Replace apache download tasks with custom ivy repository.

Hadoop ecosystem tarballs are hosted on Apache's download mirrors only instead of in maven repositories. Previously we were downloading these artifacts from a round robin of mirror endpoints, using securely obtained hashes to validate the downloaded files even from non HTTPS sources.
This PR removes those download tasks, replacing it with a custom Ivy repository backed by an HTTPS enabled apache mirror. This allows us to ensure the artifacts are securely downloaded and cached by Gradle instead of relying on task outputs like the old mirror download task.

One thing to keep in mind here is that Gradle doesn't do artifact checksum verification by default. In fact, this capability was only recently added in Gradle 6.2. As it is, this PR removes the checksum validation for these artifacts. If we want to retain that capability, we'll need to enabled checksum verification in Gradle as described here.

The dependency verification features look really useful, but I think they might be a bit out of scope. It looks like we mostly want the verification for downloads from apache mirrors, but it's a global setting that will require upkeep outside of normal project configuration. Additionally, we would need to maintain a number of unverified configurations since we rely on the local file repo in snapshot and release builds.


tests/numa: add stdout to error description on failure

What this PR does
adds stdout to the description failure on numa test when commands fails
example :
Expected success, but got an error:
    <exec.CodeExitError>:
    command terminated with exit code 2
    {
        Err: <*errors.errorString | 0xc005fddab0>{
            s: "command terminated with exit code 2",
        },
        Code: 2,
    }

Release note
None

/retest-required

/cherrypick release-1.3
/cherrypick release-1.4


is_quiet is boolean and not callable

Since self.is_quiet is boolean, self.is_quiet is not callable.

Will be fixed in another PR.


Bug — Partial HYBRID grades are not rescaled when switched between absolute and relative

When switching the grading type of a HYBRID comment from absolute to relative (or the other way around), the value is used as-is and not rescaled.
Example: +20% becomes +20pts (with a variety of broken gauges)

The other way around: +0.5pts becomes +0.5%

Expected behaviour: the value should be converted to the closest non-zero valid step (e.g., 0.25pts or 50%)

Additionally, double-clicking on either "relative" or "absolute" visually disable both.
In practice, it would seem selecting neither option defaults on "absolute".


All currencies should be hidden after activation "hide amounts" mode.

When the user activates the "hide amounts" mode by clicking on the "eye" icon, all currencies (both BEAM and BTC or USD) should be hidden.

Checked.


Sorting problem

We ran sift.js with the following code:
var sift = require('sift');
console.log(sift({}, [ 23, 42 ]));

The expected output is:
[ 23, 42 ]

The actual output is:
[ 42, 23 ]

We tracked this down to the following lines. If you comment them out, everything works as expected, but probably there's some meaning behind their existence ;-)
So, the question is how to deal with this issue properly? Any hints?
We would be happy to provide a pull request (e.g. to make sorting optional), but we wanted to make sure first that we are doing the right thing, before doing things right ;-))

@crcn The new version seems to work fine. :+1:
Is the logic that caused the original issue clear? Can you elaborate a bit on that for me?
I'm wondering if I should lock my package.json to use a specific version that I know to work (0.2.3), or if it's fairly certain that this won't happen again when trying to solve the issue that caused the original regression; i.e. I can rely on silent updates; e.g. ~0.2.

The original implementation was created on the idea that MongoDB automatically sorts results based on a search query. However, that doesn't seem to be the case, so I wouldn't expect this to be an issue again in any future version of sift.js.


[Task] Add a social banner for project

I had created a article of "Top 10 trending github repos of the week💜."
Here https://dev.to/ksengine/top-10-trending-github-repos-of-the-week-k7
I can't see your social banner there.
Please add a social banner to this project
According to github docs

Customizing your repository's social media preview
You can customize the image displayed on social media platforms when someone links to your repository.
Until you add an image, repository links expand to show basic information about the repository and the owner's avatar. Adding an image to your repository can help identify your project across various social platforms.

See https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/customizing-your-repositorys-social-media-preview
Thanks 😊

@vibhandikyash This should be fixed by project maintainers. Because it should be fixed through repo settings.

This is now done


Fix check for odi_streams

https://github.com/brightin/poms/blob/3867b2a1c7f848a8f38aec487f240126922ab3d6/lib/poms/fields.rb#L63
The regexp match does not always match the right odi streams. I think we could remove the Regexp matcher because then the check would work. (i've found occurances where there is actually an INTERNETVOD stream noted in poms, but it isn't returned in this function)

@verberktstan Do you have an example so we can produce a failing test case and fix it from there?


ui branch is broken

The ui branch is broken because of some gradle settings, eclipse can not find the asset folder.
8841ef72bade16e0effd551d7fec01f77426e1c5 and 46f38efdc88dfe9f1d80a015d9d7eb8d87003702 might be the cause

did you merge from attackUnit?
please run a "./gradlew build". Is this working? if its only a eclipse thing, the easiest way to reimport the projects

I merged the server branch, and everything is fine. "REMEMBER" force update gradle things in eclipse.

./gradlew build --refresh-dependencies
:alchemist:compileJava UP-TO-DATE
:alchemist:processResources UP-TO-DATE
:alchemist:classes UP-TO-DATE
:alchemist:jar UP-TO-DATE
:alchemist:sourcesJar UP-TO-DATE
:alchemist:assemble UP-TO-DATE
:alchemist:compileTestJava UP-TO-DATE
:alchemist:processTestResources UP-TO-DATE
:alchemist:testClasses UP-TO-DATE
:alchemist:test UP-TO-DATE
:alchemist:check UP-TO-DATE
:alchemist:build UP-TO-DATE
:core:compileJava
/home/syrcam/git/supernovae/core/src/main/java/supernovae/processor/rendering/animation/AnimationSourceProc.java:118: error: cannot find symbol
		if (!animationPrototypes.containsKey(soundPath)) {
		     ^
  symbol:   variable animationPrototypes
  location: class AnimationSourceProc
/home/syrcam/git/supernovae/core/src/main/java/supernovae/processor/rendering/animation/CommandAnimationProc.java:35: error: cannot find symbol
			start(e, source);
			         ^
  symbol:   variable source
  location: class CommandAnimationProc
/home/syrcam/git/supernovae/core/src/main/java/supernovae/processor/rendering/animation/CommandAnimationProc.java:36: error: cannot find symbol
		else if(source.isLoop())
		        ^
  symbol:   variable source
  location: class CommandAnimationProc
/home/syrcam/git/supernovae/core/src/main/java/supernovae/processor/rendering/animation/CommandAnimationProc.java:37: error: cannot find symbol
			stop(e, source);
			        ^
  symbol:   variable source
  location: class CommandAnimationProc
/home/syrcam/git/supernovae/core/src/main/java/supernovae/processor/rendering/animation/CommandAnimationProc.java:41: error: cannot find symbol
		AudioNode audio = getAnimChannel(source.getPath());
		                                       ^
  symbol:   method getPath()
  location: variable source of type AnimationSource
/home/syrcam/git/supernovae/core/src/main/java/supernovae/processor/rendering/animation/CommandAnimationProc.java:42: error: cannot find symbol
		audio.setLooping(source.isLoop());
		                       ^
  symbol:   method isLoop()
  location: variable source of type AnimationSource
/home/syrcam/git/supernovae/core/src/main/java/supernovae/processor/rendering/animation/CommandAnimationProc.java:43: error: cannot find symbol
		audio.setVolume((float)source.getVolume().getValue());
		                             ^
  symbol:   method getVolume()
  location: variable source of type AnimationSource
/home/syrcam/git/supernovae/core/src/main/java/supernovae/processor/rendering/animation/CommandAnimationProc.java:53: error: cannot find symbol
		audio.stop();
		     ^
  symbol:   method stop()
  location: variable audio of type AnimChannel
/home/syrcam/git/supernovae/core/src/main/java/supernovae/processor/rendering/animation/CommandAnimationProc.java:58: error: cannot find symbol
			sounds.put(channelName, new AudioNode(RendererPlatform.getAssetManager(), "/sounds/" + soundPath));
			                                                                             ^
  symbol:   variable soundPath
  location: class CommandAnimationProc
/home/syrcam/git/supernovae/core/src/main/java/supernovae/processor/rendering/animation/CommandAnimationProc.java:61: error: incompatible types: AudioNode cannot be converted to AnimChannel
		return sounds.get(channelName).clone();
		                                    ^
Note: /home/syrcam/git/supernovae/core/src/main/java/supernovae/filter/ParentUtils.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
10 errors
:core:compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':core:compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 2 mins 56.1 sec

On branch atttackUnit

So i didn't merge it in ui-design

Yes, currently the branch attackunit isnt compileable (my last commit broke it). Hope i can fix it today. Please dont merge it. But the original question was, is the ui-branch broken ?????
By the way i need to talk to you for concept/architecture things.

ok, I merged the ui-branch now (its pushed). But please change to jme3.1 on alchemist. I forgot to inform you about it.

Switching to jme3.1 did the trick.


Feat/sparkles

Added sparkles to the background as requested by Dylan from marketing. If HackPortal team wants me to make UI changes I will do so but it would be faster if the team handles TypeScript/file formatting preferences themselves.

Nvm this isn't ready I need to make it work on pages other than index


Migrate to go modules

allows escape $GOPATH directory
built into the go command: go build, go test, and other package-building commands add new dependencies to go.mod as needed. go mod tidy removes unused dependencies
minimal version selection algorithm

Duplicate. Done in #51


feat(AlgebraicGeometry): universally injective morphisms

Regarding the large-import, it might be worth investigating whether the imports of PullbackCarrier.lean (the newly imported file) can be reduced. But on the other hand PullbackCarrier.lean is definitely a basic file for algebraic geometry so I don't think it's a problem to import it freely.

Thanks
maintainer merge

This PR uses a range_iff_surjective lemma which was renamed in the meantime.
bors r-

bors d+


Mismatched energy levels

Hi,
Thanks for sharing this great work. I have just one question:
During the training of all models, did you face a problem of mismatched energy levels between the target and generated speech waveforms? i.e., the training evolves properly and the quality gets better over epochs but the generated signal has a lower loudness than the original one.
If yes, what do you propose to tackle this? at least from the shared samples of your trained models, I cannot find that problem.
Many thanks in advance

I did not face the problem (or I was not aware of the problem), but I heard the similar issue from several people.
Could you provide more information?

Training configuration (directly pasting config is ok)
Training data

how long, how clean
single or multi-speaker
preprocessing (especially I want to know how long silence is included)

Version of this repository

From v0.3.5 I changed the update order of the discriminator, I want to check that is related to your problem.

I checked the samples of LJSpeech.
It seems no problem. Maybe training data is related?

@kan-bayashi i got same issue in my vietnamese dataset on an old version of this repo :(. After re-compute y_hat, the problem solve. BUt i think it's not important because this is a systematic problem, just need to multiply mel spectrogram to 1.2-1.5.

@dathudeptrai Did you check both melgan and PWG?
@ahmed-fau I confirmed that if the utterances include long silence in the middle, it affects the quality. To deal with this problem, I trimmed the silence using force alignment results, which working well. If you have the text and aligner, it is worthwhile to try.

@kan-bayashi  Thanks for your prompt reply. Actually, I am training a custom model on the LJspeech dataset and found this issue occurs whatever the model/training settings I use. I was thinking that was due to the normalization of the melspectrogram (as I use a different way for normalization instead of the offline approach) but it seems that normalization is not critical to solve this.

I confirmed that if the utterances include long silence in the middle, it affects the quality. To deal with this problem, I trimmed the silence using force alignment results, which working well. If you have the text and aligner, it is worthwhile to try.

That's interesting to try. I am training my models using a slice of 1sec segments .. do you think this is too long so that silence periods will affect there?
Have you used any waveform reconstruction loss (e.g. L1 norm) between the generated and original signals just to track the waveform matching/convergence?

@kan-bayashi In the official MelGAN repo, the reconstructed signals for LJ dataset have the same problem. I am using their approach for calculating the mel spectrograms (online during the training) so that I first cut a random slice of ~ 1sec window from the audio clip (16384 for sampling rate of 16kHz) and then calculate the corresponding mel spctrogram online (with same parameters you have except the sampling rate).

OK. You did not use my repository and your question is the general topic about the training of MelGAN, right?

I am training my models using a segments of ~ 1sec long.. do you think this is too long so that silence periods will affect there?

I also use around randomly trimmed ~ 1sec for PWG and 8196 points for MelGAN.
So the length is OK. The point is that the ratio of the voiced part and silence part in the training data.

Have you used any waveform reconstruction loss (e.g. L1 norm) between the generated and original signals just to track the waveform matching/convergence?

In my repository, I always use multi-resolution STFT loss.

I also used randomly trimmed audio as the batch (the length is source ~1 sec).
So the difference is normalization. I always use mean-var normalization.
What is your normalization method?

OK. You did not use my repository and your question is the general topic about the training of MelGAN, right?

Yes, actually I find the energy levels of your samples look the same as the original compared to other MelGAN/PWGAN repos. That's why I asked here if you have some tips about that. Sorry for any unintentional confusion.

I also used randomly trimmed audio as the batch (the length is source ~1 sec).
So the difference is normalization. I always use mean-var normalization.
What is your normalization method?

I use instance normalization without affine parameter learning so that it is just normalizing the mel spectrogram to be with zero mean and unit variance but along the channel dimension instead of the batch dimension.

I use instance normalization without affine parameter learning so that it is just normalizing the mel spectrogram to be with zero mean and unit variance but along the channel dimension instead of the batch dimension.
Another difference is that my implementation first slices the 1sec audio segment then calculates its corresponding mel spectrogram during the training.

In that case, the procedure is:

randomly cut the audio (~ 1 sec)
calculate mel-spectrogram
perform mean-ver normalization for each piece of mel-spectrogram while keeping the audio waveform as original

Is my understanding correct?
If you perform the above procedure, I think the relationship between the power of the waveform and that of mel-spectrogram is different in each item in the batch.
Maybe this caused the mismatch of the power level.
In my implementation, first I calculated the mean and var over the training data, and then perform mean-var normalization. Therefore, the relationship is consistent among the training data.

I will close this issue.
If you provide the progress, it is helpful for the other users.

@kan-bayashi thanks, I was just waiting for the training.
I can confirm that your normalization approach has fixed this problem seamlessly, even without trimming the silence parts. After ~ epochs, my custom model can track the original loudness/energy levels in contrast to the old normalization approach where the levels were bounded to fixed values throughout the training although the overall quality gets higher.
The main reason I didn't use your way of normalization is that the official MelGAN repo didn't apply it and I was biased to follow their preprocessing approach. Their trained models have that problem even with higher number of epochs (~6000).
The convergence of the spectral reconstruction loss is clearly faster after normalization. The model can reach total spectral loss (sc + stft mag) of ~ 0.94 at 130 epochs, whereas the old one reaches a loss value of ~ 1.05 after 960 epochs for the LJspeech dataset.
Many thanks for your support.


Avoid including erroneous packages in the bundle at built time

See #43 for details

AS-IS
Key insights on how the build process happens with regards to espanso hub.

Build starts from a page: search doest not require the package content (repo) as oppose to the detailed page [version]. [packageName] is just a proxy to make package page URL friendly and renders the latest version.
The page fetches the packages index which is the structured information provided by the espanso hub. This is the API between the hub and the web app. The package specification indirectly dictated which object fields are optional or mandatory in the packages index.
The packages index fetch uses a cache to avoid downloading the index for each page
Each package details page ([version]) fetches the package repository (zip file) to extract the README and package code files, then renders the content. In this page we have the most source of failures. ATM the most relevant issues are:

README serialization failure: if the syntax used for the GitHub readme differs from the one supported by the third party library rendering the readme content, it may raise an error which results in a BLANK PAGE
missing homepage field: the GitHub readme may refers to assets in the package repository. Typically, but not always, the homepage field is filled with the GitHub repository link, so we use it to correctly resolve the assets statically served by the GitHub. If, something goes wrong OR the homepage field is missing OR the homepage field is not a GitHub link then it results in a MISSING DESC TAB issue.

TO-BE
The primary goal is to refactor how the web app is built so we can avoid to include failed package in the build. I think it is preferable to avoid including erroneous ones so they can be easily detected and they don't affect UX. In this way we can also tackle possible issues we are aware of as a lot of things may fail other the ones described. Afterwards, we can specifically improve the BLANK PAGE and MISSING DESC TAB issues to reduce the possibility of failures.
My current idea is to:

Extract the checks logic from the fetch package repo in a separeted routine (parse) so we can better select when to include a package or not in a build
Make the entire logic a unified pipeline over the entire application instead of per page build so we can anticipate which pages should be actually built. For example, we could avoid fetching a package repo is something is wrong at packages index level.

This is an overview, details must be further investigated, but I need to make some code changes before detailing more.

PS: because fp-ts and generally FP is friction for people wanting to help out, I am thinking to use imperative paradigm in this part rewrite. Also, I myself am not using fp-ts daily anymore

Thank you for the diagrams! 💯
Reviewing the pr 💛


Add a confirmation message when using the command /claimname

GD Version : griefdefender-1.0.2-DEV3
Minecraft Server Engine : git-Paper-146 (MC: 1.14.4)
When using the command /claimname to (re)name a claim, there's no confirmation in the chat so player may think it didn't work. You need to use /claiminfo to see if the name is correct.

Corrected in the last dev-build (need removal of the old lang file so that GD can generate a new one).


Expose clipBehavior in simple dialog

Description

Modified

adding clipBehavior property to the simpleDialog.

Earlier

There is no way to customize clipBehavior.

Related PR:
Earlier this /pull/50775 having modifications related to clipBehavior of Alert Dialog has been merged.
Issue
fixes #74414
Tests
I added tests to the dialog_test.dart that tests clipBehaviour properties.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I signed the CLA.
[x] All existing and new tests are passing.

Closing this PR for /pull/73571.

Closing this PR for /pull/73571.


Change import UI to expect import to happen out-of-band

@miltontony ready for review

Checking now displays errors again. Ready for re-review.

:+1: :cake: thanks!


dropFunction throws errors

db.dropFunction() throws errors when functions don't exist instead of just returning the number of dropped functions as 0.  This is also not documented in the API specification.  Throwing an error also makes little sense when group is set to TRUE.

This is the way the http spec works, so I guess you're matching.  Makes no sense to me, but I will simply wrap.  Would still recommend this be documented in the API spec.


[UI refactor] Remove .bind() part3 - Remove .bind for SpinButton in AxisConfigDialog, MultiICEPlot and Fairness

This PR removes .bind() for SpinButton in AxisConfigDialog, MultiICEPlot and Fairness folder. Also removes .bind() for cohortList by creating a cohortNameColumn component.
Description
The UI refactor work is to remove all .bind() functions. And this PR is part 3.
part 1 PR link: https://github.com/microsoft/responsible-ai-toolbox/pull/1523.
part 2 PR link: https://github.com/microsoft/responsible-ai-toolbox/pull/1542.
There will be following PRs to remove other .bind() functions.
The reason that we want to remove .bind() is that, a different callback is created each time the component renders. So we want to remove .bind() and set lint rule in the end to ban adding .bind() in the future.
Checklist

[ ] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

Codecov Report

Merging #1555 (f01eab5) into main (b1cf129) will increase coverage by 9.13%.
The diff coverage is n/a.

:exclamation: Current head f01eab5 differs from pull request most recent head e9e3c97. Consider uploading reports for the commit e9e3c97 to get more accurate results

@@            Coverage Diff             @@
##             main    #1555      +/-   ##
==========================================
+ Coverage   87.73%   96.87%   +9.13%
==========================================
  Files         109       12      -97
  Lines        5260      160    -5100
==========================================
- Hits         4615      155    -4460
+ Misses        645        5     -640

Flag
Coverage Δ

unittests
96.87% <ø> (+9.13%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

erroranalysis/erroranalysis/version.py

...eai/responsibleai/managers/data_balance_manager.py

...ai/databalanceanalysis/feature_balance_measures.py

rai_core_flask/rai_core_flask/__init__.py

..._flask/environments/credentialed_vm_environment.py

...ai/responsibleai/_tools/causal/causal_constants.py

erroranalysis/erroranalysis/_internal/utils.py

erroranalysis/erroranalysis/analyzer/__init__.py

...ponsibleai/responsibleai/_tools/causal/__init__.py

...ranalysis/erroranalysis/analyzer/error_analyzer.py

... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cf129...e9e3c97. Read the comment docs.


Remove all class absolute name scopes

Coverage remained the same at 0.0% when pulling a6270f179c5c8b22614b92b4e34600de475468aa on broadinstitute:tests into a39f19f6aeaa7c20f6a25a68158c8fcd2ebabfda on bodgit:master.

I'm going to convert this module to use PDK and part of that will run lint and rubocop over the module. I'll try and use this PR and then fix anything else that gets flagged.

If you have a branch with PDK changes, I can change the base on this PR to that branch so it can be merged there instead of the default branch.

I've fixed everything to the point the lint checks should pass. There are other bits that I can see are cosmetically wrong but I'd rather enhance the various lint plugins to flag them so it saves me the hassle in other modules.


Rewrite the SnapshotStore component of raft (#178)

resolves #178

Is there any other suitable storage method for SnapshotStore? Do you have any opinions?

Currently, I cannot think of any other options; we can extend it in the future if needed.


Update package version

@label-u/components 2.2.0-alpha.1 (2023-09-14)
Features

components: combine the tagTool and the textToll into one tab (a9573e3)

:tada: This PR is included in version 2.2.0-alpha.33 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


in docs, update "minions" to "nodes"

in docs, update "minions" to "nodes"
@bgrant0607 @nikhiljindal
ref #8087

LGTM

Please rebase the pr. Sorry about it.

@dchen1107 rebased, please take another look. Thanks.


hpcprof --metric-db depricated?

Has the --metric-db option been depricated?
Using it seems to produce no effect.
Using the same hpcprof command on the same hpctoolkit-measurements directory with only the --metric-db option switched between 'yes' and 'no' produces the same set of files and all files are the same (accoriding to diff).
I have tried this on metrics collected using hpcrun both with and with-out tracing (-t) enabled.
Have metric-db files/folders become these hpctrace files?
This is somewhat realated to an issue in the Hatchet project (https://github.com/LLNL/hatchet/issues/60)

The --metric-db flag is disabled for hpcprof. It should be available for hpcprof-mpi. We disabled them by default because (1) most people don't use them, and (2) they can be huge for applications that collect GPU metrics (of which there can be > 100). We are in the process of overhauling hpctoolkit to represent metrics in a sparse form rather than a dense form. Once we do that, the "metric-db" information will be collected by default once more.
hpctrace files are something completely different: they collect a sequence of call stack samples for a thread in an application. they are collected when using the -t option. they have no relation to metric-db info.

Ok that is really confusing.
The manual implies that hpcprof-mpi is simply for performing the analysis faster by performing it in parallel.
The manual also does not include anything about metric database files or the --metric-db flag.
So to get metric-db files, I have to use hpcprof-mpi? Do I have to run hpcprof-mpi with the same number of processes as the number of processes used with hpcrun?
Additionally, does this mean that hpcstruct and hpctruct -j <OMP-THREADS> are semantically different or produce different analysis?

Ok that is really confusing.
The manual implies that hpcprof-mpi is simply for performing the analysis faster by performing it in parallel.

That is generally the case. However, we found that computing the --metric-db was so slow, it was something that we didn't want to support in hpcprof as a land mine that users would inadvertantly trigger that would cause their analysis to run excruciatingly slow.

The manual also does not include anything about metric database files or the --metric-db flag.

We will correct that deficiency in the manual.  The --help message for hpcprof and hpcprof-mpi should be right. I believe we fixed that.

So to get metric-db files, I have to use hpcprof-mpi?

Yes.

Do I have to run hpcprof-mpi with the same number of processes as the number of processes used with hpcrun?

No. The number of ranks you use in hpcprof-mpi is your choice and should be based on how many files you want to analyze. For instance, you might want to use 32 MPI ranks to analyze a hpctoolkit measurement database that contains hundreds of .hpcrun files.  You can even run a single-process version of hpcprof-mpi, if you choose. How to launch hpcprof-mpi depends upon your MPI implementation and perhaps batch manager on the system you are using. For instance, you might say:
mpirun -np k hpcprof-mpi ...
or
jsrun --np k hpcprof-mpi ...
or
srun hpcprof-mpi ...
Depending upon what MPI implementation you compiled with, you may even be able to run hpcprof-mpi on a single process without using an MPI launcher. (OpenMPI supports that.)

Additionally, does this mean that hpcstruct and hpctruct -j  are semantically different or produce different analysis?

They are semantically equivalent; the -j version just runs faster.

The --help message for hpcprof and hpcprof-mpi should be right. I believe we fixed that.

I'm not sure that it is, and it seems to contradict itself.
> hpcprof --version
hpcprof: A member of HPCToolkit, version 2020.03.01-release
git branch:  detached at 2020-02-29 (94ede4e6fa1e05e6)
spack spec:  hpctoolkit<EMAIL_ADDRESS>arch=linux-ubuntu18.04-skylake/pnyrk63
install dir: [redacted]

> hpcprof --help
[... trimmed ...]
Options: Output:
  [... trimmed ...]
  --metric-db <yes|no>
                       Control whether to generate a thread-level metric
                       value database for hpcviewer scatter plots. {no}
[... trimmed ...]

> man hpcprof
[... trimmed ...]
   OPTIONS: OUTPUT
       [... trimmed ...]
       --metric-db yes | no
               If yes, generate a thread-level metric value database for hpcviewer scatter plots.  The default is yes.
[... trimmed ...]

We have a new "spack" release dated 2020.06.12. I recommend moving to the newest release. We've cleaned up some, though perhaps not all of the documentation and help messages.
As I recall, we took the --metric-db option out of hpcprof because it was already disabled and the --help message didn't indicate that. It is present for hpcprof-mpi.

This repository has moved to GitLab, please continue this issue there.


GLTF: Don't give up loading a texture if importing it fails

This fix is needed for #82455, but this PR does not completely solve that issue.
In the current master, if in the editor and the import settings are set to extract textures (default), the code in GLTFDocument will fail if it cannot extract and import a texture, resulting in that texture being missing from the model.
This PR is a fairly straightforward change: If we can't import, just load it uncompressed from the Image resource already loaded in memory, instead of giving up and inserting a blank texture.
More details: For each case where the image cannot be imported from res://, instead of setting a blank texture, use the loaded image. The return in this function now only happens after successful cases, so as a fallback, it will drop down to the bottom of the function, the uncompressed code. This is the same as if performing a runtime import. When writing this code I was curious if it would work if the project is exported, and actually yes, it does work.
As a bonus, I also added some text to two err_fail_conds in EditorFileSystem to make them distinct from each other.

In my opinion p_state->base_path.is_empty() case should assign a name (such as a number) and extract it, not load it uncompressed.
this should be the same as a glb file with embedded unnamed textures, which also should get extracted.

@lyuma I'm assuming you mean the p_image->get_name().is_empty() condition. If the base path is empty, we can't extract, because we have nowhere to save it. I've updated the PR. Old PR code:
		if (p_state->base_path.is_empty()) {
			WARN_PRINT("glTF: Couldn't extract image because the base path is empty. It will be loaded directly instead, uncompressed.");
		} else if (p_image->get_name().is_empty()) {
			WARN_PRINT(vformat("glTF: Image index '%d' couldn't be named. This cannot be saved to a file. It will be loaded directly instead, uncompressed.", p_index));
		} else {
			bool must_import = true;
			// and so on

Code in this PR with your suggestion:
		if (p_state->base_path.is_empty()) {
			WARN_PRINT("glTF: Couldn't extract image because the base path is empty. It will be loaded directly instead, uncompressed.");
		} else {
			if (p_image->get_name().is_empty()) {
				WARN_PRINT(vformat("glTF: Image index '%d' did not have a name. It will be automatically given a name based on its index.", p_index));
				p_image->set_name(itos(p_index));
			}
			bool must_import = true;
			// and so on

Note that this is technically a separate issue, but it's the same part of the code, so I'm personally good with fixing 2 issues with one PR as long as that's good with you.

Updated the PR to have a second commit which adds extract_path and extract_prefix settings, used by the Blender importer. This allows textures extracted from the glTF file to be placed next to the .blend file, as suggested by @lyuma in Discord messages.

Thanks!

This has a surprising (at least to me) side effect - if you're not using embedded textures in blend files your textures will get duplicated.
model.blend pointing to on-disk texture.png will also create model_texture.png
Is that working as intended?
It feels like there are three options

gltf with embedded images -> should be saved to disk
gltf pointing to textures within res:// directory -> should be skipped
gltf pointing to textures outside res:// directory -> should be saved to disk

@demolke True. If needed, we can revert the second commit in this PR, which will instead load the image directly instead of importing it in this case. However, I think really this is highlighting an existing problem - wouldn't this mean that a non-embedded texture from a Blend file isn't being used? How can we detect and use these textures?

wouldn't this mean that a non-embedded texture from a Blend file isn't being used? How can we detect and use these textures?

I'm not sure what you mean - I only went through the code superficially so don't see how it detects if the original texture.png is already imported/used. The part with md5 only checks for the prefixed model_texture.png.import so that will not help with de-duplication.
This project shows that after import you will get model_texture.png even though texture.png has already been imported
nonembed.zip

I spent some time poking at this and I think this https://github.com/godotengine/godot/pull/98909 addresses most of the use cases


Fixing crash of QnAMakerDialog with multiple services

Fixing https://github.com/Microsoft/BotBuilder-CognitiveServices/issues/99

Hi there, would this PR be merged? Or should I close it?

Thank you for opening an issue against the Bot Framework Cognitive Services repo. As part of the Bot Framework v4 release, we’ve moved all the Luis and QnA work to platform SDK repo. We will continue to support and offer maintenance updates via this repo.
From now on, https://github.com/Microsoft/botframework-sdk repo will be used as hub, with pointers to all the different SDK languages, tools and samples repos.
As part of this restructuring, we are closing all tickets in this repo.
For defects or feature requests, please create a new issue in the Bot Framework repo found here:
https://github.com/Microsoft/botframework-sdk/issues
For product behavior, how-to, or general understanding questions, please use Stackoverflow.
https://stackoverflow.com/search?q=bot+framework
Thank you.
The Bot Framework Team


Allow ES client to connect to managed clusters

Depending on Elasticsearch security settings the current implementation can't ping the cluster. Especially true for managed ES.
This bugfix allows data to be written to such clusters. (Tested on real managed cluster.)

Thanks!


Add: render type to fix typescript error

In this PR

Adding a render type to the QRCode Class to remove the following error in tsx files:

@mercpls thank you!

@mercpls thank you!

Happy to help!


feat(.github/workflows): add immutable image tag for releases

Description:
Makes image tags immutable for releases, github actions will not override image tags if it exists, and resolves #1797
Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Performance            [ ]
Other                  [x ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
no

Codecov Report

Merging #2352 (50ad7c8) into main (a0fd215) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2352      +/-   ##
==========================================
- Coverage   57.36%   57.34%   -0.02%
==========================================
  Files         149      149
  Lines        6654     6654
==========================================
- Hits         3817     3816       -1
- Misses       2832     2833       +1
  Partials        5        5

Impacted Files
Coverage Δ

pkg/envoy/route/config.go
95.23% <0.00%> (-0.80%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98d4675...1d63ba9. Read the comment docs.

Codecov Report

Merging #2352 (50ad7c8) into main (a0fd215) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2352      +/-   ##
==========================================
- Coverage   57.36%   57.34%   -0.02%
==========================================
  Files         149      149
  Lines        6654     6654
==========================================
- Hits         3817     3816       -1
- Misses       2832     2833       +1
  Partials        5        5

Impacted Files
Coverage Δ

pkg/envoy/route/config.go
95.23% <0.00%> (-0.80%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98d4675...1d63ba9. Read the comment docs.


Improve overflowing widgets layout

Fixes #12794 and #13004
Some widgets specify a fixed width via CSS, like the suggest widget. The overflowing code currently in place works well with those.
Others want to be as wide as their content is, up to a certain point. Most others are, namely the hover and parameter hints. This behaviour is broken currently because the text within these widgets wrap at the right-most point of their closer layout parent. We should let these widgets stretch as much as they want to.
Some widgets have a strange layout, while others definitely break. 😨
This PR places the overflowing widgets in a fixed container, stretched to fill the whole window.
I gave it a good smoke test around Code and the Monaco editor, but I need a quick review from your @alexandrudima just to be sure I'm not missing anything.

Coverage decreased (-0.001%) to 61.227% when pulling 8b9194f1e28079fd6b81f400f68b3ddbb688f202 on joaomoreno:overflowing-widgets into cd6fb060c187c0a199954d1fe19704a164827761 on Microsoft:master.

@alexandrudima Suggests to use a context view option to the editor instead of a fixed dom node.

@alexandrudima I have a different proposal. I'm not too keen on having users implement some context view element just so they can get wrapping overflowing widgets.
Using pointer-events is not good since IE11 was the first IE version to support them. So we can't position: fixed the widget wrapper... but we can do that to each widget. What do you think?

I implemented what I mentioned on my last comment.

This also fixes #9882

Tested in Chrome, Firefox, IE11, IE10 and IE9.

@alexandrudima Please take a good look here.

@joaomoreno :-1:
Sorry, but you cannot make all content widgets position:fixed, that boat has shipped. The content widgets are public editor API and there can be any number of third-party content widgets that are broken by this. Especially content widgets that don't appear and disappear quickly (such as hover / suggestions). I don't track any scrolling done in any of my containers and will not repaint, therefore will not relayout any content widgets when you scroll in a container.
e.g.

I suggest you add a flag on the content widgets you have in mind (perhaps only for hover and intellisense?) and only if this flag is present you begin to do the new behaviour (similar to allowEditorOverflow). You can then have the old behaviour and the new position:fixed behaviour.
Moreover, there are remaining issues even with the content widgets we ship (mouse wheel scroll):
file:///C:/Alex/src/monaco-editor/test/mouse-scrollable-body.html?editor=dev

After discussing with @alexandrudima, here are the conclusions:

All our widgets which set allowEditorOverflow would fit into this fixed category, so no need to introduce a new flag.
We should introduce a fixedOverflowWidgets setting which, by default, preserves the old behaviour and lets us switch to a fixed displaying of widgets in Code.


Using vdom-to-html doesn't work (returns empty string)

Hi, using node v4.2.1 and vdom-to-html with mercury doesn't work.
Don't know if this is related but I noticed that:
require('virtual-dom/vnode/vnode'); // works
require('vtree/vnode'); // doesn't work
For example:
var toHTML = require('vdom-to-html');
var h = require('mercury').h;
toHTML(h('p', 'Hello')); // Returns nothing

Am I missing something obvious? Thanks

@DominicTobias: vdom-to-html uses virtual-dom 2.0.0 while Mercury depends on 1.3.0, and v2 has breaking changes. You can make your own local mercury.js with dependencies on ^2.0.0, or just import the virtual-dom dependencies directly. Either way, you'll want to depend on just one version, so your build artifact doesn't duplicate code.

Thanks I'll just use 1.2.5 @ vdom-to-html

Is there any plan to move Mercury to virtual-dom 2.x ?

If there is a list of things that need to be done to upgrayedd mercury, I'll be happy to chip in and knock some of them out.
Please let me know how I can help.

Same here, I'd be happy to take on some work related to this.

I'd love to see this project advance, especially in regards to some of the points mentioned in the standing challenges thread  -the most crucial of which I think is the having a formal component interface for people to design reusable components around.


[firestore-genai-chatbot]: wildcards in Firestore collection path not working

[READ] Step 1: Are you in the right place?
Issues filed here should be about bugs for a specific extension in this repository.
If you have a general question, need help debugging, or fall into some
other category use one of these other channels:

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
To file a bug against the Firebase Extensions platform, or for an issue affecting multiple extensions, please reach out to
Firebase support directly.

[REQUIRED] Step 2: Describe your configuration

Extension name: firestore-genai-chatbot
Extension version: 0.0.9
Configuration values (redact info where appropriate):

Firestore Collection Path : '' or 'conversations.'

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:

install extension with '*' or 'conversations.*' as value for Firestore Collection Path variable
create a collection and a document with a prompt field
the cloud function is not triggered and no response from gemini is added to the document

Expected result
As written in the documentation : "The collection path also supports wildcards, so you can trigger the extension on multiple collections, each with their own private conversation history.", the added document with a "prompt" property should trigger the gemini API
Actual result
Nothing happened

Hi @bengeois! Firestore triggers have a special wildcard notation, i.e. collection/{wildcard} instead of collection/*.
Please refer to this document talking about Firestore triggers and possible collection wildcards.
Let me know if this helps!

Hi @jauntybrain,
Thanks for providing clarification. I've tried with {collection} and it works.
The link you shared seems quite helpful.
This is not an issue anymore.


[BUG] MetaPhlan3 produces no bowtie2out

Describe the bug
metaphlan3 does not produce bowtie2out with FastQ input, nor it produces an error report. However, if I stop the command mid run, a bowtie2out is produced, and taxonomic classification is correct. Likely, MetaPhlan is removing the file at the end of execution, for some reason
To Reproduce
metaphlan path/to/R1.fq,path/to/R2.fq --bowtie2out path/to/mg.bowtie2.bz2 --nproc 14 --input_type fastq
Screenshots
Output directory (path/to/) is just empty
Platform (please complete the following information):

Version: 3.0.5
Download source: conda install -c conda-forge -c bioconda metaphlan=3

If you provide an output path via the -o parameter, does it generate a report? Can you see from top/htop if bowtie2 is running?

If first ran with the -o, and the result was the same. Then I tried splitting into two command, first generate the bowtie2out than use that as input to use the -o, but bowtie2out was not there

Tested now observing htop, and bowtie2 runs to the end, with the alignment result growing, until it vanishes

I'm sorry but I cannot reproduce your issue. In both cases, even if bowtie2out is not specified, the bowtie2out should be generated.

You cannot reproduce it in a clean environment? If you could provide me the conda list output, I could track the dependency that might be screwing this

Yes, that's right. Here attached the conda list output. Otherwise, can you upload somewhere the input files so I can do more testing?
conda_list.txt


feat: extend shake to remove undefined or filtered values from nested objects

Modify shake to also remove undefined or filtered values from nested objects. If the resulting nested object is empty, it is also removed.
Checklist

[x] Changes are covered by tests if behavior has been changed or added
[x] Tests have 100% coverage
[x] If code changes were made, the version in package.json has been bumped (matching semver)
[x] If code changes were made, the yarn build command has been run and to update the cdn directory
[x] If code changes were made, the documentation (in the /docs directory) has been updated

Resolves
Resolves #252.

@rayepps Let me know what you think of the approach of making it remove nested undefined or filtered values by default without giving the option of opting out of this behavior. To me, it seems more natural that this be the default behavior.

Hi, I'm also interested in having deepShake, is this on the roadmap @rayepps?


multi deploy_contract fails

I try to deploy 2 token contracts and a contract that uses tokens but i get this error.
test function : https://github.com/iamreadyi/synthetic_staking_lottery_cairo/blob/main/tests/test_staking.cairo#L26
repo :
https://github.com/iamreadyi/synthetic_staking_lottery_cairo
error : protostar test
14:10:19 [INFO] Collected 1 suite, and 1 test case (0.159 s)
[FAIL] tests/test_staking.cairo test_staking_contract (time=9.59s)
[type] TRANSACTION_FAILED
[code] 43
[details]:
tests/test_staking.cairo:34:5: Error at pc=0:79:
Got an exception while executing a hint.
%{ ids.staking_token_address = deploy_contract("./src/staking_token.cairo").contract_address %}
^************************************************************************^
Cairo traceback (most recent call last):
tests/test_staking.cairo:26:6: (pc=0:110)
func test_staking_contract{syscall_ptr: felt, range_check_ptr, pedersen_ptr: HashBuiltin}() {
^^
Error in the called contract (0x4b4bc243d1405b953caa458bff8fb9adac456a63def323dc71d585e4d3751ad):
Error at pc=0:1220:
An ASSERT_EQ instruction failed: 10:1 != 10:0.
14:10:32 [INFO] Test suites: 1 failed, 1 total
14:10:32 [INFO] Tests:       1 failed, 1 total
14:10:32 [INFO] Seed:<PHONE_NUMBER>
14:10:32 [INFO] Execution time: 14.26 s

staking_token expects owner argument


feat: MiniProgram SDK supports metric analysis

Fix #166
Changes proposed in this pull request:

Update user guide of Miniprogram SDK
Update documetation of MiniProgram SDK

Codecov Report

Merging #218 (aaf41f7) into main (c4c7c40) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head aaf41f7 differs from pull request most recent head 20863a6. Consider uploading reports for the commit 20863a6 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main     #218   +/-   ##
=========================================
  Coverage     64.82%   64.82%
  Complexity      541      541
=========================================
  Files           164      164
  Lines          4804     4804
  Branches        614      614
=========================================
  Hits           3114     3114
  Misses         1537     1537
  Partials        153      153

Flag
Coverage Δ

*Carryforward flag

api_ut
54.10% <ø> (ø)

Carriedforward from 025679f

server
68.86% <ø> (ø)

Carriedforward from 025679f

ui
94.53% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.


Add PyPy 3 to travis build matrix

'pypy3' on Travis passes all tests without modification.
Travis uses the following PyPy 3k version currently:
Python 3.2.5 (b2091e973da6, Oct 19 2014, 18:29:55)
[PyPy 2.4.0 with GCC 4.6.3]

Thank you!
However, please don't take this as a hint that either itsdangerous (or even Flask/Werkzeug) are going to support PyPy 3. If it turns out to be impossible to support (due to being Python 3.2, and not-really 3.3), please understand that we'll have to remove it again.

Understood, and no worries at all.  I don't have any critical need for this personally, but since it does pass tests, and thus maybe works correctly, it is worth testing against if only to know when it does break.


Enable In-app updates for WPF Applications (feature parity with HockeyApp)

Describe the solution you'd like
We would like to use AppCenter to provide in-app notifications of our WPF applications.
On Startup, or on demand (e.g. from a "Check For Updates" menu item) we should be able to check for new public releases of our application, then have these automatically downloaded and the installation started. We distribute our applications using MSI or sometimes setup.exe and use standard Windows Installer deployments.
Describe alternatives you've considered
I see that Winsparkle is now supported for AppCenter, but native built in support using Appcenter.Distribute would be much more preferable as it keeps behaviour the same as for mobile app development.

Thank you for requesting in-app updates for WPF apps. My colleague will take it into consideration, in the meanwhile, we evaluate feature request by reactions. If we get enough :+1: it will be considered for our backlog.

Can we keep our WPF applications on HockeyApp until this feature is added?
I use the call HockeyClient.Current.CheckforUpdatesAsync(), this will stop working if our apps transition to Appcenter.

Support for Sparkle and therefore WinSparkle feeds is 'closed' #202
I am now investigating how to add WinSparkle and integrate it into the App Center workflow.

This would be super useful


torch_butterfly has CUDA version 0.0... incompatibility

Hi
I ran python setup.py install
then:
python
import torch_butterfly
Traceback (most recent call last):
File "", line 1, in
File "/home/nailon/miniconda3/envs/py38/lib/python3.8/site-packages/torch_butterfly-0.0.0-py3.8-linux-x86_64.egg/torch_butterfly/init.py", line 33, in
check_cuda_version()
File "/home/nailon/miniconda3/envs/py38/lib/python3.8/site-packages/torch_butterfly-0.0.0-py3.8-linux-x86_64.egg/torch_butterfly/init.py", line 26, in check_cuda_version
raise RuntimeError(
RuntimeError: Detected that PyTorch and torch_butterfly were compiled with different CUDA versions. PyTorch has CUDA version 10.2 and torch_butterfly has CUDA version 0.0. Please reinstall the torch_butterfly that matches your PyTorch install.

Anybody?

Issue has been resolved through email.

Hi
I ran python setup.py install
then:
python
import torch_butterfly
And got:
RuntimeError: Detected that PyTorch and torch_butterfly were compiled with different CUDA versions. PyTorch has CUDA version 11.3 and torch_butterfly has CUDA version 0.0. Please reinstall the torch_butterfly that matches your PyTorch install

Could you let me know how can I resolve it?

Running into a similar issue (PyTorch has CUDA version 11.1 and torch_butterfly has CUDA version 11.2).
Would like to hear how you resolved this for the previous issue?

@tridao @ThomasBoot @gunikavashisht13472
Were you able to resolve this issue? If yes, can you please share how you went about it


Consultation clearing command

Implement clear consultation command
Closes #79

Codecov Report
Base: 58.97% // Head: 59.12% // Increases project coverage by +0.14% :tada:

Coverage data is based on head (b94d2ae) compared to base (d5aade1).
Patch coverage: 90.90% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
+ Coverage     58.97%   59.12%   +0.14%
- Complexity      612      617       +5
============================================
  Files           129      130       +1
  Lines          2406     2417      +11
  Branches        288      288
============================================
+ Hits           1419     1429      +10
- Misses          892      893       +1
  Partials         95       95

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/AddressBookParser.java
60.00% <0.00%> (-2.50%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...ommands/consultation/ClearConsultationCommand.java
100.00% <100.00%> (ø)

src/main/java/seedu/address/model/AddressBook.java
61.44% <100.00%> (+0.95%)
:arrow_up:

...rc/main/java/seedu/address/model/ModelManager.java
64.13% <100.00%> (+0.79%)
:arrow_up:

...ess/model/consultation/UniqueConsultationList.java
58.82% <100.00%> (+2.57%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Unused


fix: if everything but our fin was acked success there fin doesn't matter

This is so clients which support one way acks close successfully.
In this case we are the data sender so if they have acked everything but our fin we will count them as successful. one way acked implementations wouldn't send us a fin so I removed that check for their fin.
With this change at least trace_gossip won't read fluffy transfers as fails and keep trying to resend the content.
This doesn't delay the recv getting the content in anyway as this is a sender's side change.
Of course perfect interop would be nice, but there is no increased delay on receiving data. The only delay is closing the connection to the sender, which can slow down the trace_gossip process, but really isn't that big of a deal

Closing this as after debugging other Trin issues

with these changes. It looks like fluffy doesn't finish due to timeout, but due to fluffy sending us a reset request because it already closed. I totally forget that being a thing after I fixed us not handling the reset requests. But that is very interesting nontheless!!!!!!!!


⚠ Bofrost.es has degraded performance

In 2c5080a, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1878 ms

Resolved: Bofrost.es performance has improved in d89635d after 13 minutes.


Dynatrace operator in operator hub not automatically updating

Describe the bug
After 0.10.2 was released it does not automatically upgrade from 0.10.1 to 0.10.2. The Update channel is "Alpha" and update approval is set to "Automatic"
This also happened from 0.9.X to 0.10.1 as well.
Running on Openshift 4.10.41/47 (multiple clusters with same issue)
The 0.10.2 update is available in operator hub as a "Certified" update.
Even if i change the Update approval to manual i do not get an option to upgrade.
Inn the case from 0.9.X to 0.10.1 i had to uninstall the operator and install it again, but this is not good since it then requires to reinstall the dynakube.

Thank you for opening a Dynatrace Operator Issue. We've identified and tagged the issue as a "Support request".
Dynatrace responds to requests like these via Dynatrace ONE support rather than Github. This helps our team respond as quickly as possible using the support team's tools and procedures.
Thanks for your help!


Extend functionality to sync by service account name to SPCs

https://azure.github.io/secrets-store-csi-driver-provider-azure/docs/configurations/identity-access-modes/workload-identity-mode/

<EMAIL_ADDRESS>

This will not be implemented - rather waiting for Azure to implement same workflow as AWS and GCP meaning they get the client id data directly from the service account. https://github.com/Azure/secrets-store-csi-driver-provider-azure/issues/1316


Automatic Indentation error in Python

Issue Type: Bug
On typing in the following in a python file:
for line in data[1:]:
The next line should be automatically indented by 1 tab (or equivalent) as per python's requirement but instead it starts from the left.
VS Code version: Code 1.23.1 (d0182c3417d225529c6d5ad24b7572815d0de9ac, 2018-05-10T16:04:33.747Z)
OS version: Linux x64 4.13.0-41-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz (4 x 2183)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: unavailable_softwarevideo_encode: enabledvpx_decode: unavailable_softwarewebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
7.71GB (2.21GB free)

Process Argv
/usr/share/code/code --unity-launch

Screen Reader
no

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

vscode-markdownlint
Dav
0.17.0

composer-support-client
Hyp
0.19.1

latex-workshop
Jam
5.5.0

gitlens
eam
8.3.2

language-haskell
jus
2.5.0

python
ms-
2018.4.0

csharp
ms-
1.15.2

grammarkdown-language
rbu
0.4.3

Not sure if this is extension or auto indent on our side

I will check.

This bug does not occur without extensions. So, i guess one of them might have messed up.

Yup, with the Python extension given by Microsoft, this indentation bug pops up.


Introduce Virtus::InstanceMethods#set_attributes.

This is a private method that permits bypassing the privacy of attribute writer methods.
Specifically, I want to be able to set all attributes in #initialize, but have private writers to prevent mutation after that.

To be clear, I know this pull request won't pass muster as it stands: it lacks unit spec coverage and docs. I'm opening it early to solicit feedback about the general idea.

Any thoughts about providing a version of #attributes= that allows setting attributes with private writers?

In general I find having a method that accepts a boolean flag as a kind of code smell. It's more formally known as Control Coupling.
I know in this case the code branch is happening further down in another place, specifically inside a ruby-provided API, that doesn't mean that it's a good API :P
However, I'm not against a #set method that allows the private attributes to be set, as long as it was private itself. The #attributes= method could even delegate to it as long as it uses Hash#reject to filter out the non-public attributes.
I might even recommend having it so #set just does what it's told rather than using #respond_to? and that it should raise an exception if a method is called that does not exist (i.e. just call the method and let the ruby exception bubble up). If I was using it inside a private part of my code I wouldn't want typo's "swallowed up" by the system.

I should follow-up with a bit of a hesitation at making setting private accessors less obvious and "prettier". I would want those kind of things to stand-out in most cases, and I wonder if this might make it easier for a reader to gloss over important pieces of code.

Agreed on all points. That leaves me with a couple of questions:
In Virtus::InstanceMethods#attributes, Attributes with private readers can be handled easily (eg., by adding a Attribute#private_reader? query API).
However, Virtus::InstanceMethods#attributes= isn't so easy: the attributes arg might have string keys, which means a naive usage of Hash#reject with a check for inclusion via AttributeSet#[] won't work (assuming we want to avoid calling #to_sym on uncontrolled input). We could iterate over the AttributeSet and only call setters for Attributes with non-private readers, but that breaks API compatibility with ActiveRecord wherein you can call arbitrary setter methods via #attributes=.
I prefer the latter approach, but it has the aforementioned characteristic (potential downside) of a narrower API than AR. To clarify, I'm proposing:
module Virtus::InstanceMethods
  def attributes=(attributes)
    self.class.attributes.each do |attribute|
      next if attribute.private_writer?
      attribute_value = attributes.fetch(attribute.name) { attributes.fetch(attribute.name.to_s, nil) }
      __send__("#{attribute_name}=", attribute_value || __send__(attribute.name))
    end
  end
end

@emmanuel good question. I think it's ok to restrict #attributes= to only set attributes. In the absence of broad user feedback it seems like the safest approach, and it kind of makes sense. It also encourages things that people want to be treated as attributes be declared in the class, which I can't see any downside to.
It's actually kind of funny that object.attributes = attributes sets things that aren't attributes. It probably should've been named something else given that it has expanded behaviour. (although I guess with our proposal, its behaviour will now align with the name, which is a good thing)

@emmanuel most of this looks great. The only question I have is why #set_attributes accepts the include_private argument, yet doesn't use it for anything.
I thought we were going to make it so that #attributes= called #set_attributes with a subset of the attributes that are non-private, and that calling #set_attributes directly it would just do what it was told?
Also, I wouldn't be againast naming #set_attributes as #set, although that's probably up for discussion on whether or not it makes the private interface "too pretty", thus making it more likely for it to be (ab)used without bringing attention to the fact that it is kind of dangerous.

@emmanuel most of this looks great. The only question I have is why #set_attributes accepts the include_private argument, yet doesn't use it for anything.
I thought we were going to make it so that #attributes= called #set_attributes with a subset of the attributes that are non-private, and that calling #set_attributes directly it would just do what it was told?
Also, I wouldn't be againast naming #set_attributes as #set, although that's probably up for discussion on whether or not it makes the private interface "too pretty", thus making it more likely for it to be (ab)used without bringing attention to the fact that it is kind of dangerous.

Continuing my thoughts, I was thinking the implementation would be something like this:
def attributes=(attribute_values)
  attributes = self.class.attributes
  set(attribute_values.select { |name, _value|
    attribute = attributes[name]
    attribute && !attribute.private_writer?
  })
end

private

def set(attribute_values)
  attribute_values.each { |pair| attribute_set(*pair) }
end

Note that Hash#select returns an Array of Array objects, but Enumerable#each yields the same name/value pair as a Hash, so the implementation of #set should work with both.

Continuing my thoughts, I was thinking the implementation would be something like this:
def attributes=(attribute_values)
  attributes = self.class.attributes
  set(attribute_values.select { |name, _value|
    attribute = attributes[name]
    attribute && !attribute.private_writer?
  })
end

private

def set(attribute_values)
  attribute_values.each { |pair| attribute_set(*pair) }
end

Note that Hash#select returns an Array of Array objects, but Enumerable#each yields the same name/value pair as a Hash, so the implementation of #set should work with both.

BTW, even if we decide against #set, we may want to consider something other than #set_attributes given that we already have #attribute_set. It strikes me as a bit inconsistent in the naming.

BTW, even if we decide against #set, we may want to consider something other than #set_attributes given that we already have #attribute_set. It strikes me as a bit inconsistent in the naming.

How about #attributes_set to be consistent with #attribute_set? This would be consistent...on the other hand both names look so similar that they can be confusing.

How about #attributes_set to be consistent with #attribute_set? This would be consistent...on the other hand both names look so similar that they can be confusing.

@solnic I thought about that, but yeah, the names are so similar that I think it would be too easy to confuse them.

@solnic I thought about that, but yeah, the names are so similar that I think it would be too easy to confuse them.

@dkubb thanks for pointing out the unused include_private arg, I forgot to remove it. I updated the implementations of InstanceMethods#attributes= and InstanceMethods#set_attributes per your recommendation.
I'm not too keen on #set, so I also renamed #attribute_set to #set_attribute and #attribute_get to #get_attribute (to correspond with #set_attributes). My feeling is that putting the verb before the object is clearer (eg., get_* and set_*), but I isolated the rename to a separate commit in the event that this is not desirable.

@dkubb thanks for pointing out the unused include_private arg, I forgot to remove it. I updated the implementations of InstanceMethods#attributes= and InstanceMethods#set_attributes per your recommendation.
I'm not too keen on #set, so I also renamed #attribute_set to #set_attribute and #attribute_get to #get_attribute (to correspond with #set_attributes). My feeling is that putting the verb before the object is clearer (eg., get_* and set_*), but I isolated the rename to a separate commit in the event that this is not desirable.

@emmanuel @dkubb how about renaming #set_attribute and #get_attribute to just #set and #get? Shorter...but maybe less obvious and too common? WDYT?

Is it ready to merge it in? We should finish it prior to merging in ValueObject! :)

@emmanuel I agree with your naming convention, it's easier to read. I only don't like #set_attribute vs #set_attributes cause both look almost the same. On the other hand, it's a private method, so let's leave it now.
Are you going to clean up the merge so it applies w/o conflicts?

I'm not a contributor on the repo, so I can't see that there are merge conflicts... but I can rebase this branch on top of master, which should take care of things.

@solnic agreed. It's still marked as @api private so if people are using it directly they have to expect we could change the name at any time.
(Also maybe it's @emmanuel's intention that it be @api public while still having private visibility. If that's so, then we should probably get clear on the method name before we publish the API)

@emmanuel refresh the page :)

OK, rebased on top of current master. All specs pass, and rake ci shows some complaints from reek (which look like false positives), but yardstick and flay are content (I did bump up the flay threshold).
I'm merging this in.


CorrDiff: Enhance configs, remove custom module.py

Modulus Pull Request
closes https://github.com/NVIDIA/modulus/issues/367
Description

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[x] An issue is linked to this pull request.

Dependencies

/blossom-ci


[feature request] map parent attributes, events binding of component to child element within the component

Using the example in https://vuejs.org/guide/components.html#Form-Input-Components-using-Custom-Events.

{{ message }}

  <my-input
    label="Message"
    v-model="message"
  ></my-input>

Vue.component('my-input', {
  template: '\

\
      {{ label }}:\
      <input v-bind:id="randomId" v-bind:value="value" v-on:input="onInput">\

\
  ',
  props: ['value', 'label'],
  data: function () {
    return {
      randomId: 'input-' + Math.random()
    }
  },
  methods: {
    onInput: function (event) {
      this.$emit('input', event.target.value)
    }
  },
})
new Vue({
  el: '#v-model-example',
  data: {
    message: 'hello'
  }
})

What if i wanted to add HTML attributes such as "placeholder" to the input box without adding "placeholder" as a new prop
or
I wanted to bind an "keypress" event to the input box without adding the $emit('keypress') in the component , like following
<my-input value="test value" label="test label" placeholder="test placeholder" @keypress="doSomething"></my-input>
Currently the result will be

   test label:\
    <input id="someRandomId" value="test value">

you can see that the placeholder attribute and the keypress event are always attached to the root element (which is the form-group div) instead of the <input> element. I hope you can provide a new feature to route/map the event binding/attributes attachment to a specific child element instead of always the root element, so that it will be like the following:

   test label:
    <input id="someRandomId" value="test value" placeholder="test placeholder" onclick="doSomething">

What if i wanted to add HTML attributes such as "placeholder" to the input box without adding "placeholder" as a new prop
or
I wanted to bind an "keypress" event to the input box without adding the $emit('keypress') in the component , like following

That's against the the basic ideas of component properties and parent-child communication.
Please explicitly declare the props you need and events to emit.

That's against the the basic ideas of component properties and parent-child communication.
Please explicitly declare the props you need and events to emit.

If this is not technically impossible, I think this is a must feature. Sometimes, our main DOM element isn't the highest element in the component template. And we can't know which attributes will be added to the component. We just want all the attributes to be transferred to the marked element.
Can you rethink about this feature please? This will help many framework developers.

I don't think implicitly routing html attributes and event bindings to internal html nodes is a good idea at all. In fact, I can see such behavior causing major headaches. Implicit bindings are never a good idea.
In my opinion, trying to pass html attributes directly to a component without declaring them as props is also a terrible idea. Components are not html nodes, they are components and should be treated as such. If you want an html node, write an html node.
Your use case is easily solvable by simply explicitly declaring the attributes as props and populating them in the component. You could also have a computed value that will return a default in the event one of the props is undefined.


Check for FORMS_USE_HTML5 on the admin instead of the model

Fixes #1399.
I decided to go with the the exclude attribute since this is an inline model admin. It's let's verbose too and if new fields are added to the Field model, they will just show up without having to explicitly include them.
I tested with modeltranslation enabled and it works fine.

Nice one, thanks Ed.


Discarding Numerical values

model is discarding numerical values both in model language and in numeric values

Thanks for reporting. Can you please give atleast an example, as well as show a snippet of how you're running?


issue with lazy sync functionality

Background:
The vendir.yml file contains the configuration lazy: true. Upon running vendir sync on a clean project, the project was updated with the vendor directory and all dependencies, along with the vendir.lock.yaml. However, running vendir sync a second time resulted in the complete clearance of the vendor/ directory.
sample vendir.yml :
apiVersion: vendir.k14s.io/v1alpha1
kind: Config
directories:
- path: vendor
  contents:
  - path: dir
    lazy: true
    directory:
      path: ./some-content

What I expected:
I expected the vendir sync to skip populating the vendor directory in the second run without clearing the directory.
Environment:
Vendir version: 0.36.0
Operating System: Photon 3/5 or Ubuntu

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

@Sanrahul02 Thank you for reporting this.


cmake: add generic clang/gcc presets

Subject
We are missing a "generic" gcc-CMAKE_BUILD_TYPE preset which would help us when starting support newer platforms with newer gcc/clang releases.
Developer checklist (address before review)

[ ] Changelog.md updated
[ ] Prepared update for depending repositories
[ ] Documentation updated (public API changes only)
[ ] API docstrings updated (public API changes only)
[ ] Rebase → commit history clean
[ ] Squash and merge → proper PR title

Duplicate of https://github.com/vectorgrp/sil-kit/pull/74


Add ScopeGuard to support users with restricted content scopes

attachedPageTreeNodeId is not a required parameter, so it can be validated.
The SubjectEntity decorator is ment to be used for other use cases as well:

scope dependent build trigger (to rebuild only affected scope)
user action log

TODO:

[x] page query: this doesn't work, as it has no relation to pageTreeNode (is this query used anywhere?)
[x] saveFooter mutation: move scope out of input into own arg (so it can be validated)
[x] newsBySlug query: add scope argument
[ ] pages query: add scope argument (used in dashboard, needs multiple scopes?)
[x] SubjectEntity decorator: type entity better
[x] Add scope guard into library
[x] get scope from parent row using something like @Scoped(entity => entity.parent.scope) (at entity class)
[x] @Scoped fix typings (don't use  as unknown as Record<string, string>)
[x] convert CurrentUser to an interface
[x] think about an application specific CurrentUser
[x] BearerTokenStrategy: allow idp user -> CurrentUser conversion application specific override
[x] find a way to avoid manual DI in main.ts (where ScopeGuard is instanciated)
[x] (?) Don't use Record<string, string> for scope, use Record<string, unknown> or so, let the application decide what's in there

Later, not in this PR:

[x] implement admin side (to only show possible scopes to the user)
[ ] implement something more flexible that supports something like that: @SubjectEntity(Product, EntityLoader)

@johnnyomair I changed ContentScope now from Record<string, string> to a complete custom interface, what do you think?


missing Windows binaries for stable INLA in R 4.0

The stable INLA repository which I reference from my package to install INLA currently does not contain any Windows binaries for R 4.0. The testing repository does provide such Windows binaries. Maybe one of those binaries could be copied over to stable?

Yes.  Soon
—
Håvard Rue
Professor of Statistics
Statistics Program, CEMSE Division
King Abdullah University of Science and Technology
Thuwal 23955-6900, Saudi Arabia
Email<EMAIL_ADDRESS>Office: +966 (0)12 808 0640
Mobile: +966 (0)54 470 0421
Research group: bayescomp.kaust.edu.sa
R-INLA project: www.r-inla.org
Zoom: kaust.zoom.us/my/haavard.rue
On 29 Jan 2021, 18:11 +0300, Sebastian Meyer<EMAIL_ADDRESS>wrote:

The stable INLA repository which I reference from my package to install INLA currently does not contain any Windows binaries for R 4.0. The testing repository does provide such Windows binaries. Maybe one of those binaries could be copied over to stable?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yes.  Soon
—
Håvard Rue
Professor of Statistics
Statistics Program, CEMSE Division
King Abdullah University of Science and Technology
Thuwal 23955-6900, Saudi Arabia
Email<EMAIL_ADDRESS>Office: +966 (0)12 808 0640
Mobile: +966 (0)54 470 0421
Research group: bayescomp.kaust.edu.sa
R-INLA project: www.r-inla.org
Zoom: kaust.zoom.us/my/haavard.rue
On 29 Jan 2021, 18:11 +0300, Sebastian Meyer<EMAIL_ADDRESS>wrote:

The stable INLA repository which I reference from my package to install INLA currently does not contain any Windows binaries for R 4.0. The testing repository does provide such Windows binaries. Maybe one of those binaries could be copied over to stable?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I'll add this soon. meanwhile, please use the testing version (just
replace /stable with /testing, and its there)
On Fri, 2021-01-29 at 15:11 +0000, Sebastian Meyer wrote:

The stable INLA repository which I reference from my package to
install INLA currently does not contain any Windows binaries for R
4.0. The testing repository does provide such Windows binaries. Maybe
one of those binaries could be copied over to stable?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

--
Håvard Rue
Professor of Statistics
Statistics Program, CEMSE Division
King Abdullah University of Science and Technology
Thuwal 23955-6900, Saudi Arabia
Email<EMAIL_ADDRESS>Office: +966 (0)12 808 0640
Mobile: +966 (0)54 470 0421
Research group: bayescomp.kaust.edu.sa
R-INLA project: www.r-inla.org
Zoom: kaust.zoom.us/my/haavard.rue

I'll add this soon. meanwhile, please use the testing version (just
replace /stable with /testing, and its there)
On Fri, 2021-01-29 at 15:11 +0000, Sebastian Meyer wrote:

The stable INLA repository which I reference from my package to
install INLA currently does not contain any Windows binaries for R
4.0. The testing repository does provide such Windows binaries. Maybe
one of those binaries could be copied over to stable?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

--
Håvard Rue
Professor of Statistics
Statistics Program, CEMSE Division
King Abdullah University of Science and Technology
Thuwal 23955-6900, Saudi Arabia
Email<EMAIL_ADDRESS>Office: +966 (0)12 808 0640
Mobile: +966 (0)54 470 0421
Research group: bayescomp.kaust.edu.sa
R-INLA project: www.r-inla.org
Zoom: kaust.zoom.us/my/haavard.rue

Its there now.

issue is fixed

Great, thanks!


@angular-devkit/build-angular depends on vulnerable version of vite

Command
new
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Running npm audit on Angular v16 project causes an error output, because @angular-devkit/build-angular depends on vulnerable version of Vite's server.fs.deny.
See more details: GHSA-8jhw-289h-jh2g
Minimal Reproduction
Create new Angular v16 project.
Run npm audit in the project folder
Exception or Error
No response
Your Environment
Angular CLI: 16.2.10
Node: 18.18.1
Package Manager: npm 10.2.0
OS: win32 x64

Angular: 16.2.12
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1602.10
@angular-devkit/build-angular   16.2.13
@angular-devkit/core            16.2.10
@angular-devkit/schematics      16.2.10
@angular/cli                    16.2.10
@schematics/angular             16.2.10
rxjs                            7.8.1
typescript                      4.9.5
zone.js                         0.13.3

Anything else relevant?
No response

Duplicate of https://github.com/angular/angular-cli/issues/27409


first commit

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?


README edits

Fixed various typos, cutoff sentences, formatting issues, and reference to a deprecated option.

Thanks! Looks good.


Multiline fomate to single line

How can i prevent this multiple line to single line?
@if (auth()->user()->subscribed('default'))

Just released https://github.com/shufo/vscode-blade-formatter/releases/tag/v0.7.9 with this issue fixed. Thank you! @furiousjayed


[GSSoC'23] Car Animation Project Completed

Title and Issue number

Title - Animated Car
Issue Number - 3068
Close #3068

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

@MohitGupta121 @pranjay-poddar @Saurabh-kumar09 Sir, please review this pr
Thanks for assigning this project to me.


update amazon game circles.

I forgot to include some methods in the amazon game circles framework.
I will make more updates for Android. Flurry ads + Revmob update are coming soon.

Thanks for the contribution Oscar


Can't add picture to comment when editing

CSP bug:

Unrelated to editing though. Image upload doesn't work at all. Need to allow blob:.


PJAX form submit and yii confirm don't mix.

Right now if you use ActionColumn and set data-pjax to 1, then it doesn't do an ajax submit like in v1.1.
The yii.js file needs to be modified so that $form = $('<form method="' + method + '" action="' + action + '"></form>'); has data-pjax.
The form needs to be inserted as well after the called element, not the body, so change $form.hide().appendTo('body'); to $e.after($form.hide());
This is so the jquery selector defined in Pjax.php on line 175 get matched.
There also should be a better way to handle this as you must define pjax history to be off, or the replaceState js function does a window.location.reload().
In summary, the ActionColumn should support ajax actions via some means. This was a mess to figure out...

Same problem happens to me. data-confirm attribute on a link doesn't let pjax-call to fire in a gridview. After you click OK in a browser-provided confirm dialog, full page reload occurs. If you remove data-confirm it starts to work via pjax.


cuDNN-based LSTM implementation not used when eager execution is disabled

System information
OS: Debian 10, x64
GPU: GeForce GTX 1060 6GB
Python: 3.7.3
TensorFlow: 2.0.0 installed from source (git tag v2.0.0)
Bazel: 0.26.1
GCC: 6.5.0
CUDA: 10.1
cuDNN: 7.6.4
Sample code
import numpy
import tensorflow as tf
from tensorflow.keras import Model
from tensorflow.keras.layers import Input, LSTM

# uncommenting this causes performance issues
# tf.compat.v1.disable_eager_execution()

i = Input(shape=(1024, 32))
o = LSTM(units=32)(i)
m = Model(i, o)

m.compile('sgd', 'mse')
m.fit(numpy.zeros((512, 1024, 32)), numpy.zeros((512, 32)))

Output with eager execution enabled
Train on 512 samples
2019-12-30 17:06:25.988147: W tensorflow/core/grappler/optimizers/implementation_selector.cc:310] Skipping optimization due to error while loading function libraries: Invalid argument: Functions '__inference___backward_cudnn_lstm_with_fallback_2026_2206' and '__inference___backward_cudnn_lstm_with_fallback_2026_2206_specialized_for_StatefulPartitionedCall_at___inference_distributed_function_2818' both implement 'lstm_c56c9d1d-36f6-4e94-9410-ecd020c8700a' but their signatures do not match.
512/512 [==============================] - 2s 3ms/sample - loss: 0.0000e+00

Output with eager execution disabled
WARNING:tensorflow:From /home/<user>/virtualenvs/tensorflow-2.0.0/lib/python3.7/site-packages/tensorflow_core/python/ops/resource_variable_ops.py:1630: calling BaseResourceVariable.__init__ (from tensorflow.python.ops.resource_variable_ops) with constraint is deprecated and will be removed in a future version.
Instructions for updating:
If using Keras pass *_constraint arguments to layers.
Train on 512 samples
512/512 [==============================] - 8s 15ms/sample - loss: 0.0000e+00

Discussion
Note how the runtime is very significantly slower when eager execution is disabled. It seems that the cuDNN-based implementation of LSTM is not used whenever eager execution is disabled, as is seen on this line in the code where self.could_use_cudnn ends up being False. This seems wrong to me, as there's no reason not to use  cuDNN in that situation.
The warning about the skipped optimization is discussed in #30263 and apparently can be ignored, as per qlzh727's comment.

Issue is replicating on colab with Tf 2.0.
Please find the gist here. Thanks!

Hi @jlherren.
Thanks for reporting this issue. In short, this is actually by design that when eager mode is disabled.
When eager mode is disabled, all the code will be run with session, which is same as v1 code. Since the new LSTM implementation uses TF function, under the hood it is a op that invoke a function graph. In the v1 session runtime, the input/output of an op can't be modified between different runs, unless the session is cleared. In LSTM's case, this means the code will break if the model is first invoked with model.predict() and then model.fit(), since predict() will only create the forward path, and fit() will create backward path after that. The backward path will cause the LSTM function op to produce extra output/states for backprop, which violate the immutable input/output rule.
This is why we disable the function approach when code will be run under session mode. You can find more details in this change 0cdf2250b7276ff3cd2fad9bd44c917cbb760bd5.
I am closing this issue as "working as intended". Feel free to reopen it if you feel otherwise.

To avoid confusing users, the documentation for GRU & LSTM should be updated to describe this limitation.
https://www.tensorflow.org/api_docs/python/tf/keras/layers/GRU
https://www.tensorflow.org/api_docs/python/tf/keras/layers/LSTM
The above pages do not list eager-mode as a requirement for using cuDNN.


Model schema doesn't display some fields of unknown type

if I have a case class like one of the following:
case class MyClass(a: String, b: Any)
case class MyOtherClass[T](a: String, b: T)

and use it as the schema's $ref, the Model Schema generated by the docs will look like:
{
  "a": "string"
}

and b doesn't show up at all, presumably because it doesn't know about the type.

it looks like the Any value does show up in the definitions in the swagger.json file. e.g.,
{
  "properties": {
    "a": { "type": "string", "required": true },
    "b": { "type": "any", "format": "any", "required": true }
  }
}

In which case it's an issue with swagger itself not recognizing the any type and excluding it from the schema. It looks like it has to match one of swagger's valid data types, but I'm not sure that swagger was intended to document arbitrary JSON inputs, so none of the types really match.
I tried adding a mapping in SwaggerParameterMapper.scala, e.g.,
typeName match {
  /// ...
  case "Any" => prop("string", Some("any JSON value"))
  /// ...
}

hoping that swagger would display the text "any JSON value" in the schema, but it just displays as:
{
  "a": "string",
  "b": "string"
}

the same happens if I choose some other format like binary or byte.
anyway, not really sure that this can be solved in a way that makes sense.

Found a possible solution: you can provide swagger with an example value to use in the generated model schema (by default it uses 0 for ints, "string" for strings, etc), and it will use that value even if the type doesn't match one of the standard types.
I've opted to use a string "any JSON value" in this case -- see PR #8


Duplicate injections

As per issue #57 I am still seeing duplicate inject lines if you place an // @ngInject above a constructor that automatically gets discovered.  This is as of version 0.15.4.

Hi! Please provide a minimal input example with ng-annotate output and I'll take a look. Thanks!

(with input example I mean ES5 code that can be fed into ng-annotate. so most likely the output from your transpiler.)

I'm having this issue too:
'use strict';

var x = (function () {
  /* @ngInject */
  function myFactory($http) {
    return $http;
  }
  return myFactory;
})();

angular.module('myApp').factory('x', x);

The above outputs this:
var x = (function () {
  /* @ngInject */
  function myFactory($http) {
    return $http;
  }
  myFactory.$inject = ["$http"];
  myFactory.$inject = ["$http"];
  return myFactory;
})();

angular.module('myApp').factory('x', x);

btw, if you put the above output into ng-annotate you get an error:
error: conflicting inject arrays at line 8 and 9
I think ng-annotate can be more forgiving in case the dup inject arrays are identical...

@shatata that's is a dupe of #135 and fixed in 79162568c53ebce941a49e4e2ab6464a45c39951, will be released in 1.0 quite soon hopefully. feel free to try master until then!
I'm not planning to relax ng-annotate complaining when there are multiple inject arrays.


Pleroma mogrify upload filter doesn't work together with other filters

Describe the bug
I enabled Mogrify filter together with Dedupe and AnonymizeFilename. If I upload an image, the mogrify filter is ignored and the full resolution image is published.
If I disable all other filters and leave only Mogrify anabled, then it works correctly, as expected.
I couldn't find anything useful in the logs.
Steps To Reproduce
Steps to reproduce the behavior:

Enable [ Pleroma.Upload.Filter.Dedupe, Pleroma.Upload.Filter.AnonymizeFilename, Pleroma.Upload.Filter.Mogrify ] in that order.
Set some mogrify arguments like: {"format", "jpg"}, {"define", "jpeg:extent=128kb"}
upload a big image
the image is not processed by mogrify and is still big

Expected behavior
I would like to enable Dedupe, AnonymizeFilename and Mogrify together as normal.
Screenshots
Part of my config:
config :pleroma, Pleroma.Upload,
  uploader: Pleroma.Uploaders.Local,
  filters: [
    Pleroma.Upload.Filter.Dedupe,
    Pleroma.Upload.Filter.AnonymizeFilename,
    Pleroma.Upload.Filter.Mogrify
  ],
  link_name: true

config :pleroma, Pleroma.Uploaders.Local, uploads: "/var/lib/pleroma/uploads/"

config :pleroma, Pleroma.Upload.Filter.Mogrify,
  args: [
    "strip",
    "auto-orient",
    {"format", "jpg"},
    {"resize", "2073600@>"},
    {"define", "jpeg:extent=512kb"}
  ]

Notify maintainers

@NinjaTrappeur @yu-re-ka @Kloenk @yayayayaka
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.57-hardened1, NixOS, 23.05 (Stoat), 23.05.4362.6f87c4d764f4`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.5`
 - channels(root): `"nixos-23.05-small, nixos-unstable"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Do you think this bug is related to the NixOS pleroma integration? If so, could you point out the specifics that makes you think it is the case?

I think the problem is in NixOS because this kind of config was working for me before I moved to NixOS and I know it works with other people's setup without NixOS.
Specifically, I don't know what could lead to this strange behavior.


Decorate person class

This implements  two decorators in, one to capitalize and the other to trim people's names.
The following apply:

A base component, Nameable is implemented
The Person class is set to inherit from Nameable
A base decorator is created to inherit from Nameable
Two decorators CapitalizeDecorator and TrimmerDecorator werer created to inherit from the base decorator
Test code is added

The screenshot below shows the result of the test:

Hi @emmiiorji,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that has no descriptive README file. README files are integral part of our software engineering career, it helps us document our work. Kindly check the link to help us
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.

Sorry about that. I had not merged the branch containing the README file.


Create Select Component in Design System that allows filtering of options

We need a component in the Design System that will allow users to type into the selection to filter the options list.
We are closing these two issues in Dataverse, because we they be addressed in the SPA, using this component:
https://github.com/IQSS/dataverse/issues/9092
https://github.com/IQSS/dataverse/issues/6772
This component will also be used in the Host Collection input in the Create Dataset Page
https://github.com/IQSS/dataverse-frontend/issues/340
In order to improve the performance of retrieving the list of options, there is another issue in Dataverse, to improve the API:
https://github.com/IQSS/dataverse/issues/6467
This issue is dependent on the completion of API issue in Dataverse

See details: Dataverse UX/UI Internal Process Meeting Notes, 2024/05/09
Related:

https://github.com/IQSS/dataverse/issues/9092
https://github.com/IQSS/dataverse/issues/6772


Error while accessing Solr

Heatmaps issue.
After adding heatmaps widget and selecting a date field, it throws following error:
{ "message": "'facets'", "traceback": [ [ "/root/Hue/apps/search/src/search/views.py", 145, "search", "response = SolrApi(SOLR_URL.get(), request.user).query(collection, query)" ], [ "/root/Hue/desktop/libs/libsolr/src/libsolr/api.py", 359, "query", "if facet['properties']['facets'] or facet['widgetType'] == 'map-widget':" ] ], "detail": "None", "title": "Error while accessing Solr" }
Also, there are no null values or zeros in the selected date field.
I'm using Hue 3.9 and Solr 5.5
Any help is appreciated.

What do you have on the /logs page?
I just tried on Hue master and Solr 4 from CDH5.8 and it was good (date field and string for field 2)

Here is what I have on /logs page:
ze=1000 HTTP/1.1" 200 None
[16/May/2016 09:05:58 -0700] resource     DEBUG    GET Got response: {"responseHeader":{"status":0,"Q...
[16/May/2016 09:05:58 -0700] _internal    INFO     ESC[m<IP_ADDRESS> - - [16/May/2016 09:05:58] "POST /search/search HTTP/1.1" 200 -ESC[0m
[16/May/2016 09:06:05 -0700] access       INFO     <IP_ADDRESS> admin - "POST /search/template/new_facet HTTP/1.1"
[16/May/2016 09:06:05 -0700] internal    INFO     ESC[m<IP_ADDRESS> - - [16/May/2016 09:06:05] "POST /search/template/new_facet HTTP/1.1" 200 -ESC[0m
[16/May/2016 09:06:05 -0700] access       INFO     <IP_ADDRESS> admin - "POST /search/search HTTP/1.1"
[16/May/2016 09:06:05 -0700] middleware   INFO     Processing exception: 'facets': Traceback (most recent call last):
File "/root/Hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/core/handlers/base.py", line 112, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/root/Hue/build/env/lib/python2.6/site-packages/Django-1.6.10-py2.6.egg/django/db/transaction.py", line 371, in inner
return func(*args, **kwargs)
File "/root/Hue/apps/search/src/search/decorators.py", line 44, in decorate
return view_func(request, *args, **kwargs)
File "/root/Hue/apps/search/src/search/views.py", line 154, in search
raise PopupException(e, title=('Error while accessing Solr'))
PopupException: 'facets'

In the chrome network tab, what do you have for the header and response of the '/search/template/new_facet' call?

There was some indentation issue in views.py file, after fixing identation, issue went away. Thanks!