update transaction_outputs

Description

possible_to_receive.iter().clone() -> possible_to_receive.into_iter():

This modification is generally appropriate and improves performance by avoiding unnecessary cloning of the possible_to_receive collection. Instead of cloning, it consumes the iterator, which is more efficient.

 .chain(received_objects) ->  .chain(received_objects.into_iter()):

By calling into_iter() on received_objects when adding them to locks_to_delete, the objects are directly used in the collection and the original reference to received_objects is no longer necessary.

** Correct the spelling error in transaction_orchestrator**:

fnished -> finished
Test plan
How did you test the new or updated feature?

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:
[ ] REST API:

Thanks @xiaodi007 for the change. There's one clippy suggestion that we need to apply to make the CI green.

Thanks @xiaodi007. @mlogan is not around this week, so just waiting for him to confirm this is OK and be aware of the needed fix in our dashboard. Give me a bit more time before landing this, thank you!

Got it, thanks!


Added test for cert manager

Added test for cert manager for a nil ca Fixes #3437
Signed-off-by: mudit singh<EMAIL_ADDRESS>
Description:

Testing done: yes

Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[x ]

Upgrade
[ ]

Other
[ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project?

Did you notify the maintainers and provide attribution?

Is this a breaking change?

Codecov Report

Merging #4004 (e80dba9) into main (c9d2292) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4004   +/-   ##
=======================================
  Coverage   67.52%   67.53%
=======================================
  Files         204      204
  Lines       11615    11615
=======================================
+ Hits         7843     7844    +1
+ Misses       3721     3720    -1
  Partials       51       51

Flag
Coverage Δ

unittests
67.53% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/certificate/providers/tresor/certificate.go
100.00% <0.00%> (+4.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9d2292...e80dba9. Read the comment docs.

Hi I am not able to figure out why e2e test is failing would appreciate any guidance for the same

@mudit-01 The failure was due to pod not coming up in k8s. I guess this can be happen when Action server does not have enough capacity at that moment. Re-run the jobs later can solve the problem.

thanks @allenlsy for the review

Thanks @ksubrmnn for the review


Brew formula assumes Homebrew installation location

From @farcaller on Gitter:
$ brew install datawire/blackbird/telepresence
Last 15 lines from /Users/farcaller/Library/Logs/Homebrew/telepresence/01.env:
2017-07-21 21:11:40 +0100

env
PATH=...
make
virtualenv/bin/sshuttle-telepresence

virtualenv --python=python3 virtualenv
/bin/bash: virtualenv: command not found
make: *** [virtualenv] Error 127

 $ echo =virtualenv
/Users/farcaller/.homebrew/bin/virtualenv

The formula extends the path to include a hard-coded /usr/local/bin.

That might want to be something like #{prefix}/bin but I'm not sure.


how to set default stable?

emacs ob-rust (org-mode org-babel)
https://github.com/micanzhang/ob-rust
error: no such subcommand: +stable
Thanks.

The +<something> argument is a rustup flag. rustup would install fake rustc and cargo to handle special arguments like +stable. But rust-overlay are shipping rustc, cargo and etc binaries directly from upstream. The version is specified using nix syntax.
The related code is located in rust-script. Please don't use the argument --toolchain-version of rust-script to make it work.

The option is not included anywhere (also "-c"), but I can't solve it. I don't know how to solve it. heh


Regression lines are broken after switching axis type to log

Please also verify how switching axes to log works with formula lines

@RobertStrulak  - to provide the expected behavior

@dionissqq , for the time being let's just not show regression line when either of the axes is in log mode. See regression_line.dart.

@skalkin As we discussed today, it would be nice to automatically change the axis value to log in the regression line calculation when user change axis to log. This way the line will be still straight.
For example:

The other frequently asked by user is R2 value, could it be shown with regression line? user need to see it to know the quality of the regression line. Thank you!

@dionissqq , let's see if we can do the same

Fixed in v1.8.2
r2 values added as well


Interactive Configuration Script

I've been working on an interactive python configuration script for use with this docker image.
The goal of the script is for it to ask the questions and then generate a docker-compose and the *.env files based upon the user's responses. Would this script be of interest to this project?

Hey @lego-engineer and thanks for your question! We're probably not going to integrate the script into the project but if you open-source it somewhere, we'd be more than happy to mention and link to it somehwere in our documentation so people can easily find and use it if they want to! What do you think?

Hello @thasmo!
That sounds like a great idea.

Hey @thasmo!
Here is a link to my gitlab repo with the project.
My general intent was for the script to streamline the server deployment process for those new to docker and who want a server on the more basic end of the spectrum. As such it will build the proper docker-compose and *.env files for almost all of the configuration options specified in here. However, since I wanted to keep it more on the generic end, and did not want to have too many prompts, I decided not to include all options (TICK_RATE, NAME_PREFIX, etc). I figured that people who want specialized stuff like that will know enough to be able to manually add these details. As time goes on and you guys update your image, I will update my script.
General Script Info

Downloadable from my gitlab or pypi.
Creates a console command dst-server-deploy which asks questions from which it generates the docker-compose.yml and *.env files.
Python3+ compatible. (I didn't test every version, but it worked fine with the versions I did.)

Future Plans

Include an argparser so the script can take in cli commands.
Make package more robust to version changes.

I've added the link to reference section of the readme. 👍


Changing locale on ColorArea doesn't change direction thumb moves with home/end key

🐛 Bug Report
Changing the locale doesn't change the direction that home/end keys move the thumb.
😯 Current Behavior
Selecting a language that is RTL or LTR, and home/end keys both move the same direction. For other components like slider, color slider, most other things the direction changes.
🔦 Context
Noticed this while testing #2888
🧢 Your Company/Team
RSP

Note: will need to discuss w/ internationalization team and accessibility to see what the expected behavior is here.


Use A Library For Browser Exec

Os.Exec function is being used to open the browser on the system. It is better if we can use toqueteos/webbrowser package.

I'd like to pick this up if you don't mind.

Yes, please :) @theag3nt


UX Unification - Adopt new Tabs in Workflow History Detail page

Is your proposal related to a problem?
As of Wagtail 3.0 - most Tabs components use the new tab UI, however there appears to be one page that does not.
Describe the solution you'd like

Adopt the new tabs in the Workflow history detail page.

Describe alternatives you've considered

Leave it as is, this page is a bit obscure
Use collapse instead of tabs?

Additional context

File https://github.com/wagtail/wagtail/blob/main/wagtail/admin/templates/wagtailadmin/pages/workflow_history/detail.html
https://github.com/wagtail/wagtail/issues/8408
This will also remove yet another inline script from our HTML

Screenshots

@PaarthAgarwal  as per discussion today, give this a go when you are ready, it is a good chance to move a legacy tabs component over to the new approach.

Files

reference implementation wagtail/admin/templates/wagtailadmin/account/account.html
JS files client/src/includes/tabs.js
wagtail/admin/static_src/wagtailadmin/scss/layouts/workflow-progress.scss

Key actions

restructure the DOM so that it aligns with the required tabs structure, be careful to look at aria props, descriptions, tab index etc
Remove the styles that will no longer be needed e.g. .workflow-progress-tabs__buttons
pull out the JS script ... document.querySelectorAll('[data-tab-button]').forEach(button => {
ensure the JS is running (we did a quick check and it looks like it is loading on that page)

How to get to this page

reports > workflows
Then click any status for any workflow
Note: You will need to run some workflows in the bakerydemo for this listing to appear

Files

reference implementation wagtail/admin/templates/wagtailadmin/account/account.html
JS files client/src/includes/tabs.js
wagtail/admin/static_src/wagtailadmin/scss/layouts/workflow-progress.scss

Key actions

restructure the DOM so that it aligns with the required tabs structure, be careful to look at aria props, descriptions, tab index etc
Remove the styles that will no longer be needed e.g. .workflow-progress-tabs__buttons
pull out the JS script ... document.querySelectorAll('[data-tab-button]').forEach(button => {

Didn't get a chance to pull :)


TypeError: LocalStateManager.init() got an unexpected keyword argument 'agent_config'

Describe the bug
I'm trying to run the code from autogen from this file:
memgpt/autogen/examples/memgpt_coder_autogen.ipynb
A clear and concise description of what the bug is.
In file memgpt/autogen/memgpt_agent.py at line  170, i think it should've been
"agent_state": agent_config, .
LOGS:
Traceback (most recent call last):
  File "/LLMmodels/autogen/ytest.py", line 75, in <module>
    coder = create_memgpt_autogen_agent_from_config(
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/MemGPT/memgpt/autogen/memgpt_agent.py", line 95, in create_memgpt_autogen_agent_from_config
    autogen_memgpt_agent = create_autogen_memgpt_agent(
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/MemGPT/memgpt/autogen/memgpt_agent.py", line 172, in create_autogen_memgpt_agent
    persistence_manager = LocalStateManager(**persistence_manager_kwargs) if persistence_manager is None else persistence_manager
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: LocalStateManager.__init__() got an unexpected keyword argument 'agent_config'

Please describe your setup

[x] MemGPT version

What is the output of memgpt version? (eg "0.2.4") 0.2.12

[x] How did you install memgpt?

pip install pymemgpt? pip install pymemgpt-nightly? git clone? git clone

[x] Describe your setup

What's your OS (Windows/MacOS/Linux)? Linux
How are you running memgpt? (cmd.exe/Powershell/Anaconda Shell/Terminal) terminal

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

If you're not using OpenAI, please provide additional information on your local LLM setup:
Local LLM details
If you are trying to run MemGPT with local LLMs, please provide the following information:

[ ] The exact model you're trying to use (e.g. dolphin-2.1-mistral-7b.Q6_K.gguf)
[ ] The local LLM backend you are using (web UI? LM Studio?)
[ ] Your hardware for the local LLM backend (local computer? operating system? remote RunPod?)

Hey @mongolu , sorry for the delay! This is basically a version issue - the latest code on this github repo is for the eventual 0.2.12 release, but the AutoGen part of the repo has not been updated yet so it won't work until #787 is finished.
If you want to use AutoGen, you should use 0.2.11. You can do this by grabbing the pip package (pip install pymemgpt or pip install pymemgpt==0.2.11), or by cloning the github repo then doing git checkout 0.2.11).


Failed to Register - Android/Cordova

Having an issue where i get
04-13 11:27:39.596    7722-7761/com.fisher.fairplay W/System.err﹕ org.json.JSONException: Index 0 out of range [0..0)
04-13 11:27:39.598    7722-7761/com.fisher.fairplay W/System.err﹕ at org.json.JSONArray.get(JSONArray.java:282)
04-13 11:27:39.598    7722-7761/com.fisher.fairplay W/System.err﹕ at org.json.JSONArray.getJSONObject(JSONArray.java:510)
04-13 11:27:39.599    7722-7761/com.fisher.fairplay W/System.err﹕ at com.pushwoosh.plugin.pushnotifications.PushNotifications.internalRegister(PushNotifications.java:145)
04-13 11:27:39.600    7722-7761/com.fisher.fairplay W/System.err﹕ at com.pushwoosh.plugin.pushnotifications.PushNotifications.execute(PushNotifications.java:358)
04-13 11:27:39.601    7722-7761/com.fisher.fairplay W/System.err﹕ at org.apache.cordova.CordovaPlugin.execute(CordovaPlugin.java:84)
04-13 11:27:39.601    7722-7761/com.fisher.fairplay W/System.err﹕ at org.apache.cordova.PluginManager.exec(PluginManager.java:147)
04-13 11:27:39.602    7722-7761/com.fisher.fairplay W/System.err﹕ at org.apache.cordova.CordovaBridge.jsExec(CordovaBridge.java:59)
04-13 11:27:39.602    7722-7761/com.fisher.fairplay W/System.err﹕ at org.apache.cordova.ExposedJsApi.exec(ExposedJsApi.java:40)
04-13 11:27:39.603    7722-7761/com.fisher.fairplay W/System.err﹕ at com.android.org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
04-13 11:27:39.604    7722-7761/com.fisher.fairplay W/System.err﹕ at com.android.org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:24)
04-13 11:27:39.604    7722-7761/com.fisher.fairplay W/System.err﹕ at android.os.Handler.dispatchMessage(Handler.java:102)
04-13 11:27:39.605    7722-7761/com.fisher.fairplay W/System.err﹕ at android.os.Looper.loop(Looper.java:136)
04-13 11:27:39.605    7722-7761/com.fisher.fairplay W/System.err﹕ at android.os.HandlerThread.run(HandlerThread.java:61)
04-13 11:27:39.661    7722-7722/com.fisher.fairplay D/CordovaLog﹕ file:///android_asset/www/js/index.js: Line 26 : initPushwooshAndroid
04-13 11:27:39.661    7722-7722/com.fisher.fairplay I/chromium﹕ [INFO:CONSOLE(26)] "initPushwooshAndroid", source: file:///android_asset/www/js/index.js (26)
04-13 11:27:39.661    7722-7722/com.fisher.fairplay D/CordovaLog﹕ file:///android_asset/www/js/index.js: Line 51 : ["failed to register ","Index 0 out of range [0..0)"]
04-13 11:27:39.661    7722-7722/com.fisher.fairplay I/chromium﹕ [INFO:CONSOLE(51)] "["failed to register ","Index 0 out of range [0..0)"]", source: file:///android_asset/www/js/index.js (51)
Any suggestions?

Which plugin version do you use?
com.pushwoosh.plugin.pushnotifications.PushNotifications.internalRegister(PushNotifications.java:145) doesnt match the file:
https://github.com/Pushwoosh/pushwoosh-phonegap-3.0-plugin/blob/master/src/android/src/com/pushwoosh/plugin/pushnotifications/PushNotifications.java

I had pulled https://www.pushwoosh.com/programming-push-notification/android/android-additional-platforms/phonegapcordova-sdk-integration/ for my plugin version.
Just reverted back to that version and get
/src/com/pushwoosh/plugin/pushnotifications/PushNotifications.java
Error:(28, 37) java: cannot find symbol
symbol:   class PushPersistance
location: package com.arellomobile.android.push
Error:(29, 49) java: cannot find symbol
symbol:   class GetTagsListener
location: class com.arellomobile.android.push.PushManager
Error:(30, 37) java: cannot find symbol
symbol:   class SendPushTagsCallBack
location: package com.arellomobile.android.push
Error:(35, 48) java: package com.arellomobile.android.push.utils.rich does not exist
Error:(175, 36) java: cannot find symbol
symbol:   method initializePushManager(android.app.Activity,java.lang.String,java.lang.String)
location: class com.arellomobile.android.push.PushManager
Error:(176, 51) java: cannot find symbol
symbol:   method getInstance(android.app.Activity)
location: class com.arellomobile.android.push.PushManager
Error:(191, 37) java: cannot find symbol
symbol:   method registerForPushNotifications()
location: variable mPushManager of type com.arellomobile.android.push.PushManager
Error:(330, 61) java: cannot find symbol
symbol:   class SendPushTagsCallBack
location: class com.pushwoosh.plugin.pushnotifications.PushNotifications
Error:(332, 25) java: method does not override or implement a method from a supertype
Error:(343, 25) java: method does not override or implement a method from a supertype
Error:(354, 25) java: method does not override or implement a method from a supertype
Error:(358, 72) java: incompatible types: SendTagsListenerImpl cannot be converted to com.arellomobile.android.push.tags.SendPushTagsCallBack
Error:(372, 55) java: cannot find symbol
symbol:   method getPushToken(android.app.Activity)
location: class com.arellomobile.android.push.PushManager
Error:(378, 55) java: cannot find symbol
symbol:   method getPushwooshHWID(android.app.Activity)
location: class com.arellomobile.android.push.PushManager
Error:(438, 37) java: cannot find symbol
symbol:   method startTrackingBeaconPushes()
location: variable mPushManager of type com.arellomobile.android.push.PushManager
Error:(449, 37) java: cannot find symbol
symbol:   method stopTrackingBeaconPushes()
location: variable mPushManager of type com.arellomobile.android.push.PushManager
Error:(458, 44) java: cannot find symbol
symbol:   method setBeaconBackgroundMode(android.app.Activity,boolean)
location: class com.arellomobile.android.push.PushManager
Error:(603, 48) java: cannot find symbol
symbol:   variable RichPushUtils
location: class com.pushwoosh.plugin.pushnotifications.PushNotifications
Error:(604, 44) java: cannot find symbol
symbol:   method setColorLED(android.app.Activity,int)
location: class com.arellomobile.android.push.PushManager
Error:(655, 68) java: cannot find symbol
symbol:   class GetTagsListener
location: class com.pushwoosh.plugin.pushnotifications.PushNotifications
Error:(657, 33) java: method does not override or implement a method from a supertype
Error:(668, 33) java: method does not override or implement a method from a supertype
Error:(680, 36) java: cannot find symbol
symbol:   method getTagsAsync(android.app.Activity,GetTagsListenerImpl)
location: class com.arellomobile.android.push.PushManager
Error:(686, 57) java: cannot find symbol
symbol:   variable PushPersistance
location: class com.pushwoosh.plugin.pushnotifications.PushNotifications
Error:(693, 25) java: cannot find symbol
symbol:   variable PushPersistance
location: class com.pushwoosh.plugin.pushnotifications.PushNotifications
Error:(699, 36) java: cannot find symbol
symbol:   method clearNotificationCenter(android.app.Activity)
location: class com.arellomobile.android.push.PushManager
Noticed that it is unable to resolve the following
import com.arellomobile.android.push.PushPersistance;
import com.arellomobile.android.push.PushManager.GetTagsListener;
import com.arellomobile.android.push.SendPushTagsCallBack;
import com.arellomobile.android.push.utils.rich.RichPushUtils;
I uninstalled the plugin via CLI and installed again and this is where I am stuck at the moment. Seems like I am missing some files?

Somehow you broke the plugin installation. What command "cordova plugin list" says?

com.pushwoosh.plugins.pushwoosh 3.4.16 "Pushwoosh"
and the rest of the plugins i am running.

From the logs I see pushwoosh.jar library disappeared somewhere. What happens if you remove plugin (cordova plugin remove command) and reinstall again?

Same issue. I can see that the Pushwoosh.jar file is located in my /libs directory.

I'm sorry, the same - 1st one or the 2nd one?

My apologies I was not clear. Uninstalling/reinstalling the plugin results in the 2nd error log i posted. I do see the jar file within my /libs directory.
cordova_plugins.js  adds in
{
"file": "plugins/com.pushwoosh.plugins.pushwoosh/www/PushNotification.js",
"id": "com.pushwoosh.plugins.pushwoosh.PushNotification",
"clobbers": [
"plugins.pushNotification"
]
}
and
module.exports.metadata =
// TOP OF METADATA
{
"com.pushwoosh.plugins.pushwoosh": "3.4.16"
}
// BOTTOM OF METADATA
config.xml

AndroidManifest.xml

Alright so I ended up just rebuild the app completely from scratch. New gradle build and everything and now I can get the plugin to work. There had to be something jacked up in the original gradle that was messing with the plugin.
Thanks for the help!


Setup echidna

High Level:
This PR sets up the environment to write echidna tests.
Specific Changes:
Created a unit tests folder
Created an echidna folder

Reopen a new PR without touching unit tests


add email to plan collaborator and add email domain to DB

Changes and Description

Add Email address to Plan Collaborator
Add Email domain to the db to enforce valid email address/

How to test this change

scripts/dev up:backend:debug && scripts/dev db:seed
Try to make a collaborator with a bad email address

mutation createPlanCollaborator {
  createPlanCollaborator(input: {

    modelPlanID: "6e224030-09d5-46f7-ad04-4bb851b36eab"
    euaUserID: "BC0V"
    fullName:"Clay B"

    teamRole: LEADERSHIP
    email: "ahsdklashdlaksd"
    }) {
    id
    modelPlanID
    euaUserID
    fullName
    email
    teamRole
  }
}

Ensure the above failed
Make a collaborator with a valid email address

mutation createPlanCollaborator {
  createPlanCollaborator(input: {

    modelPlanID: "6e224030-09d5-46f7-ad04-4bb851b36eab"
    euaUserID: "BC0V"
    fullName:"Clay B"

    teamRole: LEADERSHIP
    email<EMAIL_ADDRESS>    }) {
    id
    modelPlanID
    euaUserID
    fullName
    email
    teamRole
  }
}

NOTE
This change likely breaks the front end. The add collaborator logic will need to be updated to pass email as required to create collaborator.
PR Author Review Checklist

[ ] Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
[ ] Added or updated tests for backend resolvers or other functions as needed.
[ ] Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
[ ] Tested user-facing changes with voice-over and the rotor menu

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
Always make comments, even if it's minor, or if you don't understand why something was done.

I added the FE email field to collaborator queries and mutations.  Works great

@patrickseguraoddball Looks like there might be a failing snapshot - does that seem related to this change? 🤔


[alert_handler/pwrmgr] Ensure escalation receivers are on same clock/reset domains as the alert_handler

Since the escalation sender/receiver pairs employ a synchronous protocol, we must ensure that they are connected to the same clocks and resets in order to not run into spurious escalation issues. I.e., if the clocks / resets are not the same, a delay difference in clock gating or reset assertion may lead to spurious escalation (either due to the escalation ping monitor or due to locked up protocol FSMs).
Need to double check all receivers:

[ ] 1. NMI in rv_core_ibex -> needs to be fixed (TODO)
[x] 2./3. in lc_ctrl -> ok since lc_ctrl resides in the same clock/reset domains as alert_handler
[ ] 4. in pwrmgr -> needs to be fixed (TODO)

my current thinking to this problem is to allow clocks to be individually
assigned groups instead of relying on the module group as we do now.
This is similar to resets allowing different domains which gives more
flexibility.
I will experiment and get back to this.
On Wed, Sep 1, 2021 at 5:00 PM Michael Schaffner @.***>
wrote:

Assigned #8037 https://github.com/lowRISC/opentitan/issues/8037 to
@tjaychen https://github.com/tjaychen.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/8037#event-5243290510, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSVBQGYAKY3WJK2GO73T725B3ANCNFSM5DHVMD2Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ok that would be great.
just noticed that rv_core_ibex has the same issue, since that module is in the infra clock group, as opposed to lc_ctrl, which is in secure.


Support for disabling pvc auto removal

What should the feature do:
There should be option to disable PVC deletion when node is deleted.
What is use case behind this feature:
Certain K8s cluster use node replacement strategy for node upgrades. (CAPI does this) In those cases node is temporary removed from cluster and rebuild. After that it joins back to the cluster. Node name will be same and all data disks will be kept intact.
So once the node joins back to the cluster it would behave similarly as in case of node reboot. For point of view of Topolvm.
This could also be used in cases where host operating system needs to be reinstalled, but data disks would like to be reused with their data. So that expensive data migration would not be needed.

Hi, @mape90
Thanks for your issue. I think your request is appropriate.
I have a question to consider the specification. Could you please tell me how can we confirm which node is updating or retired, if you know?

Hi @llamerada-jp,
There is no way to differentiate between those cases as the information might not even be present in k8s cluster in any form. For that reason this request is to have way to disable it totally. So when auto removal is disabled it would move the responsibility of removal from topoLVM to cluster admin.
This would also make it simpler for topoLVM to implement as it would be just single flag to enable or disable this. So there do not need to be any special labels, timers or checks to be done by topoLVM.

@mape90
The following changes seem to be necessary to implement this feature.

Add a new option to topolvm-controller to disable NodeReconciler and also changes helm chart to use this option.
Add a new test case of this option in cleanup_test.go and change the test matrics in Github Actions to call the new test.
Update document.

It would be great if you create a PR, is it possible?

Hi there. I'm new to the TopoLVM project but I'd be happy to try implementing this according to your suggestions @llamerada-jp. Feel free to assign the issue to me.

@macaptain
Thank you for your offer. I wonder if you could implement this issue. Would you look at the program first and ask questions if you don't understand something.


Credit_card_detection

Developed a machine learning model to detect fraudulent credit card transactions with 93% accuracy on a dataset of 284,807 transactions. Preprocessed and normalized the data while handling class imbalance using oversampling and undersampling, and implemented classification algorithms like logistic regression.

@Ryder-07 can you assign me this issue by adding hacktoberfest tag to it ?


hi team , we seen a lot of user are facing issue the DCR where the source destination is selecting specific  Log analytics Workspace but after saving the option it automatically get changed to Log analytics Preview option , not just  one environment but other serval customer environment i have seen this , product team, please kindly look into issue  .

[Enter feedback here]
hi team , we seen a lot of user are facing issue the DCR where the source destination is selecting specific  Log analytics Workspace but after saving the option it automatically get changed to Log analytics Preview option , not just  one environment but other serval customer environment i have seen this , product team, please kindly look into issue  .

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 14a66a45-7f5b-b9c4-c675-bd2cc963b44d
Version Independent ID: 253cc884-5a70-c313-67c7-68f42b6e44c3
Content: Define Azure Monitor Agent network settings - Azure Monitor
Content Source: articles/azure-monitor/agents/azure-monitor-agent-data-collection-endpoint.md
Service: azure-monitor
Sub-service: agents
GitHub Login: @guywi-ms
Microsoft Alias: guywild

@Git-suu
Thanks for bringing this to our attention. We will investigate it further and update you shortly.

@shayoniseth please advise.


Be compatible with  the plugin named "Anyblock" to show up wikilinks in Backlinks

Now, wikilinks(or internal links) inside code blocks cann't be showed up in Backlinks, but they can be rendered as links.
On the contrary, the plugin named "Anyblock"(https://github.com/LincZero/obsidian-any-block) can transform a code-like block into a real code block and wikilinks inside the code block can be showed up in Backlinks. Unfortunately, they cann't be rendered as links by this plugin.
So, if you two great plugins can be compatible, it will be amazing.
Anyblock can transform
:::code(python)
aaa
:::

or
:::python
aaa
:::

to a code block. (Other languages also work)
The first one is original coding style, and you can also use "python" instead of "code(python)" if you have "added a new registration instruction" in the settings page(or open the plugin's data.json file to modify it)
For example:

So the key point is, if Codeblock-Customizer can also support ::: style blocks as code blocks, it's done
Please consider, and thanks for your great plugin ❤

Ok. Thank you so much 🌹


Default error_types value

The default value for error_types is set to E_ALL but not the effective error_reporting value. This is counter-intuitive and not mentioned in the documentation.

If you think that this is only a documentation issue, you can help yourself by submitting a PR to the docs repo. The page that you linked corresponds to this file: https://github.com/getsentry/sentry-docs/blob/master/src/collections/_documentation/error-reporting/configuration/index.md

I'm interested in the rationale behind this if there's one.
I would set the default to error_reporting() return value and reflected this in the docs.

I would say that the relationale behind this choice is that making the handler dependent on the error_reporting has both pros and cons. Specifically:
Pros:

The handler respects the setting provided by the programming language to set which errors to report, regardless of where they should be reported

Cons:

The user may want to report some errors to Sentry even though they are not reported on the screen or to the logging file. For example, I may want to not collect the deprecation errors in the logging file but I may still want to collect them to Sentry

These are just the two things that came to my mind while thinking about it, there may be more. Does it makes sense to you?

It doesn't make sense to me that E_ALL is the default value for this option. PHP default for it is different and it is not practical in the majority of use cases since it includes notice level errors. If somebody wants custom behavior as you mentioned in your contra-point they are free to do so by changing the default. With no setup, the expectation is to honor existing configuration.
I've already submitted a patch to the docs so it is at least more visible. But ultimately I think it makes sense to change the default as well.

Changing the default value at this point would be a HUGE breaking change, because people would stop receiving events if they didn't set that value.

Agree it should be well planned but the option is not currently documented.

Yes, one of them is for the 1.x version of the SDK, which is older and it doesn't implement the Unified API.

I see that both documents describe SDK version 2. The later one mentions changes made in version 2 while the former gives codes examples specific to version 2.

Here what's happening: there are indeed two pages describing almost the same things. The first one, which you linked in the first comment of this issue, is a page available globally for all SDKs (infact it's a generic Configuration page) and describes the options available in the Unified API since all SDKs adhering to the standard are supposed to share them and for this reason you can choose from the dropdown which language you want to see the options for, be it PHP or JS or whatever. The second page instead is specific of the PHP SDK and documents all the available options for that SDK only. Obviously, having them split between different pages is a total mess and things should be improved to be in one place only. Probably the best thing I would do is to have the Configuration page for each SDK and remove the global one, even though this will probably create some duplication it's more clear that everything relating to a specific SDK is in one place. The documentation for the 1.x version of the SDK is under another page

I propose to amend unified error tracking documentation right away. I've updated my pull request to indicate this option is only supported by PHP SDK.
If you agree that changing the default makes sense I'll prepare a pull request for that.

It doesn't make sense to me that E_ALL is the default value for this option. PHP default for it is different and it is not practical in the majority of use cases since it includes notice level errors. If somebody wants custom behavior as you mentioned in your contra-point they are free to do so by changing the default. With no setup, the expectation is to honor existing configuration.

If I understand correctly what you're saying, we can summarize it with the expected behavior that Sentry should capture by default the same errors that would be reported according to the error_reporting option because reporting (just an example) notice level errors is something you don't want to happen. I may agree in some form with this, but I don't have a strong opinion on this. Said this and clarified that we cannot change the default without breaking the behavior for existing users, I have another proposal: let's add another flag option that enables reporting only the errors which severity match with the error_reporting option. Following this, there will be 3 cases by which an error is reported to Sentry:

If capture_error_reporting_errors_only = true (name to define yet) and the severity doesn't match with the error_reporting bitmask don't report it
If capture_error_reporting_errors_only = false (this wil be the default to not break BC) and the severity doesn't match with the error_types option don't report it

It remains unknown at which point the capture_silenced_errors should act, probably after the two checks above. This  solution won't solve the problem immediately as you will still have to turn it on manually, but it can be turned on by default on the next major version. This way users can choose if they want to be dependent on the error_reporting option to capture errors or not. Does it makes more sense to you?

No, it doesn't. Adding another option brings more confusion regarding what will be reported.
As of right now, it is clear what capture_silenced_errors does. It is documented and reflects a real use case.
I see the following problems with the current default value:

It doesn't match the language's default value
It doesn't honor existing configuration
Can produce too many events which is neither desirable by users nor by Sentry
Is not described in the documentation.

Regarding the last point, we've found there are a few versions of documentation but the one linked from the project's README doesn't have it mentioned. It is also not mentioned in the UPGRADE docs!
I've found the commit where the default was first set (it is from you) and I see that it was done to set the type of this option to integer.
Changing the default to the return value of error_reporting will reflect existing error reporting preference whether language default or customized, as well as allow to control this preference from a single point (e. g. php.ini) while still enabling customization specific to Sentry.

Got it, unfortunately as we already said we cannot change the default or we it would be a BC. I'm sorry, the only thing that we can actually do like you did is update the both the documentation and the UPGRADE.md file

I understand that you can't change it right away, however, you can change it in the next version (2.2). So should I prepare a PR then?

We cannot even in the next minor version, a BC can happen only between major version bumps. Even if it's true that we don't write anywhere that we strictly follow Semver, we strive to do it implicitly and I don't want to change this :wink:

This is not a breaking change though. This change won't break error reporting.
This is a bug fix as it prevents potential flooding with notice-level messages.

This is a BC because it changes the behavior of an existing feature for users who update and who suddenly stop receiving errors if they have not explicitly configured the option

Breaking change is a change that potentially can lead to a system's failure.
Let's look at the situation from the perspective of a user upgrading from version 1.
The previous default was equal to error_reporing (see here). Suddenly, after upgrading (having read your upgrade docs and keeping the same configuration) you are getting a flood of notices which can potentially bring an otherwise working system down, deplete subscription limits and overload reporting servers.
Yes, changing the default will make some events disappear but not all of them and it will certainly not gonna lead to a failure to capture errors completely.
What do you see as a possible scenario where this leads to a system's failure?

Breaking change is a change that potentially can lead to a system's failure.

No it's not. We're talking about BC in a Semantic Versioning context. You can read about it here: https://semver.org/

To clarify, this is not a technical BC but a behavior breaking change. Suppose that I'm a user that upgraded from version 1.x to 2.x, and although in the UPGRADE.md file it was not mentioned (this is one issue of course and we have to fix it) the behavior of the library changed causing the error handler to not respect the error_reporting option by default. This is undocumented, but it's still a valid change as there was a major version bump. I also decided for some reason that the default is good for me. Now, what you are saying is that in 2.2 you want to change again the behavior causing pain for the users because suddenly they stop receiving errors, and the point is not how many errors they will lose but the fact that an upgrade between patch and minor versions should not require any change to the configuration to make existing features work as before. This is because users pinning to e.g. ^2.0 will get the new minor versions but not the new major versions, so they won't even notice that something is not working anymore as expected. We are more than welcome to improve the documentation and change the default for 3.0, but not before that version

FYI: #846 changes the parameter typehint as discussed in this issue. Closing this for now, changing the default value for the option will be discussed (and likely done) when the time for 3.0 comes

Closing this for now, changing the default value for the option will be discussed (and likely done) when the time for 3.0 comes


Allow upgrading to a specific commit, branch or tag

Allow choice between upgrading:

normally,
to a specific commit (and freezing),
upgrade on a different branch,
upgrade to a specific tag (and freezing),
upgrade by tags.

This is outside of the scope of the project, use a different plugin manager or create an extension for Vivid.


Repair Zipkin Micrometer Tracing

It seems that since the upgrade to Spring Cloud 2022.0, the OpenZipkin server is no longer receiving the traces.
We should use Micrometer to trace your Spring Boot app: https://springbootlearning.medium.com/using-micrometer-to-trace-your-spring-boot-app-1fe6ff9982ae

Can I work on this issue?

Yes @MarianConstantinMarica you can work on this issue.  Thank you for the proposal.

@dgriffiths-undo you may try the previous version: https://github.com/spring-petclinic/spring-petclinic-microservices/tree/v2.6.7

I sent the PR

Thanks @MarianConstantinMarica I've just posted a single comment. Once merged, @dgriffiths-undo could you please test it?

@marcingrzejszczak I saw you are working on Micrometer. Thus could you have a look on this PR please?


Ability to drill down into project references (view references of references)

Under a project > references > packages, I can see project references. I would like to be able to drill down into those to view nested dependencies, as I can in Visual Studio. Please consider implementing. Thanks.

I've added a PR for this here: https://github.com/fernandoescolar/vscode-solution-explorer/pull/245


Question on ica module

Summary
This is more of a question than a proposal
ICA module create an ibc channel for each interchain accounts
Can we make it so that this ICA module only use one channel like the transfer module, one channel for all interchain accounts
Problem Definition

The process of creating an ibc channel is time and resource consuming as we all know. Right now ica module require us to create an ibc channel for each interchain account so 1000 accounts means 1000 channels.

User who want to use ica will have to wait for their ica channel to be created by a relayer

Relayer will have a hard time handling a bunch of channels at once

Proposal
We change the logic of this module so that it only use one channel for all accounts. I think we can still remain the same level of security while avoid a lot of complication as mentioned above

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Hi! Good question!
Each interchain account must have its associated packets sent/received in order. That is, if I own interchain account X, each packet which executes transactions on behalf of that account must have ordering (just like any account).
Core IBC currently only supports UNORDERED and ORDERED channels. Since we need ordering, UNORDERED channels are out the question. Since we are using ORDERED channels, if we had a single ordered channel for all interchain accounts created, then all packets before my packet is sent need to be relayed before mine can be received. This means I might be forced to pay for the relaying of packets being used as a DoS attack in order to have mine received. For this reason we have a single interchain account per channel
In the ideal world we would have a partially ordered channel which is like an ordered channel which can support many accounts and only enforce ordering for each account rather than for all packets on the channel (thus removing the DoS vector). Due to time and resource constraints, we felt it was better to ship interchain accounts with the current mechanism of one channel per account than to delay by adding a new channel type to core IBC
I'm going to close this issue since there are no action items

that makes sense now, thank you


online demon does not work

Hi,
Online demo does not work on my computer. Microphone does not seem to be detected, and nothing happens.
Please fix the issue :)
Thanks, Samuel

Fixed. I recently moved to https/wss and forgot to update some URLs in the demo javascript code.

It works, thanks a lot !

Here I have complete and working code for decoding from microphone, python 2 and 3 are supported. Hope this help someone


New version: Git.Git version 2.38.0

Result: Installation Successful

Manifest
Add/Remove Programs

Name
Git
Git, Git

Version
2.38.0
2.37.3, 2.38.0

Publisher
The Git Development Community
The Git Development Community, The Git Development Community

ProductCode

Git_is1, Git_is1

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 3385
Microsoft Reviewers: Open in CodeFlow

@vedantmgoyal2009  as this package is available at https://github.com/git-for-windows/git, is there a way to automate the package update with winget bot ?
new version is available  https://github.com/git-for-windows/git/releases


Wireless Icon Sometimes Disappear

I tried everything but still it is...
My config:  https://www.paste.org/91375
All fonts are working without any problems I checked several times.

Can you also please the whole output of the polybar command.

Yes sir,

error: module/backlight: Could not get data (err: XCB_NAME (15))
error: Disabling module "backlight" (reason: Not supported for "eDP-1")
error: Disabling module "wired-network" (reason: Invalid network interface "net0")
error: Disabling module "battery" (reason: No suitable way to get current charge state)
warn: Systray selection already managed (window=0x280000c)

Is this the whole output while the wireless icon disappeared?
Btw, you also have the wrong interface set for your wired module

I'll wait until wireless icon disappeared and post again. I don't get it what you mean at first sorry.

Deleted ping-interval and problem solved


Storing data.message in the localStorage when the app is in the background?

Hi,
I'm trying to store the message that's received in the push notification in the localstorage when the app is in the background but I can't seem to figure out how...
I get the massages coming through nicely when the app is in the background but the localstorage is always null.
I'm actually tying to set the local storage in the push.on('notification') function like this:
push.on('notification', function(data) {

console.log(data.message);

window.localStorage.setItem('test', data.message);

});

Is this even possible?

Sorry to be a jerk but I'm now closing issues that don't follow the issue submission guidelines. This plugin takes a lot of work to maintain and I can't afford the time required to solicit the required info from everyone.
I'm closing this issue but please feel free to re-open the issue if you provide the requested details from the new issue submission guidelines.
https://github.com/phonegap/phonegap-plugin-push/blob/master/.github/ISSUE_TEMPLATE.md

Thanks for the reply. I just feel like it doesn't matter even if I re-open it, there is no way to do what I'm trying to do otherwise the answer would've been given in this question.

@rooz121359 well, I'm not sure what you are trying to do as you haven't given me enough information. I don't know what platform you are on, what version of the OS you have, what version of the plugin, what your payload looks like, etc. etc. This is why there is an issue guidelines.


Telegram chat

I have seen that many projects are now integrating Telegram as an effective means of communication between users and developers.
Examples:
https://github.com/radare/radare2
https://github.com/x64dbg/x64dbg
It could be a good idea for this project too.
Thanks for your time

Yep actually I think we're gonna stay on Discord for now 😄


Add support for nvim-dap-ui

https://github.com/rcarriga/nvim-dap-ui

For reference, here's the highlight group https://github.com/rcarriga/nvim-dap-ui/blob/ffa89839f97bad360e78428d5c740fdad9a0ff02/lua/dapui/config/highlights.lua#L17-L49.
I personally don't use dap-ui to know which mapping looks good, but PR is welcome.

Yeah, and sorry for the brief description btw. I was planning on adding it myself, will open a PR at some point soon :)


Feature Request for Nuget Package Manager

When resizing the Options window, the Available package sources area resizes with it, but the Machine-wide package sources area only resizes horizontally. It'd be great if the Machine-wide package sources area could be resized vertically as well, like the Available package sources area.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 108d587b-429e-3459-5698-3b40e44f4c3e
Version Independent ID: 76ad6a3f-4dde-0883-1df9-0f173f0ca7e7
Content: NuGet Package Manager UI Reference
Content Source: docs/tools/Package-Manager-UI.md
Product: nuget
GitHub Login: @karann-msft
Microsoft Alias: karann

Issue moved to NuGet/Home #7560 via ZenHub


[#2290] TrackingEventProcessor does not wait for his worker threads to shut down

TrackingEventProcessor does not wait for his worker threads to shut down
Signed-off-by: Nils Christian Ehmke<EMAIL_ADDRESS>This pull request resolves #2290.

Provided the commit suggestions just now, @nils-christian. Might be fair if we provide a style guide for Eclipse somewhere in the future too :sweat_smile:

Suggestions applied. Thank you @smcvb.


US_4.5: Eating habits & allergies 💰 3

As
organizer
I would like to
see a list of allergies and eating habits of the participants in the event that I organize
in order to
discuss this with the food provider.
Acceptance Criteria

As organizer I can see on the event page the participants of the event and their allergies/eating information.
The organizer can:

sort by eating habits groups (vegan, vegetarian and none)
or show allergies at the top
show detail allergies information: While holding the mouse on the symbol, you can see more information.
option for printing/generate pdf
show vegan, vegetarian and allergies symbol all the time (none have no symbol, and the following symbols are from iconfinder with cc0-license)

See UI wireframe for details

Dependency: Event, Role Pupil, Role Organizer

@julisa99 Please provide the symbols mentioned in the user story :)

@julisa99 Are the dependencies missing here?

@julisa99 @tobiduer Is this US still up to date?

Ja, wie kommst du darauf, dass sich das geändert hat?

@pinussilvestrus Is this a duplicate? Please state why you are closing issues that have no branch/PR history or duplicates linked.


Add new step to fix incompatibility issue in clicking app from task m…

…anager between Xiaomi Pad2 and other devices
Impacted tests(approved): new 0, update 1, delete 0
Unit test platform: [Xiaomi Pad2][Memo8]
Unit test result summary: pass 1, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/CTS-150

LGTM


Created Privacy and Disclaimer pages for Partner Portal

Issue

Closes #603

Description
Created correct links and pages for Partner Portal around Detroit Privacy Policy and Disclaimers.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Can This Be Tested/Reviewed?
Sign into Partner Portal and visit the two links in the footer.

[ ] Desktop View
[ ] Mobile View
[ ] Test A
[ ] Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have reviewed the changes in a desktop view
[ ] I have reviewed the changes in a mobile view
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have assigned reviewers
[ ] I have updated the changelog to include a description of my changes
[ ] I have run yarn generate:client if I made backend changes

This seems like it's a copy of the existing policy/disclaimer - can we just link to the public site version? Maybe via .env variable that says where the public site is?

Good call.  The public URL already is in the .env, so I've updated to call that.  Now it just points to the public files. I removed the other items.


Render state packager: add tests for shader creation errors (close #164)

Merged in https://github.com/DiligentGraphics/DiligentTools/commit/66f07160025f973a840caab4ac3b7bb857560326


GodotInitOptions.in_editor contains strange value

In the editor, it is<PHONE_NUMBER>. Otherwise, a random number. Windows 10, godot v 2.3.3

I looked at these numbers in binarom representation and the first 8 least significant bits are correct. Maybe godot_bool is 1 byte?

You're right, it should be 1 byte. I guess implementation-defined, but all the current C and C++ compilers use sizeof(bool) = 1, like D's bool. Fixed in the v0.1.11 release


Issues when changing a Neo field's translation setting

If a Neo field has content, changing it's translation setting causes strange side-effects with the existing content. This is due to the locales not updating correctly and consistently across all related data. Need to correct the NeoService::_applyFieldTranslationSetting() method to either copy the structures along with the blocks (if going from non-translated to translated) or just not duplicate the blocks into the other locales. It also seems that the locales aren't updating for the primary site locale blocks, instead remaining NULL.

We also noticed that the content of our NEO field within an entry didn't populate the newly added locales as the other translatable fields do. I quickly checked our DB and also noticed the NULL values you mentioned.

Any news about this topic? We run into it now and it's sadly a big problem :/

Seems to work in Neo Version 1.3.3; I got two language and it has no NULL in de database. (Craft CMS 2.6.2911)

Good news, I finally have this fixed and working on the dev branch. Expect this very soon 👍


firestore: Failed to get document from server.

Please fill in the following fields:
Unity editor version: 2019.2.11f1
Firebase Unity SDK version: 6.15.0
Source you installed the SDK (.unitypackage or Unity Package Manager): Unity Package Manager
Firebase plugins in use (Auth, Database, etc.): Auth, Firestore, Analytic, Functions (installed, not using it)
Additional SDKs you are using (Facebook, AdMob, etc.): Not yet
Platform you are using the Unity editor on (Mac, Windows, or Linux): Windows
Platform you are targeting (iOS, Android, and/or desktop):  Android
Scripting Runtime (Mono, and/or IL2CPP): Mono
Please describe the issue here:
(Please list the full steps to reproduce the issue. Include device logs, Unity logs, and stack traces if available.)
I am facing some strange issue, I have integrated firebase in my unity android app, it was working till yesterday, but today suddenly it stopped working in mobile while fetching document from server, it keeps throwing below error:
failed to get document because the client is offline
Even though mobile has internet connectivity, but its unable to connect to firebase cloud on mobile, I have tried installing the app in different phones and using different networks such as 4G and WIFI, also I have even removed all the rules, though the issue is not related to rules. But nothing is working.
Update
It does not work on specific phone network, like its not working on Airtel, which I and my brother are using, the app is not working on both our phones, but when I installed same app on my wife's phone, it was working, she is using different network named as Idea.
In unity editor also, it wasn't working, but when I ran it in visual studio debug mode, it started working. To get the document from the server, I am running below code:
var UId = {value of user id};
var snap = await Firestore.Collection('Players').Document(UId)  .GetSnapshotAsync(Source.Server);

Also I tried to calculate its latency as shown below, it only waits for around 10 seconds, after then it gets failed.

ADB Logs

Please answer the following, if applicable:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
Not tried yet.
What's the issue repro rate? (eg 100%, 1/5 etc)
80%

Closing since it's a duplicate of #756.


Updated db_connector and otp package changes.

db_connector/ prefix should be use for (db_common, db_sqlite, db_postgres)
$newTotp... to be changed to $(Totp.init...

@ThomasTJdev - thank you for the hint. I have now added backward compat fixes.


assignable to note

TODO:

[ ] provide translation
[ ] make list appear below corresponding note
[ ] prevent the note from opening after assigning someone
[ ] display name as tooltip on hover
[ ] give external assignees different background colors
[ ] better add assignee button
[ ] make it possible to assign by hitting enter
[ ] ...


Hi, what version of Cilium are you using? Please be aware that only Cilium 1.10 supports the TCP flag filters.

Hi, what version of Cilium are you using? Please be aware that only Cilium 1.10 supports the TCP flag filters.

cilium 1.8, Thanks for the answer

@opengers As indicated by @gandro, TCP flow filters are a feature new with Cilium v1.10.

@rolinh Just beat me to it, but to expand:
While you can run Hubble CLI v0.8 against Cilium 1.8, filters added after Cilium 1.8 will be ignored by the server. We're similar to kubectl in that regard, where newer versions of the client can talk to old versions of the server, but newly added API fields are silently ignored.


Make the Details Page responsive

Presently the styles are disoriented and the arrow is shadowed by the title and the tags are invisible and also fix the text font sizes

We have to make it responsive for devices

Greater than desktop
Desktop devices
Tablet devices
mobile devices

I will try to make this detail page responsive using sm, md and lg.
will fix font size according to the desig

Sure @SankalpHaritash21
I will assign this to you, please make sure to follow the PR guidelines aswell


Idea: Consider switching away from using environment variables to a config file instead

Consider using a key=value config file instead of environment variables.  Have a default config name (deb-install.conf) sitting next to the script but offer the user to pass in a path to a file.  Users could simply have pre-defined config files or echo out to a config file dynamically (much like setting the env variables now).

Given the "config script" option being used now, I think that solution is better than this option.  Closing this as wontfix.


feat(postgres): add decoding for chrono::Duration and time::Duration

I need this.

There's a reason we didn't do this. It primarily has to do with the months field in PgInterval which doesn't cleanly translate to a duration that is based on an exact, rational number of seconds. In your conversion you assume a month is 30 days but it's really all relative to the date at which it's applied. The same applies to assuming a day is exactly 24 hours (which is broken by daylight savings time changes).
Sure, Postgres has the justify_days() and justify_hours() functions which also codify these assumptions, but that's an explicit operation.
If nothing else, these conversions should carry a clear warning of this caveat.

I figured, I asked for the reason on the Discord but nobody replied, so this was the quickest way to get an answer :P
The assumptions I made are the same postgres makes when casting an interval into a numeric, or that was the intention at least.
Any better way to handle this?

We could just have the conversion functions and not Decode, though I think as long as it's clearly noted somewhere that this is the assumption being made (probably on this page: https://docs.rs/sqlx/0.5.9/sqlx/postgres/types/index.html#types) that it's okay to keep the impls.
I would not make the macros map interval to time::Duration/chrono::Duration by default, though you don't have that here anyway.

@meh did you see my last couple comments here?

Yes, it's just I kind of think it's actually a bad idea to convert the types as mentioned.
So I kind of feel ambivalent about this PR, and in my code I've just exposed the PgInterval through GraphQL as a new type.

Thanks for getting back so quick. Given the non-trivial caveats here I think it's best if we don't add these impls so I'm gonna go ahead and close.

Sure, Postgres has the justify_days() and justify_hours() functions which also codify these assumptions, but that's an explicit operation.

The same behavior also applies in interval literals themselves though.  As per the docs, '1.75 months' becomes 1 mon 22 days 12:00:00, and so I don't feel like it would be less expected for SQLx to convert to Duration the same way.  If someone has intervals with the months field set and want to keep it that way, it's sort of up to them to then make sure that the type they tell SQLx to fetch it as can actually represent that?
It's not a huge issue for us to do the conversion ourselves of course, but it does mean that we'll need to have two versions of the same struct for every struct where we need a Duration to be able to use the macros, which is a bit of a bummer.  (I guess this could be solved once FromRow can be used by the macros though.)


[FR] messaging send with predictions

Is your feature request related to a problem? Please describe.
We are using Firebase Predictions and cloud messaging (with node admin sdk). However, we want to send cloud messages to Predictions users, it is only possible in the Console. Will it be added as admin sdk?

Hi @tienne , thanks for the request. We will consider adding this feature but no timeline for now :)


Don't include symbols from test files in the API cache

Fixes: https://github.com/microsoft/pxt-arcade/issues/2164
Try yourself here: https://arcade.makecode.com/app/8e0b07b65f911e8dd2a4c14352fe7d87a7c8b56f-8c8b963622#editor
The API cache was including symbols from test.ts files and those symbols were sometimes conflicting with the user's program. The problem was revealed (but not introduced) by: https://github.com/microsoft/pxt/pull/6568 when we actually started checking for collisions between library top-level variables and user variables.
This PR has a targeted fix, but many issues still remain:

Even if test symbols are included, the user blocks program should correctly rename conflicting symbols
When gathering cached API info, the compiler is keeping around API info state from earlier compiles that might have conflicting build options (e.g. "ignoreTests")
All over the code we're using and editing PackageInfo .files member directly instead of the getFiles() method which is where we filter out or include test files. This effectively ignores the "ignoreTests" flag and leads to confusion and possibly inconsistencies.

mini post-mortem:
For future reference, when localhost and beta/ don't agree here are three things to try:

Enable full API caching on localhost. This makes localhost more consistent with how hosted versions work
Use pxt uploadtrg to create a hosted environment with custom changes
Use the /vX.Y.Z versioned editors to binary search for the changes that introduced or revealed the inconsistencies (thanks @livcheerful !)

Recommendation for future work:

Build a long-running, non-PR-blocking test suite that compiles a bunch of the community games. This could be run overnight. This would have spotted the issue much much closer to when it was first revealed and subsequent fixes would have been much quicker to come by.
We need to rethink the compiler state. We call compile very aggressively and thus we depend on it reusing previous results in order to be performant. I think we need a model where we compute a cache key based on the inputs to the compiler and use previous results if and only if it is safe to do so.

LGTM
agree on making a cronjob for testing community games, sounds like a great idea
Maybe for the hackathon I should see about making something along the lines of chases version comparison tool (like /playground or /tutorial-tool) that would basically be git-bisect using the tagged releases from the repo, shouldn't be too hard? Maybe could even be cute with it and have an option to take versions from the main editors and sort them all by the pxt dependency

I like both these ideas! Little boring for a hackathon tho.. more like normal work-week stuff haha


Error in GetFingerprintOfEvaluator

When running Routing Model with 105 vehicles and 250 locations and using :
addDimensionWithVehicleCapacity for weight,
addDimension for time and setArcCostEvaluatorOfVehicle for each vehicle I have this error :
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
C  [libjniortools.dylib+0x683d2]  operations_research::RoutingModel::GetFingerprintOfEvaluator(ResultCallback2<long long, IntType<operations_research::_RoutingModel_NodeIndex_tag_, int>, IntType<operations_research::_RoutingModel_NodeIndex_tag_, int> >*) const+0x112
C  [libjniortools.dylib+0x68c3b]  operations_research::RoutingModel::ComputeCostClasses()+0x67b
C  [libjniortools.dylib+0x6c503]  operations_research::RoutingModel::CloseModel()+0x93
C  [libjniortools.dylib+0x70ba1]  operations_research::RoutingModel::Solve(operations_research::Assignment const*)+0x21
C  [libjniortools.dylib+0x38c6b]  Java_com_google_ortools_constraintsolver_operations_1research_1constraint_1solverJNI_RoutingModel_1solveWithParameters+0x1b
j  com.google.ortools.constraintsolver.operations_research_constraint_solverJNI.RoutingModel_solveWithParameters(JLcom/google/ortools/constraintsolver/RoutingModel;JLcom/google/ortools/constraintsolver/RoutingSearchParameters;JLcom/google/ortools/constraintsolver/Assignment;)J+0
j  com.google.ortools.constraintsolver.RoutingModel.solveWithParameters(Lcom/google/ortools/constraintsolver/RoutingSearchParameters;Lcom/google/ortools/constraintsolver/Assignment;)Lcom/google/ortools/constraintsolver/Assignment;+15

This is probably caused by the size of the instance but the error is not really explicit.
I have the possibility to use a microservice to run Or-tools RoutingModel. Should I use Python instead of java or will I have the same issues and do I need to switch to pure c++ ?

The problem is rather small so I don't think size is directly an issue. I'm
trying to reproduce this but my guess is that it could be due to something
going wrong with the evaluators you pass to setArcCostEvaluatorForVehicle.
Do you create them on the fly ? Do you keep a reference to avoid having the
GC clean them up ?
Vincent
On Wed, Mar 16, 2016 at 7:13 PM, Thomas<EMAIL_ADDRESS>wrote:

When running Routing Model with 105 vehicles and 250 locations and using :
addDimensionWithVehicleCapacity for weight,
addDimension for time and setArcCostEvaluatorOfVehicle for each vehicle I
have this error :
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
C  [libjniortools.dylib+0x683d2]  operations_research::RoutingModel::GetFingerprintOfEvaluator(ResultCallback2<long long, IntType<operations_research::RoutingModel_NodeIndex_tag, int>, IntType<operations_research::RoutingModel_NodeIndex_tag, int> >) const+0x112
C  [libjniortools.dylib+0x68c3b]  operations_research::RoutingModel::ComputeCostClasses()+0x67b
C  [libjniortools.dylib+0x6c503]  operations_research::RoutingModel::CloseModel()+0x93
C  [libjniortools.dylib+0x70ba1]  operations_research::RoutingModel::Solve(operations_research::Assignment const)+0x21
C  [libjniortools.dylib+0x38c6b]  Java_com_google_ortools_constraintsolver_operations_1research_1constraint_1solverJNI_RoutingModel_1solveWithParameters+0x1b
j  com.google.ortools.constraintsolver.operations_research_constraint_solverJNI.RoutingModel_solveWithParameters(JLcom/google/ortools/constraintsolver/RoutingModel;JLcom/google/ortools/constraintsolver/RoutingSearchParameters;JLcom/google/ortools/constraintsolver/Assignment;)J+0
j  com.google.ortools.constraintsolver.RoutingModel.solveWithParameters(Lcom/google/ortools/constraintsolver/RoutingSearchParameters;Lcom/google/ortools/constraintsolver/Assignment;)Lcom/google/ortools/constraintsolver/Assignment;+15
This is probably caused by the size of the instance but the error is not
really explicit.
I have the possibility to use a microservice to run Or-tools RoutingModel.
Should I use Python instead of java or will I have the same issues and do I
need to switch to pure c++ ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/google/or-tools/issues/164

My initial guess was also related to GC and the initial implementation was :
    for (int vehicleIndex = 0; vehicleIndex < initialValues.numberOfVehicles(); vehicleIndex++) {
      final Vehicle vehicle = initialValues.vehiclesAsJava().get(vehicleIndex);
      final List<List<Long>> costMatrix = CostMatrixBuilder.apply(vehicle, initialValues).matrix(locations);

      final NodeEvaluator2 arcCostCallback = new NodeEvaluator2() {
        @Override
        public long run(int firstNode, int secondNode) {
          return costMatrix.get(firstNode).get(secondNode);
        }
      };

      routingModel.setArcCostEvaluatorOfVehicle(arcCostCallback, vehicleIndex);
    }

I switched to :
    for (int vehicleIndex = 0; vehicleIndex < initialValues.numberOfVehicles(); vehicleIndex++) {
      final Vehicle vehicle = initialValues.vehiclesAsJava().get(vehicleIndex);
      costMatrices.add(CostMatrixBuilder.apply(vehicle, initialValues).matrix(locations));

      final int index = vehicleIndex
      final NodeEvaluator2 arcCostCallback = new NodeEvaluator2() {
        @Override
        public long run(int firstNode, int secondNode) {
          return costMatrices.get(index).get(firstNode).get(secondNode);
        }
      };

      routingModel.setArcCostEvaluatorOfVehicle(arcCostCallback, vehicleIndex);
    }

where costMatrices is an instance variable but no much luck. The GC is quite aggressive :/

To ease debugging, you can also try disabling evaluator fingerprinting
(which is used to create evaluator equivalence classes) by setting search
parameters as follows:
RoutingSearchParameters parameters =
RoutingSearchParameters.newBuilder()
.mergeFrom(RoutingModel.defaultSearchParameters())
.setFingerprintArcCostEvaluators(false)
.build();
and then calling solveWithParameters(parameters); instead of solve().
On Thu, Mar 17, 2016 at 10:34 AM, Vincent Furnon<EMAIL_ADDRESS>wrote:

The problem is rather small so I don't think size is directly an issue.
I'm trying to reproduce this but my guess is that it could be due to
something going wrong with the evaluators you pass to
setArcCostEvaluatorForVehicle. Do you create them on the fly ? Do you keep
a reference to avoid having the GC clean them up ?
Vincent
On Wed, Mar 16, 2016 at 7:13 PM, Thomas<EMAIL_ADDRESS>wrote:

When running Routing Model with 105 vehicles and 250 locations and using
:
addDimensionWithVehicleCapacity for weight,
addDimension for time and setArcCostEvaluatorOfVehicle for each vehicle
I have this error :
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
C  [libjniortools.dylib+0x683d2]  operations_research::RoutingModel::GetFingerprintOfEvaluator(ResultCallback2<long long, IntType<operations_research::RoutingModel_NodeIndex_tag, int>, IntType<operations_research::RoutingModel_NodeIndex_tag, int> >) const+0x112
C  [libjniortools.dylib+0x68c3b]  operations_research::RoutingModel::ComputeCostClasses()+0x67b
C  [libjniortools.dylib+0x6c503]  operations_research::RoutingModel::CloseModel()+0x93
C  [libjniortools.dylib+0x70ba1]  operations_research::RoutingModel::Solve(operations_research::Assignment const)+0x21
C  [libjniortools.dylib+0x38c6b]  Java_com_google_ortools_constraintsolver_operations_1research_1constraint_1solverJNI_RoutingModel_1solveWithParameters+0x1b
j  com.google.ortools.constraintsolver.operations_research_constraint_solverJNI.RoutingModel_solveWithParameters(JLcom/google/ortools/constraintsolver/RoutingModel;JLcom/google/ortools/constraintsolver/RoutingSearchParameters;JLcom/google/ortools/constraintsolver/Assignment;)J+0
j  com.google.ortools.constraintsolver.RoutingModel.solveWithParameters(Lcom/google/ortools/constraintsolver/RoutingSearchParameters;Lcom/google/ortools/constraintsolver/Assignment;)Lcom/google/ortools/constraintsolver/Assignment;+15
This is probably caused by the size of the instance but the error is not
really explicit.
I have the possibility to use a microservice to run Or-tools
RoutingModel. Should I use Python instead of java or will I have the same
issues and do I need to switch to pure c++ ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/google/or-tools/issues/164

You also have to store the callbacks outside the loop with something like
this to keep the callbacks safe from the GC:
for (int vehicleIndex = 0; vehicleIndex < initialValues.numberOfVehicles();
vehicleIndex++) {
final Vehicle vehicle =
initialValues.vehiclesAsJava().get(vehicleIndex);
costMatrices.add(CostMatrixBuilder.apply(vehicle,
initialValues).matrix(locations));
  final int index = vehicleIndex;
  arcCostCallbacks.add(new NodeEvaluator2() {
    @Override
    public long run(int firstNode, int secondNode) {
      return costMatrices.get(index).get(firstNode).get(secondNode);
    }
  });

  routingModel.setArcCostEvaluatorOfVehicle(arcCostCallbacks[index],

vehicleIndex);
}
On Thu, Mar 17, 2016 at 11:08 AM, Thomas<EMAIL_ADDRESS>wrote:

My initial guess was also related to GC and the initial implementation was
:
for (int vehicleIndex = 0; vehicleIndex < initialValues.numberOfVehicles(); vehicleIndex++) {
  final Vehicle vehicle = initialValues.vehiclesAsJava().get(vehicleIndex);
  final List<List<Long>> costMatrix = CostMatrixBuilder.apply(vehicle, initialValues).matrix(locations);

  final NodeEvaluator2 arcCostCallback = new NodeEvaluator2() {
    @Override
    public long run(int firstNode, int secondNode) {
      return costMatrix.get(firstNode).get(secondNode);
    }
  };

  routingModel.setArcCostEvaluatorOfVehicle(arcCostCallback, vehicleIndex);
}

I switched to :
for (int vehicleIndex = 0; vehicleIndex < initialValues.numberOfVehicles(); vehicleIndex++) {
  final Vehicle vehicle = initialValues.vehiclesAsJava().get(vehicleIndex);
  costMatrices.add(CostMatrixBuilder.apply(vehicle, initialValues).matrix(locations));

  final int index = vehicleIndex
  final NodeEvaluator2 arcCostCallback = new NodeEvaluator2() {
    @Override
    public long run(int firstNode, int secondNode) {
      return costMatrices.get(index).get(firstNode).get(secondNode);
    }
  };

  routingModel.setArcCostEvaluatorOfVehicle(arcCostCallback, vehicleIndex);
}

where costMatrices is an instance variable but no much luck. The GC is
quite aggressive :/
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/google/or-tools/issues/164#issuecomment-197801145

It seems to be lot more stable with callbacks outside the loop !
I was not able to find setFingerprintArcCostEvaluators in the jar.
Manifest-Version: 1.0
Created-By: 1.8.0-google-v7 (Google Inc.)

On Thu, Mar 17, 2016 at 11:51 AM, Thomas<EMAIL_ADDRESS>wrote:

It seems to be lot more stable with callbacks outside the loop !

By stable do you mean it works now ?

I was not able to find setFingerprintArcCostEvaluators in the jar.

Are you importing
com.google.ortools.constraintsolver.RoutingSearchParameters ? Anyways, if
the problem is fixed you don't need that anymore.

Manifest-Version: 1.0
Created-By: 1.8.0-google-v7 (Google Inc.)
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/google/or-tools/issues/164#issuecomment-197817014

It works for medium instances but I now have an issue with my JVM size (2Go is not enough).
I'll look into that.
About RoutingSearchParameters, I'm already using that :
      final RoutingSearchParameters routingSearchParameters = new RoutingSearchParameters();
      final RoutingParameters globalParameters = new RoutingParameters();
      globalParameters.setUse_light_propagation(true);
      RoutingModel.setGlobalParameters(globalParameters);

      routingModel.setFirstSolutionStrategy(RoutingModel.ROUTING_ALL_UNPERFORMED);
      routingSearchParameters.setFirst_solution("PathCheapestArc");
      routingSearchParameters.setTrace(true);
      routingSearchParameters.setNo_lns(true);

      final Optional<Assignment> assignment = Optional.ofNullable(routingModel.solveWithParameters(routingSearchParameters, null));

Are those parameters still useful ?
It looks like I'm not using the up to date version of OrTools because I can't compile https://github.com/google/or-tools/blob/0e6b0304bacac754864190eea416924aaa9a07ba/examples/com/google/ortools/samples/Tsp.java

I did not update binary archives. You need to compile from sources.
Hopefully, I will be able to build them soon.
Thanks
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
2016-03-17 18:21 GMT+01:00 Thomas<EMAIL_ADDRESS>
It works for medium instances but I now have an issue with my JVM size
(2Go is not enough).
I'll look into that.
About RoutingSearchParameters, I'm already using that :
  final RoutingSearchParameters routingSearchParameters = new RoutingSearchParameters();
  final RoutingParameters globalParameters = new RoutingParameters();
  globalParameters.setUse_light_propagation(true);
  RoutingModel.setGlobalParameters(globalParameters);

  routingModel.setFirstSolutionStrategy(RoutingModel.ROUTING_ALL_UNPERFORMED);
  routingSearchParameters.setFirst_solution("PathCheapestArc");
  routingSearchParameters.setTrace(true);
  routingSearchParameters.setNo_lns(true);

  final Optional<Assignment> assignment = Optional.ofNullable(routingModel.solveWithParameters(routingSearchParameters, null));

Are those parameters still useful ?
It looks like I'm not using the up to date version of OrTools because I
can't compile
https://github.com/google/or-tools/blob/0e6b0304bacac754864190eea416924aaa9a07ba/examples/com/google/ortools/samples/Tsp.java
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/google/or-tools/issues/164#issuecomment-197984468


Feat qdrant metadata filtering

Description
Qdrant has built-in filtering capabilities which weren't reflected in Llama Index. This PR introduces that mechanism to the Qdrant vector store.
In addition to that, I fixed the ExactMatchFilter implementation. It was using Union[str, int, float] instead of strict types what was resulting in a wrong type when applying integers or floats (or all were converted to strings). ExactMatchFilter(key="test", value=1) was converted to ExactMatchFilter(key="test", value="1").
For reference: https://docs.pydantic.dev/latest/usage/types/#strict-types
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
The unit tests are included. They cover all the supported types.

[x] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[ ] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@NirantK I'd appreciate your review on that

@kacperlukawski is there a way for me/Llama Index users to try this API e.g. a Jupyter notebook or tests?

@NirantK Tests are included in the PR. Besides, it works the same way as in all the other vector stores, so I didn't include any notebook. Do you think it's essential to have one?

@kacperlukawski sorry for the delay on looking at this. Is this good to go from your point of view?

@logan-markewich Yes, this is a relatively simple change, but much awaited by our users. To my mind, this is ready to be released.


Re-implement the SA1004 code fix using efficient text manipulation

:+1: looks good beside a minor remark.


Shop Items

It would be nice to have to see the evaluation as well on items in the shops

Good idea. havent thought about that one. Will think about a good way to include this. But not sth I am planning to "quickly" add. We keep this issue open for the time being.

Should be supported with v3.2.5


Whats New Post

Write a what's new blog post entry.

[x] Find an owner

Make sure we link to the blog post: https://github.com/cdk8s-team/cdk8s/issues/680


Moving the map causes random zoom

I have the same problem on ubuntu and android I thinks is related to performance and workload because it tends to happen more on high zoom where more tiles are displayed and also if I have a lot of markers or things going on. When reducing MAX_WORKERS it tends to happen less. So it probably happens in the RPi 3b because of the low resources. Is there a way to optimize this?
Originally posted by @ocobacho in https://github.com/kivy-garden/garden.mapview/issues/69#issuecomment-503144772

@AndreMiras @tshirtman @zworkb @tito  Hello. I also have this problem on ubuntu, mac os and android. I tried debug it and found some mistake in on_transform method:
def on_transform(self, *args):         self._invalid_scale = True         if self._transform_lock:             return         self._transform_lock = True         # recalculate viewport         map_source = self.map_source         zoom = self._zoom         scatter = self._scatter         scale = scatter.scale  # here         if scale >= 2.:             zoom += 1             scale /= 2.         elif scale < 1:             zoom -= 1             scale *= 2. ...
scatter.scale returns value >= 2 without any tries to change zoom.


Cope with missing version attribute on module

Fixes https://github.com/bazel-contrib/publish-to-bcr/issues/95
The version attribute is technically required for non-root modules, but it should be ok for repos to not have it if they use the publish-to-bcr-bot to automatically patch it in when publishing to BCR.

Thanks for the fix! I'd like to get a new fixture/e2e in to test this. Let me know if you want to do that, else I can take it over from here.

Pushed some small fixes and additional tests.


[r] Re-order methods in ephemeral.R

This is a line-count-reducing PR which will help simplify PR #1325 for issue #1346.
It groups methods in R/ephemeral.R in what feels like a more intuitive order.
This is not strictly necessary of course; but on #1325 I found this a friction-reducer while reasoning about behavior of the ephemeral classes.

Codecov Report
Patch coverage has no change and project coverage change: -11.72 :warning:

Comparison is base (cf3ad21) 65.11% compared to head (25a09db) 53.40%.

:exclamation: Current head 25a09db differs from pull request most recent head 9bcab02. Consider uploading reports for the commit 9bcab02 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1359       +/-   ##
===========================================
- Coverage   65.11%   53.40%   -11.72%
===========================================
  Files          91       61       -30
  Lines        7583     5187     -2396
===========================================
- Hits         4938     2770     -2168
+ Misses       2645     2417      -228

Flag
Coverage Δ

python
?

r
53.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 31 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


System volume Information & Control

Is it possible to use this library to get the current system volume and even controlling it?

If there is, would expect it to be under the Windows.Media namespace.

@dlech I am not able to find this option for the volume.
Could you help me locate it or suggest a code that does this?


the month March does not appear in the label Month

The display of the month March does not appear in the label Month! 2020.02 instead of [2020.03]([url](

The time zone offset has changed in your area when comparing the current time with the time a month ago.
This issue occurs when today's date is 1st, and when the time zone changes in the previous month
For example,
I don't know which area you live in.
As of March 8th, it is assumed that the DST has been applied and the time zone offset for the region has changed.
Wed Apr 01 2020 00:00:00 GMT-0600  // today (DST is applied)

// 'prev' button click!
// Then, cal.getDate()
Sun Mar 01 2020 00:00:00 GMT-0700 // standard time

In the calendar instance, getDate() returns 00:00:00 on March 1st.
Since the date is calculated based on the time zone, it is 23:00 on February 29th.
Service level example code script but need to be improved.
when the current date is 1st,
How about counting by adding one day ?


BUG: SSL certificate for lndrest is required even though it could be a publicly issued one

related to https://github.com/lnbits/lnbits/issues/1635

Codecov Report

Merging #1636 (c210316) into main (fe315d0) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

:exclamation: Current head c210316 differs from pull request most recent head b63515e. Consider uploading reports for the commit b63515e to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #1636      +/-   ##
==========================================
- Coverage   46.32%   46.14%   -0.18%
==========================================
  Files          47       47
  Lines        6875     6880       +5
==========================================
- Hits         3185     3175      -10
- Misses       3690     3705      +15

Impacted Files
Coverage Δ

lnbits/wallets/lndrest.py
14.51% <0.00%> (-0.61%)
:arrow_down:

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

For me the patch works ;-)
Need to be merged! :-)
P.S. Hi from Nostr network, @callebtc ;-)


Multilevel menu

Does the library supports multilevel menu ?

Hi @debjitk,
The library dies not support this currently. It would be a very nice feature though!

We really need this

Hi, could you describe your use case, please? How should it look like, what devices are you targeting etc.?
I've just had a look at the latest Material Design guidelines (https://material.io/design/components/menus.html#dropdown-menu) and cascading menus are actually marked as Desktop only.
Personally, I'm not sure if there's simply enough space to put it on phones (maybe just on tablets).

Hi @zawadz88,
Multilevel menu doesn't mean a Cascading menu.
It means the same behavior of standard contextmenu: menu items with a submenu have an arrow. Clicking on the item itself shows the submenu and hides the main menu.
Main menu and submenu are not visible at the same time.
Regards

Hi @marbat87,
I don't see it in the spec so I'm not sure how this should behave (animations, anchors, etc.).
However, what you're describing should be possible by e.g. using a custom item in the top level menu so that it has the arrow at the end. When this item gets clicked you could simply open a new menu.
Wouldn't that do the trick?

@zawadz88  Yes it should work. I just thought is was easy to implement as standard contextmenu manages it yet.
Thanks

Ah, right. I understand now what you had in mind. I'll try to have a look - shouldn't be too hard.
I thought the issue was about something else from start...
Thanks for clarification

You don't need a custom item actually.
I've modified one of the samples to achieve this:

Code:
    override fun onOptionsItemSelected(item: MenuItem): Boolean {
        if (item.itemId == R.id.overflow) {
            val anchor = checkNotNull<View>(findViewById(R.id.overflow))
            val popupMenu = popupMenu {
                style = R.style.Widget_MPM_Menu //optional, light is the default
                dropdownGravity = Gravity.END
                section {
                    title = "Editing"
                    item {
                        label = "Copy"
                        icon = R.drawable.abc_ic_menu_copy_mtrl_am_alpha
                        callback = {
                            Toast.makeText(this@LightActivity, "Copied!", Toast.LENGTH_SHORT).show()
                        }
                    }
                    item {
                        label = "Paste"
                        iconDrawable = ContextCompat.getDrawable(this@LightActivity, R.drawable.abc_ic_menu_paste_mtrl_am_alpha)
                    }
                }
                section {
                    item {
                        label = "Share me please"
                        callback = {
                            shareUrl()
                        }
                    }
                    item {
                        label = "Multi-level"
                        callback = {
                            val nestedPopupMenu = popupMenu {
                                style = R.style.Widget_MPM_Menu //optional, light is the default
                                dropdownGravity = Gravity.END
                                section {
                                    title = "Second level"
                                    item {
                                        label = "Copy"
                                    }
                                    item {
                                        label = "Paste"
                                    }
                                }
                            }

                            nestedPopupMenu.show(this@LightActivity, anchor)
                        }
                    }
                }
            }

            popupMenu.show(this@LightActivity, anchor)
            return true
        }
        return false
    }

@debjitk @jrcacd @marbat87 Is that what you guys had in mind?

That's the wanted behavior, but actually items with a submenu show like the image below in the standard contextmenu (screenshot taken from Android 8.1).
We can achieve that only with a custom object in MaterialPopupMenu.

Hi @marbat87 ,
Could you post the code you used for creating this with a standard context menu?

Regarding ContextMenus, this can look like this:

which can be achieve by adding in Activity:

    override fun onCreateContextMenu(menu: ContextMenu, v: View, menuInfo: ContextMenu.ContextMenuInfo?) {
        super.onCreateContextMenu(menu, v, menuInfo)
        menu.setHeaderTitle("Context Menu")
        menu.add(0, v.id, 0, "Upload")
        menu.add(0, v.id, 0, "Search")
        menu.add(0, v.id, 0, "Share")
        menu.add(0, v.id, 0, "Bookmark")
        val subMenu = menu.addSubMenu("Submenu")
        subMenu.setHeaderTitle("title")
        subMenu.add(0, v.id, 0, "Nested1")
        subMenu.add(0, v.id, 0, "Nested2")
        subMenu.add(0, v.id, 0, "Nested3")
    }

and somewhere in onCreate:
registerForContextMenu(clickedView)

Released in 3.4.0

Can we create like this?
popupMenu {
            section {
                title = R.string...
                item {
                    label = R.string...
                    icon = R.drawable...
                    iconColor = ...
                    callback = { }
                }

                item {
                    label = R.string...
                    icon = R.drawable...
                    iconColor = ...
                    callback = { )
                    }
                }
            }

            **submenu** {
                title = R.string...
                item {
                    label = R.string...
                    icon = R.drawable...
                    iconColor = ...
                    callback = { }
                }

                item {
                    label = R.string...
                    icon = R.drawable...
                    iconColor = ...
                    callback = { }
                }
            }
        }

Hi @jrcacd,
Not in 3.4.0. There's an example in the sample app of how to do this in a different way.
Regarding the DSL proposition - I'm not sure if putting submenu on the same level as section is a good idea. It should probably be under section or item.
There's also one more issue I see with having submenus supported this way. popupMenu returns a menu object on which we call show with Context and an anchor View. We can also use it to dismiss that menu. The submenu is actually a different menu so I'm not sure how to tackle this.
I'm open to suggestions and PRs regarding this. However, since basic submenu support is already added in 3.4.0 I'd suggest moving any DSL enhancements to a separate issue.


Fix random fails on TestPerform

What this PR does / why we need it:
Fix random fails on TestPerform caused by missing sync.Mutex
Special notes for your reviewer:
Also some small changes by static analysis
If applicable:

[ ] this PR contains documentation
[x] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

Hello, any reviewers?

@mattfarina can you please review this?


A web ui for celerymon

Its not much but gives some realtime information as to whats happening in celery.

Implemented Tornado Static File Handler
Moved endpoints definition from individual classes back into main (caused problems with static file handler, for now easier to remove than fix)
Took default css and logo from celeryproject.org and used for base template
Added since param to /api/tasks to return only tasks executed since a timestamp
Added auto updating graph to root page showing realtime task status events

This is amazing!  I have been waiting for someone to do this since I started the project, so I think I love you now.
Though, it doesn't seem like the templates are enabled?  At least I can't see any changes after merging, did you commit all files?

Its good to be loved!
Something went amiss when i committed the files, it seems it committed only the new files and not the existing files that had been modified where committed yet the status showed that everything was up to date. heyho lastest commit has the files it was missing.


openapi docs: /presignedurl, not /presigned

https://github.com/nhost/hasura-storage/blob/5bd777d6c2bdfbdcb31b2a1db29f47d10b39ec5c/controller/openapi.yaml#LL520C5-L520C5
Look, there are /presigned in docs, but in reality corrrect url is /presignedurl

Thanks for reporting, fixed.


Spring Boot - add config options for WorkerFactory and Workers

Currently it's not possible to define worker factory and worker options via properties/yaml config.
Seems only way is to autowire WorkerFactory and create own workers that then can be configured as needed.
Please add this feature if possible. Thanks.

+1
The doc for the spring-boot autoconfigure module says the below

'# start-workers: false # disable starting WorkersFactory if you want to make any custom changes before the start'

But this flag just defers the factory.start() call as can be seen here, but can't override or make custom changes to the workers already created by the module here, say in terms of passing in WorkerOptions for tuning them.
Defining  worker options via properties/yaml config allows to mitigate the above constraint.


Add Safari 17.5

It'd be helpful if you could add Safari 17.5 into the system.

Done and done!


Zero-Shot on ADE20k

Because other approaches like ODISE and Mask2Former evaluate on ADE20k,  I was wondering if there was a script or summary of instructions on how to evaluate on cross-dataset on ADE20k-150?
Thanks so much!

I appreciate your interest in our work.
Thanks to the MMSeg toolkit, our model can be easily tested on ADE20K-150 by following these step:

Write 'configs/base/datasets/dataloader/ade.py' based on the '/Path/to/site-packages/mmseg/datasets/ade.py'. The evaluation function needed to be modified for better display.
Write 'configs/open_vocabulary/coco-to-ade.py'. Please refer to the script 'configs/cross_dataset/coco-to-context.py'.
If desired, prepare the text embeddings of ADE20K for faster inference using 'configs/base/datasets/text_embedding/get_embedding.ipynb'.
Ensure that the ADE20K dataset is prepared in MMSeg format.
Run this command for evaluation on ADE20K: python test.py ./configs/cross_dataset/coco-to-ade.py Path/to/coco/vpt_seg_zero_80k_12_100_multi/iter_80000.pth --eval=mIoU

We hope that these steps will be helpful for testing our model on ADE20K-150 using the MMSeg toolkit.