Python 3 upgrade manual beta testing

This is a checklist for a Manual pre-deploy check list used in the past.  It should help us be thorough in testing the far corners of HydroShare.  https://docs.google.com/document/d/1iHySO-5Kpfp1sBgixWj-Hv0yFy95WUVPvsmg2JmURaU
3 Testing Profile

[x] 3.1 Sign Up
[x] 3.2 Sign In
[x] 3.3 Reset Password
[x] 3.4 Profile Editing

4 Testing Homepage

[x] 4.1 Testing links in Header Section
[x] 4.2 Testing links in Body Section
[x] 4.3 Testing links in Footer Section

5 Testing Resources

[ ] 5.1 General Functions

[x] 1) My resources
[x] 2) resource creation
[ ] 3) resource editing
[ ] 4) resource publication
[ ] 5) resource versioning

6 Resource Copying

[ ] Resource Copying

7 Resource Specific Functions

[ ] 7.1 Time Series
[ ] 7.2 HIS time Series
[ ] 7.3 Geographic Raster
[ ] 7.4 Geographic Feature
[ ] 7.5 Multidimensional
[ ] 7.6 Model Program
[ ] 7.7 Model Instance
[ ] 7.8 SWAT Model Instance
[ ] 7.9 Web App
[ ]  7.10 Script
[ ] 7.11 Collection
[ ] 7.12 Composite

8 Testing Access Control

[ ] 8.1 Sharing Status
[ ] 8.2 Manage Access

9 Testing Discover

[ ] 9.1 Text Search
[ ] 9.2 Map search

10 Testing Terms Page

[ ]

https://github.com/hydroshare/hydroshare/issues/3735
https://github.com/hydroshare/hydroshare/issues/3736
https://github.com/hydroshare/hydroshare/issues/3737
https://github.com/hydroshare/hydroshare/issues/3738
https://github.com/hydroshare/hydroshare/issues/3739

Made patch https://github.com/hydroshare/hydroshare/pull/3726/commits/e0c6d65c7473bcc4596722787880c6c8a3a1a6b4 to fix an issue with adding files from irods user zone to a resource.


Gauging interest in niche certificate profiles (ETSI / Eidas / NL)

Internally we'll be going to extending a linter (1 or more) with additional rules to check all cases relevant to our use case. We're a QTSP in the Netherlands and are interested in linting a very specific certificate profile, namely a certificate for natural person qualified signatures (G4 Individual Validated eSig).
Other than some pkio (Dutch government pki) rules it's mostly a combination of common rulesets and ETSI rules, namely NCP+ (<IP_ADDRESS>2.1.2) and QCP-n-qscd (<IP_ADDRESS>112.1.2).
Is there interest in having these rules (partially) merged back upstream? How would you suggest formatting such rules in the current codebase?

Hi @breynders-cb, thank you for filing this. We would be excited to work with you on adding this support.
pkilint already has comprehensive support for linting QWACs, so many of the lints for the EN 319 412 document series are already in place. Expanding on that support to encompass the NCP+ and QCP-n-qscd profiles would not be very difficult. Once such support is in place, PKIO-specific lints can be added on top rather easily.
I'm open to either collaborating on this Github issue or via email (my email can be found in the contact information for the pkilint maintainer), whichever you prefer.

Thanks for the fast response! We'll get started with some basic rules, I'll ask questions either in a properly scoped issue, through email or through PR.

@breynders-cb Great to hear that there's interest in the PKIO-specific lints! Coincidentally, we're also in the process of adding PKIO lints to PKIlint. To avoid duplicating efforts, would you be open to sharing more details about the profiles you're planning to implement and your timeline?

Awesome to hear that there's more interest!
We're going to focus on check and adding some ETSI rules that are used for our PKIO usecase namely the profiles:

NCP+ (<IP_ADDRESS>2.1.2)
QCP-n-qscd (<IP_ADDRESS>112.1.2)

We'll focus on extending 411-1, 411-2 and 412-2 first. We don't have a timeline yet but are starting work on it in the coming days.


[SVCS-617] Improving the Very Limited Google Cloud Storage Provider

Ticket
https://openscience.atlassian.net/browse/SVCS-617
Purpose
Further improves the Google Cloud Storage Provider. Work continues from https://github.com/CenterForOpenScience/waterbutler/pull/322.
Changes

[x] Improve and update unit tests
[ ] Respond to CR: https://github.com/CenterForOpenScience/waterbutler/pull/322#pullrequestreview-103062273

Side Effects
No
QA Notes
Multiple PRs, please refer to the ticket: https://openscience.atlassian.net/browse/SVCS-617
Deployment Notes
In-person discussion

Coverage increased (+0.7%) to 89.996% when pulling 6d0934cf9b5bd8fcaf04c52048c8bee3e0fdca6d on cslzchen:feature/svcs-617-limited-googlecloud into 486353322bbef7b7384e49eb43c7c584da8496dc on CenterForOpenScience:develop.

Coverage increased (+0.7%) to 89.996% when pulling 6d0934cf9b5bd8fcaf04c52048c8bee3e0fdca6d on cslzchen:feature/svcs-617-limited-googlecloud into 486353322bbef7b7384e49eb43c7c584da8496dc on CenterForOpenScience:develop.


Cannot exit :term insert mode with Ctrl-\ Ctrl-N

Describe the bug
On Windows, I am unable to exit insert mode in the terminal (:term) by using <C-\><C-n>. Instead, the literal characters ^N are added as input.
To Reproduce
Steps to reproduce the behavior:

Open neovide
Type :term
Enter insert mode: i
Unable to exit with <C-\><C-n>

Expected behavior
Should be able to exit terminal mode. This is the functionality in nvim-qt and nvim in console.
Desktop (please complete the following information):

OS: Windows 10
Neovide Version: v0.7.0
Neovim Version: v0.5.0

Neovide Log
https://gist.github.com/baileyn/91358aa4602a6d3d6af8fc7ae2bdeff2
Additional Information
It seems that remapping the keys via something like :tnoremap <Esc> <C-\>C-n> works. So it's a work around.

Wasn't able to reproduce. Tried both, 0.7.0 preview in Releases (neovide7-prev in the video) and latest commit that compiled in CI (neovide). I am using the built-in terminal quite often and never got anything like that.
https://user-images.githubusercontent.com/20644474/126058084-89d97389-f1d8-43f9-bc93-aa74e1882260.mp4
Logs
neovide_rCURRENT.log
neovide7-prev_rCURRENT.log

If one just presses <C-n> it does indeed give just the ^N, but that's by neovim's design. I am not sure, but maybe something's wrong with the <C-\> on your setup? Try doing tnoremap <Esc> <C-\><C-n> and hitting ESC in the terminal mode.

Hmm it's weird this behavior seems to only happen in Neovide on my machine. I have since mapped  to <C-\><C-n>. I just thought it was an issue so I figured I would bring it up.
I suppose if it's not able to be reproduced it must be something on my end; a bit strange.

Keep it here anyway, maybe someone else will have a problem like that.

Try to add this to you init.vim
tnoremap <Esc> <C-\><C-n>

Very old. Current keyboard handling is very different


Feature Request: Influx CLI

The influx cli keeps a history of recent commands that were executed which can be accessed using the 'up' arrow key. This is an extremely useful feature on the CLI.
It would be nice to have a CLI specific command that behaves  like bash shell's 'history' command.
The output of the command could be a dump of recent commands on the console.

As a workaround in the meantime you can scan the history file itself at ~/.influx_history

@beckettsean Thanks for the note.

Adding support for the command history to the CLI would not be difficult. Simply look into how the existing code reads the commands at the CLI (help for example) and if history is entered, dump the contents of the history file.

It seems the library used for writing the history file doesn't expose a method to read the history stored in-memory. So the question is whether to fork it and try a PR or implement our own history management.
Hints?

Would it be that difficult to implement our own? It doesn't seem that difficult -- it's just a file with commands in there.
We tend to avoid 3rd party libraries if we can help it, so using our own would align better.

@otoolep on it :+1:

Unfortunately, liner is used all over the place so moving from it would become more than just implementing history support.
That said, I'll keep it simple.


Platformio build error on usb_service_protocol in stable

Platformio doesn't build on the SAMD21 with the usb_service_protocol. with error:
lib\Manikin_Software_Libraries\modules\usb_service_protocol\src\usb_service_protocol.cpp: In function 'void usb_service_protocol::SetPollingTask(tskTaskControlBlock**)':
lib\Manikin_Software_Libraries\modules\usb_service_protocol\src\usb_service_protocol.cpp:325:20: error: 'xTaskCreateStatic' was not declared in this scope; did you mean 'xTaskCreate'?
  325 |     *task_handle = xTaskCreateStatic(
      |                    ^~~~~~~~~~~~~~~~~
      |                    xTaskCreate
*** [.pio\build\samd21\lib0d0\Manikin_Software_Libraries\usb_service_protocol\src\usb_service_protocol.cpp.o] Error 1
======================================================= [FAILED] Took 11.33 seconds =======================================================

with platform.ini:
[env]
test_framework = googletest

[env:samd21]
platform = atmelsam
board = adafruit_feather_m0_express
framework = arduino
lib_deps = https://github.com/BriscoeTech/Arduino-FreeRTOS-SAMD21
           https://github.com/RobotPatient/Manikin_Software_Libraries
           https://github.com/adafruit/Adafruit_SPIFlash.git
           Wire
build_unflags = -std=gnu++11
build_flags = -std=c++17
debug_tool = atmel-ice

It might be possible that the freeRTOS does not support this function/feature on the samd21. any ideas?

The standard freertos config doesn't allow static task and queue allocation. Therefore try to set our own fork with custom options in platformio: https://github.com/RobotPatient/Arduino-FreeRTOS-SAMD21

Good to know, thanks!


node type to node role in index.md under network-architecture

Addressing this PR comment from earlier

thank you for the update 🙇


Update canvas-renderer.ts to fix Vertical alignment issues with text

Bug 1 Fixes vertical alignment of text within divs - issue shown here: https://github.com/niklasvh/html2canvas/issues/2937

Now the fillText usage logically makes sense

Tested across Chrome, Firefox, Safari

Before:

After:

Can we merge it?

Hey, this was approved for close to a year now? Can we merge it?

Can be tested in @cantoo/html2canvas

I tried this out and for me the text got justified too much.
Latest release:

With this patch:

I have done a little more research into this, and it seems that the calculation is using the incorrect parameters. The baseline should actually be the font size in px. Will make a new PR.

Ah, damn. @acurrieclark do you mind pushing your fix to this project too: https://github.com/cantoo-scribe/html2canvas ? This one seems a bit abandoned and I tried to merge the most promising PRs inside it

@Sharcoux in case you didn't see, I raised this as an issue on your fork. There are a couple of possible solutions to the problem. I have found one which fixes things on my end, but it may not be the most general solution.


Port swift-lldb to Windows

@swift-ci please test

@swift-ci please test Linux Platfor

@swift-ci please test Linux Platform

@swift-ci please test Linux Platform

@kubamracek
@tfiala
@scallanan
@clayborg
PTAL, thanks

@hughbe, I'm no longer at Apple and currently my schedule doesn't allow time for working on Swift on the side.  I need to bow out of your request.

No problem - I saw you reviewed the old PR. That one had been signed of by everyone but never got merged and was targeting the wrong branch. Anyways, good luck!

Thanks!
On Thu, Feb 23, 2017 at 8:46 AM Hugh Bellamy<EMAIL_ADDRESS>wrote:

No problem - I saw you reviewed the old PR. That one had been signed of by
everyone but never got merged and was targeting the wrong branch. Anyways,
good luck!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apple/swift-lldb/pull/125#issuecomment-282048866, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAJScS45QIscg2ynPM3mFZxuzq7KCJYbks5rfbfMgaJpZM4Lwep_
.

--
-Todd

I think it would be best to split this patch, because it contains a lot of unrelated changes.  Could we get one patch that is a NFC change fixing the more "stylistic" issues (casts, etc).  And another patch just for the build system changes.  The libedit changes also seem to be a good candidate for a standalone patch.

Sure!


Migration in Hive 2.0.4

Question
How is a migration performed properly?
Code sample
Let's say we have the following model:
@HiveType(typeId: 1)
class DailyChunk extends HiveObject {
  DailyChunk({
    required this.mood,
    required this.date,
  });

  @HiveField(0)
  double mood;

  @HiveField(1)
  DateTime date;
}

And would like to update it to the following:
@HiveType(typeId: 1)
class DailyChunk extends HiveObject {
  DailyChunk({
    required this.mood,
    required this.date,
    required this.energy,
  });

  @HiveField(0)
  double mood;

  @HiveField(1)
  DateTime date;

  @HiveField(2)
  double energy;
}

How would this be done properly without losing the data or getting null errors.
I read this documentation for Hive 0.1.0: Migration
However, I couldn't find anything similar for Hive 2
Updating that model leads to the following error:
Unhandled Exception: type 'Null' is not a subtype of type 'double' in type cast
E/flutter (14764): #0      DailyChunkAdapter.read (package:libitrack/model/entities/daily_chunk.g.dart:22:25)
E/flutter (14764): #1      BinaryReaderImpl.read (package:hive/src/binary/binary_reader_impl.dart:326:33)
E/flutter (14764): #2      BinaryReaderImpl.readFrame (package:hive/src/binary/binary_reader_impl.dart:274:26)
E/flutter (14764): #3      FrameHelper.framesFromBytes (package:hive/src/binary/frame_helper.dart:21:26)
E/flutter (14764): #4      FrameIoHelper.framesFromFile (package:hive/src/io/frame_io_helper.dart:42:12)
E/flutter (14764): <asynchronous suspension>
E/flutter (14764): #5      StorageBackendVm.initialize (package:hive/src/backend/vm/storage_backend_vm.dart:86:11)
E/flutter (14764): <asynchronous suspension>
E/flutter (14764): #6      HiveImpl._openBox (package:hive/src/hive_impl.dart:116:9)
E/flutter (14764): <asynchronous suspension>
E/flutter (14764): #7      HiveImpl.openBox (package:hive/src/hive_impl.dart:145:12)
E/flutter (14764): <asynchronous suspension>
E/flutter (14764): #8      _AddDataScreenState._readData (package:libitrack/ui/add_data_screen.dart:100:15)
E/flutter (14764): <asynchronous suspension>
E/flutter (14764):
E/flutter (14764): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: type 'Null' is not a subtype of type 'double' in type cast
E/flutter (14764): #0      DailyChunkAdapter.read (package:libitrack/model/entities/daily_chunk.g.dart:22:25)
E/flutter (14764): #1      BinaryReaderImpl.read (package:hive/src/binary/binary_reader_impl.dart:326:33)
E/flutter (14764): #2      BinaryReaderImpl.readFrame (package:hive/src/binary/binary_reader_impl.dart:274:26)
E/flutter (14764): #3      FrameHelper.framesFromBytes (package:hive/src/binary/frame_helper.dart:21:26)
E/flutter (14764): #4      FrameIoHelper.framesFromFile (package:hive/src/io/frame_io_helper.dart:42:12)
E/flutter (14764): <asynchronous suspension>
E/flutter (14764): #5      StorageBackendVm.initialize (package:hive/src/backend/vm/storage_backend_vm.dart:86:11)
E/flutter (14764): <asynchronous suspension>
E/flutter (14764): #6      HiveImpl._openBox (package:hive/src/hive_impl.dart:116:9)
E/flutter (14764): <asynchronous suspension>
E/flutter (14764): #7      HiveImpl.openBox (package:hive/src/hive_impl.dart:145:12)
E/flutter (14764): <asynchronous suspension>
E/flutter (14764): #8      _AddDataScreenState._readData (package:libitrack/ui/add_data_screen.dart:100:15)
E/flutter (14764): <asynchronous suspension>
E/flutter (14764):

Version

Platform: Mac
Flutter version: [e.g. 2.5.2]
Hive version: [e.g. 2.0.4]

Would also love some documentation on migration.
I decided that I no longer need one of the boxes and would like to delete it on update.

Bumping this.
I have the problem my data structure changed. Before a value that was just a String is now a new custom object with some Strings etc..
I have no idea how to migrate my boxes if the user still have data in the old format stored.


Default trackable-log type

When you write a new log for a trackable, its initial type is "Found it".

I also noticed that, but after some seconds of loading it is replaced by a log-type depending on the TB-situation (e.g. retrieve if its in a cache, note if it is your own)....didnt know this feature up to now.
However the initialisation is somehow not correct.


fix some typos and grammars in README

Hope you agree these edits improve readability :smile:

LGTM, thanks!


Add functionality to fill available space

Current functionality lack an ability to set styles for an element to fill all the remaining space.
It would be great to introduce some analogue of "flex-grow" property so element can fill all the free space. I understand that flex-grow functionality may be complicated, so I think the simple "fillAllRemainingSpace: true" would be great (assuming we have only such element in layout.

FlexBox like layout implementation is in plans for the future versions.
For now, similar behaviour can be achieved using percentages as a size values.
Like in this example: https://pixijs.io/layout/storybook/?path=/story/complex--application-layout
(check the 'Story tab')
Example:
new Layout({
  content: {
    el1: {
      type: 'row1',
      style: {
        display: 'block',
        width: '20%',
      }
    },
    el2: {
      type: 'row2',
      style: {
        display: 'block',
        width: '60%',
      }
    },
    el3: {
      type: 'row3',
      style: {
        display: 'block',
        width: '20%',
      }
    },
  }
)

@CyberDex Thank you for the quick response! I'm looking forward to see it implemented.


[ButtonBase] Improve test coverage

improve type coverage by type checking the ButtonBase unit test (investigating viability of #15984)
improve a11y coverage by moving to rtl
use strict mode compatible test API (remove enzyme's simulate)
enables a previously skipped test

All these points are coupled together (rtl is a bit more type friendly to the new testing approach, rtl enables new test etc).
Enables thinking about when to test for DOM properties vs HTML attributes so that was good practice.

How was your experience moving the tests from enzyme to testing-library?

Learned a bit about the DOM. Writing experience was pleasant since vscode works really well with typed libraries. Whenever I made a mistake refactoring the proper expect matchers helped identify the problem without me having to add another console.log. rtl also helps printing out the DOM tree when it can't find an element .e.g.
const button = getByRole('button'); will log
cannot find element with [role="button"] in
<div>
  <button type="button">Hello</button>
</div>

so you immediately know you should've used getByText1 and don't have to debug manually.
Some things are obviously hard like the centerRipple but we don't have a test for that anyway.
Tests are now more descriptive and it's easier with them to explain to someone how something should behave i.e. every time you do something that nobody will ever do in their codebase/browser you leave some question marks. It's obviously easier in some cases like focus compared to an Enter keyDown which has like 1 or 2 pages of spec text.
All we can do is try to improve instead of giving up immediately because it won't be perfect.

Forgot to add the 1: Going back and forth whether role="button" should match <button /> as well but a native button has different behavior than just role="button" so I guess the current behavior is ok. I wish browsers would apply behavior based on roles as well.

Forgot to add the 1: Going back and forth whether role="button" should match <button /> as well but a native button has different behavior than just role="button" so I guess the current behavior is ok. I wish browsers would apply behavior based on roles as well.

Turns out I was wrong about that. The documentation for getByRole was incomplete. expect(render(<button />).getByRole('button')).toBeInTheDocument() works perfectly fine since getByRole considers default roles.


where can i download the tranquility with version 9.0.0?

Hi. Same issue. 0.9.0. Doesn't seem to be available in maven

Should be fixed by #274 -- 0.8.2 is actually the latest version.


Adaptation to other OAuth2 services: Pull requests or forks?

I've managed to successfully fork this repo and adapt it to a new OAuth2 provider. I know others have done the same. However, given how little work it was, I'm wondering if you'd be open to generalizing the server to support multiple providers out-of-the-box, defaulting to Google but allowing for other providers.
I'm happy to take this on, and add tests as I go, as you can see from the latter link. (I'm about to file a PR for a bug I found in Options.Validate as part of this process.) That said, I understand if you'd rather keep this instance "pure" and let forks for other providers proliferate as they will.
Apologies if you've address this before; didn't see this come up in any earlier issue. Also, thanks for writing this; we've been using it successfully for months now on our Google-managed domain.

@mbland good questions. Let me dig into your current set of changes to understand what would be involved.
I'm not opposed to some generalization for other oauth provider endpoints and requested scopes, but i suspect it will become tricky as oauth providers don't have a consistent way to echo back identity after authentication which GAP needs.
I'm also keen to eventually support #28 which likely ties some functionality closer to Google's apis.

also cc: @balshor w/r/t 5f8bd41a7c089fdf047380acc9b02f2c19605721

OK, I'll keep hacking on 18F/oauth2_proxy to see if I can come up with some seams that make sense, and we can consider later whether they're worth pushing back up here. Feel free to subscribe to our repo, jump in on PRs, etc.

FYI, I've merged the latest changes from here into the generalize branch of our oauth2_proxy fork, and we're running this version now. Seems to work well.
If you're curious, I created a providers package to present a unified providers.Provider interface between the Google and MyUSA providers, and an api package to share the common api.Request() (formerly apiRequest()) between them.
I still need to add proper tests, but in the off chance you'd be interested in having any of this pushed upstream, let me know and I can prioritize that.

wow. Amazingly that refactoring came out very clean. Totally would accept as a PR.
And naming is hard, but renaming this project to a more generic "oauth2_proxy" is not a bad idea either.

Cool! I'll start sending PRs your way to build this up bit-by-bit.


NDRS-1010: Don't create a new era when we should shutdown for an upgrade. (backport to 0.9.2)

Backport of #1115.
https://casperlabs.atlassian.net/browse/NDRS-1010

bors r+

bors r+


Enable Link-Time Optimization (LTO)

Hi!
I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit. If you want to read a bit more about LTO, I can recommend starting from this Rustc documentation.
I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where in addition to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application with cargo install will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile.
Basically, it can be enabled with the following lines:
[profile.release]
lto = true

I have made quick tests (Fedora 41, Rustc 1.82) by adding lto = true to the Release profile. The binary size reduction is from 4.4 Mib to 2.9 Mib.
Thank you.

Hey! Checked the documentation, sounds good. You can make a PR for this if you want. Thank you!

Here we go: https://github.com/SafarSoFar/ghfetch/pull/2


[BUG] Cycling pods regularly results in fsck errors

Describe the bug
Stopping and starting pods in an application with 13 PVCs results in at least one showing up with
  Warning  FailedMount  64s (x39 over 76m)    kubelet  MountVolume.SetUp failed for volume "pvc-8ca2553a-0d63-42d4-93ce-4a1c47085dff" : rpc error: code = Internal desc = 'fsck' found errors on device /dev/longhorn/pvc-8ca2553a-0d63-42d4-93ce-4a1c47085dff but could not correct them: fsck from util-linux 2.31.1
ext2fs_check_if_mount: Can't check if filesystem is mounted due to missing mtab file while determining whether /dev/longhorn/pvc-8ca2553a-0d63-42d4-93ce-4a1c47085dff is mounted.
/dev/longhorn/pvc-8ca2553a-0d63-42d4-93ce-4a1c47085dff: One or more block group descriptor checksums are invalid.  FIXED.
/dev/longhorn/pvc-8ca2553a-0d63-42d4-93ce-4a1c47085dff: Group descriptor 64 checksum is 0x0000, should be 0x4a22.

/dev/longhorn/pvc-8ca2553a-0d63-42d4-93ce-4a1c47085dff: UNEXPECTED INCONSISTENCY; RUN fsck MANUALLY.
  (i.e., without -a or -p options)

To Reproduce
Steps to reproduce the behavior:

Run a 3-node cluster (1 control-plane, 2 workers) with Longhorn using all 3 nodes
Run a large application. Mine has 13 PVCs, writing log updates pretty much continuously (every couple seconds) and with 6 postgres instances.
Cycle podskubectl scale deploy --all --replicas 0
kubectl scale sts --all --replicas 0
sleep 10
kubectl scale sts --all --replicas 1
kubectl scale deploy --all --replicas 1

Usually at least 1 pod will be unable to mount a volume due to fsck errors.

Expected behavior
Pods should mount successfully.
Log
longhorn-support-bundle_ee48a964-d6ec-4141-af7a-84f62c5cea44_2021-03-11T23-34-35Z.zip
Environment:

Longhorn version: 1.1.0
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: https://kurl.sh with experimental Longhorn support

Number of management node in the cluster: 1
Number of worker node in the cluster: 2

Node config

OS type and version: CentOS 7.9.2009
CPU per node: 4
Memory per node: 8 GB
Disk type(e.g. SSD/NVMe): Tintri storage array, not sure on actual hardware. Latency is definitely in ms rather than us.
Network bandwidth between the nodes: Maybe 1Gbps?

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): Platform9 managed Openstack
Number of Longhorn volumes in the cluster: 24 (running a few other applications in other namespaces with less intense data profiles)

Additional context
I've been able to recover this in one case by deleting the currently attached replica ("connect-b" in that case) and letting others recover. Some details I noted while comparing replicas across nodes

revision.counter was the same across all replicas
the "connect" replica was at volume-head-005.img, where as others were at volume-head-004.img. However the content of volume-head-*.img across all 3 replicas matched.
the "connect-b" replica, despite having volume-head-004.img, referenced volume-head-005.img in volume-head-004.img.meta. This seemed like a warning sign that maybe a process failed midway through. The other volume-head-*.img.meta differed, but only because "connect" was on 5 while "connect-a" was on 4.
"connect" and "connect-a" had matching snapshots (.img and .img.meta). "connect-b" had the same metadata and .img name, but the .img contents differed from the other two.

I have a current incident I plan to dig into and see if it shares any similarities with the prior failure; I'll update once I dig into it. Disk latency may be a factor; I can check with the service provider on whether there are any health warnings on the disk array, but I would expect that to be monitored.

The new incident, trying to mount to "connect-a" (sha1sums)
# connect
$ cd /var/lib/longhorn/replicas/pvc-8ca2553a-0d63-42d4-93ce-4a1c47085dff-e35ae057; sha1sum *
23604d3a8bef8b913791eb1fb8a6b62b6fc734a1  revision.counter
0834657d77542f5b45e8e2c2752b62c60df81328  volume-head-004.img
cd81192671f484e51928caab4b6958c0d38b9f3d  volume-head-004.img.meta
6470514de79c005017c7c9ce5b1c720b24607983  volume.meta
796fb19b129f5cca658dced1e633df221303686d  volume-snap-b405c3ea-40e1-462e-8492-0d2a8a36f55e.img
2ce2cbf505fd3c5b556a3df96e90c76e39511a12  volume-snap-b405c3ea-40e1-462e-8492-0d2a8a36f55e.img.meta
$ cat volume-head-004.img.meta
{"Name":"volume-head-003.img","Parent":"volume-snap-b405c3ea-40e1-462e-8492-0d2a8a36f55e.img","Removed":false,"UserCreated":false,"Created":"2021-03-12T17:40:52Z","Labels":null}
$ cat volume.meta
{"Size":9663676416,"Head":"volume-head-004.img","Dirty":true,"Rebuilding":false,"Error":"","Parent":"volume-snap-b405c3ea-40e1-462e-8492-0d2a8a36f55e.img","SectorSize":512,"BackingFileName":""}

# connect-a
$ cd /var/lib/longhorn/replicas/pvc-8ca2553a-0d63-42d4-93ce-4a1c47085dff-8362dd08; sha1sum *
23604d3a8bef8b913791eb1fb8a6b62b6fc734a1  revision.counter
0834657d77542f5b45e8e2c2752b62c60df81328  volume-head-004.img
9eb3ba14a6bcc85fec50aa452e170f757aaf0eea  volume-head-004.img.meta
6470514de79c005017c7c9ce5b1c720b24607983  volume.meta
81a9d3cd9086b21d882696e904740a6c28b6b86f  volume-snap-b405c3ea-40e1-462e-8492-0d2a8a36f55e.img
2ce2cbf505fd3c5b556a3df96e90c76e39511a12  volume-snap-b405c3ea-40e1-462e-8492-0d2a8a36f55e.img.meta
$ cat volume-head-004.img.meta
{"Name":"volume-head-004.img","Parent":"volume-snap-b405c3ea-40e1-462e-8492-0d2a8a36f55e.img","Removed":false,"UserCreated":false,"Created":"2021-03-12T17:40:52Z","Labels":null}
$ cat volume.meta
{"Size":9663676416,"Head":"volume-head-004.img","Dirty":true,"Rebuilding":false,"Error":"","Parent":"volume-snap-b405c3ea-40e1-462e-8492-0d2a8a36f55e.img","SectorSize":512,"BackingFileName":""}

# connect-b
$ cd /var/lib/longhorn/replicas/pvc-8ca2553a-0d63-42d4-93ce-4a1c47085dff-bfed78a5; sha1sum *
23604d3a8bef8b913791eb1fb8a6b62b6fc734a1  revision.counter
0834657d77542f5b45e8e2c2752b62c60df81328  volume-head-003.img
cd81192671f484e51928caab4b6958c0d38b9f3d  volume-head-003.img.meta
a8401475cd7dbce614897c86f9f75b4422e07571  volume.meta
81a9d3cd9086b21d882696e904740a6c28b6b86f  volume-snap-b405c3ea-40e1-462e-8492-0d2a8a36f55e.img
2ce2cbf505fd3c5b556a3df96e90c76e39511a12  volume-snap-b405c3ea-40e1-462e-8492-0d2a8a36f55e.img.meta
$ cat volume-head-003.img.meta
{"Name":"volume-head-003.img","Parent":"volume-snap-b405c3ea-40e1-462e-8492-0d2a8a36f55e.img","Removed":false,"UserCreated":false,"Created":"2021-03-12T17:40:52Z","Labels":null}
$ cat volume.meta
{"Size":9663676416,"Head":"volume-head-003.img","Dirty":true,"Rebuilding":false,"Error":"","Parent":"volume-snap-b405c3ea-40e1-462e-8492-0d2a8a36f55e.img","SectorSize":512,"BackingFileName":""}

"connect-a" seems to be the faulty replica, but I'm also suspicious of the replica on "connect" due to the volume-head number mismatch.

@MikaelSmith thanks for the update, can you attach a new support bundle.
And post the context information, time of incident, which volumes, relevant nodes, etc.

longhorn-support-bundle_ee48a964-d6ec-4141-af7a-84f62c5cea44_2021-03-12T21-35-45Z.zip
Failure was March 12 (today) sometime between 17:39-18:00 UTC, on "connect-a", pvc-8ca2553a-0d63-42d4-93ce-4a1c47085dff. Not a production system.
Happened when rolling out new images to 4 different pods, including the affected pod.

Is the fsck error volume all happens on the same node? If yes, could you please check the HW with S.M.A.R.T. tool?
could you please check each replica content is fine or not? https://longhorn.io/docs/1.1.0/advanced-resources/data-recovery/export-from-replica/ (we'd like to find out the health replica)

The "hardware" is block storage from a Tintri storage array, which is not reporting errors.
I don't have these setup anymore. The last failure I ran through, I checked and all replicas had fsck errors.
Also, running through "export-from-replica" is challenging when using containerd rather than Docker.

Also, running through "export-from-replica" is challenging when using containerd rather than Docker.

The documentation should be updated to provided commands if the Kubernetes cluster using containerd.

To clarify, I didn't figure out how to run a container with a mounted volume with containerd. I instead tried deleting and recreating each replica, and was not able to get a working one. It's possible that ended up polluting all of the replicas somehow.

Sorry for the late reply.

Could you please check which replica is the healthy one? You could consider installing docker on the host and follows https://longhorn.io/docs/1.1.0/advanced-resources/data-recovery/export-from-replica/ to mount the block device to access the data to check which replica is the healthy one.
Try to fix the block device by run fsck check and repair unhealthy replicas.
Removes the unhealthy replicas, Longhorn will rebuild replicas from the existing healthy ones.

You could also reference this https://longhorn.io/docs/1.1.0/advanced-resources/data-recovery/data-error/

This cluster no longer exists. I may be able to set up another to test sometime in the next week or two.
Given how frequently this occurred, my concern was more that it was a recurring issue, not recovering from that specific failure.

Is this issue still exist on a new cluster?
Have you upgraded the Longhorn to v1.1.1?

I'll give 1.1.1 a try in the next few weeks.

So far 1.1.1 does seem more stable overall. I'm now testing with GCP instances using their balanced disks, and haven't run into any issues.

Good to know, thank's for your effort @MikaelSmith :smile:


Building cpputest 3.8 under Windows with mingw-w64 and CMake

Hello all! I'm trying to compile cpputest with mingw-w64 under Windows 10 but can't make it work.
I tried following Compiling Google test with Mingw-w64 and Compiling and using CppUTest 3.8 under MSYS2/MinGW32 by calling CMake with:
cmake ^
    -G "MinGW Makefiles" ^
    -D CMAKE_C_COMPILER=gcc.exe ^
    -D CMAKE_CXX_COMPILER=g++.exe ^
    -D CMAKE_MAKE_PROGRAM=mingw32-make.exe ^
	-D C++11=ON ^
    .

C:/git/tdd/cpputest/include/CppUTest/SimpleString.h:42:1:
+#include <cstddef>

C:/git/tdd/cpputest/include/CppUTest/SimpleString.h:183:31:
 SimpleString StringFrom(const nullptr_t value);
                               ^~~~~~~~~
mingw32-make.exe[2]: *** [src\CppUTest\CMakeFiles\CppUTest.dir\build.make:63: src/CppUTest/CMakeFiles/CppUTest.dir/CommandLineArguments.cpp.obj] Error 1
mingw32-make.exe[1]: *** [CMakeFiles\Makefile2:886: src/CppUTest/CMakeFiles/CppUTest.dir/all] Error 2
mingw32-make.exe: *** [Makefile:140: all] Error 2

Thanks!

Did you compile from trunk? We merged a pull request related to this yesterday.

Bas,
Thanks for your reply. I pulled right now and I'm on master. I'm trying to
compile on a clean tree with:
cmake ^
-G "MinGW Makefiles" ^
-D CMAKE_C_COMPILER=gcc.exe ^
-D CMAKE_CXX_COMPILER=g++.exe ^
-D CMAKE_MAKE_PROGRAM=mingw32-make.exe ^
-D C++11=ON ^
.
(...)

CppUTest Version 3.8
Current compiler options:
CC:
C:/mingw-w64/i686-8.1.0-posix-dwarf-rt_v6-rev0/mingw32/bin/gcc.exe
CXX:
C:/mingw-w64/i686-8.1.0-posix-dwarf-rt_v6-rev0/mingw32/bin/g++.exe
CppUTest CFLAGS:                     -include
"C:/git/tdd/cpputest/include/CppUTest/MemoryLeakDetectorMallocMacros.h"
-Wall -Wextra -pedantic -Wshadow -Wswitch-default -Wswitch-enum
-Wconversion -Wsign-conversion -Wno-padded -Wno-long-long
-Wstrict-prototypes
CppUTest CXXFLAGS:                   -include
"C:/git/tdd/cpputest/include/CppUTest/MemoryLeakDetectorNewMacros.h"
-include
"C:/git/tdd/cpputest/include/CppUTest/MemoryLeakDetectorMallocMacros.h"
-Wall -Wextra -pedantic -Wshadow -Wswitch-default -Wswitch-enum
-Wconversion -Wsign-conversion -Wno-padded -Wno-long-long
-Woverloaded-virtual -Wno-old-style-cast -Wno-c++14-compat
CppUTest LDFLAGS:
Features configured in CppUTest:
Memory Leak Detection:              ON
Compiling Extensions:               ON
Support Long Long:                  OFF
Use CppUTest flags:                 ON
Using Standard C library:           ON
Using Standard C++ library:         ON
Using C++11 library:                ON

Generating map file:                OFF
Compiling with coverage:            OFF

Compile and run self-tests          ON
Run self-tests separately           OFF

-- Configuring done
-- Generating done
-- Build files have been written to: C:/git/tdd/cpputest
I'm still getting an error:
mingw32-make.exe  V=1
Scanning dependencies of target CppUTest
[  1%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/CommandLineArguments.cpp.obj
[  2%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/MemoryLeakWarningPlugin.cpp.obj
[  3%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/TestHarness_c.cpp.obj
[  4%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/TestRegistry.cpp.obj
[  5%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/CommandLineTestRunner.cpp.obj
C:\git\tdd\cpputest\src\CppUTest\CommandLineTestRunner.cpp: In member
function 'int CommandLineTestRunner::runAllTests()':
C:\git\tdd\cpputest\src\CppUTest\CommandLineTestRunner.cpp:138:24: warning:
conversion to 'long int' from 'unsigned int' may change the sign of the
result [-Wsign-conversion]
output_->print(seed);
^~~~
[  6%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/SimpleString.cpp.obj
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:565:31: error:
'nullptr_t' does not name a type
SimpleString StringFrom(const nullptr_t value)
^~~~~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:565:31: note: 'nullptr_t'
is defined in header ''; did you forget to '#include '?
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:32:1:
+#include
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:565:31:
SimpleString StringFrom(const nullptr_t value)
^~~~~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:565:14: error:
redefinition of 'SimpleString StringFrom(int)'
SimpleString StringFrom(const nullptr_t value)
^~~~~~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:479:14: note:
'SimpleString StringFrom(int)' previously defined here
SimpleString StringFrom(int value)
^~~~~~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp: In function
'SimpleString StringFrom(cpputest_longlong)':
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:576:29: warning: unknown
conversion type character 'l' in format [-Wformat=]
return StringFromFormat("%lld", value);
^~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:576:29: warning: too many
arguments for format [-Wformat-extra-args]
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp: In function
'SimpleString StringFrom(cpputest_ulonglong)':
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:581:29: warning: unknown
conversion type character 'l' in format [-Wformat=]
return StringFromFormat("%llu", value);
^~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:581:29: warning: too many
arguments for format [-Wformat-extra-args]
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp: In function
'SimpleString HexStringFrom(cpputest_longlong)':
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:586:29: warning: unknown
conversion type character 'l' in format [-Wformat=]
return StringFromFormat("%llx", value);
^~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:586:29: warning: too many
arguments for format [-Wformat-extra-args]
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp: In function
'SimpleString HexStringFrom(cpputest_ulonglong)':
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:591:29: warning: unknown
conversion type character 'l' in format [-Wformat=]
return StringFromFormat("%llx", value);
^~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:591:29: warning: too many
arguments for format [-Wformat-extra-args]
mingw32-make.exe[2]: ***
[src\CppUTest\CMakeFiles\CppUTest.dir\build.make:133:
src/CppUTest/CMakeFiles/CppUTest.dir/SimpleString.cpp.obj] Error 1
mingw32-make.exe[1]: *** [CMakeFiles\Makefile2:886:
src/CppUTest/CMakeFiles/CppUTest.dir/all] Error 2
mingw32-make.exe: *** [Makefile:140: all] Error 2
Thanks again!
Regards,
Leonardo
On Mon, Dec 2, 2019 at 9:34 PM Bas Vodde<EMAIL_ADDRESS>wrote:

Did you compile from trunk? We merged a pull request related to this
yesterday.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cpputest/cpputest/issues/1263?email_source=notifications&email_token=ACKOP3G64NI2WU2SKS2SFZ3QWXAUBA5CNFSM4JTX672KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFX35QQ#issuecomment-560971458,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACKOP3G3DRBTUPCVNUW67RLQWXAUBANCNFSM4JTX672A
.

--
"Watchdogs are for wimps. Real designers use supernovas in a distant galaxy
to reset their boards."
itzly

Weird warnings.
I made a change related to nullptr though. Could you try to pull the latest trunk again? It ought to be fixed....

Bas,
Tried to clone from scratch and it still fails.
Has anyone been able to compile cpputest in Windows with MinGW-w64? That's
all I need.
mingw32-make.exe
[  1%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/CommandLineArguments.cpp.obj
[  2%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/MemoryLeakWarningPlugin.cpp.obj
[  3%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/TestHarness_c.cpp.obj
[  4%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/TestRegistry.cpp.obj
[  5%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/CommandLineTestRunner.cpp.obj
C:\git\tdd\cpputest\src\CppUTest\CommandLineTestRunner.cpp: In member
function 'int CommandLineTestRunner::runAllTests()':
C:\git\tdd\cpputest\src\CppUTest\CommandLineTestRunner.cpp:138:24: warning:
conversion to 'long int' from 'unsigned int' may change the sign of the
result [-Wsign-conversion]
output_->print(seed);
^~~~
[  6%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/SimpleString.cpp.obj
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:565:31: error:
'nullptr_t' does not name a type
SimpleString StringFrom(const nullptr_t value)
^~~~~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:565:31: note: 'nullptr_t'
is defined in header ''; did you forget to '#include '?
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:32:1:
+#include
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:565:31:
SimpleString StringFrom(const nullptr_t value)
^~~~~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:565:14: error:
redefinition of 'SimpleString StringFrom(int)'
SimpleString StringFrom(const nullptr_t value)
^~~~~~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:479:14: note:
'SimpleString StringFrom(int)' previously defined here
SimpleString StringFrom(int value)
^~~~~~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp: In function
'SimpleString StringFrom(cpputest_longlong)':
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:576:29: warning: unknown
conversion type character 'l' in format [-Wformat=]
return StringFromFormat("%lld", value);
^~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:576:29: warning: too many
arguments for format [-Wformat-extra-args]
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp: In function
'SimpleString StringFrom(cpputest_ulonglong)':
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:581:29: warning: unknown
conversion type character 'l' in format [-Wformat=]
return StringFromFormat("%llu", value);
^~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:581:29: warning: too many
arguments for format [-Wformat-extra-args]
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp: In function
'SimpleString HexStringFrom(cpputest_longlong)':
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:586:29: warning: unknown
conversion type character 'l' in format [-Wformat=]
return StringFromFormat("%llx", value);
^~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:586:29: warning: too many
arguments for format [-Wformat-extra-args]
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp: In function
'SimpleString HexStringFrom(cpputest_ulonglong)':
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:591:29: warning: unknown
conversion type character 'l' in format [-Wformat=]
return StringFromFormat("%llx", value);
^~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:591:29: warning: too many
arguments for format [-Wformat-extra-args]
mingw32-make.exe[2]: ***
[src\CppUTest\CMakeFiles\CppUTest.dir\build.make:133:
src/CppUTest/CMakeFiles/CppUTest.dir/SimpleString.cpp.obj] Error 1
mingw32-make.exe[1]: *** [CMakeFiles\Makefile2:886:
src/CppUTest/CMakeFiles/CppUTest.dir/all] Error 2
mingw32-make.exe: *** [Makefile:140: all] Error 2
I was thinking that the -std=c++11 flag was somehow missing. I tried
hacking FindCXX11.cmake to force that flag:
git diff
diff --git a/cmake/Modules/FindCXX11.cmake b/cmake/Modules/FindCXX11.cmake
index 8718ec10..540e0557 100644
--- a/cmake/Modules/FindCXX11.cmake
+++ b/cmake/Modules/FindCXX11.cmake
@@ -50,5 +50,9 @@ endforeach(FLAG ${CXX11_FLAG_CANDIDATES})
set(CXX11_FLAGS "${CXX11_FLAGS_INTERNAL}")
+set(CXX11_FLAGS "${CXX11_FLAGS} -std=c++11")
+
+message(STATUS "CXX11_FLAGS = [${CXX11_FLAGS}]")
+
find_package_handle_standard_args(CXX11 DEFAULT_MSG CXX11_FLAGS)
mark_as_advanced(CXX11_FLAGS)
And indeed I got the flag:
CppUTest CXXFLAGS:                   -include
"C:/git/tdd/cpputest/include/CppUTest/MemoryLeakDetectorNewMacros.h"
-include
"C:/git/tdd/cpputest/include/CppUTest/MemoryLeakDetectorMallocMacros.h"
-std=c++11  -Wall -Wextra -pedantic -Wshadow -Wswitch-default -Wswitch-enum
-Wconversion -Wsign-conversion -Wno-padded -Wno-long-long
-Woverloaded-virtual -Wno-old-style-cast -Wno-c++14-compat
But it still fails.
Thanks for your help.
On Tue, Dec 3, 2019 at 10:32 PM Bas Vodde<EMAIL_ADDRESS>wrote:

Weird warnings.
I made a change related to nullptr though. Could you try to pull the
latest trunk again? It ought to be fixed....
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cpputest/cpputest/issues/1263?email_source=notifications&email_token=ACKOP3H5TG35EMZBDPSAUVTQW4QEPA5CNFSM4JTX672KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3TORQ#issuecomment-561461062,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACKOP3EKANCHRYRGYQR32NDQW4QEPANCNFSM4JTX672A
.

--
"Watchdogs are for wimps. Real designers use supernovas in a distant galaxy
to reset their boards."
itzly

I got it to compile by hacking SimpleString.cpp:
diff --git a/src/CppUTest/SimpleString.cpp b/src/CppUTest/SimpleString.cpp
index b8c924b7..5b81341b 100644
--- a/src/CppUTest/SimpleString.cpp
+++ b/src/CppUTest/SimpleString.cpp
@@ -561,7 +561,7 @@ SimpleString BracketsFormattedHexString(SimpleString
hexString)

ARM compiler has only partial support for C++11.

Regards,
On Wed, Dec 4, 2019 at 12:00 PM Leonardo Pereira Santos <
<EMAIL_ADDRESS>wrote:

Bas,
Tried to clone from scratch and it still fails.
Has anyone been able to compile cpputest in Windows with MinGW-w64? That's
all I need.
mingw32-make.exe
[  1%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/CommandLineArguments.cpp.obj
[  2%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/MemoryLeakWarningPlugin.cpp.obj
[  3%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/TestHarness_c.cpp.obj
[  4%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/TestRegistry.cpp.obj
[  5%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/CommandLineTestRunner.cpp.obj
C:\git\tdd\cpputest\src\CppUTest\CommandLineTestRunner.cpp: In member
function 'int CommandLineTestRunner::runAllTests()':
C:\git\tdd\cpputest\src\CppUTest\CommandLineTestRunner.cpp:138:24:
warning: conversion to 'long int' from 'unsigned int' may change the sign
of the result [-Wsign-conversion]
output_->print(seed);
^~~~
[  6%] Building CXX object
src/CppUTest/CMakeFiles/CppUTest.dir/SimpleString.cpp.obj
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:565:31: error:
'nullptr_t' does not name a type
SimpleString StringFrom(const nullptr_t value)
^~~~~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:565:31: note:
'nullptr_t' is defined in header ''; did you forget to '#include
'?
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:32:1:
+#include
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:565:31:
SimpleString StringFrom(const nullptr_t value)
^~~~~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:565:14: error:
redefinition of 'SimpleString StringFrom(int)'
SimpleString StringFrom(const nullptr_t value)
^~~~~~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:479:14: note:
'SimpleString StringFrom(int)' previously defined here
SimpleString StringFrom(int value)
^~~~~~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp: In function
'SimpleString StringFrom(cpputest_longlong)':
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:576:29: warning: unknown
conversion type character 'l' in format [-Wformat=]
return StringFromFormat("%lld", value);
^~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:576:29: warning: too
many arguments for format [-Wformat-extra-args]
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp: In function
'SimpleString StringFrom(cpputest_ulonglong)':
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:581:29: warning: unknown
conversion type character 'l' in format [-Wformat=]
return StringFromFormat("%llu", value);
^~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:581:29: warning: too
many arguments for format [-Wformat-extra-args]
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp: In function
'SimpleString HexStringFrom(cpputest_longlong)':
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:586:29: warning: unknown
conversion type character 'l' in format [-Wformat=]
return StringFromFormat("%llx", value);
^~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:586:29: warning: too
many arguments for format [-Wformat-extra-args]
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp: In function
'SimpleString HexStringFrom(cpputest_ulonglong)':
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:591:29: warning: unknown
conversion type character 'l' in format [-Wformat=]
return StringFromFormat("%llx", value);
^~~~~~
C:\git\tdd\cpputest\src\CppUTest\SimpleString.cpp:591:29: warning: too
many arguments for format [-Wformat-extra-args]
mingw32-make.exe[2]: ***
[src\CppUTest\CMakeFiles\CppUTest.dir\build.make:133:
src/CppUTest/CMakeFiles/CppUTest.dir/SimpleString.cpp.obj] Error 1
mingw32-make.exe[1]: *** [CMakeFiles\Makefile2:886:
src/CppUTest/CMakeFiles/CppUTest.dir/all] Error 2
mingw32-make.exe: *** [Makefile:140: all] Error 2
I was thinking that the -std=c++11 flag was somehow missing. I tried
hacking FindCXX11.cmake to force that flag:
git diff
diff --git a/cmake/Modules/FindCXX11.cmake b/cmake/Modules/FindCXX11.cmake
index 8718ec10..540e0557 100644
--- a/cmake/Modules/FindCXX11.cmake
+++ b/cmake/Modules/FindCXX11.cmake
@@ -50,5 +50,9 @@ endforeach(FLAG ${CXX11_FLAG_CANDIDATES})
set(CXX11_FLAGS "${CXX11_FLAGS_INTERNAL}")
+set(CXX11_FLAGS "${CXX11_FLAGS} -std=c++11")
+
+message(STATUS "CXX11_FLAGS = [${CXX11_FLAGS}]")
+
find_package_handle_standard_args(CXX11 DEFAULT_MSG CXX11_FLAGS)
mark_as_advanced(CXX11_FLAGS)
And indeed I got the flag:
CppUTest CXXFLAGS:                   -include
"C:/git/tdd/cpputest/include/CppUTest/MemoryLeakDetectorNewMacros.h"
-include
"C:/git/tdd/cpputest/include/CppUTest/MemoryLeakDetectorMallocMacros.h"
-std=c++11  -Wall -Wextra -pedantic -Wshadow -Wswitch-default -Wswitch-enum
-Wconversion -Wsign-conversion -Wno-padded -Wno-long-long
-Woverloaded-virtual -Wno-old-style-cast -Wno-c++14-compat
But it still fails.
Thanks for your help.
On Tue, Dec 3, 2019 at 10:32 PM Bas Vodde<EMAIL_ADDRESS>wrote:

Weird warnings.
I made a change related to nullptr though. Could you try to pull the
latest trunk again? It ought to be fixed....
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cpputest/cpputest/issues/1263?email_source=notifications&email_token=ACKOP3H5TG35EMZBDPSAUVTQW4QEPA5CNFSM4JTX672KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3TORQ#issuecomment-561461062,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACKOP3EKANCHRYRGYQR32NDQW4QEPANCNFSM4JTX672A
.

--
"Watchdogs are for wimps. Real designers use supernovas in a distant
galaxy to reset their boards."
itzly

--
"Watchdogs are for wimps. Real designers use supernovas in a distant galaxy
to reset their boards."
itzly

I fixed it by:
diff --git a/src/CppUTest/SimpleString.cpp b/src/CppUTest/SimpleString.cpp
index b8c924b7..430041af 100644
--- a/src/CppUTest/SimpleString.cpp
+++ b/src/CppUTest/SimpleString.cpp
@@ -562,7 +562,7 @@ SimpleString BracketsFormattedHexString(SimpleString hexString)
  * Specifically nullptr_t is not officially supported
  */
 #if __cplusplus > 199711L && !defined __arm__
-SimpleString StringFrom(const nullptr_t value)
+SimpleString StringFrom(const std::nullptr_t value)
 {
     (void) value;
     return "(null)";

I just created a pull request fixing this.

Ok, I thought that change was already made. I'm surprised.

I assume this is fixed by now, so closing this issue.


Fix panic from segfaults caused by continuing from a failed condition

This replaces the if err != nil { assert.Fail() } calls with require.NoError. Aside from being slightly more readable, the switch to using require as opposed to assert allows the test to exit when it shouldn't continue. By doing so, we can avoid panics halting the test and leaving resources lying around like in this failure.

Yup! Jim pointed it out to me on one of the PRs and have since been using it religiously :)

Merging!


Can we select-highlight a text in pdf

is this pdf viewer returning an image? Briefly i want to select-highlight a text from opened pdf and do some work with this text. Can we do this? or can we add this property?

@barbarossusuz did you found option to highlight text?


Add safeSpend function with additional balance check

Not too happy with this, going to think through an approve+transferFrom approach.
New proposal: #79

Chosen solution is to use documentation to let developers know to be careful.


The docs refer to href when it should be src

<script type="text/javascript" href="assets/js/accessible-autocomplete.min.js"></script>
should be src= I think

Thanks!


When we can expect this library for android 11+?

Hello @amitimg29 ,
Starting Android 11, access to shared storage has been restricted and it is no longer possible to implement such a broad file selector without the use of Storage Access Framework(SAF) or by declaring the All files access permission (link).
The most practical solution available right now is to check the android version at runtime and implement the file picker accordingly. The app will then use the library for API < 10  and for API>=10 it will use the system file picker.
The  android 11 update for this library is still in works.


Add group object to unauthenticated output.

This fixes a bug in the CZO code. Somehow the group object wasn't being passed to the template when the user was unauthenticated. This means things couldn't be fetched from the user profile.

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

Browse to group with an image in unauthenticated mode. Image should appear. Browse in authenticated mode. Image should be the same.

@cuahsimarko The group object wasn't being passed to the template in unauthenticated mode, in init.py. Also, the filter for public resources wasn't correct.


[Feature] Add a withScrolledInView decorator

This decorator can be used to easily setup animation based on scroll position of an element by adding a new scrolledInView({ progress }) hook to any component, with progress being a value between 0 and 1 corresponding to the position of the root element in the viewport:

0 when the root element enters the viewport from the bottom
0.5 when it is centered vertically in the viewport
1 when it exits the viewport from the top

import { Base, withScrolledInView } from '@studiometa/js-toolkit';

class Component extends withScrolledInView(Base) {
  static config = {
    name: 'Component',
  };

  scrolledInView({ progress }) {
    this.$el.style.opacity = progress;
  }
}

See the updated documentation and the Parallax component in the demo to learn how to use it.

Changelog
Added

Add a withScrolledInView decorator (#156)

[ ] Add x axis values for horizontal scroll


Nginx not running on Ubuntu 16

Hi Nick,
Really loving this setup but having an issue running it on a ubuntu 16 machine. Essentially it seems like nginx server does not startup after bringing up the containers. I dont have a lot of experience using docker as a whole so not sure if I am missing something here. I have used this same setup on a mac using dinghy and works with no issues.
Are there any issue running this with Ubuntu you are aware off?
Cheers mate,
doug

Hey @dougogisi! This is an interesting one since we haven't ran our setup on Ubuntu. I think the issue could be one of two things

The environment variable UPDATE_UID_GID in global.env is set to true. If that's the case, change it to false, then run docker-compose up -d to refresh the environment. This variable being set to true does some tasks that are specific to running docker on mac to fight around some tricky permission issues.

Nginx is running, but just not available on the port you're expecting. If you run docker ps, you'll be able to see which port each container that exposes ports is bound to. For example: tcp, <IP_ADDRESS>:32776->80/tcp. This means port 80 is exposed and available on port 32776 on your host (your machine). If that isn't the issue though, can post the result of docker ps and any logs from docker-compose logs would be useful to help investigate further :)

Cheers!

Hey Ash,
Legendary stuff. Got it working. Steps

Turned off UPDATE_UID_GID
User docker ps to locate the container ids
User docker inspect {container id} to get the correct ips and added them to /etc/hosts for each container (helpful if you use mysql workbench)
Voila

Worth noting that i had a weird issue where the some db tables where missing. I removed the containers, images and just rebuilt them. I have been able to do this with and without varnish. happy days
Thanks a ton.

This was very helpful. Thanks!


Fix migration for unique slugs

the PINAX_BLOG_SLUG_UNIQUE setting when set to True, causes a migration to be generated after install.  the migrations that ship with pinax-blog were created with the default settings which is False.
perhaps the migration should be edited to be dynamic based on that setting.  that doesn't handle the case where you might want to switch after you have installed but could handle the case where you know what you want from the start.

@paltman do you think this needs to be done for 16.07?

@jtauber ideally but i'm not sure of how to fix it

@brosner any ideas?

Is this still relevant? Perhaps can be closed at this point.


Add install instructions like the old repo had

See the old repo's Read Me https://github.com/4site-interactive-studios/Engaging-Networks-SASS

Created a Wiki Entry for it: https://github.com/4site-interactive-studios/engrid/wiki/EN-Grid-Installation-Instructions
Now it needs to be updated for the latest workflow


Controller: PendingError isn't actually an error

I dug a bit more into why users of the issuer-lib wouldn't see the recovery of errors by looking at the logs with the default logging level. For example, the logs would show this:
{"level":"error","msg":"Retryable CertificateRequest error.","error":"certificate still in a pending state, the request will be retried: WebSDK CertRequest Module Requested Certificate"}
{"level":"error","msg":"Retryable CertificateRequest error.","error":"certificate still in a pending state, the request will be retried: WebSDK CertRequest Module Requested Certificate"}
{"level":"error","msg":"Retryable CertificateRequest error.","error":"certificate still in a pending state, the request will be retried: Prepares the Certificate Object for lifecycle processing"}
{"level":"error","msg":"Retryable CertificateRequest error.","error":"certificate still in a pending state, the request will be retried: Not yet available"}
{"level":"error","msg":"Retryable CertificateRequest error.","error":"certificate still in a pending state, the request will be retried: Post CSR"}
{"level":"error","msg":"Retryable CertificateRequest error.","error":"certificate still in a pending state, the request will be retried: Order Pending"}
{"level":"error","msg":"Retryable CertificateRequest error.","error":"certificate still in a pending state, the request will be retried: Order Pending"}
{"level":"error","msg":"Retryable CertificateRequest error.","error":"certificate still in a pending state, the request will be retried: Order Pending"}

After inspecting the CertificateRequest (CR), the user of an implementation of issuer-lib would realize that the CR has succeeded since then but the logs don't reflect that. They would have expected a positive message saying that the controller has recovered:
{"level":"info","msg":"Retryable CertificateRequest error.","error":"certificate still in a pending state, the request will be retried: Order Pending"}

Currently, users have to use the logr level 1 (referred as "debug" in the README) in order to see the success message, but the above "Retryable CertificateRequest error" message shows at logr level 0.
Note that the README is currently incorrect: it should say "Succeeded signing the CertificateRequest is logged at the level 1 (debug)":

I think the main reason for this mismatch is because we confused ourselves with PendingError. The type is error, it has "error" in its name, but it isn't an error after all. By mistake, we (the issuer-lib developers) ended up logging PendingError as an error i.e. at level 0 with log.V(1).Error (Error ignores V(1) entirely, that's why I say that we log it at level 0). These pending error messages get printed regardless of the logging level.
What we really wanted is to only show these messages in "debug" mode, similarly as to how we currently log the "Succeeded signing certificate" messages at logr level 1. That way, the logging experience is consistent: someone debugging the logs will be able to see, in debug mode, the progression of the signing of the certificate as well as when it succeeded.
I also propose to change the message associated with the PendingError case. It isn't a failure since PendingError isn't an error.

I think you are making a valid point.
I'll just try to write down some facts as reference:
There are two possible options: you fail permanently or you can retry reconciliation.

fail permanently:

this is always an error and this should be logged
can be caused by a returned PermanentError or by a "normal error" that has not been retried enough

retry reconciliation:

we can have a "normal error" which probably indicates an error that might be transient
we can have a PendingError which probably indicates something is not yet ready (because we will never timeout in case of a PendingError)

The relevant error types are PermanentError, PendingError and "normal error".

My concern is that we are conflating two things:

"The signing process is going well and is progressing" (PendingError),
"The signing process failed and will (or will not) be retried" (also PendingError, or PermanentError, or a normal error).

Currently, PendingError is used for both (1) and (2), and that's causing me a lot of confusion.
What I would recommend is to retire PendingError altogether. Since it isn't an semantically equivalent to an error, we shouldn't confuse it with one. I would use the following:
type Result struct {
Retry bool
SetCondition Condition
}
// The Sign func may return an error wrapped in TerminalError to signify that the
// signing process has stopped due to a problem that the implementor of Sign thinks
// can't be resolved by retrying. The Sign func doesn't return a Result when an
// error has been returned.
type Sign func(context.Context, CertificateRequestObject, v1alpha1.Issuer) (PEMBundle, Result, error)
On an other topic, I went looking at the documentation around Sign but the comment above the func signature doesn't tell what errors the implementors of Sign can use. One has to dig into the other files around (err_set_condition.go etc) to learn that they can return special errors.

This is a great improvement to issuer-lib!
/lgtm
/approve


Incorrect SLAs

The SLAs atated on this page are in conflict with what is stated here: https://azure.microsoft.com/en-gb/support/legal/sla/cosmos-db/v1_3/
Multi-region (single region writes) has 99,99% availatility for both reads and writes.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f171c675-7217-ad97-d35d-bd1d5058b2cb
Version Independent ID: 2b9b18ee-6242-4503-2c3d-9c883eb1fcf0
Content: High availability in Azure Cosmos DB
Content Source: articles/cosmos-db/high-availability.md
Service: cosmos-db
GitHub Login: @markjbrown
Microsoft Alias: mjbrown

No, it's the other page that's unclear at the top.


Added the change related to redirecting to the home page

Let this PR be in place I started refactoring I just want to push something, to keep it clean, dont merge this as of now


Weird error when testing eigencentrality on Analytical Platform

test_node_metrics.py::test_eigencentrality_star
gives an error when running on AP
pyarrow.lib.ArrowTypeError: Expected a string or bytes dtype, got int64
however test passes on github-actions dockerised environment 🤔 and hence it is merged.
Need to test in other envs as well (DAP /AWS GLUE/ OSX) to understad what is going on

OSX tested and test passes 🤔
Next stop: AWS Glue


Add the Cosmos SDK as a submodule

Close: #10

[x] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[ ] Updated all code comments where relevant
[ ] Wrote tests
[ ] Updated CHANGES.md

Archiving repo


Unmocked mutation errors now propagate to the test console

This is an alternative fix to https://github.com/Shopify/quilt/pull/731.  It fixes a more specific issue, and doesn't step outside of Apollo's link chain.
What?
Better feedback for unmocked test mutations.
Before

After
A little more output, but there's actionable feedback in here:

How tho?
Previously, Apollo would try to dig into result.errors, find nothing, and assume that it should proceed with unpacking mutation data.  This caused Apollo to throw exceptions when trying to dig into the undefined result.
Now, the expected mutation result shape is used, and Apollo correctly interprets our errors as... errors :)

@GoodForOneFare can you either update or close this?


libphy-update-d3f6d97

Working making some updates to fix the BLE_FreeRTOS examples.

Could we remove those log files?

The log files are intended to be left here. Since we can't distribute the source code, this at lease gives us a log of how the library was built.

Could we remove those log files?

The log files are intended to be left here. Since we can't distribute the source code, this at lease gives us a log of how the library was built.

@yc-adi What do you think?


ornamental question mark looks weird

Git, as opposed to all other VCSs, uses a question mark instead of a plus sign to indicate files which aren't checked in. Not sure why this is, but I'm sure there's an explanation (which could perhaps be added to the README.md).
Anyhow, for the question mark, powerline-shell does not use ? but \u2753, the 'BLACK QUESTION MARK ORNAMENT':

At first, I thought my font was broken. Why not use the actual question mark ? (or a + for that matter)?

Git, as opposed to all other VCSs

This is mostly not true as of the last version. I think the only holdout is the hg segment, but in the next release, it too will match the way git behaves.

Why not use the actual question mark

That I don't know. I added the functionality to git years ago and used + at the time. Somewhere along the line it was switched to what you see today. I don't really see any reason to use that over a regular question mark, so I think we should just switch to that.

So the conclusion here is that regular '?' will be used for untracked files in git? That would be perfect.

@shikhanshu yes.

@b-ryan does the latest release contain this fix?

Ah no it doesn't. I will do this now.

@b-ryan thanks!

Released! It's in version 0.4.2


slackUserIdFromEmail returns null

Your checklist for this issue

[x] Jenkins version
2.220
[x] Plugin version
2.40
[x] OS
Amazon Linux AMI 2018.03

Description
Hi,
We are using your plugin without the custom slack app and it's working fine for the slackSend() method.
I'm trying to implement a simple pipeline which also calls the slackUserIdFromEmail() method.
Reading your documentation I set up a custom slack app and the sendSlack() method is still working, now I'm receiving slack messages from the app.
But the slackUserIdFromEmail() method returns null, though I tried to play with the settings to see if I could make it work by (un)ticking boxes or anything else.
I also logged everything from the "jenkins.plugins.slack" package, only the slackSend() log appears.
Has anyone an idea of what I might be doing wrong ?
Here's my test pipeline :
pipeline {
   agent any

   stages {
      stage('Hello') {
         steps {
            echo 'Hello World'
            script {
                def userId = slackUserIdFromEmail('myEmail')
                echo userId
                slackSend(color: 'good', channel:'@myUserId', message: 'Message from Jenkins Pipeline')
            }
         }
      }
   }
}

Here's the console result :
Running on Jenkins in /var/lib/jenkins/workspace/testslack
[Pipeline] {
[Pipeline] stage
[Pipeline] { (Hello)
[Pipeline] echo
Hello World
[Pipeline] script
[Pipeline] {
[Pipeline] slackUserIdFromEmail
[Pipeline] echo
null
[Pipeline] slackSend
Slack Send Pipeline step running, values are - baseUrl: <empty>, teamDomain: <empty>, channel: @myUserId, color: good, botUser: true, tokenCredentialId: xxx, notifyCommitters: false, iconEmoji: <empty>, username: <empty>, timestamp: <empty>
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Finished: SUCCESS

Found the solution thanks to https://github.com/jenkinsci/slack-plugin/issues/683
You need to add users:read.email and users:read scopes added to your app.
This should be documented in the plugin.

Found the solution thanks to #683
You need to add users:read.email and users:read scopes added to your app.
This should be documented in the plugin.

could you submit a PR to update: https://github.com/jenkinsci/slack-plugin#creating-your-app

I updated the list in the issue, I'll see if can manage to add it in a meaningful way to the readme.


Add SQL Shades

Hi @ktaranov !  New add-in for your list.
Added SQL Shades, a true dark mode add-in.
Also updated VersionSQL's company name and price, which has changed, and fixed another add-in's anchor tag.

@MikeTV thanks! sorry for late response


[e2e] Add test for editing properties

Add a test that edits properties in a similar way than the following example:

Use the following text in the source code text box:

group: camel.apache.org
kind: KameletBinding
metadata:
  additionalProperties: {}
  finalizers: []
  managedFields: []
  name: Updated integration
  ownerReferences: []
plural: kameletbindings
scope: Namespaced
served: true
singular: kameletbinding
spec:
  source:
    ref:
      apiVersion: camel.apache.org/v1alpha1
      name: timer-source
      kind: Kamelet
  sink:
    ref:
      apiVersion: camel.apache.org/v1alpha1
      name: kafka-sink
      kind: Kamelet
storage: true
version: v1alpha1

Click on the first step timer-source
Check the detail window opens
Go to Config tab
Input 3000 on the Period property
Check the property gets added to the timer-source in the source code
Click on the last step kafka-sink
Check the detail window opens
Go to Config tab
Input password in the password property
Input topicname in the topic property
Check the properties get added to the kafka-sink in the source code
Change the value of the Period property in the source code
Click on the first step timer-source
Go to Config tab
The value in the input Period must be the same as the value from the source code

Tests are defined on: https://github.com/KaotoIO/kaoto-ui/tree/main/cypress
They can be run as described in the README: https://github.com/KaotoIO/kaoto-ui#end-to-end-e2e-tests
You need the backend running to be able to execute the test: https://kaoto.io/quickstart/

@miram13 this was already completed, wasn't it?

Ya, it is completed
On Tue, Aug 23, 2022 at 12:52 AM Rachel Yordán @.***>
wrote:

@miram13 https://github.com/miram13 this was already completed, wasn't
it?
—
Reply to this email directly, view it on GitHub
https://github.com/KaotoIO/kaoto-ui/issues/298#issuecomment-1222812474,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW2BEKQCHI5FVEDF5QWXFSLV2PHP3ANCNFSM5SZBFTJQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@miram13 this was already completed, wasn't it?

Ya, it is completed..I'll close the issue.


which is the format of this Input data set for training?

which is the format of this Input data set for training?Can you give the data preparation process?Give an example. Thanks!

The data format required for training is the same as the datasets shared here.
However, in some images, you may need to manual label because all faces are not labeled.
 You should also edit the names of these pictures. For example, image1232_1.jpg, image1232_2.jpg, and corresponding pts files, image1232_1.pts, image1232_2.pts
In addition to these, you may need to collect and label other faces in the wild datasets to more robust the model.
You can use a pre-trained MTCNN to simplify the labeling process.
PS: I do not intend to share the dataset I created using these and similar methods.

Hello
How are you?
Could u explain the dataset's structure in README?
Thanks


Fix our Travis CI build

Travis is pretty dead. Recommend moving to GitHub Actions.

@reedloden : Yes, thanks for the heads up. I'm actually considering either Buildkite or GitHub Actions but I'm not yet sure and will have to ask upstream first as I don't have access to the repository settings anyway.


Added regexp escape for object media.

[x] Pull request has tests / docs demo, and is linted.
[ x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (https://help.github.com/articles/closing-issues-via-commit-messages/).

Coverage remained the same at 89.971% when pulling 9bed8c60759545d7ec8acf25d013ac38f9179916 on alansouzati:fix/escape-object-media into 6bfeae60b77a6fba07b6208c2d4ad8284ede887f on mbasso:master.

Thank you 😄
I'll publish a release soon

Just published<EMAIL_ADDRESS>thank you 🎉


fix: upgrade to version 3.2.57

from: https://github.com/jenkins-x/jx

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm-kapp
88665ce1b1ef6fd5c04ba49fa0ab1b8afa968431
link
/test gsm-kapp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


mssql 2019 - linux - cleanup time

In 2019 cleanup time works under linux.
So you could add the feature for this version also under linux
BR,

Thank you. I have added support for cleanup on Linux.
https://ola.hallengren.com/versions.html


Rebuild style structure to support modular structures like Gutenberg blocks

I'd like to move the base styles like headings, fonts, buttons and form fields to mixins. That way it would be a lot easier to keep the styles consistent in different kind of modules and blocks and rewrite Gutenberg block styles to match theme styles.
Example:
body .wp-block-file {
  .wp-block-file__button {
    @include button;
  }
}

I do this already in all of my builds, although it is a departure from the current Air standard. Is this something you're interested in adopting @ronilaukkarinen ? I could send a PR next week with my tweaks, which largely move most hard coded values into variables and mixins in your help files.

@michaelbourne Would be glad to check it out! Please send a PR and we'll see, might as well be close to our future approach.

This has been done in PR #62 and further so closing.


SCP-4986 Integration test scenarios for Intersections

Nice framework!
I'm concerned that minor, occasional lack of synchronization on the backend will cause intermittent failures. Should we add "knobs" like for a delay after a confirmation, etc.

Not preemptively - I'd want to wait for there to be an actual failure to diagnose first

Also, I suggest we fix the CI failures on main before merging this.

I just pushed a couple of commits to one of your branches that should address this.

Nice framework!
I'm concerned that minor, occasional lack of synchronization on the backend will cause intermittent failures. Should we add "knobs" like for a delay after a confirmation, etc.

Not preemptively - I'd want to wait for there to be an actual failure to diagnose first

Well here's an example of a concrete failure related to this :) https://github.com/input-output-hk/marlowe-cardano/actions/runs/4118311156/jobs/7110668432
What I believe is happening here is that we are submitting the transaction, it is getting added to the chain, and marlowe-tx is returning the block header. Then before we call Poll / RequestNext in the sync protocol and get the new tx and block header, it has been rolled back and reapplied at a later slot no, so the expectedBlock does not match the actualBlock.
I see two options here:

Remove the assertions for the block headers, since we cannot be certain they will actually match, though this is not a bug.
We add a parameter (or "knob" if you wish) to marlowe-tx which requires it to wait X blocks after it receives the confirmation for the submitted transaction before it returns the block header, and we turn up the value a bit in the tests.


json-graphql-server: command not found

What you were expecting:
npm is unable to find the json-graphql-server command
What happened instead:
npx json-graphql-server db.cjs
sh: json-graphql-server: command not found

ls -lh ./node_modules/.bin
lrwxr-xr-x  1 pdehaan  staff    18B 20 Jul 23:22 acorn -> ../acorn/bin/acorn
lrwxr-xr-x  1 pdehaan  staff    22B 20 Jul 23:22 loose-envify -> ../loose-envify/cli.js
lrwxr-xr-x  1 pdehaan  staff    14B 20 Jul 23:22 mime -> ../mime/cli.js
lrwxr-xr-x  1 pdehaan  staff    20B 20 Jul 23:22 semver -> ../semver/bin/semver

Steps to reproduce:
Installed json-graphql-server locally via npm i json-graphql-server -D and populated my db.cjs flie and then tried to run with npx json-graphql-server db.cjs and got the errors above.
Looks like the filename is ./bin/json-graphql-server.cjs.
But I think the bin command in package.json still points to ./bin/json-graphql-server.js (and not .cjs)
https://github.com/marmelab/json-graphql-server/blob/cdeb68db272100115129e120c040d881ec99693b/package.json#L73-L75
Related code:

Workaround is to try and run the json-graphql-server directly from ./node_modules/json-graphql-server/bin/json-graphql-server.cjs and not from ./node_modules/.bin/json-graphql-server` alias.
./node_modules/json-graphql-server/bin/json-graphql-server.cjs db.cjs
GraphQL server running with your data at http://localhost:3000/

Other information:

Environment

Last version that did not exhibit the issue (if applicable):
Browser:

Thanks for the report. I'm marking this as a bug.


Fixed some grammar mistakes and typos.

As asked, I made fewer commits in this pull request. I will keep reviewing the project... And adding what I found in time. Let me know about your revision.

Well-done.  This is more manageable.  I have fewer comments and some may be coin-flips.  Ramon's review will determine what's important enough to him.

Yes, hope this helps. I still hava a pull request regarding a buffer too small for that data stored. I'll check it soon and some other things I noticed so you can review it.


Throw configurations not documented in wiki

Can someone please take a look at documenting these keys:
  "EnableHumanizedThrows": false,
  "NiceThrowChance": 40,
  "GreatThrowChance": 30,
  "ExcellentThrowChance": 20,
  "CurveThrowChance": 90,
  "ForceGreatThrowOverIv": 90.0,
  "ForceExcellentThrowOverIv": 95.0,
  "ForceGreatThrowOverCp": 600,
  "ForceExcellentThrowOverCp": 1000,

I can tell if they're used when "EnableHumanizedThrows": false.

Not related to the ui.

sorry wrong repo


.cab file download is now a .zip

Page describes the policy templates file download as MicrosoftEdgePolicyTemplates.cab. The file is actually named MicrosoftEdgePolicyTemplates.zip

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8e4fa0af-82d8-c1ca-02b3-fc55eb620ff3
Version Independent ID: bd546e78-3406-0fdd-2aea-d0bd72be9f38
Content: Configure Microsoft Edge for Windows
Content Source: edgeenterprise/configure-microsoft-edge.md
Product: microsoft-edge
GitHub Login: @kelleyvice-msft
Microsoft Alias: brianalt

@jschlackman Thanks for the feedback.  We've updated the documentation and removed the mention of the file.


Transition navbar opacity quicker when switching into expanded mode

Signed-off-by: Victor Porof<EMAIL_ADDRESS>@jsantell I believe this fixes your first bullet point in https://github.com/mozilla/tofino/pull/220#issuecomment-213006017

Coverage remained the same at 37.555% when pulling 469c463e24635cabdbf3dea02b9c21ce9d82c164 on victorporof:transition-opacity-quicker into c60042d7d976b027fba0393a433f2ce00cbd09e1 on mozilla:master.

nice, r+!


instance.commit() with deep values

When commit an clone back to the original instance, removing an item from an array, then commiting can result in the array not changing.  For example, if we remove a role from a user, then commit, the role will still be present because the array values are deep merged.
const todo = new User({
  roles: ['admin']
})
const todoClone = todo.clone()

todoClone.roles = []
todoClone.commit()

console.log(todo.roles.join( , ')) // --> 'admin'

This is a bug.  We should probably be doing a shallow merge.

This seems to have a problem when removing array items. Will do more testing. The merge worked when I added or changed items. But removing items didn't sync correctly across clients.


Update internal AVS evaluation with Tags

Description
Changes proposed in this pull request:

Added GetEvaluation and UpdateEvaluation methods to AVS client
Extend mockAvsServer with new actions
Added new post-action to initialisation step - updating internal AVS evaluation with tags containing additional information from Provisioner: gardener_seed_name, gardener_shoot_name and region

Related issue(s)

/test pre-master-control-plane-gke-integration

/test pre-master-control-plane-integration

/test pre-master-control-plane-gke-integration

/retest

/retest

/retest


upgrade-v12: domain categories are shown in the administration UI but they are not populated in the DB

Package version (if known): v<IP_ADDRESS>b3.x
Describe the bug
When upgrading to v12, the Domains-create administration view shows some available options for the new domain category. These categories cannot be retrieved from the REST API and neither are populated in the DB
Expected behavior
We should populate the values as part of the upgrade script. Below are the available options:

1
organization

2
company

3
mailprovider

4
spammer

Screenshots (if applicable)

icable)

@zzacharo https://github.com/inveniosoftware/invenio-accounts/pull/482 to be discussed


Unable to install on Slack

Hi there,
We've ran into an issue where users are unable to install our bot through Slack. When using an existing account, everything works fine. Here is the error that we see:

This appears to be a regression, as it was working fine at our original launch.

Can you clarify what you mean by "when you use an existing account"?  You just mean that only adding is broken?

It's hard to diagnose the problem exactly. When we authorize it with our existing accounts, everything is fine. We have both an enterprise and free Slack account that we use to test.
To recreate the issue, we created a new Slack account under a new email address. We've tried it on free, standard, and plus plans with this new Slack account.
If we invite the new account to a team on our existing accounts, the authentication works when authorizing for that team. But when authorizing for the new account's team, the authorization fails.
We're trying to get more information from our users as to what type of Slack accounts they have, but our only reproduce-able steps so far have come from a new Slack account being created.
Where can we go to see the errors that are occurring on the Bot Framework's side?
I hope this clarifies the issue, let me know if you need more information!

I've verified I can add bots to Slack teams generically, so there must be something specific.  Any possibility you could share your bot handle so we could take a look?  If you're uncomfortable with public, send to<EMAIL_ADDRESS>and mention @jameslew in the body.

Given I haven't heard any further, I'm going to close this item.


Rename ActivityList module file to use PascalCase.

@demamoh This looks great!  Here's a small PR to use PascalCase for the file names, which I think is standard.

@tmciver  Thanks. If you see more more changes keep them coming.


Feat(web): Switch Modal component to v3 design tokens #DS-1452

Description
Each Modal variant visual test can be enabled when form fields are switched.
Additional context

Issue reference

coverage: 78.41% (-0.7%) from 79.151%
when pulling a42eb1be5f0e15b60f9be78ca65d5eaa82adadf5 on feat/v3-modal
into 10beba373b141f9d08bbd8c434387adce6d75862 on bc/v3-tokens-button.


Roll Engine from 13d8565cf2e4 to 6442165e8e05 (1 revision)

https://github.com/flutter/engine/compare/13d8565cf2e4...6442165e8e05
2021-04-14<EMAIL_ADDRESS>Roll Skia from 785a3262d116 to cdee12018087 (13 revisions) (flutter/engine#25589)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


chat rendering bug / overlapping text

have panel chat open
focus the editor
move hover focus between the editor and panel chat
🐛 see text rendered over the top of panel chat response
https://github.com/microsoft/vscode/assets/29464607/5abae118-f082-44b9-9341-19c51d680431

I fixed an issue yesterday that probably addresses this. If you still see it, let me know and check for an error in the Window log.

https://github.com/microsoft/vscode/pull/212732


Can the gRPC server be started before mavsdk-server discovers/connects to a system?

In some cases, applications using mavsdk may start before the UAV system starts and is discovered by the mavsdk-server. In this case, clients intending to connect to the mavsdk-server will effectively have to block because the gRPC port will not be available.
Alternatively, if the gRPC server is up and the port is available, the clients won't have to block and the channels that are running in the background will automatically start receiving data once the UAV system is discovered.
The earlier versions of the mavsdk-server used to behave in the same manner which made client-side implementation quite easy.

Yeah it used to be that mavsdk would create a "dummy" system to receive subscriptions and whatnot, but that's not the case anymore. So your app has to wait until the drone is discovered before it can start the subscriptions. mavsdk-server is just reflecting that :innocent:

I noticed this code in mavsdk_server_api.cpp:
    if (!mavsdk_server->connect(std::string(system_address))) {
        // Connection was cancelled
        return false;
    }

    auto grpc_port = mavsdk_server->startGrpcServer(mavsdk_server_port);
    if (grpc_port == 0) {
        // Server failed to start
        return false;
    }

    return true;

Are there any chances that putting mavsdk_server->startGrpcServer(mavsdk_server_port) before mavsdk_server->connect(std::string(system_address)) would create any bugs?
Because in that case, the clients can push mavsdk_server.run() to the background thread and the gRPC port would be open for clients to connect before server blocks for systems.

That won't work because the server implementation now needs to discover a drone. If you do that, your subscriptions won't ever have an effect because mavsdk won't save them for when a system is discovered.
Unfortunately I think that you have to deal with that on your side...

Oh. I hadn't noticed when I was testing it because SITL was always there. Maybe I can make some changes to MAVSDK-Java so that the API works the same as before.

In my opinion, a very good next step for MAVSDK-Java would be to remove the dependency on gRPC and use direct bindings instead (i.e. JNI), so that it would be much more lightweight. But it also means that the API would get closer to the C++ API, which does not allow that at the moment.
And there you would see why this is problematic: MAVSDK-C++ supports discovering multiple drones, so if you subscribe to, say, the position updates before a drone is known, then MAVSDK cannot know if you were meaning to subscribe to the first or to the second drone that appears. That's why this is delegated to the user, because they know their use-case (and MAVSDK doesn't) :grin:.

Yes indeed, and that would be an interesting project to take up. We not only use MAVSDK-Java for the Android GCS, but also on companion computers running our headless Java framework. And this would definitely give a performance boost to it.
But for now, I was thinking of altering some logic in the plugin wrappers that can give users a bit more flexibility without them having to worry about initialisation problems while keeping the API as simple as it was before. That certainly helped me a lot in adopting the library. And then we can look into JNI and multiple system support. I'll try to create a PR soon.


Insufficient error message for deleted wego controllers

Describe the bug
When user tries to run wego add after removing
Environment

wego: [v0.0.0]

Affects versions

wego: [v0.0.1]

To Reproduce
Steps to reproduce the behavior:

Download wego binary
Run wego install | kubectl apply -f -
Run wego install | kubectl delete -f -
Run wego add .
See error message in console

Config and Logs
wego add . --url github.com/iahmad9
Updating parameters from environment... using URL: 'github.com/iahmad9' of origin from git config...
done
Checking cluster status... Unknown
wego repo does not exist, it will be created...
Reinitialized existing Git repository in /Users/iahmad/.wego/repositories/test-gke-ubuntu-latest-wego/.git/
ERROR: Repository not found.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights and the repository exists.
could not add remote: exit status 1
Screenshots
Additional context
Discussion in slack: https://weaveworks.slack.com/archives/C0140SWQ94M/p1622659257381800?thread_ts=1622652563.371800&cid=C0140SWQ94M

Fixed in more recent versions.


timelines should be created so that only their owner can write on them.

Presumably by PL tweaking?


Sort by Star Count

Description
Add 'Least stars' and 'Most stars' as sort metrics on the website, and possibly default to 'Most stars'
Use Case
I would like to be able to sort community constructs by star count as I think it's a helpful metric for popularity.
Other information
npm downloads alone can be manipulated or misrepresented.  As mentioned in a npm blogpost the download count includes.

automated build servers
downloads by mirrors
robots that download every package for analysis

Download count can still be useful for identifying trends, but there should be options for other metrics, especially if ConstructHub is continually indexing packages

I think a feature like this could be tricky to add because not all projects published to npm are on GitHub. In addition, information about a package's repository URL provided by package.json could be incorrect or even misrepresented (as there is no mechanism that validates this is correct).

That's a very good point.  Is there potential for some sort of rating system within ConstructHub (appstore like rating features)? Community driven input would be helpful for searching through constructs, especially when there are many similar options.

@dontirun we have talked about creating some sort of aggregate to indicate "popularity" or how active a project is in general. Something like a combination of github stars, # of recently closed issues, npm downloads, frequency of recent commits, etc.
If you're interested in this definitely feel free to do some research and let us know what you think would be the best strategy. My instinct is that we could compute this for each package while computing other metadata, like tags, and put it into the metadata where it will be added to the catalog to use for searching/sorting. So around here in the current code.

Another idea would be to add construct specific information into the cdk analytics metadata. However that could have some privacy concerns and there could be issues with max template size given the usage of many constructs.


Allow to remove Keycloak User (not the linked RDBMS database record) with a new setting

The new setting looks like this and is OFF by default:

Before this PR (and still the case if the parameter stays OFF), if you try to click "Delete" on a Keycloak User fetched by the plugin, you get the error "Error! User couldn't be deleted":

The PR adds the possibility, when the new setting is ON, to let Keycloak delete its version of the user (not the user record in the linked RDBMS), allowing the user to be re-fetched from scratch from the RDBMS on the next sync.
This is useful for testing, but also to solve sync issues for given users.
Note that the addUser method is implemented to satisfy the UserRegistrationProvider interface, but does nothing more than before: it just lets the call pass through, as per the recommendation in the Keycloak documentation here: https://www.keycloak.org/docs/latest/server_development/#:~:text=The addUser() method will be called

Nice addition, every time I had to change some user data I ended up cleaning the entire user base in order to perform a hard reload.