frozen worker

Hi,
From time to time my trains-agent workers freeze.
Currently, I have one task marked as "complete" (which seems plausible given the log) still enqueued in the worker. My only option to free the worker is to reset the task and lose the data.
I have another "running" task which is frozen with no outputs for a while. This task can be aborted to free the worker.
I use trains v14.2 and trains-server v14.
Is it a known issue?
Thanks

Hi @elinep
Thanks for reporting this :)
A few questions to clarify:

What version of Trains Agent are you using?
Are you using the Trains Agent in --docker mode?
What do you mean when you say your completed experiment is "still enqueued in the worker"? Does that mean you still see the worker listed in the workers page as running this experiment?
Can you see if there's any text in the completed experiment's INFO panel, STATUS MESSAGE field?
Can you see if the running experiment's LAST UPDATED AT field under the INFO panel is also frozen, or is it getting updated from time to time?

What version of Trains Agent are you using?
0.13.3
Are you using the Trains Agent in --docker mode?
the trains-agent is running inside our own docker image
What do you mean when you say your completed experiment is "still enqueued in the worker"?
The experiment appears in http://trainserver/workers-and-queues/workers
Does that mean you still see the worker listed in the workers page as running this experiment?
yes
Can you see if there's any text in the completed experiment's INFO panel, STATUS MESSAGE field?
STATUS MESSAGE: Changed by trains-agent trains-agent-777949bb7c-4j4wq:gpuGPU-30e3a01d-5a6e-cf57-85ab-10d4e05f85e2
Can you see if the running experiment's LAST UPDATED AT field under the INFO panel is also frozen, or is it getting updated from time to time?
Both experiments (running and complete) are updated frequently ("Update Time: a few seconds ago")

Thank you for your time.

Hi @elinep
From the looks of it, it seems that somehow the Task state was changed, and the thread that checks it died, otherwise it would have terminate the process. (BTW, could it be that the Task changed its own status? Just clarifying, this is supported, but it might help reproduce / locate the bug)
Anyhow could you change to the latest trains-agent, we have fixed a few issues relating stability.
pip install trains-agent==0.14.2rc2
Regrading the Task stuck in running, that might have to do with the actual python code running.
Any stdout/stderr prints from that process are immediately logged in the Task, so if you see nothing it does mean it is stuck, but the process is still running.
Which trains version are you using with this specific Task ? (I remember vaguely that we did see this behavior a few times, i.e. process stuck when leaving, but it was fixed with 0.14.2 (I think))
As for the Task in completed mode, I guess the only way to kill the process save the logs is, either connect to the container and kill the trains-agent or restart the container :(

The script doesn't touch the status.
We use trains == 0.14.2 for both tasks
I ran ps aux on several machines:
A) Task still Running / worker busy:
root@trains-agent-777949bb7c-xw46z:/app# ps aux
USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root         1  2.1  0.1<PHONE_NUMBER>6 ?        Ssl  May12 240:19 /usr/bin/python3 /usr/local/bin/trains-agent daemon --queue kube
root       265  5.6 10.9 16228604 3609288 ?    Sl   May13 533:20 /root/.trains/venvs-builds/3.6/bin/python -u train_script.py
root     24284  0.0  0.0  18508  3476 pts/0    Ss+  May18   0:00 /bin/bash
root     24307  1.0  0.0  18508  3268 pts/1    Ss   06:42   0:00 bash
root     24321  0.0  0.0  34404  2808 pts/1    R+   06:42   0:00 ps aux

B) Task Completed / worker busy:
root@trains-agent-777949bb7c-9dtgx:/app# ps aux
USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root         1 47.9  0.1<PHONE_NUMBER>8 ?        Ssl  Apr30 13707:03 /usr/bin/python3 /usr/local/bin/trains-agent daemon --queue kube
root<PHONE_NUMBER>  0.5 2132380 278388 ?   R    Apr30 21142800:27 /root/.trains/venvs-builds/3.6/bin/python -u src/train_script.py
root       441  0.0  0.5 2240644 255304 ?      D    May07   0:09 /root/.trains/venvs-builds/3.6/bin/python -u train_script.py
root       562  0.0  0.5 2132392 278464 ?      D    May07   5:09 /root/.trains/venvs-builds/3.6/bin/python -u src/train_script.py
root       642  0.0  0.5 2240668 255308 ?      D    May12   3:53 /root/.trains/venvs-builds/3.6/bin/python -u train_script.py
root       729  0.0  0.5 2240660 255944 ?      D    May13   0:07 /root/.trains/venvs-builds/3.6/bin/python -u train_script.py
root       811  0.2  0.5 2240656 255872 ?      Dl   May14  24:08 /root/.trains/venvs-builds/3.6/bin/python -u train_script.py
root       898  0.3  0.0  18508  3344 pts/0    Ss   06:45   0:00 bash
root       912  0.0  0.0  34404  2908 pts/0    R+   06:45   0:00 ps aux

C) Task running, no issue:
root@trains-agent-777949bb7c-2fzxj:/app# ps aux
USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root         1  2.7  0.2<PHONE_NUMBER>0 ?        Ssl  Apr07 1709:09 /usr/bin/python3 /usr/local/bin/trains-agent daemon --queue kube
root      1316  0.0  0.0      0     0 ?        Z    Apr16   0:35 [python] <defunct>
root      1372  0.0  0.0      0     0 ?        Z    Apr16   0:06 [python3.6] <defunct>
root      1414  0.0  0.0      0     0 ?        Z    Apr16   0:05 [python3.6] <defunct>
root      1466  0.0  0.0      0     0 ?        Z    Apr16   0:13 [python] <defunct>
root      7929  0.0  0.0      0     0 ?        Z    Apr09   0:37 [python] <defunct>
root     13332  317 10.7 16165924 3518368 ?    Rl   06:42  14:49 /root/.trains/venvs-builds/3.6/bin/python -u train_vae.py
root     15738  0.0  0.0      0     0 ?        Z    Apr17   0:46 [python] <defunct>
root     15742  0.0  0.0      0     0 ?        Z    Apr17   0:46 [python] <defunct>
root     15746  0.0  0.0      0     0 ?        Z    Apr17   0:46 [python] <defunct>
root     23420  0.0  0.0  18508  3232 pts/0    Ss   06:47   0:00 bash
root     23542  0.0  0.0  34404  2744 pts/0    R+   06:47   0:00 ps aux
root     28494  0.0  0.0      0     0 ?        Z    Apr20   7:02 [python] <defunct>
root@trains-agent-777949bb7c-2fzxj:/app#

There are several process still running on machine B.
We will update trains-agent and keep you updated if we see this issue again.
Thanks for your support.

Closing issue (re-open if the problem resurfaces)


Remove unneeded warnings in build

Currently a full build generates many warnings that could be trivially avoided by simple code changes. Do each as a separate commit.
In umpleSelf
    [java] Warning 49 on line 1591 of file "Generator_CodeJava.ump":
     [java] A  implementation of Method 'addJavaLttngImport' in class 'JavaGenerator' is already defined at line 1575 of 'Generator_CodeJava.ump' file. New definition at line 1592 of 'Generator_CodeJava.ump' file is being disconsidered

Solution: Comment out the disconsidered version, verify all is OK, then delete it.
     [java] Warning 3 on line 449 of file "Umple.ump":
     [java] The lazy keyword is redundant when the attribute is being initialized - in class 'CodeInjection'

Solution remove the lazy keyword. Verify all is OK.
     [java] Warning 1012 on line 584 of file "Umple.ump":
     [java] Method 'setImmutable' cannot be found. Injection was ignored.
     [java] Warning 1012 on line 660 of file "Umple.ump":
     [java] Method 'setImmutable' cannot be found. Injection was ignored.
     [java] Warning 1012 on line 664 of file "Umple.ump":
     [java] Method 'setExtendsTrait' cannot be found. Injection was ignored.

Try to understand why these were here to start with. Verify that in fact these are doing nothing by commenting the lines out. If all is OK then delete.
There are other warnings in some tests that can be dealt with

See what warnings are left by doing a full build. Many have been removed.

Here are messages that could be cleared from the build as of Sept 2016
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.

compileJava:
[java] Processing -> testbed/src/TestHarness.ump
[java] Warning 301 on line 22 of file "TestHarnessTracerTraceCase.ump":
[java] Tracing of non-existent model entity
[java] Warning 301 on line 23 of file "TestHarnessTracerTraceCase.ump":
[java] Tracing of non-existent model entity
[java] Warning 67 on line 365 of file "TestHarnessStateMachineJava.ump":
[java] State 'Sss2' from StateMachine 'Ss1' is non-reachable.
[java] Warning 50 on line 371 of file "TestHarnessStateMachineJava.ump":
[java] State 'S1.Sss2' has not been declared, it is being treated as an new state

Regarding this error "[javac] Note: Recompile with -Xlint:unchecked for details." you may have a look at this http://stackoverflow.com/questions/4134803/ant-passing-compilerarg-into-javac

Yes, I found that out by reading through the manual for at on https://ant.apache.org/manual/using.html#arg
Adding that to the javac in build.umple.xml (lines 191 to 207) makes the deprecation warnings appear.

While investing the -Xlint:unchecked warnings, Vahdat suggested that some can't easily be resolved, and that we should just suppress the warnings with @SuppressWarnings("unchecked").
After attempting to use that annotation, we discovered that the umple compiler is having a problem with annotations. Vahdat raised a separate issue regarding this (https://github.com/umple/umple/issues/884), as such, a lot of the unchecked warnings cannot be dealt with until that issue is resolved.

So maybe then the only solution to this issue is to tell the compiler to suppress the warnings, or to just delete this issue ... that is, if we can't fix the code easily to deal with the deprecations.

that's exactly what we want to do. UmpleCompiler cannot deal with suppress and then the final project cannot be compiled. I think we should forget to remove -Xlint:unchecked from the warning list.

Agreed.

I was able to resolve all -Xlint:deprecation warnings.
The warnings in compileJava:
[java] Processing -> testbed/src/TestHarness.ump
[java] Warning 301 on line 22 of file "TestHarnessTracerTraceCase.ump":
[java] Tracing of non-existent model entity
[java] Warning 301 on line 23 of file "TestHarnessTracerTraceCase.ump":
[java] Tracing of non-existent model entity
[java] Warning 67 on line 365 of file "TestHarnessStateMachineJava.ump":
[java] State 'Sss2' from StateMachine 'Ss1' is non-reachable.
[java] Warning 50 on line 371 of file "TestHarnessStateMachineJava.ump":
[java] State 'S1.Sss2' has not been declared, it is being treated as an new state

Are not valid warnings, they result from two separate bugs with state machines. Two issues have been raised regarding this. (https://github.com/umple/umple/issues/885 and https://github.com/umple/umple/issues/886)


Consistent labels for all prometheus output are needed

I have found a problem with inconsistent labels.  Each metric scrape of a specific metric must contain exactly the same labels as every other metric scrape. In other words: excluding labels like "probe_address_v6" can't be done.  If a probe doesn't have a v6 address, simply leave it as equalling nothing, like this:
probe_address_v6=""
Here's the errors I'm getting on attempted imports:
Dec 16 01:41:26 res120 node_exporter: * collected metric ripe_atlas_latency label:<name:"measurement_id" value:"12016241" > label:<name:"probe_address_v4" value:"<IP_ADDRESS>" > label:<name:"probe_address_v6" value:"fd7a:115c:a1e0::3" > label:<name:"probe_asn_v4" value:"56478" > label:<name:"probe_country" value:"GB" > label:<name:"probe_id" value:"1002880" > label:<name:"probe_lat" value:"51.4775" > label:<name:"probe_lon" value:"-0.2185" > label:<name:"sample_reported_host" value:"res730" > label:<name:"sample_reported_pop" value:"lhr" > label:<name:"version" value:"4" > untyped:<value:1.589 >  has label dimensions inconsistent with previously collected metrics in the same metric family

I'll clarify and that means that if a probe doesn't have an IPv4 address, there should still be a label of "probe_address_v4="" " in the metric line for that probe.  Similarly, any other empty label just needs to be left as empty rather than not appearing at all.

@johnhtodd I thought you mentioned that Prometheus doesn't like it when we have a null/nan value?

You can have null values for labels, but not null values for the metric data.
This works (note the null labl values for v6 data in probe 99's set):
ripe_atlas_latency{measurement_id="12016241",probe_id="991",version="4",target_ip="<IP_ADDRESS>",probe_asn_v4="5607",probe_address_v4="<IP_ADDRESS>",probe_asn_v6="5607",probe_address_v6="2a02:c7c:a86a:3d00:220:4aff:fec7:af8e",probe_country="GB",probe_lat="51.2375",probe_lon="-0.2485",sample_reported_pop="lhr",sample_reported_host="res730"} 13.667

ripe_atlas_latency{measurement_id="12016241",probe_id="99",version="4",target_ip="<IP_ADDRESS>",probe_asn_v4="378",probe_asn_v6="",probe_address_v6="",probe_country="IL",probe_lat="32.1115",probe_lon="34.8115",sample_reported_pop="tlv",sample_reported_host="res200"} 14.12

But this will fail because the metrics of the same name (ripe_atlas_latency) have inconsistent label sets- some of them will be imported but the "wrong" label set ones will not.  I think the "right" label set is defined by the first label set of a metric with that name that reach the database, and then everything after that point is compared with that first example.
ripe_atlas_latency{measurement_id="12016241",probe_id="991",version="4",target_ip="<IP_ADDRESS>",probe_asn_v4="5607",probe_address_v4="<IP_ADDRESS>",probe_asn_v6="5607",probe_address_v6="2a02:c7c:a86a:3d00:220:4aff:fec7:af8e",probe_country="GB",probe_lat="51.2375",probe_lon="-0.2485",sample_reported_pop="lhr",sample_reported_host="res730"} 13.667

ripe_atlas_latency{measurement_id="12016241",probe_id="99",version="4",target_ip="<IP_ADDRESS>",probe_asn_v4="378",probe_country="IL",probe_lat="32.1115",probe_lon="34.8115",sample_reported_pop="tlv",sample_reported_host="res200"} 14.12

This will also fail because there is no metric value:
ripe_atlas_latency{measurement_id="12016241",probe_id="99",version="4",target_ip="<IP_ADDRESS>",probe_asn_v4="378",probe_country="IL",probe_lat="32.1115",probe_lon="34.8115",sample_reported_pop="tlv",sample_reported_host="res200"}

@johnhtodd, can u confirm this is ok? I will commit the changes if this is fine.
HELP ripe_atlas_latency The number of milliseconds for response reported by this probe for the time period requested on this measurement
TYPE ripe_atlas_latency gauge
ripe_atlas_latency{measurement_id="12016241",probe_id="99",version="4",target_ip="<IP_ADDRESS>",probe_asn_v4="378",probe_address_v4="",probe_asn_v6="",probe_address_v6="",probe_country="IL",probe_lat="32.1115",probe_lon="34.8115",sample_reported_pop="tlv",sample_reported_host="res200"} 14.12
ripe_atlas_latency{measurement_id="12016241",probe_id="991",version="4",target_ip="<IP_ADDRESS>",probe_asn_v4="5607",probe_address_v4="<IP_ADDRESS>",probe_asn_v6="5607",probe_address_v6="2a02:c7c:a86a:3d00:220:4aff:fec7:af8e",probe_country="GB",probe_lat="51.2375",probe_lon="-0.2485",sample_reported_pop="lhr",sample_reported_host="res730"} 13.667

Technically, this should work - I see all the same labels between the two examples.
However, having both the probe_address_v4 AND the probe_address_v6 labels as empty is a bit unexpected, as at least one of them should be filled in.

@johnhtodd fixed in commit a0584c3ec8e6e0040e802166d992222b26b6bd1e please verify

Verified, but I found a problem further downstream.  The method you've used works well, but makes querying extremely difficult (or impossible) with the variables I want to set in the graphs.
I'd like to reverse my previous request, but only a tiny bit.  Instead of setting values to "" (null) if there is no data for the ASN field, I'd like to have you set it to "unknown".   This will allow me to match on a non-null string for some of the wildcard searches I need to do (null and non-null are separate syntax, and queries fail if I do not match on both, but that isn't possible, since I am trying to set variables to match... it's complicated, but basically I need the values set to a string  instead of set to null if there is no value you could get from the live data or the cached file.)
This also allows the condition if you can't find an ASN for either the live data OR the cached data.  It's not optimal, but at least we can still capture the information about the probe even if there is no ASN data.

@johnhtodd change "" value into "unknown" . commit 335a0d35ed59726f421e9dde280a517f774b2f71. Please verify


remove heads encryption keys

About the PR

Initially was part of #14415.
Design doc by @QuietlyWhisper
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

tweak: renamed command encryption key to all access encryption key.
add: added command encryption key (common/command).
tweak: centcom encryption key now only gives access to common/centcom.
remove: removed heads encryption keys. Heads get second key in headsets (command encryption key) to access command channel.

failed test seems to just be a test issue

is "station master key" a good name?

all done but the key name may change


vagrant: bump ubuntu-next VM image and increase jenkins timeouts

The new VM image includes the latest version of cilium-{builder,runtime} images: https://github.com/cilium/packer-ci-build/pull/208.
We will also increment the timeouts of all jenkins jobs so they don't fail due timeouts.
This should fix the timeouts we see in the net-next CI jobs.
The ubuntu image will be updated in a separate PR (it's still building), and it's not affected by the timeouts (we don't have that many tests in 4.9).

test-me-please

Coverage increased (+0.02%) to 46.827% when pulling 53b7c7f932c5abd8578ff12cee78e2a1be2cf6c2 on pr/update-packer-ci-b into 58195f13295ea2579fc7b61694737a6419256c21 on master.

restart-ginkgo

restart-ginkgo


RFC: RTIO: Take priority into account when pushing new node onto MPSC queue

Introduction
Currently the priority of a SQE is never taken into account when performing RTIO operations.
On place where I could see priority being useful is the submission queue.
When a new SQE is popped it should be the one with the highest priority.
Problem description
When calling rtio_mpsc_push the MPSC node is simply appended to the current head of the linked list.
When calling rtio_mpsc_pop the MPSC node at the tail is returned.
The priority is not taken into account, there is no reordering happening
Proposed change
When calling rtio_mpsc_push the MPSC node should be inserted depended on the priority of the SQE.
This would mean iteration from tail to head and checking the priority of every SQE.
When the priority is lower the SQE will be inserted before it.
Concerns and Unresolved Questions
Taking priority into account can get quite complex.
The proposed change suffers from issues that are similar to the one from a task scheduling algorithms.

Low priority SQEs could starve and never execute at all
Multi shot SQEs might need to be executed without interruptions
Consuming a CQE might require matching with SQE

Alternatives
The executor (Bus/Sensor) implementation could do some scheduling itself.
Some possible ideas:

Add a rtio_mpsc_push_tail function for high priority SQEs
Add functions to peek the queue without removing nodes and function to pop a specific one

If RFC is accepted it could be added to #46658

I've assigned myself, but anyone wishing to take this on is welcome to. Please re-assign and discuss, I think this a worthy feature and the RFC we can say has passed.


Dynamically get information for server to display content

Currently, the information to display is being read from a local file. For every component that display something to the screen, there is one corresponding file with identical name that hold the data. Need to instead cooperatd reactJS with restAPI to get data form server instead.

Updated: the Side menu is partially have this feature now. The data for the challenge-sets (list 2) to display is fetch from server. However, the list 1 is still read from local

This is done!


I made my two assigned error exception functions (cycle detection and all vertices connected)

Please work, had some issues with the isort and black commands causing previous issues, should be good now.

well I am giving up for now, this makes no sense.


Wiki redirects to the wrong page

Is your feature request related to a problem?
From the wiki: The documentation has migrated to https://purpur.pl3x.net/docs. However, the hyperlink leads to https://pl3xgaming.github.io/PurpurDocs/, which does not exist.
Describe the solution you'd like.
Changing the hyperlink so that both the text and the link direct to the same place.
Agreements
Please agree to the following.

[✓] I have searched for and ensured there isn't already an open issue regarding this.
[✓] I have ensured the feature I'm requesting isn't already in the latest supported Purpur build.

fixed.


[release-4.8] Add RHCOS kernel options before installation

Signed-off-by: Aishwarya Kamat<EMAIL_ADDRESS>

This PR is a new feature, it should be merged to master first, then cherrypick to other release branches.


Cannot change the height of messages pane

As the title says, does anyone know how to change the height of the messages pane after excute? It keeps using half of my screen height

@Kritiqual you should be able to resize the message pane using the sash control.  When the mouse is hovered over the divider line between the message and editor controls the divider should change to a wider blue line indicating that the cursor is positioned correctly for resize operation (see screenshot for example).  Is this not the behavior you're observing?  Maybe a screenshot would be helpful to provide better suggestions.  Thanks!

i did that, but when I choose another block of code, it goes back to original size

so the request here is to remember the results/messages pane's size and apply it to subsequent query editors, right?

Yes, that's what I want :||


Error

Just tried the workflow and got this error:
Starting debug for 'Productivity Time Calendar'

[ERROR: alfred.workflow.input.scriptfilter] Code 1: 10:19:43 workflow.py:1945 DEBUG    Workflow version : 1.1.0
10:19:43 workflow.py:1951 ERROR    u'alfred.theme.lightlarge'
Traceback (most recent call last):
  File "workflow/workflow.py", line 1946, in run
    func(self)
  File "main.py", line 37, in main
    texts = cal.get_weeks_text(year, month)
  File "cal.py", line 33, in get_weeks_text
    format = Format(self.key, self.path)
  File "format.py", line 14, in __init__
    self.font = self._load_font(key, path)
  File "format.py", line 18, in _load_font
    font = pref['themes'][key]['resultTextFont']
KeyError: u'alfred.theme.lightlarge'
10:19:43 workflow.py:1969 DEBUG    Workflow finished in 0.106 seconds.
[ERROR: alfred.workflow.input.scriptfilter] Code 1: 10:19:46 workflow.py:1945 DEBUG    Workflow version : 1.1.0
10:19:46 workflow.py:1951 ERROR    u'alfred.theme.lightlarge'
Traceback (most recent call last):
  File "workflow/workflow.py", line 1946, in run
    func(self)
  File "main.py", line 37, in main
    texts = cal.get_weeks_text(year, month)
  File "cal.py", line 33, in get_weeks_text
    format = Format(self.key, self.path)
  File "format.py", line 14, in __init__
    self.font = self._load_font(key, path)
  File "format.py", line 18, in _load_font
    font = pref['themes'][key]['resultTextFont']
KeyError: u'alfred.theme.lightlarge'
10:19:46 workflow.py:1969 DEBUG    Workflow finished in 0.372 seconds.
[ERROR: alfred.workflow.input.scriptfilter] Code 1: 10:19:46 workflow.py:1945 DEBUG    Workflow version : 1.1.0
10:19:46 workflow.py:1951 ERROR    u'alfred.theme.lightlarge'
Traceback (most recent call last):
  File "workflow/workflow.py", line 1946, in run
    func(self)
  File "main.py", line 37, in main
    texts = cal.get_weeks_text(year, month)
  File "cal.py", line 33, in get_weeks_text
    format = Format(self.key, self.path)
  File "format.py", line 14, in __init__
    self.font = self._load_font(key, path)
  File "format.py", line 18, in _load_font
    font = pref['themes'][key]['resultTextFont']
KeyError: u'alfred.theme.lightlarge'
10:19:46 workflow.py:1969 DEBUG    Workflow finished in 0.107 seconds.

Hi @politicus
I see what the problem is. I'm fixing it right now, sorry for the inconvenience.
Owen

Hi @politicus
I just published a new version of workflow which shall fix the error.
Also, default width might be too much for Light Large theme. You can change it by cal config and set the width to 9 or 8.
Owen

Working great. Thank you.

Not a problem and sorry for not testing default Alfred theme. Thanks for you report! :smile:


Add changelog and draft new release

Need to add a changelog file and draft new release.

Fixed 71ffa43. Closed.


fix #62 - sort-default direction is backwards

Hey @timbowhite sweet!
Can you pull the customSort commit out of this pull request and submit separately? Also it looks like Travis tests are failing here. You can run them locally via npm test.

I agree with @tristen, you should checkout 0d47bdd into a new branch and submit a PR for that.
Also, I've realized that the "dot separated numbers" test is wrong. I've submitted PR #65 for that. Maybe we should correct the tests first?

Okay, I cherry-picked 6054a73 into my own branch and updated the tests to accommodate ascending order. You can view the branch here: https://github.com/ryanmjacobs/tablesort/tree/default-sort-direction.
All tests are passing, btw. Here's the demo page: http://ryanmjacobs.github.io/tablesort/demo/.

@ryanmjacobs Can confirm, that commit does fix the issue.

It also looks like that commit remove the need for update param in sortTable function, would be good to get rid of that too.

@xPaw Okay, I've removed the update param from sortTable and merged the fix.
@timbowhite You should re-title this as "Add customsort" or something like that because #62 should be fixed now.

This issue was fixed, so I will close this PR.


Please streamline the user experience

Ensure every area where text can be entered that this user is aware of what input is accepted.
Do not force the user to "press enter to continue" at any point in time. The user doesn't want to have to repeatedly press enter.

?

User no longer has to press enter when being asked yes or no to exiting and saving.  User also can now tab complete scratch/current when deciding type of save.

Unfortunately, the use of the keyboard module was outlawed and as a result this issue will need to be reworked.

New implementation has been added to handle y/n/c without the need for admin privs.  Tab complete now also works and gives a drop down list to tab through to auto complete your option.


Not all colors defined in macros.js working

Before reporting a bug

[X] Check common issues.
[X] Check the bug is reproducible in the demo. If not, check KaTeX is up-to-date and installed correctly.
[X] Search for existing issues.

Describe the bug:
In macros.js, quite a few colors are defined but when I try using them on katex.org demo, only few of them are being rendered in the right color and rest are only being render in default black.
To Reproduce:
Steps to reproduce the behavior:

Go to 'https://katex.org'

Type in the following

\textcolor{blue}{ 42 } \\
\textcolor{red}{ 42 }   \\
\textcolor{redA}{ 42 } \\
\textcolor{greenA}{ 42 }

The first 2 lines are rendered in the right color but the last two are rendered in default black. No error is thrown for missing color name.

Expected behavior:
All colors defined in macros.js should work.
Screenshots:

\redA is a macro; redA is not a color. The correct usage is \redA{42}.
However, the plan is to remove all of these macro definitions (see #28) so you shouldn't be using these.


using "[[]]" in queries doesn't work

I want to display a page gallery of all the pages that link to the current page (filtered by tag, but that's irrelevant).
In DataView, the simple query "LIST FROM [[]] and #my-tag" works just fine, but when I use that in page-gallery it doesn't, for some reason. If I change the query to "from: '[[MyPage]] and #my-tag'" it works, but that means I have to enter the page name manually and it will break on renames.
The same is true for "where". If I put "where: contains(myKey, [[]])" it never works, but "where: contains(myKey, [[MyPage]])" works fine.
Would be great if that could be fixed as it makes it so much easier to write reusable galleries.

The from clause issue should be fixed in  0.7.3. I haven't found a way to get self-links working in the where clause or other fields (sortBy, fields, groupBy have this issue as well), since there doesn't seem to be a way to pass the origin page into the DataviewApi#evaluate function right now; it seems to be using a default LinkHandler with "" as its base path, and I can't find a good way to override/replace that without copying a bunch of internal Dataview code. I'm going to open an issue on https://github.com/blacksmithgu/obsidian-dataview to see if the evaluate function can be updated to support different origin pages. I'll keep this issue open and link it to that one.

Opened https://github.com/blacksmithgu/obsidian-dataview/issues/1930

As a workaround, you can use this in the where, sortBy, fields, and groupBy settings to refer to the current page; so this query should also work: where: contains(myKey, this.file.link) .

Oh nice, thanks!


what is the best way to get a Geohash of a location?

I know your package is not meant for this, but I am trying to minimize the number of packages and so trying to squeeze this capability  out of your code.
I tried calling createGeohashes(43.6500245, -79.5290709, 0.1, 9);
this one returns two: [dpz2q60xy, dpz2q60xv], which could actually be correct as this is a multi-unit building, but figured I'd check with you whether this is expected behaviour.
If it is, could you suggest of a better way to get the one geohash of a location?

In order to get a more precise geohash you will need a higher precision. If you use precision 11 such as  createGeohashes(43.6500245, -79.5290709, 0.1, 11) you will get a single response of dpz2q60xy66. However higher precisions requires more computations and will slow down your code. This website has some nice visuals for how the precision works in terms of spatial distances.
In terms of this tool being able to solve for your exact problem it depends what you are using the geohashes for. I worked on another project geohashtree, which helps ingest and store lat long coordinates by their geohashes and allows you to use proximity hash on a subset of those.

In order to get a more precise geohash you will need a higher precision. If you use precision 11 such as  createGeohashes(43.6500245, -79.5290709, 0.1, 11) you will get a single response of dpz2q60xy66. However higher precisions requires more computations and will slow down your code. This website has some nice visuals for how the precision works in terms of spatial distances.
In terms of this tool being able to solve for your exact problem it depends what you are using the geohashes for. I worked on another project geohashtree, which helps ingest and store lat long coordinates by their geohashes and allows you to use proximity hash on a subset of those.

@anovis thanks! I do get only one geohash from the website you recommended as well as this other website
also, if I understand geohash concept correctly, higher precision would give me the smaller quadrants within the quadrant with precision of 9, so in your example above the first 9 digits of the precision 11 geohash is dpz2q60xy.
if I run createGeohashes(43.6500245, -79.5290709, 0.1, 10), I get
[dpz2q60xy6, dpz2q60xy4], where the first 9 digits are also dpz2q60xy
in both scenarios with higher precision the first 9 digits match the first value returned when I use createGeohashes(43.6500245, -79.5290709, 0.1, 9).
Is it really supposed to return a second geohash dpz2q60xv? I tried reducing the radius to 0.000001 but still get two codes back.
I understand that it's meant for getting the nearby geohashes, but thought reducing the radius to something minuscule would give me only one result.
What I am trying to do is to generate and save a bunch of geohashes based on street addresses (ideally one per address), so that I can then query them based on user's requested radius. So I am trying to also use createGeohashes() to get the one geohash per address but with lower precision as that should be sufficient for my purposes and to your point - would be a little faster.
I checked out your geohashtree package, but I don't think it has a capability to generate geohashes, does it?

@anovis thanks! I do get only one geohash from the website you recommended as well as this other website
also, if I understand geohash concept correctly, higher precision would give me the smaller quadrants within the quadrant with precision of 9, so in your example above the first 9 digits of the precision 11 geohash is dpz2q60xy.
if I run createGeohashes(43.6500245, -79.5290709, 0.1, 10), I get
[dpz2q60xy6, dpz2q60xy4], where the first 9 digits are also dpz2q60xy
in both scenarios with higher precision the first 9 digits match the first value returned when I use createGeohashes(43.6500245, -79.5290709, 0.1, 9).
Is it really supposed to return a second geohash dpz2q60xv? I tried reducing the radius to 0.000001 but still get two codes back.
I understand that it's meant for getting the nearby geohashes, but thought reducing the radius to something minuscule would give me only one result.
What I am trying to do is to generate and save a bunch of geohashes based on street addresses (ideally one per address), so that I can then query them based on user's requested radius. So I am trying to also use createGeohashes() to get the one geohash per address but with lower precision as that should be sufficient for my purposes and to your point - would be a little faster.
I checked out your geohashtree package, but I don't think it has a capability to generate geohashes, does it?

ahh i see your problem.  that is my mistake. you will want to use the package dart_geohash which will generate the hash for your address. My package uses this package to generate all hashes in a certain radius to help you search. for example you have two addresses dpz2q60xy6 and dpz2q60xy6 and a user is at 43.6500245, -79.5290709. if you want to find all addresses in a certain radius then createGeohashes will output all geohashes in radius r from that point allowing you to find nerarby addresses.
this is a similar use case that i built out the geohashtree library for. I first input a list of all addresses into the tree iterating through the tree.addLatLng(double lat, double long, V v) which converts the coordinate to a geohash behind the scenes and stores the value v in the tree based on its hash to make queries quicker. then you can search the tree using tree.getGeohashesByProximity() which will return all values in the given proximity. here is the list of api methods. I am happy to add some more examples to the documentation if that makes it clearer.

ahh i see your problem.  that is my mistake. you will want to use the package dart_geohash which will generate the hash for your address. My package uses this package to generate all hashes in a certain radius to help you search. for example you have two addresses dpz2q60xy6 and dpz2q60xy6 and a user is at 43.6500245, -79.5290709. if you want to find all addresses in a certain radius then createGeohashes will output all geohashes in radius r from that point allowing you to find nerarby addresses.
this is a similar use case that i built out the geohashtree library for. I first input a list of all addresses into the tree iterating through the tree.addLatLng(double lat, double long, V v) which converts the coordinate to a geohash behind the scenes and stores the value v in the tree based on its hash to make queries quicker. then you can search the tree using tree.getGeohashesByProximity() which will return all values in the given proximity. here is the list of api methods. I am happy to add some more examples to the documentation if that makes it clearer.

ah I see, sounds like I am trying to create a simplified version of a Geohash tree but in firebase and then query it based on user's preferred radius. So hypothetically, I would have a parent with a 5 digit geohash that would then store the children with 8 digit precision and using createGeohashes would identify which geohashes I need to pull.
I did not understand from the documentation that your geohashtree generates geohashes behind the scenes, I'm going to explore it more to see if I can apply it to my use case.
thanks again!

ah I see, sounds like I am trying to create a simplified version of a Geohash tree but in firebase and then query it based on user's preferred radius. So hypothetically, I would have a parent with a 5 digit geohash that would then store the children with 8 digit precision and using createGeohashes would identify which geohashes I need to pull.
I did not understand from the documentation that your geohashtree generates geohashes behind the scenes, I'm going to explore it more to see if I can apply it to my use case.
thanks again!

@anovis would you consider adding a method  in this package to create a geohash from coordinates or exposing the GeoHash.fromDecimalDegrees as you mentioned you are leveraging dart_geohash?
it would be super handy :)

@anovis would you consider adding a method  in this package to create a geohash from coordinates or exposing the GeoHash.fromDecimalDegrees as you mentioned you are leveraging dart_geohash?
it would be super handy :)

ah in that case you can use the convertToGeohash method. this takes into consideration the Earths curvature, but you can specify x=0,y=0 and the result will the direct output of geoHasher.encode(lon, lat, precision: precision);

ah in that case you can use the convertToGeohash method. this takes into consideration the Earths curvature, but you can specify x=0,y=0 and the result will the direct output of geoHasher.encode(lon, lat, precision: precision);

@anovis this is perfect, thank you so much!

@anovis this is perfect, thank you so much!


CC2538: Better to provide official way to enable logging

For CC2538 example, it will be much helpful for debugging if OpenThread logs can be printed to serial port.

Resolved by #670.


az storage entity merge outputs invalid warning message

Describe the bug
Command Name
az storage entity merge
Errors:
az: error: unrecognized arguments: --auth-mode login

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

az storage entity merge --entity PartitionKey=foo RowKey=bar SomethingElse=whatever --table-name MyTable --account-name MyAccount

Note warning that is output:

No connection string, account key or sas token found, we will query account keys for your storage account. Please try to use --auth-mode login or provide one of the following parameters: connection string, account key or sas token for your storage account.

Try to follow suggestion in warning message:

az storage entity merge --auth-mode login --entity PartitionKey=foo RowKey=bar SomethingElse=whatever --table-name MyTable --account-name MyAccount

Expected Behavior
Either the warning should not be emitted, or the auth-mode parameter should work.
Environment Summary
macOS-10.15.2-x86_64-i386-64bit
Python 3.8.1
Shell: bash

azure-cli 2.0.81

Additional Context

hi @Juliehzl could you pls help to have a look? Thanks.

Additional context: the same thing happens for az storage entity insert and az storage entity delete, I just happened to notice it when running a script that used merge

add to S167.

Ran into this yesterday with az storage blob generate-sas.  Makes it difficult to handle output from the az commands.

I ran into this as well, I had to hack around it and put 2>/dev/null to use the generate-sas subcommand in a script.

Additional context: the same thing happens for az storage entity insert and az storage entity delete, I just happened to notice it when running a script that used merge

Yes. Currently all commands in storage entity may have the same warning message, because there will be a breaking change for such data plane operations. Please provide your credentials as suggested to avoid the message and breaking change in the future.

Ran into this yesterday with az storage blob generate-sas. Makes it difficult to handle output from the az commands.

We are working on a new feature --only-show-errors to provide a way to avoid warning message. But you may lose some useful warning information.
For the warning message, please try to provide credentials as shown in your script, because we may make it required in the future.

Yes. Currently all commands in storage entity may have the same warning message, because there will be a breaking change for such data plane operations. Please provide your credentials as suggested to avoid the message and breaking change in the future.

In Azure DevOps/VSTS: Isn't the Azure Service Principal connection the credential?
Ran into this today with the new warning breaking pipelines with seemingly benign output in sterr. Seems wrong....

Yes. Currently all commands in storage entity may have the same warning message, because there will be a breaking change for such data plane operations. Please provide your credentials as suggested to avoid the message and breaking change in the future.

In Azure DevOps/VSTS: Isn't the Azure Service Principal connection the credential?
Ran into this today with the new warning breaking pipelines with seemingly benign output in sterr. Seems wrong....

You need to specify --auth-mode login to utilize login credentials. and currently we already support --only-show-errors to make sure warning will not show up.

Because there is no response for several days, I will close this issue and if there is any problem, feel free to let me know.

I don't understand why this has been closed.  The problem I reported hasn't changed at all - i.e. az storage entity commands don't support --auth-mode login and output an invalid warning message to do so.  I have updated to 2.3.1 and this hasn't changed.
No connection string, account key or sas token found, we will query account keys for your storage account. Please try to use --auth-mode login or provide one of the following parameters: connection string, account key or sas token for your storage account.
"W/\"datetime'2020-04-20T03%3A38%3A44.3988472Z'\""
 $ az storage entity merge --auth-mode login --entity PartitionKey=foo RowKey=bar other=baz --table-name mytable --account-name myaccount
az: error: unrecognized arguments: --auth-mode login
usage: az [-h] [--verbose] [--debug] [--only-show-errors] [--output {json,jsonc,yaml,yamlc,table,tsv,none}] [--query JMESPATH] {storage} ...```

You need to add --only-show-errors in your command.

I don't think you understand what I am saying.  I have no problem with a warning being shown, but the thing that the warning says is wrong.  The --auth-mode login option doesn't work.

If --auth mode login doesn't work, then I shouldn't get a warning message that says to use it!

If --auth mode login doesn't work, then I shouldn't get a warning message that says to use it!

Currently we only throw warning message for all possible credentials missing scenarios.
And thanks you feedback. We will consider refining the warning message to let users find the suitable way by themselves.

If --auth mode login doesn't work, then I shouldn't get a warning message that says to use it!

Currently we only throw warning message for all possible credentials missing scenarios.

Outputting informational message to stderr is in violation of decades of expected behavior of stderr. Informational messages typically belong in stdout.
If you are not sure how to fix this or authentication is upstream provider out of your control: A wrapper function that will try/catch each auth method and only outputs to stderr if none of the authentication methods were unsuccessful could handle this for you.

--only-show-errors implies only showing errors, no informational output. I (and everyone else) can add this but it is a backwards workaround for a problem that shouldn't exist. This flag really shouldn't exist.

Hi @Juliehzl - This issue should probably be reopened as the problem that was mentioned has not been resolved (unless I'm missing an update). I only ended up finding this issue because of the mentioned error message - only to find out that --auth-mode login is not supported. Having an accurate error message would have saved this investigative time for myself and others.


Feat: Implement Swipe Down Reload Feature for Each Program Screen

Describe the feature
We need to implement a reload feature for each program screen in the Opso app. The reload functionality should allow users to swipe down on any screen to refresh the content, resetting it to the normal state. This feature should be consistent across all open-source programs within the app.
Add ScreenShots
Na
Record

[X] I agree to follow this project's Code of Conduct
[ ] I'm a GSSOC'24 contributor
[ ] I want to work on this issue

Hi @andoriyaprashant !
I would like to work on this issue. Could you please assign it to me?


Callback for matching a time of timer countdown

It would be useful if there is a callback if the timer matches a particular time during countdown timer.

From the docs (view source) :
HTML
<timer countdown="3" interval="1000" finish-callback="callbackTimer.finished()">{{seconds}} second{{secondsS}} </timer>

Inside the controller :
    $scope.callbackTimer = {};
    $scope.callbackTimer.status = 'Running';
    $scope.callbackTimer.callbackCount = 0;
    $scope.callbackTimer.finished = function() {
        $scope.callbackTimer.status = 'COMPLETE!!';
        $scope.callbackTimer.callbackCount++;
        $scope.$apply();
    };

hello buddy!! i have code that is working fine but time is not showing in negative.

Doesnt work

Hello Dear,
I'm not getting you.
On Sat, Sep 24, 2016 at 12:45 AM, gagikmkrtchyan1987 <
<EMAIL_ADDRESS>wrote:

Doesnt work
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/siddii/angular-timer/issues/120#issuecomment-249279080,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASyfRo0VWQB_9dDoJBJIxLq9yO3c3K5cks5qtCVagaJpZM4Ct6Ll
.

Countdown timer ticks slower, multiple timers starting at the same time are showing different results

Dear, I am not getting you.
On Mon, Sep 26, 2016 at 10:23 PM, gagikmkrtchyan1987 <
<EMAIL_ADDRESS>wrote:

Countdown timer ticks slower, multiple timers starting at the same time
are showing different results
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/siddii/angular-timer/issues/120#issuecomment-249628605,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASyfRonXKUHVpkrjHSHijqH3ZuHf9m0tks5qt_iJgaJpZM4Ct6Ll
.

I don't understand you.  (I am not getting you) I tell you that timer doesn't work correctly and you in order to write some advise, are writing ( I am not getting you )


flutter build ios not work

Steps to Reproduce

flutter clean
flutter build ios

I have waited about 30 minutes after building dart code complete
Logs
Building com.xxx.xx for device (ios-release)...
Automatically signing iOS for device deployment using specified development team in Xcode project: PF2VSW7U
Running pod install...                                       1.6s
Starting Xcode build...
├─Building Dart code...                             41.8s

[✓] Flutter (Channel beta, v0.11.3, on Mac OS X 10.14.1 18B75, locale zh-Hans-CN)
• Flutter version 0.11.3 at /Users/l/Sdk/flutter
• Framework revision 72bf075e8d (4 days ago), 2018-11-09 20:36:17 -0800
• Engine revision 5646e86a6f
• Dart version 2.1.0 (build 2.1.0-dev.9.3 9c07fb64c4)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
• Android SDK at /Users/l/Sdk/android-sdk-macosx
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• ANDROID_HOME = /Users/l/Sdk/android-sdk-macosx
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
• All Android licenses accepted.
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 10.1, Build version 10B61
• ios-deploy 2.0.0
• CocoaPods version 1.5.3
[✓] Android Studio (version 3.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 30.0.1
• Dart plugin version 181.5656
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
[!] IntelliJ IDEA Ultimate Edition (version 2018.2.5)
• IntelliJ at /Applications/IntelliJ IDEA.app
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• For information about installing plugins, see
https://flutter.io/intellij-setup/#installing-the-plugins
[✓] Connected device (1 available)
• iPhoneTester • ba8368e53d161a4d2a9c3a5ac5811c2c8f548dc6 • ios • iOS 12.0.1
! Doctor found issues in 2 categories.

me too

me too

如果解决了，给我说下

See #24139

same here

me too

如果解决了，给我说下

flutter build ios --release -v > build.log
运行的时候没有任何输出，去看log已经成功了

Merging with Merging with #24139

same problem here!

me too.
flutter doctor -v
[✓] Flutter (Channel beta, v0.11.3, on Mac OS X 10.14 18A391, locale en-CN)
    • Flutter version 0.11.3 at /Users/atfa/flutter
    • Framework revision 72bf075e8d (7 days ago), 2018-11-09 20:36:17 -0800
    • Engine revision 5646e86a6f
    • Dart version 2.1.0 (build 2.1.0-dev.9.3 9c07fb64c4)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/atfa/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 2.0.0
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 30.0.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] VS Code (version 1.29.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.20.0

[✓] Connected device (1 available)
    • iPhone XR • 6B452F65-C40F-4E54-8205-58B4DEB656DD • ios • iOS 12.1 (simulator)

• No issues found!

Freezing at "flutter build ios"
Building xxx.xxx.xxx for device (ios-release)...
Automatically signing iOS for device deployment using specified development team in Xcode project: XXXXXXXXX
Running pod install...                                       2.0s
Starting Xcode build...
 ├─Building Dart code...                             53.2s

But if I use "flutter build ios --release -v > build.log", After about 30 seconds, it's doen. The last two lines in the build.log are:
[ +504 ms] Built /Users/xxx/AndroidStudioProjects/xxx/build/ios/iphoneos/Runner.app.
[   +1 ms] "flutter ios" took 26,210ms.

Same Here

That fixed. Ensure you have the latest Flutter version.

Thanks. That worked. Sorry.


Tree Shaking Issue with Converter Registration

Hi,
First of all, thank you for this great project!
I have a question regarding the tree shaking capabilities in Dart when using your library. In the initialiseDogs method, all converters are registered as follows:
Future initialiseDogs() async {
  var engine = DogEngine.hasValidInstance ? DogEngine.instance : DogEngine();
  engine.registerAllConverters([gen0.UserConverter()]);
  engine.setSingleton();
}

My understanding is that by registering all converters this way, the Dart optimizer might be unable to tree shake unused dataclasses. Since the converters require the dataclass as a generic parameter, it seems that the dataclass itself will be included in the final build, even if it is unused. This could potentially increase the bundle size.
Could you please clarify if my understanding is correct? Is there any way to ensure that only the used dataclasses and their respective converters are included in the final build, allowing the optimizer to effectively tree shake the unused ones?
Thank you in advance for your response!

Hi,
Sorry for answering this late, for some reason I didn't get a notification for this issue.
Your assumptions about the tree shaking not being applied to generated classes and unused datatypes is currently correct.
Currently all converters are collected and registered for the entire app, one way to possibly solve this issue with the current feature set would be to basically do the tree shaking by hand by effectively initializing the dogs engine without the autogenerated method and only registering the converters you actually want to use.
An other option would be to group types in companion packages, if you do not some types yet, you can just not use / register the package and therefore the converters would get tree shook.
Determining if a converter is going to be used is a bit complicated, especially with how the system is currently designed. The quality of life imports and no part file make it quite hard to find dead converters. When the macro feature gets released, I will try making the project compatible with tree shaking.


Remove QuadMesh and add orientation parameter to PlaneMesh

Closes: https://github.com/godotengine/godot-proposals/issues/4516
Removes QuadMesh in favour of PlaneMesh.
Adds orientation property to PlaneMesh which can be FACE_X, FACE_Y, or FACE_Z. By default PlaneMesh uses FACE_Y. A PlaneMesh with FACE_Z is equivalent to a QuadMesh.
It would be nice if we could automatically convert QuadMeshes to PlaneMeshes either at load time or with the project converter tool. But I could not see an easy way of doing that as this is not a straight 1-to-1 rename. If anyone has any ideas, please let me know.
CC @Qbieshay

It would be nice if we could automatically convert QuadMeshes to PlaneMeshes either at load time or with the project converter tool. But I could not see an easy way of doing that as this is not a straight 1-to-1 rename. If anyone has any ideas, please let me know.

I'd add a compatibility class handler so that existing projects still have some kind of visual representation visible. Otherwise, it'd be transformed into a plain Node.

You have a couple docs to fix too:
ERROR: PlaneMesh.xml: Unrecognized opening tag "QuadMesh" in class "PlaneMesh" description.
ERROR: PrimitiveMesh.xml: Unrecognized opening tag "QuadMesh" in class "PrimitiveMesh" description.

One more:
ERROR: PlaneMesh.xml: Unresolved constant reference "FACE_z" in class "PlaneMesh" description.

Thanks!


Don't try to find compiler version with Clang-cl or MSVC

Clang-cl and MSVC don't provide a way to get the version of the compiler.
I had to move the check for SWIFT_COMPILER_IS_MSVC_LIKE up so its defined when calling print_versions.
I also had to move the initialization of the project up, as CMAKE_C_COMPILER_ID is not set up until calling project

@swift-ci please clean test

@swift-ci please clean test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - ba1b062453cd3cbb0d01e004af134e78c73a24d5
Test requested by - @hughbe

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - ba1b062453cd3cbb0d01e004af134e78c73a24d5
Test requested by - @hughbe

I should not this causes errors configuring Swift on Windows

This is incorrect.  cmake is able to determine the compiler version for both cl and clang.  I don't think that this should be merged.

I'll clarify.
What happens is that we execute ${cmd} --version, where ${cmd} is the path to the C compiler. Clang-cl and MSVC don't recognise the option --version, so report errors, breaking the generation

... see the implementation of find_version here: https://github.com/apple/swift/blob/master/CMakeLists.txt#L294

Example log for Clang-cl:

clang-cl.exe: warning: unknown argument ignored in clang-cl: '--version' [-Wunknown-argument]
clang-cl.exe: error: no input files
CMake Error at CMakeLists.txt:308 (message):
tried to find version for
C:/Users/hughb/Documents/LLVM/build/bin/clang-cl.exe, but
C:/Users/hughb/Documents/LLVM/build/bin/clang-cl.exe not found
Call Stack (most recent call first):
CMakeLists.txt:336 (find_version)
CMakeLists.txt:340 (print_versions)

Example log for MSVC:

cl : Command line warning D9002 : ignoring unknown option '--version'
cl : Command line error D8003 : missing source filename
CMake Error at CMakeLists.txt:308 (message):
tried to find version for C:/Program Files (x86)/Microsoft Visual Studio
14.0/VC/bin/amd64/cl.exe, but C:/Program Files (x86)/Microsoft Visual
Studio 14.0/VC/bin/amd64/cl.exe not found
Call Stack (most recent call first):
CMakeLists.txt:336 (find_version)
CMakeLists.txt:340 (print_versions)

@compnerd any response to my question above?

We shouldn't be using the homegrown version check.

See PR #7260


⚠ Fortnite has degraded performance

In 65d37fe, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1504 ms

Resolved: Fortnite performance has improved in 0980048.


Transfer Ownership

@yungsters would you be willing to make me an admin on this repo?  I've got a number of changes in the works, and I think it would be easiest to maintain long-term if I transfer ownership over to my account.

Hi @dgreif. Let me look into how to do that right now. I agree that it makes sense short- and long-term.

@dgreif I submitted the transfer request.
Also, I noticed this in the README still:

This plugin makes use of the node-somfy-synergy package.

This is no longer the case, right? I don't see it as a dependency of the code.
If you want ownership of that codebase, too, let me know. Otherwise, I'll probably archive that project.

Transfer complete, thank you!
And you are correct, I'm no longer using node-somfy-synergy, so you are welcome to archive that repo. We should probably deprecate the npm package as well. I'll get the readme updated here as well


Can deprecated?

https://www.npmjs.com/package/@nuxtjs/module-test-utils

Done!  (npm propagation might take time to apply message)


[DOC] Error with Binder link

Report incorrect documentation
Location of incorrect documentation
There is an error loading binder in the link provided in the Quickstart section of the readme.
Describe the problems or issues found in the documentation
The error message is Error loading dask-contrib/dask-sql-binder/main! See logs below for details. and the logs show: Could not resolve ref for gh:dask-contrib/dask-sql-binder/main. Double check your URL. GitHub recently changed default branches from "master" to "main". Did you mean the "master" branch?
Steps taken to verify documentation is incorrect
I looked in the repo for where the binder files might live, but didn't find them

Happy to take this on!

I definitely think relocating these notebooks to a more public location where we can continue contributing to it is a great idea - wondering if maybe a better place to relocate these notebooks would be dask-examples? Looking at Dask-ML's binder link, it seems to use the binder generated there with a filepath to specify the notebook to load into.

That seems like a possible options as well. Here's what I have so far:

Move notebooks to Dask-examples and add dask-sql as requirement to dask-examples.
Move notebooks and environment to a new repository or dask-sql itself.
Move notebooks to dask-examples but create environment elsewhere (dask-sql/new repo).

Option 1 looks like the best one so far.


Create a new layout file named dialog_progess.xml

You have to create a new layout file named dialog_progress.xml . It should simply display a progress bar along with a TextView saying "Please Wait..." The background should be black and the Please Wait Text should be white,
Here is an image for reference, note that it does not match with the color scheme I mentioned.

attach a screenshot of the layout while submitting a PR.

Claim

@IEC2021103Abhinav  You already have an issue claimed under this repo, right now I cannot assign it to you.

Claim

@akshatsgh  assigned

@akshatsgh  updates?

Claim

@IEC2021103Abhinav  you already have an active issue in this repo

claim

@zitsav  assigned


Avatars not found

I am trying to get this app running in an Android emulator on Windows 10.  React-native packager reports these errors when navigating to a view that should display avatars, eg Chat. Any ideas on why the avatar images are not found?  I know they are supposed to come from the Realm db and there are no errors populating the initial data.

same problem in mac os and real android device

problem in image (or their format). Change image path on other image (photo1.png as example) in populate methods in dataGenerator fixed this problem


Ensure working dir is GitHub workspace

Sorry about that... I'm working on the github actions workflow to release the different os-specific packages


Make ng2-uploader compatible with AoT compiler

@jkuri
I'm sorry to do yet another PR. I think I'm having issues using GitKraken on this machine.

No problem, thanks for this PR.

published 1.5.6.


Can't use custom start icon

I've tried using .png and .jpg files, but my file selections won't be reflected in the start icon.
I'm using a Samsung Galaxy S9.

same on my huawei t3 10

same here, even tried icons included in an icon pack (Viral)..
anyone have any solutions to this?

Yes same here on LENOVO M10 FHD PLUS

Custom start image is not working. Does any one how to fix this plz


Results url

Url in search results a bit not correct, it gives url like
https://www.imdb.comhttps://www.imdb.com/title/tt0073623/

{
  "type": "Movie",
  "name": "Satsujin ken 2",
  "url": "https://www.imdb.comhttps://www.imdb.com/title/tt0073623/",
  "poster": "https://m.media-amazon.com/images/M/MV5BNjg5N2UyMGYtNGMwNy00OTgzLTk1OTctZTZmZmIwZmQzODI5XkEyXkFqcGdeQXVyNzc5MjA3OA@@._V1_.jpg",
  "description": "Mercenary karate master Tsurugi gets mixed up in a plot by the American mafia to take over the karate dojos in Asia, aided by a corrupt dojo master.",
  "review": {
    "author": "HaemovoreRex",
    "dateCreated": "2007-05-01",
    "inLanguage": "English",
    "heading": "More Chiba mayhem!",
    "reviewBody": "Well, against the ostensible general tide of opinion I must say that I wasn't a particularly huge fan of the original film that this follows. In fact, for me at least, the only saving grace it boasted was in its violent excesses \u0096 the majority of which were saved until the final third of its running time. From reading many of the other reviews on this site, it furthermore seems indicative that the exact said graphic violence is the principle reason that most other reviewers have awarded the flick such lofty marks.\n\nInterestingly and conversely, this sequel actually tones down the blood letting somewhat and apparently as a result didn't hold quite as much appeal it would seem. Well, that's what I'm assuming at least.\n\nFrom my own perspective however, whilst this sequel is indeed bereft of much of the old red stuff a flying, I would say that it actually surpasses the original in pure entertainment value by far. The martial arts sequences are far superior this time around including some rather nifty Kobudo weapons displays throughout. Also Sonny Chiba is on much better form here to \u0096 just check out the awesome sequence near the start of the film in which our protagonist allows himself to be taken to a police station in order to silence a witness. He makes his escape by kicking the bars out through the wall and leaping through the subsequent hole from a few stories up! \n\nAnother scene of amazing note involves our hero punching some poor chap so hard in the back of the head that his eyeballs literally pop out!!! (some great utilisation of ping-pong balls there!) It's also great to see the return of a supposedly deceased character from the first flick who returns here with the intention of exacting his revenge upon our hero.\n\nTo be quite honest, there's only one negative I can think of in this flick and that is the ill advised inclusion of Chiba's 'side-kick' (the first film also suffered the indignity of including one to!) who in this instance is a veritably annoying chick boasting ridiculous looking pig tails and who furthermore, has a rather unfortunate propensity for warbling along to crappy music (badly at that!)\n\nAside from this minor gripe though, overall, this proves to be a tremendously entertaining affair throughout and is well worth tracking down!",
    "reviewRating": {
      "worstRating": 1,
      "bestRating": 10,
      "ratingValue": 8
    }
  },
  "rating": {
    "ratingCount": 2231,
    "bestRating": 10,
    "worstRating": 1,
    "ratingValue": 6.3
  },
  "contentRating": "X",
  "genre": [
    "Action",
    "Crime",
    "Drama"
  ],
  "datePublished": "1974-04-27",
  "keywords": "martial arts action,grindhouse film,exploitation film,psychotronic film,female nudity",
  "duration": "PT1H28M",
  "actor": [
    {
      "name": "Shin'ichi Chiba",
      "url": "https://www.imdb.com/name/nm0002002/"
    },
    {
      "name": "Claude Gagnon",
      "url": "https://www.imdb.com/name/nm0300965/"
    },
    {
      "name": "Y\u00f4ko Ichiji",
      "url": "https://www.imdb.com/name/nm0406706/"
    }
  ],
  "director": [
    {
      "name": "Shigehiro Ozawa",
      "url": "https://www.imdb.com/name/nm0654725/"
    }
  ],
  "creator": [
    {
      "name": "Shigehiro Ozawa",
      "url": "https://www.imdb.com/name/nm0654725/"
    },
    {
      "name": "K\u00f4ji Takada",
      "url": "https://www.imdb.com/name/nm0847026/"
    },
    {
      "name": "Hajime Takaiwa",
      "url": "https://www.imdb.com/name/nm0847244/"
    }
  ]
}

i guess it's imdb.py, line 149 "url": self.baseURL + result.get('url'), issue, need to delete self.baseURL from this line

Actually, IMDB keeps changing its webpage structure with time. These small issues will be mitigated in upcoming update.


modify package.json to support react 15.0.x

Hi, I update some dependencies, especially, react to 15.0.1 and react-dom 15.0.1.
sorry, these no unit test.

no jshint please

please do not change code style also


Is this suitable for an above-average 16 y/o having a computer aptitude?

I want to self-learn CS at a kinda comprehensive level.
I am fluent with the Physics and Maths used here, at least for the CS Into Courses.
I am a bright student and am well experienced with computers.
I am interested in CS, and am not in any doubt regarding it.
My experience in computers come from years of Googling how to do stuff and the gift of  some geeky cousins which built my analytical, like that guy who has been downloading pirated games since he was 6 and would research where it went wrong whenever any of his pirated games didn't work, and then, in the due course of time, learnt about stuff.
We have, in school. been taught Intro Level JAVA.
So, I have a good deal of Computer Experience, but not a lot of CS Experience.
(I know this kinda sounds like I'm a braggart, I'm trying not to make it so, but I kinda suck at writing skills, whoopsie.)

I'm nothing like gifted, but I'm actually at a good level.

It sounds like you have an appropriate background to begin studying the courses in OSSU. And it sounds like you have drive and motivation to tackle the subject. Go for it. And let us know in Gitter how it goes.


"Upgrading npm ... /" is blinking

Hi,
Thanks for the great tool!
I noticed that during upgrade the progress indicator line containing "Upgrading npm ..." text with a spinning symbol (\, |, /) is blinking instantly at quite frequent rate. Although it's a very minor visual bug I don't recall seeing similar spinners blinking in other consoles. (Could be a PowerShell limitation of sort?) So I thought I'll let you know and someone might come up with an easy fix hopefully.
Best,
Igor

Hey Igor! Yeah, that bugs me too - it's probably a Windows bug, but I'd love to find a way to fix it.


Unicode converting from UTF-16 to UTF-32 then failing on JSON.parse

We're storing an object via hset that contains the following unicode character (an emoji) \ud83e\udef6. When we retrieve the value via hgetall we get \U0001faf6 back which is the UTF-32 encoding of the original character. This causes the deserializer to fail.
Is there a reason that these characters are getting converted from different encoding types? And what would be the recommended work around here?
Error we receive back from hgetall:
FetchError: invalid json response body at [URL] reason: Unexpected token U in JSON at position 330

We then fetch the response using /hgetall/ REST API to inspect it - (res.text()) and it's telling us the unicode character was transformed to UTF-32

Perhaps the solution here is to be able to define a custom serializer? I notice we can do that for deserializers.

Hmm, we're not doing anything other than calling JSON.parse when deserializing. I'm not sure what's causing this but I'll try it myself.
Yeah, can you try it without deserialization:
new Redis({
  // ...
  automaticDeserialization: false
})

that will give you the string response straight from redis.
If that also converts the string in to UTF-32, then we'll need to fix it in our redis server.

Thanks,
I will try to debug this asap, but I can't promise you anything until the end of next week.

I've been testing this and it's also happening with ioredis

I'll close this due to inactivity, please reopen if you have more questions

Hey! Sorry for not replying - we ended up solving this by with encodeURI.
Setting - encodeURI(JSON.stringify(VALUE_TO_STORE_IN_REDIS))
Getting -JSON.parse(decodeURI(VALUE_RETREIVED_FROM_REDIS) - this returns the original unicode characters
Thanks for looking into this!

Running into the same issue!
Very easy to reproduce, just run:
➜ SET bugtest 🫠
OK
➜ GET bugtest
Bad escaped character in JSON at position 12

running into the same issue as @cvle, on the backend I replaced upstash/redis with ioredis because setting automaticDeserialization = false did not help. but now on the frontend the issue is the same, but on the frontend I can't use anything other than upstash restapi...
@chronark  do you think there will be an option in the future for the rest api to return un-desirialized (raw) data from redis?


Total number of routes monitored counter

Is your feature request related to a problem? Please describe.
It would be nice to see a number in the stats field showing the actual number of prefixes being monitored.
Describe the solution you'd like
Counter should include the total number of unique routes that are being monitored, so if your using /16^24 it would count all the 24s, not just the supernet.
Describe alternatives you've considered
n/a
Additional context
n/a

@slowr we can get this by imittating the monitoring module functionality, is that correct?
            # only keep super prefixes for monitors
            for prefix in self.prefix_tree.prefixes():
               self.prefixes.add(self.prefix_tree.search_worst(prefix).prefix)

and so on.


Chore: Sync with NextJS repo

What's the purpose of this pull request?
Sync updates made on next js store.

chore: move OrderSummary to FastStore UI
feat: Create Product Details Content component (https://github.com/vtex-sites/nextjs.store/pull/258
fix: using data-fs instead data-store
feat: Adds missing CSS modules

How to test it?
Everything should look visually the same as https://nextjs.vtex.app
Stopped on: Commits on Oct 17, 2022 [To be continued]
Checklist
You may erase this after checking them all ;)
PR Title and Commit Messages

[ ] PR title follows the Conventional Commits specification
[ ] Commit messages follow the Conventional Commits specification

PR Description

[ ] Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
[ ] Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
[ ] Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

[ ] PR description
[ ] Added to/Updated the Storybook - if applicable.
[ ] For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

Thanks for all this amazing work, fan!
All seems to be working fine, I just noticed that the CartToggle is not showing the product counter. I think the counter prop is missing: NextJS CartToggle

Oh my bad. I've fixed here :)
Thanks.


Option to allow friends proxy only https traffic

When granting my friends access to proxy requests through my computer, I would like to have an option to stop any traffic other than HTTPS.
This will inevitably make it impossible for me to sniff my friends' traffic and could work as an alibi to accuses of illegal activities.
Also, it would be useful to configure uProxy blacklist a range of IPs, in order to block friends from accessing my home/corporate network.

Great ideas!
We actually already implement a blocking of all local IPs by default, but the idea to support user-set local addresses makes sense (instead of an all-or-nothing). And we currently lack UI to configure this in the settings; this is tracked here: https://github.com/uProxy/uproxy/issues/361
+1 for an option (for each side) to restrict proxying to only HTTPS.


Fix rare crash on startup when kubernetes initialization occurs before IP address configuration

Previously, a race condition between Kubernetes initialization logic and
the IPAM / address handling / NodeDiscovery logic could cause a crash on
startup in rare circumstances due to the k8s subsystem handling a policy
update event before the initialization was complete.
André pointed out that InitK8sSubsystem() occurs asynchronously to
initialize and begin handling k8s events, and this is initiated prior to
the allocation / initialization of the IP handling subsystem. Looking at
the stacktrace, we see that the "index out of range" error is triggered
from handling a policyAdd event, through the ObjectCache initialization,
through to the headerfile write / nodeconfig fetch logic, through to
logic which would serialize the node IP addressing information into the
node config file, subsequently to be used by other datapath
initialization logic:
panic: runtime error: index out of range [3] with length 0

goroutine 145 [running]:
encoding/binary.bigEndian.Uint32(...)
    /usr/local/go/src/encoding/binary/binary.go:112
github.com/cilium/cilium/pkg/byteorder.HostSliceToNetwork(...)
    /go/src/github.com/cilium/cilium/pkg/byteorder/byteorder.go:134 +0x1ee
github.com/cilium/cilium/pkg/datapath/linux/config.(*HeaderfileWriter).WriteNodeConfig(...)
    /go/src/github.com/cilium/cilium/pkg/datapath/linux/config/config.go:108 +0x5baf
...
github.com/cilium/cilium/pkg/datapath/loader.(*Loader).Reinitialize(...)
    /go/src/github.com/cilium/cilium/pkg/datapath/loader/base.go:187 +0x2c0
github.com/cilium/cilium/daemon/cmd.(*Daemon).policyAdd(...)
    /go/src/github.com/cilium/cilium/daemon/cmd/policy.go:285 +0x1ff7
github.com/cilium/cilium/daemon/cmd.(*PolicyAddEvent).Handle(...)
    /go/src/github.com/cilium/cilium/daemon/cmd/policy.go:217 +0x5c
...
created by github.com/cilium/cilium/pkg/eventqueue.(*EventQueue).Run
    /go/src/github.com/cilium/cilium/pkg/eventqueue/eventqueue.go:240 +0x62

This occurs when converting the IPv4 loopback IP to network byte order,
and the index out of range implies that the IP address is not yet
initialized. The IP loopback address is initialized from
Daemon.allocateIPs() -> node.SetIPv4Loopback(...).
I had initially considered extending EventQueue to allow an
"initialization prerequisite" to be configured in the form of a channel.
This would require the daemon to create a channel for ip initialization
and either pass it down through the stack or pass it via the Daemon
object through to the datapath initialization logic and the endpoint add
logic (including host endpoint add), then into the endpoint EventQueue
initialization routines, which would keep a reference to the channel
around and wait on the close of the channel when EventQueue.Run() is
called. This would ensure that the "wait" is asynchronous, and hence
shouldn't slow down any of the ongoing initialization logic, however
it's a little more invasive than I'd like for a bugfix.
Looking a little closer around this logic, I realized that
loader.Reinitialize() consumes information from NodeDiscovery.
NodeDiscovery is initialized even later than allocateIPs(), and the
NodeDiscovery object has a convenient "Registered" channel which is
closed when the Daemon completes NodeDiscovery initialization. So, if we
wait on that channel, we could ensure all prerequisite IP addressing
information would be initialized prior to datapath generation.
From there, it's just a question of whether this path is guaranteed to
be handled asynchronously or whether there are some other paths that
call Reinitialize() that could potentially end up causing some kind of
deadlock. That does not appear possible upon initial inspection:
  File        Function     Line
0 policy.go   <global>     286 if (err := d.Datapath().Loader().Reinitialize(d.ctx, d, d.mtuConfig.GetDeviceMTU(), d.Datapath(), d.l7Proxy); err != nil {
1 policy.go   <global>     632 if (err := d.Datapath().Loader().Reinitialize(d.ctx, d, d.mtuConfig.GetDeviceMTU(), d.Datapath(), d.l7Proxy); err != nil {
2 loader.go   <global>      34 Reinitialize(ctx context.Context, o BaseProgramOwner, deviceMTU int , iptMgr IptablesManager, p Proxy) error
3 config.go   Handle        90 if (err := d.Datapath().Loader().Reinitialize(d.ctx, d, d.mtuConfig.GetDeviceMTU(), d.Datapath(), d.l8Proxy); err != nil {
4 daemon.go   init         228 if (err := d.Datapath().Loader().Reinitialize(d.ctx, d, d.mtuConfig.GetDeviceMTU(), d.Datapath(), d.l7Proxy); err != nil {
5 daemon.go   func         795 if (err := d.Datapath().Loader().Reinitialize(d.ctx, d, d.mtuConfig.GetDeviceMTU(), d.Datapath(), d.l7Proxy); err != nil {
6 datapath.go Reinitialize 131 func (f *fakeLoader) Reinitialize(ctx context.Context, o datapath.BaseProgramOwner, deviceMTU int , iptMgr datapath.IptablesManager, p
                               datapath.Proxy) error {
7 base.go     Reinitialize 171 func (l *Loader) Reinitialize(ctx context.Context, o datapath.BaseProgramOwner, deviceMTU int , iptMgr datapath.IptablesManager, p
                               datapath.Proxy) error {

policyAdd (From EventQueue)
policyDelete (From EventQueue)
type Loader interface
Daemon /config API (API only served after initialization is complete)
Daemon.init() (Occurs after StartDiscovery()
TriggerReloadWithoutCompile (Triggered from ipcache GC controller)
fakeLoader (unit tests)
Loader (function definition)

So, by blocking on node discovery when fetching LocalConfig(), we are
able to ensure that ip addressing configuration is properly initialized
prior to using it from datapath Reinitialize().
Fixes: #14245
Reported-by: @jorge07

test-me-please

kubeadm: Command not found issue:
https://jenkins.cilium.io/job/Cilium-PR-K8s-1.20-kernel-4.9/85/execution/node/131/log/

retest-4.9


Cache not wotking with BuildKit

Describe the bug
Cache not working when building with DOCKER_BUILDKIT=1
To Reproduce
Steps to reproduce the behavior:

Build an image with BuildKit (put DOCKER_BUILDKIT=1 before build command)
Rebuild an image
An image is building from scratch, the cache is not used.

Expected behavior
An image is building from the cache.
Debug logs
In the logs I can see:

cache is saved in the first iteration
successfully fetched in the second, but image not using that cache.

Runner Environment (please complete the following information):

ubuntu-latest
<EMAIL_ADDRESS>
Additional context
But it works ok with default builder.

Yes, BuildKit uses a different caching system than the default builder. The BuildKit cache doesn't get populated automatically by image loads, instead there are some command line options to enable caching: https://docs.docker.com/engine/reference/commandline/build/#specifying-external-cache-sources.
At the moment this action doesn't support the BuildKit cache, and I don't think those command line options are sufficient to implement this action's workflow. The docs probably need updating to make it clear that BuildKit isn't supported.

Thanks!
I missed that information when reading the docs.
Yes, it would be great if that information will exist in the docs of this action.

Appears it's still not in the docs. I just spent half a day trying to figure out why the cache wasn't working at all for me. :(

Yes, I think the docs need to be updated


No loss.backward()

Dear author! First of all, thanks for your code!
Checked it briefly I didn't found backward pass during training stage, it should be somewhere here https://github.com/aalto-intelligent-robotics/sivl/blob/main/code/trainSimilarityModel.py#L151-L174 I guess. Thanks!

Thank you for showing interest in this work and thank you for highlighting this. You are right, I had accidentally deleted that row when cleaning up code for publishing. Now it should find weights that lead to similar performance as the provided checkpoint.

Dear @jkinnari! Thanks for your answer, clear now!


[Bug] Network traffic is showing as zero

Describe the issue

How to reproduce the issue

Expected behavior

Screenshots

Software versions

Home Assistant version:

Core 2024.7.2
Supervisor 2024.06.2
Operating System 12.4
Frontend 20240710.0

TrueNAS integration version:
v1.3b2

TrueNAS version: TrueNAS-13.0-U6.2

Diagnostics data

Traceback/Error logs

Additional context

home-assistant_truenas_2024-07-15T18-42-28.184Z.log
config_entry-truenas-555d1dedcce422142e41a8785774e4a6.json
home-assistant_truenas_2024-07-15T18-18-00.193Z.log

Problem still exists.

Yep, I recently started using this integration and noticed the same on my Core system.
I dug into it a bit and this commit is what's causing the problem: https://github.com/tomaae/homeassistant-truenas/commit/a59ea1e901fbea72a8769e7d56effcf61585c412
I'm not entirely sure what the intent was with this because afaict this is completely redundant.

@tomaae sorry to ping you, but just wanted to find out exactly what the intent was for the above commit - I can submit a PR to fix it the issue reported here once I have a bit more info.

No problem with a ping.
I'm currently too busy with work and life to dive into github stuff. I will certainly go trough everything, open or closed once I have everything in order, so dont worry about status or github automations.

Looks like the units of measurement are off once fixing the zero response issue.
I changed mine to just grab the raw value from the graph api and set the native unit to UnitOfDataRate.BITS_PER_SECOND (here and here) which seems to be what the raw value is representing, although I couldn't find any documentation verifying this - but my graphs look correct now.
Note this is for TrueNAS core, not sure if there are API differences with Scale.


Add posibility to add custom helm repository

The commit adds the possibility to add a custom helm repository instead of selecting prepared ones
The commit adds new button in preferences - helm section

Warning! Implementation is ugly, need your comments on how to improve it.

@pashevskii Also, please merge current master changes into your branch and resolve conflict in preferences.tsx and keep in mind that our codebase now require stricter lint rules, so you need to set semicolons everywhere at least.
Check out these commands yarn lint and yarn lint:fix.

@pashevskii Also, please merge current master changes into your branch and resolve conflict in preferences.tsx and keep in mind that our codebase now require stricter lint rules, so you need to set semicolons everywhere at least.
Check out these commands yarn lint and yarn lint:fix.

Ok, thank you for your comments, I'll try to fix it today.
Need your opinion about "More + " improvised accordion element, it looks not convenient enough, because you have to click on a small clickable area. Probably I should cover this one with some invisible area which has the same onClick function or replace the element with a button, what do you think about it?

@pashevskii Also, please merge current master changes into your branch and resolve conflict in preferences.tsx and keep in mind that our codebase now require stricter lint rules, so you need to set semicolons everywhere at least.
Check out these commands yarn lint and yarn lint:fix.

Ok, thank you for your comments, I'll try to fix it today.
Need your opinion about "More + " improvised accordion element, it looks not convenient enough, because you have to click on a small clickable area. Probably I should cover this one with some invisible area which has the same onClick function or replace the element with a button, what do you think about it?

Yes, you can wrap text and plus icon within <Button /> component, but not to forget to set primary prop on it.

Fixed, I hope I didn't forget anything

Yes, you can wrap text and plus icon within <Button /> component, but not to forget to set plain prop on it.
I've added the plain button instead of the label and hidden all side effects in CSS (focus on the button).

@pashevskii Left 3 more comments, ptal. Otherwise looks good.


Edit component for superClasses are not preserve order

Related to https://github.com/orientechnologies/orientdb/issues/7460

Issue was fixed in OrientDB 2.2.26. So moving to this issue in https://github.com/OrienteerBAP/Orienteer/commit/7828522994874cf626b35782f6b9d2dba3d70447 fixed the issue.


Find out how to do pre-runs (somehow via coveriteam)

Hey, the deadline for this task has already passed. Is there any update on this issue @AdamZsofi?

This year we are supposed to upload to zenodo and open a merge request with the DOI. No one seems to have done this yet and some things are not clear.
I'll try to get some more information, but otherwise I suggest we wait and try to get everything else ready, so that we can easily upload the tool when needed.

I think, for this year, we will not use the coveriteam service for own preruns. Maybe next year :)


[Resolves #468] Move clean_html import into clean methods

This change allows the HTMLField to be used within a custom user model without causing a LookupError.

Coverage increased (+0.03%) to 78.043% when pulling d980bb96cd3f24c990707b8535a5498d7883ad31 on danielsamuels:patch-1 into bba7d19ccc616b0ee741b1a366f644cb21e80439 on divio:master.

Hello @danielsamuels :wave: I've been bitten a few times by #468 and I've stumbled upon this PR of yours. I'd like to reopen that issue and get it fixed. May I ask why you closed this PR? Was the fix not effective?
Thanks.

Hi @mbi ! Since the htmllib's sanitizer has been deprecated it is time to move to bleach as a sanitizer for djangocms-text-ckeditor. I'd suggest to refactor the imports together with this change. What do you think? Would you be able to support such a PR?

@fsbraun yes, I'll submit a PR as soon as I find a moment...

Since the discussion in #632 might take some time to resolve, does it make sense for now, to move
https://github.com/django-cms/djangocms-text-ckeditor/blob/9ac4c15a2f389c80333025fcb72a59257ae31ffa/djangocms_text_ckeditor/utils.py#L11
from the top of the file into the get_plugins_from_text function - just as the other cms core import in that function?
https://github.com/django-cms/djangocms-text-ckeditor/blob/9ac4c15a2f389c80333025fcb72a59257ae31ffa/djangocms_text_ckeditor/utils.py#L147-L153
I'd assume this would solve the issue?

@fsbraun it absolutely solves the issue, I'm running a fork just to do that. I'll prepare a PR just for this issue, and I'll analyze how hard it'd be to actually test this.

@fsbraun here you go: #636. As mentioned in the PR, I couldn't manage to test this. If a test is strictly required, I'll need help on how to setup a custom user model within django-cms' app_help / testing mechanism. :pray:


What were the hyperparameters for your paper AEN for Targeted Sentiment Classification?

Hello, I'm an undergraduate trying to run the code from your paper "Attentional Encoder Network for Targeted Sentiment Classification", thank you so much for your work, but I am having trouble getting the same results, may I confirm that the hyperparameters are embed_dim = 300, bert_dim = 768, hidden_dim = 300, initializer = 'xavier_normal_' (or is it uniform?), l2reg = e-5, dropout = 0.1, optimizer = 'adam'? Did I miss out some things? Thank you, in advance, for your help!

Please refer to issue #62

Hello, thank you so much for your help, but I am still running into problems running the code. I tried running train k-fold cross validation on AEN-BERT, but somehow the variables context=self.dropout and target=self.dropout in AEN-BERT returns a list of 12 tensors, instead of 1, leading to a type error. It works ok with just train.py though, so I am not sure what to change if I want to use train_k_fold_cross_val.py. Sorry, do you have more advice on how to replicate your results from the paper? Thank you.


remove Chef::Mixin::Command use

we don't use run_command anywhere and this can apparently cause uninitialized
constant issues when knife ssh is invoked via other knife commands (i.e.
bootstrap) where apparently the transitive lazy deps aren't getting
invoked correctly.  there's another bug there, but we do not have any
run_command statements in knife anymore so we should be able to drop
this as a much easier fix.
closes #4546

@chef/client-core pretty trivial -- appveyor failure is unrelated chocolatey failure

:+1:

:+1:


Add support for automated resource detection

This adds support for populating a resource with with Telemetry data
as well as Google Cloud Platform environment metata data.
For #230
Example usage
OpenTelemetry::SDK.configure do |c|
  c.resource = OpenTelemetry::SDK::Resources::AutoDetector.detect
end

Related: https://github.com/open-telemetry/oteps/pull/111

@robertlaurin can you please resolve any out-of-date comments above and rebase? This LGTM and I’ve approved it, but it wasn’t clear to me if you still had unresolved questions. Selfishly, I need this merged for my work on the OTLP exporter 😄 .

@fbogsany I've resolved every I believe to be resolved 😄
There's only two points left that I'd like to leave to some one else to resolve.
I don't think this one is a problem but I raised it just to get a second set of eyes on it.
https://github.com/open-telemetry/opentelemetry-ruby/pull/263#discussion_r425281233
The long message thread here, once again I think this one is good but I'd like to leave it to either you or @mwear to sign off on it.
https://github.com/open-telemetry/opentelemetry-ruby/pull/263#discussion_r430006630
https://github.com/open-telemetry/opentelemetry-ruby/pull/263#discussion_r430013414

LGTM. Needs a rebase, but otherwise 👍


Capatibilty w/ ActiveSupport 6.1.1

Please address at your earliest convenience:
Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    activesupport (= 6.1.1) x86_64-darwin-19

credit_card_validations (= 3.5.1) x86_64-darwin-19 was resolved to
3.5.1, which depends on
      activesupport (<= 6.1, >= 3)

Is there someone maintaining this gem?

Is there someone maintaining this gem?

fixed by https://github.com/didww/credit_card_validations/pull/101

@Fivell - was a new gem version released?  Running:
$ gem search -r credit_card_validations

Still returns:
*** REMOTE GEMS ***

credit_card_validations (3.5.1)

can you release this?

@quaertym  @ninp0  released


Simplify grammar package type constraint on let bindings

/* before */
let thing: (module Thing) = (module MyModule);

/* after */
let thing: Thing = (module MyModule);

Idea: the (module Thing) package type constraint syntax looks very foreign. Since modules are usually associated with an uppercase-cased first letter identifier, the package type constraint syntax can probably be simplified to just using the uppercase-cased first letter identifier (with possible dot for submodules).
The grammar needs to be a little bit restructured to make this work. Currently module types can be lower cased too, (module thing) is legal Ocaml for some reason, resulting in a reduce/reduce conflict.
/* ambiguity */
let thing: foo = (module Thing);
/* is foo a module type or is it a core_type */

By special casing this case to accept uppercase identifiers in the module type case, the grammar could possibly allow parsing of let thing: Thing = (module MyModule); without too much trouble.

I'm kinda suspecting that newcomers would accidentally mistake that type for a variant or something. Happens often enough in other cases

I might have been prematurely excited by finding something that did not lead to a shift/reduce conflict in the current grammar. 😅Yes, it might will be confusing for newcomers. They already have a lot of stuff to learn. It's better to at least parse the "short form" and print the module keyword with refmt.


Chat Panel closes when navigating to the agent tab

When I am on the sayings page with the chat panel open. If I click on the tab that says Agent: Agent Name then the chat panel closes. It makes sense to close it when navigating to the home page, but not certain why it closes in this case.

Closed by https://github.com/samtecspg/articulate/commit/f3f3b02e7ddcbc2dea05f521449f0c42c1196643


inquirer-recursive doesn't work with<EMAIL_ADDRESS>installed by plop

Hey, I just tried plop with inquirer-recursive and each time plop comes to prompt with recursive question it fails with error given below.
I resolved the issue by updating<EMAIL_ADDRESS>to<EMAIL_ADDRESS>At the moment inquirer-recursive works properly and nothing have broke so it's not an issue for me, but some other people may be misguided by https://github.com/amwmedia/plop/blob/master/inquirer-prompts.md.
I will suggest to:

place proper information in documentation that inquirer-recursive may need to upgrade inquirer to newer version
or consider upgrading plop's inquirer dependency
or maybe there is an issue with node 6.5.0 compatibility (this will be an issue for inquirer of course)

plop: 1.7.3
OS: Windows 10
Node: 6.5.0
Receivied error:
[ERROR] inquirer.prompt(...).then is not a function TypeError: inquirer.prompt(...).then is not a function
at Prompt.askForLoop (@project_folder@\node_modules\inquirer-recursive\index.js:27:8)
at Prompt._run (@project_folder@\node_modules\inquirer-recursive\index.js:46:10)
at Prompt.run (@project_folder@\node_modules\inquirer\lib\prompts\base.js:55:8)
at @Roaming_folder@\nvm\v6.5.0\node_modules\plop\node_modules\inquirer\lib\ui\prompt.js:79:45
at tryCatcher (@Roaming_folder@\nvm\v6.5.0\node_modules\plop\node_modules\rx\dist\rx.js:63:31)
at Defer.subscribeCore (@Roaming_folder@\nvm\v6.5.0\node_modules\plop\node_modules\rx\dist\rx.js:2536:37)
at Defer.tryCatcher (@Roaming_folder@\nvm\v6.5.0\node_modules\plop\node_modules\rx\dist\rx.js:63:31)
at setDisposable (@Roaming_folder@\nvm\v6.5.0\node_modules\plop\node_modules\rx\dist\rx.js:2082:46)
at Defer.Rx.ObservableBase.ObservableBase._subscribe (@Roaming_folder@\nvm\v6.5.0\node_modules\plop\node_modules\rx\dist\rx.js:2097:9)
at Defer.Rx.Observable.observableProto.subscribe.observableProto.forEach (@Roaming_folder@\nvm\v6.5.0\node_modules\plop\node_modules\rx\dist\rx.js:2034:19)

That's really strange because plop 1.7.3 depends on inquirer "^1.2.0". So it uses a version of inquirer that runs on promises. I'll do some tests tomorrow on plop's compatibility with this plugin. Any ideas @nathanloisel?

Well I see that I made a mistake...
I haven't checked real plop dependencies^^
After deeper search I found that in my repo<EMAIL_ADDRESS>has dependency on<EMAIL_ADDRESS>while plop actually has a dependency on<EMAIL_ADDRESS>I don't know why but in some strange way npm resolved this conflict with global inquirer package with version 0.12.0 and put<EMAIL_ADDRESS>in node_plop/node_modules, but on require in node_plop resolved with global package...
So now it comes that this is issue with proper package resolving :)

that makes a lot more sense.

Can anyone provide example of use inquirer-recursive in plop?

There is example code on the github readme page


Derive XInput device type exports

Device types which are part of the XDK libraries, should be derived, as they are necessary to use / emulate the XInput APIs.
This is some code I've used in one of my projects:
// The XPP gamepad types are not found by XbSymbolDatabase
// We derive them from GetTypeInformation
//FIXME: If this is NULL, there's another strategy for older XDKs:
//       https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/blob/2e5b9562e0f93af9e475660451c6177ea6dd41c2/src/core/hle/XAPI/Xapi.cpp#L162
write_log("Trying to find XPP device types\n");
assert(GetTypeInformation != NULL);
struct {
  UCHAR xid_devtype;
  void** xdevice_type;
} xdevice_types[] = {
  { XID_DEVTYPE_GAMECONTROLLER, &XDEVICE_TYPE_GAMEPAD }, // 0x00062274 //FIXME: !!!
  { XID_DEVTYPE_KEYBOARD,       &XDEVICE_TYPE_DEBUG_KEYBOARD },
  { XID_DEVTYPE_IRREMOTE,       &XDEVICE_TYPE_IR_REMOTE },
};
//FIXME: There's 2 of GetTypeInformation.. which one does XbSymbolDatabase resolve?
//FIXME: We can just call GetTypeInformation(); ?
for(unsigned int i = 0; i < ARRAY_SIZE(xdevice_types); i++) {
  UCHAR index;
  write_log("Trying XID type %d [table index %u]\n", xdevice_types[i].xid_devtype, i);
  uint32_t* type_information = GetTypeInformation(xdevice_types[i].xid_devtype, &index);
  *xdevice_types[i].xdevice_type = type_information ? type_information[1] : NULL;
  write_log("Set XID type %d to 0x%08X [index: %u]\n", xdevice_types[i].xid_devtype, (uint32_t)*xdevice_types[i].xdevice_type, index);
}

If the xdevice_type is found, we should call the symbol register callback with names like "XDEVICE_TYPE_GAMEPAD".
I'm not sure how to handle custom device types like the Steel Battalion controller.
But I don't know how MS handled them either (are they part of all newer libs, or is it part of the games code?).
Therefore, we probably shouldn't handle custom devices for now.

Closing as incomplete duplicate of #75