Disconnect from session when closing window

Is your feature request related to a problem? Please describe.
Clicking on the close button of the window decoration causes input to freeze i.e. you can't type nor click in the remote desktop and clicking it a few more times will freeze the video or make the screen go black.
Describe the solution you'd like
The close button of the decoration:

should do the same thing as the x button in the floatbar.
Describe alternatives you've considered
The floatbar works fine, but it sometimes gets in the way, specially when running applications in fullscreen mode in the remote desktop. You can also just ^C in the terminal window or even get the pid of the window and killing it, but those are not very practical when running several desktops or the session was simply not started from a cli.
Also logging out from the desktop is not always the best solution, specially when I just need to leave a window but plan to come back later to resume work.

I don´t exactly understand what you are working with (I assume something with fullscreen since you´re talking about floatbar?) and what environment you´re using.
The Close button of xfreerdp is working fine with my local installations, so some more information might help

I'm talking about the close button in the window's decorations. This one:

Nothing happens when I click it, and I expect it to close the window and disconnect the session (updated the OP with an example vid)

@arielnmz ok. mine does.
so could you please add some more information?

If you´re unsure what I mean with more information, see
https://github.com/FreeRDP/FreeRDP/wiki/BugReporting

Shoot, sorry I missed that

@arielnmz ok, found it. +async-input is the culprit.

Thanks! That was indeed the problem. Sorry I don't know where to look for docs on each option available


Change demo so outlet above index page

#minor#

@sglanzer added the 50% split. But had to destroy the Old/New style table when on mobile because the fixed outlet overlaps it.

Approved


logo

@h1alexbel thank you for reporting this. I'll assign someone to take care of it soon.

@h1alexbel this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2023-06-04T10:12:24.152592.
Estimation here is 60 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

@zoeself deregister

@zoeself deregister

@h1alexbel ok, I've removed this task from scope. I'm not managing it anymore.

@h1alexbel in

@l3r8yJ sure, go ahead


Converted the AppModal to a AppPage.

Introducing PageComponent.
Moved components to be rendered into own function.
getInfo function with better default case.
Remove black background from page header.
Implement breadcrumbs for app and tasks.
Removed controls while displaying task details.
Darken the navbar background.
Breadcrumbs with darker background.
Adding hasHealth method to app model.
Rebased version of #1135

That's what I could find for now, other than that it's getting there ;)


How about typescript support?

I think it should be a great feature to library.

I can create a PR for that, would that be ok @zarathustra323 @solocommand?

I can create a PR for that, would that be ok @zarathustra323 @solocommand?

I can create a PR for that, would that be ok @zarathustra323 @solocommand?

@ayrtonvwf Not opposed to this, but what would that look like structurally? So long as it is additive and won't impact anyone not using typescript I think that would probably be welcome.

@solocommand I would create some definition files and include a reference to it on the package.json, with no impact to anyone not using typescript. Glad to hear from you, I'll be submitting a PR in the next few days. Thank you!

Any update for this issue? I hope I can use this lib on TS project soon as possible. Thank you!


JavaScript heap out of memory

Describe the bug
I've been working on an Amplify project (with dev, test, and prod environments successfully deployed). After adding a new model to my graphql schema, I attempted to call amplify push when I received the following error:
UPDATE_COMPLETE amplify-service-dev-175632                 AWS::CloudFormation::Stack Mon Nov 02 2020 12:40:58 GMT-0800 (Pacific Standard Time)
UPDATE_COMPLETE functionserviceAuthenticationCustomMessage AWS::CloudFormation::Stack Mon Nov 02 2020 12:40:58 GMT-0800 (Pacific Standard Time)
UPDATE_COMPLETE authserviceAuthentication                  AWS::CloudFormation::Stack Mon Nov 02 2020 12:40:57 GMT-0800 (Pacific Standard Time)
⠏ Updating resources in the cloud. This may take a few minutes...⠋ Generating GraphQL operations
<--- Last few GCs --->

[1842:0x110008000]   535221 ms: Mark-sweep 8015.9 (8225.1) -> 8008.5 (8228.1) MB, 3621.9 / 0.0 ms  (average mu = 0.114, current mu = 0.007) allocation failure scavenge might not succeed
[1842:0x110008000]   538866 ms: Mark-sweep 8019.5 (8228.1) -> 8012.3 (8231.6) MB, 3620.0 / 0.0 ms  (average mu = 0.063, current mu = 0.007) allocation failure scavenge might not succeed

<--- JS stacktrace --->

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x100bc59ef node::Abort() (.cold.1) [/usr/local/bin/node]
 2: 0x1000815b1 node::FatalError(char const*, char const*) [/usr/local/bin/node]
 3: 0x10008171a node::OnFatalError(char const*, char const*) [/usr/local/bin/node]
 4: 0x100180b89 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/usr/local/bin/node]
 5: 0x100180b33 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/usr/local/bin/node]
 6: 0x1002a0f05 v8::internal::Heap::FatalProcessOutOfMemory(char const*) [/usr/local/bin/node]
 7: 0x1002a2268 v8::internal::Heap::MarkCompactPrologue() [/usr/local/bin/node]
 8: 0x10029fc4f v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/usr/local/bin/node]
 9: 0x10029e41a v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/usr/local/bin/node]
10: 0x1002a63dc v8::internal::Heap::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/usr/local/bin/node]
11: 0x1002a6432 v8::internal::Heap::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/usr/local/bin/node]
12: 0x100284350 v8::internal::Factory::AllocateRawArray(int, v8::internal::AllocationType) [/usr/local/bin/node]
13: 0x100283090 v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::RootIndex, int, v8::internal::Object, v8::internal::AllocationType) [/usr/local/bin/node]
14: 0x1004390a9 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet, 1>::Allocate(v8::internal::Isolate*, int, v8::internal::AllocationType) [/usr/local/bin/node]
15: 0x1003fe740 v8::internal::KeyAccumulator::AddKey(v8::internal::Handle<v8::internal::Object>, v8::internal::AddKeyConversion) [/usr/local/bin/node]
16: 0x1003fe995 v8::internal::KeyAccumulator::AddKeys(v8::internal::Handle<v8::internal::FixedArray>, v8::internal::AddKeyConversion) [/usr/local/bin/node]
17: 0x1004011d9 v8::internal::KeyAccumulator::CollectOwnPropertyNames(v8::internal::Handle<v8::internal::JSReceiver>, v8::internal::Handle<v8::internal::JSObject>) [/usr/local/bin/node]
18: 0x1003ff84b v8::internal::KeyAccumulator::CollectOwnKeys(v8::internal::Handle<v8::internal::JSReceiver>, v8::internal::Handle<v8::internal::JSObject>) [/usr/local/bin/node]
19: 0x1003fed81 v8::internal::KeyAccumulator::CollectKeys(v8::internal::Handle<v8::internal::JSReceiver>, v8::internal::Handle<v8::internal::JSReceiver>) [/usr/local/bin/node]
20: 0x100400441 v8::internal::FastKeyAccumulator::GetKeysSlow(v8::internal::GetKeysConversion) [/usr/local/bin/node]
21: 0x1003fe4d6 v8::internal::FastKeyAccumulator::GetKeys(v8::internal::GetKeysConversion) [/usr/local/bin/node]
22: 0x1004de714 v8::internal::Runtime_ForInEnumerate(int, unsigned long*, v8::internal::Isolate*) [/usr/local/bin/node]
23: 0x100750199 Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_NoBuiltinExit [/usr/local/bin/node]
zsh: abort      amplify push

I've tried the following to resolve the issue:

Updated my react start and build scripts to "start": "react-scripts --max_old_space_size=8192 start" and "build": "react-scripts --max_old_space_size=8192 build", respectively; and

Added a local environmental variable: NODE_OPTIONS="--max_old_space_size=8192"

I'm wondering if this can only be an issue with my local environment; or whether the failure is happening remotely?
Amplify CLI Version
4.29.2
To Reproduce
Added new object to graphql schema, called amplify push from terminal.
Expected behavior
I expected the push to complete without error, as is typical.
Screenshots
N/A
Desktop (please complete the following information):

OS: MacOS Catalina 10.15.6
Node Version 14.2.0

Brain flatulence. Was a schema issue that caused the error. Closing the issue.


Speedup with unique?

https://github.com/edwardbair/SPIRES/blob/c54df3974011b782e3bd541298de913d61fb5a66/run_spires.m#L89
Looking into a speedup here using unique per your suggestion, but I'm getting hung up because 1) there's no option for "OutputAllIndices" for IA ; 2) GPU acceleration doesn't work for OutputAllIndices or ByRows.
uniquetol is a built-in black box, but the source for unique is viewable. Maybe it can be modified to do what we need?

Using the snippet below, I get a speedup, but it's not huge,
Elapsed time is 5.901718 seconds.
Elapsed time is 8.245689 seconds.
`uniquetolval=5;
N=1e7;
vals=repmat([30 50 90; 31 51 91; 32 52 92; 33 53 93],N,1);
%% unique approach
tic;
uvals=round(vals/uniquetolval)*uniquetolval;
[u,ia1]=unique(uvals,'rows');
[~,ia2]=unique(uvals,'rows','last');
ia=cell(size(ia1,1),1);
for i=1:length(ia1)
ia{i}=ia1(i):ia2(i);
end
toc
%uniquetol approach
uniquetolval2=uniquetolval-1; %lower thresh b.c. uniquetol treats vals that are equal to tolerance as equivalent
tic
[ut,iat]=uniquetol(uvals,uniquetolval2,'ByRows',true,...
'DataScale',1,'OutputAllIndices',true);
toc`

Hmmm. Seem that keeping track of the index of each element that is unique adds a lot of overhead. Check your ia variable at the end, I dont think it actually has the correct indices within it. there are lots of duplicate indices in each cell.
I think you want something like this: (see the time diff between unique and uniquetol, that is where the speed is, but doesnt matter for us)
I think the big speed up via unique would be in the ability to search across an entire year or all years of a tile for unique rows via MATLAB tall arrays, which are compatible with unique, ismember, and find, but not uniquetol.
https://www.mathworks.com/help/matlab/tall-arrays.html
https://www.mathworks.com/help/matlab/import_export/develop-custom-tall-array-algorithms.html
%% unique approach
tic;
uvals=round(vals/uniquetolval)*uniquetolval;
u=unique(uvals,'rows');
toc
numUnique=size(u,1);
tic
for i=1:numUnique
ia{i}=find(ismember(uvals,u(i,:),'rows'));
end
toc

I see what you mean about the ida issue. Your approach is good, but I can't get it to run any faster and I get an extra row of unique values not produced by uniquetol (which has the correct answer). I also tried compiling as a MEX function, but it ran a little slower. Using gpuArrays seemed to cause excessive overhead, but I'm new to that, so I probably missed something.
uniquetolval=5;
N=1e6;
vals=repmat([23 50 90; 31 51 91; 32 52 92; 33 53 93; 34 54 94],N,1);
%% timbos approach
tic;
uvals=round(vals/uniquetolval)*uniquetolval;
[u0,ia0]=unique(uvals,'rows');
numUnique=size(u0,1);
u=vals(ia0,:);
ia=cell(numUnique,1);
for i=1:numUnique
ia{i}=find(ismember(uvals,u0(i,:),'rows'));
end
fprintf('timbos approach %g sec\n',toc)
%% uniquetol approach
tic
[ut,iat]=uniquetol(vals,uniquetolval,'ByRows',true,...
'DataScale',1,'OutputAllIndices',true);
fprintf('uniquetol approach %g sec\n',toc)

@DozierJeff Thanks for weighing in. I copied your email below. Right now, uniquetol is taking almost as long as the unmixing. I think we can really speed this up, but maybe it’s not with the unique /uniquetol functions?
——————-
On my machine (Lenovo, several years old) running MATLAB 2021a, uniquetol takes 2.6 sec, Timbo’s takes 4.6. When I ran it again, times were 1.9 and 4.0 sec (maybe some compiling took place, or maybe I didn’t move: some stuff I read about timing says, laptop on hard surface, plugged in, don’t touch).
That uniquetol doesn’t show the code might mean it’s coded in C.
Generally, I view speeds within a factor of 2 to be close enough.

@DozierJeff copied you e-mail in below.
for superpixels a few things:
the matlab built in superpixel function can only handle 1 or 3 features per pixel for clustering, my method enables as many features as you want, but is slow. The built is superpixels funciton is a MEX file and runs very fast. I was doing some superpixel stuff with both funcitons yesterday on Landsat images and the results are pretty dang similar. For speed, I recommend we use the matlab function.  also there is a superpixels3 (3D superpixels) funciton - we could stack a few days together and find similar pixels across multiple days - probably just a few a most.
The trick with using superpixels and MODIS data is the spatial resolution of MOD09GA is quite coarse so we don't want to make the superpixels too big.  I'm guessing our fSCA estimates from MODIS super pixels are going to be similar to the aggregate of the fSCA estimate from the individual pixels. But, unless all the component pixels have high fSCA we may be reducing our ability to estimate grain size and contaminat conc, by the superpixels fSCA going below the thresholds to estimate those snow properties.  We'd need a quick way to find good pixels/superpixels for estimating those properties.
also, we have plenty of time. We could create a large training library of unique pixels form many tiles and days with the current "slow" combo of uniquetol + speedinvert, then train the ML and for future "fast" runs, run the statistical fit / ML approach on all pixels, which could be fast enough to just use ML on all pixels.
@edwardbair - for GPU arrays, once Aaron gets MATLAB 2021a fired up on tlun, speed might improve with the new updates to matlab handling the new NVIDIA cards.

Let’s take a step back. The problem is: unmixing every pixel takes too much time, but many pixels are similar to other pixels, so we shouldn’t have to unmix all. Rosenthal & Dozier 1996 realized this, and Walter built a regression tree based on a sample of pixels.
I’d suggest we combine the ideas with superpixels. For a typical AVIRS-NG image, I have various ways to create a 3-band image that superpixel can handle, and Timbo has identified other ways. David Thompson’s Mars stuff just used a one-band image, the brightness (Euclidean norm) of the spectral reflectance. Depending on options, I get something like 65,000 superpixels, but running uniquetol on these at a tolerance of 0.05 for the weighted spectra, I reduce to 2500-3000, which I can unmix on my laptop.
Then the question is, what to do with ‘em? One approach is to say there are only 2500 answers and for each pixel pick the closest superpixel and assign that fSCA and albedo to it. An alternative is to assert that the superpixels span the range of variability and to use a statistical fit (“machine learning”) to assign the snow properties to each pixel.
Thoughts? This topic applies to other retrievals besides snow.
Jeff

“Life is really simple, but we insist on making it complicated.” – Confucius
The problem is: can we speed up SPIReS? Machine learning, LUTs, GPU arrays, and other speed ups are good research directions, but I have yet to see any evidence that they work better or faster than simpler methods for clustering.  Down the road, with the right fast clustering algorithm, I think we'll be able to apply a look up table answer to each scene and skip the iterative solving, but we are not there yet. I'll note that I wasn't able to do that  two years ago either, but I'm hoping sometime smarter than I am will be able to (i.e., on this thread).
For now, I don't agree that unmixing takes too much time since it can be efficiently parallelized. Right now, the bottleneck is uniquetol, which cannot be run in parallel, so that's what I've focused on. Below is a summing approach below that builds on Timbo's code. Note that an extra unique row is produced by Timbo's approach and the summing approach. I believe all three are producing correct answers, but uniquetol works differently in that it tests each cell in a row to be within a tolerance, whereas Timbo's approach and the summing approach examine the entire row.

uTest
timbos approach 23.087 sec
summing approach 5.4753 sec
uniquetol approach 11.7493 sec

uniquetolval=5;
N=1e7;
u0=[23 50 90; 31 51 91; 32 52 92; 33 53 93; 34 54 94];
vals=repmat(u0,N,1);
%% timbos approach
tic;
uvals=round(vals/uniquetolval)*uniquetolval;
[u_,ia_]=unique(uvals,'rows');
numUnique=size(u_,1);
u=vals(ia_,:);
ia=cell(numUnique,1);
for i=1:numUnique
ia{i}=find(ismember(uvals,u_(i,:),'rows'));
end
fprintf('timbos approach %g sec\n',toc)
%% summing approach
tic;
sv=sum(vals,2);
uvals=round(sv/uniquetolval)*uniquetolval;
[u_,ia_]=unique(uvals);
u=vals(ia_,:);
ia=cell(size(ia_));
for i=1:size(u_,1)
ia{i}=find(u_(i)==uvals);
end
fprintf('summing approach %g sec\n',toc)
%% uniquetol approach
tic
[u,ia]=uniquetol(vals,uniquetolval,'ByRows',true,...
'DataScale',1,'OutputAllIndices',true);
fprintf('uniquetol approach %g sec\n',toc)

Here's a final note.
I wrote speedyUniqueTol and implemented it in run_spires only to find that the summing approach produces too few filtered rows. In other words, many rows sum to the same value within a tolerance. The uniquetol approach finds the spectra we are looking for since it examines each cell separately. The ismember(...,'rows') approach seems to produce the same result as summing the rows and is too slow. Using uniquetol with tlun I was able to run the entire Sierra 20 year record overnight so this may be a case where the hardware improvements dwarf our attempts at code improvements.


Stop depending on the JCenter

jFrog announced the end of JCenter service.
Currently our build script depends on JCenter to download Trove4J, so we need to find alternative solution.
https://github.com/spotbugs/spotbugs-gradle-plugin/blob/37bb2bc2eabd98fc6506dd22c24e563df06d91b3/build.gradle#L21-L22

Coming releases for android gradle plugin could be solution for this problem.
https://www.reddit.com/r/androiddev/comments/lbssfn/now_that_bintray_and_jcenter_are_shutting_down/glww2jk?utm_source=share&utm_medium=web2x&context=3

Which version of trove4j is it using? Maven central has https://search.maven.org/search?q=g:net.sf.trove4j


Dino catalog

Hey Joe,
So I think I got an MVP for this exercise, but it's in some desperate need for refactoring and some things I wanted to get some clarification on. I wanted to get your input before moving forward with any revisions. A couple of sticking points:

parsing both files at one time and compiling the data into one directory
not returning nil data
I formatting for the return values outside of using ARGV

Let me know what you think and thanks again!!

Cool, it's a good start. The biggest thing to focus on here is separation of concerns. When reading this, mostly in my head I'm wondering whether a given class should own some piece of functionality. Examples:

The Dino class right now needs to know about the exact structure of the CSVs. So if we added another CSV, or a JSON input, or consumed a webservice, we'd have to change the Dino class. Does this make sense to do?
Should Directory own the responsibility of outputting dinosaurs? It's good that you're returning a string, as opposed to doing puts, but even still I'm not sure that a Directory should know this kind of stuff.

One possible refactor is to just add a to_s to Dino, but I'm not sure Dino should own it either! One approach that might be better is to provide a to_h method on Dino, then have the consumer of those string representations (usually a runner, in this case just some ruby) deal with formatting.

Should Directory know what the weight threshold for big dinosaurs is? Weight doesn't have an obvious unit of measure, which doubles down on the trouble. It's probable that Dino should have a predicate method #big?.

On the loading question: It's totally okay that you load the two files sequentially, and I like that the parser is separated out. To load the catalog progressively, probably create a #add(dinos) to the Directory, then use it for each file. Since it's just an array of Dino objects, it shouldn't be too bad.
Also, fix yer tabs. ;)
Looking forward to the next iteration.


Icon request: Digitec Galaxus

The company name is Digitec Galaxus, they own both websites.
login to access both is the same.

URL of the site or app (required): https://www.digitec.ch/ , https://www.galaxus.ch/
Logo resources for the icon (optional, but recommended):

Here you go!
https://github.com/aegis-icons/aegis-icons/blob/master/SVG/Digitec Galaxus.svg
❓ How to add icon(s) to Aegis?


[Storage Blob Service] Get Account Information Support in storage SDK

https://docs.microsoft.com/en-us/rest/api/storageservices/get-account-information

done


Cannot add a attachments as popup "Choose an action" is empty

Checklist

[X] I have used the search function to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

App version
6.603
Where did you get the app from?
F-Droid
Android version
12
Device model
Onyx Tab Ultra C Pro
Steps to reproduce

Stat writing a message
Click on attach icon

Expected behavior
You can attach a file.
Actual behavior
A popup opens, which shows "Choose an action" title, but nothing can be selected / chosen. Only possible action is clicking on big X in the corner.
Might be related to #7423.

Do note that:

K-9 is running from the Work profile
Work profile was created using Shelter
K-9 was installed in the Private profile and copied to Work profile via Shelter
The same issue happens either when composing a new or replying to an existing email

Logs
No response

Does the app work as expected in the personal profile? If so, it's probably a problem with how the work profile is configured. It doesn't seem to be a general Shelter problem. Because it works fine for me.
If the problem is also present in the personal profile, it's most likely a problem with the Android version on your device. In that case, please contact the vendor (or developer of the custom ROM, if you're using one).

It works as expected in the personal profile. Clicking on the attach icon brings up file picker.

I've tried uploading a file from another app (Slack) and it works as expected.

It works as expected in the personal profile. Clicking on the attach icon brings up file picker.

In that case it's probably a Shelter configuration issue. Please contact the author of that app.


API call to get symbol output count

MXNet Symbol.getitem using list_outputs() is too expensive, when it only cares about the output count in most cases.
Dependency of: https://github.com/apache/incubator-mxnet/pull/8989
Showing up as a hot spot:

Seems there is some CI issues, could have things to do with old tvm version in your commit, consider update tvm?

seems up to date...

fixed


[22.11] aaxtomp3: init at 1.3

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/aaxtomp3-only-looks-available/25407/6

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1821

Build is failing on all platforms according to ofborg, please check.

Unfortunately NixOS 22.11 has reached its end-of-life status on 2023-06-30, one month after the release of NixOS 23.05.
I'm closing this pull request, since we do not accept any changes to its branches anymore.


Changing display colors still does not hold the new choice or show it

This issue, originally brought up as Issue #21, was projected to be resolved in v.5. It does not seem to have been.

still working on it

as stated in my slack note, most of this seems to be done.
However, the star preferences are not complete. I am creating a ticket for that and adding to the v0.5.3 milestone


Cache data limits to ensure they are only computed once per update

Resolves #5389

Should we remove that in favor of beforeLayout?
https://github.com/chartjs/Chart.js/blob/988b3c5d2b6f91d839e2f7c9329ade42c5ba8f32/src/scales/scale.time.js#L252

We could. I wonder if we have tests covering that clearing

I removed the invalidateCaches step and everything passed. I think it should be safe as the caches were invalidated during updates.


Forge Coverage Exclude Scripts, Tests and Optional Library Exclusion

Component
Forge
Describe the feature you would like
forge 0.2.0 (7b45265 2023-11-21T00:22:00.899582254Z)
currently forge coverage includes .s.sol and at times even .t.sol in the coverage report which should not be happening since it is not a part of the contract that's being tested which is usually in src/ or in contracts/ or src/contracts/ when using a hardhat-foundry hybrid project. This is causing a problem including and not limited to when looking at the debug summary generating more information than necessary.
an optional exclusion for libraries should also be included since some functions in a library wont be used and some branches, statements and lines won't ever be hit since the code is written to prevent hitting those conditions.
this would make it easier  to debug contracts and add more tests that should be added without any unnecessary data being added
Additional context
No response

Marking as resolved by https://github.com/foundry-rs/foundry/pull/8321


Peering event stream

Allows connecting to wscat -c http://localhost:5000/peer-management (cloud) and getting messages like:
  < {"topic":"_peer/disconnect","timestamp":1422563336669,"data":{"id":"detroit","connectionId":"9d6c596b-c25d-48d7-9791-5651f811d72a"}}
  < {"topic":"_peer/connect","timestamp":1422563337670,"data":{"id":"detroit","connectionId":"fa36b150-7fc6-4f10-8f41-6129113dc6f8"}}
  < {"topic":"_peer/disconnect","timestamp":1422563338089,"data":{"id":"detroit","connectionId":"fa36b150-7fc6-4f10-8f41-6129113dc6f8"}}

Or from the hub side:  wscat -c ws://localhost:5002/peer-management
connected (press CTRL+C to quit)
  < {"topic":"_peer/disconnect","timestamp":1422563409746,"data":{"url":"ws://localhost:5000/peers/detroit","connectionId":"356c1a66-e5e2-4b9d-91c1-7c2bf73f357b"}}
  < {"topic":"_peer/connect","timestamp":1422563413943,"data":{"url":"ws://localhost:5000/peers/detroit","connectionId":"44f45194-e463-4b2e-8ec2-f4f88cd263e2"}}

Looks good. Is it possible to put the url in the cloud side messages? That may be a bit weird for a client consumer. If it's not easy then feel free to merge.

Which url are you expecting?

ws://localhost:5000/peers/detroit
--
Matthew Dobson | apigee https://apigee.com/ | m: +1.734.634.5472 |
twitter @mdobs http://twitter.com/mdobs @apigee
https://twitter.com/apigee
On Thu, Jan 29, 2015 at 4:16 PM, Adam Magaluk<EMAIL_ADDRESS>wrote:

Which url are you expecting?
—
Reply to this email directly or view it on GitHub
https://github.com/zettajs/zetta/pull/135#issuecomment-72105682.

Yeah i think so.

@mdobson I can file a different issue for that, more complicated than I thought.


api: add comments on fields for reference docs

Fixes https://github.com/cilium/tetragon/issues/957.
This PR includes no functional changes. Only comments for autogenerated documentation.
I need your help with a few fields.

Thanks @willfindlay, I added some of your API changes suggestion there https://github.com/cilium/tetragon/issues/486#issuecomment-1431019714.

Check failure is related to dependabot.yaml config format fails and I have an open PR to fix that. Let's merge this.


Update kustomize to v5.0.3

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Update kustomize to the latest patch release.
Which issue(s) this PR fixes:

None
Does this PR have test?
None

Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

Codecov Report

Merging #1677 (a3a4f71) into main (f9d8a7c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1677   +/-   ##
=======================================
  Coverage   49.34%   49.34%
=======================================
  Files          71       71
  Lines        6929     6929
=======================================
  Hits         3419     3419
  Misses       3380     3380
  Partials      130      130


Kill the browsermob-process on Windows

On Mac/Ubuntu everything work fine, but on Windows, when you collect the data, the process never exit, guess it is the killing of the BrowserMobProxy that don't work (if you run without BMP, the process exit fine). If I run without BrowserMobProxy it works fine but if I turn it on it hangs and I need to control+c to exit:

C:\Users\peter\Documents\GitHub\browsertime> node .\bin\browsertime.js -u http://www.sitespeed.io -b chrome -n 1
info: Fetching http://www.sitespeed.io (1 of 1)
info: Storing C:\Users\peter\Documents\GitHub\browsertime\www.sitespeed.io.har
info: Storing C:\Users\peter\Documents\GitHub\browsertime\www.sitespeed.io.json
info: Stopping proxy
---> here it hangs

What happens is that we spawn a Java process that starts the BrowserMobProxy, on Mac/Ubuntu it works fine killing it, but not on Windows. The code is here (check row 98): https://github.com/tobli/browsertime/blob/master/lib/proxy/mobproxy.js
Any ideas are welcome :)

maybe we could use something like this: https://www.npmjs.com/package/ms-task

this is fixed & released


Error Disallowed checkout type, the project must be checked out over one of the supported schemes: SSH

I got the following error adding a repo:

Couldn't add Xcode project at path file:///Users/mxbot/myproject/myproject.xcworkspace, error: Cannot find the Checkout/Blueprint file and failed to parse repository metadata directly. Please create an issue on GitHub with anonymized information about your repository. (Error Disallowed checkout type, the project must be checked out over one of the supported schemes: SSH).

Although the repo was clone using SSH I followed the workaround steps creating the blueprint file but I still get the same error.
Is it possible to get more detail about what is producing the error?
The blueprint file added looks like (anonymised):
{
   "DVTSourceControlWorkspaceBlueprintPrimaryRemoteRepositoryKey":"FF6F1F3CB80AF41215B17903BEEF908A02B36D30",
   "DVTSourceControlWorkspaceBlueprintWorkingCopyRepositoryLocationsKey":{

   },
   "DVTSourceControlWorkspaceBlueprintWorkingCopyStatesKey":{
      "FF6F1F3CB80AF41215B17903BEEF908A02B36D30":0
   },
   "DVTSourceControlWorkspaceBlueprintIdentifierKey":"A07FFC0C-8CE7-4944-8C3F-4CADC5C97122",
   "DVTSourceControlWorkspaceBlueprintWorkingCopyPathsKey":{
      "FF6F1F3CB80AF41215B17903BEEF908A02B36D30":"myproject/"
   },
   "DVTSourceControlWorkspaceBlueprintNameKey":"myproject"
   "DVTSourceControlWorkspaceBlueprintVersion":204,
   "DVTSourceControlWorkspaceBlueprintRelativePathToProjectKey":"myproject.xcworkspace",
   "DVTSourceControlWorkspaceBlueprintRemoteRepositoriesKey":[
      {
         "DVTSourceControlWorkspaceBlueprintRemoteRepositoryURLKey":"git@github.mycompany.com:myorg/myproject.git",
         "DVTSourceControlWorkspaceBlueprintRemoteRepositorySystemKey":"com.apple.dt.Xcode.sourcecontrol.Git",
         "DVTSourceControlWorkspaceBlueprintRemoteRepositoryIdentifierKey":"FF6F1F3CB80AF41215B17903BEEF908A02B36D30"
      }
   ]
}

Thanks for your work!

Hi @nextorlg,
first of all, great issue report! That's all I need to be helpful here.
I can see from your blueprint that your repo URL is git@github.mycompany.com:myorg/myproject.git, which implies you're using GitHub Enterprise, instead of GitHub.com, correct?
If so, technically Buildasaur doesn't yet support Github Enterprise servers, but there are a couple of people working on it (and have their forks), see this issue with links: #99. There's even a WIP pull request: #251.
Hope this helps. As I don't have an Enterprise server myself, I can't get the support in myself, so I'm relying on contributors. It might be worth to try to chat to them directly.

Possibly related to #259.

Yup looks related to the github enterprise instance. Our setup is not standard, I will check the issues as PRs you referenced and see if I can be of some help

As we don't technically yet support GitHub Enterprise yet, I'll close this. If you're using a fork of Buildasuar, it's probably best to open a ticket in the fork's issues section and later try to ask them to PR the improved version into main Buildasaur. Unfortunately I cannot help with forked code as I don't know what's been changed.


add Susono network

based on #179

using Avalance subnet this is the reason the addresses are not deployed deteriminalisitc deployment, if that is an issue I would redeploy them as requested

using Avalance subnet this is the reason the addresses are not deployed deteriminalisitc deployment, if that is an issue I would redeploy them as requested

please do, this package is a collection of deterministic deployments

using Avalance subnet this is the reason the addresses are not deployed deteriminalisitc deployment, if that is an issue I would redeploy them as requested

please do, this package is a collection of deterministic deployments

could you please provide me with a little info or give me some leads as of how can I do that with network that have replay protection?

using Avalance subnet this is the reason the addresses are not deployed deteriminalisitc deployment, if that is an issue I would redeploy them as requested

please do, this package is a collection of deterministic deployments

could you please provide me with a little info or give me some leads as of how can I do that with network that have replay protection?

https://github.com/safe-global/safe-contracts#replay-protection-eip-155

I'm closing this issue due to inactivity


examples/audio.go not working with Go 1.5, Windows 8.1

I built and ran examples/audio.go, but all I hear is a barely perceptible faint click when it starts.  Has anyone else gotten it to work recently?  Any advice on how to debug it?

Yep, I don't hear anything either.
Adding
if err := sdl.Init(sdl.INIT_AUDIO); err != nil {
	log.Println(err)
	return
}

to the beginning of main() seems to fix it. Please confirm.

There's no log:
$ go run audio.go
# command-line-arguments
.\audio.go:38: undefined: log in log.Println

I tried inserting:
if err := sdl.Init(sdl.INIT_AUDIO); err != nil {
    panic(err)
    return
}

but I'm still just getting the faint click.

So... did you resolve your problem?

Oops.  I accidentally hit the "Close and comment" button instead of "Comment".
I have not been able to resolve the problem with the audio.go example.  However, in my "real" code, the sound is working fine and I'm not sure what I did differently.

ahaha. Well I have made a pull-request #154  that fixes the problem for at-least me. Maybe you could check if that works for you.

Yes, that fixed it.  Indeed I wish I had turned down the volume before trying it :-).


Multiplayer Not Working (For Me) on 1.24.0

Hello!
ive been tryng to fix this problem since i got bmbf, and multiplayer doesnt work, what happens is it just keeps trying to connect and it wont stop saying "connecting" is there a fix for that? if so please tell me
Thanks!
-Skull

We do not support this version anymore. Upgrade to 1.25.1.


Fixed incorrect parameters to runFile

The --load option was not working due to the fact that the parameters used are incorrect. Updated parameters passed to runFile to match signature.

OK, have now signed Contributor License Agreement.


Importing the sources from ETE

The user sets a certain percentage of heat-network use in the ETM:

and

Now, the use must specify how the number of heat exchangers (connections to the heat network) are coupled to buffers.

Next the user chooses how the heat net is supplied:

Note that the heat network can also be supplied with heat from excesses in agriculture, industry and central production!

When the user opens the (scaled) ETM scenario in ETMoses, the number of connections is imported as a number of heat-exchangers for space heating and a(nother) number for hot water.

The following technologies need to be imported:

households_collective_chp_network_gas
households_collective_chp_wood_pellets
households_collective_chp_biogas
households_collective_geothermal
households_heat_network_connection_steam_hot_water (excess heat/must-run)
households_heat_network_connection_steam_hot_water (dispatchable)

The subdivision of the latter category (the central heat network) is needed as there are many technologies feeding the central network, some of them must-run (from a heat perspective meaning that they primarily produce electricity and have heat as a by-product), others dispatchable (dedicated to follow the heating demand).
I propose to give a flat production profile to the "excess heat/must-run" category. In principle, we can do better because we know the hourly profiles from Merit and could make a weighted average curve but this will be a lot of work with little payoff IMO.

Also, the buildings can be heated with a heat-network so the following additional converters need to be imported:

buildings_collective_chp_network_gas
buildings_collective_chp_wood_pellets
buildings_collective_geothermal
buildings_chp_engine_biogas

What is the status of this @grdw?

households_heat_network_connection_steam_hot_water (excess heat/must-run)
households_heat_network_connection_steam_hot_water (dispatchable)

Are not imported. There are two gql's which determine the needed production and capacity and the financial numbers are specified as defaults in ETMoses. It's merged and on beta. Do we still need to use that technology to extract values from it or?

Do we still need to use that technology to extract values from it or?

No, but they need to become technologies in the technology matrix (heat exchangers) as in:

Are they not the same as https://github.com/quintel/etmoses/issues/973#issuecomment-224853904 ?

Are you not confusing them with #973 (comment) ?

Yes 😄


missing parent at morden block 173522

version: 1.1.0
I'm unable to sync the morden blockchain using pyethereum (via pyethapp) on morden testnet. I can sync up to block 173522 but then subsequent blocks do not get imported. I get the following error message when trying to sync:
INFO:p2p.peermgr        waiting for bootstrap
INFO:p2p.peer   received hello client_version=Geth/v1.4.0-unstable/linux/go1.5.1 version=4 capabilities=(('eth', 63), ('eth', 62), ('eth', 61))
INFO:eth.sync.task      spawning new syntask
WARNING:eth.chainservice        verification failed FIXME=ban node error=('receipts_root', 'h\x13\xf3\xf4T\x913|\xaf3C\xf3\x0c\xfe\xb6\x87\xacI\x14\xf6\xe5\xf3\xc27\x16\xd2V\xe6\xb6\xf4\xc7\x9b', '==', 'm\x01\x96\t\xdc\x00\xb0\xce\x85\xaa\xdd/\xd3\xfe\xb8Q.\x15\xcd\t}D\xde_\xd5b\x02\xack\x02\x0e\xca')
Failed to connect to badblocks.ethdev.com
WARNING:eth.chainservice        missing parent head=<CachedBlock(#173522 6e252728)> block=<TransientBlock(#173524 26b2eb9b)>
WARNING:eth.chainservice        missing parent head=<CachedBlock(#173522 6e252728)> block=<TransientBlock(#173525 8c1de200)>
WARNING:eth.chainservice        missing parent head=<CachedBlock(#173522 6e252728)> block=<TransientBlock(#173526 6a3f32fe)>
[etc]

confirmed, we are looking into it.

thx! please let me know if I can provide you with any details that can help you debug the issue.

Just wanted to check in to see if there are any updates on this or if perhaps there is a workaround? Maybe some bootstrap nodes that would work? Thanks!

I know this much by now:

this contract creation produces a different medstate/post state in python:

8cd84723a408b7e150d1b4edfc9f4545c9f0ef2d3af9a0a0e39c1670e8350517, should be
b6328c75236c0145c76a03fe2a4dc23135ec777da35673e3528c18fc34e410b1

the medstate mismatch leads than to a VerificationFailed between the receipts_root of the block from the chain and the deserialized ethereum.blocks.Block instance:
--> 508         must_equal('receipts_root', self.receipts.root_hash, header.receipts_root)
...
VerificationFailed: ('receipts_root', 'h\x13\xf3\xf4T\x913|\xaf3C\xf3\x0c\xfe\xb6\x87\xacI\x14\xf6\xe5\xf3\xc27\x16\xd2V\xe6\xb6\xf4\xc7\x9b', '==', 'm\x01\x96\t\xdc\x00\xb0\xce\x85\xaa\xdd/\xd3\xfe\xb8Q.\x15\xcd\t}D\xde_\xd5b\x02\xack\x02\x0e\xca')

in hex these are:
  map(lambda s: s.encode('hex'), ('h\x13\xf3\xf4T\x913|\xaf3C\xf3\x0c\xfe\xb6\x87\xacI\x14\xf6\xe5\xf3\xc27\x16\xd2V\xe6\xb6\xf4\xc7\x9b', 'm\x01\x96\t\xdc\x00\xb0\xce\x85\xaa\xdd/\xd3\xfe\xb8Q.\x15\xcd\t}D\xde_\xd5b\x02\xack\x02\x0e\xca'))
  ['6813f3f45491337caf3343f30cfeb687ac4914f6e5f3c23716d256e6b6f4c79b', '6d019609dc00b0ce85aadd2fd3feb8512e15cd097d44de5fd56202ac6b020eca']

with the vm tracing as implemented in https://github.com/ethereum/pyethereum/tree/vm_traces_wip there is zero difference in the vm trace between python and go for this transaction -- all 31 vm steps report exactly the same values for gasCost, stack, memory and storage, etc.


ME Bridge choose crafting cpu

Describe your idea
The craftItem method should have another parameter to choose crafting cpu.
I didn’t find any information in the documentation, so I opened a Feature Request.
Describe alternatives you've considered if you've any
No response
Additional context
No response
Linked Issues
No response

I created a the pull request #402 with this feature.

I'll reopen this until released


My Tutorials: End of list black bar

At the end of the list of tutorials (I have a lot of entries might be different with less entries) there's a black bar
Steps to reproduce

Navgiate to My Tutorials tab
In my example I have many tutorials under completed tab
Scroll the end of list

Expected behavior
No black bar visible
Actual behavior

Environment

iOS Version: 14
raywenderlich.com App Version: 1.0.5
Device: iPhone 11

This issue should be closed.


client/beefy: persist voter state

On each BEEFY block finality, save current voter state to Aux db so that, on client restarts, BEEFY voter can simply resume where it left off.
When there is no available BEEFY voter state in Aux db, the initialization process is:
On first GRANDPA finality of a block where pallet-beefy is available walk back the chain from that block and initialize voter to start at either:

first encountered ancestor block for which there is a BEEFY justification available in the backend, or,
actual block where BEEFY pallet was activated if no justifications found along the way.

The above is required to guarantee all mandatory blocks are finalized, even if, for example, a client runs for a while with BEEFY voter disabled (and GRANDPA makes progress, but BEEFY gadget not running). On re-enabling BEEFY gadget/voter, it will "resume" from the last justification or BEEFY Genesis, thus guaranteeing unbroken chain of mandatory justifications.
Fixes https://github.com/paritytech/substrate/issues/11837

@andresilva I've changed initialization process so it now relaxes original assumptions, and is thus more robust:
When there is no available BEEFY voter state in Aux db, the initialization process is:
On first GRANDPA finality of a block where pallet-beefy is available walk back the chain from that block and initialize voter to start at either:

first encountered ancestor block for which there is a BEEFY justification available in the backend, or,
actual block where BEEFY pallet was activated if no justifications found along the way.

The above is required to guarantee all mandatory blocks are finalized, even if, for example, a client runs for a while with BEEFY voter disabled (and GRANDPA makes progress, but BEEFY gadget not running). On re-enabling BEEFY gadget/voter, it will "resume" from the last justification or BEEFY Genesis, thus guaranteeing unbroken chain of mandatory justifications.


Enchanting Table not showing the enchanting menu

"Failed to create screen for menu type: zenith:enchanting_table" Thats the "warning" Im getting but I basically cant enchant anything through it.

Oh right. Log:
https://paste.ee/p/BqaSg


IPv6 validation fails

Description of the Issue
Joule doesn't accept URIs containing IPv6 addresses as valid URIs
Steps to Reproduce
Put any http://ipv6-address:8080/ address as remote node
Description of Your Setup
Doesn't matter
Console Logs / Screenshots

Ahh, according to this stackoverflow post, ipv6 URLs need to be wrapped in brackets like so:
http://[fe80::a950:acb:c210:635a]:8080/

That should work. However, I should attempt to do this automatically, but it may be difficult to parse correctly.

Could use something like this: https://github.com/beaugunderson/ip-address


[ADMIN| Better error message when call to database fails

Instead of just showing a 500, show the error message

Thanks for reporting it @manniL
It's now fixed!

Make sure to refresh the tab if already opened :)


What is Duration, startTime and endTime in trx report?

Steps to reproduce
Just generate trx file with following command: dotnet test --filter Category=Test --logger:trx;LogFileName=results.trx
Environment

Windows 10 x64, NET 5.0, Visual Studio Community 16.8.4
SpecFlow 3.6.23, SpecFlow.Tools.MsBuild.Generation 3.6.23, SpecFlow.xUnit 3.6.23, xunit.runner.visualstudio 2.4.3, Microsoft.NET.Test.Sdk 16.8.3, FluentAssertions 5.10.3

In trx file I can see following sections: duration, startTime, endTime. I couldn't figure out how the time is calculated?

I found these fields in code: https://github.com/microsoft/testfx/blob/ec18af6f90c272f68f48d9d0b94c71b8e276c7a0/src/Adapter/MSTest.CoreAdapter/Execution/TestExecutionManager.cs#L376
https://github.com/microsoft/testfx/blob/ec18af6f90c272f68f48d9d0b94c71b8e276c7a0/src/Adapter/MSTest.CoreAdapter/Execution/TestMethodInfo.cs#L159

Ok I got it, thank you for your answer


Right clicking a section header should deposit or withdraw all items from the header

+1 for both deposit/withdraw as well, if vendoring, right clicking the category header would sell the items.

Yes pls Adibags was this way and I miss it.
It also makes it much easier to keep your raid gear (sets tab) away from junk items you get from farming old raids, so you can hide the raid gear (sets tab) as most of that gear you will be keep for the whole tier, making all you valuable gear hidden, so you can quickly vender all junk gear without worry you will miss sell something.

This has been implemented with v0.1.90.


Multilabel Ranking metrics

What does this PR do?
Fixes #614
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@SkafteNicki how is it going here? :rabbit:

@Borda and @justusschock I taken care of your comments, PR should be ready for merge :]

@SkafteNicki mind checking the failers:
 TypeError: Can't instantiate abstract class LabelRankingAveragePrecision with abstract methods compute, update


WIP: feature/jupyter-magic

Added Custom IPython magic to facilitate Hamilton development in Jupyter notebooks
Many comments were left in the source code.
From the notebook, you can use %%with_functions? (append ?) to view the docstring of magics.
Changes
How I tested this
Notes
Checklist

[ ] PR has an informative and human-readable title (this will be pulled into the release notes)
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future TODOs are captured in comments
[ ] Project documentation has been updated if adding/changing functionality.

When pulling a dataflow, we could also add Jupyter cells to automatically create a venv and install requirements!
!python -m venv ./my_venv

%pip install -r /dataflow/path/requirements.txt

(or directly from Python code import venv ...) We could have a create_venv flag to the magic %insert_dataflow


[BUG] Cannot run locally

I installed pip install -r requirements.txt and ran python3 main.py --model lama --port 8080, but it prompted me Error, No such option: --model，But the web no problem

Use iopaint no problem too


printf() has a different syntax to Go

There are some symbols in C's printf, like %ld that are not supported in Go. It results in Go printing something like %!!(MISSING).
There should be a noarch.Printf(), but only used when the first argument cannot be determined to not include these syntax to improve performance when most of the time it is a string literal.

Maybe it's possible to transpile MUSL's printf implementation and use that as noarch.Printf?

You can  use that code as protitype.
https://github.com/Konstantin8105/c4go/blob/bb2ab78fe0fb931f5fc42afee3501b7b02742148/transpiler/literals.go#L35-L52
And use like that: https://github.com/Konstantin8105/c4go/blob/bb2ab78fe0fb931f5fc42afee3501b7b02742148/transpiler/literals.go#L58


toJSON() returns an empty array

Since version 0.2.65 (maybe 0.2.64, since it wasn't available I didn't test it) that there's been a bug in the toJSON method.
After setting the model of the tree if you call the toJSON method it returns an empty array instead of the tree.
I've created a fiddle that shows that, you can switch between version 0.2.63 and a more recent to see the regression, I'm printing it to the console.
Here's the fiddle: https://jsfiddle.net/9aup14h7/
P.S- I think a little more documentation would do some good, I saw the toJSON and the setModel methods reading issues and printing a tree to the console, they weren't mention on the documentation.
P.P.S- As well as GitHub releases and release notes. The last release on GitHub was on 2018-10-07, over a year ago. And of course the accompanying release note. For example noting how Selection was changed from returning null to returning an empty array if nothing was found.

Hi. I think it's VueJS specific issue. Because data property is changing by link. You have to add an empty object.
<tree ref="tree" data="{}" />

adding the data property with {} on the jsfiddle on version 0.2.67 didn't work, it's still not returning the tree model, it's now returning:
[{
    "data": {},
    "state": {
      "selected": false,
      "selectable": true,
      "checked": false,
      "expanded": false,
      "disabled": false,
      "visible": true,
      "indeterminate": false,
      "matched": false,
      "editable": true,
      "dragging": false,
      "draggable": true,
      "dropable": true
    },
    "children": []
  }]

That's not the model of the tree that's being displayed.

Ohh. Sorry... I forgot. I added a "hook" to increase the speed for rendering big tree. setModel method is working asynchrony now.
https://github.com/amsik/liquor-tree/blob/master/src/lib/Tree.js#L242

That's a big change that should be included in a changelog or release notes. I didn't realize that it was asynchronous now.
The setModel isn't returning a promise thought shouldn't it be returning a promise for it to truly be a asynchronous? I've been using the async/await syntax, I tried awaiting the setModel, putting it inside of a Promise but it didn't work.
Could you do a fiddle with a working example? Thanks.

I've added it in the v0.2.68. Also here is an example: https://jsfiddle.net/amsik/fe63a28s/

I think everything is working now, I was having a few problems with testing, but I solved it after seeing what you did with adding the setupTests.js file for the requestAnimationFrame.


fixchange stream load of auto partition

Proposed changes
fixchange stream load of auto partition
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Automatically calculate coordinates when saving meeting...

First pass
Only geocodes when address has changed
Removes set lat/long button
Location map still exists to allow tweaking

Is there going to be a mechanism to allow manually set coordinates?

At this point in the PR, the only way to manually set coordinates is through the location map. May need to add a manual override but I’m not yet convinced it’s necessary.

can you just have two separate buttons?  update but not adjust coordinates?

the location map just updates the lat/long text fields doesn't it?

I don’t like the idea of having two separate buttons, but it’s certainly possible.
Yeah, the location map just updates lat/long fields.

Because google api keys are now pretty much required to be able to edit meetings, the following work should be done before this feature is completed:

Modify the installation wizard to require a valid google api key, and link a tutorial explaining how to acquire one.
Display an error message in the admin user interface when the google api key is invalid, and link a tutorial explaining how to acquire one.
Create said tutorial.

I wonder if it makes sense to be able to report this on the serverInfo.

By report this, do you mean the validity of the server’s API key? That could be interesting information to have as part of server info. Don’t think it’s absolutely necessary for this feature, but it could help us find servers without valid API keys and be proactive about contacting admins.

exactly

Ok, so far my testing looks good.  From what I can tell, the location map doesn't allow you to manually set coordinates.  It allows you to find a location and then use that to set an address.
I'm not sure how many folks are manually setting the lat/long.  By this, meaning there is a different lat/long from the actual "addressed" location.

Poll it on fb group?
On Wed, Nov 7, 2018 at 12:28 AM jbraswell<EMAIL_ADDRESS>wrote:

If we really want to fix the issues with bad coordinates adding another
button won’t do it. People will click the wrong button. Have to make people
work a little harder to do the wrong thing. An override checkbox which
makes the latitude and longitude manually editable, and then on save
persists the fact that it was overridden, is the right way to do it.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/LittleGreenViper/BMLT-Root-Server/pull/38#issuecomment-436509288,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABw9u1lNORGblPMRxACLRQ05m25jiv1Mks5usm9jgaJpZM4YRXae
.

Outstanding TODOs:

Modify the installation wizard to require a valid google api key, and link a tutorial explaining how to acquire one.
Potentially add a "Manually Override Coordinates" checkbox, which enables the latitude and longitude inputs, allowing users to manually enter coordinates. If we do this, we'll likely need to persist whether or the coordinates were overridden alongside the meeting information.

Before embarking on Item 2 my suggestion would be to poll the community and see how many people actually need this feature, and why.

I think this is done. Needs testing.


Feature request: SAM template

Would it be possible to do a fork of this starter using an AWS SAM template rather than locking into the Serverless framework template?

It could be but I just haven't explored SAM enough.


[FLINK-2537] Add scala examples.jar to build-target/examples

Currently Scala as functional programming language has been acknowledged by more and more developers, some starters may want to modify scala examples' code for further understanding flink mechanism. After changing scala code,they may select the below steps to check result:
1.go to "build-target/bin" start server
2.use web UI to upload scala examples' jar
3.this time they would get confusion, why changes would be not updated.
Because build-target/examples only copy java examples, suggest adding scala examples also.
The new directory would like this :
build-target/examples/java
build-target/examples/scala

I think the best way for newcomers to experiment with Scala and Flink is to use the quickstarts. They can be build easily and used in the same way as having modified Scala examples.
The Scala example programs were removed some time ago, because they produce the same results as the Java examples and don't add any value.

I agree with @uce and I don't think we should add the Scala example JARs again.
@chenliang613, could you please close this PR?
I am really sorry that we didn't respond to your JIRA before you started with the implementation.

ok,fine.


fixed mathematical bug in normalizing time series

ensure maximum absolute score is 1.0 with fix

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master      #2   +/-   ##
======================================
  Coverage    91.2%   91.2%
======================================
  Files           5       5
  Lines         250     250
======================================
  Hits          228     228
  Misses         12      12
  Partials       10      10

Impacted Files
Coverage Δ

xcorr.go
89.61% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6781f2d...faa8e81. Read the comment docs.