refactor(forms-web-app): move autocomplete dependency to package json

Ticket Number

UCD-741
Description of change
move autocomplete dependency to package json
Checklist

[ ] Requires infrastructure changes
[ ] I have updated the documentation accordingly
[x] I have merged commits to avoid fixing things in this PR
[ ] New features have tests
[ ] Breaking change (team conversation required)

Important
Please do not merge from master (please only rebase). This keeps the history linear and easier to debug.

ty


Multiple scripts

Which version of PhantomJS are you using? Tip: run phantomjs --version.
2.1.1
What steps will reproduce the problem?
Run in the same time many casperjs scripts
Which operating system are you using?
Ubuntu 14.04
Did you use binary PhantomJS or did you compile it from source?
Source
Please provide any additional information below.
If I have run many casperjs scripts in the same time, around 50 copies with different names and different cookies files. First few scripts works fast and take 100-150 seconds - it is normal.  But then other scripts take more time and more, like 1000 seconds. Help me please. What I do wrong ?

Due to our very limited maintenance capacity (see #14541 for more details), we need to prioritize our development focus on other tasks. Therefore, this issue will be closed. In the future, if we see the need to attend to this issue again, then it will be reopened.
Thank you for your contribution!


Sanitise repository

We need to make the repository more inviting for contributors.

Remove any redundant project files to avoid confusion
Consistent and clean directory structure
Files not specific to core library should be moved to other locations/repositories to reduce bloat/project size e.g. Tests, docs, release notes
Move documentation to GitHub pages website

Done in commit e483f2f
For now leaving Tests until #390 and #389


Increase minimum supported Rust version (MSRV) to 1.80.1

Which issue does this PR close?
Rationale for this change
We currently require 1.80, but we also say that

If a hotfix is released for the minimum supported Rust version (MSRV),
the MSRV will be the minor version with all hotfixes

therefore we should requite 1.80.1 and thus allow dependencies that
require 1.80.1 (such as substrait)
What changes are included in this PR?

require 1.80.1 msrv

Are these changes tested?
existing tests
Are there any user-facing changes?
1.80.0 is no longer supported
relates to

https://github.com/apache/datafusion/pull/13657
https://github.com/apache/datafusion/pull/13654
https://github.com/apache/datafusion/pull/13622

Thanks @findepi
I should probably have made a policy slightly more clear to mention the hotfix related to rust compiler.

Do we also need to update the Dockerfile?

rust:1.80-bookworm ships rustc 1.80.1


Revamp configuration and dockerization

This PR changes the dracor-api setup in two areas:

It moves secrets used by the API to communicate with other services to a separate file thereby opening config.xml for further non-sensitive configuration items
For dockerization we no longer rely on the official eXistDB docker image but instead install eXist into a generic image. It allows us to build linux/arm64 images (which is currently prevented for the official image by https://github.com/eXist-db/exist/issues/4151).

fixes #173
fixes #165
fixes #174
fixes #158

Hi @cmil,
I tested the docker-workflow on my iMac (Intel). The build and setup worked. But I get an empty eXist-DB (which is expected; and I especially checked that), but the local frontend (by default?) seems to use the dracor.org API, because when I access localhost:8088 I see all the corpora from dracor.org. How could I set it that in my local Docker setup, I want to use my local docker API instead of dracor.org?

Hi @ingoboerner, thanks for testing. Are you sure that the frontend image has been rebuild. Maybe you can try something like:
docker container rm dracor-api-frontend-1
docker image rm dracor-api-frontend:latest
docker compose up


hash_password on SQL Server : truncated password hashes are passed to the database

Discussed in https://github.com/lovasoa/SQLpage/discussions/116

Originally posted by Pieter3033 October 26, 2023
Hi,
I am busy creating a add user page for an admin, not sure if I am doing something wrong.
I am currently struggling converting a input password to hash_password, using the built in sqlpage.hash_password function.
Password input:

Password conversion:

Database reference:

Note: The first row (admin) hash_password was generated by myself using argon2.
The rest of the rows was generated by the hash_password function.
It seems like the input password is not inserted into the function.
Input Tested:

fixed in v0.15


[BUG] Required fields can be left blank for editing pending orgs

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When editing a pending organization, a support admin can delete values in required fields (e.g. "Administrator first name", "Administrator last name", "Administrator email", "Administrator phone") and submit the form.
Steps To Reproduce

Go to /admin/pending-organizations
Click "Edit/Verify"
When the form modal opens, clear all the required fields except "Organization name"
The form saves with empty required fields

Expected Behavior

Go to /admin/pending-organizations
Click "Edit/Verify"
When the form modal opens, clear all the required fields except "Organization name"
Error messages appear for all the blank required fields

Additional context
Discovered while testing: https://github.com/CDCgov/prime-simplereport/pull/5838#pullrequestreview-1440627001
Does this issue have a priority label?

[X] I have added a priority label

Has issue been assigned to a team?

[X] I have added a team label

@mehansen It appears to still be an issue!
https://github.com/CDCgov/prime-simplereport/assets/20211771/b5341969-319c-444b-a871-ffb418cbea10

merging this ticket into the accessibility audit issue #6399


Minor documentation suggestions

Use SVG instead of high-DPI PNG in the doc examples
Remove package-lock.json and fix the documentation build in CI accordingly (don't cache Node)

Hi @asinghvi17 , thanks so much for your contribution!
I am open to reducing the DPI of the plots, but not switching to SVG. The PNG files can be quite large, yes; however, in my experience highly detailed SVG files can be prohibitively slow to render on older computers.


August 2012 link updates

What's changed, or what was fixed?

adding wf_blink_components tags
fixing links

Fixes: #issue
Target Live Date: YYYY-MM-DD

[ ] This has been reviewed and approved by (NAME)
[x] I have run npm test locally and all tests pass.
[ ] I have added the appropriate type-something label.
[x] I've staged the site and manually verified that my content displays correctly.

CC: @petele

:tada: This has been pushed live to https://developers.google.com/web/


Add simple charts without PVC

While having PVs is key for real setup, for folks who get started with k8s having PV setup is not the default.
I think we need to think about charts 101 which would be charts that don't need PV. and only have volumes HostPath and EmptyDir.
PetSets are great, but we need more simple example like the mariadb one. We had a ton of them in the repo early on.

Hey @sebgoa!
I think this would be best handled by the following:

helm create has a basic layout for an app with a templates service and deployment, maybe using nginx as the example
Docs that can take people through simple manual chart creation and then to building out more complex applications

The goal of this repo should be to provide users with real world workable applications. As part of that persistence of some sort will be required in most cases.
As of 1.4 AWS, GCE, Azure, Gluster, Openstack, vSphere and Minikube all support dynamic PVC provisioning. I think its something that chart maintainers should be able to rely on moving forward. If a platform does not support it we should prod them in the right direction.
I do agree though that the on-boarding experience for charts is lacking but firmly believe that this should be approached as an in depth documentation effort rather than having applications that are packaged but not usable beyond an example.
One thing to note is that all of the charts that use persistence can have it disabled via a value. Generally persistence.enabled can be set to false.
cc @erictune @prydonius to keep me honest

Good idea on helm create, maybe something like kubectl run i.e helm create --image=ghost
Didn't know that minikube was supporting dynamic PV in 1.4, that's great.
Agree about real world examples, but some don't need PV (out of the box) like Spark for instance.
A new helm user will try some of these charts and get into an error because of lack of PV. Then will have to dig around to learn about PVs, sending them on on a chase...of course if minikube supports dynamic PV, then it is much less of a problem.

Yep I ran into the exact issue you described here with minikube then sent over a PR to those folks and it is now in as of the 0.10.0 release.
Not all charts need PVs and they shouldnt use them if not required. If the spark chart we have is doing this lets get a PR or issue in place to rectify it. I agree that if its not required it should not be used.

Agreed that the purpose of this repo is to focus on real-world applications, and not examples/scaffolds. There are more charts in incubator right now because we're banking on alpha features (like PVCs) becoming beta within the next few weeks with the 1.4 release, so we'll be able to promote some charts from incubator to stable pretty soon.
I'm not sure about helm create bootstrapping a working example chart, maybe that could be an option, but could get annoying as a default (if you use it regularly and have to keep deleting manifests it creates). A good place for example/scaffold charts is in the helm repo under docs/examples.

Closing this out since PVC provisioning is now in beta.


No internet connection Android 10

It's connect to hotspot in Android 10, but without Internet access

It can not check whether there is an active internet connection or not. For that you can ping your own server or any other site and if you get the result back then you can say there is an active internet connection.

Yes, that what I did, I open my browser to check, by the way I look for days how to connect to hotspot in Android 10 with Internet access but nothing work for me, my question in StackOverFlow if you can help me and help all developers.
https://stackoverflow.com/questions/63124728/connect-to-wifi-in-android-q-programmatically

I would say if you want to connect to wifi on Q and above then you need Wi-Fi network specifier.
If you want to check for internet connectivity then within from the same application you need to make a http request to a server or site and check if your response. You can't check it by opening another application or browser because the scope of connected wifi is local to your app. Of im case you close your app then wifi gets disconnected.
I hope I explained it well.

Yes I get it, but why the app that I add in the link don't have this limitation of scope ? you can look ? I installed a couple days ago, I connect to my hotspot I leave the app and I still connected to internet, it's really weird.
thank's

If you can do one thing for me please,
Could you just forget your hotspot configuration from wifi settings and then try connecting it by using that app you're talking and then close the app, and check if you're still connected to your hotspot or not?
What I think is happening with you is the configuration is saved on your phone previously and the app connects to it normally and when you close the app it disconnect the wifi but due to previously saved configuration the system again connects to it.

ok, I'll try it, sorry I wasn't near to my computer

I tried multiple time, I debug my a lot of code too, for Android Q, as you said Wi-Fi network specifier keep the scope of internet access limited only inside the app, If you leave the app which you trigger the connection to a hotspot, then, you will not have internet access.
thank's

Yeah, so if you need to check internet ping server and check response from within your app. That's the best I can think of. I am closing this issue right now. Feel free to open it if you have any questions.


Comparison/performance measurement between System.IO.Abstractions versus using ram disk

System.IO.Abstractions is nice way to abstract real file system - I think it works currently only on real file system and tries to abstract it's usage. Ideally I think not only file system should be abstracted, it would be good to have API abstractions between for example archives (zip, 7z, etc...) as simple system approach, or dive into more complex direction - that is mountable file systems (fat, iso, etc...).
But I think even with current implementation System.IO.Abstractions is quite useful if you want to test and mock file system.
Another approach not to use System.IO.Abstractions, but use ram disk instead - for example imdisk - for example one tutorial exists here:
https://www.tenforums.com/tutorials/174094-how-create-ram-disk-imdisk-windows-10-a.html
Ram disk is some complex to set-up, but it does not require file system mock up as it's - you can just read and write files on ram disk. But this approach can have some overhead, for example storing other attributes, which file system required - like permissions, file modification times and so on. This overhead could be also considered as "API richness" - eventually file system mock up will not reach all dark corners of file system, or you need to mock them as well (that is file system permissions, file attributes and so on)
Would it be possible to test usage of System.IO.Abstractions versus RAM disk (for example imdisk) - and compare for example performance and potentially other characteristics (like integration, simplicity of testing, mount / unmount delays, consumed ram) -and write as it's own articles / wiki document about summary of your findings ?
It would be good that created project would be also located on git, as example project (e.g. how you can use imdisk) with performance test framework (in case if System.IO.Abstractions or imdisk gets improved over time)

According this youtube video (sorry - it's in Russian) - guy tried to speed up java gradle builds using ram disk, and
overall build metrics are here:
http://www.youtube.com/watch?v=yIhMQ8y5eG4&t=4m31s
where ram disk is slightly slower than SSD drive  - 55s versus 53s,
but faster in case of incremental builds:
http://www.youtube.com/watch?v=yIhMQ8y5eG4&t=5m10s - 22s versus 25s.
But I think usage of System.IO.Abstractions versus ramdisk is not so relevant if test framework does not use huge amount of file operations - like it's with some packaging / uncompression tools.
Most people probably will choose not to use System.IO.Abstractions and not to use ram disk, but those who actually needs it - time difference is quite small to conclude to one or another alternative - then in this case API richness and usability might influence the decision.

Hey @tapika, thanks for your thoughts!
To be honest I'm not fully sure what you're asking for here? System.IO.Abstractions is meant as a dumb abstraction layer of existing file system APIs. There are several old issues asking for add-on functionality and/or higher level abstractions, e.g. https://github.com/System-IO-Abstractions/System.IO.Abstractions/issues/660, https://github.com/System-IO-Abstractions/System.IO.Abstractions/issues/604, or https://github.com/System-IO-Abstractions/System.IO.Abstractions/issues/473. While I totally agree that such things are useful they should not be here in the core library.
If you're asking for some document that compares the mock file system provided by this project with a Ramdisk-based approach, feel free to do so. I'll happily add a link to our documentation here. But again, this is not something that I see in scope of this package and/or myself as the maintainer.

Closing this issue. Feel free to reopen/update here if you have additional input 👍


Is it possible to treat {value: A} | {value: B} as {value: A | B} ?

TypeScript Version:  2.1.4
Code
function or<A, B>(a: A, b: B) {
	if (Math.random() < 0.5) return {value: a}
	else return {value: b}
}

function readValue<T>({value}: {value: T}) {
	return value
}

const numeric1 = or(1, '1')
const v = readValue(numeric1)

Expected behavior:
Compiled with no error.
Actual behavior:
Error on readValue call:
The type argument for type parameter 'T' cannot be inferred from the usage. Consider specifying the type arguments explicitly.
Workaround:
Explicitly add return type or<A, B>(): {value: A | B}.

This would be better asked as a Stack Overflow question.
That said, what you need is something like
function or<A, B>(a: A, b: B) {
  if (Math.random() < 0.5) return { value: a };
  else return { value: b };
}

function readValue<T extends { value: U | V }, U, V>(x: T) {
  return x.value;
}

const numeric1 = or(1, '1');
const v = readValue(numeric1);

This is not a workaround.

I think this unification is hard to do in function call because union type is classified as secondary inference. That is, when an argument of type A | B is matched against a function typed <V>(v: V): void, only A is first considered. This is TypeScript typing feature. @aluanhaddad 's recipe correctly captures this, which force TypeScript promote secondary inference to primary one.
The easiest way to avoid this is just eagerly access the field. numeric1.value will have number | string

In fact the proposed merge of types is incorrect.
When you have a {value: A} - it is an object that can hold only instances of A during its life. The same is for {value: B}. At the same time {value: A|B} means that the object will handle both A and B.
{value: A} | {value: B} means a choice between two objects capable of dealing with only one type of the value, in contrast {value: A|B} is a type of single object.
Though, the weak form of your relation could be true only for immutable objects:
{readonly value: A} | {readonly value: B} === {readonly value:A|B}

However since readonly does not impose immutability, it is still incorrect.

@HerringtonDarkholme Thanks for explaining why it works! That was very helpful to me. I knew it worked, but not why ❤

@aluanhaddad With your sample code, v is inferred as type {}, but expected result should be number | string. So I don't think your solution is correct.
@HerringtonDarkholme Thank you for the explanation.

When an argument of type A | B is matched against a function typed (v: V): void, only A is first considered.
Any reason behind such behavior? Performance?

@Artazor At least {value: A} | {value: B} is assignable to {value: A | B} which TypeScript already recognize.

Disclaimer: type inference in function is complex. I'm likely to mistaken implementation.
I guess this is the side effect of matching union type in inference. Consider this:
type Opt<T> = T | undefined
function get<T>(opt: Opt<T>): T {
  if (!opt) throw new Error('empty value')
  return opt
}
declare var opt: Opt<number>
get(opt) // number

By categorizing inferences as primary and secondary, we can first remove identical types in union, and only match type parameter against discriminated type. This improves inference quality, say, the above example gives you number. And when the improved inference fails, we can fall back to secondary inference.
~~ After re-reading code I think TS just infers target type (parameter T in OP's example) from every constituent from union type (argument type in OP's example).~~

@mhegazy Could I ask why this issue is closed?


ChangeLog.md is not updated

Hi,
ChangeLog.md seems not fully updated with npm released versions, and doesn't include all release changes. Is this by purpose?
https://github.com/Azure/ms-rest-js/blob/master/Changelog.md
https://www.npmjs.com/package/@azure/ms-rest-js

Fixed via #349 Here is the updated changelog


Scroll to chapter heading: Position not correct

page-scrolling/demo-3.htm works fine.
Perhaps the scroll-margin-provider struggles with recently changed positioning of MAIN and toolbars?

Solved.
scroll-margin-provider:

Module parameter added: additional-margin-top, additional-margin-bottom.
Documentation updated.

page-scrolling:

Element.offsetTop values must be collected along the parent element up to document.scrollingElement.

Bug fixed: Style.top used instead of element.top.

page-scrolling Documentation

updated. Demos changed to studies. New demo 1 created.

.


Add JS API

This PR splits bolt-check into a CLI and js API so that we can build on top of bolt-check in our own scripts. As part of this I split check and fix into two separate functions to make things more composable, not sure if this was overkill or not.
I also added some integration tests to verify the CLI was printing the correct things.

Codecov Report

Merging #108 into master will increase coverage by 1.63%.
The diff coverage is 87.7%.

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   82.66%   84.29%   +1.63%
==========================================
  Files          31       33       +2
  Lines         819      796      -23
  Branches      144      141       -3
==========================================
- Hits          677      671       -6
+ Misses        131      114      -17
  Partials       11       11

Impacted Files
Coverage Δ

packages/bolt-check/src/constants.ts
100% <100%> (ø)

packages/bolt-check/src/api/fix.ts
83.95% <83.95%> (ø)

packages/bolt-check/src/api/check.ts
95% <95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55fa3f...9d312a6. Read the comment docs.

Here's a diff to make the cli an entrypoint:
diff --git a/packages/bolt-check/bin.js b/packages/bolt-check/bin.js
index af819e1..4a5f635 100755
--- a/packages/bolt-check/bin.js
+++ b/packages/bolt-check/bin.js
@@ -1,6 +1,4 @@
 #!/usr/bin/env node
 "use strict";

-const cli = require("./").cli;
-
-cli();
+require("./cli");
diff --git a/packages/bolt-check/package.json b/packages/bolt-check/package.json
index a6d1091..d0d3bee 100644
--- a/packages/bolt-check/package.json
+++ b/packages/bolt-check/package.json
@@ -12,7 +12,8 @@
   },
   "files": [
     "dist",
-    "bin.js"
+    "bin.js",
+    "cli"
   ],
   "dependencies": {
     "@babel/runtime": "^7.4.4",
@@ -28,5 +29,11 @@
     "@types/child-process-promise": "^2.2.1",
     "child-process-promise": "^2.2.1",
     "jest-fixtures": "^0.5.0"
+  },
+  "preconstruct": {
+    "entrypoints": [
+      ".",
+      "cli"
+    ]
   }
 }
diff --git a/packages/bolt-check/src/cli/index.ts b/packages/bolt-check/src/cli/index.ts
index 6cccecd..0f8e5bb 100644
--- a/packages/bolt-check/src/cli/index.ts
+++ b/packages/bolt-check/src/cli/index.ts
@@ -56,8 +56,7 @@ let printErrors = (errors: ErrorObj[]) => {
   });
 };

-export default () => {
-  const { flags } = meow(
+const { flags } = meow(
   `
     Usage
       $ bolt-check
@@ -86,9 +85,9 @@ export default () => {
       }
     }
   }
-  );
+);

-  (async () => {
+(async () => {
   const config = { cwd: flags.cwd };
   // @ts-ignore
   const errors = await check(config);
@@ -108,5 +107,4 @@ export default () => {
   } else {
     console.log("Looks like your dependencies are fine");
   }
-  })();
-};
+})();
diff --git a/packages/bolt-check/src/index.ts b/packages/bolt-check/src/index.ts
index 56eb3cf..4782867 100644
--- a/packages/bolt-check/src/index.ts
+++ b/packages/bolt-check/src/index.ts
@@ -1,2 +1 @@
 export { check, fix } from "./api";
-export { default as cli } from "./cli";


Many of the metric events are not getting recorded

We are using perfume.js for live tracking of users data for housing.com. What we have seen over the period of time that CLS metric is only getting recorded for 3% users and tbt for 30% users. Any clue why it would be happening like this? Configuration used
{
resourceTiming: true,
maxMeasureTime: 15000,
}

Environment - React

Ciao @nitinagrawal08,
would you mind share more about:

what version of Perfume.js are you running
what's the percentage of your users on Chrome
can you share the percentage of all the other as well, like % of fcp, lcp, fid and so on
are you running as SPA or SSR

Just for context, the reason I asked about Chrome is because the library depends on the PerformanceObserver API.
Thank you for opening this question, looking forward to understand better what's going on.

@nitinagrawal08 somebody invested 5 minutes and replied to your query. As a minimum you could just say "thank you."

Closing this issue after a few months of lack of reply.


Add logo for Chain info

Is your feature request related to a problem? Please describe.
As part of chain info, we need to provide the chain logo. with the new design we get for mobile app, we need to display the chain logo instead of chain color in some of screens. also this will be helpful for home page of our website we currently upload the logos to this repo each time we need to change the logos.
Provide references to the feature you are implementing that requires this change

Logos can be found on Figma
Example where we want to use it in mobile

Describe the solution you'd like
Introduce a new Chain property (e.g logoURL) to save the url, and give the possibility to upload new icon
Describe alternatives you've considered
Introduce the new property with a static value for now

Will be tackled under https://github.com/safe-global/safe-config-service/issues/1021
Requirements changed and the mentioned ticket is more up to date.


bugfix: add rw lock to scp progress bar

Describe what this PR does / why we need it
Does this pull request fix one issue?

Fixes #2049
Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report
Base: 18.33% // Head: 18.36% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (e2827fd) compared to base (147d994).
Patch coverage: 12.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2053      +/-   ##
==========================================
+ Coverage   18.33%   18.36%   +0.02%
==========================================
  Files         101      101
  Lines        9227     9235       +8
==========================================
+ Hits         1692     1696       +4
- Misses       7304     7308       +4
  Partials      231      231

Impacted Files
Coverage Δ

utils/ssh/scp.go
1.90% <12.00%> (+1.90%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


domain

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.

Description

Link to Website

Additionally the NS records have spaces. If you choose to keep the NS records you will need to fix those records to not include the spaces.


Tag Workbenches so they work in mod recipes

Is there a related problem?
Other mods make use of the vanilla crafting table in recipes, but this mod prevents crafting it with most woods.
Describe the solution you'd like
Tag your new workbenches using forge:workbenches. That is what Tinkers Construct will use for its recipe instead of just the vanilla table.
Describe alternatives you have considered
You could just add a crafting recipe to craft the vanilla table from your table. However the tag is better

Our crafting tables have just been added to the forge workbenches tag in v1.0.7. Thank you for reporting :)


Maps configuration with value including colon character

Hi
The envconfig library is amazing. However, I've run into an issue where I cannot configure map of strings (map[string]string) where value contains colon character.
Basically I am trying to keep a map of URLs like dev:https://foo.com,prod:https://bar.com.
Configuration structure is as follows:
type Config struct {
	Schedule string
	Port     int
	User     string
	Passwd   string
	Urls     map[string]string
}

After calling envconfig.Process the Urls property is empty. If I remove ':' from values, it works perfectly fine.
Is there any workaround to that problem?

Hi
This solution would be help you in this situation till issue resolve generally in code. in this solution we define MyMap type and implement Setter information. This would be helpful till add ignoring char to this module.
type MyMap map[string]string
type Config struct {
Schedule string
Port     int
User     string
Passwd   string
Urls     map[string]string
}
func (m *MyMap) Set(value string) error{
list := MyMap{}
regexSpliter := [^\\]:
reg, err := regexp.Compile(regexSpliter)
if err != nil {
return err
}
if len(strings.TrimSpace(value)) != 0 {
	pairs := strings.Split(value, ",")
	for _, pair := range pairs {
		sepRange := reg.FindAllStringIndex(pair, -1)
		if len(sepRange) != 1 {
			return fmt.Errorf("invalid map item: %q", pair)
		}
		key := pair[0:sepRange[0][0]+1]
		val := strings.Replace(pair[sepRange[0][1]:], "\\:", ":", -1)
		list[key]=val
	}
}
*m = MyMap(list)
return nil

}

this pr addresses https://github.com/kelseyhightower/envconfig/pull/184

go-envconfig can override separator via separator keyword: https://github.com/sethvargo/go-envconfig#separator


Updates to PerfInsights documentations

Includes Text and image changes to PerfInsights documentation.

@anandhms : Thanks for your contribution to the Azure documentation! The author, @genlin, has been notified to review your proposed change.

anandhms is the SME author of this article.
#sign-off

@anandhms - Since you are the SME author and the scope of change here requires staging, could you please pull these changes over to https://github.com/MicrosoftDocs/azure-docs-pr for more robust staging and quality automation passes? Thanks

Hi Tyson,
I don’t see any repository called azure-docs-pr in GitHub. I don’t seem to have access if one exists.
<EMAIL_ADDRESS>Thanks,
Anand
From: Tyson Nevil<EMAIL_ADDRESS>Sent: Friday, December 1, 2017 9:49 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Anand Hegde<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Updates to PerfInsights documentations (#3998)
@anandhmshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fanandhms&data=02|01|Anand.Hegde%40microsoft.com|b42418125b88412821ce08d538e3caca|72f988bf86f141af91ab2d7cd011db47|1|0|636477473366330154&sdata=TswLqYwJuvolADo4jX7%2FfosipBEPJCthZC7iX3KOnhI%3D&reserved=0 - Since you are the SME author and the scope of change here requires staging, could you please pull these changes over to https://github.com/MicrosoftDocs/azure-docs-prhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs-pr&data=02|01|Anand.Hegde%40microsoft.com|b42418125b88412821ce08d538e3caca|72f988bf86f141af91ab2d7cd011db47|1|0|636477473366330154&sdata=G4vWfXwhj64TKhmq900tTV9ThvmPsU27G3l%2BIYu8RUk%3D&reserved=0 for more robust staging and quality automation passes? Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F3998%23issuecomment-348561667&data=02|01|Anand.Hegde%40microsoft.com|b42418125b88412821ce08d538e3caca|72f988bf86f141af91ab2d7cd011db47|1|0|636477473366330154&sdata=CzKn6rYHHDUIAokOIjo6f52ZX7bviDZu3l7jmUakJ5k%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYw7NnYxr1jH5V7FiwSd50lV_YrxpQSaks5s8DwGgaJpZM4QxsGF&data=02|01|Anand.Hegde%40microsoft.com|b42418125b88412821ce08d538e3caca|72f988bf86f141af91ab2d7cd011db47|1|0|636477473366330154&sdata=pN68bM2Jh9Pp1OTsyqJSsNhzcTbuEtCcDEUkgqVntfQ%3D&reserved=0.


Nodejs oic bindings v3

Replaces #1608.

Addressed review comments

Based on @barbieri comment on v2, we can merge/commit this.

if you fixed the comments @ceolin did, just go ahead and merge it.

:+1: to me. Please feel free to commit these commits.

Will do ASAP. Thanks for the review!


Unable to sign in with liveshare

Issue Type: Bug
I am unable to sign in with the liveshare extension in VS Code. I click on the sign in with microsoft follow the prompts in my browser click the open URI button in code but it tells me the code is invalid and to sign in again. No matter how many times I do this it continues in this loop.  I also tried to log in with the alternate method of the code in the documentation and it still loops me through having to sign in and I cannot collaborate with my team.  I have tried uninstalling everything and reinstalling it. Clearing my browser history and trying an alternate browser none of which helps.
Extension version: 1.0.1783
VS Code version: Code 1.43.0 (78a4c91400152c0f27ba4d363eb56d2835f9903a, 2020-03-09T19:34:44.548Z)
OS version: Darwin x64 19.3.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
32.00GB (21.49GB free)

Process Argv

Screen Reader
no

VM
0%

Thanks for reaching out. Your logs may provide us with helpful information. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.

LiveshareLogs.zip
attaching my liveshare logs

So just curious if there is anything that you notice in the logs or anything that could be contributing to my issue?  I would like to get this fixed as my team pairs a lot and it would be so much easier if I could get this working on my work environment. Thanks for your help!

Thanks for following up. We have identified two issues on your logs, one we have a fix that we are about to launch; we are investigating the second. Will follow up once our new version is out.

Not sure if your issue is fixed with any of our recent releases.
If it is not fixed yet, can you try running this command: Live Share: Disable VSCode account authentication? This will revert the authentication to the old flow, and not use the in client auth. Please let us know if this unblocks you, or if it was fixed already.

We've changed our authentication service. See #4128 and if the new authentication is giving you an issue, please create a new issue. Thank you for your patience.


npm install fails with the following error

My machine is running Ubuntu 18.04 with npm version 6.4.1. The error is as follows:

79 verbose stack Error<EMAIL_ADDRESS>install: node-gyp rebuild
79 verbose stack Exit status 1
79 verbose stack     at EventEmitter. (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:301:16)
79 verbose stack     at emitTwo (events.js:125:13)
79 verbose stack     at EventEmitter.emit (events.js:213:7)
79 verbose stack     at ChildProcess. (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
79 verbose stack     at emitTwo (events.js:125:13)
79 verbose stack     at ChildProcess.emit (events.js:213:7)
79 verbose stack     at maybeClose (internal/child_process.js:897:16)
79 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:208:5)
80 verbose pkgid<EMAIL_ADDRESS>81 verbose cwd /home/alexander/playground/enketo-transformer
82 verbose Linux 4.15.0-36-generic
83 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "--unsafe-perm"
84 verbose node v8.1.3
85 verbose npm  v6.4.1
86 error code ELIFECYCLE
87 error errno 1
88 error<EMAIL_ADDRESS>install: node-gyp rebuild
88 error Exit status 1
89 error Failed at the<EMAIL_ADDRESS>install script.
89 error This is probably not a problem with npm. There is likely additional logging output above.
90 verbose exit [ 1, true ]

I'm not aware of an issue with<EMAIL_ADDRESS>with that node and npm version. I just tried with node 8.11.2 (slightly newer than yours) and npm 6.4.1 on Mac OS.
However, I have noticed that these native modules (libxslt and also node-sass) fail to install occasionally for unknown reasons. I usually do a rm -R node_modules and then run npm install again and that usually works.
If the issue persists, I'd do:

create a test folder
run npm install<EMAIL_ADDRESS>in that folder
if you see the same problem, and could post an issue here: https://github.com/albanm/node-libxslt/issues

pls re-open if required


JPG images failing to write: writeToBuffer stalling issue

It seems some images (for now, only jpg) don't work.
For example, this image:
https://wellom.nyc3.digitaloceanspaces.com/media/bugs/annie-spratt-hX_hf2lPpUU.jpg
You can reproduce the issue in the playground by using the image link to load the image in the fetch.
Playground
vips.Image.newFromBuffer works.
But writeToBuffer stalls.
Original image: https://unsplash.com/photos/green-leaf-hX_hf2lPpUU
Several images from the same author have the same problem. I'm trying to figure out what it is. Maybe there is a known issue about this matter.

I could not reproduce this using this playground link.

Thanks! The issue seems to only appear on one MacBook Pro, 15-inch, 2017, macOS 13.6.6 (Chrome, Safari, Edge, Opera, Brave and Firefox)
However, it works on Opera on the same Mac.
It works on other laptops and computers and mac (Apple Silicon) I have tested so far.
Will update to macOS 13.6.7 to see.

If this issue occurs, does the JavaScript console (Option + ⌘ + C) display anything noteworthy? I suspect that issue https://github.com/emscripten-core/emscripten/issues/19374 might be relevant, although that only mentions a Safari/WebKit-specific issue.
Since I don't have access to a macOS device, I'll try to reproduce this on GNOME Web, which also uses the WebKit engine.

There is nothing noteworthy in the js console.
An out-of-memory issue seems quite plausible, I'll try to look into this. Thanks!
vips version:                  8.15.2
Emscripten version:            3.1.60
Concurrency:                   4
Cache max mem:                 52428800
Cache max operations:          100
Cache current operations:      0
Cache max open files:          20
Memory allocations:            0
Memory currently allocated:    0
Memory high water:             0
Open files:                    0
JPEG support:                  yes
JPEG XL support:               no
AVIF support:                  no
PNG support:                   yes
TIFF support:                  yes
WebP support:                  yes
GIF support:                   yes
SVG load:                      no
Text rendering support:        no

Are you able to reproduce this using this playground link? That should be the same repro as the previous one, except that it runs on wasm-vips v0.0.5.
I'm asking because I managed to reproduce this issue (or a similar one?) on GNOME Web.  I only had to set the JSC_useSharedArrayBuffer env variable to 1 to enable SharedArrayBuffer (SAB) features.
$ export JSC_useSharedArrayBuffer=1
$ epiphany

Interestingly, all other demos on the playground show this error:
[Error] GLib (gthread-posix.c): Unexpected error from C library during 'pthread_key_create': Resource temporarily unavailable.  Aborting.

However, wasm-vips v0.0.5 seems to work fine.

Disabling the LLInt (Low Level Interpreter) -> BBQ (Build Bytecode Quickly) tiering up code seems to resolve the above mentioned issue on both GNOME Web 46.1 and GNOME Web 47.alpha, which uses WebKitGTK 2.44.2 and WebKitGTK 2.45.5, respectively.
$ export JSC_wasmLLIntTiersUpToBBQ=0
# Or, if using WebKit that ships with commit https://github.com/WebKit/WebKit/commit/9dd3ce144c26c8d10468250e36eebc8e9968716e
$ export JSC_webAssemblyLLIntTiersUpToBBQ=0

I just opened https://bugs.webkit.org/show_bug.cgi?id=276953 for this.

Are you able to reproduce this using this playground link?

Thank you!
Yes, the issue is still happening on macOs Intel:

Google Chrome 126.0.6478.183
Brave 1.67.134
Edge 126.0.2592.113
Firefox 128.0
Opera 103.0.4928.34

wasm-vips v0.0.5 seems to work fine with Safari now.

I was unable to reproduce the issue using Safari versions 17.4.1 and 17.6 on an Apple Mac mini M2 (2023) provided by Scaleway.
Additionally, I attempted to reproduce the issue on BrowserStack (which provides testing on real devices via Apache Guacamole) using Safari versions 17.4.1 and 17.3 on an Apple Mac mini M1 (2020), but without success.
Interestingly, I encountered the same issue mentioned in https://github.com/kleisauke/wasm-vips/issues/69#issuecomment-2245150645 on LambdaTest with both Safari versions 17.4 and 17.2.1 on an Apple Mac mini 2018. This suggests that the issue is reproducible only on x86-64 architectures.

I was finally able to reproduce this issue. It appears to occur only when wasm-vips is initialized on the main browser thread and when navigator.hardwareConcurrency is less than 6. This explains why it has been challenging to reproduce, as most CPUs today have higher concurrency.
The problem is that the reproducer requires at least 8 threads for random access over the image when navigator.hardwareConcurrency is 4. This can be easily demonstrated using the following test script:
import pyvips

im = pyvips.Image.new_from_file('annie-spratt-hX_hf2lPpUU.jpg')
im.write_to_file('x.jpg')

and when running this script with the VIPS_MAX_THREADS env variable set on the wasm-vips-8.15 branch:
$ VIPS_PROGRESS=1 VIPS_MAX_THREADS=7 VIPS_CONCURRENCY=4 python test.py
test.py temp-2: 5304 x 7952 pixels, 4 threads, 5304 x 16 tiles, 128 lines in buffer
test.py annie-spratt-hX_hf2lPpUU.jpg: 5304 x 7952 pixels, 4 threads, 5304 x 16 tiles, 128 lines in buffer
[... deadlock]
^C

But, setting VIPS_MAX_THREADS to 8 resolves the issue:
$ VIPS_PROGRESS=1 VIPS_MAX_THREADS=8 VIPS_CONCURRENCY=4 python test.py
test.py temp-2: 5304 x 7952 pixels, 4 threads, 5304 x 16 tiles, 128 lines in buffer
test.py annie-spratt-hX_hf2lPpUU.jpg: 5304 x 7952 pixels, 4 threads, 5304 x 16 tiles, 128 lines in buffer
test.py annie-spratt-hX_hf2lPpUU.jpg: done in 0.0472s
test.py temp-2: done in 0.301s

I just pushed commit d5c2ba04fe15f02b171fd8157550af0bfb4490cc that will reduce concurrency to 1 when wasm-vips was initialized on the main browser thread. This will be in v0.0.10, thanks for reporting this!
In the meantime, you can get workaround this issue by manually lowering concurrency to 1, see for example this playground link.
https://github.com/kleisauke/wasm-vips/blob/d5c2ba04fe15f02b171fd8157550af0bfb4490cc/lib/vips.d.ts#L68-L74

Indeed setting the concurrency manually does the job.
Many thanks @kleisauke !! Your help is very appreciated 🙏


Armv7 BE8 support does not properly handle references to global strings

Binary Ninja Version
2.4.3090-dev
Describe the bug
Armv7 BE8 binaries do not properly handle references to global strings, and likely other global data.
To Reproduce
Steps to reproduce the behavior:

Load the attached libssl_armv7be8.so binary
Open the SSL_SESSION_print function in HLIL
Observe that calls to BIO_puts do not have their strings populated in the arguments
Repeat the same steps with the attacked libssl_x64.so binary and observe that in the same location, strings are populated in the arguments

Expected behavior
I expect the behavior we get in the Armv7 BE8 version (incorrect) to be the same as x64 (correct)
Screenshots

Version and Platform (required):

Binary Ninja: 2.4.3090-dev
OS: Ubuntu
Version 20.04

Files
binja_libssl.tar.gz
Both libraries included in the tarball

Thanks for the detailed report and test case this helped us quickly narrow down the issue. Fixed in 2.4.3100


Handle upstream errors with errors directive

This is a feature request and may be out of scope / a bad idea.
I posted this question on the forum: https://caddy.community/t/errors-page-for-proxied-requests/2800
I want to be able to handle errors of upstream proxied requests.
proxy / https://jac.nyc3.digitaloceanspaces.com {
    header_upstream Host jac.nyc3.digitaloceanspaces.com
}
errors {
    403 404.html
}

The reason I want to do this is to hide the bucket name of my DigitalOcean Spaces (S3 clone) bucket.

I think this is a duplicate of a few others: https://github.com/mholt/caddy/issues/1447, https://github.com/mholt/caddy/issues/753 and should probably be covered by https://github.com/mholt/caddy/issues/1639 when it's implemented

You're right this is a bullet point on #1639
On Sat, Sep 30, 2017, 12:08 AM Francis Lavoie<EMAIL_ADDRESS>wrote:

I think this is a duplicate of a few others: #1447
https://github.com/mholt/caddy/issues/1447, #753
https://github.com/mholt/caddy/issues/753 and should probably be
covered by #1639 https://github.com/mholt/caddy/issues/1639 when it's
implemented
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mholt/caddy/issues/1897#issuecomment-333283994, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKOQXaz4BAcV4fj1ivnbLbz7i4QULQXqks5sncyxgaJpZM4Pon4X
.

Cool. Thanks for the feature request! Closing in favor of the earlier issue instead.


CreateRef is missing in 8.3.1

Hey,
I was updating to the new version 8.3.1, however createRef is missing.
Really strange.
https://registry.yarnpkg.com/preact/-/preact-8.3.1.tgz#ed34f79d09edc5efd32a378a3416ef5dc531e3ac
Thanks
Gil

Hi @gilnoycloudinary!
createRef is not included in 8.3.1 as it's only a bugfix release.
Also it 's nowhere mentioned in the release notes, so you shouldn't expect it to be in 8.3.1 ;)
As far as I can tell createRef will make it into 8.4.0.

@gilnoycloudinary @Kanaye 's answer is correct. 8.3.1 was only a patch release and as such doesn't include any new features.

react-countup used createRef，so i can't use the 8.3.1 version of preact


Make better use of whitespace

Whitespace has been removed between the toolbar and table. The sections of the grid have been changed such that they don't change incorrectly when the window is resized. Cells will be resized in a different branch


Upgrade to google-oauth-java-client

Give this a shot to see if it improves the (hard-to-reproduce) issues with #250

Coverage increased (+0.1%) to 73.291% when pulling 5259df9d3e3604fc9cbdece40c04c9ed0594abdb on feature/rewrite_github_login into 8e8ad231d6da31d9d165c088c43f5163a3fc1e80 on develop.


Add hospitalization 7daycases and 7dayincidences

This will add the hospitalization 7-day-cases and 7-day-incidences, as some user requests in #275
I don't know if this is a clean programming style, but I still struggle with JS and TS, but it works.
Fix #275

@marlon360 Hi Marlon, some users asked about this enhancment ( #275 ). So I sat down and put it into practice.
It took me many many hours of try & error to write this enhancement with my modest TS (JS) knowledge. I like to do it, and I have the time, but no feedback at all is kind of frustrating and worse than negative feedback!
I am currently working on the history of hospitalization rates and I would like to know if it is worth going ahead!
cu
Peter (Rubber1Duck)

[ ] age-groups for states
[ ] update documentation


Questions about downloading data from the SUN Colonoscopy Video Database

Thanks for reading this question!
The email address provided at the end of the data download page of the SUN Colonoscopy Video Database is hitoh (a t) mori.m.is.nagoya-u.ac.jp,
This is an unfeasible email address, may I directly change the email address to<EMAIL_ADDRESS>and then send the request email?
thank you!

Yes. You are right

感谢您阅读这个问题！ SUN结肠镜视频数据库数据下载页面末尾提供的邮箱地址是hitoh（t）mori.m.is.nagoya-u.ac.jp，这是一个不可行的电子邮件地址，我可以直接将电子邮件地址更改为<EMAIL_ADDRESS>然后发送请求邮件吗？ 谢谢！

Hello, I wonder if you have received a reply? I write to<EMAIL_ADDRESS>for dataset application but was informed that my message could not be delivered.

Hi, @Selinia
I discussed with original authors via<EMAIL_ADDRESS>I am not sure why you can not use this address. Or you can search their recent research papers and find the new valid address available.
Best


feat: Please increase character limit on GCDS card badge

Prerequisites | Prérequis

[X] I've read the Contributing Guidelines. | J’ai lu les Lignes directrices sur les contributions.
[X] I agree to follow the Code of Conduct. | J’accepte de me conformer au Code de conduite.
[X] I've searched for existing issues that already report this problem, without success. | J’ai vérifié parmi les tickets (issues) existants que ce sujet n’avait pas déjà été soumis.

Describe the feature request. | Décrivez la fonctionnalité demandée
This feature would allow more than 20 characters in the badge on a card.
Describe the use case. | Décrivez les cas d’utilisation
We are working on using GCDS in a Drupal site. We have cards that summarize the content behind them.
At the top of the rows of cards is a filter users can use to refine the list of available cards by category.
The names of categories is determined by business, not the design system.
If a category has more than 20 characters, nothing appears. This can be confusing to users as other cards do have badges.
Here is an example:
The card "World leading marine safety system" belongs to the category "Oceans protection plan". Since that exceeds the 20 character limit, no category displays.

In some of our tests, the English label appears because it is under 20 characters, however the French label won't appear.
We tried a test where we added another field to the authoring interface where a user could add an abbreviated category. Shortening "Oceans protection plan" to "Oceans protection" works, " plan de protection des océan" doesn't.
Describe the preferred solution. | Décrivez la solution souhaitée
The badge prop will allow for more than 20 characters. The design will support this by allowing the blue bar to expand to more than one line if necessary, pushing down the rest of the content.
Describe all alternatives. | Décrivez toutes les solutions possibles
Write our own component
This would work as we could control what goes in the badge area. However it goes against the purpose of a component based design system.
Don't use the badge prop
We could choose not to use the badge and stick the category in the slot. Ideally though the category is more obvious to the user that that.
Shorten badge text
We tried this, it failed for reasons previously explained.
Programmatically truncate categories so they don't display more that 20 characters
We tried this, there were unpredictable results, especially in French.
Provide related code or examples. | Fournissez du code ou des exemples pertinents
This is what we would like to see

Add other relevant resources. | Ajoutez toute autre ressource utile
I understand the desire to have a concise badge. However the use states:

The badge (optional) is a visual indicator to inform users of the card's status or category. Badge text should be no more than 20 characters.

Many categories for things are going to exceed 20 characters.

@CraigClark Thanks for reaching out and submitting this issue. We have started discussions around this as a team and while we don't have an easy fix for now, it surfaces some of the use cases lacking support around character limits and text overflow.  We will look into increasing the character limit and get back to you once we have released a solution.


⚠ ClamAV has degraded performance

In 4678420, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 83 ms

Resolved: ClamAV performance has improved in c0692ea after 5 minutes.


Re organise feature specs

The main claim feature spec file was getting rather large and difficult to work with. This PR splits out the main groups of feature specs into their own files, making it easier to find the specs relevant to specific features or behaviour.

Just realised the commit that supposedly removed redundant expectations (1d08244) was bogus - the expectations were there to prove the button text changed. I've removed that commit and force-pushed.


Conditional Compilation not documented

There should be a list of the available conditional compilation flags we can use documented somewhere.
There used to be one here - https://www.openfl.org/archive/developer/documentation/conditional-compilation/
It's still linked to by the HaxeFlixel docs, but it's a dead link.
Edit: I am noticing now that there is some mention of them in the Lime docs instead, though I really think it needs to be easier to find from the OpenFl site.

I've started a spreadsheet but I can't finish it without help: https://docs.google.com/spreadsheets/d/1wIObN7nelqfcDc1o4mMhKDXfWgwFdPqsv0nO0pqLj-o/edit#gid=0


forge create fails with out of gas

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (8e7e0be 2022-11-24T00:08:24.439767455Z)
What command(s) is the bug in?
forge create
Operating System
Linux
Describe the bug
I'm trying to deploy a contract on Goerli using forge create, but I'm getting an error (code: -32000, message: contract creation code storage out of gas, data: None). It fails on both Infura and QuickNode endpoints with the same error, but it works on a local Anvil. I'm not using any gas-altering flags, just --private-key, --verify and --constructor-args.

I've digged in go-ethereum code and found that the only way to get an error with this message is here: https://github.com/ethereum/go-ethereum/blob/c5dc61c62dabf88091943e02ad309448df26feaa/core/vm/evm.go#L474. It seems that the gas estimation for creation doesn't take into consideration the cost of storing the bytecode.

Sorry about the noise, it turns out that it was my fault, I didn't have enough ETH. The gas estimation is made with your current balance and probably the expected gas price taken into account, and if you don't have enough to cover that transaction, you get the out of gas error.


Adding ClearScript Engine Integration

New Feature Proposal
Adding ClearScript Engine Integration
Description
Currently, there are many modern web pages which Jint can't not handle.
ClearScript7 is supporting newest JavaScript.
ClearScript7 is easy to apply into a project.
ClearScript7 is backed up by Microsoft, easier up-to-date than Jint.
Background
Please follow the link
https://microsoft.github.io/ClearScript/Examples/Examples.html
Specification
No

Yeah definitely - just like the Jint integration that would be another plugin library.
Feel free to contribute and start it! We can help / guide you if you have questions.

Yes, I need some help. Could you provide some quick start or some integration point into AngleSharp?
Reading whole AngleSharp.Js will be pain now, since I have only little time at the weekend.

AngleSharp.Js is actually not that large.
The main point is to have the configuration extension ready, such as the WithJs from AngleSharp.Js.
https://github.com/AngleSharp/AngleSharp.Js/blob/master/src/AngleSharp.Js/JsConfigurationExtensions.cs#L66
For this the IScriptingService interface needs to be implemented: https://github.com/AngleSharp/AngleSharp.Js/blob/master/src/AngleSharp.Js/JsScriptingService.cs#L21

Hello, me again
Seems that Devel and Master are in 2 branches now.

What's the branch recommended to begin?

Hm for what?
devel should always be the base branch - master reflects the latest full release (non-preview).
But for the ClearScript integration a new project should be started. It should not be in the core.

ok, thanks

Any news?
I've tried to combine AngleSharp and ClearScript but I encountered a problem.
document.createElement() method is defined in sealed class AngleSharp.Html.Dom.HtmlDocument, because it's sealed, it cannot be exposed to JavaScript, so ClearScript will throw method not defined exception, whatever restrict type in use, like:
Exception has occurred: Error: “AngleSharp.Html.Dom.IHtmlDocument”  does not contain a definition for “createElement”
Exception has occurred: Error: “AngleSharp.Dom.Document”  does not contain a definition for “createElement”
Exception has occurred: Error: “AngleSharp.Dom.IDocument”  does not contain a definition for “createElement”

Hi @hjlld,

because it's sealed, it cannot be exposed to JavaScript

The sealed modifier controls neither visibility nor access, so it shouldn't be relevant here. The class HtmlDocument isn't public, but you're using AddRestrictedHostObject to expose a public interface, which should be usable from JavaScript.
Due to its dependencies, we can't test your code as is, but the following works as expected (.NET Fiddle):
using var engine = new V8ScriptEngine(V8ScriptEngineFlags.UseCaseInsensitiveMemberBinding);
var config = Configuration.Default.WithCss().WithDefaultLoader();
var document = await BrowsingContext.New(config).OpenAsync("http://dictionary.com");
engine.AddRestrictedHostObject("document", document);
Console.WriteLine(engine.Evaluate("document.title"));
Console.WriteLine(engine.Evaluate("document.createElement(null, 'FooBar').tagName"));

Output:
Dictionary.com | Meanings and Definitions of Words at Dictionary.com
FooBar

If you can share a complete minimal sample that reproduces your issue, we'll be happy to take a look.
Thanks!


T must implement Unsize

Currently i get a error Unsize<MyType> is not implemented for the type MyType

Do you have example code that causes this error?

#![feature(unsize)]
use std::marker::Unsize;

struct Struct;

fn accept<T>(object: T)
    where T: Unsize<Struct>
{
}

fn main() {
    let object = Struct;
    accept(object);
    println!("Hello, world!");
}

What is the goal of the accept method?

accept method has no goal. It is example.

OK. I'm just trying to figure out a use case for "unsizing" to a sized type.

My simplified example
#![feature(unsize)]
use std::marker::Unsize;

trait CommonTrait {
}

struct Line;

impl CommonTrait for Line {
}

struct Node<T: ?Sized> {
    subnodes: Vec<Box<T>>,
}

impl<T: ?Sized> CommonTrait for Node<T> {
}

impl<T: ?Sized> Default for Node<T> {
    fn default() -> Node<T> {
        Node { subnodes: Vec::new() }
    }
}

impl<T: ?Sized> Node<T> {
    fn add_subnode<U>(&mut self, subnode: Box<U>)
        where U: Unsize<T>
    {
        self.subnodes.push(subnode);
    }
}

fn this_works_fine() {
    let mut node: Node<CommonTrait> = Node::default();
    node.add_subnode(Box::new(Line));
    let subnode: Node<CommonTrait> = Node::default();
    node.add_subnode(Box::new(subnode));
}

fn this_does_not_work() {
    let mut node: Node<Line> = Node::default();
    node.add_subnode(Box::new(Line));
}

fn main() {
    this_works_fine();
    this_does_not_work();
}

This code compiles successfully without explicit use of the unsizing machinery:
trait CommonTrait {
}

struct Line;

impl CommonTrait for Line {
}

struct Node<T: ?Sized> {
    subnodes: Vec<Box<T>>,
}

impl<T: ?Sized> CommonTrait for Node<T> {
}

impl<T: ?Sized> Default for Node<T> {
    fn default() -> Node<T> {
        Node { subnodes: Vec::new() }
    }
}

impl<T: ?Sized> Node<T> {
    fn add_subnode(&mut self, subnode: Box<T>)
    {
        self.subnodes.push(subnode);
    }
}

fn this_works_fine() {
    let mut node: Node<CommonTrait> = Node::default();
    node.add_subnode(Box::new(Line));
    let subnode: Node<CommonTrait> = Node::default();
    node.add_subnode(Box::new(subnode));
}

fn this_does_not_work() {
    let mut node: Node<Line> = Node::default();
    node.add_subnode(Box::new(Line));
}

fn main() {
    this_works_fine();
    this_does_not_work();
}

Probably I missed something.

@KalitaAlexey Can you close this? This repo is not for questions. You can ask questions at rust-users, #rust irc, or /r/rust.


Pause video when looking at an interaction

Pause video when looking at an interaction.

Closed by #63


Do our content block examples need to accrue code from the previous chapters over time?

I think maybe. At least the first time we drop something new in.

Agreed

Once the cards are done, we should go through all use of the index.nunjucks template in the docs and make sure they all include 100% of the code in the file at the time the current edit is being made.

do you think all of our code examples should have all of the code in the file, highlighting things as they're added or altered, or is that a bit extreme?

Maybe just the content block? Would that be a good middle ground?

Yeah I think that would be fine
Sent from my iPhone

On Feb 26, 2018, at 7:00 PM, Ben Welsh<EMAIL_ADDRESS>wrote:
Maybe just the content block? Would that be a good middle ground?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


WAQI Fails To Setup Occasionally When Errors Occurs

Home Assistant release with the issue:

0.71
Last working Home Assistant release (if known):
N/A (issue has been around but is not easily reproducible as it seems to be out of our control)
Operating environment (Hass.io/Docker/Windows/etc.):

virtual envrionment
Component/platform:

WAQI
https://www.home-assistant.io/components/sensor.waqi/
Description of problem:
Occasionally the component will generate an error and if I happen to restart during this time the component will fail to setup
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
sensor:
 - platform: waqi
   token: !secret aqi_key
   locations:
   - losangeles
   stations:
   - "Reseda, Los Angeles"

Traceback (if applicable):
Mon Jun 11 2018 16:12:58 GMT-0700 (Pacific Daylight Time)

Error while setting up platform waqi
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 129, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/sensor/waqi.py", line 76, in async_setup_platform
    stations = yield from client.search(location_name)
  File "/srv/homeassistant/lib/python3.6/site-packages/waqiasync/__init__.py", line 32, in search
    return (yield from self._get(SEARCH_URL, keyword=keyword))
  File "/srv/homeassistant/lib/python3.6/site-packages/waqiasync/__init__.py", line 49, in _get
    return (yield from resp.json())['data']
  File "/srv/homeassistant/lib/python3.6/site-packages/aiohttp/client_reqrep.py", line 927, in json
    headers=self.headers)
aiohttp.client_exceptions.ContentTypeError: 0, message='Attempt to decode JSON with unexpected mimetype: text/html'

Additional information:
Typically after some time this error goes away and if I restart the component will setup properly.

This is the error that shows up while the component was already working fine:
2018-07-18 13:19:02 ERROR (MainThread) [homeassistant.helpers.entity] Update for sensor.waqi_reseda_los_angeles fails
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 196, in async_update_ha_state
    yield from self.async_device_update()
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 317, in async_device_update
    yield from self.async_update()
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/sensor/waqi.py", line 167, in async_update
    result = yield from self._client.get_station_by_number(self.uid)
  File "/srv/homeassistant/lib/python3.6/site-packages/waqiasync/__init__.py", line 42, in get_station_by_number
    return (yield from self._get(FEED_NUMBER_URL.format(number)))
  File "/srv/homeassistant/lib/python3.6/site-packages/waqiasync/__init__.py", line 49, in _get
    return (yield from resp.json())['data']
  File "/srv/homeassistant/lib/python3.6/site-packages/aiohttp/client_reqrep.py", line 927, in json
    headers=self.headers)
aiohttp.client_exceptions.ContentTypeError: 0, message='Attempt to decode JSON with unexpected mimetype: text/html'


Create binarysearch.go

Thank You  @NishanNepali for you contribution to the Design And Analysis of Algorithm Repo. Have a nice day!


samples: buttons: Add GPIO_INT_EDGE to button configuration

Add GPIO_INT_EDGE triggering for the button push for boards where
the dts generates a SW0_GPIO_FLAGS.
Signed-off-by: David Leach<EMAIL_ADDRESS>

addresses issue #10137

Codecov Report

Merging #10296 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10296   +/-   ##
=======================================
  Coverage   53.05%   53.05%
=======================================
  Files         214      214
  Lines       26201    26201
  Branches     5645     5645
=======================================
  Hits        13901    13901
  Misses      10028    10028
  Partials     2272     2272

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec4b68...2b72e54. Read the comment docs.

@dleach02 take a look at #10300, should be a more general cleanup.

@galak, we discussed this internally and felt that the board DTS needed to reflect the state of the board and the registers on that board, which is why we didn't change the dts to have a zero here. After the other exchanges with you on the edge trigger I agree that the edge setting should be an application layer (in the C code) setting.

I think the flags we have for GPIO aren't the best.  The INT flag I agree should be set by the application layer, however the sense of EDGE vs LEVEL trigger (and ACTIVE_HIGH/LOW) seems more of a hardware description for the button on the board, thus my thinking of having them in the DTS.

@galak, that is how it is now?
The board dts has
gpios = <&gpioc 4 GPIO_INT_ACTIVE_LOW>;
and this PR just changes the button code to OR in the INT flag?


Use it in GTA Network

Hi,
How can I add it into a GTA Network server? I tried it, but doesn't work...
How to inport DLL to JS script?

Really js + c# dll?  )


Enhancing the topbar

Is there a way to remove a button/element from topbar?
For buttons Is it possible to pass in func *arg and **kwargs  or event details so that the on_button_press event has additional context of what the topbar element  triggered the event? This way we can have a common function that can transform to different action based on state
Is it possible to update the function of a button? Right now only see example for setting value of button

For example say your chart had multiple indicators to show/hide, you would need to implement multiple func to support which button triggered the event
    "Hide RSI" if chart.topbar['rsi_indicator'] == 'Show RSI'
    "Hide MACD" if chart.topbar['macd_indictor'] == 'Show MACD'

Possible to also include an option for dropdown in topbar?

This will allow users to be explicit with options; for example only select symbols or indicators that have been implemented
Multiselect would also be excellent addition to be able to show many overlays (indicators, trade markers, trendlines, subcharts)

Use lambda functions to pass arguments:
def on_button(chart, button):
   if button == 'button_1':
      ...
   elif button == 'button_2':
      ...

chart.topbar.button('button_1', 'Off', func=lambda c: on_button(c, 'button_1'))
chart.topbar.button('button_2', 'Off', func=lambda c: on_button(c, 'button_2'))

Dropdown is not planned at the moment (same functionality can be achieved with switchers).
Multiselect can be achieved using multiple buttons.
Louis

Edit: Actually I will implement dropdown as it would make sense to include.
Louis


[Documentation Request] Kubernetes deployment with active replication

Please add documentation for how to deploy a KeyDB cluster with active replication on Kubernetes with persistent volumes.  One possibility would be to use KeyDB for this tutorial https://kubernetes.io/docs/tutorials/stateless-application/guestbook/.  Thank you

I moved this to the docs repo.


Notification sound

Please use the following bug reporting template to help produce actionable and reproducible issues:

A brief description
It seems that the bash is missing an option. I cannot find a way to stop the annoying notification each time I use the tab key.

Expected results
To actually have a way to shut it up.

Your Windows build number
Version	10.0.14393 Number 14393

Steps / commands required to reproduce the error
Just use it.

Strace of the failing command
None.

Required packages and commands to install
None.

See our contributing instructions for assistance.

This sounds like a general Linux question to me -- Ubuntu on Linux has the same behavior.  This StackOverflow post discusses one way to disable and/or configure it.

You could also take a look at #715 for more discussion of a similar issue.


[REFACTOR] Rename Messaging APIs

send_d2c_message() -> send_message()
send_to_output() -> send_message_to_output()
receive_c2d_message() -> receive_message()
receive_input_message() -> receive_message_on_input()
Renamed samples as appropriate
Kept internal usages of "C2D" for clarity

NOTE: As a result of API changes, this Horton PR will need to be merged first https://github.com/Azure/iot-sdks-e2e-fx/pull/96

/azp run horton-pythonpreview-gate


Add scroll to modals

Issue: #2158
-Add scroll bars to modals in case user zooms in on browser or is on mobile
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #2220 (66d8a47) into main (4124bbe) will decrease coverage by 0.04%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

:exclamation: Current head 66d8a47 differs from pull request most recent head f36f09e. Consider uploading reports for the commit f36f09e to get more accurate results

@@            Coverage Diff             @@
##             main    #2220      +/-   ##
==========================================
- Coverage   68.64%   68.60%   -0.04%
==========================================
  Files         471      471
  Lines       15399    15406       +7
  Branches     1201     1203       +2
==========================================
- Hits        10570    10569       -1
- Misses       4628     4633       +5
- Partials      201      204       +3

Flag
Coverage Δ

metweb
61.46% <ø> (-0.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

met-web/src/components/common/index.tsx
89.33% <ø> (ø)

...-web/src/components/engagement/view/EmailModal.tsx
54.16% <ø> (ø)

...-web/src/components/engagement/view/EmailPanel.tsx
22.58% <ø> (+0.70%)
:arrow_up:

... and 1 file with indirect coverage changes


add http method PATCH for endpoint listener

Just adding the PATCH method for updating user according to rest semantics. #15

Thx a lot!!!


Lag spikes while moving with large number of pikmin followers

Basically title, recorded under the same circumstances as my previous issue. Not completely game-breaking, plus under normal circumstances you likely wouldn't get this many pikmin, but is still pretty bad.
Only mods active are this mod, Imperium (to test things), and their dependencies.
https://github.com/user-attachments/assets/129a053b-1f56-499b-81a5-ff678c3e68a7

It's imperium, Imperium cannot handle large numbers of entities. I'm not fully sure if that is an issue with mainly imperium, or it has something to do with LethalMin aswell.


Harmonise EBSCO and Sierra MatType codes

The materialType code is found in the leader. (character 6).  However, this is not necessarily the same value as the one in Sierra which we rely on to define MaterialTypes in the API. (The Sierra documentation states: "However, this data is customizable in Sierra and each organization determines the codes and strings for their system.")
e.g.  Sierra d means Journal, but d in MARC Leader 06 https://www.loc.gov/marc/bibliographic/bdleader.html is "Manuscript notated music".  We have several values of materialType that are not in the official list on Leader.
Journals from EBSCO have s in this position, and monographs m.
We need to map the values found here and/or in 008 to a value that corresponds with the one we use.
We may also need to do something about the label.
Originally posted by @paul-butcher in https://github.com/wellcomecollection/catalogue-pipeline/issues/2563#issuecomment-1978470058

Part of https://github.com/wellcomecollection/platform-infrastructure/issues/426

Closing as done.


Active NavList.Item is incorrectly missing bold styling

Description
Active NavList.Items do not have the expected bold styling. Note that this appears to be a bug, diagnosed below, and not browser-specific.
❌ Actual: @primer/react

Compare with expected styling on GitHub's own use of the component:
✅ Expected (via github.com):

And the screenshot from the NavList docs themselves:
✅ Expected (via docs)

Diagnosis
The current/active state of a NavList.Item is controlled by the aria-current property which drives the ActionList.LinkItem → ActionList.Item's active property. That property then decides whether ActionList.Item's isActive styles are applied:
https://github.com/primer/react/blob/3ec63098e159d5b9fb14e044e5134972ca8dbfb8/packages/react/src/ActionList/Item.tsx#L125-L138
Those styles are all correctly applied to the container LiBox.
However, (unless a "Description" heading element occurs, which is not desired here and is not shown in the above expected examples), fontWeight is overridden immediately: https://github.com/primer/react/blob/3ec63098e159d5b9fb14e044e5134972ca8dbfb8/packages/react/src/ActionList/Item.tsx#L322
Without being too familiar with the codebase or StyledComponents in general, it seems a possible fix might be something like:
- fontWeight: slots.inlineDescription || slots.blockDescription ? 'bold' : 'normal',
+ fontWeight: slots.inlineDescription || slots.blockDescription ? 'bold' : null,

Steps to reproduce
This is visible in the current storybook: https://primer.style/react/storybook/?path=/story/components-navlist--simple
whose code is given as:
export const Simple: Story = () => (
  <PageLayout>
    <PageLayout.Pane position="start">
      <NavList>
        <NavList.Item href="#" aria-current="page">
          Item 1
        </NavList.Item>
        <NavList.Item href="#">Item 2</NavList.Item>
        <NavList.Item href="#">Item 3</NavList.Item>
      </NavList>
    </PageLayout.Pane>
    <PageLayout.Content></PageLayout.Content>
  </PageLayout>
)

It occurs with any simple NavList with a "current" item, and I believe also with a basic ActionList.Item.
Version
36.9.0
Through 369c3036c8701f227ac5e49b38d32f65f6a8ce97 (at time of issue creation).
Browser
(Not browser-specific)
Chrome

Thanks for reporting this! I'm going to close this as a duplicate of https://github.com/primer/react/issues/4367, but there's a fix ready to merge that will probably be in the next release.

@langermank Oh wow, I browsed through the issues but apparently just didn't read closely enough! That does indeed appear to be a dupe.


binutils-unwrapped-all-targets: init at 2.38

It's not exactly a new package: binutils has been exposing
withAllTargets = true; knob for a while.
To give it more official status let's expose it as an
binutils-unwrapped-all-targets attribute.
Note that binutils-unwrapped.override { withAllTargets = true; }
does not work due to recursive definition of binutils.
Closes: https://github.com/NixOS/nixpkgs/issues/82792
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

/cc @Ericson2314

Just don't override, to avoid bad native bootstrapping stuff.
This is all you need
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 986ff6589c8..010848c81c3 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -14557,6 +14557,12 @@ with pkgs;
     # FHS sys dirs presumably only have stuff for the build platform
     noSysDirs = (stdenv.targetPlatform != stdenv.hostPlatform) || noSysDirs;
   };
+  binutils-unwrapped-all-targets = callPackage ../development/tools/misc/binutils {
+    autoreconfHook = if targetPlatform.isiOS then autoreconfHook269 else autoreconfHook;
+    # FHS sys dirs presumably only have stuff for the build platform
+    noSysDirs = (stdenv.targetPlatform != stdenv.hostPlatform) || noSysDirs;
+    withAllTargets = true;
+  };
   binutils = wrapBintoolsWith {
     bintools = binutils-unwrapped;
   };

Just don't override, to avoid bad native bootstrapping stuff.
This is all you need

Sounds good. Used your variant. Rebased against master.


Navbar should be positioned fixed for small devices

Navbar Enhancement. Minor fix
Navbar should be positioned as fixed for small mobile devices for accessibility and better ui/ux.
Solution
Check If Screen width is less than 769px, if yes then set navbar to be positioned as fixed.

Addressed by #1477


error in gb_repl when run not recongized code

When I try to play with gberry on it's repl, if I wrong to digit a command or I digit a wrong or not recongized command, it's end repl execution and report me  a python error on greenBerry.py.
It is a decision to not handle this stuff or is it a wip?

Feel free to fix it. I have not touched the project in a while ^^


feat: allow installing using "working-directory" folder parameter

Installing dependencies should take into account "working-directory" parameter

closes #46

If your project structure is
root/
  e2e/
    (code for installing and running Cypress tests)
    package.json
    package-lock.json
    cypress.json
    cypress

  (code for running the "app" with "npm start")
  package.json
  yarn.lock

Then this works
name: E2E
on: push
jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@master
      - name: Install root dependencies
        uses: bahmutov/npm-install@v1

      - name: Start server in the background
        run: npm start &

      # Cypress has its own package.json in folder "e2e"
      - name: Install Cypress and run tests
        uses: cypress-io/github-action@4e415ee
        with:
          working-directory: e2e

See https://github.com/bahmutov/cypress-gh-action-subfolders

bahmutov/npm-install@v1 dont cache cypress successfully

Right - so bahmutov/npm-install@v1 caches root dependencies (no Cypress) and cypress-io/github-action@v1 caches NPM + Cypress dependencies from "e2e" folder

i tried 2 runs and in bahmutov/npm-install@v1 cypress installed in this step the second time without caching


Vickel: Watch Manta[\W_]+New[\W_]+Paradigm

Vickel requests the watch of the watch_keyword Manta[\W_]*+New[\W_]*+Paradigm. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Manta[\W_]*+New[\W_]*+Paradigm has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


[python] Create separate set_condition

These are the same changes as in #1775 - see that PR for more details about the purpose of the changes.
This branch was originally meant to be merged into #1756.

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

apis/python/src/tiledbsoma/_tiledb_array.py
83.49% <100.00%> (-0.82%)
:arrow_down:

apis/python/src/tiledbsoma/_query_condition.py
56.83% <71.42%> (-0.37%)
:arrow_down:

... and 75 files with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.


Shipper Doesn't Work With Resyncs Disabled

If you run Shipper with resyncs disabled, there are cases where Shipper will get stuck while taking a release forward.
This is because sometimes we rely on the resync to happen, and we don't do as much as we can in each sync loop.
We haven't dug into this yet, so the best way to reproduce this is to run the end-to-end tests while running Shipper with the resync period of 0 to disable all resyncs, and go from there.

I followed the suggestion of just running the end-to-end tests. Much to my surprise, they all passed. Unfortunately, that seems to be because in current master there's no way to completely disable resyncs. I fixed that in 7ae1c636b93eeb680faea8fedfa69e228dd43ad6.
With those changes, I get one failing test:
--- FAIL: TestRolloutAbort (73.78s)
    e2e_test.go:751: waiting for release "my-test-app-77cf3473-0" took 1.597339649s
    e2e_test.go:840: waiting for completion of "my-test-app-77cf3473-0" took 18.399953573s
    e2e_test.go:617: waiting for contender release to appear after editing app "my-test-app"
    e2e_test.go:751: waiting for release "my-test-app-3037a9fd-0" took 1.598389769s
    e2e_test.go:624: setting contender release "my-test-app-3037a9fd-0" targetStep to 0
    e2e_test.go:627: waiting for contender release "my-test-app-3037a9fd-0" to achieve waitingForCommand for targetStep 0
    e2e_test.go:761: release strategy state transition: "" -> "release \"my-test-app-3037a9fd-0\" has no achievedStep reported yet"
    e2e_test.go:761: release strategy state transition: "release \"my-test-app-3037a9fd-0\" has no achievedStep reported yet" -> "{installation: False, capacity: False, traffic: False, command: True}"
    e2e_test.go:819: waiting for command took 10.398270118s
    e2e_test.go:633: checking that incumbent "my-test-app-77cf3473-0" has 4 pods and contender "my-test-app-3037a9fd-0" has 1 pods (strategy step 0 -- 100/1)
    e2e_test.go:624: setting contender release "my-test-app-3037a9fd-0" targetStep to 1
    e2e_test.go:627: waiting for contender release "my-test-app-3037a9fd-0" to achieve waitingForCommand for targetStep 1
    e2e_test.go:761: release strategy state transition: "" -> "{installation: False, capacity: True, traffic: False, command: False}"
    e2e_test.go:761: release strategy state transition: "{installation: False, capacity: True, traffic: False, command: False}" -> "{installation: False, capacity: False, traffic: True, command: False}"
    e2e_test.go:761: release strategy state transition: "{installation: False, capacity: False, traffic: True, command: False}" -> "{installation: False, capacity: False, traffic: False, command: True}"
    e2e_test.go:819: waiting for command took 6.397543921s
    e2e_test.go:633: checking that incumbent "my-test-app-77cf3473-0" has 2 pods and contender "my-test-app-3037a9fd-0" has 2 pods (strategy step 1 -- 50/50)
    e2e_test.go:761: release strategy state transition: "" -> "{installation: False, capacity: False, traffic: False, command: False}"
    e2e_test.go:814: timed out waiting for release to be waiting for capacity: waited 30s. final state: {installation: False, capacity: False, traffic: False, command: False}
FAIL
FAIL    github.com/bookingcom/shipper/test/e2e  104.361s

This particular instance happens because the strategy controller doesn't watch for releases being deleted, so the rollout abort gets stuck thinking it still has capacity. A cursory look also shows that most controllers don't handle deleted resources either, so even if this particular broken test gets fixed it doesn't mean we have fixed the entire problem.

Indeed, fixing that particular test wasn't the end of it. Even though all the tests passed when ran locally, CI had many more issues that were fixed in #88. Now all tests pass with resyncs disabled, but while fixing the breakage I found one major blocker that prevents us from running with resyncs disabled for real: things can fail for long enough so that they're dropped off of the queue, making things "stuck" after a while. I opened #90 so we can take care of that. Until it gets solved, this issue will remain open.

It turns out that the janitor controller also relies on resyncs: https://github.com/bookingcom/shipper/blob/master/pkg/controller/janitor/controller.go#L306-L331

Cleaning up an Application's stale releases is also executed without checking for errors and bubbling them up: https://github.com/bookingcom/shipper/blob/master/pkg/controller/application/application_controller.go#L348

Now that #77 is merged, we can finally close this! \o/


fix: Clean up out-of-scope references to auto-managed resource

Fix #561
This PR makes the UnclosedResourcesProcessor clean up references to the variable that was inlined into the resource block. Previously, such left-over references were not cleaned up, causing compile errors.
Here's an example of the new-and-improved repair, note how it removes the if in the catcher:
 public class ReferenceInCatcherAndFinalizerToFieldWithSameNameAsResource {
     private int bw = 2;

     public void saveTo(File file) throws IOException {
-        BufferedWriter bw = null;
-        try {
-            bw = new BufferedWriter(new FileWriter(file)); // Noncompliant
+        try (BufferedWriter bw = new BufferedWriter(new FileWriter(file))) {
             bw.write("Write some stuff to file");
         } catch (IOException e) {
             e.printStackTrace();
             System.out.println(this.bw); // reference to field; should not be cleaned!
-            if (bw != null) { // reference to local variable; should be cleaned!
-                bw.close(); // reference to local variable; should be cleaned!
-            }
         } finally {
             System.out.println(this.bw); // reference to field; should not be cleaned!
             System.out.println("done");

         }
     }
 }

It works by looking for references to the inlined variable inside the catchers and finalizer, and removing any statement containing a reference. It's possible that this could "over clean" for example by removing an if statement where the condition has a reference to the resource, but there's also unrelated stuff inside of the  then or else blocks. But I think we'll deal with that only if we actually find it happening, as I've said before, this processor will never be perfect.

LGTM.


Bump to v1.0.0?

Is this library ready for a 1.0 release? The API looks stable and we'd like to use it in production :)

Done. Published as 1.0.0, with semver semantics.

👍 great!
On Fri, Feb 24, 2017 at 2:27 AM Rob Wu<EMAIL_ADDRESS>wrote:

Done. Published as 1.0.0, with semver semantics.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Rob--W/proxy-from-env/issues/3#issuecomment-282258142,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAl-k8W_2ehrJIUV5HCNGyuQMp9q-kmBks5rfrCjgaJpZM4MJbKV
.


Don't lose status codes in CompositeAsyncHandler

Current best example is the body parsers. These will throw an error with status code 415 if the media type is not supported, but the composite handler will merge these into an error with status code 400. Perhaps the composite handler should check if all errors thrown are of the same type and then use that one (not sure how best to do that yet).

Question is also if CompositeAsyncHandler should be aware of this, or if a separate CompositeHttpError is required that does this.


⚠ Bofrost.at has degraded performance

In d5c4b61, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1411 ms

Resolved: Bofrost.at performance has improved in 11a5bc8 after 6 minutes.


how to set websocket proxy?

websocket how can i use sock5 proxy, this liburary have not found configure options.

pass the proxies parameter when you creating the client connection


Typo: localtion

https://github.com/kisenka/svg-sprite-loader/search?utf8=✓&q=localtion&type=
When used with angular1 it triggers TypeError: Cannot read property 'href' of undefined

I haven't yet found where it comes from but it may be some of dependencies

Ok: I found that it has already been fixed yet it's probably not released: https://github.com/kisenka/svg-baker/commit/33cebc1525cff12b58a685a4776f5c7f096c8334

@kisenka feel free to close this one but I think it should stay until new version with updated dependency is released

Fixed in<EMAIL_ADDRESS>


WIP: Adding ASFSearchOptions, to have a clean way of parsing arguments to CMR

Codecov Report

Merging #99 (10f0e3b) into master (057dc0e) will decrease coverage by 2.70%.
The diff coverage is 71.48%.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   83.97%   81.26%   -2.71%
==========================================
  Files          29       34       +5
  Lines         705      886     +181
==========================================
+ Hits          592      720     +128
- Misses        113      166      +53

Flag
Coverage Δ

unittests
81.26% <71.48%> (-2.71%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

asf_search/ASFSession.py
83.33% <ø> (ø)

asf_search/exceptions.py
100.00% <ø> (ø)

asf_search/search/geo_search.py
53.84% <28.57%> (-12.83%)
:arrow_down:

asf_search/search/granule_search.py
66.66% <40.00%> (+4.16%)
:arrow_up:

asf_search/search/product_search.py
66.66% <40.00%> (+4.16%)
:arrow_up:

asf_search/ASFSearchOptions/validator_map.py
45.45% <45.45%> (ø)

asf_search/ASFSearchOptions/validators.py
62.50% <62.50%> (ø)

asf_search/search/search.py
60.52% <82.35%> (+1.85%)
:arrow_up:

asf_search/ASFSearchOptions/ASFSearchOptions.py
90.90% <90.90%> (ø)

asf_search/search/baseline_search.py
95.55% <92.59%> (+0.55%)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 057dc0e...10f0e3b. Read the comment docs.


Authentication failed: Policy is missing

I got this error while trying to authenticate a user against B2C:
authentication failed due to: In collectInfoFromReq: policy is missing
I have created my policy in B2C but I have no idea how and where I should specify it.

@romangusev policy is specified here: https://github.com/AzureADQuickStarts/B2C-WebApp-OpenIDConnect-NodeJS/blob/master/views/index.ejs
In this sample, /login route is protected by passport, and passport extracts the policy query parameter in the request.

@lovemaths Thanks a lot. I expected this info somewhere in this docs: https://docs.microsoft.com/en-us/azure/active-directory-b2c/active-directory-b2c-devquickstarts-web-node
Because I have not cloned this repo, but trying to follow the docs and manually implement B2C with passport.
Anyway thanks for quick response.


Update solc

[x] Review the latest Solidity changes and add test files for any new language constructs.
[x] If tests are failing: fix the schema and update the changelog accordingly.

The new require for custom errors doesn't need any AST changes.


Segfault when using a recoverd trn Array

this code segfaults in Bar.result
use "debug"
use "collections"

class Bar
  let _env: Env
  new create(env: Env) =>
    _env = env

  fun result(foos: Array[Foo val] val) =>
    _env.out.print("done")
    _env.out.print(try foos(0).id.string() else "error" end)

class Foo
  let id: I32
  new create(i: I32) =>
    id = i

class FooGenerator
  var foos: (Array[Foo val] val| Array[Foo val] trn) = recover trn Array[Foo val] end
  let _notify: Bar val

  new create(notify: Bar val) =>
    _notify = notify

  fun ref apply(start: I32) =>
    var i = start
    while i < (start + 10) do
      try
        (foos as Array[Foo val] trn).push(recover val Foo(i = i+1) end)
      end
    end

  fun ref stop() =>
    foos = recover val foos end
    Debug(foos.size())
    _notify.result(foos)

actor Caller
  let foogen: FooGenerator
  new create(f: FooGenerator iso) =>
    foogen = consume f

  be apply(i: I32) =>
    foogen(i)

  be stop() =>
    foogen.stop()

actor Main
  new create(env: Env) =>
    let b = recover val Bar(env) end
    let f = recover FooGenerator(b) end
    let c = Caller(consume f)
    for i in Range(0, 1000) do
      c(i.i32())
    end
    c.stop()

Notes, so far:

this was gutted out from a much larger codebase, I couldn't find as smaller example
It doesn't segfault when:

actor Caller is removed and its apply and stop behaviours are implemented in Main
foos is an (Array[I32] trn | Array[I32] val) instead of (Array[Foo val] trn | Array[Foo val] val)
the Range in Main.create() is small (< 20)
_notify.result(foos) in FooGenerator.stop() is not called, even if the debug statement uses foos as a recovered val

here I compiled with 0.14.0-f70dba091 [release] llvm 3.9.1 -- cc (GCC) 7.1.1 20170516 but I wrote the code in ponyc 0.10 time and had the segfault then (the code base is large, it took time to narrow down to this)

In my larger code, it sometimes doesn't segfault but in that case the objects in the Array hava inconsistent field values (a random number instead of the expected value). It looks like a bad pointer or use-after-free error.

This is similar to #1979. (foos as Array[Foo val] trn) should not be allowed, since we can't determine the capability at runtime.
I'm not sure what could be causing the segfault though.

I think the error is here:
foos = recover val foos end

foos as  is possibly not sendable (trn). recover should complain about that but is somewhat confused by the composite type.

The code in the issue description shows the resulting segfault. The fact that this much shorter chunk compiles is the real issue.
actor Main
  var foo: (String trn| String val) = recover trn String end
  var bar: (String trn| I32) = recover trn String end

  new create(e: Env) =>
    let foo' = recover val foo end
    // let bar' = recover val bar end

This compiles as long as let bar' =  is commented, showing that the problem occurs when a type is a composite of two different capabilities on the same base type, just like in #1979 . This is probably a duplicate, but I can't prove it without digging the codegen/type system code.

Thanks very much for the excellent diagnosis, @lisael. This is indeed the same as #1979. The plan is to change the way type checking for as works to remove the match sugar and remove the compiler internal consume ! AST.


poor error message

When an error occurs in a request, I get this printed out (directly after whatever error message I print for the error):
/usrdata/web/facebook-insights-cli/node_modules/request-promise/node_modules/bluebird/js/main/async.js:36
        fn = function () { throw arg; };
                                 ^
TypeError: undefined is not a function
  at module.exports (/usrdata/web/facebook-insights-cli/node_modules/request-promise/lib/rp.js:158:9)
  at Function.CapturedTrace.fireRejectionEvent (/usrdata/web/facebook-insights-cli/node_modules/request-promise/node_modules/bluebird/js/main/captured_trace.js:214:17)
  at Promise._notifyUnhandledRejection (/usrdata/web/facebook-insights-cli/node_modules/request-promise/node_modules/bluebird/js/main/promise.js:889:23)
  at Async._drainQueue (/usrdata/web/facebook-insights-cli/node_modules/request-promise/node_modules/bluebird/js/main/async.js:84:12)
  at Async._drainQueues (/usrdata/web/facebook-insights-cli/node_modules/request-promise/node_modules/bluebird/js/main/async.js:91:10)
  at Async.drainQueues (/usrdata/web/facebook-insights-cli/node_modules/request-promise/node_modules/bluebird/js/main/async.js:14:14)
  at process._tickCallback (node.js:419:13)

...which isn't very helpful.

Good find. Thanks!
Could you give me some example code so I can write a test for it?

Don't mind. I found it. Two tests are already failing when executed with the latest version of Bluebird.
I will release a fix shortly.

What you actually observe is the aftermath of a possibly unhandled rejection. This is a bug in request-promise, however, you probably should handle those rejections.
If you just use:
rp(...).then(function (body) { ... });

...you should also use a catch like this:
rp(...)
    .then(function (body) { ... })
    .catch(function (reason) { ... });

The catch function will handle any rejection and you won't run into the bug anymore.

I was actually getting that output even if I was using .catch to handle the error.

Oh, that is bad! Can you give me some example code so I can fix that more quickly?

It was just:
request.get(
  uri: url
  qs: queryString
).then((body) ->
  JSON.parse(body).data
).catch((err) ->
  console.error err
)

...I would give more context, but the project is a mess right now because I'm just experimenting with the facebook API, and it should be a pretty standard call.

Unfortunately, I can't reproduce the error when catch is used.
Could you give me the output of console.dir( uri: url, qs: queryString )?

Hey @slang800 I just published<EMAIL_ADDRESS>to npm.
Could you do me a huge favor and test if you now get good error messages in all of your cases? Thanks!

Hi @slang800 since I wasn't able to reproduce all your issues it would be awesome if you could check whether some issues still remain with the latest version. Thanks!

Sure. I temporarily removed request-promise & just used request wrapped by when.JS, but I'll swap that out tomorrow morning & make sure it's fixed.

Ok, I tested it out and it seems to work! thanks!

Thank you very much!