NTR - terms related to GO:0097381 photoreceptor disc membrane

Mammalian rod cells contain stacks of structures called "membrane discs". There is some controversy about how they form that affects conclusions about the spatial relationships of components of nascent discs to other rod cell structures and the surrounding extracellular space, but once the "membrane disc" is formed there appears to be a consensus backed by evidence from several sources that the disc is a flattened cytoplasmic vesicle contained within the rod cell cytosol and separate from the rod cell plasma membrane. This disc vesicle has three parts distinguishable by origin, morphology and protein content: (1) a disc membrane that comprises the flattened faces of the disc formed by evagination of the photoreceptor ciliary membrane, (2) a disc rim membrane that forms separately from the cilium with a distinct content of membrane-associated proteins and that joins the disc membranes, and (3) the disc lumen enclosed by this membrane structure (PMID:19582864 for a review with clear diagrams; PMID:6771304, PMID: 1730772, and PMID:4100753 for experimental evidence).
Cone cells likewise have discs but they are not fully closed and remain accessible to the extracellular space (PMID:19582864).
Most annotations involving these discs (including ones from Reactome) locate entities and activities to the membrane components of discs. However, as part of our own work to try to sort out spatial relations among intracellular components we now need to locate things with respect to the disc lumen.
Does it make sense to create a new term GO:new1 photoreceptor disc with definition and parentage like that for a cytosolic vesicle, make GO:0097381 photoreceptor disc membrane a part_of child of this new term, and give it siblings GO:new2 photoreceptor disc rim membrane and GO:new3 photoreceptor disc lumen, again with standard vesicle-part definitions and relationships?
Is a rod cell - cone cell distinction needed, and how would we make it?
Expert ontology-editorial advice is needed here, and any advice from someone with real expertise in the structure and function of mammalian photoreceptor cells would be a bonus.
I can fill in the missing details of term names and definitions once the editorial issues are sorted out.

@ukemi - I think it makes sense for me to work with @deustp01 on this one, so I claimed it, but if you disagree, you can reassign it.

These two more recent reviews may also be useful:
Morshedian A, Fain GL.
The evolution of rod photoreceptors.
Philos Trans R Soc Lond B Biol Sci. 2017 Apr 5;372(1717).
PMID:28193819
Ingram NT, Sampath AP, Fain GL.
Why are rods more sensitive than cones?
J Physiol. 2016 Oct 1;594(19):5415-26.
PMID:27218707
It's a good question about whether we should distinguish between rod and cone cells. In looking at the lovely comparision diagram from PMID:27218707, see:
https://wol-prod-cdn.literatumonline.com/cms/attachment/858ebc68-961e-4a00-8d57-ba61513b0539/tjp7341-gra-0001-m.jpg
it seems that we should at least have different terms for the outer segments of rod cells versus cones cells since they have different structures as well as different constituents, but I notice that our existing definition for this term has a rod specific definition:
Term: photoreceptor outer segment
Def: The outer segment of a vertebrate photoreceptor that contains discs of photoreceptive membranes.
It might actually make sense to have different terms for other parts of rod and cone cells since they seem to differ significantly in what gene products are present in each type of cell.
@deustp01 - perhaps it would make sense to set up a time to skype.

@krchristie  Thanks! I'll read the papers then let's talk. Sometime Friday?

@deustp01 - Friday, I have commitments from 9:30 am to about 1:30 pm Pacific time. Otherwise, I am available and can be online by about 7:30 am Pacific. Let me know when would work for you.

I've been looking at some of our existing photoreceptor cell terms and we have quite a variety. This comment deals only with BP terms. In some places in BP we have a very fleshed out structure of both camera-type eyes and compound eyes, as well as ocelli. In other places we have a high level term with no child terms. In a few places, we have the high level term and an inconsistent selection of the possible child terms.
These BP terms are very general and encompass both camera-type eyes and compound eyes, as well as ocelli. There are varying levels of detail of hierarchy below.
These two terms have full structure of terms for ocellus and 2 types of eyes:

BP photoreceptor cell differentiation (GO:0046530) - general, has ocellus term & two layer child term hierarchy for camera-type & compound eyes:
-- 'camera-type eye photoreceptor cell differentiation'
--- 'retinal cone cell differentiation'
--- 'retinal rod cell differentiation'

BP photoreceptor cell fate commitment (GO:0046552) - general, has ocellus term & two layer child term hierarchy for camera-type & compound eyes:
-- 'camera-type eye photoreceptor cell commitment'
--- 'retinal cone cell commitment'
--- 'retinal rod cell commitment'

This term is missing grouping term for camera-type eye though the 2 relevant child terms exist

BP photoreceptor cell development (GO:0042461) - very general, already have ocellus term, 5 children of compound eye dev & two specific vertebrate terms, but not camera-type eye grouping term:
-- 'retinal rod cell development'
-- 'retinal cone cell development'

These 2 terms have a cone cell term but not a rod cell term; only 1 of these has a compound-eye	specific term, but none	of the grouping level terms exist:

BP photoreceptor cell fate determination (GO:0043703) - general, has cone specific child term, but not rod term; no compound eye terms; only child term is:
-- 'retinal cone cell fate determination'

BP photoreceptor cell fate specification (GO:0043704) - general, has cone specific child term, but not rod term; also only has 1 of 5 compound eye specific terms:
-- 'retinal cone cell fate specification'
-- 'R8 cell fate specification'

These terms have no child terms

BP photoreceptor cell maintenance (GO:0045494) - general, no child terms

BP photoreceptor cell morphogenesis (GO:0008594) - very general with Drosophila example, no child terms (might be better to modify def to mention appropriate for compound & camera-type eyes)

BP photoreceptor cell axon guidance (GO:0072499) - general, no child terms (single	PMID def dbxref is for Drosophila)

These BP terms have no child terms

BP protein localization to photoreceptor outer segment (GO:1903546) - general, no child terms
BP protein localization to photoreceptor connecting cilium (GO:1903621) - general, no child terms
BP photoreceptor cell outer segment organization (GO:0035845) - general, no child terms; consider need to split for rods & cones

These are the CC terms I've found that relate to photoreceptor cilia. None have specific child terms. Defs of some have been written as if the rod cell is the only type. This quote may explain why these terms seem rod cell centric, even though they are supposed to be general terms.
Quote from PMID:11826267 Ann Rev Physio 2002 (used in def of 'photoreceptor disc membrane')

This review focuses on recent developments in the understanding of two quantitative features of G protein signaling in phototransduction: signal amplification and response timing. It also focuses entirely on rods, which are the more abundant photoreceptors in the retinas of most vertebrates, with the consequence that the quantitative aspects of G protein signaling have been studied in much greater detail in rods than in cones.

CC photoreceptor cell cilium (GO:0097733) - no child terms

CC photoreceptor connecting cilium (GO:0032391) - no child terms

CC photoreceptor inner segment (GO:0001917) - no child terms

CC photoreceptor inner segment membrane (GO:0060342) - no child terms

CC photoreceptor outer segment (GO:0001750) - def is apparently specific to rod cell structure while not mentioning rod cells specifically (Peter and	I think that this should become the general term because the annotations clearly involve both rod and cone cells

CC photoreceptor outer segment membrane (GO:0042622) - no child terms

CC photoreceptor disc membrane (GO:0097381) - Although Peter and I thought that this def seemed apparently specific to rod cell structure though it doesn't mention rod cells specifically (3 refs, most recent is 2002), we found that the phrase "disc membranes" is also used for cyrptochrome containing cone cells (PMID:21647441).

CC photoreceptor ribbon synapse (GO:0098684) - no child terms; paper cited in def gives differences in this structure for rod vs cone cells

CC photoreceptor cell terminal bouton (GO:1990796) - general, no child terms

CC accessory outer segment (GO:1990906) - term is written generally, but from reference (about Zebrafish) this structure may be cone specific

@deustp01 (please correct or add anything I missed) and I talked this morning and are both in agreement that due to both the difference in structure and the specific gene products present, as well as the differences in use in color vision versus night vision, that there is good reason to split out terms for rod and cone cells.
Regarding the CC terms, all of our existing terms are named generally and the ones we checked have clearly been used for annotating both rod and cone gene products, so we feel the existing terms should remain general and we'd like to create rod and cone specific child terms.
Regarding the BP terms, I think it would make sense to make some child terms under the cell development-type terms that don't already have them, but feedback from @ukemi might be useful.

Relationships of photoreceptor cell inner (GO:0001917), connecting (GO:?), and outer segments (GO:0001750) to photoreceptor cilium (GO:0097733)
Question: is the photoreceptor connecting cilium (GO:0032391) meant to include the plasma membrane that surrounds it? If so then this term is identical to photoreceptor cell connecting segment. However, for consistency with the definition of GO:0097733 photoreceptor cell cilium (“A specialised 9+0 non-motile cilium found in photoreceptor cells. A ciliary transition zone called 'photoreceptor connecting cilium' links the photoreceptor outer segment to the inner segment”), the connecting cilium term should refer only to the region of the 9+0 non-motile cilium that spans the connecting segment of the photoreceptor cell and not to the plasma membrane that surrounds this segment of the photoreceptor.
In that case, we need a new cell component term and child:
GO:new photoreceptor connecting segment. Definition The segment of a vertebrate photoreceptor that connects its inner and outer segments, spanned by the photoreceptor connecting cilium.
GO:new photoreceptor connecting segment membrane. Definition The membrane surrounding the connecting segment of a vertebrate photoreceptor. [part_of photoreceptor connecting segment]
Question – what is the relationship of the photoreceptor connecting cilium (GO:0032391) to the inner, connecting, and outer segments of the photoreceptor cell? As shown in the diagram from PMID 19582864 figure 2, its basal body is within the inner segment, it spans the connecting segment, and extends some distance into the outer segment. These relationships are explicitly shown for rod cells, and partly shown, partly implied for cone cells. Does this give the cilium a part_of relationship to all three segments?

CC photoreceptor disc membrane (GO:0097381) - possible new rod vs cone-agnostic name and definition.
Name: photoreceptor outer segment membrane stack [or structure or pile or ...?]
Definition was: Ovally-shaped membranous stack located inside the photoreceptor outer segment, and containing densely packed molecules of the photoreceptor protein rhodopsin that traverse the lipid bilayer. Disc membranes are apparently derived from the plasma membrane in the region of the cilium that connects the photoreceptor outer segment to the inner segment.
change to: Ovally-shaped membranous stack located inside the photoreceptor outer segment, and containing densely packed molecules of the photoreceptor proteins opsins or rhodopsin that traverse the lipid bilayer. These membranes are derived from the plasma membrane in the region of the cilium that connects the photoreceptor outer segment to the inner segment. They may be sealed to form discs, cytoplasmic structures with the topology of cytoplasmic vesicles or may remain open to the extracellular space, forming lamellae with the toplogy of cell projections.
The diagram attached to the previous comment (PMID 19582864 figure 2) is useful here too.

Proposed terms for photoreceptor cell parts, with definitions and parentages
PMID 19582864
GO:0001750 Photoreceptor outer segment. The outer segment of a vertebrate photoreceptor that contains discs stacks of photoreceptive membranes
GO:new Rod cell outer segment. The outer segment of a vertebrate rod cell photoreceptor that contains a stack of photoreceptive membranes in the form of closed cytoplasmic vesicles. [Should rhodopsin be part of the definition?]
GO:new Cone cell outer segment. The outer segment of a vertebrate cone cell photoreceptor that contains a stack of photoreceptive membranes in the form of lamellae open to the extracellular space. [Should opsin be part of the definition?]
GO:new Rod cell disc stack. Oval-shaped membranous stack located inside the rod cell outer segment, and containing densely packed molecules of the photoreceptor rhodopsin protein. These membranes are derived from the plasma membrane in the region of the cilium that connects the photoreceptor outer segment to the inner segment. They are sealed to form discs, cytoplasmic structures with the topology of cytoplasmic vesicles.
[is_a Photoreceptor outer segment membrane stack (GO:0097381)]
[part_of Rod cell outer segment (GO:new)]
GO:new Rod cell disc. An individual closed flattened cytoplasmic vesicle bounded by a lipid bilayer membrane contained within the outer segment of a vertebrate rod cell. The disc is derived from the rod cell plasma membrane and contains densely packed molecules of the photoreceptor rhodopsin protein.
[is_a cytoplasmic vesicle (GO:0031410)]
GO:new Rod cell disc membrane. The lipid bilayer surrounding a rod cell disc. [Should rhodopsin be part of the definition?]
GO:new Rod cell disc lumen. The volume enclosed by the membrane of a rod cell disc membrane.
GO:new Cone cell lamellar stack. Oval-shaped membranous stack located in the cone cell outer segment, and containing densely packed molecules of photoreceptor opsin proteins. These membranes form as invaginations of the plasma membrane in the region of the cilium that connects the photoreceptor outer segment to the inner segment. They remain open to the extracellular space.
[is_a Photoreceptor outer segment membrane stack (GO:0097381)]
[part_of Cone cell outer segment (GO:new)]
GO:new Cone cell lamella. An individual plasma membrane invagination contained within the outer segment of a vertebrate cone cell. The lamella contains densely packed molecules of photoreceptor opsin proteins.
[is_a plasma membrane part (GO:0044459)]

Regarding: Relationships of photoreceptor cell inner (GO:0001917), connecting (GO:?), and outer segments (GO:0001750) to photoreceptor cilium (GO:0097733)

Question: is the photoreceptor connecting cilium (GO:0032391) meant to include the plasma membrane that surrounds it?

That is an interesting question. The membrane is very tricky for an organelle whose bounding membrane is contiguous with the plasma membrane. I'll refrain from duplicating the extensive debates on that subject here. To be sure what an expert thinks, I found a review with Jeremy Reiter, a transition zone expert, as a co-author, and the diagram in that paper would suggest yes.
Garcia-Gonzalo FR, Reiter JF. Open Sesame: How Transition Fibers and the
Transition Zone Control Ciliary Composition. Cold Spring Harb Perspect Biol. 2017
Feb 1;9(2). Review. PubMed PMID:27770015

If so then this term is identical to photoreceptor cell connecting segment.

Yes, I would agree that 'photoreceptor connecting cilium' is meant to be synonymous with 'photoreceptor cell connecting segment'. That is certainly what Paola and I intended.

However, for consistency with the definition of GO:0097733 photoreceptor cell cilium (“A specialised 9+0 non-motile cilium found in photoreceptor cells. A ciliary transition zone called 'photoreceptor connecting cilium' links the photoreceptor outer segment to the inner segment”), the connecting cilium term should refer only to the region of the 9+0 non-motile cilium that spans the connecting segment of the photoreceptor cell and not to the plasma membrane that surrounds this segment of the photoreceptor.

I don't follow your logic that this definition means that the connecting cilium term should not encompass the membrane surrounding this region. As I said above, the cilium is definitely tricky with respect to the ciliary membrane, but I think that the existing term should encompass the entire connecting cilium/transition zone including the membrane.
Regarding whether we need child terms to encompass the membrane and internal region separately, do you have an annotation need to distinguish the membrane region from the internal region of the connecting cilium? I'm fine with making these new child terms if they are needed for annotation, but otherwise think they may be unnecessary. I do not think I have ever needed to annotate to the membrane versus the internal region of the connecting cilium separately.

In that case, we need a new cell component term and child:
GO:new photoreceptor connecting segment. Definition The segment of a vertebrate photoreceptor that connects its inner and outer segments, spanned by the photoreceptor connecting cilium.

If we do need the child terms, I don't understand how your definition of 'photoreceptor connecting segment' is distinguished from the definition of the existing term:
photoreceptor connecting cilium (GO:0097733)
The portion of the photoreceptor cell cilium linking the photoreceptor inner and outer segments. It's considered to be equivalent to the ciliary transition zone.

GO:new photoreceptor connecting segment membrane. Definition The membrane surrounding the connecting segment of a vertebrate photoreceptor. [part_of photoreceptor connecting segment]

Question – what is the relationship of the photoreceptor connecting cilium (GO:0032391) to the inner, connecting, and outer segments of the photoreceptor cell? As shown in the diagram from PMID 19582864 figure 2, its basal body is within the inner segment, it spans the connecting segment, and extends some distance into the outer segment. These relationships are explicitly shown for rod cells, and partly shown, partly implied for cone cells. Does this give the cilium a part_of relationship to all three segments?

The 'photoreceptor connecting cilium' is another phrase for what you have been referring to as the 'connecting segment'. The large number of papers I have encountered have just called it the 'connecting cilium', but Paola and I thought that it was better as a term name to include the word 'photoreceptor' to eliminate potential confusion with any other areas of biology that may use the same or similar phrase for something different.
The 'photoreceptor cell cilium' is the entire cilium, which has its base in the cell body, aka inner segment, and then the connecting segment and outer segments are parts of the cilium.

Difficulty following logic - I was trying to list various possibilities and variant outcomes according to which possibility was correct. The new reference looks like it addresses the variants, so the next step for me is to read it and see if I can simplify the logic.

Maybe just address the simpler question: Do you need to be able to distinguish the membrane of the connecting cilium from the internal portion for annotation purposes? If not, then there is no need for additional terms here.

Regarding: CC photoreceptor disc membrane (GO:0097381) - possible new rod-cone-agnostic name and definition.

Name: photoreceptor outer segment membrane stack [or structure or pile or ...?]

Based on the papers we looked at together on Friday 5/3, and others I've looked at today, the word 'disc' is already agnostic to cones versus rods. Despite still being connected to the ciliary membrane the structures in cones are referred to as discs in many papers, including this recent review with a sample quote:
Mustafi D, Engel AH, Palczewski K. Structure of cone photoreceptors. Prog Retin Eye Res. 2009 Jul;28(4):289-302.  Review.  PMID:19501669
The disc is an important structural component in this step, and in the cone, the disc shape and composition is a critical determinant of its extended activity in light, as contrasted to rods. In cones, the protein molecules of the biochemical cascade are similar to those of rods, but they are located for the most part on open discs that are continuous with the plasma membrane, rather than on discrete disc membranes (Figure 3).
and these two papers from 40-ish years ago:

Steinberg RH, Fisher SK, Anderson DH. Disc morphogenesis in vertebrate photoreceptors. J Comp Neurol. 1980 Apr 1;190(3):501-8. PMID:6771304.
Anderson DH, Fisher SK, Steinberg RH. Mammalian cones: disc shedding, phagocytosis, and renewal. Invest Ophthalmol Vis Sci. 1978 Feb;17(2):117-33. PMID:415019.

Considering that 'disc' is the standard word used for both cones and rods, I would prefer to keep this terminology rather than come up with something different, but not widely used in the literature.

Definition was: Ovally-shaped membranous stack located inside the photoreceptor outer segment, and containing densely packed molecules of the photoreceptor protein rhodopsin that traverse the lipid bilayer. Disc membranes are apparently derived from the plasma membrane in the region of the cilium that connects the photoreceptor outer segment to the inner segment.

I agree the existing definition could use some improvement...

change to: Oval-shaped membranous stack located inside the photoreceptor outer segment, and containing densely packed molecules of the photoreceptor opsin or rhodopsin proteins that traverse the lipid bilayer. These membranes are derived from the plasma membrane in the region of the cilium that connects the photoreceptor outer segment to the inner segment. They may be sealed to form discs, cytoplasmic structures with the topology of cytoplasmic vesicles or may remain open to the extracellular space, forming lamellae with the toplogy of cell projections.
The diagram attached to the previous comment (PMID 19582864 figure 2) is useful here too.

I think that your definition is an improvement, and I have some additional suggestions & questions:
[delete: Oval-shaped - do not see any mention of 'oval' in any of three references cited in this definition and listed below] Membranous stack located inside the photoreceptor outer segment, and containing densely packed molecules of the photoreceptor opsin or rhodopsin proteins that traverse the lipid bilayer. These membranes are derived from the plasma membrane in the region of the cilium that connects the photoreceptor outer segment to the inner segment [should this say to the connecting cilium instead of the inner segment?, since the outer and inner segments are not directly adjacent, but instead each are adjacent to the connecting cilium..]. They may be sealed to form discrete discs, cytoplasmic structures with the topology of cytoplasmic vesicles or may remain open to the cytoplasmic (I do not see how they are open to the extracellular space...) space, forming lamellae with the toplogy of cell projections.
Arshavsky VY, Lamb TD, Pugh EN Jr. G proteins and phototransduction. Annu Rev  Physiol. 2002;64:153-87. Review.  PMID:11826267.
Yau KW. Phototransduction mechanism in retinal rods and cones. The Friedenwald Lecture. Invest Ophthalmol Vis Sci. 1994 Jan;35(1):9-32.  PMID:7507907.
Chabre M, Deterre P. Molecular mechanism of visual transduction. Eur J Biochem. 1989 Feb 1;179(2):255-66. Review.  PMID:2537204.
Add this reference to def:
Mustafi D, Engel AH, Palczewski K. Structure of cone photoreceptors. Prog Retin Eye Res. 2009 Jul;28(4):289-302. Review.  PMID:19501669

Back to the connecting region.

Yes, I would agree that 'photoreceptor connecting cilium' is meant to be synonymous with 'photoreceptor cell connecting segment'. That is certainly what Paola and I intended.
However, for consistency with the definition of GO:0097733 photoreceptor cell cilium (“A specialised 9+0 non-motile cilium found in photoreceptor cells. A ciliary transition zone called 'photoreceptor connecting cilium' links the photoreceptor outer segment to the inner segment”), the connecting cilium term should refer only to the region of the 9+0 non-motile cilium that spans the connecting segment of the photoreceptor cell and not to the plasma membrane that surrounds this segment of the photoreceptor.

I don't follow your logic that this definition means that the connecting cilium term should not encompass the membrane surrounding this region. As I said above, the cilium is definitely tricky with respect to the ciliary membrane, but I think that the existing term should encompass the entire connecting cilium/transition zone including the membrane.

The connecting segment of a photoreceptor cell is bounded by a lipid bilayer membrane. What I'm fussing about is only whether the definition is meant to include that part. If it does, nothing more is needed exactly as you say in your following comment.

Now your comments / revisions to the proposed terms and definitions.
Disc versus lamellae. If people used different words to describe rod and cone structures, we could follow that usage and avoid ambiguity. They don't so we can't - discs everywhere.
What are the lamellae open to? "Open to extracellular space" is my interpretation of the various micrographs and diagrams, like this bit of Figure 1 from Mustafi et al. (PMID: 19501669):

But I am definitely not an expert, so whatever topology fits the real expert consensus is the one I was aiming for.
Inner segment - connecting segment - yes, as you say.

** Regarding what lamellae are open to:** The reason why the cone lamellae are not open to the extracellular space is that on the extracellular  side the membrane completely encloses the disk. The place where the membrane of the disc is open is adjacent to the cilium. Thus, the lamellae are open to the 'cilary cytoplasm'.
Regarding transition zones: My interpretation of both the existing GO definitions and the diagrams I've seen, both the one I included above as well as another review, is that the transition zone includes the membrane in that region. If you feel it would be helpful, we could add to the definition to be explicit about this.

Actually, thinking more about cone discs, I'm not sure it makes sense to talk about what they are open to. I am not seeing that kind of language in the literature. Rather, researchers talk about the fact that the membrane is contiguous with the ciliary membrane. This type of phrase is used both in the paper you cite and the review I found:
Kennedy B, Malicki J. What drives cell morphogenesis: a look inside the vertebrate photoreceptor. Dev Dyn. 2009 Sep;238(9):2115-38. PMID:19582864
Mustafi D, Engel AH, Palczewski K. Structure of cone photoreceptors. Prog Retin Eye Res. 2009 Jul;28(4):289-302. doi: 10.1016/j.preteyeres.2009.05.003. PMID:19501669

Transition zone - the definition hasn't bothered anyone except me; let's leave it as-is.
What the cone discs/lamellae open to - "contiguous with ciliary membrane" sounds good.

Regarding: Proposed terms for photoreceptor cell parts, with definitions and parentages

PMID 19582864
GO:0001750 Photoreceptor outer segment. The outer segment of a vertebrate photoreceptor that contains discs stacks of photoreceptive membranes

This term has two is_a children:
GO:new Rod cell outer segment. The outer segment of a vertebrate rod cell photoreceptor that contains a stack of photoreceptive membranes in the form of closed cytoplasmic vesicles. [Should rhodopsin be part of the definition?]
GO:new Cone cell outer segment. The outer segment of a vertebrate cone cell photoreceptor that contains a stack of photoreceptive membranes in the form of lamellae open to the extracellular space. [Should opsin be part of the definition?]

I am in agreement that we need rod and cone specific terms for outer segments. It would be helpful to annotators to have rhodopsin and opsin mentioned somewhere, but perhaps most appropriate in the membrane child terms.
The existing term photoreceptor disc membrane (GO:0097381) is a membrane term, currently
is_a: ciliary membrane
While this is_a: ciliary membrane is problematic for the rod disc membrane as it is no longer
contiguous with the ciliary membrane, I don't think we can convert this term from being a membrane term to being a term for the whole stack. To handle the difference in topology between the discs in rod and cone cells, we will need to change the parentage of this general term, and then the rod and cone specific terms will need the distict appropriate parentage for each.
Another major issue for me is I don't see an annotation need to have separate terms for the stacks
versus individual discs. Unlike the Golgi stack, I don't think there is any evidence for
differential localization of any gene products to distal versus proximal discs in photoreceptor disc
stacks. When we talked last week, we talked about the need to represent the difference in structure of the rod and cone disc stacks, and then you also need a rod disc lumen term. I don't see any annotation need for specific terms for either discs or stacks. Below is what I think we need, in context with a few of the existing terms.
- photoreceptor outer segment (GO:0001750)
-- cone photoreceptor outer segment (**GO:new**)
-- rod photoreceptor outer segment (**GO:new**)

- photoreceptor disc membrane (GO:0097381)
    [change parentage from is_a 'ciliary membrane' to is_a 'membrane'
-- cone photoreceptor disc membrane  (**GO:new**)
    [is_a 'ciliary membrane'; this parent term is already a child of 'cell projection membrane']
    [part_of cone photoreceptor outer segment (GO:new)]
    [synonym (EXACT): cone photoreceptor lamella membrane]
-- rod photoreceptor disc membrane (**GO:new**)
    [is_a 'cytoplasmic vesicle membrane']
    [part_of rod photoreceptor outer segment (GO:new)]

-- rod photoreceptor disc lumen (**GO:new**)
    [is_a 'membane enclosed lumen']
    [part_of rod photoreceptor outer segment (GO:new)]

Parentage. If I read right, you have it sorted out - no concerns or suggestions here.
Terms for individual discs versus the whole stack. The only need that I know of is that we want to be able to refer to the rod disc lumen and I couldn't think of a way to refer to that lumen except as a part_of an individual disc. If you're OK with the idea that a disc stack can have a lumen then there's no need at all for individual discs.

Well, 'a' disc stack does not have 'a' lumen, but we won't have a term for disc stack anyway, only membrane terms and the rod disc lumen term. I realize it isn't a full representation of the structure, but I think it meets annotations needs without creating a bunch of terms that I can't seen any utility for with respect to annotation.

That sounds fine!

What initials do you use for your definition dbxref, GOC:pd?

I don't know. I think I've never been credited with an ontology term @ukemi?

GOC:pd does not seem to be used in the entire entology, while GOC:pde had been used 96 times.
It would be really useful if the list of curators & abbreviations was available to editors somewhere, not necessarily somewhere public. @ukemi @cmungall

https://github.com/geneontology/go-site/blob/master/metadata/users.yaml

@deustp01 - You are represented by GOC:pde, and are credited in 96 term definitions.
Here is a diff showing 5 new terms related to photoreceptor outer segments, as well as modifications to the definitions of two existing terms:

photoreceptor outer segment
photoreceptor disc membrane

https://github.com/geneontology/go-ontology/pull/17250/files
Take a look and see if you are OK with these new terms and definitions.
Note: ignore the fact that I wasn't paying attention and set the namespace of these new terms as CC. I've already fixed my version, but don't want to push the fix yet since I can't remember if you'll still be able to see this diff once I push the namespace fix.

@deustp01 - I'm thinking that perhaps just these 5 new terms is enough. It covers what you need, and covers the area of the photoreceptor outer segments that are topologically different. Perhaps all the rest can be handled with existing terms and extensions/GO-CAM models for cell types.
Let me know if you think the defs I've put in look OK to you.

@krchristie  The five terms cover everything needed now - both the specific lumen term we wanted, and related terms created to distinguish rod- and cone-specific cell_compartments.
The defs look fine.

@deustp01 - Thanks for checking. I've committed these terms now.


Links to notes with spaces in the title are not able to be followed

🐛 Describe the bug
Summary
Links with space in the note title are not followable by a simple gf. Instead, user must highlight the entire contents of the link at which point gf works.
Steps to reproduce

Create a note in vault
Link to a note with which has a space in the name (Ex: "From the Vast - Session 1.md")
Place cursor inside the link at any position
Use gf command
Observe error 'Cannot find file "From" in path'
Use visual mode to select entire file name
Use gf command
Observe link followed correctly

Expected Behavior
Link is followed no matter if visual mode technique is used or not.
Versions
NVIM v0.8.0
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by<EMAIL_ADDRESS>
Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/opt/homebrew/Cellar/neovim/0.8.0/share/nvim"

Run :checkhealth for more info

1.3.0

Hey @shakesbeare, I'm not sure what the best solution to this would be. I guess we could potentially override gf with our own implementation.

Contributions welcome on this. I looked into a little more and I'm pretty sure the best solution is in fact to override gf with a custom function. I think it's reasonable to assume that we can only handle filenames with spaces when they're contained in a reference, e.g. [[my note.md]]. So implementing this function shouldn't be too hard. Basically:

Get the cursor position and corresponding line in the buffer.
Check if cursor is on a reference, in which case parse out the reference and follow it.
Otherwise just treat the current "word" under the cursor as a filename and follow it.

@epwalsh I figured I'd give it a shot but I had some questions about the exact implementation which is best.
My thought was to create a command such as :ObsidianFollowLink and a companion function, something like cursor_inside_markdown_link. That way the user could decide to bind it at their own discretion and choose to use the gf keybind if desired and allow it to pass through to standard gf if the cursor isn't inside of a markdown link. The idea would be to avoid rewriting vim's existing code for this purpose and allow greater customization for the user.
Furthermore, Obsidian allows for links to be styled without sub-directories listed in the link (ie [[my note.md]] instead of [[notes/my note.md]]) provided that the no other note exists with that file name. It seems from some quick testing that the standard gf does not share this functionality (vim fails to find the file test3.md within the folder folder unless the text is written as folder/test3.md). Should we follow the standard set by vim gf or make the experience consistent with Obsidian's links?

My thought was to create a command such as :ObsidianFollowLink and a companion function, something like cursor_inside_markdown_link. That way the user could decide to bind it at their own discretion and choose to use the gf keybind if desired and allow it to pass through to standard gf if the cursor isn't inside of a markdown link. The idea would be to avoid rewriting vim's existing code for this purpose and allow greater customization for the user.

I like that idea.

It seems from some quick testing that the standard gf does not share this functionality (vim fails to find the file test3.md within the folder folder unless the text is written as folder/test3.md).

Vim will actually do this as long as your notes folder is in path. So in vim, just do set path+=folder and then that should work. Now that I think of it, Obsidian should do that automatically. I'm going to make a PR for that.


MockPipe cache is preventing tests from overriding implementation

First MockPipe is always winning. About to push a change that will remove the cache for pipes.

058d66e9e9c102b1654263be95faedb89c243c4d

https://github.com/ike18t/ng-mocks/tree/v7.7.1

Released: https://github.com/ike18t/ng-mocks/tree/v7.7.1


cannot read property 'connection string' of undefined

Storage Explorer Version: 1.4.1
Platform/OS Version: Windows 10 Enterprise April 2018 Update
Architecture: x64 bit
Regression From: The version prior to 1.4.1
Steps to Reproduce:

Open Azure Storage Explorer. It takes to my preset Subscription, but instead of showing me the Storage Accounts listed under the Subscription, it is throwing the error: cannot read property 'connection string' of undefined
I tried to remove my login and added back but still facing the same issue.

Expected Experience:
It should show me the list of Storage Accounts
Actual Experience:
Throwing an error as shown above

same issue

@basilcherian and @gavintgh are y'all still having issues?

Closing due to lack of response. Please open a new issue if you are still having problems.


Hook Offsets without jailbreak

hey, help me, i will making a my tweak and idk how to patch offsets without jailbreak, examples only with jails, help please

examples are provided for byte code patching, non jailbreak,  you will find them listed inside the h5frida folder

You can use ActiveCodePatch("Binary path", 0xOFFSET, "EDIT BYTE");


define test report extension in the report-vendor enum

Minor tweak that seems a little more clear to me :)

Thanks for contribution!


Update path in settings modal continues to fail

Describe the bug
We just merged #295 and I'm coming across this weird issue where if you enter a bad path and then correct it (by typing), the path checker will get stuck and it won't let you save even if the path in the input is now correct.

This happens on Mac but @AWolf81 reported he cannot reproduce on Windows.
I might look into it more myself but if anyone else wants to in the meantime go ahead.
To Reproduce

Click on Preferences in the menu to bring up the app settings modal
Change the default path to something wrong, by typing it into the input
Click save. Error throws as expected.
Correct the path to something that you know exists. Click save.
Error still throws even though path is correct.

Expected behavior
Successfully update the path.

Looked into this more and it's due to replacing the leading slash. Works perfect for me without it. PR incoming.


-k command not working with hackrf

When I write the following command:
./gal-osnma-sim -l 31.1598,131.1589,100 -v ./tv/configuration_A/13_DEC_2020_GST_09_00_01_fixed.csv -b 8 -d 60 -k
The following output appears and freezes on the last line:

Why is freezing after set_sample_rate?

Hi,
You must have a problem with your hackrf.
On our reference setup:
xxx@yyyyy:~/github/gal-osnma-sim$ ./gal-osnma-sim -l 31.1598,131.1589,100 -v ./tv/configuration_A/13_DEC_2020_GST_09_00_01_fixed.csv -b 8 -d 60 -k
Test vector file:       ./tv/configuration_A/13_DEC_2020_GST_09_00_01_fixed.csv
Replay position:        lat:31.159800 lon:131.158900 alt:100.00
Galileo start Time:     wn:1112, tow:32400
Replay duration:        60 s
Output data not recorded
sample rate = 2600000.000000
call hackrf_set_sample_rate(2600000 Hz/2.600 MHz)
call hackrf_set_freq(1575420000 Hz/1575.420 MHz)
call hackrf_set_amp_enable(1)
call hackrf_set_antenna_enable(0)
Initialized satellites in view:
sat: 03 az:  315.2 el:  20.0 wn:1112 tow:32400.100000
sat: 05 az:  262.5 el:  55.4 wn:1112 tow:32400.100000
sat: 09 az:  185.1 el:  37.0 wn:1112 tow:32400.100000
sat: 11 az:  163.1 el:   8.3 wn:1112 tow:32400.100000
sat: 12 az:  112.9 el:  23.9 wn:1112 tow:32400.100000
sat: 24 az:  351.4 el:  61.3 wn:1112 tow:32400.100000
sat: 25 az:  275.9 el:  31.5 wn:1112 tow:32400.100000
sat: 31 az:   53.4 el:  28.5 wn:1112 tow:32400.100000
sat: 33 az:   60.7 el:  15.5 wn:1112 tow:32400.100000
Nb Sat in view 9
Time =  2.3^CCaught signal 2, 0
Time =  2.4
Done!
hackrf_stop_tx() done
hackrf_close() done
hackrf_exit() done
Process time = 0.730[sec]

I tried debuging the code, and it seems to get stuck on the line highlighted below:

Do you have some idea why it might be getting stuck on hackrf_start_tx() function. I've used the same hackrf to run the gps-sdr-sim project, and it works fine with that.

Its exactly what we suspect. The issue is not related to our code but from the hackrf library or the hackrf firmware. Please checks that here: https://github.com/greatscottgadgets/hackrf
We don't give support for the hackrf.

The issue seems to be resolved. I've uncommented bufferPull() and removed the bufferPush() from the tx_callback(). And have altered the bufferPull function as following in the fifoBuffer.c file:
`void bufferPull(int nBytes, uint8_t buffer[nBytes]){
pthread_mutex_lock(&fifo.mut);

    while (fifo.length < nBytes) {

#if TEST_HACKRFBUFFER >0
printf("buffer empty: length %i / nByte %i\n", length, nBytes);
#endif
struct timespec time_to_wait={0,0};
time_to_wait.tv_sec = time(NULL)+ 1;
        pthread_cond_timedwait(&fifo.write, &fifo.mut, &time_to_wait); //

    }

#if TEST_HACKRFBUFFER
if (fifo.maxLength < nBytes) {
printf(" \n buffer size\n%i:\t%i\n", fifo.maxLength, nBytes);
}
#endif
for(int i=0; i < nBytes; i++){
    buffer[i]=fifo.buffer[(fifo.origin+i)%fifo.maxLength]>> 4;
}

fifo.origin = (fifo.origin+nBytes)%fifo.maxLength;
fifo.length -= nBytes;
pthread_cond_broadcast(&fifo.read);

pthread_mutex_unlock(&fifo.mut);

}`
The code runs fine and the receiver is observing the Galileo satellite signals.


[Issue]: Project version is set only the first time in risk and vulnerabilities tabs

Issue Description
The version entered in the Welcome Panel is set the first time but not updated after

After updating :

But the version in the report is updated:

Duplicate Steps
Change the version
Click outside of the input
Change the version again
Go to Risks or Vulnerabilities Panel
See the displayed version is the first one
Expected Results
The current version should be displayed
Version Detected
1.1.0 (Default)
Attachments
No response

Not an issue

Not an issue


Include Videos in Documentation

Link youtube videos into documentary:
OC BMeetup RaspiBlitz DeepDive, Bitcoin Magazin Sessions, Expolre Crypto YouTube Channel ... search Youtube "RaspiBlitz".

Collection of Videos to link into README documentation:
The OC Bitcoin Network Presents - The Bitcoin Full Node Deep-Dive into the Raspiblitz
https://www.youtube.com/watch?v=QXUGg45CWLo
Technical Tuesday - Running JoinMarket on the RaspiBlitz
https://www.youtube.com/watch?v=uGHRjilMhwY
Technical Tuesday - Lightning Vouchers & Merchant Onboarding
https://www.youtube.com/watch?v=0Bt3tHULAnw
Technical Tuesday - Contributing to RaspiBlitz Development
https://www.youtube.com/watch?v=ZVtZepV3OfM
Raspiblitz node Backup to Dropbox and USB
https://youtu.be/5wi6l9jRVQs
Raspiblitz - Updating to the recent version - tutorial
https://youtu.be/Xvn0WQfHUdI
CHANNEL MANAGEMENT and RTL interface in Raspiblitz
https://www.youtube.com/watch?v=pESO_Pm0v10
Raspiblitz in Mobile Wallet (Zeus app) - how to connect through TOR
https://www.youtube.com/watch?v=XStiTJosklY
TOR and Electrum Server on Raspiblitz - installation/explanation
https://www.youtube.com/watch?v=AiosKK_TA7w

Also link this tutorial on BTCPayServer: https://coincharge.io/en/raspiblitz-btcpay-server/

OK all videos linked in: https://github.com/rootzoll/raspiblitz/tree/1544doc

[ ] merged for release as soon as links for downloading the 1.6.2 image are updated


Added HAZELnet as a Community Integration Tool

HAZELnet is a Community Integration Tool that provides Discord integration and verification under the three primary tenets Privacy, Security and User Experience.
Future Integrations with Twitter and Twitch are on the way, as are additional features that allow off-chain voting, DAO onboarding, giveaways and more.

Hi @nilscodes, can you please provide us with your logo, some profiles of the main individuals involved and a URL to your site. Also if you have a blurb explaining your project and/or whitepaper/specification that would be great. Thank you


Not detecting un-used variables in case of nested try / except block.

Describe the bug
Bandit is not detecting un-used variable inside a nested try /except block
To Reproduce
Steps to reproduce the behavior:
Example:
try:
   print 'try1'
   try:
       print 'try2'
   except Exception as ex:
       print 'Got exception try2'
 except Exception as e:
     print 'Got exception try1'

Bandit captures that e as unused variable but not capturing ex
Expected behavior
Unused variable with-in nested try/except blocks should also be captured.
Bandit version
bandit                        1.4.0 [ Centos 7 ]

Additional context
Add any other context about the problem here.

So bandit will test try-except blocks that have a pass or continue in the exception handling.  It doesn't do anything to detect unused variables.  What bandit error/warning are you referring to?  try_except_pass? try_except_continue?

In the above example am not using the exception catching variables ex and e . Bandit points out that the variable e  remains un-used as a medium severity. But my expectation here is that it will point out to ex as well so that in a huge legacy python file , it would be easy to identify the un-used variables.

Could you please include the output of what you're seeing? Thanks

Failing tests are the best kind if issue report! :) Consider writing this up as a unit test?

I think that use or not use the exception variables are not a security issue.
Do you mean that always on except clause should define a var and use it on the body?
I suppose you talk about only for generic exceptions.
However, in any case, you could manage this error using the log.exception on logging lib or traceback module to manage the exception without any security issue.

Closing due to inactivity.  And I believe the problem reported is outside the scope of Bandit.


Process Review Summations

When a review summation comes in, we have to set the isPassing attribute depending of whether its a passing score or not

We need to listen on the notifications.autopilot.events topic in kafka. A sample payload in this event looks like:
{
  "date": "Wed Aug 22 09:27:49 EDT 2018",
  "projectId": 30069254,
  "phaseId": 942767,
  "phaseTypeName": "Appeals Response",
  "state": "END",
  "operator": "22841596"
}

When the Appeals Response phase ENDs, we need to process the event. Everything else is ignored.
This might need a processor of its own, since we may have to use the Submission API itself to update values. Using the submission processor might not make sense in such a case since this processor is meant to come after the api

@cwdcwd @BadalZ Do we need to only determine isPassing here, or do we need to prepare the complete Review Summation data itself, where we will get all submissions, their reviews, aggregate the scores and save the review summation?

Closing. This is being taken up in https://github.com/topcoder-platform/submission-scoring-processor/issues/1


undefined is not an object (evaluating 'RNSound.IsAndroid')

Hi,
I run react-native expo and IPhone X emulator on MacOS  but I keep getting
"undefined is not an object (evaluating 'RNSound.IsAndroid')" error on emulator IPhone X.
Can anyone help please with that issue?

react-native-cli: 2.0.1
react-native: 0.55.4
react-native-sound: 0.10.9

I'm running into this exact same issue and all I have is
var Sound = require('react-native-sound')

You need to link your library. Use "react-native link react-native-sound"

AilsonFreire, I have checked that option, no effect.

I too faced this problem. 'react-native link react-native-sound' didn't work for me
I managed to resolved this error by following the manual linking steps

A solution which worked for me :

check the manual installation
remove node_modules
yarn install
rebuild & install android package

Have you tried to install Pods after linking?

This is happening for me, and my project is iOS only. Running on my iPhone X.

It might be something related to permissions, I managed to solved by adding permissions to Manifest in android folder, using the next line of code.
<uses-permission android:name="android.permission.RECORD_AUDIO" />
But I am not sure about Expo implementation, do not know if it comes configured out the box. Go check [react-native-sound](https://www.npmjs.com/package/react-native-audi
o) npm package read me description.

Udbhav12, how you managed to resolve that issue, could you please describe the manual linking steps?

have you find any solution & resolve the issue ?

I have the same problem on android.
I did a manual installation of the package.

I am resolved this issue by manually link library in X code, actually i did react-native link that is not giving any error so assume it's linked but when i have checked xcode then see this library is not linked so when i have linked manually and create new build then it's working perfectly.

If you're still having this problem, could you please post a link to a project that reproduces the problem, give information about your environment, and say what steps you have already tried?
This is the most common issue faced by react-native-sound users and it would be good to add documentation listing the possible resolutions. A pull request would be welcome; I've opened #592 to track that.


numpy calls interfere with external code in nopython=True functions

System

conda python 3.7 with:

llvmlite 0.27.0-py37hd408876_0 --> 0.28.0-py37hd408876_0
numba 0.42.0-py37h962f231_0 --> 0.43.0-py37h962f231_0

Tested on Fedora and Ubuntu 18.04

Minimal example
import numba
import numpy as np

@numba.jit(nopython=False)
def cross_issue(a=None):
    if a is None:
        a = 1
    np.sum([1, 2, 3])
    return a

print(cross_issue())

Expected result

after the if statement a should be 1, however the function returns None.
The behavior doesn't show up if the call to np.sum is removed. The weird behavior is also present with other functions (I originally discovered it with np.cross and saw it with np.mean too).
I have honestly no idea how this even can be or how to debug it. Suggestions are welcome.

I forgot to mention, the above code works fine in numba 0.42.0 and 0.41.0.

Thanks for the report. What you are seeing is most likely due to this bug: https://github.com/numba/numba/issues/3879 which was fixed here: https://github.com/numba/numba/pull/3883, the recently released Numba 0.43.1 fixes this problem, perhaps try updating your Numba installation:
conda install numba=0.43.1

Yeah 0.43.1 fixed this. Sorry didn't find the other issue. I will close this then.

@cosama great, thanks for confirming.


Add missing symbols in Fcntl.Oflags.of_code

There were a few symbols missing from the definition of Fcntl.Oflags.of_code (7761d52).
I've also reordered the fields of Fcntl.Oflags.defns to match the order of the constructors in Fcntl.Oflags.t, and updated the various functions that operate on those types similarly (192dc28).

I must be dreaming.

This looks like it fails due to ocaml/ocaml-ci-scripts#93.


Add react-ts template

Would be useful to have a predefined template based on a create-react-app with out-of-the-box support for typescript

Actually, after I managed to monkeypatch the typescript support to the react template in my local environment, I realized that this task isn't that complicated and I created a PR for it :)


FC094 fires on chef12 but shouldn't

FC094 is designed to get people to move away from filesystem2 in chef13 now that filesystem is the same... but it currently fires for Chef12 (-c 12.21.26, -c 12.13.37 etc) which is both incorrect and dangerous.

We don't use the -c version to control which rules are active at all, that's handled via tags. Though if someone wants to send a PR for auto-controlling the chefN tags with that CLI option too, I would be down.

I'd like us to get a bit smarter about how we handle versions. Using the CLI to do the right thing would be helpful.


Restore default clear color after displaying boot splash

On Android the boot splash can be shown at a different time, so the clear color restore needs to happen within the setup_boot_logo function
When there is no boot splash logo, we alter the default clear color to application/boot_splash/bg_color. It needs to be reset after.
When there is no environment in the scene, the default clear color is used as the ambient light color. Therefore, in the MRP the entire scene became darker because there was no boot splash logo!
Fixes: https://github.com/godotengine/godot/issues/94225
CC @m4gr3d

Thanks!


Coalesce arena create/first alloc for grpc_call.

BM_CallCreateDestroy                                    496ns ± 1%              484ns ± 1%   -2.49%        (p=0.000 n=19+20)
BM_CallCreateDestroy                                        460ns ± 0%              446ns ± 0%   -2.99%        (p=0.000 n=18+20)
BM_LameChannelCallCreateCpp                                            3.92µs ± 1%             3.81µs ± 1%   -2.84%        (p=0.000 n=18+17)
BM_LameChannelCallCreateCore                                           3.28µs ± 1%             3.18µs ± 0%   -2.90%        (p=0.000 n=20+20)
BM_LameChannelCallCreateCoreSeparateBatch                              3.67µs ± 1%             3.54µs ± 1%   -3.37%        (p=0.000 n=19+20)
BM_IsolatedFilter<NoFilter, NoOp>                                       14.8ns ± 0%             14.8ns ± 0%   +0.09%        (p=0.013 n=18+20)
BM_IsolatedFilter<DummyFilter, NoOp>                                    17.5ns ± 0%             17.6ns ± 0%   +0.79%        (p=0.000 n=19+20)
BM_IsolatedFilter<ClientChannelFilter, NoOp>                            40.5ns ± 1%             40.7ns ± 1%   +0.53%        (p=0.003 n=20+17)
BM_IsolatedFilter<ClientDeadlineFilter, NoOp>                           24.7ns ± 1%             24.5ns ± 2%   -0.81%        (p=0.000 n=20+20)
BM_IsolatedFilter<ServerDeadlineFilter, NoOp>                           24.6ns ± 1%             24.5ns ± 1%   -0.60%        (p=0.002 n=19+20)
BM_IsolatedFilter<ServerDeadlineFilter, SendEmptyMetadata>              28.9ns ± 2%             30.3ns ± 1%   +4.63%        (p=0.000 n=20+20)
BM_IsolatedFilter<HttpClientFilter, NoOp>                               29.5ns ± 0%             29.6ns ± 0%   +0.23%        (p=0.007 n=19+17)
BM_IsolatedFilter<MessageSizeFilter, NoOp>                              27.0ns ± 0%             27.2ns ± 1%   +0.47%        (p=0.000 n=16+20)
BM_IsolatedCall_NoOp                                                     462ns ± 0%              445ns ± 0%   -3.58%        (p=0.000 n=19+19)
BM_IsolatedCall_Unary                                                  3.31µs ± 5%             3.12µs ±10%   -5.80%        (p=0.000 n=18+20)

To be clear, those results are with the other two arena PRs as well (including the aligned_alloc one that isn't merged). So it's not just from these changes alone.


Implement connectionStatus.isChecking

Requires up for #13.
connectionStatus.isChecking

Read-only like connectionStatus.ok. Returns true if connection is checked continuously, otherwise false. The state is persisted in cache.

[x] claim this issue (comment below)
[x] start a pull request
[x] write tests
[x] implement
[ ] update README
[ ] review & merge

Ping me in the Hoodie Chat or on Twitter if you have any questions

Will take once #13 / #19 is merged

done via https://github.com/hoodiehq/hoodie-client-connection-status/pull/26


%+% should allow changing data

Hi.
In ggplot, 'adding' a dataframe to a plot with '%+%' serves to change the data underlying the plot.
Could this be made to work as well with flowSet/flowFrame and friends?

The idea of %+% operator for data.frame in ggplot is to switch to new data without re-typing of the previous ggplot constructor and all the layers.
However, in ggcyto, a great deal of  preprocessing jobs are done during these very initial plot building steps (i.e ggcyto constructor and its overloaded + operator)
These preprocessing steps are pretty data-denpendent, e.g.fuzzy-lookup for the partial marker or channel names, extracting gates and stats from the data for geom_gate and geom_stats layers, etc...).
One way of implementing this is to store all the initial constuctor and layers somewhere before preprocessing them and then repeat the same process behind the scene once %+% is invoked.
But we will have to think more about this since it won't be as simple as replacing the underlying data.frame like ggplot does.

Understood - thanks for considering my request.  It really is quite useful
syntactic sugar.

@malcook , feel free to try it out


Ability to include and adjust image in Perl 6 notebook

Currently image can be easily embedded in the notebook in markdown cell with
![title](img/picture.png). The demerit of this approach is inability to adjust the size of image.
In python notebook, image can be embedded in code cell with code:
from IPython.display import Image
from IPython.core.display import HTML
Image(url= "http://my_site.com/my_picture.jpg", width=100, height=100)

Can it be done in Perl 6 notebook similarly?

Hi sumandoc --
Yes, is the Python generating HTML with an image tag?   You can emit HTML from the Perl 6 kernel, like this:
#% html

'<img src="https://perl6.org/camelia-logo.png" width=100 height=100>'


[WIP] Init e2e framework

What problem does this PR solve?
E2e framework initialization. Need to add document about it.
What is changed and how does it work?
Check List
Tests

Unit test
E2E test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has Go code change
Has CI related scripts change
Has Terraform scripts change

Side effects

Breaking backward compatibility

Related changes

Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

Codecov Report

Merging #322 into master will decrease coverage by 1.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage   60.34%   59.23%   -1.12%
==========================================
  Files          44       42       -2
  Lines        2890     2556     -334
==========================================
- Hits         1744     1514     -230
+ Misses       1026      942      -84
+ Partials      120      100      -20

Impacted Files
Coverage Δ

pkg/utils/selector.go
53.36% <0%> (-6.41%)
:arrow_down:

pkg/chaosdaemon/util.go
76.25% <0%> (-6.19%)
:arrow_down:

pkg/utils/chaosdaemon.go

controllers/timechaos/types.go

pkg/chaosdaemon/time_server.go
100% <0%> (+5.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e21756...1042fc7. Read the comment docs.

@YangKeao PTAL

/merge


Updated footer

Added the copyright in the footer.

There have some conflict issues check it once. @LunaNika

There have some conflict issues check it once. @LunaNika

Yeah I will check it.


Add custom contents to expanded node

I have created a tree with custom views (specifically Angular Material Design views) that are being show when the tree is expanded using Angular UI Tree. That tree does not scale at all, however, so at about 500-600 nodes the tree became unusable. Therefore I am trying out this tree instead, but I cannot figure out if there is a way to add custom views/HTML inside the tree.
Could you please advise on whether this is possible and, if so, some best practices to achieve this?
I have set up the simple case on your Github page for testing. The HTML is now like this:
<treecontrol tree-model="dataForTheTree" options="treeOptions" on-selection="showSelected(node)" selected-node="node1" class="tree-classic">Employee: {{node.name}} age {{node.age}}
    <md-content>trollolol
        <md-button class="md-fab"></md-button>
    </md-content>
</treecontrol>

which is stupid, but you get the idea. The output looks like this:

Here is an example of an existing working tree, using Angular UI Tree, that is painfully slow. This tree has the "ui-tree-handle" directive to insert into divs and other items, which enables us to insert HTML and what not.

Hi oysteinmyrmo,
Have you ever solved this? Or did you use another library?
Regards,
Thomas


Added Contravariant instance for Output

Hi Gabriel, great work on the Pipes.Concurrency.
I find it really interesting that Pipes's (Output, Input) is equivalent to elms' Mailbox of (Address, Signal).
Elm has an api called forwardTo which is actually flip contramap.
So I added a contravariant instance for Output so it can be used in a similar way.
Cheers,
Louis

Looks good!   Thanks :)


Buy per app in M365 Admin Center or not?

There is a blue box tagged as Important that says "Power Apps per app plans don't appear on the Billing > Licenses page in the Microsoft 365 admin center" Then Step one says "You can purchase per app plans from your sales channel or in the Microsoft 365 admin center" Both of these can't be true? How can I allocate licenses that I can't buy?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0f1f9ece-05b6-907c-9d52-5a19f5bf9872
Version Independent ID: 9eaed30a-4c07-ef03-e3b4-d3db9989a760
Content: About Power Apps per app plans - Power Platform
Content Source: power-platform/admin/about-powerapps-perapp.md
Service: power-platform
Sub-service: admin
GitHub Login: @alaug
Microsoft Alias: alaug

Ok, I get it. One says you can't see / manage the licenses and the other says you can buy. In my defense they per user and per app licenses are in totally different places. Why?

Thanks for your comment, @hoyty76. This issue has been assigned to the doc author for review.


/help command will not work while using luckperms and nucleus

Does anyone know why I do not have permission to the /help command?

Because you haven't added the right permission node to yourself?
Use verbose to find the node you need to add to yourself.

Because you haven't added the right permission node to yourself?
Use verbose to find the node you need to add to yourself.

It says Minecraft.command.help is set to "TRUE" under the permission

Sponge overrides the Minecraft help command with it's own. A detailed list of sponge commands can be found in their documentation https://docs.spongepowered.org/stable/en/server/spongineer/commands.html. This shows that the permission node for the help command is sponge.command.help
For future reference, as Laarryy stated you can use the LuckPerms verbose command to assist you in identifying the permission you are lacking.

Sponge overrides the Minecraft help command with it's own. A detailed list of sponge commands can be found in their documentation https://docs.spongepowered.org/stable/en/server/spongineer/commands.html. This shows that the permission node for the help command is sponge.command.help
For future reference, as Laarryy stated you can use the LuckPerms verbose command to assist you in identifying the permission you are lacking.

I don't even have access to /sponge:help in game and I cannot activate it in the console


Added some youtube methods

The Youtube API recently released these 2 methods for getting and settings modules like subtitles. It would be amazing if you can add them to your library.
Thanks!

Roman, thats the compiled file, you should modify the source file, I'll do the comipilation if you want


Update thrift v0.16 and vendor parquet-format (#2502)

Which issue does this PR close?

Closes #2502
Rationale for this change

See ticket
What changes are included in this PR?

Vendors the generated thrift code, and updates to thrift v0.16. Unfortunately thrift no longer generates enumerations, instead generating constants. This requires some churn in the conversion logic, and making some things fallible that previously weren't.
Are there any user-facing changes?
Yes, although only to the low-level interfaces.

🎉


deepdream issue

Hi,
I got activation_visualization running. But deepdream has error at _write_deepdream().
is_success = activation_visualization(sess_graph_path = self.session, value_feed_dict = {self.input_placeholder : im},
layers=layers, path_logdir=os.path.join("Log","MyModelfromMeta"),
path_outdir=os.path.join("Output","MyModelfromMeta"))
But the deepdream_visualization has error. I am using tensorflow 1.10. (I got few deprecation warnings on
is_success = deepdream_visualization(sess_graph_path = self.session, value_feed_dict ={self.input_placeholder:im}, layer="softmax_tensor",
classes = ['label1', 'label2', 'label3'], input_tensor=None, path_logdir='./Log', path_outdir='./Output')
script: tf_cnnvis\utils.py line 195. _write_deepdream.
imsave(os.path.join(path_out, "image_%d.png" % (units[(i * images[i].shape[0]) + j + k])), img_save, format = "png")
TypeError: %d format: a number is required, not str
Deprecation warnings for utils.py 👎
calling reduce_mean (from tensorflow.python.ops.math_ops) with keep_dims is deprecated and will be removed in a future version.
Instructions for updating:
keep_dims is deprecated, use keepdims instead
Traceback
Thanks in advance,
Ishwar

Hi!
You need to pass in the class numbers as list of integers - so in the above case, the input would be something like classes=[0,1,2]. Doing this should resolve your issue.
Also, thank you for bringing this to our notice- we'll update the documentation a bit and also add a check for this in the code.
Thanks!


Store Spotify and Twitch Oauth 2.0 client id and client secret in settings

These are currently stored in secrets.yaml.
Will also need a web-based flow to input these if they aren't set.

Done.


V4- sparky src/dist - bug ?

If I have a sparky task script file inside folders it does not work as expected.
Best behavior would be if it used scripts location as basepath for src and dest.
Ready to test version of script is here
https://github.com/vegarringdal/bug-4
scripts

npm run copy-bug1
npm run copy-bug2
npm run copy-hack

const PATH = process.argv[3];
if (PATH) {
  process.chdir(__dirname);
}

const { sparky } = require("fuse-box");
class Context {}
const { task, src } = sparky(Context);

task("copy-bug1", async context => {
  // expected behavior would be that this uses script location "_dirname" as basepath on both
  // with this one nothing happend because it does not find any files
  await src(`./src/**/*.*`)
    .dest(`./dist/ts`, `src`)
    .exec();
});

task("copy-bug2", async context => {
    // this will find files
    // but it will break and say it cant find file under :
    // .... package/cool/package/cool/src/index.ts
    // looks like it adds _dirname to the src path
    await src(`./package/cool/src/**/*.*`)
      .dest(`${PATH}/dist/ts`, `src`)
      .exec();
  });

task("copy-hack", async context => {
  await src(`./src/**/*.*`)
    // supply it with path './package/cool'
    .dest(`${PATH}/dist/ts`, `src`)
    .exec();
});

closing

@vegarringdal sorry did you get it resolved? ;-)

I though I just messed up so removed it.
But now when I test more it looks like something goes very wrong when my file with the task in not on root where npm gets run from

or Im just very tired messing up

@nchanged
Is this understandable ?

// script gets started from "npm start"
// this runs : node ./package/cool/tasks copy-now

const { sparky } = require("fuse-box");
class Context {}
const { task, src } = sparky(Context);

// unless I have this it fails
process.chdir(__dirname);

task("copy-now", async context => {
  await src(`./src/**/*.*`)
    .dest('./package/cool/dist/ts', `/src/`)
    // the dest() is not behaving like I expected, its like its not following process.cwd() or __dirname
    // but unless I set process.cwd() to __dirname it wont copy, but I still haveto use npm base ?
    .exec();
});

@nchanged
Im making a new sample repo so you can confirm if Im going crazy 😂

@nchanged
Tried to make a simple sample
https://github.com/vegarringdal/bug
Is this working like intended?
For me the behavior is messing up when not on root of project
clone and npm install

git clone https://github.com/vegarringdal/bug
npm install

Then run these scripts, then look into source of the first 2

npm run working1 runs : "node ./tasks working1"
npm run working2-but-weird runs : "node ./package/cool/tasks working2-but-weird"
npm run failing-but-why runs : "node ./package/cool/tasks failing-but-why"

fixed


Issues with bools in the frontmatter not working as expected

Hello! Im just getting started using tracker and it is extremely powerful. However I've found that I'm limited in some of my usecases because I would like to have track my habits in my daily notes with bools as opposed to numbers. Like read: false.
As far as I've been able to underatand (at least for the month type) frontmatter and dvFields only supports numeric values, and would otherwise need to map their text to specific values using textMap. While this is fine, it would be nice if there was an option to allow True and False values to automatically map to 1 and 0 respectively.
If I'm missing something let me know! ATM I'm using the text target option as a work around (searching for 'read:: [tT]rue') but I will try the text mapping soon.
Thanks, and I hope this issue was appropriate to open!

Oh huh, just discovered some odd behavior(?)
When assigning true to a bool value in my frontmatter and attempting to use textValueMap to map True to 1 and False to 0,  it returns the error No valid Y value found in notes
However doing the same with dvField works exactly as I had hoped.
Removing the textmap doesn't help, neither does assigning a default const. For some reason it's just refusing to read the bool as text in the front matter?
If I add on additional information (such as read: True, 1) and access it with read[0], then I'm able to map True to 1.
I'm not sure what's going on? Here's my code for both
frontmatter:
searchType: frontmatter
searchTarget: read
datasetName: Finished Daily
folder: Daily Notes
fitPanelWidth: True
textValueMap:
    '[fF]alse': 0
    '[tT]rue': 1

month:
    startWeekOn: 'Mon'
    color: tomato
    headerMonthColor: peach
    dimNotInMonth: false
    todayRingColor: orange
    selectedRingColor: steelblue
    showSelectedValue: true

and the (working) dvField version
searchType: dvField
searchTarget: drew
datasetName: Draw Habit
folder: Daily Notes
fitPanelWidth: true
textValueMap:
    '[fF]alse': 0
    '[tT]rue': 1

month:
    startWeekOn: 'Mon'
    color: LightPink
    headerMonthColor: LightPink
    dimNotInMonth: true
    todayRingColor: peach
    selectedRingColor: purple
    showSelectedValue: true

I'm starting to feel there's something i'm missing, I will change the title to reflect this

Ah I see! That makes a lot of sense hahaha
I think just parsing the boolean values as 0 and 1 would be fine, since many languages will do that if they are converted to integers anyway! Then the user can manipulate the numbers as needed after the case, or just use them straight out of the box. That's just my reasoning however!

I would agreed with the parsing of dvField boolean into 0/1 as I have had to use the text mapping to be able to use my dvField in a calendar as well.

I concur it would be good to add it since it could work well with the Database Folder plugin that make it easy to create checkboxes but this plugin will only use boolean values. Therefore combining this plugin with Tracker is not possible right now.

I agree with Fenntasy. I would like to be able to use DB Folder along with Tracker and figure out a way for Tracker to possibly use the bool values from DB Folder.

would love to see an update here!


etcd server lease timeout occasionly

There is a product on cloud that I am testing which uses etcd.
Recently met etcd server lease timeout issue frequently without any call load.
The etcd client refresh the etcd key lease every 5 second to ensure that the client etcd key is not expired, the key of the etcd client is one single record in etcd.
However, for uncertain reason, etcd lease timeout, see below etcd log and metrics
could you please comment why etcd timeout for single entry lease and any method resolve this issue?
There is no any call load running and the CPU occupy is not high (idle ~35%), 4 vCPU in total for all.
HELP etcd_debugging_server_lease_expired_total The total number of expired leases.
TYPE etcd_debugging_server_lease_expired_total counter
etcd_debugging_server_lease_expired_total 390
HELP etcd_disk_backend_commit_duration_seconds The latency distributions of commit called by backend.
TYPE etcd_disk_backend_commit_duration_seconds histogram
etcd_disk_backend_commit_duration_seconds_bucket{le="0.001"} 13637
etcd_disk_backend_commit_duration_seconds_bucket{le="0.002"} 13653
etcd_disk_backend_commit_duration_seconds_bucket{le="0.004"} 13658
etcd_disk_backend_commit_duration_seconds_bucket{le="0.008"} 13666
etcd_disk_backend_commit_duration_seconds_bucket{le="0.016"} 13666
etcd_disk_backend_commit_duration_seconds_bucket{le="0.032"} 13666
etcd_disk_backend_commit_duration_seconds_bucket{le="0.064"} 13666
etcd_disk_backend_commit_duration_seconds_bucket{le="0.128"} 13666
etcd_disk_backend_commit_duration_seconds_bucket{le="0.256"} 13666
etcd_disk_backend_commit_duration_seconds_bucket{le="0.512"} 13666
etcd_disk_backend_commit_duration_seconds_bucket{le="1.024"} 13666
etcd_disk_backend_commit_duration_seconds_bucket{le="2.048"} 13666
etcd_disk_backend_commit_duration_seconds_bucket{le="4.096"} 13666
etcd_disk_backend_commit_duration_seconds_bucket{le="8.192"} 13666
etcd_disk_backend_commit_duration_seconds_bucket{le="+Inf"} 13666
etcd_disk_backend_commit_duration_seconds_sum 2.3070954790000044
etcd_disk_backend_commit_duration_seconds_count 13666
2018-07-03 00:38:11.992380 W | etcdserver: apply entries took too long [246.755688ms for 1 entries]
2018-07-03 00:38:11.992474 W | etcdserver: avoid queries with large range/delete range!
/ # etcd --version
etcd Version: 3.2.7
Git SHA: 9ce8513b6f
Go Version: go1.8.3
Go OS/Arch: linux/amd64

lease timeout issue frequently without any call load

Do you mean leases are being expired while sending keepalive requests?

i do not know how to check the question's answer, but from etcd log and etcd metric, etcd side is ubnormal.
etcd_debugging_server_lease_expired_total 390
2018-07-03 00:38:11.992380 W | etcdserver: apply entries took too long [246.755688ms for 1 entries]
2018-07-03 00:38:11.992474 W | etcdserver: avoid queries with large range/delete range!

Those warnings keep happening? Can you also provide fsync metrics? You can just curl ENDPOINT | grep fsync.

Those warnings do not keep happen. However, lease timeout keeps happen.
HELP etcd_debugging_server_lease_expired_total The total number of expired leases.
TYPE etcd_debugging_server_lease_expired_total counter
etcd_debugging_server_lease_expired_total 224
HELP etcd_disk_wal_fsync_duration_seconds The latency distributions of fsync called by wal.
TYPE etcd_disk_wal_fsync_duration_seconds histogram
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.001"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.002"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.004"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.008"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.016"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.032"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.064"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.128"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.256"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.512"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="1.024"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="2.048"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="4.096"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="8.192"} 9280
etcd_disk_wal_fsync_duration_seconds_bucket{le="+Inf"} 9280
etcd_disk_wal_fsync_duration_seconds_sum 0.02352618800000004
etcd_disk_wal_fsync_duration_seconds_count 9280

Hmm, latency numbers look good, which means it should be from something else.

etcdserver: avoid queries with large range/delete range!

Can you try trigger this warning again? By sending similar requests to etcd server?

I will also improve the warning messages.

Can you try trigger this warning again? By sending similar requests to etcd server?
=>Not yet, this warning log does not occur again so far, but lease timeout still exist.

well, I mean ...number of all leases , not of "expired lease".

so you want to know the number from all clients? can this be seen in etcd metric?

yep, value of "sum(grpc_server_started_total{grpc_service="etcdserverpb.Lease",grpc_type="bidi_stream"}) - sum(grpc_server_handled_total{grpc_service="etcdserverpb.Lease",grpc_type="bidi_stream"})".

Thank you. Here is the metric, i do not know how to caculate for 1.xxxxxxxe+06
grpc_server_started_total{grpc_method="LeaseKeepAlive",grpc_service="etcdserverpb.Lease",grpc_type="bidi_stream"} 1.734624e+06
grpc_server_handled_total{grpc_code="Canceled",grpc_method="LeaseKeepAlive",grpc_service="etcdserverpb.Lease",grpc_type="bidi_stream"} 712
grpc_server_handled_total{grpc_code="OK",grpc_method="LeaseKeepAlive",grpc_service="etcdserverpb.Lease",grpc_type="bidi_stream"} 1.129258e+06
grpc_server_handled_total{grpc_code="Unavailable",grpc_method="LeaseKeepAlive",grpc_service="etcdserverpb.Lease",grpc_type="bidi_stream"} 604648
grpc_server_handled_total{grpc_code="Unknown",grpc_method="LeaseKeepAlive",grpc_service="etcdserverpb.Lease",grpc_type="bidi_stream"} 6

「Are they all of leases keepalive? and how many clients to keepalive that?」 ？？？

I guess so, there is only LeaseKeepAlive method which meets your listed caculation:
grpc_service="etcdserverpb.Lease",grpc_type="bidi_stream"
The number of total clients would not be too many, <10? i do not know the actual number. As I know the client that I find frequently meet timeout sends lease request every 5seconds to etcd server.
What do you doubt?
HELP grpc_server_started_total Total number of RPCs started on the server.
TYPE grpc_server_started_total counter
grpc_server_started_total{grpc_method="DeleteRange",grpc_service="etcdserverpb.KV",grpc_type="unary"} 44
grpc_server_started_total{grpc_method="LeaseGrant",grpc_service="etcdserverpb.Lease",grpc_type="unary"} 238
grpc_server_started_total{grpc_method="LeaseKeepAlive",grpc_service="etcdserverpb.Lease",grpc_type="bidi_stream"} 1.734624e+06
grpc_server_started_total{grpc_method="LeaseRevoke",grpc_service="etcdserverpb.Lease",grpc_type="unary"} 1
grpc_server_started_total{grpc_method="LeaseTimeToLive",grpc_service="etcdserverpb.Lease",grpc_type="unary"} 1.492175e+06
grpc_server_started_total{grpc_method="MemberList",grpc_service="etcdserverpb.Cluster",grpc_type="unary"} 21037
grpc_server_started_total{grpc_method="Put",grpc_service="etcdserverpb.KV",grpc_type="unary"} 329
grpc_server_started_total{grpc_method="Range",grpc_service="etcdserverpb.KV",grpc_type="unary"} 4.703231e+06
grpc_server_started_total{grpc_method="Txn",grpc_service="etcdserverpb.KV",grpc_type="unary"} 2784
grpc_server_started_total{grpc_method="Watch",grpc_service="etcdserverpb.Watch",grpc_type="bidi_stream"} 166
HELP http_request_duration_microseconds The HTTP request latencies in microseconds.


fix when use function Cache::tags, can't find tags function in class FileStore

This PR aims to fix a bug below:

configure default cache driver is file in config/cache.php;
use Illuminate\Support\Facades\Cache::tags function, will throw a exception: This cache store does not support tagging.

This bug not only exist in version 5.1,  but also exist in versions 5.2, 4.2 .

The docs state that tags aren't supported by the file driver.


Typescript: find TYPE references when using external modules

Copied from: https://code.visualstudio.com/Issues/Detail/19804
When using external modules in typescript, in my case CommonJS modules, I would expect "Find all references" to find where a given TYPE is used all over the project, not only in the current file.
It works with methods, which means the code for resolving external modules is already there, but it does not work for TYPES, when the cursor is on the name of the class in the class definition.
It also does not work on the constructor.
For example, given the following code :
File MyClass.ts
export = MyClass;
class MyClass {
 constructor(public val:number) {}
 doSomething() {}
}

File Other.ts
import MC = require('./MyClass');

var typed :MC;
var built = new MC(3);

built.doSomething();

From inside MyClass.ts :

When cursor is on "doSomething", SHIFT+F12 correctly reports usage in Other.ts
When cursor is on "constructor", SHIFT+F12 reports nothing
When cursor is on "MyClass", SHIFT+F12 reports usage inside MyClass.ts but not in other files

find all references implementation does not handle aliases. so if you search for an identifier, it will only find things with the same name, if you alias it, aliased symbols it will not be found, a separate search will need to be requested.
For export= we can do better, when searching for a symbol, we can look if it is the same as export= symbol for the current module, search for the module import.

find all references implementation does not handle aliases

I find it kind of odd that FindAllRefs doesn't deal with the original declaration for an alias. It would be useful if a user didn't need to find references to every alias as well as the originating declaration.

the main reason is to limit noise. if you have an import, and you hit find all refs, you probably do not want to see all other aliases to the same entity in other files.
i do not think there is an objective reason here why it should or should not work. i would be open to trying the experience out and seeing what can be done.

Closing as out of date


npm run testdoc pauses

When I run a test doc test, it unexpectedly pauses at the end.
I have to hit enter before my prompt returns.
if I have an echo at the end, that doesn't show until afterwards.
Is it somehow waiting for input?!?

Yes, doctest implicitly invokes the REPL
Welcome to the HCLang REPL!
.hc 0.5.1;
; #

set evaluated = true (and check before repl)

Fixed. And restores doc test coloring!


Update local path string

Description: The current localFolderPath points to an incorrect path. Correct it to use the C:\Users<user>\AppData\Local\Microsoft\WindowsAppSDK\
Validation:

Use the DemoApp to validate if the iconPath is pointing to the right folder.
Added a unittest and validated the contents of the folder.

/azp run

/azp run

There are some improvements we can do on this PR. Working on it.

/azp run

/azp run


fix: using the right type for Any paramenter

Fixing type hints for Any parameter.
Before

After

Can you check, please @asacristani  ?