5.6.3 release got updated by Scala-steward, but then, the project can not resolve it

[error] (update) sbt.librarymanagement.ResolveEx
ception: Error downloading de.heikoseeberger:sbt-header;sbtVersion=1.0;scalaVersion=2.12:5.6.3
[error]   Not found
[error]   Not found
[error]   not found: https://repo1.maven.org/mav
en2/de/heikoseeberger/sbt-header_2.12_1.0/5.6.3/sbt-header-5.6.3.pom
[error]   not found: C:\Users\Ehnalis\.ivy2\loca
lde.heikoseeberger\sbt-header\scala_2.12\sbt_1.0\5.6.3\ivys\ivy.xml
[error]   not found: https://repo.scala-sbt.org/
scalasbt/sbt-plugin-releases/de.heikoseeberger/sbt-header/scala_2.12/sbt_1.0/5.6.3/ivys/ivy.xml
[error]   not found: https://repo.typesafe.com/t
ypesafe/ivy-releases/de.heikoseeberger/sbt-header/scala_2.12/sbt_1.0/5.6.3/ivys/ivy.xml

Using sbt.version = 1.6.2

It is still not resolvable on my side. Am I missing a resolver?

Now 5.6.5 should be on (its way to) Maven Central.


Update Japanese localization on concepts/containers/runtime-class.md

What this PR does / why we need it:
content/ja/docs/concepts/containers/runtime-class.md is outdated.
File to update
https://github.com/kubernetes/website/tree/dev-1.19-ja.1/content/ja/docs/concepts/containers/runtime-class.md
Original
https://github.com/kubernetes/website/tree/release-1.19/content/en/docs/concepts/containers/runtime-class.md
diff between translated and v1.19
https://gist.github.com/ec82eac56ea84abe575db1408ab0b4c1
Which issue(s) this PR fixes:
#26865
NOTE
Regarding /docs/concepts/scheduling-eviction/pod-overhead/, I can't find Japanese doc, so I keep this English link.

/assign @nasa9084

/lgtm


Upscaling doesn't work due to additional string from Midjourney

Hi Oussama,
I opened this issue as you asked for raising the current issue with Midjourney Upscaling feature.
Till now, as you told me, the following data payload was required for generating new Upscale interaction requests:
"custom_id":f"MJ::JOB::upsample::{index}"
When I tried to run this code I encounter a problem due to the fact that probably Midjourney included another piece of information that required for the payload. This string (red) is a specific identifier that represents an image that was created with /imagine command.
Notice that all 4 images that were generated by th /imagne / /mj_imagne command shared the same string

fixed


[WIP][DONT REVIEW] Incremental cloudrun deployment exp

This is experimental PR, assign to myself so prow doesn't auto assign
/cc chaodaiG
/assign chaodaiG

/test pull-en-server-release-e2e-canary

/test pull-en-server-release-e2e-canary

/test pull-en-server-release-e2e-canary

/test pull-en-server-release-e2e-canary

/close


Add Travis testing

Perhaps taking inspiration from https://github.com/akka/akka-management/pull/329

Done in #7


DOC-3754: Added instructions for upgrading a node to a minor version.

Does this link work?
https://software.r3.com/artifactory/webapp/#/artifacts/browse/simple/General/corda/net/corda/corda-node
It shows blank page. You gotta search for Corda.
I use this link: https://software.r3.com/ui/packages/gav:%2F%2Fnet.corda:corda

@peterli-r3 Good spot. I'll substitute with your link. Thanks!


Openstack hypervisor should use a random keypair when none is provided

I can create a new keypair and associate it to the keyname to use for the VM with this simple patch:
--- a/lib/beaker/hypervisor/openstack.rb
+++ b/lib/beaker/hypervisor/openstack.rb
@@ -91,6 +91,10 @@ module Beaker
         if @options[:openstack_keyname]
           @logger.debug "Adding optional key_name #{@options[:openstack_keyname]} to #{host.name} (#{host[:vmhostname]})"
           options[:key_name] = @options[:openstack_keyname]
+        else
+          @logger.debug "Creating random keypair"
+          @compute_client.create_key_pair host[:vmhostname]
+          options[:key_name] = host[:vmhostname]
         end
         vm = @compute_client.servers.create(options)

But I can't figure out yet how to tell beaker to use the generated public key (neither were it is stored)

Our internal testing is not reliable right now.  Will retest once we are back up.

Merged, https://github.com/puppetlabs/beaker/pull/647


Upgrade docker to 0.9.5

Dockerfile target pgweb 0.9.4, while last version is 0.9.5.
Please upgrade docker file and publish the image.

Done


Python editor toolbar aligned to right after installing debugger

After installing the JupyterLab debugger
jupyter labextension install @jupyterlab/debugger

Looks like the extension added the css selector that brings our toolbar content to the right end
.jp-Document .jp-Toolbar {
    justify-content: flex-end;
}

I can add a fix for that

we might also want to report these to the JupyterLab debugger project @afshin

Thank you!


Update information about Serokell

Serokell is based in France nowadays:
https://www.societe.com/etablissement/serokell-ou-92058198000025.html

lgtm


Windows 10, Python37, Atom test_source not running

Hey,
i am in the process of setting up my FORTRAN IDE in Atom. Unfortunately the fortls seems not be running in my case. I installed Python37 and the fortran-language server with pip. In Atom i set the path of the executable to ..\AppData\Local\Programs\Python\Python37-32\Lib\site-packages\fortls_init_.py. When I am adding the test_source no and opening the outline dialog I am getting the error msg 'No outline available' although a popup is indicating that fortls is running before. Do I miss smth?
Python 37
Fortranlanguageserver 9.2 (via pip)
atom-ide-ui 0.13.0
ide-fortran 0.30
language-fortran 2.1.7

Thanks for the report. The __init__.py script is not the same as the executable and it should not be called directly. If you installed the language server using pip then a command called fortls.exe should have also been installed in the Python scripts directory. This directory is usually something like C:\Python37\Scripts. You can also find the scripts directory by looking in the directory containing the Python interpreter.

Thank you so much. Did not expect such a fast answer. This is a realy usefull tool for every FORTRAN developer.
This was the mistake the correct path is:
c:\Users\<USER>\AppData\Local\Programs\Python\Python37-32\Scripts\fortls.exe

No problem, I'm glad you like it!


Generate valid machine input lists on game load rather than on tile instantiation

NuclearCraft-2.13--1.12.2

Sorted for the next version :)


Resource destruction and memory recycling

Link
I am sorry I was not able to create a topic on the forum because I failed to upload  a picture, which was seemed to be required.

Feature description：
When I created a scene, I added some models and effects (like reflections with ReflectionProbe, and linked some meshes to them).
After I had unlinked the linked meshes from the probes, and disposed any meshes and probes, I found out that not all of the data had been destroyed, as well as some Matrixes, UniformBuffers, and so on. They were still held by some private properties like '_renderingTarget'.

Do you have any idea of 'clear' the cache when mesh or a probe is disposed?

Hello, could you provide a repro on our playground?
Technically disposing meshes and probes should be enough

Well in your sample, I can see that you are not disposing the probes created by the generateSatellite function

And the UniformBuffer related to a mesh (or material?) cannot be disposed neither.

Hello Sherley,
If you call material.dispose, this line will be executed:
https://github.com/BabylonJS/Babylon.js/blob/master/src/Materials/babylon.material.ts#L1302
Can you provide a repro that highlights your issue?

Up?

Closing for now. Please reopen if needed :)


[Fix][UI Next][V1.0.0-Alpha] Fix the Workflow instance table action button is too small to click.

Purpose of the pull request
close #8720

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

LGTM

Codecov Report

Merging #8721 (cf8f12d) into dev (9c162c8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #8721   +/-   ##
=========================================
  Coverage     45.29%   45.29%
  Complexity     4073     4073
=========================================
  Files           700      700
  Lines         27050    27050
  Branches       2894     2894
=========================================
  Hits          12251    12251
  Misses        13645    13645
  Partials       1154     1154

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c162c8...cf8f12d. Read the comment docs.


ci: Added required 'packages: write' permission to Publish Snapshot workflow

What this PR changes/adds
Gives the "packages: write" permission to trigger_snapshot.yml .
Why it does that
Publish Snapshot Build workflow throws the following "The workflow is not valid. .github/workflows/trigger_snapshot.yml (Line: 11, Col: 3): Error calling workflow 'eclipse-edc/.github/.github/workflows/publish-snapshot.yml@main'. The nested job 'Publish-Snapshot' is requesting 'packages: write', but is only allowed 'packages: read'." message so relevant permission is given in the workflow file..
Linked Issue(s)
Closes # <-- _https://github.com/eclipse-edc/Technology-HuaweiCloud/issues/66_
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

it will be fixed by this PR:
https://github.com/eclipse-edc/.eclipsefdn/pull/26
this one can be closed


Unable to get result for async rpc calls

Describe the bug
When r.result() of an async method is called, I get a runtime error. I am using docker and docker-compose. I may be doing something obviously wrong, but I can't figure out what.
starting services: regular_checker, worker
Connected to amqp://guest:**@rabbitmq:5672//
error handling worker <WorkerContext [regular_checker.ping] at 0x7fe94214d430>: This consumer has been stopped, and can no longer be used
Traceback (most recent call last):
...
...
  File "./app.py", line 18, in ping
    results = [r.result() for r in results]
  File "./app.py", line 18, in <listcomp>
    results = [r.result() for r in results]
  File "/usr/local/lib/python3.8/site-packages/nameko/rpc.py", line 326, in result
    self.resp_body = self.reply_event.wait()
  File "/usr/local/lib/python3.8/site-packages/nameko/standalone/rpc.py", line 52, in wait
    raise RuntimeError(
RuntimeError: This consumer has been stopped, and can no longer be used

To Reproduce
I am using docker and docker-compose. To reproduce the error:
app.py
from nameko.timer import timer
from nameko.standalone.rpc import ClusterRpcProxy
from nameko.rpc import rpc
from nameko.runners import ServiceRunner
import logging

class RegularChecker:
    name = "regular_checker"
    @timer(interval=1)
    def ping(self):
        results = []
        for i in range(10):
            with ClusterRpcProxy(config={"AMQP_URI":"pyamqp://guest:guest@rabbitmq"}) as cluster:
                r = cluster.worker.sleep.call_async(i)
                results.append(r)

        # Wait for all results to finish
        results = [r.result() for r in results]
        logging.info(results)

class Worker:
    name = "worker"
    @rpc
    def sleep(self, number):
        import time
        time.sleep(0.5)
        return number

Dockerfile
FROM python:3.8.1
RUN pip install nameko
WORKDIR /src/

docker-compose.yml
version: "3.7"

services:
    rabbitmq:
            image: rabbitmq:3.7-alpine
    app:
        build: .
        volumes:
            - ./:/src/
        depends_on:
            - rabbitmq
        command: nameko run app --broker rabbitmq

command:
docker-compose run app

Expected behavior
The result gets returned without an error
Environment (please complete the following information):

Nameko version: 2.12.0
Python version: 3.8.1
OS: Manjaro Linux 19.0

Ok. I just realised that using RpcProxy instead of ClusterRpcProxy works.
So my app.py should have been:
from nameko.timer import timer
from nameko.standalone.rpc import ClusterRpcProxy
from nameko.rpc import rpc, RpcProxy
from nameko.runners import ServiceRunner
import logging

class RegularChecker:
    name = "regular_checker"
    worker = RpcProxy("worker") # <-- Changed this
    @timer(interval=1)
    def ping(self):
        results = []
        for i in range(10):
            r = self.worker.sleep.call_async(i) # <-- Changed this
            results.append(r)
        # Wait for all results to finish
        results = [r.result() for r in results]
        logging.info(results)

class Worker:
    name = "worker"
    @rpc
    def sleep(self, number):
        import time
        time.sleep(0.5)
        return number

Sorry for opening an issue without doing enough research. I will close it.


slog-nat

would be cool to ahem a slog-nats ?
Nats can do durable or non durable, which might be an interesting facet too.
NATS Server can also be embedded and run in Leaf mode, so might be interesting to see how we can leverage that.
If you interested let me know. Happy to work on this with you.

I made a v0.1 last weekend. Your feedback would be appreciated.
The handler receives an *nats.EncodedConn. I wonder if we should use a better abstraction.
-> https://github.com/samber/slog-nats

hey @samber
wow your quick !!
I am running it, and so far it works for me.
I will make issues over in that repo.


[New Feature] Edit sample rate

Describe the new feature you'd like
Edit sample rate through as-cmd parameter/option
example : as-cmd -b 192.168.x.x --sample-rate 96000
Describe the reason why you want to add the feature
Increasing sample rate may lower latency since default is 48000
Additional context
I tried changing pipewire.conf but as-cmd still reports 48000

Looking forward to this as latency can be quite the annoyance on certain scenarios.

Increasing sample rate can't lower lantency. It need more network traffic bandwidth, and may higher the latency. Instead, you need decrease the sample rate.

Looking forward to this as latency can be quite the annoyance on certain scenarios.
UPDATE: Here are some comparisons:

Phone is on a 5GHz 80Hz Wi-Fi and the PC is Wired: Very noticeable latency, probably over 15ms.
Phone is directly connected to the PC via USB (Using USB Tethering): ~5ms latency.

there is this "audio-sharing" app on flathub and it so much worse like 1 or 2 sec latency
this one here is much better
latency on videos is berable on 5 ghz wifi but you can't do gaming.

there is this "audio-sharing" app on flathub and it so much worse like 1 or 2 sec latency this one here is much better
Definitely! Unfortunately IIRC its Shareware and only works for 1h and its a pain to set-up :(

latency on videos is berable on 5 ghz wifi but you can't do gaming.
I was able to get decent latency (probably 2-3ms) by doing this

Setting Buffer to 1x
Connecting a USB Cable from the Phone to the PC using USB Tethering (Dont forget to disable Mobile Data)
Connect using the IP the Phone gave you (Check the Network settings, should be something like <IP_ADDRESS>)

Finished #88


overfitting

Hello, I used your code to run an experiment, but I encountered overfitting. The trained network performs well on the training set but very poorly on the test set.  I ran the experiment in experiments/lg/lstm_soc_percentage_lg.ipynb.

I suggest you to start with some common solution on overfitting, such as dropout, regularization, etc.


allow start_command key to be omitted

in cc staging response message

[#103337820]
Signed-off-by: Zach Robinson<EMAIL_ADDRESS>

Moved to top of Diego backlog for review.


Test ignition

Description
Please provide a brief description of the changes proposed in this Pull Request

Checklist

[ ] tested locally
[ ] updated any relevant dependencies
[ ] updated any relevant documentation or examples

API Changes
Are there API changes?

[ ] Yes
[ ] No

If yes, please fill in the below

Updated conversions?

[ ] Yes
[ ] No
[ ] N/A

Updated CRDs?

[ ] Yes
[ ] No
[ ] N/A

Updated infrastructure-components.yaml?

[ ] Yes
[ ] No
[ ] N/A

Updated ./examples/capi-quickstart.yaml?

[ ] Yes
[ ] No
[ ] N/A

Updated necessary files under ./infrastructure-vcd/v1.0.0/?

[ ] Yes
[ ] No
[ ] N/A

Issue
If applicable, please reference the relevant issue
Fixes #

☝  Used with https://github.com/giantswarm/cluster-cloud-director/pull/225/commits/ff29b5db32897686b14e1f79689c6f13835b1523
Works with workaround: After 1st control plane VM is created, change NIC to DHCP and change LB Pool to the new DHCP IP.
VM doesn't get an IP with static IP pool mode <= Next focus.

☝ works with 👇
https://github.com/giantswarm/cluster-cloud-director/pull/225/commits/337ec4e4e2e94909282b4cd1c0fb7189b1283120

The only thing left here is to make it so the phases don't run when using ignition.
One option would be to add a field in VcdCluster but that means editing the CRD (new api version) so not my favourite solution.
What would be nice would be to check if kubeadmControlPlane.spec.format=ignition but I'm not sure how to do it in the controller. @erkanerol do you have an idea?

@vxav We can use the "format" field in the bootstrap secret. See https://github.com/giantswarm/cluster-api-provider-cloud-director/blob/6371e3eb65df897946e2b69bc23617d25eff357d/controllers/vcdmachine_controller.go#L1086
This method can return 2 strings: Format and Value. Then we can add some if-else logic based o

Works ☝ 🎉
With 👇
https://github.com/giantswarm/cluster-cloud-director/pull/225/commits/0de62486ca5888e166aaf5424db829acd7dfdfdd


Support for events (touch, state)

new node: Event - connects to SSE and outputs all events (touch, attr change and etc)

brand colors and icon

moved example to correct place

works fine with canvas and shapes:)

???


autoWidth option crashes slider

Issue description:
We have been trying to implement the slider with autoWidth and keep running into this error.
The slider is building the container elements properly, but changing the slide by dragging or clicking on the arrows does nothing.
Without the autoWidth setting it works perfectly.
Perhaps there is a conflict with other plugins on the global scope. But we can not find any console logged errors. It just simply stops working. We even tried the demo settings just to be sure.

Demo link/slider setting:
container: this.find('[data-list=slides]')[0],
nav: false,
gutter: 20,
items:3.3,
autoWidth: true,
loop: false,
mouseDrag: true,
swipeAngle: false,
speed: 400,
prevButton: this.find('[data-click=prev]')[0],
nextButton: this.find('[data-click=next]')[0],
Tiny-slider version:  2.9.1 & 2.9.2
Browser name && version:  Chrome Version 75.0.3770.142 (Official Build) (64-bit) actually, on all browser. our development target is ie11 ;) and have been testing on all machines
OS name && version:   ...

I have the same issue, in particular when the items have a min-width property.
Can't provide more information right now.

Same (similar) issue here.
We have a project where CSS directive "letter-spacing" breaks the slider if set on the div of the slider-items.
If this is copied to a local html-file and run in Firefox(68.0.1 @ MacOS) or Chrome (75.0.3770.100 @ MacOS), setting letter-spacing will break the slider if autoWidth = true.
If set to autoWidth=false, the slider will work.

I'm seeing similar issues, sometimes autoWidth works as expected, sometimes is doesn't. When it doesn't, no errors are logged in the console, the HTML wrappers are added correctly, but the onInit callback is not called. My best guess is that Tiny Slider is having a hard time determining the outer width of the slides, thinks that the total width is less than the parent width and concludes it doesn't need to initialize.

I have other problem with autoWidth, slider crushing when I try use it with lazyLoad option.

@yurysosnov-neklo if you have a different problem, it's usually best to comment on the issue about that problem, or create a new issue if it does not exist yet.

So, is this going to get addressed properly? I'm also incurring with auto-width hiding the controls of my slider

Same Problem here. autoWidth is hiding controls and mouseDrag wont work. Maybe more not working.


Typo in docs

Under this subtitle, Viewing Application Insights usage on your Azure bill there's a typo on line one. Changes 'baed' to based.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 93d51fcb-63a2-c622-7df3-27703a171b3a
Version Independent ID: 0e2ed122-08c3-fae2-3b7f-6fde780a9933
Content: Manage usage and costs for Azure Application Insights - Azure Monitor
Content Source: articles/azure-monitor/app/pricing.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @AaronMaxwell
Microsoft Alias: aaronmax

@mugambiwarwema Thanks for your feedback! We will investigate and update as appropriate.

@mugambiwarwema Thanks for bringing this to our attention. The PR has been created and will visible in document soon.
We will now close this issue.


external URL/API

Hello,
is it possible to address an external URL or API? I'm afraid I can't find a way.
z. B: https://api.hotslogs.com/Public/Players/1/Benthor_1644
I'm hoping for an answer.
Thank you

This version of Columns only works with arrays of objects and does not retrieve data from external source.  It maybe possible to use an external URL, but it would need to be retrieved $.ajax before calling the columns plugin.
Furthermore this version of Columns is no longer maintained.


Server crash on beforeconnect event

My server crashed during the night, caught this in the logs.
I don't use the beforeconnect event anywhere.
System.NullReferenceException: Object reference not set to an instance of an object. at System.SpanHelpers.IndexOf(Byte& searchSpace, Byte value, Int32 length) at System.Runtime.InteropServices.Marshal.PtrToStringUTF8(IntPtr ptr) at AltV.Net.Data.PlayerConnectionInfo..ctor(PlayerConnectionInfoInternal info) in /home/runner/work/coreclr-module/coreclr-module/api/AltV.Net/Data/PlayerConnectionInfo.cs:line 41 at AltV.Net.ModuleWrapper.OnPlayerBeforeConnect(IntPtr eventPointer, PlayerConnectionInfoInternal connectionInfo, String reason) in /home/runner/work/coreclr-module/coreclr-module/api/AltV.Net/ModuleWrapper.cs:line 186
Runs latest altv 7.1.1 release branch

fixed


how to get data for today?

today is Mar 28 , 2018
how to get data for today?
import fix_yahoo_finance as yf
import datetime as dt
import time
#data = yf.download("SPY", start="2017-01-01", end="2017-04-30")
data = yf.download("SPY", start="2018-03-24", end="2018-03-28")
it is what I get
data
Open        High         Low       Close   Adj Close
Date
2018-03-26  262.130005  265.429993  259.410004  265.109985  265.109985
2018-03-27  266.170013  266.769989  258.839996  260.600006  260.600006
           Volume

Date
2018-03-26  141956100
2018-03-27  126354700
but for today there is now data?

Happens also to me.
Is it possible to get today closing price after trading hours, around 17:00 EST time?


Add helper functions to access the new Charts Color Palette

Follow up from this PR:
https://github.com/CrowdStrike/tailwind-toucan-base/pull/369
These colors will be specific to charts, not other types of data visualizations.
Notable Changes:

Updated Tailwind-toucan-base package version.
Two new methods: getChartColors and getChartNeutralColors to allow you to get the normal chart or neutral colors separately. getChartColors also has an optional argument if you want to exclude the neutral colors explicitly. By default it includes 1 neutral color the same as the getGraphColors method.
The return type of swatchName in these colors was changed to a string instead of any. One of the existing tests validated this already, so I'm pretty sure this is just updating the type to be more accurate.
The test coverage is the same as the existing graphs palette - I just made the existing tests a bit more generic so they can be looped through for each of the different palettes.

@JackRobards any screenshots of the changes?


Add new LSP6 related types to interface

What kind of change does this PR introduce?
Add missing types introduced in LSP6
What is the current behavior? (You can also link to an open issue here)
The ERC725JSONSchema interface does not support the latest keyType and valueType

What is the new behavior (if this is a feature change)?
The interface supports these new types
Other information
The lib should also be updated to encode/decode these types:

#38
#39

Codecov Report

Merging #40 (979028b) into main (8f5fba4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   80.04%   80.04%
=======================================
  Files           8        8
  Lines         406      406
  Branches       88       88
=======================================
  Hits          325      325
  Misses         44       44
  Partials       37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f5fba4...979028b. Read the comment docs.

Flaky tests, my dear flaky tests....


[Service Bus] Add a possibility to update an already created subscription rule description

SubscriptionClient class does not support update on an already created rule subscription identifier.
Shall we extend this client with a new method named UpdateRuleAsync(string ruleName, RuleDescription description) which will perform updates on specific rule internally?

//cc: @JoshLove-msft

Thank you for your feedback.  Tagging and routing to the team best able to assist.

@zive7  I'd recommend deleting the old subscription and creating a new one with the same name.
Any reason that does not work?

@zive7 closing this for now, please do let us know if there are any questions.

@axisc Sorry for the late reply. I've developed like that, but I think that recreating the subscription is not a good idea. With this solution, there is a possibility some of the events not being handled at all.


out of memory "Parsing alignment file"

Hi there! :)
I am planning on using your amazing tool to do the read mapping and taxonomic characterization of some metagenomes. The issue is that I do not have easy access to a high memory node. I have played with the diamond settings to reduce the memory requirements. I think the issue is when it tries to parse the alignment out.RAT.unclassified_unmapped.alignment.diamond which is often larger than the available memory.
Perhaps there is something I can do to solve this issue?
Great job!
Cheers,
Gonçalo
Please let me know if you need any extra info!

out.RAT.log

[2024-03-27 17:24:03] Homology search with DIAMOND is starting. Please be patient. Do not forget to cite DIAMOND when using CAT or BAT in your publication.
query: None
database: /projects/0/prjs0815/databases/CAT/20231120_CAT_nr/db/2023-11-21_CAT.dmnd
mode: fast
top: 11
no-self-hits: False
number of cores: 64
block-size (billions of letters): 8.0
index-chunks: 8
tmpdir: ./
compress: 0
blast flavour: blastx
[2024-03-27 19:30:14] Homology search done! File ./out.RAT.unclassified_unmapped.alignment.diamond created.
[2024-03-27 19:30:14] Loading file /projects/0/prjs0815/databases/CAT/20231120_CAT_nr/tax/nodes.dmp.
[2024-03-27 19:30:17] Parsing alignment file ./out.RAT.unclassified_unmapped.alignment.diamond.

slurm error file:

[M::mem_process_seqs] Processed 3887138 reads in 354.034 CPU sec, 6.475 real sec
[main] Version: 0.7.17-r1188
[main] CMD: bwa mem -t 64 /projects/0/prjs0815/Projects/Rota-biotic/157633/METAG/157633_2210063V4210222_METAG/RAT_CAT/scaffolds_s.min500.fasta /projects/0/prjs0815/Projects/Rota-biotic/157633/METAG/157633_2210063V4210222_METAG/concat/157633_2210063V4210222_METAG.1.fq.gz /projects/0/prjs0815/Projects/Rota-biotic/157633/METAG/157633_2210063V4210222_METAG/concat/157633_2210063V4210222_METAG.2.fq.gz
[main] Real time: 231.080 sec; CPU: 7431.596 sec
[bam_sort_core] merging from 0 files and 64 in-memory blocks...
/var/spool/slurm/slurmd/job5710205/slurm_script: line 82: 3489247 Killed                  CAT_pack reads --mode mcr -n 64 --index_chunks 8 --block_size 8 --bin_suffix fa -b bin/ -c $contigs -1 $R1 -2 $R2 -d $db -t $tax
[2024-03-27 19:38:36] ERROR: input file ./out.RAT.complete.abundance.txt does not exist.
[2024-03-27 19:38:36] ERROR: input file ./out.RAT.contig.abundance.txt does not exist.
slurmstepd: error: Detected 1 oom_kill event in StepId=5710205.batch. Some of the step tasks have been OOM Killed.

ls CAT_output:

$ ls -lh
total 114G
drwxr-s--- 2 mendelab prjs0815 4.0K Mar 27 15:58 bin
-rw-r----- 1 mendelab prjs0815 1.6K Mar 27 17:11 out.RAT.BAT.bin2classification.txt
-rw-r----- 1 mendelab prjs0815 4.0K Mar 27 19:38 out.RAT.BAT.bin2classification.txt.with_names.txt
-rw-r----- 1 mendelab prjs0815 1.7K Mar 27 17:11 out.RAT.BAT.log
-rw-r----- 1 mendelab prjs0815 1.1M Mar 27 17:11 out.RAT.BAT.ORF2LCA.txt
-rw-r----- 1 mendelab prjs0815 1.1G Mar 27 16:56 out.RAT.CAT.alignment.diamond
-rw-r----- 1 mendelab prjs0815 866K Mar 27 17:05 out.RAT.CAT.contig2classification.txt
-rw-r----- 1 mendelab prjs0815 2.8K Mar 27 17:05 out.RAT.CAT.log
-rw-r----- 1 mendelab prjs0815 1.5M Mar 27 17:05 out.RAT.CAT.ORF2LCA.txt
-rw-r----- 1 mendelab prjs0815  12M Mar 27 16:10 out.RAT.CAT.predicted_proteins.faa
-rw-r----- 1 mendelab prjs0815 8.5M Mar 27 16:10 out.RAT.CAT.predicted_proteins.gff
-rw-r----- 1 mendelab prjs0815 3.1K Mar 27 19:30 out.RAT.log
-rw-r----- 1 mendelab prjs0815 2.6G Mar 27 16:05 out.RAT.scaffolds_s.min500.fasta.1576_210222_METAG.1.fq.gz.bwamem.sorted
-rw-r----- 1 mendelab prjs0815 109G Mar 27 19:30 out.RAT.unclassified_unmapped.alignment.diamond
-rw-r----- 1 mendelab prjs0815 425M Mar 27 17:24 out.RAT.unclassified_unmapped.fasta
-rw-r----- 1 mendelab prjs0815  27M Mar 27 15:58 scaffolds_s.min500.fasta
-rw-r----- 1 mendelab prjs0815  11K Mar 27 15:59 scaffolds_s.min500.fasta.amb
-rw-r----- 1 mendelab prjs0815 673K Mar 27 15:59 scaffolds_s.min500.fasta.ann
-rw-r----- 1 mendelab prjs0815  26M Mar 27 15:59 scaffolds_s.min500.fasta.bwt
-rw-r----- 1 mendelab prjs0815 6.5M Mar 27 15:59 scaffolds_s.min500.fasta.pac
-rw-r----- 1 mendelab prjs0815  13M Mar 27 15:59 scaffolds_s.min500.fasta.sa

Dear Goncalo,
thanks for bringing this up. Unfortunately, especially when there are a lot of unmapped/unclassified reads, the diamond file gets really big and parsing it becomes memory-intensive. I think the biggest part of this is that even for the unmapped reads, RAT integrates all the hits from within 10% of the top bit score, which is a lot of info with potentially millions of reads. So, one thing you could do is to shrink the diamond file and only use hits within 5% or 1% of the bit score: if you already have the contig2classification and the bin2classification files and supply them to the RAT run, then just setting -r to 5 or 1 should work.
I will leave this open! Maybe we can find a way to make this step a bit less memory intensive, but it is hard, because with a couple of millions of reads, it is automatically going to be a lot of RAM.
Hope this helps!
Cheers,
Tina

Hi Tina,
Thanks for getting back on this issue.
I have moved forward by turning the read annotation off CAT_pack reads --mode mc
It is probably because the assembly was filtered at 500bp. Yet, adding the short contigs or the unmap read annotation would make it too computationally intense for the resources we have available.
Thank you for the suggestion! I will keep it in mind for the future.
Cheers,
Gonçalo


Improve error handling for onLoad

I think errors should not be swallowed, that is a really bad practice. I was very against this when we first discussed, but I know that I fell ill of it myself (and took me longer than it should to see what was going on), I am vehemently against.
onLoad exceptions should be re-thrown.
This is what it looks like with this change:

You still get the option to provide an error handler but now the handler is aware of what the error was. If you do not, the exception is re-thrown as anyone would except.
Before if a handler was not provided (and it was optional) the exception was completely swallowed and not logged, seem, expressed anywhere. And you got a black screen from an empty game. Also even if you wanted to add a custom handler you would not know what went wrong, which made the custom error handler practically useless.

Good catch, fixed!

Good catch, fixed!


Feature Request: Support collections with iterators of type std::input_iterator_tag

As above, would it be possible to support collections with iterators of std::input_iterator_tag instead of requiring std::forward_iterator_tag?
It would mean it's not possible to know the size of the collection beforehand and an alternative way of encoding (removing the explicit serializing of the number of elements?) would be required. This might be useful in the generic case as well so as to avoid iterating through collections twice.

Supporting direct logging of input sequences is not planned. What's the use-case of consuming an input sequence purely for logging? FTR, the obvious workaround is copying the input sequence into a supported container first:
void log_input_sequence(InputSequence<T>& is)
{
    const std::vector<T> v(is.begin(), is.end()); // the price is a memory copy
    BINLOG_INFO("{}", v);
}

The technical reason of not supporting input sequences is keeping the serialization and queue allocation logic simple. To support values of unknown size, it'd need:

a special case for mserialize::serialized_size, increases complexity and compilation times
a different kind of logic for QueueWriter::beginWrite, that allows tentative allocation of the complete remaining free capacity
a different kind of QueueWriter::write, that checks the remaining capacity for each write (runtime penalty), and resizes the queue on overflow (difficult in the concurrent setting) or allocates a new queue (complicates ownership)

It has been done before, it is ugly.

removing the explicit serializing of the number of elements

How would then the deserializer know when to stop?

This might be useful in the generic case as well so as to avoid iterating through collections twice.

The collection is not iterated twice, if it has .size(). Do you have large, frequently logged containers that doesn't have a known size?


Can't login on android device - twitter_login: ^4.0.1

Good evening,
I contact you, because I can't connect to twitter following all the procedures and settings that can be found on the internet and stackoverflow.
Creation of the Twitter developer account : OK
Generation of the API key : OK
Generation of the API secret key : OK
Activation of 3-legged OAuth : is enabled
Added callback URL(s) : DONE

mangateck://
twitter://
twittersdk://
https://mangateck-18b6f.firebaseapp.com/__/auth/handler

Request email address from users is disabled/enabled => nothing changes
Permission: I tried everything => Read, Write, and Direct Messages

Future<UserCredential> signInWithTwitter() async {
    // Create a TwitterLogin instance
    final twitterLogin = TwitterLogin(
        apiKey: 'XXXXXXX',
        apiSecretKey:'YYYYYYYYYYYYYYY',
        redirectURI: 'twitter://'
    );

    // Trigger the sign-in flow
    final authResult = await twitterLogin.login();
    switch (authResult.status!) {
      case TwitterLoginStatus.loggedIn:
        print("SUCCESS");
        break;
      case TwitterLoginStatus.cancelledByUser:
        print("CANCELLED BY USER");
        break;
      case TwitterLoginStatus.error:
        print("ERROR");
        print(authResult.status!.index); // RESULT ==> 2
        print(authResult.status!); // RESULT ==> TwitterLoginStatus.error
        print(authResult.errorMessage); // RESULT ==> Exception: Exception: HttpException: Failed Forbidden
        break;
    }

    // Create a credential from the access token
    final twitterAuthCredential = TwitterAuthProvider.credential(
      accessToken: authResult.authToken!, // This code break but I'm not here
      secret: authResult.authTokenSecret!,
    );

    // Once signed in, return the UserCredential
    return await FirebaseAuth.instance.signInWithCredential(twitterAuthCredential);
  }

------ MANIFEST -------
<intent-filter>
                <action android:name="android.intent.action.VIEW" />

                <category android:name="android.intent.category.DEFAULT" />
                <category android:name="android.intent.category.BROWSABLE" />
                <!-- Accepts URIs that begin with "example://gizmos” -->
                <!-- Registered Callback URLs in TwitterApp -->
                <data android:scheme="twitter" /> <!-- host is option -->
            </intent-filter>

[✓] Flutter (Channel stable, 2.5.3, on macOS 11.6 20G165 darwin-x64, locale fr-FR)
• Flutter version 2.5.3 at /Users/francoisgaucher/FlutterSDK/202102_flutter/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 18116933e7 (8 weeks ago), 2021-10-15 10:46:35 -0700
• Engine revision d3ea636dc5
• Dart version 2.14.4
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /Users/francoisgaucher/Library/Android/sdk
• Platform android-31, build-tools 30.0.3
• Java binary at: /Applications/Android Studio Preview.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 13.1, Build version 13A1030d
• CocoaPods version 1.10.2
[✓] Android Studio
• Android Studio at /Applications/Android Studio 4.2 Preview.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
[✓] Android Studio (version 2020.3)
• Android Studio at /Applications/Android Studio Preview.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
[✓] Android Studio (version 4.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
[✓] Android Studio (version 3.3)
• Android Studio at /Applications/Android Studio 2.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
[✓] Android Studio
• Android Studio at /Applications/Android Studio 4.2 Preview 2.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
[✓] Android Studio
• Android Studio at /Users/francoisgaucher/Downloads/Android Studio 4.2 Preview.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
[✓] Connected device (2 available)
• SM N986B (mobile) • R5CN80J7RDJ • android-arm64 • Android 11 (API 30)
• macOS (desktop)   • macos       • darwin-x64    • macOS 11.6 20G165 darwin-x64
• No issues found!

I add an information, the authorization seems to be valid by twitter on the "authorization" side because I find the application on the "User" side in the profile->Security and connection->Application and session-> application connected->"APP".

I regenerated several times the different keys to test also.
For information: the authentication by google & facebook (nothing to see) works on the same basis of the code (the problem must come from a configuration without doubt).
Translated with www.DeepL.com/Translator (free version)

I hadn't tested it on ios yet, but I did. (Iphone X => iOS 15.0)
The result is the same:
flutter: Connect to TWITTER
flutter: ERROR
flutter: 2
flutter: TwitterLoginStatus.error
flutter: Exception: Exception: HttpException: Failed Forbidden

@scorpiotiftif
The plugin does not seem to work if you create a Twitter developer account after 15 November 2021.
When did you create your developer account?
Also, I am currently working on TwitterAPIv2 support.
https://github.com/0maru/twitter_login/issues/67

This would explain that... I just created it 3 days ago.
Thanks for the analysis. I look forward to the next version of the plugin then.
Do you have a time range on the integration of this new api ?

@scorpiotiftif
I will be releasing v4.1.0-dev today in Japan time.

@scorpiotiftif
I have released v4.1.0-dev.
Twitter API v2.0 is now supported.
Please update this plugin.

Hello @0maru
I'm updating my project and test the preview version.

@scorpiotiftif I have released v4.1.0-dev. Twitter API v2.0 is now supported. Please update this plugin and change it to use the loginV2 method.

Can you update the doc to use your package? I stuck Redirecting you back to the application. This may take a few moments. .

This is my config in Twitter developers.
and this is my AndroidManifest
<intent-filter>
                <action android:name="android.intent.action.VIEW" />
                <category android:name="android.intent.category.DEFAULT" />
                <category android:name="android.intent.category.BROWSABLE" />
                <data android:scheme="@string/fb_login_protocol_scheme" /> [This is config for another function]
                <data android:scheme="twitterkit-xxxxxxxxxxxxxxxxxxxxx" />

            </intent-filter>

Hi !
Thank's a lot about this new version that work like a charm !
I had encounter an other problem but not due to your plugin.
PS: if someone read this maybe it will be usefull if you want to complete register/login with FIREBASE : on twitter developer account, upgrade OR choose the "ELEVATED" product NOT "ESSENTIAL" otherwise you can't login through "twitter_login" AND "firebase" !

Just an other things.... think to update README to specify to use "loginV2" method in some case

Just an other things.... think to update README to specify to use "loginV2" method in some case

Hey bro. Can u show me your code, manifest and config on Twitter developers to implement it? Of course you should cover important information.

It is closed because:
"I found the issue: I just needed to relaunch the Twitter app which was launched, and then the redirect worked fine :)"
But mine is not solved: Android fails to come back to app. It hangs on: "redirecting you back to the application. This may take a few moments" .  Waiting more than 10 minutes and it is still there.
I have re-created the twitter app several times.
Used v1.1 only, then changed to 2.0 only. Not solved.
The iOS Simulator comes back to  the app.
The iPhone device (iOS 15.5) comes back to app.


Improve: Box Filter Properties form + remove text fields + add sliders

Description
Add Sliders instead of Text Fields for the box filter operator in order to improve the UX features and to remove the empty field exception

Type of change

Add Slider from javafx.scene
Remove the text fields
Solves #63

@SahanDisa What if we have the sliders and a place to change the value through text?
Sliding across finer ranges would be a hassle.

Yes, of course, we can add text with a slider.  hope it will make it more easier to deal with the numbers(especially float). It thought of adding 100% sliders because it simplifies the prototyping process.

https://user-images.githubusercontent.com/52147094/121135340-07488a00-c852-11eb-84cf-f9bfec292aee.mp4


Automated video length reduction based on content

I am using autoflip on CentOS for the videos and that tool works perfect.
I want to ask that as this is intelligent engine which detects the important content for cropping. Is it possible to reduce the video length (by fixing maximum time) based on this content.
Apparently this is question of video summarization, but the normal summarization is based on nlp approach what is spoken in the video or subtitles. I am looking for solution based on content.
If you can guide me.

@nathanfrey-google @sgowroji Please any helping solution? that the reduction of the duration of video based on time but also content wise when there is no audio inside or audio is ignored at all.

@sgowroji Is there any update on this request?

@nathanfrey-google @camillol @cdibona @sgowroji Good afternoon. Is there any update on this issue?

@sgowroji Good morning. Is there any update?

Hi @Tortoise17 .
Are you still looking for the resolution on this issue.


Sanetize 'target' attr fix

Description
The sanetization of injected html into the ui-text node (see other PR) seems to remove a bit too much attributes, because the target attribute of hyperlinks is also removed.
The DOMPurify library offers two ways to customize which attributes should be allowed:

ALLOWED_ATTR can be used to replace the entire list of default allowed attributes.  Which imho seems to be a bit too invasive.
ADD_ATTR can be used to retain the default list of allowed attributes and to add a few more.

I have used the latter option to add allow the link attribute.  Of course extra attributes can be added in the future if necessary.
The result:

Related Issue(s)
Closes #1464
Checklist

[X] I have read the contribution guidelines
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

[ ] Upgrade instructions
[ ] Configuration details
[ ] Concepts

[ ] Changes flowforge.yml?

[ ] Issue/PR raised on FlowFuse/helm to update ConfigMap Template
[ ] Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

[ ] Includes a DB migration? -> add the area:migration label

This conflict should get resolved once https://github.com/FlowFuse/node-red-dashboard/pull/1463 is merged, so will wait for Steve's eyes on it before moving forward with this one.


Missing toolbar after chat request

From https://github.com/microsoft/GitHub-Copilot-for-Azure/issues/20

Install https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azure-github-copilot
Open chat view -> "How do I deploy this app to azure?"
Response does not have Thumbs Up / Thumbs Down

Looks good with latest Insiders -> verified.
Thanks Rob!


[#150512756] Fix typo in BOSH SSH key generation

What
Checking in the wrong directory/resource caused the SSH keys for access to
BOSH to be recreated each time this task was run. I noticed this had stopped
working while testing the instructions to access BOSH without Concourse
after I had run the create-bosh-concourse pipeline to test the Concourse
upgrade. Although Terraform upload the new keypair to AWS, it doesn't take
effect if bosh-init doesn't recreate the BOSH VM.
I've tested the persistent environments and it looks like the key in the
state bucket still works at the moment, probably because we upgraded the
BOSH VM the last time this was run. However we need to fix this before the
Concourse upgrade is applied to those environments.
How to review

Checkout this branch:
git fetch && git checkout bugfix/150512756-bosh_ssh_keygen

Bring up a Bootstrap Concourse with this branch:
BRANCH=$(git rev-parse --abbrev-ref HEAD) make dev deployer-concourse bootstrap`

Run the create-bosh-concourse pipeline.

Confirm that the generate-bosh-ssh-keypair task in the generate-secrets job says:
BOSH keys non-zero size, skipping generation...

And not:
Generating new ssh key pair for BOSH...
Generating public/private rsa key pair.
…

Confirm that make dev ssh_bosh from alphagov/paas-cf still works.

Who can review
Not @dcarley or @alext (who found the typo).

Looks good, however I've noticed that the generate-deployments-key-pair has the same issue. I think that's worth fixing here as well.

Looks good, however I've noticed that the generate-deployments-ssh-keypair has the same issue. I think that's worth fixing here as well.

👍  I've rebased with that fix too. I've updated the commit and PR message, but I haven't tested or updated the PR review instructions. Would you be able to test it?


Tyler Butler

https://tbutler.org/2020/10/30/hackme-ctf-writeup.html
Cyber risk consultant, security researcher, open source developer

Testing the comment system

Testing the comment system


Add SpaceX Launch Pack LR by LazTek from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of Lazarus, to add SpaceX Launch Pack LR by LazTek to CKAN.
Please direct questions about this pull request to Lazarus.

Closing in favour of https://github.com/KSP-CKAN/NetKAN/pull/583


⚠ Processors has degraded performance

In 64b8c99, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 70 ms

Resolved: Processors performance has improved in 2a5e1a2.


Rivets slice

Hello,
Would it be possible to add a rivets formatter with slice. Would be handy to manipulate text when showing it in the cart.
Specific a client wants us to display size only on variant but not the colour.
Thanks!

Hi @Kasi-mir. That sounds possible - we'd need to make sure it would be useful in general.
You can easily add your own formatters for use with CartJS doing something like this:

which you could then use like this:

Thats what I have done for now. But would be handy to have it build in, or some sort of way to manipulate the strings.
Thanks!

Would you mind sharing what you're using at the moment?
The only issue I have with text manipulation formatters is that they're often quite use-case specific.

Yeh this is a bit use-case specific aswell. Some sort of string formatters would be nice tho
rivets.formatters.slice = function(value, arg1, arg2){   return value.slice(arg1, arg2); }

That seems useful enough! I've added it to the codebase, will be available out of the box with the next release.


Modified badge height so longer badges fit (bug 1196141)

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1196141
Issue was:

Now it should look like:

With screenshots! Awesome! :100:


fix error link and add redirect

i saw nginx error bad gateway and i change to open lbry

Thanks Chris!

you welcome sir


Unable to update Twitter/LinkedIn accounts

In Dec 2015 I updated my account with a twitter handle and a linkedin account but since then I've changed my username on both sites. As of Dec 2016 I'm unable to update either in the settings. When I hover over either the twitter/linkedin logos it displays the old username but offers no choice for updating to a new one.
It's not a huge issue, moreso one for the few of us who've changed their twitter/linkedin handles.

@majlind please email the same to<EMAIL_ADDRESS>we are currently in the process of having a feature to update the usernames for twitter and LinkedIn shortly.
This is being discussed on a separate thread.
Refer : https://github.com/FreeCodeCamp/FreeCodeCamp/issues/10807#issuecomment-257653781


unable to share files from my mac to phone in the get mode

As suggested by the title, whenever i copy something on my mac and then click on the get file on my phone, it gives this toast telling Failed Getting Files, is this an issue only for me or is this something that has yet to be worked on?  It works fine on raycast somehow but not when i use cmd + copy on the file itself.

Please specify the server and client versions. I will try to recreate this issue with those versions.
Does your mac has Apple silicon or is it Intel?

Please specify the server and client versions. I will try to recreate this issue with those versions. Does your mac has Apple silicon or is it Intel?

i am using the latest version that is available for both the server and client, since i downloaded it last week.
i have tried installing again and even then it doesn't work.
My mac is apple silicon,
Great app btw makes my life a lot easier
Thank you

I checked the latest versions, but I couldn't recreate the issue. cmd+C and get files button works. I don't have raycast though. If that has a clipboard manager (or some similar functionality), I suspect it might interfere with the default clipboard functionality (cmd+C and other). I'll try to install raycast and see if this is the case. If you use any extensions of raycast (related to clipboard), can you please specify them? then I can create an almost identical environment to recreate the issue.

I checked the latest versions, but I couldn't recreate the issue. cmd+C and get files button works. I don't have raycast though. If that has a clipboard manager (or some similar functionality), I suspect it might interfere with the default clipboard functionality (cmd+C and other). I'll try to install raycast and see if this is the case. If you use any extensions of raycast (related to clipboard), can you please specify them? then I can create an almost identical environment to recreate the issue.

Raycast does have a clipboard manager (clipboard history) and thats about it I think. I'll try disabling it and let you know

even without raycast it doesn't work, if it helps whenever i try to copy something using cmd+c, and click on get, it displays the filename on my phone, but when i click on file, it shows error getting files.
I even reinstalled clipshare_server just in case i had any old version, but it doesn't work.

I think you have pressed the green GET button at the bottom left corner?
But you should press the green FILE button at the bottom rignt corner to get the files

Seems it has copied only the file name. That's why you get the file name but not the file. Can you try to copy the file by right clicking on the file, and try to get the file?. Also please check if Cmd+V works for pasting the copied file (on mac itself).
I'll try to provide a debug enabled version to view more details on what goes wrong.

i have tried both right clicking to check if it makes it available for me on my phone , but it doesn't and cmd+c and cmd+v work perfectly on my system itself to copy files

Here is a debug version of clip_share, which prints more verbose output to the console.
clip_share-arm64-debug.zip
Unzip this and there is an clip_share executable file. Open a terminal at the folder where this clip_share file is available, and run it from the terminal with this command,
./clip_share

It will show some outputs in the terminal. Copy a file with cmd+C and try to get the file from mobile. Check if the program output in the terminal shows any output related to file paths and number of files copied.

Connection: <IP_ADDRESS>:39804
Client Common Name: clipshare_client
client verified
file:///.file/id=6571367.35494824
stat failed
Cleaning up resources before exit
is what it gives me when i try to send some file to my phone

is the actual path of the file you copied is  /.file/id=6571367.35494824 ? If not, there's something wrong. But now I think I found where's the issue. So I can try to fix that soon

the actual path of the file is /Users/shreyaspaiatkere/Downloads/IMG-20240906-WA0000.jpg
but its showing file:///.file/id=6571367.49391166
i assume its macos's internal file reference.

Yes, I have to convert the file reference URL to path, which is currently not done. I'll fix that

okay, thank you

I applied a fix for this issue, but since I couldn't reproduce the issue locally, I cannot verify if this actually fixes the problem. Here is a preview version of the fixed clip_share,
clip_share_3.3.2-alpha.zip
There are release and debug versions (with and without verbose console output). Please try the release version first, and if that works, the issue is solved. If that didn't work, please run the debug version in this to see what happens with the changes. Running either release or debug executable is same as before - i.e. open the terminal in the corresponding directory and run,
./clip_share

i have tried this and now the cmd + c works perfectly for files even outside raycast.
Thank you, also how do i make it so that this works everytime on startup.
can i just make a script that runs this on start-up?
Also, theres a slight problem with images on the app, while it sends the image to my phone i get shown something like this, this again works fine in raycast for some reason, attached below are the screenshots

this is the actual image

how do i make it so that this works everytime on startup.
can i just make a script that runs this on start-up?

I will create a patch release with the fix, so that you can install the fixed version. As a temporary workaround, you may replace the file /Users/<your username>/.local/bin/clip_share with the fixed version (release/clip_share) I uploaded above, and reboot to apply the change. (I assume you have already installed the latest version 3.3.1 that had the bug. Installation is required to run on startup)

Also, theres a slight problem with images on the app, while it sends the image to my phone i get shown something like this, this again works fine in raycast for some reason, attached below are the screenshots

Do you want to get that image file after copying it on mac? if so, then use the green FILE button as the image file is also a file. Then you will get it in ClipShareDocuments folder on your mobile (also accessible from the gallery app).
The IMAGE button is to get a screenshot or an image (not the png or jpg file).

Also, theres a slight problem with images on the app, while it sends the image to my phone i get shown something like this, this again works fine in raycast for some reason, attached below are the screenshots

Do you want to get that image file after copying it on mac? if so, then use the green FILE button as the image file is also a file. Then you will get it in ClipShareDocuments folder on your mobile (also accessible from the gallery app). The IMAGE button is to get a screenshot or an image (not the png or jpg file).

okay thank you.

how do i make it so that this works everytime on startup.
can i just make a script that runs this on start-up?

I will create a patch release with the fix, so that you can install the fixed version. As a temporary workaround, you may replace the file /Users/<your username>/.local/bin/clip_share with the fixed version (release/clip_share) I uploaded above, and reboot to apply the change. (I assume you have already installed the latest version 3.3.1 that had the bug. Installation is required to run on startup)

okay will do
Thank you

Created a new release including this bug fix at github.com/thevindu-w/clip_share_server/releases/tag/v3.3.2.
Since this bug is fixed, I will close this issue. If the new release still has the issue, please don't hesitate to reopen this issue.


Intermittent "Assertion signature is not valid" exceptions

We are using (a fork of) your library in an application of ours. During real-world validation, it was found that SSO intermittently fails with stated exception. After a lot of debugging it was found that the SAML response contains this line:
<Assertion ID="_615964bb-8e35-4c84-a169-eb8c9e315400" IssueInstant="2021-08-02T06:34:48.760Z" Version="2.0" xmlns="urn:oasis:names:tc:SAML:2.0:assertion">
After deserialization and (re)serialization by Saml2Service.GetAssertion(), the trailing zero in the timestamp has disappeared hence signature validation gets to see:
<Assertion ID="_615964bb-8e35-4c84-a169-eb8c9e315400" IssueInstant="2021-08-02T06:34:48.76Z" Version="2.0" xmlns="urn:oasis:names:tc:SAML:2.0:assertion">
Does this ring a bell?

Hi @fokkog- I'm not aware of this specific issue. Let me ask you a few questions.
What Idp are you using?
What type of authentication are you using with the Idp? Forms or Windows? I've seen issues with windows authentication. I've been working on a fix for that.

The Idp that provided quoted line is Azure AD. Login to Azure AD is form-based.
FYI we have the same intermittent exception with ADFS, but we haven't yet managed to capture a SAML response that triggers it. Hence for ADFS we cannot be sure it's the exact same root cause.
Having said that, the assertion round-tripping approach strikes me as risky. The deserialised AssertionType contains various DateTime objects with no clue about their original representation/precision. I don't find it surprising that the serialisation by Saml2Service.GetAssertion() can lead to a different payload, thus breaking the signature validation.
Only assertion signature validation suffers from this, not response signature validation because that works with the original DOM object.

I'm not sure what the cause could be. We are ADFS with signed assertion and had no issues at all when using forms authentication.
The only issue I have seen before is when using windows authentication while logging out then logging in - which I am working on code to address.
Has the IdP admin (Azure and ADFS) checked the logs to see what is causing it? Also please check the SAML response from ADFS and compare.

Thanks for your responses!
In the meantime we've been able to intercept failing and passing SAML responses from ADFS also. It's the exact same issue. If the IssueInstant milliseconds end in '0' (statistically 1 in every 10 logins) then assertion signature validation fails and we get the exception. Otherwise it passes and all is fine. I can share the SAML responses if you are interested, but I won't attach them here since they contain sensitive data.
I'd say it's a clear bug and I'm surprised we are the first/only library user to suffer from this. Maybe there is something environmental at work. In any case we'll try to fix it in our private fork by doing signature validation on the original Assertion payload instead of the recreated one.

Fixed in our fork. Considering that other library users are apparently not affected, I will close this issue.


Prettier and eslint configuration

Description
I have integrated prettier and eslint
Closes #10
What change does this PR introduce?
Please select the relevant option(s).

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] CI/CD (updates related to the CI/CD process)
[ ] Documentation update (changes to docs/code comments)
[x] Chore (miscellaneous tasks that do not fall into the above options)

What is the proposed approach?
Please give a short overview/explanation on the approach taken to resolve the issue(s).
Checklist:

[x] The commit message follows our adopted guidelines
[x] Testing has been done for the change(s) added (for bug fixes/features)
[ ] Relevant comments/docs have been added/updated (for bug fixes/features)

No problem


Runs app.js, but only if app.coffee exists

Is this intended behavior?  I was trying to set up a roots project with my app file written in JavaScript instead of CoffeeScript. (just personal preference)
With only an app.js file, roots doesn't read it.  With an app.js and an app.coffee file, roots only reads the app.js file.
Is it doing require('./app') or something?
Thanks for your time.

Hey there! Yes, it is. Roots does not support app.js, the fact that it works under any condition was unknown to me. If there's enough demand for it, we could add support for this, but app.coffee is really just a very simple configuration file, not one in which a lot of coding needs to be done, so coffee just makes it less to write and cleaner.

I see, makes sense.  I'll switch back to using app.coffee.  Thanks for the
explanation!
On Jun 23, 2015 6:14 PM, "Jeff Escalante"<EMAIL_ADDRESS>wrote:

Hey there! Yes, it is. Roots does not support app.js, the fact that it
works under any condition was unknown to me. If there's enough demand for
it, we could add support for this, but app.coffee is really just a very
simple configuration file, not one in which a lot of coding needs to be
done, so coffee just makes it less to write and cleaner.
—
Reply to this email directly or view it on GitHub
https://github.com/jenius/roots/issues/650#issuecomment-114657136.

:+1:


Fixing the Korean description text

Fixed the intro that I missed adding in the last change.

Increase 안내1(=PS), 안내2(=PPS) readability

It's not a big change, but I think it will help improve readability.

Great thanks so much @DAUN3046 ! 🙌🏻

It's not a big change, but I think it will help improve readability.

and any size change is appreciated :) we wouldn't have any translations if it wasn't for volunteers like you!
(I'm having wifi difficulties so I can't update the site with these updates right now but I'll try to deploy an update later)

All done:
https://github.com/pcottle/learnGitBranching/commit/bf2dc126dd69671a574a2b2e8aa3368018707711
thanks again


pyoculus build is crashing simsopt CI

Starting last week, the simsopt CI's have been failing at the step where pyoculus is pip-installed. Here's one example. The error message is below. Todd Elder is having the same error when trying to install pyoculus on his laptop. It looks like it's an issue with pyoculus's setup.py system. @smiet @zhisong @mbkumar  Any idea how to fix this?
Collecting pyoculus
  Downloading pyoculus-0.3.1.tar.gz (844 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 844.2/844.2 kB 58.6 MB/s eta 0:00:00
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [21 lines of output]
      Traceback (most recent call last):
        File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/tmp/pip-build-env-qhbh225t/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 332, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
        File "/tmp/pip-build-env-qhbh225t/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 302, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-qhbh225t/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 318, in run_setup
          exec(code, locals())
        File "<string>", line 2, in <module>
        File "/tmp/pip-build-env-qhbh225t/overlay/lib/python3.9/site-packages/numpy/distutils/core.py", line 24, in <module>
          from numpy.distutils.command import config, config_compiler, \
        File "/tmp/pip-build-env-qhbh[225](https://github.com/hiddenSymmetries/simsopt/actions/runs/10683512465/job/29611749973#step:15:226)t/overlay/lib/python3.9/site-packages/numpy/distutils/command/config.py", line 19, in <module>
          from numpy.distutils.mingw32ccompiler import generate_manifest
        File "/tmp/pip-build-env-qhbh225t/overlay/lib/python3.9/site-packages/numpy/distutils/mingw32ccompiler.py", line 28, in <module>
          from distutils.msvccompiler import get_build_version as get_build_msvc_version
      ModuleNotFoundError: No module named 'distutils.msvccompiler'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

Hi all,
I know I can fix this, but I don't have much time this week as I'm off
before ISHW, then at ISHW.
I think It's related to the issues we have been having with new numpy and
other packages updating because of this kick-in-the-butt, notably
setuptools deprecating its Fortran compilation features. I have a pull
request for a build using the 'future proof-er' meson build on pyoculus,
@zhisong, could you try it and approve it?
https://github.com/zhisong/pyoculus/pull/8
Additionally, can someone create a test branch of simsopt to confirm this
branch solves the issue?
I can dedicate some time on Thursday and will see what I can do.
There are future changes to simsopt planned to integrate @aikitzu features
related to turnstile calculations, but we will fast-forward the
modifications needed to fix the failing ci.
Warmest regards,
Chris
On Tue, Sep 3, 2024, 10:27 PM Matt Landreman @.***>
wrote:

Starting last week, the simsopt CI's have been failing at the step where
pyoculus is pip-installed. Here's one example.
https://github.com/hiddenSymmetries/simsopt/actions/runs/10683512465/job/29611749323
The error message is below. Todd Elder is having the same error when trying
to install pyoculus on his laptop. It looks like it's an issue with
pyoculus's setup.py system. @smiet https://github.com/smiet @zhisong
https://github.com/zhisong @mbkumar https://github.com/mbkumar Any
idea how to fix this?
Collecting pyoculus
Downloading pyoculus-0.3.1.tar.gz (844 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 844.2/844.2 kB 58.6 MB/s eta 0:00:00
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'error'
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [21 lines of output]
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in
main()
File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
File "/tmp/pip-build-env-qhbh225t/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 332, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=[])
File "/tmp/pip-build-env-qhbh225t/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 302, in _get_build_requires
self.run_setup()
File "/tmp/pip-build-env-qhbh225t/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 318, in run_setup
exec(code, locals())
File "", line 2, in
File "/tmp/pip-build-env-qhbh225t/overlay/lib/python3.9/site-packages/numpy/distutils/core.py", line 24, in
from numpy.distutils.command import config, config_compiler,
File "/tmp/pip-build-env-qhbh225t/overlay/lib/python3.9/site-packages/numpy/distutils/command/config.py", line 19, in
from numpy.distutils.mingw32ccompiler import generate_manifest
File "/tmp/pip-build-env-qhbh225t/overlay/lib/python3.9/site-packages/numpy/distutils/mingw32ccompiler.py", line 28, in
from distutils.msvccompiler import get_build_version as get_build_msvc_version
ModuleNotFoundError: No module named 'distutils.msvccompiler'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
—
Reply to this email directly, view it on GitHub
https://github.com/zhisong/pyoculus/issues/10, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADFPG2HBKH76E2WG4YUEKQLZUW2K5AVCNFSM6AAAAABNSETXKOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYDEOBYGU2TENQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@mbkumar @landreman:
The issue is with an unpinned version of setuptools, and changes to distutils, as explained here: https://github.com/pypa/setuptools/issues/3532.
Pointing simsopt to the meson-built pyoculus fixes pyoculus, but now VMEC2000 fails.
There are some suggested fixes, such as: https://github.com/pypa/setuptools/pull/3505#issuecomment-1215988554:

However, having setuptools<65 in requirements.txt with pip install --no-use-pep517 does fix it

pinning setuptools to lt. 65,   (PR #11 ) as I don't like the setuptools solution (PR #8 ). Confirmed to work in the branch used by Todd Elder.
Re-open if this does not fix.


Should not use $ at start of code sections, makes it harder to copy

Could add a copy button beside the text too.
An example of this is in launch with.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Fix Versions: Dockstore 1.6
┆Sprint: Seabright Sprint 5 Electric
┆Issue Number: DOCK-417

Tested it in staging.dockstore.org DockstoreUI - 2.3.0-beta.0. '$' is no longer present in the code examples on the Dockstore Launch tab


example: HTTP circuit breaker doesn't consider HTTP status codes which are more indicative of retryable errors

The circuit breaker pattern as per the linked docs is to allow retrying of operations that are less likely to fail. With the current code in example/ if I encounter a 404, it'll just return the 404 HTML page and moreover without any operational context hence defeating the pattern aimed for :-(
https://github.com/sony/gobreaker/blob/e7c4cd566971ee0c285b05c469e61e0993543edc/example/http_breaker.go#L26-L55
There should be a way in which the example HTTP circuit breaker looks at the returned HTTP status codes. There are some for which you should not retry unless some conditions change e.g. authorization and authentication problems, not found and legal issue status codes.
At bare minimum please make the example more resilient with error checking such as
defer res.Body.Close()

if res.StatusCode/100 != 2 { // Not a 2XX successful response
    ... // Handle the status code in here
}

Hi @odeke-em !
I believe your understanding of the circuit breaker pattern is not entirely correct.
This is what I got from ChatGPT (I was lazy to type 🥲)
To explain, the circuit breaker pattern is used to prevent cascading failures in distributed systems by detecting when a remote service or resource is unavailable, failing fast, and providing fallback behavior to prevent further requests to that service or resource. The pattern aims to increase the stability and resilience of the system.

Retry operations are often used in conjunction with the circuit breaker pattern, but they are not the main purpose of the pattern. Retry operations are typically used for transient errors that are expected to be resolved by retrying the operation.

Regarding your example, if the code encounters a 404 error, it should ideally handle it gracefully and provide meaningful feedback to the user. This can be achieved by providing a user-friendly error message along with the 404 HTML page, which can include operational context. This way, the user can understand what went wrong and take appropriate action.

However, this approach may not necessarily be related to the circuit breaker pattern. The circuit breaker pattern is primarily focused on preventing cascading failures in distributed systems, while error handling and feedback to users are important considerations in any software system.

Moreover, since the circuit-breaker pattern can wrap more than just HTTP calls, it is ideal to separate the logic handling via errors (passed to the IsSuccessful function, which can decide success/failure) rather than adding support for HTTP status codes to the core library.
In case of any further clarification, please do let me know! Happy to help :)


Cannot read property of undefined

Hi, I've tried this plugin, but I don't know how to override this error :
main.js
import MultiLanguage from 'vue-multilanguage' Vue.use(MultiLanguage, {   default: 'fr',   en: {     connection: 'Connection'   },   fr: {     connection: 'Connexion'   } })
LoginPanel.vue
template   div     span(v-lang.connection)
The error :
TypeError: Cannot read property 'connection' of undefined     at Proxy.render (eval at ./node_modules/vue-loader/lib/template-compiler/index.js?{"id":"data-v-ab120e6a","hasScoped":true,"transformToRequire":{"video":["src","poster"],"source":"src","img":"src","image":"xlink:href"},"buble":{"transforms":{}}}!./node_modules/vue-loader/lib/template-compiler/preprocessor.js?engine=pug!./node_modules/vue-loader/lib/selector.js?type=template&index=0!./src/components/LoginPanel.vue (app.js:2333), <anonymous>:134:61)     at VueComponent.Vue._render (vue.esm.js?efeb:4474)     at VueComponent.updateComponent (vue.esm.js?efeb:2765)     at Watcher.get (vue.esm.js?efeb:3115)     at new Watcher (vue.esm.js?efeb:3104)     at mountComponent (vue.esm.js?efeb:2772)     at VueComponent.Vue$3.$mount (vue.esm.js?efeb:8429)     at VueComponent.Vue$3.$mount (vue.esm.js?efeb:10790)     at init (vue.esm.js?efeb:4065)     at createComponent (vue.esm.js?efeb:5512)
Maybe there is something I'm not doing well ...
Thanks for any help.

I've done like this :
p {{translate('connection')}}
It works like a charm but it's not as pretty as the other method...

@steftanguy,
You can take a look at the demo provided in the repo. It helped me a lot!

Hi @steftanguy
I need see it, I think that because yout use the pug template. But I need verify it.

I rewrote the plugin, to give more performance and improve usage. In this new version (> 4) I applied its issue.
In the new version the return of errors has been improved, so if it gives some error I can help better.


gildas: 20180601_a -> 20180701_a

Motivation for this change
Update to the latest upstream version.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build gildas

Failure on x86_64-linux (full log)
Attempted: gildas
Partial log (click to expand)
cp -fr gbl_pi.inc /build/gildas-src-jul18a/integ/x86_64-linux-gfortran-openmp/include/gbl_pi.inc
cpp  -P -traditional -C  -DIEEE="ieee" -DBITS64="bits64" -DLINUX="linux" -DFORTRAN2003_PP -ffreestanding -DGFORTRAN="gfortran" -DGFORTRAN_VERSION="730" -DCFITSIO="yes" -DATM2009="atm2009" -DPNG="yes" -DGAG_USE_GTK -DGAG_USE_OPENMP -DGAG_USE_POSIX -DGAG_USE_PYTHON -DGAG_USE_UNDERSCORE    gbl_nan.incpp | grep -v \#pragma > built/x86_64-linux-gfortran-openmp/gbl_nan.inc
make[2]: *** No rule to make target '/build/gildas-src-jul18a/integ/x86_64-linux-gfortran-openmp/include/gbl_constant.mod', needed by 'integ'.  Stop.
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/build/gildas-src-jul18a/kernel/include'
make[1]: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
make[1]: Leaving directory '/build/gildas-src-jul18a/kernel'
make: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
builder for '/nix/store/6jkvwvy9lgllgqfv0ycxd3vw1c548nkm-gildas-20180701_a.drv' failed with exit code 2
error: build of '/nix/store/6jkvwvy9lgllgqfv0ycxd3vw1c548nkm-gildas-20180701_a.drv' failed

Failure on aarch64-linux (full log)
Attempted: gildas
Partial log (click to expand)
cp -fr gbl_pi.inc /build/gildas-src-jul18a/integ/pc-linux-gfortran-openmp/include/gbl_pi.inc
cpp  -P -traditional -C  -DIEEE="ieee" -DLINUX="linux" -DFORTRAN2003_PP -ffreestanding -DGFORTRAN="gfortran" -DGFORTRAN_VERSION="730" -DCFITSIO="yes" -DATM2009="atm2009" -DPNG="yes" -DGAG_USE_GTK -DGAG_USE_OPENMP -DGAG_USE_POSIX -DGAG_USE_PYTHON -DGAG_USE_UNDERSCORE    gbl_nan.incpp | grep -v \#pragma > built/pc-linux-gfortran-openmp/gbl_nan.inc
make[2]: *** No rule to make target '/build/gildas-src-jul18a/integ/pc-linux-gfortran-openmp/include/gbl_constant.mod', needed by 'integ'.  Stop.
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/build/gildas-src-jul18a/kernel/include'
make[1]: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
make[1]: Leaving directory '/build/gildas-src-jul18a/kernel'
make: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
builder for '/nix/store/izwxl8gk3xzlr1agbsqnpgz43v9w43kh-gildas-20180701_a.drv' failed with exit code 2
error: build of '/nix/store/izwxl8gk3xzlr1agbsqnpgz43v9w43kh-gildas-20180701_a.drv' failed

I can't reproduce this error locally, but I suspect it is due to the parallel building.
@gebner: Could you please try to build 72dc6fd to see if it fixes the problem?

@GrahamcOfBorg build gildas

I get the same error locally.  Why did you remove the make depend line?

Failure on x86_64-linux (full log)
Attempted: gildas
Partial log (click to expand)
cp -fr gbl_pi.inc /build/gildas-src-jul18a/integ/x86_64-linux-gfortran-openmp/include/gbl_pi.inc
cpp  -P -traditional -C  -DIEEE="ieee" -DBITS64="bits64" -DLINUX="linux" -DFORTRAN2003_PP -ffreestanding -DGFORTRAN="gfortran" -DGFORTRAN_VERSION="730" -DCFITSIO="yes" -DATM2009="atm2009" -DPNG="yes" -DGAG_USE_GTK -DGAG_USE_OPENMP -DGAG_USE_POSIX -DGAG_USE_PYTHON -DGAG_USE_UNDERSCORE    gbl_nan.incpp | grep -v \#pragma > built/x86_64-linux-gfortran-openmp/gbl_nan.inc
cp -fr built/x86_64-linux-gfortran-openmp/gbl_nan.inc /build/gildas-src-jul18a/integ/x86_64-linux-gfortran-openmp/include/gbl_nan.inc
make[2]: *** No rule to make target '/build/gildas-src-jul18a/integ/x86_64-linux-gfortran-openmp/include/gbl_constant.mod', needed by 'integ'.  Stop.
make[2]: Leaving directory '/build/gildas-src-jul18a/kernel/include'
make[1]: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
make[1]: Leaving directory '/build/gildas-src-jul18a/kernel'
make: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
builder for '/nix/store/c1wddg9yb9xgyvy0yx12m077wflm6q9s-gildas-20180701_a.drv' failed with exit code 2
error: build of '/nix/store/c1wddg9yb9xgyvy0yx12m077wflm6q9s-gildas-20180701_a.drv' failed

Failure on aarch64-linux (full log)
Attempted: gildas
Partial log (click to expand)
cp -fr gbl_pi.inc /build/gildas-src-jul18a/integ/pc-linux-gfortran-openmp/include/gbl_pi.inc
cpp  -P -traditional -C  -DIEEE="ieee" -DLINUX="linux" -DFORTRAN2003_PP -ffreestanding -DGFORTRAN="gfortran" -DGFORTRAN_VERSION="730" -DCFITSIO="yes" -DATM2009="atm2009" -DPNG="yes" -DGAG_USE_GTK -DGAG_USE_OPENMP -DGAG_USE_POSIX -DGAG_USE_PYTHON -DGAG_USE_UNDERSCORE    gbl_nan.incpp | grep -v \#pragma > built/pc-linux-gfortran-openmp/gbl_nan.inc
cp -fr built/pc-linux-gfortran-openmp/gbl_nan.inc /build/gildas-src-jul18a/integ/pc-linux-gfortran-openmp/include/gbl_nan.inc
make[2]: *** No rule to make target '/build/gildas-src-jul18a/integ/pc-linux-gfortran-openmp/include/gbl_constant.mod', needed by 'integ'.  Stop.
make[2]: Leaving directory '/build/gildas-src-jul18a/kernel/include'
make[1]: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
make[1]: Leaving directory '/build/gildas-src-jul18a/kernel'
make: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
builder for '/nix/store/vhbk0sscj70hcj5iwhsgmfrnycj3qa8q-gildas-20180701_a.drv' failed with exit code 2
error: build of '/nix/store/vhbk0sscj70hcj5iwhsgmfrnycj3qa8q-gildas-20180701_a.drv' failed

I get the same error locally. Why did you remove the make depend line?

This depend target has been removed upstream.

The build failure should be fixed with 8ae9e7e.

@GrahamcOfBorg build gildas

@gebner Can you try to build once more, please?

@GrahamcOfBorg build gildas

Failure on x86_64-linux (full log)
Attempted: gildas
Partial log (click to expand)
compilation terminated.
make[3]: *** [/build/gildas-src-jul18a/admin/Makefile.build:257: built/x86_64-linux-gfortran-openmp/ambigs.o] Error 1
make[3]: Leaving directory '/build/gildas-src-jul18a/kernel/lib/gsys'
make[2]: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
make[2]: Leaving directory '/build/gildas-src-jul18a/kernel/lib'
make[1]: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
make[1]: Leaving directory '/build/gildas-src-jul18a/kernel'
make: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
builder for '/nix/store/hz4fp1nppv7dcqz0mbjxdls5j1jawihf-gildas-20180701_a.drv' failed with exit code 2
error: build of '/nix/store/hz4fp1nppv7dcqz0mbjxdls5j1jawihf-gildas-20180701_a.drv' failed

Failure on aarch64-linux (full log)
Attempted: gildas
Partial log (click to expand)
-o /build/gildas-src-jul18a/integ/pc-linux-gfortran-openmp/lib/liblapack.so -L/build/gildas-src-jul18a/integ/pc-linux-gfortran-openmp/lib -L/nix/store/fh8z4sniyv18b4jf32f3gnn862bvwc3f-python-2.7.15/lib -lblas   -lrt -lpthread -lm -ldl )
collect2: error: ld returned 1 exit status
make[2]: *** [/build/gildas-src-jul18a/admin/Makefile.build:280: /build/gildas-src-jul18a/integ/pc-linux-gfortran-openmp/lib/liblapack.so] Error 1
make[2]: Leaving directory '/build/gildas-src-jul18a/legacy/lapack'
make[1]: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
make[1]: Leaving directory '/build/gildas-src-jul18a/legacy'
make: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
builder for '/nix/store/plq0rgsf6k0nx0970afkrl0qdw6msmnc-gildas-20180701_a.drv' failed with exit code 2
note: build failure may have been caused by lack of free disk space
error: build of '/nix/store/plq0rgsf6k0nx0970afkrl0qdw6msmnc-gildas-20180701_a.drv' failed

This is probably why the build is failing on nixos:
/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash: /build/gildas-src-jul18a/integ/x86_64-linux-gfortran-openmp/bin/gag-makedepend.pl: /usr/bin/perl: bad interpreter: No such file or directory
Updated dependencies in built/x86_64-linux-gfortran-openmp/Makefile.deps

9315760883916c2f56cdb230884f945f235e2bd6 fixes the build on nixos. I think this is ready to be merged now.

@GrahamcOfBorg build gildas

Failure on aarch64-linux (full log)
Attempted: gildas
Partial log (click to expand)

Warning: 'tweight' may be used uninitialized in this function [-Wmaybe-uninitialized]
make[3]: Leaving directory '/build/gildas-src-jul18a/contrib/imager/lib'
make[2]: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
make[2]: Leaving directory '/build/gildas-src-jul18a/contrib/imager'
make[1]: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
make[1]: Leaving directory '/build/gildas-src-jul18a/contrib'
make: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
builder for '/nix/store/avrziafyvg336g2acisvdl9nbay20pb4-gildas-20180701_a.drv' failed with exit code 2
error: build of '/nix/store/avrziafyvg336g2acisvdl9nbay20pb4-gildas-20180701_a.drv' failed

Failure on x86_64-linux (full log)
Attempted: gildas
Partial log (click to expand)

   complex(kind=4), allocatable :: cdata(:,:)

Warning: 'cdata.offset' may be used uninitialized in this function [-Wmaybe-uninitialized]
cpp  -P -traditional -C  -DIEEE="ieee" -DBITS64="bits64" -DLINUX="linux" -DFORTRAN2003_PP -ffreestanding -DGFORTRAN="gfortran" -DGFORTRAN_VERSION="730" -DCFITSIO="yes" -DATM2009="atm2009" -DPNG="yes" -DGAG_USE_GTK -DGAG_USE_OPENMP -DGAG_USE_POSIX -DGAG_USE_PYTHON -DGAG_USE_UNDERSCORE    getcur.f90 | grep -v \#pragma > built/x86_64-linux-gfortran-openmp/getcur.f90
gfortran -c   -fimplicit-none -Wuninitialized -Wunused-variable -Wunused-label   -I./ -I./built/x86_64-linux-gfortran-openmp -I/build/gildas-src-jul18a/integ/x86_64-linux-gfortran-openmp/include -Wrealloc-lhs-all -J./built/x86_64-linux-gfortran-openmp -pipe -fno-backslash -fno-range-check -fno-second-underscore -fPIC -fopenmp -O built/x86_64-linux-gfortran-openmp/getcur.f90 -o built/x86_64-linux-gfortran-openmp/getcur.o
f951: Warning: command line option '-Wformat=1' is valid for C/C++/ObjC/ObjC++ but not for Fortran
f951: Warning: command line option '-Wformat-security' is valid for C/C++/ObjC/ObjC++ but not for Fortran
building of '/nix/store/jys3wkwih1pykcpfchhxvhjdzb2kylga-gildas-20180701_a.drv' timed out after 3600 seconds
error: build of '/nix/store/jys3wkwih1pykcpfchhxvhjdzb2kylga-gildas-20180701_a.drv' failed

My last commit should fix the architecture detection for aarch64. I've checked that it still builds on Linux x86_64 and Darwin.
@gebner Could you please start a new build on aarch64-linux to check if it builds on this platform? (ideally with a longer time limit to avoid the time-out error).

@GrahamcOfBorg build gildas

Failure on x86_64-linux (full log)
Attempted: gildas
Partial log (click to expand)
cp: cannot stat 'built/x86_64-linux-gfortran-openmp/gio_headers.mod': No such file or directory
make[2]: *** [/build/gildas-src-jul18a/admin/Makefile.build:344: /build/gildas-src-jul18a/integ/x86_64-linux-gfortran-openmp/include/gio_headers.mod] Error 1
f951: Warning: command line option '-Wformat=1' is valid for C/C++/ObjC/ObjC++ but not for Fortran
f951: Warning: command line option '-Wformat-security' is valid for C/C++/ObjC/ObjC++ but not for Fortran
make[2]: Leaving directory '/build/gildas-src-jul18a/kernel/include'
make[1]: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
make[1]: Leaving directory '/build/gildas-src-jul18a/kernel'
make: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
builder for '/nix/store/sbzfayd85d7bp7md6rsv70jw049b381d-gildas-20180701_a.drv' failed with exit code 2
error: build of '/nix/store/sbzfayd85d7bp7md6rsv70jw049b381d-gildas-20180701_a.drv' failed

Failure on aarch64-linux (full log)
Attempted: gildas
Partial log (click to expand)
cp: cannot stat 'built/x86_64-linux-gfortran-openmp/cfitsio_parameters.mod': No such file or directory
make[2]: *** [/build/gildas-src-jul18a/admin/Makefile.build:344: /build/gildas-src-jul18a/integ/x86_64-linux-gfortran-openmp/include/cfitsio_parameters.mod] Error 1
cp: cannot stat 'built/x86_64-linux-gfortran-openmp/cfitsio_interfaces.mod': No such file or directory
make[2]: *** [/build/gildas-src-jul18a/admin/Makefile.build:344: /build/gildas-src-jul18a/integ/x86_64-linux-gfortran-openmp/include/cfitsio_interfaces.mod] Error 1
make[2]: Leaving directory '/build/gildas-src-jul18a/kernel/include'
make[1]: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
make[1]: Leaving directory '/build/gildas-src-jul18a/kernel'
make: *** [/build/gildas-src-jul18a/admin/Makefile.struct:19: default] Error 1
builder for '/nix/store/dg53ih2p39apb5zg1g526b025pf8x460-gildas-20180701_a.drv' failed with exit code 2
error: build of '/nix/store/dg53ih2p39apb5zg1g526b025pf8x460-gildas-20180701_a.drv' failed

Failure on x86_64-darwin (full log)
Attempted: gildas
Partial log (click to expand)
clang-5.0: warning: argument unused during compilation: '-isystem /nix/store/chf6i0r2hpzj6shqsx6am8kz7wvhxfj0-printproto-1.0.5/include' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-isystem /nix/store/chf6i0r2hpzj6shqsx6am8kz7wvhxfj0-printproto-1.0.5/include' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-isystem /nix/store/fdaqx6vs0896szg7x5gxcqq1ab3qmahl-cfitsio-3.430/include' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-isystem /nix/store/fdaqx6vs0896szg7x5gxcqq1ab3qmahl-cfitsio-3.430/include' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-isystem /nix/store/hh6ipy402727sg8nc2kmhhys68arkgkz-python-2.7.15-env/include' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-isystem /nix/store/hh6ipy402727sg8nc2kmhhys68arkgkz-python-2.7.15-env/include' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-F/nix/store/f74z6vd3fxi15wg4i1b5w3v5ib3ps8nm-CF-osx-10.10.5/Library/Frameworks' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-F/nix/store/f74z6vd3fxi15wg4i1b5w3v5ib3ps8nm-CF-osx-10.10.5/Library/Frameworks' [-Wunused-command-line-argument]
building of '/nix/store/qlbav4qdzsahl7z2472gdz6ddkglbzcy-gildas-20180701_a.drv' timed out after 3600 seconds
error: build of '/nix/store/qlbav4qdzsahl7z2472gdz6ddkglbzcy-gildas-20180701_a.drv' failed

The last build failure is due to an incorrect rebasing of this branch that removed the 9315760 fix (patch perl interpreter path). Sorry about this.
I've cherrypicked this commit again (93157)  and updated the source URL (it has moved since I've opened this PR).

@GrahamcOfBorg build gildas

Success on x86_64-linux (full log)
Attempted: gildas
Partial log (click to expand)
shrinking /nix/store/2rrv9ihaw2j8z8m37885py4bgrdp3qbg-gildas-20180701_a/libexec/python/pyclassfiller/_core.so
shrinking /nix/store/2rrv9ihaw2j8z8m37885py4bgrdp3qbg-gildas-20180701_a/libexec/python/pysic.so
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2rrv9ihaw2j8z8m37885py4bgrdp3qbg-gildas-20180701_a/libexec  /nix/store/2rrv9ihaw2j8z8m37885py4bgrdp3qbg-gildas-20180701_a/bin
patching script interpreter paths in /nix/store/2rrv9ihaw2j8z8m37885py4bgrdp3qbg-gildas-20180701_a
/nix/store/2rrv9ihaw2j8z8m37885py4bgrdp3qbg-gildas-20180701_a/bin/gildas-wrapper.sh: interpreter directive changed from "/bin/sh -e" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh -e"
/nix/store/2rrv9ihaw2j8z8m37885py4bgrdp3qbg-gildas-20180701_a/libexec/bin/gag-parse-messages.pl: interpreter directive changed from "/usr/bin/perl -w" to "/nix/store/mbmf1j17gadvxi9rrr8rzj0iqnb8xxyp-perl-5.24.4/bin/perl -w"
/nix/store/2rrv9ihaw2j8z8m37885py4bgrdp3qbg-gildas-20180701_a/libexec/bin/gag-get-interfaces.pl: interpreter directive changed from "/usr/bin/perl -w" to "/nix/store/mbmf1j17gadvxi9rrr8rzj0iqnb8xxyp-perl-5.24.4/bin/perl -w"
/nix/store/2rrv9ihaw2j8z8m37885py4bgrdp3qbg-gildas-20180701_a/libexec/bin/gag-format-f90.pl: interpreter directive changed from "/usr/bin/perl -w" to "/nix/store/mbmf1j17gadvxi9rrr8rzj0iqnb8xxyp-perl-5.24.4/bin/perl -w"
checking for references to /build in /nix/store/2rrv9ihaw2j8z8m37885py4bgrdp3qbg-gildas-20180701_a...

Timed out, unknown build status on aarch64-linux (full log)
Attempted: gildas
Partial log (click to expand)
f951: Warning: command line option '-Wformat=1' is valid for C/C++/ObjC/ObjC++ but not for Fortran
f951: Warning: command line option '-Wformat-security' is valid for C/C++/ObjC/ObjC++ but not for Fortran
built/x86_64-linux-gfortran-openmp/calib-engines.f90:586:0:

                          error)

Warning: 'sin' may be used uninitialized in this function [-Wmaybe-uninitialized]
built/x86_64-linux-gfortran-openmp/calib-engines.f90:586:0: Warning: 'cos' may be used uninitialized in this function [-Wmaybe-uninitialized]
building of '/nix/store/cp3w2hlh6dwy0rn35l0q37c2k2qwm1nb-gildas-20180701_a.drv' timed out after 3600 seconds
error: build of '/nix/store/cp3w2hlh6dwy0rn35l0q37c2k2qwm1nb-gildas-20180701_a.drv' failed


runtime/pprof: incorrect locations for inlined generic functions

Go version
go version devel go1.22-de5b418bea Sat Dec 2 03:15:03 2023 +0000 linux/amd64
What operating system and processor architecture are you using (go env)?
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/korniltsev/.cache/go-build'
GOENV='/home/korniltsev/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/korniltsev/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/korniltsev/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/home/korniltsev/github/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/korniltsev/github/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='devel go1.22-de5b418bea Sat Dec 2 03:15:03 2023 +0000'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/home/korniltsev/github/go/src/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build3732277415=/tmp/go-build -gno-record-gcc-switches'

What did you do?
I produced a pprof profile with the following stacktrace
foo
generic[a,b]
generic[b,a]

And foo and generic[a,b] functions are inlined by the go compiler
Reproducer
More info: https://github.com/golang/go/issues/64528#issuecomment-1846804084
What did you expect to see?
I expected to see a pprof Location with 3 Line for this case.
What did you see instead?
Isee a pprof Location with 2 Line for this case. Only
foo
generic[a,b]

and then separate location for
generic[b,a]

I suspect this is because of this line , which checks for function names without generic shapes (generic[...])
https://github.com/golang/go/blob/de5b418bea70aaf27de1f47e9b5813940d1e15a4/src/runtime/pprof/proto.go#L564

This is https://github.com/golang/go/issues/64528#issuecomment-1846804084, split into another bug. I think this also qualifies for the backport in #64609.
cc @golang/runtime @cherrymui


Comment formatting

This is a simple PR that corrects the formatting of class, function, and property comments so that they'll be parsed correctly and show up when option-clicking symbols. There are zero changes to functionality.

Thanks