Baker improvements

A couple of little improvements to nav mesh / occluder / mesh baking:

Navmesh vertex positions get rounded instead of floored, which keeps it from z-fighting with terrain and looking like it has holes. I've tested this on all the meshes I have on hand and it doesn't reintroduce any of the previous errors.
Baking occluders and meshes reuses existing nodes, instead of creating new MeshInstance3D/OccluderInstance3D every time.

I get this when baking in the navigation demo.
WARNING: NavigationMesh baking process will likely fail.
Source geometry is suspiciously big for the current Cell Size and Cell Height in the NavMesh Resource bake settings.
If baking does not fail, the resulting NavigationMesh will create serious pathfinding performance issues.
It is advised to increase Cell Size and/or Cell Height in the NavMesh Resource bake settings or reduce the size / scale of the source geometry.

With this PR merged in, I get this error on every load/run:
ERROR: Navigation map synchronization error. Attempted to merge a navigation mesh polygon edge with another already-merged edge. This is usually caused by crossing edges, overlapping polygons, or a mismatch of the NavigationMesh / NavigationPolygon baked 'cell_size' and navigation map 'cell_size'.

Reverting back to floor the sync error goes away.

Oh, sorry, I'm using a modified map for the video I'm making. The file is only one region larger than the repo demo. Here are the files if you want to look.
I'm using 4.1.3. Baking gives the suspiciously big message. I increased the cell size/height to 0.5, but that complained saying it expected 0.25. It seems to work, though there is a noticable lag when the enemy is far away and needs to find a long path.
When I load or run it gives the nav sync error.
https://we.tl/t-rikUJhMnQk

The suspiciously big warning comes from here: https://github.com/godotengine/godot/pull/60945/commits/79511af7c94b447409d10194239069facef9c4a0
Recast (the navmesh baker) builds a grid that covers the entire navigable area. Supposedly, when that grid exceeds 30,000,000 cells, baking breaks, regardless of how little of it is navigable. Increasing the cell size reduces how big the grid needs to be (although the cell size in ProjectSettings also needs to match, which is why it complained when you tried that).
The recommendation for large maps seems to be runtime baking: https://github.com/godotengine/godot/issues/60907#issuecomment-1122465223


Spatial.Converters throws null reference exception when data serialized with System.Text.Json.JsonSerializer class

Description
When attempting to load data with spatial data from CosmosDB, the Microsoft.Azure.Cosmos.Spatial.Converters.GeometryJsonConverter throws a NullReferenceException in ReadJson when the spatial data was stored using System.Text.Json.JsonSerializer.SerializeAsync(Stream, object). This is because the Microsoft serializer writes spatial data in a different format than the Newtonsoft deserializer used in the GeometryJsonConverter class.
This problem arose when attempting to follow the official sample code for bulk inserts provided at https://github.com/Azure-Samples/cosmos-dotnet-bulk-import-throughput-optimizer/blob/main/src/Program.cs
To Reproduce

Start with the official sample code for bulk CosmosDB inserts linked above
In your sample, add a field of type Microsoft.Azure.Cosmos.Spatial.Point called location
Run your sample; your CosmosDB collection should have an object with a location value
Attempt to read your data back using code similar to this:

var queryable = Container
	.GetItemLinqQueryable<MyType>(true)
	.Where(p => p.id = "my id");

var iterator = queryable.ToFeedIterator();

var models = new List<MyType>();
while (iterator.HasMoreResults)
{
	var response = iterator.ReadNextAsync()?.Result;
	if (response is null) break;

	models.AddRange(response);
}

Expected behavior
The query should execute and return your data
Actual behavior
The method iterator.ReadNextAsync() throws an AggregateException containing a NullReferenceException terminating    at Microsoft.Azure.Cosmos.Spatial.Converters.GeometryJsonConverter.ReadJson(JsonReader reader, Type objectType, Object existingValue, JsonSerializer serializer)
Environment summary
SDK Version: .NET 5.0.3, Microsoft.Azure.Cosmos package 3.16.0
OS Version: Windows 10
Additional context
The cause appears to be a mismatch between the way Newtonsoft and Microsoft serialize Point data. The example code for bulk-inserts linked above uses System.Text.Json.JsonSerializer to serialize the data for insertion into CosmosDB. But the Microsoft.Azure.Cosmos.FeedIteratorCore<T> class uses Newtonsoft tools to deserialize.
Newtonsoft's serialization looks like this:
    "location": {
        "type": "Point",
        "coordinates": [
            -90.740237,
            39.950254
        ]
    },

while Microsoft's looks like this:
"location": {
            "Position": {
                "Coordinates": [
                    -87.9066,
                    41.9795
                ],
                "Longitude": -87.9066,
                "Latitude": 41.9795,
                "Altitude": null
            },
            "Crs": {
                "Type": 0
            },
            "Type": 0,
            "BoundingBox": null,
            "AdditionalProperties": {}
        }

Examining the source code at https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/Microsoft.Azure.Cosmos/src/Spatial/Converters/GeometryJsonConverter.cs has this at line s 63-66:
JToken typeToken = token["type"];
if (typeToken.Type != JTokenType.String)
{
    throw new JsonSerializationException(RMResources.SpatialInvalidGeometryType);
}

My guess is that line 64 throws the NullReferenceException because token["type"] will be null in the Microsoft-serialized example.
I tried to fix this by replacing await System.Text.Json.JsonSerializer.SerializeAsync(stream, model) in the sample code with this bulkier Newtonsoft code:
var itemsToInsert = new Dictionary<string, Stream>(models.Count);
var jsonSerializer = new JsonSerializer() { NullValueHandling = NullValueHandling.Ignore };
foreach (var model in models)
{
	var stream = new MemoryStream();
	var streamWriter = new StreamWriter(stream);
	var jsonWriter = new JsonTextWriter(streamWriter);
	jsonSerializer.Serialize(jsonWriter, model);
	await streamWriter.FlushAsync();

	itemsToInsert.Add(model.id, stream);
}

This worked, but I am seriously worried about all the open streams after it finishes. It looks like a potential memory leak to me.
(Note also that the sample uses the model's PartitionKey as the key in the itemsToInsert dictionary, which means the sample breaks when you attempt to add two items that are in the same partition. My fix to that problem was to use the ID as the dictionary key and get the item's partition key

Is your Model using any of the Spatial types?

Yes, the model has a Point member.
Yes, that is the problem. The sample code for bulk inserts uses System.Text.Json but the SDK still uses Newtonsoft.Json. You're right that one workaround would be to create a custom serializer or deserializer. Other options might be (in no particular order): refactoring the SDK to use System.Text.Json or fixing the line of code I identified in the SDK that references an array element by case-sensitive string literal. I chose the easiest fix, which is to use Newtonsoft for the bulk insert side since I can't really avoid using it on the read side.

It's possible this is less a bug in the SDK and more a bug in the official sample code, but that's above my pay grade.

@PunzunLtd Changing the SDK to use System.Text.Json is something that is slated for the next SDK version as it would be considered a breaking change (the V4 preview uses it).
The V3 SDK has no compatibility with System.Text.Json and none is planned. It offers a serialization model where you can customize the serializer if you want to replace it entirely.
Spatial types, provided by the SDK, are Newtonsoft.Json compatible, but really this is all Json. If your Bulk process is using Newtonsoft.Json, it is just writing Json. If your read/query process wants to use System.Text.Json, you can do so, you just need to provide your own System.Text.Json types for Spatial representations that deserialize the Json in a way that is compabitle with System.Text.Json instead.

The change will be important, because any spatial data serialized with one will break when deserialized with the other, it looks like. I hope that's on the roadmap.
Again, this isn't my code using System.Text.Json to serialize; it's the official sample code for this SDK at https://github.com/Azure-Samples/cosmos-dotnet-bulk-import-throughput-optimizer/blob/main/src/Program.cs. See line 67, specifically.

I understand, but that is just an example that shows one scenario, you are not forced to follow it. The idea is to guide in a generic scenario to help understanding the concepts, in this case, that Bulk mode leverages concurrent tasks.
Just like the example contains a way to setup the Indexing Policy, but might not be applicable to all cases, or you are not using the same Item type but rather a Model of your own. The example is showing how you could achieve the best possible outcome performance-wise by potentially relying on System.Text.Json for faster serialization, but it's not required.
For example:
foreach (Item item in Program.GetItemsToInsert())
                {
                    MemoryStream stream = new MemoryStream();
                    await JsonSerializer.SerializeAsync(stream, item);
                    itemsToInsert.Add(new PartitionKey(item.pk), stream);
                }

That is showing how you could leverage System.Text.Json, or if your data already comes in Stream format (which would be even better), but you could simply do:
List<Task> tasks = new List<Task>(ItemsToInsert);
foreach (Item item in Program.GetItemsToInsert())
{
	tasks.Add(container.CreateItemAsync(item, new PartitionKey(item.pk))
		.ContinueWith(itemResponse =>
		{
			if (!itemResponse.IsCompletedSuccessfully)
			{
				AggregateException innerExceptions = itemResponse.Exception.Flatten();
				if (innerExceptions.InnerExceptions.FirstOrDefault(innerEx => innerEx is CosmosException) is CosmosException cosmosException)
				{
					Console.WriteLine($"Received {cosmosException.StatusCode} ({cosmosException.ErrorMessage}).");
				}
			}
		}));
}

// Wait until all are done
await Task.WhenAll(tasks);

If those examples are confusing, I'll work with the authors to improve them.

If you do not use System.Text.Json to save your documents and instead use the default Newtonsoft.Json as the above snippet shows, that would solve the problem, correct?

OK. I appreciate what you're saying. But there's still a bug here, even if it's only a usability bug. Specifically, your statement "Spatial types, provided by the SDK, are Newtonsoft.Json compatible" is generally true but does not remain true when you use System.Text.Json.JsonSerializer.SerializeAsync(Stream, object) to serialize a Point object.
I filed this report because tracking down what was actually happening took a couple of hours. I think it would have been easier to track down if, instead of throwing a NullReferenceException the SDK threw a SerializationException instead. And I filed it here because the SDK, not the sample code or the JSON libraries, threw the exception that took me a couple of hours of digging through the SDK source code to figure out. I believe I identified exactly why the SDK throws an NRE, and I believe that this is an inappropriate outcome in the general scenario I've described (serializing a Point with System.Text.Json and deserializing it with whatever the SDK is using.
Another possibility is for the team responsible for System.Text.Json to make their serialization of Point compatible with naïve serializations such as Newtonsoft's. That would ensure that when the Azure SDK eventually switches to System.Text.Json, the switch doesn't break what could be millions of CosmosDB documents that serialized geospatial data using Newtonsoft's serializer.
Finally, if you provide feedback to the team responsible for the sample code I followed, please also mention that populating the dictionary itemsToInsert using the partition key as the dictionary key will failif a logical partition contains more than one document.

I will follow up on the documentation with your feedback for sure.
Potentially, the NullReferenceException is because Point is being used to deserialize Json that was not generated with Newtonsoft.Json. It does make sense for the error to be more descriptive though, do you have the stack trace of the exception so we can see which line it might be? I do see several checks on the GeometryJsonConverter that throw JsonSerializationException (like https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/Microsoft.Azure.Cosmos/src/Spatial/Converters/GeometryJsonConverter.cs#L64) but there might be other flow missing.
I don't believe the team behind System.Text.Json would be interested in supporting Point, this is a type provided by the SDK (https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/Microsoft.Azure.Cosmos/src/Spatial/Point.cs) and it has Newtonsoft.Json annotations. So when you use it with System.Text.Json it won't pickup or understand those annotations, generating a raw json that, if later deserialized with Newtonsoft.Json using also Point, wouldn't match. These Spatial types are helpers (they are just following the https://tools.ietf.org/html/rfc7946 standard using Newtonsoft.Json, but the same standard could be followed by a custom serializer with a custom type, for example, this was an experiment trying to get those types to support System.Text.Json https://github.com/Azure/azure-cosmos-dotnet-v3/commit/d706a6d4421e6e4ecbb112732f8f24363d9640e1), and not the only way to use GeoJson.

@ealsur , I believe the GeometryJsonConverter throws the NRE at line 64:
63 JToken typeToken = token["type"];
64 if (typeToken.Type != JTokenType.String)
65 {
66    throw new JsonSerializationException(RMResources.SpatialInvalidGeometryType);
67 }

...because I believe token["type"] returns null in that case.
I'm still concerned that the mismatch between Newtonsoft and Microsoft on the Point class means existing data may cause the SDK to fail in future releases.

Thanks for the pointer, will try to repro.
I understand the concern, but in my humble opinion, the issue is arising due to a mix of types that are not meant to work together. Point is only meant to be used with the default SDK serialization (Newtonsoft). It is correct that it is possible for a user to use it with their own custom serialization and see unexpected results, in that case, it would be ideal to have this better documented on the Geometry classes themselves in order to avoid incorrect expectations.

So, what class should I use instead of Microsoft.Azure.Cosmos.Spatial.Point?

The SDK does not have any alternatives for System.Text.Json serialization of GeoJSON data because that is not the serialization engine used by default.
You can either:

Use Point but use Newtonsoft.Json (default serialization). In your write flow code, you can use CreateItemAsync directly instead of serializing to Stream with System.Text.Json. That would also let your read/query flow work. This is potentially the best alternative.
If you do want to use System.Text.Json in your write flow, you'll need to either code or find a GeoJSON Point implementation for System.Text.Json. There are some hints of it on the linked commit I shared before. I am not aware of GeoJSON Point provided by the System.Text.Json team, but maybe there is.

OK, I'll try the CreateItemAsync flow, but I'm still very worried what happens when the SDK switches to System.Text.Json and all those point locations break. It seems like the prevention would be to create a point model class with just latitude, longitude, and elevation, and bypass the geometry classes entirely. As long as CosmosDB sees a field called "location" it seems to accept a lot of different document types as geospatial data.

If you are using V3 SDK, the SDK won't ever switch to System.Text.Json. In the code you pointed at, it is the user code decision to utilize System.Text.Json to create Streams, that is outside of the SDK scope. If your user code makes the decision of using System.Text.Json to serialize data and pass it as Streams to the SDK, it is your user code responsibility to handle also the deserialization. The Stream APIs in the SDK are agnostic to the serialization mechanics you used to generate those Streams, they are just taking a Stream of bytes that represent raw Json, how you generated it, the SDK cannot know.
For the V4 SDK, we are planning to switch to System.Text.Json to align with all the other Azure SDKs, and in that case, there would be Spatial classes (like Point) versions that work with System.Text.Json. Since this would still following the GeoJSON standard, then serializing with V4 SDK and deserializing with V3 SDK would work, because underlying, it's just raw Json that follows the same standard.


Over memory error

i have a keyword list，376MB memory occupied。
when i add_keywords_from_list(dataList)
it's 4.697g memory occupied
How to improve？

Hi @freedom-wy,
May I know approximately the length of the dataList which has around 376MB Memory Occupied?
Also, In my experience, I have never dealt with such a big keyword list. To explain your issue, since Flashtext implements a trie dictionary structure, to store all these keywords in a dictionary character by character (https://en.wikipedia.org/wiki/Trie) would be memory consuming definitely (Should go in GB's of data).
What I can think as a novice approach probably you can try is chunking your keywords into smaller lists and then use flashtext to extract from a smaller keyword list. Using this approach would help you consume less space, whereas the limitation would be you would have to run flashtext for your use-case multiple times over each chunk separately. Let me know if this sounds feasible.
Maybe, @vi3k6i5 has another intuitive approach that might help here?
Kind Regards,
Nandan Thakur

Can I use flashtext load the database?
sqlite3 database
in database have 1 million 200 thousand data.

@freedom-wy not directly using loading the database, but you can retrieve 100k keywords at a time from the database and load them in the flashtext, and use flash text for your use case.
Iterate this until you use all your keywords from your database. At the moment, this is the best solution which I can think of. I've never handled so many keys at once (1mil+ keywords).
Kind Regards,
Nandan Thakur

thank you.


chrome 66 protractor error

Hi there!
I am getting the error below:
-------------------grunt test:e2e
Running "protractor:singlerun" (protractor) task
(node:10692) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
[18:46:16] I/launcher - Running 1 instances of WebDriver
[18:46:16] I/local - Starting selenium standalone server...
[18:46:18] I/local - Selenium standalone server started at http://<IP_ADDRESS>:4444/wd/hub
[18:46:38] E/launcher - Timed out waiting for driver server to start.
Build info: version: '3.12.0', revision: '7c6e0b3', time: '2018-05-08T15:15:08.936Z'
System info: host: 'DESKTOP-MR8O00V', ip: '<IP_ADDRESS>', os.name: 'Windows 10', os.arch: 'amd64', os.version: '10.0', java.version: '1.8.0_131'
Driver info: driver.version: unknown
[18:46:38] E/launcher - WebDriverError: Timed out waiting for driver server to start.
Build info: version: '3.12.0', revision: '7c6e0b3', time: '2018-05-08T15:15:08.936Z'
System info: host: 'DESKTOP-MR8O00V', ip: '<IP_ADDRESS>', os.name: 'Windows 10', os.arch: 'amd64', os.version: '10.0', java.version: '1.8.0_131'
Driver info: driver.version: unknown
at Object.checkLegacyResponse (C:\sree\JS testing\examples\node_modules\selenium-webdriver\lib\error.js:546:15)
at parseHttpResponse (C:\sree\JS testing\examples\node_modules\selenium-webdriver\lib\http.js:509:13)
at doSend.then.response (C:\sree\JS testing\examples\node_modules\selenium-webdriver\lib\http.js:441:30)
at
at process._tickCallback (internal/process/next_tick.js:188:7)
From: Task: WebDriver.createSession()
at Function.createSession (C:\sree\JS testing\examples\node_modules\selenium-webdriver\lib\webdriver.js:769:24)
at Function.createSession (C:\sree\JS testing\examples\node_modules\selenium-webdriver\chrome.js:761:15)
at createDriver (C:\sree\JS testing\examples\node_modules\selenium-webdriver\index.js:170:33)
at Builder.build (C:\sree\JS testing\examples\node_modules\selenium-webdriver\index.js:626:16)
at Local.getNewDriver (C:\sree\JS testing\examples\node_modules\protractor\built\driverProviders\driverProvider.js:53:33)
at Runner.createBrowser (C:\sree\JS testing\examples\node_modules\protractor\built\runner.js:195:43)
at q.then.then (C:\sree\JS testing\examples\node_modules\protractor\built\runner.js:339:29)
at _fulfilled (C:\sree\JS testing\examples\node_modules\q\q.js:834:54)
at self.promiseDispatch.done (C:\sree\JS testing\examples\node_modules\q\q.js:863:30)
at Promise.promise.promiseDispatch (C:\sree\JS testing\examples\node_modules\q\q.js:796:13)
[18:46:38] E/launcher - Process exited with error code 199

Fatal error: protractor exited with code: 199
I am on windows 10. the driver file I have is chrome chromedriver_2.38.exe.
could you please help me with this?
regards,
Sreedhar.A

Hi, @alurisreedhar ! It looks like there might be problems in config or tests. Can you provide these sources?

@krotscheck tnx for noticing
@alurisreedhar
Since it involves usage and debugging (and you haven't used the issue template to indicate otherwise), your question is better suited for StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
From the getting help section of the README.

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Thanks!


Circuits cannot be filtered by location

Environment

Nautobot version (Docker tag too if applicable): 1.5.16
Python version: 3.9.2
Database platform, version: Postgres 13.9
Middleware(s): None

Steps to Reproduce

Create a Location
Create Circuits and assign them to the location
Try to filter the Circuits list with the location

Expected Behavior
A list of circuits assigned to this location

Observed Behavior
<class 'django.core.exceptions.FieldError'>

Unsupported lookup 'slug' for AutoSlugField or join on the field not permitted.

Python version: 3.9.2
Nautobot version: 1.5.16

Thanks for the report! Confirmed reproducible on demo.nautobot.com.

Interestingly appears to not be an issue in next as far as I can tell.

Is there a release date for next?


NTR: transforming growth factor beta receptor superfamily signaling pathway

Please provide as much information as you can:

Suggested term label:

transforming growth factor beta receptor superfamily signaling pathway

Definition (free text)

The series of molecular signals initiated by an extracellular ligand binding to a member of the transforming growth factor receptor superfamily, and ending with the regulation of a downstream cellular process, e.g. transcription.

Reference, in format PMID:#######

PMID: 28096268
PMID: 22651914

Gene product name and ID to be annotated to this term

This will be used to annotate some C. elegans genes, e.g. daf-1, a Type I receptor, that participate in signaling pathways that don't necessarily neatly map on to one of the existing subclasses of TGFbeta superfamily signaling, i.e. activin, BMP, or TGFbeta.

Parent term(s)

GO:0007178. transmembrane receptor protein serine/threonine kinase signaling pathway

Children terms (if applicable) Should any existing terms that should be moved underneath this new proposed term?

activin receptor signaling pathway (GO:0032924)
BMP receptor signaling pathway (GO:0030509)
transforming growth factor beta receptor signaling pathway (GO:0007179)

Synonyms (please specify, EXACT, BROAD, NARROW or RELATED)

Cross-references

For enzymes, please provide RHEA and/or EC numbers.

Can also provide MetaCyc, KEGG, Wikipedia, and other links.

Any other information

Please also see:  https://github.com/geneontology/go-ontology/issues/23449

perhaps  "only in metazoa"?  (at lerast never in fungi ?)


Plugin stopped working

I was about to experiment with a new "up" name and after I changed it in the preferences, the plugin stopped showing me data in the matrix view. Two errors popped up in the console:
`
VM159:35173 TypeError: arr.join is not a function
at MatrixView.getAlt (eval at  (app.js:1:1494667), :35044:49)
at MatrixView.toInternalLinkObj (eval at  (app.js:1:1494667), :34987:27)
at eval (eval at  (app.js:1:1494667), :35086:41)
at Array.map ()
at eval (eval at  (app.js:1:1494667), :35086:22)
at Array.map ()
at MatrixView.getHierSquares (eval at  (app.js:1:1494667), :35075:26)
at MatrixView.draw (eval at  (app.js:1:1494667), :35165:38)
at refreshIndex (eval at  (app.js:1:1494667), :34082:94)
at async Object.saveCommandDefinition.callback (eval at  (app.js:1:1494667), :62427:25)
draw @ VM159:35173
refreshIndex @ VM159:34082
await in refreshIndex (async)
saveCommandDefinition.callback @ VM159:62427
await in saveCommandDefinition.callback (async)
Mz @ app.js:1
e.executeCommandById @ app.js:1
e.onTrigger @ app.js:1
e.handleKey @ app.js:1
e.handleKey @ app.js:1
t.handleKey @ app.js:1
e.onKeyEvent @ app.js:1
VM159:35173 TypeError: arr.join is not a function
at MatrixView.getAlt (eval at  (app.js:1:1494667), :35044:49)
at MatrixView.toInternalLinkObj (eval at  (app.js:1:1494667), :34987:27)
at eval (eval at  (app.js:1:1494667), :35086:41)
at Array.map ()
at eval (eval at  (app.js:1:1494667), :35086:22)
at Array.map ()
at MatrixView.getHierSquares (eval at  (app.js:1:1494667), :35075:26)
at MatrixView.draw (eval at  (app.js:1:1494667), :35165:38)
at Object.saveCommandDefinition.callback (eval at  (app.js:1:1494667), :62430:46)
draw @ VM159:35173
saveCommandDefinition.callback @ VM159:62430
await in saveCommandDefinition.callback (async)
Mz @ app.js:1
e.executeCommandById @ app.js:1
e.onTrigger @ app.js:1
e.handleKey @ app.js:1
e.handleKey @ app.js:1
t.handleKey @ app.js:1
e.onKeyEvent @ app.js:1
`

Does this still happen for you?

I can't reproduce the issue anymore, it seems to work just fine.
Il giorno sab 13 gen 2024 alle ore 22:21 SkepticMystic <
@.***> ha scritto:

Does this still happen for you?
—
Reply to this email directly, view it on GitHub
https://github.com/SkepticMystic/breadcrumbs/issues/383#issuecomment-1890771939,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASZH4EJHVBIXYELUFBCW5T3YOL3FXAVCNFSM5UEZN7TKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBZGA3TOMJZGM4Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

Alright, thanks for letting me know. I'll close it out for now


Doc fix for Providers

Signed-off-by: MUzairS15<EMAIL_ADDRESS>Description
Doc fix for Providers
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 04ce141203d778f9f63870ac3146fe3fcb60b130 at: https://61d9d308d94b179d59c2f8bc--meshery-docs-preview.netlify.app

Renders correctly on my side.

Also the term <your-name-here> should also get printed.

https://github.com/meshery/meshery/pull/4908#issuecomment-1008088207
I am getting this on my side.

🚀 Preview for commit 52d51690496e0c37e9d2a376f7ad2cb8053f69f2 at: https://61da437f45fa191aa9467b64--meshery-docs-preview.netlify.app


TypeError: document.querySelector(...)

Full error repeating every time home panel loads in the HA log:
2020-05-20 16:13:47 ERROR (MainThread) [frontend.js.latest.202005190] http://hassnuc.local:8123/hacsfiles/custom-header/custom-header.js:596:28526 TypeError: document.querySelector(...).shadowRoot.querySelector(...).shadowRoot.querySelector(...) is null
HA 110.0, CH 1.4.0, HACS 24.5, Firefox 75.0
config:
custom_header:
  chevrons: false
  compact_mode: true
  header_text: Home
  hide_help: true
  voice_hide: true

Error no longer appears 1.4.1. New errors
custom-header/custom-header.js:1:15443 TypeError: undefined is not an object (evaluating 'e.voice.setAttribute')

Error has been reported in another issue and most likely already solved, latest version is 1.4.4

I’m sorry. Mistyped version. The latest HACS isn’t working correctly for me right now. Nether is the hamburger menu on several panels. Error above with your release of a few hours ago.

Be sure that the dev tools console shows CH version 1.4.4 and clear cache. Let me know if it's still an issue, thanks!

I'm on 1.4.4. It seems to be an issue with the new HACS (1.0.1) and safari. HACS on Safari isn't properly displaying version/info or repositories when clicking the + key. The Hamburger menu isn't working at all in Safari or iOS Companion App. It's really confusing. I'll wait to see if things improve over the course of the next few days. Thanks for your work. Nice addition on mobile.


Implement upload_part_copy for s3s_fs

Implemented upload_part_copy with one unit test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This branch has conflicts that must be resolved. See #91 .

@Nugine This PR is outdated and obsolete due to #91 . Will file a new one with appropriate changes. Apologies for the late response.


add user feedback when favorite is added

When adding a favorite using the favorite button there is no user feedback to know that it was properly added.   This causes me to click favorite twice.  The second time brings up a warning that the favorite was already created.

Closing. Won't fix. Introducing an extra click/message box is not needed.


Please consider using longtext instead of text

Please consider using longtext instead of text since longtext can save more content capacity
Refer: https://stackoverflow.com/a/13932834/1814613

Thanks for the suggestion @abr4xas. Two thoughts on it:

If you're going to make the content_html field longtext, would you agree that content_raw should be the same?
Since altering a migration is a habit we'd like to stay away from, could you refactor your changes and recommit them with a new migration instead of touching an old one?

@austintoddj sure... Let me work on that :smile:

Thanks @abr4xas. Just finishing up a couple more things on a feature branch and then I'll get this merged into develop for the next release. 👍


Fix readonly

Fixes https://github.com/kubevirt/kubevirt/issues/1036

The question is, if we want it to be filled out. The intention was to not serialize the default values for readOnly if the user does not set it explicitly. So at least from that perspective the correct solution is to check if the value is nil and let the converter in virt-launcher set the right value if it is nil, instead of setting the default value on the cluster.

@rmohr actually that's a really good point. Moved all logic to the DOM XML conversion side.


Update Examples and adjust config parser.

After creating your pull request, tick these boxes if they are applicable to you.

[x] I have tested my changes against the dev branch (the latest developmental version), and this pull request is targeting that branch as a base
[x] I have tested my changes on Python 3.8 or higher
[x] I have ensured my code is formatted using Black

Description
Address a few hiccups with config options.ini and add more clarification to example options

I just caught on to how you're naming your patches lol


Latest gradle version

What is latest gradle version of lib? 1.12 does not work

I forgot to put
maven { url "https://jitpack.io" }


Merge for version update v0.1.2

Summary
Merge for new bug-fixes, functionality updates and changes in documentation
Changes

Fixed UserClient bug of a passed user as a parameter not being recognised and silence-failing
Fixed property bug and raised exceptions when calling property values
Removed nest_asyncio and fixed run() and double event_loop creation
Rewrite of HTTP requests for better logging and details about errors
Added new /doc-examples for openhiven.py usage examples
Added HivenObjectConstructur for easier generation of objects and easier object passing

id like to ask github on why tf both:
A) README conflicted
B) WHY WE GOT A NOTI FOR THIS SEVERAL DAYS LATER

id like to ask github on why tf both:
A) README conflicted
B) WHY WE GOT A NOTI FOR THIS SEVERAL DAYS LATER

id like to ask github on why tf both:
A) README conflicted
B) WHY WE GOT A NOTI FOR THIS SEVERAL DAYS LATER

A) I think your commit caused it
B) I opened this rn

id like to ask github on why tf both:
A) README conflicted
B) WHY WE GOT A NOTI FOR THIS SEVERAL DAYS LATER

A) I think your commit caused it
B) I opened this rn

id like to ask github on why tf both:
A) README conflicted
B) WHY WE GOT A NOTI FOR THIS SEVERAL DAYS LATER

A) I think your commit caused it
B) I opened this rn

A) ok prob
B) "Nicolas-Klatzer added 6 commits 8 days ago"

id like to ask github on why tf both:
A) README conflicted
B) WHY WE GOT A NOTI FOR THIS SEVERAL DAYS LATER

A) I think your commit caused it
B) I opened this rn

A) ok prob
B) "Nicolas-Klatzer added 6 commits 8 days ago"

Will merge when #37 is finished

Will merge when #37 is finished

Will merge for release v<IP_ADDRESS> for bug-fixes in the utils extension and a major .env bug. => v0.1.2 will be merged in new pr

Will merge for release v<IP_ADDRESS> for bug-fixes in the utils extension and a major .env bug. => v0.1.2 will be merged in new pr


changed kind e2e k8s versions

Signed-off-by: Sourik Ghosh<EMAIL_ADDRESS>Description
changes kind e2e k8s version and SHA.
Please explain the changes you've made
Issue reference
closes #914
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

@mukundansundar review

@sourikghosh Thanks for the quick PR. Can you also make the change in the upgrade_e2e workflow to use the same versions of k8s?

@sourikghosh The sea versions seem to be different in the release notes for 0.12.0 ...

Are you talking about the Images built SHA for 0.12.0 release ??
1.23: kindest/node:v1.23.4@sha256:0e34f0d0fd448aa2f2819cfd74e99fe5793a6e4938b328f657c8e3f81ee0dfb9
1.22: kindest/node:v1.22.7@sha256:1dfd72d193bf7da64765fd2f2898f78663b9ba366c2aa74be1fd7498a1873166
1.21: kindest/node:v1.21.10@sha256:84709f09756ba4f863769bdcabe5edafc2ada72d3c8c44d6515fc581b66b029c
1.20: kindest/node:v1.20.15@sha256:393bb9096c6c4d723bb17bceb0896407d7db581532d11ea2839c80b28e5d8deb

Are you talking about the Images built SHA for 0.12.0 release ??
1.23: kindest/node:v1.23.4@sha256:0e34f0d0fd448aa2f2819cfd74e99fe5793a6e4938b328f657c8e3f81ee0dfb9 1.22: kindest/node:v1.22.7@sha256:1dfd72d193bf7da64765fd2f2898f78663b9ba366c2aa74be1fd7498a1873166 1.21: kindest/node:v1.21.10@sha256:84709f09756ba4f863769bdcabe5edafc2ada72d3c8c44d6515fc581b66b029c 1.20: kindest/node:v1.20.15@sha256:393bb9096c6c4d723bb17bceb0896407d7db581532d11ea2839c80b28e5d8deb

yes


KAFKA-15156 Update cipherInformation correctly in DefaultChannelMetadataRegistry

Assing the new value of cipherInformation to a member variable if the assigning variable value is not null. The previous implementation has a bug preventing it from getting updated with the new value.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[x] Verify documentation (including upgrade notes)

@divijvaidya

Did we mean to totally remove the null check here?

Did we mean to totally remove the null check here?

Pardon me, the topic is related to "update" of cipherInformation, and this PR has fixed that.
If you prefer to either keep checks or have more checks, I can file a PR to add consistent/explicit checks to both testing and production code.


WHSInboundASNV2Entity is now marked as Obsolete

The entity WHSInboundASNV2Entity is now marked as Obsolete.
The article & examples should be updated with the V3 version

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c35d4c92-5f41-b33d-1b69-7c0a1a5735e1
Version Independent ID: 57047047-df99-d7a4-548c-627fefc1888e
Content: Import inbound ASNs through the V2 data entity - Supply Chain Management | Dynamics 365
Content Source: articles/supply-chain/warehousing/import-asn-v2-data-entity.md
Service: dynamics-365-supply-chain
GitHub Login: @GalynaFedorova
Microsoft Alias: v-gfedorova

@maciek-o, thanks for providing this feedback.
@GalynaFedorova, please update the content as suggested.

Bug 693431 has been logged to track this issue.


Adds support for separate etcd machines on terraform/openstack deployment

This PR gives the terraform/openstack deployment the ability to provision a cluster with a separate set of machines for etcd, separated from the master machines. I have tested this locally to work on our OpenStack installation at EMBL-EBI EMBASSY Cloud.

@mattymo please let me know if you need more changes on this regard, I have addressed what you have pointed out so far.


Mirror for m-ailabs dataset

Hi @kan-bayashi
Could you, please, provide some temporary mirror link for m-ailabs dataset:
http://www.m-ailabs.bayern/en/the-mailabs-speech-dataset/
Thank you in advance

I found the mirror here:
https://www.caito.de/2019/01/the-m-ailabs-speech-dataset/


flock with timeout support

I like FlockMutex because it work on kernel level and is reliable.
however there's the problem that acquiring the lock makes program wait forever. I wish to get error "unable to obtain lock withing timeout"
for flock there's LOCK_NB flag which can be used.
ps: SemaphoreMutex has similar issue

+1 for SemaphoreMutex

Having a timeout is actually a nice feature. LOCK_NB would turn the implementation into a busy waiting lock and suffer from being inacurate. I will consider this option as a last resort. But first I will see if pcntl_alarm might be a better option.

i don't see how pcntl_alarm helps here, it's just weird way of saying sleep(2).
i'd love to see the timeout being implemented, as for inaccuracy and race conditions, i think the sleep and retry should be somehow randomized and exponential.
and as LOCK_NB would move the locking to "userspace" from "kernel", it should be enabled only when timeout > 0 so previous behavior could be used.

i don't see how pcntl_alarm helps here

It's a very effective way to put a timeout on flock():
pcntl_signal(SIGALRM, function() {});
pcntl_alarm(3);
try {
    if (!flock($handle, LOCK_EX)) {
        throw new \Exception("Timeout after 3 seconds");
    }
} finally {
    pcntl_alarm(0);
    pcntl_signal_dispatch();
    pcntl_signal(SIGALRM, SIG_DFL);
}

Unfortunately it doesn't seem to be portable, which is the whole point about flock(). I guess I'll chose a hybrid implementation, that is sending the signal, and falling back to busy waiting if pcntl is not available.

ah, it makes flock "timeout" without LOCK_NB, i see now

https://symfony.com/blog/new-in-symfony-3-3-lock-component
symfony/lock seems to have timeout support, it has flock backend. will test if it suits.

update: symfony/lock: blocking doesn't support timeout and for nonblocking mode one would need to implement timeout themselves: https://github.com/symfony/symfony/issues/25418

update2: seems flock doesn't support timeout: https://symfony.com/doc/3.4/components/lock.html#available-stores and nonblocking mode i misread the implementation (because i looked at internal code which were void: FlockStore::save, FlockStore::waitAndSave)

@TheLevti add link to your quoted reference. don't strip credits.

http://php.net/manual/en/intro.pcntl.php

Timeout support has been added to FlockMutex in the master branch.
It uses PCNTL if possible and busy waiting if not.
It's not production ready! But is't ready for some testing. Please report any issues here.

With php7.1+ it is possible to get the current signal handler to not just overwrite a possible existing one. http://php.net/manual/en/function.pcntl-signal-get-handler.php
So at least for php7.1+ the recommendation to not use the flock mutex when signal handler are used, can be changed.

@TheLevti I'm not extremely familiair with the signal handling. Could you incorporate this in a PR?
The changes should go into \malkusch\lock\util\PcntlTimeout::timeBoxed.

@TheLevti I'm not extremely familiair with the signal handling. Could you incorporate this in a PR?
The changes should go into \malkusch\lock\util\PcntlTimeout::timeBoxed.

Your latest additions to https://github.com/php-lock/lock/pull/26 should solve this.


doc: add more details in architecture.md

Signed-off-by: Allen Sun<EMAIL_ADDRESS>1.Describe what this PR did
This PR adds more details for architecture.
In ecosystem arch, I adds more things about three dimensions: runtime, orchestration and container.
In component arch, I add component illustration.
2.Does this pull request fix one issue?
NONE
3.Describe how you did it
NONE
4.Describe how to verify it
NONE
5.Special notes for reviews
NONE

Thank you greatly for your review. And updated now. PTAL @Letty5411

LGTM @allencloud

Thanks for your careful review. We need your professional skills very much. @Letty5411

LGTM


Reafactor/read state

Close #270
Please briefly answer these questions:

what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Optimize the trigger of IndexBarrier and IdBarrier
what changes does this pull request make?
trigger them when a command prepare/execute failed, only run necessary stages.
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
change interface of CommandExecutor

Please update the comment in issue #254


URLs/IP ranges for Hybrid Workers on Azure China

I notice there are no URLs for Azure China on the URLs to be allowed for the Hybrid Worker configuration.
Or is it that maybe Hybrid Workers in Azure China isn't supported yet?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3092ee3a-3c57-cc53-186b-b454e7d9d190
Version Independent ID: 6f6b5a07-397a-98a2-6091-941244a77837
Content: Azure Automation Hybrid Runbook Worker
Content Source: articles/automation/automation-hybrid-runbook-worker.md
Service: automation
Sub-service: process-automation
GitHub Login: @bobbytreed
Microsoft Alias: robreed

@KarlGW Thanks for the comment. We are actively investigating on the issue and will get back to you shortly with an update.

@KarlGW Please find below few of the document references for Azure China.
https://docs.azure.cn/zh-cn/automation/automation-hybrid-runbook-worker
https://docs.azure.cn/zh-cn/automation/automation-windows-hrw-install
https://docs.azure.cn/zh-cn/automation/automation-linux-hrw-install
https://docs.azure.cn/zh-cn/automation/automation-hrw-run-runbooks
https://docs.azure.cn/zh-cn/automation/troubleshoot/hybrid-runbook-worker

@KrishnaG-MSFT thank you very much for all the links, greatly appreciated!


brainflow: init unstable-2024-05-01

Description of changes
Blocked by https://github.com/NixOS/nixpkgs/pull/303716
Closes https://github.com/NixOS/nixpkgs/pull/278412 (supersedes)
Closes https://github.com/NixOS/nixpkgs/issues/303517
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

FYI - the reason I'm using the wheel rather than building from source is because the build process isn't documented anywhere, and it's clearly nontrivial.

Result of nixpkgs-review pr 303718 run on x86_64-linux 1

5 packages built:

brainflow
python311Packages.brainflow
python311Packages.brainflow.dist
python312Packages.brainflow
python312Packages.brainflow.dist

The python package has some issues. Let me go fix those.

Result of nixpkgs-review pr 303718 run on x86_64-linux 1

5 packages built:

brainflow
python311Packages.brainflow
python311Packages.brainflow.dist
python312Packages.brainflow
python312Packages.brainflow.dist

Result of nixpkgs-review pr 303718 run on x86_64-linux 1

5 packages built:

brainflow
python311Packages.brainflow
python311Packages.brainflow.dist
python312Packages.brainflow
python312Packages.brainflow.dist

I was successfully able to connect to my Muse MU-02. Further testing will be done later, but I am pretty confident in saying that this works right now.

Testing indicates this is fully functional!

@GrahamcOfBorg build brainflow python3Packages.brainflow

Whoops. Guess I'll open a new PR...


Replace hard-coded URLs pointing to upstream repos with variables that can point to our repos

There are some more hard-coded URLs pointing to github.com/atom/atom and github.com/atom/atom-nightly-releases. We should replace these with REPO_OWNER, MAIN_REPO and NIGHTLY_RELEASE_REPO, the same way that it's being handed in/as discussed in #70.
Specifically, for example:
const MAIN_REPO = process.env.MAIN_REPO || 'atom'

easy way to find many of these is to search for things like atom/atom or JS strings exactly matching the project/repo name 'atom' or even better 'atom-nightly-releases', although there are some other hard-coded usages that don't match those search patterns.
Some of them are less important than others, or we can live with the hard-coded version. For example, apparently we pull the Atom stable/beta/nightly/dev icons from upstream at the moment? But we haven't used a custom icon yet, so it doesn't make a difference.
There's obviously Atom's "Find in Project", or if you prefer grep on Unix, you can do git grep
example: git grep \'atom-nightly-releases\' -- script/vsts


docker composer build version not being displayed after installing

I Installed docker composer accordingly by first installing Docker followed by docker composer.when I tried to run the command for viewing the version of composer , composer  version is being displayed were as build version is not being displayed

d

@nischith2002 Please try below step.
Step 1: Download docker-compose from docker’s github repository
curl -L https://github.com/docker/compose/releases/download/1.27.4/docker-compose-uname -s\-`uname -m` > ~/docker-compose
Step2: Set the permissions
chmod +x ~/docker-compose
Step3:  Move the file
sudo mv ~/docker-compose /usr/local/bin/docker-compose
Then you’ll verify that the installation was successful by checking the version
docker-compose --version
Also try below step to verify docker-compose is working fine
Create docker-compose.yml YAML file and add below content
my-test:     image: hello-world
Run below command to create container
docker-compose up -d
Note :  Please ignore above issue if it worked fine
If you get any error then please provide your OS details, docker version and what command you used to install docker and docker-compose.

[https://github.com/docker/compose/releases/download/1.27.4/docker-compose-`uname](https://github.com/docker/compose/releases/download/1.27.4/docker-compose-`uname) -s-uname -m` > ~/docker-compose
this link is not working 404 error is being displayed

@nischith2002  Run below curl command in your terminal
curl -L https://github.com/docker/compose/releases/download/1.27.4/docker-compose-`uname -s`-`uname -m` > ~/docker-compose

thank you


Fix position of the overlay

Now that the overlay actually respects the position we give it, put it
somewhere where the keyboard won't overlap it.

LGTM


How to output the wrong retrieval data?

I have a question. I have used my own datasets to evaluated the models already. But the outcome didn't reach the expectation. So I want to output the wrong retrieval data. How can i achieve it?

I have a question. I have used my own datasets to evaluated the models already. But the outcome didn't reach the expectation. So I want to output the wrong retrieval data. How can i achieve it?

Sorry, I seem to be having a hard time following the concern.
If I understand correctly, you ran models on your own datasets but the scores are worse than using your custom code. Which models did you run?
And what does “output the wrong retrieval data” mean?

I ran some models like bge-m3 and nlp_corom_sentence-embedding_chinese-base(This is a custom model) on my own datasets. I am sorry that i don't explain clearly. My question is that the recall metric after testing is not very high, and I want to output the incorrect predictions. To see on which data the model's performance is poor.

Ah, you want to save your predictions so you can look at what is going on?  For that you can add the flag save_predictions=True to the mteb.run command
I don't think we've added bge-m3 to our model set yet, if you happen to figure it out we'd love a PR to add it to our models here.

okay, Thank you, I will try. I saw the bge-m3 model from https://huggingface.co/spaces/mteb/leaderboard.


Need some assistance in make a scene on "triangle numbers"

Hey.
I'm making a video about triangle numbers and want a scene that starts with T_1000 and splits to T_999+1000, then splits again to T_998+999+1000 and so on all the way down to 1, then make all the numbers from 1 to 1000 run across the screen.
See attachment for how I would like the first part of the scene to go. This is written "manually", but I believe this could be done in a loop somehow.
Any tips on how the code can be written will be appreciated, as well as other tips /ideas for how the scene could improve.
Scene3.zip

Hi @henrln. If you haven't already, I would suggest posting your question on Stack Overflow with the tag "manim" after formatting it to meet their guidelines. Not only is Stack Overflow someplace where there are many people also using the software that might know the answer to your question, but it also feels like more appropriate place to ask a question that is focused on how to use the software rather on developing the software.
To be clear, I'm not a manim expert nor part of the dev team — I'm just some rando from the internet making an unasked for suggestion. I hope that you get your question answered on Stack Overflow though. :)

Thank you @matthewfeickert  for pointing me to the correct forum. I'll ask again over there :)


app login

What is the default email and password I used admin for both but can't login into the app

It seems the ip address in connection.js file line 6 is hardcoded I've edited the address and it works fine now

Great! I was about to point that.
I'll describe on the documentation where to find and how to change.


Predicate syntax reference

There's perhaps a small typo in injections queries, where #eq should've been #eq?, at least that's what Lua TS binding lib uses, as well as Rust and Webassembly. Here's an error from nvim:
Error detected while processing FileType Autocommands for "*":
Error executing lua callback: /usr/share/nvim/runtime/lua/vim/treesitter/query.lua:418: No handler for eq
stack traceback:
        [C]: in function 'error'
        /usr/share/nvim/runtime/lua/vim/treesitter/query.lua:418: in function 'match_preds'
        /usr/share/nvim/runtime/lua/vim/treesitter/query.lua:564: in function '(for generator)'
        /usr/share/nvim/runtime/lua/vim/treesitter/languagetree.lua:314: in function '_get_injections'
        /usr/share/nvim/runtime/lua/vim/treesitter/languagetree.lua:131: in function 'parse'
        /usr/share/nvim/runtime/lua/vim/treesitter.lua:68: in function '_create_parser'
        /usr/share/nvim/runtime/lua/vim/treesitter.lua:94: in function 'get_parser'

But I'm not sure since docs (Predicates section) state that predicates are handled by "higher level code", so perhaps the author of this query had used parser where question mark is omitted from predicate syntax. Anyway, adding ? fixed mentioned error for me.
Minimal reproducing code:
defmodule Foo do
  @foo ~w(bar) # error happens here
end

Good catch! That line should be #eq?. All tree-sitter consumers that I know of use #eq?, but you're right that they're implemented by higher level code. For example, neovim implements #any-of? while tree-sitter-cli does not.
I'll push a commit to fix this. Thanks for the report!

Good catch, currently I get this:

and it's the same when changing #eq to #whatever, so it seems like there's some error that is being silently ignored. With the change it works as expected


Daily/monthly sensors are not reset at midnight/end of the month

Describe the bug
The daily sensor is not (always) reset a midnight to 0 and the monthly sensor is not rest at the end of the month
Expected behavior
I expect that at 0:00 every night the Daily sensor will be set to 0.00 and at the end of the month the monthly sensor will be set to 0
Screenshots
Example daily

Example montly

I'm also experiencing the same issue. It only happens to the Sensors based on Power Usage.
The sensors based on Energy Usage, resets fine.

@gregbarreiro
Does it work always for the energy based sensors? Daily/Montly/Yearly? (I understand that yearly is difficult to check)
@martinarva
I checked the code difference energy_based_sensors.py and power_based_sensors.py code and could see some differences in the calculate_next_reset_time(self) function
if self._interval == "daily":
      next_reset = current_time.replace(hour=0, minute=0, second=0, microsecond=0) + timedelta(days=1)

if self._interval == "daily":
      next_reset = (current_time + timedelta(days=1)).replace(hour=0, minute=0, second=0, microsecond=0)

Could this be the reason why its working for the energy sensors and not for the power sensors?

@gregbarreiro Does it work always for the energy based sensors? Daily/Montly/Yearly? (I understand that yearly is difficult to check)
@martinarva I checked the code difference energy_based_sensors.py and power_based_sensors.py code and could see some differences in the calculate_next_reset_time(self) function
if self._interval == "daily":
      next_reset = current_time.replace(hour=0, minute=0, second=0, microsecond=0) + timedelta(days=1)

if self._interval == "daily":
      next_reset = (current_time + timedelta(days=1)).replace(hour=0, minute=0, second=0, microsecond=0)

Could this be the reason why its working for the energy sensors and not for the power sensors?

@DutchKillerbee
Yes, just checked!
The Energy Based sensors resets are OK on both month and day sensors.
The power based sensors resets varies, some days it resets and some day it doesn't. I've noticed that the day after a HA-reboot it works, the other days it varies. I have only one of these sensors. The monthly reset worked properly. For now I've created an automation that resets the sensor at 12:05.
Groet.
Greg

@DutchKillerbee I'm responding to your question posted in https://github.com/martinarva/dynamic_energy_cost/issues/26#issuecomment-2158029154 over here to keep the comments and issues together.

@Pluimvee I noticed you changed this part of the code only in the energy sensor code  what was the reason for this? for me resetting daily/monthly power sensor doesn't always work. Could your fix also work for the power sensor? issue: #30

I changed the reset schedule as I think the reset issue is caused by a race condition. Exactly at 0:00 there are two events fired: a price change event and a timer event. Due to the async definitions of the methods being invoked, the code is executed concurrently and may cause issues.
A proper way to resolve this is by either define the methods synchronous, but I'm not sure if this is in line to HA specs, or by using a mutex. As I'm not a python developer I need to investigate and test. For now I simply changed the reset timer to one second after 0:00 to prevent being fired at the same time as the market price changes.
Ps.: as I'm currently using my suggested logic to determine export/import pricing (see https://github.com/martinarva/dynamic_energy_cost/pull/31#issuecomment-2147092179) a fluctuation in net power usage may also trigger a change in my price sensor and could, potentially, also trigger a price event at 1 second passed 0:00. The changes on this are very slim as I do not switch from production to consumption, or vice versa, during midnight.
Why I didn't change this in the power based code is for three reasons:

The above is a temporarily fix

I don't like the power based solution as this code is based on changes in power usage and assumes the power usage is constant between two sensor updates. As such the accuracy of the cost calculation is dependent on the update frequency of the used power sensor. If, for example, the power sensor updates each 15 second the code 'assumes' the power consumption to be constant for 15 seconds. If this less accuracy is acceptable, or the power sensor gives more frequent updates, then I suggest to use the out-of-the-box integral helper to convert power (W) into energy (kWh) and use the latter as input for the energy based sensor of this component.

Because the power changes more frequent, also during midnight, the risk of having a race condition is higher, and therefore a better solution (mutex) is needed.

I used the quick fix of @Pluimvee on the power daily/monthly sensors and it seems to work for me.
if self._interval == "daily":
      next_reset = current_time.replace(hour=0, minute=0, second=2, microsecond=0) + timedelta(days=1)

I have the same problem of not resetting the daily power sensor at midnigh.
I will use the solution of @DutchKillerbee and check if this is working.

I have the same problem of not resetting the daily power sensor at midnight. I will use the solution of @DutchKillerbee and check if this is working.

Didn't work

I also tried to use the solution of @DutchKillerbee , but unfortunately the issu remains Daily sensors don't reset at midnight and so the values keep incrementing daily.

@brugk000 @jarrodstrachan96
I have to admit it's not working stable for me as well
What I finally did is creating an automation who starts at 00:00:01 and run the service/action dynamic_energy_cost.reset_cost for your_daily_dynamic_cost_sensor
That did the trick for me

@brugk000 @jarrodstrachan96 I have to admit it's not working stable for me as well
What I finally did is creating an automation who starts at 00:00:01 and run the service/action dynamic_energy_cost.reset_cost for your_daily_dynamic_cost_sensor
That did the trick for me

Nice solution, will do the same - thanks


TypeError: concat() got an unexpected keyword argument 'sort'

What's going on here?

Looks like you’re using an older version of pandas.
Run:
pip install pandas -U
And try again.  This error should be gone now.
Ran
On 30 May 2019, at 3:24, AashinShazar<EMAIL_ADDRESS>wrote:
[image: image]
https://user-images.githubusercontent.com/44244230/58599720-52c50800-8236-11e9-86df-0024903eb86e.png
What's going on here?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ranaroussi/yfinance/issues/67?email_source=notifications&email_token=AAJBNMXCEBERI4XTIFFPFWTPX4NC7A5CNFSM4HQYZNIKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GWTTG3Q,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJBNMQHV6U5LUXFKLAZDM3PX4NC7ANCNFSM4HQYZNIA
.

Looks like you’re using an old version of pandas (yfinance requires Pandas >= 0.23.0).
Run "pip install pandas -U" and try again.  This error should be gone now.
Ran

Ah that seemed like the issue. Thank you so much!

Looks like you’re using an old version of pandas (yfinance requires Pandas >= 0.23.0).
Run "pip install pandas -U" and try again. This error should be gone now.
Ran

I have tried this but still not working :(. Any suggestions on why?

And even more strangely, it works perfectly on the tutorial I was trying to follow on my computer.


Broken link in uaa-release README - Story Id: 126559849

Link: https://www.pivotaltracker.com/story/show/126559849
Labels:
Requester: Madhura Bhave
Estimate: 0.0

https://github.com/cloudfoundry/uaa-release/blob/develop/README.md

Link: https://www.pivotaltracker.com/n/projects/997278/stories/126559849/comments144230951
User: Madhura Bhave

@stummidi
Comment Id: 144230951


Carthage update fails with XCode 8 / Swift 2.3

After updating to XCode 8 and converting the project to Swift 2.3 I get this when attempting
carthage update --platform iOS:
The following build commands failed:
    Check dependencies
(1 failure)
warning: no umbrella header found for target 'SwifteriOS', module map will not be generated
warning: no umbrella header found for target 'SwifteriOS', module map will not be generated
A shell task (/usr/bin/xcrun xcodebuild -project /Users/Joe/Desktop/TheApp/Carthage/Checkouts/swifter/XCode/Swifter.xcodeproj -scheme SwifteriOS -configuration Release -sdk iphoneos ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build) failed with exit code 65:
** CLEAN FAILED **

Advice on how to fix this would be great!

Maybe you want to consider migrating your project to Swift 3.

That was the first thing I tried, but got the same issue.  I noticed that there were other issues reported with Swift 3 (Swifter does not appear to support Swift 3 yet), so I next tried with Swift 2.3 (expecting that at least this "legacy version" would work)...

Maybe you want to try it again. I had an simular situtation, but since yesterday, swifter supports XCode, Swift 3 (look into the commits). I was able to compile with Swift 3.

I created a fork and restructure the folders so that carthage would not complain: https://github.com/marcoconti83/swifter . It fixed it for me.


I am using geofirestore

I am using geofirestore, that awesome. But have question.
In my app i have doc with some key-values and i need to store location for each of them.
if i am using geoFirestore.query({...}); with center and radius. Then inside key-entered i got key, doc and distance.
however as doc i got everything that stored under d key. But all my other data is stored directly inside doc, on same level as d
So i need to perform one more request to get all other data which is not very good.
Do geofirestore can give an ability to get all doc data by geoquery with center and radius ?
Thanks.

Geofirestore is intended to wrap the document, so you shouldn't be trying to store details on the same level as d.. That's where geofirestore works. I'd suggest reworking your data to fit the structure geofirestore uses.


[YUNIKORN-2787] Eliminate gosec lint warnings

What is this PR for?
Eliminate gosec warnings from the test when running "make lint".
What type of PR is it?

[ ] - Bug Fix
[x] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2787
How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

I cannot reproduce the warnings in the current master code. Are you sure you are running an up to date linter that complains?

Ah yes, I just deleted "tools" and the latest linter doesn't complain, which is interesting. Anyway, this PR can be abandones then.


Extremely slow, and resource(CPU) usage high on Firefox when the prompt is large

Describe the bug
Provide a large prompt like an article, the CPU usage of the Firefox browser will be 100%, the whole UI response will be very slow, even though the response is not that large(like limited to 1000 token)
Expected behavior
Normal response speed and CPU usage?
Environment

OS: Ubuntu 22.04
Browser: Firefox 112.0.1 (64-bit)
Extension Version: v2.2.8
No other browser extension installed, only chatGPTBox

Is there an article url that can reproduce this issue?

https://www.theguardian.com/science/2021/jul/05/sixty-years-of-climate-change-warnings-the-signs-that-were-missed-and-ignored
Tested with whole webpage selected via Ctrl + A, ask gpt-4-32k model to translate it, if paste one time is not slow enough for a faster environment, maybe paste it twice will help.

Try folding the conversation before asking, ensuring that all content before each question is in a collapsed state. Will this improve the situation? The problem may be that I haven't optimized the rendering for React, so it is rendering all content in full each time.

I'm not 100% sure but it seems folded conversation also causing #462, so the situation becomes a limit for long content, even if I'm okay with the CPU usage, sometimes the tab will just crash 😓

fixed in https://github.com/josStorer/chatGPTBox/commit/d36f6ea245ab8f72d72d12199e3d49ca12fb9f2e


Add contributions templates

@fnlctrl I don't know what the Chinese text says 😛 I just took the vue issue template and replaced the jsfiddle links. I still think that the issue template is too long and I fear people will just ignore it and we end up not gaining any time.

Yeah, maybe we should make it shorter..
About the Chinese text (It's actually concise and straight to the point 😂 , though not very friendly):
中文用户请注意：
Attention Chinese users:

1. issue 只接受带重现的 bug 报告，请不要用来提问题！不符合要求的 issue 会被直接关闭。
The issue list only accepts bug reports with reproductions, do not ask questions here. Issues that fails to comply will be immediately closed.

2. 请尽量用英文描述你的 issue，这样能够让尽可能多的人帮到你。
Please try to describe your issue in English, so that more people can help.

I'll think of something this afternoon. All of the points are important imo but the real deal is to prevent useless issues to appear and in order to do that we have to find the right balance so people really take the time to read the template

@fnlctrl After thinking about it, I don't think it's necessary to shrink the message. It's fine like this. We can start with this anyway and improve progressively. Feel free to merge


Incorrect results for reverse-mode differentiation of scan wrt sequence

Differentiating the output of a scan operation with respect to the sequence being scanned over seems to incorrectly give zero-derivatives when using reverse-mode routines such as api.vjp or api.grad. As a simple example if we define the following function
import jax.numpy as np
from jax import lax, api

def scan_func(ns, x0, a):

    def trans_func(x, n):
        x = x + a * n
        return (x, x)

    _, xs = lax.scan(trans_func, x0, ns)

    return xs

and the following inputs
a = 1.
x0 = np.array(0.)
n_step = 5
ns = np.arange(n_step) * 1.  # force float

and define xs = scan_func(ns, x0, a) then we would expect the Jacobian dxs[i] / dns[j] to be a lower-triangular matrix with all one entries.
Applying api.jvp to scan_func to compute a series of JVPs to construct the Jacobian gives the correct result:
np.stack([
    api.jvp(lambda ns_: scan_func(ns_, x0, a), (ns,), (basis_vct,))[1]
    for basis_vct in np.identity(n_step)], 1)

outputs
DeviceArray([[1., 0., 0., 0., 0.],
             [1., 1., 0., 0., 0.],
             [1., 1., 1., 0., 0.],
             [1., 1., 1., 1., 0.],
             [1., 1., 1., 1., 1.]], dtype=float32)

However trying something analogous with api.vjp gives a zero-matrix out:
np.stack([
    api.vjp(lambda ns_: scan_func(ns_, x0, a), ns)[1](basis_vct)[0]
    for basis_vct in np.identity(n_step)], 0)

outputs
DeviceArray([[0., 0., 0., 0., 0.],
             [0., 0., 0., 0., 0.],
             [0., 0., 0., 0., 0.],
             [0., 0., 0., 0., 0.],
             [0., 0., 0., 0., 0.]], dtype=float32)

Similarly applying api.grad to the sum the output of scan_func gives the incorrect result
api.grad(lambda ns: np.sum(scan_func(ns, x0, a)))(ns)

outputs
_FilledConstant([0., 0., 0., 0., 0.], dtype=float32)

rather than the expected DeviceArray([5., 4., 3., 2., 1.], dtype=float32).
This only appears to be an issue when differentiating with respect to an argument corresponding to the sequence being scanned over - for example both
api.grad(lambda x0_: np.sum(scan_func(ns, x0_, a)))(x0)

and
api.grad(lambda a_: np.sum(scan_func(ns, x0, a_)))(a)

output the correct values.

Thanks for the wonderful report! That's super clear.
In the last couple hours we just squashed a scan autodiff bug in #749 (and greatly improved the scan autodiff tests, which were lacking, pretty sloppy of us). That fix is merged into master and on pypi as well (as jax version 0.1.34 and later).
I tried your code on master after that fix and it seems to work. It seems we caught the bug at about the same time! Can you check that fix on master (and jax 0.1.34) fixes things for you?
(On master, we now check scan forward- and reverse-mode (and mixed mode) derivatives up to order 2 using the handy check_grads function that all our users should use.)

Thanks for the super quick response!
Re-running the code after pulling the latest commits does indeed now give the expected results - great timing with the fix :smile: !
Thanks also for the heads-up with regards to the check_grads function - I had previously been manually doing finite-difference checks so that will makes things a lot easier.

Apologies for any time of yours this bug wasted. I can't believe we forgot to use our own check_grads on scan. That'll teach us... I'll never forget you again, check_grads!
Maybe we should put check_grads in every code example.
In any case, glad you're unstuck, and thanks again for making this report in a super clear way. It would have saved us time if we had seen it a few hours earlier!


Tokens are not writable except for superusers

Environment

Python version: 3.7.3
Nautobot version: nautobot-device-onboarding==1.0.1
nautobot-golden-config: develop
nautobot-plugin-nornir: 0.9.0

Steps to Reproduce

Create a normal active user
Add token to user with 'write enabled' checked
Set group permission to all permissions (all items and add, delete, change etc)
Try to update via the API (I use the nautobot ansible collection)
Not possible to update, message:

Device Updated

"msg": "{\"detail\":\"You do not have permission to perform this action.\"}"}

@bsmeding Can you please provide details on the group permission? Did you create a new group and assign permissions? Can you please provide the exact permission set you added to the group? Thank you!

FYI, I tested quickly on https://demo.nautobot.com/ and I was able to modify an existing object with the demo user (not super admin)
Specifically I was able to do a PATCH on a site to change the description
curl --location --request PATCH 'https://demo.nautobot.com/api/dcim/sites/a325e477-62fe-47f0-8b67-acf411b1868f/' \
--header 'Authorization: Token aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' \
--header 'Content-Type: application/json' \
--data-raw '{
    "description": "Updated from the API with demo user"
}'

Hi @jathanism, almost all the permissions are set:

Will try the API directly, but can do this only next week

I tried the same CURL, without success,
ansible01 user, standard user with almost all permissions in group setting described above
root@ansible01:/data/ansible/cmdb# curl -k --location --request PATCH 'https://<IP_ADDRESS>/api/dcim/sites/7907ed8b-82e3-4979-8832-81f335b69f9f/' \
> --header 'Authorization: Token aaaaaaaaaaaaaaaaaaaaaaaaa' \
> --header 'Content-Type: application/json' \
> --data-raw '{
>     "description": "Updated from the API with ansible01 user"
> }'
{"detail":"You do not have permission to perform this action."}root@ansible01:/data/ansible/cmdb#
root@ansible01:/data/ansible/cmdb#

same CURL now with admin token
root@ansible01:/data/ansible/cmdb# curl -k --location --request PATCH 'https://<IP_ADDRESS>/api/dcim/sites/7907ed8b-82e3-4979-8832-81f335b69f9f/' \
> --header 'Authorization: Token bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' \
> --header 'Content-Type: application/json' \
> --data-raw '{
>     "description": "Updated from the API with admin user"
> }'
{"id":"7907ed8b-82e3-4979-8832-81f335b69f9f","url":"https://<IP_ADDRESS>/api/dcim/sites/7907ed8b-82e3-4979-8832-81f335b69f9f/","name":"poc_schiedam","slug":"poc_schiedam","status":{"value":"active","label":"Active"},"region":null,"tenant":null,"facility":"","asn":null,"time_zone":null,"description":"Updated from the API with admin user","physical_address":"","shipping_address":"","latitude":null,"longitude":null,"contact_name":"","contact_phone":"","contact_email":"","comments":"","tags":[],"custom_fields":{},"created":"2021-05-10","last_updated":"2021-05-17T10:40:58.496993+02:00","circuit_count":0,"device_count":8,"prefix_count":0,"rack_count":0,"virtualmachine_count":0,"vlan_count":0,"display":"poc_site"}root@ansible01:/data/ansible/cmdb#
root@ansible01:/data/ansible/cmdb#

@bsmeding are you sure your user is inheriting the Network Developers permissions ? in your screenshot it looks like Network Developers is not associated with any users or any groups

Yes the user is in the correct/only group created

@bsmeding it looks like you have both a Group and an Object Permission named Network Developers but they are not associated with each other.
This screenshot clearly shows that the Object Permisson Network developers is not associated with any user or group

Please can you try to add the group Network Developers to the Object Permission Network Developers, you can do that in the object permission edit view

@dgarros Yes that was missing thanks!, my bad overlooked the assignment. working from curl and ansible now


Coding standard

Hi what php coding standard are you using? I've been working on echosign widgets and I want to get it right! Thanks

I start on the v3 soon. I'll have to go over the docs this next week and take a look at what has changed.


Problem with resolution with power management

Hello
I have some strange problem:
After the laptop get into power saving mode (only turning the display off) and wake up i see the desktop on only quarter of the screen , I played with the energy saver option but it’s happing all the time .

Are you using HiDPI ? If you don't use the recommended resolution, you'll have issues, I do have this problem, to get it to full screen, click the apple logo and select sleep, but immediately the screen goes off, press spacebar to abort and  wake it up, this isn't a good  way out because, you'll have glittering screen on wake-up, the solution is a restart, or use the recommended resolution

yes I'm using the HiDPI - what is the recommend resolution ?

Recommended resolution 1344 x 756

Thanks - and when using this resolution, I will not have this problem?

I got no problem with that so far


I edited the layout/design of create teams, and also edited the layout in analyze, and for logged in view. Now all views have the same layout/design

Great job updating the layout and design for create teams, analyze, and the logged-in view! Ensuring consistent design across all views improves the user experience and enhances the overall professionalism of the application. Now we can follow Clean Architecture properly and the user won't be confused when navigating through our Views


oh2iob - Unknown type: quantity

Hi , i get the following message in the log.
openhab.0 | 2018-12-10 17:26:12.388 | warn | oh2iob - Unknown type: quantity

@Schluesselmeister can you add it to adapter? I think it is number. :)

@GermanBluefox I can try. At the moment I haven't running any ioBroker instance.
Please provide the item defintion. Which version of OH are you using?

Same issue for openhab 2.4 release. But for several types. Also it seems that the items get no update from openhab. I have to restart openhab adapter instance to update item status.
What do you exactly need to debug

OK, I have OH2.4 installed. I will have a look.

Hi,
I have modified the main.js file. Unfortunatelly I cannot upload the file directly to the master branch.
@GermanBluefox : Would you be so kind to upload the file? I have  added support for "quantity", "call" and "stringlist" (at least reading the data).
main.zip

Fixed in https://github.com/ioBroker/ioBroker.openhab/commit/80146c692b7adbf8524eeeb49caf77e31e282331

@jensfr1
The missing updates seems to be an issue on OH side. So thank you for your investigation


Brave 4.x modernization

This includes code resurrected from earlier attempts to adapt a replacement for the interceptors from Brave 3. This includes a replacement for every instrumentation (except cxf which is in flux).
Expect this to change dramatically until explicitly noted that it is stabilizing.

[x] Rough in a tentative client and server tracer api
[x] Integrate each library such that it sets spans in scope so Tracer.currentSpan() works
[x] Integrate each staticly initialized library such that it uses Tracer.current()
[x] Backport client and server integration tests
[ ] ensure we can swap out propagation format when needed. Ex https://github.com/TraceContext/tracecontext-spec
[ ] take a closer look at instrumentation approach and generalize anything copy/pasted >3 times
[ ] revise tagging approach so that it solves #276 #264

waiting a day for feedback on https://github.com/openzipkin/brave/issues/166#issuecomment-277634798 before proceeding to implement with the propagation design in mind

added jaxrs2 client impl and tests

ok all client instrumentation has been retouched except the database ones.. I'm kindof going to save "best for last" on that one. Moving on to server instrumentation
note: pay little attention to the "Config" types defined, they haven't been thought through and are subject to change. This is mainly getting all tests passing and exercising the "current span" apis

added some of the server instrumentation cc @kmaci3k
note: this PR needs one change to the "current span" PR it depends on #369, which is a replacement for BraveExecutorService (a couple http client libraries need it and tests are disabled until that's in)

all instrumentation except jdbc, mysql and cxf have been redone. I will probably do cxf just to prove the api approach works

rebased on top of #369

NEXT STEPS:

implement sparkjava and database instrumentation with brave 4 apis
take a closer look at instrumentation approach and generalize anything copy/pasted >3 times
revise tagging approach so that it solves #276 #264

UPDATE: implemented sparkjava and database instrumentation with brave 4 apis
noticed we should revisit #210 as the database drivers need a reference to a tracer post-initialization (static reference)

ok rebased over some build things that were tripping up yesterday. will resume in a bit

ok current code solves the JDBC problem via #379
Moving on to other todos

https://github.com/openzipkin/brave/pull/381 is needed so that we can wire in propagation handlers

rebased over #381 but not refactored to take advantage of it (beyond making propagation type not explicit)

Ahah but if it did the test would fail!
This is not the async client, so it is blocking (same thread). Theres
another safety which is the strict context impl. Havent done async in this
library yet
On 22 Apr 2017 23:16, "Pavol Loffay"<EMAIL_ADDRESS>wrote:
@pavolloffay commented on this pull request.
In brave-apache-http-interceptors/src/main/java/brave/httpclient4/
HttpClientTracing.java
https://github.com/openzipkin/brave/pull/350#discussion_r112811778:

/**

Preferred way for constructing http clients, as it allows use of
{@link Tracer#currentSpan}

Implicitly requires a minimum version of httpclient 4.3

*/
public HttpClientBuilder httpClientBuilder() {
return new HttpClientBuilder() {

 /**

  * protocol exec is the second in the execution chain, so is

invoked before a request is

  * provisioned. We provision and scope a span here, so that

application interceptors can see

  * it via {@link Tracer#currentSpan()}.

  */

 @Override protected ClientExecChain

decorateProtocolExec(ClientExecChain exec) {

   return (route, request, context, execAware) -> {

     Span next = tracer.nextSpan();

It is a nice approach 👍 But It seems that this is run in a different
thread.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/brave/pull/350#pullrequestreview-34159439,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD617ros2_pXW6WhFc7B8kBn_bmsirkks5ryhnrgaJpZM4LtJZf
.

@adriancole thanks, my fault I didn't use brave API properly. It's pity that this cannot be used for an async client.

@adriancole https://github.com/adriancole thanks, my fault I didn't use
brave API properly. It's pity that this cannot be used for an async client
Async has different dep (different version number too annoyingly). Imho it
is better to align these with the primary jar.. so not a big deal to do
another type for async. Also that keeps complexity in the async type. Our
old interceptors didnt work well for async anyway.

started readying for final lap.. this included removing instrumentation that is very old (like jersey v1 as they can be asked for later).. I've moved all new instrumentation under the instrumentation folder and using brave-instrumentation-X which is similar naming to zipkin-js
here's what's left.

rework client code to be like server code
cleanup READMEs
add javadoc
get others to look at it.

ok reworked the server code. other pending todos still todos

implemented async servlet and servlet 2.5 support. only thing left is async http client, look into jaxrs annotation things then cleanups.

to test servlet 2.5 will be a minor pain (a maven invoker test, like we have in zipkin-server). I will definitely add this as otherwise it is punting to eyeballing and hoping it works.

ok servlet 2.5 tests are in (via maven invoker). Glad I added them as I had a bug in my class detection stuff.

next thing I have is the apache async http client (mostly to show it can work).
I'm pretty happy with the api, but will likely polish it a little after stepping back and looking at each instrumentation closely.

ok added HttpTracing component, which I think dramatically simplifies construction of instrumentation. Most are less than 100lines all-in

added tests to ensure grpc is compatible with both v1.2 and v1.3

rewrote all the readmes.
waiting on this to merge https://github.com/openzipkin/zipkin/pull/1580
need to add http redirect tests, as I'm pretty sure some clients will have unexpected behavior

renaming httpclient4 to httpclient since apache has made a new artifact httpclient5 (although not released anything on that in over a year)

ok httpasync client works.
TODO:

Add tests for http client redirects
Revisit exception parsing
Revisit remote address parsing

redirect test indeed broke a couple of the clients... fixing now

ok epic work to get redirects operating with expected output (span per attempt) is in.
next up is polishing exception handling a remote address parsing. final lap

ok I have hidden everything not required to expose. tests are good, and I think the code is, too.
I have to document things tonight, but codewise, would appreciate any valiance in review, notably the customization model for HttpTracing. Here's a unit test of that.
For example, to override the naming policy for spans, you can do this, which will affect any http client:
    httpTracing = httpTracing.toBuilder()
        .clientParser(new HttpClientParser() {
          // note you can take advantage of the actual request. ex req instanceof HttpServletRequest!
          @Override public <Req> String spanName(HttpAdapter<Req, ?> adapter, Req req) {
            return adapter.method(req).toLowerCase() + " " + adapter.path(req);
          }
        })
        .build();

Then when you are configuring a specific http client, you can assign the server name like so:
    httpTracing = httpTracing.toBuilder().serverName("remote-service").build();

added a few client benchmarks.. I'll add the others including server-side later.

fyi here's an example run of the few client benchmarks (they are real requests, but against a stupid server)
Benchmark                                                                       Mode  Cnt   Score   Error  Units
b.httpasyncclient.ApacheHttpAsyncClientBenchmarks.client_get                    avgt   15  61.399 ± 2.494  us/op
b.httpasyncclient.ApacheHttpAsyncClientBenchmarks.tracedButUnsampledClient_get  avgt   15  67.709 ± 4.623  us/op
b.httpasyncclient.ApacheHttpAsyncClientBenchmarks.tracedClient_get              avgt   15  69.701 ± 1.161  us/op
b.httpclient.ApacheHttpClientBenchmarks.client_get                              avgt   15  38.741 ± 1.196  us/op
b.httpclient.ApacheHttpClientBenchmarks.tracedButUnsampledClient_get            avgt   15  40.383 ± 0.768  us/op
b.httpclient.ApacheHttpClientBenchmarks.tracedClient_get                        avgt   15  45.378 ± 0.615  us/op
b.okhttp3.OkHttpClientBenchmarks.client_get                                     avgt   15  48.136 ± 1.143  us/op
b.okhttp3.OkHttpClientBenchmarks.tracedButUnsampledClient_get                   avgt   15  52.169 ± 2.923  us/op
b.okhttp3.OkHttpClientBenchmarks.tracedClient_get                               avgt   15  54.037 ± 1.181  us/op

ok all http client impls are now benchmarked. going to the http server ones next

just pushed benchmarks for all the http implementations client and server alike!

there's something up with the apachehc benchmark, as it crashes on socket problems immediately. All the others ran.  I'll check and see if @jplock's advice about the annotation is at fault, or something else.

actually even the untraced jaxrs-client perf is significantly worse than others. Maybe there's just some overhead that's implicit with the configuration involved.

merging so that @jplock @llinder @devinsba and others can try it out for a few days via snapshots prior to release. As a reminder, the snapshot repository is http://oss.jfrog.org/artifactory/oss-snapshot-local

ps rewrote the PR description so it is more accessible

during integration testing with an example app, I noticed a glitch in how we handle scope. We should remove the span from scope before reporting the span, as otherwise it is confusing in logging case.
Heads up for a revision which tightens up the tests to make sure context is cleaned before reporting the span.

https://github.com/openzipkin/brave/pull/393


latency result slower than tensorrt fp16

Hi, I tried to replicate your speed experiment, I tested the deit_tiny, batch size=1, RTX3090 environment, after a few days of autotune, compared to tensorrt FP16, speed is still slower.
Here are the results of my experiment:

Hi.
Our I-ViT TVM implementation is designed for the Turing Tensor Core (RTX 2080Ti), so there could be potential issues in the Ampere Tensor Core (RTX 3090) environment which could lead to sub-optimal optimizations.
We are also working on exploring solutions. And, if it's convenient, please let me know the version of TVM and TensorRT you're using.

Thanks for your reply, my development environment is
TVM: 0.14.dev0
tensorrt: 8.6.1

Hello, I just wanted to add that I saw the same issue on an A6000 with tensorrt10. @zhanglei1172 can I ask when you tried to use it tensorrt int8 whether you enabled fp16 as a fallback? And @zkkli, can I ask in your experiments if the times were measuered using TensorRT? Thanks !


updated to latest versions, fixed release mode launch

Updated all packages to latest versions, except ethers (update to latest 3.x version).  Made some minor changes to support new version of react-navigation in route.js

Sorry for taking so long to review. I just downloaded your branch to run locally, and it does not build.

Hmm, I'm able to run it using yarn ios and build it in Xcode in release mode...  What errors are you getting?  Maybe try react-native link first?

Yeah, doing this way works. I tried with Android. But there's no problem, at least it's a good point to start from. There's just a conflict with master in your branch. Could you please resolve it so I can merge?

How do I resolve?  The button is greyed out...

In your fork, pull the changes from my master. You will pull the
conflicting changes. Then you resolve locally, commit the changes and push
again.
Em qua, 5 de jun de 2019 21:12, billtlee<EMAIL_ADDRESS>escreveu:

How do I resolve? The button is greyed out...
[image: Screen Shot 2019-06-06 at 8 11 19 AM]
https://user-images.githubusercontent.com/14323281/58998300-ad5ff480-8832-11e9-9497-6556f2eb05e4.png
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/fmsouza/ethereum-wallet/pull/10?email_source=notifications&email_token=AAKU7BYJG4DWSSOAI3LUJL3PZBI5HA5CNFSM4HOZTBZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXBLVGQ#issuecomment-499301018,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKU7BZOCTSD4BM6AHRUL73PZBI5HANCNFSM4HOZTBZQ
.

I did a git pull origin master, git commit and push from my branch but didn't see any conflict.  perhaps package-lock.json is in gitignore?

Looks like you didn't pulled from the source's branch.


[VS Code] Starting collaboration session: Could not connect to the server. Live Share requires openssl 1.0 for authentication, please verify you have the dependency installed.

Error:
Starting collaboration session: Could not connect to the server. Live Share requires openssl 1.0 for authentication, please verify you have the dependency installed.
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
1.0.182

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.33.1

platformName
Linux

platformVersion
4.19.0-parrot1-13t-amd64

@AlexisBD: thanks for reporting this issue! I'm going to close it out as a duplicate of #2105 so we can consolidate the investigation there.


docs: fixed small grammatical mistake in CONTRIBUTING.md

Description
Fixed a small grammatical mistake in the CONTRIBUTING.md file. Documentation change hence no linting/tests required.
Please describe additional details for testing this change
Refer to the last sentence of the second paragraph of the "Commit your update" heading in CONTRIBUTING.md

done!


Remove tokio, android_logger deps from agency_client

removes tokio dependency at cost of one test (very low value)
also removed unused android_logger dependency

Codecov Report

Merging #975 (e73b22e) into main (f4c8642) will increase coverage by 0.53%.
The diff coverage is n/a.

:exclamation: Current head e73b22e differs from pull request most recent head 683f8a3. Consider uploading reports for the commit 683f8a3 to get more accurate results

@@            Coverage Diff             @@
##             main     #975      +/-   ##
==========================================
+ Coverage   29.22%   29.76%   +0.53%
==========================================
  Files         414      411       -3
  Lines       26246    26070     -176
  Branches     5365     5315      -50
==========================================
+ Hits         7671     7760      +89
+ Misses      16263    16001     -262
+ Partials     2312     2309       -3

Flag
Coverage Δ

unittests-aries-vcx
29.76% <ø> (+0.53%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

agency_client/src/messages/create_key.rs
0.00% <ø> (ø)

... and 81 files with indirect coverage changes


PR2: Make epsilon for ZCA parameterizable

Fixes #6612
This PR is an alternative to PR #6614

Good!

LGTM


TODO: 2015/02/03

PPA*: Should change the switching strategy. If the thread find a best heap, then should persist more to the heap.

PPA* didn't work well.
Although the result was not great and flashy, this is a contribution that is helpful for others.


Utterances forum

Would be great if Github's "discussions" (which is a forum) could also be embedded like utterances does for issues.

This was already suggested in #324. I fully agree that support for GitHub discussions would be great.
Unfortunately, it seems like GitHub doesn't provide API access to discussions yet.

This was already suggested in #324. I fully agree that support for GitHub discussions would be great.
Unfortunately, it seems like GitHub doesn't provide API access to discussions yet.

A private API for the discussions is now available.
https://github.com/github/feedback/discussions/43#discussioncomment-339955
https://gist.github.com/smashwilson/311e1487ddb40a455fc54d294cc63ad4


Add keysight manifest for deploy

/gcbrun

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.964%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2329

Relevant Lines:
4018

💛  - Coveralls

/gcbrun

can we temporarily accept both ixia-configmap and ixia-version and have them be equivalent and mutually exclusive? We have an internal repo that distributes our own manifests and images to keeps things stable, and I'd prefer not to have it only work with versions of KNE before or after this change.

/gcbrun

/gcbrun

the presubmit failed because this PR does not have the changes on the main branch that fix the issue

/gcbrun

/gcbrun

/gcbrun

/gcbrun


Profile Diff from Stderr to Stdout

Simple change to profile-diff.go to set the outWriter to os.Stdout as opposed to the default os.Stderr when not set.
cc @Monkeyanator authored change from fmt.Println to cmd.Println
fix for #30375

@adiprerepa: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ea99d2b4a13fbe50b0cd46ec52cf5b7eee6744db
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adiprerepa: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ea99d2b4a13fbe50b0cd46ec52cf5b7eee6744db
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

/test release-notes_istio

ah i think #30113 got to it before i did. closing now.

ah i think #30113 got to it before i did. closing now.