HSEARCH-3074 Avoid depending on internal Hibernate ORM types

https://hibernate.atlassian.net/browse/HSEARCH-3074

Pull Request Test Coverage Report for Build 1

21 of 23 (91.3%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0005%) to 89.293%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

mapper/orm/src/main/java/org/hibernate/search/mapper/orm/massindexing/impl/IdentifierProducer.java
12
13
92.31%

mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/query/impl/HibernateOrmSearchQueryAdapter.java
0
1
0.0%

Totals

Change from base Build 291:
-0.0005%

Covered Lines:
18656

Relevant Lines:
20893

💛  - Coveralls

@yrodiere thanks for the review. Anything else? Thanks

@fax4ever Looks good! Maybe you could just add forbiddenapis rules to forbid using classes in packages org.hibernate.internal.** and org.hibernate.**.internal.**?
Just launch the build after your added the rules, to check it fails, then add the necessary exclusions in pom.xml (around line 1411).

@yrodiere thanks! I'll added the commit with the rule for the forbiddenapis plugin. I'll wait the CI, then I'll merge it.

Merged thanks!


CORS not working

I deployed this container to Heroku and sending POST requests via curl works great! However, I have trouble getting POST requests via a React web app due to CORS. What is the best way to enable CORS on this project, since it implements the request endpoints using marmoset? Thank you!

Never mind, I figured it out. Below is for who needs this in the future.
Add the following function in controllers/file.go, changing * into your allowed domains as needed:
func addCors(w *http.ResponseWriter) {
	(*w).Header().Set("Access-Control-Allow-Origin", "*")
}

Then before the line render := marmoset.Render(w, true), call addCors(&w).


content/github/setting-up-and-managing-organizations-and-teams/verifying-your-organizations-domain.md

content/github/setting-up-and-managing-organizations-and-teams/verifying-your-organizations-domain.md

😊


Feature/move all from category

A really useful feature that Adibags had which seems to be missing from BetterBags.

Rightclicking section names on the backpack frame will (try to) move all its items to the bank.
Rightclicking section names on the bank frame will (try to) move all its items to the backpack.

Looking at this a bit more closely:

You don't need to build an item list. The section has the item list already.
Because this is multiple independent operations that affect client state, we need to move this loop into coros. PTAL at https://warcraft.wiki.gg/wiki/API_coroutine.create and associated functions and build a coroutine loop so the client doesn't lock up on large transfers.

Thanks for the feedback, @Cidan . I'll look into it and prepare an update.

awesome! later tonight, I'm going to add an async module to help, as this is a pattern I need in a few other places as well. this will make it relatively easy for you to implement this feature.

awesome! later tonight, I'm going to add an async module to help, as this is a pattern I need in a few other places as well. this will make it relatively easy for you to implement this feature.

Well, guess I'll wait for that module then!

@fiote I've just added a new module, Async, that will make this easier. You can now do the following:
async:Do(function()
  for _, item in pairs(someContainer) do
    C_Container.UseContainerItem(bagid, slotid)
    async.Yield()
  end
end)

The above function will process the loop one per frame, smoothing out the calls. You can also batch your execution if you want, i.e. keep a counter in the function and use some modulo to yield.
This is in main right now.

Okay. I think I did all that was requested.

I only checked the signing part after I was done so I'm not sure it's good enough. If you want me to, I can drop this PR, re-do all my changes (now signed) and PR again.

Also, not sure this is related to this PR. This feature works really well to (try to) send a whole category to the mail attachments. I already did it locally to test things and it's working great so far. Do you think it's part of the same feature (it's basically an extra if and that's it), or it's better as a new PR later on?

Also, not sure this is related to this PR. This feature works really well to (try to) send a whole category to the mail attachments. I already did it locally to test things and it's working great so far. Do you think it's part of the same feature (it's basically an extra if and that's it), or it's better as a new PR later on?
Edit: it's basically this, hah

Instead of checking here, look at hooks.lua, OpenInteractionWindow. We already detect if the mail event is triggered -- just create a new addon.atMailbox global and set it to true/false (false at the Close function under it).

Instead of checking here, look at hooks.lua, OpenInteractionWindow. We already detect if the mail event is triggered -- just create a new addon.atMailbox global and set it to true/false (false at the Close function under it).

That doesn't really work. That event (or the MAIL_SHOW, that I also checked) triggers when you open the inbox. But that's not enough. You need to check if the 'compose mail' frame is actually there, because since the 'move-to-other-container' method being used is the UseContainerItem, if you try to call that while on the inbox is open panel, it'll actually try to use/consume any item.
My way checks if the attachment frame is actually there/visible so the game will try to move items instead of using them when the UseContainerItem is called.

it'll actually try to use/consume any item - there is no destination for moving them.

Okay, this means we need to make a few changes:

Move the atMail boolean to a function, addon:AtSendMail. You can use init.lua to store this function.

At the time of click, you need to detect which vessel you are transferring to/from -- bank or mail, and store that.

On each click call, you need to make sure that the previous state of at bank or mail still applies, and the user didn't close the frame, otherwise items will be consumed mid-loop.

Do we want to support other interaction types? How about player trading?

Adding player trading on top of this sounds straightforward. I'll check this new approach and come back to you.
Now back to the previous comment (the bank-still-stacked one). The whole thing used that bagkind to work, because when generating the list I need to know where i'm searching. That said, now I know the section.content.cells.$.data have their bagid and slotid on it. Slotid is not really important for me, but bagid seems to be enough for me to detect if this click/section is on the bank or the backpack (https://wowwiki-archive.fandom.com/wiki/BagId)... I can use those constants to identity the 'bag kind'.
You want me to add that logic as a function/method somewhere ... ? or just have it inside my onTitleRightClick.

Oh also, let me think on bag kind for a bit. I really don't want to attach kind to a section if I can help it.

I kinda made all that I wanted to do, hah. You can check it if you want it, otherwise I'll wait for your updates to update my changes.

Merging conficts solved.

I am so sorry for the delay here -- I did not forget, but during testing a huge, massive set of bugs were discovered with how item updates work, and I had to rewrite a significant portion of the core addon systems.
Can you merge main, and try again on this?

I am so sorry for the delay here -- I did not forget, but during testing a huge, massive set of bugs were discovered with how item updates work, and I had to rewrite a significant portion of the core addon systems.
Can you merge main, and try again on this?

Sure, I'll take a look again!

Okay, looks like you changed a lot of things. So, question time! - I thought of trying re-doing things my way but you'll probably review it with "this can be done this other way, please adjust it" so I'm asking first and doing second, lol.
From local function onTitleRightClick(section)
  if (kind == const.BAG_KIND.BACKPACK) then
    source = items.itemsByBagAndSlot;
  else
    source = items.bankItemsByBagAndSlot;
  end

items.itemsByBagAndSlot is gone. You still use "itemsByBagAndSlot" on your code, but its not where it was. How can I access it (the goal here is to get the inventory itemlist).
items.bankItemsByBagAndSlot is also gone. "bankItemsByBagAndSlot" variable name itself is also gone. How can I get the bank itemlist?

 That code was actually unnecessary back then already.

Ok, I merged your changes and made it work again. I also expanded the feature to allow you to right-click the category header when a npcshop window is open to sell it. Since this one is stretching a bit the goal of moving items, i add a config entry for it, to players have to opt-in.

Can you merge in the latest main in and test this? I made a few changes.

@fiote When withdrawing from the bank or depositing to the bank, if there are virtual stacks of items in a category, this feature only moves the first item in a virtual stack and not all items in a virtual stack. i.e. buy 5 identical starter weapons, turn on stacking, and disable unstack at shop, then try to move things and it will only move one item at a time.  Can you fix this?


LuCI issues with lighttpd

Router model: TP-Link TL-WR1043ND.
After change uhttpd => lighttpd.
Every time I use LUCI crash with mesage.
thanks in advance
Everything another is OK (php, html, scripts, rrd, ...)
/usr/lib/lua/luci/util.lua:587: Unable to establish ubus connection
stack traceback:
[C]: in function 'assert'
/usr/lib/lua/luci/util.lua:587: in function 'ubus'
/usr/lib/lua/luci/dispatcher.lua:321: in function 'dispatch'
/usr/lib/lua/luci/dispatcher.lua:168: in function </usr/lib/lua/luci/dispatcher.lua:167>

/usr/lib/lua/luci/dispatcher.lua:433: Failed to execute function dispatcher target for entry '/'.
The called action terminated with an exception:
/usr/lib/lua/luci/util.lua:587: Unable to establish ubus connection
stack traceback:
[C]: in function 'assert'
/usr/lib/lua/luci/dispatcher.lua:433: in function 'dispatch'
/usr/lib/lua/luci/dispatcher.lua:168: in function </usr/lib/lua/luci/dispatcher.lua:167>

Make sure luci runs as root.

But I can not run web server (lighttpd) as root. Is any another choice?

I have the same issue with the same router.
Is there anything new about this?

What same issue? That LuCI is not running as root?

No, that luci won't start but show the message
/usr/lib/lua/luci/util.lua:587: Unable to establish ubus connection
I tried installing OwnCloud using this howto
https://wiki.openwrt.org/doc/howto/owncloud
It works fine until the part with "disable httpd and use luci on lighttpd". I could not manage to get luci working again, I only got the same error message as blllk above.
/usr/lib/lua/luci/dispatcher.lua:433: Failed to execute function dispatcher target for entry '/'.
The called action terminated with an exception:
/usr/lib/lua/luci/util.lua:587: Unable to establish ubus connection
Finally I used
firstboot
to regain the default settings and luci works again.

The following (workaround) fixes this issue for me on lighttpd:
root@OpenWrt:~# chmod +s /usr/bin/lua
Warning: This is probably not a safe solution if you care about security, especially if you are using lua for other stuff.

@bilik @Rom4nB @hurenkam I'd recommend changing the listening port for either lighttpd or for uhttpd and running the both - uhttpd for the web UI and lighttpd for you actual web server.

This is unlikely to solved in current generation of LuCI; luci-ng has aspirations to use better techniques.

Acutally I'm reopening this issue so hopefully other can find it more easily.

More details, please.  lighttpd can be run as root, if that is what is desired, and lighttpd works fine with LuCI in Turris Omnia, which runs software based on openwrt, and does not run uhttpd.

@gstrauss It looks to me like the users above are complaining that they want LuCI to work without it running either as root or making lua setuid root.  As you can imagine that isn't an option with current LuCI.

There are multiple ways to run backend scripts under a different user id than the web server.  I believe that those running lighttpd in order to run other hosting, scripts, and frameworks do not want lighttpd to run as root (and all those scripts as well) just so that LuCI can run as root.  (FYI: lighttpd will run as the user that started lighttpd if server.username and server.groupname are omitted from lighttpd.conf or commented out.)
A quick workaround to reduce what is running as root would be to rename cgi-bin/luci to cgi-bin/luci.privileged and to create a setuid root program cgi-bin/luci which turned around and executed /full/path/to/cgi-bin/luci.privileged.  That is still not ideal and nobody other than root should be able to write to that cgi-bin directory, but it is a much better solution than setting chmod g+s on /usr/bin/lua (suggested by @hurenkam), which I would never, ever consider doing.

I think this issue can be closed.
Here's the tl;dr

If you want to run LuCI with lighttpd, then lighttpd can be configured to run as root by commenting out server.username and server.groupname in /etc/lighttpd.conf.  If you are only running lighttpd for access to LuCI, then this is an "ok" solution.  Alternatively, keep uhttpd running (as root).
If you are using lighttpd to run owncloud or any other framework, then a more secure solution is to run multiple instances of lighttpd (on different ports), or multiple web servers (on different ports), with one instance running as root and serving LuCI, and the other (non-root) instance running everything else.
If you want to run a single web server to do all of the above, then consider running lighttpd as non-root, and having a single, simple setuid root executable whose only function is to execute luci, as mentioned in the previous post.

@gstrauss Thanks for the clarification; I didn't actually mean that you had to run lua setuid root but that 'something has to run suid root', which you've explained well for those who want to do such things; even then I really look forward to time to working on luci-ng and letting ubus/rpcd ACLs manage privileges and to need a webserver on root; however that is quite a way out unless something changes in either available time and/or priorities.  I will however leave the bug, open, but with appropriate tags, so that its easier to find, unless @jow- or @hnyman think it should be closed.


All secrets missing if one secret cannot be decrypted

The situation was the following: I added a new secret to a nixos configuration with the sops.secret."some/key" option and the path some/key existed in the secret file but was not encrypted for that machine. When deploying the configuration all secrets where missing, not just the one that failed to decrypt. I think it would be better if sops in such cases would decrypt and create all secrets it can and ignoring the ones it cannot. Or maybe it would be possible to detect this already at build time similar to when the path of a secret does not match.

There is a validateSopsFiles option that is true by default and checks if the key is present in the sops, but we cannot check if machine has the right private key to decrypt at build time.

I know that behaviour and we haven't changed that.
Also it is obvious that at build time we cannot decrypt the secret but at install time would it be possible to skip the secrets which cannot be decrypted instead of not creating any secrets at all?


Set up disk use monitoring

Preferably alerting to #servo

Salt's reactor system is probably the easiest way to do this.

This is pull/poll instead of push, but #791 promises to help with this.

cc @jdm re: saltbot


Improve error message in NDArray::CopyFromTo

Make it explicit that the quoted numbers are bytes.

cc @lhutton1 @eirenevp

@tvm-bot rerun

Thanks @ekalda @quic-sanirudh!


Link to hosted version of Docs in readme instead of the tutorial link.

Suggest adding a link to the hosted version of docs in the repo readme file instead of linking to the tutorial.

Great point! I was so focused on getting the "ReadTheDocs" working, I didn't even notice this README. It's been edited to include some basic information and a link to the docs!


System Theme (if system is on light mode) has extremely bad contrast from text to background.

This is the first thing seen by users of osekai when they first enter the website

This particular one, the filter options are clearly not visible to the average user.
Browser: Google Chrome 107.0.5304.121

fixed by bc6f0b58fa9a2b8eb32da2f1ddfc8a6f1484023d


Consider adding name field to Trajectory

I think it would be good to be able to assign a name to a trajectory. This would be useful to know which trajectory is which when visualizing multiple trajectories in a viewer (e.g., rviz). This can be done by adding a name field to the associated visualization object (e.g., TrajectoryMarker), but I think it would be worth to have them in Trajectory class.
Thoughts?

In general, I am a little wary of assigning metadata like names to pure data structures like Trajectory.  It makes it a bit awkward in situations like:

A trajectory is being created and consumed inside an optimizer.  What should the name be?
A trajectory is being stored into a database by ID.  Does the name have to be synchronized with the database ID when it is saved/loaded/copied?  Can the name be a binary string (since that might be its unique identifier)?
A trajectory is cloned a number of times.  Should its name change?  Does the name need to be unique?

With that said, it can be user-friendly to keep the name around as a metadata field for debugging. If it is really necessary to maintain a name, absolutely nothing in DART or its plugins should assume the field:

is populated
is unique
is meaningful

I agree with @psigen here. I generally like the idea of keeping name in visualization classes for all of the reasons he outlined above.
However, I do think it would be tremendously useful to other types of metadata with a trajectory, e.g. how it was planned, what constraints it was checked against, and where those constraint checks were performed. This is very similar to the concept of "trajectory tags" we had in PrPy that @brianhou began to resurrect in https://github.com/personalrobotics/aikido/pull/259.

This is precisely the problem that DART Aspects https://github.com/dartsim/dart/pull/659 were intended to solve. I would be thrilled if we added Aspects to Aikido's Trajectory class. I don't see any issue with creating a VisualizationAspect that could hold the trajectory's display name.


FXO digitals pricer

FXO digitals pricer and testing scripts

I guess that the classes 'SwapPricingExample', 'FxRate', 'FxVanillaOptionTest', 'BlackFxVanillaOptionProductPricerTest', 'BlackOneTouchAssetPriceFormulaRepository' where modified my mistake. Revert to the previous version.

Yes i will revert those classes.
On Mon, Dec 19, 2016 at 12:13 PM, Marc Henrard<EMAIL_ADDRESS>wrote:

I guess that the classes 'SwapPricingExample', 'FxRate',
'FxVanillaOptionTest', 'BlackFxVanillaOptionProductPricerTest', '
BlackOneTouchAssetPriceFormulaRepository' where modified my mistake.
Revert to the previous version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenGamma/Strata/pull/1432#issuecomment-267950140,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWXUlJ1PuBJRhoZ6dJ2DB63bjPlHXzTmks5rJnTRgaJpZM4LKsqC
.

As discussed with @marc-henrard, closing the PR for now - will revisit the branch later.


Release 1.0.4

Since v1.0.3 is broken we should get this out rather soon.

@hanzei did you test your fix with a JIRA instance? I can do it if you haven't already

FYI: Joram will test the release.


Include contact person information CSV export of partner agencies

Summary
Related To https://github.com/rubyforgood/diaper/issues/1790
We currently have an export CSV option on the partner's index page and we want to include the contact information for each partner agency into that CSV. That is we want to have  these fields:

agency name
agency email
contact person name (to be included)
contact person phone number (to be included)
contact person email (to be included)

Note - "Contact person" is also known as "Point person"
Things to Consider

You'll need to make an update on the partner application to be able to retrieve the information above via API.

Criteria for Completion

[ ] Clicking on "Export Partner Agencies" will trigger a download for a CSV that contains the data fields mentioned above.

I think I didn't tag the PR the right way in order for it to close this issue, but this should be resolved! https://github.com/rubyforgood/diaper/pull/1915


Implement Delegate corner-cases, improve logging and responses

Closing #224
Closing #273
Part of #232
Part of #267
Blocked by #274

I added two new commits to fix tests/docker-compose and rebased other on top of them:

https://github.com/mlabs-haskell/hydra-auction/pull/275/commits/7ef025638f5808280a2f677ccc974cd1e4bdeb35
https://github.com/mlabs-haskell/hydra-auction/pull/275/commits/74e425f4a584505a527ff60724c50c72fea126ff


Add minsurf

@frapac I ran JSO's formatter, so it did some spaces change. I don't know if you have rules yourselves?

apparently we have a complete implementation of the COPS benchmark now :+1:
The PR looks good to me. I would just suggest to switch to 4-space indentation (instead of 2). We are currently using the JuMP style guide, itself based on the Julia style guide.


feat: version bump Realtime image to 2.28.23

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 57.74%

Files with Coverage Reduction
New Missed Lines
%

internal/gen/keys/keys.go
5
11.76%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
6386

Relevant Lines:
11060

💛  - Coveralls


Refresh Label on change

Refresh Label on change
Closing #31

Or is it better to make _setLabel method?


Additional Coupon Code

Added $10.00 off coupon with a redemption duration of once.

LGTM ‼

Closing this because fake_stripe has been deprecated: https://github.com/thoughtbot/fake_stripe/pull/154


SQL Server Data Tools (SSDT)

this should state what SSDT is, before using the acronym.
could even have a link!
https://docs.microsoft.com/en-us/sql/ssdt/download-sql-server-data-tools-ssdt?view=sql-server-2017

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f0e1195-b6a2-d789-a950-4454798f265e
Version Independent ID: d8ea7415-3b97-5985-44e7-1b89bf1196b6
Content: Manage database roles and users in Azure Analysis Services
Content Source: articles/analysis-services/analysis-services-database-users.md
Service: azure-analysis-services
GitHub Login: @Minewiskan
Microsoft Alias: owend

Thanks for the feedback! We are currently investigating and will update you shortly.

@lukeb1961 the title of the article is 'Download and install SQL Server Data Tools (SSDT) for Visual Studio" so the acronym is spelled out there.
There is also the first paragraph at the top of the page:
"SQL Server Data Tools is a modern development tool for building SQL Server relational databases, Azure SQL databases, Analysis Services (AS) data models, Integration Services (IS) packages, and Reporting Services (RS) reports. With SSDT, you can design and deploy any SQL Server content type with the same ease as you would develop an application in Visual Studio."
If you were referring to something else, let us know.

You cannot be reading the page referred to in the Issue. Please address the issue.


2023 review: Add more about contributor training

The Issue
@bmartinez287 pointed out the importance of contributor training in 2023.

It be great to hear more about the contributions Simon made. Maybe a highlight of the biggest items specially since we are mentioning Matt.

It would be great to hear more about the contributions Simon made

I could write a whole blog post just about that. I think it would be a distraction in the midst of this post though. I wish he were here so we could honor him with a post like that.


Fortumo appears to be broken

I've not been able to use Fortumo in OpenIAB, either in my own app or in your TrivialDrive example.  Upon setting up OpenIAB, I get this error in the log:
FortumoStore(19678): isBillingAvailable: has FEATURE_TELEPHONY true
FortumoStore(19678): billing is not supported due to Can't obtain fortumoPrice details from  the server. (response: 0:OK)
The above is reproducible by adding supportFortumo= true to the setup options in TrivialDrive.  I can work around this by downloading the inapp details xml file directly from Fortumo (as they describe for bundling in-apps for offline use).  If I do this, OpenIAB setup completes successfully, however I cannot purchase an item.  I get an error toast explaining "Only widget payments are supported for this carrier"
However, the Fortumo demo app available from m.fortumo.com works fine, so I suspect it is an OpenIAB integration issue.

Hi everyone,
I'm having a problem creating a service, well not necessary creating it. I don't understand one of the info I need to fill out, where it ask "to which url your payment request forwaded to". Can anyone help in explaining what is really needed here...


Fix Ecto.Query.API.map for single nil column with join

Fixes #2380
Not sure if this is the best approach, but as far as I could test it solves the issue.
Used the test case provided by @wojtekmach in the issue as a regression test (thanks!)

Sorry @uesteibar. I have just changed this part of the code.
I think a simpler fix would be to completely ignore the all_nil? value here and always pass it as false:
https://github.com/elixir-ecto/ecto/blob/master/lib/ecto/repo/queryable.ex#L188
Could you please try that out?

Btw, I am aware that my solution will break a right join test but I think we should fix that test instead. The issue is that it is impossible for us to know, in the case of right joins, if all of the fields are nil or if the record entry is missing. But I would rather have the faulty behaviour on the right join rather than on from.

@josevalim that's the first thing I tried, but found out that the test for the right join so tried to make it work without braking it. I'll give that a try :)

With ignoring all_nil? and just passing false, it will still use the struct as result, which I understand is not the behaviour we want (I changed this behaviour with this).
code:  assert %{counter: nil} == TestRepo.one(from(p in Post, join: c in assoc(p, :comments), where: p.title() == "1", select: [:counter]))
     left:  %{counter: nil}
     right: %Ecto.Integration.Post{
              __meta__: #Ecto.Schema.Metadata<:loaded, "posts">,
              author: #Ecto.Association.NotLoaded<association :author is not loaded>,
              author_id: nil,
              bid: nil,
              comments: #Ecto.Association.NotLoaded<association :comments is not loaded>,
              comments_authors: #Ecto.Association.NotLoaded<association :comments_authors is not loaded>,
              comments_authors_permalinks: #Ecto.Association.NotLoaded<association :comments_authors_permalinks is not loaded>,
              constraint_users: #Ecto.Association.NotLoaded<association :constraint_users is not loaded>,
              cost: nil,
              counter: nil,
              id: nil,
              inserted_at: nil,
              intensity: nil,
              links: nil,
              meta: nil,
              permalink: #Ecto.Association.NotLoaded<association :permalink is not loaded>,
              post_user_composite_pk: #Ecto.Association.NotLoaded<association :post_user_composite_pk is not loaded>,
              posted: nil,
              public: true,
              temp: "temp",
              text: nil,
              title: nil,
              unique_users: #Ecto.Association.NotLoaded<association :unique_users is not loaded>,
              update_permalink: #Ecto.Association.NotLoaded<association :update_permalink is not loaded>,
              updated_at: nil,
              users: #Ecto.Association.NotLoaded<association :users is not loaded>,
              users_comments: #Ecto.Association.NotLoaded<association :users_comments is not loaded>,
              uuid: nil,
              visits: nil
            }

I don't see a way of knowing whether the user passed all the columns in the from or none without passing take all the way down here, but I might be missing something.
Any thoughts?

With ignoring all_nil? and just passing false, it will still use the struct as result

The test is wrong. When we do select: [:counter], it will still keep the struct format. You can change it to select: map(p, [:counter]) though.

@josevalim redone following your proposal

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


plugins/lsp: add ts-ls

https://github.com/neovim/nvim-lspconfig/pull/3232
Set plugins.lsp.tsserver.enable = true results in the warning tsserver is deprecated, use ts_ls instead when launching neovim. lsp.ts-ls is added to address the issue, and lsp.tsserver is retained since it still exists in current version of nvim-lspconfig.

Reading the error this might be dependent on https://github.com/nix-community/nixvim/pull/2252

LGTM for the most part, just fixing up our flake update real quick so this is supported.

Looks like we're getting infinite recursion message from the rename?

Looks like we're getting infinite recursion message from the rename?

Trying to debug locally, but it's not making much sense...
I also stumbled on some places where we reference tsserver internally, e.g. plugins.none-ls.sources.formatting.prettier.

In fact it is the prettier definition that seems to be causing inf.rec:
while evaluating definitions from `/nix/store/42mc0najpyf3izl3f62plm6hj0g7pfzn-source/plugins/none-ls/prettier.nix'

In fact it is the prettier definition that seems to be causing inf.rec:
while evaluating definitions from `/nix/store/42mc0najpyf3izl3f62plm6hj0g7pfzn-source/plugins/none-ls/prettier.nix'

Fixed by replacing tsserver with ts-ls in prettier.nix

Fixed by replacing tsserver with ts-ls in prettier.nix

Well done, but that does make me worry that any renames under LSP/language-servers will have the same issue when someone tries to use the old name...
I think we'll have to investigate this separately.
For now, the outstanding ci failures are formatting (you need to run nix fmt) and:

ERROR: [lspconfig] Cannot access configuration for ts_ls. Ensure this server is listed in server_configurations.md or added as a custom server.

Perhaps we are still waiting on a nixpkgs bump?

Fixed by replacing tsserver with ts-ls in prettier.nix

Well done, but that does make me worry that any renames under LSP/language-servers will have the same issue when someone tries to use the old name...
I think we'll have to investigate this separately.
For now, the outstanding ci failures are formatting (you need to run nix fmt) and:

ERROR: [lspconfig] Cannot access configuration for ts_ls. Ensure this server is listed in server_configurations.md or added as a custom server.

Perhaps we are still waiting on a nixpkgs bump? Or this may be resolved by rebasing.

I can try using this branch with my config, since i have tsserver set.

Rename seems to work, fine.

@mergifyio queue


How to translate post type name

i don't know if i'm doing something wrong but i'm not able to translate the name of the post type/taxonomy... not the 'Add New' label but the singular and plural names of the post type/taxonomy (ie: my CPT singular name is "Brands" and i want to translate "Brands").
this is the way i'm registering the post type
// Register Brand custom post type
$brand = new CPT(
    // Names
    array(
        'post_type_name'    => 'brand',
        'singular'          => 'Brand',
        'plural'            => 'Brands',
        'slug'              => 'brands'
    ),
    // Options
    array(
        'has_archive'           => true,
        'supports'              => array('title', 'editor', 'author', 'thumbnail', 'revisions'),
        'exclude_from_search'   => true,
        'map_meta_cap'          => true,
        'capabilities'          => array(
            'edit_post'             => 'edit_brand',
            'edit_posts'            => 'edit_brands',
            'edit_others_posts'     => 'edit_other_brands',
            'publish_posts'         => 'publish_brands',
            'read_post'             => 'read_brand',
            'read_private_posts'    => 'read_private_brands',
            'delete_post'           => 'delete_brand'
        )
    )
);
// Icon
$brand->menu_icon('dashicons-star-filled');
// Translation
$brand->set_textdomain('my-text-domain');

i also tried using WordPress translation functions in the names section like so:
    array(
        'post_type_name'    => 'brand',
        'singular'          => __('Brand'),
        'plural'            => __('Brands'),
        'slug'              => 'brands'
    ),

and with adding a text domain name
    array(
        'post_type_name'    => 'brand',
        'singular'          => __('Brand', 'my-text-domain'),
        'plural'            => __('Brands', 'my-text-domain'),
        'slug'              => 'brands'
    ),

hope you can help.
thnx.

Your last snippet should work
 array(
        'post_type_name'    => 'brand',
        'singular'          => __('Brand', 'my-text-domain'),
        'plural'            => __('Brands', 'my-text-domain'),
        'slug'              => 'brands'
    ),

Are you using poedit (or similar software) to scan your source files?  They should come up in the translator and then you can provide the translated terms

@slobich Sorry for the late reply
As @bynicolas said, your last example should work.
Depending on how you are translating, the set_textdomain() method can work in some cases, however if you are using something like poedit, it reads the source files and not the result of what set_textdomain will do.
Hope this helps,
Thanks :)

I have the same problem...
My textdomain  works fine everywhere but singular name

I just encountered the same issue, using CPT in a plugin. Solved it by creating the CPT's after loading the plugin's textdomain (and not before).
// this first
load_plugin_textdomain( 'my_textdomain', false, dirname( PLUGIN_BASENAME ) . '/languages/' );

// then create the CPT's

Perhaps this saves a couple of minutes here and there.

Thanks a lot. I got a solution using this.


SPIKE: POC the use of GOT hooking for everything

In order to alleviate potential name space issues, we'd like to consider using GOT hooks in place of preload to interpose. We need to ensure GOT hooking is complete anyway, in the context of attaching to a running process.
This is precipitated by the corner we got backed in to with the use _dl_sym() and the fact that Musl libc does not support that capability.

Moved to discussions https://github.com/criblio/appscope/discussions/960


Have a preview in GitHub repository

It would be nice to have an overview page to see the colour combinations.
Maybe a separate markdown file that is referenced from the README.
This way it's easier for users to decide which theme to chose.
Otherwise permanently going to settings and having to restart Joplin is less user friendly.
But it's really just a nice-to have. :wink:
This image goes a bit into this direction but it's to small to really see everything and there are also the variations that are not clear by name (various colours -, +, the number).
A proper overview would be nice.

It would be nice to have an overview page to see the colour combinations.
Maybe a separate markdown file that is referenced from the README.

Yes, I did plan to do this.

This image goes a bit into this direction but it's to small to really see everything and there are also the variations that are not clear by name (various colours -, +, the number).
A proper overview would be nice.

That would be so many screenshotssss.

That would be so many screenshotssss.

What are the differences between +, - and the number things?

The number is the degree, just 10 degrees of color hue differences for each option.


Adding more metrics

Hi,
I have just found this great repo right when we are adding a lot of monitoring at work (also for celery).
I would love to have a few more metrics (don't we all :P):

queuing time
task run time
queue length (per worker, per task name etc.). This may not be easy as each broker requires different treatment but rabbitmq/redis are most popular, could get started with those.

Our workload is strictly CPU intensive and we need to know when we are saturating the workers and need to buy more VMs.
I was thinking of trying to implement this and make a PR, it would be a damn shame just to do it for my work only :)
Would you be ok with me making a PR for this? Cannot promise anything time-wise as it is super busy now but I should get started this weekend (just get the repo and start testing my options, reading the code etc., design approach to this).
I think the main idea is to reuse what you already have and add more handlers. To measure the queueing time its simply:
task started time - task received time but please correct me if I am wrong here.
We could also check the latency so: task received time - task sent time
Task run time should be already present on the event itself I believe (haven't inspected them in debug mode for a while though).
Initially the metric could be by host/task name as the existing ones you have, later maybe could be combined for queues/workers if possible.
Please let me know what you think about this idea and if contribution is ok :).
Tom

I have just found this great repo right when we are adding a lot of monitoring at work (also for celery).

Thank you!

I was thinking of trying to implement this and make a PR, it would be a damn shame just to do it for my work only :)

I think that's a good idea.

I think the main idea is to reuse what you already have and add more handlers.

I've made the worker as simple as possible by hooking into the Celery event system and exporting whatever events the system publishes. There is little custom logic to calculate additional metrics and that has worked for the clients I work with so far. We are mostly interested in the task failure / task success rate. We alert if a task failed to execute (above a certain % threshold), and also if a scheduled task has not executed at all in a time window.
https://docs.celeryproject.org/en/latest/userguide/monitoring.html#task-events

To measure the queueing time its simply:
task started time - task received time but please correct me if I am wrong here.

Off the top of my head this would be a little tricky because the simplest approach I can think of is to make the exporter stateful and store UUIDs + timestamps for each task in memory in order to calculate the execution time. You would have to be careful that this doesn't cause a memory leak with an increasing amount of tasks.

Initially the metric could be by host/task name as the existing ones you have, later maybe could be combined for queues/workers if possible.

Hostname represents the worker name. You can set a custom one using celery worker --hostname=<name> when starting the worker.

later maybe could be combined for queues

Queue names were a little tricky to test - IIRC the in memory broker I use for tests was not exposing this, but my memory might be off. If we add this it should ideally not break for any broker types.

Please let me know what you think about this idea and if contribution is ok :).

A good idea is to adhere to the Prometheus exporters best practise here:
https://prometheus.io/docs/instrumenting/writing_exporters/
Good luck!

Hi, thx for a speedy reply :)
I have some preliminary results which are looking good.
The code needs some refactoring as with what I add I am really breaking single responsibility principle and the track_task_event becomes a monstrosity that starts doing everything.
I will look into making it a bit neater (separate stuff into small methods etc.) before sharing my changes.
I have not yet checked if in memory broker provides queue names etc but hopefully it does. If that is the case we could safely add queue to the set of labels used by the metrics.
I attach some images to show that what I want to achieve works (for the queuing time I just use a Gauge) :).
All I have is a simple celery app with concurrency 1 and a task which sleeps for set amount of time. The tasks sent to the celery after the first one have to wait for it to finish sleeping and the queuing time goes up. The data is there and easily obtainable thx god :).


Plugin throws Error ("cannot be loaded multiple times") upon bootstrapping TypeDoc multiple times

Hi!
I have written a script that calls the TypeDoc bootstrapper (basically the main() function described in the docs) multiple times in a row in order to take independent entry points and generate their respective output.
However, when multiple bootstrapWithPlugins calls have specified typedoc-plugin-missing-exports as one of their plugins, any call after the first will raise this error.
Is this the desired behavior?
I would assume that every call to TypeDoc.Application.bootstrapWithPlugins initializes a (more or less) fresh state, in which case this plugin's hasMonkeyPatched global variable should be scoped to a single bootstrap? Removing the check altogether worked in my case, at least.
I know that TypeDoc is not made to generate multiple outputs in a single project, just wondering if this error is preventing that on purpose (because I don't care about the minor implications that come with generating multiple configs)!

In general, plugins should support being loaded multiple times. This plugin is an exception because of this patching. If this plugin is loaded multiple times, each load will increase the depth of reference tracking done.
I don't recall why I went with this approach rather than not replacing the method multiple times, and moving the tracking sets outside into the module scope.... but it was intentional at the time. There's likely room for improvement here, PR welcome if you'd like to give it a shot!

I see, thanks for the explainer, I might give it a try when I've got time! In theory, could it be resolved by restoring the patch to the original createSymbolReference upon the end of the conversion?
Still gonna close this issue tho, since it is the expected behavior – I just didn't know whether it was supposed to throw on multiple bootstrapped instances as well :)

Restoring the patch when conversion ends won't work unfortunately because conversion may happen multiple times if --watch is used or the packages entryPointStrategy is used


3D Audio not working

I dont know how to let it work with 3D Audio and Audio Range.l Its not working for me what do i have to do?

You can drag the curve up for the spatial blend on the VideoAudioSource. You can increase the audio range on the U# video player for the video range.

I did change it recording to what you've said but its not working. its still Global and 2D.

You did not, the green curve needs to be a line along the top.

Okay I did that too but still. Its not working its even quieter but still global. Although I'm having problems with your player, i have to admit that i really love it, and I've seen it in other world working correctly

The falloff distance is way too high for you to hear the falloff. If you want to hear it you need to make the falloff sphere fall inside the room.

Also if you're only testing in editor, you need to move the Main Camera game object around to hear what it sounds like. Audio is not affected by your scene view position.

Oh okay this osunds interesting im gonna try that

Okay yeah it was because of the ingame camer while testing in editor. this is amazing. anyway thank you a lot.


Support null types

This pull request adds support for nulls in the runtypes output.
I needed this for checking union types which can contain nulls.
Also, in order for ts-morph to actually consider nulls, I needed to pass a custom project to generate() like so:
import {Project} from "ts-morph";
import {generate as generateRuntypes} from 'runtyping';

const project = new Project({
  compilerOptions: {
    strictNullChecks: true
  },
  // ...
});

const generator = generateRuntypes({
  buildInstructions: [ /* ... */ ],
  project
});

Also, @johngeorgewright thanks for the great library :-)

Hey @rkok. Thanks for the help!
I made a simple null type and your PR worked without adding the strictNullChecks flag to my tsconfig.json, or any need to create a custom project object. I maybe misunderstanding the problem. Would you mind adding a test so I fully understand?

Hi @johngeorgewright, no problem at all.
My particular situation involves using null in a union type. That situation appears to require strictNullTypes to be true. See example below.
If I wrote a test now, it would be an ugly one due to the custom Project instance being required.
What are your thoughts on making strictNullTypes: true the default setting in generate.ts?

Input:
// input.ts
type FooType = string | null;

Expected output:
// ...
export const FooType = Null.Or(String);
// ...

Actual output:
// ...
export const FooType = String;
//...

Script used to reach the expected output:
const generator = generateRuntypes({
    buildInstructions: [{
        targetFile: `output.ts`,
        sourceTypes: [{file: 'input.ts', type: 'FooType'}]
    }],
    project: new Project({ compilerOptions: { strictNullChecks: true } })
});

(async () => {
    for await (const file of generator) {
        console.log(`Writing runtype: ${file.getFilePath()}`);
        file.saveSync();
    }
})();

Closed in favour of #63


Clean up contracts

Main contract: https://github.com/celestiaorg/quantum-gravity-bridge/blob/adlerjohn/contract_mods/ethereum/solidity/contracts/QuantumGravityBridge.sol
Original main contract: https://github.com/celestiaorg/quantum-gravity-bridge/blob/b5ba246f23f89c43adf764e2e3f804b4a9f3beb0/solidity/contracts/Peggy.sol

Note for reviewers: tests are expected to fail catastrophically since the contract is changed but not the orchestrator.

Note for reviewers: tests are expected to fail catastrophically since the contract is changed but not the orchestrator.

Ah OK. If you want we can also merge this only after I submit a PR against this branch to fix the tests.

BTW, surprisingly integration tests pass locally!
Failing tests are:

I think only @Wondertan currently adheres to this but maybe we should actually make this a coding convention for all repos and use the above linter for this as well: https://www.conventionalcommits.org/en/v1.0.0/
Other than that, the build doesn't work:


stopped working

a superior solution to bitbounce and other tools, unfortunately, it's not working anymore, some of APIs like to monitor bitcoin etc doesn't exist. would love to see a fix, solution or similar solutions

Thanks. It seems blockr.io doesn't exist anymore. It was being used to check for payments since it supported checking multiple addresses in batches with support for a specific # of specified confirmations.
There may be other block explorers or API's that support these features.
But unfortunately I don't have the time right now to work on this project. PR's are certainly welcome.


Encode feature row before storing in Redis

What this PR does / why we need it:
Currently, feature names are stored together with the values in Redis, which result in excessive memory foot print in cases where feature names are long strings.
This PR will encode the Feature Row prior to storing them in Redis. Encoding strategy:

Entities are removed from the Redis Value as it already exist in the key.
Feature names are removed, leave only the values. This can then be reconstructed during serving, based on the corresponding feature set spec. Since feature set information is present on the key, the spec is retrievable.

In cases where the Feature Row are from external Kafka source, where it is possible for the feature row to be malformed, there are a few checks in place:

It's fine for the feature row to have feature fields in a different order than that specified in the feature set spec, as the encoding process will sort the feature in alphabetical order based on name.
Duplicated fields are tolerated.

Good to have, but out of scope for this PR:

Under normal circumstances, the decoding process should always succeed, unless the feature set spec obtained during serving is somehow inconsistent with the feature set spec used to encode the feature row due to some bugs. There should be a way to verify this during run time. One approach, is to store checksum/fingerprint of the FeatureSet configuration along with the value in Redis. Not implemented in this PR as there needs to be more discussion on the implementation details.

Which issue(s) this PR fixes:

Fixes #515.
Does this PR introduce a user-facing change?:
After this patch, the ingestion job will start storing the feature row in encoded format. However, the serving job is still able to read the non encoded feature row, hence it is not necessary to re-ingest the data prior to the application of the patch, unless the user wish to reduce the memory footprint of the existing keys.

/test test-core-and-ingestion

/test test-end-to-end-batch

/lgtm

/approve


Runaway logging fills up disk

The 16GB root device of the machine I'm running this on ran out of space due to /var/log/upstart/kafka-manager.log. These logs are rotated daily, so it must have logged a lot in a short time.
The main content appears to be blocks like this:
[INFO] [02/14/2015 13:30:53.858] [kafka-manager-system-akka.actor.default-dispatcher-161] [akka://kafka-manager-system/user/kafka-manager/<cluster>/broker-view] Stopped actor akka://kafka-manager-system/user/kafka-manager/<cluster>/broker-view
[INFO] [02/14/2015 13:30:53.858] [kafka-manager-system-akka.actor.default-dispatcher-161] [akka://kafka-manager-system/user/kafka-manager/<cluster>/broker-view] Cancelling updater...
[INFO] [02/14/2015 13:30:53.858] [kafka-manager-system-akka.actor.default-dispatcher-161] [akka://kafka-manager-system/user/kafka-manager/<cluster>/broker-view] Started actor akka://kafka-manager-system/user/kafka-manager/<cluster>/broker-view
[INFO] [02/14/2015 13:30:53.858] [kafka-manager-system-akka.actor.default-dispatcher-161] [akka://kafka-manager-system/user/kafka-manager/<cluster>/broker-view] Scheduling updater for 10 seconds
[INFO] [02/14/2015 13:30:53.859] [kafka-manager-system-akka.actor.default-dispatcher-161] [akka://kafka-manager-system/user/kafka-manager/<cluster>/broker-view] Updating broker view...
[ERROR] [02/14/2015 13:30:53.860] [kafka-manager-system-akka.actor.default-dispatcher-160] [akka://kafka-manager-system/user/kafka-manager/<cluster>/broker-view] null
java.lang.ArithmeticException

Blocks like this appear every few milliseconds in the log file.

Can you provide the stack trace?

The only relevant messages in /var/log/kafka-manager/application.log are about connection problems to a target Kafka cluster's ZooKeeper.
2015-02-13 16:21:06,907 - [ERROR] - from org.apache.curator.ConnectionState in CuratorFramework-0
Connection timed out for connection string (<IP_ADDRESS>:2181/kafka) and timeout (15000) / elapsed (26629)
org.apache.curator.CuratorConnectionLossException: KeeperErrorCode = ConnectionLoss
        at org.apache.curator.ConnectionState.checkTimeouts(ConnectionState.java:197) [org.apache.curator.curator-client-2.7.0.jar:na]
        at org.apache.curator.ConnectionState.getZooKeeper(ConnectionState.java:87) [org.apache.curator.curator-client-2.7.0.jar:na]
        at org.apache.curator.CuratorZookeeperClient.getZooKeeper(CuratorZookeeperClient.java:115) [org.apache.curator.curator-client-2.7.0.jar:na]
        at org.apache.curator.framework.imps.CuratorFrameworkImpl.performBackgroundOperation(CuratorFrameworkImpl.java:816) [org.apache.curator.curator-framework-2.7.0.jar:na]
        at org.apache.curator.framework.imps.CuratorFrameworkImpl.backgroundOperationsLoop(CuratorFrameworkImpl.java:802) [org.apache.curator.curator-framework-2.7.0.jar:na]
        at org.apache.curator.framework.imps.CuratorFrameworkImpl.access$400(CuratorFrameworkImpl.java:61) [org.apache.curator.curator-framework-2.7.0.jar:na]
        at org.apache.curator.framework.imps.CuratorFrameworkImpl$4.call(CuratorFrameworkImpl.java:272) [org.apache.curator.curator-framework-2.7.0.jar:na]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [na:1.8.0_20]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_20]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_20]
        at java.lang.Thread.run(Thread.java:745) [na:1.8.0_20]

Is this still an issue?  Can we close?

Well, I actually just let it run with a totally full disk for the last few months. I'll kill it and upgrade to latest and see if it still happens.

Hi Patrick, please let us know if this is still a problem.  Thanks!

It hasn't happened again since my report. I'll close this and reopen if I have any more issues.


PSF Deconvolution for IDL and aiapy do not match

In GitLab by @wtbarnes on Jan 25, 2023, 13:42
It was reported by a user that an AIA image, specifically one from 335, when deconvolved with the PSF, does not match the equivalent IDL operation. In particular, it was reported that the result from aiapy looks obviously wrong. More details are needed to resolve this, but I'm creating this now so we don't lose track of it.
Interestingly, there are a set of tests that compare the PSFs produced by aiapy and IDL such that they agree to <1%. However, there is no test to compare the actual deconvolved images (likely because it would take so long). We should have such a test so that this comparison can be done easily and systematically.

In GitLab by @wtbarnes on Jan 25, 2023, 14:20
Closing in favor of #133


spring version to 1.0

@wolender Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


[LiveComponent] Prevent uncollapse item on refresh

Hello, I'm using LiveComponent to render an hardcore form with a lot of collections.
This form has collections inside collapsed div.
When clicking the button to "add" or "remove" a collection item, the item is added/removed but all is "uncollapsed".
Example :
https://user-images.githubusercontent.com/53140475/220677572-1852e200-3e9e-4e8b-bd86-7109fbf66755.mp4
Unfortunately, I cannot add "data-live-ignore" in the div containing the collapsed content since otherwise the buttons allowing to add/remove an element from a collection will no longer refresh the fields.
I had another idea which was to set up a system that would save in the entities whether it's collapsed or not, and at refresh, would allow me to put everything back as it should be, but I find it restrictive, and I wonder if there isn't a better way?
This is how I render the form :

            Éléments de preuve et questionnaire

        {% for sous_dossier_index, sous_dossier_form in form.sousDossiers.children %}
            {% set sous_dossier = sous_dossier_form.vars.data %}

                    {{ sous_dossier.name }}

                            {% for sous_dossier_item_index, sous_dossier_item_form in sous_dossier_form.items %}
                                {% set sous_dossier_item = sous_dossier_item_form.vars.data %}

{{ sous_dossier_item }}

                                            {% set files_item = sous_dossier_item_form.files.children %}

                                            {% for file_index, file_item in files_item %}
                                                <button type="button"
                                                        class="btn btn-link text-danger"
                                                        data-action="live#action"
                                                        data-action-name="removeItem(sousDossierIndex={{ sous_dossier_index }}, sousDossierItemIndex={{ sous_dossier_item_index }}, fileIndex={{ file_index }})">
                                                    Retirer
                                                </button>
                                                {{ form_widget(file_item, {'attr': {'data-model': 'on(change)|norender|' ~ file_item.vars.full_name }}) }}
                                            {% endfor %}

                                            <button type="button"
                                                    class="btn btn-link float-start"
                                                    data-action="live#action"
                                                    data-action-name="addItem(sousDossierIndex={{ sous_dossier_index }}, sousDossierItemIndex={{ sous_dossier_item_index }})">
                                                Ajouter un élément
                                            </button>
                                            <button type="button" class="btn btn-sm btn-secondary float-end">

                                            </button>

                            {% endfor %}

        {% endfor %}

And in the component, my two liveAction to add or remove an item :
    #[LiveAction]
    public function removeItem(#[LiveArg] int $sousDossierIndex, #[LiveArg] int $sousDossierItemIndex, #[LiveArg] int $fileIndex): void
    {
        if (isset($this->formValues['sousDossiers'][$sousDossierIndex]['items'][$sousDossierItemIndex]['files'][$fileIndex])) {
            unset($this->formValues['sousDossiers'][$sousDossierIndex]['items'][$sousDossierItemIndex]['files'][$fileIndex]);
        }
    }

    #[LiveAction]
    public function addItem(#[LiveArg] int $sousDossierIndex, #[LiveArg] int $sousDossierItemIndex): void
    {
        $this->formValues['sousDossiers'][$sousDossierIndex]['items'][$sousDossierItemIndex]['files'][] = [];
    }

Thanks for your help!

Hi @bastien70!
I think the longer answer to this is that we need a smarter re-render system, which is something I've been thinking about for awhile. The problem is that, when you expand an item, some CSS classes are probably added to "expand" that element. Then, on re-render, those CSS classes are missing from the Twig code, so LiveComponents removes them. We don't want that :).
In theory, we could "monitor" for any custom changes made by external JavaScript and be sure to not "undo" those on re-render.
That doesn't help you right now, so let's think of a shorter-term solution :). One idea: create a custom Stimulus controller. Use the hooks system to listen on render:started. This is triggered right after an Ajax call has finished, but before it's been applied to the page. The idea would be to "detect" which item is currently open and save it to some local variable / property on your controller. Then, listen again to render:finished and "re-open" that item - e.g. trigger a click on it or manually re-add the classes it needs. However, it's very possible that this would cause the item to quickly close then re-open again... so we'll need to see if it works in practice. We could also add some way in the render:started hook to modify the HTML that will be applied so that you could add the classes there. Or, we may need some hooks inside of morphdom (the library that applies the "diff" of the latest html onto your component) so that you could run some code whenever an individual "element" is being updated. That would allow you to see that the existing element is one that is open, and add the necessary classes to the "new" element so that they're not removed.
Let me know if any of this helps :)

Hey Ryan!
Indeed, a "show" class is added on the div carrying the "collapse" class when you click on it (and disappears when you click on it again).
I have never used a hook before, but I will try tomorrow with pleasure!
I had also thought of an update idea, I don't know if it's easily added to the library, but a system with a Twig tag that would allow you to define specific places not to be updated, which could be more efficient than the "data-live-ignore" attribute which is effective for the entire element.
For example :

            My title

        {% apply data_live_ignore %}

            {% endapply %}
            Collapsed content here !

Here, we would have the "apply data_live_ignore" tag that I could assign only to the opening of the element that will contain the class that will be added/removed.
And so when refreshing, this part should not be refreshed.
But I imagine that this kind of thing must be complex to set up?

Hey it's me! (Mariooo)
I am doing the custom controller with the hooks.
The problem is that the 'render:started' seems to fire after the divs uncollapse.
For example, I have an element that is collapsed, and so the div has class "collapse" and class "show".
Except that at render:started, everything "uncollapses" directly before the render:started custom script starts, and therefore my divs that had the "show" class no longer have it at this moment, that's odd


[QUERY] AzureSearchChatDataSource.RoleInformation removed?

Library name and version
Azure.AI.OpenAI 2.0.0-beta.6
Query/Question
AzureSearchChatDataSource property RoleInformation was removed with this version and not mentioned in the changelog. Some information here would be helpful.
Environment
No response

Is there a workaround for this?  Our team is sorely missing this.

I hope this issue is resolved soon, as I am currently experiencing problems with my app.

RoleInformation is still missing as of 2.1.0 stable. I'm going to try what @johnrosenbaum suggested, but has anyone else found an alternative/more native solution yet?

Using Azure.AI.OpenAI 2.1.0-beta.2, I have been adding a SystemChatMessage(roleInfoMessage) as the first message when calling ChatClient.CompleteChatAsync - before any question or history - and it is working ok for me.


Request: TS | IBeeConfig['onTogglePreview'] and IBeeConfig['onPreview'] missing parameter Status: boolean

Is your feature request related to a problem? Please describe.
IBeeConfig['onTogglePreview'] and IBeeConfig['onPreview'] are missing parameter Status: boolean as seen in documentation and observed in usage.
https://docs.beefree.io/methods-and-events/#instance-events:

bee.d.ts:

config passed to beeInstance.start():

Describe the solution you'd like
Please add the parameters to the types.
Describe alternatives you've considered
I am currently disabling TypeScript for this line.
I could also patch the type locally.
Additional context
None. Thank you for getting to my last issue so quickly!

Hi @elliothimmelfarb ,
You can find the fix on the latest version of the npm package v1.6.3.

Thank you @davidesamp! ❤


Google Api Error: Invalid request - Your app targets Android 13 (API 33) or above. You must declare the use of advertising ID in Play Console.

Private Zenhub Image
https://developer.android.com/about/versions/13/behavior-changes-13#ad-id
Part of https://github.com/Tonomy-Foundation/Tonomy-ID/pull/825/files has cause the change

expo discussion here https://github.com/expo/expo/issues/19218


merge: dnn and mmod

closing this PR, opening a new one from a different branch with the modifications made.


Keep Endpoint Open When Changing Page

When you going to enable attribute section or changing page to any other page of the application after back to the main page you will see all the endpoints that you extend are closed.

https://github.com/project-chip/zap/pull/712


Daily update

Automated changes by create-pull-request GitHub action

Build failed because of:
No cached entry, and 北京数悦铭金技术有限公司 has issues with logo: tmp0zld4j8d.svg, SVG file embeds a png. Please use a pure svg file
No cached entry, and Sollers College has issues with twitter: https://twitter.com/SollersEdu, Request failed with status code 400
No cached entry, and Open Sourcing Mental Illness, LTD has issues with twitter: https://twitter.com/osmihelp, Request failed with status code 400
No cached entry, and JVC KENWOOD Corporation has issues with twitter: https://twitter.com/JVCKENWOOD_SR, Request failed with status code 400
the project does not use a crunchbase, but a crunchbase https://www.crunchbase.com/organization/proen-corp is present for a PROEN CORP PUBLIC COMPANY LIMITED
the project does not use a crunchbase, but a crunchbase https://www.crunchbase.com/organization/rootchain-technology-co-ltd is present for a Rootchain Technology Co., Ltd
the project does not use a crunchbase, but a crunchbase https://www.crunchbase.com/organization/uniontech is present for a UnionTech Software Technology Co., Ltd.
the project does not use a crunchbase, but a crunchbase https://www.crunchbase.com/organization/velocity-b933 is present for a Velocity
Item 北京数悦铭金技术有限公司 has no image_data


Speed up sdd_report target (and others where possible)

The sdd_report target takes a long time to run, but ideally it shouldn't. Need to figure out how to speed up the data read process, which I suspect is the bottleneck.

This might be finished with the latest PR...I switched to exporting PNGs of large ggplot objects instead of keeping them as targets components in lists. For now this works but I'm not sure if this is what we want to do long-term?


Initial 2015-01 additions

Documentation updates for the Data Model docs for the new Schema - staged at https://www.openmicroscopy.org/site/support/ome-model-staging/

Overall, the content is fine, but there are some wording changes in specific and in general, noted above, which could be made to improve its consistency.

@rleigh-dundee Better?

@qidane Looks much better, thanks.  Good to merge from me.

--no-rebase


sony-headphones-client: patch gcc-20 support

Description of changes

it does not compile currently
surpasses #172286
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

ZHF: #172160

Still fails to build on aarch64. Consider doing something like I did in my PR or just marking aarch64-linux broken.
https://logs.nix.ci/?key=nixos/nixpkgs.173133&attempt_id=8492a911-74f7-498a-8ece-4f798823b9bc

thanks @Mindavi . It should be fixed.


Disable Partial results and increase Chunk size of audio being sent over network

Dear Sir
How can we disable partial results to the Wesocket endpoint when sending File such as .wav and .opus  . I do not want partial results as I cannot work on the partial results in my domain as every word is important. The whole audio should be processed in one shot and as a whole. I have a high speed network between the SDK and Speech recognition endpoint. And telling the Speech endpoint that whole speech has to be processed  I beleive will reduce the processing time and also improve throughput as it can save the compute time spent of making partial results and sending over network.
Also i saw that the audio is being sent in chunks/segments over the network to the WebSocket endpoint at Azure end and not in one single go. Also i think the processing is also happening in the chunks and getting clubbed. Is it possible to specify the chunk size and increase it.
Regards,

@viju2008 Thank you for getting in touch! I am checking with the feature team on this, and we'll get back to you soon.

Any Updates.
Regards,
Vijay

@viju2008 Are you looking for disabling hypothesis ?

@viju2008 From here https://docs.microsoft.com/en-us/dotnet/api/microsoft.cognitiveservices.speech.propertyid?view=azure-dotnet
try setting this SpeechServiceResponse_StablePartialResultThreshold
like
config.SetProperty(PropertyId.SpeechServiceResponse_StablePartialResultThreshold, "100");
Play with different numbers and see what fits your requirement.

I tried setting is as told   config.setProperty(PropertyId.SpeechServiceResponse_StablePartialResultThreshold, "200");
But it is stilling recognizing partially. Below is the output
RECOGNIZING: Text=I need
RECOGNIZING: Text=I need to
RECOGNIZING: Text=I need to transfer
RECOGNIZING: Text=I need to transfer seventh
RECOGNIZED: Text=I need to transfer 7000 rupees to sham.

You have option not to subscribe to recognizing event and in that case the sdk wont callback the app for every intermediate. Do let me know if that solves your problem

Will disabling the event listening for partial results actually stop the speech endpoint or containers from producing partial results  and sending them across the network Or will the sdk simply not display it. I wish that the partial results should not travel over the network also

@viju2008 Even though you disable the event but the intermediate result will travel over the network. Please keep in mind the data which comes from service is a json payload which is text data. The amount of data received is much more lower than the amount of data sent to the service. So I can guarantee you that your data usage will never be a bottleneck for the incoming traffic.

But the purpose of disabling partial results is not served. Its not only about the network overheads also the container need not waste time in making partial results and can in one shot take the hold file and process the same.
The Main reason for the post was so that the response time is made better from container by disabling partial results over the network as well as the compute time involved for the container in partial results. As the partial results are not of any use in my case. Hence if the chunk size could be increased and the whole audio is taken and processed in one go the response time of the container will be better in my case

@viju2008 That is a great input to us. Please put a feature request at https://cognitive.uservoice.com/forums/912208-speech-service
Our team will look at this and will work on it based on our priority.
Thanks a lot.
Closing it for the time being.

Hello @amitkumarshukla
I have put a feature request. Please provide update on progress

waiting too


Issue with training rasa core

Command - python -m rasa_core.train -d domain.yml -s stories.md -o models/dialogue
C:\Users\inhumane\AppData\Local\Programs\Python\Python36\lib\site-packages\h5py_init_.py:34: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
from ._conv import register_converters as _register_converters
C:\Users\inhumane\AppData\Local\Programs\Python\Python36\lib\runpy.py:125: RuntimeWarning: 'rasa_core.train' found in sys.modules after import of package 'rasa_core', but prior to execution of 'rasa_core.train'; this may result in unpredictable behaviour
warn(RuntimeWarning(msg))
2019-05-16 13:42:00 INFO     apscheduler.scheduler  - Scheduler started
WARNING: The TensorFlow contrib module will not be included in TensorFlow 2.0.
For more information, please see:

https://github.com/tensorflow/community/blob/master/rfcs/20180907-contrib-sunset.md
https://github.com/tensorflow/addons
If you depend on functionality not listed there, please file an issue.

Processed Story Blocks: 100%|████████████████████████████████████████████| 6/6 [00:00<00:00, 1163.15it/s, # trackers=1]
Processed Story Blocks: 100%|█████████████████████████████████████████████| 6/6 [00:00<00:00, 367.96it/s, # trackers=6]
Processed Story Blocks: 100%|█████████████████████████████████████████████| 6/6 [00:00<00:00, 90.76it/s, # trackers=36]
Processed Story Blocks: 100%|█████████████████████████████████████████████| 6/6 [00:00<00:00, 65.39it/s, # trackers=42]
Traceback (most recent call last):
File "C:\Users\inhumane\AppData\Local\Programs\Python\Python36\lib\runpy.py", line 193, in run_module_as_main
"main", mod_spec)
File "C:\Users\inhumane\AppData\Local\Programs\Python\Python36\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "C:\Users\inhumane\AppData\Local\Programs\Python\Python36\lib\site-packages\rasa_core\train.py", line 253, in
additional_args)
File "C:\Users\inhumane\AppData\Local\Programs\Python\Python36\lib\site-packages\rasa_core\train.py", line 164, in do_default_training
kwargs=additional_arguments)
File "C:\Users\inhumane\AppData\Local\Programs\Python\Python36\lib\site-packages\rasa_core\train.py", line 89, in train
agent.train(training_data, **kwargs)
File "C:\Users\inhumane\AppData\Local\Programs\Python\Python36\lib\site-packages\rasa_core\agent.py", line 539, in train
**kwargs)
File "C:\Users\inhumane\AppData\Local\Programs\Python\Python36\lib\site-packages\rasa_core\policies\ensemble.py", line 82, in train
policy.train(training_trackers, domain, **kwargs)
File "C:\Users\inhumane\AppData\Local\Programs\Python\Python36\lib\site-packages\rasa_core\policies\keras_policy.py", line 171, in train
shuffled_y.shape[1:])
File "C:\Users\inhumane\AppData\Local\Programs\Python\Python36\lib\site-packages\rasa_core\policies\keras_policy.py", line 101, in model_architecture
from tensorflow.keras.models import Sequential
File "C:\Users\inhumane\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\keras_init.py", line 20, in
from tensorflow.keras import layers
File "C:\Users\inhumane\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\keras\layers_init.py", line 8, in
from tensorflow.python.estimator.keras import Layer
ImportError: cannot import name 'Layer'
C:\Users\inhumane\cc>pip install -U future
Requirement already up-to-date: future in c:\users\inhumane\appdata\local\programs\python\python36\lib\site-packages (0.17.1)

please make sure you've installed the correct tensorflow version, listed in our requirements.txt (and compatible with your current version of rasa)

please make sure you've installed the correct tensorflow version, listed in our requirements.txt (and compatible with your current version of rasa)

can you provide me with the latest requirements.txt. I am not able to find and also python or pip versions compatible

the requirements.txt lives in the github repo: https://github.com/RasaHQ/rasa/tree/0.15.x/alt_requirements


Bug: Parsing of tuples and lambdas dependent on parens.

@let-def Spotted this bug. I have not confirmed it, but filing the report now.
The following parse differently:
f(x => ..., 1)

f((x) => ..., 1)

They should definitely not parse differently. They should both parse as a tuple with the first item being the lambda, second item being 1.

@let-def cannot currently reproduce it, but leaving this open to track it in case anyone comes across something similar.


[apple watch] update EOL dates, add watchOS 11 and series 10

https://support.apple.com/en-us/docs/watch
https://www.apple.com/nz/watchos/watchos-11/

Thanks @jlaundry!


Fix location missing on store init

Location meta data was missing on store init during SSR, meaning href, query, route and params was missing from state when initializing stores.
This fixes that by running _matchRoute before initializing stores during SSR.

v6.13.2 🎉


[Pods] DCOS-9613: 2/2 Adapting ServiceFormModal to work with ServiceSpec

⚠  Depends on #1052 Merged

This PR makes ServiceFormModal operate on service spec and not on the service instance itself (that is now considered to carry the status information)

I will preferably need also #1083 and #1081 merged before I can continue with this.

Failed to rebase this guy. Could you take a look?

Rebased

@mlunoe the https://github.com/dcos/dcos-ui/pull/1081#pullrequestreview-32738 issue should be fixed with the latest merges. I rebased the PR.

I still get the error deploying a simple new service. Could you test this out yourself?

Going to merge this guy in as well, to continue the development


fix node.js v16 deprecation

Node.js 16 actions are deprecated.
v3.0.1 fix deprecation

Addressed in ec3ba4bfa2ec37df576bcf7a087e5a4ab88d79a4 with some other CI issues. Thanks for point it out.


VPC: Refresh fails when ipv6_ipam_pool_id is specified

What happened?

When ipv6_ipam_pool_id is specified for the VPC MR, the resource is successfully provisioned, however on further reconciles the generated Terraform includes the ipv6_cidr_block_network_border_group field, which must be specified alongside assign_generated_ipv6_cidr_block. However assign_generated_ipv6_cidr_block conflicts with ipv6_ipam_pool_id.

MR (derived from XR; some fields redacted)
apiVersion: ec2.aws.upbound.io/v1beta1
kind: VPC
spec:
  deletionPolicy: Delete
  forProvider:
    cidrBlock: <IP_ADDRESS>/16
    enableDnsSupport: true
    instanceTenancy: default
    ipv6CidrBlockNetworkBorderGroup: us-east-1
    ipv6IpamPoolId: ipam-pool-12345678901234567
    ipv6NetmaskLength: 56
    region: us-east-1
    tags:
      Name: network-qsfrr
      crossplane-kind: vpc.ec2.aws.upbound.io
      crossplane-name: network-qsfrr-nnz5z
      crossplane-providerconfig: rnd-sandbox
  initProvider: {}
  managementPolicies:
    - '*'
  providerConfigRef:
    name: rnd-sandbox

provider-aws logs:
2023-09-05T13:00:01Z    DEBUG    events    cannot run refresh: refresh failed: Missing required argument: "ipv6_cidr_block_network_border_group": all of `assign_generated_ipv6_cidr_block,ipv6_cidr_block_network_border_group` must be specified    {"type": "Warning", "object": {"kind":"VPC","name":"network-qsfrr-nnz5z","uid":"86eaa743-4f77-4181-9e48-184ab3b22ee5","apiVersion":"ec2.aws.upbound.io/v1beta1","resourceVersion":"1024207"}, "reason": "CannotObserveExternalResource"}

Generated Terraform:
{
  "provider": {
    "aws": {
      "assume_role": {
        "external_id": "rnd-sandbox",
        "role_arn": "arn:aws:iam::123456789123:role/crossplane-delegated",
        "tags": null,
        "transitive_tag_keys": null
      },
      "region": "us-east-1"
    }
  },
  "resource": {
    "aws_vpc": {
      "network-n4zc5-jvmqc": {
        "cidr_block": "<IP_ADDRESS>/16",
        "enable_dns_support": true,
        "instance_tenancy": "default",
        "ipv6_cidr_block_network_border_group": "us-east-1",
        "ipv6_ipam_pool_id": "ipam-pool-12345678901234567",
        "ipv6_netmask_length": 56,
        "lifecycle": { "prevent_destroy": false },
        "tags": {
          "Name": "network-n4zc5",
          "crossplane-kind": "vpc.ec2.aws.upbound.io",
          "crossplane-name": "network-n4zc5-jvmqc",
          "crossplane-providerconfig": "rnd-sandbox"
        }
      }
    }
  },
  "terraform": {
    "required_providers": {
      "aws": { "source": "hashicorp/aws", "version": "4.67.0" }
    }
  }
}

How can we reproduce it?

What environment did it happen in?

Crossplane Version: crossplane/crossplane:v1.14.0-rc.0.203.g3996f200
Provider Version: 0.40.0
Kubernetes Version: v1.24.16-eks-2d98532
Kubernetes Distribution: EKS

Possibly related to https://github.com/upbound/upjet/issues/214

/fresh


Is this module still up to date? Can't set it up with new Google Analytics ID

I have problem with setting up this (or any) module with the new Google Analytics ID number format, which is G-XXXXXXXXXX - not UA-XXXXXXXX-X.
It just doesn't work.

the answer is no and it's also pinned in the issue list

the answer is no and it's also pinned in the issue list

you need to use a gtag compatible package

you need to use a gtag compatible package


gir-secret not generated

Problem both in Windows7 and Ubuntu.
On windows7 I don't have libsecret installed, so don't worry about it.
But when I tried build on Ubuntu it still not generated with other error.
Running `/gir/target/release/gir -c gir-secret.toml`
thread '<main>' panicked at 'No such file or directory (os error 2) - ../gir-files/Secret-1.gir', /gir/src/parser.rs:37

Checked gir-files and don't found Secret-1.gir not in directory, not in git history.

Maybe problem with bashizm in test.sh
./test.sh: 5: [: unexpected operator

Strange: on Windows7 now also same error about missing Secret-1.gir, but yesterday IMHO was error on compiling sys_build.

Oh I just forgot pull gir-files 15 day ago. So this partially solved.


Fix crash in chrom 60, windows 7

Fix #63
From @whyka fix crash in exchange_rate, I apply for account and wallet. The reason causes crash is put function convert in title: title={toT(this.props.balance)}, so I remove it in rate. account and wallet. Currently, there is no crash in my windows 7, chrome 60. @tranvictor Could you check for OS X

@andrewsource It works like a charm on my Mac. Run several accounts for long time and no crash.
You should remove black list also.

@andrewsource Do you know why call function for attribute title in JSX cause problem?

@whyka I do not know now, It seems this only happens in chrome 60.

Title is necessary there so people can have a way to see the actual (not rounded) number. Please find another way to avoid inline function calls.

@tranvictor I've added title after change function toT, and there is no crash.

@andrewsource this is becoming very interesting. So i bet if we want to really know what is wrong we need to dig deeper into BigNumber library. Good job guys @andrewsource @whyka . I will test and merge this soon.


Improve the layout and texts of the Editor Feature Profiles dialog

After interacting with this dialog a bit I've noticed that some texts don't really make sense (e.g. sections called "Enabled X", when it was a list of all X where only items with selected checkboxes were enabled) or don't convey the intention well for a user. The layout is also pretty rough, with buttons that don't really have any order and therefore are harder to work with.
I've rearranged some elements to better group them together, and changed some titles and labels to be clearer and nicer.

Current layout, for comparison
As evident from the screenshot above I've also considered that it would be beneficial to have some sort of description here to let users know what exactly they enable and disable. I've provided descriptions for the main features, and for the nodes and resources I've used documentation data.

More screenshots:

Some nodes don't have properties, and before there was an empty branch for them. This is now fixed, no empty branch.
Most descriptions fit nicely, and for some edge cases we have a nice scroll. All docs are properly parsed and interactive, by the way.
Create and Remove profile dialogs were also slightly improved.

If this is controversial I am prepared to open a proposal, but I think this is a pretty straightforward uplift + a little usability feature.

Thanks!

Cherry-picked for 3.4.


CI Testing for macOS

Since we are cross-compiling the shp binary, we should ensure that all tests work on a macOS client.
GitHub actions now support macOS based runners - it is not clear if all of our dependent actions also support these runners (ex - install Docker, KinD, etc.)
See https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

/assign @coreydaley


Works for some, but not for all.

I'm a part of the Garry's Mod server "Freebuild and Kill," and we've been having an issue as of lately that might be related to WebAudio.
One of our members made this "YouTube Player" that uses WebAudio functions, and they made it public for everyone on the server to use. How it would work is: you place the chip down, type a prefix followed by the URL or video name, and the name of said video would show in chat and in console.
For the past couple weeks, we've been having an issue with these players. People could queue a song, and it'll show in console and in chat, but not everyone hears it. Some people do, some people don't. When I try and queue a song with my own player, again, it shows in chat and in console, but I can't hear it, and neither can others. But we all the same exact player. Instead, it gives this error:
[WA]: Error when creating WebAudio receiver with id 4, Error [BASS_ERROR_TIMEOUT]
Our custom Youtube Core addon doesn't seem to be issue, and all we can think of is that its WebAudio. I have no clue if this is happening around other servers who use WebAudio or what, and I'm not super educated in Expression 2, but just thought I'd get something out there.
Thanks for reading this,
thezcar

That's an internal error from BASS, which garrysmod uses for IGmodAudioChannel (which webaudio uses)
http://www.bass.radio42.com/help/html/78effdb0-70b5-1602-a234-b0847b4e6d6c.htm
According to this page, as the name already said, the connection is timing out.
Does this youtube api synchronously have to download a video and respond with it? If so likely that's the issue, as if bass waits (5 seconds default from what I see on other pages), and the page has yet to respond, it will fail.
Unfortunately all I can see that can be done is if the api they are using caches the sound requests, so the E2 creator could use httpRequest to first tell the server to start downloading the video, and then try playing the sound for other players. I know from personal experience a youtube download/sound hosting api will be very slow, since you first need to download it from youtube, and then convert it to mp3.. this is just my best guess though


Too long pod name when using Playwright latest images

Should not be more than 63 symbols.

Fixes in https://github.com/aerokube/moon-src/pull/484


fusermount is not installed in keybaseio/client docker image

I am trying to use the keybaseio/client:stable docker image, according to this page: https://github.com/keybase/client/tree/master/packaging/linux/docker
When I use this option (-e KEYBASE_KBFS_ARGS="-mount-type=default") to mount KBFS, I get the following errror:
ERROR Mounting the filesystem failed: fusermount: exec: "fusermount": executable file not found in $PATH
It looks like fusermount just isn't installed. Can this be added to the image?

Can you use simplefs commands to do what you need? keybase fs help

+1 for adding fuse to the image, looks like it only adds another 488kb (when running apt install fuse as root), assuming there's not a security issue here, can we have it added?
I am using the docker image in rancherOS to run keybase in a container, I want to mount KBFS so I can expose it to the host & other containers for bi-directional transfer. The simplefs commands don't do it for my unfortunately.

Making FUSE work in a container requires giving it privileges equivalent to being the root of the host OS, which completely defeats the sandboxing aspect of containerization. We discourage that practice by not including FUSE in the base images and instead encourage bot developers to use the simplefs (keybase fs) commands.
If you understand the risks of such a setup, you should make your own image based on keybaseio/client and use it in your deployment.
I actually run roughly the same setup on my personal server :) We'll add a section about running it in FUSE mode to the documentation.

Making FUSE work in a container requires giving it privileges equivalent to being the root of the host OS, which completely defeats the sandboxing aspect of containerization. We discourage that practice by not including FUSE in the base images and instead encourage bot developers to use the simplefs (keybase fs) commands.
If you understand the risks of such a setup, you should make your own image based on keybaseio/client and use it in your deployment.
I actually run roughly the same setup on my personal server :) We'll add a section about running it in FUSE mode to the documentation.

@pzduniak Thanks, that makes sense. Would love to see a FUSE write-up when you get a chance, I've been struggling to get it working.
Also, as a sidenote - do you have public configs anywhere for your personal server? I'm sure I'm unnecessarily reinventing the wheel on a few things...

I was able to get this working by using a rshared mount using --mount type=bind,source=$MOUNT_SOURCE,target=/home/keybase/.config/keybase,bind-propagation=rshared but you need to make sure you run mount --make-rshared / if rshared isn't configured for the directory. For this to work you would need to install fuse in the container though.
If you run another container you can access it by just using -v $MOUNT_SOURCE:/keybase in the docker run command.
I couldn't seem to find a way to use a docker volume to handle the share since I don't want to use a mount but it works until there's a way around it.


Summary
As the title says.
What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[x] Code style update
[x] Refactor
[ ] Docs
[ ] Build-related changes
[ ] Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature
[ ] Related documents have been updated (docs/docs/en)
[ ] Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

[ ] Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:

https://stackoverflow.com/questions/39932391/virtual-override-or-both-c
Best practice is virtual on the base and override on the derived function


Reference: https://github.com/audioscience/avdecc-lib/issues/351

Volume( Audio equalizer) change implemented for SET Control. No implementation for SET CONTROL Response. It is realized and tested along with API changes in AVDECC cmdline and AVDECC AECP.

@sachindes - can you please email me directly at<EMAIL_ADDRESS>Thanks!

As decided, Copyrights assigned to @andrew-elder and @AudioScience Inc

@andrew-elder , @jdkoftinoff  let me know if above copyright process is fine. I am not aware of process.


fedifinder.glitch.me Page is down

Sadly, the fedifinder page is currently down.
It just says: "Oops! This project isn't running. If this is your project, check out the Glitch Editor, or head over to the Help Center to learn more."
Clicking on the editor brings another error "This project has been suspended Reason for suspension: Suspended for error while preparing project. If you think this was done in error, email<EMAIL_ADDRESS>

I am working on it. Until then, you can use https://fedifinder-backup.glitch.me/

Fedifinder is up again. https://fedifinder.glitch.me/


Simplify snippet translation

The only way to nls the following snippet string in package.json:
"address": "${2:TCP/IP address of process to be debugged}"

is by using this in package.json:
"address": "%address.description%"

and this in the package.nls.json:
"address.description": "${2:TCP/IP address of process to be debugged}"

With this the translators have to deal with the snippet syntax which is error prone.
I suggest that we support something like this:
"address": "${2:%address.description%}"

and this in the package.nls.json:
"address.description": "TCP/IP address of process to be debugged"

This looks like a request for Dirk (that our package.json nls story would support partial translated strings)

/duplicate https://github.com/microsoft/vscode/issues/125774

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Fix small typo

Anroid => Android

@ValentinH - thanks for submitting this PR!
The Travis CI is currently broken due to a npm issue & #1866 will fix that. So after that PR is landed, please rebase your change onto master and then I can approve & merge this in.

@ValentinH #1866 is now in master and CI is passing now. Please rebase to get the fix 😄


Methodology and actual benchmark settings should be published

The methodology for the testing nor the actual coremark settings are published, thus making reproduction almost impossible.
Ideally this article should detail how testing was performed and the exact command and settings used.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c005a93a-6fce-d270-9bb5-8e7213156b70
Version Independent ID: 844d62d4-a06b-1578-488f-f6441242a07d
Content: Compute benchmark scores for Azure Linux VMs
Content Source: articles/virtual-machines/linux/compute-benchmark-scores.md
Service: virtual-machines-linux
GitHub Login: @cynthn
Microsoft Alias: cynthn;davberg

@msLinuxNinja at the bottom of the document we mention how they are run and calculated

Is that not sufficient?

Hey Micah, what I mean with proper methodology and test settings is explicitly defining the testing scenario, for example it says CoreMark was run on an Ubuntu VM. But it doesn’t state which version or which kernel, things that would affect benchmark results.
Also, it says that CoreMark settings were adjusted but, it doesn’t specify which settings were used for which tests. Ideally the article should provide the exact settings and command used so that users can reproduce the same testing scenario and compare numbers.

@msLinuxNinja thanks for the clarification. I am not sure this is something that we want to be included in the article. Regardless, I will assign to the author for further review.
CC @cynthn @daviburg

@msLinuxNinja Thanks for the feedback! This isn't something we want to add to the docs at this time, but David has heard the feedback.
#please-close


Clipboard value is changed in Internet Explorer

The issue takes place also in the example. http://marceljuenemann.github.io/angular-drag-and-drop-lists/demo/#/types if i will select the name of a person (f.e. "Frank") and copy it with Ctrl + C, and then paste it, then everything works, but if i will drag and drop this item, and then try to paste the name, instead of "Frank" it inserts the '{"name":"Frank","type":"man"}'. This behavior is only seen in IE.

I have encountered the same issue

I was experiencing this too, and did some research. It seems to be a bug in the IE drag and drop browser API, not the library.
I found this vanilla JS drag and drop demo via a google search result: https://html5demos.com/drag/ - In IE, copy some arbitrary text into your clipboard, then in the demo, drag one of the list items into the rectangle on the left-hand side. Your clipboard content will get replaced by whatever the content of your drag item was.
One way that you can solve it is by using a drag and drop shim, and allowing it to override the default browser behavior. Defiantly do some regressions testing if this is the route that you choose to take. (The shim linked in this project's README.md file can do this - https://github.com/timruffles/ios-html5-drag-drop-shim - see the "forceApply" option.)


Fix line offset when using single-line ~H variants

Before Elixir v1.10 we were not able to report the error line correctly for single-line ~H because there was no way to retrieve the information about the delimiter so we had to add a + 1 to the line offset because using ~H""" is more common than using the other single-line variants like ~H"..." and ~H(...). See:
https://github.com/msaraiva/surface/blob/2286f8b6130679f60fd5ece18251d3f84a1dd830/lib/surface.ex#L106-L109
Since v1.10, the delimiter is available so we're now able to fix this. Here's the difference:
~H""" in Elixir v1.9.1
{:sigil_H, [], [{:<<>>, [], ["text\n"]}, []]}

~H() in Elixir v1.9.1
{:sigil_H, [], [{:<<>>, [], ["text"]}, []]}

~H""" in Elixir v1.11.1
{:sigil_H, [delimiter: "\"\"\""], [{:<<>>, [indentation: 2], ["text\n"]}, []]}

~H() in Elixir v1.11.1
{:sigil_H, [delimiter: "("], [{:<<>>, [], ["text"]}, []]}

@msaraiva I do not understand how the delimiter is available inside the sigil macro. It's seems that the only difference is that the identation key is available when """ is used. Would you want to modify the line_offset based on the presence of that key?

@Malian you're right. Only :indentation is available inside the macro and it's only added from v1.11 on. So, in theory, we should not add + 1 to the offset if version >= 1.11 and the :indentation key is not present (it should only be present if we're using ~H""").


156 wrap propagators

Ready for review

Not sure why this failed, looking now

The tests all pass on my local branch of 156, which says it is up to date with origin

I'm not sure why the python-ci test is failing.
I will merge the PR anyway.

Okay, I thought I did clear all, must have missed one.

It is likely that you did the right thing but that a previous developer did not.
A happy outcome can only be achieved if 'clear all' is consistently executed by all developers prior to making commits.


Draft: Update skeleton

Apply the latest skeleton repo.
Ditch changes to the docs as current build is fine.

I also need to re-enable the code CI

The docs build is failing with
  File "/opt/hostedtoolcache/Python/3.11.3/x64/lib/python3.11/importlib/metadata/__init__.py", line 565, in from_name
    raise PackageNotFoundError(name)
importlib.metadata.PackageNotFoundError: No package metadata was found for coniql

but it does not do this locally so I will compare what I am doing to the docs CI.

I've fixed the CI, as well as a few miscellaneous formatting issues and black/mypy issues. I think this is ready.
Note that we still need to rename master -> main, and migrate the whole repo to DiamondLightSource.


feat: New graphics for room 8

Added a little texture to the walls and ground as it was really bland


Zoning::KeepClear needs to be displayed

Currentl it's not shown on the main map, despite being important.

Duplicate of #515.


expose send text delay as a parameter

What problem did you solve?
#332
(If you do not have screenshot) How can I check this pull request?

Open R program
write R code
Open R terminal
send text
change option for delay text to 2000
send text gain

It should now take 2 seconds before it sends
Not sure if this needs any more documentation or a better explanation

Thanks! This works as expected.

LGTM