Full map becomes revealed to players if they switch to a different scene and back again (firefox only)

Foundry 0.7.9
Perfect Vision 1.5.0

If a player is on a map with fog of war, and they switch to another publicly accessible scene and back again, then the whole map is revealed to them.  This only happens in Firefox, and when Perfect Vision is enabled.  E.g.
Initial player view...

View after switching to a different scene and back again...

Also, here's the really weird thing.  If you log in with Firefox after a fog reset then the problem happens.  But if I reset the fog, then log in as a player with Vivaldi (chromium based), then the problem does not occur.  However if I then log back in as the same player with Firefox, then the problem no longer occurs in Firefox either.  Somehow the initial Vivaldi log in prevents the problem happening in Firefox.

That's super weird. I wasn't able to reproduce it unfortunately. Do you get any errors in the console? Could you try to send me a simple world with two scenes and one token that has this problem?

That's super weird. I wasn't able to reproduce it unfortunately. Do you get any errors in the console? Could you try to send me a simple world with two scenes and one token that has this problem?

This only seems to happen in Firefox on Linux.  On Windows, I ran into a slightly different issue (a strange portion of the map is revealed) that happens regardless of whether Perfect Vision is enabled or not.
I've attached a world with two scenes and a single actor.  You can log in as GM or "Bob" (no password for either) and flick between the two scenes to trigger the issue.
Linux: Debian 10 (with backported 5.9 kernel)
Firefox: 84.0.2
perfect-vision-test.tar.gz

This only seems to happen in Firefox on Linux.  On Windows, I ran into a slightly different issue (a strange portion of the map is revealed) that happens regardless of whether Perfect Vision is enabled or not.
I've attached a world with two scenes and a single actor.  You can log in as GM or "Bob" (no password for either) and flick between the two scenes to trigger the issue.
Linux: Debian 10 (with backported 5.9 kernel)
Firefox: 84.0.2
perfect-vision-test.tar.gz

Thanks. I'll try to reproduce it in a VM. And could you send me a screenshot that shows the strange portion of the map that is revealed without Perfect Vision?

Thanks. I'll try to reproduce it in a VM. And could you send me a screenshot that shows the strange portion of the map that is revealed without Perfect Vision?

I submitted a bug report to core Foundry for the other problem
https://gitlab.com/foundrynet/foundryvtt/-/issues/4442

I submitted a bug report to core Foundry for the other problem
https://gitlab.com/foundrynet/foundryvtt/-/issues/4442

BTW, if you use a Debian VM, I am using the the latest version of firefox downloaded from the mozilla website, not the one from apt.
Also, I have a hunch this may be hw acceleration related, so not sure if it will reproduce in the VM or not, and you may have to force firefox to enable hw acceleration.

BTW, if you use a Debian VM, I am using the the latest version of firefox downloaded from the mozilla website, not the one from apt.
Also, I have a hunch this may be hw acceleration related, so not sure if it will reproduce in the VM or not, and you may have to force firefox to enable hw acceleration.

Hate to pile on, but I also had this issue in my game today. No one else was having a problem (including someone using Firefox). But one of my players who was on a Mac and using Firefox did have this issue. It was really weird. I would reset the fog of war, then he would walk around the room and at certain points in the room, the fog of war for the whole map would disappear. I would reset, he would walk around, and then he could see everything again. He refreshed, he logged out, I stopped my Forge server, he tried Firefox on a different computer, but it still kept happening. It wasn't until he logged into the game under Chrome on a different computer that he stopped having issues. I couldn't talk him through finding the console log and I haven't been able to reproduce on my end. I do have a short video though of him sharing his screen that clearly shows the issue.
https://user-images.githubusercontent.com/62632755/109452361-948f6d80-7a1d-11eb-85d3-44752fb0b4c9.mp4

@corpocracy I doubt this is Perfect Vision's fault. I feel like this is a different issue than the one above. Foundry's sight system has some bugs (see here) which will be fixed in Foundry 0.8.2 hopefully. Those kind of problems are very hard to track down, especially without a way to reproduce it. Sorry that I can't be of more help at the moment.

I have a very similar issue, also Firefox and Linux. Moving a Token around in a player session might reveal the whole fog of war area as "explored" (visible, but masked). Seems kind of non deterministic, but it happens after a few moves, even if you just move forth and back the same squares a few times. If I disable the perfect vision, everything works as expected.

After a few more tests: With perfect vision active the whole FOW is marked as explored, without Perfect Vision the FOW is only lifted on rooms with light sources.
I also tend to blame a Foundry FOW bug - when using Perfect Vison this bug seems to be triggered on a larger scale since in manipulates lightning. Basically Foundry seems to reveal FOW of sealed off parts of the map when they have a light source.

@neovatar Interesting observation. Could you send me a simple scene that has this problem? I'd like to try to reproduce it.

@dev7355608 Just the json? Or is there a way to export the scene with the background image?

@neovatar Just the json. I don't need the assets.

fvtt-Scene-FOW-Test.zip
https://user-images.githubusercontent.com/550533/114070228-133ebc80-98a0-11eb-9d94-4333b4f2b761.mp4

Scene:
fvtt-Scene-FOW-Test.zip

Video of the bug:
foundry-fow-bug.zip

I added a video of the bug - I was only able to reproduce it on "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:87.0) Gecko/20100101 Firefox/87.0", did not happen with Firefox in WIndows 10.

Yes, I also did another try with all Firefox add-ons disabled, just to be sure, but had same results.
I just opened a bug in the Foundry tracker: https://gitlab.com/foundrynet/foundryvtt/-/issues/4850

And that is how the bug looks with Perfect Vision active:

PV 1.8.0 includes a hack to fix the FoW issue; at least the problem reported by @neovatar (let me know if it works).
And I would like to know if this has any impact on the issues described by @cs96and and @corpocracy. If you could let me know, whether it makes any difference, that would be great. And let me please know what color is shown when you run this test in the OS and browser that you experienced the problem with.

@dev7355608 just did a quick test with PV 1.8.0 and FoundryVTT 0.7.9 (without my monkey patch). I can confirm, that the workaround you included in PV fixes the issue.

I can confirm that 1.8.0 fixes the bug I reported.  I re-tried it with 1.7.3 and the bug was still present.  Upgrading to 1.8.0 fixed the issue.

@cs96and Good to know. Just to make sure: if you run this test, I assume it shows yellow, right?

I get green

In Firefox? That's odd: if you get green, the hack to fix it shouldn't be enabled. Do you get a notification in Foundry that says "Rendering bug detected. [...]"?

Yep I got a notification saying the hack was enabled.  yet I get green in that test.

That's firefox in Linux BTW.

Does this test show a tiny triangular face or a complete bunny?

Tiny triangular face

Have you only ever had problems when switching scenes, or did you also experience that the whole map is revealed when you move tokens like the others described?

I've only noticed it when switching back and forth between scenes.


Using custom Attribute per Object of single material

I am wondering if Pxr Renderman for Blender supports this: using special color or other attribute per object.
Blender has this Color attribute per Object that I often use in Blender Internal to render special color per object, with same materials.
I wonder if Renderman can have such override per object basis.
Or is the Vertex Color info can be used like in Cycles?

Do you want like a random color per object or to set this object is red,
etc.  How do you set those attributes in blender internal?
On Mon, Jan 9, 2017 at 2:12 PM, Jimmy Gunawan<EMAIL_ADDRESS>wrote:

I am wondering if Pxr Renderman for Blender supports this: using special
color or other attribute per object.
Blender has this Color attribute per Object that I often use in Blender
Internal to render special color per object, with same materials.
I wonder if Renderman can have such override per object basis.
Or is the Vertex Color info can be used like in Cycles?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/432, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABzffP6ZDsBljqzgXHDHXclpeJEOa-a5ks5rQrDNgaJpZM4LeyrW
.

--
<EMAIL_ADDRESS>508-274-8700

Each Object has this Color attribute.

When set, it kind of multiply over shader (Object Color must be ticked in the material).

I am not familiar with Pixar Material, but I like to have some kind of attribute in the node that I can control using Animation Nodes. Or other means. Per Object basis.

Yes like random color per object, or another node way to provide this list of values per object.

Not particle instancing. But would like to know that too. Different topic.
I have like 2106 objects, I wanted to use the Object Color piped into Renderman 1 material.

PxrVary node is normally the way you do a random color per object.  Set it
to vary by "Object Name" and turn the hue vary up to 1.
On Mon, Jan 9, 2017 at 2:20 PM, Jimmy Gunawan<EMAIL_ADDRESS>wrote:

Yes like random color per object, or another node way to provide this list
of values per object.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/432#issuecomment-271426192,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzffBY478FIZyrZF341qJyBtn4wsK6Pks5rQrKzgaJpZM4LeyrW
.

--
<EMAIL_ADDRESS>508-274-8700

Ok I am getting this variation of color via PxrVary, but what if I wanted to specify my own Color values per object in Blender? Like from that Object Color.
bpy.data.object.color
Or on top of that, the Vertex Color "Col" per Object?
I wil check PxrVary documentation...

I reckon, there must be a way to specify custom color per custom attribute that user specified....  Per Object or Per Face.

So in cycles you have to use a vertex color map, no?
Those should work in prman too, you have to add them in the mesh properties.
On Mon, Jan 9, 2017 at 2:36 PM, Jimmy Gunawan<EMAIL_ADDRESS>wrote:

[image: screen shot 2017-01-10 at 09 35 47]
https://cloud.githubusercontent.com/assets/3952687/21786489/32298fce-d718-11e6-9487-d00913b7e52c.png
I reckon, there must be a way to specify custom color per custom attribute
that user specified.... Per Object or Per Face.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/432#issuecomment-271430136,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzffOsX73QKojUeCxfRNtfoWcGVWLa1ks5rQrZxgaJpZM4LeyrW
.

--
<EMAIL_ADDRESS>508-274-8700

I tried Mesh Properties, Vertex Color, and ... black. Pixar cannot find the "Col".
bpy.context.object.color = (1, 0.85557, 0.206023, 1)
PRMan: X00002 {ERROR}   Plugin error: [PxrAttribute] Could not find: 'Col' attribute or option [ Object: Cube Shader: Material.PxrAttribute]
Vertex Color is called "Col".

So there are 3 things:

Vertex Color passing into Renderman Material?
Custom Attribute like Object Color per object to Renderman Material?
Curious about Pixar's own Custom Attribute. PxrVary is ok, but I like to pass in some of my own values.

PxrPrimvar is what you want not PxrAttribute.
Other way you could do it is with PxrVary (set to black and white) which
leads into a ramp shader with different colors and ramp set to constant.
On Mon, Jan 9, 2017 at 2:46 PM, Jimmy Gunawan<EMAIL_ADDRESS>wrote:

So there are 3 things:

Vertex Color passing into Renderman Material?
Custom Attribute like Object Color per object to Renderman Material?
Curious about Pixar's own Custom Attribute. PxrVary is ok, but I
like to pass in some of my own values.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/432#issuecomment-271432495,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzffKin62mGW0R1I9xP-mlhAf4_zbNeks5rQrjagaJpZM4LeyrW
.

--
<EMAIL_ADDRESS>508-274-8700

Above is Cycles and Animation Nodes, and Blender Object Color attribute.

I'll check PxrPrimVar... > for Vertex Color?
But is there one Pixar Material attribute to pass in custom values or attributes per Object basis?

Ok.  I think we could output the color there in the object properties as an
attribute.  Should be simple.
On Mon, Jan 9, 2017 at 2:53 PM, Jimmy Gunawan<EMAIL_ADDRESS>wrote:

I'll check PxrPrimVar... > for Vertex Color?
But is there one Pixar Material attribute to pass in custom values or
attributes per Object basis?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/432#issuecomment-271434074,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzffKk2wFRXqn2HaYIVGsOhyS3TaCmQks5rQrqHgaJpZM4LeyrW
.

--
<EMAIL_ADDRESS>508-274-8700

Hmm.... PrimVar does not read Vertex Color "Col" either.

When succesful I'll blog / vlog this finding 👍

Reading this... maybe related.
https://github.com/bsavery/PRMan-for-Blender/issues/247

Yes, but that's a bit overkill for one color per object.
On Mon, Jan 9, 2017 at 2:58 PM, Jimmy Gunawan<EMAIL_ADDRESS>wrote:

Reading this... maybe related.
#247 https://github.com/bsavery/PRMan-for-Blender/issues/247
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/432#issuecomment-271435117,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzffJhkgFLMKo0jihjmK36skT_aLDcbks5rQrukgaJpZM4LeyrW
.

--
<EMAIL_ADDRESS>508-274-8700

Oyes, the "Cs" thing works, now just the Color per Object :) via Object Color. Thanks beforehand.
Still curious what can and cannot go into Pixar Material.
Blender Cycles actually has this limitation. But I hack it using Animation Nodes into Vertex Color of each Object.
If Pixar Renderman can just use any Custom Values that can be read per object, it would be awesome.
I use Animation Nodes Add-On by Jacques Lucke and I think it's a good pipe.

I just added something to use the Object Color.
Set your object color then in your PxrAttribute node set it to color (obviously) variable name Cs.

@bsavery oh cool! Can I update this? Is there a quick update now?
I noticed something: Pixar Materials are not keyable.
Ideally all I wanted to do is: set custom attribute value, baked, pass the value to Renderman Material and render.
I'll come back with result and will close.

Ok, I downloaded latest and reinstall, the Cs into PxrAttribute does not work per Object Color basis.
Still curious what custom values can go into Pixar Material attribute and how.

Yes it does work there.  Here's an example.
objectcolor.blend.zip

Force update? I reinstalled a few minutes ago. Checking the Blend...

On the good note, the overkill Cs PrimVar works. Still trying with Object Color.
Cs is ok with me, but what if the object has multiple Color Vertex named different like "Col", etc. What value will it takes? A mixed?

Still nope. How to check version btw? 21.2.0 from Preferences. But how do I know this is the latest2?

You need to update the blender addon, maybe remove it from blender and
reinstall from the github page.
On Mon, Jan 9, 2017 at 5:05 PM, Jimmy Gunawan<EMAIL_ADDRESS>wrote:

Still nope. How to check version btw? 21.2.0 from Preferences. But how do
I know this is the latest2?
[image: screen shot 2017-01-10 at 12 04 23]
https://cloud.githubusercontent.com/assets/3952687/21789948/f981cb36-d72c-11e6-9066-4b6d139ce4d7.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/432#issuecomment-271456976,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzffIw1qDjenHmH1HsnTFMERwWkCHqTks5rQtlNgaJpZM4LeyrW
.

--
<EMAIL_ADDRESS>508-274-8700

Here's using vertex color:
vertexcolor.blend.zip

But I did, few minutes ago after you said you add something. Hmmm... I will uninstall. Close Blender, download again and reinstall.
By the way, what was it you added so that Cs is understood as color? If the Object Color works, this mean I can bring in any kind of RGB value? Sweet... Trying again.

@bsavery  Latest commit fe9707f  4 days ago

PxrPrimvar = read primvar (this would be values set per vertex)  vertex
colors should have been working as primvars before.
PxrAttribute = read per object attribute.  I added the bit so it writes out
the object color as an object attribute.
On Mon, Jan 9, 2017 at 5:16 PM, Jimmy Gunawan<EMAIL_ADDRESS>wrote:

But I did, few minutes ago after you said you add something. Hmmm... I
will uninstall. Close Blender, download again and reinstall.
By the way, what was it you added so that Cs is understood as color? If
the Object Color works, this mean I can bring in any kind of RGB value?
Sweet... Trying again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/432#issuecomment-271458739,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzffLmrxfOEbJCmQ2leI_Uo2G9ylvZGks5rQtwJgaJpZM4LeyrW
.

--
<EMAIL_ADDRESS>508-274-8700

Oops you're right, sorry I forgot to push the fix.
On Mon, Jan 9, 2017 at 5:18 PM, Jimmy Gunawan<EMAIL_ADDRESS>wrote:

@bsavery https://github.com/bsavery Latest commit fe9707f
https://github.com/bsavery/PRMan-for-Blender/commit/fe9707ffd3ca1ca2052e37e10b3c844a1a8b20b6
4 days ago
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/432#issuecomment-271458895,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzffF_Uerj0IRimDqq8QnyNhWN6unppks5rQtxJgaJpZM4LeyrW
.

--
<EMAIL_ADDRESS>508-274-8700

Hmm.. latest zipped from GitHub gives error with IT:
PRMan: R90011 {SEVERE}  Can't open display image /tmp/renderman_for_blender/objectcolor/images/Scene.0016.it (System Error: Connection refused)

Restarting Blender... tested again:

Yes, finally!! 💯

Got it!
Thanks this clear up a lot of things 💃


Do not see anti ad blocker message but video doesn't play either

Just get black screen now

Same here, Firefox latest, latest plugin too.
Message in the console:

Uncaught (in promise) ReferenceError: can't access lexical declaration 'observer' before initialization
window["__f__low9mr62.wmt"]/</< moz-extension://cd5baa07-2f20-492f-a8ae-545b07cab411/userscripts/Remove-Adblock-Thing.user.js?id=905b4834-de15-4244-aa79-3fee8ac36fbd:78
window["__f__low9mr62.wmt"]/< moz-extension://cd5baa07-2f20-492f-a8ae-545b07cab411/userscripts/Remove-Adblock-Thing.user.js?id=905b4834-de15-4244-aa79-3fee8ac36fbd:217
St https://www.youtube.com/watch?v=YQhY_qQdlxA:9
window["__f__low9mr62.wmt"]/< moz-extension://cd5baa07-2f20-492f-a8ae-545b07cab411/userscripts/Remove-Adblock-Thing.user.js?id=905b4834-de15-4244-aa79-3fee8ac36fbd:1
"__f__low9mr62.wmt" moz-extension://cd5baa07-2f20-492f-a8ae-545b07cab411/userscripts/Remove-Adblock-Thing.user.js?id=905b4834-de15-4244-aa79-3fee8ac36fbd:1
St https://www.youtube.com/watch?v=YQhY_qQdlxA:9
s https://www.youtube.com/watch?v=YQhY_qQdlxA:72
 https://www.youtube.com/watch?v=YQhY_qQdlxA:75
g https://www.youtube.com/watch?v=YQhY_qQdlxA:69
eval:78:21

Hi,

Opera 104.0.4944.54 Win 10
Tampermonkey and ad blocker scipt installed today.

Probably fixed in https://github.com/TheRealJoelmatic/RemoveAdblockThing/pull/145 v2.5 (still waiting for merge).

Common Issues
"Ad Blockers violate Youtube Terms Of Service" OR Just a black screen
This happens when there is an adblock other than the script running. Common ways you may be blocking ads accidentally on Youtube is:

Adblock extension: Disable or whitelist YouTube on your ad blocker extension.

Browser built-in adblock: Some browsers have built-in ad blockers. Disable or configure them.

Other Tampermonkey scripts: Scripts like YouTube enhancer may conflict. Disable them one by one to identify the issue.

Wi-Fi/DNS/Firewall adblock rules: Check network settings for any ad-blocking configurations.

Windows hosts file rules: Inspect the Windows hosts file (C:\Windows\System32\drivers\etc) for ad-blocking rules.


feat(scripts): Add scripts to seed exams

These are some scripts to add exams to the database. These exams are only for local dev and testing, etc.
Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Thanks for taking a look everyone 👍 This should be ready to go again.


Canbus reading from a contactless clip

i was wondering if it is also possible to read canbus data with this shield not connected to the odb2 but with a contactless clip (eg cancrocodile) on the C-H and C-L cable?

I can't tell what the output cable of that cancrocodile product is: could be proprietary and you need to purchase their hardware in order to decode it,
OR
It is straight-up CAN and you would be able to utilize CAN_BUS_Shield to read the messages.
Need more information on the output of the cancrocodile...


[Bug]: Using Chinese to annotate a PDF, but the Chinese characters do not display after opening the downloaded PDF

Attach (recommended) or Link to PDF file
https://mozilla.github.io/pdf.js/web/viewer.html
Web browser and its version
版本 125.0.6422.113（正式版本） (arm64)
Operating system and its version
macOS 14.4.1 (23E224)
PDF.js version
new
Is the bug present in the latest PDF.js version?
Yes
Is a browser extension
No
Steps to reproduce the problem

open https://mozilla.github.io/pdf.js/web/viewer.html
add chinese text

download pdf
open the downloaded PDF

What is the expected behavior?
I want the downloaded PDF file to display all of my annotations, including those in Chinese.
What went wrong?
Link to a viewer
No response
Additional context
This issue might be related to the version of the browser.

Duplicate of #15769

For future reference:

Web browser and its version
版本 125.0.6422.113（正式版本） (arm64)

Please only use English in this bug tracker.

PDF.js version
new

That's not a valid version number.

2. add chinese text

You didn't include the string in question, which makes this issue impossible to reproduce for anyone not speaking Chinese.


Lets have a label-palooza for existing issues

Reach consensus on new label name and meaning for housekeeping/low-hanging fruit type issues

Are good first issue and help wanted already being used for similar purpose

Divy ~200 open entries in tracker to each developer to scan for new label designation and possibly remove other labels

GitHub has specific meanings for these labels...

good first issue: Good issue for a first-time contributor
help wanted: A developer wants help on an issue or PR

and they were created to be consistent across all projects on GitHub.
If we created a new label called, for instance, low-hanging fruit, is it concievable there could be an issue we would indicate is good first issue that would not also be low-hanging fruit? I think the answer is no. Any good first issue would, by definition almost certainly be low-hanging fruit.
However, I don't think the opposite is true because any issue we, seasoned VisIt developers, think is low-hanging fruit has the potential to be more involved for a first-time contributor.
This means that all good first issue issues would also be low-hanging fruit issues but that some low-hanging fruit issues would not also be good first issues.
I propose we add the new low-hanging fruit issue label and then make a pass over the 1600 issues (with 8 of us, there would be 200 issues for each of us to consider), and consider adding either good first issue and low-hanging fruit or just low-hanging fruit labels.

How to split up the current issues? If you go to the open issues at the bottom there are buttons for 65 pages. We can assign each developer a range of pages. So, I could take pages 1-8, someone else could take pages 9-16, etc.

Mark will come up with a partitioning into 8 numeric issue ranges to split up the work.

I've added the low-hanging fruit label.
Over the next week or two, I am asking that each of you find some time to go through your batch of issues in the backlog (see below) and assess each issue there for whether it needs a low-hanging fruit label (should take a cognizant developer <1/2 day) and whether it needs a good first issue label (would be good for newbie contributor) keeping in mind that sometimes both might be appropriate. When you have completed your batch, please return here and check your box.
Here is label-palooza plan

[ ] Mark: pages 1-9, Top - #3367
[ ] Eric: pages 10-18, #3365 - #2836
[ ] Kat: pages 19-27, #2835 - #2330
[ ] Eddie: pages 28-36, #2329 - #1853
[ ] Alister: pages 37-45, #1852 - #1329
[ ] Kevin: pages 46-54, #1328 - #733
[ ] Cyrus: pages 55-63, #730 - #128
[ ] Matt: pages 64-64, #127 - Bottom

So, I missed-counted here and instead assigned 9 pages each to 7 developers and so Matt was the lucky one and got the last couple of pages. I didn't feel like re-adjusting. Hope everyone doesn't mind. When you've finished your piece, please come here and check

I discovered something about checklists in GitHub issues. The progress bar is shown only if the checklist is in the original issue post and not buried in the conversation comments that follow it. As such, I've moved the comment where I had each developer's part to the original post and deleted the comment in the conversation.

Ping @brugger1 @rusu24edward @aowen87 @cyrush @mclarsen ... you can find your assignment of the label-palooza in this issue.
Also, if anyone wants some relief in their assignment, please let me know and I might be able to help.

@mclarsen do you mind now if I swap your assignment here with Cyrus' and give him the less than two pages worth of leftovers from my mis-counting?

My bunch of tickets spans 2014-2015. While reviewing them, I noticed that a lot of them are marked priority yet still open. They may have been a priority when reviewed, but the fact that they haven't been done in 5-6 years seems to me that they are not really a priority. This is likely an issue with many older tickets. Perhaps we should do a label palooza for priority tickets and define what the priority label practically means?

@markcmiller86  since these are being closed as well due to the review, the page numbers for the query aren't really meaning full anymore -- is there a way to query a range of issue #'s that are open? There are many closed in the ranges as well, don't want to have to check the range.
I tried to google and look at the github docs but the answer wasn't apparent quickly. But if someone is already a master of the github query, maybe they know?

is there a way to query a range of issue #'s that are open? There are many closed in the ranges as well, don't want to have to check the range.
I tried to google and look at the github docs but the answer wasn't apparent quickly. But if someone is already a master of the github query, maybe they know?

Oddly, github doesn't seem to provide a way to limit the range by the actual ticket number itself. See here and here. Fortunately, we can be a little creative by searching based on date. Most tickets were created on 02/26/19 during the merge from redmine, but if you're particular about the hours and minutes, you can get pretty close. This should give you your range @cyrush:
is:issue is:open created:2019-02-26T20:57:00+00:00..2019-02-26T22:00:00+00:00

@rusu24edward nice! 👍

thanks @rusu24edward !

I noticed that a lot of them are marked priority yet still open

I am making a pass over most of these, those I can find with
is:issue is:open label:priority created:<=2019-02-27 no:assignee

I am making a pass over most of these, those I can find with

Ok, I finished that and there are still 109 issues with the priority label. And, a few of those do go way back in time. A few are even low-hanging fruit. IMHO...there are a lot of gems in there which I think if addressed would improve VisIt in visible/valued ways.
My suggestion...take some time as a team maybe at an upcoming project meeting or creating an additional meeting for this purpose and review and start assinging.

@brugger1 taking @rusu24edward lead...here is the query that returns your batch of issues...
is:issue is:open created:2019-02-27T01:30:20+00:00..2019-03-28T22:00:00+00:00

@aowen87 this query gets you your batch (more or less)
is:issue is:open created:2019-02-26T23:00:00+00:00..2019-02-26T23:55:20+00:00

Having the bottom issues, I have noticed that they are very old. I think it might be worthwhile to see it we can still duplicate these issues and see if they have magically gone away.

Thanks everyone for your help in resolving this.


Fix sum(Fun(1,CosSpace())) == π

Should be 2π.  The culprit is PiecewiseSpace, but fixing this needs some thought about SumSpace with different domains.

All definite integrals should work: sum(Fun([1],SinSpace())) is also broken.

sum(Fun([1],SinSpace())) is fixed in the feat-revampbivariateops branch, which will hopefully be merged back soon

On 3 Aug 2016, at 1:37 AM, Richard Mikael Slevinsky<EMAIL_ADDRESS>wrote:
All definite integrals should work: sum(Fun([1],SinSpace())) is also broken.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/ApproxFun/ApproxFun.jl/issues/351#issuecomment-236943930, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLDqUlechVDKra-jAVZiRTTlpe0TNbcks5qb2QygaJpZM4JaSm-.

This was fixed...not sure when.


librsvg seems to override other gdk-pixbuf loaders

Describe the bug
When I include librsvg in an configuration, it will replace gdk-pixbufs with one it generates itself.  If I later include webp-pixbuf-loader, these updates to gdk-pixbuf loader path were not seen.
This maybe because librsvg was not rebuilt.
Steps To Reproduce
Steps to reproduce the behavior:

include librsvg in environment.systemPackages
rebuild
add webp-pixbuf-loader to environment.systemPackages
rebuild.

Now looking at /run/current-system/sw/lib/gdk-pixbuf-2.0/2.10.0/

loaders/ contains libpixbufloader-webp.so
loaders.cache points to /nix/store/...-libsvg-.../gdk-pixbuf-2.0/2.10.0/loaders.cache
loaders.cache doesn't contain any reference to webp.

 @GNOME
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 6.2.5, NixOS, 23.05 (Stoat), 23.05.20230313.8e3fad8`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.3`
 - channels(root): `""`
 - channels(barry): `""`
 - nixpkgs: `not found`

This is from a nix flakes rebuild using flake:nixpkgs

It seems /etc/set-environment sets up GDK_PIXBUF_MODULE_FILE to a properly generated  /nix/store/qq618cwqfs0v81lin9l26c0pfccphw49-gdk-pixbuf-loaders.cache.
But gnome-terminal and gnome-console override the environment variable
and use /nix/store/9vn32f9zhg0v5qkxvb09bkznrkdjv6lw-librsvg-2.55.1/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache in their executables.
But if I use foot or xterm I get the proper GDK_PIXBUF_MODULE_FILE setup.
Could librsvg and all the packages that explicitlly do: wrapProgram ... --set GDK_PIXBUF_MODULE_FILE "${librsvg.out}/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache" be fixed.
I don't think what plugins to gdk-pixbuf are available is something that a package should limit.  Even in a pure environment, the selection of paths should be inclusive of all the plugins added to the environment or explicitly an input to any of the packages in that environment.

I reckon changing this https://github.com/NixOS/nixpkgs/blob/a9afcd204122f52cb2d6cbcceb5fbaeeaa4b6411/pkgs/build-support/setup-hooks/wrap-gapps-hook/wrap-gapps-hook.sh#L14 to --set-default might help


make3d_test_files.txt

Hello. I want to evaluate your code on make3d dataset. And the monodepth2 evaluate code used 'make3d_test_files.txt'. Can you share your txt file for easier evaluation?
Thank you!

Hi, I didn't use 'make3d_test_files.txt'. I downloaded the dataset from here.

So your evaluate code didn't have the 'make3d_test_files.txt'? Can you share your evaluate code?

I am already finished the code. Thanks a lot


[fix] disable close item in opendata app and dataset

Coverage remained the same at 55.968% when pulling 557afe1b4fbe740049bde61c44fcefa288214055 on ShinjiTanimoto:permission into 7fb11201e166bb216f6eb477d140f2d6b3a5a3b6 on shirasagi:master.


chore: clean some trivial code

Description

Clean some trivial code
Update examples

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)

Implemented Tasks

[ ] Subtask 1
[ ] Subtask 2
[ ] Subtask 3

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide. (required)
[ ] My change requires a change to the documentation.
[ ] I have updated the tests accordingly. (required for a bug fix or a new feature)
[ ] I have updated the documentation accordingly.
[x] I have reformatted the code using make format. (required)
[x] I have checked the code using make lint. (required)
[x] I have ensured make test pass. (required)

Codecov Report

Merging #214 (8195229) into dev (55b9db1) will increase coverage by 10.97%.
The diff coverage is 94.09%.

:exclamation: Current head 8195229 differs from pull request most recent head e095a38. Consider uploading reports for the commit e095a38 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##              dev     #214       +/-   ##
===========================================
+ Coverage   85.87%   96.84%   +10.97%
===========================================
  Files          85       98       +13
  Lines        4297     4311       +14
===========================================
+ Hits         3690     4175      +485
+ Misses        607      136      -471

Impacted Files
Coverage Δ

omnisafe/algorithms/__init__.py
100.00% <ø> (ø)

omnisafe/utils/math.py
97.14% <ø> (+21.05%)
:arrow_up:

omnisafe/utils/model.py
100.00% <ø> (+18.42%)
:arrow_up:

omnisafe/utils/schedule.py
100.00% <ø> (ø)

omnisafe/utils/exp_grid_tools.py
48.48% <25.00%> (-36.14%)
:arrow_down:

omnisafe/common/statistics_tools.py
94.87% <57.14%> (+4.56%)
:arrow_up:

omnisafe/utils/tools.py
96.12% <84.61%> (+9.56%)
:arrow_up:

omnisafe/utils/command_app.py
84.07% <88.88%> (+18.55%)
:arrow_up:

omnisafe/utils/plotter.py
91.22% <90.00%> (+15.61%)
:arrow_up:

omnisafe/common/pid_lagrange.py
93.33% <90.32%> (+74.28%)
:arrow_up:

... and 49 more

... and 10 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM.


Vertex Naming Convention/Rules

I found that there is no naming convention for creating vertex labels. It's a similar issue as mentioned in #317.
I suggest the following rules:

Label name must begin either with an alphabet or an underscore.
The name can also include numbers after the first character.
No spaces or other special characters except underscore should be allowed.

Thank you for opening this issue!
As with all naming conventions, lets be sure to align ours with other graph databases for consistency.

@susano0 I see you are leaning towards Neo4j's naming rules. But, it seems these rules are already implemented for vertices (and possibly edges).
When I execute the following,
select * from cypher('y', $$ CREATE (n:1first) RETURN n $$) as (a agtype);

I get this error:
ERROR:  syntax error at or near "1"
LINE 1: select * from cypher('y', $$ CREATE (n:1first) RETURN n $$) ...
                                               ^

This example violates Neo4j's 2nd naming rule that Names should not begin with a number. I tried violating other rules as well. AGE was able to prevent all of them.
If AGE can prevent the violations, doesn't it mean naming rules are already implemented?

@rafsun42 No, you can create vertex and edge labels without errors if you don't use a cypher query.  So, it needs to be fixed. Please see the examples below.
SELECT create_vlabel('gcc1','1');
NOTICE:  VLabel "1" has been created

SELECT create_vlabel('gcc1','\n');
NOTICE:  VLabel "\n" has been created

The CREATE (n:1first) is likely due to a grammar rule in the grammar file src/backend/parser/cypher_gram.y. It likely only allows identifiers in that spot.
My question is, does Neo4j complain if you use 1first as a label? They may say that you shouldn't, but still allow you to use it. I would verify that it is explicitly disallowed.

I tried Neo4j aura. It actually throws error if naming rules are not followed. However, if the name is escaped with backtick, no rules apply anymore.
Same principe for database names. But graph names have additional rules. I mention them in #317.

I think that for all names for labels, vertices, and edges, that we need to comply with Neo4j's standards.
Additionally, I think that it is a good idea to be a bit strict with valid names due to potential security issues by allowing escaped or control characters.
So, lets follow Neo4j but disallow escaped characters.


Generate preset file during presets build

-Added logic to generate preset-data file after calling npm build-presets. It's important to take into account that you need to have all presets listed in the package.json and run "npm build-presets" with no arguments for this to generate the file properly.

Added and tested. Closed as successful.


Remove conferences

Removes all code and tables related to Conferences.
It's unused, but must be maintained if we keep it. (E.g., in Rails updates, we'll need, at a minimum, to deal with routes.)  Because of impending update to Rails 5.0, I decided to ditch it. I think cost of maintainance > hypothetical future usefulness.
Also see following email chain:

On Sat, Aug 12, 2017 at 2:14 PM, Joseph Cohen<EMAIL_ADDRESS>wrote:
Nathan:
Could I delete the Conference code (controller, models, tests, views)?

Nathan Wilson to me, Jason Aug 13
I guess. Doesn't seem worth worrying about and some day it might be useful, but I don't really care.
-Nathan

I will let this PR sit until Monday or Tuesday. If there are no objections, I'll merge it into master (and ror-5, which catalyzed this PR).


Improve adding extra trackers and removal of original trackers (every time)

Alternative implementation of https://github.com/elgatito/elementum/pull/36
uses https://libtorrent.org/reference-Torrent_Handle.html#trackers-replace-trackers-add-tracker
applies settings on every start.
better to squash on merge.

closed in favor of #40

closed in favor of #40


Feature: expose API from Headers class to replace all headers / allow strings in constructor

Is your feature request related to a problem? Please describe.
I'm spawning mitmdump from another process. They communicate via gRPC. The parent process implements things like replacements etc. because it will be hooked to a UI.
TLDR: Inside the request event I receive a list of updated header tuples from the parent process and need to replace the full flow.request.headers. There is no super straight forward way because I also need to turn the strings I get from gRPC into bytes.
Describe the solution you'd like
Looking at the current implementation it is somewhat schizophrenic. First all the name/value pairs are type checked, and then the loop does _always_bytes anyway. Either one of them needs to leave. If the type check is removed I can just pass strings to it.
https://github.com/mitmproxy/mitmproxy/blob/2774928319b706d8b6f85919f8811776342986c9/mitmproxy/net/http/headers.py#L80-L88
I mean APIs like insert already accept strings, so maybe it would be most consistent to just allow them in the constructor as well? I don't see a reason not to.
Edit: whoops, I guess there's a different between fields vs headers argument. My Python skills reach its limit right about here.
Describe alternatives you've considered
This is what I'm currently doing, essentially duplicating/copying code from mitmproxy.
# https://github.com/mitmproxy/mitmproxy/blob/2774928319b706d8b6f85919f8811776342986c9/mitmproxy/net/http/headers.py#L15-L16
def _always_bytes(x):
  return strutils.always_bytes(x, "utf-8", "surrogateescape")

if reply.replace_headers:
  flow.request.headers = mitmproxy.net.http.Headers(
    [
      (_always_bytes(header.name), _always_bytes(header.value))
      for header in reply.headers
    ]
  )

reply is the gRPC reply, essentially
message HTTPHeader {
  string name = 1;
  string value = 2;
}

message RequestReply {
  bool replace_headers = 1;
  repeated HTTPHeader headers = 2;
}

Hm... I think the current API is actually fine. If you know that you have strings, you can just call `.encode() on them:
mitmproxy.net.http.Headers([
      (x.name.encode(), x.value.encode())
      for x in reply.headers
])

Also, I'm getting more curious on what you are building. :-)

If you know that you have strings, you can just call `.encode() on them:

Oh, so the always_bytes util is mostly needed to transparently handle strings and bytes? I was copying it just to make sure there are no subtle differences that I wasn't aware of. I guess I should use surrogateescape as well?

Also, I'm getting more curious on what you are building. :-)

I bet :see_no_evil:

Oh, so the always_bytes util is mostly needed to transparently handle strings and bytes? I was copying it just to make sure there are no subtle differences that I wasn't aware of. I guess I should use surrogateescape as well?

Yes. The only subtle difference is surrogateescape. If you know that you have valid UTF-8, you don't need that.

Another mystery solved, thanks!


Clevo Device Implementation

First Clevo Device Implementation. (Requires Aurora to start with Admin Privileges)

Please still don't merge till issues get resolved first. Need assistance with this.
Still doesn't work. Clevo Device is Initialized but Aurora says that no Keyboard was found. (?)

On the other hand Clevo keyboard lights is divided in 3 regions + 1 touchpad (No per key setup is available). Does Aurora support regions instead of per key setups? Any chance to guide me how to do this? Thanks.

Closing this pull request as I have a more updated version for the DEV branch.


Hebrew Translation

New language
hebrew
Additional remarks
I'd be happy to add Hebrew translation

Hi, I added the language. Please follow the link here and select Hebrew as your contribution language
https://app.lokalise.com/public/321419046440c0f2bba414.05634832/

hebrew completed

Brilliant, thanks for the contribution. I have created a pull request to the frontend repo from Lokalise and whenever we drop the next beta, Hebrew should be available


Automatic column summaries of the table component should have a upper row count limit

Describe the bug
I'm using marimo to work on large datasets with 100 million rows, and found the "run cell" button unresponsive sometimes. After some investigation, I found during the unresponsive time, the kernel is busy running the get_column_summaries function, which is issued by the table component in the frontend.
Calculating summaries for 100m rows will take huge amounts of time, and the unresponsive behavior will cause confusions to users. I think marimo should impose a hard limit on column summary feature. Maybe 1 million is a good number?
Or maybe we can try to run the column summary in a background thread. But this will be a huge change I think, and thread safety issue will be hard to deal with.
Environment
{
  "marimo": "0.7.14",
  "OS": "Linux",
  "OS Version": "5.15.0-52-generic",
  "Processor": "x86_64",
  "Python Version": "3.10.12",
  "Binaries": {
    "Browser": "--",
    "Node": "--"
  },
  "Requirements": {
    "click": "8.1.7",
    "importlib-resources": "missing",
    "jedi": "0.19.1",
    "markdown": "3.6",
    "pymdown-extensions": "10.9",
    "pygments": "2.18.0",
    "tomlkit": "0.13.0",
    "uvicorn": "0.30.3",
    "starlette": "0.38.2",
    "websockets": "12.0",
    "typing-extensions": "4.12.2",
    "ruff": "0.5.5"
  }
}

Code to reproduce
No response

Thanks for reporting, @mutongx. I like your suggestion of limiting column summaries to 1m rows or less. If you don't mind, I'd definitely appreciate a PR.

@akshayka Sure! I will take a look at it.

@akshayka Sure! I will take a look at it.

Thank you!


Use InAppMessage dimensions relative to host activity

Implementation of fix in https://github.com/adobe/aepsdk-core-android/pull/618. The description from that pr is:
Description
Problem : Currently, the size of the InAppMessage is based on the screen height and width.  However, this is not always the case when the activity is not occupying the entire screen.
Such cases will see a full screen message within the activity irrespective of the dimensions of the actual content size of
the activity. So 70% height would be 70% screen height and exceed the activity content view height where as it should have been 70% of the height within the activity.
Solution: Use the Use InAppMessage dimensions relative to host activity and not the entire screen.

Related Issue

Motivation and Context
Problem : Currently, the size of the InAppMessage is based on the screen height and width.  However, this is not always the case when the activity is not occupying the entire screen.
Such cases will see a full screen message within the activity irrespective of the dimensions of the actual content size of
the activity. So 70% height would be 70% screen height and exceed the activity content view height where as it should have been 70% of the height within the activity.
Solution: Use the Use InAppMessage dimensions relative to host activity and not the entire screen.

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

I'll share a snapshot once I get the android tests fixed

I'm releasing a snapshot from the dev branch to share with the issue reporter


1970 text field playground

Summary of the changes

Updated state when maxCharacters is set to zero after the validation has been shown, to allow users to enter text in this instance. Previously the text-field would not allow new characters due to the max being zero.
Added child components to mutation observer for ic-text-field and ic-input-component-container, which will force an update if a slotted icon is added as a child, meaning that the icon can now be conditionally rendered

Related issue
#1970
Checklist
General

[x] Changes to docs package checked and committed.
[x] All acceptance criteria reviewed and met.

Testing

[x] Relevant unit tests and visual regression tests added.
[x] Visual testing against Figma component specification completed.

Accessibility

[x] Accessibility Insights FastPass performed.
[x] A11y unit test added and yields no issues.
[x] A11y plug-in on Storybook yields no issues.
[x] Manual screen reader testing performed using NVDA and VoiceOver.
[x] Manual keyboard testing for keyboard controls and logical focus order.
[x] Correct roles used and ARIA attributes used correctly where required.
[x] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

[x] Page can be zoomed to 400% with no loss of content.
[x] Screen magnifier used with no issues.
[x] Text resized to 200% with no loss of content.
[x] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

[x] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
[x] Windows High Contrast mode tested with no loss of content.
[x] System light and dark mode tested with no loss of content.
[x] Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

[x] Min/max content examples tested with no loss of content or overflow.
[x] All prop combinations work without issue.
[x] Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
[x] Controlled and uncontrolled input components tested.

I think some of the auto options are extraneous and could possibly be taken out?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


add wiki for date-react and general usage of date-io

The README is providing documentation for general usage, I'll add a section for react though 👍


crystal: 0.25.1 -> 0.26.0

Motivation for this change
Update to new version so Kemal framework works again.
Also @sifmelcara requested that they're removed from being maintainer, so I included that in this PR.
I'll also push an update for Mint once this PR is merged, as it won't build anymore.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build crystal

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: crystal
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-darwin (full log)
Attempted: crystal
Partial log (click to expand)
clang -fPIC    -c -o src/ext/sigfault.o src/ext/sigfault.c
ar -rcs src/ext/libcrystal.a src/ext/sigfault.o
./bin/crystal build --no-debug --release  -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib
./bin/crystal docs -b https://crystal-lang.org/api/latest src/docs_main.cr
Using compiled compiler at `.build/crystal'
installing
post-installation fixup
gzipping man pages under /nix/store/k80466m3cz03hddxhrrrphyfw9jk667c-crystal-0.26.0/share/man/
patching script interpreter paths in /nix/store/k80466m3cz03hddxhrrrphyfw9jk667c-crystal-0.26.0
/nix/store/k80466m3cz03hddxhrrrphyfw9jk667c-crystal-0.26.0

Success on x86_64-linux (full log)
Attempted: crystal
Partial log (click to expand)
wrong ELF type
shrinking /nix/store/r7i13584f87hb93s3ndd595fygrs9z2z-crystal-0.26.0/lib/crystal/llvm/ext/llvm_ext.o
wrong ELF type
shrinking /nix/store/r7i13584f87hb93s3ndd595fygrs9z2z-crystal-0.26.0/bin/.crystal-wrapped
gzipping man pages under /nix/store/r7i13584f87hb93s3ndd595fygrs9z2z-crystal-0.26.0/share/man/
patching script interpreter paths in /nix/store/r7i13584f87hb93s3ndd595fygrs9z2z-crystal-0.26.0
checking for references to /build in /nix/store/r7i13584f87hb93s3ndd595fygrs9z2z-crystal-0.26.0...
wrong ELF type
wrong ELF type
/nix/store/r7i13584f87hb93s3ndd595fygrs9z2z-crystal-0.26.0


indentation

IMO it looks better. At least it sticks to some rules now.

Gentlemen,
It terms of a code style, you should have an automated process for this matter. As a team, you should agree on defined a set of rules and let your tools to apply them automatically.
Reference:
https://www.jetbrains.com/help/idea/configuring-code-style.html
https://stackoverflow.com/questions/36371820/enable-code-style-in-intellij-idea
Example set:
https://github.com/google/google-java-format
Mentioned automation, sections:

Third-party integrations
IntelliJ
Eclipse

Once defined, you can apply a project-wide code reformat and submit a PR.
Otherwise, you will occasionally run discussions over whitespaces.


ListApiSpecs and ListApiSpecRevisions use inconsistent field naming

ListApiSpecsResponse has the field api_specs for returned specs. ListApiSpecRevisionsResponse has the field specs for returned specs. It seems like other listing responses tend to favor the former style, e.g. ListApiVersionsResponse uses api_versions instead of versions.

The api_ prefixes were required by the linter, so I agree that we should update the protos to match.


Different "profiles" for differnet computers/accounts

I've found that I have to change settings often when I switch from using my PC to my laptop as one feature may be very useful on one but not on the other due to preformance or screen size. I've also found that my loot tracker tracks loot on my RuneLite account and thus doesn't seperate my "loot checker" for my different accounts. could we maybe have some options to setup different profilers that remember your preferences that you can switch between (maybe they could even remember your username in case you want to switch accounts and have a long email)
p.s. If this Feature Request is in any way not compliant with the way your team does feature requests just let me know and I'll fix it, or delete it :D thanks for making such an awesome client

Duplicate of #2220.
See https://github.com/runelite/runelite/wiki/General-Features#playing-with-multiple-accounts for a more manual workaround in the meantime.


Check the value of event.button only if mouseButton is explicitely sp…

…ecified
Fixes https://github.com/firefox-devtools/profiler/issues/3453

@mstange can you please double-check this works for you locally ?
Using yarn link in this repository, and yarn link react-contextmenu in the profiler's repository, and then testing ctrl+click on Mac?

@mstange can you please double-check this works for you locally ?
Using yarn link in this repository, and yarn link react-contextmenu in the profiler's repository, and then testing ctrl+click on Mac?

I tried this but yarn start then prints Module not found: Error: Can't resolve 'react-contextmenu' in '/Users/mstange/code/perf.html/src/components/shared'

The problem was that I hadn't run yarn && yarn build in the react-contextmenu directory.

Even with this change, the call tree context menu doesn't display with ctrl+click in the profiler, but that has a different reason - we don't set the right clicked node in response to ctrl+clicks, so CallNodeContextMenu doesn't render a ContextMenu.

This works but I'm not sure if it's the best API. Specifically, combining a contextmenu listener with a button check seems like something that should be avoided at the API level. I think the user should need to make the choice between: 1. contextmenu event (no check), 2. mousedown event with optional button check, or 3. click event with optional button check.

Yes, I find it also a bit weird that we listen to both the click and contextmenu events. I think you're right. But I also don't want to do too much changes to this lib :-)


fix: branching and forking sometimes break conversation structure

Summary
As reported in #4761 and #3813, conversations will seemingly randomly collapse when regenerating or forking. I believe this is because in buildTree.ts, the function assumes messages are in the correct order when building the tree (parents are before their children). But for some reason, this is only the case when there are less than 17 messages in the conversation.
If the messages are not in correct order, when looking for a message's parent in messageMap, the parent might not have put into the map yet resulting in the current message becoming a root message.
What I've done is to populate messageMap first in one loop, and then in another loop look for a message's parent. This way, the parent should be found wherever it is in the message list.
I don't know if messages should be in the correct order when queried from the api given the previous assumption in buildTree.ts but this change should resolve the issue anyway.
Change Type

[x] Bug fix (non-breaking change which fixes an issue)

Testing
npm run test:client is passing.
I have not introduced any changes to the api.
I've tested my changes with a conversation described in https://github.com/danny-avila/LibreChat/issues/4761#issuecomment-2493085783
Before the change: conversatios with more than 16 messages will collapse after forking. Conversations with more than 16 messages and include any branching will collapse.
After the changes: all is good.
Checklist
Please delete any irrelevant options.

[x] My code adheres to this project's style guidelines
[x] I have performed a self-review of my own code

The first commit worked but somehow it lags the ui when send any message after a while. The second commit fixed the lag problem but it will change the order of branches.
forking with option "include related branches" is totally broken when there are more than 16 messages. What's this magic number 16? 😂
Might be better to just fix api/server/utils/import/fork.js @danny-avila

hey @xyqyear thanks for investigating this, it has eluded me for some time. In general, we can never trust the order of arrays/lists unless we explicitly sort at some step. Maybe a sorting algo is in order server-side?

The thing is, when the total number of messages in a conversation is less than 16, all forking and branching funtionality works fine. But when it exceeds 16, all sort of bad things happen. From what I've observed, the direct cause in the frontend is messages are not in order in buildTree.
Hopefully the consistent reproduction steps help with resolving this issue. I will keep investigating as well.


MCH: No Full Metal Field Use On AOE

Like the title says no FMF use on AOE rotation. Could be similar to the problem that was no excavator on ST.
Keep up the good work and buy a beer or a drink with those Kofi's I got you. You deserve it.
-Mirai

I ordered a pizza, is this still happening?

Just ran an expert. Still happening.

Fixed


Can I directly create the required Global Progress Clocks

Looking at the ClockDatabase.addClock method, it looks like it should be entirely possible to do so, as long as I wait until after the GPC module is initialised. That's why I should do this from the setup hook instead of init.

This issue is resolved in the alpha branch


update ug

Codecov Report

Merging #103 (d719a02) into master (9e804f0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #103   +/-   ##
=========================================
  Coverage     68.76%   68.76%
  Complexity      427      427
=========================================
  Files            76       76
  Lines          1351     1351
  Branches        133      133
=========================================
  Hits            929      929
  Misses          385      385
  Partials         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e804f0...d719a02. Read the comment docs.


Disabled components should display disabled labels

Note that "disabled" attribute doesn't work on  so it needs
class.
Bug: T268842

I'm the laziest person you can imagine, trust me I'd make a smaller patch if I could :P


Additional Endpoints

Hey, I work on the rust wrapper for the helldivers api, in the spirit of cooperation there are two endpoints i dont think you use yet
https://api.live.prod.thehelldiversgame.com/api/NewsFeed/[war_id]
[{"id":2797,"published":2414563,"type":0,"tagIds":[]},{"id":2798,"published":2499000,"type":0,"tagIds":[]},{"id":2799,"published":2507100,"type":0,"tagIds":[]},{"id":2800,"published":2531100,"type":0,"tagIds":[]},{"id":2801,"published":2598240,"type":0,"tagIds":[]},{"id":2802,"published":2705219,"type":0,"tagIds":[]},{"id":2803,"published":2705235,"type":0,"tagIds":[]},{"id":2804,"published":2822793,"type":0,"tagIds":[]},{"id":2805,"published":2899259,"type":0,"tagIds":[]},{"id":2806,"published":2899330,"type":0,"tagIds":[]}]

and
https://api.live.prod.thehelldiversgame.com/api/WarSeason/[war_id]/WarTime
{"time":3120460}

Thanks for the heads up!
What purpose does the WarTime serve compared to the timestamp returned in the war status?
I actually added support for the newsfeed yesterday after someone in the Discord notified me of it

To be candid, I have no idea for a use outside of the game for WarTime - especially seeing as Status is pretty painless.
I only support it because 1-it exists, and 2- someone out there might want it

fair enough, appreciate the heads up!
Feel free to let me know if you find any more endpoints, or head on over to https://discord.gg/y48gx4fB and share it there


Question related to Bypass/Global bits in ATS_TRANS_RESP

Our verification guys noticed a difference between the refence model and the model they developed based on SPEC:
        // only use Untranslated requests to access the implied 4 KiB memory range
        ...
        rsp_msg->trsp.Global = vs_pte.G;
        ...

ATS response uses VS PTE.G which doesn't reflect to the statements of the DTI specification of 5.2.2 DTI_ATS_TRANS_RESP.
Bypass
In the new revision of the DTI specification (edition 3, issue E.b), there is no Global bit defined, but defined Bypass bit:
BYPASS, bit [17]
This field indicates that translation for this StreamID is bypassed.
0 Normal translation
1 Translation bypassed
When the value of this field is 1, the VA and the PA of the translation are the same. This bit must be 0 if the value of IA in the translation request is greater than the range shown in the OAS field of the DTI_ATS_CONDIS_ACK message that was received during the connection sequence.
Global
In the old DTI version (edition 3, early release), it forces setting Global to 1 when Bypass is 1 and SSV is 1.
Global, bit[72]
This bit indicates whether this translation appplies to all SubstreamIDs
0 - Non-global.
1 - Global.
When the value of the SSV bit in the requesting DTI_ATS_TRANS_REQ message is 0, this bit is reserved, SBZ.
When the value of the SSV bit in the requesting DTI_ATS_TRANS_REQ message is 1, and the value of BYPASS is 1, this bit must be 1.
Now we are wiring these bits to 0s both in our design and the verification model which matches the behavior of our PCIe IPs.
Is this a compatibility issue in the reference model?

Mapping to protocols such as DTI should follow the rules provided by those specifications. The IOMMU specification follows the PCIe specification and any such mapping to DTI/LTI or other implementations is implementation defined.

Sorry, my mistake.
This is the one from the recent DTI specification:

The previous picture you posted is for DTI TBU. As noted above, the mapping to implementation specific buses like DTI is implementation specific.

From PCIe 5.0, there is no Bypass field in CPL:
And can see Global bit in Table 10-3:
Global Mapping - If this bit is Set, the ATC is permitted to cache this mapping entry in all PASIDs. If Clear, the ATC is
permitted to cache this mapping entry only in the PASID associated with the requesting PASID. This bit may only be Set
if the associated Translation Request had a PASID TLP Prefix.

From PCIe 5.0, there is no Bypass field in CPL:

Bypass is a DTI concept and as you noted not a PCIe concept.

According to our PCIe guys, PCIe IPs containing "Global" bit follow DTI 2.0 and early DTI 3.0 spec.

Please check if you see any reference to DTI in PCIe specification.

The previous picture you posted is for DTI TBU. As noted above, the mapping to implementation specific buses like DTI is implementation specific.

Shall the implementation dependency be mentione for this paragraph?
2.6. PCIe ATS translation request handling
• Global field is set to the value determined from the first-stage page tables if translation could be successfully completed and the request had a PASID present. In all other cases, including MSI address translations, this field is set to 0.

Please check if you see any reference to DTI in PCIe specification.

There is no reference of DTI can be found in PCIe spec, just can see reference of DTI in the IP data book.

Such an IP using DTI always receives Global as 0.  It is equivalent to such an IP ignoring the Global bit - which is allowed by PCIe - this only results in multiple translations being requested for the same Untranslated Address under different PASIDs - see <IP_ADDRESS>.

Such an IP using DTI always receives Global as 0. It is equivalent to such an IP ignoring the Global bit - which is allowed by PCIe - this only results in multiple translations being requested for the same Untranslated Address under different PASIDs - see <IP_ADDRESS>.

Is that means if an implementation doesn't support ATS.INVAL G field, it can choose to respond G=0 to ATS translation request?

Firstly, I would like to request you to not reproduce information from the PCIe specification that is licensed to you in this GitHub. If you need to refer to a section then providing a section number is sufficient. Would want to avoid any copyright, compliance, antitrust, etc. issues. An implementation that always responds to endpoint with the G bit set to 0 may not run into issues.

Firstly, I would like to request you to not reproduce information from the PCIe specification that is licensed to you in this GitHub. If you need to refer to a section then providing a section number is sufficient. Would want to avoid any copyright, compliance, antitrust, etc. issues. An implementation that always responds to endpoint with the G bit set to 0 may not run into issues.

Sure, just sorted all of them out. Thanks for the reminds.

The previous picture you posted is for DTI TBU. As noted above, the mapping to implementation specific buses like DTI is implementation specific.

My question is still about the specification/reference model clarification.
From the RISCV IOMMU specification, we cannot infer ATS handler are allowed to respond G=0, while PCIe spec permits.

The PCIe specification permits ignoring the response from the IOMMU. The RISC-V IOMMU specification is compliant with the PCIe specification and no further note is required.

OK, thanks, marking it closed.

One more thing I'd like to mention is:
For an implementation that is based on DTI. "Bypass" is a necessary field for ATS response, it combines with "Range" field. Upon accepting such an translation response, the DMA master side (e.x., PCIe RC) DTI bridge is responsible for generating "output address" using "input address" and "range", "bypass" fields, with lower bits indicated by "bypass/range" coming from the "input address" in translation request and higher bits coming from "output address" in translation response.
As such, "Bypass" is also used in ATS translations.
However, the current reference model seems like a TLP base model, cares less about DTI ATS interfacing.
Probably should move all of those ATS bridge side stuffs to implementation specific or test bench specific, and not be a part of IOMMU model.

One more thing I'd like to mention is:
For an implementation that is based on DTI. "Bypass" is a necessary field for ATS response, it combines with "Range" field. Upon accepting such an translation response, the DMA master side (e.x., PCIe RC) DTI bridge is responsible for generating "output address" using "input address" and "range", "bypass" fields, with lower bits indicated by "bypass/range" coming from the "input address" in translation request and higher bits coming from "output address" in translation response.
As such, "Bypass" is also used in ATS translations.
However, the current reference model seems like a TLP base model, cares less about DTI ATS interfacing.
Probably should move all of those ATS bridge side stuffs to implementation specific or test bench specific, and not be a part of IOMMU model.


Fix problems with install-src/doc/examples

This PR is doing a lot of work, and I understand if you would like me to split it into smaller parts:

Add the commands list-src, list-doc, and list-example, to print modules and archives for source, docs, and examples
Deprecate the target parameter for install-src/doc/example
Remove the --modules parameter from install-src
Update the error messages that ask the user to use list-qt to show valid options, so that they print the correct list-src/doc/example command. (not implemented yet) implemented in cfc2410

Fix #453

I am confused about what happened in this build: https://dev.azure.com/miurahr/github/_build/results?buildId=4747&view=logs&j=a846d25a-e32c-5640-1b53-e815fab94407&t=777e4b2c-7cad-5027-3b62-2efbb20eb961
This is a failure that I have never seen before. It occurs during installation of Pscx, in this code:
https://github.com/miurahr/aqtinstall/blob/60018b3bf643b8bd2901bd2102c9bf1e53ed888b/ci/steps.yml#L163-L167
This build passed when it ran in the previous commit, and the code in this commit is completely unrelated to the build step that failed.
I would speculate that this failed due to a backpressure mechanism at the NuGet server. I would like to re-run the build and see if it is still broken, but I'm not sure how to do that.

LTGM.


Delete nonreduced inputs

To avoid CI timeouts on the large input set.
Last one: https://github.com/bitcoin-core/qa-assets/pull/90

Can be "reproduced" with:
apt update && apt install wget -y
wget https://raw.githubusercontent.com/bitcoin-core/bitcoin-maintainer-tools/main/delete_nonreduced_fuzz_inputs.sh
bash delete_nonreduced_fuzz_inputs.sh

Did the deletion on Jammy and Focal:

147k files removed on Jammy, 184k on Focal
approx 64k files difference between both final sets

Measuring with /usr/bin/time --format 'user: %U (s:%S w:%e)' ./test/fuzz/test_runner.py -l DEBUG --par=$(nproc) ../qa-assets/fuzz_seed_corpus/ gives a mild speedup, as expected

Actually, this deleted the wallet folders due to missing the sqlite dependency

Restored them in ca05b5e921f40042b24443ef016dc190c94e217c


Azure IoT Edge Runtime - Ubuntu 20.04 package

https://github.com/microsoft/edge-video-services/blob/main/common/install_iotedge_runtime.md#install-the-azure-iot-edge-runtime
How can I get the prod.list for Ubuntu 20.04 ? The link https://packages.microsoft.com/config/ubuntu/20.04/multiarch/prod.list is not found.
TIA!

Can be found at https://packages.microsoft.com/config/ubuntu/20.04/prod.list .


Pipeline/linear feature extractor

Adding example simple linear model as a placeholder for future extractor, just to create tensor output of given size out of simulated random tensor input.

sorry za PR do maina!


Please add NSIS Language (.nsi) support [enhancement]

What is NSIS?  Is it: http://nsis.sourceforge.net/Creating_language_files_and_integrating_with_MUI
For this to work we would need a compatible beautifier.  We need either a NSIS beautifier or a beautifier from another language that is similar enough to extend support to NSIS.


Strange capitalization of each word in sitename since Wagtail 6.3

Issue Summary
Strange capitalization of each word in sitename since Wagtail 6.3
Steps to Reproduce

Have a Wagtail 6.3 site
Have the sitename set to "example.com"
The admin now reads "Example.Com", it never used to

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Technical details

Python version: 3.12
Django version: 4.2 LTS
Wagtail version: 6.3
Browser version: Chrome 131

Working on this
It appears that the capitilization is done with a Django template tag rather than with CSS as I have inspected the generated HTML.
Anyone can contribute to this. View our contributing guidelines, add a comment to the issue once you’re ready to start.

My personal thoughts on this is that I don't think the Wagtail admin should be getting itself involved in changing the case of the title provided by the site owner. Perhaps maybe the first letter of the site name but that is it.
Every word is going to make some site names look a bit silly.
Especially when you get Mysite.Co.Nz it just looks so weird.

Hi, I am new to opensource contribution and I would like to work on this issue.

Hi, I am new to opensource contribution and I would like to work on this issue.

Issues needs approval from the authors first before working on something, I'm pretty sure.
Anyway. I can go back to Wagtail 6.2.x briefly and double check what I said was accurate.
In Wagtail 6.3 is the first version I noticed the strange capitilization if the wagtail site name is a domain, and I would imagine it's just a Django template filter in one or more template(s) doing this capitilization of each word.

Thank you @robvdl, I can confirm we added this by mistake in v6.3. I remember us trying it out but it wasn’t meant to ship like this, sorry about that. It’s |title here that needs removing: https://github.com/wagtail/wagtail/blob/cd8c19d762a8f75b0dce11a31b125305c63c2775/wagtail/admin/templates/wagtailadmin/home.html#L11C50-L11C55
That line should be:
 {% block branding_welcome %}{{ site_name }}{% endblock %}

@Abbas-Askari please take a look and go for it if you want to!

Thanks <3

@Abbas-Askari please take a look and go for it if you want to!

I accidently created a faulty PR and closed it. Anyway I fixed it as:
{% block branding_welcome %}
    {% if '.' not in site_name %}
        {{ site_name|title }}
    {% else %}
        {{ site_name }}
    {% endif %}
{% endblock %}


Add connection timeout to jruby socket connect

This just adds a Timeout.timeout block around the jruby specific socket connect.   Without this jruby connects can  hang for whatever the socket level connect timeout is, which is quite long.

Thanks, "invalid-email-address".  :-) git config issue?

ya I'm fixing that:)


[shapes] DrawPoly() drawing behind QUADS

Hi nice people, I have a problem.
I print a texture as a background, and then I try to print a polygon.
But the polygon is printed under the texture.
Is it a bug?
BeginDrawing();
ClearBackground({ 0,0,0,0 });
DrawTexture(BACKGROUND, 0, 0, WHITE);
DrawPoly({ GetMouseX(), GetMouseY() }, 4, 80, 0, { 255,0,0,255 });
EndDrawing();

Corrected with commit https://github.com/raysan5/raylib/commit/8d81b6e4e40ea8ad01acea8bfbda38840eb7027f


adding import and export policies

Addresses #7
Please review but don't merge yet. I don't have automated testing setup yet, and so haven't been able to execute all tests. This PR should be treated as preliminary at this point, and I'd appreciate your review/feedback.
Thanks

Thank you @pspdbx for your work!  Unfortunately, I have another vision of routing policies. I think routing policies should be a dedicated object.
I made it in develop branch and I am going to release it  soon.

Thats great! Looking forward to it.


Error when target is arbitrary number, higher than index

This comparison, checking for valid matrix targets, throws an error when the Provider uses a non-sequential numbering sequence.
Assignees:
Labels:
https://github.com/dufourgilles/node-emberplus/blob/53646255b7e6d7bc68e975148af4a8d703cbcb86/EmberLib/Matrix.js#L367

ACK.
Created a new issue.
https://github.com/dufourgilles/node-emberplus/issues/19 https://github.com/dufourgilles/node-emberplus/issues/19
A fix will come shortly.
Gilles.

On 7 Jul 2022, at 00:07, Harm Wellink @.***> wrote:
This comparison, checking for valid matrix targets, throws an error when the Provider uses a non-sequential numbering sequence.
Assignees:
Labels:
https://github.com/dufourgilles/node-emberplus/blob/53646255b7e6d7bc68e975148af4a8d703cbcb86/EmberLib/Matrix.js#L367 https://github.com/dufourgilles/node-emberplus/blob/53646255b7e6d7bc68e975148af4a8d703cbcb86/EmberLib/Matrix.js#L367
—
Reply to this email directly, view it on GitHub https://github.com/evs-broadcast/node-emberplus/issues/42, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3DH2YZFYZTQVSI3SFWZLDVSX7SNANCNFSM523JK4DQ.
You are receiving this because you are subscribed to this thread.

Fix in 2.5.11


Fix generic client

I think we also need fixes for the calls to NewGenericClient in the template code: https://github.com/solo-io/skv2/pull/364/files


Add description for crds

https://github.com/open-cluster-management/backlog/issues/3052#issuecomment-652508330

/assign deads2k
/assign pmorie

/lgtm
/approve


feat: add missing authorized and test call methods

Adds aurora-engine contract methods that are missing from the workspace. This PR only deals with the public view methods, others will be added separately.
The methods have already been defined in the TestCallFunction enum here and the AuthorizedCall enum here, which currently have variants that are never used in the code.
Added methods

mint_account
verify_log_entry
resume_precompiles

Note
Please make sure that all the method input/output arguments match those on the engine contract. I tried my best to match them but I'm still lacking some familiarity to be absolutely sure of the changes.
Other changes
Local mocked test cases for these methods have been added.

@0x3bfc Could you elaborate please?

@0x3bfc Could you elaborate please?

It was fixed in the previous comments some functions were returning the right types similar to the engine implementation.


Client synchronizer messages patch

This pull request contains changes to the client synchronizer messages.

I'll merge it for now.

I'll merge it for now.


Wrong key code?

Lime and Openfl both return<PHONE_NUMBER> for cpp/windows while other os/target combinations return 144.
This might be related: http://wiki.libsdl.org/SDLKeycodeLookup
I think Openfl uses SDL to get the keycode wich uses numbers over<PHONE_NUMBER> for keys without character representations.
Openfl is a implemention of the flash api so it should probably return keycodes similar to how flash does it .
Causes a crash in HaxePunk: https://github.com/HaxePunk/HaxePunk/pull/243

This is still an issue as of the most recent git version of lime. Function keys are mapped incorrectly, e.g. F4 sends the keycode for "S".
Full list of incorrect keycodes here: https://github.com/openfl/openfl-native/issues/193
I don't know why https://github.com/openfl/openfl-native/pull/199 was closed, it claims to fix this? (cc @jgranick)

There is still more work that could be done on consistency, but I just tested a simple onKeyDown handler in Lime, and yes, it does return high values for F1-F12, but this matches the same values in the lime.ui.KeyCode enum, so trace (keyCode == KeyCode.F1) is true.
Similarly, OpenFL appears to be handling things based on the Lime KeyCode enum, so it maps Lime F1 keys to Flash/OpenFL F1 key codes.
I'm going to mark this as "fixed" again based on what I'm finding. Please feel free to let me know if you encounter a case where it is wrong, and which path (legacy or Lime 2) it is on, etc.
Thank you!


Config option to open link in new window?

Love the idea of this plugin, thanks for creating it!
I can see a very specific use of this plugin within Grav Skeletons to help newer users access specific external docs, etc. Having the option to set a link to open in a new Browser Window would be awesome, as this then leaves them in the Grav Admin while they can review the related docs.
Thanks very much,
Paul

FYI GitSync has been released to support the new Admin Tray, you can now sync from anywhere in the admin :)

Really nice @w00fz , just updated and gave it a go👍

Agree cool be nice to add target:_blank to link.

added 4 pull request for the developers to get this top work. Only the admin plugin should have a change to. See pull request 1 from me.

Hi @rhukster , I see there are a series of small PR's to add the ability to open Quick Links URLs in a new Browser window... any chance they might be accepted/released?🤞It would be a great enhancement!

You can set a link as external: true and it will open in a new tab
Sorry for the extremely late reply :)


Including images in exercises

As far as I can tell, there is no way of including our own static content (e.g. images) when deploying the server. We would like to include some example images in one of our exercise descriptions.

Fixed by #156
Please look at the description of this PR for documentation. (A proper documentation will arrive soon.)

Documentation still needed.


Extend the oob ruleset to provide a URL shortener

This should satisfy the requirements in section 9.5.6 of the DIDComm V2 specification.
As part of this, the "Call to action" section of the human readable instructions should suggest both the longer and shorter URIs and the QR Code associated with each of those.
Consider also this suggestion, "A sender may want to wait to generate the full invitation until the redirection event of the shortened URL to the full length form dynamic, so a single QR code can be used for distinct messages." This might be one way to address issue #643 in the pico-engine repo.

With the correction to fix the actual redirection from a shortcut to the full invitation URL, this issue is completed.


List deleted items not working

It is currently not possible to supply the required OData cast type for the directory/deletedItems
https://docs.microsoft.com/en-us/graph/api/directory-deleteditems-list?view=graph-rest-1.0&tabs=http#http-request
How do you want to implement this ? As 4 differents endpoints ? With a new method to specify the Odata cast type ? Allow the user to modify the inner url directly ?

Hmm, good question. This might be worth looking at adding some custom requests with its own request api directory that is not part of code generation for these. This would be similar to how extended_properties is currently done. It could be called deleted_items and I believe there are some other parts of the graph API that cover deleted items in other ways as well so that is something to look into.

If those specific odata cast types are used in other API requests then its probably better to add them as methods where the current OData types can be set: https://github.com/sreeise/graph-rs/blob/20ed58450ab1161793365df3271cfc4802fde5b1/graph-http/src/intoresponse.rs#L51-L113

There is at least the https://graph.microsoft.com/v1.0/directoryObjects endpoint that is not usable without the same cast types ("microsoft.graph.user", etc).
And it seems that the OData cast type is usable for a lot of other requests : https://docs.microsoft.com/en-us/search/?terms=OData cast type&scope=graph&products=%2Fdevrel%2F5fc61396-d075-4560-aece-fdbda73d243f


Fix tests to match SF pre-release

Platform changed its error format and the conditions under which it throws exceptions. This updates our tests to match.

@prescod what was the platform change?

@prescod what was the platform change?

The syntax of the error message for collection insert of a field that doesn't exist changed.

Doing a collection update on a field that doesn't exist seems not to give any error at all anymore.

The second one seems a bit fishy but SFDO hardly uses these APIs and I was not feeling altruistic enough to verify the details, make a minimally reproducible test-case in a Salesforce-standard language and make a bug report. Hopefully someone who actually uses and cares about the API regularly will get to it. In any case, it is only turning an exception into a silent ignore which perhaps is a purposeful change and would seldom be a harmful change.

@prescod here's the relevant release note: https://releasenotes.docs.salesforce.com/en-us/winter21/release-notes/rn_api_rest.htm#rn_api_rest

@prescod here's the relevant release note: https://releasenotes.docs.salesforce.com/en-us/winter21/release-notes/rn_api_rest.htm#rn_api_rest

I wonder why that i


istio ServiceEntry missing

Expected Behavior

knative/pkg/api/istio does not implement ServiceEntry which is part of apis/networking.istio.io/v1alpha3
Please implement it.

Actual Behavior

None: It is missing

Steps to Reproduce the Problem
Additional Info
See networking.istio.io/v1alpha3 for the full list.

/close
This is obsolete, we moved to using istio/client-go.


Terminal "Error: Not implemented" on web

Issue Type: Bug

Be on latest master
Compile and mixin-server
yarn run web

Open the terminal in the browser, terminal is blank and this error is in the dev console:
ERR Not implemented: Error: Not implemented
	at WorkerExtHostTerminalService.$getDefaultShellAndArgs (http://localhost:8080/static/out/vs/workbench/api/common/extHostTerminalService.js:585:19)
	at RPCProtocol._doInvokeHandler (http://localhost:8080/static/out/vs/workbench/services/extensions/common/rpcProtocol.js:336:31)
	at RPCProtocol._invokeHandler (http://localhost:8080/static/out/vs/workbench/services/extensions/common/rpcProtocol.js:321:49)
	at RPCProtocol._receiveRequest (http://localhost:8080/static/out/vs/workbench/services/extensions/common/rpcProtocol.js:248:36)
	at RPCProtocol._receiveOneMessage (http://localhost:8080/static/out/vs/workbench/services/extensions/common/rpcProtocol.js:176:30)
	at http://localhost:8080/static/out/vs/workbench/services/extensions/common/rpcProtocol.js:66:56
	at Emitter.fire (http://localhost:8080/static/out/vs/base/common/event.js:457:42)
	at http://localhost:8080/static/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:44:25

VS Code version: Code - Insiders 1.46.0-insider (595d2b9b916d063aadfc2c1a8c8f6df5b45572a8, 2020-06-03T05:38:33.098Z)
OS version: Darwin x64 18.7.0

It's not clear to me what should happen here. I could do a basic fake local echo shell such that people can test some things? @bpasero thoughts?

@Tyriar yes it would be great if the terminal can be played with from yarn web even if just fake 👍

I'm going to hold off on this one as supporting terminals in yarn web doesn't provide much use, even for dev/test as most things won't work properly if there isn't a process backing it. Will look into this later on but it will probably be a message saying the terminal isn't supported.

This may still throw as the terminal request still goes out, but there is welcome support now as opposed to a broken terminal panel.


[READY] added total hours to report

reworked form mileages and hours, also added collection class @jurre (thanks for the suggestion). I ran into a problem with the mileages/hours and didn't know which option was better. Since there are 2 totals now i had a few options:

two of each method, one for hours one for mileages in the collection class (chose this)
two seperate classes, 1 for hours 1 for mileages
3 methods with a string parameter to determine total hours or mileages

Maybe there is another way i don't know of yet.


How to control number of cores?

I apologize for opening an issue that isn't a real bug.
I need to control the number of cores used when I fit a model.
I've tried the following things:
(1)
from numba import set_num_threads
set_num_threads(1)

(2)
from numba import config
config.NUMBA_NUM_THREADS = 1

(3) Going through the source code and replacing every instance of @njit with @njit(parallel=False).
No matter what I try, I see my core usage shoot up to 128.
I'm on a cluster of machines connected by slow interconnect, so this core usage actually makes the model run very slow.
Does anybody understand how to control this?

Hello @s-banach ,
Thanks a lot for interest! As a dirty trick I always add
export MKL_NUM_THREADS=1 export NUMEXPR_NUM_THREADS=1 export OMP_NUM_THREADS=1
in my .bashrc file. Is this fixing your problem?

Thanks for the answer!
For my own use, I googled "OMP_NUM_THREADS" and found this post: https://stackoverflow.com/a/53224849
It basically says "you can configure the number of cores before importing numpy, after that you can't do anything".
I would like to run a linear model inside a package I'm writing, and be able to control the number of cores used regardless of what else the user has imported or how they have configured their environment.
I don't suppose there's any way I can do  that, other than telling the end user "Configure your environment variables correctly before you run the package." :(

I just discovered threadpoolctl, so that should help somewhat. 😄


Add axes support to Dropout for variational dropout in NLP

add axes support to dropout for variational dropout  in NLP

test pending
MKL part hasn't been updated

@szha Could you test this implementation? ping @yzhliu for MKL implementation
Description
(Brief description on what this PR is about)
Checklist
Essentials

[x] Passed code style checking (make lint)
[x] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

If MKL doesn't support the non-default axis behavior, it should skip using MKL for non-default axes similarly to how batch norm doesn't use MKL of CUDNN for non-default channel axis.

@szha The performance of dropout should be the same as before, when no axes are given.

If you have a request for changes from a committer, you can't merge per Apache guidelines.

What is the performance impact of these changes for default axes behavior compared ot the older code?

Hang suggested that if axes is empty, the behavior is exactly the same as before the change https://github.com/apache/incubator-mxnet/pull/9931/files#diff-4aea2cc24c0bb4e8e48face9faf4aa26R252

Did the guideline explain how committers deal with stale reviews?

Apache say:
"A code-modification proposal may be stopped dead in its tracks by a -1 vote by a qualified voter. This constitutes a veto, and it cannot be overruled nor overridden by anyone. Vetos stand until and unless withdrawn by their casters."
I am guessing for a "stale" review (stale I would imagine > 2 months old?), a death certificate of said committer would be useful.

Haha OK. Jokes aside, did Hang sufficiently address your concern?

Yeah, I'm good.

Sorry to be a bit late here, but this PR has no test coverage. Could you please elaborate @yzhliu ?

@zhanghang1989 is working on it

I am creating another PR for unit test.

Next time please make sure to have code changes and tests within the same PR instead of splitting them.

@yzhliu @zhanghang1989
Please make sure we don't merge code without test coverage next time.

👍 Got it. My bad.


[2.0.0] Build breaks because of missing #include <omp.h>

FAILED: src/CMakeFiles/objxgboost.dir/common/threading_utils.cc.o
/usr/local/libexec/ccache/c++ -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_BUILTIN_PREFETCH_PRESENT=1 -DXGBOOST_MM_PREFETCH_PRESENT=1 -D_MWAITXINTRIN_H_INCLUDED -I/usr/ports/misc/xgboost/work/xgboost-2.0.0/include -I/usr/ports/misc/xgboost/work/xgboost-2.0.0/dmlc-core/include -I/usr/ports/misc/xgboost/work/xgboost-2.0.0/rabit/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -DNDEBUG -std=gnu++17 -fPIC -funroll-loops -pthread -MD -MT src/CMakeFiles/objxgboost.dir/common/threading_utils.cc.o -MF src/CMakeFiles/objxgboost.dir/common/threading_utils.cc.o.d -o src/CMakeFiles/objxgboost.dir/common/threading_utils.cc.o -c /usr/ports/misc/xgboost/work/xgboost-2.0.0/src/common/threading_utils.cc
/usr/ports/misc/xgboost/work/xgboost-2.0.0/src/common/threading_utils.cc:45:7: error: use of undeclared identifier 'omp_in_parallel'
  if (omp_in_parallel()) {
      ^
1 error generated.
[ 93% 84/86] /usr/local/libexec/ccache/c++ -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_BUILTIN_PREFETCH_PRESENT=1 -DXGBOOST_MM_PREFETCH_PRESENT=1 -D_MWAITXINTRIN_H_INCLUDED -I/usr/ports/misc/xgboost/work/xgboost-2.0.0/include -I/usr/ports/misc/xgboost/work/xgboost-2.0.0/dmlc-core/include -I/usr/ports/misc/xgboost/work/xgboost-2.0.0/rabit/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -DNDEBUG -std=gnu++17 -fPIC -funroll-loops -pthread -MD -MT src/CMakeFiles/objxgboost.dir/common/stats.cc.o -MF src/CMakeFiles/objxgboost.dir/common/stats.cc.o.d -o src/CMakeFiles/objxgboost.dir/common/stats.cc.o -c /usr/ports/misc/xgboost/work/xgboost-2.0.0/src/common/stats.cc
FAILED: src/CMakeFiles/objxgboost.dir/common/stats.cc.o
/usr/local/libexec/ccache/c++ -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_BUILTIN_PREFETCH_PRESENT=1 -DXGBOOST_MM_PREFETCH_PRESENT=1 -D_MWAITXINTRIN_H_INCLUDED -I/usr/ports/misc/xgboost/work/xgboost-2.0.0/include -I/usr/ports/misc/xgboost/work/xgboost-2.0.0/dmlc-core/include -I/usr/ports/misc/xgboost/work/xgboost-2.0.0/rabit/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -DNDEBUG -std=gnu++17 -fPIC -funroll-loops -pthread -MD -MT src/CMakeFiles/objxgboost.dir/common/stats.cc.o -MF src/CMakeFiles/objxgboost.dir/common/stats.cc.o.d -o src/CMakeFiles/objxgboost.dir/common/stats.cc.o -c /usr/ports/misc/xgboost/work/xgboost-2.0.0/src/common/stats.cc
In file included from /usr/ports/misc/xgboost/work/xgboost-2.0.0/src/common/stats.cc:4:
/usr/ports/misc/xgboost/work/xgboost-2.0.0/src/common/stats.h:43:7: error: use of undeclared identifier 'omp_in_parallel'
  if (omp_in_parallel()) {
      ^
/usr/ports/misc/xgboost/work/xgboost-2.0.0/src/common/stats.h:86:7: error: use of undeclared identifier 'omp_in_parallel'
  if (omp_in_parallel()) {
      ^
2 errors generated.

FAILED: src/CMakeFiles/objxgboost.dir/common/threading_utils.cc.o
/usr/local/libexec/ccache/c++ -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_BUILTIN_PREFETCH_PRESENT=1 -DXGBOOST_MM_PREFETCH_PRESENT=1 -D_MWAITXINTRIN_H_INCLUDED -I/usr/ports/misc/xgboost/work/xgboost-2.0.0/include -I/usr/ports/misc/xgboost/work/xgboost-2.0.0/dmlc-core/include -I/usr/ports/misc/xgboost/work/xgboost-2.0.0/rabit/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -DNDEBUG -std=gnu++17 -fPIC -funroll-loops -pthread -MD -MT src/CMakeFiles/objxgboost.dir/common/threading_utils.cc.o -MF src/CMakeFiles/objxgboost.dir/common/threading_utils.cc.o.d -o src/CMakeFiles/objxgboost.dir/common/threading_utils.cc.o -c /usr/ports/misc/xgboost/work/xgboost-2.0.0/src/common/threading_utils.cc
/usr/ports/misc/xgboost/work/xgboost-2.0.0/src/common/threading_utils.cc:45:7: error: use of undeclared identifier 'omp_in_parallel'
  if (omp_in_parallel()) {
      ^
1 error generated.

The files src/common/stats.h and src/common/threading_utils.cc need #include <omp.h>.
And tests/cpp/common/test_threading_utils.cc has the same problem.
clang-16
FreeBSD 13.2

Hmm, we import omp through dmlc https://github.com/dmlc/xgboost/blob/730bc1f68852927c07b1f2ed8ff00bf3e28e448f/src/common/threading_utils.h#L8
https://github.com/dmlc/dmlc-core/blob/a355fbf49da01db456c4368a244c9dbe865eb079/include/dmlc/omp.h#L10
Not sure what's underlying issue

Tested with clang++-15 on Linux, the compilation is fine.

This is likely due to the old version of dmlc.
Thank you for your help.