Update Docker to major release 19

Description
Flatcar ships Docker 18.x.. This issue tracks the upgrade to Docker major release 19.x.

Hi @t-lo
Could you please suggest when this will be propagated into the stable channel? It looks like we found a little-bit incompatibility in our set-up between 18.x and 19.x, so we trying to schedule fix before this will go to stable.

Hello @dmazhar-cogniance,
It's on the roadmap but we don't have a fixed ETA yet; I'll keep you posted.
To mitigate your risk you might want to investigate supplying a custom torcx profile which you could use to install a custom docker version. Not suggesting anything, just making sure you're aware of alternatives.

Thanks for the suggestion :)
We have identified an issue and prepared a fix, so we'll be ready to migrate to docker 19.x. Just a little bit afraid that will not be able to propagate it through all the environments before this will get to stable channel. Is it something that will happen this/next week or later?

Hi
Back on CoreOS I froze the Docker version 18.06 via this script:
https://support.coreos.com/hc/en-us/articles/360005202674-Update-Docker-on-CoreOS-using-torcx
I have migrated CoreOS to Flatcar and now running Beta 2513.2.0 with Docker 19.
How do I unfreeze the docker version to use the one which comes with Flatcar ?
Thanks

Hi,
writing vendor to /etc/torcx/next-profile and rebooting should bring you back to the default version.

Now all channels have Docker 19.
Can we close?


Sieve of Eratosthenes in python

🚀 Feature
Sieve of Eratosthenes in python
Have you read the Contributing Guidelines on Pull Requests?
yes
Motivation
Sieve of Eratosthenes in python
Pitch
Sieve of Eratosthenes in python

/assign


Class precedence

Context:

MUI v5 beta 4
Nextjs
Using makeStyles with tss-react

I'm used to passing classes to MUI components in a classes object in order to overwrite styles.
However, the Material UI default classes always seems to be appended later, causing the custom styles to be ignored.
For example:
const useStyles = makeStyles()((theme: Theme) => ({
  myButtonRoot: {
    backgroundColor: "green",
  },
}));

...

const { classes } = useStyles();

<Button color="primary" classes={{ root: classes.myButtonRoot  }}  />;

The resulting css will list that green background, but it will be overwritten by the own MUI Button styling, since that has a background of the primary theme color.
The custom makeStyles classes should come after/have priority over the default ones of that component.

I tried adding a custom cache just for the makeStyles Wrapper:
const { makeStyles } = createMakeStyles({
  useTheme,
  cache: createCache({ key: "my-prefix-key" })
});

While the global default one just keeps the key "css" and is set up like defined in the MUIv5 nextjs example.
That way, the custom classes there actually have priority over the MUI ones however it still breaks the precedence of a className over the other classes.
Before in MUIv4 with makeStyles:
I could pass a root class for a Button, e.g. containing background: "red", within classes.
Now if I also pass a className to that Button, with the class also being created using makeStyles, which e.g. has background: "blue", that one would have priority over what is defined within classes.

Sorry if I am missing the point, I haven't read your message in detail. I will do if the following code do not solve your problem:
makeStyles.ts

export const cache= createCache({ key: "my-prefix-key" })

const { makeStyles } = createMakeStyles({
  useTheme,
  cache
});

page/document.tsx
import { createDocument } from "tss-react/nextJs";
import { getCache } from "tss-react/cache";
import { cache } from "../shared/makeStyles";

const { Document } = createDocument({ "caches": [ getCache(),  cache ] });

export default Document;

pages/index.tsx
export default function Home() {
    return (
        <>

                //...

            <CacheProvider value={getCache()}>
                <MuiThemeProvider theme={theme}>
                    <CssBaseline />
                    <Root />
                </MuiThemeProvider>
            </CacheProvider>,
        </>
    );
}

Hey @garronej, thank you for the reply, yes that is basically what I'm doing with a few exceptions:

I dont create the cache in my makeStyles wrapper
_document.tsx has a custom getInitialProps in my case, however I think I wrapped things properly in a way createDocument  would too
I dont use a the Cache provider or ThemeProvider per page, but have it in _app.js. Also, I don't use getCache there, but directly import the same shared createEmotionCache function. Just switched to getCache to be sure, but it doesn't make a difference.

I will try to create a minimal example on codesandbox to demonstrate the issue.

Thank you, sorry it didn't do it for you.
You can start from the test app located at src/test/ssr in this repo.
you can run it by doing:
git clone https://github.com/garronej/tss-react
cd tss-react
yarn
yarn build
yarn start_ssr

Oh, Im seeing this a bit too late, I already crated a quick example here:
https://stackblitz.com/edit/nextjs-4wchjr (Stackblitz since Codesandbox decides to act crazy again)

Ok thanks for taking the time to create a sandbox,
I see that:

It isn't working as expected with multiple caches.
It isn't working as expected when we use the mui  classes props.

I have to fix that!
For now this is the best workaround I can offer: https://stackblitz.com/edit/nextjs-5bjvvn?file=src%2Fcomponents%2FsomeButton.tsx

If you feel you can do it, PR are welcome.

Thanks for the quick response!
Simply switching to className sadly is not option, since in my projects classes is used to customize various classes of a MUI component.
Happy to submit a PR once I find out how to control the order of styles here :)

I just started wondering, since Material UI internally uses @emotion/styled instead of @emotion/react, if that somehow would take priority.
import { makeStyles } from "../shared/makeStyles";
import styled from '@emotion/styled'

const useStyles = makeStyles()(() => ({
    otherText: {
        color: "orange"
    }
}));

const Basic = ({ className }) => {
    const { classes } = useStyles();

    return (
        <div className={`${className} ${classes.otherText}`}>Some text

    )
}

const SomeStyled = styled(Basic)`
  color: hotpink;
`

However, this doesn't seem to be the case, since the text would properly render in orange,.
So since that got me curious, I just tried a static classname:
<Button
    classes={{
        root: "SOMESTATICNAME"
    }}
>
    text
</Button>

And realized that indeed SOMESTATICNAME would be at the start of the classes in the resulting element, not at the end.
So this problem seems to be about Material UI v5 in general, and not specific to this library, since the same issues would occur using static css.
Feel free to close this, or maybe keep it open since this would be the first starting point for users coming from v4 and expecting to be able to continue styling MUI components the same way they did before. I will search for any mention of that change in behavior in the MUI repo.

Submitted a new issue about this here: https://github.com/mui-org/material-ui/issues/27945

Ok I think it's solved, let me publish a fix

Hi @janus-reith,
I think everything is fixed now, I didn't change anything in the code but I updated the instruction on how to set things up. See the updated readme.
Do not esitate to reopen if you still have issues but it have been carefully tested

See the diff of the README to know how to update your configuration to make things work as expected. Thank you for reporting.

I, however, opened another issue on the material-ui repo following up yours.

Hi @janus-reith,
Just a small notice to inform you that I updated the instructions on how to setup tss with mui yet again and I also made some small api changes.
Sorry for the instability of the API. Everything will be freezed once mui release.
See new instructions

Hey @garronej, thanks, yes it seems to be the solution that I also found in the meantime and described above.
https://github.com/garronej/tss-react/issues/17#issuecomment-904727465
That one issue however still remains unsolved if I'm not mistaken:

Before in MUIv4 with makeStyles:
I could pass a root class for a Button, e.g. containing background: "red", within classes.
Now if I also pass a className to that Button, with the class also being created using makeStyles, which e.g. has background: "blue", that one would have priority over what is defined within classes.
Edit: So I just verified, that only comes up when using a different cache. Using the same cache, I have the original error of classes not taking priority over MUI ones, but the className works as expected and also correctly has priority over the MUI classes.

Since emotion will derive the priority of styles based on where in the three they are defined, that still doesn't work.
Here is a simple example:
My component, lets call it MyCustomButton, is a wrapper around the MUI Button and passed some classes, like a root one that defines that the Button by default is "green".
That custom component MyCustomButton just passes down all other props to the Button.
Now, I have some outer component that actually uses this Button, lets call it MyCustomPage.
MyCustomPage will make use of MyCustomButton, but instead of the default green, wants it to be blue.
So it defines a class with styles for a blue Button, and passes it: <MyCustomButton className={classes.blueButton}.
In v4 that would work fine.
But now, the resulting button will still be green - A class definition with styles for the original green button comes later, since first the Outer styles of MyCustomPage are defined, afterwards the inner ones of MyCustomButton.
While easy to work around this in a new project, this can make things quite hard with an existing codebase and is a dealbreaker for a simple transition from v4 to v5 if that pattern was used before.
One workaround that can help: On the outer class defined in MyCustomPage, add "&&" so it gets more priority:
myClassName: {
 "&&": {
      backgroundColor: "blue"
   }
}

Looks a bit weird, but probably better than using !important on each declaration.
It would end up in the resulting css as myClassName.myClassName
In a bigger project, the workflow for this can be like this:

Spot all Components that use MUI components and pass classes
Check each of them if they also add className, if yes add "&&".
Check each use of these components that wrap MUI Components, within order Components, if they pass props, maybe including className, and also add "&&" there.

This could cover usual usecases, but certainly not all of them. There could be situations where you have composition of multiple levels of nested styles, this could probably be covered using "&&&", "&&&&" and so on, you get the idea.

Tanks for rising this concern.

this can make things quite hard with an existing codebase and is a dealbreaker for a simple transition from v4 to v5 if that pattern was used before.

I agree, this is a problem. We want to make the migration as smooth as possible.
Now that said I dont think that assuming that className have priority over classes.root was a safe assumption, even in v4. The two are supposed to do the same thing. that is to apply a given class name to the root component. I trust you when you say that it worked in v4 but to me that was more attributable to star alignments than some hard specification.
I might be missing something though.
Maybe if material-ui devs address this issue we could, by moving back to using a unique cache, make it work like it used to but I don't see any other way from where I stand.
What I would recommend doing is using tss's cx function that allow to give priority of one class over an other (I need to try thoug to be 100% sure):
export type Props = {
    className?: string;
    children: ReactNode;
};

export function MyButton(props: Props){

    const { className, children } = props;

    const { classes, cx }= useStyles();

    return (
        <MuiButton classes={{
            ...classes,
            "root": cx(classes.root, classeName)
        }}>
            {children}
        <MuiButton>
    );

}

I don't know how common is the pattern you describe. Maybe I should add some instruction in the readme about that.
What do you think ?

I need to try thoug to be 100% sure

It work, I tried:

Maybe if material-ui devs address this issue we could, by moving back to using a unique cache, make it work like it used to but I don't see any other way from where I stand.

Yes, thats the same impression I got.

What I would recommend doing is using tss's cx function that allow to give priority of one class over an other

Interesting, I wasn't aware of that.  I wonder if it could be wrapped in some clever way, to avoid needing to do this per component, but so far none comes to mind.

I don't know how common is the pattern you describe. Maybe I should add some instruction in the readme about that.
What do you think ?

That could be helpful - While I'm not sure how many people do it like that usually, passing a className as a prop doesn't seem to uncommon.

Before in MUIv4 with makeStyles:
I could pass a root class for a Button, e.g. containing background: "red", within classes.
Now if I also pass a className to that Button, with the class also being created using makeStyles, which e.g. has background: "blue", that one would have priority over what is defined within classes.

Hi @janus-reith, correcty me if I am wrong but this doesn't seem to be actuate. [sandbox](Before in MUIv4 with makeStyles:
I could pass a root class for a Button, e.g. containing background: "red", within classes.
Now if I also pass a className to that Button, with the class also being created using makeStyles, which e.g. has background: "blue", that one would have priority over what is defined within classes.
)

Before in MUIv4 with makeStyles:
I could pass a root class for a Button, e.g. containing background: "red", within classes.
Now if I also pass a className to that Button, with the class also being created using makeStyles, which e.g. has background: "blue", that one would have priority over what is defined within classes.

Hi @janus-reith, correcty me if I am wrong but this doesn't seem to be actuate. sandbox

Hey @garronej , I can't really make sense of that sandbox, it only shows one h1 and two h2 each receiving a class built with makeStyles? 🤔 It also doesn't run since there is an import for a non-existent styles.css - Did codesandbox by chance mess something up here?

Sorry I didn't save: https://codesandbox.io/s/makestyles-forked-txfry?file=/src/index.js

Sorry I didn't save: https://codesandbox.io/s/makestyles-forked-txfry?file=/src/index.js

Ah, I just read your issue in the MUI repo too and figured you were referring to the same thing.
I gave more details on the issue further in this comment: https://github.com/garronej/tss-react/issues/17#issuecomment-910078454
Rereading my statement above about classnames and classes, it might've sounded a bit misleading what my point is there, it was about how these style definitions relate, not about classes and className in general.
In my example, the passed className is in the upper scope, and is passed to a Button in a component down the tree - That one has classes.root with a custom color set, and the outer className is able to overwrite it.
I took your Sandbox and added another Button that demonstrates the issue:
https://codesandbox.io/s/makestyles-forked-run7q
As far as I understand things, you won't be able to recreate the same logic with MUI v5 and tss-react - The definiton of the cyan inside the button comes later, so that one is used instead of the pink background from className

If I move the definition of WrappedButton to the index and I make it use the same useStyles the button behave like the others:
your sandborx modified
And the example you gave, behave exactly the same with mui v5 and tss-react proof.

And if I move the definition of WrappedButton to the index and make it use the same useStyles the button behave like the others:
your sandborx modified

Sure, that's expected

The example you gave, behave exactly the same with mui v5 and tss-react proof.

This is confusing, I'm struggling to puzzle the pieces together, since with my earlier testings, this did not work properly. I think this was due to the two separate Caches being necessary, is that not the case anymore? I might need to follow up more on the changes in the latest release then.

In the latest release of tss-react the contextual cache provided by <CacheProvider /> is no longer picked up. By default tss-react uses import { getTssDefaultEmotionCache  } from "tss-react".
If you want tss to use a specific cache there is a provider only for tss <TssCacheProvider />


Forcing focus to a RadioGroup inside of a Wizard cause the RadioGroup and the Next/Finish button to be focused at the same time

Describe the bug
When loading a wizard, it seems like the focus is on the Next/Submit button. The problem is that I didn't found how to escape the  Next/Submit button using keyboard to focus the content of the Wizard.
I can click on the content area but this is "slow".
For this reason, I had the idea of forcing the focus on the choice component directly, but it seems like now the focus is on both choice and the Next/Submit button.
type InteractiveWindow(config: CommitParserConfig) as this =
    inherit Window()

    let promptCommitType (config: CommitParserConfig) =
        let step = new WizardStep()

        let commitTypeLabel = new Label(Text = "Select the type of commit")

        let listOfCommitTypes =
            [| "feat"; "fix"; "docs"; "style"; "refactor"; "perf"; "test"; "chore" |]

        let choices =
            new RadioGroup(X = 1, Y = Pos.Bottom(commitTypeLabel), RadioLabels = listOfCommitTypes)

        choices.SelectedItemChanged.Add(fun _ ->
            InteractiveWindow.CommitType <- choices.RadioLabels[choices.SelectedItem]
        )

        // Force focus on the radio group for faster
        choices.SetFocus()

        step.Add(commitTypeLabel, choices)
        step

    do
        this.Title <- $"Commit editor (%O{Application.QuitKey} to quit)"

        let wizard = new Wizard()

        wizard.AddStep(promptCommitType config) |> ignore
        wizard.AddStep(promptCommitType config) |> ignore

        wizard.Finished.Add(fun _ -> Application.RequestStop())

        this.Add(wizard) |> ignore

	static member val CommitType = "You should not see this text" with get, set

Expected behavior
Only choice, should be focused and I should be able to use tab to focus the Next/Submit button.
In the console, I should see the selected "commit type" and not "You should not see this text"
Screenshots
If applicable, add screenshots to help explain your problem.

https://github.com/user-attachments/assets/124ad785-ce11-478e-96e4-3708b81b79e1
Additional context
Add any other context about the problem here.
I am using version 2.0.0-v2-develop.2214 on MacOS.

I just completely broke Wizard in the focus PR I just merged.
I'll fix this when I fix that. Sorry!

No problem, it happens :) Will wait for the wait.
For information, I think my version is from before this merge happened but I will check once I get some news.

Pull this down and see if it does what you want.
I fixed some focus things in Wizard and WizardStep and then added code to the Wizard Scenario showing how to overrride the behavior that sets the focus to the next/back buttons on Wizard.GoToStep:

The exemple for RadioGroup seems to be working fine now.
However, on the second step you can move from the Next/Submit button into the view step content but once your are inside of it you cannot go back to the Next/Submit button user the keyboard only.
https://github.com/user-attachments/assets/a894d195-7af3-4431-a95d-45026a59fafa

Yep, I'm working on fixing that...
For now, just makes sure there's a hotkey for any next/back button so the user can at least use those.
Also, when I wrote this in v1, consistent Accept event handling wasn't implemented. Now, with v2, it is. For this reason, i've removed the code that sets focus to the next/back buttons automatically. As long as the wizard step's first focusable subview doesn't eat "Accept", pressing ENTER will cause "Next" as expected.

Ok, I think this all works as expected now.
Note that because Wizard uses a hidden "content view" within WizardStep, Tab navigation is a bit odd, but correct:
When tabbing from the back/next buttons into the wizard step, the focus gets RESTORED. This is because the behavior for tabbing into a view with subviews is to restore focus, not "focus first".
With #2485 I plan on refactoring wizard to not use all this nesting, but that may never happen... ;-).


fix

修复一个中文符号的错误
修复一些翻译中的语义错误
修复个别错别字

These methods are called when an instance of a component is being created and inserted into the DOM:


chore: prepare release 2024-06-12

Summary
This PR has been created using the yarn release script. Once merged, the clients will try to release their new version if their version has changed.
Version Changes

csharp: 7.0.0-beta.3 -> prerelease (e.g. 7.0.0-beta.4)
dart: 1.11.0 -> minor (e.g. 1.12.0)
go: 4.0.0-beta.15 -> prerelease (e.g. 4.0.0-beta.16)
java: 4.0.0-beta.33 -> prerelease (e.g. 4.0.0-beta.34)
javascript: 5.0.0-beta.3 -> prerelease (e.g. 5.0.0-beta.4)
kotlin: 3.0.0-beta.28 -> prerelease (e.g. 3.0.0-beta.29)
php: 4.0.0-beta.3 -> prerelease (e.g. 4.0.0-beta.4)
python: 4.0.0b18 -> minor (e.g. 4.0.0b19)
ruby: 3.0.0.beta.3 -> minor (e.g. 3.0.0.beta.4)
scala: 2.0.0-beta.3 -> prerelease (e.g. 2.0.0-beta.4)
swift: 9.0.0-beta.3 -> prerelease (e.g. 9.0.0-beta.4)

Skipped Commits
It doesn't mean these commits are being excluded from the release. It means they're not taken into account when the release process figured out the next version number, and updated the changelog.

Commits without language scope:

Commits with unknown language scope:

chore(scripts): generate LTS files (#3168)
fix(cts): use the real java enum
chore(scripts): rename dart release CI (#3162)

nice it finally wooorks see you tomorrow


Added flake8 linter to testinfra verifier

Updated tests and documentation to support running flake8 with
molecule verify.

Just the one question about docs, code looks 🚬

Bah, I merged before adding test results... and yes a CI would be nice. 😸
  syntax: commands succeeded
  py27-ansible19-unit: commands succeeded
  py27-ansible19-functional: commands succeeded
  py27-ansible20-unit: commands succeeded
  py27-ansible20-functional: commands succeeded
  py27-ansible21-unit: commands succeeded
  py27-ansible21-functional: commands succeeded
  doc: commands succeeded
  congratulations :)


Crash when looking at canvas sign

Hey!
Just updated the mod, amongst others, on my server. Trying to render a chunk with a canvas sign block in it causes the following crash:
https://mclo.gs/gUcdMfy
Mod version is 3.1.20, minecraft version is 1.19.2 Fabric

Hello @Tempest-5ky,
Thank you for reporting the issue.
The log you give show that it's an error caused by the mod "Enhanced Block Entities". You can report the issue in the tracker of the mod : https://github.com/FoundationGames/EnhancedBlockEntities/issues.


Cannot continue listen!

I'm new,poll not work!
First connect normally,but second is odd,
then resume,
python console log success,but actually rust code is not go into correspond code block.
If I use std::net::TcpListen with block listen, it's work as expect!
cargo 1.74.1 (ecb9851af 2023-10-18)
rustc 1.74.1 (a28077b28 2023-12-04)

[dependencies]
mio = {version="0.8",features = ["os-poll", "net"]}

win11,(22621,3007)

use mio::net::{TcpListener, TcpStream};

const SERVER: mio::Token = mio::Token(0);
fn main() {
    let mut listener = TcpListener::bind("<IP_ADDRESS>:8080".parse().unwrap()).unwrap();
    let mut poll = mio::Poll::new().unwrap();
    let mut events = mio::Events::with_capacity(1024);

    poll.registry()
        .register(&mut listener, SERVER, mio::Interest::READABLE)
        .unwrap();

    loop {
        poll.poll(&mut events, None).unwrap();
        for event in events.iter() {
            match event.token() {
                SERVER => {
                    let (mut stream, addr) = listener.accept().unwrap();
                    println!("Accepted connection from: {}", addr);
                }
                _ => unreachable!(),
            }
        }
    }
}

import socket

tcp_conn = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
tcp_conn.connect(('<IP_ADDRESS>', 8080))

while True:
    data=input('Enter data to send: ')
    if not data:
        break
    tcp_conn.send(data.encode())
    data = tcp_conn.recv(1024)
    if not data:
        break
    print('Received:', data.decode())

You need to put a loop around accept, please read the docs: https://docs.rs/mio/latest/mio/struct.Poll.html#draining-readiness.

You need to put a loop around accept, please read the docs: https://docs.rs/mio/latest/mio/struct.Poll.html#draining-readiness.

Thank you very much!


force stdout to use UTF-8 encoding

Ensure tasklist output is in UTF-8 format, otherwise tasks with windowTitles containing UTF-8 chars will be rendered as � instead.
E.g. A task with windowTitle
"how to open new window · Issue #401 · SimulatedGREG/electron-vue - Google Chrome"
would register as
"how to open new window � Issue #401 � SimulatedGREG/electron-vue - Google Chrome"
in the tasklist output instead, if stdout wasn't specified to use the UTF-8 charset

I really doubt this is the proper way to fix it. I would look for a better solution without having to use the shell.
// @MarkTiedemann In case you know something about this.

chcp 65001 is the best way as I know to let window cmd to output utf-8

Closing as I'm not interested in this way of solving it. Open an issue for this instead and we can discuss better solutions.


Publish to Maven Central?

Hi,
since https://github.com/cjstehno/ersatz started using this project, one cannot use newer releases of Ersatz from Maven Central, since groovy-closure-support isn't on Maven Central. Would it be possible to publish this project to Maven Central?

I'm sorry but I don't think this is going to happen any time soon. the reason is what @cjstehno mentioned.

Note: Getting a library added to maven-central is a bit of a pain, which is why I think a lot of devs skip it until it becomes an issue.

is there anything blocking you to use JCenter repository?


Add 'head token index' attribute to words in nlp(doc)

When navigating a spaCy-processed document, e.g --
from spacy.en import English
nlp = English()
doc = nlp('The old man shook hands with the young man.')
for word in doc:
    print(word, word.tag_, word.head)

-- which outputs:

The DT man
old JJ man
man NN shook
shook VBD shook
hands NNS shook
with IN shook
the DT man
young JJ man
man NN with
. . shook

It would be great to have a token number stored with the head (i.e. word.headi or something like that). This would allow you to unambiguously identify the head (e.g. man_3 versus man_9 in this sentence).

Each token has a .i attribute. So token.head.i should give you exactly what you want.

So it does! Wasn't thinking recursively enough .. thank you

Can I ask a related question: in the sentence, "I want a flight to Berlin er I mean Munich", there are disfluencies that would be removed from the parse tree with Redshift (so that 'Berlin er I mean' is edited away) .. has that been incorporated in spaCy in some way? I can't see that it has, in which case, is there a plan to do so?

There's no immediate plan to use the Edit transition. There aren't enough speech users, and people don't know they want disfluency detection :p.
Try using a bidirectional LSTM to pre-process. It'll probably work really well.


Fix: Close connection when thrown inside handler

closes #1037

Codecov Report

Merging #1099 (ddbf093) into main (0096ea9) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1099      +/-   ##
==========================================
+ Coverage   57.45%   57.72%   +0.27%
==========================================
  Files          73       73
  Lines        2315     2316       +1
  Branches       70       72       +2
==========================================
+ Hits         1330     1337       +7
+ Misses        985      979       -6

Impacted Files
Coverage Δ

...io-http/src/main/scala/zhttp/service/Handler.scala
78.57% <100.00%> (+9.34%)
:arrow_up:

...main/scala/zhttp/http/headers/HeaderModifier.scala
18.60% <0.00%> (+1.16%)
:arrow_up:

...la/zhttp/service/client/ClientInboundHandler.scala
100.00% <0.00%> (+28.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0096ea9...ddbf093. Read the comment docs.


Fixup build & packaging

[x] Add the recv.ml cohttp example.
[x] Fixup ocamlbuild & opam dependencies
[x] Make running the test possible

Thanks!

You are welcome  :)


Cannot reproduce the result in the paper

Thank you for the nice work. I ran the code but cannot get the similar result shown in the paper. Although I used the default parameters and trained the model for 150 epochs, is there any problem? and should I tune any parameters? Would it be possible to release the pre-trained model?

Thanks for your interest in our work. We could not release the pre-trained model as it is using in a commercial software. But I could give some advice in training: 1. Sometimes, the best performance epoch number is not constant, you can try more epochs to obtain the best results; 2. For each pixelized image, the 'fake_B_x4_processed' is always the best and the other two are too hard to train if you do not want to train too much epochs; 3. Add more portrait images in the training dataset; 4. Using the data augmentation strategy is always a good way to improve the model performance.

Thanks for your quick reply. I 'll try it.


Option to replace Youtube links

Add options to replace Youtube links for Invidious ones:
https://docs.invidious.io/Invidious-Instances.md
It shouldn't be too hard to replace the base URL with an Invidious instance.

It should be included by the next release
Commit: b339cd8cd532a5efa4aa5fd0af549cc700d76c3b


Add AzimuthUtils and make TerraWhereFragment also return facing.

This makes it so when someone does /terra where it also shows the accurate facing.

All of the issues you guy mentioned should be fixed

All of the issues you guy mentioned should be fixed

Messy indents and unused imports are fixed

Messy indents and unused imports are fixed

meh... your formatting is still broken, but i'll just fix it myself...

meh... your formatting is still broken, but i'll just fix it myself...


Bloom

The bloom post processing effect doesn't look much realistic. Please look after this matter.

That's true, the bloom effect needs some more work.
I'll look into it.

The blockiness has been fixed and the spreadis now a bit more realistic.


Website is forced to restart when adding or editing custom page routing

The website is currently forced to restart in order to update the RouteTable. This will be fixed by using Data Driven routes instead: http://stackoverflow.com/a/31958586/181087

This issue remains open as we haven't found an acceptable solution yet.

Integrated SSO so that the Restart Seamlessly logs the user back in securely.


@angular/material/core/theming/_theming.scss (v15.0.3) problems

Description
After installing the "@angular/material": "15.0.3" package, strange errors related to @use '../density/private/compatibility'; appears in the @angular/material/core/theming/_theming.scss file. It seems that variables from the _compatibility.scss file are not accessible in _theming.scss.

Reproduction
Steps to reproduce:

npm i @angular/material

Expected Behavior
No such problems inside an official package.
Actual Behavior

Environment

Angular: 15.0.4
CDK/Material: 15.0.3
Browser(s): Chrome 108.0.5359.125
Operating System: Windows 10

Can you check which version of Sass you're running? It looks like you're using one that might not support some of the latest syntax.

Closing since no additional info was provided


Fix definition of parallels?

Parallels Desktop appears as node['virtualization']['systems'] == 'parallels' not 'Parallels'.
Encountered this issue while implementing chef-sugar in macos cookbook.

@tas50 any updates on getting this merged?

Sorry for the delay


Tell a pack invocation retry information about the prior failure

Do we want to start by exposing this data only to the set of whitelisted packs so that random third parties don't start using it while we are working on it?

I was thinking a bit more about this overnight, and one additional detail I would like to include is the number of retries, with the array of error codes from each failure.
The main benefit would be a pack can use that info to figure out how aggressively it should try and make sure the attempts succeed.
For example Gmail fetches 200 messages in a single pass by default. If a failure happens and the pack is retrying, I might want to back off to 20 messages. Only if that also fails I want to back off to a single message. However, that is only possible if the pack knows about the retry count and the failures from each of them. Right now I will have to go all way to the extreme position of fetch a single message because the pack doesn't know anything better.
However, I wouldn't block this PR on it. I would love to get it merged so I can start leveraging it


7.7mb install size

Hi :wave:
This probably slipped past, or is it intentional?

@ijkml This is resolved at v0.1.1. Thanks for letting us know!


Resize image on Website

I set the following in the config.sh
# Resize images before cropping and saving.
# Adjust IMG_WIDTH and IMG_HEIGHT according to your camera's sensor ratio.
IMG_RESIZE="true"
IMG_WIDTH=2028
IMG_HEIGHT=1520

and then restarted the allsky service
the image on the website has not resized.
Am I missing a step

@EricClaeys
As of right now using the pulI did today both  the image.jpg and liveview-image.jpg are the same.
I will keep a eye on the forum to see when the new updates are released and do a new pull then.
Mike

the image show to be  1304x796 according to the properties of the file.  guess I did not state the question correctly.  on the hosted side how can I get the image to fill full screen  image is small  I have attached a example of what I am asking.  There image on the hosted side does not fill up the whole screen.

Thanks for the information.  I will leave it alone.
Mike


Fix issue #884

Provide method to reset intercept for a given url
Provide method to reset intercept for all url
https://github.com/getgauge/taiko/issues/884

@negiDharmendra can you please review the pull request

Resolve the conflicts in api.json

@rparthas Thanks for your valuable contribution to Taiko.


Added tick setting to timer

Added tick setting to timer
also updated tick timer based on mouse movement

Thanks! Changed the setting default for autoTeleTimerTicks to false just to not change settings for current users when the plugin updates


Metrics now have descriptions

Pull Request Contents

✨ Feature

🦋 Bug Fix

📝 Documentation

Description
components/models.py has the llama 3.2 model. All other changes are just black formatting
Updated evaltypes so that metrics now have to have a description
Added the UncasedMatch Metric, which is ExactMatch that is case-insensitive
The LLMPipeline now tells you what it replied, which is mostly to give me something to look at
I've run evaluate_file.py and show what an output of an EvaluationFramework looks like
Related Issues or other material

[X] This PR relates to one or more issues, detailed below

Related Issue #69

Closes #69

✅ Added/updated tests?

[X] This PR contains relevant tests

Or doesn't need to per the below explanation

Naughty, but I've not run tests because you can just read the example file 🙃

[X] I've completed all actions and tasks detailed in the PR Template

I have no issue and merge it on the main. Well done James.


fix: Lot of errors on horizontal scrolling on landing

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] PR closes #4177

according to https://www.uriports.com/blog/easy-fix-for-unable-to-preventdefault-inside-passive-event-listener/
Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

pay 50

😍 Perfect, I’ve sent the payout
💵 $50 @ 35.35 USD/KSM ~ 1.414 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xf5a484078b335a5a0f3508aa3b1c3be3625eb14fd325286d5a908ec6d7d2f908
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Completed Classification Problem

The notebook under the Classification section, namely the Cancer Prediction has been completed successfully!## Linked Issue
Closes: #issue number that will be closed through this PR
#3
Describe the changes you've made
I've added the Random Forest Algorithm for the Cancer Detection notebook.
Give a clear description of what modifications you have made
Added a new algorithm and did a little bit of EDA
Type of change
Solved an issue
What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
In Google Colab - everything works perfectly fine.
Describe how have you verified the changes made
Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented on my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots

Original
Updated

Original Screenshot
Updated Screenshot

I have updated the file. Please have a look. Let me know if I should do some further changes!

Okay! So what accuracy level should I reach in your opinion?

Okay! So what accuracy level should I reach in your opinion?

as you can see Naive Bayes did perform good,
I did get 0 false negative.
I am just telling you should try those things also, it may improve the accuracy.

@muhammadanas365 Please reopen this PR merging directly into the main branch. There's some issue with the automatic github PR tracking system hence for your PRs to be counted properly please push them into the main. I've deleted the dev branch.

No problem. Once I'm done with the hyper parameter tuning I shall do as you said. Thanks for notifying!


Need client name / IP address after login for license, printer assignment, .env, etc

Hello!
In our environment, we need to know the IP address of the client that is doing the initial session setup.
Our HW Clients: Thin Clients, Windows Clients with rdp, etc.
Servers: Almalinux / xfce and of course xorgxrdp
So far we have used a script under xinitrc.d and from it, for example, the name of the nearest printer from the client name / IP address, the license assignament, etc.
After switching to xrdp and running xfreerdp on the clients (directly from rc.local) and from windows clients (with native rdp) we no longer have access to this information and are forced to hard-code such information in the user's .profile but again not reliably enough.
It would be cool if /etc/reconnectwm.sh also had access to the reconnecting client's IP address.
In this case, we could even update this information in a file in the user's home directory.
Reading into log files is cumbersome (and the information isn't there anyway)
xrdp-sesadmin is useless as it requires authentication even if you only need information about your own session
I've read that something has already been implemented in one place or another.
Can I access the information as it stands, even if I use a workaround for it?
The important thing in my environment would be if I had the IP address in the environment variables somewhere after logging in, for example.
Thanks in advance, and grateful for hints.

Duplicate of #2415  (or at least very similar) and #1348.
@sibelle-labs - we're working on this, but it isn't there yet. Using the environment isn't a great idea in general, as a session variable can't be changed once it's set. Although it will work OK for your use-case, we will doubtless end up with users getting confused when the IP address of a reconnected client is not the same as the one which started the session.
I'm hoping to make this information available from xrdp-sesadmin. This utility isn't useful for v0.9.x as you need a username and password to use it, but in the devel stream this is not longer necessary. Eventually you'll be able to query xrdp-sesadmin for the initial client IP address, current client IP address, and current connection state.


Add CRDC link to homepage

https://datacommons.cancer.gov
Tried adding this https://github.com/ImagingDataCommons/imagingdatacommons.github.io/commit/788e752d691e462e30c526dff0532a53309fd7c5
But the page didn't process the markdown and put it in as raw text.  This is probably something to do with the templating setup.


Blockquote with multiple lines render incorrectly

standard md
> quote
>
> multiple lines

GFM
> quote
> multiple lines

Looks like
> quote
> multiple lines

is parsed to
BLOCK_QUOTE(>)
quote\n> multiple lines

and then the quote\n> multiple lines are passed  to buildMarkdownAnnotatedString that keep the space in the string.

BLOCK_QUOTE (>)
PARAGRAPH (quote\n> multiple lines)
  TEXT (quote)
  EOL (\n)
  BLOCK_QUOTE (>)
  WHITE_SPACE ( )
  TEXT (multiple lines)
  EOL (\n)


Bug: 0.0.6 seems to be broken with SSR

I just upgraded mode-watcher to 0.0.6, restarted the dev server I was working on and suddenly my website isn't adapting to the OS theme (dark) anymore, it stays white after refreshing, no matter which theme I choose.
After a quick look into the console, I noticed this:

I dug the changes, and I suppose it comes from importing withoutTransition, for some reason.
I know you're really busy with all the fantastic projects you maintain but can you take a look, please?

This was a concern when I worked with this function also, hence why I added this comment:
https://github.com/huntabyte/mode-watcher/blob/2fcc614d470a345031db6b2ccf06490f42b5fc34/src/lib/mode.ts#L71
maybe there is a workaround?

for now, I think the easiest fix is just to not use this withouTransition in setInitialClassState. I don’t think it’s needed there anyways

This should be fixed with the latest release. Let me know if not and I'll check it out when I get home!

It does! Thanks @ollema, @HubbeDev & @huntabyte, you rock!


Mac OS X: Failed to build gem native extension

Can not install nokogiri on a fresh installation of Mac OS X.

sw_vers
ProductName:	Mac OS X
ProductVersion:	10.11.5
BuildVersion:	15F34

gcc --version
Configured with: --prefix=/Library/Developer/CommandLineTools/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.3.0 (clang-703.0.31)
Target: x86_64-apple-darwin15.5.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

clang --version
Apple LLVM version 7.3.0 (clang-703.0.31)
Target: x86_64-apple-darwin15.5.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

mkfile.log: https://gist.github.com/alexandrz/8487e67ec96e7870b31ed59baa6ae25e
Installing nokogiri <IP_ADDRESS> with native extensions

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    current directory: /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/ext/nokogiri
/Users/sasha/.rvm/rubies/ruby-2.2.5/bin/ruby -r ./siteconf20160525-18405-7eloxm.rb extconf.rb --with-iconv-dir=/usr/local/Cellar/libiconv/1.14/
checking if the C compiler accepts ... yes
checking if the C compiler accepts -Wno-error=unused-command-line-argument-hard-error-in-future... no
Building nokogiri using packaged libraries.
Using mini_portile version 2.0.0
checking for iconv.h... yes
checking for gzdopen() in -lz... yes
checking for iconv using --with-iconv-* flags... yes
************************************************************************
IMPORTANT NOTICE:

Building Nokogiri with a packaged version of libxml2-2.9.2
with the following patches applied:
	- 0001-Revert-Missing-initialization-for-the-catalog-module.patch
	- 0002-Fix-missing-entities-after-CVE-2014-3660-fix.patch
	- 0003-Stop-parsing-on-entities-boundaries-errors.patch
	- 0004-Cleanup-conditional-section-error-handling.patch
	- 0005-CVE-2015-1819-Enforce-the-reader-to-run-in-constant-.patch
	- 0006-Another-variation-of-overflow-in-Conditional-section.patch
	- 0007-Fix-an-error-in-previous-Conditional-section-patch.patch
	- 0008-CVE-2015-8035-Fix-XZ-compression-support-loop.patch
	- 0009-Updated-config.guess.patch
	- 0010-Fix-parsering-short-unclosed-comment-uninitialized-access.patch
	- 0011-Avoid-extra-processing-of-MarkupDecl-when-EOF.patch
	- 0012-Avoid-processing-entities-after-encoding-conversion-.patch
	- 0013-CVE-2015-7497-Avoid-an-heap-buffer-overflow-in-xmlDi.patch
	- 0014-CVE-2015-5312-Another-entity-expansion-issue.patch
	- 0015-Add-xmlHaltParser-to-stop-the-parser.patch
	- 0016-Detect-incoherency-on-GROW.patch
	- 0017-CVE-2015-7500-Fix-memory-access-error-due-to-incorre.patch
	- 0018-CVE-2015-8242-Buffer-overead-with-HTML-parser-in-pus.patch
	- 0019-Do-not-print-error-context-when-there-is-none.patch
	- 0020-xmlStopParser-reset-errNo.patch
	- 0021-Reuse-xmlHaltParser-where-it-makes-sense.patch

Team Nokogiri will keep on doing their best to provide security
updates in a timely manner, but if this is a concern for you and want
to use the system library instead; abort this installation process and
reinstall nokogiri as follows:

    gem install nokogiri -- --use-system-libraries
        [--with-xml2-config=/path/to/xml2-config]
        [--with-xslt-config=/path/to/xslt-config]

If you are using Bundler, tell it to use the option:

    bundle config build.nokogiri --use-system-libraries
    bundle install

Note, however, that nokogiri is not fully compatible with arbitrary
versions of libxml2 provided by OS/package vendors.
************************************************************************
Extracting libxml2-2.9.2.tar.gz into tmp/x86_64-apple-darwin15.0.0/ports/libxml2/2.9.2... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0001-Revert-Missing-initialization-for-the-catalog-module.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0002-Fix-missing-entities-after-CVE-2014-3660-fix.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0003-Stop-parsing-on-entities-boundaries-errors.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0004-Cleanup-conditional-section-error-handling.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0005-CVE-2015-1819-Enforce-the-reader-to-run-in-constant-.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0006-Another-variation-of-overflow-in-Conditional-section.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0007-Fix-an-error-in-previous-Conditional-section-patch.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0008-CVE-2015-8035-Fix-XZ-compression-support-loop.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0009-Updated-config.guess.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0010-Fix-parsering-short-unclosed-comment-uninitialized-access.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0011-Avoid-extra-processing-of-MarkupDecl-when-EOF.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0012-Avoid-processing-entities-after-encoding-conversion-.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0013-CVE-2015-7497-Avoid-an-heap-buffer-overflow-in-xmlDi.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0014-CVE-2015-5312-Another-entity-expansion-issue.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0015-Add-xmlHaltParser-to-stop-the-parser.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0016-Detect-incoherency-on-GROW.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0017-CVE-2015-7500-Fix-memory-access-error-due-to-incorre.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0018-CVE-2015-8242-Buffer-overead-with-HTML-parser-in-pus.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0019-Do-not-print-error-context-when-there-is-none.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0020-xmlStopParser-reset-errNo.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxml2/0021-Reuse-xmlHaltParser-where-it-makes-sense.patch... OK
Running 'configure' for libxml2 2.9.2... OK
Running 'compile' for libxml2 2.9.2... OK
Running 'install' for libxml2 2.9.2... OK
Activating libxml2 2.9.2 (from /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/ports/x86_64-apple-darwin15.0.0/libxml2/2.9.2)...
************************************************************************
IMPORTANT NOTICE:

Building Nokogiri with a packaged version of libxslt-1.1.28
with the following patches applied:
	- 0001-Adding-doc-update-related-to-1.1.28.patch
	- 0002-Fix-a-couple-of-places-where-f-printf-parameters-wer.patch
	- 0003-Initialize-pseudo-random-number-generator-with-curre.patch
	- 0004-EXSLT-function-str-replace-is-broken-as-is.patch
	- 0006-Fix-str-padding-to-work-with-UTF-8-strings.patch
	- 0007-Separate-function-for-predicate-matching-in-patterns.patch
	- 0008-Fix-direct-pattern-matching.patch
	- 0009-Fix-certain-patterns-with-predicates.patch
	- 0010-Fix-handling-of-UTF-8-strings-in-EXSLT-crypto-module.patch
	- 0013-Memory-leak-in-xsltCompileIdKeyPattern-error-path.patch
	- 0014-Fix-for-bug-436589.patch
	- 0015-Fix-mkdir-for-mingw.patch
	- 0016-Fix-for-type-confusion-in-preprocessing-attributes.patch
	- 0017-Updated-config.guess.patch

Team Nokogiri will keep on doing their best to provide security
updates in a timely manner, but if this is a concern for you and want
to use the system library instead; abort this installation process and
reinstall nokogiri as follows:

    gem install nokogiri -- --use-system-libraries
        [--with-xml2-config=/path/to/xml2-config]
        [--with-xslt-config=/path/to/xslt-config]

If you are using Bundler, tell it to use the option:

    bundle config build.nokogiri --use-system-libraries
    bundle install
************************************************************************
Extracting libxslt-1.1.28.tar.gz into tmp/x86_64-apple-darwin15.0.0/ports/libxslt/1.1.28... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0001-Adding-doc-update-related-to-1.1.28.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0002-Fix-a-couple-of-places-where-f-printf-parameters-wer.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0003-Initialize-pseudo-random-number-generator-with-curre.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0004-EXSLT-function-str-replace-is-broken-as-is.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0006-Fix-str-padding-to-work-with-UTF-8-strings.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0007-Separate-function-for-predicate-matching-in-patterns.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0008-Fix-direct-pattern-matching.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0009-Fix-certain-patterns-with-predicates.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0010-Fix-handling-of-UTF-8-strings-in-EXSLT-crypto-module.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0013-Memory-leak-in-xsltCompileIdKeyPattern-error-path.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0014-Fix-for-bug-436589.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0015-Fix-mkdir-for-mingw.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0016-Fix-for-type-confusion-in-preprocessing-attributes.patch... OK
Running git apply with /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/patches/libxslt/0017-Updated-config.guess.patch... OK
Running 'configure' for libxslt 1.1.28... OK
Running 'compile' for libxslt 1.1.28... OK
Running 'install' for libxslt 1.1.28... OK
Activating libxslt 1.1.28 (from /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS>/ports/x86_64-apple-darwin15.0.0/libxslt/1.1.28)...
checking for main() in -llzma... yes
checking for xmlParseDoc() in libxml/parser.h... no
checking for xmlParseDoc() in -lxml2... no
checking for xmlParseDoc() in -llibxml2... no
-----
libxml2 is missing.  Please locate mkmf.log to investigate how it is failing.
-----
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
	--with-opt-dir
	--without-opt-dir
	--with-opt-include
	--without-opt-include=${opt-dir}/include
	--with-opt-lib
	--without-opt-lib=${opt-dir}/lib
	--with-make-prog
	--without-make-prog
	--srcdir=.
	--curdir
	--ruby=/Users/sasha/.rvm/rubies/ruby-2.2.5/bin/$(RUBY_BASE_NAME)
	--help
	--clean
	--use-system-libraries
	--enable-static
	--disable-static
	--with-zlib-dir
	--without-zlib-dir
	--with-zlib-include
	--without-zlib-include=${zlib-dir}/include
	--with-zlib-lib
	--without-zlib-lib=${zlib-dir}/lib
	--enable-cross-build
	--disable-cross-build
	--with-xml2lib
	--without-xml2lib
	--with-libxml2lib
	--without-libxml2lib

To see why this extension failed to compile, please check the mkmf.log which can be found here:

  /Users/sasha/.rvm/gems/ruby-2.2.5/extensions/x86_64-darwin-15/2.2.0-static/nokogiri-<IP_ADDRESS>/mkmf.log

extconf failed, exit code 1

Gem files will remain installed in /Users/sasha/.rvm/gems/ruby-2.2.5/gems/nokogiri-<IP_ADDRESS> for inspection.
Results logged to /Users/sasha/.rvm/gems/ruby-2.2.5/extensions/x86_64-darwin-15/2.2.0-static/nokogiri-<IP_ADDRESS>/gem_make.out

as noted here: https://github.com/sparklemotion/nokogiri/issues/1445#issuecomment-219398565
you have to run xcode-select —install
:(

As noted in the installation tutorial, as well.


SciPy 2023 conference organization

For those who are interested in helping organize SciPy 2023 conference. SciPy conference is now under NumFOCUS.

I'm interested in this!

Unfortunately it was not selected due to lack of votes. But feel free to reach out to NumFOCUS if you are interested. Thanks for participating!


Boarding passes button broke after clicking on "Home"

Repro steps

User clicks on "Boarding passes"
Boarding passes info is shown
User clicks on "Home" in breadcrumbs, button is unselected although boarding passes info is still displayed

Expected

clicking on "Boarding passes" button should hide the info about boarding passes

Actual

nothing happens

See video below:

🥇 💯


Fix log reporting for release builds

Title (required)
Fixes #1489
Description (required)
Fixes #1489

so that the logcat includes logs only from the Commons app.
also the amount of logs that is not sent is around 1.5 MB instead of last 100-150 lines
have removed sensitive logs (needs a comprehensive test to ensure nothing sensitive is still being logged)

I made an effort to fix ACRA error reporting but it still doesn't work for me. I suspect proguard settings might be the issue.
Tests performed (required)
Sent logs using send log option. Got logs as expected.

Codecov Report

Merging #1916 into master will increase coverage by 0.69%.
The diff coverage is 36.96%.

@@            Coverage Diff            @@
##           master   #1916      +/-   ##
=========================================
+ Coverage    3.71%    4.4%   +0.69%
=========================================
  Files         192     200       +8
  Lines        9915   10085     +170
  Branches      886     894       +8
=========================================
+ Hits          368     444      +76
- Misses       9520    9613      +93
- Partials       27      28       +1

Impacted Files
Coverage Δ

...w/commons/contributions/ContributionsActivity.java
0% <ø> (ø)
:arrow_up:

app/src/main/java/fr/free/nrw/commons/Utils.java
33.33% <ø> (+5.93%)
:arrow_up:

...fr/free/nrw/commons/settings/SettingsFragment.java
36.36% <0%> (+6.36%)
:arrow_up:

...n/java/fr/free/nrw/commons/logging/LogsSender.java
0% <0%> (ø)

.../fr/free/nrw/commons/logging/CommonsLogSender.java
0% <0%> (ø)

...e/nrw/commons/logging/CommonsLogSenderFactory.java
0% <0%> (ø)

...ns/concurrency/BackgroundPoolExceptionHandler.java
16.66% <16.66%> (ø)

.../concurrency/ExceptionAwareThreadPoolExecutor.java
18.75% <18.75%> (ø)

...ain/java/fr/free/nrw/commons/logging/LogUtils.java
33.33% <33.33%> (ø)

...ree/nrw/commons/concurrency/ThreadPoolService.java
54.28% <54.28%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 825a1a0...659fc2b. Read the comment docs.

Hi @maskaravivek ,
I tested this on a Nexus S emulator running API 27. I loaded Nearby, uploaded 1 picture through Nearby, then sent logs. A few things of note:

Please set the target email address as commons-app-android-private, not commons-app-android. This is really important, we can't have people's logs publicly visible to everyone
I sent mine through anyway, with this result: https://groups.google.com/forum/#!topic/commons-app-android/Qc0Jqd97Uzg . The zip file doesn't seem to contain anything at all unfortunately? All it says is

org.acra.data.CrashReportData@eea14b6MediaWiki Username = Misaochan2
No extra information to attach

Is there a reason for splitting into two .txt files and thus necessitating the use of a zip? The old style with just 1 txt file was convenient because we could just view it directly in the browser if we wanted to. But this isn't a big problem if two files are needed

Does this work for you? I don't see any logs sent by you to the google group forum either.
Also, it seems there are quite a few new libraries added, we would need to discuss these as per new library policy. I know you mentioned hyperlog in the issue, which has been approved, but what about the others? Could we please get a brief list of the new libraries and the rationale for each of them?

@misaochan I wasn't able to check on API level 27 during my tests. I tested on Android 6.0 and it worked perfectly.
Will test it on API 27 in the next couple of days and will also change the target email address.
A couple of things that I didn't mention in the PR summary:

Ensure that the app has external storage write permissions so that logs can be written to the file. During testing, I used to grant permissions manually.
Will be removing any extra library that is unrelated to the PR. I omitted this step for the initial testing.

The group doesn't have logs sent by me because I had hardcoded my email ID while testing as I didn't want to spam the group.
Also, now we are using a .zip because now we can have multiple log files.

Instead of sharing just the last few hundred lines of logs, I have increased the logs that would be stored. Right now, the limit is 1MB. We can increase/decrease it if the need be.
The PR introduces a log rotator that could use multiple files for the logs as the whole log data would be amounting to 1MB.

PS: Am forwarding you one of the log files that I generated while testing.

Thanks for sending the log through! It looks great, and as far as I can see it also looks fine from a privacy standpoint as long as we send to the private group and we keep the current manual sending procedure.
Would be fantastic if we can get a newline for each line (probably before each of the [DEBUG] statements), but that's hardly a major issue. :)
One final request: In the subtext of the Settings "Send log file" item, we should probably say "Send log file to developers via email to help debug problems with the app. Note: logs may potentially contain sensitive information". Just to be safe...

@misaochan It works perfectly now.

All logs are on separate lines. I checked in sublime/VS code editor. Which editor are you using to check logs?
Have changed the subtext for send logs
Have removed all unrelated library additions/changes
Have added java docs
Works fine for API 27

As mentioned above log dumping requires external storage permissions.

Ensure that the app has external storage write permissions so that logs can be written to the file.

After granting the permissions, log dumps work after an app kill.

@maskaravivek Fantastic job!!! :) Just tested this again on a Nexus S emulator on API 27, prodRelease.
The first time I tapped Send Logs, got the permission request and toast.
I uploaded an image and then went back to Settings. The second time I tapped Send Logs, it crashed with this error:
10-14 18:45:23.524 32614-32614/fr.free.nrw.commons E/AndroidRuntime: FATAL EXCEPTION: main
    Process: fr.free.nrw.commons, PID: 32614
    java.lang.NullPointerException: Attempt to get length of null array
        at fr.free.nrw.commons.logging.LogsSender.writeLogToZipFile(LogsSender.java:158)
        at fr.free.nrw.commons.logging.LogsSender.getZippedLogFileUri(LogsSender.java:108)
        at fr.free.nrw.commons.logging.LogsSender.sendLogs(LogsSender.java:60)
        at fr.free.nrw.commons.logging.LogsSender.send(LogsSender.java:51)
        at fr.free.nrw.commons.settings.SettingsFragment.checkPermissionsAndSendLogs(SettingsFragment.java:111)
        at fr.free.nrw.commons.settings.SettingsFragment.lambda$onCreate$5$SettingsFragment(SettingsFragment.java:101)
        at fr.free.nrw.commons.settings.SettingsFragment$$Lambda$4.onPreferenceClick(Unknown Source:2)
        at android.preference.Preference.performClick(Preference.java:1137)
        at android.preference.PreferenceScreen.onItemClick(PreferenceScreen.java:249)
        at android.widget.AdapterView.performItemClick(AdapterView.java:318)
        at android.widget.AbsListView.performItemClick(AbsListView.java:1158)
        at android.widget.AbsListView$PerformClick.run(AbsListView.java:3127)
        at android.widget.AbsListView$3.run(AbsListView.java:4042)
        at android.os.Handler.handleCallback(Handler.java:790)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6494)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

I uploaded another image and then tapped Send Logs again. Seems third time was the charm, it worked perfectly!! 👍  And indeed the newlines work in a proper text editor (Notepad++ worked, Notepad didn't). It contains all the logs we would ever need to debug anything.
Great job with the Javadocs, too.
I am happy to approve this PR pending a fix for the crash above. After that is fixed, we can merge this. I may not be around at that time, but @neslihanturan feel free to merge once the fix is done.
Thanks so much guys!

Edit: Oh, I just noticed these lines:
2018-10-14 18:47:13,760     [DEBUG] [file-logging-thread-1] [CustomMwApi] : Token being used is redacted+
2018-10-14 18:47:13,769     [DEBUG] [file-logging-thread-1] [CustomMwApi] : Final cookies are [[version: 0][name: GeoIP][value: AU:QLD:Brisbane:-redacted:v4]
We probably want to just comment out these log lines from CustomMwApi. I think the risks exceed the benefits in having them there. Devs who want the lines to be displayed can always uncomment.

Merging this. First task complete for WMCZ project, woohoo! :D


Image View Remembers Zoom

Issue Type: Bug
In VSC, load a small image, zoom in a lot, close the image.
Resize the small image by 10 times.
In VSC, load the resized image.
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:27:14.102Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.88GB (8.50GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (15)

Extension
Author (truncated)
Version

Bookmarks
ale
10.4.3

npm-intellisense
chr
1.3.0

vscode-eslint
dba
1.8.2

githistory
don
0.4.6

EditorConfig
Edi
0.13.0

rainbow-csv
mec
1.0.0

dotenv
mik
1.0.1

vscode-typescript-tslint-plugin
ms-
1.0.0

vetur
oct
0.19.2

github-actions-vscode
Oma
2.6.1

rust
rus
0.6.1

RustyCode
sav
0.19.1

vscode-hexdump
sle
1.7.2

sort-lines
Tyr
1.8.0

markdown-all-in-one
yzh
2.3.1

(1 theme extensions excluded)

I would like to take this. I think we can store more information in cacheKey. In my opinion, we can add the size or add the SHA1 value of the image? @mjbvz Do you have any suggestions?

can i work on this?

i didn't know that @hwhung0111 already started working on this, both prs work. as far as mine considered, i'm resetting scale to 1.

@cedric05 I'm sorry that I forgot to reply to you immediately. Do you reset the scale every time you close the image? It makes the editor cannot remember the scale and offset even the image isn't modified.

yes you are write. let me close mine. :+1:


Fix memory leak

@stuartwdouglas Can you check the failure? It looks like CI doesn't like your last change of requiring JDK 17.


BucketSort - EqualityComparer.Default is always faster than StringComparer.Ordinal

Rollback of #4123
Starting to doubt if this is actually a performance improvement, after looking at the code for StringComparer.Ordinal. It seems it is actually best when meeting many different long strings where ordinal-compare can shine.

Yes my worry was confirmed StringComparer.Ordinal performs the same operations as EqualityComparer.Default, but introduces an overhead. The only place where StringComparer.Ordinal has an edge is the implementation of IComparer<string> where it actually uses String.CompareOrdinal

Created PR #4125 to rollback this one. Guess I should test instead of guessing.

I could also remove the last commit of dev. :)

That would also work. You choose :)
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
I could also remove the last commit of dev. :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/4125#issuecomment-703087539, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HFBD62CEXGRXGHHWLLSI4CAFANCNFSM4SCFYALQ.

i've removed the last commit from dev, 28ce43fff546df2204540bf1ec81a72a97836e8a
We have to make sure other PRs won't introduce 28ce43fff546df2204540bf1ec81a72a97836e8a again :)


publish latest successfully tested build via API

The purpose of this API would be to facilitate a way for other systems/projects/products to daisy-chain off of origin/openshift product CI flows, optimizing when and how often these external processes run.
/cc @ethernetdan

Can you describe here as well which fields you'd like to see / shape of the output payload?

@stevekuznetsov Right now thinking of returning ReleasePage as JSON.
Is there any information in it that shouldn't be included / additional information that could be helpful?

That seems reasonable to me!

Folded #72 into #78 (slightly different URL, some lookup fixes).


Adapt dependencies version numbers

Since we are using dependabot in github it's better to use the full version number for dependencies.
Signed-off-by: Rafael Garcia Ruiz<EMAIL_ADDRESS>

Takes some of the small fix of #34 applying review comments.

bors r+


Upload githurlparse to pypi

Would you upload giturlparse (your fork of giturlparse.py) to pypi so that it can be used easily by folks?
Would you also update this line in the README as currently if you follow what it says it installs FriendCode's original, not your fork. Once you've uploaded to pypi it should say
    pip install giturlparse

I am using it to create this.
Thanks for actively maintaining  :)

@pycampers nice!

We are also looking for url parser
Would be great if you could release it soon !
Thanks :)

@virresh sorry, I forgot to close this
release 0.9.1 has been released in January https://pypi.python.org/pypi/giturlparse
I still did not have time to update meta files etc, but the code is already one pip install away :)


Hotfix: Binary modes does not take encoding argument.

As I said in a comment on the last PR, the problem was that certain tests were failing because they were passing the enconding argument as "utf-8" to binary modes, which do not accept enconding.

Well, something doesn't seem to be working as it should. Let me take a look at it thoroughly so I can run the tests before doing the final PR. I'm a bit busy and I'm running PR without verifying the tests.


CCSimpleAudioEngine: Resuming finished background music replays song

From desk case.
Resuming background music that has completed will restart and play the song. However, the expected behaviour in this event should be that we simply ignore a Resume call.

Fixed after c84b150cddd023daaaa13d7f34e9f47e73786e56 This issue was previously only affecting iOS/Mac targets.


Cannot read property 'request' of undefined

Please provide us with the following information:

OS?

os: linux x64 Ubuntu trusty tahr

Versions.
angular-cli: 1.0.0-beta.15
node: 6.7.0
os: linux x64
Repro steps.
ng build fails, says cannot read property 'request' of undefined
package file as follows:
{
"name": "aamanager",
"version": "2.1.0",
"description": "Ask Ajumma Management Application Suite",
"angular-cli": {},
"scripts": {
"start": "ng serve",
"serve": "export NODE_ENV=production && node run.js",
"lint": "tslint "src/**/*.ts"",
"test": "ng test",
"pree2e": "webdriver-manager update",
"e2e": "protractor"
},
"author": "its2mc",
"license": "NOT FOR OUTSIDE USE",
"private": true,
"dependencies": {
"@angular/common": "2.0.1",
"@angular/compiler": "2.0.1",
"@angular/core": "2.0.1",
"@angular/forms": "2.0.0",
"@angular/http": "2.0.0",
"@angular/platform-browser": "2.0.1",
"@angular/platform-browser-dynamic": "2.0.0",
"@angular/router": "3.0.0",
"@angular/upgrade": "2.0.1",
"@types/lodash": "^4.14.36",
"angular-in-memory-web-api": "0.1.1",
"angular2-scroll-glue": "^1.0.7",
"async": "^1.5.2",
"aws-sdk": "^2.6.5",
"body-parser": "^1.15.2",
"bootstrap": "^3.3.7",
"chart.js": "^2.3.0",
"connect-mongo": "^1.3.2",
"cookie-parser": "~1.3.5",
"core-js": "^2.4.1",
"csv-parse": "^1.1.7",
"debug": "~2.2.0",
"es6-shim": "^0.35.0",
"express": "^4.14.0",
"express-favicon": "^2.0.0",
"express-session": "^1.14.0",
"express-winston": "^2.0.0",
"file-droppa": "^1.0.0",
"hbs": "^3.1.1",
"helmet": "^2.3.0",
"highcharts": "^4.2.7",
"kerberos": "0.0.21",
"lodash": "^4.16.2",
"mongodb": "^2.2.10",
"mongoose": "^4.6.1",
"morgan": "~1.6.1",
"multer": "^1.2.0",
"newrelic": "^1.30.4",
"ng2-charts": "1.2.0",
"reflect-metadata": "^0.1.8",
"rx-dom": "^7.0.3",
"rxjs": "5.0.0-beta.12",
"stripe": "^4.11.0",
"systemjs": "0.19.39",
"ts-helpers": "^1.1.1",
"typings": "^1.4.0",
"winston": "^2.2.0",
"zone.js": "^0.6.23"
},
"devDependencies": {
"@types/jasmine": "^2.2.30",
"angular-cli": "1.0.0-beta.15",
"codelyzer": "~0.0.26",
"jasmine-core": "2.4.1",
"jasmine-spec-reporter": "2.5.0",
"karma": "1.2.0",
"karma-chrome-launcher": "^2.0.0",
"karma-cli": "^1.0.1",
"karma-jasmine": "^1.0.2",
"karma-remap-istanbul": "^0.2.1",
"protractor": "4.0.5",
"ts-node": "1.2.1",
"tslint": "3.13.0",
"typings": "^1.4.0",
"typescript": "2.0.2"
}
}
The log given by the failure.
result of ng build is
{
"name": "aamanager",
"version": "2.1.0",
"description": "Ask Ajumma Management Application Suite",
"angular-cli": {},
"scripts": {
"start": "ng serve",
"serve": "export NODE_ENV=production && node run.js",
"lint": "tslint "src/**/*.ts"",
"test": "ng test",
"pree2e": "webdriver-manager update",
"e2e": "protractor"
},
"author": "its2mc",
"license": "NOT FOR OUTSIDE USE",
"private": true,
"dependencies": {
"@angular/common": "2.0.1",
"@angular/compiler": "2.0.1",
"@angular/core": "2.0.1",
"@angular/forms": "2.0.0",
"@angular/http": "2.0.0",
"@angular/platform-browser": "2.0.1",
"@angular/platform-browser-dynamic": "2.0.0",
"@angular/router": "3.0.0",
"@angular/upgrade": "2.0.1",
"@types/lodash": "^4.14.36",
"angular-in-memory-web-api": "0.1.1",
"angular2-scroll-glue": "^1.0.7",
"async": "^1.5.2",
"aws-sdk": "^2.6.5",
"body-parser": "^1.15.2",
"bootstrap": "^3.3.7",
"chart.js": "^2.3.0",
"connect-mongo": "^1.3.2",
"cookie-parser": "~1.3.5",
"core-js": "^2.4.1",
"csv-parse": "^1.1.7",
"debug": "~2.2.0",
"es6-shim": "^0.35.0",
"express": "^4.14.0",
"express-favicon": "^2.0.0",
"express-session": "^1.14.0",
"express-winston": "^2.0.0",
"file-droppa": "^1.0.0",
"hbs": "^3.1.1",
"helmet": "^2.3.0",
"highcharts": "^4.2.7",
"kerberos": "0.0.21",
"lodash": "^4.16.2",
"mongodb": "^2.2.10",
"mongoose": "^4.6.1",
"morgan": "~1.6.1",
"multer": "^1.2.0",
"newrelic": "^1.30.4",
"ng2-charts": "1.2.0",
"reflect-metadata": "^0.1.8",
"rx-dom": "^7.0.3",
"rxjs": "5.0.0-beta.12",
"stripe": "^4.11.0",
"systemjs": "0.19.39",
"ts-helpers": "^1.1.1",
"typings": "^1.4.0",
"winston": "^2.2.0",
"zone.js": "^0.6.23"
},
"devDependencies": {
"@types/jasmine": "^2.2.30",
"angular-cli": "1.0.0-beta.15",
"codelyzer": "~0.0.26",
"jasmine-core": "2.4.1",
"jasmine-spec-reporter": "2.5.0",
"karma": "1.2.0",
"karma-chrome-launcher": "^2.0.0",
"karma-cli": "^1.0.1",
"karma-jasmine": "^1.0.2",
"karma-remap-istanbul": "^0.2.1",
"protractor": "4.0.5",
"ts-node": "1.2.1",
"tslint": "3.13.0",
"typings": "^1.4.0",
"typescript": "2.0.2"
}
}

Thanks! We'll be in touch soon.

Solved, the issue was that for some reason a module I had installed used an older version of webpack and for some reason this webpack version took precedence for angular-cli as opposed to the global webpack version. hence the incompatibility.. THis should be fixed


[UIE-74] Add types for Select component

Stacked on #3804.
Motivated by the discovery that several components misuse Select (by passing a disabled prop instead of isDisabled), this PR adds type definitions for the basic Select components.
Terra UI's Select components wrap react-select's Select component. However, the types are not simple passthroughs.
Complicating the types, Terra UI adds some convenience in how options and value may be passed. For example:
h(Select, {
  options: ['foo', 'bar'],
  value: 'foo'
})

instead of:
const options = [{ value: 'foo' }, { value: 'bar' }]
h(Select, {
  options,
  value: options[0[
})

Also, react-select uses the same component for grouped / un-grouped options, while Terra UI separates them.

Just to confirm, do you mean to merge this into upgrade-babel? Or should this go into dev?

I would like to merge #3804 to dev, then merge this to dev. For now, this PR uses upgrade-babel as the base branch to isolate the changes to Select for review.

Rebased after merging #3804.

Had to make a few fixups for recently added Selects. That seems to happen every time I update this branch, so I'm going to go ahead and merge this to avoid falling behind again.


Drag and drop a folder in brackets in Win 10 and Win 8.1 opens live view.

Description
Drag and drop a folder in brackets in Win 10 and Win 8.1 opens live view.
Steps to Reproduce

Launch brackets.
Drag and drop a sites folder.
It shows live view.

Expected behavior: It should show code editor
Actual behavior: It opens live view.
Versions
Windows 10 and Windows 8.1
Brackets Release 1.11 build 1.11.0-17517

This has been verified.


Detect needs to be onboarded as an API sender

Problem statement
Detect needs to be onboarded as an API sender

Lost to APHL :(


Remove Homebrew forum in README

I think https://discourse.brew.sh in "Community" section of README should be removed, because the administrator there doesn't seem to like discussing Linuxbrew there.

Done in 4d7d34d0ad389e2079d7abc21cbd544af1d76275
Thanks for the bug report, Franklin.


Crash under Xcode 6.4 beta

You'll need to wait to add menu items until after the NSApplicationDidFinishLaunchingNotification notification fires, otherwise the menus are nil (and your deallocation observer code crashes because it tries to associate nil with the object.

thanks for spotting! it's now fixed to work with xcode 6.4, let me know how you get on :) https://twitter.com/dodsios


Remove Cloudstate component reference

Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[x] Read the contribution guide
[x] Commands include options for Linux, MacOS, and Windows within codetabs
[x] New file and folder names are globally unique
[x] Page references use shortcodes instead of markdown or URL links
[x] Images use HTML style and have alternative text
[x] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description
Remove the cloudstate component reference
Issue reference
Documentation update accompanying https://github.com/dapr/components-contrib/issues/1297
Also closes #1939

@greenie-msft


:open_book: Docs(Translation): Build & Lint - Chinese Version

What should be changed?
Now we have the document Build and Lint, so the corresponding Chinese version can also start writing (translation) here and here.

The translation does not need to correspond strictly to each sentence, it just needs to express the same meaning. "Meaningful translation" is recommended . Please feel free to ask me when you have any questions.

let me？

I?

@wendao365 first, You got it! Happy hacking!
@amdaous Try another one?

@wendao365 first, You got it! Happy hacking!
@amdaous Try another one?

which one？

@daniel-hutao
I finished zhe translation, should I submit  directly？


support Kafka SASL login module.

javax.security.auth.login.LoginContext use context class loader to load the login module, when configuring "sasl.jaas.config", we could set the value as org.apache.skywalking.apm.dependencies.org.apache.kafka.common.security.scram.ScramLoginModule required username="user" password="pass";, and the context class loader would load the class correctly, otherwise, NoClassFoundException would be thrown

Fix <#6157>

[] Add a unit test to verify that the fix works.
[x] Explain briefly why the bug exists and how to fix it.

[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #6157.
[x] Update the CHANGES log.

Previous discussion is at #7270

Yes, after this fix, the AdminClient is created successfully.

My solution is that the org.apache.kafka.common.security.plain.PlainLoginModule class needs to be configured as org.apache.skywalking.apm.dependencies.org.apache.kafka.common.security.plain.PlainLoginModule. The complete configuration is as follows:
plugin.kafka.producer_config[security.protocol]=SASL_PLAINTEXT
plugin.kafka.producer_config[sasl.mechanism]=PLAIN
plugin.kafka.producer_config[sasl.jaas.config]=org.apache.skywalking.apm.dependencies.org.apache.kafka.common.security.plain.PlainLoginModule required username="" password="";


Auto fill default value

Codecov Report

Merging #36 (6296c18) into main (85459ae) will increase coverage by 0.38%.
The diff coverage is 98.00%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   87.32%   87.70%   +0.38%
==========================================
  Files           7        7
  Lines         284      301      +17
  Branches       83       95      +12
==========================================
+ Hits          248      264      +16
- Misses         25       26       +1
  Partials       11       11

Flag
Coverage Δ

client
87.70% <98.00%> (+0.38%)
:arrow_up:

generator
87.70% <98.00%> (+0.38%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/client/src/helpers/makeHooks.ts
97.24% <97.14%> (-0.23%)
:arrow_down:

packages/client/src/helpers/makeFetcher.ts
100.00% <100.00%> (ø)

packages/client/src/helpers/makeSelect.ts
100.00% <100.00%> (ø)

packages/generator/src/utils/writeFiles.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b682f89...6296c18. Read the comment docs.


Removed the non streaming order by flag from spring data cosmos CI

Removed the non streaming order by flag from spring data cosmos CI

API change check
API changes are not detected in this pull request.

/azp run java - spring - cosmos - tests

/azp run java - spring - cosmos - test

/azp run java - spring - tests

/azp run java - spring - tests


fix: SDA-1880 & SDA-1882 (Fix background Throttling changes for cloud config)

Description
Enabling disableThrottling makes the main window go blank when creating a child windows
SDA-1880
SDA-1882
Issue on Electron
https://github.com/electron/electron/issues/22551
Solution Approach

Disable background Throttling only when the cloud-config is disableThrottling field is "ENABLED"
Fix log message to make the data and the fields clear
Add unit test cases for disableThrottling

Related PRs
List related PRs against other branches/repositories:

branch
PR

SymphonyElectron
6.1.x

Nice test coverage @KiranNiranjan 👍


Validation of transaction instructions on world state view clone before commit to store.

Description of the Change

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

Depends on #467

Smthg wrong with CI


Demo app with decent rotation icons

Issue Type

[x] Improvement

Description and/or steps/code to reproduce the problem
In the demo app, there are moments where grey/blue "+" and "-" buttons mean map rotation, like in "Draw polyline on screen". And the zoom buttons are black/white "+" and "-" buttons. That causes confusion.
I was working on an unrelated project when I found icons that really mean "left or right rotation".
I found them on material.io.
Version of osmdroid the issue relates to:
6.1.6

Done by #1540.


MiB/s vs MB/S

Is the unit on disk throuhgput is incorrect. I think it should be MB/s and not MiB/s.
I did test using diskspd and on a P60 disk i managed to get 486.31 MiB/s which is 509.93 MB/s. So concidering that there is a smal margin of error its more likely to be MB/s than MiB/s
IOPS maxed at 16324.59.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2cd6eb6c-745c-b3eb-8ea8-7fb3be24b607
Version Independent ID: 93637a78-fc66-6c5d-7845-a4fad0045c7d
Content: Select a disk type for Azure IaaS Windows VMs - managed disks - Azure Windows Virtual Machines
Content Source: articles/virtual-machines/windows/disks-types.md
Service: virtual-machines-windows
Sub-service: disks
GitHub Login: @roygara
Microsoft Alias: rogarana

@Annix83 Thank you for the valuable feedback,we are investigating the issue.

@Annix83 Thanks for reaching out, the unit in the doc is correct. It is MiB/s, not MB/s.
As far as why your numbers are lower, I can't help there. But I can give some additional info that may be relevant: Bandwidth = IOPS size * IO size, both IOPS and the IO are throttled. You might be hitting one of the other limits before you're hitting the bandwidth limit. But that's only speculation.
I'd recommend posting your question in Microsoft Q&A  since it's not directly related to the documentation. Someone will follow up there. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
#please-close
@Karishma-Tiwari-MSFT , @SumanthMarigowda-MSFT FYI


Double check 401 responses in case proxy intercepts authorization headers

- What I did
I modified the v1 pull code to retry if it receives a 401 Unauthorized error. This deals with proxies that expect authorization to follow the typical browser pattern of request with no Authorization header, response with 401, and subsequent request containing an Authorization header.  See https://github.com/docker/docker/issues/22503
- How I did it
Initially, I modified the GetRemoteTag and GetRemoteTags functions to check if any 401 response includes a Set-Cookie header, and re-try in that case, to get past a proxy that intercepts Authorization headers unless a cookie is set.  The prescence of the cookie is how the proxy determines that the authorization request is a follow-up to a 401 error.
This added a lot more commonality to the GetRemoteTag and GetRemoteTags functions, so I then refactored the common code into a separate function.  This change highlighted that the functions were deferring closes inside a loop, which is not really a good idea. So, I also modified the code to close the body inside each iteration.
Things I didn't do:

figure out how to make this work for v2 pull.
emit a message advising the user that, for better performance, they might consider modifying their proxy rules.
provide a test that mocks the described proxy pattern.

- How to verify it
First, run a proxy that strips Authorization headers from requests, unless a cookie is set. The proxy sets a suitable cookie in any 401 responses.
In this case, docker pull docker/whalesay or docker pull docker/whalesay will fail with the message Could not reach any registry endpoint.
With this change, both commands will succeed, although warning that this image was pulled from a legacy registry.
Logs will show that requests were retried:
Jun 10 10:31:54 localhost docker: time="2016-06-10T10:31:54.032176288Z" level=de
bug msg="Got status code 401 from https://registry-1.docker.io/v1/repositories/d
ocker/whalesay/tags, retrying..."
Jun 10 10:31:54 localhost docker: time="2016-06-10T10:31:54.615268091Z" level=de
bug msg="Got status code 200 from https://registry-1.docker.io/v1/repositories/d
ocker/whalesay/tags"

- Description for the changelog
Retry a request that returns 401, in case a proxy expects cookies with authorization requests
- A picture of a cute animal (not mandatory but encouraged)
 ^..^
( oo )  )~
  ,,  ,,

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "double-check-401" git@github.com:jongiddy/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~3
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "double-check-401" git@github.com:jongiddy/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~3
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Thanks @jongiddy! Looks like there's a golint issue;
11:20:18 ---> Making bundle: validate-lint (in bundles/1.12.0-dev/validate-lint)
11:20:18 Errors from golint:
11:20:18 registry/session.go:312:19: don't use underscores in Go names; method get_response_body should be getResponseBody
11:20:18
11:20:18 Please fix the above errors. You can test via "golint" and commit the result.

also /cc @aaronlehmann @dmcgowan PTAL

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "double-check-401" git@github.com:jongiddy/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~4
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@jongiddy this change is very specific to a single network configuration and involves interacting with cookies unused by Docker. I think I understand the problem but don't see it justifying adding a second attempt at a request for all 401 scenarios where a cookie set header exists.
Currently proxies are supported by setting the HTTPS_PROXY environment variable on the engine. Most proxies should support the CONNECT used to get around awkward flows like you described. If I am missing something please let me know, otherwise it is probably better to close this PR.
V1 registry support has been deprecated and we do encourage upgrading to V2. We normally don't accept behavioral changes that only effect v1 unless it addresses a critical bug.

@dmcgowan I'm very sympathetic to your view. The issue clearly lies with the proxy configuration which prevents Authorization headers in an initial request. It's completely valid to add Authorization headers up front when you know that they are needed.
However, the company that makes this proxy claim to be used by over 70% of the Fortune Global 500, and this appears to be their default configuration. So, potentially, there are people trying to introduce Docker into large companies and finding that it just doesn't work.
As indicated by my "things I didn't do", I definitely don't think this is the best fix. I did look at the V2 code, but couldn't figure out how to change that code to make it work. I can't see how any setting of HTTPS_PROXY would make this work. As suggested in #22503 an alternative solution might be to allow the Docker daemon to supply admin-configured cookies other than the X-Meta cookies passed now.  However, the actual cookie to be sent from a particular machine would have to be obtained and added manually.

@jongiddy Ok, I understand now why HTTPS_PROXY will not work since it will still alter the request. Is the proxy adding the Set-Cookie or is it expected that the registry would?  Also what is occurring right now when you pull from a v2 registry? With v2 there is an initial 401 response from the registry however it will send credentials immediately to the token server an wondering if that is where it would fail. If you are using basic auth directly with a private v2 registry though then the interaction would match the proxies expectation, minus the registry setting a cookie.

The registry is not aware of any of this. The fundamental problem is that the proxy is configured to remove any Authorization header from a request, unless a client-host-specific cookie is also present. The proxy returns the required cookie to the client in any 401 response.
The value of the cookie is specific to the client host, but is always the same for that host. This means one way to fix it is to set the cookie in the request, if this is supported.
The more automatic way is to perform a request, receive the 401, and perform the request again with the authorization and cookie set (i.e. the typical behavior of web browsers).
I'm not really clear on how the V2 call is failing, as the log file is not particularly clear on which URLs it is calling. You can see the log in https://github.com/docker/docker/issues/22503#issuecomment-217855884.

ping @dmcgowan what's the status on this one?

Closing this issue as it only relates to V1 interactions which we have deprecated and do not want to continue to support behavioral changes.
@jongiddy we are interested in adding cookie support for the V2 protocol to address issues with proxies. We are also open to discussing a method for retrying after cookies are set. Let's move this work over the distribution project where the v2 client code is. Feel free to join the discussion on https://github.com/docker/distribution/issues/1818.


CODEOWNERS wanted? FLUID Team?

A query if there should be a CODEOWNERS file in this repo. That way someone would be alerted for all PRs.
Also, @tclune and I are of the opinion that these should be teams rather than individuals. I could make a "Fluid Team" of whomever.

Hi Matt, a team of individuals that can approve PRs is probably good. Maybe we require at least two approvals for final acceptance. Many thanks for assisting with this new repo.

@jardizzo Sure. Just let me know who to be on the team and I can set it up. And set up the two approvals.

Sorry, this fell off my radar. You can add me to the list of possible code reviewers as well.

Okay. I can make a "MERRA2 FLUID" team that is:

Joe Ardizzone

Alexey Shiklomanov

Allie Collow

Mike Bosilovich

Natalie Thomas

Amin Dezfuli

I know the github ids for the first three: Alexey, Joe, and Allie. Does anyone know the ones for Mike, Amin, and Natalie? I can't see anything in the GEOS-ESM org for them, but there are a few IDs without real names associated that could be them.


Possibility to render html in code block

I would like to mark some codes in the code block by using HTML inline style, e.g. define background color for a piece of code.
codes I want to emphasise.

This is normally supported, even in quote block it works, but not in code block. In order to achieve that, I could use:

This is my code.

Well, you can not see the "correct" result in github, but I believe you understand what is expected result. But in this way, it will overwrite the code highlight feature in code block.
I understand that, the codes in the code block will/should be escaped, because there exists some programming languages, such as HTML.
How about define a second parameter for the code block? For example, if I define a code block by  ```java renderHTML, then the HTML code will not be escaped in the code block, and will be rendered correctly as HTML code, then one can take advantage of hundreds HTML/CSS styling features in code block?
This feature might be discussed before, but I didn't really find a good solution. If there is a way, would you mind tell me how to achieve this feature?

https://github.com/markdown-it/markdown-it/blob/master/lib/renderer.js#L39 you can override default renderer, and process infostring / content as you wish.


add holo-llm: a demo using hologres and pai-llm to build a chatbot

add holo-llm, a demo using hologres and pai-llm to build a chatbot.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


 Click live now. Go back.
The header nav is now green. This is due to client csching. We need to trigger the header action on will mount.

fixed by #790


How do I install harfbuzz[ucdn]:x86-windows

Package harfbuzz does not have a ucdn feature.
.\vcpkg install harfbuzz[ucdn]:x86-windows
Computing installation plan...
Could not find ucdn in harfbuzz.
note: updating vcpkg by rerunning bootstrap-vcpkg may resolve this failure.

this note is not used

this note is useless

this note is useless

It's a common notice.
Request a new feature.

this note is useless

It's a common notice.
Request a new feature.

what do you mean? I just need  harfbuzz[ucdn]:x86-windows

Thanks for posting this issue. Could you please provide more information about feature ucdn, I can't search related codes about ucdn in the source of harfbuzz.

We hope your question was answered to your satisfaction; if it wasn't, you can reopen with more info.