folder_branch_ops: avoid data race in Lookup()

If Lookup returns early, it could write to the return param node. But the internal goroutine might still be running, which also tried to write to the node param.  This leads to a possible (but really rare) data race.
Instead, have the goroutine write to a temp variable, which is only returned when the Lookup is successful.
Issue: KBFS-2579

How could this be a problem? Whatever that calls Lookup here would assign the returned Node to some variable, and would never get overwritten by the inner goroutine right?

It's not about the caller, it's about the return parameter itself on the stack.  You have two goroutines trying to write to that variable on the stack at the same time, before it gets back to the caller, so it triggers the race detector.

Hmmm I'm still not clear; I thought it was runUnlessCanceled that caused early-return. Is it not the case? Where did the 2nd routine start?

There is the goroutine of the original caller, and the goroutine started by runUnlessCanceled.  As soon as the ctx is canceled, runUnlessCanceled returns with an error, but the goroutine it statred may keep going (because it was waiting on a lock, for example).  Then when that goroutine returns, there can be a race.


Clean up Pandas deprecation warnings

Takes care of these warnings:

Note: There's also one failing test currently, but I didn't do anything with it because the cause is a bug upstream.

@cooperdff FYI - It appears the groupby behavior was officially deprecated in 2.0, so incidentally this is also the fix for https://github.com/cooperdff/nfl_data_py/issues/45.


Databinding Issue with Checkboxes

It appears that twbs:checkbox doesn't always correctly bind to the corresponding command object, even though it uses g:checkbox behind the scenes.

No longer a problem/can't reproduce


comment

https://github.com/etlweather/gaucho/compare/master...chaitanyagupta8485:master#diff-3254677a7917c6c01f55212f86c57fbf

Not sure what this pull request is resolving...


Qedma function fails on simple 12Q circuit

Steps to reproduce the problem

N = 12
qc = QuantumCircuit(N)

qc.x(range(N))
qc.h(range(N))

for kk in range(N // 2, 0, -1):
    qc.ch(kk, kk - 1)
for kk in range(N // 2, N - 1):
    qc.ch(kk, kk + 1)

op = SparsePauliOp('Z'*12)

qesem_function  = catalog.load('qedma/qesem')

qesem_job = qesem_function.run(
    backend_name=backend.name,
    action = "execute",
    instance = backend._instance,
    pubs = pubs,
)

What is the current behavior?
It fails with
{'error': 'An unexpected error occurred. Please try again later. If the issue persists, please contact support.'}
What is the expected behavior?
It should work because it is a standard input that works on other functions like the IBM circuit function

for reference, the underlying cause of the failure seems to be that the construction of the PUB should allow single observables outside of an array. This example works:
qc = QuantumCircuit(12)

qc.x(range(12))
qc.h(range(12))

for kk in range(12 // 2, 0, -1):
    qc.ch(kk, kk - 1)
for kk in range(12 // 2, 12 - 1):
    qc.ch(kk, kk + 1)

op = SparsePauliOp('Z'*12)

pubs = [(qc, [op])]

options = {
    "default_precision": 0.1,
    "execution_mode": "batch",
}

# Run the function
job = qesem_function.run(
   pubs=pubs,
   instance=IQP_INSTANCE,
   backend_name = BACKEND,
   options=options,
)


Validate ECDH keys

Go 1.24 removed some ECDH key checks from the crypto/ecdh package and moved them to crypto/internal/fips/ecdh: https://github.com/golang/go/commit/566cf1c1083b26d4a15b94213c21142ecd9a8ca9#diff-e9f4458b20e24935551d73dc6b34e4007d91ca35e1e2c5b4d1e9f2a738d04e9cL79.
This means that the checks are no longer run in the the crypto backend layer, so we must instruct OpenSSL to perform that checks.
https://github.com/golang/go/commit/566cf1c1083b26d4a15b94213c21142ecd9a8ca9 also refactored the ECDH implementation so that ecdh.PrivateKey.Public is no longer lazy loaded, but generated when ecdh.NewPrivateKey is called. Following suite here, as it simplifies our implementation and makes key validation easier.

@derekparker the fix in this PR is blocking our upstream sync process. Could you take a look? Thanks.

For https://github.com/microsoft/go/issues/1416.


benchmark_model tool get Failed to apply XNNPACK delegate error.

Click to expand!
Issue Type
Bug
Source
source
Tensorflow Version
tf 2.8
Custom Code
No
OS Platform and Distribution
Android 11
Mobile device
android_arm64
Python version
No response
Bazel version
4.2.1
GCC/Compiler version
7.5.0
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
Following this guide,I successfully compiled benchmark_model tool.
It's ok when I run this cmd adb shell /data/local/tmp/benchmark/benchmark_model --graph=/data/local/tmp/benchmark/model.tflite --num_threads=1 --num_runs=1000. But when I add --use_xnnpack=true, I getting shuch error:
STARTING!
Log parameter values verbosely: [0]
Graph: [pruning_model.tflite]
Use xnnpack: [1]
Loaded model pruning_model.tflite
INFO: Initialized TensorFlow Lite runtime.
INFO: Created TensorFlow Lite XNNPACK delegate for CPU.
XNNPACK delegate created.
Failed to apply XNNPACK delegate.
Benchmarking failed.

I tried to compile again with the following command, but it didn't work.
bazel build -c opt --config=android_arm64 --define tflite_with_xnnpack=true tensorflow/lite/tools/benchmark:benchmark_model
or
bazel build -c opt --config=android_arm64 --define tflite_with_xnnpack=true --define xnn_eable_qs8=true tensorflow/lite/tools/benchmark:benchmark_model

Standalone code to reproduce the issue
Post-training quantization cod

convert = tf.lite.TFLiteConverter.from_keras_model(model)
convert.optimizations = [tf.lite.Optimize.EXPERIMENTAL_SPARSITY]
convert.representative_dataset = representative_dataset
tflite_quant_model = convert.convert()

Relevant log output
STARTING!
Log parameter values verbosely: [0]
Graph: [pruning_model.tflite]
Use xnnpack: [1]
Loaded model pruning_model.tflite
INFO: Initialized TensorFlow Lite runtime.
INFO: Created TensorFlow Lite XNNPACK delegate for CPU.
XNNPACK delegate created.
Failed to apply XNNPACK delegate.
Benchmarking failed.

Maybe the problem is that my model contains ZeroPadding2D and GlobalAveragePooling2D layer. It works well when I remove these two layers.reference here


Rename EventReader::iter

          Agreed. I am also in favor of renaming `.iter()` to something clearer like `.read()`. Having a function named `.iter()` that modifies state has always rubbed me the wrong way.

Originally posted by @JoJoJet in https://github.com/bevyengine/bevy/pull/9583#pullrequestreview-1597040569

One objection I foresee is that calling it 'read' also implies a read-only operation. However, read being a stateful operation is idiomatic rust: see std::io::Read as one example.

Issue has been resolved by #9631 and could therefore be closed


Support for two different model grid backends

Imagine you wish to model the composite spectrum from, say, a star and a brown dwarf, or a star and a transiting planet.  The composite model may require two different pre-computed model grid backends.  Presently, the framework assumes that there exists a sole, unique emulator.
I don't think it's too hard to implement this.  Here is a path of low resistance:

Run grid.py --create, pca.py --create, etc as normal
Manually modify your config to your new backend
Re-run grid.py --create, pca.py --create, etc
In your output/ directory where you'll run star_mix.py make a new config that has additional path arguments:

PCA:
path1: phoenix_demo.hdf5
path2: brown_dwarf_demo.hdf5

Make additional updates to your config as needed (e.g. new Theta parameters)
Modify the initialize() in the Order class to posses new attributes: self.emulator2 and more
Update your evaluate and update_theta functions.

Update: I made a demo of this functionality a few months ago-- it worked!  I haven't used it since, but it's indeed possible, following the scheme I described above.  Cheers.

The new api (on refactor/core-numpy) fully supports this for single-order cases. Each SpectrumModel requires an emulator backend, so you would just specify two models with different emulators and combine the outputs for MLE afterwards e.g.
F_star = SpectrumModel(emulator=F_emu, ...)
dwarf = SpectrumModel(emulator=dwarf_emu, ...)
F_flux, F_cov = F_star()
dwarf_flux, dwarf_cov = dwarf_star()
final_flux = F_flux + dwarf_flux
# Continue with MLE from here


Skellett refuses to connect to Skungee

Minecraft: 1.13.2
BungeeCord: 1396
Skungee: 1.0.8, 1.0.9 & 1.0.9a
Skellet: 1.9.6b
Issue:
Installed Skungee and Skellett, configured both to run on the correct ports. Skellett server refuses to connect on localhost, so I tried <IP_ADDRESS>, <IP_ADDRESS> and my server's public IP. None worked, all threw this error
07.02 14:55:42 [Server] INFO [Skellett] Incorrect SkellettProxy details, No socket found or was denied access. For socket at <IP_ADDRESS>:1337
07.02 14:55:42 [Server] ERROR [Skript] If you're 100% sure your details are correct, this can be caused because some server's want a number host rather than localhost. Try inserting <IP_ADDRESS> or <IP_ADDRESS> instead of localhost. Error:
07.02 14:55:42 [Server] INFO [Skellett] Attempting to reconnect and fix myself...
07.02 14:55:42 [Server] WARN java.io.EOFException
07.02 14:55:42 [Server] WARN at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2960)
07.02 14:55:42 [Server] WARN at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1540)
07.02 14:55:42 [Server] WARN at java.io.ObjectInputStream.readObject(ObjectInputStream.java:431)
07.02 14:55:42 [Server] WARN at com.gmail.thelimeglass.Sockets.connect(Sockets.java:69)
07.02 14:55:42 [Server] WARN at com.gmail.thelimeglass.Sockets$1.run(Sockets.java:27)
07.02 14:55:42 [Server] WARN at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftTask.run(CraftTask.java:81)
07.02 14:55:42 [Server] WARN at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:392)
07.02 14:55:42 [Server] WARN at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:889)
07.02 14:55:42 [Server] WARN at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:417)
07.02 14:55:42 [Server] WARN at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:831)
07.02 14:55:42 [Server] WARN at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:729)
07.02 14:55:42 [Server] WARN at java.lang.Thread.run(Thread.java:748)
07.02 14:55:42 [Server] WARN java.net.BindException: Address already in use (Bind failed)
07.02 14:55:42 [Server] WARN at java.net.PlainSocketImpl.socketBind(Native Method)
07.02 14:55:42 [Server] WARN at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
07.02 14:55:42 [Server] WARN at java.net.ServerSocket.bind(ServerSocket.java:375)
07.02 14:55:42 [Server] WARN at java.net.ServerSocket.<init>(ServerSocket.java:237)
07.02 14:55:42 [Server] WARN at java.net.ServerSocket.<init>(ServerSocket.java:128)
07.02 14:55:42 [Server] WARN at com.gmail.thelimeglass.Sockets$1$1.run(Sockets.java:34)
07.02 14:55:42 [Server] WARN at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftTask.run(CraftTask.java:81)
07.02 14:55:42 [Server] WARN at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:52)
07.02 14:55:42 [Server] WARN at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
07.02 14:55:42 [Server] WARN at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
07.02 14:55:42 [Server] WARN at java.lang.Thread.run(Thread.java:748)

Also tried on port 7801
07.02 15:04:06 [Server] INFO [Skellett] SkellettProxy connection established on port 7800
07.02 15:04:06 [Server] INFO [Skellett] Incorrect SkellettProxy details, No socket found or was denied access. For socket at <IP_ADDRESS>:7801
07.02 15:04:06 [Server] ERROR [Skript] If you're 100% sure your details are correct, this can be caused because some server's want a number host rather than localhost. Try inserting <IP_ADDRESS> or <IP_ADDRESS> instead of localhost. Error:
07.02 15:04:06 [Server] INFO [Skellett] Attempting to reconnect and fix myself...
07.02 15:04:06 [Server] INFO [Skellett] Bungeecord went offline. Attempting to reconnect...
07.02 15:04:06 [Server] WARN java.io.EOFException
07.02 15:04:06 [Server] WARN at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2960)
07.02 15:04:06 [Server] WARN at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1540)
07.02 15:04:06 [Server] WARN at java.io.ObjectInputStream.readObject(ObjectInputStream.java:431)
07.02 15:04:06 [Server] WARN at com.gmail.thelimeglass.Sockets.connect(Sockets.java:69)
07.02 15:04:06 [Server] WARN at com.gmail.thelimeglass.Sockets$1.run(Sockets.java:27)
07.02 15:04:06 [Server] WARN at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftTask.run(CraftTask.java:81)
07.02 15:04:06 [Server] WARN at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:392)
07.02 15:04:06 [Server] WARN at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:889)
07.02 15:04:06 [Server] WARN at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:417)
07.02 15:04:06 [Server] WARN at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:831)
07.02 15:04:06 [Server] WARN at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:729)
07.02 15:04:06 [Server] WARN at java.lang.Thread.run(Thread.java:748)
07.02 15:04:06 [Server] INFO [Skellett] SkellettProxy connection established on port 7800
07.02 15:04:06 [Server] INFO [Skellett] Incorrect SkellettProxy details, No socket found or was denied access. For socket at <IP_ADDRESS>:7801

the Bungee server and it's child servers are all on the same machine, no configurations work. Is this project abandoned? Doesn't seem to work well.

SkellettProxy is not Skungee, Skungee is a universal plugin for both Spigot and Bungeecord. Set the SkellettProxy option to false and use Skungee on the Spigot servers. The main Skungee thread tells you all about how to setup Skungee.

How about you make that clear in your posts?
"Oh yeah, this IS NOT SkelletProxy and has a different installation method."


-l flag only for rule completion

Would it be possible to add a new log flag to only print out which rules have been completed? I understand that if the -vo flag is included in the validate command then completed rules are signaled in stdout under the "Level 100" logs but I'm unaware right now of a way to only print these as no -l value exists in the README which corresponds to Level 100.
The validation is currently being slowed down significantly for me by the added time the many INFO logs are taking to print to stdout and the only output I'm really interested in is knowing when rules have been completely validated.

if you don't specify the -l flag at all and only specify the -vo flag only the rule completion logs should appear @jamesformedix

For example when I run python core.py validate -s sdtmig -v 3-4 -d /mnt/c/Users/NicHaydel/workspace/cdisc-rules-engine/XPT --disable-progressbar -vo I only see rule completion logs. I will test with the executable now

@jamesformedix @alexfurmenkov I have noticed that this is only an issue on windows. I will have a patch PR up shortly

PR: https://github.com/cdisc-org/cdisc-rules-engine/pull/216


Launch template block_device_mapping not working

Description
I have EKS on version "18.29.0" and need to upgrade to the latest.
I created launch template:
resource "aws_launch_template" "play_k8s_apps" {
  name_prefix             = "play-k8s-apps-"
  image_id                = "ami-04bf865d65956a33a"
  disable_api_termination = false
  disable_api_stop        = false
  update_default_version  = true

   block_device_mappings {
    device_name = "/dev/xvda"
    ebs {
      volume_size = 30  # size in GiB
      volume_type = "gp2"
      delete_on_termination = true
    }
  }

  tag_specifications {
    resource_type = "instance"
    tags = {
      "Environment" = "play"
      "Name"        = "play-k8s-apps"
    }
  }

  tag_specifications {
    resource_type = "network-interface"
    tags = {
      "Environment" = "play"
      "Name"        = "play-k8s-apps"
    }
  }

  tag_specifications {
    resource_type = "volume"
    tags = {
      "Environment" = "play"
      "Name"        = "play-k8s-apps"
    }
  }

  metadata_options {
    http_endpoint               = "enabled"
    http_protocol_ipv6          = "disabled"
    http_put_response_hop_limit = 2
    http_tokens                 = "required"
    instance_metadata_tags      = "disabled"
  }

  monitoring {
    enabled = true
  }

  vpc_security_group_ids = [
    "sg-043d6a926f1686b35"
  ]

  tags_all = {
    "Environment" = "play"
  }
}

Also my AWS EKS cluster:
module "smg_auto_play_eks" {
  source    = "terraform-aws-modules/eks/aws"
  version   = "19.15.3"

  cluster_name    = "smg-auto-play"
  cluster_version = "1.25"

  cluster_endpoint_private_access = true
  cluster_endpoint_public_access  = true

  create_kms_key = false

  cluster_encryption_config = {
      provider_key_arn = aws_kms_key.smg_auto_play_eks.arn
      resources        = ["secrets"]
  }

  vpc_id     = module.smg_auto_play_vpc.vpc_id
  subnet_ids = module.smg_auto_play_vpc.private_subnets

  node_security_group_additional_rules = {
    ingress_self_all = {
      description = "Node to node all ports/protocols"
      protocol    = "-1"
      from_port   = 0
      to_port     = 0
      type        = "ingress"
      self        = true
    }

    egress_all = {
      description      = "Node all egress"
      protocol         = "-1"
      from_port        = 0
      to_port          = 0
      type             = "egress"
      cidr_blocks      = [var.default_route]
      ipv6_cidr_blocks = ["::/0"]
    }
  }

  eks_managed_node_groups = {

    play-k8s-apps-2 = {
      use_custom_launch_template = true
       launch_template = {
         id      = aws_launch_template.play_k8s_apps.id
         version = aws_launch_template.play_k8s_apps.latest_version
     }
      min_size       = 2
      max_size       = 2
      desired_size   = 2
      instance_types = ["t3.small"]

    }
  }

  # aws-auth configmap
  manage_aws_auth_configmap = true

  aws_auth_roles = [
    {
      rolearn  = "arn:aws:iam::994442530941:role/AWSReservedSSO_AWSAdministratorAccess_7943eed9a8407aaa"
      username = "AWSReservedSSO_AWSAdministratorAccess_7943eed9a8407aaa"
      groups   = ["system:masters"]
    },
    {
      rolearn  = "arn:aws:iam::994442530941:role/AWSReservedSSO_AutomotiveplayDeveloper_04492fefd2dc7279"
      username = "AWSReservedSSO_AutomotivePlayDeveloper_04492fefd2dc7279"
      groups   = ["developers"]
    }
  ]

  aws_auth_users = [
    {
      userarn  = "arn:aws:iam::994442530941:user/ga-terraform-access"
      username = "ga-terraform-access"
      groups   = ["system:masters"]
    }
  ]

  tags = {
    Environment = var.environment
  }
}

But it creates only resources with tags, not instances with 30gb, instead with default one with 20gb.
Is there some solution ?

Your block_device_mappings should be working with this approach :
...
    block_device_mappings = {
      xvda = {
        device_name = "/dev/xvda"
        ebs = {
          volume_type = "gp3"
          volume_size = 100
        }
      }
    }
...

just coming back around to this - so I don't think there is anything we can do here
The device_name is optional - but what I suspect folks are running into is that they want the root volume to be changed based on these configs provided. In order for that to take place, you need to match the device name in your config with the device name of the AMI's root volume
However this will vary, and some AMIs have multiple volumes (i.e. - Bottlerocket has a root volume and a separate data volume on the AMI they provided). So with that, I don't see any code changes that we can or will make here for this, but if I am missing something, please let me know


Corrected bug in clearBit

The default implementation of clearBit also clears
the bits to the left of the one passed as
parameter. The solution is to give an explicit
implementation.
Also, a quickCheck for clearBit has been added.

Manually merged, see commit 0aff564ed45ea7ea334a55c38e8464a71763717e. Sorry for taking so long, thanks again!


🦄 Update to the jenkins helm chart to remove external image 🔥

🦄 Update to the jenkins helm chart to remove external image 🔥

LGTM :)


Remove deprecated constructors and methods in ide module

I don't see any problem with PR. I started a CI run just to see if there are any failures.

These two tests seem to consistently fail:

BuildProgressCrossVersionSpec.generates download events during maven publish [3.4.1 -> current]
BuildProgressCrossVersionSpec.generates download events during maven publish [current -> current]

Not sure why but I'll look into it.


yt-dlg 1.8.3 .rpm on openSUSE - Live Stream Bug

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

WARNING
All invalid issues will be rejected!!
Before going further

If your problem is a bug with youtube-dl or a request for new site support please report it here

Make sure you are using the latest yt-dlg version (Click the Settings icon and then About to view the current version)

Make sure you are using the latest youtube-dl version (Click the Settings icon and then Update to update to the latest youtube-dl version)

Make sure you searched the bugtracker for similar issues including closed ones

Make sure to read the FAQs file

[x ] I think my problem is NOT with youtube-dl
[x ] I've verified and i assure that I'm running yt-dlg 1.X.Y
[x ] I assure that i am using the latest version of youtube-dl
[x ] Searched bugtracker
[x ] I've read the FAQs file

What is the purpose of your issue?

[ x] Bug report
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Bug report
If the problem occurs when downloading a URL please provide the full verbose output as follows:

Restart yt-dlg
Go to Options > Extra tab
Enable Debug youtube-dl
Go to Options > Advanced tab and Clear your log content
Try to download the URL
Copy the whole log content and insert it between the ``` part below

2022-12-18 13:38:34,301-DEBUG-Worker_1-[debug] Command-line config: ['--newline', '-i', '--restrict-filenames', '-o', '/home/ralph/%(title)s-%(id)s.ts', '-v', '--ignore-config', '--downloader', 'ffmpeg', '--hls-use-mpegts', '--no-part', 'https://www.cbsnews.com/live/']
2022-12-18 13:38:34,301-DEBUG-Worker_1-[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8 (No ANSI), error utf-8 (No ANSI), screen utf-8 (No ANSI)
2022-12-18 13:38:34,302-DEBUG-Worker_1-[debug] yt-dlp version 2022.11.11 [8b64402] (zip)
2022-12-18 13:38:34,302-DEBUG-Worker_1-[debug] Python 3.10.8 (CPython x86_64 64bit) - Linux-6.0.10-1-default-x86_64-with-glibc2.36 (OpenSSL 1.1.1s  1 Nov 2022, glibc 2.36)
2022-12-18 13:38:34,302-DEBUG-Worker_1-[debug] exe versions: ffmpeg 4.4.3 (fdk,setts), ffprobe 4.4.3
2022-12-18 13:38:34,302-DEBUG-Worker_1-[debug] Optional libraries: Crypto-3.16.0, brotli-1.0.9, certifi-2022.09.24, sqlite3-2.6.0
2022-12-18 13:38:34,303-DEBUG-Worker_1-[debug] Proxy map: {}
2022-12-18 13:38:34,303-DEBUG-Worker_1-[debug] Loaded 1723 extractors
2022-12-18 13:38:34,303-DEBUG-Worker_1-[debug] [generic] Extracting URL: https://www.cbsnews.com/live/
2022-12-18 13:38:34,303-DEBUG-Worker_1-WARNING: [generic] Falling back on generic information extractor
2022-12-18 13:38:34,304-DEBUG-Worker_1-[debug] Looking for embeds
2022-12-18 13:38:34,304-DEBUG-Worker_1-[debug] Identified a Twitter card
2022-12-18 13:38:34,304-DEBUG-Worker_1-[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
2022-12-18 13:38:34,304-DEBUG-Worker_1-[debug] Default format spec: bestvideo*+bestaudio/best
2022-12-18 13:38:34,304-DEBUG-Worker_1-[debug] Invoking ffmpeg downloader on "https://cbsn-us.cbsnstream.cbsnews.com/out/v1/55a8648e8f134e82a470f83d562deeca/master_11.m3u8"
2022-12-18 13:38:34,304-DEBUG-Worker_1-[debug] ffmpeg command line: ffmpeg -y -loglevel verbose -headers 'User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.106 Safari/537.36
2022-12-18 13:38:34,305-DEBUG-Worker_1-Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
2022-12-18 13:38:34,305-DEBUG-Worker_1-Accept-Language: en-us,en;q=0.5
2022-12-18 13:38:34,305-DEBUG-Worker_1-Sec-Fetch-Mode: navigate
2022-12-18 13:38:34,305-DEBUG-Worker_1-Referer: https://www.cbsnews.com/live/
2022-12-18 13:38:34,305-DEBUG-Worker_1-Cookie: fly_device=desktop; fly_geo={"countryCode": "US", "region": "NY", "dma": "501", "connection": { "type": "broadband"}}; CBS_INTERNAL=0
2022-12-18 13:38:34,305-DEBUG-Worker_1-' -i https://cbsn-us.cbsnstream.cbsnews.com/out/v1/55a8648e8f134e82a470f83d562deeca/master_11.m3u8 -c copy -f mpegts file:/home/ralph/CBS_News_Live-master_11.ts
2022-12-18 13:38:34,305-DEBUG-Worker_1-Child process exited with non-zero code: 1

What operating system do you use ?
This report is for:
Linux openSUSE Tumbleweed
python310-yt-dlg 1.8.3-1.216
List of actions to perform to reproduce the problem:

Set up yt-dlg to use yt-dlp as CLI backend.

In Extras tab, use recommended flags to download live streams via ffmpeg:

--downloader ffmpeg --hls-use-mpegts --no-part

In Settings: Options: General: Filename format:

Choose Custom and paste this:
%(title)s %(id)s.ts
Now yt-dlg is correctly set up to download live streams as mpegts transport streams with extension .ts

Start downloading a live stream. Example live streams:

https://www.cbsnews.com/live/
https://wnetdt.lls.pbs.org/out/v1/0456457548354b88b32fc437e4e7ee01/index.m3u8
https://classicarts.akamaized.net/hls/live/1024257/CAS/master.m3u8
https://playoutengine.sinclairstoryline.com/playout/9f87522c-5a0e-4ff4-b82c-d5564216132f.m3u8
https://docubayvh.s.llnwi.net/526a07ab-6ae7-4b6c-84a1-159791416484_1000004372_HLS/manifest.m3u8
What is the expected behaviour ?
Hitting the stop button should stop the download. (It should kill both yt-dlp and ffmpeg.)
What happens instead ?
Hitting the stop button has no effect. The live stream continues to download. It must be stopped manually, using killall ffmpeg or task manager.
Note 1: This is an old bug which was never fixed on Windows, but was fixed on Linux using the os.killpg function. See this comment by original developer:
https://github.com/MrS0m30n3/youtube-dl-gui/issues/49#issuecomment-121231385
I'm NOT a coder, but maybe the reason old developer was perhaps using subprocess module is that subprocess module can be more easily killed in cases where CLI backend calls ffmpeg. If you're using the CLI backend directly from python instead of using the subprocess module, maybe that's the issue.
Note 2: In the old yt-dlg 0.4 such as Ubuntu binary 0.4-1 http://ppa.launchpad.net/nilarimogard/webupd8/ubuntu/pool/main/y/youtube-dlg/youtube-dlg_0.4-1~webupd8~disco0_all.deb , hitting the stop button works as expected. ffmpeg stops downloading the live stream.
Note 3: The above yt-dlg Ubuntu binary still works in Ubuntu 20.04 with Python 3.8. Live streams downloaded using ffmpeg are successfully killed by pressing the stop button.
Note 4: Possibly at one time a workaround was to use "Prefer Native HLS". But in 2022 with yt-dlp this is not practical for live streams. To download most live streams, you need ffmpeg. Otherwise, only a short initial segment will download. Then the download will stop.
Note 5: Your FAQs file linking to old issue number 49 has typos leading to 404s. Please change youtubet to youtube (two instances).
Thank you for your time, and best wishes for a happy holiday season!

UPDATE: A guy who wrote a GUI in Qt/C++ was able to solve the ffmpeg child process issue based on tips he found here:
https://www.baeldung.com/linux/get-process-child-processes
I don't know if that helps you with your Python GUI.

Thanks for the feedback and share the info. I will take a look 👀


Basic Example Request

Hello!
I wanted to submit a request for a very simple written guide for starting ECS from scratch with Fleks.
No need to get in to any graphics or anything.  It'd be incredibly helpful to understand how to set up the structure.
I have an idea for an ECS but can't code it up.
The game has a world.
A world has regions.
A region has locations.
Locations can have objects.
Objects can be animate or inanimate and can be moved between locations and/or manipulated/viewed.
Appreciate your consideration (and love the Youtube videos)!

Hi,
I am not 100% sure what you are trying to achieve, sorry. Do you want to write your own ECS? Or do you want to use Fleks for your described scenario?
In general, I personally wouldn't try to force everything into an ECS. From your description, I would probably design the world,regions and locations without an entity. Not exactly sure what you are trying to achieve but sounds a little bit like a Quadtree structure that you want to implement.
The objects can be entities with components if you want to go for that design.
But again, it really depends on what you are trying to achieve. Some games are more suited for ECS while others aren't IMHO. Use the approach that feels most comfortable for you.
Also, if this is just a general "discussion" then it is better to create a discussion instead of an issue ;)
But let me know if that already helped or if I understood something wrong.

Closed due to inactivity


added map-leaflet component and enable flow component

This PR includes:
Implemented Leaflet map component with Marker
Authorizable component and datasource json and tms connected.
Sample:

Please and approve it

where are the tests for this?


[GHSA-jcp9-796g-pv9p] Missing Cryptographic Step in OWASP Enterprise Security API for Java

Updates

References

Comments
Add a patch https://github.com/ESAPI/esapi-java-legacy/commit/41138fef5f63d9cf0d5e05d2bee2c7f682ffef3f, of which the commit message claims Fix for Google Issue #306 and changes to address the side effects of the fix (i.e., the removal of the deprecated ESAPI 1.4 encrypt() / decrypt() methods from the Encryptor interface).

Hey @MarkLee131, not sure I follow on this one. Can you elaborate on how you arrived at this commit?

@darakian , hi, I wonder what additional information or format you want? :(
it seems the commit msg explicitly claims it fixed the issue 306 https://github.com/ESAPI/esapi-java-legacy/issues/306. the issue is also shown in the current reference link pointing to this CVE.


Added extraction of the final frame as a slide

A frame is saved as a slide when a different frame is found after it in the video.
To save the final frame an explicit logic was added.

This looks like another bug. Could I get a reproducible bug report for that? I haven't experienced this problem so far.
Possibly something related to your last frame being a key frame?


Adding Github Action to trigger Test Suite.

Is your feature request related to a problem? Please describe.
As companies moving away from Jenkins to Github Actions for CI, thus it will be one good thing if we can have the feature of running our test suites directly from Github Actions using workflows.
Describe the solution you'd like
If some code change or merge is performed (say for eg. in the repo of some company), and that code is hosted on Github enterprise edition then its good to have the Github Actions to trigger Smoke/Regression suite automatically.
Describe alternatives you've considered
NA
Additional context

This is one is for maven project.

This is already addressed and part of the framework
https://github.com/dipjyotimetia/HybridTestFramework/blob/master/.github/workflows/gradle.yml

Closing this as this feature is already there.


get and getdata do not record the dataset from which the data was obtained

Reported by karl smith on 22 Apr 2011 17:07 UTC
get and getdata need to also return the dataset ID for the data.  For getdata, this would be the value of the "dset" key.  The ID should be the filename (esp. for CDAT integration).  Check what attribute name CDAT objects use for recording the dataset.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/1842

Comment by steven.c.hankin on 25 Apr 2011 16:28 UTC
Quick note to be alert for subtleties in this.  A variable in Ferret can have an ambiguous dataset of origin, as in
LET diff = var[- var[d=dset2](d=dset1])

which means that you cannot assume that the value of the dataset stored with a particular mvar is a pointer to a simple, named, open dataset.


Issue 2885 - Support more serial number formats and fix a couple of bugs

I struggled a little to get tests to run locally and there were a couple of consistent tag failures I did not resolve. It looks like these tests aren't run regularly, as with the latest Python the internal test package has changed structure.
Regardless, here is some tidying up of serial handling with some additional tests to expose the behaviour I wanted to achieve.
Happy to add more test cases / tidy up the code / alter the help messages as people prefer.

Looks like #1 fails as I don't have write access to the repo? I'm a couple of years out of practice with Github so this is a little new to me!

@matmair are you able to look into this re the "welcome" CI step?
@exp happy with the rest, thanks for your contribution :)

@SchrodingersGat seems to be an issue of missing permissions. I will make a PR on the weekend.


Handle recursive parameter resolution in CircuitOperation

Is your feature request related to a use case or problem? Please describe.
Child of #3235.
CircuitOperation implicitly relies on single-step parameter resolution for its internal parameter mappings. This is inconsistent with the default behavior of ParamResolver, which is to resolve parameters recursively (see PR #3538).
Describe the solution you'd like
CircuitOperation should accept resolve_parameters(..., recursive=True) and handle it in a manner consistent with ParamResolver (within reason).
[optional] Describe alternatives/workarounds you've considered
Disabling recursive resolution for CircuitOperation (current behavior)
Changing default resolution behavior to single-step
What is the urgency from your perspective for this issue? Is it blocking important work?
P2 - we should do it in the next couple of quarters

Discussed at cirq cync. Default to single step and keep the error message would be a minor breaking change but the behavior would be most predictable

Discussed at cirq cync. Default to single step and keep the error message would be a minor breaking change but the behavior would be most predictable

Would it be better to have the handlers for parameter resolution be _resolve_parameter_ (singular) that takes a single kvp, and the calling protocol function itself responsible for the looping? Also possibly should parameters be specified as a kvp sequence instead of a dictionary, so that the ordering is explicit? (Granted python 3.6 and up dictionaries are ordered, but still).

I was thinking this would be a quick fix, but I assume it's not or it would've been done already. Do you have any thoughts on the matter that you can note here?
By recursive does that mean it would have to recur through the subcircuit operations, or does it just mean recurring through the local symbols of the CircuitOperation, (or does it mean both)?

I was thinking this would be a quick fix, but I assume it's not or it would've been done already. Do you have any thoughts on the matter that you can note here?

I haven't looked at this in a while, but discussion on #3538 demonstrates why this is potentially complicated. In summary:

CircuitOperation currently expects single-step resolution (e.g. {a: b, b: a} maps a to b and b to a)
This is in direct conflict with recursive resolution behavior (where {a: b, b: a} throws an infinite-loop error)
Changing over in a backwards-compatible way potentially affects many _resolve_parameters_ calls

A breaking change could probably resolve this; at the time, we opted to keep things stable. You're welcome to take a look, especially given #5016 (which I agree stems from this).


New flag for limiting format options to audio only

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2<IP_ADDRESS>. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2<IP_ADDRESS>

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[x] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
It would be nice if there was a flag for limiting downloads to audio only formats, as opposed to using the -x flag which still downloads the video then extracts audio which can lead to a consumption of data. I am not a coder so I am not telling people how to do it; but there could be 4 ways of deciding on the flag, first we could give it an entirely new flag, or we could replace -x with this, we move --batch-file which currently uses the flag -a to like -b so the letters match, or in addition to making audio-only use -a we could improve detection of when a file is on the local machine and treat those as batch-files.

-f bestaudio.


Getting CREATE_FAILED error

Hi,
I´m trying to update some resources to my WP, but I´m getting the following error:
fsmt-XXXXXXXX already exists in stack arn:aws:cloudformation:us-east-1:XXXXXXXXXXXX:stack/awseb-X-XXXXXXXXXX-stack/XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX
This error is shown in the Cloudformation Events tab.

Sorry.
It was my mistake.


fix: useStarkProfile to work with base64 tokenURI

This PR fixes a bug in useStarkProfile which currently returns an error for Blobbert NFTs that are set as profile picture.

Looks good, I need the changeset and I'll release it. Since it's a bug fix make it a patch change.

Sorry I missed your comment last week !


BZ# 1642623 - Fix permission related display issues

Fix for BZ https://bugzilla.redhat.com/show_bug.cgi?id=1642623
@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes
@miq-bot add_label hammer/yes

@chalettu any chance we can get a ss of this in action?

Before

After

Hammer backport details:
$ git log -1
commit baa3b1cc7f37fb9446b51c86e946e7d5c9d790d0
Author: Allen Wight<EMAIL_ADDRESS>Date:   Thu Oct 25 13:35:24 2018 -0400

    Merge pull request #1484 from chalettu/sui-permissions-cleanup

    BZ# 1642623 - Fix permission related display issues

    (cherry picked from commit 04236dbc6f5f92201b58bc40f627a47b94004bcf)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1642623

Gaprindashvili backport details:
$ git log -1
commit dcec4398dbb739e2040eda63aea1c3281a9a6a88
Author: Allen Wight<EMAIL_ADDRESS>Date:   Thu Oct 25 13:35:24 2018 -0400

    Merge pull request #1484 from chalettu/sui-permissions-cleanup

    BZ# 1642623 - Fix permission related display issues

    (cherry picked from commit 04236dbc6f5f92201b58bc40f627a47b94004bcf)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649419

@simaishi  Its all good, just needed to be restarted <3

@AllenBW Thanks Allen. I restarted once, but I should have done it a few more times!

ARG REALLY!!! 😩 yah it's been known to be a 🐻 at times 🤗


IDVA6-1433 Update loggedUserAcspMemberhip to allow healthcheck

Link to Jira
https://companieshouse.atlassian.net/browse/IDVA6-1433
Updates loggedUserAcspMemberhip middleware function to ignore requests for /healthcheck

CI: No security warnings found

CI: No security warnings found


Can't search on NONE for mult fields

Mult fields are allowed to have "NULL" values, but the UI doesn't let you search on them. See Cassini planet_id for an example.

Fixed in the new import pipeline


distributed_dataset tensorflow.python.framework.errors_impl.UnavailableError: Socket closed

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Debian Buster
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): bin
TensorFlow version (use command below): 2.3.0
Python version: 3.7.7
Bazel version (if compiling from source): n/a
GCC/Compiler version (if compiling from source): n/a
CUDA/cuDNN version: n/a
GPU model and memory: TPU v3-8

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
urllib.error.URLError: <urlopen error [Errno 110] Connection timed out> in Colab,
tensorflow.python.framework.errors_impl.UnavailableError: Socket closed in GCE VM
Describe the expected behavior
Not having these errors(code ran just fine a few hours ago)
Standalone code to reproduce the issue
COLAB
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
in Colab:
Traceback (most recent call last):
  File "/usr/lib/python3.6/urllib/request.py", line 1325, in do_open
    encode_chunked=req.has_header('Transfer-encoding'))
  File "/usr/lib/python3.6/http/client.py", line 1264, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/lib/python3.6/http/client.py", line 1310, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.6/http/client.py", line 1259, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.6/http/client.py", line 1038, in _send_output
    self.send(msg)
  File "/usr/lib/python3.6/http/client.py", line 976, in send
    self.connect()
  File "/usr/lib/python3.6/http/client.py", line 948, in connect
    (self.host,self.port), self.timeout, self.source_address)
  File "/usr/lib/python3.6/socket.py", line 724, in create_connection
    raise err
  File "/usr/lib/python3.6/socket.py", line 713, in create_connection
    sock.connect(sa)
TimeoutError: [Errno 110] Connection timed out

in VM:
Traceback (most recent call last):
  File "train_gpt2.py", line 77, in <module>
    train()
  File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "train_gpt2.py", line 64, in train
    model.fit(iter(dist_dataset), graph_mode)
  File "/home/ksjcom0705_gmail_com/gpt-2-tensorflow2.0/gpt2_model.py", line 343, in fit
    (inputs, targets) = next(train_dataset)
  File "/home/ksjcom0705_gmail_com/.local/lib/python3.7/site-packages/tensorflow/python/distribute/input_lib.py", line 649, in __next__
    return self.get_next()
  File "/home/ksjcom0705_gmail_com/.local/lib/python3.7/site-packages/tensorflow/python/distribute/input_lib.py", line 706, in get_next
    global_has_value, replicas = _get_next_as_optional(self, self._strategy)
  File "/home/ksjcom0705_gmail_com/.local/lib/python3.7/site-packages/tensorflow/python/distribute/input_lib.py", line 548, in _get_next_as_optional
    iterator._iterators[i].get_next_as_list(new_name))  # pylint: disable=protected-access
  File "/home/ksjcom0705_gmail_com/.local/lib/python3.7/site-packages/tensorflow/python/distribute/input_lib.py", line 1512, in get_next_as_list
    strict=True,
  File "/home/ksjcom0705_gmail_com/.local/lib/python3.7/site-packages/tensorflow/python/util/dispatch.py", line 201, in wrapper
    return target(*args, **kwargs)
  File "/home/ksjcom0705_gmail_com/.local/lib/python3.7/site-packages/tensorflow/python/util/deprecation.py", line 507, in new_func
2020-09-19 08:05:53.047063: W tensorflow/core/distributed_runtime/eager/remote_tensor_handle_data.cc:76] Unable to destroy remote tensor handles. If you are running
 a tf.function, it usually indicates some op in the graph gets an error: Socket closed
Additional GRPC error information from remote target /job:worker/replica:0/task:0:
:{"created":"@1600502753.043380028","description":"Error received from peer ipv4:<IP_ADDRESS>:8470","file":"external/com_github_grpc_grpc/src/core/lib/surface/call.
cc","file_line":1056,"grpc_message":"Socket closed","grpc_status":14}
    return func(*args, **kwargs)
  File "/home/ksjcom0705_gmail_com/.local/lib/python3.7/site-packages/tensorflow/python/ops/control_flow_ops.py", line 1207, in cond
    if pred:
  File "/home/ksjcom0705_gmail_com/.local/lib/python3.7/site-packages/tensorflow/python/framework/ops.py", line 984, in __bool__
    return bool(self._numpy())
  File "/home/ksjcom0705_gmail_com/.local/lib/python3.7/site-packages/tensorflow/python/framework/ops.py", line 1031, in _numpy
    six.raise_from(core._status_to_exception(e.code, e.message), None)  # pylint: disable=protected-access
  File "<string>", line 3, in raise_from
tensorflow.python.framework.errors_impl.UnavailableError: Socket closed
Additional GRPC error information from remote target /job:worker/replica:0/task:0:```...

@ksjae
Please refer to this issue and let us know: #42228 #41817

@ksjae This example is too much articulated. We need something that has a smaller surface to investigate reproduce it (copy, paste and run it).
Can you share a very minimal example that we could run on colab without too much gcs or too much filesystem dependencies (e.g. dummy inputs).
Thanks

Done. Example is now minimal enough for testing (I hope).
Also, I found out that on GPUs, the code gives 'Segmentation Fault' on the very same line.

@ksjae
I ran the code shared and face a different error please find the gist here.
Please share a colab gist with the error reported in the gist.

@Saduf2019 this Is a specific nightly issue like https://github.com/tensorflow/tensorflow/issues/43254#issuecomment-693461228

I ran the notebook in the original post with tf 2.3 and was able to reproduce the error.
When I set tpu = False on a GPU runtime the session crashes. Do you see that as well?
You can see in this similar issue here  #36136 that this error message is sometimes caused from trying to cache a large dataset into memory so I'm wondering if the root cause here is an OOM issue.

I've been consistently able to reproduce this(haven't ran this for a few days though, just used another training code).
Slightly doubtful about OOMs, since I tried setting batch size from 8 and it still crashed.

I experienced this issue today with tf 2.3.
UnavailableError: Socket closed
Additional GRPC error information from remote target /job:worker/replica:0/task:0:
:{"created":"@1607389193.224325108","description":"Error received from peer ipv4:<IP_ADDRESS>:8470","file":"external/com_github_grpc_grpc/src/core/lib/surface/call.cc","file_line":1056,"grpc_message":"Socket closed","grpc_status":14}

There was no error with either CPU or GPU.
Here is a colab that reproduces the error:
https://colab.research.google.com/drive/1C09OUXP-7Es4KIthVA6daRcGq_bJKGe8?usp=sharing

@CalebEverett : Above error seems to be from user code.
Normally "UnavailableError: Socket closed" is an aftermath of an underlying error
TypeError: tensordot() got an unexpected keyword argument 'dtype'
Could you try updating call function to use correct semantics for tensordot()?

@hongjunChoi Hi, thanks for looking into this. I've taken out that dtype argument and it is still producing the same error. I must have put that in as I was trying to get it work.
The colab is updated. https://colab.research.google.com/drive/1C09OUXP-7Es4KIthVA6daRcGq_bJKGe8?usp=sharing

Was able to replicate the issue with TF v2.5,please find the gist here ..Thanks !

@ksjae Could you let us know if you tried updating the call function to use correct semantics with latest TF version and still faces this issue. Please upgrade to the latest version as older versions are not actively supported.
Thank you!


Increasing Project Scope

Spitballing an idea here: Chat + Trello + Notes all in one app.
To get a design discussion going, reply with "Yeah! And..." and add a suggestion. Then when we've gathered about 5 or 10 ideas, we can start talking about "why not" and deciding which ideas are the best to select.
"Yeah! And we could add an activity feed for people to post project/status updates!"
https://cloud.githubusercontent.com/assets/4743518/5886219/c7f7da36-a355-11e4-9519-99a7b524e0ca.png

Do we want to do this? Seems like it'd be a completely different application. Might work better its own fork.
@hhaidar / @sibartlett ?


add removeNextflowVersion function

Sorry, made a mess with my branches, so recreating the PR here, it replaces #3

is the tests/utils/nextflow.config empty file needed ?

LGTM! Maybe this can later be expanded to be able to customize which fields should be removed, but let's do that another time :p

yeah I was thinking the same, but that's a good first start already

is the tests/utils/nextflow.config empty file needed ?

yeah, otherwise nf-test/nextflow complains about it


Fix upgrade module to v4

Questions
Answers

Description?
Add required hooks and configuration values for v4 upgrade

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes https://github.com/PrestaShop/PrestaShop/issues/23218

How to test?
see issue

It seems that the upgrade file is not launched at prestashop 1.7 upgrade in some cases. So I added a default commentsPerPage in paginate method

thanks @Progi1984, can you add my 3 pr in this module to 4.2.2 version ?
This pr should fix this pr too https://github.com/PrestaShop/productcomments/pull/92
(in fact it's just a test to make)

@kpodemski is it ok now ?

@jf-viguier great, thanks 👍

Hello @jf-viguier
I'm really sorry but it seems I have an issue with installing the productcomment module v3.6.1 on <IP_ADDRESS>

I tried many times but in vain :confounded:
Ping @PrestaShop/qa-functional could someone please test this PR cause I can't.
Thanks in advance :pray:

Hi @jf-viguier,
I followed these steps:

Install PrestaShop <IP_ADDRESS>

Install module product comment 3.6.0 from GitHub

Add a comment with guest and customer

Approve those comments

Upgrade PrestaShop to PS<IP_ADDRESS> (I found that the productcomment module is upgraded to v4.2.1)

I Upgraded manually the product comment module to this PR (v4.2.2)

Go to FO

View a product with a comment

See error => No comment is displayed

Thanks to check and feedback.

@khouloudbelguith have you cleared the ps cache ?

@jf-viguier I have the same bug as @khouloudbelguith  and all cache are cleared.

There is an extra bug I guess

I'm note sure to understand 😅  so is it in the scope of the contribution ?

so is it in the scope of the contribution ?

Ping @PrestaShop/prestashop-core-developers is there any one have an idea about how to test this PR :pray:
I suggest these steps, so can someone check if these are correcte:

Install PS <IP_ADDRESS>
Install Product comments with these cmds:

cd /your-shop/modules/
git clone https://github.com/PrestaShop/productcomments.git
git checkout tags/3.6.0 -b 3.6.0
BO>Module Catalog>Click on install of Product Comments
git fetch origin pull/107/head:pr-107 && git checkout pr-107 && git reset --hard && git clean -fd && git rebase origin/dev && composer install

Create 6 comments with guests and Customers
Approve all
Upgrade the shop to <IP_ADDRESS>
Check the comments in FO

Thanks in advance :pray:

The productcomments is updated during pretashop upgrade from addons : so the code of this pr will not be launched, how to solve this @kpodemski ?

@jf-viguier hmm, you're right
I think we need to create a package for the module.

composer install
Make a .zip from the productcomments directory. And install this module after the upgrade.

@jf-viguier that should do it, right?

@kpodemski I guess no, upgrade/install-4.0.0.php of my pr has to be launched. Prestashop upgrade will upgrade the module to the version 5.

Discussed with @hibatallahAouadni about the process, she will test with this process. Thanks to her.

modules\productcomments\upgrade\install-4.0.0.php is well executed during test steps.
There are two issues with your steps @hibatallahAouadni

After prestashop upgrade, there are some missing hooks for the module (displayRightColumnProduct & displayFooterProduct):

my changes in modules\productcomments\src\Repository\ProductCommentRepository.php are deleted by prestashop upgrade, so you have to update it manually

There is still a javascript error to fix in modules\productcomments\views\templates\hook\product-additional-info-quickview.tpl (remove all script here) and then comments will whow up.
Please check @hibatallahAouadni

I've just rebased my pr

Hello @jf-viguier
After adding this hook displayFooterProduct:

All comments are well displayed and the pagination works :100:
https://user-images.githubusercontent.com/23308427/149790031-3dcc800a-19a0-42e6-9eef-ec2df259f238.mp4
LGTM, QA :heavy_check_mark:
Thanks for your hard working :rocket:

Thanks @hibatallahAouadni

Thanks @jf-viguier & @hibatallahAouadni (for the hard work QA on this PR).


Input Discriminator channels

Hi I noticed that for the discriminator inputs you have 23 channels.
Why is this? I would have thought the input would have 3 channels for each of the RGB channels in an image
Thanks

Also roughly how many epochs on the img synthesis is required before seeing reasonable results?
Ie results that match head pose and  mouth but perhaps with not all visual artificats present?
Thanks, am currently able to synthesise reasonable images but head pose eyes and mouth are all similar

It is a history experiment setting of 'additional 10 history feature maps + 1 current feature maps + 4 candidate images' as G&D input, in which case, 23 = 1 * 1 + 10 * 1 + 4 * 3 for G and add another 3 channels into 26 for D. That didn't work. In my final version, I just use the current feature map as input.
I didn't check these training-related codes carefully and these may confuse you. So, you should set the input channels of D equal to channels of G plus 3.
Training such an image2image translation network is not hard, I believe. I think ~10 epoches is enough to synthesize plausible results. If you don't, check whether there are bugs between the input feature maps and the corresponding groundtruth.
Hope the above helps.

Thank you! I think my error was simply feeding in the generated images to the discriminator without the sample images + landmarks mask.
Finally do results improve if concatenating the landmark masks for the candidate images along with the target land mark mask ie: providing information of how heads should appear given a specific landmark mask?
Thanks again I very much appreciate your assistance

I'm wondering what is the targe landmark image? The renderer's task is to build a mapping from a feature map to a target image, and therefore the landmark image should be the landmarks of the target image.

Apologies for lack of clarity,
Currently I am inputting the 4x sample images + the 1 channel landmark target mask with the landmarks connected with lines for a total of 13 channels.
Would adding the landmark masks for each sample image as well as the target landmark mask increase the model capacity to learn as it would "see" how the image should vary with changes in headpose etc


Firebase deploy with NextJS peer dependencies issues

As stated in the title, when running Firebase deploy on a NextJS app with peer dependency issues, the command fails with the expected unable to resolve dependency tree. Is there a way to pass in the --legacy-peer-deps flag to this command?
EDIT: tried adding an npmrc file to the root of the project but it does not get added to the functions directory built from the deploy command

found some tips, this is often related to the dependencies not being installed, you can re-install the packages to a specific version and append the command onto it npm add xxxx --legacy-peer-deps
another, if this is related to react, is to install a specific version of React and facilitate tree shaking where needed. this could apply to other packages but from my search, it seems to be an issue with older React libraries designed for node 7 and older.

found some tips, this is often related to the dependencies not being installed, you can re-install the packages to a specific version and append the command onto it npm add xxxx --legacy-peer-deps
another, if this is related to react, is to install a specific version of React and facilitate tree shaking where needed. this could apply to other packages but from my search, it seems to be an issue with older React libraries designed for node 7 and older.

Thanks for the response. The issue with these solutions is that running ‘firebase deploy’ on a NextJS app will automatically build the functions folder and deploy. So any attempt to modify package.json or the npm flags gets overwritten immediately.
Unfortunately in my scenario this is not an app that I have written and has dozens of peer dependency issues from the previous developers, so changing the version of React won’t solve the issue either.
There should be a way to specify a flag or something on the firebase deploy command to insert your own npm config

Interesting, probably worth us copying over any npmrc

Interesting, probably worth us copying over any npmrc into the code generated Cloud Function

@jamesdaniels thanks. Is there a timeline for this update?

I'm also experiencing this issue with deploying NextJS

npmrc is copied over in a recent release


[LGO] Add LGO exchange support

Add support for LGO HTTP API and LGO authentication.
https://lgo.group/
For now, only metadata, auth, trade history and order signature are supported, because the websocket API should be favored for any trading activity (lowest possible latency).
For websocket support, we are currently working on xchange-stream LGO support.

See https://github.com/knowm/XChange/pull/3117 for the sl4j version downgrade in our implementation

@walec51 I made the requested fixes. Thanks a lot for your review !

Thanks @walec51 for your help reviewing!


an IllegalStateException 'Couldn't get domain from email address' in account setup

Describe the bug
Sorry for my second issue, but I did find another crash caused by an IllegalStateException 'Couldn't get domain from email address'. As I used the automated testing tools, the value set to email account and password are random and I did not know them exactly. Immediately after I click on 'MANUAL SETUP' or 'NEXT' to continue, the error occured and the app crashed.
To Reproduce
Steps to reproduce the behavior:

Go to page 'Set up a new account'
Edit the email address and password, both are set to random values
Click 'MANUAL SETUP' and enter page 'Account type'
Click 'IMAP' and the app crashes

Environment (please complete the following information):

K-9 Mail version: 5.734
Android version: 6.0
Device: x86 Android emulator provided by Google
Account type: IMAP

Logs
06-26 20:26:47.430 24599 24599 E AndroidRuntime: FATAL EXCEPTION: main
06-26 20:26:47.430 24599 24599 E AndroidRuntime: Process: com.fsck.k9, PID: 24599
06-26 20:26:47.430 24599 24599 E AndroidRuntime: java.lang.IllegalStateException: Couldn't get domain from email address
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at com.fsck.k9.activity.setup.AccountSetupAccountType.setupStoreAndSmtpTransport(AccountSetupAccountType.kt:66)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at com.fsck.k9.activity.setup.AccountSetupAccountType.setupAccount(AccountSetupAccountType.kt:60)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at com.fsck.k9.activity.setup.AccountSetupAccountType.setupPop3Account(AccountSetupAccountType.kt:52)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at com.fsck.k9.activity.setup.AccountSetupAccountType.access$setupPop3Account(AccountSetupAccountType.kt:24)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at com.fsck.k9.activity.setup.AccountSetupAccountType$onCreate$1.onClick(AccountSetupAccountType.kt:39)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at android.view.View.performClick(View.java:5198)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at android.widget.TextView.performAccessibilityActionInternal(TextView.java:8999)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at android.view.View.performAccessibilityAction(View.java:8883)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at android.view.AccessibilityInteractionController.performAccessibilityActionUiThread(AccessibilityInteractionController.java:668)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at android.view.AccessibilityInteractionController.-wrap6(AccessibilityInteractionController.java)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at android.view.AccessibilityInteractionController$PrivateHandler.handleMessage(AccessibilityInteractionController.java:1194)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:102)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:148)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:5417)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
06-26 20:26:47.430 24599 24599 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Does your tool take the enabled state of buttons into account? The "Next" and "Manual setup" buttons in the "Set up a new account" screen should not be enabled unless a valid email address has been entered.
Have you been able to manually reproduce the error?

Yes, my tool can recognize that, and it cannot click on the Button "Next" and "Manual setup" when the password and email address are empty, or no '@' in email address.
I tried to reproduce the error, manually and via the testing framework 'uiautomator' my tool uses, but both of them failed. From this, I guess there may be a special app state where Button "Next" and "Manual setup" is enabled even though the inputs are illegal, however, I don't know how to get into this state.

Closing because there are no instructions on how to reproduce the issue. You're welcome to open a new issue once you can provide the instructions.


Don't assume CommissionerIdTlv always uses max length.

This is a bug we found when working on getting the ThreadGroup's Android commissioner app to talk with OpenThread.

Current coverage is 72.85% (diff: 100%)

Merging #952 into master will increase coverage by 0.80%

@@             master       #952   diff @@
==========================================
  Files           117        118     +1
  Lines         17551      17561    +10
  Methods        2442       2446     +4
  Messages          0          0
  Branches       2120       2120
==========================================
+ Hits          12645      12794   +149
+ Misses         4209       4071   -138
+ Partials        697        696     -1

Powered by Codecov. Last update 67dbbfc...f04b4d2


refactor: Rename irest and istoredp transports

Resolves #101

Can you resolve the conflicts?

Can you resolve the conflicts?

Fixed


Warnings when used in Xcode 8.3.1

Just remove the line
 *  @param treeNodeInfo Object including additional information about item.
from the comments of the functions, as this parameter is not used (any more).


feature: add support for segmentio-kafka

Summary
segmentio-kafka is a lightweight Kafka library in Go.

[x] Update the docs.
[x] Pass CI test.
[x] Pass Plugin test.

Test Report

Ref https://github.com/apache/skywalking/pull/12027

Please fix lint and stuff, thanks

ALLOW_PLAINTEXT_LISTENER: yes

services.kafka-server.environment.ALLOW_PLAINTEXT_LISTENER contains true, which is an invalid type, it should be a string, number, or a null

It seems that docker-compose v2 has been verified. I'll correct it.

Updated.

dependency failed to start: container gin-service-1 exited (127)
WORK=/tmp/go-build4103001024
# text/template/parse
runtime: newstack sp=0xc00004ff90 stack=[0xc000d[700](https://github.com/apache/skywalking-go/actions/runs/8313025290/job/22748663526?pr=176#step:7:701)00, 0xc000d78000]
	morebuf={pc:0x7ffd347e6bb2 sp:0xc00004ffa0 lr:0x0}
	sched={pc:0x44b80b sp:0xc00004ff98 lr:0x0 ctxt:0x0}
runtime: gp=0xc0000bd6c0, goid=39, gp->status=0x2
 runtime: split stack overflow: 0xc00004ff90 < 0xc000d70000
fatal error: runtime: split stack overflow

BTW, do we need to test plugin separately on macOS?


Add --random_selfplay option to play 1 game with random agents, which

shows a bug - the moves made ("Player XXX played MOVE") always
have increasing indices.
Sample output:
python -u main.py --random_selfplay
...
Player o rolled <6, 4>.
Player o played** ((16, 20), (0, 6))**                                              <-- note increasing indices
| 12 | 13 | 14 | 15 | 16 | 17 | 18 | 19 | 20 | 21 | 22 | 23 |
| -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- |
|  x |    |    |    |  o |    |  o |    |  o |    |    |  x |
|  x |    |    |    |  o |    |  o |    |    |    |    |  x |
|  x |    |    |    |    |    |  o |    |    |    |    |    |
|  x |    |    |    |    |    |  o |    |    |    |    |    |
|  x |    |    |    |    |    |  o |    |    |    |    |    |

|  o |    |    |    |    |    |  x |    |    |    |    |    |
|  o |    |    |    |    |    |  x |    |    |    |    |    |
|  o |    |    |    |  x |    |  x |    |    |    |    |    |
|  o |    |    |    |  x |    |  x |    |    |    |    |    |
|  o |    |    |    |  x |  o |  x |    |    |    |    |  o |
| -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- |
| 11 | 10 |  9 |  8 |  7 |  6 |  5 |  4 |  3 |  2 |  1 |  0 |
<Player x>  Off Board :     Bar :
<Player o>  Off Board :     Bar :
Player x rolled <5, 1>.
Player x played **((7, 8), (8, 13))**                <-- this player also has increasing indices
...

Thanks for the PR! I think this is correct (per your email) but I'll need to test it. I'll try to review and test before the end of the week.


Not working

Hi,
I have added tiff-viewer extension in my google chrome [Version 57.0.2987.110 (64-bit)],  but it is not working on chrome in ubuntu platform. I even tried it on Windows, still the issue persists.
I am attaching code as well. Please let me know how can tiff images be displayed on chrome?
tiff files.zip

I will try to look into it tomorrow. Sorry for the late answer, it's the drawback with full time contracts :)

Sorry for the wait @mhammadpk ...
This appears to work now: http://link.my-codeworks.com/l57a/Screen Shot 2017-06-17 at 23.59.12 .png
Tested using the official version installed from Chrome's store, on Chrome ofc :)
Loading it took quite a while though, not sure why. Test it out and get back to me.

@mhammadpk can you confirm if this is still an issue?

Still not working on Chrome  browser.
Please try the code that I have posted in this thread.


GridView, can you help to provide freeze pane function?

Dear Yii2 Team,
Some grid widget can provide freeze top header function. However, I do not find any Yii2 grid can help to freeze left columns function.
Do you have a plan to enable GridView to provide function to freeze first several columns when scroll to right, just like excel freeze pane? thanks.
Regards,
Scott Huang

This relies on some combination of CSS and JS, perhaps defining a fixed height for the table, etc. I think this current of GridView (with no gridview.js) is more about a native HTML table. This one could benefit from improvements provided by other plugins like DataTables.
With this in mind, should GridView include these features? Any, following a CSS only proposal, which looks mostly good when background is set for the cells (used Bootstrap to aid on general styling) https://codepen.io/glpzzz/pen/GRbLaGo
If this is accepted as expected result for "fixed header" I can create the PR to add the required options to the GridView widget.

I can create the PR to add the required options to the GridView widget.

Seems, this feature require to add CSS classes only, isn't it?
What options are needed?

What options are needed?

fixedHeader as a boolean. If true, it adds the required CSS. I also need to add something like heightWhenFixedHeader, but I don't like having 2 attributes for the same thing.
I also don't like making fixedHeader accept the height instead of the boolean. It's not "semantic".
But yes, the idea is to add some attribute to GridView that flags the addition of the CSS shown in the codepen.

So, we need methods that enable/disable fixing and methods that configure fixing (set of CSS classes and/or CSS styles). Right?
In app we can globally configure grid view (set of CSS classes) and in concrete grid view set what should be fixed.

I'm still not sure if those options should be implemented in this GridView when there are other options already with those features. I don't think that the CSS only solution is completely good.
This is my reference, at least for fixed headers:

https://datatables.net/examples/basic_init/scroll_y.html
https://datatables.net/examples/basic_init/scroll_xy.html

Are we trying to achieve something like that?

No. Something like this: https://codepen.io/chriscoyier/pen/PrJdxb

This package provide HTML code only. CSS/JS should be added by user or other package.

Then closing this one.

It can be implemented as set of methods:

Methods that set freeze columns/rows/header/footer. For example freezeHeader() or freezeTopRows(2).

Methods that set freeze classes. For example, freezeConfiguration(FreezeConfiguration $configuration); where FreezeConfiguration is PHP class with HTML classses for header/footer/row/column/table when freeze is enabled.

Considering that the core of the solution is provided via CSS, I think the current implementation is doing enough by allowing to set ID and/or classes for the widget.
That way, it's easy to define the freezing style for the #gridview1 or all the grid views with a certain class.


swagger documentation

Hi,
How can I add more definition and path in Swagger controllers?
Also I can see Error at the bottom of page and when click on it give following error
[
    {
        "level": "error",
        "message": "Can't read from file http://vmcms.local/api/swagger"
    }
]

Please find attached screenshot

and json response is as bellow
{
    "swagger": "2.0",
    "info": {
        "description": "API documentation for CI Bootstrap 3",
        "version": "v1",
        "title": "CI Bootstrap 3 API",
        "termsOfService": "",
        "contact": [],
        "license": []
    },
    "host": "vmcms.local/",
    "basePath": "api/v1",
    "schemes": [
        "http"
    ],
    "externalDocs": [],
    "tags": [
        {
            "name": "user123",
            "description": "(For demo only)"
        },
        {
            "name": "user",
            "description": "(For demo only)"
        }
    ],
    "definitions": {
        "User": {
            "type": "object",
            "properties": {
                "id": {
                    "type": "integer",
                    "format": "int32",
                    "description": "Unique ID"
                },
                "name": {
                    "type": "string"
                }
            }
        }
    },
    "securityDefinitions": [],
    "paths": {
        "/users": {
            "get": {
                "tags": [
                    "user"
                ],
                "summary": "Get list of users",
                "description": "",
                "parameters": [
                    {
                        "name": "status",
                        "in": "query",
                        "description": "Filter by user status",
                        "required": false,
                        "collectionFormat": "csv",
                        "type": "array",
                        "items": {
                            "type": "string",
                            "enum": [
                                "active",
                                "hidden"
                            ]
                        }
                    },
                    {
                        "name": "tags",
                        "in": "query",
                        "description": "Filter by user tags",
                        "required": false,
                        "collectionFormat": "csv",
                        "type": "array",
                        "items": {
                            "type": "string"
                        }
                    }
                ],
                "responses": {
                    "200": {
                        "description": "successful operation",
                        "schema": {
                            "type": "array",
                            "items": {
                                "$ref": "#/definitions/User"
                            }
                        }
                    }
                }
            }
        },
        "/users/{id}": {
            "get": {
                "tags": [
                    "user"
                ],
                "summary": "Get user info",
                "description": "",
                "parameters": [
                    {
                        "name": "id",
                        "in": "path",
                        "description": "Record ID",
                        "required": true,
                        "type": "integer",
                        "format": "int32"
                    }
                ],
                "responses": {
                    "200": {
                        "description": "successful operation",
                        "schema": {
                            "$ref": "#/definitions/User"
                        }
                    },
                    "404": {
                        "description": "Record not found"
                    }
                }
            }
        }
    }
}

Thank you,
Vaibhav

I haven't see the error (in red color) before but maybe you can debug from this file:
/application/modules/api_v1/controllers/Swagger.php (which should be access via your link: http://vmcms.local/api/swagger). Normally it will output JSON as shown in your issue.
Alternatively, you can change this line from /application/modules/api_v1/views/home.php:
url = "<?php echo site_url('api/swagger'); ?>";

and replace it with a static file URL, e.g. url = "";
You can edit it from Swagger Editor website and download it as JSON file when finished.


Extract opening a pre_warm connection

This extracts opening a pre_warm connection into a few functions and moves PreWarmManager from proxy/http into iocore/net. This makes the logic easier to follow, and the PreWarmManager is used primarily in iocore; moving it there brings us closer to getting rid of the cyclic dependency between iocore/net and proxy/http.

[ci approve autest]

[approve ci autest]

Rebased on master.


Clevertap SDK 4.1.0 fails to compile on Xcode 14.3

We are having issues while adapting to Xcode 14.3 on Clevertap SDK 4.1.0 on the class CTLocalDataStore.
Can you guys confirm if the same is resolved in incremental version or the latest version. If YES please do share the details on same
@ygit @Aditi3  @Darshanpania

@suryasahu92 all releases from v4.2.2 support Xcode 14.3.
https://github.com/CleverTap/clevertap-ios-sdk/blob/master/CHANGELOG.md#version-422-april-03-2023

Thanks @akashvercetti  for the update


SAMZA-1768: Handle corrupted OFFSET file

This patch addresses the following tickets:
SAMZA-1778: SIGSEGV when reading properties (metrics) on a closed RocksDB store
SAMZA-1777: Logged store OFFSET file write during flush should be atomic
SAMZA-1768: Handle corrupted OFFSET file elegantly

@prateekm : could you please take a look?

@prateekm : I move the Files.move() out of the try{} block again since we should close the streams before we do the file movement. This is to enforce the write to the offset file before move. The IOExceptions are handled from the callers so we don't need to catch them in this function. The current handling of failing the container looks ok to me since it should happen very rarely, as we haven't seen it happening in production.

@xinyuiscool Makes sense to move this to its own try-catch block. It might still be better to handle IOException explicitly and revert to a normal move + replace existing. The IOException can happen if the implementation doesn't support replacing existing files as a part of the move. My concern is that this might fail on a particular platform consistently and we'll always end up rebootstrapping. Alternatively, if you've tested that it works on OSX and Linux, that'll be good enough for now.
Otherwise LGTM, feel free to merge this.

@xinyuiscool Makes sense to move this to its own try-catch block. It might still be better to handle IOException explicitly and revert to a normal move + replace existing. The IOException can happen if the implementation doesn't support replacing existing files as a part of the move. My concern is that this might fail on a particular platform consistently and we'll always end up rebootstrapping. Alternatively, if you've tested that it works on OSX and Linux, that'll be good enough for now.
Otherwise LGTM, feel free to merge this.

Good point on testing on both OSX and linux. I only tested on linux. Let me try OSX. Thanks.


missing setup.sh after git clone

There are minimum of four scripts which requires to be on the current working directory

03-generate-config-files/generate_apsim_configs.R
08-snakemake/Snakefile_txt and 08-snakemake/Snakefile_apsimx
run_snakefile.sh

Even if are to document this,asking the users to copy these by themselves it not very convenient .

Therefore, it will be ideal to have a setup.sh script which "asks for the working directory" and copy those files to it

Something like following should do this

Make sure to source the file  ( .e.g. source source setup.sh) and not ./setup.sh. Otherwise,

Changes to the working directory (using cd) in a shell script do not affect the parent shell from which the script was executed.
This is because each script runs in its own subshell, and changes to the working directory in that subshell do not propagate back to the parent shell.

#!/bin/bash

# Ask for the working directory
echo "Provide the path to working directory for apsim_simulations:"
read working_dir

# Check if the directory exists, if not create it
if [ ! -d "$working_dir" ]; then
    mkdir -p "$working_dir"
    echo "Created directory: $working_dir"
fi

# Copy the R script
cp 03-generate-config-files/generate_apsim_configs.R "$working_dir"

# Copy the Snakefile_txt
cp 08-snakemake/Snakefile_txt "$working_dir"

# Copy the Snakefile_apsimx
cp 08-snakemake/Snakefile_apsimx "$working_dir"

# Print completion message
echo "Setup is complete. Switching to working directory now."

# Change to the working directory
cd "$working_dir"

# Print current directory to confirm
echo "Current working directory: $(pwd)"

Done in https://github.com/nesi/APSIM-HPC/pull/68


Lost Snippets

I lost all my snippets after last plugin update :(
I guess there is no way to restore them back, is it?
In any case, thank you for this great and useful plugin.

The snippets are still there if you open your .obsidian/plugins/jelly-snippets/data.json.
You can rename searchSnippetsFile to snippetsFile to restore them (while Obsidian is closed).


adds manualModelWatcher option

This is a proposal draft of a functionality that speeds up forms with very complex models. It works on my application at work :)
Problem: I have model that is extremely large (over 500KB) and multiple forms that I need this model to be passed to (over 10). There is a deep watcher created for every formly-form instance (so it's over 10) that watches the same model on every digest cycle.
So I did some digging:
This deep watcher is created in the FormlyFormController and is needed to fire formly expressions (hide, validations and custom expressions). I know exactly what fields from the model can trigger these expressions to be changed but formly is watching the whole model anyway, even if I don't have any expression or validation.
Solution:
I added an option to manually define parts of model that should be watched instead of watching the whole model. This is done by passing manualModelWatcher option to formly-form. If you do that, formly will not set watch on whole model but will iterate data.watch array on every field (if there is one) and set multiple small watches.
Example usecase:
I have model that is over 500KB and all I need in my form is to watch for model.type change and show/hide couple of fields depending on that type. in my case, I would just do data: {watch: ['model.type']} on every field that defines the hideExpression and it works, yay! Instead of making a whole model deep watch, I've manually set to just watch what I need.
Tell me what you guys think. If this implementation is cool I will add docs to that :)

:+1: This is a major problem for me, deep watchers are too greedy and we have BIG models in API that we consume. From my perspective small watchers on needed fields are much better than one big deep watch.
In fact even if you do not need expressions, you still get deep watcher running with every digest.

Current coverage is 94.87%

Merging #599 into master will decrease coverage by -1.01% as of d6c4609

@@            master    #599   diff @@
======================================
  Files           16      16
  Stmts         1117    1131    +14
  Branches         0       0
  Methods          0       0
======================================
+ Hit           1071    1073     +2
  Partial          0       0
- Missed          46      58    +12

Review entire Coverage Diff as of d6c4609

Uncovered Suggestions

+0.79% via ...tives/formly-form.js#116...124
+0.35% via ...alidationMessages.js#25...28
+0.26% via src/test.utils.js#38...40
See 7 more...

Powered by Codecov. Updated on successful CI builds.

This looks pretty good. Please just use extras as I mention in the inline comment and I'd prefer that this new API is tested. Thanks!

P.S. Let me know when you update the PR (github wont notify me).

/me pokes @kentcdodds
I've added tests and refactored my code a bit to work with fields with custom model or relative model defined by string. How does it look now? I may add some docs as a cherry on top if you want to accept this feature.

I'm just not sure about my 'watcher grouping' magic. It seems to be working fine but I was wondering if it was so easy to implement why angular team didn't implement it globally in the core...

Thanks for doing this. The tests are great. I wonder if it might be easier if  manualModelWatcher could be a string or function itself. This way you could have a single watcher that applies to all fields. I feel like this could accomplish the need and we already have an API for specific watchers on fields.

@kentcdodds it seems like a valid case, I have updated the PR to incorporate your suggestion

With that, do we really need the extras watcher? We already have a mechanism for adding a watcher to a field... I'd rather avoid adding another way to do the same thing.

We already have a mechanism for adding a watcher to a field
We don't, that's why I wanted to be able to add watchers through extras.watch.

Scenarios:

if you do not turn manualModelWatcher on you will end up with a deep model watcher.
if you switch 'manualModelWatcher' to true, the deep model watcher will not get created and you will be able to define number of custom watchers like [model.type, () => model.type, 'model.collection']. This way you do not have the overhead of watching whole model if you know that your form field should only react to couple of changes
if you define 'manualModelWatcher' as a function you can have additional form watcher that is not dependant on any field, for example manualModelWatcher: () => ctrl.loading but you still would like to define small watches on your fields just like on the second scenario

Right. What I'm saying is for that second bullet point, you can use the watcher property to add custom watchers. It basically does the same thing as the watch is extras

@kentcdodds ok this is a gamechanger... why did I even work on this if this was already available :ghost:

@kentcdodds OH WAIT! You have to manually define listener for each of these expressions in your implementation of watcher property. What I propose is that you just define expressions that should be checked to run the internal functions in formly. I do not need any callback for that.
These two seem to be similar but in fact do 2 different things.

Sorry. I guess I didn't understand your problem well enough. I still think that it would be valuable to be able to disable the deep watch and provide a custom watch function for the whole form.

Ah, indeed... Hmmm.... I wonder if there's a way we could enhance the existing API to account for the use case

@kentcdodds well, I might try but it will be more complicated. I however agree that adding extras.watch when we already have watcher property will be confusing for developers - 'which one should I use?' Worst case scenario we could rename extras.watch to extras.manualModelWatcher to make these two functionalities separate but that's a cheap trick :palm_tree:
Btw your api is broken for a field with custom model and string expression in watcher. model in the expression will be referenced by the global model, not the one from your field. I fixed this case in my PR for my watchers by using $parse.

We could consider doing 2 things:

add watcher.runFieldExpressions property to single watcher from watcher array
empty listener watcher would not throw error if runFieldExpressions is set to true and expression is defined

This would mean that instead of:
{
  ...
  extras: {
    watch: ['model.type']
  }
}

we would have:
{
  ...
  watcher: [{
    expression: 'model.type',
    runFieldExpressions: true
  }]
}

That said, this can be done but it may seem a bit confusing. It could be less confusing if runFieldExpressions would be true by default but this would mean that all the people that used watch expressions with listeners and did not expect them to run the field expressions will get field expressions running (this adds a bit of performance overhead but well... it isn't that bad of idea to run the field expressions on custom watchers).
WIth that in mind we would end up with:
{
  ...
  watcher: [{expression: 'model.type'}]
}

HOWEVER this still doesn't look right. For me, this watcher feature would seem to be overloaded with second functionality that doesn't quite fit in there. I'm wondering if mixing these two is a good idea and I'm even closer to saying that we should rename extras.watch to extras.manualModelWatcher and it will seem like a valid feature.
@kentcdodds what do you think? I'm torn apart :) One way or the other, I'd like this feature pushed as soon as possible because it gives enormous boost to me app at work.

I like your first suggestion. I think that we could implement it in a backward compatible way and I don't think that it is terribly confusing:
{
  ...
  watcher: [{
    expression: 'model.type',
    runFieldExpressions: true,
  }]
},
{
  ...
  watcher: [{
    expression: 'model.type',
    listener: () => {},
    runFieldExpressions: true,
  }]
}

I think that both of those would run the field expressions, but the second field would also run the custom listener.
I really don't see anything bad with this approach. The idea is that it totally separates disabling deep model watching (or specifying custom watcher) from custom field watchers which I think is a good call.

@kentcdodds ok, sounds fine however I talked with @skosno at work and he came up with other suggestion. He suggested that we could switch to watching just the expressions rather than specifying additional watcher. In that case simple field like
{
  key: 'type',
  hideExpression: 'model.type === "some-type"'
}

would require no additional work done if you disable the deep model watcher because it would watch the expression itself.
On the other hand, there are cases where specifying single watcher for all expression properties would be beneficial ie:
{
  key: 'type',
  expressionProperties: {
    'templateOptions.label': 'model.type + " label"',
    'templateOptions.additionalOptions': 'data.getOptionsForType(model.type)',
  },
  hideExpression: 'model.type === data.someHeavyMethod()',
  extras: {
    manualModelWatcher: true
  },
  watcher: [{
    expression: 'model.type',
    runFieldExpressions: true
  }]
}

In this example we would disable expressions watchers for this field and just enable custom watchers that have runFieldExpressions: true.
How does it sound?

That's probably a little bit too magical I think. Maybe if we added another property to options that was watchAllExpressions in addition to disableModelWatcher or something like that. I just want the API to describe what's going on.

@kentcdodds that sounds fine, I will let you know when I'm ready

Ok @kentcdodds, I think I did it. However I went a little overboard so we might consider reverting one functionality but more on it later. Basically I did:

add optional manualModelWatcher to form config - it can be function or boolean - it disables global model watchers for that form
add optional watchAllExpressions to form config - when turned on, formly will add a deep watcher for each expression (templateExpressions and hideExpression). This option really makes sense only when manualModelWatcher is enabled but I didn't know how to validate it in apiCheck so we may let it be just optional or you may help me out with this conditional apiCheck validation
add optional runFieldExpressions to existing watcher functionality. If runFieldExpressions is enabled, it will run all field expressions after the watcher listener is finished. Also, now the listener property is optional due to fact that it can be omitted when runFieldExpressions is turned on. It could be validated in apiCheck but again, I didn't know how to do that.
renamed internal function refrencesCurrentlyWatchedModel to referencesCurrentlyWatchedModel - it had typeo
fixed hideExpression to be evaluated in the same model context that templateProperties are. This is breaking change but if you had nested or custom model on a field you had different evaluation context for basic expressionProperties (model referenced correct field model) and for hideExpression (model referenced always the model that was passed into form, not the one that the field defines). That being said, I can revert this if this is "too much" :)

I have written some tests and smoke tested these features on my work project and it works fine.
On very complex page with numerous forms, it turned out I have 2 hideExpressions and 1 expressionProperty which takes around 0.05ms in total for each digest cycle :) Not bad I'd say.

Haven't looked at the code yet, but I can tell you right now that there's a reason that hideExpression isn't evaluated the same as expressionProperties and that's because a common scenario for the hide property. That is: If a field is initialized as hide: true, then it will not be compiled. Therefore there will be no scope to evaluated this expression and the field will never be shown (because the expression can't be evaluated).
So, if you could removed that piece, then I'll give the code a look. Let me know if you have any questions. Thanks a ton!

@kentcdodds I know about that reason (however this is valid only when you ng-if the field when hide: true, it could work fine if you use ng-hide for that) but it's not about the scope, it's just about what the model property is referring to (idea seems simple enough and works fine). If you could take a look at this anyway and worst case scenario I change it back to what it was.
example:
our model: {
  game: 'scrabbles',
  player: {
    name: 'Karol',
    type: 'casual'
  }
}

This is how it works in the current latest formly release:
{
  key: 'name',
  model: 'model.player',
  expressionProperties: {
    'templateOptions.label': 'model.type + " player name"'
  },
  hideExpression: 'model.player.type === "casual"'
}

This is how it works with my PR (notice model in hideExpression refers to model.player)
{
  key: 'name',
  model: 'model.player',
  expressionProperties: {
    'templateOptions.label': 'model.type + " player name"'
  },
  hideExpression: 'model.type === "casual"'
}

If you wanted to fix the model property in those expressions, you could add to this object. Would require a breaking change though. Feel free to do that (though make sure your commit message follows the convention)

@kentcdodds the problem is that this object is used to evaluate the field.model itself so if I do:
return {
  model: field.model || $scope.model,
  options: field,
  index,
  formState: $scope.options.formState,
  formId: $scope.formId,
}

It will evaluate the model the wrong way in initModel when field.model is a string. It seems that if I do:
return {
  model: angular.isObject(field.model) ? field.model : $scope.model,
  options: field,
  index,
  formState: $scope.options.formState,
  formId: $scope.formId,
}

it all works fine but it seems a little bit hacky to me... it would take $scope.model as a model until the field.model is initialized (if it is defined as a string). What do you think?
Anyway, I will revert the fix for model property for now and I will leave this PR just with the watcher stuff and push the model fix in another PR when this gets accepted.
How does the code look to you besides of that issue?

This is excellent @kwypchlo. Thank you. If you could address my one comment, I give this a :+1:. I would like someone from @formly-js/angular-formly-collaborators and another person from @formly-js/angular-formly-collaborators-read to also review this PR and give a :+1: or :-1:

@kentcdodds cool! When this is accepted I could prepare the fix for the model reference in hide expression and watchers.

@kwypchlo Great job!
@kentcdodds :+1:

Thanks @kamilkisiela! I'll go ahead and merge this in then.

This will be auto-released in a few minutes. Thanks a bunch @kwypchlo!

Cool! :)


User Management - cognito setup

User management is required in the ga-sandbox for which we can use cognito. This needs to be created by terraform and configured for use in the jhub config
Done when:

[ ]  Cognito userpool, client and domain created by terraform
[ ]  Cognito login enabled in the jhub config

This is all done now


Support font size scaling for a11y

Describe the bug
While using outlined attribute on the textfield component, the label gets missalinged
Steps to reproduce the behavior:
Deploy Open wc es dev server
Import textfield
Set label and outlined properties
Voula
Browser Version:
Chrome 85

I'm unable to reproduce this on Chrome 85. Can you provide a reproduction with jsbin or unpkg?
https://jsbin.com/tikanajaci/edit?html,output

Alright, I guess I got it. The default css for open wc initialized application includes :host {  font-size: calc(10px + 2vmin); } which messes up with font size of the component.
So the question would be, should the component override all the existing font styles or is it problem on my part?

Got it! I'll update the issue title to more accurately reflect the problem, which is font scaling. We're aware of this problem and it's something our designers have been tracking for a while now. Here are a couple of upstream issues you can follow for some more context:
https://github.com/material-components/material-components-web/issues/1932
https://github.com/material-components/material-components-web/issues/4164
The tricky part with font scaling is that it ties very closely with the density subsystem of Material Design. If the font gets smaller, the component usually gets smaller (negative density), and if the font gets bigger the component should get bigger (positive density).
The guidance we need from design is how we can support font scaling for a11y while maintaining strict guidelines around the density system, which is why we haven't implemented it just yet.

All fonts in M3 now hook up to tokens, so you can explicitly set font type tokens and provide rem measurements instead of px