Can not send email to<EMAIL_ADDRESS>

Hello,
I tried to send you a email about my question of phylogenetic tree feature. but my email could not be delivered. The message said  "the group only accept messages from people in its organization or on its allowed senders list. Please see the image attached. Can you please add me to your list so I can send email to you? my email is<EMAIL_ADDRESS>Thank you very much.

Dear Jie,
I’m not sure why that happened because we have received emails from outside CDC before. Thanks for letting us know.
Please let me know why you are reaching out regarding MicrobeTrace so I can determine how best to help you.
Thanks,
Bill
William M. Switzer
Molecular Epidemiology & Bioinformatics Team Lead
Laboratory Branch
Division of HIV/AIDS Prevention
Centers for Disease Control and Prevention
1600 Clifton Road, Mailstop H18-2
Atlanta, GA 30329
404-639-0219
<EMAIL_ADDRESS>From: JieH9 @.>
Sent: Thursday, February 22, 2024 3:48 PM
To: CDCgov/MicrobeTrace @.>
Cc: Subscribed @.>
Subject: [CDCgov/MicrobeTrace] Can not send email to @. (Issue #787)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hello,
I tried to send you a email about my question of phylogenetic tree feature. but my email could not be delivered. The message said "the group only accept messages from people in its organization or on its allowed senders list. Please see the image attached. Can you please add me to your list so I can send email to you? my email is<EMAIL_ADDRESS>Thank you very much.
image.png (view on web)https://github.com/CDCgov/MicrobeTrace/assets/120115175/753661e4-6415-4167-aa4c-caba81548dfe
—
Reply to this email directly, view it on GitHubhttps://github.com/CDCgov/MicrobeTrace/issues/787, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHMTDBP2QX4DLRQ4NMACDEDYU6VJ3AVCNFSM6AAAAABDVUJYOWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DSOJQHE2TQNA.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>

Hi Bill and the Microbetrace team,
Thank you for the fast response. My name is Jie He. I’m a genomic epidemiologist from WI.
I watched the training video from the APHL learning center today. First, I would like to thank you for building such a strong data visualization tool. I will start to explore it with demo data and my HCV data next week. When I watch the video, I do not fully get how to visualize tree data. It sounds like I do not have to have a tree file, such as the Newick tree file, and Microbetrace will visualize the alignment as a tree. But then, what method did you use to build the tree? Can I see the distance or bootstrap for the tree built by  Microbetrace? The YouTube video from Microbetrace GitHub starts with the tree on the screen already. So, I did not really know how the tree was built.
While I could watch the training video on the APHL learning center, there were no slides to share. So, it is hard for me to follow Anne side by side after watching the video and checking the resource links in the slides. Can you send me a copy of the training slides (by Anne, 09 2022) and help me find more information about tree files, tree visualization, and Nextstrain integration?
Thank you very much.
Jie
@.Jie He, MPH, Ph.D
Genomic Epidemiologist
Enteric and Waterborne Diseases Unit
Wisconsin Department of Health Services | Division of Public Health |
Bureau of Communicable Diseases
D:<PHONE_NUMBER>| C:<PHONE_NUMBER> | Fax<PHONE_NUMBER>
<EMAIL_ADDRESS>NOTICE: This email and any attachments may contain confidential information. Use and further disclosure of the information by the recipient must be consistent with applicable laws, regulations, and agreements. If you received this email in error, please notify the sender, delete the email, and do not use, disclose, or store the information it contains.
From: Switzer, Bill (CDC/NCHHSTP/DHP) @.>
Sent: Thursday, February 22, 2024 3:01 PM
To: He, Jie - DHS @.>
Cc: Subscribed @.>; CDCgov/MicrobeTrace @.>; CDCgov/MicrobeTrace @.>
Subject: RE: [CDCgov/MicrobeTrace] Can not send email to @. (Issue #787)
CAUTION: This email originated from outside the organization.
Do not click links or open attachments unless you recognize the sender and know the content is safe.
Dear Jie,
I’m not sure why that happened because we have received emails from outside CDC before. Thanks for letting us know.
Please let me know why you are reaching out regarding MicrobeTrace so I can determine how best to help you.
Thanks,
Bill
William M. Switzer
Molecular Epidemiology & Bioinformatics Team Lead
Laboratory Branch
Division of HIV/AIDS Prevention
Centers for Disease Control and Prevention
1600 Clifton Road, Mailstop H18-2
Atlanta, GA 30329
404-639-0219
<EMAIL_ADDRESS>From: JieH9 @.>
Sent: Thursday, February 22, 2024 3:48 PM
To: CDCgov/MicrobeTrace @.>
Cc: Subscribed @.>
Subject: [CDCgov/MicrobeTrace] Can not send email to @. (Issue #787)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hello,
I tried to send you a email about my question of phylogenetic tree feature. but my email could not be delivered. The message said "the group only accept messages from people in its organization or on its allowed senders list. Please see the image attached. Can you please add me to your list so I can send email to you? my email is<EMAIL_ADDRESS>Thank you very much.
image.png (view on web)https://secure-web.cisco.com/1zV8PcwNH71cfOdL8umu_4T9fFqVCWB5BxWlDXV1DcLApUAWaR7Tr9xve4-hiXqwHQ1nDbP8h5m17u1-CsUHudcbjmRjjaDrQ8_VltcJw83drQn_U5XmDGuoTQlzprP8GXGvlJFOImecYfTCo0jvLx5SNE-vq20l__f6_g4bsXSGgDuWhdhnWVWRpaiKmiXy-aO45jCai-huTHjPwRb_VdAmp17FwQ0NNoDiyYEPzhx80NnNHIb8xQogCybYzh-8KkQAWbzG9sed7gH2kUuHe1fW6cV04g2Sg3oBAbF2Ehg9efjsZGOdqIneFtDbfc6fm/https%3A%2F%2Fgithub.com%2FCDCgov%2FMicrobeTrace%2Fassets%2F120115175%2F753661e4-6415-4167-aa4c-caba81548dfe
—
Reply to this email directly, view it on GitHubhttps://secure-web.cisco.com/1a14a6YmOG0kroWsAsRaWvbZopEsQCSN5SPPtqchIPrJ4Dz2_yBDzzUVZsg86uaDOFjzNQWHrY2zfPEUe1pveNhyPCRxYk-WlbgusCTkxMfVpLqp0-UUFoa7BGvxzcN-k8bQMvC8Y2kN-IWhjBySjZvHaKdsvey9c_ERcI5NKMLUvmD3BJTXIdCFmz_-Qbis0ruGO3u_jK_boOGVTX7MwC4Qr_9IHDsUIMsOzo1nRVWTBFa7Q3PfPjcJxX13IPfaTsNTLhAnYZId-w0cOESrs5mha3ankrE9wD6aypmW5x99Z-XjZt8jhC_j_umd9MXWj/https%3A%2F%2Fgithub.com%2FCDCgov%2FMicrobeTrace%2Fissues%2F787, or unsubscribehttps://secure-web.cisco.com/14HSyxCzZWxzHVZ9qBHwh3S65feQZFRGfW5DlQecgTYfEGHzocXKdtdGkKxtJ-VpsZub8yEUeyGh2YzG7IDBZzYsC4XiqLdJen-dAhdSWRnCb3yWhp4dZbNC30TTnFfBeu7Yyba0x3rD-lsfVb_offXsk_JAgUXUIYlfaxVUHyJFzc17VuCKHYmSF-RBJOGELRo-v80DBO79DqhaRuhEu8OfMworCPV3tX3Q5wksQF7XSpktWXeO-xzeUheuhob2Z12tFmgmEatIE5cBDItbL8hCb8rWD-9F_pgLXXb4rsZVdykSOTjm70yh4Pgxf9_FG/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHMTDBP2QX4DLRQ4NMACDEDYU6VJ3AVCNFSM6AAAAABDVUJYOWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DSOJQHE2TQNA.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>


Introduce a new field to store product on AssignedProductAttributeValue

I want to merge this change because it's introducing a new field for a FK to Product on AssignedProductAttributeValue. This change is part of the work needed to simplify Product - Attribute relation as described in https://github.com/saleor/saleor/issues/12881

Impact

[x] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations

Docs
No changes to the docs.
Pull Request Checklist

[x] Privileged queries and mutations are either absent or guarded by proper permission checks
[x] Database queries are optimized and the number of queries is constant
[ ] Database migrations are either absent or optimized for zero downtime
[x] The changes are covered by test cases

I tested the migration with 50k products with 2+ attributes each to make sure the migration task works.


Investigate using Netlify to get HTTPS support

Netlify is a static CDN that has a free tier like GitHub Pages but supports HTTPS.
I think it looks pretty dumb that we're a tech club but our website doesn't support HTTPS, so we should do this.

I went through this process for my personal website and it was really easy! Definitely should go ahead with this for the LP site

Isn't it just a matter of deploying this repository? Is there anything that has to be done on the code side?

Yep, it's all config. No code changes required

We can just do this through GitHub Pages
. But first we have to change all the URLs we request stuff from to HTTPS to avoid errors on the client side when loading fonts etc.

That's unfortunate.


Function with zero code coverage detected: cleaner.go:119: showConfiguration

Function with zero code coverage detected: cleaner.go:119: showConfiguration

Fixed in https://github.com/RedHatInsights/insights-results-aggregator-cleaner/pull/178


Broken Link in Linux Installation Guide

Describe the bug
Dear Hummingbot Support Team,
I hope this message finds you well. I would like to bring to your attention a small issue I encountered while following the Linux installation guide on your website.
In the section titled "Launch Hummingbot" under the Linux installation guide (https://hummingbot.org/installation/linux/), there is a link to the Quickstart Guide that appears to be broken. The link provided is https://hummingbot.org/installation/getting-started/custom-script/index.md, which leads to a 404 error.
Steps to reproduce

Visit the Hummingbot Linux installation guide: https://hummingbot.org/installation/linux/

Scroll down to the section titled "Launch Hummingbot."

Within this section, there is a link to the Quickstart Guide. The link is provided as follows: https://hummingbot.org/installation/getting-started/custom-script/index.md

Click on the provided link to access the Quickstart Guide.

Observe that the link leads to a 404 error page, indicating that the content at the specified URL is not found.

Release version
1.23
Type of installation
Source
Attach required files
No response

hi @surazgyawali Thank you for the report, will be fixed #269


Setup v3 hosting strategy

Summary
Setup v3 hosting strategy for both ui-kit and design-system
💬 Description
Ic-ui-kit
·      Version 2 is released as normal, when merged into main.
·      Version 3 workflow to be added to automatically deploy a pre-release flagged version to npm, that won’t automatically be installed with a npm install (make sure to confirm/test that it will not be installed automatically and will be ignored).

Ic-design-system
·      Version 2 is released as normal, when merged into main.
·      Version 3 is to be hosted in the same way feature branches are now (no workflow changes needed), so we have a temporary
·      Designers to design how they want us to be able to switch between the old version 2 and version 3, when that time comes. I think we start with only having the most up to date version of version 2 and version 3, not any minor versions between, this will increase our deployment sizes drastically, and not something anybody has requested yet.
💰 Use value
To be able to start work on v3.

Opened by @MI6-255


The type of an event is not propagated to the listener

Description
I'm currently using LitHtml in Javascript, getting some type safety with JSDoc.
When i dispatch an event it's properly detected and provides auto complete to me, but when i now add an arrow notation like this:
<custom-element @custom-event="${(e)=>console.log(e)}"></custom-element>
then the e-property has implicitly the any-type. i'm just working with javascript and JSDoc but probably TypeScipt has the same problem, if it is like that.
the problem is severe, because whenever i just want to pass the custom-event detail to a function and treat it as a simple output, then i always have to manually specify the type of the event.
I have no idea if this is the right place to state this issue, i hope someone can help me, knows a workaround or can even fix this issue.
Steps to Reproduce

create any component which dispatches and type of event

subscribe tot his event using this code

<custom-element @custom-event="${(e)=>console.log(e)}"></custom-element>
the event parameter e will have implicitly the any-type and no type autocomplete or error-checks are enabled
Expected Results
e should be for native Events of type Event, (KeyboardEvent, ...) or CustomEvent for custom events
Actual Results
e is of type any
Browsers Affected
it is no browser-related issue

Here is the related feature request in lit-analyzer: https://github.com/runem/lit-analyzer/issues/143

Closing here since it's a lit-analyzer feature.


[resolves #632] Remove examples distro module

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/471/
Test PASSed.


[#2] Expand color selection

#2 - Add a HSV value slider to allow selection of more shades of color.

Nice work, especially on adding the translation 👍


Production use?

is any one using this in production?
Does it has concept of Seller or Fulfiller i.e. if the production is fulfilled by 3rd-party?

It has concept of seller

Hi @rizplate, we've been using Saleor in production successfully for over two years in multiple projects (sometimes in heavily customized versions).
By default we don't have a concept of product seller, but it can be easily added as new model related to product (if I understand you correctly).


fix(dpj): prevent double input of plate-editor library on IOS/Android

@xuanduc987 @esksak I've updated PR to check only HyperClass-ios HyperClass-android. Please check it again. Thanks!


Dereferencing a funcref from the function it calls leads to a heap-use-after-free

Godot version
3.5.1.stable
System information
Arch Linux (rolling release)
Issue description
Dereferencing a funcref from the function it calls can cause an error in AddressSanitizer in debug/release-debug builds. It might be possible for this to cause more subtle heap corruption issues in release builds--I suspect it is behind a rare/unreproducible crash in my project.
I think what happens in the below example is that when foobar dereferences the funcref, the funcref is freed. Then when control flow returns from foobar to FuncRef.call_func the this pointer is invalid. It seems weird that function calls do not implicitly hold a reference to the object they're on.
Note that this isn't unique to FuncRefs - you can implement a FuncRef in pure GDScript and it will have the same bug.
==16930==ERROR: AddressSanitizer: heap-use-after-free on address 0x612000254d70 at pc 0x0000066b3b05 bp 0x7fff849419c0 sp 0x7fff849419b0
WRITE of size 4 at 0x612000254d70 thread T0
    #0 0x66b3b04 in std::__atomic_base<unsigned int>::fetch_sub(unsigned int, std::memory_order) /usr/include/c++/12.2.1/bits/atomic_base.h:628
    #1 0x66b3b04 in SafeNumeric<unsigned int>::decrement() core/safe_refcount.h:84
    #2 0x66b3b04 in SafeRefCount::unref() core/safe_refcount.h:177
    #3 0x66b3b04 in _ObjectDebugLock::~_ObjectDebugLock() core/object.cpp:53
    #4 0x66b3b04 in Object::call(StringName const&, Variant const**, int, Variant::CallError&) core/object.cpp:924
    #5 0x68b8c7a in Variant::call_ptr(StringName const&, Variant const**, int, Variant*, Variant::CallError&) core/variant_call.cpp:1229
    #6 0x12f7960 in GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) modules/gdscript/gdscript_function.cpp:1048
    #7 0x122592e in GDScriptInstance::call_multilevel(StringName const&, Variant const**, int) modules/gdscript/gdscript.cpp:1214
    #8 0x29b9039 in Node::_notification(int) scene/main/node.cpp:58
    #9 0x2cb073f in Node::_notificationv(int, bool) scene/main/node.h:47
    #10 0x2cb073f in CanvasItem::_notificationv(int, bool) scene/2d/canvas_item.h:163
    #11 0x2cb073f in Control::_notificationv(int, bool) scene/gui/control.h:47
    #12 0x66ab532 in Object::notification(int, bool) core/object.cpp:927
    #13 0x2a4c801 in SceneTree::_notify_group_pause(StringName const&, int) scene/main/scene_tree.cpp:1105
    #14 0x2a733d1 in SceneTree::idle(float) scene/main/scene_tree.cpp:608
    #15 0xb08189 in Main::iteration() main/main.cpp:2298
    #16 0xaaf46f in OS_X11::run() platform/x11/os_x11.cpp:3987
    #17 0xa4e5dc in main platform/x11/godot_x11.cpp:59
    #18 0x7f1c6d03c78f  (/usr/lib/libc.so.6+0x2378f)
    #19 0x7f1c6d03c849 in __libc_start_main (/usr/lib/libc.so.6+0x23849)
    #20 0xa64634 in _start (/media/scratch/coding/godot/godot-builder/godot/bin/godot.x11.opt.debug.64s+0xa64634)

0x612000254d70 is located 48 bytes inside of 272-byte region [0x612000254d40,0x612000254e50)
freed by thread T0 here:
    #0 0x7f1c6dcbe672 in __interceptor_free /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_malloc_linux.cpp:52
    #1 0x6753795 in void memdelete<Reference>(Reference*) core/os/memory.h:118
    #2 0x6753795 in void memdelete<Reference>(Reference*) core/os/memory.h:110
    #3 0x6753795 in Ref<Reference>::unref() core/reference.h:258
    #4 0x6753795 in RefPtr::unref() core/ref_ptr.cpp:85

previously allocated by thread T0 here:
    #0 0x7f1c6dcbfa89 in __interceptor_malloc /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x6b16b2f in Memory::alloc_static(unsigned long, bool) core/os/memory.cpp:75
    #2 0x12f66ed in GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) modules/gdscript/gdscript_function.cpp:1116
    #3 0x123621b in GDScriptInstance::_ml_call_reversed(GDScript*, StringName const&, Variant const**, int) modules/gdscript/gdscript.cpp:1229

Steps to reproduce
Put this script on a node and then play the scene, using a release_debug build with asan on:
var fr

func _ready():
	fr = funcref(self, "foobar")

func foobar():
	fr = null

func _process(_delta):
	if fr:
		fr.call_func()

Minimal reproduction project
N/A

I've run into this issue at least a dozen separate times now in unrelated parts of my codebase, in multiple projects, in Godot 3 and in Godot 4 as well. I seriously can't be the only one encountering this :laughing:
Updated example that works with Godot 4.3:
godot-callable-crash.zip
Build Godot with asan, run the callable_example scene and observe the asan error:
==90026==ERROR: AddressSanitizer: heap-use-after-free on address 0x5140001a8ca0 at pc 0x636b24b87682 bp 0x7ffd10c69a30 sp 0x7ffd10c69a28
WRITE of size 4 at 0x5140001a8ca0 thread T0
    #0 0x636b24b87681 in std::__atomic_base<unsigned int>::fetch_sub(unsigned int, std::memory_order) /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/14.1.1/../../../../include/c++/14.1.1/bits/atomic_base.h:641:16
    #1 0x636b24b87681 in SafeNumeric<unsigned int>::decrement() /media/scratch/coding/godot/godot-builder/godot/./core/templates/safe_refcount.h:87:16
    #2 0x636b24b87681 in SafeRefCount::unref() /media/scratch/coding/godot/godot-builder/godot/./core/templates/safe_refcount.h:207:16
    #3 0x636b24b87681 in _ObjectDebugLock::~_ObjectDebugLock() /media/scratch/coding/godot/godot-builder/godot/core/object/object.cpp:55:20
    #4 0x636b24b87681 in Object::callp(StringName const&, Variant const**, int, Callable::CallError&) /media/scratch/coding/godot/godot-builder/godot/core/object/object.cpp:814:1
    #5 0x636b24383b0a in Variant::callp(StringName const&, Variant const**, int, Variant&, Callable::CallError&) /media/scratch/coding/godot/godot-builder/godot/core/variant/variant_call.cpp:1211:27
    #6 0x636b18891d65 in GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Callable::CallError&, GDScriptFunction::CallState*) /media/scratch/coding/godot/godot-builder/godot/modules/gdscript/gdscript_vm.cpp:1780:12
    #7 0x636b184598e9 in GDScriptInstance::callp(StringName const&, Variant const**, int, Callable::CallError&) /media/scratch/coding/godot/godot-builder/godot/modules/gdscript/gdscript.cpp:2032:22
    #8 0x636b1df52251 in bool Node::_gdvirtual__ready_call<false>() /media/scratch/coding/godot/godot-builder/godot/scene/main/node.h:355:2
    #9 0x636b1df52251 in Node::_notification(int) /media/scratch/coding/godot/godot-builder/godot/scene/main/node.cpp:217:4
    #10 0x636b1f798bd1 in Node::_notificationv(int, bool) /media/scratch/coding/godot/godot-builder/godot/./scene/main/node.h:50:2
    #11 0x636b1f798bd1 in CanvasItem::_notificationv(int, bool) /media/scratch/coding/godot/godot-builder/godot/./scene/main/canvas_item.h:45:2
    #12 0x636b1f798bd1 in Node2D::_notificationv(int, bool) /media/scratch/coding/godot/godot-builder/godot/scene/2d/node_2d.h:37:2
    #13 0x636b24b7edc1 in Object::notification(int, bool) /media/scratch/coding/godot/godot-builder/godot/core/object/object.cpp
    #14 0x636b1df5ad36 in Node::_propagate_ready() /media/scratch/coding/godot/godot-builder/godot/scene/main/node.cpp:272:3
    #15 0x636b1df5aca2 in Node::_propagate_ready() /media/scratch/coding/godot/godot-builder/godot/scene/main/node.cpp:263:12
    #16 0x636b1df6c109 in Node::_set_tree(SceneTree*) /media/scratch/coding/godot/godot-builder/godot/scene/main/node.cpp:3171:4
    #17 0x636b17b3417b in OS_LinuxBSD::run() /media/scratch/coding/godot/godot-builder/godot/platform/linuxbsd/os_linuxbsd.cpp:950:13
    #18 0x636b17b17295 in main /media/scratch/coding/godot/godot-builder/godot/platform/linuxbsd/godot_linuxbsd.cpp:85:6
    #19 0x7b167e034e07  (/usr/lib/libc.so.6+0x25e07) (BuildId: 476816ac63052a8d67cb2a7e2b93ee9bd72e417b)
    #20 0x7b167e034ecb in __libc_start_main (/usr/lib/libc.so.6+0x25ecb) (BuildId: 476816ac63052a8d67cb2a7e2b93ee9bd72e417b)
    #21 0x636b179dd2e4 in _start (/media/scratch/coding/godot/godot-builder/godot/bin/godot.linuxbsd.editor.x86_64.llvm.san+0x4dc62e4) (BuildId: 94136b4b522f8ae4)

0x5140001a8ca0 is located 96 bytes inside of 392-byte region [0x5140001a8c40,0x5140001a8dc8)
freed by thread T0 here:
    #0 0x636b17acb492 in free.part.0 (/media/scratch/coding/godot/godot-builder/godot/bin/godot.linuxbsd.editor.x86_64.llvm.san+0x4eb4492) (BuildId: 94136b4b522f8ae4)
    #1 0x636b2432d184 in Variant::_clear_internal() /media/scratch/coding/godot/godot-builder/godot/core/variant/variant.cpp:1389:6
    #2 0x636b184598e9 in GDScriptInstance::callp(StringName const&, Variant const**, int, Callable::CallError&) /media/scratch/coding/godot/godot-builder/godot/modules/gdscript/gdscript.cpp:2032:22

previously allocated by thread T0 here:
    #0 0x636b17acc4c9 in malloc (/media/scratch/coding/godot/godot-builder/godot/bin/godot.linuxbsd.editor.x86_64.llvm.san+0x4eb54c9) (BuildId: 94136b4b522f8ae4)
    #1 0x636b23b772df in Memory::alloc_static(unsigned long, bool) /media/scratch/coding/godot/godot-builder/godot/core/os/memory.cpp:75:14
    #2 0x636b23b772df in operator new(unsigned long, char const*) /media/scratch/coding/godot/godot-builder/godot/core/os/memory.cpp:40:9
    #3 0x636b1842d697 in GDScriptNativeClass::instantiate() /media/scratch/coding/godot/godot-builder/godot/modules/gdscript/gdscript.cpp:99:9
    #4 0x636b1842d697 in GDScript::_new(Variant const**, int, Callable::CallError&) /media/scratch/coding/godot/godot-builder/godot/modules/gdscript/gdscript.cpp:222:29

This sometimes leads to a crash in non-asan builds (in editor, debug, and in release template builds), but it's very difficult to reproduce that way.
It happens because a RefCounted object's refcount can go to zero, causing the object to be freed, while one of its methods is still somewhere on the stack. When the stack unwinds to that method, there's a heap-use-after-free.
The pattern of use that tends to hit this bug in real code is one where there's an object that emits a signal when it's finished - and where the consumer of that signal clears the sole reference to that object (whether intentionally, incidentally, or indirectly). The other example in that project is more along these lines, and demonstrates just how insidious this bug can be:
func _ready() -> void:
	var promise = $JobQueue.post(some_slow_operation)
	$TextureRect.texture = await promise.fulfilled

When I look at this, I don't tend to think that when _ready returns it's going to (1) free the promise, and then (2) jump back into some method on the promise and crash, lol. That's some spooky action at a distance.

CC @godotengine/gdscript @godotengine/core

This bug seems caused by OBJ_DEBUG_LOCK in Object::call().
Likely this is holding onto a reference to the object and then trying to change a ref count after deletion.
Removing the line OBJ_DEBUG_LOCK seems to remove the bug.
Still investigating.

struct _ObjectDebugLock {
	Object *obj; // I AM THE PROBLEM HERE, RAW POINTER TO OBJECT
	ObjectID id;

	_ObjectDebugLock(Object *p_obj) {
		obj = p_obj;
		obj->_lock_index.ref();

		if (obj)
		{
			id = obj->get_instance_id();
		}
	}
	~_ObjectDebugLock() {

		if (id)
		{
			if (ObjectDB::get_instance(id))
			{
				obj->_lock_index.unref();
			}
		}

	}
};

Actually the bodge fix might be not so bad after all.
The FuncRef is a reference, so has a ref count, but the problem is that ObjectDebugLock works with all Objects (which don't seem to have a refcount on cursory inspection). So there's no easy way to defer the deletion.
We could test whether the object is a Reference, and if so, increase the ref count around the call. But although that fixes this case, it doesn't fix the general case for non-reference objects being deleted. Maybe this can't happen but it would be nice to close that too.
Looking up instance ids is probably super slow but it seems debug only.
Maybe there's a more elegant way though.

It seems we crossed our ways. I've made a fix based on Variant as the responsible for validity check.

It seems we crossed our ways. I've made a fix based on Variant as the responsible for validity check.

That looks good I'll check in a second. :+1:
You are more familiar with Object etc than me.
Akien poked me this morning to have a look at these bugs.

There's also the problem that if we did increase the refcount to prevent this (debug) bug, we would probably need to do it in release too because the lifetime would change subtly, and could lead to further hard to debug bugs in the future. So maybe the bodge is better.

Another issue would be the predelete handler. When the object's refcount reaches 0, it frees the object, triggering the predelete_handler and NOTIFICATION_PREDELETE. That could then do a method call and re-increment the refcount. I think this would cause an infinite loop unless how the predelete handler works was also changed somehow?

This bug seems caused by OBJ_DEBUG_LOCK in Object::call().

I think the object debug lock might not be the only problem. It's just the only way the issue manifests in the example project.
So the relevant functions in the less_direct_example are:
func _ready() -> void:
	var promise = $JobQueue.post(some_slow_operation)
	$TextureRect.texture = await promise.fulfilled

#...

	func fulfill(value) -> void:
		result = value
		fulfilled.emit(result)

The fulfill function does nothing after emitting the "fulfilled" signal, so fixing the object debug lock would fix this example. But there could be anything there after emit returns. If it assigned a value to a property or called another method wouldn't this access unallocated memory (in release builds, too)?
	func fulfill(value) -> void:
		result = value
		fulfilled.emit(result)
		# now self has been freed
		result = null # oops, write-after-free

I think the object debug lock might not be the only problem. It's just the only way the issue manifests in the example project.

I know next to zero about the await command, and I may be wrong, but this does sound like a separate issue, and should probably be reported in separate issue with MRP.


Get pgconnection from pool

I have an application using HikariCP, it's currently running version 2.4.1 and everything is working fine, but I would like to upgrade to the current version (2.4.3).
I use the Postgres LISTEN / NOTIFY system in my app, so I need to get the base PGConnection object from the connection returned by HikariCP.
I was previously doing: this.pgConnection = PGConnection.class.cast(ConnectionProxy.class.cast(connection).getPoolBagEntry().connection);
This no longer works as of 2.4.1, as you renamed that class ProxyConnection, and made the getPoolEntry() method package local.
What alternative methods do I have to get the PGConnection so I can get all of my notifications from the connection?

@Tostino Use PGConnection pgConn = connection.unwrap(PGConnection.class).


Add size calculation for a set of packages during zopen install

Originally posted by @MikeFultonDev in https://github.com/ZOSOpenTools/meta/pull/564#pullrequestreview-1721473370
PR: https://github.com/ZOSOpenTools/meta/pull/564 adds size calculated for all packages, however in zopen install you can install a set of packages as such:
zopen install git curl vim

We should be able to calculate the total size for a set as well.

Does that size include the transitory space needed for the install package that is removed after the install?


Do highlighting for at least the navigation node

NVDA has the ability to highlight the current focus (Visual preference: highlight system focus). Maybe this can be done while navigating. It requires adding ids to the web page, or writing some code that maps the internal ids used for reporting the current node back to the original tree. Then JS can get the bounding box and highlight it. CSS could be used if modifying the document is an option.

Use case: It is fairly common for blind college students to work with sighted visual descriptionists for STEM classes. I often screen-share to point out a particular piece of Math I'm struggling to make sense of, and having visual highlighting would be nice for that. In other words, +1 to this ticket.


remove unused use statements

Thanks @samsonasik, you always improve my code ;-)

you're welcome ;)


Fix tray icon always on (regression from #1235)

Fix regression introduced in #1235

:ok_hand:

@TheCleric well sorry, but actually nope, this is still a regression as now npm run test:manual will no longer exit when hitting Ctrl+W in the app. With this PR, the app processes now keep running in background (with no tray, so the only way to exit is to kill the processes).

👌

@TheCleric well sorry, but actually nope, this is still a regression as now npm run test:manual will no longer exit when hitting Ctrl+W in the app. With this PR, the app processes now keep running in background (with no tray, so the only way to exit is to kill the processes). Letting you fix the app, which probably badly reacts to "tray": "false"

Done in #1242


Don't start watching console logs if an existing resource isn't selected

From https://github.com/dotnet/aspire/pull/1034#issuecomment-1828816555

When you click on the console logs link in the menu, what decides which app to display?
Structured logs and traces have an "All" option and select it by default. But that doesn't make sense for console logs. Metrics doesn't display anything by default and prompts you to choose a service (note: service should be renamed to resource)

I think the console logs could do the same thing. That page would also be displayed if a bad name is in the url, e.g. http://localhost:15888/ConsoleLogs/ThisDoesntExist

This is relevant with or without the combined console logs view (#1034 which as of this issue being filed has not gone in) since the behavior is the same before and after that PR.
@leslierichardson95 @kvenkatrajan for your thoughts on this as well

If there is a plan for combined console logs, then the default should be the (All) option is selected and combined data is shown.
Otherwise I think a UI asking the user to select a resource (like metrics) should be shown.

If there is a plan for combined console logs, then the default should be the (All) option is selected and combined data is shown.
Otherwise I think a UI asking the user to select a resource (like metrics) should be shown.

My language in the description was probably imprecise. No plans to show a combined view of all the logs at the same time. Just #1034 to have a single page regardless of type. I updated the issue description to hopefully clarify that. Agree that the UI asking the user to select a resource is the right direction (assuming we want to move away from selecting the first one).


ProvisionController: refactoring using SharedInformers

Hi, I'd like to propose refactoring ProvisionController using SharedInformers totally.
As mentioned in the controller's Guidelines:

This saves us connections against the API server, duplicate serialization costs server-side, duplicate deserialization costs controller-side, and duplicate caching costs controller-side.

If this sounds reasonable, I'd be happy to work on this.
/cc @wongma7

Yes this is okay with me, thank you for your help. I thought briefly about it. Like, we create a SharedInormer instead of NewInformer here, maybe using those factory functions provided by client-go https://github.com/kubernetes-incubator/external-storage/blob/master/lib/controller/controller.go#L504
I am skeptical of the savings for us though: the controller is not "sharing" the informers with any other controllers, so still we need to create our own connection to the API server (I think it means that in controller-manager, multiple controllers can use the same connection). As for deserialization and caching I'm not sure. Either way we should move to SharedInformers just because they are the "correct" interface for using informers.

Thanks for the explanation, I'll submit a PR soon


Update @silvermine/eslint-plugin-silvermine to version 2.0.0

Various rules were added to the our ESLint plugin, including a new fork of the indent rule.
This PR has the necessary package bump to use it. It also includes the addition of a peerDependency on<EMAIL_ADDRESS>The plugin's new fork of the indent rule requires at least version 5 of ESLint in order to use the ASTUtil.
In addition, quote-props has been turned off since we no longer support ES3 in our codebases and that rule is not needed after ES5.

@yokuze please review


enable strict-raw-types

Similar to https://github.com/dart-lang/lints/issues/125, this is a proposal to enable strict-raw-types in the recommended lint set. We'd have to believe this is the way we want to recommend that people write Dart code.
See also https://github.com/dart-lang/lints/issues/149.

I'd suggest enabling both or neither.
Giving users protection against Foo() inferring Foo<dynamic>, but not against List<Foo> l; inferring List<Foo<dynamic>>, or vice versa, can give a false sense of security.
And I'd suggest "both".
It's a long-standing wish of mine to change the language to not infer or insert dynamic as a default, so you, or someone else, have to explicitly write at least one dynamic in order to get it. (And at the same time, using hacky "library versioning", I'd make the platform libraries use Object? everywhere they expose dynamic today.)
These "lints" being enabled will make such a change more viable, since code satisfying them will not need migrating for the inference/insertion change.

From a discussion with @leafpetersen, he saw challenges with this analysis mode (as it's implemented today?).


Allowed to create realm with <.> period in realm name, but it doesn't work correctly.

I tried to create a realm word1.word2 and it caused all sorts of weird login/role/certimport issues. It wouldn't show up correctly in the realm drop down list, had cert import issues (they wouldn't show up in the GUI)
When I recreated the realm word1word2 it all worked correctly.

Please use the Mailingsliste for support, this is for confirmed bugs or explicitly defined feature requests only


Fix/pnpm

Codecov Report

Merging #259 (d738946) into master (f6e497c) will decrease coverage by 1.82%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   88.88%   87.06%   -1.83%
==========================================
  Files          40       40
  Lines        3788     3788
  Branches     1114     1114
==========================================
- Hits         3367     3298      -69
- Misses        377      428      +51
- Partials       44       62      +18

Impacted Files
Coverage Δ

packages/command-core/src/utils/postInstall.ts
17.85% <0.00%> (ø)

packages/cli-plugin-fc/src/index.ts
19.71% <0.00%> (-45.78%)
:arrow_down:

packages/cli-plugin-check/src/index.ts
93.17% <0.00%> (-1.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e497c...d738946. Read the comment docs.


add bridge convenience script

Made a basic bridge script for #78
Had two questions:

You mean a convenience script like this or as a roll.py subcommand?
This solution could be maybe improved for devnet/prod by adding an extra 'preset' flag like the main script, so that devnet users don't have to paste in localhost:8545? prod default would get rpc from config, devnet from wherever that gets stored if possible idk.

Hey there! Sorry for the delay in the review, and thanks for the contribution 🙏

You mean a convenience script like this or as a roll.py subcommand?

Both can be good, but I'm wondering if it's maybe not better as a subcommand as it allows reusing the config loading logic (which does a few things beyond just loading the TOML, though not sure they are relevant in this use case from the top of my head). And the presets, like you mention :)
The only downside is polluting the command space a bit, but maybe we can make it a "script" command and make this a "bridge" subcommand (and then if we add other scripts like this we can add them there as well).

This solution could be maybe improved for devnet/prod by adding an extra 'preset' flag like the main script, so that devnet users don't have to paste in localhost:8545? prod default would get rpc from config, devnet from wherever that gets stored if possible idk.

The default in the loading logic I mention above is the dev preset, if not integrating as a subcommand, could use that here too!
The default is http://<IP_ADDRESS>:8545 in any case, even without preset (from config/network.py :: l1_rpc_url)

What I propose: let's merge this (maybe if you can move the utility function to the library first?).
Then if you're motivated, an extra PR to integrate this as a subcommand, and/or to optionally wait for the bridge to complete would be more than welcome!
Thanks again!


Markdown in messages sent to Facebook Messenger channel ignored

I looks to me like even simple markdown like bold is ignored by the Facebook Messenger channel.

That’s correct, facebook does not support markdown.  We render as text
From: Jakob Nielsen-MSFT<EMAIL_ADDRESS>Sent: Wednesday, May 4, 2016 11:42 AM
To: Microsoft/BotBuilder<EMAIL_ADDRESS>Subject: [Microsoft/BotBuilder] Markdown in messages sent to Facebook Messenger channel ignored (#224)
I looks to me like even simple markdown like bold is ignored by the Facebook Messenger channel.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/BotBuilder/issues/224

It would be great if you could remove the markdown then.

We actually do.
The rendering is a text rendering of the markdown.  For example:
This is
one line
of text
becomes:
This is one line of text.
-Tom
From: Jakob Nielsen-MSFT<EMAIL_ADDRESS>Sent: Wednesday, May 4, 2016 12:13 PM
To: Microsoft/BotBuilder<EMAIL_ADDRESS>Cc: Tom Laird-McConnell<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [Microsoft/BotBuilder] Markdown in messages sent to Facebook Messenger channel ignored (#224)
It would be great if you could remove the markdown then.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/BotBuilder/issues/224#issuecomment-216970636

But A1 is still A1 and not A1.

yes, that is by design.
The intent of the markdown is to express emphasis on that bit of text.  It is pretty normal for people to express emphasis for text by putting stars on either side.

OK. Got it.


toImageDiffEqual -- tolerance not used when there's a document element

By design? I think it should still respect the tolerance argument passed in.

Closing for now. If this is still an issue, please bring it up again.


create the project size file if it doesn't exist when loading project dir metadata into memory

the method updateDirSize is already verified by FlowPreparerTest#testSetupProject, so unit test is not needed.

Pull Request Test Coverage Report for Build 3941

5 of 15 (33.33%)  changed or added relevant lines in 2 files are covered.
5 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.01%) to 35.861%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-exec-server/src/main/java/azkaban/execapp/FlowPreparer.java
5
7
71.43%

azkaban-exec-server/src/main/java/azkaban/execapp/FlowRunnerManager.java
0
8
0.0%

Files with Coverage Reduction
New Missed Lines
%

azkaban-exec-server/src/main/java/azkaban/execapp/FlowRunnerManager.java
1
22.72%

azkaban-common/src/main/java/azkaban/jobExecutor/AbstractProcessJob.java
2
64.29%

azkaban-exec-server/src/main/java/azkaban/execapp/JobRunner.java
2
76.67%

Totals

Change from base Build 3938:
-0.01%

Covered Lines:
10319

Relevant Lines:
28775

💛  - Coveralls


FR: Add a retry option to upload-symbols

[REQUIRED] Step 1: Describe your environment

Xcode version: 12.0.1
Firebase SDK version: 7.0.0
Installation method:  Swift Package Manager
Firebase Component: Crashlytics

[REQUIRED] Step 2: Describe the problem
Starting on Monday the 16th, when uploading DSYMs, it fails with the following errors. After a few attempts, some uploads succeed. Still seems to be happening, but less frequent. Looking at the Firebase Community Slack, several other people are experiencing this issue as well.
[06:28:22]: ▸ Fetching upload-symbols settings...
[06:28:22]: ▸ error: Could not fetch upload-symbols settings: The request timed out.
[06:28:22]: ▸ Command PhaseScriptExecution failed with a nonzero exit code

Today running the commands manually (2nd option found here) it succeeded for me, however this morning we kicked off 2 builds. One at 10:55 and another at 10:56. The 10:55 failed with the above error, while the second one succeeded. Seems to be much less frequent now, but still sporadic.
Steps to reproduce:
What happened? How can we make the problem occur?
Run a build and uploads dsyms, or just upload existing dsyms. Seems to be sporadic.
Suggestions:
Add a fallback to upload-symbols that will attempt a retry x number of times before a failure is triggered. This would allow CI systems to try multiple times before failing and requiring the end user to kick off multiple builds in hopes of getting one that successfully uploads.

This should be fixed now

Yes, according to https://status.firebase.google.com/incident/Crashlytics/20006, this should be resolved. Thanks for the report.

@paulb777 would we be able to use the suggestion as a FR?

@jostster Done. I updated the title and labels.

Hi @jostster ,
Upload symbols currently retries 10 times by default. Have you been running into this issue still?


Where to put the exported folder "stable_diffusion_weights" in a local stable diffusion installation

Hello. Thanx for the good work. I managed to get a trained model by using a colab notebook. Now I exported the model in the folder "stable_diffusion_weights" and downloaded it. Where do I put the folder in a local stable-diffusion installation and use it in the prompt? I use the version of automatic1111.

You need to wait for the translate tool.

Ok. Thnx for answering.

name the trained model file "model.ckpt" and put it into folder "stable-diffusion-webui/models/Stable-diffusion/",  it should work.

Which file ist the trained model? There are several bin files.

I found a way. I used this script https://gist.github.com/jachiam/ef621e765c2d88f9dc090ee48f6ced89 to convert the model of the folder SKS. Then I pruned the file with https://github.com/JoePenna/Dreambooth-Stable-Diffusion/blob/main/scripts/prune-ckpt.py. You got a CKPT-file at the end.
Instructions: https://www.youtube.com/watch?v=_e5ymV4zY3w&t=175s

you can also follow the instructions here https://github.com/CompVis/stable-diffusion#stable-diffusion-v1
mkdir -p models/ldm/stable-diffusion-v1/
ln -s <path/to/model.ckpt> models/ldm/stable-diffusion-v1/model.ckpt


Error during Model Evaluation: ValueError: need at least one array to concatenate

After training on INRIA dataset using the polygonized_unetresnet_leaderboard run, I tried to evaluate the model using --mode eval on the same config. The error was faced in the tensorpoly.py file inside the transforms folder.
File "Polygonization-by-Frame-Field-Learning/pytorch_lydorn/torch_lydorn/torchvision/transforms/tensorpoly.py", line 78, in polygons_to_tensorpoly
pos = np.concatenate(polygon_list, axis=0)
File "<array_function internals>", line 180, in concatenate
ValueError: need at least one array to concatenate
Here, the polygon list is empty, there are no polygons there so it is not finding any arrays to concatenate. It is in the polygon_to_tensorpoly function and the author has mentioned in the comments in Line 50 # TODO: If there are no polygons but it has not been implemented. I would like to ask if anyone had come across this problem. I would glad to learn more about it.
Thank you.

I meet the same problem like this. Have you solved this problem yet?


Fixes issues with #30 Issue with multiple ul-li lists where ul-li lists

Fixes issues with #30 Issue with multiple ul-li lists where ul-li list contains only one item (#33)

add failing test case for multiple bulletlists with only one bullet

create an opening ul/ol tag when none have been created before

fix indentation and typo in comments

add failing test case for multiple bulletlists with only one bullet

create an opening ul/ol tag when none have been created before
fix indentation and typo in comments

improved inline documentation and added a change log entry

(cherry picked from commit e1e2c7c702e47e2bfe6e9cbf2e0c1cd9002e7e38)

Not needed anymore, fixed in upstream's master.


CleverTapSDK +[CTPreferences putObject:forKey:]

Seeing a lot of CleverTapSDK+[CTPreferences putObject:forKey:] crashes lately on the latest version of iOS (12.1.4)
Please find the crash log below:
CT-crash.txt

Hey @r-a-o ,
Please check the issue #11 looks similar.

Hi @Aditi3
I have taken a look, we don't have any KVO observers on CT preferences nor do we have any third party SDKs that would mysteriously cause a crash on calling CT preferences.
Furthermore, it looks like the putObject method of CTPreferences class is writing preferences to APMSqliteStore (SQLite store) which is causing a crash in some write-transaction scenario.
This issue has only started very recently for us and is a big percentage of our app crashes now (42crashes out of 60 overall) which is very concerning to us. Would appreciate swift action in resolving the issue.
Let me know if you need any more details.

Hey @r-a-o
I request you to check KVO observers on NSUserDefaults, not on CTPreferences.
Moreover, our SDK nowhere use APMSqliteStore to store the data. We use NSUserDefaults for storing data in the preference.
Our SDK code is open source, you can actually take a look at putObject method of the CTPreferences class.
Additionally, to help you better here and identify why the crash has started very recently for your application I would request you to write to<EMAIL_ADDRESS>So that we can look into this further.
Thanks!


Infinite loop occurs in vocabularies

Description of bug
Page hangs infinitely when a sort of special characters are entered into Tag Add page.
Steps to reproduce
List the steps to reproduce the behavior:

Install 9.2.2 (or use 9.4.x branch) and login as host;
Go to Settings > Vocabularies
Open Tags panel
Try to add a new term named "&test;".

Current result
The request will never complete.
Expected result
The name should able added.
Screenshots
Error log
Additional context
Affected version

[x] 9.4.0 release candidate

Affected browser

[x] Chrome
[x] Firefox
[x] Safari
[x] Internet Explorer
[x] Edge

Merged


Tracking issue for release 0.10.4

If you want to help with the next release, please add a message here picking one item below! There are a few things only I can do, marked with 🔑 below, and a few other only members of the chemfiles organisation can do, marked with 🗝 below.
Pre-built chemfiles

[x] backport remaining PR to the 0.10 release branch: #473
[x] update VERSION file and tag the release on chemfiles/chemfiles
[x] PR on conda-forge/chemfiles-lib-feedstock: https://github.com/conda-forge/chemfiles-lib-feedstock/pull/52
[x] Build release for Julia (https://github.com/JuliaPackaging/Yggdrasil): https://github.com/JuliaPackaging/Yggdrasil/pull/6720
[x] Build and upload to github (https://github.com/chemfiles/chemfiles-prebuilt)

Language bindings
Python

[x] Update the submodule, update code, create PR: https://github.com/chemfiles/chemfiles.py/pull/48
[x] Tag release 🗝
[x] Create PR on conda-forge/chemfiles-python-feedstock: https://github.com/conda-forge/chemfiles-python-feedstock/pull/29
[x] Download wheels from CI for the tag & upload them to PyPI 🔑

Julia

[x] Update Chemfiles_jll version, create PR: https://github.com/chemfiles/Chemfiles.jl/pull/75
[x] Tag release 🗝
[x] Register the new version using https://juliahub.com/ui/Registrator 🗝: https://github.com/JuliaRegistries/General/pull/83767

Rust

[x] Update the submodule, update code, create PR: https://github.com/chemfiles/chemfiles.rs/pull/44
[x] Tag release 🗝
[x] Release on crates.io 🔑

Fortran

[x] Update the submodule, update code, create PR: https://github.com/chemfiles/chemfiles.f03/pull/16
[x] Tag release 🗝

Documentation

[x] Check the documentation for all tags, and update it on the website

Done!


🧑💻: add language translator

:red_circle: Title :add language translator
:red_circle: Enhancement Aim : "Implement a language translator to support Indian native languages. This feature will allow users to translate content into languages such as Hindi, Tamil, Telugu, Bengali, and others, enhancing accessibility and user experience."
:red_circle: Changes :  use google api
Screenshots 📷

:white_check_mark: To be Mentioned while taking the issue :

Full name : Ananya Gupta
What is your participant role? (Mention the Open Source Program name. Eg. GSOC, GSSOC, SSOC, JWOC, etc.) gssoc ext hacktoberfest

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

#283


The Theme's Demo on the Hugo Website is missing its Hugo Pipes Assets

Hi @appernetic
On the Hugo Themes website the demo of the Hugo Bootstrap Premium Theme has its Hugo Pipes Assets missing.
For a workaround please see the Common Permalink Issues in the updated README of the Hugo Themes repository.

If you are using Hugo Pipes to publish your theme's resources due to bug gohugoio/hugo#5226 you will need to temporarily use .RelPermalink in the templates, so that these assets are served correctly on the website.

For example change line 29 of /layouts/partials/base/imports.html/ to:
<link rel="stylesheet" href="{{ $css.RelPermalink }}" integrity="{{ $css.Data.Integrity }}">
Please do this change in the theme's templates and let me know.
Thanks!
CC / @digitalcraftsman

Hello again @appernetic your theme was removed from the Hugo website.
If you apply the fix mentioned in this issue feel free to notify us.
We will be more than happy to have the theme added back to the showcase.
Thanks

Your theme was added again with commit https://github.com/gohugoio/hugoThemes/commit/2d9f912db92c3cb2d477a39026e9c9b684da8460
It seems that the problem was due to a bug. See https://github.com/gohugoio/hugo/issues/5226 for the details.
Sorry for the noise.

@onedrawingperday is this issue already fixed or did I miss something?

No it is not fixed. The commit was reverted. This issue still stands as is.

I've seen that Bjørn Erik added and later removed this theme due to https://github.com/gohugoio/hugo/issues/5226. What left me irritated was that this issue hasn't been reopened to track the issue that caused the initial removal of this theme.


Add postcard crate to comparison

Hey! I have a crate called postcard, which is aimed at embedded/WASM use cases, and has a format/style similar to bincode.
Here are the numbers I got locally:
    Finished release [optimized] target(s) in 8.82s
     Running `target/release/bench`
NoProto:     setup: 0.011
Avro:     setup: 0.096
Flatbuffers:  setup: 0.002

========= SIZE BENCHMARK =========
NoProto:     size: 209b, zlib: 167b
Flatbuffers: size: 264b, zlib: 181b
Bincode:     size: 163b, zlib: 129b
Postcard:    size: 128b, zlib: 119b
Protobuf:    size: 154b, zlib: 141b
MessagePack: size: 311b, zlib: 193b
JSON:        size: 439b, zlib: 184b
BSON:        size: 414b, zlib: 216b
Prost:       size: 154b, zlib: 142b
Avro:        size: 702b, zlib: 337b
Flexbuffers: size: 490b, zlib: 309b
Abomonation: size: 261b, zlib: 162b
Rkyv:        size: 180b, zlib: 153b
Raw BSON:    size: 414b, zlib: 216b
MessagePack: size: 296b, zlib: 187b
Serde JSON:  size: 446b, zlib: 198b

======== ENCODE BENCHMARK ========
NoProto:           668 ops/ms 1.00
Flatbuffers:      2451 ops/ms 3.67
Bincode:          7353 ops/ms 10.96
Postcard:         3861 ops/ms 5.76
Protobuf:         1100 ops/ms 1.65
MessagePack:       684 ops/ms 1.03
JSON:              595 ops/ms 0.89
BSON:              158 ops/ms 0.24
Prost:            1397 ops/ms 2.09
Avro:              175 ops/ms 0.26
Flexbuffers:       326 ops/ms 0.49
Abomonation:      4762 ops/ms 7.10
Rkyv:             3344 ops/ms 5.00
Raw BSON:          173 ops/ms 0.26
MessagePack:       234 ops/ms 0.35
Serde JSON:        853 ops/ms 1.28

======== DECODE BENCHMARK ========
NoProto:           684 ops/ms 1.00
Flatbuffers:      7937 ops/ms 11.56
Bincode:          4386 ops/ms 6.41
Postcard:         4386 ops/ms 6.40
Protobuf:         1422 ops/ms 2.08
MessagePack:       508 ops/ms 0.74
JSON:              458 ops/ms 0.67
BSON:              151 ops/ms 0.22
Prost:            2203 ops/ms 3.21
Avro:               64 ops/ms 0.09
Flexbuffers:       419 ops/ms 0.61
Abomonation:     52632 ops/ms 75.43
Rkyv:            34483 ops/ms 49.16
Raw BSON:          706 ops/ms 1.03
MessagePack:       228 ops/ms 0.33
Serde JSON:        521 ops/ms 0.76

====== DECODE ONE BENCHMARK ======
NoProto:         18519 ops/ms 1.00
Flatbuffers:    111111 ops/ms 5.54
Bincode:          4505 ops/ms 0.25
Postcard:         4545 ops/ms 0.25
Protobuf:         1464 ops/ms 0.08
MessagePack:       626 ops/ms 0.03
JSON:              551 ops/ms 0.03
BSON:              156 ops/ms 0.01
Prost:            2217 ops/ms 0.12
Avro:               67 ops/ms 0.00
Flexbuffers:     16129 ops/ms 0.88
Abomonation:    166667 ops/ms 9.05
Rkyv:           333333 ops/ms 15.00
Raw BSON:        12500 ops/ms 0.68
MessagePack:       266 ops/ms 0.01
Serde JSON:        521 ops/ms 0.03

====== UPDATE ONE BENCHMARK ======
NoProto:          8696 ops/ms 1.00
Flatbuffers:      1805 ops/ms 0.21
Bincode:          2959 ops/ms 0.34
Postcard:         2066 ops/ms 0.24
Protobuf:          577 ops/ms 0.07
MessagePack:       255 ops/ms 0.03
JSON:              403 ops/ms 0.05
BSON:              119 ops/ms 0.01
Prost:             932 ops/ms 0.11
Avro:               44 ops/ms 0.01
Flexbuffers:       193 ops/ms 0.02
Abomonation:      4348 ops/ms 0.50
Rkyv:             2833 ops/ms 0.33
Raw BSON:          125 ops/ms 0.01
MessagePack:       157 ops/ms 0.02
Serde JSON:        327 ops/ms 0.04

//! | Format / Lib                                               | Encode  | Decode All | Decode 1 | Update 1 | Size (bytes) | Size (Zlib) |
//! |------------------------------------------------------------|---------|------------|----------|----------|--------------|-------------|
//! | **Runtime Libs**                                           |         |            |          |          |              |             |
//! | *NoProto*                                                  |         |            |          |          |              |             |
//! |        [no_proto](https://crates.io/crates/no_proto)       |     668 |        684 |    18519 |     8696 |          209 |         167 |
//! | Apache Avro                                                |         |            |          |          |              |             |
//! |         [avro-rs](https://crates.io/crates/avro-rs)        |     175 |         64 |       67 |       44 |          702 |         337 |
//! | FlexBuffers                                                |         |            |          |          |              |             |
//! |     [flexbuffers](https://crates.io/crates/flexbuffers)    |     326 |        419 |    16129 |      193 |          490 |         309 |
//! | JSON                                                       |         |            |          |          |              |             |
//! |            [json](https://crates.io/crates/json)           |     595 |        458 |      551 |      403 |          439 |         184 |
//! |      [serde_json](https://crates.io/crates/serde_json)     |     853 |        521 |      521 |      327 |          446 |         198 |
//! | BSON                                                       |         |            |          |          |              |             |
//! |            [bson](https://crates.io/crates/bson)           |     158 |        151 |      156 |      119 |          414 |         216 |
//! |         [rawbson](https://crates.io/crates/rawbson)        |     173 |        706 |    12500 |      125 |          414 |         216 |
//! | MessagePack                                                |         |            |          |          |              |             |
//! |             [rmp](https://crates.io/crates/rmp)            |     684 |        508 |      626 |      255 |          311 |         193 |
//! |  [messagepack-rs](https://crates.io/crates/messagepack-rs) |     234 |        228 |      266 |      157 |          296 |         187 |
//! | **Compiled Libs**                                          |         |            |          |          |              |             |
//! | Flatbuffers                                                |         |            |          |          |              |             |
//! |     [flatbuffers](https://crates.io/crates/flatbuffers)    |    2451 |       7937 |   111111 |     1805 |          264 |         181 |
//! | Bincode                                                    |         |            |          |          |              |             |
//! |         [bincode](https://crates.io/crates/bincode)        |    7353 |       4386 |     4505 |     2959 |          163 |         129 |
//! | Postcard                                                   |         |            |          |          |              |             |
//! |        [postcard](https://crates.io/crates/postcard)       |    3861 |       4386 |     4545 |     2066 |          128 |         119 |
//! | Protocol Buffers                                           |         |            |          |          |              |             |
//! |        [protobuf](https://crates.io/crates/protobuf)       |    1100 |       1422 |     1464 |      577 |          154 |         141 |
//! |           [prost](https://crates.io/crates/prost)          |    1397 |       2203 |     2217 |      932 |          154 |         142 |
//! | Abomonation                                                |         |            |          |          |              |             |
//! |     [abomonation](https://crates.io/crates/abomonation)    |    4762 |      52632 |   166667 |     4348 |          261 |         162 |
//! | Rkyv                                                       |         |            |          |          |              |             |
//! |            [rkyv](https://crates.io/crates/rkyv)           |    3344 |      34483 |   333333 |     2833 |          180 |         153 |

Thanks for putting these benchmarks together!

Thank you for the PR!  I'll get this merged in soon.

Awesome! I wasn't sure exactly how all of your benchmarks were structured, but I basically took the bincode benchmark and reworked it for postcard.
Are you interested in benchmarking without allocations in the future? For example, postcard can serialize to a suitably sized buffer (instead of creating a new vec or inserting into it). I think some of the measurements are definitely impacted by the allocations. For example, postcard is roughly 1.5-2.0x faster on the encode benchmark when encoding into an already allocated buffer:
Postcard:         3968 ops/ms 5.51
Postcard (buf):   7246 ops/ms 10.01

Yeah that's tricky, setting up these benchmarks so everyone gets a fair chance has been challenging.
I think, for example, it's perfectly acceptable to use &str in your structs to increase performance even though many libraries don't support zero copy deserializing and can only use String types.
The main goal of the benchmarks is to record something as close to real world performance / usage as possible.  I doubt many people will know ahead of time how large a buffer needs to be in order to accommodate some date their encoding.  They'd likely end up making it a bit (or a lot) too large, then resizing it down later if they need to save it to disk or send it over the wire.  How large should we make the initial buffer in the benchmark?  How large would the typical user make it?   If you make it something like 1MB it'll fit almost any data you throw at it but the initial allocation is going to be crazy heavy and ruin the benchmark numbers.  I'm just not sure how to make the preallocation a fair comparison with the other libraries.
The allocating Vec<u8> seems to be a simple, even playing field every library and format can accommodate.
But you a raise a good point, which is sometimes libraries have really good optimizations in specific use cases (like the Update 1 for NoProto) that would be useful for developers to know.  Some libraries, for example, perform incredibly as long as you only use numbers and booleans.  These libraries are slowed WAY down by Strings and Vecs.
I think it would be really cool to put a small website together that covers all of these unique cases and provides benchmarks for them, similar to the benchmarks game website with programming languages.  The more I learn about encoding / decoding formats the more I realize there is no magic wand format/library.


Replace Session by Preset for clarity.

Will change file names in subsequent change, I wasn't sure the diff view would have worked properly had I renamed files...

This change replaces "Session" by "Preset" in the UI but also throughout the codebase.

I am also interested if it displays diff correctly.

It worked for me in the past.


[Bug] Custom series rotation origin

Version
5.1.1
Link to Minimal Reproduction
No response
Steps to Reproduce
         {
                            type: 'image',
                            rotation:45,
                            originX: x,
                            originY: y - height,
                            z2: 2,
                            style: {
                                image: imgSrc,
                                x: x,
                                y: y - height,
                                width: width,
                                height: height,
                                position: 'absolute'
                            },
                        },

Current Behavior
I want to rotate the picture 45 degrees, but it's skewed out of the X and Y coordinates
我想把图片旋转45度，但是它偏移出了X轴和Y轴坐标系
Expected Behavior
I want it to be after the rotation, not offset, in the same position as before the rotation
我希望在旋转的之后，不要偏移，还是在未旋转之前的位置上
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

就是在这段代码中旋转45度，就会偏移出原本设定的x轴y轴的坐标系
{
type: 'image',
rotation: 45,
z2: 2,
style: {
image: imgSrc,
x: x,
y: y-height,
width: width,
height: height,
position: 'absolute'
},
},

Centering rotation is doable, but there is probably a bug with the degrees of rotation.
Strange that it hasn't been reported yet...
Also transition is not right, maybe related the degrees bug?
Demo Code - 11 degrees looks more like 90 degrees.

option = {
xAxis: {
axisLine: {
lineStyle: {
color: '#90979c'
}
},
data: ['a', 'b', 'c', 'd', 'e', 'f']
},
yAxis: {
name: 'KM'
},
series: [
{
type: 'custom',
data: [['a', 3, 45],['b', 4, 90],['c', 1, 0],['d', 2, 10],['e', 3.3, 30],['f', 4.4, 50]],
renderItem: function (params, api) {
let xValue = api.value(0);
let yValue = api.value(1);
let x = api.coord([xValue, 0])[0],
y = api.coord([0, yValue])[1];
let width = 50,
height = 25;
let rotation=api.value(2);
return {
type: 'group',
children: [
{
type: 'image',
z2: 2,
rotation,
$action: 'replace',
transition: 'rotation',
originX: x + width / 2,
originY: y + height / 2,
style: {
image: 'https://echarts.apache.org/examples/data/asset/geo/Beef_cuts_France.svg',
x: x,
y: y,
width: width,
height: height
}
},
{
type: 'rect',
shape: {
x: x,
y: y - height,
width: width,
height: height
},
style: {
fill: '#000',
lineWidth: 2
}
}
]
};
}
}
]
};
So here's the full code, but actually the picture is rotated too much to offset the inside of the rectangle
I want the image to be rotated so that the position is still in the rectangle
这是完整代码，实际上图片旋转角度过大会偏移出矩形的内部
我想要的效果是，当图片旋转过后，位置还是在矩形中

Demo Code

@l406054531, please refrain from posting custom code in need of professional debugging.
This board is for well isolated ECharts bugs presented with Minimal Reproduction code.
A good alternative is stackoverflow where there are a lot more volunteers to help with any kind of problem.
disclaimer
opinions expressed in this post are strictly personal, as ECharts user, not a developer


python3Packages.deal-solver: 0.1.0 -> 0.1.1

Description of changes
upstream fixed failing tests
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 178216 run on x86_64-linux 1

3 packages built:

python310Packages.deal-solver
python39Packages.deal
python39Packages.deal-solver


Move to resque org?

Hello! Curious if there's any interest in moving this repo to the @resque org. I've been trying to get more of the resque extensions in a single place to make it easier for folks to find & contribute to popular extensions.
What do you think?

Sorry for the slow reply.  I'm all for it! :)  Just let me know how and where to coordinate.

@nevans followed up via email!

I think this can be closed now.  Thanks, @iloveitaly! 🙂


How to get lazysizes to work with IE9?

More of a question than a bug. I can't seem to get lazysizes to work properly in IE 9. I'm probably missing something simple, any ideas? I mean it kinda works with picture, but not srcset.
According to IE 9s dev tools no images are loaded at all when using srcset while using the following code:
<img
    src="data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 722 810'%3E%3C/svg%3E"
    class="lazyload"
    data-srcset="/img-1.jpg 480w, /img-640-1.jpg 640w, /img-800.jpg 800w"
    data-sizes="auto" />

When using the picture syntax, only the data-src of the img element itself is loaded and displayed, all the different sized images given in the source elements are disregarded. Is this how lazysizes is supposed to work? I mean I could totally live with that, just unsure.
Here's my code:
<picture>
    <!--[if IE 9]><video
    style="display: none"><![endif]-->
    <source data-srcset="/img-1024-1.jpg" media="(max-width: 1024px)" />
    <source data-srcset="/img-1440-1.jpg" />
    <!--[if IE 9]></video><![endif]-->
    <img
        src="data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 368 547'%3E%3C/svg%3E"
        data-src="/img-1.jpg" class="lazyload" />
</picture>

Any ideas what I'm doing wrong? And also why srcset isn't working in IE 9 at all?
Thanks a lot! Lazysizes is awesome!

Problem basically solved :)


Fixed number of parameter isuue for fuction: async_pipeline_from_audi…

Fix the too many parameter issue for the function async_pipeline_from_audio_stream
Changes:

Created two dataclasses that capture parameters that seem to be related (WakeWordConfig and PipelineConfig).
Changed all the calls to this function to reflect the changes.

Tested:

Ran Sonarqube once the changes had been made - The issue was no longer present, however the quality gate for new code now fails due to line coverage and duplicated code in tests which I duplicated intentionally to keep tests independent and isolated.
Ran the particular test file that related to this function - All tests pass, as shown below.

Looks great! Were you able to run tests for entity.py and satellite.py too?

No, I only ran the file which contained the tests for this function, I can definitely run the tests for the other files too though.


Support relative week of days

Sample utterances: "second sunday", "next Sunday", "two sundays from now"

@rubio41 isn't this working?

"two sundays from now" still not be recognized in C# and Javascript.


Fix ISO8601Formatter parsing dates that end in Z

Why:

Times are expressed in UTC (Coordinated Universal Time), with a special UTC designator ("Z").
http://www.w3.org/TR/NOTE-datetime

ISO8601Formatter would fail to parse dates(unless it hit the default case) ending in Z

This change addresses the need by:

Adding Enum cases to support character counts for dates with Z
Remove default case of the switch by making it exhaustive
Add tests for these cases

Thank you ^^


Add an auto-scroll button for mobile

Rather than automatically scrolling upon Play, make a v button visible upon response that can be clicked to do the scrolling. Add a title explaining what it does.

Tried this out, not usually very useful after all.


With latest Helm unittest version 0.6.2 - equalRaw assertion is no longer working

After latest release of Helm unittest yesterday - 0.6.2, there seems to be a regression, as the equalRaw assertion is throwing false positive errors in the unit tests we have.
For example:
  - it: with default values
    asserts:
      - equalRaw:
          value: |
            -----
            HiveMQ Platform release "test-hivemq-platform" installed in namespace "test-hivemq-platform-namespace"

            Documentation can be found here: https://docs.hivemq.com/hivemq-platform-operator/index.html
            -----

With latest version, it's now failing with below:
        - with default values

                - asserts[0] `equalRaw` fail
                        Template:       hivemq-platform/templates/NOTES.txt
                        Expected to equal:
                                |-
                                  -----
                                  HiveMQ Platform release "test-hivemq-platform" installed in namespace "test-hivemq-platform-namespace"

                                  Documentation can be found here: https://docs.hivemq.com/hivemq-platform-operator/index.html
                                  -----
                        Actual:
                                |2
                                  ---
                                  --
                                  HiveMQ Platform release "test-hivemq-platform" installed in namespace "test-hivemq-platform-namespace"

                                  Documentation can be found here: https://docs.hivemq.com/hivemq-platform-operator/index.html
                                  ---
                                  --
                        Diff:
                                --- Expected
                                +++ Actual
                                @@ -1,3 +1,4 @@
                                -|-
                                -  -----
                                +|2
                                +  ---
                                +  --
                                   HiveMQ Platform release "test-hivemq-platform" installed in namespace "test-hivemq-platform-namespace"
                                @@ -5,3 +6,4 @@
                                   Documentation can be found here: https://docs.hivemq.com/hivemq-platform-operator/index.html
                                -  -----
                                +  ---
                                +  --

You can reproduce this by your own by:

With Helm unittest 0.6.2, clone the HiveMQ Helm charts repo: git clone https://github.com/hivemq/helm-charts.git
Running helm unittest ./charts/hivemq-platform -f './tests/**/*_test.yaml' locally.

Hello @quintush and sorry for the direct ping, but seems the latest version of Helm unittest is breaking the equalRaw assertion as per above comment.

Hello @afalhambra-hivemq
Thanks for the feedback.
Based om the example I know where to look, but need to check how to solve it.
Greetings,
@quintush

So I would assume the solution is copying Helm https://github.com/helm/helm/blob/145d12f82fc7a2e39a17713340825686b661e0a1/pkg/releaseutil/manifest.go#L39
The function name is SplitManifests and in helm the Manifest is every file that contain following
// SimpleHead defines what the structure of the head of a manifest file
type SimpleHead struct {
	Version  string `json:"apiVersion"`
	Kind     string `json:"kind,omitempty"`
	Metadata *struct {
		Name        string            `json:"name"`
		Annotations map[string]string `json:"annotations"`
	} `json:"metadata,omitempty"`
}

There is another line https://github.com/helm/helm/blob/145d12f82fc7a2e39a17713340825686b661e0a1/pkg/releaseutil/manifest.go#L40

// Basically, we're quickly splitting a stream of YAML documents into an  // array of YAML docs.


Background notifications management

React native 0.34
react-native-fcm 2.3.0
Real android device with 5.1 OS version (Lollipop)
Hi,
I would like to achieve the following thing:
When the application is running in background and the user receives multiple notifications, if he/she opens the app again without pressing any banner, each banner should disappear and the app should be updated based on the data received through the notifications.
Is there a possible way to achieve this?
Now if I open the app without pressing one banner (just taking it from background to foreground) no banner disappears and the app does not update.

try cancelAllLocalNotifications

Your solution works only if the app is closed. When the app is in background I have the same behaviour. How can I call cancellAllLocalNotifications when the app is resumed?

Sorry, I resolved using AppState. However, I can clean all banners but I cannot figure out how to retrieve notifications data when the app is in background or is closed. Is there a way to achieve that?

you can call getScheduledLocalNotifications and it returns a promise.
However, you have to write native code to handle when app is not running at all.

close due to inactivity


KAFKA-3229 ensure that root statestore is registered with ProcessorStateManager

Pass through the root StateStore in the init method so the inner StateStore can register that object.

LGTM. I see that the current state store registration procedure is broken.
This change will fix the issue. Thanks.

LGTM


Scaffold-DbContext shows 'One or more errors occurred'

No stacktrace is printed either. The message comes from PowerShell throwing $null. For some reason, it looks like an exception is being thrown without a message...
I hit this using the EntityFramework.Sqlite provider and not having sqlite3.dll available (i.e. via aspnet/Microsoft.Data.Sqlite#134)

AggregateException?

@divega That was my suspicion too.

Can I get more details? I'm not seeing it. If I do Scaffold-DbContext in the Package Manager Console without sqlite3 I get:
Unable to load DLL 'sqlite3': The specified module could not be found. (Exception from HRESULT: 0x8007007E)
If I do it on the command line. I get:
System.AggregateException: One or more errors occurred. ---> System.DllNotFoundException: Unable to load DLL 'sqlite3': The specifie
d module could not be found. (Exception from HRESULT: 0x8007007E)
   at Microsoft.Data.Sqlite.Interop.NativeMethods.sqlite3_open_v2(IntPtr filename, Sqlite3Handle& ppDb, Int32 flags, IntPtr vfs)
   at Microsoft.Data.Sqlite.Interop.NativeMethods.sqlite3_open_v2(String filename, Sqlite3Handle& ppDb, Int32 flags, String vfs)
   at Microsoft.Data.Sqlite.SqliteConnection.Open()
   at Microsoft.Data.Entity.Sqlite.Design.ReverseEngineering.SqliteMetadataModelProvider.ConstructRelationalModel(String connectionS
tring) in C:\git\aspnet\EntityFramework\src\EntityFramework.Sqlite.Design\ReverseEngineering\SqliteMetadataModelProvider.cs:line 45
   at Microsoft.Data.Entity.Relational.Design.ReverseEngineering.RelationalMetadataModelProvider.GenerateMetadataModel(String connec
tionString) in C:\git\aspnet\EntityFramework\src\EntityFramework.Relational.Design\ReverseEngineering\RelationalMetadataModelProvide
r.cs:line 57
   at Microsoft.Data.Entity.Relational.Design.ReverseEngineering.ReverseEngineeringGenerator.GetMetadataModel(ReverseEngineeringConf
iguration configuration) in C:\git\aspnet\EntityFramework\src\EntityFramework.Relational.Design\ReverseEngineering\ReverseEngineerin
gGenerator.cs:line 89
   at Microsoft.Data.Entity.Relational.Design.ReverseEngineering.ReverseEngineeringGenerator.GenerateAsync(ReverseEngineeringConfigu
ration configuration, CancellationToken cancellationToken) in C:\git\aspnet\EntityFramework\src\EntityFramework.Relational.Design\Re
verseEngineering\ReverseEngineeringGenerator.cs:line 58
   at Microsoft.Data.Entity.Design.DatabaseOperations.ReverseEngineerAsync(String provider, String connectionString, String outputDi
r, Boolean useFluentApiOnly, CancellationToken cancellationToken) in C:\git\aspnet\EntityFramework\src\EntityFramework.Commands\Desi
gn\DatabaseOperations.cs:line 74
   at Microsoft.Data.Entity.Commands.Program.<ReverseEngineerAsync>d__14.MoveNext() in C:\git\aspnet\EntityFramework\src\EntityFrame
work.Commands\Commands\Program.cs:line 375

I'm not seeing it anymore. Must've been a bug in my code that got fixed before merging.

Wait, I'm still not seeing a stacktrace...

Ah, looks like my use of Write-Output is wrong.


[BEAM-9415] fix postcommit xvr tests

This PR checks whether the coder is compatible with Java SDK before rehydrating it from expanded components. The coder id renaming is only needed for Java SDK compatible coders so the change is safe.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @chamikaramj

Could you add more details about the breakage and the fix to the PR description and JIRA ? (since we are updating External.java here).

Updated.

Run Python PreCommit

python precommit failure looks irrelevant.


stepdefs formatter crashes with undefined method step_definition for nil:NilClass

bundle exec cucumber -f stepdefs
...................................................................undefined method `step_definition' for nil:NilClass (NoMethodError)
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/formatter/usage.rb:29:in `after_test_step'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/formatter/ignore_missing_messages.rb:10:in `method_missing'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/formatter/legacy_api/adapter.rb:38:in `after_test_step'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/formatter/fanout.rb:16:in `block in method_missing'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/formatter/fanout.rb:15:in `each'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/formatter/fanout.rb:15:in `method_missing'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/runner.rb:34:in `around_hook'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/around_hook.rb:11:in `describe_to'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/case.rb:106:in `block (2 levels) in compose_around_hooks'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/case.rb:107:in `compose_around_hooks'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/case.rb:24:in `block in describe_to'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/runner.rb:18:in `test_case'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/filters/prepare_world.rb:11:in `test_case'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/filters/apply_around_hooks.rb:8:in `test_case'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/filters/apply_after_hooks.rb:5:in `test_case'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/filters/apply_before_hooks.rb:5:in `test_case'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/filters/apply_after_step_hooks.rb:8:in `test_case'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/filters/activate_steps.rb:11:in `test_case'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/filters/quit.rb:11:in `test_case'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/filters/locations_filter.rb:17:in `block in done'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/filters/locations_filter.rb:16:in `each'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/filters/locations_filter.rb:16:in `done'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/filter.rb:61:in `done'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/test/filters/tag_filter.rb:18:in `done'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/compiler.rb:23:in `done'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core/gherkin/parser.rb:39:in `done'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core.rb:29:in `parse'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-core-1.4.0/lib/cucumber/core.rb:18:in `compile'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/runtime.rb:68:in `run!'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/lib/cucumber/cli/main.rb:32:in `execute!'
/Users/Jean/.gem/ruby/2.3.0/gems/cucumber-2.3.2/bin/cucumber:8:in `<top (required)>'
/Users/Jean/.gem/ruby/2.3.0/bin/cucumber:23:in `load'
/Users/Jean/.gem/ruby/2.3.0/bin/cucumber:23:in `<main>'

Can you share an example of a feature file that causes this crash please?

@mattwynne You can reproduce the issue using cucumber's own features. Just have a look at #955.

If it's any use, I am seeing this problem using --format usage
Here is the output of a bundle install then running cucumber:
Using rake 11.1.2
Using i18n 0.7.0
Using json 1.8.3
Using minitest 5.9.0
Using thread_safe 0.3.5
Using addressable 2.4.0
Using awesome_print 1.6.1
Using builder 3.2.2
Using byebug 9.0.4
Using mime-types-data 3.2016.0521
Using mini_portile2 2.0.0
Using rack 1.6.4
Using ffi 1.9.10
Using cliver 0.3.2
Using coderay 1.1.1
Installing gherkin 4.0.0
Using cucumber-wire 0.0.1
Using diff-lcs 1.2.5
Using multi_json 1.12.1
Using multi_test 0.1.2
Using dotenv 2.1.1
Using rack-idempotent 0.2.0
Using method_source 0.8.2
Using parallel 1.8.0
Using websocket-extensions 0.1.2
Using slop 3.6.0
Using rspec-support 3.4.1
Using rubyzip 1.2.0
Using websocket 1.2.3
Using bundler 1.12.5
Using faker 1.6.3
Using tzinfo 1.2.2
Using launchy 2.4.3
Using mime-types 3.1
Using nokogiri <IP_ADDRESS>
Using rack-test 0.6.3
Using rack-client 0.4.2
Using childprocess 0.5.9
Installing cucumber-core 1.5.0
Using websocket-driver 0.6.4
Using pry 0.10.3
Using rspec-core 3.4.4
Using rspec-expectations 3.4.0
Using rspec-mocks 3.4.1
Using activesupport 4.2.6
Using mail 2.6.4
Using xpath 2.0.0
Using ey_api_hmac 0.4.12
Using selenium-webdriver 2.53.0
Installing cucumber 2.4.0
Using pry-byebug 3.4.0
Using rspec 3.4.0
Using capybara 2.7.1
Using wp-hmac 0.2.5
Using capybara-angular 0.2.3
Using capybara-screenshot 1.0.13
Using poltergeist 1.9.0
Using site_prism 2.9
Bundle complete! 18 Gemfile dependencies, 58 gems now installed.

bundle exec cucumber --format usage --require=support/ --require=suites/common/step_definitions --require=suites/schedule/step_definitions --exclude=suites/schedule/features/browserstack suites/schedule/features
..................................................................................undefined method `step_definition' for nil:NilClass (NoMethodError)
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/formatter/usage.rb:29:in `after_test_step'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/formatter/ignore_missing_messages.rb:10:in `method_missing'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/formatter/legacy_api/adapter.rb:38:in `after_test_step'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/formatter/fanout.rb:16:in `block in method_missing'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/formatter/fanout.rb:15:in `each'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/formatter/fanout.rb:15:in `method_missing'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/runner.rb:34:in `around_hook'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/around_hook.rb:11:in `describe_to'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/case.rb:106:in `block (2 levels) in compose_around_hooks'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/case.rb:107:in `compose_around_hooks'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/case.rb:24:in `block in describe_to'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/runner.rb:18:in `test_case'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/filters/prepare_world.rb:11:in `test_case'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/filters/apply_around_hooks.rb:8:in `test_case'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/filters/apply_after_hooks.rb:5:in `test_case'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/filters/apply_before_hooks.rb:5:in `test_case'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/filters/apply_after_step_hooks.rb:8:in `test_case'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/filters/activate_steps.rb:11:in `test_case'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/filters/quit.rb:11:in `test_case'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/case.rb:23:in `describe_to'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/filters/locations_filter.rb:17:in `block in done'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/filters/locations_filter.rb:16:in `each'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/filters/locations_filter.rb:16:in `done'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/filter.rb:61:in `done'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/test/filters/tag_filter.rb:18:in `done'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/compiler.rb:23:in `done'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core/gherkin/parser.rb:35:in `done'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core.rb:29:in `parse'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-core-1.5.0/lib/cucumber/core.rb:18:in `compile'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/runtime.rb:67:in `run!'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/lib/cucumber/cli/main.rb:32:in `execute!'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/cucumber-2.4.0/bin/cucumber:8:in `<top (required)>'
/opt/rubies/2.3.1/bin/cucumber:23:in `load'
/opt/rubies/2.3.1/bin/cucumber:23:in `<top (required)>'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/bundler-1.12.5/lib/bundler/cli/exec.rb:63:in `load'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/bundler-1.12.5/lib/bundler/cli/exec.rb:63:in `kernel_load'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/bundler-1.12.5/lib/bundler/cli/exec.rb:24:in `run'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/bundler-1.12.5/lib/bundler/cli.rb:304:in `exec'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/bundler-1.12.5/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/bundler-1.12.5/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/bundler-1.12.5/lib/bundler/vendor/thor/lib/thor.rb:359:in `dispatch'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/bundler-1.12.5/lib/bundler/vendor/thor/lib/thor/base.rb:440:in `start'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/bundler-1.12.5/lib/bundler/cli.rb:11:in `start'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/bundler-1.12.5/exe/bundle:27:in `block in <top (required)>'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/bundler-1.12.5/lib/bundler/friendly_errors.rb:98:in `with_friendly_errors'
/opt/rubies/2.3.1/lib/ruby/gems/2.3.0/gems/bundler-1.12.5/exe/bundle:19:in `<top (required)>'
/opt/rubies/2.3.1/bin/bundle:23:in `load'
/opt/rubies/2.3.1/bin/bundle:23:in `<main>'

+1

I close this issue because in #977, which is in v3.0.0.pre.1, the usage formatter was changed so it does not have an after_test_step method and does not use the legacy_api any longer, therefore the stacktrace above is not possible. Should this kind of problem still exist with the usage formatter in v3.0.0.pre.1, which is highly unlikely since the legacy_api is the likely source of this problem, a new issue with the new stacktrace should be opened.


Release Metal3 0.7.2

A description about the changes this PR brings will be posted in the comments from @alknopfler

Changes:

Added the new suse-network-script.sh in the ipa-downloader to include the fix about upstream issue with the re-provision errors taking older configdrive unit:
https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/915170


Nsis header loader

Fixes #5

[ X] Tests pass
Tests can be run in eclipse with Run -> Run As -> Junit. Those tests will be integrated in Gradle in the next PR.

After discussion with @rossgibb , it was decided to not use the entry point of the PE file to locate the NSIS header because in some cases the header could be located before. So it iterates the bytes and uses the first offset is finds that corresponds to the NSIS Magic.

@rossgibb GitHub's internal editor can read a .editorconfig file. It can be helpful for reviewing from GitHub if it doesn't interfere with the IDE being used for development. I know Eclipse requires a plugin to use it. The idea here is to have the .editorconfig only for GitHub's internal editor. It is mostly helpful when tabs are used for indentation as its size is displayed as 8 spaces by default.


Function to return the network list in all datacenters added

Jira ID
C3-60
Problem
No functionality to get the Networks in vsphere cloud
Solution
Added support for returning the Networks list
Testing
Unit testing done - Returns the networks in datacenter in the vcenter server
Order for Reviewing
below PR needs to be merged first
https://github.com/apporbit/libretto/pull/8

So, you've been writing a lot of what I'd classify as "helper" functions.  I'm wondering if they are best done as taking a vm struct, or if they'd be better separate from it.  i.e. they really have nothing to do with a vm, its just that libretto was based around that.
would it be useful to separate out the loging in code into its own struct that can be embedded in the vm struct?

The basic functions to perform the tasks in libretto are using vm struct. For eg: setUpSession, findDataceter etc. vm struct has username, password, host of vcenter server which are used for setting up connection. vm struct has finder, collector, context which is being used by almost all libretto helper functions.
This could have been separated but this will introduce too much of duplicate code.

There are many helper functions in libretto that uses vm struct to perform that task. Changing the vm struct means changing so many helper functions.
For eg : the vcenter host, login credentials comes with vm struct, context comes with vm struct, finder, collector and client is in vm struct which are used in every helper function in libretto.
This will happen for other clouds as well. Too much complexity.


Illegal Character error

getting that on a line with $. here is the line:
coll.Find({ location: { $near: [Longitude , Latitude] } })
This keeps the package from cleaning/formatting my code on save

I don't understand the issue. $ is not valid Go syntax (and GoSublime does not fmt files with invalid syntax by design)

Sorry this was my mistake. I should have closed this. I am trying out mongodb with go.


formatter bug

bla do
  bla2 do
    bla3 do
      page= <<-HTML
        <body></body>
      HTML
    end
  end
end

=>
bla do
  bla2 do
    bla3 do
      page = <<-HTML
>
L
    end
  end
end

Thanks! Reduced:
page= <<-HTML
  foo
HTML

The problem seems to be that the = is right next to the variable name. I'll investigate, should be easy to fix.


refactor: Improved Docs Page Codebase

Related Issue
#1517
Description
I have made the code easier to read and modular, based on the concept of DRY. This code is renders the exact same webpage as before, while also making it readable.
Lines of code halved from 427 to 261.
Screenshots

okay. well i thought you gave this issue a go after what you said at our discussion on issue #1517

okay. well i thought you gave this issue a go after what you said at our discussion on issue #1517

you can close the PR & issue & just work on the https://github.com/priyankarpal/ProjectsHut/issues/1519 also, we will change the codebase in docs page

well this is a part of the changes supposed to be made for issue #1519
If you could merge, It will be good for the 1519 issue.

well this is a part of the changes supposed to be made for issue #1519 If you could merge, It will be good for the 1519 issue.

yeah I know but we will change the docs page UI & code then we need to change just work on that issue

Kindly accept this as a level1 issue only. I have worked twice on the same issue.
It's a humble request.

Plus I was assigned this issue by you only.

Okay. Noted.

will merge soon


Update readme.md

Corrected: Wrong path in the target name

Thanks for pointing this out!  It was fixed in #11