Service "kubevirt-operator-webhook" not found

What happened:
I've installed kubevirt following this tutorial on AKS: https://kubevirt.io/user-guide//cluster_admin/installation/#installing-kubevirt-on-kubernetes
but when I try to apply the KubeVirt CR it fails with the following error:
Error from server (InternalError): Internal error occurred: failed calling webhook "kubevirt-update-validator.kubevirt.io": failed to call webhook: Post "https://kubevirt-operator-webhook.kubevirt.svc:443/kubevirt-validate-update?timeout=10s": service "kubevirt-operator-webhook" not found

What you expected to happen:
To work
How to reproduce it (as minimally and precisely as possible):
Follow the https://kubevirt.io/user-guide//cluster_admin/installation/#installing-kubevirt-on-kubernetes tutorial
Additional context:
I can't even find where and how should the kubevirt-operator-webhook service being created.
Environment:

KubeVirt version (use virtctl version): v1.3.0
Kubernetes version (use kubectl version): v1.28.9
VM or VMI specifications: N/A
Cloud provider or hardware configuration: Azure
OS (e.g. from /etc/os-release): N/A
Kernel (e.g. uname -a): N/A
Install tools: N/A
Others: N/A

Please share manifests you have applied

I found out that a old version of kubevirt had obsolete webhooks which conflicted with the new version, I found such wehbooks and I've deleted them manually, if somone else has the same issue I can add more details.

@b1zzu how you find the old webhooks?

@FranciscoOchoa94
kubectl get validatingwebhookconfigurations,mutatingwebhookconfigurations

although I can't remember now if it was a mutation or a validation webhook


qemu: network: disable dnsmasq DNS server

Dnsmasq can be configured (and already is) to only listen on specific
interfaces—for DHCP. By default, it will still listen on port 53 for DNS
queries, which makes it impossible to run multiple instances
concurrently.
From the man page:
-p, --port=
Listen on  instead of the standard DNS port (53). Setting this to
zero completely disables DNS function, leaving only DHCP and/or TFTP.
Specify --port=0 to disable DNS, and allow multiple instances to run
concurrently.
Change-type: patch
Signed-off-by: Joseph Kogut<EMAIL_ADDRESS>

@balena-ci rebase

@balena-ci I self-certify!


Getting: Incompatible language version. Compatible range: 13 - 13. Got: 14

I've tried bumping tree-sitter-swift back a few version still got this error.

Reproducible here

tree-sitter-swift-version-issue/node_modules/tree-sitter/index.js:259
  setLanguage.call(this, language);
              ^

RangeError: Incompatible language version. Compatible range: 13 - 13. Got: 14
    at Parser.setLanguage (/workspace/GitHub/tree-sitter-swift-version-issue/node_modules/tree-sitter/index.js:259:15)
    at Object.<anonymous> (/workspace/GitHub/tree-sitter-swift-version-issue/index.js:5:8)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47

Ugh, yes, this would have started happening when https://github.com/tree-sitter/tree-sitter/pull/1852 was released since the tree-sitter folks haven’t released a new version of the node bindings. I was hoping that by not bumping my dependency (and leaving my lockfile as-is) I could have been avoiding it so far, but that was just wishful thinking.
There really really needs to be a new version of node-tree-sitter published, but I’ve had a hard time getting their attention (as have others: https://github.com/tree-sitter/node-tree-sitter/issues/111). Can you file this in https://github.com/tree-sitter/tree-sitter too? In the meantime, I can put out a patch version that matches exactly 0.20.6 instead of using a  ^, which I think will help.

Happy to file it there, but looks like the issue is already opened.   I don't see a published version 0.20.6
How about publishing a wasm module of tree-sitter-swift, would likely solve for both browser/node.  I have no idea how much an ask that is, but it may be easier long term if tree-sitter aren't going to keep up with the node releases.

fwiw -- the tree-sitter js/wasm seems to boot ok node v14.

How about publishing a wasm module of tree-sitter-swift, would likely solve for both browser/node.

I would accept a pull request to do that, but I’m afraid I have no experience with wasm myself.


Multiple Picks not working

This query only returns the Game models. The Player model data isn't returned at all:
const retVal = await Game.query()
.where('is_completed', false)
.orderBy('id')
.eager('players')
.pick(Game, ['id'])
.pick(Player, ['username', 'user_id']);
This query returns all fields from the Game model, and the only the Picked (username, user_id) fields from the Player model:
const retVal = await Game.query()
.where('is_completed', false)
.orderBy('id')
.eager('players')
.pick(Player, ['username', 'user_id']);

I know the documentation says different, but try this:
const retVal = await Game.query()
  .where('is_completed', false)
  .orderBy('id')
  .eager('players')
  .modifyEager('players', builder => {
    builder.pick(Player, ['username', 'user_id']);
  })
  .pick(Game, ['id'])

My models are pretty straightforward. Oh, I singularized the relationship "players" to "player".
const Model = require('objection').Model;
const Player = require('./Player');
class Game extends Model {
static get tableName() {
return 'game';
}
static get relationMappings() {
    return {
        player: {
            relation: Model.HasManyRelation,
            modelClass: __dirname + '/Player',
            join: {
                from: 'game.id',
                to: 'player.game_id'
            }
        }
    }
}

}
module.exports = Game;
'use strict';
const Model = require('objection').Model;
class Player extends Model {
static get tableName() {
return 'player';
}
static get relationMappings() {
    return {
        user: {
            relation: Model.BelongsToOneRelation,
            modelClass: __dirname + '/User',
            join: {
                from: 'player.user_id',
                to: 'user.id'
            }
        },
        game: {
            relation: Model.BelongsToOneRelation,
            modelClass: __dirname + '/Game',
            join: {
                from: 'player.game_id',
                to: 'game.id'
            }
        }
    }
}

}
module.exports = Player;

You need to also pickup The relation property players

How do I pick the relation property players? Isn't that what this does:
.eager('players')
.pick(Game, ['id'])
.pick(Player, ['username', 'user_id']);
I'm following the example from the documentation. But it isn't working.
Person
.query()
.eager('pets')
.pick(Person, ['id', 'firstName'])
.pick(Animal, ['id', 'name']);


Investigate duplicate movie action items

:tada: This issue has been resolved in version 1.10.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ios simple should compute the sum:

Hi , When I run
npm run ios-simple
There have a problem:
1) ios simple should compute the sum:      Error: [elementByIosUIAutomation(".elements().withName(\"Answer\");")] Error response status: 32, , InvalidSelector - Argument was an invalid selector (e.g. XPath/CSS). Selenium error: Locator Strategy '-ios uiautomation' is not supported for this session       at exports.newError (node_modules/wd/lib/utils.js:139:13)       at node_modules/wd/lib/callbacks.js:75:19       at node_modules/wd/lib/webdriver.js:174:5       at Request._callback (node_modules/wd/lib/http-utils.js:87:7)       at Request.self.callback (node_modules/request/request.js:368:22)       at Request.<anonymous> (node_modules/request/request.js:1219:14)       at IncomingMessage.<anonymous> (node_modules/request/request.js:1167:12)       at endReadableNT (_stream_readable.js:974:12)       at _combinedTickCallback (internal/process/next_tick.js:74:11)       at process._tickCallback (internal/process/next_tick.js:98:9)
What's This?

Are you using Appium 1.6.0 with iOS 10? These need to be updated to handle the lack of UI Automation in that version.

Oh，yes，I using Appium 1.6.0 with iOS 10,thx!(PS: How long will it take to update the version？）


can someone help me with this error?

Describe your bug here.
im new to source, and i wanted to compile cause i have everything set, so i compiled and, i got 2 errors,
and i want someone to solve it and fix it for me.
Command Prompt/Terminal logs (if existing)
source/PlayState.hx:1508: characters 3-8 : Unknown identifier : video
source/PlayState.hx:1509: characters 3-8 : Unknown identifier : video

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
yes, i edited freeplaystate and some options-states and even added a new state i guess

Please show me the source code of PlayState.hx.

add this code on playstate.hx
var video;
but this is not stable solution.
need more infomations


Install fails using python 3.7

(base) C:>pip install robotframework-aristalibrary
Collecting robotframework-aristalibrary
Downloading https://files.pythonhosted.org/packages/87/55/c7ca6d201561f567e9aaaff60a74722e02bb018c0cb9efa467c47e427348/robotframework-aristalibrary-1.3.0.tar.gz (70kB)
|████████████████████████████████| 71kB 353kB/s
ERROR: Complete output from command python setup.py egg_info:
ERROR: Traceback (most recent call last):
File "", line 1, in
File "C:\Users\p2901112\AppData\Local\Temp\pip-install-fgc60kbd\robotframework-aristalibrary\setup.py", line 41, in
execfile(join(CURDIR, 'AristaLibrary', 'version.py'))
NameError: name 'execfile' is not defined
----------------------------------------
ERROR: Command "python setup.py egg_info" failed with error code 1 in C:\Users\p2901112\AppData\Local\Temp\pip-install-fgc60kbd\robotframework-aristalibrary\

I second this. Python2 is about to not be supported anymore. All users would appreciate if this works with python3

Hi,
I just run Python utility 2to3 and fixed one error so library started working for Python 3.10.
Would anyone be interested in that?

I would be very interested in this library to work in Python 3.

I would be very interested in this library to work in Python 3.

Please check https://github.com/CloudAloud/robotframework-aristalibrary3
It was a while I used it last time and I can't test it so if it doesn't work please try running 2to3 on Python2 code. I also remember I had to fix one issue but I don't remember what exactly.

Please check https://github.com/CloudAloud/robotframework-aristalibrary3
It was a while I used it last time and I can't test it so if it doesn't work please try running 2to3 on Python2 code. I also remember I had to fix one issue but I don't remember what exactly.

Thank you for getting back to me on this.  Between the time I noticed this current repo and you posting your statement about the new repo updated for Python3. I forked this repo, made the changes to work in Python3 and fixed some other bugs in the process and got the library working.  I was not trying to take over your effort, but needed this for work at that particular time.
When I have some time I will checkout the new repo and see how it works out.

@tetheredge I am glad to hear you made it work on python3. Feel free to make a PR to new repo so others can use this 6 yo library again :)


swarm init fails on ipv6 only host

Just installed docker on my host with only IPv6 address.
Output from "docker version":
root@bn831x1-ossv-3a-lab:~# docker version
Client:
 Version:      1.12.0-rc2
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   906eacd-unsupported
 Built:        Fri Jun 17 21:21:56 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0-rc2
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   906eacd-unsupported
 Built:        Fri Jun 17 21:21:56 2016
 OS/Arch:      linux/amd64

output from "docker info"
Containers: 1
 Running: 0
 Paused: 0
 Stopped: 1
Images: 1
Server Version: 1.12.0-rc2
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 33
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: host overlay bridge null
Swarm: inactive
Runtimes: default
Default Runtime: default
Security Options: apparmor seccomp
Kernel Version: 4.4.0-21-generic
Operating System: Ubuntu 16.04 LTS
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 15.67 GiB
Name: bn831x1-ossv-3a-lab
ID: B272:E7BR:NRDW:NJ5R:TTAX:U27E:NML7:AT7G:AV4Z:OZG3:RTXH:MQGL
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Insecure Registries:
 <IP_ADDRESS>/8

Dockerd is started with --ipv6,
/usr/bin/dockerd -H fd:// --ipv6

run "docker swarm init" and receive error, trying to connect to IPv4 DNS.

~# docker swarm init
Error response from daemon: could not determine local IP address: dial udp <IP_ADDRESS>:53: connect: network is unreachable

Hi @calvincheng8
This bug should be reporting to the Docker Engine project http://github.com/docker/docker.

Hi @chanwit ,
I do not see why this is a Docker Engine issue. I only get this error when using swarm.

@calvincheng8 what you see is the Swarm mode of Docker Engine, not the feature of Docker Swarm v1 which is maintained here.

@chanwit
OK, thanks.
Just opened issue #23995 on http://github.com/docker/docker. Closing this issue now.

:+1:


Cusomize indicator padding

how about give property "indicatorPadding" to customize indicator padding?

#10

I published.


Support optional 'out' parameters for procedures

Rationale for changing the status quo
I don't like passing by reference, but Elan's restriction on not being able to either:

Call system methods in a function nor
Return a value from a procedure

makes it difficult to extract re-usable code that necessarily involves I/O. Currently, our position is that you may effectively  implement 'passing by ref' (into a procedure) by wrapping the value in an array and then extracting it afterwards, but this is fiddly.
So why not do this transparently in compilation?  We did previously have all procedure parameters working this way, but then realised it made it impossible to pass in a literal value.
New pattern
Any parameter definition (on a procedure) may be preceded by the keyword out. If it is, then:

Within the procedure body you may re-assign that out parameter to a new value/reference, and the compiled code will re-assign the original variable after exiting the procedure.
Within the procedure body you may call a mutating method on an out parameter, otherwise that would be a compile error. (This is a new rule, it is not prevented at present).
You may not pass in a literal argument to that parameter - nor a reference defined by a let - the argument must be a true variable. It must also be a simple identifier - no indexes, no qualifier, no dotted calls (this should be enforced by the parser).

Rationale
The arguments for (now) requiring out even for, say, an in-place sort on an ArrayList are:

intentionality - it makes it clear that the variable passed in may change.
There is no need to explain the difference between 'passing a (mutable) reference type', and passing by reference. To mutate or re-assign a parameter, it must be marked 'out'.

Caveat
We cannot prevent:
procedure foo(a as Bar)
  var b set to a
  call b.mutateMethod()
end foo

Where the change could impact external references to a. However, procedures, unlike functions, are not generally 'safe'.
Longer term, if we really think this is an issue, then we should enforce that all parameters not marked 'out' are cloned from the arguments.

This code works as it should:

However, it also works if you remove the out - which it shouldn't, per rule in spec above.


are there any options to mount a special device?

one single device adb connected by wifi works fine to mount with adbfs. if there are more than one devices  when typing       adb devices      how to choose the correct one
the adb command itself knows an option     -s IP-Number     to choose
please    what ist the way with adbfs?
thx gina
System:
Kernel: 5.4.0-74-generic x86_64 bits: 64 compiler: gcc v: 9.3.0
Desktop: Cinnamon 4.8.6 Distro: Linux Mint 20.1 Ulyssa

Hi this repo is no longer maintained but you can try using the enviroment variable (not sure if this will work or not)
export ANDROID_SERIAL=<device ip>


research versioning strategies with monorepo

https://softwareengineering.stackexchange.com/questions/378257/what-is-a-predictable-versioning-strategy-for-a-monorepo-using-semver

we need to consider how the versioning of packages should work with two monorepos: captcha and captcha-private. At them moment, everything gets versioned in lockstep for simplicity and publishing purposes. However, publishing needs to be changed to a per branch basis, so changing the versioning while we're at it makes sense

https://amarchenko.dev/blog/2023-09-26-versioning/


Fix bug for removal-of-scheduler-interval causing the scheduler to crash.

Fix #2520
Removing a scheduler interval when a interval action still using it would crash the scheduler

Steps for functional DEV testing:

Purge the local instance of Redis:
<IP_ADDRESS>:6379> FLUSHALL
OK
START EdgeX core services (including core-scheduler) locally.
GET the ID of the midnight interval, for example the ID 7901fc46-ba80-4293-85dd-c81a9dd728d1:

level=INFO ts=2020-05-11T21:16:06.844548Z app=edgex-support-scheduler source=loader.go:172 name=midnight id=id msg="added interval to the support-scheduler database"
level=INFO ts=2020-05-11T21:16:06.84472Z app=edgex-support-scheduler source=schedule.go:162 msg="added the interval with id : 7901fc46-ba80-4293-85dd-c81a9dd728d1 into the scheduler queue"

DELETE the midnight interval by ID using core-scheduler's API:
curl --location --request DELETE 'http://localhost:48085/api/v1/interval/7901fc46-ba80-4293-85dd-c81a9dd728d1'
--data-raw ''
RESTART EdgeX, which starts up without issue.
Thus, EdgeX now prevents the user from deleting the midnight interval not only by NAME doing (with an error of "interval still in use by intervalAction(s) name: midnight"), but also by ID, as noted in the screenshot above of REST client.

Rebased.

I think there is another bug somewhere in these changes. I performed the following steps and get an unexpected result:

Started support-scheduler with clean database
Performed a GET /interval  to get the the ID of the midnight interval
Performed a GET /interval/{ID} to ensure the midnight ID was correct
Executed a DELETE interval/{ID} for the midnight interval
Executed another DELETE interval/{ID} for the midnight interval

The first time I executed the delete I got the expected response that the Interval is in use. However, the second request resulted in a response of scheduler could not find a interval context with interval id : c1b4a2b5-aa93-4674-8af4-8b881e6008be which is the ID of the midnight Interval which I was attempting to delete. I also can execute the GET /interval/{ID} (step 3) and get back the expected Interval, so there seems to be some disconnect where the Interval still exists but the DELETE operation is not able to retrieve it for deletion. I think we need to look into what we are assuming is the source of truth for holding Interval and IntervalActions

I am able to recreate your observation above (for deleting interval by ID, as well as for deleting interval by Name).
So this may not be a bug introduced by the updates in this PR.
But you bring up a good point: There seems to be a disconnect between what we are assuming is the source of truth for holding Interval and IntervalActions.

@akramtexas , You are correct. The bug I mentioned in my last comment is not a regression and is present in the code base separate from this issue.
As we discussed in a separate meeting, we are going to ignore that "bug comment" I made previously and only address the code cleanup comments. The "bug comment" will be handled in another issue #2554.

Codecov Report

Merging #2552 into master will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2552      +/-   ##
==========================================
+ Coverage   38.89%   39.25%   +0.35%
==========================================
  Files         145      145
  Lines       12728    12819      +91
==========================================
+ Hits         4951     5032      +81
- Misses       7504     7510       +6
- Partials      273      277       +4

Impacted Files
Coverage Δ

...nal/support/scheduler/operators/interval/delete.go
93.26% <0.00%> (-6.74%)
:arrow_down:

internal/support/scheduler/router.go
0.00% <0.00%> (ø)

internal/support/scheduler/rest_interval.go
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 756fbc2...a05e74a. Read the comment docs.

The work undertaken in this PR will be completed (remaining unit failures fixed), but not for the Geneva release. As such, converted it to a Draft PR for now ✅

The work undertaken in this PR will be completed (remaining unit failures fixed), but not for the Geneva release. As such, converted it to a Draft PR for now ✅

The remaining unit failures have now been fixed, and this PR is ready for review.
Referring to the note above, and with the work undertaken being completed (i.e. remaining unit failures fixed), this PR will not be merged into the Geneva release.
As such, it currently remains a Draft PR.

Referring to the steps outlined at the top (to be carried out for functional DEV testing), those were of course carried out again.
In addition to that, and referring to #2554, I tested that consecutive attempts at deleting a scheduler interval in use (both by Id and by Name) is handled properly in that such attempts are disallowed, with the response being, for example: interval name: midnight in use ✅

Rebased.

Overall looks good. I did not manually verify these changes as this is still a draft PR. I will do a final once over once we are ready to merge in hopes of not wasting time.

@lranjbar and @jpwhitemn - Referring to the following update (in EdgeX Slack channel), I'm reaching out to you for help in ensuring that we're good with the the Geneva 1.2 tag aspects (in this PR's feature branch), since I had branched before that tagging was done:
Jim White  2:47 PM
@here - EdgeX developers, just had a Slack exchange with Lisa and the master branch of repositories is open for Hanoi development - with exception of Modbus and MQTT device services which are still having some issues addressed.  For safety sake, please make sure the repository you do work in has a 1.2 tag for Geneva in place and if it does not, please let @Lisa Ranjbar (Intel) or @jpwhite know.  Otherwise, happy coding!
Referring to the note above by @AnthonyMBonafide, I have taken this PR out of Draft state, but will hold off from requesting Anthony from doing a final once over once we are ready to merge.

Codecov Report

Merging #2552 into master will decrease coverage by 0.03%.
The diff coverage is 82.45%.

@@            Coverage Diff             @@
##           master    #2552      +/-   ##
==========================================
- Coverage   38.89%   38.86%   -0.04%
==========================================
  Files         145      145
  Lines       12728    12717      -11
==========================================
- Hits         4951     4942       -9
+ Misses       7504     7501       -3
- Partials      273      274       +1

Impacted Files
Coverage Δ

internal/support/scheduler/router.go
0.00% <0.00%> (ø)

internal/support/scheduler/rest_interval.go
96.40% <78.57%> (-3.60%)
:arrow_down:

...nal/support/scheduler/operators/interval/delete.go
96.00% <92.59%> (-4.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91925a...634de8b. Read the comment docs.

Rebased.

Rebased.

I am going to merge these changes so this branch does not become stale. @akramtexas, lets make sure we add the proper tags to this PR and the associated issue.

All, this fix should go into a dot release of Geneva that also incorporates some rules engine changes and UI fixes.  Tagging @lranjbar @lenny-intel for awareness on this item to include in our dot release.


A new config option called isAppended

adding new config option called isAppended.
This new option allows the user to decide if he wants new items to appended (the default) or prepended.
Setting the following will cause packery to use prepended: isAppended="false"

Great.
If you can just also build it and add it to the dist folder, it'd be great.


Utilize i.n.u.internal.ObjectUtil to assert Preconditions

Expected behavior
NullChecks resulting in a NullPointerException or IllegalArgumentException, numeric ranges (>0, >=0) checks, not empty strings/arrays checks must never be anonymous but with the parameter or variable name which is checked. They must be specific and should not be done with an "OR-Logic" (if a == null || b == null) throw new NullPointerEx.
Actual behavior
Some checks are already done with the io.netty.util.internal.ObjectUtil code. Some are done manually.
Steps to reproduce
checkout the master
grep -r "Objects.req"
grep -r "throw new NullPointerException"
grep -r "throw new IllegalArgumentException" (individual check necessary)
Minimal yet complete reproducer code (or URL to code)
Existing codebase.
Netty version
5.0.0.Final-SNAPSHOT
JVM version (e.g. java -version)
Not relevant, all
OS version (e.g. uname -a)
Not relevant, all
Providing the fix
One pull request per sub-project to enable reviewers to focus on a relevant subset. First one is common itself, including a new unit test for ObjectUtil itself.

@boris-unckel I am happy to review a PR 👍


Docs are confusing when using lambda without express

Hello, I am having a hard time figuring out xray for my lambda module, I do not create any subsegments and am using only the captureHTTPsGlobal to get request information and tracing, currently struggle buss'n through adding annotations and enabling xray for local development and testing.
Another issue i'm seeing is in xray I do not see any urls or methods displayed on the UI view but they do appear in the metadata.
Do I need to create a subsegment? If so do I need to close each subsegment? Are there any best practices for using the captureHTTPsGlobal or gotchas?
Another query or point of confusion I have is that I already have a separate unique v4uuid for my codebase that I use for logging and saving my data. I was hoping to be able to tie that in with xray and be able to view all parts of my system by the same v4uuid I already generate. Whats the best way to include this (annotation?). I was hoping it'd be as simple as giving the segment or subsegments that id when I create them (or by having the same parent id). Is there a common/global way to use my uuid or do I have to add it to every subsegment? How can I add it to the global http capture?
The docs state: "Currently, only Express applications are supported for automatic capturing. See the aws-xray-sdk-express package for additional information." - https://github.com/aws/aws-xray-sdk-node/tree/master/packages/core. Is that accurate anymore?
It would be great to have some generic examples for lambdas without express. A lot of the docs seem to only reference express but there is a separate express module and readme. It'd be great if all the express examples were moved there. The docs also seem to be missing information on lambdas in general and how they initialize a root segment by default and they should only be used with Automatic mode.
Should there be an lambda package? With examples and docs? or should it be in core? (I'd love to give this a start but I'll need to request permission from my company first, does this resonate at all or am I completely offbase here?)
Thank you in advance!

Hi @kbradl16,
Please see these docs for a quick run through of using the X-Ray SDK for Node in a Lambda function and these docs about captureHTTPsGlobal. We currently have a backlog item to add a more detailed sample Lambda app to that first link that includes captureHTTPsGlobal among other things.
To add some additional context, captureHTTPsGlobal will automatically generate a subsegment for all requests that you make with the captured protocol (http, https, or both). This also works for requests made via 3rd party libraries since they ultimately use one of those libraries under the hood.
You are right that the documentation for the repo is misplaced right now. We currently do support Lambda, and only the core package is needed to instrument a Lambda function. This repo was created before X-Ray's integration with Lambda was released, and the docs don't reflect that well. I'll make a note to update them on GitHub when we also update them on https://docs.aws.amazon.com.
An annotation would be the best way to associate such an ID with (sub)segments. Unfortunately in Lambda, a segment is automatically generated for you, but it is implemented as an immutable facade segment. It is immutable because the true segment representing Lambda requests is made by the Lambda service and not available to application code. Only subsegments can be modified, e.g. with addAnnotation.
There's no way to currently to perform some action for all segments/subsegments, though we've added that functionality to the Java SDK and are working on bringing it to the other SDKs. In the meantime, you'll have to retrieve the subsegment manually, e.g. with:
const subs = AWSXRay.getSegment().subsegments;

if (subs && subs.length > 0) {
  let sub = subs[subs.length-1];
  sub.addAnnotation('myKey', 'myVal');
}

I can work on getting a sample lambda app example together and moving the docs around if you can give some general guidance on where it should live?!

If you'd like to make a sample Lambda app, that'd be great! We want to expand upon the sample app on this page to include:

An HTTP request (e.g. to https://amazon.com) captured using captureHTTPsGlobal
An AWS SDK request (e.g. s3.listBuckets()) captured using captureAWS (this is currently the only thing included in the sample app)
A SQL query (using mysql or postgres) captured using their respective
A function (async or regular depending on your handler) captured using captureFunc or captureAsyncFunc. The captured function can perform one or more of the above tasks if you'd like.
A screenshot of the resulting trace map similar to the one on the page right now.

As for the repo's documentation, it'll be a little more involved refactoring so I'll stick to that one.

Hi @kbradl16,
#279 added documentation regarding usage in Lambda, and more directly pointed to the official AWS Documentation. Do you still plan on contributing a sample app? If so, it could be open sourced as a contribution to our new sample app repository. Currently it only has an express sample app, but I'd be open to adding your Lambda sample app in a separate directory if you made a PR in that repo.

Hi, @willarmiros I do still plan on contributing a sample app unless someone gets to it before me (I’ve just had a newborn born this month so I’m not actively doing any development at the moment) I’ll add it to the sample repo

Incredible, and congratulations! No worries, I'll leave you to it :)


color filter - green fixed for hack minigame

green by default is very dark in hack minigame. it outputs a different value that wasnt in the switch code
this pull adds it to the code fixing it

Thanks for your contribution!


Added a Mastodon Search extension

Description
This is a new extension that allows quick access people and hashtag search. It is not intended to be a full Mastodon client, just a quick and easy way to get glanceable information such as follower count and bot status and to navigate to pages on the Mastodon website. It intentionally does not include posting, browsing timelines, mentions, or even searching user posts.
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@BasixKOR has been working on #5001 for some time and it seems like it’s almost ready.
Now we also have #6117 and #6156 in the queue, we need to decide what to do with all three, are you up for selecting the best version and going with that and improving with the feature respectably from the other PRs?

Thanks for taking a look, @pernielsentikaer
We did search for Mastodon extensions before developing this but only found #5001 just before submitting this PR. We never thought to search the pull requests!
We just checked out @BasixKOR's client in #5001 and while the search functionality is similar, I think there's a case to make for a pure search extension that does not require an access token. In order to test out the other extension we had to go into Mastodon, make a new API app and get an access token. That's obviously necessary for a fully featured client which requires account access, but seems like overkill for someone who just wants search (like we do!)
There are also other features like our indication of bot accounts and follower count, but as you say we could spend time integrating those (if @BasixKOR agrees that they are the right way to go)
However, I think, instead, if you don't think this is valid as an extension please feel free to close it and we'll use our local copy of it rather than having it on the store.

The ability to search Mastodon without any credentials could be useful, and I don't think this extension clashes with the existing (or more appropriately, pending) Mastodon extension.

I'd still like to merge it. I've been using it regularly over the last few weeks and it's working well.

We just need to make sure it's clearly documented so the end user knows what it is

The title is currently "Mastodon Search - Search for People or Hashtags on Mastodon." which feels clear to me, but I'm happy to make refinements or changes if there's feedback on the title (or other fields that could make it clearer).
Thanks both @pernielsentikaer and @BasixKOR for your feedback 👍

So you think we should just have one extension for Mastodon, or?

So you think we should just have one extension for Mastodon, or?

No, sorry, I was talking about the title for this extension being clear. I think there is an argument for having a search-focused extension, which is this one.
I'm happy to make refinements to the metadata if you think the purpose of this extension could be clearer, but I was saying that it feels quite clear to me being "Mastodon Search - Search for People or Hashtags on Mastodon."

Thank you!


Typo in Usage example

I believe the variable String integratorKey = "[INTEGRATOR_KEY]"; should start with a capital I for the code to compile.

It was fixed. Thanks for reporting!


Default value is schema

Check this is valid and consider alternative... like no defaults here but in UI instead

Implemented


Hash and Order may make Eq ambiguous

They both extend Eq. Making a single Order with Hash fixes this issue I think.
Sorry for no test/PR but I’m on the phone.

Good call, will get this asap.


ci: tweak release please main merge

Git was unable to fast-forward release onto main. This uses a merge commit when going back into main instead. Theory is that this will be okay because production wouldn't diverge as it would end up in it's history later (on the next release).

Current dependencies on/for this PR:

main

PR #2608   👈

This comment was auto-generated by Graphite.


IO.getEnv returns invalid UTF-8 on windows

Minimized from this Zulip thread. It appears that std::getenv on windows returns data in the current code page, so putting it directly into a lean String is not legal (because it assumes UTF-8 encoding). Other languages have faced the same issue:

Nim: nim-lang/Nim#20083
Rust: implementation

Both of these languages take the approach of using the widestring version of the function (which is reliably UTF-16 (with potentially unpaired surrogates)) and manually converting it to UTF-8 (or WTF-8). This is a bit sad, I thought the A  version of the function was supposed to be UTF-8. (Maybe it is, I can't test it.)

Is this https://github.com/leanprover/lean4/issues/2554?

Unclear. (The issue description is a bit vague.) But I don't think so; from what I can tell #2546 is about a build system issue, not runtime usage of getEnv and related functions.

No, it is not a build system issue. We set the code page of lean to UTF-8 but not yet for other Lean executables, so seems very relevant here


Turn Off USB Storage

Cannot use external USB disks after applying "Full Protection". I doubt the option "Turn Off USB Storage" is necessary for home users. Removing from "Full Protection" might be considered.

The application definitely must have a "restore" option.

If you want to withdraw the "Turn Off USB Storage" setting, you can do so by entering the following value in regedit:
[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\USBSTOR]
"Start"=dword:00000003

Thank you very much for your feedback. I will make the correction you mentioned and share it as soon as possible.

Thank you.

Removed the option to turn off USB storage from the Full privacy tab. You can check.

Thank you for your quick response.


#344 fixing issue with delete keyword

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description
Fixing issue #344

Thanks!!
Can we also have a testcase/example that showcases how this would fail before? Just to avoid regressions

I can't create testcase for this unfortunately, because NodeJS and Chrome does not trigger issue when you're trying to delete undefined property/key from object/array, but PhantomJS does trigger it.
Based on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode

strict mode makes attempts to delete undeletable properties throw (where before the attempt would simply have no effect):

On one hand when you'll try to delete undefined property/key it's okay, on other hand, you can't delete something that does not exists.
I was trying to execute Mocha using Karma Runner, but it was failing because of 'use strict' and access to argument.callee from chai framework.
I'll try to prepare standalone page with this case.

@kvz I've prepare "playground" repo: https://github.com/oleg-andreyev/playground/tree/locutus-344
# run current version of array_multisort
npm run run-origin

# run patched version of array_multisort
npm run run-patch

Thanks!


Tests for cargo-shuttle

This is based on top of https://github.com/getsynth/shuttle/pull/122. It is also pretty opinionated. Probably a bit too opinionated for a first contribution, so it might be worth getting that PR merged first, and then deciding which bits of this PR you want to keep, and which to re-work.
I originally developed it as https://github.com/alsuren/shuttle/pull/1, but I don't have any self-hosted runners available over there, so I have opened up a draft pr over here.

It might be cool as well to have a something like the functionality in git - where in any given directory it will go to it's parent to check if that is a git directory recursively until it reaches / such that you can do git status from any sub-directory of the root git directory which contains the .git folder.
In our case we don't really have a .shuttle marker or something like that - except for the optional Shuttle.toml.

I have a feeling that cargo metadata will already do that for you. I can't remember whether it finds the workspace root or stops at the first Cargo.toml it finds. I will try writing a test over the weekend or something.

I wrote the above test. It kind-of passes and kind-of fails: cargo-metadata correctly finds the crate root, but then we don't use that information to find the Shuttle.toml. I left it in there as fixme_running_in_src_subdir_finds_crate_but_fails_to_find_config() so you can see what I mean.
things that are ugly:

[ ] there are probably a bunch of unix-isms floating about, that will break on windows. I will wait for a set windows CI build errors before thinking about how to solve these things.
[ ] something odd is going with the dead_code lint in clippy --tests for cargo-shuttle.
[ ] I have gone all-in on the integration-tests-only approach for cargo-shuttle, following matklad's blog post. A few of them are things that I would normally write as unit tests. I can turn them into unit tests if you prefer.
[ ] the bin-only -> bin+lib split is potentially controversial, and may also cause merge conflicts with other work that's going on at the same time. I can keep cargo-shuttle as a bin-only crate, and convert the config tests into "unit" tests, if you prefer.
[ ] fixme_running_in_src_subdir_finds_crate_but_fails_to_find_config() is kind-of a failing test. I suspect that the fix won't be too bad, but this PR series is bigger than I would like already (given that this is still my first code contribution to the project), so I would prefer to fix it later.
[ ] we should probably work out a subset of the cargo-test workflow that can be run on the github OSS free-tier windows/mac/linux runners.

I have rolled the changes into https://github.com/getsynth/shuttle/pull/122 (using unit tests rather than integration tests with a main+lib split). I will work on the cache + github runner stuff in my own time, on https://github.com/alsuren/shuttle/pull/2


Portfolio: Preserve data

Portfolio: Preserve data 😎
In this activity my partner @pmaxy  and I added the next features:

Create a Javascript object 🔢
Add the feature to preserve the form data 💾

Changes Done

Preserve data in the input fields


Exclusive pooling

This PR is in relation to this:
#355
Enabling validation that a VF is only used in one resource pool.
signed off<EMAIL_ADDRESS>

LGTM 👍

@adrianchiris @zshi-redhat
Could you review again please? :)


Risky cryptographic hashing function

Hi Angular team,
We have Coverity SCA tool integrated with our angular application.Below are the issues reported by tool for node modules files and categorized as "Risky cryptographic hashing function". Is the below issue still open from your end or fixes are already given in some of your angular releases? Please suggest. Used Angular version 4.x
1)Filename :-->  /node_modules/webpack/lib/ModuleFilenameHelpers.js
function name :-> getHash
2)Filename :--> /node_modules/webpack/lib/NormalModule.js
function name :-> NormalModule.prototype.source
3) Filename :-->/node_modules/typescript/lib/typescript.js
function name :->nodeSystem.createHash
4)Filename :-->/node_modules/ts-node/dist/index.js
5)Filename :-->/node_modules/ts-node/dist/index.js
6)Filename :-->/node_modules/istanbul-api/node_modules/istanbul-lib-instrument/dist/constants.js

Hi there,
Angular version 4 is an older version that we don't directly support anymore, but we still use some of the dependencies you mention. A better place to report any problems with those dependencies is their repository though.


After scaling, old tasks are shown as "Out-of-date"

When scaling an app, a new app version is created during deployment. We do not restart old tasks during scaling. Hence, the old tasks have the old app version.
The UI form today's master branch shows those old tasks as "Out-of-date".
We either have to update the version of those old tasks or avoid creating a new version.

This is expected behaviour as with the new scale, the app configuration has changed.

It's not what a user expects IMO.

"out of date" sound like something is wrong.

I agree with @sttts

I agree. If there's a deployment that changes anything other than the number of instances, it will replace all the tasks anyway, so there will never be an out-of-date version running.

Deployments which only scales, should NOT restart all the tasks. This is a lot of unnecessary load on the cluster, imagine cold caches and so on. Image you have 900 tasks running and scale to 1000. Restarting 900 for 10% more capacity is not very clever.

;-)

Would it make sense to compare the current version with the previous version up to the instances value in the UI?

No. As I said, there will never be two different versions running that differ in anything but the number of instances.

Right. But I was wondering how to get rid of the ugly yellow "Out-of-date" message in the UI. This can be done on the server during the deployment (by updating the old tasks' AppDefinition) or in the UI by a comparison.

So how do we go about this? We could rename it from "Out-of-date"? The problem we tried to solve was that the version numbers wasn't easy to parse, to see which tasks are running the current version and which are not.

@sttts and @bobrik: Would you be on board with adding moment.js (using the relative time function: http://momentjs.com/docs/#/customization/relative-time/) to say e.g. "Just now", "An hour ago" and "Three days ago" (all in white), to make it easy to parse and still communicate when each task was updated?

From a user's point of view relative dates would be great. In addition I would update the version in the backend when the scale step is finished. Then you have the new version for every task when the deployment is done.

I'm ok with relative time if you could get absolute values in tooltip or with click (like in mesos ui).
+1 for @sttts on updating version or keeping old version for scaled tasks. Not sure what is the best option, though.

I updated the comment to reflect the frontend changes, @drexin will you add the backend changes?


Added startup option --javascript.tasks to allow turning off JavaScript tasks

Scope & Purpose
Added startup option --javascript.tasks to allow turning off JavaScript tasks.
The default value for this option is true, meaning JavaScript tasks are available as before.
However, with this option they can be turned off by admins to limit the amount of JavaScript user code that is executed.

[ ] :hankey: Bugfix (requires CHANGELOG entry)
[x] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification
[x] :book: CHANGELOG entry made

Backports:

[x] No backports required

Testing & Verification

[x] The behavior in this PR was manually tested
[x] This PR adds tests that were used to verify all changes:

[x] Added new integration tests (e.g. in server_parameters)

Link to Jenkins PR run:
http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13719/

Tests blue

Tests blue

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13731/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13731/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13733/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13733/


Include: vSphere permissions

Thanks for creating PR!
First, BIG thank you for clarifying minimal permissions to use vbmc4vsphere. The changes for README.md is super helpful for users.

What is the saying... "less is more". I believe this is sufficient for most users.

Tested and works well. Thanks!
F.Y.I. in addition the permission Global.DIagnostics is also required to use power diag command. I'll add this permission to README.md after merging this.
Thanks for contributing again!


chore: Update Karpenter for v0.32.9

Fixes #N/A
Description

Bump Karpenter

How was this change tested?

N/A

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.486%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6259

Relevant Lines:
7588

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.486%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6259

Relevant Lines:
7588

💛  - Coveralls


chore: update 3rd party dependencies

Codecov Report

Merging #910 (51336b3) into main (d8acca0) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
- Coverage   96.35%   96.25%   -0.11%
==========================================
  Files          30       30
  Lines         439      427      -12
  Branches       77       77
==========================================
- Hits          423      411      -12
  Misses         16       16

Impacted Files
Coverage Δ

src/components/Form/Form.tsx
80.76% <0.00%> (-0.72%)
:arrow_down:

src/pages/index.tsx
90.00% <0.00%> (-0.10%)
:arrow_down:

src/stores/ThemeStore.tsx
100.00% <0.00%> (ø)

src/stores/LanguageStore.tsx
100.00% <0.00%> (ø)

src/utils/html-head-utils.tsx
100.00% <0.00%> (ø)

src/components/Button/Button.tsx
100.00% <0.00%> (ø)

src/components/Footer/Footer.tsx
100.00% <0.00%> (ø)

src/components/Buttons/Buttons.tsx
100.00% <0.00%> (ø)

src/pages/social-media-preview/index.tsx
100.00% <0.00%> (ø)

src/components/ThemePicker/ThemePicker.tsx
100.00% <0.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8acca0...51336b3. Read the comment docs.


Moderation Feature: Force Update Mute Role Permissions

The title says it all.
It would be nice to have a command that forcibly updates and applies the latest role permissions to the mute role. This would allow permissions to get fixed for existing channels if they are tampered with or messed up by staff.
It also provides an easy way for server managers to update ClemBot mute permissions when ClemBot adds support for new permissions or fixes mute-breaking features.

I see the utility in this, however its also something that can just be run from the owner eval command


Thank you

I just wanted to say thank you for implementing the pandora api in golang. I tried reading the source code for @HermesApp but all the OSx isms made my brain fog over.

My distinct pleasure!


Feature: Documentation Site

Converted documentation from GitHub wiki to mkdocs.
Added example for connecting to various LLM services/applications
Updated to allow manual trigger of the mkdocs action to allow for easier testing

<3 love it! Let's go excited to expand on this!


The type  initializer for 'SixLabors.ImageSharp.Configuration' threw an exception. on Windows PowerShell 5.1

This module seems to work fine in Windows PowerShell 5.1 but only in VSCode. It fails to run outside of it for an unknown reason (probably missing LIB).

Fixed with:

https://github.com/EvotecIT/ImagePlayground/pull/3


feat: activate and deactivate extension

Resolves #31 (Issue number this PR resolves)
What does this PR do?

Users will be able to activate and deactivate the extension from the block settings page.
Users will be unable to block a website when the extension is deactivated.

Screenshot

Nice work mam.


build: allow non-default clang binaries

this fixes release build with versioned clang from Debian

Can one of the admins verify this patch?

:+1:


itwinui-react Tooltip does not appear inside Dialog in Widget

Describe the bug
iTwinUi-React Tooltips do not work inside a Dialog in an appui context.
To Reproduce
Steps to reproduce the behavior:
(I tried these steps using the Electron "standalone" test app. I can provide the changes that I made if needed)

Create a widget that includes an iTwinUI-React Dialog.
Add a Tooltip to a component (I just used a div component) in the Dialog
Hover over the component
The tooltip does not appear

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the applicable information):

OS: Windows
Browser Tested in Chrome as well as Electron "Standalone" test app
Version [e.g. 22]
iTwin.js AppUI Version: Tested in test app as mentioned above
iTwin.js Version [e.g. 3.6.2]

Additional context
Note:

Tooltips do appear when you add them to a widget outside of a dialog (see screenshot)
Tooltips work inside of a Dialog when not in an appui context (see this example for the effect that I am trying to achieve)
If I pop out the frontstage, the Tooltip seems to appear in the dialog.

My widget src:
import * as React from "react";
import { Button, Dialog, Tooltip } from "@itwin/itwinui-react";
import { useState } from "react";

export const MyWidgetContent = () => {
  const [showDialog, setShowDialog] = useState(false);
  const openDialog = () => {
    setShowDialog(true);
  };

  return (
    <>
      <Dialog
        isOpen={showDialog}
        onClose={() => setShowDialog(false)}
        isDraggable
        isResizable
        closeOnEsc
        closeOnExternalClick
        preventDocumentScroll
        trapFocus
        setFocus
      >
        <Dialog.Main>
          <Dialog.TitleBar titleText={"Some Dialog"} />
          <Dialog.Content>
            {/* ********************** Non-working tooltip ********************** */}
            <Tooltip content={"This Tooltip *doesn't* appear"} placement="bottom">

Dialog Content

            </Tooltip>
          </Dialog.Content>
        </Dialog.Main>
      </Dialog>

        <Tooltip content="This Tooltip works" placement="bottom">
          <Button onClick={openDialog}>Dialog</Button>
        </Tooltip>

    </>
  );
};

@cfranklyn After looking a bit, the widgets uses 2 classes that prevent displaying the overflow, if you look at the html tree in the widget, you'll see nz-widget-widget have overflow: hidden and nz-widget-contentRenderer also have overflow:hidden;. Disabling those 2 will indeed make the tooltip appear, however, I dont suggest removing those for now. I'll see with the team what we can do so this would work.

Hi @cfranklyn, sorry for the delay on this. Using iTwinUI dialog directly within a widget will likely always be a problem due to the way we render the widgets. (IE, if you widget was floating, the Dialog would then be caught within the widget, the tooltip would work fine, but that is unlikely to be the desired outcome.
The best solution would be to use the Dialog or ModelessDialog classes from Core-React package so the Dialog z-index would be properly set above the widgets, and display them by using the UiFramework.dialogs entry point so they are not rendered within the widget body and restricted by various visibility issue.
(Note that rendering directly an iTwinUI dialog in UiFramework.dialogs.modeless.open will open the dialog, but it will not have the correct z-index and will display underneath the floating widgets.)
Since 4.3.0, the underlying component that Dialog uses is the iTwinUI dialog, so you should have a really similar visual result than with directly using iTwinUI dialogs.
Let me know if this fixes your issue, sorry again for the delay.

Hi @raplemie. I've been playing around with this and it seems to work well. I can see the tooltips in docked and un-docked mode. Thanks very much for looking into it.


Product Hunt Launch 7/27/2017

Planning on launching Blockchain.js on Product Hunt on Thursday!
@nblackburn thoughts? advice? tips?

@seanseany It really all boils down to understanding what you have created, what purpose it serves and why you created it.
Just be open and engage with the community and you will be fine.

@nblackburn Thank you!


Study the source code and development

I wanted to understand what clipper was doing and the detailed operational relationships between the services.I want to look at something like this. Thank you


[Feature] Spatial Indexing for Tooltip?

What problem does this feature solve?
For scatter series, when we render 50K+ data points, hovering over a dot to show tooltip becomes noticeably slow (somehow turning on large paints the dots outside of the grid for me, so I can't use it).
I wonder if it's because we're searching the nearest datapoint linearly with O(N) instead of O(logN) with spatial indexing?
D3FC uses d3-quadtree to index all the data points and that makes their tooltip really fast!
https://blog.scottlogic.com/2020/05/01/rendering-one-million-points-with-d3.html#spatial-search-of-large-datasets
Would love to know what the team thinks 😄
Thank you!
What does the proposed API look like?
chartInstance.set({
  series: [{
    type: "scatter",
    spatialIndex: "quadtree", // default to quadtree
    // ... other scatter series option
  }],
  // ... other options
})

Related to #16133?

#16133

Yes, it seems to be the same problem. BTW, if the clipping has bug with large mode, please help open an issue to report it.


Automate npm publishing

Noting for others: This action will publish to NPM when the version within package.json changes


Switch to VS 17 2022 for windows

Merge when you are ready to use VS 22

Codecov Report

Merging #119 (95eb5b5) into master (19838c2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   20.38%   20.38%
=======================================
  Files          88       88
  Lines        1388     1388
  Branches      508      508
=======================================
  Hits          283      283
  Misses        975      975
  Partials      130      130

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19838c2...95eb5b5. Read the comment docs.


crashed while i don't know how to fix it

I've just had the same problem.Can anyone solve this problem?


4826: GET Order

Would it be possible to add the AB# information to the description of the PR as well i.e. Story number & task number.


Default location and postcode

Hi, first I want to say thank you for the great project. It really helps. Just don't understand why kijiji not providing simple repost feature.
For the CFG file is it possible to have some default value such default location and postcode set? So we don't need to choose that from the dropdown list every time.
Again appreciate your good work. Keep going.

Preliminary work for this feature is on the feature/default-form-values branch.

Merged into master and released as v0.1.7 (4ba3243)


adding static-path

Initial PR for implementing AFER DM Caseload, adding static-path and hmppsRestClient.

Will add test in my next API Integration PR as it will be a complete end-to-end flow.


Upload screenshots to S3 and post comment on Github

The comment is posted on the commit itself, which should show up in PRs.
The one open question I have is how to deal with “auto merge” in Github.
It could make actual regressions go unnoticed. Any ideas?

Is your thought to disable auto-merge or just recommend that we don't use it?

Exciting PR! This is now officially the codebase with the most CI I've ever worked on

I see, so 👍 just means that things are good
On Tue, Mar 1, 2022 at 5:31 PM JP Posma @.***> wrote:

@.**** commented on this pull request.
In zaplib/scripts/ci/browser_tests.sh
https://github.com/Zaplib/zaplib/pull/107#discussion_r817276270:

mv screenshots/ screenshots_report/

mv previous_screenshots/ screenshots_report/
mv diff_screenshots/ screenshots_report/
+aws s3 cp --recursive screenshots_report/ s3://zaplib-screenshots/$GITHUB_SHA

+if grep --fixed-strings '"newItems":[]' screenshots_report/reg.json && grep --fixed-strings '"deletedItems":[]' screenshots_report/reg.json && grep --fixed-strings '"failedItems":[]' screenshots_report/reg.json
+then

echo "SCREENSHOT_GITHUB_MESSAGE=✅ No screenshot diffs found." >> $GITHUB_ENV

+else

echo "SCREENSHOT_GITHUB_MESSAGE=🤔 Screenshot diffs found. Please look at the screenshots and tag this comment with 👍 or 👎. Only merge when both the PR author and all the reviewers are happy with the changes." >> $GITHUB_ENV

^ to make it clearer that 👍 means that there is no diff
Oh but there can be a diff! 👍🏻 in that case means that the diff is
intentional / desired.
—
Reply to this email directly, view it on GitHub
https://github.com/Zaplib/zaplib/pull/107#discussion_r817276270, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AARO2K7EWLZTHXVRDFZDT6TU53AFTANCNFSM5PSTVYZA
.
You are receiving this because your review was requested.Message ID:
@.***>

Is your thought to disable auto-merge or just recommend that we don't use it?

Missed this earlier. It's a good question. I'll disable it for now, and if we feel like that is too annoying then we find a better solution.


Render documentation to web pages

As a user & developer I would like documentation to be rendered into a nice user-facing set of pages.
We can probably do this quite easily using github actions and github pages - look at the setups in the bluesky or ophyd-async repositories for inspiration if needed (those repositories already do precisely this)
We may need to restructure our docs to fit what the automated tools expect, but this ticket is not about writing new docs, just with publishing what we already have (and restructuring if necessary)
Acceptance criteria

[ ] Human-facing tutorials (the markdown files in doc/) are rendered into a nice navigable set of pages

Comparable to this

[ ] Architectural decisions as above (but fine for these to be in a "developer" section or something like that)

Comparable to this

[ ] Python-level docs (i.e. docstrings) and method signatures get used to generate docs pages

Comparable to this

Pages automatically updated on new commits to main

Consider doing this in reusable-workflows and then just calling it here, so that the same docs CI pattern can be reused by other repos easily.


Forbid repeated upgrade of the same room

As of this writing, the spec allows upgrading a room that already has a tombstone event. I don't think there was a provision to use the upgrade mechanism to fork rooms; so let's just disallow upgrading a room if it already has m.room.tombstone in its state.

based on some internal troubleshooting over the last couple weeks, I'm not entirely convinced that we should do this. Although it's not great that people can rewrite the upgrade chain, the benefit is that when someone screws up the upgrade and it needs to be fixed it is incredibly useful to overwrite their disaster.

How exactly is the update screwed up though? Is it a bug or just the user messing with things?
Additionally, we could support rewriting the chain by redacting the tombstone event.

I've seen both cases equally. There's not much difference in redacting a tombstone and overwriting it.

I'd prefer redacting, assuming clients would handle it properly.

Have we discussed whether sending any events after a tombstone is allowed?

It's normally prevented by the power level change, but not strictly enforced. Reason being the rooms we want to upgrade are great at resetting state, I think

Is the server supposed to drop everyone to PL 0 in the room?

Nope, just raise the requirement to send events.

It raises it to 50, but that's going to prevent new events from being sent by mods/admins.

Correct. It's just meant to stop clients which don't support upgrades from using the old room


[tests] Introduce assertEqualsInOrder/assertEqualsInAnyOrder for tests

Introduce assertEqualsInOrder/assertEqualsInAnyOrder for tests,
This also fixes #436 which we should not use equals to compare the un-ordered result because the snapshot data comes from  different task and may arrives in different order.

The CI passed, due to this is a test improvements, I'll merge it.


resnet 152

i'm running the 152 layer model using the default hyper-parameters, will update the results on this issue
current progress
INFO:root:Epoch[10] Batch [4850]        Speed: 298.15 samples/sec       Train-accuracy=0.447188
INFO:root:Epoch[10] Batch [4850]        Speed: 298.15 samples/sec       Train-top_k_accuracy_5=0.697656
INFO:root:Epoch[10] Batch [4900]        Speed: 298.05 samples/sec       Train-accuracy=0.445703
INFO:root:Epoch[10] Batch [4900]        Speed: 298.05 samples/sec       Train-top_k_accuracy_5=0.699609
INFO:root:Epoch[10] Batch [4950]        Speed: 297.75 samples/sec       Train-accuracy=0.444453
INFO:root:Epoch[10] Batch [4950]        Speed: 297.75 samples/sec       Train-top_k_accuracy_5=0.695312
INFO:root:Epoch[10] Batch [5000]        Speed: 298.33 samples/sec       Train-accuracy=0.443906
INFO:root:Epoch[10] Batch [5000]        Speed: 298.33 samples/sec       Train-top_k_accuracy_5=0.690469
INFO:root:Epoch[10] Resetting Data Iterator
INFO:root:Epoch[10] Time cost=4299.024
INFO:root:Saved checkpoint to "model/resnet-imagenet-152-0011.params"
INFO:root:Epoch[10] Validation-accuracy=0.507553
INFO:root:Epoch[10] Validation-top_k_accuracy_5=0.765446
INFO:root:Epoch[11] Batch [50]  Speed: 306.66 samples/sec       Train-accuracy=0.444453
INFO:root:Epoch[11] Batch [50]  Speed: 306.66 samples/sec       Train-top_k_accuracy_5=0.694766
INFO:root:Epoch[11] Batch [100] Speed: 298.39 samples/sec       Train-accuracy=0.444609
INFO:root:Epoch[11] Batch [100] Speed: 298.39 samples/sec       Train-top_k_accuracy_5=0.694141
INFO:root:Epoch[11] Batch [150] Speed: 298.08 samples/sec       Train-accuracy=0.439922
INFO:root:Epoch[11] Batch [150] Speed: 298.08 samples/sec       Train-top_k_accuracy_5=0.691719

great!!
i'll verify  RandomSkipResizeIter (https://github.com/dmlc/mxnet/issues/2968 )in cifar10 and resnet-50(from epoch 90), i think it should leads to a better result.

a large batch size seems help a lot at least for the beginning, here 101 uses 512 while 152 uses 256

resnet use many bn layers(especially one bn on the input data for mean-val normalization), and large batch size maybe useful for bn.
looks like resnet-101 much better than 152 at beginning.

the currently resnet-50.log is not strict by mx.lr_scheduler.MultiFactorScheduler(step=[30*epoch_size, 60*epoch_size, 90*epoch_size], factor=0.1), and is ```mx.lr_scheduler.MultiFactorScheduler(step=[30epoch_size, 60epoch_size, 80*epoch_size], factor=0.1)  , and at 83 epoch i cancel the scale/ration/hsv augment.
now i'm retraining according to README.md from epoch 80, and i see it leads better result, when it finished this weekend, i'll update the resnet-50 model and log.

@mli   https://github.com/tornadomeet/ResNet/issues/3 this maybe useful~

decreasing lr at epoch 30 is too early. i think we may choose epoch 50 or 60.

agree.  deeper network should decrease lr slower, i'll training resnet-18/resnet-34 and choosing epoch 50.

i tried "cancel the scale/color/ratio augmentation" at epoch 120, it leads a big decrease of both training and test accuracy.

@mli  so what's the acc now?(in resnet-50, when cancel those augmentation, it will improve absolute 1.5%~2.5% of test acc, and > 10% of train eventually)

does it decrease acc or  increase acc?

INFO:root:Epoch[100] Batch [4900]       Speed: 296.42 samples/sec       Train-accuracy=0.781172
INFO:root:Epoch[100] Batch [4900]       Speed: 296.42 samples/sec       Train-top_k_accuracy_5=0.922891
INFO:root:Epoch[100] Batch [4950]       Speed: 295.91 samples/sec       Train-accuracy=0.776641
INFO:root:Epoch[100] Batch [4950]       Speed: 295.91 samples/sec       Train-top_k_accuracy_5=0.925234
INFO:root:Epoch[100] Batch [5000]       Speed: 295.86 samples/sec       Train-accuracy=0.773828
INFO:root:Epoch[100] Batch [5000]       Speed: 295.86 samples/sec       Train-top_k_accuracy_5=0.920859
INFO:root:Epoch[100] Validation-accuracy=0.767020
INFO:root:Epoch[100] Validation-top_k_accuracy_5=0.929887

canceled 6 augs:
INFO:root:Epoch[101] Batch [4950]       Speed: 296.68 samples/sec       Train-accuracy=0.668672
INFO:root:Epoch[101] Batch [4950]       Speed: 296.68 samples/sec       Train-top_k_accuracy_5=0.850156
INFO:root:Epoch[101] Batch [5000]       Speed: 297.75 samples/sec       Train-accuracy=0.661641
INFO:root:Epoch[101] Batch [5000]       Speed: 297.75 samples/sec       Train-top_k_accuracy_5=0.847578
INFO:root:Epoch[101] Resetting Data Iterator
INFO:root:Epoch[101] Time cost=4340.443
INFO:root:Saved checkpoint to "model/resnet-imagenet-152-0102.params"
INFO:root:Epoch[101] Validation-accuracy=0.758889
INFO:root:Epoch[101] Validation-top_k_accuracy_5=0.924705

it is strange.

does  lr  set  correctly ? when cancel those augs, the lr should be the same as before canceling, just like 0.0001 if lr drops 3 times or 0.001 if drops 2 times.
when cancel those augs, it should use train_256_q90.rec.

another, i fixed a bugs when using retrain https://github.com/tornadomeet/ResNet/commit/bcd6a09dafe9d169e9e45e9a762294f45598a37e, maybe you can check that. it will influence the step of lr_scheduler.

ah, i forget to switch to the 256 rec
On Sun, Aug 28, 2016 at 10:49 PM, Wei Wu<EMAIL_ADDRESS>wrote:

it is strange.

does lr set correctly ? when cancel those augs, the lr should be the
same as before canceling, just like 0.0001 if lr drops 3 times or 0.001 if
drops 2 times.
when cancel those augs, it should use train_256_q90.rec.

another, i fixed a bugs when using retrain bcd6a09
https://github.com/tornadomeet/ResNet/commit/bcd6a09dafe9d169e9e45e9a762294f45598a37e,
maybe you can check that. it will influence the step of lr_scheduler.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tornadomeet/ResNet/issues/1#issuecomment-243037357,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZv4VXgp72l61Y-yDXxwiVC-FiWB0MKks5qknL5gaJpZM4JrOcp
.

solved by #9

@mli How's the effect of batch size for the final val error? Is 128 better or 256 better? Thanks!

i guess so but didn't test. also recommend a small batch size if it doesn't
slow down too much
On Tue, Sep 13, 2016 at 7:54 PM, Zhuang Liu<EMAIL_ADDRESS>wrote:

@mli https://github.com/mli How's the effect of batch size for the
final val error? Is 128 better or 256 better? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tornadomeet/ResNet/issues/1#issuecomment-246891128,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZv4ebyuo1NMr796GT67F4SV8HiAliLks5qp2HYgaJpZM4JrOcp
.

So is 128 better or 256 better? I don't know what you mean by "I guess so"...sorry

we can get the answer of whether 128 better or 256 better? only by experiment, the model trained is batch -size=256, you can tried it using batch-size=128.

i guess 128 gives better accuracy, because smaller batch size often
converges faster. but as wei said, you need to do the experiment to find
the exact answer.
On Tue, Sep 13, 2016 at 9:12 PM, Wei Wu<EMAIL_ADDRESS>wrote:

we can get the answer of whether 128 better or 256 better? only by
experiment, the model trained is batch -size=256, you can tried it using
batch-size=128.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tornadomeet/ResNet/issues/1#issuecomment-246901621,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZv4U6UnPN2GdXNWUudIpkdOLULxHHnks5qp3QzgaJpZM4JrOcp
.

@tornadomeet @mli  thank you! but unfortunately I don't have that many GPUs to try out. I saw there were both 512 and 256 in the first figure, and 512 seems to be better so I'm curious. Thanks

@liuzhuang13 our experiments shows that large batch-size only converge faster at the beginning, but at the end of training, it will converge slower than smaller batch-size, and leads a worse reulst at the end.

@tornadomeet  Well that's in accordance with my observation on CIFAR dataset, thanks!

@tornadomeet  @liuzhuang13  how about using larger batchsize at the begining and  smaller one at the end of the training, just like canceling strong data augmentation at the late epochs?

just opposite, need small size at beginning, and large batch-size at the end.


Refactor code and simplify file processing

Pull Request: Main Refactoring and Conversion
Summary of Changes
This pull request introduces significant improvements and refactoring to enhance the MarkdownDB functionality. The key modifications include:

Class Breakdown:

The MarkdownDB class has been refactored into two distinct classes, separating concerns for indexing and querying.

Conversion to TypeScript Objects and SQL:

The Markdown file processing has been optimized by converting MD files into TypeScript objects before transforming them into SQL data.

Function Refactoring:

Few smaller functions have undergone refactoring.

Also, not sure if parse.ts and markdownToObject need to be separate. They seem to have overlapping responsibilities. I'd merge these two.

@mohamedsalem401 What do you think? I'm not sure about it

The reason why I think they should be independent is that parseFile.ts parses the links and tags from a string source, irrespective of whether it's in a local file or not, while markdownToObject.ts is responsible for loading files from the local file system.

The reason why I think they should be independent is that parseFile.ts parses the links and tags from a string source, irrespective of whether it's in a local file or not, while markdownToObject.ts is responsible for loading files from the local file system.

Yes, I agree, let's leave them separate

@mohamedsalem401 Where are the tests? 😄

I believe this pull request (PR) includes numerous changes at the moment. Therefore, I plan to open a new PR specifically for the latest changes, including tests.

@mohamedsalem401 Where are the tests? 😄

I believe this pull request (PR) includes numerous changes at the moment. Therefore, I plan to open a new PR specifically for the latest changes, including tests.

I think it would be better if we add tests to the same PR...
Also, I wouldn't merge it into main. We don't want to publish a new version of the package until the whole refactoring is ready. (Note we have an auto-publish workflow in place.)  Let's create another branch, .e.g v2, off of main and reopen this PR against that branch.

I think it would be better if we add tests to the same PR...
Also, please don't merge it to main. We don't want to publish a new version of the package until the whole refactoring is ready. (Note we have an auto-publish workflow in place.) Let's create another branch, .e.g v2, off of main and reopen this PR against that branch.

OK, I will add them in this pull request and will switch to the new branch v2

This was for #47 and we did this (for now) in a simpler way where we don't refactor existing code - see resolution details in #47. We reused some of this and will probably reuse more in future.


FancyZones gap on right edge of screen 0.15.1

Since 0.15.0 the right most Zone on the template Zones no longer reaches the edge of the screen leaving a visible gap.

Hi @Kruzkal
thank you for reporting the problem.
It happens with 3 columns but not with 2 or 4 because all columns have the same size and the screen width is even.
We'll fix it.

Same as https://github.com/microsoft/PowerToys/issues/286 (bottom edge vs left edge)

I'm working on a fix


Please add FoDUpload.win.exe to https://github.com/fod-dev/fod-uploader-java/releases/tag/v3.0.7

An FoDUpload.win.exe is provided for v3.0.1 (to replace the old, obsolete Windows FoDUploader): https://github.com/fod-dev/fod-uploader-java/releases/tag/v3.0.1
But v3.0.1 is already out of date, and does not support the options documented online here: https://ams.fortify.com/Docs/en/HPE_Fortify_on_Demand_User_Guide.htm#Additional_Services/Tools/FoD_Uploader/BSI_Running.htm%3FTocPath%3DAdditional%2520Services|Tools|FoDUploader|_____2
This is especially annoying/broken because FoDUpload v3.0.1 does not support BSI Tokens (taking the old BSI URLs instead), but following FoD changes which occurred along with the HPE -> Microfocus dashboard makeover in November 2017, the FoD portal no longer generates BSI URLs. Only BSI tokens are generated, now!

Here you go.  You can also build your own with Launch4J if we miss updating it during release cycles or bug fixes.  Let me know if this works for you as I hastily had to pull this together.
https://github.com/fod-dev/fod-uploader-java/releases/download/v3.0.7/FoDUpload.win.exe

Hello mtgibbs, and thanks for responding.
But isn't the main benefit of having a Windows binary version of the FoD uploader to avoid an external dependency on the Java runtime? Here's what I see in my TeamCity logs when I tell my build profile to fetch the Windows binary for the FoD uploader from your new URL:
[09:39:58][Step 6/7] Uploading D:\TeamCity\buildAgent\work\2b9299460950c628\payload.zip
[09:39:58][Step 6/7] Command line: D:\TeamCity\buildAgent\work\2b9299460950c628\FodUpload.win.exe -z "D:\TeamCity\buildAgent\work\2b9299460950c628\payload.zip" -ac   -ep "Subscription" -a "Manual" -bsi "eyJ0ZW5hbnRJZCI6MTMxNywidGVuYW50Q29kZSI6IlpvY2RvYyIsInJlbGVhc2VJZCI6MTI3NzE2LCJwYXlsb2FkVHlwZSI6IkFOQUxZU0lTX1BBWUxPQUQiLCJhc3Nlc3NtZW50VHlwZUlkIjoyNzMsInRlY2hub2xvZ3lUeXBlIjoiLk5FVCIsInRlY2hub2xvZ3lUeXBlSWQiOjEsInRlY2hub2xvZ3lWZXJzaW9uIjoiNC41IiwidGVjaG5vbG9neVZlcnNpb25JZCI6MTEsImF1ZGl0UHJlZmVyZW5jZSI6Ik1hbnVhbCIsImF1ZGl0UHJlZmVyZW5jZUlkIjoxLCJpbmNsdWRlVGhpcmRQYXJ0eSI6ZmFsc2UsImluY2x1ZGVPcGVuU291cmNlQW5hbHlzaXMiOnRydWUsInNjYW5QcmVmZXJlbmNlIjoiMCIsInNjYW5QcmVmZXJlbmNlSWQiOjAsInBvcnRhbFVyaSI6Imh0dHBzOi8vYW1zLmZvcnRpZnkuY29tIiwiYXBpVXJpIjoiaHR0cHM6Ly9hcGkuYW1zLmZvcnRpZnkuY29tIn0="
[09:40:02][Step 6/7] This application requires a Java Runtime Environment 1.8.0_144

I have opened https://github.com/fod-dev/fod-uploader-java/issues/23


remove "!resizing" Condition in componentWillReceiveProps

fix #99
Please read issue #99

Will be fixed in #112


Make TabBarSelection a widget

TabBarSelection is now expected to be an ancestor of its TabBar and TabBarView.

TabBarSelection no longer creates an InheritedWidget.
Descendants now add themselves as performance listeners with TabBarSelection.registerPerformanceListener() and remove themselves with TabBarSelection.unregisterPerformanceListener(). If the TabBarSelection is deactivated, the listeners are automatically unregistered and the listener's handleDeactivate() method is called.

LGTM, but if you don't add tests here we should at least file a bug for adding tests. And definitely file a bug about the insertion case if you don't test it and/or fix it.

I've filed two issues related to this CL:
Inserting a TabBarSelection doesn't cause its descendants to rebuild
https://github.com/flutter/flutter/issues/1017
The TabBarSelection listener machinery needs a test
https://github.com/flutter/flutter/issues/1018


Config in Lumen

The package does not use custom settings.
One line is missing in file ElasticsearchServiceProvider.php to use the settings.
protected function configure(): void
{
    $this->mergeConfigFrom(__DIR__ . '/../config/es.php', 'es');
    $this->publishes([
        __DIR__ . '/../config/' => config_path(),
    ], 'es.config');

    // Auto configuration with lumen framework.
    if (
        method_exists($this->app, 'configure') &&
        Str::contains($this->app->version(), 'Lumen')
    ) {
        $this->app->configure("es"); // Add this line.
        $this->app->configure(ConnectionResolverInterface::class);
    }
}

Hi @coolycow, es should be an alias for ConnectionResolverInterface::class.
Anyway, I'll look into it!


Update Codegen dependencies and make it stable

This tries to update codegen dependencies and make it stable.
It is blocked by some bug introduced upstream. The error thrown when generating the demo-store types is: Cannot read properties of null (reading 'union'), from this line.
It seems it can't infer selection nodes when using fragment spreads (around here).
Fixed in https://github.com/dotansimha/graphql-code-generator/pull/9709 . We are also patching this bug until this is merged and released.

Ready to review! 🙌


Adding to a collection with Github storage has a file naming bug

I've tried configuring the storage for a collection to both;

gh:site/nav/*.yml
gh:site/nav/

The screenshot below shows a commit result for each configuration, it appears that the path and file extension naming logic isn't working the same way when the storage is configured to use the local filesystem.

I see. FileSystem uses glob to iterate and GitHub only the folder name. I think it's easy to implement a glob-like iterator for GitHub, using glob_to_regexp.

That'd be great, so the configuration would be the same using a glob pattern and the file created in the repo would end up in the proper location and with the proper file type?

Yes, that's the idea.

It seems easy to implement.
It's just checking the filename here https://github.com/lumeland/cms/blob/main/storage/github.ts#L61 and only yield it if the name match with the regular expression.
I'll do it today or tomorrow.

@revgum I just made some changes. Can you test it before releasing a new version?

@oscarotero Pretty close! The file was created properly, the commit message looks good.. but the route redirected to the full path (ie. collection/nav/edit/src%2Fsite%2Fnav%2Ftesting-again.yml) and when I fix the url to just collection/nav/edit/testing-again.yml the page works but the title filename is wrong..

Because of the file naming issue, saving an update while editing the file fails because it is trying to find the incorrect file name in the repository.
ERROR Error: 2024-03-12T23:57:59.251Z [POST] http://localhost:3000/cms/branch/preview/collection/nav/edit/src%2Fsite%2Fnav%2Fabout.yml - File not found: *.yml/src/site/nav/src/site/nav/about.yml
    at GitHub.delete
    at eventLoopTick
    at async GitHub.rename
    at async Collection.rename
    at async Object.handler

I have updated a couple of fixes. Now it should work fine.
Can you confirm?
Thanks!

Works great, only one very minor issue that I see left.. The commit message for "Delete" doesn't appear to be using the commitMessage function, all I'm seeing for the message is "Delete file".

Good catch!
I had to change the commitMessage function to be able to use it everywhere. Let me know if it works to you.

Looks great and ready for a new release! Thank you!


[Color Chooser] whippy UI while rendering color

I don't know why, but the custom ARGB chooser dialog isn't smooth while moving the slider, the textview rendering is laggy and you feel some delay, Is like watching a low-fps rendering.
I'm running the latest version of material dialogs on a OnePlus 5 with the lastest Android version installed (8.1.0)

Well, I'm not sure how much can be done to help that since the seek bars are inside of a ViewPager. Some trickery would probably have to be done with touch events.


add apache license badge (fixes #15)

This change is

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


API rate limit exceeded

When trying to share a gist from Playground, I'm getting:
{
  "message": "API rate limit exceeded for [MY IP]. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)",
  "documentation_url": "https://developer.github.com/v3/#rate-limiting"
}

I guess it makes sense that it's possible to hit the limit given that playground uses client-side Github API, but it's the first time I'm seeing this.
I wonder what would be the correct way to fix this. Maybe add login via Github to the playground so that user could get higher limit of requests?

given that playground uses client-side Github API,

It doesn't, anymore (#270).

Maybe add login via Github to the playground so that user could get higher limit of requests?

That's a possibility that I've been toying around with in the back of my head. I should probably make a separate issue for that...

It doesn't, anymore

Well, I've only deployed to play.integer32.com; which deployment did you experience this on?

It was on play.rust-lang.org, as far as I understood, this is still the correct repo to report issues to?

this is still the correct repo to report issues to?

Yep, there's just two deployments. At this current point in time, they have slightly different releases of code, specifically regarding Gists. I was worried that you were reporting issues with the new code.

I'm going to close this for now, as we switched the Gist implementation. Thanks!


doc: create documentation for GUI

"How to use the gui" docs are required!
where are the test data files
where are the expected outputs?

@samarth8392 do you know if the GUI documentation for RENEE already exists and maybe we just didn't realize it?

I only worked on XAVIER GUI documentation but I can add similar documentation to RENEE as well. Just assign it to me and I will get it done.

@kopardev @kelly-sovacool I don't have the permission to create branches on RENEE and I don't see the "settings" tab on RENEE repo. Can one or either of you change the permissions so that I may be able to work on this issue?

@samarth8392 I just added you!


Resizer keyboard

Closes
The Resizer should only be visible during hover or after selecting resize from our Column Header menu.
You should be able to resize the column by hovering over it and clicking and dragging the Resizer.
You should be able to resize the column by keyboard navigating to the Column Header, opening the menu, and selecting resize. This should move focus to the resizer and then you can resize with the left and right arrow keys.
You should be able to resize the column by touching the Column Header with your finger to open the menu and selecting resize. Then touching and dragging the resizer left or right with your finger.
You should be able to cancel out of keyboard resizing using the Escape key or Enter key, which will return focus to the Column Header. Or, you can hit Tab/Shift+Tab to take you out of resizing mode and currently places you on the next cell.
Clicking elsewhere on the page or table should also take you out of keyboard resizing and edit mode.
In LTR, (this statement is flipped in RTL):
This PR also addresses our EW-resize cursor display. At min, it should only be an east resizer, at max it should only be a west resizer.
Notes: A partial implementation of edit mode was needed for this so that we could prevent grid navigation while resizing with the keyboard.
FocusScope changes were needed: contain can now be turned false in the middle of its life cycle, this was needed so that we could turn off containment in Menu's that are fading out. restoring focus should check if focus was lost before actually restoring.
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Looks good! A few minor things I discovered while testing, to address in followups.

After dragging a resizer with a mouse, it remains blue even when removing hover and coming back. I guess because it's focused. Should we even focus it with a mouse? If so, then where should we send focus afterward? Maybe the blue should only be the keyboard focus style unless it is actively being dragged?
Resizer doesn't line up with divider between cells (see screenshot below).
The e-resize/w-resize cursors don't match the col-resize cursor. One renders as an arrow, the other has a vertical line too. I like the col-resize cursor better - wonder if there is a way to make it only have one directional arrow without changing the style. Might require custom cursors, which I guess Spectrum does define...
When hovering over the column headers, only the resizer for that column shows up, but I think it might make sense to show all column resizers?
Probably should have some indicator (maybe a chevron) on hover to show that there is a menu.
Resizer probably doesn't have enough contrast when not focused. It's very difficult to see.


Remove Homebrew dependencies

Is your feature request related to a problem? Please describe.
The install instructions for Mac say to use Homebrew for installing cmake, protobuf, and rust.  That isn't needed, since all those packages are available through conda.  Using an extra package manager creates extra steps for the user and extra chances for things to go wrong.
Describe the solution you'd like
Just add those packages to environment-mac.yaml and they'll get installed automatically.  There's no need for the user to install or use brew.
Describe alternatives you've considered
N/A
Additional context
N/A

There was an extensive discussion of getting the same versions of python, torch, etc running smoothly on all three platforms, and we ended up with a bit of a compromise. You can catch up with the discussion at #331, but with the warning that it's a long thread.
It's possible that we should not have introduced brew into the mix (is that a mixed metaphor?), but I suggest waiting a few days for @magnusviri to return from his break. He is the resident Mac expert here.

Thanks.  For what it's worth, I installed them with conda and everything seems to be working well.

installing onnxruntime in conda fixes the protobuf dependency when it needs to build onnx from scratch and binaries are not available.  would def be nice to be completely self contained instead of relying on brew for libraries (don't use brew myself).
don't think installing rust separately is an issue.


fix: puller and pushync should use storage radius only for syncing

Checklist

[x] I have read the coding guide.
[ ] My change requires a documentation update, and I have done it.
[x] I have added tests to cover my changes.
[x] I have filled out the description and linked the related issues.

Description
Closes #3700
Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

This change is

unit tests are broken due the puller changes :(


:bug: fix TestSSLConnectionURLParsing and TestBlockingConnectionPool

I found that you had a lot of errors in overwriting the test

@yangjiaronga For each version of the redis-py packages that i support i merge in all of their tests that they have and adapt any tests that needs adapting to a clustered setting/envrionment. Merging all tests and ensure everything still works and is compatible is one of the most major/biggest things that i need to do between all supported releases. It is on purpose that if they update their tests i need to update mine as well, it is not optimal but it is what i can do right now to ensure that the cluster code works as expected and in the way i want since we override and modify upstream behaviour in many places.
I agree and disagree that i should only focus on redis-cluster behaviour, yes that is the primary goal and things that needs to be tested and validated, but since we muck around with commands and baasically changes how everything is routed around a cluster env, i need to test every single command that i want to be supported, there has been errors in the past that has surfaced due to things that has been done here with very simple commands.
Is this change some port of a change that was done inside reids-py in some version? If so can you please point me to the git commit that introduced these changes?
If you are looking into the master branch and test_lock.py for example, i think that was a file i ported in very recently and i have not goten around to sort all the new files out, and yes, ofc they should be using the rediscluster class instead of the upstream redis class. It is just a minor oversight that it is that right now and it will all be sorted before the next major release.

Hi, I think this change has been seen since redis-py v3.3.11.
# ensure this connection is connected to Redis
connection.connect()  # HERE!!

https://github.com/andymccurdy/redis-py/commit/cfa2bc9b7ea860eb4a002eaa7029ecee01e39735

Since the code from any release including and above 3.1.0 has not yet been fully merged into the code-base, this change is not really needed righ tnow as i would pick this up when i do merge the code and all related changes from the upstream/future versions of the code. I can keep this open for now, but it will be closed as invalid later on.

Manually added this to the code base in the following commit https://github.com/Grokzen/redis-py-cluster/commit/f273b65d887a4d711a6b5a4fed1176d7080a5b43 as it includes more changes from upstream redis-py lib. Closing this PR and the fixes requested will be part of next release.


pagination problem in grid

I am successfully fetching data from remote data source but I am not getting pagination it is showing  Rows per page: 0-0of0
the code I used is this:

I guess that the names of the fields that contains page and limit are called differently than 'page' and 'limit'.
You can rename them in the response or use http://gijgo.com/grid/configuration/paramNames.page and http://gijgo.com/grid/configuration/paramNames.limit to change their names.

Earlier I havent return 'total' in json result. Now I returned 'records' and 'total' in json result. The bar shows 5/26 items per page but it displays 26 records in the table but bar is showing 5/26 items per page.
Please help me out
Thanks in Advance

You can see how it works from our sample project at https://github.com/atatanasov/gijgo-asp-net-examples. Please use it as an example.

we have popup operation as inline
one more thing the date which is in json format is only formatted in display when we edit it shows /Date(234546464)/ like this. How can we over come this

I think that would be best if you use momentjs to format the date. Here is an example: http://gijgo.com/grid/Configuration/column.format


[feat] Impose units in performance reference tuple

Fix checks that don't contain units in performance reference tuples.

Add unit test.

Documentation fixes.

Fixes #1147

@jenkins-cscs retry none

Codecov Report

Merging #1223 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1223   +/-   ##
=======================================
  Coverage   91.92%   91.92%
=======================================
  Files          84       84
  Lines       12209    12209
=======================================
  Hits        11223    11223
  Misses        986      986

Impacted Files
Coverage Δ

reframe/core/pipeline.py
92.35% <100.00%> (-0.05%)
:arrow_down:

unittests/test_pipeline.py
95.31% <100.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db805c2...7e15e1b. Read the comment docs.


Some files in GitDependencyResolverForUnity conflicts with UpmGitExtension

Version 'https://my.gitlab.com/npm/test.git#1.1.1' is invalid. Expected a 'SemVer' compatible value. (NotFound)
{
"name": "com.test",
"displayName": "My test",
"version": "2.1.4",
"unity": "2019.1",
"description": "above. ",
"dependencies": {
"com.test22": "https://gitlab.io-games.com/npm/test.git#1.1.1"
}
}

Removing library folder does not help.

Hi @dimmduh
I would like to know more information on this issue.
Environment (please complete the following information):

Platform: [e.g. Editor(Windows/Mac), Standalone(Windows/Mac)]
Unity: [e.g. 2018.3.0f1]
GitDependencyResolverForUnity: [e.g. v1.1.2]

Windows 7 SP1
Unity 20191.10f1
v1.1.2

I am also experiencing this:
Error: Unable to add package [com.starikcetin.eflatun.unitycommon@https://github.com/starikcetin/Eflatun.UnityCommon.git#0.0.1-upm]:
  Package com.starikcetin.eflatun.unitycommon@https://github.com/starikcetin/Eflatun.UnityCommon.git#0.0.1-upm has invalid dependencies:
    com.starikcetin.eflatun.expansions: Version 'https://github.com/starikcetin/Eflatun.Expansions.git#0.1.0-upm' is invalid. Expected a 'SemVer' compatible value. (NotFound)
UnityEngine.Debug:LogErrorFormat(String, Object[])
Coffee.PackageManager.Debug:LogErrorFormat(String, Object[]) (at Library/PackageCache/com.coffee.upm-git-extension@79fa88282ae1233e4841d87fd256b80f13cd8b62/Editor/Scripts/Common/Utils.cs:43)
Coffee.PackageManager.PackageUtils:UpdatePackageRequest() (at Library/PackageCache/com.coffee.upm-git-extension@79fa88282ae1233e4841d87fd256b80f13cd8b62/Editor/Scripts/Common/Utils.cs:443)
UnityEditor.EditorApplication:Internal_CallUpdateFunctions()

Windows 10
Unity 2019.2.5f1
GitDependencyResolver 1.1.2
UpmGitExtension 0.9.1

This is weird, but putting git+ at the beginning works:
    "com.starikcetin.eflatun.unitycommon": "git+https://github.com/starikcetin/Eflatun.UnityCommon#0.0.1-upm",

I got it working but it is very inconsistent. It only works if I close unity, delete the library folder, and paste the references manually into manifest.json. UpmGitExtension doesn't work.

Hi @dimmduh @starikcetin @onMouseUp
Sorry for my late reply.
Some files in GitDependencyResolverForUnity conflicts with UpmGitExtension .
(These packages use the same namespace Coffee.PackageManager )
I will fix it. :)

Version 1.1.3 is released. Try it!

Does it work for UpmGitExtension also?

Yes, I tested it with demo repo.
https://github.com/mob-sakai/UnityGitDependencyTest

Error: Unable to add package [com.starikcetin.eflatun.unitycommon@https://github.com/starikcetin/Eflatun.UnityCommon.git#0.0.3]:
  Package com.starikcetin.eflatun.unitycommon@https://github.com/starikcetin/Eflatun.UnityCommon.git#0.0.3 has invalid dependencies:
    com.starikcetin.eflatun.expansions: Version 'https://github.com/starikcetin/Eflatun.Expansions.git#0.1.1' is invalid. Expected a 'SemVer' compatible value. (NotFound)
UnityEngine.Debug:LogErrorFormat(String, Object[])
Coffee.PackageManager.Debug:LogErrorFormat(String, Object[]) (at Library/PackageCache/com.coffee.upm-git-extension@79fa88282ae1233e4841d87fd256b80f13cd8b62/Editor/Scripts/Common/Utils.cs:43)
Coffee.PackageManager.PackageUtils:UpdatePackageRequest() (at Library/PackageCache/com.coffee.upm-git-extension@79fa88282ae1233e4841d87fd256b80f13cd8b62/Editor/Scripts/Common/Utils.cs:443)
UnityEditor.EditorApplication:Internal_CallUpdateFunctions()

Import from UpmGitExtension doesn't work still :(

Hmm, works well on Unity 2018.3, but not on Unity 2019.1.
New issue: #18