HBASE-26622 Update error-prone to 2.10

Picks up on @madrob 's #3979 , applies the changes I outlined. Specifically:

Upgrades us to the last version of Error Prone that retains support for JDK8 compiler (happens to be the latest release, at this time)
Keeps the errorprone profile attached to JDK8 compiler profile
Minor changes regarding java docs and unit test warnings
Swap the KeyValue#clone method to use Arrays.copyOf as Mike suggested in the other PR.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 43s
master passed

+1 :green_heart:
compile
5m 53s
master passed

+1 :green_heart:
checkstyle
1m 11s
master passed

+1 :green_heart:
spotbugs
11m  4s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 25s
the patch passed

-1 :x:
compile
4m 16s
root in the patch failed.

-0 :warning:
javac
4m 16s
root in the patch failed.

-0 :warning:
checkstyle
1m 10s
root: The patch generated 1 new + 84 unchanged - 1 fixed = 85 total (was 85)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 39s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
11m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 14s
The patch does not generate ASF License warnings.

61m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 14ef7c3beb0b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3a53c11dbf

Default Java
AdoptOpenJDK-1.8.0_282-b08

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/1/artifact/yetus-general-check/output/patch-compile-root.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/1/artifact/yetus-general-check/output/patch-compile-root.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt

Max. process+thread count
88 (vs. ulimit of 30000)

modules
C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 54s
master passed

+1 :green_heart:
compile
1m 48s
master passed

+1 :green_heart:
shadedjars
4m 57s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
1m 53s
the patch passed

+1 :green_heart:
javac
1m 53s
the patch passed

+1 :green_heart:
shadedjars
4m 57s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
393m 21s
root in the patch passed.

422m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 700e44f4f97e 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3a53c11dbf

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/1/testReport/

Max. process+thread count
2567 (vs. ulimit of 30000)

modules
C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m  9s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 37s
master passed

+1 :green_heart:
compile
1m 47s
master passed

+1 :green_heart:
shadedjars
4m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  3s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 23s
the patch passed

+1 :green_heart:
compile
1m 43s
the patch passed

+1 :green_heart:
javac
1m 43s
the patch passed

+1 :green_heart:
shadedjars
4m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
543m  9s
root in the patch passed.

576m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 119e7d1029da 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3a53c11dbf

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/1/testReport/

Max. process+thread count
2303 (vs. ulimit of 30000)

modules
C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 22s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 24s
master passed

+1 :green_heart:
compile
6m 27s
master passed

+1 :green_heart:
checkstyle
1m 21s
master passed

+1 :green_heart:
spotbugs
12m  1s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 42s
the patch passed

+1 :green_heart:
compile
6m 31s
the patch passed

-0 :warning:
javac
6m 31s
root generated 119 new + 1353 unchanged - 272 fixed = 1472 total (was 1625)

-0 :warning:
checkstyle
1m  9s
root: The patch generated 1 new + 84 unchanged - 1 fixed = 85 total (was 85)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 25s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
12m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 13s
The patch does not generate ASF License warnings.

69m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 4dbaf72fa5a4 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5dc663ea38

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt

Max. process+thread count
87 (vs. ulimit of 30000)

modules
C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 44s
master passed

+1 :green_heart:
compile
1m 51s
master passed

+1 :green_heart:
shadedjars
5m  6s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 45s
the patch passed

+1 :green_heart:
compile
1m 53s
the patch passed

+1 :green_heart:
javac
1m 53s
the patch passed

+1 :green_heart:
shadedjars
4m 59s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 24s
the patch passed

_ Other Tests _

-1 :x:
unit
344m 24s
root in the patch failed.

374m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2b64545a6ad6 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5dc663ea38

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/2/testReport/

Max. process+thread count
1630 (vs. ulimit of 30000)

modules
C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

-0 :warning:
yetus
2m 49s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 36s
master passed

+1 :green_heart:
compile
1m 40s
master passed

+1 :green_heart:
shadedjars
4m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 21s
the patch passed

+1 :green_heart:
compile
1m 39s
the patch passed

+1 :green_heart:
javac
1m 39s
the patch passed

+1 :green_heart:
shadedjars
4m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  2s
the patch passed

_ Other Tests _

-1 :x:
unit
472m 38s
root in the patch failed.

503m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cf14d2298919 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5dc663ea38

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/2/testReport/

Max. process+thread count
1719 (vs. ulimit of 30000)

modules
C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 34s
master passed

+1 :green_heart:
compile
5m 27s
master passed

+1 :green_heart:
checkstyle
1m  9s
master passed

+1 :green_heart:
spotbugs
10m 22s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 19s
the patch passed

+1 :green_heart:
compile
6m  0s
the patch passed

-0 :warning:
javac
6m  0s
root generated 119 new + 1353 unchanged - 272 fixed = 1472 total (was 1625)

+1 :green_heart:
checkstyle
1m  6s
root: The patch generated 0 new + 80 unchanged - 5 fixed = 80 total (was 85)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 25s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
11m  4s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 56s
The patch does not generate ASF License warnings.

59m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux cb702ee6999e 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f8699176f7

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt

Max. process+thread count
87 (vs. ulimit of 30000)

modules
C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 48s
master passed

+1 :green_heart:
compile
1m 51s
master passed

+1 :green_heart:
shadedjars
3m 53s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 42s
the patch passed

+1 :green_heart:
compile
1m 51s
the patch passed

+1 :green_heart:
javac
1m 51s
the patch passed

+1 :green_heart:
shadedjars
3m 56s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
399m 57s
root in the patch passed.

427m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 89a269574126 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f8699176f7

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/3/testReport/

Max. process+thread count
2490 (vs. ulimit of 30000)

modules
C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  1s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 23s
master passed

+1 :green_heart:
compile
1m 40s
master passed

+1 :green_heart:
shadedjars
3m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  5s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 25s
the patch passed

+1 :green_heart:
compile
1m 41s
the patch passed

+1 :green_heart:
javac
1m 41s
the patch passed

+1 :green_heart:
shadedjars
3m 45s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
542m 57s
root in the patch passed.

568m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 892c6565fdaa 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f8699176f7

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/3/testReport/

Max. process+thread count
2300 (vs. ulimit of 30000)

modules
C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 38s
master passed

+1 :green_heart:
compile
5m 49s
master passed

+1 :green_heart:
checkstyle
1m  9s
master passed

+1 :green_heart:
spotbugs
10m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 20s
the patch passed

+1 :green_heart:
compile
6m 15s
the patch passed

-0 :warning:
javac
6m 15s
root generated 119 new + 1353 unchanged - 272 fixed = 1472 total (was 1625)

+1 :green_heart:
checkstyle
1m 10s
root: The patch generated 0 new + 80 unchanged - 5 fixed = 80 total (was 85)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 22s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
11m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 13s
The patch does not generate ASF License warnings.

63m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 6d6b19e9ee6e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e85bf414ab

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt

Max. process+thread count
87 (vs. ulimit of 30000)

modules
C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 26s
master passed

+1 :green_heart:
compile
2m 10s
master passed

+1 :green_heart:
shadedjars
4m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 39s
the patch passed

+1 :green_heart:
compile
1m 48s
the patch passed

+1 :green_heart:
javac
1m 48s
the patch passed

+1 :green_heart:
shadedjars
3m 51s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
405m 28s
root in the patch passed.

435m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ac920f911ce4 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e85bf414ab

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/testReport/

Max. process+thread count
2445 (vs. ulimit of 30000)

modules
C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 57s
master passed

+1 :green_heart:
compile
1m 46s
master passed

+1 :green_heart:
shadedjars
4m 16s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  9s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 44s
the patch passed

+1 :green_heart:
compile
1m 57s
the patch passed

+1 :green_heart:
javac
1m 57s
the patch passed

+1 :green_heart:
shadedjars
5m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
625m 43s
root in the patch passed.

656m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b624280b7345 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e85bf414ab

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/testReport/

Max. process+thread count
2414 (vs. ulimit of 30000)

modules
C: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 32s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 25s
master passed

+1 :green_heart:
compile
5m 25s
master passed

+1 :green_heart:
checkstyle
1m  8s
master passed

+1 :green_heart:
spotbugs
10m 18s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 20s
the patch passed

+1 :green_heart:
compile
6m  8s
the patch passed

-0 :warning:
javac
6m  8s
root generated 119 new + 1353 unchanged - 272 fixed = 1472 total (was 1625)

+1 :green_heart:
checkstyle
1m  5s
root: The patch generated 0 new + 80 unchanged - 5 fixed = 80 total (was 85)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  0s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 17s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
11m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 51s
The patch does not generate ASF License warnings.

60m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 2a954ae14eee 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 87f8d9ac4e

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-general-check/output/diff-compile-javac-root.txt

Max. process+thread count
87 (vs. ulimit of 30000)

modules
C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 12s
master passed

+1 :green_heart:
compile
1m 57s
master passed

+1 :green_heart:
shadedjars
4m 17s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 21s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 58s
the patch passed

+1 :green_heart:
compile
1m 56s
the patch passed

+1 :green_heart:
javac
1m 56s
the patch passed

+1 :green_heart:
shadedjars
4m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 21s
the patch passed

_ Other Tests _

-1 :x:
unit
347m 19s
root in the patch failed.

376m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ad9728fda56d 5.4.0-1047-aws #49~18.04.1-Ubuntu SMP Wed Apr 28 23:08:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 87f8d9ac4e

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/testReport/

Max. process+thread count
1551 (vs. ulimit of 30000)

modules
C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 21s
master passed

+1 :green_heart:
compile
1m 39s
master passed

+1 :green_heart:
shadedjars
3m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 21s
the patch passed

+1 :green_heart:
compile
1m 40s
the patch passed

+1 :green_heart:
javac
1m 40s
the patch passed

+1 :green_heart:
shadedjars
3m 45s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 53s
the patch passed

_ Other Tests _

-1 :x:
unit
471m 32s
root in the patch failed.

496m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4133

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2240dd146828 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 87f8d9ac4e

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/testReport/

Max. process+thread count
1664 (vs. ulimit of 30000)

modules
C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


tensorflow

hello there, could  you please guide me how did you install tensorflow in pynq-z2 board for this project ?
Best regards

You don't have to install tensorflow in PYNQ-Z2. I just use tensorflow on my PC to train the CNN model and get weights and biases.


The proper way to create the console logger factory in EF Core 3.0

public static readonly ILoggerFactory MyLoggerFactory = LoggerFactory.Create(builder => builder.AddConsole());

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed83069f-39a8-e992-95f7-a8b41154b6f4
Version Independent ID: 144fe168-080f-6557-e4b2-a18adb4b89ed
Content: Logging - EF Core
Content Source: entity-framework/core/miscellaneous/logging.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @rowanmiller
Microsoft Alias: divega

Just looked into this for the sample, so poaching...


Upgrade Checker Framework Annotations 3.37.0 -> 3.38.0

This PR contains the following updates:

Package
Type
Update
Change

Checker Framework Annotations (source)
compile
minor
3.37.0 -> 3.38.0

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Checker Framework Annotations 3.37.0 -> 3.38.0

See:
- https://github.com/typetools/checker-framework/releases/tag/checker-framework-3.38.0
- https://github.com/typetools/checker-framework/compare/checker-framework-3.37.0...checker-framework-3.38.0


Named slots' content is not generated for stubbed components via shallowMount

What problem does this feature solve?
Higher-order components make use of named slots. It's possible to test higher-order components via shallowMount because named slot content can be mocked, but it's not possible to test components which consume higher-order components because their generated named slot output is not available in the stubbed content.
https://github.com/vuejs/vue-test-utils/pull/782 added support for outputting default slot content, but not named slots.
To be clear, an example of a component which needs this support is:
<!-- myComponent.vue -->
<template>
  <HigherOrderComponent foo="bar">
    default slot content
    <template v-slot="header">header slot content</template>
    <template v-slot="footer">footer slot content<HigherOrderComponent foo="waldo"/></template>
  </HigherOrderComponent>
</template>

Currently, this is stubbed out to only:
<higherordercomponent-stub foo="bar">default slot content</higherordercomponent-stub>
The end user experience should be that components which generate named slot content "just work" when testing with shallowMount.
What does the proposed API look like?
The API would not change.

Related to #1261?

@runarberg I think this is a different issue. The "old syntax" slots render, but they do not render with any kind of wrapper, so they appear to be in the default slot and it's not possible for a test to confirm whether content was rendered to the correct slot.

To be clear, to properly test a component, its shallowMount rendering should be something like this:
<higherordercomponent-stub foo="bar">
  default slot content
  <template-stub v-slot="header">header slot content</template-stub>
  <template-stub v-slot="footer">footer slot content<HigherOrderComponent foo="waldo"/></template-stub>
</higherordercomponent-stub>

Not simply this:
<higherordercomponent-stub foo="bar">
  default slot content
  header slot content
  footer slot content
</higherordercomponent-stub>

I was hoping #1261 would fix the issue we were having with moving our codebase to the new slot syntax, but that didn't resolve the issue. Moving to the new slot syntax breaks a lot of our existing unit tests.
It looks like this would allow us to use the new syntax while keeping our existing unit tests as-is. Is there a timeline of when this would be available?

I believe the new slot syntax is now supported @jcmillett  - this is a differerent issue unique to shallowMount, no?

I have closed the PR that supposedly solved this problem.
We will revisit shallowMount and how it should render things for the Vue 3 integration. At this point, I don't think we will change how shallowMount is working.
I will make a new issue when we revisit shallowMount for v3 integration and invite everyone's input that point.

For those looking for a solution now, manually stubbing out the component seems to render the child slots:
const wrapper = shallowMount(MyComponent, {
  stubs: { HigherOrderComponent }
}

expect(wrapper.text()).toContain('header slot content');
expect(wrapper.text()).toContain('footer slot content');

This may work but you end up stubbing so much you aren't really testing anything. The best way to test slots is by using mount, you'll get the same behavior as production and avoid writing tests that give you false confidence.

but you end up stubbing so much

That's the point. To use OP's example, I'm writing a unit test for myComponent.vue, so I want HigherOrderComponent to be stubbed out. I also want to test that myComponent is sending down the correct template data to HigherOrderComponent. Right now, the default template is being rendered with shallowMount, but named templates are not. This doesn't make sense. Manually stubbing out HigherOrderComponent fixes it so that named templates are rendered in the stub as well. Using mount means that my unit test is no longer a unit test. If myComponent was the root component, by using mount the entire app is instantiated.

Important part:

Vue Test Utils allows you to mount a component without rendering its child components (by stubbing them) with the shallowMount method

At least, this was the intention. To stub the children.
Unit testing a single component might make sense sometimes, but if you are testing with slots, it doesn't make a ton of sense to test it as a single unit - it will never be used a single unit, but with other components and children. Just use mount to test it. Using stubs and shallow is really just making more work  for yourself - but each to their own.
We will improve the docs before Vue 3 integration (over the next few weeks). If you are interested, I will add you as a reviewer to a PR that discusses testing slots, since you have an interest in this topic. There is definitely different ways to accomplish the same thing. We should mention both approaches, and their pros and cons. Is this something you'd like to be involve with?

it will never be used a single unit, but with other components and children. Just use mount to test it.

mount no longer makes it a unit test, it becomes an integration test, and like all integration tests, everything that's instantiated must be set up properly. If like OP I'm testing the root component and I want to verify in a unit test that the header, footer, and body content is being passed to <HigherOrderComponent> properly, using mount means I have to ensure that every descendant component has the data it needs to render properly. This might mean mocking out API endpoints or any other setup needed, just to test the root component. In other words:
<root-component>
  <child-component-1>
    <child-component-2>
      ...
      <child-component-10> <!-- if this does an AJAX call, I have to mock it -->
        <child-component-11> <!-- if this does an AJAX call, I have to mock it -->

child components 10 and 11 are very far removed from the root component, but by using mount, I now have to mock out endpoints that have nothing to do with the root component. It becomes the same problem as instantiating the entire app and setting everything up for that to happen, just to test one thing.

Using stubs and shallow is really just making more work for yourself

shallowMount works exactly as expected, except when it comes to rendering named slots. I believe you're saying that because the slot is rendered in the child and the child is stubbed, so the slot shouldn't be rendered, and that would make sense, except that the default slot is rendered. This is what I mean by it doesn't make sense; why would the default slot get rendered, but not named slots? If stubbed children shouldn't render anything, then why is the default slot getting rendered?
Ultimately, what we need is a way to unit test a component that passes down named slot templates to a stubbed child. This is already possible with shallowMount using attributes() and props(), but currently nothing exists for templates, so we have no choice but to check the contents of the child stub. Ideally, there'd be something like wrapper.templates() so that we don't have to rely on the child rendering the slot template, but for now the stubs: { Component } workaround works.

then why is the default slot getting rendered?

Because shallowMount is, and has been, broken for a long time. What you are saying is correct; we should be stubbing the default slot as well (like Enzyme, which this was based on).
I see two options:

we change the current behavior to be "correct" and stub everything (as shallow mount in enzyme does)
we "shallow" everything including their stubs. A few people have tried this, I can't remember why no-one has managed to solve it.

In the second case if I have
<template>
  <Foo>
    <Bar>
      <Qux>
    </Bar>
  </Foo>
</template>

What do I get? <foo-stub><bar-stub><qux-stub></bar-stub></foo-stub>?
I still don't really see what's so bad about using stubs or jest.mock - if component that is nested 11 levels deep is giving you problems, just stub it out and carry on.

Why people are obsessed with isolating components is beyond me.

I already addressed that.

What do I get? <foo-stub><bar-stub><qux-stub></bar-stub></foo-stub>?

Yes.

I still don't really see what's so bad about using stubs or jest.mock

For the sake of example, you have 1 million unique child components. Do you stub every one out? And after you do, what's the difference between mount and shallowMount if you've stubbed everything out except the one component you're testing?

We are investigating the rendering of stubbed slots for our Vue 3 integration. I still don't see why slots should get special treatment - shallow should stub everything, instead of this weird selector slot behavior.
If you have 1 million unique components then your component is not testable. Write your code in a testable manner. Use mount. What's the alternative? 1 million isolated specs with shallowMount?
Clearly I am not the target user for this feature, so I can't fully understand. Either way, I am way pasting trying to push this issue. Let's move on.

W will find something for this use case in the Vue 3 integration, since this is something (some) users feel strongly about. If you feel strongly about this issue, you are more than welcome to attempt to implement the above behavior in this code base, too.

If you have 1 million unique components then your component is not testable. Write your code in a testable manner.

I said "for the sake of example", the focus here is not the number of components. You said "just stub out the troublesome component", and I'm saying that it could be 2, 5, a dozen, or any arbitrary number of components that need to be stubbed out when using mount, with the worst case being having to stub out every other component except for the one being tested. For large apps with deep trees, this can lead to stubbing out large parts of the app just to write a "unit test", which is starting with an integration test and stubbing out everything that's causing problems until it effectively becomes a unit test.

Clearly I am not the target user for this feature, so I can't fully understand.

The user story is, "as a developer writing a unit test, I want to verify that my component is passing the proper data to a child component." Data is defined as anything and everything that can be passed to the child component, which AFAIK is props, attributes, and templates. So given this example:
<my-component>
  <!-- other stuff that my-component does with its data -->
  <child-component :p1="data.p1" :p2="data.p2" data-prefix="prefix">
    <template>{{ data.defaultSlot }}</template>
    <template #named>{{ data.namedSlot }}</template>
  </child-component>
</my-component>

it('test my component', () => {
  const data = {
    p1: 'p1',
    p2: 'p2'
    defaultSlot: 'default slot text',
    namedSlot: 'named slot text'
  }
  const wrapper = shallowMount(MyComponent, {
    propsData: { data });
  })
  const child = wrapper.find(ChildComponent);

  // We can test for props on child stubs.
  expect(child.props('p1')).toBe(data.p1);
  expect(child.props('p2')).toBe(data.p2);
  // We can test for attributes on child stubs.
  expect(child.attributes('data-prefix')).toBe('prefix');
  // We can test for the default slot on child stubs.
  expect(child.text()).toContain(data.defaultSlot);

  // We CANNOT test for named slots on child stubs.
  expect(child.text()).toContain(data.namedSlot);
}

If you feel strongly about this issue, you are more than welcome to attempt to implement the above behavior in this code base, too.

It's already been done, but you closed it: https://github.com/vuejs/vue-test-utils/pull/1309 From your comment in the PR:

I think stubbed children should not render their slots.

To reiterate the above example:
We can test that props are properly passed to children using .props().
We can test that attributes are properly passed to children using .attributes().
We can test that the default slot is properly passed to children using .text() or .html().
Without the stubs: { Component } workaround, we cannot test that named slots are passed properly. Whether stubs should render content inside them is really not the point here, it's that there's no other way to test slots otherwise in a unit test. If there was something like childWrapper.templates(), then I'm all for stubbing out the child completely, but until that happens, checking childWrapper.text() or childWrapper.html() remains the only way to verify slots. Using mount is not a solution because, once again, it turns a unit test into an integration test.

If you have 1 million unique components then your component is not testable. Write your code in a testable manner.

I said "for the sake of example", the focus here is not the number of components. You said "just stub out the troublesome component", and I'm saying that it could be 2, 5, a dozen, or any arbitrary number of components that need to be stubbed out when using mount, with the worst case being having to stub out every other component except for the one being tested. For large apps with deep trees, this can lead to stubbing out large parts of the app just to write a "unit test", which is starting with an integration test and stubbing out everything that's causing problems until it effectively becomes a unit test.

Clearly I am not the target user for this feature, so I can't fully understand.

The user story is, "as a developer writing a unit test, I want to verify that my component is passing the proper data to a child component." Data is defined as anything and everything that can be passed to the child component, which AFAIK is props, attributes, and templates. So given this example:
<my-component>
  <!-- other stuff that my-component does with its data -->
  <child-component :p1="data.p1" :p2="data.p2" data-prefix="prefix">
    <template>{{ data.defaultSlot }}</template>
    <template #named>{{ data.namedSlot }}</template>
  </child-component>
</my-component>

it('test my component', () => {
  const data = {
    p1: 'p1',
    p2: 'p2'
    defaultSlot: 'default slot text',
    namedSlot: 'named slot text'
  }
  const wrapper = shallowMount(MyComponent, {
    propsData: { data });
  })
  const child = wrapper.find(ChildComponent);

  // We can test for props on child stubs.
  expect(child.props('p1')).toBe(data.p1);
  expect(child.props('p2')).toBe(data.p2);
  // We can test for attributes on child stubs.
  expect(child.attributes('data-prefix')).toBe('prefix');
  // We can test for the default slot on child stubs.
  expect(child.text()).toContain(data.defaultSlot);

  // We CANNOT test for named slots on child stubs.
  expect(child.text()).toContain(data.namedSlot);
}

If you feel strongly about this issue, you are more than welcome to attempt to implement the above behavior in this code base, too.

It's already been done, but you closed it: https://github.com/vuejs/vue-test-utils/pull/1309 From your comment in the PR:

I think stubbed children should not render their slots.

To reiterate the above example:
We can test that props are properly passed to children using .props().
We can test that attributes are properly passed to children using .attributes().
We can test that the default slot is properly passed to children using .text() or .html().
Without the stubs: { Component } workaround, we cannot test that named slots are passed properly. Whether stubs should render content inside them is really not the point here, it's that there's no other way to test slots otherwise in a unit test. If there was something like childWrapper.templates(), then I'm all for stubbing out the child completely, but until that happens, checking childWrapper.text() or childWrapper.html() remains the only way to verify slots. Using mount is not a solution because, once again, it turns a unit test into an integration test.

Either way, I am way pasting trying to push this issue. Let's move on.

Sure, my original comment was simply to provide a solution that works today. This issue has been reported multiple times and even has a PR for it, so it's definitely important to at least some of us, and we can't wait around for the Vue 3 integration.

It wasn't just a case of "I didn't merge it". Looks like there was some conflict and failing tests here which were not resolved: https://github.com/vuejs/vue-test-utils/pull/1309
I think we need to support both behaviors to make this work for everyone. Some people will expect a true shallow mount, others want stubbed components to render slots.
I am pretty focused on getting v1 of this lib released, vue-jest 4 and 5, and VTU next, but if you want to take a stab at this (or anyone else) feel free to do so. What I'd like to see:

stub all the children as the default
support rendering slots of stubbed children. I don't know what the API should look like, perhaps

import { config } from '@vue/test-utils'

config.shallowMount = {
  renderSlots: true
}

Or perhaps a test-by-test config. Either way, the API won't impact the implementation. Does this sound appropriate? I think this will let everyone write their tests however they like.

What is the final solution for this? I can't find those configurations on shallowMount

Try using mount - shallowMount has (always) been pretty buggy and error prone. If you have a specific component that is problematic, you could use stubs to get around it.

Here's my solution for named slots content:
https://stackblitz.com/edit/vitejs-vite-w7qqun?file=tests%2FHelloWorld.test.ts
I took my inspiration from the stubComponentsTransformer.ts file:
https://github.com/vuejs/test-utils/blob/d7e3c2fb9b89592ae0db8f4806d332c8cea6c78e/src/vnodeTransformers/stubComponentsTransformer.ts#L91
I used config.plugins.createStubs to override the default and resolve all stubbed component slots.
vitest.setup.ts
import { createStub } from './tests/utils/stub';
import { config } from '@vue/test-utils';
import { defineComponent } from 'vue';

config.global.renderStubDefaultSlot = true;

config.plugins.createStubs = ({ name, component }) => {
  return defineComponent({
    ...createStub(name, component),
  });
};

stub.ts (I had to copy some functions from stubComponentsTransformer.ts because they are not exposed)
import type {
  ComponentObjectPropsOptions,
  ComponentOptions,
  ComponentPropsOptions,
  ConcreteComponent,
  VNodeTypes,
} from 'vue';
import { h } from 'vue';

/**
 * @see https://github.com/vuejs/test-utils/blob/d7e3c2fb9b89592ae0db8f4806d332c8cea6c78e/src/utils/vueShared.ts#L1
 */
const cacheStringFunction = <T extends (str: string) => string>(fn: T): T => {
  const cache: Record<string, string> = Object.create(null);
  return ((str: string) => {
    const hit = cache[str];
    return hit || (cache[str] = fn(str));
  }) as any;
};

/**
 * @see https://github.com/vuejs/test-utils/blob/d7e3c2fb9b89592ae0db8f4806d332c8cea6c78e/src/utils/vueShared.ts#L18
 */
const hyphenateRE = /\B([A-Z])/g;
const hyphenate = cacheStringFunction((str: string): string => {
  return str.replace(hyphenateRE, '-$1').toLowerCase();
});

/**
 * https://github.com/vuejs/test-utils/blob/d7e3c2fb9b89592ae0db8f4806d332c8cea6c78e/src/utils.ts#L131
 */
const isComponent = (component: unknown): component is ConcreteComponent =>
  Boolean(
    component &&
      (typeof component === 'object' || typeof component === 'function')
  );

/**
 * @see https://github.com/vuejs/test-utils/blob/d7e3c2fb9b89592ae0db8f4806d332c8cea6c78e/src/vnodeTransformers/stubComponentsTransformer.ts#L45
 */
const normalizeStubProps = (props: ComponentPropsOptions) => {
  // props are always normalized to object syntax
  const $props = props as unknown as ComponentObjectPropsOptions;
  // eslint-disable-next-line unicorn/no-array-reduce
  return Object.keys($props).reduce((acc, key) => {
    if (typeof $props[key] === 'symbol') {
      return { ...acc, [key]: [$props[key]?.toString()] };
    }
    if (typeof $props[key] === 'function') {
      return { ...acc, [key]: ['[Function]'] };
    }
    return { ...acc, [key]: $props[key] };
  }, {});
};

type SlotProps = Record<string, Record<string, unknown>>;

export const createStub = (
  name: string,
  component: VNodeTypes,
  slotProps: SlotProps = {}
) => {
  const anonName = 'anonymous-stub';
  const tag = name ? `${hyphenate(name)}-stub` : anonName;

  const props = isComponent(component)
    ? (component as ConcreteComponent).props
    : {};

  return {
    name: name || anonName,
    props,
    setup(props, { slots }) {
      return () => {
        const stubProps = normalizeStubProps(props);
        const resolvedSlots = slots
          ? Object.keys(slots).map((k) => {
              const slot = slots[k];
              if (slot) {
                return slot(slotProps[k] ?? {});
              }
            })
          : [];
        return h(tag, stubProps, resolvedSlots);
      };
    },
  } satisfies ComponentOptions;
};

We can then use shallowMount and override some component stubs to specify slot props.
const wrapper = shallowMount(HelloWorld, {
      props: {
        msg: 'the message',
      },
      global: {
        stubs: {
          Parent: createStub('Parent', Parent, {
            child: { message: 'Slot message' },
          }),
        },
      },
    });


TAJO-1407 Minor performance improvement of MemSortExec

Simple micro benchmark shows 15~30% performance improvement, but this uses more memory. (Also can make little difference on appearance order of non-key values, caused by different sort implementation)

Removed JDK7 only method

Looks interesting.
I'll review tonight.

Added comments and now it supports interval type.

I'll review this weekend.

@navis, this is truly impressive work.
With my laptop, the vectorized sorter is faster than Collections.sort() about 25%!
I left some trivial comments.
In addition, it will be great if you add some tests to verify sort result.

Revised test case, which can be fail sometimes

I run the test 5 times, and it passed every time.
Would you share when the test fails?

2M rows sometimes made GCs, causing inversion of elapsed time.

Oh, I think it's ok. The revised test doesn't contain any comparisons of elapsed times.
In addition, MemSortExec is executed only when there remains a sufficient amount of memory.
Here is my +1, and I'll commit it shortly.
Thanks for your great work!

Oops, sorry. I have to wait the CI result.
Would you put the latest patch on Jira?
I'd like to commit this patch as soon as possible, and Jenkins will be much faster than Travis CI.


Can't paste code from the clipboard (windows)

Version: 0.1 (Build 2020-08-02 1:38)
Windows 10
Firefox 79.0
Description of the problem:
Can't paste code using the online tool
Steps to reproduce:
Try copy paste some gdscript code and paste it
It'll not paste the code
Code:
N/A

Source Code

Output

Expected Output
N/A

Warnings
N/A

That is a bug in the HTML Export and Firefox. You can workaround clicking Edit->Paste and then press Ctrl+V

See https://github.com/godotengine/godot/issues/12587

I hope to include a working paste button eventually, to workaround this bug

So an automatic workaround is not possible. This can only be fixed if Firefox one day supports the Clipboard API for more than extensions


hyper 0.10.14 fails tests

I got the following test results on hyper 0.10.14 (using rust 1.29.2):
failures:

---- server::tests::test_check_continue_reject stdout ----
thread 'server::tests::test_check_continue_reject' panicked at 'assertion failed: `(left == right)`
  left: `[]`,
 right: `[72, 84, 84, 80, 47, 49, 46, 49, 32, 52, 49, 55, 32, 69, 120, 112, 101, 99, 116, 97, 116, 105, 111, 110, 32, 70, 97, 105, 108, 101, 100, 13, 10, 13, 10]`', src/server/mod.rs:494:9

---- server::tests::test_check_continue_default stdout ----
thread 'server::tests::test_check_continue_default' panicked at 'index 25 out of range for slice of length 0', libcore/slice/mod.rs:1932:5

failures:
    server::tests::test_check_continue_default
    server::tests::test_check_continue_reject

test result: FAILED. 274 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out

One note is that I patched out the test deny(warnings), otherwise you don't even get this far due to deprecated AsciiExt.  Your Travis build also failed on these deprecations on stable+beta+nightly.
https://travis-ci.org/hyperium/hyper/builds/445836611
(The 1.17 build failed on a pub(crate) in unicode-normalization.)

Thanks for noticing! Seems the test was fragile, but I've gotten it back to the passing behavior. I'll also disable the warnings and minimum version in CI, since 0.10.x is no longer actively maintained.

Looks good -- thanks for the quick fix!


app.wireflow.com not working on Firefox

Running on Mint 19.3, Firefox 77.0.1 (64-bit).
When trying to use https://app.wireflow.co/, one cannot drag any items from the left to the main canvas. On the same setup, works fine on Chrome, can drag items with no issues.
Short video (6 sec) - https://streamable.com/qcm0ey

This is a bit weird. But I can make it work with the right mouse button! Not sure what is going on (not expected), but on Chrome it works as expected with left button.

You are right, its buggy and DnD doesn't work from FF. Thanks for reporting, we will take care of it on next release 👍


Add 2019 compatible version to Market Place

Hello,
thanks for creating the extension.
From the latest commit, it seems that it should be compatible with 2019.
For a variety of possible reasons, I cannot seem to be able to compile the source in VS 2019 Community.
Could you update the version in the Marketplace to the one with 2019 compatibility.

Hello, there are a few issues with disabling the lightbulb margin as it disables the "quick actions" feature completely.
I am trying to see if the margin can be disabled while keeping the "quick actions" feature.
Till then it is not recommended to use this extension.
I have anyway published the new version to the marketplace. Feel free to use it if you are ok with the issues.


Release Pip Package: Numpy v2 Support

Hi Team,
We're significant users of AWS and depend on aws-sdk-pandas for our research. Currently, the library does not support Numpy v2 which is blocking the upgrade of our environments.
The PR with the code upgrade has already been merged into main. Can we please have a new pip package release that includes the update, thanks?
Many thanks,
Adam
PR & Issue
https://github.com/aws/aws-sdk-pandas/pull/2944
https://github.com/aws/aws-sdk-pandas/issues/2943
cc: @LeonLuttenberger, @jaidisido, @kukushking

Hi, thanks for opening this - prepping a release with https://github.com/aws/aws-sdk-pandas/pull/2992

Hello :)  Is there a schedule for when this release is dropping?

Now released, thank you


Request to merge added features

I would like to merge the features I added into the main repository

Thanks for adding these! I'll be on vacation for the next week, so I'll take a look at this as soon as I'm back!


move make section into separate file

the episode is a bit too long and confusing with both make and snakemake.
But the make section might be interesting to some participants, and can be an alternative in case someone's snakemake installation has failed, so it's kept in a separate file

I think this is a good compromise!  I like make as a simple first example, but this is a bit to complex to be worth saying.
What about if we say there are 5 steps, but the make one is not practical so is in a separate page and not recommended to be used?  Or maybe that's too much?

no that's also a way of simplifying it. I'll merge this and then modify in follow-up PR such that make is alternative 4 but only represented by a link


myjenkins: Some installed plugins have security issues

Check on ${JENKINS_URL}/manage

Update - from http://build-gmhome.solarma.it:9080/manage

From https://wiki.jenkins-ci.org/display/JENKINS/Scriptler+Plugin

Older versions of this plugin may not be safe to use.
Please review the following warnings before using an older version:

Persistent cross-site scripting vulnerability
Any user can add Scriptler scripts to build configurations
Any Scriptler script can be executed as part of builds
Cross-site request forgery vulnerabilities in Scriptler script management
Arbitrary code execution vulnerability in rare circumstances

From https://wiki.jenkins-ci.org/display/JENKINS/Build+Flow+Plugin

Deprecated: Users should migrate to https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Plugin

Fix via PR #195


Add smooth_triple

@FHoltorf

Codecov Report
Patch coverage: 66.66% and project coverage change: +0.30 :tada:

Comparison is base (1c4395b) 90.33% compared to head (69d98f2) 90.64%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   90.33%   90.64%   +0.30%
==========================================
  Files          12       13       +1
  Lines         621      652      +31
==========================================
+ Hits          561      591      +30
- Misses         60       61       +1

Impacted Files
Coverage Δ

src/StochasticAD.jl
100.00% <ø> (ø)

src/stochastic_triple.jl
73.68% <66.66%> (-0.29%)
:arrow_down:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Does this library support reflecting Enum class member to string?

Does this library support reflecting Enum class member to string?
For example, I have a enum class Foo
enum class Foo {
  kBar,
  kBaz,
};

And I want to convert to string
"kBar", "kBaz"

No, enum to string is not supported by RareCpp, at least in the short term I've decided I can't do this better than existing libraries (full-support for typical enum reflection activities is a very non-trivial problem) depending on your needs I recommend one of:

magic_enum - https://github.com/Neargye/magic_enum (no boilerplate required if your enums aren't using the same values twice and the values are between -128 and 128 or are only bit-flag values)
wise_enum - https://github.com/quicknir/wise_enum (a macro-based approach to enum reflection with few restrictions)
a manual approach, e.g. https://godbolt.org/z/T7aT9eKMT

I am currently working on a side project in ORM (Object-Relational Mapping). One of my requirements is to be able to map database enum types to C++ enum types, and vice versa.
Thanks a lot for the suggestion of using the magic_enum library. I will take a look at it and see if it fits my needs.


Serverless Test returns non-zero code

Any plans of implementing "test" :)

Coming soon ...

Hehe - there is some test functionality, just not the ability for it to run a specific test outside of running all of the specified tests. Documentation is a little bit lacking, but you can see in the readme there is a tests key, if you specify test files to run it should run them when you run serverless test

Cool, will give it a try


add Hydra Attention

Motivation
Add Hydra Attention.
Modification
1.Add Hydra Attention. Now you can choose to use Hydra Attention or Standard Attention in ViT. (Modif "easycv/models/backbones/vision_transformer.py" and "easycv/models/backbones/vit_transformer_dynamic.py")
2.Add unittest for Hydra Attention. (Add "tests/models/backbones/test_hydraAttention.py")
3.Add config file. (Add "configs/classification/imagenet/vit/imagenet_deit_base_hydra_layer12_patch16_224_jpg.py" and "configs/classification/imagenet/vit/imagenet_deit_base_hydra_layer8_patch16_224_jpg.py")
Accuracy
DeiT-B（Hydra Attention [12 layers]）：
Official: 76.40
Ours: 76.67
DeiT-B（Hydra Attention [8 layers]）：
Official: 79.45
Ours: 79.444
(For details, see "https://www.yuque.com/u22483603/cgzswd/kcmw4k")

LGTM


FancyZones stops working between reboots.

Microsoft PowerToys version
0.49.1
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
Reboot the computer.
✔ Expected Behavior
FancyZones keeps working between reboots.
❌ Actual Behavior
FancyZones has to be turn off and on again to regain the funcionality.
Other Software
No response

Duplicate of #13214

Thanks for reporting this. This issue is a duplicate.
I'm linking this issue to #13214 to centralize the discussion thread for tracking.
Thanks for your help to make PowerToys a better piece of software!


Simple search mods

Tweaked this a bit more and now feel like it's given me enough ideas to move on to the next step.

Nice, thanks!


Is the "Singleton" Cookie Container Causing Problems?

Report from a user:

I'm observing some strange behavior where after a certain amount of time has elapsed, requests to iRacing begin to fail. I'm probably not handling the response erroring in an ideal way, but I was expecting the library to recognize a 401 and to request a new token using the credentials configured and retry (which should be successful). Do you have any ideas why I might be seeing this?

Aydsko.iRacingData.Exceptions.iRacingUnauthorizedResponseException:
   at Aydsko.iRacingData.DataClient.HandleUnsuccessfulResponse (Aydsko.iRacingData, Version=24<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null: /_/src/Aydsko.iRacingData/DataClient.cs:2145)

Is this singleton related in some way? Is there a better way to handle this cookie storage?
https://github.com/AdrianJSClark/aydsko-iracingdata/blob/a1187fa49796efb6fddf9b8831c520db10b4f5be/src/Aydsko.iRacingData/ServicesExtensions.cs#L113C1-L113C57

I have an extension method that resets my cookie container whenever I receive an iRacingUnauthorizedResponseException, could that be integrated into the library directly?
        public static async Task<T> UnwrapAsync<T>(this Task<DataResponse<T>> responseTask)
        {
            try
            {
                var response = await responseTask;
                return response.Data;
            }
            catch (iRacingUnauthorizedResponseException)
            {
                ResetCookies();
                throw;
            }
        }

I might need something like that.

Idea: Move the "Is logged in" check inside the "Create response" method. Catch the unauthorised exception the first time and retry. If that doesn't work, the exception can be raised.

I have an extension method that resets my cookie container whenever I receive an iRacingUnauthorizedResponseException, could that be integrated into the library directly?

        public static async Task<T> UnwrapAsync<T>(this Task<DataResponse<T>> responseTask)

        {

            try

            {

                var response = await responseTask;

                return response.Data;

            }

            catch (iRacingUnauthorizedResponseException)

            {

                ResetCookies();

                throw;

            }

        }

Thanks for the code too. Much appreciated. 👍

Note that extension method doesn't respect the rate limit, I use it only in specific scenarios where I know I'm not going to hit the rate limit.  Most of my stuff is hosted in an Azure Function where you're charged for how long the codes run for, so when it fails I want it to fail fast and not sit in a retry loop.
I have a different extension method when I'm pulling in larger amounts of data which does respect the rate limit and supports parallelism.
        public static DateTimeOffset? NextReset { get; set; }
        public static async Task<T> AutoRetryAsync<T>(this IDataClient client, int parallelism, Expression<Func<IDataClient, Task<DataResponse<T>>>> expression)
        {
            int tries = 0;

            while (true)
            {
                try
                {
                    var result = await expression.Compile().Invoke(client);

                    NextReset = result.RateLimitReset;

                    if (result.RateLimitRemaining < parallelism)
                    {
                        TimeSpan timeToWait = NextReset.GetValueOrDefault(DateTimeOffset.UtcNow) - DateTimeOffset.UtcNow;
                        if (timeToWait > TimeSpan.Zero)
                        {
                            await Task.Delay(timeToWait.Add(TimeSpan.FromSeconds(1)));
                        }
                    }
                    return result.Data;
                }
                catch (iRacingRateLimitExceededException)
                {
                    TimeSpan timeToWait = NextReset.GetValueOrDefault(DateTimeOffset.UtcNow) - DateTimeOffset.UtcNow;
                    if (timeToWait > TimeSpan.Zero)
                    {
                        await Task.Delay(timeToWait.Add(TimeSpan.FromSeconds(1)));
                    }
                }
                catch (iRacingUnauthorizedResponseException)
                {
                    ResetCookies();

                    tries++;
                    if (tries > 5)
                    {
                        throw;
                    }
                    await Task.Delay(5000);
                }
                catch
                {
                    tries++;

                    if (tries > 5)
                    {
                        throw;
                    }
                    await Task.Delay(5000);
                }
            }
        }

I've published a pre-release which includes a retry for unauthorized requests. Hoping to make it a final release soon.
That is release 2404.5.0-beta available on NuGet here: https://www.nuget.org/packages/Aydsko.iRacingData/2404.5.0-beta

There's now a full release with the ability to retry calls. That is version 2404.5.0 found here: https://www.nuget.org/packages/Aydsko.iRacingData/2404.5.0
As such, I'm closing this issue.


Update term copy label behavior changes in documentation

Docs Build status updates of commit 9625c4b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 136: [Error] Restore nuget package W:\fdoj-s\.optemp\dependentPackages\Microsoft.OpenPublishing.CommonPlugins\packages.config in folder:W:\fdoj-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in https://SiteHelp and include the build report and the following error message for our team to troubleshoot: Errors in packages.config projects     Unable to find version '1.0.224' of package 'Microsoft.OpenPublishing.CommonPlugins'.       C:\Users\ContainerAdministrator\.nuget\packages\: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.224' is not found on source 'C:\Users\ContainerAdministrator\.nuget\packages\'.       https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.224' is not found on source 'https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2'.
Line 136: [Error] Restore nuget package W:\fdoj-s\.optemp\dependentPackages\Microsoft.DocAsCode.ECMA2Yaml\packages.config in folder:W:\fdoj-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in https://SiteHelp and include the build report and the following error message for our team to troubleshoot: Errors in packages.config projects     Unable to find version '1.0.808' of package 'Microsoft.DocAsCode.ECMA2Yaml'.       C:\Users\ContainerAdministrator\.nuget\packages\: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.808' is not found on source 'C:\Users\ContainerAdministrator\.nuget\packages\'.       https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.808' is not found on source 'https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 613cabf:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 136: [Error] Restore nuget package W:\g2w4-s\.optemp\dependentPackages\Microsoft.OpenPublishing.CommonPlugins\packages.config in folder:W:\g2w4-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in https://SiteHelp and include the build report and the following error message for our team to troubleshoot: Errors in packages.config projects     Unable to find version '1.0.224' of package 'Microsoft.OpenPublishing.CommonPlugins'.       C:\Users\ContainerAdministrator\.nuget\packages\: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.224' is not found on source 'C:\Users\ContainerAdministrator\.nuget\packages\'.       https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.224' is not found on source 'https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2'.
Line 136: [Error] Restore nuget package W:\g2w4-s\.optemp\dependentPackages\Microsoft.DocAsCode.ECMA2Yaml\packages.config in folder:W:\g2w4-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in https://SiteHelp and include the build report and the following error message for our team to troubleshoot: Errors in packages.config projects     Unable to find version '1.0.808' of package 'Microsoft.DocAsCode.ECMA2Yaml'.       C:\Users\ContainerAdministrator\.nuget\packages\: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.808' is not found on source 'C:\Users\ContainerAdministrator\.nuget\packages\'.       https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.808' is not found on source 'https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 3ba029d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

sharepoint-server/xml/Microsoft.SharePoint.Taxonomy/Term.xml
:warning:Warning

Details

sharepoint-server/xml/Microsoft.SharePoint.Taxonomy/Term.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Taxoomy.Term'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoiint.Taxonomy.Term'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.TermStore'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Term'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Taxonomy.TaxonomySession.KeywordTermSet'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Term'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Taxonomy.TermSetItem.CreateTerm'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Taxonomy.TermStore.GetTerm'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Sharepoint.Taxonomy.TermSet'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Taxonomy.Term.Move(TermSet)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.TaxonomyTerm.Move(T:Microsoft.SharePoint.Taxonomy.Term)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Taxonomy.Term.Merge'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


BLE session disconnected with toio on playmat

Hi kawasaki-san
I found the issue with playing toio.
I put io on playmat to use absolutely position.
BLE session disconnected was occurred.
I attached log file scratch_link with -d option.
log.txt
disconnect may be occurred around line 83705.

@shimodash Hi, thank you very much for sharing the log. And sorry about my slow response. Let me have some time to look into the log and think about it. Yes, the line around 83705 is suspicious. The handle number 13 is the unlucky number :)

I took a look in the log.  Around the line 83705, we can see:
'''
2021-06-05 13:17:07,800 BLE notification: 13 b'\x01X\x011\x01_\x01O\x01,\x01_\x01'
2021-06-05 13:17:07,800 13
'''
These logs indicate that the pyscrlink received notification with handle "13". The first byte of the notification is 1. According to (coreCube.ts)
[https://github.com/toio/toio-visual-programming/blob/master/src/toio/coreCube.ts] of toio-visual-programming, the onNotified method shows that the message with value 1 contains x and y position and direction associated with "Mat". I guess this is the position and direction that toio detected and sent to Scratch.
The weird thing is that the handle 13 is not added to the handle list. At line 43157 and 64070, the log records,
'''
add handle for notification: 39
'''
Then, the handle 39 was registered twice. But there is no log for handle 13.

Hi @shimodash
For further debugging, I created two commits in the dev branch. If you have time to afford, could you try it? The first commit enriches debug and error message. The second commit is to override the unknown handle 13 with the known handle 39. I'm not sure if this dirty hack works or not, but would like to know what will happen.


Create Human/Bot interaction tools

This is defining what will be used to parse commands (message from human
to robot) and notifications (message from robot to human).

This change is

mungegithub/mungers/matchers/comment/interactions.go, line 78 [r1] (raw file):

}

func HumanActor() Matcher {

This is slightly broken. Not sure what we should do ....
What if the author is not set properly on the pull-request (because pr.Author is nil)? Should it be a human or a bot? or something else ..

Comments from Reviewable

mungegithub/mungers/matchers/comment/interactions.go, line 78 [r1] (raw file):
Previously, apelisse (Antoine Pelisse) wrote…
> This is slightly broken. Not sure what we should do ....
>
> What if the author is not set properly on the pull-request (because pr.Author is nil)? Should it be a human or a bot? or something else ..

Should be better now

Comments from Reviewable

@apelisse  I probably won't have time to review this for a week+

Review status: 0 of 7 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

mungegithub/mungers/matchers/comment/command.go, line 35 [r2] (raw file):

var (
	commandRegex = regexp.MustCompile(`^/([^\s]+)\s?(.*)$`)
)

include a short comment explaining the regex. Something like   // Looks for / followed by command followed by option arguments.  Also, can commands include nonalphanumeric chars?  What if someone included a C/C++/Java style comment in the body of the comment //why does this work?

mungegithub/mungers/matchers/comment/command.go, line 51 [r2] (raw file):

	return &Command{
		Name:      strings.ToUpper(match[1]),
		Arguments: strings.TrimSpace(match[2]),

what if match doesn't have 3 elements.  my understanding is FindStringSubmatch returns the regex match followed by the match of the subexpressions if any.  So what if there is no argument ?  Something like "/lgtm"?  Won't matches[2] cause an indexError

Comments from Reviewable

mungegithub/mungers/matchers/comment/command_test.go, line 28 [r2] (raw file):

func TestParseCommand(t *testing.T) {
	tests := []struct {
		command *Command

nit: rename to trueCommand or expectedCommand

Comments from Reviewable

mungegithub/mungers/matchers/comment/command.go, line 56 [r2] (raw file):

func (n *Command) String() string {
	str := fmt.Sprintf("/%s %s", strings.ToUpper(n.Name), strings.TrimSpace(n.Arguments))

why the extra tmp variable :)

Comments from Reviewable

Review status: 0 of 7 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

mungegithub/mungers/matchers/comment/command.go, line 51 [r2] (raw file):
Previously, grodrigues3 wrote…
> what if match doesn't have 3 elements.  my understanding is FindStringSubmatch returns the regex match followed by the match of the subexpressions if any.  So what if there is no argument ?  Something like "/lgtm"?  Won't matches[2] cause an indexError

It should work: https://play.golang.org/p/ODxpr9JdL1

Comments from Reviewable

Reviewed 4 of 7 files at r1, 2 of 2 files at r2.
Review status: 2 of 7 files reviewed at latest revision, 9 unresolved discussions.

mungegithub/mungers/matchers/comment/command_test.go, line 49 [r2] (raw file):

		{
			command: &Command{Name: "COMMAND", Arguments: "Arguments is trimmed"},
			comment: "/COMMAND     Arguments is trimmed   ",

Add a case for no arguments.

mungegithub/mungers/matchers/comment/interactions.go, line 30 [r2] (raw file):

type NotificationName string

// Match returns true if the comment is a notification

Update the comment

mungegithub/mungers/matchers/comment/interactions.go, line 55 [r2] (raw file):

type CommandArguments regexp.Regexp

func (c CommandArguments) Match(comment *github.IssueComment) bool {

Are there tests for this?

mungegithub/mungers/matchers/comment/notification.go, line 35 [r2] (raw file):

var (
	notificationRegex = regexp.MustCompile(`^\[([^\]\s]+)\]\s?(.*)$`)

Leave a comment explaining the actual format for notifications

mungegithub/mungers/matchers/comment/notification_test.go, line 53 [r2] (raw file):

		{
			notif:   &Notification{Name: "NOTIF", Arguments: "Arguments is trimmed"},
			comment: "[notif]     Arguments is trimmed   ",

Add a notification without can args

Comments from Reviewable

Reviewed 6 of 8 files at r3.
Review status: 7 of 9 files reviewed at latest revision, 8 unresolved discussions.

mungegithub/mungers/matchers/comment/pinger.go, line 78 [r3] (raw file):

	// We have pinged too many times, it's time to try something else
	if p.isMaxReached(pings) {
		return nil

How do we know to act upon this since it returns the same value as shouldPingNow?  Do we need a second return value, or something else?

mungegithub/mungers/matchers/comment/pinger.go, line 107 [r3] (raw file):

func (p *Pinger) isMaxReached(pings FilteredComments) bool {
	return p.maxCount != 0 && len(pings) >= p.maxCount

Should this only count pings since the last ACK by the assignee?  WDYT?

mungegithub/mungers/matchers/comment/pinger.go, line 110 [r3] (raw file):

}

func (p *Pinger) shouldPingNow(pings FilteredComments, startDate *time.Time) bool {

This is a good start, but we should probably have something more sophisticated that  only pings issues that don't have activity from the assignee in (time period) and allow contributors to ACK.

Comments from Reviewable

Review status: 7 of 9 files reviewed at latest revision, 8 unresolved discussions.

mungegithub/mungers/matchers/comment/command.go, line 35 [r2] (raw file):
Previously, grodrigues3 wrote…
> include a short comment explaining the regex. Something like   // Looks for / followed by command followed by option arguments.  Also, can commands include nonalphanumeric chars?  What if someone included a C/C++/Java style comment in the body of the comment //why does this work?

Done.

mungegithub/mungers/matchers/comment/command.go, line 51 [r2] (raw file):
Previously, apelisse (Antoine Pelisse) wrote…
> It should work: https://play.golang.org/p/ODxpr9JdL1

Done.

mungegithub/mungers/matchers/comment/command.go, line 56 [r2] (raw file):
Previously, grodrigues3 wrote…
> why the extra tmp variable :)

Done.

mungegithub/mungers/matchers/comment/command_test.go, line 28 [r2] (raw file):
Previously, grodrigues3 wrote…
> nit: rename to trueCommand or expectedCommand

Done.

mungegithub/mungers/matchers/comment/interactions.go, line 55 [r2] (raw file):
Previously, pwittrock (Phillip Wittrock) wrote…
> Are there tests for this?

Done.

mungegithub/mungers/matchers/comment/pinger.go, line 78 [r3] (raw file):
Previously, pwittrock (Phillip Wittrock) wrote…
> How do we know to act upon this since it returns the same value as shouldPingNow?  Do we need a second return value, or something else?

Yeah, that has been my concern since the very beginning. I've decided to let the caller responsible of calling "MaxReached()" (which I made public for that purpose) to take action based on that.

mungegithub/mungers/matchers/comment/pinger.go, line 107 [r3] (raw file):
Previously, pwittrock (Phillip Wittrock) wrote…
> Should this only count pings since the last ACK by the assignee?  WDYT?

We could be fancy and had extra interactions with the pinger. But I think this should be the caller's responsibility (callers are usually going to be states, states know what should happen based on actual interactions. ack can have a very different meaning based on what we're trying to ping for). Also see next comment :-)

mungegithub/mungers/matchers/comment/pinger.go, line 110 [r3] (raw file):
Previously, pwittrock (Phillip Wittrock) wrote…
> This is a good start, but we should probably have something more sophisticated that  only pings issues that don't have activity from the assignee in (time period) and allow contributors to ACK.

Same, caller's responsibility (this is the point of "startDate"). If there are interactions and the pinger should be reset, then it should use the last activity date as startDate.
I'll try to explain one of the main usage of this class.
The close-stale-pr could be massively simplified:
startDate := findLastHumanInteraction()
pinger := NewPinger("CLOSE-STALE").SetMaxCount(3).SetTimePeriod(30*24*time.Hour)

if pinger.MaxReached(comments, startDate) {
    obj.CloseIssue()
} else {
    obj.Post(pinger.PingerNotification(comments, MentionInvolvedUsers(), startDate).String())
}

No loop, a single if (which is the core of the actual logic anyway).

Comments from Reviewable

Review status: 7 of 9 files reviewed at latest revision, 6 unresolved discussions.

mungegithub/mungers/matchers/comment/pinger.go, line 93 [r3] (raw file):

// MaxReached tells you if you've reached the limit yet
func (p *Pinger) MaxReached(comments []*github.IssueComment, startDate *time.Time) bool {

How about calling it IsMaxReached to clarify that it is just checking the condition and not setting it

Comments from Reviewable

Reviewed 2 of 8 files at r3.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

Comments from Reviewable

+lgtm

Reviewed 2 of 2 files at r4.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

Comments from Reviewable

Changed a comment. Relgtm myself ...
/lgtm


Add pull request template

solves #105
Added the pull_request_template.md file
To verify its automatic loading, I forked the project, and everything worked as expected.

Hi @nadamoukaddem , I just have a few small change requests for the template. Thanks!

Forgot to comment your own Pull Request does not follow the template checklist. You didn't assign the appropriate labels. See screenshot.

@nadamoukaddem you still didn't apply the changes I requested above to the template. Until then this PR can't be merged.


seelog and systemd invalid argument error for every log message

When running my service by hand or in windows everything works as expected. When running the service under systemd I get this error before every log message: Seelog error: invalid argument
unit file:
[Unit]
Description=Logrhythm Rift Process that splits zmq pull streams
After=syslog.target network.target remote-fs.target nss-lookup.target network-online.target
Wants=network-online.target

[Service]
Type=simple
User=persistent
TimeoutSec=45s
Restart=always
WorkingDirectory=/usr/local/rift/
ExecStart=/home/vrecan/go/bin/rift

[Install]
WantedBy=multi-user.target

Could you provide the seelog config you are using?

seelog conf:
<seelog type="asynctimer" asyncinterval="1000000">
   <outputs formatid="all">
           <filter levels="info" formatid="fmtinfo" >
              <console/>
              <rollingfile type="size" filename="rift.log" maxsize="20000000" maxrolls="5" />
           </filter>
             <filter levels="warn" formatid="fmtwarn">
              <console/>
              <rollingfile type="size" filename="rift.log" maxsize="20000000" maxrolls="5" />
            </filter>
            <filter levels="error,critical" formatid="fmterror">
              <console/>
              <rollingfile type="size" filename="rift.log" maxsize="20000000" maxrolls="5" />
            </filter>
            <filter levels="debug,trace">
            	<console/>
            	<rollingfile type="size" filename="rift.log" maxsize="20000000" maxrolls="5" />
            </filter>
    </outputs>
    <formats>
        <format id="fmtinfo" format="%EscM(32)[%Level]%EscM(0) [%Date %Time] [%File] %Msg%n"/>
        <format id="fmterror" format="%EscM(31)[%LEVEL]%EscM(0) [%Date %Time] [%FuncShort @ %File.%Line] %Msg%n"/>
         <format id="fmtwarn" format="%EscM(33)[%LEVEL]%EscM(0) [%Date %Time] [%FuncShort @ %File.%Line] %Msg%n"/>
        <format id="all" format="%EscM(2)[%LEVEL]%EscM(0) [%Date %Time] [%FuncShort @ %File.%Line] %Msg%n"/>
    </formats>
</seelog>

Could you please try to reproduce it using only a console outputs and comment out rollingfile-s? I'm trying to figure out whether it may have something with the file access rights.

Yea that seems to be it, it must not have the ability to write to the log file location. Thanks for your help, is there any way we could improve the error here so it's more obvious?

Yeah that's definitely not obvious. I think that it returns ErrInvalid in some OS call, but I'd expect ErrPermission. I'll take a look at it tomorrow.


Html Tag matching underline an colorized

Hello,
How can i configure VS Code for matching html tag like in sublime text 3 ?
I mean, when i select a tag in html file, the open and finish match tag is underline.
Regards

Note that we already highlight the corresponding end tag in HTML (but not in PHP, that's #2915)

Can you confirm whether you are in HTML or PHP? If in HTML, can you attach a sample that shows the problem?