snapshot recovery fails when one of eventfd's listeners is in accept state

I took a snapshot of go server provided by knative examples. snapshot created fails to start with error
[h1@kubernetes km]$ ./build/km/km ../snap/kmsnap
18:47:10.204619 km_ss_recover_km_mon 401  km      label: /server 1 /tmp/kmmgmt.pipe-1
18:47:10.204755 km_ss_recover_km_mon 404  km      description: snapshot date Thu Aug 18 18:38:07 2022

18:47:10.208519 km_fs_recover_eventf 2966 km      monitored fd=5 does not exist
18:47:10.208529 km_fs_recover        2995 km      recover open files failed
[h1@kubernetes km]$

Further debugging the snapshot recover with lots of help from @paul we found that when socket is in
  if (nt_sock->how == KM_FILE_HOW_ACCEPT) {       return km_fs_recover_socket_accepted(nt_sock);    }
static int km_fs_recover_socket_accepted(km_nt_socket_t* nt_sock) {    return 0; }
In memory filesys entry is not being made and this is causing eventfd creation to bail out.

fd state of process being snapshoted
lrwx------    1 root     root            64 Aug 18 18:35 0 -> /dev/null l-wx------    1 root     root            64 Aug 18 18:35 1 -> pipe:[110166] l-wx------    1 root     root            64 Aug 18 18:35 2 -> pipe:[110167] lrwx------    1 root     root            64 Aug 18 18:35 3 -> socket:[109236] lrwx------    1 root     root            64 Aug 18 18:35 5 -> socket:[109260] lrwx------    1 root     root            64 Aug 18 18:35 6 -> anon_inode:[eventpoll] lrwx------    1 root     root            64 Aug 18 18:38 729 -> socket:[114797] l-wx------    1 root     root            64 Aug 18 23:05 731 -> /tmp/km_1.log lrwx------    1 root     root            64 Aug 18 23:05 732 -> anon_inode:[eventfd] lrwx------    1 root     root            64 Aug 18 23:05 733 -> anon_inode:[eventfd] lrwx------    1 root     root            64 Aug 18 23:05 734 -> /dev/kvm lrwx------    1 root     root            64 Aug 18 23:05 735 -> anon_inode:kvm-vm lrwx------    1 root     root            64 Aug 18 23:05 736 -> anon_inode:kvm-vcpu:0 lrwx------    1 root     root            64 Aug 18 23:05 737 -> anon_inode:kvm-vcpu:1 lrwx------    1 root     root            64 Aug 18 23:05 738 -> anon_inode:kvm-vcpu:2 lrwx------    1 root     root            64 Aug 18 23:05 739 -> anon_inode:kvm-vcpu:3 lrwx------    1 root     root            64 Aug 18 23:05 740 -> anon_inode:kvm-vcpu:4 lrwx------    1 root     root            64 Aug 19 01:59 741 -> anon_inode:kvm-vcpu:5 lrwx------    1 root     root            64 Aug 19 01:59 742 -> anon_inode:kvm-vcpu:6 lrwx------    1 root     root            64 Aug 19 16:22 743 -> anon_inode:kvm-vcpu:7 lrwx------    1 root     root            64 Aug 19 16:22 744 -> anon_inode:kvm-vcpu:8
`(gdb) p/x *$14
$17 = {nfdmap = 0x2d7, guest_files = 0x7ffff8000920}
(gdb) p/x $17->guest_files[3]
$18 = {inuse = 0x1, how = 0x4, flags = 0x0, error = 0x0, ops = 0x0, ofd = 0xffffffff, name = 0x7ffff801bd60, sockinfo = 0x7ffff8014c30, events = {tqh_first = 0x0,
tqh_last = 0x7ffff8000a10}}
(gdb) p/x $17->guest_files[5]
$19 = {inuse = 0x0, how = 0x0, flags = 0x0, error = 0x0, ops = 0x0, ofd = 0x0, name = 0x0, sockinfo = 0x0, events = {tqh_first = 0x0, tqh_last = 0x0}}
(gdb) b 2963
Breakpoint 2 at 0x7ffff7e8d9f2: file km/km_filesys.c, line 2963.
(gdb) c
Continuing.
Breakpoint 2, km_fs_recover_eventfd (ptr=0x7ffff80222a0 "\024", length=) at km/km_filesys.c:2964
2964	      int host_efd = km_fs_g2h_fd(nt_event->fd, NULL);
(gdb) p/x *nt_event
$20 = {fd = 0x5, event = 0x80002005, data = 0x7ffe235e38}
(gdb) p/x $17->guest_files[5]
$21 = {inuse = 0x0, how = 0x0, flags = 0x0, error = 0x0, ops = 0x0, ofd = 0x0, name = 0x0, sockinfo = 0x0, events = {tqh_first = 0x0, tqh_last = 0x0}}
`

In function km_fs_recover_open_socket(), this block of code needs to be removed:
   if (nt_sock->how == KM_FILE_HOW_ACCEPT) {
      return km_fs_recover_socket_accepted(nt_sock);
   }

I think the above change will allow an accepted socket to be recovered in such a way that the first recv or send operation will return ECONNRESET which will cause the payload to abandon the connection and resume listening for a new connection.

The bats snapshot_test.c needs to test listening and connected sockets to be sure they are recovered properly too.

guest is a client and we are expecting the server to keep the session alive?
On Tue, Oct 25, 2022 at 3:24 PM paulpopelka @.***>
wrote:

The bats snapshot_test.c needs to test listening and connected sockets to
be sure they are recovered properly too.
—
Reply to this email directly, view it on GitHub
https://github.com/kontainapp/km/issues/1661#issuecomment-1291205715,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANVVZGELTLXQPGT5KKITVN3WFBMYNANCNFSM57BUJ2AA
.
You are receiving this because you authored the thread.Message ID:
@.***>

guest is a client and we are expecting the server to keep the session alive?

The connection will be lost when the snapshot is recovered.
When I/O is attempted on the fd for the lost connection km will cause ECONNRESET to be returned to the payload.
We assume the payload will be able to handle this by cleaning up whatever it was trying to do on the connection and then reconnect to retry whatever it was doing.


Web - Expense - Submit button on confirmation page has extra bottom margin

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.67-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to workspace chat.
Go to + > Submit expense > Next.
Enter amount > Next.

Expected Result:
Submit button will not have extra bottom margin (production behavior).
Actual Result:
Submit button has extra bottom margin.
Workaround:
Unknown
Platforms:

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/44ad6d0f-df5d-44bc-bdb1-fb3c1d32e5e5

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @kirillzyusko

cc @kirillzyusko

I think the margin was added to make sure the button is correctly added on android native so we need to make sure it looks fine there too

Also noting that this does not have to be a blocker, but lets look into trying to fix this while not breaking the native android
I think we should assign @kirillzyusko to look into this as the PR author

Also noting that this does not have to be a blocker, but lets look into trying to fix this while not breaking the native android
I think we should assign @kirillzyusko to look into this as the PR author

I agree with both points.
But can't assign to him just cause he hasn't commented on this issue yet. Hopefully he sees it soon.

Hey, feel free to assign me 👋

Done 🙂

We should remove styles.mb6 in this style

On iOS in this case the button will be very close to the bottom of safe area.

Or we can revert to use safeAreaPaddingBottomStyle from ScreenWrapper

On Android with 3 button navigation bar the button will be moved to high from nav bar.
So both proposals will introduce issues on different platforms.

@kirillzyusko could you confirm whether these two deploy blockers (related to the way buttons appear in Android) are also related to this issue?

https://github.com/Expensify/App/issues/53190
https://github.com/Expensify/App/issues/53181

@MariaHCD yes, I think so. Probably all these issues are coming from the fact that edge-to-edge mode has been enabled and because of that some screens may have an incorrect padding or the wrong distance between button and keyboard.

Can we assign @chrispader on this?
He is working on this ticket at the moment

commenting for assignment!

fixed

$250 to @allroundexperts for their review
No regression test needed as it was a challenging new feature flag for android and these small styling issues are temporary

@mountiny I reviewed two PRs (https://github.com/Expensify/App/pull/53223 & https://github.com/Expensify/App/pull/53250) here. Can you please update the payment summary? 🙇

Updated

Payment Summary:

@chrispader does not require payment (Contractor)
@kirillzyusko does not require payment (Contractor)
@allroundexperts paid $500 via NewDot Manual Request


Fix remote services in rest_of_world

Proposed change

Merge Fix remote services in rest_of_world (#310)
Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality to this library)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:

Checklist

[ ] The code change is tested and works locally.
[ ] Tests have been added to verify that the new code works.

@gerard33, @pzim-devdata could you both please test against dev if remote services are working fully for you?
@heyepic, @dazole could you guys please test if remote execution in north america works as well? Can't test it by myself, as I don't have any cars in my account there ;)

I was able successfully test status, light flash, fingerprint vehicle finder and send message. "vehicle finder" only returned "success", though, and not any kind of lat/lon or anything else.  I'm not sure if that's expected or not.
I don't use HA, though, so I wasn't able to test door lock or ventilation.

I was able successfully test status, light flash, fingerprint vehicle finder and send message. "vehicle finder" only returned "success", though, and not any kind of lat/lon or anything else. I'm not sure if that's expected or not.

Thanks, that's great to hear! vehicle_finder doesn't give a result, but the timestamp in status will be updated.

After upgrading to 7.19, it works perfectly. Thank you ! ;-)


Add CloseAllJobs soapcall as found in the RCCService wsdl.

This would allow users to close all their jobs immediately instead of writing a foreach on closeJob() to close all their respective instances.

Thanks EggMaster


Optimising MbedTLS for size and incorrect KCONFIG explanations (IDFGH-13186)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
Moving from IDF 5.0 to Master we have run into problems that our application does not fit into a 1MB partition anymore.
In the process we tried to optimise the MbedTLS config to only support a minimal subset of cipher suites and using the suites supported by the hosts we need to access we found that the following 2 protocols are common:
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
We are using HTTPS only for a client connection to upload coredump info (very irregular) as well as to do IP geolocation to determine timezone and related info (very, very irregularly).
Whilst going through all the options for MbedTLS (only v1.2 required) in SDKCONFIG we found the same information/description for 4 different options being:

Questions we have are:
a) Can we assume option descriptions (1st line of each one) is correct and text in additional info (2nd line) is incorrect?
b) If not, can we please have more info so as to be able to ensure working config?
c) Since the HTTPS client is used very seldom speed is not a major concern for us. Most important is a) to minimise code size and b) stack and/or heap usage. Any suggestions for the optimal config to meet the requirement for the 2 specific cipher suites, TLS1.2 only, client only?
All help appreciated.

@ammaree

Can we assume option descriptions (1st line of each one) is correct and text in additional info (2nd line) is incorrect?

Yes. I have raised internal fix to correct the additional info text.
For size optimization to mbedTLS library, please refer to this guide.
For reducing the heap usage, you may consider enabling dynamic buffer feature (supported with only TLS 1.2) as per this guide.

For reducing the heap usage, you may consider enabling dynamic buffer feature (supported with only TLS 1.2) as per this guide.

Hi @mahavirj
Currently MBEDTLS_DYNAMIC_BUFFER feature is not supported with TLS 1.3 yet.
Do you have plan to support enabling dynamic buffer feature with TLS1.3?
The thing is diabling MBEDTLS_DYNAMIC_BUFFER takes too much memory (about 20K) for ESP32.
So due to the limited memory size on esp32,  it's almost not possible to support TLS1.3 for existing products using esp32.

@AxelLin

Do you have plan to support enabling dynamic buffer feature with TLS1.3?

Previously when we looked at this, it was not straight forward to add support for it in 3.6.x version. Ideally, this optimization should be part of the upstream stack itself, maintenance becomes easier that way. But, we will re-evaluate this feature request and see if we can optimize the memory footprint for TLS1.3 use-case. CC @AdityaHPatwardhan

@AxelLin

Do you have plan to support enabling dynamic buffer feature with TLS1.3?

Previously when we looked at this, it was not straight forward to add support for it in 3.6.x version. Ideally, this optimization should be part of the upstream stack itself, maintenance becomes easier that way. But, we will re-evaluate this feature request and see if we can optimize the memory footprint for TLS1.3 use-case. CC @AdityaHPatwardhan

@mahavirj @AdityaHPatwardhan
Just wondering if you have any update about this?
Also do you consider contribute your changes to upstream?

ESP had tried .. .. https://github.com/Mbed-TLS/mbedtls/pull/3889.  i think we need to push memory topic in mbedtls community. it will be great addition- if you have some time to spare on this @AxelLin

@kayzen9
I'm not a expert in mbedtls, just a normal user.
Above PR was closed because MBEDTLS_SSL_VARIABLE_BUFFER_LENGTH serves the purpose of dynamic buffers which is the main goal of this PR.
The MBEDTLS_SSL_VARIABLE_BUFFER_LENGTH is already available in mbedtls.
So I'm confused if the issue is on espressif side or mbedtls?
BTW, in my test, with MBEDTLS_DYNAMIC_BUFFER=y it use less memory than MBEDTLS_SSL_VARIABLE_BUFFER_LENGTH=y.
But MBEDTLS_SSL_PROTO_TLS1_3 depends on !MBEDTLS_DYNAMIC_BUFFER.

HI @AxelLin
We are tracking the feature request internally and will soon update regarding dynamic buffers with TLS 1.3. No work has been done as of yet.


Add fighting game example

Using various assets from fxgl-samples (or external free to use assets), build a small example of a 2d fighting game example, similar to a simplified version of MK1 with just two fighters.

I have already built this for CI628 just need to remove multiplayer code and add assets to java.

discussed with almas


Set executor timeout in a single place

We currently have executor timeout configured in 2 places. Only one of which get set in config - making places that use the other location always consider every executor as timed out
Reducing this to a single place and making all places use this location

So I think the original intention here was that there would be two separate timeouts- although we shouldn't call them both executorTimeout.

A timeout to determine when we should stop scheduling jobs on an executor (and other related things like considering the executor for the submit check)
A timeout to determine when we should consider an executor as lost and we should cancel all jobs on an executor.

I think we need 2 timeouts because the the first should be relatively short (e.g. 10 mins) while the second should be long (e.g. 1 hour)

That is fair, I'll re-raise with the minimum change (Actually setting scheduling.executorTimeout + possibly renaming)


Fix (MS)Pointer-based touch events for IE11+

This PR contains three commits, each dealing with a sub-problem of the current handling of (MS)Pointer-based touch events:

one test in Events fails as in browsers with pointer events we listen to an additional 4 pointer events

changes in tests/Events.html

IE11 drops the MS prefixes for pointer events: MSPointerDown -> pointerdown, etc. Furthermore the pointerType property of pointer event objects is no longer a numeric constant on the event object (e.g. e.MSPOINTER_TYPE_MOUSE) but now a string (e.g. "touch"). Additionally, not all devices set e.buttons to 0 for pointermove events (Surface 1 with WinRT 8.1 seems to, Lumia WP8.1 not)

changes in lib/OpenLayers/Events.js

handling of multitouch events in the drag handler was a bit wonky, as in the pointer model multiple events are fired rather than a single event. An attempt was being made to polyfill this by adding a touches array to the event, but the very first event didn't have this as there is no way of knowing that this will be part of a multitouch event. This led to e.g. pinch-zooming being a little dicey as some bits of the multitouch were being interpreted differently and the map tended to spring a bit. By tracking the pointerId of the events in the drag handler we can reliably tell whether it is really a single-finger drag or a multitouch gesture.

changes in lib/OpenLayers/Handler/Drag.js

Although these are three separate fixes for three distinct problems, they are all parts of the general problem that pointer event handling (particularly pinch zoom) is unsatisfactory in IE11 on touch devices, hence I've rolled them all into one PR. If preferred I can split into 3 separate PRs.

@ahocevar Thanks for looking at this - of course I meant _TOUCH_MODEL! I've updated the PR, and also taken the opportunity to remove some whitespace noise in the original.

Thanks @ejn for this impressive contribution!


New Release?

You've merged https://github.com/LeCoupa/vueflags/pull/27 support Vue 3. What about sharing this with the public? :-)

Hello Razorness, I guess @Tahul did it.

@LeCoupa  thank you for your response. Do you know where I can find a Vue 3 compaitble release?
When I try to just use your master branch, I get the message that no release was found and forces me to pick one of the old releases.
F.e. I recently cloned your repo and added the build to it. So I can use your current master for my project. :)

I would use flagpack. :)
https://flagpack.xyz/?ref=producthunt

Flagpack does say it's made for Vue2, not Vue3.

razorness would you be able to tell me how to import & use your fork in a vue3/ts project?


Support skipping comments in CSV files

CSV readers often support skipping comments^1 which are typically full-line comments indicated by some prefix character (often # is used). It would be great if arrow-csv would allow parsing of such CSV files.

label_issue.py automatically added labels {'arrow'} from #5759


[Bug] font variant ligatures can interfere with cursor placement on click

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[X] Not reproducible in the monaco editor playground

Monaco Editor Playground Code
No response
Actual Behavior
With font-variant-ligatures: common-ligatures; set on the element (or in my case, higher in the DOM), clicking on the exclamation point here results in the cursor placement seen below:

I was doing this in the context of shadow DOM, and the repro is based on the amd-shadow-dom sample. I wonder if shadow DOM might be related to why I wasn't able to reproduce it in the playground. The issue looks pretty similar to #1618 (also on mac) but I did try calling monaco.editor.remeasureFonts() and it didn't fix the issue.
Overall it's a pretty minor bug and was trivial for me to work around once I'd understood what the cause was, but I wanted to create the issue because I was very mystified and basically had to bisect my entire app to figure it out.
Expected Behavior
Cursor is in correct place
Additional Context
No response

When doing DOM measurements to establish if the configured font family is monospace or not, the editor briefly creates a <div> with thousands of as, ms, etc. and places that as a child of the <body>. The extra font-variant-ligatures: common-ligatures; does not therefore make it to this measurement <div> and the editor ends up believing the font is monospace. In such cases (manipulating the font of the editor through parent CSS rules), the editor needs to be created with disableMonospaceOptimizations: true.


After upgrading my flutter SDK to the latest release am getting an error when running my app.

Hi @austinevick
Could you please try this possible solution
Related to #47452
Thank you

@austinevick
I hope you solved the problem,
closing since long time without a response.
comment please if it's not so and I will reopen the issue
Thank you


i am trying to compile html5 on psych engine 0.5.2h but it leads me to this error

Describe your problem here.
lime test html5
source/WeekData.hx:11: characters 8-19 : You cannot access the sys package while targeting js (for sys.io.File)
source/editors/WeekEditorState.hx:34: characters 8-16 : ... referenced here
source/editors/MasterEditorMenu.hx:119: characters 37-52 : ... referenced here
Are you modding a build from source or with Lua?
Source
What is your build target?
HTML5/Browser
Did you edit anything in this build? If so, mention or summarize your changes.
No

idk may be run this command on da terminal
 haxelib set openfl 3.0.0-beta.3

idk may be run this command on da terminal  haxelib set openfl 3.0.0-beta.3

That installs a OpenFL version from 7 years ago 💀
You cant compile for HTML5 because Psych Engine uses some features only available on native targets.


Configurable HyperLogLog accuracy

Even though current algorithm claims to be "98% right" we've found that error is sometimes even around 4-5%
Idea is to have ability to increase accuracy (at the cost of speed and space) for such cases.
I assume that for proper estimation entire datasource would need to be aggregated with same accuracy setting
Is number of buckets proper candidate for accuracy prameter?

@gianm maybe you have some ideas about this one? :)

@leventov @fjy maybe you? :)

@DaimonPl some thoughts:

The "98% right" thing is meant to refer to average error of HyperLogLog, but certainly the error in any particular case can be greater than that.
Druid's implementation deviates from the standard algorithm (see http://druid.io/blog/2014/02/18/hyperloglog-optimizations-for-real-world-systems.html) in a way that decreases storage space but can increase the error slightly in some cases.
Yes changing the number of buckets is a good way to improve the accuracy. In addition you could undo the storage space optimization.
But watch out since both of the above changes would affect the storage format, meaning you may be incompatible with already-written hyperUnique columns.

We are also observing large errors (7-8%) especially on smaller cardinalities (<40000). This is pretty much in line with the bias observed in the Google paper.
Did you consider any of the improvements mentioned in the Google paper (HyperLogLog++)?

Related: #7160


Wallets on mobile part 1

@keybase/react-hackers this gets wallets working on mobile. its not all the way done but i don't want a huge pr since there's so many other tickets going on at the same time so lets get this going piece by piece


MongoDb-Sink-Connector support for the latest Confluent version 5.0.0

Hi,
I am Trying to use MongoDb-sink-connector with the latest released Confluent Platform version 5.0.0.
As in docs, it supports CP v4.0.0, So I just want to know can I use this with v5 or is there any new version of sink connector is going to release soon?
Thanks,
Aashish Kumar

I see no problem in using the connector with CP 5.0.0 brokers. However we do not have a code update planned at this point in time. You are more than welcome to open a PR, updating the dependencies to CP 5.0.0/Kafka 2.0.0. Starting points:

Update the dependencies in build.gradle
Check that the code is not deprecated, by adding the following block to build.gradle:tasks.withType(JavaCompile) {
    options.compilerArgs << "-Xlint:deprecation"
}

and running ./gradlew classes to see if any deprecation notices are given.
Update the Dockerfile to use the CP 5.0.0 docker image.

Then just open a pull request and I'll review it.


Hash failure is completely hidden

I pointed to a file instead of an archive, and that caused a hash failure, but Pulumi never surfaced the failure to me.
From grepping debug logging:
I0317 20:03:21.201805     860 eventsink.go:59] RegisterResource RPC finished: resource:my-lambda[aws:lambda/function:Function]; err: Error: 2 UNKNOWN: f ailed to compute archive hash: '/opt/infrastructure/src/lambda/main.py' is neither a recognized archive type nor a director y, resp: undefined
Expected behavior
Pulumi should surface the failure.
Current behavior
Pulumi looks like it simply ignores the failure and says everything is fine, but of course the resource is not created. This is very confusing as it looks like Pulumi just isn't running the code.
Steps to reproduce
const lambdaZip = new pulumi.asset.FileArchive(
  `${srcFolder}/lambda/main.py`
);

const myLambda = new aws.lambda.Function(
  "my-lambda,
  {
    code: lambdaZip,
    description: "Lambda",
    role: lambdaRole.arn,
    handler: "main.lambda_handler",
    runtime: "python3.8",
    timeout: 30,
  }
);

Context (Environment)
Trying to create a Lambda from a local Python file, a pattern I am already using in the same codebase without issue on a different Lambda.

Actually this may be a duplicate of https://github.com/pulumi/pulumi/issues/5577.

Closing duplicate of https://github.com/pulumi/pulumi/issues/5577


Upgrade deps to match k8s 1.17 - [merged]

In GitLab by @arcln on Dec 5, 2019, 22:47
Merges fix/deps -> develop

In GitLab by @arcln on Dec 5, 2019, 23:59
unmarked as a Work In Progress

In GitLab by @arcln on Dec 6, 2019, 00:05
merged

In GitLab by @arcln on Dec 6, 2019, 00:05
mentioned in commit ecb96f1b5f24f2c3dd0a8633ff8f4fc96a59aacb


Testla screenplay core package  v0.4.1 is released

Update to v0.4.1 from v0.3.0

This issue is resolved by PR:#42.


co19 shadow-disable_t01 test makes following test time out on ie11 Win8

About half the time, the test that runs after co19/LayoutTests/fast/dom/shadow/shadow-disable_t01 will time out, and the report will say that the test didn't start on the browser.
This is happening on ie11 on Windows 8.
Something this test is doing makes the following test fail, but I can't see immediately what that would be.
Skipping this test on ie11, in tests/co19/co19-dart2js.status.

We will disable all the LayoutTests soon.


[nrf fromtree]dts: nordic: nrf5340: Change nRF5340 IPC backend to icbmsg

Change the default IPC backend of nRF5340 to icbmsg.
Signed-off-by: Dominik Chat<EMAIL_ADDRESS>(cherry picked from commit 70419bdee7ffd4ea7248f2b3f4c1a5a9d5a75c76)

Rebased

handled here https://github.com/nrfconnect/sdk-nrf/pull/17721

Reopening since https://github.com/nrfconnect/sdk-nrf/pull/17721 doesn't handle it anymore.

Adding DNM since the sdk-nrf needs alignments in overlays etc. before this is merged.

Rebased.


Event Grid Readme and Samples issues

Section Link:

Suggestion:
Add hyperlink for pip https://pypi.org/project/pip/

Section Link:

Suggestions:
Add CLI command about to create Event Grid. As shown in the picture below:

Section Link:

Suggestion:
Neither of these two places can jump correctly.
1).Update to send-an-event-grid-event.
2).Update to consume-an-event-grid-event.

Section Link:

Reason 1: AttributeError: 'EventGridEvent' object has no attribute 'time'.
Suggestion 1: Update to `event_time'.
Reason 2: TypeError: 'CloudEvent' object is not subscriptable.
Suggestion 2: Delete this code snippet.

Section Link:

Reason:
TypeError: 'CloudEvent' object is not subscriptable.
Suggestion:
Delete this code snippet.

Section Link:

Suggestion:
Remove CloudEvent, this sample does not use it.

Section Link:

Suggestion:
1).Remove CloudEvent, this sample does not use it.
2).Update to:
from datetime import datetime, timedelta
expiration_date_utc = datetime.utcnow() + timedelta(hours=1)

Section Link:

Reason:
ModuleNotFoundError: No module named 'dateutil'
Suggestion:
Delete the code marked in red and update to:
from datetime import datetime, timedelta
expiration_date_utc = datetime.utcnow() + timedelta(hours=1)

Section link1, link2, link3:

Reason:
1). NameError: name 'service_bus_received_message' is not defined.
2). TypeError: 'EventGridEvent' object is not iterable.
@jongio for notification.

Thanks for reporting!
Fixed here https://github.com/Azure/azure-sdk-for-python/pull/14128


feat: allow component props to be passed from push notification payload

The type of this PR is: Enhancement

This PR resolves FX-3042
Description
Allow component props to be passed from push notification payload.
We’re planning to use a searchCriteriaID attribute, sent in the payload defined in Gravity, to trigger some saved search behavior on the artist screen.
There’s some additional context in this thread: https://artsy.slack.com/archives/C9SATFLUU/p1624539467277200
The original POC was built in this PR. This attempts a couple improvements following that POC:

We won’t send the entire notification payload through - most of which we don’t need
We can be very selective and explicit with the keys in the payload passed down as props

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[ ] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Allow custom attributes from push notifications to be passed through to React Native scenes

Nice one 👏 and thanks for the thoughtful description

LGTM 👍


Disk write failure

SteamCMD refuses to install the actual server. In the logs, it only says that it is a disk write failure. I am using volumes instead of bind mounts, but they are writable and should not cause any issues.

Are you perhaps on a system with SELinux? If yes, this may cause you these problems.
https://www.projectatomic.io/blog/2015/06/using-volumes-with-docker-can-cause-problems-with-selinux/

I now believe that this is due to an issue with Docker; my Docker installation is refusing to use more than a certain amount of storage despite hundreds of gigabytes being available. I'm going to close this issue, as I've posted about the real issue on SuperUser: https://superuser.com/questions/1452145/how-to-fix-opensuse-docker-installation-not-using-all-available-storage


Increment version

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/74849
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.9 -m "<description of version>" 65804f258681635436fdd3bce8ba82a948c958cd
git push origin v0.1.9

@JuliaRegistrator register()

Registration pull request updated: JuliaRegistries/General/74849
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.9 -m "<description of version>" 65804f258681635436fdd3bce8ba82a948c958cd
git push origin v0.1.9

@JuliaRegistrator register()

Registration pull request updated: JuliaRegistries/General/74849
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.9 -m "<description of version>" cbb6029ad1eabf0b94c9068f3df6445c467483fc
git push origin v0.1.9


7 set cookies as default auth

The New APIGw Authorizer requires the identity_source to be: method.request.header.Cookie insted of method.request.header.Authorization because the standar is to enforce HTTPOnly cookies for Serverless applications.

wrong place for PR, sorry


Tried running test of "Step_02" (firebase-get-to-know-flutter codelab) on mobile (emulator / Android) with Android Studio. Much Breakage.

lib/main.dart:127:7: Error: 'App' is already declared in this scope.
class App extends StatelessWidget {
      ^^^
lib/main.dart:26:7: Context: Previous declaration of 'App'.
class App extends StatelessWidget {
      ^^^
lib/app_state.dart:7:8: Error: Error when reading 'lib/firebase_options.dart': The system cannot find the file specified.

import 'firebase_options.dart';
       ^
lib/main.dart:21:41: Error: Couldn't find constructor 'App'.
    builder: ((context, child) => const App()),
                                        ^^^
lib/app_state.dart:19:18: Error: The getter 'DefaultFirebaseOptions' isn't defined for the class 'ApplicationState'.
 - 'ApplicationState' is from 'package:gtk_flutter/app_state.dart' ('lib/app_state.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'DefaultFirebaseOptions'.        options: DefaultFirebaseOptions.currentPlatform);
                 ^^^^^^^^^^^^^^^^^^^^^^
Target kernel_snapshot failed: Exception

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileFlutterBuildDebug'.
> Process 'command 'C:\Users\allur\AppData\Local\flutter\bin\flutter.bat'' finished with non-zero exit value 1

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 6m 36s
Running Gradle task 'assembleDebug'...                            397.5s
Error: Gradle task assembleDebug failed with exit code 1

These are compilation issues in your code. Looking at the code in the codelab for step 2 and the errors you're getting, it indicates that you have made some changes to the code you got which is why you are getting these issues. I run the code for step 2 of the codelab and it worked as expected without any issues.
Kindly check the code you have with what is in the repository to see if they match and then try again.
It appears that you might have gone past step 2 in the codelab, if that is the case, make sure you have already done the necessary setup in step3 and step4 of the codelab before you attempt step 5.
I'll be closing this since this isn't an issue with the codelab.
Thank you


Analytics Issues

Analytics us either under-reporting, or not working properly.  Review analytics code and read Heroku docs on analytics.

Need to figure out how to log user entered keyword searches, how to aggregate search info, how to organize info.
Is there any way to have like the Yoast Analytics add gatracking code to all links?


Improve "Unexpected token <" error thrown when parsing invalid API response

When an API call crashes and a HTML page is returned, then the message Unexpected token < is thrown from the JSON parser. This should be handled gracefully.
So instead of Unexpected token < the error message could be something more user-friendly. E.g:
Unable to parse response from API. Please check that your API is running and correctly configured..

This should have been fixed since some time now. I'm going to close this issue.


Fix custom map marshaling

Fix https://github.com/goccy/go-json/issues/504

Thank you for your great PR !! LGTM 👍


trigger coveralls

Coverage remained the same at 30.039% when pulling 25c29bdaf61a20f365442aafb2f71392fef9f7c9 on make-pr-trigger into f6eb850ee3c154027665c415eccea2d4fe732a9c on test/init.


Develop a GitHub Action to run Tern

Describe the Feature
GitHub supports a wide variety of GitHub actions to run various actions, all based on containerized programs. I think Tern could be a good "action" to run as part of a deployment workflow.
https://github.com/marketplace?type=actions
Use Cases
Before a container is deployed to DockerHub, could be useful to have an action to run Tern to check the compliance of it.
Implementation Changes
Essentially, you just need to write a DockerFile for the action.  For example, golangci-lint:
https://github.com/actions-contrib/golangci-lint/blob/master/Dockerfile

For a project I'm comparing several SBOM tools with each other. We're comparing tern with anchore, blackduck, whitesource, aws ecr, google cloud, and so on.
I've created a GitHub Action workflow for Tern.
https://github.com/JeroenKnoops/scan-docker-image/blob/master/.github/workflows/scan-tern.yml
I can create a github action for this so you can put it in the marketplace. Please let me know if you want me to create a PR here.
btw. We really like the output of tern. :)

@JeroenKnoops thanks for the feedback! We'd really appreciate a GitHub action. Just note that currently, Tern needs a Linux host to run. I am not sure if that is a blocker with creating a GitHub action.

I've started the development, will finish it hopefully this week.
Will try to make most of the configuration available in the action.
Progress can be found here: https://github.com/philips-labs/tern-action
Example of using it: https://github.com/JeroenKnoops/tern-action-examples

With tern version 2.2.0 the action works great.
I've released it here: https://github.com/marketplace/actions/tern-action
Source is here: https://github.com/philips-labs/tern-action but you are free to use this as inspiration and recreate it in the tern-tools organization.

Thank you! I will close this issue then.


Create CrawlerConfigurationException Specialization. Avoid throw Exception.

I had to fix a sonar constraint ("Avoid catch Exception") in my project because the CrawerController constructor throws a pure Exception.
I hope that this contribution is useful.

Thank you Gustav.
Yasser, this pull request looks good and can be merged

This makes sense to me... if we go for the next release version, this will be a benefit to pass the automated reviews...
Maybe @s17t  can look at this...


Aligned image size is half of the depth image size.

Hello, I need to align depth image with rgb and I shouldn't reduce the dimension of the aligned image less than (640,480) . I have using c++ to write my program and has tried your alignment example. Whenever I try to align them, it always make the aligned image half of the size of depth image. Can anyone help? I  am pretty sure that I am doing something wrong here. Also i need precise depth information. So, any suggestion about these would be highly appreciated.
	rs2::spatial_filter spat;
	spat.set_option(RS2_OPTION_HOLES_FILL, 5); // 5 = fill all the zero pixels
        rs2::align align_to(RS2_STREAM_DEPTH); //align to the depth (if i align to color then the depth info is really worst +/-25cm)
        rs2::pipeline pipe;

        rs2::config cfg;
	cfg.enable_stream(RS2_STREAM_DEPTH,848,480); // Enable depth camera
	cfg.enable_stream(RS2_STREAM_COLOR,1920,1080); //no matter what size i put the result is same size after alignment

        auto profile = pipe.start(cfg);
	auto sensor = profile.get_device().first<rs2::depth_sensor>();
	// Set the device to High Accuracy preset of the D400 stereoscopic cameras
	if (sensor && sensor.is<rs2::depth_stereo_sensor>())
	{
		sensor.set_option(RS2_OPTION_VISUAL_PRESET, RS2_RS400_VISUAL_PRESET_HIGH_ACCURACY);
	}

	auto stream = profile.get_stream(RS2_STREAM_DEPTH).as<rs2::video_stream_profile>();

        const auto window_name = "Display Image";
	namedWindow(window_name, WINDOW_AUTOSIZE);
	//rs2::frameset data;
	while (true)
	{
		auto data = pipe.wait_for_frames();

		// First make the frames spatially aligned
		//data = data.apply_filter(align_to);
		data = data.apply_filter(dec);
		data = data.apply_filter(spat);
		data = data.apply_filter(align_to);

                /*
		   data = align_to.process(data);*/  /// I have also tried aligned_to.process()

		auto color = data.get_color_frame();
		auto depth = data.get_depth_frame();
		auto color_mat = frame_to_mat(color);

		cout << "depth width"<<depth.get_width() << " - " <<depth.get_height()<<endl;
		cout << "color width" << color.get_width() << " - " << color.get_height() << endl;

		imshow(window_name, color_mat);
		waitKey(1);
          }

The resulted picture looks like this (please ignore the opencv window color frame ):

The resulted depth is wrong (originally about 33 cm) and the height and width of the aligned images are (424,240).
I somehow want the images of size (640,480) without black portion.  Btw, I couldn't exactly follow the aligned example or measure example as i dont want to use OpenGL.

data = data.apply_filter(dec);
@ahasan016 I believe you are using a decimation filter here. Can you post your decimation factor value? You are aligning post the decimation step. If the decimation factor is 2, then it will reduce the depth frame size by factor of 2 and the behaviour that you are seeing is expected.

Thanks again for your help @kafan1986    :)

data = data.apply_filter(dec);
@ahasan016 I believe you are using a decimation filter here. Can you post your decimation factor value? You are aligning post the decimation step. If the decimation factor is 2, then it will reduce the depth frame size by factor of 2 and the behaviour that you are seeing is expected.

@kafan1986  and @MartyG-RealSense yes. This was it. Thanks for your quick reply. Btw, I still am facing issue with depth precision. Any idea about it. I get depth value really good if I use these settings
dec.set_option(RS2_OPTION_FILTER_MAGNITUDE, 2);
rs2::config cfg;
cfg.enable_stream(RS2_STREAM_DEPTH,640,480); // Enable depth
// For the color stream, set format to RGBA
// To allow blending of the color frame on top of the depth frame
cfg.enable_stream(RS2_STREAM_COLOR,640,480);

but its always +/-(6or7) for my current case if I use anything else.

@ahasan  The optimal depth accuracy resolutions are 848x480 for D435 models and 1280x720 for D415.  I would recommend matching depth and color resolutions where possible.  If you have a choice between 1280x720 and 1920x1080 when aligning depth to color, I would recommend 1280x720 for color.

@Ahasan The optimal depth accuracy resolutions are 848x480 for D435 models and 1280x720 for D415. I would recommend matching depth and color resolutions where possible. If you have a choice between 1280x720 and 1920x1080 when aligning depth to color, I would recommend 1280x720 for color.

I am using D435i camera.. So what is your recommendation?

Try 848x480 for depth and 1280x720 for color, please/

Try 848x480 for depth and 1280x720 for color, please.

I have tried but the result isn't changed. It's the same. Only works with
dec.set_option(RS2_OPTION_FILTER_MAGNITUDE, 2);
rs2::config cfg;
cfg.enable_stream(RS2_STREAM_DEPTH,640,480); // Enable depth
// For the color stream, set format to RGBA
// To allow blending of the color frame on top of the depth frame
cfg.enable_stream(RS2_STREAM_COLOR,640,480);

However, things are different in your Intel RealSense Viewer. I always find a good depth value in the viewer app (regardless of the depth and color image size). Currently I have the following settings in the viewer:
{
    "aux-param-autoexposure-setpoint": "1536",
    "aux-param-colorcorrection1": "0.298828",
    "aux-param-colorcorrection10": "-0",
    "aux-param-colorcorrection11": "-0",
    "aux-param-colorcorrection12": "-0",
    "aux-param-colorcorrection2": "0.293945",
    "aux-param-colorcorrection3": "0.293945",
    "aux-param-colorcorrection4": "0.114258",
    "aux-param-colorcorrection5": "-0",
    "aux-param-colorcorrection6": "-0",
    "aux-param-colorcorrection7": "-0",
    "aux-param-colorcorrection8": "-0",
    "aux-param-colorcorrection9": "-0",
    "aux-param-depthclampmax": "65536",
    "aux-param-depthclampmin": "0",
    "aux-param-disparityshift": "0",
    "controls-autoexposure-auto": "True",
    "controls-autoexposure-manual": "8500",
    "controls-color-autoexposure-auto": "True",
    "controls-color-autoexposure-manual": "156",
    "controls-color-backlight-compensation": "0",
    "controls-color-brightness": "0",
    "controls-color-contrast": "50",
    "controls-color-gain": "64",
    "controls-color-gamma": "300",
    "controls-color-hue": "0",
    "controls-color-power-line-frequency": "3",
    "controls-color-saturation": "64",
    "controls-color-sharpness": "50",
    "controls-color-white-balance-auto": "True",
    "controls-color-white-balance-manual": "4600",
    "controls-depth-gain": "16",
    "controls-laserpower": "150",
    "controls-laserstate": "on",
    "ignoreSAD": "0",
    "param-amplitude-factor": "0",
    "param-autoexposure-setpoint": "1536",
    "param-censusenablereg-udiameter": "6",
    "param-censusenablereg-vdiameter": "7",
    "param-censususize": "6",
    "param-censusvsize": "7",
    "param-depthclampmax": "65536",
    "param-depthclampmin": "0",
    "param-depthunits": "1000",
    "param-disableraucolor": "0",
    "param-disablesadcolor": "0",
    "param-disablesadnormalize": "0",
    "param-disablesloleftcolor": "0",
    "param-disableslorightcolor": "0",
    "param-disparitymode": "0",
    "param-disparityshift": "0",
    "param-lambdaad": "630",
    "param-lambdacensus": "26",
    "param-leftrightthreshold": "18",
    "param-maxscorethreshb": "2047",
    "param-medianthreshold": "347",
    "param-minscorethresha": "80",
    "param-neighborthresh": "82",
    "param-raumine": "3",
    "param-rauminn": "1",
    "param-rauminnssum": "6",
    "param-raumins": "2",
    "param-rauminw": "2",
    "param-rauminwesum": "3",
    "param-regioncolorthresholdb": "0.0254403",
    "param-regioncolorthresholdg": "0.954012",
    "param-regioncolorthresholdr": "0.0283757",
    "param-regionshrinku": "4",
    "param-regionshrinkv": "1",
    "param-robbinsmonrodecrement": "15",
    "param-robbinsmonroincrement": "5",
    "param-rsmdiffthreshold": "3.34375",
    "param-rsmrauslodiffthreshold": "0.96875",
    "param-rsmremovethreshold": "0.666667",
    "param-scanlineedgetaub": "442",
    "param-scanlineedgetaug": "16",
    "param-scanlineedgetaur": "770",
    "param-scanlinep1": "21",
    "param-scanlinep1onediscon": "3",
    "param-scanlinep1twodiscon": "27",
    "param-scanlinep2": "182",
    "param-scanlinep2onediscon": "41",
    "param-scanlinep2twodiscon": "63",
    "param-secondpeakdelta": "205",
    "param-texturecountthresh": "0",
    "param-texturedifferencethresh": "3474",
    "param-usersm": "1",
    "param-zunits": "1000",
    "stream-depth-format": "Z16",
    "stream-fps": "30",
    "stream-height": "480",
    "stream-width": "848"
}

I wanted to apply the exported JSON file as the setting but I don't know how to do that.
       //// extra_added
	auto prof = pipe.start();
	rs2::device dev = prof.get_device();
	auto advanced = dev.as<advanced_mode>();
	advanced.load_json("D:/Mask_Robot_neural_stick2/effective_settings.json");
	//////////////////////
     while (true)
	{
		//// Fetch frames from the pipeline and send them for processing
		//if (pipe.poll_for_frames(&data))
		//{
		auto data = pipe.wait_for_frames();
		auto color1 = data.get_color_frame();
		auto color_mat1 = frame_to_mat(color1);
		imshow(window_name1, color_mat1);
		waitKey(1);
        }

but ended up with an error "Unhandled exception at 0x00007FFB0934A799 in roboter_mask_try.exe: Microsoft C++ exception: rs2::error at memory location 0x00000003EE8FEEA0. occurred"

Regarding loading the json, could you try moving the json loading code to directly beneath the  rs2::pipeline pipe; line please.
 rs2::pipeline pipe; auto prof = pipe.start(); rs2::device dev = prof.get_device(); auto advanced = dev.as<advanced_mode>(); advanced.load_json("D:/Mask_Robot_neural_stick2/effective_settings.json");

Regarding loading the json, could you try moving the json loading code to directly beneath the rs2::pipeline pipe; line please.
rs2::pipeline pipe; auto prof = pipe.start(); rs2::device dev = prof.get_device(); auto advanced = dev.as<advanced_mode>(); advanced.load_json("D:/Mask_Robot_neural_stick2/effective_settings.json");

actually I am doing it.  please check my main function:
int main()
{
	bool bExit = false;

	rs2::align align_to(RS2_STREAM_DEPTH);*/
	rs2::colorizer color_map;
	//color_map.set_option(RS2_OPTION_COLOR_SCHEME, 2.f);
	// Decimation filter reduces the amount of data (while preserving best samples)
	rs2::decimation_filter dec;
	// If the demo is too slow, make sure you run in Release (-DCMAKE_BUILD_TYPE=Release)
	// but you can also increase the following parameter to decimate depth more (reducing quality)
	dec.set_option(RS2_OPTION_FILTER_MAGNITUDE, 1);
	// Define transformations from and to Disparity domain
	rs2::disparity_transform depth2disparity;
	rs2::disparity_transform disparity2depth(false);
	// Define spatial filter (edge-preserving)
	rs2::spatial_filter spat;
	// Enable hole-filling
	// Hole filling is an agressive heuristic and it gets the depth wrong many times
	// However, this demo is not built to handle holes
	// (the shortest-path will always prefer to "cut" through the holes since they have zero 3D distance)
	spat.set_option(RS2_OPTION_HOLES_FILL, 5); // 5 = fill all the zero pixels
	// Define temporal filter
	rs2::temporal_filter temp;
	// Spatially align all streams to depth viewport
	// We do this because:
	//   a. Usually depth has wider FOV, and we only really need depth for this demo
	//   b. We don't want to introduce new holes
	rs2::align align_to(RS2_STREAM_DEPTH);

	// Declare RealSense pipeline, encapsulating the actual device and sensors
	rs2::pipeline pipe;

	//// extra_added
	auto prof = pipe.start();
	rs2::device dev = prof.get_device();
	auto advanced = dev.as<advanced_mode>();
	advanced.load_json("effective_settings.json");

	//////////////////////
	const auto window_name = "Display Image";
	namedWindow(window_name, WINDOW_AUTOSIZE);
	const auto window_name1 = "Display Image_before_align";
	namedWindow(window_name1, WINDOW_AUTOSIZE);
	//rs2::frameset data;
	while (true)
	{
		//// Fetch frames from the pipeline and send them for processing
		//if (pipe.poll_for_frames(&data))
		//{
		auto data = pipe.wait_for_frames();
		auto color1 = data.get_color_frame();
		auto color_mat1 = frame_to_mat(color1);
		imshow(window_name1, color_mat1);
		waitKey(1);

		data = data.apply_filter(align_to);

		auto color = data.get_color_frame();

		auto depth = data.get_depth_frame();

		auto color_mat = frame_to_mat(color);

		cout << "depth width"<<depth.get_width() << " - " <<depth.get_height()<<endl;
		cout << "color width" << color.get_width() << " - " << color.get_height() << endl;
		imshow(window_name, color_mat);
		waitKey(1);
		//aruco_try(color_mat);

		//render_simple_distance(depth, corners[0], corners[1]);

	}

}

Okay, thank you.  It was not clear from your provided listings that you were already doing this, as the rs2::pipeline pipe; line was not listed the first time that you showed your  //// extra_added code snippet above.

I am sorry that I forgot to put that line in my code snippet. Anyway, I really need to make the depth information right. The depth also changes according to the position (x,y) of the object. Isn't there any way to make it right? I can tolerate a deviation of max (+/- 1 cm). what is the max depth accuracy for the D435i can I expect? I will have to deal with the changing height as well. Because the camera will be installed in a robotic arm and the arm can move along all the axis. Any particular settings, post-processing or any kind of suggestion I can follow.

The depth accuracy of the 400 Series cameras is less than one percent of the distance from the object.  So if the camera is 1 meter from the object, the expected accuracy is between 2.5 mm to 5 mm.
The new RealSense D455 model has improved accuracy over distance by a factor of 2x compared to the D435 models (giving accuracy at 6 meters comparable to that of 3 meters distance on D435).
To be honest, the ever helpful @kafan1986 Can answer this subject better than I can.  Until he is back, you may find useful information in a recent discussion about getting xyz coordinates that @kafan1986 also helped with.
https://github.com/IntelRealSense/librealsense/issues/6749

ok. I have checked the issue. But I guess my scenario is a bit different as I have multiple objects to focus on and my camera will also move. However, I have noticed from the above issue that the depth changes over the area on the image is also an issue. you can check the following picture. Although I have pointed the camera on the flat surface but the depth values are different in different directions. Shouldn't it be the same at all pixels?

I think I also have my camera placed somewhat parallel to the floor. Say for it is not perfectly parallel, is the depth value affected by the camera placement angle? if so, then can I use the imu data to fix it? any solution or example can I follow till @kafan1986 comes back?

@ahasan016 Frankly I have never worked with D435 camera and don't know much about IMU data. But given my limited knowledge, I do believe you can deduce the angle of the camera from IMU. If the angle is known, then depth values can be adjusted as per requirement using simple trigonometry.

Welcome back @kafan1986
@ahasan016   I would think that having the camera oriented at an angle instead of pointing straight ahead (parallel to the floor) would have an effect on depth analysis, because some parts of the observed surface (the floor in this case) would appear to the camera to be nearer to the camera lens than other parts.

@kafan1986 , @MartyG-RealSense  I have checked the parallelity o my camera and I have these pictures for your reference. Do you think this is normal to have this much deviation in depth like in the first picture for the installment of the camera like the second picture?

@kafan1986 could you please direct me towards the mathematical equations for correcting the depth regardless of the area using the Euler angles from the accelerometer and gyroscope?

There will be 3 different angles - Yaw, Pitch and Roll. Roll won't impact the depth, so can be ignored. Rest two will impact the depth. In my case, I had only Pitch to worry about, so calculations only had to take care of this factor. I currently, don't have a notepad with me to calculate the formulae to be used.

I work the difference between the values out to be about 4 cm.  Given that the upper object is further away from the center of the camera lens, this seems a reasonable value.  Even though it is flat on the floor, the upper object is further from the camera.  It would be like putting a book on the floor at your feet and then pushing it away from you with your foot: you would then have to reach forward over a greater distance to touch it.

I work the difference between the values out to be about 4 cm. Given that the upper object is further away from the center of the camera lens, this seems a reasonable value. Even though it is flat on the floor, the upper object is further from the camera. It would be like putting a book on the floor at your feet and then pushing it away from you with your foot: you would then have to reach forward over a greater distance to touch it.

If the floor and camera plane is parallel, then the depth should be same. The depth calculated through stereo disparity always gives perpendicular distance to camera plane. So it won't matter if the pixel is at the center or at the edge of the image. The euclidean distance will off course change as described by your floor and feet example.

@kafan1986 exactly as you have written, I was thinking like that and it seemed to me that the camera was exactly parallel to the floor so it shouldn't affect the depth so much. at least not by 4-5 cm.  However, if you can write me the equation or give me a suitable link to follow then it will be really helpful. I want to give it a try even with considering the angles.

@MartyG-RealSense , @kafan1986  sorry to bother you guys. I have actually found a pattern for the depth changes on a flat surface. Please check the images I have plotted for depths.

Only changes in the images are the actual heights from the camera. Any idea how to flatten them to a certain point? let say I want to have a certain height for all the pixels as the mid pixel of the image? I can ignore the spike on the second image.

@ahasan016   I recalled that I had seen something like this graph before and managed to find the case on the Intel Support RealSense forum.
https://support.intelrealsense.com/hc/en-us/community/posts/360037100954-Deviation-in-distance-to-a-flat-surface-Realsense-415-Python-
The floor in their image looked like the image below, with the upper image demonstrating the variations in detected depth as a histogram.

During that case I noted that on the RGB image there was heavy shadow in some places and lighter areas in others and speculated whether that was affecting the depth values being read from the floor.

@MartyG-RealSense.. Sorry for being late.
I guess the i have the similar kind of floor where i am trying right now. I don't know whether i have the shadow or not as i haven't seen anything like that with my eyes. I have a fixed light above me.
Anyway, if it is the case of shadow then what am i required to do? Any idea?

@ahasan016   If your carpet is also a dark grey shade then that can be problematic in itself for depth analysis, as dark grey / black shades absorb light and make it difficult for depth cameras (not just RealSense) to read depth detail from them as they reflect little light back.  The darker the shade, the less light that is reflected and so the harder it is for the camera to depth-sense the surface.
A recent case involving a black office chair demonstrated that depth detail can be perceived if the dark surface is illuminated by a strong light source, lightening the surface.
https://github.com/IntelRealSense/librealsense/issues/6757
I wonder if purchasing an IR-pass filter and applying it over the camera lens would make a dark carpet easier to depth-analyse by making the projector pattern appear brighter.  Section 4.2.1 of Intel's white paper document on optical filters describes this.
https://dev.intelrealsense.com/docs/optical-filters-for-intel-realsense-depth-cameras-d400

@MartyG-RealSense Thanks for your information.
This isn't my original environment of operation. I have a few recorded depth videos from the actual robot working environment. I will check those depth frames. And will let you know whether the problem occurs there too. The environment basically looks like the following images:

Thanks very much for the above images.  Regarding the floor here, there is the potential for the camera to be confused by a different phenomenon related to surfaces that form repetitive patterns, like a row of fence posts.  I hope that the link below will provide useful information about addressing this if it does occur.
https://github.com/IntelRealSense/librealsense/issues/6713#issuecomment-651114720

@MartyG-RealSense Thanks for the early alert. I will also check on that. will get back to you after I test the camera on the real environment.

Hi @ahasan016   Do you wish to provide further test results please, or can this case be closed?  Thanks!

I have actually done test on the real scene where the distance of the camera from the object is about 1.5 meter. I need some final suggestions to improve the accuracy of depth to approx. ~4mm. I am going to try anything which is necessary. Recently, I have also tried the Lidr L515 and the accuracy was even a lot worse than the D435i. I can't do any changes to the scenario. But can try any kind of calibration or can add light sources or filters. So, some specific advise to achieve the accuracy on my environment will be highly appreciated.

The depth accuracy of the D400 series cameras is less than one percent of the distance from the object.  If the camera is 1m from the object, the expected accuracy is between 2.5mm to 5mm.
So at 1.5 meters, 4 mm would likely be considered a good result and there may not be much more that can be achieved without the aid of additional means such as physical optical filters or by turning on as many post-processing filters as possible
If you are making use of the camera's projector dot pattern then you may be able to reduce error further by using an external LED-based pattern projector.  Using an LED projector instead of the built-in projector helps to minimise a type of noise on the image called "laser speckle" that the laser-based projector in the camera can generate.  A reduction in RMS error (error over distance) of around 30% is expected when the built-in projector is turned off.

The depth accuracy of the D400 series cameras is less than one percent of the distance from the object. If the camera is 1 meter from the object, the expected accuracy is between 2.5mm to 5mm.
So at 1.5 meters, 4 mm would likely be considered a good result and there may not be much more that can be achieved without the aid of additional means such as physical optical filters or by turning on as many post-processing filters as possible
If you are making use of the camera's projector dot pattern then you may be able to reduce error further by using an external LED-based pattern projector. Using an LED projector instead of the built-in projector helps to minimise a type of noise on the image called "laser speckle" that the laser-based projector in the camera can generate. A reduction in RMS error (error over distance) of around 30% is expected when the built-in projector is turned off.
The subject of external projectors is discussed in the Intel paper in the link below.
https://dev.intelrealsense.com/docs/projectors

Any particular suggestions for buying the external projectors? I mean do you recommend any specific projectors which should be good enough for us? We have also tested the Lidar L515 sensor and have recently bought D415. L515 has really poor performance compared to the D435i but the D415 seems promising. Still would like to get the best out of D415 and it would be great if you could suggest the specific add ons like projectors or filters. I can also upload some more RGBs of our environment if you want.

As far as I know Intel haven't recommended specific pattern projector models for RealSense, though have provided guidance for choosing one in the camera tuning guide for the 400 Series cameras.
https://dev.intelrealsense.com/docs/tuning-depth-cameras-for-best-performance#section-use-external-projector
Make sure that it is a pattern projector that you are choosing if you need a dot-pattern projector, and not just a projector that casts illumination but not a pattern.  The link below illustrates this point.
https://github.com/IntelRealSense/librealsense/issues/2000#issuecomment-480795410

Case closed due to no further comments received.

So, I have now D415 camera and this time I have tried it on a white wall. I have the results as follows.
Camera to wall distance :0576mm :

Camera to wall distance :0917mm :

Camera to wall distance :1282mm :

Camera to wall distance :1615mm :

Camera to wall distance :1952mm :

The parameters are fixed as follows :
{
    "aux-param-autoexposure-setpoint": "1536",
    "aux-param-colorcorrection1": "0.461914",
    "aux-param-colorcorrection10": "-0.553711",
    "aux-param-colorcorrection11": "-0.553711",
    "aux-param-colorcorrection12": "0.0458984",
    "aux-param-colorcorrection2": "0.540039",
    "aux-param-colorcorrection3": "0.540039",
    "aux-param-colorcorrection4": "0.208008",
    "aux-param-colorcorrection5": "-0.332031",
    "aux-param-colorcorrection6": "-0.212891",
    "aux-param-colorcorrection7": "-0.212891",
    "aux-param-colorcorrection8": "0.68457",
    "aux-param-colorcorrection9": "0.930664",
    "aux-param-depthclampmax": "65536",
    "aux-param-depthclampmin": "0",
    "aux-param-disparityshift": "0",
    "controls-autoexposure-auto": "True",
    "controls-autoexposure-manual": "75714",
    "controls-color-autoexposure-auto": "True",
    "controls-color-autoexposure-manual": "312",
    "controls-color-backlight-compensation": "0",
    "controls-color-brightness": "0",
    "controls-color-contrast": "50",
    "controls-color-gain": "64",
    "controls-color-gamma": "300",
    "controls-color-hue": "0",
    "controls-color-power-line-frequency": "3",
    "controls-color-saturation": "64",
    "controls-color-sharpness": "50",
    "controls-color-white-balance-auto": "True",
    "controls-color-white-balance-manual": "4600",
    "controls-depth-gain": "16",
    "controls-depth-white-balance-auto": "False",
    "controls-laserpower": "360",
    "controls-laserstate": "on",
    "ignoreSAD": "0",
    "param-amplitude-factor": "0",
    "param-autoexposure-setpoint": "1536",
    "param-censusenablereg-udiameter": "9",
    "param-censusenablereg-vdiameter": "9",
    "param-censususize": "9",
    "param-censusvsize": "9",
    "param-depthclampmax": "65536",
    "param-depthclampmin": "0",
    "param-depthunits": "1000",
    "param-disableraucolor": "0",
    "param-disablesadcolor": "0",
    "param-disablesadnormalize": "0",
    "param-disablesloleftcolor": "0",
    "param-disableslorightcolor": "0",
    "param-disparitymode": "0",
    "param-disparityshift": "0",
    "param-lambdaad": "800",
    "param-lambdacensus": "26",
    "param-leftrightthreshold": "24",
    "param-maxscorethreshb": "2047",
    "param-medianthreshold": "500",
    "param-minscorethresha": "1",
    "param-neighborthresh": "7",
    "param-raumine": "1",
    "param-rauminn": "1",
    "param-rauminnssum": "3",
    "param-raumins": "1",
    "param-rauminw": "1",
    "param-rauminwesum": "3",
    "param-regioncolorthresholdb": "0.0499022",
    "param-regioncolorthresholdg": "0.0499022",
    "param-regioncolorthresholdr": "0.0499022",
    "param-regionshrinku": "3",
    "param-regionshrinkv": "1",
    "param-robbinsmonrodecrement": "10",
    "param-robbinsmonroincrement": "10",
    "param-rsmdiffthreshold": "4",
    "param-rsmrauslodiffthreshold": "1",
    "param-rsmremovethreshold": "0.375",
    "param-scanlineedgetaub": "72",
    "param-scanlineedgetaug": "72",
    "param-scanlineedgetaur": "72",
    "param-scanlinep1": "60",
    "param-scanlinep1onediscon": "105",
    "param-scanlinep1twodiscon": "70",
    "param-scanlinep2": "342",
    "param-scanlinep2onediscon": "190",
    "param-scanlinep2twodiscon": "130",
    "param-secondpeakdelta": "325",
    "param-texturecountthresh": "0",
    "param-texturedifferencethresh": "0",
    "param-usersm": "1",
    "param-zunits": "1000",
    "stream-depth-format": "Z16",
    "stream-fps": "15",
    "stream-height": "720",
    "stream-width": "1280"
}

Any idea of how to get the same height for each pixel value?
[note: please ignore the straight lines in the graph. Those are pixels that didn't have any depth values. I have just fixed them to a certain height for good visualization of the graphs]

Flat white walls with little or no texture can be difficult for the camera to analyze for depth detail.  If the IR Emitter component in the camera (a projector that casts a dot pattern onto the scene) is enabled then the camera can use the dots that are projected onto surfaces as a 'texture source' to read depth detail from.
The link below has C++ code under the heading 'librealsense2' for enabling the IR Emitter using the instruction RS2_OPTION_EMITTER_ENABLED:
https://github.com/IntelRealSense/librealsense/wiki/API-How-To#controlling-the-laser


feat: integrate dry-run with cellxgene-ontology-guide

Reason for Change

#102

Changes

update dry run report to use COG
remove deprecated code (compute scripts, associated workflows, all_ontology file)
update GHAs to only trigger on GENCODE / gene_info.yml updates
renamed dir ontology_files --> gencode_files

Notes for Reviewer

TODO: integrate with CLI
TODO: use official release of COG when available + use with 5.1.0 schema version
TODO: update docs re: ontology_files

breaking up into smaller prs


[FLINK-7309][hotfix] fix NullPointerException when selecting null fields

What is the purpose of the change
This pull request addresses FLINK-7309, adds null check before applying unboxing on input fields.
Brief change log

Add null check before applying unboxing on input fields.

Verifying this change
This change added tests and can be verified as follows:

Added test case: select null field from a Timestamp type field.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Thanks for the PR @yestinchen.
Will merge this.


specify C++ language in clang-tidy static-checks.yml

it looks like clang-tidy/clang does not recognize quite a few of our files as C++; I propose to add --language=c++ next to  -std=c++17 to resolve this
I tested it locally and the error: invalid argument '-std=c++17' not allowed with 'C' appearing while running is gone

I'm curious why are we using clang-format-12 and clang-tidy-12 in the linter instead of what's coming with llvm setup in cmssw on cvmfs (16.0.3 in 13_3 and more recently 17.0.3)?

Hi @slava77, this was part of the reason why I said that the clang-tidy part of the CI is good enough, but definitely not perfect. clang-tidy assumes that .h files (so most of our files) are in C. The thing is that, as far as I can tell, there are only two popular and actively maintained GitHub Actions that run clang-tidy: cpp-linter-action (the one we use) and clang-tidy-review (which I had more issues with). Both of them don't seem to expose a low enough level of control of clang-tidy to fix this sort of things. You can see in this test PR https://github.com/SegmentLinkingTests/TrackLooper/pull/3 that even with that additional flag you still get the same behavior. The purpose of the -std=c++17 flag is to fix some other errors you would get in  .cpp files. So I think that the only options would be to either implement a clang-tidy action on our own with the right parameters, try forking one of the existing ones and fix it, or just deal with some fictitious warnings for now until we can test with scram b code-checks. I opted for the last option, but if you prefer we can try the second option.
Regarding version 12 vs 16, I think I accidentally checked the version in CMSSW 13_0_0 instead of 13_3_0, but we can fix that easily.

You can see in this test PR SegmentLinkingTests#3 that even with that additional flag you still get the same behavior.

Uhm, the differences in my local setup were

I listed the arguments combined after -- instead of --extra-arg
clang-tidy was from the cmssw distribution

I'm curious if one of these is the reason for the failure in SegmentLinkingTests#3

Uhm, the differences in my local setup were

and also I passed the full file, not just the changed lines

I listed the arguments combined after -- instead of --extra-arg

Yeah, that's the issue. I don't know how to pass arguments like that to the action.

and also I passed the full file, not just the changed lines

The action uses the full file, but only reports warnings/errors in lines that were changed.

I finally figured out how to fix this issue. I'll close this PR and tomorrow I'll submit a new PR with all the CI fixes.


Request: Support MongoDB Server 5.x/6.x

Informations
Is your feature request related to a problem? Please describe.

MongoDB 4.4 will reach its EOL on February 2024. (1 year left)
Some providers already dropped support for 4.x (e.g. https://github.com/bitnami/containers/commit/92e06b062e934e8cb9d00b993af06f96e0299188)

Describe the solution you'd like
It's better to add support for MongoDB 5.x/6.x to GROWI.

@shield-9 Now GROWI v6.1 support 5.x/6.x


Clean Up dependency management

This PR is an attempt to fix #36.
Note that once my PR on DTModelStorage is merged and a new version is created the entry in Cartfile should be altered to state something like this:
github "DenHeadless/DTModelStorage" ~> 2.4

Closing, discussion in https://github.com/DenHeadless/DTModelStorage/issues/10


Crash occurring when closing and re-opening the same source file multiple times

When opening and closing the same source file that has SARIF results rendered in it multiple times, a crash occurs in visual studio.
This is related to issue this Windows bug:
https://microsoft.visualstudio.com/DefaultCollection/OS/_workitems/edit/29582350/

@lgolding

In process of validating PR, should be finished today


Please include test_index.json in tarball

I'm in the process of packaging this for Fedora, and one something that is very helpful is to be able to run the test suite during package building. Unfortunately the tarball doesn't contain test_index.json, so the tests all fail - please could you include that in the tarball. Thanks.

Thanks.
On 28 July 2015 at 20:34, Alec Thomas<EMAIL_ADDRESS>wrote:

Closed #22 https://github.com/alecthomas/importmagic/issues/22 via
a0c7ede
https://github.com/alecthomas/importmagic/commit/a0c7ede348528a50ae4aac3a55803a54c3cb0426
.
—
Reply to this email directly or view it on GitHub
https://github.com/alecthomas/importmagic/issues/22#event-367619058.


Exclude patterns in array.

I see that there was an addition on anymatch https://github.com/es128/anymatch/issues/6 for this scenario, but I couldn't make it to work with brunch 1.8.5, is this supposed to work?
  files:
    javascripts:
      joinTo:
         'js/libs.js': ['bower_components/jquery/dist/**/*.js', '!*.js']

What are you trying to do with those two globs? Doesn't seem like the second one with the negation would have any effect.

Well, yes sorry, that example is kinda non-sense.
I will try to give the 'real' example of what I'm trying to accomplish.
  files:
    javascripts:
      joinTo:
        'js/app.js' : /^app/
        'js/jquery.js': 'bower_components/jquery/dist/**/*.js'
        'js/bootstrap.js': 'bower_components/bootstrap/**/*.js'
        'js/libs.js': [/^vendor/, '!bower_components/jquery/**/*', '!bower_components/bootstrap/**/*']

all I want to do is exclude jquery and bootstrap from concat, i need those to have it on it's own file.

I'm not totally sure whether negating regex matches with negated globs is going to work, but this example still doesn't really make sense to me.
Perhaps try something like ['!**/{jquery,bootstrap}/**/*', 'vendor/**/*']

definitely I don't understand how it works, but your suggestion is exactly what I was trying to accomplish. thanks.

It's the shell expansion syntax, foo_ba{r,z,t} is foo_bar foo_baz foo_bat

thank you@vendethiel, what I don't understand is how the negation works, expansion is clear.

now I get it, I wasn't using globs correctly. thank you both.


make desmos compatible

Since desmos hard-coded relies on "secp256r1", the ethkey-tool needs to account for that.
The previous implementation was using "secp256k1" and therefor did produce incompatible keys.

@wistefan, we create a tool with a UI to generate all the required keys. https://dome-marketplace.github.io/dome-crypto-generator/

@albertrodriguezin2  Thanks for mentioning. I had a look at the repo and I'm a bit concerned. Why should I use this untested and undocumented javascript generator, when there is a very small go tool, using well-tested, maintained and documented libraries?
I would definitely prefer the go version to be updated.

@albertrodriguezin2 Whats the reason for using different curves? Why can't one access-node just use one identity? I understand that there might be use-cases where both can differ, but why is this made a necessity?


Setting OptionCheckSyntax to false throws a NullReferenceException if html has unclosed tags

Description
When using the LoadHtml method of an HtmlDocument instance that has the property OptionCheckSyntax set to false, a NullReferenceException is thrown if the input HTML has any unclosed tags or is invalid in any way.  I'm not sure if this is expected or As Designed but I couldn't find any information about it.
Exception
Exception message:  Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.
Stack trace:
   at HtmlAgilityPack.HtmlNode.UpdateLastNode() in C:\Users\Jonathan\source\repos\HtmlAgilityPack\HtmlAgilityPack.Shared\HtmlNode.cs:line 2009
   at HtmlAgilityPack.HtmlNode.CloseNode(HtmlNode endnode, Int32 level) in C:\Users\Jonathan\source\repos\HtmlAgilityPack\HtmlAgilityPack.Shared\HtmlNode.cs:line 2077
   at HtmlAgilityPack.HtmlNode.CloseNode(HtmlNode endnode, Int32 level) in C:\Users\Jonathan\source\repos\HtmlAgilityPack\HtmlAgilityPack.Shared\HtmlNode.cs:line 2056
   at HtmlAgilityPack.HtmlDocument.CloseCurrentNode() in C:\Users\Jonathan\source\repos\HtmlAgilityPack\HtmlAgilityPack.Shared\HtmlDocument.cs:line 1077
   at HtmlAgilityPack.HtmlDocument.PushNodeEnd(Int32 index, Boolean close) in C:\Users\Jonathan\source\repos\HtmlAgilityPack\HtmlAgilityPack.Shared\HtmlDocument.cs:line 2061
   at HtmlAgilityPack.HtmlDocument.Parse() in C:\Users\Jonathan\source\repos\HtmlAgilityPack\HtmlAgilityPack.Shared\HtmlDocument.cs:line 1391
   at HtmlAgilityPack.HtmlDocument.Load(TextReader reader) in C:\Users\Jonathan\source\repos\HtmlAgilityPack\HtmlAgilityPack.Shared\HtmlDocument.cs:line 771
   at HtmlAgilityPack.HtmlDocument.LoadHtml(String html) in C:\Users\Jonathan\source\repos\HtmlAgilityPack\HtmlAgilityPack.Shared\HtmlDocument.cs:line 819
   at Program.Main()

Fiddle or Project
https://dotnetfiddle.net/9NZotJ
Further technical details

HAP version:  1.11.12
NET version:  netcoreapp2.2

Hello @Shoh ,
Thank you for reporting, we will look at why this issue happens.
Best Regards,
Jonathan

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Entity Framework Classic • Bulk Operations •  Dapper Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function

Hello @Shoh ,
The pull made by @EvgeniyZ has been finally merged. Thank to him!
Starting from the v1.11.15, you should no longer get the issue.
Let me know if everything works as expected.
Best Regards,
Jonathan

Hello @Shoh
Did you get the time to try the latest version v1.11.15?
Best Regards,
Jonathan

Hi @JonathanMagnan,
Sorry for the delay; I've been on vacation.  Yes, I can confirm that the issue is fixed in v1.11.15.  Thank you!
-Shoh


Documentation

Do you have in plans to create some docs page?

Hi @mydesireiscoma haven't had much time to work on this, but will document the current functionality today.

Like I promised, the documentation is now available at the project's site. This project is still a WIP so do not expect any new additions anytime soon, but the docs cover most of the current features.

Thanks a lot my friend


NH-29380 Remove unused clean_hack config

Similar to https://github.com/solarwindscloud/solarwinds-apm-python/pull/163 and https://github.com/solarwindscloud/solarwinds-apm-python/pull/164
This removes is_grpc_clean_hack_enabled from APM Python config. It is not currently used and I don't think it's needed since liboboe 12.0.0 (https://swicloud.atlassian.net/browse/NH-28555) but please let me know if I'm wrong! The value is not used to config Reporter nor anything else. This value was copied from AO which I think used it as a hidden option to re-activate a hack (https://github.com/librato/python-appoptics/pull/254).

Closing to include changes in a single PR: https://github.com/solarwindscloud/solarwinds-apm-python/pull/164


Optimization that in my tests shows 2.7s -> 2.2s

New approach to what #312 tried to do. Nicely catches how text pointers (start_pos, end_pos) are advanced and advances proc_buf by the same amount. Runs in 2.2s.

LGTM.  Could you update the new block comment to use full sentences and punctuation (full stop at the end of a sentence, blank lines between paragraphs, etc)?

Is it ok now? BTW, I tried moving proc_buf advancement to the end – where your patch located it, and test still ran in 2.2s. I'm sure the tests are correct, wonder how is it possible that your version produces the same output, but in different time.

Merged in 5a98cd3.

BTW, I tried moving proc_buf advancement to the end – where your patch located it, and test still ran in 2.2s. I'm sure the tests are correct, wonder how is it possible that your version produces the same output, but in different time.

Let's have any investigation of this issue happen o na separate ticket; I'd like to close this one.


python37Packages.rasterio: 1.0.22 -> 1.0.23

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-rasterio/versions.
meta.description for python37Packages.rasterio is: '"Python package to read and write geospatial raster data"'.
meta.homepage for python37Packages.rasterio is: '"https://rasterio.readthedocs.io/en/latest/"
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 1.0.23 with grep in /nix/store/h6ygl4dx5y5db4s04yw4iv2c8sa0dq7g-python3.7-rasterio-1.0.23
directory tree listing: https://gist.github.com/fab91c35fa98cdc23033d1b3b984acd5
du listing: https://gist.github.com/41c1c35156be07aabcd23862ce405930

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
python27Packages.rasterio
python37Packages.rasterio

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/h6ygl4dx5y5db4s04yw4iv2c8sa0dq7g-python3.7-rasterio-1.0.23 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A python37Packages.rasterio https://github.com/r-ryantm/nixpkgs/archive/5713dd7af01b23abfa3f22f87f897d8a8d9f1069.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/h6ygl4dx5y5db4s04yw4iv2c8sa0dq7g-python3.7-rasterio-1.0.23
ls -la /nix/store/h6ygl4dx5y5db4s04yw4iv2c8sa0dq7g-python3.7-rasterio-1.0.23/bin

cc @mredaelli for testing.

And I forgot to scope isPy3k dammit!
I'll squash all that into one commit when merging

@GrahamcOfBorg build python27Packages.rasterio


Convert image to tensor

Done in https://github.com/opixelum/opixelib/commit/887f3cfe98a7306ba147aa245e17430c9cd6b0d1


Please provide a way to convert older style pdb files into the current format.

I have several older style pdb files built with different compilers (VB6 for instance) but these can no longer be used for debugging purposes with Visual Studio 2017+.
Please provide a conversion/upgrade tool to recreate the pdb file in a compatible format.
Thank you

This is certainly an interesting use case.  I think it's unlikely that Microsoft will ever decide to support this given the number of customers which are probably impacted, but LLVM has produced a fully working, completely open source implementation of PDB reading and writing.  I think your most likely path to making this possible is to implement the functionality yourself in LLVM (either upstream or in a fork).

Please open a ticket for this feature request on https://developercommunity.visualstudio.com/
This repo was for information only and is not part of the live codebase for the PDB engine shipped with Visual Studio.

Done.
https://developercommunity.visualstudio.com/idea/509038/please-provide-a-way-to-convert-older-style-pdb-fi.html


Make bpf2c maps parser match verifier's maps parser

Description
The verifier will parse "maps/*" sections, and is able to deal with maps sections with various record sizes.  This PR updates bpf2c to use the same algorithm.  In the future it would be good to refactor the verifier so the same code can be used.
Before this change, such a program would pass the verifier but bpf2c couldn't convert it.
Fixes #900
Note to code reviewers: this change is easiest to review by ignoring whitespace changes (since it removes an indentation level for a bunch of code).  To do so in github, click "Files changed", then the gear button dropdown button just under the "Checks" and "Files changed" labels, click "Hide whitespace" then "Apply and reload".
Testing
The update to map_in_map.c results in testing this functionality.
Documentation
No impact.

I think there are some more places in ebpf-for-windows code, where it either assumes the maps section will always be "maps" or hard codes the maps section size. Should we fix those also in this PR?

_get_program_and_map_names() (verifier.cpp) only looks for "maps" section to find the map names, and fails if any map name is not found in "maps" section.
parse_maps_section_windows() assumes the map size to be sizeof(ebpf_map_definition_in_file_t)

Thanks.  Both of those are now updated.

read_elf() (elfhelper.cpp) only ignores "maps" section, it should also ignore any "maps/*" sections.

ElfHelper appears to be dead code.  Filed PR #2572 for removal.

Test requires https://github.com/vbpf/ebpf-verifier/pull/510

blocked on https://github.com/vbpf/ebpf-verifier/issues/506

sanitize pass is failing because libbtf forces /WX and forces non /Zi.
The lack of /Zi means warning C5072 is generated during the sanitize pass:
    28>D:\a\ebpf-for-windows\ebpf-for-windows\external\ebpf-verifier\src\crab_utils\stats.cpp : warning C5072: ASAN enabled without debug information emission. Enable debug info for better ASAN error reporting [D:\a\ebpf-for-windows\ebpf-for-windows\external\ebpf-verifier\build\ebpfverifier.vcxproj]

And forcing /WX means that forces the github job to fail.
Other libraries either allow /WX or /Zi to be under the control of our project.
Waiting for Alan to fix in libbtf.

The curious question behind the changes: Is the goal to support more than one verifier (from different vendors)? Or, Is the goal to support different versions of the same vendor's verifier?

No.  The goal is just to support PREVAIL and have ebpf-for-windows and prevail match in terms of what map capabilities they support.

Reason: I see the map query definition by id. So, how is the id determined?


ll.blues: chans out mono mode

ll.blues seems to force-mix output to stereo at the minimum, even if i 1 channel is specified as output in "chans" variable.

I've been having this issue (sound generators outputting to mono), and after fiddling, if I change the blues output # to 1, it goes stereo, turning it back to 2 will revert to mono (so, sort of the opposite of what you'd want). Just my 2 ¢!

solved

awesome!


Create prime.pas

pascal language
The source code could be compile using fpc (free pascal compiler)
command line: fpc -O3 prime.pas

Thanks.

Pascal added to results: 773c74c5689e8e62c31e10034ee30486948af56c


Get rid of preprocessTypescript in e2e tests when using @jscutlery/cypres-harness

We have to get rid of this hack.
https://github.com/jscutlery/devkit/blob/84a54201278231a24715564d7fb781bbde9482c8/packages/cypress-harness-e2e/src/plugins/index.ts#L17-L25
This can be reproduced by removing this line and running e2e tests: nx run-many --target e2e --all

I can't even get this hack working in my end-to-end tests (not Cypress Angular component tests) using Nx 13.10.2 with Cypress 9.1.1.

I had "pluginsFile": false in my cypress.json configuration 🤦♂


[DO NOT MERGE] Squirrel test branch

(Ignore me, solely for build speed benchmarking purposes)

:popcorn:


Add support for embedded packages in the dependency window

Overview
Embedded packages go into the Packages folder directly:

Any package that appears under your project’s Packages folder is embedded in that project.

This change ensures we load from that folder too.

/azp run


RHBPMS-596 - Message and Service task default properties displayed when re-open process

Tested and works fine.

@jlindop amended (removed disabled tests per @hasys recommendations)

+1

Isn't this also removing tests that previously did run (that weren't disabled) i.e. testSimpleDefinitionsUnmarshalling?

@csadilek i removed tests that don't make sense any more to run. Our master branch has alot more tests and I will find commits to cherry pick to 6.4.x so that they are the same. The tests I removed are either not in master or have already been updated there.

@tsurdilo the following tests were active on 6.4.x and are currently on master [1] but have been removed in this commit on 6.4.x:
testSimpleDefinitionsUnmarshalling
testPoolUnmarshalling
testWorkItemHandlerNoParams
testDocumentationForSwimlane
[1] https://github.com/droolsjbpm/jbpm-designer/blob/master/jbpm-designer-backend/src/test/java/org/jbpm/designer/bpmn2/impl/Bpmn2UnmarshallingTest.java

@csadilek
testWorkItemHandlerNoParams -- revised and added back
testDocumentationForSwimlane - revised and added back
testMessageUnmarshalling - renamed to testNoDefaultMessageCreated and revised
testSimpleDefinitionsUnmarshalling - revised and added back
testPoolUnmarshalling - we dont use pools so is ok to remove . i will do the same in master asap
other removed tests no longer apply


Readme typo fix

Fix the typo issue in Readme

@Goxiaoy Updated Readme with typo fixes

Thanks for pointing out
https://github.com/Goxiaoy/go-saas/blob/7fab63a5af76a698eb89199d351d52e632f0c1e5/common/http/route_tenant_resolve_contributor.go#L24-L27
RouteTenantResolveContributor has not implemented yet

@Goxiaoy  Updated the Readme to unmark Route


results.json should include more details about the run like JVM command-line, OS env, etc.

I love that the results.json captures all the query latency details, but we should also record JVM command-line flags, OS / CPU details, etc.

And JVM version.

Sounds like a good idea. It should allow each engine to have a bit of metadata which we can present in the UI.


R0 definition should not be daily but lifespan calculated

I was thinking about the plots of R0 and it did strike me that they were too low. We calculated basically daily R0 but the definition should apply on the lifespan of individuals. It will make it harder or we need to track a NC per individual I guess.
Will think about it :/

yes i understand what you're saying,  but just a question, in this case the R0 is not a value that changes over time? and if you want to calculate the R0, is it necessary to take the average number of people contaminated by each infected person? or just the average of contaminated person infected by the people who were infected at the start of the pandemic?
because people infected at the end they will not have time to infect others, and suddenly it can drop R0

I think that what we calculated was "Effective reproductive number" not the "Basic  reproductive number"

I guess a moving average R0 calculated on "have been" contagious people will do the job. I  think it is nice to keep an "average" R0 day by day to see its evolution.

Submitted a new 14-days sliding R0 definition !


Avoid Screen from getting dimmed

Suggestion / Feature Request
Screen may get dimmed on not operation by user or whenever screen becomes unresponsive due to some interruption by system.
We need to avoid this issue.

Please assign this issue to me.

Can u explain a bit on what u wish to achieve this?

Can u explain a bit on what u wish to achieve with this?

Screen automatically gets dimmed whenever system interrupt occur or due to any possible system interrupt.

Can u clarify what do u mean by system interrupt? Maybe through a video or something?

Closing the issue for now since no updates


Is silent truncation sufficient?

I've seen a number of websites over the years that silently truncate passwords, either during login (but not during password change, making it impossible to login if you used a long password) or on the backend (which results in a silent loss of entropy, turning correct horse battery staple into the not very secure correct hors. As I dig these up, I'll submit them.
But I have one site that seems to have a decent password policy generally: min 6 chars, no other specific rules. Seems to accept all the special chars, spaces are ok. Seems to have an entropy check on the backend as short passwords are rejected unless they have lots of variation while all lowercase passphrases are just fine. BUT they truncate silently to 73 char. Is that sufficient to go on the list? A screenshot wouldn't show much as you can "have" a 120 char password and login with a 120 char password, but only the first 73 char matter.

I haven't made any specific rules to get on the list and 73 characters seems reasonably high to me, but I would definitely consider silently truncating enough for an entry.