Remove import syntax from @solana/spl-memo javascript lib

This lib https://www.npmjs.com/package/@solana/spl-memo doesn't work with require NodeJS method, because it use the import syntax. I suggest make it via commonjs style, as now working in @solana/web3.js and @solana/spl-token libs.

Yeah, this is a good callout, we should ship ESM and CJS builds.

@alexandr-kazakov would you consider opening a PR to change the package.json / tsconfig setup to match the SPL token lib?

I looked other JS libs here and I saw what two versions being created: commonjs and es modules. Example: https://github.com/solana-labs/solana-program-library/blob/57c5fd80f60ed4d6053989e64882f9002e352910/token/js/package.json#L21-L24
Probably in the JS memo lib we need to use the same approach. I will try to do it later, if no one does it before.

Yeah, exactly. We use the TypeScript compiler with different configs to build them. It should work to copy paste the same setup from Token to Memo.


Custom Control: File Uploader

Hi,
I have a general question about the custom control file uploader.
I see that we are not loading the custom control JS anymore like before.
`*    client->view_display( Z2UI5_cl_xml_view=>factory( client

    )->_z2ui5( )->timer(  client->_event( `START` )

    )->_generic( ns = `html` name = `script` )->_cc_plain_xml( z2ui5_cl_cc_file_uploader=>get_js( )

    )->stringify( ) ).`

Now I encountered that each time we call the file uploader, it creates a new iFrame.
Unfortunately, The iFrame doesn't disappear after the file uploader has been closed.

Is this a normal behavior (as designed)?
Thanks,
Axel

Hi Axel,
the file uploader custom control is loaded as before, but not on app level anymore. It is now send with the index.html at the beginning:

Thats why i would suggest that these iframes also existed before? Maybe the functionality with file loading creates these iframes, and yes maybe there are nicer solutions possible, but so far it is the "designed behaviour".
Best regards.

OK, thanks for the answer.


[39] Finally + post-commit review

@jessesquires, @BasThomas, @jpsim: Care to take a read through issue 39 and tell me what you think? :)

I can't tell you the number of times a spell-checker has told me that my last name is wrong.

So good! 🎉

LGTM too!


Missing part of information in the chart

HI, i got a problem. When i export to png, jpg format.,it just show up x-Axis line and chart line.But it is fine with PDF and SVG.

@lizard824
This is a known issue. The problem comes from a conflict of imagemagick library versions.
Now we are looking for a solution and we will notify you when the solution becomes available.
Thank you for your report!

@lizard824
Please, try to install imagemagick-7.0.7-39
Exactly this version works properly.
If you are using homebrew manager you can execute the following commands:
brew unlink imagemagick
And then:
brew install https://raw.githubusercontent.com/Homebrew/homebrew-core/d702da6c9ee696d98e8313b7303c530680dd552f/Formula/imagemagick.rb


Git LFS is not recognized

I'm just trying out Git LFS extension but I'm unable to have it working. I've installed using Homebrew, then in a test repository I've entered the following commands:
git lfs track "data/*.fastq"
git add data/SRR49336{6,7}*
git commit -m 'Adding data files'
git push

However the push complained that files were too big and suggested to use git lfs instead (!)
Writing objects: 100% (8/8), 32.13 MiB | 747.00 KiB/s, done.
Total 8 (delta 0), reused 0 (delta 0)
remote: warning: GH001: Large files detected. You may want to try Git Large File Storage - https://git-lfs.github.com.
remote: warning: See http://git.io/iEPt8g for more information.
remote: warning: File data/SRR493366.fastq is 51.94 MB; this is larger than GitHub's recommended maximum file size of 50.00 MB
remote: warning: File data/SRR493367.fastq is 51.94 MB; this is larger than GitHub's recommended maximum file size of 50.00 MB
To git@github.com:pditommaso/test-lsf.git
   f5be9f4..e2024a5  master -> master

What's wrong?
You can find the repo here.  It works for files placed in root but not for files placed in folders / directories. It's quite frustrating.

@pditommaso You need to run git lfs install to set up the global git config. You can see this from the empty values at the bottom of the git lfs env output:
git config filter.lfs.smudge = ""
git config filter.lfs.clean = ""

I don't know if you got it working later, but this file is successfully stored with Git LFS: https://github.com/pditommaso/test-lfs/blob/be3d682f37f516aee43c133092bd518fe55b12fd/data/SRR493366.fastq
@cipriantepes: Can you file a new issue with details? If files aren't being added to Git LFS, and you've run git lfs install, it's possible that Git isn't matching the files up properly with the patterns in .gitattributes.

git lfs env
git lfs track

@technoweenie I managed to make it work using github for windows and the Git Shell provided by that app. I wasn't able to install the standalone app from the site. The only file installed was git-lfs-uninstaller.exe - maybe because github for windows was already installed?

The Git LFS installer looks for where you have Git For Windows installed. If you installed it to a custom directory, you'll have to tell that to the Git LFS installer too. Though if you use native tools like GitHub Desktop (and soon, SourceTree), you may be better off relying on them to install and update Git LFS.

@technoweenie It defaults to desktop, not sure why. However, as long as it works in Git Shell, I'm good until I find what the problem could be.
Thanks!

git lfs track now installs itself if it wasn't already, so this issue can be closed.


Clean up validation for task and pipeline refs

Changes
This commit creates separate files for testing validation of Task and Pipeline
references, and moves test cases related to this validation into those files.
It also updates the error message for when a bundle is included in a reference
without the "enable-tekton-oci-bundles" flag set to "true" to instruct the user
to set that flag. In addition, it updates the error message for when resolvers
are set without the "enable-api-fields" flag set to "alpha" to instruct the user
to set that flag.
/kind  cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

n/a Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in
(if there are no user facing changes, use release note "NONE")

Release Notes
NONE

/approve

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelineref_validation.go	96.8%	100.0%	3.2
pkg/apis/pipeline/v1beta1/taskref_validation.go	97.6%	95.0%	-2.6

Refactoring is bringing down the coverage, please address this 🙏

Not sure what is going on here: tests are failing with
$ git merge --no-ff 0692a5fce64a8d24b0bf60680cf2ca457ae6e186
merge: 0692a5fce64a8d24b0bf60680cf2ca457ae6e186 - not something we can merge

but they pass locally?
/retest

/retest

/retest

/retest


'This app contains no stacks' when following the "Advanced Topics/CDK Pipelines" typescript tutorial subsection

What is the problem?
After finishing the Typescript Tutorial section with its subsections "New Project", "Hello, CDK!", "Writing constructs", "Using construct libraries", "Clean up" and"Advanced Topics/Testing Constructs" and beginning with the subsection "Advanced Topics/CDK Pipelines" and completing the Steps

"Getting Started with Pipelines"
"Create Repository"

Results in "This app contains no stacks"
when trying to execute following commands:

npx cdk bootstrap --cloudformation-execution-policies arn:aws:iam::aws:policy/AdministratorAccess
npx cdk deploy

To be sure I did the steps in "Advanced Topics/CDK Pipelines" again with copy paste only while getting the same output.
Reproduction Steps
Follow the official steps of the documentation "Advanced Topics/CDK Pipelines" after successfully doing all sections of the Typescript Tutorial sections before.
Verbose Log
> npx cdk bootstrap --cloudformation-execution-policies arn:aws:iam::aws:policy/AdministratorAccess
'@aws-cdk/core:newStyleStackSynthesis' context set, using new-style bootstrapping
This app contains no stacks

> npx cdk deploy
This app contains no stacks

CDK CLI Version
1.130.0 (build 9c094ae)
Section
Advanced Topics/CDK Pipelines
Browser
all
Language
TypeScript
Other information
No response

I ran a npm build before executing npx cdk bootstrap --cloudformation-execution-policies arn:aws:iam::aws:policy/AdministratorAccess resulting in an updated cdk.out where the corresponding app could not be resolved anymore


foreign key fields skip render_field

It seems to be impossible to customize the rendering of foreign key fields (org_id)?  These fields don't seem to go through the render_field function. I was trying to specify how to handle those in :render_with .
Originally posted by @Rio517 in https://github.com/tfwright/live_admin/issues/52#issuecomment-1636741908

Resolved in https://github.com/tfwright/live_admin/commit/28004c9921c2cf78522f7fd53a7cb24487c0843f


Add command to asdftool for removing ASDF extension from FITS file

Specifically for @hbushouse. Given a file asdf.fits that contains an ASDF extension, here's an example of how to use it:
$ asdftool remove-hdu asdf.fits no_asdf.fits

The file no_asdf.fits will be created (assuming it doesn't already exist) as a duplicate of the input file but without the ASDF extension.
For usage information:
$ asdftool -h
$ asdftool remove-hdu -h

This will need to be rebased once #482 is merged.

Coverage decreased (-0.03%) to 94.024% when pulling b106a9e33ca65e40ae80c11f75bf32f7dcf004c6 on drdavella:kill-asdf into 40aaea704e0f3ef2b65bcb3d0fad4429ccd00b34 on spacetelescope:master.


refactor and remove afterResolving()

This PR resolves the issue described in https://github.com/Laravel-Backpack/CRUD/issues/4251, which @preBit and I are both experiencing.
I'm unclear on the magic going on behind the scenes when it comes to bladeCompiler, however I followed the structure defined in https://github.com/spatie/laravel-permission/blob/main/src/PermissionServiceProvider.php, and now my @loadOnce calls render properly.

I confirm this PR resolves the issue.

Thanks @olipayne .
I will have a look at it later today, but if the problem is afterResolving I am afraid we use it in ALOT of other places, so I need to give this a throught review.

for my case. i roll back spatie/laravel-permission (5.5.1 => 5.5.0) solve the issue.
I am not sure it is related. just FYI https://github.com/Laravel-Backpack/CRUD/issues/4251#issuecomment-1059935166.

I think @kiddtang is onto it, in 5.5.1 they refactored the blade directives code - https://github.com/spatie/laravel-permission/pull/2039/files

I just tested and confirm downgrading spatie/laravel-permission (5.5.1 => 5.5.0) and digitallyhappy/assets at 2.0.3 without this PR solved the issue.

Can confirm too, now the question is which package needs to be updated to be compatible with the other? 😬

Eagerly awaiting for this one...😬

@olipayne , @preBit and @kiddtang 🙏 Can't thank you guys enough! Sad but true, I was using 5.5.0 so was unable to reproduce your error until I updated to 5.5.1.
I guess that we are the ones that should update our code. We just updated from Blade::directive to use the afterResolving like two weeks ago, but from what it seems, the proper way to do it is NOT using afterResolving, that from my understanding should work just fine, I guess something somewhere will be fixed that will work both ways without errors, for now I think we just need to stick with the "most common practice".
I am going to create the PRs to other packages we have that are using afterResolving, atmost this will be fixed tomorrow, so I guess we have a plan. Will try to make it happen today, for now use 5.0.0, since the only change in 5.5.1 was that blade directive change.
Thanks again guys!

https://github.com/erikn69/permission-issue/commit/5118f89811489dee0ac275af08b7d7b7339799dd
I did test spatie/laravel-permission 5.5.1 with this package and everything works

Answered with steps to reproduce the scenario where it doesn't work. Thanks!

Let's close this in favor of https://github.com/spatie/laravel-permission/pull/2048 - I hope Freek will find the time to merge it soon 👀😅

Thanks a lot for the time you all spend on this, guys... It was one of those damned things that's difficult to pinpoint... But it's better fixed upstream.

@olipayne I ended up doing a lot of what you did... in https://github.com/DigitallyHappy/assets/pull/13 ... with 3 letters change. Sorry I didn't merge yours 🙏


websocket_transport::disconnect could call m_receive_loop_cts.cancel() during assignment

The m_receive_loop_cts = receive_loop_cts; line in websocket_transport::connect seems to temporarily clear the cts pimpl. If m_receive_loop_cts.cancel() is called during the assignment, this might lead to an attempted null pointer dereference.

Fixed as part of reconnect work e41a8ff - the assignment is now being done in a lock


Pre configured topologies

[x] force graph to recalculate node position
[x] table list showing edit and download buttons for preconfigured topologies
[x] downloadable topologies
[x] convert preconfigured topologies to savednetwork that can be edited in the canvas
[x] fix: all preconfigured nodes are highlighted
[ ] flow: users can go back to select another topology without going back to homepage

LGTM!, was able to test it on local, and i did like the feel, just had a minor issue zooming on barabasi_albert_graph

yeah, there's a max zoom from react-flow


SCM diff decorator - modified diff decorator with a pattern

Fixes #142809

The decorator pattern looks corrupted on 1.66.0


Add property:skip.exec.plugin

Context
Refer to bug in this comments by @edburns .
In order to address the issue in the comments, one way we can do is to add a property in the azure-javaee-iaas, in this way, the weblogic-azure will be able to configure to skip some unnecessary maven plugin execution steps which contains errors.
Description

Add a property skip.exec.plugin to enable the ability to skip the plugin:exec-maven-plugin.
Upgrade version.

LGTM


Deploy ARM Buyback

Deploy
contracts/deploy/mainnet/107_arm_buyback.js
Contracts

Contract
Address

ARMBuybackProxy
0xBa0E6d6ea72cDc0D6f9fCdcc04147c671BA83dB5

ARMBuybackImpl
0x296cd04A97cBd7fc297C9c27D9FEE705077F1F83

Diffs
# Proxy
sol2uml diff 0xBa0E6d6ea72cDc0D6f9fCdcc04147c671BA83dB5 .,node_modules -n mainnet

# Implementation
sol2uml diff 0x296cd04A97cBd7fc297C9c27D9FEE705077F1F83 .,node_modules -n mainnet

Governance

No Proposal, only contract deployment.

Deploy checklist
Two reviewers complete the following checklist:
- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

I've verified the deployment

[x] All deployed contracts are listed in the deploy PR's description
[x] Deployed contract's verified code (and all dependencies) match the code in master
[x] The transactions that interacted with the newly deployed contract match the deploy script.

[x]  initialize proxy
[x] initialize ARMBuyback

[x] Governance proposal matches the deploy script

no proposal

[x] Smoke tests pass after fork test execution of the governance proposal

sol2uml diff 0xBa0E6d6ea72cDc0D6f9fCdcc04147c671BA83dB5 .,node_modules
Compared the "ARMBuybackProxy" contract with address 0xBa0E6d6ea72cDc0D6f9fCdcc04147c671BA83dB5 on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/utils/Address.sol
match   contracts/governance/Governable.sol
match   contracts/proxies/InitializeGovernedUpgradeabilityProxy.sol
match   contracts/proxies/Proxies.sol

sol2uml diff 0x296cd04A97cBd7fc297C9c27D9FEE705077F1F83 .,node_modules
Compared the "ARMBuyback" contract with address 0x296cd04A97cBd7fc297C9c27D9FEE705077F1F83 on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   contracts/buyback/AbstractBuyback.sol
match   contracts/buyback/ARMBuyback.sol
match   contracts/governance/Governable.sol
match   contracts/governance/Strategizable.sol
match   contracts/interfaces/chainlink/AggregatorV3Interface.sol
match   contracts/interfaces/ICVXLocker.sol
match   contracts/interfaces/ISwapper.sol
match   contracts/utils/Initializable.sol

[x] All deployed contracts are listed in the deploy PR's description
[x] Deployed contract's verified code (and all dependencies) match the code in master
[x] The transactions that interacted with the newly deployed contract match the deploy script.

No governance, so no governance checked


chore: adds XLayout component

Adds a XLayout component for laying out multiple components.
XLayout currently comes with two types of layout: stack and separated

stack is the same as what div class="stack" does, renders the contents vertically with a gap in-between each item.
separated is the same as the layout we use when rendering multiple badges and renders the contents inline/horizontally with a gap in-between each item.

We currently use <div class="stack"> (and others div/class things) to lay out certain components. This uses <XLayout type="stack"> to do exactly the same thing. But formalises it in the fact that is no longer just a div and a class, its a very simple component that you can use inline in your template with auto-complete-able layouts.
Another advantage is that we are making all our layouts consistent. For example, and specifically added in this PR, the margin between our tables and pagination is now shared with other "stacks". The margin is no longer a property (under the ownership) of a KTable, it's now owned by an XLayout. This way we can guarantee that the margin used for separating other components is exactly the same as the margin that separates a KTable/KPagination, previously we would have to guess/investigate what the margin was that was being used inside of KTable.
For separated, TagList currently uses this rule as CSS, but I'd like to be able to use it to render lists of TargetRef components, Label components, or maybe just Badge components. The idea is we can now re-use this simple layout via a composable layout component.
Lastly, I haven't refactored everything to use this as yet, I can do that in a follow up PR.

Sorry! Just spotted one tiny extra thing here so popped another commit on the end.
I realized in adding XLayout to DataCollection, it would space the child content of the DataCollection (in our case the PolicyTypeListing).
I added a wrapping div around the contents of the default slot of the DataCollection to avoid this.

Separately I noticed our PolicyTypeList is a bunch of divs when it should actually be a ul li or similar.


feat: Replace graphviz with d3

This eliminates the datatracker's dependency on graphviz, by using d3 to draw the document dependency graph.

Need to figure out why @rjsparks sees different data in the graphs, and why Chrome doesn't like my SVG.

@rjsparks maybe gives this another look?

I'm not getting any hover effects on the graph or the legend, even after a complete rebuild. I'll ask Nick to look.

I'm not getting any hover effects on the bubbles either.

This doesn't look right, but I think we're close enough to bring it in, and can address this (and some protonopia issues I have with the colors) later.


Relative translations don't work in initializer

This is similar to #74
If I have an initializer and I use the translation helper, then I get the error:
Cannot use t(".link_text") shortcut because path is not available

This happens even after calling super
If I move the translation into an instance method, it works as expected.
Using view_component-2.75.0, rails-7.0.4, ruby 3.1.0

@jcoyne thanks for filing this issue. Might you be up for writing a PR with a failing test? Perhaps @elia could have a look, then.

This is expected, although I agree would be great to have them working in the initializer as well.
The reason it works as an instance method is that the method is most likely called after initialization and compilation of the component. Happy to review any proposal to make it work from the get go tho 🙌

@jcoyne given @elia's response, are there any documentation changes you think we should make?

I suppose some warning in the documentation would be nice. I'm not at all clear why this timing concern exists. Maybe an explanation about that?

@jcoyne perhaps we could just add a warning for now? Like this test case: https://github.com/ViewComponent/view_component/blob/c9b7d36e5dd2a043b20756cf5a6bdef3d3463902/test/sandbox/test/base_test.rb#L37. We could also add something to the docs.

@joelhawksley that would be really helpful

@jcoyne cool. Would you be up for writing a PR? I can help clean up language if you get something started ❤

No, because I don't understand the order problem were seeing. I don't understand what the compile step is or what that does.


Feature: implement MDController base features

This PR includes base features.
IMPORTANT
This version has HARDWARE ISSUE cause CAN FD crash.
In a few days, inspect its causing.
Features

Encoder feature
MD feature
PID feature(vector, scalar)
Thermal sensor
Current sensor
SerialBridge with CAN FD
some small features....

relate to #2


Build stages in the Dockerfile using parallel jobs.

Build stages in Dockerfile using parallel jobs.
Our Dockerfile takes too long to compile. For example, the most recent workflow run for main has one job which is about to exceed the 6 hour execution limit. Fortunately, multi-stage builds and caching can help us split work across separate jobs. This pull request implements such functionality.
The Dockerfile has been split into multiple stages:

llvm
intel-graphics-compiler-and-compute-runtime
openblas
other-dependencies
final-image

The dependency structure is as follows (a -> b means b depends on a):
llvm -> intel-graphics-compiler-and-compute-runtime
llvm -> final-image
intel-graphics-compiler-and-compute-runtime -> final-image
openblas -> final-image
other-dependencies -> final-image

The last one, final-image is the name of the stage which copies all the files together from the other stages
and produces a working container. other-dependencies is for dependencies that are quick to build.
For each pull request, there are now the following images pushed to docker:
- nubots/nubots:pull-request-123-llvm
- nubots/nubots:pull-request-123-intel-graphics-compiler-and-compute-runtime
- nubots/nubots:pull-request-123-openblas
- nubots/nubots:pull-request-123-other-dependencies
- nubots/nubots:pull-request-123-final-image
If you want to checkout a particular pull request, then pull the final-image one like so:
docker pull nubots/nubots:pull-request-123-final-image

Builds for the main branch are more complicated because of limitations with calling Github Reusable Workflows and the need to build across multiple platforms. For nuc8i7beh platform, the workflow images.yaml would build and publish the following images:

nubots/nubots:nuc8i7beh-llvm
nubots/nubots:nuc8i7beh-intel-graphics-compiler-and-compute-runtime
nubots/nubots:nuc8i7beh-openblas
nubots/nubots:nuc8i7beh-other-dependencies
nubots/nubots:nuc8i7beh
Typically, the last image is the one that you want to inspect, because it contains all of the dependencies in /usr/local/.

Workflows and Reusable Workflows
build_part_of_image.yaml and build_part_of_image_all_platforms.yaml are both reusable workflows and build one stage for a set of platforms. build_part_of_image.yaml builds a stage using the caches and then publishes the image to docker. build_part_of_image_all_platforms.yaml is similar except it uses a strategy matrix to build for the three platforms.
nubots.yaml is triggered during a pull request. The dependency structure is laid out so jobs are queued in the right order and building an individual stage uses the appropriate cache. I've set it up to use nubots/nubots:generic, and nubots/nubots-pull-request-123-<stage>. This way, a build can use the cache of the main branch, as well as the cache for the pull request.
images.yaml does a similar thing to nubots.yaml except over platforms too. This impacts which caches can be used. For example, it would be invalid to use llvm built for generic as a cache when building the intel-graphics-compiler-and-compute-runtime stage for the nuc8i7beh platform. So that's why you see {0} in the cache-from fields in that file.
Finally, note how images.yaml uses build_part_of_image_all_platforms.yaml.
Why build_part_of_image.yaml and build_part_of_image_all_platforms.yaml? They look the same.
It would have been possible for me to only use one reusable workflow, however one would have needed to use a conditional (if statement) to switch between a job which builds for one platform, and a job which builds using a strategy matrix. There are a few approaches but all seemed awkward:

You could use conditional to switch between the two jobs, however doing so would introduce 5 new skipped in the checks UI during a pull request. I think this clutters the interface.
You could set matrix.platform based on an input to the workflow. However you'd need to parse json blobs because you can't pass an array as an input to a reusable workflow.

Pre-PR Checklist:

I'm not going to update the NUbook until this pull request is accept and is shown to work.
I can't add tests for my changes.

Looks good mate. Has this been tested yet?

Thanks 😊. What do you mean by tested? The checks pass?

Thanks 😊. What do you mean by tested? The checks pass?

You can test the actual workflow by changing the target branch from 'main' to your branch name, so 'thompson/parallel-builds'.
Then create a 'dummy' branch off of your branch that you can merge back in (you will need to make some kind of code change for this to actually work, i usually add a comment before making the test branch), to trigger your workflow.
Now i'm not too familiar with how dockerhub works; Would doing this overwrite our existing image or are there releases/versions?

Thanks 😊. What do you mean by tested? The checks pass?

You can test the actual workflow by changing the target branch from 'main' to your branch name, so 'thompson/parallel-builds'. Then create a 'dummy' branch off of your branch that you can merge back in (you will need to make some kind of code change for this to actually work, i usually add a comment before making the test branch), to trigger your workflow.

Right. I tested it on my own repository here. The workflow that was triggered on main passed too. There was one workflow that didn't work correctly... docker Hub Cleanup failed returning:
{"detail": "access to the resource is forbidden with personal access token"}

I'm assuming that was because I have a free account (which is limited to one PAT).

Now i'm not too familiar with how dockerhub works; Would doing this overwrite our existing image or are there releases/versions?

Yes, merging into main will override the images on docker hub, but only after the images have built successfully. I see two options if you're concerned about this not working:

Tag the image locally and rely on docker hub remembering the image. This is likely to work because the other pull requests reference similar image layers.
Creating another branch and testing it prior.

Thanks 😊. What do you mean by tested? The checks pass?

You can test the actual workflow by changing the target branch from 'main' to your branch name, so 'thompson/parallel-builds'. Then create a 'dummy' branch off of your branch that you can merge back in (you will need to make some kind of code change for this to actually work, i usually add a comment before making the test branch), to trigger your workflow. Now i'm not too familiar with how dockerhub works; Would doing this overwrite our existing image or are there releases/versions?

Okay. I think I see what you were getting at here. I just tried testing workflow the way you said. It was going to overwrite our important image tags on docker hub. It's not really a limitation of docker, but of Github actions. You'd need to take into account the different circumstances that the workflow is being ran in and specify a unique image tag. For example:

pull-request prefix for pull requests.
nubots, nuc8i7beh, and nuc7i7bnh for main images.
nubots-my-test-branch, nuc8i7beh-my-test-branch, and nuc7i7bnh-my-test-branch for testing that the workflows that run against main work correctly without actually running them on main (and pushing image tags which overwrite previous ones).

I'd suggest that we merge this code into main. I don't think it's worth adding the logic to the workflow files when they are already complicated enough. This type of thing doesn't happen very frequently, and we can get away with fixing up anything if/when it breaks.

@Crafty15 do we still have issues hitting the 6 hour mark? This could be worth looking at?

@Crafty15 do we still have issues hitting the 6 hour mark? This could be worth looking at?

I was about to say "not that i've seen", untill i saw : this
So yeah, def worth dusting this one off.

I think there should be a better way of doing this, This is going to greatly increase the complexity of the docker system and make it much harder to work with.

A quick solution could be to setup build agents on computers in the lab? I believe that would give a 72 hour build time limit with the current GitHub subscription, and wouldn’t require any changes to the Dockerfile to get working.
In hind sight I probably over thought this pull request… It is a painful experience working with slow build times because the Dockerfile sometimes rebuilds tools which you aren’t working on.


Use hex for the Debug output of Float32/Float64

When visually comparing the output of failed assertions (e.g. "expected = ..., actual = ..."), it is much easier to compare float values as hex than their unsigned integer representation. Optimally we would use actual floats in the output but this is fraught since sometimes it is necessary to do a bit-by-bit comparison. Instead, a hex representation shows the bits and avoids a manual "decimal-to-hex" conversion.

@alexcrichton, this is one part of an attempt to fix https://github.com/bytecodealliance/wasmtime/issues/1681 over in Wasmtime. I'm not sure why the Cargo.lock file changed... I didn't really do anything except run cargo test.

I'll probably need a version bump to import into Wasmtime--should I do that here?

I fixed this with https://github.com/bytecodealliance/wasmtime/pull/2475, closing...


Android Client fail to unlock if code starts with a zero

Describe the bug
The latest Android application fails to unlock the client if the code starts with a zero.
To Reproduce
Install the application
Open Settings
change the Security Code to e.g. 0101
Close out of Settings
Re-open Settings
Enter the above Security Code
Smartphone (please complete the following information):

Device: OnePlus 6
OS: Android 10
Application version: v1.1.2. Build 0

BTW: The version number is no longer in Settings - Version, but it Settings - About.

Ok will check

I experienced this too.


Unable to Import data

I've loaded Gekko for the first time according to the instructions. I select the local data tab and using the default values, I select the import button. I receive an error message. See attached. The error message says I should run the command, "npm install<EMAIL_ADDRESS>I run the commands as stated and receive other errors. See attached. Short version:  I really need help installing sqlite so I can get past this error message. Please help

I figured it out myself


‘SettingsDlg’ lines 67-68 repeat for “CmbInitialPowerScheme”.

‘SettingsDlg’ lines 67-68 repeat for “CmbInitialPowerScheme”.
I did a git push via ‘vs’, but I don't know if it works.

I'm not sure if you're up to date with the current main.
Line 67-68 of SettingsDlg.cs are:
  var index = CmbColorTheme.Items.IndexOf(Settings.Default.ColorTheme);
  if (index != -1 && index < CmbColorTheme.Items.Count)
I checked it right here on github. You might need to pull changes from the remote.

I made a mistake. It should be lines 38 to 42.

Okay, I see now.
Yeah, seems like I forgot to remove the previous code when I refactored. I will fix it.
Be warned: I'm in the process of finishing up a rework for the AC / PowerLine handling. Instead of configuring those directly, they will be a type of rule the user can create. Though I'm not done yet. I need to finish up some tests.

Released version <IP_ADDRESS>: https://github.com/SebastianBecker2/PowerPlanSwitcher/releases/tag/v<IP_ADDRESS>
The issue should be fixed in that version.


modifier+key action shows also key action as pressed

Godot Master
https://godotengine.org/qa/28199/how-to-use-shortcuts-with-modifier
I am looking for something like this I thought godot checks this internally. Try to press CONTROL+S.
Expected result CONTROL_S
func _process(event):
    if Input.is_action_just_pressed("CONTROL_S"): # KEY_CONTROL+KEY_S
        print("CONTROL_S")

    if Input.is_action_just_pressed("S"): # KEY_S
        print("S")

# Output: CONTROL_S and S

This works but I can't use it in my case
func _process(delta):
    if Input.is_action_just_released("CONTROL_S"): # KEY_CONTROL+KEY_S
        print("CONTROL_S")

    if Input.is_action_just_released("S") && !Input.is_action_just_released("CONTROL_S"): # KEY_S
        print("S")

# Output: CONTROL_S

How would you solve that? Go though Input action list and ignore other actions if there is 'direct match'?

If such a check is possible, that would probably solve it.
Someone one irc suggested to add a flag for these cases. If that behavior I described is intended you would have to activate the flag for the specific actions.

Someone one irc suggested to add a flag for these cases. If that behavior I described is intended you would have to activate the flag for the specific actions.

That's probably the best way. Many times you don't want a modifier key to shadow an action without modifier, e.g. pressing Space to jump should work even if you are holding Shift to run.

Yeah thats true.
I have no idea how the actions work internally in the example the shadow should only happen when an actual action exists for mod+space otherwise they are simply 2 separate actions mod=run and space=jump but when mod+space=superjump only run will activate and superjump will happen once space is also pressed.
If that is only possible with a flag thats fine too.

That's assuming Shift+Space replaces jump. If the action is used for something on UI, for instance, then this automatic detection will fail.
I believe there are use cases for both, so it should be a flag per-action.

If an InputMap is going to abstract the keys for me, then it should do the work of filtering and fire exclusively based on most specific matching.
My code should not know or care whether ui_focus_next or ui_focus_prev has more or less specific keys, whether they use modifiers or duplicate keys, or what order they should be in, as that defeats the whole purpose of the InputMap and abstracting the keys for me.
ex.

ui_focus_next -> S
ui_focus_prev -> Control+S
Pressing control+s should result only in ui_focus_prev.

ex2.

shift -> run
space -> jump
shift+space -> super jump
Pressing shift+space should result in run, then super jump. If the third mapping is removed, then it should result in run, then jump.

I just ran into this, and was about to file a bug.
In my case it's an App with a complicated UI, not a game, and there will be tons of such conflicts, i.e:
Z: Play C4 Note on piano
Ctrl+Z: Undo
But Ctrl+Z Plays the note AND performs undo.
Since there are two piano octaves available via keyboard... yeah, there will be a ton of conflicts. 😅
Filtering it myself would be a lot of work prone to bugs, since there's no central "UI Control" script and each part of the UI is a sub-scene and manages itself, not aware about where the conflicts may happen in other scenes. Allowing the Input system to perform this filtering as it's being suggested would be much, much welcome.
Maybe an "Exclusive" checkbox column in the Input Map editor would cover most of the cases, and stay simple enough? Checking it would only fire the action if that key, and only that key, is pressed.
Thanks!

More Information about this bug is in #44180.
I found where the problem code is. I will have to fix this very soon as it is required for #43663 to be merged

Reproducible in Godot 4.1
It can be worked around with an elif setup in the correct order but figured might as well report this
Sample project: https://drive.google.com/file/d/176GERr0Lba_PfpjPdpepBfQg24ZYtmJK/view?usp=sharing
Pressing ctrl+A in the project triggers the action for a standalone A press

I've also just run into this. Not having a way to require that a modifier key not be pressed means that I will apparently need to write my own input controller code and cannot use the one integrated with the engine if I will allow players to configure these controls. This seems like a pretty serious piece of missing functionality.

This seems like a pretty serious piece of missing functionality, or a serious regression if this was working before.

Just to confirm, are you saying that you still get modifier when the exact match parameter of Input.is_input_pressed(), etc. is true?


feat: add anchor state registry

Description
Adds the concept of the Anchor State Registry to the spec for the Fault Dispute Game.

One thing worth noting is that this new contract means that the anchor state can be updated even if the game type being played is not the respected game type. Any suggestions on how this should be handled, if at all? Primary concern would be a situation something along the lines of:

DisputeGameFactory owner adds new game type
Game type isn't respected so challenger doesn't react to it
People start playing this game type and finalize incorrect states
Game type becomes respected
New games use a bad anchor state

One thing worth noting is that this new contract means that the anchor state can be updated even if the game type being played is not the respected game type. Any suggestions on how this should be handled, if at all? Primary concern would be a situation something along the lines of:

DisputeGameFactory owner adds new game type
Game type isn't respected so challenger doesn't react to it
People start playing this game type and finalize incorrect states
Game type becomes respected
New games use a bad anchor state

I think we shouldn't be concerned with this. Or at the very least, the FDG shouldn't be concerned with the portal or respectability.
A game type should be considered either correct or not. If it yields invalidly finalized claims, then the user shouldn't reuse that game type for the portal. This way the DGF can easily support non-portal usecases.

In terms of dealing with invalid prostates that may be added, should we allow the guardian to set a prestate manually? That would also allow bootstrapping a new game type without the first game having to be played from genesis.

Although I guess you could also do that through the fault dispute game contract as well where it still has a hard coded starting block and refuses to use a prestate from the registry prior to that.  That's a lot cleaner than needing to override the registry and avoids a lot of potential race conditions.

Which summarises to - LGTM!. :)


Training error!

I generated the image, video, and mfcc file according to the procedure you provide, thanks. But the code generates the following error during training. Could you help,please.

Did you also provide the annotations?
You might want to have a read through https://github.com/tuanchien/asd/issues/2 as it seems like you are trying to accomplish something similar.

Did you also provide the annotations?
You might want to have a read through https://github.com/tuanchien/asd/issues/2 as it seems like you are trying to accomplish something similar.

I generate only training and test annotation pkl files are those files expected to be generated before training?

I generate only training and test annotation pkl files are those files expected to be generated before training?

Solve, Thanks!

Solve, Thanks!


Is error the right default?

Right now, only errors are shown by default.
I would assume at least warnings would show up.  Probably also info(rmational) messages.
Of course, this requires adding a way to make things quieter (which we might need already, see https://github.com/rust-clique/clap-verbosity-flag/issues/9).  We'd probably need a --quiet  / -q flag to go the other way.

We'd probably need a --quiet / -q flag to go the other way.

Sounds reasonable.

Right now, only errors are shown by default.

Personally I'd expect anything up to log level info to show up by default. I feel that's how git(1), cargo(1) and chrome's console work too.

I think that there is no right default log level for all applications (but do think that "error" is only rarely a good default), and it might make sense to have that configurable by the application (eg. using a type parameter).
For cargo and other do-many-things tools, chatting along their actions (which is what "info" is commonly used for) is probably a good idea and default; single action Unix tools might rather follow the rule of silence.

I would suggest closing this as resolved. The -q is helpful and error is okay as default level.

I think UNIX philosophy would say error or even no log is the correct default. But newer clis are quite a lot verbose cargo, npm are like at info level?
It depends on the tool, its intended users, …
So I think anything from error to info are a good default, now that it is configurable, -q and -v exist. The developer and user can customize their preferred behavior as needed.

I was hoping to be able to have this default to Off :/ I took a look at the code to see why there wasn't an option already, and took a stab at adding the option myself.
And there is no Off option for log::Level. In my cli, I want these formatted logs to be exclusively only shown to the user if the -v flag is given, any info that the user would need to see in general would be through !println or eprintln!.
Is there any way to achieve this type of functionality?
My failed attempt:
#[derive(Debug)]
pub struct OffLevel;

impl LogLevel for OffLevel {
    fn default() -> Option<tracing_log::log::Level> {
        Some(tracing_log::log::Level::)
    }
}

I was hoping to be able to have this default to Off :/ I took a look at the code to see why there wasn't an option already, and took a stab at adding the option myself.
And there is no Off option for log::Level. In my cli, I want these formatted logs to be exclusively only shown to the user if the -v flag is given, any info that the user would need to see in general would be through !println or eprintln!.
Is there any way to achieve this type of functionality?
My failed attempt:
#[derive(Debug)]
pub struct OffLevel;

impl LogLevel for OffLevel {
    fn default() -> Option<tracing_log::log::Level> {
        Some(tracing_log::log::Level::)
    }
}

Right after I posted this I looked deeper at the code and figured it out! If you are welcome to contributions I could add this to the library to allow defaulting to off?
#[derive(Args, Debug)]
pub struct SharedArgs {
    #[clap(flatten)]
    pub verbosity: clap_verbosity_flag::Verbosity<OffLevel>,
}

#[derive(Debug)]
pub struct OffLevel;

impl LogLevel for OffLevel {
    fn default() -> Option<tracing_log::log::Level> {
       None
    }
}

In addition to this, I would also like to add to the docs on how to change the default level, it wasn't immediately clear to me how to do this, it took some digging

If you are welcome to contributions I could add this to the library to allow defaulting to off?

While we would welcome the contribution, we need to discuss whether having a q argument makes sense for the CLI author if they want to default to OffLevel. But we can discuss this on the PR you make.

I would also like to add to the docs on how to change the default level

You can also customize the default logging level:

There's this sentence directly on the main page of docs and in README. Not sure, what else you mean by this. But you can make a PR and I can review it.

To help in supporting an OffLevel, we could do add the following attributes to quiet

value_parser that is assigned to a function that conditionally returns UnknownArgumentValueParser when L::default().is_none()
hide(L::default().is_none())

quiet might also be helpful to overriding -vs that are already present, whether for hitting the up arrow and running again or if you have the command behind an alias.

I opened a pr https://github.com/clap-rs/clap-verbosity-flag/pull/95 for adding the OffLevel, in addition to DebugLevel, TraceLevel so all the options are available. I also added a simple example of changing the default Level.

There's this sentence directly on the main page of docs and in README. Not sure, what else you mean by this. But you can make a PR and I can review it.
@pksunkara I saw this sentence, I'm not entirely sure what I was expecting the way to do this to be, but seeing this example just didn't click. I added an example to make it extremely obvious comparing to the default behavior 🙏🏼.

I saw there were some suggestions around the -q flag behavior and if it should be available with the default level to off, personally, for my cli I wouldn't mind if this flag was still present. But I see it could make sense to remove for possible confusion.
Maybe I could just make my example more tailored to adding your own level by implementing the LogLevel trait? And then users can add their own levels if they need Off, Debug, or Trace?

If I specify Info to be my default log level, how would a user be able to change that to a less verbose output, e.g. switch back to error? It seems to me that specifying -v (warn) on an app that defaults to info just ignores the -v flag.


Show BCD mapping progress on front page

This is a temporary feature. The plan is to manually update the score in the storage bucket and have the frontend query that.
App deployers will have to update the score manually. This should only last through December.
The BCD mapping progress will be hosted in a publicly exposed GCS bucket. The changes modify the frontend configuration so that the URL for json is passed in. We add a new WEB_FEATURES_PROGRESS_URL environment variable. This is where app deployers can configure the setting. (Just like the other frontend settings)
The data will have the following form: {"bcd_map_progress": number}
Users will see this percentage on the overview page. When the mapping is complete, we can turn off the feature by setting the body to {"is_disabled": true} in the GCS bucket.
Architecture of changes:
webstatus-overview-content
This is the visual component that we added the percentage to. This is responsible for the presentation layer for this change via a new renderMappingPercentage.
webstatus-webfeature-progress-service
This is a new service that maintains the business logic to get the data from the GCS bucket. It communicates to consumers via a new context webFeatureProgressContext. While webstatus-overview-content is the only consumer, we could easily support other visual components by having them consume the data from the context. And each of those visual components can have their own presentation.
Other changes:

Automatically populate the local GCS emulator with a bucket called webfeatures on startup. The bucket has a file called progress.json like staging and prod.
Modify Makefile to forward the ports to the GCS emulator.
Make GCS emulator a pre-requisite for the frontend to come up by modifying frontend/skaffold.yaml
Adding instructions that the app deployer will need to follow to update the value

The idea is to remove the code but we can easily turn this feature off while we wait for the next engineer to do the deployment (or if we need to turn it off beforehand for any other reasons)

but we can easily turn this feature off while we wait for the next engineer to do the deployment (or if we need to turn it off beforehand for any other reasons)

What's the procedure to disable showing this text?

but we can easily turn this feature off while we wait for the next engineer to do the deployment (or if we need to turn it off beforehand for any other reasons)

What's the procedure to disable showing this text?

Good question. I have added instructions to the DEPLOYMENT.md on how to handle this


Resolve performance issues

There is a ton of logging happening in release builds in certain classes. This is especially impactful in DNSIncoming as well as ListenerStatus. We may want to provide a way, at runtime, of either completely disabling logging or ignoring log method calls that don't reach a certain level.
Also, we should evaluate the levels that each log message is using. Not sure that https://github.com/openhab/jmdns/blob/master/src/main/java/javax/jmdns/impl/DNSIncoming.java#L293 needs to be severe, and is causing problems on a network with Chromecast devices.

Seen similar problems with macbooks coming on the network - anything ever tracked down here?

Same with AppleTV.


Core v2 monitor query

transitioned to core v2 for monitor query
Made changes to the 2 clients for token credential,etc
Important : Need to figure out how to do the double encoding of the response  workaround for the service bug now that we don't support _response or bodyAsText. Do these workarounds for both convertGeneratedTable and fixInvalidBatchQueryResponse

generated/models/index.ts still has core-http :(

Spoke offline with @KarishmaGhiya . This(presence of core-http) looks like a bug. Will take this as a priority and fix it today.


[Android] Fix IllegalStateException crash in WebSocketModule.java

Motivation: The WebSocket implementation on Android crashes the app when an attempt is made to write on a web socket that was closed due to a spotty connection. We found this issue by using Pusher, which is built on WebSockets. The following stack trace reveals that the WebSocketModule doesn't catch the case of a closed connection, when a consumer attempts to write:

Fatal Exception: java.lang.IllegalStateException: closed
       at com.squareup.okhttp.internal.ws.RealWebSocket.sendMessage(RealWebSocket.java:109)
       at com.facebook.react.modules.websocket.WebSocketModule.send(WebSocketModule.java:176)
       at java.lang.reflect.Method.invoke(Method.java)
       at java.lang.reflect.Method.invoke(Method.java:372)
       at com.facebook.react.bridge.BaseJavaModule$JavaMethod.invoke(BaseJavaModule.java:249)
       at com.facebook.react.bridge.NativeModuleRegistry$ModuleDefinition.call(NativeModuleRegistry.java:158)
       at com.facebook.react.bridge.NativeModuleRegistry.call(NativeModuleRegistry.java:58)
       at com.facebook.react.bridge.CatalystInstanceImpl$NativeModulesReactCallback.call(CatalystInstanceImpl.java:428)
       at com.facebook.react.bridge.queue.NativeRunnableDeprecated.run(NativeRunnableDeprecated.java)
       at android.os.Handler.handleCallback(Handler.java:739)
       at android.os.Handler.dispatchMessage(Handler.java:95)
       at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31)
       at android.os.Looper.loop(Looper.java:145)
       at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:184)
       at java.lang.Thread.run(Thread.java:818)

Test Plan: Create a WebSocket connection and attempt to write after the connection became unavailable due to a spotty connection. An easy way to do this is to establish a Pusher connection with pusher-websocket-iso/react-native and fake or force a spotty connection.

@satya164 thanks for the quick review. Made the change.

Thank you. Will merge as soon as the tests pass :)

@facebook-github-bot shipit


[InputTag] Using customRenderTag cause react Hook order error / no mapping function to custom data format

[x] I'm sure this does not appear in the issue list of the repository

Basic Info

Package Name And Version<EMAIL_ADDRESS>Framework version: 17.0.2
Browser: chrome102.0.5005.124
Reproduction Link: https://codesandbox.io/s/nervous-currying-qozmqt?file=/demo.js

What is expected?
for issue 1: no error occurs
for issue 2: It is necessary for the user to provide mapping function parameters when passing custom data types to value
For example, the inputTag value allows to be {label: string, value: any}, but at reproducing demo it will callback a string, not an object.

Even though provide labelInValue, it just convert string to {label: string, value: string}, not {label: string, value: T}.
It should ask the user to provide a mapping function: (e: string) => T to map the input string to user's custom data.
Steps to reproduce
for issue 1: running the demo and waiting for setTimeout to take effect.
for issue 2:
1, remove line27
2, input something into component
3, see console output

Sorry for issue 1 is my mistake, the render is a renderFunction but not FunctionalComponent, so we can fix it in the below way.  link to code sandbox

btw, By issue 2 is resolved, so the issue should be closed currently


Improve code style (part 2)

Codecov Report
Patch and project coverage have no change.

Comparison is base (efa760c) 100.00% compared to head (328e6f0) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #321   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           12        12
  Lines         1292      1292
  Branches       146       146
=========================================
  Hits          1292      1292

Files Changed
Coverage Δ

src/redcat/tensor.py
100.00% <ø> (ø)

src/redcat/tensorseq.py
100.00% <ø> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Stop using HTTPClient

HTTPClient/LibCurl doesn't pass tests on 0.4, not that this branch ever gets used I guess.

This would leave temp file litter around and never clean up after itself?

On OSX Base.download puts into a temporary files folder that OSX cleans, I'm not sure what Linux behaviour is.

(this is really a drive-by PR, I was just reminded of this by the 'cycle' it induces while updated MetadataTools.jl)

Bump @tkelman. Any reason to believe this wouldn't be an improvement for the better?

Because Base.download is pretty limited, you're totally faking the return code, and not cleaning up temporary files.


An error while opening the GT debugger should open an minimal emergency debugger

Currently an error while opening the debugger is handled through the Morphic emergency debugger. There should be an emergency debugger at the GT level to handle errors while opening the GT debugger.

An error while opening the debugger opens an emergency debugger.


Feature Request

Better way to automate/dispose seeds in harvesters. The seeds fill up very fast and spout everywhere. even something as simple as deleting excess seeds from spawning once the harvester reaches a fiull stack would be nice.

Hi,
Thanks for bringing it up! This was something I'd planned to do, but guess it got lost in the pile.
I think my plan was to have ~4 output slots + 1 seed input slot, with the seed input autofilling. When the seed slot is full, excess seeds go into the 4 output slots (where they can be automated out). If everything is full I think the Harvester would just shut down.
How does that sound? 😁

This should be implemented as of 1.2.18-beta. Thanks again for making the bug report/suggestion, it's very helpful indeed 😍


File URL path must be absolute

HI,
I'm using Jest version 26.0.1. When running Jest I get an error: "TypeError [ERR_INVALID_FILE_URL_PATH]: File URL path must be absolute". I run this on the network drive. Locally it works fine. The issue with network drives should be fixed in this version. I made all the paths absolute, but the error persists. What am I missing?
Node versions: 14.4.0
OS: Win 10

I'm running into this issue as well in 26.1.0. The project is on a mapped network drive but returning the error above.

Up!

This issue doesn't follow the issue template. Please open up a new issue that does (https://github.com/facebook/jest/issues/new/choose).


master not working?

Is there going to be a new release soon?

I pinged @posativ in #382 about it, but no answer yet. He is very busy and that's why @jelmer and I had write access to the repo, but only @posativ can release.
So for now no release planned, no date to communicate. In the mean time you can clone the master branch or using pip: pip install git+git://github.com/jkbr/httpie.git (Yes I know it does not solve the problem)

Ah, thank you. Is master stable enough for production use?

The current HEAD is stable. But if you plan to do some pip update regularly it may break even though we are careful about that when merging to master.

Ah, I'll pin to the latest commit then, thank you.

Ok, I'll close this and try to ping @posativ more privately for a release.

@blatinier Unfortunately, the latest HEAD doesn't work for me. It had problems parsing the defaults.ini (it's not an actual ini file) and, for some reason, embed.min.js cannot be found either. Now my comments aren't showing at all.

Can you provide us with some stacktrace and the default.ini file maybe.
Did you build the javascript files using make js?

Here's the traceback:
root@32e270eae1a0:/code# isso
Traceback (most recent call last):
  File "/usr/local/bin/isso", line 11, in <module>
    load_entry_point('isso==0.10.7.dev0', 'console_scripts', 'isso')()
  File "/usr/local/lib/python3.6/site-packages/isso/__init__.py", line 234, in main
    join(dist.location, dist.project_name, "defaults.ini"), args.conf)
  File "/usr/local/lib/python3.6/site-packages/isso/config.py", line 130, in load
    parser.read(default)
  File "/usr/local/lib/python3.6/configparser.py", line 697, in read
    self._read(fp, filename)
  File "/usr/local/lib/python3.6/configparser.py", line 1080, in _read
    raise MissingSectionHeaderError(fpname, lineno, line)
configparser.MissingSectionHeaderError: File contains no section headers.
file: '/usr/local/lib/python3.6/site-packages/isso/defaults.ini', line: 1
'../share/isso.conf'

Here's a Dockerfile that reproduces this:
FROM python:3.6
ENV PYTHONUNBUFFERED 1

RUN pip install -U pip pipenv
ADD Pipfile* /code/

WORKDIR /code
COPY . /code/
RUN pipenv install --system

The file I install from is https://github.com/posativ/isso/archive/0ff39017c6fab706a5e616f2a9a8645603ee4698.zip
I didn't run make.js, at which point after the pip install do I need to do that?

You should run isso with a proper config file (using -c option).
See https://posativ.org/isso/docs/quickstart/#running-isso for running command.
See https://posativ.org/isso/docs/quickstart/#configuration for basic configuration and https://posativ.org/isso/docs/configuration/server/ for more details.
Tell me if you have more problems after that.

Yep, same traceback, I just forgot to include it in the command line:
root@27f5233d847c:/code# isso -c isso.cfg
Traceback (most recent call last):
  File "/usr/local/bin/isso", line 11, in <module>
    load_entry_point('isso==0.10.7.dev0', 'console_scripts', 'isso')()
  File "/usr/local/lib/python3.6/site-packages/isso/__init__.py", line 234, in main
    join(dist.location, dist.project_name, "defaults.ini"), args.conf)
  File "/usr/local/lib/python3.6/site-packages/isso/config.py", line 130, in load
    parser.read(default)
  File "/usr/local/lib/python3.6/configparser.py", line 697, in read
    self._read(fp, filename)
  File "/usr/local/lib/python3.6/configparser.py", line 1080, in _read
    raise MissingSectionHeaderError(fpname, lineno, line)
configparser.MissingSectionHeaderError: File contains no section headers.
file: '/usr/local/lib/python3.6/site-packages/isso/defaults.ini', line: 1
'../share/isso.conf'

The config file is:
[general]
dbpath = /data/comments.db
notify = smtp
admin_password = password
host =
    https://www.example.com/

[guard]
require-author = True
ratelimit = 10
direct-reply = 200

[server]
listen = http://<IP_ADDRESS>:5000/

[smtp]
username = SMTP_Injection
password = password
host = smtp.example.com
port = 587
security = starttls
to =<EMAIL_ADDRESS>from =<EMAIL_ADDRESS>timeout = 30

It doesn't seem to use your config file but the default.ini file. Try providing the absolute path to your config file.

You should run isso with a proper config file (using -c option).
See https://posativ.org/isso/docs/quickstart/#running-isso for running command.
See https://posativ.org/isso/docs/quickstart/#configuration for basic configuration and https://posativ.org/isso/docs/configuration/server/ for more details.
Tell me if you have more problems after that.

Same problem:
root@8c08898214fb:/code# isso -c /code/isso.cfg
Traceback (most recent call last):
  File "/usr/local/bin/isso", line 11, in <module>
    load_entry_point('isso==0.10.7.dev0', 'console_scripts', 'isso')()
  File "/usr/local/lib/python3.6/site-packages/isso/__init__.py", line 234, in main
    join(dist.location, dist.project_name, "defaults.ini"), args.conf)
  File "/usr/local/lib/python3.6/site-packages/isso/config.py", line 130, in load
    parser.read(default)
  File "/usr/local/lib/python3.6/configparser.py", line 697, in read
    self._read(fp, filename)
  File "/usr/local/lib/python3.6/configparser.py", line 1080, in _read
    raise MissingSectionHeaderError(fpname, lineno, line)
configparser.MissingSectionHeaderError: File contains no section headers.
file: '/usr/local/lib/python3.6/site-packages/isso/defaults.ini', line: 1
'../share/isso.conf'

You can just run the Docker script to see for yourself, btw, it reproduces pretty reliably.

I did it and it works for me:
 docker build . -t isso:skorokithakis
 docker run -i --rm isso:skorokithakis

Then inside the container:
pip install .
cp share/isso-dev.conf .  # copy the dev (same used for Vagrant) conf
sed -i -e"s/\/var\/isso\/comments.db/\/code\/comments.db/" isso-dev.conf  # modify the db path to point inside a writable place in the container (DO NOT DO THAT IN REAL LIFE, DATA INSIDE A CONTAINER IS EPHEMERAL)
isso -c isso-dev.conf  # run isso, it works...

I'm currently working on a Docker/docker-compose easy setup that I will commit soon (I hope)


question

question:discovery.locator.filters exception
It's configured like this:
gateway:
discovery:
locator:
enabled: true
filters:
- name: Hystrix
args:
name: fallbackcmd
fallbackUri: forward:/fallback
filters throw exception
org.springframework.expression.spel.SpelEvaluationException: EL1008E: Property or field 'fallbackcmd' cannot be found on object of type 'org.springframework.cloud.gateway.discovery.DiscoveryClientRouteDefinitionLocator$DelegatingServiceInstance' - maybe not public or not valid?
why?

Please learn how to format code on GitHub.
That configuration is not valid

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Please learn how to format code on GitHub.
That configuration is not valid
sorry,I replied to you so late.
I configured as follows

spring:
  cloud:
    gateway:
      discovery:
         locator:
         enabled: true
          filters:
          - name: Hystrix
             args:
             name: fallbackcmd
             fallbackUri: forward:/fallback

I try to access a service,throw exception like this:

I trace the code,
exception from org.springframework.cloud.gateway.discovery.DiscoveryClientRouteDefinitionLocator

The table red box gets the value exception.Is that a bug here?

Duplicate of #637

Duplicate of #637

thanks

@ayanjoyful have you solved the problem based on #637? buddy.


dispatch when handling LOCATION_CHANGE action in custom reducer causes triple push to history

Hi,
I found a weird behavior when I need to dispatch another action while handling LOCATION_CHANGE
var changeMiddleware = (store) => {
  return (next) => {
    return (action) => {
    	/** there can be multiple other action types detected who will dispatch TRACK_IT action */
      if (action.type === LOCATION_CHANGE) {
        store.dispatch({
          type: 'TRACK_IT'
        });
      }
      return next(action);
    };
  };
};

The reason for this is to be able to aggregate TRACK_IT actions with rxjs and handle them in bulks.
When I go from page A to page B it will result in following navigation changes:
A -> B
B -> A
A -> B
This only happens with adjustUrlOnReplay: true and only if there is another action dispatched before return next(action)
I have no idea if I have it setup incorrectly or if I'm just doing something wrong.
Fiddle with demonstration is https://jsfiddle.net/akhoegsk/ just click on the 3 links one after one a then click back a few times. It should behave like browser back button but instead it just cycles between the last 2 There are listenBefore and listen handlers setup.
Thank you for any information
Jan

@ptacekj Seems to be due to the fact that the inner store.dispatch is calling a non-enhanced dispatch. See this open bug in redux bug tracker.

This is correct. I would setTimeout there to cause the dispatch to occur after the running dispatch has resolved.


[Feature]: Scroll To Widget Function

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Hello,
I'd like to have a Scroll To Top button or specific section.
Thanks
Why should this be worked on?
Especially on mobile when the list is very long  instead of scrolling .

@tiger360 thank you for the feature request. A good way to solve this would be to allow users to call a function that scrolls to any widget on a page.

This one is similar to #8314, maybe the could be combined :)

@oskarannas great catch! It is a duplicate of #8314


Explicitly stop hardware sequences once all images are acquired.

The core sequence API is vague about desired device behavior at the end of a sequence.  Many devices loop sequences, i.e. continue forever until stopped. This behavior (if explicit) could possible be leveraged to optimize behavior.  In some cases (as with the NIDAQ board we are using), it is problematic if a sequence is not explicitly stopped.  I found this place in the Acquisition Engine optimal to put such a stop in.  It works well with our hardware.  I assume this will not cause problems elsewhere, but not 100% sure.

Looks good to me


Error: The terraform-provider-anypoint_v1.6.0 plugin crashed! when trying to import the configuration of a anypoint_apim_policy_jwt_validation

When I tried to import a JWT Validation policy configuration the plugin causes terraform to crash. See details below;
│ Error: Request cancelled
│
│ The plugin.(*GRPCProvider).ReadResource request was cancelled.
╵
Stack trace from the terraform-provider-anypoint_v1.6.0 plugin:
panic: runtime error: index out of range [0] with length 0
goroutine 67 [running]:
github.com/mulesoft-anypoint/terraform-provider-anypoint/anypoint.flattenApimPolicyJwtValidationCfg(0xc0001f5200?, 0xc0001f5200)
github.com/mulesoft-anypoint/terraform-provider-anypoint/anypoint/resource_apim_policy_jwt_validation.go:604 +0x2be
github.com/mulesoft-anypoint/terraform-provider-anypoint/anypoint.resourceApimInstancePolicyJwtValidationRead({0x1d59b08, 0xc0000feee0}, 0x0?, {0x1bd2dc0?, 0xc000208000?})
github.com/mulesoft-anypoint/terraform-provider-anypoint/anypoint/resource_apim_policy_jwt_validation.go:444 +0x6ee
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xc000374e00, {0x1d59a60, 0xc000590810}, 0xd?, {0x1bd2dc0, 0xc000208000})
github.com/hashicorp/terraform-plugin-sdk/v2@v2.24.0/helper/schema/resource.go:724 +0x11b
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).RefreshWithoutUpgrade(0xc000374e00, {0x1d59a60, 0xc000590810}, 0xc0000b9e10, {0x1bd2dc0, 0xc000208000})
github.com/hashicorp/terraform-plugin-sdk/v2@v2.24.0/helper/schema/resource.go:1015 +0x549
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadResource(0xc00049dbc0, {0x1d59a60?, 0xc000590720?}, 0xc0005ed580)
github.com/hashicorp/terraform-plugin-sdk/v2@v2.24.0/helper/schema/grpc_provider.go:613 +0x48a
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ReadResource(0xc00036c320, {0x1d59a60?, 0xc000271800?}, 0xc00007ec60)
github.com/hashicorp/terraform-plugin-go@v0.14.0/tfprotov5/tf5server/server.go:748 +0x48b
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadResource_Handler({0x1ba0220?, 0xc00036c320}, {0x1d59a60, 0xc000271800}, 0xc0000fe7e0, 0x0)
github.com/hashicorp/terraform-plugin-go@v0.14.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:349 +0x169
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0004d0000, {0x1d5de88, 0xc0006029c0}, 0xc000229560, 0xc000271e90, 0x247e070, 0x0)
google.golang.org/grpc@v1.48.0/server.go:1295 +0xb18
google.golang.org/grpc.(*Server).handleStream(0xc0004d0000, {0x1d5de88, 0xc0006029c0}, 0xc000229560, 0x0)
google.golang.org/grpc@v1.48.0/server.go:1636 +0x9e7
google.golang.org/grpc.(*Server).serveStreams.func1.2()
google.golang.org/grpc@v1.48.0/server.go:932 +0x8d
created by google.golang.org/grpc.(*Server).serveStreams.func1 in goroutine 39
google.golang.org/grpc@v1.48.0/server.go:930 +0x246
Error: The terraform-provider-anypoint_v1.6.0 plugin crashed!
This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue

Thank you for reporting this.

@dfelcey can you give some info about your JWT policy ? what version etc ...

Sure. The current JWT policy I'm trying to import is version 0.11.0. See the attached screen shot;

Let me know if you need any other information

Hi @dfelcey
I'm confused, the latest version is 1.4.0
Please try using that version. your version is too old.

Hi Soufi,
If the JWT Validation policy is being applied to a Flex Gateway this is the latest version of the policy. If you are applying the JWT Validation policy to a Mule 4 gateway the latest version is 1.4. But they will be different implementations

@dfelcey
You're right.
Can you paste your terraform policy resource code here.

main.tf
terraform {
  required_providers {
    anypoint = {
      source = "mulesoft-anypoint/anypoint"
      version = "1.6.0"
    }
  }
}

provider "anypoint" {
  # use either username/pwd or client id/secret to connect to the platform

  client_id = var.client_credentials_id
  client_secret = var.client_credentials_secret

  # You may need to change the anypoint control plane: use 'eu' or 'us'
  # by default the control plane is 'us'
  cplane= var.control_plane
}

data "anypoint_flexgateway_target" "target" {
  id = "7d3e667c-fe3d-4cc8-bab2-99bfe516c278"
  org_id = var.anypoint_org_id
  env_id = var.anypoint_env_id
}

resource "anypoint_apim_flexgateway" "fg" {
  asset_group_id = var.anypoint_org_id
  asset_id = var.asset_id
  asset_version = var.asset_version
  org_id = var.anypoint_org_id
  env_id = var.anypoint_env_id

  deployment_target_id = data.anypoint_flexgateway_target.target.id
  deployment_target_name = data.anypoint_flexgateway_target.target.name
  deployment_gateway_version = data.anypoint_flexgateway_target.target.version
  deployment_expected_status = "deployed"
  deployment_overwrite = true
  deployment_type = "HY"
  instance_label  = "my terraform flex instance"
  endpoint_proxy_uri = "http://consumer.url/hello/world/2"
  routing {
    label = "my-route01"
    upstreams {
      label = "upstream01"
      weight = 100
    }
    rules {
      methods = [ "POST", "GET" ]
      host = ".*"
      path = "/.*"
      headers = {
        "x-example-header" = ".*"
        "x-correlation-id" = ".*"
      }
    }
  }
  upstreams {
    label = "upstream01"
    uri = "http://<IP_ADDRESS>:3000"
  }
}

resource "anypoint_apim_policy_jwt_validation" "jwt-policy-1" {
  org_id = var.anypoint_org_id
  env_id = var.anypoint_env_id
  apim_id = anypoint_apim_flexgateway.fg.id
  disabled = false
  asset_version = "0.11.0"
  configuration_data {
    jwt_origin = "httpBearerAuthenticationHeader"
    signing_method = "rsa"
    signing_key_length = 256
    jwt_key_origin = "jwks"
    jwks_url = "http://your-jwks-service.example:80/base/path"
    jwks_service_time_to_live = 60
    jwks_service_connection_timeout = 1000
    text_key = "your-(256|384|512)-bit-secret"
  }
}

variables.tf
variable "flex_gateway_name" {
  type    = string
  default = "fg-170524"
}

variable "anypoint_org_id" {
  type    = string
}

variable "anypoint_env_id" {
  type    = string
}

variable "client_credentials_id" {
  type = string
  sensitive = false
}

variable "client_credentials_secret" {
  type = string
  sensitive = false
}

variable "control_plane" {
  type = string
  sensitive = false
}

variable "endpoint_uri" {
  type = string
  sensitive = false
}

variable "asset_id" {
  type = string
  sensitive = false
}

variable "asset_group_id" {
  type = string
  sensitive = false
}

variable "asset_version" {
  type = string
  sensitive = false
}

solved in v1.6.1


Added support for ECC to Key Vault

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[X] The title of the PR is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[X] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[X] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[X] I have read the contribution guidelines.
[X] My spec meets the review criteria:

[X] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

@msfcolombo,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@salameer @dsgouda @olydis @sergey-shandar
Hi folks. Blaming readme.md for your contact, since there is no DL there.
A fiew questions:

The @azuresdkciprbot is telling we have 31 errors before and after this PR. Is the fix required for merging?
The Travis build here error in cognitiveservices (???). That has nothing to do with my changes. is there someone looking into that, or should I open a new issue?

Thanks!

 https://github.com/Azure/azure-sdk-for-python/pull/1368

No modification for AutorestCI/azure-sdk-for-node

No modification for AutorestCI/azure-sdk-for-node

No modification for AutorestCI/azure-sdk-for-ruby


mkfsImage error when build hello_dpu

Fist of all, appreciate your tutorial ! it is very helpful.
In "Prepare the Network Deployment File", I got following error when building hello_dpu. It seems to be a tiny problem but I have no clue at all...
Environment: Vitis 2020.1, petalinux 2020.1, board: custom ultrascale+mpsoc zu4ev board.
INFO: [v++ 82-1076] Deleting existing - /home/wu/Desktop/petaspace/peta_ai/axu4ev_peta/axu4ev_dpu_pkg/hello_dpu_system/Hardware/package/sd_card/image.ub
INFO: [v++ 82-1011] Creating sd_card directory
/tools/Xilinx/Vitis/2020.1/scripts/vitis/util/mkfsImage.sh: 57: shift: can't shift that many
ERROR: [v++ 82-1081] Cannot generate EXT4 sd_card image
ERROR: [v++ 60-702] Failed to finish packaging
INFO: [v++ 60-1653] Closing dispatch client.
make: *** [package] Error 1
makefile:38: recipe for target 'package' failed

Hi @wujingbang ,
Thanks for reporting this issue.
I have met this issue before but when I do a quick research I can see the resolved Xilinx forum post:
https://forums.xilinx.com/t5/Vitis-Acceleration-SDAccel-SDSoC/Cannot-generate-EXT4-sd-card-image-Hardware-build-error-in-Vitis/td-p/1148741
Hope this can help.

Close the issue since there is no further question


Method using defaults rather than args

I'm testing the tool out using the example and the advanced example is not taking the args and is using the default args in the method definition. In short it's using 1 + 1 + 1 = 3 rather than the other numbers.

Forgot to mention that when hovering over the button it shows the args rather than the defaults.


Fix link to jspdf.min.js in export-pdf example

See #5376

Thanks, please merge.

Thanks for the review


Demo is not working on click of Submit

Environment
Chrome 40 Firefox 36 or IE 11 on Windows 7 Enterprise SP1
Steps to Reproduce

Go to URL http://vadimsva.github.io/waitMe/
Fill in values at Name, Email & Phone field (or keep it empty)
Click on Submit.
Choose Any effect (say bounce)

Expected Result
Loading animation should be displayed.
Actual Result
Loading animation is NOT displayed for all Effects. Clicking Submit & Stop or Refreshing the page also do NOT start the animation.

Fixed on 1.09. Thanks

Verified, it works now.Thanks for the fast resolution.


sp-std in ibc-rs

To make ibc-rs no_std compatible(#29 ), one of the steps is refactoring the rust built-in std , like this.
Is it appropriate to use crate sp-std in the refactoring?

@romac As per the meeting, kindly comment if any. Thank you.

one of the steps is refactoring the rust built-in std , like this.

I would rather not have to change all imports to core:: or alloc:: but instead keep using the std:: namespace, and re-export everything from core and alloc under the std name.

Is it appropriate to use crate sp-std in the refactoring?

Can you explain why you would choose sp-std over an established crate like no-std-compat for this purpose? I unfortunately don't have to look very closely at sp-std right now, so any information would be very welcome :)

I would rather not have to change all imports to core:: or alloc:: but instead keep using the std:: namespace,

Yes, that's the way we are working.

Can you explain why you would choose sp-std over an established crate like no-std-compat for this purpose?

"sp-std" is verified in substrate, which is actively maintained and the framework we are working on.
"no-std-compat" is not maintained so actively and less dependent on by other crates.
Technically, "sp-std" may be more reliable.


Fixed the typos

Fixed the typos in spo hubsite docs folder.
closes #3762

Awesome, thanks @PriyanshuAhlawat we'll review it ASAP!

Thanks @martinlingstuyl 🙂


Uncaught Exception: Command failed:<PHONE_NUMBER>

This happened when I connected my VPN.
An uncaught exception was reported.
Info:
OS: win32
Arch: ia32
GPMDP Version: 3.0.0
Time: Wed Mar 09 2016 21:25:12 GMT 0100 (W. Europe Standard Time)
Error:
Command failed:<PHONE_NUMBER>
Error: Command failed:<PHONE_NUMBER>
System.AggregateException: One or more errors occurred. ---> System.Net.WebException: The remote name could not be resolved: 'update.googleplaymusicdesktopplayer.com'
   at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
   at System.Net.WebClient.GetWebResponse(WebRequest request, IAsyncResult result)
   at System.Net.WebClient.DownloadBitsResponseCallback(IAsyncResult result)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Squirrel.Utility.<LogIfThrows>d__50`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Squirrel.FileDownloader.<DownloadUrl>d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerS
...Some of the stack is missing

This issue was created automatically inside the uncaughtException handler

Client side network issue
Will not be reported in 3.1.0


Using multiple mock providers

I have a unit test that interacts with two different providers.
I would like to know if it is possible to generate two different pact files, one for each provider in the same test.
I tried defining two Pact functions, one for each provider, annotated with @ Pact and with the same state as the @ PactVerification test function but it didn't work.
I'm using the PactRule junit rule
By inspecting its code it looks as it scans for all the Pact functions and stores them in a Map with the state as a key, so different pact fragments will be overwritten if they have the same state.
Is there any way of acheiving what I need? Maybe without the Rule approach?

The core pact framework does support this, by specifying the consumer and provider with different names. The mock providers will have to run on different ports. I think the base JUnit test and rule have been written with only a single provider in mind. You would need to write your test to interact with the Pact libraries directly in this case. I'll put together an example of using the JUnit DSL with two providers in a test.
The Groovy DSL already has an example test with two providers, although it does run them sequentially you can nest the run blocks to have them running at the same time. Have a look at pact-jvm/pact-jvm-consumer-groovy/src/test/groovy/au/com/dius/pact/consumer/groovy/ExampleGroovyConsumerPactTest.groovy

Thanks, if you can provide an example for JUnit it would be helful.
I was actually trying to create a second PactFragment and doing runConsumer with the second provider configuration. There I was trying to nest the run blocks but I didn't know how to check for the test result, so the test always passed. Also the resulting code was not very readable.

I think I got it, although it may still be not very readable, I was missing some verifications on the result.
This is what it looks more or less. Mixing the Rule for the first provider and the pact libraries for the second:
    @Rule
    public PactRule rule = new PactRule("localhost", 8080, this);

    @Pact(state = "state for provider 1", provider = "provider1", consumer = "consumer")
    public PactFragment createFragment(final PactDslWithState builder) {
        //return some Fragment
    }

    public PactFragment createFragmentForProvider2(final PactDslWithProvider builder) {
        //return builder
        //        .given("state for provider 2")
        //        ....
    }

   @Test
   @PactVerification("state for provider 1")
   public void myTest() {
       PactFragment fragment = createFragmentForProvider2(ConsumerPactBuilder.consumer("consumer").hasPactWith("provider2"));
       MockProviderConfig config = new MockProviderConfig(8081, "localhost");

       VerificationResult result = fragment.runConsumer(config, new TestRun() {
           public void run(MockProviderConfig config) {
               //Test code here
           }
       });

       if (result instanceof PactError) {
           throw new RuntimeException(((PactError)result).error());
       }

       Assert.assertEquals(ConsumerPactTest.PACT_VERIFIED, result);
    }

That's about what I would have done. I might still put together a base test that verifies two providers as an example or update the rule to allow it to be used for multiple providers.

The JUnit rule now supports multiple providers, have a look at PactMultiProviderTest for an example.

Will  it be available with version 3.0.2? When do you expect the repository will be available?
Thanks & regards
Patrik

I'll see if I can get 3.0.2 released this weekend

That would be great! Thanks!

This works only if you create the PactProviderRule without host and port. If you provide a host and port only one of the Pacts will be considered

Sry, the reason for that was a host which was not localhost

Are you saying you resolved the issue by using localhost? Or is this still a problem?

I configured two provider one on localhost one for a different host. This did not work, it considered only the provider which is not on localhost for the verification. When I changed the second host to localhost both provider where used.


Document whether pipeline artifacts should work between hosted and private agents

Ref: https://developercommunity.visualstudio.com/content/problem/555009/should-pipeline-artifacts-work-between-hosted-and.html

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 861ce7a5-4fa4-55f1-2c97-46a9cc6a2f66
Version Independent ID: bdf954b9-9bbe-8b34-b674-71ad8153519d
Content: Publish and consume Pipeline artifacts in builds - Azure Pipelines and TFS
Content Source: docs/pipelines/artifacts/pipeline-artifacts.md
Product: devops
Technology: devops-cicd
GitHub Login: @alexmullans
Microsoft Alias: amullans

This should work. Glad to see a devcom problem report was opened --- this is the right way to report problems.
For the docs ... I don't know that we need an explicit statement about this (since it should work), but we should probably say something about the required version of the [self-hosted] agent..
For context ... the logic for the pipeline artifact tasks ships in the agent itself (which is different from every other task), so communicating the minimum required agent version in the docs is important. I think the docs needs some statement about the minimum required agent version --- maybe in an FAQ section. Ideally it's not something that needs to be updated every time the version changes (won't be that often).
Btw, currently for Download Pipeline Artifact (V2) and Publish Pipeline Artifact (V1) the minimum agent version is 2.153.1 (see task.json).


Unsubscribe does not work correctly

I tried wamp.rt to study WAMP.  I found that unsubscribe does not work correctly because subsid is not specified at the  unscribetopics() in handlers.js.  I changed as follows, then it worked correctly.
$ diff handlers.js handlers.js~
207c207
<         this.unsubstopic(topicUri, subsid);

    this.unsubstopic(topicUri);

Thank you.

I'm having the same problem, any updates on this!?

Same problem here.

29-9-15: The master has the fix, the release (npm install wamp.rt) does not.

Hi @MarijnStevens, we had the same problem sometime ago and decided to fork the project and fix this issue.
You can use this https://www.npmjs.com/package/wamp-router.


Storybook v4

This PR updates all the dependencies to work with Storybook v4.  Older version of this repo required components from the @storybook/addon-info which have changed quite a bit and some are no longer exported. Therefore I have extracted those components and added them directly to this repo.  There is one area of markdown info which still has a dependency but this branch is already getting too large. Tests pass.

Extracting the components that other libraries have deprecated is quite a smelly code smell. Is there no way we can use the APIs they've moved to?

@tweeres04 Yep. I don't disagree.  There are a few options that ran through my mind here of what we could do.

We separate ourselves from exporting components from another dependency which no longer allows exporting of said components.

Ok, this bad boy now uses an import statement (from the @storybook/addon-info) dependency for the components which were not working.  Used the direct path, which results in the correct functioning and no need to duplicate code or create potential code smells.
It also fixes, 1 or 2 open issues listed by the community - which includes the console warnings around glamorous issues.
https://github.com/Checkfront/react-storybook-addon-chapters/issues/34


Support custom easing in VelocityUI transitions.

This is something I find very usefull to personalize builtin transitions.
On line 118, I just piped redirectOptions:
opts.easing = callOptions.easing || redirectOptions.easing /* < added this*/ || "ease";

Because other options like duration and queue are backed by redirectOptions, is there a reason why easing is missing?
I created marvelous effects by providing custom easing.
Maybe you can switch the pipe order to achieve an override instead of a fallback. But it's just an idea, for me, fallback is ok.

Ahh, yes. Very good question. The reason is that providing easing control for built-in functions will very often have unintended animation behavior since the packaged effects consist of multiple animations whose for which new easing types will alter the smooth handoff from one effect to another -/


when using the area changing skins the dont work what do i do

Custom Knight itself doesn't support Area Changing skins. I believe that you are thinking of "CustomKnightPlus" which is a different mod, that adds some extra options for skins to use. If you want technical support with Mods, then you should probably join the HK Modding Discord server (linked in the Custom Knight Mods Menu iirc), and you can create a #support post there.

custom knight plus isnt working

nvm


Copying Stack tags to the Datadog monitor (#226)

Cloudformation supports tags at a stack level. They are normally passed on to all Cloudformation resources (some resources don't support that yet...). Datadog monitors got tags, too. With this change, the Cloudformation Stack tags are copied to the Datadog monitor. Additionally, the AWS autogenerated tags like stack name and logical id are also set. If a tag is already set explicitly at a monitor, the monitor value is being used. Since Datadog uses a : to separate key and value, all : are replaced with _.
In order to maintain backwards compatibility, this feature is switched off by default. It can be enabled account-wide via the type configuration, the same way Datadog credentials are being set.
Requirements for Contributing to this repository

Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
The pull request must only fix one issue, or add one feature, at the time.
The pull request must update the test suite to demonstrate the changed functionality.
After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?
This PR fixes https://github.com/DataDog/datadog-cloudformation-resources/issues/226
Description of the Change
See commit message
Alternate Designs
No alternate design.
Possible Drawbacks
There should be none, since the feature is implemented in a backwards-compatible way.
Verification Process

created a monitor via cfn with version 4.4.0
deploy my new version
updated the monitor text via cfn -> tags showed up
added to the stack a new monitor -> tags showed up

Additional Notes
I didn't add a test because there were none and I didn't work with python cloudformation resources before.
Release Notes
Copying Stack tags to the Datadog monitor (disabled by default)
Review checklist (to be filled by reviewers)

[ ] Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
[ ] PR should not have do-not-merge/ label attached.
[ ] If Applicable, issue must have kind/ and severity/ labels attached at least.

Hi, thanks for this PR. After a bit of testing we reverted this change. We realized that systemTags and others are not passed within the request context during the execution of the read_handler. This complicates things a bit further because it is difficult to properly handle resource drift with this implementation.
I am going to close this PR however, we are evaluating alternative approaches such as the native tagging support for cloudformation tags, caveat being, this will require a schema change for the tags attribute and that we are blocked waiting on new cloudformation-cli-python-plugin release.

I personally would be happy with the drift, but I can understand if you are not.

@skarimo I agree with @elruwen , I think a simple integration could suffice in many cases.


UI_TABS_CALLBACK Bug

*** Error executing callback ui_tabs_callback for xxxx\StabilityMatrix-win-x64\Data\Packages\stable-diffusion-webui\extensions\sd-webui-depth-lib\scripts\main.py
File "xxxxxxxx\StabilityMatrix-win-x64\Data\Packages\stable-diffusion-webui\modules\script_callbacks.py", line 166, in ui_tabs_callback
res += c.callback() or []
File "xxxx\StabilityMatrix-win-x64\Data\Packages\stable-diffusion-webui\extensions\sd-webui-depth-lib\scripts\main.py", line 47, in on_ui_tabs
dataset = gr.Examples(examples=os.path.join(maps_path, t), inputs=[png_input_area],examples_per_page=24,label="Depth Maps", elem_id="examples")
File "xxxxxx\StabilityMatrix-win-x64\Data\Packages\stable-diffusion-webui\venv\lib\site-packages\gradio\helpers.py", line 58, in create_examples
examples_obj = Examples(
File "xxxxx\StabilityMatrix-win-x64\Data\Packages\stable-diffusion-webui\venv\lib\site-packages\gradio\helpers.py", line 209, in init
self.processed_examples = [
File "xxxx\StabilityMatrix-win-x64\Data\Packages\stable-diffusion-webui\venv\lib\site-packages\gradio\helpers.py", line 210, in
[
File "xxxxx\StabilityMatrix-win-x64\Data\Packages\stable-diffusion-webui\venv\lib\site-packages\gradio\helpers.py", line 211, in
component.postprocess(sample)
File "xxxxxx\StabilityMatrix-win-x64\Data\Packages\stable-diffusion-webui\venv\lib\site-packages\gradio\components\image.py", line 318, in postprocess
return client_utils.encode_url_or_file_to_base64(y)
File "xxxxx\StabilityMatrix-win-x64\Data\Packages\stable-diffusion-webui\venv\lib\site-packages\gradio_client\utils.py", line 387, in encode_url_or_file_to_base64
return encode_file_to_base64(path)
File "xxxxx\StabilityMatrix-win-x64\Data\Packages\stable-diffusion-webui\venv\lib\site-packages\gradio_client\utils.py", line 360, in encode_file_to_base64
with open(f, "rb") as file:
PermissionError: [Errno 13] Permission denied: 'extensions'
Unfortunately your fork doesn't fix the error for me : (  Both versions of Depth extension do this.
I was hoping to use this for hand refinement via:
https://civitai.com/models/67174/900-hands-library-for-depth-library-or-controlnet

What version of Web UI are you using?
What's inside of your maps folder? Do you have any links or additional nested folders?

i DID have many nested folders. I just dropped the contents of the zip i got into the maps directory. The excessive number of folders broke the extension.
It works perfectly now!
Thank you.

From: wywywywy @.>
Sent: Thursday, November 23, 2023 2:30 AM
To: wywywywy/sd-webui-depth-lib @.>
Cc: Chaoddity @.>; Author @.>
Subject: Re: [wywywywy/sd-webui-depth-lib] UI_TABS_CALLBACK Bug (Issue #11)
What version of Web UI are you using?
What's inside of your maps folder? Do you have any links or additional nested folders?
—
Reply to this email directly, view it on GitHubhttps://github.com/wywywywy/sd-webui-depth-lib/issues/11#issuecomment-1823975613, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACBPZ2OKOXCVUZYNTBS2ZSLYF4CUBAVCNFSM6AAAAAA7XA3LXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRTHE3TKNRRGM.
You are receiving this because you authored the thread.Message ID: @.***>


How to Pass a Custom HLS Key for Decryption in ExoPlayer?

Hello ,
I am working on an HLS stream that is encrypted using AES-128, and I have the decryption key available. I would like to know how to pass this custom HLS key to ExoPlayer for decryption during playback.
I’ve reviewed the documentation, but I couldn’t find a clear method to directly apply the AES key to the HLS stream in ExoPlayer. Could you please guide me through the correct implementation?
If necessary, I can provide a link to the stream and the decryption key for further assistance.
Thank you in advance for your help!
Best regards,

hls file xontain such data :
#EXTM3U
#EXT-X-TARGETDURATION:4
#EXT-X-VERSION:3
#EXT-X-MEDIA-SEQUENCE:20736
#EXT-X-PROGRAM-DATE-TIME:2024-09-28T00:08:03.599Z
#EXT-X-KEY:METHOD=AES-128,IV=0x30303030303030303030303066f73d5a,URI="https://key.com/key.php?",KEYFORMAT="identity"
#EXTINF:4.000,
2024/09/28/00/08/03-04000.ts
#EXTINF:4.000,
2024/09/28/00/08/07-04000.ts
#EXTINF:4.000,
2024/09/28/00/08/11-04000.ts
#EXTINF:4.000,
2024/09/28/00/08/15-04000.ts
#EXTINF:4.000,
2024/09/28/00/08/19-04000.ts
#EXTINF:4.000,
2024/09/28/00/08/23-04000.ts


Cerebro - Connection refused

Hello,
I am securizing Elasticsearch with the plugin "Readonlyrest". I specified a user/password for Cerebro.
In application.conf, I defined this user/password to connect to ES
hosts = [   {     host = "http://localhost:9200"     name = "Secured Cluster"     auth = {       username = "cerebro"       password = "cerebro"     }   } ]
However, I get the following error :

Caused by: java.net.ConnectException: Connection refused: localhost/0:0:0:0:0:0:0:1:9200

Are the values of the attributes "username" and "password" sent to connect to Elasticsearch ?
H.

yes, username/password are sent to connect to ES.
Is elastic search running on the same server as cerebro? Also, do you have a special value defined for network.host/bind_host?

I checked the configuration of the ReadOnlyRest plugin. It is working now.
Thanks


Cut release v0.17.2

What's Changed

Fix home redirect in browser (#2008)
dynamic cursor depending on mouse scene state (#1995)
Make the sketch larger so 20-20 failures are clearer (#1989)
New segments can be added in the middle of a sketch (#1953)
Generate docs (#1994)
Fix member expression in object expression (#1992)
Rearchitect settings system to be scoped (#1956)
Set selection as top level event only (#1988)
Pipelines cause Z-fighting (#1976)
Allow two 'serial_test_' to run simultaneously (#1978)
Add plumbus test (#1975)
Onboarding updates (#1967)

Full Changelog: https://github.com/KittyCAD/modeling-app/compare/v0.17.1...v0.17.2

smoke test seems okay.