Remove MBEDTLS_X509_CHECK_*_KEY_USAGE

Context
There are two configuration options, MBEDTLS_X509_CHECK_KEY_USAGE and MBEDTLS_X509_CHECK_EXTENDED_KEY_USAGE, which are used to enable the library's verification of the keyUsage and extendedKeyUsage fields of an x509 certificate. This verification is an important step and disabling it can cause security issues however it is possible to either check or not check key usage at runtime (via the callback parameter in mbedtls_x509_crt_verify) as opposed to compile time.

Rationale
There is no reason to provide redundant compile time options when they can be equivalently done at at runtime with even more flexibility.

Work items for 3.0
In this case because both options are enabled by default we want to ensure that when removing the options verification of the key usage fields is still done by default. A user can disable the verification by using a callback which clears the corresponding flags when they've been set.

Remove MBEDTLS_X509_CHECK_KEY_USAGE and MBEDTLS_X509_CHECK_EXTENDED_KEY_USAGE from the configuration.
Ensure the library still performs the verification by default.
Ensure the changelog/migration guide is updated to give the migration path for users.
By the end git grep should return no instances of either option.

There is no reason to provide redundant compile time options when they can be equivalently done at at runtime with even more flexibility.

I'm not sure I'm fully convinced by this rationale: a reason could be to save code size. According to my measurements (arm-none-eabi-gcc -Os -mcpu=cortext-m0) each option is about 200 bytes of code size. In my book that's a bit of a grey area: is that enough to matter?
OTOH, I agree that those are security checks, so there's something to be said for always including them. Also, in terms of testing, runtime options are more convenient than compile-time options I think.
So, overall I'm a bit on the fence on this one.

A user can disable the verification by using a callback which does not check these fields.

I think that should be "a callback which clears the corresponding flags when they've been set".

In what scenarios would it be ok to not check the (extended) key usage? I guess when your root CA defines a special-purpose PKI where all certificates are for a specific usage anyway?
I'm trying to determine whether security is a reason to have these options always turned on, or at least to make users jump through hoops (possibly including a code size cost) if they want to bypass the checks.

Yes, I think the only case where you don't need to check those fields is when certificate usage is part of your PKI design - which only happens if (1) you control the entire PKI and (2) you designed it well.
Now, I can easily imagine scenarios where (1) is true at the beginning of the project but things change down the line. (I don't need to tell you that people sometimes make plans based on optimistic assumptions that don't always hold over time ;) ) In that case, there's a risk that people initially disable those options and then forget to enable later when things change.
Well, thinking while writing: if you control the entire PKI then you can choose to either (a) set these extensions to appropriate values in all certificates, or (b) omit them from all certificates  - and then no checks will be done.
So, I don't really think there's ever a good reason to want to bypass the checks, so we shouldn't make that easy.


React Hook useEffect has a missing dependency

Tania, let me first say, I REALLY appreciate your blog entries and tutorials.   You are totally helping me learn and understand many parts of React. The quality and simplicity of your presentations really sink the lessons home.  Many thanks...
With that said, I'm seeing a warning I don't really understand in this exercise.  The specific error message from the UserPage.js file:   React Hook useEffect has a missing dependency: 'props.match.params.id'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
Do note, this exercise is my first involving React Hooks.  I've read thru the documentation,but this is my first time playing with actual code.
reference1, reference 2, reference3
From what I can tell, that warning is there to stay, per discussion in https://github.com/facebook/create-react-app/issues/6880
Is that correct?  Am I reading this correctly?  Do you see the same warning when you run the code in this repo?
Again, many thanks for the work you've put into this stuff.

This warning message just drives me crazy.  But I think I fixed it...
     useEffect(() => {
          const getUser = async () => {
              const { data } = await axios(`https://api.github.com/users/${props.match.params.id}`);
              setUser(data);
        };
        getUser();
    }, [props.match.params.id]);     // <--- note the content here...

Reference:  S.O.55840294

@zipzit Yep, for useEffect, after the comma, it wants a list of anything the Effect depends on. Since this Effect depends on the params.id, whenever that changes, the Effect will run. If you only want it to happen once, like componentDidMount worked, you'll just use an empty array.  I'll add that into the article, thanks!


Legacy support for < SSE4.2

Tomahawk will not compile on a target architectures with < SSE4.2 as Cloudflare ZLIB requires the _mm_crc32_u32 intrinsic first described in SSE4.2.
We are currently considering to revert this implementation back to standard ZLIB

Tomahawk no longer depends on ZLIB directly although htslib do. In addition, Tomahawk now requires SSE4.2 intrinsics in its core computational model. Therefore, providing legacy support prior to SSE4.2 will never happen.


Corrected 2013 -> 2014

incorrect date in article.

@smashwilson would this commit with subtree screw things up?

@rdodev Oh. Yes, it likely would. Aren't submodules irritating?
#1034 also has a redundant fix (but that's fine, I'll just have rebase).

@gecampbell do you mind if I submit the fix to the date? If we merge this PR it will break things due to the subtree commit.

Since the submodule bit here shouldn't be included, I'll close this PR since I merged #1034. I'll address the year manually now.


1.5.4 api getaccount

In 1.5.3, calling getaccount returns correct data. In 1.5.4, the same call returns "Account not found"

I have not found an error testing on 1.5.4.
I provide a CURL example:
curl -X POST --data '{"jsonrpc":"2.0","method":"getaccount","params":{"account":20000},"id":123}' http://localhost:4003
Result:
{"result":{"account":20000,"enc_pubkey":"CA02200080B8A4EBDF2420D4843B9C776EFDF25BD84F1D978E6BB6698ED920852F4BD57E200008823095DF8D1F9BFE411E2FE36CB3676907D881EB436F79BDD9CA132B3EB313","balance":0,"n_operation":1,"updated_b":7657},"id":123,"jsonrpc":"2.0"}
I close this issue, If you can provide an example of error, reopen it and provide CURL call


trigger build

#611  👈
feature/proof-of-stake

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lazynina and the rest of your teammates on  Graphite


Kernel: support shellHook when defining kernel

So that
  pkg = linuxManualConfig {
    inherit stdenv;
    inherit (linux_mptcp_94) src version modDirVersion;

    # we need this to true else the kernel can't parse the config and
    # detect if modules are in used
    allowImportFromDerivation = true;

    shellHook = ''
      touch .scmversion
      echo "hello boss"
    '';
  };

works for instance.
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

or one can use
  }).overrideAttrs (oa: {
    shellHook = ''
      touch .scmversion
      echo "hello boss"
    '';
  })
  ;

closing...


Allow user to create options dynamically

Allow the user to create options that are not their by pressing enter after searching

Can you give more details? How is this different from tags.js?

Closed for inactivity. tags.js allows you to create options dynamically.


dfx schema requires a valid dfx.json

I was setting up a new remote canister and was trying to see if I could omit some fields.
I wanted to view the schema to get a better sense of what I was doing but I couldn’t because I had omitted some required fields. The file was still valid JSON.
It seems like an unnecessary coupling to not be able to view the schema because of the state of the file.

Indeed, that's a silly restriction. My bad, I didn't think I should test for that when I wrote dfx schema. Made a ticket for myself, but it's not at the top of my priorities for now.


Remove IMAGE_ID from our scripts to always use the latest version of envoy

Envoy will default it's image-id to the latest, this will remove the need to keep the image id up to date.

I think the reason we've pinned the IMAGE_ID is because we needed to build this on Xenial.

Closing this out in favor of other work on this topic.


commands: match commands on description

This change makes the VS Code command menu match on the command description, not just the title.
This enables searching /commands in the menu.
Test plan

Demo:

So keen to get this updated. But could we have it match the designs in Figma?
https://www.figma.com/file/9112BsKsJc1BpO2j8XYwLL/🤖-Cody-VS-Code-[Main]?type=design&node-id=4560-11184&mode=design&t=WvJcepme3DSbUmO6-4


Simulator

This PR implements a Python program to simulate a live environment similar to that of the KITT4SME cluster with a simulated VIQE client, a VIQE cloud service, Quantum Leap with a CrateDB backend and Dazzler configured with dashboards to display VIQE's inspection reports.

Demo
Follow the steps in this repo's README.

@innovacion-rovi please check the simulator out. First run it as explained in the README. Then try swapping the simulated VIQE client w/ your own.
To do that you need to hook up the code to send inspection data to the VIQE service. The easiest way to get going is to copy-paste the tests.util.viqe_client code into your own Python client---you'll need to add a dependency to the requests lib to be able to run that code in your own client. For a usage example, have a look at tests.sim.report_batch---that's how the simulator sends inspection data to the VIQE service.
After hooking up the code, you should start the simulator's Docker Compose file
$ cd tests/sim
$ docker compose up -d

and then use your client to send inspection data to the local VIQE service running in the Docker Compose env. After sending data, check out the Crate DB tables and the Dazzler dashboards as explained in the README.
One last thing. You could improve your initial copy-paste code by using Pydantic data models instead of plain dictionaries as done in tests.sim.report_batch. To do that, you'll need to add the following to your Python client

dependency to Pydantic
InspectionType enum from viqe.ngsy
ClientInspection Pydantic model from viqe.ngsy

With that in hand, you won't need dictionaries anymore. In fact, you could just create an inspection batch by instantiating ClientInspection objects, then transforming those objects to dicts and finally send them over to the VIQE service, e.g.
reports = [
    ClientInspection(
        type=InspectionType.raw_material, inspected_item_id='steel-slab:912',
        inspection_result_normalized=0.2, inspection_result=True),
    ClientInspection(
        type=InspectionType.tweezers, inspected_item_id='tweezers:543',
        inspection_result_normalized=0.6, inspection_result=False, spec='my spec #23'),
]
batch = [r.dict() for r in reports]
viqe_client.post_inspection_batch(batch)


[fx] provide an accurate estimation of memory except for GPT-2.

Improvements
After hacking the autograd graph and the save_tensors_hook, I managed to compute the accurate memory estimation of torchvision.models. We can compare the result with #1547.

model
estimated_fwd_mem
estimated_param_mem
real_fwd_mem
real_param_mem

<function resnet18 at 0x7f2a42d86d30>
130.350 MB
44.592 MB
141.258 MB
44.690 MB

<function resnet34 at 0x7f2a42d86ee0>
207.191 MB
83.152 MB
219.900 MB
85.538 MB

<function resnet50 at 0x7f2a42d960d0>
444.352 MB
97.492 MB
440.048 MB
99.353 MB

<function resnet101 at 0x7f2a42d96280>
672.988 MB
169.942 MB
668.108 MB
173.151 MB

<function resnet152 at 0x7f2a42d96430>
925.602 MB
229.617 MB
923.410 MB
234.590 MB

<function convnext_tiny at 0x7f9f6146d0d0>
527.151 MB
109.059 MB
539.976 MB
109.942 MB

<function convnext_small at 0x7f9f6146d280>
857.769 MB
191.588 MB
885.770 MB
192.682 MB

<function convnext_base at 0x7f9f6146d430>
1224.659 MB
337.950 MB
1242.999 MB
339.684 MB

<function convnext_large at 0x7f9f6146d5e0>
2082.190 MB
754.423 MB
2097.922 MB
757.913 MB

<function densenet121 at 0x7fbad0542310>
523.132 MB
30.437 MB
537.939 MB
30.859 MB

<function densenet161 at 0x7fbad05424c0>
1026.973 MB
109.409 MB
1053.578 MB
111.325 MB

<function densenet169 at 0x7fbad0542670>
648.988 MB
53.976 MB
665.817 MB
54.724 MB

<function densenet201 at 0x7fbad0542820>
845.351 MB
76.347 MB
868.206 MB
77.392 MB

<function wide_resnet50_2 at 0x7f5cd00959d0>
709.925 MB
262.769 MB
735.279 MB
265.056 MB

<function wide_resnet101_2 at 0x7f5cd0095b80>
1139.441 MB
484.034 MB
1184.539 MB
501.862 MB

<function regnet_x_16gf at 0x7f52d29c3280>
993.384 MB
207.056 MB
994.317 MB
209.767 MB

<function mnasnet0_5 at 0x7f52d2a76670>
105.669 MB
8.463 MB
109.946 MB
8.631 MB

<function efficientnet_b0 at 0x7f52d2a5e940>
264.923 MB
20.174 MB
364.534 MB
20.676 MB

<function mobilenet_v2 at 0x7fbcc189b310>
220.846 MB
13.370 MB
320.066 MB
13.578 MB

<function mobilenet_v3_small at 0x7fbcc189be50>
61.471 MB
9.700 MB
72.194 MB
9.805 MB

<function mobilenet_v3_large at 0x7fbcc189bca0>
168.415 MB
20.916 MB
193.134 MB
21.086 MB

<function resnext50_32x4d at 0x7f1bf2a625e0>
542.634 MB
95.478 MB
539.308 MB
96.390 MB

<function resnext101_32x8d at 0x7f1bf2a62790>
1298.837 MB
338.712 MB
1318.516 MB
351.757 MB

<function resnext101_64x4d at 0x7f1bf2a52b80>
1278.482 MB
318.357 MB
1280.926 MB
319.183 MB

<function vit_b_16 at 0x7f7ce2ad63a0>
921.073 MB
330.229 MB
869.416 MB
330.229 MB

<function vit_b_32 at 0x7f7ce2ad6550>
473.796 MB
336.549 MB
460.042 MB
337.311 MB

<function vit_h_14 at 0x7f7ce2ad61f0>
5827.954 MB
2411.063 MB
5597.718 MB
2480.049 MB

<function vit_l_16 at 0x7f7ce2ad6700>
2725.748 MB
1160.914 MB
2619.091 MB
1165.363 MB

<function vit_l_32 at 0x7f7ce2ad68b0>
1526.879 MB
1169.340 MB
1503.321 MB
1174.183 MB

<function gpt2_medium at 0x7f2f614a9ca0>
35625.668 MB
1353.543 MB
55721.340 MB
1377.555 MB

Test

Concerns
We can't use ColoTracer to trace every call_function in GPT-2, which makes the estimated result very poor.

Good work. There are some overall comments below:

fix the bug reported in the CI
use better data structure to represent your meta data, never return a dictionary whose keys are fixed, this can be converted to a dataclass instead.
do not return an empty list/dict, use None instead.
refactor all wrong type hinting.


Async void is illegal in ASP.NET and DNXcore

Tentative fix for #6119.
From my experiments it also seems that async void is problematic when using dnx-style projects.

@jskeet  FYI.

LGTM, assuming that changing the return type of an async function like that without changing the body of the function actually results in legal C#

Yes, that is the case. Every async function returns a Task (a future basically). async void is a special case (and basically an anitpattern).


Bump dependencies

Bump junit to 4.13.2 (#330)
Bump mockwebserver to 4.9.3 (#329)
Bump junit-jupiter-api to 5.8.2 (#328)
Bump guava to 31.1-jre (#327)
Bump jackson-databind to <IP_ADDRESS> (#326)
Bump slf4j-simple to 1.7.36 (#325)
Bump slf4j-api to 1.7.36 (#324)
Bump okhttp to 4.9.3 (#323)
Bump httpasyncclient to 4.1.5 (#322)
Bump commons-codec to 1.15 (#321)

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


Branch retrieval fix

Describe the bug
Branch retrieval will error when branch name contains "/" because we strip off the branch name from the last succession of "/" separated word in the relevant environment variable.
Might have to simply remove ref/heads from the environment variable instead.

Fixed using .replace('ref/heads/', '') on the environment variable containing the branch reference.
Closing for now!

Fixed using .replace('ref/heads/', '') on the environment variable containing the branch reference.
Closing for now!


refactor: remove admin service

I've removed I hope everything related to admin service, the only on part I'm not sure about the docs, so @BalduinLandolt please let me know if you think there is something more to remove or to keep.
Code works locally, including building docker image.

on first glance, I think we can remove a lot more (though the PR name should be changed then):

shared folder should be removed - if that's shared, then it's supposed to live in a separate repo
services/resources folder - has nothing to do with metadata either
for the documentation: I only need the docs/services/metadata folder... but we may want to keep more, if we intend to use slate for metadata in the future. (same goes for the docs make targets)

also, I'm not sure about all go and javascript dependencies, if they are still needed.


Implement frameElement for Window.

frameElement is currently undefined  for all Windows. This will set it to null for the top-level window, and as the HTMLFrameElement for attached frames.

I suspect you'll want tests for this, there appear to be some relevant ones in web-platform-tests but I'm struggling to work with them.

It looks like to pass those tests you'll need to do an origin check. https://html.spec.whatwg.org/#dom-frameelement step 5, basically check the two documents' ._URL.origin should do the trick probably.

I took a look at those tests and actually I don't think we can pass them given jsdom's current set up. They rely on some crazy stuff where the object model actually looks totally different cross-origin. So I will pull this in without tests.

Merged as 17996d39f955ca2e6ab72a0a6c192ed251815517; thank you!


add MessageListener annotation for spring-boot-starter

copy from rocketmq-spring

Sorry, copied code from other projects isn't allowed.


Add feature to pick multiple colors

In some cases it might be useful to be able to pick multiple colors in one go and return them, maybe even with optional usage tags.

Agree, Im actually searching for library that allows colors multiselect, but cannot find. I thought there is option in this library but this issue dispel doubts :(

FlexColorPicker actually already does a sort of multi color init and return. The list of previous used colors, can be initialized, and it is returned too (so it can be saved and returned between app runs if so desired). The same mechanism is doable to also use for setting (or letting them be null) initial colors in a multi selection list of color boxes. Then you could in the picker select which one your are picking a color for at the moment, and return them all when done.
I think one could even allow a list of custom widgets to use as customizable labels for the colors being picked, plus a config if those label widgets are left, right, over, under or even inside the selected color box that one is picking the color for.


Data set path

Hi, I keep getting errors when running NFS data sets, so can you provide the path of the NFS data set, something like this
-- data
-- lasot
|-- airplane
|-- basketball
|-- bear
...
-- got10k
|-- test
|-- train
|-- val

For the structure of the NFS dataset, please refer here.
https://github.com/botaoye/OSTrack/blob/3f4d341f05908da959b4b38d9f89945097a6b916/lib/test/evaluation/nfsdataset.py#L23

Did you download the dataset from NFS official website? Why don't I have an anno file？like this
{"name": "nfs_Gymnastics", "path": "sequences/Gymnastics", "startFrame": 1, "endFrame": 368, "nz": 5, "ext": "jpg", "anno_path": "anno/nfs_Gymnastics.txt", "object_class": "person", 'occlusion': False},
{"name": "nfs_MachLoop_jet", "path": "sequences/MachLoop_jet", "startFrame": 1, "endFrame": 99, "nz": 5, "ext": "jpg", "anno_path": "anno/nfs_MachLoop_jet.txt", "object_class": "aircraft", 'occlusion': False},


VISION OCR

Can a sample for this be added?
https://vision.googleapis.com/v1/images

Greetings!  You really don't want to use this library for that :) You want to follow the guide here:
https://cloud.google.com/vision/docs/libraries#client-libraries-install-nodejs
And there are tons of great samples here:
https://github.com/googleapis/nodejs-vision/tree/master/samples
Hope this helps!


durga-puja frontend project

to add about, services, and contact section to the homepage of website

@MohitGupta121 @TusharKesarwani @pranjay-poddar kindly assign this issue under GSSOC23


Allow setting document language ()

Ecmarkup outputs documents without a lang attribute on the html element. (In fact, it doesn't output  tags at all, which is fine when no lang attribute is needed.)
Ecmarkup should accept a language document option to support this. For example:

repository: https://github.com/bterlson/ecmarkup
assets: none
copyright: false
language: en

It would also be nice if  tags were parsed in the document itself. For example:

repository: https://github.com/bterlson/ecmarkup
assets: none
copyright: false

...

This is the only warning that https://checker.html5.org outputs for Ecmarkup documents.

As of #224, ecmarkup will preserve the html tag when it has attributes such as lang. I don't think there's much need to have explicit metadata for the language beyond , so I'm going to call this fixed.


Fixed dropdown links issue

Hello @rohan09-raj , I have fixed the dropdown links only clicking when clicking the text and hovering all over the link. Now it is clickable in the hoverable area too.
This is the pull request regarding the closed request because of unwanted changes in the previous PR(#327 )
Issue No. - #326
Gif Reference -
https://user-images.githubusercontent.com/85296770/205456861-95e679f5-3ac3-4ac9-a239-f88d668bb61e.mp4

LGTM 💯 , thanks for fixing the issue.

Thanks 👍🏻


securityChecks option not available for image scan

Hi team,
I was trying to use the recently added security-checks option to remove the secret scanning (enabled by default) because it can cause trivy to timeout on very big images, and by looking at the code, it seems that the option is only being considered for fs and repo types, while it still appears if I do trivy image -h, so I believe it should be available for images too.
I would like to know if there is a reason for this, and I will try to open a pull request in the coming hours.
Thank you for reading me!

My PR : https://github.com/aquasecurity/trivy-action/pull/112
My  tests : https://github.com/tanguy-platsec/trivy-action-security-checks-option-test/actions


Refactor Placeholder interface

Fixes #127

@rultor merge

@rultor merge

@suseika OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@suseika Done! FYI, the full log is here (took me 3min)


Wanted to add a split-on-hover Floating ball for social handles.

https://user-images.githubusercontent.com/71227590/127027374-80557284-a317-43f7-93d6-f5665f9e8d75.mp4

Please assign me this if you like it.

Not required as of now


Consider using setImmediate if available

global.setImmediate is a proposed-for-standardization version of Q.nextTick.
It does not seem to be winning the battle for the hearts and minds of spec editors (MDN says "is not expected to become standard"; negative comments from Hixie in a related bug). But, it does seem to be winning the hearts and minds of developers (blog post from Nicholas Zakas; dependencies from a reasonably-popular Knockout.js plugin; even a (closed) bug to use it in underscore.js). So it might get somewhere in the end, and Q's support could help push things in that direction.
Currently the only way to get it is through manually shimming it; the only browser to have it natively is IE9, and there it's hidden behind a prefix. So if we said Q.nextTick = global.setImmediate || (existing code), this would only work for people who have included a shim.
Still, this seems like a win. For shim users, it gives faster promises in non-MessageChannel-supporting browsers. It would also solve #44, by allowing users in the add-on SDK environment to do a quick shim like global.setImmediate = require("event-queue").enqueue.
What do you think?

I like setImmediate. I’ve experimented with shimming it and using it, but it does not make sense to shim it in Q.
Part of this is that nextTick(cb) is the only part of the signature we need and nextTick does not have to implement handle tracking or variadic argument forwarding like setImmediate(cb(...args), ...args):handle. It would be a waste of both weight and performance to properly shim setImmediate.  I would even use a global nextTick before considering using a global ``setImmediate because of this consideration.
var nextTick = global.nextTick || global.setImmediate || nextTickShim;

I do want to axe the enqueue module dependency. It is a legacy from Narwhal, which I think we should leave behind.
In the nextTick shim, I would also like to empty the queue in a single event to speed things up and make some diagnostics less noisy.

Yeah, the fact setImmediate has all the unnecessary stuff is unfortunate.
So your proposal is to change to
var nextTick = global.nextTick || global.setImmediate ||
               (typeof process !== "undefined" && process.nextTick) ||
               nextTickShim;

and then, perhaps in the future, publish a browser-based global.nextTick library?


Discrete markers broken

Codepen
https://codepen.io/mrblur/pen/zevOQO
Explanation

What is the behavior you expect?
Discrete markers should be configurable for specific point at X-axis
What is happening instead?

No marker at all if global marker size is 0. I want a solid linear graph with single marker pointing to a specific value, kind of a "you are here". Had to guess dependency on global markers and needed to make global markers "invisible" by specifing their size to 1 and putting same color as the graph itself. This workaround is working, however it does a lot of useless rendering - my graph is up to 3000 points, so a lot of markers which aren't visible.

Documentation says discrete marker color is specified with fill and stroke which isn't true. You need to specify fillColor and strokeColor. Again, had to guess, which was confusing AH together with point 1.

The worst part - it isn't possible to configure discrete marker for first point at all. dataPointIndex: 0 makes marker go away, like not configured. dataPointIndex: 1 makes marker rendered twice - for both first and second point in data series. Other values are working as expected.

Since addressing discrete markers with indexes is not working, tried addressing with categories - that does not work at all, you cannot specify an "x" value as dataPointIndex, and using indexes (which is misleading) is broken as described @ pt. 3.

What error message are you getting?
No errors, just doesn't work like expected :)

Hi
I am using 3.6.5, but still discrete  is not working as expected.
Can someone confirm with example ?
Thank you for help.

In the current version, you need to set markers.size > 0 to see all markers (whether it is discrete or not)
So, markers code becomes
var options = {
  markers: {
    size: 5,
    discrete: [{
      seriesIndex: 0,
      dataPointIndex: 1,
      fillColor: "#0A0",
      strokeColor: "#FFF",
      size: 7
    }
    ]
  }
};

Update codepen - https://codepen.io/apexcharts/pen/PgPXYO

Thank you @junedchhipa  :)
It worked :)
just created another issue with animation  https://github.com/apexcharts/apexcharts.js/issues/477#issue-429124528

There is still a problem when I add configurations to dataPointIndex: 0. It breaks everything and no markers are displayed.

@alon-loris Same issue, when using "discrete" prop on markers, tooltip positioning breaks(it is always on top left corner)

@alon-loris Same issue, when using "discrete" prop on markers, tooltip positioning breaks(it is always on top left corner)

Actually I fixed issue with tooltip by removing "size" property of inside "marker" object and specified size only inside "discrete" array

@Asmodeios thanks a lot, this workaround is very useful.
This issue is still a problem, for example when using area graph

+1 still broken, workaround doesn't work if you are only targeting some points, not all

As a workaround, you can set the default size value of 0.000001
markers: {
  size: 0.0000001,
  hover: {
    size: 6,
  },
  discrete: [
    {
      seriesIndex: 1,
      dataPointIndex: lastNonNullIndex,
      fillColor: '#1E90FF',
      strokeColor: '#FFFFFF',
      size:   5,
    },
  ],
},


Wait for at most 30 seconds for monit.

OCD run https://ocd.appscale.com:8080/job/Daily Build/1725/

https://ocd.appscale.com:8080/job/Daily Build/1728/

https://ocd.appscale.com:8080/job/Daily Build/1731/


Feature request: Ask for ticket-number

In many projects jira or something similar is used.
It would be great to ask the user for the ticket number.
The result could be: fix(scope): Ticket-1234 subject
Thanks for this project 👍

Will there be any documentation added to the README? How do you add the config item?

Sorry I missed that in the code review. I created ticket: https://github.com/leonardoanalista/cz-customizable/issues/72


Upgrade swagger dependencies

Update to current versions of swagger libraries:
'io.swagger:swagger-codegen:2.2.1'
'io.swagger:swagger-parser:1.0.25'
'io.swagger:swagger-compat-spec-parser:1.0.25'

@otrosien this will be not that easy. I tried it before and experienced a lot of breaking changes. That will be a longer task.

I'll have a look. I hope to improve the situation on transitive dependencies creeping into my gradle build. See here: https://github.com/zalando-incubator/swagger-codegen-gradle-plugin/issues/8
swagger-codegen currently pulls in maven-plugin stuff.

But this deps can be excluded, right?
I will create a branch '0.4.x' for maintenance of current state. Then we can start in 'master' working on updating 'swagger-codegen' dependencies here.

jep, I am excluding the dependencies manually, but that's not how dependencies were intended... Upgrading does not solve the dependencies problem anyway (http://mvnrepository.com/artifact/io.swagger/swagger-codegen/2.2.1)
So, before putting much effort in upgrading, let's discuss issue #61.

I'm trying to fix the issue upstream: https://github.com/swagger-api/swagger-codegen/pull/4840

@jbellmann : undo inclusion of the extra dependencies in https://github.com/zalando-stups/swagger-codegen-tooling/commit/2da1bd5ab77c137ca0ae79823de04f19a0438402#diff-c35b35f47d958c913c8cb108abee5381R23 - we should use the transitive deps from swagger-codegen. If I'm not mistaken there's an incompatible API change in swagger-parser causing gradle run to fail.

At the risk of causing someone a lot of work....
swagger-codegen v2.2.2 released 1st March 2017. Uses swagger-compat-spec-parser v1.0.26
From swagger-codegen release notes:

This  release brings 4 new API client generators and 5 new server stub generators. More than 500 enhancements and bug fixes have been successfully merged.

Note that swagger-compat-spec-parser v1.0.26  uses updated org.apache.httpcomponents:httpclient v4.5.2
This addresses CVE-2014-3577 and CVE-2015-5262
It does not matter if there is (or is not) real exposure to these CVE... they still lead to threat alerts being generated by security analysis software such as Nexus IQ.


Please help me..."Agent stopped due to max iterations."[BUG]

I've been trying to create an app, but whenever I try to use more than 1 user, it says "Agent stopped due to max iterations."
How can I create different conversations for each individual user? Even with the memory, it started replying to the second user what the first user actually asked.
Can you, please, help me?

hey @ForgottenFrog Flowise is still single user based, i.e messages/memory is per chatflow, not per user.


Title: Add Pre-commit Hook to Run Prettier and ESLint

I’d like to propose adding a pre-commit hook to our backend application. This hook would run both Prettier and ESLint before any commits are made. Here’s why I think this is a great idea:

Consistency: By automatically formatting code with Prettier and checking for linting issues with ESLint, we can ensure that our code remains consistent across the team.

Efficiency: This setup can help catch formatting and linting issues before they make it into the codebase, reducing the time spent during code reviews.

Simplicity: Having these tools run automatically means developers won’t have to remember to run them manually. It streamlines our workflow!

Implementing this change could greatly enhance our development process and maintain code quality.

@tejasbenibagde assigned

@tejasbenibagde resolved!


ignore nitpicky sphinx warnings on old library versions

Closes #1216

Current dependencies on/for this PR:

main

PR #1218   👈

This stack of pull requests is managed by Graphite.


metrics: fix the tso and id monitor

What problem does this PR solve?
Some metrics of cluster meta have been renamed like TSO and id allocation. The monitor cannot show them currently.
What is changed and how it works?
This PR fixes it by adjust the Grafana template. After this PR, the PD dashboard looks like:

Check List
Tests

No code

Related changes

PR to update pingcap/tidb-ansible:
Need to cherry-pick to the release branch

Release note

Fix the issue that the monitors of TSO and id allocation are missing

/merge

/merge

/merge

/merge

/merge

/merge


Error using webpack 2 with vue

What is the current behavior?
I got error of
throw new WebpackOptionsValidationError(webpackOptionsValidation Errors);
WebpackOptionsValidationError: Invalid configuration object. Webpack has been in itialised using a configuration object that does not match the API schema.
configuration has an unknown property 'vue'. These properties are valid:object { amd?, bail?, cache?, context?, dependencies?, devServer?, devtool?, entry, externals?, loader?, module?, name?, node?, output?, performance?, plugins?, profile?, recordsInputPath?, recordsOutputPath?, recordsPath?, resolve?, resolveLoader?, stats?, target?, watch?, watchOptions? }
For typos: please correct them.For loader options: webpack 2 no longer allows custom properties in configura tion.
Loaders should be updated to allow passing options via loader options in module.rules.Until loaders are updated one can use the LoaderOptionsPlugin to pass these options to the loader:
plugins: [
new webpack.LoaderOptionsPlugin({
// test: /.xxx$/, // may apply this only for some modules
options: {
vue: ...
}
})
]

Hi,
The configuration schema does not allow additional properties anymore.
Can you re-open at Stack Overflow as that's better for support (mentioned in the issue template)?

yes.because the webpack published the 2.0 versions, it's not supported the additional properties anymore.


Validate if fields exist before reading

This pull request is to handle empty yaml files when we use contentType: data. It is to sole the issue #361
As rawContent.fields  is empty, during validation phase, a simple return fix it.

Thanks a lot for opening this PR. I've just fixed the underlying issue with https://github.com/contentlayerdev/contentlayer/commit/014382cf555edbf1cbd201fcb8d0c5f2e973ac22 instead which addresses the problem a bit earlier in the program flow which I think is a bit more clean. Thanks a lot for your help with this!


Countdown on daily basis

We would like to be able to set a countdown to a specific time each day, currently I'd need to edit the screensaver each day. Is there a way to make this just time specific?

We would like to be able to set a countdown to a specific time each day, currently I'd need to edit the screensaver each day. Is there a way to make this just time specific?

Any update about this feature?


Move content to content/

The main directory is getting cluttered. Proposal: move all the "parts" directories into a subdirectory content/. Requires changes to some \olimport commands in driver files depending on where to content is (eg changing
\olimport*[sets-functions-relations]{sets-functions-relations}
to
\olimport*[content/sets-functions-relations]{sets-functions-relations}

No objections here.

Nor from me. — N
--
Nicole Wyatt
Head, Department of Philosophy
University of Calgary
+1-403-220-3166
<EMAIL_ADDRESS>

Fixed by commit 739a8f0e91bf947be2a6160cc4702d53c48d6ac6


fix: workspace package conditions

Vite bundles/inlines workspace packages by default.
It needs to bundle the right exports.
Without PR, packages in a monorepo that are linked are bundled with possibly node-only exports.
This is also an issue if something/someone sets a package as noExternal, the PR fixes that too.

Thanks! Released in v0.0.6


failed extract- bucket name is being removed frpom the command?

Hi
i've tried as below, it fails and the output looks as the bucket name (arik-share) is missing
is it because of the tgz?
[ec2-user@ip-172-31-46-20 ~]$ s3tar --region eu-west-1 -xvf s3://arik-share/vapp-ovf/ovf.tgz -C s3://arik-share/vapp-ovf/
2023/03/16 07:29:39 object does not exist s3://vapp-ovf/ovf.tgz/vapp-ovf/ovf.tgz
[ec2-user@ip-172-31-46-20 ~]$

checked with plain tar, looks the same
[ec2-user@ip-172-31-46-20 ~]$ s3tar --region eu-west-1 -xvf s3://arik-share/IoT_demo.tar -C s3://arik-share/
2023/03/16 07:44:20 object does not exist s3://IoT_demo.tar/IoT_demo.tar
[ec2-user@ip-172-31-46-20 ~]$

now i get different output
haven't done any change
[ec2-user@ip-172-31-46-20 ~]$ s3tar --region eu-west-1 -xvf s3://arik-share/vapp-ovf/ovf.tgz -C s3://arik-share/vapp-ovf/
2023/03/16 08:06:02 unable to parse header from TAR
[ec2-user@ip-172-31-46-20 ~]$

and
seems indeed it working, but have different issue
[ec2-user@ip-172-31-46-20 ~]$ s3tar --region eu-west-1 -xvf s3://arik-share/IoT_demo.tar -C s3://arik-share/
panic: runtime error: index out of range [1] with length 1
goroutine 1 [running]:
github.com/awslabs/amazon-s3-tar-tool.extractCSVToc({0xc509b0, 0xc0001ce870}, 0x7f586d3332a8?, {0x7ffca19855a6, 0xa}, {0x7ffca19855b1, 0xc})
/home/ec2-user/amazon-s3-tar-tool/extract.go:186 +0x4d8
github.com/awslabs/amazon-s3-tar-tool.Extract({0xc509b0, 0xc0001ce870}, 0xc0000fe580, {0x0, 0x0}, 0xc0001ca0a0)
/home/ec2-user/amazon-s3-tar-tool/extract.go:34 +0xc5
main.main.func1(0xc000168200)
/home/ec2-user/amazon-s3-tar-tool/cmd/s3tar/main.go:189 +0x893
github.com/urfave/cli/v2.(*Command).Run(0xc0000fe2c0, 0xc000168200, {0xc000134000, 0x7, 0x7})
/home/ec2-user/go/pkg/mod/github.com/urfave/cli/v2@v2.25.0/command.go:273 +0xa42
github.com/urfave/cli/v2.(*App).RunContext(0xc0000003c0, {0xc50940?, 0xc000122000}, {0xc000134000, 0x7, 0x7})
/home/ec2-user/go/pkg/mod/github.com/urfave/cli/v2@v2.25.0/app.go:332 +0x605
github.com/urfave/cli/v2.(*App).Run(...)
/home/ec2-user/go/pkg/mod/github.com/urfave/cli/v2@v2.25.0/app.go:309
main.main()
/home/ec2-user/amazon-s3-tar-tool/cmd/s3tar/main.go:212 +0xda7
[ec2-user@ip-172-31-46-20 ~]$ s3tar --region eu-west-1 -xvvf s3://arik-share/IoT_demo.tar -C s3://arik-share/
panic: runtime error: index out of range [1] with length 1
goroutine 1 [running]:
github.com/awslabs/amazon-s3-tar-tool.extractCSVToc({0xc509b0, 0xc0001c4c00}, 0x7f8a7e6fa3c8?, {0x7ffee5c3a5a6, 0xa}, {0x7ffee5c3a5b1, 0xc})
/home/ec2-user/amazon-s3-tar-tool/extract.go:186 +0x4d8
github.com/awslabs/amazon-s3-tar-tool.Extract({0xc509b0, 0xc0001c4c00}, 0xc000170160, {0x0, 0x0}, 0xc0001c00a0)
/home/ec2-user/amazon-s3-tar-tool/extract.go:34 +0xc5
main.main.func1(0xc0001610c0)
/home/ec2-user/amazon-s3-tar-tool/cmd/s3tar/main.go:189 +0x893
github.com/urfave/cli/v2.(*Command).Run(0xc0001706e0, 0xc0001610c0, {0xc00012c000, 0x7, 0x7})
/home/ec2-user/go/pkg/mod/github.com/urfave/cli/v2@v2.25.0/command.go:273 +0xa42
github.com/urfave/cli/v2.(*App).RunContext(0xc0001141e0, {0xc50940?, 0xc00011a000}, {0xc00012c000, 0x7, 0x7})
/home/ec2-user/go/pkg/mod/github.com/urfave/cli/v2@v2.25.0/app.go:332 +0x605
github.com/urfave/cli/v2.(*App).Run(...)
/home/ec2-user/go/pkg/mod/github.com/urfave/cli/v2@v2.25.0/app.go:309
main.main()
/home/ec2-user/amazon-s3-tar-tool/cmd/s3tar/main.go:212 +0xda7
[ec2-user@ip-172-31-46-20 ~]$

@arikyakir when you say "checked with plain tar" what do you mean? If you want to extract files using s3tar they have to be created with s3tar, it doesn't support un-taring regular files since there is a toc.csv file at the beginning that is added by s3tar.

The tars created with s3tar have an extra file at the beginning, a TOC that specifies the byte location and size of each file in the tar. This is what we use to extract the tar. Since existing files don't have this TOC, we don't support it.


tour: wrong word

Context: https://tour.golang.org/methods/15
In the sentence

A type assertion provides access to an interface value's underlying concrete value.

value should be replaced by the word type.

Sorry, I was wrong :-)


Add riscv build support.

Tested on my licheepi4a board and fix some missing part for build on riscv device.

Can one of the admins verify this patch?

@per1cycle we do not have a RISCV supported platform in hand but since this seems low impact and helps you, we will merge it.
Thanks for the PR :)


Site support request for noodlemagazine.com

Checklist

[x] I'm reporting a new site support request
[x] I've verified that I'm running youtube-dl version 2<IP_ADDRESS>
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that none of provided URLs violate any copyrights
[x] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single video: https://noodlemagazine.com/watch/281711238_456240128

Description

Greatings!
Add this site support, please.

I request this support too

youtube-dl -v https://adult.noodlemagazine.com/watch/-10605510_456252663 [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: [u'-v', u'https://adult.noodlemagazine.com/watch/-10605510_456252663'] [debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2021.12.17 [debug] Python version 2.7.18 (CPython) - Linux-5.13.0-21-generic-x86_64-with-LinuxMint-20.1-ulyssa [debug] exe versions: ffmpeg 4.2.4, ffprobe 4.2.4, rtmpdump 2.4 [debug] Proxy map: {} [generic] -10605510_456252663: Requesting header WARNING: Falling back on generic information extractor. [generic] -10605510_456252663: Downloading webpage [generic] -10605510_456252663: Extracting information [debug] Default format spec: bestvideo+bestaudio/best [debug] Invoking downloader on u'https://noodlemagazine.com/videofile/-10605510_456252663.mp4' ERROR: unable to download video data: HTTP Error 404: Not Found Traceback (most recent call last):   File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1976, in process_info     success = dl(filename, info_dict)   File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1915, in dl     return fd.download(name, info)   File "/usr/local/bin/youtube-dl/youtube_dl/downloader/common.py", line 366, in download     return self.real_download(filename, info_dict)   File "/usr/local/bin/youtube-dl/youtube_dl/downloader/http.py", line 351, in real_download     establish_connection()   File "/usr/local/bin/youtube-dl/youtube_dl/downloader/http.py", line 116, in establish_connection     raise err HTTPError: HTTP Error 404: Not Found


Adds SessionStoreProvider to InstagramFactory

This request creates a new class SessionStoreProvider. It will be used in the getClient method of  InstagramFactory Class. It will solve the issue #27.  I tested it in my current Laravel project. I couldn't figure out how to write custom tests for the getLoginUrl method within this pacakge. Help wanted. :)

Thanks for your contribution. Though, we've already something else in the works that will replace this setup.

Okay great! I found a strange behavior in the base package. (https://github.com/larabros/elogram/issues/42) May that goes in the same direction.

@traedamatic we're currently waiting on an update in the elogram package.


Write a starter guide document for new users of promo-tools

What would you like to be added:
Capturing previous discussions (ref https://github.com/kubernetes-sigs/promo-tools/pull/462#issuecomment-977534243 ),
it would be useful to create an introductory document to get folks started quickly on the basics of artifact promotion, geared towards new users of promotion tools.
The central idea would be to have a starter guide where users can get the essentials to be successful in what they want to accomplish, as noted by @justaugustus there are many paths and audiences:

... I see a lot of different paths to explore:

I just want to grab the tool and automagically create image promotion PRs
I want know a little bit about the architecture of this tool
I'm a Release Manager/potential maintainer and I need to know everything about how this works

There's another axis to consider:

Am I using this tool/subcommand as a user
Am I actually a bot that needs to run this unattended

/kind documentation
Why is this needed:
We need to point maintainers and other users to a one-stop doc to get things started when facing the promo-tools repo.

/remove-lifecycle rotten

/remove-lifecycle rotten

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale


Almost fully reworked and completed russian translation

All string were translated, many syntax and grammar errors were fixed.

finally I did it!


Action on Docker mentions in Tasks > Configure Multiple Schedulers

Umbrella issue #30771
Related issue #30929
Page: https://k8s.io/docs/tasks/extend-kubernetes/configure-multiple-schedulers
File: /tasks/extend-kubernetes/configure-multiple-schedulers.md
Rewrite the example and surrounding content on this page using an open-source runtime like containerd.
/triage accepted
/sig docs
/language en

/triage needs-triage

/remove-triage accepted

I'm not sure that this page needs to be changed in the context of the dockershim removal, since the task is about packaging kube-scheduler into an image to use as a second scheduler. If not needed, we can close this.

@shannonxtreme I recommend filing a separate issue for what you mentioned above, but I don't think it needs to change for dockershim.


Redux, forms and file uploading

I'm trying to understand what would be a good way to architect a form with file upload capability. Any tips?

Google "react file upload". There is surely something implemented already.

@israelidanny take a look at this issue: https://github.com/erikras/redux-form/issues/71

Reopen if still a problem.


Clarification on some options in the examples

Sorry, I hope these aren't dumb questions, but I was hoping to maybe get a little bit of elaboration on the documentation.

What is the precision option showed in the example?
Does extractIps simply serve as a method for uniquely identifying the client? I'd like to suggest a more generic name for this option if that is the case, then, like identifyClient. After all, this could be a good place to return something other than IP addresses, like maybe an API key sent in the request header (rate-limiting free API keys is a common practice) or a user's session ID -- all in case of an attacker switching proxies to bypass the limiter.
What does the weight option do?

The weight and precision parameters are discussed in the blog post linked in the README, that resource is here.
The weight parameter allows you to specify a variable "cost" per request, which essentially acts as a multiplier for each request (instead of a request costing 1 limit point it can cost 1 * multiplier limit points). The limit point explanation might sound a bit strange, but I think it's a simple way to think about it.
The precision argument is discussed at length in the "Sliding Windows" section of the article linked above, so I would highly recommend reading that in better detail.
Your suggestion of renaming extractIps is not a bad idea at all, and in fact as I quickly browsed through the first article mentioned in the readme, that is how the author named the function. We will likely make that change soon.

Thanks! I should've looked into that article first. This actually adds quite a bit of neat functionality, especially the sliding windows.
So how is precision represented?
{interval: 3600, limit: 1000, precision: 10000}

3600 I assume is a value in seconds (not milliseconds); but then, is precision represented in milliseconds (i.e. 10-seconds)?
Thanks!

Both the interval and precision are both specified in seconds. The number of buckets you have ends up being interval / precision, with the precision value defaulting to the interval value if not specified. That means the default behavior is an interval of size n with a single bucket.

Sorry, I guess I'm just confused as to the example code in the readme then. That would be 0.36 buckets (interval / precision). The quotient should be >= 1 to make sense, right? (And be an integer.)

I didn't even realize that was the case - yes it is a bit strange. Intuitively it should be an integer and greater than 1 so I'm not sure why that example is written as such. I'll certainly fix that as well! Thanks for pointing it out.

Okay cool, just wanted to make sure I understood everything correctly. This is a really awesome package by the way, and will assist greatly with helping to protect some intensive operations on a distributed app. Thanks a lot for creating this guys!

Glad you find it useful! I'll keep this issue open to track the extractIps rename and updating the README. Thanks again!

Actually - @mmiller42 I created two separate issues to track those things, so I'll go ahead and close this issue. It's been linked to in the other issues.


Replay buffer is storing multiple copies of the most recent episode

Hi @Itomigna2,
This is very cool work. Thanks for sharing it.
I was testing out your implementation here and noticed a bug. For every new episode you add an entry in the replay buffers for state, action, policy, and reward. But because you are using the same same list over and over you do not get unique episodes in the replay buffer, instead you get references to the same list so they all end up being the exact same most recent episode.
You can check this with this by inserting the code below. Here we are summing the first episode in the replay buffer and then testing if that sum is exactly the same for all of the other episodes in the buffer. You will see that they are.
for i in range(episode_nums):
    #...
    print("Size of replay buffer: ", len(agent.action_replay))
    print("All actions same in replay buffer?: ", all([sum(agent.action_replay[0]) == sum(r) for r in agent.action_replay]))
    print("All rewards same in replay buffer? ", all([sum(agent.r_replay[0]) == sum(r) for r in agent.r_replay]))
    agent.update_weights_mu(target)

The fix for this is pretty straightforward. We just need to change all of the list.clear() to new lists. Currently you have this at the end of update_weights_mu. I would suggest moving them to the beginning of self_play_mu.
        # remove these
        # self.state_traj.clear()
        # self.action_traj.clear()
        # self.P_traj.clear()
        # self.r_traj.clear()

        self.state_traj = []
        self.action_traj = []
        self.P_traj = []
        self.r_traj = []

Hi mvindiola1.
I'm very grateful for your help. I checked the code following your suggestion,
and I found you are exactly right. My code just have worked with on-policy setting.
I am trying to make progress with changed code in new branch 'testing_issue'.
Some changes (your suggestion, batch size 16 -> 64, online data 25% and replay data 75%, lr 0.00032->0.0003) applied to that code.
The training results,

https://colab.research.google.com/drive/164h_3ytA_BWOn_0wG8glCHdub4oXJ-Yp?usp=sharing
It learns faster, but has high variance. (Probably due to the absence of retrace estimator)
Thank you again for your perfect suggestion. It was very helpful!
Best regards,
Itomigna2


Crash in group handling

Reproduce like this:

open a single window
make it a group with togglegroup
open another window that gets added to that group
use movetoworkspace to move the focused window to another workspace (this enters the weird stage explained in https://github.com/hyprwm/Hyprland/issues/2229
close the window
go back to the workspace with the group (now containing only one window)
togglegroup
Crash!

The original issue seems to be fixed on latest, probably by https://github.com/hyprwm/Hyprland/commit/cbe9bf0e692010717e3d35e87a9abee79c5f8e4f
So i think this one is as well

@vaxerski


Fix typos

 Issue by tbm
Sat May 23 05:42:59 2020
Originally opened as https://github.com/codelucas/newspaper/pull/814

tbm included the following code: https://github.com/codelucas/newspaper/pull/814/commits

fixed


Compile error in clang 5.0

Hi.
In clang 5.0 I have an compile error:
json.hpp:9830:66: error: no type named 'string_view' in namespace std' and not std::is_same<ValueType, typename std::string_view>::value
I've found temporary solution (paste it after includes):
#if ((defined(__cplusplus) && __cplusplus >= 201703L) || (defined(_MSC_VER) && _MSC_VER >1900 && defined(_HAS_CXX17) && _HAS_CXX17 == 1)) && defined(__clang__)
#include <experimental/string_view>
namespace std {
    using string_view = std::experimental::string_view;
}
#endif

May be already created another better solution?
It can be helpful for people like me, who wants to get C++17 in clang :)
P.S. Sorry for my English :)

Duplicates #735

Thanks for reporting and sharing your solution. We shall see if we can integrate this with the proposal in #735.


Oculus Rift - hands/controllers aren't visible

The controls appear to work, as I was able to navigate the staging area using the analog sticks on the Touch controllers. However my "VR Hands" do no appear, despite the controllers being on and detected by the Steam VR interface.

I'm not sure... I don't have a Rift/Touch to test with. Maybe if you post a copy of the KSP.log, there may or may not be information there to help

Hi! Someone else with a Rift+Touch here. Here's my KSP.log:
KSP.log

Thanks @steamp0rt I think I see something wrong in the log. I'll try to come up with a fix soon, but in the meantime could you try the following?
Before you start up KSP, turn off the Touch controllers. Then start KSP, load your game, etc. Then turn on the Touch controllers. When you go into VR, I think hopefully you should see the hands.
I don't have a Touch, so I can't test this exactly, but I know you can do this with the Vive wands (keep them off until after I've loaded KSP, then turn them on).
I think the underlying problem here is having the controllers on during KSP start up, during which the glove models haven't been loaded into the game.

Hey, I tried turning touch controllers on after loading game save, but I am still unable to see my hands.
On logs there seems to be invalid format: Failed to load assembly D:\STEAM\steamapps\common\Kerbal Space Program\GameData\KerbalVR\openvr\win32\openvr_api.dll: System.BadImageFormatException: Format of the executable (.exe) or library (.dll) is invalid.
output_log.txt

I believed I fixed this in the new release: https://github.com/Vivero/Kerbal-VR/releases/tag/v3.2.4

Closed via #77


Removed pluginRepositories and repositories section from pom file

Ticket Link
GROUPINGS-1079
List of squashed commits
made only 1 commit
Test Checklist

[x] Unit Tests Passed:
[x] Jasmine Tests Passed:
[x] General Visual Inspection:

I added myself and zak to this ticket as well. These changes seem fine. Thank you for removing some of our old maven plugins as they can slow the build time of our application.


Internal Server Error

I get this error after installing the plugin:

Internal Server Error
Craft\Htmlcache_HtmlcacheService and its behaviors do not have a method or closure named "log".

I'm using Craft v2.6.2783.

fixed in latest master


False positive on telescoping constructors

When running infer I get the following error when trying to telescope my constructors.
src/main/java/Controller.java:60: error: NULL_DEREFERENCE
object null could be null and is dereferenced by call to Controller(...) at line 60

          @NonNull Source source,

          @NonNull Type type) {

    this(activity, config, listener, summary, source, type, null);

  }

The null here is passed into a @Nullable parameter in another constructor. Here null isn't actually dereferenced.

Unfortunately, it is hard to tell what is happening without more context about the definition of Controler. If I understood correctly, the constructor is of the form:
Controller(..., @Nullable Object obj) { ...}
where obj is not being dereference without a check for null inside the body of Controler. If that was the case, then the NPE would be reported in the body of Controler, not when calling the constructor with null somewhere else.
Would you be able to reproduce the issue on a small toy example ?

Please reopen with more details if you can.


Unable to free the intermediate values in the graph.

Hey, I was integrating Fast-Snarf with another project. However, I am not able to free up the gradients even though I am detaching the tensors of broyden cuda. Are you familiar with this error?
RuntimeError: Trying to backward through the graph a second time (or directly access saved tensors after they have already been freed). Saved intermediate values of the graph are freed when you call .backward() or autograd.grad(). Specify retain_graph=True if you need to backward through the graph a second time or if you need to access saved tensors after calling backward.

Wrapping the calculation of the gradients under torch.no_grad() solved the issue

Hi @coreqode,
I'm also having the same issue could you share the snippet for the above solution?
Thanks!


Validating fuzziness value in query

Signed-off-by: Subramanian S<EMAIL_ADDRESS>Description
Validated fuzziness values are only positive integers, AUTO or AUTO:int,int
Issues Resolved
Issue 4223
Check List
Tested positive integers, AUTO, AUTO:int,int cases, working as expected.
Other illegal values throw error.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@subbudvk,
Thank you for publishing your fixes!
Could you please add unit tests to ensure that new code is completely covered by tests?

@subbudvk, Thank you for publishing your fixes! Could you please add unit tests to ensure that new code is completely covered by tests?

Sure. Are these changes fine? I'll add tests shortly. @Yury-Fridlyand

@subbudvk Do you need any help on get the ball rolling on this PR, such as adding the unit test or need more eyes on it?

@subbudvk  Since this PR has been there for two months , would you mind if I take over this PR and add some tests to get it shipped?
cc @macohen

@macohen  could you please help with this PR?

Closing, issue was fixed in #5805.


System.Diagnostic not supported in net8.0-browser

In file HandlebarsHelper.cs there is a using of the System.Diagnostics package which is currently not supported for net8.0-browser.
The package is then used a t line 111 :
Add(Path.GetDirectoryName(Process.GetCurrentProcess().MainModule?.FileName), paths);

This makes the use of this package impossible for Blazor Webassembly projects.

https://github.com/Handlebars-Net/Handlebars.Net.Helpers/pull/106


Fix minor typos

I found some typos while browsing the code locally (with the help of misspell), so I decided to open up a PR with all typos found by this tool.
I would like to contribute more, but since I am fairly inexperienced with both Rust and Bevy, this is the best I can do right now :smile:

Thanks a ton <3 And yeah, seconding that. Discord is probably the best place to chat live about the development, but feel free to tackle any of the issues marked grab bag: they should be nice and approachable.


✨ [Feature request]: Allow selection of preferred styling language

Is your feature request related to a problem? Please describe.
Not a problem
Describe the solution you'd like
The command line input during play creation should allow the user to select their own choice of styling language (i.e.: CSS/SCSS) and accordingly a template file needs to be placed under the play directory.
Describe alternatives you've considered
NA
Additional context
NA

@naiknareshh
Thanks for starting on it. Could you please post a comment here so that, I can assign it to you?

Hey @atapas, yes please assign this to me


Improve resilience of github action "Publish documentation" executing on each PR

/As Developer
I want to see if markdown linting is failing on each PR
so that we have always a valid documentation on main
Hints / Details
Outcome / Acceptance Criteria

Outcome:

Added execution to PR (added condition to release only on main)
Added cache for plantuml jar to speed-up execution and save bandwith

Acceptance Criteria

[x] name: Publish documentation action is executed on each PR

Out of Scope

...

Issue is fixed / resilience of linter is improved.
PO acceptance in representation of @jzbmw


RC13 - dev SSR error with module 'mathjs'

Environment

Operating System: Linux
Node Version:     v18.12.1
Nuxt Version:     3.0.0-rc.13
Nitro Version:    0.6.1
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://github.com/matteomejia/mathjs-nuxt
Describe the bug
When using the library mathjs in development mode, import fails with the following error:
[nuxt] [request error] [unhandled] [500] __vite_ssr_import_0__.default is not a function
  at ./node_modules/mathjs/lib/esm/entry/configReadonly.js:16:30
  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  at async ViteNodeRunner.directRequest (./node_modules/vite-node/dist/client.mjs:250:5)
  at async ViteNodeRunner.cachedRequest (./node_modules/vite-node/dist/client.mjs:129:12)
  at async request (./node_modules/vite-node/dist/client.mjs:152:16)
  at async ./node_modules/mathjs/lib/esm/entry/mainAny.js:2:31
  at async ViteNodeRunner.directRequest (./node_modules/vite-node/dist/client.mjs:250:5)
  at async ViteNodeRunner.cachedRequest (./node_modules/vite-node/dist/client.mjs:129:12)
  at async request (./node_modules/vite-node/dist/client.mjs:152:16)
  at async mathjs:1:238

Error happens on any server-side loaded page.
Additional context

Problem does not happen when using Vite SSR outside of Nuxt 3.
Opened an issue in the mathjs repo but the error could not be reproduced.
The error can also be reproduced by loading the library via a plugin

Logs
No response

@matteomejia Do u use
build: {
    transpile: ['mathjs'],
  },

Had the same error while using the transpile key, without it works. Using Nuxt 3.1.1 with Nitro 2.1.0

@lowbits Tested it today with 3.1.1 and Nitro 2.1.0. It only works when the page is rendered in the client. Any SSR page that imports mathjs fails with the same error. If i load it via a plugin it crashes on startup, if not it crashes on page load. The devBundler option used to fix the issue, but now it has no effect. Transpiling the package never worked for me so I never used it. This is still a dev-only issue though, production has always been working fine with mathjs AFAIK.

@matteomejia sorry for the confusion, you're right! I switched now to a different evaluate method from another package. Works now like a charm.

Is there a good solution now?

Is there a good solution now? @matteomejia

I'm closing this as there is no longer a reproduction and this was created before the release of Nuxt 3. Please feel free to comment with an updated repro and I'll happily reopen.

Hi @danielroe this is still happening. Yes, you can bypass this by setting the page to only do CSR but still a hack. I'll add a repro later today


fix(bot, types): description being a required property on CreateSlashApplicationCommand.

The description is not required as indicated here:
https://discord.com/developers/docs/interactions/application-commands#create-guild-application-command

Looking on this further this is already according to the docs by using a discriminated unions for type 2 and type 3 commands (user and message commands respectivly)


Search Places

is there any way to search for places or cities??
I want to add a text input in which the user can enter the name of the location and search for that on the map.

You could use google places autocomplete API to achieve this. Here is an example of the onChangeText callback you could use on <TextInput  />
_onChangeText = async (input: string) => {
    this.setState({ input: input.trim() })
    try {
      const result = await fetch(
        `https://maps.googleapis.com/maps/api/place/autocomplete/json?key=${config.googleApiKey}&input=${input}&components=${COUNTRY_FORMAT}`
      )
      const data = await result.json()
      this.setState({ data: data.predictions })
    } catch (err) {
      console.log("## LocationPicker _onChangeText err: ", err)
    }
  }


feat: move build-push-ecr to Docker actions

docker/build-push-action has a lot more functionality than is available in a bare docker build command, like caching with GitHub Actions and cleaner support for multiple tags. As such, some projects don't use mbta/actions/build-push-ecr, which means our Docker build process is fragmented. Moving this action to docker/build-push-action should let more complexity move to the shared actions.
This was also the intent of #28, which stalled out in the review process. It was a great foundation to build on - thanks a ton @thecristen! - but I've made a few additional changes:

As it stands, the docker-additional-args input is just arbitrary command line flags passed to docker build, and docker/build-push-action has no mechanism to provide arbitrary command line flags, since it wants to encapsulate all of the available complexity in its own inputs instead. Conveniently, however, GitHub is willing to list all the @mbta repositories that use this action, and only two of them pass docker-additional-args (Skate and OTP-deploy), and both of those are only using --build-arg, so with a bit of shell scripting it's possible to maintain backwards compatibility. It's not really pleasant, though, so I'd be inclined to encourage those projects to migrate to a more direct mechanism as soon as this gets released, so it can be removed promptly before anything else starts to use it.
docker/metadata-action, which I hadn't known about until reading #28, has a lot of extremely cool functionality for applying tags conditionally. Glides, which applies an extra tag to prod deploys and uses that tag in the ECS task definition, has a ton of mess that can be mostly replaced with the docker/metadata-action tag logic. As such, it seems like it's worth trying to allow inputs to directly pass docker/metadata-action tag rules. The existing behavior of allowing a space-separated list in docker-additional-tags is more widely used than the existing docker-additional-args behavior, though, and it would be both more annoying and less valuable to migrate that department-wide, so I think it probably makes sense to support both behaviors indefinitely.
Tags are stuffed into the task output directly, via GitHub Actions's multiline strings in output files syntax, so there is no temporary file generated.
The dockerfile-path argument does not actually represent a path to a Dockerfile, but rather the path to the folder containing the Dockerfile. Since the current process is not docker build -f ${{ inputs.dockerfile-path }} but docker build ${{ inputs.dockerfile-path }}, the dockerfile-path input is properly provided to docker/build-push-action not as file: but as context:. The name is misleading, but that can't be changed backwards-compatibly.
Logs into the Docker registry with aws-actions/amazon-ecr-login instead of passing long-lived credentials to Docker directly.
Loads the container into the local Docker instance with load: true, and then pushes separately with docker push --all-tags. This is actually a really elegant solution to the fact that docker/build-push-action is broken in such a way that push: true and load: true are mutually exclusive, and I wish I'd found --all-tags in the docker push documentation earlier (although it may not have been there earlier).

Open questions:

At what point should a composite action be replaced with a reusable workflow? I think this may be across that line - it seems like it could be helpful to have the nicer UI for nested workflow calls, given how much is going on in this process now - but I don't know where the line really is. I'd be at peace moving this to mbta/workflows, but everything would have to migrate manually. (That'd save us some backwards compatibility issues, though.)
For some reason, aws-actions/amazon-ecr-login appears to technically leak the AWS account ID (via the ECR registry URL) in the GitHub Actions output. (Ask me on Slack for the link that shows this.) Does that matter?
How much testing is it worth doing before releasing this? I think most repos pin to mbta/actions@v2 rather than a specific minor version, but if this does wind up breaking something, it's not all that difficult to pin to @v2.2.1 or whatever until we can get it fixed.
Do we need the ability to disable the cache? I think we're mostly pretty good about starting with immutable images in our Dockerfiles, but if anything is doing FROM alpine:latest or what have you, it may pull from the cache before it pulls from the Docker Hub, in which case it'd always be at the old version of alpine:latest now that we're caching, causing this to technically be a breaking change. Several things have to go very wrong before that becomes a problem, though.

@boringcactus thanks for taking another stab at this!

Open questions:

At what point should a composite action be replaced with a reusable workflow? I think this may be across that line - it seems like it could be helpful to have the nicer UI for nested workflow calls, given how much is going on in this process now - but I don't know where the line really is. I'd be at peace moving this to mbta/workflows, but everything would have to migrate manually. (That'd save us some backwards compatibility issues, though.)

I don't see why you couldn't also make a reusable workflow for people to adopt, but I think that would be a larger change as a resuable workflow can't be used in quite the same way as an action.

For some reason, aws-actions/amazon-ecr-login appears to technically leak the AWS account ID (via the ECR registry URL) in the GitHub Actions output. (Ask me on Slack for the link that shows this.) Does that matter?

I don't love it (cc @ianwestcott ) but I suppose if Amazon thinks it's okay I guess it's fine.

How much testing is it worth doing before releasing this? I think most repos pin to mbta/actions@v2 rather than a specific minor version, but if this does wind up breaking something, it's not all that difficult to pin to @v2.2.1 or whatever until we can get it fixed.

I'd definitely want to test it with some existing applications, especially ones that you've already called out as using some of the non-default features.

Do we need the ability to disable the cache? I think we're mostly pretty good about starting with immutable images in our Dockerfiles, but if anything is doing FROM alpine:latest or what have you, it may pull from the cache before it pulls from the Docker Hub, in which case it'd always be at the old version of alpine:latest now that we're caching, causing this to technically be a breaking change. Several things have to go very wrong before that becomes a problem, though.

Is it possible to make using the cache optional, such that teams would need to opt-in to using it? Another approach would be to make this a non-backwards compatible update (either by releasing v3, making an action with a different name, or creating the reusable workflow).

Reusable Workflow
I think the benefits of moving to a reusable workflow would only really be apparent if something in this process breaks and needs to be debugged, and migrating would be a minor nuisance in the most basic cases but somewhat more involved for our web apps that need to extract static assets from the container image to upload them to a CDN or send source maps to Sentry. Having both a reusable workflow and a composite action would involve either maintaining them both in parallel (bad) or just calling the action from the workflow (pointless). If we were starting from scratch today, I think it'd make more sense to use a reusable workflow here and then put in more standardized tooling around asset extraction (which might be helpful anyway), but the migration probably wouldn't be worth the effort.
That said, Glides's existing deployment workflow involves asset extraction, so I could experiment somewhat with how difficult it actually is to build that process around a reusable build-push-ecr workflow. That migration effort might even be somewhat containable - when deploy-ecs moved from user-based to role-based authentication in mbta/actions@v2, @krisrjohnson21 went around to a bunch of different repos to make PRs to update GitHub Actions workflows accordingly, so if we thought it made sense and I had the time for it I could do something similar. This would be a more involved migration, though, since it isn't a drop-in replacement, so the teams maintaining the code would need to be more involved in the review process. Kris, is there any advice you'd give based on your experience with department-wide GitHub Actions workflow migration?
Guidelines for reusable workflow vs composite action that make sense to me as of this exact moment:

If the task requires more than just actions/checkout and perhaps asdf-vm/actions/install before it can be run, use a composite action. For example, even if mbta/actions/dialyzer was a shell script instead of a JS action, it wouldn't work as a reusable workflow, since it needs the Mix dependencies to be present. (If we standardize our dependency caching, this could change, but I didn't even know mbta/actions/npm-install even existed, and only one repo appears to use it.)
If the task has a single nontrivial step, use a composite action. For example, there would be no benefit to having mbta/actions/notify-slack-deploy as a reusable workflow.
If the task can be run from a clean checkout of the repository and has multiple nontrivial steps which could conceivably fail and need to be debugged, use a reusable workflow. For example, mbta/workflows/deploy-ecs doesn't require anything beyond the code, and it can fail in the container build or in the deployment.

If these guidelines are valid, then the existing implementation of build-push-ecr arguably makes sense as a composite action, depending on whether or not the supplementary tagging is considered nontrivial, but this implementation of build-push-ecr splits some logic out into docker/metadata-action and thereby moves across the line into reusable workflow territory.
Testing
I've tested in a project that only uses the advanced tag manipulation, and that feature works properly, including the output selection based on priority. I've opened https://github.com/mbta/otp-deploy/pull/29 to validate the build arg logic with multiple flags, so once that gets run, we'll be confident that that works.
Unfortunately, the GitHub dependency graph feature hides private repos and forks even if I have permission to see them, so I didn't see that we have a few more repos that also pass docker-additional-args, although conveniently they are still all --build-arg so there's no need to handle other types of additional args.
Only a few projects use docker/build-push-action directly, so migrating those onto this action should be fairly straightforward.

That said, Glides's existing deployment workflow involves asset extraction, so I could experiment somewhat with how difficult it actually is to build that process around a reusable build-push-ecr workflow.

I'd be excited to see how that turns out!
Not sure if it's a similar situation, but IIRC the primary reason Dotcom has its own bespoke setup is because, in the middle of our build-push-deploy steps, we have an extra step that extracts assets from the built image and uploads them to S3. So I'm not sure how I'd manage that with a reusable build-push-deploy action. 🤔

With a reusable workflow that has built-in support for extracting some files from the container, the process of migrating Glides winds up being only somewhat complicated, and the resulting UI is a lot nicer for exploring the output of each individual step than the composite action would be. Anyone who isn't handling Sentry release configuration the exact way we are would have a simpler time than that.
I did change my mind about having the cache be optional - since Glides passes the Sentry release name into the container via a Docker build arg, any layer after that is useless to cache, and any layer before that is already cached because we build our container in the CI process via docker/build-push-action already.
With a composite action, passing load: true into docker/build-push-action means later steps in the same job can just use the built container image directly, but with a reusable workflow, there are no later steps in the same job, so we have to get a bit creative. My current solution is to upload a tarball of the extracted files as a GitHub Actions artifact, so that a later job can download that artifact and extract the tarball, but that only matches how Glides approaches asset extraction, so perhaps a different approach would be more broadly compatible. (Both dotcom and Skate have shell scripts that take in a Docker image name as a parameter, so it might work to have the reusable workflow offer to run a shell script like that, but perhaps environment configuration or something would be an obstacle, I'd need to explore further. It'd probably be fairly straightforward to adjust the dotcom and Skate shell scripts to work with an assets tarball transferred via GitHub Actions artifacts.)

For some reason, aws-actions/amazon-ecr-login appears to technically leak the AWS account ID (via the ECR registry URL) in the GitHub Actions output. (Ask me on Slack for the link that shows this.) Does that matter?

@boringcactus thanks for flagging this; I've opened https://github.com/mbta/actions/pull/42 to address it.


RGL can't response when I using css to resize the parent div of RGL

[x] Bug
[x] Feature Request
[x] Question

Hi,
I have a problem with the response of the RGL.
I have a "side bar" in the left and the "main" div in the right.
When I click a button, the side bar is hide and the main is larger.
But the RGL in the main doesn't scale and fit the width of the main div.
When I change size of the browser, the RGL should be change.
So can I add the event from js to the RGL component ???

Can anyone help me ?


Module for accessing Lockout Manager

https://shibboleth.atlassian.net/wiki/spaces/IDP4/pages/1294074654/AccountLockoutManagement

Available (but undocumented and completely untested) in release 0.2.0


rename to page-specific-css-site

I would rename it because its not really a demo anymore :)

done, and done....


bump junit to 4.11

unify junit versions to avoid inconsistency...

There's JUnit 4.13 available. Does it really make sense to bump to 4.11 now?

@vlsi updated.


Update CHANGELOG for v1.5.0 release

Signed-off-by: Quan Tian<EMAIL_ADDRESS>

Branch is not cut yet, use this PR for review temporarily

Codecov Report

Merging #3214 (9f931ca) into main (839dc5c) will decrease coverage by 17.73%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #3214       +/-   ##
===========================================
- Coverage   58.95%   41.22%   -17.74%
===========================================
  Files         331      196      -135
  Lines       28223    23663     -4560
===========================================
- Hits        16639     9754     -6885
- Misses       9739    12911     +3172
+ Partials     1845      998      -847

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
41.22% <ø> (+0.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/ovs/openflow/default.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/util/runtime/runtime.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/ovs/openflow/logs.go
9.52% <0.00%> (-90.48%)
:arrow_down:

pkg/apis/controlplane/register.go
0.00% <0.00%> (-90.00%)
:arrow_down:

pkg/agent/controller/networkpolicy/reject.go
0.00% <0.00%> (-87.91%)
:arrow_down:

pkg/agent/nodeportlocal/k8s/annotations.go
0.00% <0.00%> (-83.88%)
:arrow_down:

pkg/agent/client.go
0.00% <0.00%> (-77.42%)
:arrow_down:

pkg/ovs/ovsconfig/ovs_client_linux.go
0.00% <0.00%> (-76.93%)
:arrow_down:

pkg/flowaggregator/certificate.go
0.00% <0.00%> (-76.58%)
:arrow_down:

...agent/controller/traceflow/traceflow_controller.go
0.00% <0.00%> (-73.41%)
:arrow_down:

... and 244 more

/test-whole-conformance
/test-networkpolicy
/test-e2e
/test-flexible-ipam-e2e
/test-multicluster-e2e
/test-windows-all
/test-ipv6-all
/test-ipv6-only-all

/test-windows-e2e
/test-windows-networkpolicy
/test-windows-proxyall-e2e

/test-ipv6-only-e2e

/test-windows-e2e
/test-windows-proxyall-e2e
/test-integration

/test-all-features-conformance
/skip-conformance (covered in whole-conformance)
/test-e2e
/test-hw-offload
/test-ipv6-networkpolicy
/test-ipv6-only-e2e
/test-ipv6-only-networkpolicy
/test-windows-e2e

/test-ipv6-only-networkpolicy

/test-windows-e2e

/skip-e2e as the only failure was because of image pulling error and https://github.com/antrea-io/antrea/pull/3224 will fix it.


Improve cropping quality after scale down

I found this solution http://stackoverflow.com/a/19223362/1252528 can improve image quality of canvas.drawImage.
Here is a demo http://jsfiddle.net/07jfxiao/otmgrmwp/3/

I'm starting to wonder if it'd be a good idea to expose the canvas object through the result method (somehow).  Letting the user do whatever they'd like to the cropped image.

Is there an easy way of integrating the solution provided above into croppie or any other algorithm like the one described here?:
http://stackoverflow.com/questions/18922880/html5-canvas-resize-downscale-image-high-quality
http://jsfiddle.net/gamealchemist/r6aVp/
Photos look pixelated after been scaled down, particularly with face close ups.

@galoram - Short Answer: no.  You're free to modify the source of croppie's _getCanvasResult (https://github.com/Foliotek/Croppie/blob/master/croppie.js#L840).
Or you can just call croppie's get method.  That will give you the points on the image that the end-user has selected.  Then you can basically write your own _getCanvasResult.
I'd like to expose a method that you can call to modify the canvas before returning the base64 image, but without any help, it's not going to happen anytime soon.  Sorry about that.

We badly need this thing resolved for https://yooocan.com.
I know very little about image processing, so I probably won't be able to help too much.
@bammoo maybe you can handle this?
@thedustinsmith Thanks for the awesome library! It greatly helps us in improving the lives of people with disabilities!

@gdoron - Feel free to grab the latest from master and play around with it.  I've changed the API to allow us to return just the canvas with the image drawn to it, by passing in type: 'rawcanvas' into the result method.
You can see this being done in demo.js: https://github.com/Foliotek/Croppie/blob/master/demo/demo.js#L53
I'd love it if you can try out the latest version of master combined with @bammoo 's stackoverflow link to see if you can get image quality improved.
Beware, this code isn't really fully tested at this point and there were quite a few larger changes, so if you can report any bugs I'd be happy to fix them or happy to accept PR's.

Thanks man!
I saw now @abuisine 's #204 issue.
I might go with his library if it's good.
I hope I'll have time to fiddle with it in the next day or two.
Thanks again!

Image after croppie:

After Stackoverflow code used with croppie:

So it seems like it works 👍 👍 👍
Can I use the code from master or is there something not quite stable there?
Many thanks!
p.s. for future me (or someone else): don't forget to remove
size: {
    	width: 100,
	height: 100
},

As if it's being used the image quality was already damaged when returned by the promise.

Thanks for the info.
Here are the changes that are in master that I wouldn't yet consider stable: https://github.com/Foliotek/Croppie/compare/v2.3.0...master
Whether or not you want to use them is entirely up to you.  The only way we really find bugs is if other people report them, so you could be our guinea pig.
I could probably release a pre-v2.4.0, but in my experience, people usually don't report problems for pre-releases, just regular releases.
These changes will make it into the next release, I just don't know when I'll have time to do that release.

I think I'll take the risk and use it.
I'll let you know when our website crashes and I'm looking for a new job. 🙈
BTW, both of the images were generated using quality: 0.9.

@gdoron could you provide an example of how you have used pica to handle scaling?  I have been doing some tests but have been unable to reproduce a similar increase in image quality.  Thanks!

@toddca I'm afraid I no longer work where I wrote that feature so I don't have access to the source code.
But if I'm not mistaken I used it somewhere on https://yoocanfind.com it was in the profile image or story telling image.
I hope it helps 🤐

Anybody tried improving quality using rawcanvas ?

Im getting the same problem.

when they should look like this

Im not sure how to implement the first solution.

When cropping the image, I can see that the CSS property of the preview image is in my case transform: translate3d(-2104px, -1335.9px, 0px) scale(0.0651);
By changing the translate3d to translate (and removing the Z point), the image is shown fine because the antiaiasing of the browser is triggered. However, this change is only for the cropping image preview phase of course, and not for the final result.
Since Chrome 54 there's a property that can be specified on the canvas
ctx.imageSmoothingQuality = "low" || "medium" || "high"
Maybe this could be a solution. I will try it.

@pabloleban  did you tried changing to jpeg?

@tomalex0 nope, but I found a similar solution like the one @bammoo posted, manipulating the rawcanvas.

@pabloleban  do you have sample code which works with croppie?

Sure, I did this:
uploadCrop.croppie('result',{circle: false, size: "original", type:"rawcanvas"}).then(function (rawcanv) {
  resample_single(rawcanv, 200, 200, true);
  var canvasBase64 = rawcanv.toDataURL();
  $.ajax({
    type:"post",
    url: base_url+"save_pic",
    data:{"pic":canvasBase64.substring(22)},
  });
}

And the resample_single function is this:
function resample_single(canvas, width, height, resize_canvas) {
  var width_source = canvas.width;
  var height_source = canvas.height;
  width = Math.round(width);
  height = Math.round(height);

  var ratio_w = width_source / width;
  var ratio_h = height_source / height;
  var ratio_w_half = Math.ceil(ratio_w / 2);
  var ratio_h_half = Math.ceil(ratio_h / 2);

  var ctx = canvas.getContext("2d");
  var img = ctx.getImageData(0, 0, width_source, height_source);
  var img2 = ctx.createImageData(width, height);
  var data = img.data;
  var data2 = img2.data;

  for (var j = 0; j < height; j++) {
    for (var i = 0; i < width; i++) {
      var x2 = (i + j * width) * 4;
      var weight = 0;
      var weights = 0;
      var weights_alpha = 0;
      var gx_r = 0;
      var gx_g = 0;
      var gx_b = 0;
      var gx_a = 0;
      var center_y = (j + 0.5) * ratio_h;
      var yy_start = Math.floor(j * ratio_h);
      var yy_stop = Math.ceil((j + 1) * ratio_h);
      for (var yy = yy_start; yy < yy_stop; yy++) {
        var dy = Math.abs(center_y - (yy + 0.5)) / ratio_h_half;
        var center_x = (i + 0.5) * ratio_w;
        var w0 = dy * dy; //pre-calc part of w
    var xx_start = Math.floor(i * ratio_w);
    var xx_stop = Math.ceil((i + 1) * ratio_w);
    for (var xx = xx_start; xx < xx_stop; xx++) {
      var dx = Math.abs(center_x - (xx + 0.5)) / ratio_w_half;
      var w = Math.sqrt(w0 + dx * dx);
      if (w >= 1) {
        //pixel too far
        continue;
      }
      //hermite filter
      weight = 2 * w * w * w - 3 * w * w + 1;
      var pos_x = 4 * (xx + yy * width_source);
      //alpha
      gx_a += weight * data[pos_x + 3];
      weights_alpha += weight;
      //colors
          if (data[pos_x + 3] < 255)
            weight = weight * data[pos_x + 3] / 250;
          gx_r += weight * data[pos_x];
          gx_g += weight * data[pos_x + 1];
          gx_b += weight * data[pos_x + 2];
          weights += weight;
        }
      }
      data2[x2] = gx_r / weights;
      data2[x2 + 1] = gx_g / weights;
      data2[x2 + 2] = gx_b / weights;
      data2[x2 + 3] = gx_a / weights_alpha;
    }
  }
  //clear and resize canvas
  if (resize_canvas === true) {
    canvas.width = width;
    canvas.height = height;
  } else {
    ctx.clearRect(0, 0, width_source, height_source);
  }

  //draw
  ctx.putImageData(img2, 0, 0);
}

Perfect response from @pabloleban with his rawcanvas and resample_single function.  Works great.

@pabloleban Can i get 5 min of your time?
I managed to get a working croppie system but i also have the quality problem, but i can't figure it out how i can alter my code so it is using your wonderful solution. i'm a noob in this :(
I know i need to put the function in the script. but then i'm stuck every thing i tried something to alter my viewer is gone.
`
//somme php stuff before this part to get my data etc ..

×
Upload & Crop Image

Crop & Upload Image

Close

`

I developed a fork of Croppie which implements a higher quality image scaling algorithm out of the box: https://theodorejb.github.io/cropt/


fix(support-bundle): orphaned ready SupportBundle blocking new creation

ref: https://github.com/longhorn/longhorn/issues/5882

Test result: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/3826/

The current support bundle mechanism can't support concurrent operations like create, download, etc.
@c3y1huang Probably we need to mention this in the doc.

@mergify backport v1.4.x


resize tab width based on opened tabs

In default theme, based on opened tabs, the tab width size will change to show most of the tabs. but in your theme, tab size not resizing based on opened tabs. So everytime i have to click on down arrow next to last tab's right side corner. Please fix it. Other than this, its just awesome.

hmm. What OS are running? Can you add a screenshot or screencast so I can see what you're referring too? Here's one showing my tabs resizing as I close them. http://quick.as/4zprcaxgq

sorry dude. no issues. sorry for posting. misunderstood.

No worries!


Update URLs in (and to) SCM rockspec, start an epoch

Closes #330

For the record all the changes from the published RC1 rockspec added here and the never-published RC2 rockspec that appears to have been a work in progess are tit-for-tat what is in the SCM rockspec now. I dropped it in favor of adding a new rockspec based on the SCM one as part of the next release cycle.

Yes that's what I was thinking too, one step at a time. I wanted to do as little as possible to get a Lua 5.4.3+ release tagged, then keep overhauling from there.


Calculate shared key according to RFC8446

Responder authentication multiple key exchange example
The DHE secrets are computed as specified in clause 7.4 of RFC 8446.
in RFC 8446, 7.4:
The negotiated key (Z) is converted to a
byte string by encoding in big-endian form and left-padded with zeros
up to the size of the prime.

Related issue in specification: https://github.com/DMTF/Security-TF/issues/1351


fix: kcctl subcommand has a bug where the ssh port is 0

Signed-off-by: zhuzhenfan<EMAIL_ADDRESS>
What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix the bug that the kcctl subcommand has a ssh port of 0.
Which issue(s) this PR fixes:

Fixes #262
Special notes for reviewers:
@x893675 @Metrora

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

@x893675 @Metrora

Codecov Report

Merging #263 (84f5c3f) into master (c7f612e) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   13.11%   13.06%   -0.05%
==========================================
  Files          98       98
  Lines       15364    15395      +31
==========================================
- Hits         2015     2012       -3
- Misses      13110    13142      +32
- Partials      239      241       +2

Impacted Files
Coverage Δ

pkg/utils/sshutils/ssh.go
0.00% <0.00%> (ø)

pkg/utils/sshutils/ssh_v2.go
17.54% <0.00%> (-2.10%)
:arrow_down:

pkg/apis/core/v1/schema.go
69.72% <0.00%> (-2.11%)
:arrow_down:

pkg/apis/core/v1/utils.go
54.12% <0.00%> (-1.85%)
:arrow_down:

pkg/apis/core/v1/handler.go
0.33% <0.00%> (-0.01%)
:arrow_down:

pkg/scheme/core/v1/k8s/kubeadm_step.go
0.00% <0.00%> (ø)

/lgtm
/approve

/cherrypick release-1.2


Wrong instructions

You are instruction to
 npm install material-ui-phone-input --save
Whilst you have renamed the project to material-ui-phone-number
So, all you have to do is:
 npm install material-ui-phone-number --save

The documentation has now been fixed. Thanks again!


grizzly: 0.4.3 -> 0.4.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/grafana/grizzly/releases.
meta.description for grizzly is: Utility for managing Jsonnet dashboards against the Grafana API
meta.homepage for grizzly is: https://grafana.github.io/grizzly/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.4.5 in filename of file in /nix/store/jkcdbxppg4mxgfg8mwhb5w9qlh2z8mr7-grizzly-0.4.5

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

grizzly

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jkcdbxppg4mxgfg8mwhb5w9qlh2z8mr7-grizzly-0.4.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A grizzly https://github.com/r-ryantm/nixpkgs/archive/1ea135a1175a24bd44e65a3f333cc5e253087235.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1ea135a1175a24bd44e65a3f333cc5e253087235#grizzly

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jkcdbxppg4mxgfg8mwhb5w9qlh2z8mr7-grizzly-0.4.5
ls -la /nix/store/jkcdbxppg4mxgfg8mwhb5w9qlh2z8mr7-grizzly-0.4.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

grizzly

Maintainer pings
cc @nrhtr for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 336774 run on aarch64-darwin 1

1 package built:

grizzly


[release-1.9] Upgrade to latest dependencies

bumping pkg -dprotaso
/cc knative-sandbox/serving-writers
/assign knative-sandbox/serving-writers
Produced by: knative-sandbox/knobots/actions/update-deps

/lgtm
/approve


register CFMG.jl as a standard Julia package

Registration is handled by Registrator.jl.
Documentation here describes how to register. Only the owner has the right to register the package.
We can try to register first and JuliaRegistrator robot would throw out any requirement that is unmet.
When I was registering GFFJ.jl, it threw out:

Name does not meet all of the following: starts with a capital letter, ASCII alphanumerics only, ends in lowercase
Name is not at least five characters long
Repo URL does not end with /name.jl.git, where name is the package name
The following dependencies do not have a compat entry that has an upper bound: CPLEX, GLPK, Gurobi, JuMP, julia

The registration for GFFJ.jl finally failed as detailed in New package: GFFJ v0.1.0.
The registration log for GapFindFill.jl is here. It couldn't pass auto-merging, but was later approved by some manager since it's a commercial license issue.

see report here


refactor(navbar): split ColumnNavDropdown component and file

Based on our team's decision, we no longer require approval of the refactoring pull request. Instead, we will review and approve the refactoring once all changes related to a specific component have been completed.