Chore: Product name and type

Changelog Description
Goal of this PR is to start using product naming in code base. Which means to use productName and productType instead of subset and family during create and publish phase.
Additional info
First of all I'm 100% sure that I broke something, if you can, please do code review first before you try to run. If you find any issues please report as soon as possible, you can DM me with quick questions.
All changes should support compatibility with workfiles before this PR in all hosts.
All the time when a family did represent product type, it should be changed to product type. e.g. create plugin does have product_type instead of family and created instance has productType in data instead of family.
One of the goals was to also use productType instead of family during publishing and use only families for pyblish filtering. The key family key is filled by pyblish automaticlly to "default", so it should not be an issue. But when we planned it, we didn't realize that sometimes instance.data are filled with raw data from scene, and in that case there might be family with a value that is not managed by us, speaking only about logic or workfiles with instances before this PR. I've changed that idea and all the time productType is changed during publishing, family is changed too.
What I couldn't resolve

Json files in Blender and Unreal
Sometimes it looks like the json is storing data that are unused, and sometimes I couldn't find source of their data so I couldn't tell if/how should I modify them. Sometimes the data are stored unclearly under key that says nothing about the value, e.g. json has "_id" which in fact represents representation id. Some of the json files are storing family which should be probably changed to product_type but I didn't find where the value is used. etc.

Json files in Maya
This is just about looks publishing, needs validation that I didn't break anything.

Resolve and Hiero
I probably failed at backwards compatibility.

Testing notes:

For host testing go one by one.
Go through code if you can and scan if you find invalid changes.
Open host and try all create plugin and publish. Validated output if can be loaded.
Open the host you're testing with workfile that does have instances before this PR and publish them.
[x] 3dsMax
[x] AfterEffects
[ ] Blender
[x] Fusion
[x] Hiero
[ ] Houdini
[ ] Maya
[x] Nuke
[x] Photoshop
[x] Resolve
[x] SubstancePainter
[ ] TrayPublisher - simple creators
[ ] TrayPublisher - editorial
[ ] TVpaint
[ ] Unreal
[ ] Celaction
[ ] Flame
[ ] Harmony

Note: This PR is clashing Hiero integration PR https://github.com/ynput/ayon-core/pull/87

Tested in Substance Painter, Looks good.
Tested in 3dsMax, so far so good,

Who could believe that productName exists in one of Houdini nodes 🥲.
Any ideas @moonyuet @antirotor @BigRoy 🥹 ?

Who could believe that productName exists in one of Houdini nodes

Houdini does store AYONProductName from now, please try it out.

I think there's something broken in the dynamic_data
Here's a test with the same Ayon settings.

 This branch
 Develop Branch

I think there's something broken in the dynamic_data
Here's a test with the same Ayon settings.

Please be more specific, I don't see anything broken, nor even know where to look.

Please be more specific, I don't see anything broken, nor even know where to look.

The product name in the publisher doesn't follow the product name profile in my settings.

Getting this when opening the creator in Blender:
Traceback (most recent call last):
  File "C:\Dev\Ynput\ayon-core\client\ayon_core\pipeline\create\context.py", line 2050, in _create_with_unified_error
    result = creator.create(*args, **kwargs)
  File "C:\Dev\Ynput\ayon-core\client\ayon_core\hosts\blender\plugins\create\create_workfile.py", line 46, in create
    product_name = self.get_product_name(
  File "C:\Dev\Ynput\ayon-core\client\ayon_core\pipeline\create\creator_plugins.py", line 549, in get_product_name
    return get_product_name(
  File "C:\Dev\Ynput\ayon-core\client\ayon_core\pipeline\create\product_name.py", line 135, in get_product_name
    asset_tasks = asset_doc.get("data", {}).get("tasks") or {}
AttributeError: 'str' object has no attribute 'get'

Hiero and Resolve works!

Traypublisher's Simple EDL editorial works like a charm ;)

Traypublisher's Simple Creators works too.

Creator Tab in Publisher tool is able to get the product name correctly.
Thanks.


No information how to use mod

Can you write a quick wiki on how to get started in the mod or make a book ingame for it. Would be extremely usefull. Thanks

There is a link to youtube videos on the curse page.  I do have a wiki half
written up but has a lot left to write.
On Jun 24, 2016 3:27 PM, "AnarchySage"<EMAIL_ADDRESS>wrote:

Can you write a quick wiki on how to get started in the mod or make a book
ingame for it. Would be extremely usefull. Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/zmaster587/AdvancedRocketry/issues/150, or mute the
thread
https://github.com/notifications/unsubscribe/ADX3Lffo33LaROgKNwbXfXIY7CGx0sCIks5qPC-5gaJpZM4I-Dlx
.

Yeah but the videos are update, and not so much a "how to" or anything

The first one on there should be general how the mod works, the rest are
update.  Once I get to a computer I'll link it
On Jun 24, 2016 6:16 PM, "AnarchySage"<EMAIL_ADDRESS>wrote:

Yeah but the videos are update, and not so much a "how to" or anything
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zmaster587/AdvancedRocketry/issues/150#issuecomment-228475802,
or mute the thread
https://github.com/notifications/unsubscribe/ADX3LYYN9DKtk-04bsOYFGoBHH1SB0f1ks5qPFcvgaJpZM4I-Dlx
.

Alright, why not create an open wiki and let users update/help?

I have a wiki half made, however most wiki hosting places either has nasty catches or is not free... If i could find one I would use it.
https://youtu.be/00XS_n6zR14 is the youtube with the main info.

true, make a book ingame then

`package com.vanityblocks.Dimensions;
import java.util.List;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.nbt.NBTTagString;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
public class VbMwManual extends ItemBlock
{
public static ItemStack manual;
static
{
    NBTTagCompound nbt = new NBTTagCompound();
    nbt.setString("author", "AnarchySage");
    nbt.setString("title", "Vanity Mining Dimension Help");

    NBTTagList pages = new NBTTagList();
    pages.appendTag(new NBTTagString("1", "      VanityBlocks\n      Mining World\n      Dimensions\n\nUser's Manual v1.0\n\n\n"
            + "Attention: If you still dont understand this, check the thread."));
    pages.appendTag(new NBTTagString("2", "Thank you for using the VB Dimensions Mod. Most everything can be changed in the config. Please check there for more config options."));
    pages.appendTag(new NBTTagString(
            "3",
            "This section will teach you how to make the portal shapes. You can see the design here(hard to explain) \n http://imgur.com/a/uKxAL \n The structure is always in that shape except for the hell dimension. "));
    pages.appendTag(new NBTTagString(
            "4",
            "Note the middle block in that structures bottom(the grass block(Redstone Ready world so discolored) \n Anyways, its the identifier, on the next page is biome name and its identifier block to open the portal there. \n (Lapis Block is always Required at top cept for hell)"));
    pages.appendTag(new NBTTagString(
            "5",
            "The possible dimensions are.. \n Plains - Grass Block \n Desert Hills - Sandstone Block \n Extreme Hills - Emerald Block \n Forest - Any Wood Log(Vannila)(direction doesnt matter) \n Taiga - Snow Block \n  Cont -> Next Page"));
    pages.appendTag(new NBTTagString(
            "6",
            "Swampland - Clay Block \n Shroom Island - Mycelium \n Jungle - Any leaves(Vannila) \n For the hell dimension its a bit different. All the stone is netherbrick and the lapis/identifer blocks are normal Nether Quartz Blocks."));
    pages.appendTag(new NBTTagString("7",
            "Then you right click with the lighter on the identifier block and the portals spawn, viola :) Enjoy. Please report any bugs you find, this was alot of work and effort for me."));
    pages.appendTag(new NBTTagString("7",
            "      Credits\nThanks to RebelKeithy for making Atum. Helped alot. \n\nThanks to mDiyo for help here and there. \n\nThanks to Kodos for helping with ideas/testing."));

    nbt.setTag("pages", pages);
    manual = new ItemStack(Item.writtenBook);
    manual.setTagCompound(nbt);
}

public VbMwManual(int id)
{
    super(id);
    setContainerItem(this);
    setCreativeTab(DimensionManagement.tabDimensions);
    setMaxStackSize(1);
}

@SuppressWarnings({ "rawtypes", "unchecked" })
@Override
@SideOnly(Side.CLIENT)
public void addInformation (ItemStack stack, EntityPlayer player, List infoList, boolean advancedTooltips)
{
    infoList.add("If you're lost, read the (in-game) manual");
}

@SuppressWarnings({ "rawtypes", "unchecked" })
@Override
@SideOnly(Side.CLIENT)
public void getSubItems (int itemId, CreativeTabs creativeTab, List subTypes)
{
    subTypes.add(new ItemStack(itemId, 1, 0));
    subTypes.add(manual);
}

}`
Bit of book code to help btw if you didnt know how it worked/used it

It'll take just as long to make an ingame book as it would a wiki.  I have hosting for a wiki, but user generated posts are out of the question for now.

@zmaster587 Doesn't the mod have a partially created wiki here on Github that can be edited by anyone? I remember pushing at least one page to a wiki somewhere.

I had forgotten about that, I'll push what I have to that later tonight
On Jun 30, 2016 11:50 AM, "TheGuyRunningSouth"<EMAIL_ADDRESS>wrote:

@zmaster587 https://github.com/zmaster587 Doesn't the mod have a
partially created wiki here on Github that can be edited by anyone? I
remember pushing at least one page to a wiki somewhere.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zmaster587/AdvancedRocketry/issues/150#issuecomment-229701681,
or mute the thread
https://github.com/notifications/unsubscribe/ADX3LRRd0yIu5aNSNkygm6eiMBc-TrLLks5qQ-WwgaJpZM4I-Dlx
.

So hows that info going @zmaster587 , cant seem to get started with the mod myself without some info, like where is dilithium, what does the observatory do, etc, get with direwolf20 for a proper spotlight, or something man, awesome mod, but i want to remove it for gc(just cause of lack of info :/)

There are several videos on YouTube which can be found on the curse forge
page for the mod
On Jul 16, 2016 3:15 PM, "AnarchySage"<EMAIL_ADDRESS>wrote:

So hows that info going @zmaster587 https://github.com/zmaster587 ,
cant seem to get started with the mod myself without some info, like where
is dilithium, what does the observatory do, etc, get with direwolf20 for a
proper spotlight, or something man, awesome mod, but i want to remove it
for gc(just cause of lack of info :/)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zmaster587/AdvancedRocketry/issues/150#issuecomment-233146237,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADX3Lbub9MK0pB40u6knpjicOy32bxC7ks5qWS3WgaJpZM4I-Dlx
.

There are also several good walk throughs around youtube which come up if
you search the name of the mod.  As of late I have had no time to develop
the mod let alone write docs for it.  From what I understand, dire wolf
does not do reviews by just asking him.
On Jul 16, 2016 4:14 PM, "Taylor Loz"<EMAIL_ADDRESS>wrote:
There are several videos on YouTube which can be found on the curse forge
page for the mod
On Jul 16, 2016 3:15 PM, "AnarchySage"<EMAIL_ADDRESS>wrote:

So hows that info going @zmaster587 https://github.com/zmaster587 ,
cant seem to get started with the mod myself without some info, like where
is dilithium, what does the observatory do, etc, get with direwolf20 for a
proper spotlight, or something man, awesome mod, but i want to remove it
for gc(just cause of lack of info :/)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zmaster587/AdvancedRocketry/issues/150#issuecomment-233146237,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADX3Lbub9MK0pB40u6knpjicOy32bxC7ks5qWS3WgaJpZM4I-Dlx
.

i found one which explains the function of each block but thats it, not a guide line persee

I'll make a video guide at some point then
On Jul 16, 2016 4:21 PM, "AnarchySage"<EMAIL_ADDRESS>wrote:

i found one which explains the function of each block but thats it, not a
guide line persee
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zmaster587/AdvancedRocketry/issues/150#issuecomment-233149179,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADX3LdjqUpsYxkBapKbHOS4n9gFZ9WGFks5qWT1ggaJpZM4I-Dlx
.

Appreciate it, thanks, i can understand not having time to code, but video guide is easy, if i knew how to use it, i would have lol.

@zmaster587 If you want to send me what you have written already, I can attempt to get it posted. (Not rushing you, just offering help.)

This is the wiki as it is so far http://<IP_ADDRESS>:25565/AdvancedRocketry/

Why not host it on github?

github does not allow 90% of the formatting I'm using to make it look polished

@zmaster587 maybe he means host the site code on github so it can be downloaded & viewed?

What dark said, sorry, just basic info for now then polish it up would be nice tbh

@zmaster587 Heres another solution, makes you money as well, http://www.indiewikis.com/  Not sure how it works, came across it via mekanism wiki.

As long as he puts ads on the site it makes money :)

I've got a site halfway built, just I don't have time to work on it.
https://github.com/zmaster587/AdvancedRocketryDoc

I've got it hosted here for now, wasn't linking it before due to bandwidth limitiations, but I've got it solved now.
http://<IP_ADDRESS>:25565/AdvancedRocketry/

@zmaster587 if you have issues with bandwidth just tell dmod and I will host the files for you no problem :)


Added a step after deploy to trigger runscope tests

There's a bucket of tests that are setup in Runscope to test Northstar on production. These tests act as additional validation of deployed code.
The curl request alone is enough to trigger the tests, and the RUNSCOPE_TRIGGER_URL has been setup in wercker.
cc: @blisteringherb

:+1:

so fetch


Indepth tutorial requested

I am a super noob dealing with this kinda stuff, so I'd appreciate an idiot-proof guide on how to do this, preferably as a video. Just for reference, I am on High Sierra, and have gotten as far as working with .bashrc, and I'm not entirely sure if I did it correctly.

Have you managed to install the dependencies and start "launchclient"?
Have you had a look at http://microsoft.github.io/malmo/0.30.0/Python_Examples/Tutorial.pdf ? This is a pretty good starting point if you take the time to do every 'exercise'

I have installed the dependencies, is launchclient a thing you do in terminal? Also, will give the link a try.

Yeah launchclient.bat for Windows or launchclient.sh for Mac/Linux is the file that starts the Minecraft server. So you open one terminal, navigate to where that file is located, and run that file. Then you open a second terminal from which you can start an agent in your preferred language (the 'default' or most widely used language is python, there are also many examples available for python). These things are also explained at the start of the tutorial, so I really advise you to walk through that and play around with the commands / concepts introduced there.
If you still have specific or broad questions afterwards, feel free to open an issue, or join the gitter: gitter.im/Microsoft/malmo where you can chat with others about the malmo project.


chore: added target blank to Concepts and tutorial part

fixes: #2601
I have added target blanks to the part shown with a green correct sign:

hey @alequetzalli Please review these initial changes so that I can move forward

@alequetzalli @smoya Friendly reminder!

The target="_blank" is a default behavior change: the default behavior of a link is to open on the same page (as if the link had a target="_self" ). Although you may be used to links opening in a new tab or window, this is a personal preference.
Unfortunately, closing this PR.


Don't rebuild binaries for test-only changes

Don't run rebuild CI jobs for test-only changes.
These jobs are testing prod binaries, which should not include test compilation.

Lint changes were made per prettify


Toyota: Allow DSU Re-routing

Description
In light of the recent "Harness Malfunction" issue relating to the SmartDSU, I have decided to make a harness that allows the DSU to be re-routed to the camera side of the existing harness. Thus eliminating the need for a SmartDSU, reducing hardware costs to the end-user, and, if widely adopted, allows most Toyota's longitudinal to be handled like TSS 2.0 cars.
A very crude hand drawn schematic is attached for your reference.

Verification
Drove with comma device, and verified that openpilot is controlling longitudinal; drove without comma device, and verified that the stock longitudinal is working as expected.
Route
Route: 7069d98b0de453c0/2024-03-05--18-53-02

Responded on Discord.


(MyXQL.Error) (1071) Specified key was too long; max key length is 3072 bytes for any index size

I was playing with the idea of migrating a Postgres database to MySQL 8 but the experience hasn't been pleasant so far.
After running the migrations (mix ecto.migrate --log-sql) I'm having this error:
17:41:08.793 [info]  create table locations

17:41:08.835 [debug] QUERY OK db=41.7ms queue=0.5ms idle=50.6ms
CREATE TABLE `locations` (`id` binary(16) NOT NULL, `country` varchar(255), `country_slug` varchar(255), `city` varchar(255), `city_slug` varchar(255), `state` varchar(255), `state_slug` varchar(255), `district` varchar(255), `district_slug` varchar(255), `city_summary` varchar(255), `city_summary_slug` varchar(255), `inserted_at` datetime NOT NULL, `updated_at` datetime NOT NULL, PRIMARY KEY (`id`)) ENGINE = INNODB []

17:41:08.835 [info]  create index locations_country_state_city_district_index

17:41:08.883 [debug] QUERY ERROR db=1.1ms queue=46.8ms idle=0.1ms
CREATE UNIQUE INDEX `locations_country_state_city_district_index` ON `locations` (`country`, `state`, `city`, `district`) []
** (MyXQL.Error) (1071) Specified key was too long; max key length is 3072 bytes
    (ecto_sql 3.6.2) lib/ecto/adapters/sql.ex:760: Ecto.Adapters.SQL.raise_sql_call_error/1
    (elixir 1.12.0) lib/enum.ex:1553: Enum."-map/2-lists^map/1-0-"/2
    (ecto_sql 3.6.2) lib/ecto/adapters/sql.ex:848: Ecto.Adapters.SQL.execute_ddl/4
    (ecto_sql 3.6.2) lib/ecto/migration/runner.ex:343: Ecto.Migration.Runner.log_and_execute_ddl/3
    (ecto_sql 3.6.2) lib/ecto/migration/runner.ex:117: anonymous fn/6 in Ecto.Migration.Runner.flush/0
    (elixir 1.12.0) lib/enum.ex:2356: Enum."-reduce/3-lists^foldl/2-0-"/3
    (ecto_sql 3.6.2) lib/ecto/migration/runner.ex:116: Ecto.Migration.Runner.flush/0
    (stdlib 3.15) timer.erl:166: :timer.tc/1
    (ecto_sql 3.6.2) lib/ecto/migration/runner.ex:25: Ecto.Migration.Runner.run/8
    (ecto_sql 3.6.2) lib/ecto/migrator.ex:324: Ecto.Migrator.attempt/8
    (ecto_sql 3.6.2) lib/ecto/migrator.ex:251: anonymous fn/5 in Ecto.Migrator.do_up/5
    (ecto_sql 3.6.2) lib/ecto/migrator.ex:295: anonymous fn/6 in Ecto.Migrator.async_migrate_maybe_in_transaction/7
    (ecto_sql 3.6.2) lib/ecto/migrator.ex:310: Ecto.Migrator.run_maybe_in_transaction/4
    (elixir 1.12.0) lib/task/supervised.ex:90: Task.Supervised.invoke_mfa/2
    (elixir 1.12.0) lib/task/supervised.ex:35: Task.Supervised.reply/5
    (stdlib 3.15) proc_lib.erl:226: :proc_lib.init_p_do_apply/3

Even if I override the index name to be shorter, the problem still persists:
create unique_index(:locations, [:country, :state, :city, :district], name: "i").
After searching a little bit on the internet it seems there's no obvious solution, problems vary between changing engine, charset, or collation. There's also this other issue that seems related, but as you can see from the logs, the table columns are already limited by default to 255.
I just did a clean installation of the MySQL package on WSL (mysql  Ver 8.0.25-0ubuntu<IP_ADDRESS> for Linux on x86_64 ((Ubuntu))). It seems that the experience out-of-the-box is not as smooth as I thought it would be for Postgres.

Definitely do not want to spray hate here (just freshly started with elixir + phoenix), but never encountered this issue before on rails + mysql, when setting unique index, leading me to believe that this it is still a bug.

The @rkorzeniec's fix of setting the size opt to 191 does the trick, but what would be a long-term solution for this? It's really counterintuitive and it's the first time I've encountered this problem as well.

Yes, the comment in the issue you linked explains it. The issue is not the index name. The issue is that you are indexing data that is longer than the maximum index size. This is a MySQL behaviour, there is nothing Ecto can do. Either change the column or index only part of the data.

I also recommend reading the reply to the comment you quoted in full: https://github.com/elixir-ecto/myxql/issues/102#issuecomment-752053310


Make build-registry work correctly when ember-data addon is used

Credit for fix code goes to @rwjblue, I am merely the humble PR creator.
This addresses emberjs/data#4071.

Thank you! I'll release shortly...

@rwjblue just curious, do you have an ETA? Also will this have to kick off a release in ember-quint and ember-cli-qunit as well?


Value predication: The generated Console App project is running failed.

System Information (please complete the following information):
Windows OS: Windows-11-Enterprise-22H2
ML.Net Model Builder 2022: <IP_ADDRESS>0801 (Main Build)
Microsoft Visual Studio Enterprise: 2022(17.5.5)
.Net: 6.0, 7.0
Describe the bug

On which step of the process did you run into an issue:
The generated Console App project is running failed.

TestMatrix
https://testpass.blob.core.windows.net/test-pass-data/taxi-fare.csv
To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio start window.
Choose the C# Console App (.NET Core) project template.
Add model builder by right click on the project.
Select Value predication scenario.
On Data page, choose the data source to complete the training,
Go to the Consume page, click "Add to solution" button to generate Console App project.
Run the generate Console App project, it is running failed.

Expected behavior
The generated Console App project should be running successfully.
Screenshot

Additional context
The generated Web API project can be running successfully.

The bug has been fixed on the latest main build <IP_ADDRESS>2301.


Catalogue of ADR's and and components

As a developer
I would like to know what component and ADR's their are
So I can understand the current architecture and
Acceptance criteria:
Link the components
Link to the ADR's (scripted)
Suggestion:
Build a github action to retreive md files (ADR's) to publish it all together (time based)

Open questions:
Where to host this? confluence?

Not relevant for now


TypeError: Cannot convert GlobalWindow to apache_beam.utils.windowed_value._IntervalWindowBase

Hi Team,
We recently went into this error: TypeError: Cannot convert GlobalWindow to apache_beam.utils.windowed_value._IntervalWindowBase
Full error log:
Error message from worker: generic::unknown: Traceback (most recent call last):   File "apache_beam/runners/common.py", line 1458, in apache_beam.runners.common.DoFnRunner._invoke_bundle_method   File "apache_beam/runners/common.py", line 561, in apache_beam.runners.common.DoFnInvoker.invoke_finish_bundle   File "apache_beam/runners/common.py", line 566, in apache_beam.runners.common.DoFnInvoker.invoke_finish_bundle   File "apache_beam/runners/common.py", line 1747, in apache_beam.runners.common._OutputHandler.finish_bundle_outputs   File "apache_beam/runners/worker/operations.py", line 237, in apache_beam.runners.worker.operations.SingletonElementConsumerSet.receive   File "apache_beam/runners/worker/operations.py", line 239, in apache_beam.runners.worker.operations.SingletonElementConsumerSet.receive   File "apache_beam/runners/worker/operations.py", line 198, in apache_beam.runners.worker.operations.ConsumerSet.update_counters_start   File "apache_beam/runners/worker/opcounters.py", line 215, in apache_beam.runners.worker.opcounters.OperationCounters.update_from   File "apache_beam/runners/worker/opcounters.py", line 267, in apache_beam.runners.worker.opcounters.OperationCounters.do_sample   File "apache_beam/coders/coder_impl.py", line 1472, in apache_beam.coders.coder_impl.WindowedValueCoderImpl.get_estimated_size_and_observables   File "apache_beam/coders/coder_impl.py", line 1490, in apache_beam.coders.coder_impl.WindowedValueCoderImpl.get_estimated_size_and_observables   File "apache_beam/coders/coder_impl.py", line 1222, in apache_beam.coders.coder_impl.SequenceCoderImpl.estimate_size   File "apache_beam/coders/coder_impl.py", line 1238, in apache_beam.coders.coder_impl.SequenceCoderImpl.get_estimated_size_and_observables   File "apache_beam/coders/coder_impl.py", line 208, in apache_beam.coders.coder_impl.CoderImpl.get_estimated_size_and_observables   File "apache_beam/coders/coder_impl.py", line 829, in apache_beam.coders.coder_impl.IntervalWindowCoderImpl.estimate_size TypeError: Cannot convert GlobalWindow to apache_beam.utils.windowed_value._IntervalWindowBase
Traceback (most recent call last):   File "/usr/local/lib/python3.7/site-packages/apache_beam/runners/worker/sdk_worker.py", line 287, in _execute     response = task()   File "/usr/local/lib/python3.7/site-packages/apache_beam/runners/worker/sdk_worker.py", line 360, in <lambda>     lambda: self.create_worker().do_instruction(request), request)   File "/usr/local/lib/python3.7/site-packages/apache_beam/runners/worker/sdk_worker.py", line 597, in do_instruction     getattr(request, request_type), request.instruction_id)   File "/usr/local/lib/python3.7/site-packages/apache_beam/runners/worker/sdk_worker.py", line 634, in process_bundle     bundle_processor.process_bundle(instruction_id))   File "/usr/local/lib/python3.7/site-packages/apache_beam/runners/worker/bundle_processor.py", line 1009, in process_bundle     op.finish()   File "apache_beam/runners/worker/operations.py", line 939, in apache_beam.runners.worker.operations.DoOperation.finish   File "apache_beam/runners/worker/operations.py", line 942, in apache_beam.runners.worker.operations.DoOperation.finish   File "apache_beam/runners/worker/operations.py", line 943, in apache_beam.runners.worker.operations.DoOperation.finish   File "apache_beam/runners/common.py", line 1479, in apache_beam.runners.common.DoFnRunner.finish   File "apache_beam/runners/common.py", line 1460, in apache_beam.runners.common.DoFnRunner._invoke_bundle_method   File "apache_beam/runners/common.py", line 1507, in apache_beam.runners.common.DoFnRunner._reraise_augmented   File "apache_beam/runners/common.py", line 1458, in apache_beam.runners.common.DoFnRunner._invoke_bundle_method   File "apache_beam/runners/common.py", line 561, in apache_beam.runners.common.DoFnInvoker.invoke_finish_bundle   File "apache_beam/runners/common.py", line 566, in apache_beam.runners.common.DoFnInvoker.invoke_finish_bundle   File "apache_beam/runners/common.py", line 1747, in apache_beam.runners.common._OutputHandler.finish_bundle_outputs   File "apache_beam/runners/worker/operations.py", line 237, in apache_beam.runners.worker.operations.SingletonElementConsumerSet.receive   File "apache_beam/runners/worker/operations.py", line 239, in apache_beam.runners.worker.operations.SingletonElementConsumerSet.receive   File "apache_beam/runners/worker/operations.py", line 198, in apache_beam.runners.worker.operations.ConsumerSet.update_counters_start   File "apache_beam/runners/worker/opcounters.py", line 215, in apache_beam.runners.worker.opcounters.OperationCounters.update_from   File "apache_beam/runners/worker/opcounters.py", line 267, in apache_beam.runners.worker.opcounters.OperationCounters.do_sample   File "apache_beam/coders/coder_impl.py", line 1472, in apache_beam.coders.coder_impl.WindowedValueCoderImpl.get_estimated_size_and_observables   File "apache_beam/coders/coder_impl.py", line 1490, in apache_beam.coders.coder_impl.WindowedValueCoderImpl.get_estimated_size_and_observables   File "apache_beam/coders/coder_impl.py", line 1222, in apache_beam.coders.coder_impl.SequenceCoderImpl.estimate_size   File "apache_beam/coders/coder_impl.py", line 1238, in apache_beam.coders.coder_impl.SequenceCoderImpl.get_estimated_size_and_observables   File "apache_beam/coders/coder_impl.py", line 208, in apache_beam.coders.coder_impl.CoderImpl.get_estimated_size_and_observables   File "apache_beam/coders/coder_impl.py", line 829, in apache_beam.coders.coder_impl.IntervalWindowCoderImpl.estimate_size TypeError: Cannot convert GlobalWindow to apache_beam.utils.windowed_value._IntervalWindowBase
our pipeline looks something like this:
         pipeline             | "Read PubSub Messages"             >> beam.io.ReadFromPubSub(                 subscription=options.input_subscription, with_attributes=False             )             | f"Group Messages into {options.window_size} seconds window"             >> beam.WindowInto(                 window.FixedWindows(options.window_size),                 allowed_lateness=Duration(seconds=1 * 60 * 60),             )  # 1 hour             | "Extract data from requests" >> beam.ParDo(ExtractDataFromRequest()
This pipeline has been running successfully for a couple months and these errors only shown up recently and it seems nowhere to start debugging with. Any ideas?

Could you please provide more details. which version of Beam are you running? Does the succeeded and failed job on same Beam version?

@Abacn Yes. Beam version: python sdk 2.43.0. Succeeded job and failed job both running on 2.43.0. After we restarted a new job with same code this error is not been seen yet.

thanks for reporting. Sounds like this is intermittent which makes it hard to investigate. Will try to investigate.


Can't use SAS tokens for Azure?

https://github.com/aloneguid/stowage/blob/92612a6d12c0f78c93d38b65f3bb280bc07f6f1a/src/Stowage/Impl/Microsoft/SasAuthHandler.cs#L8C11-L8C26
The implementation seems to exist but I can't find any place that actually uses that class, and since it is all internal I can't call it myself either?

Oh i see. The work has started but never finished a while ago (hence the class is internal).

@aloneguid I see, it doesn't really do anything 😄  you want me to make a PR for it?

Yes please, that would be awesome!


Prefer artifact over version in buildpack layers

Prefer using the full Artifact instead of just the Artifact#go_version, in buildpack layers. This changes the buildpack output to include more information about the Go artifact (i.e. architecture and os, and where the artifact is downloaded from) - and allow us to add more target architectures (e.g. https://github.com/heroku/buildpacks-go/pull/233) that factor in the target os/arch in addition to the version

@runesoerensen do you mind adding a test for the Go binary being restored on rebuild? I noticed there aren't any in the current integration test suite.

@colincasey for sure, I've added one here https://github.com/heroku/buildpacks-go/pull/237/commits/4ea5eab1e1025aa396ccae965542eeb8f04e717b


Add decoder context and argument type in getDefault method

BTW it might be a good idea to change the order of the parameters in createSpecific to have the same order as in deserialize: context and then the type, in the same way, serialize can have context, type, and then value.

makes sense, do you want to make that change?

I will


Showcase submission : RuBaRu dApp

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

[ ] You have updated the .github/CODEOWNERS file according to your changes.
[ ] You have registered new documents to /sidebars.js if any.

The CLA bot got stuck once again. @RuBaRuApp could you please also go through the steps over at https://github.com/dfinity/cla/issues/300? Then I'm able to merge

Thank you @sesi200. Sent the consent to bot again

Hello @sesi200 ,
Are there any further steps required from our side? How long does it takes to get changes reflected on portal?
Thank you in advance!


use using instead of typedef in C++ header

add clang-tidy check to the generated file in CI

@Changqing-JING
both fixed, close this ticket


Include Raul's contributions to the code

Codecov Report
Attention: 125 lines in your changes are missing coverage. Please review.

Comparison is base (60d4c59) 63.76% compared to head (f87efb8) 41.32%.

:exclamation: Current head f87efb8 differs from pull request most recent head 538452e. Consider uploading reports for the commit 538452e to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##              dev      #22       +/-   ##
===========================================
- Coverage   63.76%   41.32%   -22.44%
===========================================
  Files           1        1
  Lines         218      363      +145
===========================================
+ Hits          139      150       +11
- Misses         79      213      +134

Files
Coverage Δ

src/SSNVariability.jl
41.32% <3.84%> (-22.44%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[SDK] Feature: Adds SiteLink component

Completes CNCT-2259

PR-Codex overview
This PR introduces the SiteLink component to facilitate wallet-aware linking between thirdweb-enabled sites, enhancing user experience by sharing wallet state seamlessly. It also updates the SiteEmbed component documentation and includes tests for the new SiteLink.
Detailed summary

Updated comment for SiteEmbed to reflect wallet connection usage.
Added SiteLink component for creating links with wallet parameters.
Provided usage example for SiteLink in documentation.
Implemented tests for SiteLink to verify functionality and error handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Merge activity

Nov 6, 3:12 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


Add config file to provide notification URL

This PR adds an environment file that will help us configure notification URL.

Discussed with @zeusongit that we will use dotenv-webpack to introduce different endpoint for dev, staging. prod env so this repo is prod ready

@zeusongit Please address merge conflicts and update readme for this change. Once you have it tested, LGTM


bash completion

It would be nice to have bash completion for pyinfra command line.
Perhaps we can leverage this: https://click.palletsprojects.com/en/7.x/bashcomplete/

Apologies for resurrecting closed issue but wouldn't it make sense to install completions on pip install pyinfra?

@yermulnik no worries! I did some investigation into this but unfortunately it seems bash completion folders vary by OS, OS version and environment! As such I don't think there's really any clean way to do this. However, I am going to improve/highlight the documentation on this, as it should be accessible to all.

@Fizzadar Thank you for taking a look into it. I meant more of having an option to have a completion file installed along with the package itself + howto in README on how to have completion activated by e.g. sourcing the file from within .bashrc.


Duplicate key in Tabs list when label is a node instead of a string

In the Tabs component, the label can be a node instead of a simple string.
But the way the key is computed : https://github.com/codegouvfr/react-dsfr/blob/main/src/Tabs.tsx#L160
  <li key={label + (iconId ?? "")} role="presentation">

may give the <li> a non unique [object Object] key.
I encountered this when putting labels inside <span> .
Wouldn't it be a better option to choose the tabIndex as the key ?

in general, it is better to avoid using indexes as key in react https://react.dev/learn/rendering-lists#why-does-react-need-keys

You might be tempted to use an item’s index in the array as its key. In fact, that’s what React will use if you don’t specify  a key at all. But the order in which you render items will change over time if an item is inserted, deleted, or if the array gets reordered. Index as a key often leads to subtle and confusing bugs.

maybe give us the option to provide our own key ?

Hello @slafayIGN,
Thank you for bringing this to my attention. I can't believe I made such a basic error. It appears I changed the label type from `string` to `ReactNode` but failed to update the code to reflect that change.
@david-nathanael, although it's generally advisable to avoid using indexes as keys, it's not an absolute rule. The key attribute in React helps to prevent unnecessary rerendering of list items when their order changes. This is crucial for performance, especially when you have dynamic filtering like in a search input. However, in this case, the performance gain would be negligible.
Firstly, in 99.9% of scenarios, the tab order won't change dynamically. Even if it does, it would only trigger rerender of some native ``, which would have an insignificant impact on performance.
I've released a new version that includes this patch.


add ability to support arrays as input in query

Thanks for the contribution!  I hope you're finding this library useful.

In fact, I find this library very useful, are there any planned releases?(more features?)


There is a conflict with Angular Material v1.1.1

Hello,
I'm trying to install it via Bower and I have an issue
ECONFLICT Unable to find suitable version for angular-material

I'm using Angular Material v1.1.1.
Could you please provide instructions how to resolve it?
Thanks,
Alexander

This should be solved by https://github.com/logbon72/angular-material-datetimepicker/pull/79

Also solved by #34
But I prefer to use yarn than bower.


labwc: 0.7.2 -> 0.7.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/labwc/versions.
meta.description for labwc is: Wayland stacking compositor, inspired by Openbox
meta.homepage for labwc is: https://github.com/labwc/labwc
meta.changelog for labwc is: https://github.com/labwc/labwc/blob/0.7.3/NEWS.md
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.7.3 with grep in /nix/store/m3nb0vkmrbcb412pn2bpqi93dl55jpbw-labwc-0.7.3
found 0.7.3 in filename of file in /nix/store/m3nb0vkmrbcb412pn2bpqi93dl55jpbw-labwc-0.7.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

labwc

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/m3nb0vkmrbcb412pn2bpqi93dl55jpbw-labwc-0.7.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A labwc https://github.com/r-ryantm/nixpkgs/archive/8593642d3d11273863e41d5788d338e1a2b8baba.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8593642d3d11273863e41d5788d338e1a2b8baba#labwc

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/m3nb0vkmrbcb412pn2bpqi93dl55jpbw-labwc-0.7.3
ls -la /nix/store/m3nb0vkmrbcb412pn2bpqi93dl55jpbw-labwc-0.7.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

labwc
labwc.man

Maintainer pings
cc @AndersonTorres for testing.

@NixOS/nixpkgs-merge-bot merge


fix(module/asg): IAM Policy for Delicense Lambda

This fixes the wrong IAM policy

okay fair point :)
we just assumed that everyone stores it a hierarchy I guess :)
I adjusted it accordingly to append a slash if needed pls check

/idempotence paths="examples/combined_design_autoscale"

/sca

Please also fix Terraform documentation as after changing variables description, README needs to be updated too.

/sca

/idempotence paths="examples/combined_design_autoscale"

/idempotence paths="examples/combined_design_autoscale"

/sca

Thanks @sebastianczech


fix: doc only

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] I have updated changeset
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report
Base: 57.31% // Head: 57.31% // No change to project coverage :thumbsup:

Coverage data is based on head (fd46af7) compared to base (97ffdc1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   57.31%   57.31%
=======================================
  Files         622      622
  Lines       15995    15995
  Branches     3405     3405
=======================================
  Hits         9167     9167
  Misses       6303     6303
  Partials      525      525

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[ci skip] adding user @ZzEeKkAa

Hi! This is the friendly automated conda-forge-webservice.
I've added user @ZzEeKkAa as instructed in #32.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #32

I want to fix https://github.com/conda-forge/ittapi-feedstock/issues/1

@conda-forge/core the feedstock seems to be abandoned, please add me as a maintainer

you don't need to be a maintainer to fix 1. fix it, then ask to be a maintainer.

anybody can fork and make a PR.

@hmaarrfk I did it in #34

@ZzEeKkAa, I'm closing this PR since the required changes have been merged in #34 and there is no need to add new maintainers to this repo


Update default gazebo version on debian buster to 11

This would fix the inconsistency described in #27851

For the 2nd approval, I tried to follow the conversations but it looks complicated. Is it normal that gazebo11 isn't actually listed as an available package in Buster? https://packages.debian.org/search?keywords=gazebo

Thanks for the long hanging followup.

I guess there was some miscommunication. I thought you guys would consider it and change it if there isn't any reason not to.
I'm always hesitant to make single-line change PRs for systems I can't even test on.
However, I've made an exception since the build server kept emailing me to remind me.

For the 2nd approval, I tried to follow the conversations but it looks complicated. Is it normal that gazebo11 isn't actually listed as an available package in Buster? https://packages.debian.org/search?keywords=gazebo

I think it's available from the ros build farm / debian repo: http://packages.ros.org/ros/ubuntu/dists/buster/main/binary-amd64/Packages
but I'm not 100% sure and I don't have a debian system to confirm this.


[Bug] A quiet buzzing noise can be heard in the Song Select menu and Results menu

Might just be your computer, mine does this sometimes too. Here is a trouble shoot list from Quora
OBS says there are no sound output when in song select idle.
Evidence
Audio mixer showing no sounds when idle

Audio mixer showing sounds when on a song

I second Ashiro's point. Have you tried using different headphones? Or using it on a different PC?

Nothing by my side neither, closing the ticket for now as after additional checks the issue seems to simply not happen
Please reopen the ticket if you find more details or evidence about it


Is it possible to connect to multiple Artemis instances?

In Java you can set property e.g. spring.artemis.url=(tcp://host:61616,tcp://host2:61616), and your client manages connections itself. I need to rewrite some services from Java to Golang, but I can't find a library supports connection to multiple nodes.

Not with a single Conn instance, you'd have to create one instance per connection.

Closing. Please ping back if you have further questions.


Post request - array parameter not working properly

Here is the code;
var client = new RestClient ("http://localhost:3000");
var request = new RestRequest ("products", Method.POST);
request.AddParameter ("countryCode", "US", ParameterType.GetOrPost);
request.AddParameter ("storeId", "1001", ParameterType.GetOrPost);
request.AddParameter ("storeId", "1002", ParameterType.GetOrPost);
var response = client.Execute(request).Result;
At the server end, only one storeId (the last one, 1002) is coming.
The same request via curl works perfectly.
curl -X POST --header "Content-Type: application/x-www-form-urlencoded" --header "Accept: application/json" -d "countryCode=US&storeId=1001&storeId=1002" "http://localhost:3000/products"
What I am my doing wrong here?  Is this that the limitation?
Can some one pls advise.
Thanks

This is a limitation. You may want to try storeId[0]=1001&storeId[1]=1002 instead. This should work too.

I'll try to lift this limitation for 4.0, but it's not there yet.

You mean to say, If I pass like below the request should go through?
request.AddParameter ("storeId[0]", "1001", ParameterType.GetOrPost);
request.AddParameter ("storeId[1]", "1002", ParameterType.GetOrPost);

Yes, it might work (I've already seen this :wink:)

Sry, It didn't work out.  Any other ways you can suggest to achieve this.?

OK, I'll try to fix this and get a new pre-release out tomorrow

Thanks @fubar-coder. Please leave a message here once you publish the pre-release.

It's available as beta on the RestSharp.Portable MyGet Gallery. The NuGet v3 feed is: https://www.myget.org/F/restsharp-portable/api/v3/index.json
Be aware, that you have to use NuGet 3.5.0 beta to be able to consume this package. Please reopen this issue, when this issue is not resolved.

Getting error saying

'4.0.0-beta-01.10' is not a valid version string

I'll fix this ASAP.

What client do you use to install the NuGet packages? Where exactly does this happen? It works fine here when using Visual Studio 2015, both with .NET Core RC2 and .NET 4.5 console applications.

I pushed pakages with a new version number: 4.0.0-beta1-012. I hope that your client can now handle this version number... Maybe your dotnet tool is too old?

I was using nuget client to install nuget packages in xamarin studio 5.10.2.

Does it work now? Maybe you have to use nuget 3.5.0 beta?

@fubar-coder. I have tried now in NET 4.5 console applications. By using  nuget client 3.5.0 beta now to install packages. But still unable to add the nuget package. It says
"
Adding FubarCoder.RestSharp.Portable.Core...
Attempting to resolve dependency 'Newtonsoft.Json (≥ 8.0.4-beta1)'.
Downloading FubarCoder.RestSharp.Portable.Core 4.0.0-beta1-012...
'FubarCoder.RestSharp.Portable.Core' already has a dependency defined for 'NETStandard.Library'. "
But My target is to create a PCL lirbary using restsharp with targetFramework="portable-net45+win+wp80+MonoTouch10+MonoAndroid10+xamarinmac20+xamarinios10".
Any help is greatly appreciated.

That's it. Cameron Studio doesn't support the new nuget packages. I'll do some investigation, and answer you again about possible solutions.

I made a back-port of the 4.0 changes to 3.3.0 (on nuget.org). Please try this version. You should be able to install this in Xamarin.Studio. Sorry for the hassle and thank you for your patience.

Sorry for giving you trouble once again. May be it's some limitations in xamarin studio.
Still unable to add package. It's says
"Adding FubarCoder.RestSharp.Portable...
Attempting to resolve dependency 'FubarCoder.RestSharp.Portable.HttpClient (≥ 3.3.0)'.
'4.0.0-beta-01.10' is not a valid version string.
Parameter name: version"

The latest version is beta1-012. This should work

I changed the version number to avoid exactly this problem.

@fubar-coder Thanks for your patience. This also didn't work out.
Still getting error
"Adding FubarCoder.RestSharp.Portable.Core...
Attempting to resolve dependency 'Newtonsoft.Json (≥ 8.0.4-beta1)'.
Downloading FubarCoder.RestSharp.Portable.Core 4.0.0-beta1-012...
'FubarCoder.RestSharp.Portable.Core' already has a dependency defined for 'NETStandard.Library'."
If possible pls try to create a sample PCL library in xamarin studio and test adding this package to that
Thanks

Too long awake. Please use 3.3.0 from nuget.org. I made a backport.

Thank you very much. Finally issue resolved 👍 👍

Good :grinning:


fix: createResource null check failing on load

When createResource is trying to resolve, it checks with the condition (typeof p !== "object" || !("then" in p)) so that it knows if it should await for the value. However, typeof null is equal to "object" and so the condition fails for the promise check.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 88.997%

Totals

Change from base Build<PHONE_NUMBER>:
0.009%

Covered Lines:
1261

Relevant Lines:
1346

💛  - Coveralls

Thank you.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 88.997%

Totals

Change from base Build<PHONE_NUMBER>:
0.009%

Covered Lines:
1261

Relevant Lines:
1346

💛  - Coveralls


Allow more elements per line in SMILES file

Could you elaborate a bit more?

At the moment the SMILES importer is very restrictive and only allows 2 entries per line separated by a separator, i.e. if I have a file with an additional entry, it will not be read. This is not very practical for a "loose" format like a text file containing SMILES.

I think this was actually the point in #31


Update AZ400_M01_Agile_Planning_and_Portfolio_Management_with_Azure_B…

…oards.md
Replace issue name M00-LAB00:QUICK_DESCRIPTION, for example "M01-LAB01: My new issue" (or same name as linked Issue)
Related Issue
Link related Github Issue 🢂 Fixes # . (Include issue number after #)
Checklist
Mark completed with "x" between brackets, "[x]":

[ ] Has related GitHub Issue 💥 Create Issue 📝
[ ] Tested it
[ ] Read the PR collaboration guide 👓 Collaboration Guide 📝

Changes proposed in this pull request:

Submitted by garjen55 on behalf of MOC Labs Review

@MOC-Labs-Review Next time at least provide description and follow guidelines as mentioned in the PR template if possible Collaboration Guide thanks!

imported proposed changes myself (no reply) and merged PR


Added option for custom packager port

Issue: #1367
What I did
Added option for custom packager port (--packager-port=xxxx) .
How to test
Pass option --packager-port and see that new port is used.
Is this testable with jest or storyshots?
RN cli is not tested with jest yet.
Does this need a new example in the kitchen sink apps?
No.
Does this need an update to the documentation?
Not sure. We should document all the options available in cli.
If your answer is yes to any of these, please make sure to include it in your PR.

If you have tested this @Gongreg, go ahead and merge.


How can we Register interceptors globally ??

Did you go through the example use case?
You can set interceptors that way from any component or service you want.

Yes, did go through this example , but there you are adding/removing interceptors probably in a service level.
I think it would be better to configure the interceptors in the module level, while the HttpInterceptorService is being injected.  As you have stated in your concept or as here

The thing is services should always remain as singletons meaning they are only of one instance no matter where you are injecting it (any component or service).
That said all registered interceptors always global.

I understand the singleton concept.
In my project there a independent service to each resources, where HttpInterceptorService is being injected via constructor and most of the API calls need OAuth Token attached.
The problem is I can't be certain which service will always be firstly created, so that the interceptors can be configured in that service.
Else I have to configure in the base-service, which is inherited by all my resource-services.
But I am able to do this in the main app's module level. I will not have to be worried about these rite ?

I'm sure you can do that from main app.
However I'm not sure I can see the problem why you ever should be worried about services construction order?
Can you please provide some example use case?

I'm going to close this assuming your issue was resolved

Yeap. Thnx...


Entity names always start with capital letter. Intended?

Describe what is wrong
Since a while all entity-names always start with a capital letter. This is not at all critical and might only be seen in special cases. For example if you have an "iPhone" the entity name starts with "IPhone".
Was this change intended and is there a chance to leave the entity name like it is set up by the user?
Version
v3.1.3

You can disable this via BulkRename capitalize_first
https://github.com/maxwroc/battery-state-card?tab=readme-ov-file#bulk-rename
Example (just skip the rules)
https://github.com/maxwroc/battery-state-card?tab=readme-ov-file#entity-filtering-and-bulk-renaming

Thanks very much for the fast answer. It works.
Sorry that I oversaw that new config-setting, which has been introduced.

No worries, not your fault - it was kind of breaking change which shouldn't happen in the minor version update


Fix #762, scrub of all CFE UT stub functions

Describe the contribution
Scrubs all CFE unit test functions to ensure that:

All functions in the CFE public API have a stub function implemented
All parameters to the stub function are registered in the context object,
so the values will be available to hook functions.
The names of all parameters match the prototype/documentation, so hook
functions that use name-based argument value retrieval will work.

Fix #762
Testing performed
Build and run all CFE unit tests
Sanity check on CFE execution (but this doesn't change any FSW code).
Expected behavior changes
No impact to current behavior - except it does change the internal names of some stub arguments to match prototype.
Note this only changes UT stubs.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

CCB 2020-07-01: APPROVED


Running analysis from GVCF level with bcbio to get updated results for expanding population of samples

Hi @chapmanb .
In the past we typically ran analysis with bcbio from the input level of FASTQ or BAM files. We are happy with the results how scalable and reliable bcbio is.
To get a population level analysis result it's now with the availability of GATK4 much more efficient to reprocess from GVCF level for all existing (historical + new) samples than from BAM level.
Starting an analysis from GATK4 GVCF level is current not possible in bcbio as far as I know.
Also it is not obvious how the BAM level QC files in this case would be aggregated to also be included in the multiqc report.
Is reprocessing from GVCF level for expanding populations of samples functionality that you think fits with bcbio and would like to cover with bcbio?
Otherwise I'll have to (re)create this functionality myself outside of bcbio (which I rather not do), so that we get the same results for our expanding population as for our new batches:

Re-calculation of callable regions from GVCF or BAM for parallelization
The actual GVCF square off via GenomicsDBImport and GenotypeGVCFs
Soft filter status for SNPs and INDELs
Aggregated MultiQC

Most of this looks straight forward enough to me, if I would need to do this.
I was just wondering if any values are extracted from the squared of VCF to fill in variables in the soft filter function for SNPs and INDELs. This does not look to be the case but I remember that in the past the full squared of VCF was scanned for depth values to fill in some variables in the soft filter functions.
https://github.com/bcbio/bcbio-nextgen/blob/584bdbb8809faedf134ed2f97d66a1208559ad32/bcbio/variation/vfilter.py#L215
Please let me know your thoughts on this.
Thank you.

Maybe it's still possible to have the functionality in bcbio to still start from BAM level but have the functionality to detect if GVCF files are already in place in some directory, so to then skip the computation needed to create the GVCF files?

Thanks much for the suggestion and starting this discussion. We've gotten feedback that this would be useful (#1513 #2068) but haven't yet gotten it implemented, so definitely know it would be great to have. Our target would be a little less aggressive than what you suggest and would take in a set of gVCFs and joint call them with the new samples calculated as inputs. We wouldn't plan to target recalculating callable regions.
If you had ability and time to tackle this, the starting point would be to supply the gVCFs as individual samples with a vrn_file specification instead of files (https://github.com/bcbio/bcbio-nextgen/blob/master/tests/data/automated/run_info-bam.yaml#L7). Then by batching these with the samples of interest to joint call, we'd need the joint calling machinery to pick these up and include during the GenomicsDBImport and GenotypeGVCFs stages.
I'm happy to provide more specific pointers and help to drive this along if it sounds worthwhile. Thanks again.

Hi @chapmanb, Thank you very much for your answer.  Specifying the existing GVCF files using the  vrn_file field works.  The only thing missing is that soft filtering  is not run on the squared off multi-sample VCF file.
This makes the genotype concordance look low compared to the same samples variant called from FASTQ level or from BAM level.  Could soft filtering also be run by default (or optionally) for variant calling analysis that start exclusively from GVCF files ?
I did start the analysis also with the existing BAM files to get the mapping and variant calling MultiQC report in the end.  And to get the regions to parallelize the GVCF merge on.
I did not try to run a mixed analysis with some samples starting from FASTQ and some from GVCF.
We like to keep that separated, i.e. a batch analysis from FASTQ for new incoming samples, and then subsequently a distinct new analysis from GVCF for the new total set of samples in the  expanded population.
Below is what I exactly did.
Sample CSV table
samplename,description,batch,phenotype,sex,variant_regions,lane,coverage_interval,quality_format
DA_1052_01,VSDA_1052_01,DA_1052,,,,DA_1052_01,genome,
DA_1052_02,VSDA_1052_02,DA_1052,,,,DA_1052_02,genome,
DA_1052_03,VSDA_1052_03,DA_1052,,,,DA_1052_03,genome,

Template YAML file, not that I set aligner: false  and variantcaller: false and jointcaller: gatk-haplotype-joint
# Template for whole genome Illumina variant calling with FreeBayes
# This is a GATK-free pipeline without post-alignment BAM pre-processing
# (recalibration and realignment)
---
details:
  - analysis: variant2
    genome_build: my_reference
    description:
    # to do multi-sample variant calling, assign samples the same metadata / batch
    metadata:
      batch: DA-1052
    algorithm:
      aligner: false
      mark_duplicates: false
      recalibrate: false
      realign: false
      variantcaller: false
      jointcaller: gatk-haplotype-joint
      ploidy:
          default: 2
      nomap_split_targets: 1000
      effects: false
      tools_off:
      - gemini
      # for targetted projects, set the region
      # variant_regions: /path/to/your.bed

I manually added vrn_file field  with the path to the existing GVCF files for every sample. I did not yet try to put a  vrn_file  column with the GVCF paths in the sample CSV table.
I hope that also works so I can generate the full YAML below from the combination of the sample CSV file and the template YAML.
details:
- algorithm:
    aligner: false
    coverage_interval: genome
    effects: false
    jointcaller: gatk-haplotype-joint
    mark_duplicates: false
    nomap_split_targets: 1000
    ploidy:
      default: 2
    realign: false
    recalibrate: false
    tools_off:
    - gemini
    variantcaller: false
  analysis: variant2
  description: DA_1052_01
  files:
  - input_bam/DA_1052_01-ready.bam
  genome_build: my_reference
  lane: DA_1052_01
  vrn_file: input_gvcf/DA_1052_01.vcf.gz
  metadata:
    batch: DA_1052
- algorithm:
    aligner: false
    coverage_interval: genome
    effects: false
    jointcaller: gatk-haplotype-joint
    mark_duplicates: false
    nomap_split_targets: 1000
    ploidy:
      default: 2
    realign: false
    recalibrate: false
    tools_off:
    - gemini
    variantcaller: false
  analysis: variant2
  description: DA_1052_02
  files:
  - input_bam/DA_1052_02-ready.bam
  genome_build: my_reference
  lane: DA_1052_02
  vrn_file: input_gvcf/DA_1052_02.vcf.gz
  metadata:
    batch: DA_1052
- algorithm:
    aligner: false
    coverage_interval: genome
    effects: false
    jointcaller: gatk-haplotype-joint
    mark_duplicates: false
    nomap_split_targets: 1000
    ploidy:
      default: 2
    realign: false
    recalibrate: false
    tools_off:
    - gemini
    variantcaller: false
  analysis: variant2
  description: DA_1052_03
  files:
  - input_bam/DA_1052_03-ready.bam
  genome_build: my_reference
  lane: DA_1052_03
  vrn_file: input_gvcf/DA_1052_03.vcf.gz
  metadata:
    batch: DA_1052
fc_name: DA_1052_bam_table
upload:
  dir: ../final

This analysis indeed skipped the variant calling step and just squared of the existing GVCF files with the callable regions recalculated from the existing BAM files. Also I got the mapping and variant calling (BAM and VCF based) MultiQC report. This is what I wanted to have.
So the only thing missing is that soft filtering did not run. This is noticed from the genotype concordance results created with Picard. I compared against the same samples run from FASTQ level with BCBio.
As you can see the sensitivity of the samples processed from GVCF is 1, but the PPV only 0.92. This is because the soft filtering did no run.
VARIANT_TYPE	TRUTH_SAMPLE	CALL_SAMPLE	HET_SENSITIVITY	HET_PPV	HET_SPECIFICITY	HOMVAR_SENSITIVITY	HOMVAR_PPV	HOMVAR_SPECIFICITY	VAR_SENSITIVITY	VAR_PPV	VAR_SPECIFICITY	GENOTYPE_CONCORDANCE	NON_REF_GENOTYPE_CONCORDANCE
SNP	DA_1052_01	DA_1052_01	1.00	0.92	?	1.00	0.99	?	1.00	0.97	0.91	0.81	0.81
SNP	DA_1052_02	DA_1052_02	1.00	0.92	?	1.00	0.99	?	1.00	0.96	0.92	0.75	0.75
SNP	DA_1052_03	DA_1052_03	1.00	0.90	?	1.00	0.99	?	1.00	0.97	0.89	0.87	0.87

See also the detailed genotype concordance stats for the first sample. This shows that there are a lot of VC_FILTERED	HET_REF_VAR1 and MISSING	HET_REF_VAR1 discordand genotypes.
VARIANT_TYPE	TRUTH_SAMPLE	CALL_SAMPLE	TRUTH_STATE	CALL_STATE	COUNT	CONTINGENCY_VALUES
SNP	DA_1052_01	DA_1052_01	HOM_VAR1	HOM_VAR1	2076047	TP
SNP	DA_1052_01	DA_1052_01	HET_REF_VAR1	HET_REF_VAR1	846153	TP,TN
SNP	DA_1052_01	DA_1052_01	VC_FILTERED	HET_REF_VAR1	664864	EMPTY
SNP	DA_1052_01	DA_1052_01	MISSING	HET_REF_VAR1	66254	FP,TN
SNP	DA_1052_01	DA_1052_01	VC_FILTERED	HOM_VAR1	37459	EMPTY
SNP	DA_1052_01	DA_1052_01	MISSING	HOM_VAR1	17872	FP

Thank you.

@chapmanb  It would be ideal if I could run the following command to get the full yaml with both the path input_bam/DA_1052_03-ready.bam and  vrn_file: input_gvcf/DA_1052_03.vcf.gz fields.
bcbio_nextgen.py -w template VSDA-783.yaml  VSDA_783_bam_table.csv input_bam/*.bam input_gvcf/*vcf.gz
Thank you.

Thanks much for testing this out and for the feedback. This made better progress than I'd expected and happy that it's almost doing what you need. I'll put adding in soft filtering and improving template support for these (with less urgency) on the to do list. I appreciate the feedback and suggestions and will update when we have a chance to work on these.

Hi Brad, Thank you for putting enabling soft filtering for analysis starting from GVCF on the to do list. I look forward to that functionality being in bcbio.
I am already very happy with that analysis from GVCF already mostly works via bcbio. :)
I can wait for the soft filtering, or if needed just run it as an extra manual step after bcbio for now.
Thank you again also for the bcbio software in general.


[AutoPR search/resource-manager/search/data-plane/Microsoft.Azure.Search.Data/search/data-plane/Microsoft.Azure.Search.Service] chore: jsonfmt search

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6240

(message created by the CI based on PR content)


Rebased CpGGpC train branch with master

Hi, i'm tring to repeat the result of nanoNOMe published in the nature method and i'm very new to calling methylation from nanopore. It would be very kind of you to answer the following questions:

does the nanopolish call-methylation in cpggpc_new_branch use the model made in the paper automatically? or should i use the nanopolish methyltrain first?
if i split the total fastq in multiple small fastqs, align and call methylation from them seperately, can we just merge the result of  the meth.freq.txt.gz?
Waiting for replying~

Hi, i'm tring to repeat the result of nanoNOMe published in the nature method and i'm very new to calling methylation from nanopore. It would be very kind of you to answer the following questions:

does the nanopolish call-methylation in cpggpc_new_branch use the model made in the paper automatically? or should i use the nanopolish methyltrain first?
if i split the total fastq in multiple small fastqs, align and call methylation from them seperately, can we just merge the result of  the meth.freq.txt.gz?
Waiting for replying~


Support to declare GObject proeprties

This is meant to be a discussion about the implementation of user declared GObject properties.
IMO it must be as transparent as possible, i.e. a property/setter/getter macro on GObject, overwriting the original Crystal Object macros.
class Foo < GObject::Object
  # Creates a read/write GObject property
  property foo : Int32
  # Creates a read only GObject property
  getter bar : Int32
  # Creates a write only GObject property
  setter moo : Int32
  # Prop with blurb
  property hey : String, blurb: "I'm the property blurb"
  # Prop with cusom nick
  property nicked : String, nick: "Nickey"
end

The nick can be the name.titleize, or custom. Blurb could be default to name.titleize too
These macros would create the variables on Crystal world, so people could use @foo to read foo property without overhead.
A possible implementation for this would be the macro generate something like
@[GObject::Property(blurb: "Prop blurb"]
@foo : String

So a finalize macro would catch all instance variables with this annotation and generate the set_property/get_property methods plus the class_init that register the properties.
I didn't test this yet, but if it works we could use the same schema to vfuncs, to avoid the bug that forbid a method starting with do_ to be declared if no vfuncs with that name exists, so instead vfuncs can just be:
@[GObject::VFunc]
def do_whatever

# or

@[GObject::VFunc(name: :whatever)]
def whatever_name

But this is another subject :grin:
Back to properties... other options for properties can also be added as extra parameters in the macro, e.g.:
property foo : Int32, min: 0, max: 32

Not all crystal properties can be mapped to GObject properties, therefore I would suggest using an annotation, raising an error if there is no equivalent gtype.
Also, there are modules using the getter, setter, property macros so I think we should put blurb, nick and additional arguments into the annotation.
Example:
@[GObject::Property(min: 10, max: 20)]
@some_int : Int32

@[GObject::Property(default: -1)]
property something : UInt64

We still have to override the setter/getter/property macros to emit a notify signal on property change.
I'm already working on an implementation, there I just looped over the instance vars using {% for Ivar in @type.instance_vars %} and only generated a GObject property where the annotation is set.

Not all crystal properties can be mapped to GObject properties, therefore I would suggest using an annotation, raising an error if there is no equivalent gtype.

It's true, better just use the annotation so, and if the annotation is going to be explicit used, better put the property options there.
And I think we don't need to care about constructor-only properties.

Implemented on 6383125b77e59d8aea45ff1da254410354c07cee


make CLI tool actually usable

The main function should call the appropriate functions to generate functions

Resolved in #15


Add VPR echo targets and VPR_EXTRA_ARGS cache variables.

As long as VPR_EXTRA_ARGS doesn't apply to the rr_graph.xml generation vpr runs, then LGTM!


WEBSOCKET_HOST decode error on Python 3

On Python 3 (3.4.3) a simple stream client like this:
from __future__ import print_function
from datasift import Client

ds = Client("Username", "API Key")

@ds.on_delete
def on_delete(interaction):
    print( 'Deleted interaction %s ' % interaction)

@ds.on_open
def on_open():
    print( 'Streaming ready, can start subscribing')
    csdl = 'interaction.content contains "music"'
    stream = ds.compile(csdl)['hash']

    @ds.subscribe(stream)
    def subscribe_to_hash(msg):
        print(msg)

@ds.on_closed
def on_close(wasClean, code, reason):
    print( 'Streaming connection closed')

@ds.on_ds_message
def on_ds_message(msg):
    print( 'DS Message %s' % msg)

ds.start_stream_subscriber()

throws the following error:
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/multiprocessing/process.py", line 254, in _bootstrap
    self.run()
  File "/usr/local/lib/python3.4/multiprocessing/process.py", line 93, in run
    self._target(*self._args, **self._kwargs)
  File "/datasift-python/datasift/client.py", line 237, in _stream
    options = ssl.optionsForClientTLS(hostname=WEBSOCKET_HOST.decode("utf-8"))
AttributeError: 'str' object has no attribute 'decode'

This looks like a duplicate of issue #49.

Closing as a duplicate of #49


croppie.destroy() causes errors

Error 1
// This error happens because `opts.update()` is called after `destroy()`

Uncaught (in promise) TypeError: Cannot read property 'preview' of undefined
    at Croppie._get (webpack-internal:///223:1318:37)
    at Croppie._result (webpack-internal:///223:1353:25)
    at Croppie.result (webpack-internal:///223:1569:28)

Error 2
// This error happens because `_updateOverlay()` is triggered by `_debouncedOverlay()`
// after a `destroy()`, and `self.elements` is null

Uncaught TypeError: Cannot read property 'boundary' of undefined
    at Croppie._updateOverlay (croppie.js?f101:939)
    at later (croppie.js?f101:102)

function _updateOverlay() {
        var self = this,
            boundRect = self.elements.boundary.getBoundingClientRect(),
            imgData = self.elements.preview.getBoundingClientRect();
...
}

Good catch.  I guess the simplest fix would be adding a
if (!self.elements) return;

at the top of the _updateOverlay.

Yes, shall I do that and submit a PR?

Will that fix the first error though?

I'm not seeing the first error you mentioned.  Where is opts.update called after destroy?

Hmm I can't replicate this atm, but possibly if the croppie was destroyed while waiting for loadImage() in _bind()?

Then _triggerUpdate() is called after croppie has been destroyed, which calls self.options.update()

Despite using this
if (!self.elements) return;
at the top of _updateOverlay(), I am getting the error
"Cannot read property 'preview' of undefined" at Croppie_get().
and in Croppie_destroy(), I am getting this error when I am trying to destroy an existing instance post uploading an image.

Please guyz, Can you help me out asap. I am using it in my company project and deadline is this Sunday.
Please have a look and comment to help.

Hey guyz, i was getting the error because _croppie_instance.destroy() was not working. Set it to null and then initiated Croppie instance and it started working.

I was encountering this because I had moved one of the Croppie components (the zoom slider) from the Croppie container into our container.
Calling destroy() with some Croppie elements intentionally placed elsewhere in the DOM threw an error. It looked like Croppie was trying to search for known children and couldn't find them in the original parent container.
When I put the slider back into the original Croppie container, then proceed to can call destroy(), the instance is destroyed without error.

Any fix on that?

Anybody fix on this problem?


⚠ Bofrost.be has degraded performance

In a2c8205, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1609 ms

Resolved: Bofrost.be performance has improved in 499e639.


Problem with mode

Hi,
I am using this beautiful editor but having a problem with mode. I have Vue 2.6.14.
Here is my usage:
<json-editor-vue
          v-model="json"
          :readOnly="true"
          :navigationBar="false"
          :mainMenuBar="false"
          :mode.sync="data.mode"
></json-editor-vue>

In data I also have:  mode: 'text',
I also tried :mode.sync="mode"
But editor is not showing up in text mode.
Thanks

Could you provide a minimal reproducible codesandbox link? I can not reproduce this.

I tried this Vue 2.6.14 CDN example and the mode is doing just fine:
<!DOCTYPE html>
<html lang="en">

<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=no">
  <meta http-equiv="X-UA-Compatiple" content="IE=Edge,chrome=1">
  <meta name="renderer" content="webkit">
</head>

<body>
  <div id="app">
    <json-editor-vue :mode.sync="mode"></json-editor-vue>
  </div>

  <script>
    window.process = { env: { NODE_ENV: 'production' } }
  </script>
  <script type="importmap">
    {
      "imports": {
        "vue"<EMAIL_ADDRESS>        "@vue/composition-api": <EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>        "vue-demi": "https://unpkg.com/vue-demi/lib/v2/index.mjs",
        "vanilla-jsoneditor": "https://unpkg.com/vanilla-jsoneditor",
        "json-editor-vue"<EMAIL_ADDRESS>      }
    }
  </script>
  <script type="module">
    import { createApp, ref } from '@vue/composition-api'
    import JsonEditorVue from 'json-editor-vue'

    const app = createApp({
      setup: () => ({
        mode: ref('text'),
      }),
    })
    app.use(JsonEditorVue)
    app.mount('#app')
  </script>
</body>

TS is not required.
You can have a try with the Vue 2.6.14 CDN example I provided previously, it's unlikely related to json-editor-vue.
Temporarily close this due to the lack of enough information.
Please provide a minimal reproduction to reopen the issue.
Thanks.

Why reproduction is required

Type of value must be string under text mode, JSON.stringify it. This should be the same cause of https://github.com/cloydlau/json-editor-vue/issues/16.
Again proving that a reproduction is highly necessary, I have no way to investigate this without knowing how your value looked like.

Document updated, differentiating type of binding value under different modes.

After a discussion with the original author, it's not correct in the document saying text mode only take strings. Now you can directly pass JSON value to<EMAIL_ADDRESS>

I could not understand, can I assign "text" to mode after 0.7.2? Anyway, I have found another way, thanks for the effort.

It means you can pass anything in any mode now.


[vcpkg_configure_make] Add mingw support

Is your feature request related to a problem? Please describe.
Currently, vcpkg_configure_make assumes that MSVC is the compiler used. This is however not true anymore since we now have community support for mingw. I tried modifying it but soon gave up due to the complexity. If someone can steps up or at least guides me through the process, I'd appreciate it.

the trick is probably to replace all if(VCPKG_TARGET_IS_WINDOWS) with if(VCPKG_TARGET_IS_WINDOWS AND NOT VCPKG_TARGET_IS_MINGW) since in mingw vcpkg_configure_make can probably just take the linux path.

Alright I'll take a look

the trick is probably to replace all if(VCPKG_TARGET_IS_WINDOWS) with if(VCPKG_TARGET_IS_WINDOWS AND NOT VCPKG_TARGET_IS_MINGW) since in mingw vcpkg_configure_make can probably just take the linux path.

No, It can't currently. vcpkg_configure_make hardcodes Visual Studio compiler into CXX env at Windows system.

I just noticed @Neumann-A's excellent PR #12936 which removed the hardcoded cl.exe and now x264 builds with x64-mingw-dynamic with some fixes. Thank you for the help, I'll make a PR for the fixes later.

Closing this since vcpkg_configure_make now works like intended.

Closing this since vcpkg_configure_make now works like intended.


⚠ Bofrost.be has degraded performance

In e7a5b7d, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1359 ms

Resolved: Bofrost.be performance has improved in f1cb61d.


Accented characters are replaced by spaces

Hello,
I just have an encoding issue with the folder creation.
Accented characters are replaced by spaces.
picture
Thank you for your work, great tool !

Hey @joachimBrindeau,
Thanks so much for raising the issue. Please update to the latest version of the extension (v.1.5.0) and it should be working. I'll close the issue but if there's anything that isn't working as expected, feel free to raise another one.
Stay safe and don't forget to wash hands! :D
Regards,
H


Page translateContent does not work for form fields

What were you trying to do?
I'm trying to scale a page which contains a form with different fields, text/checkbox etc
How did you attempt to do it?
page.scale(scale, scale);
page.translateContent(translateX, translateY);
What actually happened?
The form fields are not translated as the rest of the page content.
What did you expect to happen?
The form fields should have been translated as well (X/Y)
How can we reproduce the issue?
page.scale(0.8, 0.8);
page.translateContent(translateX, translateY);
OoPdfFormExample.pdf
Version
1.17.1
What environment are you running pdf-lib in?
Node
Checklist

[X] My report includes a Short, Self Contained, Correct (Compilable) Example.
[X] I have attached all PDFs, images, and other files needed to run my SSCCE.

Additional Notes
No response

I have implemented a workaround solution
pdfDoc.getForm().getFields().forEach((field) => {                 page.node.Annots()?.asArray().forEach((annot) => {                     if ((annot as PDFRef).objectNumber === field.acroField.ref.objectNumber) {                         const widgets = field.acroField.getWidgets();                         widgets.forEach((widget) => {                             const rect = widget.getRectangle();                             rect.x += translateX;                             rect.y += translateY;                             widget.setRectangle(rect);                         });                     }                 });             });


[Typed throws] Workaround for LLVM miscompile of unused swifterror, add executable test

While experimenting with typed throws, I discovered that on x86_64 and -Onone only, the IR that typed throws generates (which is identical to IR on arm64!) ends up getting lowered in a wrong way and the execution of the program ends up taking the wrong branch, this is demonstrated by the testcase added in this PR -- the "this cannot happen" call actually happens. I don't have the ability to diagnose the LLVM problem further, and so instead this PR adds a workaround to enable executable testing of typed throws. This PR also adds a simple executable test.

The following IR demonstrates the problem. When the following is built for x86_64 under -O0…
target triple = "x86_64-apple-macosx14.0.0"
declare swiftcc i64 @throwing(ptr swiftself %0, ptr noalias nocapture swifterror dereferenceable(8) %1)
define swiftcc void @catching() {
entry:
  %swifterror = alloca swifterror ptr, align 8
  store ptr null, ptr %swifterror, align 8
  %0 = call swiftcc i64 @throwing(ptr swiftself undef, ptr noalias nocapture swifterror dereferenceable(8) %swifterror)
  %1 = load ptr, ptr %swifterror, align 8
  %2 = icmp ne ptr %1, null
  br i1 %2, label %catch, label %continue
catch:
  ; %dummy_use = ptrtoint ptr %1 to i64    ; UNCOMMENT THIS TO GET CORRECT OUTPUT
  br label %ret
continue:
  br label %ret
ret:
  ret void
}

…it produces this machine code:
] ../llvm-macosx-arm64/bin/llc -O0 x86.ll -o -
_catching:                              ## @catching
	pushq	%r13
	pushq	%r12
	pushq	%rax
	xorl	%eax, %eax
	movl	%eax, %r12d
	callq	_throwing
	cmpq	$0, (%rsp)
	je	LBB0_2

Notice that the cmp is comparing (%rsp), which is a miscompile -- swifterror is expected to be in r12. Interestingly, this only happens if there is no use of %1 in the catch block in the IR, and even a dummy unused instruction that just ends up using %1 suddenly makes the output correct.

@swift-ci please test

@swift-ci please test Windows platform


NameError: name 'time' is not defined

getting error while running the script
┌──(kali㉿kali)-[~/tools/s1c0n]
└─$ python3 sicon.py -u hackerone.com
       [!] Error on import No module named 'nmap'

[*] nmap exist
Traceback (most recent call last):
File "/home/kali/tools/s1c0n/sicon.py", line 51, in
check(tool)
File "/home/kali/tools/s1c0n/sicon.py", line 29, in check
time.sleep(0.2)
NameError: name 'time' is not defined

sudo apt install nmap
Or
pip3 install namp
to fixe the problem

Add in the top
import time

the problem is in the nmap module which is not installed, you can install it using pip3 install nmap or pip3 install python-nmap


memory usage for ensemble too big

Hello,
I'm trying to do the example plot_steps_nowcast.py from pySTEPS using OPERA.
The memory usage is big, more than 20 Gb.
Is is normal?
Thank you
Juan

Considering the large size of the OPERA mosaics, this sounds normal if you are using 20 ensemble members. To reduce the memory usage, you can try passing domain="spectral" to steps.forecast.

Thank you, that helps.

Thank you, that helps.

Good to hear! Do not hesitate to share your findings with us, does using the spectral domain reduce considerably the memory footprint of steps.forecast? By how much?
I just wanted to add that typically steps is run on relatively limited domains (order of 500 x 500 km). This has to do with the computational cost, but also because STEPS assumes stationarity of the rainfall statistics (mean, variance, and correlation structure) over the domain.
I'm closing this issue, but do not hesitate to reopen it if you need more support.


Rancher does not remove nodes deleted via ec2/DO console despite k8s knowing node is gone

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Create IaaS cluster  with a cloud provider (ec2 preferred)
Create node templates with IAM roles usable for cloud provider
Provision a cluster.
Delete a node from the cluster via ec2 console
Run kubectl get nodes
Node is no longer present
But node is still visible in rancher UI with  kubelet stopped posting node status

Result:
Other details that may be helpful:
Rancher should know if the node is gone if kubernetes knows

I believe this is a dupe of https://github.com/rancher/rancher/issues/14184
if you verify it is a dupe, can you close this one and just add your repro steps to that issue?

Verified as duplicate, closing in favor of https://github.com/rancher/rancher/issues/14184


[Java][recognizer-text-number] Apply linting format

*Apply linting format to several .java files
*linting-rules.xml:
+Change property 'allowedAbbreviationLength' from 1 to 4
+Set property 'VariableDeclarationUsageDistance' to 5
+Delete deprecated value from linting-rules.xml (LeftCurlyBraces->'maxLineLength' property)

Already applied in upstream


AudioBus oddities; saving problem? loading problem?

Godot version:
Godot v3.1.beta10.official
OS/device including version:
Intel Core i7 920 (Nehalem) @ 2.67GHz (4 core/8 thread)
12GB DDR3 @ 1066MHz (CPU limited)
Issue description:
I created a new AudioBusLayout using the Create button. I then modified this file, and it worked perfectly in editor. When I ran the scene however, it would revert, and audio would not come through the bus it was routed to and was just working in editor. I eventually did get it working, however since I could not locate a place to set the current AudioBusLayout, I have reverted to naming it default_bus_layout.tres as it expects so it actually works, but I'm not really sure what the heck happened during this weird issue as I just tried everything to get it working until it did.
Steps to reproduce:
I wish I knew precisely what the problem is, but likely, it didn't save the named AudioBusLayout I was working with, or it didn't select that as the current AudioBusLayout automatically at scene run, but did fine in the editor, or something along these lines.

Provide an example project and/or video demonstration is also welcome if you want to someone to start working on this issue.

No answer to the above comment, so closing.


how to use startTick option of NoteEvent?

please example code :D

Hi @drumtj,
You can see an example of how to use the startTick option here: https://github.com/grimmdude/MidiWriterJS/blob/1.7.0/examples/notes-by-start-tick.js
-Garrett

thank you :)


stray additionalProperties line in 5.0.1

https://github.com/CVEProject/cve-schema/blob/521696b8ee6be21a86e8cac712b888bc0deb5e1f/schema/v5.0/CVE_JSON_5.0_schema.json#L808-L816
The "additionalProperties": false line shouldn't occur here. It causes error messages from ajv and possibly other validators, e.g.,
strict mode: missing type "object" for keyword "additionalProperties" at "https://cveproject.github.io/cve-schema/schema/v5.0/docs/CVE_JSON_5.0_bundled.json#" (strictTypes)

This was fixed in PR #250. Closing


Make referral code & URL text boxes fill width

Make referral code & URL text boxes wide enough to show you the entire value

Coverage increased (+0.004%) to 26.317% when pulling c6dcef9fadf0ae7587e43b09f1cede7c0826f5b6 on alioso:M3-980 into 97f4417804f74c92f0a3b0712e75e41348c7a7f5 on linode:develop.


issues_report: Adding more guidelines.

https://github.com/zulip/zulip/issues/7388
Testing Plan:
Tested in local environment successfully
GIFs or Screenshots:

@rishig
Added suitable points regarding bug reports.
It would be great if you please check and mention the scope for improvement.

@dipu989 this issue really requires clear English writing and context on what sorts of bad issue reports we get in Zulip, and as a result I don't think your changes improve that document.
I'd encourage you to work on a project that better matches your skills and experience.


How to change Node Version in Lambda Function that hosts Nextjs SSR

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting questions.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
d3vc58cpnaxzh9
AWS Region
us-east-2
Amplify Hosting feature
Deployments
Question
Hi, Thanks for the support and sorry if this is a duplicate, but I've researched a lot and couldn't find any docs or issues related.
I have a nextjs app that needs to run on node18, you can see the issue below.

I've already tried the following:

set engines to 18.x in package.json
update environment variable of NODE_VERSION to 18.x
update the build settings to use a custom docker image: node:18.2.0
created a lambda function with node18.x in the backend, but i failed to use that function as a runtimer

Update Runtime in amplify/backend/function/YOURLAMBDA/yourlambda-cloudformation-template.json

Set node version in .nvmrc file in the project root

Here is the repo example: https://github.com/Sirge-io/test-amplify
PS: Just to be clear, i'm not talking about the functions that we can add into amplify/function but the lambda that hosts the frontend
Any Help is much appreciated. Thanks.

Hi @saulonunesdev, thanks for raising this question. Updating the runtime for Lambda functions hosting SSR apps is not supported at this time. We will keep this open as a feature request instead. We apologize for this inconvenience.

Thanks @hloriana ^^

Up to this, we need this.

We definitively need to run our public faced application on maintained environment and lot of lib are dropping node 16 so basically with amplify we are stuck to not update our application


unciv: 4.6.4-patch2 -> 4.6.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yairm210/Unciv/releases.
meta.description for unciv is: An open-source Android/Desktop remake of Civ V
meta.homepage for unciv is: https://github.com/yairm210/Unciv
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.6.5 in filename of file in /nix/store/89yxxqrp54r69pw6ais7bqj95aka0acq-unciv-4.6.5

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
unciv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/89yxxqrp54r69pw6ais7bqj95aka0acq-unciv-4.6.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unciv https://github.com/r-ryantm/nixpkgs/archive/89c1ba29baa41ec6bc96982eef0b34231256b35d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/89yxxqrp54r69pw6ais7bqj95aka0acq-unciv-4.6.5
ls -la /nix/store/89yxxqrp54r69pw6ais7bqj95aka0acq-unciv-4.6.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

unciv

Maintainer pings
cc @tex for testing.

Result of nixpkgs-review pr 228221 run on aarch64-darwin 1

1 package built:

unciv


While loop replaced by for loop

https://github.com/ARM-software/CMSIS_5/pull/779
CMSIS-DSP is using while loop with decrementing counter.
For compiler point of view, it may be easier to use for loop and array indexing.
This is also related to this other github issue about pointer indexing : https://github.com/ARM-software/CMSIS-DSP/issues/20
Unfortunately, those changes are highly compiler dependent and not always giving more performant code.

It will require too much revalidation work without a gain which is always clear and highly compiler dependent.


Support for intersection types (& operator)

The ability to do @type table<string, string> & number[] to say that it is both a string->string table and an array of numbers

You've got union and intersection types around the wrong way; currently only union types are supported. There are no intersection types.
That said, with the specific example you've given, an equivalent type can be defined as:
---@shape NumberArrayStringMap
---@field [number] number
---@field [string] string

---@type NumberArrayStringMap
local numberArrayStringMap1 = {}

---@type { [number]: number, [string]: string }
local numberArrayStringMap2 = {}

Would like intersection support, however honestly it's probably a way off. Currently it's not yet possible to extend multiple shapes, that'd need to come first.

currently only union types are supported. There are no intersection types.

Union types support all operations of all types, intersection types only support operations that both types support. Is that backwards?

 Or you can think about it this way: The properties of a type (e.g. what fields you can access) are a function what values are not part of the type (the type's complement, it's all just set theory btw.). The more values you can rule out, the more properties you know are guaranteed. If you look at the complement of types, the intersection of two types become their union and vice-versa.
So if you take the union of what you can rule out in two types, you get the union of the types' properties…

I have another example I've run into where I wanted to use an intersection type. I'm writing type stubs for a library that provides functions inside of tables in global variables. Some of these functions are overloaded, so I can write (without any require):
foo.bar()
foo.bar(42)

To type this, I wanted to write the following declaration (pseudo-syntax) in a stub file (a Lua file that I'm never importing):
---@shape Foo
---@field bar fun() & fun(a: number)

foo = --[[---@type  Foo]] {}

Instead, I managed to get the result I wanted with this:
---@shape Bar
---@overload fun()
---@overload fun(a: number)

---@shape Foo
---@field bar Bar

foo = --[[---@type  Foo]] {}