Error con update.

Hola luego de actualizar me tira esto cuando uso el nuevo nodo de recepcion de mensajes.
Error: Cannot find module 'mqtt'
Require stack:
- /home/pi/.node-red/node_modules/node-red-contrib-whin/whin.js
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /usr/lib/node_modules/node-red/lib/red.js
- /usr/lib/node_modules/node-red/red.js

Hi @Askeshine,
I will answer in english so that the rest of the whin community can take advantage of the comments.
This update is adding two new nodes, as described on the read.me
It has no breaking changes, but we rebuilt the project so that all the nodes fit into one single package. Depending on which is the version you were using before the upgrade, you might find a problem we did not catch on our tests.
My suggestion is:
1.- remove whin completely from the node-red (do not forget to remove also the whin-config node).
2.- make a clean install from the palette.
3.- complete the config filling in the fields on the config node. You don't need to copy your token, just click here: https://wa.me/34613164997?text=signup and you will get it again.
I hope it helps; if you still have problems, just let us know.

Ok,
i do all things and keep showing that error. only with this

iYou have to uninstall whin first, then follow the process explained above.
Probably, you still have some nodes in the existing flows, or configuration nodes. Check in the menu Configuration Nodes for any unused nodes and delete them, then deploy changes.
When you're sure there's no remaining whin nodes on the flows, AND there's no config node remaining:
1.- Log-in to the nodered terminal.
2.- cd to .node-red folder (usually mapped to /data if you're using docker).
3.- Using package manager from the command line, from within your .node-red folder -this is important-, run
npm uninstall node-red-contrib-whin
4.- If this doesn't remove whin, then post the full output from the command here.

You have to uninstall whin first, then follow the process explained above.
Probably, you still have some nodes in the existing flows, or configuration nodes. Check in the menu Configuration Nodes for any unused nodes and delete them, then deploy changes.
When you're sure there's no remaining whin nodes on the flows, AND there's no config node remaining:
1.- Log-in to the nodered terminal. 2.- cd to .node-red folder (usually mapped to /data if you're using docker). 3.- Using package manager from the command line, from within your .node-red folder -this is important-, run npm uninstall node-red-contrib-whin 4.- If this doesn't remove whin, then post the full output from the command here.

Same error.
Error: Cannot find module 'mqtt'
Require stack:
- /home/pi/.node-red/node_modules/node-red-contrib-whin/whin.js
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /usr/lib/node_modules/node-red/lib/red.js
- /usr/lib/node_modules/node-red/red.js

okay, so it looks like you've updated to the latest version of whin (0.1.4) correctly.
Now it seems like you're missing a node-red core node, in particular: mqtt - which is declared as dependency.
Can you please check if you find a folder called mqtt at /usr/lib/node-modules/node-red/node_modules ?
This path has nothing to do with contrib-whin, but the core node-red modules. If you cannot find mqtt there, then you must install it before enabling whin.

I use mqtt in my node red, I have 8 esp8266 connected all sends updates with mqtt
Sent with a Spark
El 11 de enero de 2022 12:41 -0300, lu4t @.***>, escribió:

okay, so it looks like you've updated to the latest version of whin (0.1.4) correctly.
Now it seems like you're missing a node-red core node, in particular: mqtt - which is declared as dependency.
Can you please check if you find a folder called mqtt at /usr/lib/node-modules/node-red/node_modules ?
This path has nothing to do with contrib-whin, but the core node-red modules. If you cannot find mqtt there, then you must install it before enabling whin.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: @.***>

lo siento @Askeshine, me temo que me he quedado sin ideas de qué puede estar pasando... veo que has acutalizado a la última versión del nodo whin, entiendo que debe ser algo local a tu RPi porque vemos que el resto de usuarios están funcionando con normalidad.

I am having the same issue. getting error
Error: Cannot find module 'mqtt'
Require stack:
- /home/pi/.node-red/node_modules/node-red-contrib-whin/whin.js
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /usr/local/lib/node_modules/node-red/lib/red.js
- /usr/local/lib/node_modules/node-red/red.js

I have done the steps mentioned here https://github.com/inUtil-info/node-red-contrib-whin/issues/3#issuecomment-1008718917 and checked the path mentioned here https://github.com/inUtil-info/node-red-contrib-whin/issues/3#issuecomment-1010085900 and I do not have MQTT folder there but I do have it in /usr/local/lib/node_modules/node-red/node_modules/mqtt

looks like the RPi installer maps the node_modules folder outside the Dockerfile PATH

I am having the same issue. getting error
Error: Cannot find module 'mqtt'
Require stack:
- /home/pi/.node-red/node_modules/node-red-contrib-whin/whin.js
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /usr/local/lib/node_modules/node-red/lib/red.js
- /usr/local/lib/node_modules/node-red/red.js

I have done the steps mentioned here #3 (comment) and checked the path mentioned here #3 (comment) and I do not have MQTT folder there but I do have it in /usr/local/lib/node_modules/node-red/node_modules/mqtt

Are you running nodered on RPi raspbian? or is it running as a docker container on the RPi?
the PATHs you get on the logs attached are weird.

yes that is exactly correct I am running node-red on a pi4 with raspbian

Hi @moshed, I am afraid that the problem has to do with the way nodered is installed on the RPi. We are not running whin on a RPi and cannot troubleshoot the install process.
I had a look at this: http://stevesnoderedguide.com/installing-node-red and I guess you probably need to adjust the settings.js to your needs.
BR

ok thanks! I will take a look at that and see if I can manage it.


Predictability improvements

@miv-ableton @toh-ableton

@jbo-ableton looks good! I left one minor comment. And it would be nice if the build was green. Not sure what Travis' problem is.


Drag&Drop Support

@Akascape
First, many thanks for this handy tool! I did a brief testing, Textemage worked fine and I liked it. Excellent work, thank you.
Have you considered adding support for drag&drop? I mean dragging & dropping an image file into Textemage window in stead of using Open dialog? For me it would be faster and handier to use drag&drop in stead of Open. What do you think?
Off-topic question- it seems that Textemage is portable and that it does not save any settings, is that right? It seems that on exit Textemage clears its Temp directory and I also could not find any traces in AppData and in Windows registry. So- no settings are saved and no data is left behind? If this is true this is great!
Regards

@smaragdus Thanks for using my tool.
I just created it as a small project for my practice.
But I will surely continue it's development. I will check what I can do to add the drag & drop feature and implement it when I get it.
Secondly, it doesn't need any settings which needs to be save. The temp dir is just a folder where it extracts some packages for running the program. It will clean that automatically when the user exit the program.
Beside this it doesn't do anything in the OS folders/registry.

@Akascape

I just created it as a small project for my practice.

Thank you for sharing it. This is the first OCR tool I have used that I really like- easy, simple, efficient.

But I will surely continue it's development. I will check what I can do to add the drag & drop feature and implement it when I get it.

Even without drag&drop Textemage is easy to use. I just suggested a possible enhancement which is not of great importance.

Secondly, it doesn't need any settings which needs to be save. The temp dir is just a folder where it extracts some packages for running the program. It will clean that automatically when the user exit the program.
Beside this it doesn't do anything in the OS folders/registry.

I supposed that Textemage is fully and truly portable but I wanted a confirmation from the developer. Being portable one can have Textemage on a f;ash drive or on an external hard drive and use it on other machines without leaving any traces behind. Excellent. I added Textemage to my collection of portable programs.
I came upon Textemage on Softpedia and gave it a five-star rating which it deserves.
Keep the great work

@smaragdus Yes, its totally portable. You just need the Textemage.exe program.
All of my other python based application like these are portable because they are created with Pyinstaller only.

@smaragdus Finally added the drag and drop file support feature. Please upgrade to version 1.3.


OCM-13047 | fix: create/oproles manual- use path from user roles

/cherry-pick release_1.2.49

/lgtm


Cannot remove API token

Describe the bug

I created an API token with a scope of my whole account, just to test and play with GitHub Actions. After that I want to remove it, and instead use a new API token with project scope. But I cannot remove it. Each time I try, it prompts for my account password, after entering the correct password, it says "Invalid credentials. Try again". See the screenshots:

Expected behavior

After entering my account password for confirmation, the corresponding API token should be removed from my account.
To Reproduce

Create an API token;
Go back to "Account" page, from the API token list, use the "Option" button > "Remove" to try to remove this API token;

My Platform
I don't think client platform matters in this case. But I'm using Edge 79.0.309.56 on macOS 10.15.2.
Additional context

I have 2FA enabled (TOTP).

thank you for reporting. this is a duplicate of #7143. I'm looking into this now but have been unable to reproduce.


[Feature][Cherry-Pick][Branch-3.1] Support int32 to datetime in parquet reader (backport #39808)

cp from https://github.com/StarRocks/starrocks/pull/39808
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[x] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

https://github.com/Mergifyio backport branch-3.1-cs


feat: Track current version

I think this won't be very useful. We should directly track whether the client is running on an old version. E.g., you can put a 15sec timeout on mount (in a useEffect() in https://github.com/excalidraw/excalidraw/blob/master/src/excalidraw-app/index.tsx) which will then make the request to /version.json to figure that out and track only if the client is behind.

I think this won't be very useful. We should directly track whether the client is running on an old version. E.g., you can put a 15sec timeout on mount (in a useEffect() in https://github.com/excalidraw/excalidraw/blob/master/src/excalidraw-app/index.tsx) which will then make the request to /version.json to figure that out and track only if the client is behind.

Which version exactly are you trying to track?

Which version exactly are you trying to track?

On load the number of the current version.. if connected to BigQuery we can make charts like this one:

Checking how fast the latest version is getting used and how some clients are still loading an outdated/cached version..

On load the number of the current version.. if connected to BigQuery we can make charts like this one:

Checking how fast the latest version is getting used and how some clients are still loading an outdated/cached version..

Which version exactly are you trying to track?

Which version exactly are you trying to track?

 I guess depends what you wanna do with it.

 I guess depends what you wanna do with it.

Timestamp is nice because you can visually distinguish which version is higher than the using the hashes.. and it's not hard to find the hash knowing the date if needed.

Timestamp is nice because you can visually distinguish which version is higher than the using the hashes.. and it's not hard to find the hash knowing the date if needed.

I checked what the version date is, and it's custom date at time of build. IOW, it'd pretty hard to map it a given commit.
If we don't want to use commit hash, let's at least use the time of the commit we're building from.
Best if we could log both in a JSON object. Can BigQuery drill down to an object?

I checked what the version date is, and it's custom date at time of build. IOW, it'd pretty hard to map it a given commit.
If we don't want to use commit hash, let's at least use the time of the commit we're building from.
Best if we could log both in a JSON object. Can BigQuery drill down to an object?

I still think hashes are more useful. The temporal dimension (which release comes before which) should be obvious from the graph itself. What remains is the use case where we want to know how much a given commit is still used in production.

I still think hashes are more useful. The temporal dimension (which release comes before which) should be obvious from the graph itself. What remains is the use case where we want to know how much a given commit is still used in production.

Version numbers are incrementals and the deployed version timetstamp (at the time of the build) is very close to reality by checking the commit log.
Maybe even tracking both?
${version}-${hash}

Version numbers are incrementals and the deployed version timetstamp (at the time of the build) is very close to reality by checking the commit log.
Maybe even tracking both?
${version}-${hash}

And sorting by version will always show the correct order of deployments...

And sorting by version will always show the correct order of deployments...

Version numbers are incrementals and the deployed version timetstamp (at the time of the build) is very close to reality by checking the commit log.

Yea, but let's not make it "close to reality" if we can make it "identical to reality". It'll be trivial:
TZ=UTC git log -1 HEAD --pretty=format:'%h %ad' --date=iso-local

(or pull the date from git and convert it via JS' Date)

Maybe even tracking both?
${version}-${hash}
2020-01-10-12-33-43-38857b9e

Yea, let's do that :+1:

Version numbers are incrementals and the deployed version timetstamp (at the time of the build) is very close to reality by checking the commit log.

Yea, but let's not make it "close to reality" if we can make it "identical to reality". It'll be trivial:
TZ=UTC git log -1 HEAD --pretty=format:'%h %ad' --date=iso-local

(or pull the date from git and convert it via JS' Date)

Maybe even tracking both?
${version}-${hash}
2020-01-10-12-33-43-38857b9e

Yea, let's do that :+1:

With a fallback to now if git doesn't exist during build...

With a fallback to now if git doesn't exist during build...

With a fallback to now if git doesn't exist during build...

Good point. No idea if we have access to git in vercel build environment. If not, we need to use a combination of current time as we're doing now + VERCEL_GIT_COMMIT_SHA for the commit hash.

With a fallback to now if git doesn't exist during build...

Good point. No idea if we have access to git in vercel build environment. If not, we need to use a combination of current time as we're doing now + VERCEL_GIT_COMMIT_SHA for the commit hash.

Good. How about we also replace:
https://github.com/excalidraw/excalidraw/blob/4b48d77433d14fe5ada26b7e24c33d049026e37d/scripts/build-version.js#L10-L18
with:
const versionDate = (date) => date.toISOString()

so that we get the date in ISO format.
Currently the YYYY-MM-DD-HH-MI-SS doesn't tell you what time zone it is in, plus it's fairly nonstandard format.

Good. How about we also replace:
https://github.com/excalidraw/excalidraw/blob/4b48d77433d14fe5ada26b7e24c33d049026e37d/scripts/build-version.js#L10-L18
with:
const versionDate = (date) => date.toISOString()

so that we get the date in ISO format.
Currently the YYYY-MM-DD-HH-MI-SS doesn't tell you what time zone it is in, plus it's fairly nonstandard format.


Add coverage reports for rust

https://doc.rust-lang.org/nightly/rustc/instrument-coverage.html

https://marco-c.github.io/2020/11/24/rust-source-based-code-coverage.html


confrimable registration token expire

When I click confirmation token from email it always login me into app . Even if token is expired. Action responsible for confirmation looks:
   def show

     @resource = resource_class.confirm_by_token(params[:confirmation_token])

      if @resource and @resource.id
              ....

Above condition which trigger success confirmation logic,  is always true, even @resource.confirmed? = false .

I also have that problem

Hi there @piotr-galas @bslipek   ,
In an effort to cleanup this project and prioritize a bit, we're marking issues that haven't had any activity in a while with a "close-in-7-days" label. If we don't hear from you in about a week, we'll be closing this issue. Obviously feel free to re-open it at any time if it's the right time or this was done in error!
If you are still having the issue (especially if it's a bug report) please refer to our new Issue Template to provide some more details to help us solve it.
Hope all is well.


Group capstone: set up your Kanban board

Group capstone: set up your Kanban board
The Kanban board project has been set up and it can be found here:

https://github.com/didierganthier/javascript-group-capstone/projects/1

This project was created by @hopeforkoami and @didierganthier

Hi @didierganthier & @hopeforkoami,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻

[ ] Please cards should be assigned to team members, and also decide who is Student A, and Student B. So each card with Student A in its title should always be assigned to the same student (and analogical for other students) 🙃 😉.
[ ] And all cards with group task in the title should be assigned to someone (it does not matter to whom as students had freedom with that) 😁 😁.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

**STATUS: APPROVED  🟢 **

Hi team,
Great work on making the changes requested by a previous reviewer 👏🏻
Highlights:
✔ kanban board is setup correctly
Your project is complete! . There is nothing else to say other than... it's time to merge it 🍾🚢 :shipit: . Congratulations!  🎉💯🌟

Cheers and Happy coding! :clap: :clap: :clap:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me [@shoirata] in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have  limited number of  reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.


Values of zero are being omitted

(Semi) BUG REPORT
Noticed this when the value field wasn't being written out onto a kafka topic.
This may be more of an issue with what protoc generates but I believe Mainflux should account for this. So I wanted to just make sure you all were aware it.

What were you trying to achieve?
Sending a message where the value is zero.

What are the expected results?
That the value field does not get omitted and contains a value of zero when the message that is sent contains 0.

What are the received results?
The value field gets omitted and is non-existent rather than zero

What are the steps to reproduce the issue?
The way I found easiest to visualize this, was through subscribing to the NATS channel where the normalized messages are written to (out.senml for example) and then decoding the messages.

Sub to out.senml and capture the output.
Send a message containing a zero for the value for example:

[
   {
      "bn":"MVP-mikes-fridge-sensor:",
      "bt":1537822790,
      "bu":"degC",
      "bver":5,
      "n":"Temperature",
      "u":"degC",
      "v":0
   }
]

Decode that output using protoc and although a value was sent, it does not appear

What I am seeing when I do this:

In what environment did you encounter the issue?
Kubernetes

Additional information you deem important:
I believe that a Zero value should be valid and not get omitted anywhere in Mainflux.  Since things like refrigerators/freezers can send temperatures that are 0.

The issue probably truly lies in protoc/go since protoc generates message.pg.go:
type Message struct {
        ...
	Value                float64  `protobuf:"fixed64,6,opt,name=Value,proto3" json:"Value,omitempty"`
        ...
}

Due to a combination of omitempty getting added and zero being considered empty in go, the Value field does not get populated.
Let me know thoughts about this!

Judging from this issue I would say that for message serialization and deserialization we should use http://github.com/golang/protobuf/jsonpb instead of standard encoding/json lib.


Device type getlist endpoint

Closes #179
FT is marked explicit until I can implement the delete endpoint.

verified it will pull the type list via Postman, approved pending anyone seeing a problem with the test portion


Paths and Tag Groups don't match the expected styles

Please make the Path and Tag Group components styles configurable using CSS variables.
Current result

Expected result

created PR: https://github.com/pk-hotovo/swagger-ui-kong-theme/pull/17


Update for Xcode 11.3

Send subscription synchronously in ReceiveOn and Delay operators
Some locks made recursive, as they should be
ObservableObjectPublisher doesn't use PassthroughSubject under the hood anymore

Let's wait until CircleCI supports Xcode 11.3.

LGTM

  Generated by :no_entry_sign: Danger Swift against d24e20cd79fe7906ed19b3112deca543701cc27c


WMI persistance event

Which provider should I use to get WMI persistence creation event logs.

That is something you would have to explore personally. I recommend that you have a look at EtwExplorer:
https://github.com/zodiacon/EtwExplorer


fullscreen prevents address bar from collapsing in ios safari

Bug, feature request, or proposal:
Bug
What is the expected behavior?
The address bar in the mobile safari browser should collapse while scrolling down.
Tapping at the top of the address bar should browse to the top.
What is the current behavior?
Using fullscreen in md-sidenav-layout prevents the address bar from collapsing while scrolling.
Tapping at the top of the address bar has no effects.
What are the steps to reproduce?
Scrolling the site down. Tapping at the address bar.
What is the use-case or motivation for changing an existing behavior?
The motivation is to not corrupt the native experience of iOS.
Which versions of Angular, Material, OS, browsers are affected?
Angular2 RC4
Angular2 Material alpha 6
iOS 9.3
Mobile safari
Thanks.

I created a screen recording to show what is described. I hope that helps
https://media.giphy.com/media/3ohzdCMs2cudR4hHVK/giphy.gif
Generally, having an absolute positioned element being the scrolling container causes these problems. The body needs to be part of the scrolling flow, for iOS to 'get it'

Believe this is obsolete as we've eliminated this API.

I'm not sure if I should open a new issue for this because this is exactly the behaviour I am experiencing as well. Following the Material Guide here I created my sidenav as described, only with a router outlet in the main content div, but this should not matter
<app>
  <md-sidenav-container>
    <md-sidenav mode="side" opened="true">Drawer content</md-sidenav>

Main content

  </md-sidenav-container>
</app>

html, body, material-app, md-sidenav-container, .my-content {
  margin: 0;
  width: 100%;
  height: 100%;
}

The issue I'm having is that this fix for a fullscreen sidenav (since we should not use the fullscreen attribute! https://github.com/angular/material2/issues/759) is indeed working but on mobile browsers the css prevents the address bar from shrinking - as shown in the .gif.
Can you provide a solution for this problem?
Thanks

@simerlec Yeah this is still an issue with the recommended approach. It's high on my list of things to work on.

angular.io uses the sidenav component, but still hides the address bar. Scrolling is not done within the sidenav-content-div but with the whole document. It is probably related to setting height: auto !important;, but I wasn't able to fully reproduce it.
https://github.com/angular/angular/blob/7caa0a8aa46aae05102e82ba68b268c2c392f856/aio/src/app/app.component.html

Is there any updates on this issue?

I think this likely has something to do with .mat-drawer-content having overflow:auto, so the scrolling is happening within the div instead of the page as a whole.  This also leads to some awkward scrolling behavior when we try to add a scrollable div within the drawer-content.


Footer into menu

Merge #1920 first plz
Closes #1912
of course that damn sentry button was still covering the menu, and the new footer in the menu.
but i finally figured out how to make the menu render on top of it.
so now, both the toasts and the side nav menu will render on top of the sentry button.

@xraystyle1980 I fixed it, please re-test 🙏


Update lollipop

Purpose/implementation Section
Update 09-lollipop analysis module so that OncoKB access token is provided in command line when running analysis module.
What scientific question is your analysis addressing?
NA
What was your approach?

Divided the analysis module into three scripts:

01-create-maf-subset.Rmd subsets MAF for oncokb annotation2.
02-run-oncokb-annotation.sh runs MafAnnotator.py from oncokb_annotator GitHub repo3.
03-create-lollipop.Rmd generates lollipop plots 4.

Set variable ONCOKB to be defined with Oncokb access token when running run_lollipop.sh shell script.
Created README file with instructions on defining access token variable when running module.

What GitHub issue does your pull request address?
Ticket #59
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?

confirm that module runs with personal Oncokb access token
confirm changes in plots are as expected

Is there anything that you want to discuss further?
No
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Results
What types of results are included (e.g., table, figure)?
MAF subset tables:
hgat-goi.maf.tsv
snv-dgd-goi.maf.tsv
OncoKB annotation results:
dgd_maf-goi-oncokb.tsv
snv-consensus-plus-hotspots-hgat-oncokb.maf.tsv
Lollipop plots:
atrx-lollipop-all.pdf
atrx-lollipop-alt-neg.tiff
atrx-lollipop-alt-pos.tiff
atrx-lollipop-comp.tiff
atrx-lollipop-oncogenic.pdf
atrx-lollipop-vus.pdf
What is your summary of the results?
There are minor changes in some of the figures and tables due to a change in sample number.
Documentation Checklist

[X] This analysis module has a README and it is up to date.
[X] The analytical code is documented and contains comments.

closing this and submitting new PR


fix vectordb score bug

There was a crucial error at the vectordb.
When we use chromadb, the calculation method looks like this.

In this way, the lower score is better (more related to each other)
So, I resolve this with 1 - chroma_score, getting original cosine similarity value.
I don't know why the score computation looks like this, but this is how it works.
Effected modules

Ranking aware metrics (NDCG, mRR, mAP)
passage filters using scores

We have to measure again whole embedding benchmark

@bwook00 Needs to be release to newer version. Since it is critical HotFix for the bug.


Checkbox spec: clarifying conversion table & adding work items to track conversion.

We arrived at the final props list in this conversion table by comparing the props lists of the current Fabric and Stardust Checkboxes and the conversion was meant to track the progress of the conversion from the Fabric Checkbox, not the current Stardust/Fluent Checkbox in this repo. So added some clarification of that and added a list of work items to track the conversion of the current Stardust/Fluent Checkbox to the new Fluent Checkbox we're trying to build with this spec.

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Perf comparison

Status
Scenario
Fluent TPI
Fabric TPI
Ratio
Iterations
Ticks

🔧
Avatar.Fluent
0.58
0.39
1.49:1
2000
1157

🔧
Button.Fluent
1.27
0.17
7.47:1
1000
1269

🔧
Checkbox.Fluent
1.41
0.28
5.04:1
1000
1406

🔧
Dialog.Fluent
0.36
0.16
2.25:1
5000
1780

🔧
Dropdown.Fluent
3.48
0.36
9.67:1
1000
3484

🔧
Icon.Fluent
0.25
0.03
8.33:1
5000
1253

🔧
Image.Fluent
0.11
0.07
1.57:1
5000
547

🔧
Slider.Fluent
1.94
0.3
6.47:1
1000
1944

🦄
Text.Fluent
0.06
0.21
0.29:1
5000
292

🦄
Tooltip.Fluent
0.37
17.67
0.02:1
5000
1871

🔧 Needs work     🎯 On target     🦄 Amazing

  Generated by :no_entry_sign: dangerJS


How can I change line length settings for the black formatter?

Thank you for the awesome package. This is the only formatted that doesn't open all my folded code when I run it in the buffer.
I like to use blackwith the traditional line length. With blacken, I do this: (setq blacken-line-length 79). I tried editing apheleia-formatters, but after many attempts I wasn't able to get the syntax right.

(setf (alist-get 'black apheleia-formatters) '("black" "-l" "79" "-"))

(untested)?

That worked fine thank you very much. A note in the README on how to add those options might save trouble in the future. Cheers!

Done.


aiken docs: Module prefix when there's only 1 module

When there's only 1 module in the project (eg: https://github.com/ariady-putra/tx_util), aiken docs lists / as the module name instead of using the full module name. So I added a match-arm during pattern matching to handle 1 module.

Before
After

Run #[test] in docs module: OK, tested with cargo run docs -o ~/docs ~/aiken/tx_util from the crates/aiken (where ~/aiken/tx_util contains 1 module; result is After column above)
Retested with normal project containing multiple modules cargo run docs -o ~/docs ~/aiken/morbid:

Hey @rvcas , on second thought it's probably better to return immediatly when there's only 1 module instead of going through the fold
fn do_find_modules_prefix(current_prefix: &str, modules: &[DocLink]) -> String {
    if modules.len() == 1 {
        return current_prefix.to_string();
    }
    ...
}

I'll re-push. Sorry about that

:octocat:
Workflow run

:heavy_check_mark:
Tests / build (push)
https://github.com/ariady-putra/aiken/actions/runs/5571881093/jobs/10177347992

:heavy_check_mark:
Nix Build / nix-build (push)
https://github.com/ariady-putra/aiken/actions/runs/5571881087/jobs/10177348001

@ariady-putra why close?

@ariady-putra why close?

Hey @rvcas , previous commits was messy. This is my first time contributing to an open source project. I was planning to re-push with just 1 commit and having all :heavy_check_mark: workflow runs.
But currently I'm facing Clippy reject at crates/aiken/src/lib.rs:26:64. It was an easy fix but I'm reluctant to tamper with that module. I'm waiting for someone else to make the changes there :grinning:
The commit that I'm trying to suggest is a minor visual on aiken docs. It would be rare for people to have only 1 module in their project anyway. So there is no rush.

Retested with normal project containing multiple modules cargo run docs -o ~/docs ~/aiken/morbid:

Note that the attached screenshot here seems to be showing a regression from the original behavior. See for example on the stdlib:

The goal is to factor out the module prefix when there's one.

Retested with normal project containing multiple modules cargo run docs -o ~/docs ~/aiken/morbid:

Note that the attached screenshot here seems to be showing a regression from the original behavior. See for example on the stdlib:

The goal is to factor out the module prefix when there's one.

Hey @KtorZ , I ran cargo run docs -o ~/docs ~/aiken/stdlib/ with https://github.com/ariady-putra/aiken/commit/5118ab106e6421d79199c6e88ad346570a8c453b and it still gives the same result as your screenshot. Is there something I missunderstood? :thinking:


mgmt, local generation and verification for managedapplications

Description
Draft for verification for namespace change of Microsoft.Solutions.
https://github.com/Azure/sdk-release-request/issues/4489
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-resourcemanager-managedapplications


How to integrate blade_formatter?

Hi all,
I'm starting to work with Laravel and Blade template engine. I installed via Mason Blade-formatter, but I don't understand how to configure it. I added the following line in lvim/lua/user/null-ls/init.lua:
nls.builtins.formatting.blade_formatter.with{filetypes={"php", "blade", "blade.php"}},
When I try to format with lf it says null-ls timeout (and it create a file near the one I'm formatting, deleted an instant later).
If I use :lua vim.lsp.buf.format() It formats my file, but without Blade rules.
Thanks for all help

to integrate blade_formatter add the following:
    nls.builtins.formatting.blade_formatter {
      filetypes = { "php", "blade", "blade.php" },
    },

in here:
https://github.com/abzcoding/lvim/blob/7c14d2d0a1a8be9574ab6c90a6df2102014a2b39/lua/user/null_ls/init.lua#L53-L54

It seems to work, not always, with timeout at 50000. Is it a possibility that blade formatter is so slow? I'm on a i7 of 11th with 16 GB RAM and I'm working on a file of only 241 rows

Sadly I'm not familiar with blade formatter or PHP, so I'm not sure about the performance, but maybe there is some tuning that can be done in its settings

I tried also to increment lsp timeout using in my config.lua vim.lsp.buf.format({ timeout_ms = 10000 }) but it seems to override it in some way, the timeout occurs after a few seconds, maybe 1-2 seconds

hmm, maybe null-ls overrides that


WireMock evaluation of all criteria generates unnecessary warnings

[Description]
Short version: Non-json requests are evaluated against json mappings with body patterns and fill the log with failed json validation warnings.
Longer version: Because WireMock does an aggregation of the results for all evaluation rules (RequestPattern.match(Request request)) instead of hierarchically allowing a subsequent criterion to be evaluated against only after the higher one was matched, mappings that would immediately be excluded based on things like URL are still evaluated for body pattern matches. This is an issue when json body pattern matching mappings exists because it tries to evaluate ALL requests [that did not previously match] against the json body pattern matching mappings, which fills the log with all kind of json validation warnings.
[Repro]

Start WireMock.
Train WireMock [use something like Postman and POST to WireMockServer:WireMockPort/__admin/mappings/] with RAW body:

        {             "id": "fab6d56b-d66e-4a5a-810a-ab323e485103",             "request": {                 "urlPath": "/unavailablepath",                 "method": "POST",                 "headers": {                     "X-SessionId": {                         "equalTo": "90930D577144AB198B2082CA56E6A0F5",                         "caseInsensitive": true                     }                 },                 "bodyPatterns": [                     {                         "matchesJsonPath"<EMAIL_ADDRESS>== 'something')]"                     }                 ]             },             "response": {                 "status": 200,                 "bodyFileName": "a.json",                 "headers": {                     "Content-Type": "application/json"                 }             },             "uuid": "fab6d56b-d66e-4a5a-810a-ab323e485103"         }

Make sure the a.json file exists. I do not believe its content is relevant, but when I was creating the repro for this bug this is what I put in mine:

{   "jsonrpc": "2.0",   "id": "-1412417872994864924",   "result": {     "payload": {       "timeStamp": "2017-02-17T16:26:28.588"     }   } }

Send a non-admin request to WireMock. I used an empty GET to WireMockServer:WireMockPort/services/none
Observe the WireMock console. Result contains something like (actual error differs based on body patterns in mappings and on the requests):

20:41:12 INFO  WireMock - Warning: JSON path expression<EMAIL_ADDRESS>== 'something')]' failed to match document '' because of error 'json string can not be null or empty'
20:41:12 INFO  WireMock - Warning: JSON path expression<EMAIL_ADDRESS>== 'something')]' failed to match document '' because of error 'json string can not be null or empty'

The number of such entries considerably increases when the mappings are more complex and the requests are quite large. I think it is a one to one matching for each line of the request to each body pattern and each will generate at least a warning.
This makes our logs (which are already quite large) extremely large and it is very hard to follow what is wrong when you need to navigate through hundreds of pages of such warnings.
We also do not want to downgrade the logging level since we would like to be able to observe the [other] information provided.
[Environment]
We are using WireMock 2.5.1, but we tested (before actually debugging the code and finding the root cause) and the issue is still present in WireMock 2.8.0.

related (no search on the root cause):
https://groups.google.com/forum/#!topic/wiremock-user/DOmiAQ83W8E

TLDR: This bug brings wiremock to its knees and causes multiple and resonably random failures that are very hard to investigate. This is no longer just about the size and quality of the logs, it majorly affects performance.
Long version: This is a lot worse than we initially estimated. We are running 160 simultaneous tests (with about 5-15 requests per test) and we were having a failure rate of 90%. It was really hard to figure out what the problem was since wiremock seemed properly trained and working so we were actually adding more debug messages to our app in trying to figure out where the problem was. But we did the right thing and decided to fix the wiremock logging issue first so we can actually see the errors in the much smaller/cleaner logs once the issue was removed . As soon as the errors stopped being logged our failure rate moved to 3% and we could easily figure out what the causes were for those.

See my comment here https://github.com/tomakehurst/wiremock/issues/652#issuecomment-446423920

See also my PR https://github.com/tomakehurst/wiremock/pull/1049

Closing individual logging issues in favour of (referenced) logging redesign issue.


add dockerfile for ova-provider

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.28%. Comparing base (11ebad9) to head (dc397e7).
Report is 7 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1049   +/-   ##
=======================================
  Coverage   16.28%   16.28%
=======================================
  Files         112      112
  Lines       19772    19771    -1
=======================================
  Hits         3220     3220
+ Misses      16268    16267    -1
  Partials      284      284

Flag
Coverage Δ

unittests
16.28% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remove calls to methods deprecated as of iOS 7/8.

It looks like the backwards compatibility is intentional, so you may choose to suppress the warnings individually in the future.  On the chance that you want to remove compatibility for pre iOS 8, here are the changes required to remove the warnings.

+1


Plugin is too old, please update

Hi, I have an issue when building analytics

here are my app/build.gradle
https://gist.github.com/pratamawijaya/91afa9f00c776d2c7c11
root build.gradle
https://gist.github.com/pratamawijaya/7ba87bdec7bce5f81f14
my Android Studio version 1.2.2
any ideas how to solve these ?

Same here

Change the line com.android.tools.build:gradle:1.3.0-beta3 to classpath 'com.android.tools.build:gradle:1.2.3'

try to back the version of gradle to 1.2.3

Moving to version 1.3.0-beta4 should work.

@kroikie I sent a pull request to update our code to use the latest stable version of the plugin, otherwise we're going to have a similar issue opened after every release of the beta plugin.


Build from source with Stack

Is it possible to build elm-platform from source with Stack?
I'm trying to build elm-platform on MacOS. To get old Haskell environment, I'm using Stack.
After installing Stack, I did the following.
$ stack setup 7.10.3
$ stack install --resolver lts-4.2 cabal-install
$ stack runghc --resolver lts-4.2 buildFromSource.hs 0.18

This works almost fine, but .cabal-sandbox/bin is not created.
Full log is here:
Using GHC 7.10
Using Cabal <IP_ADDRESS>

Cloning into 'elm-compiler'...
remote: Counting objects: 24996, done.
remote: Compressing objects: 100% (27/27), done.
remote: Total 24996 (delta 9), reused 0 (delta 0), pack-reused 24968
Receiving objects: 100% (24996/24996), 6.58 MiB | 765.00 KiB/s, done.
Resolving deltas: 100% (15460/15460), done.
Checking connectivity... done.
Cloning into 'elm-package'...
remote: Counting objects: 3703, done.
remote: Total 3703 (delta 0), reused 0 (delta 0), pack-reused 3703
Receiving objects: 100% (3703/3703), 697.31 KiB | 475.00 KiB/s, done.
Resolving deltas: 100% (2203/2203), done.
Checking connectivity... done.
Cloning into 'elm-make'...
remote: Counting objects: 1051, done.
remote: Total 1051 (delta 0), reused 0 (delta 0), pack-reused 1051
Receiving objects: 100% (1051/1051), 217.22 KiB | 172.00 KiB/s, done.
Resolving deltas: 100% (706/706), done.
Checking connectivity... done.
Cloning into 'elm-reactor'...
remote: Counting objects: 3396, done.
remote: Total 3396 (delta 0), reused 0 (delta 0), pack-reused 3396
Receiving objects: 100% (3396/3396), 1.92 MiB | 705.00 KiB/s, done.
Resolving deltas: 100% (1948/1948), done.
Checking connectivity... done.
Cloning into 'elm-repl'...
remote: Counting objects: 995, done.
remote: Total 995 (delta 0), reused 0 (delta 0), pack-reused 995
Receiving objects: 100% (995/995), 175.06 KiB | 0 bytes/s, done.
Resolving deltas: 100% (615/615), done.
Checking connectivity... done.
Downloading the latest package list from hackage.haskell.org
Skipping download: Local and remote files match.
Writing a default package environment file to
/Users/jinjor/Projects/elm-book/Elm-Platform/0.18/cabal.sandbox.config
Creating a new sandbox at
/Users/jinjor/Projects/elm-book/Elm-Platform/0.18/.cabal-sandbox
cabal: Use of GHC's environment variable GHC_PACKAGE_PATH is incompatible with
Cabal. Use the flag --package-db to specify a package database (it can be used
multiple times).
cabal: Use of GHC's environment variable GHC_PACKAGE_PATH is incompatible with
Cabal. Use the flag --package-db to specify a package database (it can be used
multiple times).
cabal: Use of GHC's environment variable GHC_PACKAGE_PATH is incompatible with
Cabal. Use the flag --package-db to specify a package database (it can be used
multiple times).

This error seems to be the same as this issue. Has anyone solved it?
I also tried directly running runghc without stack, but it took very long. (Is it the right behavior? I could not wait and stoped it...)

I think the error
cabal: Use of GHC's environment variable GHC_PACKAGE_PATH is incompatible with
Cabal. Use the flag --package-db to specify a package database (it can be used
multiple times).

is related to the fact that stack and cabal generally don't play nice. (BuildFromSource.hs is more or less trying to run a cabal install inside a stack install). I'm currently trying to patch the installer to shut up about all its problems so I can get a working 0.18 install on nix, but a more permanent solution may be to just use stack. It honestly looks like the whole BuildFromSource.hs system could just be replaced by a stack.yaml and a .cabal file.

It can be done.

I don't use stack for various reasons.  My workflow is fine, and I'd need to weigh the possible outside benefit against the cost. Right know I do not know that outside benefit at all, so I cannot prioritize this.


Respect server-side sorting of tasks in coordinator console

This is to replace https://github.com/druid-io/druid/pull/3349
The new behavior is thus:

On load, the order as returned by the server is preserved
Tables can be sorted by any column by clicking it

👍  LGTM

@gvsmirnov can you sign our CLA? http://druid.io/community/cla.html

@fjy he already did.

@gianm thanks


Wrong polyfill name for IntersectionObserver

When adding the IntersectionObserver polyfill while creating a bundle, "IntersectionObserver-polyfill" is added to the query string. This is incorrect as it does not pull in the polyfill. Instead, "IntersectionObserver" should be added. The same applies for IntersectionObserverEntry.

Actually the -polyfill ending is added to all polyfill query strings, not just the IntersectionObserver polyfill. Thus none of them is working out of the box. After manually removing the -polyfill like stevesy wrote, then they work nicely.

Same here, removing -polyfill works like a charm but the website is giving wrong informations
Thanks

This has now been fixed and is live on polyfill.io


Add engine.node ">=7".

Since async/await is used.

Only samples are async / await compatible and the engine is only ES6.


Add ORTC Task

We should add the ORTC task.

I don't have any experience with it. Is there any browser besides Edge that already implements it?

No, not that I have heard of. It's not urgent and - as it's a task - it's independent from the release of the protocol itself. But I'll start writing the spec for it soon. :)


Added SecurityLogic value to the Config object with DefaultSecurityLo…

…gic as default.
This allow us to retrieve the actual value from the Config object for instance when using the SecureAction annotation within the Pac4j-play project. Currently there is now easy way to switch securityLogic implementations.

Removed Config object changes, going for '''@Inject''' in play-pac4j instead

Reopening as per request.
@inject Solution did not do the trick. Using Config object approach instead.

I don't see any changes in this PR. I guess there is an issue.

@leleuj It's because the second commit in the PR reverts the changes before that

Fixed by: https://github.com/pac4j/pac4j/commit/044f01023e085b93c27f2c44b3be5c84f4baef94


Added claude 3.5 sonnet and perplexity with llama model to curated ai…

Added claude 3.5 sonnet model and perplexity with llama large 8b instruct model to the curated list of models

I have updated the file structure in the PR with the handler moved and also removing the try catch from the sonnet file making it not suppress the error

You added axios without using it somewhere. Is that a mistake or did you do it on purpose and if the latter why?

I added axios because perplexity doesn't offer any sdk or package for using the models and it was only available through the api call and i think axios is the way to go for calling api's rather the fetch method where you need to do the heavy lifting work and axois provides things out of box which normal way of calling api's using fetch doesn't

If axios doesn't work out for us. i can do the normal standard way using the fetch too

Sure will change it to fetch from axios

@krishkalaria12 btw are you in discord?

@webdevcody my discord username is krishkalaria12


Add Clubstep (Phonk Remix) by pohgii

Song Name
Clubstep (Phonk Remix)
Artist Name
pohgii
Source
Youtube
Youtube Link
EJFM2e7lC54
Direct File Link
No response
Song ID
13
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 59699245

accept. Good phonk remix!


Added 'print' chunk option

The print chuck option is useful in the juliaconsole environment so we can use print instead of display (certain vectors output more compactly using print, especially for textbooks). I think a more sophisticated implementation (e.g., use of Base.invokelatest) could be an improvement from my first pass.
Note, this was forked off of v0.9.4

Codecov Report

Merging #387 into master will decrease coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   74.34%   74.31%   -0.04%
==========================================
  Files          25       25
  Lines        1345     1347       +2
==========================================
+ Hits         1000     1001       +1
- Misses        345      346       +1

Flag
Coverage Δ

#unittests
74.31% <66.66%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/config.jl
20.00% <ø> (ø)

src/display_methods.jl
41.93% <66.66%> (+0.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a7f2a...c3d1c1a. Read the comment docs.


⚠ Bofrost.lu has degraded performance

In 0b85802, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1184 ms

Resolved: Bofrost.lu performance has improved in 10a6a07 after 19 minutes.


Move the live webinars to featured

Move the live webinars to featured

@tatevikteroyan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

sign-off

@maggiesMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@maggiesMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@maggiesMSFT: I'm sorry - only the author of this article, @kfollis, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Rename binary to cargo-fix

After a cargo install rustfix, the subcommand cargo fix would be available.

Can we cheat and add two [[bin]] with "rustfix" and "cargo-fix" as names, but both with src/main.rs as target? :D

Cargo will produce
warning: file found to be present in multiple build targets: src/main.rs

if we do that :(
I guess we can move the logic to lib.rs and load it from both src/bin/rustfix.rs and src/bin/cargo-fix.rs which simply have the same source code. Or go the extremely hacky route of creating src/bin/cargo-fix.rs with the content include!("../main.rs")


Add timeout argument to wait message

Expected Behavior
In ophyd.v2 I would like to call complete on a number of detectors, then while any are not complete then call collect repeatedly at a known flush rate. This allows the plan to control the flush rate of an HDF file. The plan would look like this:
for det in dets:
    yield from bps.complete(det, wait=False, group="complete")
done = False
while not done:
    try:
        yield from bps.wait(group="complete", timeout=FLUSH_PERIOD)
    except TimeoutError:
        pass
    else:
        done = True
        for det in dets:
            yield from bps.collect(det, stream=True, return_payload=False)

To do this, I need to be able to wait for a group to complete for up to a time period, and raise TimeoutError if it fails.
Current Behavior
Currently I have to run a sleep loop, checking the value of a status object.
Possible Solution
Add a timeout=None argument here that is passed down as a kwarg to the Msg:
https://github.com/bluesky/bluesky/blob/7fb01233d7ee8bd3ccf9441e6a46cd7bdb4fc008/bluesky/plan_stubs.py#L488
Add the same msg.kwargs.get("timeout", None) to the wait_for Msg here:
https://github.com/bluesky/bluesky/blob/7fb01233d7ee8bd3ccf9441e6a46cd7bdb4fc008/bluesky/run_engine.py#L2201
Extract the timeout=msg.kwargs.get("timeout", None) and pass it to asyncio.wait:
https://github.com/bluesky/bluesky/blob/7fb01233d7ee8bd3ccf9441e6a46cd7bdb4fc008/bluesky/run_engine.py#L1738
The return from asyncio.wait is a a tuple of done and pending futures. If there are any pending futures then raise TimeoutError.
@tacaswell does this sound reasonable?

yes.

Yes, happy to give this a go!

Closed by https://github.com/bluesky/bluesky/pull/1598


ListDiffable isEqual always compares with the same object after the update.

ListDiffable isEqual always compares with the same object after the update.

[ ✅] I have reviewed the README and documentation
[ ✅] I have searched existing issues and this is not a duplicate

General information

IGListKit version: 3.4.0
iOS version(s): 12.0
CocoaPods/Carthage version: 1.5.3
Xcode version: 10.0
Devices/Simulators affected: All
Reproducible in the demo project? (Yes/No): Yes
Related issues: NA

Updating an user object and expecting to reload by adapter.performUpdates by checking isEqual.
I have a ViewController listing all the users from an array of user objects. After selecting one user I want to reload the perticular section.
func didSelectAtIndex(_ index: Int) {
    let user = users[index]
    user.name = "User " + "\(index) updated"
    adapter.performUpdates(animated: true, completion: nil)
}

UserInfo class
class UserInfo: ListDiffable {
    var id: Int!
    var name: String!

    init(id: Int, name: String) {
        self.id = id
        self.name = name
    }

    func diffIdentifier() -> NSObjectProtocol {
        return id as NSObjectProtocol
    }

    func isEqual(toDiffableObject object: ListDiffable?) -> Bool {
        guard let object = object as? UserInfo else {
            return true
        }
        *both the objects are same, I know I just updated the same object.*
        print("self.name = \(self.name)")
        print("object.name = \(object.name)")
        return self.name == object.name
    }
}

Is this an expected behaviour? I know I can reload the SectionController from the same controller using
performBatch like this.
    collectionContext?.performBatch(animated: true, updates: { (batchContext) in
        object.isSelected = !object.isSelected
        batchContext.reload(self)
    })

Then what is the use of func isEqual(toDiffableObject object: ListDiffable?) -> Bool ?

You need to use immutable objects. Aka create new users, instead of mutating the existing ones.

Immutability
The data should be immutable. If you return mutable objects that you will be editing later, IGListKit will not be able to diff the models accurately. This is because the instances have already been changed. Thus, the updates to the objects would be lost. Instead, always return a newly instantiated, immutable object and implement IGListDiffable.

From the docs here: https://instagram.github.io/IGListKit/getting-started.html

Closing as that's exactly the issue. Mutating the instance will just change the instance to itself. You need to create a new object.

@calimarkus @rnystrom  Thanks. Yes! I am doing the same. Creating new instances of UserViewModel in "func objects(for listAdapter: ListAdapter) -> [ListDiffable] {}" and returning from there.

In your example above you mutate an existing model:
func didSelectAtIndex(_ index: Int) {
    let user = users[index]
    user.name = "User " + "\(index) updated"
    adapter.performUpdates(animated: true, completion: nil)
}

You want to avoid that and instead create new models. Your .name property is not immutable.

I'm creating brand new objects, and I can confirm that through their memory address, however, isEqual to when performing updates, always compares the new object, not the new object with the old one


[Kubernetes] Added ingress resource to dashboard

Allows to opt-in for an ingress on top of the dashboard service.
This is very important in production-grade deployments where you want to expose the Pulsar dashboard through an easy to remember URL.

run integration tests

rerun integration tests


Add 'make tests' for running locally.

'make test' and 'make integration_test' are configured to run under Jenkins.
New targets should be added to run tests locally. They should call pytest directly, skipping the docker target and calling run_tests.py.
Consider renaming the existing tests to 'jenkins_<test_name>'.

I have some improvements for the local testing experience in the works. Currently however, make test does call run_tests.py directly.
I'm confused on which make targets Jenkins actually runs. I cannot find where the environment variable make_targets is defined for Jenkins.
Currently I suspect that Jenkins uses just test_parallel and test_integration, but I'm not sure how to confirm.
@ejacox do you have any ideas?

Would it be simpler to call the tests directory, rather than through run_tests.py?
Jenkins toil-pull-requests calls the following make targets:
check_cpickle docs clean_docs test_parallel check_clean_working_copy
Jenkins toil-pull-request-test-integration calls these make targets:
docs clean_docs integration_test check_clean_working_copy

Woops! that was a typo... I mean to say the exact oposite:   Currently however, make test does not call run_tests.py directly. This was actually addressed in an old PR I found.
I'm editing run_test.py to have a separate option for running the integration tests locally—the main reason being that then we have only one source of what counts as an integration test.

I have a working target for running integration tests locally in series. Unfortunately this takes ages to run. There is also an immense amount of output from the tests. @ejacox looking for input.

The motivation for this issue is to be able to run as many tests locally as possible and to get away from using Jenkins to test code under development.
One issue is how to choose which tests to run. Currently, decorators are used to skip tests that don't have the right environment (e.g. no Azure credentials). One option is to select tests by name, such as all AWS tests.
The other issue is setting up the environment correctly. For example, the current configuration always pushes a docker container before starting the tests. Is this required for some tests? Which ones? Some of the AWS tests fail for me locally, even though I have AWS credentials configured.
We can start with targets useful to us to setup a framework for running sets of tests and expand on it as needed for other uses.
If the Makefile approach isn't working, a python script could be used, too (reusing run_tests.py or creating another).

I have looked into the docker issue. We're actually not the first to find building the docker container a little superfluous.
The current solution which is basically undocumented—minus a couple comments in the makefile—requires setting TOIL_DOCKER_REGISTRY to the empty string. This prevents the docker appliance from being built.
The test(s) that need the docker appliance are marked with @needs_appliance. They are skipped if the appliance isn't built.
This all seemed pretty round-about to me so I am adding a new make target to run tests without docker and skip all of the @needs_appliance tests.

@jessebrennan I think what the make file is missing is the setup that is done in jenkins.sh.
Jenkins calls this before calling the make targets:
export TOIL_DOCKER_REGISTRY=quay.io/ucsc_cgl
export TOIL_DOCKER_NAME=toil-pr
export docker_registry=$TOIL_DOCKER_REGISTRY # delete once PR #1260 is merged
export docker_base_name=$TOIL_DOCKER_NAME # delete once PR #1260 is merged
. ./jenkins.sh

As a side note, it looks like #1260 has been merged, those last two environment variables have been merged, and those two lines can be deleted.


added pre-commit script

Pull Request Test Coverage Report for Build 42

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.611%

Totals

Change from base Build 40:
0.0%

Covered Lines:
376

Relevant Lines:
406

💛  - Coveralls


[SPARK-37339][K8S] Add spark-version  label to driver and executor pods

What changes were proposed in this pull request?
This PR aims to add spark-version label additionally to the driver and executor pods.
Why are the changes needed?
This enables the users select Spark jobs by the versions.
$ bin/spark-submit \
--master k8s://https://kubernetes.docker.internal:6443 \
--deploy-mode cluster \
-c spark.executor.instances=2 \
-c spark.kubernetes.container.image=dongjoon/spark:v3.3.0 \
--class org.apache.spark.examples.SparkPi \
local:///opt/spark/examples/jars/spark-examples_2.12-3.3.0-SNAPSHOT.jar 200000
...
21/11/15 14:19:57 INFO LoggingPodStatusWatcherImpl: State changed, new state:
	 pod name: org-apache-spark-examples-sparkpi-e7c7e17d25af7a9e-driver
	 namespace: default
	 labels:
           spark-app-name -> org-apache-spark-examples-sparkpi,
           spark-app-selector -> spark-ba77aee3ee284c80b5112d204f778067,
           spark-role -> driver,
           spark-version -> 3.3.0-SNAPSHOT

$ k get pod -l spark-version=3.3.0-SNAPSHOT
NAME                                                        READY   STATUS    RESTARTS   AGE
org-apache-spark-examples-sparkpi-e7c7e17d25af7a9e-driver   1/1     Running   0          37s
spark-pi-8a81ea7d25af8638-exec-1                            1/1     Running   0          34s
spark-pi-8a81ea7d25af8638-exec-2                            1/1     Running   0          34s

Does this PR introduce any user-facing change?
Yes, but it's a new K8s label.
How was this patch tested?
Pass the CIs with the newly added test cases.

Test build #145248 has started for PR 34609 at commit 41e60bb.

Test build #145248 has finished for PR 34609 at commit 41e60bb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145248/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49718/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49718/

Hi, @viirya . Could you review this please?

lgtm

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49718/

Thank you so much!

Merged to master for Apache Spark 3.3.


more info in the error messages

when I specify a field decorator such as this:
@ObjectType({ description: 'Simple product object type' })
class Product {
  @Field()
  async wow(): Promise<number> {
    return 10
  }
}

I get this error:
TypeError: undefined is not a promise
    at Promise (<anonymous>)
    at resolveType (/home/capaj/git_projects/tests/type-gql/node_modules/typegql/lib/index.js:227:24)
    at inferTypeOrThrow (/home/capaj/git_projects/tests/type-gql/node_modules/typegql/lib/index.js:389:12)
    at resolveRegisteredOrInferedType (/home/capaj/git_projects/tests/type-gql/node_modules/typegql/lib/index.js:607:12)
    at compileFieldConfig$$1 (/home/capaj/git_projects/tests/type-gql/node_modules/typegql/lib/index.js:625:24)
    at /home/capaj/git_projects/tests/type-gql/node_modules/typegql/lib/index.js:658:39
    at Array.forEach (<anonymous>)
    at getAllFields (/home/capaj/git_projects/tests/type-gql/node_modules/typegql/lib/index.js:653:25)
    at /home/capaj/git_projects/tests/type-gql/node_modules/typegql/lib/index.js:666:39
    at Array.forEach (<anonymous>)

Which is fine-you need to specify the type explicitly using {type: Number}, but would it be possible to maybe at least print out a name of the field and the name of the class?
It's quite hard to find where the error is coming from if I have just added many fields

Do you use compileSchema function of typegql to compile schema that is using this type? It should perform validation and do exactly what you're asking here

I just have this very basic project set up and I try most of the things there: https://github.com/capaj/type-gql-with-binding-boilerplate
Our production project is way to complex for experimenting like that. You can see I compile it here: https://github.com/capaj/type-gql-with-binding-boilerplate/blob/3ad576184fbdf405cf4445f1340728d3064a0947/index.ts#L55
and I run it using  https://github.com/capaj/type-gql-with-binding-boilerplate/blob/3ad576184fbdf405cf4445f1340728d3064a0947/package.json#L7


Which branch?

Currently this repo has two branches:
https://github.com/bitfocus/companion-module-simedia-yesapi/branches/all
The most recently updated one is not the default, and doesn't seem to share any commits with the older (default) branch...

Thanks for removing the other one @Julusian !


tests: addition of authentication utility functions

Adds utility functions for testing purposes:

client_authenticated which checks if the current client is authenticated by attempting to access the "change password" form/view (requires app context and a client)
create_test_user which creates a new user from the given arguments and returns the user object, with its plaintext password as an additional field (password_plaintext) (requires app context)
login_user_via_view(client, email, password) which logs the user in via the login page (requires app context and a client).

Ideally the login utility would just log the user in and return the valid session which we could then attach to a client. However I've not been able to figure out how flask creates and attaches the session to the client, and my efforts to reverse-engineer/duplicate this process have not been successful.

@otron s/add/addition/
--
source: http://pythonhosted.org/invenio/technology/git.html#r2-remarks-on-commit-log-messages

@otron please read http://pythonhosted.org/invenio/technology/git.html#r2-remarks-on-commit-log-messages again and re-format bullet points.

@jirikuncar should the module be "global" or "tests"? (tests isn't recognized by kwalitee).

@otron tests: is fine

@otron Is this ready to go?

@lnielsen I've fixed all the issues with it raised by reviewers (i.e. Jiri) since opening it, so I guess so?
It was ready for reviewing when I opened it. I'd think someone else would decide when it's done being reviewed.

@otron Thanks, please rebase on top of latest master.

@lnielsen done

Sorry, you'll have to do it one more time :(

@lnielsen: have rebased on top of master.
@jirikuncar: changed the client_authenticated function to check the status code instead of the data. Good call by the way -- data was actually the contents of the response (i.e. the page itself) and not the URL as I'd assumed.

@otron this is a reminder of http://pythonhosted.org/invenio/technology/git.html#r2-remarks-on-commit-log-messages and an example with correctly structured output from git log:
    tests: addition of authentication test utils

    * NEW Adds utility functions for tests conducted
      in an application context in `invenio_accounts/testutils.py`. A
      function to create/register a user for testing purposes; logging a
      user in (requires a test client); and one which checks if a client is
      authenticated.

    Signed-off-by: Odd Magnus Trondrud<EMAIL_ADDRESS>

@jirikuncar I'd like to point out that my commit message conforms to the rules laid out in http://pythonhosted.org/invenio/technology/git.html#r2-remarks-on-commit-log-messages
Neither of the differences between the "correctly structured" commit message and my own are mentioned in the remarks. There's nothing about colons at the end of a label or the line limit for non-header lines.


Adding support to allow people to use fake_sqs in local environment

Added new environmental variable SQSD_ENDPOINT
Added new environmental variable SQSD_SSL_ENABLED
Update to latest aws-sdk

Hi,
I've been trying to get sqsd to work with fake_sqs. These are the changes I needed to do to get it to work.


[Bug?] column u0.sign_in_token does not exist

Thanks for this great library!
When I updated firezone to latest ( 0.7.8 ), I've got the errors shown below.
I found that the colum sign_in_token is recently dropped
In my environment, there are users signed in by OIDC process. ( signed up with previous version firezone )
Do you have any idea to solve this?
10:51:35.385 [error] GenServer #PID<0.475.0> terminating
** (Postgrex.Error) ERROR 42703 (undefined_column) column u0.sign_in_token does not exist

    query: SELECT u0."id", u0."role", u0."email", u0."last_signed_in_at", u0."last_signed_in_method", u0."password_hash", u0."sign_in_token", u0."sign_in_token_created_at", u0."disabled_at", u0."inserted_at", u0."updated_at" FROM "users" AS u0 WHERE (u0."disabled_at" IS NULL)
    (ecto_sql 3.9.2) lib/ecto/adapters/sql.ex:913: Ecto.Adapters.SQL.raise_sql_call_error/1
    (ecto_sql 3.9.2) lib/ecto/adapters/sql.ex:828: Ecto.Adapters.SQL.execute/6
    (ecto 3.9.4) lib/ecto/repo/queryable.ex:229: Ecto.Repo.Queryable.execute/4
    (ecto 3.9.4) lib/ecto/repo/queryable.ex:19: Ecto.Repo.Queryable.all/3
    (fz_http 0.7.2) lib/fz_http/oidc/refresh_manager.ex:41: FzHttp.OIDC.RefreshManager.spawn_refresher/0
    (fz_http 0.7.2) lib/fz_http/oidc/refresh_manager.ex:24: FzHttp.OIDC.RefreshManager.handle_continue/2
    (stdlib 4.1.1) gen_server.erl:1123: :gen_server.try_dispatch/4
    (stdlib 4.1.1) gen_server.erl:865: :gen_server.loop/7
Last message: {:continue, :schedule}

When I start firezone:latest for empty database, it works well.

Hi @shohei-ihaya — from the log output it looks like your firezone image is still at 0.7.2. Could you double-check you’re running 0.7.8?

@jamilbk
Oh.... I'm so sorry ....

I specify firezone:latest image, but due to local image cache, old version is continuously used ...
Thanks a lot!


Issue template that includes the project

Simple create an issue template that includes the project. So we don't have to auto add it.

Seems like we can't do this unfortunately


Implement Extend for WriteHandle

Add a impl for Extend to WriteHandle, to append multiple operations
from an iterator from the oplog at once. In addition to convenience,
this has the potential to be more efficient by avoiding reallocating the
vector for the oplog multiple times.

This change is

That's a great idea, love it! One little nit inline and then I'm happy to merge this.

Thanks!

Published in left-right 0.11 and evmap 11.0.0-alpha.5 :tada:


Add Compound Config

This patch adds Compound Config to the Open Oracle that allows us to trac the Compound Config repo. This means, for instance, when you run a saddle console -n mainnet, you'll actually have access to the Open Price Feed contracts. This makes it easy to get a console and interact with the OPF.

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   97.47%   97.47%
=======================================
  Files           6        6
  Lines         555      555
  Branches      148      148
=======================================
  Hits          541      541
  Misses         14       14


Fixes and minor improvement for detect.sdks.find_vstudio

I've included two fixes to find_vstudio for older MSVC/VS builds, detailed in the commit messages.
I also included a commit which modifies the search logic to only use find_tool("vswhere") for MSVC/VS versions where it is supported.

The purpose of find_vstudio is to detect all vs environments on the system, not just the current one.
Because under the vs command prompt we also need to switch the vs version.
for example:
$xmake f --vs=2015
$xmake
$xmake project -k vs2017
$xmake project -k vs2015

-- find the single current MSVC/VS from environment variables
local VCInstallDir = os.getenv("VCInstallDir")
if VCInstallDir and (VCInstallDir ~= "") then

        -- save results
        local results = {}
        results[vsvers[VisualStudioVersion]] = {version = VisualStudioVersion, vcvarsall_bat = vcvarsall, vcvarsall = {x86 = vcvarsall_x86, x64 = vcvarsall_x64}}
        return results
    end
end

you can use os.getenv(VisualStudioVersion) get the current vs version and save to results.
Then we can select this version first in
https://github.com/tboox/xmake/blob/master/xmake/platforms/windows/check.lua

I'm not sure it's possible to detect the correct environments of all MSVC/VS environments on the system when you're within an already pre-prepared environment. I think that to do so would require scrubbing out the currently prepared versions environment variables. You could delete some, but scrubbing the PATH would be quite difficult.
Prior to this commit set, the results of find_vstudio were a muddled combination of the environments between the currently set environment and the next detected MSVC/VS version. And, I definitely have had problems when inadvertantly running multiple vsvarsall from differing MSVC/VS versions in the past.
And the original source returned after detecting just the currently set environment if it saw VCInstallDir and VisualStudioVersion.

We should also check other versions while acquiring the current VS environment.
Not just one version

you'll need to, at least, delete all the environment variables except PATH.

Why? We only need to detect one VS version in the current environment variable of command prompt and detect other versions from vswhere and registry

os.getenv(VisualStudioVersion) to get the current vs version and select this version first

I like the idea of selecting the currently setup version first, but, I believe that'll only work for versions of MSVC/VS which set that environment variable. I'm not sure when the transition happened, but MSVC/VS 8.0/2005 (and earlier) doesn't have it. I can see that MSVC/VS v11.0/2012 does have it. So it could have been added anywhere in the VC9/2008, VC10/2010, or VC11/2012 versions.

Why? We only need to detect one VS version in the current environment variable of command prompt and detect other versions from vswhere and registry

The results that I see from find_vstudio have all of the environment variables associated with that version listed (with values) in the return results table. But, with a pre-prepared environment, the environment variables from the newly discovered environment are mixed on top of the current settings. I think using the resulting mixed environment will cause later issues. It's definitely much different from the results returned when you have a non-prepared (normal CMD) environment.
It's possible that cleaning the listed environment variables would clean things up enough to avoid issues. Although I'm still worried that the value of PATH may be problematic.

The detection process does not affect the current environment
local file = io.open(genvcvars_bat, "w")
    file:print("@echo off")
    file:print("call \"%s\" %s > nul", vcvarsall, arch)
    for idx, var in ipairs(vcvars) do
        file:print("echo " .. var .. " = %%" .. var .. "%% %s %s", idx == 1 and ">" or ">>", genvcvars_dat)
    end
    file:close()

I will merge this patch first, then I will modify it slightly.

Yes, I agree, the detection doesn't effect the current environment, but the current environment effects what results returns as values for environment variables. Using your current "dev" branch code, I've attached three files ("CMD.txt" which is the xmake lua detect.sdks.find_vstudio output from a normal CMD prompt without running vsvarsall, "CMD+VC8.txt" is run from the VC8 command prompt, and "CMD+2017.txt" is run from the VC2017 command prompt).
CMD.txt
CMD+VC8.txt
CMD+VC2017.txt
Note the variation in what is returned and how the values of VC2017 are contaminated by VC8.

Ok, I understand what you mean and agree with you, so let's do it first.

So, after thinking about this, one way to get all versions even if one is already setup via a "VCX Command Prompt" or running vcvarsall would be to reset the environment prior to searching for the other versions:

save the current environment, then erase it
re-read and reconstruct the environment from the registry via the "HKLM\System\CurrentControlSet\Control\Session Manager\Environment" and "HKCU\Environment" keys (see https://stackoverflow.com/a/32420542/43774); (note: merging the PATH variables)
if the VCVARS_ARE_SET and/or VCInstallDir environment variables are missing (meaning the user environment has a "clean" version without MSVC/VS variables), then search for other versions, skipping any already defined version in the results array

As long as the MSVC/VS variables are not "permanently" set in the user environment, this would give you all available versions with the cleanest respective environment.
Along with this, I would default to use the current environment MSVC/VS version if it's already setup.
I can see how it needs to be done, but I don't know how to read all of the registry keys to find the variables. All of the examples I see accessing the registry are for specific values within a key. If you could guide me on that, I could work up a prototype of the above algorithm.

Thank you very much for taking the time to find a solution to this problem, I thought about it and I think the current processing is very good, we don't have to do too complicated processing on the command prompt environment.
If needs to switch the vs environment to compile, we can open a clean cmd.exe to do it.
And if a vs commad prompt has been opened, in most cases, we just want to compile in the current vs environment.


Support TTL configuration for CosmosDbStorage

Looking for a way to define a TTL for all Cosmos DB documents created by the Bot Framework. Ideally, this would also include defining a TTL as part of the collection creation options, as well as at the individual document level.
Not sure of the implications of such a feature to the framework overall, but in my client use case this was incredibly useful.

Looks like this is definitely possible. I know we've had requests for something like this before.
@bojingo I'll forward this on to the dev team.

I imagine this is a matter of adding a Ttl property to Microsoft.Azure.Documents.Client.RequestOptions so that the Microsoft.Bot.Builder.Azure.CosmosDbStorageOptions.DocumentCollectionRequestOptions and DatabaseCreationRequestOptions properties can tell the CosmosDbStorage class how to define the collection during creation and the documents during write to have the desired TTL.
Behavior semantics of defining the Ttl property in these config properties:

If not specified at the DatabaseCreationRequestOptions level, the collection won't support TTL (unless subsequently changed...)

If the collection doesn't have a TTL defined and the DocumentCollectionRequestOptions has a value, the setting will be ignored by Cosmos DB.
If the collection got a TTL subsequently after create and the DocumentCollectionRequestOptions has a value, the document will successfully have the TTL applied

If specified at DatabaseCreationRequestOptions level but not at the DocumentCollectionRequestOptions level the document will inherit the TTL from the collection.
If defined in both, the DocumentCollectionRequestOptions would take priority on individual documents.

FYI, in my case I manually modified the collection after the Bot Framework created it to give it a default TTL of a day and have had no negative ramifications in the bot implementation or behavior. Only impact is that after a day everyone's conversation and user state is reset to empty - which was intended. :)

Hi @bojingo, this is a good suggestion, I am tagging it for consideration in our next iteration.
Thanks

I'll revisit this once R8 planning is settled.
Some initial thoughts are that, for collection level, we don't need to specifically enable this in our SDK because, as you said, it can be modified later. We have automatic container creation in the SDK as a QOL feature, but you can create it on your own ahead of time/write your own container creation step on start up. You can even modify our indexing policy settings which could break our queries for the old provider. We would need to make a change to enable per document ttl.
Biggest concerns with ttl being enabled in general is the lack of debuggability that Cosmos's TTL feature offers. There is no trace in the changelog/etc. that it was removed, so if you're getting end users that are upset their state was deleted,  you'll have a hard time root causing it.
I think we should definitely provide guidance for how/when to detect you can delete state. That guidance is pretty much non-existent today. So even if we say you should just set ttl yourself, we should give some guidance as to the consequences.
Fun fact: I did some napkin math and I think it works out that it costs 3x to delete a document than it does to store it for an hour (or deleting a document breaks even after the 3rd hour post-deletion). I'm not certain on the frequency of the billing metering for storage, so I'm not sure how it would pan out in reality. There's a good chance I missed a unit conversion here, though. Need to break out excel.
@bojingo - a few scoping questions:

Do you mind sharing what scenario you have where you want your state reset every day?
Why do you need it available at the document and collection level? Would you want to be able to say, for a given operation, how long it should be persisted, if we do document level?

The scenario is using a bot to assist people working through tasks at a job site. The state of the job can change such that after a period of time elapses (1 day) we want to treat any continuation of work at the job like a brand new job/conversation. We certainly could have built in a lot of logic related to comparing timestamps and such to start over and discard past state, but in the interest of keeping it simple thought "what if the bot just forgets everything about past conversations?" That ended up proving to be trivial to implement with a TTL, and effective.
I suppose collection level would be sufficient. Not sure I have a reason to have distinct TTLs for different documents within the same collection. My description above was just my attempt at shortest path to getting this capability at all by simply extending RequestOptions to have a TTL property. And if we extend RequestOptions, the property would be available both for collection creation and all subsequent Cosmos operations, like writing individual documents.

My problem domain's use case aside, Cosmos DB's TTL functionality is just awesome for cleaning up old data, anyway. I see that as reason enough to let the bot managed its own collection with a configurable TTL.


chore(deps): revert dependency on shared-react 2.6.3 to 2.6.2

This is a follow-up on #1731 and reverts the @janus-idp/shared-react dep down to 2.6.2 because that release wasn't found on npm.

/cc @nickboldt @debsmita1 @divyanshiGupta @ciiay @invincibleJai


Refactor aggregation logic and allow it to be applied to the matrix again

Closes #238
Closes #232
Closes #225
Relates to #224
Closes #137
Closes #118 (since we've refactored the whole thing)
TODOs:

[x] Allow matrix to be reset
[x] Show child legend
[x] Debug issue when turning off aggregation more than once

Found one major bug (though seems like it is an easy fix) + a couple of minor ones (that are more opinions than required fixes). Otherwise, everything is working as expected!
Major bug
If you submit a connectivity query, view it using the aggregation, then submit another query, enable aggregation is not reset.  I think it should be as simple as adding store.dispatch.updateEnableAggregation(false) to line 189 in ConnectivityQuery.vue
Minor Bugs
(1) If you hover over the + icon, the tooltip shows up very far away

(2) I would assume if you aggregate by a categorical variable you would see it as an attribute on the parent node. In the example below, the Label attribute shows up as - for the aggregated row. But I don't think it's a big deal, it just means you can't filter based on parent node attributes ..

(3) Can we update the child class text color to be slate gray so that it is more visually distinct?

Thanks for such thorough testing.

Major bug
If you submit a connectivity query, view it using the aggregation, then submit another query, enable aggregation is not reset. I think it should be as simple as adding store.dispatch.updateEnableAggregation(false) to line 189 in ConnectivityQuery.vue

Your suggested fix seemed to work here. 8a5785f

Minor Bugs
(1) If you hover over the + icon, the tooltip shows up very far away

I think this is a general bug in the rendering of the tooltip. I'll address it in a follow up #289

(2) I would assume if you aggregate by a categorical variable you would see it as an attribute on the parent node. In the example below, the Label attribute shows up as - for the aggregated row. But I don't think it's a big deal, it just means you can't filter based on parent node attributes ..

Addressed this in 0f21621.

(3) Can we update the child class text color to be slate gray so that it is more visually distinct?

Fixed in 31fe5e7

(4) Color scale of child legend doesn't match the child cells in the matrix

I'll fix in #290

(5) Th z-index of lineup is higher than the tooltips, so sometimes it blocks the tooltip.

I'll add this to #289.


Add "Recursively calculate file sizes at given depth" recipe

Use walkdir's min_dir/max_dir to calculate the total file sizes at some depth of the filesystem tree.

Hi, @brson ! I can do that!

@brson , check, please, if the code is good enough to be published in the book :)

One nit: we should tweak this example to use f.file_type().is_file() instead of requiring the metadata to filter out non-files. It seems minor, but the WalkDir iterator gets the file_type() data for free during iteration (since it's stored in the directory entries), whereas calling metadata() generally means an additional call to stat each item. Those extra syscalls can add up, so it's better to filter on the already-available data first.
Here's an example I wrote when I was learning to use the walkdir API:
https://gist.github.com/luser/e1aee2b269551bb181172a55448c8787

@luser fair point, calling file_type() would be a reasonable performance optimization and your implementation is also very nice.
If you are willing to provide/change this or any other example with textual description, you are very welcome to open a PR :)
For now I'm closing this issue with https://github.com/brson/rust-cookbook/issues/181


Showcase Submission for neural-networks/18-backpropagation-part-5

Thank you Amritpal Singh for your contribution! A member of the Coding Train team will review it shortly.

Tic Tac Toe Using Neural Networks in C#
Amritpal Singh

Great work!!!


remove comment from READMEs

Description
Removes internal comment visible in READMEs
JIRA

@sanscontext your comment is visible in the READMEs that get downloaded.  I'd keep the build instruction since they'll want to build to optimize for production.


[#556] Hide post-seed backup flow and rework screenshot tests

Closes #556

flow is hidden by default
when turned on, only new users (nuke wallet and start over) continues to the flow
unit tests fixed and updated
new unit tests
phrase display screen simplified

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation).  For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author

[x] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[ ] Does the code abide by the Coding Guidelines?
[x] Automated tests: Did you add appropriate automated tests for any code changes?
[x] Code coverage: Did you check the code coverage report for the automated tests?  While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
[ ] Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
[x] Run the app: Did you run the app and try the changes?
[x] Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
[x] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

[ ] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
[ ] Ad hoc review: Did you perform an ad hoc review?  In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[ ] Automated tests: Did you review the automated tests?
[ ] Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
[ ] How is Code Coverage affected by this PR? We encourage you to compare coverage before and after your changes and when possible, leave it in a better place. Learn More...
[ ] Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
[ ] Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

can you left align the Text columns so it's easier to read?


Add default_server for nginx processing and correct http spelling

@dannyroberts
I still want to figure out how this will work if two servers are specified as default  (e.g. staging and prod in this configuration).

@czue This has the change we talked about this morning and a couple spelling fixes.

nothing blocking. the other bugs you found were all in untracked files?

@czue Yeah, there were a couple changes in the untracked configuration, but this was the blocking bug.


[CS2103-W17-2] App-Ointment

App-Ointment helps Receptionists of Clinics schedule appointments, and maintain patient records and accounts. It allows them to more quickly verify the patient on arriving at the clinic for the appointment.

Codecov Report

Merging #16 (cb1c17f) into master (c36220c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36220c...cb1c17f. Read the comment docs.


feat: add javascript stack in gitlab

Added JavaScript stack for GitLab platform.

Results:

Tested with:

a sample javascript project pushed in gitlab

Resolves: #112

Removed the tsc stage. I think it's ok now:

Removed the tsc stage. I think it's ok now:

Worked here

:+1:


Fixes crash due to accessing selection after graph_scene is deleted #218

Summary
The MainWindow class is where I integrated the cleanup routine for the GraphScene. MainWindow has already a closeEvent method. This is where we call the shutdown method of each GraphScene instance before the application closes. However, the GraphScene instances are not directly managed by MainWindow but rather by the panels like GraphEditPanel, ProofPanel, and RulePanel which are derived from BasePanel. Each of these panels contains an instance of GraphScene.
Here's the cleanup implementation:

Add a cleanup method in the BasePanel class.
Call this cleanup method for each panel in the MainWindow's closeEvent.

Firslty, I added a shutdown method to the GraphScene class. Then, added a corresponding method in the BasePanel class that calls GraphScene.shutdown()
Next, I ensured each panel subclassing BasePanel class provides its own shutdown method.
Finally, I modified the closeEvent of the MainWindow class to shutdown on each panel before closing.
This method ensures that each GraphScene is properly cleaned up before the main window closes.

Hi, @RazinShaikh I have made the suggested changes, here is the commit.

I wonder if it wouldn't be simpler and more future-proof to simply clear the node selection when the user asks to close the app?

@dlyongemallo that actually makes more sense

Hi Kaushik, thank you for the PR. Could you please make the requested changes before we can merge this?

Thanks for the PR, Kaushik. Can you make the suggested change and add a test to confirm it works? I think that should suffice.