feat: migrates to rome from eslint and prettier

migrate from prettier and eslint to rome
chore: changeset

Description
Migrates to rome
Additional Information

[x] I read the contributing guide
[x] I added documentation related to the changes made.
[x] I added or updated tests related to the changes made.

Your ENS/address:

Thank you! Rome all the things!


Add Opdom

This is a work in progress, it is not ready.
I am adding this to get early feedback on the current chart configuration.
Until the OpDom image is built and pushed it will not be possible to deploy this chart.
Signed-off-by: matttrach<EMAIL_ADDRESS>

I am unable to add assignees or request reviewers.

I believe this is ready to be deployed.


Cannot see analytics dashboard after installation

Hi,
I'm installing this package as per the explanation. I have the Laravel Spatie package installed and working.
Essentially I'm doing these two steps:
$ composer require bezhansalleh/filament-google-analytics
...
...
119 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
> @php artisan vendor:publish --tag=laravel-assets --ansi --force

   INFO  No publishable resources for tag [laravel-assets].

No security vulnerability advisories found
Using version ^2.0 for bezhansalleh/filament-google-analytics

and
$ php artisan vendor:publish --tag=filament-google-analytics-config

   INFO  Publishing [filament-google-analytics-config] assets.

  Copying file [...\vendor\bezhansalleh\filament-google-analytics\config\filament-google-analytics.php] to [...\config\filament-google-analytics.php]  DONE

However I don't see the Google Analytics dashboard in Filament. I can see the benzhansalleh\filament-google-analytics folder under the vendor directory.
Anyone can help me to ensure I see the dashboad when logging into Filemant admin panel?

For Filament v3 we should register plugin in the Filament Panel Provider
public function panel(Panel $panel): Panel
{
    return $panel
        ->plugins([
            ...
            \BezhanSalleh\FilamentGoogleAnalytics\FilamentGoogleAnalyticsPlugin::make()
        ]);
}

you need to register the page in the AdminPanelProvider panel, like this:
    return $panel
      ->pages([
        // ...
        FilamentGoogleAnalyticsDashboard::class,
      ])


Please add my high school and read my comment.

Let me explain, you refused my last two pull requests, telling me that the domain name was invalid, whereas in my comments I wrote that it was the students' email address that owned the domain name, and if you type https://lyceecoetlogon.fr/ in the search bar, you are redirected to the official site of my academy (the one in Renne), so https://lycee-coetlogon.ac-rennes.fr/, which also proves that the domain name belongs to them.
Summary :
Official Website: https://lyceecoetlogon.fr/
Or rather: https://lycee-coetlogon.ac-rennes.fr/ since it redirects us
Student email : @lyceecoetlogon.fr

@Lhy-x I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host lycee-coetlogon-ac-rennes.fr not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!

@Lhy-x I added the email domain @lyceecoetlogon.fr to the trusted list manually. You did not submit the request with a file name and correct path. For this domain there had to be one file with the name lib/domains/fr/lyceecoetlogon.txt.
Thank you for the contribution. Please start requesting free licenses in about an hour from now.


Old Versions

So I'ev managed to get a docker container of the latest release bedrock loaded and working(on volume 1). Since then I've been looking into addons for the servers, so i wanted to run a 1.17.0 server, but when i run:
"sudo docker run -it -v yourvolumename2:/minecraft -e Version=1.17.0 -p 19199:19199/udp -p 19198:19198 --restart unless-stopped 05jchambers/legendary-bedrock-container:latest"
It still loads the latest....

pi@raspberrypi:~ $ sudo docker run -it -v yourvolumename2:/minecraft -e Version=1.17.0 -p 19199:19199/udp -p 19198:19198 --restart unless-stopped 05jchambers/legendary-bedrock-container:latest
Minecraft Bedrock Server Docker script by James A. Chambers
Latest version always at https://github.com/TheRemote/Legendary-Bedrock-Container
Don't forget to set up port forwarding on your router!  The default port is 19132
Ports used - IPV4: 19132 - IPV6: 19133
Taking ownership of all server files/folders in /minecraft...
Complete
No daily restart scheduled
Backing up server (to minecraftbe/backups folder)
Backing up server (multiple cores) to minecraftbe/backups folder
worlds/
worlds/Bedrock level/
worlds/Bedrock level/level.dat_old
worlds/Bedrock level/levelname.txt
worlds/Bedrock level/level.dat
worlds/Bedrock level/db/
worlds/Bedrock level/db/CURRENT
worlds/Bedrock level/db/MANIFEST-000014
worlds/Bedrock level/db/000015.log
Checking for the latest version of Minecraft Bedrock server ...
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100  318k    0  318k    0     0   282k      0 --:--:--  0:00:01 --:--:--  282k
Latest version online is bedrock-server-<IP_ADDRESS>.zip
Override version, using version specified: 1.17.0 as bedrock-server-1.17.0.zip
Current install is: bedrock-server-1.17.0.zip
Requested version bedrock-server-1.17.0.zip is already installed
Starting Minecraft server...
[2022-12-25 11:59:07] NO LOG FILE! - setting up server logging...
[2022-12-25 11:59:07] [2022-12-25 11:59:07:087 INFO] Starting Server
[2022-12-25 11:59:07] [2022-12-25 11:59:07:093 INFO] Version <IP_ADDRESS>
[2022-12-25 11:59:07] [2022-12-25 11:59:07:093 INFO] Session ID 7283969f-2d29-44fe-a70c-bcc69ed55e39
[2022-12-25 11:59:07] [2022-12-25 11:59:07:138 INFO] Level Name: Bedrock level
[2022-12-25 11:59:07] [2022-12-25 11:59:07:181 INFO] Game mode: 0 Survival
[2022-12-25 11:59:07] [2022-12-25 11:59:07:182 INFO] Difficulty: 1 EASY
[2022-12-25 11:59:07] [2022-12-25 11:59:07:591 INFO] Content logging enabled. Writing log to: ContentLog__Sunday__2022_December_25__11_59_07
[2022-12-25 11:59:07] [2022-12-25 11:59:07:615 INFO] opening worlds/Bedrock level/db

Hello,
I think I can help!  So there's no such thing as Minecraft server version 1.17.0.  You can take whatever version you want to get and put it in Microsoft's web site like this:
https://minecraft.azureedge.net/bin-win/bedrock-server-1.17.0.zip
We can see there's no file found for that on Microsoft's servers.  If you look at the current one on their download page now the current version is:
https://minecraft.azureedge.net/bin-win/bedrock-server-<IP_ADDRESS>.zip
You are going to need to know the exact version that you want to run.  1.17.0 isn't good enough because Bedrock doesn't work like Java Minecraft.  It's going to be some really weird other version like <IP_ADDRESS> or who knows.  I'm not even sure how you'd find the old ones unless you were specifically targeting an exact version.
Like for example we are now on Java Minecraft 1.19.3 yet the Bedrock version for that is <IP_ADDRESS>.  Obviously that looks nothing like 1.19.3 and if you put -e Version=1.19.3 you would get the same error.  There's basically nothing for it to download off Microsoft's servers so it's falling back to the old version.
If you know the exact right dedicated server version to download in there (and it exists on Microsoft's servers when you try it manually) then it will work!

Ok thanks, I'll try doing some googleing for bedrock server version and hopfully i get lucky, Great container BTW!!

No problem at all!  The client may be able to help if you have a specific older client you're targeting.
They don't always match one to one but it's definitely a start and sometimes (especially upon the first release) they'll be in sync.  Other times the client will be something like <IP_ADDRESS> and the server might be <IP_ADDRESS> if that makes sense.
I would definitely start with the exact client one if you have it.  It should be possible to get that to pop up within the game menus itself and get the exact version (or even right click on the Minecraft .exe and go to the "Properties" tab and look what they filled out for Version).
Best of luck, hopefully someone has compiled information like this somewhere (or even if you found an old screenshot happening to show one from that era)!

So i found this: https://minecraft.fandom.com/wiki/Bedrock_Dedicated_Server
It has version list, i tried the link and changed it for "<IP_ADDRESS>" , and it downloaded, so ill give it ago in docker

Bingo!  That is perfect and a pretty amazing / comprehensive list.
Now the only question is to get a version of 1.17 that is compatible enough with the client that the client won't complain when connecting.  With this list though it shouldn't be too hard to move through the different versions though until you find one close enough for the client.
Thanks for sharing that list by the way, I had not seen it before!

Glad i could help :) Thank you again


Update addEquivalents for new structure

The new diacritics.json was not including equivalents. This new build fixes that!

Still doesn't generate the equivalents for me?

Odd, I just tested it and it's working for me.


https not http for the dripper

hi,
i want to know how to force the caffeine dripper to use a https url instead of a http? is there a way to add a setting FORCE_HTTPS?
kind regards
Andy

The drip url is generated using the url() helper, which gets the base url from Laravel. This means it will use the same schema as your Laravel app is configured to use.
Do you have a use-case where you wouldn't want it to behave this way? (If your Laravel app is on HTTPS, but drip is not pointing to HTTPS, my guess is there is probably a configuration issue in your Laravel app.) Please let me know. :)
Thanks!
~Mike

hi, thanks for the reply.
i have the laravel app running behind a load balancer. so the internal laravel system is http but the client facing part is https.
i have changed the line in the middleware to just call
$dripUrl = '/genealabs/laravel-caffeine/drip';
as the url part is broken, when i use the load balancer.
but it is going to break when there is an update!
Andy

Excellent use case, I forgot to consider that! Thanks for bringing this up, I will add that as a configuration option.

could you just have a full url in the config file?

Will definitely consider it. It will probably be two config values, one for the base URL (schema and domain) and another for the actual route on the app.

yes, perhaps you can have url() as the default for the first one, so i can overright it.
thanks for a great package and great service.


Updates docs and tests for new Django versions

Current coverage is 96.62%

Merging #163 into master will not affect coverage as of 6c40c15

@@            master    #163   diff @@
======================================
  Files           40      40
  Stmts         2724    2724
  Branches         0       0
  Methods          0       0
======================================
  Hit           2632    2632
  Partial          0       0
  Missed          92      92

Review entire Coverage Diff as of 6c40c15

Powered by Codecov. Updated on successful CI builds.


Benchmark about Medmnist+

Can u release the benchmark of medmnist+ like the size 224*224?
best wish

https://zenodo.org/records/7782114
I find here, sry for disturb

Hey @Weixiang-Sun,
Exciting news! We've just rolled out the very first solid baseline performance evaluation for MedMNIST+, titled "Rethinking Model Prototyping through the MedMNIST+ Dataset Collection". This comprehensive evaluation covers 10 different deep learning models trained via 3 distinct training schemes across all 12 2D datasets and available image resolutions (28x28, 64x64, 128x128, and 224x224) within the MedMNIST+ dataset.
You can check out the paper here: Link to the paper
And dive into the source code on our GitHub repository: Link to the GitHub repository
We're excited about how this evaluation can establish a baseline for future research in the MedMNIST+ benchmark domain. Looking forward to hearing your thoughts and contributions!
Cheers,
Sebastian

Hi @sdoerrich97 ,
It’s really an exciting update! Thanks for your contribution to the MedMNIST community! I will add a reference to your work in the MedMNIST readme.
Jiancheng


Save to db - the deployer email ID along with lab details when a lab is deployed

Fixed. Tested. Code review is pending.
Commit can be accessed here: https://github.com/vlead/ovpl/commit/b89a65dbfbed21b038b3290b7398b4f59879922d


Do Existing Rules Support these Criteria? or Is It Worth Creating New Rules?

Gherkin-lint has been amazing so far... I have few questions though,

Is there a rule to check if the last step in Scenario or Scenario Outline should not be a When step? Then, And and But should be okay.
A rule to check if there is more than one space in the step after Gherkin keyword? Then   I am on the Home page is wrong rather it should be Then I am on the Home page Like how one-space-between-tags rule works something like that for steps would be great.
A rule to check Feature file name length?
A rule to ignore feature files with a tag or specify a directory path so all features files in it are ignored?
A rule to throw error when there is a period(".") at the end of scenario name
Can name-length rule also cover Scenario Outline name length?

@vsiakka any existing rule would cover these? If no, do you think it's worth to have new rules for them?

Are my questions making sense to anyone? Does any existing rule cover my list item or is it worth having new rules for them?


new functions added in test_script

Coverage increased (+15.0%) to 71.429% when pulling 5640c9a25acdfdf25a8ea52ed79e82d8b863bca1 on dev into f3edba07ab9280db3601ed11ee46461ca350de30 on master.


failure to create .lnk file

I've run through the installation process a couple of times now and I keep getting the following on Windows 10:
CScript Error: Execution of the Windows Script Host failed. (Access is denied. )
"Created EcoAssist.lnk"
We are seeing the following error during the install but not sure how to resolve it:
ERROR conda.core.link:_execute(745): An error occurred while installing package 'conda-forge::bzip2-1.0.8-h8ffe710_4'.
Rolling back transaction: done
Thanks for any help or guidance you can provide.

@andrea-petrullo It looks like there are two issues here.

The first one probably has to due with your security settings, most likely you anti-virus software (link). Could it be that some VPN, proxy server, antivirus or other protection software was still enabled during installation? This is a common problem with installs on company machines.
The conda.core.link error looks like some problem with the conda installation. Possibly easy to solve (link), but perhaps it won't even be a problem if we solve issue number 1 first.

Thank you!  That seems to have been the problem...I was able to download it on my personal laptop by turning the antivirus off.  My work computer has administrative locks on it and I'm still trying to get the antivirus temporarily turned off.


Support for RISE slides?

Hi there,
Is there any way to generate https://github.com/damianavila/RISE based slides at this point?  If not, it would be a great feature for generating slides for tutorials and classes.

That would be great indeed!
And in general having some syntax for setting cell metadata. Asecond use case: writing exercise sheets with automatic feedback / grading with ordo / nbgrader respectively.

I agree. We would like to add a specific jupyter directive for better control and more direct linking with the jupyter notebook spec. Ref #13

Thanks @FelipeMaldonado -- PR https://github.com/QuantEcon/sphinxcontrib-jupyter/pull/112 adds support for slides. It is not feature complete - so will leave this issue open and tag for 0.6 for review.


XamlCode.exe RPC_E_WRONG_THREAD SHCore.dll thread Mobile Emulator

I chose mobile emulator to run the XamlCode sample as x86 Debug from VS2017 with cppwinrt installed via nuget and Pictures Library Capability enabled from Package.appxmanifest
It throws RPC_E_WRONG_THREAD error. The thread appears as SHCore.dll

Some functionalities must be invoked in ui thread. What is the "Capability" you are using?

It's the sample from this repository itself. It does OCR on an image that user selects from the device's Pictures library. "Capabilty" list can be seen by opening the appxmanifest file within VS. The target for running the app, as mentioned above, should be selected as emulator to get the error.

some functionalities must be called by the UI thread for security reason.

XAML components enforce that you call their methods on the UI thread. This isn't really a security issue. It's a correctness enforcement. As UI components execute on a (single) UI thread, a developer doesn't need to make their state safe for multi-threaded access. XAML, therefore, checks on each call that the caller is running on the UI thread.
This isn't particular to C++/WinRT. It's just how XAML has always been implemented.
So, for example, if you've some callback running on an arbitrary thread, and you want to call a UI object's method, you'll need to switch to the UI thread first.


🐛 Bug Report: Appwrite Rest endpoint expects 'passwordAgain' param when calling account.updateRecovery

👟 Reproduction steps
Install appwrite web sdk, configure w/ v1 endpoint (https://cloud.appwrite.io/v1), and attempt to call account.updateRecovery. The method accepts 3 args (userId, secret, and password), but the endpoint is expecting a separate "passwordAgain" param.
Also, docs still show that the method accepts a 4th "paswordAgain" arg, but in v14.0.0 of sdk it does not support that argument.
👍 Expected behavior
I'm able to use the updateRecovery method to confirm password reset by passing 3 arguments - userId, secret, and password.
👎 Actual Behavior
I get an error saying that "passwordAgain" param is required, but updateRecovery method does not support it.
🎲 Appwrite version
Different version (specify in environment)
💻 Operating system
MacOS
🧱 Your Environment
Local environment, node 20.5.1, appwrite 14.0.0 configured with v1 endpoint
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Faced same issue, looks like there is a mismatch between actual implementation and the latest  package code. Had to downgrade the version to 13 for the time being where the updateRecovery  method actually supports the passwordAgain  argument and is working currently.

In case anyone else runs into this or a similar api/sdk mismatch - you can always just use the client instance to hit the rest api or shim the account method that's not working, ie:
account.updateRecovery = (
  userId: string,
  secret: string,
  password: string,
  passwordAgain: string,
): Promise<Models.Token> => {
  if (!userId || !secret || !password || !passwordAgain) {
    throw new Error('Missing argument');
  }
  const uri = new URL(client.config.endpoint + '/account/recovery');
  return await client.call('put', uri, {
    'content-type': 'application/json',
  }, { userId, secret, password, passwordAgain });
};

@clnmcgrw, you were probably using an SDK meant for Appwrite version 1.5 while Appwrite Cloud was on version 1.4. It's important to make sure you use a version of the SDK that is compatible with Appwrite. The readme will mention. For example:
Version 15.0.0 of the web SDK:
https://github.com/appwrite/sdk-for-web/blob/eab8856a36f1df682c832a66a63cb0e84c75befd/README.md?plain=1#L9
Version 13.0.2 of the web SDK
https://github.com/appwrite/sdk-for-web/blob/bf13f876b75ff590f4b0921770cf6fc027d4622a/README.md?plain=1#L9


Group search & refactoring

Serverside changes:

Extract the presenters in serverside SearchController into methods which are shared between instant and full searches
Fix sorting (by sorting on the pg_search_rank column in Rails)
Rank everything onto a common scale for all searchable items (0..1 via tsearch normalization mode 32 + 8 + 2)
Add a nasty raw-sql hack to rank user results and maintain email searching without exposing too much info about email

If we're willing to drop email search (does anyone actually use it?) we can just replace this with just a pg_search on name

Rename fuzzy_search_by_title and simple_search_by_title to instant_search and full_search, respectively
Modify the full_search algorithm to just include trigram in the rankings initially
Add searching for Groups
Updated all indices to match the new search queries

Super Sekrit Internal Unsupported API™ Changes:

Change type parameter to separate depth and scope parameters.

Maintain type=full since it's 3 lines of code and it keeps Tenpenchii and Deadman working for now.  I know we don't officially support third party apps using the internal API, but users blame us anyways if they break so I'd rather not.  Plus Tenpenchii is off Google Play right now so updating might be slower (idk how this stuff works tbh)

Clientside Changes

Switch to the modified search endpoints and results
Add groups to dropdown
Move some of the stuff from the autocomplete to use {{#link-to}}
Use transitionToRoute to get to the /search page if you hit enter in the search box
Replace var self = this with () => {} functions where it was easy.

The clientside changes should reduce reboots of the app (searching no longer requires it to reboot) and the search changes should greatly improve result relevance.
I did some rough benchmarks on the search methods too, in development:
Cold Cache: 40ms instant, 600ms full
Hot Cache: 1.1ms instant, 1.5ms full

I just want to note that the results in some cases are somewhat... wrong (I think it might be related to the 8 or 2 normalizations).  So I'd like a dump of the anime, manga, and groups tables (cc @vikhyat) if possible, to tweak the ranking algorithm against :dango:

We should have a client-side SearchResult model or something, currently logic for executing search is distributed all over our routes. It doesn't need to inherit from DS.Model, Ember.Object would also be fine if we don't need ember-data functionality.

I actually mentioned that in the devchat, that we should create some central object to handle the search coordination.  I was leaning towards a service object which would wrap the bloodhound crap and expose the API as simple as setting options for depth/scope and then passing strings in to get a response.
I also was thinking about better options for the serialization/deserialization stuff, like AMS etc. but didn't find any good leads that direction.
  Just calibrate the results on this and call it done.

Cool, let's put it on the todo list then.


Build and run engine on different gpus

Hi,
Is it possible to build an engine from one type gpu card, then load and run the engine from another type gpu card?
eg:
build from A100, load and run from H100.

Please refer this discussion https://github.com/NVIDIA/TensorRT-LLM/issues/222.


@Question

Hello,
I want know some things about telegram theming, how can I contact you
Through discord or telegram.
I would love to learn some things from you.

<EMAIL_ADDRESS>


Equirectangular image works in v1, not in v2

Hello,
I tried your script on an equirectangular image, it worked flawlessly on v1 but could not render image in v2. Is it normal? I tried the is_stereo parameter with no luck.
https://storage.googleapis.com/vrview/index.html?image=http://i.imgur.com/lOKJwUy.jpg
https://storage.googleapis.com/vrview/2.0/index.html?image=http://i.imgur.com/lOKJwUy.jpg
Image: http://i.imgur.com/lOKJwUy.jpg

this is a three.js issue which has been fixed here: https://github.com/mrdoob/three.js/commit/73a4ca56b51dcd9480bcbf62b22c904dcb6c8ffb
you are using mixed content (http image on https page) which works when the image is loaded with the imageloader (it's allowed passive mixed content then) but does not work without the fix, because it is loaded via xmlhttprequest in fileloader (it's blocked active mixed content then)
you can host your image on https to work around this. (you cannot use the imgur https image url though, as it redirects to the imgur html page)

Thanks for your precise answer.


sokol_gfx.h: missing validation check in for number of mipmaps when creating image

I've found out some difference with generating MIP maps in OpenGL and Direct3D backends of Sokol. In OpenGl backend all MIP maps to 1 pixel resolution are needed otherwise black texture is appeared. In Direct3D backend it works fine with any number of MIP maps. Is this trait of OpenGL or Sokol? May be doing some assert or warning about this trait in OpenGL backend is good idea....

Hmm, true, looks like this is a missing validation check in sokol-gfx. The intent is that you either provide no mipmaps (only the highest level surface), so sg_image_desc.num_mipmaps =1, or the full mipmap chain down to 1x1, with num_mipmaps = log2((w > h) ? w : h) + 1;.
I'll need to look around in the GL, D3D11 and Metal docs what's the behaviour when the user restricts access to mipmaps (via sg_image_desc.min_lod and max_lod), but this is not allowed in GLES2/WebGL anyway, so I think it's best to use the rule "either one mipmap, or all".
I'll rename the ticket and keep it open, and thanks for writing the bug report :)

This has been fixed in the meantime by dropping the GLES2 backend, and generally setting GL_TEXTURE_MAX_LEVEL when creating GL textures.


moved client.connect to top callers so that they can catch errors pro…

…perly

This change does not need to happen, we can keep the flag check in the mean time and remove when we are ready to fully move to next reader/sender


It strategy corrections

Two corrections:

Changed wording in the section "Program Statement"
Original wording made it sound like the problem is that we have too many applications in our portfolio. It wasn't the intent. The intent was to raise awareness on the increasing complexity technology (and departments) are facing.

Corrected display of numbered list under Short Term Outcomes

@remyb2canada
Would be a good opportunity to add a link to the PM PoC as guidance as well, if we have a link and info for that?

@remyb2canada
Would be a good opportunity to add a link to the PM PoC as guidance as well, if we have a link and info for that?

@jaysonmc that's for another document. Not that one.

woops. Got my document titles mixed up.


Provide new app details for new Details page (986)

Signed-off-by: Keith Chong<EMAIL_ADDRESS>What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Need this to provide the data for the resource section of the new Details page
Have you updated the necessary documentation?
Documentation is updated in a separate PR
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-986
How to test changes / Special notes to the reviewer:
Tested manually using 4.9 UI.  Also updated tests based on Shubham's change
(I originally had a test from this branch https://github.com/keithchong/gitops-backend/commit/461b9327c2874191bb00e1f9eada7979e41d01ac )

@shubhamagarwal19 @chetan-rns , can you please review this?
I tested the changes from 577 from the master branch.

Hi @wtam2018 , could you please review this?  Looks like Chetan is on vacation this week.

@shubhamagarwal19 . @wtam2018 , I've updated the PR based on the review feedback.  Changes only made to api.go, and have tested it. Note, the individual arrays have to be initialized. The UI is expecting an empty array and will show '0' for that resource.

/lgtm
/approve


Add locale support

Should fix issue #202 and may help with general playback for some.
The included locale list is fairly comprehensive; I do not know exactly which ones are or are not supported by NX.
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

All Submissions:

[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

[X] Have you successfully ran tests with your changes locally?

Nice. Maybe we could get rid of the big language map file & some other boilerplate using:
xbmc.convertLanguage?
Also, I´d like not to set this for the plugin especially. Haven't found it right away, but I think that there should be a way to get the preferred playback language set from within Kodi itself?! At least that would be the way I prefer. It also wouldn't break service asddons like this one

@asciidisco
I did not want to include the huge list but I found no other way. :-)
NX requires a language-country code like 'de-DE' (German-Germany). All of the Kodi stuff works with language only. I did include a check for Kodi's value but it must conform to NX requirements, and it does not, currently.

@GTechAlpha I have an idea, will sketch out something (most probably over the weekend) that we can discuss. It´s just a lot of code to spit out a 5 char string :D

@asciidisco

It´s just a lot of code to spit out a 5 char string

I agree. A simpler alternative would be better.  :-)

@GTechAlpha @asciidisco
if i understand it right you need a soltion to identify the system lang as "de-de" for example right ?
It is easy:
lang = xbmc.getLanguage(xbmc.ISO_639_1,True) - it will get country and region so we have the needed syntax :-)

@hawkeye Guve it a try with a few combinations, it’s broken (at least in my Kodi build) & does not return something useful.
But I do have another plan to realize this. I’m just to tired now to explain :D

tested on my win build and with my librelec in pi and both ggave me the result de-de ...

I´d propose something like this:
import xbmc

DEFAULT_ISO_LOCALE = 'en-gb'

@classmethod
def __check_locale(cls, locale=''):
    if locale is None:
        return False
    if len(locale) < 5:
        return False
    return True

def get_iso_language(self):
    # fetch user setting & validate
    user_locale = self.settings.get(key='iso_locale')
    if self.__check_locale(locale=user_locale) is True:
        return user_locale
    # fetch kodi setting & validate
    iso_locale = ''
    iso_locale = xbmc.getLanguage(
        format=xbmc.ISO_639_1,
        region=True)
    if self.__check_locale(iso_locale) is False:
        # try to get the default locale from the gettext file
        iso_locale = self.get_local_string(string_id=30063)
        if self.__check_locale(iso_locale) is False:
            # if gettext locale is false as well, default to constant
            iso_locale = DEFAULT_ISO_LOCALE
    # persist the current setting
    self.settings.set(key='iso_locale', value=iso_locale)
    return iso_locale

Where in the gettext file the entry would look like this:
msgctxt "#30062"
msgid "locale"
msgstr "en-gb"

The user gets a 5 char textfield in the settings where they can change the locale manually if needed & we have a proper fallback chain to determine it locally.
Thoughts?

qasciidisco looks good to me

in this way, do you get the region language?
ex: i have english as gui language but i live in italy and want it-IT.
if yes, it's good. if no, it's a first step 😃
(The pains of a worldwide plugin xD)

@pinoelefante With the proposed solution, you could just simply go to the plugin settings (as there would be a textfield) & enter "it-it" in it. If the string you entered is syntactically valid, it wouldn't be overridden by the system.

The differences, as I understand them:

The proposed change would require the user to recognize there is a problem, then figure out that this setting relates to the problem, then figure out what their locale code should be.

The PR prompts the user to select a locale on first run and provides a list of language-country combinations to select from. This at the expense of making the plugin slightly larger.

Additionally, this issue isn't just about the default language. I have experienced a complete inability (temporary) to watch videos as a result of the locale being wrong.

@GTechAlpha I agree with your points. Maybe we both looked at it from the wrong side of the table.
If thought, if anyone should now which locale is the valid one for the user, then it should be Netflix.
A super quick evaluation showed that, amongst the data the plugin is already parsing, you can find this:
"SOMECRYPTICUSERID":{"avatar":["avatars","nf","icon36"],"precacheConfig":[],"summary":{"size":214,"\x24size":214,"\x24type":"leaf","maturityLevel":"OLDER_KIDS","language":"de-DE","isKids":true,"canEditCharacter":true,"avatarName":"icon36","experience":"jfk","isActive":false,"isAccountOwner":false,"guid":"SOMECRYPTICUSERID","profileName":"Kids"}

Especially:
"language":"de-DE"

Which totally makes sense, cause you can set different locale preferences for each user profile.
Fetching that piece of data (and reusing it) could be implemented pretty quick/easily.
What´s your opinion?

@asciidisco Of course, lol! Why didn't I think of that before. Makes perfect sense. Right there on the profile page:
{"constants":{"sessionLength":[REMOVED],"ownerToken":[REMOVED],"locale":"en-US"
Great, no need for any of this!

@GTechAlpha :D
Collaborative coding FTW ;)
We might really need a place where we talk about implementations & things that need/should be done... ... ...any recommendations on how/where that could be done would be appreciated.
In regards to that @hawkeyexp sorry for not mailing you so far, had quite a stressful day, will write you when the little one is in bed.

@asciidisco no problem - you are right we need a place - my part ist most time small things but they must be done, too and some small are a big one, too :-)

Closing this since a better solution has been formulated.


Do not overwrite existing labels in cellpose_segmentation task

Close #307

Ah, nice approach!
Is there still a fix needed for many channels? Cellpose doesn't return more than one channel anyway, right? There is still a comment for # FIXME deal with: (1) many channels

Is there still a fix needed for many channels?

I don't think so.

Cellpose doesn't return more than one channel anyway, right?

That's correct. The current task takes a single input channel (identified via either wavelength_id or channel_label) and then has this logic
    # Find channel index
    try:
        channel = get_channel_from_image_zarr(
            image_zarr_path=zarrurl,
            wavelength_id=wavelength_id,
            label=channel_label,
        )
    except ChannelNotFoundError as e:
        logger.warning(
            "Channel not found, exit from the task.\n"
            f"Original error: {str(e)}"
        )
        return {}
    ind_channel = channel["index"]

    # Load ZYX data
    data_zyx = da.from_zarr(f"{zarrurl}{level}")[ind_channel]

    # ...

As for the channel name (which is the name of the label folder), this is obtained as in
    # Set channel label - FIXME: adapt to new channels structure
    if output_label_name is None:
        try:
            omero_label = zattrs["omero"]["channels"][ind_channel]["label"]
            output_label_name = f"label_{omero_label}"
        except (KeyError, IndexError):
            output_label_name = f"label_{ind_channel}"

I don't see anything obviously wrong, so I'll remove the FIXME (unless you do spot something weird, @jluethi)

I don't see anything obviously wrong, so I'll remove the FIXME (unless you do spot something weird, @jluethi)

I take it back. Since we already defined a channel object, that's where we should get the name from.

Fixed with https://github.com/fractal-analytics-platform/fractal-tasks-core/pull/308/commits/bd2ffbe631ed5f909b9f3f7ff13260a77abd0f78.
@jluethi, this is in principle ready to merge, but I'll wait for comments - just in case

The channel handling part looks good to me.

As for the channel name (which is the name of the label folder)

This part I don't understand. The output is a label image, which will be in a folder called output_label_name. If output_label_name is not set, we need to have some default handling, as you posted above and that looks reasonable to me. If that can already be gotten from the channel object, even better :)
Side-note: I will look into making cellpose work with dual-channel input. But that's unrelated to this PR and I'll create a new PR. Makes sense to base it on this code though, so I'll wait for this to be merged into main (don't need a release for that, will anyway test running it locally now)

@jluethi, this is in principle ready to merge, but I'll wait for comments - just in case

LGTM!

The "default" logic is indeed needed, but what was missing was "let's use the channel object, since we already have it" - and that's what the second FIXME was there for.

I'll wait for this to be merged into main (don't need a release for that, will anyway test running it locally now)

I'll merge right after the CI is complete.
Note, by the way, that you may want to stick with this main for a while (the one after this PR is merged), because right after this one I will merge #303 - and that one will be the beginning of some important changes (not there in #303 yet, but all related to #300).

Sounds good! Then let's actually make this a minor release, so we can refer to e.g. tasks 0.7.3 vs. the upcoming 0.8.x tasks :)

0.7.3 is now on pypi

Thank you @tcompa !


[Backport] remove ServerConfig from DruidNode as all information needs to be present in DruidNode serialized form

backports #4858

Took off Security bug because while it is a bug that has to do with the security channels, it isn't a bug that would cause insecure stuff


Throw when trying to edit a module export

In https://github.com/ModuleLoader/es6-module-loader/blob/master/src/loader.js#L760, we should be able to add a setter that just throws if trying to edit an export property.

I had raised the question Is it goal to have imports be immutable bindings? - Google Groups and in response this issue was opened.
Now I am having second thoughts about this.
The main concern is that this change might break a lot of existing testing/mock code.

@henrjk can you clarify why you think this would break testing code?

The kind of thing I had in mind is:
--- file: settings.js
export let server = "example.com/foo"
--- file: lib.js
import {server} from './settings'
<some code using server to be tested >
--- file: test-lib
test lib.js with a 'test-server'
<use some magic code which would patch the `server` binding inside lib.js or perhaps any imports to `server`. Something akin to proxyquire >

Now dynamic System.import provides a module object and perhaps one could patch bindings there. For static imports one presumably would have to somehow hook into the loader to support this kind of patching for unit testing.
Anyways I am a bit muddy on whether this is even an issue, but wanted to make sure there are no bad consequences.

Patching import {server} from 'server' is different to doing import * as Server from 'server'. It's only the latter case we can throw on for patches, the first case must be caught by static analysis in the transpilers themselves. Throwing in these cases at whatever levels are appropriate is important though to encourage specification compliance.

Fixed in https://github.com/ModuleLoader/es6-module-loader/commit/cf0d2fb561d26e305f4fda9f3cf64d46033c27f0. Object.freeze performance seems to be good these days from what I can tell, which was the reservation here initially.


Can't exit new SUI with Focus mode enabled

Environment
Win32NT 10.0.19042.0 Microsoft Windows NT 10.0.19042.0
Windows Terminal Dev from main at b50df20

Steps to reproduce

Build Windows Terminal Dev from main. Head was at b50df20 when I built. Notably this includes the new Settings UI (SUI), as well as #8882 and #8885.

Enable Focus mode on launch. I used "launchMode": "focus" in settings.json to do this.

Launch Windows Terminal Dev. My config loads an Ubuntu WSL2 session in Focus mode by default.

Open the new SUI with CTRL+SHIFT+S.

Expected behavior
There should be an easy way to exit SUI and return to your other pane(s).
Actual behavior
There's no way to exit SUI with the mouse. In Focus mode, the X to close the tab is hidden.
Most of the keybindings I tried to use here also don't work. Specifically, I tried these first in an attempt to exit SUI:
CTRL+SHIFT+P (for the switcher)
CTRL+SHIFT+W (close pane)
ALT+F4 (close window)
After a while, I figured out I could use CTRL+TAB to switch tabs. Then I can use CTRL+SHIFT+P to open the switcher, Toggle Focus Mode, and finally I can close SUI with the mouse.
After some discussion with @cinnamon_msft she suggested I file a bug here. See: https://twitter.com/33b5e5/status/1353929089137041408

This is fixed as of #8903

This is fixed as of #8903

/dup #8903 :smile:  thanks for filing!

/dup #8903 :smile:  thanks for filing!

@DHowett - ctrl+w should work as well. Quite sure I tested it.

@DHowett - ctrl+w should work as well. Quite sure I tested it.

For what it's worth, CTRL+W does not close the SUI for me (from b50df20). I will pull in the latest and try again.

For what it's worth, CTRL+W does not close the SUI for me (from b50df20). I will pull in the latest and try again.

@don-vito Ages upon ages ago (version 0.3), we changed the default bindings from ctrl+t->newTab and ctrl+w->closeTab to ctrl+shift+t->newTab and ctrl+shift+w->close*Pane*. Have you really been carrying around settings from 0.2? :smile:

@don-vito Ages upon ages ago (version 0.3), we changed the default bindings from ctrl+t->newTab and ctrl+w->closeTab to ctrl+shift+t->newTab and ctrl+shift+w->close*Pane*. Have you really been carrying around settings from 0.2? :smile:

@DHowett - hmm... I don't remember configuring this.. but I think I started using terminal around 0.4..

@DHowett - hmm... I don't remember configuring this.. but I think I started using terminal around 0.4..

Okay, after pulling in the latest, CTRL+SHIFT+W does work to close the SUI. CTRL+W does not work. I would love to see CTRL+SHIFT+P work here as well, because that would allow you to close the pane OR disable Focus mode (or switch panes, or whatever). Thanks for listening.

Okay, after pulling in the latest, CTRL+SHIFT+W does work to close the SUI. CTRL+W does not work. I would love to see CTRL+SHIFT+P work here as well, because that would allow you to close the pane OR disable Focus mode (or switch panes, or whatever). Thanks for listening.

@33b5e5 - yeah CTRL+W works only for me, because it is a binding to a closeTab which appears to be not bound by default.
Regarding Command Palette, I am worried what happens if the user clicks on action like "Find" which is not supported in the settings UI.

@33b5e5 - yeah CTRL+W works only for me, because it is a binding to a closeTab which appears to be not bound by default.
Regarding Command Palette, I am worried what happens if the user clicks on action like "Find" which is not supported in the settings UI.


Can't target older framework with new Net Core build system

On macOS, after upgrading to the latest Visual Studio and converting my project files to use the Microsoft.NET.Sdk project build system and targeting net45 Framework, I get this error from Ionide (also from using dotnet build but not from msbuild)
/usr/local/share/dotnet/sdk/2.2.0-preview1-007736/Microsoft.Common.CurrentVersion.targets(1124,5): error MSB3644: The reference assemblies for framework ".NETFramework,Version=v4.5" were not found. To resolve this, install the SDK or Targeting Pack for this framework version or retarget your application to a version of the framework for which you have the SDK or Targeting Pack installed. Note that assemblies will be resolved from the Global Assembly Cache (GAC) and will be used in place of reference assemblies. Therefore your assembly may not be correctly targeted for the framework you intend.

It's known dotnet CLI bug, the workaround is setting FrameworkPathOverride variable on the machine as described here - https://github.com/dotnet/netcorecli-fsc/wiki/.NET-Core-SDK-1.0.1#using-net-framework-as-targets-framework-the-osxunix-build-fails. After setting the variable remove obj dir and then run dotnet restore again.

@Krzysztof-Cieslak is FrameworkPathOverride worth exposing as a variable or setting for ionide?  And/Or should it be documented to put in your .bashrc or .bash_profile ?


keras: depend on tensorflow

Motivation for this change
The Keras library has now a tensorflow backend. This patch exposes tensorflow to Keras.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Is it necessary to add tensorflow here? Can't you, as a user, just create a Python env where you have keras and then add tensorflow to the env?

You're right, there is no need to have tensorflow as a static dependency. Thanks for pointing out my error!


If there are many sites, can I include conf files like nginx?

If there are many sites
For example, thousands of sites, all written in a config.yaml is too long and ugly
Can you include conf files like nginx?
That is, include files in a directory to make it easier to distinguish

sorry,  currently, the YAML does not include any kind of "import" or "include" statement.
and I think we can support the multiple yaml files. but I need time to think how to implement it.,

P.S. I need to evaluate these two solutions: 1) develop a YAML editor UI, 2) support the multiple YAML files
the first one would address the pains of YAML configuration much more than the second one, but the work efforts are much more.

P.S. I need to evaluate these two solutions: 1) develop a YAML editor UI, 2) support the multiple YAML files
the first one would address the pains of YAML configuration much more than the second one, but the work efforts are much more.

知名时序数据库VictoriaMetrics是采用后者，可以加载多个yaml文件
https://github.com/VictoriaMetrics/VictoriaMetrics/blob/master/docs/vmagent.md#loading-scrape-configs-from-multiple-files

P.S. I need to evaluate these two solutions: 1) develop a YAML editor UI, 2) support the multiple YAML files

the first one would address the pains of YAML configuration much more than the second one, but the work efforts are much more.

知名时序数据库VictoriaMetrics是采用后者，可以加载多个yaml文件
https://github.com/VictoriaMetrics/VictoriaMetrics/blob/master/docs/vmagent.md#loading-scrape-configs-from-multiple-files

Would you like to contribute this PR?

Sorry.My program skill is not good enough.

I can hava a try. Give me some time, Please.


Unable to build docker image with .docker files

Hi, I am trying to run e2e test cases from hive-driver and I am running into this issue. I am on MAC OS (not sure if that. affects docker)
ntalla$ make build
cd hive && docker build --build-arg USER_UID=$(id -u) --build-arg USER_GID=$(id -g) -t lenchv/hive:2.3.6 .
 When container is built it tries to create a user with the same group id and user id as the host system has.  It seems that container already has group as your host system.
groupadd: GID '20' already exists
I will fix it. But for now you can define another group id here:
USER_GID=$$(id -g)
https://github.com/lenchv/hive-driver/blob/master/.docker/Makefile#L4

You mean sth like this
cd hive && docker build --build-arg USER_UID=$$(id -u) --build-arg USER_GID=21 -t lenchv/hive:2.3.6 .

ohk, since I dont need ssl, I skipped the step "make generate_ssl", is that required step?

@ntallapa12 no, if you don't need ssl, it is not required to generate it.
When you build you just configure the image lenchv/hive:2.3.6. Then the command make up adjust hostname in docker-compose.yml.dist and starts services docker-compose up -d. It is strange that user "hive" not found, as it is added in the image.
You can try omit building image, remove or rename built image: docker image rm lenchv/hive:2.3.6
And then run make up TYPE=tcp.plain
In this case the image will be got from docker hub. The difference is that, in the image from docker hub the user hive has id 1000, which may be different from yours. The possible problem is that if you will share files between container and your host machine it will have different permissions. For instance, it won't have enough permissions to use hive-site.xml
Also, to troubleshoot you may run container and check what is wrong with user:
docker run --rm -it lenchv/hive:2.3.6 bash


Add Archived assessments / non-required assessments view to assessment actions page

This page data is split into two sections: Required & non-required(archived) assessments. Need to decide how to display this data & if we should really have 2 tables or if the archived / required field can just be added to the top table.

@justinxhale - Could we combine these two sections & add a field indicating if the assessment is required / archived or not?

I think the expectation is for this to be 2 seperate tables. Personally I think these being split is cleaner, but a user wont have tons of questionnaires, so having them in a single table and some type of indicator or text that tells the user its archived could be simple.
We could discuss this in the UI meeting.
Might have to confirm with @rromannissen here.


How to know the result of update

I wrote the code ,i want to know the result of update,but the 'results' is undefined, i want to know how many recorders has be updated....
  Repository.prototype.updatePassword = Foxx.createQuery({
    query: 'for user IN watchdog_account filter user.username == @username update user with {password: @password} in watchdog_account',
    params: ['username', 'password'],
    transform: function(results){
      var console = require("console");
      console.log(results);
    }
  });

Have a look here about the pseudo-variables OLD and NEW:
https://docs.arangodb.com/Aql/DataModification.html#using-old-and-new-in-the-same-query

@CoDEmanX Thank u very much. But when i update 10000 recorders....the results....so large

curerntly the statistics aren't available via the Foxx.createQuery(). however, db._query() has them:
var a = db._query("FOR u IN _users RETURN u")
a.getExtra()
{
  "stats" : {
    "writesExecuted" : 0,
    "writesIgnored" : 0,
    "scannedFull" : 110,
    "scannedIndex" : 0,
    "filtered" : 0
  },
  "warnings" : [ ]
}

Foxx.createQuery is too high-level. Just use db._query instead.


Build error: 'EnumDefinition' object has no attribute 'range'

Most recent build encounters this AttributeError at what looks like the conclusion of the merge step:
14:17:33  [KGX][cli_utils.py][               merge] INFO: Spawning process for 'phenio-merged'
14:17:33  [KGX][cli_utils.py][        parse_source] INFO: Processing source 'phenio-merged'
14:19:54  [KGX][cli_utils.py][               merge] INFO: Merged graph has 275527 nodes and 1638357 edges
14:20:12  [KGX][cli_utils.py][               merge] INFO: Writing merged graph to merged-kg-tsv
14:23:49  [KGX][cli_utils.py][               merge] INFO: Writing merged graph to merged-kg-nt
14:25:25  Traceback (most recent call last):
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/run.py", line 98, in <module>
14:25:25      cli()
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
14:25:25      return self.main(*args, **kwargs)
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/click/core.py", line 1055, in main
14:25:25      rv = self.invoke(ctx)
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
14:25:25      return _process_result(sub_ctx.command.invoke(sub_ctx))
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
14:25:25      return ctx.invoke(self.callback, **ctx.params)
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/click/core.py", line 760, in invoke
14:25:25      return __callback(*args, **kwargs)
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/run.py", line 93, in merge
14:25:25      load_and_merge(yaml, processes)
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/kg_phenio/merge_utils/merge_kg.py", line 35, in load_and_merge
14:25:25      merged_graph = merge(yaml_file, processes=processes)
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/cli/cli_utils.py", line 728, in merge
14:25:25      transformer.transform(input_args, output_args)
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/transformer.py", line 281, in transform
14:25:25      sink = self.get_sink(**output_args)
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/transformer.py", line 436, in get_sink
14:25:25      return s(self, **kwargs)
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/sink/rdf_sink.py", line 75, in __init__
14:25:25      self.property_types = get_biolink_property_types()
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/utils/kgx_utils.py", line 487, in get_biolink_property_types
14:25:25      property_type = get_type_for_property(p)
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/utils/kgx_utils.py", line 529, in get_type_for_property
14:25:25      t = get_type_for_property(r)
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/kgx/utils/kgx_utils.py", line 522, in get_type_for_property
14:25:25      r = e.range
14:25:25    File "/var/lib/jenkins/workspace/ledge-graph-hub_kg-phenio_master/gitrepo/venv/lib/python3.9/site-packages/jsonasobj2/_jsonobj.py", line 160, in __getattr__
14:25:25      return super().__getattribute__(item)
14:25:25  AttributeError: 'EnumDefinition' object has no attribute 'range'

Seems to be something related to Biolink types, but not sure why this isn't raised until writing to nt (through kgx's rdf sink).

Workaround here is to disable producing nt for now


[SPARK-1301][WebUI]Add UI elements to collapse "Aggregated Metrics by Executor" pane on stage page

Can one of the admins verify this patch?

Sorry. I am first time user and i dont know how to do pull request.
Please ignore/delete this request. its created by mistake.
On Fri, Mar 13, 2015 at 3:27 PM, UCB AMPLab<EMAIL_ADDRESS>wrote:

Can one of the admins verify this patch?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/5021#issuecomment-79485817.

--
Thanks & Regards,
Shanker

@shankervalipireddy just close this pull request, no problem. We can't close it for you.

I have just closed it. sorry for wasting your time. I am just trying to learn saprk and wanna become spark committer soon.

Hey,
I just signed the petition "Tik Tok: Ban Tik Tok" and wanted to see if you
could help by adding your name.
Our goal is to reach 1,500 signatures and we need more support. You can
read more and sign the petition here:
http://chng.it/sNQ8kHxTFz
Thanks!
Shanker


Google Login Page Clone

Hey! I am Tridib Bag, GSSOC'22 Contributor, wanted to add a clone of Google Login Page using HTML5, CSS3 as there is nothing regarding this.
Can @Rayman-Sodhi , @gurjeetsinghvirdee , kindly assign it to me?

Closing this coz we need website clone not a login clone and google clone alreadyaafed by me

Closing this coz we need website clone not a login clone and google clone alreadyaafed by me

Read important issue before mentioning me @Mrjoy832


Dcn retinanet

Can I use dcn in retinanet?I don not know how to use dcn in retinanet.

You you can have a try, which should be very simple. See the examples in configs.


Allow setting --docdir

This will allow setting --docdir during configure, this is useful because not all linux distributions install documentation to /usr/share/doc.  For example in Slackware documentation is installed to /usr/doc/$PRGNAM-$VERSION and /usr/share/doc is a symlink to /usr/doc.
To use this ./configure --docdir=/usr/doc/$PRGNAM-$VERSION can be used.
Here is the PR for the main rust repo. https://github.com/rust-lang/rust/pull/36360

Just to inform that currently "rust make install" isn't working due to
install: error: Option '--docdir=/usr/local/share/doc/rust' is not recognized
Not sure but I think that this PR is intended to handle the docdir option used in rust make install

I am under the impression for --docdir to work both this PR and the one that was already merged (Linked in the op) are needed, I haven't tested it with just the merged PR yet though.

Thanks for the PR.
As written, this is hard-coded to work with the rustc package produced by the rustc build, because it specifies "share/doc/rust". This is sufficient to work with make install for the main-repo because all of its docs are installed to "share/doc/rust", but it will not, e.g. work for the combined installer on the website, which additionally includes (I believe) cargo docs in "share/doc/cargo", nor would it work for make install from the cargo repo. There is generally no rust-specific behavior encoded in the install script, as in this patch.
A simple solution would be to omit the "/rust" directory when doing the rewriting here, with the consequence that changing --docdir will preserve the "rust" subdirectory. If that's not sufficient for your purposes then a suitable solution may require some more consideration.

The "/rust" directory was included in this as in Slackware it would be named "$PRGNAM-$VERSION" where $PRGNAM = rustc to make the source tarballs at the main rust site.
I think ideally a more complete solution will have to be found, but I am unfortunately not in that great of a position to test the combined installed on the website or the make install in the cargo repo.

Should be fixed.

Closing in favor of https://github.com/rust-lang/rust-installer/pull/54. Thanks <3

Thanks!


I've tried re-running init() and window.scrollTo, resetting window.scrollY.
Any advice greatly appreciated.

I've tried re-running init() and window.scrollTo, resetting window.scrollY.
Any advice greatly appreciated.

scrollama.destroy() and re-running scrollama.setup() should handle it


in release-safe mode, in functions that return an error, generate an error return instead of crash

When you create a release build of software, you don't want it to crash. Some people even argue in favor of not asserting in release builds, because they'd rather have the program in an undefined state than crash.
In release-fast mode, we don't do safety checks. Full optimization + undefined behavior. However you can override this default in a per block basis by using @setDebugSafety(this, true);. Then you'll have some release-safe parts of your code even in release-fast mode.
In release-safe mode, we do optimization but we turn on debug safety checks to prevent undefined behavior, such as integer overflow checking. We don't really know what else we could do when an integer overflow occurs besides crash the program.
...or do we?
In a function whose return value is error or %T, we could have that function return an error code, such as error.UndefinedBehavior. Assuming the programmer correctly uses the cleanup idioms, this error will be handled correctly, like the other possible errors in the function, even though the programmer never explicitly considered that this particular error was possible.
If this sounds like hidden control flow, I want to point out that we're talking about how to handle undefined behavior, and crashing the program is certainly also an example of hidden control flow.
When this situation happens, it's certainly a bug. But because the programmer (presumably) has a path to handle errors in these cases, it can be a bug that does not bring down the entire program or pose a security threat or instability to defined behavior of the program.
In the same way that you can override the default panic behavior by making pub fn panic(msg: []const u8) -> noreturn in the root source file, we can have another optional function such as pub fn warn(err: error) which defaults to printing a stack trace to stderr, but can be used to log these bugs. Obtaining a stack trace from the warn function would yield exactly the location that caused the problem.
Because Zig is so adamant about edge cases - for example insisting that memory allocation can fail - it is very common for functions to return a possible error. This makes the surface area that this covers fairly large.

If I start with a function that does not error, like:
    pub fn area(self: &Rect) -> i32 {
        self.width * self.height
    }

how do i take advantage of this feature to catch the overflow?
    pub fn area(self: &Rect) -> %i32 { // ERROR: function doesn't actually return an error
        self.width * self.height
    }

The second function actually is allowed. Consider if you have a list of function pointers with prototype fn (&Rect) -> %i32 and some of them return errors, you should still be able to have a function in the list that has this prototype and does not return an error.
But even considering the first function, sure, it's an example where this proposal wouldn't affect anything and we'd still have to crash inside area. Let's look at a real world example, std/debug.zig which is implementing reading DWARF info and printing a stack trace:
[nix-shell:~/dev/zig/build]$ grep '\bfn\b' ../std/debug.zig  | wc -l
40
[nix-shell:~/dev/zig/build]$ grep '\bfn\b' ../std/debug.zig | grep '\-> %' | wc -l
30

Here 75% of functions have an error return and would be covered by this feature.

This makes me think that people will develop "best practices" which is always make functions errorable, and call all functions with %return, even if there's apparently no error case. This turns zig's safety features into paranoia and boilerplate clutter.
This proposal is starting to approach the Java-style pokemon error handling, where an event loop just catches all exceptions from each event handler and continues running regardless of what's going wrong. Is that what we want with this proposal?
Stack-unwinding exception handling is optimized optimistically, but zig's if-driven error handling is not. If the "best" way to write zig code is to make everything errorable, zig would be better off with C++-style exceptions.

But we're not asking users to make everything an error union return value. We're just asking ourselves, what's the correct thing for zig to do when debug safety is violated in release mode?

what's the correct thing for zig to do when debug safety is violated in release mode?

Call the panic function. If users want to implement "continue and hope for the best" like Java pokemon programming, they can have their panic function longjmp back to a known state or something.
There's no generally correct solution to handling assertion failures in production. I'm not comfortable implementing or suggesting a language-level half solution. Any half solutions that go into production should be implemented and understood by the application maintainers.
I might have a different opinion if I had more experience in this domain; I'm still approaching this project as an idealist. I'd like to see more evidence of how this feature would be valuable.

I don't know how I feel about this - release-safe is still safe, and safety means we shouldn't continue running the program when it's in an undefined state. Calling a panic function which can be overriden seems like the most prudent idea.
If I switch on the error union and cover every possible error, without an else clause, where would my error.UndefinedBehaviour get handled? Would that be valid?

If people don't like it, I won't do it. It's certainly easier to keep things crashing, as status quo. But let's talk through it some more.

Also, from the Zen of Zig: Runtime crashes are better than bugs.

Damn. Tough to argue with this. (Not being sarcastic, I really love that you're bringing this up.)
In order for this proposal to be a good idea, I need to argue that it is not a bug to handle undefined behavior this way. I think this is related to your next question below:

If I switch on the error union and cover every possible error, without an else clause, where would my error.UndefinedBehaviour get handled? Would that be valid?

In this case, it would be handled the same way that every switch in ReleaseSafe mode which has no else clause is handled. There is a default else => unreachable. So the function would once again bubble up "unreachable code reached", or if the function is not error or %T, it would crash by calling the panic function.

Call the panic function. If users want to implement "continue and hope for the best" like Java pokemon programming, they can have their panic function longjmp back to a known state or something.

There's no generally correct solution to handling assertion failures in production. I'm not comfortable implementing or suggesting a language-level half solution. Any half solutions that go into production should be implemented and understood by the application maintainers.

This proposal is offering something a little bit more robust. The premise is that the user uses zig's idioms perfectly, and functions which have an %T signature use the %defer / defer features, so that any line of code that reads return error.Foo is guaranteed to clean up correctly.
Given these premises, and further given that we're deciding what to do when undefined behavior is invoked, it seems reasonable to me to take advantage of this already existing error handling mechanism for undefined behavior that we are catching.
Consider, if, when you type %T into a function's return value, you are taking on the responsibility that any code you might type into the function could return from the function with error.UndefinedBehavior. To me this does not add any complexity into the understanding of how the application will behave. We already need the calling function to correctly handle an error value; what extra difficulty does it add to have one more possible error code?
As a reminder, we're talking about what happens when there is a bug in the programmer's code that is invoking undefined behavior. The programmer has (accidentally or purposefully) agreed that however we handle the situation is valid according to the semantics defined by them.
And then finally, I'll say what I said earlier, again:
If people don't like it, I won't do it.

It just seems a little too ad hoc, since a lot of places where undefined behavior can happen will be in functions that do not return an error union. So the same code in different contexts will either crash the program or cause an error to be returned.
And this will force people to have to code in an "exception safe" way which they won't have to otherwise, because undefined behavior can hide where you don't expect it. defer should be a tool to make it easier to write correct code, but not required. It seems bad to throw out C philosophy that all control flow is visible, which has so far been kept in Zig.


test: fix a incorrect the usage of the assert function

Problem

first argument of assert function is  that is checked for being truthy and second argument is message.
In this test case, using assert.equal is correct.
Issue number, if available:
Changes

Corresponding docs PR, if applicable:
Validation

npm run test

Checklist

[x] If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
[x] If this PR requires a change to the Project Architecture README, I have included that update in this PR.
[x] If this PR requires a docs update, I have linked to that docs PR above.
[x] If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Amplifiyer Hi, I have created PR to fix a incorrect the usage of the assert function. I would be grateful if you could review it.

@sobolk
Hi, I would appreciate your review of this PR.


Automated cherry pick of #8183: vpcagent: ovn: increase dhcp lease, renew, rebind time

Cherry pick of #8183 on release/3.4.
#8183: vpcagent: ovn: increase dhcp lease, renew, rebind time

/lgtm
/approve


Skip await for loadMe if we have the currentUser

Summary
This PR allows the app to start faster by not waiting for loadMe to complete if we already have thecurrentUser.

Cool, this should speed up the app reopening


Added AWS s3 bucket cleanup option.

Added Option to cleanup S3 buckets from AWS cloud provider.
 [root@c69a5476fd64 cloudwash]# swach ec2 --s3

<<<<<<< Running the cleanup script in ACTION mode >>>>>>>
The EC2 providers settings are initialized and validated !
Removed following S3 buckets from ec2 cloud.
['aws-cloudtrail-logs-448555927204-391aa792', 'cf-templates-jz6rqjglgwhp-us-east-1', 'my-tf-test-bucket-paragkamble-12345', 'pakamble-ephemeral-cloudigrade-trails', 'paraggit-ephemeral-cloudigrade-trails', 'paragkamble-ephemeral-cloudigrade-inspections', 'paragkamble-ephemeral-cloudigrade-trails'] ```

@paraggit Is it ready for review ?

Ping @paraggit !

@paraggit Hey! I see you closed the MR, is that accedntal ? Or you simply want to create a new PR ?


Exec tachikoma update<PHONE_NUMBER>1928

:hamster::hamster::hamster:   Strategy none
Powered by Interval Pull Request as a Service - Tachikoma.io Announcement: 2015-06-28 Updated permissions - Tachikoma.io

Coverage decreased (-0.009%) to 99.695% when pulling 501f1d7f35804b98031a9f9e1dbda1e39e91bcf7 on pazjacket:tachikoma/update-20160623151928 into 77a776d257a2436999eb722afb99b372b7aa9f95 on hoshinotsuyoshi:master.


Implement sample_n and sample_frac using tablesample

Implement sample_n and sample_frac using tablesample

Merging this change request from @edgararuiz, his perf results for future reference:

I’ve ran a test with a data set that has 11M records. Here are the results:

n
function_test
seconds
rows
columns

1
cran_sample_n
19.872
1100
20

2
cran_sample_frac
17.394
1113
20

3
cran_sdf_sample
1.262
1098
19

4
branch_sample_n
0.172
1100
19

5
branch_sample_frac
1.180
1143
19

So, it looks like N sampling is about 20X faster, and Frac about 15X faster than the CRAN version.


Add new CONTAINER_VNET value to config.hosts

Re: https://ukgovernmentdfe.slack.com/archives/C03AANC6UJF/p1677253180105049
We added a new /healthcheck endpoint for monitoring.
Unfortunately when implementing the monitoring, techops encountered an error because the health probes' IP address is not in the app's allowed hosts:
ERROR -- : [ActionDispatch::HostAuthorization::DefaultResponseApp] Blocked host: <IP_ADDRESS>

As a solution, techops are going to add a new environment variable to terraform called CONTAINER_VNET. This will be an IP range.
https://guides.rubyonrails.org/configuring.html#actiondispatch-hostauthorization
We can add this to the allowed hosts in the application via IPAddr.new(ENV["CONTAINER_VNET"])

 Allow IP address ranges to be added to the allowed hosts list.


Example python create case with observables

Would it be possible to expand this example:
https://github.com/TheHive-Project/TheHive4py/blob/master/samples/test-case-create.py
to also include adding observables of different types?
Is there a way to trigger the analayzers also after having added them via python?
Request Type
Feature Request

Ops sorry found it here:
https://github.com/TheHive-Project/TheHive4py/blob/master/samples/test-case-observable.py
Closing.


kitty: 0.27.0 -> 0.27.1

Description of changes
https://sw.kovidgoyal.net/kitty/changelog/
Also bumped go version per upstream:

Bump the version of Go needed to build kitty to 1.20 so we can use the Go stdlib ecdh package for crypto.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 215129 run on aarch64-darwin 1

1 package built:

kitty


Update README to use markdown and add badges

Changes Unknown when pulling 238677c851919d62b66a6dc772af6f20e64a0c77 on gem-badge into ** on master**.


Fixes build errors on gcc < 5.2 and mcst compilers

How much older than GCC 5.2 are you trying to make this work for? You can add the following lines to .drone.jsonnnet to cover the GCC 4.X versions:
linux_pipeline(
        "Linux 14.04 GCC 4.8* 32/64",
        "cppalliance/droneubuntu1404:1",
        { TOOLSET: 'gcc', COMPILER: 'g++', CXXSTD: '03,11', ADDRMD: '32,64' },
    ),

    linux_pipeline(
        "Linux 14.04 GCC 4.9 32/64",
        "cppalliance/droneubuntu1404:1",
        { TOOLSET: 'gcc', COMPILER: 'g++-4.9', CXXSTD: '03,11', ADDRMD: '32,64' },
        "g++-4.9-multilib",
        [ "ppa:ubuntu-toolchain-r/test" ],
    ),

For historical context support for GCC 4.X were dropped specifically for this issue.

That's not going to work because b2 no longer supports building under 14.04. It should be something like
linux_pipeline(
        "Linux 16.04 GCC 4.8 32/64",
        "cppalliance/droneubuntu1604:1",
        { TOOLSET: 'gcc', COMPILER: 'g++-4.8', CXXSTD: '03,11', ADDRMD: '32,64' },
        "g++-4.8-multilib",
    ),

    linux_pipeline(
        "Linux 16.04 GCC 4.9 32/64",
        "cppalliance/droneubuntu1604:1",
        { TOOLSET: 'gcc', COMPILER: 'g++-4.9', CXXSTD: '03,11', ADDRMD: '32,64' },
        "g++-4.9-multilib",
    ),

cross build for armv7-linux-gcc 4.8.2

the error is due to the warning that dragonbox.cpp does not create obj files because it should not create anything for msvc, in 4.9/4.8 the problem is with the conversion warning, I don't know how relevant they are at all

Since you seem to be having similar build problems as I did I am going to close this. Frankly I am not interested in adding the maintenance burden of GCC 4.X to the library, and I do not want you to waste your time.

let me finalize my theories, because it is not realistic for me to deploy all tests locally, I just want to achieve that all tests pass successfully, and the further decision to include or not is not very important to me.


Red updated bios??

OK good start--- clean up the files-- do a git rm on any files that are not supposed to be there, and put the final bio into the bios directory.

So I see you've started work on the hubble project; however, you're doing this work on the same branch that you used for the bios!  This pull request should be only the bio.  I didn't emphasize branching today, but perhaps I should have.
To correct this situation, you can break out the hubble work into a new branch, then reset master (which you used for this pull request) to a previous commit, before the hubble work.  In other words:
git checkout -b hubble
git checkout master
git reset --hard <commit hash before hubble work>
git push

This should preserve the contents of the hubble work in the hubble branch but get rid of them on master for the purposes of the pull request.  (Sam, I think this may be the answer to what you were asking me earlier today.)

Or instead of the git reset --hard .... command you could also just manually delete the hubble files under master after creating the branch.... that might be more straightforward.

ok looks good now, except looks like you still have an 'ihategit.md' file that i'd rather not merge in :-)


Sparkle Auto Updater has a vulnerability

The current implementation of Sparkle has a vulnerability that got flagged by my company's scanning software. It's now blocked and I can't use or promote ControlPlane within the company. Can we update Sparkle to the latest version?

https://sparkle-project.org/documentation/security/

You can download the latest version at http://controlplaneapp.com/download/1.6.4 which has the updated Sparkle client.

perfect. thank you!


Makefile: fix installheaders

Describe your PR, what does it fix/add?
Attempts to fix the recent breakage of make installheaders, which breaks
hyprpm.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Untested. Please test.
Is it ready for merging, or does it need work?
Needs testing.
Closes #5896.

tested but does not seem to fix it for me!
hyprpm output on 6ae4278 : hyprpm_5929.txt
(for comparison: hyprpm output on latest commit 70b5e6d : hyprpm_latest.txt)

@fufexan The issue is not fixed for me as well, on arch:
Build targets in project: 136

wlroots 0.18.0-dev

    drm-backend     : YES
    x11-backend     : YES
    libinput-backend: YES
    xwayland        : YES
    gles2-renderer  : YES
    vulkan-renderer : NO
    gbm-allocator   : YES
    session         : YES
    xcb-errors      : YES
    egl             : YES
    libliftoff      : YES

  User defined options
    examples        : false
    renderers       : gles2

Found ninja-1.12.0 at /usr/bin/ninja

✔ configured Hyprland
[v] installation will run: sed -i -e "s#PREFIX = /usr/local#PREFIX = /home/thamw/.local/share/hyprpm/headersRoot#" /tmp/hyprpm/hyprland-thamw/Makefile && cd /tmp/hyprpm/hyprland-thamw && make installheaders
 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╍━━━━━━━━━  4 / 5  Installing sources[v] installer returned: rm -fr /home/thamw/.local/share/hyprpm/headersRoot/include/hyprland
mkdir -p /home/thamw/.local/share/hyprpm/headersRoot/include/hyprland
mkdir -p /home/thamw/.local/share/hyprpm/headersRoot/include/hyprland/protocols
mkdir -p /home/thamw/.local/share/hyprpm/headersRoot/include/hyprland/wlroots-hyprland
mkdir -p /home/thamw/.local/share/hyprpm/headersRoot/share/pkgconfig
find src -name '*.h*' -print0 | cpio --quiet -0dump /home/thamw/.local/share/hyprpm/headersRoot/include/hyprland
cd subprojects/wlroots-hyprland/include && find . -name '*.h*' -print0 | cpio --quiet -0dump /home/thamw/.local/share/hyprpm/headersRoot/include/hyprland/wlroots-hyprland && cd ../../..
cd subprojects/wlroots-hyprland/build/include && find . -name '*.h*' -print0 | cpio --quiet -0dump /home/thamw/.local/share/hyprpm/headersRoot/include/hyprland/wlroots-hyprland && cd ../../../..
cp ./protocols/*.h /home/thamw/.local/share/hyprpm/headersRoot/include/hyprland/protocols
cp ./protocols/*.hpp /home/thamw/.local/share/hyprpm/headersRoot/include/hyprland/protocols
cp ./build/hyprland.pc /home/thamw/.local/share/hyprpm/headersRoot/share/pkgconfig
if [ -d /usr/share/pkgconfig ]; then cp ./build/hyprland.pc /usr/share/pkgconfig 2>/dev/null || true; fi
chmod -R 755 /home/thamw/.local/share/hyprpm/headersRoot/include/hyprland
chmod 755 /home/thamw/.local/share/hyprpm/headersRoot/share/pkgconfig

✖ failed to install headers with error code 2
 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━  5 / 5  Failed

Let me know if you need more details on debugging this.

#5946


memset() works too slow

Originally reported on Google Code with ID 19
What steps will reproduce the problem?
1. Run many times calloc and malloc (1024000 times)
Calloc() works more slower than malloc().
I think that memset() that used inside calloc() works too slow.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
google-perftools-0.91 compiled from sources with
gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-51)
Linux 2.6.20-1.2319.fc5 i686 i686 i386 GNU/Linux

Please provide any additional information below.

Reported by egor.abramov on 2007-06-18 15:50:36

Ten times slower than ptmalloc's calloc

Wasn't aware of this ticket. Here is what I can tell you. What likely happens is that benchmark is ~bogus. That is, in this specific benchmark case, ptmalloc likely has optimization that "memory" freshly gotten from kernel is (correctly) assumed to be zeroed. But that calloc hits this case is in fact rare. Other than micro-benchmarks. it will only occur early during program startup and then ~all subsequent callocs will be returning "reused" memory which must be memset. And then libc's calloc will call memset same as us with same slowdown. I think jemalloc has (or used to have) similar optimization. IMHO it is not useful/not worth complexity.

Thanks for your reply.
In fact, I have benchmarked jemalloc as well with the same program. This benchmark has warm up simulation. That is requesting 1MB,  10MB, 100MB, 1GB, 10GB from the allocator and free them first. After that, benchmark records time used by calloc, malloc, posix_memalign requesting 1MB, 10MB, etc.  using ptmalloc, jemalloc and tcmalloc. Overall, tcmalloc has the best performance except calloc. jemalloc and ptmalloc have similar calloc performance and both are orders of magnitude faster than tcmalloc

If you just allocate and free using calloc and allocator has this specific optimization, then this is not "real" too. Because virtual memory pages behind this large area are not populated. If you touch this memory (say force-read every page), you will get more real outcomes.
But also do note that tcmalloc (and most others allocators) don't really work hard optimizing large allocations. Because they are relatively rare. It does matter to squeeze every cycle for common-ish 32 byte allocations as some programs allocate those hundreds of millions of times per second, but those 1+ meg allocations they can take microseconds or even more and it'll be fine.

Thanks a million. I touched every byte in the calloc 1MB address space. tcmalloc is just a little slower than ptmalloc. But they are on the same order of magnitude now.


docs-fr | setup | independent section

/hold
as discussed on slack, i take this whole section for translate work.

please wait before Review as it is WIP, i need to finish all the bundle (folder) of files, then i we re-read/review on my own, then i drop the WIP, dont waste your precious time now folks 😎

bon courage aux reviewers :)

@perriea it's all done, you can continue your review now :)

Also we need to define if we say "la kubelet" or just "kubelet" and so reflect this change in each sentences

I changed all "kubelet" to "la kubelet", when applicable.

/hold cancel
reviews done, thanks team !

/lgtm

/approve


Add ability to run performance regression checks on Beam IO Load tests.

This PR adds ability to run regression checks against Beam IO load tests.
Below is the command to run this,
python3 apache_beam/testing/analyzers/load_test_perf_analysis.py --config_file_path=apache_beam/testing/analyzers/io_tests_config.yaml

We can automate runs for these regression checks by adding a GH workflow in a separate PR.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @AnandInguva, @Abacn

Not a big deal, but in general we should wait for all checks to pass before merging


update stellar-relay pallet to do stellar stuff instead of bitcoin

Needs more info.
See https://www.notion.so/satoshipay/Stellar-Oracle-af0b2f95d013487e86670ba6207964ae

Superseded by #88.


the trait From<bytes::Bytes> is not implemented for Vec<u8>

Hi! Something went wrong...
clickhouse = "~0.9.1" compilled.
but 11.4, 11.5 are not.
  Compiling clickhouse v0.11.5
error[E0277]: the trait bound `Vec<u8>: From<bytes::Bytes>` is not satisfied
  --> /home/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clickhouse-0.11.5/src/response.rs:92:42
   |
92 |     let reason = String::from_utf8(bytes.into())
   |                                          ^^^^ the trait `From<bytes::Bytes>` is not implemented for `Vec<u8>`
   |
   = help: the following other types implement trait `From<T>`:
             <Vec<u8> as From<&str>>
             <Vec<u8> as From<CString>>
             <Vec<u8> as From<std::string::String>>
   = note: required for `bytes::Bytes` to implement `Into<Vec<u8>>`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `clickhouse` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...

Process finished with exit code 101

cargo -V :   1.70, 1.71

It disappeared, I don't know why.


cmake.ctestArgs command expansion

I am trying to set up my environment to make extensive use of the build target name for convenience.  In particular, I have the launch.json configured to launch the current build target using
"program": "some-stuff-here/${command:cmake.buildTargetName}"

This works perfectly.
However, when I try to set up the CTest runner to use the same trick to only run tests associated with the current build target, it does not work.  In particular when I try to use the following configuration in settings.json to try and set up the label:
    "cmake.ctestArgs": ["-L", "${command:cmake.buildTargetName}"],

I get the following output:

[proc] Executing command: ctest -j7 -C Debug -T test --output-on-failure -L ${command:cmake.buildTargetName}

which is clearly not what I was aiming to get.
Am I doing something wrong or are command expansions not supported in this context and thus require some changes in the plugin?
Thanks!

Sorry, the expansion isn't supported in this context yet.  The change shouldn't be difficult, it's just a matter of routing the information to the location where it's used in ctest.ts

I'm not familiar with VSCode extension development, but if you point me to where similar expansion is done (and where it's tested if you have unit tests for that), I can try fixing it and making a PR.


Refactor reusable parts of ReadStreamer into utils-java

. . . so that Spark can use it too.
https://github.com/googlegenomics/dataflow-java/blob/master/src/main/java/com/google/cloud/genomics/dataflow/readers/ReadsStreamer.java
Also implement sharding and shard shuffling code similar to what we will have after https://github.com/googlegenomics/utils-java/issues/34 but suitable for reads.
Note that Spark does not have support for custom sources like Dataflow so fixed shards are still needed.

This was fixed with https://github.com/googlegenomics/utils-java/pull/55


Maven import

Hi I followed the guide and I tryed to import the repo in my java project but I can't find com.contentfull.rich classes when I try to import them in my java class

Hello,
In your path I can see a doubled l in contentful. Was this a typo here or in your configuration. If nothing helps, can you share more details, as in error messages, code you tried, etc.
Greetings,
Mario

Yes sorry just a typo error. In my pom.xml file I added
    <repositories>
        <repository>
            <id>jitpack.io</id>
            <url>https://jitpack.io</url>
        </repository>
    </repositories>

    <dependency>
        <groupId>com.github.contentful</groupId>
        <artifactId>rich-text-renderer.java</artifactId>
        <version>master-25d243508f-1</version>
    </dependency>
    <dependency>
        <groupId>com.github.contentful</groupId>
        <artifactId>contentful.java</artifactId>
        <version>v10.3.1</version>
    </dependency>

but then I can't import HtmlContext and HtmlProcessor classes like if I don't import the repo in my project.

Hey,
I just published an update on the versions, essentially a jcenter() was missing...

I can't still import in my project the repository

Any updates on this? I am also not able to do an import...


Update dtk-template & fix building all source files

This updates to the latest dtk-template changes. Namely:

CLI progress output now shows matched code % across all source files, including unlinked.
A report.json is generated in CI that can be used for https://decomp.dev
Adds vscode config to enable dtk-template's new clangd integration, a better alternative to IntelliSense.

Progress:
  All: 21.81% matched, 19.44% linked (324 / 807 files)
    Code: 703004 / 3223116 bytes (3791 / 15430 functions)
    Data: 166489 / 931828 bytes (17.87%)

Since the new progress reporting requires all source files to build, regardless of their matching status, I fixed all the errors that popped up. I also cleaned up various warnings that appeared with clangd. These changes are in the second commit, so it's easier to review.

Thanks a lot for your work!


test: count number of gates in ultra recursive verifier

Results after running the test with UltraVerifier and UltraCircuitBuilder
Recursive Verifier Ultra: num gates = 556759
Recursive Verifier Ultra: num gates after finalization = 762491

Please read contributing guidelines and remove this line.

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
740
740
740

l1_rollup_calldata_gas
6,692
6,680
6,668

l1_rollup_execution_gas
586,824
586,812
586,800

l2_block_processing_time_in_ms
1,624 (+7%)
5,467 (-1%)
10,348 (-1%)

l2_block_building_time_in_ms
22,252 (-1%)
87,846 (-1%)
175,724 (-2%)

l2_block_rollup_simulation_time_in_ms
22,048 (-1%)
87,112 (-1%)
174,288 (-1%)

l2_block_public_tx_process_time_in_ms
8,767 (-2%)
34,256 (-2%)
68,948 (-2%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
16,375 (-9%)
31,261 (-3%)

node_database_size_in_bytes
20,766,800
37,339,216

pxe_database_size_in_bytes
29,868
59,425

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
174 (-1%)
46,819
28,822

private-kernel-inner
204 (-1%)
76,734
28,822

private-kernel-ordering
227 (-1%)
53,040
42,751

base-parity
66.7
128
64.0

base-rollup
16,191 (-2%)
111,062
925

root-parity
1,607
27,064
64.0

root-rollup
64.4 (-1%)
11,454
789

public-kernel-app-logic
1,962 (-1%)
54,321
22,677

public-kernel-tail
4,801 (-2%)
159,770
3,898

merge-rollup
6,455 (-1%)
2,696
925

public-kernel-teardown
160 (-2%)
54,321
30,042

public-kernel-setup
220 (-2%)
54,321
30,042

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
44,613
535,433

Transaction size based on fee payment method

Metric
native fee payment method
fpc_public fee payment method
fpc_private fee payment method

tx_with_fee_size_in_bytes
897
1,145
1,345

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
1,390 (-1%)
1,000 (-1%)
3,645 (-2%)

Metric
1 public data writes
2 public data writes
3 public data writes
4 public data writes
5 public data writes
8 public data writes

tx_sequencer_processing_time_ms
875 (-1%)
785 (-2%)
1,410 (-2%)
927 (-2%)
2,179 (-2%)
1,107 (-2%)


Unifying the Request Signing Strategy

In https://github.com/opensearch-project/opensearch-spark/pull/303, we introduced a separate signing strategy for accessing metadata. Moving forward, we may consider implementing a more flexible approach. For instance, while SigV4a could serve as the default, users might have the option to specify either a role-based or policy-based signing strategy via Spark submit parameters.

Catch All Triage - 1 2 3 4 5 6


No module named model_selection error in python 2.7

While splitting the training and testing dataset to two output files. Encountering a import error.
DVC $ dvc run python code/split_train_test.py data/Posts.tsv 0.33 20170426 data/Posts-train.tsv data/Posts-test.tsv
Git command error (python code/split_train_test.py data/Posts.tsv 0.33 20170426 data/Posts-train.tsv data/Posts-test.tsv):
Traceback (most recent call last):
  File "code/split_train_test.py", line 2, in <module>
    from sklearn.model_selection import train_test_split
ImportError: No module named model_selection

Further research indicated this is due to older scikit versions calling this  module "train_test_split" now been renamed to model_selection.
pip install -U scikit-learn
solved the issue.
Suggest instructions can be added to the README if deemed useful? Thanks.

@vishwanath79 thank you! Good catch.
I'm adding the updating option to pip install -U -r code/requirements.txt. It fixes the issue. The same change in the tutorial: https://blog.dataversioncontrol.com/data-version-control-beta-release-iterative-machine-learning-a7faf7c8be67

Thank you @dmpetrov

This module was deprecated in version 0.18 in favor of the model_selection module into which all the refactored classes and functions are moved. Also note that the interface of the new CV iterators are different from that of this module. This module will be removed in 0.20.
"This module will be removed in 0.20.", DeprecationWarning)
And for requirements I keep getting;
Could not open requirements file: [Errno 2] No such file or directory: 'code/requirements.txt'

@Rootmannii hi, could you share the exact commands you are running? And the link to the tutorial you try to reproduce, please. Thank you!


fix(alzlibtool): sort defaults

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.82%. Comparing base (263c3bf) to head (6021c88).

Files with missing lines
Patch %
Lines

internal/doc/doc.go
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   51.84%   51.82%   -0.03%
==========================================
  Files          37       37
  Lines        1973     1974       +1
==========================================
  Hits         1023     1023
- Misses        795      796       +1
  Partials      155      155

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.