Introduce PSA test driver library to test PSA configuration

Description
The main purpose of this PR is to remove from the library (psa_crypto_*.c files) all the test code introduced for testing the PSA
configuration. This clean-up was highly desired for the 2.x LTS branch. This PR removes the aforementioned test code by replacing it by calls to a PSA test driver library.
PR #3959 has proven that by adding a prefix (LIBTESTDRIVER1/libtestdriver1_ in this commit) to all MBEDTLS/PSA_* and medtls/psa_* symbols of a copy of the Mbed TLS library, we can build a library that can be linked with the Mbed TLS library.
This commit leverages this to build a PSA test driver library based on the Mbed TLS library code. Its purpose is to test the PSA
configuration where cryptographic operations are disabled in the library and provided by a test driver library.
The cryptographic features supported by the test library are defined by:
. a minimal configuration (in the sense of config.h), see config_test_driver.h
. PSA_WANT_* and PSA_ACCEL_* defined macros.
The PSA_WANT_* macros have to be the same as the ones used to build the Mbed TLS library the test driver library is supposed to be linked to as the PSA_WANT_* macros are used in the definition of structures and macros that are shared by the PSA crypto core, Mbed TLS drivers and the driver test library.
The PSA_ACCEL_* macros are intended to define the cryptographic features that have to be removed from the Mbed TLS library and thus supported by the test library in test scenarios. The PSA_ACCEL_* macros to build the test library are thus mirrored from the ones to build the Mbed TLS library by extended the crypto_config.h: see crypto_config_test_driver_entension.h.
Fixes #3680.
Status
IN DEVELOPMENT
Requires Backporting
Yes, forward porting to development

@ronald-cron-arm does this still need work or did you just forget to remove the label after pushing?

@ronald-cron-arm does this still need work or did you just forget to remove the label after pushing?

I think the only genuine CI failure is the PSA compliance where a NOT_SUPPORTED error code is expected and we return INVALID_PARAMETER. Thus I still need to do something about that, leaning towards fixing the compliance test suite for the time being. But I do not think this should prevent the reviews to carry on and I believe I have addressed all comments from @mprse.

I rebased on top of development_2.x to fix a conflict in psa_crypto.c introduced by the merge of #5231.

I changed the "psa: Add algorithm validity check" commit to the "psa: asymmetric_encrypt/decrypt: Improve error code consistency" one to fix the PSA compliance test issue we were getting before.

I am merging this pull request ahead of its 3.0 forward-port so that it's available for follow-up tasks such as #5249 and #5251, and so that there's no risk that it slips until after the 2.28 LTS.


livereload does not work with cordova-android 7

Short description of the problem:
The livereload plugin fails to serve cordova.js file and serves // mock cordova file during development even while running the app on a device. The dev-server fails silently with ENOENT error here.
[13:12:20]ENT: no such file or directory, stat 'C:\Users\Harshith Kashyap\dev\ionic-app\platforms\android\assets\www\cordova.js'

This is happening because cordova-android@7 was updated to Android Studio based project structure and  assets/ directory is no longer available in platforms/android/
What behavior are you expecting?
ANDROID_PLATFORM_PATH here is hard coded here to platforms/android/assets/www directory. It should be updated to  platforms/android/app/src/main/assets/www for cordova-android 7 projects.
Steps to reproduce:

Clone https://github.com/harshithkashyap/ionic-app/
npm install
ionic cordova platform add android
ionic cordova run android -lc --device
Once the app is opened on the device, the following message should be seen in the terminal.

console.warn: Native: tried calling StatusBar.styleDefault, but Cordova is not available. Make sure to
            include cordova.js or run in a device/simulator

Which @ionic/app-scripts version are you using?
ionic info
    @ionic/cli-utils  : 1.19.0
    ionic (Ionic CLI) : 3.19.0

global packages:

    cordova (Cordova CLI) : 8.0.0

local packages:

    @ionic/app-scripts : 3.1.7
    Cordova Platforms  : android 7.0.0
    Ionic Framework    : ionic-angular 3.9.2

System:

    Android SDK Tools : 26.1.1
    Node              : v8.9.3
    npm               : 5.6.0
    OS                : Windows 10

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
Platforms directory structure for cordova android 6 and 7.
cordova-android 6:

cordova-android 7:
Notice there is no platforms/android/assets directory. Its moved to platforms/android/app/src/main/assets

I made a Cordova hook that you can add to your config.xml.  If you don't know what Cordova Hooks are, you can find more information at https://cordova.apache.org/docs/en/latest/guide/appdev/hooks/.  I recommend adding it like this
<hook src="scripts/fixcordova7issue.js" type="before_prepare" />
The code for the webhook is in this gist: https://gist.github.com/SteveKennedy/a9964b291afa51f820b5d73b687eeb34

The answer below solved the livereload problem and I was able to run the apk on the device:
i changed the last line in these file<EMAIL_ADDRESS>from
exports.ANDROID_PLATFORM_PATH = path.join('platforms', 'android', 'assets', 'www');
to
exports.ANDROID_PLATFORM_PATH = path.join('platforms', 'android', 'app/src/main', 'assets', 'www');
BUT.. there's always a but , when the program starts, is fetches some data using http and I am getting a CORS problem now which I don't have when I run without livereload
Failed to load http://XXX.XXX.XXX.XXX/api.php/TESTAPI: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://<IP_ADDRESS>:8100' is therefore not allowed access.
If I do not use livereload , everything works fine! I am guessing that, without livereload, the http request is made by the device and the http headers are properly configured for that, BUT, with livereload, every http request is done using my wifi router and somehow the pre-configured header inside the code Access-Control-Allow-Origin : * is somehow lost.
Any ideas?

have the same problem with http...

I upgraded Ionic. It looks like they added both paths:

yes, new version has fixed this problem.
As for livereload CORS, sometimes ionic uses a different port, so make sure you are allowing both port in your server.

I get this issue in an ionic v1 project. My ionic (-g) version is 3.20.0

same issue here... live reload doesnt work.

Excuse me folks but this issue is opened since 2017 and there is not an ufficial fix on this? This problem appears also with Ionic AppFlow live reload


remove controller

This PR removes the controller and instructs users to expose the JSON Schema via static resources.

Maybe we want to supply to correct media type. But perhaps we also want it to be application/schema+json.
It is indeed better to remove the controllers, so I will merge and we can think of this later.

Maybe we want to supply to correct media type. But perhaps we also want it to be application/schema+json.
It is indeed better to remove the controllers, so I will merge and we can think of this later.

Yes, I will add a PR to Core to support the application/schema+json media type.


Fix Plugin Template Order

1. Why is this change necessary?
If a plugin B provides a new storefront template file which is included via a bundle name that is not its own(*) (e.g. CMS elements, which are always included with @Storefront), and another plugin E tries to extend it, E's template is not loaded unless it is installed before B (which cannot happen if E declares B as one of its composer.json requirements).
(* This is necessary because the template loader always loads from the provided bundle's template files last.)
2. What does this change do, exactly?
It corrects the order in which plugin template files are loaded. Without the Storefront ThemeInheritanceBuilder, plugin templates are loaded in reverse order of installation (so the last installed plugin's templates are loaded first). The ThemeInheritanceBuilder flips this order, seemingly by accident.
3. Describe each step to reproduce the issue or behaviour.

Create and install a plugin B that defines a new CMS element (or provides any other new template file that is included via the @Storefront bundle)
Create and install a plugin E that extends the template from B.
Observe how E's template is completely ignored.

4. Please link to the relevant issues (if any).
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @Fayti1703, i've talked with our Storefront team and this needs rigorous testing which we need to do ourselves. It may take a while until anything happens here again.

Any update on this?

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-24825
Please use this issue to track the state of your pull request.


Duplicate Code in https://github.com/kubernetes-sigs/multi-tenancy/blob/master/tenant/config/manager/all_in_one.yaml

It seems line 15-23 in this code : https://github.com/kubernetes-sigs/multi-tenancy/blob/master/tenant/config/manager/all_in_one.yaml

apiGroups:

""
resources:
namespaces
verbs:
get
list
watch
create

This is exactly same as in lines 59-67.
Can someone clarify the difference, otherwise one of it can be deleted.

Feel free to create a PR to fix it. Thanks

/assign


ars-grin jenkins job fails after upgrade to scala 2.12

Scrape job setup at https://build.berkeleybop.org/job/extract-grin-traits/23/console failed due to change in scala version. @cmungall any chance you can update the start script to java -jar 'target/scala-2.12/samara-assembly-*.jar' scrape grin ?
snippet from jenkins console:
+ java -jar 'target/scala-2.11/samara-assembly-*.jar' scrape grin
Error: Unable to access jarfile target/scala-2.11/samara-assembly-*.jar
Build step 'Execute shell' marked build as failure

PS Same applies to https://build.berkeleybop.org/job/extract-apsnet-diseases

@cmungall @austinmeier I was wondering whether it might be pragmatic to give me access to planteome build jobs. . . don't want to keep bugging you about trivial issues and sit around idle while waiting.

I made the changes, I'll chat with @kltm tomorrow about getting you set up

Thanks for making the changes, looks like the job are now running again. apsnet completed, ars-grin scrape is in progress as I write.


Retrieve live params first, include template-driven defaults

Problem
#3820 reported an issue that parameter defaults that use Jinja templates that return something other than string, simply don't work.
This is caused by two things:

The code in the API controller that handles execution scheduling currently makes a call to action_service.create_request before the live parameters are retrieved, which is where any templates are rendered into a result value. So if a parameter is an integer but the default value is still a template (string) - even if that template is expected to return an int, naturally this will cause problems because it hasn't even rendered yet.
The call to param_utils.render_live_params and the function calls within will render the templates, but will not actually use the resulting value, as the default values for parameters are not seen as "live". So even though there's a rendered value available to use, it's not placed in the params list because it wasn't passed in explicitly by the user, and the same problem occurs, as the unrendered template value is used (string).

Proposed Solution
To fix the behavior observed in #3820, I propose the following changes:

A simple re-order will address the first problem. Wait to call action_service.request until the live params are retrieved.
After the existing behavior around live parameters, I suggest that we detect if a parameter's default is a template, and the resulting value of that template is actually being used (i.e. isn't being overridden by the user). In effect, we treat the resulting value as a live parameter (we're literally adding it to the same dict). If a default value is rendered and used, it shows up as if the user had passed that value in.

I think treating rendered default values as "live" parameters makes sense. Inherently, since we're using a template, it could easily be user-provided, even if the user provides it via st2kv. It's a bit of a paradigm change but I think it makes sense, personally.
One potential consequence to note is that the parameter schema will now have to validate against what the template's value will be, but IMO this should already be happening anyways. I would expect that if I'm getting a value from a template, that the datatype should be predictable, and if it's different for any reason, I would expect a validation error at runtime. We've already inherently moved this problem to runtime by using templates in params like this anyways - this just makes the resulting behavior more intuitive.
Demo
I threw together a quick action to demonstrate the new logic:
---
description: Run a local linux command
enabled: true
runner_type: local-shell-cmd
name: nmaludy-test
pack: testpack
parameters:
  kv_test:
    type: integer
    default: "{{ st2kv.system.nick_test | int }}"

I'll create the referenced key in the datastore and execute my action:
~$ st2 key set -s system nick_test 31415
+------------------+-----------+
| Property         | Value     |
+------------------+-----------+
| name             | nick_test |
| value            | 31415     |
| expire_timestamp |           |
+------------------+-----------+
~$ st2 run testpack.nmaludy-test cmd=date
.
id: 5a2667e632ed353390a8bc7a
status: succeeded
parameters:
  cmd: date
  kv_test: 31415
result:
  failed: false
  return_code: 0
  stderr: ''
  stdout: Tue Dec  5 09:33:27 UTC 2017
  succeeded: true

Note that kv_test appears in the resulting live parameters as if I had passed it in explicitly. While it's true, I didn't do this at the CLI, I believe the intention is the same - the default value is based on dynamic retrieval from the datastore via the template.
Note also that I can still override this with my own value - a "true" live param:
~$ st2 run testpack.nmaludy-test cmd=date kv_test=12345
.
id: 5a2667f832ed353390a8bc7d
status: succeeded
parameters:
  cmd: date
  kv_test: 12345
result:
  failed: false
  return_code: 0
  stderr: ''
  stdout: Tue Dec  5 09:33:44 UTC 2017
  succeeded: true

Closes #3820

+100

Overall, from a high level perspective the change and approach looks good to me.
We had some discussion about this in the past (dynamic default parameter values) and I was strongly against it then.
My main reason was that is very hard to reason about - different values are available at different point in lifecycle of an execution (before any rendering is happen, after rendering happens, when execution is created, etc).
I'm still personally not a big fan of it (static > dynamic - a lot easier to reason about, develop, troubleshoot, see what is going on, etc.), but apparently other users see value in it and in a sense it's opt-in so I'm fine with it.

I agree with you actually. I far prefer predictable values than moving the problem to runtime. One of the reasons I go write Go code when Python starts grinding my gears again :)
In any case, my point was that IMO we crossed this boundary when we allowed templates in default values for actions in the first place. This PR just finishes that work by making the type cast portion work the way you'd expect.


[HUDI-5797] fix use bulk insert error as row

Change Logs
bulkinsert as row not initTable first, it will trigger mdt init when commit result after write in the same job, and this will use fileSystem to init, which will contain orphan file or error file. For example, if writer not flush but kill by RM, the parquet file size may be 0. It will triiger the size check error when init mdt.
Impact
None
Risk level (write none, low medium or high below)
None
Documentation Update
None
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@hudi-bot  run azure

@hudi-bot run azure

@hudi-bot run azure

@KnightChess : I am not sure I understand why this is only the problem with bulkInsert as row. Is problem because when doing MDT init, files which are not committed (empty/partial) are being added (see HoodieBackedTableMetadataWriter.listAllPartitions) . @prashantwason : Can you let me know if I am missing something.

@bvaradar yeah, when doing mdt init, will use fileSystem to list all partitions. Unfortunately, it may contain damaged data file
after bulk insert. It will use the damaged data file to init mdt when commit the hoodie meta.

THanks @KnightChess . @nsivabalan : Should we fix HoodieBackedTableMetadataWriter.listAllPartitions to only gather committed files ?

@bvaradar sorry, I found it will use complete instant to filter it, so I think my problem description has a little problem. I will reopen it when I reproduct or meet again. close it, thanks


Outdated GDNative API: determinant method in Transform2D is not implemented

With this commit, determinant method was added to Transform2D. However, it's not implemented in this repository yet. Therefore, using the latest build of Godot engine from 3.x branch causes a crash with the following backtrace:
================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v3.6.beta.custom_build (c4becb0ca44de25ee9ca9a3365245d979dad1e61)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x42520) [0x7fbe24e42520] (??:0)
[2] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0x31cdf63] (/home/ilker/Programming/godot/godot/./core/cowdata.h:128)
[3] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0x31ce2a5] (/home/ilker/Programming/godot/godot/./core/cowdata.h:376)
[4] godot::GlobalConstants::___init_method_bindings() (??:0)
[5] godot::___init_method_bindings() (??:0)
[6] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0xf90da7] (/home/ilker/Programming/godot/godot/modules/gdnative/gdnative.h:88)
[7] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0xb60eb4] (/home/ilker/Programming/godot/godot/modules/gdnative/register_types.cpp:304)
[8] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0xb61e9a] (/home/ilker/Programming/godot/godot/modules/register_module_types.gen.cpp:93)
[9] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0xa7112a] (/home/ilker/Programming/godot/godot/main/main.cpp:1588)
[10] /lib/x86_64-linux-gnu/libc.so.6(+0x29d90) [0x7fbe24e29d90] (??:0)
[11] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x80) [0x7fbe24e29e40] (??:0)
[12] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0xa7e305] (??:?)
-- END OF BACKTRACE --
================================================================

This issue has been fixed by this merged PR on Godot which moves Transform2D::determinant to the newly added Core API 1.4.
Thanks to Bromeon and chitoyuu for helping me debug this issue on Discord and thanks to akien-mga for PR!


Gets stuck after retrieving audio in Version 2.1.53.

This was also an issue with 2.1.50 as well. It happens sometimes, usually when I try to edit a field. then add audio, then click another field quickly. This seems to only happen when using the Ctrl+Shift+F function.

This should be fixed now, if it still happens feel free to reopen this issue.


📌 Use versions

@master is deprecated. Please use a version, thank you :)

Github action not needed anymore. Thank you, closing PR.


implement aggregate join by overriding the whole aggregate() method.

This version allows for separator to be a set, but doesn't put a separator at the beginning or end of the result string

We had talked about the following interface in the past: text = join(token, index, with)
I don't know if I like "with" as an attribute as opposed to separator, but I think using token as an argument and having text as the output is good, because it mirrors the split function (token, index) = split[text, by]

corey, i changed the argument names (actually you can use 'value' or 'token' because of some class inheritance rules, but i thought that was ok)
i wrote a basic test, but instead of trying to capture the output database, i wrote another test driver which looks to see if the is a #success in the output, that way the test eve can be self contained and use intermediate data

@convolvatron okay, looks good. I don't think this needs changing in this PR, but playing around with join highlights some issues with aggregates that are unpleasant. For instance, I found I had to do this in order to get the string I wanted:
(token, index) = split[text: "Hello world" by: ""]
text = join[token index given: (token, index) with: "/"]

I needed to add the index in to given, or else duplicate letters in the original string went missing. This is an easy thing to overlook. It's also pretty verbose for just a string join, but that's what it takes.


bufferline does not work as expected

It is found that only one bufferline tab will show up, so there must be something wrong with the bufferline config.
AFAIK if bufferline is enabled, nvim can show multiple tab windows and we can use shortcuts to navigate between
theses opened tab windows.

Nothing unexpected. I wrote a filter function to filter buffers, which makes only buffers on the current tab or that are modified but not saved to files will be shown up.
If you are familiar with many popular IDEs before, you may want to interact with bufferline just like the tab bar of IDEs. However, buffers are not tabs, even though many users treat them the same. Vim has its own concept of tabs, totally different from the tabs of IDEs, which is more like a window layout or workspace.
The reason  I wrote the filter is that the most efficient way to open a file in the current workspace is to search it by a fuzzy finder, rather than check if it already exists in the bufferline and jumps again and again.
This setting is indeed very personal, but it is true that many people who are more familiar with Vim have this habit. If you are interested in the concepts of buffers and tabs in Vim, you can read some articles about it, or you can fork this repository and modify the configuration file and delete the filter function.

Thanks for your reply. Well I  have read through the doc of bufflerline.lua and now realize that it is the custom_filter function that makes a set of filter buffers show up there.  And this is surely a very personal taste. I usually open lots of files
and jumps around when I am doing my job. So I think I should write own filter here as suggested.
Thanks for your help.


Deploy to Heroku & Generate Readme

Deploy to Heroku
Test all routes on deployed application
Fix any issues
Generate Gifs & Video
Complete Readme

Integrated under: commit 6db26b26c441de250183afc30f385db9c332dd12 .


update composer.json for Heroku

[Current coverage][cc-pull] is 100%

Merging [#361][cc-pull] into [heroku][cc-base-branch] will not change coverage

@@           heroku   #361   diff @@
====================================
  Files          24     24
  Lines         365    365
  Methods        77     77
  Messages        0      0
  Branches        0      0
====================================
  Hits          365    365
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last updated by [64c40bd...c4b3a47][cc-compare]
[cc-base-branch]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/branch/heroku?src=pr
[cc-compare]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/compare/64c40bdc2f8b656835479b614ddd8b7d6163a34b...c4b3a47e53309cd0ecb5146a469c1eedf05f31ff
[cc-pull]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/pull/361?src=pr

better way to use "incenteev/composer-parameter-handler"


Party restrictions

In some places primary ballots are restricted by party.   How do we want to deal with this?

Added a party to the Choice object.


Add dictionary_read method to ext-FFI

CHANGELOG:

Added dictionary_read method to the ext-FFI that allows to directly read a value under a Key::Dictionary.
Added API methods to both the Rust and Assembly script API libraries to make use of the newly added ext-FFI method.
Added a test to check the functioning of the newly added methods
Added utility method to the Assembly script library to create  Key::Dictionary from a seed uref and an item key

Closes: #3145

bors r+


Beacon detection extremely unreliable on Android

There seems to be something weird going on with Chrome on Android's beacon detection. On iOS and in the Nordic Master Control Panel my beacon is always detected, nearly instantly. On Android is often doesn't show up for several minutes, sometimes hours and sometimes never. Even the Physical Web app can't find them sometimes - surely that uses the same scanning method as the Master Control Panel app?
Can you tell us what the duty cycle used for scanning is, does it vary by phone? What happens if you dismiss a notification - will it ever come back? Is a scan initiated when you unlock the phone?
I thought the idea was you could walk up to a physical thing, open your phone and interact with it. If it take 15 minutes to detect the thing that's not really possible is it?

The Physical Web App uses the raw BLE scanning services (much like Nordic MCP) the reason for the difference in speed is that the MCP just returns the raw packet URL whereas the PW App runs everything through our PWS (Physical Web Service)
Chrome on the other hand uses the Nearby scanning service (which is much more power efficient) it only scans when you wake up the screen but it too has to go through the PWS.
There was a bug in the Nearby Service that was just recently fixed (last week in fact) so I can understand your frustration with Chrome (it should be fixed now) However, when you say the PW App is also flakey that suggests you have a bad/slow internet connection. If you can't reach the PWS, results won't show up.

I've noticed something similar.  I have a few beacons configured for Eddystone-URL that were working well with chrome PW detection the other day, but today everything seems to show as unresolved under chrome://physical-web.  In particular, I have a beacon sitting here now that is broadcasting https://www.google.com and shows up in the PW app, and on other BLE scanners, but chrome is not finding it in its PW search or notifications, and shows the url as unresolved on the chrome://physical-web tool.
Phone is Nexus 5 with latest updates, latest Chrome.  Is this related to a PWS issue?  Is there a way to check PWS status to see if it's slow/unresponsive?  If this is known and/or fixed in a new Chrome then that's fine.

https://www.google.com should work fine.  We had a temporary issue that has been fixed that might be related.  Does it still show up as unresolved for you?

After a restart of Chrome, it's appearing just fine.  Thanks!


Update S3 tests

The 4 splits are test1.csv, test1.csv.gz, test1.csv.lz4,
test1.csv.bz2. The number of files was changed in
43bd519052ba4c56ff1f4fc807075637ab5f4f10.

Are these files provisioned automatically or they need to be uploaded to bucket?

Automatically.

@electrum ?

@sopel39 thanks for review
yes, this is very important
it's covered by https://github.com/prestosql/presto/issues/274


Issue with Terminal placement

Issue Type: Bug
Hello Team,
Command prompt which is like C:> is not placed correctly. Please find the attachment for your reference. I have clean installed the latest version of VS code.
It is getting some empty space above that prompt.

Me too, I thought it was a problem with PowerShell.

What does your terminal look like if you just open cmd outside of VSCode?

It looks normal outside of VSCode.

Me too, I thought it was a problem with PowerShell.

Don't know...for both Powershell and Command prompt terminal in VS Code, I noticed the same thing.

It still has a space, I have obsessive-compulsive disorder, it’s too bad.

https://github.com/Microsoft/vscode/issues/57803


[TODO] Set up YAML linting

Starting points:

https://github.com/aio-libs/yarl/blob/bd5ff24/.yamllint
https://github.com/aio-libs/yarl/blob/bd5ff24/.pre-commit-config.yaml#L89-L94

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

Addressed by 187f552


Remove the {BaseViewer, PDFThumbnailViewer}._pagesRequests caches

Please refer to the individual commit messages.

/botio unittest

/botio-linux preview

Looks good, and thank you for also extending the test coverage!


GLDv2 test performance reproduction

Hi,
Thank you for your great work and sharing your code.
I was able to reproduce mAP scores for ROxford and RParis datasets, also with +1M distractors, both with and without re-ranking. Unfortunately, I cannot reproduce mAP@100 scores for GLDv2 retrieval test set. I am around 0.8 below your scores even without re-ranking. The same applies when I try to reproduce original CVNet - I can reproduce ROP but not GLDv2.
I cannot figure out what I am doing wrong. Is there any special pre-processing of the GLDv2 images which is different to ROP images? For example some image resizing? I noticed that if I keep GLDv2 images in their original size, some of them have their smaller side too small and the extraction with your code crashes. This does not happen with ROP as they are generally larger images with less extreme aspect ratios.
Thank you for your assistance.

Hi, thank you for your interest in our work! The GLDv2 evaluation pipeline is with my Google collaborators. I have already informed them to provide some support.


AzurePowershellV5: Az-function output suppression

Task name: AzurePowershellV5
Description: Suppress Az-functions output in line with rest of task code
Documentation changes required: N
Added unit tests: N
Attached related issue: Y : #19672
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

@LeftTwixWand and @v-mohithgc: I removed the changes to helper function to make approval process easier.
Opened this new PR with only the changes made to AzurePowershellV5-task.
Hopefully this will make for a streamlined approval engagement.

@MrNewgarden: Please approve this also, it's the same as #19674 but removed the changes to VstsAzureHelpers_ as this triggered changing version on many other tasks.

@manolerazvan  please approve the code

/azp run

@v-mohithgc please approve if you are an approver

/azp run

Hey @mortenlerudjordet thank you for reaching me out.
And thank you so much for this contribution❤

I've added a commit with version bump

/azp run

Hey @mortenlerudjordet I completely agree, that versioning might be a bit confusing.
The minor version is usually our sprint number from this resource: whatsprintis.it
And patch is incremental.
But now we're moving from NodeJS 10 to NodeJS 20.
And generating pretty much the same code but for different version of Node.
That's why there is a versioning inconsistency.
It might be really tricky if you're doing it for the first time.😅
Anyway, thank you for the contribution.
Tomorrow we would start a new tasks' deployment, and it might take up to 5 days to reach everyone.


What it the setpoint changes often?

Hi! Can it be used in a situation where the setpoint changes on-the-fly, like a gas pedal of a car, accelerating? Example, you change the speed and the PID  tries to keep the new set speed, even if the load increases.

Yes, it can do that


ai(transcript): Add 1 transcripts

This PR adds 1 new transcripts generated by tstbtc.

closing this, it was for testing purposes.


fix get contract_state()

Fixes how get_contract() uses min_confirmations.
To be clear, 0 confirmations would be considered not being in the blockchain, 1 confirmation is considered as being in the head.
Surprisingly, this hadn't been causing an issue on sandbox. I think the reason is because blocks are produced much faster on sandbox, so by the time the merchant was checking the blockchain, one block had probably elapsed. Without this fix, I got the following error when min_confirmations was 1 or 2. After this fix it worked for both values.
Error: Merchant chose to abort the session

Caused by:
    Could not verify contract's origination on chain

thanks! rebased and ran cargo fmt


Installing smartmontools on Raspberry/Banana Pi (Debian Wheezy)

I thought I would share how to get the smartmontools installed on a Debian Wheezy since there are no guides out there. You would think it would be easy, but Debian Wheezy apt repo has version 5.41, HTPC Manager requires 5.42+.
After completely hosing my linux install trying to use the version on the Debian Jessie repo, I flashed the sd card from a backup and dug a little deeper into the backport repos.
Debian warns that the backport servers house experimental and possibly unstable versions of packages. However I did get smartmontools to install with no problems to my raspberry.
when logged in as a root user run the following command (you can simply copy and paste into your favorite ssh terminal).

We add the backport repo - this creates a file that can be deleted later if you want (not required)

echo "deb http://http.debian.net/debian wheezy-backports main" > /etc/apt/sources.list.d/wheezy-backports.list

We add a preferences file so that the backport server is only ever used when it specified in the command line - this creates a file that can be deleted later if you want (not required)

echo "Package: *\nPin: release n=wheezy-backports\nPin-Priority: -1" > /etc/apt/preferences.d/wheezy-backports.pref

Update the repo list, then install smartmontools (the -t wheezy-backports specifies to use the backports version, same label as in the preferences file we created)

apt-get update && apt-get install -t wheezy-backports smartmontools -y
My system shows that smartmontools 6.3 is installed.
After that you just need to restart your HTPC Manager install and enable the S.M.A.R.T. otion in the Computer Stats setting. Provided you have smartctl in your path (see: http://www.troubleshooters.com/linux/prepostpath.htm for directions on that).

Awesome thanks! Would you mind adding that to the wiki?

sorry, i was being brain dead. yeah, gimme a couple minutes.

Wiki page added

ty

np, i figure I gotta create some good will. I plan to submit a fair number of feature requests once I get my new download station build stable.

Your +1 now atleast.


homework1

Good Job!!!   @Zhiqing-Zhu

Good Job!!! @Zhiqing-Zhu

@Zhiqing-Zhu
你需要update branch一下哈

Good Job!!!   @Zhiqing-Zhu
Python homework:

Total questions: 108
Correct answers: 105
Score: 97.00%

Numpy homework:

Total questions: 10
Correct answers: 10
Score: 100.00%

Pandas homework:

Total questions: 12
Correct answers: 11
Score: 91.00%

Good Job!!!   @Zhiqing-Zhu
Python homework:

Total questions: 108
Correct answers: 105
Score: 97.00%

Numpy homework:

Total questions: 10
Correct answers: 10
Score: 100.00%

Pandas homework:

Total questions: 12
Correct answers: 11
Score: 91.00%

Good Job!!!   @Zhiqing-Zhu
Python homework:

Total questions: 108
Correct answers: 105
Score: 97.00%

Numpy homework:

Total questions: 10
Correct answers: 10
Score: 100.00%

Pandas homework:

Total questions: 12
Correct answers: 11
Score: 91.00%

@Zhiqing-Zhu
Python基础作业和扩展作业在加把油哈！

@Zhiqing-Zhu
Python基础作业再加加油哈！


Error Queueing v6 Recipe from Parse Job

In 5.9.x if a v6 recipe type is queued from a parse trigger, we need to call the v6 queue recipe method and not the old method.

Fixed in 5.9.5


WIP: Penaltymodel cross platform install

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   92.63%   92.63%
=======================================
  Files          18       18
  Lines         611      611
=======================================
  Hits          566      566
  Misses         45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23fb61...7aaa166. Read the comment docs.


Panic observed when docker's config.json has a server entry that uses credential helper

What steps did you take and what happened:
Executed starboard find vulnerabilities deployment/nginx --namespace dev command and observed that system went into panic mode due to a runtime error.

panic: runtime error: index out of range [1] with length 1

This is happening because my docker configuration JSON file had a server line that uses credentials helper and has a structure like below in the config.json file.
{
  "auths": {
    "<my-server>": {}
  }
}

What did you expect to happen:
I was expecting that those server entries would be skipped and starboard will continue looping through other server entries in the config file.
Anything else you would like to add:
I have a subsequent PR to fix this issue.
Environment:

Starboard version (use starboard version): v0.2.5
Kubernetes version (use kubectl version): Client -> 1.17, Server -> 1.14+
OS (macOS 10.15, Windows 10, Ubuntu 19.10 etc): Debian 4.9.144-3.1

/assign


Gray buttons

I have gray buttons on different pages.
HA Version = core-2021.5.3
Them Version = 1.3
Integration

Dashboard Edit Mode:

HACS

Make this fix. https://github.com/naofireblade/clear-theme-dark/issues/7#issuecomment-665038516


Reset password frontend

Some notes:

Email view is currently accessible in /resetPasswordEmail/:token
Email view still has things marked as to do since it will most likely need changes when actually implementing it to the email
All of the pages are using old footers but I figured that creating new footers and applying it to all the other pages as well (email verification etc.) is not in the scope of this PR

Great points 👍 Added all your suggestions

One thing I noticed though, is that clicking "send link" -> "change address" -> "send link" -> ... allows skipping the cooldown.

Added separate cooldown for the send link button on the first page. Made it 15 sec so it prevents spamming but shouldn't affect real cases where you accidentally typed wrong address too much.

I think the email page should be in separate pr to keep this one a bit more manageable and focused.

Removed the email page from this pr

The timeout should also be cancelled when the component is unmounted.

Missed this part in the previous fixes, it's under progress now.

Added all the changes 👍 There's now just one timer which controls both send and resend buttons

The time could be parametrised, but either way is fine, your call

Added this 👍


Reimplement actions skeleton

Actions don't run yet, but they are enqueued/dequeued, batches are created and they get processed on apply.
It doesn't have tests yet, that's also a next step in a subsequent PR.
Also fixes a bunch of misc bugs that we found along the way, that's why it's being merged even if not feature complete.
Co-Authored-By<EMAIL_ADDRESS>

@paulocsanz approved but I think we need to ignore the .gitignore change.

bors merge


Upgrading react-oidc-contet 3.1.6 to 3.1.7 -- stuck in endless loop at the callbackComponent page calling the openid-config endpoint

Issue and Steps to Reproduce
Seeking advice on where to look for the below issue, need to isolate the problem down a bit more.
Updating package @axa-fr/react-oidc-context 3.1.6 to 3.1.7
After a user logins in.
They hit the callbackComponentOverride , the component displays successfully.
But in the browser console it will enter an endless loop with network calls to the discovery openid-configuration endpoint, locking up the browser.
In the AuthenticationProvider component, loggerLevel is DEBUG
All I see in the browser console is a set of oidc debug messages in a continual loop:
UserManager._loadUser: user storageString loaded
oidc-client.min.js:1 User.fromStorageString
oidc-client.min.js:1 UserManager._loadUser: user storageString loaded
oidc-client.min.js:1 User.fromStorageString
oidc-client.min.js:1 UserManager._loadUser: user storageString loaded
oidc-client.min.js:1 User.fromStorageString
oidc-client.min.js:1 UserManager.getUser: user loaded
oidc-client.min.js:1 UserManagerEvents.load
oidc-client.min.js:1 AccessTokenEvents.load: access token present, remaining duration: 3586
oidc-client.min.js:1 AccessTokenEvents.load: registering expiring timer in: 3526
oidc-client.min.js:1 Timer.init timer Access token expiring skipping initialization since already initialized for expiration:<PHONE_NUMBER>
oidc-client.min.js:1 AccessTokenEvents.load: registering expired timer in: 3587
oidc-client.min.js:1 Timer.init timer Access token expired skipping initialization since already initialized for expiration:<PHONE_NUMBER>
oidc-client.min.js:1 UserManager.getUser: user loaded
oidc-client.min.js:1 UserManagerEvents.load
oidc-client.min.js:1 AccessTokenEvents.load: access token present, remaining duration: 3586
oidc-client.min.js:1 AccessTokenEvents.load: registering expiring timer in: 3526
oidc-client.min.js:1 Timer.init timer Access token expiring for duration: 3526
oidc-client.min.js:1 AccessTokenEvents.load: registering expired timer in: 3587
oidc-client.min.js:1 Timer.init timer Access token expired for duration: 3587
oidc-client.min.js:1 UserManager.getUser: user loaded

If I close the browser and open it again, the user has been successfully logged in.
If I revert to 3.1.6, the problem goes away.

Any advice on where to investigate appreciated.

Thank you for the report. It is a big bug. You may look at thé commit in the master history?

Thanks @guillaume-chervet ,  yes I intend to dig deeper by looking at the commit log and isolate my code for a repro.  Posted early just in case someone may have had a similar issue and found an obvious fix.

related #644


Update chip-tool listening port to be 'CHIP_PORT + 1' instead of CHIP…

…_PORT
Problem
chip-tool is sometimes used to connect to a local accessory server running on the same machine. In this case the accessory server and chip-tool conflicts because both listens to port 11097 (CHIP_TOOL).
It is easy to workaround this by adding a ListenPort=11098 to /tmp/chip_tool_config.ini but it requires an extra step that is not necessary.
Summary of changes

Listen on port CHIP_PORT + 1 by default instead of CHIP_PORT

Should we add a command-line argument instead?
Although we are loking to deprecate chip tool, so maybe either approach works just as well.

Should we add a command-line argument instead?

At some point I should probably rewrite the command line parsing ability of chip-tool. It just seems a bunch of work for little value at the moment.

Although we are loking to deprecate chip tool, so maybe either approach works just as well.

On a side note it's possible that chip-tool may lies around as long as it is useful. But yeah, in theory it should be useless at some point.


Fix typo

I know it's silly, but I figured this was the easiest way for you.
I'd actually be interested to know if you'd prefer to be told these types of things in another way.
Cheers

Ta!!


Remove some cli parameters

Nydus-snapshotter now has its own toml based configuration file whose entries are duplicated with CLI startup parameters.
In the first phase, we will remove those not frequently used cli parameters and suggest users to migrate the configuration to toml based configuration file.

Codecov Report
Base: 30.50% // Head: 29.61% // Decreases project coverage by -0.88% :warning:

Coverage data is based on head (7fd29b7) compared to base (c84085c).
Patch coverage: 15.38% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   30.50%   29.61%   -0.89%
==========================================
  Files          37       37
  Lines        3800     3718      -82
==========================================
- Hits         1159     1101      -58
+ Misses       2520     2497      -23
+ Partials      121      120       -1

Impacted Files
Coverage Δ

config/config.go
10.11% <0.00%> (+1.70%)
:arrow_up:

cmd/containerd-nydus-grpc/pkg/command/flags.go
100.00% <100.00%> (ø)

cmd/containerd-nydus-grpc/pkg/logging/setup.go
76.47% <100.00%> (+6.20%)
:arrow_up:

pkg/blob/blob_manager.go
32.65% <0.00%> (+3.06%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


unciv: 4.6.13 -> 4.6.14-patch1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yairm210/Unciv/releases.
meta.description for unciv is: An open-source Android/Desktop remake of Civ V
meta.homepage for unciv is: https://github.com/yairm210/Unciv
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.6.14-patch1 in filename of file in /nix/store/zlvhspk1bi4d51shyvgyhdr6h78s45v4-unciv-4.6.14-patch1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
unciv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zlvhspk1bi4d51shyvgyhdr6h78s45v4-unciv-4.6.14-patch1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unciv https://github.com/r-ryantm/nixpkgs/archive/527049b1c101816f71e27889666336843e70ffd9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zlvhspk1bi4d51shyvgyhdr6h78s45v4-unciv-4.6.14-patch1
ls -la /nix/store/zlvhspk1bi4d51shyvgyhdr6h78s45v4-unciv-4.6.14-patch1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

unciv

Maintainer pings
cc @tex for testing.

Result of nixpkgs-review pr 234417 run on aarch64-darwin 1

1 package built:

unciv


[LIBCLOUD-688] Loadbalancer driver for Softlayer

https://issues.apache.org/jira/browse/LIBCLOUD-688

Thanks, I will have a look shortly (will most likely have time to review this one before autoscaling changes since it's a smaller patch which doesn't introduce any new APIs and requires less work).

Made some minor style and Python 3 compatibility fixes and merged changes into trunk.
Thanks!

Hi, can we close corresponding issue: https://issues.apache.org/jira/browse/LIBCLOUD-688 ?
Thanks.


Use usage="rec" to indicate recommended attributes

Use of @usage="rec" and display of the attribute's status in the Data Dictionary will help clarify when an attribute is recommended. Since "rec" results in an optional attribute in RNG (the same as "opt"), there is no compatibility issue. Need to compile a list of recommended attributes.

Since compiling a list of recommended attributes for every element is likely to take quite some time, I'm kicking this issue further down the road to someday.


Change cursor datatype in RaceBuffer to u64

We've identified a troublesome race condition with the current overflow handling code; a change to u64 eliminates this for all practical implementations, and allow us to eliminate overflow handling.

Updating them to be U64s makes them multi-word writes on most hardware we expect to deal with, which makes them potentially interruptable mid-write if I understand things correctly. Doesn't that mean that something like the debug reader might end up reading a value from the cursor location that's half-written?
Is there the possibility of a solution to managing the cursors in a way that doesn't depend on numbers that need to grow forever by-design, but can't due to wrap around in-practice? Or maybe something that maintains other single-word state that's tracking the relationship or epochs of the relationships between the cursors?

Updating them to be U64s makes them multi-word writes on most hardware we expect to deal with, which makes them potentially interruptable mid-write if I understand things correctly. Doesn't that mean that something like the debug reader might end up reading a value from the cursor location that's half-written?

Yes. We've discussed several ways to accommodate this based on the fact that these number aren't arbitrarily set, they're incremented. For example: read the high word, then the low word, then the high word again. If the high word changed, then you know the low word must have rolled over to zero in the interim. There are a few different variations of that.
But: the intent of this ticket is to allow us to get the RaceBuffer merged into mainline modality-probe for regular (non-debug-reader) use, unblocking a bunch of other work which depends on having a working ring buffer in place. It's possible that none of the debug-reader strategies will actually work out, and we have to do something different; in that case we'll figure something out. But we will still have something in place for local-operation, which is the short-term priority.

Is there the possibility of a solution to managing the cursors in a way that doesn't depend on numbers that need to grow forever by-design, but can't due to wrap around in-practice? Or maybe something that maintains other single-word state that's tracking the relationship or epochs of the relationships between the cursors?

Yes, of course there is the possibility. But the design constraints of read-only access (all reader state is local to the reader) and being able to tell how many events were overwritten between reads leaves me at a loss.


Use global imagePullPolicy

Signed-off-by: clyang82<EMAIL_ADDRESS>

@clyang82 Please update the sidecar injection template to pass the CI.

always is really only good for dev testing when reusing the image name/tag, why should that be the default for a real installer?

always is really only good for dev testing when reusing the image name/tag, why should that be the default for a real installer?

Here is explanation from code comments
https://github.com/istio/installer/blob/399986a9f0289a928f8b6edca46a2da8199e731f/global.yaml#L178-L182

the TODO there doesn’t actually say why always is needed or good

@costinm @howardjohn Is there other consideration for default image pull policy to always?
I saw it before this PR, eg. https://github.com/istio/installer/blob/master/global.yaml#L181
https://github.com/istio/installer/blob/master/gateways/istio-ingress/templates/deployment.yaml#L89
and https://github.com/istio/installer/blob/master/gateways/istio-egress/templates/deployment.yaml#L66

In istio/istio we use IfNotPresent. I think Costin changed it and wrote the TODO to change it, so maybe he has some insight on why this is preferred.

IfNotPresent is required for minikube/kind - since the image is not pushed,
but built locally and reused.
In the past, we used sha tags in the official installers. That works with
'if not present' as well.
Now we use tags for periodic builds like 'nightly/weekly' - when using tags
it is not safe to use 'ifnotpresent' since image can get out of date. The
checked in defaults and kustomize  are using tag - otherwise we would need
to do a PR for every build.
Official releases could 'if not present' - if the version is fully
specified (1.1.7), but if we use something like 1.1-stable - it has to be
'allways'
In general - allways fails only for minikube, while IfNotPresent fails if
tags are used.
On Tue, Jun 11, 2019, 16:52 John Howard<EMAIL_ADDRESS>wrote:

In istio/istio we use IfNotPresent. I think Costin changed it and wrote
the TODO to change it, so maybe he has some insight on why this is
preferred.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/installer/pull/234?email_source=notifications&email_token=AAAUR2XERK7EOL3H2XDHTCDPZ6327A5CNFSM4HWURR3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXNMVGI#issuecomment-500877977,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAUR2RYR3ZEE37G5IIXDOLPZ6327ANCNFSM4HWURR3A
.

Thanks @costinm and @howardjohn  for your detailed information
so this PR can be merged. right?

Yes. What is checked it has floating labels - so needs Allways.
For released artifacts - which will have strict version - when the tag is
changed to fixed we could also set the pull policy.
On Wed, Jun 12, 2019, 04:57 Chunlin Yang<EMAIL_ADDRESS>wrote:

Thanks @costinm https://github.com/costinm and @howardjohn
https://github.com/howardjohn for your detailed information
so this PR can be merged. right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/installer/pull/234?email_source=notifications&email_token=AAAUR2ROPTZ2DRLX33ZTSLTP2BQ2RA5CNFSM4HWURR3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXPDHKY#issuecomment-501101483,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAUR2U3NMBCQF5ZKAKTEVLP2BQ2RANCNFSM4HWURR3A
.

IfNotPresent is required for minikube/kind - since the image is not pushed, but built locally and reused. In the past, we used sha tags in the official installers. That works with 'if not present' as well. Now we use tags for periodic builds like 'nightly/weekly' - when using tags it is not safe to use 'ifnotpresent' since image can get out of date. The checked in defaults and kustomize are using tag - otherwise we would need to do a PR for every build. Official releases could 'if not present' - if the version is fully specified (1.1.7), but if we use something like 1.1-stable - it has to be 'allways' In general - allways fails only for minikube, while IfNotPresent fails if tags are used.
…
On Tue, Jun 11, 2019, 16:52 John Howard @.***> wrote: In istio/istio we use IfNotPresent. I think Costin changed it and wrote the TODO to change it, so maybe he has some insight on why this is preferred. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#234?email_source=notifications&email_token=AAAUR2XERK7EOL3H2XDHTCDPZ6327A5CNFSM4HWURR3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXNMVGI#issuecomment-500877977>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAUR2RYR3ZEE37G5IIXDOLPZ6327ANCNFSM4HWURR3A .

@costinm are you suggesting to change the default here:
https://github.com/istio/istio/blob/master/install/kubernetes/helm/istio/values.yaml#L271
To Always?  Given your line of reasoning (needed so we are not testing stale images in CI), I think it makes sense with the exception of the released artifacts.  We will need an appropriate change in the sedding scripts of the manifests to also sed this value if we change the default value back to IfNotPresent - which is what we want for production environments.  Such sedding is a slippery slope of madness, and we need to be careful the sed script doesn't turn into a monstrosity to deal with non-issues.  (this is probably not a non-issue fwiw).
@fpesce since this involves T&R work, could you chime in on your thoughts about approach?

We can't have users installing the latest daily builds anyways. If we are going to have them Kustomize install directly from the repo we must have a branch that has the versions pinned. Otherwise users are going to upgrade without knowing to untested builds.
For our tests that require Always, can we just set the helm flag in the test? Then we don't need to do crazy sed stuff for release

@howardjohn there are a boatload of tests, but I think most of the install is localized to one portion of the code base (atleast in istio/istio).  I am not sure about this code base.
I would prefer to use the flag and keep the default as IfNotPresent.  If it speeds up local dev, we can change to Always for the short term with a TODo to change to IfNotPresent prior to making this work available for production (along with an issue on the topic).
Re Kustomize - vs a helm flag, whatever option is best works for me:)

We can't have users installing the latest daily builds anyways. If we are going to have them Kustomize install directly from the repo we must have a branch that has the versions pinned. Otherwise users are going to upgrade without knowing to untested builds.

Right, I think this is to optimize for the CI and developer case.  We can tolerate alot more pain than operators.
Still the PR is valid (we need a way to customize the image pull policy).  I don't know if kustomize would be better suited to this purpose, or templating as is done here.
Thoughts?

How about keep Always as this PR done and change to IfNotPresent  in released artifacts since the version is strict?

Sounds like a correct approach. Pull policy should match the label type.
On Tue, Jun 18, 2019, 06:49 Chunlin Yang<EMAIL_ADDRESS>wrote:

How about keep Always as this PR done and change to IfNotPresent in
released artifacts since the version is strict?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/installer/pull/234?email_source=notifications&email_token=AAAUR2RDECM4J24S5UFKOTTP3BSPHA5CNFSM4HWURR3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX5FOWI#issuecomment-502945625,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAUR2SBVXGGJ7IO5PWTVYLP3BSPHANCNFSM4HWURR3A
.

On Sat, Jun 15, 2019, 16:23 Steven Dake<EMAIL_ADDRESS>wrote:

We can't have users installing the latest daily builds anyways. If we are
going to have them Kustomize install directly from the repo we must have a
branch that has the versions pinned. Otherwise users are going to upgrade
without knowing to untested builds.
Right, I think this is to optimize for the CI and developer case. We can
tolerate alot more pain than operators.
Still the PR is valid (we need a way to customize the image pull policy).
I don't know if kustomize would be better suited to this purpose, or
templating as is done here.
Thoughts?

The main point is correctness - whatever is checked in or distributed by
any mean and to whoever is using it must match the label type and policy.
I can't imagine any user type or case where you would want a fixed label
with IfNotPresent.
We can have rel branches or rel repos where we use version numbers/sha -
but in master it doesn't make a lot of sense to have a sha or
unmatching/old version number checked in.
—

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/installer/pull/234?email_source=notifications&email_token=AAAUR2SZEL4RMFESZBKSYDDP2T3OJA5CNFSM4HWURR3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXYZFWY#issuecomment-502371035,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAUR2VOZIST22WWCCDTDUDP2T3OJANCNFSM4HWURR3A
.

On Sat, Jun 15, 2019, 16:19 John Howard<EMAIL_ADDRESS>wrote:

We can't have users installing the latest daily builds anyways. If we are
going to have them Kustomize install directly from the repo we must have a
branch that has the versions pinned. Otherwise users are going to upgrade
without knowing to untested builds.

Why not ? Google does this - why wouldn't other users want the same ( I
mean have a staging env very close to head) ?
Yes, we will need rel branches with versions pinned. But doesn't mean
master shouldn't have a latest label and Always.
For our tests that require Always, can we just set the helm flag in the

test? Then we don't need to do crazy sed stuff for release
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/installer/pull/234?email_source=notifications&email_token=AAAUR2TQHODTRA4Y3AQOP7TP2T26FA5CNFSM4HWURR3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXYZDRA#issuecomment-502370756,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAUR2RTAO2B2Y2DSNL6M43P2T26FANCNFSM4HWURR3A
.

On Sat, Jun 15, 2019, 16:23 Steven Dake @.***> wrote: We can't have users installing the latest daily builds anyways. If we are going to have them Kustomize install directly from the repo we must have a branch that has the versions pinned. Otherwise users are going to upgrade without knowing to untested builds. Right, I think this is to optimize for the CI and developer case. We can tolerate alot more pain than operators. Still the PR is valid (we need a way to customize the image pull policy). I don't know if kustomize would be better suited to this purpose, or templating as is done here. Thoughts?
The main point is correctness - whatever is checked in or distributed by any mean and to whoever is using it must match the label type and policy. I can't imagine any user type or case where you would want a fixed label with IfNotPresent. We can have rel branches or rel repos where we use version numbers/sha - but in master it doesn't make a lot of sense to have a sha or unmatching/old version number checked in. —
…
You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#234?email_source=notifications&email_token=AAAUR2SZEL4RMFESZBKSYDDP2T3OJA5CNFSM4HWURR3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXYZFWY#issuecomment-502371035>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAUR2VOZIST22WWCCDTDUDP2T3OJANCNFSM4HWURR3A .

@costinm - I agree the pull policy needs to be configurable, however, I don't understand the implementation specifically:
          imagePullPolicy: {{ .Values.global.imagePullPolicy | default "Always" }}

why not just use
          imagePullPolicy: {{ .Values.global.imagePullPolicy }}

And set default in the values.yaml file to Always?

On Sat, Jun 15, 2019, 16:23 Steven Dake @.***> wrote: We can't have users installing the latest daily builds anyways. If we are going to have them Kustomize install directly from the repo we must have a branch that has the versions pinned. Otherwise users are going to upgrade without knowing to untested builds. Right, I think this is to optimize for the CI and developer case. We can tolerate alot more pain than operators. Still the PR is valid (we need a way to customize the image pull policy). I don't know if kustomize would be better suited to this purpose, or templating as is done here. Thoughts?
The main point is correctness - whatever is checked in or distributed by any mean and to whoever is using it must match the label type and policy. I can't imagine any user type or case where you would want a fixed label with IfNotPresent. We can have rel branches or rel repos where we use version numbers/sha - but in master it doesn't make a lot of sense to have a sha or unmatching/old version number checked in. —
…
You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#234?email_source=notifications&email_token=AAAUR2SZEL4RMFESZBKSYDDP2T3OJA5CNFSM4HWURR3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXYZFWY#issuecomment-502371035>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAUR2VOZIST22WWCCDTDUDP2T3OJANCNFSM4HWURR3A .

@costinm - I agree the pull policy needs to be configurable, however, I don't understand the implementation specifically:
          imagePullPolicy: {{ .Values.global.imagePullPolicy | default "Always" }}

why not just use
          imagePullPolicy: {{ .Values.global.imagePullPolicy }}

And set default in the values.yaml file to Always?

Some of our example values-xxx.yaml files do not have imagePullPolicy defined. we cannot ensure the values.yaml which is used by client will have imagePullPolicy define. so have a default value should be safe I think.

On Sat, Jun 15, 2019, 16:23 Steven Dake @.***> wrote: We can't have users installing the latest daily builds anyways. If we are going to have them Kustomize install directly from the repo we must have a branch that has the versions pinned. Otherwise users are going to upgrade without knowing to untested builds. Right, I think this is to optimize for the CI and developer case. We can tolerate alot more pain than operators. Still the PR is valid (we need a way to customize the image pull policy). I don't know if kustomize would be better suited to this purpose, or templating as is done here. Thoughts?
The main point is correctness - whatever is checked in or distributed by any mean and to whoever is using it must match the label type and policy. I can't imagine any user type or case where you would want a fixed label with IfNotPresent. We can have rel branches or rel repos where we use version numbers/sha - but in master it doesn't make a lot of sense to have a sha or unmatching/old version number checked in. —
…
You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#234?email_source=notifications&email_token=AAAUR2SZEL4RMFESZBKSYDDP2T3OJA5CNFSM4HWURR3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXYZFWY#issuecomment-502371035>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAUR2VOZIST22WWCCDTDUDP2T3OJANCNFSM4HWURR3A .

@costinm - I agree the pull policy needs to be configurable, however, I don't understand the implementation specifically:
          imagePullPolicy: {{ .Values.global.imagePullPolicy | default "Always" }}

why not just use
          imagePullPolicy: {{ .Values.global.imagePullPolicy }}

And set default in the values.yaml file to Always?

the global values.yaml file is always used even if an override file is specified.
The order of application is the values.yaml in the chart, followed by any overrides in the command line from (right to left) iirc.  Can you please test - this would make things far simpler.

Yes, the new installer script adds 'global.yaml' in all cases, and overrides with user-specific values.
I still think it's better to use "default" pattern, but in this case maybe it's ok to not do it, might be trickier
to sed/generate the changes in the release branch.

@costinm I agree to have "default" pattern and then replace it with "IfNotPresent" in release branch. Thanks.
@sdake I have removed the label of merge-to-release-branch to merge this PR into master branch firstly. I will have another PR against release branch.

Seems to be approved but has conflicts - let's try to get it in.


Expected sequence of events for an initialization failure

In the specification entry for initialize, it mentions the expected error code and data in case initialization fails.
Based on my understanding, the server should return this if it fails to initialize
{
  error: {
    code: 1,
    message: "Failed to initialize!",
    data: { retry: true }
  }
}

My question is what needs to happen after returning this response. Are servers expected to exit the process immediately after responding? Should they wait for shutdown and exit messages?

It depends on the value of retry. If it is true the server should not exit and the client should resend the initialize request. If false things can get indeed tricky. I would propose that the server shouldn't exit and the client should send shutdown and exit

the client should resend the initialize request
the client should send shutdown and exit

Do these already happen? Or do they need to be implemented in the client package?

They need to be implemented in the client package as vscode-languageclient does.


Improve skill Roll dices for current crew role 🔑 v2

Nice work, so in v1.802 we have:

With v1.803 we got:

Can you consider this:

Add new column (Dice pool) with dices next to Role instead of under Role, I think that this should be more readable when there are many crews, like in screen below:

This is just an idea
After update to v1.803 I realized that setback are not displayed.
Like You see in the image below, Commander Blackout has -1 setback dice to piloting skill, but there is no info about that in the new feature that you add in v1.803

Changes for this will need to be picked up in #1300

Done, will be released in 1.805.
Looks like this:

@wrycu hey, setback are still not displayed. Are you forgot about them, or it is not possible to show them?

Remove setback are not part of the actual pool, but you can file a new issue if you feel strongly about seeing them and I can look into them.


Failed to index com.github.javaparser.ast.body.(ClassOrInterfaceDeclaration|MethodDeclaration) if quarkus-poi is present

If quarkus-poi is present as a dependency, you will receive the following message:
Failed to index com.github.javaparser.ast.body.ClassOrInterfaceDeclaration: Class does not exist in ClassLoader QuarkusClassLoader:Deployment Class Loader: PROD for code-with-quarkus-1.0.0-SNAPSHOT@caa5298
Failed to index com.github.javaparser.ast.body.MethodDeclaration: Class does not exist in ClassLoader QuarkusClassLoader:Deployment Class Loader: PROD for code-with-quarkus-1.0.0-SNAPSHOT@caa5298

Reproducer

Download reproducer.zip
./gradlew clean build --rerun-tasks

Is that problematic?

This looks like a Jandex issue is there any more in the stack trace?

actually maybe a Gradle Kotlin isssue?  I only use Maven with Quarkus and have not seeing this issue it is very strange!

OK its just this class is the weird one com.github.javaparser.ast.body not sure if that is used by Quarkus or Gradle.

It looks like Gradle is using this library and leaking this into the Quarkus classloader.
Adding a dependency on
    implementation("com.github.javaparser:javaparser-core")

makes the problem go away

This could be a bug in the Quarkus Gradle Plugin though. Have you seen this @aloubyansky ?

Is this still an issue @mschorsch with Quarkus 3.16.0?

@all-contributors add @mschorsch for bug

@melloware I think it's not an issue anymore. Thanks for adding me as a contributor 👍

Nice thanks for responding @mschorsch !


IMAGING-188

https://issues.apache.org/jira/browse/IMAGING-188
commits:

support for all icns types listed on wikipedia: https://en.wikipedia.org/wiki/Apple_Icon_Image_format

support for JPEG 2000 via modified ImageIO Library, look at the new entry in the pom

test for the enhanced IcnsDecoder, plus test files (extracts images of all icns-types from several icns files)

The tests run successfully if they are run separately, but not by Jenkins. Thats why it's failing. Please review.

Closing: No reply.


Fix clicking on links where text is a code block

Apparently, if you do this syntax, e.g.:
Opened [Update TypeScript infrastructure and migrate dict.js](#11513) for review.
We generate a link formatted as a code block, which is nice, but clicking the link just opens compose, probably due to a click handler ordering/precedence issue.  See for example:
https://chat.zulip.org/#narrow/stream/65-checkins/topic/Tommy.20Ip/near/697676
This may be a bit tricky to fix, since debugging this sort of click handler ordering issue can be challenging.

@timabbott I don't think there is any bug here, as this worked for me (see gif below).
I guess why it didn't work in the thread that you have linked here is because of the incorrect link provided in the parathesis.
Try a valid link like
Opened [Zulip github](https://github.com/zulip/zulip) for review.

Try Chrome?

The link didn't get linkified

Try Chrome?

Worked for me there too.

hm, working for me on Chrome as well. (Though it sounds like the original issue is not browser-specific?)

ok, I reproed. The link has to come from a linkification filter. (Kunal, let me know if that doesn't make sense.)

@rishig Yes, a brief explanation would be helpful. :sweat_smile:
How did you reproduce the issue?

@kunal-mohta you need to setup a "Linkifier" in organization settings, and then generate a link like that.  You can get the source content for Tommy's message and copy the relevant Linkifier from chat.zulip.org's organization settings to set this up in your development environment.

I should have linked to https://zulipchat.com/help/add-a-custom-linkification-filter.

The issue is not specific to links with text as code blocks, it is purely related to the linkifier

The problem is the realm filter is expanded before the link, so at some point in the renderer the markdown is transformed into
[some text](#123)

@zulipbot claim

@aero31aero FYI since this is a markdown processor ordering bug.

Interesting. I believe this was present before the recent changes to ordering as well. It shouldn't be too hard to fix.
@zulipbot claim

You can chat with Tommy and collaborate -- he might benefit from your context.

Ok so I fixed the frontend markdown. My solution is a bit of a hack :grimacing: since I got round the ordering problem by replacing the realm filter with a marker before rendering and inserting the link afterwards.
@aero31aero would you mind reviewing my PR?


Feature: Type definition file with dependencies

Make external tokens referenced in import statements.
This allows us to understand the dependencies of CSS Modules files simply by parsing the type definition file.
This is an important milestone for implementing stylelint rules to detect unused css rulesets in TypeScript code !! :exploding_head:

solved by https://github.com/mizdra/happy-css-modules/pull/121


Not Working Redmi Note 10 Pro

Sir i hope you can fix it, It's not working on my Redmi Note 10 Pro now i just updated my device to MIUI <IP_ADDRESS> EU ROM (Android 12) it was working before on my previous MIUI 13.0.13 Version.

Hmm I dont have a MIUI to test, was there a big change from 13.0.13 version to <IP_ADDRESS>?

Unfortunately it doesn't work for me either.  I have Redmi Note 10 Pro , firmware CrDroid 9.2 Android 13, build date Mon Feb 20 01:41:03 IST 2023. Reinstalling the module did not help. I will be very happy if you fix this error.


OCM-140 | chore : reverting IMDSv2

Reverting this change for now to reduce scope on a critial release for summit. Will enable after release
JIRA : https://issues.redhat.com/browse/OCM-140
//cc @tsorya

/lgtm

/lgtm


Console spam is really annoying

While it can be useful to know if anything goes wrong and so on, I really miss a simple verbosity toggle. Whenever I work on my laptop (which does not have a streamdeck connected) the console is flooded with annoying messages.

Also thanks for this package, it is super helpful :)

You can disable that in the Module settings.

Hi,
What spamming messages are you referring to? The connected and disconnected messages?
I could provide an option to disable those messages, but whenever Unity recompiles scripts it closes the connection and reopens, that is something I can't change is the way the engine works... Those messages are only logged so you as a user know if you are or not connected to the stream deck. If not them pressing actions will do nothing.
I will release a new update in a few days, finishing things up right now.

Here's what I'm talking about :) So many messages simply when entering play mode, and it just keeps trying to reconnect :) Just a simple preference toggle to configure verbosity would be excellent!
And yeah I definitely think it is the right approach to have the messages enabled by default, but in situations like mine where I work on two different setups where only one has a streamdeck connected it would be nice if I could just set an EditorPref bool to mute the messages since I know it's never gonna connect to a streamdeck!

I will add an option (editor pref) to disable the Stream Deck integration.
Entering play mode doesn't affect the connection, the problem in your case is that since one setup doesn't have the Stream Deck Software and plugin installed there's no server to connect.
Thank you.

Great, Thanks :) and again thanks for the integration at all

Done! Will be released in the next few days.

Awesome! My console will be happy ;)
Great work

The new update was released, there are some new features but it won't work until I update the stream deck plugin.


Paragraph Justifications

Thank you for the theme, it is great.
The problem with paragraph justification in style settings should not justify code blocks. I cannot think of any other elements that should not justify, but maybe better isolate it per element?
Happy holidays!

The new version has fixed this issue. You can try updating it.


Java.Lang.IllegalStateException: 'CameraDevice was already closed' on Android

In the Android environment, Quickly and repeatedly calling StartCameraAsync()/StopCameraAsync() while adding/removing a CameraView to the parent will result in a Java.Lang.IllegalStateException: 'CameraDevice was already closed' exception.

Stacktrace

 	0xFFFFFFFFFFFFFFFF in Android.Runtime.JNIEnv.monodroid_debugger_unhandled_exception	C#
 	0x1A in Android.Runtime.JNINativeWrapper._unhandled_exception at /Users/runner/work/1/s/xamarin-android/src/Mono.Android/Android.Runtime/JNINativeWrapper.g.cs:12,5	C#
 	0x1E in Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PPL_V at /Users/runner/work/1/s/xamarin-android/src/Mono.Android/Android.Runtime/JNINativeWrapper.g.cs:122,26	C#
 	0x17 in System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw	C#
 	0x69 in Java.Interop.JniEnvironment.InstanceMethods.CallObjectMethod at /Users/runner/work/1/s/xamarin-android/external/Java.Interop/src/Java.Interop/obj/Release/net7.0/JniEnvironment.g.cs:11524,5	C#
 	0x26 in Java.Interop.JniPeerMembers.JniInstanceMethods.InvokeAbstractObjectMethod at /Users/runner/work/1/s/xamarin-android/external/Java.Interop/src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods_Invoke.cs:848,6	C#
 	0x29 in Android.Hardware.Camera2.CameraDeviceInvoker.CreateCaptureRequest at /Users/runner/work/1/s/xamarin-android/src/Mono.Android/obj/Release/net7.0/android-33/mcw/Android.Hardware.Camera2.CameraDevice.cs:756,5	C#
 	0x14B in Camera.MAUI.Platforms.Android.MauiCameraView.StartPreview	C#
 	0x15 in Camera.MAUI.Platforms.Android.MauiCameraView.MyCameraStateCallback.OnOpened	C#
 	0x11 in Android.Hardware.Camera2.CameraDevice.StateCallback.n_OnOpened_Landroid_hardware_camera2_CameraDevice_ at /Users/runner/work/1/s/xamarin-android/src/Mono.Android/obj/Release/net7.0/android-33/mcw/Android.Hardware.Camera2.CameraDevice.cs:161,5	C#
 	0x9 in Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PPL_V at /Users/runner/work/1/s/xamarin-android/src/Mono.Android/Android.Runtime/JNINativeWrapper.g.cs:121,5	C#

Have you got any solution? I am also faciing same issue.

You can try my pull (https://github.com/hjam40/Camera.MAUI/pull/107). It should have resolved almost all the crashes.

I've run into this problem as well. My "solution" was to disable the AutoStartPreview

@justinswork Is Default value of AutoStartPreview is true? When are you setting the AutoStartPreview to false?
Could you please share some piece of code. I am getting this crash in production
@hjam40 Could you please add some fix to it and its been parked here for a long time
Thanks in advance :)


Got this error while running flutter doctor

The error stack is :
Exception: Bad UTF-8 encoding (U+FFFD; REPLACEMENT CHARACTER) found while decoding string: [
{
"instanceId": "037621c3",
"installDate": "2022-05-16T10:32:57Z",
"installationName": "VisualStudio/17.2.0+32505.173",
"installationPath": "C:\Program Files\Microsoft Visual Studio\2022\Community",
"installationVersion": "17.2.32505.173",
"productId": "Microsoft.VisualStudio.Product.Community",
"productPath": "C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\devenv.exe",
"state":<PHONE_NUMBER>,
"isComplete": true,
"isLaunchable": true,
"isPrerelease": false,
"isRebootRequired": false,
"displayName": "Visual Studio Community 2022",
"description": "IDE puissant, gratuit pour les �tudiants, les contributeurs open source et les particuliers",
"channelId": "VisualStudio.17.Release",
"channelUri": "https://aka.ms/vs/17/release/channel",
"enginePath": "C:\Program Files (x86)\Microsoft Visual
Studio\Installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service",
"installedChannelUri": "https://aka.ms/vs/17/release/channel",
"releaseNotes": "https://docs.microsoft.com/en-us/visualstudio/releases/2022/release-notes-v17.2#17.2.0",
"thirdPartyNotices": "https://go.microsoft.com/fwlink/?LinkId=661288",
"updateDate": "2022-05-16T10:32:57.4307138Z",
"catalog": {
"buildBranch": "d17.2",
"buildVersion": "17.2.32505.173",
"id": "VisualStudio/17.2.0+32505.173",
"localBuild": "build-lab",
"manifestName": "VisualStudio",
"manifestType": "installer",
"productDisplayVersion": "17.2.0",
"productLine": "Dev17",
"productLineVersion": "2022",
"productMilestone": "RTW",
"productMilestoneIsPreRelease": "False",
"productName": "Visual Studio",
"productPatchVersion": "0",
"productPreReleaseMilestoneSuffix": "7.0",
"productSemanticVersion": "17.2.0+32505.173",
"requiredEngineVersion": "3.2.2146.50370"
},
"properties": {
"campaignId": "2030:471faeb5-928e-4ff9-9dab-f04c0c285d39",
"channelManifestId": "VisualStudio.17.Release/17.2.0+32505.173",
"nickname": "",
"setupEngineFilePath": "C:\Program Files (x86)\Microsoft Visual Studio\Installer\setup.exe"
}
}
]
.


move github runner from macos-12 to macos-14

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

[ ] I have read the contributing guide and understand what's expected of me
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

Two more:
https://github.com/dbt-labs/dbt-snowflake/blob/1d299923e34c96f2e96a5215ac196658f86ce1d1/.github/scripts/integration-test-matrix.js#L47
https://github.com/dbt-labs/dbt-snowflake/blob/1d299923e34c96f2e96a5215ac196658f86ce1d1/.github/scripts/integration-test-matrix.js#L81


Do you have a more detailed BOM for the USB-Powered-RCA-Classic?

Do you have a more detailed BOM for the USB-Powered-RCA-Classic?
I don't seem be able to find the correct parts, or even parts for it at all.

I can look at that to see if the parts can be more easily identified.
Although, we are about to finish a new USB C PD Power Board that will be a
lot better than this board.
The biggest issue with USB C is it allows for 4.75v to 5.75 volts and is
still considered in spec.
The NES does not like voltages under or over 5.0 - 5.1 volts so it's very
hit and miss with all the different power bricks out there.
With the USB-C PD design, we are hitting 5.07 volts perfectly, even under a
2 amp load.
Hoping to have this ready for release in the next 4 weeks,  you can shoot
me an email if you would like more information on this.
Thanks,
-Merlin Shaw
On Sun, Mar 31, 2024 at 6:14 AM AlbertVDS @.***> wrote:

Do you have a more detailed BOM for the USB-Powered-RCA-Classic?
I don't seem be able to find the correct parts, or even parts for it at
all.
—
Reply to this email directly, view it on GitHub
https://github.com/ShawMerlin/NES-Power-Module-Redesign/issues/16, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQZJHHU46TLU552QIOSVOJLY274YPAVCNFSM6AAAAABFQLYCYSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTMOJTHE4DCMI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Would be great if you could, because I already have the PCBs. 😅
Though if you think it's a better choice to just get the update version, then I might just do that.

I still have extra parts for these boards.  Please send me an email and I will provide the parts for you.

I have added website links to the parts on the BOM list.  I checked LCSC and all parts are available.


Numbering and Comment Field

If there would be a numbering of blog entries, there
were a advantage to see if a new blog ist inserted succesfully.
e.g.
1   blogname a         100 200
2   blogname a         400 800
...
If there could be one comment-field for the user this would be convenient.
e.g
1   blogname a         100 200       see next week
2   blogname a         400 800       bl a is better

TumblThree already has a comment field ("personal notes") for blogs. You might have to make it visible by right-clicking on the header row if you don't see it.
The advantage of a numbering I don't get. Especially as newly added blogs are added to the end of the list by default. You just have to scroll the list down a bit if the end is out of view. Later you could sort the list by "Date added".

The issue has been closed. You can still comment. Feel free to ask for reopening the issue if needed.


Indents are not working well

I runned the following test case:
a := 76547
if a > 39:
 print 'hi'
else:
 print 'bye'
print 'done'

Output:
  File "...", line 49, in <module>
    compiled_code = Compile(lines)
  File "...", line 267, in Compile
    while indent_level != scope_stack[len(scope_stack)-1].indent_level:
IndexError: list index out of range

Its not solved still its creating trouble.

I got to know the problem as we are trying to migrate from C/C++ so to handle indents we couldn't apply same method since now concepts are quite different.


New script: Dump/replace storage1.raw, storage2.raw

For instance, for editing Video in motion:
DS_Velocity_Threshold= in storage1.raw and storage2.raw determines the thresholds for video in motion.

Nice job!!!


vue 2.4.3 ssr auto inject critical CSS doesn't work, version 2.4.2 is work

2.4.2 SSR html

2.4.3 SSR html

when i locked package.json vue version 2.4.2  it is work . but 2.4.3 is not


openttd-jgrpp: 0.57.0 -> 0.57.1

Description of changes
https://github.com/JGRennison/OpenTTD-patches/blob/jgrpp-0.57.1/jgrpp-changelog.md#v0571-2024-02-04
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 287320 run on x86_64-linux 1

1 package built:

openttd-jgrpp


Hogyan gondolkozz úgy, mint egy informatikus:Tanulás Python 3 segítsé…

…gével python book added to list of Hungarian programming books.
Hacktoberfest notes:

due to volume of submissions, we may not be able to review PRs that do not pass tests and do not have informative titles.
please read our contributing guidelines
be sure to check the output of Travis-CI for linter errors
if this is your first open source contribution, make sure it's not your last!

What does this PR do?
Add Resource(s) | Remove Resource(s) | Add info | Improve Repo
Add Resource
For resources
Description
It adds freely available Hungarian translation of a Python book that is an excellent resource for beginners.
Why is this valuable (or not)?
It is good for beginners. The book teaches the reader the basics of Python and how to think like a software developer.
How do we know it's really free?
Universities made this book available freely. The English version is available freely as well here: https://www.ict.ru.ac.za/Resources/cspw/thinkcspy3/thinkcspy3/
For book lists, is it a book? For course lists, is it a course? etc.
It is a book.
Checklist:

[ x] Not a duplicate
[ x] Included author(s) if appropriate
[ x] Lists are in alphabetical order
[x ] Needed indications added (PDF, access notes, under construction)

Thanks, and welcome to free-programming-books!


Cell editor positioning issue when table is inside pack.

I have a table inside of an hpack. When editing a cell, the cell editor shows in the next hpack position (right side of screenshot) instead of on top/inside of the original cell where it should be.

Hello
Thanks for the report. Can you try updating to 0.3.3, I've pushed a fix and published a new version.

Thanks for the quick update!
Unfortunately, I am still noticing issues where the rendering for the editing mode does not happen at all, or is very sporadic. Attached are recordings of a table not in a pack and in a pack. I am unable to get the editor mode to show at all inside a pack.
No pack:
https://github.com/user-attachments/assets/af4b1410-d085-4bf1-b93b-bb9ef0c10dd1
Pack:
https://github.com/user-attachments/assets/4f341fa6-5d37-4c32-950f-33eecba24b1d

Thanks for getting back to me quickly. I’ll try to look deeply into the issue tomorrow and over the weekend 👍

Can you try with the latest master:
[patch.crates-io]
fltk-table = { git = "https://github.com/fltk-rs/fltk-table" }

This version is working as expected both in and out of a pack. Everything is working well.
Thank you!


Replace "sanity check" in  doc comments.

Per current Apple Style Guide https://help.apple.com/applestyleguide/#/apsge70df12b?sub=apd57d1e8d9c
Resolves rdar://65958589

@swift-ci Please smoke test.

I also considered "correctness check" as a replacement.  Nate, does one of these seem significantly better to you?

I think "consistency check" maintains the meaning most accurately – great change! 👏🏻


Actor Hadrian assigned to wrong quest faction

Crew_Elite_Hadrian "Hadrian" [NPC_:0029C17F]
has been incorrectly asigned to ConstellationFaction [FACT:000191DC]
rather than CrimeFactionUC "United Colonies" [FACT:0005BD93] appropriate for the UC quest line.
Noticed when creating faction kickout handlers.

Details
read summary
Game Version
<IP_ADDRESS>
Language
English (EN)
New Game
Yes
Reproduction Steps
Look at Crew_Elite_Hadrian "Hadrian" [NPC_:0029C17F]  in xEdit
Notice how "referenced by" is UC quests not MQ quests.

Ingame fix:
Actor Crew_Elite_Hadrian = Game.GetFormFromFile(0x002B17C4, "starfield.esm") as Actor
Faction ConstellationFaction  = Game.GetFormFromFile(0x000191DC, "starfield.esm") as Faction
Faction CrimeFactionUC = Game.GetFormFromFile(0x0005BD93, "starfield.esm") as Faction
Crew_Elite_Hadrian.RemoveFromfaction(ConstellationFaction)
Crew_Elite_Hadrian.AddToFaction(CrimeFactionUC)


Unable to use icons with rollup

When using material-ui/icons with rollup I have the following error:
Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: object.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Here is my rollup config:
import babel from "@rollup/plugin-babel";
import resolve from "@rollup/plugin-node-resolve";
import commonjs from "@rollup/plugin-commonjs";
import serve from "rollup-plugin-serve";
import { extensions } from "../rollup.config";
import replace from "@rollup/plugin-replace";
import json from "@rollup/plugin-json";
import { terser } from "rollup-plugin-terser";

const production = !process.env.ROLLUP_WATCH;

const replacements = {
  "process.env.NODE_ENV": JSON.stringify(
    production ? "production" : "development"
  ),
  "process.env.WS_API": JSON.stringify(process.env.WS_API || null),
  "process.env.HTTP_API": JSON.stringify(process.env.HTTP_API || null),
};

export default [
  {
    input: "public/src/index.tsx",
    output: {
      file: "public/dist/index.umd.js",
      format: "umd",
      name: "picnicSDK",
      sourcemap: true, // TODO: remove sourcemap on prod
      globals: {
        react: "React",
        "react-dom": "ReactDOM",
        "react-router-dom": "ReactRouterDOM",
      },
    },
    external: ["react", "react-dom"],
    plugins: [
      resolve({
        extensions,
        browser: true,
        preferBuiltins: false,
      }),
      commonjs(),
      postcss({
        plugins: [],
        minimize: true,
        sourceMap: "inline",
      }),
      // Allows node_modules resolution
      replace(replacements),
      babel({
        exclude: "node_modules/**", // only transpile our source code,
        babelHelpers: "bundled",
        extensions,
        presets: [
          "@babel/preset-typescript",
          "@babel/preset-react",
          [
            "@babel/preset-env",
            {
              modules: false,
              targets: production
                ? {
                    chrome: 55,
                    edge: 11,
                    firefox: 60,
                    safari: 11,
                    node: "12.18",
                  }
                : {
                    browsers: "last 2 chrome versions",
                  },
            },
          ],
        ],
        plugins: production ? ["@babel/plugin-proposal-class-properties"] : [],
      }),
      production
        ? terser()
        : serve({
            open: true,
            host: "<IP_ADDRESS>",
            contentBase: ["public"],
            historyApiFallback: true,
            port: 4000,
          }),
    ],
  },
];

Used with the following index.html
<!doctype html>

  <meta charset="utf-8">
  <meta name="viewport" content="minimum-scale=1, initial-scale=1, width=device-width">
  <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500,700&display=swap" />
  <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons" />

@moroine Why would it be an issue with Material-UI and not the configuration of rollup?

@oliviertassinari thanks for your answer.
Yeah, you're right it's a rollup config issue, but I think this is related to material-ui because it would be nice to have in the doc or at least in github issue tips on how to integrate with rollup.
I found the issue after a good sleep.
The issue was due to using import MicOff from "@material-ui/icons/MicOff"; imports style. This was leading to react import not detected by rollup & causing React to be included in the build instead of being external. So React checks for valid node type using symbol, they didn't match.
The solution was to import like import { MicOff } from "@material-ui/icons". I check the bundle size compare to @material-ui/icons/esm/MicOff and it's the same because rollup is able to do tree-shaking thanks to sideEffects: false & module: ./esm/index.js flags in packages.json.
As a reference here is my final config:
import babel from "@rollup/plugin-babel";
import resolve from "@rollup/plugin-node-resolve";
import commonjs from "@rollup/plugin-commonjs";
import serve from "rollup-plugin-serve";
import { extensions } from "../rollup.config";
import replace from "@rollup/plugin-replace";
import json from "@rollup/plugin-json";
import { terser } from "rollup-plugin-terser";

const production = !process.env.ROLLUP_WATCH;

const replacements = {
  "process.env.NODE_ENV": JSON.stringify(
    production ? "production" : "development"
  ),
  "process.env.WS_API": JSON.stringify(process.env.WS_API || null),
  "process.env.HTTP_API": JSON.stringify(process.env.HTTP_API || null),
};

export default [
  {
    input: "public/src/index.tsx",
    output: {
      file: "public/dist/index.umd.js",
      format: "umd",
      name: "picnicSDK",
      sourcemap: true, // TODO: remove sourcemap on prod
      globals: {
        react: "React",
        "react-dom": "ReactDOM",
        "react-router-dom": "ReactRouterDOM",
      },
    },
    external: ["react", "react-dom"],
    plugins: [
      resolve({
        extensions,
        browser: true,
        preferBuiltins: false,
      }),
      commonjs(),
      json(),
      babel({
        exclude: "node_modules/**", // only transpile our source code,
        babelHelpers: "bundled",
        extensions,
        presets: [
          "@babel/preset-typescript",
          "@babel/preset-react",
          [
            "@babel/preset-env",
            {
              modules: false,
              targets: production
                ? {
                    chrome: 55,
                    edge: 11,
                    firefox: 60,
                    safari: 11,
                    node: "12.18",
                  }
                : {
                    browsers: "last 2 chrome versions",
                  },
            },
          ],
        ],
        plugins: production ? ["@babel/plugin-proposal-class-properties"] : [],
      }),
      // Allows node_modules resolution
      replace(replacements),
      production
        ? terser()
        : serve({
            open: true,
            host: "<IP_ADDRESS>",
            contentBase: ["public"],
            historyApiFallback: true,
            port: 4000,
          }),
    ],
  },
];

Awesome, thanks for sharing the solution. Hopefully, it's enough for the other developers that will search the history :)