FrozenLib & Wilder Wild compatibility

For implementation, I added a new method transformation. It is just a copy of ModifyInjectionPoint with ordinal support. I submitted a PR to Adapter for this, can be replaced with the content from that PR when merged.
Closes #40
Also fixes compatibility with Configurable Everything and newer versions of Simple Copper Pipes
Works with Wilder Wild 2.1.10+
For the most part works, only compatibility issue left is the ModifyArgs lvt patch thingy

so far I’ve gotten rid of the issue in #40 but there’s still other existing compatibility issues
Ex
WW uses a ModifyArgs in LiquidBlockRenderer.tesselate on LiquidBlockRenderer.vertex
I believe it just has one more float parameter, alpha somewhere around index 7 (idk for sure)
I am not very familiar with patches. Is there anything that can patch this?

What is the exact error? Adapter should be able to handle simple LVT changes

What is the exact error? Adapter should be able to handle simple LVT changes

heres ww source for reference
@ModifyArgs(method = "tesselate", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/renderer/block/LiquidBlockRenderer;vertex(Lcom/mojang/blaze3d/vertex/VertexConsumer;DDDFFFFFI)V", ordinal = 8))
	private void wilderWild$sideTextureBottom1(Args args) {
		if (this.wilderWild$isWater) {
			this.wilderWild$u0 = this.waterOverlay.getU0();
			this.wilderWild$u1 = this.waterOverlay.getU1();
			this.wilderWild$v0 = this.waterOverlay.getV0();
			this.wilderWild$v1 = this.waterOverlay.getV1();
			args.set(7, this.wilderWild$u0);
			args.set(8, this.wilderWild$v1);
		}
	}

here
its not very descriptive though
org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {}
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:250) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {}
	at org.spongepowered.asm.service.modlauncher.MixinTransformationHandler.processClass(MixinTransformationHandler.java:131) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {}
	at org.spongepowered.asm.launch.MixinLaunchPluginLegacy.processClass(MixinLaunchPluginLegacy.java:131) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {}
	at cpw.mods.modlauncher.serviceapi.ILaunchPluginService.processClassWithFlags(ILaunchPluginService.java:156) ~[modlauncher-10.0.9.jar:10.0.9+10.0.9+main.dcd20f30] {}
	at cpw.mods.modlauncher.LaunchPluginHandler.offerClassNodeToPlugins(LaunchPluginHandler.java:88) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.ClassTransformer.transform(ClassTransformer.java:120) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.TransformingClassLoader.maybeTransformClassBytes(TransformingClassLoader.java:50) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.cl.ModuleClassLoader.readerToClass(ModuleClassLoader.java:113) ~[securejarhandler-2.1.10.jar:?] {}
	at cpw.mods.cl.ModuleClassLoader.lambda$findClass$15(ModuleClassLoader.java:219) ~[securejarhandler-2.1.10.jar:?] {}
	at cpw.mods.cl.ModuleClassLoader.loadFromModule(ModuleClassLoader.java:229) ~[securejarhandler-2.1.10.jar:?] {}
	at cpw.mods.cl.ModuleClassLoader.findClass(ModuleClassLoader.java:219) ~[securejarhandler-2.1.10.jar:?] {}
	at cpw.mods.cl.ModuleClassLoader.loadClass(ModuleClassLoader.java:135) ~[securejarhandler-2.1.10.jar:?] {}
	at java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?] {}
	at net.minecraft.client.renderer.block.BlockRenderDispatcher.<init>(BlockRenderDispatcher.java:41) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:APP:fabric-resource-loader-v0.client.mixins.json:KeyedResourceReloadListenerClientMixin from mod (unknown),pl:mixin:A,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.<init>(Minecraft.java:499) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:A,pl:runtimedistcleaner:A}
	at net.minecraft.client.main.Main.main(Main.java:182) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {}
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {}
	at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:111) ~[fmlloader-1.20.1-47.1.3.jar:?] {}
	at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:99) ~[fmlloader-1.20.1-47.1.3.jar:?] {}
	at net.minecraftforge.fml.loading.targets.ForgeClientUserdevLaunchHandler.devService(ForgeClientUserdevLaunchHandler.java:19) ~[fmlloader-1.20.1-47.1.3.jar:?] {}
	at net.minecraftforge.fml.loading.targets.CommonDevLaunchHandler.lambda$makeService$7(CommonDevLaunchHandler.java:135) ~[fmlloader-1.20.1-47.1.3.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:108) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:78) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) ~[bootstraplauncher-1.1.2.jar:?] {}
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Multi-argument modifier method wilderWild$sideTextureBottom1(Lorg/spongepowered/asm/mixin/injection/invoke/arg/Args;)V in wilderwild.mixins.json:client.general.LiquidBlockRendererMixin from mod (unknown) failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap mixins.wilderwild.refmap.json
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {}
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1384) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {}
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1062) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {}
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:402) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {}
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {}
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {}
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {}
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {}
	... 32 more```

Any idea on how something like this could be fixed?

actually
the lvt changes arent getting applied probably because its a ModifyArgs
i believe this is going to require ModifyArgs to be handled in the lvt patch you were referring to

Using this build
its able to get in game, but crashes when opening the inventory
that build is the same just with that renderer mixin disabled
net.minecraftforge.fml.ModLoadingException: Fabric Item Group API (v1) (fabric_item_group_api_v1) encountered an error during the done event phase
�7java.lang.NullPointerException: Cannot invoke "net.minecraft.world.level.ItemLike.asItem()" because "anchor" is null
	at net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:111) ~[javafmllanguage-1.20.1-47.1.3.jar:?] {}
	at net.minecraftforge.fml.ModLoader.lambda$postEvent$29(ModLoader.java:326) ~[fmlcore-1.20.1-47.1.3.jar:?] {}
	at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?] {re:mixin}
	at net.minecraftforge.fml.ModList.forEachModInOrder(ModList.java:227) ~[fmlcore-1.20.1-47.1.3.jar:?] {}
	at net.minecraftforge.fml.ModLoader.postEvent(ModLoader.java:326) ~[fmlcore-1.20.1-47.1.3.jar:?] {}
	at net.minecraftforge.client.ForgeHooksClient.onCreativeModeTabBuildContents(ForgeHooksClient.java:1212) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:mixin,re:classloading,pl:mixin:APP:connectormod.mixins.json:ForgeHooksClientMixin from mod (unknown),pl:mixin:A}
	at net.minecraft.world.item.CreativeModeTab.buildContents(CreativeModeTab.java:129) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B,xf:fml:connectormod:injectCreativeModeTabCtr,re:mixin,pl:accesstransformer:B,xf:fml:connectormod:injectCreativeModeTabCtr}
	at net.minecraft.world.item.CreativeModeTabs.lambda$buildAllTabContents$50(CreativeModeTabs.java:1696) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B}
	at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183) ~[?:?] {}
	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179) ~[?:?] {}
	at java.util.Iterator.forEachRemaining(Iterator.java:133) ~[?:?] {re:mixin}
	at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845) ~[?:?] {}
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?] {}
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?] {}
	at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150) ~[?:?] {}
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173) ~[?:?] {}
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?] {}
	at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596) ~[?:?] {}
	at net.minecraft.world.item.CreativeModeTabs.buildAllTabContents(CreativeModeTabs.java:1695) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.item.CreativeModeTabs.tryRebuildTabContents(CreativeModeTabs.java:1710) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.client.gui.screens.inventory.CreativeModeInventoryScreen.<init>(CreativeModeInventoryScreen.java:86) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:APP:connectormod.mixins.json:CreativeModeInventoryScreenMixin from mod (unknown),pl:mixin:A,pl:runtimedistcleaner:A}
	at net.minecraft.client.gui.screens.inventory.InventoryScreen.init(InventoryScreen.java:48) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.client.gui.screens.Screen.init(Screen.java:321) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:computing_frames,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:fabric-screen-api-v1.mixins.json:ScreenAccessor from mod (unknown),pl:mixin:APP:fabric-screen-api-v1.mixins.json:ScreenMixin from mod (unknown),pl:mixin:A,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.setScreen(Minecraft.java:1007) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:A,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.handleKeybinds(Minecraft.java:1928) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:A,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.tick(Minecraft.java:1795) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:A,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1112) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:A,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.run(Minecraft.java:718) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:A,pl:runtimedistcleaner:A}
	at net.minecraft.client.main.Main.main(Main.java:218) ~[forge-1.20.1-47.1.3_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A}
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {}
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {}
	at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:111) ~[fmlloader-1.20.1-47.1.3.jar:?] {}
	at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:99) ~[fmlloader-1.20.1-47.1.3.jar:?] {}
	at net.minecraftforge.fml.loading.targets.ForgeClientUserdevLaunchHandler.devService(ForgeClientUserdevLaunchHandler.java:19) ~[fmlloader-1.20.1-47.1.3.jar:?] {}
	at net.minecraftforge.fml.loading.targets.CommonDevLaunchHandler.lambda$makeService$7(CommonDevLaunchHandler.java:135) ~[fmlloader-1.20.1-47.1.3.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:108) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:78) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) ~[modlauncher-10.0.9.jar:?] {}
	at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) ~[bootstraplauncher-1.1.2.jar:?] {}
Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.world.level.ItemLike.asItem()" because "anchor" is null
	at net.fabricmc.fabric.api.itemgroup.v1.FabricItemGroupEntries.addBefore(FabricItemGroupEntries.java:462) ~[fabric-item-group-api-v1-4.0.11+369cb3a477.jar%23255!/:4.0.11+369cb3a477] {re:classloading}
	at net.fabricmc.fabric.api.itemgroup.v1.FabricItemGroupEntries.addBefore(FabricItemGroupEntries.java:323) ~[fabric-item-group-api-v1-4.0.11+369cb3a477.jar%23255!/:4.0.11+369cb3a477] {re:classloading}
	at net.frozenblock.lib.item.api.FrozenCreativeTabs.lambda$addBefore$1(FrozenCreativeTabs.java:74) ~[WilderWild-2.1.7-Fabric+1.20.1$frozenlib-1.3.12-mc1.20.1_mapped_mcp_1.20.1.jar%23306!/:?] {re:classloading}
	at net.fabricmc.fabric.impl.itemgroup.ItemGroupEventsImpl.lambda$createModifyEvent$1(ItemGroupEventsImpl.java:53) ~[fabric-item-group-api-v1-4.0.11+369cb3a477.jar%23255!/:4.0.11+369cb3a477] {re:classloading}
	at net.fabricmc.fabric.impl.itemgroup.ItemGroupEventsImpl.onCreativeModeTabBuildContents(ItemGroupEventsImpl.java:80) ~[fabric-item-group-api-v1-4.0.11+369cb3a477.jar%23255!/:4.0.11+369cb3a477] {re:classloading}
	at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:260) ~[eventbus-6.0.5.jar:?] {}
	at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:252) ~[eventbus-6.0.5.jar:?] {}
	at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.5.jar:?] {}
	at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.5.jar:?] {}
	at net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:107) ~[javafmllanguage-1.20.1-47.1.3.jar:?] {}
	... 44 more

was able to just fix all the errors in frozenlib and wilder wild themselves
although
the modify args thing will still need to be fixed, but i just set it to not crash the game

only works with WW 2.1.7+
gameplay should be fine
screenshot of wilder wild + cracker's wither storm mod

actually theres one issue left
ill fix it tmr

seems somewhat simple to fix
should just be an easy param addition
[15Oct2023 22:34:43.031] [Render thread/WARN] [mixin/]: Injection warning: LVT in net/minecraft/server/level/ServerPlayerGameMode::m_7179_(Lnet/minecraft/server/level/ServerPlayer;Lnet/minecraft/world/level/Level;Lnet/minecraft/world/item/ItemStack;Lnet/minecraft/world/InteractionHand;Lnet/minecraft/world/phys/BlockHitResult;)Lnet/minecraft/world/InteractionResult; has incompatible changes at opcode 126 in callback mixin/frozenlib.tag.mixins.json:ServerPlayerGameModeMixin from mod (unknown)->@Inject::frozenLib$useItemOn(Lnet/minecraft/server/level/ServerPlayer;Lnet/minecraft/world/level/Level;Lnet/minecraft/world/item/ItemStack;Lnet/minecraft/world/InteractionHand;Lnet/minecraft/world/phys/BlockHitResult;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;Lnet/minecraft/core/BlockPos;Lnet/minecraft/world/level/block/state/BlockState;Lnet/minecraftforge/event/entity/player/PlayerInteractEvent$RightClickBlock;Z)V.
 Expected: [Lnet/minecraft/core/BlockPos;, Lnet/minecraft/world/level/block/state/BlockState;, Lnet/minecraftforge/event/entity/player/PlayerInteractEvent$RightClickBlock;, Z]
    Found: [Lnet/minecraft/core/BlockPos;, Lnet/minecraft/world/level/block/state/BlockState;, Lnet/minecraftforge/event/entity/player/PlayerInteractEvent$RightClickBlock;, Lnet/minecraft/world/item/context/UseOnContext;]
Available: [Lnet/minecraft/core/BlockPos;, Lnet/minecraft/world/level/block/state/BlockState;, Lnet/minecraftforge/event/entity/player/PlayerInteractEvent$RightClickBlock;, Lnet/minecraft/world/item/context/UseOnContext;, Z]

Hm, that should get automatically patched by adapter, I'll see what's wrong there

Okay, I tested running Wilder Wild version 2.1.9 on the latest Connector dev build, and I've run into the frozenlib AxeItem mixin conflict plus a registry freeze bug in Connector, which has now been fixed. So in the end, the only remaining conflict is the AxeItem mixin. Could you try again using the latest revision?

I tested newest changes with WW 2.1.9 and adapter pull request done by Treetrain1 and seems like it is working just fine. There is no issue with AxeItem mixin.

So far my testing results are great, but I’d like to do further testing before this is merged.
I’ve implemented a mixin config in a work in progress version of Wilder Wild and have refactored a lot of mixins, so I want to make sure this also works with that version just in case it for some reason doesn’t.
It should still work but I want to be 100% sure.
I’ll mark this PR as ready for review once I’ve tested and released that version.

Works with the latest version of Wilder Wild (2.1.10)!

i believe this is in a merge ready state
up to you ig

Thanks for taking care of this on your side as well. I've tried running Wilder Wild on the current version of connector, and it seems like it work out of the box. Is the patch to AxeItem's mixin still necessary in that case?

Thanks for taking care of this on your side as well. I've tried running Wilder Wild on the current version of connector, and it seems like it work out of the box. Is the patch to AxeItem's mixin still necessary in that case?

Oh, that's strange
I feel like that patch may still be necessary
because i havent seen anything that could automatically fix the ordinal of the injection point

Hm, I have an idea on how to patch that dynamically, though it relies on having access to unpatched mc files, which shouldn't be a problem in forge.

Okay that should do. I've added a dynamic patch that can analyze all method calls for the @At target and correct the injection point ordinal based on the target's surrounding instructions, eliminating the need to add a hardcoded patch with a fixed number offset.
I believe the modifyargs mixins you've mentioned still need fixing though.

Okay that should do. I've added a dynamic patch that can analyze all method calls for the @At target and correct the injection point ordinal based on the target's surrounding instructions, eliminating the need to add a hardcoded patch with a fixed number offset.
I believe the modifyargs mixins you've mentioned still need fixing though.

i dont think that works with the axe item mixin
either that or it causes another issue that causes the game to crash
it just crashes after this point now

Sorry, seems like registry bootstrap/freeze timing got messed up again. Can you try using this dev build?

Fully works in beta 21
I'll close this PR now that its fixed

Nice, thanks for fixing some of the issues on your end as well, appreciated!

i like how the same day this was fixed wilder wilds updated and that update does not work with connector
:|


Compiled Windows executable isn't running

I've been able to compile PHP8.2 on a Windows GitHub Action 🎉
However, when I then try to use it on a Windows machine, I get the following error:

Seems that some part (I'm guessing curl?) is depending on nghttp2 but this isn't statically link.
My extension string was:
bcmath,ctype,zlib,openssl,curl,iconv,xml,dom,fileinfo,filter,mbstring,pdo,sqlite3,pdo_sqlite,session,simplexml,sockets,tokenizer

Fixed in main branch.


ci: add job to check Python code format in code-formatting workflow

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add the propConversion header to generated props

Summary:
Generated props with custom structs generates implement their own version of fromRawProps in the header file, which has to invoke fromRawProps in the framework which is not available.
This Diff adds the missing header in the generated Props.h file and updates the tests.
This should also fix [this issue] https://github.com/facebook/react-native/issues/35054.
Changelog:
[General][Fixed] - Add missing header in the Codegen for props with object types.
Differential Revision: D40674432

Closing as abandoned internally


Queue Implementation

Queue Implementation using array

@indrakishore  assign this issue to me

@indrakishore please assign this issue to me

@indrakishore can you please assign this to me. I can do it this in c++.With proper explaination .


Images in listview are loaded on click

I'm using jquery mobile lists with thumbnails, like http://jquerymobile.com/test/docs/lists/lists-thumbnails.html
The thumbnails are lazy loaded, but when I click on a list-item all thumbnails are loaded anyway. The only setting for lazyload is the threshold in this case. I'm testing this with chrome, and the intention is to get it working on Android.

It is impossible to answer the question without seeing the page where you have problem with.

Since most of the HTML is generated by JavaScript it is quite hard to debug. Maybe all images are above the fold when page load which causes them to load. I would take the unminified version of the plugin and add some console.log() sentences to see which images are below the fold when jQuery mobile generates the HTML. You could also try to use the latest version from GitHub. New parameter ´skip_invisible´ was recently introduced. This might help if jQuery mobile somehow hides images in the beginning. I really do not know internals of jQuery mobile.
I also noticed the code throws ´a.nodeName is undefined´ error.

Thanx a lot! This works now! I've updated the demo, but I will take it soon offline.

Just out of interest. How did you fix it? Other people might have the same problem in future.

Ok cool. Thanks!


Vue files as html

I mostly use VS 2017 for my development. I was getting tired of editing .vue files as text with no intellisense  or error checking (resharper). So I decided to rename my vue files as componentname.vue.html. Then in the webpack.config.js file I changed to this:
`resolve: {
extensions: ['.js', '.vue.html'],
alias: {
'vue$': 'vue/dist/vue',
'components': path.resolve(__dirname, './ClientApp/components'),
'views': path.resolve(__dirname, './ClientApp/views'),
'utils': path.resolve(__dirname, './ClientApp/utils'),
'api': path.resolve(__dirname, './ClientApp/store/api')
}
},
....
        rules: [
            { test: /\.vue.html$/, include: /ClientApp/, use: 'vue-loader' },
            { test: /\.js$/, include: /ClientApp/, use: 'babel-loader' },
            { test: /\.css$/, use: isDevBuild ? ['style-loader', 'css-loader'] : ExtractTextPlugin.extract({ use: 'css-loader' }) },
            { test: /\.(png|jpg|jpeg|gif|svg)$/, use: 'url-loader?limit=25000' }
        ]

`
Now I have full intellisense and error checking. Everything seems to be working fine. Has anyone else tried this?

I personally mix VS Code with VS2017. VS Code is quite good with VueJS + all the linting + ... etc.
However for C# nothing beat Visual Studio 2017 IDE (at the moment). After I think most of the people working with vuejs use the .vue instead of a .vue.html.

I use both as well as I think many developers do today. I am responsible for our entire system so I do a lot of back end systems, databases and utilities, for that VS 2017 shines.  I have Vetur installed in VS Code but it does not seem to work at all anymore.
I wonder if we should add .vue.html to this template so that developers can choose what they want to use. Maybe even just the webpack setup and a note in the docs about it. I have seen a lot of questions floating around the web on how to get VS 2017 to play nice with .vue files.

Guys, just install this Vue extension pack and your .vue files will give you all you expect  in VS2017, no need to tag on the .html  .... but with TYPESCRIPT there IS an issue that I filed here with MS and they have yet to act on it... so do note that (and if you have a workaround for that issue PLEASE let me know, thanks!) @WayneHiller


Remove pom element linkXRef

What is the purpose of the change
Fix the error "Element linkXRef is not allowed here" reported by Intellij IDEA  2018.1.6 (Utimate Edition).
The  linkXRef element isn't defined as parameter in the "check" goal but in the "checkstyle" goal and the "checkstyle-aggregate" goal,  according to the plugin.xml of  maven-checkstyle-plugin:3.0.0.
See https://maven.apache.org/plugins/maven-checkstyle-plugin/plugin-info.html  for details.
Brief changelog
Remove the  linkXRef element in root pom.
Verifying this change
CI passed
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #2105 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2105      +/-   ##
============================================
+ Coverage     54.13%   54.14%   +<.01%
- Complexity     5079     5080       +1
============================================
  Files           559      559
  Lines         24908    24908
  Branches       4438     4438
============================================
+ Hits          13484    13486       +2
  Misses         9387     9387
+ Partials       2037     2035       -2

Impacted Files
Coverage Δ
Complexity Δ

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
41.66% <0%> (-8.34%)
3% <0%> (ø)

...onfig/spring/extension/SpringExtensionFactory.java
78.57% <0%> (-7.15%)
10% <0%> (ø)

.../dubbo/remoting/transport/netty4/NettyChannel.java
65% <0%> (-1.25%)
22% <0%> (-1%)

.../java/org/apache/dubbo/config/ReferenceConfig.java
47.68% <0%> (+0.71%)
38% <0%> (ø)
:arrow_down:

...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java
59.16% <0%> (+0.83%)
31% <0%> (+1%)
:arrow_up:

.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java
58.94% <0%> (+1.05%)
18% <0%> (ø)
:arrow_down:

...he/dubbo/remoting/transport/netty/NettyServer.java
71.42% <0%> (+3.57%)
9% <0%> (+1%)
:arrow_up:

...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java
64.51% <0%> (+6.45%)
3% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22d18c...c4318f6. Read the comment docs.

LGTM, thanks for the pull request!


Missing triggers?

Hello, I'm referring to the part which says the extension by default has  triggers which detect following situations:
"infinity or very long redeliver"
"zero deliver rate when queue not empty"  (really looking for this trigger, don't want to setup a custom bash script to achieve the same)
In my template only three triggers are available:
Can't obtain RabbitMQ stats
RabbitMQ Memory Alarm (publishers blocked)
RabbitMQ process is NOT running
Did I miss anything during the install process?

@igorinsky Hi. Tell me a little bit more information about your installation. Have you installed RabbitMQ as a single node or you have a cluster setup?

@tears-of-noobs  Hello, It's a single node setup.

@igorinsky Did you define a macro {$GROUPNAME} on your RabbitMQ node? If not, you should do it. Read the last paragraph of the readme. In short - Zabbix will create aggregation triggers only if you define macro {$GROUPNAME} with the group name where your node was added.

Not sure if I follow you. How configured\non-configured macros can affect triggers in a template?
There are literally 3 triggers inside a template.

Aha, you've been very helpful indeed.
So it's not in triggers, but in trigger_prorotypes and it requires a {$GROUPNAME}.
Thanks!

@igorinsky Now this issue solved or not?


Conflicting string-template-indent and function-signature rules

Expected Behavior
Given the following config:
ktlint_function_signature_body_expression_wrapping = default

And the following code:
private fun buildSelectQuery(additionalWhereClause: String = "") =
    """
    SELECT
        $ID,
        $CREATED_AT,
        $CREATED_BY,
        $DELETED,
        $STATE
    FROM $SESSIONS
    WHERE $ID = :$ID
        AND $DELETED = false
        $additionalWhereClause
    """.trimIndent()

I would expect that the function-signature rule is ignored and the string-template-indent rule takes precedence. (Alternatively string-template-indent is ignored, but I feel that string-template-indent should take precedence.)
Observed Behavior
ktlint cannot format the given code, as it either violates function-signature or string-template-indent.
WARN com.pinterest.ktlint.rule.engine.api.KtLintRuleEngine -- Format was not able to resolve all violations which (theoretically) can be autocorrected in file

Steps to Reproduce
Run ktlint --format on the given snippet.
Your Environment

Version of ktlint used: 1.2.1
Relevant parts of the .editorconfig settings

max_line_length = 124
ij_kotlin_allow_trailing_comma = true
ij_kotlin_allow_trailing_comma_on_call_site = true
ij_kotlin_name_count_to_use_star_import =<PHONE_NUMBER>
ij_kotlin_name_count_to_use_star_import_for_members =<PHONE_NUMBER>

ktlint_function_signature_rule_force_multiline_when_parameter_count_greater_or_equal_than = unset
ktlint_function_signature_body_expression_wrapping = default

# as function signature body expression wrapping is set to `default` instead of `multiline`,
# then it would be inconsistent to enable multiline expression wrapping
ktlint_standard_multiline-expression-wrapping = disabled

Name and version (or code for custom task) of integration used (Gradle plugin, Maven plugin, command line, custom Gradle task): ktlint-cli 1.2.1
Version of Gradle used (if applicable):
Operating System and version: macOS 14.2.1

Tnx for reporting. This is a bug indeed.
For now you can suppress this as follows:
@Suppress("ktlint:standard:function-signature")
private fun buildSelectQuery(additionalWhereClause: String = "") =
    """
    SELECT
        $ID,
        $CREATED_AT,
        $CREATED_BY,
        $DELETED,
        $STATE
    FROM $SESSIONS
    WHERE $ID = :$ID
        AND $DELETED = false
        $additionalWhereClause
    """.trimIndent()

Thanks, that's what I did already, but I thought it's worth flagging.


Feature/cleanup

Closes https://github.com/apinf/emq-rest-api/issues/4

Please review.

Closing this in favor of https://github.com/apinf/emq-rest-api/pull/5


Unknown prop aligned on  tag

version 78.2 doesn't seem to recognize 'aligned' prop in the Tab module. do you have any version that don't have this error?

Hey, seems like your problem is using semantic-ui-react, its original semantic-ui repo.
Report your issue here: https://github.com/Semantic-Org/Semantic-UI-React

@w96k oh. sorry. will close it then. thanks


Tweaks / fixes for tests

Hi @tetron sorry I did not see this! I think however these have been fix now. Thank you!


Welcome screen

This might be a good place to start:
https://code.visualstudio.com/api/references/contribution-points#contributes.walkthroughs

Not going to worry about now


Revise installer

Staging installer for review (VPN required): https://metadeploy-stg.herokuapp.com/products/outbound-funds
Critical Changes
Changes

The Outbound Funds Module installer has been revised to match ongoing Salesforce.org branding and to prepare for localization.

Issues Closed

@SalesforceFoundation/release-engineering-reviewers Can we get a review on this PR? We need to get the metadeploy labels off to translation. Thank you.


Pipe overflow (valid transitions && verified transitions)

I failed to reproduced the pipe-overflow behavior of valid-transitions-pipe both locally and on the CI. Would  anyone please point out a log with this failure?

I notice there are two pipes named "valid transitions" as well. I'll keep an eye out for it in CI. It's possible they were overflowing for the same reason (verified transitions reader got backed up and the other processes race to fill their pipes?)

not seen in ci anymore - closing


Pulumi deploys using an old commit when DO app is set to us elatest commit on main

Describe what happened
When I deploy an app platform app with DO, the commit that's deployed in DO doesn't change. It appears to use the same commit that was last deployed. This causes issues between commits where the infrastructure & build commands have changed together, meaning that I cannot update the infrastructure with pulumi, and have to do it manually.
When I deploy (update the app) on digital ocean, the commit always updates to latest from my repo.
Sample program
I get the feeling this is a lack of understanding on my part, if it isn't and this is not intended behavior I can provide more info
Log output
N/A
Affected Resource(s)
App Platform
Output of pulumi about
N/A
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hey @douglasg14b, sorry you hit this. This is, unfortunately, a somewhat awkward bit of how pulumi and similar tools work.
Are you using the git parameter here? If so, pulumi likely doesn't "know" when you update the git repo so can't know to redeploy the app.
Looking at the digitalocean App resource you might be better off using one of github or  gitlab depending on where your source is stored with deploy_on_push. https://www.pulumi.com/registry/packages/digitalocean/api-docs/app/#appspecfunctiongithub
These should be the easiest way for you to achieve the automatic redeployment of the app.
If that doesn't work for you then you need a way to tell pulumi to check for new updates to your git repo, for example using the Github provider - you can query the repo on every deployment and add a depends_on resource option to your digital ocean App, so that when the git repo is updated, pulumi knows to redeploy your digital ocean App.

Are you using the git parameter here

I don't believe so. What is this parameter?

There may be a disconnect in what I explained, let me clarify:
Parameters:

deploy_on_push: FALSE

We don't want to allow DO autodeploy on pushes, infra might be incompatible

Lets imagine this commit history on main:

Commit 1
Commit 2
Commit 3

Lets say the currently deployed version of the DO app is Commit 2.
If I was to go to DO and trigger a "deployment" in their UI the app would pull Commit 3, build & deploy.
If I (CI/CD) was to instead trigger a deployment via Pulumi, the app will pull Commit 2, build & deploy. I need to directly trigger DO to do another deployment to get it to update to Commit 3. However, this may not be possible due to the timing of the DO rollback from the now failed DO deployment of Commit 2 now that the infra has broken the app itself on that old commit.

The problem this causes is if Commit 2 contains incompatible infrastructure & code changes. With the expectations that these are deployed as a unit, the infrastructure is updated, and then the application built & deployed. When the pulumi deployment is performed the application will build from an old commit, breaking, and be unable to rollback, resulting in extended downtime while this process resolved to a failed state. And then we can manually perform a deployment with DO to update to the newest commit, fixing the application.

@douglasg14b Could you please include some code here so that we can reproduce what you are seeing - I don't quite understand the problem you are facing.
It would be really helpful if you could isolate a small pulumi program which exhibits the same problem so that we can work off of that. Thanks!


hg-git: update

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Please squash the review commits together and do not use fixup! because GitHub does not correctly merge them all the time.

Please squash the review commits together and do not use fixup! because GitHub does not correctly merge them all the time.

I am not quite sure what change is still missing, Github shows me 1 change request would still be open but I cannot find which one that is.

I am not quite sure what change is still missing, Github shows me 1 change request would still be open but I cannot find which one that is.

That feature is buggy but I think after the change I noted above it is ready to go.

newer version already on master


KUBECONFIG not exporting all files in definition

What happened:
when exporting KUBECONFIG env var, not able to switch between contexts defined in variable
export KUBECONFIG=$KUBECONFIG:~/.kube/dev:~/.kube/qa
What you expected to happen:
after exporting KUBECONFIG I should be to kubectl config set-context dev/qa which is not working it's always pointing to one or another.
How to reproduce it (as minimally and precisely as possible):
export KUBECONFIG=$KUBECONFIG:~/.kube/dev:~/.kube/qa
kubectl config set-context qa
kubectl config set-context dev
Anything else we need to know?:
Environment:

Kubernetes client and server versions (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-25T21:25:17Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21+", GitVersion:"v1.21.5-eks-bc4871b", GitCommit:"5236faf39f1b7a7dabea8df12726f25608131aa9", GitTreeState:"clean", BuildDate:"2021-10-29T23:32:16Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"linux/amd64"}
Cloud provider or hardware configuration:
aws-cli/2.1.24 Python/3.7.3 Linux/4.14.262-200.489.amzn2.x86_64 exe/x86_64.amzn.2 prompt/off
OS (e.g: cat /etc/os-release):
NAME="Amazon Linux"
VERSION="2"
ID="amzn"
ID_LIKE="centos rhel fedora"
VERSION_ID="2"
PRETTY_NAME="Amazon Linux 2"
ANSI_COLOR="0;33"
CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2"
HOME_URL="https://amazonlinux.com/"

Hope you can help me!
Thanks in advance,
Julio

not able to switch between contexts defined in variable

Were you intending to use kubectl config use-context rather than kubectl config set-context? The former switches and the latter modifies. I did a couple tests and was able to use both of those commands with similarly combined kubeconfigs without issue.
/triage not-reproducible

Thanks for the quick response!
You are right is working using use-context also the kubeconfig view is now working!
Please close this.
Thank you so much for your help!

/close


Inquiry Regarding NB distribution and Associated Code

Hi Guanjue,
I hope this message finds you well. I recently had the opportunity to read your papers again, including:

https://doi.org/10.1093/nar/gkaa105
https://doi.org/10.1093/bioinformatics/btab148

I also took the time to work with the source code. And I encountered some difficulties and observed a few behaviors that were not entirely clear based on the papers. I have spent considerable time reviewing the source code to ensure that my understanding aligns with the intended functionality. However, I am left with a few uncertainties that I am hoping you might help clarify.
I don't understand why you fit the data after performing the S3norm to a negative binomial distribution and use the -log10Pvalue as the signal value. Also, as I read your source code, there are some things I don't quite understand.
global_nbp_NB_cm.ok.R:
line1 |	get_true_NB_prob_size = function(x, siglim){
line2 |		x_pass_lim = x[x>=siglim]
line3 |		m=mean(x_pass_lim)
line4 |		v=var(x_pass_lim)
line5 |		print('old m & v')
line6 |		print(c(m, v))
line7 |		passlim_num = sum(x>=siglim)
line8 |		for (i in 1:1){
line9 |			if (v<m){v=m+0.1}
line10|			m_pre = m
line11|			v_pre = v
line12|			p = m/v
line13|			s = m^2/(v-m)
line14|			exp_siglim_p = dnbinom(0:siglim, s, p)
line15|			exp_total_num = passlim_num/(1-sum(exp_siglim_p))
line16|			### get new mean
line17|			siglim_n_sum_for_m = 0
line18|			for (j in 0:siglim){
line19|				siglim_n_sum_for_m = siglim_n_sum_for_m + j* exp_siglim_p[j+1]*exp_total_num
line20|			}
line21|			m = (siglim_n_sum_for_m + m * passlim_num) / exp_total_num
line22|
line23|			### get new var
line24|			siglim_n_sum_for_v = 0
line25|			for (j in 0:siglim){
line26|				siglim_n_sum_for_v = siglim_n_sum_for_v + (j-m)^2 * exp_siglim_p[j+1]*exp_total_num
line27|			}
line28|			v = (siglim_n_sum_for_v + sum((x_pass_lim-m)^2)) / (exp_total_num-1)
line29|			if (v<m){v=m+0.1}
line30|			print(c(i,m,v))
line31|			if(abs(m-m_pre)<0.001 & abs(v-v_pre)<0.00001) {break}
line32|		}
line33|		p = m/v
line34|		s = m^2/(v-m)
line35|		print('new m & v')
line36|		print(c(m, v))
line37|		return(c(p,s))
line38|	}
line39| }

line8: for (i in 1:1), should this be for (i in 1:100)?
line12 and line33: p = m/v, according to the formula in the articles, calculating the p-value should be: p = (v-m)/v? (I am not sure about this)
line14-line28: I don't understand how to calculate the parameters of NB distribution<EMAIL_ADDRESS>
I am aware that these issues may arise from my own misinterpretation, and I am eager to learn from your expertise. Could you please provide some guidance on these matters? I would greatly appreciate your insights.
Thank you for considering my inquiry. I look forward to your response and am happy to provide any further details should you require them.

Here, given some epigenomic datasets have inflated zeros, we decided to use non-zero signals to estimate the NB distribution.
Q1, I don't understand why you fit the data after performing the S3norm to a negative binomial distribution and use the -log10Pvalue as the signal value.
This is mainly for the downstream IDEAS genome segmentation analysis, in practice, we found converting reads count to -log10-p-value can generate the epigenetic states profile more similar to what people expect to see.
Q2, [line12 and line33: p = m/v, according to the formula in the articles, calculating the p-value should be: p = (v-m)/v? (I am not sure about this)](line8: for (i in 1:1), should this be for (i in 1:100)?)
If observed non-zero signals indeed follow the NB distribution, theoretically, this function should converge to a more reliable NB distribution. However, in practice, the estimation in practice is not very stable. In some individual datasets, after a few rounds, the NB mean and sd may become too large or too small for converting observed read counts to -log10-p-value. Therefore, we decided to only estimate NB 1 time for each individual -log10pvalue calculation.
Q3, line12 and line33: p = m/v, according to the formula in the articles, calculating the p-value should be: p = (v-m)/v? (I am not sure about this)
The line12 and line33: p = m/v, according to the formula in the articles, calculating the p-value should be: p = (v-m)/v? (I am not sure about this)
Since we are using the dnbinom function to get the density function, we used their notation (https://www.rdocumentation.org/packages/stats/versions/3.6.2/topics/NegBinomial) in this script.
In this link, the dnbinom defines the m = n*(1-p) and v = n*(1-p) / p^2, thus n = m/v, p = m^2/(v-m)
Q4, line14-line28: I don't understand how to calculate the parameters of NB distribution<EMAIL_ADDRESS>1, exp_siglim_p is the expected probability of non-zero bins based on initial NB distribution with initial m and v: p = m/v and s = m^2/(v-m)
2, passlim_num is the osberved number of non-zero bins.
3, Since NB distribution is a discrete distribution, then you can estimate the expected total number of bins (zeron-bins + non-zero bins) based on this formula: exp_total_num = passlim_num/(1-sum(exp_siglim_p))
4, Then, to calculate the new mean based on the initial NB distribution, at each count data point (include zero), we use the for loop to first get the sum:
siglim_n_sum_for_m = 0
for (j in 0:siglim){
# Based on the initial NB distribution, for all data points equal to count j, their sum should be j* exp_siglim_p[j+1]exp_total_num
siglim_n_sum_for_m = siglim_n_sum_for_m + j exp_siglim_p[j+1]*exp_total_num
}
5, Then we get the new mean: based on (siglim_n_sum_for_m + m * passlim_num) / exp_total_num. If I remember correctly, here, we added "m * passlim_num" because in practice this method's estimated NB distribution is not sufficient to reduce the background noise in some datasets which will create epigenetic states that are not biologically meaningful in the downstream analysis, so we decided to increase the estimate mean for estimated NB model. Adding this term can double the estimated mean.
6, A similar calculation is also done for variance.

Hi @guanjue ,
I hope this message finds you well. First and foremost, I would like to express my gratitude for your prompt and thorough response to my questions. I truly appreciate the time and effort you took to provide such a detailed explanation.
I have gained a deeper understanding of the computational principles behind the negative binomial distribution after studying the materials you provided and I am now fully able to comprehend your calculation process.
While I have a better understanding of the calculation process, I still have a lingering question and concern outside of the calculation (in terms of biological significance). I would be grateful if you could provide further clarification. I understand that you may be busy, but your additional insights would be of great help to me and possibly other users as well.
Regarding the [Q1. I don't understand why you fit the data after performing the S3norm to a negative binomial distribution and use the -log10Pvalue as the signal value]:

Why doesn't the normalized data from S3V2 match the expectations of users? What data distribution should people expect to see?

Besides this, I have some doubts about the output results of the software. I know that there are 2 main output directories:

${outprefix}_RC/: the S3V2 normalized data (${cell}_${id}.${mk}.S3V2.bedgraph) in bigwig format.
${outprefix}_NBP/: the -log10Pvalue data obtained by fitting a negative binomial distribution to S3V2 normalized data (${cell}_${id}.${mk}.S3V2.bedgraph.NBP.bedgraph)

In practical applications, what are the uses of the S3V2 normalized data (${cell}_${id}.${mk}.S3V2.bedgraph) and the -log10Pvalue data obtained by fitting a negative binomial distribution to these data? Specifically, I know that -log10P data is applicable to IDEAS analysis. However, if you perform differential signal analysis or calculate log2FC, can you still use it? Is the S3V2 normalized data (${cell}_${id}.${mk}.S3V2.bedgraph) more suitable?

(1) For sequencing data people usually expect to fit a negative binomial distribution.
(2) .S3V2.bedgraph files are just saved in the output fold for the record. If it eats too much space, feel free to delete them
We didn't systematically evaluate the performance of S3V2 normalized data in differential analysis. It may create some unexpected signals due to the non-linear transformation which may not fit well with the background model of differential analysis methods.
Best wishes.
Guanjue

Thank you for your patience and quick response!


docs: add some docs for common libraries

Overview
Add some docs for common libraries, both ko and en.

PR Checklist

[x] I read and included theses actions below

I have read the Contributing Guide
I have written documents and tests, if needed.

TODO:

Add documentations to the rest utils

@ChanhyukPark-Tech I fixed all things you commented in https://github.com/toss/slash/pull/98/commits/ffa70be87c43773997cc755e4a7b81b8075912bc . Thanks.


archive epa eia crosswalk

Still need to test and create tests. This is just open so that folks can check-in on progress

Most of these changes are docs stuff. Lmk if you think I should change the deposition name to one of the other ones I suggested above!

Ok the most recent changes include a function that alters pudl contributor metadata to meet the zenodo contributor requirements.


At least one

Related to https://github.com/histoire-dev/histoire/issues/527
I'm still getting this error for 'nuxt-icon' and 'nuxt-icons' plugins. These are both very popular plugins
[vite:vue] At least one <template> or <script> is required in a single file component.
file: /Users/sam/dev/clones/nuxt-tune/node_modules/nuxt-icon/dist/runtime/Icon.vue?nuxt_component=async
node:internal/process/promises:279
            triggerUncaughtException(err, true /* fromPromise */);
            ^

SyntaxError: At least one <template> or <script> is required in a single file component.
    at Object.parse$2 [as parse] (/Users/sam/dev/clones/nuxt-tune/node_modules/@vue/compiler-sfc/dist/compiler-sfc.cjs.js:1275:7)
    at createDescriptor (/Users/sam/dev/clones/nuxt-tune/node_modules/@vitejs/plugin-vue/dist/index.cjs:84:43)
    at transformMain (/Users/sam/dev/clones/nuxt-tune/node_modules/@vitejs/plugin-vue/dist/index.cjs:2282:34)
    at Object.transform (/Users/sam/dev/clones/nuxt-tune/node_modules/@vitejs/plugin-vue/dist/index.cjs:2814:16)
    at /Users/sam/dev/clones/nuxt-tune/node_modules/vite-plugin-inspect/dist/index.cjs:932:28
    at Object.plugin2.<computed> (/Users/sam/dev/clones/nuxt-tune/node_modules/vite-plugin-inspect/dist/index.cjs:919:16)
    at file:///Users/sam/dev/clones/nuxt-tune/node_modules/rollup/dist/es/shared/node-entry.js:25518:40 {
  id: '/Users/sam/dev/clones/nuxt-tune/node_modules/nuxt-icon/dist/runtime/Icon.vue?nuxt_component=async',
  plugin: 'vite:vue',
  name: 'RollupError',
  hook: 'transform',
  code: 'PLUGIN_ERROR',
  watchFiles: [
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
    ```

_Originally posted by @samuveth in https://github.com/histoire-dev/histoire/issues/527#issuecomment-1713213570_

I get the same issue using any of the available icon libraries, which are:

nuxt-icons
nuxt-icon
@nuxtjs/svg-sprite

It is enough to add them to the modules list of the nuxt.config to get the At least one <template> or <script> is required in a single file component error.
It can be reproduced by any setup with histoire 0.17.1 and nuxt 3.16.x and using the nuxt and vue plugins. I also added an example component for testing.
My current workaround is to disable the icon module for histoire, which is messy but okay for a short period.
package.json scripts
    "story:dev": "cross-env NUXT_APP_DISABLE_ICON_MODULE=true histoire dev",
    "story:build": "cross-env NUXT_APP_DISABLE_ICON_MODULE=true histoire build",
    "story:preview": "histoire preview

nuxt.config
const modules = [
  '@pinia/nuxt',
]

if (process.env['NUXT_APP_DISABLE_ICON_MODULE'] !== 'true') {
  modules.push('nuxt-icons')
}

export default defineNuxtConfig({
  devtools: { enabled: false },
  modules,
})

Here is a minimal example to reproduce the issue:
https://stackblitz.com/edit/nuxt-starter-ppp9v2

@Akryum I investigated a bit on this issue and it seems like histoire does not work with the async components exposed by nuxt-icons and svg-sprite libraries.
I have added the nuxt-icon component from library "nuxt-icons" manually to my project and even though there was not build error anymore, it does not display the icons (in nuxt itself it works though) and it does not matter what I render in the component. As long as it is async setup (it is using await in the setup function) nothing is being rendered in histoire (eg. a hardcoded span element with text).
I ensured that that the icons, which I tried to load, exist and were found in the component logic.
I also got this in the browser console
[Vue warn]: Component <Anonymous>: setup function returned a promise, but no <Suspense> boundary was found in the parent component tree. A component with async setup() must be nested in a <Suspense> in order to be rendered.
  at <NuxtIcon name="search" fill="" >
  at <DemoComponent icon-name="search" text="DemoComponent" onAwesomeClick=fn  ... >
  at <RenderStorySubApp>

maybe it would work if histoire puts a suspense tag around the rendered component.

From what I saw histoire simply does not work with global components from nuxt which are treated as async components. So is not really about nuxt-icon, it's about async components.
To get this error simply initiate a nuxt project and create a component in components/global then start histoire.

Can confirm that it is still happening in the latest Version and isn't fixed together with this issue:
https://github.com/histoire-dev/histoire/issues/587#issuecomment-1751680486

Happening with me as well, using Nuxt 3.7.4 and Histoire 0.17.2.

is also not working with several other modules D: !

This seems to happen too with vue-material-design-icons.

Try disabling the "@nuxt/content" module, in my case it worked.

@alex-lit:
nuxt/content isn't installed in the repro @anoack93 provided.
Any globally loaded module seems to trigger this issue, not this one specifically.

I have tried to investigate this issue and identify where in the vite transform pipeline this error seems to come from. This error seems to come from the fact that vite is transforming the .vue files which are registered as global components twice.
The following output is from running histoire dev on a Nuxt project with some global components registered.
As you can see in the traces below the first POST TRANSFORM END line shows a global component passing through the vite:vue transform hook within vite.
The second log of POST TRANSFORM ERROR shows the vite:vue hook being run on the already transformed output. In Daniel Roe's answer on Storybook where a similar error seems to be occuring he suggests plugin vue is being loaded multiple times. This would appear to add up with something similar happening here. It doesn't appear to be multiple vite:vue hooks registered though as checking the transform plugins list in the logs below you can see no duplicates.
I'm going to keep looking...
POST TRANSFORM END vite:vue import { defineComponent as _defineComponent } from "vue";
const _sfc_main = /* @__PURE__ */ _defineComponent({
  __name: "JourneyButtons",
  props: {
    buttons: { type: Array, required: true },
    topLevelClass: { type: String, required: true },
    containerDivClass: { type: String, required: true },
    buttonWrapperDivClass: { type: String, required: true }
  },
  emits: ["nextClick", "previousClick"],
  setup(__props, { expose: __expose, emit: __emit }) {
    __expose();
    const emit = __emit;
    function handleClick(button) {
      if (button.type === "next")
        return emit("nextClick");
      if (button.type === "previous")
        return emit("previousClick");
    }
    const __returned__ = { emit, handleClick };
    Object.defineProperty(__returned__, "__isScriptSetup", { enumerable: false, value: true });
    return __returned__;
  }
});
import { renderList as _renderList, Fragment as _Fragment, openBlock as _openBlock, createElementBlock as _createElementBlock, toDisplayString as _toDisplayString, normalizeClass as _normalizeClass, createElementVNode as _createElementVNode } from "vue";
const _hoisted_1 = ["onClick"];
function _sfc_render(_ctx, _cache, $props, $setup, $data, $options) {
  return _openBlock(), _createElementBlock(
    "section",
    {
      class: _normalizeClass($props.topLevelClass)
    },
    [
      _createElementVNode(
        "div",
        {
          class: _normalizeClass($props.containerDivClass)
        },
        [
          _createElementVNode(
            "div",
            {
              class: _normalizeClass($props.buttonWrapperDivClass)
            },
            [
              (_openBlock(true), _createElementBlock(
                _Fragment,
                null,
                _renderList($props.buttons, (b, i) => {
                  return _openBlock(), _createElementBlock("button", {
                    key: i,
                    class: _normalizeClass(b.text),
                    onClick: ($event) => $setup.handleClick(b)
                  }, _toDisplayString(b.text), 11, _hoisted_1);
                }),
                128
                /* KEYED_FRAGMENT */
              ))
            ],
            2
            /* CLASS */
          )
        ],
        2
        /* CLASS */
      )
    ],
    2
    /* CLASS */
  );
}
_sfc_main.__hmrId = "1bdbbfa7";
typeof __VUE_HMR_RUNTIME__ !== "undefined" && __VUE_HMR_RUNTIME__.createRecord(_sfc_main.__hmrId, _sfc_main);
import.meta.hot.accept((mod) => {
  if (!mod)
    return;
  const { default: updated, _rerender_only } = mod;
  if (_rerender_only) {
    __VUE_HMR_RUNTIME__.rerender(updated.__hmrId, updated.render);
  } else {
    __VUE_HMR_RUNTIME__.reload(updated.__hmrId, updated);
  }
});
import _export_sfc from "\0plugin-vue:export-helper";
export default /* @__PURE__ */ _export_sfc(_sfc_main, [["render", _sfc_render], ["__file", "C:/Users/i33672/source/repos/customer-portal/components/content/JourneyButtons.vue"]]);
 [
  'unplugin-formkit',
  'nuxt:layer-aliasing',
  'content-slot',
  'unplugin-vue-i18n',
  'nuxt:client-fallback-auto-id',
  'vite:css',
  'vite:esbuild',
  'vite:json',
  'vite:worker',
  'vite:vue',
  'vite:vue-jsx',
  'replace',
  'nuxt:remove-plugin-metadata',
  'nuxt:chunk-error',
  'nuxt:components:imports',
  'replace',
  'vite:define',
  'vite:css-post',
  'vite:worker-import-meta-url',
  'vite:asset-import-meta-url',
  'vite:dynamic-import-vars',
  'vite:import-glob',
  'nuxt:composable-keys',
  'nuxtjs:i18n-macros-transform',
  'nuxtjs:i18n-resource',
  'nuxt:imports-transform',
  'unctx:transform',
  'nuxt:dev-style-ssr',
  'nuxt:runtime-paths-dep',
  'nuxt:components-loader',
  'nuxt:tree-shake-composables:transform',
  'vite:client-inject',
  'vite:import-analysis'
] Error: why have you done this
    at Object.transform (file:///C:/Users/i33672/source/repos/customer-portal/node_modules/.pnpm/vite@4.5.0/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:44380:95)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async loadAndTransform (file:///C:/Users/i33672/source/repos/customer-portal/node_modules/.pnpm/vite@4.5.0/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:55034:29)
ℹ ✨ optimized dependencies changed. reloading                                                                                16:27:16
ℹ Vite client warmed up in 1935ms                                                                                16:27:16
Failed to resolve dependency: vscode-oniguruma, present in 'optimizeDeps.include'
Failed to resolve dependency: vscode-textmate, present in 'optimizeDeps.include'
Using 8 threads for story collection
Collect stories start all
  ➜  Local:   http://localhost:6006/
  ➜  Network: use --host to expose
✔ Nitro built in 4241 ms                                                                                nitro 16:27:20
At least one <template> or <script> is required in a single file component.
POST TRANSFORM ERROR vite:vue import { defineAsyncComponent } from "vue"
export default defineAsyncComponent(() => import("C:/Users/i33672/source/repos/customer-portal/components/content/JourneyButtons.vue").then(r => r.default)) [
  'unplugin-formkit',
  'nuxt:layer-aliasing',
  'content-slot',
  'unplugin-vue-i18n',
  'nuxt:client-fallback-auto-id',
  'histoire:flags',
  'vite:css',
  'vite:esbuild',
  'vite:json',
  'vite:worker',
  'replace',
  'nuxt:remove-plugin-metadata',
  'nuxt:chunk-error',
  'nuxt:components:imports',
  'vite:vue',
  'vite:vue-jsx',
  'replace',
  'histoire-vue-docs-block',
  'vite:define',
  'vite:css-post',
  'vite:worker-import-meta-url',
  'vite:asset-import-meta-url',
  'vite:dynamic-import-vars',
  'vite:import-glob',
  'nuxt:composable-keys',
  'nuxtjs:i18n-macros-transform',
  'nuxtjs:i18n-resource',
  'nuxt:imports-transform',
  'unctx:transform',
  'nuxt:runtime-paths-dep',
  'nuxt:components-loader',
  'histoire-plugin-vue',
  'vite:client-inject',
  'vite:import-analysis'
]
At least one <template> or <script> is required in a single file component. (x2)
At least one <template> or <script> is required in a single file component. (x3)
At least one <template> or <script> is required in a single file component. (x4)
At least one <template> or <script> is required in a single file component. (x5)
At least one <template> or <script> is required in a single file component. (x6)
At least one <template> or <script> is required in a single file component. (x7)
At least one <template> or <script> is required in a single file component. (x8)
At least one <template> or <script> is required in a single file component. (x9)
At least one <template> or <script> is required in a single file component. (x10)
At least one <template> or <script> is required in a single file component. (x11)
At least one <template> or <script> is required in a single file component. (x12)
At least one <template> or <script> is required in a single file component. (x13)
At least one <template> or <script> is required in a single file component. (x14)
At least one <template> or <script> is required in a single file component. (x15)
At least one <template> or <script> is required in a single file component. (x16)
At least one <template> or <script> is required in a single file component. (x17)
At least one <template> or <script> is required in a single file component. (x18)
At least one <template> or <script> is required in a single file component. (x19)
At least one <template> or <script> is required in a single file component. (x20)
At least one <template> or <script> is required in a single file component. (x21)
At least one <template> or <script> is required in a single file component. (x22)
At least one <template> or <script> is required in a single file component. (x23)
At least one <template> or <script> is required in a single file component. (x24)
At least one <template> or <script> is required in a single file component. (x25)
At least one <template> or <script> is required in a single file component. (x26)
At least one <template> or <script> is required in a single file component. (x27)
At least one <template> or <script> is required in a single file component. (x28)
At least one <template> or <script> is required in a single file component. (x29)
At least one <template> or <script> is required in a single file component. (x30)
At least one <template> or <script> is required in a single file component. (x31)
At least one <template> or <script> is required in a single file component. (x32)
At least one <template> or <script> is required in a single file component. (x33)
At least one <template> or <script> is required in a single file component. (x34)
At least one <template> or <script> is required in a single file component. (x35)
At least one <template> or <script> is required in a single file component. (x36)
At least one <template> or <script> is required in a single file component. (x37)
At least one <template> or <script> is required in a single file component. (x38)
At least one <template> or <script> is required in a single file component. (x39)
At least one <template> or <script> is required in a single file component. (x40)
At least one <template> or <script> is required in a single file component. (x41)
At least one <template> or <script> is required in a single file component. (x42)
At least one <template> or <script> is required in a single file component. (x43)
At least one <template> or <script> is required in a single file component. (x44)
POST TRANSFORM ERROR vite:vue import { defineAsyncComponent } from "vue"
export default defineAsyncComponent(() => import("C:/Users/i33672/source/repos/customer-portal/components/content/JourneyButtons.vue").then(r => r.default)) [
  'unplugin-formkit',
  'nuxt:layer-aliasing',
  'content-slot',
  'unplugin-vue-i18n',
  'nuxt:client-fallback-auto-id',
  'histoire:flags',
  'vite:css',
  'vite:esbuild',
  'vite:json',
  'vite:worker',
  'replace',
  'nuxt:remove-plugin-metadata',
  'nuxt:chunk-error',
  'nuxt:components:imports',
  'vite:vue',
  'vite:vue-jsx',
  'replace',
  'histoire-vue-docs-block',
  'vite:define',
  'vite:css-post',
  'vite:worker-import-meta-url',
  'vite:asset-import-meta-url',
  'vite:dynamic-import-vars',
  'vite:import-glob',
  'nuxt:composable-keys',
  'nuxtjs:i18n-macros-transform',
  'nuxtjs:i18n-resource',
  'nuxt:imports-transform',
  'unctx:transform',
  'nuxt:runtime-paths-dep',
  'nuxt:components-loader',
  'histoire-plugin-vue',
  'vite:client-inject',
  'vite:import-analysis'
]
Error while collecting story C:/Users/i33672/source/repos/customer-portal/stories/Woof.story.vue:
SyntaxError: At least one <template> or <script> is required in a single file component.
    at Object.parse$2 [as parse] (C:\Users\i33672\source\repos\customer-portal\node_modules\.pnpm\@vue+compiler-sfc@3.3.8\node_modules\@vue\compiler-sfc\dist\compiler-sfc.cjs.js:1904:7)
    at createDescriptor (C:\Users\i33672\source\repos\customer-portal\node_modules\.pnpm\@vitejs+plugin-vue@4.5.0_vite@4.5.0_vue@3.3.8\node_modules\@vitejs\plugin-vue\dist\index.cjs:86:43)
    at transformMain (C:\Users\i33672\source\repos\customer-portal\node_modules\.pnpm\@vitejs+plugin-vue@4.5.0_vite@4.5.0_vue@3.3.8\node_modules\@vitejs\plugin-vue\dist\index.cjs:2302:34)
    at TransformContext.transform (C:\Users\i33672\source\repos\customer-portal\node_modules\.pnpm\@vitejs+plugin-vue@4.5.0_vite@4.5.0_vue@3.3.8\node_modules\@vitejs\plugin-vue\dist\index.cjs:2848:16)
    at Object.transform (file:///C:/Users/i33672/source/repos/customer-portal/node_modules/.pnpm/vite@4.5.0/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:44353:62)
    at async loadAndTransform (file:///C:/Users/i33672/source/repos/customer-portal/node_modules/.pnpm/vite@4.5.0/node_modules/vite/dist/node/chunks/dep-bb8a8339.js:55034:29)
Collect stories end 2440ms

I believe I have found a potential fix. But I'm a little confused by it...
Changing the hook that @histoire/plugin-nuxt uses to check for the presence of the vue plugins to vite:configResolved and everything starts working fine.

This shows that no plugins are actually modified by the hook anymore as they are already present.
With the hook changed to configResolved the vite dev server starts and everything seems to work.
If you just remove the hook entirely it no longer errors but the vite dev server never starts.

Very strange. I'm not confortable raising a PR with this just yet as I dont understand why just listening to configResolved but doing nothing seems to make histoire work again. Something for Monday 😄 if anyone notices anything that might explain let me know!

can confirm this is tsill there with latest historie v 0.17.6 and latest  nuxt 3.8.2

This is there in the vue plugin too

This is there in the vue plugin too

Most likely this is because your Vue plugin is loaded twice and your code is being transformed twice. I believe following the vanilla histoire setup for a standard Vue 3 project does work. Try setting up a vanilla one and adding some of your vite config piece by piece and see what seems to break it.


Create index.html and insert the snippet

`

Résumé

    ― Hello World! 😉

`

this have been done


Segfault on musl when two tls stacks accidentally chosen

Current and expected behavior
This code
fn main() {
    tokio::runtime::Builder::new_current_thread()
        .enable_all()
        .build()
        .unwrap()
    .block_on(async {
    match kube::client::Client::try_default()
            .await {
              Ok(_) => (),
              Err(error) => eprintln!("{error:?}")
            }
            // .expect("Expected a valid KUBECONFIG environment variable.");
    });
}

compiles well, but the binary crashes. See attachet backtrace.txt
20:05 $ rustc --version
rustc 1.66.0-nightly (758f19645 2022-10-24)
20:01 $ OPENSSL_DIR="/home/apastuchov/git/openssl/openssl/build" RUSTFLAGS="-C target-feature=+crt-static" cargo run --bin seg-fault --target x86_64-unknown-linux-musl

Possible solution
No response
Additional context
No response
Environment
19:58 $ kubectl version --output json
{
  "clientVersion": {
    "major": "1",
    "minor": "25",
    "gitVersion": "v1.25.2",
    "gitCommit": "5835544ca568b757a8ecae5c153f317e5736700e",
    "gitTreeState": "clean",
    "buildDate": "2022-09-21T14:33:49Z",
    "goVersion": "go1.19.1",
    "compiler": "gc",
    "platform": "linux/amd64"
  },
  "kustomizeVersion": "v4.5.7",
  "serverVersion": {
    "major": "1",
    "minor": "23",
    "gitVersion": "v1.23.9",
    "gitCommit": "c1de2d70269039fe55efb98e737d9a29f9155246",
    "gitTreeState": "clean",
    "buildDate": "2022-07-13T14:19:57Z",
    "goVersion": "go1.17.11",
    "compiler": "gc",
    "platform": "linux/amd64"
  }
}

Configuration and features
k8s-openapi = { version = "0.16", default-features = false, features = ["v1_25"] }
kube = { version = "0.75.0", default-features = true, features = ["derive", "runtime", "client", "rustls-tls"] }

Affected crates
No response
Would you like to work on fixing this bug?
maybe

default-features = true is the root cause of the issue because openssl-tls is default feature for [kube-client|https://github.com/kube-rs/kube/blob/da6b5e7b963bd6f72190a23b428abdf5e321141d/kube-client/Cargo.toml#L19].
Changing default-features = false resolves the issue.
Consider to check "mutually exclusive"
✔ ~/git/github/kube-rs/kube [main|✚ 1]
21:34 $ git diff
diff --git a/kube-client/src/lib.rs b/kube-client/src/lib.rs
index 03382bd..99166aa 100644
--- a/kube-client/src/lib.rs
+++ b/kube-client/src/lib.rs
@@ -1,3 +1,5 @@
+#[cfg(all(feature = "rustls-tls", feature = "openssl-tls"))]
+compile_error!("Feature rustls-tls and openssl-tls are mutually exclusive and cannot be enabled together");
 //! Crate for interacting with the Kubernetes API
 //!
 //! This crate includes the tools for manipulating Kubernetes resources as

Hm, we used to have a static_assertion that we had exactly one of these features selected, but we might have taken that out once we made the client optional.
We should probably reintroduce the XOR check when the client feature is set. Thanks for the report.

I think this is a duplicate of https://github.com/kube-rs/kube/issues/869#issuecomment-1092612014 . OpenSSL is used by the default client when both are enabled.

we might have taken that out once we made the client optional.

We removed the requirement to have TLS feature enabled when client feature is enabled, and also allowed having multiple TLS features (#540).
I haven't tested the current version, but we have an example changing it at runtime that worked at the time.
https://github.com/kube-rs/kube/blob/a7861aa6a4b883799675ca3e4c004a46c9bcff8c/examples/custom_client_tls.rs#L1-L3

Just ran into this -- taking a look at https://github.com/kube-rs/kube/issues/869#issuecomment-1092612014 and switching to a debian base build solved the issue for me.
The failure mode I was seeing was that Client::incluster() was causing a panic & crash when built from alpine but not when built from Debian.
Having both TLS methods turned on at the same time (openssl via default features, rust TLS via explicit feature addition) didn't cause a problem for me (and didn't break locally obviously), but when running a container the application would start up and fail.

Yeah, alpine is sometimes problematic if you're not doing the musl build correctly. We do use distroless (static) in controller-rs from static exe and in version-rs using muslrust as a builder so people can follow those build setups for minimal images. Debian/official rust build is usually harder to get wrong though.
I'm going to close this as a duplicate of #869, but will start writing a bit about container builds on kube-rs/website.


Add client for http4s library

Hi! I don't know if there is space for another client, but it seemed appropriate for me to add it, since it's kinda mainstream client in cats-effect ecosystem (http4s/circe/cats-effect). I was kinda surprised not to find it, ended up implementing it, but got tired copying it between my projects where I use elastic4s.
If you think it's a good idea to add it, I will be happy to add tests in this PR as well. Thank you.

It just came to me, @Philippus if you think that elastic4s supports enough clients out of the box (I found that sttp for example already has http4s backend), I can just publish it as a separate library.

I would love to use this client! I think currently sttp use future backend (which is backed scala future & akka iiuc). So this is definitely worth adding imho.
Also We probably can have more perform IO backed client if We have this: https://github.com/Philippus/elastic4s/issues/2379

@lenguyenthanh I was also thinking about that, addressed in https://github.com/Philippus/elastic4s/pull/3119

@lenguyenthanh I was also thinking about that, addressed in #3119

this is great, thanks! I was about to do it.

I think adding a new client is fine, provided someone is using it in production (like you). Maybe we can mark it as experimental, allowing us to make backwards incompatible changes for a certain time.

@Philippus nice! Then I'm going to add tests for it

@Philippus I've added some tests following the pattern from sttp. I think it is ready to be merged, WDYT?

@igor-vovk now that https://github.com/Philippus/elastic4s/pull/3124 is merged, care to get back and clean up this PR (or create a new one based on the current main branch)?

@lenguyenthanh Do you have time to take a look at the PR to see if this will work for you as well?

@lenguyenthanh Do you have time to take a look at the PR to see if this will work for you as well?

of course, I'll take a look tomorrow.

@lenguyenthanh I've addressed all your comments

@Philippus I also noticed test flakiness, tried to add health check before proceeding on the level of GH actions in #3207, but failing to understand why it fails in GH Actions environment (works locally, probably something with bash options...)

I think it's because of all the tests running on the same instance. If you change the test to "yellow" or "green" I think it will be fine.

@Philippus I think what happens is that this status changes from red to yellow and then to green (doc https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-health.html). And then depending on when the test runs it can receive any of these, thus flakiness of the test. In any case, I've deleted this test.

Marked #3207 as ready for review. It now waits elastic to start before continuing, should reduce tests flakiness

@Philippus I think what happens is that this status changes from red to yellow and then to green (doc https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-health.html). And then depending on when the test runs it can receive any of these, thus flakiness of the test. In any case, I've deleted this test.

If you think it's worth having it as a test I think we can bring it back. We can always remove it again, if it turns out to be flaky again.

Reverted the deletion of the test. After #3207 will be merged, the test should stop being flaky


Javascript bundles referenced with invalid absolute paths in "index.html" when building app

Version
3.0.0-rc.1
Reproduction link
https://github.com/TAGC/vue-expandable-grid/commit/fe08cb83eae3a5a5a6c15cd03dd24e2270768b02
Steps to reproduce
After cloning and installing dependencies, run $ ./node_modules/.bin/vue-cli-service build ./src/index.ts in the project root directory. This should generate dist/index.html and app/vendor bundles under dist/js. Open dist/index.html in a browser and confirm it gets 404s trying to load the bundles.
What is expected?
dist/index.html to be generated where it references the bundles as relative paths:

What is actually happening?
The HTML file gets generated referencing the bundles at invalid absolute paths:

Manually changing the absolute paths to relative paths after generating the HTML file causes the JS bundles to be loaded successfully.

Are you trying to open the page directly from your file explorer? If so, it won't work since you are not on a real HTTP server. To test your deploy locally, you can use for example this small utility which can expose your files in an HTTP server on localhost just like if you would have uploaded them on a real server.

Ah okay, that's awesome thanks.


Default and/or display AudioContext sample rate

Many of the little demos have a default sample rate for the demo.  This is fine, but if the AudioContext sample rate differs greatly from this, the playback of the saved audio buffer is resampled to the sample rate of the context.  At least for Chrome, this is just a simple linear interpolation which doesn't work very well if the sample rates differ significantly.
So, as a way to alert the user, it would be nice to somehow inform him what the sample rate of the AudioContext is.  And as a bonus, if the sample rate isn't specified for the snippet, perhaps it can be defaulted to the sample rate of the AudioContext.

This is not good enough?

That should work for the display part.

It's already rendered/displayed based on the default value (44.1K) when the sample rate is not given.


Improvesupport array to window-func first-last-value arg type

Proposed changes
support array to window-func first-last-value arg type
eg. select first-value(array) over(xxx)
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 42.61 seconds
stream load tsv:          453 seconds loaded<PHONE_NUMBER>9 Bytes, about 157 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          57 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          29 seconds loaded 861443392 Bytes, about 28 MB/s
insert into select:          69.1 seconds inserted 10000000 Rows, about 144K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230627070151_clickbench_pr_168533.html

run buildall

run clickbench

run clickbench

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.72 seconds
stream load tsv:          452 seconds loaded<PHONE_NUMBER>9 Bytes, about 157 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          58 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          29 seconds loaded 861443392 Bytes, about 28 MB/s
insert into select:          68.0 seconds inserted 10000000 Rows, about 147K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230627104738_clickbench_pr_168738.html

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.61 seconds
stream load tsv:          451 seconds loaded<PHONE_NUMBER>9 Bytes, about 158 MB/s
stream load json:         23 seconds loaded<PHONE_NUMBER> Bytes, about 97 MB/s
stream load orc:          57 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          29 seconds loaded 861443392 Bytes, about 28 MB/s
insert into select:          73.4 seconds inserted 10000000 Rows, about 136K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230627114902_clickbench_pr_168794.html

run p1


Helm doesn't cleanup on unsuccessful deployments

After encountering an error during install/upgrade helm doesn't clean after itself (that is operation isn't atomic), which forces me to clean manually each time during testing. Also, that deployment name isn't registered, thus I cannot use helm delete --purge <name>
~ helm version
Client: &version.Version{SemVer:"v2.7.2", GitCommit:"8478fb4fc723885b155c924d1c8c410b7a9444e6", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.7.2", GitCommit:"8478fb4fc723885b155c924d1c8c410b7a9444e6", GitTreeState:"clean"}

/remove-lifecycle stale
Yes, it would be nice. The most common case when an update fails is when cluster IP is changed to NodePort or things like that in services. ((IIRC)). The usual solution is to perform rollback with --force

I hit this error frequently. An install fails and then I make some changes to my config and try to install again but hit errors complaining about how many pods/configmaps etc already exist. When you run helm list it doesn't list any failed or successful deployments so then I have to go and cleanup everything manually. If an install fails it should definitely rollback the changes it has already made not leave a half installed helm chart.

This issue is frustrating, Why do helm charts gets installed partially ? Any work around commands for this?

@ysaakpr

helm install testchart/ --name xyz --> installs with a release name

if you want to make changes to the release use,

helm upgrade xyz testchart/ --> upgrades with the recent changes only

also , below command is useful to delete the full release itself
3. helm del --purge xyz
--Thanks

@jibinjohnbabu that doesn't work when helm doesn't have a release name and leaves the cluster in an unclean state. Which is what this whole git issue is about.

@bacongobbler why is this labelled as a feature? It's a bug.

Can a new status code be added to programmatically know that a chart was reverted? Reporting “1” as before does not provide proper understandings of what that has happened.


Controller type not found

🐛 Bug Report
Cannot import Controller as it's not exported
To Reproduce
This simple code demonstrates best:
import { Controller } from 'react-spring';

console.log(Controller) // -> Returns undefined

Expected behavior
Controller should not be undefined
Environment

react-spring v8.0.20
react v16.8.6

Can you try with react-spring@next? Thanks! 👍

@aleclarson So Controller doesn't exist in 8.x.x?

It does, but I guess it's not exported from the main module. And since the package is bundled, you won't be able to get access to it. This is fixed in v9 though.

@aleclarson This should be mentioned somewhere in the docs I guess. Thanks for the clarification!

@aleclarson Just updated and Controller still doesn't exist. Please reopen. Cheers

Just tested it locally and it exists. Try deleting any lockfiles and node_modules directories.

@aleclarson I'll try. What I did was npm install react-spring@next

@aleclarson Tried and Controller still not found

Ah that's right, the Controller class is not included in the TypeScript definitions yet. I'll try to sort that out for the next beta.

What shall i use now as an alternative?
On Thu, 30 May 2019 at 16:46, Alec Larson<EMAIL_ADDRESS>wrote:

Reopened #685 https://github.com/react-spring/react-spring/issues/685.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/react-spring/react-spring/issues/685?email_source=notifications&email_token=ALSFW37QC2PYMGR5MIKIFGDPX7ZFXA5CNFSM4HRGB4R2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORXCRAHY#event-2378502175,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALSFW32YPEUEG6MNYIOR4ITPX7ZFXANCNFSM4HRGB4RQ
.

v9.0.0-beta.9 is out! Sorry for the delay :)


Track & clip colors

It would be great to have the ability to color code clips and/or tracks in Raven.
For starters, colors could be set in OTIO metadata, but once that is working, we could explore adding that as an official schema feature in OTIO.

Are you thinking about a pre-defined palette or arbitrary RGB colors?

Marker colors come from a pre-defined set, which is convenient when quickly picking something, but rather of awkward when interchanging with other systems where the colors are different. I guess clip colors would be similar?
I mocked this up to try it out...

Addressed by #14

Cool screenshot! Palettes are convenient but considering the clip/track colors are prominent in the UI (like your screenshot) it would be nice to have more control over the colors. Maybe RGB floats, like an Imath::Vec3?


Chore: Add documentation for context

Add documentation for context

I would also add a txt example to the docs.
Don't actually use this, but it could look like:
pirate.txt
talk like a pirate

Tool1:
Context: pirate.txt

Tell a joke

Tool2:
Context: pirate.txt

Say Hello

Showing you can reduce boiler plate and change behavior quickly

@cloudnautique I have included an example for multiple tools using txt file as context.