Use https:// in npm-shrinkwrap.json

How did you do that and why?

Oops, I'm sorry if I merged prematurely!
I noticed that when I ran npm shrinkwrap on my machine, some of the URLs had changed from http to https, so I figured it'd be best to go ahead and lock in those changes, to take full advantage of https. Note that most of the URLs were already https, so this only changes the remainder.
git checkout 963cf15
grep https: npm-shrinkwrap.json | wc -l
grep http: npm-shrinkwrap.json | wc -l

I'm guessing that when you first ran npm shrinkwrap, some of the dependencies had already been downloaded over http, so that got reflected in npm-shrinkwrap.json.

Thanks for clearing that up. I did a complete fresh npm install before I was creating the shrinkwrap file. So I  have no clue why some of them are downloaded via http. We will see if the manual editing of the shrinkwrap will cause any further issues as soon we update/add a dependency. By the way, which version of npm do you use? I'm on 3.9.5.
Regarding merging. It's fine to merge small stuff by yourself, but new features or bigger/critical PRs I would like to have a discussion first or at lease a thumbs up 😉

Hmm, with a fresh npm install, it is strange that some dependencies came over http. Hopefully they won't in the future.
For adding/updating dependencies, the npm documentation says that npm-shrinkwrap.json will be updated automatically, as long as we pass --save to npm install. It looks like --save-dev doesn't have the same behavior, but npm-shrinkwrap.json doesn't currently have the devDependencies anyway, so that's ok.
I'm on npm 3.9.3 at the moment, so I'm guessing our versions behave mostly the same, according to the changelog
Thanks for the clarification on merging, I'll try to be a little more careful about changing new code like this before getting feedback.

It looks like --save-dev doesn't have the same behavior, but npm-shrinkwrap.json

That's actually a problem for us! I was adding the shrinkwrap especially for them to avoid different build by different versions of babel, webpack .... Will create a new shrinkwrap which includes only the devDep this evening.


network, netstat: Add tests to cover changes in the guest

What this PR does / why we need it:
Add unit tests that cover the following scenarios:

Existing interfaces have their MAC changed.
Existing interfaces are removed.
Add a new interface.

Note: With the current implementation, bridge binding interfaces that
cannot be associated with interfaces in the guest, will include the IP/s
detected at the setup stage on the pod.
This is questionable, because the IP/s are supposed to be passed into
the VM (using a DHCP server), however, there is no way to validate it
has indeed passed in.
We may need to change this behavior later on.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/cc @oshoval
These are the tests that are suppose to cover the different infoSource scenarios when changes are done in the guest.

/uncc vatsalparekh

Note: With the current implementation, bridge binding interfaces that cannot be associated with interfaces in the guest, will include the IP/s detected at the setup stage on the pod. This is questionable, because the IP/s are supposed to be passed into the VM (using a DHCP server), however, there is no way to validate it has indeed passed in. We may need to change this behavior later on.

I don't think it is the current behavior in e2e, just on unit-test
The reason is the virt-launcher merger adds the interfaces from the domain.spec to the domain.status
and then on UpdateStatus those interfaces from the guest are overriding the ones from the pod
This e2e test shows it
https://github.com/kubevirt/kubevirt/pull/7053

Note: With the current implementation, bridge binding interfaces that cannot be associated with interfaces in the guest, will include the IP/s detected at the setup stage on the pod. This is questionable, because the IP/s are supposed to be passed into the VM (using a DHCP server), however, there is no way to validate it has indeed passed in. We may need to change this behavior later on.

I don't think it is the current behavior in e2e, just on unit-test (because they don't do what the virt-launcher merger does). The reason is the virt-launcher merger adds the non guest agent interfaces from the domain.spec to the domain.status (without ips), and then on UpdateStatus those interfaces from the domain.status are overriding the ones from the pod
This e2e test shows it #7053

Yes, this is an older note I had which is no longer relevant. The unit tests show the right behavior.

change: Dropped the wrong note from the commit message.

/sig network

change: Rename tests to make it clearer what is checked.

/assign @AlonaKaplan

/retest

/retest


cuda pointpillars ROS ; illegal memory access!

when I use this repo in my own ros, want to detect in real time , but error occured: cuda error : an illegal memory access ,
hope someone can tell me how to solve it ,thanks.
error belike 👇

i have met the same questions in GPU_CHECK(cudaStreamSynchronize(stream_)); have your solved it ?

nope， it bothers me long time . have u solved it?

Can u check params.h which is configured for your ranges of point cloud or not?

Hello, has anyone been able to resolve this issue or figured out the reason? I am facing the same error, working on a Jetson Orin with ROS and would appreciate any help.  Thank you!


Can't view Transaction history of Moonbase Alpha network

Description the bug
Can't view Transaction history of Moonbase Alpha network
To reproduce the bug
Steps:

Open the extension
Perform send DEV token successfully
Go to transfers tab, click on this transaction history

Actual: (see file below)

Expected: Can view Transaction history of Moonbase Alpha network
Version test: https://github.com/Koniverse/SubWallet-Extension/releases/tag/v0.5.6

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./600-merge-build-0.5.6-1661771873223.zip
Validation passed.


Fail to debug .NET 6/7/8 projects with Azure Event Grid trigger Function

OS: All
Build Version: 20240305.5
Regression: Not a Regression
Repro Steps:

Create a .NET 6/7/8 project >- Select "Azure Event Grid Trigger" for the Functions.
Debug the Project.
Check if the function project is successfully debugged.

Expected:
It should successfully debug the 'Azure Event Grid Trigger' function.

Actual:
Fail to debug the "Azure Event Grid Trigger" function.

More info:

This issue does not reproduce for Javascript, Typescript, Python and Powershell.

@Amar-QA Can you provide the value of your local.settings.json file? You should have an entry for AzureWebJobsStorage that is set to either a connection string of a valid Azure Storage account, or "UseDevelopmentStorage=true" to use the emulator. If none of these are set, this error is expected.

Hi @hossam-nasr, here is the screenshot of local.settings.json file.

This issue also reproduces when debugging a .NET project created with Azure Blob Storage trigger template.
I think the cause is that no below prompt doesn't pop up when debugging the project.

So the setting "AzureWebJobsStorage" can not fill automatically.

If I fill the setting "AzureWebJobsStorage" manually, the debug is successful.

Verified this bug on v1.14.4-alpha.0 build, it also reproduces when debugging Python and Powershell projects with Azure Event Grid Trigger template.


Can someone explain IO::FileDescriptor#wait_readable to me please?

I'm trying to figure out IO::FileDescriptor#wait_readable, IO::FileDescriptor#add_read_event and Scheduler::create_fd_read_event. I don't understand why all these complicated functions are necessary. Surely IO::FileDescriptor#unbuffered_read could just be written like this?
private def unbuffered_read(slice : Slice(UInt8))
	count = slice.size
	loop do
		bytes_read = LibC.read(@fd, slice.pointer(count), count)
		return bytes_read if bytes_read != -1
		raise Errno.new "Error reading file" unless LibC.errno == Errno::EAGAIN
		Fiber.yield
	end
end

Wait readable is supposed to be called when a read call on the file descriptor would block, in order to not block but pass to another coroutine.
Ie. this is the event loop at work.

Your version would brute force the read until it passes, and would resume the coroutine for as long as we can't read. That would be very inefficient, spin the CPU for instance, ...
Wait readable tells libevent to notify when we can read, thus allowing to never return to the coroutine until we can read, allowing to run other coroutines that can be resumed in the meantime. Ie. it schedules coroutines efficiently.

Hm. I'm not familiar with libevent. It's some form of asynchronous callback-based version of IO.select?

What stops the fiber being resumed prior to a call from libevent? Is it something to do with the Scheduler.reschedule call?

I'm not familiar with libevent too, but it's a kind of cross platform wrapper for kernel systems like epoll,

Closing, since this is going into a talk and not an issue.


Concerns about metrics from @ljharb

From @ljharb in https://openssf.slack.com/archives/C0235AR8N2C/p1649348249786279:

hi! i have some concerns about some of the metrics used in the scorecard. for example:

"binary-artifacts" likely doesn't often apply to ecosystems that don't compile (JS, php, ruby, python)
more than one contributor is nice, but the existence of a lone contributor is usually because nobody else wants to help (that's why i'm the sole maintainer of over 10% of npm's traffic - not because i don't want help, but because nobody offers it). penalizing projects for something that's not in their control doesn't seem like it'll help security.
similarly, on a 1-maintainer project, it shouldn't matter if changes are landed via a PR or not, because there's nobody to do code review.
Pinned-Dependencies: the best practice for an npm project is to never pin dependencies, and to always use a ^ semver range. apps should always pin deps with a lockfile, and thus pinning deps in package.json provides no value (because transitive deps exist)
does SAST take into account eslint usage? a linter is a static analysis tool just like codeql, depending on how it's configured.
publishing from CI is not something i'd call a best practice, at least in the npm ecosystem - it's impossible to do it with 2FA, since using an authentication token is just a single factor.
Signed-Releases: what's the benefit of signing releases in an ecosystem where the majority of users (or their tooling) don't verify them by default? Measuring whether releases are signed, before making that actually a beneficial action, seems like putting the cart before the horse.
Fuzzing: given that CI logs are not persistent (GHA deletes them in 30 days, i believe, and travis deletes them on a rerun) a fuzzing tool that doesn't eternally persist previously failed input seems like it doesn't add much value. Why is this an objectively cross-ecosystem best practice?
Dependency-Update-Tool: for renovate, does it check the project's owner's .github repo for renovate config as well? i use this, altho it's not that common to do so.

I'd love to chat more about this :slightly_smiling_face: metrics that add value are great, but simply assigning a number to something brings a risk of unintended consequences/perverse effects, like incentivizing me to make a sock puppet account solely to code review all my changes, to satisfy the "2 contributor" requirement.

@ossf/scorecard-maintainers -- Some of these points are familiar, so wherever possible, let's reference existing discussions/issues/PRs. I just want to make sure we capture all of @ljharb's questions as a first step! :)

@brianrussell2 fyi.

From @ljharb in https://openssf.slack.com/archives/C0235AR8N2C/p1649348249786279:

hi! i have some concerns about some of the metrics used in the scorecard. for example:

"binary-artifacts" likely doesn't often apply to ecosystems that don't compile (JS, php, ruby, python)
more than one contributor is nice, but the existence of a lone contributor is usually because nobody else wants to help (that's why i'm the sole maintainer of over 10% of npm's traffic - not because i don't want help, but because nobody offers it). penalizing projects for something that's not in their control doesn't seem like it'll help security.
similarly, on a 1-maintainer project, it shouldn't matter if changes are landed via a PR or not, because there's nobody to do code review.
Pinned-Dependencies: the best practice for an npm project is to never pin dependencies, and to always use a ^ semver range. apps should always pin deps with a lockfile, and thus pinning deps in package.json provides no value (because transitive deps exist)

The check does not ask users to pin their dependencies in the manifest. It only verifies that there's a lock file when it's used in CI, so you get "reproducible" installation and don't suddenly fall victim to "npm color" attacks if someone pushed a malicious package. If there's a false positive you found, can you provide a link?

does SAST take into account eslint usage? a linter is a static analysis tool just like codeql, depending on how it's configured.

We want to improve this check TODO I envisage adding support for commmands as well

publishing from CI is not something i'd call a best practice, at least in the npm ecosystem - it's impossible to do it with 2FA, since using an authentication token is just a single factor.
Signed-Releases: what's the benefit of signing releases in an ecosystem where the majority of users (or their tooling) don't verify them by default? Measuring whether releases are signed, before making that actually a beneficial action, seems like putting the cart before the horse.

yes, we'd like to have checks be more ecosystem-aware. This is on our radar, but needs work.

Fuzzing: given that CI logs are not persistent (GHA deletes them in 30 days, i believe, and travis deletes them on a rerun) a fuzzing tool that doesn't eternally persist previously failed input seems like it doesn't add much value. Why is this an objectively cross-ecosystem best practice?

/cc @oliverchang

I'd love to chat more about this 🙂 metrics that add value are great, but simply assigning a number to something brings a risk of unintended consequences/perverse effects, like incentivizing me to make a sock puppet account solely to code review all my changes, to satisfy the "2 contributor" requirement.

good point.

@ossf/scorecard-maintainers -- Some of these points are familiar, so wherever possible, let's reference existing discussions/issues/PRs. I just want to make sure we capture all of @ljharb's questions as a first step! :)

It only verifies that there's a lock file when it's used in CI, so you get "reproducible" installation and don't suddenly fall victim to "npm color" attacks if someone pushed a malicious package

I don't think this is actually a best practice - I think that a package should fall victim to the same attacks and bugs that their users will on a fresh installation, and that encouraging lockfile use in packages actively harms users by hiding problems from maintainers. The false positive imo is that this is considered at all.

I don't entirely follow. How would a maintainer of package X control how users will use their package? Even if the maintainers of package X want to protect themselves in their CI tests (I think they should), they would not be able to control what their users will do or when installing X, right?

Speaking for the npm ecosystem, most lockfiles are "dev only", which means that a project with a lockfile has a pinned graph, but their consumers have nothing pinned. There's also one lockfile format that is published, and that is respected by consumers - but it's considered highly user-hostile to use this, because it prevents the consumer from deduping, and from seamlessly updating transitive deps.
The belief I'm professing here is that the CI on a public project isn't worth protecting in this fashion in general terms, but it's definitely less important than ensuring that maintainers are notified as early as possible about issues in their dep graph. With a lockfile, the project will continue passing CI even as users who newly install it get bugs or security vulnerabilities - without one, the project's success or failure matches that of the users, and the problems can be fixed much more rapidly.

The belief I'm professing here is that the CI on a public project isn't worth protecting in this fashion in general terms, but it's definitely less important than ensuring that maintainers are notified as early as possible about issues in their dep graph. With a lockfile, the project will continue passing CI even as users who newly install it get bugs or security vulnerabilities - without one, the project's success or failure matches that of the users, and the problems can be fixed much more rapidly.

There are two different classes of problems:

Security vulnerabilities, i.e non-intentional problems. Good dependency patches/alerts are definitely really useful.
Intentional, malicious packages. Dependency alerts don't help that much here, right? Pinning can limit the spread of problem. Remediation and incidence response are expensive, as we've seen in log4j

Right - but a dev-only lockfile (the almost exclusive kind used in the npm ecosystem) does not pin dependencies for consumers, only for the maintainers. The best practice in the npm ecosystem is to always use ^ on dependencies and never, ever pin them - that's always only the job of the top-level app (with a lockfile).
I'm not fully versed on log4j, but wasn't the issue with log4j a problem because of a ton of applications that were pinned, and thus when the long-standing vulnerability was discovered, they weren't able to upgrade to the fixed version?

Right - but a dev-only lockfile (the almost exclusive kind used in the npm ecosystem) does not pin dependencies for consumers, only for the maintainers. The best practice in the npm ecosystem is to always use ^ on dependencies and never, ever pin them - that's always only the job of the top-level app (with a lockfile).

I think that's what the scorecard check does, i.e., that the final top-level app uses a lock file. If someone tests an API in their CI, scorecard will also check they've added a lockfile for the CI check, but not the overall project.

I'm not fully versed on log4j, but wasn't the issue with log4j a problem because of a ton of applications that were pinned, and thus when the long-standing vulnerability was discovered, they weren't able to upgrade to the fixed version?

log4j was an example of how remediation takes time and limiting the blast radius helps.
The npm color package attack is one that affected may people due to lack of pinning. Would the changes been malicious, it would have created a lot of work for remediation.

The scorecard runs on projects tho - a published project isn't a top-level app, generally (altho sometimes it can be).

About the lockfile, is your thought that:

A library should not use a lockfile, because that will conceal dependency-induced failures that might be caught by tests.
The scorecard should distinguish between libraries and apps

Sure, in this one case - less than a dozen over the lifetime of npm, by my reckoning - this is true. However, not pinning has allowed the seamless flow of bug and security fixes, and also allowed apps to dedupe, resulting in significantly smaller bundle sizes, saving the web uncountable amounts of bandwidth.
I’m saying that the benefits of pinning in a package are infinitesimal, and the harm of pinning is massive.

Some additional feedback: pinning an action to a tag is perfectly fine when the author is trusted, and is far better for security because security fixes can freely flow downstream.

Some additional feedback: pinning an action to a tag is perfectly fine when the author is trusted, and is far better for security because security fixes can freely flow downstream.

What happens if the author account is compromised? How do you deal with that?

The same thing that happens if the author account is compromised, they update the action to have well-hidden malicious code, and then someone rubberstamps a dependency update PR - be compromised.
In practice, this simply is not a thing that actually happens. Additionally, this is on open source published packages - there's nothing to compromise because nothing is done in the actions. In most cases, they don't even have permissions to do anything (via actions config).
This level of paranoia is appropriate for an application - but it's actively harmful for a published package.

This would be a good panel discussion at something like https://events.linuxfoundation.org/openssf-day-europe/.

In cases where there are no permission, I agree that pinning does not help and incur additional work for maintainer to maintain / update. @ljharb is this what you meant or you had a different example in mind?
The point on developer trust is interesting. It's hard for scorecard to do out of the box, but allowing consumers to tweak the results based on developer's identity would be interesting. What signals would you use to assess a "developer's trustworthiness" (2FA, projects they contribute to, ?)?

That’s up to each maintainer. GitHub’s official recommendations, for example, say that pinning an action to a tag is sufficient for an action author the maintainer trusts.
The scorecards system fails to be useful if it tries to editorialize too aggressively - when something is sometimes safe and reasonable, if the scorecard penalizes maintainers for it, the scorecards themselves stop being well-considered and useful.


[UI] Added customization options for menu and dashboard elements

Description
Hello!
I wanted to use dark red as the @primary-color, but after I'd set it, some elements turned grayish-red, which wasn't suitable for me. I decided to introduce some new optional variables for config.json.
This PR adds features that allow users to stylize:

selected menu item & hovered table rows via @primary-color-light,
gauges on Root-domain admin dashboard via @dashboard-graph-,
tiles on custom-domain admin dashboard via @dashboard-tile-.

Introduced all new variables in the ui/docs/customize.md.
Tested it with and without the variables set.
Focused on unchanging the default behavior (color palettes), so that default bg-colors will be the same as before.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[X] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

[ ] Major
[X] Minor

Screenshots (if appropriate):

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5937 (SL-JID-1098)


Reduce Docker image size

Reduce Docker image size from 741.39 MB to 293.86 MB

Ah man - if I like one thing in this world, then it is efficiency. 👍

Merged latest master. Ready for second Code Review
Final image size is now 316.18 MB

Excellent

My goal was to have only production dependencies in node_modules, but in current master we have npm prune --production command and now Dockerfile uses layers to not include cache so IMO it is OK.
We can remove some dev-build files in final Docker image (packages-lock.json, test, vite.config.js, extra (without healthcheck.js), kubernetes (?)):

But we can save less than 1 MB, so I'm closing this PR
Feel free to comment. Maybe I missed something

FYI: Current Docker image sizes:

Thanks, I did not merge this request because multi-stage was new to me.
Until I learned it yesterday. Wow, it is too good. I think all Dockerfile should be in this way.


Is there any related papers for this code as a reference?

Hi. This code is for beginner which contains only basic concept of speaker recognition.
You can refer my paper below.
"Spatial Pyramid Encoding with Convex Length Normalization for Text-Independent Speaker Verification"
The code does not deal with the algorithm of the above paper, but the naive model is implemented in the code (the model using global average pooling and cross entropy loss).
Thank you.


New release?

Hello,
first thx for your plugin. A little problem, i cant use it because of flutter 3 and gradle issues. I see u already merged the pull request to fix this but there is no version released for flutter 3 compatibility. Are there any plans to make a new release?

Renan was going to check about bumping some more things and check that everything was working today and then we're ready for a new release.

0.2.0 is out!


Editing messages via InputBotInlineMessageID results in MESSAGE_ID_INVALID for some users

Hi!
Recently, while migrating a bot to the Python Telethon library, I stumbled upon a very weird behavior.
For some users, editing messages via inline query doesn't seem to work.
After looking through the code, the maintainer and I couldn't find a reason for this behavior in the python code base, since the payload sent to Telegram was formatted as specified in the docs. The issue seems to even exist in other telegram client libraries.
Original issue: https://github.com/LonamiWebs/Telethon/issues/1398
In there you can find a minimal python example and additional information about the bug.
Symptoms:
Messages shared via inline query cannot be edited for some users and result in a MESSAGE_ID_INVALID 400.

The messages definitely do exist
Buttons on those messages work, the bot receives the callback query
When trying to edit the message with the exact same dc_id, id and access_hash as received from the original inline feedback or callback query payload, this error pops up.
It doesn't happen to everyone, but affected users can reproduce the issue deterministically

Either there's something fundamentally wrong in what we're doing or there is some weird bug.
Anyway, I would appreciate any help with this. This is currently the last blocker to migrate the Ultimate Pollbot to Telethon.
Example for a failing payload. Send via @nukes_test_bot:
EditInlineBotMessageRequest(
    id=InputBotInlineMessageID(
        dc_id=2,
        id=1815815020588675696,
        access_hash=1957312065933721233
    ),
    no_webpage=True,
    message='Callback response text',
    media=None,
    reply_markup=ReplyInlineMarkup(rows=[KeyboardButtonRow(buttons=[KeyboardButtonCallback(text='callback response', data=b'100:0:0')])]),
    entities=[]
)

Relevant TG docs:
https://core.telegram.org/method/messages.editInlineBotMessage
https://core.telegram.org/constructor/inputBotInlineMessageID
Relevant Telethon docs:
https://tl.telethon.dev/methods/messages/edit_inline_bot_message.html
https://tl.telethon.dev/constructors/input_bot_inline_message_id.html
Thanks in advance!

Relevant Links from Lonami + confirmation that other libraries are affected:
https://github.com/LonamiWebs/Telethon/issues/1398#issuecomment-597638896

The problem is in the usage of the method. You send the request to a wrong datacenter. InputBotInlineMessageID.dc_id is an exact datacenter ID to which the request must be sent.

The problem is, that we're using the exact dc_id we're getting from over here: https://core.telegram.org/constructor/updateInlineBotCallbackQuery
https://core.telegram.org/type/InputBotInlineMessageID
updateInlineBotCallbackQuery.msg_id.dc_id to be exact.
There is no logic in between and no hard-coded ID handling.
Just to be absolutely sure, I just tried to manually set the dc_id and checked if it works for any dc_id in the range of 1 to 5. No luck with that.
However, one thing I noticed is that everything seems to work fine for users in datacenter 4, while users in datacenter 2 seem to experience problems. That might be a red herring, but it fits to your statement about dc_id's being wrong.

You must not change the dc_id. You must send the request to the specified datacenter. Telegram has a lot of datacenters. Most requests needs to be sent to the main user DC, but some requests needs to be sent to another specific DC. This is one of such requests, which must be sent to a specified DC and not to the main DC.

As I already said, I'm not changing the dc_id. I'm sending the dc_id for this specific message as I'm getting it from your API.
Nothing in between.
We use the same dc_id we get from the InputBotInlineMessageID.
Is there a quick way to write a minimal example for this?
My C++ is kind of rusty. Something like a skeleton for a C++ telegram bot using tdlib directly?

I said nothing about changing the request, The request is correct. I said that you send the request to the wrong place. Please forward my previous comments to Lonami, so he can answer how to send requests to the right DC using Telethon. to fix the problem

Ah ok. I misunderstood your responses. Sorry for the unnecessary ping-pong. I wasn't aware that requests are explicitely sent to specific datacenters. I assumed that there is some kind of internal routing for this stuff.
I'll redirect your response to Lonami.
Sorry again for any inconveniences.


Should we really include peepin?

I noticed
https://github.com/mozilla/sugardough/commit/c37806aec247702f6ddfe2177f25e4550084ec1a
(cc @glogiotatidis )
I wonder if there's value in including it. It's a personal choice to use it and you certainly don't need it in runtime or for running tests.
I don't think it should be included because peep install -r requirements.txt gets really slow if the list starts to get long. That's because peep has to do a LOT of I/O work.
PS. I'm the proud author of peepin :)

I included peepin because I believe it's a useful tool for development. Most -if not all- sugardough based projects will include more packages in requirements.txt so they will need peepin at some point. That being said we should include documentation on how to use peepin to update requirements. I agree that using peepin is a personal choice but I see sugardough as promoting best practices and peep with peepin is one of them. If one doesn't like it they can remove the line and don't use it (same with peep).
So why include it in requirements.txt and not have a separate requirements-dev.txt? In masterfirefoxos project (based on sugardough) we build a Docker development workflow in which we decided to build a docker image and then run tests against that image and if they pass we deploy that very same image. This way we eliminate the difference between the development environment and production. Long story short: In masterfirefoxos we will install both dev only packages and prod packages so we are OK with one requirements file.
If that's not useful generally and people prefer to have two requirements (requirements.txt and requirements-dev.txt) we can go this way. We would move other packages too to the new file, e.g. flake8

Thanks for that update. I really appreciate it.
I'm still a noob on all things Docker so I bet I don't understand the needs there as well as others do.
Perhaps one way to satisfy this discussion is to consider using -r to include other requirements files.
For example, for runtime you might only need requirements.txt and for travis and Docker you need to install mock, coverage, nose, peep, peepin etc. so you list those in requirements-all.txt which looks something like this:
-r requirements.txt  # the base system
# sha256: owdsfhsodifjsdpof
mock==1.2.3
# sha256: w0oirjvw0oivjh
peep==2.3.4


suggestions for compiling and installing

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
the compiling and installing are too slow.
if I get an error in the middle steps, I have to go back to the first step and redo step by step.
the network is not good for me, this makes it worse.
it's difficult for me to understand the detailed procedure of compiling and installing.
if I can't get the detail, I can't complete my job.
for example:
the gluten uses too many building tools, such as mvn、cmake、ccache...
I can not execute the bash script manually, because these scripts take so many arguments, I don't know how to pass the correct arguments.
making the user think is not a good way, the best compiling script is without arguments provided when execute, of course, the user can modify the variable in the script to change its behavior.
Describe the solution you'd like

make download、build、install separate
provide a script to compile CPP or a specified directory, it's no need to provide any arguments
think more about easy usage

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

https://github.com/oap-project/gluten/pull/610 will fix this issue.

#610 will fix this issue.

well done, thank you very much!


fix test broken by NetworkX update

networkx 2.4 removed graph.node in favor of graph.nodes

Coverage decreased (-0.2%) to 88.13% when pulling 849131d68b0a3fc474befdbc9250b7a161c95fa0 on fix-networkx-update into bf4e4374fe925c6d5944b1d6016b812b8f4d3915 on master.

Coverage decreased (-0.2%) to 88.13% when pulling 849131d68b0a3fc474befdbc9250b7a161c95fa0 on fix-networkx-update into bf4e4374fe925c6d5944b1d6016b812b8f4d3915 on master.


Fewer calls to Composite.iterComponents

Description
This PR intends to close #1211 by changing a lot of calls to Composite.iterComponents to do something else.
Most calls are for aggregation / reduction methods. To sum mass, rather than using iterComponents to find the mass of all components, each object in the composite tree just sums mass of all it's children.
There are a few other places that would still rely on iterComponents cross section manager
https://github.com/terrapower/armi/blob/5e808270f31504895559897c7112259c56fc035d/armi/physics/neutronics/crossSectionGroupManager.py#L351-L367
that I'm open to addressing here, or in a second PR if this is well accepted.

Checklist

[x] This PR has only one purpose or idea.
[x] Tests have been added/updated to verify that the new/changed code works.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[ ] The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
[x] The documentation is still up-to-date in the doc folder.
[x] The dependencies are still up-to-date in setup.py.

@drewj-usnctech Okay, sorry for the absurd delay.  I only have one question above.
@opotowsky Other than my one question, this PR is minimal and safely invisible to our downstream projects.

@albeanth @john-science is there anything delaying this PR from getting merged?

Not from my end no. Just John's approval. I've already run this PR on our downstream testing and it does not require any updates.

@drewj-usnctech I am SO SORRY this PR hasn't been merged yet.
And because it sat for so long (our fault), it needs to be updated with ARMI main. Could you do that and we can get this merged today?

@drewj-usnctech I am SO SORRY this PR hasn't been merged yet.
And because it sat for so long (our fault), it needs to be updated with ARMI main. Could you do that and we can get this merged today?

@opotowsky sorry, was out last week. Changes have been incorporated. Let me know if there's anything else that's needed

Thanks so much @drewj-usnctech! I'll merge as soon as CI is done.


added infrared stream

tested with realsense sr300 on ubuntu 16.04.2 (4.4.0-75-lowlatency kernel) and librealsense v1.12.1

thanks for the contribution, though can you change the branch from master to dev?


manifests: Skip pod anti affinity for nil labels

What this PR does / why we need it:
At kubevirt provider we pass "nil" labels to the deployment defaults configurator, that should skip pod anti affinity, but a bit was missing to do so.
Whitout this the kccm deployement end up with
 podAntiAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
      - labelSelector: {}
        topologyKey: kubernetes.io/hostname

Which prevent it from schedule.
The pod anti affinity feature was introduced by https://github.com/openshift/hypershift/pull/3286
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/cc @sjenning

/approve
/lgtm
How was this not caught in the kubevirt e2e?

/area control-plane-operator


Fluxify further

-Now that most search objects read data directly from the store, and expect the store to have the data needed by the time they render, there is no reason to propagate these values down. Cleaned up a lot of the props/state values that are now read from the store. In some cases they are still used in a state in order to trigger updates, since it's not recommended to use forceUpdate.
-Cleaned up some unused actions and unused methods in some objects.
-Pulled the row limit into the store and added this to the params when running the query. This will give us a way to change this within the store in the future. I do not have an action for this yet, since it's not needed, but I did test it out using different values and pagination and views seem to work fine with values other than the default of 12.

:+1:

See comment then :+1:


Windows installation - problems with compiling

Hi,
I am having some troubles installing usaddress on windows (windows 7 64 bit, python 2.7 32 bit) using pip and am hoping you may be able to give some hints on compiler settings that work on windows. It appears that visual studio 8 is not able to compile it and that g++ is required. I tried installing mingw (both 32 and 64) but run into errors. The last part of the command output is below but I do not have insight into what I am doing wrong or what is wrong with my setup. Any hints would be appreciated.
Michael
c:/mingw/bin/../lib/gcc/mingw32/4.5.2/../../../../mingw32/bin/ld.exe: build\temp.win32-2.7\Release\pycrfsuite_pycrfsuite.o: bad reloc address 0xc in section `.data'
collect2: ld returned 1 exit status
error: command 'g++' failed with exit status 1

Update: The problem related to the installation of python-crfsuite on windows. The solutions can be found here - https://github.com/tpeng/python-crfsuite/issues/16, although hopefully the python-crfsuite package will be updated to automatically avoid this issue in future.

I put in a fix upstream in python-crfsuite. It's in the repo but hasn't been pushed to pypi.

@fgregg i just pushed it to pypi.


fixed the typo on the comments

Thanks @vr001!
Fixed via #67dbf50, sorry we're not able to accept contributions without signing the CLA.

I signed it!


Crashes on second "/wiki" command

Describe the bug
The game crashes after 2 uses of the "/wiki" command.
To Reproduce
Steps to reproduce the behavior:

Run the  "/wiki" command twice with any argument.
The game crashes and doesn't process the second wiki request.

Expected behavior
I would expect the game not to crash and open the correct wiki page.
System configuration (please fill in):

OS: Windows 11
GPU: NVIDIA RTX 3060
Chainloading: BlishHUD -> Arcdps BlishHUD Integration -> arcdps -> GW2Clarity

Additional context
I am using the updated getbuffs.dll.

Do you have that issue without Clarity? Without any addon?

It doesn't happen when I remove Clarity.

Actually, it doesn't crash if I remove any of BlishHUD, arcdps or GW2Clarity.
It only crashes if the 3 are running.

That tracks with what I've been able to gather from other devs. Looks like it's a problem with certain configurations with no clear cause, so we're just waiting for a fix. I'm afraid there's nothing I can do.


fix: Weird scrolling in FluentDialogs

🐛 Bug Report
I'm using both bootstrap-grid.min.css and bootstrap-utilities.min.css in my project. In addtion I've added the CSS to display bootstrap tables in my project. When I display a large table now within a FluentDialog (which causes scrolling) I'll get this weird scrolling behaviour where it first scrolls within just a little bit and then starting to scroll normally. Whenever I reach the top or bottom again, the same behaviour reoccurs. I've tried to catch it in a video for you.
https://github.com/user-attachments/assets/7aac9088-ae74-4f10-9914-0326667b4000
💻 Repro or Code Sample
I've created a small sample repo which can be found here: https://github.com/MarvinKlein1508/FluentUI-Scroll-Issue
🤔 Expected Behavior
I expect the content in the FluentDialog to be normally scrollable.
😯 Current Behavior
It only scrolls for a few pixels and then gets stuck until you start to scroll much harder.
🔦 Context
I've noticed the same behaviour a couple of times already also when using Fluent components like FluentGrid or FluentStack. This is also the reason why I've switched back to the bootstrap grid.
🌍 Your Environment
This seems to be a Firefox specific issue. It works fine for me in both Chrome and Edge
EDIT: It also works fine in Safari for me.

I think you need to fix the height of the dialog. For example with a --table-responsive-height CSS variable.

Updating your App.css file
body {
   --table-responsive-height: calc(100vh - 100px);
}

.table-responsive {
   height: calc(var(--table-responsive-height) - 200px);
   overflow-x: auto;
   -webkit-overflow-scrolling: touch;
}

Setting the Height property in your Home.razor file
DialogParameters parameters = new()
   {
       Height = "var(--table-responsive-height)",
       ...
   }

@dvoituron this seem to work. However this is not an optimal solution because it will always display all tables with this class with 100vh. It depends from customer to customer. With this approach all of my responsive tables would have 100vh of height.
In Bootstrap it ain't an issue either. See https://getbootstrap.com/docs/5.3/components/modal/#scrolling-long-content
I really want to have the height of the table set to auto. Isn't there any way to fix this for the dialog itself with some sort of CSS adjustment?

Of course, you need to adapt this sample with your project. For example, to apply the style only if it is used in a fluent-dialog (or using another CSS if you prefer).
.table-responsive {
    -webkit-overflow-scrolling: touch;
    height: calc(var(--table-responsive-height) - 200px);
}

fluent-dialog .table-responsive {
    overflow-x: auto;
}

Hmm I mean more like the FluentDialog supporting this out-of-the box. I really don't like to specify this kind of stuff by hand.

Hmm I mean more like the FluentDialog supporting this out-of-the box. I really don't like to specify this kind of stuff by hand.

We can do that for the v5 but not for the current version.

I'm fine with that! :)

@dvoituron can you add v5 tag here?
It would also be super nice if you can take it into consideration for FluentGrid and FluentStack in v5. I get the same scrolling behaviour with those components a lot as well.

Closing this one as a workaround is provided. We have the v5 work on another list


[BEAM-14297] Enable nullable key and value arrays for xlang kafka io with metadata

Update the schema to enable null arrays for keys and values when xlang kafka io is used with metadata

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Run Java PreCommit

Run Java Precommit

R: @pabloem

LGTM


Identifiers validation failed for dataset Herpetology

Identifier validation failed for the dataset Herpetology:

Crawler attempt: 316
Publishing organization: Academy of Natural Sciences
Publishing country: UNITED_STATES
Installation: ANSP IPT Installation
Number of occurrences indexed for this dataset at the time of the issue: 35548
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 39065 total records; 39065 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/4142789/step

New IDs sample:

Old IDs sample:

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Herpetology : https://doi.org/10.15468/2wlj2m.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Herpetology:

Crawler attempt: 317
Publishing organization: Academy of Natural Sciences
Publishing country: UNITED_STATES
Installation: ANSP IPT Installation
Number of occurrences indexed for this dataset at the time of the issue: 35548
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 39065 total records; 39065 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/4142896/step

New IDs sample:

Old IDs sample:

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Herpetology : https://doi.org/10.15468/2wlj2m.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


Added ECommerce App to React folder

Please review and merge my PR request. Thanks in advance.

😅 Hogye 4 PR merge 🤣

Thank you @codersalman


feat: add support for transit secrets engine

Resolves #5
This implements most of the transit secrets engine API, minus importing external keys or batch_input parameters (but would be easy enough to add on top).

#22 added base64 as a dependency and was recently merged. You might need to update your local copy, it looks like there's duplicates.

No worries, I've rebased against the current master.

Thanks again for the PR!


Moment Zulu Time IE11

Hello.
I've had an issue on IE11.
i was trying to do something like
moment('2018-10-12Z').format('x');
And as result i got NaN
if i do moment(`2018-10-12`).format('x'); all is working fine.
In chrome actually it is working in both cases.
Did someone notice same issues ? Why it is not working ?
As workaround i did moment(new Date('2018-10-12')).format('x')
seems like this is same as doing moment('2018-10-12Z').format('x');. am i right ?
Thanks !

This is a great question for Stack Overflow.


pull secret is missing: secrets "XXX-pull-secret" not found

Describe the bug
We have succescfuly installed the Dynatrace Operator to Openshift (version: 4) test environment.
But Prod install fails with following error:
dynatrace:XXXX-pull-secret' pull secret is missing: secrets "XXXX-pull-secret" not found
To Reproduce
Run the following command:
oc adm new-project --node-selector="" dynatrace
oc apply -f https://github.com/Dynatrace/dynatrace-operator/releases/download/v0.10.0/openshift.yaml
oc -n dynatrace wait pod --for=condition=ready --selector=app.kubernetes.io/name=dynatrace-operator,app.kubernetes.io/component=webhook --timeout=300s
oc apply -f dynakube.yaml
dynakube.yaml was generated by Dynatrace Managed Environemnt (version: 1.256.125)
apiVersion:` v1
data:
apiToken: ZHQw...jJE
kind: Secret
metadata:
name: xxxx-prod
namespace: dynatrace
type: Opaque
apiVersion: dynatrace.com/v1beta1
kind: DynaKube
metadata:
name: smart-prod
namespace: dynatrace
annotations:
feature.dynatrace.com/automatic-kubernetes-api-monitoring: "true"
spec:
apiUrl: https://dynar.service.org/e/9...e/api
Expected behavior
Operator Activegate starts up and connects to Dynatrace
Screenshots
0116 20:11:57.582976      16 request.go:682] Waited for 1.041367766s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/security.internal.openshift.io/v1?timeout=32s
[namespace ]    --- checking if namespace 'dynatrace' exists ...
[namespace ]     ✓  using namespace 'dynatrace'
[crd       ]    --- checking if CRD for Dynakube exists ...
[crd       ]     ✓  CRD for Dynakube exists
[          ]    no Dynakube specified - checking all Dynakubes in namespace 'dynatrace'
[          ]    xxxx-prod
[dynakube  ]     |--- checking if 'dynatrace:xxxx-prod' Dynakube is configured correctly
[dynakube  ]     |    using 'dynatrace:xxxx-prod' Dynakube
[dynakube  ]     |    checking if api url is valid
[dynakube  ]     |    api url is valid
[dynakube  ]     |    'dynatrace:xxxx-prod' secret exists
[dynakube  ]     |    secret token 'apiToken' exists
[dynakube  ]     | X  'dynatrace:xxxx-prod-pull-secret' pull secret is missing: secrets "xxxx-prod-pull-secret" not found
[dynakube  ]     | ⚠  Skipped 'pullSecretHasRequiredTokens' check because prerequisites aren't met: [pullSecretExists]
[dynakube  ]     | X  'dynatrace:xxxx-prod' Dynakube isn't valid. Target namespace and dynakube can be changed by providing '--namespace ' or '--dynakube ' parameters.: 'dynatrace:xxxx-prod-pull-secret' pull secret is missing: secrets "xxxx-prod-pull-secret" not found
[dynakube  ]     | ⚠  Skipped 'DynatraceClusterConnection' check because prerequisites aren't met: [dynakube]
[dynakube  ]     | ⚠  Skipped 'imagePullable' check because prerequisites aren't met: [dynakube]
[dynakube  ]     | ⚠  Skipped 'proxySettings' check because prerequisites aren't met: [dynakube]
Desktop (please complete the following information):

OS: Linux
Browser chrome
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Thank you for opening a Dynatrace Operator Issue. We've identified and tagged the issue as a "Support request".
Dynatrace responds to requests like these via Dynatrace ONE support rather than Github. This helps our team respond as quickly as possible using the support team's tools and procedures.
Thanks for your help!


ci: resolve conflicts

I resolved conflicts and outscoped loadbalancing for CRD mode
https://github.com/caos/orbos/blob/c357152a6a2213a0fe2d9619528719de197415c1/internal/ctrlcrd/networking/networking.go#L49

#603


Initiate polling via automation instead of HA

Is there any mechanism to initate polling of data by automation e.g. in case of starting charging by HA?
Originally posted by @andreasengelsberg in https://github.com/skodaconnect/homeassistant-skodaconnect/issues/210#issuecomment-1729684986

Is there any mechanism to initate polling of data by automation e.g. in case of starting charging by HA?
Originally posted by @andreasengelsberg in #210 (comment)

The problem is how to know when to start polling if states aren't polled regularly.
It's possible to implement shortened poll interval under some circumstances such as charging/climatisation.
However if the purpose is to prevent the rate limiting I think it's better to explore other options. One being cache and another "night time" poll interval.

This will be solved by making the polling interval available to be changed, so you could use automation to influence it. We will not support an automation to start/stop polling.

FWIW, someone on Discord mentioned this might just be natively supported by HA. I haven't tried this myself but in theory:

Settings -> Devices -> Skoda -> System Options -> Uncheck Enable polling for updates
Use the homeassistant.update_entity service to trigger an update on demand


Add support for promises in schema builder

Environment
Knex version: 0.21.1
Database + version: NI
OS: NI
Feature discussion / request
Currently, most of Knex's API return Promises allowing you to await the value:
const records = await knex.select("*").from("articles");

however, the same doesn't apply to the Schema builder methods:
const table = await knex.schema.table("articles"); // << doesn't work

Explain what is your use case

As part of the coding style of a project, we're heavily relying on async/await and promises to avoid a callback hell. It would be nice to be able to maintain this style when working with the schema builder as well.

Explain what kind of feature would support this

Allowing you to rely on async/await in the schema builder, instead of the callback:
const table = await knex.schema.table("articles");
// etc

instead of
knex.schema.table("articles", function(table) {
  // etc
});

Seeing knex.schema.table's callback doesn't adhere to Node's standard callback format function (err, data) {}, it's impossible to use promisify to work this in unfortunately

Ah, it seems like this is already using a promise under the hood, based on https://github.com/knex/knex/issues/1221#issuecomment-187551650.
It wasn't clear from the docs that you're required to add a .then() to the alterTable statement in order to execute it. Apologies for wasting your time reading this ✌


Support schema update via OLC

Add the feature to update a schema in the OLC.
The check is done on the modifyTimestamp in LDAP

@antoine-roux could you please add unit and acceptance test to prove that it works and to prevent future regression?

This was merged as #212


Add tlc59731 strip led driver

This patch series add driver support for TI TLC59731 RGB controller, along side the changes applied for STM32WB5MM_DK board and a demo samples based on this board.

Needs rebase

Needs rebase

Should I rebase to the main or maybe open a new PR?

Needs rebase

Should I rebase to the main or maybe open a new PR?

Rebasing on main should do.

@simonguinot can you re-review please?

@simonguinot can you re-review please?

The code review is complete and apart from the fact that this driver uses GPIO to configure the LED strip, it is now in good shape.
But I am not sure if it should be merged... @javad123javad, are you still working on an SPI implementation ?
@soburi @thedjnK what do you think ?
I am implementing the SPI version in another branch. The development is completed, however, there are some problems relating to the pulse timing that prevent it from working properly.
For this branch, I have applied the suggested changes and seems to be ready to merge.

@simonguinot se can this be merged?

@simonguinot so can this be merged?

Yes this can be merged.

Implementation is OK but since we are ready with #71630 can you adjust PR to follow that? Colour grouping is needed and the led strip yaml file can include the new binding, hopefully other can be merged tomorrow

Sure, I will apply the changes after #71630 is merged. Because there are some dependencies that I need from this PR.

@javad123javad can be updated


Support better K8s Resource Name editing

https://issues.redhat.com/browse/RHOAIENG-583
Description

Provides a new cleaner interface to manage DisplayNames & Descriptions & K8s Name generation. This component will provide a unified front for any element we need to manage K8s items with.
ONLY REFACTORS Project modal & Workbench form. There will be more that can use this.
Screenshots
Project Modal:

Click to expand more Project Screenshots
These are in chronological order of operation.
Initial State:

Just Display Name Added:

Looking at the resource name:

Make the display name too long:

Make the resource name exceed max characters:

Throw on an invalid character:

Trim it back to the max (no auto trimmed action, so no warning):

Clear out the resource name:

Make an invalid k8s name that is short:

Make it a valid k8s name:

Workbench screen (only the workbench name is configured this way -- other resources created here are not YET):

How Has This Been Tested?

Using the Create/Edit Project Modals & the Create/Edit Workbench Forms.
Test Impact

Added unit tests for the new component. Created a Cypress Page object and refactored the Project/Workbench page objects to use it. Existing Cypress tests should cover the Project modal & Workbench form; minor adjustments made for new design.
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

@xianli123 @kywalker-rh Please review the screenshots (they are in a collapsed section, look for the header in the description and expand it)

Thanks @andrewballantyne . It looks great.
There is one point we could discuss, and I have attached a graph below.
Is it possible that the input automatically truncates to the first 30 characters when the user inputs more than 30 characters? At this moment, the warning message is displayed below the input field. In this way, it could enhance the user experience by eliminating the need for users to manually remove excess characters. What do you think? cc @kywalker-rh

Thanks @andrewballantyne . It looks great.
There is one point we could discuss, and I have attached a graph below. Is it possible that the input automatically truncates to the first 30 characters when the user inputs more than 30 characters? At this moment, the warning message is displayed below the input field. In this way, it could enhance the user experience by eliminating the need for users to manually remove excess characters. What do you think? cc @kywalker-rh

I don't understand the desire -- why don't we limit bad characters... why even have error states? I feel the feedback is most commonly done via when they manually type into the field not to "stop them" but to inform them?

Reviewed this with @andrewballantyne in the slack thread. Our decision is to remove the yellow warning text when the resource name has been truncated. Once that change is made this lgtm. cc: @xianli123

Changes needed to page objects & UX implementation

I agree with you on the update. @kywalker-rh. After the change, it will LGTM.

@xianli123 @kywalker-rh Okay, updated the screenshot in the description.
New state when you type a too long display name (and we auto translate it for k8s):

Looks great, thanks @andrewballantyne!

LGTM! Thanks @andrewballantyne .

I found an incorrect helper text condition. The second helper text should be an error in this situation.
Reproduce:
Don't touch the k8s name and input the display name as - (or anything ends with -)
The form is not able to be submitted, which is good because the name is invalid, we just need to update the logic to show the second helper text as an error state.

Last commit addresses the special character situation. I also rebased to get rid of the conflict


[Feature]: net9 docker images

🚀 Feature Request
Please can we get net9 docker images?
Example
We cannot upgrade to net9 until playwright docker base images support it.
Motivation
Want to upgrade to net9.

We recommend either to install net9.0 manually on top, see here or creating your own Docker image. Our Docker image only targets .NET LTS versions for simplicity.


Error:  Proxy is invalid (Excon::Errors::ProxyParseError)

Error:       Proxy is invalid (Excon::Errors::ProxyParseError)
Backtrace:   /usr/local/heroku/vendor/gems/excon-0.15.5/lib/excon/connection.rb:357:in `setup_proxy'
             /usr/local/heroku/vendor/gems/excon-0.15.5/lib/excon/connection.rb:34:in `initialize'
             /usr/local/heroku/vendor/gems/excon-0.15.5/lib/excon.rb:89:in `new'
             /usr/local/heroku/vendor/gems/excon-0.15.5/lib/excon.rb:89:in `new'
             /usr/local/heroku/vendor/gems/heroku-api-0.3.2/lib/heroku/api.rb:55:in `initialize'
             /usr/local/heroku/lib/heroku/auth.rb:75:in `new'
             /usr/local/heroku/lib/heroku/auth.rb:75:in `api_key'
             /usr/local/heroku/lib/heroku/auth.rb:185:in `ask_for_credentials'
             /usr/local/heroku/lib/heroku/auth.rb:217:in `ask_for_and_save_credentials'
             /usr/local/heroku/lib/heroku/auth.rb:80:in `get_credentials'
             /usr/local/heroku/lib/heroku/auth.rb:41:in `login'
             /usr/local/heroku/lib/heroku/command/auth.rb:22:in `login'
             /usr/local/heroku/lib/heroku/command.rb:179:in `send'
             /usr/local/heroku/lib/heroku/command.rb:179:in `run'
             /usr/local/heroku/lib/heroku/cli.rb:25:in `start'
             /usr/bin/heroku:25

Command:     heroku login
HTTP Proxy:
HTTPS Proxy:
Version:     heroku-toolbelt/2.30.2 (universal-darwin12.0) ruby/1.8.7

omg thank you!
had to remove the exports from my .bashrc as well as the no_proxy variable!

If i want to login into heroku from my linux box that is behind proxy server, how shld i be doing this.
I have already set http_proxy and https_proxy env var, but still getting this error message.
Thanks..

Hello,
I was trying to run the command behind a corporate firewall. Thanks to this thread I got to know what to set. Solved my problem by setting both HTTP_PROXY and HTTPS_PROXY to http://proxy.company.com:8080
Cheers!


NotesDatabaseTest not working

The program usually outputs "SupportSQLiteDatabaseException" and exits with error code 14. However, on other occasions it can output other errors as well.

It appears that the issue is caused by the app not having the permission required to create database, which as of now there is no solution that has a minimum API requirement of 19. Thus, this issue will be closed until a solution could be found.


choose rpm destination?

Is there a destination option for the rpm artifact?

Never mind - found it! e.g.: destinationDir = file('target/distribution')


After the user does a RPC POST Request, how do I make the server Response send a bunch of JSON back to the user - eg, multiple recordsets?

I'm trying to figure out how to use RPC to send a bunch of JSON to the server, to POST records to multiple tables - and then I want the server Response to send back a bunch of JSON to the client - possibly with some modifications (some records failed to INSERT, some field values altered due to validation errors, etc.).
For example, if the user attempted to POST an Order Line for a Quantity of Product - where the server determined that this Quantity exceeded the amount of Product currently available "in stock" - then the server Response could include a "Failure" flag - or (even better) the server Response could include all the submitted records, with some fields "adjusted" (or some records totally missing) to indicate the specific failures / validation errors.
I don't understand the following:

How do I copy the JSON from the output of the stored procedure called by the RPC POST Request, and into the server Response?

Is there some mechanism whereby the Response to an RPC POST Request automatically receives any output produced by the Stored Procedure invoked by that RPC POST Request?

Where would this JSON "payload" be placed in the Response? Can I put it in the body? (Does the Response to an (RPC) POST request even include a body??)

I've been reading here:
https://postgrest.com/en/v4.3/api.html#stored-procedures
https://github.com/begriffs/postgrest/pull/986
But I'm not sure how to do this.  But I'm unsure about some very basic things regarding how to "wire" all this together:

How does the server formulate its Response to an RPC POST?

Can I put a bunch of JSON in the body of this Response?

How do I "transfer" this return value from the output of the stored procedure to (the body of?) the server's Response to the user's RPC POST?

Example
Consider the following scenario involving a "master-detail" layout, where the user is editing one "parent" record, as well as editing one or more sets of "child" records:

There is a "parent" record on the top of the form layout, showing the Customer

There is a "child" recordset on one "tab" of the form layout, showing the Customer's Invoices

There is another "child" recordset on another "tab" of the form layout, showing the Customer's Reviews

So the HTML layout (eg, using Elm) displays the Customer record at the top - plus two "tabs":

one tab containing a list of the Customer's Invoices,

another tab displaying a list of the Customer's Reviews.

You can see a demo of a similar scenario here:
https://marmelab.com/admin-on-rest-demo/#/customers/11
(Look at the Orders and Reviews tabs - each of which displays a list of "child" records.)

So the user can perform the following:

Update various fields on the "parent" Customer record;

Add / change / delete various "child" rows on Customer's Invoices, and on Customer's Reviews.

Regarding when to actually POST the user's changes to the server, I guess there are two options:

POST the changes immediately - every time the user moves to a different record in the list of Invoices or Reviews (eg, when the current "child" record loses focus); or

Provide an explicit "Save" button on the bottom of the entire the form, and batch all the changes in a single RPC POST to the server (using custom code to bundle together a bunch of JSON to send in the body of this RPC POST, to be used as input to a stored procedure in Postgres).

By the way, I've been looking at GraphQL (and PostgraphQL) as an alternative way of doing this. It looks nice, but I don't really want to add another layer and another language between my client and my database. Plus I don't plan on writing an API to be consumed by lots of different clients - basically I want to write just one SPA app (Elm frontend), using PostgREST.
I'd feel safer writing my own stored procedures in Postgres to handle these sort of master-detail parent-child multiple-record multiple-table inserts / updates - using the proven ACID / transaction guarantees of Postgres directly - rather than learning GraphQL (and trusting GraphQL to provide the same kinds of guarantees).

So my question is:
I would like to get some useful information back from the server in Response to an RPC POST.

At a minimum, the server should respond with some kind of "success" or "failure" message.

Even better, it would be nice if the server would respond by sending back all the records which the user attempted to insert / update (eg: the "parent" Customer record, and all the related "child" records for the Customer's Invoices and the Customer's Reviews) - so the client could re-display them. This would provide a simple confirmation of exactly which changes by the user actually were actually committed to the database (more detailed than using a "toast" notification.)

For example, consider a slightly different scenario - now involving a "numerical limitation":

The "parent" record is not a Customer but now an Order,

The "child" recordset is a list of Order Lines (with fields: Product, Quantity).

Now the Quantity of Product entered by the user on an Order Line could exceed the "Quantity Available In Stock" for that Product.
After the user does the RPC POST, the server could inform the user of this problem by:

returning all the Order Lines - with some now showing an adjusted Quantity which is less than the original Quantity entered by the user; or

displaying a field on the Order Line (normally saying "OK") saying "Quantity too high - please revise!"

So what I want here is for the server to respond with all the records which the user attempted insert / update via the RPC POST - possibly with some changes.

I think that PR 986 might handle this sort of thing.

And I think I can return a bunch of recordsets from a stored procedure:

http://www.sqlines.com/postgresql/how-to/return_result_set_from_stored_procedure

And I found a nice function in Postgres called json_to_recordset which efficiently converts JSON to a recordset:

https://www.postgresql.org/docs/9.4/static/functions-json.html
I'm just trying to figure out how to "wire this all together".
Summary

How do I "transfer" (or "communicate" or "copy") the recordset returned by a Postgres stored procedure (which PostgREST called using RPC) to the HTTP Response sent to the client in Response to the RPC POST Request?

Assuming I want to send a big chunk of JSON back to the client in this Response - where in the Response do I put this "payload"? PR 986 seems to be talking about setting custom headers but that doesn't seem to be the proper place to put such a payload.

Can I put this JSON payload (outputted by the stored procedure called by the RPC) into the body of the Response to the RPC POST? If so, how do I copy this JSON from the output of the stored procedure to the body of the Response to the RPC POST Request?

Thanks for any help!

here is a function that receives a single param (json) and outputs it back as json
https://github.com/begriffs/postgrest/blob/master/test/fixtures/schema.sql#L340-L344
here it is being called
https://github.com/begriffs/postgrest/blob/master/test/Feature/RpcSpec.hs#L290-L304
the junction just needs to return json type, whatever it returns will be sent back to the user


Expand form subnodes right after their parents

Instead of just appending the expanded nodes at the end

Changed base branch to integrate fix into next release


[WIP DO NOT MERGE]: Prototype for getting instance ids

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@jolshan #17881 adds a "triage" label to PRs from non-committers. Turns out this also affect committers if their membership visibility in the ASF GitHub org is not public. I added instructions for setting your membership visibility to public https://github.com/apache/kafka/blob/trunk/.github/workflows/README.md#pr-triage

@bbejeck https://github.com/apache/kafka/pull/17881 adds a "triage" label to PRs from non-committers. Turns out this also affect committers if their membership visibility in the ASF GitHub org is not public. I added instructions for setting your membership visibility to public https://github.com/apache/kafka/blob/trunk/.github/workflows/README.md#pr-triage

@mumrah thanks for the heads up - I've made the membership public


Redirect to home page after login

After a user logs in, redirect the user to tasks home page

Closed via #12

Error code 403 occurring while signing in.
Error message: ApiException 403: {"id":"00000000-0000-0000-0000-000000000000","message":"sql: no rows in result set","code":"403"}


feat(bullmq): add bullmq (>=2) instrumentation

Add an instrumentation for BullMQ.
The initial work for this instrumentation was done by @jenniferplusplus at jenniferplusplus/opentelemetry-instrumentation-bullmq, of which both appsignal/opentelemetry-instrumentation-bullmq and the instrumentation in this commit are forks.
The instrumentation aims to comply with the Messaging Semantic Conventions (v0.24.0) whenever possible. Due to the latest published version of the @opentelemetry/semantic-conventions package not fully complying with the semantic conventions, when in conflict, the instrumentation chooses to follow the implemented shared package instead of the contents of the document.

It's good to see this happening. I'm glad the instrumentation has been useful to people, but I'm also glad to be relieved of it. It's not a stack I use anymore.
I'll be happy to mark my npm package as deprecated once this gets merged and published.

Thank you!
The same goes for @appsignal/opentelemetry-instrumentation-bullmq, we would deprecate it and move people over to the contrib-based instrumentation.

Hi @unflxw. We've recently added new contributing guidelines for new instrumentation libraries.
Is there a specific reason why you'd want @appsignal/opentelemetry-instrumentation-bullmq here in this repo as opposed to hosting and maintaining it in a seperate repo, ideally closer to the community that knows and maintains BullMQ?

@pichlermarc Thanks for letting me know! I had not seen these guidelines before.
Our belief is that it is valuable for this instrumentation to be visible to the OpenTelemetry community, as well as for its maintenance to be shared with the community at large. Nonetheless, I have added myself as the maintainer for this instrumentation in the component owners file.
We're not BullMQ maintainers ourselves. We run an OpenTelemetry-based APM, and we took on the task of improving this instrumentation in order to be able to offer it to our customers. So, while we can host it on a public repository of our own, as we currently do, it will not be a repository owned by the BullMQ maintainers. The BullMQ maintainer team has stated that they're not interested in maintaining the OpenTelemetry instrumentation.
The instrumentation, while popular enough to have tens of thousands of weekly downloads, was not under active maintenance. Part of why we forked it was to avoid imposing additional maintenance workload on @jenniferplusplus, as we implemented changes to it. We would hope to prevent further fragmentation of the instrumentation ecosystem and the work on it by sponsoring it under the OpenTelemetry banner.

Please let us know if there's anything we can do to help move this forward.


Enable astc transcode to dxt for iris and astc compute shader decompress for anv.

In this change, for iris, astc will be converted to dxt. for vulkan, astc will be decompressed using compute shader.
Tracked-On: OAM-117170

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web  for more details. For Binaries: /cactus-absp-or-local/celadon_smr0_master-merge/945


Update export_to values for technologies

Fixes: #1107
Fixes: #736
Part of: #1264

Thanks! Not sure why I hadn't merged this sooner... Anyway, I did so manually to fix a conflict.


USER_C_MODULES seems should be pointing to a root cmake file

Followed README.md, the build fails with latest MicroPython source:
make -j8 -C mpy-cross && make -j8 -C ports/stm32/ BOARD="PYBD_SF6" USER_C_MODULES="$(pwd)/ports/stm32/boards/PYBD_SF6/cmodules"
Turns out I have to go with :
make -j8 -C mpy-cross && make -j8 -C ports/stm32/ BOARD="PYBD_SF6" USER_C_MODULES="$(pwd)/ports/stm32/boards/PYBD_SF6/cmodules/micropython.cmake"

Sorry, it's duplicated.


[AIRFLOW-1350] dataproc_operator: Add parameter query_uri to Hive and…

… SparkSQL DataProc operator
Google cloud APIs allows users to submit jobs where the query
to be executed are stored in a separate file on GC storage.
In the current implementation this option is available only for
Pig jobs, whereas also Hive and SparkSQL should allow this. This
commit changes such a behavior by leveraging the same implementation
used for the Pig operator.
Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1350

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

Google cloud APIs allows users to submit jobs where the query
to be executed are stored in a separate file on GC storage.
In the current implementation this option is available only for
Pig jobs, whereas also Hive and SparkSQL should allow this. This
commit changes such a behavior by leveraging the same implementation
used for the Pig operator.
No UI changes or doc changes required (docs have been updated)
Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Since there was no unit test for this module and no relevant change, I did not change any test

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2402 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2402      +/-   ##
==========================================
- Coverage   69.26%   69.22%   -0.04%
==========================================
  Files         146      146
  Lines       11231    11231
==========================================
- Hits         7779     7775       -4
- Misses       3452     3456       +4

Impacted Files
Coverage Δ

airflow/jobs.py
74.87% <0%> (-0.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e870a8e...8429f24. Read the comment docs.

Nah, if it's consitent, that's fine. Let me merge.

+1 merged


Parallelize decryption of reports

I did the CPU utilization experiment you describe. It's not super compelling, since two shards * three helpers is already 6 cores, i.e., most of the performance cores on my laptop (and CPU utilization can get somewhat above 100% per shard even before this change), but there was an improvement.
I also logged the current tokio task ID when decrypting to confirm that decryption was being performed on multiple tasks.

most of the performance cores on my laptop (and CPU utilization can get somewhat above 100% per shard even before this change), but there was an improvement.

Have you had a chance to compare it with main? The reason I am asking is because I ran this experiment on main a few days ago and it was also showing > 100% CPU utliziation

I see the CPU utilization increase from ~110% per helper to ~150% per helper comparing main to this change.

But that said, I would be more confident in this change if we see a performance improvement on the real cluster. I don't think it will be harmful, but it is rearranging the order in which flattening of the stream and decryption happen. (Doing it in the preferred order ran afoul of 100013.) So there's a small risk.


Add an experiment for the new debug adapter

For #7026, add the code that checks whether we are in the debug adapter experiment, but do nothing with it for now.
Based on Don's PR #6858 but I couldn't push to his branch :'(

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[ ] Has a news entry file (remember to thank yourself!)
[ ] Appropriate comments and documentation strings in the code
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated
[ ] Test plan is updated as appropriate
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #7056 into master will decrease coverage by 0.4%.
The diff coverage is 78.33%.

@@            Coverage Diff             @@
##           master    #7056      +/-   ##
==========================================
- Coverage   58.31%   57.91%   -0.41%
==========================================
  Files         483      485       +2
  Lines       21347    21403      +56
  Branches     3445     3447       +2
==========================================
- Hits        12449    12396      -53
- Misses       8123     8219      +96
- Partials      775      788      +13

Impacted Files
Coverage Δ

src/client/common/application/types.ts
100% <ø> (ø)
:arrow_up:

src/client/debugger/extension/types.ts
100% <100%> (ø)
:arrow_up:

src/client/common/experimentGroups.ts
100% <100%> (ø)
:arrow_up:

src/client/debugger/extension/serviceRegistry.ts
100% <100%> (ø)
:arrow_up:

src/client/debugger/extension/adapter/activator.ts
100% <100%> (ø)

src/client/common/application/debugService.ts
26.31% <50%> (-1.47%)
:arrow_down:

src/client/debugger/extension/adapter/factory.ts
63.63% <63.63%> (ø)

src/client/testing/serviceRegistry.ts
48.64% <0%> (-46.85%)
:arrow_down:

src/client/testing/codeLenses/main.ts
44.44% <0%> (-33.34%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
66.66% <0%> (-33.34%)
:arrow_down:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a0e87...686ec8c. Read the comment docs.


SW-5013: Scoring entry component

This PR includes a new ScoreEntry component for the accelerator scorecards.
TODO

[x] Remove hacky demo code
[ ] Break out sub-components from ScoreEntry into discrete files?
[ ] Move many styles from sx prop to style props on the components?
[ ] Remove local state from SourceControl component?

Example
https://github.com/terraware/terraware-web/assets/1474361/720ec198-2ae3-4a16-8bb9-28548607d510

Thanks for the review, I appreciate it 🙌


Shape convention check

Hello Otto.
In line 200 of kalmanfilter the following dimension check is made, along with others:
n_states = state_transition.shape[0]
Should this be
n_states = state_transition.shape[-2]
to support the use of multiple transition matrices, or is that not supported?
Peter

You know what, never mind I should be able to answer this along the lines of
update

See PR

Was actually fixed by https://github.com/oseiskar/simdkalman/pull/18 (but forgot to tag this issue in the squash-merged commit)


Workaround for issue #2492 - disable ConvBinWinoRxS when granularity loss is huge

This is expected to resolve issue #2492, at least for some time (see https://github.com/ROCmSoftwarePlatform/MIOpen/issues/2492#issuecomment-1793570143, https://github.com/ROCmSoftwarePlatform/MIOpen/issues/2492#issuecomment-1793574432 for more info).

The W/A disables ConvBinWinoRxS when granularity loss is > 0.995 (performance drops 200 times)
The W/A can be switched OFF by setting MIOPEN_DEBUG_WORKAROUND_ISSUE_2493=0 in the env.

[Attribution] @junliume @JehandadKhan

https://github.com/ROCmSoftwarePlatform/MIOpen/labels/workaround
https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_high
https://github.com/ROCmSoftwarePlatform/MIOpen/labels/non-miopen-bug
Proposed reviewers:

@JehandadKhan
@Kirpich30000
@wenchenvincent
@CAHEK7

@atamazov  @Kirpich30000
I am worried about performance impact on this change:
 disable ConvBinWinoRxS when granularity loss is > 0.995 (performance drops 200 times)

especially if that could be the expected behavior of Winograd kernels in certain cases.

@junliume "200x performance drop" are cases when Winograd is unable to utilize GPU efficiently, and it's performance is expected to be so low that it makes no sense to use it.

@junliume @JehandadKhan Thanks but we were too fast ;) Please look at the 2nd part, PR #2510.


Proposing Magnus Kulke as maintainer for KBS

Magnus (@mkulke) is actively contributing to KBS both in terms of features and reviews.  I'm proposing to add Magnus as a maintainer for the KBS project.
I also created a related issue in guest-components as both goes together.. - https://github.com/confidential-containers/guest-components/issues/456
cc @fitzthum @Xynnn007

Great idea! I think @mkulke can really help the project

Totally agree. Welcome @mkulke (though we are old faces : P)

💯 From me. @mkulke is indeed an old timer already, but welcome anyways!

Added!


huge number of watch in zookeeper cause zookeeper full gc

I noticed there are about 100M watches in zookeeper in my product environment, and once I restart some of realtime tasks, zookeeper may full gc even it is configured to 32GB heap and druid is configured to use http server view.
After investigation, this issue is caused by the Announcer.java implementation.
The Announcer is trying best to avoid temporary disconnecting to zookeeper server and watch every child path under the specified base path, but for base path like /druid/prod/announcements and /druid/prod/listeners/lookups/__default/, there are plenty of hosts as child path under them.
If there are 10000 realtime tasks(not single realtime job, but like 50 jobs), then each task will create 2 * 10000 watches, finally we will get 200M watches!!
I'm not familiar with curator, can curator only watch a particular leaf path? Thus we can implement a simpler Announcer for these two pathes to reduce watch number in zookeeper to avoid zk OOM. @gianm

I'm not familiar with curator, can curator only watch a particular leaf path? Thus we can implement a simpler Announcer for these two paths to reduce watch number in zookeeper to avoid zk OOM.

It sounds possible, but I wonder what your solution is. Would you elaborate more details? What is the simpler implementation of Announcer you think?

My thought is that only watch the leaf path instead of watching all the child paths under the base path.
Rather than use childEvent, watch the path itself, I don't know whether it is possible, I'm not familiar with curator.

I also encountered this problem, how did you solve it?

What I want is to delete the directory under discovery and delete it after the task is finished.


[BUG]: Incorrect default actor initialization in BLOOMActor class of ChatGPT.

🐛 Describe the bug
Hello,
I wanted to report a bug with the current implementation of the inference.py.
Specifically, when using the bloom model, the actor is not being initialized correctly.
At the moment, the actor is being initialized using the following command:
python inference.py --pretrain <your actor model path> --model bloom

https://github.com/hpcaitech/ColossalAI/blob/82503a96f20c2e61016af78445f9d1697ac07dd5/applications/ChatGPT/examples/inference.py#L14
However, the correct way to initialize the actor when using bloom is to specify the corresponding tokenizer configuration, like this:
actor = BLOOMActor('bigscience/bloom-560m').to(torch.cuda.current_device())

https://github.com/hpcaitech/ColossalAI/blob/82503a96f20c2e61016af78445f9d1697ac07dd5/applications/ChatGPT/examples/inference.py#L29
This will load the specified model. I suggest updating/modifying the BLOOMActor class to initialize the actor with the correct default model.
Environment
current main branch

Hi @Fazziekey  and @ht-zhou  , can you help to answer this question?

Thank you for your feedback, this problem has been solved in #2988 .

I'm going to close this issue, and feel free to reopen this if you have any other questions.


How to setup remote docker hosts with a TLS certificate?

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
First of all, thank you very much for this beautiful peace of software. I'm using it since a couple of month now without any big issues.
I'm monitoring multiple remote machines which are running different docker containers. I'm able to access these containers via docker remote port 2375 successfully. But port 2375 is not protected by default, which is a security risk. Now I protected my docker sockets with a TLS certificate as decribed here.
In WhatUpDocker I can access the socket with a TLS client certifacte successfully with the follwing docker-compose settings:
version: '3'
services:
  whatsupdocker:
    image: fmartinou/whats-up-docker:latest
    container_name: whatsupdocker
    restart: always
    volumes:
      - /data/certificates/ca-public.pem:/tmp/ca-public.pem
      - /data/certificates/client-certificate.pem:/tmp/client-certificate.pem
      - /data/certificates/client-key.pem:/tmp/client-key.pem
    ports:
      - 3010:3000
    environment:
      - TZ=Europe/Berlin
      - WUD_WATCHER_PILIVE_CRON=4 4 * * *
      - WUD_WATCHER_PILIVE_HOST=<IP_ADDRESS>
      - WUD_WATCHER_PILIVE_PORT=2376
      - WUD_WATCHER_PILIVE_CAFILE=/tmp/ca-public.pem
      - WUD_WATCHER_PILIVE_CERTFILE=/tmp/client-certificate.pem
      - WUD_WATCHER_PILIVE_KEYFILE=/tmp/client-key.pem

But I can't figure out, how to use the same TLS client certificate files in Uptime Kuma. I tried the following docker-compose settings for Uptime-Kuma without success:
version: '3'
services:
  uptime-kuma:
    image: louislam/uptime-kuma
    container_name: uptime-kuma
    restart: always
    ports:
      - 3001:3001
    volumes:
      - /data/uptime-kuma:/app/data
      - /data/uptime-kuma/certs/ca-public.pem:/app/data/certs/ca-public.pem
      - /data/uptime-kuma/certs/client-certificate.pem:/app/data/certs/client-certificate.pem
      - /data/uptime-kuma/certs/client-key.pem:/app/data/certs/client-key.pem
    environment:
      - NODE_EXTRA_CA_CERTS=/app/data/certs/ca-public.pem
      - SSL_CERT=/app/data/certs/client-certificate.pem
      - SSL_KEY=/app/data/certs/client-key.pem

If I change the docker daemon setting in the docker host setup dialog from http://<IP_ADDRESS>:2375 to https://<IP_ADDRESS>:2376 I only get a "socket hang up" error messages. The WIKI page "How to Monitor Docker Containers" isn't explaining, how we can use Port 2376 with a TLS certificate.
It would be great, if we could have 3 more options to browse for the TLS files in the dialog, if I would select a "HTTPS" in the drop-down box. Or as an alternative to set these as an environment var.
How can I use my TLS client certificate? Any help is appreciated.
🐻 Uptime-Kuma Version
1.18.5
💻 Operating System and Arch
Ubuntu 22.04.1 LTS / Raspberry Pi 3b + Pi 4
🌐 Browser
Firefox 107
🐋 Docker Version
Docker 20.10.12
🟩 NodeJS Version
No response

I have the exact same issue.  I'd like to be able to somehow add client certs to the remote docker connection set up.   As it is, I can't access the remote docker server with http or https as I'm strictly using https for other apps that connect to a remote docker service on my local lan.

This isn't going to work currently as that would require using mutual TLS on the client side to connect to docker hosts. This also implies a new admin section where you can upload docker client certificates and since these certificates are per host, you'd need to be able to upload these for multiple hosts and then during a Docker Host Setup process in Kuma you would assign a client key to a host so in the future the selected client certificate would be used for the given docker host.
+1 for this feature request!

I'm not sure if the feature is missing or instructions are unclear, but I would like to know how to do this as well


Readme: Installation link broken on site

https://surferprotocol.org/desktop/installation. It just needs the docs subdomain https://docs.surferprotocol.org/desktop/installation

fixed thanks!


Styling doesnt work

Div is all miss aligned and style is messed up. Please help.

I have found the same issue. Any ideas how to fix it?

Yeah I tried all the tricks in issue #3 and nothing is working...

Got it. Changed my background color.


Thread destroyed while running

In my opinion, our problem situation is as follows:

When terminating the program, Bus instances are destroyed without stopping the threads.
When calling Swift.destroyBus(), since bus.stop() immediately returns and does not guarantee that the thread is stopped at all, the following bus.deleteLater() will be executed before the thread actually stops.

I cannot accept the proposed solution to add wait() as a slot of self._consumer.finished... I have no idea why it works.
The reason is that self._consumer.finished is a signal that I defined, and it will never be emitted unless the stop() is called so the while loop in run() finishes.
However, I've found a very magical phenomenon.
I tested as follows:

Define a new signal QueueConsumer.test().
Connect wait() as a slot to the test signal instead of finished signal.
It also solves the problem! Note that I only defined the signal and never used it, i.e., test signal is never emitted.

😄 I will study this further...
Originally posted by @kangz12345 in https://github.com/snu-quiqcl/swift/pull/96#issuecomment-1474717462

This is resolved (or has gone) by #112.