XML documentation of all public Nickel methods

At the same time, a PR doing this should enable a linting rule to warn about any missing documentation for public members.

Would it be possible to annotate the public members somehow (e.g. with a JetBrains.Annotations.PublicAPI attribute)? That would help with getting an overview of what needs to be documented.

It's essentially all types which are public, and all public members of said types.

At the same time, a PR doing this should enable a linting rule to warn about any missing documentation for public members.

Looking into this, it turns out MSBuild property GenerateDocumentationFile (which enables generating an .xml file with the documentation extracted) automatically enables the built-in warning for missing documentation on public types (CS1591).
(dotnet format does not display these, however. If we want a warning on PRs, that will require separate setup.)

Done in upcoming Nickel 1.0.0. The warning for missing docs is not yet setup.


Error installing netdata

The installer seems to successfully install netdata, but upon completion I'm unable to access it via the URL. It doesn't show up in running processes and I cannot find a launchable service for it. It did create a folder /root/netdata which seems to be the install path....

Thank you for the report! If netdata runs, it will be only in local. A reverse proxy, or maybe just modifying a configuration file is needed. I've also noticed some changes in netdata since this script was made, the installation may be not successful.

@alexborisov The netdata installation should be fixed now, with a nginx reverse proxy.

@j8r thanks for the update. I've just tried with the latest version, but i still cannot connect. Do I need to configure something? Regarding your comment about being local, do you mean i cannot access it via another computer on the network? My pi is headless. I'm trying on port 19999 as per the instructions, but I'm getting a refused to connect error. Dropping the port I get the default nginx landing page so thats working.

I ran sudo ~/DPlatform-ShellCore/netdata/netdata-installer.sh manually and now it works.

I've missed to add  cd to have the git repo cloned to /root and not in ~/DPlatform-ShellCore, and to have the followed command ~/netdata/netdata-installer.sh executed next.
Fixed now, thanks for your feedback!


fix wrong namespaceSelector in servicemonitor

Why is this pull request needed and what does it do?
when set prometheus.monitor.namespace to differ namespace, we should use namespaceSelector to specify service namespace
Which issues (if any) are related?
Checklist:

[x] I have bumped the chart version according to versioning.
[x] I have updated the chart changelog with all the changes that come with this pull request according to changelog.
[x] Any new values are backwards compatible and/or have sensible default.
[x] I have signed off all my commits as required by DCO.

Changes are automatically published when merged to main. They are not published on branches.

Note on DCO
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Not sure I understand the change, shouldn't the namespace selector always be the release namespace? In what cases should the service monitor be targeting a different namespace?

Because some prometheus is deployed with servicemonitor namespace to monitoring only (I don't think it is good, but it is historical)
I give some example
https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/templates/controller-servicemonitor.yaml (this is complex :)) )
https://github.com/bitnami/charts/blob/main/bitnami/redis/templates/servicemonitor.yaml
https://github.com/bitnami/charts/blob/main/bitnami/rabbitmq/templates/servicemonitor.yaml

Alright, sounds reasonable, please fill out all the items in the PR task list and we can get this rolling (e.g. DCO)

@tulequ the DCO check is failing, please resolve

Seems like the DCO check is still failing, please fix so we can merge this

please check again

Thanks!


Fix possible SQL Injection

May i ask why SQL Injection is a concern to you in this app when it is just a SQL client?

My SQL injection I was more thinking about a source of bugs, than a attack.
Maybe it's what you were asking for

I understand. I appreciate the feedback. For now, i'll merge this PR just to resolve the connection problem and open another PR addressing your feedback.
Thank you very much.
Originally posted by @jorgerojas26 in https://github.com/jorgerojas26/lazysql/pull/67#issuecomment-2220807680

Addressed in #73


Multichannel Analog USB Microphone

I followed CaydenPierce's four channel PDM usb microphone array format from: https://github.com/CaydenPierce/MSA to create a similar firmware that use Analog microphones instead of PDM microphones.
The board I was using is waveshare_rp2040_lcd_1.28.
I was able to get signals from the ADC pins and receive four channel audio data on my machine via USB.
However, I encountered some issues:

Received the same signal across different channels. [I expected it to show different signals from different channels because they are using different ADC pins]
Even if I did not initialize a ADC pin, for example, GPIO26 from rp2040, i could still get the signal from that pin regardless. And this also has the issue I described above issue 1. [I expected it to not be able to read from GPIO26 because I did not initialize that pin to read from]

Could anyone provide some feedback on this? It might due to my implementation is wrong but if someone can point me in the right direction, that would be very helpful.
Thanks in advance!

Hi @Sky-Unmodal,
I don't have any experience with this, I would suggest you follow up with CaydenPierce directly.


Update basenwbephyswriter.py

fix #304

Always appreciate help cleaning up CI warnings. Few dozen more to go, haha.


Communication: Reduce height of channel and chat item card

Checklist
General

[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
[x] I strictly followed the client coding and design guidelines.
[x] I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

The cards for the channels and chats had a lot of margin. As a result, only a few fit on one page, and there was a lot of scrolling. The height/padding has been reduced.
Description
The margin for the communication sidebar items has been reduced.
Steps for Testing

Prerequisites:

1 Student
1 Course with Communication enabled

Log in to Artemis
Navigate to Course Communication
See Sidebar with Channels / Chats
Verify that the Channel Chats are smaller
Navigate to Exercises / Lectures
Verify that everything looks like before

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

[ ] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test 1
[ ] Test 2

Performance Tests

[ ] Test 1
[ ] Test 2

Screenshots

Before:

After:

Summary by CodeRabbit

Style

Improved button alignment and spacing in the sidebar components for a more consistent user interface.
Adjusted rendering logic for sidebar items based on their type to enhance layout consistency.

New Features

Introduced conditional rendering for sidebar items, improving user interaction based on the sidebar type.

Tested on TS6 and TS2, card margins in the communication tab are smaller as described.


[4.1] %swift-target-frontend => %target-swift-frontend.

Looks like it was a typo.

@swift-ci test

@swift-ci test

@swift-ci test

Explanation: Fixes a typo in a test '%pattern' that is causing failures on 4.1. I didn't add this test, I just fixed it on master when I saw it, so I was asked to cherry-pick the change.
Scope: Fixes the build.
Radar/SR Issue: rdar://37472318
Testing: I ran the CI tests so we know that this test succeeds now.
Reviewer: @jckarter (Joe Groff)


Mixins

All current suggestions have been addressed, and no more have been posted in two days.

I haven't actually looked at the proposal, but please squash all history into a single commit.


UPDATE: Minor typo

I noticed the word "very" should be "vary" and "among" should be "by" on this page. See following instance:
Change from: Many governance details may very among region
Change to: Many governance details may vary by region

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d8ae2940-66f1-1603-8e54-7cfc22061a4b
Version Independent ID: 987deaf7-7081-5e54-2296-699cb7e1d4cc
Content: Information architecture models and examples - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/information-architecture-models-examples.md
Service: sharepoint-online
GitHub Login: @MattEEvans
Microsoft Alias: matteva

Thanks for your feedback!


weldr/api: indicate preloading progress in the log

With this you can see if the preloading is already finished or not

I'm not understanding what additional info this adds. It already prints when it is done, and when I'm looking at the logs I don't care how many there are, just whether or not the one I'm interested in has failed to load the metadata.

For the service to be up and running and responsive they should all be loaded, right?
The current logs didn't indicate if it's still busy preloading.
If this doesn't provide any value also for running the service to check if the startup is very slow or still not fully done, we can as well drop this

Hmm - it's used with the getting started "service" mode but you are right it's not aws 🤔


[DPG] The derived models with all required properties do not have proper internal constructor

For this typespec:
@discriminator("name")
@doc("Base model with discriminator property.")
model DeliveryRuleAction {
    foo?: string;
}

@doc("Deriver model with discriminator property.")
model DeliveryRuleCacheExpirationAction extends DeliveryRuleAction {
    name: "A";

  @doc("Required parameters.")
  parameters: CacheExpirationActionParameters;
}

model CacheExpirationActionParameters {
    foo: string;
    bar?: int32;
}

Now on the latest commit e07e879768792aea9b30c2a8b65abf8f3d596616 generates the code like this for class DeliveryRuleCacheExpirationAction:
    /// <summary> Deriver model with discriminator property. </summary>
    public partial class DeliveryRuleCacheExpirationAction : DeliveryRuleAction
    {
        /// <summary> Initializes a new instance of DeliveryRuleCacheExpirationAction. </summary>
        /// <param name="parameters"> Required parameters. </param>
        /// <exception cref="ArgumentNullException"> <paramref name="parameters"/> is null. </exception>
        public DeliveryRuleCacheExpirationAction(CacheExpirationActionParameters parameters) : base("A")
        {
            Argument.AssertNotNull(parameters, nameof(parameters));

            Parameters = parameters;
        }

        /// <summary> Required parameters. </summary>
        public CacheExpirationActionParameters Parameters { get; set; }
    }

and corresponding deserialization looks like this:
        internal static DeliveryRuleCacheExpirationAction DeserializeDeliveryRuleCacheExpirationAction(JsonElement element)
        {
            if (element.ValueKind == JsonValueKind.Null)
            {
                return null;
            }
            CacheExpirationActionParameters parameters = default;
            string name = default;
            Optional<string> foo = default;
            foreach (var property in element.EnumerateObject())
            {
                if (property.NameEquals("parameters"u8))
                {
                    parameters = CacheExpirationActionParameters.DeserializeCacheExpirationActionParameters(property.Value);
                    continue;
                }
                if (property.NameEquals("name"u8))
                {
                    name = property.Value.GetString();
                    continue;
                }
                if (property.NameEquals("foo"u8))
                {
                    foo = property.Value.GetString();
                    continue;
                }
            }
            return new DeliveryRuleCacheExpirationAction(parameters);
        }

The optional property on the base class foo just disappears during the deserialization and it is not correct.

Root cause is here: https://github.com/Azure/autorest.csharp/blob/e07e879768792aea9b30c2a8b65abf8f3d596616/src/AutoRest.CSharp/Common/Output/Models/Types/ModelTypeProvider.cs#L186
In the above case, publicParameters and serializationParameters happens to have the same content, therefore the serialization constructor has been skipped.
The public parameters and serialization parameters will always have the same content if all the properties on this model are required, but it breaks when it has a base class - properties can be optional on the base model therefore in this case we cannot skip the serialization constructor.

Root cause is here:
https://github.com/Azure/autorest.csharp/blob/e07e879768792aea9b30c2a8b65abf8f3d596616/src/AutoRest.CSharp/Common/Output/Models/Types/ModelTypeProvider.cs#L186
In the above case, publicParameters and serializationParameters happens to have the same content, therefore the serialization constructor has been skipped.
The public parameters and serialization parameters will always have the same content if all the properties on this model are required, but it breaks when it has a base class - properties can be optional on the base model therefore in this case we cannot skip the serialization constructor.

The publicParameters and serializationParameter should not the same in that case. Maybe that the serializationParameters is not correct.

Root cause is here:
https://github.com/Azure/autorest.csharp/blob/e07e879768792aea9b30c2a8b65abf8f3d596616/src/AutoRest.CSharp/Common/Output/Models/Types/ModelTypeProvider.cs#L186
In the above case, publicParameters and serializationParameters happens to have the same content, therefore the serialization constructor has been skipped.
The public parameters and serialization parameters will always have the same content if all the properties on this model are required, but it breaks when it has a base class - properties can be optional on the base model therefore in this case we cannot skip the serialization constructor.

The publicParameters and serializationParameter should not the same in that case. Maybe that the serializationParameters is not correct.

These two list of parameters stands for "the parameters coming from my own properties", therefore:
PublicParameters: parameters coming from the required properties of my own
SerializationParameters: parameters coming from all the properties of my own
Because this model only have required parameters, they are the same.
This part is correct. Issue is on "we should not skip the serialization constructor when these lists are the same" because they are not all the parameters.
Details please check my PR.


Add stack trace to .attrs warning

We should log the stack trace when warning about function keys in .attrs. Ref: https://spectrum.chat/styled-components/help/functions-as-object-form-attrs-error-but-not-in-source~390a2294-3b80-4527-a2ea-36556a540ed8

Just saw the thread on spectrum!
I believe I may be running into the same problem. Just wanted to post the following code snippet that's triggering the warning for me in case it's a false positive.
const tooltipFadeIn = keyframes`
    from {
        opacity: 0
    }
    to {
        opacity: 1;
    }
`;

const TooltipWrapper = styled.div.attrs<TooltipWrapperProps>({
  style: ({ xPosition, yPosition, opacity }: TooltipWrapperProps) => ({
    left: xPosition,
    top: yPosition,
    opacity,
  }),
})<TooltipWrapperProps>`
  position: absolute;
  pointer-events: none;
  animation: ${tooltipFadeIn} 80ms linear 1;
`;

Closed via #2486


Fix regression in domain to session type mapping

If no domain is passed, self->session->client_info->domain is an empty
string that is incorrectly treated as if the domain were passed by the
client.
The regression was introduced in fc753a95, when an incorrect check for
non-empty domain was added. That check was removed in 67119ecc based on
coverity report, leaving no trace of the original intention.
Check domain both for '_' and '\0' as the initial character. In either
case, select the first session type section in xrdp.ini.

Even though it is not a security fix, I consider it a 0.9.1 material. Firstly, it's a regression. The 0.6.x releases did not have that issue. Secondly, users switching from Xvnc to X11rdp or xorgxrdp backend would want to experiment with different backends, and the ability to have autologin with more than one backend would be very handy.

+1
בתאריך יום ו׳, 11 בנוב׳ 2016 ב-23:14 מאת Pavel Roskin <
<EMAIL_ADDRESS>
Even though it is not a security fix, I consider it a 0.9.1 material.
Firstly, it's a regression. The 0.6.x releases did not have that issue.
Secondly, users switching from Xvnc to X11rdp or xorgxrdp backend would
want to experiment with different backends, and the ability to have
autologin with more than one backend would be very handy.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/neutrinolabs/xrdp/pull/483#issuecomment-260057034,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADTH1KNwoInM_8siz-Fzyek2-UEwlgXaks5q9NqlgaJpZM4KwIpc
.

--
Idan Freiberg
PGP FP: 8108 7EC9 806E 4980 75F2  72B3 8AD3 2D04 337B 1F18

Let's include this to the next release.


Update the columns and the content of the columns so the render of the t...

...ables will be neater in the Ensembl mobile website

There seems to be code repetition for Alleles and Genotypes. Can this be split out as a subroutine? Also please avoid using inline styles. Add any styles to an appropriate .css file in htdocs/components.

What Harpreet said. There’s documentation on where to find the pertinent styles here:
https://www.ebi.ac.uk/seqdb/confluence/display/ENS/Ensembl+web+development https://www.ebi.ac.uk/seqdb/confluence/display/ENS/Ensembl+web+development
Cheers
Anne

On 30 Apr 2015, at 15:21, Harpreet Riat<EMAIL_ADDRESS>wrote:
There seems to be code repetition for Alleles and Genotypes. Can this be split out as a subroutine? Also please avoid using inline styles. Add any styles to an appropriate .css file in htdocs/components.
—
Reply to this email directly or view it on GitHub https://github.com/Ensembl/ensembl-webcode/pull/223#issuecomment-97815423.

I moved the inline styles into the htdocs/components/85_spreadsheet_table.css file.


License page empty on launch

Hi,
Not sure if this is a foundry issue or a docker image issue, so I figured I'd ask.
I've configured the image on my remote server as well as nginx, and when I connect I get redirected to the license page as expected. But there's no text on the page, and so no way to proceed. Did I do something wrong in the setup?

Welp, turns out I just didn't set up the proxy properly. I used your version of the proxy instead of the one I use for my own website and it worked xD

This is my favorite kind of issue!  (The ones that close themselves!)
It sounds like it was a websocket proxy issue.  I'm glad you got it working. 🎉
Happy Gaming!

Yup, exactly. My regular nginx proxy is intended for static pages, so it didn't have anything for sockets ^^;


request: caption in markdown format

I'm a very happy user of this plugin!
Would it also be possible to use markdown format in the caption?
Now when I try:
Figure: Test **bold** text

![](image.png)

It will show the image with this caption below it: "Figure 1: Test" and nothing more. Where I was hoping to see: "Figure 1: Test bold text"

that is a cool idea... Need to see how It can be done within the mkdocs processor.
in the meantime I guess you can just use HTML syntax in the caption

😇 I tried a bit around and came up with the proposal in #16 . Would you mind trying it out before I merge it? Maybe you can give me some feedback if the change works as you had in mind.

That's fantastic news! I would love to try out this new version. How can I do that?

no need to manually clone, you can simply use pip to install the package directly form a branch.
pip install git+https://github.com/tobiasah/mkdocs-caption.git@markdown_syntax_in_caption


Replace t.WarnF with t.Error

I replaced t.WarnF with t.Error because testing package doesn't have WarnF().

The testing is actually not use at all


Implemented Tuxedo pipeline

Transcript-level expression analysis of RNA-seq experiments with HISAT, StringTie and Ballgown:
http://www.nature.com/nprot/journal/v11/n9/full/nprot.2016.095.html

Only once we have user requests


Fix substitution for anonymous class

The logic in Substitutions#substitute() fails for J.NewClass instantiating new anonymous classes because an anonymous class like A$1 is replaced with A.1 which isn't a legal class name.

@kunli2 I think this should fix the problem you were seeing. I didn't add any test, because I would like you to first verify this for yourself and decide if this is how you want to fix the issue. Let me know if I can help with tests or anything else.


TokenCredentials causes a ServiceRequestException

When using TokenCredentials, I get the following error:
microsoft.exchange.webservices.data.ServiceRequestException: The request failed. NamespaceURI cannot be null
    at microsoft.exchange.webservices.data.SimpleServiceRequestBase.internalExecute(SimpleServiceRequestBase.java:70) ~[ews-java-api-2.0-SNAPSHOT.jar:na]
    at microsoft.exchange.webservices.data.MultiResponseServiceRequest.execute(MultiResponseServiceRequest.java:145) ~[ews-java-api-2.0-SNAPSHOT.jar:na]
    at microsoft.exchange.webservices.data.ExchangeService.internalBindToItems(ExchangeService.java:1187) ~[ews-java-api-2.0-SNAPSHOT.jar:na]
    at microsoft.exchange.webservices.data.ExchangeService.bindToItem(ExchangeService.java:1223) ~[ews-java-api-2.0-SNAPSHOT.jar:na]
    at microsoft.exchange.webservices.data.ExchangeService.bindToItem(ExchangeService.java:1242) ~[ews-java-api-2.0-SNAPSHOT.jar:na]
    at microsoft.exchange.webservices.data.EmailMessage.bind(EmailMessage.java:71) ~[ews-java-api-2.0-SNAPSHOT.jar:na]
Caused by: javax.xml.stream.XMLStreamException: NamespaceURI cannot be null
    at com.sun.xml.internal.stream.writers.XMLStreamWriterImpl.writeAttribute(Unknown Source) ~[na:1.7.0_67]
    at microsoft.exchange.webservices.data.WSSecurityBasedCredentials.emitExtraSoapHeaderNamespaceAliases(WSSecurityBasedCredentials.java:153) ~[ews-java-api-2.0-SNAPSHOT.jar:na]
    at microsoft.exchange.webservices.data.ServiceRequestBase.writeToXml(ServiceRequestBase.java:206) ~[ews-java-api-2.0-SNAPSHOT.jar:na]
    at microsoft.exchange.webservices.data.ServiceRequestBase.buildEwsHttpWebRequest(ServiceRequestBase.java:731) ~[ews-java-api-2.0-SNAPSHOT.jar:na]
    at microsoft.exchange.webservices.data.ServiceRequestBase.validateAndEmitRequest(ServiceRequestBase.java:690) ~[ews-java-api-2.0-SNAPSHOT.jar:na]
    at microsoft.exchange.webservices.data.SimpleServiceRequestBase.internalExecute(SimpleServiceRequestBase.java:58) ~[ews-java-api-2.0-SNAPSHOT.jar:na]

My code looks like the following:
ExchangeService exService = new ExchangeService(ExchangeVersion.Exchange2010_SP2);
ExchangeCredentials credentials = new TokenCredentials("TOKEN_VALUE");
exService.setCredentials(credentials);
exService.setUrl("EWS_SERVER_URL");
EmailMessage serverMessage = EmailMessage.bind(exService, new ItemId("ITEM_ID");

I tinkered with the offending class, WSSecurityBasedCredentials, and was able to get past this error, but the XML output ended up being garbled, with the header missing some tag names, as well as some escaped tags with < and > instead of < and > . .
In addtion, the word "null" gets prepended to the token when written to xml due to the concatenation of a null "timestamp" (see WSSecurityBasedCredentials line ~225. Initializing it to an empty string would fix this.

duplicates #265


BUG always make copy of external data

closes #409
Always make a copy instead of trying to symlink. We should go from the principle that the data are always quite small.

ping @agramfort @rth

This PR needs to be back ported in 0.4.X for a bug fix release

Looks good. Can we still put this code on server as soon as the FAN challenge is closed?

Looks good. Can we still put this code on server as soon as the FAN challenge is closed?

Can I close FAN now?

or do you still have some activities happening there?


#48910:Fixed position of flash message

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #48910

You have opened two PRs with the same change, if the change is needed, I would have asked you to edit the PR, and I wouldn't have closed it.

We don't want to change the bootstrap classes file, because it's reach is wide and it affects every thing.
Adding flex and align-items with center value. Doesn't change anything because the elements are already centered with the old school float way, and doesn't provide RTL support, because the component do have RTL support baked into it.


Follow symlinks for TLS certificate

It is sometimes convenient to simply provide a symlink that points at the actual TLS certificate. Up to ZNC 1.7.x-git-701-15ae561, it looks like it stats the file, then errors out with
Binding to port [+1234] using ipv4... [ Unable to locate pem file: [/path/to/znc.pem] ]
Unrecoverable config error.

Instead, znc should follow such symlinks.

Are you really, really sure that you got the path to the symlink and the symlink correct?
Looking at the code, it just checks if the file exists [1] and the method that it uses for this just stat()s the file. So symlinks should just work.
[1] https://github.com/znc/znc/blob/b45617cb59ee1729d6288c1242a22cae785c5e4b/src/znc.cpp#L1724-L1726
[2] https://github.com/znc/znc/blob/b45617cb59ee1729d6288c1242a22cae785c5e4b/src/FileUtils.cpp#L159-L162

Wow, made a bunch of mistakes here.
I also had two versions of znc on the system, so which one was executed depended on how I executed it (ie relying on $PATH vs init script vs executing the binary directly) and I never noticed.
I also misunderstood what strace was telling me. In particular, I thought znc was asking stat if the file was a regular file, and seeing that it wasn't. In reality, S_IFREG indicates that stat is saying that the file is a regular file. (which is still weird, because I'd expect to see S_IFLINK)
And, you're right: this works just fine. Because I wasn't looking at the logs corresponding to what I was actually running, I didn't see the real and unrelated failure.

which is still weird, because I'd expect to see S_IFLINK

This is the difference between stat() and lstat(). One follows symlinks, another looks at symlink itself.


 It looks like we'd need to have code that uses buildAnnotatedString with index positions to identify the hyperlink and then call openURI, which would make sense as a re-usable component.
Could you take a look at this one? I suspect it will be quick for you.

It's hard to make part of flowing text clickable while respecting the minimum size recommended to make it easy to tap using a finger. Presumably that's why there's no built-in support for that.
I'd recommend making the whole text clickable.

Default
Finger down

Would that work? I could update the PR accordingly.

Yes I was thinking the same, making the whole text clickable but underlining and making the learn more text look like a hyperlink would be great.
Appreciate you taking over the pull request.

@kewisch: What's the URL for the link?


The Transform-Policy.ps1 script provided does not include private IP ranges, this will cause customer production down after running this script.

[Enter feedback here]
We need to add this line into this script:
$NewPolicyParameters = @{
Name = (GetPolicyNewName -Policy $Policy)
ResourceGroupName = $Policy.ResourceGroupName
Location = $Policy.Location
ThreatIntelMode = $Policy.ThreatIntelMode
BasePolicy = $Policy.BasePolicy.Id
DnsSetting = $Policy.DnsSettings
Tag = $Policy.Tag
SkuTier = "Premium"
PrivateRange = $Policy.PrivateRange

which will include the no snat private IP ranges for the customer's exisiting standard policy, currently this line is not included.
and the new created premium policy will be created as always SNAT, this essentially break all the custmer's internal flow!!
This is critical, please kindly update the powershell script.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 326302f4-752f-4e20-cdf6-39a249548ae4
Version Independent ID: 576f83ed-4053-40bd-f7c0-9a8f9dc3f5ae
Content: Migrate to Azure Firewall Premium
Content Source: articles/firewall/premium-migrate.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@cecilyanyy, Thanks for reaching out. We will investigate and update this thread.

@Cecilyanyy, Appreciate your feedback. We have assigned this issue to the respective content owner to update the document accordingly.

Thank you for your dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


Some pystats results are nonsensical

Some of the pystats results for the Optimizer stats don't make sense -- they show more successful traces than trace attempts.  For example, the hexiom ones:

Count
Ratio

Optimization attemptsⓘ
1,540

Traces createdⓘ
52,900

Trace stack overflowⓘ
0

Trace stack underflowⓘ
16,060

Trace too longⓘ
0

Trace too shortⓘ
1,197,960

Inner loop foundⓘ
500

Recursive callⓘ
0

Low confidenceⓘ
100

Executors invalidatedⓘ
0

Traces executedⓘ
109,768,500

Uops executedⓘ
2,948,922,980

I can't reproduce this locally, so there must be something else going on.

Moved to CPython: https://github.com/python/cpython/issues/116760


How to parse SystemSignalLongSymbol

could you please elaborate? what is the issue? can you provide a complete file?

hi ,
I also want to extract "SystemSignalLongSymbol",
Example:
Consider ->  SG_ signalname_0000 : 395|8@0+ (1,0) [0|255] ""  ABCD
SystemSignalLongSymbol" property is set  for  signalname_0000
BA_ "SystemSignalLongSymbol" SG_ xxxxx signalname_0000 "signalname_150000000000";
For a particular signal in dbc , if "SystemSignalLongSymbol" property is set
-> then Cantools is taking Signal Name as ""signalname_150000000000"" instead of  "signalname_0000"
-> Cantools not storing "signalname_0000" this any where, when  "SystemSignalLongSymbol" property is set
For a particular signal in dbc , if "SystemSignalLongSymbol" property is NOT set
-> then Cantools is taking Signal Name as ""signalname_0000""

Hi, the special attributes for long names are applied automatically. There might be some old tools that only support the short name (up to 32 chars). So there should be no need to separately "ask" for the long name. If you still want to do so for any reason, try to access the attribute "SystemSignalLongSymbol" as you would do for other dbc properties. As far as I remember, these special attributes are kept in the data structure, but for convenience the standard attributes for retrieving the name automatically reflect them, too.

hi ,
Can you help me to understand, why Can tools reading Signal name as value of SystemSignalLongSymbol" property .
if this is property is SET for that signal

Hi,
this is due to the specification of the dbc file format. So cantools behaves like other common tools regarding that feature.
I guess that the very first versions of dbc file supported symbol names up to 32 chars only, and for compatibility reason this limitation has been kept, and the "workaround" with the special attributes has been introduced. All common tools (especially those from Vector) support long names of course, and the normal user does not need to care about that. I guess he won't even be aware of that concept (except he browses through the settings via CANdb++ and the integrated online help).


Calibre tutorial certbot might not work

I had everything set up as the basic tutorial said. I tried to create calibre-server but the certification didn'ŧ work. When I ran
certbot --nginx  I didn'ŧ get the option to add calibre.myserver.xxx. User might be tempted to add it manually with certbot --nginx -d calibre.myserver.xxx but this adds the certification to /sites-available/default file instead of /sites-available/calibre and the certification won't work for some reason. The solution is to get rid of all certbot certificates and then run certbot --nginx now it works normally for some reason. There is one more thing missing and that is that you should link the calibre file to /sites-enabled/ with ln -s /etc/nginx/sites-available/calibre /etc/nginx/sites-enabled.

Could you not just type certbot and choose the calibre domain you want to renew by number ?

No. I dunno why, it might have been some problem on my part though as I said I have done the guide step by step. Anyway I think it would be just fine adding this info as a footnote and mentioning the part about having to link the sites-available and sites-enabled, also as a footnote I guess.


Interactive feature scatter

Reopened previous PR with updated master commit history

All seems to be in order. I guess the only other future feature that would be nice in the CPV graph is click events, to show more expression information of selected gene or link to eupathdb (etc). E.g. https://plotly.com/python/click-events/


Unit Testing

We should set up basic unit tests and iterate towards more sophisticated ones.

Setup jest for the project
Add basic tests for the commands listed on the help menu.
Add a new script to the package.json that runs unit tests
Add unit tests execution to a CI workflow (perhaps to the "Build" workflow)

/assign

Good luck @sweetapplepumpkinpie I have a feeling that this one might be quite complicated.

Thanks @pavlovcik. will complete this asap

Sorry for the late start. I just thought that I would continue after the last issue is merged.
So the basic unit tests should cover all of the project?

The purpose of this bounty is more to set up a foundation so they can be just a few simple ones.

/assign

let's work on it!! great @pavlovcik any particular reason why we want a meta dockerized unit testing? (just for the thoughts here, i will handle it anyway)

It's a best guess on how to closely match the GitHub actions runner environment. I did a small bit of research before and found that there are docker containers specifically to act like a GitHub Action runner.
Do you have any other suggestions?
Maybe @rndquu might have some ideas.

Let's clear the terminology:

Unit tests: fast and small tests which mock most of the external dependencies
Integration tests: tests running in a simulated environment without mocking external dependencies

This issue implies setting up a foundation for unit testing, i.e.:

Setup jest for the project
Add basic tests for the following commands:

/assign
/unassign
/wallet
/payout
/multiplier

Add a new script to the package.json that runs unit tests
Add unit tests execution to a CI workflow (perhaps to the "Build"  workflow)

At later steps, when we are about to implement integration tests, we could consider using docker for simulating github environment. Perhaps there are better ways for implementing integration tests.

Okay so let's remove Docker from the spec and just run jest in the CI.

Closing this one because:

jest (along with jest CI) will be setup here
unit (functional) tests for basic commands will be implemented here


Unreachable code in circular reference check?

When I was doing #12 I started looking at deduplicating the circular reference checks but got bogged down with code style issues. Then I wondered if all of that code is actually reachable. I tried to run the coverage report but it errored out for me. But as demonstrated by this PR, the chunk I'm referring to is not covered; with this change existing tests (and those I add in #12) pass. Is there a situation I haven't thought of where this would be reachable?

ok, so - I added it initially because I was being careful that both iteration of "value" and "other" had the same checks.
However, I think I see why this change works - because the only reason to have the second iteration in the first place is to ensure that there are no keys in "other" that are missing from "value".
Since all the tests pass, I think this is OK - can you rebase this on the latest master, and I'll bring it in? (bonus points if you can prefix the commit message with "[Refactor] ")

However, I think I see why this change works - because the only reason to have the second iteration in the first place is to ensure that there are no keys in "other" that are missing from "value".

Yeah, I can't see a way for the iteration of other to get past that check.

Since all the tests pass, I think this is OK - can you rebase this on the latest master, and I'll bring it in?

Sure, done :sparkles:

Thanks!

Thanks!


Enable more unit tests for ACM

Some unit tests for ACM implementation were commented out due to a then pending PR on freezegun
Enabling those tests with minor changes.

Coverage decreased (-0.3%) to 94.137% when pulling 906a92cb4d9d5a43228eebcbebe72058910bcdad on nom3ad:noma3d-acm-more-unit-tests into db7842653fbc30735e84037a768748c01b203023 on spulec:master.


Terragrunt doesn't recognize providers versioning?

My terragrunt.tfvars file specifies my provider as follows:
terragrunt {
  terraform {
    source =<EMAIL_ADDRESS>
    # define region for aws
    # security connection will be pulled from credentials file
    provider "aws" {
      version = "~> 1.54"
      region  = "us-west-2"
    }

    # for data_file resource
    provider "template" {
      version = "~> 1.0"
    }
  }

  include {
    path = "${find_in_parent_folders()}"
  }
}

However, when I run terragrunt plan I see this:
Initializing the backend...

Successfully configured the backend "s3"! Terraform will automatically
use this backend unless the backend configuration changes.

Initializing provider plugins...
- Checking for available provider plugins on https://releases.hashicorp.com...
- Downloading plugin for provider "template" (1.0.0)...
- Downloading plugin for provider "aws" (1.54.0)...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.aws: version = "~> 1.54"
* provider.template: version = "~> 1.0"

Terraform has been successfully initialized!

Furthermore, despite my specifying the region in the awsprovider, it still prompts me for a value:
[terragrunt] 2019/01/05 01:20:46 Running command: terraform plan
provider.aws.region
  The region where AWS operations will take place. Examples
  are us-east-1, us-west-2, etc.

  Default: us-east-1
  Enter a value: us-west-2

Refreshing Terraform state in-memory prior to plan...
The refreshed state will be used to calculate this plan, but will not be
persisted to local or remote state storage.

I can overwrite it with an environment variable, however this shouldn't happen. I'm trying to keep things DRY and not put the provider info inside the source module, but is that really not possible?

if anyone else stumbled on this issue, this community post has the full answer you are looking for.

I'm having a separate but related issue.
When using Terraform to include a Terraform module you can pass or override providers of the modules.
https://www.terraform.io/docs/configuration/modules.html#passing-providers-explicitly
This seems impossible with Terragrunt?

I came across a use case that is a great fit for the feature @ericfrederich cited above.
To give you guys a better grasp of it, we got more than one provider on our provider.tf, which is propagated to child folders via generators.
We could use the ability of referencing one or another provider via explicit passing:
module "a_module" {
  source = ...

  providers = {
    aws = aws.account_a
  }
}

Or even more than one provider at once:
module "complex_module" {
  source = ...

  providers = {
    aws.primary = aws.region_a
    aws.secondary = aws.region_b
  }
}

Lemme know if you guys need some extra details on it.

Unfortunately, there isn't a way to support this in terragrunt because there is no way to do this through CLI args or environment variables at the current moment.
You will have to figure out a way to do this through conditional generators (e.g., update the contents of the provider.tf file generated by generate blocks to be dynamically determined in terragrunt), or variables that configure the provider in the module.

Closing this as won't fix.
The recommended approach to handle this is to create a wrapper terraform module that configures the providers and explicitly forwards them to the module using terraform constructs, and then have terragrunt call that wrapper module instead of going to the underlying module directly.


Add CI pipeline

Description
Added a Jenkins CI pipeline for automatic testing.

Can one of the admins verify this patch?


Can't install: Calibre

calibre can't be installed

calibre-normal works as expected

https://github.com/lukesampson/scoop-extras/issues?q=is%3Aissue+sort%3Aupdated-desc+calibre+too+long+is%3Aclosed


ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(conv_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(gemm_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(pool_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(shape_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(slice_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(split_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(unary_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(argmax_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(binary_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(concat_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(gather_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(resize_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(flatten_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(reshape_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(softmax_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(squeeze_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(reduction_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(transpose_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(activation_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(depthtospace_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(batch_norm_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(DataStructures.pb.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(Parameters.pb.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(utils.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
ld: warning: object file (../../_deps/onnxruntime-src/lib/libonnxruntime.a(base_op_builder.cc.o)) was built for newer macOS version (12.7) than being linked (11.0)
Undefined symbols for architecture arm64:
"_objc_msgSend$URLByAppendingPathComponent:", referenced from:
onnxruntime::coreml::util::GetTemporaryFilePath() in libonnxruntime.a(host_utils.mm.o)
"_objc_msgSend$URLWithString:", referenced from:
-[CoreMLExecution loadModel] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$UTF8String", referenced from:
onnxruntime::coreml::util::GetTemporaryFilePath() in libonnxruntime.a(host_utils.mm.o)
-[CoreMLExecution cleanup] in libonnxruntime.a(model.mm.o)
-[CoreMLExecution loadModel] in libonnxruntime.a(model.mm.o)
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$addObject:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$arrayWithCapacity:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$cleanup", referenced from:
-[CoreMLExecution dealloc] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$compileModelAtURL:error:", referenced from:
-[CoreMLExecution loadModel] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$count", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
___57-[CoreMLExecution predict:outputs:getOutputTensorDataFn:]_block_invoke in libonnxruntime.a(model.mm.o)
"_objc_msgSend$countByEnumeratingWithState:objects:count:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$dataType", referenced from:
___57-[CoreMLExecution predict:outputs:getOutputTensorDataFn:]_block_invoke in libonnxruntime.a(model.mm.o)
"_objc_msgSend$defaultManager", referenced from:
-[CoreMLExecution cleanup] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$dictionaryWithCapacity:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$featureValueForName:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$featureValueWithMultiArray:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$fileURLWithPath:isDirectory:", referenced from:
onnxruntime::coreml::util::GetTemporaryFilePath() in libonnxruntime.a(host_utils.mm.o)
"_objc_msgSend$getBytesWithHandler:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$globallyUniqueString", referenced from:
onnxruntime::coreml::util::GetTemporaryFilePath() in libonnxruntime.a(host_utils.mm.o)
"_objc_msgSend$initWithDataPointer:shape:dataType:strides:deallocator:error:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$initWithDictionary:error:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$initWithPath:logger:coreml_flags:", referenced from:
onnxruntime::coreml::Execution::Execution(std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator> const&, onnxruntime::logging::Logger const&, unsigned int) in libonnxruntime.a(model.mm.o)
onnxruntime::coreml::Execution::Execution(std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator> const&, onnxruntime::logging::Logger const&, unsigned int) in libonnxruntime.a(model.mm.o)
onnxruntime::coreml::Model::Model(std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator> const&, onnxruntime::logging::Logger const&, unsigned int) in libonnxruntime.a(model.mm.o)
"_objc_msgSend$insertObject:atIndex:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$loadModel", referenced from:
onnxruntime::coreml::Execution::LoadModel() in libonnxruntime.a(model.mm.o)
onnxruntime::coreml::Model::LoadModel() in libonnxruntime.a(model.mm.o)
"_objc_msgSend$localizedDescription", referenced from:
-[CoreMLExecution cleanup] in libonnxruntime.a(model.mm.o)
-[CoreMLExecution loadModel] in libonnxruntime.a(model.mm.o)
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$longLongValue", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$modelWithContentsOfURL:configuration:error:", referenced from:
-[CoreMLExecution loadModel] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$multiArrayValue", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$numberWithLongLong:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$objectAtIndexedSubscript:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$path", referenced from:
onnxruntime::coreml::util::GetTemporaryFilePath() in libonnxruntime.a(host_utils.mm.o)
-[CoreMLExecution loadModel] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$predict:outputs:getOutputTensorDataFn:", referenced from:
onnxruntime::coreml::Execution::Predict(std::__1::unordered_map<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator>, onnxruntime::coreml::OnnxTensorData, std::__1::hash<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator>>, std::__1::equal_to<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator>>, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator> const, onnxruntime::coreml::OnnxTensorData>>> const&, std::__1::unordered_map<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator>, onnxruntime::coreml::OnnxTensorInfo, std::__1::hash<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator>>, std::__1::equal_to<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator>>, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator> const, onnxruntime::coreml::OnnxTensorInfo>>> const&, std::__1::function<void* (std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator> const&, int, gsl::span<long long const,<PHONE_NUMBER>3709551615ul>)> const&) in libonnxruntime.a(model.mm.o)
"_objc_msgSend$predictionFromFeatures:options:error:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$processInfo", referenced from:
onnxruntime::coreml::util::GetTemporaryFilePath() in libonnxruntime.a(host_utils.mm.o)
"_objc_msgSend$removeItemAtPath:error:", referenced from:
-[CoreMLExecution cleanup] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$setComputeUnits:", referenced from:
-[CoreMLExecution loadModel] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$setObject:forKeyedSubscript:", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$shape", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$strides", referenced from:
-[CoreMLExecution predict:outputs:getOutputTensorDataFn:] in libonnxruntime.a(model.mm.o)
"_objc_msgSend$stringWithUTF8String:", referenced from:
-[CoreMLExecution initWithPath:logger:coreml_flags:] in libonnxruntime.a(model.mm.o)
(anonymous namespace)::Utf8StringToNSString(char const*) in libonnxruntime.a(model.mm.o)
ld: symbol(s) not found for architecture arm64
clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [sherpa-onnx/csrc/CMakeFiles/sherpa-onnx.dir/build.make:108: bin/sherpa-onnx] Error 1
make[2]: Leaving directory '/Users/nirmitdalal/Documents/playgrounds/rust/sherpa-rs/sys/sherpa-onnx/build-static'
make[1]: *** [CMakeFiles/Makefile2:2203: sherpa-onnx/csrc/CMakeFiles/sherpa-onnx.dir/all] Error 2
make[1]: Leaving directory '/Users/nirmitdalal/Documents/playgrounds/rust/sherpa-rs/sys/sherpa-onnx/build-static'
make: *** [Makefile:156: all] Error 2

Relevant environment variables in the shell
MACOSX_DEPLOYMENT_TARGET=11.0
DEPLOYMENT_TARGET=11.0
CC=clang
CXX=clang++
CXX_FOR_TARGET=clang++

xcodebuild --version
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

Could you have a look at
https://github.com/nodejs/node-gyp/issues/569
or search with google with your log about xcode?
There must be something wrong with your installation of xcode.

Got that fixed -
xcodebuild -version
Xcode 15.4
Build version 15F31d

It still fails: https://gist.github.com/nirmitleo/b84b949a5516632045cce8244613187b

Could you delete your build directory and retry after you fix your xcode installation?
Please post the log of make VERBOSE=1 -j1 when you retry.

https://gist.github.com/nirmitleo/6203aabe29e94238ab9f709f24c78bec
Exact steps -
rm -rf build-static
mkdir -p build-static
cd build-static
cmake \
  -DSHERPA_ONNX_ENABLE_C_API=ON \
  -DCMAKE_BUILD_TYPE=Release \
  -DBUILD_SHARED_LIBS=OFF \
  -DCMAKE_INSTALL_PREFIX=/tmp/sherpa-onnx/static \
  ..

Could you share the log of
make VERBOSE=1 -j1

You are using -j6 which invokes multiple jobs and the log is not easy to parse.

So sorry missed that one.
https://gist.github.com/nirmitleo/fd3e007332bd5ef151ebc1eb8d0e2178

The quickest fix should be using
-DBUILD_SHARED_LIBS=ON

Since you are already using xcode 15 which is newer than xcode 14, I've no idea why you still have such issues.


[To Improve] Conditional return Type datas

We have a special case, for a ReservationType, we want to return the data only if it belongs to this person, so we have to add conditions on every "fields" today, as below. We would like to declare one condition for all or only certain "fields" without repeating functions in AbstractReservationType.
/**
     * @Field()
     * @param Reservation $reservation
     * @return Bill|null
     */
    public function getBill(Reservation $reservation): ?Bill
    {
        if ((($reservation->getClient() !== null) && ($this->userService->getUserId() === $reservation->getClient()->getId())) || $this->rightsService->isAllowed('IS_ADMIN')) {
            return $reservation->getBill();
        }
        return null;
    }

    /**
     * @Field()
     * @param Reservation $reservation
     * @return Client|null
     */
    public function getClient(Reservation $reservation): ?Client
    {
        if ((($reservation->getClient() !== null) && ($this->userService->getUserId() === $reservation->getClient()->getId())) || $this->rightsService->isAllowed('IS_ADMIN')) {
            return $reservation->getClient();
        }
        return null;
    }

Hey @charles4201 ,
This is something I'll be looking at in the next release (3.1), as this is quite a common need.
I'm not sure how we can solve it, but my guess is that we should probably work on custom annotations that can register a kind of middleware that applies on the Field.
Something like:
    /**
     * @Field()
     * @MyCustomRight
     */
    public function getClient(Reservation $reservation): ?Client

and
class MyCustomRightService implements GraphQLMiddleware
{
    public function __construct(RightService $rightService) { /*....*/ }

    public function process(object $obj, HandlerInterface $handler) : ?object
    {
        if ($obj instanceof Reservation) {
            if (!(($reservation->getClient() === null) || ($this->userService->getUserId() === $reservation->getClient()->getId())) && $this->rightsService->isAllowed('IS_ADMIN')) {
                return null;
            }
        }
        return $handler->handle($obj);
    }
}

This is actually now solved by the brand new @Security annotation #132
See documentation: https://graphqlite.thecodingmachine.io/docs/next/fine-grained-security


Update membership.md

Grammar
Signed-off-by:  mkell85<EMAIL_ADDRESS>

Thanks for the contribution! However, this is a read-only mirror. please read the contribution guide. Also, feel free to join us on chat!


How to catch an events that was emitted from an item component?

There the way exists for pass params TO items components via "source" item prop, or pass additional params to items components: via extra-props.
But how to get BACK a data from an item components?

How to catch an events that was emitted from an item component?
How to get item component instance with an index or data-key specified? Or, for example, to detect is the item in the visible scroll area (get the items bound rect within the browser window)

你可以使用一个中间组件，不需要把需要渲染的组件传递给他

你可以使用一个中间组件，不需要把需要渲染的组件传递给他
I don't understand Сhinese, sorry. I tried to translate your answer, but it does not explain the attached pictures.
I think, if you want, that most of people clear understand you, try write in English (it's not my native language too, but I do so).

If I clear uderstand your code on screens, you suggest to use a Vuex global store.
This approach is not a good one, as I think. It breaks modularity and increases the connectivity of components.
Vue recommends to use "props - emit" scheme to comunicate parent component with its children components. And I don't see how to use this scheme with this realization of Virtual Scroller.

你可以使用一个中间组件，不需要把需要渲染的组件传递给他
I don't understand Сhinese, sorry. I tried to translate your answer, but it does not explain the attached pictures.
I think, if you want, that most of people clear understand you, try write in English (it's not my native language too, but I do so).

If I clear uderstand your code on screens, you suggest to use a Vuex global store. This approach is not a good one, as I think. It breaks modularity and increases the connectivity of components. Vue recommends to use "props - emit" scheme to comunicate parent component with its children components. And I don't see how to use this scheme with this realization of Virtual Scroller.

Hi @vvy6791 ,
find solution here:
https://github.com/tangbc/vue-virtual-scroll-list/issues/237#issuecomment-641935872


Migrate Web Agent Sample to NestJs

As discussed previously in one of our community calls, I propose to migrate the current source code structure to NestJs based code organization structure in order to have a convention based approach to the architecture. Also it will help new contributors to follow well-defined coding patterns.

That's a good idea. We need to be aware that Nest.js is primarily a server-side, backend oriented framework, but it could be nice to have Nest.js DI container for example. I did a demonstration of minimal setup using DI container in nest-di project (see  main.ts file).

Yes, we can separate out the library oriented modules and server hosted modules so that we can achieve re-usability of library modules across the target platforms such as React-Native, Node, etc.
I am working out a project structure and will share it soon with you guys once ready.

I'm closing this. We can create a new issue once we decide to implement dependency injection / have a concrete plan


tests missing from pypi tarball

Hi! I'm packaging python-click-help-colors for Arch Linux.
We're usually using the sdist tarballs from pypi.org, as they ensure uniqueness. However, in this case, the sdist release is missing the tests. As the sdist is supposed to contain the sources from which users can build the package, it should also contain the tests, so that they can validate, that click-help-colors integrates with their system python.
The directory can be added to MANIFEST.in and will then be available in the sdist tarball upon next release.

On 2nd look, I realize, that a python setup.py sdist should currently already do the right thing.
How was the version 0.7 sdist tarball created for pypi.org?

fixed in 0.8


Fix compilation error in all crates by updating image

Version 0.12.4 of image produces compilation errors, while 0.13.0 does not. This commit updates image in all sub-projects. No other changes seem to be needed in any project. All tests work on my machine.

This patch failed to build on 0.15.1. Maybe an issue with error-chain? Not sure what's up with that, but I thought you'd like to know.
Maybe I just need to update my error chain dependency to make this work again, which would be fine.

Any reason you’re specifically testing for 1.15.1? It did work with previous version and it works with newer versions.

Well,  let's see if I can explain what I was thinking. :-) 1.15.1 is the first version of Rust with stable macros, and various Linux distributions are beginning to lock down various versions as their "system Rust", and so I don't want to always require the latest stable.
We can bump it to 1.16.0 if we really must, but I really do want to have an "earliest supported Rust version" that doesn't change every 6 weeks.

I updated error-chain to 0.10.0 and now everything is working again! The problem (probably) is that all sub-crates were compiled to subtitles-rs/target, which then contained error-chain in version 0.8.1 and 0.10.0 from different projects. This seemed to confuse rustc 1.15.1. Now that all error-chain versions are the same, the problem is avoided.

Thank you! I've merged this change and I'll release it when I next work on the library. If that's not in the next week or so, please feel free to bug me. :-)

I'm using the "feel free to bug me"-card: Did you have time to push up a crate release yet? I'd really like to have aligner compiling again...

Done! Sorry for the delay.


doesn't respect some modules

there are some problems like this https://github.com/folke/lua-dev.nvim/blob/e18c4ce4048497384972052d8118eeaa0a681ada/types/lua.lua#L563
which should be vim.ui.select
this can be fixed with something like this:
https://github.com/max397574/lua-dev.nvim/blob/81d6185ab28e18fc56ff092e842beec26c4650d9/lua/lua-dev/parser.lua#L140-L156
https://github.com/max397574/lua-dev.nvim/blob/81d6185ab28e18fc56ff092e842beec26c4650d9/lua/lua-dev/parser.lua#L164-L167
the vim.fs things would have to be added as well

Hi!
You were totally right. The fix was to actually not generate any types for existing lua files.
Existing lua files are properly hooked in types/vim.lua
Fixed in https://github.com/folke/lua-dev.nvim/commit/130b35e0f671c5729d106a4fe113129cb979e4b1


Support for Running Module Federation Projects with devRemotes

Hello,
I'm relatively new to the NX context, and I started looking into the Module Federation Option it provides with Angular.
Previously I used this plugin to serve my individual apps out of the monorepo but now to serve these either static or with live reloading, I need to run them in a single command:
nx serve host-app --devRemotes=remote-app-a,remote-app-b
I'm not even sure if it is possible to add a UI for this, and I'm pretty sure it would be pretty niche at the moment; Nevertheless, I wanted to start a discussion on that.

Hello,
I think it's  possible to do that just pass this to arguments field --devRemotes=remote-app-a,remote-app-b


TypeORM connector + documentation seems to be broken

Describe the bug
With a fresh install of latest versions of AdminJS and TypeORM, it seems there is no way to properly add Resources without breaking AdminJS.
Installed libraries and their versions

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
To Reproduce
Steps to reproduce the behavior:

Install typeorm, @adminjs/express, @adminjs/typeorm
Follow the documentation, but realize that createConnection is deprecated and that Model.getRepository is not documented by TypeORM
Use that index.ts code

{
  "dependencies": {
    "@adminjs/express": "^4.1.0",
    "@adminjs/typeorm": "^3.0.0",
    "@types/express": "^4.17.13",
    "@types/swagger-ui-express": "^4.1.3",
    "adminjs": "^5.10.0",
    "body-parser": "^1.20.0",
    "concurrently": "^7.1.0",
    "cors": "^2.8.5",
    "express": "^4.18.1",
    "express-formidable": "^1.2.0",
    "express-session": "^1.17.2",
    "nodemon": "^2.0.16",
    "pg": "^8.7.3",
    "swagger-ui-express": "^4.3.0",
    "ts-node": "^10.7.0",
    "tsc": "^2.0.4",
    "tsoa": "^4.0.0",
    "typeorm": "^0.3.6",
    "typescript": "^4.6.4"
  }
}

import "reflect-metadata";
import { BaseEntity, Column, DataSource, Entity, PrimaryGeneratedColumn } from "typeorm";
import express, { Request, Response } from "express";
import bodyParser from "body-parser";
import swaggerUi from "swagger-ui-express";
import AdminJS from "adminjs";
import AdminJSExpress from "@adminjs/express";
import * as TypeOrmAdapter from "@adminjs/typeorm";

@Entity()
export class User extends BaseEntity {
  @PrimaryGeneratedColumn()
  id: number;

  @Column()
  email: string;

  @Column()
  name: string;

  @Column()
  status?: "Happy" | "Sad" = "Happy";

  @Column("varchar", { array: true })
  phoneNumbers: string[];
}

export const PostgresDatasource = new DataSource({
  type: "postgres",
  host: "localhost",
  port: 5432,
  username: "postgres",
  password: "example",
  database: "password",
  entities: [User],
  synchronize: true,
})
PostgresDatasource.initialize();

const app = express();

AdminJS.registerAdapter(TypeOrmAdapter);
const adminJs = new AdminJS({
  databases: [PostgresDatasource],
  resources: [{ resource: User, options: { parent: { name: "foobar" } } }],
  rootPath: "/admin",
});
const router = AdminJSExpress.buildRouter(adminJs);
app.use(adminJs.options.rootPath, router);

app.listen(3000, () => console.log("Server live on port 3000"));

Expected behavior
AdminJS to load properly my resources
Actual behavior
NoResourceAdapterError: There are no adapters supporting one of the resource you provided
[0]     at /workspace/api/node_modules/adminjs/lib/backend/utils/resources-factory/resources-factory.js:99:15

Additional informations
If I dig in, I can see that /resources-factory.js:99:15 is actually calling adapter.Resource.isAdapterFor(resourceObject) where adapter is the @adminjs/typeorm one.
On node_modules/@adminjs/typeorm/lib/Resource.js:211, to check if the resource can be loaded - AdminJS calls rawResource.getRepository().metadata in a try catch that silents any error.
If I remove the try/catch, I get that following error
Error: DataSource is not set for this entity.
at Function.getRepository (/workspace/api/src/repository/BaseEntity.ts:115:19)

BaseEntity.ts:115 is doing the following:
    static getRepository() {
        const dataSource = this.dataSource;
        if (!dataSource)
            throw new Error(`DataSource is not set for this entity.`);
        return dataSource.getRepository(this);
    }

I can fix that issue by calling useDataSource on each of my entities (not ideal, but...)
// ...
export const PostgresDatasource = new DataSource({
  type: "postgres",
  host: "localhost",
  port: 5432,
  username: "postgres",
  password: "example",
  database: "example",
  entities: [User],
  synchronize: true,
})
PostgresDatasource.initialize();

User.useDataSource(PostgresDatasource);

const app = express();
// ...

But even doing that, I get another error - this time about Metadata
[0] /workspace/api/src/data-source/DataSource.ts:422
[0]         if (!metadata) throw new EntityMetadataNotFoundError(target)

I'd like to play it by the documentation, but it seems outdated as createConnection is deprecated by TypeORM.
My feeling is that AdminJS tries to load the entities before TypeORM actually ends his initialization work.

Datasource initialization is async. Sorry for bothering. This works
import "reflect-metadata";
import {
  BaseEntity,
  Column,
  DataSource,
  Entity,
  PrimaryGeneratedColumn,
} from "typeorm";
import express, { Request, Response } from "express";
import bodyParser from "body-parser";
import swaggerUi from "swagger-ui-express";
import AdminJS from "adminjs";
import AdminJSExpress from "@adminjs/express";
import * as TypeOrmAdapter from "@adminjs/typeorm";

@Entity()
export class User extends BaseEntity {
  @PrimaryGeneratedColumn()
  id: number;

  @Column()
  email: string;

  @Column()
  name: string;

  @Column()
  status?: "Happy" | "Sad" = "Happy";

  @Column("varchar", { array: true })
  phoneNumbers: string[];
}

export const PostgresDatasource = new DataSource({
  type: "postgres",
  host: "localhost",
  port: 5432,
  username: "postgres",
  password: "example",
  database: "example",
  entities: [User],
  synchronize: true,
});
PostgresDatasource.initialize().then(() => {
  console.log({ m: User.getRepository().metadata });

  const app = express();

  AdminJS.registerAdapter(TypeOrmAdapter);
  const adminJs = new AdminJS({
    databases: [PostgresDatasource],
    resources: [{ resource: User, options: { parent: { name: "foobar" } } }],
    rootPath: "/admin",
  });
  const router = AdminJSExpress.buildRouter(adminJs);
  app.use(adminJs.options.rootPath, router);

  app.use(
    bodyParser.urlencoded({
      extended: true,
    })
  );
  app.use(bodyParser.json());

  app.use("/docs", swaggerUi.serve, async (_req: Request, res: Response) => {
    return res.send(
      swaggerUi.generateHTML(await import("../build/swagger.json"))
    );
  });

  app.listen(3000, () => console.log("Server live on port 3000"));
});


Community packages not working

Hello, i tried following the instructions to extract the community package to the privatezilla package but it still wont run

Found it. Turns out i have to rename the extracted folder from "packages" to "scripts".

Thank you for pointing that out. I have packed it again as scripts directory and will refresh the instructions

Awesome! I love privatezilla and i cant wait to see this implemented :D

Awesome! I love privatezilla and i cant wait to see this implemented :D

I just discovered it and DAMN!!! so neat!!

Nice! I can close this issue!


French version

PS : This is my first pull request, let me know if anything needs to be changed/improved

Merged the wrong branch


hook to override bootstrap

Added a hook to override Bootstrap variables.
Changed the config to point to Bootstrap scss instead of css as variables does not exist outside the scope of Sass.

You did it @vivekkamineni2018!
Thank you for signing the Anthem Opensource Software CLA.

:+1:

@vivekkamineni2018 shouldn't this go in the nimbus-sass-module project?

This will be included in nm-sass-module as Dinakar suggested.   Closing this PR..


Create Docker-compose files and other collateral that uses tagged versions versus latest

For stability, for comparing versions of solutions, it is important to be able to specify versioned software. When our solutions refer to "latest" images, it is a moving target.

@ashahba Do we have docker image of released v0.7, v0.8 on docker hub?

Yes, please! Can we please ensure new versions of containers get pushed to Docker Hub with both a vX.Y release and the latest labels.
That would allow us to pass the $TAG variable and lock in versions.


 Return io::Result<Self> from QueueableCommand::queue and ExcutableCommand::execute. This lets us get rid of the let _ = pattern that ignores errors.
QueueableCommand, ExecutableCommand: Use references to the writer. This lets us dispense with the noise of reassigning stdout back to itself.

Sorry, but I broke your branch :)

@TimonPost can you merge this one? There was an ongoing discussion, which was basically ended with the #229 issue. I'm working on the #229 now and it's conflicting (merge point of view) with this PR. Either I or Anders will be forced to rebase & solve the conflicts again.

Merged!


Does the API contract need to be updated here.

Hi,
Just to explain the angle I'm coming from ..  I use both CoreApp and XamlApp templates in my C# game and related work (with SharpDX interop for DX). I have to manually write the CoreApp template because VS doesn't provide a C# version. I'm looking to move my UWP game engine/framework from being a UWP library to a .Net Standard library. I'm investigating if that's the right course of action and if it's possible in terms of compatible API's / app models etc.
As I understand this IFrameworkView API, it's a projection from WinRT. I notice in the docs here the device family and API contracts are as follows ..
Device family = Windows 10 (introduced v10.0.10240.0)
API contract = Windows.Foundation.UniversalApiContract (introduced v1)
Is this still correct or is there some information missing here or elsewhere on this page when considering  Microsoft.Windows.SDK.Contracts for consuming WinRT from .Net Core.
And to raise some specific queries I have regarding this API ..

Is the IFrameworkView app template, or at least the API and app model as used in UWP now available in .Net Core?
Likewise can I use the Xaml app model from UWP (not Xaml Islands) in .Net Core?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 69a05178-aff3-7f67-305e-2eba49cb17da
Version Independent ID: 72c12587-21c1-5a98-5538-b0b1d5f23dbc
Content: IFrameworkView Interface (Windows.ApplicationModel.Core) - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.applicationmodel.core.iframeworkview.yml&version=GBlive&_a=contents
Product: uwp
Technology: winrt-reference
Git Login: knicholasa
Microsoft Alias: nichola

inline below...

Hi,
Just to explain the angle I'm coming from .. I use both CoreApp and XamlApp templates in my C# game and related work (with SharpDX interop for DX). I have to manually write the CoreApp template because VS doesn't provide a C# version. I'm looking to move my UWP game engine/framework from being a UWP library to a .Net Standard library. I'm investigating if that's the right course of action and if it's possible in terms of compatible API's / app models etc.
As I understand this IFrameworkView API, it's a projection from WinRT. I notice in the docs here the device family and API contracts are as follows ..
Device family = Windows 10 (introduced v10.0.10240.0)
API contract = Windows.Foundation.UniversalApiContract (introduced v1)
Is this still correct or is there some information missing here or elsewhere on this page when considering Microsoft.Windows.SDK.Contracts for consuming WinRT from .Net Core.

This is the correct information.  CoreApplication, IFrameworkView, IFrameworkViewSource are all UWP APIs.  The two interfaces in the list above are the extension points you need to implement in order to use CoreApplication to show UI when you don't have a framework that already implements them for you.  For instance XAML implements these interfaces in order to provide you the more curated XAML Application object.

And to raise some specific queries I have regarding this API ..

Is the IFrameworkView app template, or at least the API and app model as used in UWP now available in .Net Core?

As long as you're building a UWP app, these interfaces are available.  I'm not sure if we have a VS template for using them from .NET Core, but it shouldn't be too hard to write from scratch (by following what the other templates look like).  I feel like the DirectX 11 template in VS is a decent one to copy if you follow how the App class is constructed.

Likewise can I use the Xaml app model from UWP (not Xaml Islands) in .Net Core?

I'm unaware of any restrictions around using XAML from .NET Core.  I'll find out for sure and respond here.
Thanks
--Scott


How can I specify virtual network device?

System Information
Linux distribution
Ubuntu 22.04
Terraform version
OpenTofu v1.6.1
on darwin_arm64

Provider and libvirt versions
provider registry.opentofu.org/dmacvicar/libvirt v0.7.6
libvirtd (libvirt) 8.0.0

Description of Issue/Question
I want to bind virtual network to specific host interface, but i can't find the way to do it.
I don't know if this feature is missing or it's just a documentation issue.
Setup
terraform {
  required_providers {
    libvirt = {
      source = "dmacvicar/libvirt"
      version = "0.7.6"
    }
  }
}

provider "libvirt" {
  uri = "qemu+ssh://..."
}

resource "libvirt_network" "services-network" {
  name = "office-services"
  mode = "route"
  domain = "services.office.internal"
  addresses = ["<IP_ADDRESS>/28"]
  bridge = "office-services"
  autostart = true

  dhcp {
    enabled = true
  }

  dns {
    enabled = true
    local_only = true

    forwarders {
        address = "<IP_ADDRESS>"
        domain = "office.internal"
    }
  }
}

Steps to Reproduce Issue
This setup will generate the following network xml:
<network>
  <name>office-services</name>
  <uuid>553965c9-578c-4d58-abbf-e2fab9107430</uuid>
  <forward mode='route'/>
  <bridge name='office-services' stp='on' delay='0'/>
  <mac address='52:54:00:2d:74:e3'/>
  <domain name='services.office.internal' localOnly='yes'/>
  <dns enable='yes'>
    <forwarder domain='office.internal' addr='<IP_ADDRESS>'/>
  </dns>
  <ip family='ipv4' address='<IP_ADDRESS>' prefix='28'>
    <dhcp>
      <range start='<IP_ADDRESS>' end='<IP_ADDRESS>'/>
      <host mac='02:00:00:00:00:01' name='reverse' ip='<IP_ADDRESS>'/>
    </dhcp>
  </ip>
</network>

I've edited it manually to define dev attribute of forward node. After saving network xml becomes this way:
<network>
  <name>office-services</name>
  <uuid>553965c9-578c-4d58-abbf-e2fab9107430</uuid>
  <forward dev='office' mode='route'>
    <interface dev='office'/>
  </forward>
  <bridge name='office-services' stp='on' delay='0'/>
  <mac address='52:54:00:2d:74:e3'/>
  <domain name='services.office.internal' localOnly='yes'/>
  <dns enable='yes'>
    <forwarder domain='office.internal' addr='<IP_ADDRESS>'/>
  </dns>
  <ip family='ipv4' address='<IP_ADDRESS>' prefix='28'>
    <dhcp>
      <range start='<IP_ADDRESS>' end='<IP_ADDRESS>'/>
      <host mac='02:00:00:00:00:01' name='reverse' ip='<IP_ADDRESS>'/>
    </dhcp>
  </ip>
</network>

Is it possible to achieve this result with provider?

Hello,
does specifying device work with pure libvirt?
And out curiosity, what are you trying to achieve?

Hello,
yes, it's works with pure libvirt )
I want to pass nic port direct to vm


Flask-appconfig overwrites flasks binary

Currently flask==0.12 comes with a flask binary. flask's-appconfig flask utility overwrites it/gets overwritten by flasks original binary.
IMO the utility should be renamed because i.e current flask docs gives instructions on how to use their original flask binary, and as it turned off I was trying to apply those instructions to a different binary :)

That's correct. The binary is actually obsolete, newer versions integrate with flask's own CLI interface. I'll look into this.


Improve resilience to failed packets on ordered channels

Summary

There is a risk that Hermes enters in a state where it will fail to relay all packets on an ordered channel until the packet clearing is triggered.
This can happen when a packet is not successfully relayed, but isn't noticed by Hermes. It will then try to relay the next packets but they will all fail due to a sequence number mismatch.
Hermes shouldn't blindly try to relay any packet if it fails to relay one in an ordered channel.

For Admin Use

[x] Not duplicate issue
[x] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

@soareschen suggested that we could maintain a priority queue of packets to be relayed, ordered by sequence numbers.
As a I see it, we would update the queue whenever we get a new event batch. After successfully submitting a tx, we would remove from the queue the packets we just submitted and move on the remaining ones. Whenever we fail to do so, we can refresh the queue by querying for packets yet to be relayed on the channel.
Does that make sense to you, @ljoss17 @soareschen?

Why can't we trigger/call packet clearing if needed for seq < n, before we process the event for n?

Quick notes from the call with @ljoss17 and @seanchen1991:
diff --git a/crates/relayer/src/link/relay_path.rs b/crates/relayer/src/link/relay_path.rs
index dc01a71f7..e4b74a1b6 100644
--- a/crates/relayer/src/link/relay_path.rs
+++ b/crates/relayer/src/link/relay_path.rs
@@ -673,10 +673,40 @@ impl<ChainA: ChainHandle, ChainB: ChainHandle> RelayPath<ChainA, ChainB> {
                 }
                 Err(LinkError(error::LinkErrorDetail::Send(e), _)) => {
                     // This error means we could retry
-                    error!("error {}", e.event);
+                    error!("error {}", e.event); // TODO: better message here
+
+                    // if on ordered channel, do a packet clearing, but only if we are not doing
+                    // a packet clearing already.
+                    if self.ordered_channel() && i == 0 && !odata.tracking_id.is_clearing() {
+                        // Need to specify height for clearing?
+                        // Probably not since no progress will have been made
+                        self.relay_pending_packets(None)?;
+                    }
+
+                    // fine up to: 112
+                    // next expected: 113
+                    // submitting: 120, 121
+                    //
+                    // a1) pending: 114, 115, 116, 117, 118, 119, 120, 121
+                    //    cleared: 114, 115, 116, 117, 118, 119, 120, 121
+                    //
+                    // a2) pending: 114, 115, 116, 117, 118, 119
+                    //     cleared: 114, 115, 116, 117, 118, 119
+                    //
+                    // b1) pending: 114, 115, 116, xxx, 118, 119
+                    //     cleared: 114, 115, 116 (?)
+                    //
+                    // b2) pending: 114, 115, 116, xxx, 118, 119
+                    //     cleared: none
+                    //
+                    // c)  pending: 114, 115, 116, 117, 118, 119
+                    //     cleared: none
+
                     if i + 1 == MAX_RETRIES {
                         error!("{}/{} retries exhausted. giving up", i + 1, MAX_RETRIES)
                     } else {
+                        // TODO: output current retry step here in debug!
+
                         // If we haven't exhausted all retries, regenerate the op. data & retry
                         match self.regenerate_operational_data(odata.clone()) {
                             None => return Ok(S::Reply::empty()), // Nothing to retry

Can https://github.com/informalsystems/hermes/issues/3695 also be solved as a part of this?

Can #3695 also be solved as a part of this?

Yes, seems resolved with the change

Seems https://github.com/informalsystems/hermes/pull/3610 does not resolve such case: timeout is not triggered if exceeds max gas error is raised after submitting large txs as test in here. While golang relayer will send MsgTimeout to controller chain and then MsgChannelCloseConfirm to host chain after max gas error.


Should we have an issue that informs us a new OpenSSL or wxWidgets version is out?

So we could sync. CI and be "on top of latest"...

Or, more generally, how should we implement in such a way that we can rebuild older artifacts with newer OpenSSL versions?

OTP team doesn't rebuild artifacts and so I wouldn't either. I don't think we care if there's a new OpenSSL or wxWidgets version, we don't need to be absolutely up to date in my opinion. What I'd do instead is see what openssl/wx version OTP builds for Windows are using so we're consistent.

OTP team doesn't rebuild artifacts and so I wouldn't either

But they don't statically link OpenSSL for you either, unless you want, right? But I agree we can live without it and use the same versions as they do for Windows.
I'll leave this open, to think of a mechanism to obtain those versions and warn us. Sounds Ok?

OTP builds for windows are statically linking openssl and wxwidgets.

Ah, I wasn't thinking about Windows specifically, but you're right. If you feel we can accompany those without some sort of automated mechanism, feel free to close. I just wanted to understand if it's something we wanted.

Yeah, I'd like to keep this open and add some automatic check that ensures we use the same versions as OTP. Can be a nightly job or whatever. It's a low priority but would be nice to have imo.


ci: Add pullapprove configuration file

Signed-off-by: Samuel Ortiz<EMAIL_ADDRESS>

Coverage increased (+0.4%) to 68.178% when pulling 401790e79aa6c255490a747cacdad38538a35136 on sameo/topic/ci into 5147036af300c71e131d0596c37646f6a61c23e5 on master.

Approved


regulation of translation in response to stress

I wonder if
regulation of translation in response to stress and all its children except for
the mitochindrial terms
regulation of mitochondrial translation in response to stress ; GO:0010892
could be renamed as cytoplasmic  translation regulation terms?
(and new general terms created)
I checked all  of the existing annotations (73), and they all refer to cytoplasmic translation except for the ones annotated specifically to mitochondrial terms.
Many thanks
Val
Reported by: ValWood
Original Ticket: geneontology/ontology-requests/8638

Can close this one. I wanted terms so that we could ensure  all of our gene products were appropriately annotated to mitochondrial or cytoplasmic translation. This is done so all of the terms I needed are there. Anything else required can be done later.
Val


[deps] dependabot config switch to live (from nightly) and security updates only

Motivation
As we are now in a mode where the master branch is to be treated as a release branch we should now disable updating dependency on the master branch unless they are security fixes.   Which will now be opened as soon as they are available rather than being batched nightly.
It may be a tad premature as we still have several months before go live.   I'd be okay with waiting until we actually cut the branch but want the call able to made now.
Have you read the [Contributing Guidelines on pull requests]
Y
Test Plan
Dependabot's handy-dandy config validator:  https://dependabot.com/docs/config-file/validator/
Related PRs
None

@sausagee yes dependabot supports multiple branches, I'll configure it for security updates only on release branches when the time comes.

@bors-libra r+

:pushpin: Commit 0b54161 has been approved by rexhoffman

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #5142

:pushpin: Commit 0b54161 has been approved by sausagee

:hourglass: Testing commit 0b541617aeaa06dca30541d655359935d3fb0cef with merge 9f354de7bc4d98a68ecf67790597681ad3ae4bd1...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sausagee
Pushing 9f354de7bc4d98a68ecf67790597681ad3ae4bd1 to master...


redirectUri not available on SilentFlowRequest

Please follow the issue template below. Failure to do so will result in a delay in answering your question.

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[x] `<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Important: Please fill in your exact version number above, e.g<EMAIL_ADDRESS>Description
The docs for SilentFlowRequest mention a redirectUri property, but it's not available on the type.  Will this be added in the future?
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/c6db556ceef9012bc1852dcf27e9d46fae4c2046/lib/msal-common/src/request/SilentFlowRequest.ts#L16
Security

[ ] Is this issue security related?

Regression

[ ] Did this behavior work before?
Version:
(similar functionality did exist in msal 1.2.x)

Expected behavior
The redirectUri property should be available on the type and be used appropriately.
Browsers/Environment

[x] Chrome
[x] Firefox
[x] Edge
[x] Safari
[x] IE
[ ] Other (Please add browser name here)

@dapathy Thanks for pointing that out. It was something we were considering for silent flow, but have since decided against it. If you need a redirectUri in case of a refresh token error, please use the redirectUri parameter in configurations.

@jo-arroyo In the msal 1.x library, we could specify the redirectUri so that the iframe could point to an empty page.  Is that no longer necessary?  Thank you

@dapathy Apologies I think this was an oversight. I will add the ability to specify this for iframe request.
To be clear, acquireTokenSilent in 2.x will only open an iframe if the refresh token is expired.
ssoSilent also opens an iframe, and accepts a redirect URI

Thank you


Add helm namespace to templates

Which problem is this PR solving?

Closes #146

While helm install can respect the kubectl context namespace or accept a namespace flag, when using helm template, this information is lost if not persisted to the generated files. This means tooling that requires a helm template -> kubectl install has to work around the missing namespace.
Short description of the changes
Adds in the default .Release.Namespace value to the namespace for each namespace resource. https://helm.sh/docs/chart_template_guide/builtin_objects/ . Similar changes have been made such as https://github.com/helm/charts/pull/17937/files#diff-4dcbfca5f8fd1c82a179cf60e0448926548323d101f0321679e2fd1e3a2dc665R12  found on the original issue https://github.com/helm/helm/issues/5465
How to verify that this has the expected result
❯ kns
Context "ngrok-dev-us" modified.
Active namespace is "default".
❯ helm template ./charts/opentelemetry-collector | grep -i namespace
  namespace: default
  namespace: default
  namespace: default
  namespace: default
  namespace: default
❯ kns
Context "ngrok-dev-us" modified.
Active namespace is "kube-system".
❯ helm template ./charts/opentelemetry-collector | grep -i namespace
  namespace: kube-system
  namespace: kube-system
  namespace: kube-system
  namespace: kube-system
  namespace: kube-system

@alex-bezek Apologies for the delay. This looks good -- the main question before I approve it is whether there are any updates needed to the README file? I don't know enough to know if something there should change as a result of this.

No problem @kentquirk. This change is just leveraging an existing helm built in value the Release object. https://helm.sh/docs/chart_template_guide/builtin_objects/ . This particular one, the namespace, is set by helm. If you do a helm install it uses the namespace of your current kubecontext. If using helm template there is a --namespace flag.
I wouldn't document the built-in objects in your readme, but if you'd like I could add just a section explaining that namespaces are added to all namespace-able objects and it uses the helm internals to do so.

Sounds like we don't need any documentation changes. I just wanted to be sure that there wasn't something non-obvious.


BUG: inconsistent prompt behavior (JSON vs. raw response)

I know the interpreter is not an officially released feature, but I thought I'd report this observed unexpected behavior (not sure if it's necessarily a bug), in case you'd want to change it before the release. I can also contribute a fix (if you accept pull-requests).

Version (please complete the following information):

OS: macOS 14.6.1
Browser: Arc
Web Clipper version: 0.9.4
Obsidian version: 1.7.4 (Installer 1.6.7)

Describe the bug
{{prompt}} sometimes returns a markdown that can be inlined directly, and sometimes a JSON. I think this inconsistent behavior is unintended.
To reproduce
Use this template (full JSON below):
{{prompt:"a markdown bullet-point list of the main takeaways with sub-points for the important details"}}

I tried a few different ways to prompt for a "list", a "nested list", a "bullet-point markdown list", etc. but every time it would return a JSON array or JSON object. So I landed on asking for an array and using |list filter to convert it to a markdown list.
For example for the Obsidian Web Clipper page it returns:
Lengthy output
[
  "Obsidian Web Clipper Overview",
  "- A browser extension for saving web content to your Obsidian vault.",
  "Getting Started",
  "- Install from browser-specific directories: Chrome, Firefox, or Safari.",
  "- Requires Obsidian version 1.7.2 or above.",
  "Basic Usage",
  "- Access Web Clipper through browser icon, hotkeys, or context menu.",
  "- Use 'Add to Obsidian' to save content.",
  "Interface Structure",
  "- Header: Switch templates, enable highlighter, access settings.",
  "- Properties: Metadata extracted from the page.",
  "- Note Content: Content to be saved to Obsidian.",
  "- Footer: Select vault and folder.",
  "Templates",
  "- Create templates to capture and organize page metadata.",
  "- Import and export templates using JSON files.",
  "Template Triggers",
  "- Automatically select templates based on URL or schema.org data.",
  "Variables in Templates",
  "- Use preset, meta, selector, and schema variables to populate data.",
  "Filters",
  "- Modify variables with various filters for dates, text, arrays, etc.",
  "HTML Processing",
  "- Tools for handling HTML to Markdown conversion."
]

I also tried instructing it explicitly to not use JSON:
{{prompt:"a markdown bullet-point list of the main takeaways with sub-points for the important details. format it as a single Markdown string, not a JSON array"}}

and that returned an empty response.
I tested it mostly with gpt4o-mini.
Expected behavior
I expect it to always return markdown (or a "raw" response), unless instructed otherwise.
Or maybe always return JSON with some predictable structure (although I think it's much less user-friendly). I can appreciate structured output that can be processed with filters, but I think the current behavior is inconsistent and confusing.
Your template file
{
	"schemaVersion": "0.1.0",
	"name": "Summarize bug report",
	"behavior": "create",
	"noteContentFormat": "{{prompt:\"a markdown bullet-point list of the main takeaways with sub-points for the important details\"}}",
	"properties": [],
	"triggers": [],
	"noteNameFormat": "{{title}}",
	"path": "clippings"
}

I've identified these relevant locations in the code:

System prompt instructs the model to return JSON:
https://github.com/obsidianmd/obsidian-clipper/blob/bea800d5894876e6ef2bc0a9c57d4b443dc5e66a/src/utils/interpreter.ts#L24

The reponse is either parsed as JSON or returned raw:
https://github.com/obsidianmd/obsidian-clipper/blob/bea800d5894876e6ef2bc0a9c57d4b443dc5e66a/src/utils/interpreter.ts#L122-L131

There is some special handling of the array an object responses:
https://github.com/obsidianmd/obsidian-clipper/blob/bea800d5894876e6ef2bc0a9c57d4b443dc5e66a/src/utils/interpreter.ts#L433-L441
I'm not sure what the intent was here, but I suspect that this is the place causing the behavior described above.

The feature is not completed and not yet documented.