FormattedAsset returns Optional class string rather than expected string

The FormattedAsset class is returning bad string values for id, assetCode, issuer, etc. Basically looks like an optional is getting miscast or using .toString() incorrectly.
What version are you using?
Kotlin: 0.7.0
What did you do?
val accountInfo = stellar.account().getInfo(walletAddress)
val balance = accountInfo.assets.find { asset ->
    asset.assetCode == assetCode
}

What did you expect to see?
Correct asset code, id, etc
What did you see instead?
Optionals casted to strings.

Here looks like the culprit on org.stellar.walletsdk.util.Format.kt
// Non-native asset
      (balance.assetType == AssetType.ALPHANUM_4.type ||
        balance.assetType == AssetType.ALPHANUM_12.type) -> {
        val asset =
          FormattedAsset(
            id = "${balance.assetCode}:${balance.assetIssuer}",
            // TODO: fetch home domain
            homeDomain = "",
            // TODO: fetch name
            name = "",
            // TODO: fetch imageUrl
            imageUrl = "",
            assetCode = balance.assetCode.toString(),
            assetIssuer = balance.assetIssuer.toString(),
            balance = formatAmount(balance.balance),
            availableBalance = formatAmount(balance.balance),
            buyingLiabilities = formatAmount(balance.buyingLiabilities.toString()),
            sellingLiabilities = formatAmount(balance.sellingLiabilities.toString())
          )

This class is removed in #117


neovide: fix build on darwin

Description of changes
Add necessary dependencies to fix build on darwin
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:
[x] Tested basic functionality of all binary files (usually in ./result/bin/)

ping @ck3d

Result of nixpkgs-review pr 191561 run on aarch64-darwin 1

1 package built:

neovide


Fail to get facebook "image text" post

This kind of post return no text even if the text can be text copied on the mbasic version.

@Cartasiane  Can you give a public group example ?

from facebook_scraper import get_posts

for post in get_posts('890901752414740', base_url="https://mbasic.facebook.com/groups",
start_url="https://mbasic.facebook.com/groups/890901752414740",
                      pages=50,
 cookies = "./cookies.txt"):

  print(post)

@Cartasiane i have updated the repo to be able to get that type of text, but there is probably some change between cookies and regions, it seems mbasic is going away from using article elements. let's see for now.

@Cartasiane i am closing this issue, since the bug seems to be fixed and we do get the text from the fancy post texts.


feat: bidirectional references

referenced items should keep track of all elements that reference them
this allows efficient updates to the references when the base item changes (updated or deleted)
When a base item gets deleted all its references should also get deleted.
When a reference gets deleted, the base item should stop pointing to it.

closing this in favor of #345


Vercel deployment missing for nachet-frontend

While trying to debug an error message from the backend, I noticed that I can't make changes to the frontend without affecting the main URL which could cause issues later if it's not incorporated so need to add the ability to support multiple URL

@rngadam I would like to know if we have fully switched to vercel or if we plan on still using gh-pages for nachet-backend, because of how finesse-frontend is setup I thought adding the deployment to vercel wouldn't be an issue but create-react-app makes this very very complicated, I have been trying to debug it for the past hour and I just want to make sure if it's something that will be useful or not. I have an idea of the fix, basically need to set a env variable before the build so that the right script from pacakge.json gets triggered, but just don't want to spend a long time on it for nothing

As discussed, there are solutions to serve from relative paths or specifying the PUBLIC_URL at build time:
https://stackoverflow.com/questions/43011207/using-homepage-in-package-json-without-messing-up-paths-for-localhost

As discussed, there are solutions to serve from relative paths or specifying the PUBLIC_URL at build time:
https://stackoverflow.com/questions/43011207/using-homepage-in-package-json-without-messing-up-paths-for-localhost

I tried all the solution that were available I don't know if I'm just not knowledgable enough to make it work but I found another solution I will create a PR for it now and tell me if it's okay with you

What did you try and what were the error messages?

also, I see the title here and the PR talks about nachet-backend, but should be nachet-frontend?

also, I see the title here and the PR talks about nachet-backend, but should be nachet-frontend?

copy pasted from the issue I changed both my mistake

What did you try and what were the error messages?

I tried setting the homepage as ".", that didn't change anything, I then tried to add a baseurl like in finesse-frontend and even though in the network tab it made the request to the right URL (meaning https://ai-cfia.github.io/nachet-frontend/static/js/main.3f829c92.js for example) the page still was blank and nothing was appearing, I am guessing maybe because the homepage was still serving to the root but I could be totally wrong I am really not good enough to be able to debug issues like this yet

Have you tried setting PUBLIC_URL?
https://create-react-app.dev/docs/advanced-configuration/
Create React App assumes your application is hosted at the serving web server's root or a subpath as specified in package.json (homepage). Normally, Create React App ignores the hostname. You may use this variable to force assets to be referenced verbatim to the url you provide (hostname included). This may be particularly useful when using a CDN to host your application.

Have you tried setting PUBLIC_URL?
https://create-react-app.dev/docs/advanced-configuration/
PUBLIC_URL
Create React App assumes your application is hosted at the serving web server's root or a subpath as specified in package.json (homepage). Normally, Create React App ignores the hostname. You may use this variable to force assets to be referenced verbatim to the url you provide (hostname included). This may be particularly useful when using a CDN to host your application.

i think this one worked


fix: package.json use sourceDir for new command

When creating a new app using ng new appName --source-dir sourceDir, package.json was not using the sourceDir option.

I signed it!

Committed under my wrong name...


Sanitizer checkers

I'm not sure what to do with the ambiguous messages: sometimes different "checkers" emit the same log message that we use for identification. So this PR is WIP.


Move spec and guide to old location

Fixes #1630

LGTM. Merging without waiting for CI, because no code is affected.


"Warning: tried to add target beyond target's input capacity"

Hey BradLarson,
i use UICollectionView, and make config in 'didSelectItemAt' func like code blow
let color = colors[indexPath.item]
filter.red = Float(color.red!)
filter.green = Float(color.green!)
filter.blue = Float(color.blue!)
picture --> filter --> renderView
picture.processImage()

then it'll show  "Warning: tried to add target beyond target's input capacity"
how to solve it?

@w-i-n-s
you mean reset the filter?  create a new filter again?

you mean reset the filter? create a new filter again?
I meant the creation of the new one

Is there any update in this?

You need to clear SourceContainer in destination ImageConsumer (e.g. in renderView or filter), before attach consumer again
renderView.sources.removeAtIndex(0)


bug: db.Ping is a no op

Connection interface has a Ping method which pings the server and checks if the server is up: https://pkg.go.dev/database/sql#DB.PingContext
Since we don't implement it, even if the server is unreachable, ping does not report any errors. To fix it, we can use a simple query like SELECT 1
Here is a regression test:
import (
	"database/sql"
	"fmt"
	"os"

	_ "github.com/tursodatabase/libsql-client-go/libsql"
)

var dbUrl = "http://<IP_ADDRESS>:8080" // some non existent server
db, err := sql.Open("libsql", dbUrl)
if err != nil {
   //
}
db, err := db.Ping()
if err != nil {
  // this never runs
}

I can take a look at this one

feel free to @webstradev! 😄


ENA-230: Request for a "set saturation effect" block

Hi Scratch team,
Myself and many other creators on scratch would like to request a "set saturation effect" block in Scratch. This would allow users to adjust the intensity of the colors in a sprite, making them more or less vibrant.
Why should this suggestion be implemented?
My personal need for this block is because I want to be able to stamp with a specific saturation. This would make it possible for my project: https://scratch.mit.edu/projects/723419988/ to stamp any solid coloured triangle quickly.
In addition to my use case of stamping rgb quickly, this effect would be useful for regular scratch usage. Some ideas of how it could be used are:

Easy shadows: clone a sprite, send it to the back layer, offset slightly and set the saturation to 0 and you have a quick shadow.
Grayed out options: If a scratcher makes a GUI for their game, they might want buttons which are grayed out. For example in a level select menu, you want to gray out future levels.
Fun animations: with saturation scratchers can create animations which take advantage of saturation. One example, might be a player sprite which smoothly transistions from colour to grayscale and back to represent the character being at low health.

These are just some ideas I thought of off the top of my head, but I'm sure if you made a saturation effect easily accessible it would inspire even more creative ideas.
What workarounds exist?
A workaround for this block exists with this: https://scratch.mit.edu/projects/623945749/ but it requires two stamps and alot of calculations which causes it to be much slower than a built in block would be. This workaround is also inaccessible and unintuitive for regular scratchers to use. (most scratchers do not know about the existence of this method, let alone how it works)
A workaround for achieving grayscale specifically exists which is to set the colour effect to infinity. However similarly this is quite inaccessible and unintuitive.
How could this suggestion be implemented?
The implementation of this suggestion is not neccessarily simple (nothing is ever simple!), but it's certainly not difficult. Since the block "set colour effect" exists, the saturation block can be created by just copying the code for the "set colour effect" in every location that "set colour effect" is referenced and modifying it for "set saturation effect"
Specifically the changes required are:

in scratch-render/src/shaders/sprite.frag add a shader for saturation. This is very similar to the one for colour except it simply clamps the saturation value and then sets hsv.y to this value. You would also need to update the color shader to allow for saturation to go to 0, when saturation is enabled, as at the moment it sets a minimum saturation of 0.11
in scratch-render/src/EffectTransform.js add logic for saturation. The logic here is similar to what is used in sprite.frag to add saturation. The structure can be copied from the logic for color.

sprite.frag and effectTransform have the main changes but the below files also need minor changes:

in scratch-render/src/ShaderManager.js the new saturation effect needs to be added. This can be almost exactly copied from the object used for brightness
in scratch-render/src/playground/ index.html and playground.js do minor changes to make sure the render demos still work correctly.
in scratch-blocks/blocks_vertical/looks.js add the new 'SATURATION' option to the setEffect block dropdown options.
scratch-blocks/msg/json/en.json add the new 'SATURATION' option
in scratch-l10n/editor/blocks add a new option to the json for each language called "LOOKS_EFFECT_SATURATION". The value for this can be automatically taken from "COLOUR_SATURATION_LABEL" just change it to lower case ;)

I hope you will consider this feature request. Thank you for your time and for creating such a wonderful platform for creativity and learning.
Best regards,
Joe (Chrome_Cat)

If i made a pull request with the changes is there a chance this could be considered?

Hi, any progress? I am considering doing the changes myself to reduce the work for you guys. Your team seems to be hyperfocused on "colour" right now, so this change would fit right in ;)


Standalone files are not recognized inside git repo

When single file is opened inside the git repo, get_root_dir doesn't return nil, instead it returns a path to the git root:
https://github.com/simrat39/rust-tools.nvim/blob/9f89fe6d9762ef89973bbb698c750dd21b94ec44/lua/rust-tools.lua#L175-L178
Because of that, the standalone client is not run:
https://github.com/simrat39/rust-tools.nvim/blob/9f89fe6d9762ef89973bbb698c750dd21b94ec44/lua/rust-tools.lua#L192-L198
It might be not safe to just remove the line checking for the git repo, hence not proposing a PR.
I assume the following part might be an issue:
https://github.com/simrat39/rust-tools.nvim/blob/9f89fe6d9762ef89973bbb698c750dd21b94ec44/lua/rust-tools.lua#L181-L186

Not sure how to fix this, don't exactly wanna remove the check for git root but then I can't think of any other way


[Request for External] Table 5902 "Service Line" - UpdateRemainingCostsAndAmounts

Dear ALAppExtensions,
Please consider removing the local modifier from UpdateRemainingCostsAndAmounts on Service Line. We wish to be able to use this function in our extension triggers.
// local procedure UpdateRemainingCostsAndAmounts()
procedure UpdateRemainingCostsAndAmounts()

Thank you,
SR

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10221.


[IRGen] swift_getFunctionTypeMetadataGlobalActor has concurrency availability

Explanation: Fix two problems in IRGen where we were not correctly weak-importing symbols from the _Concurrency library, which caused crashes when the program was executed on OS's that do not include support for concurrency.
Scope: Affects back-deployed applications that have adopted concurrency behind @available(...).
Radar/SR Issue:  rdar://79674106
Risk: Low.
Testing: PR testing and CI on main.
Original PR: https://github.com/apple/swift/pull/38140

@swift-ci please test

@swift-ci please nominate

Build failed
Swift Test Linux Platform
Git Sha - 7d30d0489ea13964b2ecabf8d45d59a00a69dffc

@swift-ci please test


Fix progress bar, use requests, tqdm version

This fixes the small progress when downloading the data as sc.datasets.paul_15(), etc..
Also fixes removing the file when KeyboardInterrupt occurs (previously, it was just on exceptions and at least for me I sometimes stop a download by interupting the jupyter kernel - now it also correctly removes the partially downloaded file).
I've also opted for requests library, since it's much cleaner than urllib3 and as a dependency.
However, this is completely unrelated to the 2 things I've mentioned above and can be quickly reverted.
Relevant PRs I could find:

tqdm version (I opted for bumping the version [search through open issues, lowest one had 4.32]): https://github.com/theislab/scanpy/issues/1244

Not relevant:
My reaction when using the progress bar (slightly NSFW [foul language]).

The main change here is passing None instead of 0 to total, right?
Also: this makes some errors with files still existing make much more sense. I had no idea KeyboardInterrupt doesn't inherit from Exception.

Thanks for a quick response and the comments.

The main change here is passing None instead of 0 to total, right?

It was actually setting it in the contructor, rather than assigning it to the tqdm object (the latter doesn't work).
Here's before:

and after:

Also: this makes some errors with files still existing make much more sense. I had no idea KeyboardInterrupt doesn't inherit from Exception.

I didn't know that either, so I looked it up (it actually inherits from BaseException among other things:
https://docs.python.org/3/library/exceptions.html#exception-hierarchy

Just noticed the ? at the end (both-cases), last commit should fix it (it was the updating), here's the final result:

Hey @ivirshup, can you please use the “Squash & merge” button?
It’s not super useful to drill through commits called “Rever tqdm/requests change” when searching a file’s history


Fix issue where exit code was not being appropriately returned

Essentially, instead of diagnostics referring to the same variable throughout compileProgram, each of the let declarations created a new scoped variable, meaning that the test at the end was not picking up "global" and "semantic" errors.
Fixes #4095.

:+1:

:+1:


Add API call for multiple molecule inputs

Currently the api call /api/v1/hiers/get_scaffolds allows for the user to return scaffolds for a single molecule. It would be nice if we had an api call that returned scaffolds for a list of input molecules. The molecules could still be provided in SMILES format, but be comma (",") separated and parsed accordingly.

This has been resolved.


REM-25119 Document minimum supported and tested versions in README

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   84.78%   84.78%
=======================================
  Files          24       24
  Lines        1275     1275
=======================================
  Hits         1081     1081
  Misses        194      194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2cde8...a818a80. Read the comment docs.


Automate the Preflight release update

Test-hints: no-check

Not sure it's the best way to proceed, we should maybe prefer dependabot instead. @thekad @fredericlepied wdyt?

Tania, how do you test test? Just wondering if there is place where we could see this in action. Thanks

I tested all shell commands locally, and something similar works on my private project.
But that's true, I have no viable testing strategy here except to merge and to run the workflow. Let me ask @tonyskapunk and @thekad how they did for already existing actions.

Let me ask @tonyskapunk and @thekad how they did for already existing actions.

You could, for sake of testing, modify the workflow to be applied on a pr, that way it will be triggered automatically

Test if both releases are the same and we don't have to open a PR.

Tested, to open PR works: GH action logs and PR that was opened.

From my side, it looks good, really good work! But I'm wondering something, @tkrishtop , did you check if github-actions user has permissions to run DCI jobs in github-stream repo? The user needs to belong to dci-labs or redhatci organizations, if I'm not wrong.

Good point, that's something difficult to test before the Preflight team will release a new version. I've seen that for external contributors we have to approve all and the test set and here all the tests were launched automatically, so I believe we should be fine.

I think you didn't get my point. The only thing we need to ensure is that github-actions user is included in the redhatci organization, else the PR would be created but probably no DCI job will be launched because the user will be unauthorized based on the config we have on github-stream.

From my side, it looks good, really good work! But I'm wondering something, @tkrishtop , did you check if github-actions user has permissions to run DCI jobs in github-stream repo? The user needs to belong to dci-labs or redhatci organizations, if I'm not wrong.

Good point, that's something difficult to test before the Preflight team will release a new version. I've seen that for external contributors we have to approve all and the test set and here all the tests were launched automatically, so I believe we should be fine.

I think you didn't get my point. The only thing we need to ensure is that github-actions user is included in the redhatci organization, else the PR would be created but probably no DCI job will be launched because the user will be unauthorized based on the config we have on github-stream.

sure, this we could do, thanks @ramperher

recheck


go-fuse: set AttrTimeout, EntryTimeout and NegativeTimeout to 600s

Is your feature request related to a problem? Please describe.
The fuse process is not tuned. To achieve better performance for metadata operations, one can try tuning the following parameters: AttrTimeout, EntryTimeout and NegativeTimeout.
Describe the solution you'd like
User can set the above parameters in config.toml. The default values for those should be set to 600s.
The PR should contain the comparison for the workloads performance with the value 600s to baseline performance (all values are set to 0).

Where's the default value of 600s coming from?

https://github.com/awslabs/soci-snapshotter/blob/5a80cdafeb08957b7a3296183fe4b00bb5929522/fs/fs.go#L134-L147

Overall, trying to tune FUSE kernel cache expiration timeouts didn’t make any gains in improving RabbitMQ-type workloads. To make a difference with RabbitMQ specifically, it is suggested to set min-layer-size parameter to 10MiB when building the soci index. For more details, see the attached doc:
Experimenting with FUSE kernel cache expiration timeouts.pdf


Surface CPSM error feedback information

SUMMARY
In some cases, CPSM's API is able to provide more detailed error feedback information.  You can simulate this by making an update request for a pipeline definition, omitting the starting slash from the config file path.  This information won't currently be surfaced in the output from the Ansible modules, but should be at some point.

Another easy way to recreate is passing in an invalid host. We get back the message
"Error performing CMCI request: <urllib3.connection.HTTPSConnection object at 0x11097c160>"

Another easy way to recreate is passing in an invalid host. We get back the message
"Error performing CMCI request: <urllib3.connection.HTTPSConnection object at 0x11097c160>"

I think that is probably a bug.  That's just with a hostname that doesn't exist?

I think that is probably a bug.  That's just with a hostname that doesn't exist?

ah yep, actually nothing to do with CMCI, so that error needs surfacing separately. Will raise a separate issue for it

ah yep, actually nothing to do with CMCI, so that error needs surfacing separately. Will raise a separate issue for it

The cmci_create_bundle_failure integration test will need its error message updating when this is complete

The cmci_create_bundle_failure integration test will need its error message updating when this is complete

@Tom-Latham has fixed this with one of his recent PRs


segfault: ws.send( SharedArrayBuffer )

Hello,
When trying to pass a raw SharedArrayBuffer to ws.send() I get a segfault. I see the API doesn't support this exact class. To work around the issue I wrap the SharedArrayBuffer using new Uint8Array().
I'm not sure what the exact ramifications are in the C code with regard to accepting a SharedArrayBuffer (directly or in disguise). Hoping you can clarify the API and either accept the raw SharedArrayBuffer (like you do the ArrayBuffer), or if this could lead to some really bad issues in the C code, don't accept a typed array backed by a SharedArrayBuffer at all.
I also noticed the segfault error message doesn't convey the issue. I saw you spent some time updating error messages and type checking at some point. Thought this issue would help on that front as well.
Either way, clarification would be appreciated.
Thanks again for the awesome work!
uv loop at [0x7000061d7af8] has open handles:
[0x105546560] poll (active)
	Close callback: 0x7000ffffffff
	Data: 0x0
[0x1053d0550] poll (active)
	Close callback: 0x654d646576696501
	Data: 0x0
uv loop at [0x7000061d7af8] has 2 open handles in total
/Users/tc.ferguson/.nvm/versions/node/v14.16.0/bin/node[69056]: ../src/debug_utils.cc:322:void node::CheckedUvLoopClose(uv_loop_t *): Assertion `0 && "uv_loop_close() while having open handles"' failed.
 1: 0x1012e4da5 node::Abort() (.cold.1) [/Users/tc.ferguson/.nvm/versions/node/v14.16.0/bin/node]
 2: 0x1000a6239 node::Abort() [/Users/tc.ferguson/.nvm/versions/node/v14.16.0/bin/node]
 3: 0x1000a60a1 node::Assert(node::AssertionInfo const&) [/Users/tc.ferguson/.nvm/versions/node/v14.16.0/bin/node]
 4: 0x100030e8e node::CheckedUvLoopClose(uv_loop_s*) [/Users/tc.ferguson/.nvm/versions/node/v14.16.0/bin/node]
 5: 0x1001459f6 node::worker::WorkerThreadData::~WorkerThreadData() [/Users/tc.ferguson/.nvm/versions/node/v14.16.0/bin/node]
 6: 0x100142351 node::worker::Worker::Run() [/Users/tc.ferguson/.nvm/versions/node/v14.16.0/bin/node]
 7: 0x100145b7f node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/tc.ferguson/.nvm/versions/node/v14.16.0/bin/node]
 8: 0x7fff2037c950 _pthread_start [/usr/lib/system/libsystem_pthread.dylib]
 9: 0x7fff2037847b thread_start [/usr/lib/system/libsystem_pthread.dylib]

Process finished with exit code 134 (interrupted by signal 6: SIGABRT)

This is not a segfault it is an assertion failure in libuv. That's a huge difference.

uWS.App().listen(new SharedArrayBuffer(1024), () => {})
Uncaught 'Text and data can only be passed by String, ArrayBuffer or TypedArray.'

It works like it should, you are simply not handling exceptions properly

I was going to mention this earlier but the segfault in this issue is caused by the same thing as this other issue https://github.com/uNetworking/uWebSockets.js/issues/465 where an uncaught JS error causes the worker thread to exit, and uWS still has uv loop handlers open. But the underlying JS error Text and data can only be passed by String, ArrayBuffer or TypedArray looks like can be fixed by updating this uWS.js file Utilities.h and add this type check: isSharedArrayBuffer(value)

Perfect. I really appreciate the guidance. It is exactly what I needed.

I see this isAnyArrayBuffer util checks for both, possibly just need to replace that 1 line


rpi_camera doesn't refresh image

Home Assistant release (hass --version): 0.34.5
Trying to use rpi_camera component, no image appears.
Looking at the code, I don't see anything that refresh the image.
The image is supposed to be generated on HA start (and it doesn't work for me) and after the component simply reload the same image again and again

Can you work with raspistill from the command-line?

Looking at the code, I don't see anything that refresh the image.

Check the base class.

raspistill is working perfect.
for the refresh I didn't so the timelapse argument, my mistake.
The problem was the unwritable path
I change a little rpi_camera.py to avoid this,
I replaced :
CONF_FILE_PATH: config.get(CONF_FILE_PATH,
                                       os.path.join(os.path.dirname(__file__),
                                                    'image.jpg'))

by
CONF_FILE_PATH: config.get(CONF_FILE_PATH,hass.config.path('rpi_camera.jpg'))

Closing, please feel free to reopen if this is still an issue.


chore: updating link to newer viz plugin blog post

SUMMARY

Updating to the newer link, which is more relevant for the current monorepo situation
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@villebro I just noticed this link... but it might be worth a look to see if there are more things worth updating in contributing now that we're (finally) a monorepo


Why SRE? blog post

I've followed the steps from https://github.com/operate-first/blog/pull/5/files as much as I could (some of them have TBD placeholders, so I skipped them).
I'm opening this as a draft PR as there's 1 section that is awaiting some accuracy checks.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign tumido after the PR has been reviewed.
You can assign the PR to them by writing /assign @tumido in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test all

@david-martin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

aicoe-ci/prow/pre-commit
5629d98238439a953f0530362e0fdda32cb51c26
link
true
/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I think this came out really well.  Thanks @david-martin and those leaders who were interviewed!

Thanks @schwesig
Just waiting on this comment thread to resolve https://github.com/operate-first/blog/pull/8#discussion_r882542623

New changes are detected. LGTM label has been removed.

@schwesig @jeremyeder OK, I think this is ready to land.
The TOIL link gets you to the SRE Maturity page without an anchor for the moment. That anchor should start working once a separate PR to the sre repo lands.

@david-martin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

aicoe-ci/prow/pre-commit
e2a3aae9a0a1e03265f89eb5a82822188b35bf60
link
true
/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@david-martin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

aicoe-ci/prow/pre-commit
76b0bb86cce410926c060dd60ce528a99ef33c8c
link
true
/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

Read through the whole thing, found some minor "wording" issues while at it. Otherwise I'm +1 on publishing this.

@david-martin the blog is not part of the main website. Can you move your PR to https://github.com/operate-first/operate-first.github.io ?

closing, because I'll archive this repo now


Regressions for MS MARCO Passage Task

@rodrigonogueira4 has written documentation on how to run MS MARCO passage, but we also need an addition to our regression suite. This will allow automated test.
I'll work on this.

Resolved by #692


docs(cli): Add a long description for file render

The existing description for deck file render doesn't currently provide any detail on what the command does or how to use it.
I was trying to test it out and couldn't even figure out how it was supposed to work, since there's no input file flag or example.
Found the info I needed on Slack here, and based the update on that: https://kongstrong.slack.com/archives/C04349E4KRC/p1690921140291889
❗ I did run into one potential issue while testing: this command doesn't warn you when overwriting existing files, like deck dump or others do. Is that intentional?

cc. @zekth

@zekth iirc this command also renders the files, as they would be synced to the control plane (kong or Konnect), such that it will also do substitutions etc. That is currently not in the description, should it be? including maybe a warning that secrets might be in the rendered file?

currently render use mocks for values, so secrets won't be rendered.
ref:
https://github.com/Kong/deck/blob/20ef81eb32b3de4023ea815d3db02dabf722fa02/file/reader.go#L36
https://github.com/Kong/deck/blob/20ef81eb32b3de4023ea815d3db02dabf722fa02/cmd/file_render.go#L24

@lena-larionova @zekth can we get this updated with the one suggestion (or something similar) and get it merged?

this command also renders the files, as they would be synced to the control plane (kong or Konnect), such that it will also do substitutions etc.

How's this @Tieske @zekth :
Short description: "Combines multiple complete configuration files and renders them as one Kong declarative config file."
Then some questions about the rest:

currently render use mocks for values, so secrets won't be rendered.

Does this mean the rendered file isn't in a ready state for syncing to a control plane, as the user has to replace mocked values with their own? Or am I misunderstanding something.

such that it will also do substitutions etc.  That is currently not in the description, should it be?

What should be said about substitutions? What's the etc part? Is that something we should list out? What exactly should we add to the long description here?

currently render use mocks for values, so secrets won't be rendered.

Does this mean the rendered file isn't in a ready state for syncing to a control plane, as the user has to replace mocked values with their own? Or am I misunderstanding something.

No, the goal is to validate local, so users would not edit manually, but if successful do an actual sync with actual values (not mocked ones).
Deck does;

grab files
combine them
render variables and "other magic"
sync to CP

especially step 3 & 4 were a single operation, without an option to inspect the output of step 3. The new render command allows a user to execute the same steps, but without the sync, so they can validate locally. (otherwise the user would need a running Kong system to test the sync against)

such that it will also do substitutions etc.  That is currently not in the description, should it be?

What should be said about substitutions? What's the etc part? Is that something we should list out? What exactly should we add to the long description here?

Above I named it "other magic" because I do not know exactly what deck logic is executed here. Probably @GGabriele knows. If there is any additional logic, and if so, what it exactly is.

I think my suggestion above covers enough of the use case here to apply it and merge this down

@zekth @Tieske Added Rick's suggestion, how does that look?
Also added the term "render" back into the short description. That makes the description a bit long - is there a character limit I need to be aware of?

Codecov Report
Patch coverage has no change and project coverage change: -0.05% :warning:

Comparison is base (6336929) 33.78% compared to head (2e2a096) 33.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
- Coverage   33.78%   33.74%   -0.05%
==========================================
  Files         101      101
  Lines       12360    12375      +15
==========================================
  Hits         4176     4176
- Misses       7775     7790      +15
  Partials      409      409

Files Changed
Coverage Δ

cmd/file_render.go
0.00% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix: delete deprecated vela dashboard in e2e setup

What this PR does / why we need it:
delete deprecated vela dashboard in e2e setup
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
/cc @chivalryq

ref: #2341


FBX with embedded media missing images on export

I've exported a model from Maya LT with embedded media. The file imports into Blender with the texture. When I export a glTF the images are missing unless I check on "embed images". I sort of understand the logic behind this, but I would prefer if the textures were written out next to the glTF when "embed images" is disabled".
Here is a sample FBX:
https://storage.googleapis.com/blocker-gltf-test/GenericCameraEmbedded/GenericCameraEmbedded.fbx

Actually, its looking like the issue is not in this library. When the FBX is loaded in with embedded media the material shows up a pink. If I select the model the texture pops in. I can then export as a glTF as I expect.
So it seems something is going on with the texture loading.


Automator: update<EMAIL_ADDRESS>dependency in<EMAIL_ADDRESS>

Generated by Automator - 2023-10-07T01:28:26+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio_release-1.19
37ba46a08e3e5ebed37a9b54f056e2e94fe4a17a
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Create protoype Ecosystem Function calculation for Carbon Stock

Gen - build the list of calculations with defined input response no. (in Code). Store in inst. as .r

Completed cs and ws. Some common patterns in functions, but not all questions have the same calculation. A few things to note

need to address the "" rather than NA values for calculations
build standard function for max of weighted values


Python module install path wrong on MinGW

MinGW (at least the MSYS2 one) Python is a bit special and also uses the regular Unix location, so the condition should probably be if(WIN32 AND NOT MINGW).
Even better the block could be replaced by something that figures out the location form Python_SITEARCH (which seems to be absolute, just need to extract the relative part).

Is this still an issue ?


Assisted Keys: Vault Creation Check err

Task Description
@cakesoft-utkarsh has been able to add both SS and IKS to a 3-of-4 Vault which should have been prevented by the standard vault checks for Assisted Keys.

RCA leads to: https://github.com/bithyve/bitcoin-keeper/issues/4616


fix(NgTemplateOutlet): replace deprecated ngOutletContext with ngTemplateOutletContext

via: https://github.com/angular/angular/pull/18780
fixing example/cli & example/cli2 is needed.

any news on when this PR will be made available??

Hi,
latest version supports this. Thanks for the contribution


Not able to use with proxy

Before submitting your bug report

[ ] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[ ] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: Windows 10
- Continue: v0.8.24
- IDE: VSCode

Description
Unable to use continue on vscode with proxy
To reproduce
No response
Log output
request to https://proxy-server-green-l6vsfbzhba-uw.a.run.app/stream_chat failed, reason: self signed certificate in certificate chain

POST https://us.i.posthog.com/e/?retry_count=1&ip=1&_=1713432561822&ver=1.116.6&compression=base64 net::ERR_CERT_AUTHORITY_INVALID
[Extension Host] FetchError: request to https://proxy-server-green-l6vsfbzhba-uw.a.run.app/stream_chat failed, reason: self signed certificate in certificate chain
	at ClientRequest.<anonymous> (c:\Users\a0e72199\.vscode\extensions\continue.continue-0.8.24-win32-x64\out\extension.js:25975:14)
	at ClientRequest.emit (node:events:529:35)
	at ClientRequest.emit (node:domain:489:12)
	at TLSSocket.socketErrorListener (node:_http_client:501:9)
	at TLSSocket.emit (node:events:517:28)
	at TLSSocket.emit (node:domain:489:12)
	at emitErrorNT (node:internal/streams/destroy:151:8)
	at emitErrorCloseNT (node:internal/streams/destroy:116:3)
	at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

@sestinj is it also possible to configure a no_proxy variable?

@ilyanoskov We don't have this today, but to make sure I understand what you mean:
You would set requestOptions.proxy to the proxy that you want most requests to go through, and also requestOptions.noProxy with a list of host names that you don't want the proxy to be used for?

@sestinj this is a feature that we would also like to see implemented. Your understanding is correct.

@nmcostello Here's a first pass at the feature: https://github.com/continuedev/continue/commit/e7f1f43fddc81034a046c0bbde5d963b53282e17
I'll release it later today in pre-release, but let me know if there's anything else that you would need

Awesome! I'll check it out in the pre-release. This should be what's needed.

I have the same request. I set the config.json like this. But it doesn't work at version of 0.8.40. Looking forward to your new release.
{
"model": "gpt-4o",
"title": "GPT-4o",
"systemMessage": "You are an expert software developer. You give helpful and concise responses.",
"apiKey": "my-api-key",
"completionOptions": {},
"provider": "openai",
"requestOptions":{
"proxy": "socks5h://<IP_ADDRESS>:7890"
}
}

Just pushed 0.9.154 so it should be on the store in a matter of 20 minutes


add Awesome Competitive Programming

This is a curated list of awesome competitive programming resources which covered a wide variety of aspects. It's aimed to be a useful list for all.
Competitive Programming - Wikipedia
I do realize there's a list under a similar name (Competitive Coding).
However, I believe competitive programming isn't just about coding (think Linear programming - Wikipedia for example). On top of that, I believe that there's more than just knowledge. It's also about the community that revolves around it.
In addition, I do not think it's quite possible to cover everything awesome with a one-article-link layout. There are way more sites with awesome resources.
I've been in the competitive programming scene for more than 10 years, and have also been digging good information for roughly the same time. I sincerely feel that my list would indeed be able to connect people to information.
This list I created also receives positive feedbacks.
An awesome list for competitive programming! - Codeforces
Current entry (Competitive Coding): awesome-competitive-coding - Codeforces, Topic wise Coding Resources - Codeforces

First of all, I'm not really thrilled with the content in awesome-competitive-coding.
Second of all, words programming and coding are considered to be synonyms by a huge chunk of the population and I don't see the reason why we should make any difference between these two words.
Third of all, I absolutely do not see any point in having both of these lists here. We should definitely decide on one of them.

Now, in my own opinion, I do think that your list is better suited to be included here, however, I don't think you played fair by telling your concerns here instead of first reporting them in the awesome-competitive-coding and at least trying to expand that list before you've decided to create your own version of a similar thing. I believe that you should have at least tried to make an agreement with @hkirat.

He actually reached out to me when I was making my list (through Codeforces PMs).
I responded nicely and expressed my concern for the fact our contents are organized very differently. An initial agreement was reached 2 weeks ago. We agreed to add referral links to our repos (ie. He adds one to mine, and I add one to his) - which he didn't comply.
Here is the link to the screenshot of our conversation.

Hi.
I am the other guy if you would say like that. I also have a list on this with my own ideas.
Honestly, these two lists(by @lnishan and @hkirat ) actually cover different sides of competitive programming, and in my opinion they are both awesome enough to be added into this list.
Competitive programming is a big subject and the lists actually did provided different details.

Well if you go through the conversation properly I mentioned that both the repos would do better together
But @lnishan turned the conversation to the direction of separation and adding referral links.
I am still up for a merge of both these repos.
There is no point of awesome-competitive-coding and awesome-competitive-programming
And @lnishan you did not approach me before making the repo it was only after you made it that I got in touch with you for merging the two

@sindresorhus I agree with you.
But the situation here is that the two lists are quite different in details.
If you take a further look, you'll see that @hkirat provides info on each single subject while @lnishan only takes broader view into concern.

I'd rather not going into the details.
I said adding links for a start because I think it takes time for a real collaboration as the contents are vastly different. You didn't even follow our initial agreement. How would I expect you to do more?
The more serious part. You said you're still up for a merge, but I do not see any activity on your repo. If you bother looking through literally anything on my knowledge section, you'll notice you have so many  more resources to add. I can name lots of topics you didn't managed to cover: bipartite graphs, planar graphs, matchings, linear programming, strongly/biconnected components. You also have many links pointing to the same website with simply a different keyword search.
But the real point I'm making here is, it's just not possible to cover it all. Let's also take awesome-algorithms, awesome-datascience for example (as these 2 are closely related to competitive programming). None of them categorize their contents by methods, because there are simply  too many.  Now it's true that competitive programming covers only a portion of them, but the same applies.

I am no one to force this merger on you and you are no one to question the activity of my repo @lnishan .
If you wan't to continue with different repositories it is fine by me.But don't put forward futile points to make it look that we actually do need two repositories.
The whole point of open source is collaboration. The final call is yours.
And on weather or not this should be added to the awesome listing, I leave the decision with @sindresorhus

@hkirat , Don't get me wrong. From the very beginning, I have always been willing to collaborate.
This is also one of my first attempts at contributing to the open source community, so I do try to be as careful and as cooperative as possible.
One of the reasons that prompted me to work on this new list is that: there is already a good amount of information available on the Internet. Before @hkirat 's list, there are other awesome curated lists already (See my Knowledge and Open Courses section). All of these are trying to cover the knowledge required in this scene.
Oftentimes I would feel that there's more to know (Some sites didn't teach something while some others do) or perhaps Site A explains something better than Site B (not to mention this is personal preference). Therefore, there really is a need for a list to collect all the awesome resources.
I'm not sure what your aim is, but to really see what I mean, you can consider reading problems from regions around the world (ACM-ICPC). Europe in general lays emphasis more on mathematical foundations and thinking, whereas China focuses more on advanced data structures and algorithms. In the end, not even a website like GeeksforGeeks can cover all the knowledge necessary in the competitive programming scene.
I have been in the competitive programming scene for more than 10 years and have accumulated quite a few years of teaching experience (also me always being the team captain).  One without guidance would wander around not knowing where to start. In this case, it would probably be better to include easier contents. However, with the case of a reasonably seasoned person, he/she might find the list common sense. There's a seemingly impossible imbalance (if you will) if the aim is to have a list for the general public.
One major flaw I just spotted, you list flow as the third item, and even put graph (DFS, BFS) beneath. Usually maximum flow and Max-flow min-cut theorem is lectured in the very end of an algorithm course because it is not easy.

It is alphabetically sorted @lnishan :)

Okay, then this would be an issue depending on what you're aiming for as far as I'm concerned.
It doesn't make much sense unless we're aiming for a database/archive. Also, there are data structures with multiple names (eg. Fenwick tree is also known as Binary indexed tree). There are also extensions such as Persistent segment tree. It would make much more sense to at least keep similar topics together.

They are sorted so that people can easily find the topics they wish to study upon
It is a common practice followed by a lot of people working on awesome listings :)

I would argue that's not the case.
It wouldn't make any difference with a quick Ctrl + F (Command + F in OSX) in the browser. Besides, you have a Table of Contents just for that.

Create an issue...Let's discuss it over there :)

Following this direction, @hkirat 's list would probably turn into an organized version of this. It would probably not be a list to get people started.
My honest opinion (no offense): There are still many other issues (eg. casings, wordings, inaccurate/inadequate descriptions, insufficient resources to support ... etc.) left to point out. I would suggest @hkirat to do a bit more research into the scene outside his nation first. As of now, there are at least twice as many contents needed to mentioned. A conservative estimate would be months. I frankly do not have the time to do all of this. It would be kind of like creating another list ...

Landed this in favor of @lnishan's list (sorry!). As a totally objective person on this topic, this list is just more approachable, comprehensive and better structured.


Logo Design issue#1

Logo design
issue number 1.
I've added the logo designs in the resources folder.

@harshita2319  please squash your commits, it should be 1 commit only, refer to README.md file


cadets can roll antag

About the PR
Added fun!
Why / Balance

Technical details

Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog
:cl:

add: Added fun!

it took me longer to write the info about this than it did to actually make it

Summary by CodeRabbit

New Features

The Security Cadet role can now participate as an antagonist.

Ahelp Crying
Rulemaxxing
Metamaxxing
And the thing that counter this PR is
Mindshilding from start of the game, because they're security -> so they cant become antag if not roundstart
In general it seems to be a very funny addition for cadets being silly and shooting random people that is what goob needs

Wdym? They are already an antag :godmode:

Security is only department that should be protected from being antag.

bro no

Cadets are already antagonists.
this is a joke


Performance of is operator

I have read Gavin's post about observer/observable pattern in Ceylon. It is very nice approach! But... I have performed some exercises with and found some performance issues.
Consider four cases:

function with knowing type, like Anything(Integer)
narrowing function Anything(Nothing) with is Anything(Integer)
narrowing interface - interface Foo<in T> with is Foo<Integer>
interface with knowing parameter type - Foo<Integer>
see example code below

Results:

case 1 is the fastest
case 4 is close to case 1
case 3 is about 10 times slower than case 4
and case 2 is about 100 times slower than case 1

Don't know but may be it is possible to improve this? My humble opinion is if narrowing function and narrowing interface show close results, it would be perfect (at the moment it looks like the difference is about 10 times).
code:
void runInteger(void doIt(Integer int), Integer i) {
	doIt(i);
}

void runIntegerNothing(Anything(Nothing) doIt, Integer i) {
	if (is Anything(Integer) ddd = doIt) { ddd(i); }
}

interface Foo<in Body> {
	shared formal void foo(Body body);
}

class FooImpl(void doIt(Integer int)) satisfies Foo<Integer> {
	shared actual void foo(Integer body) => doIt(body);
}

void runIntegerInterface(Foo<Integer> int, Integer i) {
	int.foo(i);
}

void runNothingInterface(Foo<Nothing> int, Integer i) {
	if (is Foo<Integer> ddd = int) {ddd.foo(i);}
}

shared void ttt() {

	for (i in 0 : 1000000) {}

	variable Integer start = system.nanoseconds;
	for (i in 0 : 1000000) {
		runInteger((Integer n) {Integer k = n+1;}, i);
	}
	Float intTotal = (system.nanoseconds - start) / 1000000.0;

	start = system.nanoseconds;
	for (i in 0 : 1000000) {
		runIntegerNothing((Integer n) {Integer k = n+1;}, i);
	}
	Float nothingTotal = (system.nanoseconds - start) / 1000000.0;

	start = system.nanoseconds;
	for (i in 0 : 1000000) {
		runIntegerInterface(FooImpl((Integer n) {Integer k = n+1;}), i);
	}
	Float intInterfaceTotal = (system.nanoseconds - start) / 1000000.0;

	start = system.nanoseconds;
	for (i in 0 : 1000000) {
		runNothingInterface(FooImpl((Integer n) {Integer k = n+1;}), i);
	}
	Float nothingInterfaceTotal = (system.nanoseconds - start) / 1000000.0;

	print("direct fuction ``intTotal``, narrow function ``nothingTotal``,
	       direct interface ``intInterfaceTotal``, narrow interface ``nothingInterfaceTotal``");

}

@LisiLisenok if you want to experiment with optimizations, you need to look at com.redhat.ceylon.compiler.java.runtime.model.TypeDescriptor.is(). Note that I think I already got most of the low-hanging fruit, but perhaps I missed some cases.

Well, I have performed some testings. See test function on gist. Basically, it calculates time of narrowing function and narrowing class with is.
Baseline (Ceylon 1.2.2).
mean time / standard deviation:

narrow function 17.4 / 3.8
narrow class 8.3 / 1.9

Step 1.
memoizing hash code (like it is in com.redhat.ceylon.model.typechecker.model.Type):

com.redhat.ceylon.model.typechecker.model.Declaration
com.redhat.ceylon.compiler.java.runtime.model.TypeDescriptor.Class

mean time / standard deviation:

narrow function 11.7 / 4.2
narrow class 6.3 / 1.5

About 30% improvement
Step 2.
com.redhat.ceylon.model.typechecker.model.Type.getSupertype():
It looks like
if (cache.containsKey(this, dec)) {
    return cache.get(this, dec);
 }

can be replaced with
Type ret = cache.get(this, dec);
if (ret!=null) {return ret;}

mean / standard deviation

narrow function 9.9 / 1.7
narrow class 5.6 / 0.7

Total about 40% improvement

oh, very nice!
send us a PR?

Type ret = cache.get(this, dec);
if (ret!=null) {return ret;}

No that's wrong, since we do cache null entries.

Of course it's possible to use a hardcoded Type instance to represent null, that'd still save us hashCode being called twice by using only get and comparing pointers.

But 40% improvement seens like peanuts when we're trying to solve a factor 100 difference.

@FroMage ok, replacing with cache.get(...) is canceled.
We don't try to solve a factor of 100. This factor is like factor between if(true) and if(is ...). How much it can be? But improving operator is performance on 30% is possible by memoizing hash code. Why not to implement this?
@gavinking
Well, I will send PR. Should hash codes of other TypeDescriptor inner classes to be memoized as well?

No we can replace the combo containsKey/get with a single get (since it saves on calling hashCode), but only if we add a null-like marker to keep caching null supertypes.
I'm not complaining, 40% is great, but you mentioned a factor 100 difference so if we want to improve we need more than a factor 1.4 improvement :(

That's some misundersdanding. I have to explain that factor.

add a null-like marker to keep caching null supertypes

I am not so familar with Ceylon model details... Do you mean add the marker to the Type? Something like
if(isSupertypeNull) {
    return null;
}
else {
    Type ret = cache.get(this, dec);
    if (ret!=null) {return ret;}
}
...
Type superType;
if (isSimpleSupertypeLookup(dec)) {
    //fast!
    if (getDeclaration().inherits(dec)) {
        superType = dec.getType();
        isSupertypeNull = false;
    }
    else {
       superType = null;
       isSupertypeNull = true;
    }
}
...

No I mean:
private static final Type NullType = new Type();

...
            Type ret = return cache.get(this, dec);
            if(ret != null) return ret == NullType ? null : ret;
...
            cache.put(this, dec, superType == null ? NullType : superType);

@FroMage  well, understood, thank you

This has been merged, so closing. If you think we should reopen, don't hesitate.

Thanks @LisiLisenok!


pod install 报错啊  版本 <IP_ADDRESS>

podfile 如下
source 'git@github.com:CocoaPods/Specs.git'
target 'weexdemo' do
platform :ios, '7.0'
pod 'WeexSDK', '<IP_ADDRESS>'
end
pod install 报错  错误如下
[!] Unable to satisfy the following requirements:

WeexSDK (= <IP_ADDRESS>) required by Podfile

None of your spec sources contain a spec satisfying the dependency: WeexSDK (= <IP_ADDRESS>).
You have either:

out-of-date source repos which you can update with pod repo update.
mistyped the name or version.
not added the source repo that hosts the Podspec to your Podfile.

Note: as of CocoaPods 1.0, pod repo update does not happen on pod install by default.

hi @houtou118
follow the instruction bellow , just try pod repo update  before pod install
You have either:

out-of-date source repos which you can update with pod repo update.
mistyped the name or version.
not added the source repo that hosts the Podspec to your Podfile.

or you can try pod update directly


Undefined math constants breaks windows build

Windows 10, VS2015 x64 Native Tools
scons platform=windows
I get errors about math constants (like M_PI, M_SQRT2) in many files in servers\audio\effects.
The build works if I manually define these constants in core\typedefs.h
I supposed it's a compiler specific issue.
https://msdn.microsoft.com/en-us/library/4hwaceh6.aspx

Math Constants are not defined in Standard C/C++. To use them, you must first define _USE_MATH_DEFINES and then include cmath or math.h.

Duplicate of #7608


aggAvg function error if null/missing values

If the data for a column that's using 'avg' aggregation has any missing values, an error is thrown on line 22883 of ag-grid-enterprise:
else if (typeof currentItem.value === 'number' && typeof currentItem.count === 'number') {
this is because currentItem is undefined.
https://jsfiddle.net/andytaft/n168v3hy/2/

your plunker threw ag-grid-enterprise.js?ignore=notused22:23173 Uncaught TypeError: Cannot read property 'value' of null
anyway, found it. fixed. will be in next release.


Request doesnt pass query parameters

This is my web api method
 /// <summary>
        /// test
        /// </summary>
        /// <param name="accepted">query param</param>
        /// <param name="page"></param>
        /// <param name="status"></param>
        /// <param name="size"></param>
        /// <returns></returns>
        [HttpGet]
        [SwaggerResponse(System.Net.HttpStatusCode.OK, Type = typeof(PaginatedApiResponse<IEnumerable<Report>>))]

        public PaginatedApiResponse<IEnumerable<Report>> Get([FromUri]bool accepted, [FromUri]int page, [FromUri]string status, [FromUri]int size)
        {
            return ReportsService.GetReportsByStatus(
                status,
                accepted,
                page,
                size);
        }

This is how it looks in swagger

If I remove [FromUri] he says that parameters are modelbinding type why ??

Which version of SB are you using?

Closing due to inactivity


Update aws-java-sdk-dynamodb to 1.12.238

Updates com.amazonaws:aws-java-sdk-dynamodb from 1.11.1034 to 1.12.238.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-dynamodb" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #303.


JWT-FL (Independent Publisher)

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[ ✅] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[ ✅] I attest that the connector works and I verified by deploying and testing all the operations.
[ ✅] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[ ✅] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[ ✅] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[ ✅] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[✅ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ✅] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ✅] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ✅] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

2 Unique Operations

Paconn Validation

@officialFlutterDeveloper I did not mean to instigate from my previous comment that you should host your own service to create JWT tokens. As you do not own either the website or privacy policy listed in Swagger file, I am going to insist that you close this PR.


feat: support ALTER DATABASE/SCHEMA/TABLE/... xxx OWNER TO xxx syntax

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Refer to https://github.com/risingwavelabs/risingwave/issues/11162
Progress:

[x] ALTER TABLE
[x] ALTER (MATERIALIZED) VIEW
[x] ALTER SINK/SOURCE
[ ] ALTER DATABASE/SCHEMA
[ ] Tests

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Any updates? 👀

Any updates? 👀

Now we support alter database/schema xxx owner to.
However, I found a bug when doing a quick test as follows:
create database xxx;
create user test;
alter database xxx owner to test;
drop database xxx;

And the result is:
dev=> create database xxx;
CREATE_DATABASE
dev=> create user test;
CREATE_USER
dev=> alter database xxx owner to test;
ALTER_DATABASE
dev=> drop database xxx;
ERROR:  QueryError: internal error: transport error

Next I will look into the bug.


currentQueue is null in drainQueue

I'm getting an error in Firefox where currentQueue is null inside of drainQueue in babel-core/browser.js.  From stepping through the code, there appears to be a race condition between two instances of drainQueue running at once.  This is what is happening:

drainQueue starts the first time: queueIndex is -1, queue has one item in it
draining is set to true
setTimeout(cleanUpNextTick) called
currentQueue is set to queue, queue is set to an empty array
queueIndex compared to length of queue and then incremented
currentQueue[queueIndex].run() called
At this point, control goes to the cleanUpNextTick scheduled by drainQueue
draining set to false
cleanUpNextTick sets queue to currentQueue and calls drainQueue, starting a second instance of drainQueue
currentQueue set to a queue (which is just what it was before
Because queueIndex is already 1, no new functions are run
queueIndex set to -1
currentQueue is set to null
Second drainQueue completes
First drainQueue regains control
queueIndex is -1, because of second drainQueue
queueIndex is less than len, so currentQueue[queueIndex].run() is called
Exception because currentQueue is null

I've only observed this problem in Firefox, and usually only under very specific conditions (usually only the first time the page is loaded).  We think this is causing problems for us downstream with Babel, Reflux, and React, so a fix would be greatly appreciated!

the only way this could come up, would be if we were in an environment which redefined setTimeout in terms of process.nextTick which meant that the clean up function we thought would only run if the loop exited prematurely actually ran during the look because setTimeout was actually an alias for process.nextTick.
do Babel, Reflux, or React happen to set their own versions of setTimeout?  if So why doesn't this usage cause a problem, the only difference is that it has the 0 explicitly stated, I wonder if changing this line to be
var timeout = setTimeout(cleanUpNextTick, 0);

or even
var timeout = setTimeout(cleanUpNextTick, 4);

(which should be equivalent in a browser) would fix it.

I'm seeing a similar problem in an environment that I'm putting together (ottoext) on top of the otto JavaScript interpreter. That interpreter, as with many others, doesn't contain an event loop. The way that I've implemented setTimeout and friends means that setTimeout(fn) is exactly the same as process.nextTick(fn).
There's a crash in cleanUpNextTick that has its roots in the same place as this one, which can also be papered over by changing setTimeout(cleanUpNextTick) to setTimeout(cleanUpNextTick, 5). Inside cleanUpNextTick, currentQueue can be null sometimes. I presume it's by the same mechanism as described above.
Perhaps a null check would be good in cleanUpNextTick as well? Either way, I'm going to find out what the correct behaviour is for setTimeout and make sure I implement that, but it could save future JavaScript environment tinkerers some time tracking down mysterious crashes.

Omitting the number from setTimeout should be equivalent to setTimeout(fun,
4)
On Sat, Oct 3, 2015, 11:41 PM Conrad Pankoff<EMAIL_ADDRESS>wrote:

I'm seeing a similar problem in an environment that I'm putting together (
ottoext http://fknsrs.biz/p/ottoext) on top of the otto
https://github.com/robertkrimen/otto JavaScript interpreter. That
interpreter, as with many others, doesn't contain an event loop. The way
that I've implemented setTimeout and friends means that setTimeout(fn) is
exactly the same as process.nextTick(fn).
There's a crash in cleanUpNextTick that has its roots in the same place
as this one, which can also be papered over by changing
setTimeout(cleanUpNextTick) to setTimeout(cleanUpNextTick, 5). Inside
cleanUpNextTick, currentQueue can be null sometimes. I presume it's by
the same mechanism as described above.
Perhaps a null check would be good in cleanUpNextTick as well? Either
way, I'm going to find out what the correct behaviour is for setTimeout
and make sure I implement that, but it could save future JavaScript
environment tinkerers some time tracking down mysterious crashes.
—
Reply to this email directly or view it on GitHub
https://github.com/defunctzombie/node-process/issues/49#issuecomment-145315304
.

Yep, that's the behaviour I ended up implementing. I still had very, very occasional crashes at the same point, but they were certainly less frequent. I ended up managing to avoid the problem entirely by implementing setImmediate on my own and telling webpack (which was pulling this in, indirectly) not to shim the process module.

If currentQueue is null in cleanUpNextTick that would likely be a seperate thing that would be worth opening it's own issue for. Off the top of my head it could be caused by clearTimeout not effectively removing the timeouts?


Reset password and verify email urls missing in keycloakify starter

I added two pages in keycloakify starter: login-reset-password and login-verify-email
In the first one I don't see any url where to submit the form to actually send the reset password email.
in the kcContext I only see this
type LoginResetPassword = Common & {
        pageId: "login-reset-password.ftl";
        realm: {
            loginWithEmailAllowed: boolean;
        };
        url: {
            loginResetCredentialsUrl: string;
        };
    };

but the logintResetCredentialsUrl is for showing the reset form
In the same way it would be useful to have the url to send the email to verify the registration after the registration has done (in the verify-email page) in order to say to the user to click to receive the email again if didn't receive it yet.

Hi @koo27,
The types definition are just here to provide a better devlopper experience, to give you an idea of what's supposed to be on the kcContext depending on the page you're on.
However it's Keycloak, not Keycloakify that decides what's available. Keycloakify just forward the all context to the frond blindely.
If you want to actually see what's there you can console.log(window.kcContext) in your browser console.
If you figure out that one of our type definition is lying or if there are some properties that aren't present in the type definition, please, PR are wellcomes :)

Looks like it's kcContext.urls.loginActions you are looking for isn't it?  https://github.com/keycloakify/keycloakify/blob/15aa114579c891d90900e9da28792c0d2bf53b59/src/login/pages/LoginResetPassword.tsx#L26

I already tried that one, but it seems to be the url for loggin in, isn't it?
Shouldn't it be different to ask for a password reset?

I tried again and it seems to work with this url. It sends the email and then redirects the user to the login page. I think the same happends with the update password page.
So I close this issue, thank you again


About SmartBCH NFT

Dear Sir
Can i ask some QA about NFT in term  of contracts. (SmartBCH)
i try to create NFT market place from your Git
when I buy NFT from someone who mint and list in market
it work fine, but all BCH was send to smart contract addr , don't send to seller
i think in the contract at buyitem function is a problem.
Or i just do something wrong

thank you for you help

This line https://github.com/zh/scaffold-eth/blob/minting/packages/hardhat/contracts/AwesomeAssets.sol#L63
(bool sent, bytes memory _data) = itemOwner.call{value: msg.value}("");

should send the payment to the item owner...
I have this application deployed to https://test-nfts.surge.sh/ . Try to create some NFT there and I'll try to buy. Let's see what will happen.

This line https://github.com/zh/scaffold-eth/blob/minting/packages/hardhat/contracts/AwesomeAssets.sol#L63
(bool sent, bytes memory _data) = itemOwner.call{value: msg.value}("");

should send the payment to the item owner... I have this application deployed to https://test-nfts.surge.sh/ . Try to create some NFT there and I'll try to buy. Let's see what will happen.

Thank you for your reply Sir
I Buy one from  https://test-nfts.surge.sh/  already
it send to smartcontract addr or your wallet ?

Looking on the Events screen the payment is indicated,

but the transaction is strange (choice testnet ) - https://www.smartscan.cash/transaction/0x94000f342c5693687d5680e84a5c63da19ba1c2d18cd5c06518e051ed5488d08 - the first two logs seems good - the token is transfered, but the last one, which should be the payment seems strange. Need to investigate more... Thanks for the report. If you find something feel free to comment or make PR.

Looking on the Events screen the payment is indicated,  but the transaction is strange (choice testnet ) - https://www.smartscan.cash/transaction/0x94000f342c5693687d5680e84a5c63da19ba1c2d18cd5c06518e051ed5488d08 - the first two logs seems good - the token is transfered, but the last one, which should be the payment seems strange. Need to investigate more... Thanks for the report. If you find something feel free to comment or make PR.

Thank you for your reply Bro,
Hope everything work fine soon

any update for this issue ?

I think I fixed the problem in commit# f9da6c76c6ed79fb56aaf8cafe26a57930dd3d71 - the transfer of token ownership was before sending funds, so basically the new owner was sending funds to himself. Please try again on http://test-nfts.surge.sh/

Issue resolved


Nit about the decorator of PortArgs.init_new

Trivial issues:

From both the definition and the usage of PortArgs.init_new(), it may be better to be decorated with staticmethod rather than classmethod.
Even for a classmethod, the convention is typically using cls instead of self.

Motivation

Modifications

Checklist

[ ] Format your code according to the Contributor Guide.
[ ] Add unit tests as outlined in the Contributor Guide.
[ ] Update documentation as needed, including docstrings or example tutorials.

Thanks @glen-amd. It is merged.


This svg from google fonts gets mis-rendered.

Expected Behaviour
Renders the svg with full color.
Actual Behaviour
Half of it is black.
Reproduce Scenario (including but not limited to)
Will attach test file.
Steps to Reproduce
Just run testCairo or testSkia to convert to png.
See also
https://gitlab.gnome.org/GNOME/librsvg/-/issues/997
Librsvg's rendering is worse.
Platform and Version
Latest git HEAD, Linux
Sample Code that illustrates the problem
Will upload test file. Just your testCairo and testSkia
Logs taken while reproducing problem

Here is the test file. Extracted from Google font's Nabla

Here is how Adobe svg native renders it, half black. (Should be all different shades of yellow/orange/red, just like it does above if you look at this issue on github with the attached svg rendered inline.


[feature request] Specify location of config file

E.g. git pr-train --config-file=~/.pr-train-BUG-1337.yml.
Use case: "I have multiple PR trains in flight, and want to manage them all without any ln -s shenanigans."

Hey Chris, you can have multliple trains in the .pr-train.yml
trains:
  train for feature 1:
    - tomas/feature-1/foo
    - tomas/feature-1/bar

  train for feature 2:
    - tomas/feature-2/foofoo
    - tomas/feature-2/barbar

Does that address your issue?


GM Panel: Add free note section

The GM panel should allow the GM to write down arbitrary notes.
We could reuse the UI in Info section.

started work on this - first version here: https://www.figma.com/file/BHLkTTiKO5iELu5Ww3o3LJ/The-Treacherous-Turn?node-id=5307%3A455&t=i6XJPVLgKd4o0YhP-4


fs= should not be required in assertion

re: https://github.com/gerardroche/sublime_color_scheme_unit/pull/13
It's necessary use specify fs, even if you scopes not bold or/and italic.
Example

Incorrect — ^ fg=yellow
correct — ^ fg=yellow fs=

Expected
Allow assertion ^ fg=yellow without the need to specify fs=

I'm unable to reproduce this.
All the following work for me. They need to be correct order fg, bg, fs, but can be specified individually or in pairs too.
def somefunc(param1='', param2=0):
# ^ fg=#66d9ef
# ^ bg=#272822
# ^ fs=italic
# ^ fg=#66d9ef bg=#272822 fs=italic
# ^ fg=#66d9ef bg=#272822
# ^ fg=#66d9ef fs=italic
# ^ bg=#272822 fs=italic
# ^ fg=#66d9ef fs=italic

Maybe there some other issue. Can show some examples of what your testing and your tests?

Sorry, now I also don't reproduce it :unamused: . But I just remember that getting this error. If I can reproduce, I reopen this issue.
Thanks.


expose api to get PeerInfo for given peer id to the native and wasm nodes

See https://node-rpc-docs.celestia.org/?version=v0.12.4#p2p, PeerInfo method.
We could add something like:
node.peer_info(id: PeerId) -> Option<PeerInfo>
This would allow to get all the webtransport addresses of connected peers like
const addrs = [];
for (peer_id in await node.connected_peers()) {
    let webtransport_addrs = node.peer_info(peer_id).addrs.filter(addr => addr.includes("certhash"));
    addrs.push(...webtransport_addrs);
}
console.log(addrs);

covered by #245


Update message blocks mini-player

OS:
Win10 x65
Issue Descriptions:
Update notification gets in mini-player and doesn't allow any interaction with it.

Steps to Reproduce:
Receive an update while UI's in mini-player form

Has been fixed in latest update


Remove Ship.io

Apparently, it was bad timing to add Ship.io the other day.
https://ship.io/ship-io-is-shutting-down/

Thanks!


SW-1537 Implement withdrawals POST, PUT endpoints

Add implementations for the withdrawals POST (create) and PUT (update) operations.
Because updating withdrawals causes accession-level information to change, make
the write operations return the entire accession rather than just the information
about the updated withdrawal. In practice, we expect clients will always want the
latest accession details after updating a withdrawal, so no point sending back a
useless response payload and forcing the client to GET the one it actually wants.
Move the endpoints under /api/v1/seedbank/accessions/{id} to make it less
surprising that they now return accession payloads.
The new endpoints currently only work for count-based accessions; support for
weight-based accessions will be added as part of a larger change to quantity
management.

Current dependencies on/for this PR:

main

PR #585   👈

This comment was auto-generated by Graphite.


Document New Relic PHP Agent as an incompatible extension due to ZTS

Thanks!

Nice to see you here around @RubenKruiswijk :)


intel-ocl: add web archive link since other links 404

Description of changes
Closes #166886

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/clinfo-cannot-find-intel-gpu/30731/2

I have downloaded https://web.archive.org/web/20190526190814/http://registrationcenter-download.intel.com/akdlm/irc_nas/11396/SRB5.0_linux64.zip and extract to find its date is 2017. Why not update it to latest 2023? https://aur.archlinux.org/packages/intel-cpu-runtime is a reference.

No one has updated it, Please submit a PR.

@kierdavis are you using this package anymore


[Tracking] HttpClient Dialers

Motivation: Select a specific NIC for certain outbound requests
https://github.com/dotnet/runtime/issues/28721

Will track the link directly in boards, it doesn't also need an issue here.


how to use Parcels in angular

Question
Hello, I have used the CLI single-spa to create a Parcel project since, according to the documentation, this type of microfront is recommended to be able to share UI components in different frameworks, in the CLI it shows the options of which language to use, I chose React; Now I want to use this Parcel in an Angular project, but I can't find examples of how to do it, do you have any demo of Angular Parcel?

@angular/core version: 9.1.0
single-spa-angular version: 4.0.1

We have not yet had the time to document Angular Parcels, and the issue is tracked on the documentation repo https://github.com/single-spa/single-spa.js.org/issues/199

Would that be possible to get access to the angular app that you use to test out the Parcel component? I'm trying to get it to work with a simple spa app without success:
<parcel *ngIf="!!spaSite" [config]="spaSite" [mountParcel]="mountParcel"> </parcel>

import { mountRootParcel} from "single-spa";
@Component({})
export class HomeComponent implements OnInit {
   mountParcel = mountRootParcel;
   spaSite;
   constructor(){}
   ngOnInit() {
    this.spaSite = window.System.import("spa-site");
    // also tried with
    // window.System.import("spa-site").then(mod => {
    //   this.spaSite = mod.default;
    // });
  }
}

PS : The "spa-site" is a spa application that works great when mounted with registerApplication()

@R0muald this coexisting-angular-microfrontends repo would likely be a good candidate to use.  You'll have to fork it but your changes might also be a good example to  contribute.

Thanks for the reply.
To do that, I would need to transform the root-html app into an angular app. I will also need to remove the spa-layout since the Parcel will be mounted and unmounted from the angular app that will load/unload those routes.
Is that a faire statement? Do you see a different way to explain the usage of Parcel?
Please let me know, so I can create the reference app and share it.

Parcels were implemented in https://github.com/single-spa/single-spa-angular/pull/122 by @ricardofct.
@ricardofct could you comment here with example usage? We need to add this to the documentation.

Hi,
I created a root-angular app that follows the root-html-file but with an angular routing instead of the single-spa-layout routing.
It's a basic angular app with lazy loading. The setup I have regarding to the spa micro-app:

navbar registered as an application (to insure that application and parcel can work together)
app1 loaded as parcel under /app1 route
app2 loaded as parcel under /app2 route

But I still have my issue: The app1 and app2 don't want to load in the parcel component and I'm not sure why. If someone wants to look at it that would be great!
My repo: https://github.com/R0muald/coexisting-angular-microfrontends
I can make a PR too if you want.

@R0muald I think you went the wrong direction with that. You do not have to implement the root-config with Angular in order to use Parcels, and using a framework in the root-config is something we actively discourage. A Parcel is "a chunk of functionality meant to be mounted manually by an application" to interoperate between frameworks by leveraging single-spa's lifecycles. An example would be to create and share an Angular component within a React application.

Yes, I figured that I was stretching the usage of Parcels.
The issue I want to solve with Parcel:

Have more control on when, where to load those micro-app without depending only on the route,
Have a framework at the root to provide dynamic loading of micro-app and better communication between them

Is there anything that stop an application to be loaded as a parcel?

Those are good questions. I'd recommend joining our Slack workspace to ask those questions because this issue is for tracking single-spa-angular Parcels documentation, and I'd rather not clutter it with tangential information.

Will update my fork to follow your recommendation

I see the docs don't exist yet, but is there an example repo out there anywhere?

The parcel component and module are not currently compatible with Angular 9+. I tried it locally just now.

https://stackoverflow.com/questions/60726180/angular-9-value-at-position-x-in-the-ngmodule-imports-is-not-a-reference

ah, ok. thank you for the quick response. may look into it if I have time

Also, here's a rough idea of how to use the component once it's successfully imported and installed:
import { mountRootParcel } from 'single-spa';

const parcelConfig = {
  async mount() {
    console.log('mounting!')
  },
  async unmount() {
    console.log('unmounting')
  }
}

// In angular template
<parcel [config]="parcelConfig" [mountParcel]="mountRootParcel" />

The parcel component has been fixed in v4.7.0. The release notes have a link to an example, and @arturovt is putting together a PR for the documentation soon:
https://github.com/single-spa/single-spa-angular/releases/tag/v4.7.0

Documentation is live at https://single-spa.js.org/docs/ecosystem-angular#parcels

Documentation is live at https://single-spa.js.org/docs/ecosystem-angular#parcels

Seriously???? It exemplifies Parcels via react! Wow guys. "Lets make an angular component but not document". Really nice. smh

@danielgchap your comment is not helpful. Single-spa is a community-owned project that operates via volunteer work and (minimal) donations. Since you're part of the community, perhaps you should take ownership of the documentation and submit an improvement, rather than criticizing the rest of the community you're part of?

@danielgchap your comment is not helpful. Single-spa is a community-owned project that operates via volunteer work and (minimal) donations. You received single-spa for free and do not have to use it if you do not want to. Since you're part of the community, perhaps you should take ownership of the documentation and submit an improvement, rather than criticizing the rest of the community you're part of?

As part of this community, maybe YOU should be more open to critique too.  Your angular docs point to react examples. Your vanilla parcel project doesn't work. My apologies to the community.   You

@danielgchap your comment is not helpful. Single-spa is a community-owned project that operates via volunteer work and (minimal) donations. You received single-spa for free and do not have to use it if you do not want to. Since you're part of the community, perhaps you should take ownership of the documentation and submit an improvement, rather than criticizing the rest of the community you're part of?

@joeldenning
YOUR comment is not helpful. Everything I said on the docs was true. The harshest word I used was 'garbage' in the slack chat.
As part of this community, maybe YOU should be more open to critique too.  If you're going to stand as an advocate, then be one. You apparently have time to combat me on provable issues, direct that to your docs instead. Your angular docs point to react examples. Your vanilla parcel project doesn't work. My truest apologies to the community.    Banned for truthful criticism?.. none of which was impolite, cussing or rude. There's some advice for 'free'.

 Lack of docs wasting dev hours? People literally created this in their spare time so you can use it for free. It's an open source project. If you want better docs you write them.

Thanks @awhitehouseWS. I'm going to lock this conversation to avoid it further devolving. The single-spa docs are by no means perfect, but the way to go about improving them is by offering your own time to submit pull requests, etc. Reporting issues with the documentation is also valid, but should be done in a respectful way that does not criticize the project, its maintainers, or its community.


Update packages

Not sure if we have control of this but installing today (6-Dec-2016) gave the following warnings:
npm WARN deprecated<EMAIL_ADDRESS>ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
npm WARN deprecated<EMAIL_ADDRESS>use uuid module instead
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.

It's an npm issue and package owners have no control over it unfortunately. Related:

https://github.com/npm/npm/issues/11628
https://github.com/npm/npm/issues/5253
https://github.com/npm/npm/issues/2040


Remove a Transaction

User Story
As a User
I want to delete a transaction
so that I can undo previous transaction
Description
A delete button will be added to the transactions.

AC

[ ] Remove the selected transaction from the shown list by clicking on the delete button

Tasks

[ ] create a new branch
[ ] create storybook
[ ] add new button to transactions
[ ] add onClick event for deleting transaction

Hey 👋
Looks good to me.
Just an idea: One thing you could add is some kind of confirmation dialog before deleting a transaction.
So the user doesn't delete unintentionally 🙂


chore: remove repetitive words

Description:

BREAKING CHANGE:

Related issue (if exists):

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Karma runner logs warning for public assets

The karma.conf.js currently proxies requests as follows: '/app/': '/base/dist/app/'.
However if you put an asset such as an image in the public directory, the asset is placed into the root of the dist directory when built. The result is that karma will log a warning each time the asset is requested:
19 04 2016 23:34:57.334:WARN [web-server]: 404: /image.png
Not sure if it's a valid solution, but changing the proxy to '/': '/base/dist/' allows requests to app to behave as normal, while including requests to assets in the root of dist, eliminating the warnings.

I'll put up a PR with your fix. If it horribly breaks everything, our tests should be able to show since they run ng test a whole lotta times.

Seems fine really, it's in!


Allows apps2 outside of root

Fix #257
I'm not a nginx expert. But this works on my dev env.

I tried this on my environment, but I can't get it to run.
My apps2 folder is at /apps2/
So I changed your root /srv/http/; to alias /apps2/;. I also tried root /;
Still get the error message and the css can't be load.
Why you choose the root location to /srv/http/?  :) Let me check.

@skjnldsv It still doesn't work for me. Works it with 12.0.3 or need I a special branch?

@hoellen I added the basic solution used from a basic install, I don't use docker.
@Wonderfall will need to take a look.

Thanks for working on this. I tried this solution but it doesn't work for me either. How is the nginx config going to solve the  "ResourceLocator can not find a web root" messages in nextcloud? I still receive the error messages in the log. However my browser does not show any urls that are not reachable. So I'm wondering if this is an issue that can be solved by reconfiguring the nginx or if this is something internally in the nextcloud server?

Nginx can't serve a file outside of the webroot, so it's more than a nextcloud issue! :)

Hi, this didn't solve the problem for me.


Package this properly so it can be reused in the CLI on the Core or Jupyter Kernel

This project should be separated so we have a folder lib with the API and the index.js as the binary for launching this. It should be highly configurable and embeddable on other projects.

I think this should be enough: https://github.com/metacall/polyglot-repl/commit/ecc31c3c40bd2a5cf5c81423295c92121d81f6b5


Resource filtering

Filtering across name , ns and type
Multi-word searching to via space

CC: @jasonmadigan

/hold

/unhold

fixed a issue with dark mode where a diff shade of gray was showing when there wasn't as many resources showing in the table

/lgtm