@types/node higher than 18.11.10 breaks import of storybook builder

Command
other
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
With @types/node 18.11.10 @angular-devkit/architect can correctly import storybook builder.
With a higher version, it fails with the error you can see below.
Minimal Reproduction
It's not actually that simple to create an environment with Storybook, I found it in a nx workspace.
Please try to create nx workspace and add Storybook (Cypress is not needed).
I still hope that you can find enough information from the error.
Exception or Error
Directory import<EMAIL_ADDRESS>is not supported resolving ES modules imported from<EMAIL_ADDRESS>
   Did you mean to import<EMAIL_ADDRESS>
Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import<EMAIL_ADDRESS>is not supported resolving ES modules imported from<EMAIL_ADDRESS>Did you mean to import<EMAIL_ADDRESS>    at new NodeError (node:internal/errors:393:5)
    at finalizeResolution (node:internal/modules/esm/resolve:253:17)
    at moduleResolve (node:internal/modules/esm/resolve:879:10)
    at defaultResolve (node:internal/modules/esm/resolve:1087:11)
    at nextResolve (node:internal/modules/esm/loader:161:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:831:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:413:18)
    at ESMLoader.import (node:internal/modules/esm/loader:514:22)
    at importModuleDynamically (node:internal/modules/cjs/loader:1151:29)
    at importModuleDynamicallyWrapper (node:internal/vm/module:438:21)

 —————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

### Your Environment

```text
Node : 19.2.0
   OS   : darwin arm64
   yarn : 1.22.17

   nx : 15.3.0
   @nrwl/angular : 15.3.0
   @nrwl/cypress : 15.3.0
   @nrwl/detox : Not Found
   @nrwl/devkit : 15.3.0
   @nrwl/esbuild : Not Found
   @nrwl/eslint-plugin-nx : 15.3.0
   @nrwl/expo : Not Found
   @nrwl/express : Not Found
   @nrwl/jest : 15.3.0
   @nrwl/js : 15.3.0
   @nrwl/linter : 15.3.0
   @nrwl/nest : Not Found
   @nrwl/next : Not Found
   @nrwl/node : Not Found
   @nrwl/nx-cloud : 15.0.2
   @nrwl/nx-plugin : Not Found
   @nrwl/react : Not Found
   @nrwl/react-native : Not Found
   @nrwl/rollup : Not Found
   @nrwl/schematics : Not Found
   @nrwl/storybook : 15.3.0
   @nrwl/web : Not Found
   @nrwl/webpack : 15.3.0
   @nrwl/workspace : 15.3.0
   typescript : 4.9.4
   ---------------------------------------
   Local workspace plugins:
   ---------------------------------------
   Community plugins:
         @ngrx/component-store: 15.0.0
         @ngrx/effects: 15.0.0
         @ngrx/store: 15.0.0
         @jefiozie/ngx-aws-deploy: 5.0.0
         @ngrx/eslint-plugin: 15.0.0
         @storybook/angular: 6.5.14

### Anything else relevant?

_No response_

nevermind, it's my mistake... sorry


Automated Package Upgrade

:tada: This PR is included in version 25.3.447 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


MemoryError still presists with n_jobs=3

Try n_jobs=1?

Still not working...
This time it gets stuck even earlier.

I am trying to replicate the baseline model and for that purpose I need to get the files generated after pre processing. Is there any way anyone could share a link to those files so that I could proceed with the remaining steps.
Thanks in advance

@mominali12 not sure I'm seeing it in the screenshot -- warnings can be safely ignored, and if you're missing the ujson package, try pip install ujson

The system stops at Done 9 and won't progress any further. I believe that I should be getting a train_record.pkl file and this file is not created neither is there any progress in pre processing

@mominali12 That's strange. Could you try running the code with a machine with more RAM?

Same problem for me on linux machine with 32GB of RAM. Stuck after job 9 and RAM usage is going up until crash.

Most of our work is done on server machines with 64G or more memory, so it's possible that even larger RAM will help resolve the issue. But also if people are stuck at example 9, it might also be worth investigating into that particular example and skip/truncate if necessary.


Added ability to manipulate the edit form

Added ability to manipulate the edit form. Sometimes you need to add additional actions, or manipulate form fields that might be getting added or manipulated through this module.
public function updateItemEditForm($form) {
    $actions = $form->Actions();
    $record = $form->getRecord();
    $actions->removeByName('action_unpublish');
}

If there's no conflict, updateItemEditForm would be better than updateVersionedItemEditForm, as it mirrors the parent class's extend API.
Also, can you squash these commits please?

That's where I started, but immediately had an issue where it was being called multiple times. Might just be due to my current setup - but I just thought this might allow you to be more contextually specific. Let me know what you think and I'll make the change + squash the extra commit where I made that change.

I changed it back to updateItemEditForm. Should be good to go now?

Did that end up working for your code with updateItemEditForm? In theory most field operations should be repeatable without causing any problems. Anyone have any objections to this?

Yeah, it did! I found that another module was being somewhat greedy with i t's usage of updateItemEditForm and completely throwing off everything I was setting elsewhere.


Add Support for Images

Images should be auto embedded, especially things like imgur and things

Before diving off the deep end with this, I believe we should discuss our methodology involving this. I think there might be an easier way for all of these specific items.

Also, duplicate of #9. This should be added to #9's list, and closed.

Closing this.


May be incompatible with hubot@3?

I was just trying to upgrade all my hubot things, and I went with<EMAIL_ADDRESS>This yielded errors here:
https://github.com/loafoe/hubot-matteruser/blob/fdf4cdb883eb6addccc71bb9ce24a55d942baa49/src/matteruser.coffee#L201
I commented this line out to see if it the ignored users. The error just shifted to just a few lines later:
https://github.com/loafoe/hubot-matteruser/blob/fdf4cdb883eb6addccc71bb9ce24a55d942baa49/src/matteruser.coffee#L207
INFO Someone is typing...
DEBUG Message {
  event: 'posted',
  data:
   { channel_display_name: '',
     channel_name: 'my8---redacted---br6c',
     channel_type: 'D',
     mentions: '["no4--redacted--br6c"]',
     post: '{"id":"ke3----tc","create_at":1522146010510,"update_at":1522146010510,"edit_at":0,"delete_at":0,"is_pinned":false,"user_id":"my8---t1h9e","channel_id":"rn----wa","root_id":"","parent_id":"","original_id":"","message":"help","type":"","props":{},"hashtags":"","pending_post_id":"my8------h9e:1522146010862"}',
     sender_name: 'mynickname',
     team_id: '' },
  broadcast:
   { omit_users: null,
     user_id: '',
     channel_id: 'rn83---redacted--cwa',
     team_id: '' },
  seq: 4 }
ERROR TypeError: Cannot read property 'getUserByID' of undefined
  at Matteruser.message (--redacted--\node_modules\hubot-matteruser\src\matteruser.coffee:207:18, <js>:289:28)
  at Client.<anonymous> (--redacted--\node_modules\hubot-matteruser\src\matteruser.coffee:1:1, <js>:5:61)
  at Client.emit (events.js:160:13)
  at Client.onMessage (--redacted--\node_modules\mattermost-client\src\client.coffee:279:17, <js>:381:23)
  at WebSocket.<anonymous> (--redacted--\node_modules\mattermost-client\src\client.coffee:224:13, <js>:318:22)
  at WebSocket.emit (events.js:160:13)
  at Receiver.ontext (--redacted--\node_modules\ws\lib\WebSocket.js:841:10)
  at --redacted--\node_modules\ws\lib\Receiver.js:536:18
  at Receiver.applyExtensions (--redacted--\node_modules\ws\lib\Receiver.js:371:5)
  at --redacted--\node_modules\ws\lib\Receiver.js:508:14
  at Receiver.flush (--redacted--\node_modules\ws\lib\Receiver.js:347:3)
  at Receiver.finish (--redacted--\node_modules\ws\lib\Receiver.js:541:12)
  at Receiver.expectHandler (--redacted--\node_modules\ws\lib\Receiver.js:499:31)
  at Receiver.add (--redacted--\node_modules\ws\lib\Receiver.js:103:24)
  at TLSSocket.realHandler (--redacted--\node_modules\ws\lib\WebSocket.js:825:20)
  at TLSSocket.emit (events.js:160:13)
  at addChunk (_stream_readable.js:269:12)
  at readableAddChunk (_stream_readable.js:256:11)
  at TLSSocket.Readable.push (_stream_readable.js:213:10)
  at TLSWrap.onread (net.js:599:20)

INFO ping

Could you solve the problem? I am having the same issue here.

my solution at the time was to downgrade hubot, which I've been using ever since. Not ideal.

@ketchalegend @ccoenen the next version (5.x) should be compatible with Hubot3. If you are able to test the current master branch that would be great!

I'm very sorry, My bot is currently running well enough and I am somewhat swamped. I will not be able to test this in the next 3-4 weeks. This is not for a lack of interest, though. I will update to 3.x at some point.

@ketchalegend @ccoenen there is a new v5.0.0 which should be fully compatible with Hubot3, please try it and report any issues.


Interaction terms

Hi, I would like to test the significance of a variable with an interaction term as covariate:
trait ~ sex:age + variable_to_test
Can I do this with your library @jzluo?

Hi @Hoeze, this would have to done in the data preparation just like sklearn. Say you have a dataframe df with columns trait, sex, age, variable_to_test. Two simple examples:

Use patsy

y, X = dmatrices('trait ~ sex:age + variable_to_test', df)

Create interaction term in pandas

df['sex:age'] = df['sex'] * df['age']
X, y = df[['sex:age', 'variable_to_test']], df['trait']

Let me know if it works for you!


Add option to have brighter colors in the output.

Hi,
setting intense only for the message looks a little bit half baked for me. level, timestamp (if highlighted) are not taken into account. Same for the pid and tid which aren't in the 0-15 range and cannot be "intensed".
The coloring stuff is something that is currently very opinionated and inflexible and only works for dark backgrounds.
Maybe we should go for some more real themeisch thing? Haven't checked yet if there is something that could be reused...

The actual problem I had was that pid, tid and tag use autogenerated colors which on average appear much brighter than the log messages. So I've made the messages brigther to balance it out.
But I agree, it would be great to allow the user to configure the colors they like.


[fix] (inverted index) fix error result in compound query (#40425)

Proposed changes
pick from branch-2.1 #40425

run buildall


Update FPGA ANR ref design readme

Existing Sample Changes
Description
Restructured to match the new template. Updated the markdown to conform to standard support. Moved several sections around, split Windows and Linux build and run information into separate sections, and added detail to the DevCloud section.
Fixes Issue#
External Dependencies
N/A
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[x] Documentation change

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Command Line
[x] oneapi-cli
[x] VSCode

Adding @IgorOchocki and @jimmytwei for notifications.


I can not use it

I can not install it with the latest versions of three and R3F

downgrade three.js version to 0.133.0 until it get fixed

try this version
https://www.npmjs.com/package/latest-react-3d-icons


Make commands take multiple packages

I tried scoop uninstall less wget today, but it told me that it could not uninstall less wget. It would be nice if it interpreted whitespace as a delimiter, and took each item one by one.

Thanks for the suggestion. This is working now.


Fix crash on startup involving regeneratorRuntime

This seems to be cropping up in recent versions of Babel, https://phabricator.babeljs.io/T7128 is the bug I've filed but they don't seem to be super excited to fix it :-/
Closes #8

@kevinsawicki This is :gem: and should fix up #8

Published in 2.0.2, thanks :+1:


Introduce replacements

fixes #21

@jamiesamson this would be interesting if it worked

Force-pushed out.


Feature: eq for semantic equality

Policies, PolicyLists, Directives and ValueItems should support __eq__.
Two objects (of the same type)  should satisfy a == b IFF they are "semantically" equivalent in terms of their effect.
This feature is likely easiest to build on top of .canonical
Edgecases to cover:

Directives with the same valueItems in a different order
Policies with the same directives in a different order
Directive Names, Keywords, Schemes with different cAsEs

Pointed out to me today: Most of CSP is case-insensitive, paths in urls being a noteworthy exception.


fix: Check for permissions in FilterBox

SUMMARY
If a filter box uses data that the user shouldn't have access to, they don't currently get restricted from using the filter box. This is because filterboxes are kinda hacky to begin with, and it looks like we don't check permissions for the extra queries it runs. This PR builds a QueryContext for each query the filterbox runs and calls raise_for_access on it. Then we catch that exception and set the error on the response if it fails.
The big thing I'm unhappy with here is the import within the run_extra_queries function o_O I tried to get around this, but circular imports were pretty impossible here... Would love it if others have better thoughts about how to resolve this.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN
Manually test with a FilterBox that accesses data I don't have access to, see the failure. See it pass when I do have access to the data.
No unit tests currently exist for the FilterBox viz. I've got the sense that this will be deprecated soon so 🤷
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

to: @villebro @serenajiang @michellethomas @ktmud
cc: @junlincc

@etr2460 thanks for the PR! In this case, does the filterbox share the same dataset with at least one charts on the dashboard?
Please help me understand the use case a bit more, we should get it covered in the native filter. 🙂

In this case, does the filterbox share the same dataset with at least one charts on the dashboard

Yup! Although it wouldn't have to share the same dataset. the filters only define column+value pairs to add to the filter, so theoretically a user could have access to every chart on the dashboard, but not have access to the table backing the filter box.


It takes two hours to evaluate two indicators with 500 data records. Is there any method to accelerate the evaluation?

It takes two hours to evaluate two indicators with 500 data records. Is there any method to accelerate the evaluation?

@wangsir-cn were you able to figure it out? we do use async to make it as fast as possible but the biggest time sink is the LLM. Which one are you using?


Updated tests for 'Iterate through an array with a for loop' to ES6

Updated tests to pass with ES6 syntax. Allows let, const, and no semicolon at end of line.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #16983

Finally made the last test pass satisfactorily. Attaching the test cases I used.

@mail-liam, thank you for submitting a PR for this issue. This looks good, though I'd like to test this locally before we merge it.

Updated again. Here are the new tests used:

Thank you for helping us improve this section of the curriculum, @mail-liam! Looking forward to your next contribution :+1: :+1:


Use application name/id for log tag instead of 'flutter'

The tag used for logging today uses is 'flutter'. When user has multiple flutter apps on their phone, it would be hard to sift through crash logs unless we use app.id or some other app specific string during logging.

Agreed.  This will take a bit of work since it's currently hard-coded in the engine:
https://github.com/flutter/engine/blob/d658f9d324a401589174400cf0463d9948b4bcb0/lib/ui/dart_runtime_hooks.cc#L155
There is a second place this is hard-coded for engine errors as well, but those can probably stay flutter?
https://github.com/flutter/engine/blob/6c5315c3a1d72ee2aae520e05c1ebf0f6794ae0e/sky/engine/wtf/Assertions.cpp#L65
@jason-simmons @chinmaygarde

This should be in place before we release the app to production.


ascon-c/tests/demo.c --> mlen variable value

I am taking a look at the implementation of ASCON in C. I found very useful the "demo.c" program to learn how to use the algorithm. It might be due to my lack of understanding of ASCON, but I realized that "mlen" initial value is 8, instead of 16. The same happens with "alen":
  unsigned char a[16] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15};
  unsigned char m[16] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15};
  unsigned long long alen = 8;
  unsigned long long mlen = 8;

Is this a typo in the code, or is it just me that I am missing something?

This is just an example, where the data length passed to Ascon is 8 bytes. Not the allocated size. But I agree it's misleading and changed the lengths to 16 bytes.


Using codeclimate within VSCode - Windows

Hi everyone,
This is more like a clarification instead of reporting an issue. Basically my doubt is whether it is possible to use this plugin in VSCode based on Windows. If yes, do you have specific configuration to do so?
Regards,
Wagner

Hi Wagner,
This plugin works 'natively' on Linux, but in theory, it could work. I guess the best option for you would be using Docker for Windows and following the running-inside-of-a-docker-container instructions.
In essence, this plugin calls the codeclimate-cli (Docker based) executable, which should be accessible either in your OS or inside a specified container.
Best of luck


Typo in README

If you do web streaming, you should try the new read-ahead buffer feature of FFmpegInteropX, available in the latest prerelease packages. It will read ahead and buffer a configurable amount of stream data to allow uninterrupted playback. This even allows fast forward seeking (stepping) without stream reconnection, if the target position is buffered.

config.ReadAheadBufferEnabled = true;

// Optionally, configure buffer size (max duration and byte size)
config.ReadAheadBufferDuration = TimeSpan.FromSeconds(30);
config.ReadAheadBufferEnabled = 50*1024*1024;

The last line should be config.ReadAheadBufferSize = 50*1024*1024;

Fixed, thank you for the hint.


Use change-to when edited

I'd like to still execute the change-to when a PR target is edited, but the existing code overrides the value and then fails.

Thanks!

Available in https://github.com/Vankka/pr-target-branch-action/releases/tag/v2.1


Make Appbar in MainActivity collapsable (as it is in most apps from Samsung or Google)

As of version 3.5.1, this has been introduced partially for activities regarding the settings of the app. It is intended to introduce these toolbars for all activities.


Added State Function to JavalinRenderer

The Idea is to add a state function to the JavalinRenderer similar to the one in JavalinVue. This is needed, at least for me, because I need to do some filtering and customization on reports generated using templates depending on the user and a couple of other options.

@tipsy  just thought this might also be useful to others

Thanks @TareqK ! What people typically do for this is:
ctx.render("/template.ext", baseModel(ctx) + componentModel)

Since the FileRenderer  already has access to the Context, you could also create your own rendering implementation for setting a base model every time.
I sort of like taking the state-function concept from JavalinVue, but I'm not sure having implicit values in the template model is good. It is namedspace to javalin, but that could also be considered a downsiden (having to prefix each property).
What do you think about getting rid of the default properties and removing the namespace?

What do you think about getting rid of the default properties and removing the namespace?

I think it would be a little inconsistent, since we inject javalin using $javalin in JavalinVue, i think it makes sense to keep it namespaced and with different properties for path/query/state . Also, we can be a little more sure that any data we inject unlikely to conflict with the javalin namespace.
I think it really comes down to consistency and convenience;  I dont want to explicitly call and inject my state it into the model each time, or implement my own FileRenderer each time i want state injected.

@tipsy  so should we merge this or do you want me to change the namespace ?

It's named $javalin in JavalinVue, because that's the convention Vue uses for extending its prototype. For template models, on the other hand, the convention is to put everything in a Map<String Any>. I would rather these two plugins be consistent within their own domain than have a "Javalin-flavored" consistency cross-domain.
Before merging this, I would make the state function return a Map<String, Object>, and make the default implementation empty. You should also merge the component-specific state into the base-state, overriding any duplicate keys (and perhaps logging info?).

@tipsy  Ive gone ahead and refactored the state map and added overriding, though my Kotlin-Fu is limited so i just converted the model to a mutable map and modified that(but at least, the argument called stays immutable). Ive also added a state() utility method, similar to model(), and ive added a per-render state to the Context class. Ive added tests for everything.
I also removed the namespace prefix, so you can access directly using queryParams and pathParams and state. ive also made it so that array params are kept as arrays instead of being parsed to a string.

I think we need to take a step back here, adding a state: Map<String, Any> doesn't really give any added benefit to how templates are rendered (since they already have a model: Map<String, Any>). If I understand correctly what you want to achieve, all you need is your one function:
@JvmField
var stateFunction: (Context) -> Map<String, Any?> = { mapOf<String, Any>() }

Although, I would probably name is baseModelFunction, which would indicate that the model is merged on top of the result of the baseModelFunction.
The only other change required should be to this line:
return renderer.render(filePath, model, ctx)

So that it includes this new base model:
return renderer.render(filePath, baseModelFunction(ctx) + model, ctx)

The user can add query/path params themselves if they need them.

I assume since we are passing the CTX to the base function anyway, we can insert them from there right ? I'll patch it up tommorow - but do we still need a per-component state then ?

I assume since we are passing the CTX to the base function anyway, we can insert them from there right ?

Could you elaborate?

Do we still need a per-component state then ?

You'll still want per-template state (as in a model for each template).
The base model will handle things like the current user, the current locale/language, if the website is using dark or light theme, etc.
The template specific model with deal with things that are only relevant for a specific page, for example account details or a list of users being displayed.

This is out now ! https://javalin.io/news/2021/01/19/javalin-3.13.0-released.html

This is out now ! https://javalin.io/news/2021/01/19/javalin-3.13.0-released.html


WIP Guided pool executor

Fixes #
This adds new executor/scheduler features such as scheduler_hints that can be passed from executors to control how tasks are placed by the scheduler (numa domains in this first version)
Proposed Changes
New executor types that pass task arguments through a custom user defined function (templated by the executor type) so that the tasks can be queried for information (such as memory placement) before being scheduled. The query only happens once the args for the task a ready so that data locality (memory addresses of the future contents) can be obtained when they are valid.
Any background context you want to provide?
This PR contains some commits that need to be moved onto other branches, but are included here for testing purposes on my home setup.

Closing this in favor of #3415 and #3420.


MAINT: Loosen installation restrictions

Since sdcflows is nipreps middleware and will be used by various tools, we should not be overtly strict on installations.

Codecov Report

Merging #269 (24b87b6) into master (56a02bf) will increase coverage by 7.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   83.09%   90.49%   +7.40%
==========================================
  Files          25       25
  Lines        1851     1851
  Branches      278      212      -66
==========================================
+ Hits         1538     1675     +137
+ Misses        281      145     -136
+ Partials       32       31       -1

Flag
Coverage Δ

travis
?

unittests
90.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

sdcflows/workflows/outputs.py
93.54% <0.00%> (+1.61%)
:arrow_up:

sdcflows/interfaces/reportlets.py
89.83% <0.00%> (+1.69%)
:arrow_up:

sdcflows/interfaces/bspline.py
87.44% <0.00%> (+4.18%)
:arrow_up:

sdcflows/interfaces/utils.py
94.50% <0.00%> (+11.00%)
:arrow_up:

sdcflows/workflows/fit/syn.py
69.82% <0.00%> (+21.30%)
:arrow_up:

sdcflows/interfaces/fmap.py
96.55% <0.00%> (+24.13%)
:arrow_up:

sdcflows/utils/phasemanip.py
94.02% <0.00%> (+28.35%)
:arrow_up:

sdcflows/interfaces/brainmask.py
100.00% <0.00%> (+43.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a02bf...24b87b6. Read the comment docs.

We had this issue a couple weeks ago with niworkflows or something. I think the conda-forge builds of Python are now treating cpython and pypy as variant builds of Python, and pypy is lexically later than cpython so is seen as more recent by the resolver.
Sometimes.

I guess clearing the cache worked... good to merge?


Update of PR #2300

Purpose

This PR is an update of #2300. I could not push my changes to the other PR.
Therefore I created a new one.
I had to merge the new HTTP API into the branch. @muyangye can you please check if this is correct?
Remarks

PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no

@tenthe Thanks a lot for merging🙏.
Is there any reason to switch from JAX-RS to Spring MVC? I copied (I can't even do git pull🤣) the code to local and was not able to compile it because endpoints in PipelineElementFile.java expect a return of type ResponseEntity which is part of Spring MVC whereas the actual return is of type Response which is part of JAX-RS. Other than that I spot no issues.

Hey @muyangye,
thanks for trying it out.
What exactly didn't work for you?
I just tried to upload two files with the same name and I was able to change the name of the second file.
My last commit only fixes some linting errors.
The change from JAX-RS to Spring MVC was made to harmonize our code base, see #2276.
If the change causes problems in your development setup just let me know and we can try to solve it together.

Hey @muyangye, thanks for trying it out.
What exactly didn't work for you? I just tried to upload two files with the same name and I was able to change the name of the second file. My last commit only fixes some linting errors.
The change from JAX-RS to Spring MVC was made to harmonize our code base, see #2276. If the change causes problems in your development setup just let me know and we can try to solve it together.

@tenthe Thanks for pointing out the harmonization PR. I wasn't able to do git pull or git push so I didn't get the latest change brought by #2276. After manually downloading the dev branch to local I was able to compile and everything works perfectly. Let's merge this PR and I'll continue the work on #2181 once I return to USA since I have network issue with git right now.


Fixes a typo and a missing slash in urls

Coverage remained the same at 37.085% when pulling 7cbe67ac833a26f9c6ef5d08d4e598aef3dfd7e8 on develop into bfcce626990c53aef7fbe534f1f6ff1092945597 on master.


Use os.stat instead of os.access

This gives true file permissions irregardless of the current user.
Tested both for normal user and root.
Fixes #84

Nice - that looks like it will do the job - using group attributes is a good idea


Add Byron Blank to Contributors list

Adding my name to Contributors

@ByronCoder, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

Hello. I felt great following the tutorial. I didn't have any issues except github saying there was a conflict. I'm not new to coding but I am to open source.  One of the hardest things is finding something that I can contribute to.  If a project is popular a lot of people are already contributing to the issue or feature or if its not popular the project seems kind of dead.  Sometimes the issue or feature isn't something I'm familiar with .


[Mat-Menu] Feature Request : add mat-menu-trigger to overlay when [overlapTrigger]="false"

Bug, feature request, or proposal:
mat-menu can be configured not to overlap its trigger.
The trigger though is no more accessible because of the backdrop added when opening a menu.
Material guidelines tell the trigger should allow us to close the menu as well as a click out of it.
Therefore I'd recommend making the trigger button accessible when backdrop is active.
What is the expected behavior?
Trigger should be accessible if menu is not overlapping it.
What is the current behavior?
Backdrop disables access to anything else than the menu, even if it doesn't overlap the trigger.
What are the steps to reproduce?
https://stackblitz.com/edit/angular-bcfxwg?file=app%2Fmenu-overview-example.html
What is the use-case or motivation for changing an existing behavior?
Dismiss a menu by tapping outside of the menu, or by tapping the emitting button (if visible). (https://material.io/guidelines/components/menus.html#menus-behavior)
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?

Closing as duplicate of #9938


SnipsConfigParser.write_configuration_file should return True when it succeeds

The helper function SnipsConfigParser.write_configuration_file returns False when it fails, but doesn't return anything when writing the configuration succeeds. It would be more logical if it returns True then.
That would make it cleaner to test if writing succeeded in an app:
if SnipsConfigParser.write_configuration_file(CONFIG_INI, self.config):
  # Do something
else:
  # Give an error message or do something else

Moreover, the helper function SnipsConfigParser.read_configuration_file always returns a value: the dictionary with configuration values if reading succeeds and an empty dictionary when it fails. So it would be more consistent if SnipsConfigParser.write_configuration_file does the same.

Hello:
Thanks for this suggestion. We have already changed.


Channel specifically for stock options

If something about options is mentioned drop this is in the channel.
How are we sure if a tweet is about options?

Maybe also get the options data via yfinance

We probably need to train a classifier for doing this, but is there data on option tweets?

Too hard to do, how are we going to find out if a tweet is specific for options?


Fictitious Self-play and Self-play documentaion needed

Hi, thanks for providing such a powerful open-source framework. This is an awesome repo for MARL training and is what we needed the most to implement some distributed training algorithm without building a framework from scratch. While I appreciate how easy to train agents with the PSRO algorithm using this repo, I would like to see more training algorithms coming in the future. I was reading the paper of your work, and I find the following sentence in that paper:
"In the initial implementation, we provided three PB-MARL algorithms support, they are Policy Space Response Oracle [27] (PSRO), Fictitious Self-play [8] (FSP), Self-play [9] (SP) and Population-based Training [14] (PBT)" (Doesn't that make four rather than three algorithms already?)
If my understanding was right, you guys have already integrated the training algorithms such as Fictitious Self-play in this repo now, right? However, I could not find any documentation about how to use the FSP or PBT algorithm to train my agents. Would you guys mind to provide more examples of using other training algorithms in the future? Thanks very much.

Hi, thank you so much for your suggestions. I'm very glad to answer your questions.

PSRO, FSP and SP since there is a little difference between them, which is the solution of a meta-game. Generally speaking, the current framework structure can support different algorithms as long as they have almost the same executing steps:

interactions between every single policy in the population, which may be maintaining a meta-game;
solving the population based on the results of interactions you do in the first step;
extend your population with more powerful/diverse policies which can be running a best response(BR) algorithm against the current solution of the population.
We've already implemented this loop with good scalability and you can customize each part of it to create new algorithms.

For more examples and documentation in detail, they are actually on our current plan. For algorithms like FSP and SP, they are implemented and tested in our dev branch. We'll provide them in current updates.


Cannot scroll when hovering over a tooltip on the main page (old ui)

kinda unexpected :/
We should at least make sure that it works in the new ui

Issue is solved in the new UI.


Linking on Windows

It would be nice if the Readme explained how to compile this on Windows. As it stands I either get ld: cannot find -lpq or and equivalent error for pq.lib depending on whether I'm using the -msvc or -gnu toolchains. It actually fails when compiling diesel_codegen.
I installed PostgreSQL using the BigSQL windows installer, and it put libpq.a and libpq.dll in C:\Program Files\PostgreSQL\pg96\lib but I have no idea how to tell cargo to look there and google did not help.

You should probably copy/paste libpq.a and .dll in C:<where you installed rust>\lib\rustlib\x86_64-pc-windows-gnu\lib
if you don't want to copy the dll, you could edit $HOME/.cargo/config so that the linker knows where to lookup your dll, or you could specify the lookup directly in your cargo command line, like so :
cargo rustc --release -- -L C:\\Program Files\\PostgreSQL\\pg96\\lib
I am on linux myself so I can't say that these work for sure (at least the first one should), but at least it's something

I also found that the instructions in pq-sys worked, specifically set an environment variable LIB_PQ_DIR=C:\Program Files\PostgreSQL\pg96\lib worked. You have to do cargo clean after setting it.
How do I edit .cargo/config? Something like this?
[build]
rustflags = ["-L" "C:/Program Files/PostgreSQL/pg96/lib"]

I edited my post

Ah this did the trick:
[target.x86_64-pc-windows-msvc.gnu]
rustc-link-search = ["C:\\Program Files\\PostgreSQL\\pg96\\lib"]

No need for the rustc-link-lib.

Looks like this has been resolved. You can also do this by adding the PG directory to your PATH, there's an executable in the PG install directory which does this for you as well.

Came across this trying to run
cargo install diesel_cli --no-default-features --features postgres

Adding to $env:PATH the following did NOT help
C:\Program Files\PostgreSQL\17\lib
C:\Program Files\PostgreSQL\17\bin

(I did validate that the .lib file it was complaining about did exist in the lib dir.)
Instead, I re-read the docs and just followed the instructions from there instead lol
https://diesel.rs/guides/getting-started
cargo install cargo-binstall
cargo binstall diesel_cli

This is still an issue with postgres 17....

I'm locking this issue now as this is long answered and not the right place to discuss your problems about your local development setup.
If you feel that you still have this problem I recommend rereading the Installing Diesel CLI section of the getting started guide, especially the "A note on installing diesel_cli" box. If that doesn't answer your questions you are welcome to open a new discussion thread in our discussion forum. Just make sure to include all details about your system setup (which operating system, which environment variables are set, how is libpq installed, how does your Cargo.toml file look like).


Fixes a shadowed variable in the system time zone initializer.

The shadowed variable that's being removed in this PR causes the name to fall out of scope as soon as it exits the "if (0 < ret)" block, and the outermost "name" field is left null. This causes the systemTimeZone to always report as GMT.
I'm not sure if the mechanism I'm using to test this is the best way to go. Calling into the C time functions seems like a hack, and something that might get broken by subtle changes to system configurations. It works on both my Mac and Linux installs, and it correctly gives an error when the change to CFTimeZone.c is removed.

oops, hmm perhaps we should enable error on shadowing
Validating against the C api's is perfectly reasonable in a unit test.


Accept "ull" format of parses holding statistical information

Closes issue #168 https://github.com/singnet/language-learning/issues/168

Commit https://github.com/OlegBaskov/language-learning/commit/44ef579d6dae0f11f4c9a1fc71ed1ae20d42bcdb, PR https://github.com/singnet/language-learning/pull/190


Error on Building thpp

While building thpp
THPP_NOFB=1 ./build.sh
I am facing the error:
In file included from /home/admin/usr/src/thpp/thpp/test/StorageTest.cpp:13:0:
/usr/include/glog/logging.h:85:27: fatal error: gflags/gflags.h: No such file or directory
 #include <gflags/gflags.h>

I am using CentOS7, CUDA 8.0 and CUDNN 5.1.

I believe i fixed it by:
yum install gflags-devel


Update for distribution spec 1.0

Clarifies in stronger language which registries are supported by containerd now that OCI distribution specification has reached 1.0 and has compliance testing.
Adds a "workaround" for registries which do not properly implement the "/v2" prefix as defined by the specification. This helps some Harbor users which are using non-compliant mirror endpoints.
Closes #5518

cc @MaxRink

/retest

/retest

[sig-node] ResourceMetricsAPI [NodeFeature:ResourceMetrics]
_output/local/go/src/k8s.io/kubernetes/test/e2e_node/framework.go:23
  when querying /resource/metrics
  _output/local/go/src/k8s.io/kubernetes/test/e2e_node/resource_metrics_test.go:45
    should report resource usage through the resource metrics api [It]
    _output/local/go/src/k8s.io/kubernetes/test/e2e_node/resource_metrics_test.go:66
    Timed out after 60.000s.

    Expected
        <string>: KubeletMetrics
    to match keys: {
    [."container_start_time_seconds"[resource-metrics-7721::stats-busybox-0::busybox-container]:
    	Expected
    	    <string>: Sample
    	to match fields: {
    	.Value:
    		Expected
    		    <model.SampleValue>: 1.625262691484108e+09
    		to be >=
    		    <int64>:<PHONE_NUMBER>628039599
    	.Timestamp:
    		Expected
    		    <time.Time>: 1970-01-01T00:00:00Z
    		to be >=
    		    <time.Time>: 2021-07-02T21:50:53.628040868Z
    	}
    	, ."container_start_time_seconds"[resource-metrics-7721::stats-busybox-1::busybox-container]:
    	Expected
    	    <string>: Sample
    	to match fields: {
    	.Value:
    		Expected
    		    <model.SampleValue>: 1.625262691536568e+09
    		to be >=
    		    <int64>:<PHONE_NUMBER>628042725
    	.Timestamp:
    		Expected
    		    <time.Time>: 1970-01-01T00:00:00Z
    		to be >=
    		    <time.Time>: 2021-07-02T21:50:53.628043652Z
    	}
    	]
    }

    _output/local/go/src/k8s.io/kubernetes/test/e2e_node/resource_metrics_test.go:107

looks like kubelet or cadvisor issue cc @dims

/retest

/retest

/retest


However, Buttons inside the ListTile keep their visual effect.
ListTile's visual effect can be recovered with Opacity in the Container color (see video and code sample)
I'm not sure if it is a bug or the intended behavior. A have been using decorated Container with tons of widgets, and the decoration always appears behind the Child (as it should, I suppose). Only ListTile has its onTap visual effect blocked by the Container's background color.
Expected results
The Container background color should be behind the Child.
Actual results
The Container background color blocks ListTile visual effect
Code sample
Code sample
import 'package:flutter/material.dart';

class ListTileOnTap extends StatelessWidget {
  const ListTileOnTap({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          title: const Text('ListTileOnTap'),
          backgroundColor: Colors.blue[200],
        ),
        body: Column(
          crossAxisAlignment: CrossAxisAlignment.start,
          children: [
            Container(
              decoration: // behind the [child]
                  BoxDecoration(
                   border: Border.all(),
                // color:  Colors.grey[300],
              ),
              child: ListTile(
                splashColor: Colors.red,
                onTap: () { null; },
                title: Text('ListTile 1'),
                subtitle: Text('Color in Container: False'),
                trailing: IconButton(
                  onPressed: () { null; },
                  icon: Icon(Icons.star_border),
                  highlightColor: Colors.red,
                ),
              ),
            ),
            Container(
              decoration: // behind the [child]
                  BoxDecoration(
                   border: Border.all(),
                   color: Colors.grey[300],
              ),
              child: ListTile(
                splashColor: Colors.red,
                onTap: () { null; },
                title: Text('ListTile 2'),
                subtitle:
                    Text('Color in Container: True\ncolor = Colors.grey[300]'),
                trailing: IconButton(
                  onPressed: () { null; },
                  icon: Icon(Icons.star_border),
                  highlightColor: Colors.red,
                ),
              ),
            ),
            Container(
              decoration: // behind the [child]
                  BoxDecoration(
                   border: Border.all(),
                   color: Colors.grey[800]!.withOpacity(0.20),
              ),
              child: ListTile(
                splashColor: Colors.red,
                onTap: () { null; },
                title: Text('ListTile 3'),
                subtitle: Text( 'Color in Container: True\ncolor = Colors.grey[800].withOpacity(0.20)'),
                trailing: IconButton(
                  onPressed: () { null; },
                  icon: Icon(Icons.star_border),
                  highlightColor: Colors.red,
                ),
              ),
            ),
            Text('Conclusion:\n'),
            Text('Background color blocks the ListTile\'s visual effect\n'),
            Text('Background color does not block the visual effect of buttons in the ListTile')
          ],
        ));
  }
}

Screenshots or Video

Screenshots / Video demonstration
ListTileOnTap.webm

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
flutter doctor -v
[✓] Flutter (Channel stable, 3.19.6, on openSUSE Tumbleweed 6.8.8-1-default, locale en_US.UTF-8)
    • Flutter version 3.19.6 on channel stable at ~/BIN/FLUTTER_3.19.3
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 54e66469a9 (4 weeks ago), 2024-04-17 13:08:03 -0700
    • Engine revision c4cd48e186
    • Dart version 3.3.4
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at ~/BIN/ANDROID_STUDIO_2<IP_ADDRESS>
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = ~/BIN/ANDROID_STUDIO_2<IP_ADDRESS>
    • Java binary at: ~/BIN/ANDROID_STUDIO_2<IP_ADDRESS>_fonte/jbr/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✗] Chrome - develop for the web (Cannot find Chrome executable at google-chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✗] Linux toolchain - develop for Linux desktop
    ✗ clang++ is required for Linux development.
      It is likely available from your distribution (e.g.: apt install clang), or can be downloaded from https://releases.llvm.org/
    • cmake version 3.29.2
    • ninja version 1.11.1
    • pkg-config version 2.1.1
    ✗ GTK 3.0 development libraries are required for Linux development.
      They are likely available from your distribution (e.g.: apt install libgtk-3-dev)

[✓] Android Studio (version 2023.2)
    • Android Studio at ~/BIN/ANDROID_STUDIO_2<IP_ADDRESS>_fonte
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.89.0)
    • VS Code at /usr/share/code
    • Flutter extension version 3.88.0

[✓] Connected device (2 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64 • Android 13 (API 33) (emulator)
    • Linux (desktop)              • linux         • linux-x64   • openSUSE Tumbleweed 6.8.8-1-default

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

I think this is because the splash of color goes to the parent Material. Which is behind the Container and the ListTile. Not sure the best solution, as the docs recommend not wrapping each ListTile with its own Material for performance reasons.

Container(
              decoration: // behind the [child]
                  BoxDecoration(
                   border: Border.all(),
                   color: Colors.grey[300],
              ),
              child: ListTile(
                splashColor: Colors.red,
                onTap: () { null; },
                title: Text('ListTile 2'),
                subtitle:
                    Text('Color in Container: True\ncolor = Colors.grey[300]'),
                trailing: IconButton(
                  onPressed: () { null; },
                  icon: Icon(Icons.star_border),
                  highlightColor: Colors.red,
                ),
              ),
            ),

@leocirto Here, the BoxDecoration's color property is used in applying background color to the Container, hence for this condition, the ListTile's visual effects and also per Callum's comment above, see if these help further in your case or not.


Add encryption at-rest to the RDS database used by APT in production

@wrynearson Should we move this into a sprint since MCP is requesting this be completed?

Yes, good catch. I added it to Sprint 3

@sunu and I took at a look at this yesterday. Encryption-at-rest can only be enabled when creating the database, so we will need to migrate the data:

Manually take a snapshot of the database
Rename the database in the CDK script to ensure Cloudformation removes and re-deploys the database (with encryption)
Restore the new database from the Snapshot saved in Step 1

The steps need to be slightly different since AWS doesn't allow restoring a snapshot to an existing RDS instance either:

We manually take a snapshot of the database and create an encrypted copy of it.
We restore the encrypted copy to a new database
We tweak the CDK scripts to ensure it uses the new database
After confirming everything works fine, delete the old database

Oh great catch, I didn't realize the snapshot had to be encrypted first.  Here' s a tutorial for reference

@sunu I believe this is complete? Is there anything else we/IMPACT needs to do for this ticket?

We have deleted the old unencrypted instance now after making sure the migration went fine.

cc @ChrisPhillips1024 ☝


feat: add typescript types

with usage example in client.ts

Thanks a lot for adding types
LGTM 😊.
Merging pull request.

Hey @beenotung,
I've published a new version please check out here,
https://www.npmjs.com/package/open-google-translator.


Document the tcp_queue_length core check

What does this PR do?
Document the tcp_queue_length core check
Motivation
The tcp_queue_length core check has been implemented in GO with DataDog/datadog-agent#4619.
So, we need an entry in integration-core only for the metadata of the check.
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Hallo @L3n41c can you add this check in CODEOWNERS as owned by the container-integrations team?

Hello @hithwen ,
I’ve just added container-integrations as CODEOWNER of this check.


Add proper linting

Reason (Why?)
Use proper linting for higher codebase consistency and better maintainability.
Solution (What?)
Swap tslint for more universal eslint. Also use eslint standard rules for vue projects.
Acceptance criteria

Remove tslint
Use eslint
Run eslint and fix errors + warnings

closed by #302


WebAssembly prototype implementation

To better facilitate collaboration on our WebAssembly implementation, and have more iterative development, I'd like to merge our prototype into the Microsoft fork. Note that this is still not stable or complete, and it will change, frequently. Use is currently only available through WScript.LoadWasmFile in ch.exe (which uses the JsRunWasmScript JSRT API).

@dotnet-bot test this please

@MikeHolman
In .gitattributes, I think you should mark this as binary instead of -crlf
See: http://git-scm.com/book/en/v2/Customizing-Git-Git-Attributes

To keep things moving along, I'm going to merge this in (to the WebAssembly branch) so we can start putting in more changes on top. If you have any comments at this point, please open an issue.

Squashed and merged in: https://github.com/Microsoft/ChakraCore/commit/e44a8b287b04698f423787965201a3e7d0c1c820


No processing of clock and register reset

RegisterNode has only input and output ports currently, clock port should be added, and reset statement processing should be added to processStatement

Sorry, my mistake, I thought Reg(UInt()) would be initialized to 0 by default, but it was not.


Add new storage backend that supports writing via client

Suggestions for testing...
Add a new method to MongoAdapter:
@classmethod
def from_mongomock(cls, **kwargs)
    # This is similar to the classmethod from_uri but instead of connecting to
    # a real database it creates a mock, temporary one to use.
    client = mongomock.MongoClient()
    database = client["mock_database"]
    return cls(database, **kwargs)

Make a test file:
# databroker/tests/test_experimental.py

from tiled.client import from_tree

def test_saving_and_retreiving(tmpdir):
    tree = MongoAdapter.from_mongomock(directory=tmpdir)
    client = from_tree(tree)
    # Do things similar to the example from the recon gist.

running this locally the openapi documentation appears broken.
The error looks a bit obscure.
  File "/home/joseph/.local/opt/miniconda3/envs/aimm/lib/python3.9/site-packages/fastapi/utils.py", line 28, in get_model_definitions
    m_schema, m_definitions, m_nested_models = model_process_schema(
  File "pydantic/schema.py", line 617, in pydantic.schema.model_process_schema
  File "pydantic/schema.py", line 658, in pydantic.schema.model_type_schema
  File "pydantic/schema.py", line 258, in pydantic.schema.field_schema
  File "pydantic/schema.py", line 498, in pydantic.schema.field_type_schema
  File "pydantic/schema.py", line 925, in pydantic.schema.field_singleton_schema
  File "pydantic/schema.py", line 617, in pydantic.schema.model_process_schema
  File "pydantic/schema.py", line 658, in pydantic.schema.model_type_schema
  File "pydantic/schema.py", line 258, in pydantic.schema.field_schema
  File "pydantic/schema.py", line 563, in pydantic.schema.field_type_schema
  File "pydantic/schema.py", line 848, in pydantic.schema.field_singleton_schema
  File "pydantic/schema.py", line 748, in pydantic.schema.field_singleton_sub_fields_schema
  File "pydantic/schema.py", line 563, in pydantic.schema.field_type_schema
  File "pydantic/schema.py", line 922, in pydantic.schema.field_singleton_schema
  File "/home/joseph/.local/opt/miniconda3/envs/aimm/lib/python3.9/abc.py", line 123, in __subclasscheck__
    return _abc_subclasscheck(cls, subclass)
TypeError: issubclass() arg 1 must be a class

I checked that I don't get this for aimmdb or the basic tiled example tree so something is going on. Can anyone else reproduce?

Next step is to support the new queries added in tiled v0.1.0a63.

Add apply_mongo_query method to MongoAdapter, copied from databroker/mongo_normalized.py.
At the bottom of server_ext.py:

from tiled.queries import Eq

def eq(query, catalog):
    return catalog.apply_mongo_query({f"metadata.{query.key}": query.value})

MongoAdapter.register_query(Eq, eq)

Do this for Eq, Comparison, Contains, FullText, etc. Only do this for the queries in tiled/quieries.py. Do not worry about the qureies in databroker/queries.py because they are Bluesky-specific.


Mock resampled streams in test_formula_composition

... to decouple it from the resampler.  This needs to be generalized
and used in all the tests in a subsequent PR.

I wonder if this is something that can be added to the MockMicrogrid.

yes,  that's what I meant by "generalized", should have been more specific.  This PR can't be merged anymore,  but because the urgency has gone away as well,  I will do it in a separate PR next week.


Degradation code

Hi, thank you for sharing your code. I have a question: could you please share the degradation code and the reference sites you used for creating BD and BI degradations to make low resolution images? I would like to use your code to train my own model. Thank you!

Hi, we use matlab for degradation, I will organize the code and upload it shortly.

thanks for the reply, looking forward to it :)

Hi please check the matlab code for BD degradation under the dataset folder. For BI degradation, just change the degradation code to lq = imresize(gt, 1/scale, 'bicubic').


Diffs between what ships with Sketch and what builds with this repo

I just got the project building with the new instructions, but noticing a pretty dramatic difference between the file that ships with Sketch 40.3 (33839) and what builds.
The built js file has 1248 lines of code, while the file that ships with Sketch has 2111.

Looks like this is probably just due to changes

Getting more up to speed with the repo, it appears that the develop branch is much further along than master and is more aligned with what's shipping in Sketch today?

Yep. As we've explained on the comments of various issues, this is still a work in progress and so far we haven't really released the project.
I'll add a note to the README to clarify the status of the project, thanks for asking!

I understand that this is still a work in progress, I guess what I'm really getting at with this issue is trying to identify issues I think eager developer/designers like myself will run into when trying to figure out how best to provide community support and pull requests :)
If I may propose:

master is always the latest of what is shipping with Sketch.
develop is the latest of what's going into the next release of Sketch.
When a new release of Sketch is released, tag the repo with the corresponding version
Adding a contributor guide that outlines this, some common code conventions for the project, and the roadmap of things in the works that the community could contribute to.

I'm eager to contribute and see this get to a non-wip version 👍

It would be great if there's a note on the README to show the status of this API like bundled in Sketch.app or not and which version of Sketch has this API bundled in.

Out of interest, is there a way to force Sketch to run a less stable branch of the API?

@mattpfeffer the README outlines how to build the code with gulp and set the SketchAPILocation to point to your own SketchAPI file: https://github.com/BohemianCoding/SketchAPI#development

there is a branch for each release of Sketch if you need to check what is ship with each of them


Show warning about sending a test transaction when sending to new addresses

Description
When a user selects a raw address to send to, a warning about sending a test transaction is show before they proceed. The user has the option to turn off this warning forever. Currently there is no way to re-enable the warning after it has been disabled
Other changes
A recipient is added to the recent recipients list when a payment/invite is sent to them, not just when they have been selected from the RecipientPicker
Tested
tested in emulator

How others should test
When selecting a recipient, type in an address and select it. The warning does not appear for recipients selected from the recent recipient list
Related issues

Fixes #250

Backwards compatibility
yes

https://valora.testquality.com requirement R38.

Hi @MuckT We have verified this issue on Latest android build V1.16.0 & Testflight build V1.16.0(66) and updated the status in testqulaity tool.
Testquality tool link:
Android:

https://valora.testquality.com/project/12128/plan/20854/run/148956/result/2432160
iOS:
https://valora.testquality.com/project/12128/plan/20854/run/148956/result/2432188

Devices: Vivo v11 pro (10), iPhone 6+(12.4.5)
Query:

https://github.com/celo-org/wallet/issues/852
CC: @isabellewei

Hi @MuckT, We have verified this issue on Latest android build V1.16.0 in Android 11.0 and everything is working as expected.
Device Details: Google Pixel 4a(11.0)

https://valora.testquality.com defect D658.


Added Command Line golang ToDo-App.

This will I guess the first Command Line Todo tool on this repo :) I hope everything is up to speed and it was nice to learn about cockroachdb.

Thanks!


Allow user to specify outputPath and errorPath by basename

As discussed in PR #74, this PR allows user to specify a basename for the output and error path instead. The basename is then automatically completed to include the job id in the final filename.
For instance, to have workers write to /scratch/logs/workers.JOBID.out, one would create a cluster like so:
cluster = DRMAACluster(outputBasename='/scratch/logs/workers', errorBasename='/scratch/logs/workers')

Then cluster.template would contain 'errorPath': ':/scratch/logs/workers.$JOB_ID.$drmaa_incr_ph$.err'

Hmm...think I missed this discussion. Where was this proposed?

This was mentioned in PR #74. As it is now, I think it is pretty much impossible for users to specify the output/error paths without reading the source code first?
My use case is simply to allow me to easily write all the outputs to a specified directory. I'm open to implementing something more flexible and make another PR if you think this is better. Could you elaborate on your proposal?
Thanks!


Add support for picamera2

I'm trying to use a raspberry pi camera on Bookworm OS, where is no picamera only picamera2, but the Camera widget don't support picamera2.
I tried to use opencv or gi and I had partial success when I used them with libcamerafy, but the performance was very poor.

Hi @kelenorbert ,
As the picamera2 project looks pretty active, we can plan to have it in 3.0.0 if we find someone who have the opportunity to take care of this provider implementation.
Setting as feature request, if anyone is interested to work on it, please ping me, so we can assign the issue.


Simple Communication error

I get the errors "The type or namespace name 'System' could not be found".

This means that the NuGet packages didn't get pulled down properly. Try cleaning the project, then building again. Worst case, clean your %USERPROFILE%.nuget directory.


IOU - The paid IOU shows a message about the disabled category

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.25-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Preconditions:
In OldDot under admin, create a Collect group policy, enable categories and add 3 categories, add an employee to the policy.
Steps:

Open https://staging.new.expensify.com/
Log in to the employee's account
Tap on the green plus button (FAB)
Select Request money
Select any currency and amount
Click next
Choose a WS room
Click on "Show more"
In the "Category" section, select any category
Complete the IOU
Open https://staging.expensify.com/
Log in to the admin account
Navigate to the Collect group policy settings
In the category tab, disable the employee's selected category from step 9
Open https://staging.new.expensify.com/
in incognito mode.
Log in as an administrator
Go to the employee report and pay the IOU
Under the employee's account, open the IOU details

Expected Result:
The message about the disabled category should disappear after IOU payment
Actual Result:
The paid IOU shows a message about the disabled category
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/5d6871a0-97e9-4528-9e6d-cc65b2b44b4d
View all open jobs on GitHub

The message about the disabled category should disappear after IOU payment

This is not the expected behavior, so closing. Adding the source of expected behavior can be useful when logging bugs
Violations seem to be working correctly here, and they're behind a beta, so even if this wasn't the expected behavior, we shouldn't block on violations for the time being


Missing interactions for PMID:22918952

There are 3 physical interactions involving clp1 (SPAC1782.09c) that are shown on this publication page but aren't on the clp1 page:
http://pombase2.bioinformatics.nz/reference/PMID%3A22918952

FIxed when #216 was fixed.


Closes #7 Add support for Elixir Phoenix

@bkeepers All the commands are working except for strappy server.
Phoenix projects have a package.json file in the top directory and so the npm_server command is triggered.
$ ls
brunch-config.js  deps     mix.lock      package-lock.json  test
_build            lib      node_modules  priv               web
config            mix.exs  package.json  README.md

Would it be possible to make the npm_server check more specific?

Would it be possible to make the npm_server check more specific?

Definitely. Any suggestions on what the heuristics should be for detecting npm vs phoenix?

Definitely. Any suggestions on what the heuristics should be for detecting npm vs phoenix?

By default Phoenix doesn't define a npm start script so checking for that should be enough. I've added a check to the change.

Thanks @fapdash. I pushed a few fixes after testing it locally, but everything looks good now.


Review “Securing a cluster”

Page to review

What would you like to be added
https://kubernetes.io/docs/tasks/administer-cluster/securing-a-cluster/ mentions Kubernetes v1.7
Review this page, removing references to Kubernetes versions that are earlier than what's supported, and revising wording to suit.
Why is this needed
The documentation usually can and should assume that the reader is running a version of Kubernetes that is at least as new as the oldest version still supported.
Comments
/kind cleanup

/assign

/priority important-longterm


change registration service return values

This change is

SonarQube analysis reported 1 issue

 1 major

Watch the comments in this conversation to review them.


Update LICENSE

nvm, doesn't look like we need this.
https://github.com/apache/spark/blob/master/LICENSE#L189


Hangs on Prepare Forever

I haven't been able to get this to work - it just sits on Prepare endlessly.
"storybook-chrome-screenshot": "^1.0.1",

.storybook/config.js
import { setScreenshotOptions } from 'storybook-chrome-screenshot';

setScreenshotOptions({
  viewport: {
    width: 768,
    height: 400,
    deviceScaleFactor: 2,
  },
});

/stories.js
// @flow

import React from 'react';
import { MemoryRouter } from 'react-router-dom';
import { storiesOf } from '@storybook/react';
import { initScreenshot, withScreenshot } from 'storybook-chrome-screenshot';

import Nav from './index';

const location = { pathname: '/clients', hash: '', search: '' };

storiesOf('Nav', module)
  .addDecorator(story => <MemoryRouter initialEntries={['/']}>{story()}</MemoryRouter>)
  .add('primary', () => <Nav location={location} />)
  .addDecorator(initScreenshot())
  .addDecorator(withScreenshot());

Nevermind - I forgot to register this in addons!


ENH: plot adjacency

Reference issue
Fixes #10602.
What does this implement/fix?
This adds plot_ch_adjacency. Currently this is a clean-up, fixed version of what I had in my sarna repo. In matplotlib interactive mode it allows to edit the adjacency too:

Currently a bit more work is needed, see below:
TODOs:

[x] rename to plot_ch_adjacency
[x] 3d mode (kind='3d') should turn off edit mode as poistion of mouse clicks are not reliable in three dimensions in matplotlib
[x] currently if adjacency is sparse it is turned to array. This makes sense for convenient visualisation, but makes inplace modifications to the adjacency impossible (now a warning is raised, but this could be changed into an error when if we add a default of enable_edit=False.
[x] scale node size with number of connections
[x] change node size as number of connection changes during user interaction
[x] remove toolbar
[x] it should likely do something about channel types, now it just assumes all channels are of the same type
[x] it should additionally test if adjacency shape matches the number of channels available in the passed mne object.
[ ] tests

[x] basic 2d plotting
[x] 2d plotting interactivity
[ ] 3d mode
[ ] errors thrown

[ ] whats new
[ ] some example?

How to run
import mne
from mne.datasets import sample

data_path = sample.data_path()
meg_path = data_path / 'MEG' / 'sample'
raw_fname = meg_path / 'sample_audvis_filt-0-40_raw.fif'

raw = mne.io.read_raw_fif(raw_fname).crop(0, 5).pick('eeg').load_data()

# %%
adj, ch_names = mne.channels.find_ch_adjacency(raw.info, 'eeg')

# %%
mne.viz.topomap.plot_ch_adjacency(raw, adj, kind='2d')

to make the edits work in place, do adj = adj.toarray() before plotting adjacency.

for more context: I have found the option to manually edit the adjacency very useful in the past. The deafault triangularization done by mne often requires some manual corrections in my experience.

omg this is amazing!!!!
I never thought about "fixing" things manually. Could you give an example where you believe this might be useful?

I can look for some better examples but the changes I apply in the gif I pasted make sense (would have to confirm in 3d). BTW this is also what FieldTrip allows you to do.

This is off to an amazing start and more than I even wished for with the editing! Will look in more detail soon

@mmagnuski Thank you, it appears the animation didn't load properly for me first, hence I was confused :) But now I understand what you mean, and I have to say I'm almost slightly shocked as I realize I never thought of this problem before. I always just assumed that MNE would do "the right thing", but it's clear that it's not so clear what exactly the "right thing" would be in certain situations.
I'm wondering if find_ch_adjacency() should spit out a warning if the distance of two "adjacent" channels exceeds a certain threshold – this would help discover at least some of the problematic cases, I suppose?
Regarding your visualization:
Could we make it such that the size of each node is determined by the number of its edges / neighbors? This would make it easier to spot "well-connected" nodes and those who are rather "isolated".
Also I'm wondering if it could make sense to turn of the Matplotlib toolbar – I think all those buttons add unhelpful visual clutter – the only one I deem useful is the "Save" button, but it's not that we have one of those in all of our other visualizations either…

I always just assumed that MNE would do "the right thing", but it's clear that it's not so clear what exactly the "right thing" would be in certain situations.

True, in many cases it wouldn't change the cluster based test results much, I think, but I've had clear cases where adjacency built by mne was problematic. I moved to mne from FieldTrip so I already had the habit to always visualize the adjacency and correct if it was needed. I can also reassure you that manual correction of adjacency is not a quirk :), see for example description of how FieldTrip adjacency templates are created (from here):

EEG neighbour templates are based on automatic, symmetric triangulation of the 2D layout templates. After the automatic definition, we used 3D electrode positions and ft_neighbourplot with cfg.enableedit=’yes’ to manually add and/or remove edges between sensors.

BTW, FieldTrip and mne don't construct the adjacency exactly the same - FieldTrip does a union of two triangulations ("symmetric triangulation" in the description above), mne does only one. As a conseqence you can get adjacency like the one posted by @sappelhoff in FieldTrip:

but in mne you wouldn't get "crossed" adjacency relations (which in the case above clearly makes sense) as only one triangulation is performed. But all these adjacency-creation issues can be discussed in a separate issue thread, I think.

Could we make it such that the size of each node is determined by the number of its edges / neighbors? This would make it easier to spot "well-connected" nodes and those which are rather "isolated".

Sure, I can add it. I never actually liked that option in FieldTrip (channels on the cap edges always have less connections and I didn't like that these nodes are drawn smaller :)), so maybe we could allow to turn it off with scale_nodes=False for example?

Also I'm wondering if it could make sense to turn off the Matplotlib toolbar – I think all those buttons add unhelpful visual clutter – the only one I deem useful is the "Save" button, but it's not that we have one of those in all of our other visualizations either…

Definitely, I'll change that!

I can add enable_edit=False default so that no edits can be made unless user explicitly asks for this.

@hoechenberger I've changed node size (it scales with number of connections), now it looks like this:

Super nice!!

I've added some checks for ch_type but since I rarely had to handle data with multiple channel types, I'm not very good with handling types in mne, so please let me know how to do it better.
If everyone is ok with it, I will add enable_edit=False by default (this is a mirror of FieldTrips enableedit, but I can use a more mne'sqe name for that ) and option to disable node scaling (scale_nodes).
One thing I'm still thinking about is that find_ch_adjacency returns the adjacency and ch_names, so instead of checking for ch_type etc. maybe its better to require passing ch_names to plot_ch_adjacency and just do inst.copy().pick_channels(ch_names, ordered=True) and it will handle all the checks for me.

If everyone is ok with it, I will add enable_edit=False by default (this is a mirror of FieldTrips enableedit, but I can use a more mne'sqe name for that ) and option to disable node scaling (scale_nodes).

sounds good!
regarding a potential example of this code in the docs, you could try to replace the plot here: https://mne.tools/stable/auto_tutorials/stats-sensor-space/75_cluster_ftest_spatiotemporal.html#find-the-fieldtrip-neighbor-definition-to-setup-sensor-adjacency with your new feature :thinking:
unless you want to explicitly show the interactivity in a GIF or so.

One thing I'm still thinking about is that find_ch_adjacency returns the adjacency and ch_names, so instead of checking for ch_type etc. maybe its better to require passing ch_names to plot_ch_adjacency and just do inst.copy().pick_channels(ch_names, ordered=True) and it will handle all the checks for me.

Is there ever a situation where one would want to plot adjacencies across channel types?

unless you want to explicitly show the interactivity in a GIF or so.

Good, I'll update that example, and the gif and description interactivity options etc. I can add to a separate example in a next PR.

Is there ever a situation where one would want to plot adjacencies across channel types?

I don't think so. But using the ch_names instead of ch_type should be both simpler (handles multiple checks "for free") and more stringent (makes sure channels are in the same order in the mne object and adjacency matrix). Also constructing adjacency already requires ch_type argument and returns ch_names - so the ch_names will be always from the same type.
I think I convinced myself, and I'll change the optional ch_type to requred ch_names. :)

I would suggest to call the parameter edit or editable, no? :)

I don't think so. But using the ch_names instead of ch_type should be both simpler (handles multiple checks "for free") and more stringent (makes sure channels are in the same order in the mne object and adjacency matrix). Also constructing adjacency already requires ch_type argument and returns ch_names - so the ch_names will be always from the same type.
I think I convinced myself, and I'll change the optional ch_type to requred ch_names. :)

right, you also convinced me!

Ok, edit argument is now added, and the checks are simplified thanks to ch_names. I also got used to the node scaling, so I think I won't add an argument to turn it off. The only remaining things are tests (ouch), editing an example and whats new. I'll get to that tomorrow.

@larsoner Thanks, I know - its corrected now.
I've also already requested @sappelhoff review. :)
argh, and I forgot to correct one style issue...

@mmagnuski note also that I pushed a small fix, so remember to pull before continuing your work :wink:

Thanks @sappelhoff !
I will add the remaining tests today.
I don't get the error I'm getting on Circle:
Added  32 HTML plot_* redirects for auto_tutorials
Added  99 HTML plot_* redirects for auto_examples
Added  52 HTML custom redirects
Added "af386b75aa4a59e1766e64459fef97cde5160466" > _version.txt
make: *** [Makefile:70: html_dev-noplot] Error 1
make: Leaving directory '/home/circleci/project/doc'

Exited with code exit status 2
CircleCI received exit code 2

Looks like CircleCI is green. When you see that error, though, try searching for "warning" because we treat warnings as errors, as they usually indicate some problem with RST syntax

yeah, the circle error was a warning because you had "figure" as a type in a docstr, not "Figure" -- and only "Figure is defined as an alias in conf.py :-)

Ha, indeed, I refreshed the page and now its all green. @sappelhoff For some reason I saw the error in the last commit, after you fixed the figure problem.

@sappelhoff How do I pull these changes now? I looked online but I only found advice on how to create a PR or fetch someone else's PR...

Ok, I got it, I tried pulling from origin, not my fork, now it works.

Okay, great -- I would have thought that a simple git pull works :)

I also get this on CIs:
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.4/x64/bin/mne", line 33, in <module>
    sys.exit(load_entry_point('mne==1.1.dev0', 'console_scripts', 'mne')())
  File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/mne-1.1.dev0-py3.10.egg/mne/commands/utils.py", line 107, in main
    cmd.run()
  File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/mne-1.1.dev0-py3.10.egg/mne/commands/mne_sys_info.py", line [32](https://github.com/mmagnuski/mne-python/runs/6530498348?check_suite_focus=true#step:8:33), in run
    mne.sys_info(show_paths=options.show_paths, dependencies=dependencies)
  File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/mne-1.1.dev0-py3.10.egg/mne/utils/config.py", line 616, in sys_info
    out(f' {{backend={mod.get_backend()}}}')
  File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/matplotlib/__init__.py", line 1170, in get_backend
    return rcParams['backend']
  File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/matplotlib/__init__.py", line 672, in __getitem__
    plt.switch_backend(rcsetup._auto_backend_sentinel)
  File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/matplotlib/pyplot.py", line 268, in switch_backend
    switch_backend(candidate)
  File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/matplotlib/pyplot.py", line 288, in switch_backend
    class backend_mod(matplotlib.backend_bases._Backend):
  File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/matplotlib/pyplot.py", line 289, in backend_mod
    locals().update(vars(importlib.import_module(backend_name)))
  File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/matplotlib/backends/backend_qtagg.py", line 9, in <module>
    from .qt_compat import QT_API, _enum, _setDevicePixelRatio
  File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/matplotlib/backends/qt_compat.py", line 1[37](https://github.com/mmagnuski/mne-python/runs/6530498348?check_suite_focus=true#step:8:38), in <module>
    _setup()
  File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/matplotlib/backends/qt_compat.py", line 91, in _setup_pyqt5plus
    from PyQt6 import QtCore, QtGui, QtWidgets, sip
RuntimeError: the sip module implements ABI v13.0 to v13.3 but the PyQt6.QtCore module requires ABI v13.4
matplotlib:          3.5.2
Error: Process completed with exit code 1.

Also, the tutorial fails because MEG names are different between adjacency and read epochs file:

The read adjacency uses the following names:
['MEG0111',
 'MEG0121',
 'MEG0131',
...

while the epochs file contains such .ch_names:
['MEG 0111',
 'MEG 0121',
 'MEG 0131',
...

I'm not sure what's the preferred fix here:

automatically change channel naming to mne python convention when reading FieldTrip adjacency
fix the adjacency we distribute with mne

I think I'd prefer

automatically change channel naming to mne python convention when reading FieldTrip adjacency

I'd also prefer this but I'm not sure if the pattern I see in this case is universal. Do we always name these MEG channels including the space?

This is a problem for the neuromag sensors apparently. We have two neighbor files for these:

neuromag306mag_neighb.mat
neuromag306planar_neighb.mat

for both of them, the names are organized as:
>> load /home/stefanappelhoff/Desktop/bids/mne-python/mne/channels/data/neighbors/neuromag306mag_neighb.mat
>> neighbours.label
ans = MEG0111
ans = MEG0121
ans = MEG0131
ans = MEG0141
ans = MEG0211
ans = MEG0221

>> load /home/stefanappelhoff/Desktop/bids/mne-python/mne/channels/data/neighbors/neuromag306planar_neighb.mat
>> neighbours.label
ans = MEG0113
ans = MEG0112
ans = MEG0122
ans = MEG0123
ans = MEG0132
ans = MEG0133
ans = MEG0143
ans = MEG0142
ans = MEG0213
ans = MEG0212

if MNE-Python uses the same names but with a space between MEG and the 4-digit number, then I think you could for now hardcode the space in read_ch_adjacency so that the neighbor template names and the epochs names are the same.
As for the other templates: Maybe they are not a problem, let's cross that bridge when we reach it. We don't even have that many templates, and for EEG, these are not used by default.
Wdyt @larsoner?

Ok, I can do a small fix now and check the FieldTrip neighbour conventions vs mne in a next PR to see if we can solve it more generally.

Potentially last step - enhancing the visuals
This is how the adjacency looks for this MEG template:

Let me know if you think the visuals should be tweaked.
I think for example that the head outline gets a bit lost among these lines.
Changing the adjacency color makes it a little better, I think:

Another option is to also change the adjacency line width:

I like the adjustment of the line width. Maybe adding a little bit of transparency to the nodes (alpha 0.6 or so) could help too?

wow this looks super good! I was expecting it to be much more messy :-)

I like the adjustment of the line width.

+1

Maybe adding a little bit of transparency to the nodes (alpha 0.6 or so) could help too?

Good idea, I'll test that.

adding alpha of 0.7 to the nodes and removing their linewidth:

I have a general question as to the definition of adjacency here. In the following figure (taken from your screenshot above), I totally see how the green edges point to neighbors of the green node. But I think one could debate whether the nodes connected via the red edges are neighbors of the same kind, no? Shouldn't at least some sort of (reduced) weight be applied here? Or am I just getting confused as we're looking at a 2D projection of a 3D mesh?

BTW the viz looks great!

I think this is a case where projecting to 2d just looks weird, but I'm working on the 3d mode now, so I'll post a screenshot soon (BTW plotting sensors from info with mne.viz.plot_sensors(info, ...) and using the pos field of info['chs'] gave different 3d positions, may be related to different coordinates (head vs not head)? I felt it may be another pandora box so I use the plotted point positions in 3d now).

but I agree that the red connections could be removed :)

I think I'll disable node scaling in 3d mode, I get weird matplotlib errors:
TypeError: only integer scalar arrays can be converted to a scalar index

Traceback (most recent call last):

  File "C:\Users\Admin\.conda\envs\mne\lib\site-packages\IPython\core\formatters.py", line 341, in __call__
    return printer(obj)

  File "C:\Users\Admin\.conda\envs\mne\lib\site-packages\IPython\core\pylabtools.py", line 151, in print_figure
    fig.canvas.print_figure(bytes_io, **kw)

  File "C:\Users\Admin\.conda\envs\mne\lib\site-packages\matplotlib\backend_bases.py", line 2295, in print_figure
    self.figure.draw(renderer)

  File "C:\Users\Admin\.conda\envs\mne\lib\site-packages\matplotlib\artist.py", line 73, in draw_wrapper
    result = draw(artist, renderer, *args, **kwargs)

  File "C:\Users\Admin\.conda\envs\mne\lib\site-packages\matplotlib\artist.py", line 50, in draw_wrapper
    return draw(artist, renderer)

  File "C:\Users\Admin\.conda\envs\mne\lib\site-packages\matplotlib\figure.py", line 2810, in draw
    mimage._draw_list_compositing_images(

  File "C:\Users\Admin\.conda\envs\mne\lib\site-packages\matplotlib\image.py", line 132, in _draw_list_compositing_images
    a.draw(renderer)

  File "C:\Users\Admin\.conda\envs\mne\lib\site-packages\matplotlib\artist.py", line 50, in draw_wrapper
    return draw(artist, renderer)

  File "C:\Users\Admin\.conda\envs\mne\lib\site-packages\mpl_toolkits\mplot3d\axes3d.py", line 451, in draw
    for artist in sorted(collections_and_patches,

  File "C:\Users\Admin\.conda\envs\mne\lib\site-packages\mpl_toolkits\mplot3d\axes3d.py", line 440, in do_3d_projection
    return artist.do_3d_projection()

  File "C:\Users\Admin\.conda\envs\mne\lib\site-packages\matplotlib\_api\deprecation.py", line 386, in wrapper
    return func(*inner_args, **inner_kwargs)

  File "C:\Users\Admin\.conda\envs\mne\lib\site-packages\mpl_toolkits\mplot3d\art3d.py", line 614, in do_3d_projection
    self._sizes = self._sizes3d[z_markers_idx]

TypeError: only integer scalar arrays can be converted to a scalar index

<Figure size 432x432 with 1 Axes>

although you can see z_markers_idx is an array of int...
%debug
> c:\users\admin\.conda\envs\mne\lib\site-packages\mpl_toolkits\mplot3d\art3d.py(614)do_3d_projection()
    612
    613         if len(self._sizes3d) > 1:
--> 614             self._sizes = self._sizes3d[z_markers_idx]
    615
    616         if len(self._linewidths3d) > 1:

z_markers_idx
[ 81  80  79  65  72  88  78  97  71  89  64  62  77  94  73  76  96  87
  70  86  63  74  56  61  75  95  60  92 100  69  93  84  55  68  58  57
  85 101  59  91  99  66  90  67  54  83  82  27   7   3  26  98   6  48
  52  15  49   2  14  40  41   4  24   0  25  53  47   5  51  12   1  46
  13  39  38  22  11  37  50  43   9  10  44  23  45  36  21   8  42  19
  20  35  32  34  16  31  18  33  29  17  30  28]

type(z_markers_idx)
<class 'numpy.ndarray'>

z_markers_idx.dtype
int64

but not changing the alpha and linewidths of the points in 3d allows matplotlib to change it dynamicaly based on perspecitve and the depth is easier to understand then:

so I think I'll set the alpha and linewidths for the nodes only in 2d.

another one in 3d without linewidths:

I'd say for 3d the dynamic adjustment based on perspective is preferrable --- but for 2d it's nice with alpha and line-width adjustments hardcoded

but I agree that the red connections could be removed :)

wouldn't that rather be a different PR that is having a go at the delaunay triangulations?

wouldn't that rather be a different PR that is having a go at the delaunay triangulations?

Oh, yes, I wouldn't change the template. I think the template is very good in general and these red connections may be a matter of preferrence and one could change them manually with edit=True.

I'd say for 3d the dynamic adjustment based on perspective is preferrable --- but for 2d it's nice with alpha and line-width adjustments hardcoded

Great, I'll leave it for 2d, that's for sure. But I'm not certain which one to pick for 3d: linewidth or no linewidths? :) (the last two plots, one in a separate comment)

I like it better when the markers don't have additional lines :-)

also @hoechenberger:

Shouldn't at least some sort of (reduced) weight be applied here?

That is not possible in conventional clustering - channels either are neighbours or not. But one can reasonably remove these connections now with edit=True. Generally, sticking with the templates that FieldTrip distributes is good for cross-package consistency, but these templates may change from time to time on FT side (that's what they say in their docs), so we could check if they are still the same.

so we could check if they are still the same.

I had a look, they were last updated 10 years ago: https://github.com/fieldtrip/fieldtrip/tree/master/template/neighbours

I've added a see also section, but I should do something additional to make the rendered docstring use links for these function names (the same way it looks here in the "see also" section). Do you have a hint?

ok, I think I know :)

https://output.circle-artifacts.com/output/job/e63439a6-50e9-40eb-a1ca-81423ea379c6/artifacts/0/dev/auto_tutorials/stats-sensor-space/75_cluster_ftest_spatiotemporal.html#find-the-fieldtrip-neighbor-definition-to-setup-sensor-adjacency

This is a really great addition, thanks @mmagnuski and @sappelhoff !

Thanks @mmagnuski :tada: :rocket:

Thanks @sappelhoff @hoechenberger @agramfort ! 🚀


Upgrading the pytorch logo to the 2018 version

This is just a cosmetic change!

@JosephKJ Thanks a lot joseph!


Running behind proxy fails to build package

Our build environment is only able to access the internet via proxies.
The environment variables http_proxy, htts_proxy and no_proxy are defined so that curl, bundler and wget can access the internet as needed.
However, building the debian package with pkgr package fails at the following step:
-----> Compiling Ruby/Rails
-----> Using Ruby version: ruby-2.3.4
-----> Installing dependencies using bundler 1.16.0
       Running: bundle install --without development:test --path vendor/bundle --binstubs vendor/bundle/bin -j4 --deployment
       Warning: the running version of Bundler is older than the version that created the lockfile. We suggest you upgrade to the latest version of Bundler by running `gem install bundler`.
       Fetching source index from https://rubygems.org/
       Retrying fetcher due to error (2/4): Bundler::HTTPError Could not fetch specs from https://rubygems.org/
       ....

Ater 4 retries the process aborts.
When enabling the --debug option I can see the following output when triggering the heroku-ruby-buildpack:
...
DEBUG: Running "env -i PATH=\"$PATH\" TARGET=debian:8 BUILDPACK_NODE_VERSION=\"0.6.8\" /home/user/.pkgr/buildpacks/builtin/7f03e5472376de1229ddab91b5cb7b0b9c1f3e33/heroku-buildpack-ruby/bin/compile \"/tmp/d20180129-21812-q3gnct/opt/project\" \"/tmp/d20180129-21812-q3gnct/opt/project/.git/cache\" \"/tmp/d20180129-21812-10zp41w\" "

My assumption is that pkgr initiates the buildpack without transfering the environment from the current process to the buildpack. To verify my assumption, I tried to inject some debugging output into a fork of the buildpack used by pkgr for ruby projects, but encountered some problems.

Yes, pkgr uses a clean env to avoid any pollution from the current environment, typically to avoid any existing ruby version on the system to be picked up while running the buildpack.
You should indeed use the --env flag to pass any env variables that need to be used by the subprocesses.


add option to make headline text uppercase

This feature is for the EMPHATIC among us. (Also sorry about small oddities where my vim config seems to have stripped out whitespace).

Nice! Does this make the headline uppercase or both source + headline?

#18: Added a source uppercase toggle as well


Catch up joining nodes in the PASSIVE state before promotion to ACTIVE

Copycat servers that join the cluster as ACTIVE members are currently immediately added to the configuration in the ACTIVE state. This can cause a loss of availability in certain cases while the new node is being caught up to the leader. For example, if a second node is added to a one node cluster, if the new node immediately becomes a voting member, new writes to the cluster will be blocked until the new node is caught up. For this reason, nodes are typically added in a PROMOTABLE state wherein they are caught up before they are promoted to a full voting member of the cluster.
To be done correctly, this should be done by adding an additional PROMOTABLE node type/state to the Copycat cluster. PASSIVE nodes don't necessarily fit this role well since they receive only committed entries from followers. PROMOTABLE nodes should run in the passive state and receive all entries from the leader. Once a PROMOTABLE node has caught up to the leader's commitIndex, either the leader should promote it or it should promote itself via the leader.

How do I increase the ability of test case to improve the algorithm on PassiveStateTest？


chore: upgrade prism-react-renderer to v2

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation
prism-react-renderer v2 is available
Test Plan
N/A
Test links
Deploy preview: https://deploy-preview-9316--docusaurus-2.netlify.app/
Related issues/PRs

Also we'll need some notes to explain users how to handle this breaking change. Can you write down some notes to explain what users should do when upgrading, and link to relevant external resources explaining breaking changes in depth?

@slorber where should this go?

Also we'll need some notes to explain users how to handle this breaking change. Can you write down some notes to explain what users should do when upgrading, and link to relevant external resources explaining breaking changes in depth?

@slorber where should this go?

I usually put a ## Breaking changes section at the top of each PR with some notes and external ref links.
This makes it easier to aggregate all those notes into the final v3.0 blog post on release. It doesn't have to be super polished but please note down things that we might have forgotten in a few weeks, and that Docusaurus users should be aware of when upgrading ;) Links to upgraded packages release notes and breaking change docs can be useful for example.
See for example PRs listed in v3 beta:
https://github.com/facebook/docusaurus/releases/tag/v3.0.0-beta.0

Apparently we have some pages that produce errors now 😅

Try:

https://localhost:3000/tests/pages/markdown-tests-mdx
https://localhost:3000/docs/markdown-features/code-blocks

I'll take another look. I can't reproduce it locally for some reason

now I can't reproduce error TS2578: Unused "@ts-expect-error" directive. error locally...

Seems to be working now
But our visual regression tests tool reports many unexpected changes to syntax highlighting:
https://app.argos-ci.com/meta-open-source/docusaurus/builds/247/60618995
Will investigate.
@carloskelly13 any idea what could be happening here?

LGTM thanks 🎉 will be in Docusaurus v3


Japanese: translate LH_AUTH_NG again

It regressed to English in #1122.

Could you squash the commits, please?

Squashed.

Thanks.

@metalefty @davidebeatrici keep in mind that goal of these messages is to be caught by Fail2Ban.
If you translate them, Fail2Ban jail won't work anymore.
I then think they should be kept in english.

I've been worked on blacklistd(8), a similar product of fail2ban, of BSD.  I would say fail2ban relies on scraping human-oriented logs too much.
Not translating logs only for fail2ban is a bad idea and spoils the user experience because the log is also for humans. I think users who want to use fail2ban should set the language settings to English otherwise we should also introduce machine-oriented logs for fail2ban like:
LH_AUTH_NG_F2B   [fail2ban] AUTH_NG: CID="%S", USER="%S", CLIENT_IP="%S"

Then we can be friendly both to humans and fail2ban.

I think users who want to use fail2ban should set the language settings to English

I then think that's the proper solution if we want all messages to be translated (so this PR to be merged).
A specific fail2ban message, is, well, too specific IMO, as, as you said, there are other blacklisting solutions.
Let's go like this then if all messages must be translated 👍

how we go further ? should we merge it ?

As far as I observe, many Japanese users want Japanese messages as much as possible if the language is set to Japanese. I would like to go this way. Translate as much as possible and add some machine-friendly log messages for machine-reading purposes.


15B, 30B, 65B

May I ask when will the larger model be released?
Is there a schedule (15B, 30B, 65B) for reference?

They'll first have to fix 3B and 7B model performance before training larger ones.

There's no currently public scheduled plans, but rest assured it's all very actively in the works. As the user above noted, the focus is on quality before scale.


Commons collections

Just get some tests running in Travis

Ok looks like Travis didn't run so I will Test this bad boy locally.

Tests failing so putting this on hold for now.

All Unit tests are passing.  Haven't run the ITs yet.

I think this is good finally so I will merge.

I am seeing this warning... Is this what you are referring to?
[INFO] --- maven-assembly-plugin:3.0.0:single (binary-assembly) @ accumulo ---
[INFO] Reading assembly descriptor: src/main/assemblies/binary-release.xml
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o  'commons-collections:commons-collections'

I didn't try a build to see the warning. But yeah, it's warning of the same thing I was talking about.
The assembly descriptor references a set of components to include in the tarball. That list contains dependencies of the assemble module. The above warning indicates that the commons-collections:commons-collections artifact can't be found among the assemble module's dependencies and wasn't included. The reason is because it was replaced with the new groupId/artifactId... we just need to update the component.xml file to have the correct new groupId/artifactId for commons-collections.