PaxHeader files in app package tarball fails deployment

While doing the quick start tutorial, I did it following the guide and it work. Then, I opened the files to see what were in them (album-recommendation-selfhosted) and retried the quick start guide but an error appeared.
As you can see in this screenshot, ".root.xml" is trying to be parsed but the prefix . is causing the parser to throw.

Work notes:
https://github.com/vespa-engine/sample-apps/blob/master/album-recommendation-selfhosted/src/main/application/search/query-profiles/types/root.xml has the correct name.
I then followed the steps in https://docs.vespa.ai/en/vespa-quick-start.html - all worked fine
Can you please check this?
$ ls -la src/main/application/search/query-profiles/types/ total 8 drwxr-xr-x  3 kraune  staff   96 May 12 17:22 . drwxr-xr-x  4 kraune  staff  128 May 12 17:22 .. -rw-r--r--  1 kraune  staff  614 May 12 17:22 root.xml

Here's the output:
drwxr-xr-x  3 ADAM  1000   96 12 May 12:54 .
drwxr-xr-x  5 ADAM  1000  160 12 May 12:56 ..
-rw-r--r--@ 1 ADAM  1000  614 12 May 12:54 root.xml
I believe it's the sam

interesting! so either there is something wrong with the tar / gzip combo, or something breaks on the vespa size when unzipping. I hope you can help by just creating the tar file / untar it and see - and maybe zip the tar file and make it available for our download?

here the zip tar file : application.tar.gz

thanks! the archive looks right. looking at options ...

I am able to replicate:
$ curl --header Content-Type:application/x-gzip --data-binary @/Users/kraune/Downloads/application.tar.gz localhost:19071/application/v2/tenant/default/prepareandactivate
{"error-code":"INVALID_APPLICATION_PACKAGE","message":"Invalid application package: default.default: Error loading model: Could not parse '._root.xml', error at line 1, column 1: Content is not allowed in prolog."}
just curious: can you try using zip instead of gzip (ref https://cloud.vespa.ai/en/getting-started for how to create the zip) - and deploy with Content-Type:application/zip ?

CC @jonmv / @hmusum https://docs.vespa.ai/en/cloudconfig/deploy-rest-api-v2.html

I think that's what you wanted me to do?

not really, you have to create the .zip file as in the cloud guide and POST it like
curl --header Content-Type:application/zip --data-binary @application.zip localhost:19071/application/v2/tenant/default/prepareandactivate

it worked!

Thanks for the help!

great news! I will keep this ticket open for my own investigation to compare the tar files. Thanks for reporting!

diff-ing your and my tar files:
$ diff --test err/e.tar ok/o.tar
diff: unrecognized option `--test'
diff: Try `diff --help' for more information.
 Copyright Verizon Media. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. -->
---
> ./schemas/000755<PHONE_NUMBER>24<PHONE_NUMBER>0<PHONE_NUMBER>3 013300 5ustar00kraunestaff000000 000000 ./search/000755<PHONE_NUMBER>24<PHONE_NUMBER>0<PHONE_NUMBER>3 013122 5ustar00kraunestaff000000 000000 ./search/query-profiles/000755<PHONE_NUMBER>24<PHONE_NUMBER>0<PHONE_NUMBER>3 016110 5ustar00kraunestaff000000 000000 ./search/query-profiles/types/000755<PHONE_NUMBER>24<PHONE_NUMBER>0<PHONE_NUMBER>3 017254 5ustar00kraunestaff000000 000000 ./search/query-profiles/default.xml000644<PHONE_NUMBER>24<PHONE_NUMBER>3<PHONE_NUMBER>3 020263 0ustar00kraunestaff000000 000000 <!-- Copyright Verizon Media. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. -->
93,94c93
< ./search/query-profiles/types/._root.xml000644<PHONE_NUMBER>24<PHONE_NUMBER>0<PHONE_NUMBER>3 021160 0ustar00kraunestaff000000 000000 Mac OS X        	2~?ATTR???com.apple.lastuseddate#PS?`ă?./search/query-profiles/types/PaxHeader/root.xml000644<PHONE_NUMBER>24<PHONE_NUMBER>5<PHONE_NUMBER>3 022714 xustar00kraunestaff000000 000000 29 mtime=1620838499.50353989
< ./search/query-profiles/types/root.xml000644<PHONE_NUMBER>24<PHONE_NUMBER>6<PHONE_NUMBER>3 020747 0ustar00kraunestaff000000 000000 <!-- Copyright Verizon Media. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. -->
---
> ./search/query-profiles/types/root.xml000644<PHONE_NUMBER>24<PHONE_NUMBER>6<PHONE_NUMBER>3 020763 0ustar00kraunestaff000000 000000 <!-- Copyright Verizon Media. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. -->
107c106
< ./schemas/music.sd000644<PHONE_NUMBER>24<PHONE_NUMBER>4<PHONE_NUMBER>3 014740 0ustar00kraunestaff000000 000000 # Copyright Verizon Media. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
---
> ./schemas/music.sd000644<PHONE_NUMBER>24<PHONE_NUMBER>4<PHONE_NUMBER>3 014754 0ustar00kraunestaff000000 000000 # Copyright Verizon Media. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
148c147
<
\ No newline at end of file
---
>
\ No newline at end of file

I am not the tar expert, but this seems to be a problem with a PaxHeader file - I don't yet fully understand why one tar file got it and not the other, but Vespa should extract the tar correctly regardless, @jonmv

https://stackoverflow.com/questions/34688392/paxheaders-in-tarball

review some docs in  https://github.com/vespa-engine/documentation/pull/1326

https://docs.vespa.ai/en/reference/application-packages-reference.html#deploy is updated a long time ago, use zip, not tar/gzip - and I could not find any examples of tar/gzip use in doc/sample apps - closing


Feature: Allow basic configuration of more features by cli

It should be possible to configure basic features of clusters and logging by using command line flags, when using init or append, should also be used when using run without a configuration file.
Remember to update documentation, and --help

Fixed


Docker compose create one more bee instance can not receive peers

Docker compose create one more bee instance can not receive peers

Story
Docker compose create one bee instance with default settings, it can works well, and after a while, testing with curl localhost:1635/peers, a lot of peers show.
But create a new bee instance with docker compose with different ports, every port plus 4, for instance, the p2p addr port 1638, the debug api port 1639.
The bee instance starts up and pass the initial geth payout. after a while (even long time, 4 hours and more), the log of the bee instance:
bee-1_1   | time="2021-05-04T23:44:35Z" level=warning msg="discover to bootnode /dnsaddr/bootnode.ethswarm.org"
bee-1_1   | time="2021-05-04T23:45:07Z" level=warning msg="connect to bootnode /ip4/<IP_ADDRESS>/tcp/31309/p2p/16Uiu2HAmLe8hu7N9cnkY4BjwjtdfsPzYLoebk5rUbHsiYKvMpBHW"
bee-1_1   | time="2021-05-04T23:45:07Z" level=warning msg="discover to bootnode /dnsaddr/bootnode.ethswarm.org"
bee-1_1   | time="2021-05-04T23:45:39Z" level=warning msg="connect to bootnode /ip4/<IP_ADDRESS>/tcp/31309/p2p/16Uiu2HAmLe8hu7N9cnkY4BjwjtdfsPzYLoebk5rUbHsiYKvMpBHW"
bee-1_1   | time="2021-05-04T23:45:39Z" level=warning msg="discover to bootnode /dnsaddr/bootnode.ethswarm.org"
bee-1_1   | time="2021-05-04T23:46:10Z" level=warning msg="connect to bootnode /ip4/<IP_ADDRESS>/tcp/31301/p2p/16Uiu2HAmHgthsmN99SDMaApv5XY2YaCLeU9gkrPWBzRWBCaLPphs"
bee-1_1   | time="2021-05-04T23:46:10Z" level=warning msg="discover to bootnode /dnsaddr/bootnode.ethswarm.org"
bee-1_1   | time="2021-05-04T23:46:42Z" level=warning msg="connect to bootnode /ip4/<IP_ADDRESS>/tcp/31302/p2p/16Uiu2HAmMxanzFwGspp7dvpZymTSF28w4x2qbbqd9EmzC75dPiYB"

Check the debug api peers, it returns a empty list.
curl localhost:1639/peers

Acceptance criteria

Background

version: "3"

services:
  clef-1:
    image: ethersphere/clef:0.4.9
    restart: unless-stopped
    environment:
      - CLEF_DATA
      - CLEF_CHAINID
    volumes:
      - clef-1:/app/data
    command: full

  bee-1:
    image: ethersphere/bee:latest
    restart: unless-stopped
...

I use the latest version bee image.
Tasks

Task
Assignee
Done (1), or 0

Hey,
Thank you for trying out Bee!
This is most likely a problem with the configuration of your docker-compose. It would be best if you join our community  on Discord, to see if people can help you out there.
https://discord.gg/sU8NEtaR8y


#2301 - Feature/join org us11.1

What does this pull request aim to achieve? 💯
Add New Applicant checkbox in Notification
Please be concise and link any related issue(s):

[V ] I have checked that no one else is working on similar changes.
[V ] I have read the latest README and understand the development workflow.
[V] The name of this branch is: feature/<branch_name> for a regular feature, hotfix/<branch_name> for a hotfix, and service/<branch_name> for a microservice, where <branch_name> briefly describes the issue(s) resolved and is prefixed with the issue number(s) (e.g. 1127-1130-update-git-branching-model). The branch is created in a cloned version of this repo, not a forked repo.
[V] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[V] There are no merge conflicts.
[V] There are no console warnings and errors.
[V] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".
[V] The title describes the issue(s) being addressed using format: <issue_numbers> - <brief_issue_description> (e.g. #1127/#1130 - Update Git Branching Model)

@aditilamkhede I already fix the issue, please review it.

@aditilamkhede I already fix the issue, please review it.

@ChunPingYang I saw the New applicant checkbox in Individual user profile and it is not visible in Organization profile.
It should be implemented vice a versa.

@aditilamkhede I already fix the issue, please review it.

@ChunPingYang I saw the New applicant checkbox in Individual user profile and it is not visible in Organization profile.
It should be implemented vice a versa.

@aditilamkhede I already fix the issue, please review it.

@ChunPingYang I saw the New applicant checkbox in Individual user profile and it is not visible in Organization profile.
It should be implemented vice a versa.

How do you test my code ? I run my code and show the view as what I expected.

@aditilamkhede I already fix the issue, please review it.

@ChunPingYang I saw the New applicant checkbox in Individual user profile and it is not visible in Organization profile.
It should be implemented vice a versa.

@aditilamkhede
How do you test my code ? I run my code and show the view as what I expected.

@ChunPingYang your branch has conflict, please resolve those conflicts. then we might have to redeploy your changes.

@ChunPingYang  When i try to switch account in help board page between individual account and organisation account an error message is populated.

@ChunPingYang looks fixed but changing the value of new applicant doesn't reflect newly changed value.

 I ONLY SEE THE NEW APPLICANT BOX on orgn page.

As a requirement "GIVEN the org admin is in the ‘Notifications’ page/screen WHEN they toggle on the ‘New Applicant’ THEN they must receive email notifications whenever a new application comes through."  Yes the new applicant button is working as a expected but email notifications is not working whenever a new application comes trough. I tried that a few times.

temporarily closed for troubleshooting


[SPARK-31395][CORE]reverse preferred location to make schedule more even

What changes were proposed in this pull request?

Let scheduler read preferred location reversely,
for instance,
block locations
[xxx.93. xxx.100 xxx.02]
[xxx.93 xxx.102 xxx.04]
[xxx.93 xxx.66 xxx.05]
for now, the executors in xxx.93 will firstly be scheduled, then executors in other locations,
after modification
the scheduling result is more even.
It is more obvious in small clusters.
Why are the changes needed?

because such a hot spot is unnecessary
Does this PR introduce any user-facing change?

No
How was this patch tested?

Manually test

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@ChenjunZou Can you explain why and how it schedule evenly? I can't follow why. Also, please keep the Github PR template (https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE).

@ChenjunZou Can you explain why and how it schedule evenly? I can't follow why. Also, please keep the Github PR template (https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE).
Thanks for reminding that.

TaskSetManager will first seek the free executors in xxx.02 xxx.04 xxx.05,  then executors in xxx.93 because they are process_locality level.
After that, It schedules to higher locality level.

spark.shuffle.reduceLocality.enabled

thanks for reminding me that, I will watch the pr.

Hi @ChenjunZou , you can disable spark.shuffle.reduceLocality.enabled if you don't want locality prefer scheduling.
Or you may consider about some certain workloads where throughput is affected by delay scheduling? If so, you may interested at this PR #27207.

thanks for reminding me that, I will watch the pr.

Closing this - seems you just want to don't take the locality into account, which is already possible by the configuration spark.shuffle.reduceLocality.enabled or spark.locality.wait

Closing this - seems you just want to don't take the locality into account, which is already possible by the configuration spark.shuffle.reduceLocality.enabled or spark.locality.wait

@HyukjinKwon
I don't think spark.shuffle.reduceLocality.enabled or spark.locality.wait is enough to solve my scenario.
Because my locality skew happens in the map stage,
Second I already set scheduler.locality.wait to 0.
It still has a hot spot.

@zsxwing
can you have a look.

If that's the case, we should fix the configurations to take the locality into account, rather than reversing the hosts. @ChenjunZou, please clarify why and how reversing the hosts can resolve your problem.
From what you said, reversing will just switch the hot spot nodes to happen.

If that's the case, we should fix the configurations to take the locality into account, rather than reversing the hosts. @ChenjunZou, please clarify why and how reversing the hosts can resolve your problem.
From what you said, reversing will just switch the hot spot nodes to happen.

@HyukjinKwon
The root cause is the model, or the data is written from a single node. ( xxx.93 for instance)
So as the HDFS writing pipeline, the client firstly writes to xxx.93, plus another two nodes.
the preferred locations are like that:
[xxx.93. xxx.100 xxx.02]
[xxx.93 xxx.102 xxx.04]
[xxx.93 xxx.66 xxx.05]
When spark schedules tasks.
the executors in xxx.93 are always preferred by spark scheduler.  other executors rarely get tasks when they are all busy. The single hot spot should be avoided.
besides, I agree to add configurations.

From what you said, reversing will just switch the hot spot nodes to happen.

the write pipeline is various。
It could be any two nodes。
the hot spot will be alliviated。

So are you saying you have 3 replica in three nodes and Spark job is only being executed in one specific node because of the locality? Then, how does reversing hosts help?
You shouldn't use our driver as a cluster ideally. In production you should better use cluster mode for such reason.
You're arguing that one specific case the driver and executor exist in one specific note together, and the workload is heavy in the specific node. What if the last node has both driver and executor? Reversing hosts doesn't solve anything.

this pr is not something important.
It just wants to reduce the possibility that a single node to be an unnecessary hot spot.

Thanks for your explanation @HyukjinKwon
I have 2 questions more.

You shouldn't use our driver as a cluster ideally.

what  does this mean.

In production you should better use cluster mode for such reason.

Actually I use the cluster mode. if I use client mode, the client writes HDFS block will be even.
single node hot will not happen.

What if the last node has both driver and executor?

that is unrelated.  the PROBLEM is:
the first location of all blocks will always be the same xxx.93. which made scheduler try executors in that node first.

If there's a cluster, and the block is being written into single node only, seems an issue in HDFS then.

In the runtime it is something like
xxx.93 (driver)
Starting task 0.0 in stage 0.0 (TID 0, xxx.93,executor
Starting task 1.0 in stage 0.0 (TID 1, xxx.93, executor
Starting task 2.0 in stage 0.0 (TID 1, xxx.93, executor
Starting task 3.0 in stage 0.0 (TID 1, xxx.93, executor
Starting task 4.0 in stage 0.0 (TID 1, xxx.93, executor
Starting task 5.0 in stage 0.0 (TID 1, xxx.63, executor
Starting task 6.0 in stage 0.0 (TID 1, xxx.102, executor
the executors in xxx.93 are scheduled more preferably.

If there's a cluster, and the block is being written into single node only, seems an issue in HDFS then.

The client which is in HDFS data nodes, will write a copy to itself.  That is a common behavior.
I am glad we get some common knowledge here :)

Reversing hosts doesn't solve anything.

not limited to reverse. shuffle is OK.

No~ I think you said you faced this issue when you run the applications in a cluster mode where the driver runs on a different node. This is initially what I meant.

What cluster mode do you use? If xxx.93 (driver) is a driver, and the problem is that the data is copied into that node, you should separate the driver out of the HDFS cluster or use Yarn cluster mode to evenly distribute in production.
What I am saying is, how reserving hosts can solve the problem. The last node xxx.102, executor can be a driver too.

you still don't understand I mean. ~
I use yarn cluster mode, xxx.93 is a node RM pick randomly for me to run driver on it.
and the executors also in node xxx.93 is more preferred to be scheduled to execute tasks.
Because I write some data in the driver's code and then do some RDD calculation.

No~ I think you said you faced this issue when you run the applications in a yarn cluster mode where the driver runs on a different node. This is initially what I meant.

I agree.  xxx.93 is what you said of "a different node".

The last node xxx.102, executor can be a driver too.

I agree that node xxx.102 could also be a hot spot too.

@ChenjunZou How can you make sure that front nodes in the reversed list are available to serve tasks? What if others are busy except xxx.93?
And what if the location lists are
[xxx.100 xxx.02 xxx.93]
[xxx.102 xxx.04 xxx.93]
[xxx.66  xxx.05 xxx.93]

then, do you still prefer "reverse" here?
IMO, the status of scheduling is quite complex and undermined at runtime. So, I don't think such "reverse" could solve the problem.
And I do think that you should try #27207 firstly as it really ease the problem you mentioned here.

@Ngone51
I only want is to make the schedule more even with minor effort.
I also said it may not reverse, shuffle is ok.
the reverse is because hdfs write pipeline gives enough randomness.

What if others are busy except xxx.93?

It schedules to xxx.93.
It is about fairness.  If the writing process is a single point spot. The scheduler may add some random condition for schedule fairness.


Add "Buy Me a Coffee" Button

Hi
You've been working on an amazing plugin, and I couldn't find any alternatives to it. I believe some people would be willing to donate to support the plugin.

Hi @vkamenski , thank you for your kindness and the interests to this plugin! it encourages me a lot. I will add the button when I could give more time to maintain this project, currently I am busy with something else and hopefully it will end in a month.


[BUG] - Component created from extendVariants cannot be used as a JSX component

NextUI Version
2.6.4
Describe the bug
As I understand it, due to the change in the ReactElement interface in React 19, an error occurs in determining the type of component when creating your own styles through the extendVariants function.
When using @types/react version 18.3.12
interface ReactElement<P = any, T extends ...>

When using @types/react version 19.0.1
interface ReactElement<P = unknown, T extends ...>

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Using these library versions, try to create any component with custom styles through the extendVariants function. An error occurs - 'Component' cannot be used as a JSX component.
{
  "name": "project",
  "version": "1.0.0",
  "private": true,
  "scripts": {
    "dev": "next dev",
    "build": "next build",
    "start": "next start --hostname <IP_ADDRESS>",
    "lint": "next lint"
  },
  "browserslist": [
    "defaults"
  ],
  "dependencies": {
    "@nextui-org/react": "^2.6.4",
    "@nextui-org/use-infinite-scroll": "^2.2.1",
    "clsx": "^2.1.1",
    "framer-motion": "^11.13.1",
    "next": "^15.0.4",
    "react": "^19.0.0",
    "react-dom": "^19.0.0"
  },
  "devDependencies": {
    "@types/node": "^22.10.1",
    "@types/react": "^19.0.1",
    "@types/react-dom": "^19.0.1",
    "autoprefixer": "^10.4.20",
    "cssnano": "^7.0.6",
    "cssnano-preset-advanced": "^7.0.6",
    "eslint": "^9.16.0",
    "eslint-config-next": "^15.0.4",
    "postcss": "^8.4.49",
    "tailwindcss": "^3.4.16",
    "typescript": "^5.7.2"
  }
}

Expected behavior
I think this is an error in the extendVariants function type declaration and need to specify ReactElement<any> there.
Screenshots or Videos
No response
Operating System Version
Any
Browser
Chrome

I studied the source code of the extendVariants function in a little more detail. It looks strange to me that in the type declaration, the function returns ForwardRefRenderFunction type, although in fact in extend-variants.js the ForwardedComponent is returned, which is obtained as a result of the forwardRef call, and the returned type must be ForwardRefExoticComponent.
If I understand everything correctly, the actual declaration of the ExtendVariants type should be as follows.
type ExtendVariants = {
  <
    C extends JSXElementConstructor<any>,
    CP extends ComponentProps<C>,
    S extends ComponentSlots<CP>,
    V extends ComposeVariants<CP, S>,
    SV extends SuggestedVariants<CP, S>,
    DV extends DefaultVariants<V, SV>,
    CV extends CompoundVariants<V, SV>,
  >(
    BaseComponent: C,
    styles: {
      variants?: V;
      defaultVariants?: DV;
      compoundVariants?: CV;
      slots?: S;
    },
    opts?: Options,
  ): ForwardRefExoticComponent<
    PropsWithoutRef<{
      [key in keyof CP | keyof V]?:
        | (key extends keyof CP ? CP[key] : never)
        | (key extends keyof V ? StringToBoolean<keyof V[key]> : never);
    }> &
      RefAttributes<ReactElement>
  >;
};

can you provide a simple sandbox for reproducing the issue and a PR for us to review?

@wingkwong I will try to do it soon

@wingkwong Check the reproduction of the error in my codesandbox. In the app/page.tsx file you can see the ts error I'm talking about. And in utils/extendVariants.ts, a correction of the data type is presented.
I also made a pull request #4291 with data type corrections.

+1, also does anyone know when will this be released?

+1, wait for further notification

also waiting for this release

+1, having the same issue


Add a forwarded_ports capability

This reports the forwarded_ports in use by the VM

is it implemented in fog ?

@pronix I honestly do not know.  I am new to vagrant and libvirt.  I needed this for parity with a virtualbox image.  Can you point me toward fog and I am happy to look?

this patch working for you ?

I tested it using a plugin I am working on and it returned the values as expected.

ports are forwarded ?

All this does is allow the forwarded_ports capability to be used to report what ports are forwarded .. port forwarding was already working

This is similar to a cap provided by virtualbox

I not understand what doing your patch.
add description to readme, please

I believe the idea is to allow other plugins to query which ports have been forwarded based on checking the provider capabilities first to see if it can provide this information to do something with them, rather than checking if the provider is libvirt do x, virtualbox do y, docker do z, etc.

@electrofelix has the correct answer.  However, I have discovered a bug in my patch and am going to be traveling for a few days.  So please give me some time to rework it.


[Enhancement] Add EmptyView property

It would be great if an EmptyView property was added which can take in a ContentView that is shown whenever there are no items or no items left. Basically, Tinder saying like: "you swiped through all your matches, come back later".

This is a cool idea! I will add it to the new features list. Thanks!

If I can find some time I will see to contribute something(s) myself 🙂

Is there any support for multiple ItemTemplate, and then use the DataTemplateSelector to choose which DataTemplate to display.
I want to insert adverts every 5 cards and that has a different layout.

Imho an 'empty' card should be handled by the application programmer by pushing one at the end of the stack and disable any functionality in the bindings by checking whether it's the end card, instead of being built into the component (which would complicate it unnecessarily). The app programmer also has a choice of adding a UI element below the deck that gets drawn when the deck is empty, while hiding the swipe view when empty.
The recent fixes to swipe view will set TopItem to null when the deck is empty, making it easy to use bindings to detect this (something like IsVisible={Binding TopItem, Source={x:Reference myDeck}, Converter={StaticResource IsNullConverter / IsNotNullConverter}}.


chore(main): release 3.12.0

:robot: I have created a release beep boop
3.12.0 (2024-12-17)
Features

Create sync-config.yml (110fc61)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v3.12.0
:sunflower:


Fix format

@changeworld : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


WIP: Feature/tellor

This is a work in progress PR to add tellor as one of the oracles on oracles.club. This will be ready in tandem with a forthcoming pr to the server repo:
https://github.com/Dragonfly-Capital/oracles.club.server
this pr includes:

new tellor.html page
tellor links added to the navigation
metadata tag updates

keeping this as a draft until the server pr is ready.

Just realized this will conflict with https://github.com/Dragonfly-Capital/oracles.club/pull/6
if that is going to be merged I can work off that instead.

Dependent on this server repo PR:
https://github.com/Dragonfly-Capital/oracles.club.server/pull/1


[HOLD for payment 2024-08-07] Free trial badge displayed in LHN

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721304565430729
Action Performed:

Create a new account and select Track and Budget Expenses onboarding task.
This will result in a task for Track an expense.
Create a new workspace.

Expected Result:
The task report in LHN should not show Free trial badge. The parent Concierge or Expensify chat should show the badge.
Actual Result:
Free trial badge displayed in LHN. when the onboarding chat is Concierge , the tasks created within the Concierge report (e.g. Track an Expense ) will also displays the Free trial badge.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/bc3c16cd-4dda-4cc4-8c82-405f538935d0

View all open jobs on GitHub

@twisterdotcom I will raise a PR for this as mentioned in slack conversation here

does this need a C+ review @rojiphil ? I was assigned to the PR

Well! Not sure since this is an easy fix. @mountiny Can you weigh in here?

@twisterdotcom Can we please process the payment here since the fix has been in production for 2 weeks as mentioned here

Payment Summary:

@rojiphil paid $250 via Upwork here (C+)


Allow auto merge for AWS SDK packages

I think we can allow auto merge for minor upgrades.
Seeing the changelog, it rarely does breaking changes:
https://github.com/aws/aws-sdk-js-v3/blob/main/CHANGELOG.md

It seems like the auto-merge config is changed in the config which this repo depends on:

https://github.com/int128/typescript-action-renovate-config/pull/15

And it affected the auto-merge eligibility for AWS SDK packages:

https://github.com/quipper/monorepo-deploy-actions/pull/863 (Enabled)
https://github.com/quipper/monorepo-deploy-actions/pull/866 (Disabled)

This is fixed in:

https://github.com/quipper/monorepo-deploy-actions/pull/868


Error installing 1.3.6 in MacOSX10.14

Hey, I'm trying to install sqlite 1.3.6 (1.4.0 works just fine) in MacOSX10.14 with ruby 2.6.0 and running into an error, how can I fix this?
~ % gem install sqlite3 -v 1.3.6
Building native extensions. This could take a while...
ERROR:  Error installing sqlite3:
	ERROR: Failed to build gem native extension.

    current directory: /Users/haroon/.asdf/installs/ruby/2.6.0/lib/ruby/gems/2.6.0/gems/sqlite3-1.3.6/ext/sqlite3
/Users/haroon/.asdf/installs/ruby/2.6.0/bin/ruby -I /Users/haroon/.asdf/installs/ruby/2.6.0/lib/ruby/site_ruby/2.6.0 -r ./siteconf20190226-1207-1spp42e.rb extconf.rb
checking for sqlite3.h... yes
checking for sqlite3_libversion_number() in -lsqlite3... yes
checking for rb_proc_arity()... yes
checking for sqlite3_initialize()... yes
checking for sqlite3_backup_init()... yes
checking for sqlite3_column_database_name()... yes
checking for sqlite3_enable_load_extension()... no
checking for sqlite3_load_extension()... no
checking for sqlite3_open_v2()... yes
checking for sqlite3_prepare_v2()... yes
checking for sqlite3_int64 in sqlite3.h... yes
checking for sqlite3_uint64 in sqlite3.h... yes
creating Makefile

current directory: /Users/haroon/.asdf/installs/ruby/2.6.0/lib/ruby/gems/2.6.0/gems/sqlite3-1.3.6/ext/sqlite3
make "DESTDIR=" clean

current directory: /Users/haroon/.asdf/installs/ruby/2.6.0/lib/ruby/gems/2.6.0/gems/sqlite3-1.3.6/ext/sqlite3
make "DESTDIR="
compiling backup.c
compiling database.c
database.c:205:3: warning: 'sqlite3_trace' is deprecated: first deprecated in macOS 10.12 [-Wdeprecated-declarations]
  sqlite3_trace(ctx->db, NIL_P(block) ? NULL : tracefunc, (void *)self);
  ^~~~~~~~~~~~~
  sqlite3_trace_v2
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/sqlite3.h:2952:36: note: 'sqlite3_trace' has been explicitly marked deprecated here
SQLITE_API SQLITE_DEPRECATED void *sqlite3_trace(
                                   ^
1 warning generated.
compiling exception.c
compiling sqlite3.c
compiling statement.c
statement.c:262:11: warning: implicit declaration of function 'RBIGNUM' is invalid in C99 [-Wimplicit-function-declaration]
      if (RBIGNUM_LEN(value) * SIZEOF_BDIGITS <= 8) {
          ^
./sqlite3_ruby.h:16:24: note: expanded from macro 'RBIGNUM_LEN'
#define RBIGNUM_LEN(x) RBIGNUM(x)->len
                       ^
statement.c:262:11: error: member reference type 'int' is not a pointer
      if (RBIGNUM_LEN(value) * SIZEOF_BDIGITS <= 8) {
          ^~~~~~~~~~~~~~~~~~
./sqlite3_ruby.h:16:36: note: expanded from macro 'RBIGNUM_LEN'
#define RBIGNUM_LEN(x) RBIGNUM(x)->len
                       ~~~~~~~~~~  ^
statement.c:262:32: error: use of undeclared identifier 'SIZEOF_BDIGITS'
      if (RBIGNUM_LEN(value) * SIZEOF_BDIGITS <= 8) {
                               ^
1 warning and 2 errors generated.
make: *** [statement.o] Error 1

make failed, exit code 2

Gem files will remain installed in /Users/haroon/.asdf/installs/ruby/2.6.0/lib/ruby/gems/2.6.0/gems/sqlite3-1.3.6 for inspection.
Results logged to /Users/haroon/.asdf/installs/ruby/2.6.0/lib/ruby/gems/2.6.0/extensions/x86_64-darwin-18/2.6.0-static/sqlite3-1.3.6/gem_make.out

I encountered this same issue on Ubuntu 18.04.  Installing v1.4.0 succeeds, but installing v1.3.6 yields the above error.
If you're trying to install v1.3.6 to satisfy Rails 5.2.2 (related: rails/rails#35154), you might try v1.3.13 instead.  Rails 5.2.2 requires sqlite3 "~> 1.3.6", and I was able to install v1.3.13 without any problems.

I encountered this same issue on Debian 9.8.
gem install sqlite3
Building native extensions.  This could take a while...
ERROR:  Error installing sqlite3:
	ERROR: Failed to build gem native extension.
    current directory: /var/lib/gems/2.3.0/gems/sqlite3-1.4.0/ext/sqlite3
/usr/bin/ruby2.3 -r ./siteconf20190307-8587-z0x7ny.rb extconf.rb
mkmf.rb can't find header files for ruby at /usr/lib/ruby/include/ruby.h
extconf failed, exit code 1
Gem files will remain installed in /var/lib/gems/2.3.0/gems/sqlite3-1.4.0 for inspection.
Results logged to /var/lib/gems/2.3.0/extensions/x86_64-linux/2.3.0/sqlite3-1.4.0/gem_make.out

gem install sqlite3 -v 1.3.6
Building native extensions.  This could take a while...
ERROR:  Error installing sqlite3:
	ERROR: Failed to build gem native extension.
    current directory: /var/lib/gems/2.3.0/gems/sqlite3-1.3.6/ext/sqlite3
/usr/bin/ruby2.3 -r ./siteconf20190307-8745-1hpb01a.rb extconf.rb
mkmf.rb can't find header files for ruby at /usr/lib/ruby/include/ruby.h
extconf failed, exit code 1
Gem files will remain installed in /var/lib/gems/2.3.0/gems/sqlite3-1.3.6 for inspection.
Results logged to /var/lib/gems/2.3.0/extensions/x86_64-linux/2.3.0/sqlite3-1.3.6/gem_make.out

Where you able to figure out the problem? I'm dealing with the same thing.

Same problem here, any updates?

thank @isopen work like magic

We're working on shipping precompiled native gems as well as increasing test coverage for people who want to use system libraries. If you're curious please follow #320.


Charging Schedule

Is your feature request related to a problem? Please describe.
It is possible in the Volvo (Android) app to configure a charging schedule, even for PHEV vehicles.
It would be nice if it was possible to control this via volvo2mqtt so that we can set a schedule based on for example the amount of sun that there will be in that day (charge when there is a lot of solar overproduction).
Describe the solution you'd like
Maybe there is an API to set this, as the app can also do it?
Additional context
If there is no API for this available, then of course this is not possible.

No sorry, there is no API endpoint available. But you are able to automate this behavior with HA automations.

How so? By connecting your charging station to HA? Since there is no toggle on car level to start/stop the charging?

Yes, indeed you need a charging station which is HA compatible.

Ok, I thought so unfortunately. Still need to make a little project of that, since my Alfen Pro Line isn't supported by HA out of the box. So I will have to do some modbus stuff for it to work.
Thanks for the quick reply man, appreciated!
This ticket can then be closed.


Test Landsat 7 Scan Line Masking

This paper used Landsat 7 NDVI by masking:
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6544617/
L7 (perhaps cross referenced with L8) is the ideal dataset for us as it spans 2000-2020 - a good balance between time series length, and sensor quality.
We should implement their masking technique and cross reference with L8 data.

The scan line errors in L7 images, pictured above, pose a bit more of a problem for offest50 calculations than for the NDVI value. We should be able to mask using 0 pixel locations (similar to cloud masking).

In fact, our current cloud masking is already rejecting sub-images with scan lines in them: for example the following sub images are currently rejected:

So in fact nothing needs to be done, unless we want specifically to get a bit more information by using the masking exactly for the NDVI, rather than rejecting entire sub-images


Feature: recognize binary device tree structures

(Binwalk v2.1.1)
$ file k_and_dtb
k_and_dtb: Device Tree Blob version 17, size=36983, boot CPU=0, string block size=2291, DT structure block size=34636

$ binwalk k_and_dtb

DECIMAL       HEXADECIMAL     DESCRIPTION
--------------------------------------------------------------------------------

DTB signatures and extraction are supported in Binwalk v3 :)


Add support for messagepack

Description
This pull request implements fetching data from InfluxDB using msgpack serialization instead of JSON. This fixes issues related to serialization ambiguities in JSON, and makes database queries faster. It does not break compatibility with older influxdb versions that do not support msgpack.
Related issues
Closes #733
Fixes #665
Fixes #715
Fixes #625
Performance
Here is a performance comparison before (JSON) and after (msgpack) this pull request, for a simple SELECT * request on a measurement with 2 tags and three fields of types: integer, float and string:

Using msgpack gives a ~25% speedup.

@aviau Is it ok now ?

@aviau I think this is ready for merging.

I will look at this as soon as I have time, thanks!

@aviau : Did you have the time to look at it ?

Can someone please review that ?

@aviau Can you find a few minutes to review that and merge it if it's ok ?

For the love of god someone please check this in!

@xginn8: Maybe you can review this ?

What shall I do to have this reviewed ? This is a PR that gives a 25% speedup to the library and fixes multiple issues, and no one seems to be interested.
@russorat maybe ?

@lovasoa oh wow, this is awesome. Sorry for taking so long here. I'll find someone to review this. While I do that, could you sign the CLA agreement https://influxdata.com/community/cla/ ?

Hooray ! Thank you.

So sorry for the delay @lovasoa, but we REALLY appreciate your contribution here. I'm going to look around at some other PRs and build up a release candidate shortly.

the hard lock on 0.6.1 prevents this from being integrated with other solutions.

Oh yes, the dependency requirement should be updated. @prometheanfire, you should make a pull request. But good luck for getting it merged: mine took 5 months before someone finally looked at it.

ya, that seems to be common for oneliners.  The amount of time it takes to merge is inversely proportional to the size of the patch.

Mine (#734) wasn't a one-liner, although it wasn't huge either.

true, I've had the same issue with pins or capping with others though (salt and boto off the top of my head).


After leaving the cluster to run for two days, flynn-host ps returns nothing

I cant run flynn create either, it returns with: httpclient: unexpected status 503.
Debug info 1
Debug info 2

How many nodes in the cluster?

5
On 5 Apr 2015 20:13, "Jonathan Rudenberg"<EMAIL_ADDRESS>wrote:

How many nodes in the cluster?
—
Reply to this email directly or view it on GitHub
https://github.com/flynn/flynn/issues/1405#issuecomment-89833039.

Okay, this looks like "cluster collapse" due to a combination of issues with etcd, discoverd, and flynn-host that I'm currently working on resolving. #1373 will resolve this.

@titanous Thanks. Please how do I restart the cluster without loosing data under this scenario?

If the postgres server is still running, you should find it and take a dump of your app databases directly. After doing that, you can try stopping flynn-host on all nodes and then starting it on all nodes. If that doesn't resolve the issue, a clean re-install is probably the next step.

OK. Thanks.
On 7 Apr 2015 12:37 am, "Jonathan Rudenberg"<EMAIL_ADDRESS>wrote:

If the postgres server is still running, you should find it and take a
dump of your app databases directly. After doing that, you can try stopping
flynn-host on all nodes and then starting it on all nodes. If that doesn't
resolve the issue, a clean re-install is probably the next step.
—
Reply to this email directly or view it on GitHub
https://github.com/flynn/flynn/issues/1405#issuecomment-90284814.


fix 4.3.0 haxe version

https://github.com/HaxeFlixel/flixel/issues/2780#event-9073694321 thanks for @Geokureli for the fix

Interesting

@JonnycatMeow why was this closed?

@Geokureli i deleted my psych engine fork and so it closed the pull request

i will reopen


Out of memory when using long stack traces

Please answer the questions the best you can:

What version of bluebird is the issue happening on?  3.4.6

What platform and version? (For example Node.js 0.12 or Google Chrome 32)  Node 4.6.1

Did this issue happen with earlier version of bluebird?  unknown

With long stack traces turned on, memory consumption increases dramatically causing my server to be OOM-killed in production multiple times per hour, whereas without long stack traces this is a rare occurrence (under similar load).  The server uses generator-based coroutines extensively, using either co or bluebird-co (tried both, same results).
If this is expected it might be a good idea to update the docs since those only mention a performance penalty.  I certainly expected a bit higher memory usage (since those extra stack frames need to be stored, after all) but nothing this dramatic.
If it's not expected, I can try to dig deeper to figure out what combination of usage patterns causes this issue.

Sounds like this might be related: https://github.com/petkaantonov/bluebird/issues/1080

It does sounds similar but I'm not sure I have any long recursive promisified chains in my code.  The closest I can think of is the one below (in firelease), but the promise chains are item-specific and those are either fairly short-lived or rarely-extended.  But perhaps the aggregate effect is large enough.
  item._lease.extendLeasePromise =
    (item._lease.extendLeasePromise || Promise.resolve()).catch().then(function() {
      ...
    });


.d.ts file for --web target does not define the init() function

Describe the Bug
Compiling a module with --web will create a .d.ts, which contains the TypeScript types for all the functions exposed by the module.
The typings for the init() function, the default export, are missing.

I will work on it


training way of domain adaptation

Hi, author, thank you for your excellent work! I would like to know how can I employ this baseline for domain adaptive person re-id. In other words, what's the way of network training for cross domain and what's the difference with direct transfer (models trained on source domain are tested on target domain)?

You can train and test the model with different datasets. For example:
Train:
DATASETS:
  NAMES: ('market1501')

Test (Load the model trained on Market):
DATASETS:
  NAMES: ('dukemtmc')
TEST.WEIGHT:
  ('your path to trained checkpoints')

You also can modified the config file for more convenience.

You can train and test the model with different datasets. For example:
Train:
DATASETS:
  NAMES: ('market1501')

Test (Load the model trained on Market):
DATASETS:
  NAMES: ('dukemtmc')
TEST.WEIGHT:
  ('your path to trained checkpoints')

You also can modified the config file for more convenience.

Can you explain in detail how to modify the config file to achieve training on the B dataset on the A dataset?


Monorepo support

As suggested here, it would be useful to have the option to differentiate between multiple projects within the same repository when posting changelogs.
I think the most plausible solution is to pass some text on the command line which is appended before the title of the release, such as --project "Foo". This would create a title of Foo vX.X.X. Alternatively, more customization of the ordering could be given using some sort of format string.
Obviously, if the option is omitted then the behavior would be the same as it is now.

I forgot to mention, the generated assets on the releases tab contain the entire github repo instead of build artifacts per package. Should be good to provide extra documentation about this in some example.
Cheers!

Looking at that link you sent, maybe it'd be better to add more comprehensive support for monorepos instead of just the changelog titles.

The docs are a little thin, but there's at least some basic support for multiple projects in a repo -- https://python-semantic-release.readthedocs.io/en/latest/automatic-releases/github-actions.html#multiple-projects mentions having multiple projects setup in different directories already -- and I could see a separate changelog being generated in each directory easily enough, but I imagine this would create conflicts with the tags and GH versions?
I guess configuring a different tag_format in the config for each project within the directory structure would handle tags Ok - and that would presumably also handle the release name as well.
If the goal is to have a single changelog and releases, but multiple "things" internally, figuring out the "right" behavior could get pretty complicated.

Still in backlog

Still in backlog


Increase stability in resources/extract-platform.sh

error handling in  resources/extract-platform.sh needs to be improved

:tada: This issue has been resolved in version 0.31.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 0.31.1 :tada:
The release is available on:

npm package (@release-0.31.x dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add PSA file to API

What this PR does / why we need it:
Add PSA file to the API, this is needed to configure PSA when CIS profile is set

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://github.com/rancher/cluster-api-provider-rke2/issues/457
Special notes for your reviewer:
Checklist:

[ ] squashed commits into logical changes
[ ] includes documentation
[ ] adds unit tests
[ ] adds or updates e2e tests

@alexander-demicev looks like this needs a rebase


Getting system up and going instructions

Summary of the Pull Request
Script to get VS to install all needed components

References

PR Checklist

[x] Applies to #2933, #2296
[x] CLA signed. If not, go over here and sign the CLA

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

any other feedback?


Fix removing nested components

@dxvladislavvolkov
Any idea when this might get merged and v19.2.6 release might happen?


[MINOR][DOCS] Update spark.yarn.driver.memoryOverhead and spark.yarn.executor.memoryOverhead in the tuning-guide.

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request

The parameters spark.yarn.driver.memoryOverhead and spark.yarn.executor.memoryOverhead are out of date. After Apache Spark 2.3.0, they were replaced by spark.driver.memoryOverhead and spark.executor.memoryOverhead respectively.

Check out this link for details :
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkConf.scala#L706-L709

Brief change log
Verify this pull request
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@yihua，Thanks your review.


Roll engine db60ebc6325c..e0e0ac0a6802 (23 commits)

https://github.com/flutter/engine/compare/db60ebc6325c...e0e0ac0a6802
git log db60ebc6325c..e0e0ac0a6802 --first-parent --oneline
2019-12-12<EMAIL_ADDRESS>[testing] Make vsync waiters pluggable in shell_unittests (flutter/engine#14463)
2019-12-12<EMAIL_ADDRESS>Use futures to images used for comparison with fixtures in embedder unit-tests. (flutter/engine#14465)
2019-12-12<EMAIL_ADDRESS>[testing] Move test vsync waiters to their own TUs (flutter/engine#14456)
2019-12-12<EMAIL_ADDRESS>Roll src/third_party/skia 51b99659ed82..c514e7d9be6e (13 commits) (flutter/engine#14457)
2019-12-12<EMAIL_ADDRESS>Fix type in build_fuchsia_artifacts (flutter/engine#14452)
2019-12-12<EMAIL_ADDRESS>Refactoring text editing. Strategy pattern is used to handle different browser/operating system and a11y behavior. (flutter/engine#14131)
2019-12-12<EMAIL_ADDRESS>Roll src/third_party/dart d9fa37e85d5c..45db29709547 (48 commits) (flutter/engine#14453)
2019-12-12<EMAIL_ADDRESS>Remove unused _TypeNone enum field. (flutter/engine#14440)
2019-12-12<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from otkJA... to SlgE8... (flutter/engine#14407)
2019-12-12<EMAIL_ADDRESS>Smart quote/dash configuration support in iOS (flutter/engine#13863)
2019-12-12<EMAIL_ADDRESS>[flutter_runner] Enable Skia tracing by default on Fuchsia (flutter/engine#13457)
2019-12-12<EMAIL_ADDRESS>Roll src/third_party/skia 3517aa7b14ad..826484f2631f (18 commits) (flutter/engine#14375)
2019-12-12<EMAIL_ADDRESS>[tests] Use distinct begin and end times (flutter/engine#14361)
2019-12-12<EMAIL_ADDRESS>objcdoc fix for some ambiguity (flutter/engine#14367)
2019-12-11<EMAIL_ADDRESS>Fix CGMutablePathRef memory leaks when the path is invalid. (flutter/engine#14275)
2019-12-11<EMAIL_ADDRESS>Fix missing API stream when record event in systrace (flutter/engine#14323)
2019-12-11<EMAIL_ADDRESS>Fix missing timeline event of flutter engine's startup time (flutter/engine#14319)
2019-12-11<EMAIL_ADDRESS>Assert that arc end caps on canvases with root surface transformations are drawn correctly. (flutter/engine#14359)
2019-12-11<EMAIL_ADDRESS>Conditionally use offscreen root surface only when needed
2019-12-11<EMAIL_ADDRESS>Add ability to control dithering on Paint (flutter/engine#13868)
2019-12-11<EMAIL_ADDRESS>Remove duplicate and outdated src/third_party/dart/tools/sdks entry from DEPS. (flutter/engine#14340)
2019-12-11<EMAIL_ADDRESS>Roll src/third_party/skia 75799967be60..3517aa7b14ad (3 commits) (flutter/engine#14345)
2019-12-11<EMAIL_ADDRESS>[fuchsia] Move async_get_default_dispatcher include to the header (flutter/engine#14351)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://github.com/flutter/flutter/runs/346750427

Commit queue failed; closing this roll.


Amendment - Update Peergos pricing

Type
Amendment

Changes
Minor update to Peergos item to reflect updated pricing plan

Supporting Material
Plans shown on signup tab of https://peergos.net/

Affiliation
I work on Peergos project

Checklist

[x] I have read the Contributing guide, and confirmed my PR aligns with the requirements
[x] I have performed a self-review (valid Markdown formatting, spelling, and grammar)
[x ] I have indicated whether I have any affiliation with any software / services added
[x ] I agree to follow the repositories Contributor Covenant Code of Conduct

So all the data is located in awesome-privacy.yml - the readme is just auto-generated using that data, same as the website.
So I'll close this and just update the YAML file.


User feedback for "doesn't look right" is difficult to access

Format as email to<EMAIL_ADDRESS>

This is a dupe of #8 :)


[release-4.12] Bug OCPBUGS-5403: Make sure LB status is updated immediately

This is a cherry-pick of #161

/approve

/retest

@MaysaMacedo @eurijon Looks like 4.13 bug is verified now and this can go forward.

/lgtm
/label backport-risk-assessed

/label cherry-pick-approved


Explain the need to enable BT and BTDM BLE in SDK (IDFGH-4854)

If users may try to use this (excellent) example code in their own projects, without understanding the need to enable the BT stack and BTDM settings in the SDK. If they do that then their builds will fail with linker errors but they may not understand why.

Thanks for your contribution.

@mjcross Instead of this PR, if we select additional config options at https://github.com/espressif/esp-idf/blob/master/examples/provisioning/wifi_prov_mgr/main/Kconfig.projbuild#L12 will that help?

@mahavirj Yes I think that's an improvement - thanks 👍
The challenge is that new users (like me) read the API documentation but don't understand why/how to configure the SDK until they get hit with a page full of linker errors; and for many people provisioning will be their first contact with BT...

The challenge is that new users (like me) read the API documentation but don't understand why/how to configure the SDK until they get hit with a page full of linker errors; and for many people provisioning will be their first contact with BT...

I agree, however we do have some part of this covered in documentation at https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/kconfig.html. Additionally, just would like to mention that we can also keep BT enabled by default, but that has some impact on static footprint (RAM usage) of application and hence choice has been left to end application regarding this.

Yes I think that's an improvement

Could you pleas help to update PR in that case? I will pull it in our internal review queue post that.
Thank your for your patience!

@mahavirj - I've had a look at modifying the PR to move the BT and BTDM config options from sdkconfig.defaults to Kconfig.projbuild - but to be honest I think it is a bit beyond my capability. I am not sufficiently familiar or confident with either the menu config system or the SDK BLE options, so there is a risk that I do more harm than good (!)
Also I can see it's going to be necessary to test a modification like that against the different provisioning options (BT / SoftAP / Nimble / Bluedroid) and I don' have the opportunity to do that here.
So my apologies that I can't help more - I think the best I can suggest is that adding a comment to the code as per the original PR might be the simplest and 'safest' approach; and it has the advantage that it points users in the right direction to be able to use Provisioning - which is after all the objective!

@mjcross

I am not sufficiently familiar or confident with either the menu config system or the SDK BLE options, so there is a risk that I do more harm than good (!)

Sure, no problem.

I think the best I can suggest is that adding a comment to the code as per the original PR might be the simplest and 'safest' approach; and it has the advantage that it points users in the right direction to be able to use Provisioning - which is after all the objective!

Makes sense. I will put in this change in our internal review queue.
Thank you!


Boolean index produces error

Kotlin multiplatform Realm SDK version: 1.5.1
Gradle plugin: io.realm.kotlin:gradle-plugin:1.5.1
Example:
class ActivityDoc() : RealmObject {
    @Index var myFlag: Boolean = true
    ...
}

produces error: [Realm] Indexed key myFlag is of type Boolean but must be of type [Byte, Char, Short, Int, Long, String, RealmInstant, BsonObjectId, ObjectId, RealmUUID]
while documentation states that Boolean is supported to be indexed field:
https://www.mongodb.com/docs/realm/sdk/kotlin/realm-database/schemas/index/
so who is wrong? documentation? or is it a bug in SDK and Boolean type must be supported for indexing?

This seems to be our compiler plugin that erroneously guards against marking boolean properties as indexed. I have created #1197 to fix this.


Create opts feature toggles

The Chore
We need to be able to quickly toggle features on and off without needing to deploy.
These flags differ from release flags which will still be added and managed via .env files.
Tasks

[x] Agree an approach
[ ] Agree which features should be flagged
[ ] Agree naming convention for toggles
[ ] Add documentation to incident management on how to toggle features
[ ] Implement

[ ] toml file for feature flags
[ ] add wrapping toggle component

[ ] Test

Additional details / background info

Put this on a list to discuss with Matt when he's back next week

Thoughts:

[ ] How can we ensure no one could maliciously enable toggles (unauthorised users etc)
[ ] Do we need logging around toggles for traceability?
[ ] Toggles need to work across environments, and not affect environments other than their own.
[ ] Anyone on the on-call rota need to know how to enable toggles and their effects
[ ] Is there any considerations with IPFS and toggle status not being consistent across nodes etc?
[ ] will it be easy to see the current state of toggles/
[ ] Keep feature/release toggles separate from ops toggles
[ ] We will need to test to ensure UI handles components disappearing correctly
[ ] Can we enable toggles locally ( on mainnet but only affect our own version of console)?
[ ] Depending on what ops toggles are in place we may want to duplicate some of our tests with toggles enabled/disabled.

Some thoughts around release toggles:

[ ] Could we use a similar strategy to release features?

[ ] Could we do canary releases?
[ ] Could we release features to mainnet with them turned off, enable locally to test they work, then turn the toggle on to release feature. Once happy, delete the toggle or turn to ops toggle.

Pretty sure I recall Barney being strongly allergic to this as it implied very close control of the app which is something we cannot have. Pushing it out a long way.


Inconsistent tool behavior between distributions

Platform and architecture (e.g. Linux/x64:
macOS 10.14.6

Java version (from "java --version") e.g. 1.8.0_181, 11.0.4+11 etc.:
openjdk version "11.0.6" 2020-01-14
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.6+10)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.6+10, mixed mode)

Variant e.g. HotSpot or OpenJ9:
HotSpot

Have you tested it with other vendors' java:
Yes

Steps to reproduce:
Run the command jar --describe-module --file your_favorite_jar.jar

Error messsage and/or description of what is not working as expected:
The problem is that the language of the output of the above command is different from other distributions as you can see below.

$ /Library/Java/JavaVirtualMachines/jdk-11.0.6.jdk/Contents/Home/bin/jar --describe-module --file annotations-16.0.3.jar
No module descriptor found. Derived automatic module.

<EMAIL_ADDRESS>automatic
requires java.base mandated
contains org.intellij.lang.annotations
contains org.jetbrains.annotations

$ /Library/Java/JavaVirtualMachines/jdk-11.0.6+10/Contents/Home/bin/jar --describe-module --file annotations-16.0.3.jar
Kein Moduldeskriptor gefunden. Automatisches Modul wurde abgeleitet.

<EMAIL_ADDRESS>automatic
requires java.base mandated
contains org.intellij.lang.annotations
contains org.jetbrains.annotations

The first command above is executed by Oracle JDK and the output is english whereas the second command is exectued with AdoptOpenJDK and the output is in german because the default locale of my machine is set to german. This poses a problem to scripts which analyze the output of such commands if some java distributions arbitrarily adopt different conventions of which output language is chosen. I wonder how such difference can occur if you do not fiddle explicitly with the common JDK sources. I have tested this with all Oracle OpenJDK distributions from 11 to 15 and they all use english as the output language. Only AdoptOpenJDK uses the language as defined by the default locale.

This is a question for Oracle. I have verified that the openjdk binaries from ourselves, Azul, Bellsoft and Amazon and RedHat's reference implementation all behave in the same way as ours (they are all based on the OpenJDK codebase so that's what you'd expect).
Oracle must be doing something different on their internal builds to cause that difference.
The line with that message is in the openjdk codebase here:
https://github.com/AdoptOpenJDK/openjdk-jdk11u/blob/5f01925b80ed851b133ee26fbcb07026ac04149e/src/jdk.jartool/share/classes/sun/tools/jar/resources/jar_de.properties#L80

I would have thought that the non-Oracle behaviour was more in line with convention though - if you run, for example, ls /NonsexistantFile the message comes back in your system language (and would lead to similar parsing problems if you tried to process it) and the output from our releases is in line with that.

Not on my system. See attached screen shot.

You see that the menu line is in german but the shell uses english for the output of the 'ls' command. Obviously there are different language settings possible although I think what I am using is the default.

Interesting - I was testing on Linux and setting LC_ALL=de_DE makes the message come out in German
[sxa@sxa git]$ LC_ALL=de_DE ls /NonexistantFile
ls: Zugriff auf /NonexistantFile nicht m�glich: Datei oder Verzeichnis nicht gefunden
[sxa@sxa git]$

although as you say I just logged into a macos box and it seems to behave differently (unless the language support isn't on the machine, but locale -a suggests they're all there.

Just for comparison. Here is what I get on the Mac for this:
ip8:~ mpaus$ echo $LANG
de_DE.UTF-8
ip8:~ mpaus$ echo $LC_ALL

ip8:~ mpaus$ locale -a
en_NZ
nl_NL.UTF-8
pt_BR.UTF-8
fr_CH.ISO8859-15
eu_ES.ISO8859-15
.
.
.
de_DE
lt_LT
tr_TR
C
POSIX
ip8:~ mpaus$ LC_ALL=de_DE ls /NonexistantFile
ls: /NonexistantFile: No such file or directory
ip8:~ mpaus$

As you can see LC_ALL is not set by default but setting it explicitly as you did also makes no difference.
Originally I discovered this issue under different circumstances. I wrote a Java program to analyze the content of JAR files and I used the ToolProvider class to access and run the jar command. This worked ok until I tried AdobtOpenJDK for the first time where I was hit by the problem described above. So I don't think that any terminal settings are relevant for this issue.

As Stewart pointed out, we‘re in line with OpenJDK. Therefore, there is nothing for us to do here.
On https://stackoverflow.com/questions/64038/setting-java-locale-settings, there are multiple ways described to influence the locale of a Java program.


Update the readme

Create short usage guide for the current program.

Coverage remained the same at 70.96% when pulling 140c1e87f0c256ad00d21dd2a49b81ba2c628020 on readme-improvements-aleksi into 055e9872750e356a0cb395897d4e2848c9241e6b on master.

Coverage remained the same at 71.689% when pulling 984043297d5d943e090627d49762c5dfa351d269 on readme-improvements-aleksi into 99e00b0199329682bf5ab4d2aa3626515156a657 on master.

LGTM.


setParallaxHeader problem

When i setParallaxHeader my first element is disappear, and when i click on last element app crashes. "java.lang.IndexOutOfBoundsException"
Can i fix this ?

When you set de parallaxHeader or the LoadMore, they are added as part of the adapter. They pretty much are two more elements in the adapter.
You need to check this in your adapter
if (customHeaderView != null) {
position--; //so you can see the first position because position = 0 is the header!
}
//just verify the range so when you click the last item it doesn't crash. Remember the last item is the //LoadMore thingy.
if (position >= 0 && position < comments.size()) {
}
Hope this was helpful!

I strongly recommend to the creator of this library to

Do not add the header and footer as a part of the adapter
Manage it internally so we don't have to check this kind of things in our implementations.


Run test suites like how CPython runs theirs

The extra flags come from the buildbottest rule in CPython's Makefile.
This will enable checking the tests we've been skipping by default (such as network-based tests). This will also report the top 10 slowest tests and will mark a test as failed if it altered the execution environment.

I can investigate the Windows failures tomorrow evening.


IsRetry is toggled on for the initial attempt to search a secondary package source

This is a continuation of a discussion on the feedback forum: https://developercommunity.visualstudio.com/t/Azure-Artifacts-Credential-Provider-dele/10110841?viewtype=all
There is code somewhere in the plugin that sets IsRetry=True when a nuget package is not found on one feed, and there is another feed that can be tried. This causes problems during package searches when a nuget.config file contains multiple feeds, e.g. a public and a private feed.
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <clear />
    <add key="nuget" value="https://api.nuget.org/v3/index.json" />
    <add key="private" value="https://pkgs.dev.azure.com/private/_packaging/private-nuget-feed/nuget/v3/index.json" />
  </packageSources>
</configuration>

The behavior I'm seeing when searching a private package is roughly as follows
$ dotnet package add SomePrivatePackage # version not specified so it will search all feeds

the (dotnet) nuget client searches nuget.org
nuget.org responds with 404 Not Found
the (dotnet) nuget client searches my private feed
the credprovider is invoked with the IsRetry=True bit and clears my session token cache by design https://github.com/microsoft/artifacts-credprovider/blob/cdc427e8236212b33041b4276961855b39bbe98d/CredentialProvider.Microsoft/RequestHandlers/GetAuthenticationCredentialsRequestHandler.cs#L144-L149
my private feed responds with 401 Unauthorized

It is my conclusion that the IsRetry bit is toggled on when it shouldn't be. A NotFound error should not result in my token cache being cleared.
My suggested fix is to change the error handling code to only clear the session token cache when an authorization error is observed.

https://developercommunity.visualstudio.com/t/Azure-Credprovider:-IsRetry-is-toggled-T/10125533

@johnterickson Could you possibly have a look at the issue workflow is supposed to be for problems like this? This is firmly a code error in this repo, which makes Azure Artifacts unusable in certain situations.
This issue has been sent to Developer Community, where it has been assessed and closed as out of the scope.
https://developercommunity.visualstudio.com/t/Azure-Credprovider:-IsRetry-is-toggled-T/10125533
https://developercommunity.visualstudio.com/t/Azure-Artifacts-Credential-Provider-dele/10110841?viewtype=all

A few quick thoughts:

Don't have more than one package source in your nuget.config. It makes you insecure: https://devblogs.microsoft.com/devops/changes-to-azure-artifact-upstream-behavior/
It sounds like NuGet/dotnet is incorrectly calling the cred provider with -IsRetry. If that is correct, report at https://github.com/NuGet/Home. Deleting the session token is our side of the contract AFAICT.
Session tokens are supposed to be super transient. The question is why is your ADAL/MSAL token not working. Try using the env var to opt in to MSAL mode. It's newer and we're working on making that default.
If you are on WSL, you can try https://github.com/johnterickson/CredentialProvider.Redirect but that's a side project FWIW.

Okay I think this discussion should be moved to NuGet if they are the ones setting the IsRetry flag. Hopefully someone can move using a GH tool? 😀

Session tokens are supposed to be super transient. The question is why is your ADAL/MSAL token not working. Try using the env var to opt in to MSAL mode. It's newer and we're working on making that default.

What do you mean by ADAL/MSAL token? I'm not using single sign-on but instead a device code login flow. I'm not sure about the statement that the token is supposed to be super transient. I certainly don't want to be doing device code logins every time I need to run a nuget command.

If you are on WSL, you can try https://github.com/johnterickson/CredentialProvider.Redirect but that's a side project FWIW.

I'll check it out when I have a moment. I'm using the credprovider in a dev container backed by Docker on WSL2.

@sliekens Can you take a look at https://github.com/NuGet/Home/issues/11210 ?
W.r.t. MSAL & cache https://github.com/microsoft/artifacts-credprovider/blob/master/CredentialProvider.Microsoft/Util/EnvUtil.cs :
NUGET_CREDENTIALPROVIDER_MSAL_ENABLED
NUGET_CREDENTIALPROVIDER_MSAL_FILECACHE_ENABLED
NUGET_CREDENTIALPROVIDER_MSAL_FILECACHE_LOCATION

@johnterickson thanks again but ADAL/MSAL token caching on disk is only supported on Windows(?) if I'm not reading this code wrong
https://github.com/microsoft/artifacts-credprovider/blob/cdc427e8236212b33041b4276961855b39bbe98d/CredentialProvider.Microsoft/CredentialProviders/Vsts/AdalTokenCacheUtils.cs#L16-L20
https://github.com/microsoft/artifacts-credprovider/blob/cdc427e8236212b33041b4276961855b39bbe98d/CredentialProvider.Microsoft/CredentialProviders/Vsts/MSAL/MsalTokenProvider.cs#L40-L55

Ugh why does MSAL make this so hard... Filed https://github.com/microsoft/artifacts-credprovider/issues/345

There's a number of "gotchas" in this thread, but I do want to reiterate that the reason developers inside Microsoft don't hit these problems is because we've pushed really hard on getting all teams to only have one source in their nuget.config.  Not nuget.org'/npmjs.comand one Artifacts feed - exactly one source in thenuget.config`.
Here's the security whitepaper that's a better description than the link I gave previously: https://azure.microsoft.com/en-us/resources/3-ways-to-mitigate-risk-using-private-package-feeds/

I won't argue with the benefits of using a single aggregate feed with added protection against private package substitution attacks, but I found it not worth the drawback. It breaks things like dotnet list package --outdated exactly because upstream sources are not included in the search. I much prefer to have 2 package sources and use a packages.lock.json file for checking the integrity of the binaries.
I look forward to seeing MSAL implemented for Unix-like platforms. 😀

While I understand that; having this workflow fail is really confusing, and that Azure Artifacts expects best practice that isn't really documented in .NET docs nor NuGet docs is difficult.
https://docs.microsoft.com/en-us/nuget/reference/nuget-config-file#packagesources
<packageSources>
    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
    <add key="Contoso" value="https://contoso.com/packages/" />
    <add key="Test Source" value="c:\packages" />
</packageSources>

https://docs.microsoft.com/en-us/nuget/hosting-packages/overview

Regardless of how packages are hosted, you access them by adding them to the list of available sources in NuGet.Config.

Azure artifacts docs/"Connect to feed" guide hint at it by clearing, but doesn't explain that it's a requirement:
https://docs.microsoft.com/en-us/azure/devops/artifacts/nuget/dotnet-setup?view=azure-devops
In some places it appears to guide you towards simply adding the source
https://docs.microsoft.com/en-us/azure/devops/artifacts/get-started-nuget?view=azure-devops&tabs=windows#publish-nuget-packages
It also seems that upstream sources aren't supported for all feed types?
https://docs.microsoft.com/en-us/azure/devops/artifacts/concepts/upstream-sources?view=azure-devops#best-practices-feed-ownerspackage-publishers
Worst of all, it appears that using an upstream source has a sudden and permanent cost? My nuget cache folder locally is 14GB.

Once you've enabled an upstream source, every time you install a package from the public registry, Azure Artifacts will save a copy of that package in your feed.

Perhaps more importantly though, consider the process that somebody considering adopting Azure Artifacts as a private package registry might be taking:
First they will learn how to build packages using dotnet pack, and likely will use a local feed to experiment with how multiple sources works.
Then they'll create an Azure Artifacts project, add it as a source, then push it. Then they might experiment with how to use it to pull that package back down with different permissions levels. They might then experiment with using their new feed via their CI/CD, or through a clean environment like a docker container. Any of this could randomly fail unless they on upstream sources.
I don't think it's reasonable to expect somebody evaluating the core of the service (A private package repository) to commit to using a complicated feature (upstream sources) which has additional costs.

@sliekens outdated should work:

Thinking again, it may be dependent on a feature that we just rolled out or are currently rolling out, so perhaps it's not out everywhere.
@tboby No argument that there are some broken and/or painful aspects of upstreams and onboarding. I will forward your feedback to the NuGet and Artifacts PM teams.
FWIW we are rolling out support for "some upstreams for public feeds" - for example the feed for this repo.
If upstreams is not the right match for your needs, the option for securely mixing private packages and public package usage on nuget specifically is to leverage package source pinning: https://devblogs.microsoft.com/nuget/quickly-map-your-nuget-packages-to-sources/

@sliekens - The actual issue reported in this issue should be fixed in https://github.com/NuGet/NuGet.Client/pull/4794

@kartheekp-ms @johnterickson sorry for the direct pings, but -
I believe i hit the same thing (or a very similar issue) in #347 (which is now clearly mislabled now that i understand the scenario) which does not (directly) use dotnet list subcommands.
Is this related? If so, since the fix seems to have been very specific, what and where do i open an issue on this?
As this involves so many different repos/parts im quite confused on that at this point.


Optional rayon

As mentioned in #208 rayon will panic when creating a threadpool on targets which do not have threads. This PR puts rayon and num_cpus behind the feature flag multi_thread (suggestions for name?), but otherwise follows exactly the same code path as the Fixed(1) case.
Fixes #208

That's very nice, thanks! The feature name multi_thread is good in my opinion.

This is a breaking change btw, as someone could have default-features = False in their Cargo.toml

I had not realized that. Thanks for pointing it out. Guess I'll try to syncrhonize the version bump with another breaking change I'm thinking of. I should probably maintain a file of planned breaking changes.

And eventually find ways to commit to a more stable API of course...


Use insiders for code action fix

Would there be value in testing against release and insiders going forward?

Definitely would like to test insiders - but not on PRs.  There's enough flakiness already that we need to get out of the tests.

superceded by https://github.com/dotnet/vscode-csharp/pull/7784


[Genesis] Migration tools for genesis from legacy accounts

This is the tool which allows for a "kitchen sink" network upgrade, that is, one that requires a halt and a new genesis from backed up data.
Genesis tools for migration

[x] Refactor account recovery to use the vm session in vm-genesis/lib.rs (quite gross work)
[x] Remove daemon, file fetcher, swarm, which are not useful in the case of a single V6 upgrade.
[x] Add test scaffold, to create a default test node config, and replace with current genesis.

Tests:

[x] e2e tests where a test node goes up
[x] parsing snapshot tests
[x] exporting json tests
[x] creating genesis from json
[x] test with production snapshots

A separate and future issue would be how to properly test this in Forge and Smoke tests. Hard-ish problem.

LGTM 👍


🆙 Update XCM coefficients for PROD env

This PR was generated automatically 🤖

Status verification: ✅
All this changes were tested today in https://github.com/nova-wallet/nova-utils/pull/1539


Changing ownership to www-data

Looking at the run.sh file it seems to change ownership of all the application code to the web user. Is this not unsafe as it would allow the application to overwrite its own code? Usually I'd just set the ownership to specific directories where the application needs to write files to. (e.g on drupal /sites/default/files or on wordpress /wp-content/files)

Given that this is a generic image, changing permissions of web folder is the easiest thing to do. There is no super simple way to specify folders you wish to modify, especially when you consider the complexity of considering sub-folders and more unique setups.
What is simple, is to take their run.sh and modify it to fit your needs, and simply copy it over the default one.


Add awesome-fastapi

https://github.com/mjhea0/awesome-fastapi
Thanks!

Awesome, also thanks for fixing that other typo! 😊


Write down more installation testcases

Currently, installation testcases should execute package installation only.
We should do more installation testcases.
e.g) Serverspec.

Test linux or windows specific bundled gems.

On linux side, https://github.com/fluent-plugins-nursery/td-agent-builder/pull/174 will cover it.
So, I'll try to add windows too.

bundled for windows packages:
win32-event -> win32-ipc -> ffi
win32-service -> ffi, ffi-win32-extensions
windows-pr -> win32-api, windows-api
winevt_c
fluent-plugin-parser-winevt_xml
fluent-plugin-windows-eventlog" -> win32-eventlog -> ffi

I'll work windows test case on https://github.com/fluent-plugins-nursery/td-agent-builder/pull/180

Windows and Linux installation testcases are merged into master.
We can close this issue.


Provide a more intuitive way to load static resources

You can use the require method to load .json files (and .js obviously), but nothing else. To load a resource file as a string you need XHR, which is not just cumbersome, but just plain wrong. It implies that there is HTTP involved, which it is only when using the development client.
I would envision a method that works like require (i.e. relative to the current module path), something like
module.getResourceAsString(id);

(to keep the possibility to get a resource as a stream). Note that this has nothing to do with a filesystem API, which does not access resources bundled with the application. Since we already have the native API we need for this (http-request AND the more simple tabris._client.load(url)) it's only a question of exposting it.

After some discussion we agreed on module.getResource(filename), with a optional second parameter in the future (to get the resource as a stream or something else).

This become invalid with the FileSystem API.


Update for 8.1

This PR is tracking dotnet/aspire/tree/main so we get some validation of the samples against latest available Aspire bits.

https://github.com/dotnet/aspire-samples/pull/362


Fix build for mingw toolchain

Many thanks for the PR! Could you please provide some details about the environment / setup in which this patch is useful? E.g. how is MinGW installed, how was LLVM / llvmlite setup, what versions of tools and Numba dependencies are in use?
(Basically - how would one get set up to test these fixes?)

I am using clang in msys2/mingw-w64 environment.

Some info about the toolchain https://www.msys2.org/docs/environments/
llvmlite setup https://github.com/msys2/MINGW-packages/tree/master/mingw-w64-python-llvmlite
numba setup https://github.com/msys2/MINGW-packages/tree/master/mingw-w64-python-numba

@Biswa96 Many thanks for the info - unfortunately none of the Numba / llvmlite maintainers are users of MinGW, so it's quite hard for us to see how to get set up to test this patch - can you provide some guidance as to how to set up an environment to test the patch please?

Understood. Let me check if I can setup any GitHub Actions for mingw environment.

Hi @Biswa96, I have a Windows machine and can try your patch. If you provide a high level description of the necessary steps, that would be helpful.

Verbose documentation can be found here https://www.msys2.org/. Here is the gist:

Download the msys2 installer from that page and install it.
Run C:\msys64\clang64.exe or the clang64 shortcut in start menu.
Update packages with pacman -Syyu twice.
Install required packages pacman -S pacboy; pacboy -S git cc:p python:p python-setuptools:p and other required dependencies for this project. The :p is necessary because it is translated into mingw-w64-clang64-x86_64- prefix.
Make sure there is no other python in $PATH. which python.exe will show /clang64/bin/python.exe.
Now do the regular development steps.

Thanks, @Biswa96. I'll try it in the upcoming days.

HI @Biswa96, thanks for the info. I can confirm your patch works and I was able to successfully build Numba with it. I also tried to build Numba main branch, which failed because it could not build omppool.o.
Below I will copy the steps I did for the "regular development steps" to compile Numba on Windows with msys2:

pacboy -S python-llvmlite:p python-numpy:p
Since llvmlite on msys2 is old (v0.38), I had to manually disable the _ensure_llvm() check on numba/__init__.py
Build numba with python setup.py build_ext --inplace
Tried a simple test case:

$ cat file.py
from numba import njit
import numpy as np

@njit
def foo(a):
    return np.arange(a)

print(foo(3))

$ python file.py
[0, 1, 2]

Hi @Biswa96, thanks for the info. I can confirm your patch works and I was able to successfully build Numba with it. I also tried to build Numba main branch, which failed because it could not build omppool.o.
Below I will copy the steps I did for the "regular development steps" to compile Numba on Windows with msys2:

pacboy -S python-llvmlite:p python-numpy:p
Since llvmlite on msys2 is old (v0.38), I had to manually disable the _ensure_llvm() check on numba/__init__.py
Build numba with python setup.py build_ext --inplace
Tried a simple test case:

$ cat file.py
from numba import njit
import numpy as np

@njit
def foo(a):
    return np.arange(a)

print(foo(3))

$ python file.py
[0, 1, 2]

cc @esc

mingw is not an entirely different "platform". In simple terms,

The first commit applies the same compiler flags from Linux to Windows.
The second commit removes the misconception that _MSC_VER means Windows platform. _WIN32 should be used to check the target OS.

I ran this on the Anaconda build farm and the build was all green (numba_smoketest_cpu_yaml_119).


[Feature request] Make the snapshot screen more dummy proof

[ ] Have help texts explaining each option (WIP)
[ ] Check available space before duplicating a dataset
[ ] Add job control to the duplicate process, otherwise a user can get stuck waiting for it to complete
[ ] Make it so that if a snapshot from the default bootfs is cloned and promoted, the new dataset should become the default bootfs; for added points, have an option to do automatic renaming so the promoted snapshot keeps the name.

See https://github.com/zbm-dev/zfsbootmenu/tree/help-system for the WIP online help/documentation browser.

Job control in duplicate process: https://github.com/zbm-dev/zfsbootmenu/commit/6cca613bf51d4852143cdeb2b12c011eb1432b77

Space calculations in https://github.com/zbm-dev/zfsbootmenu/commit/d5318c2fa73e9a808b288e336a2a7d4615ba86f6

Closed via #101.


[frontend][onnx]fix matmul broadcast

When I import onnx model. I ran into a bug with matmul.
The matmul input shape is: a:[1,1,31,64,16], b:[3,31,64,16].
Thus the broadcast shape should be [1,3,31,64,16].
the both inputs should broadcast.
So far our code just handld the case of one input broadcast.
So I fix it. Thanks to help reviews.
CC: @AndrewZhaoLuo

Can you have a look at this PR? thanks.
@AndrewZhaoLuo


Can only set cursors to 32 x 32 textures.

Regarding Input.set_custom_mouse_cursor(), I'm experiencing this in the 3.0.4 build.
@guilhermefelipecgs Has a regression occurred from this time: https://github.com/godotengine/godot/issues/17992 ?
Example project: 32x32 limit.zip

Duplicate of #17992, the fix #18002 was merged in the master branch, not cherry-picked yet into the 3.0 branch.


Default option overrides all options

The default option when you edit a app is always present even once you input your own value
Recreate : Create GOG app,
edit Country from NZ to GB
save and open edit again.
Shows NZ not GB

(The GB value is saved, but you can never view it in edit second)

move to New Zealand?  Its very lovely.

fixed this now.  but for some reason the first item in gog the default value is always shown blank...  on edit it's not.  I have to look into this later.


docker swarm inspect and docker info inconsistencies

Both docker info and docker swarm inspect display information regarding the swarm.
They do so in a different way.
There are also other inconsistencies in swarm inspect (#23689, #24122).
/cc @stevvooe @aanand @dnephin @tonistiigi

I suggest we replace swarm inspect with swarm info because it does not expect an argument.
It should be pretty by default, and maybe add --json flag, although I would prefer not having it for 1.12 and adding it to both swarm info and info in a later release.
This means that --pretty could remain on node inspect and service inspect, even though i would expect --pretty be added in a later release to volume inspect and network inspect and inspect.

We could also add this information to docker info and remove swarm inspect altogether to stay future proof (in the case there will be multiple swarms to inspect).

Voting for removing swarm inspect as :

It's not following the conventions as docker inspect, docker-machine inspect
It's only showing the current swam info

We decided to remove swarm inspect altogether and just add swarm-specific information to docker info. We need to find a way of merging the existing swarm information in docker info, with the one in swarm inspect currently.
Any takers?

@tiborvass I can take a look at it tomorrow morning :angel: :fr:

SGTM


check object's initialize / destroy time

Problem : some object's are not actually getting destroyed. and need to call initialize & destroy manually.
To solve : add destroy code at destructor / initialize code at constructor
Expected problem : wrong destructor order (dependency)

still have to update singleton's initialize code.
should I make it as public constructor?


Fix price per roll calculation and improve custom filament selector

Corrected price per roll calculation by scaling dynamically with roll weight.
Ensured "Custom" filament option is always selectable in the filament brand dropdown.
Updated labels and positioning for roll weight and filament used fields to improve clarity.
Price per roll now adapts correctly based on the roll weight input (€/kg to €/roll).

Some updates based on beta tester feedback, thank you beta testers!


add opex_nonfuel column to all FERC1 plant tables in output layer for all_plants_ferc1 table

Covers issue #1619
add opex_nonfuel column to add ferc1 plant tables in the output later so the all_plants_ferc1() table has complete O&M Cost data from all tables in one place.

pull these assigns into the specific table outputs

Ahh yes I think that's a good idea I'll do that


Fix upgrade note following Groovy update

The previous Groovy version was 3.0.10 and not 3.0.11.

@bot-gradle test and merge

OK, I've already triggered a build for you.


Better grl

I think the idea of distributing events base on the grl rate is good, but if we don't change the corresponding time likelihood maybe it could cause a false positive. Also, I think the injected signal events should not weight based on the grl rate
The original idea of disabling the grl filter is to stop filtering out injected signal events when the n_signal_observed is given so it should still be keep.


Craft 3.4: Matrix Field Content will not be duplicated

After update craft 3.3 to craft 3.4, content in a matrix field will not be copied.
Other fields will be copied correctly.
Craft Version: 3.4.8, Plugin Version: 1.0.3

Noted @miro94. I'll try and look into this asap.

Any update on this? We really like this plugin, so it would be great if we can use it with craft 3.4 too. Best, Miro

Hi @miro94 totally forgot about this tbh. It's probably not working due to the new delta-updates P&T released in the 3.4.x versions. I can't give you any ETA I'm afraid but I'll see what I can do next week.

@naboo any news on this? To be honest I am dumbfounded a feature as essential as this doesn't exist in upstream Craft yet.

Sorry that this has taken forever. I just haven't had the time.
So I've fixed the general issue with Site Duplicate not even working with Craft 3.4 or larger. The v1.1.0 release fixes that.
But it doesn't fix the duplication of Matrix entries. Somehow this has changed. I need to look into, or even ask P&T, why it doesn't The code Site Duplicate uses is the same as Craft when duplicating an entry. Site Duplicate just swaps in the new siteId from the dropdown on the entry model. But I'm guessing the Matrix field is handled a little different. I'll keep you updated once I know more.

Any update on this? I have a site that basically runs on matrix fields and I really need to copy all the content over.

@ArtDepartmentMJ There is a feature in the newest Craft versions, that might make using this plugin unnecessary, if you're usecase is similar to mine. You can specify propagation method for your section to "Let each entry choose which site it should be saved to", which basically eliminated my need for this plugin.

@MatthiasGrandl Great stuff thanks for this info, worked a treat


chore(main): release 1.1.0

:robot: I have created a release beep boop
1.1.0 (2024-04-29)
Features

create release-please.yml (8ba892f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/luoyi58624/luoyi_dart_test/releases/tag/v1.1.0 :sunflower:


Fix CreateString with already-encoded string or bytearray in Python 2.7.

There was no way to pass an already-encoded string to
builder.CreateString in Python 2.7:

Passing a bytearray raised a TypeError because bytearray was not
recognized as an instance of compat.binary_type.
Passing a utf-8 encoded str would cause the string to be
double-encoded, because compat.string_types = (basestring,) and
basestring is the base class of str and unicode, so the logic
would never reach the elif isinstance(s, compat.binary_type) case.
Converting a utf-8 encoded bytearray to bytes like
builder.CreateString(bytes(encoded_string)) does not work because
in Python 2.7, bytes is just an alias for str so it behaves as
above.

This change allows either bytes or bytearray as an already-encoded
string to be passed to CreateString in versions of Python that support
bytearray, and falls back to str in older versions.
In Python 2, it restricts unencoded string types to unicode, so str
can be used as an encoded, binary representaiton.

cc @orion-napofearth


Recommended way to add login_hint parameter to authorize request URLs?

Hi - After digging through the docs for a while and coming up short, I thought I'd just ask you directly.
What's the best/recommended way to append the optional login_hint query parameter to the authorize URL on signin attempts made via the UserManager class?
I'm hoping to be able to pass a user's email address as the login_hint to prepopulate the username field on our login page.
Thanks in advance for any guidance from maintainers or the community!

You can pass login_hint  as an extra parameter into signinRedirect and other sigin functions. You will need at least v2.2.2 of this library...

Thanks so much! That was just what we needed!


New brand

New tauri brand! For 1.0 stable
This updates all the repo resources to use the new brand.

SVG files
png's
Repo readme splash (new!)

tray_icon_with_transparency.png and tray_icon.png should need to be valid for macos as we use the template format; (png with black and alpha for the transparency)
https://developer.apple.com/documentation/appkit/nsimage/1520017-template?language=objc

There still a bug @wusyong in the tray icon