Array of array issue

var createMapper = require("map-factory")

var source = {
    foo: [
        {"name": "a", "things": ["a1", "a2"]},
        {"name": "b", "things": ["b1", "b2"]}
    ]
}
const mapper = createMapper();

mapper
  .map("foo[].name").to("bar[].label")
  .map("foo[].things[]").to("bar[].values[]");

const result = mapper.execute(source);

...which gives us this:
bar: [{
        label: "a",
        values: [
            ["a1", "a2", "b1", "b2"]
        ]
    },
    {
        label: "b"
    }
]

...but what's required is this:
bar: [{
        label: "a",
        values: ["a1", "a2"]
    },
    {
        label: "b",
        values: ["b1", "b2"]
    }
]

I'm on holiday at the moment. Will have a look when I return.

The latest object-mapper library fixes this issue.  I overrided the object-mapper folder and seems to be working now.

Thanks. Looking into it now.

Does object-mapper fix this? I tried this with it and got this result:
const mapper = require("object-mapper");

const src = {
  foo: [
    { "name": "a", "things": ["a1", "a2"] },
    { "name": "b", "things": ["b1", "b2"] }
  ]
}

const map = {
  "foo[].name": "bar[].label",
  "foo[].things[]": "bar[].values[]"
}

const result = mapper(src, map);
console.log(result);

/*
{
  "bar": [
    { "label": "a", "values": [[["a1", "a2"], ["b1", "b2"]]] },
    { "label": "b" }
  ]
}
*/

Granted this behaviour isn't what you were after but, unless I'm mistaken, it is consistent with object-mapper.
I am working on an unwind() feature that will flatten the structure to get what you want as it turns out...

Published to npm as 3.0.0.


Automatic Background Removal technology

I am looking for a deep learning library/sdk which can be used to remove the background from any image automatically (with quality as good as www.remove.bg).
I tried some image segmentation SDKs with pre-trained models such as Tensorflow Lite & Fritz AI, but the accuracy of the cutout mask was very low, amongst other issues.
Criteria :-

Background Removal rather than just Human/Portrait Segmentation

If the foreground consists of person holding a balloon, sittting on a chair, with a pet on his side, then I want all of this to get extracted. Not just the human cutout. The segmentation SDKs I tried are only extracting humans (the chair gets vanished), that too with a very low quality mask (hair gets cut, parts of ear gets cut, etc).

Mask quality should be Super-Accurate

I want even the finer details like the hair, delicate clothes, etc to be extracted perfectly.

Fast & Lightweight (for mobile phone)

I want to use this technology on mobile phones (in an Android app) which should ideally work even in an offline environment. If this option is difficult to achieve, then plan B would be install the technoloy on our server.

Technology

What technology should I be exploring to achieve this? Is it called image segmentation or the better term would be image matting? (e.g. http://alphamatting.com/eval_25.php)
I have been reading a lot and I am currently lost in the sea of various technologies out there (OpenCV, Deep Matting, Mask RCNN, Instance Segmentation, Detectron2, Tensorflow, Pytorch, etc). I wonder what magic is happening behind the curtains of www.remove.bg
Would your library help me to achieve what I am looking for? Any help you could provide would be awesome.
Thanks a ton!

If you find anything new about that, please send me an update :)
I'm really intersted in the field too!


How to clone multiple git repositories in workflow

I want to clone multiple repositories for the workflow to be configured in GitHub for Continuous Integration.
I am getting below error
Run pwd
/runner/_work/EuronetsoftwareRenaissanceOnline/EuronetsoftwareRenaissanceOnline
total 4.0K
drwxr-xr-x 2 runner runner   22 Oct 30 17:54 .
-rw-r--r-- 1 runner runner 1.7K Oct 30 17:54 test.pem
drwxr-xr-x 3 runner runner   46 Oct 30 17:54 ..
Cloning into '../renaissance-online-external-libs'...
fatal: unable to access 'https://IP/Euronet-REN/renaissance-online-external-libs/': SSL: certificate subject name (github.uklo.office.eeft.com) does not match target host name '<IP_ADDRESS>'
Below is my workflow for PUSH
on: [push]
env:
WF_ENV: workflow envirnment variables
PEM_KEY: ${{ secrets.APP_PEM_BADAM }}
jobs:
run-shell-command:
runs-on: [ 'self-hosted', 'linux', 'x64', 'docker' ]
steps:
- name: checking host details
run: |
pwd
uname -a
pwd
ls -lath
git --version
git config  --list
echo "GITHUB_ACTOR:  ${GITHUB_ACTOR}"
echo "GIT_REPOSITORY: ${GIT_REPOSITORY}"
echo ${PEM_KEY} >  test.pem
cat test.pem
echo ${{ github.token }}
  - name: checking git config details
    run: |
      pwd
      git config  --list
      ls -lath
      git clone https://${{ github.token }}@Ip/REPO-REN/online-external-libs ../online-external-libs
      pwd
      ls -lath
  - name: clone shared libs
    uses: actions/checkout@v3
    with:
      token: ${{ github.token }}

  - name: checking host details
    run: |
      pwd
      ls -alrth
      cd Linux
      ls -ltrha

@Mayankm13 have you created this issue here by mistake?


Script for creating mock 1p app

What this PR does
Before this PR:
There was no script to create a basic application registration with certificate authentication to a service principal using a custom role definition.
After this PR:
A script exists to do the above.
Jira: https://issues.redhat.com/browse/ARO-6406
Link to demo recording:
Special notes for your reviewer
Try it out, create, delete and login should work

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Deployment: The deployment process was considered and addressed if required
[ ] Testing: New code requires new unit tests.
[ ] Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
[ ] Customers: Is this change affecting customers? Is the release plan considered?

Double-checking - this isn't a bicep template because it's not relevant outside of our dev environment right?
The script looks good to me

The reason this is a script is bicep/arm templates are not fully supported for app registrations. I could split this up so only the last part isn't templated out, but I think most of this will end up being temporary just to get us going.


I can not connect to Storage Explorer

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.20.0
Regression From
1.20.0
Architecture
x64
Storage Explorer Build Number
No response
Platform
Windows
OS Version
No response
Bug Description
{
"message": ""{\n  \"name\": \"Error\",\n  \"message\": \"self signed certificate in certificate chain\",\n  \"stack\": \"Error: self signed certificate in certificate chain\\n    at TLSSocket.onConnectSecure (_tls_wrap.js:1484:34)\\n    at TLSSocket.emit (events.js:310:20)\\n    at TLSSocket._finishInit (_tls_wrap.js:927:8)\\n    at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:697:12)\",\n  \"code\": \"SELF_SIGNED_CERT_IN_CHAIN\"\n}""
}
Steps to Reproduce
launch Storage Explorer;
connect to my blob files;
Actual Experience
i can not connect to my Storage Explorer
Expected Experience
No response
Additional Context
No response

Hi, it sounds like you are having self signed certificates issues. We have to recommended paths forward for you:

Try using system proxy, which you can read about in our networking documentation: https://docs.microsoft.com/en-us/azure/storage/common/storage-explorer-network There are some limitations to it, so make sure you understand those.
Try setting certificates manually. You can read about this process in our troubleshooting guide for additional help with that: https://docs.microsoft.com/en-us/azure/storage/common/storage-explorer-troubleshooting?tabs=Windows%2C2004#ssl-certificate-issues
If neither of those help feel free to come back here to let us know what happened.

Closing due to lack of response. If you still run into the issue, please open a new issue instead.


Content amends

@chrishanes a number of these changes relate to email copy, but this PR only changes the copy in the staff UI (not in the mailers) – is that intentional? [p.s. you'd be right to question why the duplication]


Swift 3 Alamofire JSON conversion problem

I'm not able to convert the response to JSON
let jsonResponse = JSON(response.result.value)
And I'm getting this :
JSON(rawString: "", rawNumber: 0, rawNull: <null>, rawArray: [], rawDictionary: ["status": success, "data": {
  }], rawBool: false, _type: SwiftyJSON.Type.dictionary, _error: nil)

This used to work perfect with older version. Any idea?

Can you provide what exactly is in response.result.value?
Is it
["status": success, "data": {}]

No. It has proper values :
[
  "status": "success",
  "data": [
    "token": "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOjQxLCJpc3MiOiJodHRwOlwvXC9zdGjoxNDc"
  ]
]

This happens with the all the response that I'm parsing.
Also, this started happening once I switched to Swift 3. The older version is working fine.

How did you switched to swift3?

Because I just published it like one hour ago. 😄

Lol. Damn. I've been using this
😄 😄
Do you think this might be the issue?

I've actually not look at their branch yet. :(
But can you give the new one a go and let me know?
if you're using cocoapods, the version should be 3.0.0

Hey @zhigang1992, its working with 3.0.0. Thanks a lot :) 👍


Unable to check for new games, but CAN login (including with 2FA / Captcha)

It does say a new version is available, but i have pulled the docker a number of times and it always shows me that, so i assume it's up to date - I have several older images in my docker catalogue so it's definitely updating
It can log in, and even sends me a notification to login via the discord bot i have set up, all that works. It just will not check for new games.
I should note that it has been working great (captcha ever time, but what can you do :P) so it seems to be a new issue, and one that I didn't see recently posted here. Thankyou for your hard work :)
Config when this was posted was using "weekly" but i tried "all" and it still happens

<EMAIL_ADDRESS>entrypoint-config
node dist/src/entrypoint-config.js
npm notice
npm notice New minor version of npm available! 8.5.0 -> 8.6.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.6.0
npm notice Run npm install -g<EMAIL_ADDRESS>to update!
npm notice
Setting timezone: Europe/London
Run on startup: true
[2022-04-03 10:11:00.600 +0100] INFO: Started epicgames-freegames-node
COMMIT_SHA: "e61c1899206eb6c3fe7d7e4544d9483ada153e0d"
BRANCH: "master"
DISTRO: "alpine"
[2022-04-03 10:11:00.826 +0100] WARN: A newer version of epicgames-freegames-node is available! docker pull this image to update.
[2022-04-03 10:11:00.828 +0100] INFO: Checking free games for XXX
[2022-04-03 10:11:06.199 +0100] INFO: Successfully refreshed login
user: "XXX"
[2022-04-03 10:11:06.511 +0100] ERROR:
message: "Sorry can't find that!"
error: true
[2022-04-03 10:11:06.511 +0100] ERROR: Response code 404 (Not Found)
err: {
"type": "HTTPError",
"message": "Response code 404 (Not Found)",
"stack":
HTTPError: Response code 404 (Not Found)
at Request. (/usr/app/node_modules/got/dist/source/as-promise/index.js:117:42)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
"name": "HTTPError",
"timings": {
"start":<PHONE_NUMBER>358,
"socket":<PHONE_NUMBER>359,
"lookup":<PHONE_NUMBER>384,
"connect":<PHONE_NUMBER>390,
"secureConnect":<PHONE_NUMBER>397,
"upload":<PHONE_NUMBER>397,
"response":<PHONE_NUMBER>506,
"end":<PHONE_NUMBER>507,
"phases": {
"wait": 1,
"dns": 25,
"tcp": 6,
"tls": 7,
"request": 0,
"firstByte": 109,
"download": 1,
"total": 149

}
}
}
[2022-04-03 10:11:06.512 +0100] WARN: Current version
COMMIT_SHA: "e61c1899206eb6c3fe7d7e4544d9483ada153e0d"
BRANCH: "master"
DISTRO: "alpine"
Run once: false
Setting cron schedule as 0 */2 * * *

The version you're using is about 4 months old. Make sure you're not pulling the dev tag or something. It should be latest.

The version you're using is about 4 months old. Make sure you're not pulling the dev tag or something. It should be latest.

I'm using charlocharlie/epicgames-freegames:latest
Even creating a new container is not pulling a newer image. no errors pulling. same issue so im not sure why its old!

@manor7777 Try stopping the container and running a sudo docker system prune which will clean your local image cache among other things. After that you can start the container and it should eventually pull the latest tag accordingly.
Check the reference before you run the command, as it is always advisable to familiarize yourself with the things you run from the Internet (https://docs.docker.com/engine/reference/commandline/system_prune/)

@manor7777 Try stopping the container and running a sudo docker system prune which will clean your local image cache among other things. After that you can start the container and it should eventually pull the latest tag accordingly.
Check the reference before you run the command, as it is always advisable to familiarize yourself with the things you run from the Internet (https://docs.docker.com/engine/reference/commandline/system_prune/)

I ran that, no change. I am using portainer also, which lets you remove images too. Strange - i get the same image on a new install machine

Can you post the docker-run command or your docker-compose.yml that you use to run the freegames-node? (omit sensitive values)

Can you post the docker-run command or your docker-compose.yml that you use to run the freegames-node? (omit sensitive values)

docker pull charlocharlie/epicgames-freegames:b77b960bad2133b86bc4b9bdd87ac6ae84ff6168 also gives the same error. With the same git commit sha as the error, even though that image was 9 days ago.
I just used  docker run -d -v /my/host/dir/:/usr/app/config:rw -p 3000:3000 -m 2g charlocharlie/epicgames-freegames:latest from the home page, but with a different config directory.
I manage my dockers through portainer most of the time though

Is it potentially a regional change on epic's store? like they changed their api/something that the free node is scraping on their page for my region, and it hasn't rolled out everywhere? can i ask where you are testing from that is working, i'll spin up a VPN to test to see if it is a regional issue.

@claabs last night my docker auto updater (thanks watch tower) pulled another docker image for this project. despite the fact that it still shows "COMMIT_SHA: "e61c1899206eb6c3fe7d7e4544d9483ada153e0d"" in the logs (4 months old according to this thread), it now seems to be picking up games again. I have none to claim until next week due to it being broken for me, so I did it manually.
I'll close this ticket for now!

Hmm, interesting. It works fine for me. I currently only have to solve the CAPTCHAs for "purchasing" the free games.
Just curious what happens when you pull from the GitHub container registry (ghcr.io/claabs/epicgames-freegames-node:latest)

Hmm, interesting. It works fine for me. I currently only have to solve the CAPTCHAs for "purchasing" the free games.
Just curious what happens when you pull from the GitHub container registry (ghcr.io/claabs/epicgames-freegames-node:latest)

I was originally


add Identity default hasher

Worked for me. shrug
upd: just realized i did it with master instead of v2 branch

identity hasher is already included in #62. Will be merged soonish


There is a mistake in the document AFAIK

There is a mistake in the document if I am not mistaken. We see an example SAN called certauth.contoso.com but this is not correct, it should be certauth.adfs.contoso.com as far as I know.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d7cc47f3-30fe-1a90-ac1f-6ddfe842ace8
Version Independent ID: ed59c2d1-48f2-5b15-1b10-826e7d66f210
Content: Configure AD FS support for user certificate authentication
Content Source: WindowsServerDocs/identity/ad-fs/operations/Configure-User-Certificate-Authentication.md
Product: windows-server
Technology: ad-fs
GitHub Login: @jenfieldmsft
Microsoft Alias: billmath

Ref. https://docs.microsoft.com/en-us/windows-server/identity/ad-fs/operations/ad-fs-support-for-alternate-hostname-binding-for-certificate-authentication :

With AD FS in Windows Server 2016 this can be accomplished.
In AD FS on Windows Server 2016 this has changed. Now we support two modes, the first uses the same host (i.e. adfs.contoso.com) with different ports (443, 49443). The second used different hosts (adfs.contoso.com and certauth.adfs.contoso.com) with the same port (443). This will require an SSL certificate to support "certauth." as an alternate subject name. This can be done at the time of the farm creation or later via PowerShell.

Note: my emphasis added in the quoted text for (adfs.contoso.com and certauth.adfs.contoso.com).

Ref. https://docs.microsoft.com/en-us/windows-server/identity/ad-fs/operations/ad-fs-support-for-alternate-hostname-binding-for-certificate-authentication :

With AD FS in Windows Server 2016 this can be accomplished.
In AD FS on Windows Server 2016 this has changed. Now we support two modes, the first uses the same host (i.e. adfs.contoso.com) with different ports (443, 49443). The second used different hosts (adfs.contoso.com and certauth.adfs.contoso.com) with the same port (443). This will require an SSL certificate to support "certauth." as an alternate subject name. This can be done at the time of the farm creation or later via PowerShell.

Note: my emphasis added in the quoted text for (adfs.contoso.com and certauth.adfs.contoso.com).

#assign:xelu86

Hey @bekirdur,
Thanks again for contacting Microsoft. We value your feedback.
The response given by Illfated is indeed correct where more than one hostname can be used. We have updated this documentation to state this for more clarity and changes should be live by the next business day.
We will now be closing this thread. Thank you and have a most pleasant day. #please-close


Not showing S-Bahn

The modules is not showing entries for S-Bahn

There was planned shutdown of Strammstrecke (S-Bahn) from Friday 2017-05-12@22:45 till Monday 2017-05-15@04:30 so MVG didn't provide any data in this time.


feat: new environmentMatchGlobs option to auto infer env based on glob

This could enable convetions based env setup and allow conexist of different environments esier.

@antfu I forgot, but can you add documentation for this feature?


Dark mode

Motivation and Context

The current dark mode color scheme could use some updating as the colors are a bit unusual and not as contrast.
Your Changes

Description:

Updated color scheme of overall dark mode
Added properties to React chart to fix incoherent styling applied
Added dark mode compatible icons for dropdown menu, which would've been hard to see if unchanged.

Type of change (select all that apply):

[x] New feature (non-breaking change which adds functionality)

Testing

Questions and Comments (if applicable)

Currently, the values in chart_helpers.js are hardcoded values for the color variables --primary_one and --gridline. This is not good practice. I have tried doing document.documentElement.style.getPropertyValue("--primary_one") and importing variables from app/assets/stylesheets/common/_constants.scss. None of these approaches have worked and would like suggestions on how to proceed.

Checklist

[x] I have performed a self-review of my own code.
[x] I have verified that the pre-commit.ci checks have passed.
[ ] I have verified that the CI tests have passed.
[ ] I have reviewed the test coverage changes reported on Coveralls.

@therealfake one thing I just double-checked: there's one more usage of chartScales in grade_entry_form_chart.jsx that needs to be updated.


'minzoom' is deprecated and will be removed in Mapnik 4.x, use 'minimum-scale-denominator' instead

Same for maxzoom / maximum-scale-denominator.
Perhaps this will also clarify https://github.com/mapbox/carto/issues/385?
Refs https://github.com/mapnik/mapnik/issues/1447

I'd also like to see this done; right now, Mapnik is generating a lot of noise in our logs complaining about minzoom being deprecated, so I'm looking at doing a regex search/replace to manually fix it. It'd be much nicer if carto built the stylesheet with the right name.


marathon-sd - use 'hostPort' member of portMapping to construct target endpoints

Fixes #4855 - ServicePort was wrongly used to construct an address to endpoints defined in portMappings. This was changed to HostPort. Support for obtaining auto-generated host ports was also added.
@rjanovski @adrien-f Could you validate this on your setups, please?

Is the fix inside the docker prom/prometheus:latest? Other tag?

@rjanovski the fix would be available in prom/prometheus:master once merged. Before that you can download the binary here for testing: https://9532-6838921-gh.circle-artifacts.com/0/build/prometheus

Thank you all for the effective collaboration! @rjanovski can you give it a try? The change looks good to me but since you're the original reporter, it would be good if you can confirm. If you absolutely need a container image and you're not sure how to do it, I can build it for you.

@simonpasquier , not sure about the executable in the link above; couldn't run it on my mac.
I built prometheus from source from https://github.com/ti-mo/prometheus and ran it.
it successfully discovered my services.
LGTM 👍
thanks for the quick fix 🥇
let me know if you need anything else

Thanks all. @simonpasquier could this be released on the 2.5 branch?

@ti-mo It sounds reasonable, you need to open the same PR but against the release-2.5 branch.

@simonpasquier Done, created #4909! Is this okay to merge?

Thanks @ti-mo! After discussing with @brancz who's in charge of the 2.5 release and knowing that the first release candidate for v2.6.0 is happening in less than 2 weeks (Dec 6th normally), we decided that there won't be a v2.5.1 release. Sorry for the inconvenience.
@brian-brazil can you have a look at this PR. The original reporter of the issue and another user reported that the fix is working for them.

:+1:


App has been unpublished from the store by Microsoft

Sad news. I have been informed via e-mail that Microsoft has unpublished this app from the Microsoft Store because they reviewed it again and found out, that it breaks store policy 10.1.1

The submission is a web app and must be published by the owner of the related domain or website.

Tis is something that cannot be fixed, because the app relies on access to open.spotify.com because it's just a wrapper and since I am not the owner of that domain I cannot use this URL in this app.
From my understanding it has nothing to do with the "Spotify" in the name and I think that I made absolutely clear that this is not a official Spotify app, the problem is "only" with the URL that it is using.
I have no idea what i should do next, and why would they go you of their way to remove this app when it's available only for mobile device which will be discontinued in a few months.

Actually I think it's totally related to the Name. I mean all other 3rd party Spotify apps were unpublished too and they needed to change their name before they could be republished. One of the Apps is now called XPO Music which is also a Spotify Web App. I would really try to come up with something NOT Spotify in the name and nothing similar and see if they accept that or not.

Okay, but when it comes to naming the app I'm completely clueless...
How about "Definitely not a Spotify player" 😃

lol....yeah same here:
"Musicfy Mobile"
"Musical-fy Mobile"
"Mobilefy Music"
"Mobilefy Web Music"
"Green Mobile Music Player"
🤣

Hey, is there anything new to the case? I'd like to bring the player back for I reset my phone, unfortunately it's no longer available and I can't manage to compile the set along with given instructions. Don't you have an appx or appxbundle package? Much appreciated!

Hi, you can download compiled releases on this page.

Did you ever try to republish with one of the names (or other ones)?

No I didn't. I heard that the app is currently broken and since I don't have any WM device available anymore for testing I can't properly debug the app (obviously I don't want to release the app in the current broken state).
It was fun side project and a way to extend WM usability but in 3 months WM will be EOL and I don't have the motivation to constantly react to changes made by the Spotify team. So for that reasons I think it's time for me to end this project so I can focus more on different projects.
If anyone wants to continue working on this project feel free to fork this repo. Older build (and two unreleased will be still available on the Releases tab.

Unfortunately, I had to part with my Lumia as well recently, so can't help with debugging either. I don't think the app should be broken though, except for the podcast episode description page.
Regardless, it was a pleasure working with you, Jan, and very enlightening. Your app made us enjoy our Lumias for a bit longer. Thank you. :)

I can debug. There was a last update to hit the phone today. They upgraded the browser to Chromium. Now the app is really broken now.


App grabs system-wide volume vocus while chromecasting

When chromecasting no matter what app has focus, adjusting volume only adjusts the put.io chromecast volume. This doesn't happen with other chromecast enabled apps for me.

Hmm, is this not the desired behavior in the Cast design guidelines? I'll
have to read those again.
On Mon, Oct 19, 2015, 11:57 AM Bryan Davis<EMAIL_ADDRESS>wrote:

When chromecasting no matter what app has focus, adjusting volume only
adjusts the put.io chromecast volume. This doesn't happen with other
chromecast enabled apps for me.
—
Reply to this email directly or view it on GitHub
https://github.com/DSteve595/Put.io/issues/40.


Mention relation of interfaces to member fields

In D the interfaces are special abstract classes which forbid non-static function declarations and non-static member field definitions.
For good software engineering reasons I didn't add alias to the interface example.

IMO, this is not the best approach to describing interfaces in D. An interface isn't inherited, it's implemented. And they aren't really abstract classes---all classes are subclasses of Object, but interfaces are not. The language used in this PR is potentially confusing.

Maybe there is a different technical term?

Classes in D are more akin to those of Java than C++. There, interfaces are usually "implemented" rather than "inherited". Though really, I suppose "inherit" also works. We inherit both the interface and the implementation from a class, and we inherit the interface from an interface. So I shouldn't have objected to that.
The abstract class bit though just has to go. Abstract classes and interfaces are distinct in D, so that term doesn't work in describing interfaces.

because of simplicity for learners

What we should strive for is clarity, not tutorial level text. The spec is the language definition, not a tutorial.
But I do agree that the first bullet point needs to be revised. First, it could be better worded. Perhaps something like this:
"An Interface is a set of functions that have no implementation. Classes that inherit from an Interface must provide an implementation for each function."
I think this makes the text clearer and gets the point across that an interface is like an abstract class, but without introducing the detour into describing abstraction. However, it's not the whole picture. Further down the page, we see a reference to final and static member functions, which means some functions do have implementations.
With that in mind, I might rewrite the introductory paragraph as:
"An Interface generally is a set of functions that have no implementation. Classes that inherit from an Interface must provide an implementation for each unimplemented function. Interfaces may be specialized to provide final or static member function implementations, and include static member fields."
I think that would be a good start.
The addition you have about non-static member fields is probably backwards. There is nothing in the current documentation that says anything about static member fields. I think it better to add a paragraph that says something like this:
"Interfaces may have static member variables. Non-static member variables are prohibited."
===========
The above refers to your PR, but while you're at it, there are some more improvements to be made on the existing documentation. A couple that would fit in your PR, IMO:
Item 7 in the existing documentation is really poorly worded:

Virtual interface member functions do not have implementations. Interfaces are expected to implement static or final functions.

Ugh! In line with my suggestion about member variables:
"Interfaces may provide implementations of functions, but such functions must be marked as static or final.`
And item 8 in the existing docs:

Interfaces can have function templates in the members. All instantiated functions are implicitly final.

Double ugh! How about:
"Interface functions can be template functions. All such functions are implicitly final, so the interface must provide an implementation."
=====
If you can modify your branch with the changes I've suggested, and also make the additions I've recommended, then I'll have no problem approving it and, barring any further objections, merging it.
Also, please use American spelling for consistency with the rest of the documentation. So, "behavior" instead of "behaviour".

The abstract class bit though just has to go. Abstract classes and interfaces are distinct in D, so that term doesn't work in describing interfaces.

Only syntactically distinct, but conceptionally the abstract class is a superset of an interface.
Just that classes probably can't inherit multiple abstract classes in D. The Dlang documentation for class is nowhere explicit about multiple inheritance.
Interfaces probably are even implemented as an abstract class under the hood because of isAbstractClass!(InterfaceType).
Anyone who played around with interfaces in D should notice that an interface behaves like an abstract class just with restrictions, which are: no definition for instance members (no declaration for instance fields), required implementation for class members and implemented functions are always final (for whatever reason, more terrible: the attribute can be omitted for templated and static functions).

because of simplicity for learners

What we should strive for is clarity, not tutorial level text. The spec is the language definition, not a tutorial.

Yes, more clarity has been the motiviation for this pull request.
Explanations and hints shouldn't be dismissed as "tutorials". D is known to have (too) technical and terse documentation for beginners which makes D hard to learn and additionally decreases the popularity of Dlang. A documentation should simplify learning. D's community should be interested in improved explanations.
Explanations and design reasons do belong into a documentation (except for the reason of subjective taste) and it seems like this is missing in D. People need to explain it multiple times in the Forum because it's not in the documentation.

"An Interface is a set of functions that have no implementation. Classes that inherit from an Interface must provide an implementation for each function."

That's equal to the previous text with only different grammar. Frankly, I don't care about grammar unless it's ambiguous or meaningless. I removed the wording because it is what I found unclear by myself and even wrong. My purpose for this PR is that an interface is not just a set of functions in D, not even the general concept is. It's a lightweight abstract class introduced as a simple solution for the diamond problem.

The addition you have about non-static member fields is probably backwards. There is nothing in the current documentation that says anything about static member fields.

Not sure if I understand correctly.
I changed the introductory paragraph (removed "set of functions"). I mentioned "abstract class" so it should be clear by default that members would be allowed in an interface. I added the paragraph about non-static member fields therefore. Example now contains member field templates. All of my added examples are tested with latest rdmd online.

...there are some more improvements to be made on the existing documentation...
Item 7 in the existing documentation is really poorly worded:

Virtual interface member functions do not have implementations. Interfaces are expected to implement static or final functions.

Ugh! In line with my suggestion about member variables:
"Interfaces may provide implementations of functions, but such functions must be marked as static or final.`

Done

Interfaces can have function templates in the members. All instantiated functions are implicitly final.

Double ugh! How about:
"Interface functions can be template functions. All such functions are implicitly final, so the interface must provide an implementation."

Done

Also, please use American spelling for consistency with the rest of the documentation. So, "behavior" instead of "behaviour".

Done

D is known to have (too) technical and terse documentation for beginners which makes D hard to learn and additionally decreases the popularity of Dlang. A documentation should simplify learning. D's community should be interested in improved explanations.

Documentation that simplifies learning D for beginners should exist, but the language spec is not the correct place for it.
Broadly speaking, documentation can be divided into four categories: tutorials, HOWTOs, reference documents, and explanatory documents (see the link for more details on these categories).
The language specification is a reference document: its purpose is to be a complete, detailed, and accurate description of the D programming language. It is intended to be used primarily by experienced D programmers who need to look up the specific details of how a particular language feature works. The spec should avoid being unnecessarily obtuse, but correctness and precision are more important than friendliness to beginners.
If you would like to contribute some learning-oriented documentation about D's interfaces, the articles section of dlang.org would be a good place for it.


feat(docker-push-to-registries): Added

Related: https://github.com/Telicent-io/telicent-ontology-app/pull/249
Best (naive) guess at removing AWS
Testing
Will need to happen "live" once merged to main

Whoops. NOthing has changed yet. Ignore this review for a few minutes

Hm.
So it seems like I accidentally pressed merge?
Surprising as

I don't feel like I pressed anything (I literally say the PR turn purple as I was typing - maybe I hit a kb shortcut?)
This does not have any approvals.

Its not terrible, as the diff moves things forward.
But I'm investigating..

Oh.... ok.
So it may be because I pushed commits to this branch... from my local, directly to telicent-oss, and github resolved this by closing this PR.
I guess on the correct assumption I'll just open the PR in telicent-oss.


[xiami] bug fix for extractor xiami.py

Before submitting a pull request make sure you have:

[ ] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[ ] Searched the bugtracker for similar pull requests

What is the purpose of your pull request?

[x] Bug fix
[ ] New extractor
[ ] New feature

Before applying this patch, when downloading resources from xiami.com, it crashes with these:
Traceback (most recent call last):
  File "/home/phi/.local/bin/youtube-dl", line 11, in <module>
    sys.exit(main())
  File "/home/phi/.local/lib/python3.5/site-packages/youtube_dl/__init__.py", line 433, in main
    _real_main(argv)
  File "/home/phi/.local/lib/python3.5/site-packages/youtube_dl/__init__.py", line 423, in _real_main
    retcode = ydl.download(all_urls)
  File "/home/phi/.local/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 1786, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "/home/phi/.local/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 691, in extract_info
    ie_result = ie.extract(url)
  File "/home/phi/.local/lib/python3.5/site-packages/youtube_dl/extractor/common.py", line 347, in extract
    return self._real_extract(url)
  File "/home/phi/.local/lib/python3.5/site-packages/youtube_dl/extractor/xiami.py", line 116, in _real_extract
    return self._extract_tracks(self._match_id(url))[0]
  File "/home/phi/.local/lib/python3.5/site-packages/youtube_dl/extractor/xiami.py", line 43, in _extract_tracks
    '%s/%s%s' % (self._API_BASE_URL, item_id, '/type/%s' % typ if typ else ''), item_id)
  File "/home/phi/.local/lib/python3.5/site-packages/youtube_dl/extractor/common.py", line 562, in _download_json
    json_string, video_id, transform_source=transform_source, fatal=fatal)
  File "/home/phi/.local/lib/python3.5/site-packages/youtube_dl/extractor/common.py", line 568, in _parse_json
    return json.loads(json_string)
  File "/usr/lib/python3.5/json/__init__.py", line 312, in loads
    s.__class__.__name__))
TypeError: the JSON object must be str, not 'NoneType'

This patch solves exactly this problem.

Thanks and sorry for my previous mistake at 7759be38da1b5ad99a8ef04d9a1df21b989e3b8c.


remote: Check whether input is a TTY before prompting

Add a new CanAcceptPrompt API for determining whether the user can
type in things to send to the running process. If the user cannot do
that, exit with an error immediately, rather than hanging forever.
I haven't checked whether this code is used in other parts of the
program, but if so we should probably update those as well.
This work was sponsored by Otto.
Fixes #317.

This is definitely a nifty way of checking for a prompt, but it also breaks the interactive experience for human CLI users. Let's resolve #317 and perhaps then we can revisit this.

it also breaks the interactive experience for human CLI users

I'm a little confused. If a human is using the CLI, terminal.IsTerminal will return true, and we'll skip the if branch. If there's no TTY hooked up to stdin, terminal.IsTerminal will return false and you'll get an error.

Ah, that's my mistake. Thanks for clarifying.

This is blocked on #335 (and I guess #336).

PR not updated for over 2 years, closing


FPS RAN parameter

Hi!
When you call the utils.farthest_point_sample function you've a boolean parameter named RAN. What does it mean and which is its purpose? Thank you!

Same issue


Where to find MSIXCoreInstaller?

I developed the application and packaged it in msix. Now I want to try installing it on Win7. But I can not find any executable files and usage materials.

It's in preview under releases:  https://github.com/microsoft/msix-packaging/releases
You can download msixmgr.msi to deploy.  Readme here: https://github.com/microsoft/msix-packaging/tree/master/preview/MsixCore


KV Graveler stagingManager Migration

Migration code to port existing data from SQL to KV, and a corresponding test

@N-o-Z is this done?


Copyright assignment

@marscher would it be possible to transfer the copyright to some neutral agency such as Apache?  It just feels silly maintaining the Steves original copyright 2004 statement when 90%+ of the code has been rewritten.  (Not to mention the awkwardness of that darn accented e getting crushed by editors).
I am fine with doing the paperwork and signing it over my portions, but we need to get Steve to sign off and find a organization to accept it.

Even if 90% of the code has been rewritten, it is still considered a derivative in terms of clause 2 of the Apache license. What is the benefit of this administrative work, I can now only see that you want to delete the copyright notice in the file headers. Does Apache foundation provide some beneficial framework in the sense of lowering maintenance burdens? We do not need to pay for continuous integration services, hosting etc.
What is the implication of changing the copyright notice anyways? The license still applies and it grants enough freedom in my opinion.
Maybe related https://github.com/jpype-project/jpype/issues/11

My main issue is in the creation of new files.  I always perfer to assign the copyright to some neutral agency with has the resources to defend rather than retain it myself.  Thus far with most times I have just been copying the projects archival 2004 copyright so long as there is a single line which should apply to most of native/common.  Native/python is currently entirely replaced as of 0.8.  The Jpype python is mixed.
There is no read guidance in the docs on the project.  Should new authors copy the old header, or should they insert their own copyright statement?

Did you ever need to defend your copyright against somebody? I thought it is something based on the U.S. constitution, so it is also only applicable there. Honestly I do not care so much, as we have the git history, which can be used to prove authorship if even questionable. The headers has become irrelevant in my opinion and are pre-git historic. If you think it is worth the effort to transfer this right to an trustworthy agency, please go ahead.

The other minor wrinkle regarding copyright is that to create the 0.8 speed patch without any documentation from cpython regarding their api i had to read cpython source code and use it as a template.  Both projects have free licenses, but they are different licenses thus giving me hesitation.
I am sure that cpython authors would not object as the purpose is to promote python in general.  But be assigning the files to Steve I feel like I am dragging a person into something.  It is not clear to me if I should add a statement like "Portions of this code were derived from the CPython source, copyright blah blah... see PSF license".
Last time i had issues like this I just worked with Stallman and decide to assign the whole project over to Gnu.

So you're saying that you've copied over parts of CPython? Have you rewritten it somehow? If so it should be considered your work. Mixing licenses should be avoided in any case.

Now it seems to me that this cpython copied/derived code is your main concern about this whole copy-right/right-transferal issue. If the Python foundation would sue this project for some copied lines of code, the GNU foundation would have to deal with it. Ultimately leading to a waste of every bodies resources (lawyers, courts, finally developers needing to re-implement the questionable lines of code).

Well the only party that I am really worried about is my employer.  I unfortunately work under Department of Energy in the United States in California contracted through a private company (who is replaced every few years).  Virtually everything I write it thus owned by my employer. It was better when my contractor was University of California, but when we were forced to go private more issues have ensued.  My current employer has not caused issues, but at some point they may be replaced by something like Lockheed Martin.   I have been a party to copyright dispute for the last 7 years between DOE, my company, and the funding agency which has prevented a code that I authored from ever seeing the light of day.   The last thing I want to see is a repeat of that whole mess.
Thus unfortunately I have seen what happens.  I have informal permission to work on this project on my own time from my boss. Filing paperwork with my employer to sign over my portions to a neutral agency just takes the whims of my employer out of the picture, but I can't really file paperwork to sign over to Steve.  Thus always leaving me and the project subject to the whims of whatever the United States Government decides our next private contractor will be.

On 12/16/19 3:59 PM, Karl Nelson wrote:

Well the only party that I am really worried about is my employer. I
unfortunately work under Department of Energy in the United States in
California contracted through a private company (who is replaced every
few years). Virtually everything I write it thus owned by my employer.
It was better when my contractor was University of California, but when
we were forced to go private more issues have ensued. My current
employer has not caused issues, but at some point they may be replaced
by something like Lockheed Martin. I have been a party to copyright
dispute for the last 7 years between DOE, my company, and the funding
agency which has prevented a code that I authored from ever seeing the
light of day. The last thing I want to see is a repeat of that whole mess.
Thus unfortunately I have seen what happens. I have informal permission
to work on this project on my own time from my boss. Filing paperwork
with my employer to sign over my portions to a neutral agency just takes
the whims of my employer out of the picture, but I can't really file
paperwork to sign over to Steve. Thus always leaving me and the project
subject to the whims of whatever the United States Government decides
our next private contractor will be.

What a mess. Thanks for this detailed explanation. I hope we can
convince Steve (@DevilWolf) in this case to hand over the copy-right to
a neutral agency.

Well I am not sure that we have to have Steve hand over the code.  I just need a neutral agency to accept the project so that I can transfer my portions to them thus taking my employer (or any future company that takes over my contract) for having any claim.  Usually that requires prior authors approval but I am not sure it that has to be the case.
With regard to the CPython source.  I had to use  Modules/_testcapimodule.c as an example for setting up heap classes as well reviewing  Object/typeobject.c, Object/exceptions.c and Object/longobject.c.  No code was copied directly but I did need to view the source and set up tests to determine behavior and interactions prior so that I could replicate similar functionality within JPype.  The lack of a noody example for the API meant delving into code of another license which always prefer not to do.   (I did discover a few bugs in CPython that I likely should report.)

Not sure it's the right organization, but maybe someone at the EFF can help out here?  Looks like some legal counseling might be adviseable. Especially because the code is internationally developed.

I talked it over with my local company lawyer and was directed work through my IPO office.  We have policy called “Incremental contributions to external open source projects” which allows me to freely contribute bug fixes and the like to projects.  Unfortunately there were two sticking points,  first that my contribution can’t exceed more than 25% of the total code in project and the license be on the list of approved  open source licenses of which “Apache” is not included.  As I have exceeded this limit I have to go through the formal approval process and get the appropriate waver.  This usually requires adding the DOE disclaimer and auspices statement as well as attaching the copyright statement of my organization to the project for files that I have contributed.  It will not alter the license nor change the way in which project can be used in any way, but it is a bit of extra red tape.  Once that is complete it should shield the project from any future claims should our management change.  The only part that I am hoping to avoid is the requirement for “review and release” on patches which would very much slow down my ability to contribute if I have to push each patch through a week long review with half a dozen approvers.
Does anyone have any objections to that?


feat: initiating login flow

Formerly for ~DCMAW-6241: Initiating login flow~ but now relating to DCMAW-7075 iOS | Initiate login (staging)
This PR aims to implement a login feature using the Authentication package for the staging app configuration.
Checklist
Before raising your pull request:

[x] Commit messages that conform to conventional commit messages
[x] Ran the app locally ensuring it builds
[x] Ran the tests locally ensuring they pass on Build
[x] Pull request has a clear title with a short description about the feature or update
~- [ ] Created a draft pull request if it is not yet ready for review~

Before your pull request can be reviewed:

[x] Met all of the acceptance criteria specified in the user story on Jira

[x] Reviewed your own code to ensure you are following the style guidelines

[x] Ran the app and tested the feature on a range of device sizes
Please include iPod Touch, iPhone SE and iPhone 11 as a minimum.

[x] Written Unit and Integration tests if needed

[ ] Met all accessibility requirements?

[ ] Checked dynamic type sizes are applied
[ ] Checked VoiceOver can navigate your new code
[ ] Checked a user can navigate only using a keyboard around your new code

Before merging your pull request:

[ ] Ensure that the code coverage and SonarCloud checks have passed
[ ] Actioned and resolved all comments, reaching out to reviewers for clarifications if necessary.
[ ] Ran the app to ensure that no regressions have been caused by changes during code review.

AppEnvironment Tests for missing info plist and keys/values missing from plist


Error value is unexpected (stringified interactor) and unusable

Not sure this is the expected behavior, but my error attribute is coming out as the whole stringified context. When I set the same values to a different property, I get the values I expect:

Getting the test/error:

Am I not supposed to access the error directly outside from the result?

It's because I was stupidly rescuing StandardError in my Interactor...


doc: Development process enhancements

doc: remove outdated and wrong merge-window description
doc: development process: feature tracking

Codecov Report

Merging #15052 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #15052      +/-   ##
==========================================
- Coverage   52.93%   52.92%   -0.02%
==========================================
  Files         309      309
  Lines       45268    45268
  Branches    10451    10451
==========================================
- Hits        23961    23956       -5
- Misses      16542    16544       +2
- Partials     4765     4768       +3

Impacted Files
Coverage Δ

subsys/testsuite/ztest/src/ztest.c
68.59% <0%> (-4.14%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6249ac...98e8d2d. Read the comment docs.

By the way, this topic has a significant overlap with the old content from doc/development_process/proposals.rst

yeah, good point. I will consolidate all of that now.


DEPRECATION: Overriding init without calling this._super is deprecated. Please call this._super.init && this._super.init.apply(this, arguments); addon: ember-cli-htmlbars

Upgrade to ember-cli-htmlbars version 1.0.6 or above to fix.

fixed in https://github.com/ramybenaroya/ember-cli-lightbox/releases/tag/1.0.0


execute method in sqliteconnection does not work when sending a delete query in ios alone but works in android. (ionic angular app )

I have ionic angular application for ios and android. Recently i updated the capacitor 3 to 5. after updated capacitor 5 i update capacitor-community/sqlite-5 .40.2 version i think it does not get work properly in ios. But it works fine in android. Issue is I could not execute which means execute method the delete query and it returns changes: 0 in ios but in android it returns changes: 1. Any idea?

@rengadevigg Sorry to come late i was busy on another plugin. You have to be more specific. Are you database standalone or coming from a remote server with the use of importFromJson and exportToJson methods and having the fields sql_deleted and last_modified?

@rengadevigg Any news?

It worked after adding ; at the end of the query.

@rengadevigg yes it is mandatory as the execute statement in iOS SQLite can take several statements which is not the case for Android SQLite where the user'statements is split in individual stztement before to be executed by Androis SQLite. So i close the issue


Fixed Vulnerabilities (with npm audit fix)

i hate git

closing this for now, well have to run npm audit fix on the current master again.

not really needed anymore anyway, since I ran the command before I did the new music commands, so they're all merged into master anyway now.


JavaScript object expected thrown from inside Bugsnag notifier?

We’re seeing a consistent low-volume stream of errors come in from IE 10 and 11, and from the stack, it appears to be coming from Bugsnag itself (but it’s hard to tell for sure, since there’s so little information provided — only one frame in the trace).
Here’s the raw trace:
Error JavaScript object expected
    https://[redacted].harvestapp.com/assets/web_timesheet2-80a7d003a062a3d24384e0c0e4ebc022.js:1:244 t.bugsnag

Our source is minified, but the line given in Bugsnag is this block of code:
if (options && options.eventHandler) {
  lastEvent = event;
}
lastScript = currentScript;

// We set shouldCatch to false on IE < 10 because catching the error ruins the file/line as reported in window.onerror,
// We set shouldCatch to false on Chrome/Safari because it interferes with "break on unhandled exception"
// All other browsers need shouldCatch to be true, as they don't pass the exception object to window.onerror
if (shouldCatch) {
  try {
    return _super.apply(this, arguments);
  } catch (e) {
    // We do this rather than stashing treating the error like lastEvent
    // because in FF 26 onerror is not called for synthesized event handlers.
    if (getSetting("autoNotify", true)) {
      self.notifyException(e, null, null, "error");

Here‘s the error in our Bugsnag account. We’re sort of ¯\_(ツ)_/¯ with ideas.
Seen anything like this before? I assume that if it’s indeed an issue in the notifier, that it’d be present on other accounts for IE 10 and 11.

Hey @adunkman,
This has been reported before, but I was unable to figure out the problem. Before the stack-trace was from this line:
    return _super.apply(this, arguments);
As far as I can tell, _super must be an object, this must be an object, and arguments must be an object.
My best hypothesis is that the callback is crashing, and the stacktrace is truncated for an unknown reason (perhaps it's a native method, or it's been inlined?). What would be helpful is if we knew what the value of _super was when this crash happens (so that we can have a look at the event handler).
Happy to explore other ideas if you have them.

We've made some major changes to the notifier since this was opened, and haven't heard any recent reports like this, so I'm going to call this closed for now. Feel free to open a new issue if you hear of more reports or find a way to reproduce. Thanks.


Added a MathsBot

Automated message from Dropbox CLA bot
@Jeffthebest1, it looks like you've already signed the Dropbox CLA. Thanks!


odo v3-alpha2

Once even a single flag is provided it runs in non-interactive mode. All required information needs to be provided via flags
If the command is executed without flags it can enter interactive mode
every command should have -o flag to specify output format, and every command should support -o json

CLI structure for v3.0.0-alpha1

odo catalog

[ ] #5523

odo registry

[ ] #5524

odo create namespace,  odo list namespace, odo delete namespace

[ ] #5525

@serenamarie125 @kadel I know that we haven't adhered to the odo <verb> <noun> pattern till v2. Are we consciously keeping things loose when it comes to odo in that we do have odo create/delete/list, but we will also have odo registry/catalog? I'm not asking this as a critical remark, but more to understand if we want to consider odo <verb> <noun> during v3 or scrap that idea completely for odo.

We should still try to keep verb noun pattern where it makes sense. We definitely don't want to scapt that idea.  But there are areas where it is hard to keep this pattern, and  trying to force some constructs into verb nount pattern would be creating more confusion than if we break that pattern.

/close
two remaining items will be address separately
https://github.com/redhat-developer/odo/issues/5607
https://github.com/redhat-developer/odo/issues/5727


RAM leak with multiple calls

Hello @serengil, many thanks for this awesome library!
I noticed a non neglectible memory leak when calling DeepFace.analyze() multiple times. I've seen #78 and your suggestion to not use the function in a for loop and to use the tf.keras.backend.clear_session() to clear the tf graph.
Unfortunately, even calling tf.keras.backend.clear_session() at every iteration does not stop the memory leak. I really need to use a for loop, as I'm processing a large dataset of videos, so I need to extract the frames and pass them to the function (can't use filenames instead of actual frames).
The pseudo-code is the following:
models = {}
models['race'] = DeepFace.build_model('Race')

dataset_results = list()
for v in videos:
    frame_list = extract_fixed_number_of_frames(v)
    deepface_result =  DeepFace.analyze(frame_list, actions=['race'], models=models)
    dataset_results.append(deepface_result)

The dataset is too large to load it entirely and call DeepFace.analyze([frame_list_1, ..., frame_list_v]).
Do I have other options other than splitting the dataset into chunks that can fit my RAM considering the memory leak?
Do you have any idea on what part of the code is leaking memory? The models are pre-built and the face detector (opencv) is allocated once and retrieved as a global variable, so those should be ok.

calling deepface functions was problematic in old versions but this is sorted. you can call it in for loops now.

I have version 0.0.75 installed by pip a few days ago. Isn't this the latest version?

it is the latest. you are having this issue even if you call it in the for loop?

Yes, the for loop looks like the one in the pseudo code above

no, you are feeding input images as array still. send just an image to analyze function.
models = {}
models['race'] = DeepFace.build_model('Race')

dataset_results = list()
for v in videos:
    frame_list = extract_fixed_number_of_frames(v)
    for frame in frame_list:
       deepface_result =  DeepFace.analyze(frame, actions=['race'], models=models)
       dataset_results.append(deepface_result)

long story short, this is not directly related to the library. you have memory issues on your env. closing this issue.


Network routes not working with iOS client

Describe the problem
I've installed self hosted netbird version 0.25.5, identity provider is microsoft azure/entra. Added custom DNS to resolve my private AD domain (internal.example.com) and added a network route to my private network range (<IP_ADDRESS>/24), routing peer is a ubuntu linux vm with installed netbird client and connected as a peer. If i connect my windows notebook via netbird I am able to connect to internal services within my private network via iPhone hotspot. So in my opinion everything's fully working right now except one thing: If i connect my iPhone (iPhone 14, iOS 17.3 i think) then all peers connect the same way they do when I connect my notebook but neither ips are resolved nor dns names (e.g. test-client.internal.example.com or <IP_ADDRESS>). As far as it seems I'm getting a IPv4 adress via cellular and via hotspot this is working. This issue is just with the iOS-client :/
To Reproduce
Steps to reproduce the behavior:

Install netbird self hosted
Add DNS with internal nameserver and dns name
Install VM (or barebone) ubuntu / linux machine and connect netbird client
Add network route to private network via linux machine mentioned in 3.
Connect via windows / macOS notebook - fully working
Connect via iPhone...
See error

Expected behavior
I'd like to use my internal services via iPhone
Are you using NetBird Cloud?
Self-hosted netbird
NetBird version
netbird version 0.25.5
NetBird status -d output:
Not applicable
Screenshots
Not applicable I guess.
Additional context
n/a
Is there anything I can do to get this one working? :)
Regards
Chris

Hello @EnterTheC,
Could you double check the iOS is in the same group than your other devices?

@pappz checked it, they're all in the same group (default 'all').

When you open the NetBird app on your iPhone device what shows the "Peers connected" page? The connection between the router peer and your device has been established?

Yep, the routing peer is in status 'connected' within the peers-page.

Wanna let you know that I just updated to iOS app version 0.0.3 and everything's fully working now on my iPhone. Thank you so much 🫡

That's great, thanks for confirming @EnterTheC

I have the same problem but only when my iPhone connected to WiFi. With cellular all seems good.
MacBook works without any issues through WiFi.
iPhone netbird version 0.0.3

Hi!
I have a similar intermittent problem. I'm not using self-hosted NetBird. This is what I do:

Network route is configured
On iOS, connect to Netbird
Try to ping any internal ip/name, it doesn't work
Connect/disconnect a few times, eventually it works.
Sometimes, I try on the iOS client to disable/reenable the network route and everything starts working.

It's weird because it's intermittent, sometimes I'm able to ping, sometimes not. So, I guess that means that the configuration is correct.
What information do you need me to provide to help debug it?
Thanks!


recoveryservicesbackup-track2

release for issue: https://github.com/Azure/sdk-release-request/issues/2427

Hi @colawwj, @witemple-msft @MaryGao
I'm new to the package release process.
I can see in the request https://github.com/Azure/sdk-release-request/issues/2427 a new package is generated.
Do we need any more steps to finalize the release?

Hi @colawwj, @witemple-msft @MaryGao I'm new to the package release process. I can see in the request Azure/sdk-release-request#2427 a new package is generated. Do we need any more steps to finalize the release?

That is just artifact for you to verify it work as expected if you are interested. The real release should be done by merge this PR and trigger the release pipeline by us.

Sorry I just saw the official release package on other request.


refactor(sql_lab): SQL Lab Persistent Saved State

SUMMARY

There was a bug report about saved queries not persisting if you refresh the browser that they are on. This PR adds a saved_query foreign key to tab state and then uses that to populate the remoteId necessary for the proper buttons to appear in sql lab.
It does this by creating a new action linked to saving a query that adds the id into the backend, which then gets referenced in getInitialState as well as the action for switching tabs.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up

/testenv up FEATURE_SQLLAB_BACKEND_PERSISTENCE=True

@AAfghahi what happens if you save a query to a tab state and then delete the query and then reopen the tab?

From my testing the saved query no longer exists

@AAfghahi I tested on the testenv and wasn't seeing the expected behavior. Can you take a look? Maybe the feature flag didn't get set correctly on the testenv, but want to check that you're not seeing this on your local dev.
https://user-images.githubusercontent.com/5186919/148258813-976bdbd0-f1ef-48f2-be50-5b77b20a12d4.mov

@yousoph if you change the name of a tab, do you think it should update the default name of the query in the modal?
https://user-images.githubusercontent.com/5186919/148259432-f7d18479-f912-4c3d-8bbf-65aff3db696d.mov

@yousoph if you change the name of a tab, do you think it should update the default name of the query in the modal?
Screen.Recording.2022-01-05.at.9.09.14.AM.mov

That makes sense to me!
But for saved queries, if the tab is renamed, it would still require the user to save the query again before the query name updates?

@yousoph if you change the name of a tab, do you think it should update the default name of the query in the modal?
Screen.Recording.2022-01-05.at.9.09.14.AM.mov

That makes sense to me! But for saved queries, if the tab is renamed, it would still require the user to save the query again before the query name updates?

Yes, correct.

@eschutho ok, I moved some functions around to get the intended behavior to work. I will make a video to showcase that soon (after this standup/office hours).
I will also add the change to the query title like you suggested. THank you!

/testenv up FEATURE_SQLLAB_BACKEND_PERSISTENCE=True

/testenv up FEATURE_SQLLAB_BACKEND_PERSISTENCE=True

@yousoph if you change the name of a tab, do you think it should update the default name of the query in the modal?
Screen.Recording.2022-01-05.at.9.09.14.AM.mov

This has been changed

/testenv up FEATURE_SQLLAB_BACKEND_PERSISTENCE=True

This looks great @AAfghahi. Sorry, one more nit on the name change on the tab. It makes sense that if the query is not saved to use the current tab name for the default, but if the tab is changed after the query is saved, I think it should show the original name, not the name of the tab. WDYT? and @yousoph too for feedback.

Hmm, I think I could go either way here.
It makes sense to me to keep them tab name and query name in sync, but I also would want to avoid people accidentally saving the same query twice under different names.

Hmm, I think I could go either way here.
It makes sense to me to keep them tab name and query name in sync, but I also would want to avoid people accidentally saving the same query twice under different names.

I believe if you select "update" it will rename the old query to the new name. You'd have to save as new to save it with the new name, fyi. So the likely scenario is that you wind up renaming the query without realizing.

This looks great @AAfghahi. Sorry, one more nit on the name change on the tab. It makes sense that if the query is not saved to use the current tab name for the default, but if the tab is changed after the query is saved, I think it should show the original name, not the name of the tab. WDYT? and @yousoph too for feedback.

This works for me - tab name prepopulates the query name for an unsaved query, but they're separate once the query is a saved query.

@yousoph and @eschutho I changed the logic to reflect what you were saying. It will now set the label if you are unsaved automatically, but will not if it is a saved query (until you save)

/testenv up FEATURE_SQLLAB_BACKEND_PERSISTENCE=True

/testenv up FEATURE_SQLLAB_BACKEND_PERSISTENCE=True

/testenv up FEATURE_SQLLAB_BACKEND_PERSISTENCE=True


Dot net core 6 upgrade

Upgrading the project from .Net Framework 4.5 to .Net Core 6.0:

Using EF Core 6.0
Using AutoMapper 12.0
Added extra validation and fixed existing ones
WCF services changed to gRPC
Added base classes for Entities with timestamps
Updated views to match new .Net Core MVC look
Use partials to reduce view code duplication

:white_check_mark: Build TestePraticoDDD 1.0.3 completed (commit https://github.com/rcdmk/TestePraticoDDD/commit/6c5cf5c339 by @)

:white_check_mark: Build TestePraticoDDD 1.0.5 completed (commit https://github.com/rcdmk/TestePraticoDDD/commit/eacb79f0d0 by @)


[Bug]: device_info_plus can't return unique identification code

Platform
iOS 15.5, android 12
Plugin
device_info_plus
Version
4.0.0
Flutter SDK
2.10.5
Steps to reproduce
Remove and install repeatedly to obtain unique identification code.
androidId return empty string.
iOS identifierForVendor Every return is different
Code Sample
final devInfo = DeviceInfoPlugin();
String id = '';
if (!kIsWeb && Platform.isAndroid) {
  AndroidDeviceInfo deviceInfo = await devInfo.androidInfo;
  id = deviceInfo.androidId ?? '';
} else if (!kIsWeb && Platform.isIOS) {
  IosDeviceInfo deviceInfo = await devInfo.iosInfo;
  id = deviceInfo.identifierForVendor ?? '';
}

Logs
[ +131 ms] executing: sysctl hw.optional.arm64
[  +29 ms] Exit code 0 from: sysctl hw.optional.arm64
[   +2 ms] hw.optional.arm64: 1
[   +7 ms] executing: [/Applications/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +15 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 5464c5bac742001448fe4fc0597be939379f88ea
[   +1 ms] executing: [/Applications/flutter/] git tag --points-at 5464c5bac742001448fe4fc0597be939379f88ea
[  +24 ms] Exit code 0 from: git tag --points-at 5464c5bac742001448fe4fc0597be939379f88ea
[        ] 2.10.5
[  +12 ms] executing: [/Applications/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +12 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/stable
[        ] executing: [/Applications/flutter/] git ls-remote --get-url origin
[  +11 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[ +160 ms] executing: [/Applications/flutter/] git rev-parse --abbrev-ref HEAD
[  +18 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] stable
[   +7 ms] executing: sw_vers -productName
[  +20 ms] Exit code 0 from: sw_vers -productName
[        ] macOS
[        ] executing: sw_vers -productVersion
[  +21 ms] Exit code 0 from: sw_vers -productVersion
[        ] 12.3
[        ] executing: sw_vers -buildVersion
[  +18 ms] Exit code 0 from: sw_vers -buildVersion
[   +1 ms] 21E230
[  +65 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +51 ms] executing: /Users/shiqingguo/Library/Android/sdk/platform-tools/adb devices -l
[  +19 ms] executing: sysctl hw.optional.arm64
[  +11 ms] Exit code 0 from: sysctl hw.optional.arm64
[        ] hw.optional.arm64: 1
[        ] executing: /usr/bin/arch -arm64e xcrun xcodebuild -version
[  +92 ms] Exit code 0 from: /usr/bin/arch -arm64e xcrun xcodebuild -version
[        ] Xcode 13.4.1
           Build version 13F100
[   +4 ms] executing: /usr/bin/arch -arm64e xcrun xcdevice list --timeout 2
[   +4 ms] /usr/bin/arch -arm64e xcrun simctl list --json devices
[        ] executing: /usr/bin/arch -arm64e xcrun simctl list --json devices
[   +4 ms] executing: /usr/bin/arch -arm64e xcrun simctl list
[  +82 ms] Exit code 0 from: /usr/bin/arch -arm64e xcrun simctl list
[   +1 ms] == Device Types ==
           iPhone 4s (com.apple.CoreSimulator.SimDeviceType.iPhone-4s)
           iPhone 5 (com.apple.CoreSimulator.SimDeviceType.iPhone-5)
           iPhone 5s (com.apple.CoreSimulator.SimDeviceType.iPhone-5s)
           iPhone 6 Plus (com.apple.CoreSimulator.SimDeviceType.iPhone-6-Plus)
           iPhone 6 (com.apple.CoreSimulator.SimDeviceType.iPhone-6)
           iPhone 6s (com.apple.CoreSimulator.SimDeviceType.iPhone-6s)
           iPhone 6s Plus (com.apple.CoreSimulator.SimDeviceType.iPhone-6s-Plus)
           iPhone SE (1st generation) (com.apple.CoreSimulator.SimDeviceType.iPhone-SE)
           iPhone 7 (com.apple.CoreSimulator.SimDeviceType.iPhone-7)
           iPhone 7 Plus (com.apple.CoreSimulator.SimDeviceType.iPhone-7-Plus)
           iPhone 8 (com.apple.CoreSimulator.SimDeviceType.iPhone-8)
           iPhone 8 Plus (com.apple.CoreSimulator.SimDeviceType.iPhone-8-Plus)
           iPhone X (com.apple.CoreSimulator.SimDeviceType.iPhone-X)
           iPhone Xs (com.apple.CoreSimulator.SimDeviceType.iPhone-XS)
           iPhone Xs Max (com.apple.CoreSimulator.SimDeviceType.iPhone-XS-Max)

Flutter Doctor
[✓] Flutter (Channel stable, 2.10.5, on macOS 12.3 21E230 darwin-arm, locale zh-Hans-CN)
    • Flutter version 2.10.5 at /Applications/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5464c5bac7 (10 weeks ago), 2022-04-18 09:55:37 -0700
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/shiqingguo/Library/Android/sdk
    • Platform android-31, build-tools 29.0.2
    • ANDROID_SDK_ROOT = /Users/shiqingguo/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[✓] VS Code (version 1.68.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.42.0

[✓] Connected device (4 available)
    • M2102J2SC (mobile)      • b87f4a9e                             • android-arm64  • Android 11 (API 30)
    • shiqing的iPhone (mobile) • 00008110-000825EE1E87801E            • ios            • iOS 15.5 19F77
    • iPhone 13 (mobile)      • 2F0A4468-6AA8-4F16-89F6-69D48C65F7BF • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-5 (simulator)
    • Chrome (web)            • chrome                               • web-javascript • Google Chrome 102.0.5005.115
    ! Error: shiqing的iPhone is busy: Preparing the watch for development via shiqing的iPhone. Xcode will continue when shiqing的iPhone is finished. (code -10)

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Have same issue in android as well.
androidId: null,

Have same issue in android as well.
androidId: null,

Have same issue in android as well.
androidId: null,

I have the same issue too. Any one have a solution ?

Have same issue in android as well.
androidId: null,

I have the same issue too. Any one have a solution ?

I started to generate a unique identification (Uuid) and save it in the device's SharedPreferences and use this Uuid to identify it.
https://pub.dev/packages/uuid

Have same issue in android as well.
androidId: null,

me too

I can't believe this!

According this document: https://developer.apple.com/documentation/uikit/uidevice/1620059-identifierforvendor#1965828 I think It is not a bug.

I know it's not a bug
I was suggesting device info plus return the unique id code
Most apps depend on this already
I have 2 published apps and my means of identification is the unique id
Besides, playstore recognizes unique id last I checked
You just need to state in the privacy policy
And they are other ways to make users safer  eg encrypting the id before
display that way we get a fake....as long as it's unique
Removing it is not smart....my opinion
Nice package tho
On Thu, Jul 14, 2022, 5:03 AM frank2359 @.***> wrote:

According this document:
https://developer.apple.com/documentation/uikit/uidevice/1620059-identifierforvendor#1965828
I think It is not a bug.
—
Reply to this email directly, view it on GitHub
https://github.com/fluttercommunity/plus_plugins/issues/934#issuecomment-1183960874,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWI5F3Y6P5WJ2FEO4JDGFUDVT6GSLANCNFSM5Z5BFEIA
.
You are receiving this because you commented.Message ID:
@.***>

I agree

I know it's not a bug I was suggesting device info plus return the unique id code Most apps depend on this already I have 2 published apps and my means of identification is the unique id Besides, playstore recognizes unique id last I checked You just need to state in the privacy policy And they are other ways to make users safer eg encrypting the id before display that way we get a fake....as long as it's unique Removing it is not smart....my opinion Nice package tho
…
On Thu, Jul 14, 2022, 5:03 AM frank2359 @.> wrote: According this document: https://developer.apple.com/documentation/uikit/uidevice/1620059-identifierforvendor#1965828 I think It is not a bug. — Reply to this email directly, view it on GitHub <#934 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWI5F3Y6P5WJ2FEO4JDGFUDVT6GSLANCNFSM5Z5BFEIA . You are receiving this because you commented.Message ID: @.>

I agree

FYI there is a new plugin for getting the Android ID 🙂
https://pub.dev/packages/android_id

From Android 10 onwards it is restrict to collect unique identifiers. This was achieved only in DeviceOwner privileged apps and system apps. From android developer documentation Best practices for unique identifiers explained how to identify uniqueness based on different scenerios. Link


v1.15.0 release

Prepare for v1.15.0 release:

Update changelog
Update client version

Blocked by https://github.com/fastly/go-fastly/pull/199
make release-changelog generates the following
# Changelog

## [Unreleased](https://github.com/fastly/go-fastly/releases/tag/HEAD)

[Full Changelog](https://github.com/fastly/go-fastly/compare/v1.14.0...HEAD)

**Enhancements:**

- Add PublicKey field to S3 all CRUD actions [\#198](https://github.com/fastly/go-fastly/pull/198)
- Add User field to Cloudfiles Updates [\#197](https://github.com/fastly/go-fastly/pull/197)
- Remove extraneous Token field from all Kafka CRUD [\#196](https://github.com/fastly/go-fastly/pull/196)
- Add Region field to all Scalyr CRUD actions [\#195](https://github.com/fastly/go-fastly/pull/195)
- Add MessageType field to all SFTP CRUD actions [\#194](https://github.com/fastly/go-fastly/pull/194)
- Add MessageType field to GCS Updates [\#193](https://github.com/fastly/go-fastly/pull/193)

\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*

Force-pushed rebasing master.

Force-pushed squashing commit to bump client version.


Can you add Linux support?

Great works!
I'm looking for a flutter package that handles audio buffers in Linux.
Can you add Linux support?

Thanks!
The package coast_audio already have Linux support which can handle audio buffers.
What are you intended to use audio buffers for?

That's great!
I'm sorry. I am newbie to Flutter. I didn't know if your package already supports Linux.
I'm trying to make sound effects that modify audio buffers in real time.  I need to port existing sound effects written in C/C++ to Flutter.
Thank you!

@SKKbySSK Hi,
I want to use coast_audio_miniaudio on Linux. Can you add linux support for coast_audio_miniaudio?
I tested mabridge build-android.sh and build-apple.sh, and they work fine.
Can you add build-linux.sh similarly?

@SKKbySSK
I'm currently working on creating an audio effect module that can run on Tizen TV OS. After discovering that it is possible to create apps for Tizen using Flutter-Tizen, I plan to install your music_player sample app on Tizen TV OS and integrate my audio effect module to verify it.
If coast_audio_miniaudio is compatible with Tizen, that would be fantastic.
https://github.com/flutter-tizen/plugins/issues/558

@hl4hck
It seems Tizen uses its custom audio backend.(Correct me if it it wrong)
And miniaudio does not support Tizen OS.
Because of these problems, you cannot use the coast_audio_miniaudio.
Instead, you need to implement custom audio node to play raw PCM buffer.
tizen_interop already wraps APIs by using ffi so maybe you can use it to implement the node(s).

@SKKbySSK
I understand. I thought miniaudio would work, but it seems like I was wrong. I should look into tizen_interop as you suggested. Thank you for answering my questions.

No sweat. I hope your project going well.


access to initial values from HTML or createForm

Is your feature request related to a problem? Please describe.
hi - i'm trying to set the form back to its original HTML values? i've tried setting a variable to $data upon component mount to store the values but it doesnt quite work. is there an idiomatic felte way to do this?
Describe the solution you'd like
allow access to initial values from HTML or even the initialValues inside createForm object?
Describe alternatives you've considered
setting variable to $data upon component mount
Additional context
none
thanks for your GREAT work on this library! so good

thanks for the reply! yes, kinda - the issue is that i'd use setInitialValues and reset few times already. let me explain:
lets say we have a registration form and a list of registrations. filling out a empty form appends a registration item to the list. i also provide the ability to edit an existing registration - when the user clicks on 'edit' button, the existing registration's data is passed to the form via setInitialValues and reset.
after editing an registration and saving it, i'd like to be able to clear the form (back to original values) and then make new registrations.
right now - if i use setInitialValues to allow the editing of a registration, i can't get the original form back. because reset will always set the form to the most recent setInitialValues/registration edit. as i try to create new registrations, the form has the data of the edit.
i hope this is clear!

hi - i also noticed that nested bits in $data aren't populated to the HTML on the first call to reset and setInitialValues - it populates the first level only and then the children on the second call (two button clicks)
any ideas how to fix?
here's a screencast: https://www.youtube.com/watch?v=4CUG3hX5fsE

the first-level only population behavior applies to setFields as well

setData not working as name of function sugest