bind to a queue without a message type

as a side effect of #1, i would like to be able to specify a queue without a message type, when handling a message.
it's good that we can specify the queue, now. with that, the message type doesn't make much sense anymore.
var opts = {
  queue: "some.q"
};
rabbot.handle(ops, function(){ ... });

i could, for now, just subscribe to "#" for the message type, when combined with a queue, but it would be nice to not have to specify the message type.

@derickbailey if I were implementing the options, I could just always default type to #. There's not really another way for me to get messages to the handler.

There's not really another way for me to get messages to the handler.

well... there is, but it involves the removal of postal and going straight to the amqplib handler functions.
if postal is using the type as it's internal subscription, wouldn't a type of # give me all messages published through that postal instance? i haven't looked through the code in some time, so i'm probably not remembering how postal is setup, correctly

@derickbailey - ok, I've updated the handle call to take an options hash. You shouldn't have to specify a type if you want to handle everything arriving on the queue.


maven support?

Would you accept a pull request that included a pom.xml for convenient builds with maven?

Is Gradle so inconvenient?  Out of curiosity, what's the (broad) use case for this PR?  There's not a lot of demand for this, and I'm struggling to think of anything Maven can do for the project that Gradle cannot.  If you really need Maven, you can always just make a fork, and keep it in sync with the master (which I'm sure is what you've done so far).

The work adds support for sending events to an SNS topic when chaos monkey terminates instances. Had some trouble puzzling out a problem with adding an SNS dependency, just switched to maven to avoid being blocked.
I concede that adding maven build doesn't add much value to the project. It merely makes it a bit easier to get started hacking on it for the people familiar with maven and not gradle. Sounds like you're not a fan, so I'll switch back to gradle once I have my changes ready.


Apply font2 patch

This should fix #93. @w3bb could you please confirm that it works for you?
On a side note I'm not sure whether we really need this. st is supposed to use fontconfig's fallback, isn't it?

fontconfig's fallback can cause problems if let's say you want to use a colour emoji globally, and have a monochrome font locally on st. Instead of falling back to another font it makes the character invisible.

@w3bb does the patch work for you? I have no way to test it atm.

Yes it's working nice and dandy.


Count can be wrong in Zend Config

When setting the same key on a config object the counter always increments without caring about already existing keys:
use Zend\Config\Config;

$config = new Config([], true);

$config->foo = 1;
$config->foo = 2;
assert($config->foo == 2);
assert(count($config->toArray()) == 1);
assert(count($config) == 1);

The issue can be found in __set of class Zend\Config\Config.
There are two possible solutions for this issue:

decrease the counter if the key is already defined:
if (null === $name) {
    $this->data[] = $value;
} else {
    if (array_key_exists($name, $this->data)) {
        $this->count--;
    }
    $this->data[$name] = $value;
}

$this->count++;

2. remove the counter and call `count($this->data)` in the `count()` method of the class

This issue did not exists in Zend Framework 1. count() was always called on $this->_data at every single call of __set
Is the better performance the reason why count() is not simply called on the data:
public function count()
{
    return count($this->data);
}

?

Fixed with #7256


Add more nested options on NDC nav

This PR moves us closer to the new version of the top menu as proposed here: https://basecamp.com/1756858/projects/13795275/todos/344949987#comment_622956393
For now we have just added the: NDC Comparison, NDC Explorer and NDC Search.

@simaob let me know if you want me to take this PR from here 🖐


Rename coords --> cvalues in crsapi.jl

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.96%. Comparing base (f911da5) to head (0e8b772).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   94.96%   94.96%
=======================================
  Files          22       22
  Lines        1033     1033
=======================================
  Hits          981      981
  Misses         52       52

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create website header with empty nav

Add logo
Add navigation bar

Approved :green_circle:
Hi @meryemsanem ,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights :heavy_check_mark:

[x] Git flow is used correctly :white_check_mark:
[x] Clean code :white_check_mark:

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


Performance/RangeInclude should not correct when argument to include? is a range

It is possible to provide a Range to Range#include? like range.include?(arg) to check that range.begin <= arg.begin && arg.end <= range.end.  Unfortunately rubocop auto-corrects this from include? to cover?, which does not provide the same result

Expected behavior
Rubocop should not detect these cases
Actual behavior
Rubocop detects and auto-corrects
Steps to reproduce the problem
(self.begin..self.end).include?(token.begin..token.end)
RuboCop version
0.42.0 (using Parser <IP_ADDRESS>, running on ruby 2.2.3 x86_64-darwin14)

This is not a behaviour of Ruby. It's added through monkey patching by ActiveSupport. 😀
Our official stance right now is that we can't take into consideration different frameworks. (This should eventually be handled by extensions for each framework.)

Ah, of corse that old scamp ActiveSupport ;)
I'll rubocop:disable for now, thanks!


regproducer action use of "bytes" type is confusing

The eosio.system/regproducer action takes a producer name, a producer key, and a params bundle. However the producer key argument is of type "bytes" which appears to be a string of ascii encoded hexadecimal values. This differs from the eosio.bios contract's setprods action which uses the type "public_key" for the equivalent key value. The "public_key" value is consistent with keys as presented by the existing key manipulating and formatting tools such as the wallet and the default config file generator.

I see the abi of regproducer is already using public_key value. I'm closing this issue.


Keep user state upon reconnection

Hi again :) , i am playing with https://github.com/endel/tic-tac-toe and i see that sometime one client maybe lost connection (While users are on the go, the data source will often switch towers and or downgrade/upgrade between 2G and 3G).
So i think if server hold the client session, then when client want to re connect, they can send that session id again to go to current playing room.
(i really do not know detail of that feature , but some where they are using ping and pong message between client and server to find if client lost connection or not)
It is very importance in real online game, so it is awesome if we have that feature!
Thanks so much!

Hey @takaaptech, thanks for checking out the tic-tac-toe demo!
I never experienced this switch you mentioned, are you sure the connection is lost because of this switch?
I'm not sure how to deal with authentic disconnects in parallel with lost connections. Maybe a good idea would be to wait, say, 10 seconds after any disconnection, and only trigger the disconnection handler in case nobody tries to reconnect with that session id during this period.

Hi, switching between 2G/3G or 3G and wifi cause change ip address maybe the point! I need to build corona sdk tic tac toe version and then deploy to mobile for test now :)

Closing this feature as it doesn't seem to be relevant. Please feel free to reopen it if you think this is important for your project.


Title: iOS Crash when selecting items

When using the drag-select-compose library in a my project, selecting items works properly on desktop and Android, but causes a crash on iOS with the following exception:
Uncaught Kotlin exception: kotlin.native.internal.IrLinkageError: Function 'toggleable' can not be called: No function found for symbol 'androidx.compose.foundation.selection/toggleable|toggleable@androidx.compose.ui.Modifier(kotlin.Boolean;androidx.compose.foundation.interaction.MutableInteractionSource;androidx.compose.foundation.Indication?;kotlin.Boolean;androidx.compose.ui.semantics.Role?;kotlin.Function1<kotlin.Boolean,kotlin.Unit>){}[0]'
https://github.com/user-attachments/assets/1bf466fb-1935-4d7b-b817-3d374614d407

It turns out the library is not compatible with my Compose version.


Broken 'resizeWindow' with docker and electron in Testcafe

I have an issue using resizeWindow from Testcafe inside a docker container while testing an electron app with gitlab.
Note: On local setup (linux) all tests work as expected, but inside the docker container resizeWindow does not seem to work. Other tests inside the container work as well.
Maybe i'm missing any configuration for xvfb or should i use fluxbox?
Any suggestion how to solve this?

Test error with docker:
$ yarn test-e2e-ci
yarn run v1.22.4
$ node -r @babel/register ./internals/scripts/CheckBuildsExist.js && cross-env NODE_ENV=test testcafe electron:./ci ./test/e2e/DockerTest.e2e.ts --screenshots takeOnFails=true
 Running tests in:
 - Electron 9.0.4 / Linux 0.0
 Docker execution
 ✖ `ResizeWindow` works as expected
   1) AssertionError: expected 1024 to deeply equal 100
      Browser: Electron 9.0.4 / Linux 0.0
          8 |
          9 |test('`ResizeWindow` works as expected ', async t => {
         10 |  await t.resizeWindow(100, 100);
         11 |  const innerWidth = await t.eval(() => window.innerWidth);
         12 |  const innerHeight = await t.eval(() => window.innerHeight);
       > 13 |  await t.expect(innerWidth).eql(100);
         14 |  await t.expect(innerHeight).eql(100);
         15 |});
         16 |
         at <anonymous>
      (/builds/netqa-devs/myFancyProject/test/e2e/DockerTest.e2e.ts:13:30)
         at fulfilled
      (/builds/myFancyProject/test/e2e/DockerTest.e2e.ts:5:58)
 1/1 failed (8s)

Warnings:
 Warnings (3):
 --
  Was unable to resize the window due to an error.
  The
  /builds/myFancyProject/node_modules/testcafe-browser-tools/bin/linux/glibc-64/resize
  process failed with the null exit code.

Using resizeWindow inside a docker container with electron.
What is the Current behavior?
resizeWindow does not seem to work, a warning is thrown, the size is not adapted.
What is the Expected behavior?
The electron app should resize itself in docker.
What is your web application and your TestCafe test code?
see above example

see above example

see above example

Your complete configuration file (if any):

Your complete test report:

Screenshots:

Steps to Reproduce:

Go to my website ...
Execute this command...
See the error...

Your Environment details:

testcafe version:
node.js version:
command-line arguments:
browser name and version:
platform and version:
other:

Hi @zerocewl
Yes, are right. You need to correctly install and setup the fluxbox tool.
See an example in our docker related files:

https://github.com/DevExpress/testcafe/blob/master/docker/Dockerfile
https://github.com/DevExpress/testcafe/blob/master/docker/testcafe-docker.sh


[Testing] Fixing issues reported by PT

Issues reported: https://docs.google.com/spreadsheets/d/1wIoFFfaSb4Fvs0WJG3dUTiaVtQuZhwc_xiwnspsZSJ4/edit?gid=1061436948#gid=1061436948

Release getting tracked here: https://github.com/NipunSahAIyak/web-orchestrator/issues/27


Instana cannot find process

Trying to add instana to our Node/Express API and we're getting the following log in our Instana Agent using
require('@instana/collector')();
Version 1.71.2
2019-08-27T13:08:40.420-0700 | INFO  | na-http-thread-4 | LoggerEndpoint                   | 51 - com.instana.agent - 1.1.505 | Node.js collector (pid: 8, reporting pid: 8): Transitioning from agentHostLookup to unannounced
2019-08-27T13:08:40.421-0700 | ERROR | na-http-thread-1 | Nodejs                           | 114 - com.instana.discovery-nodejs - 1.2.11 | Could not find the process NodejsProcess{pid='8', pidFromParentNS='false', name='node', arguments=[app.js], cpuSetFileContent='/ecs/prod-21/89a71c9121a24a0f879dfa0d215ae004/106e69fc7ec0d0bb24c2c80934020d2402608990586186837eece669e79b57c0
', fd='14', inode='socket:[34521786]'}.
2019-08-27T13:08:40.424-0700 | INFO  | na-http-thread-3 | LoggerEndpoint                   | 51 - com.instana.agent - 1.1.505 | Node.js collector (pid: 8, reporting pid: 8): Announce attempt failed: Announce to agent failed with status code 404.

Not sure what is causing this issue, any ideas?

Hi @chrisjcodes,
please use https://support.instana.com/hc/en-us/requests/new for inquiries like that. Actually, one of your colleagues already opened a ticket with a log snippet that contains this issue (Ticket #9359).
There I can see the following timeline of events in the log:
2019-08-28T13:33:27.558-0700 | INFO | na-http-thread-1 | LoggerEndpoint | 51 - com.instana.agent - 1.1.507 | Node.js collector (pid: 8, reporting pid: 8): Transitioning from agentHostLookup to unannounced
2019-08-28T13:33:27.568-0700 | ERROR | na-http-thread-2 | Nodejs | 114 - com.instana.discovery-nodejs - 1.2.11 | Could not find the process NodejsProcess{pid='8', pidFromParentNS='false', name='node', arguments=[app.js], cpuSetFileContent='/ecs/{REDACTED}
', fd='14', inode='socket:[30036766]'}.
2019-08-28T13:33:27.571-0700 | INFO | na-http-thread-4 | LoggerEndpoint | 51 - com.instana.agent - 1.1.507 | Node.js collector (pid: 8, reporting pid: 8): Announce attempt failed: Announce to agent failed with status code 404. Will retry in 60000ms
2019-08-28T13:33:34.601-0700 | INFO | 08-c1070c5bf75b) | Docker | 153 - com.instana.sensor-docker - 1.1.55 | Activated Sensor
2019-08-28T13:33:35.381-0700 | INFO | heduler-thread-3 | AgentHttpServiceImpl | 51 - com.instana.agent - 1.1.507 | Listening on {REDACTED}
2019-08-28T13:34:27.578-0700 | INFO | na-http-thread-4 | LoggerEndpoint | 51 - com.instana.agent - 1.1.507 | Node.js collector (pid: 8, reporting pid: 8): Overwriting pid for reporting purposes to: 19583
2019-08-28T13:34:27.580-0700 | INFO | na-http-thread-2 | LoggerEndpoint | 51 - com.instana.agent - 1.1.507 | Node.js collector (pid: 8, reporting pid: 8): Changing pid to 19583
2019-08-28T13:34:27.581-0700 | INFO | na-http-thread-3 | LoggerEndpoint | 51 - com.instana.agent - 1.1.507 | Node.js collector (pid: 8, reporting pid: 19583): Transitioning from unannounced to announced
2019-08-28T13:34:34.726-0700 | INFO | ae-61f5e82ffdf9) | Nodejs | 154 - com.instana.sensor-nodejs - 1.2.11 | Activated Sensor
2019-08-28T13:34:34.753-0700 | INFO | ae-61f5e82ffdf9) | Process | 155 - com.instana.sensor-process - 1.1.36 | Activated Sensor for PID 19583
2019-08-28T13:34:34.777-0700 | INFO | ae-61f5e82ffdf9) | NodejsTrace | 156 - com.instana.sensor-nodejs-trace - 1.2.3 | Activated Sensor
2019-08-28T13:34:37.591-0700 | INFO | na-http-thread-3 | LoggerEndpoint | 51 - com.instana.agent - 1.1.507 | Node.js collector (pid: 8, reporting pid: 19583): Reporting unhandled promise rejections is disabled.
2019-08-28T13:34:37.591-0700 | INFO | na-http-thread-4 | LoggerEndpoint | 51 - com.instana.agent - 1.1.507 | Node.js collector (pid: 8, reporting pid: 19583): Agent is ready to accept.
2019-08-28T13:34:37.591-0700 | INFO | na-http-thread-2 | LoggerEndpoint | 51 - com.instana.agent - 1.1.507 | Node.js collector (pid: 8, reporting pid: 19583): Transitioning from announced to agentready
2019-08-28T13:34:37.593-0700 | INFO | na-http-thread-4 | LoggerEndpoint | 51 - com.instana.agent - 1.1.507 | Node.js collector (pid: 8, reporting pid: 19583): Reporting uncaught exceptions is disabled.
2019-08-28T13:34:37.607-0700 | INFO | na-http-thread-3 | LoggerEndpoint | 51 - com.instana.agent - 1.1.507 | Node.js collector (pid: 8, reporting pid: 19583): The Instana Node.js collector is now fully initialized.

TL;DR: The Instana agent needs to inspect the Docker container the Node.js app is running in to be able to match the process information the Node.js app is reporting during the initial handshake to an actual OS level process the agent sees (directly on the host or in a container). The first attempt failed because we had not yet inspected the Docker container. However, we retry this automatically. Once the Docker info was there, the handshake between the Node.js app and the Instana agent worked, as you can see.


[Market Page] - The indicator showing that an order is mine shows only after a refresh

Describe the bug
The arrow indicating that the resting order is mine appears only after a refresh.
To Reproduce
Simply place a limit order, notice that the "arrow" showing that the order is yours is not there. Refresh.
Expected behavior
We should see the arrow pointing to my order the moment I submit it.
Screenshots

Additional context/device information
Add any other context about the problem here.

Resolved in commit https://github.com/InjectiveLabs/injective-dex/commit/c25c4a9aab5bd90603f44cc9b53e62cc08d7a239


Use HTTP Only config

Use http_only config from config/session.php

This seems to break the test suite.


Atom throwing error when attempting to view a package's settings and README

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode (Author's note: was unable to reproduce in safe mode, but caused a separate issue there. Please see description for more details.)
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
When I install a particular Atom package and try to open the settings to view the README, I get the following error:
Uncaught NodeError: The "path" argument must be of type string. Received type object
    at assertPath (path.js:39:11)
    at Object.isAbsolute (path.js:1144:5)
    at sanitize (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2663474)
    at /Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2663633
    at t.exports (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:3267594)
    at new PackageReadmeView (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2663041)
    at PackageDetailView.renderReadme (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:826124)
    at PackageDetailView.updateInstalledState (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:825697)
    at PackageDetailView.populate (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:824249)
    at PackageDetailView.completeInitialization (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:819589)
    at PackageDetailView.loadPackage (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:819801)
    at new PackageDetailView (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:816387)
    at SettingsView.getOrCreatePanel (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:957781)
    at SettingsView.showPanel (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:958502)
    at HTMLDivElement.clickHandler (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2636770)

This issue only occurs with this particular package. I am not able to reproduce this issue in safe mode, however. When I run Atom in safe mode, it shows the settings screen fine but says there is no README file. I have tried all of the other steps in the Prerequisites section, but haven't been able to find an existing solution that works for me.
Steps to Reproduce

Install react-rnative-snippets via Install window (Atom -> Preferences -> Install)
Click on the package to view the settings and README
Error message appears

Expected behavior:
I should be able to view the settings and README for this package.
Actual behavior:
I receive the error mentioned above.
Reproduces how often:
Every time
Versions
0.1.3
Additional Information
OS: macOS Catalina 10.15.3
Atom version: 1.45.0

I can confirm that this issue is also occurring on another Atom user's system. I know they have macOS but do not know the version or the version of Atom they used either. If this could help solve the issue, please let me know and I will find out from them.

Issue was solved. It was being caused by the presence of the word Image in the read me without being wrapped by backticks. Settings panel was trying to parse it as an actual image.


Extension incorrectly reports Nonexistent passage when using nested quotes

For testing purposes, I made a strange passage name:
:: Test Pagination "'Nested Buttons'" [pagination:5 demo]

Elsewhere, I have a macro refer to this passage:
<<act "Passage with less pages than current" "Test Pagination \"'Nested Buttons'\"">><</act>>

I get a warning on the second parameter saying: Nonexistent passage: "Test Pagination \"'Nested Buttons'\""sc2-ex(110)
I expected no warnings.
This is how the macro is defined in my config:
    act:
      name: act
      container: true
      parameters:
        - text |+ (passage|undefined) |+ text

@BawdyInkSlinger
My advice, don't create Passages with names like that! :)

@BawdyInkSlinger My advice, don't create Passages with names like that! :)

perhaps twee notation update incoming? 👺

perhaps twee notation update incoming? 👺

Assuming you mean the Twee specification, it has no issues with such passage names.

@Tranberry

perhaps twee notation update incoming? 👺

a. The File Type section of the current (v3.0.2) version of the Twee 3 Specification recommends that the Twee file be UTF-8 based.
Which means that any Unicode character can be used inside such a file.
b. The Passage Header section of the specification explains what characters have special meaning within such a header, and that you need to escape those special characters if you want to include any of them within a Passage or Tag Name.
This section includes no restrictions about using any Unicode character within the Passage Header.
c. The Passage Name section recommended not using the special characters that make up the syntax of a "Markup based Link" as part of the Name of a Passage, but it doesn't forbit such usage.
So in theory you can use any Unicode character in a Passage Name, as long as you escape any of the characters that have specially meaning.
But to make things easier for yourself, and others, you might not want to go crazy with what characters you use in the Name of a Passage.... :)

sometimes limits just makes things better than no limits

Perhaps this issue can be reopened? I think this fix causes warnings on new kinds of passage name's:
<<act "See what she does next." "\"A monster girl!\"-Intro-46">><</act>>

<<act "Drag her out of your home." "\"A monster girl!\"-Intro-46">><</act>>

<<act "Scream in terror." "\"A monster girl!\"-Intro-46">><</act>>

<<act "Skip Intro (Not recommended!)" "Tutorial" "act__button--metagame">><</act>>

:: \"A monster girl!\"-Intro-46 [nohud noinventory nojournal pagination:7 demo]

But to make things easier for yourself, and others, you might not want to go crazy with what characters you use in the Name of a Passage.... :)

Yeah, I agree. For what it's worth, these passage names were generated with code. I have since modified that code to generate better passage names.


VOD: Respond to deletion event, delete Asset

Deprioritized, since we're not charging for storage. Could be a small change when we decide to start charging for storage.


Catch chmod exception in repository checkout. (#closes 242)

It turns out the file was a dangling symlink (status=256) and chmod couldn't be run on it, since the file it was pointing to was deleted.

LGM


dask dashboard not showing workers after cluster.stop_workers(cluster.jobs)

On PBS with dask-jobqueue #25
If I start a cluster, kill workers with cluster.stop_workers(cluster.jobs)  and try to restart a new cluster, then workers do not show up in the dashboard.
Is it expected behavior?
Could we do something about this?

I believe this was just noise on my part, deeply sorry.
It works fine today with:

cluster.stop_workers(cluster.jobs)

and then:
cluster.start_workers(4)

Even client.restart() and client.upload_file() are working.
I have other issues (workers dying) but these will motivate other posts.
Sorry again


Projection widget fails when on SQL CE and the pager is displayed

More specifically, the DefaultHqlQuery.Count() method fails because the SQL generated is not compatible with SQL CE.
Example query generated to get count of content items:
select count(distinct contentite0_.Id) as col_0_0_
from Orchard_Framework_ContentItemVersionRecord contentite0_
  inner join Orchard_Framework_ContentItemRecord contentite1_
    on contentite0_.ContentItemRecord_id=contentite1_.Id
  inner join Orchard_Framework_ContentTypeRecord contenttyp2_
    on contentite1_.ContentType_id=contenttyp2_.Id
where (contenttyp2_.Name in ('BlogPost'))
  and contentite0_.Published=1

SQL CE does not support count(distinct ), and so this query fails, which results in an exception being thrown, and if the query is being executed within the context of the ProjectionPartDriver, the projection shape will not be displayed.

I should add that this is against the latest dev.

Look at the file history, we did a change in the past weeks that must have done that. It was encapsulating the query instead. Safe is to revert, unless you find a way that is best for the two issues.

@jersiovic this is about the change you made on HQL I think

@paynecrl97 Try to revert this to see if it fixed your issue: https://github.com/OrchardCMS/Orchard/commit/020cb8b8bf402864a8974ef2770cde9c5d712a2e

@sebastienros it does. https://github.com/OrchardCMS/Orchard/pull/7563


Store Playback Information in JSON File.

Related Issue: #156
Description
This feature implements an interface for other applications to read
information about the current song and playback status of the player.
The interface consists of a JSON-formatted file, located at:
%APPDATA%\Google Play Music Desktop Player\playback-information.json
The file includes the following attributes:

isActive: (bool) Whether or not the player is running
isPlaying: (bool) Whether or not a song is currently playing
song: (string) The name of the current song
artist: (string) The artist of the current song
album: (string) The album of the current song
imageURL: (string) An URL to the current song or album image

Changes
All changes should be self-explanatory, but just to make sure:

PlaybackAPI class is introduced to manage the current playback status.
New JavaScript interface setPlaybackStatus is introduced to
update the "isPlaying" attribute of the playback information.
The existing JavaScript interface songChangeEvent is used to update
the song, artist, album, and imageURL attributes of the playback
information.
The FormClosing event of the main application is used to set the
isActive attribute to "false" just before the player closes so the
file reflects that state properly.

Also, can we add some information about this feature to the README :smile:

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Google Play Music/PlaybackAPI.cs, line 13 [r1] ([raw file](https://github.com/marshallofsound/google-play-music-desktop-player-unofficial-/blob/e2af0b217f11f6954b53f42ddb5fbce5e9de8320/Google Play Music/PlaybackAPI.cs#L13)):
Somewhere else (I believe in our CEF settings) I target the %APPDATA%\\GPMDP directory.  Can we be consistent and use that directory?

Comments from the review on Reviewable.io

In my latest commit 2a42d5d I've added a documentation for the interface, mentioned it in the README.md and changed the path from "Google Play Music Desktop Player" inside %APPDATA% to just "GPMDP" inside %APPDATA%.

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, all discussions resolved.

Google Play Music/PlaybackAPI.cs, line 13 [r1] ([raw file](https://github.com/marshallofsound/google-play-music-desktop-player-unofficial-/blob/e2af0b217f11f6954b53f42ddb5fbce5e9de8320/Google Play Music/PlaybackAPI.cs#L13)):
Sweet

Comments from the review on Reviewable.io


adding more vulnerability helper methods

Coverage decreased (-0.08%) to 11.033% when pulling 554437f52519f4fbb3227270f2fb09de16a9085e on ek-add-vulnerablity-methods into c075799f6921d60aa101c1b701099291bc95423a on master.


Visibility feature

Description
add visibility feature to passwords in login and signup page
Related Issues
fixes #354
Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.

[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I am working on this issue under GSSOC

fix allignment

bro still issue.

fixed

depolyment issue.


Infer the data type for LiteralTransformFunction

Description

Infer the data type for LiteralTransformFunction so that the parent transform function can read the correct data type
Fix the data type handling for CaseTransformFunction and use STRING type to handle non-numeric types
For BinaryOperatorTransformFunction, use the lhs expression as the main data type, and match rhs data type with lhs, e.g.

stringCol > 123 will use string comparison
intCol > '123' will use integer comparison

Codecov Report

Merging #7332 (13789ac) into master (f11b5d6) will decrease coverage by 2.11%.
The diff coverage is 73.52%.

@@             Coverage Diff              @@
##             master    #7332      +/-   ##
============================================
- Coverage     71.39%   69.27%   -2.12%
+ Complexity     3284     3190      -94
============================================
  Files          1503     1110     -393
  Lines         73871    51922   -21949
  Branches      10699     7760    -2939
============================================
- Hits          52738    35968   -16770
+ Misses        17538    13381    -4157
+ Partials       3595     2573    -1022

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
69.27% <73.52%> (+0.18%)
:arrow_up:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ator/transform/function/CaseTransformFunction.java
54.36% <16.66%> (+25.13%)
:arrow_up:

...r/transform/function/LiteralTransformFunction.java
75.40% <83.33%> (+19.64%)
:arrow_up:

...form/function/BinaryOperatorTransformFunction.java
30.13% <100.00%> (+3.21%)
:arrow_up:

...a/org/apache/pinot/common/metrics/MinionMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...g/apache/pinot/common/metrics/ControllerMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/BrokerQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/MinionQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pache/pinot/common/utils/grpc/GrpcQueryClient.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...he/pinot/common/messages/SegmentReloadMessage.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...not/common/lineage/SegmentLineageAccessHelper.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 597 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f11b5d6...13789ac. Read the comment docs.


Small updates in different pages

The requirements of the updates are in pages 4, 8, 9, 11 and 12 in the UpdatedSurveyJuly document

It also includes the functions of validating the postal code at UI, removing the fields of <lat, lng> from the formdata, and retrieving the postal code from <lat,lng> at UI,


Fix broken link in documentation

Description
This PR fixes a broken link to Grafana, which causes the linting check to fail.

/merge


Chrome shows 'not secure' when running https://gene.iobio.io

Same in firefox. The reason is that some of the requests are being made over http. For example, http://iobio.io/public/images/blog/gene_3.0/banner.png. In order to fix that we'll need to get iobio.io working on https, which we've needed to fix for a while anyway.
You can see all the insecure requests in the network tab when you run gene.

If this is still outstanding, then it looks like something we need to address.

Looks fixed to me

in Firefox

Looks fixed, why reopen?

Because it still shows as not secure on Firefox

Making a new issue for Firefox specifically so we don't have to follow the thread and be misled by the issue title


Webpack/babel/grunt/gulp script to compile json

If I want multiple files to separate info, and help structure up the config, I'd need some precompilation step, that generates the json before it converts to the haproxy-config.
One way would be to use webpack/babel/grunt or gulp, to achieve that

Done in separate project, not released to public yet


曹超群-青藏高原森林覆盖度

队员
曹超群
作品名称
青藏高原森林覆盖度
作品网址
https://caochaoqu.github.io/
其他说明
1、地图数据来源于项目 2、利用高德开放平台进行制图 3、利用Mobirise进行网页制作

Great work.
But I do not understand why you show the dynamic of precipitation instead of forest coverage rate which is your mapping theme.
So I suggest you can switch from precipitation to forest coverage rate, if it is possible.

Because forest cover is closely related to precipitation. In the current figure, we can directly see the changes of forest cover in different areas with different precipitation.

Teacher,Thank you for your praise and advice.
And why I show the dynamic of precipitation instead of forest coverage rate is Because forest cover is closely related to precipitation. In the current figure, we can directly see the changes of forest cover in different areas with different precipitation.


RST-6267 new password configuration

Jira link (if applicable)
https://tools.hmcts.net/jira/browse/RST-6267

Odd git log history


New aka.ms/azsdk links

The main goal of this PR is to define what links to create in aka.ms based on existing links. The intention is to:
Fix #8516
While investigating how to solve #8516, we ended up to this list of tentative links to fix: https://gist.github.com/sadasant/7f4f00f433577b66fd016136c4312e7e
From that experience, I've been able to narrow this down to the following replacement:

Replacing links matching: https://azuresdkdocs.blob.core.windows.net/$web/javascript/.
To links that begin with this instead: https://aka.ms/azsdk/js/<service>/docs.

Then I'm only picking some of these links, to make sure I follow the guidelines here: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/233/Azure-SDK-AKA.ms-Links
The entirely new aka.ms links I'm ending up with are:

New Blob
Original link

azsdk/js/identity/docs
https://azure.github.io/azure-sdk-for-js/identity

azsdk/js/service-bus/docs
https://azure.github.io/azure-sdk-for-js/servicebus

The other similar links (links with the same root, but targeting different classes or with other different parameters) will not be changed, to minimize the number of aka.ms links we make.
I also found some aka.ms links that need to be updated:

Original
New

azsdk-js-search-ref-docs
azsdk/js/search/docs

azsdk-js-textanalytics-ref-docs
azsdk/js/textanalytics/docs

azsdk-js-formrecognizer-ref-docs
azsdk/js/formrecognizer/docs

azure-sdk-preview1-js
azsdk/releases/july2019preview

Keep in mind that I will only generate the aka.ms entries once this is approved.
Besides these changes, this investigation also led me to the following other changes:

To replace the TypeScript guidelines from their older link, https://azuresdkspecs.z5.web.core.windows.net/TypeScriptSpec.html, to their actual link https://azure.github.io/azure-sdk/typescript_introduction.html. Is this change correct? Should I make this another aka.ms link?
I removed sdk/eventhub/ThirdPartyNotices since there's a better file in the same directory: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/eventhub/thirdpartynotice.txt . Is this correct?
Removed all of the broken https://azure.github.io/azure-sdk-for-js/* links on the CHANGELOG files, specially since our other CHANGELOGs are generally not linking when making references to classes, etc.

Please let me know how does this look.

/check-enforcer evaluate

Please double check that the akas are created.

/check-enforcer evaluate

The changes in the storage packages look good to me. Thanks.


License

The LICENSE.md file linked to in the README is missing. Could you add it please? Also, the INSTALL.txt states the license is GNU, I suppose you want to update this to MIT.

Oh indeed, thanks for pointing that out, we changed from GNU GPL to MIT

changed and resolved. thanks for highlighting


STM32 circular BDMA - single buffer

related to issue #702
The purpose of this PR is to allow Peripheral->Mem transfer using circular BDMA in the embassy-stm32 DMA library.
The new method start_circular_read() fulfill this purpose.
As a first implementation of this new method, the read_continuous() method has been developped in the adc f1 library (stm32f103) and a new example has been developed in the stm32f1 example directory (adc_dma.rs)

closing since DMA already has ringbuffer support nowadays


Animation icon overlaps if motion name is too short

The Animation icon overlaps if the Motion name is too short. It could use some minimum additional padding.

Fixed in #3


HTML WebGL support

Description
#500 brings support for the compatibility renderer. However, we haven't been successful getting an HTML export working. It's unclear if this is due to our process, or bugs in Terrain3D or Godot.
Here is the process so far.
A key point is that the terrain build, the export template, and export settings need to match the same thread support. All three marked on or off.
Docs
Building instructions
https://docs.godotengine.org/en/stable/contributing/development/compiling/compiling_for_web.html
Godot Export for web docs
https://docs.godotengine.org/en/stable/tutorials/export/exporting_for_web.html
Building
To build the extension for web you must install emscripten, set up the build environment, then build the web assembly version. I installed with scoop, which is how my python is also installed, per the Godot building instructions.
Emscripten seems to be very finicky about versions. Akien reports they are using v3.1.64 for 4.3 stable builds.
$ scoop install<EMAIL_ADDRESS>
# then I restarted my terminal to get the updated path to finish installing emscripten

$ emsdk install 3.1.64
$ emsdk activate 3.1.64

# finally setup the build environment
$ source ~/scoop/apps/emscripten/current/emsdk_env.sh

# build
$ scons platform=web target=template_debug threads=no

$ ls project/addons/terrain_3d/bin/*.wasm
project/addons/terrain_3d/bin/libterrain.web.debug.wasm32.wasm

This file needs to be added to terrain.gdextension
web = "res://addons/terrain_3d/bin/libterrain.web.debug.wasm32.wasm"

These are also untested possibilities:
web.debug = "res://addons/terrain_3d/bin/libterrain.web.debug.wasm32.wasm"
web.release = "res://addons/terrain_3d/bin/libterrain.web.release.wasm32.wasm"

web.wasm32.nothreads = "res://addons/terrain_3d/bin/libterrain.web.debug.wasm32.nothreads.wasm"
web.debug = "res://addons/terrain_3d/bin/libterrain.web.debug.wasm32.wasm"

Exporting

Select custom template debug: web_dlink_nothreads_debug.zip, which I found here: C:/Users/Cory/AppData/Roaming/Godot/export_templates/4.3.stable/web_dlink_nothreads_debug.zip
Enable Extensions Support
Ensure Threads Support is disabled to match the other settings
Vram compressed textures don't work for me on Edge. They don't load in the log. They stop complaining with VRam uncompressed.

Upload to Webserver
After export, the full package must be uploaded to a webserver. Itch or your own. That server must be configured with SharedArrayBuffer & Cross Origin Isolation.
In nginx this can be enabled with:
    location ^~ /terrain3d/ {
        add_header "Cross-Origin-Opener-Policy" "same-origin";
        add_header "Cross-Origin-Embedder-Policy" "require-corp";
    }

On Itch.io , edit game, find the Embed Options section and enable:
SharedArrayBuffer support - (Experimental) This may break parts of the page or your project. Only enable if you know you need it.
Running
I built w/ 4.2.2 and seemed to mostly load but error messages complained that my scene files were built for 4.3?? So I built and exported everything with 4.3: godot source, godot-cpp, Godot binary, Godot export templates.
Edge complained about being unable to load the textures if compressed with vram compressed. But no complains using vram uncompressed.
Currently it loads to the godot logo, then our demo scene w/ player and blue sky, but the terrain doesn't render and has no collision.

Errors & Solutions
Uncaught (in promise) LinkError: WebAssembly.instantiate(): Import #0 "env" "memory": mismatch in shared state of memory, declared = 1, imported = 0
This is a mismatch of thread options: https://github.com/godotengine/godot/issues/94537
Set all to threaded or not threaded.

for refrence, this project is a working example of GDextension exported to web, and is under MIT
https://github.com/kiwijuice56/sand-slide - working example in chrome browser in itch.io too!

Ok, I have the demo scene building and loading. Updated instructions in Op.
https://tokisan.com/terrain3d/demo.html
However there are three problems:

The mouse isn't captured, so the camera doesn't move (but the mouse wheel does work)
Terrain collision doesn't work. But it works on the tunnel.
The terrain doesn't render. The console reports a problem with shader compilation:

 USER ERROR: SceneShaderGLES3: Vertex shader compilation failed:
 ERROR: 0:460: 'usampler2DArray' : No precision specified
 WARNING: 0:718: '/' : Zero divided by zero during constant folding generated NaN

    at: _display_error_with_code (drivers/gles3/shader_gles3.cpp:254)
 USER ERROR: Method/function failed.
    at: _compile_specialization (drivers/gles3/shader_gles3.cpp:348)

New url. Back tick ` will also capture the mouse, and arrow keys will turn the camera.
https://tokisan.com/terrain3d_demo/demo.html
It seems that all the samplers need highp. Including those in uniforms.glsl.
Here's the full console log, after adding additional highps:
console_log.txt
The last remaining shader error is:
demo.js:474  ERROR: 0:528: '[' : array index for samplers must be constant integral expressions
also 535, 536.

These lines are:
demo.js:459 528: 			vec2 m_decal_uv=(((vec2(((m_cosa * m_uv.x) - (m_sina * m_uv.y)), ((m_sina * m_uv.x) + (m_cosa * m_uv.y))) - (vec2(((m_cosa * m_dus_editor_decal_position[m_i].x) - (m_sina * m_dus_editor_decal_position[m_i].y)), ((m_sina * m_dus_editor_decal_position[m_i].x) + (m_cosa * m_dus_editor_decal_position[m_i].y))) * m_dus_vertex_density)) * m_size) * m_dus_vertex_spacing);

demo.js:459 535: 			float m_decal=smoothstep(0.10000000149012, 1.0, texture(m_dus_editor_decal[m_i], (m_decal_uv + 0.5)).r);
demo.js:459 536: 			m_albedo=mix(m_albedo, m_dus_editor_decal_color[m_i].rgb, (m_decal * m_dus_editor_decal_color[m_i].a));

I'm not sure why webgl doesn't like these array indices compared to our other array indices.

texture(m_dus_editor_decal[m_i], (m_decal_uv + 0.5)).r`

I think this should be texture(_editor_decal, vec3(decal_uv + 0.5, float(i))). In my own custom shader, accessing an array index this way was working, but when I put this into the glsl file and compiled, Godot reports this in the desktop. Didn't try webgl yet:
SHADER ERROR: Invalid arguments for the built-in function: "texture(sampler2D[3],vec3)".

Alright, next error is 256 instances of this before it stops:
GL_INVALID_OPERATION: Mismatch between texture format and sampler type (signed/unsigned/float/shadow).
WebGL: too many errors, no more errors will be reported to the console for this context.

I changed controlmap to sampler2DArray and put in floatBitsToUint() around the calls. However that didn't fix it or change the number of errors. I don't have any shader dumps or identification as to what line it doesn't like.

did you catch all 5 instances of the control map reads?

No, I have 7 instances. 5 in main, 1 editor functions, 1 debug views. Worked on desktop.

theres actually a few more in debug views now you mention that, but those shouldnt cause problems unless they are on.

I have it rendering something now.
https://tokisan.com/terrain3d_demo/demo.html

This is using the minimum shader with a gradient color applied.
Albedo is only blue. These grey spots appear only near the camera, and they are usually constantly moving around, even when the camera is still. But at some angles they are still.
Removing source_color from the mouse depth didn't help
Just highp with a usampler didn't work. This needed highp and sampler/floatbitstouint.
Holes work surprisingly. I thought it complained about dividing by 0 before, but it doesn't care about it now.
Here's my working minimum.txt shader.
This full_shader.txt
produces the errors noted above.

This version of the full shader works. working_shader.txt

#512 has a working web build. Now I don't get any grey artifacts with the same setup, but building with CI. On chrome I get 45-60fps, on edge I get only 1fps. Previously I had 45-60fps on edge with artifacts.


Distance ignored in ThreeDScene

Hi,
So I'm trying to plot some data in a ThreeDScene, and I am finding that the distance argument is being ignored. So for example, here is a simple class:
class Scene6d_Autometa4(ThreeDScene):
	def construct(self):
		# Note to keep the coverage looking roughly the same scale as x and y, we are going to
		# divide the raw numbers by 100
		axes = ThreeDAxes(x_min = -50, x_max = 50, y_min = -50, y_max = 50, z_min = 0, z_max = 70)
		circle = Circle()
		self.set_camera_orientation(phi=80 * DEGREES,theta=45*DEGREES,distance=12000,gamma=30*DEGREES)
		self.play(ShowCreation(circle), ShowCreation(axes))
		self.move_camera(phi=30*DEGREES,theta=-45*DEGREES,run_time=3, distance = 200)
		self.wait(2)

The numbers are a bit extreme because I was trying to see if anything made a difference. Note the axes max/min reflect the data I'm going to plot. Anyway, here is the result of the above:

Note, the distance doesn't change as the camera changes angle, as I expected to happen.
This was run using the official Docker image. I've only just started using manim so I haven't dug that deep into the code. Has distance been implemented?
Thanks,
Jason

Update: I found that the Docker image had a commit from July, so I tried pulling the latest commit on master, and got the same result. Although the current version is faster but appears to ignore requests to write a gif (will only write mp4). I guess that is another issue, though.

Hi @jason-c-kwan , I have the same problem. The distance is ignored, I don't know where the problem comes from ?!!


PyTorchJob does not run

I deployed Kubeflow (including Kubeflow Training operator) in a local Kubernetes by
export PIPELINE_VERSION=2.0.0
kubectl apply --kustomize="github.com/kubeflow/pipelines/manifests/kustomize/cluster-scoped-resources?ref=${PIPELINE_VERSION}"
kubectl wait crd/applications.app.k8s.io --for=condition=established --timeout=60s
kubectl apply --kustomize="github.com/kubeflow/pipelines/manifests/kustomize/env/platform-agnostic?ref=${PIPELINE_VERSION}"

Then I deployed a training job by
kubectl create --filename=https://raw.githubusercontent.com/kubeflow/training-operator/master/examples/pytorch/simple.yaml

It stucks there forever
➜ kubectl get pytorchjobs --namespace=kubeflow
NAME             STATE   AGE
pytorch-simple           30m

Any ideas? Thanks! 😃

I am wondering if it is related with my controller-manager pod is in CrashLoopBackOff
Curious if this controller-manager is the "controller" mentioned here:

By default, PyTorch Operator will be deployed as a controller in training operator.

Can you check events? Anything in controller logs? Can you do
kubectl describe pytorchjobs --namespace=kubeflow

Thanks @johnugeorge !
I guess you mean workflow controller pod log?
I am using the default one from Kubeflow based on this doc:

By default, PyTorch Operator will be deployed as a controller in training operator.

I verified I have pytorchjobs.kubeflow.org by:
➜ kubectl get crd
NAME                                                   CREATED AT
addons.k3s.cattle.io                                   2023-04-15T03:35:35Z
helmcharts.helm.cattle.io                              2023-04-15T03:35:35Z
helmchartconfigs.helm.cattle.io                        2023-04-15T03:35:35Z
agents.agent.k8s.elastic.co                            2023-04-15T08:52:23Z
apmservers.apm.k8s.elastic.co                          2023-04-15T08:52:23Z
beats.beat.k8s.elastic.co                              2023-04-15T08:52:23Z
elasticmapsservers.maps.k8s.elastic.co                 2023-04-15T08:52:23Z
elasticsearchautoscalers.autoscaling.k8s.elastic.co    2023-04-15T08:52:23Z
elasticsearches.elasticsearch.k8s.elastic.co           2023-04-15T08:52:23Z
enterprisesearches.enterprisesearch.k8s.elastic.co     2023-04-15T08:52:23Z
kibanas.kibana.k8s.elastic.co                          2023-04-15T08:52:23Z
stackconfigpolicies.stackconfigpolicy.k8s.elastic.co   2023-04-15T08:52:23Z
alertmanagerconfigs.monitoring.coreos.com              2023-04-15T09:56:53Z
alertmanagers.monitoring.coreos.com                    2023-04-15T09:56:53Z
podmonitors.monitoring.coreos.com                      2023-04-15T09:56:53Z
probes.monitoring.coreos.com                           2023-04-15T09:56:53Z
prometheuses.monitoring.coreos.com                     2023-04-15T09:56:53Z
prometheusrules.monitoring.coreos.com                  2023-04-15T09:56:54Z
servicemonitors.monitoring.coreos.com                  2023-04-15T09:56:54Z
thanosrulers.monitoring.coreos.com                     2023-04-15T09:56:54Z
scheduledsparkapplications.sparkoperator.k8s.io        2023-04-24T18:42:36Z
sparkapplications.sparkoperator.k8s.io                 2023-04-24T18:42:36Z
kafkaconnects.kafka.strimzi.io                         2023-04-25T00:26:39Z
kafkaconnectors.kafka.strimzi.io                       2023-04-25T00:26:39Z
kafkabridges.kafka.strimzi.io                          2023-04-25T00:26:39Z
kafkamirrormakers.kafka.strimzi.io                     2023-04-25T00:26:39Z
strimzipodsets.core.strimzi.io                         2023-04-25T00:26:39Z
kafkamirrormaker2s.kafka.strimzi.io                    2023-04-25T00:26:39Z
kafkas.kafka.strimzi.io                                2023-04-25T00:26:39Z
kafkarebalances.kafka.strimzi.io                       2023-04-25T00:26:39Z
kafkatopics.kafka.strimzi.io                           2023-04-25T00:26:39Z
kafkausers.kafka.strimzi.io                            2023-04-25T00:26:39Z
strimzischemaregistries.roundtable.lsst.codes          2023-04-27T16:55:28Z
artifacts.artifact.apicur.io                           2023-04-30T06:15:54Z
catalogsources.operators.coreos.com                    2023-04-30T06:54:45Z
clusterserviceversions.operators.coreos.com            2023-04-30T06:54:45Z
installplans.operators.coreos.com                      2023-04-30T06:54:45Z
olmconfigs.operators.coreos.com                        2023-04-30T06:54:45Z
operatorconditions.operators.coreos.com                2023-04-30T06:54:45Z
operatorgroups.operators.coreos.com                    2023-04-30T06:54:45Z
operators.operators.coreos.com                         2023-04-30T06:54:45Z
subscriptions.operators.coreos.com                     2023-04-30T06:54:45Z
apicurioregistries.registry.apicur.io                  2023-04-30T06:57:21Z
rayclusters.ray.io                                     2023-07-04T22:36:14Z
rayjobs.ray.io                                         2023-07-04T22:36:14Z
rayservices.ray.io                                     2023-07-04T22:36:15Z
mpijobs.kubeflow.org                                   2023-07-10T03:55:46Z
mxjobs.kubeflow.org                                    2023-07-10T03:55:46Z
paddlejobs.kubeflow.org                                2023-07-10T03:55:47Z
pytorchjobs.kubeflow.org                               2023-07-10T03:55:47Z
tfjobs.kubeflow.org                                    2023-07-10T03:55:47Z
xgboostjobs.kubeflow.org                               2023-07-10T03:55:48Z
clusterworkflowtemplates.argoproj.io                   2023-07-10T05:44:21Z
cronworkflows.argoproj.io                              2023-07-10T05:44:21Z
scheduledworkflows.kubeflow.org                        2023-07-10T05:44:21Z
viewers.kubeflow.org                                   2023-07-10T05:44:21Z
workfloweventbindings.argoproj.io                      2023-07-10T05:44:21Z
applications.app.k8s.io                                2023-07-10T05:44:21Z
workflows.argoproj.io                                  2023-07-10T05:44:21Z
workflowtaskresults.argoproj.io                        2023-07-10T05:44:21Z
workflowtasksets.argoproj.io                           2023-07-10T05:44:21Z
workflowtemplates.argoproj.io                          2023-07-10T05:44:21Z

Hmm, just wonder which pod log should I print out given I am using standalone training operator, thanks!
➜ kubectl get pods -n kubeflow
NAME                                               READY   STATUS    RESTARTS      AGE
metadata-writer-79d569c46f-km7nh                   1/1     Running   0             17h
metadata-envoy-deployment-59687d9798-f2bxl         1/1     Running   0             17h
ml-pipeline-persistenceagent-84f946b944-zcs5d      1/1     Running   0             17h
ml-pipeline-scheduledworkflow-54d88874b-mcd49      1/1     Running   0             17h
ml-pipeline-viewer-crd-75c6d588df-pwd4c            1/1     Running   0             17h
cache-deployer-deployment-779655b9f7-gr9z5         1/1     Running   0             17h
workflow-controller-5f6fdf89d7-pcg2z               1/1     Running   0             17h
ml-pipeline-ui-679784dfd6-c4r4h                    1/1     Running   0             17h
minio-549846c488-pb6q6                             1/1     Running   0             17h
ml-pipeline-visualizationserver-7f8f7fdbdc-w6w6k   1/1     Running   0             17h
mysql-5f968d4688-mtqr4                             1/1     Running   0             17h
cache-server-55c88c76c5-p9hpx                      1/1     Running   0             17h
metadata-grpc-deployment-6d744c66bb-k9w92          1/1     Running   2 (17h ago)   17h
ml-pipeline-867f66dc54-sfc2f                       1/1     Running   1 (17h ago)   17h

There should be a training operator pod when you install Kubeflow. I see that pipelines is the only component that is installed

Sorry, I guess
export PIPELINE_VERSION=2.0.0
kubectl apply --kustomize="github.com/kubeflow/pipelines/manifests/kustomize/cluster-scoped-resources?ref=${PIPELINE_VERSION}"
kubectl wait crd/applications.app.k8s.io --for=condition=established --timeout=60s
kubectl apply --kustomize="github.com/kubeflow/pipelines/manifests/kustomize/env/dev?ref=${PIPELINE_VERSION}"

does not install training operator, right?
I was confused by this sentence at https://www.kubeflow.org/docs/components/training/pytorch/#installing-pytorch-operator
I thought when install Kubeflow pipelines, it also comes with training operator which is not:

I guess after installing Kubeflow pipelines, I have to install training operators separately. Please correct me if I am wrong. I have another question at https://github.com/kubeflow/training-operator/issues/1855 regarding how the version matches.
Anyway, I will try Kubeflow pipelines 2.0 and Kubeflow Training Operator 1.6 see if they work together, and report the results. Thanks!

Thanks @johnugeorge !
I finally succeed deploying Kubeflow Training Operator 1.6 based on https://github.com/kubeflow/training-operator/issues/1841#issuecomment-1635334868
Here is my scripts
# Install Kubeflow Pipelines
export PIPELINE_VERSION=2.0.0
kubectl apply --kustomize="github.com/kubeflow/pipelines/manifests/kustomize/cluster-scoped-resources?ref=${PIPELINE_VERSION}"
kubectl wait crd/applications.app.k8s.io --for=condition=established --timeout=60s
kubectl apply --kustomize="github.com/kubeflow/pipelines/manifests/kustomize/env/platform-agnostic?ref=${PIPELINE_VERSION}"

# Install Kubeflow Training Operator
# Based on https://github.com/kubeflow/training-operator/issues/1841#issuecomment-1635334868

# Create a PyTorch training job
kubectl create --filename=https://raw.githubusercontent.com/kubeflow/training-operator/master/examples/pytorch/simple.yaml

However, this PyTorch training job succeed:

But the job is not listed in my Kubeflow UI:

I feel this Kubeflow Training Operator does not connect with my Kubeflow Pipelines correctly. Any ideas? Thanks!

No. Kubeflow pipelines is a ML workflow orchestrator. It is up to you to decide the workflow graph. If you want to see training job inside pipelines UI, you have to trigger the job within a pipeline experiment .

I see, thank you so much, @johnugeorge !
A demo machine learning code is at https://github.com/Hongbo-Miao/hongbomiao.com/pull/9807/files
And I can see it starts to train and show in the UI 😃


Use Rust 1.69

And fix new clippy errors

Current dependencies on/for this PR:

main

PR #4065   👈

This comment was auto-generated by Graphite.

Hopefully doesn’t break Conda but will keep an eye on it in the next release: https://github.com/conda-forge/rust-feedstock/pull/139


Proper pip requirements file added

To run
pip install -r requirements.txt

proper package name with version required, the above command just look the package name and the version what user want to install
pip install packageName  in requirement will not work
By the way great project 👍🏻

Thanks for the improvement :+1:


fix: mistakely removes compaction inputs on failure

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)

fixes #3633

What's changed and what's your intention?
This PR fixes the the incorrect behavior that removes compaction inputs instead of outputs on compaction failure.
Checklist

[ ]  I have written the necessary rustdoc comments.
[ ]  I have added the necessary unit tests and integration tests.
[x]  This PR does not require documentation updates.

I added a test for this case https://github.com/GreptimeTeam/greptimedb/pull/3636. If the test also fails in CI, I'll merge this PR into the main branch to make the test pass.


Adjust test for new random quantization formats

lucene now randomly adjusts quantization params, etc. and consequently this test sometimes doesn't return exactly a score of 0. Adjusting to ensure we are never negative.
Related: https://github.com/apache/lucene/pull/14049
closes: https://github.com/apache/lucene/issues/14051

oh I see; I think in other cases like this, I disabled the randomness, but easing the constraint seems OK too.


Improve import file extension handling

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Describe the Feature
import:
  - ue1-globals
  - catalog/eks.yaml

Note the incidental .yaml here.
Error:
Error: Error in function call

  on /modules/utils/stack-config.variant line 71:
  (source code not available)

with opt.config-dir as "./stacks",
     opt.stack as "ue1-auto".

Call to function "import" failed: /modules/utils/stack-config.variant:12,13-20: Error in function
call; Call to function "import" failed: /modules/utils/stack-config.variant:10,43-50: Invalid
function argument; Invalid value for "path" parameter: no file exists at
stacks/catalog/eks.yaml.yaml; this function works only with files that are distributed as part of
the configuration source code, so if this file will be created by a resource in this configuration
you must instead obtain this result from an attribute of that resource...

Error: Error in function call

  on /modules/utils/stack-config.variant line 71:
  (source code not available)

with opt.config-dir as "./stacks",
     opt.stack as "ue1-auto".

Call to function "import" failed: /modules/utils/stack-config.variant:12,13-20: Error in function
call; Call to function "import" failed: /modules/utils/stack-config.variant:10,43-50: Invalid
function argument; Invalid value for "path" parameter: no file exists at
stacks/catalog/eks.yaml.yaml; this function works only with files that are distributed as part of
the configuration source code, so if this file will be created by a resource in this configuration
you must instead obtain this result from an attribute of that resource...

Error: 1 error occurred:
        * step "write varfile": job "terraform write varfile": config "config-component": source 0: job "stack config": /modules/utils/stack-config.variant:71,13-20: Error in function call; Call to function "import" failed: /modules/utils/stack-config.variant:12,13-20: Error in function call; Call to function "import" failed: /modules/utils/stack-config.variant:10,43-50: Invalid function argument; Invalid value for "path" parameter: no file exists at stacks/catalog/eks.yaml.yaml; this function works only with files that are distributed as part of the configuration source code, so if this file will be created by a resource in this configuration you must instead obtain this result from an attribute of that resource...

Expected Behavior
A clean error/warning or just allow the extension.
Use Case
It seems reasonable some people may choose to add an extension; ex: yaml vs yml.
Describe Ideal Solution
Allow an extension or default to yaml.
Alternatives Considered
Require no extension, but provide a clean error.
Additional Context

thanks @johncblandii
note that @osterman  did not want to use extensions in stack names on purpose and be opinionated

That's cool. Then let's handle it if someone does use one on an import with a clean error.

closing since this is updated (and new functionality added) in the new version of atmos starting with 1.0.0.
Extension can be anything now, if no extension is specified, .yaml is assumed by default


LST Staking generic contract (StakingValidator for Starknet first)

Description
LST factory and StakingValidator factory fully Open source from day 1.
Basically mint an aX token, starting with the aSTRK one, aETH and aBTC coming later.
Check the Docs of the Starknet Staking contract:
https://docs.starknet.io/staking/overview/
StakingValidator have a main address for the validator (AFK), but can delegate to another validators.
We can add a validator AFK bonus in the contract for future plan.

[ ] Create a Factory contract to stake LST that call a StakingValidator component.
[ ] Create a StakingValidator interface (can be one for Starknet first, but gonna implement and deploy another for ETH & BTC)
[ ] StakingValidator can stake deposit to the main validator (AFK) with a bonus points, or every validators.
[ ] Access control
[ ] Add Upgradeable contract
[ ] Deposit and withdraw fees with set functions and admin check
[ ] Set functions for Staking validator address

Tackling this issue:

I will first checkout Starknet staking contract docs
I will study other LST smart contract implementation,
I will implement it using Cairo

Can I be assigned to this?

Hi, I'm a Cairo Developer, ready to get to work on this,

I'd go through the Staking Contract Docs, to map out the architecture of the program, as it would influence the StakingValidator Interface,
For access control and upgradeability, I'd use the openzepellin components, and then ensure the deposit fees and withdraw fees have the admin check,
and also add a function to set the staking validator address.

Let me handle this issue!

May I pick this up? first time contributor

can i work on this
ETA 24hrs


Fix for OSFUSE-425: First arg of log methods should be String format constant string.

Fixed up lots calls but needs more review.

retest please

test this please

@chirino seems like that the Jenkins plugin cannot test PRs other than for master (probably a git fetch --all is missing somewhere).

BTW, if you don't mind I'm going to implement the solution we discussed for log.info() in d-m-p.

and make a release off the latest d-m-p only with this change.

hmm. just saw that the redhat branch depends on dmp 0.16.9 (current version: 0.17.2).
@chirino If its ok for you and would help you I could do 0.16.10 only with the log changes (0.16.9 was the latest 0.16.x release)

test this please

retest this please

retest this please

[merge]


feat(User): Add default profile picture when user does not have a picture

What this PR does 📖
1. Create a random identicon when user create an account, and use it if user does not have a profile picture

2. Split functions with warnings in 2 functions, to not happen problem anymore

Which issue(s) this PR fixes 🔨

Resolve #881

Special notes for reviewers 🗒
Additional comments 🎤

missing linter 🔨

the comment from phil still happens with latest commit 🔨

same here 🔨

@lgmarchi

First Paragraph, I thought the same, but or I change everywhere I am calling profile_picture, or change profile_picture() in warp to always get default polkadot when pfp is empty, updating default work as normal profile picture. So in this case way I did is less work or change warp as well. What do you think is better? And that tool from Rust, Deref would work here?

I think that even if the change to profile_picture() is done in Uplink instead of Warp (as you have done in this PR), the user's DID could probably be used to generate the same picture, making it unnecessary to save the picture and save the path to it. That's all. Then again, if we ever want to use a different default profile picture, we may want to save the file. Your way may be better.
I withdraw my comment about storing the picture in memory :grin:
I still like the idea of a reset button.

@sdwoodbury requesting your review due to your changes requested

I agree with you, I just do not know if worth more to change method directly into Warp, let way it is now or change all calls from profile picture in Uplink.
My main thought was to ensure that developers do not inadvertently call the wrong method and receive an empty string instead of the default profile picture, so I have decided to upload default profile picture to Warp. This is centred around a single location that handles the upload of the default profile picture. This strategy guarantees that the profile_picture() method, when invoked from the entity, will always return a valid result or default profile picture.

As discussed, what could be done would be to use the Identity wrapper in https://github.com/Satellite-im/Uplink/blob/af4b0dc3b237acf7d24e924e1c6b3f6a568eeaab/common/src/state/identity.rs#L8 to create a Identity::profile_picture that would perform a check to determine if the picture is set within the inner Identity from warp and if not to fallback to using the default picture provided in this pr.
I do have one possible idea on how i could have you do this in warp indirectly but would have to experiment a little first.


Upgrade the json gem in the Gemfile

The GitHub Workflows build (in Pull Request #294 ) shows hundreds of instances of the following message:
/home/runner/work/sessionizer/sessionizer/src/vendor/bundle/ruby/2.7.0/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
I will submit a pull request addressing this issue after Pull Request #294 is merged.

Removing the sdoc gem allowed the json gem to be upgraded.  This issue is now resolved.


[Coverity CID :190617]Control flow issues in /subsys/net/lib/lwm2m/lwm2m_rw_json.c

Static code scan issues seen in File: /subsys/net/lib/lwm2m/lwm2m_rw_json.c
Category: Control flow issues
Function: do_write_op_json
Component: Networking
CID: 190617
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

Fixed in merged commit:
https://github.com/zephyrproject-rtos/zephyr/commit/181544beec6b20991593672491a05af9efec2fb0#diff-a4d0f86a3fa08e60a99ec94935e3b6dd
Closing.


[Candidate 3v3 Nocky Mountains ZH v2] Many rocks are floating above terrain

Observed behaviour
Many rocks are floating above terrain.
Expected behavior
Rocks sit on terrain.
Screenshots

sadly those are not tiltable by WB

Have you tried lowering the rocks? They'd go into the mountain and only psrt of them would stick out, which would look fine imo, since mountains do have random rocks sticking out. Lots of maps already do this.

well yes ofc i did this with the bigger rocks but those smal flat road rocks you cant lower on those slopes, you just wont see any of them i d need to have the option to tilt them. So not only the option to rotate arround Z also to X and Y

In this instance I agree with xezon, rocks should not be floating, they can be lowered or moved into the mountain so that only some are showing and do not look odd. If it cannot be fixed then I would rather the rocks get removed. However, I think it can be fixed.

Has this been fixed? I downloaded the map and I don't see the 'float'.

nope i didnt fixed it

Perhaps I closed by mistake. I can recheck.

@xezon is as designed

Doesn't look very good tbh

Uploading v3 of this map now with fixed rocks and terrain height.

In my opinion so many floating rocks like seen in this map are a blocker. As my edit is rejected, I suggest move map to backlog

Promoted to blocker as per Dominator request.

this is a joke its not noticeable as you play the map (as in the normal gameview ss), all rocks do touch the ground on a certain point (this is how the WB works), its a game engine thing that you cant even place it like i would want to because there is no tilt function in the options.

I will look at it again.

For me, it becomes more annoying now because I know about it. But also you can easily see shadows under many rocks when they should not be there. This is at regular angle. Some players do use alternative angles and anyone should be able to take a good screenshot from any angle in my view and it still look good. I would just remove the rocks as players do not care and less objects probably means a few more FPS

NoMerci, whats your latest view on this?
Do you wanna fix / remove the rocks, otherwise I suggest not to become RANKED. Without RANKED status, it wont get played so much. I even did the work and removed these rocks for you but you rejected it.

i m waiting for xezons feedback

i m waiting for xezons response

Xezon is taking 1 month break from the project.
It's likely he will come back and say it should be fixed. Why not just fix it?
So many people delaying this crappy project it's a joke

xezon do have the newest version since 1.10.23 so i ll wait to his response

@xezon is this no fixed and can be closed?

Did you move the rocks closer to terrain? If not, then this issue should be still valid.
With default camera pitch, this issue is mostly obvious by the displaced shadows under the rocks.

in the newest version those are moved, for me its totaly fine cause you d never see it in a live game.

Unclear to me what has changed. Rocks still float above terrain everywhere. The problem is these flat stones are not really fit to be placed on slopes. It would probably work better with high rocks that can be pushed into slopes generously.

I do not think it should be a blocker either. You can negotiate with Dominator.
But I do think it would be nice to fix. The flat rocks do not even look good, despite floating.

I think it's mega unprofessional to have so many floating rocks, especially when I already spent 30 mins fixing and removing them all for you. You'd rather revert my efforts and make the map look bad. Some of the rocks can be seen from normal camera view as I showed before

I think it's mega unprofessional to have so many floating rocks, especially when I already spent 30 mins fixing and removing them all for you. You'd rather revert my efforts and make the map look bad. Some of the rocks can be seen from normal camera view as I showed before

you did some fixes on an old version but nvm

I do not think it should be a blocker either. You can negotiate with Dominator.
But I do think it would be nice to fix. The flat rocks do not even look good, despite floating.

well thats a taste thing I do like them you dont thats a art thingy

Note that previous editions of Ranked Maps had less scrutiny. The first edition had no checks. I try to be fair in judgement for all new maps.
I can see that fixing the rocks is difficult, because there are so many of them.

Demoted from blocker, because rocks sit on impassable terrain and are no detriment to game play areas.

There are still floating rocks visible on some cliffs. Bug is no longer a blocker. Polish at will, otherwise can be closed.

Polished mostly. Done.


ValueError: could not broadcast input array from shape (1,2048) into shape (98,1024)

I'm trying to build a Attention mechanism for Medical report Generation using Chest X-rays.
train, test = train_test_split(data, test_size = 0.2, random_state = 1, shuffle = True)
print(train.shape)   - (3056, 4)
print(test.shape)   - (764, 4)
Function for Extracting the Images:
def image_feature_extraction(image1,image2):
  image_1 = Image.open(image1).convert('RGB')
  image_1 = np.asarray(image_1)

  image_2 = Image.open(image2).convert('RGB')
  image_2 = np.asarray(image_2)

    #normalize the values of the image
  image_1 = image_1/255
  image_2 = image_2/255

    #resize all image into (224,224)
  image_1 = cv2.resize(image_1,(224,224))
  image_2 = cv2.resize(image_2,(224,224))

  image_1 = np.expand_dims(image_1, axis=0)
  image_2 = np.expand_dims(image_2, axis=0)

    #now we have read two image per patient. this is goven to the chexnet model for feature extraction

  image_1_out = final_chexnet_model(image_1)
  image_2_out = final_chexnet_model(image_2)

  #conactenate along the width
  conc = np.concatenate((image_1_out,image_2_out),axis = -1)

  #reshape into(no.of images passed, length*breadth, depth)
  image_feature=tf.reshape(conc,(conc.shape[0], -1, conc.shape[-1]))
  #image_feature = feature_extraction_model([image_1,image_2])

  return image_feature

print(image_2_out)
KerasTensor(type_spec=TensorSpec(shape=(None, 1024), dtype=tf.float32, name=None), name='Chexnet_model/avg_pool/Mean:0', description="created by layer 'Chexnet_model'")
train_features = np.zeros((3056,98,1024))
for row in tqdm(range(train.shape[0])):
image_1=train.iloc[row]["image1"]
image_2=train.iloc[row]["image2"]
train_features[row] = (image_feature_extraction(image_1,image_2))
0%|          | 0/3056 [00:00<?, ?it/s]
ValueError                                Traceback (most recent call last)
 in
2   image_1=train.iloc[row]["image1"]
3   image_2=train.iloc[row]["image2"]
----> 4   train_features[row] = (image_feature_extraction(image_1,image_2))
ValueError: could not broadcast input array from shape (1,2048) into shape (98,1024)

您好：       来信我已收到，我会尽快回复的。

收到。


[DOC]: A bit of guidance through inference please??!

📚 The doc issue
After finishing stage 3 of PPO for the Chat application, the state dictionary got saved as per the implementation.
Now I'm trying to make an inference using the examples/inference.py file but I'm facing errors regarding loading the saved state_dict into the pretrained model.
Here's the command I used (I provided the pretrain argument inside the code), bloom-rlhf is the final saved state_dict after the PPO training, and not the optimizer checkpoint:
python3 inference.py --model bloom --model_path bloom-rlhf
Here's one line of the error:
size mismatch for transformer.word_embeddings.weight: copying a param with shape torch.Size([250880, 64]) from checkpoint, the shape in current model is torch.Size([250880, 4096]).
and this type of error happens for pretty much all the layers of the model.
I also get errors of: Missing keys for the second layer and onwards, as well as errors of Unexpected keys in the saved state_dict.
I would really appreciate some guidance here as the documentation only mentions serving the model via the interface, which doesn't support the model I fine-tuned (BLOOM).
I tried to load the HuggingFace model as well as the fine-tuned one and they both caused the mentioned errors.
How can I please correctly run the inference? Is it something with the pretrained model? with the state_dict?

something

Thanks for your advise， you should use '--pretrain' to pass 'bloom-rlhf' .

Thanks for the suggestion, you should pass "--pretrain"  the same as ppo stage.

Yes I did pass it by default in the same way as in the PPO stage, but same error.

Thanks for the suggestion, you should pass "--pretrain" the same as ppo stage.

Yes I did pass it by default in the same way as in the PPO stage, but same error.

Can I take a look at the script you used in the third stage?

Sure, here it is:
torchrun --standalone --nproc_per_node=4 train_prompts.py --prompt_dataset /pretrain_dataset.json --strategy colossalai_zero2 --model bloom --rm_model bloom --rm_pretrain model/bloom-sft --rm_path /rm_model/bloom-rm.pt --save_path /rlhf_model/bloom-rlhf --need_optim_ckpt True
The other arguments that I haven't explicitly passed are set by default in the code
First I had a suspicion that I didn't specify the .pt extension for the --save_path argument because the output file was only 30MB, but then I saw that it's used as a state dictionary so it's supposed to be relatively small in size, no?
Thank you for your help!


False Warning on no-unused-vars

Is this a bug report?
Debatable, but yes.

Can you also reproduce the problem with npm 4.x?

Yes
Steps to Reproduce
Have an unused variable named _, for example:
const auth = response.headers.get('Authorization');
const [_, authToken] = auth.split(' ');

Notice the following false warning is logged:
'_' is assigned a value but never used  no-unused-vars
Changing the unused var to _name or something does no good.
Expected Behavior

The above code example is good idiomatic javascript. It should not be linted. If this is kept as a default rule, it should be changeable without ejecting.
Actual Behavior

No way to suppress this false warning.

I don't think that's idiomatic? Using underscore as a variable name has no special meaning. For example, this fails.
const ab = [1,2];
const [a, _] = ab;
const [_, b] = ab;
// SyntaxError: Identifier '_' has already been declared

Destructuring does support ignoring specific values, you just need to not put any name there.
const [, authToken] = auth.split(' ');

Destructuring does support ignoring specific values, you just need to not put any name there.

👍
That's the solution.
_ in particular is problematic because it is often used for import _ from 'lodash' which, if you don't use it, will unnecessarily increase your bundle size.


Add a root screen for picking photos from the photo library

Should fix https://github.com/artsy/emission-nebula/issues/8 - due to the plist changes.
Will comment inline.

Fails

:no_entry_sign:

No CHANGELOG added.

:no_entry_sign:

Please assign someone to merge this PR, and optionally include people who should review.

  Generated by :no_entry_sign: dangerJS

I got caught by https://github.com/facebook/jest/issues/919#issuecomment-280769085 due to only including @2x assets - took a bit of time

WRT the comments, yeah, I need to dig into those a bit further next, but this PR is the blocker on the chain of a bunch of stuff


Have a toggle between the old snapGrid and the new one

Please describe the feature that you want to propose
I would like a toggle between the old snapGrid and the new one. I was using the old one in my code and with this update it broke everything. I understand why users would like the snapGrid[10, 10] to move in increments of 10 based off of 0, 0. But I also like the idea of moving over 545 for where it is now, but snapGrid[545, 30] now does it in reference to 0, 0. That is what I use in my code. If things are not aligned at 0, 0. it completely throws off the dragging feature.  I have made a temporary fix :
const handleDragStart = (node, event) => {
// 545 is what the snapGrid is set to and where the node goes to on drag
     if (node.position.x == 545){
         // 625 is the actual node.position.x that I want it to be at.
         node.position.x = 625
      }
 }

This is temporary and only works for some of my nodes. I hope that this feature can be created so I don't have to look into a more permanent fix. I believe that the toggle could look something like:     snapGridAtZero={true/false}

Sorry, I don't understand the issue. Do you want to use a snap grid or not?

@moklick We could allow switching between snapping modes by allowing more values for the snapToGrid boolean. So change https://github.com/wbkd/react-flow/blob/7a909e942527daecb01fb78a4cfc00d5f46330ab/src/types/component-props.ts#L95 to snapToGrid?: boolean | 'absolute' | 'relative' to avoid breaking changes.

@moklick We could allow switching between snapping modes by allowing more values for the snapToGrid boolean. So change
https://github.com/wbkd/react-flow/blob/7a909e942527daecb01fb78a4cfc00d5f46330ab/src/types/component-props.ts#L95
to snapToGrid?: boolean | 'absolute' | 'relative' to avoid breaking changes.

@wardoost @moklick I like that a lot

@WillBaker2017 I don't like it :D The old version was broken, because it was not one grid but multiple ones. If you want a special snap behaviour you can use onNodesChange or alter nodes when dragging is false for example.


fix: delimiter check cleanup

I went through the code to understand the algorithm a bit better and was confused by the delimiter check. From my understanding this does what the delimiter check is supposed to do (but saving a small amount of work).
While making this change, I also did some minor cleanup, where I changed some select calls to simd_max and tried to make the code in smith_waterman_macro/src/lib.rs and src/simd.rs look more similar. This is not really important, and I can remove some of these changes if you prefer.
(I also added a toolchain file and set codegen-unit=1 to try to improve performance, though it only gives a very minor boost overall - I see about 3-4% quicker benchmark times for match_list from this pull request compared to main and no real difference in nucleo_match_list.)

Sorry you had to read the code to understand the algorithm, I ought to write up an ALGORITM.md... The delimiter check was meant to give a bonus to matches that come after a delimiter. For example, with a needle hw and haystack hello_world, the w match would get the DELIMITER_BONUS since the match comes directly after a delimiter.

What confused me is mainly that the right side of https://github.com/Saghen/frizbee/blob/f2ae8310efe196772a9cc3d804eb5b4f54f88e3f/src/simd.rs#L149-L155 doesn't depend on j, but it is saved in an array that updates for every j.
If it is on purpose that the i=1 case in https://github.com/Saghen/frizbee/blob/f2ae8310efe196772a9cc3d804eb5b4f54f88e3f/src/simd.rs#L115 should be false (the initial value) and following values should depend on the previous char, then it can be moved out after the loop over j (instead of before as I did in this pull request).
Also, this didn't seem to affect performance, but conceptually I think it is a bit nicer to have the delimiters all in one Simd vector and then comparing that with needle_char as a Simd vector, which you can then call any on instead of doing all those bitors.

Sorry you had to read the code to understand the algorithm, I ought to write up an ALGORITM.md...

That's fine, I have started using blink.cmp, and plan to stick with that, so I would want to look at this if I ever want to make a PR to add functionality anyways. :)

The delimiter check was meant to give a bonus to matches that come after a delimiter. For example, with a needle hw and haystack hello_world, the w match would get the DELIMITER_BONUS since the match comes directly after a delimiter.

If this is what you want, maybe you meant to compare with haystack_simd instead of needle_char in https://github.com/Saghen/frizbee/blob/f2ae8310efe196772a9cc3d804eb5b4f54f88e3f/src/simd.rs#L149-L155 and then save to j instead of j-1? (And change the length to 9 so this is possible.) That would depend on j, and then it makes sense why the code is written with all the bitors.

Yep, that's exactly what I was looking for

Also, this didn't seem to affect performance, but conceptually I think it is a bit nicer to have the delimiters all in one Simd vector and then comparing that with needle_char as a Simd vector, which you can then call any on instead of doing all those bitors.

Agreed!

I've incorporated these changes onto main, alongside a few other changes, and marked you as the co-author. Thank you!

It looks good to me. The only thing I would still consider updating is potentially setting codegen-units = 1 and changing the a.simd_gt(b).select(a - b, zero) to zero.simd_max(a - b). E.g. https://github.com/Saghen/frizbee/blob/aca1794c1eb3859e891a37347a92b7ab40b0abe9/src/simd.rs#L129-L130
But it is mostly a question of preference, since the two seem to generate very similar assembly anyways: https://godbolt.org/z/sroffxrT7
(Also this max does nothing: https://github.com/Saghen/frizbee/blob/aca1794c1eb3859e891a37347a92b7ab40b0abe9/src/simd.rs#L152 )

codegen-units = 1

Tested on my system, there was no performance improvement but the build times did increase slightly. If you noticed a difference on your system though, I'll absolutely enable it

a.simd_gt(b).select(a - b, zero)

This one's necessary to make sure we don't get integer overflow

.simd_max(zero);

Nice catch, dropped that one

A bit late, but I've added a README with an explanation of the algorithm

codegen-units = 1

Tested on my system, there was no performance improvement but the build times did increase slightly. If you noticed a difference on your system though, I'll enable it

I think you can just leave it as is. It makes no noticeable difference for me on main. (The difference mentioned above was from the wrong delimiter implementation.)

a.simd_gt(b).select(a - b, zero)

This one's necessary to make sure we don't get integer overflow

Ah, you are right, I totally missed that. I should have noticed that by the different sub commands in the assembly.


Edit Docs

Before:
https://admin-shell-io.github.io/aas-transformation-library/articles/configuration.html
After:
https://alw-iwu.github.io/aas-transformation-library/articles/configuration.html
This is the last PR required before merge of
https://github.com/admin-shell-io/aas-transformation-library/pull/17

Oh and ideally squash this commit as it has quite low granularity


Updated README.md

Had to update the README file to provide clarity and a couple of extra steps needed to run the app locally. The steps were primarily around adding the "Classifier ID" to the app.js file.

thanks!


fix(mssql): handle ibis error when sql with invalid syntax

We found the error 'NoneType' object has no attribute 'lower'.
This issue arises because Ibis invokes the lower() function on a None value when using _get_schema_using_query().
This PR addresses this by implementing error handling to capture this specific scenario and attempt to extract a more informative error message.
Moreover, we will continue following Ibis issue https://github.com/ibis-project/ibis/issues/10331.

Ibis handles this issue at https://github.com/ibis-project/ibis/pull/10332. If we have time to wait for the ibis release, we can close this PR.

Ibis handles this issue at ibis-project/ibis#10332. If we have time to wait for the ibis release, we can close this PR.

Filed https://github.com/Canner/wren-engine/issues/840 to trace it


Depth calculation

Improved the avgOfDepthMat function -- instead of taking the average, you can choose between using k-means clustering or finding contours to calculate depth. The function has now been renamed to usefulDepthMat. Also added a subscriber so the function can be tested -- it listens on the test_depth topic and a filename to an image for testing (e.g. in tf_object_detection/test_bitmaps) can be published to the topic in order to test.
If we need to save space, the test_bitmaps folder where the test cases are can be removed.

Thanks for reviewing this! I added a few replies and will add more commits in line with the comments tomorrow or Wednesday.

I just pushed a commit with some changes and resolved all of the comments that I didn't have any questions on. Also, should I remove the test_bitmaps folder so the test images don't go on the robot by accident?

Per my comment about making a separate test node, I think it makes sense to leave the test bitmaps in. They're not that large compared to e.g. a video file, and worst case we can filter them out in the script which pushes data to the robot.  But having the test images there would make it really easy to verify new changes in the code or tweak config values.

Oh, one other TODO - rename the actual node to something more descriptive than object_detection?  I'm not picky on what that name is, but something that lets us know there's some conversion from depth data to object position.

Kevin's suggestion for a test node from the meeting: could have depth calculation function in one file that is included in the testing node and main node (added as another source file)
e.g. depth_algorithms.cpp, screen_to_world.cpp, test_screen_to_world.cpp

@kjaget I successfully added the test node -- is there anything else I should do on this for now?


AAD Connector

The 21H1 Lab Guide (p30) gives intsructions to run the PS cmdlet Import-Module -Name “C:\Program Files\Microsoft Azure Active Directory Connect\ADPrep\ADSyncPrep.psm1” this does not exist on the DC1 server.

@SteveSmallwood  Please indicate which document you are referring to and what is your feedback. Thanks


Indentation is inconsistent

Please decide on an indentation scheme and stick to it (how many space? use tab or not?)

Dear All,
Single TAB in future for all code indentations.  Will assist in standardisation during code review


Revert "Update Rails to security patched version <IP_ADDRESS>"

Reverts alphagov/smart-answers#2320
This commit was created using bundle update rails but has bumped the major version of sprockets from 2.x to 3.x, which seems to results in a checksum being appended to each compiled JS and CSS asset when we run the regression tests and save the output.
I guess we can either regenerate the artefacts, or turn this behaviour off with a config setting that has been flipped since sprockets version 3.0.2 was released.

Just tried adding the following to config/environments/test.rb
  # disable asset digest for test environment
  config.assets.digest = false

and it seems to prevent the checksum being added to the JS and CSS assets when running the regression tests.

This revert looks fine to me. :+1:
I'd suggest a new PR to re-do the upgrade to rails without the upgrade to sprockets. Then we can think about upgrading sprockets separately.

There is a line in Rails's Gemfile that they require sprockets ~> 3.0.0.rc.1, so not sure how it's possible to not bump the version https://github.com/rails/rails/blob/4-2-stable/Gemfile#L18

I think it's the constraint(s) in rails.gemspec (and possibly the sub-gems) which are used by Bundler. As far as I can see there is no constraint on sprocket-rails: https://github.com/rails/rails/blob/v<IP_ADDRESS>/rails.gemspec#L31. So it ought to be possible to upgrade either by editing the Gemfile.lock as I did above or alternatively adding an explicit dependency on sprocket-rails in the Gemfile with a ~> 2.0 constraint.

Maybe it's worth updating sprockets before Rails, in the 4.2-stable branch, the Gemfile is specifying sprockets ~> 3.0.0.rc.1


Gradle version could be upgraded

It would be trivial to upgrade to 8.7 if anyone feels like sending a pull request.

This was done already with the commit by @snicoll - See: https://github.com/spring-projects/spring-petclinic/commit/85ae6fbc802ba6a57122dd47e4acf4e8a213b912
I think this issue #1539 can be closed.


fix:Google Sheet Plugin Numeric inputs Whitespace issue.

Description

Google sheets plugin: Row limit does not parse properly
When We give a space or enter in the input where an Integer is expected, it is throwing error.

Fixes #8196

By adding a trim() where an integer value is expected, this error is handle
This fix resolves 5 input fields, and also handles enter keys before and after values

Type of change

Bug fix (non-breaking change which fixes an issue)
Unit Test has been added for this issue

How Has This Been Tested?
Use google sheet get query
-While defining the row limit add an additional new line after input value - Error was found and fixed now
-While defining the row limit add an additional new line before input value- Error was found and fixed now
-While defining the row limit add a space before input value- Error was found and fixed now
-While defining the row limit add a space before input value- Error was found and fixed now
Tested for the following input fields
(1) Table Heading Row Index - Error was found and fixed now
(2) Row Offset - Error was found and fixed now
(3) Row Limit - Error was found and fixed now
(4) Cell Range - Error was found and fixed now
Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

Reply to @nidhi-nair query : Do you think we could handle these by trimming all property values at L#47 instead?
Line 47 is processing almost 10 input data, out of this we need validation only for 4 items, so considering unnecessary processing ( trim() ), I have place the trim() in the required 5 places.

@leotom2000 I think we can safely add this check for all other inputs as well. It is valid to expect this validation to exist in all other fields as well. Could you please add the check as common for everything instead?

/ok-to-test sha=5e62b66

/ok-to-test sha=5e62b66

/ok-to-test sha=5e62b66


Time coordinate is inconsistent between files

It's currently the middle of sampling period for GCWerks output, but start of averaging period for Picarro data

When we fix this, need to ensure consistency with resampling function output

Hopefully fixed in PR #43


Revised TLS docs for logging to make differences clearer

Thanks for the suggested wording, @gsmith-sas. Changes made


[backport v2.2] Bluetooth: controller: split: Fix slave latency cancel race

Fix missing transmit buffer demutiplexing before checking if
slave latency needs to be maintained or cancelled.
This bug was detected when new transmit buffer was enqueued
overlapping with on-air radio transmission of empty PDU
preceding the handling of radio event done.
Symptoms of this bug being data transmission latency of upto
slave latency plus one times connection interval.
Backport of #25341.
Fixes #25350.
Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>

@wopu-ot @aescolar you will need this.

Note: Moved to ready in the Backports project without a formal vote in the CCB in order to achieve Bluetooth qualification. All  the relevant stakeholders have seen the Pull Request.