MAINT: remove NPY_INLINE, use inline instead

xref https://github.com/numpy/numpy/issues/22100

The only thing that didn't seem obvious was the M_PI64 substitutions, I guess that's our internal thing.

Indeed, see commit 8250f96b8a0 for context of why that exists. It's higher-precision than M_PI, so this was the easiest solution, rather than add _USE_MATH_DEFINES.

It's higher-precision than M_PI...

Actually, it isn't higher precision.  M_PI64 is precisely the  double precision (i.e. 64 bit floating point) approximation to π.  The lesson learned in https://github.com/scipy/scipy/commit/8250f96b8a09290bcaeeefa437d71451a5d7b6d0 was that if a literal such as 3.14159265358979323846264 (as M_PI might be defined) is used in an expression, the compiler might use extended precision (80 bits) in intermediate calculations before assigning the result of the expression to a double variable.  Normally, that would be fine--who doesn't want a little incidental extra precision?  But that broke the calculation in
https://github.com/scipy/scipy/blob/eee13eb0dca36c185b4335ac5834872b1f614ddb/scipy/special/_cosine.c#L101
which depends on the literal representation of π being exactly the 64 bit approximation.
I think it is fine to use M_PI64 elsewhere, but that specific value is only needed in that one line.  The other uses of M_PI64 could be replaced/reverted to M_PI, if the additional definitions or #includes are added that ensure that M_PI is defined, since it is not standard.

By the way: thanks, @rgommers, for fixing the bug that I introduced in https://github.com/scipy/scipy/commit/8250f96b8a09290bcaeeefa437d71451a5d7b6d0 when I left M_PI undefined.  I guess it continued to work because on all the CI jobs, with the various compilers that we use and the existing NumPy/SciPy #includes, we ended up with a definition of M_PI, even though nothing guaranteed that it would be defined.

Thanks for the extra details @WarrenWeckesser.

The other uses of M_PI64 could be replaced/reverted to M_PI, if the additional definitions or #includes are added that ensure that M_PI is defined, since it is not standard.

As you point out in your second comment, this may have been broken before (or not, hard to tell when header order matters so much and we don't use MSVC in CI anymore). So I considered it, and chose to add 64 rather than add extra defines in meson.build and setup.py - just easier. So my preference would be to leave it as is.


(PUP-10627) Makes last_run_summary.yaml readable for regular users

Before this commit, the last_run_summary.yaml report file (automatically generated after an agent run) was located in /opt/puppetlabs/puppet/cache/state on Linux and C:\ProgramData\PuppetLabs\puppet\cache\state on Microsoft Windows which isn't accessible by any user since it can sometimes contain other files with sensitive data in them. The last_run_summary.yaml does not contain such information.
This commit adds the public folder (full path being /opt/puppetlabs/puppet/public on Linux and C:\ProgramData\PuppetLabs\puppet\public on Microsoft Windows) with 0755(rwxr-xr-x) permissions and changes the last_run_summary.yaml file default path inside it for public access. Similar files can easily be moved here in the future. The folder's existence is ensured after installation or upgrade of a puppet-agent.
The puppet config set publicdir <custom_path> cli command or adding the publicdir = <custom_path> line in the puppet.conf file can be used for changing the path.
Merging this will unlock PA-3253 (acceptance tests for this PR will be run there also).

CLA signed by all contributors.

We should consider updating https://github.com/puppetlabs/puppet-specifications/blob/master/file_paths.md if still maintained. Maybe in a different ticket.

I just noticed this but this seems like a massive step backwards in terms of platform security.
None of this information should be available to ALL users.


test: extends timeout for case client_writes

@Mergifyio refresh

@Mergifyio refresh

Seems the robot is not responding to you lol.

Seems the robot is not responding to you lol.

Seems the robot is not responding to you lol.

That's what I am doing... publish some rule and find out whether the bot works...
Please leave us alone...

Seems the robot is not responding to you lol.

That's what I am doing... publish some rule and find out whether the bot works...
Please leave us alone...


Initializing state definitions with empty resolve object so that reso…

Initializing state definitions with empty resolve object so that resolves can be added within $stateChangeStart.  This would make it possible to create middleware for states.

Feel free to submit this PR against the new fork


Allow full options on Editor

This would close https://github.com/siku2/rust-monaco/issues/20 & https://github.com/siku2/rust-monaco/issues/8
I tried to keep a bit more backward-compatibility relative to the proposal in https://github.com/siku2/rust-monaco/issues/20. But tbh I didn't understand the depth of the Borrows / Derefs.
Edit: after trying this for PRQL — ofc it breaks backward-compat because of the Rc change anyway. So if CodeEditorProps shouldn't be generic, lmk

I appreciate the lengths you went to to keep this backward compatible, but this library is 0.x for a reason so I would've welcomed the breaking change :)
Other than that, the implementation is exactly how I imagined it.


(Analytics Controller) Issues in sending csv email and adding proper error codes and swagger improvements

Sending proper error codes in api response (500 instead of 400) for sending email and error code coverage in analytics controller swagger doc.
There was an error of "Missing final '@ domain'" due to a comma after the email id in env file. This PR resolves #1733

@VivekFitkariwala can we get an updated review on this so we can move towards resolving some of our older PRs?


Update Repo Structure for AppModelConfig and AzureCore

Moved ApplicationModelConfiguration and Core to sdk folder.
Updated sdk structure

@Azure/azure-sdk-eng

FYI @pakrym @AlexGhiondea @maririos
@mariros do you know what the config service is called? Is it just azconfig or is there a different name? We want to know what to name the service folder that will contain it.

@mariros do you know what the config service is called? Is it just azconfig or is there a different name? We want to know what to name the service folder that will contain it.

The name of the service is App Configuration
As for the namespace we are going to use for it, it was just decided in the arch board meeting that it will be Azure.Data.AppConfiguration =>changes to the code to reflect that namespace will come during this week

The name of the service is App Configuration

Thanks. @chidozieononiwu then what you have as appconfiguration as the name for the service folder is correct.


wasm32-unknown-unknown target is too limited

Report
Rinf does smoothly connect Flutter and Rust right now, but there's one clunky part left: the web.
On the web, with the curren target wasm32-unknown-unknown, many native functionalities including std::thread, std::time::Instant, std::fs are not working. This limitation prevents many crates like tokio and rayon from working on the web, leaving the vast majority of Rust ecosystem being fallen out from the web platform.
The goal is to use wasm32-wasi target for the web, so that users can use Rusts's thread, time, file, network APIs and various crates just like they do on native platforms. If we are able to compile Rust crates to wasm32-wasi, the JavaScript polyfill libraries will handle the rest, utilizing existing web APIs.
This is a tracking issue, as this goal cannot be achieved without community support.

[ ] wasmer-js or browser_wasi_shim supports threads polyfill

https://github.com/wasmerio/wasmer-js/issues/332

[ ] wasm-bindgen supports wasm32-wasi target

https://github.com/rustwasm/wasm-bindgen/issues/3421
https://github.com/rustwasm/wasm-bindgen/issues/3454

[ ] wasm-pack supports wasm32-wasi target

https://github.com/rustwasm/wasm-pack/issues/654

[ ] Migrate the Rinf codebase to wasm32-wasi target

Steps to Reproduce
Use any kind of system I/O functionalities on the web. It's very clunky, sometimes even panicking.
System Information
Not really relevant.

https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Proposal.20for.20a.20new.20target.20.60wasm32-wasi-js.60/near/400363817
https://github.com/bytecodealliance/cargo-component
https://github.com/bytecodealliance/jco

https://github.com/temeddix/jco-test

jco might be used as our new JavaScript shim in the future:

https://github.com/bytecodealliance/jco/issues/246
https://github.com/bytecodealliance/jco/issues/247


Not true anymore

This topic should be adjusted (removed) as BC 15 does suppikrt XMLport request pages. Similar issue reported here: #795

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 942855d1-dc6e-495a-ff56-1a0734f48fd4
Version Independent ID: 6ca88cee-4066-a171-13eb-4847698c69c3
Content: The Web client does not support displaying the Request page of XMLPorts. - Business Central
Content Source: dev-itpro/developer/analyzers/uicop-aw0001-requestpageofxmlportscannotbedisplayed.md
Service: dynamics365-business-central
GitHub Login: @solsen
Microsoft Alias: solsen

Correct, thanks for the feedback! The article has been fixed to indicate that the rule only applies to Business Central Spring 2019 (BC14). The update will be published soon.


[BUGFIX] add autocorrect attr override because Mobile Safari hates us

fixes emberjs/ember.js#11869, Cc/ @stefanpenner

Fixed failing test, expect(12) -> expect(13)

Thanks @jayphelps!  Sorry for letting this linger.
Any objections?


feat(cmake-build): Option to allow building shared libraries.

Add option in CMake build to specify that shared libraries should be created (as
opposed to static). This is an exclusive option (not enabled by default).
I'm by no means a CMake specialist (or even fan), but I believe this is the (current) recommend method.

Thanks you!


docs: write "what is autocomplete"

This PR writes the first introduction page, "What is autocomplete".
It describes:

what an autocomplete experience is, in general,
what this library does and doesn't provide.

I feel like the second part is still a bit weak and could use some more technical details, so please suggest any you see missing. Thanks!

Oops, this was a duplicate of https://github.com/algolia/autocomplete.js/pull/393.

Oops, this was a duplicate of https://github.com/algolia/autocomplete.js/pull/393.


Silencing non-pinned dep notifcation

Codecov Report
Base: 78.92% // Head: 78.92% // No change to project coverage :thumbsup:

Coverage data is based on head (2ddc359) compared to base (412bdd6).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   78.92%   78.92%
=======================================
  Files          14       14
  Lines        1177     1177
=======================================
  Hits          929      929
  Misses        248      248

Flag
Coverage Δ

unit
78.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Question] KeyError: 'LlavaConfig' of using cli

Question
'''
python -m llava.serve.cli \

--model-path checkpoints/llava-v1.5-7b-lora \
--model-base checkpoints/vicuna-7b-v1.5 \
--image-file "https://lmg.jj20.com/up/allimg/tp03/1Z921110450D60-0-lp.jpg" \
--load-4bit

[2023-12-25 13:22:09,390] [INFO] [real_accelerator.py:110:get_accelerator] Setting ds_accelerator to cuda (auto detect)
Traceback (most recent call last):
File "/root/miniconda3/envs/llava/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/root/miniconda3/envs/llava/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/zhaobai46a02/LLaVA/llava/serve/cli.py", line 125, in
main(args)
File "/zhaobai46a02/LLaVA/llava/serve/cli.py", line 32, in main
tokenizer, model, image_processor, context_len = load_pretrained_model(args.model_path, args.model_base, model_name, args.load_8bit, args.load_4bit, device=args.device)
File "/zhaobai46a02/LLaVA/llava/model/builder.py", line 48, in load_pretrained_model
tokenizer = AutoTokenizer.from_pretrained(model_base, use_fast=False)
File "/root/miniconda3/envs/llava/lib/python3.10/site-packages/transformers/models/auto/tokenization_auto.py", line 718, in from_pretrained
tokenizer_class_py, tokenizer_class_fast = TOKENIZER_MAPPING[type(config)]
File "/root/miniconda3/envs/llava/lib/python3.10/site-packages/transformers/models/auto/auto_factory.py", line 671, in getitem
model_type = self._reverse_config_mapping[key.name]
KeyError: 'LlavaConfig'
'''
I have already dowload the weight of llava-v1.5-7b-lora and vicuna-7b-v1.5, but when i use cli, it happens like this

the model-path parameter shoule be with a full model
you need to merge the lora model and Vicuna firstly, using this script

I have the same issue. Did you fix it

@Lee-ray-a @chrisx599 Did you manage to solve this?

has anyone fixed it？


Method Tracking System

Common | Forge
This PR adds a ClassTransformer that allows the methods of target classes (mainly interfaces) to be redirected so actions can be executed before and after the method, and even cancel the method or modify it's parameters.
The main reason for this system was to track calls to IItemHandler, IFluidTank, IFluidHandler and IFluidBlock. These are all forge interfaces and will be tracked in SpongeForge.
The way the tracker class system is designed is that no classes will be loaded that could trigger class loading, ASM will be used to read all the TrackerMethods from registered tracker classes. This is already a preparation for the separated core/main mod refactor.
A example of the usage can be found in the SpongeForge PR.

I'd like to take the opportunity to point out that the reason Mixin doesn't support this, is that this kind of global class processing is always going to be expensive. I feel like using tree in this instance is just exacerbating the problem and that if you're going to do this you should use visitor instead to reduce the overhead of this processing. Looking at your code I think that it will actually make it easier to read as well since you're basically emulating visitor pattern but with the added overhead of it being tree.
You're also duplicating some helper method functionality that already exists in Type with some unnecessary helper methods of your own, I have annoted these in the above review.

Also note that when you have a ClassReader/ClassWriter pair you should always pass the reader into the writer's constructor when using "mostly add" operations since this enables the built-in optimisations in ASM for this scenario.

Please let me know when this is ready for pull as GriefPrevention could really use this system to track fluids and item transportation with mods.

@bloodmc It is finished as far I know, unless I missed something.

@Mumfrey does this PR look good to pull?

Also a small note that only one tracker can be registered for every method. But you can mixin into the tracker method classes.


Abort merge if head has been updated before pressing merge

It is possible that a PR head may be pushed to between the merge page being shown
and the merge button being pressed. Pass the current expected head in as a parameter
and cancel the merge if it has changed.
Fix #18028
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Codecov Report

Merging #18032 (1cda077) into main (b24a965) will increase coverage by 0.00%.
The diff coverage is 17.39%.

@@           Coverage Diff           @@
##             main   #18032   +/-   ##
=======================================
  Coverage   45.21%   45.21%
=======================================
  Files         823      823
  Lines       91371    91388   +17
=======================================
+ Hits        41309    41319   +10
- Misses      43465    43473    +8
+ Partials     6597     6596    -1

Impacted Files
Coverage Δ

routers/api/v1/repo/pull.go
29.20% <0.00%> (+0.36%)
:arrow_up:

routers/web/repo/pull.go
30.38% <0.00%> (-0.17%)
:arrow_down:

services/forms/repo_form.go
41.25% <ø> (ø)

services/pull/merge.go
48.33% <25.00%> (-1.06%)
:arrow_down:

services/pull/update.go
54.66% <100.00%> (ø)

modules/charset/charset.go
71.71% <0.00%> (-4.05%)
:arrow_down:

modules/process/manager.go
81.39% <0.00%> (-1.56%)
:arrow_down:

services/pull/pull.go
41.70% <0.00%> (ø)

models/issue_comment.go
53.32% <0.00%> (+0.28%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24a965...1cda077. Read the comment docs.


[BUG] Defaults aren't getting saved in the flow.dag.yaml in the Promptflow UI (AML Studio)

Describe the bug
For a flow, when we fill in the default value through the UI it gets persisted. However, I don't see that information in the flow.dag.yaml. This causes issue, if we download the flow files and start to work within VSCode.
This seems to be a recent issue, I have seen this working in the past.
How To Reproduce the bug
Steps to reproduce the behavior, how frequent can you experience the bug:

Create a flow (Standard)
Update the default value of the input
Save the flow
Switch to the raw file mode
The file doesn't have the defaults populated.

Expected behavior

the raw file of flow.dag.yaml should have the default property setup.

Screenshots
If applicable, add screenshots to help explain your problem.

Running Information(please complete the following information):
Happens in the Prompflow inside the AML studio.
Additional context
Add any other context about the problem here.

Hi @prasann,
Thanks for your feedback. For azure portal related feedback, please refer to Frequency asked questions (FAQ) — Prompt flow documentation and create feedback on azure portal, thanks!


windowsreport.com

This is a windows troubleshooting site and is not malicious

Thanks! The domain has been removed from the list.


SIP50: Web Socket API

This documents proposes a new lightweight real time API based on WebSockets for the reference software.

Please add also to the main page from the SIPs @ohager

Please add also to the main page from the SIPs @ohager

done


Update Catch2 version

Update Catch2 version to v2.13.10
Catch2 v2.13.0 supports BENCHMARK tests.
A new BENCHMARK test "GenShader: ShaderGen Performance" to benchmark document load, validation and shadergen times

This looks very promising, thanks @ashwinbhat!
Looking at the build times, though, I see that our Dynamic Analysis tests take quite a while to complete the new benchmark step.
Would it be possible to exclude the benchmark step from Dynamic Analysis builds, e.g. by setting a preprocessor flag when MATERIALX_DYNAMIC_ANALYSIS is enabled in a build, and checking for this before running this specific test?
https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/CMakeLists.txt#L56C8-L56C34

Thanks for that update, @ashwinbhat, though I'm not sure this is having the desired effect!
Looking at the builds in GitHub Actions, most are taking 25-30 minutes, but the two most recent builds from PR 1566 are taking more than 40 minutes, with the Dynamic Analysis build taking an unusually long time to complete (31 minutes, as compared to 8 minutes for other builds).
One recommendation on the approach to controlling which tests run in Dynamic Analysis builds:
What if we were to set a preprocessor flag named MATERIALX_DYNAMIC_ANALYSIS when the user has selected the option of the same name through CMake, and then simply wrap benchmark tests with a check for this preprocessor flag?  That would make it more straightforward to change this behavior in the future, extending it to new tests or removing it from other tests, without needing to synchronize test names in CMake.
Here's an example of this pattern for setting preprocessor flags matching user options in the root CMake file:
https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/CMakeLists.txt#L168

Hi @jstone-lucasfilm I think I've updated it to follow you suggestion where PerformanceTest: ShaderGen and Validation is run only with MATERIALX_DYNAMIC_ANALYSIS = ON. I see that the last DYNAMIC_ANALYSIS build took 51m 19s. Should we turn it off completely if it's going to hurt PR time and developer productivity

@ashwinbhat Oh, I may have miscommunicated my thinking here, and it's only when MATERIALX_DYNAMIC_ANALYSIS is off that we want to run these new benchmarking tests.
In a dynamic analysis build, the compiler inserts additional error-checking instructions into the generated code, allowing us to enforce that conditions such as memory boundary overwrites never occur in our unit tests.
But because these error-checking instructions dramatically slow down runtime performance, we want to omit our new benchmark tests when this mode has been enabled in the compiler, and we can check for this condition using the MATERIALX_DYNAMIC_ANALYSIS preprocessor flag that you've added.


Brace matching does not ignore comments

Running Atom 1.0.19 on Windows, I do atom --safe C:\Temp\foo.js to open this non-existing file.  I then enter the following content:
function foo() {
    // }
}

Positioning the cursor on the only opening brace tells me that it incorrectly matches the closing brace in the comment.  And indeed, hitting Ctrl-M to jump to the matching brace confirms this.
Shouldn't braces in comments be skipped for the purposes of brace matching?

This looks like a duplicate of https://github.com/atom/bracket-matcher/issues/78 - please subscribe there for updates.


Reduce mermaid's CSS directives collision potential.

Add .mermaid prefix to most CSS paths.
Fixes #7

Perhaps a very bad PR.
How about this instead ?
/** Section styling */
svg .section {
  stroke: none;
  opacity: 0.2;
}
svg .section0 {
  fill: rgba(102, 102, 255, 0.49);
}
svg .section2 {
  fill: #fff400;
}
svg .section1,
svg .section3 {
  fill: white;
  opacity: 0.2;
}
svg .sectionTitle0 {
  fill: #333;
}
svg .sectionTitle1 {
  fill: #333;
}
svg .sectionTitle2 {
  fill: #333;
}
svg .sectionTitle3 {
  fill: #333;
}
svg .sectionTitle {
  text-anchor: start;
  font-size: 11px;
  text-height: 14px;
}

Hi @Goutte,
The first solution you came with to prefix all CSS selectors is the most relevant, since it ensures that the style applies only to DOM nodes from that library. Without style preprocessor, prefixing everything is the only way to do it, so we are going for that.
Thanks for the PR 👍


Fancyzones forgets layout after disconnecting/reconnecting dock

Microsoft PowerToys version
0.58.0
Running as admin

[ ] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
Set up external monitors with fancyzones via USBC dock.
Disconnect the dock.
<Unknown if full laptop hibernation/restart is required to trigger bug>
Reconnect the dock.
External monitors are back in default fancyzone layout.
✔ Expected Behavior
Monitors remember their assigned layout.
❌ Actual Behavior
Monitors forgot their assigned layout.
Other Software
No response

/dup of https://github.com/microsoft/PowerToys/issues/16370


Ability to manually initiate touch id / face id authentication

Reasoning described in #60

Hi, @igorkulman
Thanks for your PR.


Multiple masters and stale Pgpool data

I made some basic changes to your solution to suit our deployment “provisioner” needs. Instead of having 3 StatefulSets (for a 3 node setup), I created just one StatefulSet (with Adaptive Mode) with 3 replicas and changed the docker entry point to populate NODE_ID, NODE_NAME and other instance specific things for each replica. Pgpool sits in the front of this setup.
Now I don’t know if its because of some misconfiguration at my end, but this is what I see:

At times when the failed master comes up, it is not able to auto-detect the new master and assumes the role of master. Thus causing 2 masters in the setup.

When one instance goes down and does not come up beyond x seconds, Pgpool marks it as “down” but does not mark it as “up” when it finally comes up and is responsive

At times Pgpool does not show the correct master.

Any help will be greatly appreciated
Thanks,
Sudeep

Can you share your solution at least (I really afraid that having only single statefulset is not possible right now)

That sounds like we need logs to see
Yeah that refers us to the issue when you might want to have hard pgpool - pgsql intergration. So postgres will notify all pgpool instances about events (up/down) Pgpool actually automatically detect master anyways.
As alternative I can offer you to use HealthCheck for Pgpool /usr/local/bin/pgpool/has_enough_backends.sh [REQUIRED_NUM_OF_BACKENDS, default=$REQUIRE_MIN_BACKENDS] That will restart Pgpool and will try to attach all nodes again on the start.
Not sure what you mean by that. But should be a reason for it...

Thanks for your reply. I have considered your points and redesigning my solution. Will keep you posted.

@paunin
The second point you mentioned as a solution is quite good. But in case the one of the nodes do not come up, then doesnt this cause the restart of pgpool repeatedly?. And also doesnt the restart of pgpool actually drop the current connections as well?. Can you please share your output on this.

it does drop connections but according to the idea of liveness probe - your system is not sustainable to keep current connections....so better to drop them (on application level it would create an exception and uncommitted transaction - you app design should take into account unstable DB connection... right?)
pgpool would restart repeatedly... because it has no enough nodes to work with.
If you want to keep pgpool even when  some backends are down - don't set the probe... set some monitoring ;)
anyways check the section https://github.com/paunin/PostDock#health-checks
you will have some clue how to avoid split brain (2 masters in one cluster)


Update daemonset.yaml

Added a configmap and attached it to Nginx ingress to controll some default parameters.
HSTS add security, but having it installed by default is worst then the problems it is called to resolve:
it's an advanced parameters and people should set it only if they know how it works to prevent problems.
hsts-include-subdomains: "false"
hsts-max-age: "0"
hsts: "false"
Hide some some server information, like the name and version, it's useful to reduce attack exposition of the services.
proxy-hide-headers: "Server"
server-tokens: "False"
reference to parameters
https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/
https://github.com/nginxinc/kubernetes-ingress/tree/master/examples/customization
High level description of the change.

Specific change
Specific change

Testing
Describe your work to validate the change works.
rel: issue number (if applicable)

Most of these values aren't any different from the defaults (except server-tokens), you've only applied it for DigitalOcean, and this isn't following the one-manifest-per-file convention like all other addons. Overall, this doesn't seem very compelling and folks can add whatever Nginx customizations are desired on their own, addon minutiae aren't a Typhoon concern.

Wait, you're the same person having difficulties using the ingress controller on DigitalOcean in https://github.com/poseidon/typhoon/issues/294.


chromium: 53 -> 54

Motivation for this change
Update
Things done
Used update.sh

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Hrmmm not so simple this time :(
patching file chrome/common/chrome_paths.cc
Hunk #1 succeeded at 69 (offset 1 line).
Hunk #2 succeeded at 266 (offset 1 line).
Hunk #3 succeeded at 274 (offset 1 line).
Hunk #4 succeeded at 317 (offset 1 line).
Hunk #5 succeeded at 352 (offset 1 line).
sed: can't read chrome/chrome_tests.gypi: No such file or directory
builder for ‘/nix/store/ky882cjxnrnvdqggfs2c2px0342ansb1-chromium-55.0.2883.11.drv’ failed with exit code 2

Oh, I only built stable...

OK, I need help with this... :D
I don't even see your error when I build chromiumDev. It complains a lot about PepperFlash and I have spent a good amount of time on this and got nowhere...
I get these
/opt/google/chrome-unstable/PepperFlash: Not found in archive
chmod: cannot access 'PepperFlash/libpepflashplayer.so': No such file or directory
unable to read file PepperFlash/manifest.json: No such file or directory
Seemed to me that PepperFlash has been removed but I am not sure how I would go about fixing that. I don't think I understand the nix expressions for Chromium...

Continuing from https://github.com/NixOS/nixpkgs/issues/19678, shall we use this PR as a ticket for the chromium transition?
I took @aszlig 's work on porting to GN and tried to get it built: https://github.com/bendlas/nixpkgs/tree/chromium-gn
It compiles, but there is an rpath issue with linking, that I think I've identified as: https://github.com/NixOS/nixpkgs/issues/19680
If nobody beats me to it, I'll try to create a temporary gcc wrapper for chromium to deal with this until the issue is resolved.
I added a commit to deactivate PepperFlash, but for a complete port we'll probably need distribute NPAPI flash: https://blogs.adobe.com/flashplayer/2016/08/beta-news-flash-player-npapi-for-linux.html

@bendlas: Chromium has dropped support for the NPAPI a long time ago, so how do you exactly want to port it? Reviving the old (unsandboxed) NPAPI code?

@aszlig I probably misremembered. Probably because chromium dropped the PPAPI flash from the default plugin package at the same time where Adobe announced plans to keep NPAPI flash updated in the future. Shall we continue to support PPAPI flash, by downloading it directly from Adobe? What's upstream doing?

@bendlas: Ah, didn't get that in the first place... So the Chrome binary package doesn't include Pepperflash anymore, right? So yes, I'd get the (PPAPI) plugin directly from Adobe then and drop the plugin from the Chromium plugins package (leaving it to only include widevine).

(bug roundup highlighted this issue again, https://github.com/NixOS/nixpkgs/issues/19884) What's the status on updating the stable chromium?

@grahamc almost there, I could get a successful link with the @rspfile fix in nix-shell --pure, for some reason nix-build still doesn't set the rpath correctly. I'm investigating, but chromium builds are painfully slow

Link issue should be fixed, just running another build.
The issue with pepperflash seems, that google now wants to keep flashplayer updated via chrome://components https://forums.adobe.com/thread/2221587
If this works for NixOS as well, it would be net gain, otherwise, we need to devise a scheme to find out the most recent version of flash, in our update.sh. Adobe's download page doesn't seem very helpful about it.

@bendlas: I think it's better to completely decouple pepperflash from Chromium, like it has been back then with the NPAPI flash plugin, especially because Flash versions are no longer tied to Chromium versions (okay, to be more exact: I assume they aren't).

@aszlig if the auto-update via Component Updater works, wouldn't it be better to take advantage of this, to get faster security updates? I grepped GN flags for flash, but didn't find anything to control Component Updater. Let's see, what it does in a finished build, still waiting for that. Got to run in 15 minutes, unfortunately ...

I rebased and squashed everything in https://github.com/NixOS/nixpkgs/compare/master...bendlas:chromium-54
if somebody wants to take care of pepperflash right now, you can do so on top of that branch, otherwise I recommend pushing this w/o pepperflash, for now.

Where are we at with this?
@bendlas can you send your progress as a PR? We should have a working up-to-date Chromium then, correct?


Update makeFile for JDK22 version

/runtimes/backlog/issues/1318

Update makeFile for JDK22 version

CC: @llxia

moved to internal repo so no longer valid.
Closing it.


[Develop]: Can not find reference datahub.metadata in idea IDE

I follow the steps described in the url https://datahubproject.io/docs/developers.
When I open datahub.ipr  in idea IDE, datahub.metadata reference can not be found.

Thank you for your friendly help.

These are generated classes.
Did you run this ./scripts/codegen.sh?
https://github.com/datahub-project/datahub/blob/master/metadata-ingestion/developing.md#sanity-check-code-before-committing

Hi @ddsr-ops
Is this still an issue? If not, will close it after a few days of inactivity


task: use eslint as jsformatter and slim rules

Eslint formatting is dropped
https://eslint.org/blog/2023/10/deprecating-formatting-rules/


Remove prefix or move all capnp to c++

Currently we are using a custom version of c-capnproto to hack a "cereal_" prefix on to the C api. https://github.com/commaai/c-capnproto/commit/2e625acacf58a5f5c8828d8453d1f8dacc700a96
It's one more dependency that has to be custom. Can we remove it and use the standard?

I think it's better to move to C++.c-capnproto  is old and not well maintained.

I support moving everything to C++


Add license to repo

I'd love to use the code, but want to make sure I can based on the license. Could you all add a license please? :D
Thanks.

We added the MIT license to the project. Thanks for your request and sorry for the delay.


Custom autocomplete for multiple required arguments

I have a command that has multiple required arguments, and I want to make custom autocomplete that is different between the arguments.
As far as I can tell there is no way to do this right now. Am I wrong?

Found this issue because I was wondering the same thing, so from the lack of feedback I guess that this is indeed not possible... A partial hack could be using an argument and one or more options (depending on how many arguments you need), but in my case that doesn't work either, because the autocomplete for one of the arguments depends on the value set in the other, and apparently there is no way to get the current input so that I can make an informed decision. Pity, as I really like vorpal so far!

@giodamelio not sure if you still need this, but I got it to work eventually, with the help of events. All you need to do is intercept the keypress event, and use that to update some global variable where you can keep track of what the user typed in so far:
	cli.on('keypress', function(event) {
		currentInput = event.value;
	});

The in your autocomplete string just process that variable to do different autompletes depending on the position of the argument in the text. I used a regular expression to make sure I only had one space in between arguments, and a split to figure out how many arguments were already typed down. Hope this helps!

Ah, that is a clever way to do this. A bit of a hack, but it works 😀 .
Thanks for the tip.


Fix max/min calculation for getBoundsZoom (fixes #5136)

When inside is true, the code shall use Math.max instead of Math.min when comparing the horizontal and vertical scale factors between the bbox and the map viewport size.

@perliedman Added one test for the inside parameter. Should be enough.


Added new support lifecycle article

PR Summary
Added new support lifecycle article
PR Checklist

[x] Descriptive Title: This PR's title is a synopsis of the changes it proposes.
[x] Summary: This PR's summary describes the scope and intent of the change.
[x] Contributor's Guide: I have read the contributors guide.
[x] Style: This PR adheres to the style guide.

Should we consider adding in the text information regarding the type of updates that the LTS version will receive?

I've added this information in the bulleted list under LTS and STS.


Tilt effect on mouse hover

I have been experimenting with a subtle tilt effect inspired by how Apple TV cards move when you hover over them.

Here's a quick prototype I threw together:
https://painted-sleep.glitch.me/
The camera tilts slightly based on where your mouse is hovered over the element. While it's a subtle effect, it helps reinforce how the model is 3D and not just an image. Adds an extra hint for discoverability.
Something to consider adding for that extra oomph!

That's awesome 😍 I love this idea as a subtle but intuitive improvement / alternative for our default interaction prompt.
I wonder if there is an additional version of this where the model tilts in line with the scroll value.. maybe that's a separate issue though :)
cc @elalish

@cdata Took the words right out of my mouth! The tilt on scroll is something we've been playing around with too, and there is a great example of that type of interaction in the wild: https://panic.com/transmit/
I filed an issue for it here: #600


Add "Photo Discovery" Feature

This would be anything that 'curates' photos for the user.

Implemented in v1.4.0


docs: fix typos

Also, I recommend keeping these examples in English:
https://github.com/lf-edge/ekuiper/blob/179b3707543cd3256d0c86a0774a069e4d8677a1/docs/zh_CN/CONTRIBUTING.md?plain=1#L220-L232

Also, I recommend keeping these examples in English:
https://github.com/lf-edge/ekuiper/blob/179b3707543cd3256d0c86a0774a069e4d8677a1/docs/zh_CN/CONTRIBUTING.md?plain=1#L220-L232

agree


[Discuss if worth doing] Splashscreen before main menu

With the understanding that contents can be displayed before showing the main menu by modifying the main menu element inside index.html, I wonder if we could have a more user-friendly way of implementation in future development.
For example, a specific label that, if defined, shows its content (image, text, media files etc.) before main menu (like the splashscreen label in Ren'Py)

Hi there! I would like to implement this but I was wondering, would the splash screen be shown before, after or at the same time as the loading screen?

Hi there, thanks for considering this for the next release!
I suppose contents in the splash screen should be shown after the loading screen, in case people make rather heavy use of assets in the splash screen..? (a short prologue featuring some character sprites and BGs, or an opening video shown before the main menu is quite common)

Hi @RuolinZheng08 just wanted to let you know that support for showing a splash screen using a special label on your script has landed on what will become the v2 release :) Since it is a label, on the splash screen you can do anything you'd be able to do in your game!


bug: can't implement approved suggestions

No problems approving or implementing normal suggestions however when -sa implement is used on an approved task I get "Error: Not a valid Suggestion Message"

I get the same issue @Satty9361. I have tried all manor of passing an ID to the bot. This happens with or without a comment.

Hey, sorry to necro this.
Can you tell me what message ID you provided as suggestion message?

Hey, sorry to necro this.
Can you tell me what message ID you provided as suggestion message?

@jo3-l what do you think about closing this due to inactivity?

Is this bug reproducible on your end @l-zeuch?

Couldn't reproduce with several configurations... What about your end?

Neither could I. Let's close this then. Feel free to open a new issue if it pops up with more information @ironbelly : )


Inference generating weird output

I am running the inference script but getting somewhat unprocessed images like the one below. Only the first image in Generated_Frames is decent the rest all are pixelated. There are no errors thrown so I don't know exactly what is going wrong. Any help would be appreciated!

Hello! Could you give me some details related to your set up. Are you training your own model from scratch, or using a pretrained one?
If using the pretrained, note that it performs very poorly on videos outside the crema-d dataset. You would need to either finetune the model on top of your data, or train a new one from scratch. Depending on your needs for generalisation and your dataset size, this can take anywhere from a few days, to weeks.

Hey Dan, thanks for the quick response and for sharing such an amazing model. I am using the pre-trained multispeaker checkpoint. If you can clarify some general questions regarding the model it would be great

Why does the multispeaker checkpoint/model performs poorly outside the crema-d dataset? is it because of overfitting or how the data is handled within the code (like different audio sample rate, image encoding etc..)
Why are there two different checkpoints (multilspeaker and single speaker), can't the multispeaker be fine-tuned with the single speaker data?
Is there any part of the code which I can focus on to debug this issue? I feel like this is a bug related to the code implementation (will also raise a PR for the fix if I find the cause)

No worries, sure!
1: I believe its overfitting. Because CREMA-D isn't a diverse dataset (by diverse I mean different backgrounds, not that many speakers in the grand scheme of things, all the videos being relatively the same in terms of style), the model performs poorly on more natural "in-the-wild" videos. To fix this, training on a bigger dataset like vox celeb is what I would recommend, but that will take quite a lot of resources and time which is why I couldn't do it.

You are correct, the multi-speaker model can indeed be finetuned on a single speaker. We include the two checkpoints simply because our first experiments consisted of getting the single speaker model to work. So we decided to include it here as well.

Hmmm I'm not sure, when we were doing the experiments, we encountered a similar problem as you did, where the output would degrade significantly after a few timesteps. Even when testing on videos from the same dataset. Our problem however was the opposite, the model was underfitting on the dataset, this was because there was a bug with our attention layers where they were never being called during training. Once we fixed that and ensured attention was correctly implemented, the model began converging. In your case though, I suspect the main issue is that its overfit on crema-D.

Thanks! I will look into this and train the model on my own dataset to see if it solves the issue.

@voku682 I encountered the same problem. Did the problem solved after train the model on you own dataset.


Can't resolve 'crypto' in '/path/to/site/node_modules/@dice-roller/rpg-dice-roller/lib/esm'

Using your dice roller on a Gatsby project and it's awesome!
However when I try building the static html files I get this error pointing to rpg-dice-roller and "crypo"
Generating JavaScript bundles failed

Can't resolve 'crypto' in '</path/to/my/site>/node_modules/@dice-roller/rpg-dice-roller/lib/esm'

If you're trying to use a package make sure that 'crypto' is installed. If you're trying to use a local file make sure that the path is
correct.

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

I'm using the default engine and haven't selected anything called "crypto" so I'm unsure of the best way to resolve this as I don't want to break anything.

installing crypto-browserify and adding
exports.onCreateWebpackConfig = ({ actions }) => {
  actions.setWebpackConfig({
    resolve: {
      fallback: {
        crypto: require.resolve('crypto-browserify'),
      },
    },
  });
};

in my gatsby-node.js file, fixed this error message.
Found here: https://stackoverflow.com/questions/68884421/webpack-breaking-changes-for-builtin-modules-on-gatsby-site


Compiler options have different effects on command line vs in fourslash test

TypeScript Version:  Version 3.0.0-dev.20180616
Code
/// <reference path="fourslash.ts" />

// @target: esnext

////Symbol.iterator;

verify.noErrors();

This fourslash test fails. But putting Symbol.iterator; in a file and running tsc a.ts --target esnext compiles with no error. // @lib: esnext doesn't work either, even though tsc a.ts --lib esnext works.

@rbuckton This works for other options, it probably has something to do with #23893.
This isn't actually about compiler flags, the following compiles fine with no compile flags but fails as a fourslash test:
/// <reference lib="es2015" />
Symbol.iterator;


Replace JSONKit

Now that we are supporting 10.7 as the minimum we can implement NSJSONSerialization.
JSONKit is abandoned and will not compile with Xcode 7 out of the box which is another reason to move away from it.

[ ] Write tests for existing code in Xcode 6.4 on OS X 10.10
[ ] Convert JSONKit calls to NSJSONSerialization and confirm tests are still passed
[ ] Test compilation in Xcode 7

There is a single jsonDecoder object in current code (in the GoogleReader class), so I am not sure it is worth creating a wrapper class.

The crash caused by commit d01260b is due to a memory management problem. Will fix it.


replace keyword from with to if

Refs https://github.com/tc39/proposal-import-attributes/issues/3
It's based on #70, please merge it first.

I will also update the syntax section of the README with an explanation before we merge this.


Add setcount to the uhhh thing... readme :)

exactly what the title says

when using the command it sends this.

Ah, i forgot to remove the debug output from the setcount code hehe @kass507

I pushed a fix for it now

Worthy of note: This issue is resolved by #49

resolved by #49


Missing release tag for 0.3.0

You bumped version to 0.3.0 in b832cf7edd72585575e1278d506cd49ec5ba2ed8, but there’s no release tag and the last one is two years old.

Sorry, I must have failed to push the tag. It's there now.


Update Container Wait

Summary
The goal for this PR is to be able to use the POST /containers/{name}/wait API in order to no longer rely on the Events API when doing docker run ... and docker start in attached mode. Here is the set of behavioral changes in the API and CLI:

The wait API now has on optional query parameter, condition, which specifies the state of the container which the client would like to wait for:

not-running
This is the default value which maintains the existing behavior of the Wait API. It blocks if the container is in a state which is considered to be running, i.e., any of running, paused, or restarting. If it is already not in any of those states, then it would not block at all and return immediately with the current exit code.

next-exit
This condition allows the client to wait for the container's state to change to a not-running state or to be removed. This is different from the not-running option because it will block if the container is in the created, exited, dead, or removing state, blocking through a transition to one of the running states and back to one of exited states or until the container is removed, whichever comes first. It is similar to waiting for a die or destroy event. This option is very useful to use before issuing a container start API request.

removed
This condition allows the client to wait for the container to be removed. It is similar to waiting for a destroy event.

The Wait API will now return HTTP response headers immediately. This serves an an acknowledgement that a wait has been registered. The JSON response body will not be returned until the wait condition is met.

The Wait API's request context is extended to wait for a http.CloseNotifier event in the case that the client closes the connection while the server is blocked on the wait condition. This prevents leaked goroutines but should only be necessary until we switch to using Go 1.8's request context which cancels automatically if the client disconnects.

To handle a manual detach (when the user enters the detach keys sequence when attached in TTY mode), the CLI now detects this key sequence, stops sending stdin, and causes the CLI to exit immediately. This is done as an alternative to waiting for a detach event.

Follow-up to #31794
Fixes #32242

@WeiZhang555 @cpuguy83 any concerns for the approach?

The design looks good, I like it :-)
https://github.com/docker/docker/pull/31744 seems need to reimplement based on this, it could be simplified a lot with this PR.

@WeiZhang555 Indeed, however we still need to support old daemons.

@cpuguy83 Yep, you're right, then we have to keep both waitExitOrRemoved and this, backward compatibility makes this so complicated :cry:

Well, at least janky seems happy with this first commit. I'll have to look into the failures with windowsRS1 and z tests later. I'll push the second commit now.

I've removed the [WIP] label from this PR and make the necessary changes to the API client and docs. Please take a look. I've also the waitExitOrRemoved() function in a way that maintains compatibility with older versions.
While all of the integration tests pass locally for me, I have seen some flakiness in a few tests that Jenkins runs. They mostly get this error:
Cannot kill container {ContainerID}: Container {ContinerID} is not running

But I can't tell if it's related to my changes or not since I tried not to modify container state/lifecycle in any way.

I've hit an issue on something that I forgot to consider: docker run -it ... where the user enters the DetachKeys. In this case, the ContainerAttach API call returns but we still block on waiting for the container to exit, which it never will. This is why the DockerSuite.TestAttachAfterDetach integration test is failing everywhere.
The current implementation of waitExitOrRemoved() handles this by waiting for a detach event to unblock and return a 0 exit code. That is also not perfect because you have no way of knowing which CLI session the detach came from. I also want to completely avoid using the events API. I could overload the wait API with another option to wait for a detach, but you still don't know which attach request it was associated with.
One solution that I can think of would be to do an inspect of the container after the attach returns. If the container is still running then we can assume that the attach connection ended because the user entered the detach control keys. If the container has exited or is not found then we can assume that the attach connection ended because the container exited and/or was removed. The only problem with this is that there is a very small race window after the container exits between when the container's IO streams are closed (which causes the attach request to end) and the container's state is set to stopped/restarting. If the inspect request comes in after the attach connection closes but somehow before the container's state is marked as stopped then it would be interpreted as a manual detach since it would look like the container is still running.
Another clever solution to detecting the detach control keys is to actually do that detection client-side, passing the stream through the logic that tries to detect the detach control keys in the same way that the daemon-side does. Then we'll know for sure that the client initiated the detach.

Windows tests look good. There's just a race condition in one of the DockerSuite integration tests. I've opened an issue for it. #32306

The powerpc also looks good except for the same flaky test. It also failed on another flaky test: TestSwarmIngressNetwork.

The z tests had the same single flaky test failure as on Windows: TestRmRestartingContainer.

I've decided to carry a fix for TestRmRestartingContainer on top of this PR to try to get all of the tests to pass. I've also got another PR open with just that commit: https://github.com/docker/docker/pull/32307

Aw Yiss. ✅✅✅✅✅✅

I've edited the initial PR comment above to summarize all of the changes.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "update_container_wait" git@github.com:jlhawn/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354185800
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

I've rebased after a conflict with docs/api/version-history.md.

Since this didn't make the cut for 17.05 and API 1.29 I've had to add on an extra commit which bumps the version checks I added to use 1.30 instead and update docs/api/version-history.md.

Design LGTM
ping @WeiZhang555 for review. Tentatively moving to code-review

@cpuguy83 I've rebased and adde 3 commits to address your comments, please take a look.

@tonistiigi @WeiZhang555 I've also added a commit which removes the changes to the CLI, so there's no longer a --condition flag and it just keeps the old behavior (i.e., --condition=not-running). I also removed the integration tests which covered those CLI options.

I used to be able to change labels on the docker/docker repo but now I can't. Can someone trigger a rebuild on powerpc, please?

@cpuguy83 I've added a commit which adds WaitCondition constants to the api/types/container package. Please take a look.

These build failures seem to be either Jenkins issues or flaky tests, can someone please trigger rebuilds for experimental, janky, and windowsRS1? 🙏

Rebased after conflicts with docs/api/version-history.md.

I've updated this PR again:

Rebased to resolve yet another conflict with docs/api/version-history.md
Added a new commit to address review comments from @tonistiigi

15:49:24 The swagger spec at "api/swagger.yaml" is valid against swagger specification 2.0
15:49:26 The result of hack/generate-swagger-api.sh differs
15:49:26
15:49:26  M api/types/container/container_wait.go
15:49:26
15:49:26 Please update api/swagger.yaml with any api changes, then
15:49:26 run `hack/generate-swagger-api.sh`.

Ping @dnephin Do you know how we can add these new API objects to swagger so swagger-gen doesn't complain? Should we just move to a different file?

ContainerWait is a generated struct (it's in hack/generate-swagger-api.sh), so you should never edit api/types/container/container_wait.go directly. Edit swagger to match what you want and generate it using  hack/generate-swagger-api.sh.
Is that what you mean?

I mean it makes sense, but he's added some enums which need to be defined somewhere, and preferably in one place, but not sure if there is any facility for that in the swagger spec/generator.

Edit swagger to match what you want ...

How would I do that? Edit the api/swagger.yaml file?

Yes, sorry I noticed afterward it was just an enum. Putting them into a different file should work.

So, all of the cli/command files have disappeared. Do I have to open another PR now, against https://github.com/docker/cli ? I'm guessing that the api client package may soon disappear, too?

I'm going to preserve my cli/command changes in this diff file and deal with that later. I've rebased and this PR is now strictly an api and backend change.
moby_cli.diff.txt

Tests were green, but I had to rebase to resolve still yet another conflict with docs/api/version-history.md.

💢💢💢💢💢💢💢💢💢💢💢💢
I'll keep rebasing to resolve the conflict, but I want to point out for posterity:

The code implementation looks good to me.
I have only one doubt about the next-exit, as I can see there's no function using the next-exit feature currently, then should we keep it in the codes ? Though it costs only little redundant codes. :cat2:

there's no function using the next-exit feature currently

There was, until the cli package was moved to https://github.com/docker/cli. See this diff for the CLI changes for which I'll have to open another PR against that repository.

@jlhawn I see, LGTM :smile:

ping @tonistiigi @dnephin PTAL!

LGTM

I'm currently rebasing and addressing @dnephin's comments. I want to expand on one of them since it has been asked already multiple times:

Why does [the ContainerWait client method] return a container.ContainerWaitOKBody channel instead of just blocking?

This is done because it seemed like to quickest way to meet the new requirements we need for the Container Wait API which is to enable this flow:

Create a container in the case of docker run ... or have the container already exist in an exited state in the case of docker start -a ....
Begin waiting for the container's next exit code (i.e., after it starts) or for it to be removed (in the case of docker run --rm ....
Get acknowledgement from the daemon that it has begun waiting for that condition.
Start the container.
Continue to block on that wait condition.
Some time later, the container exits.
Receive the exit code.

Point 2 is the reason why there is a next-exit wait condition.
Point 3 is the reason why the API handler now returns response headers immediately.
Being able to sync point 4 is the reason why the Client method returns a channel for the wait result - to be able to propagate the ack from point 3 and start the container without a race condition: If we didn't have a way of ensuring the order of 3 and 4 then it would be possible that the container is started and exits before the wait actually begins on the backend in which case 5 would block indefinitely.

I'm willing to change it to whatever we can all agree on. An alternative I have thought of is to go back to returning (exitCode int, err error) but to get the acknowledgement I mentioned we would need to have another argument to the method which is a channel which is maybe closed when the headers come back. That seems like an even more confusing interface to me though. Please make other suggestions if you have any ideas.

I have no idea why the windowsRS1 build has failed:
can't load package: package github.com/docker/cli/cmd/docker: cannot find package "github.com/docker/cli/cmd/docker" in any of:
 	C:\go\src\github.com\docker\cli\cmd\docker (from $GOROOT)
 	C:\Users\ContainerAdministrator\AppData\Local\Temp\e5237f98-d5ea-4be8-bfb3-c68f9d2c2d38\src\github.com\docker\cli\cmd\docker (from $GOPATH)

Rebased and squashed, it's now just 2 commits.

Thanks!

All 💚

The CLI changes are now in a PR against the docker/cli repo here: https://github.com/docker/cli/pull/101


feat: Update icons for accessibility

Update the icons to support better accessibility.
Fixes: #47

:tada: This PR is included in version 2.7.0 :tada:
The release is available on:

Chrome Web Store
GitHub release

Your semantic-release bot :package::rocket:


Can't Find Elements in ChildContent

Finding elements in ChildComponents
When trying to find elements in AddChildContent the system will error (first test example). You have to instead look directly in the cut (second test example)
Say you had a parent element (HeadlessDisclosure) that is a div and cascades itself to a child (HeadlessDisclosureButton) which is a button. I want to grab the button element with the Find(cssSelector).
The expected razor
<HeadlessDisclosure>
    <HeadlessDisclosureButton />
</HeadlessDisclosure>

would result in

    <button />

Here is the first test (that fails). The Node of the disclosure has 1 element (the div), but not direct children. Instead, if you look in the Node's content, you will see the button.
var disclosure = RenderComponent<HeadlessDisclosure>(parameters => parameters
    .AddChildContent<HeadlessDisclosureButton>()
);

var button = disclosure.Find("button"); // Bunit.ElementNotFoundException : No elements were found that matches the selector 'button'
// do stuff with button

Test that works:
var disclosure = RenderComponent<HeadlessDisclosure>();
var cut = RenderComponent<HeadlessDisclosureButton>(parameters => parameters
    .AddCascadingValue(disclosure.Instance)
);

var button = cut.Find("button");
// do stuff with button

Expected behavior:
I want the top test to be able to find elements
Version info:

bUnit version: <PackageReference Include="bunit.web" Version="1.2.49" />
.NET Runtime and Blazor version: <TargetFramework>net6.0</TargetFramework>
OS type and version: Windows

Additional Info
Here is a screen grab of the markup of disclosure. So I know it is getting the correct markup.

@thalaeg I think the problem is that you are using the <template> element. Content inside a template element is not added to the document object model (more about the tag here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/template), and can thus not be found using Find or FindAll, both of which are shorthands for QuerySelector and QuerySelectorAll respectively, so that is why `Find("button") doesn't return an element.
That's not just a bUnit thing, it's also how it works in the browser, so you may be using the <template> element incorrectly in this case.

Hi @egil. I was having some problems with .NET 6 rc1 so I had to upgrade to rc2 this morning to fix that issue. Sorry for the delay.
Yes, I mistyped in my initial issue.
I was expecting
<template>
    <button />
</template>

The problem does relate to template. I just created this basic repo to replicate the issue if you want to check it out further. https://github.com/thalaeg/Bunit_Issue512
I may be using it incorrectly! Most of the time, the component (my HeadlessDisclosure) will likely be casted to a div rather than a template, but I was trying to make it generic.
Unfortunently, it would not be easy to share the HeadlessDisclosure code quite yet, working on moving it to a public Github project. It is being developed by my company and we are iterating on it pretty quick and don't want a bunch of breaking changes at first. However, that small project above replicates it well.
I believe you are correct that it is not a bunit thing. So feel free to close the issue! Perhaps a note in the documentation about templates might be warrented? Unsure on that bit. Thanks for creating such a cool testing project.


nuget.config Environmental variable usage is contradictory

In the docs, we have the textual documentation:

Note that you have to use Windows-style environment variables (starts and ends with %) even on Mac/Linux. Having $HOME/NuGetRepository in a configuration file will not resolve. On Mac/Linux the value of %HOME%\NuGetRepository will resolve to /home/myStuff/NuGetRepository.

But in the actual example code:
        <!--
            ...
            In this example, %PACKAGEHOME% is an environment variable. On Mac/Linux,
            use $PACKAGE_HOME/External as the value.
        -->
        <add key="repositoryPath" value="%PACKAGEHOME%\External" />

So the docs say use Windows-style variables (which is what actually works according to others), but the example says the opposite. Am I reading this wrong, or should we adjust the example comment?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0ea1390e-db36-6759-3095-ebab9d546fdb
Version Independent ID: ca88d8c6-0515-a267-aac3-a508c54157ab
Content: nuget.config File Reference
Content Source: docs/reference/nuget-config-file.md
Product: nuget
GitHub Login: @karann-msft
Microsoft Alias: karann

Dupe of https://github.com/NuGet/docs.microsoft.com-nuget/issues/1959


Add Copy Evidence button

This PR adds a button overlay on some evidence that enables the ability to copy the core content of that evidence (the image for screenshots, the source code for codeblocks). This ability theoretically should work cross browser and cross OS, but is limited in a number of ways. Text copying should always work, while image copying will work depending on both the storage type of the image and the browser being used, as well as how that browser is configured. Below is a short guide on what to expect:
Using Chrome
Text will copy and png images should copy. All of types of image files will not copy. You may get a modal indicating the failure to copy
Using Firefox
Text will copy. PNGs may copy if the correct flag is turned on. Other file types will not copy. You may get a modal indicating the failure to copy
To enable the correct firefox flag:

Open a new tab, and navigate to about:config
Look for the dom.events.asyncClipboard.clipboardItem. Set this value to true. Note that you'll also need dom.events.asyncClipboard also set to true, but this is enabled by default
Note that this enables this flag universally

Using Safari
Still testing, but it might work for everything.
Please note that in all cases, you should be able to right click and choose "save image" which should work regardless of the image type/OS
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Based on limitations and the fact that you can just right click and copy the image contents, which was the main use case, maybe we just hold off on this for now. I think there is still maybe value in the feature, especially for other evidence types (eg. storing a har or asciinema file on the clipboard as a data uri to bring into something else) but that seems like it's not worth tackling now.
In terms of feedback, it seems to work pretty well. I think if we re-visit this I'd like to see the option folded into the dropdown where move and delete currently are and have it disabled if it's not possible to copy that specific evidence type.
It also may make sense to start storing the mime type of the evidence for use in determining whether the evidence could be copied or not. We may also want that in the future with the enrichment pipeline.


if metadata reconciliation for any destination fails, we should continue on other destinations intead of failing the whole process

Reviewers: gbailey
Reviewed By: gbailey
Subscribers: nx, aravindv

Coverage decreased (-0.005%) to 54.653% when pulling 134962af267c3d2c285b32c18a8e1b16ab50be67 on replicator_hotfix into 5dcef224aa240e3a0ffbfc7864744639d630c8cd on master.


[camera_web] Add setFlashMode comments

Added comments to explain how setting the flash mode affects the camera torch mode constraint as suggested in https://github.com/flutter/plugins/pull/4222#discussion_r685373028.
Part of https://github.com/flutter/flutter/issues/45297.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[x] All existing and new tests are passing.

@ditman @felangel

I am manually merging this one, it's only comments.


Converting Numbers to incorrect Hex

Hi, i found out that after uglifying the javascript, the numbers are converted incorrectly. Instead of "1000" in the result i have "1e3" and it is not the correct value.

gulp-uglify is only a wrapper for uglify-js so it is not this package issue.
Moreover, 1e3 means 1000. See here

Thanks @mabar for answering this. :+1:


'?' Key to display keyboard shortcut

thus is is easier to learn.
Feature request

I agree, partly because the 'right-click' thing doesn't show all shortcuts: for example, I couldn't find 'shift-P means push' anywhere. AFAICT any of the "global" shortcuts are not shown in the right-click menus.

Duplicate of #73


Show usage mymizu statistics

Beneath the map, load the total refill amount from the community endpoint and display statistics

Pet bottle amount is defined as refill amount ml / 500
CO2 amount is defined as total pet bottles *  0.333
Litres is refill amount ml / 1000

Please check notion link for more details:
https://mymizu.notion.site/Live-community-metrics-ae5eab9dfc394c08818b65f059e02234

https://sites.google.com/mymizu.co/mymizuapi/home


test go 16 build [DO NOT MERGE]

Signed-off-by: Mike Ng<EMAIL_ADDRESS>

1.16 seems ok for this repo


Can the color picker be enhanced to have similar colors and other functions

Can the color picker be enhanced to have similar colors and other functions

Can you be more specific?
When you say similar colors: if you have the editor open, select one of the colors and then it shows that color between a lighter and darker shade of it. If you click the colored bar in the middle, you can fine-tune the color.


Opening files/tabs

Issue Type: Feature Request
I opened a file. It created a new tab. Then I clicked another file. But no new tab was created. Instead, the previously opened tab was replaced by the new one. This happens regardless of the different extensions the old file and the new file are. I need to open the file in new tabs everytime I click on them from the Explorer or I open them from the File Explorer.
VS Code version: Code 1.58.0 (2d23c42a936db1c7b3b06f918cde29561cc47cd6, 2021-07-08T06:54:55.083Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

/question
This is called Preview and controlled by settings workbench.editor.enablePreview, workbench.editor.enablePreviewFromQuickOpen, and workbench.editor.enablePreviewFromCodeNavigation.
See more about this feature in docs Preview mode
If you want to disable it - make sure 3 settings above are set to false

Thank you @Github @Andrii Dieiev ..... Also, is there any newsletter that
post useful infos on VS Code ? If there is one, please subscribe me there.
If not, could you post something useful ?
On Sun, Jul 11, 2021 at 3:16 AM Andrii Dieiev @.***>
wrote:

/question
This is called Preview and controlled by settings
workbench.editor.enablePreview,
workbench.editor.enablePreviewFromQuickOpen, and
workbench.editor.enablePreviewFromCodeNavigation.
See more about this feature in docs Preview mode
https://code.visualstudio.com/docs/getstarted/userinterface#_preview-mode
If you want to disable it - make sure 3 settings above are set to false
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/128385#issuecomment-877708530,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQIDX7B3SRXB5IANP7PYR7TTXC5S5ANCNFSM5AEKTTYA
.


CL2.hpp - error: ‘CL_DEVICE_QUEUE_ON_HOST_PROPERTIES’ was not declared in this scope

Hello all,
I have the following error when I attempt to compile my code on my CUDA 8.0 Machine. But on my CUDA 9.0 machine it works fine. Why is this the case? I have set the version flag to 200

Closing. Reopen if needed.

在代码中增加如下:
#define CL_HPP_ENABLE_EXCEPTIONS
#define CL_HPP_MINIMUM_OPENCL_VERSION 120 // Need to set to 120 on CUDA 8
#define CL_HPP_TARGET_OPENCL_VERSION 120 // Need to set to 120 on CUDA 8
#include <CL/cl2.hpp>
并且在其它地方不要重复包含cl2.hpp头文件.


Cypher processor

Hey I've got questions in regards to this. I figured we could open an issue while I finish this dev.
I'm currently just going through the tests to make a failing Cypher processor test and I wanted to know about this query:
$query = 'SELECT field1, field2';
$query .= ' FROM target';
$query .= $this->getWhereSql();
$query .= ' GROUP BY groupField';
$query .= ' ORDER BY orderField DESC';
$query .= ' LIMIT 3';

The logic seems a little off in the sense that you are grouping by groupField but ordering by another field entirely (that would be lost in the grouping process). It's important to get the logic right here as cypher doesn't have a GROUP BY clause which means that I need to construct an equivalent.
Same with the selecting of fields that would be lost in the grouping process. We should change this around to be something more realistic. Maybe just drop the GROUP BY and place that in another test?

You are right. I was just trying to create a complex query bag and wasn't really thinking about a practical scenario. I am fixing the BaseTest and Orient Test now. Should I push to develop or would you rather a pull request (don't want to screw with what you are working on now)

The other issue is that there should be a clear separation of logic between label and type.
In both gremlin and cypher you choose the type of element you want and then the label within that type.
ie: I want a vertex with label target and/or an edge with label target, or both. The query for these would be different. (whereas I feel it would be the same query in orient).
This means that the use of from() is ambiguous at best. There's no intuitive understanding of what it refers to and technically in graph DBs it doesn't have much meaning other than referring to a subset of the graph (which is what where is for). I understand that in orient they've made label/class analogous of RDBMS tables because it made the transition easier, but this is an incomplete abstraction and doesn't represent graph logic properly.
At best I could see from() being used as an optional field to specify if we're looking to get vertices or edges (as opposed to the default both)
There could be several ways of going about it. Here are a few:
// using where. This could work for IDs as well (as we discussed ID cases in one of our previous exchanges)
$builder->select()->where(Builder::ELEMENT_LABEL, 'user'); // fetches user labelled elements (both V and E)
$builder->select()->from(Builder::ELEMENT_VERTEX)->where(Builder::ELEMENT_LABEL, 'user'); // fetches user labelled vertices
$builder->select()->from(Builder::ELEMENT_EDGE)->where(Builder::ELEMENT_LABEL, 'user'); // fetches user labelled edges

//some other random idea, this doesn't really help with the user scenario:
$builder->select()->from(':user'); // fetches user labelled elements (both V and E)
$builder->select()->from('V:user'); // fetches user labelled vertices
$builder->select()->from('E:user'); // fetches user labelled edges

I like the first better as it makes more sense. (no more need for specific methods to fetch IDs, or introducing new methods for LABELs). It has the downside of either being verbose or introducing reserved keywords (_label and _id probably)
Orient processor would have to do a bit more work to make up for the missing abstractions on the server level though but it shouldn't be that hard

Ah thanks! develop is fine. I haven't committed anything yet, I can just stash it, pull the develop and apply again

Thinking about my example maybe it could be:
const Builder::E_ID
const Builder::E_LABEL
const Builder::E_V
const Builder::E_E

Or something. It keeps the code clear when writing queries and is short enough not to be too verbose.

This looks great. Orient is the odd duck and I don't mind it going through extra hoops. If you want to implement these in the Cypher processor, I can make orient match that.
For what it's worth, I like keeping from as sugar for those making the transition. Maybe:
$builder->select()->from($label, $type)->where(); // Where type would default to both vertex and edge

At the base builder level, we can introduce:
// using where. This could work for IDs as well (as we discussed ID cases in one of our previous exchanges)
$builder->select()->where(Builder::ELEMENT_LABEL, 'user'); // fetches user labelled elements (both V and E)
$builder->select()->from(Builder::ELEMENT_VERTEX)->where(Builder::ELEMENT_LABEL, 'user'); // fetches user labelled vertices
$builder->select()->from(Builder::ELEMENT_EDGE)->where(Builder::ELEMENT_LABEL, 'user'); // fetches user labelled edges

ok sounds good I'll add those changes. Once we're up and running on cypher and orientSQL we should probably make a new issue to discuss sugar aliases we want to add to Builder (for a birds eye view)

Yes. If you can workout the base builder, don't worry about the from sugar in the Builder. I will take care of that.

You know, we can drop group by entirely. I've never used it and its easy enough to filter results in a response object on the user side. If someone begs for it later, we can consider it an enhancement.

I didn't include groupBy in the recent PR for cypher. Maybe we can reintroduce this later.

I'm of the mind of: "build stuff for you and your friends, and then let others tell you how to improve it." If someone wants group by, they can open an issue. For now, we have bigger fish to fry.

Agreed.


Inherit function config from project config

I was expecting much more code but turns out that it's enough to have default values and support configs inheritance.

I think it solves https://github.com/apex/apex/issues/52.

boom!


Adding recipe for GODAS

[ ] Fill out meta.yaml
[ ]

Well I hadnt seen this before... @cisaacstern

I almost got the example to run, but I am getting this error:
ValueError: Cannot combine fragments. Expected a hypercube of shape [3] but got 6 fragments. [while running 'Create|OpenURLWithFSSpec|OpenWithXarray|Preprocess|StoreToZarr/StoreToZarr/Rechunk/MapTuple(combine_fragments)-ptransform-31']

indicating to me that this is still not properly concatenting/merging the individual datasets? @cisaacstern does this look familiar to you?

@jbusecke apologies for missing this notification.
Yes, this seems to be the same issue as https://github.com/pangeo-forge/pangeo-forge-recipes/issues/517, which I am working on a fix for in https://github.com/pangeo-forge/pangeo-forge-recipes/pull/521.

Also, the rate limit error above is presumably due to these lines in the action:

https://github.com/pangeo-forge/deploy-recipe-action/blob/bda89250ed9ee256af1d0cac3e951c772ce7b53b/action/deploy_recipe.py#L58-L60

We could resolve this issue if there was a way to rework the action so that it does not need to call back into the GitHub API, and instead relies only on injected environment variables for the necessary context. As of this moment, I'm not sure if/how we might accomplish that. I'll open an issue on the action for that.

pre-commit.ci autofix

@cisaacstern if you have a minute, could you look into this error:
Traceback (most recent call last):
[59](https://github.com/leap-stc/data-management/actions/runs/5426518167/jobs/9868667430?pr=21#step:5:60)
  File "/srv/conda/envs/notebook/bin/pangeo-forge-runner", line 5, in <module>
[60](https://github.com/leap-stc/data-management/actions/runs/5426518167/jobs/9868667430?pr=21#step:5:61)
    from pangeo_forge_runner.cli import main
[61](https://github.com/leap-stc/data-management/actions/runs/5426518167/jobs/9868667430?pr=21#step:5:62)
  File "/srv/conda/envs/notebook/lib/python3.9/site-packages/pangeo_forge_runner/cli.py", line 3, in <module>
[62](https://github.com/leap-stc/data-management/actions/runs/5426518167/jobs/9868667430?pr=21#step:5:63)
    from .commands.bake import Bake
[63](https://github.com/leap-stc/data-management/actions/runs/5426518167/jobs/9868667430?pr=21#step:5:64)
  File "/srv/conda/envs/notebook/lib/python3.9/site-packages/pangeo_forge_runner/commands/bake.py", line 15, in <module>
[64](https://github.com/leap-stc/data-management/actions/runs/5426518167/jobs/9868667430?pr=21#step:5:65)
    from ..storage import InputCacheStorage, MetadataCacheStorage, TargetStorage
[65](https://github.com/leap-stc/data-management/actions/runs/5426518167/jobs/9868667430?pr=21#step:5:66)
  File "/srv/conda/envs/notebook/lib/python3.9/site-packages/pangeo_forge_runner/storage.py", line 2, in <module>
[66](https://github.com/leap-stc/data-management/actions/runs/5426518167/jobs/9868667430?pr=21#step:5:67)
    from pangeo_forge_recipes.storage import CacheFSSpecTarget, FSSpecTarget, MetadataTarget
[67](https://github.com/leap-stc/data-management/actions/runs/5426518167/jobs/9868667430?pr=21#step:5:68)
ImportError: cannot import name 'MetadataTarget' from 'pangeo_forge_recipes.storage' (/srv/conda/envs/notebook/lib/python3.9/site-packages/pangeo_forge_recipes/storage.py)

Wondering if this is related to https://github.com/pangeo-forge/pangeo-forge-recipes/pull/527 and if there is an easy way for me to circumvent this?

Wondering if this is related to https://github.com/pangeo-forge/pangeo-forge-recipes/pull/527 and if there is an easy way for me to circumvent this? Maybe just getting pgf-recipes from the beam-refactor branch is the solution?

Yes that's correct. And it also reflects that we should have a better plan for integration testing of recipes + runner.
I'll take a closer look at a fix this afternoon. Thanks for raising this, Julius!

Opened https://github.com/pangeo-forge/pangeo-forge-runner/issues/76 to track the issue above. Turns out I won't have time to work up a PR today, but can look at it next week.

@jbusecke, following merge of https://github.com/pangeo-forge/pangeo-forge-runner/pull/77, the issue above should be fixed. Can you try re-deploying the test? (I just checked if I could, but I think I don't have permissions to do so on this repo.)

Rerunning now. Let me also make a dev team here and give you permissions.

Yay! The deployment worked. Could you try to rerun the test, just to confirm that the 'maintain' role (via new data-management-devs team) has enough permissions to do so?

Yep! I can now add/remove labels! Thanks Julius!

So both runs succeed!

Let me try to add all the variables now.

pre-commit.ci autofix

Looking promising! 😄

Deployment was successful, but there is an issue with combining the surface and depth resolved datasets. Debugging that rn.

Hmm this looks like some sort of bug in the recipe to me.
This particular dataset contains surface variables like this:

and full 3d variables like this:

When merging this I would expect it to just work, and in the manual case it does:
import fsspec
import xarray as xr

def make_full_path(variable, time):
    return f'https://downloads.psl.noaa.gov/Datasets/godas/{variable}.{time}.nc'

with fsspec.open(make_full_path('vcur', 1980)) as f:
    with fsspec.open(make_full_path('sshg', 1980)) as f_surf:
        ds = xr.open_mfdataset([f, f_surf])
ds

gives

but from the dataflow logs I am getting an error message like this:
apache_beam.runners.worker.operations.SingletonElementConsumerSet.receive File "apache_beam/runners/worker/operations.py", line 1238, in apache_beam.runners.worker.operations.PGBKCVOperation.process File "apache_beam/runners/worker/operations.py", line 1267, in apache_beam.runners.worker.operations.PGBKCVOperation.process File "/srv/conda/envs/notebook/lib/python3.9/site-packages/pangeo_forge_recipes/combiners.py", line 33, in add_input accumulator.add_input(schema, position) File "/srv/conda/envs/notebook/lib/python3.9/site-packages/pangeo_forge_recipes/aggregation.py", line 70, in add_input self.schema = _combine_xarray_schemas(self.schema, s, concat_dim=self.concat_dim) File "/srv/conda/envs/notebook/lib/python3.9/site-packages/pangeo_forge_recipes/aggregation.py", line 82, in _combine_xarray_schemas dims = _combine_dims(s1["dims"], s2["dims"], concat_dim) File "/srv/conda/envs/notebook/lib/python3.9/site-packages/pangeo_forge_recipes/aggregation.py", line 109, in _combine_dims raise DatasetCombineError(f"Dimensions for {dim} have different sizes: {l1}, {l2}") pangeo_forge_recipes.aggregation.DatasetCombineError: Dimensions for level have different sizes: 40, 0 [while running 'Create|OpenURLWithFSSpec|OpenWithXarray|Preprocess|StoreToZarr/StoreToZarr/DetermineSchema/CombineGlobally(CombineXarraySchemas)/KeyWithVoid-ptransform-48']

This indicates to me that somwhere in the aggregation code the surface variables either get promoted to have a scalar level dimension, or that the aggregation can simply not handle this case yet.
@cisaacstern I think we should add this sort of pattern to the PGF-recipes tests?

This is a leftover from our old mono-feedstock. Can we migrate this into a separate feedstock?
cc @leap-stc/data-and-compute

https://github.com/leap-stc/GODAS_feedstock


OS Error when using offline cached models

OSError: Error no file named diffusion_pytorch_model.bin found in directory /home/khan/.cache/huggingface/hub/models--prompthero--openjourney-v4/snapshots/b195ed2d503f3eb29637050a886d77bd81d35f0e/vae.

No idea what's going on, but the offline feature does not work yet.

Fixed it by downloading the model again, and then setting the offline option again - but the error appears again after 24 hours and all my models keep disappearing?

I think I have a better idea of what's going on.
When setting guidance scale to more than > 1.0 -- an entire new model is going to be downloaded and used.
I will confirm tomorrow see if there's any more issues now that I (think I) have downloaded all the models I need.
ls(base) khan@khan-desktop:~/.cache/huggingface/hub$ ls
models--latent-consistency--lcm-lora-sdv1-5  models--stabilityai--sd-turbo
models--Lykon--dreamshaper-8                 version_diffusers_cache.txt
models--prompthero--openjourney-v4           version.txt

@khanumballz  Follow this tutorial https://www.youtube.com/watch?v=T8kZL5l3K8c


node-drain experiment operator CrashLoopBackOff

Is this a BUG REPORT or FEATURE REQUEST?
BUG REPORT
What happened:
When I tested the node-drain experiment, I found that if drain.yaml is configured as follows, chaos-operator-ce will crash.
apiVersion: litmuschaos.io/v1alpha1
kind: ChaosEngine
metadata:
  name: nginx-chaos
  namespace: default
spec:
  # It can be true/false
  annotationCheck: 'false'
  # It can be active/stop
  engineState: 'active'
  #ex. values: ns1:name=percona,ns2:run=nginx
  auxiliaryAppInfo: ''
#  appinfo:
#    appns: 'default'
#    applabel: 'app=nginx'
#    appkind: 'deployment'
  chaosServiceAccount: node-drain-sa
  monitoring: false
  # It can be delete/retain
  jobCleanUpPolicy: 'delete'
  experiments:
    - name: node-drain
      spec:
        components:
          env:
            # set node name
            - name: APP_NODE
              value: 'sdn-k8s-b2-7'

We can check the operator work status by kubectl.
kubectl get pod -n litmus -o wide
NAME                               READY   STATUS   RESTARTS   AGE     IP          NODE
    NOMINATED NODE   READINESS GATES
chaos-operator-ce-d78fdff7-sjh4k   0/1     Error    6          6m24s   <IP_ADDRESS>   k8s-b2-
6   <none>           <none>

What you expected to happen:
normal work
Anything else we need to know?:
appinfo: Does this field make sense for this experiment?

@kaustumbh7 @chandankumar4 Would you be opposed to add more  new api object for processing node-drain or pod fail e.t.c.

@jjmengze , apologies for the delayed response. New APIs are welcome!! Could you share some example/elaborate on your thoughts?

@ksatchit
Just like user use kubernetes resource deployment,service ...e.t.c.
maybe user love more obvious statement,If I want to chaos pod that I must  to use the resource of ChaosPod , if i would like to chaos network that i should change the resource kind

Ok. So you are saying you would like to create separate api resources for each chaos type. Well, that surely seems one of the models. How litmus is viewing this requirement is:

At the end of the day,  the experiment business logic needs some input - which you could choose to send via say ChaosPod.spec attributes/fields or a set of ENVs or configmaps mapped to a single standard api called ChaosExperiment
The actual chaos execution piece/logic --> needs to be able to use these inputs to execute/inject chaos. Irrespective of whether the logic is in go/python/ansible etc..,

In litmus we ensure the latter by allowing for your logic to be containerized and wrapped in a ChaosExperiment CR like this: https://github.com/litmuschaos/chaos-charts/blob/master/charts/generic/pod-delete/experiment.yaml#L42 w/ your own args/dependencies etc., This experiment will be orchestrated by the chaos-operator.
Having said this, I see the logic of what you are stating. We are exploring this thought process here: https://github.com/litmuschaos/litmus/issues/1374

Is this a BUG REPORT or FEATURE REQUEST?
BUG REPORT
What happened:
When I tested the node-drain experiment, I found that if drain.yaml is configured as follows, chaos-operator-ce will crash.
apiVersion: litmuschaos.io/v1alpha1
kind: ChaosEngine
metadata:
  name: nginx-chaos
  namespace: default
spec:
  # It can be true/false
  annotationCheck: 'false'
  # It can be active/stop
  engineState: 'active'
  #ex. values: ns1:name=percona,ns2:run=nginx
  auxiliaryAppInfo: ''
#  appinfo:
#    appns: 'default'
#    applabel: 'app=nginx'
#    appkind: 'deployment'
  chaosServiceAccount: node-drain-sa
  monitoring: false
  # It can be delete/retain
  jobCleanUpPolicy: 'delete'
  experiments:
    - name: node-drain
      spec:
        components:
          env:
            # set node name
            - name: APP_NODE
              value: 'sdn-k8s-b2-7'

We can check the operator work status by kubectl.
kubectl get pod -n litmus -o wide
NAME                               READY   STATUS   RESTARTS   AGE     IP          NODE
    NOMINATED NODE   READINESS GATES
chaos-operator-ce-d78fdff7-sjh4k   0/1     Error    6          6m24s   <IP_ADDRESS>   k8s-b2-
6   <none>           <none>

What you expected to happen:
normal work
Anything else we need to know?:
appinfo: Does this field make sense for this experiment?

Coming back to the original issue, do you see it working for you if you include appinfo details w/ commenting it. Here are the docs for this exp: https://docs.litmuschaos.io/docs/node-drain/

Closing this issue wrt node-drain experiment execution. However, the thoughts shared by @jjmengze in here: https://github.com/litmuschaos/litmus/issues/1388#issuecomment-612606811 are valuable. Tracking that as a separate issue.


Add snow specific Bottlerocket settings: admin, control, bootstrap snow containers

Issue #, if available:
#4050
Base on #4208
Description of changes:

Override default BR admin, control container images URL
Add bottlerocket-bootstrap-snow to custom bootstrap container image

Hold till #4208 is merged first.
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/retest