Using "Configure" causes Assert fail errors

XRTK - Mixed Reality Toolkit Bug Report
Describe the bug
When opening the development branch clean and using the "Mixed Reality Toolkit-> Configure" option, the console gets flooded with 7 errors, as follows
Assertion failed
UnityEngine.Debug:Assert(Boolean)
XRTK.Editor.PropertyDrawers.MixedRealityProfilePropertyDrawer:OnGUI(Rect, SerializedProperty, GUIContent) (at Packages/com.xrtk.core/Editor/PropertyDrawers/MixedRealityProfilePropertyDrawer.cs:120)
UnityEditor.EditorGUILayout:PropertyField(SerializedProperty, GUIContent, GUILayoutOption[])
XRTK.Editor.Profiles.MixedRealityToolkitRootProfileInspector:RenderSystemFields() (at Packages/com.xrtk.core/Editor/Profiles/MixedRealityToolkitRootProfileInspector.cs:180)
XRTK.Editor.MixedRealityToolkitInspector:OnInspectorGUI() (at Packages/com.xrtk.core/Editor/MixedRealityToolkitInspector.cs:135)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

This source down to

Line 120 of "Core/Editor/PropertyDrawers/MixedRealityProfilePropertyDrawer.cs"

To Reproduce

Checkout dev clean
Open Unity
Hit "Mixed Reality Toolkit-> Configure"
See error

7 errors? probably one for each service we're attempting to render fields for in the root inspector. I'll check it out.

I wasn't able to repro with the steps you provided. Was there any additional steps you may have omitted?
DId you select anything or have any specific scene open when configuring?
Does this happen in brand new projects, or just the core project when doing a fresh clone and pressing configure?

@SimonDarksideJ any update to this? Are you still running into this issue?

Wasn't able to repro this in latest 2019.4.15f1 release and core/sdk preview packages


Trouble on OS X

I am having some trouble using the library on OS X. When I run a simple program (essentially the mnist_conv_fnn example) I get
Uncaught exception:

  Dl.DL_error("dlopen(libtensorflow.so, 1): Symbol not found: _PyCObject_Type\n  Referenced from: ./lib/libtensorflow.so\n  Expected in: flat namespace\n in ./lib/libtensorflow.so")

This is using the lib/python2.7/site-packages/tensorflow/python/_pywrap_tensorflow.so obtained via pip.

I don't currently have access to an OS X box so I cannot only suggest potential fixes for now:

Building libtensorflow.so from the git source should work as it won't require any python dependency.
If you cannot do (1), under linux this error would be caused by libpython2.7.so not being in your LD_LIBRARY_PATH so adjusting this path may work for OS X too. If you don't have libpython2.7.so installed on your system but there is a libpythonXX.so, you can try editing wrapper.ml and replacing libpython2.7.so by libpythonXX.so.

Closing for now as there have been some recent changes to the mac build + google now provides libtensorflow binaries for mac. Feel free to re-open if this is still problematic.


Price plans modal texts improved

Fixes #6243

CR @xavijam

What about the "vector data" text?

Woops my fault, I forgot that.

Please, update the description image and take into account what I said about "replace" operation within templates.

Changes done and description picture updated!

Unlimited "datasets" instead of tables please :)

:+1:

:sparkles:


Linking SDL2

I wish I could link SDL2 in a way that I could add a submodule at gueepo2D/thirdparty/SDL2 and then premake5 would add into the project. This way, the engine gueepo2D would have as a dependency the SDL2 project, not a specific release, or a specific .dll or .lib.
This is more useful when trying to build on different platforms, as the purpose of this engine is to also run on macOS and Unix.
The current proposed approach is to have development libraries pushed in the project (for example, for windows, the .dll and .lib files) - Which raises a number of problems: (i) how to update a dependency version? (ii) how to build on different platforms? - and there's also the issue that the repo will simply grow with files that don't really need to be there.

This will be solved with CMake.


grid2demand integration

https://github.com/asu-trans-ai-lab/grid2demand can generate travel demand models just from a .osm. We can now import scenarios from it: https://a-b-street.github.io/docs/howto/asu.html#importing-a-grid2demand-scenario
One idea is to distribute grid2demand with abst and have a simple UI to specify parameters like the number of grid cells. We could generate the scenario dynamically. There are two complications:

People would need Python installed and the ability for it to run pip to install what's needed. This maybe isn't a huge ask -- many people will already have this.
We'd have to add in a step to download the original .osm file used -- it is available in S3 for all of the abstreet maps. But more straightforward would be to convert abst's map format into GMNS instead. This could also help hook into https://github.com/asu-trans-ai-lab/data2timing more easily too.

No plans to do anything further here


Move tokens from a path param to a query param

When we get more than 50,000+ signatures in a day Google Analytics will send a 'Too many URLs' alert because the tokens are embedded in the path, thus making each one a unique URL.
We can't tell GA to ignore parts of the URL but it can ignore named query parameters, so by moving the token to a query parameter we can ignore it and prevent any future alerts.
Fixes #448.

This looks good, but it needs a rebase since merging #464 :(

No longer needs a rebase now that #464 has been reverted.  Merging.


2019_U8 hang on ppc64le in test_thread_monitor.exe

I have been in communication with Alexey Veprev about issues building 2019_U8 on ppc64le for the Fedora Linux distribution.  I found some hardware to test on.  The issue is that test_thread_monitor.exe hangs most of the time.  GDB has this to say about such a hung process:
(gdb) info threads
  Id   Target Id                                        Frame
* 1    Thread 0x7ffff7ff5510 (LWP 48) "test_thread_mon" 0x00007ffff7aeff1c in sched_yield () from /lib64/libc.so.6
  5    Thread 0x7ffff76bf160 (LWP 54) "test_thread_mon" 0x00007ffff7b0a334 in syscall () from /lib64/libc.so.6
(gdb) bt
#0  0x00007ffff7aeff1c in sched_yield () from /lib64/libc.so.6
#1  0x0000000100005ea4 in rml::internal::thread_monitor::yield ()
    at ../../src/rml/server/thread_monitor.h:232
#2  TestMain () at ../../src/rml/test/test_thread_monitor.cpp:105
#3  0x0000000100004840 in main (argc=<optimized out>, argv=<optimized out>)
    at ../../src/test/harness.h:420
(gdb) bt
#0  0x00007ffff7b0a334 in syscall () from /lib64/libc.so.6
#1  0x0000000100005ad0 in tbb::internal::futex_wait (comparand=2,
    futex=<optimized out>) at ../../include/tbb/machine/linux_common.h:81
#2  tbb::internal::binary_semaphore::P (this=<optimized out>)
    at ../../src/tbb/semaphore.h:205
#3  rml::internal::thread_monitor::commit_wait (c=..., this=0x100041eb8)
    at ../../src/rml/server/thread_monitor.h:255
#4  ThreadState::loop (this=0x100041eb8)
    at ../../src/rml/test/test_thread_monitor.cpp:51
#5  0x00000001000067c8 in ThreadState::routine (arg=<optimized out>)
    at ../../src/rml/test/test_thread_monitor.cpp:31
#6  0x00007ffff7f399a8 in start_thread () from /lib64/libpthread.so.0
#7  0x00007ffff7b11d18 in clone () from /lib64/libc.so.6

The ThreadState object for thread 5 is:
$2 = {monitor = {my_cookie = {
      my_epoch = {<tbb::internal::atomic_impl_with_arithmetic<unsigned long, unsigned long, char>> = {<tbb::internal::atomic_impl<unsigned long>> = {
            my_storage = {
              my_value = 3585}}, <No data fields>}, <No data fields>}},
    in_wait = {<tbb::internal::atomic_impl<bool>> = {my_storage = {
          my_value = true}}, <No data fields>}, skipped_wakeup = false,
    my_sema = {<tbb::internal::no_copy> = {<tbb::internal::no_assign> = {<No data fields>}, <No data fields>},
      my_sem = {<tbb::internal::atomic_impl_with_arithmetic<int, int, char>> = {<tbb::internal::atomic_impl<int>> = {my_storage = {
              my_value = 2}}, <No data fields>}, <No data fields>}}},
  request = 419, ack = 420, clock = 7165, stamp = 7155}

As you can see, request != ack, so this thread was supposed to call monitor.cancel_wait(), but instead it called monitor.commit_wait(c).
Questions:

Consider lines 49-51 of test_thread_monitor.cpp.  Is something supposed to prevent request from changing between reading it in the if condition and calling monitor.commit_wait(c)?  If so, what is that something?  If not, this test has a race.

Is something supposed to cause a memory barrier between the main thread writing request and the other thread reading it?  If so, what is that something?  If not, then this test needs such a barrier.

I tried skipping this test to see if everything else was okay on ppc64le.
And so on for thousands and thousands of lines before I noticed this was happening and stopped the test.

The test_mutex_v2 issue on  is known, and can be safely ignored. This test exists to check the backward compatibility entry points with a really old version of TBB which is very unlikely to be used by any application right now. Perhaps we should remove these backward-compatibility tests from the test target. Alternatively, specifying -DTBB_NO_LEGACY=1 (e.g. adding it to CPLUS_FLAGS for PowerPC architectures inside build/linux.gcc.inc might help.
The issue with test_thread_monitor is not clear, especially without having access to a PowerPC machine. We will double-check the questions you asked, and get back; however it's unclear what more we could do. Also, this test is for an optional TBB binary, which is not of much use even on Intel's architectures, so perhaps building and testing it on PowerPC makes little sense and should be disabled.

I patched tbb to skip test_thread_monitor and reran the build.  Now src/rml/test/test_thread_monitor.cpp is hanging.  It is exactly the same situation as above.  Thread 1 is in the while loop on lines 104-5, waiting for thread 2 to respond.  Thread 2 is stuck in a futex_wait call, below the call to monitor.commit_wait(c) on line 51.  The value of ack is 976.  The value of request is 975, so monitor.cancel_wait() should have been called.
See https://cfarm.tetaneutral.net/ for one way of gaining access to ppc64le hardware.

Two possibilities for gaining access to a PowerPC machine:

https://cfarm.tetaneutral.net
Have someone on your team become a Fedora packager, and help maintain the Fedora package.  That person will gain access to these machines: https://fedoraproject.org/wiki/Test_Machine_Resources_For_Package_Maintainers

Tonight, I patched tbb to skip test_thread_monitor.  The build went on for awhile, but then test_task_scheduler_init.exe hung.  Two threads are left, both on line 281 of src/test/test_task_scheduler_init.cpp, neither able to make progress.
On a whim, I decided to see if there might be something wrong with the ppc64 primitives in include/tbb/machine/mac_ppc.h.  I changed every isync and lwsync to sync.  All of the tests passed.  I won't have time for a few more days, but whenever I can look at this next, I will try doing a binary search to figure out which one is causing the problem.  Hopefully it is just one. :-)  It might be worth looking through the gcc 9 release notes to see if any changes were made to inline asm.

Ignore that last paragraph.  I was looking at the wrong header file.
The problem with test_task_scheduler_init.exe is that ExceptionTest2 creates a barrier for 4 threads, but we're using an arena with my_num_slots == 2.  So 2 threads enter the barrier, then wait there forever for the other 2 threads to show up.  How is the maximum number of threads for the arena decided?

What arena do you mean? There is no explicit arenas in ExceptionTest2 and it uses task_scheduler_init to specify the required number of threads. Have you modified the test?


uid/gid

Please add to choose uid/gid.  Currently defaults to 999, which is used by several things as default, not least of which is puppet.

It doesn't really default to anything, it just uses the first available uid that useradd gives it, but I agree that can conflict if consul is installed first, take 999, and then something else comes along and is pinned to 999.
I would accept a PR, but also I recommend setting your SYS_UID_MIN-SYS_UID_MAX ranges on your system to be outside the range of hand pinned UIDs in puppet to ensure this doesn't happen. (this is what we do at yelp to ensure modules can be installed in any order and ensure that pinned/non-pinned uid/gids never mix)

I'll look up how to do a PR and stuff, and give it a shot.  :) I usually like to pin my services, so that they can be added into ldap, and consistent across containers, as well as viewable as a named process on the host, rather than just the number.  And nice job on your project.  Most things I come across on the forge, usually get used for testing and playing only, and then have to be completely rewritten to be of any actual use in my environment.


When swipe set to true, then 'back' button on navigation bar not working

I have a two page, Dashboard page and slidepanel page.
Click a button in Dashboard page and then go to slidepanel page.
I set 'swipe' parameter to be true. i click 'back' button on navigation bar. it cannot back to Dashboard.
Also, i call Navigator.pop(context), which also not work.

@KingWu please post your code here.

@KingWu you solved?

I also noticed enabling swipe gets too aggressive removing history from the root navigation queue. I'll see if I can find time for a fix and PR. Thanks for the work on this!

@brandon8863 the back button does not close?

Ya beat me to a PR. Yes, commenting out the call to _ensureHistoryEntry() in _handleDragDown fixes the issue.


HTML Report in one single file

Is your feature request related to a problem? Please describe.
We are using Jenkins for builds and we are attaching mutation html report as artefact.

Problem is, when I click on report I see only that custom elements are not supported.
Root cause are security policies for downloading/linking files from html file for JS files.

User receive errors from loading JS files.
Describe the solution you'd like
It would be best, if all 3 required files would be inlined in one html report.
We would not need any alowance and sending over this report would be far easier then using compressed files.

Thanks @HonzaMac for opening this feature request.
I've tried to merge it all into one file once before. However this poses a problem if your JavaScript source code has a string '</script>', as it will close the html script tag. I didn't want to spent a ton of time investigating it.
Do you know a way around the issue? Otherwise I guess we could enable it with an optional config setting.

@nicojs I think we should go with escaping of that values.
Do you have in some branch that "merge" into files? I can follow up and fix escaping.

Thank you!

Sure thing! We will release a new version later this week.


Add a serializer in queue publication builder

This fixes a bug in which we weren't adding a serializer when registering a queue for publications, so attempting to publish would throw an exception.

What confuses me here is why the queue publication tests work - they shouldn't but I can't yet see why!

This was also fixed in #876


Adds #5: support relations

Fixes #5 , please triple check, this is only tested on a hobby project

Summary by CodeRabbit

New Features

Introduced new helper methods for improved query-building.

Improvements

Enhanced readability and maintainability of service methods.
Refactored key methods for consistency in resource handling and validation.

Bug Fixes

Adjusted method signatures for better clarity and alignment.

hi @toonvd can you review the ⚠ Potential issue and make sure that everything works fine on a fresh project install?


Keywords is a good option for the project.

can you update the code and add to extract keywords from page.

Hello @IAMHamzaHaroon,
Can you show me an example of a page with the "keywords" data you need?

Yes Sure,
Your code is about Esty and every page is similar you just need to step once.
Example URL:
https://www.etsy.com/listing/958177892/wooden-gift-box-gift-for-him-grooms-gift?ga_order=most_relevant&ga_search_type=handmade&ga_view_type=gallery&ga_search_query=wooden+gift+box&ref=sr_gallery-1-1&organic_search_click=1&pro=1

This is the keywords of related products mean the original products.


Implement block header format

We should implement the block format in the rust codebase and also explore where we should unhash the block data in the kernel.
See the table below and the following comment for more insight on the format.

Field
Description

prev_hash
Hash of the previous block's header (32 bytes).

block_num
Unique sequential number of the current block (4 bytes should be enough).

chain_root
A commitment to an MMR of the entire chain where each block is a leaf (32 bytes).

state_root
A combined commitment to Account, and Nullifier databases (32 bytes).

note_root
A commitment to all notes created in the current block (32 bytes).

batch_root
A commitment to a set of transaction batches executed as a part of this block (32 bytes).

proof_hash
Hash of a STARK proof attesting to the correct state transition (32 bytes).

Closed by #82.


Textbox content does not propagate across multiuser

In this example, @mattatgit connected a textbox to the URL input, and an image showed up in the image box, but I did not see the text entered into the text box.

could be same as #219


Update Cubs_tool_Usage.md

Description

Checklist

[ ] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[ ] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[ ] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

The cubs_tool is no longer used in CSM 1.6. I am closing this PR and will create a new PR to remove the cubs_tool documentation.


Unify single-response-requests with streaming requests on graphql-transport-ws

(replaces closed #1739)
Various problems with single-response-requests existed as a result of their having a separate control
path from streaming requests.  Single-response-requests are really just special cases of streaming requests
that deliver at most one Next message and need to behave as such.

Description
single-response-request are now handled as tasks and can be overlapped with other requests
on the same connection, can be cancelled, and share the same unique requests ID namespace.
Types of Changes

[ ] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

#1731
#1733
#1734
#1738

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release fixes a number of problems with single-result-operations over
graphql-transport-ws protocol

operation IDs now share the same namespace as streaming operations
meaning that they cannot be reused while the others are in operation

single-result-operations now run as tasks meaning that messages related
to them can be overlapped with other messages on the websocket.

single-result-operations can be cancelled with the complete message.

IDs for single result and streaming result operations are now released
once the operation is done, allowing them to be re-used later, as well as
freeing up resources related to previous requests.

Here's the preview release card for twitter:

Here's the tweet text:
🆕 Release (next) is out! Thanks to @kristjanvalur for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)


The method $scope.toogleMethod() is called when chat service isn't already defined

It happens when screen width is < 800, then it's called in the viewdesktop and also in record, but in record works. Maybe is initialized before

It's my fault I've moved this method from controller to chatservice :-1:


Is Postgres 16 supported by Drogon?

In Wiki and Docs I cannot see which version of Postgres is supported. Could you please list the supported versions.

Yes.
Drogon supports Postgres 10 or higher. If you find compatibility issues, please let us know, thanks.

OK. Thank you!


BLE: Enable/Disable Automatic sending of Connection Parameter update request on Timeout.

Problem:
We want our peripheral to have the Peripheral Preferred Connection Parameters characteristic in the Generic Access service, but we do NOT want the Zephyr stack of our peripheral to automatically send an L2CAP Connection Parameter Update Request if the central doesn't change the connection parameters within a certain time (this behavior is optional according to the spec). We want our peripheral application layer to decide if/when such requests are sent.
Currently, it seems that the Zephyr configuration setting CONFIG_BT_GAP_PERIPHERAL_PREF_PARAMS controls both functionalities at once. If and only if the setting is enabled, the characteristic will be present (in gatt.c), and the update request will automatically be sent (in conn.c). So there doesn't seem to be a way to get one without the other.
In conn.c, when the time out happens, conn_update_timeout() is invoked and Zephyr will Automatically sends out the Connection Parameter update request. If CONFIG_BT_GAP_PERIPHERAL_PREF_PARAMS is enabled it will take the values from Characteristics else internal values.
Solution:
Add a new KConfig flag, say CONFIG_BT_GAP_AUTO_SEND_CONN_PARAMS_ON_TIMEOUT and this can be disabled if the Application layer do not want to automatially send the Update request on time out.
And update conn_update_timeout() in conn.c something like below.
#if defined (CONFIG_BT_GAP_AUTO_SEND_CONN_PARAMS_ON_TIMEOUT)
#if defined (CONFIG_BT_GAP_PERIPHERAL_PREF_PARAMS)
.......
.......
.......
#endif
#endif

CC: @jhedberg

@kipm-ot will you send a PR for this?

@carlescufi yes I am preparing the PR :)


Starting local notebooks server failed with error

Open a notebook and observe the error
Starting local notebooks server failed with error..

Raj, can you give more info? Is this only on windows? Is it a path issue or Jupyter config? What is shown in the output channel and does manually running the Jupyter start command from the command line work or fail?

It's not the Path issue since python is run correctly. Launched 'jupyter notebook' from anaconda and now I am not able to repro. I saw it only on windows. Let me uninstall - reinstall python and see.


bind_key not working

Hello,
the bind key is not working for me. Is this a bug, or a problem with my code?
All data is written to database.db, but shold be seperated to the two databases. The database_logging.db was created but is empty.
The relevant extract of the code. I need the declarative_base because I want to seperate the table definitions over multiple files.
database.py
from sqlalchemy.ext.declarative import declarative_base
Base = declarative_base()

app.py
app = Flask(__name__)

app.config['SQLALCHEMY_DATABASE_URI'] = 'sqlite:///' + os.path.join(basedir, 'database/database.db')
app.config['SQLALCHEMY_BINDS'] = {
    'logging': 'sqlite:///' + os.path.join(basedir, 'database/database_logging.db')
}

db = SQLAlchemy(app, model_class=Base)
with app.app_context():
    db.create_all()

data.py
from sqlalchemy import *
from database.database import Base

class atable(Base):
    __bind_key__ = "logging"
    __tablename__ = "a"
    id = Column(Integer, primary_key=True)
    abc = Column(Text, nullable=False, index=True)

    def __repr__(self):
        return f'<a {self.abc}>'

class btable(Base):
    __tablename__ = "b"
    id = Column(Integer, primary_key=True)
    abc = Column(Text, nullable=False, index=True)

    def __repr__(self):
        return f'<b {self.abc}>'

Environment:

Python version: 3.10
Flask-SQLAlchemy version: 3.0.3
SQLAlchemy version: 2.0.9

You used your own declarative base instead of ours (ir a subclass), so you don't get the features it provides.

Ah Base = db.Model... Thanks!


Just to Chack Push Changes

Trial Pull request to check Permission

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: pshyamjith sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


please explain the installation procces for me

I am new in github. And I have'nt used these types of softwares or websites before.
Please help me to get out of this.
It will be so helpful if explained through a video

wbm is a library for nodeJS, and like any library for nodeJS you install it using npm(node package manager).
Steps:

You must have nodeJS installed
Open your terminal(on linux or windows), go to your project folder on the terminal
Run this command: npm install wbm
Create a anyname.js file
Paste this example of code inside anyname.js(change the phone numbers inside the code to your phone before test, so you are gonna receive the messages)

const wbm = require('wbm');

wbm.start().then(async () => {
    const phones = ['5535988841854', '35988841854', '5535988841854'];
    const message = 'Good Morning.';
    await wbm.send(phones, message);
    await wbm.end();
}).catch(err => console.log(err));

run the command: node anyname.js

Other Way:

Just download the github repository
The repository have a file called test.js
run this command(on the terminal inside the repository folder downloaded): node test.js

Your issue is about how to install wbm, but how to install a npm package, so i recommend you to search about it.

Do I need to install npm or ado I have to clone the repository

When you install nodeJS, it installs npm too.
Installing wbm using npm is a way, git clone is another one, you can choose one of them.
I'm sorry but i can't make a video about it :(, i suggest you to learn a little bit of node, how to install a npm package and how to use a terminal.
wbm is a free programming solution i created for hobby, maybe in the future i can create a friendly interface.

ok thanks


[ToggleButton] Make the prop 'value' optional when button stands alone

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
There are no reasons to pass 'value' prop when ToggleButton is used alone without a ToggleButtonGroup. It should be optional in that case.
Current Behavior 😯
Now it is required.

@ayubov You can't use the ToggleButton standalone. What's you use case for it? Here is how it looks like with #14278:

No, it wasn't designed with that in mind, either originally, or with the v2 restyle.

I think that we should close. On my side, the long term vision is to have a Button, a ButtonGroup to wrap multiple Button and a ToggleButton to have a later of active values.

Ok, I got it. It's really non-sense to use it standalone without additional styles. I can replace it with Button and apply another additional styles to Button. Result will be the same. Thanks.


[Release] sdk/resourcemanager/resourceconnector/armresourceconnector/1.0.0

https://github.com/Azure/sdk-release-request/issues/3955

The breaking changes are introduced and approved in this PR.

@Alancere please add removeUnreferencedType flag.


[1.6.0] Uncrafting grinder shoots items out backwords

Expected: shoots out (into world or chest) where the hole texture is.
But it shoots backwards, opposite of the texture.

Fixed in release 1.6.1


A question about tensorboardx used in code

After running your code in GPU, i wanted to visualize the result in tensorboard. I run "tensorboard ./log/" in the directory, but i got the error:  ValueError: A logdir must be specified when db is not specified. Run "tensorboard --help" for details and examples. However, after i run commend: tensorboard --logdir ./log/. i got the website successfully.
So i wander weather you wrote the wrong commend or i misunderstand it.

You are right, I wrote my command wrong. I will fix my readme. Thanks!


fix pulse calibrations

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 88.726%

Files with Coverage Reduction
New Missed Lines
%

qiskit_research/utils/pulse_scaling.py
3
81.7%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2424

Relevant Lines:
2732

💛  - Coveralls


Rishfilet/vital role section

This is just an initial refactor for reusable components, to create similar sections for bottom line and vital role (on the partners page). I plan to further break it down for reusability in another PR (right now its a bit messy but a start). This also cleaned up a bunch of warnings, cleaned up console.log and style in burger menu. Changed the home in index.js for about us

@rishFilet
Some overall thoughts of mine:

I like how you seperate the userStyle into another file. That definitely helps minimize conflicts down the line.

Great initiative on the refactoring! From my point of view, a component can be reused if there is not much changes needed to be performed (or very very small changes) on that shared component - (Like Saint reuses the HeroText.js component and very little changes need to be made to hide the heart icon).

I understand your intention to reuse the GridContainerFile for both pages. However, I am not too much of a fan for doing this since there are some factors that are not shared between the two sections. For instance, there are 3 paragraphs in Partner page (we should fix it too) whereas there is only one paragraph in another. Maybe it can be fixed by doing some css styling to hide stuff but it will be messy as more pages share this component. In addition, the tablet version for Partner page is like this.

which is quite different from the mobile version of the donation page (if we plan on reusing the component).

One may have to add additional child components/HTML tags into the GridContainerFile and will make the file quite messy.

In my opinion, we can create a copied version of the section that has been done (TheBottomLine.js) and make appropriate modification to suit the needs of other section from other pages. Two benefits: 1) Multiple teammates can work on seperate files without having to change the same refactored files and to avoid conflicts and 2) Changes to that specific sections only occur within that component file, and not to any shared, generic component like GridContainerFile.js.

Would love to hear your thought.

Disclaimer: Putting following comment without actually going through diff of the files bcos too much code change  for me to review lol (@rishFilet good job :O!!)
I concur what @gh0stl0nely  said about leveraging copying/modifying (WET) in certain cases over "argumented reusing" (DRY)
I remember having this discussion with @dghazi12 in some of the first code pieces, how we chose to "hardcode" pieces of configuration within code and deciding to copy/paste as per need
There is no right/wrong approach anyway, and its always good to balance between WET and DRY code principles in my opinion
When all this effort has already been put in this PR toward refactoring (and I am a huge fan of refactoring lol), we can choose to merge I guess ?(will try to actually review the file diffs too :p)

@rishFilet
Some overall thoughts of mine:
* I like how you seperate the userStyle into another file. That definitely helps minimize conflicts down the line.

* Great initiative on the refactoring! From my point of view, a component can be reused if there is not much changes needed to be performed (or very very small changes) on that **shared** component - (Like Saint reuses the HeroText.js component and very little changes need to be made to hide the heart icon).

* I understand your intention to reuse the GridContainerFile for both pages. However, I am not too much of a fan for doing this since there are some factors that are not shared between the two sections. For instance, there are 3 paragraphs in Partner page (we should fix it too) whereas there is only one paragraph in another. Maybe it can be fixed by doing some css styling to hide stuff but it will be messy as more pages share this component. In addition, the tablet version for Partner page is like this.

which is quite different from the mobile version of the donation page (if we plan on reusing the component).

One may have to add additional child components/HTML tags into the GridContainerFile and will make the file quite messy.
* In my opinion, we can create a copied version of the section that has been done (TheBottomLine.js) and make appropriate modification to suit the needs of other section from other pages. Three benefits: 1) Multiple teammates can work on seperate files without having to change the same refactored files and to avoid conflicts and 2) Changes to that specific sections only occur within that component file, and not to any shared, generic component like GridContainerFile.js and 3) Allows for customization for each section.

Would love to hear your thought.

I do agree with both @gh0stl0nely and @harshvchawla but this is not the final version lol. As i mentioned and placed a ticket up on trello, i am going to further refactor this into smaller components. This is the ultimate goal i believe, which is to create a bunch of reusable components that we can plug and place anywhere. So while this is technically one reusable component. I am working backwards and the next step is to refactor the grid container into smaller components that can be edited based on the need for it.
I appreciate the detailed response and review on this.  I'd say when that refactor is complete, then if it still does not work well (i doubt it will as it will be modular pieces), i can revert the commit back to it being two sections.

@rishFilet
Some overall thoughts of mine:
* I like how you seperate the userStyle into another file. That definitely helps minimize conflicts down the line.

* Great initiative on the refactoring! From my point of view, a component can be reused if there is not much changes needed to be performed (or very very small changes) on that **shared** component - (Like Saint reuses the HeroText.js component and very little changes need to be made to hide the heart icon).

* I understand your intention to reuse the GridContainerFile for both pages. However, I am not too much of a fan for doing this since there are some factors that are not shared between the two sections. For instance, there are 3 paragraphs in Partner page (we should fix it too) whereas there is only one paragraph in another. Maybe it can be fixed by doing some css styling to hide stuff but it will be messy as more pages share this component. In addition, the tablet version for Partner page is like this.

which is quite different from the mobile version of the donation page (if we plan on reusing the component).

One may have to add additional child components/HTML tags into the GridContainerFile and will make the file quite messy.
* In my opinion, we can create a copied version of the section that has been done (TheBottomLine.js) and make appropriate modification to suit the needs of other section from other pages. Three benefits: 1) Multiple teammates can work on seperate files without having to change the same refactored files and to avoid conflicts and 2) Changes to that specific sections only occur within that component file, and not to any shared, generic component like GridContainerFile.js and 3) Allows for customization for each section.

Would love to hear your thought.

I do agree with both @gh0stl0nely and @harshvchawla but this is not the final version lol. As i mentioned and placed a ticket up on trello, i am going to further refactor this into smaller components. This is the ultimate goal i believe, which is to create a bunch of reusable components that we can plug and place anywhere. So while this is technically one reusable component. I am working backwards and the next step is to refactor the grid container into smaller components that can be edited based on the need for it.
I appreciate the detailed response and review on this. I'd say when that refactor is complete, then if it still does not work well (i doubt it will as it will be modular pieces), i can revert the commit back to it being two sections.

@rishFilet  Sure, we can look forward to the refactor version. Is it ok if we can keep the original files in place for the 2 sections for now, while you are working on refactoring the GridContainer file on a seperate branch? I just want to make sure that others who are working on fixing padding or styling on those sections can work on them without creating additional conflicts while waiting for your refactored version. Other parts like getting rid of console log, fixing burger style etc.. are good to merge.

@rishFilet
Some overall thoughts of mine:
* I like how you seperate the userStyle into another file. That definitely helps minimize conflicts down the line.

* Great initiative on the refactoring! From my point of view, a component can be reused if there is not much changes needed to be performed (or very very small changes) on that **shared** component - (Like Saint reuses the HeroText.js component and very little changes need to be made to hide the heart icon).

* I understand your intention to reuse the GridContainerFile for both pages. However, I am not too much of a fan for doing this since there are some factors that are not shared between the two sections. For instance, there are 3 paragraphs in Partner page (we should fix it too) whereas there is only one paragraph in another. Maybe it can be fixed by doing some css styling to hide stuff but it will be messy as more pages share this component. In addition, the tablet version for Partner page is like this.

which is quite different from the mobile version of the donation page (if we plan on reusing the component).

One may have to add additional child components/HTML tags into the GridContainerFile and will make the file quite messy.
* In my opinion, we can create a copied version of the section that has been done (TheBottomLine.js) and make appropriate modification to suit the needs of other section from other pages. Three benefits: 1) Multiple teammates can work on seperate files without having to change the same refactored files and to avoid conflicts and 2) Changes to that specific sections only occur within that component file, and not to any shared, generic component like GridContainerFile.js and 3) Allows for customization for each section.

Would love to hear your thought.

I do agree with both @gh0stl0nely and @harshvchawla but this is not the final version lol. As i mentioned and placed a ticket up on trello, i am going to further refactor this into smaller components. This is the ultimate goal i believe, which is to create a bunch of reusable components that we can plug and place anywhere. So while this is technically one reusable component. I am working backwards and the next step is to refactor the grid container into smaller components that can be edited based on the need for it.
I appreciate the detailed response and review on this. I'd say when that refactor is complete, then if it still does not work well (i doubt it will as it will be modular pieces), i can revert the commit back to it being two sections.

@rishFilet Sure, we can look forward to the refactor version. Is it ok if we can keep the original files in place for the 2 sections for now, while you are working on refactoring the GridContainer file on a seperate branch? I just want to make sure that others who are working on fixing padding or styling on those sections can work on them without creating additional conflicts while waiting for your refactored version. Other parts like getting rid of console log, fixing burger style etc.. are good to merge.

Yea sounds good. Ill revert that part and leave the others and commit it.

@hanlinc27 @gh0stl0nely can you approve this with the added changes from hanlin so we can start using the reusable components

@rishFilet Sure. I assume we are not following Figma design on this section. Or that is to be done later?

@rishFilet Sure. I assume we are not following Figma design on this section. Or that is to be done later?

Yup you are right. I added a card here for Blendi/cynthia to update the figma to match our code rather than the design as they agree it looks fine and wouldn't be worth a whole lot to make the change to look exactly like this. https://trello.com/c/XOREgyOo

@demiwu96 @dghazi12 @BBoutet1 @airshiprook @harshvchawla

@demiwu96 @dghazi12 @BBoutet1 @airshiprook @harshvchawla

sounds good that makes life 101% easier.


Enable resource requests/limits on daemonset pods

Please enable me to set a resource request/limit on the daemonset pods.
The structure already exists around the container injection variant, and I'd like the same on DS pods so that my cluster autoscaler can correctly understand how much space needs to be provisioned to fit one of the falcon pods.
When karpenter (our cluster autoscaler) detects unschedulable workloads, it provisions a new node to fit those workloads on it.
For example, if I have 2Gi of memory requests that the scheduler cannot fulfill, karpenter provisions an instance that provides (2Gi + daemonset requests) of memory. If the falcon sensor does not participate in this calculation, my nodes are undersized by whatever amount of resource utilization the falcon sensor would require, and either a daemonset pod is unschedulable (very bad) or a workload pod is unschedulable, causing me to create another instance which is then subject to the same problem again (also bad, but differently).
So I and others need to be able to specify the resource requests for all pods, daemonset or otherwise.

It's a really relevant request, I'm confused why PR was closed =(

Any updates for resources for daemonset mode?

@redhatrises already done - Case number 01097263.

FYI. Limits will probably never be supported.

A great solution for the great SW...

Our organization is trying to deploy this chart, but is going to have to manually copy and modify the chart because it doesn't support setting resource limits on the daemonset. This is a standard feature of most helm charts, so I don't understand why the MR was closed

Because we don't support setting limits especially since kernel processes aren't reported correctly back .e.g. 20MiB and the cpu usage has held constant at 200-300mcores is quite inaccurate usage reporting back.


feat(java): add adoptium eclipse temurin 17

Is this something you feel will be useful to a "larger" audience? If only specific for one or two repos I would suggest adding it locally to those instead.

@Edholm good question. It is for one specific repo so I could add it there. However, Sage already has maven support and maven requires Java so I think this change makes Sage more complete.


Write transfer test

Codecov Report

Merging #1863 into tendermint will increase coverage by 1.56%.
The diff coverage is 44.44%.

@@              Coverage Diff               @@
##           tendermint    #1863      +/-   ##
==============================================
+ Coverage       34.82%   36.38%   +1.56%
==============================================
  Files              68       68
  Lines            3334     3196     -138
==============================================
+ Hits             1161     1163       +2
+ Misses           2173     2033     -140


Project filter doesn't filter results

I tried to filter the Browser (Project view) by one of the pilot datasets, but the Browser still displays all of the projects.

Also after selecting the project, nothing happens when I click on the Specimens or Files tabs. Below is a shot of the JS console, if it helps.

Same behavior noticed if I try to filter on another facet (Organ:blood).

I see the same issue when I click on any of the organs on the main Portal page except Pancreas, Brain, Skin of Body and Embryo - these are the only ones that give me a clickable dataset entry. This is example for spleen:

Occurs on dev and staging.

Thanks for spotting this.
This should be fixed on all environments. Please review.
@theathorn @hannes-ucsc

Confirmed fix in both dev and staging


Update in NodeSetHelper to serialize DataTypeDefinition attribute

Update in NodeSetHelper to serialize DataTypeDefinition attribute for DataType nodes.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


File Parser / Resolver

The parser can now take a single thrift file and follow all its
includes and parse them as well. The output is stored in a FileGroup,
which is returned.
Added a resolver to handle resolution of struct references. As
references are added to the FileGroup, they are placed in the resolver
and after parsing is complete, added to the resolutions field in the
FileGroup.
@pguillory @jparise

Coverage decreased (-6.8%) to 92.157% when pulling c5f32282804885505ede09eb3e475bf4b957c437 on scohen:follow_includes_and_resolver into 3f8002a8ad3e9befbd2152e386c0f05f465c2f65 on pinterest:master.

Coverage decreased (-6.8%) to 92.157% when pulling 9dbeef36b891092d61e8bbc51dfc802b7e6aa542 on scohen:follow_includes_and_resolver into 3f8002a8ad3e9befbd2152e386c0f05f465c2f65 on pinterest:master.

Coverage increased (+0.3%) to 99.296% when pulling 221d166d2b2cc77a49a779dc5143a8cbc8959a24 on scohen:follow_includes_and_resolver into 3f8002a8ad3e9befbd2152e386c0f05f465c2f65 on pinterest:master.

Coverage increased (+0.3%) to 99.296% when pulling 221d166d2b2cc77a49a779dc5143a8cbc8959a24 on scohen:follow_includes_and_resolver into 3f8002a8ad3e9befbd2152e386c0f05f465c2f65 on pinterest:master.

Coverage increased (+0.3%) to 99.296% when pulling bab6132ec19306d0007e655fc45056e67950259d on scohen:follow_includes_and_resolver into 3f8002a8ad3e9befbd2152e386c0f05f465c2f65 on pinterest:master.

Coverage increased (+0.3%) to 99.296% when pulling bab6132ec19306d0007e655fc45056e67950259d on scohen:follow_includes_and_resolver into 3f8002a8ad3e9befbd2152e386c0f05f465c2f65 on pinterest:master.

Coverage increased (+0.3%) to 99.296% when pulling d0ed833cc19c37f50a1e66b4d0ce4ed4c0fd5932 on scohen:follow_includes_and_resolver into 3f8002a8ad3e9befbd2152e386c0f05f465c2f65 on pinterest:master.

Coverage increased (+0.3%) to 99.296% when pulling d0ed833cc19c37f50a1e66b4d0ce4ed4c0fd5932 on scohen:follow_includes_and_resolver into 3f8002a8ad3e9befbd2152e386c0f05f465c2f65 on pinterest:master.

Coverage increased (+0.3%) to 99.296% when pulling d0ed833cc19c37f50a1e66b4d0ce4ed4c0fd5932 on scohen:follow_includes_and_resolver into 3f8002a8ad3e9befbd2152e386c0f05f465c2f65 on pinterest:master.


Pyright issue on Mac OS

I am trying to configure kak-lsp to work with the pyright language server on my macbook (intel based).
My /Users/adam/Library/Preferences/kak-lsp/kak-lsp.toml has a section that looks like the following
[language.python]
filetypes = ["python"]
roots = ["requirements.txt", "setup.py", ".git", ".hg"]
command = "pyright-langserver"
args = ["--stdio"]

My main.py looks like
def foo() -> str:
    return 5

def bar() -> bool:
    return foo()

if __name__ == '__main__':
    print(bar())

If I run pyright I get the following output
No configuration file found.
No pyproject.toml file found.
stubPath /Users/adam/code/demo/typings is not a valid directory.
Assuming Python platform Darwin
Searching for source files
Found 1 source file
/Users/adam/code/demo/main.py
  /Users/adam/code/demo/main.py:2:12 - error: Expression of type "Literal[5]" cannot be assigned to return type "str"
    "Literal[5]" is incompatible with "str" (reportGeneralTypeIssues)
  /Users/adam/code/demo/main.py:6:12 - error: Expression of type "str" cannot be assigned to return type "bool"
    "str" is incompatible with "bool" (reportGeneralTypeIssues)
2 errors, 0 warnings, 0 informations
Completed in 0.538sec

So the cli version of the tools seems to work fine. However, when I open the file in kakoune none of the language server features work (autocomplete, go to definition, etc).
Looking at the /tmp/kak-lsp.log I see
Mar 15 10:44:38.787 INFO Starting main event loop, module: kak_lsp::session:28
Mar 15 10:44:38.788 DEBG Searching for vars starting with KAK_LSP_PROJECT_ROOT_PYTHON, module: kak_lsp::project_root:58
Mar 15 10:44:38.789 INFO Found project root "/Users/adam/code/demo" because it contains ".git", module: kak_lsp::project_root:41
Mar 15 10:44:38.789 DEBG Routing editor request to Route { session: "90217", language: "python", root: "/Users/adam/code/demo" }, module: kak_lsp::session:94
Mar 15 10:44:38.790 DEBG Spawning a new controller for Route { session: "90217", language: "python", root: "/Users/adam/code/demo" }, module: kak_lsp::session:116
Mar 15 10:44:38.790 INFO Starting Language server `/usr/local/bin/pyright-langserver --stdio`, module: kak_lsp::language_server_transport:20
Mar 15 10:44:38.790 DEBG To server: {"jsonrpc":"2.0","method":"initialize","params":{"capabilities":{"general":{"markdown":{"parser":"kak-lsp","version":"12.0.1-snapshot"}},"offsetEncoding":["utf-8","utf-16"],"textDocument":{"callHierarchy":{"dynamicRegistration":false},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}},"dynamicRegistration":false,"isPreferredSupport":false},"codeLens":{"dynamicRegistration":false},"colorProvider":{"dynamicRegistration":false},"completion":{"completionItem":{"commitCharactersSupport":false,"deprecatedSupport":false,"documentationFormat":["markdown","plaintext"],"preselectSupport":false,"resolveSupport":{"properties":["additionalTextEdits"]},"snippetSupport":false},"completionItemKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25]},"contextSupport":false,"dynamicRegistration":false},"declaration":{"dynamicRegistration":false,"linkSupport":false},"definition":{"dynamicRegistration":false,"linkSupport":false},"documentHighlight":{"dynamicRegistration":false},"documentLink":{"dynamicRegistration":false,"tooltipSupport":false},"documentSymbol":{"dynamicRegistration":false,"hierarchicalDocumentSymbolSupport":true},"formatting":{"dynamicRegistration":false},"hover":{"contentFormat":["markdown","plaintext"],"dynamicRegistration":false},"implementation":{"dynamicRegistration":false,"linkSupport":false},"onTypeFormatting":{"dynamicRegistration":false},"publishDiagnostics":{"relatedInformation":false},"rangeFormatting":{"dynamicRegistration":false},"references":{"dynamicRegistration":false},"rename":{"dynamicRegistration":false,"prepareSupport":false},"selectionRange":{},"semanticTokens":{"dynamicRegistration":false,"formats":["relative"],"requests":{"full":true,"range":false},"tokenModifiers":["documentation","constant","readonly"],"tokenTypes":["keyword","namespace","type","variable","function","operator","string","comment"]},"signatureHelp":{"contextSupport":false,"dynamicRegistration":false,"signatureInformation":{"documentationFormat":["plaintext"],"parameterInformation":{"labelOffsetSupport":false}}},"synchronization":{"didSave":true,"dynamicRegistration":false,"willSave":false,"willSaveWaitUntil":false},"typeDefinition":{"dynamicRegistration":false,"linkSupport":false}},"window":{"workDoneProgress":true},"workspace":{"applyEdit":false,"configuration":true,"didChangeConfiguration":{"dynamicRegistration":false},"executeCommand":{"dynamicRegistration":false},"symbol":{"dynamicRegistration":false,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]}},"workspaceEdit":{"changeAnnotationSupport":{},"documentChanges":true,"failureHandling":"abort","normalizesLineEndings":false,"resourceOperations":["create","delete","rename"]},"workspaceFolders":false}},"clientInfo":{"name":"kak-lsp","version":"12.0.1-snapshot"},"processId":90416,"rootPath":"/Users/adam/code/demo","rootUri":"file:///Users/adam/code/demo","trace":"off"},"id":0}, module: kak_lsp::language_server_transport:177
Mar 15 10:44:38.959 DEBG From server: {"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"Pyright language server 1.1.227 starting"}}, module: kak_lsp::language_server_transport:151
Mar 15 10:44:38.959 DEBG From server: {"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"Server root directory: /usr/local/lib/node_modules/pyright/dist/"}}, module: kak_lsp::language_server_transport:151
Mar 15 10:44:38.960 DEBG To editor `90217`: lsp-show-message-log 'Pyright language server 1.1.227 starting', module: kak_lsp::editor_transport:84
Mar 15 10:44:38.963 DEBG From server: {"jsonrpc":"2.0","id":0,"result":{"capabilities":{"textDocumentSync":2,"definitionProvider":{"workDoneProgress":true},"declarationProvider":{"workDoneProgress":true},"typeDefinitionProvider":{"workDoneProgress":true},"referencesProvider":{"workDoneProgress":true},"documentSymbolProvider":{"workDoneProgress":true},"workspaceSymbolProvider":{"workDoneProgress":true},"hoverProvider":{"workDoneProgress":true},"documentHighlightProvider":{"workDoneProgress":true},"renameProvider":{"workDoneProgress":true},"completionProvider":{"triggerCharacters":[".","["],"resolveProvider":true,"workDoneProgress":true},"signatureHelpProvider":{"triggerCharacters":["(",",",")"],"workDoneProgress":true},"codeActionProvider":{"codeActionKinds":["quickfix","source.organizeImports"],"workDoneProgress":true},"executeCommandProvider":{"commands":[],"workDoneProgress":true},"callHierarchyProvider":true}}}, module: kak_lsp::language_server_transport:151
Mar 15 10:44:38.963 DEBG To server: {"jsonrpc":"2.0","method":"initialized","params":{}}, module: kak_lsp::language_server_transport:177
Mar 15 10:44:38.963 DEBG To server: {"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"languageId":"python","text":"def foo() -> str:\n    return 5\n\n\ndef bar() -> bool:\n    return foo()\n\n\nif __name__ == \"__main__\":\n    print(bar())\n","uri":"file:///Users/adam/code/demo/main.py","version":1}}}, module: kak_lsp::language_server_transport:177
Mar 15 10:44:38.963 DEBG To server: {"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"languageId":"python","text":"def foo() -> str:\n    return 5\n\n\ndef bar() -> bool:\n    return foo()\n\n\nif __name__ == \"__main__\":\n    print(bar())\n","uri":"file:///Users/adam/code/demo/main.py","version":1}}}, module: kak_lsp::language_server_transport:177
Mar 15 10:44:38.968 DEBG To editor `90217`: lsp-show-message-log 'Server root directory: /usr/local/lib/node_modules/pyright/dist/', module: kak_lsp::editor_transport:84
Mar 15 10:44:41.111 DEBG From editor:
session  = "90217"
client   = ""
buffile  = ""
filetype = ""
version  =
method   = "stop"
[params]
, module: kak_lsp::editor_transport:129
Mar 15 10:44:41.112 ERRO panic: panicked at 'Failed to parse editor request: Error { inner: ErrorInner { kind: Wanted { expected: "a value", found: "a newline" }, line: Some(5), col: 11, at: Some(73), message: "", key: [] } }', src/editor_transport.rs:131:54, module: kak_lsp:268
Mar 15 10:44:41.112 INFO Shutting down language servers and exiting, module: kak_lsp::session:184
Mar 15 10:44:41.112 INFO Exit python in project /Users/adam/code/demo, module: kak_lsp::session:189
Mar 15 10:44:41.113 INFO Waiting for Controller to finish..., module: kak_lsp::thread_worker:19
Mar 15 10:44:41.113 DEBG To server: {"jsonrpc":"2.0","method":"exit","params":null}, module: kak_lsp::language_server_transport:177
Mar 15 10:44:41.113 INFO Waiting for Messages to language server to finish..., module: kak_lsp::thread_worker:19
Mar 15 10:44:41.113 DEBG Received signal to stop language server, closing pipe, module: kak_lsp::language_server_transport:188
Mar 15 10:44:41.114 DEBG Waiting for language server process end, module: kak_lsp::language_server_transport:87
Mar 15 10:44:41.116 DEBG Language server closed pipe, stopping reading, module: kak_lsp::language_server_transport:129
Mar 15 10:44:42.116 INFO ... Messages to language server terminated with ok, module: kak_lsp::thread_worker:21
Mar 15 10:44:42.116 INFO Waiting for Messages from language server to finish..., module: kak_lsp::thread_worker:19
Mar 15 10:44:42.116 INFO ... Messages from language server terminated with ok, module: kak_lsp::thread_worker:21
Mar 15 10:44:42.117 INFO Waiting for Language server errors to finish..., module: kak_lsp::thread_worker:19
Mar 15 10:44:42.117 INFO ... Language server errors terminated with ok, module: kak_lsp::thread_worker:21
Mar 15 10:44:42.117 INFO ... Controller terminated with ok, module: kak_lsp::thread_worker:21
Mar 15 10:44:42.117 INFO Waiting for Messages to editor to finish..., module: kak_lsp::thread_worker:19
Mar 15 10:44:42.118 INFO ... Messages to editor terminated with ok, module: kak_lsp::thread_worker:21

If you all have any idea how I can further resolve this issue I would be very appreciative.

version  =

This is really weird, this should have the timestamp from $kak_version. Are you somehow calling lsp-stop from a draft context?

method   = "stop"

I wonder why this is being sent at all here - why would we stop the language server 3 seconds after startup?
It works for me. How did you install kak-lsp? If you have the kak-lsp repo inside your autoload folder (e.g. when using plug.kak) then make sure to recompile after upgrading.

This is really weird, this should have the timestamp from $kak_version. Are you somehow calling lsp-stop from a draft context?

Ok nevermind, that was my bad; fixed as of
148c0a90 (Fix request parameters when there is no file in context, 2022-03-16)
so this panic should be gone.
I'm still not sure what the actual problem is maybe try again with latest master?

Thanks for getting back to me so quickly!

Are you somehow calling lsp-stop from a draft context?

I don't think so? I can post my kakrc if that would be helpful?

I wonder why this is being sent at all here - why would we stop the language server 3 seconds after startup?

I just opened the file, waited for few seconds to see if the errors would get picked up and then closed the file when nothing happened.

It works for me. How did you install kak-lsp? If you have the kak-lsp repo inside your autoload folder (e.g. when using plug.kak) then make sure to recompile after upgrading.

I have it installed using plug with the following
plug 'kak-lsp/kak-lsp' do %{
    cargo install --locked --force --path .
}

I thought that would recompile when I upgrade? It seemed like the post update hook was taking a while but I didn't check the log. It also works for me on my windows laptop through WSL 2. It seems like just on a mac I'm having issues.
I pulled the latest master like you recommended and I'm still having issues unfortunately.
Here is the latest log (this time I opened, tried to use go to definition, then closed the file)
Mar 16 09:42:29.298 INFO Starting main event loop, module: kak_lsp::session:28
Mar 16 09:42:29.300 DEBG Searching for vars starting with KAK_LSP_PROJECT_ROOT_PYTHON, module: kak_lsp::project_root:58
Mar 16 09:42:29.301 INFO Found project root "/Users/adam/code/demo" because it contains ".git", module: kak_lsp::project_root:41
Mar 16 09:42:29.302 DEBG Routing editor request to Route { session: "67862", language: "python", root: "/Users/adam/code/demo" }, module: kak_lsp::session:94
Mar 16 09:42:29.302 DEBG Spawning a new controller for Route { session: "67862", language: "python", root: "/Users/adam/code/demo" }, module: kak_lsp::session:116
Mar 16 09:42:29.302 INFO Starting Language server `pyright-langserver --stdio`, module: kak_lsp::language_server_transport:20
Mar 16 09:42:29.305 DEBG To server: {"jsonrpc":"2.0","method":"initialize","params":{"capabilities":{"general":{"markdown":{"parser":"kak-lsp","version":"12.0.1-snapshot"}},"offsetEncoding":["utf-8","utf-16"],"textDocument":{"callHierarchy":{"dynamicRegistration":false},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}},"dynamicRegistration":false,"isPreferredSupport":false},"codeLens":{"dynamicRegistration":false},"colorProvider":{"dynamicRegistration":false},"completion":{"completionItem":{"commitCharactersSupport":false,"deprecatedSupport":false,"documentationFormat":["markdown","plaintext"],"preselectSupport":false,"resolveSupport":{"properties":["additionalTextEdits"]},"snippetSupport":false},"completionItemKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25]},"contextSupport":false,"dynamicRegistration":false},"declaration":{"dynamicRegistration":false,"linkSupport":false},"definition":{"dynamicRegistration":false,"linkSupport":false},"documentHighlight":{"dynamicRegistration":false},"documentLink":{"dynamicRegistration":false,"tooltipSupport":false},"documentSymbol":{"dynamicRegistration":false,"hierarchicalDocumentSymbolSupport":true},"formatting":{"dynamicRegistration":false},"hover":{"contentFormat":["markdown","plaintext"],"dynamicRegistration":false},"implementation":{"dynamicRegistration":false,"linkSupport":false},"onTypeFormatting":{"dynamicRegistration":false},"publishDiagnostics":{"relatedInformation":false},"rangeFormatting":{"dynamicRegistration":false},"references":{"dynamicRegistration":false},"rename":{"dynamicRegistration":false,"prepareSupport":false},"selectionRange":{},"semanticTokens":{"dynamicRegistration":false,"formats":["relative"],"requests":{"full":true,"range":false},"tokenModifiers":["readonly","constant","documentation"],"tokenTypes":["variable","type","operator","comment","namespace","string","function","keyword"]},"signatureHelp":{"contextSupport":false,"dynamicRegistration":false,"signatureInformation":{"documentationFormat":["plaintext"],"parameterInformation":{"labelOffsetSupport":false}}},"synchronization":{"didSave":true,"dynamicRegistration":false,"willSave":false,"willSaveWaitUntil":false},"typeDefinition":{"dynamicRegistration":false,"linkSupport":false}},"window":{"workDoneProgress":true},"workspace":{"applyEdit":false,"configuration":true,"didChangeConfiguration":{"dynamicRegistration":false},"executeCommand":{"dynamicRegistration":false},"symbol":{"dynamicRegistration":false,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]}},"workspaceEdit":{"changeAnnotationSupport":{},"documentChanges":true,"failureHandling":"abort","normalizesLineEndings":false,"resourceOperations":["create","delete","rename"]},"workspaceFolders":false}},"clientInfo":{"name":"kak-lsp","version":"12.0.1-snapshot"},"processId":68065,"rootPath":"/Users/adam/code/demo","rootUri":"file:///Users/adam/code/demo","trace":"off"},"id":0}, module: kak_lsp::language_server_transport:177
Mar 16 09:42:29.979 DEBG From server: {"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"Pyright language server 1.1.230 starting"}}, module: kak_lsp::language_server_transport:151
Mar 16 09:42:29.980 DEBG From server: {"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"Server root directory: /private/var/folders/38/6kx_92r130q91nzpcc7lddfc0000gp/T/pyright-python-langserver/node_modules/pyright/dist/"}}, module: kak_lsp::language_server_transport:151
Mar 16 09:42:29.981 DEBG To editor `67862`: lsp-show-message-log 'Pyright language server 1.1.230 starting', module: kak_lsp::editor_transport:84
Mar 16 09:42:29.983 DEBG From server: {"jsonrpc":"2.0","id":0,"result":{"capabilities":{"textDocumentSync":2,"definitionProvider":{"workDoneProgress":true},"declarationProvider":{"workDoneProgress":true},"typeDefinitionProvider":{"workDoneProgress":true},"referencesProvider":{"workDoneProgress":true},"documentSymbolProvider":{"workDoneProgress":true},"workspaceSymbolProvider":{"workDoneProgress":true},"hoverProvider":{"workDoneProgress":true},"documentHighlightProvider":{"workDoneProgress":true},"renameProvider":{"workDoneProgress":true},"completionProvider":{"triggerCharacters":[".","["],"resolveProvider":true,"workDoneProgress":true},"signatureHelpProvider":{"triggerCharacters":["(",",",")"],"workDoneProgress":true},"codeActionProvider":{"codeActionKinds":["quickfix","source.organizeImports"],"workDoneProgress":true},"executeCommandProvider":{"commands":[],"workDoneProgress":true},"callHierarchyProvider":true}}}, module: kak_lsp::language_server_transport:151
Mar 16 09:42:29.984 DEBG To server: {"jsonrpc":"2.0","method":"initialized","params":{}}, module: kak_lsp::language_server_transport:177
Mar 16 09:42:29.984 DEBG To server: {"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"languageId":"python","text":"def foo() -> str:\n    return 5\n\n\ndef bar() -> bool:\n    return foo()\n\n\nif __name__ == \"__main__\":\n    print(bar())\n","uri":"file:///Users/adam/code/demo/main.py","version":1}}}, module: kak_lsp::language_server_transport:177
Mar 16 09:42:29.984 DEBG To server: {"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"languageId":"python","text":"def foo() -> str:\n    return 5\n\n\ndef bar() -> bool:\n    return foo()\n\n\nif __name__ == \"__main__\":\n    print(bar())\n","uri":"file:///Users/adam/code/demo/main.py","version":1}}}, module: kak_lsp::language_server_transport:177
Mar 16 09:42:29.989 DEBG To editor `67862`: lsp-show-message-log 'Server root directory: /private/var/folders/38/6kx_92r130q91nzpcc7lddfc0000gp/T/pyright-python-langserver/node_modules/pyright/dist/', module: kak_lsp::editor_transport:84
Mar 16 09:42:31.654 DEBG From editor:
session  = "67862"
client   = "client0"
buffile  = "/Users/adam/code/demo/main.py"
filetype = "python"
version  = 1
method   = "textDocument/definition"
[params.position]
line      = 10
column    = 11
, module: kak_lsp::editor_transport:129
Mar 16 09:42:31.654 DEBG Searching for vars starting with KAK_LSP_PROJECT_ROOT_PYTHON, module: kak_lsp::project_root:58
Mar 16 09:42:31.654 INFO Found project root "/Users/adam/code/demo" because it contains ".git", module: kak_lsp::project_root:41
Mar 16 09:42:31.655 DEBG Routing editor request to Route { session: "67862", language: "python", root: "/Users/adam/code/demo" }, module: kak_lsp::session:94
Mar 16 09:42:31.655 DEBG To server: {"jsonrpc":"2.0","method":"textDocument/definition","params":{"position":{"character":10,"line":9},"textDocument":{"uri":"file:///Users/adam/code/demo/main.py"}},"id":1}, module: kak_lsp::language_server_transport:177
Mar 16 09:42:32.774 DEBG From editor:
session  = "67862"
client   = ""
buffile  = ""
filetype = ""
version  = 0
method   = "stop"
[params]
, module: kak_lsp::editor_transport:129
Mar 16 09:42:32.774 INFO Shutting down language servers and exiting, module: kak_lsp::session:184
Mar 16 09:42:32.774 INFO Exit python in project /Users/adam/code/demo, module: kak_lsp::session:189
Mar 16 09:42:32.774 INFO Waiting for Controller to finish..., module: kak_lsp::thread_worker:19
Mar 16 09:42:32.775 DEBG To server: {"jsonrpc":"2.0","method":"exit","params":null}, module: kak_lsp::language_server_transport:177
Mar 16 09:42:32.775 INFO Waiting for Messages to language server to finish..., module: kak_lsp::thread_worker:19
Mar 16 09:42:32.775 DEBG Received signal to stop language server, closing pipe, module: kak_lsp::language_server_transport:188
Mar 16 09:42:32.775 DEBG Waiting for language server process end, module: kak_lsp::language_server_transport:87
Mar 16 09:42:32.785 DEBG From editor:
session  = "67862"
client   = ""
buffile  = "/Users/adam/code/demo/main.py"
filetype = "python"
version  = 1
method   = "textDocument/didClose"
[params]
, module: kak_lsp::editor_transport:129
Mar 16 09:42:32.789 DEBG Language server closed pipe, stopping reading, module: kak_lsp::language_server_transport:129
Mar 16 09:42:33.778 INFO ... Messages to language server terminated with ok, module: kak_lsp::thread_worker:21
Mar 16 09:42:33.778 INFO Waiting for Messages from language server to finish..., module: kak_lsp::thread_worker:19
Mar 16 09:42:33.778 INFO ... Messages from language server terminated with ok, module: kak_lsp::thread_worker:21
Mar 16 09:42:33.778 INFO Waiting for Language server errors to finish..., module: kak_lsp::thread_worker:19
Mar 16 09:42:33.779 INFO ... Language server errors terminated with ok, module: kak_lsp::thread_worker:21
Mar 16 09:42:33.779 INFO ... Controller terminated with ok, module: kak_lsp::thread_worker:21
Mar 16 09:42:33.779 INFO Waiting for Messages to editor to finish..., module: kak_lsp::thread_worker:19
Mar 16 09:42:33.779 INFO ... Messages to editor terminated with ok, module: kak_lsp::thread_worker:21

Any other ideas I can try

I've pushed a test case to the pyright that shows that this works macOS.
Can you run that test test/pyright-goto-definition.sh or test/run test/pyright-goto-definition.sh
The test will run in an isolated home directory (though it won't clear environment variables) so it should be mostly independent of your user's configuration in case that's the problem

I thought that would recompile when I upgrade?

yep

I pulled down the pyright branch reran cargo install --locked --force --path ., ran test/run test/pyright-goto-definition.sh, and saw the following output:
Failure in test/pyright-goto-definition.sh:

  The CHECK on line 28 wants:
    def %()foo() -> int:

  which failed to match line stdout:1:
     1│ def %()foo() -> int:

  Context:
     1│ def %()foo() -> int: <= does not match CHECK 'def %()foo() -> int:' on line 28
     1│     return 5 <= does not match CHECK 'return 5' on line 29
     2│ <= does not match CHECK 'print(foo())' on line 31
     3│ print(foo()) <= no check matches this, previous check on line 31
    ~
    ~
                                           main.py 1:8 [+] 1 sel - client0@[session]

  when running command:
    /bin/sh test/pyright-goto-definition.sh

Anything more I can do on my end? Thanks for being so responsive!

1│ def %()foo() -> int:

This means the test works the cursor successfully jumped to definition and inserted %() (the 1|  is another problem, see below).
Since the test (almost) passess, the problem is very likely somewhere in your config
Please try starting Kakoune like HOME=/some/temp/dir kak main.py where /some/temp/dir contains the minimal .config/kak/kakrc and .config/kak-lsp/kak-lsp.toml necessary to reproduce this.
The 1|  prefix is probaby just a line number highlighter from your config. This is likely a bug in the test framework; it should override that. I wonder if we need to explicitly export HOME (untested)
diff --git a/test/lib.sh b/test/lib.sh
index 451248a2..0c770e1d 100644
--- a/test/lib.sh
+++ b/test/lib.sh
@@ -15,7 +15,7 @@ fi
 command -v tmux >/dev/null

 # Export a fresh HOME, so Kakoune runs without user configuration.
-HOME=$(mktemp -d)
+export HOME=$(mktemp -d)
 cd "$HOME"
 export TMPDIR=$HOME # Avoid interfering with other kak-lsp processes.
 env=$(env)

also, could you try if it works in another editor like neovim? that would narrow down the issue further

Sorry yeah I'll try doing those today, yesterday was crazy. I've been using neovim for several months with pyright just fine using the built in lsp client. It seems to be an issue I can only reproduce with kakoune unfortunately. VSCode and emacs also seem to work well.

Sorry for the delay
I created a minimal kakrc here: pastebin
Here is my ksk-lsp.toml which only modified the python section to use pyright instead of pyls pastebin
The pyls language server works just fine in kakoune btw it's just pyright for some reason
Here is main.py: pastebin
Here is the kak-lsp debug log: pastebin
Let me know what else I can provide!

I tried your config (with pyright 1.1.231) but it works just fine (I think only the bottom part starting with eval %sh{kak-lsp ...} is really necessary.)
If you can find a reproducer I can run, preferably an executable test that works on github actions (like the one in the pyright branch), that would help a lot.
BTW I think I found the problem with the spurious line numbers in your test run:
Kakoune loads %val{runtime}/kakrc which loads %val{runtime}/kakrc.local.
The latter might have arbitrary customizations. Commit 9b1b12d2f64bbf52779703fb1fdb289c30578b12 avoids loading it in tests.
(Users shouldn't modify %val{runtime}/kakrc because that's in the realm of Kakoune)


Help, why 'no output directory' ?

Why the results are no output directory?
I went to the folder google-hosts-master/scripts/, and then:
$./filter.sh mail.google.com
no output directory.
$./select.sh
no output directory.

You must run ./auto.sh first, this script will create output directory.
$ ./auto.sh
BTW, Don't forget to check Requirements:
https://github.com/txthinking/google-hosts/blob/master/scripts/README.md
On Mon, Apr 20, 2015 at 4:31 PM xujchen<EMAIL_ADDRESS>wrote:

Why the results are no output directory?
$./filter.sh mail.google.com
no output directory.
$./select.sh
no output directory.
—
Reply to this email directly or view it on GitHub
https://github.com/txthinking/google-hosts/issues/83.


Fix: Get transactions missing types

Context
Recently a new endpoint has been added to receive historical transactions. Only thing missing were the generated types.
What has been done

well....
yarn build that's all 😝

@icastillejogomez @danielvandenberg95 any idea why it might be failing? It's simply a build from the source, nothing else has been edited...

@danielvandenberg95 the linter is failing

Seems like the library has not been complying to it's own lint rules for a while now. All the errors outputted by the linter are valid, albeit not in files changed by this PR. Ignoring them for this PR sounds like a valid option to me.
Non-compliant files are:

src/api/getTransactionsRequest.ts
src/types/GetTransactionsOptionsType.ts
src/types/TransactionType.ts
src/types/index.ts

I'll approve this PR as it looks good. A separate issue has been created for the linting.


Update timber-image-helper.php  #405

fix issue  #405

Coverage increased (+0.04%) to 72.79% when pulling f09f2c99c068dafa730489158f28f4898b4f8dcd on marciojcoelho:patch-2 into 7221aa7690ad57ef5fb6af7f05a2cb6a960d5a5c on jarednova:master.

Coverage increased (+0.04%) to 72.79% when pulling 856498ef2145994a6c106014c97bc04223dfb439 on marciojcoelho:patch-2 into 7221aa7690ad57ef5fb6af7f05a2cb6a960d5a5c on jarednova:master.

:+1: thanks @marciojcoelho !


Removed ReactorWithEffects.MutationWithEffect

CHANGES

Removed MutationWithEffect and updated tests
Bumped to version 0.9.5

Coverage decreased (-4.2%) to 70.833% when pulling 1b2731decc09a92ec57ad7ebfc4ce7e6e8508a50 on removed-mutationwitheffect into ecf1ee184e79febc1bd72a5f841a8aa42055c751 on master.


Improvements for comparison processes

Changes:

Comparison processes eq, gt, gte, lt, lte, neq and between accept all data types as input for the operands.
text_begins, text_contains, text_ends: null values are supported and get passed through.
Fix: between may return a null value.
Several clarifications

I think all changes are quite straightforward. The thing to debate is probably whether arrays and objects should be comparable or always return false?
Main reason for the changes was the absence of some data types from some of the comparison, especially booleans.

Telco: Only work on scalars.


Duplicate paragraph

After the IHV has certified the base driver, it can be deployed on all OEM systems. Because a base driver can be used across all systems that share a hardware part, Microsoft can test the base driver broadly by using Windows Insider driver flighting instead of limiting distribution to specific machines.

After IHV has certified the base driver package, it can be deployed on all OEM systems. Because a base driver package can be used across all systems that share a hardware part, Microsoft can test the base driver package broadly via Windows Insider flighting, rather than limiting distribution to specific machines.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2c5fa76b-6c2e-8f5e-7e96-ceb1c726842b
Version Independent ID: 48a29c52-9907-9b1a-1dc2-3365c2d021d0
Content: Getting started with Universal Windows drivers - Windows drivers
Content Source: windows-driver-docs-pr/develop/getting-started-with-universal-drivers.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Well, that's interesting.
Thanks for catching this, @Sunbreak
Appreciate the Issue.
Closed in source and merged to live branch.


Fix to support files with spaces in their name

Fix to support files with spaces in their name

Thank you! 🚀 https://marketplace.visualstudio.com/items?itemName=fmoronzirfas.open-in-marked#overview


add interaction instructions

Coverage decreased (-0.06%) to 80.826% when pulling 2b848de6f0a92b2440633049df856a8a53a7233f on RNAer:master into 8999eb88616a6073a23b7927f8fdb22bdb67ac81 on amnona:master.


New-AzureRmADApplication/Set-AzureRmADApplication: not possible to add reply url for Public client/Native app

With New-AzureRmADApplication and Set-AzureRmADApplication it is possible to set reply urls for Azure AD app:
$replyUrls = @()
$replyUrls += "url1"
$replyUrls += "url2"
...
New-AzureRmADApplication -DisplayName ... -ReplyUrls $replyUrls

However all specified reply urls will be added with Type = "Web":

I.e. it is not possible to specify "Public client/native" type for reply url.

Hi @sadomovalex
Thank you for your issue submission.  I have created a work item to track this issue and will be sending it to engineering.  At this point, I am going to go ahead and close this issue.  I will post an update as soon as I have any additional information.
Thank you!
Bill


Updated CLI steps to avoid Drupal installation errors

This patch makes a few tweaks to streamline initial installation:

Adds prerequisites with links.
Removes sites/default/files and sites/default/settings.php after ddev creates them when setting the project type - if they are present when ddev drupal install is run, Drupal errors saying it's already installed.
Sets the yarn version and enables corepack, see #12.
Adds steps to install drush, if desired.

For a more detailed breakdown, see this gist.

Thanks @rfay, I've accepted your changes.

It may make more sense to apply my changes after #17 is resolved, as it overlaps. I also personally preferred @rpkoller 's README in #13, much easier to digest for newcomers :) Shall we continue this work in those tickets?

#17 is in.

Different approach (I hadn't read this PR closely and my solution has different things, ironically) https://github.com/justafish/ddev-drupal-core-dev/pull/21

A couple of suggestions @T-Fletcher -

Please use a named branch for PRs, so you don't get messy with trying to use "main" for various things. It always comes out badly. Use a branch like "20240328_fix_drupal_install_errors" or something like that.
When you close a PR without merging, please don't delete the branch. It loses all the changes.

Thanks for the advice @rfay, this as my first time working with multiple devs on the same issue. I'll be sure to use feature branches and preserve the work even when closing the MR. Thanks!


[Codegen] Wrap the content of the case Array and case $ReadOnlyArray in Flow into a separate function

Summary

This PR aims to extract translateArrayTypeAnnotation logic into a separate function as it is done in typescript folder. This will enable us to extract translateArrayTypeAnnotation function into a shared folder in a later step. It is a task of #34872:

Wrap the content of the case Array: and case ReadOnlyArray in Flow into a separate function, as it is for the TypeScript parser. This will enable us to unify the two parsers in a later step.

Changelog

[Internal] [Changed] - Wrap the content of the case Array and case $ReadOnlyArray in Flow into a separate function
Test Plan

yarn flow:

yarn lint:

yarn jest react-native-codegen:

Note: No new test because translateArrayTypeAnnotation is not exported. We can create new tests on this when the function will be extracted to be shared with typescript folder.


HMAC validation

Sorry, I can't merge this one as-is either. There are just too many drastic changes. I took some inspiration from your and updated the existing code base in a way that I feel better suits the style goals of the code base. Consistency of the code base is something that is very important to me.
Thank you for your help, I do appreciate it! and thanks for notifying me of this change, I had no idea.
If you have a moment, please do check out the master branch and test the updates in a live setting. The tests are currently passing but I have not validated in a live setting.
thanks!


Tests not passing in master

It seems that there is one test case in master that is raising a panic.
I have done a little bit of debugging and it seems that it happens in the following line engine.go#120.
I have checked all the PR's tests and they have passed so the regression might have happened when overlapping features got together. Do you have any take on why this could be avoided?
In my opinion, enforcing people to rebase master before merging a PR (running the tests again at that stage) will catch some of these issues. What do you think? Is this something that happens often?
=== RUN   TestBadValues
--- FAIL: TestBadValues (0.00s)
panic: assignment to entry in nil map [recovered]
	panic: assignment to entry in nil map

goroutine 7 [running]:
panic(0x7d7720, 0xc820249570)
	/usr/local/go/src/runtime/panic.go:481 +0x3ff
testing.tRunner.func1(0xc8200a2510)
	/usr/local/go/src/testing/testing.go:467 +0x22a
panic(0x7d7720, 0xc820249570)
	/usr/local/go/src/runtime/panic.go:443 +0x521
k8s.io/helm/pkg/engine.(*Engine).render(0xc8202b1d20, 0xc8202b4210, 0xc8202b4210, 0x0, 0x0)
	/home/migmartri/work/gocode/src/k8s.io/helm/pkg/engine/engine.go:120 +0xfbb
k8s.io/helm/pkg/engine.(*Engine).Render(0xc8202b1d20, 0xc8202a3500, 0x0, 0xb, 0x0, 0x0)
	/home/migmartri/work/gocode/src/k8s.io/helm/pkg/engine/engine.go:78 +0x61
k8s.io/helm/pkg/lint/rules.Templates(0xc8202b1e50)
	/home/migmartri/work/gocode/src/k8s.io/helm/pkg/lint/rules/template.go:58 +0x468
k8s.io/helm/pkg/lint.All(0x90c980, 0x1c, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/migmartri/work/gocode/src/k8s.io/helm/pkg/lint/lint.go:34 +0xda
k8s.io/helm/pkg/lint.TestBadValues(0xc8200a2510)
	/home/migmartri/work/gocode/src/k8s.io/helm/pkg/lint/lint_test.go:74 +0x5b
testing.tRunner(0xc8200a2510, 0xac1fd0)
	/usr/local/go/src/testing/testing.go:473 +0xdd
created by testing.RunTests
	/usr/local/go/src/testing/testing.go:582 +0xae3
FAIL	k8s.io/helm/pkg/lint	0.061s

The line references the Template namespace changes.
In any case, the takeaway I'd like to get from this issue is to know your take on how this has happened and how we can avoid it.
cc/ @technosophos

I think this happened when two PRs got merged at around the same time. Each individually passed, and when GitHub did the auto-merge, they caused a test to break.

Fixed by #919


Official CentCom Costume to uplink

About the PR
adding:

Official Centcom Costume Bundle to Uplink

Why / Balance

More variety for antagonists
SS13

Media

Changelog
under

Isnt like chameleon suit can turn into centcom official?

This got removed
https://github.com/space-wizards/space-station-14/pull/6895

how about a ghost role that has a low chance of spawning for a REAL centcom official to come to the station and do an audit, would be a good roleplay opportunity and a reason for this to exist

also 25TC is too much, make it 2TC

how about a ghost role that has a low chance of spawning for a REAL centcom official to come to the station and do an audit, would be a good roleplay opportunity and a reason for this to exist

yeah, that was the original problem
I think everyone is fine with some kind of cc rep, inspector, assistant kind of event but it's just a wyci

also 25TC is too much, make it 2TC

it's too imbalance

chameleon can do this and isnt 25tc
also this still needs a way to avoid being metagamed as per the removal pr discussion

The solution is just to add the centcomm event. So players believe it both ic and ooc, removing the risk of metagaming.

also 25TC is too much, make it 2TC

it's too imbalance

whats worth more? clothes? or a full auto shotgun?

also 25TC is too much, make it 2TC

it's too imbalance

whats worth more? clothes? or a full auto shotgun?

trust

compelling argument

Chameleon clothes already do this job and the costume was removed for good reasons that haven't been addressed.


Spawner Bugged?

I tried beaming two different living materials, but they always go to the top slot...

 There was a bug in the config

I was on 1.10 - 5.62
just updated it thank you


opensbi: init at 1.0

Motivation for this change
With 1.0, patches are no longer required for HiFive Unmatched so I think it's time to finally upstream this to Nixpkgs.
Tested by building natively on riscv64-linux as well as cross-compiling from x86_64-linux. Works on QEMU as well as on Unmatched.
Ref: #101651
Things done

Built on platform(s)

[x] riscv64-linux
[x] riscv64-linux (cross from x86_64-linux)

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Thanks all! I have integrated @ius's changes and updated the PR. Also adding you both to the maintainer list, which I hope you don't mind. OpenSBI doesn't seem to get releases often so there shouldn't be many pings.


Use MacawUI

I want to merge this change because it moves theming outside dashboard, right into https://github.com/mirumee/macaw-ui.
PR intended to be tested with API branch: master
Screenshots

Pull Request Checklist

[x] This code contains UI changes
[ ] All visible strings are translated with proper context including data-formatting
[ ] Attributes [data-test-id] are added for new elements
[x] Changes are mentioned in the changelog
[x] The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://qa.staging.saleor.cloud/graphql/

Task linked: SALEOR-3287 Use Macaw-UI in both Saleor Cloud and Saleor Dashboard


HIveRunner keeps failing

I keep getting the below error and could not find which jar im skipping. I'm not able to find the below class in ay of jar.
2016-04-05 08:59:59     DEBUG     HiveServerContainer : 173    -    org/apache/hadoop/fs/FSDataInputStream$FadviseType
java.lang.NoClassDefFoundError: org/apache/hadoop/fs/FSDataInputStream$FadviseType
at org.apache.hadoop.mapred.LineRecordReader.close(LineRecordReader.java:284)

Looks like , I did some config changes and know im stuck at :All resource target files should be created in a subdirectory to the test case basedir
Somehow need to find where the standaloneHiveRunner is creating the dir.

Hi, Sorry for a very late reply
You can retrieve the basedir of your hiverunner test either by HiveShell#getBaseDir() or through hive configuration property ${hiveconf:hadoop.tmp.dir}.
Hope that helps!
/Pelle


Introduce custom error handling across codebase

Title: Introduce custom errors handling across codebase
Issue:
Right now we use boilerplate ValueError and Exception throughout the codebase. While these standard exceptions can provide basic error handling functionality, they lack the specificity and flexibility needed for effective debugging and error resolution.
Problem:
The primary issue with this approach is that it can be hard to identify exactly where an error has occurred and what caused it, especially in a large codebase. This is because standard exceptions do not provide specific context about the error, its source, or the part of the codebase it affects.
Furthermore, there may be certain scenarios in our application where we'd like to handle exceptions differently based on the type of error that occurred. This is not easily achievable with the current, generic exception handling.
Proposed Solution:
In order to provide more specific and meaningful error messages, and to handle exceptions in a more flexible way, we propose introducing custom exception classes across the codebase.
These custom exceptions should inherit from the base Exception class or appropriate subclasses (such as ValueError or TypeError), and should be designed to encapsulate a particular type of error that could occur within our application.
Here's an example of what a custom exception class might look like:
class CustomDatabaseError(Exception):
    """Raised when a specific error occurs in the database module."""

    def __init__(self, message="A database error occurred"):
        self.message = message
        super().__init__(self.message)

In this example, the CustomDatabaseError would be raised whenever a specific database-related error occurs, making it easier to identify and handle this specific kind of error.
Tasks:

[ ] Review the codebase to identify areas where custom exceptions would be beneficial.
[ ] Design custom exception classes that encapsulate specific types of errors in our application.
[ ] Replace generic exceptions with custom exceptions throughout the codebase.
[ ] Test the system to ensure custom exceptions are working as expected and providing more meaningful error information.
[ ] Update documentation to reflect the introduction of custom exceptions.

Through these steps, we can create a more robust and developer-friendly error handling system that will make our codebase easier to maintain and debug.
As always, don't hesitate to ask if you have any questions or need further clarification. Your contributions to this project are highly valued!

Hello everyone,
I find this issue to be quite interesting and I believe it's an area where we can really enhance the readability and maintainability of our codebase. Therefore, I am going to take this issue and start working on it.
I plan to share a pull request with the initial set of changes by tomorrow, or perhaps by Wednesday at the latest. As I'm currently in the process of familiarizing myself with the entire codebase and reading through the documentation, I estimate that this task might take me about a week to complete.
Of course, should it take longer, we can take it as an opportunity to ensure the quality of the changes is up to our high standards, and to have a rich discussion about best practices for error handling in our project.
Looking forward to working on this and hearing your thoughts!
Best regards,
Robert

If this issue is still open, I would love to work on this. @emrgnt-cmplxty , @Exarchias

Nice choice @ganesh-palanikumar! I am not working currently at this issue, so if @emrgnt-cmplxty agrees as well, feel free to jump to it!


Is Shiva works? How to test it from remote location?

I hope that I configured the honeypot correctly. I'm using a Python script to test honeypot from localhost. And it works. We can see in the logs:
2018-04-11 09:19:22,085 - root - DEBUG - Pulled message with key: '1523431157.M154179P9513Q2-212.X.X.X-shiva-none' off
2018-04-11 09:19:22,088 - root - CRITICAL - Inside Attachment handling
2018-04-11 09:19:22,088 - root - CRITICAL -     [+]Fixing Padding for Attachment if needed
2018-04-11 09:19:22,089 - root - INFO - [+]Inside shivadecide module.
2018-04-11 09:19:22,089 - root - INFO - Inside shivaaddnewrecord Module.
2018-04-11 09:19:22,089 - root - INFO - [+]shivaaddnewrecord Module: Adding recipient to whitelist and relaying
2018-04-11 09:19:22,089 - root - INFO - key: ab3fc69a590ebf0cc0d1f13cd70f3d89, value<EMAIL_ADDRESS>2018-04-11 09:19:22,089 - root - INFO - key: spammers_email, value: []
2018-04-11 09:19:22,089 - root - INFO - key: d32d96409e1725b21040b07a0b70fed3, value<EMAIL_ADDRESS>2018-04-11 09:19:22,090 - root - DEBUG - Message received from Peer: '/home/test/shiva-installer/shiva/queue/', From: u'From Person<EMAIL_ADDRESS>to To [u'test$2018-04-11 09:19:22,091 - routing - DEBUG - Matched<EMAIL_ADDRESS>against START.
2018-04-11 09:19:22,091 - routing - DEBUG - Message to<EMAIL_ADDRESS>was handled by app.handlers.sample.START
2018-04-11 09:19:22,091 - routing - DEBUG - Matched<EMAIL_ADDRESS>against FORWARD.
2018-04-11 09:19:22,103 - routing - DEBUG - Message to<EMAIL_ADDRESS>was handled by app.handlers.sample.FORWARD
2018-04-11 09:19:22,103 - root - DEBUG - Removed '1523431157.M154179P9513Q2-212.X.X.X-shiva-none' key from queue.

I am trying to log in from a remote location using the telnet command. Seems that it is not working, so a potential spammers couldn't login into my server:
Microsoft Telnet> open 212.X.X.X 25
Connecting To 212.X.X.X...Could not open connection to the host, on port 25: Connect failed

My server use a static IP and public.
Any tips?

Hi,
Please check the configuration file for listening port https://github.com/shiva-spampot/shiva/blob/master/helpers/shiva.conf#L14

I've setup port on 25 and I have a lot, a lot, a lot! message. Disk with size 25GB has been fulled up on 50% more that 12h. So I think that my configuration is correct.


[EP] Improving Filter Structure for Map

Description
With the latest updates that were deployed on 12 Feb, the filter structure of the map has been negatively affected. Some data were implemented as layers and some filters were not related to these layers. This has made it difficult to return the right data when combining filters and layers, and they were not useful for all purposes of the map.
Objective
The objective of this epic is to improve the filter structure of the map so that it returns the right data and is useful for all purposes.
Solution
Divide the filters into three groups: victims' information, help calls, and services. Each group will have categories with multiple selection options. The layers will only have visible map type (satellite, etc.) and map content (heat map and markers).
https://www.figma.com/file/ndZkyLsSzpXtEbGGcBxyOa/Afetharita-filtre-yapısı?node-id=0%3A1&t=p57hLhvoECs6yFGs-0
https://www.figma.com/file/sctw6xtcdoFOfmE0gC97Ft/Afet-Harita---Afetharita.com?node-id=5383%3A11160&t=453ihQvDDpYAOPkT-0
Benefits
By improving the filter structure, the map will be more user-friendly and provide accurate data. This will make it easier for users to find the information they need and make better-informed decisions. Additionally, having a clear and organized filter structure will improve the overall functionality of the map.
Acceptance Criteria:

[ ] Filters are divided into three groups: victims' information, help calls, and services.
[ ] Each filter group has multiple selection categories.
[ ] Layers only contain visible map type (satellite, etc.) and map content (heat map and markers).
[ ] Filter and layer selection options return the right data when combined.
[ ] Filter structure is user-friendly and easy to understand.

Success Criteria:

[ ] Increased user satisfaction with the map, as measured by a user survey or feedback mechanism.
[ ] Improved accuracy of data returned by the map, as measured by comparison to a trusted data source.
[ ] Increased usage of the map, as measured by tracking the number of unique users and the frequency of use.
[ ] Improved decision-making ability for users, as measured by feedback from users and stakeholders.

Risk & Challenges

[ ] There may be ongoing maintenance and support associated with the new filter structure, which must be taken into account.
[ ] User adoption of new features may be slow.
[ ] Changes to the user interface may confuse existing users.
[ ] Integration of new features with existing infrastructure may prove to be technically challenging.

FYI - I organized the epic. @sercanerhan @handekaratas96

@muhammetemredurmus would you guys be able to follow the acceptance criteria when you are completing tests?

@oguzergul pls update.