🐛 [firebase_analytics] Obfuscation distrubs Google Analytics screenview event

Bug report
Describe the bug
I have encountered this issue before on FirebaseCrashlytics, and I have already created discussion on both Stackoverflow & here #8163 (stackoverflow link in discussion) Obfuscated app bundle clearly does not show screen names(classnames).
I can clearly see the wanted results on Firebase DebugView.

However, I cannot see app that created in release mode.
Android (unwanted result)

iOS (wanted result)

Steps to reproduce
Steps to reproduce the behavior:

Create obfuscated app bundle in release mode for android.
Install the app to android device.
Navigate between several screen
Check Google Analytics.

Expected behavior
To be able to see screen/class names clearly.
Sample project

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
[✓] Flutter (Channel stable, 3.3.7, on macOS 13.0 22A380 darwin-arm, locale en-TR)
    • Flutter version 3.3.7 on channel stable at /Users/development/fvm/versions/3.3.7
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e99c9c7cd9 (7 days ago), 2022-11-01 16:59:00 -0700
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/development/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.67.0)
    • VS Code at /Users/development/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (1 available)
    • macOS (desktop) • macos • darwin-arm64 • macOS 13.0 22A380 darwin-arm

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.18.4
Flutter SDK 3.3.7
gain 4.1.0+222

dependencies:
- adjust_sdk 4.29.2 [flutter meta]
- audio_video_progress_bar 0.9.0 [flutter]
- auto_orientation 2.2.1 [flutter]
- auto_size_text 3.0.0 [flutter]
- better_player 0.0.83 [flutter cupertino_icons wakelock meta flutter_widget_from_html_core visibility_detector path_provider collection xml]
- cached_network_image 3.2.1 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web]
- collection 1.16.0
- connectivity_plus 2.2.2 [flutter connectivity_plus_platform_interface connectivity_plus_linux connectivity_plus_macos connectivity_plus_web connectivity_plus_windows]
- cupertino_icons 1.0.5
- dart_code_metrics 4.21.2 [analyzer analyzer_plugin ansicolor args collection crypto file glob html meta path platform pub_updater source_span xml yaml]
- device_info_plus 6.0.0 [flutter device_info_plus_platform_interface device_info_plus_macos device_info_plus_linux device_info_plus_web device_info_plus_windows]
- dio 4.0.6 [http_parser path]
- dio_cache_interceptor 3.3.0 [dio uuid string_scanner]
- envied 0.2.3
- firebase_analytics 10.0.3 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_core 2.1.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 3.0.3 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_performance 0.9.0+3 [firebase_core firebase_core_platform_interface firebase_performance_platform_interface firebase_performance_web flutter]
- firebase_remote_config 3.0.3 [firebase_core firebase_core_platform_interface firebase_remote_config_platform_interface firebase_remote_config_web flutter]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- flutter_cache_manager 3.3.0 [clock collection file flutter http path path_provider pedantic rxdart sqflite uuid]
- flutter_downloader 1.8.4 [flutter]
- flutter_local_notifications 12.0.1+1 [clock flutter flutter_local_notifications_linux flutter_local_notifications_platform_interface timezone]
- flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path vector_math]
- flutter_pip 0.0.1 [flutter flutter_web_plugins plugin_platform_interface]
- flutter_riverpod 2.0.0-dev.9 [collection flutter meta riverpod state_notifier]
- flutter_secure_storage 6.0.0 [flutter flutter_secure_storage_linux flutter_secure_storage_macos flutter_secure_storage_platform_interface flutter_secure_storage_web flutter_secure_storage_windows meta]
- flutter_svg 1.1.1+1 [flutter meta path_drawing vector_math xml]
- flutter_video_cast 1.0.3 [flutter stream_transform]
- freezed_annotation 2.2.0 [collection json_annotation meta]
- get_it 7.2.0 [async collection]
- google_fonts 3.0.1 [flutter http path_provider crypto]
- hive 2.2.3 [meta crypto]
- hive_flutter 1.1.0 [flutter hive path_provider path]
- image_picker 0.8.5+3 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_platform_interface]
- in_app_purchase 3.0.6 [flutter in_app_purchase_android in_app_purchase_platform_interface in_app_purchase_storekit]
- intl 0.17.0 [clock path]
- json_annotation 4.7.0 [meta]
- mask_text_input_formatter 2.3.0 [flutter]
- package_info_plus 2.0.0 [flutter package_info_plus_platform_interface package_info_plus_linux package_info_plus_macos package_info_plus_windows package_info_plus_web]
- path_provider 2.0.10 [flutter path_provider_android path_provider_ios path_provider_linux path_provider_macos path_provider_platform_interface path_provider_windows]
- permission_handler 10.0.0 [flutter meta permission_handler_android permission_handler_apple permission_handler_windows permission_handler_platform_interface]
- pretty_dio_logger 1.2.0-beta-1 [dio]
- provider 6.0.2 [collection flutter nested]
- retrofit 3.3.1 [dio meta]
- share_plus 5.0.0 [cross_file meta mime flutter share_plus_platform_interface share_plus_linux share_plus_macos share_plus_windows share_plus_web]
- shared_preferences 2.0.13 [flutter shared_preferences_android shared_preferences_ios shared_preferences_linux shared_preferences_macos shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- shimmer 2.0.0 [flutter]
- smooth_page_indicator 1.0.0+2 [flutter]
- store_redirect 2.0.1 [flutter]
- subtitle_wrapper_package 2.1.0 [better_player bloc equatable flutter flutter_bloc http http_parser]
- uni_links 0.5.1 [flutter uni_links_platform_interface uni_links_web]
- url_launcher 6.1.6 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- version 3.0.2
- video_player 2.2.5 [flutter meta video_player_platform_interface video_player_web html]
- wakelock 0.6.1+2 [flutter meta wakelock_macos wakelock_platform_interface wakelock_web wakelock_windows]
- webview_cookie_manager 2.0.6 [flutter]
- webview_flutter 3.0.4 [flutter webview_flutter_android webview_flutter_platform_interface webview_flutter_wkwebview]

dev dependencies:
- analyzer 5.1.0 [_fe_analyzer_shared collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- build_runner 2.3.0 [args async analyzer build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- envied_generator 0.2.3 [envied build source_gen analyzer]
- flutter_lints 2.0.1 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]
- freezed 2.2.0 [analyzer build build_config collection meta source_gen freezed_annotation json_annotation]
- hive_generator 2.0.0 [build source_gen hive analyzer source_helper]
- json_serializable 6.5.1 [analyzer async build build_config collection json_annotation meta path pub_semver pubspec_parse source_gen source_helper]
- retrofit_generator 4.2.0 [analyzer build built_collection code_builder dart_style dio retrofit source_gen tuple]

transitive dependencies:
- _fe_analyzer_shared 49.0.0 [meta]
- _flutterfire_internals 1.0.7 [cloud_firestore_platform_interface cloud_firestore_web collection firebase_core firebase_core_platform_interface flutter meta]
- analyzer_plugin 0.11.2 [analyzer collection dart_style pub_semver yaml]
- ansicolor 2.0.1
- args 2.3.1
- async 2.9.0 [collection meta]
- bloc 8.1.0 [meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- build 2.3.1 [analyzer async convert crypto glob logging meta path]
- build_config 1.1.1 [checked_yaml json_annotation path pubspec_parse yaml]
- build_daemon 3.1.0 [built_collection built_value http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 2.0.10 [analyzer async build crypto graphs logging path package_config pool pub_semver stream_transform yaml]
- build_runner_core 7.2.7 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta path package_config pool timing watcher yaml]
- built_collection 5.1.1
- built_value 8.4.2 [built_collection collection fixnum meta]
- cached_network_image_platform_interface 1.0.0 [flutter flutter_cache_manager]
- cached_network_image_web 1.0.1 [flutter flutter_cache_manager cached_network_image_platform_interface]
- characters 1.2.1
- checked_yaml 2.0.1 [json_annotation source_span yaml]
- clock 1.1.1
- cloud_firestore_platform_interface 5.8.4 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 3.0.4 [_flutterfire_internals cloud_firestore_platform_interface collection firebase_core firebase_core_web flutter flutter_web_plugins js]
- code_builder 4.3.0 [built_collection built_value collection matcher meta]
- connectivity_plus_linux 1.3.1 [flutter connectivity_plus_platform_interface meta nm]
- connectivity_plus_macos 1.2.6 [connectivity_plus_platform_interface flutter]
- connectivity_plus_platform_interface 1.2.3 [flutter meta plugin_platform_interface]
- connectivity_plus_web 1.2.5 [connectivity_plus_platform_interface flutter_web_plugins flutter js]
- connectivity_plus_windows 1.2.2 [connectivity_plus_platform_interface flutter]
- convert 3.1.1 [typed_data]
- cross_file 0.3.3+2 [js meta]
- crypto 3.0.2 [typed_data]
- csslib 0.17.2 [source_span]
- dart_style 2.2.4 [analyzer args path pub_semver source_span]
- dbus 0.7.8 [args ffi meta xml]
- device_info_plus_linux 5.0.0 [device_info_plus_platform_interface file flutter meta]
- device_info_plus_macos 5.0.0 [device_info_plus_platform_interface flutter]
- device_info_plus_platform_interface 5.0.0 [flutter meta plugin_platform_interface]
- device_info_plus_web 5.0.0 [device_info_plus_platform_interface flutter_web_plugins flutter]
- device_info_plus_windows 6.0.0 [device_info_plus_platform_interface ffi flutter win32 meta]
- equatable 2.0.5 [collection meta]
- fake_async 1.3.1 [clock collection]
- ffi 2.0.1
- file 6.1.4 [meta path]
- firebase 9.0.3 [http http_parser js]
- firebase_analytics_platform_interface 3.3.12 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_analytics_web 0.5.1+3 [_flutterfire_internals firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- firebase_core_platform_interface 4.5.2 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.0.1 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_crashlytics_platform_interface 3.3.5 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_performance_platform_interface 0.1.1+24 [_flutterfire_internals firebase_core flutter plugin_platform_interface]
- firebase_performance_web 0.1.1+13 [_flutterfire_internals firebase firebase_core firebase_core_web firebase_performance_platform_interface flutter flutter_web_plugins js]
- firebase_remote_config_platform_interface 1.1.24 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_remote_config_web 1.1.13 [firebase_core firebase_core_web firebase_remote_config_platform_interface flutter flutter_web_plugins js]
- fixnum 1.0.1
- flutter_bloc 8.1.1 [flutter bloc provider]
- flutter_blurhash 0.7.0 [flutter]
- flutter_local_notifications_linux 2.0.0 [flutter flutter_local_notifications_platform_interface dbus path xdg_directories]
- flutter_local_notifications_platform_interface 6.0.0 [flutter plugin_platform_interface]
- flutter_plugin_android_lifecycle 2.0.7 [flutter]
- flutter_secure_storage_linux 1.1.1 [flutter flutter_secure_storage_platform_interface]
- flutter_secure_storage_macos 1.1.1 [flutter flutter_secure_storage_platform_interface]
- flutter_secure_storage_platform_interface 1.0.0 [flutter plugin_platform_interface]
- flutter_secure_storage_web 1.0.2 [flutter flutter_web_plugins flutter_secure_storage_platform_interface js]
- flutter_secure_storage_windows 1.1.2 [flutter flutter_secure_storage_platform_interface]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
- flutter_widget_from_html_core 0.8.5+3 [csslib flutter fwfh_text_style html]
- frontend_server_client 2.1.3 [async path]
- fwfh_text_style 2.22.08+1 [flutter]
- glob 2.1.0 [async collection file path string_scanner]
- graphs 2.2.0 [collection]
- html 0.15.1 [csslib source_span]
- http 0.13.5 [async http_parser meta path]
- http_multi_server 3.2.1 [async]
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- image_picker_android 0.8.5+3 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- image_picker_for_web 2.1.10 [flutter flutter_web_plugins image_picker_platform_interface]
- image_picker_ios 0.8.6+1 [flutter image_picker_platform_interface]
- image_picker_platform_interface 2.6.2 [cross_file flutter http plugin_platform_interface]
- in_app_purchase_android 0.2.3+6 [collection flutter in_app_purchase_platform_interface json_annotation]
- in_app_purchase_platform_interface 1.3.2 [flutter plugin_platform_interface]
- in_app_purchase_storekit 0.3.3 [collection flutter in_app_purchase_platform_interface json_annotation]
- io 1.0.3 [meta path string_scanner]
- js 0.6.4
- lints 2.0.1
- logging 1.1.0
- matcher 0.12.12 [stack_trace]
- material_color_utilities 0.1.5
- meta 1.8.0
- mime 1.0.2
- nested 1.0.0 [flutter]
- nm 0.5.0 [dbus]
- octo_image 1.0.2 [flutter flutter_blurhash]
- package_config 2.1.0 [path]
- package_info_plus_linux 2.0.0 [package_info_plus_platform_interface flutter path]
- package_info_plus_macos 2.0.0 [flutter]
- package_info_plus_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- package_info_plus_web 2.0.0 [flutter flutter_web_plugins http meta package_info_plus_platform_interface]
- package_info_plus_windows 3.0.0 [package_info_plus_platform_interface ffi flutter win32]
- path 1.8.2
- path_drawing 1.0.1 [vector_math meta path_parsing flutter]
- path_parsing 1.0.1 [vector_math meta]
- path_provider_android 2.0.21 [flutter path_provider_platform_interface]
- path_provider_ios 2.0.11 [flutter path_provider_platform_interface]
- path_provider_linux 2.1.7 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_macos 2.0.6 [flutter path_provider_platform_interface]
- path_provider_platform_interface 2.0.5 [flutter platform plugin_platform_interface]
- path_provider_windows 2.1.3 [ffi flutter path path_provider_platform_interface win32]
- pedantic 1.11.1
- permission_handler_android 10.2.0 [flutter permission_handler_platform_interface]
- permission_handler_apple 9.0.7 [flutter permission_handler_platform_interface]
- permission_handler_platform_interface 3.9.0 [flutter meta plugin_platform_interface]
- permission_handler_windows 0.1.2 [flutter permission_handler_platform_interface]
- petitparser 5.1.0 [meta]
- platform 3.1.0
- plugin_platform_interface 2.1.3 [meta]
- pool 1.5.1 [async stack_trace]
- process 4.2.4 [file path platform]
- pub_semver 2.1.2 [collection meta]
- pub_updater 0.2.2 [http json_annotation process]
- pubspec_parse 1.2.1 [checked_yaml collection json_annotation pub_semver yaml]
- riverpod 2.0.0-dev.9 [collection meta stack_trace state_notifier]
- rxdart 0.27.5
- share_plus_linux 3.0.1 [cross_file share_plus_platform_interface file flutter meta url_launcher]
- share_plus_macos 3.0.1 [share_plus_platform_interface flutter]
- share_plus_platform_interface 3.1.2 [cross_file flutter meta mime plugin_platform_interface]
- share_plus_web 3.1.0 [cross_file share_plus_platform_interface url_launcher flutter flutter_web_plugins meta mime]
- share_plus_windows 4.0.0 [cross_file share_plus_platform_interface flutter meta url_launcher ffi win32]
- shared_preferences_android 2.0.14 [flutter shared_preferences_platform_interface]
- shared_preferences_ios 2.1.1 [flutter shared_preferences_platform_interface]
- shared_preferences_linux 2.1.1 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface]
- shared_preferences_macos 2.0.4 [flutter shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.1.0 [flutter plugin_platform_interface]
- shared_preferences_web 2.0.4 [flutter flutter_web_plugins shared_preferences_platform_interface]
- shared_preferences_windows 2.1.1 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- shelf 1.4.0 [async collection http_parser path stack_trace stream_channel]
- shelf_web_socket 1.0.3 [shelf stream_channel web_socket_channel]
- sky_engine 0.0.99
- source_gen 1.2.6 [analyzer async build dart_style glob meta path source_span yaml]
- source_helper 1.3.3 [analyzer collection source_gen]
- source_span 1.9.0 [collection path term_glyph]
- sqflite 2.2.0+3 [flutter sqflite_common path]
- sqflite_common 2.4.0+2 [synchronized path meta]
- stack_trace 1.10.0 [path]
- state_notifier 0.7.2+1 [meta]
- stream_channel 2.1.0 [async]
- stream_transform 2.1.0
- string_scanner 1.1.1 [source_span]
- synchronized 3.0.0+3
- term_glyph 1.2.1
- test_api 0.4.12 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- timezone 0.9.0 [path]
- timing 1.0.0 [json_annotation]
- tuple 2.0.1
- typed_data 1.3.1 [collection]
- uni_links_platform_interface 1.0.0 [flutter plugin_platform_interface]
- uni_links_web 0.1.0 [flutter flutter_web_plugins uni_links_platform_interface]
- url_launcher_android 6.0.21 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.0.17 [flutter url_launcher_platform_interface]
- url_launcher_linux 3.0.1 [flutter url_launcher_platform_interface]
- url_launcher_macos 3.0.1 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.1.1 [flutter plugin_platform_interface]
- url_launcher_web 2.0.13 [flutter flutter_web_plugins url_launcher_platform_interface]
- url_launcher_windows 3.0.1 [flutter url_launcher_platform_interface]
- uuid 3.0.6 [crypto]
- vector_math 2.1.2
- video_player_platform_interface 4.2.0 [flutter flutter_test meta]
- video_player_web 2.0.12 [flutter flutter_web_plugins video_player_platform_interface]
- visibility_detector 0.3.3 [flutter]
- wakelock_macos 0.4.0 [flutter flutter_web_plugins wakelock_platform_interface]
- wakelock_platform_interface 0.3.0 [flutter meta]
- wakelock_web 0.4.0 [flutter flutter_web_plugins js wakelock_platform_interface]
- wakelock_windows 0.2.0 [flutter wakelock_platform_interface win32]
- watcher 1.0.2 [async path]
- web_socket_channel 2.2.0 [async crypto stream_channel]
- webview_flutter_android 2.10.4 [flutter webview_flutter_platform_interface]
- webview_flutter_platform_interface 1.9.5 [flutter meta plugin_platform_interface]
- webview_flutter_wkwebview 2.9.5 [flutter path webview_flutter_platform_interface]
- win32 2.7.0 [ffi]
- xdg_directories 0.2.0+2 [meta path process]
- xml 6.1.0 [collection meta petitparser]
- yaml 3.1.1 [collection source_span string_scanner]

@darshankawar @russellwheatley any news on this topic?

@darshankawar @russellwheatley hey guys, yestarday, I saw this link & solved our crashlytic issue. Will this solution also solve our analytic issue as well?

@darshankawar @russellwheatley any news?

Hello, sorry for the very late reply. I believe this has now been fixed. Feel free to open a new issue if this is not the case using the latest versions.


Inline completions conflict between brace completion and undo operations

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.72
OS Version: Windows 11

For brace completion to work properly, I have to return the entire line as inlineCompletionItem.insertText. So if the buffer is b = tf.Variable( and the prediction is Variable(tf.Constant()), I need to return b = tf.Variable(tf.Constant()) as the insertText.
If I return just tf.Constant()) as the insertText, the last closing bracket gets removed by brace completion.
However, doing this introduces a bug with the undo operation. The Undo stack adds the entire insertText to the top so when I undo, it deletes the entire line. Here is a GIF

Do y'all have any advice on how to navigate this? Some questions -

The TextEditor.insertSnippet function has an option to add undoStopBefore and undoStopAfter, is that something that can be added to SnippetString insertText?

cc @hediet

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.72.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

This bug has been fixed in the latest release of VS Code Insiders!
@juihanamshet1, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version c3eebaead9d3bf1cb961b91fca1b8af31990d328 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!


[TypeReconstruction] Handle InOutType when reconstructing elements.

Before, we were just ignoring it, and this resulted in the type
being reconstructed incorrectly when assertion were disabled, and
in an assertion firing otherwise (AST invariants being broken).
rdar://problem/39248252

@swift-ci please nominate
Explanation: Incorrect type reconstruction for InOutType(s) causes a crash in the debugger when trying to reconstruct them (as they violate an AST invariant).
Scope: Only lldb goes through this path (modulo test utilities), so only the debugger is affected.
Radar (and possibly SR Issue): rdar://problem/39915946
Risk: Low. The fix is self-contained and obvious enough (handles a case that wasn't handled before). This also fixes several crashes seen in the wild (the type we're trying to mangle comes from a "real" .dSYM).
Testing: Testing has been done in CI and locally

@swift-ci please test

Note that this has been reviewed by Slava here: https://github.com/apple/swift/pull/16611


Add (UKVI) AB testing setup for September 2016 session

This commit sets up AB test for the following ukvi page sections:

/eea-registration-certificate/apply
/eea-registration-certificate/permanent-residence

Cohorts across the aforementioned ukvi pages section fall under the following.

original (with a 90% weighting)
applyTextAndLink (with a 10% weighting)

The isSection checks that the current path matches the the given path that has
been defined for A/B testing.
It basically does an (string based) equality check.
The AddtoApplySection and AddtoPermanentResidenceSection function inserts
the given html before the respectively identified html tags.
Factcheck for Apply
Before

After

Factcheck for Perm. Residence
Before

After

NB: Factcheck was carried out on integration after deploying just this branch.

@nickcolley I've checked your review comments have been addressed. This looks good to me.

In the past we have tended to insert templated html from <script> blocks rather than writing them out in js. This approach was arbitrarily dependent on how much html needs inserting and in this case it's pretty marginal. So I'm happy to merge.


[Bug]: Cant deploy nextjs app

Error Message and Logs
Im getting this error while installing any package fom npmjs, im using pnpm with nixpack, for example:
#11 64.81  WARN  GET https://registry.npmjs.org/oauth4webapi/-/oauth4webapi-3.1.2.tgz error (ERR_SOCKET_TIMEOUT). Will retry in 10 seconds. 2 retries left.
And after 3 retry
#11 255.3  ERR_SOCKET_TIMEOUT  request to https://registry.npmjs.org/oauth4webapi/-/oauth4webapi-3.1.2.tgz failed, reason: Socket timeout
#11 255.3
#11 255.3 FetchError: request to https://registry.npmjs.org/oauth4webapi/-/oauth4webapi-3.1.2.tgz failed, reason: Socket timeout
#11 255.3     at ClientRequest.<anonymous> (/nix/store/lx2wfmprgj37h58nv3zry2wya37xlgm1-pnpm/dist/pnpm.cjs:66954:18)
#11 255.3     at ClientRequest.emit (node:events:517:28)
#11 255.3     at TLSSocket.socketErrorListener (node:_http_client:501:9)
#11 255.3     at TLSSocket.emit (node:events:529:35)
#11 255.3     at emitErrorNT (node:internal/streams/destroy:151:8)
#11 255.3     at emitErrorCloseNT (node:internal/streams/destroy:116:3)
#11 255.3     at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
#11 ERROR: process "/bin/bash -ol pipefail -c pnpm install" did not complete successfully: exit code: 1
------
 > [ 7/11] RUN  pnpm install:
255.3  ERR_SOCKET_TIMEOUT  request to https://registry.npmjs.org/oauth4webapi/-/oauth4webapi-3.1.2.tgz failed, reason: Socket timeout
255.3
255.3 FetchError: request to https://registry.npmjs.org/oauth4webapi/-/oauth4webapi-3.1.2.tgz failed, reason: Socket timeout
255.3     at ClientRequest.<anonymous> (/nix/store/lx2wfmprgj37h58nv3zry2wya37xlgm1-pnpm/dist/pnpm.cjs:66954:18)
255.3     at ClientRequest.emit (node:events:517:28)
255.3     at TLSSocket.socketErrorListener (node:_http_client:501:9)
255.3     at TLSSocket.emit (node:events:529:35)
255.3     at emitErrorNT (node:internal/streams/destroy:151:8)
255.3     at emitErrorCloseNT (node:internal/streams/destroy:116:3)
255.3     at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
------
Dockerfile:20
--------------------
  18 |     ENV NIXPACKS_PATH=/app/node_modules/.bin:$NIXPACKS_PATH
  19 |     COPY . /app/.
  20 | >>> RUN  pnpm install
  21 |
  22 |     # build phase
--------------------
ERROR: failed to solve: process "/bin/bash -ol pipefail -c pnpm install" did not complete successfully: exit code: 1
Deployment failed. Removing the new version of your application.

I have tried with other projects and same issue. Im using as "Install Command" pnpm install
Steps to Reproduce

Build any nextjs app from github repository
Use pnpm install as install command

Example Repository URL
No response
Coolify Version
v4.0.0-beta.379
Are you using Coolify Cloud?
No (self-hosted)
Operating System and Version (self-hosted)
Ubuntu 24.04 LTS
Additional Information
Before migrating from an old server all was working fine with same settings, but when I migrate all and try to deploy this problem has begin

Now works fine, it seems like it was a temporary bug.


spotdl v3.2.0rc0 don't work

I've got this error message when i try spotdl $songurl
Fetching Song...   0%|                                                                                |ETA: ?, ~min/songTraceback (most recent call last):   File "C:\Users\Black4Killer\Desktop\PYTHONIK\Scripts\spotdl-script.py", line 33, in <module>     sys.exit(load_entry_point('spotdl==3.2.0rc0', 'console_scripts', 'spotdl')())   File "c:\users\black4killer\desktop\pythonik\lib\site-packages\spotdl\__main__.py", line 88, in console_entry_point     downloader.download_single_song(song)   File "c:\users\black4killer\desktop\pythonik\lib\site-packages\spotdl\download\downloader.py", line 283, in download_single_song     download_song(songObj, self.displayManager, self.downloadTracker)   File "c:\users\black4killer\desktop\pythonik\lib\site-packages\spotdl\download\downloader.py", line 103, in download_song     youtubeHandler = YouTube(   File "c:\users\black4killer\desktop\pythonik\lib\site-packages\pytube\__main__.py", line 103, in __init__     self.descramble()   File "c:\users\black4killer\desktop\pythonik\lib\site-packages\spotdl\patches\pyTube.py", line 149, in descramble     self.player_config_args = get_ytplayer_config(self.watch_html)["args"]   File "c:\users\black4killer\desktop\pythonik\lib\site-packages\spotdl\patches\pyTube.py", line 241, in get_ytplayer_config     raise RegexMatchError( NameError: name 'RegexMatchError' is not defined   0%|                                                                                |ETA: ?, ~min/song

I have the newest ffmpeg installed and it works, but the script doesn't work with any track what am I doing wrong? I don't have something installed yet?, are I missing any libraries to install?

Same issue is faced by me too..  PLS TAKE A LOOK INTO THIS

3.2 is WIP. It isn't necessarily functionality all the time.


PositionRewardClaim implementation

We can safely defer this out into the future, since we haven't designed the reward claim mechanism yet.

Closing this entirely because we have no design or plan as yet.


Webhook ownerRef may cause issues with istiod

See https://github.com/istio/istio/pull/19476/files#r356298037
We are explicitly looking for an "istio-galley" cluster role to set the owner ref to. This means we still need this role with istiod
Seems like we may want to stop generating the webhook in galley entirely as the real fix though.. the operator should manage the lifecycle, which I believe is being worked on.
cc @morvencao @costinm

Galley and istio no longer create the webhook config anymore. We also don't use ownerRef for cleanup. No trickery. The config is in the charts like all of our other config.


Sometimes cannot switch to VSCode window in fullscreen mode (Zen mode) on Windows 10 (use Alt+Tab)

VSCode Version: Code 1.13.0 (376c52b955428d205459bea6619fc161fc8faacf, 2017-06-08T16:43:13.058Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author
Version

theme-monokai-dark-soda
AdamCaviness
0.0.5

maxscript
AndrewMcWhae
0.0.2

vscode-color
anseki
0.4.1

theme-material
bcmarinacci
1.3.0

theme-atom-one-dark
freebroccolo
0.0.1

Theme-Cobalt
gerane
0.0.2

Theme-CoffeeDarkRoast
gerane
0.0.2

Theme-DarkKrystal
gerane
0.0.2

Theme-Monokai-Cobalt
gerane
0.0.3

Theme-TomorrowNightBlue
gerane
0.0.2

Theme-VibrantInk
gerane
0.0.2

autofilename
JerryHong
0.1.3

theme-material-theme
jprestidge
1.0.1

cobalt2-Theme
kamranmackey
0.0.3

ftp-sync
lukasz-wronski
0.3.3

Theme-TomorrowKit
ms-vscode
0.1.4

theme-earlytobed
PasqNet
0.0.4

material-icon-theme
PKief
2.0.9

git-common-commands-suite
samschneller
0.2.2

theme-cobalt0
sharksym
0.0.5

Steps to Reproduce:

Run VSCode in Zen mode
Switch to another application
on tasks switch popup there is no VSCode window.

Another case:

Run several VSCode windows
Switch to Zen mode in one of these windows.
Switch to VSCode in windowed mode (Alt+Tab)
Try to switch to VSCode in Zen mode (Alt+Tab), and you cannot see it in tasks list and cannot switch, only on taskbar. This happens not always but often.

Can you also reproduce this with:

Going into full screen VSCode
With a barebone electron full screen aplication
When you go fullscreen in Chrome?

Only when try to switch to fullscreen VSCode. Switching to windowed VSCode - normal.
I have no electron application, except of VSCode
Yes, when I have 2 or more Chrome windows, I cannot switch to fullscreen Chrome from windowed Chrome

Due to 3 this issue is an upstream issuue with chrome, since we depend on electron which uses chrome undearneath.
It would be best to report this issue against chrome


Fixing the FileSystemOutputCache feature

Caching keys for filenames to prevent too long paths
Separating metadata from content storage to optimize some scenarios
Fixing retry logic

@sebastienros why did you close this!?

Can't remember. If you want an answer try to find the meeting recording right before this was closed maybe. We must have talked about the changeset in the status.


"Access blocked: Nest’s request is invalid" on a new installation

The problem
I've just downloaded the integration for the first time, and when trying to install it on my HA instance I click on the provide "authorize your account" link:

Before I enter any details, I get this error:

The same error appears if I open the "authorize your account" link in incognito mode.
The additional error details:

Which includes a link to this documentation: https://developers.google.com/identity/protocols/oauth2/resources/oob-migration
What version of this integration (ha-nest-protect) has the issue?
0.3.12
What version of Home Assistant Core has the issue?
2024.1.5
Device / Model
No response
Diagnostics information
No response
Home Assistant log
No response
Additional information
No response

Sorry - I've just seen https://github.com/iMicknl/ha-nest-protect/issues/105


<EMAIL_ADDRESS>

错误: 无法将类 BindingRecyclerViewAdapters中的方法 setAdapter应用到给定类型;
需要: RecyclerView,ItemBinding<? super T>,List,BindingRecyclerViewAdapter,ItemIds<? super T>,ViewHolderFactory,AsyncDifferConfig
找到: RecyclerView,ItemBinding,ObservableList,ContactAdapter,ItemIds,ViewHolderFactory,AsyncDifferConfig
原因: 推论变量 T 具有不兼容的限制范围
等式约束条件: CompanyInfo,ContactItemViewModel
上限: ContactItemViewModel,Object
其中, T是类型变量:
T扩展已在方法 setAdapter(RecyclerView,ItemBinding<? super T>,List,BindingRecyclerViewAdapter,ItemIds<? super T>,ViewHolderFactory,AsyncDifferConfig)中声明的Object

Thank you for reporting your issue. In order to look into it, can you please provide a sample project and clear steps to reproduce?

Thank you for reporting your issue. In order to look into it, can you please provide a sample project and clear steps to reproduce?

android.build.gradle version 3.5.3
and setAdapter in Activity/Fragment（not in ViewModel）, This is different from the sample code

Thank you for reporting your issue. In order to look into it, can you please provide a sample project and clear steps to reproduce?

If I define the adapter in the ViewModel like the simple code, there is no problem, But I don't know if this code will cause a memory leak?

build.gradle Modify upgrade in file：
classpath 'com.android.tools.build:gradle:3.6.3'

gradle-wrapper.properties Modify upgrade in file：
distributionUrl=https://services.gradle.org/distributions/gradle-5.6.4-all.zip

The following questions will appear：
E:\Android\AndroidStudioProjects\MVVMHabit-master\app\build\generated\ap_generated_sources\debug\out\com\goldze\mvvmhabit\databinding\FragmentNetworkBindingImpl.java:158: 错误: 无法将类 BindingRecyclerViewAdapters中的方法 setAdapter应用到给定类型;
me.tatarka.bindingcollectionadapter2.BindingRecyclerViewAdapters.setAdapter(this.mboundView2, viewModelItemBinding, viewModelObservableList, adapter, (me.tatarka.bindingcollectionadapter2.BindingRecyclerViewAdapter.ItemIds)null, (me.tatarka.bindingcollectionadapter2.BindingRecyclerViewAdapter.ViewHolderFactory)null);
^
需要: RecyclerView,ItemBinding,List,BindingRecyclerViewAdapter,ItemIds<? super T>,ViewHolderFactory
找到: RecyclerView,ItemBinding,ObservableList,BindingRecyclerViewAdapter<CAP#1>,ItemIds,ViewHolderFactory
原因: 推断类型不符合等式约束条件
推断: CAP#1
等式约束条件: CAP#1,NetWorkItemViewModel
其中, T是类型变量:
T扩展已在方法 setAdapter(RecyclerView,ItemBinding,List,BindingRecyclerViewAdapter,ItemIds<? super T>,ViewHolderFactory)中声明的Object
其中, CAP#1是新类型变量:

Project address in question：https://github.com/goldze/MVVMHabit  uses binding collection adapter

study

怎么解决呢

我也遇到这个问题了，如何解决？（I am met this problem too, what is the solution?）

在xml导入的类名后面加入   <Object>试试.


Allow users to specify a directory for additonal devices

Podman will search through the directory and will add any device
nodes that it finds.  If no devices are found we return an error.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

LGTM, but would like another head nod before merge

bot, retest this please

/lgtm

/approve


build: replace amd64 with GOARCH in make target 'release'

this allows to run 'make release' on an arm64 host where build output dir is out/linux-arm64 not out/linux-amd64

(I've included a patch in the rpm to generate the release builds so this is not urgent)


installation of  Restic server by sitting behind the proxy

Output of restic version
it is about installation of restic server
What are you trying to do? What problem would this solve?
I am trying to install the restic-server .
my system is behind proxy-server  so installation process is unable to resolve the links to github.com
Did restic help you today? Did it make you happy in any way?

I'm sorry, but this is not caused by restic, rest-server or similar. This seems like a local network problem on your end, and there's not much we can do about that. You simply have to fix your proxy and network so that you can properly resolve and access github.com.
On a related note, you can (once you are able to access github.com) download a rest-server binary directly from https://github.com/restic/rest-server/releases , in case you don't want to build it yourself. But I guess you do, and there's nothing wrong with that :)
I'll be closing this issue for now. For future reference, please use the restic forum when you want to ask about a usage problem. The issues here on GitHub are intended for bug reports or feature requests.


[Bug-7896][api] Fixed the problem of duplicating project names when authorizing projects

Fixed the problem of duplicating project names when authorizing projects
This closes #7896

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).
org.apache.dolphinscheduler.api.service.UsersServiceTest#testGrantProject

Codecov Report

Merging #8453 (8b6919b) into dev (234f399) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #8453      +/-   ##
============================================
- Coverage     45.35%   45.34%   -0.02%
+ Complexity     4028     4026       -2
============================================
  Files           686      686
  Lines         26702    26702
  Branches       2867     2867
============================================
- Hits          12112    12109       -3
- Misses        13448    13449       +1
- Partials       1142     1144       +2

Impacted Files
Coverage Δ

...inscheduler/api/service/impl/UsersServiceImpl.java
75.47% <100.00%> (+0.20%)
:arrow_up:

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.70% <0.00%> (-2.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 234f399...8b6919b. Read the comment docs.


ByteBuddy persistence mapping generation not working with Kotlin

Discussed in https://github.com/xmolecules/jmolecules/discussions/106

Originally posted by Alfhir November  8, 2023
Hello,
I am trying Spring Boot Modulith and jMolecules in a Kotlin project. I suspect that Bytebuddy is not doing it's magic and I don't know how to debug this. If someone could have a look at my config and help, that would be really nice!
build.gradle.kts
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

buildscript {
	repositories {
		mavenCentral()
	}
	dependencies {
		classpath(platform("org.jmolecules:jmolecules-bom:2021.1.0"))
		classpath("org.jmolecules.integrations:jmolecules-bytebuddy")
	}
}

plugins {
	id("org.springframework.boot") version "3.1.5"
	id("io.spring.dependency-management") version "1.1.3"
	id("net.bytebuddy.byte-buddy-gradle-plugin") version "1.14.9"
	kotlin("jvm") version "1.8.22"
	kotlin("plugin.spring") version "1.8.22"
	kotlin("plugin.jpa") version "1.8.22"
}

byteBuddy {
	transformation{
		plugin = org.jmolecules.bytebuddy.JMoleculesPlugin::class.java
	}
}

group = "com.example.demo"
version = "0.0.1-SNAPSHOT"

java {
	sourceCompatibility = JavaVersion.VERSION_17
}

repositories {
	mavenCentral()
}

dependencies {
        // omitted some dependencies for brevity
	implementation("org.springframework.boot:spring-boot-starter-data-jpa")
	implementation("org.jetbrains.kotlin:kotlin-reflect")
	implementation("org.springframework.modulith:spring-modulith-starter-jpa") // includes core

	implementation(platform("org.jmolecules:jmolecules-bom:2021.1.0"))
	implementation("org.jmolecules:kmolecules-ddd:1.9.0")
	implementation("org.jmolecules:jmolecules-events")
	implementation("org.jmolecules.integrations:jmolecules-spring")
	implementation("org.jmolecules.integrations:jmolecules-jpa")
	compileOnly("org.jmolecules.integrations:jmolecules-bytebuddy")
	runtimeOnly("org.postgresql:postgresql")
}

dependencyManagement {
	imports {
		mavenBom("org.springframework.modulith:spring-modulith-bom:1.0.2")
	}
}

tasks.withType<KotlinCompile> {
	kotlinOptions {
		freeCompilerArgs += "-Xjsr305=strict"
		jvmTarget = "17"
	}
}

tasks.withType<Test> {
	useJUnitPlatform()
}

and here's some code from the classes, I am trying to persist (all in internal package but the repo):
@org.jmolecules.ddd.annotation.Repository
interface Dungeons: CrudRepository<Dungeon, DungeonIdentifier>

@JvmInline
value class DungeonIdentifier(val id: UUID = UUID.randomUUID()): Identifier {
    fun of(id: UUID)  = DungeonIdentifier(id)
}

@Table(name = "dungeon")
data class Dungeon(
    override val id: DungeonIdentifier = DungeonIdentifier(),
) : AggregateRoot<Dungeon, DungeonIdentifier>

I get

Found 0 JPA repository interfaces.

and

Could not safely identify store assignment for repository candidate interface com.example.demo.dungeon.Dungeons; If you want this repository to be a JPA repository, consider annotating your entities

So that's why I suspect they're not being annotated w. the necessary JPA annotations.
What am I overseeing?

Would you mind packaging this up as a minimal buildable project? I am not a Kotlin expert but in the tickets we've got so far, the primary problem was that the project did not set up Kotlin compilation in a way that the generated class files could be found in places that standard java tooling expects them to end up`

Thanks for getting back at me so fast! I'll make a minimal buildable project asap and post the URL here.

I've set up a minmal branch, is that sufficient?

I think the core of the issue is indeed that ByteBuddy is inspecting the standard Java compiler target folder, not the Kotlin one. Traces of that can be found here:

https://github.com/raphw/byte-buddy/issues/1284
https://github.com/xmolecules/jmolecules-examples/issues/6

I'm sorry I don't have better news.

Thank you very much for investigating. I'll use Java then or see if I can come up with a custom ByteBuddyTask.

I strongly assume that any contribution making this more usable from within Gradle would be welcome by Raphael. We're just neither Gradle nor Kotlin experts.


Don't use SimpleGoodTuring as a default for NgramModel

See https://github.com/nltk/nltk/issues/602#issuecomment-34762070 for motivation. Since this change is backwards-incompatible I think it is better to fix it before NLTK 3 is released.

@stevenbird I think we can close this because the new language model module doesn't really have a "default" model and the underlying problem with SGT can be tracked in #602.


Building custom image fails on libguestfs error

I am running the builder with the minimal example on a Mac M1 and get an libguestfs error. Not sure what is causing this.
I am building the image using the following configuration:

Mac M1 Pro (Ventura)
Colima v0.6.7 (colima start --arch aarch64 --vm-type=vz --vz-rosetta)

Please let me know if any other info is needed!
# image definition file
apiVersion: 1.0
image:
  imageType: iso
  arch: x86_64
  baseImage: SLE-Micro.x86_64-5.5.0-Default-SelfInstall-GM.install.iso
  outputImageName: eib-image.iso

# Executed command after successfully building the edge builder docker image
docker run --rm -it \
  -v $IMAGE_DIR:/eib eib:dev /bin/eib \
  -config-file $CONFIG_FILE \
  -config-dir /eib \
  -build-dir /eib/_build

# console output
Building ISO Image with parameters:
IMAGE_DIR = /Users/mpas/Development/scratchpad/eib-test
CONFIG_FILE = eib-config-iso.yaml
BUILD_DIR = /Users/mpas/Development/scratchpad/eib-test/_build
Generating image customization components...
Identifier ................... [SUCCESS]
Custom Files ................. [SKIPPED]
Time ......................... [SKIPPED]
Network ...................... [SKIPPED]
Users ........................ [SKIPPED]
Proxy ........................ [SKIPPED]
Rpm .......................... [SKIPPED]
Systemd ...................... [SKIPPED]
Elemental .................... [SKIPPED]
Suma ......................... [SKIPPED]
Embedded Artifact Registry ... [SKIPPED]
Keymap ....................... [SUCCESS]
Kubernetes ................... [SKIPPED]
Certificates ................. [SKIPPED]
Building ISO image...
Kernel Params ................ [SKIPPED]
Error building ISO image, check the logs under the build directory for more information.

# raw-build.log
libguestfs: error: appliance closed the connection unexpectedly.
This usually means the libguestfs appliance crashed.
Do:
  export LIBGUESTFS_DEBUG=1 LIBGUESTFS_TRACE=1
and run the command again.  For further information, read:
  http://libguestfs.org/guestfs-faq.1.html#debugging-libguestfs
You can also run 'libguestfs-test-tool' and post the *complete* output
into a bug report or message to the libguestfs mailing list.
libguestfs: error: /usr/bin/qemu-system-aarch64 exited with error status 1.
To see full error messages you may need to enable debugging.
Do:
  export LIBGUESTFS_DEBUG=1 LIBGUESTFS_TRACE=1
and run the command again.  For further information, read:
  http://libguestfs.org/guestfs-faq.1.html#debugging-libguestfs
You can also run 'libguestfs-test-tool' and post the *complete* output
into a bug report or message to the libguestfs mailing list.
libguestfs: error: guestfs_launch failed.
This usually means the libguestfs appliance failed to start or crashed.
Do:
  export LIBGUESTFS_DEBUG=1 LIBGUESTFS_TRACE=1
and run the command again.  For further information, read:
  http://libguestfs.org/guestfs-faq.1.html#debugging-libguestfs
You can also run 'libguestfs-test-tool' and post the *complete* output
into a bug report or message to the libguestfs mailing list.

I think it maybe related to the fact eib is not supported on arm64 (yet), see https://github.com/suse-edge/edge-image-builder/issues/68
Just in case, can you run the same command with debug enabled?
Note: maybe we need to check the architecture and fail gracefully instead of letting libvirt fail 😅 /cc @jdob

Will run with debug enabled..
What I actually want to achieve is to run eib on my Arm machine and create a x64 ISO image. That is something we have been doing with previous SLE Micro versions /  setups that worked nicely.
So if there are any tips on how to achieve that, then that would be great!

Have run with debug enabled like in the linked issue.
2024-02-05T14:19:05.346Z	INFO	combustion/network.go:50	Configuring network component...
2024-02-05T14:19:05.346Z	INFO	combustion/network.go:54	Skipping network component, configuration is not provided
2024-02-05T14:19:05.346Z	INFO	combustion/rpm.go:32	Skipping RPM component. Configuration is not provided
2024-02-05T14:19:05.346Z	INFO	combustion/elemental.go:29	Skipping elemental registration component, configuration is not provided
2024-02-05T14:19:05.347Z	INFO	combustion/certificates.go:28	skipping certificate configuration, no certificates provided
2024-02-05T14:19:24.390Z	FATAL	eib/main.go:96	An error occurred building the image: modifying the raw image inside of the ISO: running the image modification script: exit status 1
main.main
	/src/cmd/eib/main.go:96
runtime.main
	/usr/lib64/go/1.21/src/runtime/proc.go:267

Related to the message that Could not access KVM kernel module: No such file or directory. I tried setting the option LIBGUESTFS_BACKEND_SETTINGS=force_tcg inside the modify-raw-image.sh.tpl. But this gives another error..
I found this option reading the thread below.
<EMAIL_ADDRESS>

Thanks for the interest in this. Unfortunately, the initial release will not support aarch64 but we're definitely looking into introducing it at a later point.

Closing as a duplicate of the feature request for aarch #193


Fix single dataset openapi specs (API docs)

This fixes FastAPI's generated API docs in the case where a single dataset is published. The dataset_id parameter is not shown anymore.
The fix is based on FastAPI docs: https://fastapi.tiangolo.com/advanced/extending-openapi/. I had to do some tricks to support a bunch of changes in last FastAPI versions, though. Hopefully it won't change too often in the future.
This fix won't be needed anymore if it is addressed upstream (see https://github.com/tiangolo/fastapi/issues/1594).

Given that we support only the latest version of Xarray (https://github.com/xarray-contrib/xpublish/pull/42#discussion_r467980591), should we also support only lasts versions of fastapi?
If yes, I'm happy to remove the compatibility code in this PR.

@benbovy - yes, let's bump minimum versions to make things less complicated at this point. I think we'll start to stabilize after this next release but for now, I'm happy to stick with fairly recent versions.

It's ready to be reviewed and/or merged.


Add AlertManager configuration

https://trello.com/c/pOfajLA2/980-install-kube-prometheus-stack-chart-via-argo-cd-instead-of-terraform

Approach lgtm! I just skimmed the template stuff (since a fair bit of it is preexisting cruft anyway right, like those duplicated receiver configs).


One proof per block including all transactions

At the moment we are only proving one tx per block. We need to proof each transaction and with this recursively proof the block

Blocked by missing recursion in lambdaworks prover


chore(master): release 2.7.8

:robot: I have created a release beep boop
2.7.8 (2024-11-16)
Dependencies

deps: update davidanson/markdownlint-cli2-action action to v18 (#62) (18dbf43)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.7.8
:sunflower:


Suggestion: Hash filter contents as the filterId (or add a filterAlias property)

Suggestion
Filters created via POST /_matrix/client/v3/user/{userId}/filter are difficult to manage because their resulting ID is generated dynamically on upload from the client. This forces clients to use computed IDs obtained by uploading each filter's full JSON definition to the home-server on startup. By switching to hashes, filter IDs could be computed independently and referenced statically in config files. Moreover, this lays the groundwork for a separate service that fresh clients can use to verify filters exist before sending full JSON definition.

Is it that much of a burden for clients to upload the filter?  If we switch to using hashes, then clients would need to

compute the hash for the filter (which, probably means computing the Canonical JSON and then throwing it through SHA256 or something)
query whether the server has that filter already
if not, upload the filter

which seems to me like more effort than just blindly uploading the filter.

Perhaps effort is the wrong way to look at it, and here's why.
Hashes provide significantly more utility over generated IDs. With hashing, clients that want to continue blindly uploading filters can do so without interruption. Nothing changes for them. On the other hand, clients that have a large number of pre-defined filters alongside bandwidth / network availability concerns absolutely need a way to avoid uploading large JSON documents. This will require hashes. Additionally, hashes can be pre-computed during build processes and extracted into a separate constants definitions file, which can be very helpful for automation and testing purposes.
Now, I do admit this conversation mostly applies to filters that configure static values, like limits or event types, but looking out at the near future, it's a reasonable expectation that we'll eventually need a way to specify template parameters too. For example, I might want to use 90% of a filter's configuration, but pass a handful of room ids dynamically when I make the /sync request. E.g. set not_rooms to something like ['$not_rooms'] and query /sync with ?fp_not_rooms=1,2,3.


Use a popup theme to style the picker on Android

cc @shawnborton for style approval
Details
This PR introduces a popup theme for styling the picker background on Android.  After some recent findings, I believe we should reopen the styling discussion.
In the issue thread, we agreed on using a theme that more closely matches the modals.  As part of that discussion @shawnborton mentioned using a border. After further testing, I have identified a minor problem related to borders on a popup theme.  When scrolling, the items overlap the border.  Unfortunately this is not fixable through styling, but would require modifying the Picker source directly and adding ViewGroup.clipToPadding(true) which is not feasible.
This problem can be identified in the following video:

Border overlap issue

These examples are from a demo app where I could quickly iterate changes, which is why the items are not ones used in our app.  This demonstration of the overlap issue uses a 6dp border:
https://user-images.githubusercontent.com/1311325/226196349-bec0b1a5-38b3-48b4-a975-1b19c098e771.mp4

There are a couple ways we could approach this. Since the modals in the app themselves do not use a border, I think we could get away without them. I think it looks great with just the font, card background color, and border radius, and it also solves the issue:

Popup theme without border

Another idea would be to use a thinner border which would make the overlap less obvious.  Here are a couple examples of how it would look with narrower border widths:

Popup theme (2dp border)

Popup theme (4dp border)

Since having no border solves the issue and looks really good, I have included that version in this PR.  If @shawnborton decides we should include the border despite the overlap issue, I can quickly add a commit for that.
Fixed Issues

$ https://github.com/Expensify/App/issues/15460
PROPOSAL: https://github.com/Expensify/App/issues/15460#issuecomment-1444500449
Tests

Picker Test

Launch the Android native app
Log in and navigate to a screen containing a picker
Open the picker and confirm that the picker has a green background
Confirm the picker has a border radius
Confirm the items are displayed with a white text color, in the Expensify Neue font.
Suggested: Run the app on a physical device to confirm the same functionality.

Example pickers used for testing:

Workspace > General Settings > Default currency
Workspace > Reimburse Expenses > Track Distance Unit
Workspace > Personal Details > Home Address > Country

DatePicker Test

Launch the Android native app
Log in and navigate to a screen containing a DatePicker
Open the datepicker and confirm the style matches the Android native screenshots in the PR.
Suggested: Run the app on a physical device to confirm the same functionality.

Date picker used for testing:

Workspace > Connect Bank Account > Connect Manually > Step 2 > Incorporation Date

Alert Test

Launch the Android native app
Log in and navigate to a screen that triggers an alert
Trigger the alert and confirm the style matches the Android native screenshots in the PR.
Suggested: Run the app on a physical device to confirm the same functionality.

Alerts used for testing:

Profile > Upload Profile Image > Deny Camera Access

Workspace > Upload Workspace Image > Deny Camera Access

Report > Download Attachment > Success

[X] Verify that no errors appear in the JS console

Offline tests

QA Steps

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screencast from 2023-03-19 11:30:39 AM.webm

Mobile Web - Chrome
https://user-images.githubusercontent.com/1311325/226198823-2f7f3c70-5604-497d-b928-0d49e8fafb63.mp4

Mobile Web - Safari
https://user-images.githubusercontent.com/1311325/226198838-4a2491db-5dcd-4171-be25-30b30541ab80.mp4

Desktop
https://user-images.githubusercontent.com/1311325/226198847-216ca91a-310e-458f-9cba-dfd1dadb9ddd.mov

iOS
https://user-images.githubusercontent.com/1311325/226198858-9a3ecdad-2302-4dd8-8063-399d151a9cb6.mov

Android
Picker

DatePicker

Alert

@chiragsalian @sobitneupane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

I think it looks pretty good without the border, so that works for me.

Do we have control over the color used to highlight the day, as well as "Cancel" below? If so, let's use green.

@shawnborton Does this work?

Screenshot

Commit for the recommended accent color is pushed.

One more case:

@sobitneupane Requested changes completed.
@situchan That case has been accounted for.

@redstar504 great! I meant to add in test steps 🙂

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@redstar504 @jsamr  we need to QA this?

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.2.89-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.89-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


VIZ, BUG: fix plot compare evokeds with list/tuple input when evoked comments not unique

closes #8588
For the record this was introduced in #8054.

@aaronjnewman are you able to confirm this fix by testing on your data with this PR branch?  (something like pip install git+https://github.com/drammock/mne-python.git@fix-plot-compare-evokeds should do it...

The last plot in this tutorial section demonstrates the new behavior.

@drammock yes, it works now. Two lines are plotted for two inputs, and the (identical) comments for each input are shown in the legend.
Thank you!

rebased & force-pushed, hopefully Azure CIs will be green now

Thanks @drammock


No routing between correlation jboss applications

I have two jboss applications A and B , A invoke B by cxf ,but no routing between A and B .A and B is independent.

Please post according to this template with as much detail as possible.


Problems with Safari and stack

I can't get tablesaw stack mode working in Safari.
It's really weird because I've taken all possible script/css that could interfere with this and it's still not working.
Is anyone else having this problem with the current version 2.0.3 ?
First screenshot below shows the two screens side by side (left is safari, right is chrome). Second is both screens when tablesaw "stacks". See how Safari is still showing a single table of rows instead of showing a separate table for each row (visually, I know that literally).

Would be grateful if anyone could confirm whether this is a bug or not and/or if you've seen it before how did you mitigate it???
Regards,
Tim

Testing this out I found that it seemed to work ok with a part of the same file when declaring the doctype (it wasn't previously declaring this).
Is anyone able to confirm that this makes sense, i.e. without doctype declaration jQuery possibly wasn't working as it should have been?
Tried with latest version of jQuery as well as 1.11.3 (which is what currently is used on this page) and seemed to work ok ???
Tim


[#2291] Publish button update

If the resource is not Public the Publish button is now hidden.
If the resource is Public, but the profile is incomplete, the button is grayed out and a helpful message is shown when hovered over.

Title field in Profile page is now a required field.
Minor profile page style adjustments

This code is ready for review now.

We still need to decide. We can leave the implementation like this, or we can change the tooltip to a popover with a message and link to the Profile page.
I vote for leaving this implementation as is because we already have a message that shows up to users with incomplete Profile information on page load prompting them to fill in the missing information.

@dtarb See Mauriel's comment. Cool with you?

If the current decision is to go with

then I like it.
I did note in the comments above "Title field in Profile page is now a required field".  Sorry for there to be reneging on this, but in a side discussion with @martinseul and @aphelionz we decided a few days ago that Title did not need to be a required field.

In that case should we be removing the field from the prompt message as well?

@Maurier Sure, go ahead. We will be removing that nag message soon enough anyway. Might as well be consistent in the meantime.

Build finished.


High CPU usage and latency on aarch64 ARMV8 build

Hello, I am running into high latency and constant high CPU  usage (80-95% ) when running a ARMv8 build on my Samsung Note 10. To test bench this I am running various matrix unit tests. The armv7 build runs fast and shows moderate CPU usage when compared to this armv8 build so I am wondering if I am missing a certain configuration during build. Below are benchmarks to compare the armv8 and armeabi-v7a builds running the exact same code. My best guess on the high CPU usage is some thread locking issue for some reason, though I don't have anything substantial to back that up.
BUILD INSTRUCTIONS I USED:
ARMV8 build (android-ndk-r18b-2022) (version 0.3.27.dev)
make TARGET=ARMV8
CC=$TOOLCHAIN_BIN/aarch64-linux-android-gcc
AR=$TOOLCHAIN_BIN/aarch64-linux-android-ar
FC=$TOOLCHAIN_BIN/aarch64-linux-android-gfortran
HOSTCC=gcc
-j4
(I have tried building with no threads / threads/ affinity on,off / locking / lots of threads / 1 thread) (these are defined in the Makefile.rule file, no difference here on CPU usage)
=================================================================
armeabi-v7a build (android-ndk-r14b) (version 0.3.0.dev)
make HOSTCC=gcc
CC="$COMPILERDIR/arm-linux-androideabi-gcc --sysroot=$SYSROOT"
FC="$COMPILERDIR/arm-linux-androideabi-gfortran --sysroot=$SYSROOT"
TARGET=ARMV7
CROSS_SUFFIX=$COMPILERDIR/arm-linux-androideabi-gcc-
FCOMMON_OPT=-frecursive
ARM_SOFTFP_ABI=1 \
=================================================================
BENCHMARKS (Bolded are some tests that differ wildly between 64 and 32 bit builds)
attached are android studio profile snippets showing that CPU usage is so much higher on the ARMv8 64bit builds)
ARMv8
64 bit
UnitTestRealFftSpeed,float,512,0.126857,seconds
UnitTestSplitRadixRealFftSpeed,float,512,0.0719979,seconds
UnitTestSvdSpeed,float,4,39.363,seconds
UnitTestAddMatMatSpeed,float,2,1.87856,seconds
UnitTestAddRowSumMatSpeed,float,5,0.228737,seconds
UnitTestAddColSumMatSpeed,float,5,0.30996,seconds
UnitTestAddVecToRowsSpeed,float,5,0.221573,seconds
UnitTestAddVecToColsSpeed,float,5,0.259116,seconds
UnitTestRealFftSpeed,double,512,0.140171,seconds
UnitTestSplitRadixRealFftSpeed,double,512,0.098691,seconds
UnitTestSvdSpeed,double,4,32.5623,seconds
UnitTestAddMatMatSpeed,double,2,4.06978,seconds
UnitTestAddRowSumMatSpeed,double,5,0.222114,seconds
UnitTestAddColSumMatSpeed,double,5,0.205234,seconds
UnitTestAddVecToRowsSpeed,double,5,0.240473,seconds
UnitTestAddVecToColsSpeed,double,5,0.162261,seconds

As you can see the CPU usage is pinned above 90%.
armeabi-v7a
32bit
UnitTestRealFftSpeed,float,512,0.0684619,seconds
UnitTestSplitRadixRealFftSpeed,float,512,0.0363259,seconds
UnitTestSvdSpeed,float,4,4.70356,seconds
UnitTestAddMatMatSpeed,float,2,0.76346,seconds
UnitTestAddRowSumMatSpeed,float,5,0.140093,seconds
UnitTestAddColSumMatSpeed,float,5,0.142121,seconds
UnitTestAddVecToRowsSpeed,float,5,0.146741,seconds
UnitTestAddVecToColsSpeed,float,5,0.145406,seconds
UnitTestRealFftSpeed,double,512,0.0561302,seconds
UnitTestSplitRadixRealFftSpeed,double,512,0.0310419,seconds
UnitTestSvdSpeed,double,4,7.92912,seconds
UnitTestAddMatMatSpeed,double,2,0.883866,seconds
UnitTestAddRowSumMatSpeed,double,5,0.152569,seconds
UnitTestAddColSumMatSpeed,double,5,0.160446,seconds
UnitTestAddVecToRowsSpeed,double,5,0.148019,seconds
UnitTestAddVecToColsSpeed,double,5,0.147486,seconds

CPU usage varies but usually under 50%
Any help here would be greatly appreciated! If more info is needed, I will gladly post it.

Well, if you see essentially the same behaviour no matter if the build is multi- or singlethreaded, it is probably safe to rule out any locking issues. But I do wonder why you are comparing vastly different versions in addition to 32 vs 64 bit - 0.3.0 was released almost exactly six years ago and contained an equally old version of LAPACK (which may or may not matter, depending on what your benchmarks do). Did you build OpenBLAS yourself, or are these binaries you picked up from some other projects (which would imply differences in build options and compilers) ?
Do you see similar differences with the simple benchmarks provided in the benchmark directory ?

@martin-frbg thanks for the quick response.
I figured out this issue was a dumb mistake on my end. I was linking against this openblas aarch64 library in one of my libraries. Then when linking against that I was also accidentally pointing to the old armv7 32bit library of openblas. I would have thought that the compiler would complain here about linking 32bit and 64bit libs.....which I still do not understand.
Here is the CPU usage with the correct aarch64 lib. It's looking real nice now! Closing this issue


support to run header_filter and body_filter phase for global rules.

Issues resolved
Fix #1338

@Akayeshmantha
Maybe we can refactor the way to run global rule in log/header filter/body filter phases to use the same function?

Sure @spacewander created a new issue #1369 since this ticket mentioned a different issue

@spacewander @membphis

@membphis  can we merge this if its ok?

@membphis done changes

@membphis @moonming  if things ok can we merge this so I can work on the other issue related to this 🙂

@Akayeshmantha you need to rebase you PR after https://github.com/apache/incubator-apisix/commit/c76e7e3623f871987f006848c6c6abcb59550bdb merged

@membphis  rebased

@spacewander please take a look


Update dependencies

#3410 somehow downgrades knative.dev/reconciler-test. This PR updates the dependencies as the should

/retest

/hold


[fix][test] Fix clear transaction buffer snapshot flaky test

Motivation
java.lang.AssertionError:
Expected :true
Actual   :false
<Click to see difference>
	at org.testng.Assert.fail(Assert.java:99)
	at org.testng.Assert.failNotEquals(Assert.java:1037)
	at org.testng.Assert.assertTrue(Assert.java:45)
	at org.testng.Assert.assertTrue(Assert.java:55)
	at org.apache.pulsar.broker.transaction.TopicTransactionBufferRecoverTest.checkSnapshotCount(TopicTransactionBufferRecoverTest.java:452)
	at org.apache.pulsar.broker.transaction.TopicTransactionBufferRecoverTest.clearTransactionBufferSnapshotTest(TopicTransactionBufferRecoverTest.java:427)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
// ...

Currently, the clear transaction buffer snapshot is flaky, because we used @Cleanup, the @Cleanup annotation will put the close producer method to the bottom of the test method, then the producer will close after deleting the topic.
When we delete the topic, all relevant producers will receive a CLOSE_PRODUCER command, then the producer client will try to reconnect to the broker, so it will send the PRODUCER command again, then the transaction buffer snapshot will take a new snapshot, so the test will fail.
Modifications
Make the producer close before the topic deleting.
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

@codelipenghui @BewareMyPower The CI is passed. Please take a look if you have time, thanks : )


whitelist resultstore

@alexander-fenster It seems the api owner have updated //third_party/googleapis/. Is there a way to force sync googleapis/googleapis and kick off a CI? We won't need to whitelist it if the problem is fixed.

It works!

Thanks for working on it @hzyi-google! I guess we can close this PR now.

Thanks for the help Alex.


VM unresponsive on macOS Sierra

On a fresh install of macOS Sierra + Homebrew:
brew install dlite docker # Installs dlite 1.1.5 and docker 1.12.1
dlite install -v 2.3.1
dlite start
# Wait a minute
dlite ip

Output: Failed to find an IP for the virtual machine in 15 seconds
Running docker ps throws out the usual Cannot connect to the Docker daemon. Is the docker daemon running on this host?
I've never touched xhyve and am at a loss for where to start debugging this. Docker for Mac fails miserably for my application, so I'm very interested in getting this functional.

I haven't actually tested in sierra just yet, I plan to update today sometime and I'll take a look and see if it's even compatible

I'm having the same issue. The dlite process starts up, then exits without any feedback or error.
Is there a way to get some log info? I'm not a go developer, but know a thing or two about software development and system administration, maybe I could help a bit.

so i've updated and confirmed this is definitely a sierra related bug, i'm working on getting it fixed

Thanks! Appreciate you're looking into it this urgently. Hope it's something quick to fix, I need this thing more than ever now.
Working on a database migration, and Docker for Mac runs slow like hell, and symfony keeps losing connection to the MariaDB docker instance.

@tamasimrei Since you need it urgently, there's also Dinghy which is gives you a similar end-result to dlite, but is a layer on top of docker-machine (which you can use with xhyve like dlite does for better native performance). Alternatively, you could just run docker-machine with the xhyve provider yourself, then run the docker-machine-nfs script to switch it over to NFS shares instead of the default solution.
I think dlite's a head above those options due to the custom xhyve OS and local socket file rather than needing a slew of environment variables for a remote TCP connection, but they work well in a pinch.

@TomFrost thanks, will check them out!

Hi s there any update for this issue? We have same problems on Siera.. We tried some alternatives, but they are not working too.

i have a fair amount of work done in the refactor branch here that i'm still doing some testing with. it's rough and probably needs some debugging, but it's mostly functional. give me another day and i'll release a beta

Why does it work just fine for me? :)

waiting for beta =)

https://github.com/nlf/dlite/releases/tag/2.0.0-beta7
please remove any previous installations you had before trying it. i'm going to clean up existing issues, so feel free to open new issues for any problems you have.


cutadapt has an option called --revcomp

Hi all, from the source code I see that cutadapt has been called twice to run, among which another once is on reverse-complemented sequences.
However cutadapt has already had the --revcomp option: https://cutadapt.readthedocs.io/en/stable/guide.html#reverse-complement
How about using this option to make cutadapt run only once?

Hello @billzt,
Thank you very much for the comment. I'll have a look at the --revcomp option and update the code if the same results can be achieved compared to the current implementation.
Thanks again!
Cheers,
Gert-Jan

Hello @billzt,
Thank you very much for the comment. I'll have a look at the --revcomp option and update the code if the same results can be achieved compared to the current implementation.
Thanks again!
Cheers,
Gert-Jan


Getting the actual location of a passenger

https://github.com/bergerhealer/TrainCarts/blob/4fab1568b6e6350afb11b79aeed8a506e89ec0a9/src/main/java/com/bergerkiller/bukkit/tc/controller/MinecartMember.java#L575
Is there a reason why the function above is only returning a default vector? Because the name of the function and the parameter would suggest that I can request the actual location of a passenger with this function.
Is there maybe another way I can request the actual location of a passenger? Because when I'm using seat attachments, the location of a player seems to be always in the middle of the cart when requesting it.

The player only exists where the minecart exists on the server. The server does not know about any attachments being present, and thus does not know the exact player's location.
There is a way to return the actual location of the player as seen by the client, but I am not familiar with the way of doing so.

Thats a very good question haha. Very old code, I very much doubt I still use that function. Instead I query the attachments (network controller) what the seat positions are.

I hate to be that guy, but could you give me an example on that? Lets say I have the minecart group of the passenger and I would like to know the exact location of that passenger.

I think Ill just fix that function up instead of explaining, but the code to do it is in TCListener as part of the vehicle exit event handling

Aah okay that is awesome, in the mean time I'll keep trying to figure it out.

https://github.com/bergerhealer/TrainCarts/commit/3dd5a3251c1f9b3714c2f32c82f9ab60f9b321ed

Awesome! I was almost there with the code from the exit event, but this makes it much better. Thanks!


x/tools/cmd/go-contrib-init: tool does not recognize .googlesource.com config

What version of Go are you using (go version)?
Go 1.9beta2
What operating system and processor architecture are you using (go env)?
Windows 10
What did you do?
go get golang.org/x/tools/cmd/go-contrib-init

go-contrib-init

What did you expect to see?
All good. Happy hacking!
Remember to squash your revised commits and preserve the magic Change-Id lines.
Next steps: https://golang.org/doc/contribute.html#commit_changes

What did you see instead?
Your .gitcookies file isn't configured.
Next steps:
  * Submit a CLA (https://golang.org/doc/contribute.html#cla) if not done
  * Go to https://go.googlesource.com/ and click "Generate Password" at the top,
    then follow instructions.
  * Run go-contrib-init again.

This seems to be caused by the fact that I already have a line in the configuration containing this:
.googlesource.com       TRUE    /       TRUE    <hidden>      o       git-florinpatan.gmail.com=<hidden>

Wasn't this already fixed by https://go-review.googlesource.com/c/48230/ ?
Are you running an old version?

/cc @kevinburke

I literally just go getted the tool for the workshop so no, it's not fixed yet I guess. sorry.

@dlsniper, but you probably had an old x/tools on disk already from a different x/tool package.

Investigating...

I've fixed with go get -u, thank you.


Test fails with AssertionFailed 42 != 0 on mvn v3.5.0, jdk v1.8.0

Cloned fresh, compiled cleanly, so I ran "mvn test" using maven v3.5.0 and JDK 1.8.0_91. But 2 of 3 tests fail, an abbreviated log is below.
Running biz.paluch.rest.test.InMemoryRestTest
KEEPALIVE!: true
[Tue Nov 14 13:15:21 EST 2017] Servlet for path '/' already defined and no default will be used.
[Tue Nov 14 13:15:21 EST 2017] TJWS httpd localhost - SimpleAcceptor ServerSocket[addr=localhost/<IP_ADDRESS>,localport=49900] is listening.
[Tue Nov 14 13:15:22 EST 2017] Accept: java.net.SocketException: Socket closed
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.67 sec <<< FAILURE!
postSimpleBody(biz.paluch.rest.test.InMemoryRestTest)  Time elapsed: 0.238 sec  <<< FAILURE!
java.lang.AssertionError: expected:<42> but was:<0>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:645)
	at org.junit.Assert.assertEquals(Assert.java:631)
	at biz.paluch.rest.test.InMemoryRestTest.postSimpleBody(InMemoryRestTest.java:56)

Finally here's the result:
Failed tests:   postSimpleBody(biz.paluch.rest.test.InMemoryRestTest): expected:<42> but was:<0>
  postWithMocking(biz.paluch.rest.test.InMemoryRestWithMockitoTest): expected:<42> but was:<0>

Please advise, thanks for listening.

Please see my pull request for the fix.

That's fixed now.


Navigation Menu Animation is a bit clunky

https://ui.shadcn.com/docs/components/navigation-menu
You can see the animation on the docs page is a bit clunkier than the Radix Navigation Menu.
Imagine this is a calculation issue of the Item Content component.

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

I've noticed the same behavior. @shadcn I think you should reopen this issue 👀

Same here.

Hi everyone,
I've also noticed the "clunky" animation of the navigation-menu component and wanted to share some improvements that could potentially enhance the smoothness of the animations.
1. Modify NavigationMenuPrimitive.Viewport component:
To address the animation issue, add the following classNames to the NavigationMenuPrimitive.Viewport component to enhance the menu's open/close animation and enable width animation.
/* enhance menu open/close animation */
data-[state=closed]="fade-out-0"
data-[state=open]="fade-in-0"

/* enable menu width animation */
duration-200

2. Changes to NavigationMenuIndicator component:
To fix initial visibility issues when the menu is animating in, include the NavigationMenuIndicator inside the NavigationMenuList of your component.

Note: It appears that without the NavigationMenuIndicator component, some of the internal logic of @radix-ui/react-navigation-menu does not function properly.

<NavigationMenuList>
  <NavigationMenuItem>
    // ...
  </NavigationMenuItem>
  <NavigationMenuIndicator/> // added here
</NavigationMenuList>

Note: These changes affect the visibility of the indicator, which currently does not align with shadcn's visual style guidelines. For example, elements such as popovers and tooltips do not use triangle indicators that visually reference their container elements.

There are two ways to address this issue, but I would consider them "temporary workarounds" and leave the definitive solution to the author.
a) If you prefer to maintain the indicator, please consider the following modifications:
To refine the slide-in animation, remove the following classNames from NavigationMenuPrimitive.Indicator.
data-[state=visible]="animate-in"
data-[state=visible]="fade-in"
data-[state=hidden]="animate-out"
data-[state=hidden]="fade-out"

b) If you prefer to hide the indicator, consider the following two options:

Note: These changes could impact the internal logic of @radix-ui/react-navigation-menu for calculating width and other properties. Further investigation and testing are recommended to ensure compatibility and functionality.

Option 1:
Modify the classNames of the inner div of NavigationMenuPrimitive.Indicator by changing size-2 to size-0 to hide the indicator. Alternatively, you could add hidden or opacity-0 to the classNames.
<div className="relative top-[60%] size-0 rotate-45 rounded-tl-sm bg-border shadow-md"/>

Option 2:
Simplify NavigationMenuPrimitive.Indicator to its bare essentials while maintaining its functionality but hiding its visual appearance.
const NavigationMenuIndicator = React.forwardRef<
  React.ElementRef<typeof NavigationMenuPrimitive.Indicator>,
  React.ComponentPropsWithoutRef<typeof NavigationMenuPrimitive.Indicator>
>(({ className, ...props }, ref) => (
  <NavigationMenuPrimitive.Indicator ref={ref} className={cn(className)} {...props}/>
));

NavigationMenuIndicator.displayName = NavigationMenuPrimitive.Indicator.displayName;

(Optional): Customization of NavigationMenuViewport appearance:
Lastly, to further tailor the component's appearance, you might consider removing NavigationMenuViewport from the shadcn UI component and re-adding it to your component.

Remove <NavigationMenuViewport/> from shadcn UI component:

<NavigationMenuPrimitive.Root
  ref={ref}
  className={cn(
    'relative z-10 flex max-w-max flex-1 items-center justify-center',
    className,
  )}
  {...props}
>
  {children}
  // <NavigationMenuViewport/> // remove here
</NavigationMenuPrimitive.Root>

Add <NavigationMenuViewport/> to your component:

<NavigationMenu>
  <NavigationMenuList>
    <NavigationMenuItem>
      // ...
    </NavigationMenuItem>
    <NavigationMenuIndicator/>
  </NavigationMenuList>
  <NavigationMenuViewport className="bg-popover/80 backdrop-blur-lg"/> // add here
</NavigationMenu>

I hope these suggestions help improve the animation smoothness. I look forward to any feedback or further discussion on these modifications.
Best
Michael

I got a little confused by how you were using the = sign but eventually got it working by switching it with :
data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 duration-200
Thanks!


fix(dependencies): upgrade dependencies

:tada: This PR is included in version 1.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Wristwatch has an OOC description

Description
The wristwatch item's description reads "How much time did you waste playing ss14?". This is a NO NO!!
Screenshots

Additional context
This change would be in line with ones such as the one to chef's cookbook #29467

already fixed by #30036


Full Text Seach: where clause ignored or unclear behavior

Assuming I've set up an fts_index... when doing this:
table.search(query).where(filter).limit(10).to_list()

I expect the FTS to be limited to records where filter is True. But it doesn't seem to be the case,
as in the first query below -- the filter seems to be ignored, or I don't understand the behavior, or I'm missing some setting.
I expected the first query below to return NO results. The second one seems to work as expected.
In [1]: import lancedb
   ...:
   ...: uri = "data/sample-lancedb"
   ...: db = lancedb.connect(uri)
   ...:
   ...: table = db.create_table("my_table",
   ...:             data=[{"vector": [3.1, 4.1], "text": "Frodo was a happy puppy"},
   ...:                   {"vector": [5.9, 26.5], "text": "There are several kittens playing"}])

In [2]: table.create_fts_index("text")

In [3]: table.search("Frodo").where("text like '%kitten%'").limit(10).to_list()
Out[3]:
[{'vector': [3.0999999046325684, 4.099999904632568],
  'text': 'Frodo was a happy puppy',
  'score': 0.6931471824645996}]

In [4]: table.search(None).where("text like '%kitten%'").limit(10).to_list()
Out[4]:
[{'vector': [5.900000095367432, 26.5],
  'text': 'There are several kittens playing'}]

I expected the first query below to return NO results. The second one seems to work as expected.

If we get the FTS results then apply the filter on top, I think that should be good right?

It doesn't work yet, I assume you mean you're planning to implement it.
yeah just wanted to confirm this would solve your need before I go implement it

@pchalasani you can take a look at the unit test in #739 to see usage. Lmk if this is what you were expecting.

Lmk if this is what you were expecting.

@changhiskhan yes it looks like the behavior I was expecting, i.e. the FTS should be restricted to records that pass the where filter. In the unit test, there's a chance there are no results matching puppy, but may be that doesn't happen given the table contents.


Changes to Metadb derived table po_lines_locations.sql with comments added

Added holding_id and relying locations resolving on newly introduced holding information at po line level for derived table po_lines_locations (Metadb version)
All queries:
- [ ] Release notes added or updated in CHANGES.md
- [ ] Query runs without errors
- [ ] Query output is correct
- [ ] Query logic is clear and well documented
- [ ] Query is readable and properly indented with spaces (not tabs)
- [ ] Table and column names are in all-lowercase
- [ ] Quotation marks are used only where necessary

Report queries:
- [ ] Query has complete user documentation
    - [ ] Purpose of report
    - [ ] Sample output
    - [ ] Query instructions

Derived tables:
- [ ] Query begins with user documentation in comment lines
- [ ] File name is listed in `runlist.txt` after dependencies
- [ ] All columns have indexes
- [ ] Table is vacuumed and analyzed

@natalyapik I requested a few changes for this PR. I know they're mostly just typos, but would you be willing to go ahead and propose some updates? I think making the logic easier to understand would be a pretty high priority for me, since that's a major change to this query and it could be difficult to follow. Fixing the typos is not a high priority, so if that's holding you back we could skip those suggestions.


Missing selection statistics for gen2

Storage Explorer Version: 1.6.0
Platform/OS Version: win10 x64
It would be great to have the following when gen2 stats are supported:

Total number of files
Total number of directories
Max directory depth
Total size in bytes
Min/Avg/Max # of files per directory
Min/Avg/Max bytes per file

Hi, this "feature request" (or bug depending how you read it) has been opened for nearly 21 months now, is there any plan for these to be added anytime soon please?
Alternatively are you planning to fix "Azure Storage Explorer Folder Statistics missing in ADLS Gen2"https://github.com/microsoft/AzureStorageExplorer/issues/1349 which was closed as a duplicate?
Can we please have updates on the timelines please?

This is a key missing feature.

+1

+1

Selection and folder statistics for Gen2 are going to be included in 1.17. The feature has parity with the existing normal blob experience. That is: counts of number of and total bytes of active blobs.


<gem-route>  precise definition

Does the routes prop change and currentRoute need to be changed?
When is the change event triggered?

Update only when the href is modified
Trigger change after update, and not redirect


'New Database' button error

Problem

Clicking on 'New Database' button to create a new database throws an error.
Cause
Invalid reference to _create_db_table().
Fix
Reference the proper function.

Potential fix: https://github.com/nle244/4GP-Password-Manager/commit/d088d7f89db93acfdbff0aecbb8f1dc02fdd4621


Error in sample code

if run MOSS 2019 EE:
if ((Get-PSSnapin 'Microsoft.SharePoint.PowerShell' -ErrorAction SilentlyContinue) -eq $null) {
    Add-PSSnapin 'Microsoft.SharePoint.PowerShell'
}
Clear-Host

$proxy = Get-SPServiceApplicationProxy | ?{$_.TypeName -eq 'User Profile Service Application Proxy'}
$security = Get-SPProfileServiceApplicationSecurity -ProfileServiceApplicationProxy $proxy
$everyone = New-SPClaimsPrincipal -Identity 'c:0(.s|true' -IdentityType EncodedClaim
Revoke-SPObjectSecurity -Identity $security -Principal $everyone -Rights 'Create Personal Site'
Set-SPProfileServiceApplicationSecurity -Identity $security -ProfileServiceApplicationProxy $proxy

Error^ Revoke-SPObjectSecurity : The specified user or domain group was not found.
At C:\Work\UserProfilePremissions\UserProfilePremissions07.ps1:9 char:1
+ Revoke-SPObjectSecurity -Identity $security -Principal $everyone -Rig ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (Microsoft.Share...eObjectSecurity:SPCmdletRevokeObjectSecurity) [Revoke-SPObjectSecurity], SPException
    + FullyQualifiedErrorId : Microsoft.SharePoint.PowerShell.SPCmdletRevokeObjectSecurity

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2e39560d-4312-1e65-c7a1-49eb2ef07bd6
Version Independent ID: f0d4b39e-efc9-b5fe-f469-ec7f3db8f56e
Content: Set-SPProfileServiceApplicationSecurity (sharepoint-server)
Content Source: sharepoint/sharepoint-ps/sharepoint-server/Set-SPProfileServiceApplicationSecurity.md
Product: sharepoint-powershell
GitHub Login: @techwriter40
Microsoft Alias: kirks

@officedocsbot assign @yogkumgit

There isn't an error. This works fine given the claim has been previously added. In your case, it means the group wasn't assigned rights on the UPSA prior to running the cmdlet.

Hello @ChebotovViktor
Please see https://github.com/MicrosoftDocs/office-docs-powershell/issues/4410

@tseward Please review the PR #4430

@kenwith Please merge this PR #4430 . Thanks.

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @ChebotovViktor Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Please release a new tag v4.0.8 that uses ^9.0 instead of ^8.0

Currenly we cannot use new features 9.0...See:
https://github.com/Adldap2/Adldap2-Laravel/blob/v4.0.7/composer.json

Hi @acacha, this is intended, as v9.0 includes breaking changes in the query builder and other aspects that may impact developers Laravel applications.
It will be a v5.0 release to follow semver.
It will be coming in a couple days!

agghh ok sorry! No problem. Thanks!

No problem, thanks for your patience! :smile:

Hi,
will there be some kind of upgrade guide? I'm also looking forward to this to fix the problem with getting contacts when searching for users.
Thanks!

Hi @KuenzelIT, there will definitely be an upgrade guide.
There won't be many breaking changes, only small configuration & query builder changes, but they are indeed breaking so it requires a major version.
Thanks for your patience guys!

v4.0.10 upgraded adldap to v9.
is this intended? it broke quite a lot...

Hi @m-lotze, just caught this. Created a release from the v4.0 branch and it seemed to use the new composer.json file using v9.0...
I'm going to re-create the release. I might have done this somehow, just not sure how.

@m-lotze New release is now good to go, sorry about that! 🤦♂

Is there an update when the v5 will be released?

Released.