Plugin not working on Android 8.0

Hi!
This plugin doesn't work on Android 8.0, logcat outputs this:
03-16 18:25:01.899  4884  4884 W zygote  : Attempt to remove non-JNI local reference, dumping thread
03-16 18:25:01.966  4884  4970 E PluginManager: Uncaught exception from plugin
03-16 18:25:01.966  4884  4970 E PluginManager: android.os.FileUriExposedException: file:///storage/emulated/0/Android/data/[MY_APP_ID]/files/instagram8756136426115648363.png exposed beyond app through ClipData.Item.getUri()
03-16 18:25:01.966  4884  4970 E PluginManager:         at android.os.StrictMode.onFileUriExposed(StrictMode.java:1958)
03-16 18:25:01.966  4884  4970 E PluginManager:         at android.net.Uri.checkFileUriExposed(Uri.java:2348)
03-16 18:25:01.966  4884  4970 E PluginManager:         at android.content.ClipData.prepareToLeaveProcess(ClipData.java:941)
03-16 18:25:01.966  4884  4970 E PluginManager:         at android.content.Intent.prepareToLeaveProcess(Intent.java:9735)
03-16 18:25:01.966  4884  4970 E PluginManager:         at android.content.Intent.prepareToLeaveProcess(Intent.java:9741)
03-16 18:25:01.966  4884  4970 E PluginManager:         at android.content.Intent.prepareToLeaveProcess(Intent.java:9720)
03-16 18:25:01.966  4884  4970 E PluginManager:         at android.app.Instrumentation.execStartActivity(Instrumentation.java:1609)
03-16 18:25:01.966  4884  4970 E PluginManager:         at android.app.Activity.startActivityForResult(Activity.java:4472)
03-16 18:25:01.966  4884  4970 E PluginManager:         at org.apache.cordova.CordovaActivity.startActivityForResult(CordovaActivity.java:342)
03-16 18:25:01.966  4884  4970 E PluginManager:         at android.app.Activity.startActivityForResult(Activity.java:4430)
03-16 18:25:01.966  4884  4970 E PluginManager:         at org.apache.cordova.CordovaInterfaceImpl.startActivityForResult(CordovaInterfaceImpl.java:66)
03-16 18:25:01.966  4884  4970 E PluginManager:         at com.vladstirbu.cordova.CDVInstagramPlugin.share(CDVInstagramPlugin.java:127)
03-16 18:25:01.966  4884  4970 E PluginManager:         at com.vladstirbu.cordova.CDVInstagramPlugin.execute(CDVInstagramPlugin.java:73)
03-16 18:25:01.966  4884  4970 E PluginManager:         at org.apache.cordova.CordovaPlugin.execute(CordovaPlugin.java:98)
03-16 18:25:01.966  4884  4970 E PluginManager:         at org.apache.cordova.PluginManager.exec(PluginManager.java:132)
03-16 18:25:01.966  4884  4970 E PluginManager:         at org.apache.cordova.CordovaBridge.jsExec(CordovaBridge.java:57)
03-16 18:25:01.966  4884  4970 E PluginManager:         at org.apache.cordova.engine.SystemExposedJsApi.exec(SystemExposedJsApi.java:41)
03-16 18:25:01.966  4884  4970 E PluginManager:         at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
03-16 18:25:01.966  4884  4970 E PluginManager:         at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:41)
03-16 18:25:01.966  4884  4970 E PluginManager:         at android.os.Handler.dispatchMessage(Handler.java:105)
03-16 18:25:01.966  4884  4970 E PluginManager:         at android.os.Looper.loop(Looper.java:164)
03-16 18:25:01.966  4884  4970 E PluginManager:         at android.os.HandlerThread.run(HandlerThread.java:65)
03-16 18:25:01.968  4884  4884 W cr_Ime  : updateState: type [0->0], flags [0], show [false],

The problem seems to be easy to solve but Java is not my forte.....
https://stackoverflow.com/questions/38200282/android-os-fileuriexposedexception-file-storage-emulated-0-test-txt-exposed
Thanks

It was fixed in the past for Android 7.... https://github.com/vstirbu/InstagramPlugin/commit/ebba2d1fd1a590a967066fa27747fa6952b24232
But the problem is still reproducible in Android 8 (API 26)

Bounty of $50 created for this issue: https://www.bountysource.com/issues/56192821-plugin-not-working-on-android-8-0

+1

I think there is solved on https://github.com/vstirbu/InstagramPlugin/pull/98 , can i claim now ?? :)

Does this fix also maintain backwards compatibility with android 7 and below?

To be honest , I have not built it because I do not have the Cordova environment ready, nor instagram, but I know the error and this should solve the problem in Android 8 and maintain the previous compativility .

@rodrigograca31 Can you tell me if you have the following in your installation?
In your AndroidManifest.xml:
<provider android:authorities="${applicationId}.provider" android:exported="false" android:grantUriPermissions="true" android:name="android.support.v4.content.FileProvider">
            <meta-data android:name="android.support.FILE_PROVIDER_PATHS" android:resource="@xml/provider_paths" />
</provider>

and in your res/xml/provider_paths.xml:
<paths xmlns:android="http://schemas.android.com/apk/res/android">
    <external-path name="external_files" path="."/>
</paths>

I have them in my install but I'm worried they are being created by another plugin and my current fix which I have working now won't apply to everyone.

@albertleao searching for android:authorities in AndroidManifest.xml
gives me this 2 results:
<provider android:authorities="${applicationId}.provider" android:exported="false" android:grantUriPermissions="true" android:name="android.support.v4.content.FileProvider">
    <meta-data android:name="android.support.FILE_PROVIDER_PATHS" android:resource="@xml/provider_paths" />
</provider>

<provider android:authorities="com.MY-PACKAGE.sharing.provider" android:exported="false" android:grantUriPermissions="true" android:name="nl.xservices.plugins.FileProvider">
    <meta-data android:name="android.support.FILE_PROVIDER_PATHS" android:resource="@xml/sharing_paths" />
</provider>

Thanks @rodrigograca31 . I think I got it figured out, do you have an android 6 or below device we can test on?

and res/xml/provider_paths.xml has this:
<paths xmlns:android="http://schemas.android.com/apk/res/android">
    <external-path name="external_files" path="."/>
</paths>

I have Android 4.4, 5.1 and 8
Then I can set up emulators for 6 and 7 with a few clicks and some waiting..... :joy:

Give it a shot for me https://github.com/albertleao/InstagramPlugin/tree/android_nougat_patch

Are you  using Android Studio? I had that sem error at first then I changed one more line in the file and it 'synced' and started working. I think i added a random space. I'm kinda shooting from the hip with this java stuff.

I just downloaded your repo and added directly and compiled!
Seems not to work yet......... (not share to Instagram) let me try another way...........

Wait................. Actually compiled because I downloaded the master branch.... fail... Downloading the correct branch produces that error above....

Yea. I'm trying to figure out how to import the FileProvider library correctly. If you add it after compile, everything works.

Sorry guys , you are right with the FileProvider , i just missinterpreted a comment , thinking we just need set the flag . Looks you are solving that , if you want me to try again let me know ;)

I just pushed an update to https://github.com/albertleao/InstagramPlugin/tree/android_nougat_patch
It's compiling on my end on android 7.

@albertleao
1st: not sure why you were complaining about nougat (android 7) because for me worked in 7 when I tested 1-2 weeks ago in a emulator...
2nd: used your first commit and tryed on my own to make the import (reading the docs) and just added import android.support.v4.content.FileProvider; to your first commit and works for me..... (Android 8 Oreo)

Haha, my fault. I've been referring to Nougat as if it were Oreo.
I'll redo my commits with the right messages.
My 2nd commit ensures that when you add the plugin to cordova it references the correct libraries. I was having issues with that in my first commit

And you repeat code in your first commit inside the if/else.... it would be better if that was cleaned and updated the package version, etc for the plugin creator to accept a PR.....
but first I will try that commit with my changes in 4.4, 5.1, 6, 7 and 8.......

Oh........ ok.........

Doing that now, give me a few.

Ok, I'm testing in 4.4 and 5 atm. Then 6 and 7 will take a while do spin up the emulator install Instagram and test....

Ok, I will test that on all the things and report back maybe in 1-2 hours or tomorrow......

I just tested on an emulator running Nougat and on my phone running Oreo and both are working.

Tested on Android 4.4 and 8 real devices and all of this emulators:

and it's working! YAY! :smile:
@albertleao would you mind registering in bountysource and claiming the reward?
(3AM here, I'm heading out)

Also, send a PR for the main plugin......

Great! I'll do that and I'll make the pull request back to the main repo. I'll keep this up until then.
Have a great night!

@vstirbu please merge #99

also published in npm. great job

Yay!
I just spend 3 hours trying to make my ionic project work......... :cry:
I updated Android Studio and it updated gradle and everything went bananas...... :cry:
Even almost solved one of my Rubik's cubes by accident while waiting for downloads/compiles :joy:
@albertleao bountysource says: "The bounty can be claimed once the issue gets closed on the original issue tracker. When a bounty claim is submitted, all Backers will be notified."
you should be able to claim now and I will accept :)

@rodrigograca31 glad you got it working. I have claimed the bounty.

Accepted. Enjoy! :)

hummmmmmm.
Not sure what I've done but everything was working and I even deployed a new version of my app to the Play Store already.........
Then I basically removed and added cordova back: ionic cordova platform rm android && ionic cordova platform add<EMAIL_ADDRESS>and did ionic cordova run android and the app crashes on launch....
adb logcat:
03-27 18:37:31.533  2488  2488 D AndroidRuntime: Shutting down VM
03-27 18:37:31.538  2488  2488 E AndroidRuntime: FATAL EXCEPTION: main
03-27 18:37:31.538  2488  2488 E AndroidRuntime: Process: MY_APP_ID, PID: 2488
03-27 18:37:31.538  2488  2488 E AndroidRuntime: java.lang.RuntimeException: Unable to get provider com.vladstirbu.cordova.plugin.utils.AssetProvider: java.lang.ClassNotFoundException: Didn't find class "com.vladstirbu.cordova.plugin.utils.AssetProvider" on path: DexPathList[[zip file "/data/app/MY_APP_ID-zBBIXHndes8kSG-p2dOqZw==/base.apk"],nativeLibraryDirectories=[/data/app/MY_APP_ID-zBBIXHndes8kSG-p2dOqZw==/lib/arm64, /system/lib64, /system/vendor/lib64]]
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at android.app.ActivityThread.installProvider(ActivityThread.java:6548)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at android.app.ActivityThread.installContentProviders(ActivityThread.java:6094)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6015)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at android.app.ActivityThread.-wrap1(Unknown Source:0)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1756)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:105)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:164)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:6809)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
03-27 18:37:31.538  2488  2488 E AndroidRuntime: Caused by: java.lang.ClassNotFoundException: Didn't find class "com.vladstirbu.cordova.plugin.utils.AssetProvider" on path: DexPathList[[zip file "/data/app/MY_APP_ID-zBBIXHndes8kSG-p2dOqZw==/base.apk"],nativeLibraryDirectories=[/data/app/MY_APP_ID-zBBIXHndes8kSG-p2dOqZw==/lib/arm64, /system/lib64, /system/vendor/lib64]]
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:93)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        at android.app.ActivityThread.installProvider(ActivityThread.java:6533)
03-27 18:37:31.538  2488  2488 E AndroidRuntime:        ... 10 more

removing this from the plugin makes it work:
<config-file target="AndroidManifest.xml" parent="/manifest/application">
        <provider android:authorities="${applicationId}.provider" android:exported="false" android:grantUriPermissions="true" android:name="com.vladstirbu.cordova.plugin.utils.AssetProvider">
          <meta-data android:name="android.support.FILE_PROVIDER_PATHS" android:resource="@xml/instagramplugin_provider_paths" />
        </provider>
    </config-file>

but I think that's only because another plugin cordova-plugin-camera does basically the same.........
<config-file target="AndroidManifest.xml" parent="application">
          <provider
              android:name="android.support.v4.content.FileProvider"
              android:authorities="${applicationId}.provider"
              android:exported="false"
              android:grantUriPermissions="true" >
              <meta-data
                  android:name="android.support.FILE_PROVIDER_PATHS"
                  android:resource="@xml/provider_paths"/>
          </provider>
        </config-file>

After typing that I think we need to add another <source-file.... for the AssetProvider.java file to be copied because its probably not copied and is missing....? Let me try to add that.....

Yep, adding
<source-file src="src/android/utils/AssetProvider.java" target-dir="src/com/vladstirbu/cordova" />

after:
<source-file src="src/android/CDVInstagramPlugin.java" target-dir="src/com/vladstirbu/cordova" />

makes it work... and makes sense.... not sure how it was working before........?
@albertleao opinion? should you add this line ...?
thanks.

@albertleao ?

It is still not working for me.. I have added the source-file line as @rodrigograca31 suggested in the plugin.xml.
05-29 16:59:34.278 23282-23282/? E/UncaughtException: java.lang.RuntimeException: Unable to get provider com.vladstirbu.cordova.plugin.utils.AssetProvider: java.lang.ClassNotFoundException: Didn't find class "com.vladstirbu.cordova.plugin.utils.AssetProvider" on path: DexPathList[[zip file "/data/app/com.obi4wan.instagram-E6QuXbWUe_WYgZzEBXFz3A==/base.apk"],nativeLibraryDirectories=[/data/app/com.obi4wan.instagram-E6QuXbWUe_WYgZzEBXFz3A==/lib/arm64, /system/lib64, /vendor/lib64]]
Any ideas?

Humm, did you remove and add the android platform so that it does the entire process again?

...  That worked.. hopefully this fix will be added soon. @albertleao


Add skeleton to main namespace

Only adding the skeleton for now (the other one is data list, but I wanted to see if we want to consolidate that at all with our existing lists).

I think data_list and the rx.list namespace serve different purposes, they probably shouldn't be consolidated together.

Already merged in #3257


Changed the architecture image to remove the space

Removed the space between "HD Insight"

#Sign-Off

@EdPrice-MSFT: I'm sorry - only the author of this article, @, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Fix issue where empty WebUI property is not parsed correctly

This resolves #3011

Hey @timhovius! Thanks for reporting and fixing this issue! If you have time, it would be great if you could also add a test case for this scenario?


Double startup speed - Render MarketPane less with shouldComponentUpdate

Keep track of relevant market changes, and only update if necessary.  I tried the immutable-js route with the PureRenderMixin, but there is market mutation everywhere, and parts of the system seem to depend on that.
In tests on my local machine before this change, I would typically see markets first render, and the whole page complete, in about 12 and 16 seconds, respectively.  After this change, I was seeing about 5 and 7.
There are still another couple seconds to shave off in React render sections, then we'll have to start looking elsewhere for the biggest wins.

nice work here!

I strongly support immutable-js if you're trying to head in that direction.

Cool, I'll try to fit it in. Maybe next.
Sent on a Sprint Samsung Galaxy S® 5
-------- Original message --------
From: Niran Babalola<EMAIL_ADDRESS>Date: 07/09/2015 1:23 PM (GMT-08:00)
To: AugurProject/augur<EMAIL_ADDRESS>Cc: Jason Carver<EMAIL_ADDRESS>Subject: Re: [augur] Double startup speed - Render MarketPane less with shouldComponentUpdate (#108)
I strongly support immutable-js if you're trying to head in that direction.
—
Reply to this email directly or view it on GitHubhttps://github.com/AugurProject/augur/pull/108#issuecomment-120135341.

My only concern is that it's probably an extensive change.
On Thu, Jul 9, 2015 at 4:57 PM Jason Carver<EMAIL_ADDRESS>wrote:

Cool, I'll try to fit it in. Maybe next.
Sent on a Sprint Samsung Galaxy S® 5
-------- Original message --------
From: Niran Babalola<EMAIL_ADDRESS>Date: 07/09/2015 1:23 PM (GMT-08:00)
To: AugurProject/augur<EMAIL_ADDRESS>Cc: Jason Carver<EMAIL_ADDRESS>Subject: Re: [augur] Double startup speed - Render MarketPane less with
shouldComponentUpdate (#108)
I strongly support immutable-js if you're trying to head in that direction.
—
Reply to this email directly or view it on GitHub<
https://github.com/AugurProject/augur/pull/108#issuecomment-120135341>.
—
Reply to this email directly or view it on GitHub
https://github.com/AugurProject/augur/pull/108#issuecomment-120157917.

Agreed.  Immutable-js may cause more instability in the short term, but hopefully would have long-term benefits.  Eventually, I’ll head down the path again and see how far I can get.
The first time I tried, it started breaking in unclear ways (eg~ page didn’t load, without any console errors).  I was trying to do an incremental update and just fix everywhere that broke, but that seems to be an ineffective strategy.  Instead, I’ll try to follow through everywhere that uses the market store, and update it.
I am getting married in a couple weeks, so between that and a full-time job, I’ll probably be pretty silent until mid-August.
From: Niran Babalola<EMAIL_ADDRESS>Sent: Thursday, July 09, 2015 16:15
To: AugurProject/augur
Cc: Jason Carver
Subject: Re: [augur] Double startup speed - Render MarketPane less with shouldComponentUpdate (#108)
My only concern is that it's probably an extensive change.
On Thu, Jul 9, 2015 at 4:57 PM Jason Carver <notifications<EMAIL_ADDRESS>wrote:

Cool, I'll try to fit it in. Maybe next.
Sent on a Sprint Samsung Galaxy S® 5
-------- Original message --------
From: Niran Babalola <notifications<EMAIL_ADDRESS>Date: 07/09/2015 1:23 PM (GMT-08:00)
To: AugurProject/augur <augur<EMAIL_ADDRESS>Cc: Jason Carver <jacarver<EMAIL_ADDRESS>Subject: Re: [augur] Double startup speed - Render MarketPane less with
shouldComponentUpdate (#108)
I strongly support immutable-js if you're trying to head in that direction.
—
Reply to this email directly or view it on GitHub<
https://github.com/AugurProject/augur/pull/108#issuecomment-120135341>.
—
Reply to this email directly or view it on GitHub
https://github.com/AugurProject/augur/pull/108#issuecomment-120157917.

—
Reply to this email directly or view it on GitHubhttps://github.com/AugurProject/augur/pull/108#issuecomment-120172051.

Congrats!
On Fri, Jul 17, 2015 at 1:52 PM Jason Carver<EMAIL_ADDRESS>wrote:

Agreed. Immutable-js may cause more instability in the short term, but
hopefully would have long-term benefits. Eventually, I’ll head down the
path again and see how far I can get.
The first time I tried, it started breaking in unclear ways (eg~ page
didn’t load, without any console errors). I was trying to do an incremental
update and just fix everywhere that broke, but that seems to be an
ineffective strategy. Instead, I’ll try to follow through everywhere that
uses the market store, and update it.
I am getting married in a couple weeks, so between that and a full-time
job, I’ll probably be pretty silent until mid-August.
From: Niran Babalola<EMAIL_ADDRESS>Sent: Thursday, July 09, 2015 16:15
To: AugurProject/augur
Cc: Jason Carver
Subject: Re: [augur] Double startup speed - Render MarketPane less with
shouldComponentUpdate (#108)
My only concern is that it's probably an extensive change.
On Thu, Jul 9, 2015 at 4:57 PM Jason Carver<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:

Cool, I'll try to fit it in. Maybe next.
Sent on a Sprint Samsung Galaxy S® 5
-------- Original message --------
From: Niran Babalola<EMAIL_ADDRESS><EMAIL_ADDRESS>Date: 07/09/2015 1:23 PM (GMT-08:00)
To: AugurProject/augur<EMAIL_ADDRESS><EMAIL_ADDRESS>Cc: Jason Carver <jacarver<EMAIL_ADDRESS>Subject: Re: [augur] Double startup speed - Render MarketPane less with
shouldComponentUpdate (#108)
I strongly support immutable-js if you're trying to head in that
direction.
—
Reply to this email directly or view it on GitHub<
https://github.com/AugurProject/augur/pull/108#issuecomment-120135341>.
—
Reply to this email directly or view it on GitHub
https://github.com/AugurProject/augur/pull/108#issuecomment-120157917.

—
Reply to this email directly or view it on GitHub<
https://github.com/AugurProject/augur/pull/108#issuecomment-120172051>.
—
Reply to this email directly or view it on GitHub
https://github.com/AugurProject/augur/pull/108#issuecomment-122372149.


Fix current time and Add support for Editor++ 3d Trails

State::CurrentRaceTime = GetApp().Network.PlaygroundClientScriptAPI.GameTime - scriptPlayer.StartTime;
is the line that fixes current race time if you want just that. (Editor Trails has been broken for a while, not sure why CurrentRaceTime changed behavior.)
The rest of this PR is adding support for drawing trails via E++'s newly exposed draw lines and quads module. A screenshot of what it looks like is included below.
I don't really mind if this PR is accepted or not, it was mostly for me to test that the draw API worked correctly.
But if you would like it to be added I'm happy to do a little polish.

Thanks, I fixed this in 3aefaae4109689f0b74584ef814860cf2b277f17.
As for the 3D lines, it's cool, but not how I want to approach it in this plugin right now.


Tamper Proof ID

Before issuing the ID for anybody.. can we do a test to ensure they are hack proof and not open to forgery. I have a few lads who can help on that front. (the forgery side not the hacking)

A New Form of ID Allows You to Be a Citizen of the World
Instructions on how to create a BlockchainID
Video here:
http://youtu.be/1iAg6BITPdc
Github project:
https://github.com/MrChrisJ/World-Citizenship
I seriously advise the OCU-Organisation pour une Citoyenneté Universelle get on board with this project.
Join the
O U C - Organization for Universal Citizenship
Join us on facebook
http://www.facebook.com/worldcitizenfriends
Call to Action by:
http://www.facebook.com/citoyenneteuniverselle
Published by:
http://www.o-c-u.org/en/


License?

Excellent work here. I am confused about the licensing implications though. Would help if you could clarify if this can be used commercially?
Thanks!

@zllrunning I would suggest either ISC or AGPL-3.0, whatever you prefer. Tl;dr: ISC just requires to name you as the author (and perhaps you might also want require to cite the papers your code is based on) while AGPL also requires the (modified) source code to be provided to end users.
And thanks for the project, really impressive work!

Thanks for your interest. Licensed under an MIT license.


I suggest using OpenBSD's ksh instead of mksh

https://github.com/ibara/oksh

No. We specifically use mksh for the high compatibility with bash.

No. We specifically use mksh for the high compatibility with bash.

I suggested oksh because its high compatibility with bash! My experience with mksh and oksh is mostly on MSYS2. I found oksh is more compatible with bash than mksh. You can even use the same PS prompt syntax like bash!


Problem in creating Apk file

Description of the Bug
When I use KivyMD code and compile apk for android that app did not run in android auto close when I start that app on my phone.
but when I use only kivy module and compile apk that apk works perfectly.
Code and Logs
kivy code that apk perfectly works
from kivy.app import App
from kivy.uix.label import Label
class MyApp(App):
    def build(self):
        return Label(text="With.SJ")
MyApp().run()

kivymd code that apk not works
from kivymd.app import MDApp
from kivymd.uix.label import MDLabel
class MyApp(MDApp):
    def build(self):
        return MDLabel(text="With.SJ",halign="center")
MyApp().run()

Versions

OS: Ubuntu
Python: 3.6.9
Kivy: 1.11.1
KivyMD: 0.104.1

@WithSJ What is the "auto close"???

when I start the app in my phone that app close immediately.

@WithSJ Attach full log.

@HeaTTheatR Log after this command || buildozer android debug deploy run || show in terminal
log.txt

@WithSJ adb logcat | grep python

@HeaTTheatR
log.txt

@WithSJ https://github.com/HeaTTheatR/KivyMD#how-to-use-with-buildozer


Update Nginx in Docker

Stable from 1.14.1 to 1.14.2
Mainline from 1.15.6 to 1.15.8

Shouldn't we get ngx_pagspeed working on OpenSSL 1.1 instead of just installing LibreSSL? OpenSSL seems to be much more popular, it's the default on alpine now and it supports TLS 1.3 unlike LibreSSL.

I have a docker image working and always updated with the latest nginx mainline (1.7.3), openssl 1.1.1x and the latest pagespeed.
https://cloud.docker.com/repository/docker/extremeshok/nginx-pagespeed

I have a docker image working and always updated with the latest nginx mainline (1.7.3), openssl 1.1.1x and the latest pagespeed.
https://cloud.docker.com/repository/docker/extremeshok/nginx-pagespeed

Hello, backward compatibility?
If I just change pagespeed/nginx-pagespeed to extremeshok/nginx-pagespeed should everything work right away?

I have a docker image working and always updated with the latest nginx mainline (1.7.3), openssl 1.1.1x and the latest pagespeed.
https://cloud.docker.com/repository/docker/extremeshok/nginx-pagespeed

Hello, backward compatibility?
If I just change pagespeed/nginx-pagespeed to extremeshok/nginx-pagespeed should everything work right away?

Closing this in an effort to clean up stale pull requests (but feel free to re-open if you want to pick this up again).


Re-enable data race detection on CI testing

Currently turned off due to the prevalence of false-postives caused by logging occurring during test completion.
Will need to consider approaches to this.

Closed by #37 and #39


Fix #62350

Fix for the issue #62350.
When we run a file with a path that has a space in it instead of running "c:\Users\matb\folder\sp ace.html" it will now execute & 'c:\Users\matb\folder\sp ace.html'. This way powershell will be able to execute the file as it is pretended.

I will close this PR because it has conflicts due to a previous version of vscode


Wrong link in the cue tour

This link is not correct https://github.com/cuelang/cue/blob/master/doc/tutorial/basics/2_types/40_stringlit.txt#L17

Did you verify this link on cuelang.org? The tutorial in this repo is meant to be the source for the tour in repo, which will do rewriting of the files.

Marcel van Lohuizen<EMAIL_ADDRESS>writes:

Did you verify this link on cuelang.org? The tutorial in this repo is meant to be the source for the tour in repo, which will do rewriting of the files.

Yep, I noticed this error on the cuelang.org tour.
So, in the page:
https://cuelang.org/docs/tutorials/tour/types/stringlit/, the link
https://cuelang.org/docs/tutorials/tour/types/stringlit/interpolation.md
is not found:
Not found

Oops! This page doesn't exist. Try going back to our home page.

Ah, the link was correct, it was just that the latest CUE repo including the fix was not yet included in cuelang.org.

Ok, thx.

This issue has been migrated to https://github.com/cue-lang/cue/issues/197.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


fix: add clear in afterAll

Resolves #35

Codecov Report

Merging #37 (f9fd510) into main (4d2b099) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   15.30%   15.29%   -0.02%
==========================================
  Files          37       37
  Lines        1477     1478       +1
  Branches      101      101
==========================================
  Hits          226      226
- Misses       1232     1233       +1
  Partials       19       19

Impacted Files
Coverage Δ

packages/provider/src/tests/runProviderTest.ts
0.18% <0.00%> (-0.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d2b099...f9fd510. Read the comment docs.


CSS conflict with reveal.js

I'm trying to have codemirror on my slides with reveal.js and there seems to be a css conflict.
Look at this page that reproduces the issue: http://viebel.github.io/klipse/misc/reveal-codemirror.html.
There are a couple of issues:

The code is centered instead of aligned left
When trying to navigate the code with the keyboard arrows, it feels very weird
The cursor is not visible when editing the code

You would have to override the css for CodeMirror, because reveal css will change/modify the properties of div's and so on.
What you would have to alter is as follows:
.reveal .CodeMirror-lines {
    text-align: left !important;
    ......
    ......
}

Alter the CSS for getting the result, because, your CodeMirror is inside a reveal div and that will obviously add it's own css, like:
.reveal .slides {
    position: absolute;
    width: 100%;
    height: 100%;
    top: 0;
    right: 0;
    bottom: 0;
    left: 0;
    margin: auto;
    overflow: visible;
    z-index: 1;
    text-align: center;  /* Culprit -- changing the alignment */
    -webkit-perspective: 600px;
    perspective: 600px;
    -webkit-perspective-origin: 50% 40%;
    perspective-origin: 50% 40%;
}

Thanks.
But my problem is with the less trivial css than text-align.
As I mentioned above:

When trying to navigate the code with the keyboard arrows, it feels very weird
The cursor is not visible when editing the code

What css should I override to fix that?

You could try wrapping your editor instances inside web components. That should remove the problems caused by agressive, unscoped CSS in reveal.js.
But in general, I'm not taking responsibility for issues like this, produced by outside CSS. You'll just have to find the relevant properties and reset them in your own CSS.

Per @marijnh suggestion, I've tried to put my editor instance inside a web component but still some CSS is bleeding into the editor:

CodeMirror with reveal: you cannot move with arrows until the end of the line and you cannot insert a space.
CodeMirror without reveal: it works fine.

I know that it is probably an issue with reveal so I am reporting also in reveal repo.
Maybe you guys at CodeMirror can think of a workaround?

Moving with arrows or using space is related in to Reveal.js keyboard bindings.
https://github.com/hakimel/reveal.js/#keyboard-bindings
https://github.com/hakimel/reveal.js/blob/master/js/reveal.js#L4201
You need to be able to stop event propagation from CodeMirror editor in to Reveal.js handler.

@RopoMen Here is a version with a code mirror editor on slide 1 and a textarea on slide 2.
As you can see, inside the textarea, arrows and space work fine.

It's because
https://github.com/hakimel/reveal.js/blob/master/js/reveal.js#L4144
// Check if there's a focused element that could be using
// the keyboard
var activeElementIsCE = document.activeElement && document.activeElement.contentEditable !== 'inherit';
var activeElementIsInput = document.activeElement && document.activeElement.tagName && /input|textarea/i.test( document.activeElement.tagName );
var activeElementIsNotes = document.activeElement && document.activeElement.className && /speaker-notes/i.test( document.activeElement.className);

If you inspect DOM in first slide you can see that CodeMirror editor is not directly using input/textarea when content is edited. (if I'm correct)

I think that reveal.js should have attribute 'reveal-keyboard-off' and code should also check whether the element has that attribute. If it has, keyboard event handler should not do anything on those events.

Thanks a lot @RopoMen
It looks much better now.
But I'm still having weird issues. For instance, if you put the cursor at the beginning of (map inc [1 2 3]) and press the right arrow 8 times, the cursor will be at the beginning of the c - see screnshot below. And if you press space, a backspace will be added after the c.

In general, if you play a bit with arrows and spaces, you will feel that something is really not working well.
Do you know why it happens and how coud I solve it?

I have handled the keyboard binding issue by adding contenteditable="true". See https://github.com/viebel/klipse/commit/67b9abc2284aafb70057274c3cdc68e33c893968

@marijnh maybe you can help with this part of the problem that I mentioned above: https://github.com/codemirror/CodeMirror/issues/4189#issuecomment-271863685

I did see that on Reveal rules but I thought that it would not work because contenteditable would make the element editable, like
 or
 but it actually does not work like that with custom elements :) nice.
I have looked in to web components / custom html elements because to major benefit is the style isolation.

@RopoMen so why doesn't it work properly yet ?

@viebel
this works fine.
<klipse-snippet id="code" contenteditable="true"></klipse-snippet>

What I meant was that if you add contenteditable for example:

Edit me

Browser is making
 tag editable and browser is not making <klipse-snippet> editable in a same way. What I thought initially was that if you add contenteditable for the custom element, browser would make it editable in a same way as it was
 -tag.

I mean why do we still have this issue https://github.com/codemirror/CodeMirror/issues/4189#issuecomment-271863685
I'm so frustrated: we are so close but still not there!

@viebel I think I found something!
I get the problem you describe when I have the chrome inspector open.
But when I close the inspector/console... it works perfectly.
I think that CodeMirror calculates cursor/selection related things in a way that is affected by the changed size of the HTML area when the inspector is open????

Actually, it's a little more complicated than what I described above.
The cursor behavior is affected by the dimensions of the page.
Having the inspector open or closed affects the dimensions of the page... but any kind of resizing does as well. If the page is too narrow, the selection area is smaller than the real text. If the page is too wide, you cannot click on the text. I'll dig a bit deeper.

@viebel O.K. I got it to work...
I set these in the .adoc file
:revealjs_minScale: 1.0
:revealjs_maxScale: 1.0
This prevents the scaling when the screen is narrow or wide. The scaling does not play well with codemirror.


Update SD-JWT, Support encryption of SIOP responses

Why can't I shake the feeling, I've been here and seen this before?!

Maybe you're thinking of https://github.com/a-sit-plus/kmm-vc-library/pull/62


Pass user object to session callback

Summary of proposed feature
I'd like to augment the default data returned in the session payload. The session callback is a nice way to do this, but it would be more useful if you passed the user object through.
Purpose of proposed feature
Make it easier to customize the session payload.
Detail about proposed feature
Add a user param to the session callback.
Potential problems
If you're using jwt there is no user so this could complicate the function signature.
Describe any alternatives you've considered
I've thought about adding a separate endpoint to get additional session data but this seems redundant since I'm already fetching the session on each page.
Please indicate if you are willing and able to help implement the proposed feature.
Happy to submit a PR for this if it makes sense.

Thanks for capturing this @mwildehahn! I completely agree the User object should be supplied to the Sign In, Session and JWT callback (substituted for the OAuth or other Profile object if not using a database).
This is something I plan to resolve for v3 (the last major bit of work that I think is outstanding; behaviour in v3 has been impacted by other changes and needs review).
I'm trying to work out the best API for it right now to cater for all scenarios equally - so am starting with documentation that describes how it should work then refactoring the implementation accordingly.

Sounds good! I’m loving the library in general, let me know if I can help!
On Thu, Jul 23, 2020 at 6:04 AM Iain Collins<EMAIL_ADDRESS>wrote:

Thanks for capturing this @mwildehahn https://github.com/mwildehahn! I
completely agree the User object should be supplied to the Sign In, Session
and JWT callback (substituted for the OAuth or other Profile object if not
using a database).
This is something I plan to resolve for v3 (the last major bit of work
that I think is outstanding; behaviour in v3 has been impacted by other
changes and needs review).
I'm trying to work out the best API for it right now to cater for all
scenarios equally - so am starting with documentation that describes how it
should work then refactoring the implementation accordingly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/iaincollins/next-auth/issues/464#issuecomment-662994315,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFMAUN4G243J24CGI3AFR3R5AYONANCNFSM4PFFLL4Q
.

This should be resolved with the new callbacks in version 3.0!


Multi-GPU Training with DPO

I am trying to RLHF a Llama-7B using DPO, closely following this example. I also try to use both of my GPUs, with a config file that looks like this one. However, my GPU usage looks like the following
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 535.146.02             Driver Version: 535.146.02   CUDA Version: 12.2     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  Tesla V100-PCIE-16GB           Off | 00000001:00:00.0 Off |                    0 |
| N/A   31C    P0              36W / 250W |  10924MiB / 16384MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+
|   1  Tesla V100-PCIE-16GB           Off | 00000002:00:00.0 Off |                  Off |
| N/A   31C    P0              36W / 250W |    310MiB / 16384MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+

+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|    0   N/A  N/A     11149      C   /home/azureuser/miniconda/bin/python       5460MiB |
|    0   N/A  N/A     11150      C   /home/azureuser/miniconda/bin/python       5460MiB |
|    1   N/A  N/A     11150      C   /home/azureuser/miniconda/bin/python        306MiB |
+---------------------------------------------------------------------------------------+

At which point there is a CUDA out of memory error, presumably because the remaining VRAM on GPU0 is not enough to hold the DPO network and train them at the same time. So my question is---is it possible to load the trained model and the reference model separately (one on GPU0 and the other on GPU1)? Looking at the nvidia-smi output it seems like OOM happened because both models are loaded on GPU0, hence overloading the memory of that GPU. Am I misunderstanding something?

Hi @QiyaoWei
Thanks for the issue! I think if you load the active and reference model on different devices it will work out of the box
Can you try to load the active model with passing device_map={"": 0} and the reference model with device_map={"": 1} ? Make sure to use the latest TRL version from pypi as it includes a fix for multi-gpu
Moreover you can use a single model to get both the reference and active logits and speed up your training, you need to pass a peft_config to DPOTrainer and load your model with device_map={"": PartialState().process_index} and run your script with accelerate launch xxx.py after selecting "multi-gpu" when calling accelerate config from your terminal.
Let me know if anything is unclear.

@younesbelkada Many thanks for your help, and everything is super clear! I tried exactly device_map={"": PartialState().process_index} and the code worked out of the box, I didn't even have to use accelerate, just a normal python run was enough :)

Awesome, glad to hear that! Thanks and enjoy using TRL !

device_map={"": PartialState().process_index}

from accelerate import PartialState


Problem with join and grouping

Because of the excessive grouping the result is mingled. More details here:
http://stackoverflow.com/questions/7152453/problem-with-join

I'm closing as I believe this has been recently resolved. To test, please install from the current HEAD:
gem 'geocoder', :git => 'git://github.com/alexreisner/geocoder.git'

If I'm mistaken please re-open the issue, but it seems very similar to issue 140.


Incorect default value for decimal type

Default values table topic show 0.0M as default value for decimal type. For decimal type 0M and 0.0M have different binary representation and 0M is actual default value for decimal type.

Thanks for pointing this out, @PetSerAl. We'll update the documentation by December 1.


update  SidecarHealthHandler to handle the backend startup slow and connection between liveness and readiness

The fix is for the spring boot backend that starts too slow and the connection created between liveness and readiness are not usable.

 update SidecarHealthHandler to handle the backend startup slow and connection between liveness and readiness kafka-sidecar master


Issue 445 | Docker images on merge

Summary
Cleanup actions + release latest on merge to main
Details and comments
Closes #445

@psschwei  and @Tansito not sure how can I test it more, but I've tried local tests with https://github.com/nektos/act and everything seem to work

I do not think we will hit push limits :)

Random thought I had while building the GHAs for ICR: now that we're building the latest images on each push, should we think about dropping the nightly ones?

@psschwei @IceKhan13 sorry for the delay, was this last comment from Paul discussed? 🤔

I don't think so (or if it was, I've forgotten what we discussed :smile: )

Initiating the conversation in #621 , @psschwei


AWS Module Performs Lookup on allowed null variable "iam_role_additional_policies"

There is no requirement for a value on the AWS module, or the self-managed-node-group This line expects to process a variable. This results in the following error.
│ Error: Invalid value for input variable
│
│   on .terraform/modules/eks.eks/node_groups.tf line 336, in module "eks_managed_node_group":
│  336:   iam_role_additional_policies = lookup(each.value, "iam_role_additional_policies", lookup(var.eks_managed_node_group_defaults, "iam_role_additional_policies", {}))

modules/eks-managed-node-group/variables.tf:461,1-40: map of string required.
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/0e3cb9a0afcea87e1da0c87ecc969ffb963619ea/node_groups.tf#L336
@bryantbiggs When you developed this change, did you test it against this type of input where iam_role_additional_policies is undefined?
  eks_managed_node_group_defaults = {
  }

yes, I did - see the examples


Combine Stunnel with Rsync

This PR does the following:

Stunnel Configuration changes:

Removal of foreground = yes so that the stunnel process runs as daemon.
Addition of output = /dev/stdout for streaming of stunnel process logs as we are running the process in daemon mode.
Updating accept = localhost:2222 in order to facilitate data transfer between rsync and stunnel over the lcoalhost interface.

Transfer Image changes: These involve the addition of new packages/utilities used for embedding new workflow log in the container commands of rsync and stunnel.
Accommodate Stunnel alongside Rsync in the RunRsyncOperations phase:

Modifying getRsyncClientPodRequirements to have destination IP for rsync process as localhost.
Modifying  getRsyncClientPodTemplate :

To add Stunnel Volumes consisting of stunnel configuration file, stunnel certs as well as the volume called rsync-stunnel-ipc (used for facilitating inter-process communication between rsync and stunnel).
To add Stunnel VolumeMounts of stunnel certs, configs, rsync-stunnel-ipc.
To add rsync-stunnel-ipc alongside the PV involved in the migration of the application.
To add bash scripts for rsync container command as well as the stunnel contaienr command.
To add stunnel container manifest consisting of all the above changes stunnel changes.

Enhancement doc reference: https://github.com/konveyor/enhancements/pull/18
Dependent PRs: https://github.com/konveyor/rsync-transfer/pull/4

@alaypatel07 @pranavgaikwad Please take another look at this PR, I have updated it with the missing stunnel requirements, minor fixes as well as added unit tests for DVMP's getRsyncClientContainerStatus


Wrong version generation (1.3.0)

[Wed Dec 20] [10:40:28] - [~/maxim-ic/lde-3.0/TREE/user/buildroot/build/tpmtss-1.3.0/lib] - [change]  (polska) :
$ cat ./*
CFLAGS="-O0 -ggdb3 -DDEBUG_SOCKETS"
CXXFLAGS="-O0 -fno-operator-names -fpermissive -ggdb3 -DDEBUG -DDEBUG_SOCKETS"
Name: sapi
Description: TPM2 System API library.
URL: https://github.com/01org/TPM2.0-TSS
Version: 05.06.00
Cflags: -I/usr/include/sapi
Libs: -lsapi
Name: sapi
Description: TPM2 System API library.
URL: https://github.com/01org/TPM2.0-TSS
Version: @VERSION@
Cflags: -I@includedir@/sapi
Libs: -lsapi
Name: tcti-device
Description: TCTI library for communicating with a TPM device node.
URL: https://github.com/01org/TPM2.0-TSS
Version: 05.06.00
Requires: sapi
Cflags: -I/usr/include/tcti
Libs: -ltcti-device
Name: tcti-device
Description: TCTI library for communicating with a TPM device node.
URL: https://github.com/01org/TPM2.0-TSS
Version: @VERSION@
Requires: sapi
Cflags: -I@includedir@/tcti
Libs: -ltcti-device
Name: tcti-socket
Description: TCTI library for communicating with a TPM over a socket.
URL: https://github.com/01org/TPM2.0-TSS
Version: 05.06.00
Requires: sapi
Cflags: -I/usr/include/tcti
Libs: -ltcti-socket
Name: tcti-socket
Description: TCTI library for communicating with a TPM over a socket.
URL: https://github.com/01org/TPM2.0-TSS
Version: @VERSION@
Requires: sapi
Cflags: -I@includedir@/tcti
Libs: -ltcti-socket

while compiling tpm2-tools
I receive this error :
./configure: 11264: ./configure.lineno: AX_CODE_COVERAGE: not found
checking whether /usr/bin/make -j2 supports nested variables... yes
checking for pandoc... yes
./configure: 11344: test: xyes: unexpected operator
configure: WARNING: Required executable pandoc not found, man pages will not be built
checking pkg-config is at least version 0.9.0... yes
checking for SAPI... no
configure: error: Package requirements (sapi >= 1.3.0 sapi < 2.0.0) were not met:

Requested 'sapi < 2.0.0' but version of sapi is 05.06.00
You may find new versions of sapi at https://github.com/01org/TPM2.0-TSS

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables SAPI_CFLAGS
and SAPI_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
make[2]: *** [/home/change/maxim-ic/lde-3.0/TREE/user/buildroot/build/tpmtsstools-3.0.2/.stamp_configured] Error 1
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/change/maxim-ic/lde-3.0/TREE/user/buildroot'
make: *** [rootfs-build] Error 2
make: Leaving directory `/home/change/maxim-ic/lde-3.0'
ldecmd build usip-0.2.3: *** ERROR 2, command failed: make -C /home/change/maxim-ic/lde-3.0 rootfs
/home/change/bin/ldecmd v1.0.2: *** ERROR 2, command failed: build rootfs
/home/change/maxim-ic/lde-3.0/TREE/user/buildroot/build/tpmtss-1.3.0/lib

I guess reason is caused by wrong versioning of tss stack
[Wed Dec 20] [10:40:28] - [~/maxim-ic/lde-3.0/TREE/user/buildroot/build/tpmtss-1.3.0/lib] - [change]  (polska) :
$ cat ./*
CFLAGS="-O0 -ggdb3 -DDEBUG_SOCKETS"
CXXFLAGS="-O0 -fno-operator-names -fpermissive -ggdb3 -DDEBUG -DDEBUG_SOCKETS"
Name: sapi
Description: TPM2 System API library.
URL: https://github.com/01org/TPM2.0-TSS
Version: 05.06.00
Cflags: -I/usr/include/sapi
Libs: -lsapi
Name: sapi
Description: TPM2 System API library.
URL: https://github.com/01org/TPM2.0-TSS
Version: @VERSION@
Cflags: -I@includedir@/sapi
Libs: -lsapi
Name: tcti-device
Description: TCTI library for communicating with a TPM device node.
URL: https://github.com/01org/TPM2.0-TSS
Version: 05.06.00
Requires: sapi
Cflags: -I/usr/include/tcti
Libs: -ltcti-device
Name: tcti-device
Description: TCTI library for communicating with a TPM device node.
URL: https://github.com/01org/TPM2.0-TSS
Version: @VERSION@
Requires: sapi
Cflags: -I@includedir@/tcti
Libs: -ltcti-device
Name: tcti-socket
Description: TCTI library for communicating with a TPM over a socket.
URL: https://github.com/01org/TPM2.0-TSS
Version: 05.06.00
Requires: sapi
Cflags: -I/usr/include/tcti
Libs: -ltcti-socket
Name: tcti-socket
Description: TCTI library for communicating with a TPM over a socket.
URL: https://github.com/01org/TPM2.0-TSS
Version: @VERSION@
Requires: sapi
Cflags: -I@includedir@/tcti
Libs: -ltcti-socket

How can I fix this?
Thanks in advance.

By the way my package use compiled by buildroot
#############################################################
#
# tpmtss
#
#############################################################

TPMTSS_VERSION = 1.3.0
TPMTSS_SITE = https://github.com/intel/tpm2-tss.git
TPMTSS_SITE_METHOD = git
TPMTSSTOOLS_CFLAGS = $(TARGET_CFLAGS)
TPMTSS_INSTALL_STAGING = YES


Feat GitHub oauth 219

Basic reducer for logging in and logging out. Since we don't have a lambda function yet, the login page is broken and will throw an error

@BastinJafari I'll create a new api gateway endpoint with github authorizer for this testing to unblock you tomorrow.


Add Large investor profile to search pt 2

Description of change
This adds the large investor profile search views. It allows most fields to be filtered.
Checklist

[x] Has a new newsfragment been created? Check changelog/README.rst for instructions
[ ] Have any relevant search models been updated?
[ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[ ] Has the admin site been updated (for new models, fields etc.)?
[ ] Has the README been updated (if needed)?

Do we have tests for the view (including the filters)?

@reupen Lots of the tests that are already in place cover most things hence why I didn't add any. Will take a second look though and add some tests in.

@marcuspp do we need so many filters? We are trying to avoid adding more filters than we need (and index fields) unless absolutely necessary as it adds complexity, makes refactoring harder and therefore it's more expensive for DIT (we experienced it directly).
I remember you saying that there won't be many profiles if I'm not wrong?


Spec v3: fix conflicts with main and minor updates to match the current v3 spec

I merged master, fixed the conflicts and then made some small changes for consistency with the current v3 spec draft (see commits starting from d56d416).
I opened this PR for visibility/awareness, but you don't necessarily need to review anything at this point.
TODO:

[ ] Add unit tests and/or doctests in docstrings
[ ] Add docstrings and API docs for any new/modified user-facing classes and functions
[ ] New/modified features documented in docs/tutorial.rst
[ ] Changes documented in docs/release.rst
[ ] AppVeyor and Travis CI passes
[ ] Test coverage is 100% (Coveralls passes)

The Appveyor failure here is unrelated to the changes in the PR


Where are the TS types for Node?

I am using the library in Node with Typescript, but don't see types.
    "@lowlighter/xml": "^5.4.7",

I have tried using
npx jsr add @lib/xml

but the command fails:
> npx jsr add @libs/xml
Setting up .npmrc...ok
Installing @libs/xml...
$ npm install @libs/xml@npm:@jsr/libs__xml
npm ERR! Cannot read properties of null (reading 'matches')

Yes it seems so
I'm not entirely sure why (I'm a bit rusted on node + TS ecosystem since I mainly use TS runtimes now) but after generating types declarations with tsc mod.ts --declaration --emitDeclarationOnly --target esnext --allowImportingTsExtensions --moduleResolution bundler to create mod.d.ts and referencing the "types": "mod.d.ts" field in package.json, it is still unable to refer back to types
However I noticed that sometimes deleting the node_modules and reinstalling deps seems to prevent the error you mentionned from occured, but I'm not sure exactly why

If you bundle the .d.ts files and point to the types from the package.json it should work.
As a workaround you can use JSR @mabasic:
First add @jsr:registry=https://npm.jsr.io to .npmrc and then install with npm install @jsr/libs__xml.

The workaround does not work for me. I still get the same error:
> npm install @jsr/libs__xml
npm error Cannot read properties of null (reading 'matches')

@mabasic did you edit .npmrc?

@mabasic did you edit .npmrc?

Yes

Got it now to work, forgot to use pnpm since that is what I use xd


writeToFile function

create the writeToFile function that will take the user input and create the svg.

I don't think I can write any of this until I figure out how what to do with shape.js first :(

DONE!


add debug option: mount sources from host

...so one can easily debug builds by changing sources on host and not rebuilding the build image:
snippet
    # on osbs (builder)
    $ git clone https://github.com/DBuildService/dock.git /mnt/dock
    docker create -v /mnt/dock/dock:/usr/lib/python2.7/site-packages/dock --name dock_sources $image

    # osbs sources
    $ git diff
    diff --git a/osbs/build.py b/osbs/build.py
    index 163d03c..b2d8e66 100644
    --- a/osbs/build.py
    +++ b/osbs/build.py
    @@ -209,6 +209,13 @@ class SimpleBuild(BuildRequest):
             dj.dock_json_set_arg('postbuild_plugins', "store_metadata_in_osv3", "url", self.param['openshift_uri'])

    +@register_build_class
    +class DevBuild(ProductionBuild):
    +    """
    +    """
    +
    +    key = "dev"
    +
     class BuildResponse(object):
         def __init__(self, request):
             """

    $ cat inputs/dev.json
    {
          "metadata":{
            "name": "{{NAME}}"
          },
          "kind": "Build",
          "apiVersion": "v1beta1",
          "parameters": {
            "source" : {
              "type" : "Git",
              "git" : {
                "uri": "{{GIT_URI}}"
              }
            },
            "strategy": {
              "type": "Custom",
              "customStrategy": {
                "image": "buildroot",
                "exposeDockerSocket": true,
                "env": [{
                  "name": "DOCK_PLUGINS",
                  "value": "TBD"
                }],
                "volumeMounts": [{
                    "mountPath": "/usr/lib/python2.7/site-packages/dock",
                    "name": "dock_sources",
                    "readOnly": true
                }]
              }
            },
            "output": {
              "imageTag": "{{OUTPUT_IMAGE_TAG}}",
              "registry": "{{REGISTRY_URI}}"
            }
          }
    }
    $ ls -l inputs/dev_inner.json
    lrwxrwxrwx. 1 me me 15 Apr  9 17:15 inputs/dev_inner.json -> prod_inner.json

thanks @pbabinca

Looking at this now.
So, it would also be useful to extend this to host paths -- hostDir / hostPath (old name, new name, I think).
I'm trying to work out how the JSON should look in that case but finding it hard to discover the right documentation.
Where is the content of strategy documented?

@csrwng could you please help us here?
We would like to mount arbitrary paths from host to build container and we struggle with finding right docs for the build json.

@TomasTomecek we currently don't give you a way to specify volume mounts in a build definition. One way to get around this is to run a container from your custom builder container that will mount whatever local directory you like and do the build.

Hm, really? I know that @pbabinca managed to do the mounting, see my first comment. Am I missing something?

@TomasTomecek Are kubernetes secret volumes what we actually need for certificates and keys?

@TomasTomecek we don't have a volume mounts struct in the custom strategy: https://github.com/openshift/origin/blob/master/pkg/build/api/v1beta3/types.go#L198-L215. It won't fail if you have that in there, but it won't do anything.

I was chatting with @twaugh and it seems like what you need is to setup a secret if all you need is the pulp certificate/key pair

Secrets can now be mounted for build pods.


[PE-2161] Improve Cache Behavior

Description and related tickets, documents

Remove default cache at SparkDDFManager
Add cache for ApplySchema

Reviewers:

Main reviewer: @Huandao0812 @lebinh
Observers: @hai-adatao, @SeineRiver

Note:
This branch will continue working for any change of cache behavior in the future. So don't delete it after merge.
PR Progress
Make sure all checkboxes below are checked before merged

[x] Merge check has no conflicts. PR checks passed.
[ ] Main reviewer approved
[ ] Optional reviewer approved

@zkidkid I agree that the call to cache and materialize should be removed from copyFrom method but it shouldn't be put inside applySchema either and should be called from PE side. Also please find where are copyFrom being called in PE and add caching there at least until we finalise design + started working on the new caching behavior.

Per discussion this morning, this PR will now be closed in favor of https://github.com/ddf-project/DDF/pull/364


Nesting skips available space

Hi Jack, I was trying to nest a few 10X10 cubes into a 20X10 bin and the algorithm seems to skip the remaining space in the bin
Input:

Output:

Default config setting.
input svg:

Br

if your bin is exactly 10x20 there is some uncertainty in whether the part will fit. Maybe try making the bin 10.01x20.01

i tried with bigger 10.01X, 20.01, 10.05X20.05 and 10.05X30.05 with out any success

hm.. could you attach the svg?

<svg xmlns="http://www.w3.org/2000/svg" version="1.1" viewBox="0 0 170 30" preserveAspectRatio="xMinYMin meet"><polygon id="1" fill="none" stroke="blue" stroke-width="10" points="0,0  0,10  10,10  10,0  0,0 "></polygon><polygon id="2" fill="none" stroke="blue" stroke-width="10" points="10,0  10,10  20,10  20,0  10,0 "></polygon><polygon id="3" fill="none" stroke="blue" stroke-width="10" points="20,0  20,10  30,10  30,0  20,0 "></polygon><polygon id="4" fill="none" stroke="blue" stroke-width="10" points="30,0  30,10  40,10  40,0  30,0 "></polygon><polygon id="5" fill="none" stroke="blue" stroke-width="10" points="40,0  40,10  50,10  50,0  40,0 "></polygon><polygon id="6" fill="none" stroke="blue" stroke-width="10" points="50,0  50,10  60,10  60,0  50,0 "></polygon><polygon id="7" fill="none" stroke="blue" stroke-width="10" points="60,0  60,10  70,10  70,0  60,0 "></polygon><polygon id="8" fill="none" stroke="blue" stroke-width="10" points="70,0  70,10  80,10  80,0  70,0 "></polygon><polygon id="9" fill="none" stroke="blue" stroke-width="10" points="80,0  80,10  90,10  90,0  80,0 "></polygon><polygon id="10" fill="none" stroke="blue" stroke-width="10" points="90,0  90,10  100,10  100,0  90,0 "></polygon><polygon id="11" fill="none" stroke="blue" stroke-width="10" points="100,0  100,10  110,10  110,0  100,0 "></polygon><polygon id="12" fill="none" stroke="blue" stroke-width="10" points="110,0  110,10  120,10  120,0  110,0 "></polygon><polygon id="13" fill="none" stroke="blue" stroke-width="10" points="120,0  120,10  130,10  130,0  120,0 "></polygon><polygon id="14" fill="none" stroke="blue" stroke-width="10" points="130,0  130,10  140,10  140,0  130,0 "></polygon><polygon id="15" fill="none" stroke="blue" stroke-width="10" points="140,0  140,10  150,10  150,0  140,0 "></polygon><polygon id="16" fill="none" stroke="blue" stroke-width="10" points="150,0  150,10  160,10  160,0  150,0 "></polygon><polygon id="17" fill="none" stroke="blue" stroke-width="10" points="160,0  160,10  170,10  170,0  160,0 "></polygon><polygon id="" fill="none" stroke="blue" stroke-width="10" points="160,0 "></polygon><rect id="binRect" x="0" y="10" width="10.05" height="30.05"></rect></svg>

the underlying issue is that the clipper version of the minkowski sum sometimes generates small, spurious polygons (it's slightly noisy), and to remove these we have to filter out very small nfps that look like singularities. For a more direct solution you could try my other project deepnest.io that avoids this issue with a better minkowski library.
for svgnest it will generally not be able to place a part if the required space is tighter than one pixel. This is a trade off, as having a tighter tolerance would mean that sometimes parts would erroneously overlap. This particular svg is problematic because the parts are only 10px across, while the fit tolerance is calibrated for "real world" sizes where parts are greater than 72px or 1 inch in size. I would recommend scaling your parts up about 5x and ensuring the bin is at least 1px wider than the part at all points.
A simple solution to this would be to scale up all numbers in preprocessing, but this may take some work..

Thank you Jack for the help!


add isCloseTo assertion for Java 8 java.time.* types

Summary
Add isCloseTo assertion for java 8 java.time.* types the same way as for java.util.Date.
Preferably for all types of java.time package.
Most important types are:

[ ] Instant
[ ] LocalDate
[ ] LocalDateTime
[ ] LocalTime
[ ] ZonedDateTime

Example
Instant instant1 = Instant.now();
Instant instant2 = Instant.now();
assertThat(instant1).isCloseTo(instant2, 100); // 100 ms

Instead of:
assertThat(instant1.toEpochMilli()).isCloseTo(instant2.toEpochMilli(), within(100L));

which also is not null-safe.
Java 8 specific ?

YES : create Pull Request from the master branch

agreed.

Thanks to @fiery-phoenix pull request which added this for all  java.time.* classes supported by AssertJ I think this can be closed. Instant is no supported yet, but this should be a different issue I think.

agreed : https://github.com/joel-costigliola/assertj-core/issues/903


Fix misnamed trace stack usages in javadocs and variable names

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #56   +/-   ##
=========================================
  Coverage     99.11%   99.11%
  Complexity      617      617
=========================================
  Files            44       44
  Lines          1461     1461
  Branches        161      161
=========================================
  Hits           1448     1448
  Misses            4        4
  Partials          9        9

Impacted Files
Coverage Δ
Complexity Δ

...util/asynchelperwrapper/BiFunctionWithTracing.java
100% <100%> (ø)
10 <1> (ø)
:arrow_down:

...til/asynchelperwrapper/BiPredicateWithTracing.java
100% <100%> (ø)
10 <1> (ø)
:arrow_down:

...va/com/nike/wingtips/util/AsyncWingtipsHelper.java
100% <100%> (ø)
32 <7> (ø)
:arrow_down:

...s/util/asynchelperwrapper/FunctionWithTracing.java
100% <100%> (ø)
10 <1> (ø)
:arrow_down:

...asynchelperwrapper/SuccessCallbackWithTracing.java
100% <100%> (ø)
10 <1> (ø)
:arrow_down:

...s/util/asynchelperwrapper/SupplierWithTracing.java
100% <100%> (ø)
10 <1> (ø)
:arrow_down:

...m/nike/wingtips/util/AsyncWingtipsHelperJava7.java
100% <100%> (ø)
18 <8> (ø)
:arrow_down:

.../nike/wingtips/spring/util/WingtipsSpringUtil.java
100% <100%> (ø)
18 <3> (ø)
:arrow_down:

.../nike/wingtips/util/AsyncWingtipsHelperStatic.java
100% <100%> (ø)
32 <11> (ø)
:arrow_down:

...erwrapper/ListenableFutureCallbackWithTracing.java
100% <100%> (ø)
11 <1> (ø)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 420796d...e6946af. Read the comment docs.


Devfile public community registry goes live

Tracking work remaining work before devfile public community registry goes live (announcement):
P1:

[x] odo to move to the new registry (create PR on odo repo) (https://github.com/devfile/api/issues/367)
[x] Pre-transition period steps for the hosted devfile registry service (https://github.com/devfile/api/issues/376)
[x] Stack creator switch over (https://github.com/devfile/api/issues/391)
[x] Stability monitoring after odo PR merge (check if any of their PR tests hitting the live server)
[x] Registry update (starts with once per week) (https://github.com/devfile/api/issues/390)
[x] QE tests
[ ] Odo integration tests should use staging devfile registry (registry.stage.devfile.io) (https://github.com/openshift/odo/issues/4639)

P2:

[x] Stack addition/update request process (https://github.com/devfile/api/issues/390)
[ ] Documentation for stack requirement
[ ] Blog post on public registry (#408)
[ ] Stack issue tracking
[x] odo plan to GA with the new registry
[x] Odo URL migration (odo doc to clean existing preference)
[ ] Add devfile registry operator to OperatorHub (https://github.com/devfile/api/issues/410)

Closing this one off since public community went live. Any new work will be tracked by new issues.

Closing old item since the devfile community registry went live for a while already.


LibJS: Transition ModuleEnvironment bindings to HashMap for efficiency

This gives O(1) access to ModuleEnvironment bindings since it is only accessed by name.

@Imran-imtiaz48 please don't add LLM generated responses as a review.

Are you sure this leads to a performance improvement? Could you run some Kraken and/or Octane benchmarks and post the results?
You can do that using the scripts in the js-benchmarks repository. The commands you run will look something like this:
(checkout the master branch (without your changes) and build it)
./run.py --iterations 2 --warmup 3 --suites Kraken,Octane --output before.json

(checkout the branch with your changes and build it)

./run.py --iterations 2 --warmup 3 --suites Kraken,Octane --output after.json

./compare.py -o before.json -n after.json

Are you sure this leads to a performance improvement? Could you run some Kraken and/or Octane benchmarks and post the results?

None of the benchmarks in our js-benchmarks collection use JS modules, so there should be no real difference from these changes.
Regardless, a benchmark would be good here, to illustrate the improvement being made.
For non-module environment accesses, we use a form of caching (see the EnvironmentCoordinate caches for e.g GetById.) Those caches depend on having contiguous indexed storage and would not work with an associative container like HashMap. Are we sure using a HashMap is the best solution here?


feat(std):Eslint airbnb with reduce error

Why you wanna push to use semicolon in this starter kit?

Not sure what the objective of this PR is. If you'd like to resubmit with some details I'd be happy to discuss.

I wanna put airbnb style guide for starter kit


Added pdfs

👷 Deploy Preview for gladia processing.

Name
Link

🔨 Latest commit
43b8c324e1c2a691ab81a8bd11fd2f7e5531b8c3

🔍 Latest deploy log
https://app.netlify.com/sites/gladia/deploys/63f8bcfe6829e600085f5768


Coregistration failure - Rotation ?

As promised in #999, I'm opening a new issue for rotated coregistration with multi-echo. This is a problem I'm still seeing with the latest release (v. 1.0.15) and the same data set as shared previously on OpenNeuro:

The only thing I could think that's differing from my local execution and on OpenNeuro is that I'm using a previously computed FreeSurfer directory, though I'm not sure how it could be causing this issue.
Any (other) ideas where to start looking would be deeply appreciated !

Can you point me to these data on OpenNeuro?

This subject should be available here !


Dynamically update the transaction's BaseFee

Closes #88

Please take into account that although 100 stroops is the general convention for the base fee, a user could decide to use a higher amount, increasing the chances of getting the transaction settled into the ledger. Is the mentioned case implemented anywhere in the library?

Yes, sr. I'm planning to add some missing functions for:

bumping the sequence number
updating the transaction's base fee
adding a whole time bound (currently accepting a timeOut, without a lower time)

Let me create the issue


Fix | Fix unit test for SPN to include port number with Managed SNI

This PR is for the Unit Test for the fix of Issue #2187
This PR contains the unit test for the GetSqlServerSPN method inside MDS driver where when a tcp protocol and named instance is used in the data source, it used to return the named instance name instead of the port number.
This PR's unit test is testing TCP protocol with a Named Instance with or without a port number in a data source specified.

LGTM

LGTM

Are you going to approve?


Update to Jetty 9.4.12.v20180830

The test cipher ...
https://github.com/airlift/airlift/blob/bd1dffa179fa386b026d53ba476c39b861268dea/http-server/src/test/java/io/airlift/http/server/TestHttpServerCipher.java#L45
Is excluded by Jetty in 9.4.12.
Note: excludes always win over includes.
See:

Issue eclipse/jetty.project#2807 - Update default excludes for Jetty
Commit eclipse/jetty.project@5e07592a692e7400cd641e608decd8e0c942872d - for new exclusion list

@joakime thank you. Since ^TLS_RSA_.*$ is excluded in the latest Jetty version I updated the test CIPHER_1 to TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384.

I will follow up with @joakime about the implications of this change on our production config.

@dain Please review when you have a chance.

After reading jetty docs at https://www.eclipse.org/jetty/documentation/9.4.x/configuring-ssl.html
My understanding is that, to enable the non-FS ciphers, we need to call setExcludeCipherSuites. Doing this would override the default exclusions. After overriding the default exclusion, we can set the inclusions to our whitelist.
The way the code is currently written today, we always override both include and exclude. As a result, our production set up will happen to work.
https://github.com/airlift/airlift/blob/bd1dffa179fa386b026d53ba476c39b861268dea/http-server/src/main/java/io/airlift/http/server/HttpServer.java#L236
It was not our intention to override the default unconditionally. However, it was natural to believe that calling setExcludeCipherSuites with an empty list has no effect.
We probably want to change the default of our config parameter to match Jetty's default exclusion list, add test to make sure they are always in sync, and document the effect of setting the config property. (Note that doing so will lead to production breakage if we don't change our deployment configuration.)
The issue with the test is test-specific. We didn't call setExcludeCipherSuites there. https://github.com/airlift/airlift/blob/bd1dffa179fa386b026d53ba476c39b861268dea/http-server/src/test/java/io/airlift/http/server/TestHttpServerCipher.java#L184

@dain @haozhun added a new commit to update the default value of http-server.https.excluded-cipher.

Seems like @dain has merged this. @dain Can you please release a new version?


indexed assignment does not work with dimension name specification

Indexing by dimension names does not seem to work for LHS assignments:
julia> K = wrapdims(rand(2,2), x=1:2, y=1:2);
julia> K[x=1] .= 0
ERROR: MethodError: no method matching dotview(::KeyedArray{Float64,2,NamedDimsArray{(:x, :y),Float64,2,Array{Float64,2}},Tuple{UnitRange{Int64},UnitRange{Int64}}}; x=1)
Closest candidates are:
  dotview(::KeyedArray, ::Any...) at /home/takbal/.julia/packages/AxisKeys/G3Okw/src/struct.jl:137 got unsupported keyword argument "x"
  dotview(::Any...) at broadcast.jl:1160 got unsupported keyword argument "x"
  dotview(::BitArray, ::BitArray) at broadcast.jl:1130 got unsupported keyword argument "x"
  ...
Stacktrace:
 [1] top-level scope at REPL[182]:1

It works for NamedDims though:
julia> parent(K)[x=1] .= 0
2-element NamedDimsArray(view(::Array{Float64,2}, 1, :), (:y,)):
↓ y  0.0
     0.0

Looks like the reason is that the Base.dotview() specialization does not pass keyword arguments upwards.

That looks like a bug, indeed. I think there ought to be a method Base.dotview(A::KaNda; kw...) which looks up the names.

I believe the same goes for setindex!()


Bump console 2.10.21 and core 2.0.96 versions

Bump versions

console 2.10.21
core 2.0.96

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7204197504

Will be addressed with https://github.com/wso2/product-is/pull/18570. Hence closing the PR.

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7204197504
Status: success


fixing path to toc

This might be an issue where you've got the wrong path. If you start with a /, that creates a path relative to the site root. I've modified your path so that it's relative to the ToC. Let me know if this caused the nested ToC to work properly.

@EisenbergEffect,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:x: Validation status: errors

File
Status
Preview URL
Details

sandbox/TOC.yml
:x:Error

Details

:x:Error

Details

sandbox/TOC.yml

[Error] W:\xf52-s\sandbox\sandbox\demos\TOC.yml is not a valid TOC File: W:\xf52-s\sandbox\sandbox\demos\TOC.yml is not a valid TOC file.
[Error] W:\xf52-s\sandbox\sandbox\demos\TOC.yml is not a valid TOC File: W:\xf52-s\sandbox\sandbox\demos\TOC.yml is not a valid TOC file.

[Error] W:\xf52-s\sandbox\sandbox\demos\TOC.yml is not a valid TOC File: W:\xf52-s\sandbox\sandbox\demos\TOC.yml is not a valid TOC file.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


PLUGIN-1588: Make auth optional for Confluent Streaming Sink

PLUGIN-1588

Code LGTM. Can you add unit tests ?

Added. fa08e1d4d10b32e0860f2f584b3b6af7d8d56590

Commits have been squashed. 4ad9e470262d436893e9593948d99aeab8028823


docs: add 3d-view endpoint doc

@Anafabula unified the api docs, in the last days, your docs don't follow the new structure. Every page now hast an overview section at the beginning, https://naturerobots.github.io/HSOS-SEP-PlantMap-2022/reference/bed-plant-endpoints/#overview. And the headers after that use a real name instead of the URL. Could you change that?

@Anafabula unified the api docs, in the last days, your docs don't follow the new structure. Every page now hast an overview section at the beginning, https://naturerobots.github.io/HSOS-SEP-PlantMap-2022/reference/bed-plant-endpoints/#overview. And the headers after that use a real name instead of the URL. Could you change that?

I reworked the 3d-view to contain an overview like described and added a storage system section


two sessions uploading same file

As UniqueIdentifier is created by filesize and name, whenever two users upload same file, it corrupts both uploads and creates multiple files in output directory.

This seems like a problem wit the server-side implementation -- because uploading the exact same chunk twice for the same file shouldn't cause an issues; and two clients uploading the same file, with the same token should actually improve performance.

I'm deleting the temp files once the upload is complete. This causes an issue because file.1 gets deleted as soon as first upload is complete, thus making file.1 unavailable for second client.

Yeah, so that's probably the problem then, but that's mainly about then sharding the upload folder per user -- or allowing for simultaneous file uploads. We use the latter to great effect at TwentyThree, but the former may be a better option.


Helm updates for istiod cert

See individual commits for more details and justification.
Summary:

istio (upstream) uses "signature algorithm" frequently when it means "private key algorithm". We copy that for our "signature algorithm" value. Added a warning about that to avoid confusion.
Adds some comments and updates value descriptions to make what's happening clearer
Adds the ability to choose a private key algorithm for the istiod cert. Currently, it's only configurable globally for all kinds of certs.

/approve


GKE Auto detection for metric labeling

When running on GKE, it would be great to have automatic labeling for the metrics, similarly to how it is done for GCE.
It would be useful if on GKE we can set the resource to k8s_cluster/ k8s_node / k8s_pod / k8s_container.
Additionally, some attributes are worth having as resource labels: project_id, cluster_name, location, pod_name, node_name, namespace_name, container_name (e.g use case: multi-tenant clusters).
As reference, the resource labels for the GKE K8sContainer schema is defined as:

project: Immutable project number (gaia id) that uniquely identifies the project to which this container belongs.
location: The location (e.g. GCE zone or region) of the GKE cluster in which the container is located. It is immutable for the life of a container.
cluster_name: Immutable name of the cluster that the container is running in. The combination of project+location+cluster represent a globally (but not temporally) unique identifier for a cluster.
namespace: Immutable name of the namespace that the container is running in.
pod_name: Immutable name of the pod that the container is running in.
container_name: Immutable name of the container.

Similar to this enhancement; logging is also by default going to resource.type="gce_instance" which isn't ideal when running on GKE.

#622 should fix the logging issue for GKE.

Note that to access container_name, you'll need to set CONTAINER_NAME environment variable in your deployment config.


Use less stack intensive error mapping

closes: #2070

Great, I'll have to see if we can introduce downstream tests or include this one perhaps if it doesn't have too many other dependencies.

I'm using anchor 0.26.0 which is supposed to include the fix in this PR (?). However, cargo build-sbf still gives me similar error messages:

Error: Function ZN14solana_program4vote5state9VoteState11deserialize17hc24c28c4eff79cffE Stack offset of 6344 exceeded max offset of 4096 by 2248 bytes, please minimize large stack variables
Error: Function ZN229$LT$solana_program..vote..state..vote_state_0_23_5....$LT$impl$u20$serde..de..Deserialize$u20$for$u20$solana_program..vote..state..vote_state_0_23_5..VoteState0_23_5$GT$..deserialize..__Visitor$u20$as$u20$serde..de..Visitor$GT$9visit_seq17h90250e16ba5fe33dE Stack offset of 5752 exceeded max offset of 4096 by 1656 bytes, please minimize large stack variables
Compiling voting-app v0.1.0 (/Users/snawaz/projects/voting-app/programs/voting-app)
Finished release [optimized] target(s) in 2.19s

Implies, this PR doesn't fix in all places?

This was fixing a stack error that was showing up for a limited range of program for a very specific reason, it was introduced by a change made to anchor about showing errors.
No matter what anchor does as a dev you will always be able to exceed the stack. It's a memory buffer allowed to you by the solana runtime. If you're getting a stack error then you should follow the instructions and try to box accounts which will put them on the heap.
However, if there's a specific part of anchor you think might be causing this, like if there's some function or variables that are unnecessarily using up memory, then we definitely look at fixing that. You would need to help us in tracking down / narrowing where the excessive memory usage was coming from in the anchor lang/ directory.


The problem with document.write in iframe in Edge

The document.write causing the error SCRIPT70: Permission denied if you use a few document.write inside iframe. This error occurs only in the Edge. In all other browsers this error is not observed.
For example:
<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <title>SSP-558</title>
</head>
<body>
<script>
    document.write("1");
    document.write("2");
</script>
<script>
    var iframe = document.createElement("iframe");
    iframe.width = window.outerWidth;
    iframe.height = window.outerHeight;
    iframe.onload = function () {
        var doc = iframe.contentWindow.document;
        var script = doc.createElement("script");
        script.type = "text/javascript";
        script.text = [
            'document.write("1");',
            'document.write("2");'
        ].join("");

        doc.body.appendChild(script);
    };
    document.body.appendChild(iframe);
</script>
</body>
</html>

This code will display 12 on the page and in iframe, but it cause an error and displays only 1 inside iframe in Edge.

There was found a solution. If you add window in front of document.write the error will not be caused.
<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <title>SSP-558</title>
</head>
<body>
<script>
    document.write("1");
    document.write("2");
</script>
<script>
    var iframe = document.createElement("iframe");
    iframe.width = window.outerWidth;
    iframe.height = window.outerHeight;
    iframe.onload = function () {
        var doc = iframe.contentWindow.document;
        var script = doc.createElement("script");
        script.type = "text/javascript";
        script.text = [
            'window.document.write("1");',
            'window.document.write("2");'
        ].join("");

        doc.body.appendChild(script);
    };
    document.body.appendChild(iframe);
</script>
</body>
</html>

This is an issue with Edge. Can you please open a new issue here with the category HTML/DOM? https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/
Feel free to post on this thread the link to the issue you open.

Ok, I open a new issue in the category HTML/DOM issues#9291485

@CrazySquirrel Thanks! We'll monitor that issue. Closing this issue as External.


Forward-declare MSIDRequestContext in MSIDAccountCredentialCache.h

This protocol was neither forward-declared nor included by this header,
making it dependenant on its position in the include order of other files.
This change also sorts the forward-declared classes and symbols in this
file.

Thanks for the review! I'm not authorized to merge into dev, so if someone could merge and close this PR that'd be greatly appreciated!

@remyjette, can you please join the devs group?

Sent the request, good idea :)


Provide meaningful error message (UI) when django app is not configured correctly

If manage.py file does not exist (or path in launch.json is incorrect)
We can figure this out easily and should display a to the user.

Closing in favor of https://github.com/microsoft/vscode-python/issues/1670.


36 Megapixel image causes gd-png error: cannot allocate image data

Hello, I'm trying to integrate your class into a project where I've to work with some pretty big files.
The following code tries to resizes the $path image (32 bit PNG, ~11.000 pixel) to a 1000x1000 image:
$path="https://s3.eu-central-1.amazonaws.com/dw-uploads/photos/originals/3bd39e9fa22678933c7b7427237a715a";
$fs="test_local.png";

file_put_contents($fs, file_get_contents($path));

require_once '/home/simpleimage/SimpleImage.php';
$img = new abeautifulsite\SimpleImage($fs);
$img->best_fit(1000, 1000)->save($fs);
```

But fails with this error:

`Parse error: imagecreatefrompng(): gd-png error: cannot allocate image data in /home/simpleimage/SimpleImage.php on line 1105`

Even if the whole thing [should require less than 256MB](http://www.dotsamazing.com/en/labs/phpmemorylimit), my php.ini has `memory_limit = 512M`.

The main bugreport is: I think your class should throw an exception for this

Second bug: this smells like multiple object are being created. Could you please look into it?

Thanks!

It's not a memory leak. The GD library is notorious for using a lot of memory. Depending on your server, even 2-3MB images can throw that error.
It's also not something we can catch: http://stackoverflow.com/questions/2318858/how-to-recover-from-a-fatal-error-allowed-memory-size-exhausted
Normally you could just bump up the memory for PHP, but for gigantic images like that you may need to seek an alternative solution to GD. ImageMagick, for example—although I'm not sure it handles memory better when run as a PHP module.
— Cory LaViska
A Beautiful Site, LLC
www.abeautifulsite.net
On Sat, May 9, 2015 at 6:12 PM, Dr. Gianluigi Zanettini
<EMAIL_ADDRESS>wrote:

Hello, I'm trying to integrate your class into a project where I've to work with some pretty big files.
The following code tries to resizes the $path image (32 bit PNG, ~11.000 pixel) to a 1000x1000 image, but fails with this error:
Parse error: imagecreatefrompng(): gd-png error: cannot allocate image data in /home/simpleimage/SimpleImage.php on line 1105
Even if the whole thing (should require less than 256MB)[http://www.dotsamazing.com/en/labs/phpmemorylimit], my php.ini has memory_limit = 512M.
The main bugreport is: I think your class should throw an exception for this
Second bug: this smells like multiple object are being created. Could you please look into it?
Thanks!
Reply to this email directly or view it on GitHub:
https://github.com/claviska/SimpleImage/issues/81

acknowledged, thanks for your reply and explain!