Make find_part process only the requested block device

find_part() API should only look for partitions on block device it was asked to look at.
Signed-off-by: Pramodh Pallapothu<EMAIL_ADDRESS>

Seems I found the root cause of your problem: https://github.com/lf-edge/eve/pull/2506, please check

Now that https://github.com/lf-edge/eve/pull/2506 is merged is this no longer needed then? @zedi-pramodh @giggsoff

@rvs no #2506 will not fix this issue. I believe Petr was just suggesting that this issue can be fixed similar to #2506. Basically there are two ways to fix this issue and I picked the way of processing only requested disks, which I feel we should be doing anyway.

I am fine either way -- @giggsoff what's your preference?

@rvs no #2506 will not fix this issue. I believe Petr was just suggesting that this issue can be fixed similar to #2506. Basically there are two ways to fix this issue and I picked the way of processing only requested disks, which I feel we should be doing anyway.

If I correctly understood your problem, you saw that out for ... in did not iterate over $PARTS, but just use several parts in $p.
Expected:
$ DISKS=$(lsblk -anl -o "NAME,PARTLABEL"| awk '{print $1}' |grep nvme)
$ for i in $DISKS; do echo "/$i/"; done
/nvme0n1/
/nvme0n1p1/
/nvme0n1p2/
/nvme0n1p3/
/nvme0n1p4/
/nvme0n1p5/
/nvme0n1p6/
/nvme0n1p7/
/nvme0n1p8/

Broken version with modified IFS:
$ IFS=','
$ DISKS=$(lsblk -anl -o "NAME,PARTLABEL"| awk '{print $1}' |grep nvme)
$ for i in $DISKS; do echo "/$i/"; done
/nvme0n1
nvme0n1p1
nvme0n1p2
nvme0n1p3
nvme0n1p4
nvme0n1p5
nvme0n1p6
nvme0n1p7
nvme0n1p8/

So I am not sure what else we should fix.

@giggsoff problem seems to be that if you have drive names of  different lengths say sda, sdb, nvme0n1p4 etc and they have same partition name (config in this case). The following code is not parsing those properly.
PARTS=$(lsblk -anl -o "NAME,PARTLABE  2>/dev/null | sed -ne "/$LABEL"'$/s#'"[[:space:]]*$LABEL##p")
Basically $p will be one string "sda nvme0n1p4" which is wrong.
My fix is  to not even look for multiple drives since caller is explicitly asking for a specific drive.

@giggsoff problem seems to be that if you have drive names of different lengths say sda, sdb, nvme0n1p4 etc and they have same partition name (config in this case). The following code is not parsing those properly.
PARTS=$(lsblk -anl -o "NAME,PARTLABE 2>/dev/null | sed -ne "/$LABEL"'$/s#'"[[:space:]]*$LABEL##p") Basically $p will be one string "sda nvme0n1p4" which is wrong.
My fix is to not even look for multiple drives since caller is explicitly asking for a specific drive.

I cannot reproduce the problem (I use sda15 and nbd0 here, i.e. different length; and LABEL instead of PARTLABEL, but it should not have affect):
$ lsblk -anl -o "NAME,LABEL"
sda
sda1   cloudimg-rootfs
sda2
sda14
sda15  UEFI
nbd0   UEFI
nbd1
$ LABEL="UEFI"
$ PARTS=$(lsblk -anl -o "NAME,LABEL" 2>/dev/null | sed -ne "/$LABEL"'$/s#'"[[:space:]]*$LABEL##p")
$ for p in $PARTS ; do echo "/dev/$p"; done
/dev/sda15
/dev/nbd0

Again, $p was "sda nvme0n1p4" because of wrong separator (IFS).
Please check with #2506 merged.

I can reproduce every time on my system, I can try after 2506 merge, but might solve this issue, but the correctness is still not solved. The job of find_part() is to find partition on the requested disk. Current code is finding on all disks and then trying to filter it out. All I am doing is finding on the requested disk only.


Capability to fetch Snippets from sub-folder

Hi,
As it is a good practice to organize snippets in subfolders. Currently, the plugin picks up snippets from the defined parent directory and generates alfred-snippets.json. It will be amazing we can fetch snippets from sub-folder.
Thanks

@PKDmeDEV - I need this too, so I've created a PR:
https://github.com/ramandv/obsidian-snippets-manager/pull/5

Thanks @daniel347x . New version released 1.1.1


Missing null filter

The boolean filter checks whether a value is true or false.
There is currently no filter type to check whether a value is null or not.

A null filter has been introduced here.
field: {null: true} will return records where the field is null.
https://geolytix.dev/latest/api/layer/cluster/9.72?locale=UK&layer=retail_points&table=dev.retail_points&kmeans=0.04&dbscan=0.04&resolution=0.1&theme=categorized&cat=retailer&label_template=retail_points_label&filter={"locality":{"null":true}}&viewport=-1.0496563709540747,50.99878512228403,-0.03418362904592518,51.98296305654961
field: {null: false} will return records where the field is not null.
eg. https://geolytix.dev/latest/api/layer/cluster/9.72?locale=UK&layer=retail_points&table=dev.retail_points&kmeans=0.04&dbscan=0.04&resolution=0.1&theme=categorized&cat=retailer&label_template=retail_points_label&filter={"locality":{"null":false}}&viewport=-1.0496563709540747,50.99878512228403,-0.03418362904592518,51.98296305654961
A null filter has been added to retail_points layer in dev workspace.
https://geolytix.dev/latest?layers=mapbox_base,retail_points&lat=54.3&lng=-4&z=6.6


New version: Microsoft.BingWallpaper version <IP_ADDRESS>

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Resolve #184512

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.
Manual Validation

Microsoft Reviewers: Open in CodeFlow

[!WARNING]
This is another attempt. It may fail because of the exactly same reason.
There're already 3 attempts before:

#160817
#166300
#174665

I have a feeling this is gonna fail again.

[!CAUTION]
Close with reason: Unknown. Installer file detection blocked.

See https://github.com/microsoft/winget-pkgs/pull/184531#issuecomment-2424701864


Minor fixes

[x] Return URL
Return URL is not working, After we log in, It goes back to the dashboard.
http://localhost:5000/admin/login/?returnUrl=http://localhost:5000/admin/profile/

[x] Register
When we start fresh it goes to the /admin/ instead of /admin/register/

[x] Page URL
There shouldn't be a /posts/ before the slug of the page. It should be:
http://example.com/title-of-the-page

[ ] Default Cover
Add the default cover back to the settings,
so that admin can change the default cover.

[ ] Localizer on the themes
not working, please check.

[x] Search bug
When we search in the blog posts, we see results from pages as well. they need to be separated completely.

..
Add more minor details that are left to do here.

https://github.com/blogifierdotnet/Blogifier/pull/293
This pull request will fix bugs 3 (Page URL) and bug 6 (Search Bug)
In startup.cs I had to switch the order of services being loaded so urls like /admin will still resolve correctly instead of going to the Home controller Index action.
Refactored the Home Controller to two methods, getSingleBlogPost and Get BlogPosts.

I forgot to note, this will also fix Pages' metadata urls

Alright sorry about all the mess, this pull request will fix # 3 and # 6 from the list above.
Had to do some small hackery to make sure we weren't hijacking the /admin route from razor
https://github.com/blogifierdotnet/Blogifier/pull/295

@fullreboot Thank you, we review it this week.

@farzindev
I found another small bug. For some reason routing of /admin or /admin/ gets routed differently. Sometimes it get "stolen" by MVC home controller

The bug previously mentioned has been fixed and is pushed to the PR. If this is an unacceptable hack please let me know.

Hey @rxtur, Please review this, Thank you.

Hi, I see several more small issues.

When I logged in into admin panel and switching tabs(dashboard/blog/pages...) after once clicking on 'pages'
the tooltip icon is always show under 'pages' and 'blog' tabs until refresh page.

Create new 'page', save it, then publish it and go to that page. On that page cover image is broken 'src="//http://localhost:3169/img/cover.jpg"'

@farzindev the default cover image is showing, but this picture should change after clicking on it. I think this feature has bugs.


chore(main): release ngx-intl 2.2.0

:robot: I have created a release beep boop
2.2.0 (2023-09-13)
Features

support strings as inputs for date pipes (#24) (19d9f5e)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/haiilo/ngx-intl/releases/tag/ngx-intl-v2.2.0 :sunflower:


Bug: Validation breaks when widgets have no features

Discovered in v0.5.0-alpha.0. If a widget.json has no features, the validation function in validatePageFeatures() is undefined. Handle this case by only calling it if it is defined.

Implemented on master (v0.5.0)


GitHub Raffle at Collision 2023 - Leave a comment to enter

GitHub Raffle at Collision 2023!
🎫 To enter the draw, add a comment at the bottom of this issue 👇
🏆 The prize draw will be drawn at the GitHub Booth at 12pm on Thursday June 29th
A couple of T&C's:

Entry into this raffle will NOT constitute your consent to be contacted for anything else
We will not be adding you to our marketing database (but if you want to subscribe to our newsletter, you can do so here)
The raffle prize cannot be swapped or changed,
The winner of the prize at Collision 2023 MUST be present when we draw a winner, otherwise we will redraw!

Good luck!

:pray: Huge shout-out to @icelam for a great and simple name picker we could fork and use for the GitHub booth!
:rocket: This site is deployed to GitHub Pages using GitHub Actions. The Actions workflow pulls entrants from commenters of a GitHub Issue.

Thanks. Awesome opportunity

Thanks for the chat.

Nice 👍

🙏

Omg, so awesome, can’t wait

Great booth!

Great booth!

Looking forward to the copilot talk!!!

Visited the booth!

Good luck all

Booth was awesome!

You are the best

🔥🔥🔥🔥

Cat rules the world!

awesome!

Like the hat at the booth  ;)

🥳🥳🥳

Awesome!! 💪❤🔥

Henlo World!

Hello!!

Great 👌👌

I like it!

Let's go GitHub!

Test comment

At the booth

AI!!

Hiiiii

Hello!

🔥🔥🔥

Great hat!

Awesome swag!

Great booth!

Loved the co-pilot conversation

Thank you for the lovely chat :)

love this!

Amazing

Swag me 🍕

Delighted to see you at event

❤ github

I'm in!

🚀🚀🚀

I'm going to win.

😎😎

Great connecting with you all at Collision 💥

Thanks!

Great connection  with you at collision

Thanks GitHub!

Copilot is the best!

Hallo

Hello, World!

Booth was great!

Github! ❤

Nice meeting you!

Thanks for the chat

thanks!

hello world

Thanks GH!

❤❤❤

Great booth!

💜💜💜

Great conference

Thanks for the opportunity :)

Thank you! :)

Awesome thanks!

Enjoyed visiting your booth! Thank you!

Great booth experience !

Jason Etcovitch is awesome 👯

I love GitHub! ❤

Best version control system! 🤗

Yooo, gg folks

Love github best platform

LGTM

Nice to meet you!

thanks!!

LGTM!

Collision 2023 🔥

yessirrrrr!!!!🫶🏼🫶🏼

Thanks for the chat :)

Cool beans!

Awesome!

So cool!

Github rocks! 👍

Thanks 😊

Yay!!

super cool

LETS GOOOOO

here at collision!

So cool! Great to meet you 🎉

🔥

Psych!!

Github is lit🔥🔥🔥

Ellie

LGTM 🫡

Awesome ❤

Commit push!

Great booth

Lets build from here.

Love the mugs 😃

Sweet! Thank team! 🔥

Yay! Can finally comment! Pick me please!

I love GitHub ♥

Woooo 🥳

GitHub Usage is daily

Epiiic!

Colliding with GitHub 🥰

Awesome!

Yes pls

Github!!! 💜💜💜

It was really good talking with you Jason.

Committing

Gotta get the 💼

Kool Ppl

Looks good to merge

Looks good to merge

Looking forward to some swag!

Collision!🚀

Collision

Collision 4tw

Woohoo let's go!

yay let’s go!

I love GitHub too

Github A+

love github!

git commit -m "I love GitHub"

Cool!

The stall with the maximum crowd. My stall was right in front and could not get the goodies. Such was the crowd

Github is very Useful

GitDrawme

:) awesome!

Thanks GitHub!

 Raffle. Winner!!!

Visited the booth! Have a good conference!

Hello from Collision 2023

I want GitHub to be my Copilot #collision2023

Hi guys! It was great to chat with you today.

Hi guys! It was great to chat with you today.

Hey! Raymond here!

Hello! Slesha here :)

LETS GOOOO!!

😎

Gimme Dat swag for my Github rep!

Thank you for the GitHub swag 😊

Mohit raised a PR!! GitHub please approve and merge ✌🏼

Github swag!!

cool

Awesome!

Get me that prize!!

Participating!

Good luck to all 🩷

V cool!!

Hello!

Good luck to everyone!

It was great meeting you all! 🥰

Great to meet you guys!!

Thankk youu!

Good luck to y'all!

Hiii

Hello world

Hello world indeed

Howdy! Great meeting ya guys! 👋

Hii!

Hey it was nice meeting you!!

Great chatting with you at Collision!

Great meeting you guys😀

It was nice meeting you guys!

For the ruffle!

Thanks

Holla

🤙

Hey guys!

Nice chatting with you!

I have enjoyed the GitHub lot, feels to have worth

It was great to meet you at collision!

Was at Collision!

thanks!!

Hello GitHub

Let's win!

Hello from Doc Clik

#octocat4life

Thanks so much for hosting this raffle! <3

collision ting

Hello World @Collision

Comment

Let's gooo!

🤓

Thanks for this amazing activity. Let's wait for results.

😺

Github merchandise is the best!

Swag looks sick 😎

Trying for the swag 🤷♂

I need to git this swag bag 😂

Hello from after the after-party

hello from collision conf

Noone will read this comment. Hi mom!

Woohoo!

Heeey!

in for one!

Can't wait!

Pick me plz

🐈⬛

Pick me pick me

Big fan 👾

Cool!

🤔

git please pick me as raffle winner 🤭

hello world, pls pick me thx 👍🏻🫶🏼🫂

pickMe()

hello world 🥰

Hello Github!

Hi!

hi!

Great times at Collision!

Thank you!

Collision 2023!

Console.log(I win)

Raffle in ~13minutes! Head over to the GitHub booth (E303) to be eligible to WIN!

woot!! let’s go collision!

🤞🏻🤞🏻🤞🏻

Raffle in 9. Im gonna win Gig!

Confirm!

Comfiem

Thank you for the opportunity!!!

Lets go!

Win

Timothy Han

Enter :)

thanks!

Special shoutout to @danielljeon for winning the timbuk2 backpack grand prize ✨

Who won??


Add unarmed stage to explosive banana peel

About the PR

Added an unarmed step to the explosive banana peel where it looks almost like a normal banana. It can be opened to reveal the expected peel.
Why / Balance

Someone exploded to death when they stepped on their surplus and died. This prevents that happening again by requiring an intentional action to arm it.
Technical details

Moved explosive banana peel from produce.yml to funny.yml.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl: crazybrain

tweak: Explosive banana peel can no longer spawn in a surplus crate.

see also #17243

honk

It should come in self-disposing packaging instead, like the exploding pen

why not make it an actual banana with the explosive peel as trash, so you get a snack too

why not make it an actual banana with the explosive peel as trash, so you get a snack too

My reasoning was you might accidentally eat the bomb or something.

dawg you messed up the changelog

ouuuuuuuhhhhhhhh

dawg you messed up the changelog

I'm such a goober


[Proposal] Enhance the Hashable protocol

This proposal introduces a new Hasher type representing the standard library's universal hash function, and it extends the Hashable protocol with a new hash(into:) requirement that expresses hashing in terms of Hasher. This new requirement is intended to replace the old hashValue property, which is deprecated.

This looks super awesome, great job.  This is the first I'm seeing of this, a few random questions/comments:

Would it be useful for Hasher to have an additional init that gives a new random seed value, not an explicitly specified one, or the executions shared random seed value?

I can see where append(bits:) is a coming from, the the name is a bit misleading - there is no appending happening.  Is there a standard name for the operation?  Something like mixIn(bits:) or combine(bits:) might work better.

😍😍😍
I'm so happy to see this happening!
@lorentey I'll have to buy you a drink, next time we meet!


Docker image have issues loading libmultihash

Description
Built the code as a docker image using .net5 failed to load libmultihash at runtime.
Steps to Reproduce
Launching Miningcore.dll from docker image fails to load libmultihash.
Expected behavior
Should launch pool without any errors
Actual behavior
Fails with error as in description.
[2021-06-15 01:18:19.7255] [E] [eth1] System.DllNotFoundException: Unable to load shared library 'libmultihash' or one of its dependencies. In order to help diagnose loading problems, consider setting the LD_DEBUG environment variable: liblibmultihash: cannot open shared object file: No such file or directory   at Miningcore.Native.LibMultihash.ethash_get_default_dirname(Byte* data, Int32 length)
at Miningcore.Crypto.Hashing.Ethash.Dag.GetDefaultDagDirectory() in /src/src/Miningcore/Crypto/Hashing/Ethash/Dag.cs:line 34
at Miningcore.Blockchain.Ethereum.EthereumJobManager.Configure(PoolConfig poolConfig, ClusterConfig clusterConfig) in /src/src/Miningcore/Blockchain/Ethereum/EthereumJobManager.cs:line 425
at Miningcore.Blockchain.Ethereum.EthereumPool.SetupJobManager(CancellationToken ct) in /src/src/Miningcore/Blockchain/Ethereum/EthereumPool.cs:line 369   at Miningcore.Mining.PoolBase.StartAsync(CancellationToken ct) in /src/src/Miningcore/Mining/PoolBase.cs:line 351 System.DllNotFoundException: Unable to load shared library 'libmultihash' or one of its dependencies. In order to help diagnose loading problems, consider setting the LD_DEBUG environment variable: liblibmultihash: cannot open shared object file: No such file or directory
at Miningcore.Native.LibMultihash.ethash_get_default_dirname(Byte* data, Int32 length)
at Miningcore.Crypto.Hashing.Ethash.Dag.GetDefaultDagDirectory() in /src/src/Miningcore/Crypto/Hashing/Ethash/Dag.cs:line 34
at Miningcore.Blockchain.Ethereum.EthereumJobManager.Configure(PoolConfig poolConfig, ClusterConfig clusterConfig) in /src/src/Miningcore/Blockchain/Ethereum/EthereumJobManager.cs:line 425
at Miningcore.Blockchain.Ethereum.EthereumPool.SetupJobManager(CancellationToken ct) in /src/src/Miningcore/Blockchain/Ethereum/EthereumPool.cs:line 369   at Miningcore.Mining.PoolBase.StartAsync(CancellationToken ct) in /src/src/Miningcore/Mining/PoolBase.cs:line 351    at Miningcore.Native.LibMultihash.ethash_get_default_dirname(Byte* data, Int32 length)
at Miningcore.Crypto.Hashing.Ethash.Dag.GetDefaultDagDirectory() in /src/src/Miningcore/Crypto/Hashing/Ethash/Dag.cs:line 34
at Miningcore.Blockchain.Ethereum.EthereumJobManager.Configure(PoolConfig poolConfig, ClusterConfig clusterConfig) in /src/src/Miningcore/Blockchain/Ethereum/EthereumJobManager.cs:line 425
at Miningcore.Blockchain.Ethereum.EthereumPool.SetupJobManager(CancellationToken ct) in /src/src/Miningcore/Blockchain/Ethereum/EthereumPool.cs:line 369   at Miningcore.Mining.PoolBase.StartAsync(CancellationToken ct) in /src/src/Miningcore/Mining/PoolBase.cs:line 351
Reproduces how often
Everytime
Version
Latest version
Additional Information
Dockerfile
FROM mcr.microsoft.com/dotnet/aspnet:5.0 AS base
WORKDIR /app
FROM mcr.microsoft.com/dotnet/sdk:5.0 AS build
WORKDIR /src
COPY ["src/Miningcore/Miningcore.csproj", "src/Miningcore/"]
RUN dotnet restore "src/Miningcore/Miningcore.csproj"
RUN apt-get update -y &&
apt-get install -y --no-install-recommends apt-transport-https cmake build-essential libssl-dev pkg-config libboost-all-dev libsodium-dev libzmq5
COPY . .
WORKDIR "/src/src/Miningcore"
RUN dotnet build "Miningcore.csproj" -c Release -o /app/build
FROM build AS publish
RUN dotnet publish "Miningcore.csproj" -c Release --framework net5.0 -o /app/publish
COPY ["src/Miningcore/config.json", "/app/publish/"]
FROM base AS final
WORKDIR /app
COPY --from=publish /app/publish .
ENTRYPOINT ["dotnet", "Miningcore.dll", "-c", "config.json"]

That because neither the docker image nor Ethereum have been maintained for a long time. The latter is already gone from the latest release and I think the docker image should be scrapped too.

Tracked in #844


Usage of Azure functions

The architecture diagram shows  5 Azure functions. From Azure resource group, there are only three Azure functions created , pls see below. Can anyone explain?

Hi @tomatosis ,
To handle the backend services, we have the 3 durable azure functions

Prep-Function:- Prepares the message

Send-Function:- Send the message to the users and picks the message from the service bus one-by-one and the messages will be delivered to the respective users.

Data-Function:- This function gives the acknowledgement saying that message got delivered or not.

Export-Function:- This function exports notification in a zip file for the admin. It prepares the file by reading the notification data, user graph api. This is a part of prep-function only.

Clean-up function:- This deletes the files in Azure Blob storage and file cards sent to users. This is a part of Data function only.

Hope it helps.

@gsv022
Thanks for sharing.
However, my question is why we don't see Export-Function and Clean-up Function when we setup the company communicator using the code provided?

Hi @gsv022 ,
Attaching the screenshots for the reference.

Export Function:-

Clean-up Function:-

Hope it conveyed.

Hi @gsv022,
Thanks for the explanation.
You may close the case.


[Enhancement] Access to iCloud /local Library

Is your feature request related to a problem? Please describe.
Would be nice if i can access my owned Music associated with my apple id without a Apple Music subscription.
Right now i have my songs synced through the icloud and this makes it available for all my (apple) devices.
I use a Macbook, iPhone, iPad and a Windows PC. I can access my Music on all Apple Devices using the Music App except on my Windows PC where i have to use iTunes.
iTunes seems to be not be further developed by Apple so i search for alternatives on Windows ...
This "Apple Music Electron App" for Windows seems to be the perfect fit.
thanx
Christian

This app will be sunseted very soon and we are NOT maintaining this app
unless of a security issue. We encourage you to try Cider, our new music app built from scratch. Issues filled on that repository will be seen and will be acted upon. Please join our discord and see the #nightly-builds channel for a current build.
Cider can be found here


Anchors

Anchors are ways of directing child elements to resize when the parent does allowing for stages to be dynamically filled.
For example, you could set the anchor to 'right-1' and the anchor would keep the right side of the child (X + width) 1 pixel away from the parents edge. It would do this first by trying to reduce the X. If the X has an anchor and its rule already applies then the width will be reduced
Possible settings:

left
right
top
bottom

The plan is nearly complete but has changed from above. Instead the Anchors will function like CSS 'position: absolute' with the addition of min and max properties.
Expect the update to be pushed within 3 days.

Anchor settings of
panel:createAnchor {
    right = 1,
    left = 1,
    bottom = 1,
    top = 1,

    maximumWidth = 40,
    minimumWidth = 5,

    minimumHeight = 5,
    maximumHeight = 10
}

give this result:
http://puu.sh/n5WXY/1165df0704.gif

Commit https://github.com/HexCodeCC/DynaCode/commit/d5f7b74d680be28a75f010230280661b0a6b7d51 closes this issue.


clonehero: fix invalid url

Description of changes
Updated the URL to latest release from github, since pubdl.clonehero.net is not available anymore, and is not the primary mirror for this program's download.

Homepage: https://github.com/clonehero-game/releases
Things done
in src changed https://pubdl.clonehero.net/clonehero-v${finalAttrs.version}-final/clonehero-linux.tar.xz to https://github.com/clonehero-game/releases/releases/download/V<IP_ADDRESS>80/CloneHero-linux.tar.xz
Didn't need to update the hash, as they both have the same hash.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thanks!


Error: uplink: bucket: metainfo error: context canceled

Can't provide a reproduce use case, only the error.
Using Nextcloud Desktop client.
# gateway version
Release build
Version: v1.1.8
Build timestamp: 01 Oct 20 12:29 CEST
Git commit: 5a1e6724b1f1258d6730633c2058f10ac3b84018

API: GetObject(bucket=cloud-org, object=urn:oid:65062)
Time: 14:57:03 CEST 10/07/2020
DeploymentID: 29d7da1e-e8c5-43d9-b295-c196952ee847
RequestID: 163BB70E0836A3E3
RemoteHost: <IP_ADDRESS>
Host: <IP_ADDRESS>:7777
UserAgent: aws-sdk-php/3.133.27
Error: uplink: bucket: metainfo error: context canceled
       4: /go/pkg/mod/github.com/minio/minio@v0.0.0-20200808024306-2a9819aff876/cmd/api-errors.go:1980:cmd.toAPIErrorCode()
       3: /go/pkg/mod/github.com/minio/minio@v0.0.0-20200808024306-2a9819aff876/cmd/api-errors.go:2005:cmd.toAPIError()
       2: /go/pkg/mod/github.com/minio/minio@v0.0.0-20200808024306-2a9819aff876/cmd/object-handlers.go:420:cmd.objectAPIHandlers.GetObjectHandler()
       1: net/http/server.go:2042:http.HandlerFunc.ServeHTTP()

"context canceled" typically means a network timeout, and is an expected occasional error.  Have you had any issues since seeing this error?

Sorry, i've switched to Uplink only, had too much issues with the Gateway.
Closing for now, if someone wants to reopen, feel free to do it.


How to add a image headerView ?

I want  to add a 150x150 image at the top of the formviewcontroller, how could I ?

Sorry there is no easy way to do it.

Take a look at the CustomViewController.swift file.
The CustomFormItem is used to create instances of the LoaderCell.
Replace LoaderCell with your own custom cell containing a UIImageView.

In the future, adding a dedicated imageview that seems like a good idea.


Add telemetry for updating Advanced data options

Model Builder Version: In which Model Builder version was the bug encountered?
Visual Studion Version: In which Visual Studio version was the bug encountered?
Bug description
A clear and concise description of what the bug is.
Steps to Reproduce

List the minimal steps required to reproduce the bug.
Thanks for reporting!

Expected Experience
A description of what you expected to happen. If applicable, add screenshots or "Machine Learning" Output Logs to help explain what you expected.
Actual Experience
A description of what actually happens. If applicable, add screenshots or "Machine Learning" Output Logs to help explain what actually happened.
Additional Context
Add any other context about the problem here, such as unusual system configurations, network restrictions, etc.

Ensure we don't have 4 telemetry events - either split to smaller events or have only the one large event.


Update/Add git upstream to an existing project

Depends on github.com/keptn/go-utils/pull/169
Resolves Issue https://github.com/keptn/keptn/issues/1517

@johannes-b @bacherfl Could you take a look into it if I should change something?

Hi, I reviewed the code and it looks good from my perspective (please just address the two commands). However, let's wait for @bacherfl's feedback as he knows best the details about locking a project when executing a git command.

Codecov Report

Merging #1887 into master will increase coverage by 0.62%.
The diff coverage is 57.59%.

@@            Coverage Diff             @@
##           master    #1887      +/-   ##
==========================================
+ Coverage   32.21%   32.84%   +0.62%
==========================================
  Files          99      141      +42
  Lines        7673     8495     +822
  Branches        0      116     +116
==========================================
+ Hits         2472     2790     +318
- Misses       4883     5352     +469
- Partials      318      353      +35

Flag
Coverage Δ

#moduleA
36.85% <88.23%> (?)

Impacted Files
Coverage Δ

bridge/client/app/app.module.ts
100.00% <ø> (ø)

cli/cmd/install.go
24.37% <0.00%> (ø)

cli/cmd/onboard_service.go
24.28% <0.00%> (ø)

configuration-service/common/git.go
2.84% <0.00%> (-0.21%)
:arrow_down:

remediation-service/main.go
6.61% <ø> (ø)

helm-service/controller/action_handler.go
41.89% <7.69%> (-2.79%)
:arrow_down:

api/handlers/configure.go
13.08% <50.00%> (+0.36%)
:arrow_up:

cli/cmd/configure_monitoring.go
61.66% <50.00%> (ø)

cli/cmd/create_project.go
62.33% <50.00%> (ø)

cli/cmd/create_service.go
47.22% <50.00%> (ø)

... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72a4c11...9ba2aad. Read the comment docs.


Docs

github.io site with examples for each component

[x] basic Figure example
[ ] Collection examples


Make directive compatible with NgModelController so it works with forms

Hi there,
I wanted your multiselect to be able to take advantage of built-in Angular forms functionality like $dirty and $pristine states, validation, and whatnot, so I made your directive compatible with NgModelController (see the "Implementing custom form controls" section of the Angular guide). This change also makes your component compatible with, say, angular-unsavedChanges.
It's (hopefully) fairly straightforward, requiring ngModel and using NgModelController.$viewValue and NgModelController.$setViewValue() instead of selectedModel .
However, it is a breaking change in that all consumers must set the ng-model attribute instead of the current selected-model attribute (which is removed). This behavior is consistent with standard form Angular controls, so hopefully makes for more standard usage.
Thanks!

Just plain awesome !
Thanks a lot for sharing this.
kbjp

Thanks for the kind words @kbjp!

Are there any plans to merge this PR?

:+1:


SNOMED CT codes (IP issue) (Hackathon)

diseases.js  object exposes a lot of SnomedCT codes
Proper implementation would allow any condition to be used.
This would require whole SNOMED CT terminology.
This is subject to a license and should be used, but not so easily obtainable (in developer console - for example)

Cleaning up old issues: Yeah, there are way too many diseases in a terminology like SNOMED to use.  The current list was designed by a committee, but can be revisited in the future.


Fix small typo

Proposed changes

Add the word "to" in sentence

Merge timing

ASAP once approved

This line looks good to me as is, so I'm going to close this one out.


SN1 & SN2

Add compatibility with SN1 and SN2
-- Need to determine the best way to estimate the lines (could use non-ML method)

The non ML method is implemented and the lines in SN1 and SN2 have been added. Need to make it clear to users how to go about this.


Compile fails with 'error: format not a string literal and no format arguments'

Compiling src/Band/band.cpp to CMakeFiles/sirius.dir/Band/band.cpp.o fails with the following:
[ 13%] Building CXX object src/CMakeFiles/sirius.dir/Band/band.cpp.o
cd <builddir>/sirius/obj-x86_64-linux-gnu/src && /usr/bin/c++  -D__PROFILE -D__PROFILE_TIME -D__USE_MEMORY_POOL -D__USE_TIMER -I<builddir>/sirius/obj-x86_64-linux-gnu/src -I<builddir>/sirius/src/SDDK -I<builddir>/sirius/src -I<builddir>/sirius/src/. -isystem /usr/lib/x86_64-linux-gnu/openmpi/include -isystem /usr/lib/x86_64-linux-gnu/openmpi/include/openmpi -isystem /usr/include/hdf5/serial  -g -O2 -fdebug-prefix-map=<builddir>/sirius=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -fPIC -fvisibility=hidden   -fopenmp -std=gnu++14 -o CMakeFiles/sirius.dir/Band/band.cpp.o -c <builddir>/sirius/src/Band/band.cpp
In file included from <builddir>/sirius/src/K_point/k_point_set.hpp:28,
                 from <builddir>/sirius/src/Band/band.cpp:27:
<builddir>/sirius/src/K_point/k_point.hpp: In instantiation of ‘void sirius::K_point::message(int, const char*, Args ...) const [with Args = {const char*}]’:
<builddir>/sirius/src/Band/band.cpp:425:5:   required from ‘void sirius::Band::check_residuals(sirius::Hamiltonian_k&) const [with T = double]’
<builddir>/sirius/src/Band/band.cpp:414:9:   required from ‘void sirius::Band::initialize_subspace(sirius::Hamiltonian_k&, int) const [with T = double]’
<builddir>/sirius/src/Band/band.cpp:154:46:   required from here
<builddir>/sirius/src/K_point/k_point.hpp:746:19: error: format not a string literal and no format arguments [-Werror=format-security]
  746 |             printf(args...);
      |             ~~~~~~^~~~~~~~~
cc1plus: some warnings being treated as errors

Top of cmake output:
-- The C compiler identification is GNU 9.2.1
-- The CXX compiler identification is GNU 9.2.1

Thank you for reporting, we were not compiling with -Werror=format-security so far. It's fixed in PR #446 .

Thanks a lot for the prompt fix! Compile completes successfully now.


Fix pathForTesting -> startupPath

This fixes a bug introduced in #7225 due to a bad cherry-pick.

Jenkins green, merging now.

ty & sry


dev: publish imu indoor and update timestamp setting

Description
This PR provides publishing 6 axis IMU indoor and decision making mechanism for timestamp setting. If gps time's delay to rostime less than 100ms and use_rostime setted false messages timestamps setted to gps time.
Tests performed

While use_rostime false clap runned indoor and outdoor and its messages timestamp's checked
Effects on system behavior

Outdoor environment GPS time is initialized clap publishes messages with GPS time

Indoor environment GPS time isn't initialized, although use_rostime setted false clap publishes messages with rostime.

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Clap-B7 GNSS driver is sending 6-axis IMU data without GNSS connections required now.


Question - Multiple Inserts within transaction

Hello @kshvakov I was wondering if there was a way to do multiple inserts into separate collections/tables within the same transation?
eg.
tx, err := connect.Begin()
...

stmt, err := tx.Prepare("INSERT INTO table1 ....")
_, err = stmt.Exec(...)
...

stmt, err := tx.Prepare("INSERT INTO table2 ....")
_, err = stmt.Exec(...)
...

err := tx.Commit()
...

on the second Prepare statement I get the error:
data request has already been prepared in transaction

thanks in advance for any help :)

Hi, it's not possible, Clickhouse do not support transactions
tx, err := connect.Begin() // <-- it's not real transaction
stmt, err := tx.Prepare("INSERT INTO table1 ....") // <-- create statement with data buffer
stmt.Exec(...) // <-- write data to statement buffer
tx.Commit() // <- send data-block to Clickhouse server

Thanks


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-28-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3998

Questions ?
Please refer to the Backport tool documentation


[Automation]: Notify when irrigation needs to be cleaned out

Description
IRRIGATION WATER FILTER under preserve walkway closer to dock - clean (open valve to run water and debris out) every 3-4 weeks. Located under the dock near the step down onto the tree trunk.
Reference / Guide Url
No response

Done via Cron and node red


[WIP] Provide Support for Linux

Infraestructure

[x] Update the build tools and CI

Code
Ogra Error Message
/home/rlovelett/Source/langserver-swift/.build/checkouts/Ogra.git-4459770976581387768/Sources/Encodable.swift:95:128: warning: redundant same-type constraint 'Wrapped.Iterator.Element' == 'Wrapped.Element'
extension Optional where Wrapped: Collection & ExpressibleByArrayLiteral, Wrapped.Element: Encodable, Wrapped.Iterator.Element == Wrapped.Element {
                                                                                ^
/home/rlovelett/Source/langserver-swift/.build/checkouts/Ogra.git-4459770976581387768/Sources/Encodable.swift:95:33: note: previous same-type constraint 'Wrapped.Element' == 'Wrapped.Iterator.Element' implied here
extension Optional where Wrapped: Collection & ExpressibleByArrayLiteral, Wrapped.Element: Encodable, Wrapped.Iterator.Element == Wrapped.Element {
                                ^
/home/rlovelett/Source/langserver-swift/.build/checkouts/Ogra.git-4459770976581387768/Sources/Encodable.swift:89:102: warning: redundant conformance constraint 'Self.Element': 'Encodable'
extension Collection where Self: ExpressibleByArrayLiteral, Self.Element: Encodable, Iterator.Element: Encodable {
                                                                                ^
/home/rlovelett/Source/langserver-swift/.build/checkouts/Ogra.git-4459770976581387768/Sources/Encodable.swift:89:73: note: conformance constraint 'Self.Element': 'Encodable' written here
extension Collection where Self: ExpressibleByArrayLiteral, Self.Element: Encodable, Iterator.Element: Encodable {
                                                                        ^
/home/rlovelett/Source/langserver-swift/.build/checkouts/Ogra.git-4459770976581387768/Sources/Encodable.swift:36:18: error: cannot convert value of type 'Int' to type 'NSNumber' in coercion
                return .number(self as NSNumber)
                               ^~~~
/home/rlovelett/Source/langserver-swift/.build/checkouts/Ogra.git-4459770976581387768/Sources/Encodable.swift:42:18: error: cannot convert value of type 'Double' to type 'NSNumber' in coercion
                return .number(self as NSNumber)
                               ^~~~
/home/rlovelett/Source/langserver-swift/.build/checkouts/Ogra.git-4459770976581387768/Sources/Encodable.swift:48:18: error: cannot convert value of type 'Float' to type 'NSNumber' in coercion
                return .number(self as NSNumber)
                               ^~~~
/home/rlovelett/Source/langserver-swift/.build/checkouts/Ogra.git-4459770976581387768/Sources/Encodable.swift:54:18: error: cannot convert value of type 'UInt' to type 'NSNumber' in coercion
                return .number(self as NSNumber)
                               ^~~~
/home/rlovelett/Source/langserver-swift/.build/checkouts/Ogra.git-4459770976581387768/Sources/Encodable.swift:109:29: error: cannot convert value of type 'Int' to type 'NSNumber' in coercion
        return .number(self.rawValue as NSNumber)
                       ~~~~~^~~~~~~~
/home/rlovelett/Source/langserver-swift/.build/checkouts/Ogra.git-4459770976581387768/Sources/Encodable.swift:115:29: error: cannot convert value of type 'Double' to type 'NSNumber' in coercion
        return .number(self.rawValue as NSNumber)
                       ~~~~~^~~~~~~~
/home/rlovelett/Source/langserver-swift/.build/checkouts/Ogra.git-4459770976581387768/Sources/Encodable.swift:121:29: error: cannot convert value of type 'Float' to type 'NSNumber' in coercion
        return .number(self.rawValue as NSNumber)
                       ~~~~~^~~~~~~~
/home/rlovelett/Source/langserver-swift/.build/checkouts/Ogra.git-4459770976581387768/Sources/Encodable.swift:127:29: error: cannot convert value of type 'UInt' to type 'NSNumber' in coercion
        return .number(self.rawValue as NSNumber)
                       ~~~~~^~~~~~~~
error: terminated(1): /usr/bin/swift-build-tool -f /home/rlovelett/Source/langserver-swift/.build/debug.yaml main output:

[x] Fix Ogra (Fixed in #38)
[x] Update source code to Swift 4.1 (Fixed in #38)
[x] Update SwiftPM to Swift 4.1 (Fixed in #38)
[ ] Cross-platform logging
[ ] Get PR that fixes SR-5773 merged into corelibs-libdispatch
[ ] Ensure all tests are passing

Documentation

[ ] Update the README

What does waitForDataInBackgroundAndNotify do? Is it related to File Events?

https://github.com/apple/swift-corelibs-foundation/pull/1427
The author should stop being lazy and finish the requested feedback. 😏

Omg, I didn't realise you were working on that! Yes, I agree 😜 but also I think his pace might be different. We should not be pressuring him :)

How're we doing logging? Because tracelog is an option to have cross-platform logging :)

PS: I edited the original to-do list so that it's easier to follow, how's it look?

PS: I edited the original to-do list so that it's easier to follow, how's it look?

LGTM 👍

How're we doing logging? Because tracelog is an option to have cross-platform logging :)

So I will be honest and say I haven't put too much thought into logging. So I'll try and stop this from becoming a stream of consciousness.
My two platforms I daily drive are macOS and Fedora. On macOS I want the logging to be done using Unified logging or os_log and on Fedora I want the logging to be available inside the systemd journal, e.g., journalctl. So does that limit or select the loggers we can use? I have no idea. Do we need to do that on the first iteration of logging? Probably not.
The thing that we absolutely cannot do is write to stdout. That is how the LSP and VSCode talk to one another. So if tracelog outputs to stdout then we'll need a different solution.
Other than that, I think its probably best to just try some out and see what happens.

LSP also defines window/logMessage

LGTM 👍

Awesome :)

The thing that we absolutely cannot do is write to stdout. That is how the LSP and VSCode talk to one another. So if tracelog outputs to stdout then we'll need a different solution.

That seems reasonable.
So looking at TraceLog's Readme (under Configuration), I think we can definitely avoid writing to stdout and possibly configure exactly where do we want it to go depending on the OS:

Log output can be configured globally using the LOG_ALL variable, by TAG name using the LOG_TAG_ variable pattern, and/or by a TAG prefix by using the LOG_PREFIX_ variable pattern.

LSP also defines window/logMessage

Ohh, that is very interesting. Maybe we can pipe the logs to that eventually, or some of them at least (the ones relevant to have on the client's side)
Is this the kind of logging you meant in the to-do list, Ryan? (I know very little about the LSP so I couldn't say)

LSP also defines window/logMessage

Absolutely I think that's a good one too. Traditionally I didn't use that one because when I was first starting this thing I really wanted to be able to log the raw bytes of the protocol. So if you were doing that over the logMessage API it would be a runaway feedback loop. 😄
So for a long time I was just logging every new message into a different file.
Eventually this became too noisy and I fell back to os_log.
This struck a nice balance between being able to see all the low-level logs from the server and also giving an easy filter mechanism.
I still think that window/logMessage has value. Though right now the challenge is what are messages that are for developers of the LSP and what are user facing log messages.
Also, if you look at the main run loop. It is pretty poorly structured to handle injecting out of band messages. The main run loop is basically designed to receive a request from the client and respond. It is not really designed to just say something without being prompted first. That's a design flaw by me.

Is this the kind of logging you meant in the to-do list, Ryan? (I know very little about the LSP so I couldn't say)

No the logging I want to fix in the todo list is this.

Also, if you look at the main run loop. It is pretty poorly structured to handle injecting out of band messages. The main run loop is basically designed to receive a request from the client and respond. It is not really designed to just say something without being prompted first. That's a design flaw by me.

It's not like this was another one amongst the tens of LSP implementations for Swift. This was the first one. I wouldn't blame you for having a design mistake in something that was not only entirely new, but also very much urgently needed.
Maybe the design could be reworked after everything is cross-platform and stable.

Is this the kind of logging you meant in the to-do list, Ryan? (I know very little about the LSP so I couldn't say)

No the logging I want to fix in the todo list is this.

I see. I'll read the docs of TraceLog in more detail, I think it could work for this.

Update on TraceLog:

It can do what we'd like, that is,

My two platforms I daily drive are macOS and Fedora. On macOS I want the logging to be done using Unified logging or os_log and on Fedora I want the logging to be available inside the systemd journal, e.g., journalctl.

Is very much possible :D

Tony thinks this use case is so good that he wants to help directly by possibly implementing it himself ❤

Okay. I've gotten it "working". :tada:

I had to kludge a bunch of patches and compile my own copy of Swift in order to get it to work. But it does sort of work.
Still many hours left to go but I have made significant progress.

OMG! :D
YOU CAN DOOO EEEET :fist_raised:
...how did you get past the Foundation problems? Are you sneakily using your corelibs PR? :)

...how did you get past the Foundation problems? Are you sneakily using your corelibs PR? :)

Yup. I've compiled my own version of Swift 4.2. I'm using using my patch(es) and a few others that I've not published yet. I'm compiling swift, swift-stdlib and libdispatch in debug mode. So I can actually use lldb against each of those components.
I've actually refactored the run loop to not use the old patch needed for Foundation. It now just uses DispatchIO directly. Which actually, I think, makes it more performant.
The bad news is that now it depends on this patch. So I just traded one issue in corelibs for another I suppose. 🤷♂ 🤦♂

I'm compiling swift, swift-stdlib and libdispatch in debug mode. So I can actually use lldb against each of those components.

Wow. Having fiddled a little bit with compiling the toolchain, that's a ton of work. :bowing_man: thank you

I've actually refactored the run loop to not use the old patch needed for Foundation. It now just uses DispatchIO directly. Which actually, I think, makes it more performant.
The bad news is that now it depends on this patch. So I just traded one issue in corelibs for another I suppose. :man_shrugging: :man_facepalming:

Well, that patch looks certainly much, much simpler. So that's great! It should be merged soonish, I'd say.
The performance gains are great as well. Good job! ^^

I've updated the to-do list to reflect your new PR :+1:

@felix91gr the cross platform logging wasn't as straight forward as we might have hoped I take it.
Swift on Linux is not for the faint of heart. :smirk: :rofl:

the cross platform logging wasn't as straight forward as we might have hoped I take it.

Hahaha, I know right? Ah well. I'm gonna see if I can persuade somebody who's at WWDC s.t. they can get a word in for us for expanding the os_log API.

Swift on Linux is not for the faint of heart.

Last year it was oh so much worse :rofl: but it's getting better! And thanks to people like you and @vknabel, among many others, we can push it forward even faster :). IMO the most important part of a project like Swift is the community behind it, and we have a really welcoming one, with very kind people all around.
I've also seen great disposition on the corelibs-foundation team. They really want to complete the library. That will be a huge push for cross-platform compatibility - more or less half of the projects I've been helping to port, rely on unimplemented pieces of the library.

And thanks to people like you and @vknabel, among many others, we can push it forward even faster

I don't know if I have said or not but I've hit a road block since I cannot actually debug the server on Linux the same way I do on macOS. I'm now learning how LLDB works and trying (so far unsuccessfully) to implement the capability on Linux. :crossed_fingers:

IMO the most important part of a project like Swift is the community behind it, and we have a really welcoming one, with very kind people all around.

Could not agree more.

more or less half of the projects I've been helping to port, rely on unimplemented pieces of the library

That aligns with my experience too.
Keep up the great work!

I don't know if I have said or not but I've hit a road block since I cannot actually debug the server on Linux the same way I do on macOS. I'm now learning how LLDB works and trying (so far unsuccessfully) to implement the capability on Linux. :crossed_fingers:

I've seen your quest for LLDB at the forums. I'm crossing my fingers for you as well!
If I got it correctly, LLDB support at the langserver level means that you can do step-by-step debugging right there in the IDE, like in Visual Studio or Eclipse?

Keep up the great work!

You too! ^^

@RLovelett do you need assistance adding TraceLog and AdaptiveWriter for "Cross-platform logging"?  I should have some time shortly and would be happy to assist when I do.

Absolutely I'd love the assistance. @felix91gr was the one for the original "vision" of how to do this feature but certainly I can help answer questions. If you have a vision for it by all means move forward with it.

@RLovelett Ok, I suggest that TraceLog is added in a branch off of master in a separate PR, then pulled into here once merged with master.  That would isolate out the changes and allow easier review and testing.  TraceLog is already cross-platform.  The new AdaptiveWriter can be added in that branch which will also satisfy the requirement in this PR/branch.  The AdaptiveWriter writes to os_log (Unified Logging) on Darwin and SD journal on Linux so we'd be all set.  We'd be able to remove all the #if os() statements currently used for logging.  Thoughts?

Totally agree. That is a great idea. Especially love the idea of it being done directly off of master. Easier to review and move forward.

Great, as soon as I free up a bit, I'll get setup with your dev environment, create the branch and get started.


mount additional fsx

This script allows mounting additional FSx Lustre filesystems from the lifecycle_scrtipt.py. These can be mounted by adding in lines on lifecycle_script.py#L153 like so:
ExecuteBashScript("./mount_fsx.sh").run("fs-05dac34e835f2c48f.fsx.us-west-2.amazonaws.com", "4owupbev", "/fsx/home")
ExecuteBashScript("./mount_fsx.sh").run("fs-0972ef1ec89bcc14c.fsx.us-west-2.amazonaws.com", "6eoi7bev", "/fsx/mount2")
ExecuteBashScript("./mount_fsx.sh").run("fs-0da5542b6a0808375.fsx.us-west-2.amazonaws.com", "yioi7bev", "/fsx/mount3")

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Just to be a bit a pain. we should use fsxl instead of fsx

Can I get this approved @perifaws

@sean-smith merged


Nuxt?

Is it possible to create some sort of documentation on how Nuxt is implemented? Is it needed to create a plugin? Something? It's quite confusing. I read that Hooper works ok with Nuxt but I'm experiencing some issues as the carousel does not render the slides I want it to render and I don't know where the issue is because apparently my code is correct comparing it to the docs one. 😞
I can attach code if needed.

Nothing special, works out of a box.
Code snippet:
<template>
  <hooper :settings="hooperSettings" ref="carousel">
    <slide>
      <div v-for="index in 5" :key="index">
        {{index}}
      </div>
    </slide>
  </hooper>
</template>

<script>
  import { Hooper, Slide } from 'hooper'
  import 'hooper/dist/hooper.css'

  export default {
    name: 'Div',
    components: {
      Hooper,
      Slide
    },
    data() {
      hooperSettings: {
        itemsToShow: 1,
        itemsToSlide: 1
      }
    },
    methods: {
      slidePrev () {
       this.$refs.carouselPress.slidePrev();
     },

     slideNext () {
       this.$refs.carouselPress.slideNext();
     }
    }
  }
</script>

Like @rensite said, hooper supports SSR out of the box. No need to create a plugin for it.
You might've missed importing the css, as Hooper requires some minimal CSS to work. But you will have to provide your own styles to adjust height, width, colors.
This is a sample I uploaded recently to Codesandbox: https://codesandbox.io/s/hooper-nuxt-765ot

Ok, thanks. I modified my slider so it's like the example but it still renders whatever the slides it wants, not the ones I want it to render, any ideas on why this would be happening?

Ok, thanks. I modified my slider so it's like the example but it still renders whatever the slides it wants, not the ones I want it to render, any ideas on why this would be happening?

Could you attach the code?

`

<Slide :style="{width: pWidth, height: pHeight}"
        v-for="(option, index) in options"
        :index="index"
        :key="index"
>

  <SinglePhotoForSlider :pWidth="pWidth" :pHeight="pHeight" class="photo" :option="(option.img || option.path) + '&fit=min&q=60'" />
</Slide>
<Navigation slot="hooper-addons"></Navigation>

`
Here it is

😔

Look's like the loop issue. Try to move v-for="(option, index) in options" :index="index" :key="index" into SinglePhotoForSlider as following:
<Slide :style="{width: pWidth, height: pHeight}">
      <SinglePhotoForSlider v-for="(option, index) in options" :index="index" :key="index" :pWidth="pWidth" :pHeight="pHeight" class="photo" :option="(option.img || option.path) + '&fit=min&q=60'" />
</Slide>

Hope the snippet above solves the problem ;)

I'm afraid that doesn't work. Images appear one on top of another (vertical). I've also tried adding the v-for to a div inside the slide, outside. Nothing works. :S For some reason it does not get the setting from the data...

Could you create sandbox example or provide your live project with broken hooper carousel? Gonna take a look at it. I assume it may be also css issue.

Here: https://codesandbox.io/s/codesandbox-nuxt-t6q72
This is no representation of what is happening to me, I can see the photos but I can not use hooper settings to modify anything. I don't know why the sandbox is behaving like that (probably I forgot something) but at least you can check the code. 🤦🏼♀

I had the same problem and it's because the hooper css is missing, inspect the page and search for the .hooper class, if you can't find its because of that.
In my case, it wasn't adding the CSS because I'm using nuxt-purgecss, adding whitelistPatterns: [/hooper/], fixed the problem.
I hope it helps!

I'm afraid css is not the problem, it is imported and i'm not using PurgeCSS or similar. Hooper class is there. Thanks anyway, I'll keep investigating. 😔

Related issue #51

Thanks @saerose

I think I figured it out. I have the sliders inside a component that has an v-show, i changed it to v-if and now it's working.


Outdated Documentation?

Hi,
Thanks for the amazing code. I was trying it out today, but unfortunately a lot of the documentation seems to be outdated. Specifically, the following pages do not work with the newest version of the code:
https://docs.einsteinpy.org/en/latest/examples/Visualizing Event Horizon and Ergosphere (Singularities) of Kerr Metric or Black Hole.html
https://docs.einsteinpy.org/en/latest/examples/Using Geodesics (Back-ends %26 Plotting).html
Is it a problem on my side, or is the documentation indeed outdated?
Thanks!
Andrius

Thanks!
I have installed the newest version and can now confirm that the relevant imports work.
I have tested the geodesic example (https://docs.einsteinpy.org/en/stable/examples/Using Geodesics (Back-ends %26 Plotting).html) and, unfortunately, it still does not seem to work. In particular, when defining the Geodesic class instance, it requires a 'metric' and 'metric_params', which are not defined in the example.

I have installed the newest version and can now confirm that the relevant imports work.

Great.

I have tested the geodesic example (https://docs.einsteinpy.org/en/stable/examples/Using Geodesics (Back-ends %26 Plotting).html) and, unfortunately, it still does not seem to work. In particular, when defining the Geodesic class instance, it requires a 'metric' and 'metric_params', which are not defined in the example.

You are looking at the docs for "stable" (v0.3.1). Since you are using the "latest" or dev version (v0.4.dev0), please peruse the docs for "latest". You can switch between docs by clicking on this screentip at the bottom right of the docs website:

There were some significant updates to the Geodesics module between v0.3.1 and v0.4.dev0.

Sorry, that was my bad. Now it all works. Thanks!

Have made a release for the project just now. Hope this all will be fixed


Use Oauth2AuthorizedClientProvider to implement authorize clients delegated by azure client.

Use Oauth2AuthorizedClientProvider to implement authorize clients delegated by azure client.

/azp run java - spring - tests

Hi, @moarychan , @yiliuTo , @zhichengliu12581 , please help to review this PR.

LGTM

LGTM.

@moarychan , thank you.

@moarychan , test github notification.


The MessageAttachment struct doesn't have a public initializer

public struct MessageAttachment: Codable {
    let fileID: String
    let tools: [AssistantObject.Tool]

    enum CodingKeys: String, CodingKey {
        case fileID = "file_id"
        case tools
    }

    public init(fileID: String, tools: [AssistantObject.Tool]) {
        self.fileID = fileID
        self.tools = tools
    }
}

Thanks!
https://github.com/jamesrochabrun/SwiftOpenAI/releases/tag/v3.8.1


[inputNumber] fix doc error

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

issues
https://github.com/ElemeFE/element/issues/18431

close: long time no handle.


Set deployment target to 10.8 and removed i386 as a valid arch.

Closes issue #576
The deployment target not being set was leading to cocoapods issues.
Removed i386 from valid architectures as we are now 64-bit only.
I know we tried this last year and we reverted it but a lot of cocoa projects have this variable set in the project itself and we are creating issues with cocoapods.

Seems redundant with what is already set in configs/Project-All.xcconfig


Add required ClimateEntityFeature TURN_OFF/TURN_ON for HA2024.2

This works only for HM-IP devices and not for the old HM-CC-RT-DN right?

Please don't comment on merged PR.
This feature is not pinned to a platform.
More information can be found in the HA documentation


PhantomJS crash help

I am trying to build a scrapper using PhantomJS and it keeps crashing at specific point in runtime. After it crashes it says to create an issue here and attach the .dmp file. I am on Windows system and I couldn't figure out how to obtain stack trace from the .dmp file and GitHub won't allow me to attach .dmp file to the issue so I uploaded it on my drive here https://drive.google.com/file/d/0BzNRHH7MTdRdYklhUGEyOXZwOEU/view?pli=1. Can anyone help me with this issue?

We really ought to take that message out.  .dmp files are basically useless to us.

Are you using PhantomJS 2.0?  1.9.x is no longer developed and has many bugs.

If you have a webpage that crashes using 2.0, please see if it also crashes a nightly build of WebKit, and if so, report that to the WebKit developers.  We do not have the manpower to fix WebKit bugs ourselves.

If you have a webpage that crashes PhantomJS 2.0 but not a nightly build of WebKit, we will eventually pick up the fix when we upgrade our embedded copy of WebKit, but that might be quite some time from now, sorry.


Allow option for invisible tokens to be tracked.

My use case is that players know the facility map, and I can pre-populate sections with invisible alien actors. So a simple fog of war except for tokens.

Hello! Thanks for adding this! Somebody mentioned he used the hidden tokens to place facehuggers or xenomorphs walking on the ceiling and it made completely sense. In fact, the first version only filtered by visibility it was and is the easiest way but now the mod can filter by other means. I'll do something the next days for all this 👍

I'll just wanted to secod this request. My use case is the same.

That's what I am doing right now, I am making a 0.5.0 version who removed the filtering for invisible tokens and added a custom status for the motion tracker. All tokens are filtered by this status & dead status. Also, you can configure additional status within the settings. If this seems fine after some tests we can close the issue :)

Hey did this resolved your issue ?


Global variables are not supported with testarina

Steps

Write some test functions as below

string tweetId;

function testinit()() {
     tweetId = "test";

}

function testTweet() {
        system:println("Print tweetId " + tweetId);
}

Execute the tests as ./ballerina test

Issue
"test 'testTweet' has an error: null" is logged. The print statement will not be executed.

this works in ballerina 0.92 release as well as the current master branch


Investigate using dockerless terraform priver to pull and push docker images

Background
dibbs-aws uses a terraform provider that requires docker to be present to work. To reduce our dependencies we should consider writing it with a Terraform provider that doesn't require docker to be installed.
Action Requested
Investigate using a provider to pull and push docker images that don't require the docker daemon to be present.
Acceptance Criteria

Rewrite the docker resources to use a dockerless setup.
OR
Produce a document stating why this can't be done.

Additional context

One possible option: https://registry.terraform.io/providers/nullstone-io/dockerless/latest/docs/resources/remote_image

Philadelphia


Add delete context in the options

I would suggest to add a delete context command.
Here's what I did and worked:

function usage() {
  Write-Output "
      Usage
        kubectxwin                        : current context
        kubectxwin ls                     : list the contexts
        kubectxwin set <name>             : switch to context <name>
        kubectxwin rn <oldname> <newname> : rename context <oldname> <newname>
        kubectxwin rm <name>              : delete context <name>
        kubectxwin help                   : display usage"
}
[...]

function delete_context() {
    kubectl config delete-context $name
}
[...]

function main() {
    switch ($action) {
        set { switch_context $name }
        Default { current_context }
        ls { list_contexts }
        rn { rename_context }
        rm { delete_context }
        help { usage }
    }
}

@euphreme - Thanks.  I've commit this.


Rerender v0.1.1rc1

I'm pretty sure I pushed #8 as a result of no re-rendering in the scope of the PR, so I re-rendered (locally) and pushed. I'm not sure if these changes would actually push them to a new branch or not
https://anaconda.org/conda-forge/openff-interchange/files

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin please rerender

Okay, this gives me some confidence:
2021-08-09T15:31:57.3441652Z INFO :: The inputs making up the hashes for the built packages are as follows:
2021-08-09T15:31:57.3442274Z {
2021-08-09T15:31:57.3443143Z   "openff-interchange-0.1.1rc.1-pyhc3945a9_0": {
2021-08-09T15:31:57.3443532Z     "recipe": {
2021-08-09T15:31:57.3444071Z       "channel_targets": "conda-forge openff-interchange_rc"
2021-08-09T15:31:57.3444466Z     }
2021-08-09T15:31:57.3445117Z   },
2021-08-09T15:31:57.3445727Z   "openff-interchange-base-0.1.1rc.1-pyh658aab2_0": {
2021-08-09T15:31:57.3446201Z     "recipe": {
2021-08-09T15:31:57.3446829Z       "channel_targets": "conda-forge openff-interchange_rc",
2021-08-09T15:31:57.3447327Z       "python": "3.6.* *_cpython"
2021-08-09T15:31:57.3447705Z     }
2021-08-09T15:31:57.3448004Z   }
2021-08-09T15:31:57.3448313Z }


Q: How do I start up the interface in full width and full height by default?

Without requiring to click on the fullscreen icon (inside the menu)
Tried several ways and only width was able to expand to 100%
Thanks
STAY SAFE!!!

Hi, https://xdsoft.net/jodit/doc/options/fullsize/ set true.


Correct supported python versions.

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

3.0.0
GitHub release

Your semantic-release bot :package::rocket:


[iOS] App crashes when a Google Map with satellite map type and no markers is removed from the view hierarchy.

Summary
We identified a crash in the following conditions:

Google Maps on iOS (Using Metal renderer)
Map with satellite map type
No markers added and no user location shown in the map (map is completely clean)
When the map is removed from the view hierarchy, it crashes (it might get hidden after a screen refresh or removed from memory after the user moves back in the stack navigation).

Reproducible sample code
import React, { useEffect, useState } from 'react';
import { View } from 'react-native';
import MapView from 'react-native-maps';

const TestScreen = () => {
  const [showTestMap, setShowTestMap] = useState(false);

  useEffect(() => {
    setTimeout(() => {
      setShowTestMap(true);
      setTimeout(() => {
        setShowTestMap(false);
      }, 3000);
    }, 2000);
  }, []);

  return (
    <View style={{ flex: 1 }}>
      {showTestMap && <MapView style={{ flex: 1 }} provider="google" mapType="satellite" />}
    </View>
  );
};

export default TestScreen;

Steps to reproduce
Showing the provided TestScreen will generate the crash. The crash happens when the app shows a map with no visible markers at all (not even user location) and then it's removed from the view hierarchy (either by hiding it, or by removing the screen from a navigation stack).
There are 2 ways to reproduce the crash:
Way 1: Remove a clean map from the view hierarchy.

Add a map to the screen with provider="google" mapType='satellite" and no markers, not even user location marker.
Remove that map from the view hierarchy
The provided code is doing this (add the map after 2 seconds the screen appears, and then removing it 3 seconds later).

Way 2: Move the map to a place with no markers and then remove it from the view hierarchy.

Add a map to the screen with provider="google" mapType='satellite" which can have markers (for example user location, points of interest or any other marker).
Move the map to a region that doesn't have any markers (you need to move far away from the markers locations, like in the middle of the ocean, so that markers are removed from memory).
Remove the map from the view hierarchy.

Expected result
The app doesn't crash
Actual result
The app crashes  with the following stack trace:
SIGSEGV: Attempted to dereference garbage pointer 0x530038bc8aa0.

0  Our App       std::__1::less<std::__1::tuple<MTLTextureType, MTLPixelFormat, int, int, bool> >::operator()(std::__1::tuple<MTLTextureType, MTLPixelFormat, int, int, bool> const&, std::__1::tuple<MTLTextureType, MTLPixelFormat, int, int, bool> const&) const (Our App)
1  Our App       std::__1::__tree_iterator<std::__1::__value_type<std::__1::tuple<MTLTextureType, MTLPixelFormat, int, int, bool>, std::__1::vector<std::__1::shared_ptr<gmscore::renderer::MetalTexture>, std::__1::allocator<std::__1::shared_ptr<gmscore::renderer::MetalTexture> > > >, std::__1::__tree_node<std::__1::__value_type<std::__1::tuple<MTLTextureType, MTLPixelFormat, int, int, bool>, std::__1::vector<std::__1::shared_ptr<gmscore::renderer::MetalTexture>, std::__1::allocator<std::__1::shared_ptr<gmscore::renderer::MetalTexture> > > >, void*>*, long> std::__1::__tree<std::__1::__value_type<std::__1::tuple<MTLTextureType, MTLPixelFormat, int, int, bool>, std::__1::vector<std::__1::shared_ptr<gmscore::renderer::MetalTexture>, std::__1::allocator<std::__1::shared_ptr<gmscore::renderer::MetalTexture> > > >, std::__1::__map_value_compare<std::__1::tuple<MTLTextureType, MTLPixelFormat, int, int, bool>, std::__1::__value_type<std::__1::tuple<MTLTextureType, MTLPixelFormat, int, int, bool>, std::__1::vector<std::__1::shared_ptr<gmscore::renderer::MetalTexture>, std::__1::allocator<std::__1::shared_ptr<gmscore::renderer::MetalTexture> > > >, std::__1::less<std::__1::tuple<MTLTextureType, MTLPixelFormat, int, int, bool> >, true>, std::__1::allocator<std::__1::__value_type<std::__1::tuple<MTLTextureType, MTLPixelFormat, int, int, bool>, std::__1::vector<std::__1::shared_ptr<gmscore::renderer::MetalTexture>, std::__1::allocator<std::__1::shared_ptr<gmscore::renderer::MetalTexture> > > > > >::find<std::__1::tuple<MTLTextureType, MTLPixelFormat, int, int, bool> >(std::__1::tuple<MTLTextureType, MTLPixelFormat, int, int, bool> const&) (Our App)
2  Our App       gmscore::renderer::MetalTexturePool::CleanupIfNeeded() (Our App)
3  Our App       gmscore::renderer::MetalTexturePool::ReturnTextureToPool(std::__1::shared_ptr<gmscore::renderer::MetalTexture> const&) (Our App)
4  Our App       gmscore::renderer::MetalPooledTexture::~MetalPooledTexture() (Our App)
5  Our App       std::__1::shared_ptr<reanimated::NativeReanimatedModule>::~shared_ptr() (shared_ptr.h:177:9)
6  Our App       std::__1::shared_ptr<facebook::jsi::Function>::~shared_ptr() (shared_ptr.h:957:1)
7  Our App       std::__1::__hash_table<std::__1::__hash_value_type<long long, std::__1::shared_ptr<facebook::jsi::Function> >, std::__1::__unordered_map_hasher<long long, std::__1::__hash_value_type<long long, std::__1::shared_ptr<facebook::jsi::Function> >, std::__1::hash<long long>, std::__1::equal_to<long long>, true>, std::__1::__unordered_map_equal<long long, std::__1::__hash_value_type<long long, std::__1::shared_ptr<facebook::jsi::Function> >, std::__1::equal_to<long long>, std::__1::hash<long long>, true>, std::__1::allocator<std::__1::__hash_value_type<long long, std::__1::shared_ptr<facebook::jsi::Function> > > >::~__hash_table() (__hash_table:1519:5)
8  Our App       std::__1::unique_ptr<gmscore::renderer::MetalRenderStateController, std::__1::default_delete<gmscore::renderer::MetalRenderStateController> >::reset(gmscore::renderer::MetalRenderStateController*) (Our App)
9  Our App       gmscore::renderer::MetalRenderTarget::~MetalRenderTarget() (Our App)
10 Our App       gmscore::renderer::MetalRenderTarget::~MetalRenderTarget() (Our App)
11 Our App       gmscore::base::ReferenceCounted::GMSx_Unref() (Our App)
12 Our App       gmscore::base::reffed_ptr<gmscore::renderer::RenderTarget>::~reffed_ptr() (Our App)
13 Our App       -[GMSPhoenixRenderer .cxx_destruct] (Our App)
14 libobjc.A.dylib        object_cxxDestructFromClass(objc_object*, objc_class*)
15 libobjc.A.dylib        _objc_destructInstance
16 libobjc.A.dylib        __objc_rootDealloc
17 libsystem_blocks.dylib __Block_release
18 libobjc.A.dylib        AutoreleasePoolPage::releaseUntil(objc_object**)
19 libobjc.A.dylib        _objc_autoreleasePoolPop
20 UIKitCore              -[UIViewController dealloc]
21 libsystem_blocks.dylib __Block_release
22 CoreFoundation         ___RELEASE_OBJECTS_IN_THE_ARRAY__
23 CoreFoundation         -[__NSArrayM dealloc]
24 UIKitCore              -[_UIViewControllerTransitionContext _runAlongsideCompletions]
25 UIKitCore              -[_UIViewControllerTransitionContext completeTransition:]
26 UIKitCore              -[UITransitionView notifyDidCompleteTransition:]
27 UIKitCore              -[UITransitionView _didCompleteTransition:]
28 UIKitCore              ___UIVIEW_IS_EXECUTING_ANIMATION_COMPLETION_BLOCK__
29 UIKitCore              -[UIViewAnimationBlockDelegate _didEndBlockAnimation:finished:context:]
30 UIKitCore              -[UIViewAnimationState sendDelegateAnimationDidStop:finished:]
31 UIKitCore              -[UIViewAnimationState animationDidStop:finished:]
32 UIKitCore              -[UIViewAnimationState animationDidStop:finished:]
33 QuartzCore             CA::Layer::run_animation_callbacks(void*)
34 libdispatch.dylib      __dispatch_client_callout
35 libdispatch.dylib      __dispatch_main_queue_drain
36 libdispatch.dylib      __dispatch_main_queue_callback_4CF
37 CoreFoundation         ___CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
38 CoreFoundation         ___CFRunLoopRun
39 CoreFoundation         _CFRunLoopRunSpecific
40 GraphicsServices       _GSEventRunModal
41 UIKitCore              -[UIApplication _run]
42 UIKitCore              _UIApplicationMain
43 Our App       main (main.m:8:12)
44 dyld                   start

React Native Maps Version
1.2.0
What platforms are you seeing the problem on?
iOS (Google Maps)
React Native Version
0.68.2
What version of Expo are you using?
Not using Expo
Device(s)
All iOS devices
Additional information
There's a workaround, not elegant though:
To avoid this crash, add an invisible marker that is always in the visible region. We achieved this the following way:

Track the visible region in a state:
Handle the onRegionChangeComplete event to update the region
Add a placeholder marker in the visible region

The code should look like this:
...
const [visibleRegion, setVisibleRegion] = useState<Region>();
...
<MapView
  ...
  onRegionChangeComplete={region => {
    setVisibleRegion(region);
  }}
>
  {/* This is a placeholder marker required in iOS because if the map doesn't have any markers, it crashes when closing the modal */}
  {Platform.OS === 'ios' && visibleRegion && (
    <Marker coordinate={visibleRegion}>
      <View />
    </Marker>
  )}
</MapView>

I was able to reproduce this issue with the native Google Maps SDK in a native iOS app. This only happens with the Metal renderer, so if we can include a flag to disable it in react-native-maps it'd be great

Hi @lucaslt89. Thank you for your thorough report.
I noticed that you've opened an issue on google issue tracker as well, which is great. I'll keep an eye on that.
If possible, I would prefer not adding another variable that needs testing/triage etc. If Google doesn't provide a solution, I will of course reconsider :)

sounds good. Let's wait for Google to fix it! I did try a fork using OpenGL renderer but other crashes also happen, so I rather stay with Metal which works much better, and only has this crash.
Thanks!

I'm not using markers yet mapType={'satellite'} still causes a crash with a similar stack trace on my end. I'm not across the details but could it be a satellite view issue rather than an issue with markers too?
for me the issue seems to be a hybrid with this issue as I am using both satellite view with provider google

@isaacparsons-dw it actually happens when you don't use markers. If the map has a satellite type and is completely clean (no markers), when the map is removed from the view hierarchy, then the app crashes. I also found that this is reproducible with a hybrid map, if there are no points of interest or streets nearby, and you don't add any markers.
As I mentioned this is an issue on Google Maps SDK and it's reported there so I guess we can close this one.

This seems to have come back in with ios 17 :(

Its back in iOs 17


Add support for matrix bot

Hey @bjesus!
I figured it was about time to open the PR here for your review and feedback
Everything is tested and works with the exception of adding jobs for the scheduler. I haven't used this library before and am getting a value error ValueError: Wrong number of fields; got 1, expected 5 and was wondering if you've run into something similar with the telegram bot.
Happy to hear your thoughts!

Hey @avedor ! sorry it took me so long to review this. it seems like the PR is doing two things - adding some Todoist backend and adding the matrix bot.
I'm very happy to add Matrix support, but I'm a bit hesitant about implementing a different "backend" to Wren. I'm not entirely sure what's the use case and why not use one of many Todoist CLI tools instead? my first reaction would be that this is better off as another "plugin", just like Telegram or HTTP aren't affecting the core functionality of Wren.

Hi @bjesus! Absolutely no issue! I hope all is well!
My apologies! It looks like I merged things incorrectly on my fork--I'd intended to keep the matrix branch completely separate. I've dropped the todoist related commits from the branch, so it should be back down to just the matrix commits.
Sorry again for any confusion!

Thank you! this looks much better. a few tiny comments before we merge this:

can we change the setting homeserver to be called matrix_homeserver ?
I think we need to also go over schedules at startup and register them, like we're doing at the telegram bot: https://github.com/bjesus/wren/blob/main/wren/telegram.py#L163-L169

also, let's use croniter.is_valid() to validate the cron format. I've just added that on the telegram side too: https://github.com/bjesus/wren/commit/f6e9111635e1f7e12737aaa97a85e558635adbd6#diff-5193d610d07d0454264253f854564b7521017a9b38bb14d31158612211c1d74dR131

lastly, let's add the matrix bot dependencies as optional deps, like the http and telegram deps: https://github.com/bjesus/wren/blob/main/setup.cfg#L23-L33

hey @bjesus! i think i've gotten to everything you called out! i ran into a bit of trouble with the scheduler, though, as it wasn't separating the cron expression from the task name. i believe i've addressed that, but i wanted to call your attention to it because it does deviate from what you have in the telegram plugin

looks good to me! just made some formatting changes to match the general style of the code. merging this now and will make a new release. thank you very much!


OpenTelemetry Tracing for ProductCatalogService

Resolves #248 . Subtask of #132 .
To test, deploy the sandbox and you should see this in Cloud Trace (specifically, look for Span.{server, client}-hipstershop.ProductCatalogService/{ListProducts, GetProduct}):

@simonz130 did a refactor

For some reason I'm not seeing those traces, only BatchWriteSpans and health checks. I'm not too familiar with Cloud Trace though, so it could just be a me problem

For some reason I'm not seeing those traces

:O no span.server-frontend whatsoever? Oh, maybe you need to open hipstershop and click around a few times, or have the loadgenerator hit it with some requests, otherwise there might not be anything to trace?

:O no span.server-frontend whatsoever? Oh, maybe you need to open hipstershop and click around a few times, or have the loadgenerator hit it with some requests, otherwise there might not be anything to trace?

Nevermind, I tried again today and it's working!

@simonz130 Please take another look, I'm requiring PROJECT_ID since it's a required parameter, but the auth/credentials are the responsibility of the exporter. I'm having it retry up to 3 times and just warn if it fails. Thanks!


Remove $SCRIPT_ROOT from 'admin.create_template_from_zone' URL

As the URL here is contructed from Flask's "url_for" which already
takes the script root into account, we do not need to add it here
explicitly. This would result in a duplicate script root otherwise.

You're right. Merging your PR. Thanks


Use CoroutineContext instead of CoroutineDispatcher

This is useful for me because I have a use case where I'm passing around CoroutineContext rather than CoroutineDispatcher, but here you're only using them for calls to withContext - which works exactly the same since we're now just using the base interface instead.
Love the library by the way, extremely useful.

Pinging @divyanshupundir , since I can't seem to add a reviewer for this PR

Hello @rowden-jon. Thanks a lot for the kind words and for creating this PR.
It looks good to me. I'll just test it out and will create a release soon.


ES fix aggregation errors when index is empty

Fixes #464

Coverage remained the same at 100.0% when pulling e57142677fbcc572e0636218706e92615907359e on pavolloffay:es-fix-empty-index into 10d660f67babb61bbf0b8c75461bd2948e4537cb on jaegertracing:master.

lgtm, but we should let @black-adder to review

Coverage remained the same at 100.0% when pulling 133da741cc37faec83dfef00e1987e9349baf2c5 on pavolloffay:es-fix-empty-index into 5db9cdee782818bcab3de7e59f2691c50684c911 on jaegertracing:master.


Fix address conflict for m8plus when used with kpatch

Move carved space to avoid it conflicting with kpatch.
This new carve space is ~2kB by using an unused microcode update and patching the cpuid check for sanity sake (the cpuid check it nop's out hasn't shown up anywhere from my research and is probably a leftover from very early pre-production hw).

Whoops! Just now realized that it's in the wrong section! Closing this PR and will make another when an alternative carve space is worked out.


Angular typescript crash

I want to congratulate you for the component, it's been very useful in my project.
I'm currently having a problem, I'm developing an Angular Typescript project
I have the tsconfig.json file and when I add the parameter noUnusedParameters = true to the settings when running the build, the application gives an error:
Error: node_modules/cal-heatmap/src/options/Options.ts:321:41 - error TS6133: 'objValue' is declared but its value is never read.
321 ...mergeWith(this.options, opts, (objValue, srcValue) => {
× Failed to compile.
The problem is in the objValue variable that is not being used. To correct this in typescript there are some ways:
 this.options = {
       // eslint-disable-next-line arrow-body-style
       //@ts-ignore
       ...mergeWith(this.options, opts, (objValue, srcValue) => {
         return Array.isArray(srcValue) ? srcValue : undefined;
       }),
     };

or
  this.options = {
       // eslint-disable-next-line arrow-body-style
       ...mergeWith(this.options, opts, (_objValue, srcValue) => {
         return Array.isArray(srcValue) ? srcValue : undefined;
       }),
     };

That way it worked for my project.
The error happens at "node_modules\cal-heatmap\src\options\Options.ts"
Grateful

Thanks, fixed in 4.2.3


docs(showcase): add @vedantmgoyal2009 docs (draft/do-not-merge)

Motivation
Add my website to showcase.
Have you read the Contributing Guidelines on pull requests?
Yes.

we need the screenshot
Also your site is a newly initialized default template: please submit it once it is a real doc site with real content

Hello again, I have pushed the documentation now. Can you please re-open the the PR?

cc @Josh-Cena @lex111 @slorber

@vedantmgoyal2009 the screenshot it still missing in this PR


Install script does not add the source line to .zshrc when using zsh

Operating system and version:
Ubuntu 16.04.2 LTS
nvm debug output:

nvm --version: v0.33.11
$SHELL: /usr/bin/zsh
$SHLVL: 1
$HOME: /home/mufa
$NVM_DIR: '$HOME/.nvm'
$PATH: $NVM_DIR/versions/node/v10.8.0/bin:$HOME/bin:$HOME/.local/bin:/opt/ros/kinetic/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
$PREFIX: ''
$NPM_CONFIG_PREFIX: ''
$NVM_NODEJS_ORG_MIRROR: ''
$NVM_IOJS_ORG_MIRROR: ''
shell version: 'zsh 5.1.1 (x86_64-ubuntu-linux-gnu)'
uname -a: 'Linux 4.4.0-1049-aws #58-Ubuntu SMP Fri Jan 12 23:17:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux'
OS version: Ubuntu 16.04.2 LTS
curl: /usr/bin/curl, curl 7.47.0 (x86_64-pc-linux-gnu) libcurl/7.47.0 GnuTLS/3.4.10 zlib/1.2.8 libidn/1.32 librtmp/2.3
wget: /usr/bin/wget, GNU Wget 1.17.1 built on linux-gnu.
git: /usr/bin/git, git version 2.7.4
grep: grep: aliased to grep  --color=auto --exclude-dir={.bzr,CVS,.git,.hg,.svn} (grep --color=auto --exclude-dir={.bzr,CVS,.git,.hg,.svn}), grep (GNU grep) 2.25
awk: /usr/bin/awk, GNU Awk 4.1.3, API: 1.1 (GNU MPFR 3.1.4, GNU MP 6.1.0)
sed: /bin/sed, sed (GNU sed) 4.2.2
cut: /usr/bin/cut, cut (GNU coreutils) 8.25
basename: /usr/bin/basename, basename (GNU coreutils) 8.25
rm: /bin/rm, rm (GNU coreutils) 8.25
mkdir: /bin/mkdir, mkdir (GNU coreutils) 8.25
xargs: /usr/bin/xargs, xargs (GNU findutils) 4.7.0-git
nvm current: v10.8.0
which node: $NVM_DIR/versions/node/v10.8.0/bin/node
which iojs: iojs not found
which npm: $NVM_DIR/versions/node/v10.8.0/bin/npm
npm config get prefix: $NVM_DIR/versions/node/v10.8.0
npm root -g: $NVM_DIR/versions/node/v10.8.0/lib/node_modules

nvm ls output:

->      v10.8.0
default -> stable (-> v10.8.0)
node -> stable (-> v10.8.0) (default)
stable -> 10.8 (-> v10.8.0) (default)
iojs -> N/A (default)
lts/* -> lts/carbon (-> N/A)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.14.3 (-> N/A)
lts/carbon -> v8.11.3 (-> N/A)

How did you install nvm?
install script in readme
What steps did you perform?
Installed via script, that's it.
What happened?
When I open a new session I got zsh: command not found: nvm. I figured the source line was not added to .zshrc file even though the readme file suggests that it should. I added the source line and it worked. (I added the source line to .profile file, which I use for common directives for both shells. Both .zshrc and .bashrc source this file)
What did you expect to happen?
The lines:

export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" # This loads nvm

Should have been added to .zshrc after running the script, instead they were added to .bashrc although my default shell is zsh

Is there anything in any of your profile files (.bashrc, .bash_profile, .zshrc, etc) that modifies the PATH?
Well, many, but here's my $PATH right now: /home/mufa/.nvm/versions/node/v10.8.0/bin:/home/mufa/bin:/home/mufa/.local/bin:/opt/ros/kinetic/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games

I have just tried installing on macos 10.14 Beta (18A336e), and got the same result, although I have zsh as default shell, script added the lines in .bash_profile. Here is the output:

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12819  100 12819    0     0  84713      0 --:--:-- --:--:-- --:--:-- 84894
=> Downloading nvm from git to '/Users/muhsinfatih/.nvm'
=> Cloning into '/Users/muhsinfatih/.nvm'...
remote: Counting objects: 267, done.
remote: Compressing objects: 100% (242/242), done.
remote: Total 267 (delta 31), reused 86 (delta 15), pack-reused 0
Receiving objects: 100% (267/267), 119.47 KiB | 4.42 MiB/s, done.
Resolving deltas: 100% (31/31), done.
=> Compressing and cleaning up git repository

=> Appending nvm source string to /Users/muhsinfatih/.bash_profile
=> Appending bash_completion source string to /Users/muhsinfatih/.bash_profile
=> Close and reopen your terminal to start using nvm or run the following to use it now:

export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion


Rebase

Rebase in order to upgrade to v0.4.2.

This PR is based on main instead of v0.4.2, is that intentional?

Close as we used a release just in case.


CountdownLatchTest failure (https://hazelcast-l337.ci.cloudbees.com/view/Clients/job/cpp-linux-nightly/39)

Fix for CountdownLatchTest failure in some runs (e.g.: https://hazelcast-l337.ci.cloudbees.com/view/Clients/job/cpp-linux-nightly/39/ ). This comes out to be a missing thread wait in the test itself.

But there is already thread.join in destructor of thread. This change does not affect the test. If problem is really timing, we can increase the timeout to 2 minutes(default of timeouts in java tests). If latch takes 2 minutes to finish, we can easily conclude that implementation is wrong.

Sancar,
The thread destructor also has the pthread_cancel just before pthread_join, i don't know if that causes the problem. I don't think it is a timing problem of 2 minutes, the test really passes most of the time. (I separately checked the timing for await, it is doing the wait as requested, hence we can assume it is working)
Still need to understand why LockGuard destructor is getting the Segmentation fault. It only does mutex.unlock(), may be the mutex becoming invalid by then, i could not understand this yet.
From the stack trace we see that it is possible to get to thread destructor before testLatchThread function completes. This shows that the main thread assertTrue(l->await(10 * 1000)); lines passed before the testLatchThread function finishes. Hence, this suggested to me that the response to await call may arrive earlier than the response to the last countDown call (may be due to the times the server delivers these responses may be different). But we really want the testLatchThread to exit before the l.await passes and the test scope ends, don't we?
Stack trace:
Core was generated by `buildSHARED64Release/hazelcast/test/clientTest_SHARED_64'.
Program terminated with signal 11, Segmentation fault.
[Switching to thread 1 (Thread 28818)]#0  0x00002b2706df8bf0 in hazelcast::util::LockGuard::~LockGuard() ()
from /root/jenkins/workspace/cpp-linux-nightly/buildSHARED64Release/libHazelcastClient3.7-SNAPSHOT_64.so
(gdb) bt
#0  0x00002b2706df8bf0 in hazelcast::util::LockGuard::~LockGuard() ()
from /root/jenkins/workspace/cpp-linux-nightly/buildSHARED64Release/libHazelcastClient3.7-SNAPSHOT_64.so
#1  0x00002b2706dac47f in hazelcast::client::connection::CallFuture::get(long) ()
from /root/jenkins/workspace/cpp-linux-nightly/buildSHARED64Release/libHazelcastClient3.7-SNAPSHOT_64.so
#2  0x00002b2706daca65 in hazelcast::client::connection::CallFuture::get() ()
from /root/jenkins/workspace/cpp-linux-nightly/buildSHARED64Release/libHazelcastClient3.7-SNAPSHOT_64.so
#3  0x00002b2706dbdefe in hazelcast::client::proxy::ProxyImpl::invoke(std::auto_ptrhazelcast::client::protocol::ClientMessage, int) ()
from /root/jenkins/workspace/cpp-linux-nightly/buildSHARED64Release/libHazelcastClient3.7-SNAPSHOT_64.so
#4  0x00002b2706db381b in hazelcast::client::ICountDownLatch::countDown() ()
from /root/jenkins/workspace/cpp-linux-nightly/buildSHARED64Release/libHazelcastClient3.7-SNAPSHOT_64.so
#5  0x0000000000474078 in hazelcast::client::test::testLatchThread(hazelcast::util::ThreadArgs&) ()
#6  0x00002b2706df8703 in hazelcast::util::Thread::controlledThread(void*) ()
from /root/jenkins/workspace/cpp-linux-nightly/buildSHARED64Release/libHazelcastClient3.7-SNAPSHOT_64.so
#7  0x000000338880683d in start_thread () from /lib64/libpthread.so.0
#8  0x0000003387cd4fdd in clone () from /lib64/libc.so.6
(gdb) thread 7
[Switching to thread 7 (Thread 0x2b27070d5980 (LWP 27708))]#0  0x0000003388807c65 in pthread_join () from /lib64/libpthread.so.0
(gdb) bt
#0  0x0000003388807c65 in pthread_join () from /lib64/libpthread.so.0
#1  0x00002b2706df812c in hazelcast::util::Thread::join() () from /root/jenkins/workspace/cpp-linux-nightly/buildSHARED64Release/libHazelcastClient3.7-SNAPSHOT_64.so
#2  0x00002b2706df8243 in hazelcast::util::Thread::~Thread() () from /root/jenkins/workspace/cpp-linux-nightly/buildSHARED64Release/libHazelcastClient3.7-SNAPSHOT_64.so
#3  0x0000000000478914 in hazelcast::client::test::ICountDownLatchTest::testLatch() ()
#4  0x0000000000480fd5 in iTest::iTestFixturehazelcast::client::test::ICountDownLatchTest::executeTests() ()
#5  0x000000000047aca8 in unitTests(char const*) ()
#6  0x0000003387c1d9f4 in __libc_start_main () from /lib64/libc.so.6
#7  0x00000000004423b9 in _start ()

From the stack trace we see that it is possible to get to thread destructor before testLatchThread function completes.

Is not this because timeout is something that can be reachable when there is load on the system? If we make it a bigger value, test will be more healthy.

This shows that the main thread assertTrue(l->await(10 * 1000)); lines passed before the testLatchThread function finishes. Hence, this suggested to me that the response to await call may arrive earlier than the response to the last countDown call .

This is again 10 seconds is too short for this case.

But we really want the testLatchThread to exit before the l.await passes and the test scope ends, don't we?
It should not matter which one happens first. Threads finished or await passes. Either way test will pass.

By the way, do we know which LockGuard/mutex causes the problem ?

@sancar there is a check for await return assertTrue(l->await(10 * 1000));  This checks passed, meaning that it was not a timeout, does it make sense? We don't have any load on the server.
The guard/mutex here:  https://github.com/hazelcast/hazelcast-cpp-client/blob/master/hazelcast/src/hazelcast/client/connection/CallFuture.cpp line 73, and then https://github.com/hazelcast/hazelcast-cpp-client/blob/master/hazelcast/include/hazelcast/util/Future.h#L88

What if it failed when there is a timeout
Test throws an exception
Causes hazelcast to be closed which makes mutex invalid
And this causes core dump because other thread waiting on mutex.
Because of core dump we don't see the test exception properly.
Do we know how much time test takes when it failed ?

Test log: https://hazelcast-l337.ci.cloudbees.com/view/Clients/job/cpp-linux-nightly/39/console
According to time stamp in the test: started and ended at 19:56:37. It really lasted short.
Which timeout? Timeout in await call? Because, there is no timeout for C++ test run, it can only be either boolean false from the server or some other exception message. I tested both cases:
// throw IException in await call, the test result:
<<<<<<< ICountDownLatchTest >>>>>>
======= 0. ICountDownLatchTest =======
ExceptionMessage {ihsan} at Server:
============FAILED==============
// Put sleep(25) in testLatchThread, result:
<<<<<<< ICountDownLatchTest >>>>>>
======= 0. ICountDownLatchTest =======
Assert[ 3 ] is failed.
============FAILED==============

Test PASSed.

Test PASSed.


minor fix for bfloat16

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


[Proof] Claim & proof lifecycle testing

Objective

Add unit integration coverage for proof module's #SubmitProof() method (analogous to msg_server_create_claim_test.go).
Add integration CLI coverage to claim/proof lifecycle sufficient for testing regression of minimum-viable-testnet (depends on #404).

Origin Document
(See: x/proof/module/tx_create_claim_test.go)

(See: x/proof/module/tx_submit_proof_test.go)

Goals

Ensure comprehensive unit and integration coverage exists for the claim/proof lifecycle sufficient to detect regression of existing validations.

Deliverables

[x] A PR which adds integration coverage of claim creation.

#412

[x] A PR which adds integration coverage of proof submission.

#417

[ ] A PR which adds test coverage of claim creation via the CLI
[ ] A PR which adds test coverage of proof submission via the CLI

Non-goals / Non-deliverables

Refactoring any CLI tests.

General deliverables

[ ] Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
[ ] Testing: Add new tests (unit and/or E2E) to the test suite.
[ ] Makefile: Add new targets to the Makefile to make the new functionality easier to use.
[ ] Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @bryanchriswhite
Co-owners: @red-0ne

Reopening as this calls for CLI test coverage, as currently written, which has not yet been implemented.

Deprioritizing as claims & proofs are typically generated and broadcast by the relay miner, making CLI test coverage less urgent.

Closing this out since it's a lower priority relative to other deliverables.


Hello! Could you tell me how to save and load model's weights in ".pt" file?

@yonda-yonda Thanks very much for your code. I am using this for series anomaly detection on my own data. I want to save the model's weights and load it. Could you help with me?

@943fansi I understand.
And sorry, I didn't care about save and load model.  Surely that's necessary.
Give me a few days to think.

https://github.com/yonda-yonda/tadgan/pull/2
Is it what you want?

@yonda-yonda Yeah. Thanks very much. It solved my problem very well. Do you have any good suggestions and methods for threshold setting of abnormal score?

@943fansi I would have to merge it.
My tadgan is so much better, thanks to your comment.
About threshold settings, see simple comparisons with different parameters (sorry for Japanese text).
https://zenn.dev/yonda/articles/681f32264341cf#a1
So anomaly_score is zscore, if you want to evaluate conservatively, the threshold should be 3.
However, we have to solve each problem accordingly in the end.
The implementation by the author of the paper has some innovations that are not in my code, so I recommend that you refer to that as well.

@yonda-yonda Thanks!


[0.9.1] Including integer literal in continuous query causes panic

I've create a continuous query that downsamples data into 10 second bins.  As part of this query I create a new field length and set it to 10.  This causes the database to immediately crash.
CREATE CONTINUOUS QUERY "downsample" ON mydb BEGIN
    SELECT sum(value), 10 AS length INTO "1h".data FROM "default".data GROUP BY time(10s)
END

I've created a gist that reproduces the crash and includes the crash log: https://gist.github.com/njurgens/9a459ccdc3b8c3a7255b.

It is no longer possible to create a CQ that mixes aggregates and single values:
> create continuous query foo on foo begin
     select sum(value), 10 as bar into newfoo from thing group by time(1m)
   end
ERR: error parsing query: mixing aggregate and non-aggregate queries is not supported