Red Hat vs. CentOS false positives

Is this a request for help?: yes

Is this a BUG REPORT or a FEATURE REQUEST? (choose one): BUG REPORT

Version of Anchore Engine and Anchore CLI if applicable: 0.3.3
What happened:
A scan of a CentOS based image shows vulnerabilities and provides versions that fix the problems. Those versions are already installed in the image. It seems that anchore is not recognizing CentOS version numbers.
$ anchore-cli image vuln image all
Vulnerability ID        Package                           Severity        Fix                             Vulnerability URL
RHSA-2019:0679      libssh2-1.4.3-12.el7         High             0:1.4.3-12.el7_6.2      https://access.redhat.com/errata/RHSA-2019:0679
Anchore reports that libssh2 has a vulnerabilities and that the Red Hat version 0:1.4.3-12.el7_6.2 fixes the problem. Installed is this version:
$ rpm -q libssh2
libssh2-1.4.3-12.el7.x86_64
The versions are identical except for the Red Hat postfix "_6.2" that CentOS does not include in its versions.
What did you expect to happen:
Correct identification of CentOS version numbers and no reported vulnerability.

Any relevant log output from /var/log/anchore:
What docker images are you using:
anchore/anchore-engine:latest
How to reproduce the issue:
Scan a recent CentOS based image that has libssh2 installed (other packages have the same problem like systemd, systemd-libs, openssl-libs)
Anything else we need to know:

Hi @MichaelW-SD
We're not quite seeing the same condition that you describe currently, but wanted to run by what we're seeing.  What I'm seeing currently is demonstrated with the below procedure, which shows that there are packages available in centos that correspond to the versions indicated in the result from anchore:
# docker run -t -i centos:latest /bin/bash
[root@11407c78fde8 /]# yum info libssh2
Loaded plugins: fastestmirror, ovl
Determining fastest mirrors
 * base: mirrors.usc.edu
 * extras: repos.lax.quadranet.com
 * updates: centos.mirror.ndchost.com
base                                                                                | 3.6 kB  00:00:00
extras                                                                                | 3.4 kB  00:00:00
updates                                                                                | 3.4 kB  00:00:00
(1/4): base/7/x86_64/group_gz                                                                                | 166 kB  00:00:00
(2/4): extras/7/x86_64/primary_db                                                                                | 188 kB  00:00:00
(3/4): base/7/x86_64/primary_db                                                                                | 6.0 MB  00:00:01
(4/4): updates/7/x86_64/primary_db                                                                                | 3.4 MB  00:00:01
Installed Packages
Name        : libssh2
Arch        : x86_64
Version     : 1.4.3
Release     : 12.el7
Size        : 334 k
Repo        : installed
From repo   : CentOS
Summary     : A library implementing the SSH2 protocol
URL         : http://www.libssh2.org/
License     : BSD
Description : libssh2 is a library implementing the SSH2 protocol as defined by
            : Internet Drafts: SECSH-TRANS(22), SECSH-USERAUTH(25),
            : SECSH-CONNECTION(23), SECSH-ARCH(20), SECSH-FILEXFER(06)*,
            : SECSH-DHGEX(04), and SECSH-NUMBERS(10).

Available Packages
Name        : libssh2
Arch        : i686
Version     : 1.4.3
Release     : 12.el7_6.2
Size        : 134 k
Repo        : updates/7/x86_64
Summary     : A library implementing the SSH2 protocol
URL         : http://www.libssh2.org/
License     : BSD
Description : libssh2 is a library implementing the SSH2 protocol as defined by
            : Internet Drafts: SECSH-TRANS(22), SECSH-USERAUTH(25),
            : SECSH-CONNECTION(23), SECSH-ARCH(20), SECSH-FILEXFER(06)*,
            : SECSH-DHGEX(04), and SECSH-NUMBERS(10).

Name        : libssh2
Arch        : x86_64
Version     : 1.4.3
Release     : 12.el7_6.2
Size        : 135 k
Repo        : updates/7/x86_64
Summary     : A library implementing the SSH2 protocol
URL         : http://www.libssh2.org/
License     : BSD
Description : libssh2 is a library implementing the SSH2 protocol as defined by
            : Internet Drafts: SECSH-TRANS(22), SECSH-USERAUTH(25),
            : SECSH-CONNECTION(23), SECSH-ARCH(20), SECSH-FILEXFER(06)*,
            : SECSH-DHGEX(04), and SECSH-NUMBERS(10).

#

After updating those packages with 'yum update' and analyzing the updated centos+yumupdates image, anchore is no longer matching those vulnerabilities.
Let us know if this helps to clarify, we're happy to discuss/look closer if you are finding that something isn't lining up in the way you expect.

Thanks for the quick response. You pointed me in the right direction. Our image is not using yum for package management and did not correctly resolve all dependencies.
This was not anchore related at all.


Update repo URLs in the composer.json

I removed the support info, because Composer guesses them from the Github metadata already (the expected values are the one guessed by composer here, except that it was not allowed to guess due to the outdated URLs).
I also changed the description:

the right way to reference Symfony is Symfony, not Symfony2 (the version number 2 must be separated from the name)
use 2+ as the standard is also OK for Symfony 3.

Thanks for your contribution @stof!
Kind regards,
David


New Notification: Liquidity Spread

When market creator's market doesn't pass the default spread filter show a notification.

Needs to say....
The liquidity provided has been depleted and your market no longer is passing the liquidity spread filter.  Add more to have your market seen.
(add more button which would take them to the market) (also needs a don't show me this again for this market - button)

Design for this is here
https://www.figma.com/file/bZh7tOiLm6Ls9Hl4RL6qMC5X/Augur-Redesign?node-id=15137%3A34030

2 Things:
I just created a market with pre-liquidity and see this notification already,,,,dont think I should get it yet
Also the check box need to be changed (probably make the Dont' show me again be a button)....bc I check to dismiss it but then what? how does it go away

we chatted about this. the idea is to check the checkbox then click the add liquidity button then the notification would go away.

Need @matt-bullock  to update design

So the problem with clicking the checkbox and making the user hit the add liquidity button is, If I am the market creator and I added all the liquidity I wish to add.....the events outcome looks inevitable, etc....I would click the checkbox and NOT hit the add liquidity button....so there is no way for me to remove this.....and this will happen extremely often...probably every market
So we have 2 options:

Remove the checkbox and make the "Dont show me this again" clickable (once clicked we remove it)
Add an (x) to dismiss the notification


Beets doesn't seem to be rewriting my tags

Hi,
Every time I run: beet import /mnt/nas/music I see a bunch of entries like:
/mnt/nas/music/Aerosmith/O, Yeah! Ultimate Aerosmith Hits [2002]/AAC (30 items)
Tagging:
    Aerosmith - O, Yeah! Ultimate Aerosmith Hits
URL:
    http://musicbrainz.org/release/7fb9d2db-bf96-45bf-b089-496fe2758c20
(Similarity: 99.2%) (tracks) (2xSACD, 2002, US, Columbia)
SACD 1
 * What It Takes -> What It Takes (id)
SACD 2
This album is already in the library!
Old: 30 items, FLAC, 1017kbps, 132:16
New: 30 items, AAC, 218kbps, 132:18
[S]kip new, Keep both, Remove old? k

Beets shows a difference between the IDs and after I select 'k' (Keep Both) my assumption is that Beets would update the id tag of the 99.2% match to be a 100% match (i.e. fix the mismatch in the id) during the import process. However, this does not happen since if I run the beets import command again I will get the exact same prompt.
My current Beets config is as follows:
library: /mnt/nas/music/.beets/library.db
directory: /mnt/nas/music
plugins: fetchart embedart convert chroma info scrub lastgenre
import:
    move: yes
paths:
    default: $albumartist/$album [$year]/$format/$artist - $track - $title
    singleton: Non-Album/$artist/$format/$artist - $title
    comp: Compilations/$album [$year]/$format/$artist - $track - $title
convert:
#    auto: yes
    dest: /mnt/nas/music
    paths:
        default: $albumartist/$album [$year]/AAC/$artist - $track - $title
        singleton: Non-Album/$artist/AAC/$artist - $title
        comp: Compilations/$album [$year]/AAC/$artist - $track - $title
    never_convert_lossy_files: true
    format: aac
    formats:
        aac:
            command: ffmpeg -i $source -y -codec:a libfdk_aac -vbr 5 $dest
            extension: m4a
        mp3:
            command: ffmpeg -i $source -codec:a libmp3lame -q:a 2 $dest
            extension: mp3
#chroma:
#    auto: no
scrub:
    auto: no

Note that I have the "scrub" plug-in enabled and I ran a manual "beet scrub album:'ultimate aerosmith' format:'aac'" before the import to no avail.

The ID mismatch is probably coming from Chromaprint, not the tags themselves. Have you tried disabling that? If that changes anything, it's probably just a false negative from the fingerprint database.

Yep, you're right, that did appear to fix the issue. Is there a way to set up some sort of tolerance for this? i.e. if the choma signature is only slightly different consider it a match?

It's not really possible; the comparison is done server-side in the acoustid database. Unfortunately, false negatives are just a fact of life using a heuristic like fingerprinting.


Invalid hook call error after upgrading from 0.61.5 to 0.62.2 or further

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
I have a yarn workspace monorepo project which contains a shared folder along with react-native and react projects. Before the upgrade I could build and run both native and web project with no issue. After upgrading to 0.62.2 or further versions I started getting invalid hook call error on both redux and react-navigation packages.
React Native version:
System:
OS: macOS 10.15.1
CPU: (4) x64 Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz
Memory: 3.64 GB / 16.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 12.12.0 - ~/.nvm/versions/node/v12.12.0/bin/node
Yarn: 1.19.2 - /usr/local/bin/yarn
npm: 6.11.3 - ~/.nvm/versions/node/v12.12.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.9.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK: Not Found
IDEs:
Android Studio: 4.0 AI-193.69<IP_ADDRESS>14223
Xcode: 11.3/11C29 - /usr/bin/xcodebuild
Languages:
Java: 13.0.1 - /usr/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: 0.63.2 => 0.63.2
npmGlobalPackages:
react-native: Not Found
Steps To Reproduce

Upgrade react-native version 0.62.2 or above while using monorepo.

Expected Results
To build without any errors.
Snack, code example, screenshot, or link to a repository:

Hi @MrtYlnzz thanks for the issue! To investigate, could you provide a repro that consistently throws this error? Thanks!

Hello @safaiyeh here is a demo repo showing the said error. It's a simple setup of what I use. https://github.com/MrtYlnzz/rn-invalid-hook.git

Can confirm same issue. Fire up the CLI and build a TS project. Make a component with a hook. Consume it at app.tsx
regressing versions right now to confirm the roll back.

@MrtYlnzz I checked the repo you provided, I do not see any usage of hooks? Could you point it out to me, I must be missing something.

@safaiyeh That's actually what the issue is, react-navigation do use hooks inside their functions and whenever I import react-navigation it gives the mentioned error.

Got it, could you make an issue with react-navigation? This should be a common problem they have seen they should have ways to help you.


[SPARK-15223] [DOCS] fix wrongly named config reference

What changes were proposed in this pull request?
The configuration setting spark.executor.logs.rolling.size.maxBytes was changed to spark.executor.logs.rolling.maxSize in 1.4 or so.
This commit fixes a remaining reference to the old name in the documentation.
Also the description for spark.executor.logs.rolling.maxSize was edited to clearly state that the unit for the size is bytes.
How was this patch tested?
no tests

Can one of the admins verify this patch?

LGTM

Jenkins test this please

Test build #58135 has started for PR 13001 at commit 3cbec74.

Test build #58135 has finished for PR 13001 at commit 3cbec74.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58135/
Test PASSed.

Merged build finished. Test PASSed.

Merging into master 2.0


python312Packages.androidtv: 0.0.73 -> 0.0.74

Diff: https://github.com/JeffLIrion/python-androidtv/compare/v0.0.73...v0.0.74

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 352212

x86_64-linux

:white_check_mark: 5 packages built:

home-assistant-component-tests.androidtv
python311Packages.androidtv
python311Packages.androidtv.dist
python312Packages.androidtv
python312Packages.androidtv.dist


Update references in configuration variable implementation

PR Summary
Commit updates the references in doc/developer-guide/config-vars.en.rst.

[approve ci]

[approve ci]

[approve ci]

[approve ci]

Cherry-picked to v10.0.x


Add new repos from SQL to offline whitesource scan

Description
Add recently onboarding new repos to our offline security scan.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2985 (77ab17c) into main (fd4a950) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2985   +/-   ##
=======================================
  Coverage   92.87%   92.87%
=======================================
  Files         167      167
  Lines        4602     4602
=======================================
  Hits         4274     4274
  Misses        328      328

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Can you change the title of the PR to more appropriate one. Something like adding newly separated repos to whitesource?

Can you change the title of the PR to more appropriate one. Something like adding newly separated repos to whitesource?

Thanks for pointing out. Updated the title. Thanks.

Merging as the vulnerability check doesn't fail because of this PR.


Have CLI take preference over config for verbosity

If a CLI option is passed, that trumps any command line configuration, otherwise
just do what we did previously.
Closes #2588

r? @huonw
(rust_highfive has picked a reviewer for you, use r? to override)

r? @brson

@bors r+

:pushpin: Commit b40e1db has been approved by brson

:hourglass: Testing commit b40e1db with merge 8975f30...

:sunny: Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64


invalid token response

I doubt if everyone is experiencing the same thing or not? i can't get valid token when using getToken function. The response from the function is always the raw response from the API (with some being truncated due to "substrings" in some variables) as shown below.

I think the issue is in the "end" variable
https://github.com/threadsjs/threads.js/blob/292df7d245497de65a6eff6e2c3704b5d7005cbe/src/index.js#L55
But I can fix it with the code below
const pos = text.search("Bearer IGT:2:");
const sliced = text.substring(pos);
const token = sliced.substring(13, sliced.search(/\\\*?/gm));
return token;

Do I need to open a new pull request or is there another way to fix this problem?

I have the same issue. I was wondering why nobody has encountered that. Would just do a PR and see what @elijah-wright thinks.

I doubt if everyone is experiencing the same thing or not? i can't get valid token when using getToken function. The response from the function is always the raw response from the API (with some being truncated due to "substrings" in some variables) as shown below.

I think the issue is in the "end" variable
https://github.com/threadsjs/threads.js/blob/292df7d245497de65a6eff6e2c3704b5d7005cbe/src/index.js#L55
But I can fix it with the code below
const pos = text.search("Bearer IGT:2:");
const sliced = text.substring(pos);
const token = sliced.substring(13, sliced.search(/\\\*?/gm));
return token;

Do I need to open a new pull request or is there another way to fix this problem?

Also tried your solution and it works for me.

I have the same issue. I was wondering why nobody has encountered that. Would just do a PR and see what @elijah-wright thinks.

ok I would open a new PR

Actually, I have a fixed parser, but I haven't finished implementing the 2FA method yet, so I will make a pull request with 2FA as soon as possible.


Incorrect permission displaying module is used for roles' permission display during the user creation wizard

Describe the issue:

Try user creation flow.
There is a step to assign roles
For a given role, you can see a key icon to view permissions of the role
It shows the old permission tree model instead of actually assigned permissions through API resources

https://github.com/wso2/product-is/assets/25483865/fb9f8b7c-d27b-4bd7-b03b-724c70d3bff8

This issue depends on https://github.com/wso2/product-is/issues/17645.
If we decides to remove role assignment option during user creation, nothing to be fixed in reported issue in #17647

Population of API Resource permissions without the old IS Permissions is a critical level issue as it hinders a user from  viewing the permissions relevant to a role before adding it to a user


[Feature Request] Support for multiple source schema registries

Consider the case where the smt is used by replicator consuming different topics that contain messages registered with different schema registries.
Currently, we workaround this by having multiple connect configs with different smts attached.
I think it would be nice to be able to pass a pattern based mapping for registries.
department_a_events * --> schema reg A
department_b_events* --> schema reg B

Config wise:
transforms.AvroSchemaTransfer.dest.schema.registry.urls=[http://schema-registry-2:8081, http://schema-registry-3:8081]
transforms.AvroSchemaTransfer.dest.schema.registry.topic.mappings=[department_a_events *, department_b_events *]

What do you think? I guess I would be able to provide a PR for this. I would suggest to keep the existing properties as they are and use
transforms.AvroSchemaTransfer.dest.schema.registry.url=http://schema-registry-2:8081

as fallback if none of  the patterns matches

pass a pattern based mapping for registries

My main concern would be what if you had N registries and M topic patterns where N != M ? How would that mapping line up?
I personally see nothing wrong with having separate connect tasks for separate topics configured for different registries.

My main concern would be what if you had N registries and M topic patterns where N != M ? How would that mapping line up?

One would need to force a 1:1 mapping so that n=m, repeating entries potentially.
Now I am uncertain myself :). In our setup I planned to organize the connect replicators by domain, instead I'm finding myself in a situation where replicators are split by the source registry. This also means that there are configs for a single topic only.
But, yes, I do understand that this feature might be considered overkill and bloats the config api.

replicators are split by the source registry. This also means that there are configs for a single topic only.

I think one benefit to this is that the error handling is simpler and isloated if a task fails to contact the registry.
Besides that, see "Mistake #2" 😃
https://www.confluent.io/blog/17-ways-to-mess-up-self-managed-schema-registry

Convinced. Let's close it :)
Well, of course it makes sense to have a central schema registry. Bu as you know, sometimes it is weird political circumstances that lead to such violations.


Cant connect to Apple APN Gateway

I've tried every which way to export the cert but for some reason I am never able to connect. Im currently on v1.7.8 because this is an older app. When I startup the app I am getting the following error
APN GATEWAY ERROR Error:<PHONE_NUMBER>49952:error:14094416:SSL routines:SSL3_READ_BYTES:sslv3 alert certificate unknown:../deps/openssl/openssl/ssl/s3_pkt.c:1292:SSL alert number 46

  at SlabBuffer.use (tls.js:235:18)
  at CleartextStream.read [as _read] (tls.js:455:29)
  at CleartextStream.Readable.read (_stream_readable.js:341:10)
  at EncryptedStream.write [as _write] (tls.js:369:25)
  at doWrite (_stream_writable.js:226:10)
  at writeOrBuffer (_stream_writable.js:216:5)
  at EncryptedStream.Writable.write (_stream_writable.js:183:11)
  at write (_stream_readable.js:602:24)
  at flow (_stream_readable.js:611:7)
  at Socket.pipeOnReadable (_stream_readable.js:643:5)
  at Socket.emit (events.js:92:17)
  at emitReadable_ (_stream_readable.js:427:10)
  at emitReadable (_stream_readable.js:423:5)
  at readableAddChunk (_stream_readable.js:166:9)
  at Socket.Readable.push (_stream_readable.js:128:10)
  at TCP.onread (net.js:529:21)

I have tried googling the error and I can't seem to find a fix. In keychain it is saying my cert is valid. I am using an exported p12 from keychain. Any help you can give me would be amazing and thank you for your time.

It could be that your system doesn't trust the server certificate presented by APNs.
What's your OS and which node version are you using? Can also post a code snippet and show how you create your connection object.

OS: OS X El Capitan
Node: 0.10.35
var options = {
    pfx: path.resolve(__dirname, '../../apn/apn-cert-2016.p12'),
    production: true
};
var apnConnection = new apn.Connection(options);

It's weird because up until I needed to update my certificate this same exact code has been working perfectly.
Do you know how I can check if it's an issue with my system not trusting my certificate?
Thank you again for the help.

Maybe APNs rejects your client certificate. Please try the steps mentioned in the wiki Preparing-Certificates.


Stack overflow when object property's value is process.stderr

node: 8.9.2
deepmerge: 2.1.1
I'm trying to merge two objects, one of which is configuration for Bunyan, and uses process.stderr as its output. Using that value causes a "Maximum call stack size exceeded" error when trying to merge the objects.
Simple repro as follows:
const merge = require('deepmerge');
const a = {
  log: process.stderr
};

const b = {};

const c = merge(a, b); // Throws "Maximum call stack size exceeded"

Output:
/project-dir/node_modules/deepmerge/dist/umd.js:28
function isReactElement(value) {
                       ^

RangeError: Maximum call stack size exceeded
    at isReactElement (/project-dir/node_modules/deepmerge/dist/umd.js:28:24)
    at isSpecial (/project-dir/node_modules/deepmerge/dist/umd.js:21:6)
    at Object.isMergeableObject (/project-dir/node_modules/deepmerge/dist/umd.js:9:7)
    at mergeObject (/project-dir/node_modules/deepmerge/dist/umd.js:50:14)
    at deepmerge (/project-dir/node_modules/deepmerge/dist/umd.js:79:10)
    at cloneUnlessOtherwiseSpecified (/project-dir/node_modules/deepmerge/dist/umd.js:38:5)
    at /project-dir/node_modules/deepmerge/dist/umd.js:57:23
    at Array.forEach (<anonymous>)
    at mergeObject (/project-dir/node_modules/deepmerge/dist/umd.js:55:22)
    at deepmerge (/project-dir/node_modules/deepmerge/dist/umd.js:79:10)

Sounds like the same issue as #115 - I assume there's a cycle somewhere in process.stderr.


Add support for latest vcpkg release

We are using vcpkg for some github actions for our CI builds. We currently build vcpkg from github, latest sources but that is tricky. We don't want to have the burder to manually update our github actions to a new release, would it be possible to have a latest release option, when that is set run-vcpkg could see what is the latest release from github (currently https://github.com/microsoft/vcpkg/releases/tag/2020.06) and build that? At the moment there is a new release it would be automatically used.

for people asking for the latest, vcpkg has added the support for caching packages on local/cloud machines.
for GHA, this is the code:
      - name: Setup NuGet Credentials
        run: |
          & $(vcpkg fetch nuget | select -last 1) sources add `
          -source "https://nuget.pkg.github.com/${{ github.repository_owner }}/index.json" `
          -storepasswordincleartext `
          -name "GitHub" `
          -username ${{ github.repository_owner }} `
          -password "${{ secrets.GITHUB_TOKEN }}"

      - name: vcpkg package restore
        run: |
          vcpkg install "your packages"

Please take a look to run-vcpkg@v10 and see if suites your needs. Feel free to reopen this or a new ticket about any problem you may see.


[FLINK-32176] Exclude snakeyaml from pulsar-client-all to mitigate CVE-2022-1471

Purpose of the change
Mitigate the imapact of CVE in flink
Brief change log
Exclude snakeyaml from pulsar-client-all
Verifying this change
Significant changes
No significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for
convenience.)

[ ] Dependencies have been added or upgraded
[ ] Public API has been changed (Public API is any class annotated with @Public(Evolving))
[ ] Serializers have been changed
[ ] New feature has been introduced

If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)

@Samrat002 IIUC, you want to remove the snakeyaml dependencies in the flink-connector-pulsar. But I don't think this PR works. All the snakeyaml classes has been shaded in the fat-jar of pulsar-client-all. You can't remove it from pulsar-client-all by simply using a <exclude> directive. BTW, Pulsar client didn't use snakeyaml internally. So the CVE you report on snakeyaml won't occur on flink-connector-pulsar.

I have one query regarding this, Do we really need pulsar client all here in flink connector pulsar ? Cant we just use the only pulsar client that is used , using pulsar client all will bring other client that is not required here . Looking forward to hear your opinion on it

I'm quite willing to answer this question because a lot of people ask the same question while a lot of the hidden details is not well documented.
Pulsar has two kinds of the Java client, the admin API and the client API. pulsar-client only contains the client API while our connector highly relies on the admin API to solve some bugs in client API and fulfil the missing features in client API. So we can't use the pulsar-client separately. Since the pulsar-admin and pulsar-client are both depending on a lot of duplicated dependencies. The only way to avoid the class conflicting and to have a clean dependency tree is just using the pulsar-client-all.
We are planning to drop the admin API usage because it just exposes a lot of dangerous operation to the end users and a lot of permission issues occurred. But this should take a long time to accomplish the pulsar client. We are still on the way.

I think we can just close this PR and wait an upstream client bumping. WDYT? @tisonkun @Samrat002

We are planning to use the LTS version of the Pulsar client. But the ci can't be passed cause some strange test issues


not working on @just-web/events

SyntaxError: The requested module '@unional/events-plus' does not provide an export named 'JustEventDuo'

Due to isolatedModules

Fixed by following isolatedModules restriction.


Restart stateless service replica throws 400

It appears that stateful/stateless service replicas both use the same endpoint for the restart action? a Stateless service had a undefined in the URL

#233


[feature request]: Add an Examples folder to the project hierarchy.

Contact Details
<EMAIL_ADDRESS>Is your feature request related to a problem? Please describe.
V2 examples are embedded in the README.md file. I have found that good working examples, make excellent components for integration/acceptance testing, driven by unit tests.
Describe the solution you'd like

Create Examples directory.
Add to that, an example for each algorithm/major feature of CryptoNet, as separate console projects.
Add unit test to the CryptoNet.UnitTests to cover each new example app.
TBD: List of example worthy features.

Describe alternatives you've considered
No response
Additional context
No response
Priority Level
Medium
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I have driven some development this way. Create a feature example project and unit test driver, for TDD and then I wind up with a descent example usage that I can point to in my docs (whenever I get around to those).

Draft PR: https://github.com/maythamfahmi/CryptoNet/pull/103/files
I have not removed CryptoNet.Cli yet. I still need to evaluate the coverage situation.

Thanks, I am reviewing now, just have seen some files like CryptoNet.vtg, CryptoNet.vpwhist, CryptoNet.vpw, CryptoNet.vpj is those suppose to be part of the solution? maybe we need to add following to gitignore
Ignore SlickEdit files.
*.vpj
*.vpw
*.vpwhist
*.vtg
Let me know what you think?

With this solved, #87 and #88 will be not needed and can be close when this is merged to https://github.com/maythamfahmi/CryptoNet/tree/version3

Yes! I forgot to add that to the .gitignore file, will fix shortly...

All comments resolved.


Add template functions to the language

This could be done by "turning" inline generic functions into templated functions (this may or may not have been the case in the past, I vaguely remember something about it).
For example:
adder: inline func <T> (a, b: T) -> T {
    a + b
}

"#{adder(2, 40)}" println()

adder("hi", 12) // Resolve error: No operator + for String, Int

f: func <T> (arg: T) {
    f(arg, arg) // This should also error out, can't actually pass "real" generics
}

This would be a real challenge to implement but I do think it is a worthwhile investment.
Alternatively, to make it clearer that the function is templated instead of using generics, this syntax (which matches cover templates) would be better (?):

adder: template<T> func (a, b: T) -> T {
    a + b
}

// Perhaps even allow

adder: template<T, U> func(a, b: T) -> U {
    a + b
}

This can already be emulated using a stateless template cover with static functions, although I'm not sure if you can (correctly) get the address of those functions.
I just think it's nicer that way.
Ideally, it should also be possible to generate and take the address of such a function in a context sensitive way.
For example:
apply: func(a, b: Int, f: Func (Int, Int) -> Int) -> Int {
    f(a, b)
}

mult: template<T> func(a, b: T) -> T {
    a * b
}

// Ideally, should generate mult<Int> and take it's address
apply(0, 0, mult)

Otherwise, I guess we would need to be able to manually instanciate the templates and thus add some kind of syntax:
apply(0, 0, mult<Int>)

Imho, this would be too confusing because of the generic/template "clash".

We could even take the Java/C++ route and generate cover templates as seen in the previous comment then replace accesses to the function to the static cover method.
This would still need some way to instanciate the function manually, though, and I personally think it is an inelegant solution

This is not needed, closing.

why not needed? :)

@vendethiel I think adding class templates and working a bit on inferring will be enough templates for us.
You can basically do this with the trick I showed above anyways.
After I add class templates, rock will be considered feature-complete, at least in language features.
Of course, additions to the sdk and rock's functionality itself will be always welcome.

Okay, thanks!


Training on my own data

When I try and train on my own dataset, I include files for all 20 viewpoints per the README, but when I perform random sampling on the manifold I get results (the 5x5 grids) that are the same for each viewpoint. However when I train with the same arguments on class data from ShapeNet Core through the provided link (e.g. headphones) then I am able to get expected results with different views for each viewpoint. Could you offer any ideas of what I might be doing wrong with my data? Thanks.

@acerio98 I'm not entirely sure what might be causing this but if the produced samples are sharp and are not blurry it probably means that the model is over-fitting the data. If the samples are pretty blurry you will need to give more data/time to the model to get trained.

Okay, after some poking around I have an idea of what the problem may be. I'm training the model on a set of long, narrow objects (sword models) and my theory is that the network is only picking up on the very tip of the models since that is the only part that appears as a strong white in any of the depth maps, given that that part gets closest to the camera while rending the maps.
I guess my question now is whether there is any way to make the network more sensitive to  features in the depth maps that may not be as strong (i.e. features that appear in the gray range rather than pure white, as in the example below).

Is this just a matter of giving the network more data or epochs to train, like you say? I'd appreciate any tips you could offer.

@acerio98 Sorry for getting back to you with a lot of delay. Somehow I missed your question here. The major things that contribute to getting sharper results (e.g. the model pays attention to small details) are a good model architecture, training the model longer and more importantly replace VAE with another generative model whose assumptions (i.e. regularization) does not cause the decoder to behave conservatively when mapping the latents to the output, as vanilla VAE does that. More data should help too.


Adaptation problems with the Outliner plugin in the new Live Preview mode

Hi, thank you for developing such an excellent theme. However, I noticed that the vertical line for the outline disappeared in the new version of the theme with the outliner plugin. I remember that in the old version when using Outliner the vertical lines would appear. You can see the picture below.

The vertical lines under the original theme can be displayed, please see the image below

I'm having this issue as well.

Obsidian now has these lines built-in. Feel free to close this issue :)


Admin endpoint to query the in/out topic name of an OMAS

The Stewardship server needs to know the in/out topic names of the Stewardship Action OMAS.  It has the platform URL root and server name. This enhancement provides an admin services REST endpoint to allow it to query the topic names.
For configuration in cloud environments, it is necessary to pre-configure the topic names.
This enhancement will also provide a list of all topic names being used by a server (including the cohort topics)
For completeness/consistency, this feature will also provide the ability to query the cohort topic names @planetf1

Decided to close this one as the lab notebooks show how easy it is to do this from the existing calls.


document checkpatch

Checkpatch can be added to the pre-commit hooks as follows:

Create .git/hooks/pre-commit
Make the executable: chmod +x .git/hooks/pre-commit
Add the following code to the pre-commit file:

#!/bin/sh
set -e exec
exec git diff --cached | ../deps/zephyr/scripts/checkpatch.pl -

This uses the .checkpatch.conf in this repo (from our Zephyr SDK) and the instructions come form the Zephyr Code Styling docs. This should be documented somewhere.

This is stale.


re-add tx ibc wasm

fix-up for accidental removal from #882 (based on the fraccaman/nft-impl, which was before the toolchain update so CI won't pass)

not quite complete, it's also removed other places

not quite complete, it's also removed other places

oh yeah, thanks!

ah, looks like I also don't have the up-to-date base


Fix phpdocs and small bug

Fix small bug, fields need be array by default beacuse yii parse string to array only if option is array by default (https://github.com/yiisoft/yii2/blob/master/framework/console/Controller.php#L84).
I fix test too, sorry for my mistake

Merged. Thank you!

@SilverFire why do you  know test fail with hhvm? i dont understand.

Because of 1-second lag and missing body https://travis-ci.org/yiisoft/yii2/jobs/93006055#L220
When I checked the HHVM test fail I didn't see the missing body option. I'm not sure why this happens in HHVM only :thought_balloon:

It is a strange behavior. i will check with hhvm in local.

@SilverFire  i think regular expression was wrong. check my pr https://github.com/yiisoft/yii2/pull/10248

Thank you, merged


Add a Filter Rows Shortcut Action

Users have the need to sometimes sort an outlines rows. See #179 for details.

A sample Shortcut should be created that shows how to do this and it should be added to the help documentation.


FIX docblock types

Description
Fix/improve return types for public facing apis
Manual testing steps
Nothing, just phpstan being happy
Issues
https://github.com/silverstripe/silverstripe-framework/issues/11173
https://github.com/silverstripe/silverstripe-framework/issues/11149
Pull request checklist

[x] The target branch is correct

See picking the right version

[x] All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)

Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.

[x] The commit messages follow our commit message guidelines
[x] The PR follows our contribution guidelines
[x] Code changes follow our coding conventions
[x] This change is covered with tests (or tests aren't necessary for this change)
[x] Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
[x] CI is green

Can you please tick all of the appropriate checkboxes? It's intended both as a "have I done everything I need to?" checklist for you, as well as a "Is the contributor still working on this or is it clear there is still more to do?" list for maintainers.
As it stands, with none of the boxes ticked, it looks like this isn't even ready to be reviewed.

Please also link to an open issue - we can't track closed issues

@GuySartorelli  issue created https://github.com/silverstripe/silverstripe-framework/issues/11173

Ahh, I didn't notice this has a bunch of commits, so I'll have to squash merge anyway, so I can change the commit message during that process.


Remote debug android arm64, lldb failed to read from single register

OS: ubuntu 20.04
VSCode version: 1.63.0-insider
CodeLLDB version: v1.7.0
Compiler: android-ndk-r21e
Debuggee: android arm64

The problem: In VSCode's CodeLLDB debug prompt, the command register read x0 gives no result, which differs from directly using LLDB command, for the android arm64 remote debugging.
The code
#include <stdio.h>

struct Test
{
    int i;
    Test()
    {
        i=23;
    }
    void hello(int a, int b, const char* name)
    {
        int c = a + b;  // !! please set a break point in this line, then execute `register read x0`
        c += i;

        for (int j = 0; j < c; j++)
        {
            if (name)
            {
                printf("hello, %s\n", name);
            }
            else
            {
                printf("hello, world\n");
            }
        }
    }
};
int main()
{
    Test obj1;
    const char* name = "ChrisZZ";
    int a = 1;
    int b = 2;
    obj1.hello(a, b, name);
    printf("done\n");

    return 0;
}

VSCode CodeLLDB remote debug output:

LLDB command remote debug output:
(
lldb --version
lldb version 15.0.0git (/home/zz/work/github/llvm-project/lldb revision c2a8a104ec320c8bed39c3632eae2fb37f53487b)
clang revision c2a8a104ec320c8bed39c3632eae2fb37f53487b
llvm revision c2a8a104ec320c8bed39c3632eae2fb37f53487b
)

The full produce project is uploaded in https://github.com/zchrissirhcz/min-repros/tree/master/test_codelldb_remote_arm64_read_register , including the scripts to compile, and the json files for vscode debugging.
BTW, my settings.json of VSCode is:
    // CodeLLDB plugin

    // "lldb.library": "/home/zz/soft/llvm15-dev/lib/liblldb.so",
    // "lldb.adapterEnv": {
    //     "LLDB_DEBUGSERVER_PATH": "/home/zz/soft/llvm15-dev/bin/lldb-server"
    // },
    // /home/zz/soft/llvm15-dev/bin/lldb
    "lldb.launch.initCommands": ["command source ${env:HOME}/.lldbinit"], // 加载用户的 ~/.lldbinit
    "lldb.verboseLogging" : true,

And the loaded ~/.lldbinit file is with only contents:
settings set target.x86-disassembly-flavor intel
command alias reload_script command source ~/.lldbinit

Codelldb bundles lldb 14, you seem to be using one compiled from llvm main branch.  Could this be a recent bug fix?

I've tested again, with codelldb using my build lldb, and it can read registers correctly:
    "lldb.library": "/home/zz/soft/llvm15-dev/lib/liblldb.so",
    "lldb.adapterEnv": {
        "LLDB_DEBUGSERVER_PATH": "/home/zz/soft/llvm15-dev/bin/lldb-server"
    },

There are actually many updates in LLVM repo for LLDB:
~/.gitconfig:
[alias]
    hist = log --pretty=tformat:'%Cgreen%h%Creset %ad | %s%d %C(bold blue)[%an]%Creset' --graph --date=short

git hist llvmorg-14.0.0..c2a8a104ec320c8bed39c3632eae2fb37f53487b | ag 'lldb' | wc -l

Thanks for checking!   Once LLVM 15 is out, I'll update the bundled liblldb.

Did this get resolved in v1.8.1?

Did this get resolved in v1.8.1?
I've tested again, removing the customization of lldb path, update to latest codelldb(v1.8.2), and it successfully read registers x0, x1 and x2. I think it is solved now.

The screenshots:


Bad file descriptor

I'm using laravel 5.4 in windows OS ran via WAMP. I get this error ZipArchive::close(): Failure to create temporary file: Bad file descriptor. I googled everywhere but no fix found so I decided to reach the devs of the library. If this helps here's my code.
$excel->store('xlsx', storage_path('exports'));

Duplicate of #1135


Presence#history wasn't working (infinite recursion)

(Conflicts) Separated base ARTPresence: ARTRealtimePresence and ARTRestPresence
ARTRestPresence has base class for ARTRealtimePresence

This looks good, however I am a bit confused by the naming now.  Previously it was something like ARTObject, so ARTClient stood for Ably Real-Time Client, however now it seems we are doubling up on Realtime i.e. ARTRealtimePresence.  I realise in Java the realtime class names are prefixed with Realtime, but it does feel a bit odd.  Out of interest, just so that I know, what do you think about the classes simply being AblyRealtime* and AblyRest* instead?  How difficult would this be to change i.e. are there refactoring tools built into Xcode?


museovirastoarcrest_rkykohteet not visible on test server

Currently, on test server, the RKY objects (all 7 of them) are found in the db, but the tile server returns http 500 when asking for those tiles.
This means they are not shown on the map or on tile server preview.
Could not reproduce this locally, they show up alright on my dev install. Also, they are identical in the db.
Perhaps something wrong with the layer read rights on the test server??

Looks like also access privileges are identical. Will have to check Postgres logs and tile server logs.


Issue in running packages

Description:
Consider the folllowing project structure.
├── ma
│   └── main.bal
├── ma:in
│   └── main.bal

ma/main.bal -
import ballerina/io;

public function ^"in:test"(int i) {
    io:println("Test 2");
}

ma:in/main.bal -
import ballerina/io;

public function test(int i) {
    io:println("Test 1");
}

When we run the following command, test function in ma:in/main.bal will be executed.
ballerina run ma:in:test 10
There is no way to run the in:test function in ma package.

This is no longer valid since we don't allow running any public function in a package now.


Endpoint for Posting a notification order (publish event for immediate sending)

Description

Endpoint for posting a notification (syncron) should save to database and push to Kafka-topic.
Screenshots

Considerations

Is from address required to provide? What is our default sender?
Is sendersReference required?

Ops requirements

Specification tasks

swagger for  API

Development tasks

[ ] Create new controller and endpoint for post notification
[ ] Create service for save notification
[ ] Create necessary database tables (procedures, functions?)
[ ] Create repository-classes
[ ] Create client for send message to Kafka (topic-name?)
[ ] Add authorization to endpoint (ScopeOrAccessToken)
[ ] Documentation (docs.altinn.studio) is updated (if relevant)

[ ] Technical documentation

[ ] QA
[ ] Manual test is complete (if relevant)

Test

Acceptance criteria

[ ] Posting a new notification should save to postgres and publish new message on Kafka topic
[ ] Invalid input should be denied (bad request)
[ ] Unauthorized users should be denied post

openapi3_1.yaml.txt


2.9.0 change the order of parameters in operations

After upgrading to 2.9.0 from 2.8.0, the parameters of my operations are now sorted alphabeticaly instead of following the order of declaration in the java method. This is a problem because I generate a client with Swagger codegen and the parameters are no longer in the order my app expect them to be.

@fgoulet the order has never been guaranteed. It just happened to be consistent and stable. What we discovered when moving to java 8 compiler was that the order changed. When we realized that was the case, the parameters were changed to being alphabetically sorted; to maintain stability of the order, atleast going forward.
Sadly, it has affected your application. Going forward, the ordering will be more stable.

Thanks for the explanation. I think a way to enforce a particular order for parameters would be much needed, especialy in client code generation scenario. Is it something that could be eventualy done via the @ApiParam or @RequestParam annotations ?

@fgoulet, perhaps a custom annotation even. The underlying model for the specification doesnt guarantee an order regardless.

Gosh, this is a bummer.  One of the things that made SpringFox so great is that it generated easy-to-use screens, good enough for developers, and even Business folks to use for things like Admin screens and other "not so important to get the UI team involved" endpoints.  Being able to keep the parameters in order was nice, since logically, "startDate" comes before "endDate", even though the alphabet doesn't think so.  Is there any way to work to preserve the order, or even specify the order?
(I hate it when specs get in the way of doing the "right" thing)

Another reason to have default sorting match the order of declaration in the code; grouping of required and optional parameters. In my case the first parameters declared are required parameters (because they are path parameters), while the rest are query-parameters and optional. Since the parameters are now sorted alphabetically, the required and optional parameters are mixed and it's not. Clearing this up would require adding extra annotations to ensure the desired sorting. Manually adding annotations to get the right sorting in Swagger would be a lot of extra work and another thing to maintain, so I'll be sticking to 2.8.0 for now.

@livarb the data structure doesn't guarantee order, it is a Map so the order which some parameters appear cannot guarantee order unless its a List. I understand your concern however. We can add a feature to respect specified order, but that would require a request swagger-core to add a sort order for parameters in teh annotation. It is also feedback that should go back to the OpenApiSec.

Just to provide some feedback, this change may have made springfox unusable for us, unfortunately. We're trying to see what we can do to restore the order within the confines of springfox, but it looks like it isn't easily doable, so we may have to explore other options.

I fully agree with @meowfaceman and @livarb.
@dilipkrish I dont get your argument. It worked before - did you change the underlying data structure? And even if it is a map now you can easily swith to a SortedMap for example.

Provide some option to choose whether to sort the parameter alphabetically or preserve the operation parameter order.
If it uses Map then LinkedHashMap preserve the insertion order. Or choose some Map that preserve the order as it is depending on user choice

I was using Java Configuration to create the client and was using the generated client in other application.
When I updated the springfox version 2.9.2 then in the new client the parameter order is changes. It is in sorted order now. It is breaking my integration as in older version, the parameter was in the order as listed in API.

I don't understand why UiConfiguration can't just have a sorter based on the order of the getters/setters of the java beans for POST requests? Doesn't "OperationsSorter.METHOD" effectively do the same to sort the endpoints' display on the UI?

Just to provide some feedback, this change may have made springfox unusable for us, unfortunately. We're trying to see what we can do to restore the order within the confines of springfox, but it looks like it isn't easily doable, so we may have to explore other options.

Does anyone find an alternative? This problem also makes springfox not suitable for my needs.

We moved to swagger-maven-plugin in the meanwhile. The documentation is a bit lacking, but it preserves the order of methods.

I had a look at the source code. It's not a problem with Map limitation, it's a deliberate choice to sort parameters in an arbitrary order (from the user point of view).
Here is the commit: https://github.com/springfox/springfox/commit/4ab3fc60a7017a948662aebab88a9aa24510a8bc
I posted here an ugly workaround:  https://github.com/springfox/springfox/issues/2705

So I've put up PR #2721, which allows the following Plugin (Kotlin, adapt as needed if the PR gets merged) to restore the previous parameter order:
@Order(SwaggerPluginSupport.SWAGGER_PLUGIN_ORDER + 1000)
class OriginalParamOrderPlugin : ParameterBuilderPlugin {

  override fun apply(parameterContext: ParameterContext) {

    val order = parameterContext.resolvedMethodParameter().parameterIndex
    parameterContext.parameterBuilder().order(order)

  }

  override fun supports(delimiter: DocumentationType) = true

}

@shartte, have you tested your plugin? I've written a similar plugin implementing ExpandedParameterBuilderPlugin that sets the parameter order by context.getParameterBuilder().order(orderValue), however, the desired order is not respected by Swagger.
Digging into the code, I've found out that Springfox finally orders the parameters by name:
https://github.com/springfox/springfox/blob/master/springfox-core/src/main/java/springfox/documentation/service/Operation.java#L84 (as @fathzer has mentioned above):
parameters.stream().sorted(byParameterName()).collect(toList());

The order field is not taken into account.

Why was this ever closed? @dilipkrish

@kroka as mentioned, my plugin depends on the linked PR being merged
On Thu, Oct 11, 2018, 16:31 kroka<EMAIL_ADDRESS>wrote:

@shartte https://github.com/shartte, have you tested your plugin? I've
written a similar plugin implementing ExpandedParameterBuilderPlugin that
sets the parameter order by
context.getParameterBuilder().order(orderValue), however, the desired
order is not respected by Swagger.
Digging into the code, I've found out that Springfox finally orders the
parameters by name:
https://github.com/springfox/springfox/blob/master/springfox-core/src/main/java/springfox/documentation/service/Operation.java#L84
(as @fathzer https://github.com/fathzer has mentioned above):
parameters.stream().sorted(byParameterName()).collect(toList());
The order field is not taken into account.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/springfox/springfox/issues/2418#issuecomment-428971619,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABM_V31Nb7t0AH7wrXnGMsZNZ2_O1Okjks5uj1Y5gaJpZM4T9u73
.

@dilipkrish any update on this, swagger ui is not usable any more for my users (i have many apis with a lot of optional parameters and start/limit paging parameters, they used to be at the bottom of the list and easy to find - last in declaration - now they are scattered about seemingly randomly to user)

Hi, was there a solution or fix merged for this?

This behaviour is still counter-intuitive, please reopen.

I had the same problem using
@JsonPropertyOrder
with springfox 2.9.2The interesting thing is that it applies the ordering to some POJOS, not to all.
I have a class that extends another.
E.g.
@JsonPropertyOrder(value = {"id"})
public class UserProofVerificationResource extends ProofVerificationResource
...
@JsonPropertyOrder(value = {"purpose", "method", "status"})
public class ProofVerificationResource {

The parent class @JsonPropertyOrder is ignored, not added to the subclass field ordering.
So, what I did, was to add the parent class fields to the subclass and now the ordering is fine.
@JsonPropertyOrder(value = {"id", "purpose", "method", "status"})

I don't think sorting parameters alphabetically is a good idea, neither for automatic swagger doc generation logic or for automated codegeneration based on swagger doc.
Otherwise adding a new parameter may cause a complete reordering of the Parameters array (depending on the name chosen for the parameter).
If the client code generation logic makes use of overloading they may not even get a compile time error since a new method with the same types may have been generated, and only the parameter names will be different since the query params in the signature are actually different due to the reordering.
If the generated client code does not make use of overloading tricky errors may still happen: It may appear as if they get the compilation error due to the addition of a new optional variable in the API from which the client code is generated, so the developer simply solve this by adding null to the call to the autogenerated client method. Now the code compiles. But since a reordering may have occured they may be setting the new optional parameter to someOldValue and the someOldValue parameter to null.
No overloading scenario:
Generated code before adding 'Boolean aParam':
public void myOperation(Boolean bParam ) { }
Generated code after adding 'Boolean aParam':
public void myOperation(Boolean aParam, Boolean bParam ) { }
Overloading scenario (let's assume that the parameters are optional):
Generated code before adding 'Boolean aParam':
public void myOperation() { }
public void myOperation(Boolean bParam ) { }
Generated code after adding 'Boolean aParam':
public void myOperation() { }
public void myOperation(Boolean aParam ) { }
public void myOperation(Boolean aParam, Boolean bParam ) { }

I had the same problem using
@JsonPropertyOrder
with springfox 2.9.2The interesting thing is that it applies the ordering to some POJOS, not to all.
I have a class that extends another.
E.g.
@JsonPropertyOrder(value = {"id"})
public class UserProofVerificationResource extends ProofVerificationResource
...
@JsonPropertyOrder(value = {"purpose", "method", "status"})
public class ProofVerificationResource {
The parent class @JsonPropertyOrder is ignored, not added to the subclass field ordering.
So, what I did, was to add the parent class fields to the subclass and now the ordering is fine.
@JsonPropertyOrder(value = {"id", "purpose", "method", "status"})

@gsbtech I tried using@JsonPropertyOrder and it's getting ignored... On which version of springfox are you?

Since I couldn't figure out how to get JsonPropertyOrder to get picked up by springfox I've added io.swagger.annotations.ApiModelProperty annotation to each field and explicitly specified the position... It works but obviously it adds duplicate logic...

How to fixed this issue ?

How can we fix the issue? (After more than a year...) This is a critical feature!

position attribute at `@ApiModelParameter' does not bring any effect

So, I just updated my project from 2.7.0 to 2.9.0.. or I should say, I was trying to...
I never faced such a terrible up-gradation. So many changes and so little documentation..
It was very very exhausting and tiring..
This issue was the last straw that forced me to pull out all the messy springfox codes and annotations from my project.
I really appreciate the hard work done by springfox peoples.
P.S: I've moved to springdoc, Life was never been so easier..

Any update to this issue?

Any update to this issue?

Seems, no update. Still the order changes. In my case, it is grouping by required and non-required parameters

I found the following solution using aggregation annotation.
@Target({ElementType.METHOD, ElementType.PARAMETER, ElementType.ANNOTATION_TYPE, ElementType.TYPE})
@Retention(RetentionPolicy.RUNTIME)
@Parameter(name = "page", in = ParameterIn.QUERY, explode = Explode.TRUE, description = "Results page you want to retrieve. Default: 0",
        schema = @Schema(type = "int"))
@Parameter(name = "size", in = ParameterIn.QUERY, explode = Explode.TRUE, description = "Number of records per page. Default: 20",
        schema = @Schema(type = "int"))
@Parameter(name = "sort", in = ParameterIn.QUERY, explode = Explode.TRUE, description = "Sort the response data on a field in ascending or descending order. " +
        "The basic format to define your sorting criteria is \"field(,asc|desc)\". " +
        "Multiple sort criteria are supported with a \"|\" delimiter, e.g. \"created_on,desc|modified_by,asc\". Default: created_on,desc",
        schema = @Schema(type = "string"))
public @interface ApiPageable {
}

    @Operation(summary = "Filter system variables by allowed parameters.", method = "GET", responses = {
            @ApiResponse(responseCode = "200", description = "system variables results",
                    content = @Content(array = @ArraySchema(schema = @Schema(implementation = SystemVariable.class))))})
    @GetMapping
    @ApiSystemVariableSpec
    @ApiPageable
    ResponseEntity<Page<SystemVariable>> find(
            @Parameter(hidden = true) SystemVariableSpecification spec,
            @Parameter(hidden = true) @PageableDefault(sort = {"sysVarId"}, direction = Sort.Direction.DESC) Pageable pageable);

All request parameters belonging to the ApiPageable annotation are located under the parameters of the ApiSystemVariableSpec annotation in the Swagger UI.


Insert resource function long file paths

Is your feature request related to a problem? Please describe.
When using the insert resource function in VSCode and having to select an existing file to insert to there's an issue when file names are too long.
Describe the solution you'd like
View the full path by hovering or insert resource to the active new file window.

Need to confirm if we have control over how file paths are rendered. This may be a generic VS code issue.


Add minimal interval to refresh (timeago.render)

This PR adds the minimal interval option to refresh intto timeago.render.
This option will help developers to avoid disturbing users especially in case of having multiple sub-minute elements. An example is available at https://cl.ly/2r39322u3e23 (adapted from gitlab-org/gitlab-ce#47976).
Signed-off-by: Takuya Noguchi<EMAIL_ADDRESS>

This would be a great addition. I've currently got multiple use cases for this and hope to see it merged soon.

@amustill Thanks for reviewing 😄
@hustcc Can you have a look at this?

I would also like to see this merged. I was going to implement this myself till i came across this PR. I wanted this functionality so that i can control when the update runs, since in my use case i dont need an update every second, it would help me adjust it to update every minute instead

@GlennFernandes Thanks for your endorsement on this PR 😄 Hope we will get it on master (4.0 beta?) soon...

If we add the option like minInt, then a lot config will coming, and the parameters of function will explosive. So maybe we should modify the API:

format(date[, opts]): format a Date instance / timestamp / date string to string.
render(dom[, opts]): make a dom automatic rendering.

import { format, render } from 'timeago.js';

const opts = {
  locale: 'en_US',
  minInt: 60,
};

format('2019-08-13', opts);

render('#container', opts);

And all the config of opts are optional, what is your suggestion?

I will add an opts as the 3rd or 4th parameter.
Now has:

maxDiffSecond: when diff > maxDiffSecond, will not format.
minInterval: the min setTimeout time interval

fixed in https://github.com/hustcc/timeago.js/commit/6f6466803f44f5dcf595b3a25e0c8e1189aa39f6

+<EMAIL_ADDRESS>

@hustcc  Thanks for the improvement 😄 and sorry that I could not have replied you 😭


Update submodule ecl to latest Thu Feb  6 00:39:33 UTC 2020

- ecl in PX4/Firmware (a95f1c88fc011a46e8c7c130f8304ea17399103e): https://github.com/PX4/ecl/commit/ed260c4f1db8545d8ad3aa7f05d951857436ef87
- ecl current upstream: https://github.com/PX4/ecl/commit/89bcebd631024a1a91babb7b68f197dc3b6e5ca8
- Changes: https://github.com/PX4/ecl/compare/ed260c4f1db8545d8ad3aa7f05d951857436ef87...89bcebd631024a1a91babb7b68f197dc3b6e5ca8

89bcebd 2020-01-30 Paul Riseborough - EKF: Prevent covariance initialisation overwriting yaw variance
a3347b7 2020-01-30 Paul Riseborough - EKF: Use more conservative value for delta velocity bias process noise
21054a4 2020-01-30 Paul Riseborough - EKF: Fix bug causing incorrect covariance initialisation

@priseborough @RomanBapst any testing you'd like to see here before the ecl update with the covariance initialization fix (https://github.com/PX4/ecl/pull/739) goes into PX4/Firmware master?

Tested on PixRacer V4
Indoor Flight Test
Modes Tested
Stabilized Mode: Good.
Procedure
Arm and Take off in stabilized mode.
Notes
No issues noted, good flight in general.
Log https://review.px4.io/plot_app?log=11153d21-ec17-4dfc-8bb6-c161131f06a1
Tested on CUAV nano V5
Indoor Flight Test
Modes Tested
Stabilized Mode: Good.
Procedure
Arm and Take off in stabilized mode.
Notes
No issues noted, good flight in general.
Log https://review.px4.io/plot_app?log=9fd00bfb-68e0-4e9a-a7ad-6f519f0b9707

Tested on pixhawk4 v5 f-450
Indoor Flight Test
Modes Tested
Stabilized Mode: Good.
Procedure
Arm and Take off in stabilized mode.
Notes
No issues noted, good flight in general.
Log
https://review.px4.io/plot_app?log=f06345f6-8b34-4882-9fcd-74388ad8648d

Closing in favor of https://github.com/PX4/Firmware/pull/14147.


Add isNormalized

Closes #1316.
I have implemented isNormalized for lie groups and for the joint configuration, with bindings.
I have very limited time, so I think I will let the bounds checks go for the time being. The normalization check has much more value and it is much more difficult to implement for an inexpert user, so I think this contribution is already important per se.

@jcarpent done

OK. Thanks. Next time, it would be nice to squatch the commits that fixe the remarks I have made. They are a bit redundant I would say.

OK. Thanks. Next time, it would be nice to squatch the commits that fixe the remarks I have made. They are a bit redundant I would say.

Indeed they are. I don't know, I am mostly on Gitlab now, and it offers an option to automatically squash the commits, doesn't Github have the same? I think it does: https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuring-commit-squashing-for-pull-requests


Clarify "minimal" property

The minimal property currently states that no web UI is included, but that's not the case:
https://github.com/cryostatio/cryostat-operator/blob/3948e7dedd0c25f1de14a47f06dcde3196a014fd/api/v1beta1/cryostat_types.go#L47-L50

What actually happens nowadays is that the web UI is included, but the jfr-datasource/grafana-dashboard components aren't deployed.

README's See Also section should be updated as well.

I think the old minimal mode idea, where a user might deploy a Cryostat container alone without even the web-client assets bundled (no jfr-datasource/grafana and no reports sidecars) is pretty much dead at this point, so redefining "minimal" within the Operator context to mean "Cryostat container only, no jfr-datasource/grafana" makes sense. If that's the case then over in the main Cryostat project I think we should rename the "minimal" builds to something else and avoid the confusion so the term isn't overloaded.
Maybe a Cryostat OCI without the web-client assets should be a "headless build"?

"headless" makes sense to me


[AUTH] Add kerberos and ldap authentication backends for the webserver

Note: I am opening this PR to have some discussion. It is still work in progress, although functional.
This PR allows to specify the authentication backend in airflow.cfg instead of using the PYTHON_PATH. The old behavior is still available, but marked deprecated. However, if authenticate is True and the authentication backend fails to import the web server will fail to start. This is a behavioral change in order to make sure you do not run an inconsistent setup.
New config can be used adding the following (for example) the the [webserver] section of airflow.cfg
authenticate = True
auth_backend = airflow.contrib.auth.backend.ldap_auth

As an example I have included and ldap authentication module (that should work against FreeIPA and AD as well as normal LDAP servers) and a kerberos authentication module. I am not entirely sure of I got all flask-isms right, so I wouldn't mind some pointers.
Couple of questions / ideas

I saw some talk of using Flask App Builder. Flask App Builder has a more extensive framework for authentication (roles etc). Am I doing work here that is going to be outdated soon? :-)
Logout is not part of the standard templating where to put it (ie. this is my lack of Flask knowledge)?
Is the change in behavior acceptable?
... anything I am forgetting?

I see the commits are not too clean. For merging I will clean them up.

Thanks for the PR, I'm hoping to have some time to dig into it over the next few days

Would mind rebasing and writing a few unit test to cover this? I should be able to see the PR in travis after that!

Of course. Will do tomorrow.

On 21 okt. 2015, at 23:10, Maxime Beauchemin<EMAIL_ADDRESS>wrote:
Would mind rebasing and writing a few unit test to cover this? I should be able to see the PR in travis after that!
—
Reply to this email directly or view it on GitHub.

@mistercrunch unit testing the authentication mechanisms requires (I think!) to refactor app.py so it creates the app in a function, eg see http://flask.pocoo.org/snippets/20/ , to be able to pass a different configuration to the app per test.
This looks like a good idea but also a major undertaking. If you have a better idea how to unit test the functionality please advice. If refactoring is unavoidable (and it seems more future proof anyway), I will need some help.

That sounds kind of brutal. Maybe something like:
# assuming this import in tests/core.py
from airflow.www import app

# inside your unit tests
# change os.environ['AIRFLOW_CONFIG'] and find some way to reload the configuration, ten
reload(app)

Ah good idea. I thought about doing the reload but I couldn't get the config to apply. I didn't try the os.environ yet though. Still the refactoring might be nice for the roadmap as it makes the unit testing much cleaner and probably some other stuff too.

@mistercrunch the tests work locally, but not on travis due to an importerror of the backend. I am not able to reproduce it. If you have an idea that would be appreciated.

Is it a circular import issue?

Not obviously right away. The login code is not dependent on core.py or app.py . There is of course a reference to flask (login etc). But it doesn't explain why the tests work locally (./run_unit_tests.sh) and for in practice. I'll continue searching...

Grmbl, was missing the ldap dependency but exception got swallowed. Needs a bit more fixing, but I think I'll get there.

@mistercrunch this is giving me headaches :). Due to the reloading if have to put the tests last otherwise it interferes with the other tests or - I just though of it - I could do the reloading again in a teardown. Still the decorators do not seem to kick into action so I am wondering is this path is as tough as reworking app.py and as that seems more flexible towards the future it might be more opportune.
I will see if a can do some work on that. Please let me know if you won't accept such a patch.

Having a function that returns an app seems reasonable.

closing for now, as it needs more fixing.


Remove explicit caching of .lake folder; enable use of Github cache

Issues:
Hopefully, resolves https://github.com/leanprover/LNSym/issues/155
Description:
Avoid caching fails in CI
Testing:
make all ran locally
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

LGTM. As a note, we're doing this since I had hypothesized the following failure mode:
We have two caches:
    - uses: leanprover/lean-action@v1
      with:
        auto-config: false
        use-mathlib-cache: false
        use-github-cache: true

    - name: Cache `.lake` folder
      id: cache-lake
      uses: actions/cache@v4
      with:
        path: .lake
        key: ${{ runner.os }}-lake

I feel we should delete the hand-written Cache .lake folder rule, and only keep leanprover/lean-action's use-github-cache: true rule. I could very well imagine that the latter cache somehow overwrote files from the former's cache, thereby invalidating the .lake state!


updated from deprecated nuget package to lastest and now browsers are not installed

I updated from the deprecated version of playwright-sharp to latest and now the new NuGet install is NOT installing the browser drivers...
basically killing my project in visual studio
I also tried the CLI commands, but it appears nothing is getting installed...

I found a work around
dotnet tool install --global Microsoft.Playwright.CLI
then
playwright install
Can we have the CLI are part of the nuget package in verse place...
I tried using the UI package installer --- but it keeps failing..
Can we update the Documents for the Visual Studio users... ?
We need the browsers to be installed during the package installation.. doing this in a pipeline on azure VM is going to be annoying
In the legacy playwright sharp. I could just run a function like 'await Playwright.InstallAsync()'
we need that option back

Does this help?
Microsoft.Playwright.Program.Main(new string[] { "install", "chromium" });

I found a work around

This is the correct way of using the tool, as per the docs.

I tried using the UI package installer --- but it keeps failing.. for Microsoft.Playwright.CLI

The CLI is a dotnet tool - and as such, it won't work through the UI. It's not a package you add to your project.

Can we update the Documents for the Visual Studio users... ? not all of US use VS CODE

What exactly do you feel needs to differ? The only significant difference is that you do not type dotnet add package command, but use the UI to install the same package - Microsoft.Playwright. If you have other suggestions on how to improve this, we'd be happy to consider them!

We need the browsers to be installed during the package installation.. doing this CLI in a pipeline on azure VM is going to be annoying
In the legacy playwright sharp. I could just run a function like 'await Playwright.InstallAsync()'
we need that option back

Installing browsers during the package installation is not a good way, because applications get deployed to various environments. The browsers need to be installed wherever they are running. We are exploring other ways of making this scenario better, but right now, this workflow mimics the npm flow which is why we picked it.
As pointed out by @kababoom, you can use the workaround of invoking the underlying CLI through calling Microsoft.Playwright.Program.Main(new string[] { "install" }); which will perform the installation. This is currently not officially supported/documented but we've already seen requests, so it's possible we'll add this.

Just for your consideration: custom CI systems benefit from some flexibility around runtime "installation" from cached internal sources.
In PlaywrightSharp:
Environment.SetEnvironmentVariable("PLAYWRIGHT_DOWNLOAD_HOST", internalPlaywrightDownloadUrl);
await Playwright.InstallAsync(); //convenient when pre-loading onto a build/test host isn't feasible

@lcpautotester FYI playwright install assumes it will be able to find Microsoft.Playwright.dll under the current directory (or parent directory in some circumstances).
Running the tool from a folder (or parent) which contains Microsoft.Playwright.dll might work instead.
The install doesn't work well for scenarios which have custom packages and bin/obj folders (eg, OutputPath outside of the repository).

@lcpautotester FYI playwright install assumes it will be able to find Microsoft.Playwright.dll under the current directory (or parent directory in some circumstances).

The recent changes should help with that. They’re currently available in the next version (pre-release) but we backported them to 1.12, and they’ll be available soon-ish. But it’s a fair point.

We've shipped 1.13, and the discovery issue should be fixed there. We will consider having an API method for triggering the installation process.


Bad multiline code block in AsciiDoc

Swagger2Markup version: 1.3.0
Problem description:
When including a multiline code block in a Description (as supported by Markdown) is mistranslated to AsciiDoc.
The Swagger YAML:
      description: "Example:

      ```

      curl -X GET -H \"Accept: application/json\" -H \"Authorization: Bearer <Your Token Here>\" \"https://my.api.com/Endpoint/00000000-0000-0000-0000-000000000000\"

      ```
      "

But Swagger2Markup tries to convert it into an inline code statement:
==== Description
Example:
`
curl -X GET -H "Accept: application/json" -H "Authorization: Bearer <Your Token Here>" "https://my.api.com/Endpoint/00000000-0000-0000-0000-000000000000"
`

And asciidoctor-pdf fails to parse it (rightfully).
It should:

Use ---- instead of `
Not HTML-escape the &, <, >, etc.

Generated output should be
==== Description
Example:
----
curl -X GET -H "Accept: application/json" -H "Authorization: Bearer <Your Token Here>" "https://my.api.com/Endpoint/00000000-0000-0000-0000-000000000000"
----

Full small Swagger Spec to reproduce the issue:
---
swagger: '2.0'
info:
  title: Bad Spec
  contact:
    name: Developer
    email<EMAIL_ADDRESS>  version: '1.0'
host: my.api.com
basePath: "/"
schemes:
- https
produces:
- application/json
paths:
  "/Endpoint":
    get:
      summary: Retrieves all folders for the current user.
      description: "Example:

      ```

      curl -X GET -H \"Accept: application/json\" -H \"Authorization: Bearer <Your Token Here>\" \"https://my.api.com/Endpoint/00000000-0000-0000-0000-000000000000\"

      ```
      "
      responses:
        '200':
          description: Success

Hi,
Swagger2Markup uses this library to convert Markdown to AsciiDoc: https://github.com/bodiam/markdown-to-asciidoc
It seems the library does not interpret your Markdown as a Code Block.
Maybe there are some Windows, Linux line feed issues?
On which OS did you create the Swagger Spec and on which OS do you invoke the Swagger2Markup CLI?

All in Windows 10. If you run with the spec I posted here, is the output different from what I have?
(Attaching my local bad-swagger file in case encoding is a key player)
bad-swagger.zip

As a workaround. Do you have to use Markdown in your Swagger Spec?
You could also use AsciiDoc directly and change the config property swagger2markup.swaggerMarkupLanguage to ASCIIDOC.

Thanks. Well, I'd like my curl examples to show code-block like.
I use the same swagger file to host a web site with Swagger -UI (generating this PDF is a temporary measure while our website is ready for public). I'm not sure that Swagger web UI supports ASCIIDOC descriptions.

If you agree, then we can close this issue. I've already added the extra lines to my swagger and I'm able to generate the PDF with no parsing errors.

Thx for the Information


refactor(state/gateway)!: remove SubmitTx endpoint from RPC and Gateway

This PR removes the state.SubmitTx endpoint from the RPC, and the submit_tx endpoint from the gateway.
Related: #3348
Rationale
This endpoint was never fully documented, and no usage examples exist.
When creating usage examples after a discussion in #3345 , we realized the endpoint is not very useful at all. In order to use it, you need to construct a transaction, importing app, tendermint... all to then proxy it to an app instance via node anyways. Here is a snippet from @jcstein in the docs tutorial for submitting data.
The example for celestia-openrpc/celestia-node would essentially be exactly the same, except we build a rpc connection to node instead of a grpc to app. I think it is clear from this example why SubmitTx is too much of a hassle to use, and if users do need this functionality for their use-case, it is likely a sign that they should be interacting with app directly instead anyways.
To verify this, @Bidon15 reached out to teams to get feedback on this decision. All teams confirmed that the endpoint is not being used and not needed.
We support enough transaction types in the state module. If users need more functionality, we should either add the granularity to the current methods or add specific methods for specific transaction types/use cases. Dropping down a level to SubmitTx should never be needed if our API is good enough.
Example (using app conn)
import (
    "context"
    "fmt"

    "github.com/celestiaorg/celestia-app/app"
    "github.com/celestiaorg/celestia-app/app/encoding"
    "github.com/celestiaorg/celestia-app/pkg/appconsts"
    "github.com/celestiaorg/celestia-app/pkg/namespace"
    "github.com/celestiaorg/celestia-app/pkg/user"
    blobtypes "github.com/celestiaorg/celestia-app/x/blob/types"
    "github.com/cosmos/cosmos-sdk/crypto/keyring"
    tmproto "github.com/tendermint/tendermint/proto/tendermint/types"
    "google.golang.org/grpc"
    "google.golang.org/grpc/credentials/insecure"
)

// SubmitData is a demo function that shows how to use the signer to submit data
// to the blockchain directly via a celestia node. We can manage this keyring
// using the `celestia-appd keys` or `celestia keys` sub commands and load this
// keyring from a file and use it to programmatically sign transactions.
func DemoSubmitData(grpcAddr string, kr keyring.Keyring) error {
    // create an encoding config that can decode and encode all celestia-app
    // data structures.
    ecfg := encoding.MakeConfig(app.ModuleEncodingRegisters...)

    // create a connection to the grpc server on the consensus node.
    conn, err := grpc.Dial(grpcAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
    if err != nil {
        return err
    }
    defer conn.Close()

    // get the address of the account we want to use to sign transactions.
    rec, err := kr.Key("accountName")
    if err != nil {
        return err
    }

    addr, err := rec.GetAddress()
    if err != nil {
        return err
    }

    // Setup the signer. This function will automatically query the relevant
    // account information such as sequence (nonce) and account number.
    signer, err := user.SetupSigner(context.TODO(), kr, conn, addr, ecfg)
    if err != nil {
        return err
    }

    ns := namespace.MustNewV0([]byte("1234567890"))

    fmt.Println("namespace", len(ns.Bytes()))

    blob, err := blobtypes.NewBlob(ns, []byte("some data"), appconsts.ShareVersionZero)
    if err != nil {
        return err
    }

    gasLimit := blobtypes.DefaultEstimateGas([]uint32{uint32(len(blob.Data))})

    options := []user.TxOption{
        // here we're setting estimating the gas limit from the above estimated
        // function, and then setting the gas price to 0.1utia per unit of gas.
        user.SetGasLimitAndFee(gasLimit, 0.1),
    }

    // this function will submit the transaction and block until a timeout is
    // reached or the transaction is committed.
    resp, err := signer.SubmitPayForBlob(context.TODO(), []*tmproto.Blob{blob}, options...)
    if err != nil {
        return err
    }

    // check the response code to see if the transaction was successful.
    if resp.Code != 0 {
        // handle code
        fmt.Println(resp.Code, resp.Codespace, resp.RawLog)
    }

    // if we don't want to wait for the transaction to be confirmed, we can
    // manually sign and submit the transaction using the same package.
    blobTx, err := signer.CreatePayForBlob([]*tmproto.Blob{blob}, options...)
    if err != nil {
        return err
    }

    resp, err = signer.BroadcastTx(context.TODO(), blobTx)
    if err != nil {
        return err
    }

    // check the response code to see if the transaction was successful. Note
    // that this time we're not waiting for the transaction to be committed.
    // Therefore the code here is only from the consensus node's mempool.
    if resp.Code != 0 {
        // handle code
        fmt.Println(resp.Code, resp.Codespace, resp.RawLog)
    }

    return err
}

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.78%. Comparing base (2469e7a) to head (b33aa28).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3391      +/-   ##
==========================================
- Coverage   44.83%   44.78%   -0.05%
==========================================
  Files         265      272       +7
  Lines       14620    15210     +590
==========================================
+ Hits         6555     6812     +257
- Misses       7313     7612     +299
- Partials      752      786      +34

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@walldiss


Read an account from the service

As a System Administrator,
I need the ability to read an account from the service,
So that I can check the status of the customer account
Details and Assumptions
the account of the queried user should display
Acceptance Criteria
Given I have added an account in the service
When I read this account
Then it should display the account information


Change IPAM driver type to pointer to avoid default value

This fix tries to address the issue raised in #368 and https://github.com/docker/docker/issues/25735
where NetworkCreate needs to set up the IPAM driver type. Otherwise
an error will be returned.
This fix change IPAM driver type to pointer so that /networks/create
does not the explicit specification of IPAM driver any more.
This fix fixes #368.
This fix is related to https://github.com/docker/docker/pull/25803
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

LGTM

LGTM 🐸


Update defender-for-cloud-glossary.md

Updated text in two URLs.
Minor cleanup of markdown.

Learn Build status updates of commit c7a9aec:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 0, Column 0: [Error: download-failed] Download failed for file 'https://ops/buildconfig/?name=azure-documents&locale=en-us&repository_url=https://github.com/MicrosoftDocs/azure-docs&publish_repository_url=https://github.com/MicrosoftDocs/azure-docs-pr&branch=main&xref_endpoint=&xref_query_tags=/dotnet,/python'. Try closing and reopening the PR. If you get this Error again, file an issue.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@ElazarK,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#please-close

#please-open

Learn Build status updates of commit c7a9aec:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/defender-for-cloud/defender-for-cloud-glossary.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#sign-off


Optional resource specification

On some K8s clusters like IBM ICP we must explicitly specify resource for each pod. It is ICP requirement. Also, performance wise some Egeria components work much better with more resources available. On ICP, Atlas pod, for example, wouldn't even start without at least 2 cpus, but significant improvement is visible when cpu = 4, while igcproxy requires 2 cpus.
It should be possible to optionally specify resources  for each pod in values.yaml E.g. (suggested def values)
resources:
limits:
cpu: 1
memory: 2Gi
requests:
cpu: 10m
memory: .01Gi

Whether these are required will depend on the particular k8s environment.
I took a look at a few public charts for kafka, mariadb, cassandra & could not see such values specified, so it's not clear how common it is to include these.
If it appears to be fairly deployment-centric another option may be - locally - to use an admission controller to automatically augment the pod definition -- potentially a podpreset could do this trick.
This needs a little further investigation to figure out what is 'best practice' and this area in terms of what should be 'shipped', as well as the best extension mechanism to allow it to be done locally (such as podpreset)
In the meantime can you confirm the version of k8s in use?

Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-19T11:13:54Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.5+icp-ee", GitCommit:"eb4df6c6fb47f5b4fd1ed8bfbfe2d0ed5ea636e1", GitTreeState:"clean", BuildDate:"2019-05-08T02:18:32Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}

k8s Admission controller may not be an option for majority of users who are not allowed to run kube-apiserver [flags] on their cluster. In case a podpreset is recommended what should matchLabels contain?  Probably app.kubernetes.io/instance... Can you confirm?


Fix for incorrect detection of %2f as separator at a few places in UriParser

The detection of %2f in UriParser.readNonSeparator() is incorrect as it always compare a String of length 2 with a String of length 3.
After the fix, a unit test failed:
NamingTests -> assertSameName(path, name, "foo%2f..%2fa", scope);
The reason was before the fix the resolved path was '/Java/libraries/commons-vfs/commons-vfs2/target/test-classes/test-data/read-tests/foo%2f..%2fa'
After the fix the resolved path is '/Java/libraries/commons-vfs/commons-vfs2/target/test-classes/test-data/read-tests%2fa'
AbstractFileName.checkName (with scope child) wasn't failing first as path.charAt(baseLen) was '/' (the '/' before foo)
then it was failing as the separator at baseLen was %2f and not '/'.
So I've changed the UriParser.PathNormalizer.readSeparator() to also normalize the '%2f' to '/'. This fixes the unit tests.
While adding more unit tests, I also noticed the different handling of '/' and %2f in UriParser.normalisePath() and fixed it.
I don't know why it shows a big diff when I only changed a few lines in UriParser. I guess it may have to do with the line feed but I've read many post on internet and tried many things for 1 hour without any result. If it's a problem let me know, I'll do a clean clone again and recreate the change.

Hello @japplis
You'll need to update the PR to only show what's actually changed (IOW not the whole file).

I'm closing with pull request as I had problems to fix the line feed in the diff in this branch. I've created a new branch with a new pull request with the same change (and fix for the large diff): https://github.com/apache/commons-vfs/pull/543


Seems like my webpack.config.js file is getting ignored

Hello, so I have a webpack.config.js file where I filled the resolve.modules array with my src and node_modules folder, following this documentation for webpack 2/3 (I have webpack 2 installed).
I have a folder in the root where I store my components src/components, so that from anywhere in my code, I can reference a component by doing import Component from 'components/Component'.
If I go and make a simple build to a dist folder, everything works beautifully, so I know that my webpack config is fine. But when I try to make the webpack-isomorphic-tools setup run, it seems like it's using a config file on it's own and plain ignoring my well crafted config file!
Any ideas on how to add support for the same resolve.modules from webpack-isomorphic-tools? Doesn't seem to be documented anywhere!
Disclaimer: I inherited this project I'm working on, I didn't code the config for the webpack-isomorphic-tools setup we have right now.

resolve.modules is the new name for resolve.modulesDirectories.
Add modulesDirectories parameter to the webpack-isomorphic-tools.js config.
  // if you're using Webpack's `resolve.modulesDirectories`
  // then you should also put them here.
  //
  // modulesDirectories: webpackConfiguration.resolve.modulesDirectories // is ['node_modules'] by default

Perhaps then it could work.


Define default evaluation options for evaluation tests

Need to decide on the default evaluation option behavior for the conformance tests. The most relevant at the moment would be permissive vs strict/type-checking mode.

Before continue porting tests from partiql-lang-kotlin as part of milestone 2, will need to define the default evaluation options and how they will be specified in the evaluation test schema.

From #29, decided that the evaluation mode (COERCE vs ERROR previously known as PERMISSIVE and TYPE-CHECKING/STRICT) was the only mode to consider adding at this time. If other evaluation options are needed can reopen this issue.


Fix GradleBuildExternalPluginsValidationSmokeTest

This PR fixes a couple issues with GradleBuildExternalPluginsValidationSmokeTest:

the Gradle build itself was incorrectly configuring all ValidatePlugins tasks, including those for external plugins
there was a potential race condition in verification

Closes #16084

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

Thanks for taking the time to improve this!


Token workaround

Fixes #255
Basically, this works if a token represents a full version string, but I think it’s possible to use a token anywhere in the string, like 3.3.0$versionsuffix$. This won't work in that case, but I don't think that's too common.
If there are any tokens in the versions, save package and publish commands are disabled since that's not a valid package. It can only be saved as a manifest.
Here's a nuspec I used for testing
<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
  <metadata>
    <id>MyPackage</id>
    <version>$version$</version>
    <title></title>
    <authors>oren</authors>
    <owners>oren</owners>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <description>My package description.</description>
    <dependencies>
      <group>
        <dependency id="foo" version="$versio1n$" />
        <dependency id="bar" version="$version$" />
        <dependency id="bb" version="[$version$, $version4$)" />
      </group>
      <group targetFramework=".NETFramework4.5">
        <dependency id="bb" version="4.5.0" />
      </group>
    </dependencies>
  </metadata>
  <files>
  </files>
</package>

I'm not sure a legacy project like this is worth adding a suite of unit tests around...

will test this after #256

Merging this in for now; will address any subsequent issues as they arise.


Create html pages with no plugin, just entry points

Summary
html-loader doesn't load javascript paths, neither parses template code.
But, with the help of other loaders or javascript logic, having fixed output filenames for javascript entry point bundles at webpack output configuration section, it may result in a tricky solution for building up an static web site.
As explained in the post of @sokra in the issue #536 of webpack project, using multiple webpack configuration (by an array) and a customized npm script will help.
Resources

https://github.com/webpack/webpack/issues/536#issuecomment-59530883

Hello @temple,
The html-bundler-webpack-plugin allows you to use an HTML template as an entry point for all referenced source assets.
In a HTML template can be referenced any source files of styles, scripts, images, fonts, etc.
The bundler plugin detects all source files referenced in a HTML template and extracts processed assets to the output directory.
You need to install only one html-bundler-webpack-plugin plugin.
For example, there is the source of index.html:

  <link href="./styles.scss" rel="stylesheet">

Hello World!

The Webpack config is very simple:
const HtmlBundlerPlugin = require('html-bundler-webpack-plugin');
module.exports = {
  entry: {
     index: 'src/views/home.html', // => dist/index.html
     'news/sport': 'src/views/news/sport/index.html', // => dist/news/sport.html
  },
  plugins: [
    new HtmlBundlerPlugin(),
  ],
  // ... loaders for ts, sass, images, etc.
};

The generated HTML contains the output filenames of the processed files:

  <link href="css/styles.05e4dd86.css" rel="stylesheet">

Hello World!


Use less  @Import from classpath

Right now, lesscss maven plugin does NOT support @Import from classpath. See https://github.com/marceloverdijk/lesscss-maven-plugin/issues/72
In the pom.xml of the springboot branch, there is workaround in the pom.xml unpacking the bootstrap on-the-fly. Remove this plugin config when the issue is resolved OR a better resolution is found.
The https://github.com/gabrysbiz/lesscss-extended-compiler/issues/2 has been closed.

Use wro4j instead of lesscss plugin: 131a588e09c67a53ab91c4928b2896dc035f8cee


feat: introduce configurable resource limits for flagd sidecar

This PR

Related Issues

Notes

Follow-up Tasks

How to test

It would be great to leverage some benchmark metrics to help define reasonable default resource limits.
There's an open issue in the flagd repo requesting this information.
https://github.com/open-feature/flagd/issues/212

Codecov Report

Merging #241 (8f8cc2f) into main (3ee6075) will increase coverage by 0.43%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   50.46%   50.90%   +0.43%
==========================================
  Files           3        3
  Lines         432      444      +12
==========================================
+ Hits          218      226       +8
- Misses        199      202       +3
- Partials       15       16       +1

Impacted Files
Coverage Δ

webhooks/pod_webhook.go
67.62% <73.33%> (-0.05%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Set bokeh < 3 on all environment.yml files

As heard from @jbednar on the Pangeo weekly meeting last week, it would be good to be proactive and set bokeh<3 in our environments, as when it is actually released, it is almost guaranteed to break some functionality in holoviz.    Then when holoviz folks finish working through the issues, we can unpin it.
I've set this on the users/pangeo enviroment on ESIP qhub, but @gzt5142 noted we need to do this for any HPC and local hytest environments as well.

Note that current panel versions pin bokeh less than 3, so if you pin to a current Panel version, as would be good practice anyway, you won't also need to pin bokeh.

our current environment.yml file does not specify panel or bokeh... just hvplot
https://github.com/hytest-org/hytest/blob/main/environment_set_up/HyTEST.yml
I will add a line to set
  - panel=0.14.*