easy lauch

hello sir R3nzTheCodeGOD, I am writing to you because I do not understand what I have to do to use the mod. I don't know if it's possible for you to create an .exe version and easier to use how it's mods : https://killerskins.com or https://leagueskin.net/p/download-mod-skin-2020-chn

hello sir R3nzTheCodeGOD, I am writing to you because I do not understand what I have to do to use the mod. I don't know if it's possible for you to create an .exe version and easier to use how it's mods : https://killerskins.com or https://leagueskin.net/p/download-mod-skin-2020-chn

This tool only let's you equip already existing skins in the game that you don't own. It's not a Custom Skin tool it's simply a skin changer for the skins that already exist within the game.

my antivirus deletes the .exe file in it that's why it didn't work

my antivirus deletes the .exe file in it that's why it didn't work

That is a false positive. The skin changer as well as the injector uses some Win32 API's that aren't commonly used in normal programs. The project is open-source, so you are welcome to compile the skin changer on your own, otherwise disable your antivirus and add the folder with the binaries to the exclusion list.
I'm tired of closing issues like this one is like a 10 issue relating to this issue this week. Please check closed issues before posting an another one.


[BACKLOG-29332] S3 Multipart Upload does not allow configurable part …

…sizes

created class StorageUnitConverter to handle human readible file size to byte

:white_check_mark: Build finished in 46m 28s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core,engine,ui

:ok_hand: All tests passed!
Tests run: 4768, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

the sonar link doesn't show any finds

:white_check_mark: Build finished in 45m 20s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core,engine,ui

:ok_hand: All tests passed!
Tests run: 4768, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 45m 20s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core,engine,ui

:ok_hand: All tests passed!
Tests run: 4768, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message


Migrate away from sphinx-multiversion

sphinx-multiversion is a really good tool for automatically building multiple branches and facilitating switching between them seamlessly. However, it has the following problems:

It's highly inflexible
It can't account for multiple translations smoothly
It appears to be mostly unmaintained

While we can run sphinx-multiversion for each locale in our locale dir, this doesn't give us a neat way of switching between them as it does with versions. To offer a future-proof solution, we should simply build each version using a script and then insert some Javascript into the version picker to sort through the different versions and programmatically replace the URL when the page changes.
Success criteria

[ ] The user should be able to click on the v4 or v5 branch link from any page and end up on the equivalent page in the documentation for that version
[ ] The user should be able to click on another locale from any page and end up on the equivalent page in the documentation for that language
[ ] If a page doesn't exist in the other branch, the user should be taken back to the index page

Resources

Multiversion Sphinx without the plugin
Layout example with Javascript for switching

Relates to #12

This will be resolved by the move to Astro in v2


Consider QoL improvements to tar artifacts generated by kit

Describe the problem you're trying to solve
When packing a modelkit, each layer consists of a tar of the files in that layer's directory. For example, packing a model layer
model:
  path: model-files/

will result in a plain tar containing the contents of model-files (but not the directory itself). During unpacking, this context is reconstructed from the Kitfile so that digests are unchanged.
In addition, creating reproducible modelkits (unpacking and repacking results in the same digest) requires some additional changes, such as setting owner/group, timestamps, etc. to a known value.
This means that the tar files generated by Kit lose some information from the packing environment -- tooling using modelkits depends on kit-specific logic for extracting the contents of a modelkit.
Describe the solution you'd like
To make layer tars more useful outside of a kit context, it would be useful to find a way to include more of the context from the packing environment (e.g. directory names).
Additional context
Considering this change, it's likely something we want to decide sooner rather than later; any change to the pack process will break reproducibility of repacking unpacked modelkits. We also need to consider compatibility, so that previously-packed modelkits can still be unpacked with whatever new format we choose.

If implemented these will be breaking changes so better to do sooner than later. We'll take it in the sprint to discuss how to handle and (maybe) to implement.

Sprint 17 goal: make the decision on what we are going to do for this.
Implement the change can follow in a future sprint if needed.

I've given this some thought and I'm generally focussed on two general areas of improvement: 1) the tar artifacts generated for ModelKit layers, and 2) extensions to our config object that make it somewhat easier to consume Modelkits. I'll list the high-level changes here, with more detail below

Pack layer tarballs to include the full directory structure from the Kit pack command's context (instead of relative to the layer's path)
Update the default owner ID inside tarballs to user 1000 instead of 0
Extend the manifest config structure to include digests and potentially a diffID equivalent
Add an explicit layer for the plain Kitfile, after making the changes to the config object (add a new mediaType application/vnd.kitops.modelkit.kitfile.v1+yaml)

All of these changes are "nice to haves" rather than strictly necessary, so we may not want to ultimately bother with them at this time.

Update how we structure tar files for ModelKit layers
These changes largely center around making the individual layers of a ModelKit easier to use in non-ModelKit contexts (such as injecting ModelKits into containers as we do on jozu.ml).
Currently, we pack data into tar files by effectively switching context into the layer's directory and copying its contents into a tarball. This means that if you pack, for example, ./data/my-modelkit/my-modelkit.safetensors, files inside the tar will have relative paths that exclude data/my-modelkit (packing a tarball with just the file ./my-modelkit.safetensors). Kit then needs to re-construct the directory structure when unpacking to reproduce the original project. As a result, if you just extract the tar files used for layers, all of the directory structure is lost. Instead, I would like Kit to do less magic here, and have the tarred layers extract to the same directory structure as in the original context, packing ./data/my-modelkit/my-modelkit.safetensors instead of just my-modelkit.safetensors.
Additionally, in order to ensure re-packing the same directory results in the same digest, we overwrite the owner's user ID on all files to be the root user. This can cause issues in handling the tars directly, since the current user may not have access to the files; instead I'd like to default to user 1000, which is at least a non-privileged user.
Extend the ModelKit config object
Currently, the application/vnd.kitops.modelkit.config.v1+json media type is just a JSON-encoded Kitfile. This makes retrieving the Kitfile easy for any given ModelKit, but also means tools attempting to process ModelKit manifests need to implement the same logic as the Kit CLI -- for example, given a Kitfile
manifestVersion: 1.0.0
package:
  name: my-modelkit
model:
  name: my-modelkit
  path: my-modelkit.gguf
code:
  - path: LICENSE
    description: License file.
  - path: README.md
    description: Readme file.

and manifest
{
  "schemaVersion": 2,
  "config": {
    "mediaType": "application/vnd.kitops.modelkit.config.v1+json",
    "digest": "sha256:b19e288cbb07d2bd79e666cbbcc31b53d521f012a175fdfc54da52814c673dbd",
    "size": 426
  },
  "layers": [
    {
      "mediaType": "application/vnd.kitops.modelkit.model.v1.tar",
      "digest": "sha256:649716826e7381c1dd4f7909121ddd2b3581f5ebe793a7d27ab5cb65151f32c4",
      "size": 531067392
    },
    {
      "mediaType": "application/vnd.kitops.modelkit.code.v1.tar",
      "digest": "sha256:42df82c72f37f856070f346b9d1ff8b25154a2a2dd9eb597a1ac8ab297486e47",
      "size": 13312
    },
    {
      "mediaType": "application/vnd.kitops.modelkit.code.v1.tar",
      "digest": "sha256:8fb7ccbb0d326272ae0b375bab6f5c31da5a8748f32fa769936bc674fd634140",
      "size": 6656
    }
  ],
}

The only way to grab the README.md layer is to match its index in the Kitfile (the 2nd code layer) with its index in the manifest (the second digest with mediaType application/vnd.kitops.modelkit.code.v1.tar). This trips up both tools that want to extract metadata from ModelKits and also contributors to this repository.
Instead, we could have an "enhanced" Kitfile for our config -- for example
manifestVersion: 1.0.0
package:
  name: my-modelkit
model:
  name: my-modelkit
  path: my-modelkit.gguf
  digest: sha256:649716826e7381c1dd4f7909121ddd2b3581f5ebe793a7d27ab5cb65151f32c4
code:
  - path: LICENSE
    description: License file.
    digest: sha256:42df82c72f37f856070f346b9d1ff8b25154a2a2dd9eb597a1ac8ab297486e47
  - path: README.md
    description: Readme file.
    digest: sha256:8fb7ccbb0d326272ae0b375bab6f5c31da5a8748f32fa769936bc674fd634140

These extensions would be compatible with the Kitfile definition, so you could just ignore the new fields to get the original Kitfile, but I'd also like to just include the full YAML kitfile inside the manifest as a regular layer, to make it easy to get it explicitly.

I agree with these proposed changes for structuring tar files for ModelKit layers. Preserving the original directory structure in the tar file will simplify things. The current structure forces too much magic we need to implement.
Switching the file owner to user 1000 is also a practical choice.
When we make these changes, we need to ensure that kit CLI can handle the current tar structure.


Issue with flake.nix not finding input for 'beautysh/flak-utils'

I have the following error when doing nix flake update:
error: input 'bud/beautysh/poetry2nix/flake-utils' follows a non-existent input 'beautysh/flake-utils'

I'm guessing this is related to the 10-day-old commits refactoring the flake.nix.

The input is called utils now, so you need to do beautysh.inputs.utils.follows = "flake-utils". Sorry for the churn!


[W6.1d][W11-B2]Zhan Yu

Completed LO-Polymorphism. Updated tests as well

@ZY-Ang
Some comments added. Please ack & close the PR after reading comments.


feat: Add option to set Cloudfront managed cache policy

The cachePolicy argument can now be used to customize the cloudfront cache policy using one of the managed policies. It defaults to the previous fixed value of 'Managed-CachingOptimized'.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.00%. Comparing base (f796d85) to head (a913fb7).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   86.61%   90.00%   +3.38%
==========================================
  Files           8        8
  Lines        1061      990      -71
  Branches       46       49       +3
==========================================
- Hits          919      891      -28
+ Misses        142       99      -43

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create a new class for quest pins.

Description
Technical Description
This has to extend pin class and have two controls for each scroll. One for when the pin is visible on minimap and one for when it's outside of it to indicate the direction.
Prerequisites

#3

Pull Request #16

Closed as it'll be done in #39


java.lang.NoSuchFieldException: No field mMenuView in class Landroid/support/design/widget/BottomNavigationView; (declaration of 'android.support.design.widget.BottomNavigationView'

运行环境：
Android Studio 3.3 canary 11, Android Sdk: 28, com.android.support库 28.0.0

I had to change the version of design library from 28.0.0 to 27.1.1
That solved the issue.
But the library should update according to newer design libraries by Google

This exception seems to indicate that the support component BottomNavigationView no longer has a field named "mMenuView".
The library tries to get that field using the getField(Class targetClass, Object instance, String fieldName) method (line 800) without finding it.
I don't know if the source code of the android support 28.0.0 is released yet, but we will have to wait for that release to fix the issue.

I made a PR for this issue : #128
Beware that this would require the use of android support 28.0.0 minimum from now on

I am sorry to be late. Please use version 2.0.0 if support lib >= 28.
Version 27 is abandoned.
For AndroidX, please add config into gradle.properties
android.useAndroidX=true
android.enableJetifier=true


Minor error in configuration options in README

'key' isn't a configuration option.  It looks like the correction option is 'apikey' as shown in the example

you're right. Already fixed. Thanks for the hint!


Question

With Lil bit of tinkering ollama works, I hope?

Please provide the OLLAMA_BASE_URL in the .env file and OLLAMA supported models should work. If you are using docker for RAGbuilder you need to give http://host.docker.internal:11434 instead.
OLLAMA_BASE_URL=http://localhost:11434 #http://host.docker.internal:11434/

tq . got it.!


Examples broken

I attempt to understand how osgjs works goinr through examples but they don't work.
It could be the mismatch with the dependencies in the index.html :
    <script type="text/javascript" src="../vendors/bluebird.js"></script>     <script type="text/javascript" src="../vendors/hammer.js"></script>
But when I look at the corresponding path I find :
<script type="text/javascript" src="../vendors/bluebird-2.10.2.js"></script>     <script type="text/javascript" src="../vendors/hammer-2.0.4.js"></script>
So I made the change for one local index.html and it works.

Hi @vinou31, the examples should be accessed within a server.
You will have a lot of errors if you try to access it directly as you did.
The easiest way is to follow the instructions in the Readme.md -> https://github.com/cedricpinson/osgjs#running-the-examples


Cop idea: Macro Style Methods and Callbacks Order for models

Is your feature request related to a problem?
The Rails Style Guide offers guidance on the ordering of macro methods inside ActiveRecord models.
Macro Style Methods: https://rails.rubystyle.guide/#macro-style-methods
Callbacks Order: https://rails.rubystyle.guide/#callbacks-order
There are currently no cops available to enforce this styling.
Describe the solution you'd like
A cop (or two) that verify correct ordering according to the style guide.
Describe alternatives you've considered
There is an unmaintained rubocop extension called rubocop-rails-order_model_macros that adds this functionality but it has not been updated since 2018 and has an open issue that indicates it doesn't work with the latest Rubocop version.

That cop is licensed with MIT, so my guess is that we can just borrow it.
The incompatibility seems to be due to the hard version requirement and may not be actually a blocker to run it with the latest RuboCop.
In any case, there's a nice ]official cop migration guide](https://docs.rubocop.org/rubocop/1.24/v1_upgrade_notes.html).
Related issue that this cop could fix: #412
Just for the reference: Layout/ClassStructure cop and its docs.
Would you like to submit a PR?

I'll attempt a PR sometime this week 👍

In fact, Layout/ClassStructure cop leaves a lot of problems.
https://github.com/rubocop/rubocop/issues?q=is%3Aissue+is%3Aopen+Layout%2FClassStructure
In addition, I'm worried about the conflict between rubocop-rails-order_model_macros and Layout/ClassStructure, so even whether the PR is opened, it may not be possible to import it into RuboCop Rails at this time. So, There are too many Layout/ClassStructure cop issues left.
Perhaps one approach is to contact the author of rubocop-rails-order_model_macros and maintain the 3rd party gem.

For callbacks order I implemented one  a while ago - https://github.com/rubocop/rubocop-rails/blob/master/lib/rubocop/cop/rails/active_record_callbacks_order.rb
There are so many cops in rubocop and rubocop-rails no one remembers it already exists 😄

For the record: The existing issues with Layout/ClassStructure made me reconsider attempting a PR for this 😬


Initial wallpaper is broadcasted 3 times.

BroadcastReceiver is great but the initial wallpaper is broadcasted 3 times when the app first installed.
2 times when the app is started. Once when the wallpaper is actually set.

A number of improvements have been done in the intervening time, particularly in the latest Muzei 2.6.0 so I suspect this is fixed.


Feature/empty state

Description

On empty state, add a NoDomain component with a button to add a new domain

Screenshots

That's cool! Just in case you're working on more: I'm going to rename a few things today. Might be worth to wait a bit so we don't end in tons of conflicts :)

Pull Request Test Coverage Report for Build 348

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.206%

Totals

Change from base Build 347:
0.0%

Covered Lines:
479

Relevant Lines:
725

💛  - Coveralls

Ok! I'll take a break then. I'm only working outside of "office hours" anyway. Thanks for letting me know.


Try it out with the 0.7 openssl

Hi,
To get this library working with openssl 0.7, I had to remove this part of the code. I spent some time trying to get it to work with no luck.
Would you like to help a bit, so I don't need to break features?

There's actually a PR for this already. There's a TODO on it before it can get merged which I'll address today.

Coverage decreased (-8.4%) to 85.718% when pulling<PHONE_NUMBER>477bee83b00a2a670ad81974018a96 on pimeys:master into 544faee3ffb2e4b46684c0a0ed5a21a4af0c7c54 on mlalic:master.


Support for Google Analytics

We have to explicitly tell Angulartics to send a pageview when the search term changes in /search. I don't know if we should be doing the same thing in other views (eg. collections search?) or why we need to do that explicitly.
Closes #98.

I'm not allowed to use GA in my env; is there any way you could also put this behind a config part, at least the template integration?

If you don't declare GA_TRACKING_ID in the config, the GA script is not injected at all (and the angular code just does nothing). That's why the example config file has it commented out. Is that sufficient?

Does this cover your use case, @pudo ?

Sorry I still wanted to check out if there's a way this can be made to support Piwik also. I'm not allowed to use GA (or load their assets -- which this currently does?), but more fine-grained analytics would be great.

This doesn't load GA assets unless a GA tracking ID is defined.  Don't know about Piwik.


return immediately when matched for efficiency

PR Details
Several functions in sheet.go loop all the sheets even the condition is met
Description
Return immediately when matched
Motivation and Context
For efficiency
Types of changes
Bug fix (non-breaking change which fixes an issue)

Codecov Report

Merging #1049 (cde903a) into master (08ad10f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1049   +/-   ##
=======================================
  Coverage   97.70%   97.70%
=======================================
  Files          29       29
  Lines       16978    16978
=======================================
  Hits        16588    16588
  Misses        267      267
  Partials      123      123

Flag
Coverage Δ

unittests
97.70% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

sheet.go
97.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08ad10f...cde903a. Read the comment docs.

LGTM, thanks for your PR.


Fix findfiles not to fail on missing/invalid dir

Was failing on --dry-run and tests.
Added unit-test.

After this, #191 can be reverted ;)

Thanks!
Can you revert #191 ?


Add .cargo/ icon

Type

[ ] File icon
[X] Folder icon

Context and associations
.cargo/ (see https://doc.rust-lang.org/cargo/reference/config.html)
References
This directory probably needs an icon (folder icon + Cargo.toml icon) but also the config.toml within - perhaps the latter is just handled by #170?

Maybe the config.toml icon should just be a generic TOML icon + config gear/wheel? Used in other places like .rye/config.toml: https://rye.astral.sh/guide/config/#self.


added_functions_annulus

1.Added  area to CircleAnnulusPixelRegion.
2.If no meta is given then it takes region1.meta in CompoundRegion.
3. Added tests

@keflavich some tests are failing.(tests are passing locally).Needed help.

@keflavich can you have a look at this??

@keflavich Have a look at this.!

@bsipocz can you tell me why circle-ci is failing here?

this PR is stagnated for too long. @keflavich  any comments on this ??


Add decimals and remove initial mint from base ERC20 initializer

Summary
This PR addresses issue #194 and contains changes to the initializer for the base ERC20 (erc20/library.cairo) so that it can be used for most ERC20 implementations with minimal modifications.
The changes include:

Decimals is defined as a parameter in the initializer instead of hardcoded to 18

In favor of creating a generalizable base contract for derived contracts to use out of the box, allowing decimals to be defined in the constructor is more flexible and accommodates for non-18 decimal tokens such as USDC
Added checks on decimals for non-zero and < 2^8 (256) as per the EIP-20 spec (in _setDecimals)

Minting of an initial supply to a specified recipient is removed from the base ERC20 initializer

The Solidity ERC20 implementation takes an agnostic approach to token supply mechanisms and just provides the internal _mint function for derived contracts to use in any way they choose - this change brings the Cairo implementation more in line with the Solidity pattern
The initial supply minting logic is moved to the derived contracts instead

New base ERC20 initializer with the above changes implemented:
func ERC20_initializer{
        syscall_ptr : felt*,
        pedersen_ptr : HashBuiltin*,
        range_check_ptr
    }(
        name: felt,
        symbol: felt,
        decimals: felt
    ):
    ERC20_name_.write(name)
    ERC20_symbol_.write(symbol)
    _setDecimals(decimals)
    return ()
end

Fixes #194


Added author to package.json -> "Packages - Denis Rizov" in UPM

Instead of "Packages - Other"

I don't know about the branch workflow. Do I need to create another PR for master with the same change?

The UPM branch is autogenerated every time there is a new commit in master. I will merge that into v2, and next time I merge it into master, the UPM branch will be recreated

Merged into v2 - ea1750278ac12561ed36ad6bd9cb8e99efc87838


Permission is false when I have already given permissions on iOS

flutter: [requestPermission]::true flutter: [hasPermission]::false
I am running demo app, it gives true but when trying to retrieve data it gives false

@FirdousNath I am getting the same error in Android. Did you get any solution for the same? If yes then can you please guide me here?
Thanks in advance.


Is this repo archived?

There are over 400 issues right now and there haven't been any meaningful updates all year. Is this an archived repo and if so, who has the best fork for project continuity?

@julianwagle check out yfrake.
It is also a Yahoo market data scraper, but on steroids. It's not a fork of yfinance, because yfinance codebase was too messy for me to try to clean up.

@julianwagle This looks like only fork with recent updates: https://pypi.org/project/yfinance-ez . I'm going to switch soon and probably contribute some PRs.

@julianwagle I have been given permissions to merge PRs etc, so can start working through backlog. But I would greatly appreciate help reviewing, critiquing etc. Anyone can assign themselves to PRs and suggest changes.


⚠ Bofrost.be has degraded performance

In df80ae5, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1780 ms

Resolved: Bofrost.be performance has improved in e9f1127.


Add Contributors Page

Is your feature request related to a problem? Please describe.
A page to show the contributors section
Describe the solution you'd like
Add the contributors section

contributors section is already on github readme.


Rather than sponsors, I wonder if we should be doing grants

So individual projects can list grants... or maybe the sponsors class has a grant field?

I've thought more about this: and I agree that we should be tracking specific grants (whether or not we float the information externally).

We are now tracking grants...


Dropdown is not getting hide

Whenever it displays a dropdown and I press tab key so as to loose current field focus, dropdown keeps on being displayed...

It also happens whenever I press "enter key", so as to insert new tag. It keeps on showing..

Do you have any trick so as to do right now in order to release to my customer? Or, do you know when could you guys solve it? Thanks!

same happens when I backspace clearing the tags. drop down menu keeps on showing..

Hi @igordeoliveirasa. Thanks for opening this. I will probably fix it this weekend.

I thank you so much for the answer!! And congratulations again! Awesome project! It will be the top  of the angular 2 tag input components. You want to bet?

Hi @igordeoliveirasa,
I published the version 0.2.2 and should fix this :)


Allow setting the Prometheus instance document title through a flag.

implemented: #4683

The HTML title can now be set via a flag: --web.ui-title="[custom name]"

cc @juliusv

I can actually see this being useful if you have a bunch of tabs with different Prometheus servers open and you want to quickly differentiate them by, say, datacenter name. However, I want to make sure that others think it's a good idea to add this as a flag as well.
@brian-brazil and others?

I'm not sure about this one either way to be honest.

Hey has there been any decision made or this or does anything else need changing? :)

@achiuBAE you need to run make assets, commit the changes and push again.

LGTM


Enable/Disable xdebug extension on demand

This allows better performance in development mode
In debug panel in atom:

When open panel then enable xdebug extension
When close panel then disable xdebug extension

As in enable the extension inside PHP? I believe that would be out of scope for this project, as it requires a restart/rehash of PHP.

I really don’t known but it is possible in phpstorm https://blog.jetbrains.com/phpstorm/2016/06/xdebug-on-demand-for-cli-php-scripts-in-phpstorm-2016-2-eap/

If you create a configuration to define a script file to execute on open  debug panel?

I think that @leandrogehlen talking about the functionality which was working before last update. Now when PHP Debug pane is closed and php code runs with exception, atom automatically opens the file and mark line where the exception has been occured.
Before update the PHP Debug window have to be opened to mark exceptions.
So, It looks like the PHP Debug is working still in the bacground, because the Action Bar is also 'blinking' on screen (if no watchpoints, breakpoints marked and PHP Debug pane is closed).

@leandrogehlen and @appleandpear I've added a setting to stop listening when all the windows have been closed. Should be available in v0.3.4.

Thanks @cchamplin - works like a charm. 👍


Add error handling to cart redux thunks

Add error handling to cart redux - specifically .catch for thunks

Merged and closed.


Mono Build Error: Optional parameters must appear after all required parameters

The problem
Describe the bug
When building a Godot Mono project that uses the Dialogic plugin, a build error occurs.
To Reproduce
Steps to reproduce the behavior:

Download and install Godot Mono for Windowx x64, and the documented microsoft SDK on the godot website
Create a new Godot mono project and attach a C# script to the root node of the main scene
Build the project (should build successfully at this stage)
Clone this repo in another folder (used commit 10c14d149e562466b8bb5dc62c8d65d6e7844f3f)
Copy the addons/dialogic folder from the dialogic repo into the project
Create a timeline
Add a single text event to the timeline
Add addons/dialogic/Dialog.tscn to the root node as a child node
Select the timeline created earlier in the propery inspector for the Dialog node
Build the project

Expected behavior
Build error:
<folder path ommitted for privacy>\addons\dialogic\Other\DialogicSharp.cs(16,102): Optional parameters must appear after all required parameters

Solutions
Workaround
No known workaround, it's a build error.
Possible fixes
Short term fix: change add a default value to String dialogScenePath = "". This would be backwards compatible for existing users of the library but I haven't tested if this works.
Long term fix: If dialogScenePath can't be optional and default to "", reorder the parameters.  This would be backwards incompatible and require support for downstream users of the library.

Working on the recommended short term fix now, will have a PR soon.

I have a PR which I've tested against my own project.
Build results after the fix:
Build with surface heuristics started at 14:36:20
Use build tool: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\MSBuild.exe
CONSOLE: Microsoft (R) Build Engine version 16.11.2+f32259642 for .NET Framework
CONSOLE: Copyright (C) Microsoft Corporation. All rights reserved.
CONSOLE: Build started 2021-11-30 2:36:20 PM.
CONSOLE: Project "C:\Users\sesop\AppData\Local\Temp\Xekicit.proj" on node 1 (default targets).
CONSOLE: ControllerTarget:
CONSOLE:   Run controller from C:\Program Files\JetBrains\JetBrains Rider 2021.2.2\lib\ReSharperHost\JetBrains.Platform.MsBuildTask.v15.dll
0>------- Started building project: GameCollabFirst
0>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\Roslyn\csc.exe /noconfig /unsafe- /checked- /nowarn:1701,1702,1701,1702,2008 /fullpaths /nostdlib+ /errorreport:prompt /warn:4 /define:GODOT;GODOT_WINDOWS;GODOT_PC;TRACE;TOOLS;DEBUG;NETFRAMEWORK;NET472;NET20_OR_GREATER;NET30_OR_GREATER;NET35_OR_GREATER;NET40_OR_GREATER;NET45_OR_GREATER;NET451_OR_GREATER;NET452_OR_GREATER;NET46_OR_GREATER;NET461_OR_GREATER;NET462_OR_GREATER;NET47_OR_GREATER;NET471_OR_GREATER;NET472_OR_GREATER /errorendlocation /preferreduilang:en-US /highentropyva+ /reference:C:\Users\sesop\Documents\github.com\sesopenko\GameCollabFirst\.mono\assemblies\Debug\GodotSharp.dll /reference:C:\Users\sesop\Documents\github.com\sesopenko\GameCollabFirst\.mono\assemblies\Debug\GodotSharpEditor.dll /reference:C:\Users\sesop\.nuget\packages\microsoft.netframework.referenceassemblies.net472\1.0.0\build\.NETFramework\v4.7.2\mscorlib.dll /reference:C:\Users\sesop\.nuget\packages\microsoft.netframework.referenceassemblies.net472\1.0.0\build\.NETFramework\v4.7.2\System.Core.dll /reference:C:\Users\sesop\.nuget\packages\microsoft.netframework.referenceassemblies.net472\1.0.0\build\.NETFramework\v4.7.2\System.Data.dll /reference:C:\Users\sesop\.nuget\packages\microsoft.netframework.referenceassemblies.net472\1.0.0\build\.NETFramework\v4.7.2\System.dll /reference:C:\Users\sesop\.nuget\packages\microsoft.netframework.referenceassemblies.net472\1.0.0\build\.NETFramework\v4.7.2\System.Drawing.dll /reference:C:\Users\sesop\.nuget\packages\microsoft.netframework.referenceassemblies.net472\1.0.0\build\.NETFramework\v4.7.2\System.IO.Compression.FileSystem.dll /reference:C:\Users\sesop\.nuget\packages\microsoft.netframework.referenceassemblies.net472\1.0.0\build\.NETFramework\v4.7.2\System.Numerics.dll /reference:C:\Users\sesop\.nuget\packages\microsoft.netframework.referenceassemblies.net472\1.0.0\build\.NETFramework\v4.7.2\System.Runtime.Serialization.dll /reference:C:\Users\sesop\.nuget\packages\microsoft.netframework.referenceassemblies.net472\1.0.0\build\.NETFramework\v4.7.2\System.Xml.dll /reference:C:\Users\sesop\.nuget\packages\microsoft.netframework.referenceassemblies.net472\1.0.0\build\.NETFramework\v4.7.2\System.Xml.Linq.dll /reference:C:\Users\sesop\.nuget\packages\microsoft.netframework.referenceassemblies.net472\1.0.0\build\.NETFramework\v4.7.2\Facades\netstandard.dll /debug+ /debug:portable /filealign:512 /optimize- /out:C:\Users\sesop\Documents\github.com\sesopenko\GameCollabFirst\.mono\temp\obj\Debug\GameCollabFirst.dll /subsystemversion:6.00 /target:library /warnaserror- /utf8output /deterministic+ /langversion:7.3 /analyzerconfig:C:\Users\sesop\Documents\github.com\sesopenko\GameCollabFirst\.mono\temp\obj\Debug\GameCollabFirst.GeneratedMSBuildEditorConfig.editorconfig addons\dialogic\Other\DialogicSharp.cs "C:\Users\sesop\Documents\github.com\sesopenko\GameCollabFirst\.mono\temp\obj\Debug\.NETFramework,Version=v4.7.2.AssemblyAttributes.cs" C:\Users\sesop\Documents\github.com\sesopenko\GameCollabFirst\.mono\temp\obj\Debug\GameCollabFirst.AssemblyInfo.cs /warnaserror+:NU1605
0>GameCollabFirst -> C:\Users\sesop\Documents\github.com\sesopenko\GameCollabFirst\.mono\temp\bin\Debug\GameCollabFirst.dll
0>------- Finished building project: GameCollabFirst. Succeeded: True. Errors: 0. Warnings: 0
Build completed in 00:00:01.168
Build succeeded at 2:36:21 p.m.

The build error is gone and now I'm getting the following error when enabling the plugin, which I suspect is unrelated:
--- Debugging process stopped ---
 res://addons/dialogic/Editor/CharacterEditor/CharacterEditor.gd:53 - Invalid call. Nonexistent function 'get_settings_value' in base 'GDScript'.

I created a test scene with a dialog and it now runs successfully in godot mono x64 locally on my machine
Screenshot of it now working:

@coppolaemilio the PR fixing this issue: https://github.com/coppolaemilio/dialogic/pull/658

DialogicSharp.cs:16 needs to be updated to either be:
  public static T Start<T>(String timeline = "", String default_timeline = "", String dialogScenePath = "res://addons/dialogic/Nodes/DialogNode.tscn", bool useCanvasInstead = true) where T : class
  {
    return (T)_dialogic.Call("start", timeline, default_timeline, dialogScenePath, useCanvasInstead);
  }

Or check to see if dialogScenePath is set, and if not, call a different start() overload. Right now, if you run a new C# project, you get the error:
ERROR: Resource file not found: res://.
   At: core/io/resource_loader.cpp:287

Because it defaults the resource to empty string.


pull request for e2e test at 12/25/2016 05:45:15

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


documentation - checkpointing and reusing models

Hi. This is very interesting software. Thank you for providing it.  It seems to run stably.  Congratulations, this is not easy.
How do you restart a training run from a checkpoint?
How do you generate new data from an existing model?

launcher.py is designed to automatically do hyper parameter random search  on multiple datasets. Thus it is not very straightforward to restart training and generate new data from an existing model. But you can still do that.

Go to the experiment folder, find the param.json, and get all the hyper parameters.
To restart training, run python3 src/TGAN_synthesizer.py [...] --data xxx.npz --load xxx.ckpt. You can find xxx.npz in the experiment folder generated by launcher. xxx.ckpt is the checkpoint you want to load. [...] are all the hyper parameters in param.json.
To generate new data, run python3 src/TGAN_synthesizer.py [...] --data xxx.npz --load xxx.ckpt --sample 1000. It can sample 1000 new rows from the saved model.


Potential Enhancement - stop using $(document).ready and put scripts at the bottom

I've ready in a few places that it's best to place all scripts at the bottom so that you have a de factor document.ready status before executing scripts.  One example: http://modernweb.com/2013/05/06/5-things-you-should-stop-doing-with-jquery/.
I don't feel strongly about this.  What one person says is a best practice may well turn out to be a 1-person opinion.
Loving the course!
Challenge Waypoint: Learn how Script Tags and Document Ready Work has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

jQuery Playground

#left-well

        <button class="btn btn-default target" id="target1">#target1</button>
        <button class="btn btn-default target" id="target2">#target2</button>
        <button class="btn btn-default target" id="target3">#target3</button>

#right-well

        <button class="btn btn-default target" id="target4">#target4</button>
        <button class="btn btn-default target" id="target5">#target5</button>
        <button class="btn btn-default target" id="target6">#target6</button>

This is not a bad observation and I think I agree with you.  I don't think we'll make the change immediately, as it is high touch.  Ultimately, our plan is to move to a multi-tab editor interface which would move all of the JS into a separate file.  We will definitely take it under advisement to put the link elements at the end of the page for that.


Infinite recursion while attempting to load

Describe the bug
When trying to load in the REPL, an infinite recursion is triggered (I used the REPL just as the easiest way I know to load).
Steps To Reproduce
On a fresh new installation of Nix on MacOS:
nix repl '<nixpkgs>'

Expected behavior
Load nixpkgs, as described in https://nixos.wiki/wiki/Nix_command/repl
Additional context
~ % nix repl '<nixpkgs>'
warning: future versions of Nix will require using `--file` to load a file
Welcome to Nix 2.15.0. Type :? for help.

error:
       … in the left operand of the update (//) operator

         at /nix/store/sq0gp79s1kjhf6ilxfkxsqxasi5znh1c-nixpkgs/nixpkgs/lib/fixed-points.nix:69:64:

           68|   #
           69|   extends = f: rattrs: self: let super = rattrs self; in super // f self super;
             |                                                                ^
           70|

       … in the left operand of the update (//) operator

         at /nix/store/sq0gp79s1kjhf6ilxfkxsqxasi5znh1c-nixpkgs/nixpkgs/lib/fixed-points.nix:69:64:

           68|   #
           69|   extends = f: rattrs: self: let super = rattrs self; in super // f self super;
             |                                                                ^
           70|

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: infinite recursion encountered

       at «none»:0: (source not available)

Metadata
~ % nix-shell -p nix-info --run "nix-info -m"
error:
       … <borked>

         at «none»:0: (source not available)

       … in the left operand of the update (//) operator

         at /nix/store/sq0gp79s1kjhf6ilxfkxsqxasi5znh1c-nixpkgs/nixpkgs/lib/fixed-points.nix:69:64:

           68|   #
           69|   extends = f: rattrs: self: let super = rattrs self; in super // f self super;
             |                                                                ^
           70|

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: infinite recursion encountered

       at «none»:0: (source not available)

Maybe this is the wrong repo, since in this command nixpkgs is not even involved...

What revision of nixpkgs are you on?

The one that has been brought today by the installer (i.e. sh <(curl -L https://nixos.org/nix/install)):
~ % nix derivation show --experimental-features nix-command $(nix-store --query --deriver $(nix-instantiate --eval --expr '<nixpkgs>'))
warning: The interpretation of store paths arguments ending in `.drv` recently changed. If this command is now failing try again with '/nix/store/48w7693vpcvh9209ka78w4ha7312pb4j-nixpkgs.drv!*'
{
  "/nix/store/48w7693vpcvh9209ka78w4ha7312pb4j-nixpkgs.drv": {
    "args": [],
    "builder": "builtin:unpack-channel",
    "env": {
      "builder": "builtin:unpack-channel",
      "channelName": "nixpkgs",
      "name": "nixpkgs",
      "out": "/nix/store/sq0gp79s1kjhf6ilxfkxsqxasi5znh1c-nixpkgs",
      "preferLocalBuild": "1",
      "src": "/nix/store/43qqfhr631qqbi0k954a6s5ll0dxzkxa-nixexprs.tar.xz",
      "system": "builtin"
    },
    "inputDrvs": {},
    "inputSrcs": [
      "/nix/store/43qqfhr631qqbi0k954a6s5ll0dxzkxa-nixexprs.tar.xz"
    ],
    "name": "nixpkgs",
    "outputs": {
      "out": {
        "path": "/nix/store/sq0gp79s1kjhf6ilxfkxsqxasi5znh1c-nixpkgs"
      }
    },
    "system": "builtin"
  }
}

"Transferred" to https://github.com/NixOS/nix/issues/8404


Does dynomite support redis-cli --pipe option?

Assume there are 2 dynomite nodes, one in each datacenter with token "0".
I'm trying to load the redis AOF file in node-1 using below command. But the data is not written into redis, hence no replication as well.

[root@datacenterone /]# cat appendonlyOrig.aof | redis-cli -h <IP_ADDRESS> -p 8102 --pipe
All data transferred. Waiting for the last reply...
Error reading from the server: Connection reset by peer

Whereas I can execute this directly on redis server.

[root@datacenterone /]# cat appendonlyOrig.aof | redis-cli -h <IP_ADDRESS> -p 6379 --pipe
All data transferred. Waiting for the last reply...
Last reply received from server.
errors: 0, replies: 6

My question here is whether dynomite currently support such use cases?

@rajanarayan92 We don't support the --pipe mode at the moment. You're welcome to submit a patch to support it if you like.
On another note, to load from an AOF file, you can make the node load from the file on redis-server startup by putting the file in a pre-determined path:
http://download.redis.io/redis-stable/redis.conf
AOF and RDB persistence can be enabled at the same time without problems.
If the AOF is enabled on startup Redis will load the AOF, that is the file
with the better durability guarantees.

Closing this. Please reopen if you have more questions.


Splat 2.0.0 is not compatible with Acr.UserDialogs 6.3.10

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[x] iOS
[x] Android
[] UWP
[] PCL

Version of OS(s) listed above with issue
MacOS
Version of ACR UserDialogs Library
6.3.10
Expected Behaviour
Upgrade Splat library to 2.0.0
Actual Behavior
Unable to resolve dependencies. 'Splat 2.0.0' is not compatible with 'Acr.UserDialogs 6.3.10 constraint: Splat (>= 1.6.2 && < 2.0.0)'

What's the first thing it says in the "code of conduct"?  The thing you deleted...!
I'm not ready to move this library to .NET standard which splat 2.0 is.

Allright, thanks for pointing out my error! I'll be watching the repo for updates.


Track manual changes with CUSTOMIZATIONS.md

Like described in my comment here (https://github.com/kcamcam/vscode_dark_modern.zed/issues/2#issuecomment-2243752200), I have tried my own hand at creating a repository which has both Modern Dark and Modern Light themes included. I adopted the idea of tracking changes in CUSTOMIZATIONS.md, because this would allow us to track which values are generated by the importer and which ones are manually created.
Pros:

It allows us to easily see which values we should overwrite and which we maybe want to keep if the theme_importer program behavior changes (e.g. it generates different color values for certain fields).

Cons:

It adds additional work, especially when changing many values manually, maybe deterring people from contributing
This is extra effort to try to account for theoretical changes to theme_importer that may or may not even occur
Requires close attention during reviewing, although theoretically this process could be automated with a script (I tried this, didn't end up finishing it)

So if you're not sold on the idea, feel free to close this issue.

Thanks for the issue @2zqa.
I agree with the pros and cons. Ultimately I think that the extra cost in maintainability outweighs the mentioned pros.
Let's leave the issue open to see if anyone else has an opinion or other ideas.

It's been two weeks, I'll go ahead and close this. Looking back at this issue, it's probably not worth it. Plus, git blame can be used in dire situations.


Stored Procedure Param with Default is Marked as Required

Describe the bug
After updating Supabase, my functions that have a parameter of   p_user_id uuid default auth.uid() now require p_user_id to be passed in gql.
To Reproduce
Steps to reproduce the behavior:

Create the following function (yes I know it is pointless, but shows the issue):

create function public.get_user_id(
  p_user_id uuid default auth.uid()
)
returns text
stable
language sql
as $$
  select p_user_id;
$$;

The following gql query works, but it requires pUserId:

query {
  userId: getUserId(
    pUserId: "00000000-0000-0000-0000-000000000000"
  )
}

Expected behavior
When introspecting the schema, pUserId should not be required
Versions:

PostgreSQL: PostgreSQL 15.1
pg_graphql commit ref: v1.5.4

Additional context
This was working last week (pUserId not being required in gql). I am working in a local dev enviroment. I recently updated the cli to version 1.178.2. I don't remember which version i was on before tho.

The difference was introduced between 1.4.2 and 1.4.3
@imor could you take a look?
In the changelog for 1.4.3 there are a couple of references to UDF defaults that look promising


Default Resolver is not set for Finally Tasks

Expected Behavior
Default Resolver is set for Finally Tasks
Actual Behavior
Default Resolver is not set for Finally Tasks
Additional Info
Was looking into the SetDefaults function and realized that support for default Resolver is not implemented for Finally Tasks:
https://github.com/tektoncd/pipeline/blob/9ff4f888e30aa8c11e24fb3fc74f81d95c3c7362/pkg/apis/pipeline/v1/pipeline_defaults.go#L34-L65
Related PR: https://github.com/tektoncd/pipeline/pull/6317
cc @QuanZhang-William

Ahh... Good catch and thank you @jerop!
/assign


Upgrading to A-Frame 1.5.0

Mostly works with 1.5.0, but upgrading all the examples has revealed a handful of issues.

color changes in some examples.  This is due to previously bugged code, using A-Frame 1.4.2 and colorManagement: true, calls should be made to applyColorCorrection, when using THREE.js Color() directly.  This is handled automatically in 1.5.0.  Where these calls were missing, the examples were previously showing the "wrong" colors, and are now correct.

physics-ammo.html

Hits error when re-spawning a ball.
ReferenceError: body is not defined

To be investigated under c-frame/aframe-physics-system

updates.html & updates-multi-mesh.html

When mesh capacity is updated, a large instance appears at the origin, and frame rate drops (particularly noticeable with the multi-mesh example).
This requires further investigation.

Physics problem is nothing to do with 1.5.0, just a bug in aframe-physics-system - fixed here: https://github.com/c-frame/aframe-physics-system/pull/54

Problem 3 turns out to be a regression in 1.4.0.   Issue was instancedMesh.count not being set up correctly on initialization, so additional instances without specified matrices were being rendered.
Problem didn't appear at 1.3.0 - not sure why, but new code should be better for all versions.
Fix here:
https://github.com/diarmidmackenzie/instanced-mesh/commit/e11ef1045d92f6b192efcfafcd008de46fb35b46

Addressed by #38


Support Bookmark Seperators in JSON definition

With a large number of bookmarks, a bookmark list it can quickly become confusing. This is where (sub)-folders can help. However, sometimes a (sub-)folder is unwanted and a divider would be the desired way to go.
It would be nice to define separators as child elements in the json bookmark definition file as well:

Thanks for the idea, @chberger. Funnily enough I had the exact same thought yesterday.
Unfortunately there is one problem here: whereas Firefox supports the creation of vertical and horizontal separators, Chrome decided that this feature is too complex for their users to understand.
That leaves us with a few options:

Don't support separators
Only support separators for Firefox and silenty drop them for Chrome
Substitute separators in Chrome with bookmarks with a name like "__________" to simulate a placeholder
(inspired by https://bookmarkseparators.com/?i=folder )

What do you think? I'm not sure if I really like the UX of option 3 and forcing it on end users. On the other hand I wouldn't want to needlessly introduce a configuration toggle for this.
@mbechto @chberger

Perhaps 3.

@frederikb Thanks for the explanation. I would vote for option 2. However, since I don't use Chrome at all option 3 would also be acceptable. 😆

What do you think? I'm not sure if I really like the UX of option 3 and forcing it on end users. On the other hand I wouldn't want to needlessly introduce a configuration toggle for this.

@frederikb can't this be done in code? if browser == 'chrome' { insert('________') } ...

@frederikb Yes. I simply meant that perhaps some Chrome users would rather forgoe separators entirely rather than having these substitutes.
Nevertheless, I'll give it a try and report back.
I'll also focus on horizontal separators only and skip vertical separators in the bookmarks (tool)bar.

I've experimented with custom separators inspired by solutions such as https://bookmarkseparators.com/?i=folder . The overall verdict was that it's a bad UX and that we will skip separators for all non-Firefox browsers for now.


Added Root::Clone function

Signed-off-by: Nate Koenig<EMAIL_ADDRESS>🎉 New feature
Summary
Adds a Root::Clone function so that one sdf::Root can copy another sdf::Root
This is just a Fortress fix. Here is a fix for Garden: https://github.com/ignitionrobotics/sdformat/pull/844
Checklist

[x] Signed all commits for DCO
[x] Added tests
[x] Updated documentation (as needed)
[x] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Codecov Report

Merging #843 (9c16a72) into sdf12 (8e832e7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            sdf12     #843      +/-   ##
==========================================
+ Coverage   90.76%   90.78%   +0.01%
==========================================
  Files          78       78
  Lines       12535    12555      +20
==========================================
+ Hits        11378    11398      +20
  Misses       1157     1157

Impacted Files
Coverage Δ

src/Root.cc
94.01% <100.00%> (+0.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e832e7...9c16a72. Read the comment docs.

I'm combining this PR with #841 due to testing overlap


Trained model

It's a very interesting work. Could you provide your trained model? Thanks a lot.

@baolinv Hi, now you can find the model in /models/ckpts/ and feel free to try it!


For the not-square attn (How to generate 'Relative position bias' when 'attn' is a non-square matrix ?)

https://github.com/microsoft/Swin-Transformer/blob/6bbd83ca617db8480b2fb9b335c476ffaf5afb1a/models/swin_transformer.py#L129
When the dimensions of Q, K are not the same (i.e., N_q is not equal to N_k), the generated attn is non-square, so I resize the relative_position_bias. I tried, but the relative_position_bias does not work as expected.
How should I generate relative_position_bias for this case? Looking forward to your reply : )

Hi,
We first defined a relative_position_bias_table for each possible relative position per head.
https://github.com/microsoft/Swin-Transformer/blob/fa36255a62b37bc37c05133d7af5704b88d1ad3c/models/swin_transformer.py#L89-L90
In our case, all possible relative positions are:

(-Wh+1, -Ww+1)
...
(-Wh+1, -2)
(-Wh+1, -1)
(-Wh+1, 0)
(-Wh+1, 1)
(-Wh+1, 2)
...

(Wh-1, -Ww+1)
...
(Wh-1, -2)
(Wh-1, -1)
(Wh-1, 0)
(Wh-1, 1)
(Wh-1, 2)
...
(0, Ww-1)

where Wh/Ww represent the height/width of the window. So the total number of all possible relative positions are(2xWh-1) x (2xWw-1).
With the relative_position_bias_table, we now can select the corresponding value(relative_position_bias) from it based on the relative position (∆h,∆w) of each q and k:
https://github.com/microsoft/Swin-Transformer/blob/fa36255a62b37bc37c05133d7af5704b88d1ad3c/models/swin_transformer.py#L93-L103
https://github.com/microsoft/Swin-Transformer/blob/fa36255a62b37bc37c05133d7af5704b88d1ad3c/models/swin_transformer.py#L126
Note that because pytorch doesn't support selecting the relative_position_bias_table using a 2D relative position matrix, so we first change it to a 1D index.
As for your question, I have the following suggestions:

First, list all possible relative positions of Q and K and then define the relative_position_bias_table.
Second, select the corresponding value from the relative_position_bias_table based on the relative position of each q and k.

Hope it can help😊.


restore STDIN input

JCommander has been updated and now passes '-' as an input File when encountered

Can you please describe what this PR is solving?
I had a look at the linked issue, but I am not fully clear about what this change achieves.

Now I understand what this is about.
Thanks for this fix!
Can you please open a ticket, because even I wasn't aware that the AsciidoctorJ CLI currently does not support reading from stdin.
Also could you please extend the description of the input files parameter at AsciidoctorCLIOptions.parameters stating that a single value of - reads the input from stdin?

Document use of '-' to read STDIN.
Use IOUtils instead of Scanner - not really more legible in my opinion, due to exceptions in close().
Open and link issue https://github.com/asciidoctor/asciidoctorj/issues/865

While testing I figured these 2 differences from the asciidoctor CLI, which I think we should align with:

When converting to an html document from stdin, asciidoctor creates a full document including headerFooter, whereas asciidoctorj now only creates the body of the document, ie without the headerFooter option:

cat ~/dev/asciidoctorj/test.adoc|asciidoctor -|head
<!DOCTYPE html>

<meta charset="UTF-8">
...

vs
cat ~/dev/asciidoctorj/test.adoc|./asciidoctorj -|head

Test

...

When converting to pdf without outputfile asciidoctor writes the PDF as text to stdout, while asciidoctorj fails with an exception:

cat ~/dev/asciidoctorj/test.adoc| asciidoctor-pdf - 2&>/dev/null |head
%PDF-1.4
%����
1 0 obj
<< /Title (Test)
/Creator (Asciidoctor PDF 1.5.0.beta.6, based on Prawn 2.2.2)
/Producer (Asciidoctor PDF 1.5.0.beta.6, based on Prawn 2.2.2)
...

vs
cat ~/dev/asciidoctorj/test.adoc| ./asciidoctorj -b pdf - |head
Nov 13, 2019 4:34:27 PM org.asciidoctor.jruby.internal.JRubyAsciidoctor convert
SEVERE: org.jruby.RubyTypeError
Exception in thread "main" org.asciidoctor.jruby.internal.AsciidoctorCoreException: org.jruby.exceptions.TypeError: (TypeError) cannot convert instance of class org.jruby.gen.RubyObject50 to class java.lang.String
	at org.asciidoctor.jruby.internal.JRubyAsciidoctor.convert(JRubyAsciidoctor.java:318)
	at org.asciidoctor.jruby.internal.JRubyAsciidoctor.convert(JRubyAsciidoctor.java:334)
	at org.asciidoctor.jruby.internal.JRubyAsciidoctor.convert(JRubyAsciidoctor.java:329)
	at org.asciidoctor.jruby.cli.AsciidoctorInvoker.renderInput(AsciidoctorInvoker.java:156)
	at org.asciidoctor.jruby.cli.AsciidoctorInvoker.invoke(AsciidoctorInvoker.java:73)
	at org.asciidoctor.jruby.cli.AsciidoctorInvoker.main(AsciidoctorInvoker.java:222)
Caused by: org.jruby.exceptions.TypeError: (TypeError) cannot convert instance of class org.jruby.gen.RubyObject50 to class java.lang.String

I guess if no output is set and input is read from stdin, we need to set the stream stdout as the output stream.


Not working after cleaning browser with CCleaner/CCEnhancer

I've just used CCleaner with CCEnhancer to clean my computer yesterday. In CCleaner, I check every option about Firefox except Cookies, Saved Form Information and Saved Passwords. After that, whenever I went to Youtube, while greasemonkey still had "Youtube Center Developer Build" in the script availabled, there's no trace of it anywhere: no gear icon, no Download button... just like a normal youtube layout.
Browser: Cyberfox 36.0 x64
YT version use: Developer 492, Greasemonkey script

Have you tried the obvious steps of re-installing Greasemonkey and/or YTC?

ccleaner is probably the worst program there is

I already did and it's working now. What I want to know is how CCleaner+CCEnhancer affects YTC and by what options. Just curious, that's all.

@q1k: That statement doesn't help anything.
@blue-lightning: I don't use CCEnhancer, but I do use CCleaner regularly and don't have this problem. I believe the "Site Preferences" option is responsible for losing your settings in YTC. Next time you run CCleaner, leave that option unchecked and see if you still lose settings.

@Zarggg  It's not that the settings are lost, but the whole script does not run at all, leaving behind an unchanged YT

That's really unusual. I can't think of a way that CCleaner would interfere with a userscript functioning at all unless it's somehow set up to delete it all together.
In the interest of troubleshooting, what files (excluding the cache) come up for Firefox when you run it? Click Analyze instead of Run Cleaner so that it doesn't delete the files.

Since this is an Analyze after cleaning up 3 days ago, it is probably less than normal. CCleaner/CCEnhancer detected lots of files in:
C:\Users[Username]\AppData\Local\8pecxstudios\Cyberfox\Profiles[ProfileDefaultName] - Internet Cache + Internet History
C:\Users[Username]\AppData\Roaming\8pecxstudios\Cyberfox\Profiles[ProfileDefaultName] - Session + Site Preferences

Excluding cache and history files, can you put a full list of the files on a pastebin somewhere and link it here? Ultimately, this may be an issue with CCleaner deleting something it should not be.
I see you mention you still have Site Preferences selected. That could very well be what is causing the problem.

I'd have to agree with Zarggg. If you really have to get rid of such data (at least in Firefox or it's ports), do it from the browser and not via an external application.

Yup, Firefox Site Preference alright. Since it's an option not of CCEnhancer, guess I can't look into it to figure out what cause the problem. Thank you @Zarggg !
@ErdeFB I have used CCleaner and CCEnhancer for years without a hitch (till now) despite a lot of people saying they were dangerous. Beside, having a centre program to clean up everything is pretty convenient.
Now how do I close this issue...

As a follow-up, situations like this are why I have CCleaner set to not delete the Site Preferences files in my own install. The program isn't inherently "dangerous," but it's not for the novice, either. Sometimes you need to do a bit of research into what the files it deletes are actually used for.


fix projected vs max query size check for queries w/ LIMIT clause [JIRA: RIAK-3195]

There was a bug in 1.5.0 where, for queries with a LIMIT clause, the projected query size was incorrectly computed. The LIMIT value was used as the number of chunks in the calculations and not as the number of rows as it ought to be.
Separately, this PR fixes the logic of the max query data size checks for the case where LIMIT is big but the WHERE range is small. Such queries should not be cancelled.

create jira issue

:+1:

@paegun This is a duplicate of #1619 which you had previously reviewed. Mind +1ing this one, too?

+1

thumbs retry

+1


Autocomplete "no matches found" lowercased

In the German translation, the "no matches found" text seems to be lowercased:

This should read "Keine Treffer gefunden", like it's in the localization file.

Here: https://github.com/yourlabs/django-autocomplete-light/blob/master/autocomplete_light/autocomplete/base.py#L187
Since backward compatibility is king here, I suggest we get the translation, check if the first letter is capitalized, and only call .capitalize() if it is not. We'd need a test case for that too. Do you want to make the PR ? Is it the kind of things you're into or would you rather have somebody else take care of that one ?

Do you really think that backwards compatibility is so important here? We can easily say in the release notes that the string is now left unmodified, and if someone relies on the case of the letters, it's easily fixed.

On Tue, Sep 22, 2015 at 10:24 AM, Jonas Haag<EMAIL_ADDRESS>wrote:

Do you really think that backwards compatibility is so important here? We
can easily say in the release notes that the string is now left unmodified,
and if someone relies on the case of the letters, it's easily fixed.

Right but then we can't put it in a minor version release, we'd have to
release this as 2.3.0.
--
http://yourlabs.org http://blog.yourlabs.org
Customer is king - Le client est roi - El cliente es rey.

OK, let's put make this part of the 2.3 milestone then.

Could you add this to the 2.3 GitHub milestone so we don't lose it?

To be clear, we just have to remove the .capitalize() call here ?

Closing in favor of PR #548


Python console: do not require output that looks like a traceback to be valid

which causes Error to be flagged with output that just happens to look like a traceback
Fixes #2407

Note: alternate fix would be to just allow stray lines in PythonTracebackLexer.

The fix is fine, but it produces "one character tokens". Can we track if we're in "error mode" and while we're in error mode, accumulate tokens, and if we're in the first non-error token, yield the whole text accumulated so far?

Yeah, true, I like this better then.


[Question] I want to use the RAG function offline, but I only found the KEY for OPENAI in the documents and search.

Context / Scenario
Use kernelmemory to process notes on a local computer, create a knowledge base from your own organized notes, and then review them.
Question
I want to create a local knowledge base feature. I added Gemma: 2b using the semantic kernel to the reference document. But I want to use RAG to analyze the QA of books or knowledge bases. Because I cannot connect to the internet, I am unable to use OPENAI's remote RAG. I tried downloading the m3e-base, but I do not know how to use the offline RAG model in kernelmemory. Is there an example?

Hi @duwenlong2, there's no immediate support for custom models, so you'd need to write a couple of classes to implement ITextGenerator and ITextEmbeddingGenerator, leveraging the custom model you're choosing.
https://github.com/microsoft/kernel-memory/blob/main/service/Abstractions/AI/ITextGenerator.cs
https://github.com/microsoft/kernel-memory/blob/main/service/Abstractions/AI/ITextEmbeddingGenerator.cs
Once you have those classes, it's easy to plug them in, e.g. using KM builder methods WithCustomEmbeddingGenerator and WithCustomTextGenerator.

Sorry, due to unfamiliarity with AI. After several days of tinkering, I still couldn't achieve this function. Do you have similar examples or more information?


Connect an existing API via Redux

Project requirements
In the previous project, you added the add book and remove book features directly in your application. Now you will refactor your code to use an external API to facilitate these features.

Make use of the Bookstore API as your backend.
Use axios with createAsyncThunk to make your HTTP requests to the backend
Fetch your books from the Bookstore API after the component has rendered
Refactor your add book and remove book features to persist your changes in the server
Your application should behave the same way after the refactoring

Note: Styling is not required

thanks for your time


kubevirt vm not starting on vcluster

What happened:
A clear and concise description of what the bug is.
I can successfully deploy vm demo on minikube cluster. but failed in vcluster.
What you expected to happen:
A clear and concise description of what you expected to happen.
I expect the vm demo to start and run in vcluster.
How to reproduce it (as minimally and precisely as possible):
Steps to reproduce the behavior.
Additional context:
Add any other context about the problem here.
logs from successful host instance and failed vcluster are attached. the difference is located around:
{"component":"virt-launcher","kind":"","level":"info","msg":"Executing PreStartHook on VMI pod environment","name":"testvm","namespace":"vcvm","pos":"manager.go:531","timestamp":"2023-04-15T21:15:22.760831Z","uid":"e3a9fb70-273f-4498-8f16-30e1660a6fbe"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Starting PreCloudInitIso hook","name":"testvm","namespace":"vcvm","pos":"manager.go:552","timestamp":"2023-04-15T21:15:22.760942Z","uid":"e3a9fb70-273f-4498-8f16-30e1660a6fbe"}
Environment:

KubeVirt version (use virtctl version): v0.34.2
Kubernetes version (use kubectl version): "v1.26.3"
VM or VMI specifications: (https://raw.githubusercontent.com/kubevirt/demo/master/manifests/vm.yaml)
Cloud provider or hardware configuration: minikube on bare metal
OS (e.g. from /etc/os-release): ubuntu 20.04 on hyperv
Kernel (e.g. uname -a): 5.4.0-146-generic
Install tools: virtctl
Others: N/A

logs from successful host instance:
{"component":"virt-launcher","level":"info","msg":"Collected all requested hook sidecar sockets","pos":"manager.go:86","timestamp":"2023-04-15T21:15:20.912610Z"}
{"component":"virt-launcher","level":"info","msg":"Sorted all collected sidecar sockets per hook point based on their priority and name: map[]","pos":"manager.go:89","timestamp":"2023-04-15T21:15:20.912730Z"}
{"component":"virt-launcher","level":"info","msg":"Connecting to libvirt daemon: qemu+unix:///session?socket=/var/run/libvirt/virtqemud-sock","pos":"libvirt.go:519","timestamp":"2023-04-15T21:15:20.913886Z"}
{"component":"virt-launcher","level":"info","msg":"Connecting to libvirt daemon failed: virError(Code=38, Domain=7, Message='Failed to connect socket to '/var/run/libvirt/virtqemud-sock': No such file or directory')","pos":"libvirt.go:527","timestamp":"2023-04-15T21:15:20.914419Z"}
{"component":"virt-launcher","level":"info","msg":"libvirt version: 9.0.0, package: 3.el9<EMAIL_ADDRESS>2023-02-01-12:58:56, )","subcomponent":"libvirt","thread":"38","timestamp":"2023-04-15T21:15:20.929000Z"}
{"component":"virt-launcher","level":"info","msg":"hostname: testvm","subcomponent":"libvirt","thread":"38","timestamp":"2023-04-15T21:15:20.929000Z"}
{"component":"virt-launcher","level":"error","msg":"Unable to open /dev/kvm: Permission denied","pos":"virHostCPUGetCPUID:1422","subcomponent":"libvirt","thread":"38","timestamp":"2023-04-15T21:15:20.929000Z"}
{"component":"virt-launcher","level":"error","msg":"internal error: Unable to get session bus connection: Cannot spawn a message bus without a machine-id: Unable to load /var/lib/dbus/machine-id or /etc/machine-id: Failed to open file “/var/lib/dbus/machine-id”: No such file or directory","pos":"virGDBusGetSessionBus:126","subcomponent":"libvirt","thread":"38","timestamp":"2023-04-15T21:15:20.929000Z"}
{"component":"virt-launcher","level":"error","msg":"internal error: Unable to get system bus connection: Could not connect: No such file or directory","pos":"virGDBusGetSystemBus:99","subcomponent":"libvirt","thread":"38","timestamp":"2023-04-15T21:15:20.929000Z"}
{"component":"virt-launcher","level":"info","msg":"Connected to libvirt daemon","pos":"libvirt.go:535","timestamp":"2023-04-15T21:15:21.418435Z"}
{"component":"virt-launcher","level":"info","msg":"Registered libvirt event notify callback","pos":"client.go:537","timestamp":"2023-04-15T21:15:21.424911Z"}
{"component":"virt-launcher","level":"info","msg":"Marked as ready","pos":"virt-launcher.go:75","timestamp":"2023-04-15T21:15:21.425563Z"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Executing PreStartHook on VMI pod environment","name":"testvm","namespace":"vcvm","pos":"manager.go:531","timestamp":"2023-04-15T21:15:22.760831Z","uid":"e3a9fb70-273f-4498-8f16-30e1660a6fbe"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Starting PreCloudInitIso hook","name":"testvm","namespace":"vcvm","pos":"manager.go:552","timestamp":"2023-04-15T21:15:22.760942Z","uid":"e3a9fb70-273f-4498-8f16-30e1660a6fbe"}
{"component":"virt-launcher","level":"info","msg":"Found nameservers in /etc/resolv.conf: \n`\u0000\n","pos":"network.go:287","timestamp":"2023-04-15T21:15:22.762410Z"}
{"component":"virt-launcher","level":"info","msg":"Found search domains in /etc/resolv.conf: vcvm.svc.cluster.local svc.cluster.local cluster.local mshome.net","pos":"network.go:288","timestamp":"2023-04-15T21:15:22.763726Z"}
{"component":"virt-launcher","level":"info","msg":"Starting SingleClientDHCPServer","pos":"server.go:65","timestamp":"2023-04-15T21:15:22.764616Z"}
{"component":"virt-launcher","level":"info","msg":"Driver cache mode for /var/run/kubevirt-ephemeral-disks/disk-data/rootfs/disk.qcow2 set to none","pos":"converter.go:452","timestamp":"2023-04-15T21:15:22.815338Z"}
{"component":"virt-launcher","level":"info","msg":"Driver cache mode for /var/run/kubevirt-ephemeral-disks/cloud-init-data/vcvm/testvm/noCloud.iso set to none","pos":"converter.go:452","timestamp":"2023-04-15T21:15:22.824223Z"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Domain XML generated. Base64 dump PGRvbWFpbiB0eXBlPSJrdm0iIHhtbG5zOnFlbXU9Imh0dHA6Ly9saWJ2aXJ0Lm9yZy9zY2hlbWFzL2RvbWFpbi9xZW11LzEuMCI+Cgk8bmFtZT52Y3ZtX3Rlc3R2bTwvbmFtZT4KCTxtZW1vcnkgdW5pdD0iYiI+NjQwMDAwMDA8L21lbW9yeT4KCTxvcz4KCQk8dHlwZSBhcmNoPSJ4ODZfNjQiIG1hY2hpbmU9InEzNSI+aHZtPC90eXBlPgoJCTxzbWJpb3MgbW9kZT0ic3lzaW5mbyI+PC9zbWJpb3M+Cgk8L29zPgoJPHN5c2luZm8gdHlwZT0ic21iaW9zIj4KCQk8c3lzdGVtPgoJCQk8ZW50cnkgbmFtZT0idXVpZCI+NWE5ZmMxODEtOTU3ZS01YzMyLTllNWEtMmRlNWU5NjczNTMxPC9lbnRyeT4KCQkJPGVudHJ5IG5hbWU9Im1hbnVmYWN0dXJlciI+S3ViZVZpcnQ8L2VudHJ5PgoJCQk8ZW50cnkgbmFtZT0iZmFtaWx5Ij5LdWJlVmlydDwvZW50cnk+CgkJCTxlbnRyeSBuYW1lPSJwcm9kdWN0Ij5Ob25lPC9lbnRyeT4KCQkJPGVudHJ5IG5hbWU9InNrdSI+PC9lbnRyeT4KCQkJPGVudHJ5IG5hbWU9InZlcnNpb24iPjwvZW50cnk+CgkJPC9zeXN0ZW0+CgkJPGJpb3M+PC9iaW9zPgoJCTxiYXNlQm9hcmQ+PC9iYXNlQm9hcmQ+CgkJPGNoYXNzaXM+PC9jaGFzc2lzPgoJPC9zeXNpbmZvPgoJPGRldmljZXM+CgkJPGludGVyZmFjZSB0eXBlPSJldGhlcm5ldCI+CgkJCTxzb3VyY2U+PC9zb3VyY2U+CgkJCTx0YXJnZXQgZGV2PSJ0YXAwIiBtYW5hZ2VkPSJubyI+PC90YXJnZXQ+CgkJCTxtb2RlbCB0eXBlPSJ2aXJ0aW8tbm9uLXRyYW5zaXRpb25hbCI+PC9tb2RlbD4KCQkJPG10dSBzaXplPSIxNDUwIj48L210dT4KCQkJPGFsaWFzIG5hbWU9InVhLWRlZmF1bHQiPjwvYWxpYXM+CgkJCTxyb20gZW5hYmxlZD0ibm8iPjwvcm9tPgoJCTwvaW50ZXJmYWNlPgoJCTxjaGFubmVsIHR5cGU9InVuaXgiPgoJCQk8dGFyZ2V0IG5hbWU9Im9yZy5xZW11Lmd1ZXN0X2FnZW50LjAiIHR5cGU9InZpcnRpbyI+PC90YXJnZXQ+CgkJPC9jaGFubmVsPgoJCTxjb250cm9sbGVyIHR5cGU9InVzYiIgaW5kZXg9IjAiIG1vZGVsPSJub25lIj48L2NvbnRyb2xsZXI+CgkJPGNvbnRyb2xsZXIgdHlwZT0ic2NzaSIgaW5kZXg9IjAiIG1vZGVsPSJ2aXJ0aW8tbm9uLXRyYW5zaXRpb25hbCI+PC9jb250cm9sbGVyPgoJCTxjb250cm9sbGVyIHR5cGU9InZpcnRpby1zZXJpYWwiIGluZGV4PSIwIiBtb2RlbD0idmlydGlvLW5vbi10cmFuc2l0aW9uYWwiPjwvY29udHJvbGxlcj4KCQk8dmlkZW8+CgkJCTxtb2RlbCB0eXBlPSJ2Z2EiIGhlYWRzPSIxIiB2cmFtPSIxNjM4NCI+PC9tb2RlbD4KCQk8L3ZpZGVvPgoJCTxncmFwaGljcyB0eXBlPSJ2bmMiPgoJCQk8bGlzdGVuIHR5cGU9InNvY2tldCIgc29ja2V0PSIvdmFyL3J1bi9rdWJldmlydC1wcml2YXRlL2UzYTlmYjcwLTI3M2YtNDQ5OC04ZjE2LTMwZTE2NjBhNmZiZS92aXJ0LXZuYyI+PC9saXN0ZW4+CgkJPC9ncmFwaGljcz4KCQk8bWVtYmFsbG9vbiBtb2RlbD0idmlydGlvLW5vbi10cmFuc2l0aW9uYWwiPgoJCQk8c3RhdHMgcGVyaW9kPSIxMCI+PC9zdGF0cz4KCQk8L21lbWJhbGxvb24+CgkJPGRpc2sgZGV2aWNlPSJkaXNrIiB0eXBlPSJmaWxlIiBtb2RlbD0idmlydGlvLW5vbi10cmFuc2l0aW9uYWwiPgoJCQk8c291cmNlIGZpbGU9Ii92YXIvcnVuL2t1YmV2aXJ0LWVwaGVtZXJhbC1kaXNrcy9kaXNrLWRhdGEvcm9vdGZzL2Rpc2sucWNvdzIiPjwvc291cmNlPgoJCQk8dGFyZ2V0IGJ1cz0idmlydGlvIiBkZXY9InZkYSI+PC90YXJnZXQ+CgkJCTxkcml2ZXIgY2FjaGU9Im5vbmUiIGVycm9yX3BvbGljeT0ic3RvcCIgbmFtZT0icWVtdSIgdHlwZT0icWNvdzIiIGRpc2NhcmQ9InVubWFwIj48L2RyaXZlcj4KCQkJPGFsaWFzIG5hbWU9InVhLXJvb3RmcyI+PC9hbGlhcz4KCQkJPGJhY2tpbmdTdG9yZSB0eXBlPSJmaWxlIj4KCQkJCTxmb3JtYXQgdHlwZT0icWNvdzIiPjwvZm9ybWF0PgoJCQkJPHNvdXJjZSBmaWxlPSIvdmFyL3J1bi9rdWJldmlydC9jb250YWluZXItZGlza3MvZGlza18wLmltZyI+PC9zb3VyY2U+CgkJCTwvYmFja2luZ1N0b3JlPgoJCTwvZGlzaz4KCQk8ZGlzayBkZXZpY2U9ImRpc2siIHR5cGU9ImZpbGUiIG1vZGVsPSJ2aXJ0aW8tbm9uLXRyYW5zaXRpb25hbCI+CgkJCTxzb3VyY2UgZmlsZT0iL3Zhci9ydW4va3ViZXZpcnQtZXBoZW1lcmFsLWRpc2tzL2Nsb3VkLWluaXQtZGF0YS92Y3ZtL3Rlc3R2bS9ub0Nsb3VkLmlzbyI+PC9zb3VyY2U+CgkJCTx0YXJnZXQgYnVzPSJ2aXJ0aW8iIGRldj0idmRiIj48L3RhcmdldD4KCQkJPGRyaXZlciBjYWNoZT0ibm9uZSIgZXJyb3JfcG9saWN5PSJzdG9wIiBuYW1lPSJxZW11IiB0eXBlPSJyYXciIGRpc2NhcmQ9InVubWFwIj48L2RyaXZlcj4KCQkJPGFsaWFzIG5hbWU9InVhLWNsb3VkaW5pdCI+PC9hbGlhcz4KCQk8L2Rpc2s+CgkJPHNlcmlhbCB0eXBlPSJ1bml4Ij4KCQkJPHRhcmdldCBwb3J0PSIwIj48L3RhcmdldD4KCQkJPHNvdXJjZSBtb2RlPSJiaW5kIiBwYXRoPSIvdmFyL3J1bi9rdWJldmlydC1wcml2YXRlL2UzYTlmYjcwLTI3M2YtNDQ5OC04ZjE2LTMwZTE2NjBhNmZiZS92aXJ0LXNlcmlhbDAiPjwvc291cmNlPgoJCTwvc2VyaWFsPgoJCTxjb25zb2xlIHR5cGU9InB0eSI+CgkJCTx0YXJnZXQgdHlwZT0ic2VyaWFsIiBwb3J0PSIwIj48L3RhcmdldD4KCQk8L2NvbnNvbGU+Cgk8L2RldmljZXM+Cgk8bWV0YWRhdGE+CgkJPGt1YmV2aXJ0IHhtbG5zPSJodHRwOi8va3ViZXZpcnQuaW8iPgoJCQk8dWlkPjwvdWlkPgoJCTwva3ViZXZpcnQ+Cgk8L21ldGFkYXRhPgoJPGZlYXR1cmVzPgoJCTxhY3BpPjwvYWNwaT4KCTwvZmVhdHVyZXM+Cgk8Y3B1IG1vZGU9Imhvc3QtbW9kZWwiPgoJCTx0b3BvbG9neSBzb2NrZXRzPSIxIiBjb3Jlcz0iMSIgdGhyZWFkcz0iMSI+PC90b3BvbG9neT4KCTwvY3B1PgoJPHZjcHUgcGxhY2VtZW50PSJzdGF0aWMiPjE8L3ZjcHU+Cgk8aW90aHJlYWRzPjE8L2lvdGhyZWFkcz4KPC9kb21haW4+","name":"testvm","namespace":"vcvm","pos":"libvirt_helper.go:133","timestamp":"2023-04-15T21:15:22.831119Z","uid":"e3a9fb70-273f-4498-8f16-30e1660a6fbe"}
{"component":"virt-launcher-monitor","level":"info","msg":"Reaped pid 57 with status 0","pos":"virt-launcher-monitor.go:120","timestamp":"2023-04-15T21:15:22.875959Z"}
{"component":"virt-launcher-monitor","level":"info","msg":"Reaped pid 59 with status 0","pos":"virt-launcher-monitor.go:120","timestamp":"2023-04-15T21:15:23.017359Z"}
{"component":"virt-launcher-monitor","level":"info","msg":"Reaped pid 65 with status 0","pos":"virt-launcher-monitor.go:120","timestamp":"2023-04-15T21:15:23.238390Z"}
{"component":"virt-launcher-monitor","level":"info","msg":"Reaped pid 67 with status 0","pos":"virt-launcher-monitor.go:120","timestamp":"2023-04-15T21:15:23.275079Z"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Domain defined.","name":"testvm","namespace":"vcvm","pos":"manager.go:882","timestamp":"2023-04-15T21:15:23.508373Z","uid":"e3a9fb70-273f-4498-8f16-30e1660a6fbe"}
{"component":"virt-launcher","level":"info","msg":"DomainLifecycle event 0 with reason 0 received","pos":"client.go:463","timestamp":"2023-04-15T21:15:23.508566Z"}
{"component":"virt-launcher","level":"info","msg":"kubevirt domain status: Shutoff(5):Unknown(0)","pos":"client.go:295","timestamp":"2023-04-15T21:15:23.514736Z"}
{"component":"virt-launcher","level":"info","msg":"Successfully connected to domain notify socket at /var/run/kubevirt/domain-notify-pipe.sock","pos":"client.go:170","timestamp":"2023-04-15T21:15:23.518977Z"}
{"component":"virt-launcher","level":"info","msg":"Domain name event: vcvm_testvm","pos":"client.go:422","timestamp":"2023-04-15T21:15:23.527393Z"}
{"component":"virt-launcher","level":"info","msg":"Monitoring loop: rate 1s start timeout 4m45s","pos":"monitor.go:181","timestamp":"2023-04-15T21:15:23.528600Z"}
{"component":"virt-launcher","level":"info","msg":"generated nocloud iso file /var/run/kubevirt-ephemeral-disks/cloud-init-data/vcvm/testvm/noCloud.iso","pos":"cloud-init.go:675","timestamp":"2023-04-15T21:15:23.637566Z"}
{"component":"virt-launcher","level":"info","msg":"GuestAgentLifecycle event state 2 with reason 1 received","pos":"client.go:520","timestamp":"2023-04-15T21:15:23.759909Z"}
{"component":"virt-launcher","level":"info","msg":"kubevirt domain status: Paused(3):StartingUp(11)","pos":"client.go:295","timestamp":"2023-04-15T21:15:23.763059Z"}
{"component":"virt-launcher","level":"info","msg":"Domain name event: vcvm_testvm","pos":"client.go:422","timestamp":"2023-04-15T21:15:23.765276Z"}
{"component":"virt-launcher","level":"info","msg":"DomainLifecycle event 4 with reason 0 received","pos":"client.go:463","timestamp":"2023-04-15T21:15:24.234938Z"}
{"component":"virt-launcher","level":"info","msg":"DomainLifecycle event 2 with reason 0 received","pos":"client.go:463","timestamp":"2023-04-15T21:15:24.258030Z"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Domain started.","name":"testvm","namespace":"vcvm","pos":"manager.go:910","timestamp":"2023-04-15T21:15:24.269414Z","uid":"e3a9fb70-273f-4498-8f16-30e1660a6fbe"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Synced vmi","name":"testvm","namespace":"vcvm","pos":"server.go:191","timestamp":"2023-04-15T21:15:24.270827Z","uid":"e3a9fb70-273f-4498-8f16-30e1660a6fbe"}
{"component":"virt-launcher","level":"info","msg":"kubevirt domain status: Running(1):Unknown(1)","pos":"client.go:295","timestamp":"2023-04-15T21:15:24.273237Z"}
{"component":"virt-launcher","level":"info","msg":"Domain name event: vcvm_testvm","pos":"client.go:422","timestamp":"2023-04-15T21:15:24.276545Z"}
{"component":"virt-launcher","level":"info","msg":"kubevirt domain status: Running(1):Unknown(1)","pos":"client.go:295","timestamp":"2023-04-15T21:15:24.278526Z"}
{"component":"virt-launcher","level":"info","msg":"Domain name event: vcvm_testvm","pos":"client.go:422","timestamp":"2023-04-15T21:15:24.281265Z"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Synced vmi","name":"testvm","namespace":"vcvm","pos":"server.go:191","timestamp":"2023-04-15T21:15:24.412463Z","uid":"e3a9fb70-273f-4498-8f16-30e1660a6fbe"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Synced vmi","name":"testvm","namespace":"vcvm","pos":"server.go:191","timestamp":"2023-04-15T21:15:24.503800Z","uid":"e3a9fb70-273f-4498-8f16-30e1660a6fbe"}
{"component":"virt-launcher","level":"info","msg":"Found PID for vcvm_testvm: 76","pos":"monitor.go:142","timestamp":"2023-04-15T21:15:24.529239Z"}
{"component":"virt-launcher","kind":"","level":"info","msg":"Synced vmi","name":"testvm","namespace":"vcvm","pos":"server.go:191","timestamp":"2023-04-15T21:15:24.582072Z","uid":"e3a9fb70-273f-4498-8f16-30e1660a6fbe"}

logs from failed instance in vcluster: it seems that the startup process stuck.
{"component":"virt-launcher","level":"info","msg":"Collected all requested hook sidecar sockets","pos":"manager.go:86","timestamp":"2023-04-15T21:26:21.549669Z"}
{"component":"virt-launcher","level":"info","msg":"Sorted all collected sidecar sockets per hook point based on their priority and name: map[]","pos":"manager.go:89","timestamp":"2023-04-15T21:26:21.549819Z"}
{"component":"virt-launcher","level":"info","msg":"Connecting to libvirt daemon: qemu+unix:///session?socket=/var/run/libvirt/virtqemud-sock","pos":"libvirt.go:519","timestamp":"2023-04-15T21:26:21.552033Z"}
{"component":"virt-launcher","level":"info","msg":"Connecting to libvirt daemon failed: virError(Code=38, Domain=7, Message='Failed to connect socket to '/var/run/libvirt/virtqemud-sock': No such file or directory')","pos":"libvirt.go:527","timestamp":"2023-04-15T21:26:21.553860Z"}
{"component":"virt-launcher","level":"info","msg":"libvirt version: 9.0.0, package: 3.el9<EMAIL_ADDRESS>2023-02-01-12:58:56, )","subcomponent":"libvirt","thread":"38","timestamp":"2023-04-15T21:26:21.602000Z"}
{"component":"virt-launcher","level":"info","msg":"hostname: testvm","subcomponent":"libvirt","thread":"38","timestamp":"2023-04-15T21:26:21.602000Z"}
{"component":"virt-launcher","level":"error","msg":"Unable to open /dev/kvm: Permission denied","pos":"virHostCPUGetCPUID:1422","subcomponent":"libvirt","thread":"38","timestamp":"2023-04-15T21:26:21.602000Z"}
{"component":"virt-launcher","level":"error","msg":"internal error: Unable to get session bus connection: Cannot spawn a message bus without a machine-id: Unable to load /var/lib/dbus/machine-id or /etc/machine-id: Failed to open file “/var/lib/dbus/machine-id”: No such file or directory","pos":"virGDBusGetSessionBus:126","subcomponent":"libvirt","thread":"38","timestamp":"2023-04-15T21:26:21.603000Z"}
{"component":"virt-launcher","level":"error","msg":"internal error: Unable to get system bus connection: Could not connect: No such file or directory","pos":"virGDBusGetSystemBus:99","subcomponent":"libvirt","thread":"38","timestamp":"2023-04-15T21:26:21.603000Z"}
{"component":"virt-launcher","level":"info","msg":"Connected to libvirt daemon","pos":"libvirt.go:535","timestamp":"2023-04-15T21:26:22.057647Z"}
{"component":"virt-launcher","level":"info","msg":"Registered libvirt event notify callback","pos":"client.go:537","timestamp":"2023-04-15T21:26:22.096529Z"}
{"component":"virt-launcher","level":"info","msg":"Marked as ready","pos":"virt-launcher.go:75","timestamp":"2023-04-15T21:26:22.100494Z"}

maybe related to this issue https://github.com/kubevirt/kubevirt/issues/8288

On working instance (on host): this path exists: /var/run/kubevirt-ephemeral-disks/disk-data/rootfs/disk.qcow2
On non-working vcluster: this path is empty: /var/run/kubevirt-ephemeral-disks/container-disk-data

/cc @xpivarc
do we expect this to work in hyperv?

maybe related to this issue #8288

Indeed.

do we expect this to work in hyperv?
Sure why not as long as you have nested virt.


Move repository package to internal/repository

Fixes #268

@PiotrLewandowski323 Wow thank you for this change, can you request to be assigned to the ticket here: https://github.com/alpstable/gidari/issues/268 so that I can assign you?

@PiotrLewandowski323 Thank you for your contribution!


SourceAnnotationExtractor moved in edge Rails causing error

Steps to Reproduce

Clone repo: https://github.com/jasnow/show-me-the-food5edge
Run "bundle ; rake" (all green)
Run "bundle update ; rake" and get this error:

Bundler::GemRequireError: There was an error while trying to load the gem 'rspec-rails'.
Gem Load Error is: Rails::SourceAnnotationExtractor is not a class/module
Backtrace for gem load error is:

Think it is caused by this code change:    https://github.com/rails/rails/commit/0ec23effa74e8e9da6ebb14afbd335bea470ab3e
Feel free to add comment for more information if needed.

Rails:   6.0.0.alpha
Ruby:   2.6.0-preview1

Checked today and it affects 4 of my "canary"/edge Rails repos.

The same problem here. Even for all the RSpec stack from the master.

@JonRowe - Is there anything else you need from me regarding this issue?

Try out #1989 and see if that fixes it for you, really someone should tell the Rails team about this too as the intent is to deprecate the class not break it.

I did the following:

Changed Gemfile to use

gem 'rspec-rails', git: 'https://github.com/rspec/rspec-rails'

Ran "bundle update" and got lots of dependency errors.

@JonRowe - Added a comment to Gitter. Can't cut/paste into Google Group and did not yet want to delete rails/rails issue template.

I'm using master branch of Rspec with Rails master and still see this error:
https://travis-ci.org/doorkeeper-gem/doorkeeper/jobs/380759360


test(challenges): Corrected a test case for challenge

Pre-Submission Checklist

[ x] Your pull request targets the staging branch of freeCodeCamp.
[ x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[ x] You have only one commit (if not, squash them into one commit).
[ x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x ] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x ] Tested changes locally.
[ ] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #17134
Description
Issue:
We need to improve tests because if user types props without curly braces it pass the challenge
Your temporary password is: this.props.tempPassword
Solution:
For the last test case in Access Props Using this.props challenge, I updated the test condition to check that the value of the tempPassword prop is the same as the content within the  tags. This test case will ensure that there is text present in the strong tag and its value is as expected.

Incorrectly  created pull request


Feature: implement vRDMA

Recently I was reading up on virtio RDMA (vRDMA) at https://www.mikelangelo-project.eu/technology/vrdma-virtio-remote-direct-memory-access/, and this seems like an interesting feature to have.

I suspect implementing NDK support is the first step towards this, see https://docs.microsoft.com/en-us/windows-hardware/drivers/network/initializing-an-ndk-capable-miniport-driver.

Yes, I thought about support NDK yesterday.
I will see how we can build a roadmap for the support of those features.

virtio-rdma was removed from QEMU. Closing for now.


ESLint and Vetur integration

Feature request

[ ] Linting for config files
[ ] Vetur autocompletions and templates for the customized Vue parts (like export const data = {})

What problem does this feature solve?
Developer experience++
What does the proposed API look like?
How should this be implemented in your opinion?
Let's just look at Gridsome and how they've done it :eyes:
Are you willing to work on this yourself?
Yes.

Linting for config files

Do you really need that? Now you can use TypeScript:
// @ts-check

/** @type {import('saber').SaberConfig} */
const config = {
  foo: true // type error
}

module.exports.config

@egoist It'd be cool if that would be applied automatically. Necessary? No :smile:


[Autocomplete] Only activate clear button plugin when there is a placeholder option

Q
A

Bug fix?
yes

New feature?
maybe?

Issues
Fix #402

License
MIT

Only add the clear_button plugin to TomSelect if the form element has no placeholder option.
Notes:

I defined 'having a placeholder' as the select having an option with an empty value, as that is what TomSelect also seems to do
I'm not 100% sure about whether this needs a test or how to even run tests locally

Form the monorepository root
Install dependencies
yarn install

Code style
yarn run lint
yarn run format

Run Tests
yarn run test

Build dist packages
yarn run test

(you need to commit both src/Autocomplete/assets/src/** and src/Autocomplete/assets/dist/** files in this PR)
Please ask if you want/need anymore information :)


Error when starting bot

I get this error:
`pi@himbeere:~/vreddit-download-bot $ python3 -i bot.py
Authenticating...
Traceback (most recent call last):
File "/usr/lib/python3.7/configparser.py", line 845, in items
d.update(self._sections[section])
KeyError: 'vreddit'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "bot.py", line 272, in
main()
File "bot.py", line 29, in main
reddit = authenticate()
File "bot.py", line 102, in authenticate
reddit = praw.Reddit('vreddit', user_agent='vreddit')
File "/home/pi/.local/lib/python3.7/site-packages/praw/reddit.py", line 189, in init
config_section, config_interpolation, **config_settings
File "/home/pi/.local/lib/python3.7/site-packages/praw/config.py", line 82, in init
self.custom = dict(Config.CONFIG.items(site_name), **settings)
File "/usr/lib/python3.7/configparser.py", line 848, in items
raise NoSectionError(section)
configparser.NoSectionError: No section: 'vreddit'
You provided the name of a praw.ini configuration which does not exist.
For help with creating a Reddit instance, visit
https://praw.readthedocs.io/en/latest/code_overview/reddit_instance.html
For help on configuring PRAW, visit
https://praw.readthedocs.io/en/latest/getting_started/configuration.html

`

Is this a error on my site?

You need to fill in your own bot information in the praw.ini file. In my case, I identify my bot as 'vreddit', while in your case, you need to choose an own identifier instead of 'ExampleBot'.

Which kind of app do I have to create on reddit? I put everything is needed.
I still don't understand what you are meaning with authenticate()

Send me a message on Discord to Marvin#7307 and I'll explain the details


Missing lab folder

A bunch of code has been removed from the project that was living in /lab - where has this moved to?

The old site is here: https://github.com/Code4SA/old-code4sa.github.io


Cluster version controller code restructering

Seperate the different reconcile concerns into functions
Preload all input resources
Optimize memory managemnt for console resources
Add reconsole tracking log messages
Fix some issues with object metadata overwrites

@nb-ohad

#107 introduced a bug wherein ceph deploy & ds .spec.template.metadata.labels are missed during refactor which kinda makes current main undeployable

2024-03-15T03:27:04Z    ERROR   Reconciler error        {"controller": "clusterversion", "controllerGroup": "config.openshift.io", "controllerKind": "ClusterVersion", "ClusterVersion": {"name":"version"}, "namespace": "", "name": "version", "reconcileID": "4c22d638-60c8-40c0-9855-2ae425f8cb09", "error": "Deployment.apps \"csi-cephfsplugin-provisioner\" is invalid: spec.template.metadata.labels: Invalid value: map[string]string(nil): `selector` does not match template `labels`"}

w/ current PR I see codepath in point 1 isn't hit (or at-least I don't see any logs) at all which is more puzzling and a new error in the log appeared

2024-03-15T03:33:03Z    INFO    Starting reconciliation {"controller": "clusterversion", "controllerGroup": "config.openshift.io", "controllerKind": "ClusterVersion", "ClusterVersion": {"name":"version"}, "namespace": "", "name": "version", "reconcileID": "7cc80ef1-57e4-4a1d-b7e2-75aead0b1854", "ClusterVersion": {"name":"version"}}
2024-03-15T03:33:03Z    INFO    Reconciling NginxConfigMap      {"controller": "clusterversion", "controllerGroup": "config.openshift.io", "controllerKind": "ClusterVersion", "ClusterVersion": {"name":"version"}, "namespace": "", "name": "version", "reconcileID": "7cc80ef1-57e4-4a1d-b7e2-75aead0b1854", "ClusterVersion": {"name":"version"}}
2024-03-15T03:33:03Z    ERROR   failed to create nginx config map       {"controller": "clusterversion", "controllerGroup": "config.openshift.io", "controllerKind": "ClusterVersion", "ClusterVersion": {"name":"version"}, "namespace": "", "name": "version", "reconcileID": "7cc80ef1-57e4-4a1d-b7e2-75aead0b1854", "ClusterVersion": {"name":"version"}, "error": "Object openshift-storage-client/ocs-client-operator-console-nginx-conf is already owned by another Deployment controller ocs-client-operator-console"}
github.com/red-hat-storage/ocs-client-operator/controllers.(*ClusterVersionReconciler).reconcileNginxConfigMap
        /workspace/controllers/clusterversion_controller.go:231
github.com/red-hat-storage/ocs-client-operator/controllers.(*ClusterVersionReconciler).reconcilPhases
        /workspace/controllers/clusterversion_controller.go:165
github.com/red-hat-storage/ocs-client-operator/controllers.(*ClusterVersionReconciler).Reconcile
        /workspace/controllers/clusterversion_controller.go:153
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
        /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:119
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
        /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:316
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
        /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
        /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227
2024-03-15T03:33:03Z    INFO    Reconciliation completed successfully   {"controller": "clusterversion", "controllerGroup": "config.openshift.io", "controllerKind": "ClusterVersion", "ClusterVersion": {"name":"version"}, "namespace": "", "name": "version", "reconcileID": "7cc80ef1-57e4-4a1d-b7e2-75aead0b1854", "ClusterVersion": {"name":"version"}}
2024-03-15T03:33:03Z    INFO    Reconciling StorageClassClaim.  {"controller": "storageclassclaim", "controllerGroup": "ocs.openshift.io", "controllerKind": "StorageClassClaim", "StorageClassClaim": {"name":"ocs-storagecluster-cephfs"}, "namespace": "", "name": "ocs-storagecluster-cephfs", "reconcileID": "bb5c50e1-fe1b-444d-a21b-5c819d968ad6", "StorageClassClaim": {"name":"ocs-storagecluster-cephfs"}}

I think we really need a deployment test suite, can we make an effort to have client operator be able to run on plain k8s which can help a bit better?
Regarding point 1, I'll be raising a new PR to fix that specific issue.

@nb-ohad will you be refreshing this PR?

@nb-ohad will you be refreshing this PR?

@leelavg I am not sure I will do that as the changes to the code base are considerable. I might decide on an alternative of recoding these changes from the ground up on top of the current main. Either way, this work will get into the repo at one point or another.


Relative paths to sources are not set correctly

Poedit <IP_ADDRESS>
When I create a new po file the program asks me to save it before I can add sources.
I save it to

/var/www/project/wp-content/themes/minima-lite/langs

After saving base bath is set to the path po file is located in.
When I try to add

/var/www/project/wp-content/themes/minima-lite/

as a source folder therelative  path becomes '.' but it should be '../'
The only way to fix it is to add any subfolder like

/var/www/project/wp-content/themes/minima-lite/subfolder

so it changes the base path and relatives paths become correct

The latest version is 2.0.3. Even in 1.8 series, the latest is not .7, but .13. Please don't waste developers' time by submitting bug reports against ancient versions and always verify in the latest version first.
That said, relative paths of course do work correctly. You didn't provide any reproduction instructions that could be followed, so I can only guess this is some confusion on your part. If you believe otherwise, please provide actual description of the problem (your description is very confusing and unclear) reproduction instructions, with actual files. Please read this first too.

The latest version is ....
For the user the lates version is a version from their repository usually. Github threads often appears as Google search results - so that hack I found may save someone's time.

For the user the lates version is a version from their repository usually.

If you're too entitled to follow normal OSS practices, then file bug report with your distribution (none of which ship this old version in their respective current versions either). Your expectation that upstream will provide you with free support for years old versions is quite simply unreasonable.

so that hack I found may save someone's time.

You didn't describe any hack and this confusingly (non)described issue is certainly not going to help anyone — on the contrary.


Added count to options (#19)

what

Added count to accepter and requester options to prevent them from being created when enabled is false.

why

When enabled is false count is set to 0 and is used to skip most resources except these two options. When these options aren't skipped the module fails.

references

closes #19

I added a fix found for a related issue I explained in #19 which only effected Terraform 0.12.11+

@JamesTimms Can you fix your conflict?

/test all

@Gowiem I've merged master but saw someone made a similar fix to one of the issues using try(). So I've changed my fix to use try() instead of length() and a ternary. It seems to work fine for me as long as I'm on a version on Terraform that supports try().

/test all

@nitrocode & @Gowiem is this ok to merge now or do you need a few more changes?

@JamesTimms  thanks for the PR.
Looks like in the final version you removed count  = local.count and the final changes are not reflected in the PR description.
I think the count needs to be added anyway to prevent the resources from being created when enabled=false.
You final changes are ok, they make TF to not throw errors when data.aws_subnet_ids.accepter.*.ids does not exist.
Please update.

@aknysh,
I think someone added the count into a different PR that's made its way into master as the count is still there but not showing up in the diff.
Which lines exactly do you think I've removed count from? The commit here, shows me adding them but then looking at the files (here and here) you can see they're still there despite not showing up in the diff.

Is this likely to get merged?

@aknysh I think the count change is not showing in this PR because it was added here: https://github.com/cloudposse/terraform-aws-vpc-peering-multi-account/commit/071e574b62abb4bf9c20820c114096cf25b5cc9e
@JamesTimms given the above, maybe good to update the PR description to match the remaining changes in this PR.

@aknysh I think the count change is not showing in this PR because it was added here: 071e574
@JamesTimms given the above, maybe good to update the PR description to match the remaining changes in this PR.

Agree with @joe-niland , please update the PR description

@JamesTimms thanks again, just a few nitpicks

I've updated to use empty arrays, including a related change that got into master via some other change. Let me know if this is good enough to merge!

/test all

/test all

/rebuild-readme

/test all

Thanks for your contribution @JamesTimms !


Allow change of font size in a text run

Could be tied to eg ** bracket - or else <span> `class attribute.

Going with <span> and style.fontsize. - in both cases specifying px as the unit of measure.
Coded, awaiting documentation.

Shipped in v4.5.