Some urls are incorrect/invalid, in License header.

in starrocks source files' License header, these urls can not reach.
https://github.com/apache/incubator-doris/blob/master/be/src/util/memcmp.h
https://github.com/apache/incubator-doris/blob/master/be/src/util/starrocks_metrics.cpp
https://github.com/apache/incubator-doris/blob/master/be/src/util/bit_packing.inline.h
https://github.com/apache/incubator-doris/blob/master/be/src/util/template_util.h

https://github.com/apache/incubator-doris/blob/master/be/src/exprs/base64.h
https://github.com/apache/incubator-doris/blob/master/be/src/exprs/base64.cpp

https://github.com/apache/incubator-doris/blob/master/be/src/runtime/date_value.h
https://github.com/apache/incubator-doris/blob/master/be/src/runtime/date_value.cpp
https://github.com/apache/incubator-doris/blob/master/be/src/runtime/decimal_value.h
https://github.com/apache/incubator-doris/blob/master/be/src/runtime/decimal_value.cpp
https://github.com/apache/incubator-doris/blob/master/be/src/runtime/timestamp_value.h
https://github.com/apache/incubator-doris/blob/master/be/src/runtime/timestamp_value.cpp

https://github.com/apache/incubator-doris/blob/master/be/src/runtime/data_stream_recvr.hpp

https://github.com/apache/incubator-doris/blob/master/be/src/http/monitor_action.h
https://github.com/apache/incubator-doris/blob/master/be/src/http/monitor_action.cpp
https://github.com/apache/incubator-doris/blob/master/be/src/http/download_action.h
https://github.com/apache/incubator-doris/blob/master/be/src/http/download_action.cpp
https://github.com/apache/incubator-doris/blob/master/be/src/http/action/update_config_action.h
https://github.com/apache/incubator-doris/blob/master/be/src/http/action/update_config_action.cpp

https://github.com/apache/incubator-doris/blob/master/be/src/testutil/init_config.h

https://github.com/apache/incubator-doris/blob/master/be/src/olap/rowset/bitmap_range_iterator.h
https://github.com/apache/incubator-doris/blob/master/be/src/olap/rowset/segment_v2/parsed_page.cpp
https://github.com/apache/incubator-doris/blob/master/be/src/olap/collection.h
https://github.com/apache/incubator-doris/blob/master/be/src/olap/decimal12.cpp
https://github.com/apache/incubator-doris/blob/master/be/src/olap/delete_condition.h

https://github.com/apache/incubator-doris/blob/master/be/src/simd/simd.h
https://github.com/apache/incubator-doris/blob/master/be/src/simd/simd.cpp

https://github.com/apache/incubator-doris/blob/master/be/test/runtime/int128_arithmetic_ops_test.cpp

https://github.com/apache/incubator-doris/blob/master/be/test/column/avx_numeric_column_test.cpp
https://github.com/apache/incubator-doris/blob/master/be/test/column/binary_column_test.cpp
https://github.com/apache/incubator-doris/blob/master/be/test/column/date_value_test.cpp
https://github.com/apache/incubator-doris/blob/master/be/test/column/column_helper_test.cpp
https://github.com/apache/incubator-doris/blob/master/be/test/column/object_column_test.cpp
https://github.com/apache/incubator-doris/blob/master/be/test/column/fixed_length_column_test.cpp
https://github.com/apache/incubator-doris/blob/master/be/test/column/const_column_test.cpp
https://github.com/apache/incubator-doris/blob/master/be/test/column/field_test.cpp
https://github.com/apache/incubator-doris/blob/master/be/test/column/vectorized_schema_test.cpp
https://github.com/apache/incubator-doris/blob/master/be/test/column/timestamp_value_test.cpp
https://github.com/apache/incubator-doris/blob/master/be/test/column/column_pool_test.cpp
https://github.com/apache/incubator-doris/blob/master/be/test/column/avx_numeric_column.h
https://github.com/apache/incubator-doris/blob/master/be/test/column/chunk_test.cpp

https://github.com/apache/incubator-doris/blob/master/be/test/olap/del_vector_test.cpp

https://github.com/apache/incubator-doris/blob/master/be/test/simd/simd_test.cpp

https://github.com/apache/incubator-doris/blob/master/gensrc/proto/palo_internal_service.proto
https://github.com/apache/incubator-doris/blob/master/gensrc/thrift/parquet.thrift
https://github.com/apache/incubator-doris/blob/master/gensrc/thrift/InternalService.thrift

https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/planner/FileScanNode.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/sql/optimizer/rewrite/ScalarOperatorFunctions.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/analysis/ArrayExpr.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/analysis/ArrayElementExpr.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/analysis/ArraySliceExpr.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnSeparator.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/analysis/SingleRangePartitionDesc.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/analysis/MVColumnPercentileUnionPattern.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/analysis/ShowMaterializedViewStmt.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Auth.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Role.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Privilege.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/mysql/MysqlChangeUserPacket.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/rewrite/mvrewrite/PercentileApproxToUnionRule.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/StarRocksFE.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/rpc/PBackendService.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/rpc/PFetchDataRequest.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/rpc/PExecPlanFragmentRequest.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/rpc/ThriftClientAttachmentHandler.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/rpc/PTriggerProfileReportRequest.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/load/loadv2/LoadTimeoutChecker.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/load/MultiDeleteInfo.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/catalog/PseudoType.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/catalog/AnyElementType.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/catalog/AnyArrayType.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/http/common/StarRocksHttpPostObjectAggregator.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/metric/StarRocksMetricRegistry.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/common/io/FastByteArrayInputStream.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/common/io/Text.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/common/io/DeepCopy.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/common/io/IOUtils.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/common/io/FastByteArrayOutputStream.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/common/io/DataOutputBuffer.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/common/io/Writable.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/common/proc/ClusterLoadStatByMedium.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/common/StarRocksHttpException.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/clone/ColocateTableBalancer.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/transaction/UpdateDbUsedDataQuotaDaemon.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/external/hive/HiveMetaStoreThriftClient.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/meta/MetaContext.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/test/java/org/apache/doris/sql/optimizer/MVRewriteTest.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/test/java/org/apache/doris/analysis/ColumnSeparatorTest.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/test/java/org/apache/doris/analysis/RowDelimiterTest.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/test/java/org/apache/doris/analysis/ShowMaterializedViewTest.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/test/java/org/apache/doris/mysql/MysqlChangeUserPacketTest.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/test/java/org/apache/doris/load/loadv2/LoadingTaskPlannerTest.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/test/java/org/apache/doris/catalog/TypeTest.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/test/java/org/apache/doris/http/StarRocksHttpTestCase.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/test/java/org/apache/doris/utframe/StarRocksAssert.java
https://github.com/apache/incubator-doris/blob/master/fe/fe-core/src/test/java/org/apache/doris/clone/ColocateTableBalancerTest.java

https://github.com/apache/incubator-doris/blob/master/fs_brokers/apache_hdfs_broker/src/test/java/org/apache/doris/broker/hdfs/WildcardURITest.java
https://github.com/apache/incubator-doris/blob/master/fs_brokers/apache_hdfs_broker/src/test/java/com/starrocks/broker/hdfs/TestFileSystemManager.java
https://github.com/apache/incubator-doris/blob/master/fs_brokers/apache_hdfs_broker/src/test/java/com/starrocks/broker/hdfs/TestHDFSBrokerService.java

several causes:

not from incubator-doris, added newly by starrocks
from incubator-doris, but incubator-doris delete it
from incubator-doris, but filename changed, eg, doris_metrics.cpp changed to starrocks_metrics.cpp
for 1, should change the License to StarRocks itself, for 3, should rename to it's original

welcome volunteers to resolve this issue.

check-urls.txt
check-urls.sh.txt
pure-urls.txt
urls.txt


Progress is not working

I see 1% and then there is no indication of file being uploaded. After few sec the file gets uploaded. Even the progress indicator is not working in the demos.

Yes, there are some issues with upload server.

Also having this issue when I was still in RC4. I thought it will be resolved by upgrading to Angular 2 Final 2.0.1, but still having the error.
I added a console.log on first line of handleUpload function and found out that data.progress.percent is immediately set to 100. On second check, it stays at 100, even the image was already uploaded.

I was wondering if the progress indicator can work with a PHP upload file?

Finally I can confirm this is working with a PHP upload, but the example in doc was wrong!
I had to change this code:
handleUpload(data: any): void {
    this.zone.run(() => {
      this.response = data;
      this.progress = Math.floor(data.progress.percent / 100);
    });
  }

by simply this:
handleUpload(data: any): void {
        this.zone.run(() => {
            this.response = data;
            this.progress = data.progress.percent; //no need to divide by 100 anymore!
        });
        if (data && data.response) {
            data = JSON.parse(data.response);
        }
    }

Hope this helps.


MusicXML: Import  element

This PR imports the <defaults> element, with the exception of the <concert-score> element, useless for now, and the <appearance> values, also useless for now and because importing them will require to make engraving options not constant and this is not an urgent change.
The main achievements with this PR are:

Page size and margins are now imported and taken into account.
System and staves distance and margins are also imported and taken into account. But, for distances (not for margins), the imported values could be overridden by the layout algorithm if more space was required.
Font for words is now imported and used for texts.
Font for lyrics and language for lyrics is now imported and used for lyric lines.
Font for music is also imported but it is useless as Lomse will, for now, continue using Bravura font.

Imported scores should now properly display lyric lines when using non-Latin languages. For instance, test score
Echigo-Jishi.musicxml.txt from MusicXML test set:
Lomse, before this PR:

Lomse, after this PR:

This PR also:

Adds method ImoScore::tenths_to_logical(Tenths value) to provide tenths to LUnits conversion when tenths not referred to an staff. This method will, perhaps in future, replace current method for conversion when no staff involved.
Paper size and related methods has been removed from ImoScore. They were here by historical reasons but were not used.
Lomse used a model with three values: left margin, right margin and binding margin. But MusicXML, instead of using a common binding margin, uses a model with four independent values. Also for top and bottom margins MusicXML allows to specify different values for odd and even pages. As MusicXML model is more flexible, and to fully support MusicXML, the Lomse internal model has been changed. Therefore, this PR introduces some backward incompatible changes in Document API: the methods for defining margins have been split into two groups: one for even pages and one for odd pages:

//Before this PR:
LUnits page_left_margin() const;
LUnits page_right_margin() const;
LUnits page_top_margin() const;
LUnits page_bottom_margin() const;
void set_page_left_margin(LUnits value);
void set_page_right_margin(LUnits value);
void set_page_top_margin(LUnits value);
void set_page_bottom_margin(LUnits value);

//After this PR:
    //odd pages
LUnits page_left_margin_odd() const;
LUnits page_right_margin_odd() const;
LUnits page_top_margin_odd() const;
LUnits page_bottom_margin_odd() const;
void set_page_left_margin_odd(LUnits value);
void set_page_right_margin_odd(LUnits value);
void set_page_top_margin_odd(LUnits value);
void set_page_bottom_margin_odd(LUnits value);
    //even pages
LUnits page_left_margin_even() const;
LUnits page_right_margin_even() const;
LUnits page_top_margin_even() const;
LUnits page_bottom_margin_even() const;
void set_page_left_margin_even(LUnits value);
void set_page_right_margin_even(LUnits value);
void set_page_top_margin_even(LUnits value);
void set_page_bottom_margin_even(LUnits value);

@dmitrio95 Probably you have some MusicXML samples with texts and lyrics in Russian language. If so and it is possible for you, I would appreciate if you could send me a couple of samples, for testing and reference, by PM if you prefer. Thank you!

Sure, I have sent you some sample scores by e-mail.


fix: using let instead of var and all var declarations at top

Description
Fixes #7941
Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

I have made the required changes. Please review them


Update AutoRest C# version

Update AutoRest C# version to 1.0.0-alpha.20201113.1

I'll make the change in my PR.


clusterctl support

This provides support for clusterctl in two ways.
First, it properly structures it so you can run clusterctl --config=... to initialize the Packet provider. It did work before, but there were elements missing. This completes it so that it works. As part of it, it needed to change some of how the templates are generated to ./out/.
Second, it adds support for the cluster template in the right directories in ./out/. This means that generate-example.sh is no longer relevant, although it uses the same source template. This now is pushed into the correct ./out/ directories, where clusterctl can consume them.
Since clusterctl config cluster does not (yet) support defaults - every env var must be set for it to work - this repurposes generate-example.sh to generate-cluster.sh, which wraps clusterctl but sets defaults for env vars that should support them (as it did before when it was generate-example.sh). Also moved that to ./scripts/ to keep it clean and consistent.
Other things had to be improved to make it work, for example adding the correct Secret to run the manager as part of make release (it isn't needed in managerless, since we run it locally).
All of the docs relating to it have been updated as well, as have Makefile targets.
There are a few things that still do not work or require fixing once this PR is in, but should be handled as separate steps.

Our cluster template requires PACKET_API_KEY as part of its template, so that the CCM deployment will work correctly. Cluster templates are not supposed to have secrets. Even though we had it in v1alpha1, and this is a carryover, this requires us to clean it up. We need to find a way to get the secret across from the initializer in the management cluster. I have some ideas; we can follow through later.
The actual clusterctl --config= command - both in the README and in make cluster - does not work because it references the URL https://github.com/packethost/cluster-api-provider-packet/releases/latest/`, but we haven't actually released the config file there yet. That will continue to be the case until we cut a release.

We need to find a way to get the secret across from the initializer in the management cluster. I have some ideas; we can follow through later.

we should probably do something like kube2iam ideally https://github.com/jtblin/kube2iam
Thanks great!

What about moving what there is in the readme

I am up for that. Let's do that as a separate "no code change" PR.


does evil twin works as this ?

[+] Evil Twin - Creates a Fake Access Point, Clients Connect to Divulging MSCHAP Hashes or Cleartext Passwords
Stealing 802.1x Credentials with Rogue AP & RADIUS server

The youtube link is broken. But please check out https://m.youtube.com/watch?v=AeqfYGbHwWw

@Tylous
i don't know what broke it ...
but here is it
https://youtu.be/HoihKhQWZ7k

@Tylous
https://youtu.be/AeqfYGbHwWw?t=2243
but this works on ios only ? as android needs to set the configuration (GTC) manually !

No it works on Android as well.


Skeleton: as property

Description
Skeleton component should support the as property (as is with https://github.com/nuxt/ui/blob/dev/src/runtime/components/layout/Container.vue#L22C3-L26C7).
Additional context
See #1813

I will post a PR about this


Tests which use set_output_to to redirect output may not run correctly on AzureML runs

Because of the way DeepLearningFileSystemConfig.create() is written, set_output_to has no effect in AzureML runs. Tests end up writing to the same output_dir which means tests may see old files from other tests.

Fixed in #323. set_output_to will have an effect in AzureML runs as well.

Fixed in #323. set_output_to will have an effect in AzureML runs as well.


Button hot state is not properly shown for children of Scroll

This can be seen with the list example, especially if the debug_paint_layout is turned off. Hover over a button and then scroll a bit. The button should no longer have a white border but it does.

I've just come across this problem. Repro example below.
use druid::widget::{List, Scroll, Switch, WidgetExt};
use druid::{AppLauncher, Widget, WindowDesc};
use im::{vector, Vector};

fn build_widget() -> impl Widget<Vector<bool>> {
    Scroll::new(List::new(|| Switch::new())).vertical().center()
}

pub fn main() {
    let window = WindowDesc::new(build_widget).title("Scroll evt error");
    AppLauncher::with_window(window)
        .use_simple_logger()
        .launch(vector![false])
        .expect("launch failed");
}

I'm doing a stream of consciousness at https://xi.zulipchat.com/#narrow/stream/255910-druid-help/topic/Event.20for.20window.20lost.20focus


Add information on how to use animations

Add information on how to use animations. List available classes.

:ship: :it: :grey_exclamation:
Ship it


Aqara Shade Driver E1 not reporting battery level in SmartThings (Xiaomi/Aqara Blinds 1.2)

Hello,
I'm keep to assist with troubleshooting this and obtaining logs necessary.
Please let me know what is needed.
Thanks,
Vas

Hi, if I recall correctly, older Aqara (lumi) devices use a custom cluster to report battery status and signal strength. Typically, this message is sent when there’s a significant change or when the user presses a physical button.
However, in my experience, the battery percentage reported by the device is not very accurate. It usually only indicates high, medium, or low battery levels.

I pressed the physical buttons a few times, but still no battery information shown. Not a big issue, but it's slightly annoying to see the notification from SmartThings app saying that not all attributes are available yet.


⚠ SpeakUpConference.com has degraded performance

In 15df58f, SpeakUpConference.com (https://www.speakupconference.com) experienced degraded performance:

HTTP code: 200
Response time: 20839 ms

Resolved: SpeakUpConference.com performance has improved in ffb3976 after 2 hours, 18 minutes.


Adrianbranch

Added new guide "data_engineering_with_apache_airflow"

Hi jason, I have rebased my branch to the original. The sample md is as per what is current is in the original SF guides here: https://github.com/Snowflake-Labs/sfquickstarts . It is on my adrianbranch already. Do let me know if there is anything else to be done. Thank you!


Add support for specifying a service provider

Hi,
If a validator needs the service provider inside the validation context, there is currently no way to pass it when calling TryValidateObject. I am sending a pull request to add it as an extra parameter that defaults to null.

Well, actually, the parameter also needs to be passed around in the subsequent methods... Forgot to do it as I submitted directly from GitHub's code editor. Should be an easy change though.


Restore updates made to the batch endpoint text section

Restored updates that were previously made to the batch endpoint section.

Discussed on May 27 2021 call, consensus was to - 1) let's change the endpoint back to /edvs/<id>/batch, 2) add an issue marker to revisit the operation syntax, and 3) merge the PR.

@dmitrizagidulin @msporny Done!

Thanks @DRK3! Merging.


DBZ-1935 fixed broken links and anchors

https://issues.redhat.com/browse/DBZ-1935
also added .asciidoctorconfig for improved preview and validation.
If you think the contents of .asciidoctorconfig should be in antora.yml, please let me know and I'll move them.
I've used the latest preview version 0.30.51 of the AsciiDoc IntelliJ plugin to run "Analyze | Inspect code..." with all AsciiDoc validations. With these changes it doesn't show any errors.
All links are fixed to my best knowledge, let me know if any more fix-ups are required.

If you think the contents of .asciidoctorconfig should be in antora.yml, please let me know and I'll move them

So where is .asciidoctorconfig applied? Also during the Antora build? Or only in the IntelliJ preview? I general, I'd prefer to minimize the number of configuration files as much as possible, as it's quite tricky (already) to understand which is applied where and when.

@gunnarmorling TL;DR: I removed the .asciidoctorconfig and fixed some more anchors. Please re-review.
The .asciidoctorconfig is only for the preview in IntelliJ. You can use it to provide attributes that are only present in the Antora playbook.
I added it assuming that the automatically created anchors in two places (snapshots and topic-names) would require it.
Looking closer, I found that these two attributes aren't set in the playbook, therefore the production site renders the links with the AsciiDoc defaults (that are: underscores).
I removed .asciidoctorconfig (as it is no longer needed) and adjusted the broken anchors.

I assume "these two" apply to oracle.adoc and db2.adoc.

Yes, exactly.

What I did here: fix the broken anchors by pointing to the most appropriate existing anchor ID. What I didn't do: restructure/rename anchor IDs.

Ok, gotcha. Thanks for clarifying. So uniqueness within each connector documentation should be enough, we don't create one large document with all the documentation at once. Indeed I think the slight inconsistency originates from downstream work, as the docs team has added the prefix to those files which feed into the downstream product.
I.e. all good, thanks a lot again!


Add missing 'testCaseID' property to Event.Snapshot

Add a testCaseID property to Event.Snapshot, similar to testID. It was an oversight when adding the Test.Case.ID type to not add it to Event.Snapshot when it was added to Event.
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

Resolves rdar://124184583

@swift-ci please test


ocaml indent

 print_string "Hello World\ "   hello.ml2:1 LFUTF-8OCaml Failed to spawn command ocp-indent. Make sure ocp-indent is installed and on your PATH.

I keep getting this error when trying to type code in atom. Could you help me with the remedy?

You should have ocp-indent installed, and available in your path. If that's the case, try opening atom from the command line.


Failed to install

./configre not found

Oops.  Looks like the README was missing the important ./bootstrap call prior to a ./configure.
I have amended the README; you should be running this:
./bootstrap && \
./configure && \
make && \
sudo make install

My apologies!


check for password during update public link

Bugfix: Fix public links with enforced password
Fix the public link update operation in the case that a password is enforced.

confused

I was too at the beginning. Let me explain.
From the backend side, things always look different.
In the web frontend you have the following situation:

You create a link. During that, you cannot specify permissions, it just uses the default and no password
You want to change the permissions to "Editor". Now the Frontend side validation kicks in ans says: "hey, that doesn't work without a password!" and prompts a password. You  provide one and violà, we have a request that updates the permissions and the password together. IMO this makes sense.


STXM-17: Unnecessary line feeds

To see the PR without whitespace changes, check   https://github.com/jbossas/staxmapper/pull/5/files?w=1
Some of the changes look reasonable but some look questionable. I'm not a committer here, though, so I have no power of approval.

I've cleaned up all of the extra "stuff" and just retained (and rebased) the core piece that was originally described by the JIRA.


encoding/json: SyntaxError message change breaks brittle tests

The change for #36221 adds a json:  prefix to SyntaxError, which breaks >50 targets for the regression tests we run inside Google.
Thoughts:

Relying on the error message is to rely on unspecified behavior and is generally considered outside the Go 1 compatibility promise. The json package theoretically has the right to change error messages.
At the same time 50 targets is a non-trivial number of breakages. Fortunately they are all test failures (from my high-level glance).
If we're going to cause churn with a changed error message, should we also consider whether SyntaxError.Offset should be part of the error message string? Why or why not?
Should we batch changes like this for the future where we may want to introduce other changes to json that are technically compliant with the Go 1 compatibility promise, but may be slightly disruptive? Presumably it's better to break brittle targets once, rather than repeatedly.

Filing this issue to decide whether we're sure we want to move forward with this change.
\cc @mvdan @kevinburke @rsc

Presumably it's better to break brittle targets once, rather than repeatedly.

I agree. Do we have more suggestions, though?

whether SyntaxError.Offset should be part of the error message string?

That could be a good idea, but how would you render it in the string? If you use ${offset}: ${message}, I think most people will incorrectly read the number as a line number and not a byte offset. We could go for ${message} at byte offset ${offset}, but it feels too wordy.
Another reason not to do it is that, right now, Error() is the only way to obtain just the message string. It might need to be coupled with exporting the msg string field.

At the same time 50 targets is a non-trivial number of breakages.

At this point I've learned to not try to argue with test breakages :)

Yikes. I did try to search on Github for code snippets that this change could break, but that search wasn't exhaustive and probably Google writes better tests.
I think backing this change out is the right thing to do.

To be clear, these tests are brittle and shouldn't depend on the exact text of stdlib errors. We're fine with dealing with it internally. However, 50 tests is more than we usually see break from a changed error message, which might point at this having more impact than expected in the ecosystem at large.

Looking at things like the mod_proxy_invalid.txt message, I think leaving the prefix out makes a lot of sense. Let's just revert it please. What's done is done.

I think leaving the prefix out makes a lot of sense

A bigger discussion, I guess, but if it doesn't make sense to prepend the package name prefix in this case, I'm wondering why we have this convention in the standard library at all. I've noticed it's funky to expose Go errors to frontend clients in a browser UI context.

@kevinburke, yes, in general I think that rule is clearly not something to apply 100% of the time.
io.EOF is "EOF" not "io: EOF". And os.Open("nonexist") returns an error that says "open nonexist: file does not exist", not "os: open nonexist: syscall: file does not exist".

@rsc, I would expect the rule to at least be consistent within a package. All other errors within the json package have a json:  prefix.


Filter aeolus by country

Someone on reddit was looking for duch people fin a certain rating range to play with on faf.
I answered that he could filter aeolus by rating :

(Which I discovered on the spot and thought was really cool!)
And i said for the dutch nationality he could just run through the list he gets and pm those with a dutch flag.
That seemed to me like an underwhelming answer.
I feel like being able to filter by country would be a nice addition!  :)

Created a pull request for this:
https://github.com/FAForever/downlords-faf-client/pull/1979


CSS Not Loading - Redux Hot Example

Trying to integrate this beautiful datepicker into this very popular React-Redux boilerplate https://github.com/erikras/react-redux-universal-hot-example. The input box appears and it is possible to select dates but the styling does not load at all. I have tried the canusedom approach from https://github.com/Hacker0x01/react-datepicker/issues/137 but the most it does is not give the "document is not defined" error. Screenshot is attached to show the kind of component that gets rendered.

Clicking on any of the numbers does select the right date, but the nicely styled date selector component is not rendered. Is there a way to make this render as it is supposed to?

+1

Seeing the same issue. Using React 0.14.0 and 0.15.1 of the datepicker.

Also, this appears to have nothing to do with HMR. I am using redux, but it shouldn't matter since I am just trying to init a basic version of the component with hardcoded values.
Switching to Zippy UI for now until you get this resolved.

Oh holy wow. Here's the fix. Add this:
require('react-datepicker/dist/react-datepicker.css')
Why is this not in the documentation!!!

Oh that might be an oversight from our side! Sorry about that.. Would be
awesome if someone could contribute to the documentation with their
experiences.
On do 29 okt. 2015 at 22:05 Jason<EMAIL_ADDRESS>wrote:

Oh holy wow. Here's the fix. Add this:
require('react-datepicker/dist/react-datepicker.css')
Why is this not in the documentation!!!
—
Reply to this email directly or view it on GitHub
https://github.com/Hacker0x01/react-datepicker/issues/194#issuecomment-152326521
.

Happy to add to the docs, will squeeze it in here in a sec, but now noticing another bug. The datepicker stays display: none right now. I can manipulate in the dev console and then it works until page refresh.
Will create a new issue for this.

Thanks!

Even with importing the CSS the datepicker has the same issue for me :disappointed: Playing around with it

any solution for this yets?

If anyone is using CSS Modules, you have to import react-datepicker/src/stylesheets/datepicker-cssmodules.scss

I'm using CSS Modules
I import react-datepicker/src/stylesheets/datepicker-cssmodules.scss
not helping :(


There should not be any translation issue on the checkout page.

Bagisto Version: Master
Steps To reproduce--
1. Log in as a customer.
2. Change app locale to Arabic.
3. Add any item to the cart.
4. process for checkout.
5. Try to select the shipping method.
Expected result: There should not be any translation issue on the checkout page.
Actual result: There is a translation issue on the checkout page if the customer is selecting the shipping method. Please find the screenshot Here

@jitendra-webkul
I am closing this issue because we need to add the shipping method from the admin panel. please find the screenshot Here.


German text in backend SEPA

Hi, we see payment from our DE website in the backend which is set to EN with a german text.
Should this not be English? (like the backend)

Hi Sean,
This text is not coming from our module. This is coming from core of magento.
Regards,
Rik
Adyen


[fix] Fixed consumer connection checking for unauthorized user #177

Fixes #177

Coverage: 99.288% (-0.001%) from 99.289% when pulling 92344981da92db94d793d7eae5b432376f988564 on issue-177/fix-consumer-connection-for-unauthorized-user into da8e099c7c8502a395dbab116affe3b2f7730177 on master.

@nemesisdesign I've tried re-running the CI build several times, but this specific test keep failing with an AssertionError on (Python==3.7). Do you have any idea why this might be happening?


Accessibility Epic: Focus State Visuals

Ensure that all elements have a focused state with corresponding visual clues (when navigating via keyboard for instance)

https://github.com/rancher/dashboard/issues/4379
https://github.com/rancher/dashboard/issues/7886

We evaluated the following alternatives but never made a solid decision:
Focus state - Adobe Xd Prototype


Implemented shared_connection_block

Method advanced_connection::advanced_connection_impl::block contains race: two different thread can in the same moment block when m_blocker still doesn't exist, so two blockers can be created and there will be data race for m_blocker assignment. Even if assignment will not cause problems itself, incorrect blocker will be returned to one of the caller threads.

Added spinlock mutex to protect the blocker. There is also potential race in shared_connection_block::block(), but I don't think using single shared_connection_block from multiple threads is a valid use case.


GuestAdditions versions and shared folders, test failed

vagrant installed, but toward the end I received these messages:
Got different reports about installed GuestAdditions version:
Virtualbox on your host claims:   4.2.0
VBoxService inside the vm claims: 6.0.10
then a little further down:
==> default: Mounting shared folders...
default: /vagrant => /Users/bfmalle/DiViMe
Vagrant was unable to mount VirtualBox shared folders. This is usually
because the filesystem "vboxsf" is not available. This filesystem is
made available via the VirtualBox Guest Additions and kernel module.
Please verify that these guest additions are properly installed in the
guest. This is not a bug in Vagrant and is usually caused by a faulty
Vagrant box. For context, the command attempted was:
mount -t vboxsf -o uid=1000,gid=1000 vagrant /vagrant
The error output from the command was:
/sbin/mount.vboxsf: mounting failed with the error: No such device
Probably unsurprisingly, the test didn't work:
$ vagrant ssh -c "launcher/test.sh"
bash: launcher/test.sh: No such file or directory
Connection to <IP_ADDRESS> closed.
** Running vagrant 2.2.4 on MacBook Pro (15-inch, 2017), 2.8 GHz Intel Core i7, 16 GB 2133 MHz LPDDR3, MacOS 10.14.5 **

Oh dear, I would suggest to rebuild the entire VM, but this has probably happened already. Would you be able to attach the entire log file, plus provide the versions of the plugins and Virtualbox etc? The error referenced above is not typically an issue, because vagrant updates the guest additions as it builds the VM, and even without that it should work.
You may also be able to build the VM with the docker provider (https://www.vagrantup.com/docs/docker/basics.html)


Enabling Namespace returns error

What happened:
$ kubefed2 -v 2 enable namespace
I0314 15:49:51.276320   24230 enable.go:199] Found resource "namespaces.core/v1"
F0314 15:49:51.510322   24230 enable.go:109] error: Error initializing validation schema accessor: Error loading openapi schema: SchemaError(io.k8s.federation.multiclusterdns.v1alpha1.IngressDNSRecordList.metadata): invalid object doesn't have additional properties

What you expected to happen:
Creation of federatednamespaces custom resource definition.
How to reproduce it (as minimally and precisely as possible):
Federation v 0.0.6 on an OpenShift 4.0 test cluster, follow directions in user guide to set up federation (shortcut hack/intall-latest.yaml). After installing, attempt above command to create Namespaces federated type.
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version)

$ oc version
Client Version: version.Info{Major:"4", Minor:"0+", GitVersion:"v4.0.22", GitCommit:"219bbe2f0c", GitTreeState:"", BuildDate:"2019-03-10T22:23:11Z", GoVersion:"", Compiler:"", Platform:""}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.4+0f8e04e", GitCommit:"0f8e04e", GitTreeState:"clean", BuildDate:"2019-03-04T15:33:19Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}

Federation version

$ oc -n federation-test logs federation-controller-manager-5fb55c99bb-cxw82
Federation v2 controller-manager version: version.Info{Version:"0.0.6", GitCommit:"f3bec03f890ba89079d819213eef4d003df7ab8a", GitTreeState:"clean", BuildDate:"2019-03-12T22:30:29Z", GoVersion:"go1.11", Compiler:"gc", Platform:"linux/amd64"}

$ kubefed2 version
kubefed2 version: version.Info{Version:"v0.0.6", GitCommit:"d56dfb3b83e8d40e584b5e66116de98328846fd2", GitTreeState:"clean", BuildDate:"2019-02-21T18:17:51Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"}

Install method (helm vs script)

Script first, then attempted with operator, both with same result.

Install configuration (namespaced vs cluster-scoped)

namespaced

Others

/kind bug

@cwilkers do you try the latest code? I tried in my latest updated code, it seems has no such issue.
Another question: if you use script to install federation, namespace should be federated. So, could you help to show your installation step?

This bug was fixed by #646, closing.


Manually upgrade spring-boot-starter-parent to 2.6.7

As title.
Refer to https://github.com/Azure-Samples/azure-spring-boot-samples/pull/274.
Try to awake dependabot.

@dependabot reopen

@dependabot recreate

@dependabot rebase

@dependabot


Gameserver DELETED watch sometimes make xDS server not update config

Hello,
Sometimes the gameserver watch from kubernetes returns a DELETED object without address information, the status.address field is "".
This cause the xDS server to warn
error: "status: Unknown, message: "failed to lookup address information: Name or service not known", details: [], metadata: MetadataMap { headers: {} }"
message: "provider task error, retrying"

and after that we dont get any config updates for a long time

I guess the issue is here: https://github.com/googleforgames/quilkin/blob/main/src/config/providers/k8s.rs#L148

Thank you for your issue! Can you provide an example of what a gameserver looks like without the address information? So that we can see what is available? (e.g. node_name), so that we can use a more stable identifier to cleanup the gameservers. We can add a simple check to skip them for now, but ideally we delete the old endpoints so we're properly cleaning up memory.

Yezz, here u go
{
  "type": "DELETED",
  "object": {
    "apiVersion": "agones.dev/v1",
    "kind": "GameServer",
    "metadata": {
      "annotations": {
        "agones.dev/sdk-version": "1.27.0"
      },
      "creationTimestamp": "2023-04-03T09:31:18Z",
      "deletionGracePeriodSeconds": 0,
      "deletionTimestamp": "2023-04-03T09:31:22Z",
      "finalizers": [
        "agones.dev"
      ],
      "generateName": "gameserver-dev-fleet-4wcrf-",
      "generation": 5,
      "labels": {
        "agones.dev/fleet": "gameserver-dev-fleet",
        "agones.dev/gameserverset": "gameserver-dev-fleet-4wcrf"
      },
      "managedFields": [
        {
          "apiVersion": "agones.dev/v1",
          "fieldsType": "FieldsV1",
          "fieldsV1": {
            "f:metadata": {
              "f:generateName": {},
              "f:labels": {
                ".": {},
                "f:agones.dev/fleet": {},
                "f:agones.dev/gameserverset": {}
              },
              "f:ownerReferences": {
                ".": {},
                "k:{\"uid\":\"171160ba-1d53-42db-ad9b-c89e3dea21a7\"}": {}
              }
            },
            "f:spec": {
              ".": {},
              "f:health": {
                ".": {},
                "f:failureThreshold": {},
                "f:initialDelaySeconds": {},
                "f:periodSeconds": {}
              },
              "f:players": {
                ".": {},
                "f:initialCapacity": {}
              },
              "f:ports": {},
              "f:scheduling": {},
              "f:sdkServer": {},
              "f:template": {
                ".": {},
                "f:metadata": {
                  ".": {},
                  "f:creationTimestamp": {},
                  "f:labels": {
                    ".": {},
                    "f:build-id": {},
                    "f:channel": {}
                  }
                },
                "f:spec": {
                  ".": {},
                  "f:containers": {}
                }
              }
            },
            "f:status": {
              ".": {},
              "f:address": {},
              "f:nodeName": {},
              "f:players": {},
              "f:ports": {},
              "f:reservedUntil": {},
              "f:state": {}
            }
          },
          "manager": "controller",
          "operation": "Update",
          "time": "2023-04-03T09:31:22Z"
        }
      ],
      "name": "gameserver-dev-fleet-4wcrf-f5cwf",
      "namespace": "default",
      "ownerReferences": [
        {
          "apiVersion": "agones.dev/v1",
          "blockOwnerDeletion": true,
          "controller": true,
          "kind": "GameServerSet",
          "name": "gameserver-dev-fleet-4wcrf",
          "uid": "171160ba-1d53-42db-ad9b-c89e3dea21a7"
        }
      ],
      "resourceVersion": "162236786",
      "uid": "1b72a7fb-bc6f-4a76-b942-3f02a5b4bce8"
    },
    "spec": {
      "container": "game",
      "health": {
        "failureThreshold": 3,
        "initialDelaySeconds": 15,
        "periodSeconds": 15
      },
      "players": {
        "initialCapacity": 5
      },
      "ports": [
        {
          "container": "game",
          "containerPort": 7777,
          "hostPort": 7404,
          "name": "default",
          "portPolicy": "Dynamic",
          "protocol": "UDP"
        }
      ],
      "scheduling": "Packed",
      "sdkServer": {
        "grpcPort": 9357,
        "httpPort": 9358,
        "logLevel": "Info"
      },
      "template": {
        "metadata": {
          "creationTimestamp": null,
          "labels": {
          }
        },
        "spec": {
          "containers": [
            {
              "args": [ ],
              "command": [ ],
              "env": [ ],
              "image": "xyz",
              "name": "game",
              "resources": {
                "limits": {
                  "cpu": "500m",
                  "memory": "1G"
                },
                "requests": {
                  "cpu": "500m",
                  "memory": "1G"
                }
              }
            }
          ]
        }
      }
    },
    "status": {
      "address": "",
      "nodeName": "",
      "players": {
        "capacity": 5,
        "count": 0,
        "ids": null
      },
      "ports": null,
      "reservedUntil": null,
      "state": "Shutdown"
    }
  }
}

I suppose metadata.name is a good key

Fyi, this object is taken from the k8s api server gameserver watch using curl:
curl "http://localhost:8080/apis/agones.dev/v1/gameservers?watch=true"

Most DELETED objects does have the address field set, so it seems to be related to some sort of timing issue with Agones maybe.

In this particular case the gameserver the Agones state was:
Creating -> Starting -> Shutdown
so the instance was never actually Ready. I dont know why Agones schedules like that. It was 4 seconds between the Starting and Shutdown updates.

Turns out that the gameserver creation triggered a nodepool scaleup, and then the cluster decided to delete the pod.


Fix sgn(T val) when val == 0

You tried to implement the function as a one-liner but then someone mentioned it would fail when val == 0 so you decided against the one-liner, but forgot to remove it.
Context: https://www.twitch.tv/videos/590165240?t=1h3m

@justinsmid Nice! Thank you so much for catching that! I wonder why the compilers never said anything about the "dead code" :thinking:


Doxygen files are missing in project 10, 11, 12

The file docs/Doxyfile is missing in project 10, 11, 12
What is the use of the configure_file() call if you don't have variables in the Doxyfile
The file is present in FinalCmake/docs/Doxyfile but contains a typo for the INPUT property
INPUT                  =    ../src \
INPUT                       ../include

INPUT                  =    ../src ../include

Added the files.
And this was no typo, mine version works like yours.


Update OS, actions, node

~Remove node 14~ Add maintenance and LTS node versions
Update checkout to 3.3.0
Update setup-node to 3.6.0
Change windows to latest

Needs #53 to hopefully fix the windows test

Well there's your problem...
Looks like I'll need to find another way to add a space into that directory lol

...why in the world is Windows 16 using node-gyp -v v9.1.0...don't tell me that having node-gyp hoisted into the package.json is what made Windows install using the correct version :man_facepalming:

I give up. Putting back the hoisted node-gyp entry into the package.json fixed the CI for Windows 16 AND 18 - so I guess it stays there for now...

I worry about micro-managing this PR, my apologies.
Responding to request for review.
Regarding the CI failure on Node 19: Would personally rather not test any non-LTS Node versions.

I kind of don't want to worry about non-LTS Node. We have plenty of time to integrate those changes after they've been stabilized and packaged for wide consumption, when they appear in Node 20 LTS in the future. There's generally three LTS releases at any given time, that gives us plenty of lead time to get ready for the newest LTS, in my opinion, before being forced to switch. Riding the "Current" release stream is a headache.

Also, commenting out a test feels kind of wrong, I don't think it is genuinely relevant to the changes in .github/workflows/CI.yml. I do expect this test will not work with npm 8 or newer, so its days are most likely numbered, so I suppose removing it here is okay, just seems not neatly scoped to "one PR one change".
And yet we have some much wider-reaching PRs in other repos. So. I dunno if it's so bad...
Again, I don't want to micro-manage, I feel like this started as a draft and I nudged it into being merge-ready by specifying all the details exactly, doesn't feel like good reviewer behavior, but er it was requested now. Feel free to ping on Discord if you need to talk about it/check in expectations in a less formal way.


Top/bottom line holly-ghost brackets (now 3 lines; allow user to specify 0 line break)

Check for existing issues

[X] Completed

Describe the feature
Currently when scrolling/traveling through a file (up/down) with keyboard when reaching the top of the screen or bottom, there will always be a "holly-ghost" space of 3 lines. Allow user to specify this space to be at 0 lines.
Side note: I am still amazed how natural and intuitive ZED is and feels. Thank you for all the work you do.
If applicable, add mockups / screenshots to help present your vision of the feature
Here I present current setup for the top of the file, you can see there is brake/bracket traveling window of three lines to the top.

The same applies to the bottom travel/scroll (3 lines).
I would like to have ability to have the current line to be at the very top without the traveling window space of 3 lines.

Was about to file an issue myself when I found this.
My problem is with trying to double click to select words within the first 3 lines and it'll just scroll up and make me select the wrong stuff, but I guess in the end it's the same thing. Still not sure if this is a bug or feature…
👍'ed


[FM4Bridge] Add new bridge for FM4 news page

Add bridge for FM4 news (austrian radio station)

@em92 added exampleValue and made tag optional to load all articles, also more than one page can be parsed now

gj @joni1993 !


feat: improve import file to calendar and extend capabilities

This is an extension for import to calendar:
what's new?

Support "Location" field when importing txt, csv or ics files
files must be in the following structure or the old structure (without Location)Title1, Content1, S_Date1, E_Date1, Location1
Title2, Content2, S_Date2, E_Date2, Location2
...
TitleN, ContentN, S_DateN, E_DateN, LocationN

Start and End dates support hours and minutes format

the new rules we set (can be changed through a global variable):

The location field length is up to 50 characters.
The event duration limit.

Additional tests added:

Start date is smaller or equal to the end date.
The Location field may be empty.
Checking that new files from the old and new format are working flawlessly.
And some more here and there :)

Codecov Report

Merging #201 (6f75002) into develop (a1f2998) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #201      +/-   ##
===========================================
+ Coverage    99.36%   99.37%   +0.01%
===========================================
  Files           36       36
  Lines         1418     1447      +29
===========================================
+ Hits          1409     1438      +29
  Misses           9        9

Impacted Files
Coverage Δ

app/internal/import_file.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f2998...9a4124e. Read the comment docs.


Dependencies pep8

this incorporates #254 and extends it by adding a required pyproj dependency to the ARIA-tools install file
it then incorporates  PEP8 style changes in #257.

Codacy issue is related with two rules in PEP257 (D212 and D213). These rules are exclusive and can be ignored as long as one of them is satisfied.

@bbuzz31 Looks good to me on the requirements.


Support for publisher-subscriber in load balanced environment (Multiple instances of the server)

Question
Do we have support for running publisher-subscriber in load balanced environment?
Scenario
Consider I have a publisher named "publisher-app" and a subscriber named "subscriber-app".
I have 2 instances of both publisher-app and subscriber-app.
Consider the instances named as follows:
publisher-app-instance-1, publisher-app-instance-2
subscriber-app-instance-1, subscriber-app-instance-2
Observation
After running these instances, I observed that subscriber-app-instance-1 and subscriber-app-instance-2 are both connected to publisher-app-instance-1 only.
Now in that case, If anything is published on publisher-app-instance-2 then it would not get notified to any of the subscriber-app-instance-1 or subscriber-app-instance-2.
What am I looking for
I need to connect each subscriber to each publisher as per the requirement of the project. So that I can get notifications on every subscriber from every publisher.

subscriber-app-instance-1 should connect to publisher-app-instance-1 as well as publisher-app-instance-2
subscriber-app-instance-2 should connect to publisher-app-instance-1 as well as publisher-app-instance-2

I think this question is out of Spring for GraphQL's scope. This is really about your publisher instances sharing a common piece of infrastructure (usually, a message queue or a pub/sub service of some sort). There is no specific support for that in this project but could be achieved with spring data redis or spring-amqp I think.

Sure. Thanks for the information @bclozel. I will explore Spring Data Redis and Spring-amqp.


Actions

JIRA Ticket: https://jira.lyrasis.org/browse/FCREPO-3532
What does this Pull Request do?
Replaces Travis with Github Actions
How should this be tested?
This is difficult to test. Here is an example of the build workflow: https://github.com/pwinckles/fcrepo4/actions/runs/363679840
I have not tested the deploy workflow. I think it should work, but it may need tweaking. All I can say for certain is that it is syntactically correct.
The deploy workflow only runs on pushes to main and the following secrets must be defined in the Github settings:

OSSRH_USERNAME
OSSRH_TOKEN
GPG_PASSPHRASE
GPG_PRIVATE_KEY
DOCKER_USERNAME
DOCKER_PASSWORD

I have not defined these secrets.
Interested parties
@fcrepo/committers

One idea for testing the deployment workflow is to add the necessary secrets and then merge these changes into a branch rather than main. I can update the deployment workflow to apply to the branch, which would allow us to see if it works before merging into main.

@pwinckles : That seems like a good test step.

@awoods Okay, I added the trigger. The deploy workflow will now run on main and deploy-test.

Thanks, @pwinckles . I will wait for @dbernstein to add the "secrets".

@awoods : I'm looking into the secrets now.

Secrets in place: https://github.com/fcrepo/fcrepo/settings/secrets/actions

This PR should be good to go. Here's a successful run, including a deploy, on a test branch: https://github.com/fcrepo/fcrepo/actions/runs/371243618.
Note, I got rid of the deploy workflow, moving the deploy job into the build workflow so that I could make it depend on all of the other jobs. Deploy will only run on main.


TEST

TEST ONLY

Waiting some time to see if CIVET updates the scripts.

Success!
Installing RAVEN plugins ...
BUILD_ROOT/raven/: scripts/install_plugins.py -s TEAL


1.20 port

Data Attributes is unfortunately not yet updated to 1.20 so I couldn't test this, and I am therefore marking it as a draft.

Data Attachments are now in Fabric API, can this replace the Data Attributes library?
Like using Data Attachments that are attached to entities instead of using Data Entity Attributes.

there seems to be an updated fork of data attributes available for 1.20, would it be ok to use that? https://modrinth.com/mod/data-attributes-directors-cut

Should be noted that this mod doesn't depend on Data Attributes. The code in question was written to make Purpeille compatible with that mod.
Anyways, sorry for not responding sooner. Unfortunately there's a lot of issues in the latest version of the mod that I fixed in the 4.0 development version but never patched back in the main version. I can cherry pick those fixes if I have the time.

ok, in that case I'll change the data attributes dependency to modCompileOnly and test without it

did a bit of testing and seems to work fine, so marking as ready to review


Add PlayStream inspector widget

Within the Godot Editor, add a PlayStream inspector widget

Unfortunately, this is not possible, as at the current time one cannot simply subscribe to the PlayStream directly.
IT could be made possible with a separate server-side solution/configuration, but that would defend the purpose of this feature.

Unfortunately, this is not possible, as at the current time one cannot simply subscribe to the PlayStream directly.
It could be made possible with a separate server-side solution/configuration, but that would defend the purpose of this feature.


Create old.nuget.org DNS entry

It would be good to be able to look back at the old site if we need to reference it for feedback from the community.

Done.


[#PRDGROWTH-271] adding product lists to admin serializer

@ganeshmohan2021 These updates will need to be made to the Rails 6 branch also

Sure Tom

@ganeshmohan2021 Can you please get the test suite to pass? Once that's done we will need to release a new version of the gem, and then adjust the other apps as needed, but we can sync up on that wen the time comes

You'll want to release both a new 5.2 and 6.1 version

@ganeshmohan2021 Can you please get the test suite to pass? Once that's done we will need to release a new version of the gem, and then adjust the other apps as needed, but we can sync up on that wen the time comes

Hi @bcasci , The spec failure is related to ruby version. In my local all spec is passing. I don't know how to fix the bundler issue in Circle CI?

@ganeshmohan2021 Can you please get the test suite to pass? Once that's done we will need to release a new version of the gem, and then adjust the other apps as needed, but we can sync up on that wen the time comes

Hi @bcasci , The spec failure is related to ruby version. In my local all spec is passing. I don't know how to fix the bundler issue in Circle CI?

@ganeshmohan2021 you can set the bundler version in .circleci/config on line 36.

@tmking @ganeshmohan2021 I resolved it by changing the CircleCI image. It was old.


[Q] Future of Boost.Nowide

I'm a user of this library and already opened a few PRs. I've just seen that this was accepted into Boost 2 years ago. But nothing happened since.
@artyom-beilis What is the intended future for this project? I'd really love for it to be either included into boost or refactored into a standalone library with boost integration/dependency.
Reason is: This is super useful. It has even been included already in several linux distros, see e.g. https://bugzilla.redhat.com/show_bug.cgi?id=1502584. However there are some issues with some of them even being already fixed by open PRs. It would be great to have at least the community to enhance this.
I'd suggest (if Boost inclusion is out for now) to create a simple library, which requires boost and has proper CMake files for building as submodule or standalone. My PR #27 is already used by RedHat repos, so that might be a good starting point. This combined with some travis CI to test PRs keeps the effort low.

I created a master branch in my fork incorporating the reviewfixes branch (https://github.com/artyom-beilis/nowide/commit/6bc55c95d2aa08f37fed3cc952619269812f4046) from here as well as all my PRs and various other fixes for failures detected during the setup of CI.
It contains extensive CI that also verifies the standalone version as well as improved CMake scripts that install proper targets. Additionally the CMake Library on Linux is now an INTERFACE library meaning no linking (of an empty lib) is required. Releases on tags are also created automatically.
See https://github.com/Flamefire/nowide
@artyom-beilis Are you still interested in that library to maintain it and/or include it into boost? The master branch should be almost ready for it as I fixed all remaining issues from the review summary. Only thing missing is the Jamfile for the docu.

What branch have you forked?
This is the relevant one: https://github.com/artyom-beilis/nowide/tree/reviewfixes
I still need to finish some review work (I have some open issues) unfortunatelly I still can't get my hands on it...

I started with your master and merged all my open PRs, then merged your reviewfixes. On top of that I started implementing CI, fix the remaining review issues and fix bugs detected. Basically all the review comments have been addressed now and some previously undetected bugs have been squashed.
My focus was to but as much as possible on CI to verify future changes for standalone and boost version (the former is/was broken)
However I'm currently working on the filebuf which has some inconsistencies and bugs, some of them only degraded performance by doing more than required by the standard. So I'm going through each function and check and fix them according to the standard. To be sure I templated the test cases to run them with the std and the nowide classes to detect non-bugs.
Due to the current state I'd suggest to close my open PRs and create a new, big one with all my changes and have you review them in case I missed anything. Ping me when you got time for such thing or suggest an other approach.

@pdimov if you need help, ping me
To ease taking code from my fork, I'd suggest you merge the reviewfixes branch asap to avoid conflicts and apply clang format (with my style file, designed to make it consistent w/o changing more than required) I think afterwards we can easily diff files and you don't need to fix issues I already fixed. If you want I can then also try to extract small PRs, but the format needs to be adjusted first


DCOS-57614: table-multiselect doesn't work as expected

Allow multiple job run to be selected
in the job run history table
Closes DCOS-57614
Testing

Go to jobs tab.
Create a job that wouldn't finish immediately.
Example JSON:

{
  "id": "new-job-1",
  "description": "",
  "run": {
    "cpus": 1,
    "disk": 0,
    "mem": 128,
    "ucr": {
      "image": {
        "id": "nginx",
        "kind": "docker"
      }
    },
    "cmd": "sleep 1000"
  }
}

Open it.
Run it at least two times.
In the runs history table, verify that you can select multiple checkboxes.
Verify that the added test makes sense.

Trade-offs
It took me two minutes to fix the bug and like fourty minutes to get the test working.
Dependencies
None.
Screenshots
Before

After

Unrelated system tests are failing. Maybe we broke master?

does not seem to work as intended:

The failing system tests are unrelated to this PR and are also failing on other PRs.

@pierrebeitz , the bug you mentioned is actually a known one: https://jira.mesosphere.com/browse/DCOS-8763 . I guess this means we need to change the table type.

Alternatively, we can just run through the selected items.


refactor(frontend): merge presenter

Motivation
This will merge presenter/ into frontend/(presenter)/. See vike docs to learn about (domain)-driven file structure.
The motivation is the same as in #1792:

Less dependencies
Less dependabot PRs
Less workflows to run
Less code duplication
Less memory consumption in our kubernetes cluster
Less domains to generate certificates for
Less potential for CORS issues
Less containers running in docker-compose
Less disk usage on our laptops

As a side quest, this will also remove warnings in presenter/ during npm run build.
There is one manual step to do on our vServer: It would be nice to send a redirect stage1.app.dreammall.earth -> stage1.dreammall.earth.
How to test

cd frontend
npm run test:unit

or -

cd frontend
npm run dev

I object this - we don't get any meaningful benefits for now - not reviewable. Maybe after the release. I would appreciate if we could focus or workforce on things we actually need for the release.

@ulfgebhardt I think the PR description contains a list of meaningful benefits. Regarding the workforce: Freeing up time otherwise spent on maintaining code duplication is one of the benefits.

I object this still

Then let's find a time to have a meeting together with the team where you can participate.


Polynomial Equation Roots Finder

Enter calculator name -
Polynomial Equation Roots Finder
Describe calculator functionality -
Take input as degree(max.: 7) of polynomial and then take inputs for the coefficients of the equation x^n + x^(n-1) + x^(n-2) + ... + constant from the user and display the roots of this polynomial
Under which category you wish to place it -

[] Computer Science
[x] Mathematics
[] Physics
[] Chemistry
[] Biology
[] Finance
[] Scientific
[] Health
[] Sports
[] Let project owner decide
[] Suggest a new category - (Answer here)

Kindly assign this issue to me @SarthakKeshari.

Hey @shivangforsure,
Assigned.
You may contribute your code under the folder path -
calc_for_everything\calculators\src\mathematical\polyEqRootFinder
Issue completion deadline - 9th Oct 11:00:00 am IST
NOTE - In case the issue completion deadline is not met, the issue will be assigned to a new participant

I apologize for the delay in my response, and I appreciate your understanding.

@shivangforsure,
Since the issue completion deadline is crossed,
Issue has been unassigned.
Kindly do not create a PR for the issue now.

hello pls assign me

Hey @Harshit-Poddar90,
Assigned.
You may contribute your code under the folder path -
calc_for_everything\calculators\src\mathematical\polyEqRootFinder
Issue completion deadline - 9th Oct 11:00:00 am IST
NOTE - In case the issue completion deadline is not met, the issue will be assigned to a new participant

Hey @syash7202,
Assigned.
You may contribute your code under the folder path -
calc_for_everything\calculators\src\mathematical\polyEqRootFinder
Issue completion deadline - 26th Oct 11:00:00 pm IST
NOTE - In case the issue completion deadline is not met, the issue will be assigned to a new participant

kindly assign me this @SarthakKeshari

Hey @WaterCubeGod,
Glad to see your eagerness for contributing 🤩. I regret to inform, issue can't be assigned as each assigned issue is marked with a deadline. In case the previous participant fails to raise a PR before the deadline, only then the issue can be assigned to a new participant.
For now, kindly look into any open issues or you may even create one. 🤩
Happy Contributing 🎉


[benchmark] Add Azure support to Terraform in p4benchmark | 68405

This PR is Work in progress

Thanks Christina - will have a look next week when Andy is back.
You say WIP - what else do you expect to be included?

Hi, @rcowham I opened the Draft PR in this fork by mistake. We are still working on the Terraform scripts for Azure, we have to add the Virtual Machines and add some configurations. So the idea is to work on another Fork we created and after reviewing it with the team internally send it to both of you to be reviewed. I will close this PR.


Diffusers 0.26.3

Hi you need update pipeline XL to work with last version of Diffusers...

Hi @elismasilva,
I tested DeepCache under diffusers==0.26.3 and it works well. Can you give me the code snippet that can reproduce the bug/error?

#23 Looking now at the history I suppose this is related, this pipeline is for 0.24 diffusers right?

#23 Looking now at the history I suppose this is related, this pipeline is for 0.24 diffusers right?
Yes. If you want to use the code in DeepCache.sdxl.pipeline_stable_diffusion_xl, than Diffusers needs to be downgraded to 0.24(test passed under 0.21.3<diffusers<0.25.0).

And another way is to install the package DeepCache and follow the instruction to run the pipeline (or use DeepCache.extension.deepcache, the same). This implementation can support the latest versions of diffusers so far.


scipy.stats.mode

It would be great if you could add the JAX equivalent of scipy.stats.mode, which is currently unavailable.
A use case may be a ML classification task with ensembles, where multiple models give different predictions, and we are interested in finding the most common one.
As an example, consider predictions to be a two-dimensional DeviceArray of predictions, with
shape = (number of models, number of data points).
It would be nice if one could compute
mode_prediction  = jax.scipy.stats.mode(predictions, axis=0),
returning the most common prediction for every data point.

Here's a quick jit-compatible implementation if you want to make use of it:
import jax.numpy as jnp
from jax import vmap

def mode(x, axis=None):
  def _mode(x):
    vals, counts = jnp.unique(x, return_counts=True, size=x.size)
    return vals[jnp.argmax(counts)]
  if axis is None:
    return _mode(x)
  else:
    x = jnp.moveaxis(x, axis, 0)
    return vmap(_mode, in_axes=(1,))(x.reshape(x.shape[0], -1)).reshape(x.shape[1:])

x = jnp.array([1, 1, 2, 2, 2, 3, 4])
print(mode(x))
# 2

y = jnp.array([[1, 1, 2, 3],
               [4, 5, 6, 5]])
print(mode(y, 1))
# [1, 5]

Great, thanks!

It's definitely in scope to add this to jax.scipy.stats. If anyone wants to tackle it, you could take the example implementation from above, make sure it returns the same values as scipy.stats, and add an appropriate test in tests/scipy_stats_test.py

Let me take this up, can anyone suggest a good location/file for this function to put ?
For Scipy it's defined here and here.
I am starting this for now by putting it inside the init.py

@gianlucadetommaso  can i work on this ?

@Yash621 please go ahead, I haven't had much time to take this up myself.

@gianlucadetommaso can you suggest the location where i should place this function?

You could put the implementation in a new submodule, maybe something like jax/_src/scipy/stats/_core.py

I'd love to jump in and collaborate with @Yash621 on this, if that's okay.

Would love to collaborate with @Yash621, if this issue is still open?

I think the PR in https://github.com/google/jax/pull/9141 is quite close - it just needs a bit more work before it can be merged.

@jakevdp @gianlucadetommaso I took a swing at it on a fresh branch (#11475).
(Apologies for the couple of branches. I was tricking the google cla scan to find my cla.).
Let me know any feedback you have.

Also for those wanting to contribute - based on any feedback we get here - feel free to open a PR on my branch


Manage project reporting, impact capture, ways of work

Goal Title
DSH produces required reports and is able to clearly communicate the project impact
Description
Project reports
Impact communication
Mangement repo and roadmap maintenance
Meeting templates and structure
Definition of Done
Quarterly, and after relevant milestones the is a comprnehensive report
Monthly the team is able to communicate and work effectively, progress is clearly communicated during meetings and there is an associated PR or document
Details

RACI

Accountable team or person:
Responsible team or person:
Informed and consulted people:

Estimated effort in total FTE: 0.12

RAM: 0.05

Resourcing
August

RPM: 0.05

Task and issue breakdown
Breakdown in specific tasks of maximum a month duration, tasks and issues may be added as necessary
Issues may span across repositories when necessary

https://github.com/alan-turing-institute/data-safe-haven-team/issues/44

Checklist

[ ] This Story have been agreed with project members, it tackles prioritised work

[ ] If not: Label as ForPrioritisation so it discussed in the next monthly meeting, do not set a status

[ ] I have filled in the Team Accountabe field
[ ] I have included this Story in the agreed upon Milestone, set status as Planned

[ ] If not: set status as Backlog, to be Planned via weekly meetings or async discussions

[ ] The work to be done is likely to span over a month
[ ] I have broken down the work in monthly issues and added them above
[ ] I have labeled this issue according to its main project: SATRE, TRESA, CORE DSH (ELA) or other (please agree and create a new label if necessary)
[ ] If known: sum the total effort (points) of tracked issues and add it on the body
[ ] Select a Story level of effort in the project fields

Reporting
10 July to 14 August 2023

The team was involved in discussing the proposed ways of work, it was decided that they needed to be streamlined. To do so the focus has been put in updating the weekly meeting notes and the PM and story accountable persons driving reporting efforts (PM prepares, story/project leaders complete and approve)

Ways of work principles have been added as a result
The weekly template has been updated to reflect this
WaysofWork require furhter changes to reflect the above

Questions from the team regarding ways of work (evaluate where to best put this):

Do we need to open an issue for everything we do? How much time does that take? We already have issues and places to update them, to update in yet another place can be burdensome.
What about other repos, especially repos not owned by the Turing org?
Will people appreciate being pinged in our project management repo?
What happens when we have information we can’t or shouldn’t share publicly?

Plan to capture publication strategy here. This includes:

Tiers/design paper (on arXiv but not published)
v4 Implementation paper (on Overleaf but not arXiv or published)
SATRE work (spread across medium blogs + specification page)

October: both ELA and SATE ends, reportng due and 6 monthly

Dec planning
Some end of the year report needs done, not really a rpiority. Esp Community call

Jan planning
Focus is not this now, it's mainly strategy planning/review etc


[wrt][xwalk-3492] Update tests for packertool2

Add test for version when the length of version in manifest file is greater than or equal to 4

Impacted TCs num(approved): New 1, Update 3, Delete 0
Unit test Platform: Android
Android test result summary: Pass 4, Fail 0, Block 0

LGTM


Hover over Request Description - Advanced Search

As a user
I want to see the request descriptions quickly on an advanced search
so that I can determine if I need to look further into a file

Assumptions & Scope
This is a feature enhancement to the existing hover over request ID description story.
It was found that we missed a criteria to also extend this feature to advanced search results, and this story aims to rectify it.
Acceptance Criteria
Scenario 1: Advanced Search - Move cursor over request ID Number

GIVEN I am a user on a queue
WHEN I move my cursor over the ID Number for a request
THEN a display window will appear that displays the full request description for that request
AND the text window will also display the date range for the request at the end of the request description in parentheses e.g. This is the request description (Jan 1 2021 to Jan 31 2021)

Scenario 2: Advanced Search - Move cursor off request ID Number

GIVEN the cursor is hovered over the ID number for a request
WHEN I move the cursor off the ID number to anywhere else on the page
THEN the display window will disappear

Scenario 3: xxxxxx
...
Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

Hi @m-prodan @liseandtea @KyEggleston, This ticket is part of event queue. Once it is closed, we will plan the event queue release.
cc. @sumathi-thirumani-aot @abin-aot

Passed QA - closing.


polymorphic variant in rei

should we use [< | `some_tag | ... ] instead of [ | `some_tag | ... ] whenever possible?
https://github.com/SentiaAnalytics/bs-css/blob/master/src/Css.rei#L499 like here,
I've got a [<| `color | `url(string)], but when I pass it into background, it could not compiles:
  This has type:
    [< `currentColor
     | `hex(string)
     | `hsl(int, int, int)
     | `hsla(int, int, int, int)
     | `rgb(int, int, int)
     | `rgba(int, int, int, int)
     | `transparent
     | `url(string)
     > `hex ]
  But somewhere wanted:
    [ `currentColor
    | `hex(string)
    | `hsl(int, int, int)
    | `hsla(int, int, int, float)
    | `linearGradient(Css.angle, list((int, Css.color)))
    | `none
    | `radialGradient(list((int, Css.color)))
    | `repeatingLinearGradient(Css.angle, list((int, Css.color)))
    | `repeatingRadialGradient(list((int, Css.color)))
    | `rgb(int, int, int)
    | `rgba(int, int, int, float)
    | `transparent
    | `url(string) ]

Yeah I think that makes sense.

Do you want to open a PR?


Serialize api activation via a property

…roperty

Feedback addressed, PTAL.

I'll look into getting a linter to run on Github. I don't think Google's internal python style matches public python anyway, so it might be good for us to have a different linter in this repo than g4 lint anyway.


Add aarch64 linux build

This adds support for arm-based linux distributions.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Should there be ARM builds in the matrix on Azure? I'm not seeing any new ones: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=866942&view=logs&jobId=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e

Should there be ARM builds in the matrix on Azure? I'm not seeing any new ones: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=866942&view=logs&jobId=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e

Hmm, not sure - I don't see the macOS builds there either, but perhaps they do not run on Azure. It might be possible to alternatively use provider: {linux_aarch64: azure}(?). I followed the information found here: https://thepracticalsysadmin.com/building-multiarch-conda-forge-recipes/

I think this is outdated. Please have a looked at the previously posted documentation.

OK, I changed to linux_aarch64: {enabled: True}, but now to not see any arm builds.

try to ping somebody in gitter.im conda-forge channel

try to ping somebody in gitter.im conda-forge channel

Thanks, but I'm not sure what that means? Btw. the manual states that linux_aarch64: {enabled: True} is largely an internal value. Reading further, I think my original proposal was possibly OK, see here: https://conda-forge.org/docs/maintainer/conda_forge_yml.html#provider

@mlund https://app.gitter.im/#/room/#conda-forge:matrix.org
I'm pretty sure the way to do these migrations is let the bot try (https://github.com/conda-forge/conda-forge-pinning-feedstock/pulls?q=is%3Apr+aarch64), or at least that's what I did the last time I added a platform to an existing feedstock

@mlund https://app.gitter.im/#/room/#conda-forge:matrix.org
I'm pretty sure the way to do these migrations is let the bot try (https://github.com/conda-forge/conda-forge-pinning-feedstock/pulls?q=is%3Apr+aarch64), or at least that's what I did the last time I added a platform to an existing feedstock

Thanks, I think I got it and opened this: https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5454


Adding Kafka-emitter

This PR is about adding new extensions-contrib.
Currently, Druid has various emitter module and also has HttpPostEmitter for general purpose. But, Many user currently using Apache Kafka platform and I assume that If druid has another extension emitting their metrics to kafka directly, many user feel comfort and convenience using various monitoring dashboard UI or another eco.
Please feel free for commenting this PR.

This PR is under construction but I wanna get many people's comment about direction of this PR.

Thanks @dkhwangbo. Will review soon

@fjy Hi. Any update is in there?

@b-slim I just reflect your another comment. Please feel free for review and giving another comment to me.

also it would be great if you can write some documentation for this extension. For example, here's the documentation for StatsD Emitter - https://github.com/druid-io/druid/blob/master/docs/content/development/extensions-contrib/statsd.md
You can include the extension in list of Community Extensions here - https://github.com/druid-io/druid/blob/master/docs/content/development/extensions.md

@pjain1 Thanks for your review! I just reflect your kind comment and also write documentation. Please review it.

@dkhwangbo Also please file the CLA if you have not done so far - http://druid.io/community/cla.html

@dkhwangbo have you tested this emitter on your druid cluster ?

@pjain1 I reflect your comment! This extension is running in my druid cluster since 3 weeks ago and All functionality doing well. Also, I already done signing CLA during writing this PR

Closing/Reopening PR for travis

Changes look good to me so 👍 .. however I have one last question - Why are you not handling AlertEvent ?

@pjain1 To make this PR, I refer graphite-emitter and StatsD-emitter. Both has no handling AlertEvent. (Just graphite-emitter write error log when AlertEvent emitted). I dig a little up but  druid has no documentation about AlertEvent, furthermore, AlertEvent class only used in ambari-metrics-emitter and graphite-emitter in whole druid project. So, I cannot get a sense how to handle AlertEvent appropriately.
What's the purpose of AlertEvent? When AlertEvent is emitted? What's the class AlertEvent called? If you give me the answer of my question, I really appreciate your help and support.

This is the AlertEvent class. It is outside of Druid repo. It is used whenever an Alert is made using log.makeAlert(). This is used for alerting critical problematic situations like Segment could not be loaded or task failed to run etc.
I am not sure why graphite-emitter is not handling alerts but for Kafka emitter Ideally alerts should go to a different topic than the metrics (ServiceMetricEvent) so that users immediately know that something is wrong in the cluster and they can take a look.
I am OK with the PR as it is, if someone wants to have alerts handled then it can be done in a follow up PR. If you want you can write the code for handling alerts in this PR as well or in a follow up PR or you can choose not to do it.

@pjain1 Oh, I got it. Thanks for your nice explanation. I'll add the code line to handle AlertEvent in another kafka topic. I'll ping you when I ready for review.

Hi Dongkyu,
I'm interested in your implementation as I've tricked current http metric
emitter.
What I've currently done is an http server in Go lang that receives http
emitter.
It parses messages and put events into a Kafka topic.
Main issue is that some of the events has multiple informational like JVM
data or System ones, so I've set generic fields for Druid datasource as
user1 user2 an so on.
A suggestion is about having a configuration file which set events that can
be set into Kafka and which not. This is what I've set in my http server,
avoiding to have unwanted metrics.
About alerts what I've done is generating an email and a Slack notification
with the error details.
Mainly I use the standard event metrics to monitor Druid through Grafana
charts and alerts as immediate notifications (this is why I didn't put into
Kafka).
Hope I helps in your implementation
Thanks
Maurizio
Il 05 feb 2017 3:07 AM, "Dongkyu Hwangbo"<EMAIL_ADDRESS>ha
scritto:

https://github.com/pjain1

@pjain1 https://github.com/pjain1 Oh, I got it. Thanks for your nice
explanation. I'll add the code line to handle AlertEvent in another kafka
topic. I'll ping you when I ready for review.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/druid-io/druid/pull/3860#issuecomment-277492212, or
mute the thread
https://github.com/notifications/unsubscribe-auth/AAYbMSDRWAPh4d9vr2Rne85JTXdqQMXMks5rZS7fgaJpZM4LnmVX
.

@tutunci Hi Maurizio. Thanks for your interesting suggestion. I understand your point. In fact, I use this extension with another my own Spark streaming job. It can consume Kafka topic, metric-value-based anomaly detect, and send the metric to my timeseries DB. I think your idea also reasonable, so I'll add something like whitelist based logic.

@tutunci Hi Maurizio. Your suggestion is under construction by me, but I think origin purpose of this PR is already done. So, I think It is better finishing this PR in here and handle your suggestion in another PR. Is it Okay?
@pjain1 It's ready for your review.

Hi Dongkyu,
It's absolutely OK, of course.
Just to give you some additional details, here my configuration file:
enabled=sys/disk/write/count||all
enabled=jvm/mem/max|memKind|all
enabled=jvm/mem/committed|memKind|all
enabled=jvm/mem/used|memKind|all
enabled=jvm/mem/init|memKind|all
enabled=jvm/pool/max|poolKind,poolName|all
enabled=jvm/pool/committed|poolKind,poolName|all
enabled=jvm/pool/used|poolKind,poolName|all
enabled=jvm/pool/init|poolKind,poolName|all
enabled=segment/loadQueue/size|server|druid:aws:coordinator
enabled=segment/loadQueue/failed|server|druid:aws:coordinator
enabled=segment/loadQueue/count|server|druid:aws:coordinator
enabled=query/cache/total/hitRate||druid:aws:broker,druid:aws:historical
enabled=query/cache/total/averageBytes||druid:aws:broker,druid:aws:historical
enabled=query/cache/total/timeouts||druid:aws:broker,druid:aws:historical
enabled=query/cache/total/errors||druid:aws:broker,druid:aws:historical
Here what's setup is
metric | additional params to set as user1,user2... | services involved
So for example when I receive these metrics:
{"feed":"metrics","host":"<IP_ADDRESS>:8083","metric":"jvm/pool/init","
poolKind":"heap","poolName":"PS Survivor Space","service":"
druid:aws:realtime
","timestamp":"2017-02-05T23:59:54.891-05:00","value":268435456}
{"feed":"metrics","host":"<IP_ADDRESS>:8083","metric":"jvm/pool/max","poolKind":"heap","poolName":"PS
Old
Gen","service":"druid:aws:realtime","timestamp":"2017-02-05T23:59:54.891-05:00","value":10737418240}
It matches with this condition enabled=jvm/pool/init|poolKind,poolName|all
because metric matches, services are all and additional user-defined fields
are poolKind=>user1 and poolName=>user2 (it's positional based on the
insert order).
Hope it can give you some kind of help.
Let me know if you create another PR, so I can follow it.
Thanks
Maurizio
2017-02-06 3:01 GMT+01:00 Dongkyu Hwangbo<EMAIL_ADDRESS>
@tutunci https://github.com/tutunci Hi Maurizio. Your suggestion is
under construction by me, but I think origin purpose of this PR is already
done. So, I think It is better finishing this PR in here and handle your
suggestion in another PR. Is it Okay?
@pjain1 https://github.com/pjain1 It's ready for your review.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/druid-io/druid/pull/3860#issuecomment-277570577, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAYbMbAFNwJmyWDVrTOJEtjEFGdJ3nouks5rZn8QgaJpZM4LnmVX
.

👍

@tutunci have you seen this https://github.com/yahoo/druid-extensions/tree/master/metric_collector might be helpful ?

@dkhwangbo i have raised this issue https://github.com/druid-io/druid/pull/3860#pullrequestreview-19666260 and still see the same problem. emit should never be blocking.

@b-slim Hi. Is it going right direction?

@dkhwangbo yes that's good now user can inject config to the producer. Can you fix the the blocking issue please and thanks for the contribution?

@b-slim Thanks for your support. I'll fix the point you repeated and ping you when this PR is ready for your review.

@b-slim I try to fix you pointed. Is it going right direction? Please correct if it goes wrong.

@dkhwangbo you are using an unbounded queue here and thus you have no control on how big this queue can grow (and can potentially grow big enough to cause JVM heap to go out of memory). Also, you do not need another queue, kafka producer already maintains an internal buffer whose size can be configured by user using property buffer.memory. Thus user can choose how many events they want to buffer at the producer side.
In my opinion what would be better is to configure kafka producer to throw exception when its buffer gets full by setting block.on.buffer.full to false and thus drop the events that cannot be accommodated something like this - https://github.com/yahoo/druid-extensions/blob/master/metric_collector/src/main/java/com/yahoo/druid/metriccollector/MetricCollectorResource.java#L254
This way users can choose how many events they want to buffer and how much heap memory they are ready to spare for the producer. If you decide to go this route, it would be good to maintain a counter of how many events were dropped because of this and log that count every X number of dropped events. X can be a million or something like that.
That would be my advice @b-slim what do you think ?

@pjain1 Hi. I have a question for your advise.
In Kafka documentation, block.on.buffer.full is deprecated from <IP_ADDRESS>.

The producer config block.on.buffer.full has been deprecated and will be removed in future release. Currently its default value has been changed to false. The KafkaProducer will no longer throw BufferExhaustedException but instead will use max.block.ms value to block, after which it will throw a TimeoutException.

In terms of code maintenance, Using block.on.buffer.full is a little bit questionable solution. also, @b-slim mentioned, emit should never be blocking but using producer.send in emit has potential blocking issue because of max.block.ms. This is why I use another queue and using queue.add in emit.
So, I think next step is 1) fix using unbounded queue, or 2) rollback last commit and set max.block.ms to 1 (or another reasonable value) and drop message when TimeoutException occured. What do you think? Please comment. Thanks!

One option is to implement a memory bounded queue, something like this - https://gist.github.com/pjain1/96ed2369bb8de4cb691317d5f2945888 (this one is blocking but the one required here should not be, it should just drop data) and use that instead of unbounded queue.
Another option is to use max.block.ms and set it lets say 50 by default and make it such that the property max.block.ms is overridable by user supplied config.
I am in favor of using max.block.ms @b-slim what do you prefer ?

This is one of my favorite interview questions for new platform eng hires 😆 (handling buffer full conditions)
I suggest we retain the behavior in the other emitters and drop new data in favor of old data. AKA record the dropped event count and continue on, occasionally warning of dropped events in the log.

@pjain1 Thanks for your kind explanation! Your explanation is always helpful to me. @b-slim Please share your idea. If you agree with @pjain1 's second option(set max.block.ms to 50) I'll drive with that.
@drcrallen Thanks for your interesting! I'll keep in mind this subject and your suggestion when I'll take interview 😄

actually https://gist.github.com/pjain1/96ed2369bb8de4cb691317d5f2945888 is not blocking when you add item, it blocks while taking item from it, so it actually does what we want here.

@pjain1 Hi. I adopt MemoryBoundLinkedBlockingQueue. Please review it. Thanks.

@pjain1 @b-slim @drcrallen Any suggestion?

@pjain1 I apply your comment. Thanks for your detailed review.

@dkhwangbo Once https://github.com/druid-io/druid/pull/3860/files#r103521383 is resolved I am good to get this merged 👍  also I would suggest that you run the latest code on your druid setup for sometime (just in case some issue comes up you can do follow up PRs)
thanks @dkhwangbo for resolving the outstanding issues quickly

@pjain1 I apply your last suggestion and also version up kafka-clients to latest. I tested last commit of this implementation on my cluster and all the functionality going well. Thanks for your every helpful explanation on here.

@b-slim any more comments?

@gianm Hi! Thanks for your reply. I addressed your comment, also I apply code formatting rule. Furthermore, I use lambda a little bit to the right place.

@fjy @b-slim @gianm Anythine else?

@dkhwangbo thanks for contribution ! this looks good to me ! good job !

Can we maybe get some example JSON in the documentation so people know what to expect? Also maybe and example kafka consumer task that consumes this JSON back into Druid?

@erikdubbelboer Thanks for your suggestion! I'll revise document your suggestion included soon.

@pjain1 Can you describe what the 0.10.1 release notes should call out regarding this patch?

dear all:
I use kafka-<IP_ADDRESS> config kafka-emitter status is ok, but use kafka-<IP_ADDRESS> status is exception. How solve this exception :
io.druid.emitter.kafka.KafkaEmitter - Failed to take record from queue!
java.lang.InterruptedException

@ambition119
Can I get your config file both with <IP_ADDRESS> and <IP_ADDRESS>?

use kafka-<IP_ADDRESS> and kafka-<IP_ADDRESS> common.runtime.properties kafka-emitter config is the same, info :
druid.extensions.loadList=["druid-hdfs-storage", "druid-histogram", "druid-datasketches", "druid-lookups-cached-global", "mysql-metadata-storage", "kafka-emitter"]
druid.monitoring.monitors=["com.metamx.metrics.JvmMonitor"]
druid.emitter=composing
druid.emitter.composing.emitters=["logging","kafka"]
druid.emitter.logging.logLevel=info
#druid.emitter=kafka
druid.emitter.kafka.bootstrap.servers=hdp:9092
druid.emitter.kafka.metric.topic=druid-metric
druid.emitter.kafka.alert.topic=druid-alert
druid.emitter.kafka.producer.config={"key.serializer":"org.apache.kafka.common.serialization.StringSerializer","value.serializer":"org.apache.kafka.common.serialization.StringSerializer","max.block.ms":10}
extensions/kafka-emitter directory Are not the same, kafka-emitter（<IP_ADDRESS>）info:
kafka-emitter/
kafka-emitter-0.11.0-SNAPSHOT.jar
kafka_2.10-<IP_ADDRESS>.jar
kafka-clients-<IP_ADDRESS>.jar
metrics-core-2.2.0.jar
scala-library-2.10.4.jar
snappy-java-<IP_ADDRESS>.jar
zkclient-0.3.jar
jopt-simple-3.2.jar
kafka-emitter（<IP_ADDRESS>）info:
kafka-emitter/
jopt-simple-5.0.3.jar
kafka_2.10-<IP_ADDRESS>.jar
kafka-clients-<IP_ADDRESS>.jar
kafka-emitter-0.11.0-SNAPSHOT.jar
metrics-core-2.2.0.jar
scala-library-2.10.6.jar
snappy-java-<IP_ADDRESS>.jar
zkclient-0.10.jar
thanks!

@ambition119 Older than Kafka 0.9.x has no compatibility with it, because It currently use Kafka <IP_ADDRESS> client. Please read this part of Kafka document: http://kafka.apache.org/documentation.html#upgrade_9

hi @dkhwangbo
Do you still plan to work on a whitelisting system?
thanks


Fix linkis cli async exeute throw npe

What is the purpose of the change
Fix linkis cli async execute throw npe. close #4869
Related issues/PRs
Related issues: #4869

LGTM.


[documentation] Updated comment for tf.multnomial

Self-explanatory.

Can one of the admins verify this patch?

Could you sign the CLA? We need this.

Done.

I'm not sure this is an improvement.
@aselle what say you?

Up to you, though I think it's worth noting that "unnormalized log probabilities" makes it seem like the function accepts log probabilities (which it doesn't). It accepts log-odds!!!
The documentation of the underlying function that implements tf.multinomial is actually more precise; this is how I figured out that I needed to pass log-odds in the first place.

Apologies, you are correct. Thanks!

Jenkins, test this please.