WFLY-4780 Add migrate operation to the web subsystem to allow it to b…

…e migrated to the Undertow subsystem

Linux Build 7106 is now running using a merge of adce1ed8277eb94ce2acadbc91de6b811aebfabf

Linux with security manager Build 1979 is now running using a merge of adce1ed8277eb94ce2acadbc91de6b811aebfabf

Windows Build 2158 is now running using a merge of adce1ed8277eb94ce2acadbc91de6b811aebfabf

Linux with security manager Build 1979 outcome was SUCCESS using a merge of adce1ed8277eb94ce2acadbc91de6b811aebfabf
Summary: Tests passed: 878, ignored: 284 Build time: 0:06:32

Linux Build 7106 outcome was FAILURE using a merge of adce1ed8277eb94ce2acadbc91de6b811aebfabf
Summary: Tests failed: 1 (1 new), passed: 2956, ignored: 354 Build time: 0:45:39
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ejb.remote.suspend.EjbRemoteSuspendTestCase.testSuspendedCallRejected: <no details avaliable>

Windows Build 2158 outcome was FAILURE using a merge of adce1ed8277eb94ce2acadbc91de6b811aebfabf
Summary: Tests failed: 2, passed: 2955, ignored: 354 Build time: 0:47:45
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.clustering.xsite.XSiteSimpleTestCase.testPutRelayedToBackups: <no details avaliable>

org.jboss.as.test.manualmode.ejb.client.cluster.EJBClientClusterConfigurationTestCase.testServerToServerClusterFormation: <no details avaliable>

Retest this please

Windows Build 2163 is now running using a merge of adce1ed8277eb94ce2acadbc91de6b811aebfabf

Linux with security manager Build 1984 is now running using a merge of adce1ed8277eb94ce2acadbc91de6b811aebfabf

Linux Build 7111 is now running using a merge of adce1ed8277eb94ce2acadbc91de6b811aebfabf

Linux with security manager Build 1984 outcome was SUCCESS using a merge of adce1ed8277eb94ce2acadbc91de6b811aebfabf
Summary: Tests passed: 878, ignored: 284 Build time: 0:06:35

Linux Build 7111 outcome was SUCCESS using a merge of adce1ed8277eb94ce2acadbc91de6b811aebfabf
Summary: Tests passed: 2956, ignored: 355 Build time: 0:45:22

Windows Build 2163 outcome was FAILURE using a merge of adce1ed8277eb94ce2acadbc91de6b811aebfabf
Summary: Tests failed: 2, passed: 2954, ignored: 355 Build time: 0:47:30
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.clustering.xsite.XSiteSimpleTestCase.testPutRelayedToBackups: <no details avaliable>

org.jboss.as.test.manualmode.ejb.client.cluster.EJBClientClusterConfigurationTestCase.testServerToServerClusterFormation: <no details avaliable>

Linux with security manager Build 2039 is now running using a merge of 8eae6ce8a346dc927bf6028ac298f8f7e3f39b0b

Windows Build 2223 is now running using a merge of 8eae6ce8a346dc927bf6028ac298f8f7e3f39b0b

Linux Build 7167 is now running using a merge of 8eae6ce8a346dc927bf6028ac298f8f7e3f39b0b

Linux with security manager Build 2039 outcome was SUCCESS using a merge of 8eae6ce8a346dc927bf6028ac298f8f7e3f39b0b
Summary: Tests passed: 880, ignored: 282 Build time: 0:06:31

Linux Build 7167 outcome was FAILURE using a merge of 8eae6ce8a346dc927bf6028ac298f8f7e3f39b0b
Summary: Tests failed: 1 (1 new), passed: 2949, ignored: 354 Build time: 0:47:56
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ejb.mdb.ejb2x.MDB20TopicTestCase.testEjb20TopicMDBs: <no details avaliable>

Windows Build 2223 outcome was SUCCESS using a merge of 8eae6ce8a346dc927bf6028ac298f8f7e3f39b0b
Summary: Tests passed: 2948, ignored: 355, muted: 1 Build time: 0:48:58

@bstansberry does this look ok to you?

This shouldn't block this, but we should look into it for web and messaging.
These subsystems should not be usable on a non-admin-only server. Their function is to provide a model for migration, but if a runtime is being set up they should fail.
LegacyExtension would handle that for something like cmp, but it can't be used here of course. But these subsystems are still using ModelOnlyAddStepHandler/ModelOnlyWriteAttributeHandler/ModelOnlyRemoveStepHandler and those handlers will happily work in a non-admin-only server, just storing the model and doing nothing in runtime. For these subsystems we should fail in performRuntime if it's called.

I'll try and look more later.

A simple solution to my previous long comment would be for LegacyExtension to support a boolean constructor param. If 'false' (default) the behavior is like now. If true it doesn't complain about being run on a standalone server if ExtensionContext.getRunningMode() == RunningMode.ADMIN_ONLY.

@stuartwdouglas other than Jeff's comment, looks good.

Windows Build 2236 is now running using a merge of 335d6c26d50f472a518e12bbe7855c6360105335

Linux with security manager Build 2052 is now running using a merge of 335d6c26d50f472a518e12bbe7855c6360105335

Linux Build 7180 is now running using a merge of 335d6c26d50f472a518e12bbe7855c6360105335

Linux with security manager Build 2052 outcome was FAILURE using a merge of bb7928e81b0ee06ac827dcb3fb97c415a13c228d
Summary: Tests passed: 712, ignored: 252; exit code 1 (new) Build time: 0:03:47
Build problems:
Process exited with code 1

Linux Build 7180 outcome was FAILURE using a merge of bb7928e81b0ee06ac827dcb3fb97c415a13c228d
Summary: Tests passed: 712, ignored: 252; exit code 1 (new) Build time: 0:04:10
Build problems:
Process exited with code 1

Windows Build 2236 outcome was FAILURE using a merge of bb7928e81b0ee06ac827dcb3fb97c415a13c228d
Summary: Tests passed: 712, ignored: 252; exit code 1 (new) Build time: 0:06:00
Build problems:
Process exited with code 1

Linux Build 7181 is now running using a merge of bb7928e81b0ee06ac827dcb3fb97c415a13c228d

Linux with security manager Build 2053 is now running using a merge of bb7928e81b0ee06ac827dcb3fb97c415a13c228d

Windows Build 2237 is now running using a merge of bb7928e81b0ee06ac827dcb3fb97c415a13c228d

Linux with security manager Build 2053 outcome was SUCCESS using a merge of bb7928e81b0ee06ac827dcb3fb97c415a13c228d
Summary: Tests passed: 880, ignored: 282 Build time: 0:06:21

Linux Build 7181 outcome was SUCCESS using a merge of bb7928e81b0ee06ac827dcb3fb97c415a13c228d
Summary: Tests passed: 2950, ignored: 354 Build time: 0:44:41

Windows Build 2237 outcome was SUCCESS using a merge of bb7928e81b0ee06ac827dcb3fb97c415a13c228d
Summary: Tests passed: 2948, ignored: 355, muted: 1 Build time: 0:46:25


ARROW-13424: [C++] Remove needless workaround for conda and benchmark

https://github.com/google/benchmark/issues/1046 has been resolved.

@pitrou Could you try this? I don't have conda environment.

@github-actions crossbow submit -g cpp

@github-actions crossbow submit -g conda


Modal inconsistency for polygon wizards image selector

In a polygon table, if you select in the IMG selector for the SIMPLE wizard a modal for patterns is shown:

If you do it in CATEGORY wizard a modal for markers is shown:

Also, inside this modal, if you select some of the icons it says "upload image" instead of "set image":

cc @viddo @xavijam

Most likely will be resolved with new modal, the new ones replacing these are planned for this sprint.

By the way, I think we should design some patterns for the polygons as well as we're offering some icons for markers. Stripped/dotted svgs would be nice :)

Closing since this will be fixed with the redesign :)


Faq component | dropdown effect

faq component added with dropdown effect. If approved,  i have also made an array of objects files where the faq questions are included. I will map over it and display data as we don't want to repeat jsx elements unwantedly!

let me know @abhijeet007rocks8 @DhairyaBahl

let me know @abhijeet007rocks8 @DhairyaBahl , also my lap has not been working for some days. now I am not able to open files, hence why I will sending pics from phone, I hope you guys don't mind it !

no issue images are getting an idea of the fix
and there are merge issues

thanks! merge issues fixed @abhijeet007rocks8 @DhairyaBahl

everything is fixed!

its still occurring can you try again

Can you check it out @abhijeet007rocks8 , I don't knoe why it's happening again, all I did is imported faq component and added that in about page

Can you check it out @abhijeet007rocks8 , I don't know why it's happening again, all I did is imported faq component and added that in about page

The issue is being generated in app.js file.
So pull the recent changes from the main repo to your fork and then add your changes to it and commit.

please check now, there are no conflicts!

Can you mention the issue number ?? for adding label

this is part of about us page,  #132  @abhijeet007rocks8 , please add labels


Unable to alter primary key after creating the table

Bug description
I have a model in prisma.schema that looks a little like this:
model PayrollCheque {
  parentChequeId Int @unique @id
  parentCheque Cheque @relation(fields: [parentChequeId], references: [id])
  // Other fields
}

I realized that I want multiple payrolls for a single parent cheque, so I changed my schema to have a different primary key.
model PayrollCheque {
  id Int @id @default(autoincrement())
  parentChequeId Int
  parentCheque Cheque @relation(fields: [parentChequeId], references: [id])
  // Other fields
}

I attempted to create a migration and deploy it, only to get the following error:
Database error:
Column name 'id' does not exist in the target table or view.
I checked the migration and Prisma was adding a primary key constraint before creating the ID column. Here is a little representation of what was being generated:
ALTER TABLE [dbo].[PayrollCheque] ADD CONSTRAINT PayrollCheque_pkey PRIMARY KEY CLUSTERED ([id]);
ALTER TABLE [dbo].[PayrollCheque] ADD [id] INT NOT NULL IDENTITY(1,1);

How to reproduce

Expected behavior
ID should be added before the primary key is created.
Prisma information

I can't include my schema.prisma as it contains confidential information.
Environment & setup

OS: Windows 10
Database: Microsoft SQL Server 2016
Node.js version: v18.14.1

Prisma Version
Prisma v4.15.0

Hey there, I'm a first time contributor and would like to help out with this issue. Is there a maintainer that would be willing to review/accept my PR when I start working on it?

I started with this schema (expanded from the minimum you shared):
model PayrollCheque {
  parentChequeId Int    @id @unique
  parentCheque   Cheque @relation(fields: [parentChequeId], references: [id])
  // Other fields
}

model Cheque {
  id            Int            @id @unique
  PayrollCheque PayrollCheque?
  // Other fields
}

This migrates cleanly and nicely.
Then I changed it according to your suggestions (again expanded from what you actually shared):
model PayrollCheque {
  id             Int    @id @default(autoincrement())
  parentChequeId Int
  parentCheque   Cheque @relation(fields: [parentChequeId], references: [id])
  // Other fields
}

model Cheque {
  id            Int             @id @unique
  PayrollCheque PayrollCheque[]
  // Other fields
}

This indeed fails as you described:
PS C:\Users\Jan\Documents\throwaway\19963> npx prisma migrate dev
Environment variables loaded from .env
Prisma schema loaded from prisma\schema.prisma
Datasource "db": SQL Server database

√ Enter a name for the new migration: ... expand
Applying migration `20240522192221_expand`
Error: P3018

A migration failed to apply. New migrations cannot be applied before the error is recovered from. Read more about how to resolve migration issues in a production database: https://pris.ly/d/migrate-resolve

Migration name:<PHONE_NUMBER>2221_expand

Database error code: 1911

Database error:
Column name 'id' does not exist in the target table or view.

This is the full migration:
/*
  Warnings:

  - The primary key for the `PayrollCheque` table will be changed. If it partially fails, the table could be left without primary key constraint.
  - Added the required column `id` to the `PayrollCheque` table without a default value. This is not possible if the table is not empty.

*/
BEGIN TRY

BEGIN TRAN;

-- DropIndex
ALTER TABLE [dbo].[PayrollCheque] DROP CONSTRAINT [PayrollCheque_parentChequeId_key];

-- AlterTable
ALTER TABLE [dbo].[PayrollCheque] DROP CONSTRAINT [PayrollCheque_pkey];
ALTER TABLE [dbo].[PayrollCheque] ADD CONSTRAINT PayrollCheque_pkey PRIMARY KEY CLUSTERED ([id]);
ALTER TABLE [dbo].[PayrollCheque] ADD [id] INT NOT NULL IDENTITY(1,1);

COMMIT TRAN;

END TRY
BEGIN CATCH

IF @@TRANCOUNT > 0
BEGIN
    ROLLBACK TRAN;
END;
THROW

END CATCH

And indeed it adds the contraint on id before actually adding the column.


How to adjust NIMBLE's MANO output to real world size

Hi @reyuwei ,
Thanks for sharing NIMBLE model to community!
when running demo.py, I got rand_0_manov.xyz and successfully shown it in visualization. However, I noticed that the scale of vertices in this file is quite large. the mean value of vertices position in my case is [16.59393144 -61.90396254 -26.14423879], even scale by 0.01 (in case the unit is centimeter), the size of hand is not match with  real world hand size.
Could you give any advice on how to scale the MANO output to real world scale? Thanks in advance!

Hi! The original MRI data and our NIMBLE model are both in millimeter unit. So you probably want to scale by 0.001 to get MANO scale (in meter unit).

Hi @reyuwei , Thanks for your reply, which solved my problem 👍


[Snyk] Upgrade io.fusionauth:fusionauth-jwt from 5.2.0 to 5.2.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade io.fusionauth:fusionauth-jwt from 5.2.0 to 5.2.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released a month ago, on 2022-08-12.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


doesn't download from instagram

It was working till last night but it stopped working today and it shows these errors:
E/flutter (18670): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: Bad state: No element E/flutter (18670): #0      List.first (dart:core-patch/growable_array.dart:360:5) E/flutter (18670): #1      Instagram (package:direct_link/sites/instagram.dart:18:10) E/flutter (18670): <asynchronous suspension> E/flutter (18670): #2      DownloadData.downloadProcess (package:instagram_downloader/download_data.dart:20:17) E/flutter (18670): <asynchronous suspension> E/flutter (18670):  E/flutter (18670): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: Bad state: No element E/flutter (18670): #0      List.first (dart:core-patch/growable_array.dart:360:5) E/flutter (18670): #1      Instagram (package:direct_link/sites/instagram.dart:18:10) E/flutter (18670): <asynchronous suspension> E/flutter (18670): #2      DownloadData.downloadProcess (package:instagram_downloader/download_data.dart:20:17) E/flutter (18670): <asynchronous suspension> E/flutter (18670):
I have used many different Instagram links but it just shows this.

Is anybody having this problem or it is just me?😐

It is keeping to show Bad state: No element please tell us how to fix this, thanks.

at least just tell us is it going to be fixed or not?


add tags to notion data sources

add tags to notion DS documents:

title
author
last editor
last edited at

display provider icons

icon for notion, slack, gdrive, github in DS list
icon for notion next to doc name in documents list & search

documents display name

use the title tag if available to replace the document ID in documents list & search

misc

remove focus indicator for tags when in readonly mode (upsert page)

No other "tags" from Notion?

@spolu i realized “tags” is not an actual notion page property. You can add a “multi select” property and you can name it “tags” but its not a standard thing

Yes it will require a resync


[core] Fix offline case

FIxes https://github.com/lvwerra/trl/issues/530
I propose to add a (risky) bare except to handle the offline cases
cc @lvwerra

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Atomically swap config data

Swap the config providers' data atomically instead of changing the property.
This is so that any enumeration of the dictionary running during a (re)load operation does not throw an InvalidOperationException due to the collection being modified.
Addresses #1189

Thanks


upcoming: [M3-7463] - Disable Billing access user permission for child users

Description 📝
As a child user, the UI of the permissions page will be the same as global or non-parent/child, except for Billing Access. Billing Access will be set to "Read Only" with the option for unrestricted child users to switch it to "None" for other child users. "Read-Write" will always be disabled. In other words, child account users will have no permission greater than "Read Only" billing access.
Why are we enforcing this in the UI, rather than relying on the account_access grant?
For an unrestricted (admin) child account user's account_access (which determines Billing Access), the API will return read_write in order for the user to have access to the rest of the user permissions, including managing those of their proxy user. Therefore, we need to make an additional check of the user_type to ensure on the front-end that we actually restrict billing access for child users.
Changes  🔄

The Billing Access default setting is configured to "Read Only" for child users.
Child users have the option to switch Billing Access to "None."
The "Read-Write" option is consistently disabled and cannot be selected by child users.
Adds test coverage for the above to user-permissions.spec.ts.

Preview 📷

How to test 🧪
Prerequisites
(How to setup test environment)

Check out this PR and yarn dev.
In devtools, make sure the feature flag is on and enable the MSW.
Go to serverHandlers.ts and edit the account/users/:user request to the following in order to mock a child user:

  rest.get('*/account/users/:user', (req, res, ctx) => {
  // Parent/Child: switch the `user_type` depending on what account view you need to mock.
  return res(ctx.json(accountUserFactory.build({ user_type: 'child' })));
  }),

Verification steps
(How to verify changes)

Go to http://localhost:3000/account/users and navigate to the User Permissions for a mock restricted user.
Confirm the Changes described above.
Toggle off the feature flag and confirm that Read-Write billing access is not disabled and is the default selection.
Play around with the Billing Access options and make sure there are no regressions in the selected options (e.g. no more than one option can be selected at the same time).
Verify test passes:

yarn cy:run -s "cypress/e2e/core/account/user-permissions.spec.ts"

As an Author I have considered 🤔
Check all that apply

[x] 👀 Doing a self review
[x] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[x] ➕ Adding a changeset
[x] 🧪 Providing/Improving test coverage
[x] 🔐 Removing all sensitive information from the code and PR description
[x] 🚩 Using a feature flag to protect the release
[x] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

The CI e2e failures are irrelevant to this PR and I connected with Banks offline regarding the above comment - we can't derive since user data isn't already stored in state.
Going to go ahead and merge. 🚢


iostream file not found

well, here's what i get when i run make setup command:
respring_simulator.mm:6:10: fatal error: 'iostream' file not found #include <iostream>

Rather a problem with your compiler header, not simject itself. Try installing Xcode Command Line Tools in case you haven't.


Go 1.15 will break a test case about ssl SANs.

What did you do?
Commit PRs and found that TestNewHTTPWithServerName  failed in the windows environment in CI.
What did you expect to see?
No error for TestNewHTTPWithServerName.
What did you see instead? Under which circumstances?
I looked the last PR results, and there were some successes and some failures with this use case.
Environment
windows in ci

System information:
windows in ci

Prometheus version:
master branch

Logs:

=== RUN   TestNewHTTPWithServerName
2020/08/28 01:41:49 http: TLS handshake error from <IP_ADDRESS>:50034: remote error: tls: bad certificate
    target_test.go:306: Get "https://<IP_ADDRESS>:50033": x509: certificate relies on legacy Common Name field, use SANs or temporarily enable Common Name matching with GODEBUG=x509ignoreCN=0
--- FAIL: TestNewHTTPWithServerName (0.01s)

CI failed results

https://app.circleci.com/pipelines/github/prometheus/prometheus/8873/workflows/1265f98d-c3de-49bd-a286-21b61402e093/jobs/38710
https://app.circleci.com/pipelines/github/prometheus/prometheus/8638/workflows/01992340-66b4-4992-9dac-fbaf2e631e6b/jobs/37696

Further information

crypto/x509: Go 1.15 will break default connections to AWS RDS

Thanks. This has been fixed on master a few weeks ago.


Create Jupyter Notebook Extension

The extension (including both the necessary Python code and static JavaScript and image assets) should be packaged as a Python package, and installable using Jupyter Notebook commands.

Closed by #23

I need to test building the package and installing it now that #23 is merged.

I'm making progress on this. I'm now getting an error when I try to run the code in a Jupyter notebook:
Javascript error adding output!
SyntaxError: missing ) after argument list
See your browser Javascript console for more details.

I haven't had time to run this down.

0.1 has been pushed to PyPI.


Added debugging GUID comment generation

Fixes #611.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: YohDeadfall sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

/azp run


[Bug] wrong time displayed

Server has the correct time, docker container has the correct time, Adguard Home shows the correct time, android devices where I run Adguard Home manager app have the correct time, but the app shows the time with an hour difference

That's a known issue. I have seen many times during the development. On mu device the application shows the correct time. Maybe could be something related with the time zone, but I will need to investigate it.

That's a known issue. I have seen many times during the development. On mu device the application shows the correct time. Maybe could be something related with the time zone, but I will need to investigate it.

time zones are correct on all devices, a solution would be to have in the app an option to use the server time or to be able to select the time zone, which would be useful when you are traveling in a zone with another time zone, this of course for people who have adguard home configured to use outside home

@zekabra could you give me your time zone? Just for testing.

It's GMT+00:00

more information to help troubleshoot the problem, tested on 2 devices. Currently the app has one hour more, unchecked the option for the time and time zone to be automatically provided by the network, nothing changed, manually selected a time zone with +01:00, my time increased but the app kept the time unchanged, manually selected again +00:00, this time the app showed the correct time and my equipment also has the correct time, I selected again time and time zone automatically provided by the network, in one equipment the app kept the correct time but in another it increased one hour

I don't have that issue. On my case I'm on GMT+1 and the app shows the correct time. If I switch to GMT+0 the app still shows the correct time. When you change the timezone on the device settings, you have to refresh the logs list to update the time.
When the app shows a different time than the web app, go to the web app, to the logs list, open developer tools, and on the network tan, open the querylogrequest. There, on the response, open one log and paste here the time.

I can't find the entry in the web app to view the log, can you provide more directions. Video showing the problem, Lineage 18.1 rom, never had problems with timezones in other apps.
https://martinhojose.dynip.sapo.pt/s/zQEaZxNfxTYAg4B

As I can see the issue is only present on Lisbon timezone on Portugal. I tried many other timezones on the US, India, China with no issues. Also as you can see, the Canary Islands are also on GMT+0 and with that timezone selected there's no issue. It's very strange.
https://user-images.githubusercontent.com/47545344/204144443-6eb3f3b1-6e85-4b8b-a1a7-a86982c64d5d.mp4

So it seems, I tried with a larger time zone and the time was shown correctly, when I went back to mine, the time went back to showing 1 hour more, as you suggested, I tried with Spain/Canary and it shows the correct time, for now I will use that setting until the cause of the bug is found, thanks for the support

The issue seems to be fixed
https://user-images.githubusercontent.com/47545344/204145581-5cdea923-6de0-422c-a041-d03ea28d9757.mp4

The issue seems to be fixed
Grabacion.de.pantalla.2022-11-27.a.las.17.13.39.mp4

Thank you very much for your patience and dedication

Fixed on v1.5.3. I have uploaded the update to Google Play a moment ago. It should be available later today. Thank you for reporting the issue and I hope you enjoy the application.


python interpreter in launch task does not override python.defaultInterpreterPath

Type: Bug
Behaviour
Expected vs. Actual
I specified a valid python interpreter path on the debug launch task,

and inherited an invalid python interpreter path through python.defaultInterpreterPath.

I expect the valid interpreter to be used when launching the debugger task. Instead, I get an error about launch.json being invalid (which is inaccurate):

This happened unfortunately as part of https://github.com/devcontainers/features/issues/258, where the devcontainer was providing an invalid interpreter path, and trying to fix it by setting the python path override did not help.
Steps to reproduce:

Specify a valid python interpreter path in launch.json
Specify an invalid python interpreter path in settings.json
Launch the debugger on a python file

Alternatively use the minimal repro here https://github.com/weikanglim/devcontainer-python/tree/weilim/invalid-interpreter:

git clone https://github.com/weikanglim/devcontainer-python && cd devcontainer-python && git checkout weilim/invalid-interpreter
Open main.py and hit F5

Expected:
The valid python interpreter is used, and debug successfully launches.
Actual:
An error "The Python path in your debug configuration is invalid." that points to launch.json shows up.
Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda):
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Unknown
Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

[ERROR 2022-10-3 10:37:12.928]: Invalid Python Path 'invalid'

User Settings

languageServer: "Pylance"

Extension version: 2022.18.0
VS Code version: Code 1.73.0 (8fa188b2b301d36553cbc9ce1b0a146ccb93351f, 2022-11-01T15:34:06.111Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: No
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2
Connection to 'codespaces+weikanglim-github-template-test-qvrq7wrxwxf45wp' could not be established
Connection to 'codespaces+weikanglim-studious-giggle-xr6w5j6q6426wpv' could not be established
Connection to 'codespaces+weikanglim-supreme-space-robot-5v6qgw656x2p664' could not be established
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-10980XE CPU @ 3.00GHz (36 x 3000)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
63.73GB (27.86GB free)

Process Argv
--crash-reporter-id 0ce79a4c-f4f8-4913-a92b-4597f5c231c8

Screen Reader
no

VM
0%

Item
Value

Remote
Dev Container: Azure Developer CLI

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
Intel(R) Core(TM) i9-10980XE CPU @ 3.00GHz (36 x 2999)

Memory (System)
49.99GB (47.01GB free)

VM
0%

Connection to 'codespaces+weikanglim-github-template-test-qvrq7wrxwxf45wp' could not be established
Connection to 'codespaces+weikanglim-studious-giggle-xr6w5j6q6426wpv' could not be established
Connection to 'codespaces+weikanglim-supreme-space-robot-5v6qgw656x2p664' could not be established

Item
Value

Remote
Dev Container: Azure Developer CLI

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
Intel(R) Core(TM) i9-10980XE CPU @ 3.00GHz (36 x 2999)

Memory (System)
49.99GB (47.01GB free)

VM
0%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
pyindex848cf:30577861
nodejswelcome1cf:30587006
fc301958:30595537
2e4cg342:30596373

Reassigning as it's related to debugger.

"python" in the debug configuration is used by adapter to spawn the debuggee. However, there's a separate question of which Python is used to spawn the adapter itself - this is something decided by the extension, and it does not take "python" into account.
There is, however, a separate property named "debugAdapterPython" that can be used to control that:
https://github.com/microsoft/vscode-python/blob/f62e96c39fe9e15cc5422184dac36f4f1a6a1eb7/src/client/debugger/extension/adapter/factory.ts#L113-L120


Does not fetch new B2 authorization token when token expires

Version v1.26
OS: Ubuntu 14.04 LTS 64bit
Command: rclone copy ./folder b2:bucket/folder
Issue: I was uploading ~3M files and the upload from my estimate would take 3 days. B2 auth tokens expire after 24 hours. I noticed today (started upload last night around this time) that rclone began throwing unauthorized errors because B2 expired the token and rclone ignored it.

Thanks for reporting that. I missed that the token expired in the docs.

Do you happen to know which error code backblaze returned? 401?  Or was it something else?
There isn't much of a clue in the docs
https://www.backblaze.com/b2/docs/b2_authorize_account.html
I might just fetch a new one every hour - that would probably do it.

You could do if error code != 200, get new auth token. Same with the uploads. If the upload returns anything but 200, get a new URL.

The actual error is
x: Failed to copy: Failed to upload: Authorization token has expired (401 expired_auth_token)

I've fixed this.  It took a little while with a 24 hour test cycle! I've also fixed a number of other important B2 bugs!
Here is a beta for you to try.
http://pub.rclone.org/v1.27-41-g6b6b434β/
Thanks for reporting the bug.
Nick

I don't have any massive uploads at the moment .-. I managed to break apart my massive upload to upload in sections. Also, I got to talk with the Backblaze CEO (Because I was hammering the B2 API with 750 concurrent uploads) and they suggest using multiple upload URLs when doing concurrent uploads.

See #373 for the multiple upload URLs - I've fixed that and there is a beta with that in on that issue!

Awesome! :+1:  :)

Hello,
Rclone 1.34, running on a raspberry pi 3 (with raspbian)
I'm currently in the progress of uploading a ton of data to B2, and unfortunately, this issue is still present.
I started rclone at [2016-11-21 19:48] (ah, don't we love logfiles)
After a bit over 24 hours, it started spouting these errors:
2016/11/22 19:59:52 data/5/50045: Failed to copy: Authorization token has expired (401 expired_auth_token)
2016/11/22 19:59:53


Vulnerability roundup 71: wavpack-5.1.0: 7 advisories

search, files

[ ] CVE-2018-10536 (nixos-unstable)
[ ] CVE-2018-10537 (nixos-unstable)
[ ] CVE-2018-10538 (nixos-unstable)
[ ] CVE-2018-10539 (nixos-unstable)
[ ] CVE-2018-10540 (nixos-unstable)
[ ] CVE-2018-6767 (nixos-unstable)
[ ] CVE-2019-11498 (nixos-unstable)

Scanned versions: nixos-unstable: 73392e79aa6. May contain false positives.

I can't see this reported for 19.03, but the version is the same, so I cherry-picked that PR anyway.


Bug: Filter removes ms from DateTime values

While working on a new feature for apxsp-big-logger, I came across this fun issue. The Filter class currently removes MS from DateTime object values.
This bug only appeared when attempting to query for an exact DateTime value (as is necessary with the linked application):
Long loggedAtMs =<PHONE_NUMBER>820L;
DateTime loggedAtDt = DateTime.newInstance(loggedAtMs);
String queryString = 'SELECT Message__c FROM Log__b WHERE Logged_At__c = :loggedAtDt LIMIT 1';
System.debug('\n\nStrongly Typed SOQL:\n' + queryString + '\n' + JSON.serialize([
SELECT Message__c FROM Log__b WHERE Logged_At__c = :loggedAtDt LIMIT 1
]) + '\n\n');
> Strongly Typed SOQL:
SELECT Message__c FROM Log__b WHERE Logged_At__c = :loggedAtDt LIMIT 1
[{"attributes":{"type":"apxsp__Log__b","url":"/services/data/v57.0/sobjects/apxsp__Log__b/000000000000000AAA"},"apxsp__Message__c":"This is a test, Jason!","Id":"000000000000000AAA"}]

System.debug('\n\nDynamic SOQL:\n' + queryString + '\n' + JSON.serialize(Database.query(queryString)) + '\n\n');
> Dynamic SOQL:
SELECT Message__c FROM Log__b WHERE Logged_At__c = :loggedAtDt LIMIT 1
[{"attributes":{"type":"apxsp__Log__b","url":"/services/data/v57.0/sobjects/apxsp__Log__b/000000000000000AAA"},"apxsp__Message__c":"This is a test, Jason!","Id":"000000000000000AAA"}]

apxsp.Soql query = apxsp.DB.Soql.newQuery(Log__b.SObjectType)
    ?.deselectId()
    ?.selectFields(Log__b.Message__c)
    ?.whereCriteria(new apxsp.Filter(Log__b.Logged_At__c, apxsp.Filter.EQUALS, loggedAtDt))
    ?.setRowLimit(1);
System.debug('\n\napxsp.SOQL:\n' + query.toString() + '\n' + JSON.serialize(query.run()) + '\n\n');
> apxsp.SOQL:
SELECT apxsp__Message__c FROM apxsp__Log__b WHERE apxsp__Logged_At__c = 2023-03-18T23:49:21Z LIMIT 1
[]

Cause: in Filter.cls, the query string is produced in part with the help of this method:
private String processDateTime(DateTime value) {
	final String soqlFormat = 'yyyy-MM-dd\'T\'HH:mm:ss\'Z\'';
	return value.formatGmt(soqlFormat);
}

this is missing the ms (SSS) values; should be  'yyyy-MM-dd\'T\'HH:mm:ss:SSS\'Z\'' instead.

This solution actually wasn't able to solve it. Adding SSS returns an error when running via SOQL (or deserializing into a DateTime of any type).
We were able to solve this problem through the new Database.queryWithBinds() method: https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_dynamic_soql.htm
Implementing this now in Soql.

Merged in #66


fix(versions): update Activiti/activiti-cloud-full-chart-security versions

UpdateBot pushed helm dependency: activiti-cloud-full-example to: 7.1.421

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-full-example 7.1.421


fix(openai-auth.ts): fix the default chrome path of windows

#112

@transitive-bullshit

https://github.com/transitive-bullshit/chatgpt-api/releases/tag/v2.3.2


change the pattern and color scheme of the contact us pages.

Description
make a nicer contact us page and follow color scheme.
Definition of Done

[x] All of the required items are completed.
[x] Approval by 1 mentor.

@codetheorem can I work on this?

Yes go for it.


Adding automated anvil testing client creation.

Adding automated anvil test running using vitest for premint sdk testing.

Current dependencies on/for this PR:

main

PR #322

PR #324   👈

This stack of pull requests is managed by Graphite.

from env vars or?
On Fri, Nov 3, 2023 at 17:20 Dan Oved @.***> wrote:

@.**** approved this pull request.
awesome discovery of how to get this to work, minor suggestions with
naming and configuration
In .github/workflows/foundry.yml
https://github.com/ourzora/zora-protocol/pull/324#discussion_r1382210316
:

@@ -135,6 +135,10 @@ jobs:
run: |
npx turbo run build

 - name: Test js package

   run: |

     npx turbo run test:js

nice!
In packages/protocol-sdk/src/anvil.ts
https://github.com/ourzora/zora-protocol/pull/324#discussion_r1382210821
:

 chain,

 transport: http(anvilHost),

});

const testClient = createTestClient({

 chain,

 mode: "anvil",

 transport: http(anvilHost),

});

const publicClient = createPublicClient({

 chain,

 transport: http(anvilHost),

});

await use({

great use of use
In packages/protocol-sdk/src/create/1155-create-helper.test.ts
https://github.com/ourzora/zora-protocol/pull/324#discussion_r1382211145
:

const demoTokenMetadataURI = "ipfs://DUMMY/token.json";
const demoContractMetadataURI = "ipfs://DUMMY/contract.json";
describe("create-helper", () => {

beforeEach(async () => {
await testClient.setBalance({

 address: creatorAccount,

 value: parseEther("1"),

});
});
afterEach(() => testClient.reset());

it(

anvilTest(

how about renaming to anvilRunningTest
In packages/protocol-sdk/src/anvil.ts
https://github.com/ourzora/zora-protocol/pull/324#discussion_r1382212222
:

});
+}

+export const anvilTest = test.extend({

viemClients: async ({task}, use) => {
console.log('setting up clients for ', task.name);
const port = Math.floor(Math.random() * 2000) + 4000;
const anvil = spawn(

 "anvil",

 [

   "--port",

   `${port}`,

   "--fork-url",

   "https://rpc.zora.co/",

   "--fork-block-number",

   "6133407",

how about allowing chain name (zora, or zora-sepolia) and blockNumber to
be specified as arguments with defaults?
—
Reply to this email directly, view it on GitHub
https://github.com/ourzora/zora-protocol/pull/324#pullrequestreview-1713542716,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGMCODM5IWX5U2K7ECKSETYCVN23AVCNFSM6AAAAAA635YKDGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJTGU2DENZRGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

from env vars or?
…
On Fri, Nov 3, 2023 at 17:20 Dan Oved @.> wrote: @.* approved this pull request. awesome discovery of how to get this to work, minor suggestions with naming and configuration ------------------------------ In .github/workflows/foundry.yml <#324 (comment)> : > @@ -135,6 +135,10 @@ jobs: run: | npx turbo run build + - name: Test js package + run: | + npx turbo run test:js nice! ------------------------------ In packages/protocol-sdk/src/anvil.ts <#324 (comment)> : > + chain, + transport: http(anvilHost), + }); + + const testClient = createTestClient({ + chain, + mode: "anvil", + transport: http(anvilHost), + }); + + const publicClient = createPublicClient({ + chain, + transport: http(anvilHost), + }); + + await use({ great use of use ------------------------------ In packages/protocol-sdk/src/create/1155-create-helper.test.ts <#324 (comment)> : > const demoTokenMetadataURI = "ipfs://DUMMY/token.json"; const demoContractMetadataURI = "ipfs://DUMMY/contract.json"; describe("create-helper", () => { - beforeEach(async () => { - await testClient.setBalance({ - address: creatorAccount, - value: parseEther("1"), - }); - }); - afterEach(() => testClient.reset()); - - it( + anvilTest( how about renaming to anvilRunningTest ------------------------------ In packages/protocol-sdk/src/anvil.ts <#324 (comment)> : > + }); +} + +export const anvilTest = test.extend({ + viemClients: async ({task}, use) => { + console.log('setting up clients for ', task.name); + const port = Math.floor(Math.random() * 2000) + 4000; + const anvil = spawn( + "anvil", + [ + "--port", + ${port}, + "--fork-url", + "https://rpc.zora.co/", + "--fork-block-number", + "6133407", how about allowing chain name (zora, or zora-sepolia) and blockNumber to be specified as arguments with defaults? — Reply to this email directly, view it on GitHub <#324 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMCODM5IWX5U2K7ECKSETYCVN23AVCNFSM6AAAAAA635YKDGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJTGU2DENZRGY . You are receiving this because you authored the thread.Message ID: @.***>

i would say for each test, to be able to config via json the fork chain name (or rpc url) and fork block #


Move field slip notes further down the form

coverage: 93.422%. remained the same
when pulling 54603fefc06b95cf7b28aeac20365590d5a5f876 on njw-tweak-field-slip-form
into 7dfda30c06fc29f53e702d56e526db3e21215b51 on main.


Merge work with similar project?

I just stumbled across this repository; it is a great contribution. I've been working on a similar library over the past few years, and have gotten some outside help in curating from the USGS and others. I think centralizing the basic symbols might be useful to avoid duplication of effort.
It would also be nice to have scripts for color changing etc., and provide a single location to aggregate derived or associated symbols (e.g. the entire map symbology for linework is rather untouched as yet).
Would you be open to evaluating overlap with the geologic-patterns repository, and potentially create a set of tools referencing these patterns? I'd like to figure out a strategy for building a functional and growing collection of geologic symbology; having other interested parties involved in this effort would be great!

Hi,
I just saw your comment. What do you think the overlap is? I converted all the Otago converted symbols and they can all also be changed to any brush color from within QGIS so that you don't need a script to do that.
It might make sense to have less duplication, but it seems your set is not specifically for QGIS in that regard?

I think the overlap is that, to the extent that there are FGDC symbols used in both projects, it might be nice to have the symbols themselves (i.e. the SVG files) stored centrally, and then used in various other tools for different platforms like QGIS. For patterns, we've gotten a few fixes added from the USGS to solve minor graphical bugs. A well-curated and centralized set of linework symbols is still needed.

Yes, I think you are correct on the overlap. It would be best to have a central location.  (finally go to this)
I spot checked a few svg across both, and the ones I have in this repository have much simpler/more compact xml as they were simplified at some point, for example all the same fill and stroke lines get grouped so there is only one fill/stroke per file instead of per path.
This header to start each stroke:
fill="none"
stroke="param(outline) #231f20"
stroke-width=".3"
versus:

In the past the second one did not work in QGIS to change the colors, but it seems to now, I think. I don't know how the parser works so I don't know which is computationally more efficient.
can your applications handle the param() declaration?
Maybe It might be easiest to centralize the fixed color ones and have the QGIS parameterized ones pulled out separately?
Yes, the line styles need to be fixed too. I found some here: https://sourceforge.net/projects/qgisgeologysymbology/files/
But, it looks like these guys have superseded me:
https://github.com/BC-Consulting/FGDC-4-QGIS


Compilation error when compiling .tsx with generics.

Hi, I think I found a bug, but it might be just misconfiguration.
I'm trying to use parcel with this plugin to bundle a Surplus.js app written in Typescript.
The problem can be reproduced with this tsx file:
import * as Surplus from "surplus";
let a: Array<number> = [1, 2, 3];

The error I get when trying to run parcel on this project:
project_path>yarn parcel build src/index.html
yarn run v1.7.0
$ project_path/node_modules/.bin/parcel build src/index.html
×  project_path/src/main.tsx: element missing close tag at line 1 col 12: ``<number> = [1, 2, 3];''
    at ERR (project_path/node_modules/surplus/compiler/index.js:374:15)
    at jsxElement (project_path/node_modules/surplus/compiler/index.js:165:17)
    at program (project_path/node_modules/surplus/compiler/index.js:92:31)
    at parse (project_path/node_modules/surplus/compiler/index.js:84:12)
    at Object.compile (project_path/node_modules/surplus/compiler/index.js:1540:45)
    at TSAsset.pretransform (project_path/node_modules/parcel-plugin-surplus/lib/surplus-asset.js:20:39)
    at TSAsset.process (project_path/node_modules/parcel-bundler/src/Asset.js:202:18)
    at <anonymous>
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This seems like the tsx source is ran through the surplus compiler before being compiled by the ts compiler, and the surplus compiler thinking this is a JSX starting tag.
Do you think this is a bug, and if it is, can it be fixed?

Hi @Sh4rK! it's true, i'm going to do some tests about running surplus after ts using "jsx": "preserve" thanks for reporting this

Cool, thanks!

Hi @Sh4rK, can you try the new version?

sorry i forgot, you need to add a configuration in your tsconfig.json
https://github.com/tinchoz49/parcel-plugin-surplus#for-typescript-users

It seems to work great, thanks for the really quick fix! :)

(It's funny that fixing this was actually removing the TS specific parts :) )

haha yes, it's true. The issue is that parcel first runs TS and then runs the result with the JS asset. I didn't know that, so basically I was compiling surplus twice.
The other issue was that surplus only compiles JS so it's necessary to compile the TypeScript code first and then runs the Surplus compiler.
Thanks for reporting it!


implemented partial inference of column_types

This is now possible:
    valid_df = pd.DataFrame({"categorical_column": ['turtle', 'crocodile', 'turtle'],
                         "text_column": ['named Giskard', 'a nile crocodile', 'etc'],
                         "numeric_column": [15.5, 25.9, 2.4]})
    valid_df_column_types = {'categorical_column': 'category', 'text_column': 'text', 'numeric_column': 'numeric'}

    column_types = {'categorical_column': 'text'}
    expected_df_column_types = {'categorical_column': 'text', 'text_column': 'text', 'numeric_column': 'numeric'}

    # Option 1: only one column in column_types is provided
    my_dataset = Dataset(valid_df, column_types=column_types)
    assert my_dataset.column_types == expected_df_column_types

    # Option 2: one column in column_types is provided, one in cat_columns
    my_dataset = Dataset(valid_df, column_types=column_types, cat_columns=['categorical_column'])
    assert my_dataset.column_types == valid_df_column_types

Just noticed that some tests fail with
ValueError: The provided keys ['target'] in 'column_types' are not part of your dataset 'columns'. Please make sure that the column names in `column_types` refers to existing columns in your dataset.

Maybe we should get rid of this. When it’s about the target, this is also confusing because it is part of the dataframe that the user put in, so from their point of view the message may be confusing.
It’s good to raise a warning, but in my opinion if we can continue execution we should do it. In a case like this, it means that the user specified extra column types, in principle we have all what we need to create the dataset, and can just throw a warning saying
WARNING: The column types for `feature_a`, `feature_b` were not taken into account since these columns were not found in the dataframe.

This error was mainly raised in the above because I removed by mistake this line:
column_types.pop(self.target, None)  # no need for target type

Otherwise, I think it's a useful error, In case the user-provided columns in column_types assuming they have them in their df, but turns out that they don't... that could be seen as a debugging message to investigate the df.

Otherwise, I think it's a useful error, In case the user-provided columns in column_types assuming they have them in their df, but turns out that they don't... that could be seen as a debugging message to investigate the df.

I agree but I think a warning would be better for this case, since it is not a fatal problem.


WIP Mark IAggregableReduceOp as Serializable.

What changes were proposed in this pull request?
Mark IAggregableReduceOp as Serializable to fix running Reducers on Spark.
How was this patch tested?
Can someone add unit tests please?

Fixes #326

@agibsonccc Is this test OK? It might be a little fragile.  Open to ideas.


chore: add Kubernetes 1.24 to the matrix of tests

Introduce Kubernetes 1.24.2 (latest at this time) in the matrix of
Kubernetes distributions to be tested.
Update E2E tests to use the latest available kind and k3s
available images for testing.
Update supported releases page for 1.16, 1.17 and 1.18.
Closes #333
Signed-off-by: Gabriele Bartolini<EMAIL_ADDRESS>

/test

/test

/test


APT whitelist request for libstdc++6:i386

As suggested at https://github.com/travis-ci/travis-ci/issues/3701#issuecomment-123438410

libstdc++6:i386 does not appear to a package name on which our automation process can handle.
APT packag request should be made for exactly one package, according to the form specified in
https://github.com/travis-ci/apt-package-whitelist#package-approval-process.
If the source package of your requested package contains other related packages, you do not
have to open another one for those.
(When in doubt, do.)

Ran tests and found setuid bits by purely textual search. Further analysis is required.

See https://travis-ci.org/travis-ci/apt-whitelist-checker/builds/72365320.


[Epic] New WOPI Server

Implement a WOPI Server following the WOPI protocol specification as described here: https://learn.microsoft.com/en-us/microsoft-365/cloud-storage-partner-program/rest/
This new WOPI Server should be written in Golang and can be based on Willy Klouceks work in https://github.com/wkloucek/cs3-wopi-server/
The new server does not have to maintain oC10 compatibility.
The most important collaborative editor applications for the WOPI are

OnlyOffice
Collabora office
Microsoft Office 365

other applications should be integrated later, such as

CodiMD
...

Locking is mandatory utilizing the oCIS locking API.
Extra features
The following extra features would add considerable benefit:

Stateless: No permanent storage needed (if possible)
Simple to extend if needed to connect other collaborative editors
Good runtime debugging capabilities through comprehensive loggings
Audit functionality (ie. which documents were opened/closed when) based on events via NATS (already existing)

Definition of done

[ ] Functional requirements

Quality Assurance

[ ] CI based test suite that runs different testing scenarios
[ ]  Successful WOPI validation tool
[ ] Manual tests with oCIS and the main editors

Deployment
The new WOPI Server does have the following deployment requirements:

[ ] Deployable in the single binary. Included in the default build.
[ ] Simple to deploy on a "developer machine" to work on it
[ ] Good docker/kubernetes "support", health endpoint, using the micro service registry, should survive restarts,
[ ] metrics

TBD

Documentation
The following documentation related work has to be delivered:

Documentation for the Dev-Docs about

[ ] Development setup
[ ] Docker deployment
[ ] Kubernetes considerations

Input for the administrator documentation written by docs team

References

https://github.com/owncloud/enterprise/issues/3639
https://jira.owncloud.com/browse/OCIS-406
https://github.com/pydio/cells/tree/main/gateway/wopi

@hodyroff @wkloucek @DeepDiver1975 @micbar FYI

Nice! Thanks.
@jvillafanez ocis team is supporting you.

Probably the current state is "good enough" (I personally love it!) with the upcoming oCIS 7.0.0 release. Please reopen and highlight what's still open if needed.


fixed issue show clock badge on Activity Bar icon when tests are running

https://github.com/microsoft/vscode/issues/201982
Proposed Changes:

The script introduces error handling improvements to prevent runtime errors related to accessing undefined properties. Specifically, it checks whether clockIcon.element is undefined before creating the NumberBadge instance. If the element is undefined, it logs an error message to the console.

The code is organized into two classes, TestingProgressUiService and TestingProgressTrigger, to encapsulate related functionality. This improves code readability, maintainability, and separation of concerns.

The code utilizes TypeScript's type system to enforce type safety and prevent type-related errors. This ensures that the code adheres to TypeScript's strict type checking rules and enhances the overall reliability of the application.

Testing Instructions:

To test the error handling improvement, deliberately set clockIcon.element to undefined before invoking the updateActivityBarIcon method. Then, observe whether the error message is logged to the console as expected.

Review the code structure and verify that related functionality is encapsulated within the appropriate classes (TestingProgressUiService and TestingProgressTrigger). Ensure that each class has a clear responsibility and adheres to the single responsibility principle.

@AvaVellozzi please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company=Ava Vellozzi]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@AvaVellozzi please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="Ava Vellozzi"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

We should be able to use the IProgressService for this, we should not need to interact directly with the activity bar. The UnmanagedProgress class may be a useful utility.


chore(cli): structop to clap migration

structopt to clap Migration
Warning: I can't run Isograph locally because I'm on Linux and there are some issues getting that working, so this could use testing to make sure the commands actually still works!
But the help command outputs very similar stuff, and it compiles, which is a very good sign when working with Rust 😁
What

Migrates CLI from the stuctopt crate (which is deprecated) to clap in preparation for work in #68
Renames the Command enum to Commands to align with clap conventions

How

Followed migration guides:

For structopt to clap v3: https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#migrate-structopt
For clap v3 to v4: https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#migrating

Screenshots
Before

After

LGTM!!! Thank you for taking this on!
Most of the other enums are named singularly (e.g. enum DeserializationError not enum DeserializationErrors) but I can just revert that name change in main


Add missing "delete account" French translations

Add missing "delete account" French translations
Type of change

[x] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[x] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[ ] npm test runs as expected.
[ ] npm run build runs as expected.

Thanks for your contribution @selimjouan :)

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Update vertex-level simulation

The old simulation compared OMNI to {MASE, vertex-level network statistics}

Proposed changes
Modify the algorithms being compared:

Add MDMR, DBS
Rename vertex-level network statistics -> exponential random graph model
Remove MASE

Performance metrics:

Replace the three separate plots per row with an ROC curve

Also include different p-value correction methods:

Compare Bonferroni, Bonf-Holm, Benj-Hoch, Benj-Yeku


Seems to be incompatible with iCloud Drive

When iCloud Drive is enabled, after reboot, the links will be replaced respectively by the directories Desktop and Documents and the links moved inside those folders.
Right after install of MacOS-OneDrive-KFM and before reboot:
/Users/me/Desktop -> /Users/me/OneDrive - Company, Inc/Desktop
/Users/me/Documents -> /Users/me/OneDrive - Company, Inc/Documents

After reboot:
/Users/me/Desktop/Desktop -> /Users/me/OneDrive - Company, Inc/Desktop
/Users/me/Documents/Documents -> /Users/me/OneDrive - Company, Inc/Documents

Turning off iCloud Drive seems to fix this.
Br,
ANx

Hi
Before installing I was wondering if this would work with iCloud drive as I would love to have the files synced to iCloud and On Drive if at all possible. It might be over kill but I am generally using my Desktop for One Drive and Documents for iCloud.
Many thanks for any help.

It has not been tested with iCloud.  I would bet it will not work correctly.  As this uses sym links and iCloud uses a native API.  FYI though OneDrive is moving to support this nativity this fall.  We will work on an “uninstaller” so that a transition can be made to the supported process.

Thanks for responding. I did assume both couldn’t be used simultaneously on the same folders. It’s great to hear Microsoft are going native. Do you have a link to that feature so I can monitor its release.

Here is the Microsoft anouncment: https://techcommunity.microsoft.com/t5/microsoft-onedrive-blog/microsoft-works-to-ensure-a-great-onedrive-experience-on-apple/ba-p/2400803


Crash when running a simple query with where clause for partitionKey

Open client
Browse to a document collection
Right click and choose query documents
select * from c where c.partitionKey <> "somevalue" -- in my case some value is a guid
Execute query
Crash below

System.AccessViolationException was unhandled
Message: An unhandled exception of type 'System.AccessViolationException' occurred in Microsoft.Azure.Documents.Client.dll
Additional information: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.

I have similar problem, when trying to execute query against partitioned db:
select * from c WHERE c.PartitionKey = "1"

I receive
System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.Azure.Documents.Query.QueryPartitionProvider.GetPartitionedQueryExecutionInfo(SqlQuerySpec querySpec, PartitionKeyDefinition partitionKeyDefinition)
   at Microsoft.Azure.Documents.Routing.PartitionRoutingHelper.GetProvidedPartitionKeyRanges(SqlQuerySpec querySpec, Boolean enableCrossPartitionQuery, Boolean parallelizeCrossPartitionQuery, PartitionKeyDefinition partitionKeyDefinition, QueryPartitionProvider queryPartitionProvider, String clientApiVersion, QueryInfo& queryInfo)
   at Microsoft.Azure.Documents.Query.DefaultDocumentQueryExecutionContext.<TryGetTargetPartitionKeyRangeAsync>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.Documents.Query.DefaultDocumentQueryExecutionContext.<ExecuteOnceAsync>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.Documents.BackoffRetryUtility`1.<>c__DisplayClass2.<<ExecuteAsync>b__1>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.Documents.BackoffRetryUtility`1.<ExecuteRetry>d__16.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.Documents.BackoffRetryUtility`1.<ExecuteAsync>d__7.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.Documents.Query.DocumentQueryExecutionContextBase.<ExecuteWithRetryPolicy>d__1b.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.Documents.Query.DefaultDocumentQueryExecutionContext.<ExecuteInternalAsync>d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.Documents.Query.DocumentQueryExecutionContextBase.<ExecuteNextAsync>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.Documents.Linq.DocumentQuery`1.<ExecuteNextPrivateAsync>d__17`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Microsoft.Azure.DocumentDBStudio.DocumentCollectionNode.<QueryDocumentsAsync>d__32.MoveNext() in f:\git\DocumentDB-studio\DocumentDBStudio\TreeNodes.cs:line 913

I suspect I'm running into similar issue:
http://stackoverflow.com/questions/43985540/documentdb-client-1-14-kills-running-process


background_image

When using Asciidoctor PDF 1.5.0.beta.1 using Asciidoctor 2.0.10 [https://asciidoctor.org]
title_page:
background-image: image:images/title.png[]
is used on every other page of generated pdf.
1.5.0.alpha.18 doesn't have this issue.

Sorry, this was a mistake, the issue is already logged at https://github.com/asciidoctor/asciidoctor-pdf/issues/1144

Yep. The fix will be in beta.2.


Set testcase for range of tests when using t.Run.

Description
Noticed a bug where we aren't setting the testcase when ranging over a set of testcases with t.Run.
Documentation

TODOs

[ ] Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
[ ] Update the docs.
[ ] Keep the changes backwards compatible where possible.
[ ] Run the pre-commit checks successfully.
[ ] Run the relevant tests successfully.
[ ] Ensure any 3rd party code adheres with our license policy: https://www.notion.so/gruntwork/Gruntwork-licenses-and-open-source-usage-policy-f7dece1f780341c7b69c1763f22b1378
[ ] Maintainers Only. If necessary, release a new version of this repo.
[ ] Maintainers Only. If there were backwards incompatible changes, include a migration guide in the release notes.
[ ] Maintainers Only. Add to the next version of the monthly newsletter (see https://www.notion.so/gruntwork/Monthly-Newsletter-9198cbe7f8914d4abce23dca7b435f43).

Related Issues

Great, thank you for the review, going to merge now.


negative margin (spacing hack) can block interaction with surrounding content

Ideally, detect grid gap support and use that, otherwise fallback to margin hack, or maybe fallback to fixing it with js, or maybe fallback to no spacing at all :)

flex-gap-polyfill handles this by disabling pointer-events on the flex parent and re-enabling them on the children. Implementing spacing via grid gap and using that polyfill for flex gap support in Safari and older environments seems like the way to go for now. Disabling pointer events means pointer events won't work on an element that has spacing, so that will be an unfortunate caveat until Safari 14 and below are scarcely used.


Add a generic Events API

An events API can be used to surface interesting and critical events targeted towards a cluster admin and also individual users. Here is a sample list of events:

Crash looping pods/containers
Pods which get CPU throttled
Pods/containers that don't make any progress - critical for best effort tasks.
Wasted resources for containers - limits too high when compared to historical utilization.
Anomalies across pods with similar Spec (Controllers like Replication, daemon, etc) - Abnormal utilization (possibly due to network issues), suggestion for limits; if application metrics are made available, anomalies can be detected across those metrics as well
Cluster utilization - events on low and high thresholds
Node flipping - flapping between ready and notready states
.....

@afein: Kindly add other use cases that I might have missed here.

Out of the scope of Heapster.


Part of Cerebellum missing in "desc-preproc_T1w" but not in "T1.mgz" (from freesurfer)

When T1.mgz (256x256x256) from the Freesurfer directory is converted to "*desc-preproc_T1w" (192x256x164), part of the cerebellum is removed in some of the subjects:

(Further, the cerebellum then gets distorted in the "*_space-MNI152NLin2009cAsym_desc-preproc_bold.nii.gz" image, an issue I believe is related part of Cerebellum missing in "*desc-preproc_T1w")
Any help would be highly appreciated.

Can you explain what you mean by converting T1.mgz to desc-preproc_T1w.nii.gz? What command are you running?

Sorry about the confusion, the command I run is:
fmriprep $datadir/ ${destdir}/ participant -w ${workdir}/ --ignore {fieldmaps,slicetiming,sbref} ${distortionCorrection} ${templateResamplingGrid} --participant_label ${subId} --nthreads $nthreads

Okay. I'm a little confused, as we don't do any cropping of T1w images.
Is there a chance you could share your T1w.nii.gz from your source dataset, the desc-preproc_T1w.nii.gz from the fMRIPrep outputs, and your corresponding T1.mgz from the FreeSurfer directory? (All defaced, of course.)

I found it strange as well, because I didn`t see any reason why you would want to crop the images.
That sounds like a plan, thank you for being willing to look at them. Where do you want the files uploaded?

I don't think I have somewhere to anonymously upload, so whatever you feel comfortable with. OnionShare, if you're feeling paranoid. :-)

I'm running this now to see if I can reproduce using fMRIPrep 1.3.1.

I would suggest double-checking sure that your source dataset has a good T1w image, and then re-run with a fresh working directory (you can use --anat-only --output-space T1w to limit it to just running the basic T1w preprocessing) to see if you still produce this error.
Incidentally, what version of fMRIPrep are you using? We generally recommend people who've started preprocessing on one version stick with it unless errors make upgrading necessary, so if you have the time, it would be good to test with the version you've been using and make sure that it is replicable before upgrading.

Again, thank you so much. Ill try to run the analysis again using --anat-only --output-space T1w and my current version of fmriprep. Im using fmriprep v1.2.5.

I now found out that is was an error in one of my scripts, sorry about that. The script copied some old T1 files, that I was sure that I had deleted, with part of the cerebellum missing instead of the correct T1 files used in freesurfer. Thank you again for all the help and a quick reply, I highly appreciate it. Next time I`ll do a more thorough investigation of my own scripts and data used before asking.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Found another case of some typing errors that are correlated with JSII using an old version of TypeScript. Technically there is a bug in upstream (https://github.com/aws/aws-sdk-js-v3/issues/3297), but using a new TypeScript version a la https://github.com/aws/aws-cdk-rfcs/pull/373 would also have avoided this issue


Consider NOT caching ~/.cache/baze/ on our Docker builds

We currently cache all of ~/.cache/ on our Docker Linux builds:
https://github.com/googleapis/google-cloud-cpp/blob/c8e235437e944b4a8623f7e554586ef4100df2cc/ci/kokoro/docker/upload-cache.sh#L42-L43
That directory includes bazel's cache, and that can be ~9GB in my experiments (probably bigger too). We're already using GCS as a remote cache for bazel
https://github.com/googleapis/google-cloud-cpp/blob/c8e235437e944b4a8623f7e554586ef4100df2cc/ci/kokoro/docker/build-in-docker-bazel.sh#L69
So we effectively have two caches of bazel's data.
We should consider no longer caching all of ~/.cache/ and instead only caching specific subdirectories, like ~/.cache/vcpkg.
HOWEVER...
It's possible that this may slow down the bazel builds. I'm not sure if we get a performance win by downloading bazel's local cache in one go rather than piece-by-piece as I think will happen with the "remote_cache". But there's one way we can find out -- we could try it! :-)

Fixed in https://github.com/googleapis/google-cloud-cpp/pull/5822


ARM cortex M0 design question

Hi,
I was able to port the C code to an Arm Cortex M0. The device does not have a Memory Protection Unit, I was trying to understand the implications for the deferencing issue on NULL pointers but as I am new to it and since library is meant to be used with M0 devices as well I want to check with you.
Do you know how this will affect the scheuler and what issues I can expect?
Here is the section code I have commented.

I will appreciate your comments,
Thank you,

SST has been running on the M0/M0+ for a long time, so there was not much "porting" except compiling the core SST code.
The BSP (Board Support Package) might require some adjustements because this part is really specific to the board/MCU type. In the absence of the MPU, you can skip the "NULL-pointer protection". NULL-pointer dereferencing should never happen in a correct program, so it will run correctly. But, of course, it will not catch the mistakes.
--MMS

Hi @quantum-leaps ,
Thank you for your response, yeah BSP is the section that have the code changes.
I have a working SST example for a different MCU vendor, I want to check weather you would like to include the example in your repository or not.
The other thing I would like your thoughts is about implementing the lock for task, since it is a Cortex M0, how do you rise the priority of the current task? The section is TBD in the sources.

I will appreciate your response,
Manuel

Unfortunately, Cortex-M0/M0+ (ARMv6-M architecture) is the least appropriate CPU for the SST (the hardware RTOS). This is because the ARMv6-M hardware is so limited. There is no BASEPRI register to lock the hardware "scheduler" only up to a given priority ceiling. And also the ARMv6-M NVIC with just 2 bits of interrupt priority is very limited and just barely adequate to do any prioritization of tasks.
Compare this to ARMv7-M or ARMv8-M architectures (all other Cortex-M) with the BASEPRI register and with 3 or 4 bits of NVIC priority. This is the proper hardware for a hardware RTOS.
So, the bottom line is that with literally thousands of Cortex-M MCUs available on the market, there is no shortage of proper hardware choices for SST. Choosing the M0/M0+ is just missing the point. I wouldn't sweat the Cortex-M0.
Finally, if you'd like to contribute your BSP to the SST repo, please make a pull request.
--MMS

Hi @quantum-leaps ,
Agree.
Quick question about SST task handling, what are the options for a task to delay the processing of events until a previous event is completed?
I will appreciate your guidance.
Thank you,

Hi Manuel,
SST is fundamentally an event-driven, non-blocking kernel, so SST does not have any blocking primitives, such as the delay() function. Instead, SST provides the time events (see the SST_TimeEvt). A time event is an event that the application can request to be delivered after the specified timeout in the future. Please see the Blinky example to see how to use such time events.
--MMS

Hi Miro,
I am already familiar with it as I have used to migrate some of the existing code for the platoform I am working with.
I would need to rethink of a way to do it using the time events. For a moment I thought i was able to reschedule the event when the task is busy, but the time event does not allow to specify some parameters for my task.
Basically I am triggering the event from another task such as

In this case the event contains the message which is the clock time (from SNTP task).
But it might be the case that the led matrix task is busy (i.e. scrolling a text).  This case might be silly as probably discarding the event is the reasonable approach.
But what if I want to enqueue a couple of different scroll text messages? i.e.

The first message trigger the scroll task but as soon as the second event is received I can either restart scrolling with new text or discard the message.
Here is my source code in case you want to have a look.
Thank you,
Manuel

Hi Manuel,
In SST events are posted by pointers, so the actual events are all shared among concurrent entities (ISRs and SST tasks). Such sharing is safe when events are immutable, such as the events demonstrated in all SST examples. However, you are using a mutable events, which are another story entirely. Currently, SST does not support mutable events.
Your way of posting an event (you call it "triggering an event") is potentially dangerous because your fInitDoneEvt is modified in one task and then it is processed in another concurrent task (mutable event). But you have no guarantee that the processing will not be preempted and the event will be modified again. In other words, this is the classic data race.
Proper handling of mutable events is not trivial. One example of an efficient and reasonably elegant solution is provided in the QP Framework. QP Framework is also event-driven and works well with non-blocking kernels. You might also take a look at the QK kernel, which works very much like the SST.
--MMS


Unsubscribe?

Does the subscriber have to call Unsubscribe in order to prevent memory leaks (as the EventAggregator is registered as a singleton)?

According to my test, it seems that yes. A component subscribing itself to the event aggregator (as shown in the documentation) should implement IDisposable and then unsubscribe itself. Otherwise, its handler will still be called event if the user has navigated to another page.

Yeah it needs to unsubscribe at IDisposable.Dispose at each listening component.

@dodyg is there a way to automatically unsubscribe on each listening component? Or is it required to manually put that logic in each component? Is there an example of how you unsubscribe at IDisposable.Dispose for Blazor Server?

This is the pattern I am using in each of the component that cares
@implements IDisposable
@implements EventAggregator.Blazor.IHandle<JobNominationPagingInfo>

   protected override async Task OnInitializedAsync()
   {
        base.SubscribeEvents();
   }

    public Task HandleAsync(JobNominationPagingInfo pi)
    {
        return Task.CompletedTask;
    }

    public void Dispose()
    {
        base.UnsubscribeEvents();
    }

Thanks. I'm using a code behind file so I think that solution would look something like the following...
public partial class FooPage : IHandle<FooMessage>, IDisposable
{
	protected override void OnInitialized()
	{
		EventAggregator.Subscribe(this);
	}

	public void Dispose()
	{
		EventAggregator.Unsubscribe(this);
	}
}

Is disposing still necessary if EventAggregator is added as a scoped service?

There is no such thing as Scoped service in Blazor. It's either Singleton or Transient.

https://docs.microsoft.com/en-us/aspnet/core/blazor/fundamentals/dependency-injection?view=aspnetcore-5.0&pivots=server

Blazor WebAssembly apps don't currently have a concept of DI scopes. Scoped-registered services behave like Singleton services.
Registering a dependency as Scoped in Blazor Server will result in dependencies that live for the duration of the user’s session. Instances of Scoped dependencies will be shared across pages and components for a single user, but not between different users and not across different tabs in the same browser.
It sounds like a scoped service is what I want for my EventAggregator. I don't want a singleton because I don't want a single instance for all users, across all tabs/browsers.
And I don't want transient because it isn't necessary to obtain a new instance of the EventAggregator for each component.
Thoughts?

Maybe the disconnect is you are using WebAssembly and I'm using Server...

You can use EventAggregrator in scoped in Blazor Server but you still have to subscribe and unsubscribe.

Ok. And I'm able to register it as a scoped service by doing the following:
services.AddScoped<EventAggregator.Blazor.IEventAggregator, EventAggregator.Blazor.EventAggregator>();
but I'm struggling to determine how to set AutoRefresh = true when using the method above. Do you know how I could accomplish that?

https://github.com/mikoskinen/Blazor.EventAggregator#note-about-auto-refresh

My issue was the order. I initially had:
services.AddScoped<EventAggregator.Blazor.IEventAggregator, EventAggregator.Blazor.EventAggregator>();
services.AddEventAggregator(options => options.AutoRefresh = true);

which caused IEventAggregator to be registered as a singleton which for Blazor Server is not desirable.
Switching to the following is seems to be the workaround:
services.AddEventAggregator(options => options.AutoRefresh = true); // this registers as a singleton
services.AddScoped<EventAggregator.Blazor.IEventAggregator, EventAggregator.Blazor.EventAggregator>(); // now register as scoped

Thanks!


Replace AWS Reference Architecture

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Brenna Buuck seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Added Studio and Lang support Closes #4 and #1

Added Studio and Lang pages

filtering script expanded for language page
studios share filter script with facilities

Added automation for building all future templates

moved each page template to it's own build script
all triggered by the main build.js

Closes #4

Please hold off on accepting, have a few more updates to make.

Ready for final reviews and merge if desired. Any further features will be a new branch.

Can this be done in a way where the node executable isn't invoked? Simple function calls should suffice.
Can the templating system be leveraged to eliminate the redundancy across all pages? That is, they all share common headers, footers. Those ideally would appear in one place.
Ajv is no longer needed in package.json and package-lock.json

Can this be done in a way where the node executable isn't invoked? Simple function calls should suffice.
Can the templating system be leveraged to eliminate the redundancy across all pages? That is, they all share common headers, footers. Those ideally would appear in one place.
Ajv is no longer needed in package.json and package-lock.json

@radford-for-smpte
1- Done, templated the build JS into a loop, rather than external JS and calls as suggested. Object added for each registry definition.
2- Done! I agree, much better!
3 - Done.
@palemieux
See current commit as discussed. The PDF generation is buggy with the looping rather than calling in each separate JS. The facility PDF never generates, and the language one does about 70% of the time, the studio does every time.

Can this be done in a way where the node executable isn't invoked? Simple function calls should suffice.
Can the templating system be leveraged to eliminate the redundancy across all pages? That is, they all share common headers, footers. Those ideally would appear in one place.
Ajv is no longer needed in package.json and package-lock.json

@radford-for-smpte
1- Done, templated the build JS into a loop, rather than external JS and calls as suggested. Object added for each registry definition.
2- Done! I agree, much better!
3 - Done.
@palemieux
See current commit as discussed. The PDF generation is buggy with the looping rather than calling in each separate JS. The facility PDF never generates, and the language one does about 70% of the time, the studio does every time.

I suspect this is due to the process.exit() :)

@palemieux
See current commit as discussed. The PDF generation is buggy with the looping rather than calling in each separate JS. The facility PDF never generates, and the language one does about 70% of the time, the studio does every time. Weird as hell.

@palemieux I suspect this is due to the process.exit() :

@palemieux
See current commit as discussed. The PDF generation is buggy with the looping rather than calling in each separate JS. The facility PDF never generates, and the language one does about 70% of the time, the studio does every time. Weird as hell.

@palemieux I suspect this is due to the process.exit() :)

Oi vey, I missed that... yep, that was it. New commit coming in a moment...

OK gents @radford-for-smpte @palemieux all good to go for review now. Thanks for the help Mike!

I believe this is an incorrect use of the  tag. It's currently at the top-level of the html. Additionally,  closes mid-. And  closes before .
Suggestion: each top-level .hbs should contain it's own opening and closing body tag, and should eliminated the header tag. Split header.hbs into: head.hbs which includes its own ..., and maybe `

I believe this is an incorrect use of the  tag. It's currently at the top-level of the html. Additionally,  closes mid-. And  closes before .
Suggestion: each top-level .hbs should contain it's own opening and closing body tag, and should eliminated the header tag. Split header.hbs into: head.hbs which includes its own ..., and maybe top.hbs which includes the nav, etc. It would not include the opening  tag.

It's really a matter or preference, as I usually go the route of minimum amount of code on each template page, so no one can mess up the overall design. The header element just defines a section for the reader, it doesn't control anything. Works well for cross platform and mobile. I also tend to just keep the main table for people to edit, but containing everything else in the shared header. This same method is used for example in Wordpress, so you can change out the overall body or design quickly compared to the main content.
That being said, happy to accommodate to make it easier for other people to parse it out.

I believe this is an incorrect use of the  tag. It's currently at the top-level of the html. Additionally,  closes mid-. And  closes before .
Suggestion: each top-level .hbs should contain it's own opening and closing body tag, and should eliminated the header tag. Split header.hbs into: head.hbs which includes its own ..., and maybe top.hbs which includes the nav, etc. It would not include the opening  tag.

It's really a matter or preference, as I usually go the route of minimum amount of code on each template page, so no one can mess up the overall design. The header element just defines a section for the reader, it doesn't control anything. Works well for cross platform and mobile. I also tend to just keep the main table for people to edit, but containing everything else in the shared header. This same method is used for example in Wordpress, so you can change out the overall body or design quickly compared to the main content.
That being said, happy to accommodate to make it easier for other people to parse it out.

Well the suggestions were really about how to resolve the core issue which is the out-of-order tags within the final HTML. Take a look at the final render and see that  closes mid-. And  closes before . I'm ok w/ any solution that resolves those issues.

I believe this is an incorrect use of the  tag. It's currently at the top-level of the html. Additionally,  closes mid-. And  closes before .
Suggestion: each top-level .hbs should contain it's own opening and closing body tag, and should eliminated the header tag. Split header.hbs into: head.hbs which includes its own ..., and maybe top.hbs which includes the nav, etc. It would not include the opening  tag.

It's really a matter or preference, as I usually go the route of minimum amount of code on each template page, so no one can mess up the overall design. The header element just defines a section for the reader, it doesn't control anything. Works well for cross platform and mobile. I also tend to just keep the main table for people to edit, but containing everything else in the shared header. This same method is used for example in Wordpress, so you can change out the overall body or design quickly compared to the main content.
That being said, happy to accommodate to make it easier for other people to parse it out.

Well the suggestions were really about how to resolve the core issue which is the out-of-order tags within the final HTML. Take a look at the final render and see that  closes mid-. And  closes mid-. I'm ok w/ any solution that resolves those issues.

Understood that, again it was a preference thing to use the  and  tags, not inherently wrong per se. I was able to do the pretty formatting and do what I wanted by swapping for comments instead. Check that out.

Check that out.

Looks great! A few issues I see:

Each template uses {{idType}} inside the #data loop. You have to use ../idType to get the context above the current loop (currently it's undefined)
The attribute id=clear-filter is used multiple times in the HTML.
There's an extra 	 on each row of languages.html.
Can you update the scheme to https for the JSON Feed links?

Check that out.

Looks great! A few issues I see:

Each template uses {{idType}} inside the #data loop. You have to use ../idType to get the context above the current loop (currently it's undefined)
The attribute id=clear-filter is used multiple times in the HTML.
There's an extra 	 on each row of languages.html.
Can you update the scheme to https for the JSON Feed links?

Good catch! I was using those id's for something else and left them in for possible future use, so I wasn't checking them. Fixed.
That is intentional. Those are used by the onclick() to clear out the filter in the upper right when clicking to item that obsoletes current item searched on (or any other search). I also have a clear "x" button next to the field that clears the filter. They are only on internal page hrefs.
Good catch, bad copy/paste when doing the templates.
Done.

That is intentional. Those are used by the onclick() to clear out the filter in the upper right when clicking to item that obsoletes current item searched on (or any other search). I also have a clear "x" button next to the field that clears the filter. They are only on internal page hrefs.

Since HTML disallows duplicate IDs, can you use a class instead?

That is intentional. Those are used by the onclick() to clear out the filter in the upper right when clicking to item that obsoletes current item searched on (or any other search). I also have a clear "x" button next to the field that clears the filter. They are only on internal page hrefs.

Since HTML disallows duplicate IDs, can you use a class instead?

Fair enough! Done.

Shall we get this PR out, so we can focus on other items, as mentioned today in the ISDCF meeting, and others (Mike your question re the external file, can we move that out for this for now)?

(Mike your question re the external file, can we move that out for this for now)?

Yep I'm good with that.

Are there supposed to be two "X" buttons visible to clear the search box?

Are there supposed to be two "X" buttons visible to clear the search box?

The native X in the form field only clears the field itself, not the filtering applied via the function. Remember, it's not a search per se, it's filter the results. I cannot yet find a way to remove the native field's X.

Are there supposed to be two "X" buttons visible to clear the search box?

The native X in the form field only clears the field itself, not the filtering applied via the function. Remember, it's not a search per se, it's filter the results. I cannot yet find a way to remove the native field's X.

Actually, I might have just figured it out. Pushing commit in a few mins.

git clone https://github.com/ISDCF/registries-site.git
git submodule update --recursive --remote --init
npm install
npm run build

results in
><EMAIL_ADDRESS>build C:\Users\pal\Documents\registries-site
> node src/main/scripts/build.js

Building facilities started
Building languages started
Building studios started
Error: Command failed: git submodule status external/registries
C:/Program Files/Git/mingw64/libexec/git-core\git-submodule: line 22: .: git-sh-setup: file not found

    at ChildProcess.exithandler (child_process.js:303:12)
    at ChildProcess.emit (events.js:315:20)
    at maybeClose (internal/child_process.js:1021:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5) {
  killed: false,
  code: 1,
  signal: null,
  cmd: 'git submodule status external/registries',
  stdout: '',
  stderr: 'C:/Program Files/Git/mingw64/libexec/git-core\\git-submodule: line 22: .: git-sh-setup: file not found\n'
}
...
(node:44896) UnhandledPromiseRejectionWarning: Error: Page crashed!
    at Page._onTargetCrashed (C:\Users\pal\Documents\registries-site\node_modules\puppeteer\lib\Page.js:213:24)
    at CDPSession.<anonymous> (C:\Users\pal\Documents\registries-site\node_modules\puppeteer\lib\Page.js:122:56)
    at CDPSession.emit (events.js:315:20)
    at CDPSession._onMessage (C:\Users\pal\Documents\registries-site\node_modules\puppeteer\lib\Connection.js:200:12)
    at Connection._onMessage (C:\Users\pal\Documents\registries-site\node_modules\puppeteer\lib\Connection.js:112:17)
    at WebSocket.<anonymous> (C:\Users\pal\Documents\registries-site\node_modules\puppeteer\lib\WebSocketTransport.js:44:24)
    at WebSocket.onMessage (C:\Users\pal\Documents\registries-site\node_modules\ws\lib\event-target.js:120:16)
    at WebSocket.emit (events.js:315:20)
    at Receiver.receiverOnMessage (C:\Users\pal\Documents\registries-site\node_modules\ws\lib\websocket.js:789:20)
    at Receiver.emit (events.js:315:20)
(node:44896) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:44896) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Build of languages completed
Build of studios completed

git clone https://github.com/ISDCF/registries-site.git
git submodule update --recursive --remote --init
npm install
npm run build

Was there an implied git checkout  issues/0004-studio-language-support in there?

git clone https://github.com/ISDCF/registries-site.git
git submodule update --recursive --remote --init
npm install
npm run build

Was there an implied git checkout issues/0004-studio-language-support in there?

Yes.

Was there an implied git checkout issues/0004-studio-language-support in there?

Yes.

Interesting b/c these precise steps work for me:
$ node -v
v14.5.0
$ git clone https://github.com/ISDCF/registries-site.git
$ cd registries-site
$ git checkout issues/0004-studio-language-support
$ git submodule update --recursive --remote --init
$ npm install
$ npm run build
Building facilities started
Building languages started
Building studios started
Build of studios completed
Build of languages completed
Build of facilities completed

What version of node are you on?

What version of node are you on?

v12.18.2
Windows 10


Broswer core

I see there is an file called Chrome.py, so I have a question that is this project use Chrome or just Chromium, I think this is a big problem because Chrome is NOT a open-source software, but Chromium is. I think if you use Chrome, you need to change it to Chromium, but if you just use Chromium, you also need to rename the file, or it will make a dispute with the owner of Chrome -- Google.
@ChrisKnott

@weathon It works with either Chrome or Chromium but it prefers Chromium if it is installed https://github.com/ChrisKnott/Eel/blob/master/eel/chrome.py#L46
I think the file was named when it only worked with Chrome

If it is runing with some broswer but not a own windows, I am worrying about if some one make a page and that page include eel.js, that page ill call python function, and it will be a security issue.

I am sorry about my English is not good.

@ChrisKnott


Remove doc references to cudf JIT

Fixes #3174.  Now that we are no longer using libcudf functionality that requires JIT, we no longer need to mention the JIT cache path in our documentation.

build

build


build: Update swc_core to v1.0.0

Commit range: https://github.com/swc-project/swc/compare/v1.7.28...swc_core%40v1.0.0


sagemaker emotion model

#closes 121
determines emotion for each sentence and exports to csv
https://emotion-analysis-nvi9.notebook.us-west-2.sagemaker.aws/notebooks/emotions2.ipynb
Time Estimate: 3 hours

Task
Time

Develop
4 hours

To test:

Log in to AWS

Search for sagemaker

Left Navigation bar:  'notebook > notebook instances'

Instance: emotion-analysis

Open emotions2 file

Run each line

Verify expected results:

Go back to emotion-analysis root

Verify sentenceEmotion.csv got updated

Looks good, you could clean up the code at the end of the notebook. There are some errors. It also looks like you've imported quite a few libraries you are not using.

@eknigge I reverted the notebook back to when I originally made the PR; the end of the notebook and imports are cleaned up now.


Views Controlled Vocabularies TG call 16 June 2021 at 15:00 UTC

The Views Controlled Vocabularies Task Group will have an online meeting at 15:00 UTC on Wednesday, 2021-06-16. That corresponds to 11:00 AM Eastern (US) Daylight Time (New York), 10:00 AM Central (US) Daylight Time (Chicago), 8:00 AM Mountain (US) standard time (Phoenix), 5:00 PM Central European summer time (Stockholm), and 5:00 AM Hawaii Standard time (Honolulu).
At this meeting we will go over "competency questions" generated from the Final Requirements established at the last meeting. We will discuss the path forward for generating implementation experience.
Meeting details:
Join Zoom Meeting
https://vanderbilt.zoom.us/j/91817362347
Meeting ID: 918 1736 2347
Find your local number: https://vanderbilt.zoom.us/u/aeucmQayaA

The Views Controlled Vocabularies meeting for tomorrow (June 16) is cancelled. We will re-schedule for late July.


AWS styling changes have broken extension

AWS Seem to have changed the styling today, just as I was trying to get your extension to work!
It's not changing the AWS menu for me - I get the following error in the console:
aws-console.js:1 Uncaught (in promise) Error: Timeout: Element not found with selector "#menu--account"
    at aws-console.js:1:21039

I think it's this line:
https://github.com/WTFender/aws-sso-extender/blob/5846ebea2c1d67f331d1904c39056e9fe543f46f/src/entry/aws-console.ts#L111
#menu--account probably needs to be switched to #nav-usernameMenu I guess.

@chrisgilbert Thanks for letting me know! Looks like they made some slight tweaks, I'll have a fix out soon.

There were some subtle HTML changes to the AWS console menu that messed up how I'm scraping the account info. Some pages use the updated HTML and some still use the old format.
Let me know if you see anything else odd.