Is it possible to switch a module On and Off ?

Hi there , I'm working on my terragrunt project for AKS and I was wondering if it's possible to enable or disable modules based on inputs. For example when you create a cluster, you might want to disable  monitoring  module for quick test. Is there something in Terragrunt that help me to achieve this?
Currently this is my folder structure:
.
├── README.md
├── _base
│   ├── acr.hcl
│   ├── aks-log-diagnostic.hcl
│   ├── aks-provisioning.hcl
│   ├── aks.hcl
│   ├── azure-service-bus.hcl
├── environment
│   ├── acr
│   │   └── terragrunt.hcl
│   ├── aks
│   │   └── terragrunt.hcl
│   ├── aks-log-diagnostic
│   │   └── terragrunt.hcl
│   ├── aks-provisioning
│   │   └── terragrunt.hcl
│   ├── azure-service-bus
│   │   └── terragrunt.hcl
│   ├── environment_specific.hcl

I've followed the documentation and I came up with this setup for a nice DRY solution.  However, I'm still struggling with the situation described above
_base/aks.hcl
locals {
  env_config = read_terragrunt_config(find_in_parent_folders("environment_specific.hcl"))

  source_base_url = "git::https://github.com/xxxx/sys-tf-module-acr.git"
}

dependency "aks" {
  config_path = "${get_terragrunt_dir()}/../aks"

  mock_outputs = {
    kubelet_identity_object_id = "temporary-dummy-id"
  }
}

inputs = {
  acr_resource_group_name    = "rg-acr"
  acr_name                   = "acrname"
  kubelet_identity_object_id = dependency.aks.outputs.kubelet_identity.0.object_id
}

environment/aks/terragrunt.hcl
include "root" {
  path = find_in_parent_folders()
}

include "base" {
  path   = "${get_terragrunt_dir()}/../../_base/aks.hcl"
  expose = true
}

# Construct the terraform.source attribute using the source_base_url and custom version
terraform {
  source = "${include.base.locals.source_base_url}?ref=remotes/origin/main"
}

inputs = {
  cluster_name                   = "aks-demo"
  private_cluster_enabled        = false
  enable_log_analytics_workspace = false
  enable_aks_audit               = false
}

environment/environment_specific.hcl
locals {
  environment                = "test"
  resource_group_name        = "rg-test"
  enable_aks_log_diagnostics = false
  common_tags = { }
}

so, my idea is at the moment I set enable_aks_log_diagnostics = true then the log-dianostics module should be applied . I know in Terraform you have the option of using count = var.enable_aks_log_diagnostics ? 1 : 0  but I don't see how to achieve this in a clean  way via Terragrunt. Any ideas/suggestions  how can I achieve this?
Thanks in advanced.

Hi,
I think this function is not supported, however, aks_log_diagnostics configurations can be imported from common HCL files for environments that require log diagnostics.

Hi,
I'm writing on this issue to ask if there is any plan to add the functionality in the future? It would be really beneficial in my case!
Thanks!


When char width is too smal error jump up. I'm about Basic Line

Thanks for the report, This happens because a dimension of an area is negative, normally the PlotArea, even if I fix this error, the chart will not display correctly, if you are facing this error then your charts need to be bigger.
can you please let me know the size of your chart?

I soves it, defining minWidth for my ChartUserControl. Even When it is being resized it is working correctly. Now I have another problem) I set one MVVM ViewModel for chart which I'am changing every time i jump betweet tabs. The problem is - if initial chart animation isn't finished yet but i click on another tab and model changed error jumps up. It tells me that animation wasn't finished yet (first) and that it obtain NaN value now. How I can solve it? Or  Shall I wait for new DLL upgrade?

This second error is interesting, and yes you might wait for an update, I am opening an issue based on this

Thanks for great job. Your charts look so good. I like it.

This should not happen anymore, With many commits, now the model (core library)  should never send to the view (WPF library) a negative value to set as the height/width of a shape


[R-package] Move error handling into C++ side

Short description
#4155 fixes a critical issue facing Windows users of the R package, but to implement it the R package needs to switch from using wrapper function lgb.call() to directly using the builtin .Call(). This PR is a first step in that refactoring.
Longer description
Today, the interaction between R code in {lightgbm} and C++ code in lib_lightgbm works like this:

R initializes an integer call_state
R calls C++ code with .Call()
On the C++ side, if anything goes wrong then call_state is updated to a non-0 value, and an error message is stored in the place that LGBM_GetLastError() can find it
When control returns to R, it checks the value of call_state. If it is non-0, R calls lgb.last_error(), which calls C++ function LGBM_GetLastError(), then raises an R exception using stop().

This back-and-forth is the reason that almost all of {lightgbm}'s calls to C++ code use an internal wrapper function lgb.call().
https://github.com/microsoft/LightGBM/blob/d517ba12f2e7862ac533908304dddbd770655d2b/R-package/R/utils.R#L62-L91
It seems that the use of that function (not calling .Call() directly with a name that matches a symbol exported from the library) is not allowed if you use R's native routine registration, which is blocking the bugfix in #4155 (see that PR's description for more background).
This is a first step towards factoring out lgb.call(), as described in https://github.com/microsoft/LightGBM/pull/4155#issuecomment-812896569. This PR proposes just raising errors directly from the C++ side. Using Rf_error() from R, those still become regular R exceptions. So this change does not have any user-facing impact. I've added a unit test to make that expectation explicit.
If call_state isn't necessary for raising errors, why doesn't this PR just remove it from all the interfaces defined in LightGBM_R.h?
I did spent a while trying this, but unfortunately it can result in this warning every time code .Call() is used:

converting NULL pointer to R NULL

This comes from Rinternals.h, at https://github.com/wch/r-source/blob/d22ee2fc0dc8142b23eed9f46edf76ea9d3ca69a/src/main/dotcode.c#L538-L541. I think those now-unnecessary uses of call_state can be cleaned up as part of #3016.

Just wondering about the next step after this PR. Does that mean we need to replace every lgb.call with .Call wrapped by tryCatch?

Just wondering about the next step after this PR. Does that mean we need to replace every lgb.call with .Call wrapped by tryCatch?

Next, every lgb.call() would be replaced by .Call() (in #4155). But it won't be necessary to introduce any new tryCatch() stuff in the R package, since as of this PR that logic moves to the C++ side.

Then I have no question about this PR. But it seems that checks on macOS failed.

OpenMP was not found, and should be when testing the CRAN package on macOS

Looks like this was similar to the issue that briefly blocked the most recent release (https://github.com/microsoft/LightGBM/pull/4169#issuecomment-818046919).
https://github.com/microsoft/LightGBM/pull/4163/checks?check_run_id=2325957398

==> Downloading https://homebrew.bintray.com/bottles/libomp-11.1.0.catalina.bottle.tar.gz
curl: (22) The requested URL returned error: 403 Forbidden
Error: Failed to download resource "libomp"

I'll merge in the latest master to this and re-run the jobs. If we're going to re-run jobs anyway, might as well also update the PR to the latest master!
If you're ok with the change @shiyu1994 , could you approve the PR?

/gha run r-valgrind

Hey cool example of failing valgrind tests blocking a merge! Nice job @StrikerRUS !

I'll fix this tonight.

Ok I just pushed a change that, based on running valgrind locally, I think will test this PR without triggering any issues from valgrind.
I originally wanted to test that errors are raised correctly by constructing a Dataset where the size of data and label don't match. But that results in this valgrind finding.
==3577== 40 bytes in 1 blocks are definitely lost in loss record 46 of 2,254
==3577==    at 0x483BE63: operator new(unsigned long) (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==3577==    by 0x1525F509: __gnu_cxx::new_allocator<float>::allocate(unsigned long, void const*) (new_allocator.h:115)
==3577==    by 0x1525D31B: std::allocator_traits<std::allocator<float> >::allocate(std::allocator<float>&, unsigned long) (alloc_traits.h:460)
==3577==    by 0x15259D57: std::_Vector_base<float, std::allocator<float> >::_M_allocate(unsigned long) (stl_vector.h:346)
==3577==    by 0x15259EDE: std::_Vector_base<float, std::allocator<float> >::_M_create_storage(unsigned long) (stl_vector.h:361)
==3577==    by 0x1525506E: std::_Vector_base<float, std::allocator<float> >::_Vector_base(unsigned long, std::allocator<float> const&) (stl_vector.h:305)
==3577==    by 0x1536F8E2: std::vector<float, std::allocator<float> >::vector(unsigned long, std::allocator<float> const&) (stl_vector.h:511)
==3577==    by 0x155BE08F: LGBM_DatasetSetField_R (lightgbm_R.cpp:224)
==3577==    by 0x49422DE: R_doDotCall (dotcode.c:610)
==3577==    by 0x494D3CA: do_dotcall (dotcode.c:1281)
==3577==    by 0x49A07AE: bcEval (eval.c:7072)
==3577==    by 0x498C38F: Rf_eval (eval.c:727)

I think that has something to do with how this vector is filled:
https://github.com/microsoft/LightGBM/blob/211ef7878f0c8a72757fd2b0050029908bc3091a/R-package/src/lightgbm_R.cpp#L220-L224
I suspect that that issue might be fixed as part of #3016. Either way, it's not directly related to this PR.
I changed the unit test in this PR to use an init_score of the wrong size, to use this branch of code that doesn't need to allocate a new vector: https://github.com/microsoft/LightGBM/blob/211ef7878f0c8a72757fd2b0050029908bc3091a/R-package/src/lightgbm_R.cpp#L218.

/gha run r-valgrind

Sorry, realized I still had the label "in progress" on this! This is ready for review.

@shiyu1994 sorry to bother you, could you look at this PR again and approve it if you agree with the changes?
Some of the discussion from #4207 and #4216 are giving new urgency to #3016, and I'd like to handle this PR and #4155 as steps towards that.

@jameslamb Sorry for the delay. I've checked and already approved.

No problem, thanks very much for the help!


Test: too many folding regions notification

Refs: https://github.com/microsoft/vscode/issues/163428

[x] anyOS @lramos15
[ ] anyOS @alexr00

Complexity: 3
Create Issue

Configure "editor.foldingMaximumRegions": 10 with a small limit to test this issue
Open a file with more than 10 folding ranges. Verify that the language indicator now has a warning

test that clicking the link in the notification works
reduce the number of folding ranges and verify that the warning goes away
test that this works for any language, including JSON and JSONC.
use a language specific setting and test that this works as well

"[json]" {
    "editor.foldingMaximumRegions": 12
}

test that opening a different file in the same editor correctly updates the indicator
test with a multi column tab layout and test that setting focus in the different tab column correctly updates
test that this also works in the output view

test that this also works in the output view

How can I cause foldable regions in the Output view? I tried appending a bunch of JSON to an output channel, but that didn't show as foldable.

@alexr00 I improved the wording of the last test bullet point.
Steps to produce a large output are:

set "json.trace.server": "verbose"
open some JSON file, do some edits, check the JSON Language Server output view.

The output view does not support folding.
There's was bug that folding was computed anyways and the user could get a notification about too many folding ranges.


77 ensure unit test coverage of secir get_migration_factors

Changes

migration unittest uses the right simulation class
additional unittest specifically for get_migration_factors

closes #77
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:

[x] There is at least one issue associated with the pull request.
[x] The branch follows the naming conventions as defined in the git workflow.
[x] New code adheres with the coding guidelines
[ ] Tests for new functionality has been added
[x] A local test was succesful
[ ] There is appropriate documentation of your work. (use doxygen style comments)
[ ] If new third party software is used, did you pay attention to its license? Please remember to add it to the wiki after successful merging.
[ ] If new mathematical methods or epidemiological terms are used, has the glossary been updated ? Did you provide further documentation ?
is present or referenced. Please provide your references.
[ ] The following questions are addressed in the documentation*:  Developers (what did you do?, how can it be maintained?), For users (how to use your work?), For admins (how to install and configure your work?)
For documentation: Please write or update the Readme in the current working directory!

Checks by code reviewer(s):

[ ] Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
[ ] The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
[ ] There are appropriate unit tests and they pass.
[ ] The git history is clean and linearized for the merge request.
[ ] Coverage report for new code is acceptable.

Out of curiosity, why did you replace the auto& with auto&&?

At first because I didn't understand why auto& works at all, since cast returns a temporary. After you asked me I have found out that it works because cast returns const CastXpr, so auto& becomes const CastXpr&, which is fine since const ref extends lifetime of a temporary. That seems a bit brittle to me, the return type could easily change (intentionally or not) to be non-const in future Eigen versions. It could be auto without any ref, but that would be brittle too, since cast may return a reference to the original object if the type of the cast is identical to the type in the array. So if we ever change the parameters from UncertainValue to double, there would be an unnecessary and probably undetected copy. So auto&& is correct, although I didn't know that when I made the change.
Isn't C++ fun?


feat: add ribbon icon toggle

Adds #18

Thank you, I will release a new version to add this feature.


Checks if bug exists, and if so, checks if bug is deprecated

This changes d4j-info to print if a bug is deprecated or nonexistent

Hi @bkushigian. This looks great. One request - can you also add this check/error message to defects4j-checkout? This will be more informative than the current output: Version id does not exist: 2f! at /home/greg/repos/defects4j-rjust/framework/core/Vcs.pm line 177.

I agree with @Greg4cr. Would be great to have a consistent error message. What about adding this check to Utils.pm and calling it from d4j-info and Vcs.pm? (Utils.pm already provides a somewhat related subroutine to check version ids.)

Good idea - let's use the check_vid subroutine for both checking format and whether a bug ID actually exists/is deprecated.
Instead of Wrong version ID as an error message, this could be made more informative:

Malformed version ID for those not properly formatted.
Non-existent version ID  for those out of the allocated range.
Deprecated version ID for those that have been deprecated (in-range, but not in the list of bug IDs)

We should also try to be consistent on terminology: "version ID" versus "bug ID". I don't have a strong opinion, but we should choose one and use it both here and in the table in the README.

The bug-mining README does define the two terms version id and bug id. I think we should keep this distinction.
My suggestion is:

add a check_bid which performs the check that @bkushigian has implemented.
call check_bid from check_vid (for well-formed version ids).

The error message types would be:

Malformed version id
Non-existent bug id
Deprecated bug id

This all sounds good---I'll get on these tomorrow.

@rjust @Greg4cr so to follow up, it seems to me what we want is a subroutine that ensures that we have a valid bug id (resp version id). In my conception of this, the subroutine would handle termination of the program. This is potentially inflexible? That is, perhaps we want the caller to handle this in specific ways?
sub ensure_valid_bid {
    bid = shift
    if (check $bid for bad format) {
      confess("Bad bug id format: $bid, expected [d+]\n");
   }
   if (check if $bid doesn't exist){
      confess("bug id $bid doesn't exist\n");
    }
   if (check if $bid is deprecated) {
      confess("bug id $bid exists but is deprecated\n");
   }
}

Then this can be called:
sub foo {
    bid = shift
    ensure_valid_bid($bid);    // this returns only when bug id is valid
    // do stuff with valid bug id

}

check_vid currently returns a dict {valid => 1, bug_id => $1, $type => 2}. The valid is a constant and maybe not necessary? This subroutine terminates with an error message whenever the vid is not valid.

ping

@rjust most of the subroutines in this file use shift. Should I update those in this PR or do a separate PR?

Also, does the my ($a, $b) = @_ pattern have a way to handle stuff like $b = shift // '='?

Good call. Let's use shift to be consistent and then change all occurrences later in a separate PR.


Mutual Authentication security

Hi,
It will be great if we can have a mutual authentication (or client-base certificate) security plugin.
I think that will be a great plugin to have more if the "truststore" can be reloaded with new entries.
We are working with IoT devices that we register to a truststore so we can have mutual authentication, but Java keystore stuff is a pain and do require refreshing the SSL connector at least to get the new public certificates from clients (not ideal as you don't want to be messing with connections when devices are sending data)
Thanks!

Why not using the ssl_client_certificate directive of Nginx? I'm not sure about the feasibility, nor even the behavior of this made as a plugin.

Hi @thibaultCha,
Our current problem is that we are registering devices to the truststore and every time this happen we need to restart the SSLConnector (this is using tomcat & Java keystore) and that is not desirable (to use nice words).
This process is basically a call to an end point that allow devices to do that sign in or registration process. We deal with the authorisation using other methods internally but that allow us to communicate using mutual authentication for the rest of the calls.
I am looking to move this implementation either to nginx on its own (adding a small nodejs or similar to it) or to kong, that I can see is base in nginx and can give us extra functionality.
I know nginx can listen for changes in the configuration (using reload) so we will not be restarting the connector.
If this could be useful for other people, I am happy to help with the development but my experience in LUA is 0. Happy to learn and looks a pretty interesting scripting language.
Thanks

Isn't what would be appropriate this: http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_ssl_certificate ?

Hi @DonMartin76 ,
I end up implementing a simple server that does our logic. You can close this as is fairly specific to our needs.
We are doing something similar to the key authentication
https://getkong.org/plugins/key-authentication/
but with certificates and creating users in our system.
Thanks in any case.

Hi @ISMAELMARTINEZ
Can you elaborate on how did you implemented the Mutual Auth , As I have the same need and wondering if there is an easy way to achieve it.
Thanks

Hi @amramtamir,
I ended up creating a GO program to do the "registration" process and using stunnel to deal with the certificates.
So I don't think I can help much on this.


Recommended PCI Passthrough options for VF's

What is the recommended way of passing through vfs with kvm?
Should we use OVMF (for UEFI) or Seabios?
Should it be PCI-E (pcie=1, machine type q35) or old PCI?
Can we use x-vga=1 to make the VF the primary display of the VM? (this hasn't worked so far in my testing).
Thanks! This is probably something that should be in the docs, imo.

And additionally to my previous question, what is the correct driver to use? The one that is 17.12.2 and says it is specifically for GIM "technical preview" or the most recent driver?


refactor: replaced waitForElement by findByText

waitForElement is deprecated

Thanks!

This PR broke the build: https://app.circleci.com/pipelines/github/skidding/react-testing-examples/7/workflows/125cb679-a5de-45da-bb9d-957fc48615b5/jobs/224 – @MitchelSt Can you please make a follow-up PR to fix the issue? Thanks!


Send detailed error on unrecognized client_assertion_type

Coverage: 93.986% (+0.001%) from 93.985% when pulling 8bdb1288528a3277f7ae3972a6d0a80d011581a1 on cody-error-on-unsupported-client-assertion-type into 5b88479d3e7d88234c27e6f6d3b95c5e89e8bed9 on main.


WA Notify integration with SimpleReport to end on 5/11

Problem statement
We are planning for May 10 to be the final day for verification code issuance after which the SimpleReport API verification code issuance key will be disabled.
What you need to know
We sincerely appreciate your collaboration on this project to integrate WA Notify code issuance with SimpleReport. Since implementing in March 2022, nearly 20,000 verification codes have been issued for positive COVID-19 results reported through SimpleReport. This allowed WA Notify users who tested positive to more quickly notify others they may have exposed.
Original Email Communication:
Hawes, Richard (CDC/DDPHSS/OD)
Thanks for the heads up. I'm forwarding this request to the ReportStream support email address to schedule the configuration change needed.
BTW: I've taken another job at CDC, so please use the support email address in the future for RS requests.
-- Rick
United States Digital Service at CDC
<EMAIL_ADDRESS>From: Higgins, Amanda L (DOH<EMAIL_ADDRESS>Sent: Tuesday, May 2, 2023 3:02 PM
To: Hawes, Richard (CDC/DDPHSS/OD<EMAIL_ADDRESS>Subject: WA Notify integration with SimpleReport to end on 5/11
Hi Rick,
I hope you are doing well. I am reaching out to let you know that COVID-19 exposure notifications through WA Notify will sunset on May 11 in tandem with the end of the public health emergency order. We are planning for May 10 to be the final day for verification code issuance, after which the SimpleReport API verification code issuance key will be disabled.
To avoid unnecessary requests and errors, please remove the code issuance process from the SimpleReport reporting system at the start of business on May 11. Once it is removed, please let us know and we will disable the SimpleReport API key in the ENCV platform.
We sincerely appreciate your collaboration on this project to integrate WA Notify code issuance with SimpleReport. Since implementing in March 2022, nearly 20,000 verification codes have been issued for positive COVID-19 results reported through SimpleReport. This allowed WA Notify users who tested positive to more quickly notify others they may have exposed.
Please let me know if you have any questions, and thank you for your partnership.
Best regards,
Amanda Higgins, MSHI
Pronouns: She/Her
WA Notify Epidemiologist
Office of Innovation and Technology
Washington State Department of Health
Acceptance criteria
Once it is removed, please let us know and we will disable the SimpleReport API key in the ENCV platform.
To do

Please remove the code issuance process from the SimpleReport reporting system at the start of business on May 11.

FYI... The generic name for WANotify is Google/Apple Exposure Notification (GAEN). The setting that governs this data flow is: wa-phd.gaen. Suggest that a change in the setting is used to disable this flow.

Remove transport and set filter to allowNone()

@adegolier Hi Angela, any update on the status for this? Amanda from WA state is asking for an update.
Best regards,
Sharon

@RickHawesUSDS Can you please advise @adegolier where exactly this exposure notification should be disabled at is that somewhere in azure?

wa-phd.gaen has been updated to remove the transport and change the filter to allowNone(), effectively shutting it off.

WA confirmed that no verification codes have been issued.  Please see below communication:
Hi Angela,
I can confirm that no verification codes have been issued through the SimpleReport API today. We will disable the API key in the ENCV platform by EOD.
Thank you for your assistance with this configuration change.
Best,
Amanda Higgins, MSHI


Wrong link on repo page

The link at the top of https://github.com/tidoust/reffy-reports/ goes to https://w3c.github.io/reffy-reports/ instead of https://tidoust.github.io/reffy-reports/

Fixed, thanks. Also fixed a similar broken link in the Readme of Reffy's repo.


Added missing param.

This PR implements https://github.com/CartoDB/support/issues/691.

:es:

We have to check that add-analysis dialog works with the "show me all analyses" flag enabled and disabled.

Tested in staging, working like a charm.


XSS when defining header

Hi there,
AuthAnalyzer is vulnerable to XSS when defining headers to add/replace. If you define a header as X-Foo: <img src='https://xxx'>  and start the session, the tag will be rendered, and a GET request will be triggered to the img src. Although the impact is obviously low, I think you should know. And it's visually annoying ;)

Cheers,
Antoine

Hi Antoine,
Thank you for pointing this out. However, this is not related to XSS; it is simply an HTML-rendered Java Swing UI element and has no security impact whatsoever. If it bothers you, feel free to implement a fix and submit a pull request.
Kind regards


Hex property raises Other error

It looks to me like the specification allows any kind of Value -- including hex Numbers -- as property values., but the following document doesn't parse:
track flags=0xdeadbeef

Looks like the same thing happens for nodes with octal and binary literal properties also.

Looks like the same thing happens for nodes with octal and binary literal properties also.


Sustaining request during specific seconds.

Can i sustain sending request to destination during specific seconds?
When i do test performance like cpu usage, I need to sustain request sending.

@jeyraof we are coming to that, as soon as we release 2.0.0 we'll add these kind of features

I think we already have this. You can set the count of requests to execute to 0 and specify a time limit to run the tests.

@cwaltken-edrans we do, but it is affected by this issue... https://github.com/goadapp/goad/issues/142
closing this one


fix(key-auth) errors while setting consumer headers, fix #3617

Summary
Fix issue introduced in Key Auth when moving Kong consumers to new DAO which can return ngx.null on null columns (old DAO always returned nil in such cases).
Issues resolved
Fix #3617

We are looking for a more generic fix, as we don't want nulls in DAO, only in Admin API. So I close this, and will follow up with more generic fix.


MINOR: Remove waitUntilTrue from TestUtils.scala.

Removed the waitUntilTrue function from TestUtils.scala and replaced it with waitForCondition.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

LGTM, except some improvement suggestions.

@dengziming
Thanks for the heads up, I've fixed the problem you mentioned.


Add 'hobu' as maintainer

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

It won't create new packages.


Query regarding learning of robot model using this code

Dear Contributors,
Great work! I have thoroughly looked into the code and understood the following:
Step 1: First the sine wave trajectory data having (q, dq, ddq, tau) is being generated using ground truth robot model as given below:
train_data = generate_sine_motion_inverse_dynamics_data(gt_robot_model, n_data=1000, dt=1.0/250.0, freq=0.05)

Step 2: Then torque values are predicted using the learnable robot model as:
tau_pred = learnable_robot_model.compute_inverse_dynamics(q=q, qd=qd, qdd_des=qdd_des, include_gravity=True)

My query is regarding the step 2. You are computing the inverse dynamics (i.e. tau) using the same model from which you have computed the ground truth values. I think the learnable robot model should be a neural network. Please guide me regarding this.
Thanks.
Best,
Deepak Raina

Hi Deepak,
Thanks! and sorry for the long wait! To answer your question:
When we instantiate a robot model, we can instantiate either with ground truth parameters (which are taken from the Urdf), or with unknown parameter values (for instance randomly initialized). In the 2nd case we would then estimate these parameters from data.  So when we generate data, we use the ground truth parameters from the Urdf.
An example of where we generate data using the ground truth model, and then compare learning a "structured robot model" (robot model with randomly initialized parameters) to an "unstructured robot model" (neural network) in the ipython notebook
https://github.com/facebookresearch/differentiable-robot-model/blob/master/experiments/l4dc-sim-exps.ipynb
I hope this helps!
Franziska


update to sbt 1.0.3 and scala 2.12.4

SBT 1.0.3 fixes the problem we were seeing in #725. Tried
reimporting and I can still run tests with no issues.

Build is failing on jdk9 due to: https://github.com/sbt/sbt/issues/3684


Filtering Images by Text Field in IntelliJ Plugin

When we use parameterized tests or something like https://github.com/takahirom/robospec, it is difficult to find the image we want to see. If we have a text field to filter images by file name, I think it would be very convenient to use.
You can debug the IntelliJ Plugin by running ./gradlew runIde
https://github.com/takahirom/roborazzi/blob/main/roborazzi-idea-plugin/src/main/kotlin/com/github/takahirom/roborazzi/idea/preview/RoborazziPreviewTool.kt

I'd like to try this task!
I haven't started anything yet, but I might be able to get by with JBTextField.

@sanao1006 Sounds good! I would love to use this feature.


Need regex function to extract a substring

Description:
Regex library lacks functionality to extract a substring (currently we can only replace a substring, not extract)

We introduced new APIs to exact substring and It will be available with next minor release which will come with the next SL update 1 release.
For reference: https://github.com/ballerina-platform/ballerina-standard-library/issues/2689


"Save All" Button in VS Code is Greyed Out

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.57.1
OS Version: Ubuntu 20.04.2 LTS

Steps to Reproduce:
The "File => Save All" button in VS Code is no longer working and is greyed out even after modifying files. This button/functionality used to available (not greyed out) and work until recently. I have noticed hat this bug was already reported twice at the following links, but both reports were closed without providing a solution or explanation:
https://github.com/microsoft/vscode/issues/87352
https://github.com/microsoft/vscode/issues/87108
Thank you for your help. J

/duplicate of 126133


Training with LMDrive

Hello,
Thank you for providing an extensive code base and training dataset.
I have a few questions regarding the dataset usage and training process:
Dataset Usage:
You mentioned that the only difference between your dataset and the one used for training InterFuser is the sampling rate.
I plan to use the RGB image (cropped into three) as inputs and the lidar_odd. Is that correct?
How would you suggest dealing with the difference in sampling rate? Should I use the entire dataset but with fewer training epochs?
Training Parameters:
Regarding the training parameters, which towns and weather conditions from the LMDrive dataset should be used for training and which should be used for validation to replicate your publication results as closely as possible?
Thank you!

Hi!
Dataset Usage:

Utilize both lidar_odd and lidar sensors concurrently as each sensor provides a unique 180-degree field of view. Combining both will give a comprehensive 360-degree perspective.
If limited by time or computational resources, downsample the dataset by selecting frames at fixed intervals. For instance, use every fourth frame (e.g., 001_rgb.jpg, 004_rgb.jpg, etc.) to manage the dataset size effectively.

Training Parameters:

Select multiple towns (excluding possibly Town05) and include all weather conditions for training. Ensure to review and adjust the settings as described in the Interfuser.


Haste from IDE Console

It would be convenient to publish chunks of logs from the Debug/Console tab

That's a nice suggestion 👍 Currently I'm running a little bit low on time, but as soon as some is available for this project, I'll try to implement this feature.


How to disable fullscreen ?? need help

how to disbale full screen option without hiding controls??

Found a solution to not enable full screen mode?

Found a solution to not enable full screen mode?

no not yet

hello did something like this, and it hid the button
return YoutubePlayer(
    controller: _controller,
    bottomActions: [
        const SizedBox(width: 14.0),
        CurrentPosition(),
        const SizedBox(width: 8.0),
        ProgressBar(
            isExpanded: true,
        ),
        RemainingDuration(),
        const PlaybackSpeedButton(),
    ]
);


Large and XLarge column spans use 12 columns but should be 16 columns & Angular export doesn't export col span

In builder
Large and XLarge column spans use 12 columns but should be 16 columns (reference carbon grid guidelines)

React export also uses the 12 columns

Angular export doesn't export the col span settings

If I use  react to prototype the same thing, the col spans act correctly

JSON here
TestColumnSpan.json.zip

Large and XLarge go to 16 in the UI at the moment. Is that it, @gcate?

No, the issue is the display.  In UI builder if I create 16 columns, each with large span 1,  the columns wrap after 12. But Carbon grid is 16 columns.  UI builder should wrap after 16 columns.

I think this is covered since we moved to Carbon v11. If something is missing, please open separate issues.


Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="NoRegisteredProviderFound" Message="No registered resource provider found for location 'westeurope' and API version '2022-03-02-preview' for type 'managedClusters'

Describe the bug
Hi All,
I am facing issue with managedclusters resource. I am not mentioning any API version. Still it gives me error related to API version.
I am running terraform validate command with below versions.
terraform: 1.0.0
Azurerm: 3.20
NOTE:

This was working fine till February 22nd when I last ran it.
I am already using latest version of azurecli..2.57.0.
I donot see this error when using azurerm version of 2.81 and tf version 0.15.5

Related command
terraform validate
Errors
│ Error: retrieving Cluster: (Managed Cluster Name "aks-cluster1" / Resource Group "my-rg"): containerservice.ManagedClustersClient#Get: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="NoRegisteredProviderFound" Message="No registered resource provider found for location 'westeurope' and API version '2022-03-02-preview' for type 'managedClusters'. The supported api-versions are '2017-08-31, 2018-03-31, 2019-02-01, 2019-04-01, 2019-06-01, 2019-08-01, 2019-10-01, 2019-11-01, 2020-01-01, 2020-02-01, 2020-03-01, 2020-04-01, 2020-06-01, 2020-07-01, 2020-09-01, 2020-11-01, 2020-12-01, 2021-02-01, 2021-03-01, 2021-05-01, 2021-07-01, 2021-08-01, 2021-09-01, 2021-10-01, 2022-01-01, 2022-02-01, 2022-03-01, 2022-04-01, 2022-06-01, 2022-07-01, 2022-07-02-preview, 2022-08-01, 2022-08-02-preview, 2022-08-03-preview, 2022-09-01, 2022-09-02-preview, 2022-10-02-preview, 2022-11-01, 2022-11-02-preview, 2023-01-01, 2023-01-02-preview, 2023-02-01, 2023-02-02-preview, 2023-03-01, 2023-03-02-preview, 2023-04-01, 2023-04-02-preview, 2023-05-01, 2023-05-02-preview, 2023-06-01, 2023-06-02-preview, 2023-07-01, 2023-07-02-preview, 2023-08-01, 2023-08-02-preview, 2023-09-01, 2023-09-02-preview, 2023-10-01, 2023-10-02-preview, 2023-11-01, 2023-11-02-preview, 2024-01-01, 2024-01-02-preview'. The supported locations are 'australiacentral, australiacentral2, australiaeast, australiasoutheast, brazilsouth, brazilsoutheast, canadacentral, canadaeast, centralindia, centralus, eastasia, eastus, eastus2, francecentral, francesouth, germanynorth, germanywestcentral, israelcentral, italynorth, japaneast, japanwest, jioindiacentral, jioindiawest, koreacentral, koreasouth, northcentralus, northeurope, norwayeast, norwaywest, polandcentral, qatarcentral, southafricanorth, southafricawest, southcentralus, southindia, southeastasia, swedencentral, switzerlandnorth, switzerlandwest, uaecentral, uaenorth, uksouth, ukwest, westcentralus, westeurope, westus, westus2, westus3'."
Issue script & Debug output
NA
Expected behavior
It should retrieve the resource details
Environment Summary
Azurecli: 2.57
terraform: 1.0.0
Azurerm: 3.20
Additional context
No response

Thank you for opening this issue, we will look into it.

/clibot unresolve
opening this as there is no resolution yet and this is blocking many of our activities.

Please open this issue in terraform repo

/clibot unresolve
hi @yonzhan ,
This was working few days ago with same terraform(1.0.0) and azurerm (3.20) version.
It started to fail since 2 days complaining about the API version in cli.

Please let me know which CLI command you use?

I am not passing any particular command. Terraform fetches the resources in backend when we use terraform validate command on our azure subscription.

and just now I tried with azurerm version 3.90 instead of 3.20 and it works fine. Not sure at which exact version it is breaking.

Please provide more details related to CLI commands.

I'm also facing this issue when running terraform apply.
Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="NoRegisteredProviderFound" Message="No registered resource provider found for location 'westus' and API version '2022-01-02-preview' for type 'managedClusters'.

I am also facing the same issue when i use terraform plan or terraform apply

I am facing this with ARM templates as well, the workaround mentioned in https://github.com/Azure/azure-cli/issues/23985#issue-1383263012 can't be applied with this workflow.

I am also facing the same issue when running terraform plan
Code="NoRegisteredProviderFound" Message="No registered resource provider found for location 'australiaeast' and API version '2022-03-02-preview' for type 'managedClusters'.

the issue went away for me when i set the azurerm to v 3.94.0.
# Configure the Azure provider
terraform {
  required_providers {
    azurerm = {
      source  = "hashicorp/azurerm"
      version = "3.94.0"
    }
  }
  required_version = ">= 1.1.0"
}

the issue went away for me when i set the azurerm to v 3.94.0.
# Configure the Azure provider
terraform {
  required_providers {
    azurerm = {
      source  = "hashicorp/azurerm"
      version = "3.94.0"
    }
  }
  required_version = ">= 1.1.0"
}

Thanks this fixed it for me. I was on 3.0.4 previously.

Thank you, @michaelschuett-tomtom!
This fixed it for me - I was using v3.0.4 and encountering the 400 error, but updating to 3.94.0, running terraform init -upgrade, then running apply again provisioned my AKS cluster as expected.


[Task]: Fixing movies DB flakiness leading to cypress failures in CI

Is there an existing issue for this?

[X] I have searched the existing issues

Instances where this was observed

https://theappsmith.slack.com/archives/C02GAUE9P5H/p1694151136758819?thread_ts=1693815663.411539&cid=C02GAUE9P5H

SubTasks
No response

Example run 1

Run2

Run3

Run4

Run5

Run6


Clarify what's included in Network settings

We provide detailed list of Yammer audit events here: https://learn.microsoft.com/en-us/microsoft-365/compliance/search-the-audit-log-in-security-and-compliance?view=o365-worldwide#yammer-activities and "usage policy" confused couple customers because there is usage policy feature in Yammer

@pamgreen-msft Please merge this PR. Thanks

@chinhngt please pass all the check. Thanks

This article has since been redirected due to updates for the rebrand to Viva Engage. The article is https://github.com/MicrosoftDocs/viva/blob/public/Viva/engage/track-engage-events.md. @Starshine89 can you help move these changes over to the new article?

@tiburd

Please close this PR. Changes are now in PR #6176 for the rebranded Viva Engage article.
@pamgreen-msft
@tiburd


bugfix: add NoArgsConstructor to RateFeeDetail so it can be parsed by kafka

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[x] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Add @NoArgsConstructor to RateFeeDetail so it can be parsed by kafka.
Why
Otherwise, kafka would throw errors.

Reference Server Preview is available here:https://anchor-ref-pr295.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr295.previews.kube001.services.stellar-ops.com/


NullPointerException warning while checking s3 bucket lifecycle configuration

I see https://github.com/spark-redshift-community/spark-redshift/pull/30, but I think this might be a different issue, because my lifecycle configuration does have a prefix.
It looks like so:

I should note there are a couple other prefixes in the bucket that do not have a lifecycle policy... not sure if that matters?
Feel free to close this if it is indeed addressed by #30.
19/11/05 01:21:28 WARN Utils$: An error occurred while trying to read the S3 bucket lifecycle configuration
java.lang.NullPointerException
        at java.lang.String.startsWith(String.java:1405)
        at java.lang.String.startsWith(String.java:1434)
        at io.github.spark_redshift_community.spark.redshift.Utils$$anonfun$5.apply(Utils.scala:140)
        at io.github.spark_redshift_community.spark.redshift.Utils$$anonfun$5.apply(Utils.scala:136)
        at scala.collection.Iterator$class.exists(Iterator.scala:917)
        at scala.collection.AbstractIterator.exists(Iterator.scala:1334)
        at scala.collection.IterableLike$class.exists(IterableLike.scala:77)
        at scala.collection.AbstractIterable.exists(Iterable.scala:54)
        at io.github.spark_redshift_community.spark.redshift.Utils$.checkThatBucketHasObjectLifecycleConfiguration(Utils.scala:136)
        at io.github.spark_redshift_community.spark.redshift.RedshiftWriter.saveToRedshift(RedshiftWriter.scala:390)
        at io.github.spark_redshift_community.spark.redshift.DefaultSource.createRelation(DefaultSource.scala:109)
        at org.apache.spark.sql.execution.datasources.SaveIntoDataSourceCommand.run(SaveIntoDataSourceCommand.scala:45)
        at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult$lzycompute(commands.scala:70)
        at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult(commands.scala:68)
        at org.apache.spark.sql.execution.command.ExecutedCommandExec.doExecute(commands.scala:86)
        at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:131)
        at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:127)
        at org.apache.spark.sql.execution.SparkPlan$$anonfun$executeQuery$1.apply(SparkPlan.scala:155)
        at org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
        at org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:152)
        at org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:127)
        at org.apache.spark.sql.execution.QueryExecution.toRdd$lzycompute(QueryExecution.scala:80)
        at org.apache.spark.sql.execution.QueryExecution.toRdd(QueryExecution.scala:80)
        at org.apache.spark.sql.DataFrameWriter$$anonfun$runCommand$1.apply(DataFrameWriter.scala:676)
        at org.apache.spark.sql.DataFrameWriter$$anonfun$runCommand$1.apply(DataFrameWriter.scala:676)
        at org.apache.spark.sql.execution.SQLExecution$$anonfun$withNewExecutionId$1.apply(SQLExecution.scala:78)
        at org.apache.spark.sql.execution.SQLExecution$.withSQLConfPropagated(SQLExecution.scala:125)
        at org.apache.spark.sql.execution.SQLExecution$.withNewExecutionId(SQLExecution.scala:73)
        at org.apache.spark.sql.DataFrameWriter.runCommand(DataFrameWriter.scala:676)
        at org.apache.spark.sql.DataFrameWriter.saveToV1Source(DataFrameWriter.scala:285)
        at org.apache.spark.sql.DataFrameWriter.save(DataFrameWriter.scala:271)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)
        at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:357)
        at py4j.Gateway.invoke(Gateway.java:282)
        at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
        at py4j.commands.CallCommand.execute(CallCommand.java:79)
        at py4j.GatewayConnection.run(GatewayConnection.java:238)
        at java.lang.Thread.run(Thread.java:748)

Also seeing this issue...

@eeshugerman have you tried this in a bucket containing only prefixes with a lifecycle policy ? I'm trying to understand the steps to reproduce and the potential culprit.

I have not, I'll report back when I have a chance to try that out.
Also, just to clarify the OP, I'm using .option('tempdir', 's3n://mybucket/spark/data').

see this PR #30 fix the issue but was not merged for now.

I don't use the project any more so I can't verify, but looks like this has been fixed (#30 is now merged). Closing.


Logging out from Identity Server 4 won't log out from Client

I'm using the Asp Net Identity and the EF Core combined sample, everything works correctly, database, seeding, api call except for when i try to log out from the IS page. It does not delete the .AspNetCore.Cookies which is the one keeping the user logged in on client
`  ///
/// Handle logout page postback
///
[HttpPost]
[ValidateAntiForgeryToken]
public async Task Logout(LogoutInputModel model)
{
// build a model so the logged out page knows what to display
var vm = await BuildLoggedOutViewModelAsync(model.LogoutId);
        if (User?.Identity.IsAuthenticated == true)
        {
            // delete local authentication cookie
            await _signInManager.SignOutAsync();

            // raise the logout event
            await _events.RaiseAsync(new UserLogoutSuccessEvent(User.GetSubjectId(), User.GetDisplayName()));
        }

        // check if we need to trigger sign-out at an upstream identity provider
        if (vm.TriggerExternalSignout)
        {
            // build a return URL so the upstream provider will redirect back
            // to us after the user has logged out. this allows us to then
            // complete our single sign-out processing.
            string url = Url.Action("Logout", new { logoutId = vm.LogoutId });

            // this triggers a redirect to the external provider for sign-out
            return SignOut(new AuthenticationProperties { RedirectUri = url }, vm.ExternalAuthenticationScheme);
        }

        return View("LoggedOut", vm);
    }

On MVC Client it works correctly, logs out from both sides
  public IActionResult Logout()         {             return SignOut("Cookies", "oidc");         }
I tried to do
 // delete local authentication cookie                 await HttpContext.SignOutAsync("Cookies");                 await HttpContext.SignOutAsync("oidc");
but gives me an exception cause i didn't add these on AddAuthentication on the IS...

Can you add your start up specifically the AddAuthentication section.

Hi , thanks for replying. This is basically the same file as the sample of Asp.Net Identity and EF Core combined
public class Startup
{
        public IConfiguration Configuration { get; }
        public IHostingEnvironment Environment { get; }

        public Startup(IConfiguration configuration, IHostingEnvironment environment)
        {
            Configuration = configuration;
            Environment = environment;
        }

        public void ConfigureServices(IServiceCollection services)
        {

            var connectionString = Configuration.GetConnectionString("DefaultConnection");
            var migrationsAssembly = typeof(Startup).GetTypeInfo().Assembly.GetName().Name;

            services.AddDbContext<ApplicationDbContext>(options =>
                options.UseSqlServer(connectionString));

            services.AddIdentity<ApplicationUser, IdentityRole>()
                .AddEntityFrameworkStores<ApplicationDbContext>()
                .AddDefaultTokenProviders();

            services.AddMvc().SetCompatibilityVersion(Microsoft.AspNetCore.Mvc.CompatibilityVersion.Version_2_1);

            services.Configure<IISOptions>(iis =>
            {
                iis.AuthenticationDisplayName = "Windows";
                iis.AutomaticAuthentication = false;
            });

            var builder = services.AddIdentityServer(options =>
            {
                options.Events.RaiseErrorEvents = true;
                options.Events.RaiseInformationEvents = true;
                options.Events.RaiseFailureEvents = true;
                options.Events.RaiseSuccessEvents = true;
            })
                // this adds the config data from DB (clients, resources)
                .AddConfigurationStore(options =>
                {
                    options.ConfigureDbContext = b =>
                        b.UseSqlServer(connectionString,
                            sql => sql.MigrationsAssembly(migrationsAssembly));
                })
                // this adds the operational data from DB (codes, tokens, consents)
                .AddOperationalStore(options =>
                {
                    options.ConfigureDbContext = b =>
                        b.UseSqlServer(connectionString,
                            sql => sql.MigrationsAssembly(migrationsAssembly));

                        // this enables automatic token cleanup. this is optional.
                        options.EnableTokenCleanup = true;
                })
                .AddAspNetIdentity<ApplicationUser>();

            if (Environment.IsDevelopment())
            {
                builder.AddDeveloperSigningCredential();
            }
            else
            {
                throw new Exception("need to configure key material");
            }

            services.AddAuthentication()
                .AddGoogle(options =>
                {
                        // register your IdentityServer with Google at https://console.developers.google.com
                        // enable the Google+ API
                        // set the redirect URI to http://localhost:5000/signin-google
                        options.ClientId = "copy client ID from Google here";
                    options.ClientSecret = "copy client secret from Google here";
                });
        }

        public void Configure(IApplicationBuilder app)
        {
            if (Environment.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
                app.UseDatabaseErrorPage();
            }
            else
            {
                app.UseExceptionHandler("/Home/Error");
            }

            app.UseStaticFiles();
            app.UseIdentityServer();
            app.UseMvcWithDefaultRoute();
        }
    }`

try
 await _signInManager.SignOutAsync();

I tried this and it does not delete the AspNetCore.Cookies which keeps the user logged in the client application.
I tried again just downloading the samples  https://github.com/IdentityServer/IdentityServer4.Samples
and using a fresh Identity + EF Core combined solution and problem still persists.
Logging out from Identity Server does not log out from client.
This is the configuration on client, not sure if it could change anything
` new Client
                {
                    ClientId = "mvc",
                    ClientName = "MVC Client",
                    AllowedGrantTypes = GrantTypes.Hybrid,

                    ClientSecrets =
                    {
                        new Secret("secret".Sha256())
                    },

                    RedirectUris           = { "http://localhost:5002/signin-oidc" },
                    PostLogoutRedirectUris = { "http://localhost:5002/signout-callback-oidc" },

                    AllowedScopes =
                    {
                        IdentityServerConstants.StandardScopes.OpenId,
                        IdentityServerConstants.StandardScopes.Profile,
                        "api1"
                    },

                    AllowOfflineAccess = true
                },`

Clearing the cookie in IdentityServer won't logout the user "auto-magically" at other clients, check the docs
https://identityserver4.readthedocs.io/en/latest/topics/signout.html

That makes sense, I haven't implemented any of this. However i can't seem to find any of this in any identity server 4 sample on the official github

https://github.com/IdentityServer/IdentityServer4.Samples/tree/master/Clients

Looks like the issue is that in the quickstarts layout lhttps://github.com/IdentityServer/IdentityServer4.Samples/blob/master/Quickstarts/Combined_AspId_and_EFStorage/src/IdentityServer/Views/Shared/_Layout.cshtml
the link to the logout controller does not pass  the logoutId argument
 @if (!string.IsNullOrWhiteSpace(name))
            {

                        @name

Logout

            }

...which the AccountController expects
https://github.com/IdentityServer/IdentityServer4.Samples/blob/master/Quickstarts/Combined_AspId_and_EFStorage/src/IdentityServer/Quickstart/Account/AccountController.cs
        public async Task<IActionResult> Logout(string logoutId)
        {
            // build a model so the logout page knows what to display
            var vm = await BuildLogoutViewModelAsync(logoutId);

            if (vm.ShowLogoutPrompt == false)
            {
                // if the request for logout was properly authenticated from IdentityServer, then
                // we don't need to show the prompt and can just log the user out directly.
                return await Logout(vm);
            }

            return View(vm);
        }

As a result vm.TriggerExternalSignout is false which means the extenal signout does not get called.
/// Handle logout page postback
        ///
        [HttpPost]
        [ValidateAntiForgeryToken]
        public async Task<IActionResult> Logout(LogoutInputModel model)
        {
            // build a model so the logged out page knows what to display
            var vm = await BuildLoggedOutViewModelAsync(model.LogoutId);

            if (User?.Identity.IsAuthenticated == true)
            {
                // delete local authentication cookie
                await _signInManager.SignOutAsync();

                // raise the logout event
                await _events.RaiseAsync(new UserLogoutSuccessEvent(User.GetSubjectId(), User.GetDisplayName()));
            }

            // check if we need to trigger sign-out at an upstream identity provider
            if (vm.TriggerExternalSignout)
            {
                // build a return URL so the upstream provider will redirect back
                // to us after the user has logged out. this allows us to then
                // complete our single sign-out processing.
                string url = Url.Action("Logout", new { logoutId = vm.LogoutId });

                // this triggers a redirect to the external provider for sign-out
                return SignOut(new AuthenticationProperties { RedirectUri = url }, vm.ExternalAuthenticationScheme);
            }

            return View("LoggedOut", vm);
        }

I'll raise a new issue

I am in the process of going though the samples now i will add this to #3178

Thank you Linda, really appreciate your help.  I also have created https://github.com/IdentityServer/IdentityServer4/issues/3212

Looks like the issue is that in the quickstarts layout lhttps://github.com/IdentityServer/IdentityServer4.Samples/blob/master/Quickstarts/Combined_AspId_and_EFStorage/src/IdentityServer/Views/Shared/_Layout.cshtml
the link to the logout controller does not pass the logoutId argument
 @if (!string.IsNullOrWhiteSpace(name))
            {

                        @name

Logout

            }

...which the AccountController expects
https://github.com/IdentityServer/IdentityServer4.Samples/blob/master/Quickstarts/Combined_AspId_and_EFStorage/src/IdentityServer/Quickstart/Account/AccountController.cs
        public async Task<IActionResult> Logout(string logoutId)
        {
            // build a model so the logout page knows what to display
            var vm = await BuildLogoutViewModelAsync(logoutId);

            if (vm.ShowLogoutPrompt == false)
            {
                // if the request for logout was properly authenticated from IdentityServer, then
                // we don't need to show the prompt and can just log the user out directly.
                return await Logout(vm);
            }

            return View(vm);
        }

As a result vm.TriggerExternalSignout is false which means the extenal signout does not get called.
/// Handle logout page postback
        ///
        [HttpPost]
        [ValidateAntiForgeryToken]
        public async Task<IActionResult> Logout(LogoutInputModel model)
        {
            // build a model so the logged out page knows what to display
            var vm = await BuildLoggedOutViewModelAsync(model.LogoutId);

            if (User?.Identity.IsAuthenticated == true)
            {
                // delete local authentication cookie
                await _signInManager.SignOutAsync();

                // raise the logout event
                await _events.RaiseAsync(new UserLogoutSuccessEvent(User.GetSubjectId(), User.GetDisplayName()));
            }

            // check if we need to trigger sign-out at an upstream identity provider
            if (vm.TriggerExternalSignout)
            {
                // build a return URL so the upstream provider will redirect back
                // to us after the user has logged out. this allows us to then
                // complete our single sign-out processing.
                string url = Url.Action("Logout", new { logoutId = vm.LogoutId });

                // this triggers a redirect to the external provider for sign-out
                return SignOut(new AuthenticationProperties { RedirectUri = url }, vm.ExternalAuthenticationScheme);
            }

            return View("LoggedOut", vm);
        }

I'll raise a new issue

You've got a point here! I think.
The problem is that BuildLogoutViewModelAsync, when logoutid is null (as is in the case of the IS account controller), will not set LoggedOutViewModel.SignOutIframeUrl.
This means that if the user signs-out in the IS backoffice it will not trigger the front-channel logout on the clients as it does between clients.
Anyone can tell me how to fix that please?

I have the same issue, except I'm using a JavaScript Client with OIDC. I can see that the endSession contains both the id_token_hint and post_logout_redirect_uri in the debug logs, I can see an error:
http://localhost:5002/connect/endsession?id_token_hint=ey_redacted_EQ&post_logout_redirect_uri=http%3A%2F%2Flocalhost%3A8080
{"ClientId": "js", "ClientName": "JavaScript Client", "SubjectId": "0exxx93", "PostLogOutUri": null, "State": null, "Raw": {"id_token_hint": "eyxxx
[INF] End session request validation failure: Invalid post logout URI  [ERR] Error processing end session request Invalid request
I assume I've done something wrong, but have not scratched open the solution yet.

I'm having the same issue having started the quick start a couple days ago.


chore(apps/prod/tekton/configs/triggers): increase pipeline run timeout to 3h

User description
avoid timeout on low performance mac machines.
Signed-off-by: wuhuizuo<EMAIL_ADDRESS>
PR Type
Enhancement

Description

Increased the pipeline run timeout to 3 hours for tiflash and tikv components to avoid timeouts on low-performance Mac machines.

Changes walkthrough 📝
Relevant filesEnhancement

git-push.yamlIncrease pipeline run timeout for tiflash to 3 hours

apps/prod/tekton/configs/triggers/triggers/pingcap/tiflash/git-push.yaml

Increased the pipeline run timeout from 2 hours to 3 hours.

+1/-1

git-push.yamlIncrease pipeline run timeout for tikv to 3 hours

apps/prod/tekton/configs/triggers/triggers/tikv/tikv/git-push.yaml
Increased the pipeline run timeout from 2 hours 30 minutes to 3 hours.

+1/-1

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

/approve


Adding Custom Keyboard Shortcuts for Enhanced Usability

Hi there,
Is there a way to add custom keyboard shortcuts? The more I work with MZmine, the more I realize how useful it would be to have shortcuts such as:
Esc for closing a window or module
Delete for removing a feature in the feature list tab or a row in the feature table
Alt for accessing the top menus
Ctrl + z for undo
...
...
These additions would greatly enhance usability. Thanks for considering this suggestion!
Best,

Hi Hannier,
nice to hear from you and even nicer to hear that you are using mzmine more and more! :)
Custom keyboard shortcuts would be nice, but they are currently not on our to-do list.
However, the shortcuts you suggested are definitely nice to have and we can add them as a default in a future release. Do you have more suggestions?
Hint: did you know about Ctrl+F or double shift to search a module? :)

Great, i added these, too.
The Alt key already works for me (on windows).
see #1937


[DO NOT MERGE, for conversation ] winrm elevated

exploring connection options for winrm connection timeout
@tyler-ball  poking around with solving that timout connection issue
without elevated we get:
  - run '& "C:\chef\install.ps1"' on base-2012r2-2016-10-20[2016-10-20T05:41:56+13:00] INFO: Processing chef_node[base-2012r2-2016-10-20] action create (basic_chef_client::block line 57)
[2016-10-20T05:41:57+13:00] INFO: Converging base-2012r2-2016-10-20 because the resource was updated ...

    [base-2012r2-2016-10-20] The term 'chef-client' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
                             At line:1 char:77
                             + $env:path = [System.Environment]::GetEnvironmentVariable('PATH', 'MACHINE');chef ...
                             +                                                                             ~~~~
                                 + CategoryInfo          : ObjectNotFound: (chef-client:String) [], CommandNotFoundException
                                 + FullyQualifiedErrorId : CommandNotFoundException

Just changing to shell(:elevated) seems to make it timeout....

Well this is fun. When I put a breakpoint here and run execute('pwd', :timeout => 10) it succeeds. But if I let the code go I get a "#<Timeout::Error: execution expired>"... Investigating further

Backtrace:
"/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/httpclient-<IP_ADDRESS>/lib/httpclient/session.rb:799:in `gets'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/httpclient-<IP_ADDRESS>/lib/httpclient/session.rb:799:in `block in parse_header'",
 "/Users/tball/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/timeout.rb:91:in `block in timeout'",
 "/Users/tball/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/timeout.rb:101:in `timeout'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/httpclient-<IP_ADDRESS>/lib/httpclient/session.rb:795:in `parse_header'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/httpclient-<IP_ADDRESS>/lib/httpclient/session.rb:778:in `read_header'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/httpclient-<IP_ADDRESS>/lib/httpclient/session.rb:554:in `get_header'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/httpclient-<IP_ADDRESS>/lib/httpclient.rb:1297:in `do_get_header'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/httpclient-<IP_ADDRESS>/lib/httpclient.rb:1243:in `do_get_block'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/httpclient-<IP_ADDRESS>/lib/httpclient.rb:1017:in `block in do_request'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/httpclient-<IP_ADDRESS>/lib/httpclient.rb:1131:in `protect_keep_alive_disconnected'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/httpclient-<IP_ADDRESS>/lib/httpclient.rb:1012:in `do_request'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/httpclient-<IP_ADDRESS>/lib/httpclient.rb:854:in `request'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/httpclient-<IP_ADDRESS>/lib/httpclient.rb:763:in `post'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/winrm-2.1.0/lib/winrm/http/transport.rb:50:in `send_request'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/winrm-2.1.0/lib/winrm/wsmv/receive_response_reader.rb:95:in `send_get_output_message'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/winrm-2.1.0/lib/winrm/wsmv/receive_response_reader.rb:63:in `read_response'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/winrm-2.1.0/lib/winrm/psrp/receive_response_reader.rb:41:in `read_message'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/winrm-2.1.0/lib/winrm/psrp/receive_response_reader.rb:60:in `block in read_output'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/winrm-2.1.0/lib/winrm/wsmv/receive_response_reader.rb:75:in `with_output'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/winrm-2.1.0/lib/winrm/psrp/receive_response_reader.rb:59:in `read_output'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/winrm-2.1.0/lib/winrm/shells/base.rb:81:in `block in run'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/winrm-2.1.0/lib/winrm/shells/base.rb:127:in `with_command_shell'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/winrm-2.1.0/lib/winrm/shells/base.rb:80:in `run'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/gems/winrm-elevated-1.0.1/lib/winrm/shells/elevated.rb:56:in `run'",
 "/Users/tball/github/chef-provisioning/lib/chef/provisioning/transport/winrm.rb:42:in `block in execute'",
 "/Users/tball/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/timeout.rb:106:in `timeout'",
 "/Users/tball/github/chef-provisioning/lib/chef/provisioning/transport.rb:92:in `with_execute_timeout'",
 "/Users/tball/github/chef-provisioning/lib/chef/provisioning/transport/winrm.rb:40:in `execute'",
 "/Users/tball/github/chef-provisioning/lib/chef/provisioning/transport/winrm.rb:78:in `available?'",
 "/Users/tball/github/chef-provisioning-aws/lib/chef/provisioning/aws_driver/driver.rb:1335:in `wait_for_transport'",
 "/Users/tball/github/chef-provisioning-aws/lib/chef/provisioning/aws_driver/driver.rb:704:in `ready_machine'",
 "/Users/tball/github/chef-provisioning/lib/chef/provider/machine.rb:39:in `block in <class:Machine>'",
 "(eval):2:in `block in action_ready'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/bundler/gems/chef-f1ee3c3ad99a/lib/chef/provider.rb:361:in `instance_eval'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/bundler/gems/chef-f1ee3c3ad99a/lib/chef/provider.rb:361:in `compile_and_converge_action'",
 "(eval):2:in `action_ready'",
 "/Users/tball/github/chef-provisioning/lib/chef/provider/machine.rb:56:in `block in <class:Machine>'",
 "(eval):2:in `block in action_converge'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/bundler/gems/chef-f1ee3c3ad99a/lib/chef/provider.rb:361:in `instance_eval'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/bundler/gems/chef-f1ee3c3ad99a/lib/chef/provider.rb:361:in `compile_and_converge_action'",
 "(eval):2:in `action_converge'",
 "/Users/tball/.rvm/gems/ruby-2.3.1@cookbook-test-provisioning/bundler/gems/chef-f1ee3c3ad99a/lib/chef/provider.rb:145:in `run_action'",
...

Closing this in favor of https://github.com/chef/chef-provisioning/pull/562


NSX: Add CKS Support & Firewall rules for Isolated Networks

Description
This PR...

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan package

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7754

@blueorangutan package

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7764

@blueorangutan package

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7854

@blueorangutan package

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✖ el7 ✖ el8 ✖ el9 ✔ debian ✖ suse15. SL-JID 7933

@blueorangutan package

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 7935

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@nvazquez CKS works now for NSX - removed the mtu hack and created a separate offering for VPC tiers of deploying CKS cluster on NSX with conserve mode true.


Extended read permission and Github authorization

Github Organization task says that my owner is missing Task/ExtendedRead permission.
According to docs extended-read-permission plugin doesn't support Github authorization.
Whether it is a problem with Github Organization task only or something should be changed in one of these plugins.

Feature request for Github Branch Source plugin: https://issues.jenkins-ci.org/browse/JENKINS-44954


Homepage url not working correctly.

Using latest Chrome beta, if I go to http://angular-ui.github.io/bootstrap/#/pagination I get a 404 page at http://angular-ui.github.io/bootstrap/pagination

This is now fixed, as can be seen by clicking the links.


Support Swift 4

Hi there,
I would like to know if this project still be updated or not? If yes, is it possible to get a version for Swift 4? I've got an error during the compilation of the project using Carthage, it might be the explanation...
Many thanks

Swift 4 support would be much appreciated as Apple is killing support for Swift 3 in the near future.


use model base class for standalone compilation

Summary:
Replace use of templated type in command.hpp with a call to a factory method defined in the generated model class:
stan::model::model_base&
new_model(stan::io::var_context& data_context,
    unsigned int seed,
    std::ostream* msg_stream);

This depends on stan-dev/stan issue https://github.com/stan-dev/stan/issues/2759, which takes care of adding a virtual base class, a CRTP extension, and generating appropriate model code.
Current Output:
Is fine.
Expected Output:
Should not change.
Current Version:
v2.19.1

Model compilation is now taking 7s on my machine, including linking!
To try it yourself, check out branches:

stan-dev/cmdstan branch: feature/0712-model-base-class
stan-dev/stan branch:  feature/2759-model-base

The issues have the matching numbers.  Use the stan branch to generate appropriate .hpp files.
Here's how to compile from the top-level cmdstan directory, the various bits.  Make sure to put the generated .hpp file in the right place.
# build command (carpenter: 34s on my macbook)
time clang++ -std=c++1y -Wno-unknown-warning-option -Wno-tautological-compare -Wno-sign-compare -O3 -I src -I stan/src -I stan/lib/stan_math/ -I stan/lib/stan_math/lib/eigen_3.3.3 -I stan/lib/stan_math/lib/boost_1.69.0 -I stan/lib/stan_math/lib/sundials_4.1.0/include    -DBOOST_RESULT_OF_USE_TR1 -DBOOST_NO_DECLTYPE -DBOOST_DISABLE_ASSERTS -DBOOST_PHOENIX_NO_VARIADIC_EXPRESSION -c src/cmdstan/main.cpp

# precompiled header for models  (carpenter: 30s, 10s on my macbook)
time make O=3 stan/src/stan/model/model_header.d
time make O=3 stan/src/stan/model/model_header.hpp.gch

# build model (12s w/o precompiled header; 7s with)
cp src/cmdstan/big_norm.hpp src/cmdstan/big_norm.cpp
time clang++ -std=c++1y -Wno-unknown-warning-option -Wno-tautological-compare -Wno-sign-compare -O3 -include-pch stan/src/stan/model/model_header.hpp.gch -I src -I stan/src -I stan/lib/stan_math/ -I stan/lib/stan_math/lib/eigen_3.3.3 -I stan/lib/stan_math/lib/boost_1.69.0 -I stan/lib/stan_math/lib/sundials_4.1.0/include    -DBOOST_RESULT_OF_USE_TR1 -DBOOST_NO_DECLTYPE -DBOOST_DISABLE_ASSERTS -DBOOST_PHOENIX_NO_VARIADIC_EXPRESSION -c src/cmdstan/big_norm.cpp

# link
clang++ -o big_norm main.o big_norm.o

For discussion, see https://discourse.mc-stan.org/t/separate-compilation-of-model-and-services-code-complete/9565

just updated the makefile and rulesfile make/program  - works on my machine.

Here's how to compile from the top-level cmdstan directory, the various bits. Make sure to put the generated .hpp file in the right place.

this didn't actually work - perhaps not all of the sequence of session commands was captured?

@bob-carpenter I edited some comments, so please click through to issue from your email.

I think some steps were omitted from the console snippets given above.

Those were ones I was just cutting and pasting.  What failed when you tried it and what did you need to add to get it to work?

I'm not sure whether the difference in the 7s reported by Bob is due to different compile commands or the fact that his machine has faster processors. and testing on a different model,

The sundials and MPI libs are binaries, so I hope they don't add a lot to compile time.  I don't know what LBLIBS is.

To check if it's machine effect, can you compare new compile times vs. old compile times on your machine?

Did the precompiled headers get included?  In my example, I had 12s compile times w/o precompiled headers and 7s with.

on my machine, bernoulli model under CmdStan 2.19.1 takes 23 sec to compile executible from bernoulli.hpp.
for this PR,  the makefile rule that goes from .hpp file to executable takes 10 sec.
the makefile, as written, also generates a .d file - this takes 1-2 seconds on my machine.  is this necessary?    @syclik - do the Stan model files need a dependencies file?

found my error - precompiled headers are needed at compile time, not link time.
fixed and pushed.
bernoulli model, going from .hpp to executible:  now 7 secs, (2.19.1 is 23 seconds).
slightly larger model (bym2), now 9 secs, (2.19.1 is 28).

Bob, where is big_norm.hpp coming from? Just any model your using to test this on?

Yes, big_norm.hpp was just a simple example model.

On Jul 12, 2019, at 5:34 PM, Rob J Goedman<EMAIL_ADDRESS>wrote:
Bob, where is big_norm.hpp coming from? Just any model your using to test this on?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

addressed via PR https://github.com/stan-dev/cmdstan/pull/713


[Frontend] Nicer assert when -dump-parse foo.sil

What's in this pull request?

Invoking the following command to -dump-parse a file containing SIL triggers an assertion from within the Swift compiler frontend:
swiftc -dump-parse foo.sil

The assertion is not coupled with a description of what went wrong. It turns out the frontend doesn't support -dump-parse for SIL files, although swiftc -help wouldn't inform users of that:
-dump-parse      Parse input file(s) and dump AST(s)

As a result, a user may invoke -dump-parse on a SIL file and not know what went wrong. Add an assertion message to inform the user that only Swift code may be parsed. (IFK_Swift_Library here is for the case where swiftc -parse-as-library -dump-parse foo.swift is invoked.)
Resolved bug number: None

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

Seems reasonable!
@swift-ci Please smoke test


Using . instead of % to access a derived type component is non-standard.

Please consider changing logger_mo.f90 so that the standard % is used instead of . to access derived type components. Currently, compiling with gfortran gives errors such as
>gfortran -c logger_mo.f90
logger_mo.f90:103:16:

  103 |       call this.write ( file_macro, line_macro, '*** Erorr:', trim(iomsg) )
      |                1
Error: Junk after CALL at (1)
logger_mo.f90:122:16:

  122 |       call this.exec ( __FILE__, __LINE__, 'rm -f '//trim(this.file) )
      |                1
Error: Junk after CALL at (1)

Thank you very much for your advice!
I have changed . to % to follow the Fortran standard.


Inconsistent behavior with "in" operator

The following CQL code behaves differently when a ValueSetFacade is passed in and when a List<Code> is passed in.
To Reproduce
define fluent function "Code in"(coding FHIR.Coding, codes List<System.Code>):
coding in codes
The C# falls into context.Operators.CodeInList() function and it behaves differently for ValueSetFacade and List<Code>. When ValueSetFacade is passed in, only the code & system are checked. When a List<Code> is passed in then the code, system, version and display are checked.
Expected behavior
The function should behave the same. There needs to be a way to specify that you want the CodeInList operator to behave like Equivalent and not Equals.

@DamienM419 - does #79 fix this? Can I close this issue?

@ewoutkramer yes that PR fixes this issue and can be closed.


DirectML 1.8.2 depthwise convolution slow?

Hello,
I love DirectML but I'm experiencing slow depthwise convolutions (with group count equal to channel count) with DirectML 1.8.2 compared to regular convolutions, when in fact the depthwise convolution should be much faster (due to less filters and less operations). This is probably related to the meta commands not being supported. When debugging with various combinations of float32, float16, NCHW and NHWC, the depthwise convolution is always quite slow (e.g. when compared to Pytorch or the same convolution with 256 in/out channels and group count set to 1).
My depthwise convolution:

// Create the convolution operator description
ZeroMemory(&this->ConvolutionOperatorDesc, sizeof(this->ConvolutionOperatorDesc));
this->ConvolutionOperatorDesc.InputTensor = &inputTensor->TensorDesc; //1x256x320x180
this->ConvolutionOperatorDesc.FilterTensor = &this->WeightsTensor->TensorDesc; //256x1x3x3
this->ConvolutionOperatorDesc.BiasTensor = &this->BiasTensor->TensorDesc; //1x256x1x1
this->ConvolutionOperatorDesc.OutputTensor = &outputTensor->TensorDesc; //1x256x320x180
this->ConvolutionOperatorDesc.Mode = DML_CONVOLUTION_MODE_CROSS_CORRELATION;
this->ConvolutionOperatorDesc.Direction = DML_CONVOLUTION_DIRECTION_FORWARD;
this->ConvolutionOperatorDesc.DimensionCount = 2;
this->ConvolutionOperatorDesc.Strides = this->Strides.data(); //1,1
this->ConvolutionOperatorDesc.Dilations = this->Dilations.data(); //1,1
this->ConvolutionOperatorDesc.StartPadding = this->StartPadding.data(); //1,1
this->ConvolutionOperatorDesc.EndPadding = this->EndPadding.data(); //1,1
this->ConvolutionOperatorDesc.OutputPadding = this->OutputPadding.data(); //0,0
this->ConvolutionOperatorDesc.GroupCount = 256;
this->ConvolutionOperatorDesc.FusedActivation = fusedActivationDesc; //LeakyRelu 0.2

Debug Output:

D3D12 MESSAGE: ID3D12GraphicsCommandList::CreateMetaCommand: MetaCommand parameters are not supported by the current system configuration. [ STATE_CREATION MESSAGE #1172: META_COMMAND_UNSUPPORTED_PARAMS]
D3D12 ERROR: ID3D12CommandQueue::ExecuteCommandLists: The MetaCommand (0x000001C4C3C06CD0:'Unnamed ID3D12MetaCommand Object') was used in ExecuteMetaCommand before calling InitializeMetaCommand with the same MetaCommand [ EXECUTION ERROR #1175: UNINITIALIZED_META_COMMAND]
...

Benchmark: depthwise convolution 256 channels, 3x3 kernel, 256 groups (like above)

float32 and NCHW: 99ms
float32 and NHWC: 610ms
float16 and NCHW: 191ms
float16 and NHWC: 312ms

Benchmark: regular convolution 256->256 channels, 3x3 kernel, 1 group

float32 and NCHW: 284ms
float32 and NHWC: 508ms
float16 and NCHW: 298ms
float16 and NHWC: 61ms

As you can see, the depthwise convolution is even slower than the regular convolution in some cases.
My setup

Windows 10 Home
Version 10.0.19044 Build 19044
Intel Core i5-9600K
Nvidia RTX 3080 Ti

I would really like to use hardware efficient dephwise convolutions to make my neural network faster.
Am I doing something wrong here or are depthwise convolutions just slow in DirectML?

Maybe unrelated to the problem, but the debug output seems to indicate you're not running the operator initializer before using the operator like in https://github.com/microsoft/DirectML/blob/master/Samples/HelloDirectML/main.cpp#L212

Thanks, but I think that debug output is due to another operator that I'm calling after the convolution (which I am indeed not initializing). Sorry for the confusion, I should not have added it to the debug output.


Application Insights support

There is already support for Google Analytics, how about adding support for Application Insights?
I think it may be an interesting alternative especially if someone uses Azure to host his minima blog.

Google Analytics is an exception, like Disqus. Those services were added because they are used by a vast majority. We don't plan to add other external services for now.
Minima has to live by its name 😄


Add a button for a fixed duration task

Hi, I'd love if Hackaru includes a button that simply allows the duration to be set to an exact length, say 1 hour. I want to compare how often I have been performing tasks, so that I can see the count, not the duration. eg: I want to see that I did coding 5 times this week and exercise 3 times. Knowing this count is more important to me than knowing that I was coding was 8 hours and exercising for 2 hours. When starting the timer for a task, if you included a button that says "Perform 1 hour" or something like that, then it can be achieved without changing anything else in the project :-)
So if you can please add this feature, I would be very grateful!

Hello, thank you very much for your feedback!
Your feedback is very informative, but at this point we are unable to make a decision to add that feature.
Basically, this is a time tracking app, but not a habit tracking app to see the count.
However, if we receive many requests from users, we will consider adding this feature.


New version: SaltStack.SaltMinion version 30.04.1

- [X] Have you signed the Contributor License Agreement?

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Does your manifest conform to the 1.1 schema?

Resolves #56825

Microsoft Reviewers: Open in CodeFlow

#55485


update to version 4.24?

I got the following error when going to 4.24:
https://forums.unrealengine.com/community/work-in-progress/1644397-node-js?p=1714980#post1714980

Addressed with release: https://github.com/getnamo/nodejs-ue4/releases/tag/0.5.0, open new issue if new related problems appear


Recursive Solution to Superposition -> FourBitstringSuperposition

Alternative Solution to add to reference implementations
Would there be any interest in adding a recursive solution to the Superposition.ReferenceImplemention.qs file for the FourBitstringSuperposition task?  Personally, I struggled with the ancillae-based solution, but recursion made sense to me.  I wrote the following solution, which passes the unit test cases as well as offers extensibility to n-bit string superpositions.
Proposed additional solution:
// Task 15*. Superposition of four bit strings
    // Inputs:
    //      1) N qubits in |0...0⟩ state
    //      2) four bit string represented as Bool[][] bits
    //         bits is an array of size 4 x N which describes the bit strings as follows:
    //         bits[i] describes the i-th bit string and has N elements.
    //         All four bit strings will be distinct.
    //
    // Goal: create an equal superposition of the four basis states given by the bit strings.
    //
    // Example: for N = 3 and bits = [[false, true, false], [true, false, false], [false, false, true], [true, true, false]]
    //          the state you need to prepare is (|010⟩ + |100⟩ + |001⟩ + |110⟩) / 2.
   operation FourBitstringSuperposition (qs : Qubit[], bits : Bool[][]) : Unit {
        FourBitstringSuperposition_Recursive(new Bool[0],qs,bits);
    }

    operation FourBitstringSuperposition_Recursive (currentBitString : Bool[], qs : Qubit[], bits : Bool[][]) : Unit {
        //an array of bit strings whose columns we are considering begin with |0>
        mutable zeroLeads = new Bool[][0];
        //an array of bit strings whose columns we are considering begin with |1>
        mutable oneLeads = new Bool[][0];
        //rows is more intuitive to read
        let rows = Length(bits);
        //figure out what percentage of the bits should be |0>
        if (rows >= 1 and Length(currentBitString) < Length(qs)) {
            for (row in 0..rows-1) {
                if (bits[row][Length(currentBitString)]) {
                    set oneLeads = oneLeads + [bits[row]];
                } else {
                    set zeroLeads = zeroLeads + [bits[row]];
                }
            }
            //rotate the qubit to make the percentage happen based on the previous bit string
            //for the first path through when bitstring is of zero length, it should do the rotation regardless.
            let theta = ArcCos(Sqrt(IntAsDouble(Length(zeroLeads))/IntAsDouble(Length(bits))));
            (ControlledOnBitString(currentBitString, Ry))(qs[0..Length(currentBitString)-1], (2.0 * theta , qs[Length(currentBitString)]));
            //call myself again based on the bit strings so far.
            FourBitstringSuperposition_Recursive(currentBitString + [false],qs,zeroLeads);
            FourBitstringSuperposition_Recursive(currentBitString + [true],qs,oneLeads);
        }

    }

Also, as long as the ControlledOnBitString continues to handle the "no control" the same, you can do this with about half the code:
operation FourBitstringSuperposition (qs : Qubit[], bits : Bool[][]) : Unit {
        FourBitstringSuperposition_Recursive(new Bool[0],qs,bits);
    }

    operation FourBitstringSuperposition_Recursive (currentBitString : Bool[], qs : Qubit[], bits : Bool[][]) : Unit {
        //an array of bit strings whose columns we are considering begin with |0>
        mutable zeroLeads = new Bool[][0];
        //an array of bit strings whose columns we are considering begin with |1>
        mutable oneLeads = new Bool[][0];
        //rows is more intuitive to read
        let rows = Length(bits);
        //figure out what percentage of the bits should be |0>
        if (rows >= 1 and Length(currentBitString) < Length(qs)) {
            for (row in 0..rows-1) {
                if (bits[row][Length(currentBitString)]) {
                    set oneLeads = oneLeads + [bits[row]];
                } else {
                    set zeroLeads = zeroLeads + [bits[row]];
                }
            }
            //rotate the qubit to make the percentage happen based on the previous bit string
            (ControlledOnBitString(currentBitString, Ry))(qs[0..Length(currentBitString)-1], (2.0 * ArcCos(Sqrt(IntAsDouble(Length(zeroLeads))/IntAsDouble(Length(bits)))) , qs[Length(currentBitString)]));
            //call myself again based on the bit strings so far.
            FourBitstringSuperposition_Recursive(currentBitString + [false],qs,zeroLeads);
            FourBitstringSuperposition_Recursive(currentBitString + [true],qs,oneLeads);
        }

    }

The ControlledOnBitString method seems to do the rotation regardless on an empty control.  If that behavior is planned to be maintained, the code contracts nicely to the edit above because the first rotation has to happen.  Hopefully it is readable enough to get the strategy across...
Thanks!

This definitely looks interesting! I think that with a bit more generalization you can get from this solution all the way to the one we use in our library.
I think it would be a better fit for the Superposition workbook, so that you could include a step-by-step explanation of how to get to this solution along with the code itself. @jimcristofono and @ScottCarda-MS are working on the workbook for task 15 now - once they are done, you could add this solution to it. Would that work for you?

I'd be happy to do that if it helps.
I didn't know about the PrepareArbitraryState() method, so thanks for pointing that out.  It would definitely be more elegant to just use it than recursion
    //assumes appropriate includes for Microsoft.Quantum.{Preparation,Arithmetic}
    operation FourBitstringSuperposition (qs : Qubit[], bits : Bool[][]) : Unit {
        mutable coefficients = new ComplexPolar[PowI(2,Length(qs))];
        for (row in 0..Length(bits)-1) {
            set coefficients w/= BoolArrayAsInt(bits[row]) <- ComplexPolar(1.0,0.0);
        }
        PrepareArbitraryState(coefficients,LittleEndian(qs));
    }

Would the recursive solution still be useful, or is it better to skip that and utilize the PrepareArbitraryState() approach to superposition problems?

It was my understanding that the PrepareArbitraryState method was not to be used in this Kata as it makes the tasks trivial. @tcNickolas Maybe I misunderstood?

Yea, exactly! We use these tasks as training material to build up skills on state manipulation, and describing a recursive solution would be very useful for this purpose - more useful than just referring to a library function that does all the magic for us but doesn't teach the learner any interesting way of thinking.

Ok.  Great!  That makes sense.

@cdberkstresser The workbook for task 15 of the Superposition kata is finally merged to master (sorry it took me so long to review it!)
If you're still interested in contributing a description of the recursive solution, you're most welcome to do so!

@tcNickolas Would be happy to!  Hoping to sit down with this on the upcoming weekend.

Submitted Pull Request #324 .  Thanks!


Add documentation about NetworkIsolation on UWP for remote debugging

Add documentation about NetworkIsolation on UWP for remote debugging

Done


When creating a stack using docker-compose/rancher-compose encounters api error for service creation , stack is stuck in "Activating" state forever.

Rancher Version:v1.0.0
Steps to reproduce the problem:
Create a stack by providing the following docker-compose.yml which has name field with "." which will fail API validation
test.client2:
  labels:
    io.rancher.container.pull_image: always
  tty: true
  image: nginx
  stdin_open: true

Stack creation fails and  is stuck in "Activating" state forever.

Expected Behavior:
Stack should be created successfully.
But the service creation failure should be notified to the user.

This issue is not seen anymore when testing with latest build from master.
Related issue tracked in https://github.com/rancher/rancher/issues/6284


[BEAM-6085] Revert "[BEAM-5442] Revert #6675 "Revert PRs #6557 #6589 #6600""

This reverts commit 1e8ba268d4d16d60809215170edce73ab82c2264.
This will only be reverted from release 2.9.0 branch as per following discussion.
<EMAIL_ADDRESS>Please add a meaningful description for your change here

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Thanks.

Thank you!


Failed to activate custom 'one-dark-ui' package

[Enter steps to reproduce below:]

Follow guide on how to make custom theme
Run Atom

Atom Version: 1.0.11
System: Mac OS X 10.9.4
Thrown From: Atom Core
Stack Trace
Failed to activate the rm-dark-ui package
At Cannot read property 'toLowerCase' of undefined

TypeError: Cannot read property 'toLowerCase' of undefined
    at setLayoutMode (/Users/rasmus/Documents/Github/one-dark-ui/lib/main.coffee:56:63)
    at Object.module.exports.activate (/Users/rasmus/Documents/Github/one-dark-ui/lib/main.coffee:36:5)
    at ThemePackage.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:243:19)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/theme-package.js:48:26
    at ThemePackage.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:167:15)
    at ThemePackage.module.exports.ThemePackage.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/theme-package.js:43:12)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:486:21)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/theme-manager.js:361:50
    at Config.module.exports.Config.observeKeyPath (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:568:7)
    at Config.module.exports.Config.observe (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:135:21)

Commands

Config
{
  "core": {
    "audioBeep": false,
    "themes": [
      "rm-dark-ui",
      "rm-dark-syntax"
    ]
  },
  "editor": {
    "invisibles": {},
    "tabLength": 4,
    "showIndentGuide": true,
    "fontSize": 15
  }
}

Installed Packages
# User
pigments, v0.13.2
rm-dark-syntax, v0.1.0
rm-dark-ui, v0.1.0

# Dev
No dev packages

You probably didn't add the configuration schema for your package.
Aren't you missing this?


T::Private::Abstract::Data in sorbet-runtime triggering deprecated warning

I think that this warning:
<EMAIL_ADDRESS>sorbet-0.4.4525/lib/hidden-definition-finder.rb:214:
warning: constant ::Data is deprecated

is being triggered by:
<EMAIL_ADDRESS>sorbet-runtime-0.4.4525/lib/types/private/abstract/data.rb:
module T::Private::Abstract::Data

You can always reopen it if ya'll want to.