GEODE-240: Remove deprecated methods on TransactionEvent

Removed deprecated methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents from the TransactionEvent.
Removed implementation for methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents from TxEvent and TxRmtEvent.
Added utility methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents in TxEventTestUtil.
Changed tests to use the new utilty methods from TxEventTestUtil.
Signed-off-by: Shankar<EMAIL_ADDRESS>Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Yes.  GEODE-240
[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?
Yes.
[x] Is your initial contribution a single, squashed commit?
Yes.
[x] Does gradlew build run cleanly?
Yes.
[x] Have you written or updated unit tests to verify your changes?
Yes.
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Not applicable.

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

+1 LGTM

This looks good

+1 LGTM

Thanks @ameybarve15  @dschneider-pivotal @davinash for the review.

Can this PR be merged?


How many public keys in Encryption

Hi,
var encrypted = crypt.encrypt([publicKey1, publicKey2, publicKey3], message);
Regarding encrypting with multiple public keys , is there any limit on how many public keys it can encrypt with ?
If there is a limit , can it be increased ?
Thanks,
Chitta

Hey! There is no such limit. However, the size of the encrypted message increases per each encryption key as keys' fingerprints and encrypted AES keys must be stored into encrypted message:
{
    "v": "hybrid-crypto-js_0.1.2",        // Current package version
    "iv": "CmtyaZTyzoAp1mTNUTztic0v1...", // Initialization vector
    "keys": {                             // Encrypted AES keys by RSA fingerprints
        "85:3d:10:e1:56...": "bHaTF9...",
        "d3:48:6a:e9:13...": "t9eds3..."
    },
    "cipher": "+iwVFsC2dECBQvwcm9DND..."  // Actual encrypted message
    "signature": "sdL93kfdm12feds3C2..."  // Signature (optional)
}


Add E2E tests

This adds E2E tests for Airseeker.

This is ready for review. Sorry about the mess with commits :facepalm:, it should be quite straight forward to go through the file changes, though.

I tried decreasing all the timers and it passes for me locally: https://github.com/api3dao/airseeker/commit/83d772cb229f555358b13e2c51aa361e0b1c2591

Mhh, I was not getting this error when I disabled this wait time and ran the test locally 🤔 . But can't you make the server return more future timestamps instead of this waiting?

Ignore this. I tried rerunning this and it doesn't work for me either...

@vponline Can you maybe rebase so there are not 111 commits in this PR? :sweat_smile:

@vponline Can you maybe rebase so there are not 111 commits in this PR? sweat_smile

Fixed, sorry about that :sweat_smile:


refactor module, fix types and add JsDoc

Motivation
The module follow style convention of C instead of Deno/Typescript, there is also some type errors to fix and refactor to do.
Changes

Change style conventions.
Cache webui-2 lib with static import via ejm.sh. Lib is cached before runtime and can be replace by local one if needed.
Refactor some parts.
Add symbols to ffi.
Add JsDoc to all exports.
Fix deprecated.
Split code to improve readability and maintainability.

I don't know if the project follow semantic versionning so I don't update version.

Hi @JOTSR, Thank you for this significant improvement. We genuinely appreciate it.

I don't know if the project follow semantic versionning so I don't update version

I guess yes, we should upgrade the version to <IP_ADDRESS>.
And according to this discussion, we should stay with 2.3.0.x.y (Major.Minor) to keep in sync with the original core library version. Not mandatory, but preferable.


nested panel example

Because the limitation about "panel cannot inside panel" is gone, I try to modify main.lua and add pGame into pGrid.
In my mind, the widget inside pGame will auto resize(or clip) for fixing grid layout.
But I totally mess up as following image:

I think it is not bug, but a nested panel demo maybe helpful.

My bad, those limitations are still part of GÖÖi, I accidentally removed the list in the last update, I added it again.

Got it!


Cookie is returning fairos.io only domain

Describe the bug
The cookie used to authenticate / session manage is set at fairos.io
To Reproduce
Login or signup, check console/xhr and see the contents of the cookie
Expected behavior
A cookie that's being set for *.fairdrive.io

Added a falg to add the domain to be returned --cookieDomain


Throw an error when a user uses FromForm attribute with IFormFile in …

…controller methods

Needs a test.

Added

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.37%. Comparing base (3416927) to head (22cfe86).
Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2840      +/-   ##
==========================================
+ Coverage   92.06%   92.37%   +0.31%
==========================================
  Files          93       93
  Lines        3111     3160      +49
  Branches      536      556      +20
==========================================
+ Hits         2864     2919      +55
+ Misses        247      241       -6

Flag
Coverage Δ

Linux
92.37% <100.00%> (+0.31%)
:arrow_up:

Windows
?

macOS
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks!


Don't print compiler messages when --quiet is passed

r? @Emilgardis
(rust_highfive has picked a reviewer for you, use r? to override)

The CI error has nothing to do with this pull request. It appears that LLVM have renamed -arch-name to --arch-name.

The CI error has nothing to do with this pull request. It appears that -arch-name has been renamed to --arch-name in LLVM 11.

Meh. :(

Seems like double hyphen style long options also work before LLVM 11 and they've deprecated the single hyphen ones in LLVM 11.
I've created #92 to change that, let's see whether CI agrees...


Envoy HTTP Local rate Limit Inconsistent Token available with load

We currently implement an envoy filter using Istio for HTTP Local rate limiting, We had se the rate limit at 100 request per second which I acknowledge is fairly low. Across 1 Gateway pod so we expected to see around ~100 RPS or 6,000rpm allowed. , as we saw our traffic climb up to 5,000 RPS or 300,000rpm. We saw the tokens available go up to around 300RPS or 19,000 rpm.
With that said some key points I would like to include we are using descriptor paths to set our health checks at a higher point but since we aren't calling there I do not think that should matter. As well for the test we had it in a count mode with the filter not enforced. Auto scaling was also turned off for this load test. CPU at the time was set to 46%
Looking to see if anyone has any explanation for this behavior. Since it worked perfectly fine up until 2,000 rps

cc @wbpcode who has been looking at this recently

could you provide a configuration about your test?

spec:
  configPatches:
  - applyTo: HTTP_FILTER
    match:
      context: GATEWAY
      listener:
        filterChain:
          filter:
            name: envoy.filters.network.http_connection_manager
    patch:
      operation: INSERT_BEFORE
      value:
        name: envoy.filters.http.local_ratelimit
        typed_config:
          '@type': type.googleapis.com/udpa.type.v1.TypedStruct
          type_url: type.googleapis.com/envoy.extensions.filters.http.local_ratelimit.v3.LocalRateLimit
          value:
            stat_prefix: http_local_rate_limiter
  - applyTo: HTTP_ROUTE
    match:
      context: GATEWAY
    patch:
      operation: MERGE
      value:
        route:
          rate_limits:
          - actions:
            - remote_address: {}
          - actions:
            - header_value_match:
                descriptor_value: healthcheck
                expect_match: false
                headers:
                - name: :path
                  string_match:
                    ignore_case: true
                    prefix: /healthcheck/
        typed_per_filter_config:
          envoy.filters.http.local_ratelimit:
            '@type': type.googleapis.com/envoy.extensions.filters.http.local_ratelimit.v3.LocalRateLimit
            always_consume_default_token_bucket: false
            descriptors:
            - entries:
              - key: header_match
                value: service
              token_bucket:
                fill_interval: 1s
                max_tokens: 100
                tokens_per_fill: 100
            enable_x_ratelimit_headers: DRAFT_VERSION_03
            filter_enabled:
              default_value:
                denominator: HUNDRED
                numerator: 100
              runtime_key: http_local_rate_limiter
            filter_enforced:
              default_value:
                denominator: HUNDRED
                numerator: 0
              runtime_key: http_local_rate_limiter
            response_headers_to_add:
            - append: false
              header:
                key: x-local-rate-limit
                value: "true"
            stat_prefix: http_local_rate_limiter
            token_bucket:
              fill_interval: 1s
              max_tokens: 1100
              tokens_per_fill: 1100
  workloadSelector:
    labels:
      app.kubernetes.io/component: istio-ingressgateway

cc @cam634 The configuration seems fine. From the configuration, the requests with /healthcheck/ path will be limited to 100/s and other request will be limited to 1100/s? Right?
Are you ensure the test requests have the expected prefix? Could you also give an example?
(PS: the current local rate limit use a timer based token bucket which sometime are inaccurate. But you results still be weird because the difference is too big)

Yeah that's exactly what we are trying to do,

Are you ensure the test requests have the expected prefix? Could you also give an example?
This was an original thought of mine but something that debunked that for me was we hold at the right number that should be rate limited until about 2,000 RPS. We were calling a path called /ping. I have not looked in the current code but could the filter possibly be overwhelmed at certain rates. Since it doesn't directly correlate with RPS coming in that it's leaking up.

Is there anything else you may recommend looking into CC: @wbpcode

@cam634 actually, I have no other idea about this problem if you actually disable the HPA. I am working a new token bucket solution which could provide more stable result. But it still need some more time.

In the case some else stumbles upon this we tried to retest with a higher limit & also higher time frame separate times. We found the higher limit at 1 second completely didn't work. Then after increasing the time frame we realized at 150,000 rpm or 2,500rps each time we saw this issue arise. So we confirmed after that rate we see the limit double we did confirm we saw no HPA activity.

Followup found the reason. Turns out it was by the host it is currently setup on our ingress  with the gateway and ex we have one route name test1.com & test2.com and each one of them have their own limit can we have a combined limit ?
CC: @wbpcode

Figured it outs because the HTTP-ROUTE which distributes the changes to the services envoy proxies instead of taking effect at the istio gateway. So each service has there own rate limit.


Question: where are No One's Boulder 13-15 from?

These No One games have long been considered lost, but they were recently added to the "caves" folder. So now I wonder about the source of these games. Please let me know!
Also I want to use the opportunity for a big THANK YOU revvv! GDash has been improved so much thanks to your efforts already :)

I guess they are from @cwscws C64 Boulder Dash collection: https://github.com/revvv/gdash-export-CrLi/issues/43#issuecomment-1699231581

Yeah, this was the PR #44
@Dustin974 wrote:

Also I want to use the opportunity for a big THANK YOU revvv! GDash has been improved so much thanks to your efforts already :)

You're welcome! Great to hear that!


Fixing issues

Needed to fix some stuff so that the thing will actually build.
Steps to reproduce:
-Revert to previous commit
-Slap the project into Android Studio
-Basically fix each error that comes up
Additional stuff:

Switching over to buildTools 28

Fixed the issue here (i think) because it builds just fine for me now.


v2 system

contains cli for creating and bundling plugins
plugin add cli
i will add remove and force fetch later
pluginManager to load plugins

Otherwise everything good.


Superscript formulas

Follow-up on #868
All useful superscript characters (see https://www.compart.com/en/unicode/search?q=superscript#characters) are now supported. This means that following characters are also supported in superscript form: ( ) + - n i
The only other one that might be useful is the superscript equals sign, but I don't really see a use case for that one.

Thanks for this! I've merged it in, but I changed the way it was defined so the replacements are easier to change, and I added superscript equals for completeness.


✨ Blog Posts - View Mode

cc: @landonmaxwell
🩸 Pain
Currently when content editors are trying to create new blog posts there is no way for them to preview the markdown before clicking 'SAVE'
✨ Solution
Have a preview mode for markdown text (like how GitHub does when im writing this PBI)

@joshbermanssw
Is this a TinaCMS issue or a TinaCloud issue?


All application buttons with transition

Following up https://github.com/merakiui/merakiui/pull/21

I've added the same transition to all application buttons (not the ui components). In order to do so I abstracted everything into an AppButton component instead of adding the same classes everywhere. I can also setup a utility class for that if you think it is better.
By the end I added some hover effect into the scroll-top button and used AppButton. I can also remove it if that is too much.

This is awesome I like the component idea thanks man 🤠 if you have time I have a feature want to add it but never have time to work on it 😓, it's simple but need some work hehe the components responsive test like Tailwind UI make div resizable to show components on different width if you have time and you want to help you can tweak it  😁.
Thanks again man I appreciate this 🧑🏽 🤝.

This is awesome I like the component idea thanks man 🤠 if you have time I have a feature want to add it but never have time to work on it 😓, it's simple but need some work hehe the components responsive test like Tailwind UI make div resizable to show components on different width if you have time and you want to help you can tweak it 😁.
Thanks again man I appreciate this 🧑🏽 🤝.

Hey!
Yeah, I could try, nonetheless I would recommend you to open an issue and explain the exact behavior you expect. I've also couple of questions and if you think issues are the best place to put them, I will do so.


In assignment Type Union is resolved as Intersection

TypeScript Version:  Nightly

Search Terms:
Type Union, Type check during assignment
Expected behavior:
Some error i.e.
19:7 - error TS2339: Property 'c' does not exist on type 'tAB'.

19 c: false,

Actual behavior:
exits with status 0

Related Issues:
Code
type tAB = {
  a: string
  b: number
}
type tAC = {
  a: string
  c: boolean
}

type tUnion = tAB | tAC

//@ts-ignore Type '{}' is not assignable to type 'tUnion'
const empty: tUnion = {}

//No ts-error but should be
const union: tUnion = {
  a: '',
  b: 0,
  c: false,
}
//@ts-ignore  Property 'b' does not exist on type 'tAC'
union.b

Output
"use strict";
//@ts-ignore Type '{}' is not assignable to type 'tUnion'
const empty = {};
//No ts-error but should be
const union = {
    a: '',
    b: 0,
    c: false,
};
//@ts-ignore  Property 'b' does not exist on type 'tAC'
union.b;

Compiler Options
{
  "compilerOptions": {
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictPropertyInitialization": true,
    "strictBindCallApply": true,
    "noImplicitThis": true,
    "noImplicitReturns": true,
    "useDefineForClassFields": false,
    "alwaysStrict": true,
    "allowUnreachableCode": false,
    "allowUnusedLabels": false,
    "downlevelIteration": false,
    "noEmitHelpers": false,
    "noLib": false,
    "noStrictGenericChecks": false,
    "noUnusedLocals": false,
    "noUnusedParameters": false,
    "esModuleInterop": true,
    "preserveConstEnums": false,
    "removeComments": false,
    "skipLibCheck": false,
    "checkJs": false,
    "allowJs": false,
    "declaration": true,
    "experimentalDecorators": false,
    "emitDecoratorMetadata": false,
    "target": "ES2017",
    "module": "ESNext"
  }
}

Playground Link: Provided

Unions are not mutually exclusive. You have a valid tAB and a valid tAC; no type violation has occurred.

I see that they are exclusive - working like operator XOR or JsonSchema's oneOf
https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=24&pc=1#code/C4TwDgpgBMCCUF4oG8BQUoEMBcUDOwATgJYB2A5qgL6qiQwBCiK6UARrqQK4C2bEhaqlrhowAKqliAe1LM4UAD6NhAY1kEoXKbNwSdcpGgw4oAcjMAaVhygAGazVTEAZlAAUZtmahktBgEpWAHpgmFEoAAsyYCw8KHVSTW0ZUj0GVlcPMwATHz8U2SCMDFCoAAVCaUhCUHM8qBzpCHjSaViIAA9iTVlw+jNSCAA3ATMAOlYMQtJxnNQgA
type tA = {
  a: string
}
type tB = {
  b: number
}

type tUnion = tA | tB

const union: tUnion = {
  a: '',
  b: 0,
}

if ('b' in union)
  // type hint as const union: tB
  if ('d' in union)
    //TSError: Property 'd' does not exist on type 'never'.ts(2339)
    union.d

https://en.wikipedia.org/wiki/Union_type also thinks that  better to have XOR  rather than mathematical union

@RyanCavanaugh so it is not working as intended

How to reopen it?

@askirmas This is the intended behavior; truly it is.

So please explain why here type resolved to never
https://github.com/microsoft/TypeScript/issues/38159#issuecomment-619108680

I don't think you meant to at me, but consider: https://www.typescriptlang.org/play/#code/C4TwDgpgBMCCUF4oG8CwAoKUCGAuKAzsAE4CWAdgOYYC+GokMAQoihlgEb7kCuAthwjFaGeuGjAAquVIB7cqzhQAPsxVQAFEoBkzAJSj0AY3lEoPGfPxTLCpGkw58AcmcAadlC5QADB-R06BikAGaazhzOUBTmtgaOAPQJMOJQABYUwDgEUCbkZhZy5NZMnqHh2FExhfLxWFhJACoAygCixMSyxPgACp2QxKBQzpVQACayEDnkslkQAB6kZvIpjM7kEABuQs4AdMAEGgBMAMwnAJx19TXku9hAA

Oh, miss in mention, sorry.
I know that OR pattern - just a bit up https://github.com/microsoft/TypeScript/issues/38159#issuecomment-619112350. My question in XOR that doesn't working in assignment statement


fixed compilation key error

the following error was returned during compilation
FLUENTEXPR.PRW(25)   Regular functions are not allowed in code.Use USER FUNCTION or STATIC FUNCTION at line 25.[Projeto: advpl-testsuite]
Chave de compilação não informada.
ReadFileContents was moved to testsuite.ch as a STATIC FUNCION
see issue #3

Actually this introduced a few errors. I will comment on the files.


Lumerical exports sparameters with a capital 'S' in v221.

Thank you Thomas

just released v3.10.3 with your improvement


Nav app is getting replaced by the route app in the dom sometimes on page load

I have 2 angular 12 apps as parcels created using single spa generator
i use one of the app in 'NAV' and the other one in a 'Route'
the issue that i am coming across is sometimes the app which is supposed to load for the route replaces the app which is supposed to load in the nav in the dom. Why is this happening.
This issue can be reproduced by creating new angular apps via the generator

I don't spend much time maintaining single-spa-angular, but welcome pull requests to address any issues. There are a few others who occasionally help in maintaining it, but they are not very active right now in doing so. I'll keep this issue open for others to comment on - the most helpful thing you can do would be to provide a github repository demonstrating the issue. A screen recording is not sufficient to diagnose issues in a lot of cases.

I figured out the issue. This was caused because both the applications have the same prefix "app" . The prefixes need to different if two angular apps need to run simultaneously in the DOM. Yes it is present in the documentation, but since i generated these projects using "create-single-spa" generator i dont have control over how the angular project is created and specify my own prefix while creation. I think there should be an option to allow to enter the project prefix in the create-single-spa generator for Angular framework.

Closing since you found a fix


Console warning cannot update during an existing state transition

Describe the bug
On initial load warning displays path=/story/intro-overview--px-blue-react-components
Cannot update during an existing state transition (such as within render). Render methods should be a pure function of props and state.
in Unknown (created by Context.Consumer)
in WithTheme(Component)
in WithTheme(Component) (created by Preview)
in div (created by Context.Consumer)
in Side (created by FlexBar)
in div (created by Context.Consumer)
in Styled(div) (created by FlexBar)
in div (created by SimpleBar)
in div (created by SimpleBar)
in div (created by SimpleBar)
in div (created by SimpleBar)
in div (created by SimpleBar)
in div (created by SimpleBar)
in SimpleBar...
What is the expected behavior?
no warning
What are the steps to reproduce?

Run react storybook
Dev tools

Screenshots or links to minimum reproduction example
What is your environment?

Framework

[ ] Angular
[ ] React
[ ] Ionic
[ ] React Native

Browser

[ ] Internet Explorer
[ ] Edge
[ ] Safari
[X] Chrome
[X] Firefox

Operating System

[ ] MacOS
[X] Windows
[ ] Other

Anything else to add?

This appears to be an upstream bug in the @storybook-addons plugin (https://github.com/storybookjs/storybook/issues/10204). Disabling the plugin makes the error go away, so that's one way we could fix it but we would lose the viewport dropdown picker (not sure how valuable that is). It also appears to be resolved in storybook 6.

I'm putting wont-fix labels on anything related to storybook at this point.  Closing this issue.


Fix 0x071 for grouped batching

AB#5964
TODO: need to update snapshot tests for new format (if that's the path we want to take)

In either the PR or the AB issue would be good to include a description of what triggers the bug, and ideally the premise of the fix too.

Chatted offline, I'm recommending to just relax the assert to >= rather than doing all the clientSequenceNumber stuff.  Probably a low-value assert overall anyway, it appears to just be validating that we're processing writes in order which should already be guaranteed by the lower layers.


mzxml data result

@josoriom Please check the result of the parsing for mzXML.
Currently the values are crazy, at least in the case of the 32 bits and I don't know why. Even the length of one of the test is not a multiple of 4.
Please add some tests on the expect values. For the 64 bits example the first data point should be 100 I think.

Also in the XML we have in the block the number of points. This could also be used in the check to be sure it is the correct number rather than relying on the result.


Register page

before :

after :

before :
after :

Opened #212

I ran a full import optimization FYI @notKamui

"On a bien travaillé"


Bring back Orders and positions on a Chart

Console V1 and Pennant used to show open orders + positions on a chart. Console V2 doesn't.
It would be good it it did.

The functionality is present in pennant but we need to pass in the correct data to light the feature up.

We've had some user feedback requesting this feature https://github.com/vegaprotocol/feedback/discussions/106

Closing as superseded by #4248


How do we output ollama response to file?

If Ollama can read prompts from file, there has to be a way somehow to receive response to file and save it in the working directory.
How do I achieve this?
Scenario:
ollama run dolphin-phi

'/home/ai/repo/llama2.c/run.c' rewrite this code with arguments for blah... :smile:

Thanks.

If you're on a Unix-like system (Linux, MacOS) you should be able to just do something like:
ollama run dolphin-phi "prompt" >> response.md

I have tried this using some other models and it worked.

Thanks

If you're on a Unix-like system (Linux, MacOS) you should be able to just do something like:
ollama run dolphin-phi "prompt" >> response.md

I have tried this using some other models and it worked.

This is a big help.

  How can I get a clean output?

i developed  simple a bash script with the help of chatgpt to prompting.
`#!/bin/bash
Define the output file
output_file="Response.md"
# Ensure the output file is empty or create it if it doesn't exist
> "$output_file"
Loop until the user decides to exit
while true; do
# Prompt the user for input
read -p "Enter something (or type 'exit' to quit): " user_input
# Check if the user wants to exit
if [[ "$user_input" == "exit" ]]; then
    echo "Exiting..."
    break
fi

# Print the variable
echo -e "
======  Start of $user_input  ======
" >> "Response.md"

if [[ "$user_input" == *"-e"* ]]; then
  # Run the command and append the output directly to the file
  ollama run phi3:mini "explain/describe in easy way -$user_input" >> "$output_file"
else
  # Run the command and append the output directly to the file
  ollama run phi3:mini "$user_input" >> "$output_file"
fi

echo -e "
======  End of $user_input  ======
" >> "Response.md"

# Inform the user that the response has been saved
echo "The response has been saved to $output_file"

done
`


Enable to re-deploy github/remote deployed apps

Enable to re-deploy github/remote deployed apps

It would be nice to trigger a re-deploy from the UI, enabling stratos managed apps to be updated on demand
Context

Mostly, demonstrating the functionality of Stratos and adding value in the UI, but in the event of the need to trigger manually a rebuild from a source that is not currently available to push with cf push.

When not being able to access source, the build env and needing to push code that is more static. Or just because we need to quickly push from a branch.
Possible Implementation

it would be nice to provide a re-deploy button where the user us reminded where that application is hosted and which branch is being used to re-deploy. Additionally, if there are several replicas/instances, then perform a rolling rebuild vs a destructive rebuild.

Now implemented inV2


Prevent parsing userdata properties

Roblox recently added a FontFace property, which uses user data, this causes the plugin to error while serializing any TextBoxs/Labels. This simply prevents the plugin from parsing user data. Also resolves #4

"Roblox be consistent with their implementation of things" challenge when...
Looks good. No promises on when a new release will be pushed because I've been super busy recently.


Upgrade to S3Proxy 1.7.0

Release notes:
https://github.com/gaul/s3proxy/releases/tag/s3proxy-1.7.0

thanks for the contribution @gaul !


net/http: ReadTimeout is not honored when ReadHeaderTimeout > ReadTimeout

What version of Go are you using (go version)?

$ go version
go version go1.13.4 linux/amd64

Does this issue reproduce with the latest release?
It should.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build860032074=/tmp/go-build -gno-record-gcc-switches"

What did you do?
The following simple program runs a Hello World HTTP server with 5 second ReadTimeout and 10 second ReadHeaderTimeout.
package main

import (
	"fmt"
	"net/http"
	"time"
)

func main() {
	http.HandleFunc("/", HelloServer)
	server := &http.Server{
		Addr:              ":1234",
		ReadHeaderTimeout: 10 * time.Second,
		ReadTimeout:       5 * time.Second,
	}
	server.ListenAndServe()
}

func HelloServer(w http.ResponseWriter, r *http.Request) {
	fmt.Fprintf(w, "Hello, %s!", r.URL.Path[1:])
}

Start the server.  Now, test the timeouts by connecting as a client as follows, where nc is the netcat program.  The client initiates a connection but never sends any bytes containing request headers.
jamesjohnston-mac:website jamesjohnston$ time nc localhost 1234

real	0m10.019s
user	0m0.005s
sys	0m0.010s

What did you expect to see?
The connection should time out after 5 seconds.  The documentation for ReadTimeout states the following:
	// ReadTimeout is the maximum duration for reading the entire
	// request, including the body.

Since headers are part of the request, we'd also expect this timeout to apply to headers as well.
What did you see instead?
The connection timed out after 10 seconds, not 5 seconds.
NOTE:  If we instead did an HTTP POST with a request body included, and then sent the full request (headers+body) in the time between 5 and 10 seconds (with a flush on network connection after sending all headers and before the body), then we would find that the headers would be successfully received by server but then the body would instantly time out when trying to read it.  I struggle to see how this would be of any use in the real world, especially seeing as how ServeHTTP cannot adjust read timeouts/deadlines - i.e. lengthen them to something that isn't timing out immediately. (see https://github.com/golang/go/issues/16100 )
Suggested action items
I do not know what the actual intended behavior the maintainers of the http package wish to have.  It seems to me there are two options to resolve this contradiction:

Update documentation to reflect actual behavior.  For example, update comment on ReadTimeout to look something like:

	// ReadTimeout is the maximum duration for reading the entire
	// request, including the body.  As an exception, if
	// ReadHeaderTimeout > ReadTimeout, then ReadHeaderTimeout will
	// apply for reading the header portion of the request, but then the
	// request body will immediately time out when attempting to read it if
	// the ReadTimeout deadline has already elapsed.

Update code to match current documented behavior.  For example, update https://github.com/golang/go/blob/440f7d64048cd94cba669e16fe92137ce6b84073/src/net/http/server.go#L946 to look something like:

	t0 := time.Now()
	if d := c.server.readHeaderTimeout(); d != 0 {
		hdrDeadline = t0.Add(d)
	}
	if d := c.server.ReadTimeout; d != 0 {
		wholeReqDeadline = t0.Add(d)
	}
	// New: Enforce hdrDeadline <= wholeReqDeadline
	// (Not shown: logic to deal with infinite ReadHeaderTimeout and/or ReadTimeout
	if wholeReqDeadline.Before(hdrDeadline) {
		hdrDeadline = wholeReqDeadline
	}

Changing this behavior could break applications.
The current behavior is the requestTimeout = readHeaderTimeout + readTimeout.
It would be safer to just adjust the documentation to match the behavior.

how to avoid sending dotfile or files in a dot folder on a http response

The current behavior is the requestTimeout = readHeaderTimeout + readTimeout

@fraenkel I think that isn't true either... I actually assumed as you that this was the case, and tried to use a ReadHeaderTimeout > ReadTimeout in my application.  But it turns out it's actually not, and having such a relationship shows an interesting behavior.  Observe the following if we alter the example to read:
func HelloServer(w http.ResponseWriter, r *http.Request) {
	fmt.Fprintf(w, "serving endpoint %v\n", r.URL.Path[1:])
	body, err := ioutil.ReadAll(r.Body)
	if err != nil {
		fmt.Fprintf(w, "while reading body: %v", err)
	} else {
		fmt.Fprintf(w, "Hello, %s!", string(body))
	}
}

Then create the following shell script with a client payload:
#!/bin/bash

sleep 7
echo POST /myroute HTTP/1.1
echo Host: localhost
echo Content-Length: 5
echo
sleep 0.1 # Required in order to defeat buffering and flush headers in a separate packet
echo James

And run it:
$ time ./testreq.sh | nc localhost 1234
HTTP/1.1 200 OK
Date: Sun, 17 Nov 2019 18:51:36 GMT
Content-Length: 90
Content-Type: text/plain; charset=utf-8
Connection: close

serving endpoint myroute
while reading body: read tcp [::1]:1234->[::1]:63741: i/o timeout
real	0m7.130s
user	0m0.009s
sys	0m0.015s

The server happily waits up to ReadHeaderTimeout for headers, but after getting them, if ReadTimeout is elapsed, it instantly times out the request when trying to read the body.  (Note therefore that it doesn't affect GET requests where there's no body.)  It seems like kind of a useless behavior in real life, and therefore an error for anyone to ever be setting ReadHeaderTimeout > ReadTimeout.
I accidentally set ReadHeaderTimeout > ReadTimeout in my application because ReadHeaderTimeout documentation says:
	// ReadHeaderTimeout is the amount of time allowed to read
	// request headers. The connection's read deadline is reset
	// after reading the headers and the Handler can decide what
	// is considered too slow for the body.

The question is: the read deadline is reset to what?  I assumed it would be reset to a new deadline based off of whenever the headers had stopped reading.  i.e. that something sensible would happen when ReadHeaderTimeout > ReadTimeout.  For example, reset deadline to timeHeadersWereReceived + ReadTimeout.  But it turns out that it is reset to timeConnectionWasOpened + ReadTimeout and if more than ReadTimeout has already elapsed, then the connection will instantly time out at the moment we transition from headers to body.
I think that documentation could also use clarification to indicate what value the read deadline is reset to, and then explicitly call out this interesting behavior as a warning.

Sorry I should have been more clear. I dont think the current behavior is valuable given what I would have expected the proper behavior to be.
If there is no ReadHeaderTimeout, the request timeout is exactly the read timeout. If there is a ReadHeaderTimeout set, the headers must be read within that timeout window, but the request timeout is the remaining amount given the sum of ReadHeaderTimeout + ReadTimeout.
Personally I would have preferred the ReadHeaderTimeout when set to only govern the header part and allow the ReadTimeout to be the rest. But now the remainder is carried over.
What you see above seems correct to me. The header timeout expired and so does the request. For a GET request, having this split timeout doesn't make much sense given there is usually no body. It would have been useful if the timeouts were disconnected so one could guarantee headers are read within time X and bodies within time Y.
I guess if one looks at the current ReadHeaderTimeout usage, we could determine if changing the behavior affects people and whether it would be for the better.

@bradfitz @mikioh


LND tries to resolve HTLCs under the dust limit on chain

Background
Describe your issue here.
i had a channel with a lot of pending htlcs under the dust limit of p2wsh, when i force closed a few days ago those htlcs were not in the commitment tx on chain (expected), but they have been sitting in pendingchannels stuck in stage one with non existent outpoints
there were also larger htlcs in this channel which have been resolved on chain
https://github.com/lightning/bolts/blob/master/03-transactions.md#trimmed-outputs
{
    ...
    "pending_force_closing_channels": [
        {
            "channel": {
                "remote_node_pub": "026e4ac4ce38c559a918fbc3f94abccc64992626cb3335364b7c0a381d1d1ef9fd",
                "channel_point": "d1ad120b1805af53782c14b00584f14fd197cdc68b502bf15bb27e8b07daa490:0",
                "capacity": "100000",
                "local_balance": "1478",
                "remote_balance": "0",
                "local_chan_reserve_sat": "0",
                "remote_chan_reserve_sat": "0",
                "initiator": "INITIATOR_LOCAL",
                "commitment_type": "STATIC_REMOTE_KEY",
                "num_forwarding_packages": "0",
                "chan_status_flags": ""
            },
            "closing_txid": "de46048881b41dcd48a8f51845ee9e918961ccc82b4a3fafe7a0441cb77bfe0d",
            "limbo_balance": "12012",
            "maturity_height": 0,
            "blocks_til_maturity": 0,
            "recovered_balance": "0",
            "pending_htlcs": [
                {
                    "incoming": true,
                    "amount": "364",
                    "outpoint": "f080341ee47e4b1f22811a09a0ac0f949dbe123b94edad5722a193cfc0cc527f:0",
                    "maturity_height": 2196562,
                    "blocks_til_maturity": -292,
                    "stage": 1
                },
                {
                    "incoming": true,
                    "amount": "364",
                    "outpoint": "d33d36cbe7b56dd4b087e90fd6b13ae18ddc3cd4d9d3bd3c123611667bb3ba39:0",
                    "maturity_height": 2196562,
                    "blocks_til_maturity": -292,
                    "stage": 1
                },
                ...
                {
                    "incoming": true,
                    "amount": "364",
                    "outpoint": "4cc72ae3a6984b3e6b12721cef7c9af92a4f4ce79ec9c004bf83661e0af169a8:0",
                    "maturity_height": 2196562,
                    "blocks_til_maturity": -292,
                    "stage": 1
                },
                {
                    "incoming": true,
                    "amount": "364",
                    "outpoint": "e9cb4b1fb366951c81318400ba92df2e507de3d6d1c8a59f532acae92d3bcc35:0",
                    "maturity_height": 2196562,
                    "blocks_til_maturity": -292,
                    "stage": 1
                }
            ],
            "anchor": "LIMBO"
        }
    ],
    "waiting_close_channels": [
    ]
}

Your environment

version of lnd
lnd version 0.14.2-beta commit=v0.14.2-beta
which operating system (uname -a on *Nix)
version of btcd, bitcoind, or other backend
any other relevant environment details
testnet

Steps to reproduce
Tell us how to reproduce this issue. Please provide stacktraces and links to code in question.
i dont know, i tried but they dont show up on chain (expected) and not in pendingchannels (expected)
Expected behaviour
Tell us what should happen
lnd should not try to resolve contracts that dont exist on chain (look up the outpoints in the htlcs)
Actual behaviour
Tell us what happens instead
they got stuck in stage 1

the dust limit for a p2wsh script is 330sats and our code does account for this before creating a resolver.  it seems like the 2nd level tx never hit the chain so that's why you wouldn't find the outpoints. not sure why the resolver didn't expire itself though, do you have any logs? do you own this tx (257588070d593c9dfcc6e75ebc8f29b6c29d22ba5cabf78830f2fdeaf903ec88)?

My hunch is that the incoming_contest_resolver decided to morph into a success resolver, broadcasted the 2nd-level, but doesn't handle the case where the the blockheight is close to the htlc expiry and the peer claims the outputs via timeout, leading to stuck resolvers. cc @Roasbeef

do you have any logs?

lnd.log got rotated, here is lnd.log.2.gz

do you own this tx (257588070d593c9dfcc6e75ebc8f29b6c29d22ba5cabf78830f2fdeaf903ec88)?

yes

https://github.com/lightning/bolts/blob/master/03-transactions.md#trimmed-outputs
i accidentally got the same issue again
i think the issue might be that HTLC timeout transactions create outputs under the dust limit
does LND use this logic from bolt 3? i think those HTLCs must not be created in the first place in the commitment tx

for every offered HTLC:

if the HTLC amount minus the HTLC-timeout fee would be less than
dust_limit_satoshis set by the transaction owner:

MUST NOT contain that output.

otherwise:

MUST be generated as specified in
Offered HTLC Outputs.

for every received HTLC:

if the HTLC amount minus the HTLC-success fee would be less than
dust_limit_satoshis set by the transaction owner:

MUST NOT contain that output.

otherwise:

MUST be generated as specified in
Received HTLC Outputs.

I don't think this is correct, lnd does not create outputs under the dust limit. There seems to be something else going on with the resolver that is unrelated to the spec

Dupe of https://github.com/lightningnetwork/lnd/issues/4896


Increase Dashboard Graph Time Window

The graphs on the dashboard are moving too fast. Comparing stats within the past 30 seconds is not really useful either.
Besides the visual overload, graphs are flactuating too much as they immediately rescale to a single spike and rescale once again seconds later as the spike leaves the window.
Please show stats from a larger time window and consolidate stats from 1 bar every second to larger time chunks to smoothen out the graph.

Graphs removed from v2.0.0-rc.1 in favour of Graphana.


Add location updates validation

It turns out that the gson is not very secure and can break Kotlin's null safety. I guess that's because it uses the reflection mechanism from Java and therefore is allowed to put a null in a non-nullable field. Because of that, I've added a few checks that make sure that the objects we receive are in a valid format. If that's not the case we are simply logging it to the log handler.

Changed to draft as we have to wait for an infrastructure for assigning error codes to complete this PR.

The error code is ready so we can continue the work.

I'm going to use my admin powers to merge this PR despite the change requests. However, those requests seem to be fixed so I hope it is okay. Let me know if you feel otherwise and we'll work on that in another PR :wink:


[release-v1.9] Bump to Go 1.19

As per title

The build image update will only be reflected once merged so we might need to force merge


hints off page and hints off tab don't work

Saying hints off page or hints off tab results in Rango displaying a notification that says Fatal error: value must not be null/undefined. Seems to be every tab I try.

Using Vivaldi (Chromium-based) on MacOS, no console log errors shown

Ignore me, apparently the keyboard shortcuts were messed up


update ecommerce spec syntax to v2

This PR changes the ecommerce V1 syntax Action + Object to the new V2 syntax, Object + Action.
This PR will be waiting on a few blockers, a refactor of the Analytics-Events repo to be more concise and readable as we add more events to our spec and for similar changes to be made to all other integrations currently using V1 syntax.

lgtm

it works after end-to-end testing @wcjohnson11


display:none on mouseleave

Using the 'trigger: hover' option and when I mouseout, it is adding a "display:none;" to my  tag, hiding it on the page. Not sure why this is happening in my situation but not at all in the demo.

Can you put some of your code and we can try to fix the problem?


Remove collector if check is removed

If a check is removed, the metric will still be present as the collector will not be unregistered automatically.
We should remove collectors when the check is no longer present.

It will be fixed by #20.


Add test scripts to check 3556 issue (internal review)

ATF Test Scripts to check 3556
This PR is [ready] for review.
Summary
Add test scripts to check the 3556 issue.
ATF version
develop
Changelog

@dboltovskyi Thanks for your review. All done in 7f9e1f


[Dubbo-4608]refactor duplicate code of ServiceBean and ReferenceBean

What is the purpose of the change
XXXXX
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #4709 into master will increase coverage by 0.22%.
The diff coverage is 57.83%.

@@             Coverage Diff              @@
##             master    #4709      +/-   ##
============================================
+ Coverage     63.85%   64.08%   +0.22%
+ Complexity      451      448       -3
============================================
  Files           769      769
  Lines         33156    33244      +88
  Branches       5211     5221      +10
============================================
+ Hits          21173    21303     +130
+ Misses         9558     9533      -25
+ Partials       2425     2408      -17

Impacted Files
Coverage Δ
Complexity Δ

...g/apache/dubbo/config/AbstractInterfaceConfig.java
68.25% <50.74%> (-3.34%)
0 <0> (ø)

...va/org/apache/dubbo/config/spring/ServiceBean.java
53.04% <87.5%> (+4.82%)
0 <0> (ø)
:arrow_down:

.../org/apache/dubbo/config/spring/ReferenceBean.java
30% <87.5%> (+11.41%)
0 <0> (ø)
:arrow_down:

.../apache/dubbo/qos/protocol/QosProtocolWrapper.java
64.1% <0%> (-17.95%)
0% <0%> (ø)

...che/dubbo/remoting/transport/mina/MinaChannel.java
43.42% <0%> (-10.53%)
16% <0%> (-1%)

.../apache/dubbo/remoting/transport/AbstractPeer.java
58.69% <0%> (-4.35%)
0% <0%> (ø)

...e/dubbo/remoting/transport/netty/NettyChannel.java
54.11% <0%> (-3.53%)
19% <0%> (-1%)

.../rpc/protocol/dubbo/LazyConnectExchangeClient.java
56.47% <0%> (-2.36%)
0% <0%> (ø)

...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
89.71% <0%> (-0.94%)
16% <0%> (-1%)

...che/dubbo/common/compiler/support/JdkCompiler.java
64.54% <0%> (ø)
0% <0%> (ø)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65a0140...429edbb. Read the comment docs.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@tswstarplanet pls resolve conflicts with the latest master branch

Close for long time no response.
Please feel free to reopen if you have any question.


Unable to convert snmpwalk from Fortigate

The SnmpWalk import failed to parse the "clear(1)" string
.<IP_ADDRESS>.4.1.123<IP_ADDRESS>.<IP_ADDRESS>.xx.xx.xx.xx.xx.xx.xx.xx.xx.xx.xx.xx.xx.xx.xx = BITS: 40 clear(1)
Solution:
snmpsim/snmpsim/grammar/walk.py line  85
replace by:
match = re.match(r'^([0-9a-fA-F]{2}(\s+[0-9a-fA-F]{2})*)', value)

Thanks for reporting this!
The fastest way to get it fixed is to push a PR. ;-)

BTW, @landy2005 may have looked into that or somehow relevant code lately...

Sorry, i can't create a PR
Can't connect to any URI: https://github.com/etingof/snmpsim.git (https://github.com/etingof/snmpsim.git: git-receive-pack not permitted on
Here the patch
diff --git a/snmpsim/grammar/walk.py b/snmpsim/grammar/walk.py
index 66f67ff..3d5bb92 100644
--- a/snmpsim/grammar/walk.py
+++ b/snmpsim/grammar/walk.py
@@ -81,8 +81,9 @@
def _bitsFilter(value):
# rfc1902.Bits does not really initialize from sequences
# Clean bits values

   # .<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS> = BITS: 5B 00 00 00   [[...]1 3 4 6 7

   match = re.match(r'^([0-9a-fA-F]{2}(\s+[0-9a-fA-F]{2})*)\s+\[', value)

   # .<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS> = BITS: 5B 00 00 00   [[...]1 3 4 6 7

   # .<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS> = BITS: 5B 00 00 00   clear(1)

   match = re.match(r'^([0-9a-fA-F]{2}(\s+[0-9a-fA-F]{2})*)', value)
   if match:
       return ints2octs([int(y, 16) for y in match.group(1).split(' ')])

Here is the patch that I've pushed to master:
-        match = re.match(r'^([0-9a-fA-F]{2}(\s+[0-9a-fA-F]{2})*)\s+\[', value)
+        match = re.match(r'^([0-9a-fA-F]{2}(\s+[0-9a-fA-F]{2})*)', value)

I hope it does not break anything else.
Thanks!

I don't think
This regex match only valib bits
Thanks a lot
Le lun. 2 sept. 2019 à 10:55, Ilya Etingof<EMAIL_ADDRESS>a
écrit :

Here is the patch that I've pushed to master:

   match = re.match(r'^([0-9a-fA-F]{2}(\s+[0-9a-fA-F]{2})*)\s+\[', value)

   match = re.match(r'^([0-9a-fA-F]{2}(\s+[0-9a-fA-F]{2})*)', value)

I hope it does not break anything else.
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/etingof/snmpsim/issues/87?email_source=notifications&email_token=AD5MXIUWVVE6UP2P5DFTMBLQHTIJFA5CNFSM4ISXBOB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5VFXOA#issuecomment-527063992,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD5MXIXNQGLUTBBOOA64VVDQHTIJFANCNFSM4ISXBOBQ
.

Here is the patch that I've pushed to master:
-        match = re.match(r'^([0-9a-fA-F]{2}(\s+[0-9a-fA-F]{2})*)\s+\[', value)
+        match = re.match(r'^([0-9a-fA-F]{2}(\s+[0-9a-fA-F]{2})*)', value)

I hope it does not break anything else.

Probably should work correctly, my original bits "test" string written in code comment:
.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS> = BITS: 5B 00 00 00   [[...]1 3 4 6 7


Add configuration for enabled Balancer factories

This PR adds a new configuration option for selecting which Balancer V2 factories to use as baseline sources.
The motivation behind this change is that it would allow us to add new Balancer V2 factories kinds (like LBPs) with relatively low risk, since we can always disable them via configuration if we encounter an issue instead of requiring a code change + hotfix.
Test Plan
Run with different configurations:
$ cargo run -p solver
...
2021-12-21T11:14:20.230Z DEBUG shared::sources::balancer_v2::pool_init: initialized registered pools block=13848181 pools=159
...
$ cargo run -p solver -- --balancer-factories Weighted
...
2021-12-21T11:20:49.509Z DEBUG shared::sources::balancer_v2::pool_init: initialized registered pools block=13848203 pools=159
2021-12-21T11:20:49.601Z  WARN shared::sources::balancer_v2::pool_fetching: found pools that don't correspond to any known Balancer pool factory total_count=75 unused_pools=...
...
$ cargo run -p solver -- --balancer-factories Weighed2Token
...
2021-12-21T11:24:17.287Z DEBUG shared::sources::balancer_v2::pool_init: initialized registered pools block=13848215 pools=159
2021-12-21T11:24:17.379Z  WARN shared::sources::balancer_v2::pool_fetching: found pools that don't correspond to any known Balancer pool factory total_count=87 unused_pools=...
...
$ cargo run -p solver -- --balancer-factories Stable
...
2021-12-21T11:22:39.179Z DEBUG shared::sources::balancer_v2::pool_init: initialized registered pools block=13848209 pools=159
2021-12-21T11:22:39.270Z  WARN shared::sources::balancer_v2::pool_fetching: found pools that don't correspond to any known Balancer pool factory total_count=156 unused_pools=...
...

Noticing that

Weighted: 159 - 75 = 79,
Weighted2Token: 159 - 87 = 72,
Stable: 159 - 156 = 3,
Total: 79 + 72 + 3 = 159

Codecov Report

Merging #1498 (4bfb098) into refactor-balancer-cleanup-1 (968d4d5) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

:exclamation: Current head 4bfb098 differs from pull request most recent head f21a25c. Consider uploading reports for the commit f21a25c to get more accurate results

@@                       Coverage Diff                       @@
##           refactor-balancer-cleanup-1    #1498      +/-   ##
===============================================================
- Coverage                        65.84%   65.75%   -0.09%
===============================================================
  Files                              162      162
  Lines                            30752    30798      +46
===============================================================
+ Hits                             20249    20252       +3
- Misses                           10503    10546      +43


[FLINK-14464][runtime] Introduce the AbstractUserClassPathJobGraphRetriever

What is the purpose of the change
Introduce the AbstractUserClassPathJobGraphRetriever which could construct the 'user code classpath' from the "job" dir. The FileJobGraphRetriever and ClassPathJobGraphRetriever could extend this abstract class and set the corresponding 'user code classpath' to the JobGraph.
Brief change log

AbstrctUserClassPathJobGraphRetriever scan the 'jobdir' recursively and all the jar files in the 'jobdir' are added to the 'user code classpath'

Verifying this change

Add AbstractUserClassPathJobGraphRetrieverTest to test the functionality.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks @guoweiM for addressing all the comments.
It looks to me now. +1 to merge it.

Thanks @zhuzhurk for reviewing.
@flinkbot attention @tillrohrmann
Could you have a look at this pr. Thanks.

First of all, I would like to thank @zhuzhurk and @tillrohrmann  for your very thoughtful and comprehensive suggestions. I have a lot of gains.
But I have a simple question, maybe I am different from the previous understanding. I want to confirm, I wrote the question below.


fix battery < 10%

I has to revert this commit as it's not compiling well on windows, and as I don't understand how it fixes anything

currently Utils::FileSystem::readAllText is not reading the values correctly.
hence adding a new method which reads the integer from the file correctly.
this needs to be resolved in one way or another. ping me on Discord.


feat: add golangci-lint action

Closed in favor of https://github.com/go-vela/types/pull/77

Closed in favor of https://github.com/go-vela/types/pull/77


Installation of structures bundle does not include CEI/Nexus needed to run pydynamicreporting

🔍 Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

🐞 Description of the bug
When a user does an Installation of Ansys structural bundle (so WB/APDL,etc.) only, then this does not include or create CEI folder and Nexus files needed to run pydynamicreporting.
Ideally we would need to include the CEI folder and Nexus files when installing only the structural bundle, just as it is probably done when installing the Fluids bundle (have in mind that structural engineers will not of course often install Fluid bundles due to various reasons so we would need to create the folders and Nexus files with the structures Ansys installation and any other installations).
📝 Steps to reproduce
NA
💻 Which operating system are you using?

In 2023 R2, Nexus (the "old" name for Ansys Dynamic Reporting") can only be installed as part of the EnSight package, which is under the Fluid section.
In 2024 R1, we have added an entry in the Ansys installer for ADR specifically, so you can explicitly request for the CEI/ folder to be installed as part of your installation. At the moment (aka, for 24R1), this will still be visible only under the Fluids package, so you will need to actively go there during the installation process and toggle on the "Dynamic Reporting" entry, even if you're only installing structure. But we're looking into the possibility of moving this installation toggle in an other area outside of Fluids (maybe a 'Common / Shared package' area?) for 2024 R2, but this is too early to say what the decision will be.
Anyway, I've added comments to clarify this aspect of the installation in the pydynamicreporting docs - see PR 67.
Thank you for bring up the issue, which allowed us to start the conversation.


"Total outflow" and "Average daily outflow" include transfers between 2 on-budget accounts

Name of Defective Feature
Days of Buffering Metric
System Settings (Required)
ToolKit Version: 1.1.0
Operating System (Mac/Windows/Etc): MacOS Sierra 10.12.6
Browser (Chrome/Firefox/Safari): Chrome
Browser Version: Version 60.0.3112.90 (Official Build) (64-bit)
Other Extensions: NA
Export of Toolkit Settings (Bottom Left of Settings Page)
[{"key":"AccountsDisplayDensity","value":"0"},{"key":"AccountsEmphasizedOutflows","value":false},{"key":"AccountsStripedRows","value":false},{"key":"AdditionalColumns","value":true},{"key":"AdjustableColumnWidths","value":false},{"key":"AutoCloseReconcile","value":false},{"key":"ChangeEnterBehavior","value":false},{"key":"CheckNumbers","value":false},{"key":"ColourBlindMode","value":false},{"key":"CustomFlagNames","value":false},{"key":"DisplayTargetGoalAmount","value":false},{"key":"GoalWarningColor","value":null},{"key":"HideAgeOfMoney","value":null},{"key":"HideReferralBanner","value":false},{"key":"PrintingImprovements","value":true},{"key":"RemovePositiveHighlight","value":false},{"key":"RowHeight","value":"0"},{"key":"RunningBalance","value":false},{"key":"ShowCategoryBalance","value":false},{"key":"SquareNegativeMode","value":false},{"key":"StealingFromFuture","value":true},{"key":"TargetBalanceWarning","value":true},{"key":"accountsClearSelection","value":true},{"key":"accountsDisplayDensity","value":"0"},{"key":"accountsEmphasizedOutflows","value":false},{"key":"accountsRowHeight","value":"0"},{"key":"accountsStripedRows","value":false},{"key":"activityTransactionLink","value":true},{"key":"betterScrollbars","value":"0"},{"key":"budgetBalanceToZero","value":true},{"key":"budgetProgressBars","value":"0"},{"key":"budgetQuickSwitch","value":false},{"key":"budgetRowsHeight","value":"0"},{"key":"calendarFirstDay","value":"0"},{"key":"categoryActivityPopupWidth","value":"0"},{"key":"changeEnterBehavior","value":false},{"key":"checkCreditBalances","value":true},{"key":"checkNumbers","value":false},{"key":"closeReconcileWindow","value":false},{"key":"collapseExpandBudgetGroups","value":false},{"key":"collapseSideMenu","value":false},{"key":"colourBlindMode","value":false},{"key":"compactIncomeVsExpense","value":true},{"key":"currentMonthIndicator","value":true},{"key":"daysOfBuffering","value":true},{"key":"daysOfBufferingHistoryLookup","value":"0"},{"key":"editButtonPosition","value":"0"},{"key":"enableRetroCalculator","value":true},{"key":"enlargeCategoriesDropdown","value":true},{"key":"exportTransactions","value":false},{"key":"goalIndicator","value":false},{"key":"goalIndicatorWarningColor","value":true},{"key":"googleFontsSelector","value":"0"},{"key":"hideAOM","value":false},{"key":"hideAccountBalancesType","value":"0"},{"key":"hideHelp","value":false},{"key":"highlightNegativesNegative","value":true},{"key":"importNotification","value":"1"},{"key":"incomeFromLastMonth","value":"0"},{"key":"l10n","value":"0"},{"key":"largerClickableIcons","value":true},{"key":"monthlyNotesPopupWidth","value":"0"},{"key":"navDisplayDensity","value":"0"},{"key":"options.dark-mode","value":false},{"key":"pacing","value":"0"},{"key":"popupCalculator","value":false},{"key":"printingImprovements","value":true},{"key":"privacyMode","value":"0"},{"key":"reconciledTextColor","value":"0"},{"key":"removePositiveHighlight","value":false},{"key":"removeZeroCategories","value":true},{"key":"reports","value":true},{"key":"resizeInspector","value":false},{"key":"rightClickToEdit","value":true},{"key":"runningBalance","value":false},{"key":"seamlessBudgetHeader","value":true},{"key":"showIntercom","value":true},{"key":"spareChange","value":false},{"key":"splitKeyboardShortcut","value":true},{"key":"splitTransactionAutoAdjust","value":true},{"key":"squareNegativeMode","value":false},{"key":"stealingFromNextMonth","value":true},{"key":"swapClearedFlagged","value":false},{"key":"toBeBudgetedWarning","value":true},{"key":"toggleSplits","value":false},{"key":"toggleTransactionFilters","value":"1"},{"key":"warnOnQuickBudget","value":true}]

Steps to Reproduce the Behavior
Please write down the steps necessary to reproduce the behavior you're seeing. Please be as thorough as possible.

Add an outflow transaction from one on-budget account to another on-budget, for instance, transfer from a checking account to a savings account.
Go to the budget view.
Hover over "Days of Buffering" and wait for the hover to show.
See that "Total outflow" and "Average daily outflow" include outflow transactions across on-budget accounts, even though transfers from one on-budget to another on-budget account net 0 dollars.

Expected Behavior
What did you expect would happen after completing the steps?
I would expect to see a "Total Outflow" that matches the actual amount leaving my budget.
Actual Behavior
What actually happened after you completed the steps.
The "Total Outflow" includes transfer transactions from one on-budget account to another, when no money actually left the budget.

On further investigation, I cannot pinpoint the exact transactions being accounted for in the "Total Outflow", but I am seeing that my "Total Outflow" is greater than my "Total Spent" when I look at reports.
Total Outflow: 18595.04
Total Spent: 16498.43
Maybe I'm just miss-understanding this metric?

I found a couple of transfer transactions that were not properly set, after adjusting those I am down to a total outflow of 17841.90

@cdierkens there is some DOB investigation going on here: #931 which may resolve this issue?

Yes, we are working to filter out transfer transactions from the Days of Buffering metric. I think we may have found a solution. Keep your eye on #931 for details.

Thanks for the updates! I'll keep my eyes open.
On Tue, Sep 19, 2017 at 12:14 PM, tremsy<EMAIL_ADDRESS>wrote:

Yes, we are working to filter out transfer transactions from the Days of
Buffering metric. I think we may have found a solution. Keep your eye on
#931 https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/931
for details.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/882#issuecomment-330591561,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AElueRlcfLfver_pZMcKag2TplFHB4Usks5sj-hagaJpZM4Ou75q
.

I'm closing this issue as it's been resolved by #931. There is another issue with changes made by YNAB to some of the functions being used to determine a on budget transfer. That's being tracked in a different issue.


Added csharp code

Is that full executable example? Please make it full code. I will be updating all other examples also.
 "System.Console.WriteLine('Hello, World!');"

okay.

Why hello1? And are you sure it requires public?

Yeah I am sure. I checked it from https://msdn.microsoft.com/. Okay I will change hello1 to helloworld, although it does'nt make any difference in c#.

bash already exists, thats why you are getting issues with merge now. Anyways I would suggest following C# code, straight from Wikipedia:
using System;

class HelloWorld
{
    static void Main()
    {
        Console.WriteLine("Hello, world");
    }
}

Since there are conflicts now, do this,

solve merge conflicts
squash the commits and make it to a 'added C# examaple'

Sounds fine? Thanks for the PR!

Okay I will do that.

:+1:


Join my 1.20.4 CarpetSkyAdditions server!

Hello, hope you don't mind me posting this but
sky.hardcoreanarchy.gay
Please check out my skyblock server! It runs this but updated and has personal islands, TPA, and a /spawn. Thanks!

How did you get the mod to work on 1.20.4?

How did you get the mod to work on 1.20.4?

I just ran all the broken scripts through ChatGPT

How did you get the mod to work on 1.20.4?

I just ran all the broken scripts through ChatGPT

huh?GPT?

A few posts below yours is one in Chinese, I think. There a poster links to a fork of the project which has been updated to 1.20.4. Haven't tried it myself but here is the link.
https://github.com/Galatex1/CarpetSkyAdditions
Please, let us know how it goes so we can proceed with updates as well. Thanks.

I have some error when I try build this report
https://github.com/Galatex1/CarpetSkyAdditions
Plugin [id: 'fabric-loom', version: '1.4-SNAPSHOT'] was not found in any of the following sources:

The maven can't find the plugin in the web and I can find it when I open the site on browser

I haven't tried compiling the repo myself but a quick google search lead me to the following site.
https://maven.fabricmc.net/net/fabricmc/fabric-loom/1.4-SNAPSHOT/
I hope the link helps and my apologies that I don't have further knowledge to share on the compilation process.

Thank you very much, I fixed this bug 3 days ago with some settings. If you need these settings I can open source my code

Thank you very much, I fixed this bug 3 days ago with some settings. If you need these settings I can open source my code

please do


fix several typos in docs;

Note: I added a TODO in docs/Debugging-Event-Handlers.md, I think there was a clipped sentence at the end.

That sort of proofing reading is gold.  Many Thanks.


Return uniqueSaleNumber on receipt

Hello,
Currently we can print a receipt without specifying uniqueSaleNumber. In this case the printer will automatically generate and add it to the receipt (at least with Datecs devices). However this auto-generated uniqueSaleNumber is not returned back which make it impossible to print a reversal receipt afterwards.
Is it possible to get the uniqueSaleNumber back with the response, no matter if it is already specified by the incoming POST request?
Thanks,
Dimitar

This could be made and would be a nice addition to the protocol.
However, as this is unsupported open-source effort, it is up to you to implement it. If you implement it with a quality code, please give us a pull request, so that we can share it to benefit everybody.
If you decide to implement it:

Implement it for DATECS printers
Consider the non-DATECS printers - do they support this?
Include the change in the protocol help (this should be only 1 line description and 1 line in any of the example responses)
Anything else, which you might consider good for the quality of the pull request.

Regards!


Detect file sizes changing during Copy

In Copy, check to see if can read more bytes from the reader after the copy has finished.
If this is the case, then make an error - "file size changed while copying" and abort the copy.
This would have detected #902 also.

Maybe instead of aborting the copy, it should spit out an error and move onto the next copy. This is if you're assuming there are multiple files being copied.

This fix should be in the latest beta in 30 mins or so!


fix: com_field_list  response, combine the fields into a package to send

arana com_field_list response issue
combine the fields into a package to send

What this PR does:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #226 (bebd53d) into master (3438a2b) will decrease coverage by 0.24%.
The diff coverage is 2.24%.

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   36.85%   36.61%   -0.25%
==========================================
  Files          84       84
  Lines       13041    13127      +86
==========================================
  Hits         4806     4806
- Misses       7632     7718      +86
  Partials      603      603

Impacted Files
Coverage Δ

pkg/mysql/conn.go
39.94% <0.00%> (-4.89%)
:arrow_down:

pkg/mysql/execute_handle.go
0.00% <0.00%> (ø)

pkg/mysql/server.go
0.00% <0.00%> (ø)

pkg/mysql/client.go
35.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3438a2b...bebd53d. Read the comment docs.


Cleanup NetBeans license header for module apisupport.harness

Review and cleanup the license header in apisupport.harness
Oracle donated NetBeans to the Apache Software Foundation.
Your task now is to replace the old license header that has Oracle (and/or Sun Microsystems
and/or NetBeans) in it with the standard Apache Software Foundation license header.
For an empty file that supports headers you must add the Apache license header.
Note that you have to use the proper license header for Java, .properties or HTML files.
Look at the nearby files for templates and copy-paste the license header.
When done commit the changes with a commit message that starts with first line
"[NETBEANS-54] Module Review " and a message body describing your review.
See a longer explanation about what we are doing here: https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
Please announce in a comment when you have started work.
Files that need to be looked at in apisupport.harness:
apisupport.harness/jnlp-manifest.mf
apisupport.harness/windows-launcher-src/app.rc

On it.


fix(persist): remove environment check

because we can now pass in undefined for persisters during SSR, and the persisters themselves are not window related anymore, as we don't use window.localStorage directly

:tada: This PR is included in version 4.0.0-beta.19 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[WIP]Support to build Unidic dictionary

This PR can build UniDic binary dictionary.
The PR can build and success to build binary dictionary with unidic-mecab-2.1.2_src.
There are some tasks that need be fixed before merging.

[ ] Add options to Readme.md
[ ] Test  lindera tokenizer with the built dictionary

Fixed #8

I'll move this implementation to https://github.com/bayard-search/lindera-unidic .


Should autocrlf=false when cloning repositories?

What's wrong
I found out this when using the sly package on Windows for the first time. It has a multi-line format, which broke because autocrlf=true, which is the recommended default on Windows. But (newer) Windows supports only LF too, and when we're not cloning a repo in order to work with cross OS repos, a better default might be autocrlf=false, i.e. as the repo author intended.
This can be done on the clone command by saying --config autocrlf=false, which sets autocrlf=false in .git/config in the cloned repository.
Directions to reproduce
Clone sly on Windows using autocrlf=true and run M-x sly.
Version information

Emacs version: 28.2
Operating system: Windows 11

Could this be solved via a repo-specific .gitattributes file rather than hard coding a setting into the clone command?

.gitattributes overrides user, system and global settings? Maybe a better solution then. Hard to tell :shrug: I really hate autocrlf, but it's a necessary evil on Windows unfortunately. Been years since I tried autocrlf=false on Windows, so maybe I should try again.
I see the following threads have advocates for both sides: https://stackoverflow.com/questions/2825428/why-should-i-use-core-autocrlf-true-in-git#2825829
Why oh why does Windows have to work so different from all other operating systems..? :(

So currently we don't set any special autocrlf settings in straight.el, because the idea is that probably you want the same settings to be used for straight.el as when you are otherwise cloning repos. Don't you run into similar issues elsewhere on your system if the autocrlf setting is not applied properly?
Generally speaking, I think if git clone fails due to configuration, it is out of scope for straight.el to try and patch the issue.


Read vehicle

Implemented following API functionalities:

get all vehicles
get vehicle by vehicle id
get vehicles by user id

added appropriate http requests
sorted routes to vehicle/all, vehicle/{id} and vehicle/user{id}

approved by both team mates


[WIP] update examples and readmes

My goal with this pull request is to get the examples to run correctly, specifically I will:

[x] update SMIRNOFF_comparison examples to import forcefield_utils correctly
[ ] update example in README to be a code snippet that works (unless the problem there is an issue with the code somewhere)
[ ] update README to include more information about ChemicalEnvironments.
[ ] Check README and examples in the examples/ChemicalEnvironments/ directory (I assume they're from smarty and are fine, but Christopher made them back in August and I haven't looked at them closely in a long time so I want to make sure they're understandable.

I have this in a separate Fork because I didn't have permission to push branch changes on the main fork, but I'll move these to a branch when that changes.

Closing, as I've moved changes to a branch instead of a fork, see pull request #7


Look and Feel

(1) GUI need heavy updates like mainpage, page redirection
(2) put some background image
(3) put back button

We done it


RenderSliverGrid assert on SliverGridLayout too strict

While SliverGridLayout's documentation specifies that

The tiles can be placed arbitrarily, but it is more efficient to place tiles in roughly in order by scroll offset because grids reify a contiguous sequence of children.

RenderSliverGrid asserts that firstChild.layoutOffset <= scrollOffset, which fails when the first child is offset vertically.
Minimal example
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) => MaterialApp(home: Page1());
}

class Page1 extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: CustomScrollView(
        slivers: <Widget>[
          SliverGrid(
            delegate: SliverChildBuilderDelegate((context, index) => Container(
                  color: Colors.red,
                  margin: EdgeInsets.all(8),
                )),
            gridDelegate: MySliverGridDelegate(),
          )
        ],
      ),
    );
  }
}

class MySliverGridDelegate extends SliverGridDelegate {
  @override
  SliverGridLayout getLayout(SliverConstraints constraints) => MySliverGridLayout();

  @override
  bool shouldRelayout(MySliverGridDelegate oldDelegate) => true;
}

class MySliverGridLayout extends SliverGridLayout {
  @override
  int getMinChildIndexForScrollOffset(double scrollOffset) => 0;

  @override
  int getMaxChildIndexForScrollOffset(double scrollOffset) => 10;

  @override
  SliverGridGeometry getGeometryForChildIndex(int index) {
    final double crossAxisStart = (index % 4) * 80.0;
    return SliverGridGeometry(
      scrollOffset: (index ~/ 4) * 80 + 80 - (index % 4) * 20.0,
      crossAxisOffset: crossAxisStart,
      mainAxisExtent: 80,
      crossAxisExtent: 80,
    );
  }

  @override
  double computeMaxScrollOffset(int childCount) => 50;
}

Output:
flutter: ══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
flutter: The following assertion was thrown during performLayout():
flutter: 'package:flutter/src/rendering/sliver_grid.dart': Failed assertion: line 602 pos 12:
flutter: 'childScrollOffset(firstChild) <= scrollOffset': is not true.
flutter:
flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially
flutter: more information in this error message to help you determine and fix the underlying cause.
flutter: In either case, please report this assertion by filing a bug on GitHub:
flutter:   https://github.com/flutter/flutter/issues/new?template=BUG.md
flutter:
flutter: When the exception was thrown, this was the stack:
flutter: #2      RenderSliverGrid.performLayout (package:flutter/src/rendering/sliver_grid.dart:602:12)
flutter: #3      RenderObject.layout (package:flutter/src/rendering/object.dart:1632:7)

The grid looks like I'd expect, so my proposal would be to remove the assert. Unless there's a less strict condition that can be checked. (Maybe that the child before firstChild is completely outside of the visible area of the grid?)
[✓] Flutter (Channel master, v1.2.2-pre.21, on Mac OS X 10.14.3 18D109, locale en-NL)
    • Flutter version 1.2.2-pre.21 at /Users/spkersten/Development/flutter
    • Framework revision 035e0765cc (8 hours ago), 2019-02-16 01:48:28 -0500
    • Engine revision f37b09a11b
    • Dart version 2.1.2 (build 2.1.2-dev.0.0 c92d5ca288)

Perhaps we want to just update the assert so that it checks that the child's scroll offset has left it visible on the screen.  I suspect that's the intent, and that the assert was just copypasted from some other widget where this kind of layout could never happen.
@goderbauer @chunhtai @Piinks WDYT?

I think removing this assert will be ok. I'm looking into it now. :)

After a quick look, so far, as it is, removing this assert seems to open the door for some unexpected behavior.
I took the sample you provided and added another sliver after the grid to help visualize this a bit better:
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) => MaterialApp(home: Page1());
}

class Page1 extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: CustomScrollView(
        slivers: <Widget>[
          SliverGrid(
            delegate: SliverChildBuilderDelegate((context, index) {
              return Container(
                color: Colors.red,
                margin: EdgeInsets.all(8),
              );
            }),
            gridDelegate: MySliverGridDelegate(),
          ),
          SliverToBoxAdapter(
            child: Container(
              color: Colors.blue,
              height: 100,
            ),
          )
        ],
      ),
    );
  }
}

class MySliverGridDelegate extends SliverGridDelegate {
  @override
  SliverGridLayout getLayout(SliverConstraints constraints) => MySliverGridLayout();

  @override
  bool shouldRelayout(MySliverGridDelegate oldDelegate) => true;
}

class MySliverGridLayout extends SliverGridLayout {
  @override
  int getMinChildIndexForScrollOffset(double scrollOffset) => 0;

  @override
  int getMaxChildIndexForScrollOffset(double scrollOffset) => 3;

  @override
  SliverGridGeometry getGeometryForChildIndex(int index) {
    final double crossAxisStart = (index % 4) * 80.0;
    return SliverGridGeometry(
      scrollOffset: (index ~/ 4) * 80 + 80 - (index % 4) * 20.0,
      crossAxisOffset: crossAxisStart,
      mainAxisExtent: 80,
      crossAxisExtent: 80,
    );
  }

  @override
  double computeMaxScrollOffset(int childCount) => 50;
}

By adding this follow up sliver, we can see that the grid ends up overlapping it visually, and further more, scrolls in a funny way where the grid scrolls over the blue sliver until they line up and scroll together.
Also, with or without the blue sliver after the grid, it appears to scroll infinitely. When the blue sliver is included, it sticks to the top, but it continues to scroll infinitely. I captured this below where I have to scroll way up to find the grid again.

This assert does seem intentional. I have checked the other render objects that use a RenderSliverBoxChildManager, and it does not appear that this assert came from a copy paste. The git history does not provide much help either, as this assert was present when SliverGrid was created. The documentation seem to be wrong here regarding arbitrary placement.
I think staggered grids like this can work, although I am not sure what would need to be changed at this precise moment.
I can continue to look into this, although I am curious to know what others think.
What would you expect the behavior to be in the situations above?
I have seen packages that create staggered grids, could  there already be an existing solution in that case?

@Piinks I think that the infinite scrolling results from the hardcoded value returned by computeMaxScrollOffset in my example. (I didn't think that was needed to show the issue.) I believe that the overlapping is similarly a result of my crude example.
I'm attempting to create a reorderable SliverGrid which animates the tiles to their new positions while the user drags a tile over the grid. For example like this:

My current approach is to use the SliverGridDelegate wrapper to change (and animate) the positions of the cards in the grid. The assert failed in an early version when I dragged the first card, which was then shown not as the first along the main axis. I can probably avoid doing this, but generally it would be nice if the framework wouldn't impose unnecessary limitations (of course, while still having asserts where it helps :) ).

Hey @spkersten thanks for the update! I have some more thoughts, let me know what you think! :relaxed:

I'm attempting to create a reorderable SliverGrid which animates the tiles to their new positions while the user drags a tile over the grid.

Are you able to provide a reproduction for this use case?

I also did a quick search and found a few packages that do animated reorder-able grids if its helpful:

https://pub.dev/packages/dragablegridview_flutter
https://pub.dev/packages/reorderables

I noticed the Flutter doctor provided above is version 1.2, is this reproducing on master for your reorder-able animated SliverGrid?
It sounds like this might be similar to #42142, where the layoutOffset of the firstChild is incorrect, causing issues when children are rearranged. @chunhtai is working on a fix for that in #42703. We can see if something similar is happening here with a reproduction.

The assert failed in an early version when I dragged the first card, which was then shown not as the first along the main axis.

You mentioned running into this in an earlier version, does this mean you are not experiencing this anymore, or that you found a workaround?

it would be nice if the framework wouldn't impose unnecessary limitations (of course, while still having asserts where it helps :) ).

I don't know that we have proven this assert is unnecessary. While the reproduction provided above may not be a real use case, it does look like an example of the assert doing its job.

@Piinks I don't have anything more to share yet. I was exploring options when I encountered this issue and reported it, hoping it would be fixed by the time I needed to make a proper implementation. On that, I will work this week.

You mentioned running into this in an earlier version, does this mean you are not experiencing this anymore, or that you found a workaround?

Yes, I think I can work around it.

I also did a quick search and found a few packages that do animated reorder-able grids if its helpful:

https://pub.dev/packages/dragablegridview_flutter
https://pub.dev/packages/reorderables

Neither offers a reorderable SliverGird but they might provide some more inspiration. Thanks.

@Piinks update: The issue still still relevant and working around it is more cumbersome than I expected (wrapping SliverChildDelegate and adding a zero size dummy widget at the start).

@Piinks I have created a repo with the SliverReorderableGrid I created including an example here: https://github.com/spkersten/sliver_draggables
You can observe the issue of this ticker by making the window short enough so there is only a single row and dragging an item to the first spot:

(I used latest master)
I'm also very interested in any other feedback on the code. I think it reveals several shortcomings of Flutter's existing Draggable and DragTarget.

A duplicate issue has been filed for this, and it has been escalated: https://github.com/flutter/flutter/issues/64006
I am going to close this one since the escalated one is under higher priority review.

Ccvt
Vf(( f
On 18 Aug 2020 Tue at 20:08 Kate Lovett<EMAIL_ADDRESS>wrote:f

A duplicate issue has been filed for this, and it has been escalatedd  :
#64006 https://github.com/flutter/flutter/issues/64006
I am going to close this one since the . Tescalated one is under higher
priority review.
—f
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/28056#issuecomment-675602106,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRE7I5CE5UEH6MBISYTPWDSBKYQHANCNFSM4GX4WJDQ
.


Too little information

Needs more explanation.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9923c482-7052-694a-5f83-3ae3eaac35cb
Version Independent ID: b8f20565-bbe3-ba0d-b680-650b743f4e57
Content: RequestOptions.IfNoneMatchEtag Property (Microsoft.Azure.Cosmos) - Azure for .NET Developers
Content Source: xml/Microsoft.Azure.Cosmos/RequestOptions.xml
Service: cosmos-db
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

This issue has been transferred to the repository where the Microsoft.Azure.Cosmos library is maintained as #4038.


Appropriate licensing and copy right.

Hello @yeban and @yannickwurm
I would like to bring back to your attention an issue I have mentioned to both of you a few times: Afra should display the Apollo logo. Afra is written as a modification to the plugin - and lives on top of JBrowse-, so it should acknowledge use of both in a more prominent manner, yet neither tool is identified on the Afra working windows.
Unfortunately, the phrase: "Parts of Afra are forked from or inspired by JBrowse and WebApollo" displayed at the bottom of the [README] (https://github.com/wurmlab/afra/blob/master/README.mkd) is also not enough to appropriately credit our copyright. The Apollo plugin is licensed with copyright from the Regents of the University of California and as you can read on the terms of the [Apollo License] (https://github.com/GMOD/Apollo/blob/master/LICENSE.md), redistribution and use in source and binary forms, with or without modification, are permitted provided that our copyright notice is retained, along with the list of conditions and the disclaimer we have included in the license. This means you will want to extend the [Apache License and Copy Rights from QMUL] (https://github.com/wurmlab/afra/blob/master/LICENSE.txt) to include this information.
You know how very much I dig Afra! I also am taking necessary steps to ensure that licenses and copyrights are appropriately followed and acknowledged. Please let me know if you have any questions and I will be very glad to assist you in any way I can to complete these steps.
Happy Annotating! :bowtie:

I will be happy to address this after I'm back (I'm home for ~2 weeks). In the meantime I would like to draw your attention to the NOTICE.txt file, where I have discussed copyright stuff in more detail.

@yeban Perfect. Evidently, you were listening, and I didn't know where to look! It didn't occur to me to read a "NOTICE.txt" file. :grin: Perhaps the notice can simply be renamed to something along the lines of "License Notice", or something similar.
Have fun at home! We'll chat about the rest later. -- step.away.from.the.computer! :sunny: :four_leaf_clover:


SplashBuddy freezing during user initiated enrollment

Anyone else running into Splashbuddy freezing during user initiated enrollment? Experiencing an inconsistent issue where users are reporting being stuck on the Splashbuddy GUI for more than 60+ minutes. When users attempts to kill splashbuddy with CMD+Ctlr+Q, splashbuddy relaunches within  2-5 seconds. Any ideas what can be causing this issue? Or how to continue splashbuddy even if an install fails?

Are all of your applications installed that you required to be installed? It's possible something is not being installed on some systems which is preventing the window from showing the continue button becoming active.
Additionally as per SplashBuddy Wiki if you don't want SplashBuddy to relaunch, then you need to do CMD + Option + Alt + Q and it will write the .SplashBuddyDone file and prevent it from launching again.

Office 365 is one of the applicates that is installed during this process. I made adjustments in how we package and deliver Office 365 that seems to have helped and is running smoother. However, still seeing a few devices freezing up.
So when I run the CMD + Option + Alt + Q it does not seem to be writing the .SplashBuddyDone file to prevent it from launching again.  Also is this running in loginwindow, or user space?


Add ssl_ca_file and ssl_crl_file inside the config

These are mentioned in the README and have defaults, however, they are not being exported in the postgresql.conf.
Just a recommendation - would be great if there are a couple of lines explaining how to run the tests and the linters locally.

@vesln thank you very much! I have rebased this on top of the latest master and merged this in as #138. I will add some documentation about testing in the near future.


Make W&B optional in L2G step

As a Gentropy user I want to be able to train L2G without using W&B as experiment tracker because this is a non OS tool that might require licensing
Background
L2G evaluation is embedded in the function that exports the training metadata to W&Bs. A Gentropy user has requested to make the usage of this tool optional.
Tasks

[ ] Make W&B tracking optional
[ ] Evaluate model using scikit

Acceptance tests
How do we know the task is complete?

L2G step runs without providing wandb_name

Genentech is reminding us about this

Hi @ireneisdoomed, was this done?

@prashantuniyal02 Not yet


alphabetize gemfile

@zr2d2 Thank you! Submitted the patch against the main repo in https://github.com/SnapFresh/SnapFresh/pull/55


Upgrade tensor flow from 1.9 to 1.12, Using tf.keras : ImportError: cannot import name 'Layer'

'from tensorflow.keras.layers import Embedding, Dense, Input, Dropout, LSTM, Activation, Conv2D, Reshape, Average, Bidirectional'

ImportError                               Traceback (most recent call last)
 in ()
----> 1 from tensorflow.keras.layers import Embedding, Dense, Input, Dropout, LSTM, Activation, Conv2D, Reshape, Average, Bidirectional
2 from tensorflow.keras.models import Model
3 from tensorflow.keras.optimizers import Adam
4
5 from tensorflow.keras.losses import binary_crossentropy
/usr/local/lib/python3.5/dist-packages/tensorflow/keras/init.py in ()
18 from . import estimator
19 from . import initializers
---> 20 from . import layers
21 from . import losses
22 from . import metrics
/usr/local/lib/python3.5/dist-packages/tensorflow/keras/layers/init.py in ()
6 from future import print_function
7
----> 8 from tensorflow.python.estimator.keras import Layer
9 from tensorflow.python.keras import Input
10 from tensorflow.python.keras.applications.densenet import Activation
ImportError: cannot import name 'Layer'

I have the same issue. The solution from @liupeng89 does not help. I still get the same error.

I had the same issue when upgrading to tensorflow 1.13 (windows, through conda). In the end I just used keras with tensorflow backend, i.e. for this example:
from keras.layers import Embedding, Dense, Input, Dropout, LSTM, Activation, Conv2D, Reshape, Average, Bidirectional

I have the same problem.
pydoc.ErrorDuringImport: problem in tensorflow.keras - ImportError: cannot import name 'Layer'
Any proper solution for this instead of workaround?

I have fixed it just typing "from tensorflow.keras.layers import Embedding, Dense, Input, Dropout, LSTM, Activation, Conv2D, Reshape, Average, Bidirectional'" again. Thanks!

We have the same name.


Fix provider permissions indicators for disabled permissions

Context
The providers listed for disabled permissions is displaying the incorrect side of the permissions relationship.

Changes proposed in this pull request

Display the training provider when viewing a ratifying provider and the training provider doesn't have the relevant permissions.
Display the ratifying provider when viewing a training provider and the ratifying provider doesn't have the relevant permissions.
Rename CrossIcon to CrossIconComponent

Guidance to review

Link to Trello card
Spotted in support

Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

I think the behaviour here isn't quite right yet. If I set permissions like this, ie Blackfriars can do everything everywhere:

Then I see this in the component:

Shouldn't I see that this applies to courses ratified by those providers?
And if I set the reverse (ie untick the whole left column, tick the whole right) I get this:

@duncanjbrown updated to use subtraction of *_providers_that_can_* to determine providers with disabled permissions.

I may be massively confused by this but I tried the following scenario (that came through support).

Ratifying providers have all the permissions, training provider (Blackfriars) doesn't have any permissions.

This is what I see on the user's page:

It feels like it's the wrong way round:

Blackfriars can make decisions (as it's a user level permission) but it does not apply to courses ratified by (...)
Keele can make decisions and it applies to courses run by Blackfriars

Closing this PR as superseded by https://github.com/DFE-Digital/apply-for-teacher-training/pull/3523


Unable to preventDefault inside passive event listener invocation

First of all , thanks for creating react-image-crop.
It is specially useful for people like me, who don't work with canvases .
I am getting this error whenever i test this functionality in mobile mode, like selecting some part or simply clicking of the canvas
Unable to preventDefault inside passive event listener invocation

Okay thanks

Do I need to downgrade react npm version as well for this? I am using react-image-crop in Capacitor Ionic App and it has all react 17 version.
& with that, this error is appearing.

Do I need to downgrade react npm version as well for this? I am using react-image-crop in Capacitor Ionic App and it has all react 17 version.
& with that, this error is appearing.

Thanks for pointing that out, please use 8.6.11 instead

Do I need to downgrade react npm version as well for this? I am using react-image-crop in Capacitor Ionic App and it has all react 17 version.
& with that, this error is appearing.

Thanks I am looking into this will publish a fix @ 8.6.11

Is that sorted in this commit?

Is that sorted in this commit?

Yep please try 8.6.12

But with react 17 or lower? In 17 its still same. Here is my list of packages.
"react": "^17.0.2",
    "react-color": "^2.19.3",
    "react-dom": "^17.0.2",
    "react-image-crop": "^8.6.12",
    "react-konva": "^17.0.2-4",

But with react 17 or lower? In 17 its still same. Here is my list of packages.
"react": "^17.0.2",
    "react-color": "^2.19.3",
    "react-dom": "^17.0.2",
    "react-image-crop": "^8.6.12",
    "react-konva": "^17.0.2-4",

Hm that's strange, are you able to repro the issue here? https://codesandbox.io/s/react-image-crop-demo-with-react-hooks-y831o
I was able to repro on 8.6.10 because I removed something with passive events that I shouldn't have, but I added it back and the warning went away for me

Ok let me check. Thanks for your help.

8.6.9 is same.

I am changing the version
run npm install command
npx cap sync android

& done. Then I am checking.
I hope I am not missing anything.

Could not find a declaration file for module 'react-image-crop'. '/Volumes/MAIN/BJPFrames/PF2.0/PoliticalFrames/node_modules/react-image-crop/dist/ReactCrop.min.js' implicitly has an 'any' type.
Try npm i --save-dev @types/react-image-crop if it exists or add a new declaration (.d.ts) file containing declare module 'react-image-crop';ts(7016)
After updates to react 17, this warning is showing here:
import ReactCrop from 'react-image-crop';

Could not find a declaration file for module 'react-image-crop'. '/Volumes/MAIN/BJPFrames/PF2.0/PoliticalFrames/node_modules/react-image-crop/dist/ReactCrop.min.js' implicitly has an 'any' type.
Try npm i --save-dev @types/react-image-crop if it exists or add a new declaration (.d.ts) file containing declare module 'react-image-crop';ts(7016)
After updates to react 17, this warning is showing here:
import ReactCrop from 'react-image-crop';

Did you try as the message prompts npm i --save-dev @types/react-image-crop? As with the passive warning I'm not sure why that's coming up for you as it should only be a problem in 8.6.10 🤔

Yes I have run that command. Now failed to compile.

Hello, its started working without doing anything. Seriously. I turned off computer and after few hours I started to check and it was miracle. Thank you for your update.

Hello, its started working without doing anything. Seriously. I turned off computer and after few hours I started to check and it was miracle. Thank you for your update.

Hah ok that's good as I was out of ideas ;)