Event Hubs: "conn" package is not exported in new SDK

Bug Report

import path of package in question: github.com/Azure/azure-sdk-for-go/sdk/messaging/azeventhubs
SDK version: 0.4.0
output of go version: 1.19.4

Description
In the new "track 2" SDK for Event Hubs, the conn package is marked as internal: github.com/Azure/azure-sdk-for-go/sdk/messaging/azeventhubs/internal/conn
Because of that, we cannot use the ParsedConnectionFromStr method to parse a connection string like the SDK does. We need to do that in Dapr to be able to determine if the user passed a connection string that includes an entity path or not, and behave accordingly.

This has been released!
https://github.com/Azure/azure-sdk-for-go/releases/tag/sdk%2Fmessaging%2Fazeventhubs%2Fv0.5.0

Thank you @richardpark-msft , updating now :)


Encourage to avoid using (required) field option for numeric and boolean types

This PR closes https://github.com/SpineEventEngine/base/issues/197.
Before, attempting to use (required) = true on all numeric types and the boolean type resulted in false-positive violations of ValidatingException - the numeric fields were compared against  0 and boolean fields were compared against false, and if they were equal to those default values, the fields were considered unset.
This is semantically incorrect, because both 0 and false, while being a default, are valid values nonetheless.
Now, when trying to validate required fields of the following numeric types:

int32
int64
float
double

or a required field of type bool, a warning is produced, telling that doing so is incorrect.

@dmdashenkov, PTAL again.


service without healthchecks don't receive dns entry (not clear if intended)

Output of docker version:
Client:
 Version:      1.12.0-rc2
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   906eacd
 Built:        Fri Jun 17 20:35:33 2016
 OS/Arch:      darwin/amd64
 Experimental: true

Server:
 Version:      1.12.0-rc2
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   a7119de
 Built:        Fri Jun 17 22:09:20 2016
 OS/Arch:      linux/amd64
 Experimental: true

Output of docker info:
Containers: 125
 Running: 2
 Paused: 0
 Stopped: 123
Images: 236
Server Version: 1.12.0-rc2
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 470
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge overlay null host
Swarm: active
 NodeID: 6o19rpi5kx93jt9z6osdxfwfp
 IsManager: Yes
 Managers: 1
 Nodes: 1
 CACertHash: sha256:5711d0745394ebace6e82caa93a943281c0ce201902d4c3b6ba0b12f5d13cb02
Runtimes: default
Default Runtime: default
Security Options: seccomp
Kernel Version: 4.4.13-moby
Operating System: Alpine Linux v3.4
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 1.954 GiB
Name: moby
ID: 2PNZ:QY46:DCR2:IAU7:WUU4:Q5FZ:MAVC:KK7U:6JKH:LG2L:ANYI:3JP6
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 107
 Goroutines: 281
 System Time: 2016-06-26T17:28:58.594609691Z
 EventsListeners: 32
No Proxy: *.local, 169.254/16
Registry: https://index.docker.io/v1/
Experimental: true
Insecure Registries:
 <IP_ADDRESS>/8

mac beta
Steps to reproduce the issue:

docker service create --name dns_test --replicas=1  nginx:latest
docker exec -it  /bin/bash
ping dns_test

Describe the results you received:
root@b2e0ce1a5da7:/# ping dc_test
ping: unknown host

Describe the results you expected:
It should be a known host.
Additional information you deem important (e.g. issue happens only occasionally):
I'm not sure if this is intended because there is no health check, but either way it's currently not clear why there is no host. I'd imagine w/o a health check the status should always be OK. If a health check is required for a service then that should be made known somehow in the flow.

$ docker ps
CONTAINER ID        IMAGE               COMMAND                  CREATED             STATUS                    PORTS               NAMES
b2e0ce1a5da7        nginx:latest        "nginx -g 'daemon off"   2 seconds ago       Up 1 seconds              80/tcp, 443/tcp     dns_test.1.bnmkgsidlug1zwh7sdhmvnw7l
98f3a8a8ecb3        hc_test:latest      "nginx -g 'daemon off"   11 minutes ago      Up 11 minutes (healthy)   80/tcp, 443/tcp     web.2.bzpdiq8nuzzxdvdp0iyd4ynjt
d919e98214fc        hc_test:latest      "nginx -g 'daemon off"   13 minutes ago      Up 13 minutes (healthy)   80/tcp, 443/tcp     web.1.5dka4xamn4do07y1jsor7c9h

Also, since this is a service shouldn't the status be something even without a health check?

So, what's kinda strange is that the resolv.conf file had a <IP_ADDRESS> address iirc for another service that routed correctly https://github.com/docker/docker/issues/23965; however, my new containers have
root@a309e600e41b:/# cat /etc/resolv.conf
search local
nameserver <IP_ADDRESS>

I'm not sure why the file is different across create calls.


One issue about Tab autocompletion

First of all, thanks for your efforts! Application software in the field of biology requires indispensable automated auxiliary tools, which could greatly reduce learning costs and increase work efficiency.
After I install the PYMOLSNIPS (followed by the instructions from site: https://mooerslab.github.io/pymolsnips/#SublimeText3), part of the tab triggers is valid (ao; coordinate; sc222; stack) but the others are not.
if it's convenient for you, could you please give me some suggestions to address the problem?
Thanks for your time and your work again!

Thank you for the compliments and especially thank you for pointing out that some tab triggers were not working.
I found that those snippets were missing. This was the only library that was not properly updated with the full set of snippets.
The full set of snippets for Sublime Text is now on GitHub. Please download the library again and copy the snippets:
cp -a ./pymolsnips-master/st3pymolsnips/* ~/Library/Application\ Support/Sublime\ Text\ 3/Packages/User/snippets/Pymol/.

Thank you for the compliments and especially thank you for pointing out that some tab triggers were not working.
I found that those snippets were missing. This was the only library that was not properly updated with the full set of snippets.
The full set of snippets for Sublime Text is now on GitHub. Please download the library again and copy the snippets:
cp -a ./pymolsnips-master/st3pymolsnips/* ~/Library/Application\ Support/Sublime\ Text\ 3/Packages/User/snippets/Pymol/.

GOT IT. Thanks for your reply.

GOT IT. Thanks for your reply.

I closed this issue after waiting for a month.


Failed to load the line-ending-selector package(EPERM: operation not permitted, write)

[Enter steps to reproduce below:]

Install atom
Error occured

Atom Version: 1.2.4
System: Unknown Windows Version (Windows 10, version 1511, build 10586.29)
Thrown From: line-ending-selector package, v0.3.0
Stack Trace
Failed to load the line-ending-selector package
At C:/Users/Lord/AppData/Local/atom/app-1.2.4/resources/app.asar/node_modules/line-ending-selector/lib/status-bar-item.js: EPERM: operation not permitted, write

Error: C:/Users/Lord/AppData/Local/atom/app-1.2.4/resources/app.asar/node_modules/line-ending-selector/lib/status-bar-item.js: EPERM: operation not permitted, write
    at Error (native)
    at Object.fs.writeSync (fs.js:663:20)
    at SyncWriteStream.write (fs.js:1981:6)
    at Function.log (C:\Users\Lord\AppData\Local\atom\app-1.2.4\resources\app.asar\node_modules\babel-core\node_modules\debug\node.js:106:17)
    at enabled (C:\Users\Lord\AppData\Local\atom\app-1.2.4\resources\app.asar\node_modules\babel-core\node_modules\debug\debug.js:117:11)
    at Logger.debug (C:\Users\Lord\AppData\Local\atom\app-1.2.4\resources\app.asar\node_modules\babel-core\lib\transformation\file\logger.js:92:31)
    at File.parse (C:\Users\Lord\AppData\Local\atom\app-1.2.4\resources\app.asar\node_modules\babel-core\lib\transformation\file\index.js:573:14)
    at File.parseCode (C:\Users\Lord\AppData\Local\atom\app-1.2.4\resources\app.asar\node_modules\babel-core\lib\transformation\file\index.js:691:20)
    at C:\Users\Lord\AppData\Local\atom\app-1.2.4\resources\app.asar\node_modules\babel-core\lib\transformation\pipeline.js:167:12
    at File.wrap (C:\Users\Lord\AppData\Local\atom\app-1.2.4\resources\app.asar\node_modules\babel-core\lib\transformation\file\index.js:639:16)

Commands

Config
{}

Installed Packages
# User
linter, v1.11.3
linter-php, v1.1.6

# Dev
No dev packages

linter-php gives the same error

Already reported at atom/line-ending-selector#18.

@50Wliu I don't think this is the wrong repo, actually the issue occurs with different packages and is likely due to right issues in Atom itself.

I reopen this issue, as it's clearly an issue with Atom that can occurs when compiling a js file with use babel pragma (see how the same error occurs with minimap).
What we need now is to find what trigger this issue.

This seems a whole lot like https://github.com/atom/electron/issues/2033#issuecomment-114560015, though it's curious that in the minimap issue people report that reloading or disable/enable fixed it.
It certainly seems related to the compile cache. /cc @maxbrunsfeld for any theories

@LendLord Di you by any chance have the DEBUG or DEBUG_FD environment variables set when loading Atom? It looks like a module that we use, babel uses a logging utility library that tries to write to stderr if that variable is set. I think this will cause errors in Windows GUI programs because they don't have a stderr stream.


Update desktop-cross-report-drill-through.md

Customer feedback with CSS case : Power BI Desktop and Power BI Service changes are setup in a Tab format, so customer was confused on how to configure the service part. Customer feedback is to remove the Tab format and make it like
Step1: Power BI Desktop

Step 2: Power BI Service
Could we please consider changing the tab to a step by step format over here?

@maggiesMSFT - To clear the warnings, we can change the H1 Markdown to H2 Markdown before merge if you'd like.
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi, @JoelSteph -- thanks for your update! I fixed the formatting.
#sign-off

merging


MBEC available on 7th gen Intel processors, so why not usable for Windows 11?

There has been comment in the press based on an interview with Microsoft's David Weston, partner director of enterprise and OS security, as to why Windows 11 requires Intel 8th generation processors as a baseline (desktops: Coffee Lake, laptops: Kaby Lake Refresh):
https://www.techrepublic.com/article/windows-11-understanding-the-system-requirements-and-the-security-benefits/
I quote:

Eighth-generation processors also already include functionality that improves the performance of HVCI: Intel's Mode-based execute control for EPT (MBEC), AMD's Guest-mode execute trap for NPT (GMET), and ARM's Translation table stage 2 Unprivileged Execute-never (TTS2UXN). Older processors have to rely on slower, less power-frugal Restricted User Mode emulation, which is one of the reasons for the CPU requirements in Windows 11.

However, your documentation on Device Guard states Kaby Lake (7th generation Intel processors) and higher support MBEC:
https://github.com/MicrosoftDocs/windows-itpro-docs/blob/public/windows/security/threat-protection/device-guard/enable-virtualization-based-protection-of-code-integrity.md#enable-virtualization-based-protection-of-code-integrity

[!NOTE] Because it makes use of Mode Based Execution Control, HVCI works better with Intel Kaby Lake or AMD Zen 2 CPUs and newer. Processors without MBEC will rely on an emulation of this feature, called Restricted User Mode, which has a bigger impact on performance.

Is this a gap in documentation, or in the explanation as to why 7th generation processors are not usable with Windows 11?
For what it's worth, Intel's "8th generation" processors can be from five actual microarchitectures:

Coffee Lake (desktops, laptops)
Kaby Lake Refresh (laptops)
Whiskey Lake (laptops)
Amber Lake (laptops, tablets)
Cannon Lake (10 nm die shrink of Kaby Lake; one laptop model and two Intel-branded small form factor desktops)

For what Intel is calling the 8th generation, the company has explicitly stated that it will feature multiple architectures, including the Kaby Lake refresh processors (like the 15-watt CPUs announced here), Coffee Lake designs, and Cannonlake designs. It will also have parts built on the 14nm process technology node currently in use today as well as the 10nm process technology due next year.

My own ThinkPad T480 is equipped with a Kaby Lake Refresh processor, and PC Health Check indicates it is eligible for Windows 11, despite it being based on the same technology as 7th generation Kaby Lake, the main difference being that these mobile processors have twice the cores available compared to the Kaby Lake mobile processors (4 instead of 2).
I would suggest either fixing the documentation if indeed it is only "8th generation" Intel processors that support MBEC, or fixing the Windows 11 CPU floor.
(admin edit: adding article metadata for proper linking)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1d4b8d75-5d09-e0d6-1a90-45175fd1043d
Version Independent ID: dfb10d10-a514-6ea5-1307-df865db530db
Content: Enable memory integrity
Content Source: windows/security/threat-protection/device-guard/enable-virtualization-based-protection-of-code-integrity.md
Product: windows-client
Technology: itpro-security
GitHub Login: @vinaypamnani-msft
Microsoft Alias: vinpa

Also intel inc has  limited  windows os for i5 7th 7200U, this processor supported  only windows 10 OS and is  certified to OEM  to install only  windows 10 , if OEM prefers to preinstall windows

Will the Surface Studio 2 be supported (using a i7-7820HQ CPU)?

@vinaypamnani-msft Please help us in resolving this issue. Thanks

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


improve readability of CanvasGraphics's and SVGGraphics's constructPath

extract sub-programs into own functions:

rectangle(x, y, width, height)
moveTo(x, y)
lineTo(x, y)
curveTo(cp1x, cp1y, cp2x, cp2y, x, y)
curveTo2(cp2x, cp2y, x, y)
curveTo3(cp1x, cp1y, x, y)

align CanvasGraphics's and SVGGraphics's constructPath definition
as much as possible

Reason
constructPath has now improved readability and an user searching for information about the api and the way how PDF.js works can now easier see the parallels between the implementation for Canvas and for SVGs.

Won't adding a whole bunch of (strictly unnecessary) methods add an unnecessary level of indirection and quite possibly even slow down rendering by requiring many more function calls then the current code?

@Snuffleupagus Yes, they're strictly unnecessary but they help getting what the code does. Also the methods are defined as single ops and maybe they may occur standing alone (not sure about this because I could not find any documentation about this behaviour).
I don't think that it will slow down rendering speed that much. But: my main point is that you can see with one look what the functions do. That is not the case in the current implementation IMHO.

It can often, in general, be illuminating to look at the history of a particular piece of code.
In this case, you're essentially proposing to revert part of PR #4683, whose purpose was to improve the rendering performance of in particular large/complex PDF files. In that PR, readability was thus purposely traded for perhaps slightly less easily readable code.

... maybe they may occur standing alone (not sure about this because I could not find any documentation about this behaviour).

I don't think that can happen, given the changes made in PR #4683.

I don't think that it will slow down rendering speed that much.

Rather than guessing/assuming, please actually test the impact of your proposed changes!
Most likely, you'll have a slightly easier time convincing a reviewer to accept your patch if you can clearly demonstrate that it doesn't cause any performance regressions.
Please refer to https://github.com/mozilla/pdf.js/wiki/Benchmarking-your-changes for information about benchmarking, and perhaps https://github.com/mozilla/pdf.js/wiki/Contributing is useful too for general information about the test-suite.
The following PDF files contains lots of rendering operations, and would probably be good examples to use when benchmarking:
https://github.com/mozilla/pdf.js/files/1522715/wuppertal_2012.pdf
https://www.prorail.nl/sites/default/files/spoorkaart_prorail_april_2013.pdf

@Snuffleupagus Maybe I will turn this topic into another direction and write an example with improved readability while ignoring performance issues. So beginners would have a good point to start and can from there understand other implementation like the one for SVG or canvas.

I think there are two problems here.
The most important one is that the increased number of function calls will have a bad effect on performance, and eliminating them is one of the reasons why #4683 worked so well.
Moreover, I don't think that the current code is hard to understand and I don't feel that this patch makes it any clearer. For instance, all function names are the same as the operator, so you get this.rectangle(...) just below case OPS.rectangle and that doesn't give any more context. The same goes for the parameters and variable names: previously it would be x = args[j++]; whereas now it's args[j++]; // x, which is equivalent and also doesn't provide more context. The remaining comments are of the form // ensure height is not null just above if (height === 0), which is redundant.
In conclusion, I'm closing this since there does not appear to be much benefit in merging this unfortunately. We can definitely consider a patch though that adds inline documentation as comments, but then they do have to add context and not just explain the code.

I solved my readability issues by writing my own PDF.js core documentation that can be found here.

Thank you for your contribution! I think it can definitely help in understanding the core of PDF.js and I think it's also much better suited on a specialized wiki page than in inline comments. I have linked the documentation on the https://github.com/mozilla/pdf.js/wiki/Additional-Learning-Resources page.

Edit: Small feedback, it looks like the setTextRenderingIntent link in the overview does not work when clicked, while the others do.

I fixed it. The name setTextRenderingIntent was wrong because it is setTextRenderingMode.
I will try to improve my documentation when I have the time for it.


Updated help for account api keys and export

https://github.com/rancher/rancher/issues/5719
https://github.com/rancher/rancher/issues/5718
https://github.com/rancher/rancher/issues/5672


Application frozen on shut down

When trying to exit the app on Windows 10 the application freezes. Attached is a screenshot. The only way to kill it was to stop the java process through task manager.

That is the MultiDoge Wallet. Any issues should be directly raised over with them: https://github.com/langerhans/multidoge/issues. Though, the project appears to have been discontinued.
@patricklodder @rnicoll @michilumin  Close this one.


Incorrect status for setting SSL version

It seems that https://github.com/openssl/openssl/blob/3c83c5ba4f6502c708b7a5f55c98a10e312668da/test/ssltest_old.c#L862 may get invalid status INT_MAX, from SSL_ctrl() calls BIO_ctrl() (https://github.com/openssl/openssl/blob/master/ssl/bio_ssl.c) calls BIO_nread0() (can return INT_MAX).
My point is, can I still use SSL_ctrl()'s return code to determine if an error occurred or this is not your intention?

Here set_protocol_version is setting both the SSL_CTRL_SET_MIN_PROTO_VERSION & SSL_CTRL_SET_MAX_PROTO_VERSION using SSL_ctrl, where [ssl_check_allowed_versions && ssl_set_version_bound] are bound to return 0/1 depending on the operation status. The internal implementation of ssl_check_allowed_versions & ssl_set_version_bound also return 0/1.
The same has been followed in case of SSL_CTX_set_min_proto_version/SSL_CTX_set_max_proto_version -> SSL_CTX_ctrl, where the CTX_min/max version is set. And no operation is found to be performed on the return codes, while returning to the calling function.
Please correct me, if I'm wrong.

Hi @legendtang legendtang, We have reviewed the code set_protocol_version and it will call to SSL_ctrl for SSL_CTRL_SET_MIN_PROTO_VERSION & SSL_CTRL_SET_MAX_PROTO_VERSION. For both cases SSL_ctrl is taking care to return as 0/1. Hence it wont get wrong return status. Please check and close this bug as applicable.


Wrong or no code snippets for queries using $count

Describe the bug
Checking the examples in docs or even testing the examples in Graph Explorer, we notice that the code snippets for examples that include $count/$count=true are incorrect. The two scenarios are:

When $count is used as a path parameter (e.g. /users/$count), the code snippet is incorrect. [Update: identified a related issue to track this: https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator/issues/402)]
When $count is used as a query parameter (e.g. /users?$count=true), the code snippet doesn't show use of $count and is incorrect

To Reproduce (where $count=true is used)

Click the following request to run in Graph Explorer https://graph.microsoft.com/v1.0/users?$filter=endswith(mail,'a@contoso.com')&$orderby=userPrincipalName&$count=true
See code snippet responses below for Java and CSharp showing that $count isn't included

GraphServiceClient graphClient = new GraphServiceClient( authProvider );

var users = await graphClient.Users
	.Request()
	.Filter("endswith(mail,'a@contoso.com')")
	.OrderBy("userPrincipalName")
	.GetAsync();

GraphServiceClient graphClient = GraphServiceClient.builder().authenticationProvider( authProvider ).buildClient();

UserCollectionPage users = graphClient.users()
	.buildRequest()
	.filter("endswith(mail,'a@contoso.com')")
	.orderBy("userPrincipalName")
	.get();

To Reproduce (where /$count is used)

Click the following request to run in Graph Explorer https://graph.microsoft.com/v1.0/groups/$count
See code snippet responses below for Java and CSharp that are incorrect

GraphServiceClient graphClient = new GraphServiceClient( authProvider );

var int32 = await graphClient.Groups.$count
	.Request()
	.GetAsync();

GraphServiceClient graphClient = GraphServiceClient.builder().authenticationProvider( authProvider ).buildClient();

int int32 = graphClient.groups().count()
	.buildRequest()
	.get();

Expected behavior
The code snippets should be complete and/or accurate
Additional context
The problem also affects code snippets in docs. Examples:

Example 5 in List users
Example 2 in List groups

cc @Licantrop0

closing as duplicate of #497


Document DNS requirements for Workers

If a user has a zone already on Cloudflare, it is easy for us to allow them to set up a custom hostname.
It will take some work for us to actually allow people to CNAME to their zoneless Workers, but in the meantime, developers can still deploy to their own custom sites.
To support this without requiring too much user involvement, we would need to:

Create a dummy DNS record (if one doesn't already exist for the hostname), i.e. to <IP_ADDRESS> (to allow external DNS to resolve)
Create a wildcard route for the hostname (somewhat related: https://github.com/cloudflare/wrangler/issues/76 ).

We should document this as the recommended path for custom hostnames (will create separate issue in docs).

@ispivey @rita3ko Please correct me if I’m wrong, but I believe this may cover it:
https://github.com/cloudflare/workers-docs-engine/blob/4b8501576d3ff65a9d981ba8c06b4afee648c060/src/content/learning/getting-started.md#L349

Yes, absolutely, this is what the issue was about. I'll PR a small tweak, now that I'm thinking about it: we should recommend an AAAA record to 100::, which is the reserved IPv6 discard prefix, which ensures requests to "origin" will be immediately discarded/timed out.

Good to know. I need to update my site now... hehe.

Hehe... it's not super important, but it's definitely the safest and most foolproof way to do accomplish this, so figure we should recommend it explicitly.


DevTest labs sku not available in the west region

Some SKUs are subject to restrictions based on subscription types (MSDN, Trial, BizSpark). Use other regions to avoid SKU restrictions (US West 2, US East 2, US North Central, US South Central, Europe North, Southeast Asia, Korea Central, Korea South). See http://azure.microsoft.com/regions/services for current availability.


[Bug]: Display block not compatible with CSS layouts

Describe the bug
This commit (https://github.com/DaveKeehl/svelte-reveal/commit/18d0f6d58e0e912602326394ca4a939a0e3bcb89) adds extra CSS properties to the element. This breaks other CSS layouts if display is set to flex or grid etc.
The correct way to do this to let the user set display: block on the element if needed.
Reproduction
Any example shows the properties being applied.
System Info
Latest version, all browsers.

Severity
Serious, but I can work around it
Additional Information
Happy to submit a PR with a fix.

Hi, thanks for reaching out. Feel free to submit a PR. I'll take a look at it ASAP

I just released version 0.6.0 which solves your problem. Thanks for the feedback and suggestions! I've also updated the REPL example.


unique docstring extend #13565 unique datetime tz issue

closes  #13565
whatsnew
extended doc string for unique addressing the issue with timezone aware datetimes ( see #13565 )

not this not correct. documenting this is silly when it can easily be fixed.

I thought it can't be fixed easily / its the expected behavior (your own words) so i added a the docstring.

well its the 'expected behavior' because of numpy silliness


Setup wrangler outside of global

💡 Setup wrangler outside of global
Describe the feature
The current path for installing wrangler is to install it globally on your system, npm install -g @cloudflare/wrangler. Likewise, inside a project when you log into wrangler, wrangler puts this auth token in a global folder, /Users/{account-name}/.wrangler/config/default.toml. In Javascript projects, this is considered legacy and users should generally avoid installing packages and making configurations globally, preferring instead to install and configure them local to a project.
The requested workflow would be something like:
Starting in a projects folder, i.e. /Users/{account-name}/projects
npx @cloudflare/wrangler generate hello-world
The above command would create a hello-world folder and init wrangler inside of there.
From within the hello-world project folder, run npx @cloudflare/wrangler login. The result of running this command would create a wrangler-auth.toml file that contains the auth info for your project. Likewise this file would be added to .gitignore.
Describe the alternatives
The alternative is to keep the existing process and install and configure wrangler globally. The issue with this approach is A) it is not considered best practice in the industry and B) it does not scale for situations where as a developer I am doing work against multiple cloud flare accounts.

@threepointone are there any updates on the status of this? Having to install Wrangler globally is causing quite a few headaches for our projects and it would be awesome to be able to just install and run it as a local NPM package. 🙏

There are a couple of options here -

Install using cargo, or download the binary manually https://developers.cloudflare.com/workers/cli-wrangler/install-update.
With that, pass CF_ACCOUNT_ID and CF_API_TOKEN manually as environment vars when calling wrangler.

This should let you do isolated development with wrangler, and with multiple accounts. That said, you'd have to set up this stuff by yourself.

We're spending all our time right now on the wrangler 2 rewrite which should be Generally Available in Q1; this already is built to be used as a local dependency in your package.json. You can use CF_ACCOUNT_ID and CF_API_TOKEN with that if you'd like to use multiple cloudflare accounts; and we may build a more natural feature for multiple cloudflare accounts later too.

That’s awesome. That’s for the prompt reply. I’ll wait on Wrangler 2, as that sounds like a better fit for us than adding Cargo to our pipeline.

+1 to this feature.  This will make CI much simpler with being able to install and run wrangler local to repository where worker resides.

This is how we're dealing with this in the next major version of wrangler:

We do not attempt to create ~/.wrangler on install
On first usage, we only attempt to create the configuration file if you haven't explicitly passed CF_API_TOKEN/CLOUDFLARE_API_TOKEN
We encourage folks to use wrangler like any other npm package; NOT installed with -g, and as a regular dependency of their project. The executable code is then installed under node_modules as expected (You can still install it globally if preferred, but even then it uses node's global node_modules directory, not ~/.wrangler)

You can try this today with npm install wrangler@beta (note that we don't require the @cloudflare/ scope). We're actively developing this at https://github.com/cloudflare/wrangler2, and hope to go to GA soon.

Closing this since wrangler v2 is now in GA.


Fix API package name

invalid class name in Optional.Interface
So couldn't strip interface exactly.

Self-merged. Thanks for bringing this to my attention!

has this been merged into the dev builds?


feat: add custom dimension for tracking usager type

This commit adds a custom dimension to the Matomo tracking script to track the type of user that is visiting the website.
It set the custom dimension to "Agent connecté" or "Super-agent connecté" if the user is logged in as an agent or super-agent.
Otherwise, it sets the custom dimension to the value of the radio-set-visitor-type form field in the NPS form.
closes #817

I wait for agent connect debugging to merge this

@johangirod ready to merge this but can you please first solve the merge conflict ?


Add PrepareMixin for PigMapper

Implemented the prepare node functionality via a PrepareMixin, which can be added to any mapper.
For now added it only to PigMapper.

These commits became included in https://github.com/GoogleCloudPlatform/cloud-composer/pull/21. Closing.


Fix invalid HTML after hyphenating

HTML documents processed with metalsmith-hyphnate are malformed (missing HTML element). This changes parseFragment to parse so that the document is correctly parsed and serialised.

I used parseFragment so that 'metalsmith-hyphenate' can be used any templating (Jade in my regular usage) downward in the pipeline.
I had problems when I used 'metalsmith-hyphenate' with 'parse' after the HTML generated with Jade.
Not sure, if I'm doing something wrong.

Does it make sense to use parse() when <html> is present in the buffer, else parsing with parseFragment()?

Found the place where the plugin breaks when used after Jade or other templates. Merged you changes.
Thanks again :)


Create CONTRIBUTING.md

Looking for review from @michaeldorner and @maxcapraro.

Thank you for your contribution! But I can't hear you singing. ;-)

OK, fine ;/


CSV parsing in gh [gei|ado2gh|bbs2gh] reclaim-mannequin rejects valid CSVs

Description
gh [gei|ado2gh|bbs2gh] reclaim-mannequin allows you to pass in a --csv of mannequins to reclaim, based on the template generated with gh [gei|ado2gh|bbs2gh] generate-mannequin-csv.
At the moment, this only works with CSVs that exactly match the template - for example, if you generate a CSV with the headers quoted (which is allowed in CSV files), it is rejected:
"mannequin-user","mannequin-id","target-user"
"tim","M_kgDOB65srg","timrogers"

This is because, when reading a provided CSV file, we effectively treat the input as text rather than parsing it as a CSV.
It's quite likely that you end up with quoted CSVs, for example if you build them programatically using PowerShell.
We should make the CSV parsing more tolerant.
Reproduction Steps

Call gh [gei|ado2gh|bbs2gh] reclaim-mannequin --csv, passing in a CSV like the example above

We should follow the same pattern for csv parsing that we do for ado2gh migrate-repo --repo-list repos.csv
https://github.com/github/gh-gei/blob/main/src/ado2gh/Services/AdoInspectorService.cs#L41


apresolve.spotify.com is necessary for the Spotify web player to function, spclient.wg.spotify.com is necessary for the Spotify app to function.

I just reported this upstream at CHEF-KOCH/Spotify-Ad-free#2, but given that list is marked here as being updated "occasionally" I felt an issue here might also be worthwhile, since otherwise it means Spotify's web player will remain broken until whenever it gets updated over there and then merged over here.
EDIT: Appears to have been added in adc8004 as a result of #492.

Bonus: #153 and #270 are back in effect, as of the same adc8004 and also coming from the parent Spotify-Ad-free list. This marks the third time the same domain, spclient.wg.spotify.com has been added to the hosts list, breaking the Spotify app for mobile users.

Sorry but no. #153 && #270 applies to the old data (Cf: https://github.com/FadeMind/hosts.extras/blob/61f798c860e463b540889aed6a6df5066e85e5df/SpotifyAds/
update.json) which was maintained by @FadeMind which is not the case here (cf: https://github.com/FadeMind/hosts.extras/blob/e5702b4e40edd63f4c5a53322e6cd3fe65862230/Spotify-Ad-free/update.json)

You're correct that the upstream source for the blocked domain is different to the one from those old issues, but I'm not sure what point you're making.
My comment above about spclient.wg.spotify.com "also coming from" Spotify-Ad-free refers to the fact that apresolve.spotify.com in the initial issue post is coming from that list.
And it's the third time this domain has been blocked by StevenBlack/hosts, albeit it's come from at least two different upstream sources.
If you're just making the point that it's technically a different issue to the previous ones because the upstream source is different, then sure. But I referenced them because they refer to the same domain being blocked in StevenBlack/hosts.

The Spotify list also blocks redirector.gvt1.com which appears to prevent Firefox from installing the Widevine decryption module.

redirector.gvt1.com is apparently also the domain over which Google Chrome browser updates are served. It seems quite important. This Chromium issue comment says redirector.gvt1.com "redirects to other hosts in the gvt1.com domain, which is shared with other services," which seems like it'd explain why you're having issues in Firefox. No idea what "other services" beyond Chrome and Firefox could be relying on this, but it seems like a great degree of caution should be observed in blocking it.

The point is Steven @StevenBlack choose to include a list or not but on the other side, he does not touch any list. It's the responsibility of the upstream source to make the changes. Which means that you (or @StevenBlack ? :thinking: ) should add it to whitelist and that's all unless the maintainer of the upstream source decides to remove it.
So to resume there is two case:

The upstream source maintainer removes the domain/IP

Steven updates this repo and that's it.

The upstream source maintainer does not want to remove the domain/IP for his own and valid reason (for example https://github.com/StevenBlack/hosts/issues/505#issuecomment-366695531)

You (or Steven) add the domain/IP to the whitelist list and you only have to update your copy with the script.

Thanks @vaguerant I've just dropped that source of hosts data.
Please update your hosts file, and try it now.

Just confirming that everything's back to normal after a list update; thanks for the rapid support.


Upgrade syn dependency once wasmtime-component-macro is updated

Once wasmtime-component-macro is released on a version that uses syn v2, we can upgrade the dependency in wit-bindgen-wasmcloud

This was accomplished, syn is now version 2, and pulled from the workspace


[Bug] CldImage does not support Next Image fill

Bug Report
Describe the bug

I am trying to move from NextJS's next/image over to your CldImage so I can fetch images directly from Cloudinary but when I try to swap my tag I get this error header sent back at runtime: x-cld-error: Invalid width in transformation: NaN. It seems that NextImage can accept fill={true} and not need a width or height specified but CldImage cannot.
This is unexpected because the documentation states 'At its core, Next Cloudinary offers a CldImage component that wraps and extends the Next.js Image component, giving you the same developer experience you expect from Next.js, while providing the features and performance you love from Cloudinary."
Expected behaviour

I expected that it would offer the same functionality as the underlying component.

That's my issue thanks. Let me know if there is any more info I can provide

i went ahead and merged it in since it fixes the bug. let me know if i seem to be missing anything though!

hey @Max29a created a PR here: #113
wanted to confirm the expectation of the feature as it's not a feature I usually use
If you look at the example I added to test this:
https://next-cloudinary-keak0yptx-colbyfayock.vercel.app/components/cldimage/examples#next-image-features
i set a height explicitly on the parent and by default, Next.js fills that container, so the image warps a bit unless you use something like object-fit (per docs)
is this what you expect? anything missing?

This does sound like what I am expecting thanks. I am using object-fit as referenced here: https://nextjs.org/docs/api-reference/next/image#fill


Mismatch between the point cloud slice and distance map slice

Hello!
I'm using Rviz2 to visualize the distance map slice and I sometimes see a disagreement between the origin of the distance map slice and the point cloud slice. It seems that the origin of the distance map slice sometimes is off by one voxel in either (or both) x and y directions. When i move the robot around I can see the offset shifting around once in a while.
Note that i convert the nvblox distance map slice to a nav_msgs::msg::OccupancyGrid msg to enable visualization in Rviz, but their msg fields should have a 1-1 correspondence.
I think this could be a potential issue in the implementation of: RosConverter::distanceMapSliceFromLayer(), but I'm not sure.

Interesting! It's possible you've found a bug.
Could you upload a video showing the effect so I can try to repro? 😃

I've written a simple example that shows how I convert between a standard nav_msg OccupancyGrid and the nvblox DistanceMapSlice so you can test it quickly.
// CostMap color palattes: http://docs.ros.org/en/jade/api/rviz/html/c++/map__display_8cpp_source.html
constexpr int8_t kNoInformation = 0;
constexpr int8_t kFreeSpace = 1;
constexpr int8_t kMinCost = 2;
constexpr int8_t kMaxCost = 98;
constexpr int8_t kInscribedInflatedObstacle = 99;
constexpr int8_t kLethalObstacle = 100;

ObstacleMapping::ObstacleMapping() : Node("obstacle_mapping") {
  RCLCPP_INFO(this->get_logger(), "Launching Obstacle Mapping Node!");

  occupancy_inflation_distance_ = declare_parameter<float>("occupancy_inflation_distance_m", occupancy_inflation_distance_);
  occupancy_max_distance_ = declare_parameter<float>("occupancy_max_distance_m", occupancy_max_distance_);

  // Publishers
  pub_obstacle_map_ = this->create_publisher<nav_msgs::msg::OccupancyGrid>("~/occupancy_grid", rclcpp::SensorDataQoS());

  // Subscribers
  sub_distance_map_slice_ = this->create_subscription<nvblox_msgs::msg::DistanceMapSlice>("/nvblox_node/map_slice", rclcpp::SensorDataQoS(),
                                                                                std::bind(&ObstacleMapping::DistanceMapSliceCallback, this, std::placeholders::_1));
}

void ObstacleMapping::DistanceMapSliceCallback(const nvblox_msgs::msg::DistanceMapSlice::ConstSharedPtr& msg) {
  // Create occupancy map from nvblox slice
  nav_msgs::msg::OccupancyGrid::UniquePtr occupancy_grid = std::make_unique<nav_msgs::msg::OccupancyGrid>();
  occupancy_grid->header.frame_id = msg->header.frame_id;
  occupancy_grid->header.stamp = msg->header.stamp;

  // Copy map dimensions
  occupancy_grid->info.origin.position = msg->origin;
  occupancy_grid->info.resolution = msg->resolution;
  occupancy_grid->info.width = msg->width;
  occupancy_grid->info.height = msg->height;

  // Allocate the occupancy grid directly
  size_t map_size = msg->width * msg->height;
  occupancy_grid->data.resize(map_size, kNoInformation);

  // Remap the floating point distance to occupancy grid colors
  const auto k_unknown_value = msg->unknown_value;
  for (size_t i = 0; i < map_size; ++i) {
    // Default: No information
    if (msg->data[i] <= k_unknown_value) {
      continue;
    }

    // Lethal obstacle
    if (msg->data[i] <= 0.0F) {
      occupancy_grid->data[i] = kLethalObstacle;
      continue;
    }

    // Inflated obstacle
    if (msg->data[i] <= occupancy_inflation_distance_) {
      occupancy_grid->data[i] = kInscribedInflatedObstacle;
      continue;
    }

    // Free space
    if (msg->data[i] > occupancy_max_distance_) {
      occupancy_grid->data[i] = kFreeSpace;
      continue;
    }

    // Distance scale
    occupancy_grid->data[i] = kMinCost + static_cast<int8_t>((kMaxCost - kMinCost) * (1.0F - std::min((msg->data[i] - occupancy_inflation_distance_) / occupancy_max_distance_, 1.0F)));
  }

  pub_obstacle_map_->publish(std::move(occupancy_grid));
}

The video below should highlight the issue. The point cloud distance slice is shown with the point tiles and the underlying distance map is the OccupancyGrid msg slice. The point cloud distance slice seems completely static, but the other map jumps a bit around. The maps are also not completely aligned, which is likely also related to this same issue.
example(1).webm

Could you please try again with the latest Isaac ROS DP3 Release?

The jump is no longer present in the new release :)

@Veng97 Thank you for your help in finding this. much appreciated :+1:


[1.16] You can pour infinite milk

Industrial Foregoing Version:
industrial-foregoing-1.16.4-<IP_ADDRESS>-6b5c95b
Titanium Version:
titanium-1.16.4-3.2.5
Forge version:
36.0.1 (latest for 1.16.5)
Slightly different from #912, I think.
https://user-images.githubusercontent.com/15698722/105575272-0e05b300-5d30-11eb-9b64-235db598bfa2.mp4
After pouring milk, I can click the empty bucket two more times to make two more sources.

Please update to the latest version where I dont handle the milk bucket, as that one is the forge one

Please update to the latest version where I dont handle the milk bucket, as that one is the forge one

Unless I'm missing something, I am using the latest version.
industrial-foregoing-1.16.4-<IP_ADDRESS>-6b5c95b
https://www.curseforge.com/minecraft/mc-mods/industrial-foregoing/files/3167607

Unless I'm missing something, I am using the latest version.
industrial-foregoing-1.16.4-<IP_ADDRESS>-6b5c95b
https://www.curseforge.com/minecraft/mc-mods/industrial-foregoing/files/3167607

Huh, fair enough then lol

Huh, fair enough then lol

Curseforge why are you the way that you are

Curseforge why are you the way that you are


[BEAM-9963] Fix coder type in failing ParDo streaming load test

The newly added load tests fails. Apparently this was caused by addressing
a linter message right before the merge.
https://builds.apache.org/job/beam_LoadTests_Python_ParDo_Flink_Streaming_PR/39/console
16:00:38   File "apache_beam/coders/coder_impl.py", line 690, in apache_beam.coders.coder_impl.VarIntCoderImpl.encode_to_stream
16:00:38   File "apache_beam/coders/coder_impl.py", line 692, in apache_beam.coders.coder_impl.VarIntCoderImpl.encode_to_stream
16:00:38 TypeError: an integer is required

The coder for the state cell should be an iterable varint coder but it is
sufficient to just supply the combine function.

Run Python Load Tests ParDo Flink Streaming


Template Studio should be replaced with Template Playground

Bug Report 🐛

Links and references to Template Studio should be replaced with Template Playground
Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce

Context (Environment)

Desktop

OS: [e.g. macOS]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 0.22.15]

Detailed Description

Possible Implementation

Looking into this.

.take


Initialize metrics with labels

So far metrics with labels were registered but not initialized at startup. This leads to unpredictable resources usage and limits certain registry operations, e.g. linting or autogenerating docs.
This PR initializes metrics with known labels. It required explicitly defining known labels, so there are lots of commits doing just that - defining types for label values. Let me know if you want me to squash some of these commits. I also used InitMetrics functions as a notebook and left some comments for the future about metrics naming - hope that's ok.
A few remarks about the impact and limitations of this approach:

Initializing metrics at startup means increased initial resources usage. However, it also means that metrics volume is more predictable and can be planned for - that's good.
Some metrics have labels that depend on the environment: process metadata (namespace, workload, pod, binary), policy name, hook point. These metrics are not initialized.
Some metrics have known labels, but are registered as custom collectors. These are also not initialized.

I'll re-open this PR from a branch in the repo not a fork, so that I can stack follow-up PRs.


Fix source maps for sentry.

:tada: This PR is included in version 4.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Move FCM class to organisms, convert rendering of it to include_block

This PR addresses a few things, most urgently the inability to compare revisions on any page that has an FCM (due to the outdated FeaturedContent template property).
It moves the Python code to organisms to be consistent with that change in the front-end code, and removes the macro-based rendering setup to the more standard Wagtail include_block method.
It also corrects a lingering template issue with empty link list markup when no link was set up.
Changes

Moves the RelatedPosts class from molecules.py to organisms.py
Updates page templates to render RelatedPosts blocks via include_block instead of macro.render()
Fixes related-posts.html template logic to not render empty link list markup if no links are present

Removals

Unused macro_link stuff in related-posts.html

Testing

Pull branch
Visit pages of each type with an FCM and confirm that they are still working

Browse: http://localhost:8000/es/prepararse-para-comprar-casa/hipotecas/
Sublanding: http://localhost:8000/consumer-tools/auto-loans/
Sublanding Filterable: http://localhost:8000/consumer-tools/auto-loans/
Browse Filterable: One doesn't exist that uses an FCM. You can make your own.
Newsroom Landing: Doesn't currently uses an FCM. You can make your own.

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the development playbook
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated
[ ] Reviewers requested with the Reviewers tool :arrow_right:

I don't want to blow up the scope of your PR, but while you're in here:

Is it a bug that category is not required, but a null category is not checked for in the template? If you leave the category blank, the page validation passes, but you see a None on the page:

Similarly, image is also optional. I don't think that this required=False is doing what we want, because this elif value.image is still evaluating as true even if you don't specify an image. This is probably because the ImageBasic block does always exist; what we really want to check is value.image.upload. See also https://github.com/wagtail/wagtail/issues/2665 which explains that required doesn't have any affect on a sub-StructBlock. If you don't specify an image, you get this kind of thing in the page source:

Per this logic, this if value.video is also probably always true, although here we're correctly checking against .url and .id.

Conversely, our Hyperlink does seem to have some kind of custom required logic. We don't enforce that links have URLs, which allows you to enter links that don't point anywhere:

Validating this would require a change to Hyperlink, but the template for the FCM could add a check for value.links[0].url here to at least skip empty links.

post_link_text is included in the template even though it is also not required. Should it default to the page title? If you don't enter a title, a weird empty link is inserted in the page source:

@chosak All good catches, thanks! Fixed them up in the latest commit, then rebased on master and force-pushed.


OSX High CPU usage

Every now and then the CPU Usage gets around 50% for quite a while and makes the OS quite slow.
Also getting the beachball very often on OSX Sierra when starting a task on TogglDesktop

This should be improved in the latest beta. Could you please switch to beta channel from the about view and see if the update works better.

Seconded. Ill try the beta Channel and see if this fixes things

I've changed the release channel to beta and works great now! Thanks @IndrekV

Thank you for getting back to me on that. Glad that it's better now. Thank you for reporting.


Update dev dependencies

the weekly update of dev dependencies

@ingorichter I ran to this strange dependency error with is-property library not being present, which is required by electron-prebuilt. I then went ahead and added is-property as one of the dependencies and the build succeeded fine. Should we add is-property as one of the dependencies?

@nethip I haven't seen the issue yet. The lib isn't mentioned in package.json of electron-prebuilt.

@ingorichter hmm.. That's strange. On my system npm install fails just for this reason.

It works for me, too.
Thus merging.
@nethip You could try to delete your entire node_modules folder and do a fresh npm install thereafter. That sometimes resolves such npm issues.


Rules regarding use of AI

Is it permitted to use AI's such as ChatGPT to help solve the different assignments?

Yes, this is being added to the course description.


Feature/redux

@wialy I strongly recommend to not store api responses in redux. Libraries like a react-query uses their own cache reducing amount of boilerplate. I think whole PR will be much smaller if we will use react-query instead. I use it on my projects and it's awesome.
Can we add react-query to our frontend-template? What do you think?


Squeezebox updates

Description:
Updated squeezebox component to handle the playing of media by setting playlist or adding to a existing playlist.
Related issue (if applicable): fixes #
NA
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
No changes in configuration, just additional support for more service calls to the squeezebox component.
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[X] Documentation added/updated in home-assistant.io

If code communicates with devices, web services, or a:

[X] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[X] New dependencies have been added to the REQUIREMENTS variable (example).
[X] New dependencies are only imported inside functions that use them (example).
[X] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[X] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

resynced my dev branch with the dev branch and updated pull.


Django version deprecations / upgrades

deprecate django versions 1.6 and 1.7 gracefully,
support django 1.9

see https://www.djangoproject.com/download/#supported-versions


Scrolling when specifying the parent breaks the picker

Description of the issue
When I specify the option parent, and scroll the picker follow the parent but when I then click to choose a color it's most of the time black. It's due to the fact that it register the click like if the picker was positionned when first displayed (not after the scroll). It works fine when not specifying the parent option but then the scroll doesn't work 😅

That's interesting, I specifically fixed that issue several weeks ago and I'm unable to reproduce it now. Can you please provide a test case where you can reproduce this issue?

@VincentMolinie Is your issue resolved? Should I close this?

I'm closing this for lack of activity.


Use dpkg to count installed packages for apt users

Resolves https://github.com/dylanaraps/neofetch/issues/1719

Equivalent change has been merged from elsewhere. Care to elaborate on the memory changes?


Failed connecting to robot inventor

I'm having issues running any logic that depends on LEGO Hub connection. I'm running this on Raspberry Pi 4B. I setup Bluetooth connection with the hub following another tutorial. I had issues initially but after I followed the tutorial it seems to connect now if I select the option to connect it to serial port. The blue light comes on and the hub is shown as connected in the Bluetooth status area on the Pi.
On the coding canvas I can see the MAC address of the Hub is picked up so there is some kind of connection.
When I attempt to run a script I get the following error:
"Initialization of control failed.  Failed connecting to robot inventor, try restarting the robot inventor hub and run initialize again."
I tried rebooting both the Pi and the hub.
Any hints on how to troubleshoot this or how to establish a successful connection?
The tutorial I followed for setting up Bluetooth connection is here: https://medium.com/jj-innovative-results/how-to-set-up-bluetooth-on-the-raspberry-pi-for-a-lego-spike-61b137f98673

OMG, I did not just spend a day trying to get this to work when it is in fact that SIMPLE.
No need to manually connect Hub via bluetooth. I just started one of the example scripts, turned hub on and pressed bt button and the script does the bluetooth connection on initialization.
Feeling a little silly now. This can be closed

Hi @kaalen, sorry I missed your issue, I have been busy on another project lately. Good to know you have gotten it worked out.


Add initial implementation for AI Connector

Purpose
WSO2 MI AI Connector
This connector currently supports two primary operations:
1. PROMPT
Enables users to execute various tasks using AI, such as:

Transforming messages between formats (e.g., JSON to XML, XML to JSON)
Summarizing content for easier consumption

2. SCAN
Specializes in document processing by utilizing AI to:

Read and extract content from images or PDFs
Convert content into a structured JSON format for further use
Allow users to specify a custom response schema for precise output

Note: As we continue to understand and address user needs, we plan to expand this connector by incorporating additional operations to meet emerging requirements.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email<EMAIL_ADDRESS>to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to<EMAIL_ADDRESS>and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


test数据集的使用

请问为何要在训练过程保存在test数据集上最优的模型，这样划分验证集和test集的意义是不是就没有了？这样得到的结果和别的模型作比较是否不公平？

Hyperparameter tuning was conducted and selected over the validation data. And all experiments and ablation studies were under the same setting.

When I conducted experiments to reproduce your results based on your command lines that you provided, it seems that you reported results through hyperparameter tuning on the test data. This should not happen in research.
P/s: although if you use results through hyperparameter tuning on the validation set, the results just reduced about 1-2% compared to your results on your paper.
Anw, can you provide your command lines for train_binary.py file on the PDTB2.0 dataset?

Hi, thanks for your interest in our work. Our models were saved based on the evaluation over validation data. We ran multiple rimes and averaged the accuracies/f1 scores. If you cannot reproduce our experiments, please try our seeds 0, 1000, 1996, 2000, 2020. It's worth noting that we might get different results even when we used the same seeds. If you have the same problem, please set "save_best" as "accf1" because it makes the difference between validation and test performance as close as possible.
For the commands for "train_binary.py", the only change is to explicit set "relations" as "Comparison"/"Contingency"/"Expansion"/"Temporal".

Thank you for your reply. I tried to run your code for the binary classification, but it had a bug in Sampler class. When I fixed this bug in the same way you fixed it in the train.py file, there was a bug in the evaluation. Can you re-run your code to check it?

Updated. Please have a try.


(PUP-1635) Make daemon.rb signals Ruby 2.x safe

Ruby 2.x changes the way signals work to mean you can't do certain things from the 'trap context'. This means that SIGUSR1 and the like no longer work.
This change makes it so that we, instead of processing methods in the 'trap context', just store them on a list and pop them out the other side in another job called signal_loop.
This is modelled on the way other Ruby Daemon-like projects have fixed this issue.

Okay okay I'll fix the tests ;)

In fact - trying to fix the tests shows that they: rarely seem to run properly on my Debian Wheezy machine and when they do I can't seem to fix the issue - I'm not sure how do that in rspec.

That solution passes but I don't know how to test that I pop the method and call it in another loop. Looking at the tests that doesn't usually get checked for other bits either. Open to suggestions - but this passes now.

CLA signed by all contributors.

Thanks @leepa for the contribution! At this time though we're getting ready to release Puppet 4.0.0, and until we do there's a hold on doing merges. Please be patient and we'll keep an eye on this PR for review.

I don't mean to sound rude @ScottGarman but is that truly a sane idea to do a major release of Puppet that does not work correctly on the most common version of Ruby? That sounds like a bit of a blocker to me.

@leepa no worries, that's a legit question; more so now because we'll be bundling ruby 2.1.5 in our new packaging that rolls out with puppet 4, so this would be a regression on some platforms (previously users of the system ruby on, say, rhel 5/6 would never hit this).
That said, we are in a merge freeze window for puppet 4.0.0-rc1 (down to mostly some final packaging related changes), which is what @ScottGarman is referring to. Of course, none of that stops us from reviewing this, so that it is ready to go once we open back up for merges. Also just a heads up that we are fully expecting we'll be doing Z releases for 4.0.0 in short order, so it's not like 4.0.0 would be the last shot :)

@kylog sure - thanks for the detailed answer. I totally get freezing in terms of features but bugs that, as you say, regress the experience for RHEL 5/6 users (of which there are still log) seems wrong. Especially when the 'packaging' will include a version of Ruby where simply doing mco puppet runall 10 will bin all your puppet agents.
Incidentally, this PR works on Ruby 1.9.x as well from my testing.
I would still argue this bug is a blocker to a release with a 2.x version of Ruby bundled. I'm more surprised no one picked this up already in testing 4.x.

I'm more surprised no one picked this up already in testing 4.x.

It would have turned up in puppet 3.x as well given a 2.x ruby. My best guess is that use of SIGUSR1/etc is not very widespread. E.g. anecdotally I'm aware of some large ruby-2.x installs who haven't mentioned this.
Also we have no tests for this today. On the ticket, I suggested we add an acceptance test (pretty hard to test for this at spec level) so we don't regress in the future.

I have updated this as per @kylog comments to add a constant instead of using a magic number.

Merged to master in 4ccb00c. Thanks for the contribution!

Well done guys - I take it this fix will be part of Puppet 3.7.5?

@sammcj this was merged to master, so will be released in 4.0.0.

So, no one can use puppet 3 non-interactively on any Linux OS that has Ruby 2.x because if so that's going to put a hard dependency on everyone upgrading to Puppet 4 to use say Debian 8, RHEL 7 etc...
Also, isn't the Puppet 4.x client compiled rather than Ruby based?

It would have turned up in puppet 3.x as well given a 2.x ruby. My best guess is that use of SIGUSR1/etc is not very widespread. E.g. anecdotally I'm aware of some large ruby-2.x installs who haven't mentioned this.

Well we found out because we both use mcollective and an ENC/dashboard.
By default that's how mcollective sends a trigger for the puppet agent to restart, but it does not return an error code. The ENC allowed us to catch that all non-interactive triggers were failing on ruby 2.0
So I would assume it is a widespread problem, just not one that is visible unless you're actually looking for it.

@lak sorry to CC you in here but I want to make sure this isn't missed as it might have a larger fallout for you guys than imagined (or perhaps we're wrong?).

@sammcj while i hope you don't take this as encouragement to ping people's boss to get them to do what you want, we have pulled this back to 3.7.x and it will be in the next point release.

@ahpook absolutely not, and thank you so much - I could see this blowing up and having to be retroactively backported if it wasn't done now anyway.
Keep up the great work!


NOOb - how to connect in ha-OS version

Hello,
sorry if it sounds dumb, but I homeassistant as OS on my raspberry,
i've install the extension:
i've started it , the log seems to be okay, like

[17:56:43] INFO: done
[17:56:43] NOTICE: TimescaleDb is running!

but then i don't know how to connect,
from external machine the port doesn't seems to be open (by default i guess)
but if i try to psql in the ssh extension i get

command not found

not sure how and where i'm supposed to use it 🤔
(after that i would like to make a duplicate of recorder for more long term & fine-grained stats)

No problem! I'm glad to help you.
please check out  https://github.com/Expaso/hassos-addons/issues/1 first.
And also check out: https://community.home-assistant.io/t/home-assistant-add-on-postgresql-timescaledb/198176
This will point you into the right direction of using Timescale for long-running stats :)
When you want to connect to timescale form the outside world, you have to open-up it's ports in the configuration-page first:

nice thanks :)
i can now connect , change the user & stuff 🎉
still wondering where the data are, but now i'll  try to connect the recorder & ltss & stuff :)

The recorder stores it's data in the events table, and ltss stores it in the ltss table.
From here, you can use all your query and timescale magic 🪄


Custom tooltip placement bug when using _make_custom_tooltip

Godot version:
3.2 (b3af0b2a394d8671849ee8637007fc9c27e1c43f)
Note: Commit b3af0b2a394d8671849ee8637007fc9c27e1c43f is needed for RichTextLabel's 'Fit Content Height' property used in the MRP - but the bug is reproducible even without it / without using RichTextLabel.
This is "reproducible" in the master branch but harder to see as a bug since default tooltip also go out of the window just fine now with multiple window support.
OS/device including version:
Linux
Issue description:
When showing tooltips, Viewport is responsible for ensuring that the tooltip panel will be within the bounds of the viewport, to avoid having content cut on the edges:

Control has a virtual method _make_custom_tooltip that can be overridden from scripts to return a custom Control that will be used as the tooltip (still nested in a TooltipPanel in Viewport). When using this, the logic that makes it stay within bounds seems to fail:

I don't know why yet, so opening an issue.
Relevant code in 3.2 branch (might be relevant in master too):
https://github.com/godotengine/godot/blob/42a31501a8bd858d5560b389712a7c230a4c2074/scene/main/viewport.cpp#L1592-L1632
Steps to reproduce:

See MRP
Compare the tooltip when you hover "Debug build" when _make_custom_tooltip returns a custom Control (here a PanelContainer) or the default tooltip. Uncomment #return null in addons/debug_watermark/debug_watermark_label.gd to use the default tooltip.

Minimal reproduction project:
godot-debug-watermark.zip
Example code from https://github.com/akien-mga/godot-debug-watermark/tree/custom-tooltip

This turns out to be a very simple one. The tooltip code in viewport.cpp is using get_minimum_size() for which Label - used in default tooltip - correctly reports minimum size based on its contents, whereas the RTL - used in your custom tooltip - returns (0, 0) hence the difference in behaviour. This is also reported as issue #18260.
Using get_size() fixes the problem. This seems to be the correct function to call anyway - we want to account for the "true" size, rather than the minimum one. Will open a PR with a fix in a bit.

Actually, the documentation on _make_custom_tooltip function has this note attached.

Note: The tooltip is shrunk to minimal size. If you want to ensure it's fully visible, you might want to set its rect_min_size to some non-zero value.

So it was a deliberate decision to use min_size instead of the real size. In that case I'd say this is not a bug, it's an expected behaviour. I'd still argue using a size instead of min_size would be better solution but that's not the decision for me to make.

What's puzzling is that even forcing a non-zero rect_min_size doesn't fix the issue. E.g. in my example:
func _make_custom_tooltip(for_text):
	var tooltip = $Tooltip.duplicate()
	var rtl = tooltip.get_node("MarginContainer/RichTextLabel")
	rtl.bbcode_text = for_text
	# Work around https://github.com/godotengine/godot/issues/18260.
	# FIXME: Not working :(
	rtl.rect_min_size = rtl.rect_size
	return tooltip

Still produces the same result.
The tooltip node of type PanelContainer, which is returns as the Control for _make_custom_tooltip, also has a non-zero rect_min_size defined in the scene.

The problem with get_minimum_size() is more complex than "just" #18260.
Control::get_minimum_size() doesn't honor rect_min_size set from script, which is used instead in Control::get_combined_minimum_size(). My project uses a PanelContainer, whose PanelContainer::get_minimum_size() actually uses Control::get_combined_minimum_size() for its child nodes, but only for those which are visible in tree... which is likely not the case of the tooltip control in Viewport::_get_gui_show_tooltip() as it's only show()-ed as the last step. So all calculations are done with the (combined) minimum size which has not yet been updated for neither the PanelContainer nor its child RichTextLabel.
This is all pretty messy, I think all *minimum* APIs in Control and derived classes need a serious refactoring.

This patch makes setting a custom rect_min_size functional:
diff --git a/scene/main/viewport.cpp b/scene/main/viewport.cpp
index<PHONE_NUMBER>..7db7b28916 100644
--- a/scene/main/viewport.cpp
+++ b/scene/main/viewport.cpp
@@ -1607,6 +1607,8 @@ void Viewport::_gui_show_tooltip() {
        }

        rp->add_child(gui.tooltip_popup);
+       gui.tooltip_popup->show();
+
        gui.tooltip_popup->force_parent_owned();
        gui.tooltip_popup->set_as_toplevel(true);
        if (gui.tooltip) // Avoids crash when rapidly switching controls.
@@ -1629,7 +1631,6 @@ void Viewport::_gui_show_tooltip() {
        gui.tooltip_popup->set_size(r.size);

        gui.tooltip_popup->raise();
-       gui.tooltip_popup->show();
 }

 void Viewport::_gui_call_input(Control *p_control, const Ref<InputEvent> &p_input) {

I don't know if this could introduce flickering to have the show() happen before setting the position, but it seems necessary for the min size logic to work.

And as I supposed, this also works:
diff --git a/scene/gui/panel_container.cpp b/scene/gui/panel_container.cpp
index 74663c33e3..7e7daa780d 100644
--- a/scene/gui/panel_container.cpp
+++ b/scene/gui/panel_container.cpp
@@ -43,7 +43,7 @@ Size2 PanelContainer::get_minimum_size() const {
 	for (int i = 0; i < get_child_count(); i++) {

 		Control *c = Object::cast_to<Control>(get_child(i));
-		if (!c || !c->is_visible_in_tree())
+		if (!c || !c->is_visible())
 			continue;
 		if (c->is_set_as_toplevel())
 			continue;

(exclusive of the other patch)
@reduz changed is_visible() to is_visible_in_tree() in 04c749a1f034c0b2256fdca0ca2675f696b490e8 when introducing this API, but in this case it's maybe not the right choice as we want to be able to calculate a min size for what would be visible once added to the tree.

What's puzzling is that even forcing a non-zero rect_min_size doesn't fix the issue.  E.g. in my example:
code
Still produces the same result.

Oh, you are on the right track here! It is indeed the problem with how PanelContainer computes the minimum size. However, I think no engine changes are needed :). Tooltip panel that you are using as a template is not visible in the scene. When you duplicate it, the duplicate - and thus all its children - are also not visible. Hence when the PanelContainer::get_minimum_size()  is called, it considers all its children not visible and only returns (20, 20) as a minimum size, which is just the sum of margins as configured in the child MarginContainer. Changing your script to this mostly solves the issue:
func _make_custom_tooltip(for_text):
	# Uncomment this to fix bug.
	#return null

	var tooltip = $Tooltip.duplicate()
	tooltip.visible = true
	var rtl = tooltip.get_node("MarginContainer/RichTextLabel")
	rtl.bbcode_text = for_text
	rtl.rect_min_size = rtl.rect_size
	return tooltip

The only issue still is that the RTL rect_size is not correctly returning the height, so I end up with the tooltip cropped fro mthe bottom a little bit.

	# Uncomment this to fix bug.
	return null

This would return a default tooltip, not my custom one :)

Whoops, sorry, my bad. Forgot to remove that from the MRP code :)

Here's cleaned up code.
func _make_custom_tooltip(for_text):
	var tooltip = $Tooltip.duplicate()
	tooltip.visible = true
	var rtl = tooltip.get_node("MarginContainer/RichTextLabel")
	rtl.bbcode_text = for_text
	rtl.rect_min_size = rtl.rect_size
	return tooltip

The important change is setting tooltip visible after duplicating it so the parent Panel uses the min_size as set in the property

So I was about to make a patch with https://github.com/godotengine/godot/issues/39677#issuecomment-720422628, but thinking more about it, maybe this should be a requirement on the user side to make their custom tooltip visible before returning it in _make_custom_tooltip?
For 3.2 I'm on the fence, but in master now that tooltips are windows, the custom tooltip passed to _make_custom_tooltip is actually added as child of a new TooltipPanel, which is the one that Viewport makes visible. So it's the user's responsibility to pass a visible Control that will be added as child to TooltipPanel if you want to see anything. (This brings new issues as you can't access the TooltipPanel created by Viewport to customize it, but that's a side issue.)
So in the end, maybe this just needs a note in the documentation of _make_custom_tooltip?

Yes, I think it is reasonable to ask of user to return a visible control. Also, it might be just my personal preference, but I tend to save the scene tree branches that I plan on instantiating as scenes, rather than storing them hidden in the containing scene. That way they are stored in the exact state I want them to appear when instantiated. If users prefer this workflow too, they wouldn't even come across this problem with returning invisible control.

Actually, I would go as far as to say that the _gui_show_tooltip() should display the popup control exactly as it is returned from the user-defined function, not even change its visible property. The only changes it should make to the returned control is add it to the scene tree and set its position to not "leak" out of the containing window. That way it doesn't make any unexpected changes to the popup properties. And if users return a control that is not visible, it would just not render anything - or in case of 4.0, it would render an empty TooltipPanel.
If I, as a user, find that my custom tooltip is not rendering, I'd find it easier to figure out that I made a mistake and returned an invisible control. If, instead, I get a tooltip but with a wrong position, I would assume I did everything right and there is a bug in the engine - after all, this was your case too.
It would be a whole different story if the _make_custom_tooltip didn't expect a whole new instance of popup control but a control that already exists in the scene tree and is just invisible. In that case, as a user, I'd expect the engine to manage some of the properties of that control, including showing it when hovered and hiding it when no longer hovered.

But in the end, this is not really a problem with the popup API, it is more deep-rooted problem with controls and minimum_size API as you pointed out. And it really does need some rework to make it work more predictably.


How to get preview mode working in multiple pods within Kubernetes?

Package
next-drupal (NPM package)
Ask the question
next-drupal: 2.0.0-alpha.0
Next.js: 14.1.0
Next module: 1.6.3
GraphQL module: 4.6.0
GraphQL Compose module: 2.0.0
We're hosting next-drupal projects in Lagoon and are having trouble when the projects are set to be high availability (more than 1 node service) for Next.js with next-drupal.
The behavior is as follows:

User edits a Drupal node in Drupal
User saves the node
User sometimes sees the preview (context.preview is true), but other times sees a 404 (context.preview is false)
Refreshing the page sometimes results in a working preview, but other times results in a 404 again

The behavior is random in that Drupal gets a response from a random node service pod.
So far what we have done is:

Set the Next build ID equal to the git hash of the deployment
Make the .next directory a persitant volume claim to be shared on all node pods
Turned off in-memory caching for Next.js via next.config
Implemented a Redis cache service to be shared between all node service pods

From what it says here on the next docs it looks like there's a cookie and private key that are generated on next build and that might not be shared between pods, but it's unclear if that's the issue.  There isn't much info about self-hosting Next.js.
In our page components that handle previews we have this:
	// This route is only visible as a preview for nodes.
	if (!context.preview) {
		console.log('TESTING PREVIEW NOT FOUND IN CONTEXT')
		return {
			notFound: true,
		};
	}

I'm able to confirm that when viewing logs when 2 node services are running, when the route resolves the preview correctly, we do not see that console log statement, but when we get a 404, we see the console log statement.
Here is what was implemented in the list above:
docker-compose.yml:
services:
  node:
    ...
    labels:
      lagoon.type: node-persistent
      lagoon.persistent: /app/apps/tb/.next/
    depends_on:
      - redis
    ...

next.config.js:
...
  cacheHandler:
    process.env.LAGOON_PROJECT === "projectname"
      ? require.resolve("./redis-cache-handler.js")
      : undefined,
  env: {
    NEXT_PUBLIC_REDIS_INSIGHT_URL: "redis:8001",
  },
  cacheMaxMemorySize: 0,
  generateBuildId: async() => {
    return process.env.LAGOON_GIT_SHA ? process.env.LAGOON_GIT_SHA : process.env.HOSTNAME
  },
...

redis-cache-handler.js:
const { IncrementalCache } = require("@neshca/cache-handler");
const createRedisCache = require("@neshca/cache-handler/redis-stack").default;
const createLruCache = require("@neshca/cache-handler/local-lru").default;
const { createClient } = require("redis");

const client = createClient({
	url: "redis://redis:6379",
});

client.on("error", (error) => {
	console.log("Redis error: ", error.message);
});

IncrementalCache.onCreation(async () => {
	// read more about TTL limitations https://caching-tools.github.io/next-shared-cache/configuration/ttl
	function useTtl(maxAge) {
		const evictionAge = maxAge * 1.5;

		return evictionAge;
	}

	await client.connect();

	const redisCache = await createRedisCache({
		client,
		useTtl,
	});

	const localCache = createLruCache({
		useTtl,
	});

	return {
		cache: [redisCache, localCache],
		// read more about useFileSystem limitations https://caching-tools.github.io/next-shared-cache/configuration/use-file-system
		useFileSystem: false,
	};
});

module.exports = IncrementalCache;

I'm wondering why clearPreviewData() is called at the top of the async preview function in client.ts. It seems that might actually pose some issues with session data needed for previews.

Per @JohnAlbin this isn't something next-drupal can address itself and is just the architecture of previews in Next.js.
The answer at the moment seems to be that sticky sessions are needed for the /api/preview and any path that would be previewed.


add example project

Codecov Report

Merging #409 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #409   +/-   ##
=======================================
  Coverage   90.63%   90.63%
=======================================
  Files          43       43
  Lines        2914     2914
=======================================
  Hits         2641     2641
  Misses        273      273

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e56762...548e7da. Read the comment docs.


Fix commit.Identity and add test

closes #1291

Codecov Report

Merging #1302 (f416a50) into master (80a0018) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1302      +/-   ##
==========================================
+ Coverage   47.14%   47.16%   +0.01%
==========================================
  Files         203      203
  Lines       15867    15867
==========================================
+ Hits         7481     7483       +2
+ Misses       7399     7397       -2
  Partials      987      987

Impacted Files
Coverage Δ

catalog/mvcc/cataloger_create_branch.go
81.53% <0.00%> (-3.08%)
:arrow_down:

catalog/mvcc/cataloger_create_repository.go
62.96% <0.00%> (ø)

pyramid/tier_fs.go
58.77% <0.00%> (+1.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a0018...f416a50. Read the comment docs.

Codecov Report

Merging #1302 (f416a50) into master (80a0018) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1302      +/-   ##
==========================================
+ Coverage   47.14%   47.16%   +0.01%
==========================================
  Files         203      203
  Lines       15867    15867
==========================================
+ Hits         7481     7483       +2
+ Misses       7399     7397       -2
  Partials      987      987

Impacted Files
Coverage Δ

catalog/mvcc/cataloger_create_branch.go
81.53% <0.00%> (-3.08%)
:arrow_down:

catalog/mvcc/cataloger_create_repository.go
62.96% <0.00%> (ø)

pyramid/tier_fs.go
58.77% <0.00%> (+1.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a0018...f416a50. Read the comment docs.


bash.exe -c "nohup winver.exe &" leaves init using 100% CPU on one core

Windows Version
Microsoft Windows [Version 10.0.19045.5131]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[ ] WSL 2
[x] WSL 1

Kernel Version
4.4.0-19041-Microsoft
Distro Version
Ubuntu 24.04.1 LTS
Other Software
No response
Repro Steps
If I open an ordinary Windows cmd prompt window (not WSL).  There run bash.exe -c "nohup winver.exe &" or wsl.exe -e bash -c "nohup winver.exe &".
Expected Behavior
WSL should run temporarily, starting winver.exe and then closing.
Actual Behavior
After WSL exits, an init process remains, using 100% CPU on one core. Even after winver.exe is closed, that init process remains, endlessly wasting CPU time like that. Every time this is repeated, another init process like this is created, each wasting CPU time.
Other than this, everything seems fine. I am returned to the cmd prompt immediately, and winver remains running.
If the nohup is not used, or the & is not used, then this problem does not occur.
Workaround: Using bash.exe -c "winver.exe &" gives more reasonable behaviour. The first run leaves behind two init processes, but they do not waste CPU time, and repeating it does not create more lingering init processes. Even though nohup is not used, winver remains running, probably because SIGHUP doesn't affect ordinary Windows processes. Another alternative that doesn't cause problems is bash.exe -c "winver.exe & disown"
Diagnostic Logs
No response

Thank you @dreamlayers. Interestingly I can't reproduce the issue. Could you share a coredump of the init process that's consuming CPU  ?

Here is a core dump generated via gcore from WSL1: hanging_init_core.gz.
This was soon after booting into Windows. The first time I did bash.exe -c "nohup winver.exe &", winver didn't run at all, and init wasn't consuming CPU afterwards. I waited for CPU activity to fall to single digits and then tried again and reproduced this. It seems like there is some race condition when running an ordinary Windows program from WSL1 and then immediately exiting WSL1.  When launching Windows programs that take a longer time to start up, I need a sleep 1 after the & to make them start successfully.


Remove "OpenShift Dedicated" from the messages that are common to both OSD and Rosa

There are a few templates here that specifically mention OpenShift dedicated when the message can be applicable to ROSA too. This PR is to generalise these templates so that they can be used for both product types.

/lgtm

/lgtm /approve


Add registry delete operation

Description
Adds a new registry operation - delete. This includes some manual swagger changes, since the swagger's listed response codes for the delete operation are wrong, and needed to be updated to include the actual return options. I included a couple other similar registry swagger corrections here as well. These changes are all manual fixes, not based on an official spec.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-ml


Start PVC-consumer pod with the right virt-v2v image (el8/el9)

See #215

we need the consumer on el9 (in the PR, we look for useEl9...).

@liranr23 right, that's no longer an issue after addressing this - it's a bit confusing though because we check UseEl9VirtV2v in EnsureDataVolumes and then in createPodToBindPVCs we use Settings.Migration.VirtV2vImageCold - because we know UseEl9VirtV2v returns true only for cold-migration to the local cluster.. how about trying to see how to make the code a bit more self-explanatory or at least add a comment that clarifies this in the current code?

added a comment in https://github.com/kubev2v/forklift/pull/242


Image only not triggering on-content-changed

Hi!
Seems as if creating a new editor and then uploading an image only without editing the text causes on-content-changed to not be triggered.
Steps:

Create a new directive for ng-quill with a on-content-changed callback, drop a console log in there for testing

Without typing or adding any input to the editor, click the upload image button and select an image

Notice no log (callback is not triggered)

could you check this if quill editor fires the "text-change" event ?
http://quilljs.com/docs/api/#text-change
Would be nice if you could create an editor without ng-quill --> simple quilljs
If quilljs itself does not trigger the text-change event. it is more a quilljs bug.
Let me know if you have time. If not i can check this this evening.
Thanks!

Would be much appreciated mate!

seems to be working:
http://codepen.io/KillerCodeMonkey/pen/xgLeoR
watch the false above the editor --> after inserting an image it switches to true and you get a console.log


Basic Data Update

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[x] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[x] I attest that the connector works and I verified by deploying and testing all the operations.
[x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

Hello @developmentLL
There is an issue in our validation checker, we are actively working on to resolve the same. We will approve your PR once it is resolved. Thank you for your patience and understanding.

Hello, whats the current status on this pull request? are there any chances that the pull request will be merged to Live?

Hello @developmentLL,
Please accept my sincere apology for delay, the swagger validation is failing due to pipeline issue, could you please close this PR and resubmit the PR?

Close due to pipeline issues

Hello @vmanoharas ,
i reopened the pull request. but there is still the same error.

@vmanoharas : New Pull request: https://github.com/microsoft/PowerPlatformConnectors/pull/3088/checks?check_run_id=18629766135