configlet lint warnings

At some point the configlet lint warnings will turn into errors.

practices items refer to something in the top-level concepts array
prerequisites items refer to an exercise in .exercises.concepts

I propose to move anything in a practices array into a topics key (currently unmonitored by configlet), and remove anything in a prerequisites array.
Would you like me to do the grunt work?

$ bin/configlet lint
The lint command is under development.
To check your track using the latest linting rules,
please regularly update configlet and re-run this command.

The following concepts exist in the `practices` array of a Practice Exercise in `/home/glennj/src/exercism/tracks/wren/config.json`, but do not exist in the top-level `concepts` array
strings
text-formatting
optional-values
lists
maps
enumeration
exceptions
numbers
loops
recursion
getters
fields
classes
sequences
operator-overloading
match
math

The Concept `strings` appears 20 times in the `practices` arrays of user-facing Practice Exercises, but can only appear at most 10 times:
/home/glennj/src/exercism/tracks/wren/config.json

The following concepts exist in the `prerequisites` array of a Practice Exercise in `/home/glennj/src/exercism/tracks/wren/config.json`, but are not in the `concepts` array of any user-facing Concept Exercise
classes
loops

The following concepts exist in the `prerequisites` array of a Practice Exercise in `/home/glennj/src/exercism/tracks/wren/config.json`, but do not exist in the top-level `concepts` array
classes
loops

Basic linting finished successfully:
- config.json exists and is valid JSON
- config.json has these valid fields:
    language, slug, active, blurb, version, status, online_editor, key_features, tags
- Every concept has the required .md files
- Every concept has a valid links.json file
- Every concept has a valid .meta/config.json file
- Every concept exercise has the required .md files
- Every concept exercise has a valid .meta/config.json file
- Every practice exercise has the required .md files
- Every practice exercise has a valid .meta/config.json file
- Required track docs are present
- Required shared exercise docs are present

Configlet produced at least one warning.
These warnings might become errors in a future configlet release.
For more information, please see the documentation:
https://exercism.org/docs/building/configlet/lint

This is (just) slightly above my head, but sounds right. @ErikSchierboom Does this sound right?  I think the problem is we have no concepts yet but we don't fully want to lose this meta-data - but we don't want linter to start yelling at us tomorrow.  Thoughts?

Yes, that sounds about right. I'd also like configlet to keep them as warnings for tracks that don't have concept exercises (like wren), so that would mean it would be okay to leave them as-is.

Awesome. So not sure this is needed at all then. @glennj

No, the problem is the wren track is using the practices and prerequisites keys incorrectly in config.json.

the problem is the wren track is using the practices and prerequisites keys incorrectly

Are we? Or are we using them prematurely?  Or is that a distinction without a difference to you?
What about adding the future_ prefix such as future_concepts, etc... would that solve the issue?

That's a good idea: will_practice, will_have_prerequisites

will_have_practice?


old version on conda-forge

Should this be getting updated on conda-forge?
I kind of liked being able to grab it from there....
-CHB

I submitted the latest version at https://github.com/conda-forge/conda-build-all-feedstock/pull/11.
Which platform are you seeing this on?

Just spotted some Windows failures in the CI. I have triggered a rebuild - let's see if that was the problem.

Is https://github.com/conda-forge/conda-build-all-feedstock/issues/12 solved?

Is conda-forge/conda-build-all-feedstock#12 solved?

Seems not. Latest version of conda-build-all only available for py34 on Windows @ChrisBarker-NOAA.

AARRGG! I didn't have the conda-forge channel set! Idiot!
Sorry for the noise, but maybe I helped you find a bug in Windows :-) (I was actually doing OS-X and Linux...)

but it does seem that the py27 Windows builds are missing, and I'm going to need that today :-)

but it does seem that the py27 Windows builds are missing, and I'm going to need that today :-)

Realistically, your best best is to clone the repo and build conda-build-all locally if it is needed for today.

looks like I didn't -- maybe today -- but sure I'm happy to work off the repo.

Looks like this is now available.


Cleanup of Rails 6.1 code

Follow on to #2789 and #2790, remove more code for now unsupported versions.

Released in 7.0.1


Error in Docker PHP

Keep getting this error. Are we relying on the right images?
E: Failed to fetch http://http.debian.net/debian/pool/main/e/expat/libexpat1_2.1.0-6+b3_amd64.deb  Error reading from server. Remote end closed connection [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://http.debian.net/debian/pool/main/l/less/less_458-3_amd64.deb  Error reading from server. Remote end closed connection [IP: <IP_ADDRESS> 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

Just rebuild all and don't have the problem

Do you still have the problem @pierrejoye  ?

Yes,  I will update to docker 1.6 and check again. If it fails, updating
tonjessie next week will surely make it :)
On Apr 24, 2015 7:04 PM, "Bruno CHALOPIN"<EMAIL_ADDRESS>wrote:

Do you still have the problem @pierrejoye https://github.com/pierrejoye
?
—
Reply to this email directly or view it on GitHub
https://github.com/FriendsOfPHP/pickleweb/issues/21#issuecomment-95911509
.

I just tried on macOSX and got :
Cannot start container a1efa1281c5a805ec70798d36a70cf5f484d7aab2eec64735e949d38fec0c73a: Cannot link to a non running container: /pickleweb_redis_1 AS /pickleweb_web_1/pickleweb_redis_1

Seems to be a write authorisation problem on data/redis

@JEDIBC I also have trouble on OSX with b2d : permissions on volumes shared with containers using custome users are wrong.
What I usually do is a good-old chmod -R 777 data/redis on host machine and it fixes the problem.

Unfortunately it isn't. It will fix the problem once you start the container for the first time but the next time it'll be unable to read form the file generated.

The initial bug is actually not a bug. It needs docker 1.6 and latest/recent docker-compose.
I also update the sample config.json to match the redis host name (redis, it uses the name of the container)


Allow keepNames esbuild config option

This PR allows for the keepNames esbuild option.
It also allows for some extensibility for future esbuild options this project might want to support.
Error message for using an invalid option:

Without keepNames
var RandomType = class RandomType2 {
};

With keepNames
var RandomType = /* @__PURE__ */ __name(class RandomType2 {
}, "RandomType");

This fixes an issue I have been having with using the @anatine/esbuild-decorators plugin to use "emitDecoratorMetadata": true in my tsconfig. Prior to this, my type-graphql types were coming back as:

but with keepNames:

@KinnersleyM thanks for the PR - it looks good! There's a conflict that needs to be resolved but I'll merge it after then

@thdxr Thank you! Just rebased now 👍

Thanks @KinnersleyM, will take a look at it today!

@KinnersleyM with v0.34.7, you can now configure keepNames inline like this:
  bundle: {
    esbuildConfig: {
      keepNames: true,
    },
  },

Let me know if that makes sense.


Show news about ongoing campaigns/competitions

Suggested by John Cummings at https://commons.wikimedia.org/wiki/Commons:Village_pump#IEG_proposal:_Improve_Upload_to_Commons_Android_app

@Misaochan:, this has a very large potential to increase participation. I wanted ask a question that is outside the current grant request but is related. I know that there has been some previous work on a Wiki Loves Monuments app and could see a clear use for a similar app for Wiki Loves Earth. I don't understand the technical side of Wiki Loves Monuments and Wiki Loves Earth but I can see having an app may help increase the easy of participation for people. Would there be an easy mechanism to have a link somewhere in the front page of the app to contribute to the competitions? I think there are a few advantages of integrating the competitions into a central app rather than having an app for each competition:
If people install the app for the competition it means they can continue to contribute to Wikimedia Commons after the competition has finished
May encourage people to take part in multiple competitions, inccreasing the participation for all of them. E.g someone installs the app for WLE and then continues to add photos afterwards and the app makes them aware that WLM is happening.
Smaller competitions can have contributions by an app without needing to create their own.
Thanks
John Cummings (talk) 13:52, 4 March 2016 (UTC)

How about a small "advertisement" that would show up only during such events, and presumably a week or so before.
Implementation could be as simple as loading a text file from a hard-coded URL like https://www.mediawiki.org/wiki/Wikimedia_Apps/Commons/Ad (that page would need to be ultra-protected obviously) and ignoring when the page is blank. Loading would need to be asynchronous to not impact app startup speed too much.

Ahh, is that the Campaigns code that we removed previously due to it being unused? That explains a lot. :)
I like the idea of the ad for other WM campaigns. Who would maintain the URL that switches the ads around though? Or is it already done automatically?

Maintainance would be done manually by the community at https://www.mediawiki.org/wiki/Wikimedia_Apps/Commons/Ad

Ideally we could have some kind of plug-in structure. For example a GeoJSON with the location, description etc.. and also the name of the campaign, start date, end date, custom categories. Ideally a user could create a campaign from query.wikidata.org which will also be able to query commons soon (once Wikidata for Commons goes online).
Something like Wiki loves monuments or Wiki loves earth is probably not more than a few lines of sparql to get the desired items. Non location based campaigns query for certain categories or create the JSON manually. If no locations are provided no map is shows, but a list. Gamification would be possible if points (stars, etc..) are assigned to the items.

Indeed.
Would you mind designing the ads for two campaigns that have actually happened? And design the JSON that would define each of these campaigns. Agreeing on a solid format is a requirement before we start coding.

@tobias47n9e: This issue is only about the ads (news), so your paragraph about SPARQL probably belongs to https://github.com/commons-app/apps-android-commons/issues/100
Cheers! :-)

We could load the JSON file from a hard-coded URL like http://commons-app.github.io/campaigns.json
I now see the point of having SPARQL in this file too.
To summarize, the JSON file could contain for each ongoing campaign:

Name of the campaign
Area where the campaign takes place
Start/end date of the campaign
Explanation text
Categories to add to categories suggestions
SPARQL request for nearby campaign-related items

As discussed with the team am assigning this task to @ashishkumar468. I would be picking up #604 instead.
cc @misaochan

Can someone help me with the api's for the same. Also, I was hoping if the right place for it would be the nav drawer ?

@VojtechDostal @nicolas-raoul @whym Would appreciate insight on which API we should use for this?
@ashishkumar468 For the UI, the eventual plan is for it to be on the main screen. But depending on the output of the API, for the time being the nav drawer or even a separate "News" activity could work.

@nicolas-raoul @VojtechDostal @urbanecm Any ideas on what API we could use? I will try to ask on wikitech-l or the village pump soon if no one here knows. :)

Not sure I fully understand the question. What data you want to access in the app?

The exact data that we will display is somewhat flexible, but we at least need to be able to check (1) dates that the campaigns are running and (2) names of these campaigns.

What is a campaign in this context?

I think we can just start with the international WLE and WLM campaigns for now, but for a future enhancement could include the country-specific ones?

I wonder if such campaigns are stored in some app. If not, it's hard to recommend an API.

Hmm, I guess if an API doesn't exist, we can just go with the manual maintenance and loading of a text file as mentioned at https://github.com/commons-app/apps-android-commons/issues/78#issuecomment-193065060 . IMO this would be less-than-ideal due to the maintenance required, but if it is only WLM and WLE, maintenance would be required only once a year (and even then only if WMF changes their plans, AFAIK those have fixed dates every year?).

If you decide to maintain the list of campaigns in a TXT file, I think this file should not be stored in app, but somehow publicly available on web. This will make changes simplier, because you won't have to wait for users to update the app.

Campaign in this context is page in the Campaign namespace on Wikimedia Commons.
https://commons.wikimedia.org/wiki/Commons:Upload_campaigns

Apparently there is no active campaign right now?
Here is how that page looked when a campaign was active: https://commons.wikimedia.org/w/index.php?title=Commons:Upload_campaigns&oldid=101495150
Seeing the page's history, it does not seem to be maintained carefully. So we would have someone make sure it is kept up-to-date every month or so. Also, we would have to add a few columns, at least start/end time, name+explanation (localized?), ideally location, maybe also a SPARQL query for Nearby.
Not sure which is better:

Use and extend that page, potentially benefit from the community's maintenance, and possibly face breaking changes from time to time.
Or start a JSON file from scratch at an URL like http://commons-app.github.io/campaigns.json which would have to be 100% maintained by us.

Here are more photo scavenging events, albeit very unstructured: https://commons.wikimedia.org/wiki/Category:Photo_scavenger_hunts
Keeping track of all competitions might take more time than we can afford.

That table seems manually updated but it seems like people periodically update campaigns like this one: https://commons.wikimedia.org/w/index.php?title=Campaign:wlm-cz&action=edit

I did not know about that namespace, interesting!
Unfortunately it does not seem to have time information, for instance https://commons.wikimedia.org/w/index.php?title=Campaign:FLISoL2017&action=edit is still marked as active.
And there are hundreds: https://commons.wikimedia.org/w/index.php?title=Special:PrefixIndex&namespace=460 so we can not just show all campaigns.

The problem is that the campaign you linked is still officially marked as active and if you use an URL referencing this campaign, it will just work.
Maybe we should get Commons administrators and/or campaign admins to disable a campaign when it is no longer necessary, so we can use it in this app?
Alternatively, we can display x newest campaigns, which can display some out of date campaigns and also not display some campaigns that should be displayed. I think the previous solution is better.

Thanks guys! :)
To clarify, I don't think we want to display a list of campaigns to the user per se. IMO for our current prototype, we would only display active campaigns, with a line like: "This campaign (e.g. WLM) is currently running from Oct 1 - Oct 31! Tap to see more information", and when tapped, the user would be brought to the campaign page.
We also probably don't want to display photo scavenger hunts at the moment, and indeed IMO we want to limit ourselves to the major campaigns. Not just for our own sake (i.e. maintenance), but also because I think users would become desensitized. If they see lots of campaigns active all the time, most users would just ignore them entirely, then the impact would be lost.
It seems like the last edit tohttps://commons.wikimedia.org/w/index.php?title=Commons:Upload_campaigns&oldid=101495150 was in 2013? In that case I'm not sure we would get any help from the community even if we use that page, lol. Perhaps the publicly-available JSON or TXT file maintained by us would be the better solution. If we restrict ourselves to major campaigns, I don't think we would need to maintain it more often than 1-2 times a year?

The campaigns pages themselves do not contain any information about time. If we need info about time, I think there's no other solution than maintaining publicly available JSON file.

So, I'm working on getting the base information up so that @ashishkumar468 can get started on the JSON file and the task itself.
I have the campaigns below at the moment, please feel free to correct/add:
Wiki Loves Monuments, 1-30 Sep, https://www.wikilovesmonuments.org/contest/
Wiki Loves Earth, 1 May - 30 June (unfortunately it seems that it differs slightly based on country?), http://wikilovesearth.org/
What else? WikiLovesPride seems to have a fixed date every year, but seems fairly small. WikiMuseum?

The problem is that the campaign you linked is still officially marked as active and if you use an URL referencing this campaign, it will just work.
Maybe we should get Commons administrators and/or campaign admins to disable a campaign when it is no longer necessary, so we can use it in this app?

This is by design. Upload campaigns have this dual-use − for campaign-as-contest, and as an upload helper. That’s why folks are encouraged to use WLM campaigns even when WLM is not running, as they get fields pre-filled with the monument ID etc. These campaigns are expected to be enabled all year long. (At least for WLM, we rely on {{WLM-is-running}} and manual updates to sort out what really belongs in the campaign-as-contest.)
Couple of other notes:

campaigns are usually aligned on local-time (from midnight to midnight)
there are always exceptions − for example this year, Ireland started WLM on Aug 24, Israel finishes on October 10 (not that this level of detail necessarily matters much for the commons app use case)

(I’m part of the WLM international team, and an avid Campaign creator/user :-)

Thanks for the input! :) Unfortunately I still can't find a way for our app to retrieve specific start and end dates from that namespace. :( As I talked about with @VojtechDostal today, perhaps we could stick to the JSON file for now as time is running short for this task. In the future, especially if a more suitable API is built upstream, we can change our approach.
@ashishkumar468 can you please create the JSON file in our repo with the information below? Then anyone can modify it or add more.
Wiki Loves Monuments, 1-30 Sep, https://www.wikilovesmonuments.org/contest/
Wiki Loves Earth, 1 May - 30 June (unfortunately it seems that it differs slightly based on country?), http://wikilovesearth.org/

I created a new repository, so that we can give reviewer right to people who are not Android developers.
In the future we can even give this repository to another organization, as maintaining this list is not our core mission.
https://github.com/commons-app/campaigns
https://raw.githubusercontent.com/commons-app/campaigns/master/campaigns.json

@nicolas-raoul thanks for creating the repo. :)
I was thinking about the JSON structure and here are a few things that we should consider:
{
    "config": {
        "showOnlyLiveCampaigns": true/false,
        "sortBy": "title/startDate/endDate"
    }
    "campaigns": [
        {
            "title": "Wiki Loves Monuments",
            "description": "Wiki Loves Monuments",
            "startDate": "2018-09-01",
            "endDate": "2018-12-01",
            "link": "https://www.wikilovesmonuments.org/contest/"
        },
        {
            "title": "Wiki Loves Earth",
            "description": "Wiki Loves Earth",
            "startDate": "2018-09-01",
            "endDate": "2018-12-01",
            "link": "https://www.wikilovesmonuments.org/contest/"
        }
    ]
}

Am just proposing a suggestion for campaign config. We can have it implemented in the client at a later stage. :)

showOnlyLiveCampaigns can help the app decide if only live campaign needs to be shown or all campaigns should be shown. As of now, we should show all campaigns but once our JSON has more items, we can decide to show only live ones.
sortBy to decide which campaign to be shown on top.

Thanks @maskaravivek  This seems to cover all the possible cases (at least those I could think of). If all of us agree, I can proceed with this api contract

@ashishkumar0207 I updated the JSON file with Vivek's additions, so feel free to make the app download it from GitHub (URL above) and parse it :-)

Thanks @nicolas-raoul . I am on it :-)

Oops, I hadn't noticed that the repo already had a JSON. @nicolas-raoul Thanks for adding the updated JSON to the repo.
@ashishkumar468 You might have to update the JSON file to fix the values based on @misaochan's comment. I had just posted a sample. :)

Thanks @maskaravivek , will do the same

Question: Is there a plan to make the news about the Campaigns country-aware or is that out of scope for this task?

@JeanFred Does not seems something difficult to implement, although it would add complexity in maintenance of the json, IMO, can be taken as an improvement, what do others say?

@JeanFred Does not seems something difficult to implement, although it would add complexity in maintenance of the json, IMO, can be taken as an improvement later on, what do others say?

Agreed. I think it makes a lot of sense to keep the first iteration simple and not making it country-aware ; but also to keep that in mind for the future as a very desirable improvement: people in Country X might be confused that they get WLM advertised if there is no WLM running in their country. For WLM and WLE it is probably not too bad, because they happen in lots of countries ; but I can see that competitions with smaller scope (for example, there were quite some Wiki loves X happening in India) would be keen to also get their campaigns surfaced in the app :)

I am in favor of keeping countries for a second phase because it is not trivial:

Some users do not allow the app to use the GPS.
As far as I know, there is no open source library to guess a country from a location.
Some competitions might cover Benelux (three countries that very often act as a single one) or Alaska (not a country), adding to the complexity.

This might be out of the scope of the task but for the sake of discussion, we can support country-level campaigns with 2 additional attributes.
{
    "config": {
        "showOnlyLiveCampaigns": true/false,
        "sortBy": "title/startDate/endDate"
    }
    "campaigns": [
        {
            "title": "Wiki Loves Monuments",
            "description": "Wiki Loves Monuments",
            "startDate": "2018-09-01",
            "endDate": "2018-12-01",
            "link": "https://www.wikilovesmonuments.org/contest/",
            "global": false,
            "country": "India"
        },
        {
            "title": "Wiki Loves Earth",
            "description": "Wiki Loves Earth",
            "startDate": "2018-09-01",
            "endDate": "2018-12-01",
            "link": "https://www.wikilovesmonuments.org/contest/",
            "global": true
        }
    ]
}

if global is true then the campaign would be visible in all countries.
if global is not set as true then the campaign would be visible only in the country.

Some users do not allow the app to use the GPS.
As far as I know, there is no open source library to guess a country from a location (nor from the Android system itself).

Users who do not allow GPS/location access can be shown only global campaigns. Others can see global + country campaigns.

Some competitions might cover Benelux (three countries that very often act as a single one) or Alaska (not a country), adding to the complexity.

The campaign file would contain a corresponding entry for each country. The user would be shown only one of these items based on his country.

Assuming GPS is never available, we can have a country drop-down list where the user can select the country for which they want to see the campaigns. Some users might be planning a trip ahead and might want to see campaigns in another country.
Our JSON file won't grow to unmanageable limits as of now but later we can introduce a middle layer so that the app doesn't consume the JSON directly. The client can send country, language, global etc as params.

Thanks for creating the new repo! I agree that country-specific support would be wonderful, but it would be best to do it as a future enhancement.
Now that we have a rudimentary backend sorted, we need to consider the UI. Do we want this in the nav drawer, or the main screen, or do we want a separate News activity? IMO the news activity would probably be easiest for the time being, and would allow us to tidy up the initial iteration based on user feedback before it is placed in a more prominent location. @neslihanturan

@misaochan  yes, a separate activity which could be opened from the navigation menu

At first I thought the most obvious would be to display a red notification. But then I realized that I hate receiving Facebook notifications that are about something not directly related to me (such as a message to me or an event about one of my pictures), so that is probably not a good idea. Showing non-important notifications might lead users to just ignore notifications, and thus not see important ones such as someone asking them about the copyright status of a picture.
How about showing each campaign:

At the first day of the campaign, on the app's home activity, instead of the Nearby notification. The app should remember (in the local database) whether it has displayed that campaign to the user or not yet, for instance if the user does not open the app for two days then the campaign should be shown during the third day. After that campaign-showing day is over, when the app is opened, do not show it anymore, just show the normal Nearby notification, or just nothing if Display nearby notification is off.
In the Notifications activity's list, but without triggering the red "new notification" signal.

Note: I wrote "first day of the campaign", but we might prefer "one week before the start of the campaign" or "one week before AND the first day AND at the middle of the campaign" or anything similar, with for each a shown-or-not-yet record in database.

@nicolas-raoul Hmmm. That sounds a little bit complicated to me. ;) If we are going to have it in the main activity, I think it should be OK to just have the campaign news as an additional card underneath the Nearby card? It can stay up for the duration of the campaign as long as it can be swiped to be dismissed, and we remember the user's preference. It does have to be reasonably small in height so that it doesn't take up too much of the screen.

@nicolas-raoul So to conclude to what you want

Apart from showing the campaigns in the notification activity, we show it in the HomeActivity as well, under the contributions tab above the contribution (the visibility of a contribution being based on its age)

I don't know any ongoing campaign unfortunately, but we can fake it until
before release.
On Thu, Dec 13, 2018, 23:25 Ashish Kumar<EMAIL_ADDRESS>wrote:

@nicolas-raoul https://github.com/nicolas-raoul If there are any live
campaigns going on, can you please add one of them in the repo mentioned,
would be really helpful in testing with the actual api's, currently I am
using a fork of your repository for the same
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/78#issuecomment-446986491,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGFBnBLEZcLo26a3EL8wcCjiyHu76QRks5u4mNwgaJpZM4HqKq2
.

Umm, wouldn't it work if you just changed the date in the emulator?

BTW, how do we handle recurring dates? Currently the year is hardcoded in the JSON file. Is there a way for us to specify the date and month, but have it applicable for every year?

Reopening as we still need to sort out the recurring dates before we release this. We can just make them 2019 if we have to, and change them every year, but that would really not be ideal.

Hard-coding the next 10 years is probably simpler, and chances are low that
any campaign will keep the same dates for 10 years, I would say.
On Sat, Dec 15, 2018, 01:56 Josephine Lim<EMAIL_ADDRESS>wrote:

Reopened #78
https://github.com/commons-app/apps-android-commons/issues/78.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/78#event-2027313535,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGFBnlUpfxMZBSC5oEGqQMS_gQrwuliks5u49hbgaJpZM4HqKq2
.

@nicolas-raoul Ah, good point. Should we just add 2019 and 2020 to the JSON file now, then?

I've added 2019 to the JSON file and fixed the dates etc. If anyone could double check the file, that would be fantastic, but everything appears to be in good working order otherwise. :)


Prefer context over locate

https://github.com/Dherse/codly/blob/88d90dca71e62a81bab019f540fd94f7ee3d5303/codly.typ#L228

This is the case as of 6e4a60f


About those features. I can't access the support forum, since it is been passing through some heavy load. So?

How to access these other features made by you on steamdb game page and all this says is Feature disabled for now. Sorry? Where can i reach you out?
TIA.

https://cs.rin.ru/forum/viewtopic.php?p=2452810#p2452810


fix(sqllab): Disable Select All on table selector

SUMMARY
After https://github.com/apache/superset/pull/22084 merged, all SyncSelect has "Select All" option including a database selector.  This change easily hits the tens (and can be thousands) of table preview fetches since the option triggers the preview request.
This commit disables the "Select All" option for TableSelector to resolve the issue.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:

Before:

TESTING INSTRUCTIONS
Go to SQLLab and verify that no options for "Select All" in table selector
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Not sure if this just happened very, very fast or we both coincidentally spotted the same thing but I was just coming here to raise this PR after raising a discussion about it yesterday: https://github.com/apache/superset/discussions/24115. Thanks for fixing this.


Can't locate ExtUtils/PL2Bat.pm

When using<EMAIL_ADDRESS>to install Perl on windows,
I noticed that when using cpm via perl-actions/install-with-cpm I got the issue
Can't locate ExtUtils/PL2Bat.pm in @INC (you may need to install the ExtUtils::PL2Bat module)
I'm not sure who to blame here and if it's a cpm bug or actions-setup-perl one?
Switching to perl-actions/install-with-cpamm fixed the issue for me lol
more details: https://github.com/atoomic/Clone/runs/656823399?check_suite_focus=true
Run<EMAIL_ADDRESS>C:\hostedtoolcache\windows\perl\5.30.2\x64\bin\perl.exe -MConfig -e "print \"$Config{installsitescript}/cpm\""
/cpm::set-output name=Get cpm from https%3A//raw.githubusercontent.com/skaji/cpm/master/cpm::
install_to d:\cpm
install: B::COW!
do_exec: C:\hostedtoolcache\windows\perl\5.30.2\x64\bin\perl.exe
C:\hostedtoolcache\windows\perl\5.30.2\x64\bin\perl.exe d:\cpm install --show-build-log-on-failure -v --no-test -g B::COW
##[error]Can't locate ExtUtils/PL2Bat.pm in @INC (you may need to install the ExtUtils::PL2Bat module) (@INC contains: FatPacked::13938184=HASH(0xd4ae08) C:/hostedtoolcache/windows/perl/5.30.2/x64/site/lib C:/hostedtoolcache/windows/perl/5.30.2/x64/lib) at d:\cpm line 599.
##[error]BEGIN failed--compilation aborted at d:\cpm line 599.
##[error]Compilation failed in require at d:\cpm line 587.
##[error]BEGIN failed--compilation aborted at d:\cpm line 587.
##[error]Compilation failed in require at d:\cpm line 858.
##[error]BEGIN failed--compilation aborted at d:\cpm line 858.
##[error]Compilation failed in require at d:\cpm line 387.
##[error]BEGIN failed--compilation aborted at d:\cpm line 387.
##[error]Compilation failed in require at d:\cpm line 383.
##[error]BEGIN failed--compilation aborted at d:\cpm line 383.
##[error]Compilation failed in require at d:\cpm line 379.
##[error]BEGIN failed--compilation aborted at d:\cpm line 379.
##[error]Compilation failed in require at d:\cpm line 299.
##[error]BEGIN failed--compilation aborted at d:\cpm line 299.
##[error]Compilation failed in require at d:\cpm line 1487.
##[error]BEGIN failed--compilation aborted at d:\cpm line 1487.
##[error]The process 'C:\hostedtoolcache\windows\perl\5.30.2\x64\bin\perl.exe' failed with exit code 2

Note: this was also reported to cpm as https://github.com/skaji/cpm/issues/173

ref. https://github.com/skaji/cpm/issues/173#issuecomment-625899847
Please try again with cpm v0.992.
Feel free to reopen if the problem is not fixed.


Missing documentation on how to use Keptn Quality Gates

While the documentation on https://keptn.sh/docs list the concept of Keptn Quality Gates as well as the structure of SLI and SLO files, details on how to actually set up a quality gate and how to trigger the evaluation are missing.
Would be great to have detailed information on:

what is needed to set up a quality gate with Keptn
how to integrate a quality gate in an existing pipeline
how to trigger a quality gate with the Keptn CLI
how to get the evaluation of a quality gate with the Keptn CLI
how to trigger a quality gate with the Keptn API
how to get the evaluation of a quality gate with the Keptn API

Thanks for creating it. Without looking at your issue, I created the same issue too.
Let me close that one with a reference to the issue here: https://github.com/keptn/keptn.github.io/issues/636


gene expression trends line plots grouped by sample conditions

...
Hi, I would like to visualize the gene expression trends of a particular lineage between different sample conditions. Is it possible to do it using cr.pl.gene_trends function? Or is there a workaround ? What I can think of is to build the GAMR model for each sample conditions, but I am not sure how to integrate all the line plots in one figure. Thanks!

Good question, I don't think we currently support covariates in gene trend plotting (or anywhere in CellRank, to be honest). That's something to think about for the future.


Make the Turi Create API more Pythonic and General Purpose.

Hello,
I'm a developer that writes machine learning software for end users to consume. My use case is running Turi Create on production server environments, not Jupyter notebooks or laptops.
Here are a few suggestions for how to make Turi Create more of a general purpose ML Python package that works well for ALL runtime environments.
SFrame Input Data
In Python, a very idiomatic way of representing a table is a list of dictionaries like so:
[
 {'name': 'Michael', 'age': 28},
 {'name': 'Emma', 'age': 33}
]

This format is very intuitive and so common that the CSV module in the standard library has first-class support for it using the DictReader and DictWriter classes. Unfortunately, the TuriCreate SFrame API does not support this input style, the options supported are:

A csv file, which assumes the runtime environment has access to the local file system.
An sframe directory archive which is Turi Specific.
A general text file which assumes the runtime environment has access to the local filesystem.
A Python dictionary which is suitable for representing a single row of a table, not the entire table.
A pandas.DataFrame.
A "JSON" string of some kind (There are no details as to what the data structure shape should be)

These formats are fine casual data exploration, but what about production environments where there are hundreds of application servers running Turi and input data is coming from Celery tasks (primitive Python data types)?
Make Python objects a first class citizen.
While reading the documentation, I find a constant theme:

The Recommender Docs. The example calls read_csv('./dataset/ml-20m/ratings.csv') which assumes Turi is run on a laptop or some kind of development environment.
The Image Classification Docs: The example calls tc.image_analysis.load_images('PetImages', with_path=True) which assume a local directory called Pet images exists on the file system.
The list goes on...

Instead, it would be better:

Do not assume the runtime environment.
Default to Python objects (list of dictionaries for recommendation, list of image urls for image classification).
Let the user be in charge of serializing the data to an alternate format input format.

Basically Turi Create should be in charge of machine learning, YOU, the developer are in charge of serialization to your favorite format.
Make  __str__ and __repr___ default to a more common style, not massive tables.
Currently when you run
train_data = tc.SFrame(data=data, format='array')

A massive amount of output is printed to stdout by default. This output is definitely useful in a read eval print loop, but in a production environment, it adds tons of noise to the logs.
Support for exporting to Core ML as bytes data
It would be nice to have an export option that returns bytes, which we can either write to the local file system or upload directly to S3. Let the developer decide what to do with the raw data instead of deciding for us.

Thanks for your response @hoytak. This is very helpful!


Added information about Hacktoberfest.

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

We cannot add this since we have already seen someone request going excluded due to same update. Try to contribute quality projects


Fixed some dorado driver bugs

What this PR does / why we need it:

Fixed  dorado replication ReplicationPeriod UNITE issue.
Fixed dorado create volume always in pool 0 issue.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

Coverage decreased (-0.01%) to 43.848% when pulling 9ddd5df39c672c0ba43c431218e45b90175ce150 on xxwjj:dorado_bugs into af3840fdd4c57127840959e62808fa92c3556765 on opensds:development.


Fix imagery request render

Fixes #6193
invalidateAllTiles was not being called reliably at the correct time.

@ggetz, thanks for the pull request! Maintainers, we have a signed CLA from @ggetz, so you can review this at any time.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

@ggetz I'm seeing a crash if I alternate between Enable terrain and Disable terrain in the example I pasted in #6193
DeveloperError: requestTileGeometry must not be called before the terrain provider is ready.
Error
    at new DeveloperError (http://localhost:8080/Source/Core/DeveloperError.js:43:19)
    at CesiumTerrainProvider.requestTileGeometry (http://localhost:8080/Source/Core/CesiumTerrainProvider.js:569:19)
    at doRequest (http://localhost:8080/Source/Scene/TileTerrain.js:149:48)
    at requestTileGeometry (http://localhost:8080/Source/Scene/TileTerrain.js:163:9)
    at TileTerrain.processLoadStateMachine (http://localhost:8080/Source/Scene/TileTerrain.js:97:13)
    at processTerrainStateMachine (http://localhost:8080/Source/Scene/GlobeSurfaceTile.js:384:20)
    at Function.GlobeSurfaceTile.processStateMachine (http://localhost:8080/Source/Scene/GlobeSurfaceTile.js:281:13)
    at GlobeSurfaceTileProvider.loadTile (http://localhost:8080/Source/Scene/GlobeSurfaceTileProvider.js:505:26)
    at processSinglePriorityLoadQueue (http://localhost:8080/Source/Scene/QuadtreePrimitive.js:768:26)
    at processTileLoadQueue (http://localhost:8080/Source/Scene/QuadtreePrimitive.js:759:9)

I'm also still seeing a problem where sometimes the tiles don't load in if I zoom in and click the Disable terrain button.  The tiles start loading when I move the camera.

Just a reminder not to forget about this for next release, I've hit it several times today.

@hpinkos I believe this is resolved. I moved the invalidate logic to right before we process the tile load queue. I am no longer seeing any errors when switching back and forth, and repeatedly clicking disable terrain always reload the globe.

@ggetz, not sure if this is the same bug but I still see this in this branch:

Start Cesium Viewer: http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/fix-imagery-requestRender/Build/Apps/CesiumViewer/index.html
Switch to Ellipsoid via Base Layer Picker (nothing will update until you move the mouse)

@mramato That's a regression because of the changes here. Fixed and added a new spec. @hpinkos in your sample code, you should no longer need to request a render after setting the terrain provider.

@ggetz I'm still seeing issues here.  If I double click the Disable terrain button, I can still get a globe with no tiles.  It doesn't happen as consistently, but I can still reproduce it within a few tries.

@hpinkos I don't think I can reproduce.
The first time I hit disable terrain, it takes a second or two for the new terrain provider to load in, but will re-render without mouse input. That's the same behavior as when we are not in requestRender mode.
If you comment out
viewer.terrainProvider = cesiumTerrainProviderMeshes; in your example, disbaleTerrain doesn't cause that initial delay since it was initially loaded with the EllipsoidTerrainProvider

@ggetz I can show you when you're in the office

@ggetz I just merged master and pushed it to your branch

Looks like this fixed the issue!  Thanks @ggetz
@bagnell can you please review the Globe and QuadtreePrimitive changes?

@hpinkos @ggetz This looks good to me.

Thanks @bagnell! @hpinkos tests are cleaned up as well now.

Thanks @ggetz!


Notebooks does not separate examples

Many blocks of code are not represented well in the notebooks, e.g.
1 + 2       # adding integers

1.0 + 2.0   # adding floats

2 / 4       # standard division

div(2, 4)   # Computes 2/4 truncated to an integer

35 \ 7      # inverse division

1 // 3      # fractions

1//2 + 1//4

'c'        # characters (unicode)

:symbol    # symbols, mostly used for macros

is in a single cell, hence it only prints the last command. This is not didactic. Either every line should be split in a separate code block in the .jmd file or there is some Weave command to do this?
Should be solved for

[ ] basics
[ ] collections
[ ] types
[ ] CA
[ ] error prop

Ik doe het op maandag je mag mij assignen heb mijn laptop niet mee dit
weekend
Op za 14 dec. 2019 om 12:53 schreef Michiel Stock<EMAIL_ADDRESS>
Many blocks of code are not represented well in the notebooks, e.g.
1 + 2       # adding integers
1.0 + 2.0   # adding floats
2 / 4       # standard division
div(2, 4)   # Computes 2/4 truncated to an integer
35 \ 7      # inverse division
1 // 3      # fractions
1//2 + 1//4
'c'        # characters (unicode)
:symbol    # symbols, mostly used for macros
is in a single cell, hence it only prints the last command. This is not
didactic. Either every line should be split in a separate code block in the
.jmd file or there is some Weave command to do this?
Should be solved for

basics
collections
types
CA
error prop

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MichielStock/Julia925/issues/25?email_source=notifications&email_token=ACYUUXAIBMOXF47O3VRCNBLQYTCNHA5CNFSM4J22GTMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IAPYUNA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYUUXGSBTEJF5IN2JWJ5NDQYTCNHANCNFSM4J22GTMA
.

Related, in collections @Beramos uses @show a lot (to circumvent this problem). I don't find this good practice. Remove this and split the blocks (if no weave command is found).

Parking this idea for now

@Michiel this was fixed with term=true in #26, right?

Nope, you have to split the code blocks manually.
term=true solves it for pdf, not notebooks

On 16 Dec 2019, at 12:53, BramDeJaegher<EMAIL_ADDRESS>wrote:
@michiel https://github.com/michiel this was fixed with term=true in #26 https://github.com/MichielStock/Julia925/pull/26, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/MichielStock/Julia925/issues/25?email_source=notifications&email_token=ABN5PI7UJ5KZMW5DX45F6RTQY5T5FA5CNFSM4J22GTMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG6O6NI#issuecomment-566030133, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABN5PI5FBEGCYDWITWYGTVTQY5T5FANCNFSM4J22GTMA.


updating Users and perms on QUERIES.md

LGTM, :ship:

@gunnaraasen can you check latest comment for a +1?

This looks good.
Not specific to these changes, but the GRANT ALL PRIVILEGES statement doesn't work (#2872).


UnboundLocalError: local variable 'display' referenced before assignment

Description of your problem
When executing this extremely short code, spyder hangs.
What steps will reproduce the problem?
[This could be a contest for shortest bug report.]
Here is the program:

Str = '\x8c'
print(Str)

I then set a breakpoint on line 2 (print line).
I then click "Debug file" button
What is the expected output? What do you see instead?
Spyder hangs!
Please provide any additional information below
By killing the python process which runs this code, spyder console shows:
continue

/home/user/Documents/bug_spyder.py(1)()
-> Str = '\x8c'
(Pdb) > /home/user/Documents/bug_spyder.py(2)()
-> print(Str)
(Pdb) Exception in thread Thread-1:
Traceback (most recent call last):
File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
self.run()
File "/usr/lib/python2.7/dist-packages/spyderlib/widgets/externalshell/monitor.py", line 569, in run
self.update_remote_view()
File "/usr/lib/python2.7/dist-packages/spyderlib/widgets/externalshell/monitor.py", line 450, in update_remote_view
remote_view = make_remote_view(ns, settings, more_excluded_names)
File "/usr/lib/python2.7/dist-packages/spyderlib/widgets/externalshell/monitor.py", line 79, in make_remote_view
minmax=settings['minmax'])
File "/usr/lib/python2.7/dist-packages/spyderlib/widgets/dicteditorutils.py", line 225, in value_to_display
return display
UnboundLocalError: local variable 'display' referenced before assignment

Versions and main components

Spyder Version: Spyder 2.3.8
Python Version: Python 2.7.11+ 64bits
Operating system: Ubuntu 16.04

This issue is not present with spyder3. I only see it with spyder(2).
Dependencies
Please go to the menu entry Help > Optional Dependencies (or
Help > Dependencies), press the button Copy to clipboard
and paste the contents below:
IPython >=1.0      :  2.4.1 (OK)
jedi >=0.8.1;<0.9.0:  0.9.0 (NOK)
matplotlib >=1.0   :  1.5.1 (OK)
pandas >=0.13.1    :  0.17.1 (OK)
pep8 >=0.6         :  None (NOK)
psutil >=0.3       :  3.4.2 (OK)
pyflakes >=0.5.0   :  1.1.0 (OK)
pygments >=1.6     :  2.1 (OK)
pylint >=0.25      :  1.5.2 (OK)
rope >=0.9.2       :  0.10.2 (OK)
sphinx >=0.6.6     :  1.3.6 (OK)
sympy >=0.7.3      :  None (NOK)
zmq >=2.1.11       :  15.2.0 (OK)

I have found a workaround to avoid spyder from hanging:
       elif is_binary_string(value):
            try:
                display = to_text_string(value, 'utf8')
            except:
                pass

The pass may be replaced by:
               display = "<error>"

I think this was fixed in Spyder 2.3.9. Could you update and try again?

Definitely fixed in 2.3.9, with code very similar to what you proposed:
https://github.com/spyder-ide/spyder/blob/2.3/spyderlib/widgets/dicteditorutils.py#L209


Potential issue in Getting Started.ipynb > Metrics & evaluation > "format_labels"

Hello!
I am wondering if the "format_labels" function in the Metrics & evaluation part of sample code "Getting Started.ipynb" have a slightly wrong order (and indexing) with inputs in the "res" list?
To my understanding, the "format_labels" is used to convert the raw data extracted from "sample-spatial/label.json" to a desired format.
More specifically, to the format of input to "list2stack" function in "https://github.com/CAMMA-public/ivtmetrics > ivtmetrics/detection.py > class Detection > function list2stack",
i.e. as stated in "list2stack" function: "#x format for a single frame: list(list): each list = [tripletID, toolID, toolProbs, x, y, w, h]".
However, I think current output of "format_labels" is giving the format of : each list = [toolID, toolProbs, toolProbs, x, y, w, h].
The screenshot below shows the original "format_labels" function and the version I modified, could you kindly have a look please?

Many thanks!

Thanks, the format and instruction is very clear!
I think the "format_labels" function in GettingStarted.ipynb is trying to do the "dict2stack" job in "https://github.com/CAMMA-public/ivtmetrics > ivtmetrics/detection.py > class Detection", but it turns the "vid_gt" into a list(list) format, which could leads to an issue?

You are correct. I will contact the person that wrote the GettingStarted.ipynb to cross-check with the metric library. Thank you for your input.

Thank you!


Feature/edepsim truth

Added Truth reading from Edepsim:

Contains a new library for the Edepsim files and the method to build it that is called in build.sh

Edepsim files are the merged spill files used by simulations.

Edepsim files are loaded the same way as other files with the call
nd_cafmaker.CAFMakerSettings.EdepsimFile: "/path/to/edepsimfile.root"

Edepsim Files are read when filling the true interactions (FillInteraction in FillTruth.cxx and to get particles in FillParticle in FillTruth.cxx.
We select the right entry from the Edepsim file with the combination of RunId and EventId exactly as the GenieFiles.

Three modifications were made to  MLNDLArRecoBranchFiller:

G4 ID is explicitely passed
G4ID is always defined as the gen_id of the file
We don't try to match ancestors inside it as the link is sometimes broken in MLReco

Added a template for ValidateOrCopy for float float comparisons. And loosened the criteria (apparently 1e-6 was too tight)
Those additions have fixed several issues realted to #71, #63 and another issue with neutral particles not being stored properly.
Details can be found in DocDb #31466
Impact x-checks show:

An additional running time of 40% (1.4 min vs 1min in average for a MiniRun5 file), still way bellow the bottlenecks of the production chain
No impact on the CPU usage per process
Additional filesize that needs to be accessible is 60%: For Minrun5, 791G for Genie and 536G for edepsim. Prelminiary work shows me that we can drop the memory usage of edepsim files by 50-60% by removing irrelevant variables for that work (Segments, Primaries, intermediate points) in case we want to store the full file on tape and keep a reduced file for future reprocessing.

About the main issue with the TG4Event Libraries. I've fixed it by just loading Edepsim with ups, I don't why I didn't do it originally. I checked that we got the same reasult with it.


Issue 221 - ability to inject topics into tests

Type of change
Select the type of your PR

Enhancement / new feature

Description
Ability to inject test topics into tests.
The user signals their wish for a topic to be injected by the use of a Topic type parameter.  On encountering this, the Junit extension will create a topic on the broker using a random name, and let the test know the name via the Topic parameter.    The test is guaranteed that the topic will exist before the test method commences.
Passing topic config, replication factor and number of partitions is supported.
Additional Context
Why are you making this pull request?
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[x] Write tests
[ ] Make sure all tests pass
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[x] Update CHANGELOG.md

@SamBarker @franvila  I want to point out the package/module location of the new @TopicConfig annotation.  See #234 for more details.

@SamBarker @franvila I want to point out the package/module location of the new @TopicConfig annotation. See #234 for more details.

PR is good to merge although could be affected by the outcome of #234.  Holding off merge until that reaches conclusion.


Feature/qa experience

Impetus: make it easier for Docs/QA/PM/UX to use manual plans to provision 7 day scratch orgs to test out a branch or latest beta.

replaces the (empty) bootstrap based user detail view with a user detail view that shows non-deleted scratch orgs owned by the user. it also shows some user details in an SLDS format

creates a new plan trigger type called Org Request to indicate the plan is not only triggered manually, but in cases where the org will stay around for testing.

adds a "New Org Please" page to allow the easy creation of orgs using Org Request plans by listing all plan repositories

plan run form now accepts query string prefill params. this makes link sharing easier.

Since you told me elsewhere that more work is incoming on this, I've removed myself as a reviewer for now. Once it's ready please add me as reviewer again.


WIP: Release 1.10.2

Just the CHANGELOG so far, for review

Can we relax the linter to 40 cyclomatic complexity?

The cyclomatic check is a warning; it does not cause a failed build.  This line is the fail:
CHANGELOG.md:51:26: "existant" is a misspelling of "existent"

I updated to bring in #3568


New wersion of adcs-issuer

I've decided to renew the code for adcs-issuer. Now it works with cert-manager 1.9.x and fully supports ntlm.
This work is still in progress. Helm chart will be in few next releases.
My repo link:
https://github.com/djkormo/adcs-issuer
Linked to:
https://github.com/cert-manager/website/pull/1077

I forked the most "deep" version and I have made changes to use this plugin
with 1.9.1 cert manager. The original version for using the old cert
manager API (beta). I haven't so far to talk to other people. The Nokia
code is outdated and imposibble to use at this moment.
With best regards,
Krzysztof Pudłowski
czw., 12 sty 2023 o 13:16 Richard Wall @.***>
napisał(a):

Thanks. Why are there so many forks of this project? Is there some
consensus about which is the official version since Nokia archived the
original?
https://github.com/djkormo/adcs-issuer/network/members
[image: image]
https://user-images.githubusercontent.com/978965/212063886-d637f7d4-75d6-4222-9cea-16bc6eb2deab.png
I'm glad you're maintaining it, but have you talked to those other
maintainers about whether yours should become the official version?
—
Reply to this email directly, view it on GitHub
https://github.com/cert-manager/website/issues/1132#issuecomment-1380241951,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE2CS6KN3UZA2VAUQY5KXTLWR7YYJANCNFSM6AAAAAATBRG7QA
.
You are receiving this because you authored the thread.Message ID:
@.***>

@mmlt @SimeonPoot @jimbali @gellner @pearj @dimatha You all have forks of the adcs issuer which are ancestors of @djkormo 's fork . Please weigh in on which version you now consider to be the official / best version.
@CsatariGergely and @chojnack You both contributed to the original Nokia project (AFAICS) so please comment if you have time.  Which of the forks you consider to be the official version.
xref

https://github.com/nokia/adcs-issuer/issues/14

Unfortunately we are not maintaining the original project anymore, but honestly I can not and do not want to define the official successor of the original Nokia code. I'm happy to add a note to the README to the original repo to clarify the situation if needed.

Hi there, at the moment I'm not maintaining any of the adcs-issuer code anymore. Made a few adjustments to make it working for the company I was with at that time, (I think the same goes for mmlt, as we teamed up).
If I need to do something for you guys, lemme know.
Good luck!

Unfortunately I was never able to complete the work that I needed this for, as I was blocked by another couple of departments for almost a year, and then the company went bust. I no longer have access to an ADCS server.

@djkormo seems to be the most active and keen to keep pushing adcs-issuer forward. I Vote his repo.

@djkormo seems to be the most active and keen to keep pushing adcs-issuer forward. I Vote his repo.

Agree!

After so many months I prepared documentation at https://djkormo.github.io/adcs-issuer/. Helm chart version of this plugin is now available.

After so many months I prepared documentation at https://djkormo.github.io/adcs-issuer/. Helm chart version of this plugin is now available.

Great! Open a PR to update https://cert-manager.io/docs/configuration/issuers/  and ping me when you want a review.

https://github.com/cert-manager/website/blob/07a6456a0ba9fddef0eab4ff92a2caf67268f46a/content/docs/configuration/issuers.md#L9-L29

https://github.com/cert-manager/website/pull/1369

I think this has been fixed in https://github.com/cert-manager/website/pull/1369


BreachDepressionsLeastCost 4-cell connected

Thanks for the awesome tool.
My tests show that BreachDepressionsLeastCost  uses 8-cell connectedness:

It would be awesome if there was an option for 4-cell to align with some hydrodynamic model behavior.  In the meantime, if you have any alternates to suggest these would be appreciated.

Looking at the image above, I must admit that I don't see the issue. How is 8-cell connectedness a problem? Can you provide an example perhaps? The issue with 4-cell connectedness is that breach paths will necessarily take on a very unnatural zig-zagging pattern. I think I could probably implement this feature, but the question is, do the benefits outweigh the downsides, i.e. the zig-zag breaching pattern and the additional parameter on a tool that already contains a large number of parameters.

Thank you for the reply and apologies for the confusion. The question is not which is preferable, but the application of the DEM. I am conditioning for a LISFLOOD model which uses 4 cell connectedness. I agree It would be nice if LISFLOOD used 8 cell, but it does not. Therefore, I need a conditioning tool which supports 4 cell. I assume there are others in a similar position, also… adding this as another parameter actually brings more clarity to the tool (I don’t think the connectedness is mentioned in the documentation).


Subcommand to adjust the signing protection watermark

Add a subcommand that will allow adjusting of the slashing protection watermark. This would be useful if all the slashing protection data has been lost and allow web3signer to be safely used to sign again by setting the watermark to a future slot.
Tasks

Create new subcommand at the same level as Eth2Export, Eth2Import, etc. (e.g. SlashingProtectionSubCommand or WatermarkSubCommand?)
Create service layer (may be small enough to go in subcommand) which uses tech.pegasys.teku.spec.Spec to determine the epoch/slot as the default for the command.
Allow user to configure their own epoch/slot?
Consider adding an acceptance test

Notes

An approach similar to the Teku signing-protection repair subcommand https://docs.teku.consensys.net/en/latest/Reference/CLI/Subcommands/Slashing-Protection/#repair could be used.
If automatically setting the slot and epoch watermark we can use the Teku spec object and calculate the exact epoch and slot
Optional nice to have to do in another story: take the opportunity to prune the DB.
Probably only need to configure one of epoch or slot.
Epoch source and target can be the same value.

Acceptance Criteria

Subcommand that allows setting the attestation and block watermark to the provided values
Can automatically set the slot and epoch to next epoch given the network name
Should set watermark for all the validators the web3signer instance knows about (rather than everything in the database), c.f. how pruning works: https://github.com/ConsenSys/web3signer/blob/6fa9df2fa42a8a67da19eb6fe5f210c4b9467d76/slashing-protection/src/main/java/tech/pegasys/web3signer/slashingprotection/DbSlashingProtection.java#L264

Tasks

[ ] Create watermark subcommand
[ ] Update watermarks for all known validators

Subcommand that allows setting the attestation and block watermark to the provided values

Besides attestations & block proposals, you might need to cover other cases like sync committees (altair) and signed blinded blocks (bellatrix).

Sync committee signings aren't stored as there are is no slashing that can be done on these.
The signed blinded blocks are treated the same as blocks since we pass in the body root now instead of the entire body. So these will be pruned as part of the block pruning.


Exclude vendor directory from gofmt input parameters

Now that the vendor directory is no longer excluded from git we need to adjust the gofmt input parameters to exclude it since it currently looks at any and all *.go files within the entire repo.  This causes it to run on files within the vendor directory which, as it turns out, contains some *.go files that do not conform to the go formatting guidelines.
Alternatively we could have explicitly listed the required source directories, but figured that this dynamic approach would be more "future-proof" and require less code maintenance.

/approve


[PREVIEW] Single port

https://issues.jboss.org/browse/ISPN-8756
Design document: https://github.com/infinispan/infinispan-designs/blob/master/Single_port.adoc
This is a preview version of a Single Port functionality. Currently it handles only HTTP/1.1 Upgrade and TLS/ALPN types of "upgrade" for REST server. However the most of the refactoring has been done and now I need to plug Hot Rod Server in and implement wiring in the server modules. Feel free to comment.
TODO:

[x] Upgrade to Hot Rod using TLS/ALPN and HTTP/1.1 Upgrade
[ ] Implement wiring in the endpoint
[ ] Implement an integration test

Rebased and comments addressed. All features are in, now I'll be focusing on the boring part (server wiring and e2e tests). Feel free to drop me more comments.

DistributedExecutorService is deprecated, so this is a good time to move it over to ClusterExecutor :)

@galderz Unfortunately it doesn't seem to be a no-brainer task. The APIs are different and require different approach and I can see no tests around it. I created ISPN-8873 to address this.

There are many tests for the ClusterExecutor: https://github.com/infinispan/infinispan/tree/master/core/src/test/java/org/infinispan/manager
Since this is a rewrite of the code, I'd prefer to see s/DistributedExecutor/ClusterExecutor/ done here rather than in a subsequent PR.

@tristantarrant I really, really, (really) don't think that's a good idea. There are little to none tests around this so this PR will already be gigantic (believe me). I you really insist I can do it (being more precise incorporate ISPN-8873 into this PR), but I won't be able to test all the scenarios...  This PR is ready to be reviewed.

Rebased. None of the failures occurred on my local box.

Rebased.
@galderz @ryanemerson - May I ask for your review guys?

@slaskawi Yep! I'll make sure I go through it before the end of the week

I've created ISPN-9251 and ISPN-9252 for the other leftovers here.

Thanks @galderz


PipsPager: The spacing between the pips in horizontal orientation is inconsistent with the vertical orientation

Describe the bug
When in horizontal orientation, the width and height of the bounding box for the pips is 20px by 12px when it should be 12px by 20px.
Steps to reproduce
View the pips in both orientations:

The denser spacing of the pips in vertical orientation is desired.
Solution Recommendation
Update PipsPager theme resources to allow bounding box customization in both orientations:
Rename existing theme resources to include 'Vertical' in name and create Horizontal resources as well.

Current
Recommendation

PipsPagerButtonWidth
Rename to PipsPagerVerticalButtonWidth and add PipsPagerHorizontalButtonWidth

PipsPagerButtonHeight
Rename to PipsPagerVerticalButtonHeight and add PipsPagerHorizontalButtonHeight

PipsPagerNavigationButtonHeight
Rename to PipsPagerVerticalNavigationButtonHeight and add PipsPagerHorizontalNavigationButtonHeight

PipsPagerNavigationButtonWidth
Rename to PipsPagerVerticalNavigationButtonWidth and add PipsPagerHorizontalNavigationButtonWidth

Two potential options for implementation:

Reference these new resources in the code behind when calculating pip size.
Create two new styles in the theme resources for horizontal and vertical orientation. Create handler in code behind to reference these styles on orientation change.

@beervoley fyi


Smart reload on publish page

Currently, when publishing a single page, we call load_from_db which reloads every page, component, layout, and stylesheet. We should instead call a new function that reloads the single page and the layout it uses (since the layout needs to regenerate the css based on the new page).

Permalink just in case that file changes :) https://github.com/BeaconCMS/beacon/blob/d0a75a593257103d267d7a0e3b02b5fccd1956e2/lib/beacon/pages.ex#L101


FM2-333 : Implement the $collect-data operation in HAPI FHIR

Ticket:FM2-333

see results returned  https://pastebin.com/k9EX9deb

see results returned  https://pastebin.com/k9EX9deb

@ibacher  , i updated the PR,
see data returned   https://pastebin.com/mi9DdQHS

@ibacher  , i updated the PR,
see data returned   https://pastebin.com/mi9DdQHS

@mozzy11 That example looks perfect to me! Thanks for all the work on this!

@mozzy11 That example looks perfect to me! Thanks for all the work on this!

Thanks @ibacher too  for the review

Thanks @ibacher too  for the review


add support for FunctionImageSizeMB configuration on Azure experiments

This PR is related to #343 and adds filler files to Azure deployments, when the size of the source code/binary falls below the value of the FunctionImageSizeMB parameter.
Changes

extracts previously duplicated portions of code into a new CalculateFillerFileSizeInBytes function

Example of a deployment artifact uploaded to the Azure storage account (when FunctionImageSizeMB is set to 24):


update vertical_tabs to work with multiple instances of vertical tabs…

Updated the logic to be encapsulated to individual instances of vertical tabs. Fixes #12 .

I’m closing this because this project will no longer be actively maintained.


feat: support global direct call validation

Motivation
While we added support for direct-call validation in #90, this was only supported for individually added selectors, because the checking type defaulted to non-global. It would be useful to have "full" support for all validation types in this path.
Solution
Check for both global and selector-based validation applicability in the direct call path.
Do this by refactoring the checking functions to take an enum with types of GLOBAL, SELECTOR, and EITHER.
Refactor the direct call tests to randomize the validation type initialization, to test both cases.

Nice way to go about this!
Wdyt of the security implications? I think it's fine, because a nefarious module could always just request whatever function to direct-call. So, overall, I think this is a nice streamlining change!

Wdyt of the security implications? I think it's fine, because a nefarious module could always just request whatever function to direct-call. So, overall, I think this is a nice streamlining change!

Yeah, similar reasoning on my end. The status of a validation as global vs not is part of the domain it gets set up with, so if you don't want to give it global access, you just don't set that as a parameter when you install it. But in some cases, it would be nice to grant it that permission.


Update jquery version.

Closes #351

Not sure how good Bootstrap and Popper are with regards to not breaking things in patch releases, but should we maybe consider dropping the .lock file, so that users can easily get the latest patch versions?

Whatever you see fit. I don't use the css/js provideed through the plugin (nor any templates for that matter) so I don't care :slightly_smiling_face:.

Well, I don't want to be the one who breaks everybody's stuff 😄

Everyone lib maintainer does that sooner or later 😂.

Yeah, well... let's leave that for another day 🙃 Maybe we can give it a try with for BS5.


Sage IntAcct Integration: Deliverables

Fixes https://github.com/OpenTechFund/apply-app/issues/1

Codecov Report

Merging #2568 (60a053f) into main (59b1398) will decrease coverage by 0.02%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #2568      +/-   ##
==========================================
- Coverage   81.15%   81.13%   -0.03%
==========================================
  Files         647      647
  Lines       23098    23105       +7
==========================================
+ Hits        18745    18746       +1
- Misses       4353     4359       +6

Impacted Files
Coverage Δ

hypha/settings/base.py
66.81% <14.28%> (-1.66%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b1398...60a053f. Read the comment docs.

@frjo, I got this error on sentry while testing on test: Some of the parameters are wrong.
While all these errors from the payment service APIs should be handled in our code..we could display a friendly message..or log the errors somewhere..any error on the communication b/w hypha and the intacct api shouldn't break hypha system.
I will be working on this fix. In meantime can you recheck if all the variables are correct. Thanks.

I have deployed the latest changes to test now.

@frjo, can we deploy this on test? I have sent the env variable that I'm using locally on signal.

Deploying to test now.

@frjo I suppose we can merge this in now.
I removed all three lines which does the api call. We can add them whenever we need them back.
So now there is no connection b/w hypha and intacct and the code for intacct integration is lying there independently.


Customized Homepage fallout

[x] Dragging offset problem, especially when scrolling is involved.  Not sure if there is a solution.

https://github.com/atlassian/react-beautiful-dnd/issues/1881#issuecomment-682016581

[ ] Annoying react-beautiful-dnd warning about nested containers.  I don't think there's nested containers, though.
[ ] Draggable icon could be better (maybe use 6 dots like in Gmail)

[ ] Excluded categories (like News, and in the future, Wild West) isn't excluded in the dialog.


Report broken Control Center cleanup on iOS 17.1 beta to Apple

As a developer integrating Pillarbox I want to be able to enable or disable Control Center integration on the fly.
Hint
Control Center integration can be enabled or disabled at any time. Starting with iOS 17.1 betas this feature is broken. It still works well on iOS 17 or 16.
The issue is that clearing the now playing info center does not work correctly anymore on iOS 17.1.
Acceptance criteria

The above issue has been reported to Apple.

Tasks

[ ] Report the issue to Apple.
[ ] Document as known issue if 17.1 is released and the issue has not been fixed.

The issue is not reproduced in iOS 17.2. Closing it was legitimate.


Syntax error in minified blob when adding a surfacerepresentation

I have a clean checkout of the current master checkout, just pulled a few minutes ago.
git status
# On branch master
nothing to commit, working directory clean

The I build NGL with npm, and specifically the minified version:
npm install
npm run-script build-min

and then use  dist/ngl.js. When I create a surface representation:
 ngl_stage.compList[0].addRepresentation("surface")

I get no visible representation and the following error message in the browser javascript console:
Object { stage: {…}, signals: {…}, parameters: {…}, uuid: "D3253E13-5F38-400A-9F03-7C48C5BFE0DC", parent: {…}, repr: {…} }
Worker.onerror molsurf
error { target: Worker, isTrusted: true, message: "SyntaxError: function statement requires a name", filename: "blob:http://<IP_ADDRESS>:42342/53ef56ce-c48c-4929-8aa3-a9e0a7261fdb", lineno: 126, colno: 0, currentTarget: Worker, eventPhase: 2, bubbles: false, cancelable: true, … }
ngl.js:1:691138
SyntaxError: function statement requires a name
53ef56ce-c48c-4929-8aa3-a9e0a7261fdb:126:8

Inspecting the blob, there indeed seems to be a syntax error. Here is an excerpt of the blob contents ([...] added for clarity):
[...]
function yS(C,I,c){var p=ty(I), [...]
function ym(t,e,i){t[0]=e[0]-i[0],t[1]=e[1]-i[1],t[2]=e[2]-i[2]}
function(C,I,L,R,t,e,i){var r=C.length,O=t[0],D=t[1],k=t[2],n=e[0][...]
self.func = function(t,e){var i=t.data.args,r=t.data.params;if(i&&r){var [...]
self.onmessage = function(t){var e=t.data.__name,i=t.data.__postId;void 0===e?console.error("message __name undefined"):void 0===self.func[...]

The third line is indeed missing the function name. This seems to be related with the minification process. If I use build/js/ngl.dev.js the surface representation is working properly.
One more note: if I checkout tag v2.0.0-dev.33 and run npm install && npm run-script build-min, surface representations work fine. Therefore this must be caused by a change since v2.0.0-dev.33.

hi guys, seems that there is a regression with latest dev release 37
as i am currently experiencing similar issue with the library as per the images attached

nvm guys - it seems that it was a minification issue on nuxt build


Allow managing state transition asynchronously.

Idea is similar to one of the comments from https://github.com/angular-ui/ui-router/issues/618
pause()
resume()
halt()
E.g. now I adding service that watch forms, and show modal to user when user try to navigate away. Modal is async, so i need to do some tinkering. Can't say if it is correct solution, but it seems it works now.
var initialTransition = true;
$rootScope.$on('$stateChangeStart', ... {
  if (!initialTransition) {
    return;
  }
  some async call().then(function() {
    if(stayOnCurrentState) {
      return;
    }
    initialTransition = false;
    $state.transitionTo(to, toParams);
    initialTransition = true;
  });
   event.preventDefault();
});

One way to solve it, could be some method that do these. Another option would be to add new option 'skipStart', that will allow to skip  only '$stateChangeStart' (similar to 'notify' option).

https://gist.github.com/eddiemonge/f6a58169c2846731a1eb


[Question] How to act as logged user in tests?

Describe your question
I'm using sessionAttribute and AccessManager for authentication / authorization. I do like writing acceptance tests on REST API level. Question: Is there any common pattern to act as a logged user in tests?
Currently, I added an optional endpoint (added only in tests) like:
if (testMode) {
    app.post("/test-login", ctx -> {
        ctx.sessionAttribute(PRINCIPAL_SESSION_KEY, ctx.bodyAsClass(Principal.class));
    });
}

// ..
public record Principal(UUID userId, String username, Set<Role> roles) implements Serializable {
}

and then in tests I'm using this endpoint before tested endpoint, but that's quite verbose (?)

Another way is to perform a check against an environment variable, or check for localhost, inside the AccessManager:
config.accessManager { ...
    if (evn == local) ctx.sessionAttribute(PRINCIPAL_SESSION_KEY, ctx.bodyAsClass(Principal.class));
    // normal access manager code
}

That's an interesting idea from a server side perspective. Do you have any ideas/ways to improve something on the client side?   I'm experimenting with something like:
 @Test
void foo() {
    runTestAs(TestPrincipal.publisher, () -> {
        String request = """
            {
                "title": "Title 1"
            }""";

        HttpResponse<String> result = http.postRequest("/api/article", request);
        assertThat(result.statusCode()).isEqualTo(200);
        // ...
    })
}

which requires some abstract BaseIntegrationTest class. Did you find something better?

@mat-mik I haven't really thought about this from the client's perspective, but we could potentially expand the testtools artifact to include some sort of preTest and postTest callbacks?

@tipsy spent some time with it and I get used to it (to have an abstract class with helper methods), so for me it looks good as it is. But I spent some time "inventing" this approach - maybe we could mention it in tutorials / docs or add INFO label? What do you think?


Correctly setup MockQuery.snapshots() to broadcast data to 'already listening' streams.

Objective
Fix the issue #111
Changes

Add QuerySnapshotStreamManager to keep and re-fire updated data to streams for each Query.
Setup snapshots() stream to not broadcast same data.
Add unit test

Tests

[x] listening snapshot stream with where.
[x] listening snapshot stream with orderBy.
[x] listening snapshot stream with where and orderBy.

Not designed well. close for now.

Thanks for filing and working on it, @gki! I'll take a look at your draft in the next few days.

Thanks @atn832 . Actually, I'm not familiar to sending PR to OSS repo.
So feel free to point out my code if there are unsuitable structure, naming, updates etc, etc... 😉

Awesome work, I only have minor comments.

@atn832 Thanks for reviewing!

Thank you for this big, well-written PR! I'll publish an update later this week.

Ah, sorry to incomplete update... 😩 I will create another PR to fix remaining points.

I just published this and #115 to https://pub.dev/packages/cloud_firestore_mocks/changelog#0461. Thank you for your awesome contributions!


Created new file =  Randomshit.py

I added a new .py file which can identify the length of a word given

hello, what can you say about the file that I added


As a potential user exploring the app, I see the app populated with sample data.

So that I can immediately see an example of the app in use.

Already implemented.


The following build commands failed:   CompileC com.apple.compilers.llvm.clang.1_0.compiler (in target 'react-native-webview' from project 'Pods').    'react/utils/ContextContainer.h' file not found

Please help i am new in react-native , while run project after installing  webview in ios it throws an below error.
Bug description:
2023-11-24 13:28:35.330 xcodebuild[51973:107127009] DVTCoreDeviceEnabledState: DVTCoreDeviceEnabledState_Disabled set via user default (DVTEnableCoreDevice=disabled)
2023-11-24 13:28:44.796 xcodebuild[51973:107128086]  DVTPortal: Service '<DVTPortalViewDeveloperService: 0x144e5ae10; action='viewDeveloper'>' encountered an unexpected result code from the portal ('1100')
2023-11-24 13:28:44.796 xcodebuild[51973:107128086]  DVTPortal: Error:
Error Domain=DVTPortalServiceErrorDomain Code=1100 "Your session has expired. Please log in." UserInfo={payload={
creationTimestamp = "2023-11-24T07:58:45Z";
httpCode = 200;
protocolVersion = QH65B2;
requestUrl = "https://developerservices2.apple.com/services/QH65B2/viewDeveloper.action";
responseId = "f1a76ac4-4fd1-416c-93aa-324af834c8c9";
resultCode = 1100;
resultString = "Your session has expired. Please log in.";
userLocale = "en_US";
userString = "Your session has expired. Please log in.";
}, NSLocalizedDescription=Your session has expired. Please log in.}
** BUILD FAILED **
The following build commands failed:
CompileC /Users/admin/Library/Developer/Xcode/DerivedData/DemoProject-blolrmezpqveeoftwazzmuuubhsl/Build/Intermediates.noindex/Pods.build/Debug-iphoneos/react-native-webview.build/Objects-normal/arm64/RNCWebView.o /Users/admin/Documents/Rect_Projects/Express-Minds/node_modules/react-native-webview/apple/RNCWebView.mm normal arm64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'react-native-webview' from project 'Pods')
(1 failure)
To Reproduce:
Here is podfile

Expected behavior:
I am useing react native new architechture.
I am  useing '  RCT_NEW_ARCH_ENABLED=1 pod install --repo-update ' command to install pods . After insrtalling when i run run project i throws above error.
Below thow error in Xcode : -

Environment:

OS: MacOs M1
OS version: Venture 13.3.1 (22E261)
react-native-webview version: 13.6.2

System:
OS: macOS 13.3.1
CPU: (8) arm64 Apple M1
Memory: 63.52 MB / 8.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 18.16.0
path: /usr/local/bin/node
Yarn:
version: 1.22.19
path: /opt/homebrew/bin/yarn
npm:
version: 9.6.7
path: /opt/homebrew/bin/npm
Watchman:
version: 2<IP_ADDRESS>
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.13.0
path: /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 22.4
- iOS 16.4
- macOS 13.3
- tvOS 16.4
- watchOS 9.4
Android SDK:
API Levels:
- "30"
- "31"
- "33"
- "34"
Build Tools:
- 30.0.2
- 30.0.3
- 33.0.0
- 34.0.0
System Images:
- android-34 | Google APIs ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2022.2 AI-222.4459.24.2221.10121639
Xcode:
version: 14.3/14E222b
path: /usr/bin/xcodebuild
Languages:
Java:
version: 11.0.19
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.6
wanted: 0.72.6
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: true

same issue!

same issue!

I solve this issue by disabling new architecture in ios during pod install.
use this for disabling : -----  cd ios && RCT_NEW_ARCH_ENABLED=0 pod install

@partikshadubb Thank you, I will try


Update Display Version for Zoom.Zoom version <IP_ADDRESS>988

When the previous version is installed, in sandbox it matches to '> <IP_ADDRESS>030' which indicates the package can't be mapped to a specific version. Making the display version exactly match what is installed should help

Related to #137286

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

2024-01-31T20:20:37.9667483Z ##[error] Manifest Error: DisplayVersion declared in the manifest has overlap with existing DisplayVersion range in the index. Existing DisplayVersion range in index:  [ [5.17.5 (31030), 5.17.5 (31030)]]

(Automated response - build 684.)

@wingetbot run

Automatic Validation ended with:

2024-01-31T22:16:48.6603831Z ##[error] Manifest Error: DisplayVersion declared in the manifest has overlap with existing DisplayVersion range in the index. Existing DisplayVersion range in index:  [ [5.17.5 (31030), 5.17.5 (31030)]]

(Automated response - build 692.)

Ah, right. It sees the version ranges as 5.17.2 to 5.17.29988, and that 5.17.5 falls inside that range.
@denelon / @ryfu-msft - This might highlight a need to not treat DisplayVersion as a range and instead make it an array which requires exact matching

/AzurePipelines run


[Issue] azd Get started using Azure Developer CLI learn docs page "default" (todo app w/mongo db) template does not function as expected

Output from azd version
azd version 1.6.1 (commit eba2c978b5443fdb002c95add4011d9e63c2e76f)
Describe the bug
Following the quick start here, when deployment is complete, the web app does not function, becuase there are no lists created by default. The create list button is disabled. The only way to get the sample to work properly is to create a new list via the api.
To Reproduce
Follow default instructions here.
Once deployed, click link. On learn page, looks like this:

Clicking on web app link, you'll see spinning icon.
Expected behavior
Icon is not spinning, and/or the create new list button is not disabled.
Environment
Information on your environment:
* whatever language sample above uses
* VS Code Version: 1.87.0 019f4d1419fbc8219a181fab7892ebccf7ee29a2 x64

@hemarina can you triage it?

Tried deploying https://github.com/Azure-Samples/todo-nodejs-mongo and the todo app seems to be working fine. Able to add, remove todo items to it.
@robch @hemarina can you try again?

@hemarina service api seems working fine -  https://app-api-ctdl25rqtvzge.azurewebsites.net/ using edge.
Also, fixing this feature request https://github.com/Azure/azure-dev/issues/3260 should alleviate some of the deployment related issues.


deprecate template

remove template namespace
deprecate template

#4

Coverage decreased (-0.8%) to 95.07% when pulling e9748d124321d1c884898a1c7adf72a480e268d0 on issue_template_deprecate into 6d7c065c11858ddb9b8410f7c1e96890f456d07f on master.

Coverage decreasing caused by remove template doesn't matter. Decide to merge.


[azservicebus] Ignore the leading XMLNS for properties in subscription rules

The individual properties for a rule in Service Bus come with an XML ns prefix. We don't actually care about this as we're just trying to figure out what the assigned type is (string, int, etc..) so this just strips out the prefix.
Fixes #18785

/azp run go - azservicebus

(had to go 1.19 gofmt)

/azp run go - azservicebus

The CI pipeline seems to be having issues unrelated to tests or code (it's failing to upload an artifact, but it's CI).
Bypassing - live tests and other CI pipelines have passed

/check-enforcer override

/check-enforcer reset

/check-enforcer override


Test server issues with legacy query

Expected Behavior
Test server sends legacy query and activity resolution at the same time and workflow should be able to send response to query and next command.
Actual Behavior
This one is a bit hard to reproduce. You have to make an activity resolution happen at the same time as a query. Then the query comes over as a legacy query from the test server and the workflow responds to the query and does a start child workflow in the same response. Core responds to this with:

Lang SDK sent us a malformed workflow completion for run (a067d736-1f05-4217-8c4c-4c4c5674c605): Workflow completion had a legacy query response along with other commands. This is not allowed and constitutes an error in the lang SDK

The server should never issue a legacy query with new history. This is either an error with the test server, or the python SDK is erroneously processing existing history (which may be sent with a legacy query) as new history and thus generating a new command


RequestError's access control

I try 2.0-development branch just now.
RequestError's access control is internal.
Is this on purpose?
RequestError.swift
Is it possible to public?

Good catch 🙇 This will also be fixed in #166!

Thanks for quick reaction!


Support nested schema projection (#5148)

Which issue does this PR close?

Closes #5148.
Rationale for this change

See ticket
What changes are included in this PR?

Are there any user-facing changes?

Looks very nice @tustvold  -- thank you

One question I have is does this API support the usecase in https://github.com/apache/arrow-rs/pull/5149#discussion_r1409743402 (selecting a nested subfield)? If not, I can file a ticket tracking that feature request

One question I still have is does this API support the usecase in #5149 (comment) (selecting a nested subfield)?

Yes, I responded to the comment as such?

One question I still have is does this API support the usecase in #5149 (comment) (selecting a nested subfield)?

Yes, I responded to the comment as such?

Sorry -- the github UI is confusing me. I see the response in https://github.com/apache/arrow-rs/pull/5149#discussion_r1409762734 now. Thanks


feat: port Topology.Category.UniformSpace

I got stuck on typeclass issues, see Zulip thread.

bors merge


Social Login

Does kong support any form of social login, or is it planned? I'm extremely tempted to use kong right now, but social login (Facebook/Twitter/Google) is a must.

Can you clarify better? Do you mean social logins as plugins in the authentication group like we have for JWT, basic, etc?


Organizing tests and configurations

Organizing the tests into subfolder to help with the introduction of new feature set.

Codecov Report

Merging #24 (c487b8f) into main (6f4b71e) will increase coverage by 0.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   96.15%   96.71%   +0.55%
==========================================
  Files          10       11       +1
  Lines         442      456      +14
==========================================
+ Hits          425      441      +16
+ Misses         17       15       -2

Impacted Files
Coverage Δ

gh_actions_exporter/metrics.py
88.99% <ø> (+0.65%)
:arrow_up:

tests/api/metrics/test_job.py
98.68% <ø> (ø)

gh_actions_exporter/main.py
97.72% <100.00%> (+0.16%)
:arrow_up:

tests/api/conftest.py
100.00% <100.00%> (ø)

tests/api/metrics/conftest.py
100.00% <100.00%> (ø)

tests/api/metrics/test_workflow.py
100.00% <100.00%> (ø)


Compare stable network data version when only requesting stable data.

Codecov Report

Merging #1390 into master will increase coverage by 0.44%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1390      +/-   ##
=========================================
+ Coverage   69.16%   69.6%   +0.44%
=========================================
  Files         171     172       +1
  Lines       26962   26979      +17
  Branches     3395    3370      -25
=========================================
+ Hits        18647   18780     +133
+ Misses       6895    6784     -111
+ Partials     1420    1415       -5

Impacted Files
Coverage Δ

src/core/thread/mle.cpp
81.21% <100%> (+0.75%)
:white_check_mark:

third_party/mbedtls/repo/library/ecp_curves.c
90.16% <ø> (-3.06%)
:x:

src/core/net/udp6.cpp
82% <ø> (-1%)
:x:

...d_party/mbedtls/repo/library/memory_buffer_alloc.c
60.25% <ø> (-0.39%)
:x:

src/core/thread/mle_router.cpp
79.68% <ø> (-0.06%)
:x:

third_party/mbedtls/repo/library/ssl_tls.c
54.34% <ø> (-0.04%)
:x:

examples/apps/ncp/main.c
100% <ø> (ø)

third_party/mbedtls/repo/library/bignum.c
51.09% <ø> (+0.13%)
:white_check_mark:

src/core/thread/network_data_leader_ftd.cpp
68.23% <ø> (+0.23%)
:white_check_mark:

src/core/openthread.cpp
45.58% <ø> (+0.42%)
:white_check_mark:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f35cdb...bf4ef59. Read the comment docs.


queue: Use locking to avoid race conditions in missedmessage_emails.

This queue had a race condition with creation of another Timer while
maybe_send_batched_emails is still doing its work, which may cause
two or more threads to be running maybe_send_batched_emails
at the same time, mutating the shared data simultaneously.
Another less likely potential race condition was that
maybe_send_batched_emails after sending out its email, can call
ensure_timer(). If the consume function is run simultaneously
in the main thread, it will call ensure_timer() too, which,
given unfortunate timings, might lead to both calls setting a new Timer.
We add locking to the queue to avoid such race conditions.
Tested manually, by print debugging with the following setup:

Making handle_missedmessage_emails sleep 2 seconds for each email,
and changed BATCH_DURATION to 1s to make the queue start working
right after launching.
Putting a bunch of events in the queue.
./manage.py process_queue --queue_name missedmessage_emails
Once maybe_send_batched_emails is called and while it's processing
the events, I pushed more events to the queue. That triggers the
consume() function and ensure_timer().

Before implementing the locking mechanism, this causes two threads
to run maybe_send_batched_emails at the same time, mutating each other's
shared data, causing a traceback such as
Exception in thread Thread-3:
Traceback (most recent call last):
File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner
self.run()
File "/usr/lib/python3.6/threading.py", line 1182, in run
self.function(*self.args, **self.kwargs)
File "/srv/zulip/zerver/worker/queue_processors.py", line 507, in maybe_send_batched_emails
del self.events_by_recipient[user_profile_id]
KeyError: '5'
With the locking mechanism, things get handled as expected, and
ensure_timer() exits if it can't obtain the lock due to
maybe_send_batched_emails still working.

While the locking strategy you had might work, it's hard to reason about.  Philosophically, the best way to think about locking is as protecting data structures; all access to data structures protected by a lock should be done while holding the lock, and then you can be confident that no problematic access happens without having to really think about it.
I pushed a new commit on top of this PR implementing that concept; can you review and rerun your reproducer test on it?

@timabbott Looks right to me, and seems to work well with my testing as well. I thought that the property of having consume() able to run quickly without waiting was important to keep, that's why I went for the more tricky locking. One issue I can see with blocking consume() while emails are being sent is that this might confuse our queue monitoring - it will look like the queue is stuck (because it's not consuming) if maybe_send_batched_emails is taking a bunch of minutes.

Since this queue worker's output is just writing entries to the email_senders queue, the processing in maybe_send_batched_emails is extremely fast; see for example this output:
2020-08-26 19:23:19.362 INFO [] Batch-processing 1 missedmessage_emails events for user
2020-08-26 19:23:19.380 INFO [] Batch-processing 1 missedmessage_emails events for user
2020-08-26 19:23:19.381 INFO [] Batch-processing 6 missedmessage_emails events for user
2020-08-26 19:23:19.381 INFO [] Batch-processing 2 missedmessage_emails events for user
2020-08-26 19:23:19.438 INFO [] Batch-processing 1 missedmessage_emails events for user
2020-08-26 19:23:24.459 INFO [] Batch-processing 3 missedmessage_emails events for user
2020-08-26 19:23:24.505 INFO [] Batch-processing 1 missedmessage_emails events for user
2020-08-26 19:23:39.518 INFO [] Batch-processing 3 missedmessage_emails events for user
2020-08-26 19:23:39.519 INFO [] Batch-processing 2 missedmessage_emails events for user
2020-08-26 19:23:39.519 INFO [] Batch-processing 1 missedmessage_emails events for user
2020-08-26 19:23:39.561 INFO [] Batch-processing 1 missedmessage_emails events for user
2020-08-26 19:23:44.562 INFO [] Batch-processing 1 missedmessage_emails events for user
2020-08-26 19:23:44.579 INFO [] Batch-processing 1 missedmessage_emails events for user
2020-08-26 19:23:54.582 INFO [] Batch-processing 1 missedmessage_emails events for user

This doesn't quite log the timing details, but you can see we're handling multiple users in a single millisecond, with large gaps in between when the processor is presumably idle.  I think we should be OK.

Squashed and merged, thanks @mateuszmandera!