The DisableTDTFeature Parameter is missing from the Set-MpPreference Documentation

Prerequisites

[X] Existing Issue: Search the existing issues for this repository. If there is an issue that fits your needs do not file a new one. Subscribe, react, or comment on that issue instead.
[X] Descriptive Title: Write the title for this issue as a short synopsis. If possible, provide context. For example, "Typo in Get-Foo cmdlet" instead of "Typo."
[X] Verify Version: If there is a mismatch between documentation and the behavior on your system, ensure that the version you are using is the same as the documentation. Check this box if they match or the issue you are reporting is not version specific.

Links

https://github.com/MicrosoftDocs/windows-powershell-docs/blob/main/docset/winserver2022-ps/defender/Set-MpPreference.md

Summary
On Windows 11 build 22621.1992, the parameter DisableTDTFeature is available in Set-MpPreference but is not documented on this page.
Interestingly, DisableTDTFeature does not appear in Get-MpPreference but is available in Set-MpPreference.
Details
No response
Suggested Fix
No response

Ping @HotCakeX

Ping @HotCakeX

Nice, I found 2 more
https://github.com/MicrosoftDocs/windows-powershell-docs/issues/3558
https://github.com/MicrosoftDocs/windows-powershell-docs/issues/3557


W3MService made app freezed when hard-reloading

When I started building the app, it works just fine.
 Please provide a valid projectId. '
          'See https://docs.walletconnect.com/web3modal/flutter/options for details.');
      return;
    }
    if (_status == W3MServiceStatus.initializing ||
        _status == W3MServiceStatus.initialized) {
      return;
    }
    _status = W3MServiceStatus.initializing;
    _notify();

    _registerListeners();

    await storageService.instance.init();
    await networkService.instance.init();
    await explorerService.instance.init();
    if (_initializeCoinbaseSDK) {
      // final isInstalled = await cbIsInstalled();
      // Fetch Coinbase Wallet object to get updated metadata
      final cbWallet = await explorerService.instance.getCoinbaseWalletObject();

    ** I notice that when I do hard reload, this future is not resolved **
    // seems like we have issue with cbInit
      await cbInit(metadata: _web3App.metadata, cbWallet: cbWallet);
    }

Web3Modal Version [3.2.2]

Please could you try web3modal_flutter: ^3.3.0-beta06 instead? Also why are you initializing w3mService outside of runApp()?
// main.dart
void main() async {
 await w3mService.init();
 runApp(const MyApp());
}

@quetool not sure if it's a bad practice ? cause I have global bloc which use w3mservice, so I wanna make sure it's initialized before the app is rendered

It's not a bad practice but not ideal in our case, W3MService uses a BuildContext internally (and it will be required in the future) so that might have some troubles. I would init it inside MyApp().
Anyway, have the issue been fixed by updating to latest beta?

Is this fixed, @mthinh ?

@quetool yah i think it's fixed. May I know the reason behind ?

It's not a bad practice but not ideal in our case, W3MService uses a BuildContext internally (and it will be required in the future) so that might have some troubles. I would init it inside MyApp().
Anyway, have the issue been fixed by updating to latest beta?

Nice advice, let me take a look on this

@quetool yah i think it's fixed. May I know the reason behind ?

Probably due to an issue on a thirty party SDK that got fixed and updated recently.


[proposal] Added support for nested invalid attributes

If you want to manually build an error based on WLValidationError that holds nested errors, because validation failed on nested data (association, nested documents, etc), there is no way to pass that data as invalidAttributes and get the expected result. There might not be support yet for deep validations but this opens the door for it. It's just a couple of simple helpers that iterate recursively if needed to properly normalize and format the errors.
So that this invalid attributes:
{ location:
      { country:
         [ { rule: 'string',
             message: '`undefined` should be a string (instead of "null", which is a object)' },
           { rule: 'required',
             message: '"required" validation rule failed for input: null' },
           { rule: 'notEmpty',
             message: '"notEmpty" validation rule failed for input: null' } ],
        city:
         [ { rule: 'string',
             message: '`undefined` should be a string (instead of "null", which is a object)' },
           { rule: 'in',
             message: '"in" validation rule failed for input: null' },
           { rule: 'required',
             message: '"required" validation rule failed for input: null' },
           { rule: 'notEmpty',
             message: '"notEmpty" validation rule failed for input: null' } ],
        }

Can keep that format (otherwise it gets modified) and we can get a nice error too, like this
Error (E_VALIDATION)  ... some error details here
• location:
      • country:
        • `undefined` should be a string (instead of "null", which is a object)
        • "required" validation rule failed for input: null
        • "notEmpty" validation rule failed for input: null
      • city:
        • `undefined` should be a string (instead of "null", which is a object)
        • "in" validation rule failed for input: null
        • "required" validation rule failed for input: null
        • "notEmpty" validation rule failed for input: null

If the use case is not clear, or something needs to be improved or modified let me know.
pst: Not sure if there are tests for this, i didn't check since i'm doing this for the project i'm currently working on, so if there are some tests that needs to be modified somehow, let me know that too.

ok, fixed!


Consider using SvgPathImage instead of SvgImage for 2FA QR

SvgImage() produces a QR code with small white lines between each point in the QR code which can cause some apps to struggle in reading the code. By using SvgPathImage the white lines are removed.

Thanks for the suggestion. Switch to SvgPathImage in the commit above.


Implement uploading of multpart/form-data

Great idea! I think Alamofire supports this already, so there is an opportunity to leverage their code while being clever about how we expose the functionality.

I am afraid it is not, out of the box. But it would be great if there was something like Alamofire.upload at least.

OK, cool. We can start there then :)

There is Alamofire support for uploading and downloading files, so this would be straight forward I guess.
I anyone already working on this? Might need it in the following weeks so I might as well hack on it if you want.

Help on this would be very much appreciated. I'm catching up on some work for the remainder of the week, and won't have time to look at it for a while.

Also looking for this fairly soon. @aschuch do you have any progress on this? If not I can take a look.

@zdavison I did not start on it yet. I probably don't get time to do it anytime soon though... :disappointed:

@aschuch that's ok, i'll take a look here, we need it in the next week or so.

This is a fundamentally new behaviour for Moya. I'm trying to figure out the best way to add it to our existing API without overly complicating things.
If we want to use the existing request() function, then we would need to have a way to distinguish targets between upload and regular HTTP requests. We could add .Upload to the Moya.Method enum, which would be easy, but would break parity with the HTTP verbs and the Alamofire.Method enum.
On the other hand, if we add a new optional property to MoyaTarget for uploading (say, we call it uploadData), we could ignore the method of the target and assume it's uploading based on the presence of a non-nil uploadData.
In either case, we would still need to figure out the progress callback. Maybe we could incorporate it into the cancellable token somehow maybe?
Neither option really sits with me. We could, instead, have a new upload method on the MoyaProvider class. We would still need the optional uploadData property, the API would become slightly more complicated, and it would be some duplicated code in MoyaProvider and its subclasses.
Anyone have any feels about this?

If only Swift had support for default parameters to Enums, we could have .POST and others with a optional parameter with a default to nil.
But even if we don't have that support, we could just add more verbs that accept that to Moya.Method.

FWIW we ended up just doing it by hand (since we only need it for one request) and having a special case that returns a MoyaResponse until Moya/Alamofire support it natively.

@zdavison Can we see what your solution looks like? I tried hacking it in an endpointResolver, but I hit a wall when I figured out the Endpoint doesn't seem to know about any of the parameters it's been given in by the enum. Now, creating a custom, plain NSURLRequest seems the best option.
But you returning a MoyaResponse sounds intriguing, but I don't get what that would look like.
@ashfurrow

On the other hand, if we add a new optional property to MoyaTarget for uploading (say, we call it uploadData), we could ignore the method of the target and assume it's uploading based on the presence of a non-nil uploadData.

I like this one. Beyond the fact that we still need a call-back of some kind, it fits very well within the existing way of creating a Target.

Neither option really sits with me. We could, instead, have a new upload method on the MoyaProvider class. We would still need the optional uploadData property, the API would become slightly more complicated, and it would be some duplicated code in MoyaProvider and its subclasses.

This also sounds good, though slightly confused on how this would interact with a Target. Do suddenly all Target cases have the ability to upload data if you call them with this method? Should the method check if the request is a .POST or not?

  // Multipart image uploading not supported by Moya/Alamofire, temporary stand in
  internal static func ns_multipartImageUpload(urlString: String, image: UIImage, imageKind: ImageKind, progressHandler: ((Float) -> Void)?) -> RACSignal{

    let imageData       = UIImageJPEGRepresentation(image, 9.5)

    return RACSignal.createSignal{
      (subscriber) in

      Just.post(
        urlString,
        headers:    ["X-Auth-Token":  DropLogic.sharedInstance.apiToken!],
        data:       ["sizes":         imageKind.rawValue],
        files:      ["file":          HTTPFile.Data("image.jpeg", imageData, nil)],
        asyncProgressHandler: {
          (progress) in
          progressHandler?(progress.percent)
        },
        asyncCompletionHandler: {
          (result) in

          if let error = result.error {
            subscriber.sendError(error)
            return
          }

          let moyaResponse = MoyaResponse(statusCode: result.statusCode!, data: result.content!, response: result.response)
          subscriber.sendNext(moyaResponse)
          subscriber.sendCompleted()
        }
      )

      return RACDisposable()
    }
  }

Using Just and ReactiveCocoa.

Didn't know about Just :) That's going to be useful. Thanks!

Has there been any work on this yet? :pray:

Not yet, do you want to give it a shot and open a PR @clooth?

I'll give it a try this weekend, need to look around the source a bit so it feels enough Moya-like.
Sent from my iPhone

On 08 Oct 2015, at 18:04, Alexander Schuch<EMAIL_ADDRESS>wrote:
Not yet, do you want to give it a shot and open a PR @clooth?
—
Reply to this email directly or view it on GitHub.

BTW Alamofire now [supports uploading multipart/form-data] natively.(https://github.com/Alamofire/Alamofire#uploading-multipartformdata.)

I would really like this to be part of Moya. Might give it as shot, but I think I need a better understanding of the project before that will work... Is anyone else making progress on this?

Cool, that would be great! Feel free to ask questions in issues.
As for an implementation of this, I figure there's two part "entry points" where you could specify multipart upload: the MoyaTarget protocol or the request function. I think I'd prefer adding another function, or expanding the existing request function to handle it. Not sure of specifics, but you get the idea.

Let's make this happen!
How about creating a subprotocol, MultipartFormUploadable (I think we should get rid of this Moya namespacing too, but that's kinda just me) that inherits from MoyaTarget – we overload request to take the more specific type, and to use it, and require an extra function to vend either an NSData, NSStream or a closure that returns those things to supply the body.
This might be the groundwork for a more strongly typed set of targets that more closely specify their methods of encoding and requesting, though that is perhaps an exercise best left to the reader.

Played around with your ideas a bit, @swizzlr. A problem I'm running into is that if using something like:
public protocol MultipartFormUploadable: MoyaTarget { }

public enum UploadDataProvider {
    case Data(NSData)
    case File(NSURL)
    case Stream(NSInputStream)
}

extension MoyaProvider where Target: MultipartFormUploadable {
    public func request(target: Target, provider: UploadDataProvider, completion: Moya.Completion) -> Cancellable
}

Then your entire target type is then needing to conform to this protocol, or you need a second provider and target type for your multipart endpoints. While it doesn't seem like a necessarily common occurrence with a buffer of common sense, someone could technically call this version of request() with a POST target that is not multipart with a random (valid) data provider, since there's no way to distinguish between multipart and non-multipart enum target cases. This also means that the "original" request() can be called with a multipart case, which is also wrong. Any better ideas for separation and compile-time verification of these types of endpoint targets?

Yeah, this is why I think adding another request function specific to multipart uploading would be the best approach.

@ashfurrow Yeah, that is what I demonstrated above in the extension, but saw potential confusion with. Since the entire enum type must conform to MultipartFormUploadable, there's no way to determine whether a specific enum case should be able to be used for a multipart upload or not. This means it's not "perfectly strict" in that it can't warn or error if you try to misuse it in this way (misuse meaning call the overloaded version of request() in the extension with a data provider). If you do so, you're stuck waiting potentially for the server to WTF at you for trying to upload data to a POST endpoint that doesn't take it, if that will even happen. In short, there's something that we know would at compile time, but can't enforce with the compiler in any way that I can think of, at least with targets as enum types.

Maybe we should not focus on multipart/form-data, but on uploads in general. In Alamofire there are 4 types of uploads:

File
Data
Stream
MultipartFormData

I would say we add some kind of request type, which can be either Request or Upload (we could add  Download too). Based on the request type it would execute the right Alamofire methods with the needed data from the target. That would also mean adding some kind of UploadType enum for all the supported upload types.
This way you maintain the abstraction. If you were adding a request specifically for uploads, you'd be picking the request type when executing a request, but that's something that the target should know.
Please do correct me if I'm wrong, but this seems like a step in the right direction to me.

This makes total sense to me!

On Nov 18, 2015, at 4:49 AM, Guido Hendriks<EMAIL_ADDRESS>wrote:
Maybe we should not focus on multipart/form-data, but on uploads in general. In Alamofire there are 4 types of uploads:
File
Data
Stream
MultipartFormData
I would say we add some kind of request type, which can be either Request or Upload (we could add Download too). Based on the request type it would execute the right Alamofire methods with the needed data from the target. That would also mean adding some kind of UploadType enum for all the supported upload types.
This way you maintain the abstraction. If you were adding a request specifically for uploads, you'd be picking the request type when executing a request, but that's something that the target should know.
Please do correct me if I'm wrong, but this seems like a step in the right direction to me.
―
Reply to this email directly or view it on GitHub.

Makes sense to add the type of request to the target.

Yeah, I'm sorry to say that I don't have time for this after all.

I think, ideally, we'd like to be able to use the same endpoints for both Requests and Uploads, and therefore directly provide the DataProvider as a parameter to the request function. I ran with @JRHeaton's idea of a protocol extension to MoyaTarget, MultipartFormUploadable. I posted some of the implementation below and would love any feedback!
public protocol MultipartFormUploadable: MoyaTarget { }

extension MoyaProvider where Target: MultipartFormUploadable {

    public func request(target: Target, parts: [MultipartBodyPart], completion:Moya.Completion) -> Cancellable {
        precondition(target.method == .POST, "Uploads require Moya.method to be .POST")

        let endpoint = self.endpoint(target)
        let stubBehavior = self.stubClosure(target)
        var cancellableToken = CancellableWrapper()

        let performNetworking = { (request: NSURLRequest) in
            if cancellableToken.isCancelled { return }

            switch stubBehavior {
            case .Never:
                cancellableToken.innerCancellable = self.sendUpload(target, request: request, parts: parts, completion: completion)
            default:
                cancellableToken.innerCancellable = self.stubRequest(target, request: request, completion: completion, endpoint: endpoint, stubBehavior: stubBehavior)
            }
        }

        requestClosure(endpoint, performNetworking)

        return cancellableToken
    }
}

The sendUpload function would take an additional parameter representing a collection of each part of the multi-part upload, with those parts represented by the MultipartBodyPart struct. We could then have some helper function on the Manager that takes that collection and returns an Alamofire request.
public struct MultipartBodyPart {

    public enum DataProvider {
        case Data(NSData)
        case File(NSURL)
        case Stream(NSInputStream)
    }

    public let name: String
    public let provider: DataProvider

    // Additional stream parameters
    public let length: UInt64
    public let fileName: String
    public let mimeType: String
}

    func sendUpload(target: Target, request: NSURLRequest, parts: [MultipartBodyPart], completion: Moya.Completion) -> CancellableToken {
        guard let request = manager.uploadRequest(request, parts : parts) else {
            var cancellableToken = CancellableWrapper()
            cancellableToken.isCancelled = true
            return cancellableToken.innerCancellable!
        }

        return sendRequest(target, request: request, completion: completion)
    }

public extension Manager {

    private func uploadRequest(request: NSURLRequest, parts: [MultipartBodyPart]) -> Request? {

        let formData = MultipartFormData()

        for part in parts {
            switch part.provider {
            case .Data(let data):
                formData.appendBodyPart(data: data, name: part.name)

            case .File(let file):
                formData.appendBodyPart(fileURL: file, name: part.name)

            case .Stream(let stream):
                formData.appendBodyPart(stream: stream, length: part.length, name: part.name, fileName: part.fileName, mimeType: part.mimeType)
            }
        }

        do {
            let data = try formData.encode()
            return self.upload(request, data: data)
        } catch {
            return nil
        }
    }
}

David, could you attach an example of the Ello.Target that would need to use Request and Upload types? I want to be sure I'm following you...

On Nov 18, 2015, at 2:26 PM, David Warner<EMAIL_ADDRESS>wrote:
I think, ideally, we'd like to be able to use the same endpoints for both Requests and Uploads, and therefore directly provide the DataProvider as a parameter to the request function. I ran with @JRHeaton's idea of a protocol extension to MoyaTarget, MultipartFormUploadable. I posted some of the implementation below and would love any feedback!
public protocol MultipartFormUploadable: MoyaTarget { }
extension MoyaProvider where Target: MultipartFormUploadable {
public func request(target: Target, parts: [MultipartBodyPart], completion:Moya.Completion) -> Cancellable {
    precondition(target.method == .POST, "Uploads require Moya.method to be .POST")

    let endpoint = self.endpoint(target)
    let stubBehavior = self.stubClosure(target)
    var cancellableToken = CancellableWrapper()

    let performNetworking = { (request: NSURLRequest) in
        if cancellableToken.isCancelled { return }

        switch stubBehavior {
        case .Never:
            cancellableToken.innerCancellable = self.sendUpload(target, request: request, parts: parts, completion: completion)
        default:
            cancellableToken.innerCancellable = self.stubRequest(target, request: request, completion: completion, endpoint: endpoint, stubBehavior: stubBehavior)
        }
    }

    requestClosure(endpoint, performNetworking)

    return cancellableToken
}

}
The sendUpload function would take an additional parameter representing a collection of each part of the multi-part upload, with those parts represented by the MultipartBodyPart struct. We could then have some helper function on the Manager that takes that collection and returns an Alamofire request.
public struct MultipartBodyPart {
public enum DataProvider {
    case Data(NSData)
    case File(NSURL)
    case Stream(NSInputStream)
}

public let name: String
public let provider: DataProvider

// Additional stream parameters
public let length: UInt64
public let fileName: String
public let mimeType: String

}
func sendUpload(target: Target, request: NSURLRequest, parts: [MultipartBodyPart], completion: Moya.Completion) -> CancellableToken {
    guard let request = manager.uploadRequest(request, parts : parts) else {
        var cancellableToken = CancellableWrapper()
        cancellableToken.isCancelled = true
        return cancellableToken.innerCancellable!
    }

    return sendRequest(target, request: request, completion: completion)
}

public extension Manager {
private func uploadRequest(request: NSURLRequest, parts: [MultipartBodyPart]) -> Request? {

    let formData = MultipartFormData()

    for part in parts {
        switch part.provider {
        case .Data(let data):
            formData.appendBodyPart(data: data, name: part.name)

        case .File(let file):
            formData.appendBodyPart(fileURL: file, name: part.name)

        case .Stream(let stream):
            formData.appendBodyPart(stream: stream, length: part.length, name: part.name, fileName: part.fileName, mimeType: part.mimeType)
        }
    }

    do {
        let data = try formData.encode()
        return self.upload(request, data: data)
    } catch {
        return nil
    }
}

}
―
Reply to this email directly or view it on GitHub.

@colinta pretty much any endpoints that could take optional data. I may not be completely understanding @GuidoHendriks solution, but I'd like to not have to write multiple enum cases for, say a "Create Account" request that may or may not take image data.  Essentially, I want one "Create Account" endpoint to which I can optionally pass one or multiple NSData, NSURL, NSInputStream parameters.
Essentially, I'd like to avoid extraneous enum cases like this...
public enum API: MoyaTarget {

    case CreateAccount(name: String, type: String, description: String)

    case CreateAccountWithImageData(name: String, type: String, description: String, imageData : NSData)
}

extension API  {

    public var requestType: RequestType {
        switch self {
        case .CreateAccount:
            return .Request

        case .CreateAccountWithImageData:
            return .Upload
        }
}

Yup that's about what I was imagining, and I wouldn't want those two endpoints either.

On Nov 18, 2015, at 4:23 PM, David Warner<EMAIL_ADDRESS>wrote:
@colinta pretty much any endpoints that could take optional data. I may not be completely understanding @GuidoHendriks solution, but I'd like to not have to write multiple enum cases for, say a "Create Account" request that may or may not take image data. Essentially, I want one "Create Account" endpoint to which I can optionally pass one or multiple NSData, NSURL, NSInputStream parameters.
Essentially, I'd like to avoid extraneous enum cases like this...
public enum API: MoyaTarget {
case CreateAccount(name: String, type: String, description: String)

case CreateAccountWithImageData(name: String, type: String, description: String, imageData : NSData)

}
extension API  {
public var requestType: RequestType {
    switch self {
    case .CreateAccount:
        return .Request

    case .CreateAccountWithImageData:
        return .Upload
    }

}
―
Reply to this email directly or view it on GitHub.

@drw86312 Why would you need an extra endpoint for that? You could instead just use an optional:
public enum API: MoyaTarget
{
    case CreateAccount(name: String, imageData: NSData?)

    public var requestType: RequestType {
        switch self {
        case .CreateAccount(_, let imageData) where imageData != nil:
            return .Upload
        default:
            return .Request
        }
    }
}

API.CreateAccount(name: "Guido", imageData: nil).requestType      // .Request
API.CreateAccount(name: "Guido", imageData: NSData()).requestType // .Upload

@zdavison Would you mind sharing your solution on manual implementation?

Looking forward use this feature some day. As temporary solution I:

added file property in MoyaTarget protocol:

public protocol MoyaTarget {
     ...
     var file: NSURL? { get }
}

use result of [1] to determine type of request:

    func sendRequest(target: Target, request _request: NSURLRequest, completion: Moya.Completion) -> CancellableToken {
        let request: Request
        if let file = target.file {
            request = manager.upload(_request, file: file)
        } else {
            request = manager.request(_request)
        }
        ...

Hey, guys. Any progress on this issue? Is there any solution that is working and can be used?
Anyway, upvoting!
And thanks for so cool artefact, Moya literally saved me days of work and tons of headache!

Getting in way late to the party here but I second @GuidoHendriks' idea of just adding a RequestType enum with two cases .Upload and .Request and then a second enum, UploadType with four cases: .File, .Data, .Stream, .Multipart.
We could then add two variables to TargetType:
public var requestType: RequestType { get }
public var uploadType: UploadType?

where uploadType would only be checked if requestType returns .Upload. What I like a lot about this approach is it's easy to implement, it keeps the abstraction, and makes migrations much easier since all people now have to do is add the two new variables to conform.
My only concern is as mentioned, how to show progress of a upload request.

@startupthekid I like that.

where uploadType would only be checked if requestType returns .Upload. What I like a lot about this approach is it's easy to implement, it keeps the abstraction, and makes migrations much easier since all people now have to do is add the two new variables to conform.

We could even go as far as adding a default implementation with sensible defaults to the added protocol vars, which would "upgrade" any existing implementations.

Exactly. Anything that doesn't explicitly say they're an upload is just a request. People can opt into the behavior as needed.

I'm thinking we should TargetType generally the same and steal some patterns from Alamofire...
If we add ParameterEncoding to TargetType, then we could describe a multipart like so:
public enum Target {
  ...
  /// Represents a data part upload.
  /// Requires a data part to upload, and the name of the part
  case UploadData(NSData, String, String, String)
}

extension Target: TargetType {
  var parameterEncoding: ParameterEncoding {
    switch self {
    case .UploadPhoto(let data, let partName, let fileName, let mimeType):
      return .Multipart({ formData in
        formData.appendBodyPart(data: data, name: partName, fileName: fileName, mimeType)
      })
    default:
      return .JSON
    }
  }
}

I'm going to spend a little time poking around the internals to see what makes the most sense. Personally, this is my preferred API use case. I think it makes a bit more sense than introducing new abstractions that are ignored by 90% implementations, and also gives the developer a bit more power in handling the encoding on a per-request basis.

Fixed in #483.


Release: 1.1 release video

Checklist

[ ] Agree on Key points to highlight
[ ] Gather screen recordings
[ ] Cut the video

@robmarcer are you able to take the video this release? Hoping the new docs & Premiere Pro way of working should make this super easy. I'm out on Thursday, but around tomorrow if you want a shadow to check it's okay?


BaseSegment defines put_annotation as having return type NoReturn

Expected Behaviour
The return type should be None. NoReturn means that the function never returns (e.g. it always throws an exception) and makes type checkers (e.g. mypy) mark all code following put_annotation as unreachable.
Also applies to put_metadata, patch, and patch_all.
Current Behaviour
These methods breaks type checking in any modules they're used because all code following a call to e.g. put_annotation is marked as unreachable.
Code snippet
with Tracer().provider.in_subsegment('test') as subsegment:
    subsegment.put_metadata('x', 1)
    print("hi")  # marked as unreachable

Possible Solution
Change the return type to None.
Steps to Reproduce
Use the code snippet above and run mypy on the file.
AWS Lambda Powertools for Python version
latest
AWS Lambda function runtime
3.9
Packaging format used
PyPi
Debugging logs
No response

Thanks a lot for filling this Johan, definitely overlooked it. If you have
the bandwidth to make a PR, we can include it in the next release.
Thank you!
On Mon, 13 Mar 2023 at 12:06, Johan Tibell @.***> wrote:

Expected Behaviour
The return type should be None. NoReturn means that the function never
returns (e.g. it always throws an exception) and makes type checkers (e.g.
mypy) mark all code following put_annotation as unreachable.
Also applies to put_metadata, patch, and patch_all.
Current Behaviour
These methods breaks type checking in any modules they're used because all
code following a call to e.g. put_annotation is marked as unreachable.
Code snippet
with Tracer().provider.in_subsegment('test') as subsegment:
subsegment.put_metadata('x', 1)
print("hi"). # marked as unreachable
Possible Solution
Change the return type to None.
Steps to Reproduce
Use the code snippet above and run mypy on the file.
AWS Lambda Powertools for Python version
latest
AWS Lambda function runtime
3.9
Packaging format used
PyPi
Debugging logs
No response
—
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-lambda-powertools-python/issues/2002, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZPQBEEDTGLIBZ26P62YT3W335RRANCNFSM6AAAAAAVY5JAIM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Complier error with ssd_mobilenet_v1_fpn_shared_box_predictor_640x640_coco14_sync_2018_07_03

Hi,
I have retrained the ssd_mobilenet_v1_fpn_shared_box_predictor_640x640_coco14_sync_2018_07_03 model on my own dataset using tf 1.15 and converted it to tflite to run it on the Coral using export_tflite_ssd_graph.py in the object detection API.
When I use toco I get this error:
`Edge TPU Compiler version 14.1.317412892
ERROR: :83 input->params.zero_point != output->params.zero_point (113 != 0)
ERROR: Node number 28 (PACK) failed to prepare.
ERROR: :83 input->params.zero_point != output->params.zero_point (113 != 0)
ERROR: Node number 28 (PACK) failed to prepare.
Compilation failed: Internal error
Internal compiler error. Aborting! `
Any help would be appreciated

I got the same problem. Would highly appreciate any help! Thank you.

Hello Pushkar,
This is not a generic issue, description the error is missing details to reproduce the issue. Can you please share following details to reproduce the issue.

Source of checkpoints and pipeline
How did you qunatize the model ?
have you tried to use /export_tflite_graph_tf2.py

Thanks

Hi Naveen,
Thanks for your attention.

Source of checkpoints and pipeline: tf1 model zoo
I have run a quantized aware training
No. Since this is a tf1 model.

Let me know if you need any more details.
Thanks

Hello Pushkar,
This is not a generic issue, description the error is missing details to reproduce the issue. Can you please share following details to reproduce the issue.
1. Source of checkpoints and pipeline

2. How did you qunatize the model ?

3. have you tried to use /export_tflite_graph_tf2.py

Thanks

Hello Pushkar,
Thanks for the info, I was able to reproduce the issue, let me work on it update back to you.

Hi Naveen,
Thanks.
Looking forward to hearing from you on this soon.

Hello Pushkar,
I have investigated a little bit, seems like the issue is tflite_convert at quantization step. Can you try to do qunatize using Post training quantization and see if the issue is at your end.  if you can share me the exported graph i can try on  my end as well.
Thanks,
Naveen


Resource warning bug for multi procressing pool

  _warn(f"unclosed running multiprocessing pool {self!r}",
ResourceWarning: Enable tracemalloc to get the object allocation traceback```

We removed the multiprocessing pool in orwell


Error "cannot find module 'xxx'" when bundled with webpack

Description
I was unable to configure webpack the way that __non_webpack__require__ is defined, so using bundle always results in error: "Cannot find module". Is it a bug or am I missing something (and if so, how can I make it work)?
Bundled real require looks like this (all requires are replaced to __webpack__require__s, but __non_webpack__require__ is ignored and is always undefined):
function realRequire(modulePath) {
    if (typeof __non_webpack__require__ === 'function') {
        return __non_webpack__require__(modulePath)
    }

    return __webpack_require__("./node_modules/real-require/src sync recursive")(modulePath)
}

Demos that displays this behavior

Demo project 1 (localized example): imitate-real-require.zip
Demo project 2 (usage example): bundle-real-require.zip

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.


Option to allow cursor to pass through window

Operating System

[X] Windows
[X] macOS
[X] Linux
[X] FreeBSD
[X] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] Xbox
[ ] Web Browsers

What feature would you like to be added?
An option to allow cursor clicks to pass through the game window and not take focus. My idea was another cursor mode such as CursorModePassThrough as it would be exclusive of the existing modes.
This would of course only apply to desktop and probably only before Run.
Why is this needed?
Creating a transparent overlay window like: mascot or neko but where the screen is large or where clicking, dragging or keys have no effects and we want to just use the window behind it.
This would be especially required if the window was a full screen window displaying some sort of full screen effect such as the weather or whatever.

This will be possible in GLFW 3.4, instead of 3.3: https://www.glfw.org/docs/3.4/window_guide.html#GLFW_MOUSE_PASSTHROUGH_hint
I'll take a look more but probably we have to wait for GLFW 3.4 stable.

Windows: https://github.com/glfw/glfw/blob/d299d9f78857e921b66bdab42c7ea27fe2e31810/src/win32_window.c#L1951
macOS: https://github.com/glfw/glfw/blob/d299d9f78857e921b66bdab42c7ea27fe2e31810/src/cocoa_window.m#L1481
Linux (X11): https://github.com/glfw/glfw/blob/00967cbb8a4a51ea8ff6f8b8a7efcf1f761cc664/src/x11_window.c#L2713

Oops, on Linux, this requires a new dependency libXext...
https://github.com/glfw/glfw/blob/3eaf1255b29fdf5c2895856c7be7d7185ef2b241/src/x11_init.c#L879-L908


Update docs with shadow dom guide and element passing

Hey maintainers!
I recently found your library and I've liked it a lot. When first reading the docs it was very unclear as to whether I can use it with Shadow DOM without doing too much hackery.
Upon inspection of the source I noticed that it's written very elegantly and does indeed permit my use case.
That being said, this PR adds docs as to how to use it with Shadow DOM or by passing a DOM element.

Thanks for the addition to documentation!


Rest params not working in lambda functions

Consider the following:
public function main() {
    string x = "Foo";

    var fn = function (int i, string... rest) returns string {
        string s = x;
        return s;
    };

    string a = fn(10, "Hello");
}

The above program gives the following error:
error: .::18302.bal:9:23: incompatible types: expected 'string[]', found 'string'

Closing this since this is a duplicate of #10639


Update rules_ios to latest and enable bzlmod

Updates to use rules_ios 3.1.0 and enables bzlmod.
rules_ios is lacking support for Bazel > 6.x: https://github.com/bazel-ios/rules_ios/issues/795

Current blocker:
Generating "rules_ios.xcodeproj"
ERROR: /Users/lpadron/Development/rules_xcodeproj/examples/rules_ios/bazel-output-base/rules_xcodeproj.noindex/build_output_base/external/rules_xcodeproj~override~internal~rules_xcodeproj_generated/generator/xcodeproj/BUILD:12:10: error loading package 'iOSApp': Unable to find package for @[unknown repo 'build_bazel_rules_apple' requested from @]//apple:versioning.bzl: The repository '@[unknown repo 'build_bazel_rules_apple' requested from @]' could not be resolved: No repository visible as '@build_bazel_rules_apple' from main repository. and referenced by '@rules_xcodeproj~override~internal~rules_xcodeproj_generated//generator/xcodeproj:xcodeproj'
ERROR: Analysis of target '@rules_xcodeproj~override~internal~rules_xcodeproj_generated//generator/xcodeproj:xcodeproj' failed; build aborted: Analysis failed

I can look at this Monday.

Per offline, this is good to go in as is (when others approve it).

So it now has two rules_ios CI jobs, both using rules_ios 3.1.0:

One with bzlmod enabled using Bazel 6.4.0
One without bzlmod enabled using Bazel 6.4.0


[QUESTION] V6 Build project with npm instead of yarn

In the tsed cli I chose to build my project using npm.
In package.json my build script is yarn tsc, is that a bug or is it intentional?
Is there any way to use npm in the build script instead? npm tsc seems to be an invalid command.
I'm deploying my server to a heroku app which uses npm, so it's important to only use npm and not mix yarn (yarn: not found).

Replace yarn tsc by npm run tsc ;)
is not intentional, I forgot to use variable on scripts generation.

Makes sense, thanks :) More issue coming your way, trying to take this v6 to production.

Story
Fix the scripts generated by the CLI. Replace yarn by npm when the choosen packageManager is NPM.
See https://github.com/TypedProject/tsed-cli/blob/master/packages/cli/src/commands/init/InitCmd.ts#L236

I released a new version of the CLI which fix this issue :)

Solved with CLI v2.12.0


Rls configuration

Thanks for the package. Is there a way to pass configuration to rls? For example I'd like to try the workspace_mode.
https://github.com/rust-lang-nursery/rls#configuration

Currently no. It probably be fairly trivial to add but I haven't had the time to extend it. I'd accept a PR that did so however.


Simplify tests

Use a shorter constructor with setters instead of passing all
arguments every time.

Thank you for the contribution. I have completely changed tests structure and added a bunch of new ones, so this PR got out of date. Sorry for not getting back to you earlier


Compare with other "field"

Is it possible to compare with another field? There are two places where this could be useful:
Comparing "repeating password / email fields" or comparing dates (e.g one should be before another date). I'd say these are both fairly common in form handling. But I can't seem to figure out how to to either of these.
edit: It seems I can create a custom validator, and use an option to set the field to compare it to. And get that value from the attributes object.

You can validate that two fields are equal but that's it for now: http://validatejs.org/#validators-equality
If you want something more advanced you'd have to write your own validator.

but when single value validation. it's not possible. right?

No, how would that even work?


P2P Game Discovery

Make it possible for users to find new games through peers instead of the server.

Too much overhead.


Correct $PROFILE configuration

When using winget, Oh-my-posh will not add Set-PoshPrompt to path, the execution will fail. The correct configuration can be found in https://ohmyposh.dev/docs/windows#replace-your-existing-prompt

Docs Build status updates of commit 8066e09:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TerminalDocs/tutorials/custom-prompt-setup.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Thanks @Cutano! Great catch - appreciate the update. Merged.


Error with Thumbs.db on Windows

Hi,
I use imagemin-cli 3.0.0 with imagemin image/* --out-dir image but i got the following error:
Error: Error in file: image/Thumbs.db
EPERM: operation not permitted, open 'myFolder\image\Thumbs.db'

I see  that it comes from the thumbnails generated by Windows 7 but I think this file should be automaticaly black-listed from the list of the files to process.

Yup, agreed.

We could use junk to filter out unwanted system files. PR welcome :)


Encoding issue

Hello,
i'm trying to generate pdf using your module. Charset was setted to UTF8, but report looks agly(with question symbols). Have you  any idea what can be wrong.
Environment

OS: ubuntu 12
Node version (node -v): 6.3.0
package version: 3.2.1

Could be related to #551. But that was fixed. I don't know what could be wrong. Can you provide a working example when I can run locally and reproduce?

Closing this ticket because there has been no response. We can reopen if needed.


Refactored initChannel to allow subclasses customize the channel handlers

This small change will allow us to implement port unification (socketio and customer tcp on a single port).

Can you merge this request? Let me know if you have any questions on this change.
Thanks.


How to implement with CodeIgniter

Great Library,
Is this easy to implement into Codeigniter and if so how?

You could very easily implement this into CodeIgniter, you can actually just drop it right into your library folder and then start using it:
$this->load->library('When');

$this->when->recur('19970902T090000')->rrule('FREQ=DAILY;COUNT=10');

while($r = $this->when->next())
{
	echo $r->format('c') . "<br />";
}


Text and button animation

Description
Added text and border button animation and a lamp effect
Fixes:  #49

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x ] I have made this from my own
[ x] I have taken help from some online resourses
[ x] My code follows the style guidelines of this project
[ x] I have performed a self-review of my own code
[ x] I have commented my code, particularly in hard-to-understand areas
[x ] I have made corresponding changes to the documentation
[x ] My changes generate no new warnings

@Rohitha-pudu Hey, the input field is also expanding along with text. Don't animate input field.


Use jspngopt and pako to create reproducible PNG files for Chrome as well

The combination of jspngopt (which I just developed for this task) and pako should eliminate possible causes for different PNG encodings, although the core reason for #325 remains unknown.
Pako has poorer compression rates than native libz, but optimization can counter that effect, and actually reduce the size of the screenshots (from 1736 to 1120 kB).
The screenshots for LimitControls and UnsupportedCmds on Firefox used to exhibit subpixel rendering before, for reasons unknown.  The regenerated versions don't exhibit this.  See #324 for a discussion. Arrays-chrome.png has changed as well, since the generation of Chrome screenshots was disabled during the work on #330. Apart from this, all screenshots remain the same with regard to their image content, which I verified by running optipng on the directory from these two branches before comparing them.

Thanks for digging into this and fixing issue.  It's weird that only some images would exhibit subpixel rendering.  Here are some screenshots so that people can the before/after for LimitControls.  The reason why all the images changed is b/c the compression changed.
w/ subpixel rendering

w/o subpixel rendering (still antialiased though)

@gagern did you notice an appreciable difference in run times?

Perhaps @JeffEverett created those two screenshots using Selenium directly, without the docker, therefore taking shots from his local Firefox setup. This is the most likely explanation I can think of.
This patch here increases the time to take screenshots from 45s to 168s. A factor of two in that is due to the fact that we're now using two different browsers, so the optimization causes another factor two increase in processing time, approximately. I know that jspngopt could be made faster using asynchroneous zlib calls, but since here we're using pako not zlib, that won't help for this use case. What I probably could do is work out the parameter combinations which actually yield the smallest results for our inputs, and then restrict the search space to that.


chore: next vote after block pushed

Not giving up on next voting a value that is already cert voted and pushed to the chain

So the actual bug here is this condition because we wrongly set last_cert_voted_value_ to NULL_BLOCK_HASH right after we push block into the chain....
if (last_cert_voted_value_ != NULL_BLOCK_HASH) {
in first finish step. This is fixed in my branch so I think it will fix the issue

@mfrankovi  this PR is outdated, having been superseded by all the pbft simplification changes.  So I will close this PR.


SCRUM-2550 Duplicate key fix

The name fields (displayText / formatText) are not sufficient to determine identity for the nameSlotAnnotations attached to any single gene/allele for FB annotations.


Add FlowV2 to supportedAmendments

I need to figure out how to test this

[Current coverage][cc-pull] is 69.37%

Merging [#1742][cc-pull] into [develop][cc-base-branch] will decrease coverage by 0.03%

2 files (not in diff) in src/ripple/core/impl were modified. more

Misses +10
Hits -10

2 files (not in diff) in ...rc/ripple/beast/nudb were modified. more

Misses +4
Hits -4

3 files (not in diff) in src/ripple were modified. more

Misses +9
Hits -9

@@            develop      #1742   diff @@
==========================================
  Files           856        856
  Lines         62543      62543
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits          43411      43388    -23
- Misses        19132      19155    +23
  Partials          0          0

[][cc-pull]

Powered by Codecov. Last updated by [5dd8f28...f84c48c][cc-compare]
[cc-base-branch]: https://codecov.io/gh/ripple/rippled/branch/develop?src=pr
[cc-compare]: https://codecov.io/gh/ripple/rippled/compare/5dd8f282905c70d92790fde3f1d384e43c925ff3...f84c48cc7391d0cdf435e6c0b1368bae2a2c4c5d
[cc-pull]: https://codecov.io/gh/ripple/rippled/pull/1742?src=pr

There's nothing to test. I'm assuming that 5CC22CFF2864B020BD79E0E1F048F63EF3594F95E650E43B3F837EF1DF5F4B26 is the value returned from feature("FlowV2")?

@nbougalis Yes, that's how I got the hash. I wanted to try to turn the amendment on locally to make sure I got everything right so we don't have to do another rc.

Here's your test, approximately:

Here's your test, approximately:
void testSupportedAmendments()
{
    for(auto const& amend : supportedAmendments())
    {
         expect(amend.substr(0, 64) == feature(amend.substr(65)));
    }
}

Pushed a unit test for supported amendments.

Looks good, assuming CI passes. :+1:


[stable/mail2most] added mail2most chart

Signed-off-by: Carsten Seeger<EMAIL_ADDRESS>What this PR does / why we need it:
This PR adds a new chart for mail2most a small tool to parse mails, filter them and send them to mattermost
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @prydonius

@cpanato, @jlegrone is there anything that needs to be changed ?

@cpanato , @jlegrone more suggestions here ?

@cpanato , @jlegrone , @prydonius  is there anything that i can do to help ?

/ok-to-test
cc @cpanato

@cpanato can you give me a hint what to do to make the pull-charts-e2e  work ? For me it looks like an internal script error.

@cpanato , @jlegrone , @prydonius anything i missed here ?

/test pull-charts-e2e

@cpanato anything left to do ?

@cpanato ping

Hi 👋 new charts are no longer accepted to stable or incubator. See Status of the Project and Deprecation Timeline for more info about that.
Good news is you can host a Helm chart yourself on GitHub, use the same tools as this repo does for automatic Chart testing and releasing, and list your Helm repo on https://helm.hub.sh. Follow this issue for info about existing guidelines and upcoming improvements: https://github.com/helm/charts/issues/7800

@cseeger-epages it's been a while, but you put a lot of work into this chart. Would love to see it up on the Hub. Ping us on Slack if you need any help with setting that up

@cseeger-epages you can copy this pr and open in the mattermost-helm repository. We can host that if you would like

hi guys sorry for the long time without anything going on here. Ill take a look at this as soon as i have time. The chart will definetly be ready, maybe i will rework this for helmv3 since i use the beta for quite some time. @cpanato ill take a look where to host this. Thanks for your help guys you helped me a lot to understand helm. :+1:


Suricata IPS does not seem to drop

Hi!
I am trying OPNSense:
OPNsense 17.1.7-amd64
FreeBSD 11.0-RELEASE-p10
OpenSSL 1.0.2k 26 Jan 2017
On an APU2C4 with Suricata enabled, IPS enabled, promiscious enabled, interface; WAN,new rules installed and enabled ET-scan and more.
I also changed the rules from alert to drop.
No matter how hard I try: I don't see any blocks in my alerts tab using nmap -sS/nmap -sT against the WAN interface from a VPS to my OPNsense box.
I also noticed that I see no alerts at all, only STREAM alerts but no drops (I also expect Dshield and Comrpomised alerts from chinese ip adressess but no alerts at all).
My questions:

am I missing something to trigger the alerts?
I did the the eicar download before with the OPNsense test rules but no other rules are triggered
I have a VLAN interface connected to igb0 and use hardware offloading, all other hard offloading is disabled (by default) should I disable the VLAN interface? I also use port forwarding for SSH, HTTP & HTTPS can this cause issues?

I haven't experienced this with PFsense with suricata and/or snort.
Any pointers would be more then welcome :)

Also opted here; https://forum.opnsense.org/index.php?topic=5261.0 but did not get a very clear answer from the helping hand ;)
If it is related to $HOME_NET and $WAN_NET variables not filled in correctly; how can I achieve this via the GUI and if this has to be changed by hand on the filesystem, how is it restored after an upgrade?

@chiel1980 please try the test rule first and check if eicar blocks, our homenet is correctly configured. see also https://forum.opnsense.org/index.php?topic=4711.msg21016#msg21016

Hi Ad, I enabled the plugin, download & update and try to test it from a box behind my firewall/IPS:
beheerder@NAS:~$ wget 'http://www.eicar.org/download/eicar.com.txt'
--2017-05-30 12:38:34--  http://www.eicar.org/download/eicar.com.txt
Resolving www.eicar.org... <IP_ADDRESS>
Connecting to www.eicar.org|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response...

And yes it triggers an alert:
Alert details
Timestamp
	2017-05-30T12:38:34.731644+0200
Alert
	OPNsense test eicar virus
Alert action / sid
	7999999
Source IP
	<IP_ADDRESS>
Destination IP
	<IP_ADDRESS>
Source port
	80
Destination port
	64276

But still no other alerts are triggered (like dshield, port scans, etc):

and my search for scans:

What else can I try?

Like I explained in the forum thread, a lot of the rules trigger when coming from the external network and go to the home network (<IP_ADDRESS>/16,<IP_ADDRESS>/8,<IP_ADDRESS>/12).
Suricata shouldn't be very noisy normally.
If one rule functions, they all should.

Hi Ad, thanks for your reply.
I tested that with nmap and get no results, I also enabled the dshield, feodore, etc. no alerts.
Is there any way I can troubleshoot this and can you show me an example of your own setup with a nmap from the outside against your WAN interface and that it triggers an alert? I simply can not reproduce alerts by just settings some options in the GUI.
Just trying to get it to work and the 'If one rule functions, they all should.' might be true but since it does not work on my box I want to troubleshoot it.

I checked the suricata.log in /var/log and for example I see:
30/5/2017 -- 12:36:16 - <Error> - [ERRCODE: SC_ERR_UNKNOWN_PROTOCOL(124)] - protocol "t" cannot be used in a signature.  Either detection
for this protocol supported yet OR detection has been disabled for protocol through the yaml option app-layer.protocols.t.detection-enable
d

Not sure if that can be the culprit?

you can add your wan network manually to HOME_NET (/usr/local/etc/suricata/suricata.yaml ) and restart suricata (service suricata restart) then test again.
Enabling suricata on your LAN interface and forwarding all traffic to a machine in your local network should also work.
Please inspect the rules you want to match first (they're not that difficult the read) and fabricate traffic that matches that.

Adding the WAN interface to $HOME_NET does trigger alerts (like port scans).
Since I have ZIggo/Vodafone with a dynamic ip, how can I ensure that this behaviour stays this way? Does adding the LAN interface also have the same effect?

I've added my LAN and GUEST interfaces and that seems to get some more alerts and blocks (especially for my port forwarded hosts).
I am happy :)
If you want, I could help writing some documentation so these questions can be prevented in the future? (seeing as I am not the only one with these questions ;) )

If you can spare some time to improve the documentation on this subject, that would be great. We're using Sphinx (http://www.sphinx-doc.org/en/stable/index.html) for our documentation (https://docs.opnsense.org/manual/), but any other documentation format is ok too.
Please send your contribution to<EMAIL_ADDRESS>and we'll try to incorporate it asap.
The best thing is probably to add a section about (basic) setup, as far as I see that's missing from our documentation at the moment.


Re-runs animation on every render

Trying to use react-anime for mounting/unmounting of components but animations are re-run every time component is re-rendered, regardless if something changes in child or <Anime ...> definition.
e.g. <Anime opacity={[0, 1]}>hello</Anime> will rapidly flash 'hello' each time you run setState or e.g. props are changed via Redux. This makes the library a bit useless, particularly for Redux, as component must manually be cached and wrapped to avoid this behaviour.
Maybe a feature to limit animations to only run when mounting/unmounting could fix it temporarily.
Version: 2.0.1

@echoghni is there any source code you could provide for your workaround? Changing the props of my component the animation is placed in seems to force a re-render

I seemed to stop my animation from "re-looping" by placing my Anime components isolated in their own PureComponent and setting up the shouldComponentUpdate lifecycle event to return false. This prevents my component from ever re-rendering after its' initial mount'
shouldComponentUpdate(nextProps, nextState){     // Prevent Anime from rerendering animation     return false;   }

@danieljodeci can you share how you did this? I isolated the component but the animation no longer works.

I have created a workaround that solves the issue for my case of fading an element in only on the first render. If given the chance, I could make this more generic to support all opacity cases,  set the ANIMATION_DURATION set to the duration prop value instead, and merge the fix into the library.
export const AnimeWrapper: React.FC = () => {
  const [startOpacity, setStartOpacity] = useState<number>(0)
  useEffect(() => {
    const delayOpacity = setTimeout(() => setStartOpacity(1), ANIMATION_DURATION)
    return () => clearTimeout(delayOpacity)
  }, [])

  return (
      <Anime
        duration={ANIMATION_DURATION}
        opacity={[startOpacity, 1]}
      >
        {children}
      </Anime>
  )
}


Adds external client

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description

Adds an option to receive an external auth0 client as prop

This could be used to able users (and myself) to have a singular auth0Client that would be used both in the react context (within auth0 provider) and outside of it in JS references.

My use case: I'm initializing many API clients outside of the react scope that needs access to jwt for auth, this jwt is used bother in JS and in the react scope and should be the same.
References
Testing
Describe how this can be tested by reviewers:

This should be testable with the current test suites but with an externally created client.

Checklist

[V] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
[V] All active GitHub checks for tests, formatting, and security are passing
[V] The correct base branch is being used, if not master

Hi @EdenTurgeman - thanks for raising this
This has come up a few times before. Have a look at https://gist.github.com/adamjmcgrath/0ed6a04047aad16506ca24d85f1b2a5c for an explaination of why we don't provide this feature and some workarounds for your use case


Top padding

Hey great library if you could add the image editing in terms of padding around would be genius

check version 2


As a CIF Administrator, I want to see help text of form fields, so that I understand what it is and how it's calulated

Description:
The rules for some calculated fields are getting too complex even for someone familiar with the CIF program. Tooltips are prepared for fields on the forms below to provide more clarity to users.

Budgets, Expenses, & Payments
Milestone Reports
Emissions Intensity Report

Acceptance Criteria:
Given I am a CIF administrator
When I hover over the tooltip icon next to a field listed in the Tooltips for Calculated Fields document
Then I see contextual help text for the field
Development Checklist:

[x] Add ui:tooltip object to the UISchema of each of these forms and pass the related context to it
[x] Add tests
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

Hey team! Please add your planning poker estimate with Zenhub @BCerki @dleard @gurjmatharu @JoshLarouche @mikevespi @sam-warren

For the fields that have multiple bullet points, does all the text go in one tooltip?

@BCerki With the current tooltip implementation we only have one tooltip per field, So I'm assuming we can use an HTML list tag to display multiple bullet points.

Great question, @BCerki! Yes.
Thanks @Sepehr-Sobhani for making it possible. :)

@pbastia This one is already in test.


Use daemon thread instead of user thread

Usage of user thread prevent application's main thread from exiting.

@Misterhex This project is not being actively maintained. We don't plan on creating any new releases going forward.
See the noticed at the top of the README:
Use of this library is strongly discouraged. Providing a library that essentially disables or
bypasses a major facet of inter-application communication security, while convenient for
development, also makes it easy for developers to deploy insecure applications to
production. Platforms like Cloud Foundry have made it easier to centralize SSL certificate
management at an operations level, eliminating any need for a library like this.

What's your use case for this library?

@scottfrederick
Hi, we are using this in our testing environment to trust self signed certificates.
When adding this to classpath, we noticed SslCertificateTruster is spawning a user thread in the executor threadpool.
This thread caused our main thread not to exit and block indefinitely.

@Misterhex I'm sorry that you're having problems with the library, but I suggest you use one of the alternative instead of patching the lib.
One good alternative is to add the self-signed cert to the list of BOSH trusted certs. If you are using Pivotal Cloud Foundry, you can extract the Ops Manager root CA cert and add that to the trusted certificates.

@scottfrederick no problem scott, thanks for getting back.


[Event Request] codeunit 550 "VAT Rate Change Conversion" - OnAddNewSalesLineOnAfterNewSalesLineInit

Reference to the old issue marked as complete:
https://github.com/microsoft/ALAppExtensions/issues/19514
Not included in the Build ID 48357 (Update 1 for BC 2022 Wave 2)
please add new event in codeunit 550 "VAT Rate Change Conversion"
[IntegrationEvent(false, false)]
local procedure OnAddNewSalesLineOnAfterNewSalesLineInit(SalesLine: Record "Sales Line"; var NewSalesLine: Record "Sales Line")
begin
end;

local procedure AddNewSalesLine(SalesLine: Record "Sales Line"; VATProdPostingGroup: Code[20]; GenProdPostingGroup: Code[20])
var
    NewSalesLine: Record "Sales Line";
    OldSalesLine: Record "Sales Line";
    SalesHeader: Record "Sales Header";
    OldReservationEntry: Record "Reservation Entry";
    NewReservationEntry: Record "Reservation Entry";
    OldItemChargeAssignmentSales: Record "Item Charge Assignment (Sales)";
    NewItemChargeAssignmentSales: Record "Item Charge Assignment (Sales)";
    VATRateChangeLogEntry: Record "VAT Rate Change Log Entry";
    RecRef: RecordRef;
    NewLineNo: Integer;
    QtyRemainder: Decimal;
    AmountRemainder: Decimal;
    RoundingPrecision: Decimal;
begin
    if not GetNextSalesLineNo(SalesLine, NewLineNo) then
        exit;
    with NewSalesLine do begin
        Init;
        NewSalesLine := SalesLine;
        "Line No." := NewLineNo;
        "Quantity Shipped" := 0;
        "Qty. Shipped (Base)" := 0;
        "Return Qty. Received" := 0;
        "Return Qty. Received (Base)" := 0;
        "Quantity Invoiced" := 0;
        "Qty. Invoiced (Base)" := 0;
        "Reserved Quantity" := 0;
        "Reserved Qty. (Base)" := 0;
        "Qty. to Ship" := 0;
        "Qty. to Ship (Base)" := 0;
        "Return Qty. to Receive" := 0;
        "Return Qty. to Receive (Base)" := 0;
        "Qty. to Invoice" := 0;
        "Qty. to Invoice (Base)" := 0;
        "Qty. Shipped Not Invoiced" := 0;
        "Return Qty. Rcd. Not Invd." := 0;
        "Shipped Not Invoiced" := 0;
        "Return Rcd. Not Invd." := 0;
        "Qty. Shipped Not Invd. (Base)" := 0;
        "Ret. Qty. Rcd. Not Invd.(Base)" := 0;
        "Shipped Not Invoiced (LCY)" := 0;
        "Return Rcd. Not Invd. (LCY)" := 0;
        OnAddNewSalesLineOnAfterNewSalesLineInit(SalesLine, NewSalesLine);

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 49620.


Kernel restarted

I have some other problems to run the notebook CLS-DE.ipynb. If I use  conda and install the default pytorch (1.3.1), after the command
exp.finetune_lm.train_(cls_dataset, num_epochs=20)
I get following error message:
ImportError: /tmp/torch_extensions/forget_mult_cuda/forget_mult_cuda.so: undefined symbol: _ZN3c106Symbol14fromQualStringERKSs
Then I installed pytroch from the pytorch channel as follow:
conda install pytorch=1.3.1 torchvision cudatoolkit=10.0 -c pytorch
The issue with "undefined symbol" is gone, but the kernel was restarted during the first epoch of exp.finetune_lm.train_(cls_dataset, num_epochs=20)
Is this known problem? Following is maybe the relevan python modules:
$ conda list| egrep 'torch|^fastai|cuda|nvid'
_pytorch_select           0.2                       gpu_0
cudatoolkit               10.0.130                      0
cudnn                     7.6.5                cuda10.0_0
fastai                    1.0.61                        1    fastai
nvidia-ml-py3             7.352.0                    py_0    fastai
pytorch                   1.3.1           cuda100py37h53c1284_0
torchvision               0.4.2           cuda100py37hecfc37a_0

Thanks.

I fixed the kernel restarting after I use CUDA 9.2 instead of CUDA 10.0. It seems the model doesn't like the latest cuda version. Now the notebook runs properly to the end.


Refresh tooltip

Tooltip box is annoying and hard to notice specially on a back background. I think its better to show value as part of the label text like this

TMPE.zip
Note
in the prev PR tooltip would cause exception when CS is loading because things are not initialized. It can't even tell if it is visible or not. guarding the code like this would avoid the exception:
if (parent.containsMouse)
  parent.RefreshTooltip();

But still the tooltip is hard to notice.

Ok, so for DLS it will also display it like that, I suppose?

Ok, so for DLS it will also display it like that, I suppose?

yep


How to display "Dropbox", "Google Drive" and "Documents"?

In my test, only "iCloud Drive" is shown under Locations. So how to display "Dropbox", "Google Drive" and "Documents" ?
FYI, I just test on simulator, does it make sense?

Do I have to install "Dropbox", "Google Drive" apps on my device to make these shown under Locations?

...uh, yes. Of course you have to have an app installed for it to show up. Document providers for 3rd party services are not built into iOS they are provided by apps.

OK，got it. Thanks very much!

In the real device, the menus was shown at the left-top corner. Is there any way to locate it at the bottom & center-horizontal of the screen? TIA

It should be v2, "react-native-document-picker" : "^2.1.0", right?

The menu will be removed in the next version.
For v2 see the iPad portion of the example in the README:
https://github.com/Elyx0/react-native-document-picker#example


Allow consumer INFO json to be directly used as --config to create an identical consumer

For convenience and compatibility with full INFO json response, adding a consumer by config should work identically for these two documents:
The value of the config element from INFO:
{
  "ack_policy": "explicit",
  "ack_wait":<PHONE_NUMBER>0,
  "deliver_policy": "all",
  "durable_name": "bobo",
  "filter_subject": "stl.tx",
  "max_ack_pending": 1000,
  "max_deliver": -1,
  "max_waiting": 512,
  "replay_policy": "instant",
  "num_replicas": 0
}

INFO full document:
{
  "stream_name": "TX-FEED",
  "name": "bobo",
  "config": {
    "durable_name": "bobo",
    "deliver_policy": "all",
    "ack_policy": "explicit",
    "ack_wait":<PHONE_NUMBER>0,
    "max_deliver": -1,
    "filter_subject": "stl.tx",
    "replay_policy": "instant",
    "max_waiting": 512,
    "max_ack_pending": 1000,
    "num_replicas": 0
  }
...
}

According to @ripienaar , stream add already implements this convenience, but as of 0.35.0 of CLI, using the full document (as above) will go silently, but will create a consumer named "bobo" with all defaults (including default expiry).
/cc: @bruth

Done in https://github.com/nats-io/natscli/pull/714
It's quite scary though, I was overruled in requests to type or version these various structs, so we are now in a situation where {} is a valid configuration for consumers.
You can literally send in a stream info output into consumer create, it will create a thing and its impossible to really detect and there's now no sane kind of validation that can be done in schemas since even empty object is valid.
Had these data structs been typed we could have detected errors, for now its definitely a chance or just random weird things happening when passing in json files like this.

@ripienaar The stream_name from the json file is not used. When using
nats consumer add --config test.json
The question "Select a Stream" is asked

Yes it only uses the config. You need to supply the stream


Smart completion - Should not show dialog if no values

It can show this empty dialog with default value

The exceptionHandler has no value and there should be no dialog


Fix bug for auto save behavior on change page

Description
When saving formData for statefull app the http request was not cancelled if the saga was cancelled (takeLatest). This would lead to the user beeing stuck on the same page if the Naviagtion was triggered two times in a row on slow internett.
Related Issue(s)

closes #1313

Verification/QA

Manual functionality testing

[x] I have tested these changes manually
[ ] Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
[ ] No testing done/necessary

Automated tests

[ ] Unit test(s) have been added/updated
[x] Cypress E2E test(s) have been added/updated
[ ] No automatic tests are needed here (no functional changes/additions)
[ ] I want someone to help me make some tests

UU/WCAG (follow these guidelines until we have our own)

[ ] I have tested with a screen reader/keyboard navigation/automated wcag validator
[x] No testing done/necessary (no DOM/visual changes)
[ ] I want someone to help me perform accessibility testing

User documentation @ altinn-studio-docs

[ ] Has been added/updated

[x] No functionality has been changed/added, so no documentation is needed
[ ] I will do that later/have created an issue

Changes/additions to component properties

[ ] Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
[x] No changes made

Support in Altinn Studio

[ ] Issue(s) created for support in Studio

[x] This change/feature does not require any changes to Altinn Studio

Sprint board

[ ] The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
[ ] I don't have permissions to do that, please help me out

Labels

[ ] I have added a kind/* label to this PR for proper release notes grouping
[ ] I don't have permissions to add labels, please help me out

Reproduced the issue and confirmed it is fixed 👍


platform: add Trailers type for better classification

Description: Allows for better scoping of header types; in this case, specifically for advanced filters.
Risk Level: Low
Testing: CI
Signed-off-by: Mike Schore<EMAIL_ADDRESS>

@rebello95 I think those are all already correct because they're already specific Request~ or Response~ variants.

Ah right, good call

thanks @rebello95!


Automatic dns resolver

In the android settings there is also an option to use the dns provider provided by the network which in some cases you are required to use, which makes it better to use automatic rather than completely turning private dns off.

Implemented in Release 1.1.

Hi, Thanks for the app.
I use a private DNS to block annoying ads, this is a gem 🔥.
Can you please explain more on what this "Enable Auto" function does?

Well I use the automatic dns resolver when I am connected to my school wifi, because that network forces you to use their dns resolver, so if you manually override that within the settings using manual dns resolver you cannot connect to the internet. Ao then I switch to automatic dns resolver to automatically use their dns resolver and when I get back home I can now immediately switch back to my nextdns profile.
If you have more questions, you can add me on discord with stackedunderflow


robot_server using unix domain socket vs port

The usage of a unix socket for the server (rather than a port) was an arbitrary decision made for unclear reasons about 3 years ago. Unless we can think of a good reason to remain on a unix socket, it might make sense to switch over to doing something a little more conventional
This would require changes to the NGINX config.

Uvicorn recommends using domain sockets for deploying with nginx.
See: https://www.uvicorn.org/deployment/#running-behind-nginx


chore: release main

:robot: I have created a release beep boop
renderer: 1.0.1
1.0.1 (2023-12-22)
Bug Fixes

readme (9839258)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/pavophilip/react-shader-fiber/releases/tag/renderer-v1.0.1 :sunflower:


quality-gates integration test randomly fails: Failed to check that the project exists via the API.

It appears that the following check whether a project exists via configuration-service fails in the quality-gates integration test:
https://github.com/keptn/keptn/blob/15978523db13e22c64923cccee9e8cc4d7c98647/test/test_quality_gates_standalone.sh#L60-L79
Output is:
Creating a new project without git upstream
WARNING: Creating a project without Git upstream repository is not recommended.
You can configure a Git upstream repository using:
keptn update project PROJECTNAME --git-user=GIT_USER --git-token=GIT_TOKEN --git-remote-url=GIT_REMOTE_URL
Starting to create project
ID of Keptn context: b679c585-09db-4862-ab69-f447d43e4b27
Project musicshop created
Stage hardening created
Shipyard successfully processed
Failed to check that the project exists via the API.

What's weird is that it randomly fails, e.g.: https://travis-ci.org/github/keptn/keptn/builds/698829804

I don't think it's a timing issue, because we have a sleep 10 after the create project CLI call.

We do not see this issue anymore.


Added complex example

A more complex example of redux integration with nested StackNavigator / TabNavigator structure. Creating pull request as agreed with @grabbou here https://github.com/react-community/react-navigation/issues/179#issuecomment-278584750.

Hi @ericvicenti @hasLandon, I've pushed the code changes requested. Still having some issues with duplicate module declarations running inside the react-navigation project. Will look into this asap

I am going to close this pull request as it has changes requested for more than a month. Feel free to re-open it / resubmit when you get time to address the changes!
Thank you for your time!

@grabbou new pull request created here #1624


Software detection

Can we detect visual studio code, atom and others so that we can add app launchers automatically?

This is normally done by inspecting the registry (on Windows platform, that is) - like searching for HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\VisualStudio
To solve this right we would have to make a platform independent implementation, something we are not supposed to do now. I would propose to use Monterey's own registry of tiles instead and encourage users to configure these tiles themselves. We should provide examples for that in https://aurelia-ui-toolkits.gitbooks.io/monterey-overview/content/monterey_tiles/app_launcher.html

Yeah, you should be able to install the app launchers, and somehow set one as your preferred editor / browser.


Introduce a new lefthand nav for the cases detail pages

https://trello.com/c/qzsoT0EX/1405-left-nav-for-cases
Description
This PR brings the top case navigation on the current service to the left hand side, and also provides hyperlinks to navigate the cases landing page.

Checklist:

[ ] Have you documented your changes in the pull request description?
[ ] Does the change present any security considerations?
[ ] Is any gem functionality overloaded? Eg: Devise controller methods being overloaded.
[ ] Has acceptance criteria been tested by a peer?
[ ] Has the CHANGELOG been updated? (If change is worth telling users about.)

General testing (author)

[ ] Test without JavaScript
[ ] Test on small screen

Accessibility testing (author)

[ ] Works keyboard only
[ ] Tested with one screen reader
[ ] Zoom page to 400% - content still visible
[ ] Disable CSS - does content make sense and appear in a logical order?

Codecov Report

Merging #1915 (03a9495) into master (9ca60a5) will decrease coverage by 46.89%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1915       +/-   ##
===========================================
- Coverage   61.88%   14.99%   -46.90%
===========================================
  Files         402      402
  Lines        9372    11658     +2286
  Branches     1180      574      -606
===========================================
- Hits         5800     1748     -4052
- Misses       3318     9856     +6538
+ Partials      254       54      -200

Impacted Files
Coverage Δ

app/helpers/investigations/display_text_helper.rb
25.39% <ø> (-47.62%)
:arrow_down:

app/models/role.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/contact.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/accident.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/incident.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/forms/comment_form.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/forms/sign_in_form.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/helpers/search_params.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/unexpected_event.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/policies/product_policy.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 247 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca60a5...03a9495. Read the comment docs.


Fix #610: Cancel out Django's style on lists

Upstream PR: https://github.com/select2/select2/pull/4226
If it's merged in a timely fashion, we should release the upstream fix instead of this patch.


Docs : Fix Slides typo errors

complete Dependency Injection part
compete LazyLoading part

a full review of ChangeDetection section is coming soon ...

Ready to merge!

Merged, thanks for your contribution @JRPoinsot


Support const.py move

See https://github.com/home-assistant/home-assistant/pull/20945. Fixes https://github.com/gerard33/home-assistant/issues/7

Thanks. Solved it a bit different in d5d5c97 so the component also works on HA <= 0.88.

Looks great.


FileWriter sets TotalByteSize to 0

When using the FileWriter, the generated row group metadata sometimes has a  TotalByteSize of 0 even though the row group contains multiple column chunks.  After looking through the code, it appears that the TotalByteSize is set to 0 in FlushRowGroup(…) here:
fw.rowGroups = append(fw.rowGroups, &parquet.RowGroup{
	Columns:        cc,
	TotalByteSize:  0,
	NumRows:        fw.rowGroupNumRecords(),
	SortingColumns: nil,
})

Is there a specific reason the TotalByteSize is being set to 0?
If not, could one possible solution be to set the TotalByteSize to the sum of each column chunk's TotalCompressedSize for an accurate estimation of the size?

Based on documents TotalByteSize: Total byte size of all the uncompressed column data in this row group *
Also, we keep track of the uncompressed size of each chunk in column chunk metadata. (ColumnChunk.MetaData.TotalUncompressedSize) the size for each chunk contains header size as well, so we can put the sum in TotalByteSize.
I need to confirm this with a valid parquet file generated by the Java version. if you have a sample please share, if not for me it takes a lot of effort to create the sample (I am no longer working with the Parquet files)

Okay sounds good - here's a valid parquet file for testing: parquet_test_file.zip

Hey @fzerorubigd, is there a time estimate on when this will be fixed?


Upgrade our ElastiCache instances

Quoting an email from AWS:

You are receiving this message because you have one or more Amazon ElastiCache for Redis clusters running version 3.x.x in the EU-WEST-1 Region.
ElastiCache for Redis version 3, originally released in October 2017, will reach its End Of Life (EOL) on July 31, 2023. We are providing you this notice to give you sufficient time to upgrade your Redis cluster(s). We recommend that you upgrade your cache cluster(s) to the latest available ElastiCache for Redis version before July 31, 2023. At this time, the latest version is 6.2, and it contains features including: JSON support, Redis Streams, performance improvements (including Enhanced IO), and data tiering as well as a various security and reliability updates.
You can initiate the upgrade of your cluster(s) immediately using the AWS Console, CLI or API. The upgrade process is fully managed and will upgrade each Redis node in the cluster to the new version. Depending on the cluster configuration, the upgrade process may lead to brief interruptions to application availability. Prior to upgrading, we recommend taking a snapshot of your cluster [1] during a scheduled maintenance window. See the upgrade guide for more information [2]. While most applications will not require any modification because of this upgrade, we recommend you check the version behavior compatibility page [2] and test your application with the new version before upgrading. To learn more about upgrading ElastiCache for Redis major cluster versions, review the Upgrading Redis Versions page [3].
Amazon ElastiCache for Redis instances using Version 3:
archivematica
archivematica-staging
We want to make you aware of the following milestones associated with ElastiCache for Redis Versions 3.x.x that are reaching EOL:

From July 31, 2022 until July 31, 2023 - You can initiate upgrades of ElastiCache for Redis Version 3 instances to Redis 6.2 or higher at any time [3].
From May 1, 2023 - you cannot create new ElastiCache for Redis 3.x.x instances from the AWS Console.
From July 31, 2023 - Redis Version 3 will not be available in the ElastiCache Console, CLI, API or CloudFormation. We will automatically upgrade all ElastiCache for Redis 3.x.x clusters to Redis 6.2 within the next maintenance window after July 31, 2023.

If you have any questions or concerns, please reach out to AWS Support [4].
[1] https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/backups-manual.html
[2] https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/VersionManagementConsiderations.html
[3] https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/VersionManagement.html
[4] https://aws.amazon.com/support

Closing as no longer applicable (we're past Redis v3).


[WIP] Test commit to see checkpoint CI failures

Just a test PR to see the checkpoint restore failures in F29 as they have not been reproducible on my F29 system.

I do not see any checkpoint related errors. Full VM testing fails with a rootless bug, but nothing in regards to checkpoint/restore.

Closing as I was able to reproduce it locally.


[docs] Removed focus outline on modal demo

Removes the browser default outline to the modal

Closes #11504
cc: @oliviertassinari

@sebasrodriguez It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

Thanks @oliviertassinari for your help. Let’s hope this is the first PR of many ;)


[Bug] insert into tinyint type column from bigint column

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
Both <IP_ADDRESS> ant 0.15.1-rc03
What's Wrong?
When I select value 169 from a bigint column in source table, and insert into the tinyint column in target table.
It seem success but the value becomes -87.
What You Expected?
May be it should show "Number out of range[169]. type: TINYINT"
How to Reproduce?
-- create target table
CREATE TABLE test.test (   id int(11) NULL COMMENT "", 	abc tinyint replace_if_not_null NULL Comment"" ) ENGINE=OLAP AGGREGATE KEY(id) COMMENT "OLAP" DISTRIBUTED BY HASH(id) BUCKETS 6 PROPERTIES ( "replication_allocation" = "tag.location.default: 3", "in_memory" = "false", "storage_format" = "V2" );
-- Input some test data
insert into test.test(id,abc) select 1,100;
-- Number out of range[169]. type: TINYINT
insert into test.test(id,abc) select 2,169;
-- create source table
CREATE TABLE test.test1 (   id int(11) NULL COMMENT "", 	abc bigint replace_if_not_null NULL Comment"" ) ENGINE=OLAP AGGREGATE KEY(id) COMMENT "OLAP" DISTRIBUTED BY HASH(id) BUCKETS 6 PROPERTIES ( "replication_allocation" = "tag.location.default: 3", "in_memory" = "false", "storage_format" = "V2" );
-- Input some test data
insert into test.test1(id,abc) select 1,100;
insert into test.test1(id,abc) select 2,169;
-- It seem success but the value becomes -87.
insert into test.test(id,abc) select * from test.test1;
select * from test.test
Anything Else?
global variables enable_insert_strict=true
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hive is also implemented in this way.


Can't run non-main function from composer.

With PR: https://github.com/ballerina-platform/ballerina-lang/pull/10060, main function behavior is changed. This feature has to support from plugins, VS-Code, Idea, composer etc.
Checked on : Nightly 0.981.2-SNAPSHOT (Sep 24, 2018)

This is no longer supported by the language.


Add PIR sensor support for motion detection

We would like the control panel to awake from sleep/dim/screensaver mode when motion is detected.  To accomplish this, let's add support for adding a PIR sensor.

Added v1.4.8


Custom Source filename

Hey,
I am using:
		app.use(
			sass({
				src: path.join(__dirname, '/common/sass'),
				dest: path.join(__dirname, '../wwwroot/stylesheets'),
				prefix: '/stylesheets',
			})
		)

but it will only pick up the sass file if I call it "style.scss" instead of "bootstrap.scss" for example. Is there a way to specify the source filename? I'd like to keep it named bootstrap.scss instead of style.scss.
Same question applies to the dest filename, can I give it a custom name which differs from the source css filename?

Hey @crephix. Thanks for reaching out! 🌮
At the moment, we only replace the .css extension with .scss from requested path to deduce the source filename.
What do you think if we extend the API by delegating this control to the consumer though a user-defined source-file provider function? Something like:
sassMiddlewareOptions = {
  sourceFileProvider: (requestContext) => getSourceFilenameFor ( requestContext.requestedPath );
};

// as an alternative to:

sassMiddlewareOptions = {
  src: path.join(__dirname, '/common/sass'),
  dest: path.join(__dirname, '../wwwroot/stylesheets'),
  prefix: '/stylesheets',
};

where middleware will inject the consumer's initial options and request objects to the requestContext and consumer will return an absolute path to .s[ac]ss file (String).
Additionally, we can also extend this approach to in-memory strings compilation, which node-sass provides OOTB:
sassMiddlewareOptions = {
  sourceProvider: (requestContext) => getSourceFor ( requestContext.requestedPath );
};

here in getSourceFor(..) function, consumer might be reading source content from (for instance) a remote server based on the requested path. With these options, middleware will asyncronously proceed once the source provider function returns the source contents or path to compile.

Sounds like a great enhancement for me.


How to replace Ip Address for peer-to-peer connection for media in WebRTC app?

I am writing WebRTC application for windows. My scenario is like:

LAN is default network interface for all applications.
System has more than one network interfaces like LAN and Wifi or usb modem.
WebRTC Signaling should use LAN & media (peer-to-peer connection) should use Wifi network. So that application can get fast network access for media communication.
Question- How to replace the Wifi Ip Address from LAN IP Address for media communication (peer-to-peer connection)?

My observation is:

It is possible to print Private and Public ICE candidates as per blow code.
pc.onicecandidate = function(evt) {
if (evt.target.iceGatheringState == "complete") {
local.createOffer(function(offer) {
console.log("Offer with ICE candidates: " + offer.sdp);
signalingChannel.send(offer.sdp);
});
Private ICE candidate (<IP_ADDRESS>:60834) for the peer
Public ICE candidate (<IP_ADDRESS>:69834) returned by the STUN server.

Now how to replace the Private ICE conditate (IP Address) to Wifi (IP Address)?

Could you please suggest any solution?

Am 02.07.2015 um 14:38 schrieb KP Singh:

I am writing WebRTC application for windows. My scenario is like:

System has more than one network interfaces like LAN and Wifi or usb modem.
WebRTC Signaling should use LAN & media (peer-to-peer connection) should use Wifi network. So that application can get fast network access for media communication.
Question- How to replace the Wifi Ip Address from LAN IP Address for media communication (peer-to-peer connection)?

My observation is:

You don't want to do that (i.e. non-trickle). Calling createOffer is not
necessary if you already called setLocalDescription, the
pc.localDescription will contain an sdp with all candidates.

Private ICE candidate (<IP_ADDRESS>:60834) for the peer
Public ICE candidate (<IP_ADDRESS>:69834) returned by the STUN server.

Now how to replace the Private ICE conditate (IP Address) to Wifi (IP Address)?

There should be an ice candidate with the Wifi IP (not sure how you want
to determine that though).
What might work is looking at the message content in
https://github.com/HenrikJoreteg/SimpleWebRTC/blob/master/simplewebrtc.js#L150-152
and only signal the candidate with the wifi ip.
You probably need to filter out the srflx candidate from the non-wifi
interface, too. This is tricky, you need to look for a candidate with
the same foundation (see
http://webrtc.github.io/samples/src/content/peerconnection/trickle-ice/)
as your wifi candidate, as the foundation identifies the interface.

Could you please suggest any solution?

this is going to be very complicated... hope that helps a little.

fixed per https://groups.google.com/forum/#!topic/discuss-webrtc/5Md1bDMI7Q0


cannot run miner

root@cdd8b202aee3:~/nimble/nimble-miner-public# python execute.py nimble1utnzppsel6c9mclqc6lgpx293ua5h7vcaqph64
Address nimble1utnzppsel6c9mclqc6lgpx293ua5h7vcaqph64 started to work.
Preparing
{'detail': 'Wallet nimble1utnzppsel6c9mclqc6lgpx293ua5h7vcaqph64 does not have master address'}400
Error: Failed to init particle: {"detail":"Wallet nimble1utnzppsel6c9mclqc6lgpx293ua5h7vcaqph64 does not have master address"}

same issue here

same issue here

you have to apply for whitelist :
https://discord.com/channels/1139328143400894604/1220834589845622926/1220913693303505046


CRI-O: move junit results to gcs artifacts root

Needed by the k8s testgrid as per
https://github.com/kubernetes/test-infra/pull/5943#issuecomment-351584590
@stevekuznetsov PTAL
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

I've also noticed we've not been publishing results to https://openshift-gce-devel.appspot.com/ since 11/16 for the crio jobs :confused:

I would rather see TestGrid move to be like Gubernator and allow for the jUnit everywhere. We are using the federated bucket now, as we discussed when we set this up -- gs://origin-federated-results/


mdf: Function: enable args with value

Since #218, Function.args are not set when Function.value is set. I think reallowing use of args with value would provide several benefits

ability for projects using MDF to use identical value expressions without pre-substituting arguments. ex with a linear function as expression:

current requirement:
"node1_linear_func": {
    "value": "2 * node1_input_port + 5"
}

"node2_linear_func": {
    "value": "3 * node2_input_port + 5"
}

allowed with args reenabled:
"node1_linear_func": {
    "value": "slope * variable0 + intercept",
    "args": {
        "variable0": "node1_input_port",
        "slope": 2,
        "intercept": 5
    }
}

"node2_linear_func": {
    "value": "slope * variable0 + intercept",
    "args": {
        "variable0": "node2_input_port",
        "slope": 3,
        "intercept": 5
    }
}

continued support for more complex python expressions in value, including subscripting, which cannot be handled by sympy simplify. (This is used to replicate psyneulink behavior in several common situations)
less need for #247, without which any project that wants to use MDF would be required to perform function dependency resolution on its own and ensure functions are output into MDF in the proper order.

This all looks good to me. I think you are right about allowing args with value as well.

@kmantel Sounds good, but is this PR just to allow MDF to have args on a function, but it doesn't implement this feature in the standard execution engine? If it is allowed in the spec, it should be fairly easy to enable expressions/functions like that in the reference implementation...
Looking at this though, what would be quite good is a new example py/json/yaml showing the various different forms of expressions allowed in the functions/parameters statements, maybe with a bit of text explaining them and of course tests on the example.

Prior to #218 this was possible; the execution engine automatically handles args with value in the same way it does args with function, so there's no additional code necessary. It seems that this was never explicitly tested here, but internal tests for replicating psyneulink models relied pretty heavily on args with value.
I'll go ahead and write a few tests for the args and value behavior including those in #247 that this fixes, but I think general expression examples are a bit out of scope for this PR.

From some more testing it seems that args and value execution only works in some cases as of now, which happened to be the ones used in pnl. I'll make some changes for the other cases in this PR.

Ok, thanks @kmantel. Merging this. I've tested it here #250, and added the example with soem of the Parameter/Function structures allowed:

https://github.com/ModECI/MDF/tree/nml_examples/examples/MDF#parameters-and-functions-example


Strange behavior on re-size

Charts are rendering outside of their wrapper.

This is because the div.variable-row width is set to 100%, but the charts aren't resizable (since we want a fixed height). Best bet is just to set the whole thing to a fixed width (ie: 1024px).

Test Notes: Just confirm that the chart doesn't overlap the div border as shown in the screenshot in dev-v1.0.0

Expected Result: Viewed all charts and they all are contained in their wrappers
Outcome: Pass


NIFI-9570 Separate classpath for NiFi Registry sensitive property pro…

…viders
This PR creates lib/spp under NiFi Registry's lib directory to isolate all of the sensitive property provider dependencies, and also separates NiFiRegistryPropertiesLoader into it's own module. It then uses a similar approach from NiFi to load NiFiRegistryPropertiesLoader via reflection in NiFiRegistry using a special ClassLoader that has lib/spp resources.

Thanks for the improvement @bbende! The pull request appears to include a number of test properties files, are all of those necessary as part of this change?

@exceptionfactory thanks for taking a look... as part of splitting apart the properties and properties loader, there was also a test class for properties loader that used several of these files. At the time I was mostly trying to get the tests passing and just duplicated the resources, so we can probably narrow it down a little bit, a bunch of them are used though.

Thanks @bbende, if there is an opportunity to cut down the number of test cases and corresponding properties files, that would be helpful.

@exceptionfactory pushed a new commit that cleans up the test resources... from the original resources, the bootstrap ones were needed only by nifi-registry-properties and the nifi-registry.properties ones were needed only by nifi-registry-properties-loader.