Determining off mesh directionality

In dtNavMeshQuery where it determines the right and left poly type I want to determine the directionality of the off mesh link if it's big directional so that I can handle it differently in my custom off mesh code. The problem is that there doesn't appear to be a good way to determine directionality within this function.
I tried to copy the mechanism that dtNavMesh::getOffMeshConnectionEndPoint uses, but it's not working consistently.

Also I wonder if getOffMeshConnectionEndPoint is robustly implemented. What if there are multiple links from a given poly? How does the loop through the link list know it's looking at the right one?

So, you are trying to figure out on which endpoint you entered a link? You
can determine that based on previous polygon and the links. Starting of an
off-mesh link (polyref), and looping through the links the "edge" of the
links tells which end point is connected. Something like this:
dtStatus getEntryIndex(dtPolyRef prevRef, dtPolyRef polyRef, int* index)
{
const dtMeshTile* tile = 0;
const dtPoly* poly = 0;
if (dtStatusFailed(m_nav->getTileAndPolyByRef(polyRef, &tile, &poly)))
return DT_FAILURE | DT_INVALID_PARAM;
for (unsigned int i = poly->firstLink; i != DT_NULL_LINK; i =
tile->links[i].next)
{
if (tile->links[i].ref == prefRef)
{
*index = tile->links[i].edge;
return DT_SUCCESS;
}
}
return DT_FAILURE;
}
where prevRef is the previous poly on path, and polyRef is the ref to the
off-mesh link.
The Off-Mesh Link is a polygon itself, so there is no ambiguity on that
one. You can use getOffMeshConnectionByRef() to get more information about
the off-mesh link.
--mikko
On Wed, Oct 14, 2015 at 5:44 PM, jswigart<EMAIL_ADDRESS>wrote:

Also I wonder if getOffMeshConnectionEndPoint is robustly implemented.
What if there are multiple links from a given poly? How does the loop
through the link list know it's looking at the right one?
—
Reply to this email directly or view it on GitHub
https://github.com/memononen/recastnavigation/issues/116#issuecomment-148072253
.

I think the issue I'm having is what to use as prevRef within the scope of the findStraightPath function. path[i] doesn't always work

Btw the location I'm trying to add this functionality is at the 2 spots within findStraightPath that set the flags to DT_STRAIGHTPATH_OFFMESH_CONNECTION

path[leftIndex-1] should do it.
--mikko
On Wed, Oct 14, 2015 at 9:34 PM, jswigart<EMAIL_ADDRESS>wrote:

Btw the location I'm trying to add this functionality is at the 2 spots
within findStraightPath that set the flags to
DT_STRAIGHTPATH_OFFMESH_CONNECTION
—
Reply to this email directly or view it on GitHub
https://github.com/memononen/recastnavigation/issues/116#issuecomment-148148081
.

That never succeeds in getEntryIndex . I tried leftindex - 1, and apexindex since that uses the left or right index depending on the left of right code branch within that loop. Neither got any hits in getEntryIndex. So far the best I've tried is path[i-1] which returns success quite a bit but also fails some too. That been the closest in terms of observation of my guy traversing the link so far. I'm concerned that those failures still point to something not entirely correct about that.

Judging by the call to getPortalPoints that uses path[I] and path[I+1], it appears that the 'prevRef' should probably be path[I].
When I try that I get a good number of successes in the getEntryIndex  function, but when it fails, it appears to fail because prevRef and polyRef are the same value.
Do I need to do this directionality outside the scope of the x == DT_POLYTYPE_OFFMESH_CONNECTION conditional so that it happens even after the first conditional before the block that handles else if (rightPolyType == DT_POLYTYPE_OFFMESH_CONNECTION)
Or perhaps there is a simplification that can be made to this function so that when an off mesh connection is hit, it can be handled before these string pulling area checks and such, since off mesh connections I would imagine should basically get string pulled to a point.
Maybe something like
if ( toType == DT_POLYTYPE_OFFMESH_CONNECTION ) before the 2 blocks that string pull the left and right sides. Perhaps that would make the previous poly more consistent, since it's not relying on state from previous iterations of the loop as it does inside the scope that currently checks for the off mesh
else if (leftPolyType == DT_POLYTYPE_OFFMESH_CONNECTION)
and
else if (rightPolyType == DT_POLYTYPE_OFFMESH_CONNECTION)

As an aside, what are your thoughts about adding a value to the dtPolyTypes flags, to use one of those available bits to mark a poly as reversed? (assuming each direction of a bidirectional connection gets its own poly). Then you'd have all the directional context you need from the offmesh poly by itself and not have to mess with the previous area in cases like this.

Using i is not correct in this case. The i is the current polygon, and one
of left or right is further back. One option is to calculate the value when
getting portal, and store it in the same way as leftFlags/rightFlags.
--mikko
On Thu, Oct 15, 2015 at 4:18 PM, jswigart<EMAIL_ADDRESS>wrote:

As an aside, what are your thoughts about adding a value to the
dtPolyTypes flags, to use one of those available bits to mark a poly as
reversed? (assuming each direction of a bidirectional connection gets its
own poly). Then you'd have all the directional context you need from the
offmesh poly by itself and not have to mess with the previous area in cases
like this.
—
Reply to this email directly or view it on GitHub
https://github.com/memononen/recastnavigation/issues/116#issuecomment-148383313
.

This appears to work consistently
dtPolyRef prevRef = path[apexIndex];
where apexIndex is the leftIndex or rightIndex depending on which of those 2 blocks it's in.
Basically the same as your original suggestion without the -1


Added 6 new button styles

Fixes #31
I have created and added more button styles in my PR. I have made the detailed explanation through diagram and discussion is in Issue Number: #31

Nice stuff you got here🎉
Just some suggestions and comments

For all the buttons that are rounded, they should be inside the rounded story and can have all the colors and the large size too. And also, I don't think we need any button to have a shadow for now until the design accounts for it.

Nice stuff you got here🎉 Just some suggestions and comments

For all the buttons that are rounded, they should be inside the rounded story and can have all the colors and the large size too. And also, I don't think we need any button to have a shadow for now until the design accounts for it.

Okay, I will make the changes

Nice stuff you got here🎉 Just some suggestions and comments

For all the buttons that are rounded, they should be inside the rounded story and can have all the colors and the large size too. And also, I don't think we need any button to have a shadow for now until the design accounts for it.

Updated

You've done a great job🎉
What I want you to do next is put all the round buttons inside of the button story. I don't want each of them to be a story on their own.

You've done a great job🎉 What I want you to do next is put all the round buttons inside of the rounded story. I don't want each of them to be a story on their own.

How can I do it ? Are there any resources to follow ?

I'll review it and drop feedback. Thanks

Ok, I have checked it out and that's not what I meant
Inside of the button story, Have a sub story called Round which is where I wrote Round
Now inside of the Round story, you can populate it with different round buttons with colors instead of just a single button

Use this for reference
https://github.com/wagtail/wagtail/blob/main/wagtail/admin/templates/wagtailadmin/shared/button.stories.tsx

Ok, I have checked it out and that's not what I meant
Inside of the button story, Have a sub story called Round which is where I wrote Round
Now inside of the Round story, you can populate it with different round buttons with colors instead of just a single button

Use this for reference
https://github.com/wagtail/wagtail/blob/main/wagtail/admin/templates/wagtailadmin/shared/button.stories.tsx

Hi! I tried doing it but I am unable to change it.

@purnima143 I have done the changes + there were some merge conflicts due to which I had to close the pr/. I have reopened it.

Thanks for sticking to this @ojasaklechayt
You would need to open a new PR with these changes and it should be against the dev branch instead of master

Okay I shall close this pr then


restic tries to backup its own temp files

Output of restic version
restic 0.7.2
compiled with go1.8 on windows/amd64
How did you run restic exactly?
restic -r F:\Backup backup C:\Users\USER

What backend/server/service did you use?
Local
Expected behavior
restic should ignore its own temp files during backup

Actual behavior
restic reports

error while saving data to the repo: remove C:\Users\USER\AppData\Local\Temp\restic-temp-pack-212416791: Der Prozess kann nicht auf die Datei zugreifen, da sie von einem anderen Prozess verwendet wird.

Steps to reproduce the behavior
restic -r F:\Backup backup C:\Users\USER

Do you have any idea what may have caused this?
restic tries to backup its own temp file while restic of course is removing this file because it is temporary
Do you have an idea how to solve the issue?
restic should exclude its own temp files or temp directory from backup

I think this only happens on Windows. On Unix systems, restic uses unlinked temp files.
Workaround is to add the Temp dir to restic's excludes.
Plausible fixes:

Add os.TempDir to default excludes. I don't like this option because maybe you do want to backup other files in TempDir.
Keep track of temp files created, and exclude those. I don't like this option because multiple restic processes may try to archive each others' temp files. But that's arguably an esoteric case, and it's easy to workaround by changing temp dir.
Use a regular name pattern like "#restic.*" for restic temp files, and exclude any files that match that pattern. This of course will fail to archive files that accidentally or deliberately match that name pattern. Accident seems to me unlikely. But an antagonist evading archival is maybe a legitimate concern.
Just warn if the temp dir is in the archival set, and maybe try to automatically pick a temp dir outside the archival set.

I would go for solution 2. I would not consider other restic processes. restic does not know of other processes at all, which is good. Creating for each restic process a unique temp dir should solve it. I am on your page with 1 and 3. The last solution won't work for the backup path C:\ and having only drive.

A user on IRC reported this happened on Linux:
# restic backup /
enter password for repository:
scan [/]
scanned 89432 directories, 1320677 files in 1:43
error for tmp/restic-temp-pack-138128855: Lstat: lstat /tmp/restic-temp-pack-138128855: no such file or directory
error for tmp/restic-temp-pack-151660632: Lstat: lstat /tmp/restic-temp-pack-151660632: no such file or directory
error for tmp/restic-temp-pack-955784605: Lstat: lstat /tmp/restic-temp-pack-955784605: no such file or directory
[12:51] 9.02%  32.365 MiB/s  24.368 GiB / 270.058 GiB  69414 / 1410109 items  3 errors  ETA 2:09:33

I guess this is super rare, it would be a race condition, if restic lists the contents of /tmp/ just after creating a temp pack but before unlinking it. But it can happen.

It's probably caused by a very old version of restic, on Linux, we've long since deleted temp files directly after creation so that this doesn't happen on Linux with recent versions

The user reported that they used restic 0.5.0, which still had this issue on Linux.

I dont know if it's the case already, but if not, please also automatically exclude the path to the repository in use :-)

Yep, good point. Thanks!

Is this still an issue? Can't reproduce on Linux with 0.9.0

It is, although not on Linux, where restic unlinks the temp files directly after creating them (so they are not visible in the file system any more).


Restructure website

In response to the NeurIPS reviewers, we will improve the website as follows:

[ ] Break website up into several pages
[ ] Add a sidebar for easy navigation

I should be able to get this done by tomorrow morning.

Resolving this issue will also solve issue #8.

Question for @jerrylin96 and others: Are the demo notebooks meant to be included on the documentation website?
The table of contents suggests so:
https://github.com/leap-stc/ClimSim/blob/f7d092cbaf57d79d47fa56dc0fd3e00a391da696/website/_toc.yml#L8-L10
Note that the 3 demo notebooks do not show up because they live outside of the website directory. I can make them show up, if that is the intention.

If the demo notebooks are meant to appear on the documentation website, maybe they should be cleaned up a little bit?

I'll defer to @jerrylin96 of course, but to me it seems like including the demo notebooks on the website is a nice value-add for the website. As discussed in the meeting, otherwise the website is "just" the README. So I'd be 👍 on including them.


EKS KMS Encryption for secrets without running 'terraform apply -target="module.kms"'

Please describe your question here
When applying with terraform an encrypted cluster (kms key encrypted secrets). With the following config:
module "kms" {
  source      = "terraform-aws-modules/kms/aws"
  version     = "1.1.0"
  description = "Master Key"

  # Aliases
  aliases                 = [local.name]
  aliases_use_name_prefix = true

  key_owners = [local.current_identity]
  policy     = data.aws_iam_policy_document.key.json

  deletion_window_in_days = 30
  enable_key_rotation     = true

  tags = local.tags
}

#---------------------------------------------------------------
# EKS Blueprints
#---------------------------------------------------------------

module "eks_blueprints" {
  source = "git::https://github.com/aws-ia/terraform-aws-eks-blueprints.git?ref=v4.12.1"

  cluster_name      = local.cluster_name
  cluster_version   = "1.21"
  cluster_ip_family = "ipv4"

  vpc_id             = module.vpc.vpc_id
  private_subnet_ids = module.vpc.private_subnets

  cluster_enabled_log_types = ["api", "audit", "authenticator", "controllerManager", "scheduler"]

  cloudwatch_log_group_kms_key_id = module.kms.key_arn
  cluster_kms_key_arn             = module.kms.key_arn
  cluster_encryption_config = [
    {
      provider_key_arn = module.kms.key_arn
      resources        = ["secrets"]
    }
  ]

I'm getting following error on 'terraform plan':
│ Error: Invalid count argument
│
│   on .terraform/modules/eks_blueprints/main.tf line 5, in module "kms":
│    5:   count  = var.create_eks && var.cluster_kms_key_arn == null ? 1 : 0
│
│ The "count" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many instances will be created. To work around this, use the -target argument to
│ first apply only the resources that the count depends on.

The workaround is to run first :
terraform apply -target="module.kms"

and than terraform plan works as it should.
Am I using the blueprints wrong? Why the KMS key can not be created with the whole stack and needs to exist before?

+1

thank you for the issue @RafalMaleska - unfortunately, yes - the current implementation would require that the KMS key be created before the cluster and not at the same time. Alternatively, you can look at utilizing the https://github.com/terraform-aws-modules/terraform-aws-eks module which would support your reported use case


Rendering newline in error doesn't help user

This is a regression compared to toml-rs as found by cargo's test suites
---- bad_config::malformed_override stdout ----
running `/home/epage/src/personal/cargo/target/debug/cargo build`
thread 'bad_config::malformed_override' panicked at '
test failed running `/home/epage/src/personal/cargo/target/debug/cargo build`
error: stderr did not match:
1   1     error: failed to parse manifest at `[..]`
2   2
3   3     Caused by:
4   4       could not parse input as TOML
5   5
6   6     Caused by:
7        -  expected a table key, found a newline at line 8 column 27
    7    +  TOML parse error at line 8, column 27
    8    +    |
    9    +  8 |                 native = {
    10   +    |                           ^
    11   +  Unexpected `
    12   +  `

Strange, in other places, I'm seeing it say "newline".

Oh, expecting a newline gets special rendering, but not an unexpected.

Oh, we're providing that with an expected.

This is resolved in the latest, nom-based parser


[10.x] ShouldBeUnique jobs works incorrect on failed DB transactions

If queue afterCommit flag is true and database transaction failed (will be rolled back), then all jobs dispatched with ShouldBeUniqueUntilProcessing interface will get a persistent lock, and you can't dispatch them again at all (because there are no any instruments to clear the locks from redis).
Opened issue: https://github.com/laravel/framework/issues/47761

@aprokopenko tests fail here.

@aprokopenko I see now the change is intentional. However, because it's a behavioral change it's probably best we do this in the next release only. Could you send in a PR to master with the tests updated? We can then see what Taylor thinks about it.

@aprokopenko there's a docker compose file you can use to run the tests locally: https://github.com/laravel/framework/blob/10.x/docker-compose.yml

@driesvints , I finally got the tests running, thx.
But when I run all tests - I got memory limit problem, maybe you already got such issue? Anyway, now I can run tests and will spent some time to update them

@driesvints btw, why you closed the issue? the bug still exists and I still plan to update the code and create new PR


feat: Implement pause() and resume()

Add pause and resume methods for the Kafka consumer

Is this code tested at all?

Is this code tested at all?

No tests yet. The reason is that we need to finish implementing some other parts of this consumer for this to actually work. Specifically the part that tracks partitions and updates self.offsets in the assignment/revocation callback. Right now it's always empty so these functions will immediately error with ConsumerError::UnassignedPartition.

A few questions:
Is implementing these necessary (or useful) for what we're trying to learn? What does it unlock for us in terms of gauging performance or ease of writing consumers?
Assuming it is useful:
Should we implement the offset tracking first or is this a chicken/egg situation?
Do we need to implement offset tracking and rebalancing mechanics right now?
I understand that our consumers need to handle rebalancing but for the test we have in  mind, we'll probably only run one partition so I don't have a clear picture of how it helps us.

It's not just for rebalancing. The assignment callback is called when the first (and only partition) gets assigned (or revoked).


Bump requests in /modules/sc-mesh-secure-deployment/requirements

Bumps requests from 2.23.0 to 2.31.0.

Release notes
Changelog
Commits

updated-dependencies:

dependency-name: requests dependency-type: direct:production ...

Alert details: https://github.com/tiiuae/mesh_com/security/dependabot/7


I am testing ECH in go1.24rc1. I noticed that the server aborts the handshake with a decode_error alert if the client sends an invalid ECHClientHello.type.
In section 7, the draft indicates an invalid ECHClientHello.type should generate an illegal_parameter alert.

If ECHClientHello.type is not a valid ECHClientHelloType, then the server MUST abort with an "illegal_parameter" alert.

https://datatracker.ietf.org/doc/html/draft-ietf-tls-esni-22#section-7-5
What did you see happen?
I implemented an ECH TLS server using the "go1.24rc1" tag. The following is the implementation code for the server.
https://github.com/thekuwayama/sample_ech_server
$ git clone --recursive git@github.com:thekuwayama/sample_ech_server.git
$ cd ../..
$ GOROOT='' go/bin/go run main.go
main.go:113: /tmp/echconfigs.pem3815808868

I am developing a conformance testing tool for ECH implementation.
I used the tool and confirmed that when a client sends an invalid ECHClientHello.type in ClientHelloOuter, the server aborts the handshake with a decode_error alert.
$ gem specific_install git@github.com:thekuwayama/echspec.git
$ echspec -f /tmp/echconfigs.pem3815808868 -p 4433 -s 7-5 localhost -v
TLS Encrypted Client Hello Server
        ✔ MUST abort with an "illegal_parameter" alert, if ECHClientHello.type is not a valid ECHClientHelloType in ClientHelloInner. [7-5]
        x MUST abort with an "illegal_parameter" alert, if ECHClientHello.type is not a valid ECHClientHelloType in ClientHelloOuter. [7-5]

Failures:

        1) MUST abort with an "illegal_parameter" alert, if ECHClientHello.type is not a valid ECHClientHelloType in ClientHelloOuter. [7-5]
                did not send expected alert: illegal_parameter
{"Alert":{"level":"0x02","description":"0x32"},"ClientHello":{"msg_type":"0x01","legacy_version":"0x0303","random":"0xe4a185724a980665b7c80747d3d9b85fae5085d673071ac30afbf0111b8139e1","legacy_session_id":"0x90e53937201797e49bdce9cd2d9164e63069877a6e1bde306aaa4357d132aa50","cipher_suites":["0x1302","0x1303","0x1301"],"legacy_compression_methods":["0x00"],"extensions":{"0x0000":{"extension_type":"0x0000","server_name":"0x6c6f63616c686f7374"},"0x002b":{"extension_type":"0x002b","msg_type":"0x01","versions":["0x0304"]},"0x000d":{"extension_type":"0x000d","supported_signature_algorithms":["0x0403","0x0503","0x0603","0x0804","0x0805","0x0806","0x0401","0x0501","0x0601"]},"0x000a":{"extension_type":"0x000a","named_group_list":["0x0017","0x0018","0x0019"]},"0x0033":{"extension_type":"0x0033","msg_type":"0x01","key_share_entry":[{"group":"0x0017","key_exchange":"0x0444d7c5dc352521211889ff074bf6f175e1577bb44b9a022ca9e2382788c52921d875dd1fd38fa757ebd822863228dd7221fc5e844b08c94462d70888061ef4b0"},{"group":"0x0018","key_exchange":"0x04955b8f67fa68eaef773509df3a905ce42ae4596c818dacd50b6715190c0f4b32615c45889d6c07c75ffb8330d2847c3639b5550a417b68348707faf76f935281932a1ad8ac42b59019b99b375bf6cbac5540040f3ad3cf3a2d49999157a97a4d"},{"group":"0x0019","key_exchange":"0x04005d7d8446fce79cd6424d8e68b7c06b47400e7b35a997259016c1166144b12d295fe602ae3167c7caf5158c3042bef0d898a3b05944367283f3073201d4823453ca0171ba35414bdfaae5d9d48d90b4ea6c250eecf7aab7607f9b4afacb2f7819695f9835daaea6957eaa8b624b06f768fe3c6fa0ea0a70c90a923426a4211acdf1947a"}]},"0xfe0d":{"extension_type":"0xfe0d","type":"0x02","cipher_suite":{"kdf_id":{"uint16":1},"aead_id":{"uint16":1}},"config_id":123,"enc":"0x611d5683e66c5c8a76db982870b37671513fa7f3ff5f550fcc32b4d3e372d82a","payload":"0xbe6cddb5281dfd3154e36547e86b91019180d2e0ca26437904920b42ad9f144995c7416a67598f25672f37cf88168842e1f255becd61abfe1491ad17ca02246be894db43aac362f2c3f56a010132d75662647d9215b9f7e7b7d525479687d4b8d9606222795049df86d03b7e0ae01413dc1f9a867ce4a14d3b9bafa8d3cc34bd7328d3b1716e0a4882a972d60789aeb044ea2c9261d03a2ac7b57ab53ed616708cf553e799ae7d961565e55ff0ebdb35e0e5adc0634e18f154095024a9fcdc27d69966226c83cdfcac390743c25c74ef04db3a997a492e5a6e1cae30274daeb59088353146049592c3cd419df7d8c19da2f37d3043771f0892c66c4b642c0539db24517db54978cb2f0a16eb5b3ae9364c4a9e14c921458ed7eaba49040b45d2ceaf979b6408aa665c85c371826a7df7a2b1b9ff50436d198d6cb66d4d023c2ed1a4f06ae62d057d53d4535d4f261ea71f9e6067279a72c25b7256acbc4916847f103f45f13af531666c3f182492df5e2c73196c8db4033550abd44ff7a8a266232fd1ec96162f5651bf6214e0aa611570a74196d414d8f8dc6fe4a59d3cd2e00291a52a5b0799d8e2e439cc0c74f03187748a250d75e290e9a7d993d2fb8876bac4cb79f7bd5a093b2befa326992c1fda35686e770fe5b2f7"}}},"ClientHelloInner":{"msg_type":"0x01","legacy_version":"0x0303","random":"0x60cdfa15e66502b2e268d49f49a567ec9abad0ea62132626e9e2a38a2f30b281","legacy_session_id":"0x90e53937201797e49bdce9cd2d9164e63069877a6e1bde306aaa4357d132aa50","cipher_suites":["0x1302","0x1303","0x1301"],"legacy_compression_methods":["0x00"],"extensions":{"0x0000":{"extension_type":"0x0000","server_name":"0x6c6f63616c686f7374"},"0x002b":{"extension_type":"0x002b","msg_type":"0x01","versions":["0x0304"]},"0x000d":{"extension_type":"0x000d","supported_signature_algorithms":["0x0403","0x0503","0x0603","0x0804","0x0805","0x0806","0x0401","0x0501","0x0601"]},"0x000a":{"extension_type":"0x000a","named_group_list":["0x0017","0x0018","0x0019"]},"0x0033":{"extension_type":"0x0033","msg_type":"0x01","key_share_entry":[{"group":"0x0017","key_exchange":"0x0444d7c5dc352521211889ff074bf6f175e1577bb44b9a022ca9e2382788c52921d875dd1fd38fa757ebd822863228dd7221fc5e844b08c94462d70888061ef4b0"},{"group":"0x0018","key_exchange":"0x04955b8f67fa68eaef773509df3a905ce42ae4596c818dacd50b6715190c0f4b32615c45889d6c07c75ffb8330d2847c3639b5550a417b68348707faf76f935281932a1ad8ac42b59019b99b375bf6cbac5540040f3ad3cf3a2d49999157a97a4d"},{"group":"0x0019","key_exchange":"0x04005d7d8446fce79cd6424d8e68b7c06b47400e7b35a997259016c1166144b12d295fe602ae3167c7caf5158c3042bef0d898a3b05944367283f3073201d4823453ca0171ba35414bdfaae5d9d48d90b4ea6c250eecf7aab7607f9b4afacb2f7819695f9835daaea6957eaa8b624b06f768fe3c6fa0ea0a70c90a923426a4211acdf1947a"}]},"0xfe0d":{"extension_type":"0xfe0d","type":"0x01","cipher_suite":null,"config_id":null,"enc":null,"payload":null}}}}

1 failure

What did you expect to see?
I think the server should abort the handshake with an illegal_parameter alert if the client sends an invalid ECHClientHello.type.
The following is a related comment.
https://go-review.googlesource.com/c/go/+/623576/8..16/src/crypto/tls/ech.go#b490

Related Issues

crypto/tls: encryptedExtensions.echRetryConfigs not returned to client #70915
crypto/tls: After the ech key verification fails, the new key sent by the ech server will not be used for handshake. #70073 (closed)
crypto/tls: abort handshake if unrequested extensions are sent #51090
crypto/tls: Failure to handshake when ClientHello lacks Point Formats Extension #54116 (closed)
crypto/tls: server responds with HRR even if there is no overlap between key_share and supported_groups #65686 (closed)
crypto/tls: TLS13 handshake does not fail if no cipherSuites overlap between server and client  #30109 (closed)
crypto/tls: handshake failure #8138 (closed)
crypto/tls: TLS 1.2 SupportedSignatureAlgorithms not honored in Server Hello Certificate Request #40344 (closed)
crypto/tls: tls client-side test recordings don't include the close notify message #69846 (closed)

Related Code Changes

crypto/tls: add ech client support

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)


Create login page

Backend changes are being implemented to create JWT tokens to allow login, but now a login is required.

Complete. Need to add registration logic


Add performance notes on break conditions of loops

The example shown in https://book.cairo-lang.org/ch02-05-control-flow.html?highlight=loop#repetition-with-loops
currently demonstrates
fn main() {
    let mut i: usize = 0;
    loop {
        if i > 10 {
            break;
        }
        'again'.print();
        i += 1;
    }
}

as a main example
This doesn't show best practice which is to avoid at all cost comparison operators to break out of loops.
It is much cheaper to compare numbers i == 11 rather than doing i>10, as internally ">" or "<" does range checks and calls the relevant libfunc, whereas numbers equality costs 2 steps, and zero checks ==0 or !=0 cost 1 step.
The best case, if possible, is to start from the latest index (10), decrement i, and check i==0.

fn main() {
    let mut i: usize = 10;
    loop {
        if i == 0 {
            'again'.print();
            break;
        }
        'again'.print();
        i -= 1;
    }
}

lol, i just noticed this is an infinite loop.
Indeed it's better to use strict equality checks - provided that i is increased by incrementation of ones.

lol, i just noticed this is an infinite loop.

copy pasted the wrong example. Edited.

@feltroidprime do you want to write a section about gas golfing in Cairo (1)?

whereas numbers equality costs 2 steps, and zero checks ==0 or !=0 cost 1 step.

Honestly, given all the overhead that the sierra abstractions imposes, I don't even think it's worth mentioning apart from in deep step optimisation chapters

Will be for chapter advanced cairo, probably gas optimizations

closing as we will not add a dedicated chapter for gas optimisation. I'll push a PR to add in control flow section informations about avoiding range check builtin usage with equality check


Add support for instagram albums

Example: https://www.instagram.com/p/BRiCc0VjULk/?taken-by=gfriendofficial
Currently it only downloads the first image.

done in c6ac3880571b82cde8158f203b10c1f348f334d4.


[Bug]: Yielding StopEvent in nested workflow breaking the handler

Bug Description
I'm running into a bit of a problem with a nested workflow. The handler in the parent workflow keeps stopping immediately whenever it gets a StopEvent from one of the sub-workflows.
I used the parent workflow's handler to pass all the events from the children, and after this change: https://github.com/run-llama/llama_index/pull/16115, we now always yield a StopEvent at the end of the workflow.
But I'm wondering that does yielding a StopEvent even make sense?
Version
0.11.11
Steps to Reproduce
Create a nested workflow where the handler of parent workflow stream all the event from its children. The handler stop immediately once one of sub workflow complete.
Relevant Logs/Tracbacks
No response

@dosu Afaik StopEvent is a primitive event of a workflow, while the handler should serve as a bridge for custom ones, where the event is added by calling ctx.write_event_to_stream(). Where is the code that writes StopEvent to the stream?

@dosu Thanks! then what codes are using StopEvent from the event stream?


Copilot onActivated event

We use the following check to decide whether or not to display copilot-related CTAs:
vscode.extensions.getExtension('github.copilot-chat')?.isActive

This check doesn't properly work through right after our participant extension startup. It seems that it takes time to activate the copilot and it happens after our extension is up and running. Is there a way to listen for the activation of github.copilot-chat?
I also tried vscode.extensions.onDidChange to hide copilot-related CTAs when a user disables the copilot chat extension, but it looks like the event doesn't happen on disabling, only when you enable the extension.

Just found out that it works as expected with vscode.extensions.getExtension('GitHub.copilot').

Actually, I played with this more, and GitHub.copilot also does not handle all cases. It looks like it is being activated earlier than github.copilot-chat so it covers out case to show or hide an icon when our extension is activated. But if we listen for vscode.extensions.onDidChange events considering that users might enable/disable the copilot in the meanwhile, the onDidChange is being triggered when the GitHub.copilot extension was enabled, but the isActive returns false. So the initial question is still valid, is there a way to listen for the onActivated state in this case.


Adding Citation for GPT-MT Report

Description and Motivation
We are working on the evaluation of LLMs for machine translation and we find this report very valuable for our work, hence I thought adding a citation would be helpful.
Expected Behaviour

A link will be automatically added to the repository landing page in the right sidebar, with the label "Cite this repository." This makes it easy for others to cite your this work project, using the information in the CITATION.cff[1]. Screenshot attached.

Adding citation BibTeX/APA into Readme.md. Screenshot attached.

References

About CITATION files

cc: @neubig @zwhe99

Thank you!


elemental-quickstart: remove duplicate label

Fixes: #389

I don't actually think this makes sense at all given that we're not using the /oem/ path, as that's for Elemental Teal

I don't actually think this makes sense at all given that we're not using the /oem/ path, as that's for Elemental Teal

I did wonder about that - do we just remove the /oem/registration or is the labelling itself not relevant?  (sorry not had time to dig into the details yet)

Agreed, I think the whole section can be removed.

Ok now removed, and I noticed the Rancher version needed updating


Bump pyupgrade to 2.37.2

Fixes #20

Can you rebase please?

Can you rebase please?

@s0undt3ch done


[SPARK-32352][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Exclude partition columns from data columns

What changes were proposed in this pull request?

This PR fixes a bug of #29406. #29406 partially pushes down data filter even if it mixed in partition filters. But in some cases partition columns might be in data columns too. It will possibly push down a predicate with partition column to datasource.
Why are the changes needed?

The test "org.apache.spark.sql.hive.orc.HiveOrcHadoopFsRelationSuite.save()/load() - partitioned table - simple queries - partition columns in data" is currently failed with hive-1.2 profile in master branch.
[info] - save()/load() - partitioned table - simple queries - partition columns in data *** FAILED *** (1 second, 457 milliseconds)
[info]   java.util.NoSuchElementException: key not found: p1
[info]   at scala.collection.immutable.Map$Map2.apply(Map.scala:138)
[info]   at org.apache.spark.sql.hive.orc.OrcFilters$.buildLeafSearchArgument(OrcFilters.scala:250)
[info]   at org.apache.spark.sql.hive.orc.OrcFilters$.convertibleFiltersHelper$1(OrcFilters.scala:143)
[info]   at org.apache.spark.sql.hive.orc.OrcFilters$.$anonfun$convertibleFilters$4(OrcFilters.scala:146)
[info]   at scala.collection.TraversableLike.$anonfun$flatMap$1(TraversableLike.scala:245)
[info]   at scala.collection.IndexedSeqOptimized.foreach(IndexedSeqOptimized.scala:36)
[info]   at scala.collection.IndexedSeqOptimized.foreach$(IndexedSeqOptimized.scala:33)
[info]   at scala.collection.mutable.WrappedArray.foreach(WrappedArray.scala:38)
[info]   at scala.collection.TraversableLike.flatMap(TraversableLike.scala:245)
[info]   at scala.collection.TraversableLike.flatMap$(TraversableLike.scala:242)
[info]   at scala.collection.AbstractTraversable.flatMap(Traversable.scala:108)
[info]   at org.apache.spark.sql.hive.orc.OrcFilters$.convertibleFilters(OrcFilters.scala:145)
[info]   at org.apache.spark.sql.hive.orc.OrcFilters$.createFilter(OrcFilters.scala:83)
[info]   at org.apache.spark.sql.hive.orc.OrcFileFormat.buildReader(OrcFileFormat.scala:142)

Does this PR introduce any user-facing change?

No.
How was this patch tested?

Unit test.

cc @AngersZhuuuu @maropu

Test build #127813 has started for PR 29526 at commit 213ba22.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32438/
Test PASSed.

retest this please

Test build #127814 has started for PR 29526 at commit 213ba22.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32439/
Test PASSed.

Test build #127815 has started for PR 29526 at commit d16f654.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32440/
Test PASSed.

Other failed tests with hive-1.2 profile were fixed in other PRs. This PR should pass all Jenkins tests with hive-1.2 profile now.

Test build #127813 has finished for PR 29526 at commit 213ba22.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127813/
Test FAILed.

Test build #127814 has finished for PR 29526 at commit 213ba22.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127814/
Test FAILed.

Is the final one to fix the failures in the branches? (I'm checking it now).

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32444/
Test PASSed.

Is the final one to fix the failures in the branches? (I'm checking it now).

Yes. :)

Test build #127819 has started for PR 29526 at commit d16f654.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32445/
Test PASSed.

Nice, thanks for the swift fixes, @viirya! Anyway, it seems we didn't notice this test failure for 10+ days, so we need to be more careful of the branches w/hive-1.2...

Yeah, we don't run hive-1.2 test usually except we know the diff touches hive 1.2 code path. For these failed tests, they don't touch the code directly, but affect it indirectly...

Test build #127820 has started for PR 29526 at commit b37f694.

Thanks! @maropu

Test build #127815 has finished for PR 29526 at commit d16f654.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127815/
Test PASSed.

good catch! LGTM

Test build #127820 has finished for PR 29526 at commit b37f694.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127820/
Test PASSed.

Thanks all!

Merged to master. @viirya Looks like conflicts with bnrahc3.0. Could you backport it?

Test build #127819 has finished for PR 29526 at commit d16f654.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@maropu I think #29406 was only merged to master, so we don't need to backport this.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127819/
Test PASSed.

Ah, I see.


ACL request payload access field always equal to 2

I am testing emqx with auth http plugin enabled, but my http server always receiving payload with access equal to 2, no matter my client is trying to subscribing a topic or publishing a topic.
ACL config emqx_auth_http.conf goes here:
##--------------------------------------------------------------------
## ACL request.
##
## Variables:
##  - %A: 1 | 2, 1 = sub, 2 = pub
##  - %u: username
##  - %c: clientid
##  - %a: ipaddress
##  - %t: topic
##
## Value: URL
auth.http.acl_req = http://backend:9000/v1/auth/acl
## Value: post | get | put
auth.http.acl_req.method = post
## Value: Params
auth.http.acl_req.params = access=%A,username=%u,clientid=%c,ipaddr=%a,topic=%t

Sorry @enix223  It is a bug actually, and it has fixed at https://github.com/emqx/emqx/commit/f14a56eb1741006f07a86ee518de4e29c8dd5af9
Please upgrade EMQ X above v3.1.0

Thanks for your promptly reply. Tested with v3.2-beta.1, issue have been fixed.


Bugged space between variables and operators

Hi. Sometimes, a space between a variable and an operator change the result, like in this screencast.
Variable is well recognized without space with its operator but when you give a space, it unrecognized operator. Is it a normal behavior or a bug ?
(I'm on last version)

I see this same issue. :/


Auto update submodules on master

We should figure out a way to auto import changes in https://github.com/kubernetes-client/python-base. Probably a bot like the one kubernetes main repo is using to publish staging/* repos.

@caesarxuchao can you add some pointers here so we can implement this for client python?


Don't electrocute when using remote on electrified door

About the PR
Adds an item property interactsRemotely to determine if it is a special type of item like a remote control that does not physically touch when it interacts. Currently used for electrocution, but could be used for other physical contact things in the future like germ spread, etc.
Fixes #8651
I went back and tested, and interacting with a door with any item can electrocute you, even a banana. Don't know if we want to check if the item being used to interact is conductive/metal in the future.
Screenshots

Changelog

:cl:

fix: Electrified doors no longer shock you when using a remote opener

This feels like a hack. Should be some way to indicate the interaction isn't physical, as I doubt the door should be able to shock you if you open it telepathically.

True, in the future we might have TV remotes and stuff with the same issue. Perhaps a new field in SharedItemComponent? I'll look into doing it that way.

This isn't the right approach, you just need to use a different event.
https://github.com/space-wizards/space-station-14/pull/8803


TextureD3D12::update calculates wrong subresource index when working with TextureArrays

Issue
When updating a TextureArray with more than one layer and mipmaps, TextureD3D12::update creates an out-of-bounds error for the source box.
To Reproduce
Create a TextureArray with mipmaps and update it with images including mipmap chain.
Expected behavior
Proper update of layers/mipmaps
Additional context
The subresource index calculation does not include _z and/or _depth to calculate the proper index.
_mip + (_side * m_numMips);
for the proper layer/mipmap index,
_mip + (_side * m_numMips) + (_z * m_numMips);
D3D12_BOX box;
box.left   = 0;
box.top    = 0;
box.right  = box.left + _rect.m_width;
box.bottom = box.top  + _rect.m_height;
box.front  = 0;
box.back   = 1;

the box.front and box.back values can be set to 0 and 1 to properly update the subresource. (At least it worked as a workaround for me)

Besides the subresource index calculations I removed the D3D12_BOX completely from the _commandList->CopyTextureRegion(&dst, _rect.m_x, _rect.m_y, 0, &src, nullptr); to get it working for me.

I was having crashes when using D3D12 until I apply the changes by @Findus79 , is there any reason not to apply those changes? Seems like texture arrays will be broken there until this is done.


dial tcp :0: connect: connection refused

DNS: xx:xxx@tcp(localhost:3305)/play?charset=utf8mb4&parseTime=true&loc=Local
the username and password are all correct
then got this error "dial tcp :0: connect: connection refused" i switch to the cloud db server, the result is the same
i use wsl2 as develop env
but i dont think it's a network problem, PING is ok

what did i miss?  it performs so weird...


Querying files with 10,000s of columns and 100,000s of rows

We have some biological datasets with 10,000s of columns and 100,000s of rows. Currently, we are storing the data in Parquet files and using pyarrow+pandas to read and filter the data. Users specify queries to filter the rows. And they indicate which columns they want to select.
This works well in most cases. But sometimes our users want to select all columns (but only some of the rows). Currently, we read all the data into a pandas DataFrame and then filter the rows. This is memory intensive when all columns are selected because the full dataset needs to be read. We are looking for a way to filter the rows before pulling data for all the columns.
Could we do something like the following?

Read only the columns specified in the filtering criteria and identify row indices that match the filtering criteria.
Read the rows that match those row indices.

Perhaps (probably?) we are thinking about this all wrong. Or perhaps Parquet is the wrong tool for the job. If you have any pointers or tips, we would greatly appreciate them.
Thanks for your time!

Parquet supports predicate pushdown on RowGroup and Page level. While page-level filtering is not yet available and will be a bit more complex to implement, you can already do basic RowGroup filtering using pyarrow. With pyarrow.ParquetFile(…).metadata.row_group(…).column(…).{min,max} you get the minimum and maximum of a RowGroup for a given column. When you compare your filters against these statistics, you should be able to only read a subset of the file using read_rowgroup.
This though depends on that you already have written your Parquet files with more than one RowGroup. You can achieve this by setting a chunk_size in write_table that matches to your problem. Normally pyarrow will only write Parquet files with a single RowGroup.

@xhochy Thanks for your response! Would it be unreasonable to create a separate RowGroup for each row of data in the parquet file? Instead of getting the min or max, could we use that to just grab all the data in that single row? Would that have significantly negative side effects?

Yes, that would remove most of the benefits of a columnar file format. If you really want to filter exactly to one row (assuming that your rows are quite large). It would be better to use a row-wise format like Avro.
To use Parquet, you should at least have 100 rows per RowGroup and for effective use, this should be well above 10k rows per RowGroup.

@srp33 Hey Stephen,
How did you resolve this?  I have a similar case from the market research industry.
I have a dataset with over 500,000 columns and over two million rows and we need to read and filter the data from disk for a group of columns at a time, or for all columns but only a handful of rows at the time.
Cheers,
JC

JC,
It's still a work in progress, but our preprint article here (https://www.biorxiv.org/content/10.1101/536979v1) describes our preliminary solution and links to some code on GitHub.
Enjoy!

@tday you may want to open up a new issue.  You will also likely need to provide some more details about what your overall goal is.

@tday I did some benchmarks and did not find a way to get good performance. I have an alternative solution that works really well. I'm creating a Python package. It's not quite ready yet. I'm happy to let you know when it is, if there's a way to get in touch.


Dockerfile.s390x: Switch to golang 1.7

With golang version 1.7 the s390x architecture is officially supported.
To be in sync with the other architectures now switch also for s390x
from gccgo 6.1 to golang:

golang: build and install to /usr/src/go

Download golang-1.7 sources
Bootstrap with gccgo 6.1

go lint: Sync GO_LINT_COMMIT with other Dockerfiles
notary: Remove GO15VENDOREXPERIMENT and softlink hack

With this patch the current CI on s390x completes with:

OK: 1375 passed, 43 skipped

Signed-off-by: Michael Holzheu<EMAIL_ADDRESS>

LGTM

LGTM (IANAM)

z — Jenkins build Docker-PRs-z 7 is running

Well... is this Jenkins job triggered manually? It currently still uses gccgo to build docker with hack/make gccgo.
We have to update the configuration:
- export BINARY="gccgo"
+ export BINARY="binary"

My plan was to update the Jenkins job after this PR is merged:

https://jenkins.dockerproject.org/job/Docker-PRs-z/configure
https://jenkins.dockerproject.org/job/Docker Master (z)/configure
https://jenkins.dockerproject.org/job/Docker Master (z) Binaries/configure

@michael-holzheu oh, I started it. Always a problem with Jenkins configs needing to change. I would rather change it first, as no one else is likely to want to run a Z job, and I would rather we show it passing on our CI before merging.

@michael-holzheu great! Thanks!
LGTM

@michael-holzheu oh, I started it. Always a problem with Jenkins configs needing to change. I would rather change it first, as no one else is likely to want to run a Z job, and I would rather we show it passing on our CI before merging.

@justincormack : No problem, I updated now https://jenkins.dockerproject.org/job/Docker-PRs-z to export BINARY="binary".

@michael-holzheu should we rebuild z in this PR?

@michael-holzheu should we rebuild z in this PR?

Sure, you can if you want.

Sure, you can if you want.

But I have tested it manually. So I don't expect problems.

@michael-holzheu seems like that machine is still using gccgo :/ And it failed.

@michael-holzheu seems like that machine is still using gccgo :/ And it failed.

Well, its only "saying" gccgo. In fact it tried to build "binary". But it looks like you have not built my PR.
16:13:49 Checking out Revision b97f985054b2eea3e9ee10cc8f10c5e61ded4f9b (origin/master)
16:13:49  > git config core.sparsecheckout # timeout=10
16:13:49  > git checkout -f b97f985054b2eea3e9ee10cc8f10c5e61ded4f9b

@michael-holzheu I dunno how to do that. I just asked IRC bot to rebuild this pr :)

@michael-holzheu I dunno how to do that. I just asked IRC bot to rebuild this pr :)

@LK4D4 I am also not familiar with the PR builds. @justincormack do you know the trick?

@LK4D4 With the help of @clnperez I updated and re-started the Jenkins Job:
https://jenkins.dockerproject.org/job/Docker-PRs-z/9/console
I had to manually add the following parameters:
https://jenkins.dockerproject.org/job/Docker-PRs-z/9/parameters/

@michael-holzheu cool, let's see now

LGTM when green

LGTM when green

Is green now: https://jenkins.dockerproject.org/job/Docker-PRs-z/9

\o/
LGTM

Yay!

@michael-holzheu Sorry I didn't notice this before but you might want to put a comment in the dockerfile like we have, that s390 requires go 1.7 or above. Ours got bumped down once to avoid a bug by someone who didn't know about the version requirements.

We did it :-)
Looks good in principle. One additional question:
In https://jenkins.dockerproject.org/job/Docker Master (z) Binaries we upload the built binaries to https://master.dockerproject.org/linux/s390x in the "Post-build Actions".
There we have defined:
Source: bundles/latest/${BINARY}-*/*
Destination bucket: master.dockerproject.com/linux/${ARCH}

Here the output of https://jenkins.dockerproject.org/job/Docker Master (z) Binaries/1330/console:
18:22:23 Publish artifacts to S3 Bucket is waiting for a checkpoint on Docker Master (z) Binaries #1329
18:31:15 Publish artifacts to S3 Bucket Build is still running
18:31:15 Publish artifacts to S3 Bucket Using S3 profile: master_binaries
18:31:15 Publish artifacts to S3 Bucket bucket=master.dockerproject.com/linux/s390x, file=docker region=us-east-1, will be uploaded from slave=true managed=false , server encryption false
18:31:15 Publish artifacts to S3 Bucket bucket=master.dockerproject.com/linux/s390x, file=docker-1.13.0-dev region=us-east-1, will be uploaded from slave=true managed=false , server encryption false
18:31:15 Publish artifacts to S3 Bucket bucket=master.dockerproject.com/linux/s390x, file=docker-1.13.0-dev.md5 region=us-east-1, will be uploaded from slave=true managed=false , server encryption false
...

Currently I only see binaries from 2016-08-15. How can I verify that the upload works correctly?

@michael-holzheu seems to be a general issue, don't seem to be any uploads for any arch for 10 days, trying to find out why not...


Properly fix dependencies workflow

Description:

Fixes #112
This time I will run the workflow here as a test (not actually creating a PR from it, though).
Type of change:

[x] Bug fix.
[ ] New feature.
[ ] Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

[ ] Is the change limited to one issue?
[ ] Does this PR close the issue?
[ ] Is the code easy to read and understand?
[ ] Do all new feature have an accompanying new test?
[ ] Has the documentation been updated as necessary?

The workflow now seems to work.


Inspector update for #616

Simple change to disable the debugger until chapter 3 and 4.

Pull Request Test Coverage Report for Build 1955

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 27.705%

Files with Coverage Reduction
New Missed Lines
%

src/sagas/workspaces.ts
1
9.92%

Totals

Change from base Build 1953:
-0.005%

Covered Lines:
1410

Relevant Lines:
4394

💛  - Coveralls

Travis complains. Not pretty enough.

Once we switch to Source §1 or §2, the Inspector and Env Visualizer should be cleared. At the moment, they just sit there, with content that is not relevant any longer:

Any other views on this, @ReignOfComputer and @geshuming ?

Taking the telegram discussion a bit further, here are the options:
(A) Restrictive
So the correct solution would be to disable change of Source x and change of library while debugging is going on, by:
(1) removing the buttons
(2) making the buttons grey and unclickable, or
(3) letting the user click and choose, but then pop up an error saying stop inspector to switch.
(B) Permissive
Let the user click and choose Library and Source chapter, but for any selection, automatically leave INSPECT and ENV, and re-set REPL. I personally find this option attractive. Any change of Library and Source chapter already resets REPL.

TL'DR: For any of the following actions, let's re-set REPL, ENV and INSPECT:

Run
change library
change Source §x


Cannot load PSReadline module.  Console is running without PSReadline.

Steps to reproduce
Expected behavior
Actual behavior
Environment data

> $PSVersionTable

@MSW345 need some repro steps please

Closing due to no repro steps.


Add text classification interface

This patch introduce new text classification interface.
Load pre-trained classifier from fasttext(1)
classifier = fasttext.load_model('model.bin', label_prefix='__label__')

Train & Load classifier
classifier = fasttext.supervised(input, output, label_prefix='__label__')

Test the classifier
precision_at_one, nexamples = classifier.test(test_file)

Predict the most-likely label of texts
texts = ['example very long text 1', 'example very longtext 2']
labels = classifier.predict(texts)
print labels

@pyk can you provide some pre-trained classifiers for AG, Sogou, DBP or other datasets.

@IvyGongoogle you can use pre-trained fasttext model on english to use it for english dataset https://s3-us-west-1.amazonaws.com/fasttext-vectors/wiki.en.zip


Use 2m Temp colors for Soil Temp

A request for higher-resolution soil temperature colors came in last week from Tanya. A hot fix was applied for HRRR and RRFS comparisons. She was happy with the result for her comparisons. Putting those changes in for permanence here.

@cshartsough Excellent suggestion for #2. I will do that shortly.
For #1,  I'm not sure the tick marks were important. She returned a little later to say "18z plots (Sept 24) of soil temperature look great, including the tick marks in NA RRFS." I decided just to continue with what we had in place for that time...and those were these changes.


Does this still build?

Hi!
I want to use this library in an app but I can't get it to work.
The first obstacle was two error: 'runtime_error' is not a member of 'std' thrown in src/spacy/spacy.cpp file. I overcame this by adding #include <stdexcept> in this file.
The thing is that even after this, I can't seem to be able to use it in my project. #include <spacy/spacy> throws No such file or directory error.
My CMakeLists.txt is
cmake_minimum_required(VERSION 3.12)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

# create project
project(myapp VERSION 0.1)

# add executable
add_executable(hello src/main.cpp)

# add CPM
set(CPM_DOWNLOAD_LOCATION "${CMAKE_BINARY_DIR}/cmake/CPM.cmake")

if(NOT (EXISTS ${CPM_DOWNLOAD_LOCATION}))
    message(STATUS "Downloading CPM.cmake")
    file(DOWNLOAD https://github.com/TheLartians/CPM.cmake/releases/latest/download/CPM.cmake ${CPM_DOWNLOAD_LOCATION})
endif()

include(${CPM_DOWNLOAD_LOCATION})

# add spacy
CPMAddPackage(
  NAME spacy
  GITHUB_REPOSITORY d99kris/spacy-cpp
  VERSION 1.04
)
target_link_libraries(hello PUBLIC spacy)

I would appreciate it if you gave me some insight.

Hi!
Thanks for reporting the issue and pointing out the missing header include.
I found some issues in the CMakeLists.txt file of spacy-cpp which I have addressed in above commit, along with adding the missing include.
Your CMakeLists.txt now works for me, with the minor adjustment of changing it to use latest spacy-cpp release 1.05 instead of 1.04.
I tested on Linux (Ubuntu 20.04) with compiler g++ (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0.
Please let me know if you are still seeing build problems using latest spacy-cpp. If yes, feel free to re-open this issue and please provide which OS/distro and compiler is used. Also the full output from cmake and make may be useful.
Thanks!

Just to add on, the cpp file I used with your CMakeLists.txt was src/main.cpp with the following content:
#include <iostream>
#include <spacy/spacy>

int main()
{
  Spacy::Spacy spacy;
  auto nlp = spacy.load("en_core_web_sm");
  auto doc = nlp.parse("This is a sentence.");
  for (auto& token : doc.tokens())
    std::cout << token.text() << " [" << token.pos_() << "]\n";
}

Hi, thank you for the swift response! Followed your points, but still, "no such file or directory". I am using Manjaro Linux and g++ 11.1.0. Here is the cmake result:
[stelios@Volund myapp]$ mkdir build && cd build && cmake ..
-- The C compiler identification is GNU 11.1.0
-- The CXX compiler identification is GNU 11.1.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Downloading CPM.cmake
-- CPM: adding package<EMAIL_ADDRESS>(v1.05)
-- Found PythonLibs: /usr/lib/libpython3.10.so (found suitable version "3.10.2", minimum required is "3")
-- Found PythonInterp: /usr/bin/python3 (found suitable version "3.10.2", minimum required is "3")
-- Build tests: OFF
-- Configuring done
-- Generating done
-- Build files have been written to: /home/path/to/my/app/myapp/build

And then make:
[stelios@Volund build]$ make
[  7%] Building CXX object _deps/spacy-build/CMakeFiles/spacy.dir/src/spacy/attrs.cpp.o
[ 15%] Building CXX object _deps/spacy-build/CMakeFiles/spacy.dir/src/spacy/nlp.cpp.o
[ 23%] Building CXX object _deps/spacy-build/CMakeFiles/spacy.dir/src/spacy/python.cpp.o
[ 30%] Building CXX object _deps/spacy-build/CMakeFiles/spacy.dir/src/spacy/span.cpp.o
[ 38%] Building CXX object _deps/spacy-build/CMakeFiles/spacy.dir/src/spacy/doc.cpp.o
[ 46%] Building CXX object _deps/spacy-build/CMakeFiles/spacy.dir/src/spacy/pyobjectptr.cpp.o
[ 53%] Building CXX object _deps/spacy-build/CMakeFiles/spacy.dir/src/spacy/spacy.cpp.o
[ 61%] Building CXX object _deps/spacy-build/CMakeFiles/spacy.dir/src/spacy/stringstore.cpp.o
[ 69%] Building CXX object _deps/spacy-build/CMakeFiles/spacy.dir/src/spacy/token.cpp.o
[ 76%] Building CXX object _deps/spacy-build/CMakeFiles/spacy.dir/src/spacy/vocab.cpp.o
[ 84%] Linking CXX shared library libspacy.so
[ 84%] Built target spacy
[ 92%] Building CXX object CMakeFiles/myapp.dir/src/main.cpp.o
/home/path/to/my/app/myapp/src/main.cpp:4:10: fatal error: spacy/spacy: No such file or directory
    4 | #include <spacy/spacy>
      |          ^~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/myapp.dir/build.make:76: CMakeFiles/myapp.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:100: CMakeFiles/myapp.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Hi! Thanks for providing additional details. I was able to reproduce the original problem now.
With the above commit I hope the issue should finally be fixed. Just point to spacy-cpp VERSION 1.06.

Yes, it works now! Thank you!


Fix E2E Tests

Currently, when you clone from master and run ng e2e you get the error:  Failed: No element found using locator: By(css selector, app-root h1).
This simple PR just fixes the e2e test to find the correct element and expect a different value of text.

Thank you very much for your effort. Could you please change commit message to fix(e2e): correct message and selector or something like that? We're generating changelog automatically so the commits should follow standardized format.

Updated the commit message, sorry for not taking a look at contributing guide beforehand.  Awesome boilerplate by the way!  Will be considering using parts of this for my team's next project.

No worries! I'll merge PR once the CI build is completed. Happy to hear that you find this useful. I am always trying to improve it a bit here and there. Should definitely add more tests, both unit and e2e though...

In a near future I want to add custom schematics for generating themed components with some.component.scss-theme.scss stub files generated and automatically added to the main styles.scss.

Yeah it's super useful, and I also really enjoyed reading your medium post about it.  Thanks for making it!


UNDERTOW-847 fixed appending port 80 if "X-Forwarded-Port" is empty

Jira: https://issues.jboss.org/browse/UNDERTOW-847
JBEAP Jira: https://issues.jboss.org/browse/JBEAP-8087
This is needed by EAP 7.0 CP release.

Can one of the admins verify this patch?


An error occurs when updating remote logging configuration with URL "http://localhost:8080/api/logs/consume".

Description
An error occurs when adding remote logging configuration with URL "http://localhost:8080/api/logs/consume".
Steps to Reproduce
Prerequisites
setup a https server
start the server
Steps

Start APIM server
Login to management console
Configure -> Remote logging
Select a log type
Add remote server URL

Affected Component
APIM
Version
4.3.0-alpha
Environment Details (with versions)
local environment
Relevant Log Output
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate plugin type for SecuredHttp
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate plugin for SecuredHttp
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to invoke factory method in class org.apache.logging.log4j.core.config.AppendersPlugin for element Appenders: java.lang.NullPointerException: Cannot invoke "org.apache.logging.log4j.core.config.plugins.util.PluginType.getElementName()" because "childType" is null
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "PaxOsgi" for logger config "root"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CARBON_CONSOLE" for logger config "root"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "ERROR_LOGFILE" for logger config "root"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CARBON_LOGFILE" for logger config "root"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CARBON_TRACE_LOGFILE" for logger config "trace.messages"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "ATOMIKOS_LOGFILE" for logger config "com.atomikos"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "AUDIT_LOGFILE" for logger config "AUDIT_LOG"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "TRACE_APPENDER" for logger config "TRACE_LOGGER"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "OPEN_TRACING" for logger config "tracer"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CARBON_LOGFILE" for logger config "org.apache.axis2.wsdl.codegen.writer.PrettyPrinter"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CORRELATION" for logger config "correlation"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CARBON_LOGFILE" for logger config "org.apache.directory.shared.ldap.ldif.LdifReader"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CARBON_LOGFILE" for logger config "org.apache.directory.shared.ldap"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CARBON_LOGFILE" for logger config "org.apache.directory.server.ldap.LdapProtocolHandler"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CARBON_LOGFILE" for logger config "org.apache.directory.shared.ldap.entry.DefaultServerAttribute"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CARBON_LOGFILE" for logger config "org.apache.directory.server.ldap.handlers"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "SERVICE_APPENDER" for logger config "SERVICE_LOGGER"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CARBON_LOGFILE" for logger config "org.apache.directory.server.ldap.LdapSession"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CARBON_LOGFILE" for logger config "org.apache.directory.server.core"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CARBON_LOGFILE" for logger config "org.apache.directory.server.core.DefaultDirectoryService"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "BOTDATA_APPENDER" for logger config "org.wso2.carbon.apimgt.gateway.mediators.BotDetectionMediator"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "API_LOGFILE" for logger config "API_LOG"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate appender "CARBON_LOGFILE" for logger config "org.apache.axis2.enterprise"
org.ops4j.pax.logging.pax-logging-api [log4j2] ERROR : Unable to locate plugin type for SecuredHttp

Closing as this issue is fixed with https://github.com/wso2/product-apim/pull/13437


Ledger integration

Not ready for merge, just like github's display of these things...

Confirmed that this works with the ledger integration.


constrain DSG trajectory, profile plots minor bugs

For profile and timeseries DSG  data the native plots constraining along the native direction works fine,
yes? use pmelTao5daySst_timeseries_dsg
yes? plot/T=15-jan-2017:15-feb-2017/m=1:3 t_25

yes? use WestCoastCarbon_profile_dsg.nc
yes? plot/z=10:400/m=1:3 pco2

and also for profile and timeseries constraining in X and Y works fine: choosing features by station location
yes?  use pmelTao5daySst_timeseries_dsg
yes? plot/x=155:165/y=-10:0 t_25

But for Trajectory plots, X-Y-T constraints select the right data, but the plot axis in Y doesn't adjust to the constrained subset.
yes? use socat_trajectory_dsg

! this is correct
yes? plot/t=02-APR-2017:01-jun-2017 temp ; go fland

! These select the right data but the map region shows the whole original range in Y
yes? plot/x=170W:155W temp; go fland
yes? plot /y=55:70 temp; go fland

This is fixed in plt/dsg_traj_plot_set_up.F  and new tests added to the benchmarks.


friends_with? returns true if users are not friends

User1 sends request to user2
user1.friend_request(user2)
And now even if user2 hasn't accepted friend request from user1, friends_with? return true
user1.friends_with?(user2)
=> true

user2.friends_with?(user1)
=> true

Fixed in 0.1.2

Thank you man)


[gui error report] Error: Initializing daemon...

👉 Please describe what you were doing when this error happened.
Specifications

OS: darwin
IPFS Desktop Version: 0.20.4
Electron Version: 17.2.0
Chrome Version: 98.0.4758.109

Error
Error: Initializing daemon...
go-ipfs version: 0.12.1
Repo version: 12
System version: amd64/darwin
Golang version: go1.16.12

Error: lock /Users/scottjeffers/.ipfs/repo.lock: someone else has the lock

    at errorTemplate (/Applications/IPFS Desktop.app/Contents/Resources/app.asar/src/daemon/migration-prompt.js:78:49)
    at loadWindow (/Applications/IPFS Desktop.app/Contents/Resources/app.asar/src/daemon/migration-prompt.js:115:26)
    at module.exports (/Applications/IPFS Desktop.app/Contents/Resources/app.asar/src/daemon/migration-prompt.js:120:3)
    at startIpfsWithLogs (/Applications/IPFS Desktop.app/Contents/Resources/app.asar/src/daemon/daemon.js:165:9)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async module.exports (/Applications/IPFS Desktop.app/Contents/Resources/app.asar/src/daemon/daemon.js:190:17)
    at async startIpfs (/Applications/IPFS Desktop.app/Contents/Resources/app.asar/src/daemon/index.js:46:17)
    at async restartIpfs (/Applications/IPFS Desktop.app/Contents/Resources/app.asar/src/daemon/index.js:100:5)

@Scott16546 can you attempt to resolve the issue using the instructions at https://github.com/ipfs/ipfs-desktop/pull/2111/files ?
Thanks.


Mock up "details" screen

May be very closely related to #21
Mock up what the details "panel" or view would look like

right-side panel:
https://www.figma.com/file/8CiUNS9zH2NUm74VEicn64/Unity-screen-flows?node-id=1439%3A9683&t=lCBN2LtQrXQiERrJ-1
bottom panel:
https://www.figma.com/file/8CiUNS9zH2NUm74VEicn64/Unity-screen-flows?node-id=1470%3A11965&t=lCBN2LtQrXQiERrJ-1


Bug Report: Frontend Not Auto-Reloading in Docker Environment

When running the frontend application using Vite in a Docker container, changes in the code do not automatically trigger a page reload or reflect in the browser.
https://github.com/user-attachments/assets/9fcb9a01-3e71-4806-a75e-6f33ce53a669

/assign


hrpws, identify active appointments by salary PayRate

Coverage decreased (-0.05%) to 85.662% when pulling f9d7c20c06ad0f9e3893b94c682a5c53bd1fd3b5 on feature/hrpws-1 into 85892db06542a49bd0bd132e67431b34763ec4bc on develop.

Coverage decreased (-0.06%) to 85.643% when pulling 49ad8afd9f9e82b9f1bee753304088c0b10457ec on feature/hrpws-1 into 85892db06542a49bd0bd132e67431b34763ec4bc on develop.


lunr 0.6.0

updated to lunr 0.6.0

:+1:

I've cherry-picked this with the tagged v0.6.0 lunrjs at cc62319028a69ac37d25f18f926adb374b9c2060 - the one you've added seemed to be a dev version.
Thank you both!


Versions list

i can't edit the versions list how can i add versions and set a custom url to every version and everything about the versions list in the header

I guess you figured that out — using docs-versions.yml
Note, there's also this page: http://localhost:1313/versions/

I guess you figured that out — using docs-versions.yml
Note, there's also this page: http://localhost:1313/versions/

yes, i did but there was a promplem also with multilang
when i create the ./content/en/docs/....and so on nothing change
also with the other langs like nl i created the ./content/nl/docs/... but something is missing i am sure becuse it dosn't display too in the lang select
and so on in the versions like when i create the ./contetnt/docs/1.3.0/...
the version display with the docs like the getting started
i want you to know that i read the docs of the doks and isn't it old
some things had changed a lot of it
my proplem now is with langs and versions that i can't do it correctly something i wrong

I will have a closer look and update the new documentation with proper instructions. I'll get back to you.

I will have a closer look and update the new documentation with proper instructions. I'll get back to you.

Okay, I'm waiting take your time


Search is incredibly slow

In particular, it is slow for queries with many results. Is it a backend issue? Is it a UI issue? Who knows!

I think the only way to effectively evaluate search speed is to actually ask users what they commonly search for.

Some common searches (I think):
-host DNS name (partial or fqdn)
-IP address
-Kirsten

On Jan 23, 2015, at 11:32 AM, drkitty<EMAIL_ADDRESS>wrote:
I think the only way to effectively evaluate search speed is to actually ask users what they commonly search for.
—
Reply to this email directly or view it on GitHub.

@kiwim0n: Thanks. I'll take a look.

What about partial IP addresses? I could easily see a situation where someone who wants to see all of the records in a given range might search for something like 128.193.1... unfortunately, this search is also very slow.

As for host names, the most common hostname is by far is www, which takes no time to search at all.


layers: Clean up old mem_tracker merge remnants

Clean up most of the remaining MTMERGESOURCE defines.
Many of these come straight out. A number of copy functions
were able to merge some code to provide a slight efficiency gain.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:+1:

cherry-picked and pushed to master


Some errors about image color

Hi,
Thanks for your great contribute on this open source work! But I have a few questions!
Firstly, I downloaded the faces_webface_112x112.zip from InsightFace Dataset zoo. Then I unzipped
the data and followed your instruction to generate training imgs but I got such images!

It looks like an issue about RGB channel and BGR channel. So i wonder whether its color is correct.
Thank you!

Hi all,
This is BGR format image, which is easy to verify.
All images under folder /faces_emore/imgs are BGR images too.

I'm confused too. All images under folder /faces_emore/imgs are BGR format and I dont find  the RGB transpose in this training code.  However,

data_pipe.py +line 59
img = cv2.cvtColor(img, cv2.COLOR_RGB2BGR).

Yeah, that's true. But it is different, right?

Line59 in data_pipe.py is used for preprocessing data which is validation data such as lfw, cfp_fp. This operation can transform these data from rgb to bgr. So, that means the data used for networks is in BGR format.
However, in face_verify.py, RGB data is used. It's strange, right?  It must be a transform in some place, but I dont find where it is.
And I'm very sure that the data used for networks is RGB format, because the test results are very poor if I use a BGR format data as input.

That's why I'm confused.

Hi, guys, after check on the codes, the conclusion is all the traning and evaluation image are all in bgr format, so the main codes are ok.
The problem is I shouldn't change the format during inference, so I have updated the following codes
image = Image.fromarray(frame[...,::-1]) #bgr to rgb
to:
image = Image.fromarray(frame) #bgr input format
in face_verify.py and infer_on_video.py

Got it, thank you @TreB1eN

Yeah, that's true. But it is different, right?

Line59 in data_pipe.py is used for preprocessing data which is validation data such as lfw, cfp_fp. This operation can transform these data from rgb to bgr. So, that means the data used for networks is in BGR format.
However, in face_verify.py, RGB data is used. It's strange, right?  It must be a transform in some place, but I dont find where it is.

That's why I'm confused.

Line92 in data_pipe.py is used for saving face images which used for training in RGB format. So, that means the data used for training is in RGB format???!!!


[migration] Nvim 0.10 Support

Feature description
The 0.10 stable version of nvim was released on 3 days ago. We could make some changes like #1245 to current 0.10 branch and merge it into main.
Additional information

MANDATORY CHANGES

[x] Update install scripts and issue templates to support v0.10. <==> https://github.com/ayamir/nvimdots/pull/1271
[ ] Consider dropping v0.7 (and v0.8) support. <==> ?
[ ] Create two new branches: 0.9 (legacy) and 0.11 (nightly) <==> ?
[ ] Revisit all the Treesitter-related plugins to lift some of the performance limitations (as incremental parsing is finally supported) <==> ?
[ ] Use the "signs" key of vim.diagnostic.config() to configure diagnostic-signs <==> ?
[x] Use vim.lsp.get_clients() in place of vim.lsp.get_active_clients() <==> https://github.com/ayamir/nvimdots/pull/1266
[x] Use vim.uv in place of vim.loop <==> https://github.com/ayamir/nvimdots/pull/1260
[x] Use Iter:flatten() in place of vim.tbl_flatten() <==> https://github.com/ayamir/nvimdots/pull/1260

NEW FEATURES

[x] Support LSP Inlay Hints <==> https://github.com/ayamir/nvimdots/pull/1260
[ ] Support new options <==> ?
[x] Consider replacing all accesses to Vim options from vim.api.nvim_get_option_value to vim.[b]o (as of v0.10, they finally function identically) <==> https://github.com/ayamir/nvimdots/pull/1269

Linked issues / PRs

[ ] #676
[ ] #851
[ ] #969
[ ] #1230
[ ] #1245

Support new options

after quite scan over https://neovim.io/doc/user/news-0.10.html and https://neovim.io/doc/user/deprecated.html#deprecated-0.10, i think it's fine w/ current option setup.

after quite scan over https://neovim.io/doc/user/news-0.10.html and https://neovim.io/doc/user/deprecated.html#deprecated-0.10, i think it's fine w/ current option setup.

Just took some time to read through the release notes. I think we could possibly implement those changes
- complete: ".,w,b,k" --> ".,w,b,k,kspell"
- completeopt: "menuone,noselect" --> "menuone,noselect,popup"
- smoothscroll: nil --> true

?


Users are redirected from Hosts page to Stacks page when Kubernetes environment becomes unhealthy

Rancher Versions:
Server: Rancher 1.3
healthcheck:
ipsec:
network-services:
scheduler:
kubernetes (if applicable):
Docker Version:
1.12.x
OS and where are the hosts located? (cloud, bare metal, etc):
DigitalOcean, Ubuntu
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Rancher 1.3
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
A Kubernetes environment with 4 hosts on DigitalOcean
Steps to Reproduce:
On the Hosts page, I delete some hosts, causing Rancher to reconcile Kubernetes infrastructure services to other hosts.
Results:
Rancher UI redirects me back to the Stacks page with https://<server>/env/1a39456/kubernetes/default/stacks?error_description=The%20redirect_uri%20MUST%20match%20the%20registered%20callback%20URL%20for%20this%20application.&state=0.5483969863717566
Expected:
I should stay on the Hosts page.

I think this was fixed already, but it definitely doesn't apply in 2.0.


Nested models with pydantic 2.0

Describe the bug:
With pydantic 2.0 (using the patched version from #35), I get an error on nested models.

class DisplaySettings(BaseModel):
    multiline: bool
    sort_on: str  # Literal['best_value', 'most_hits']

class InputSettings(BaseModel):
    autocomplete: bool

class OtherSettings(BaseModel):
    ids: list[NonNegativeInt]
    other_ids: list[NonNegativeInt]

class Settings(BaseModel):
    display: DisplaySettings
    input: InputSettings
    ltner: OtherSettings

class User(BaseModel):
    password: SecretStr
    settings: Settings

value = pydantic_form(model=User)

only renders the text_input (for password) visually, and consequently, when pressing "Submit" in the form, will rightly refuse to create a corresponding instance, as there are missing required arguments (settings).
When debugging, the problem happens in ui_rendere.py:117, when getting the _schema_references: I get a warning:
[WARNING] <streamlit.runtime.scriptrunner.script_run_context> Thread 'Thread-73': missing ScriptRunContext

and self._schema_references is set to {}.
This {} is also the reason for the missing input behaviour, as the references cannot be resolved.
See note below for a partial fix!
Expected behaviour:
Nested models working
Steps to reproduce the issue:
See snippet above.
Technical details:

Host Machine OS (Windows/Linux/Mac): Windows
Browser (Chrome/Firefox/Safari): Firefox
Streamlit: 1.24.1
Pydantic: 2.0.3

Possible Fix:
It seems that the internal schema of the model classes have changed with 2.0
In ui_renderer.py, line 118 and 1171 in the .get changing "definitions" to "$defs" seems to work in the first order:
Next to password also the settings defined in DisplaySettings and InputSettings are rendered.
BUT there is still a problem with the list fields nested in OtherSettings which needs further investigation.
I'm sorry that the PR #35 was not enough to make the lib fully pydantic 2.0 compliant.
As I said, s/"definitions"/"$defs"/ solves some of the problems, but still not all.

Ok, so the issue wrt. nested models not working with pydatnic 2 is resolved by the "suggested fixes".
However, the "list" not working seems to be an orthogonal problem, not related to pydantic 2 (but maybe changes in streamlit, compared to earlier versions):
List-Editing is solved in streamlit-pydantic among others by adding a button: self._render_list_add_button(key, add_col, data_list) (ui_renderer.py:1000), but that tries to add a streamlit.button(...) to the interface. However, adding a regular button within a form is disallowed by (at least current) streamlit button.py:407-411 raising an exception (which is then silently caught and ignored).


Validation rules tweaks

Model 1 and Model 44 GB:
Add °C units to TEMPM and TEMPR
Standardised 'metres' units as 'm'
Model 44

Remove replacement values for discharge category (not required)
Fail Discharge category should be greater than 10 not 9
Remove warning Discharge category for < 1 (because it redundant as also a fail)
Altitude min should be 0 not -3
Remove 0m as altitude warning - redundant as also a fail.
Distance from source Warn 245? should be in metres: 245000 (m) and less than 100m
Replacement for distance from source should be lessthan not equal to
Replacement for distance from source should be lessthan 100 not not 0.1 (as Model is in metres). Replacement should be 100 (i.e. metres).

Model 1

Discharge category warn if greater than 9 in GB.
Discharge category warn if greater than 8 in NI.
Remove less than 1 warn on discharge category (redundant as same a fail level)
Remove velocity warnings (redundant as same as failures)
Replace velocity max fail with 10 (not 5)
Add velocity warning at >5? But max value is 5? can't be higher than 5?

All issues fixed except velocity warnings. Velocity appears to get stored in velo_dummy column - and warning is not applied. Need to debug this.

Removed velocity warning limits for now, and used < 1 and > 5 as fail values (pending confirmation). Tests written and passing.

Confirmed velocity fail values (< 1 and > 5) are correct.


Handle deno runtimes better with CLI

Tested with npx<EMAIL_ADDRESS>
I ran into an issue during the Honcathon, where the FPX cli didn't play nicely with our Deno project.
The issue lies in how we detect the project root. Current CLI only looks for package.json or wrangler.toml. It does not consider a deno.json or deno.jsonc file.
Since I had a rogue package.json a few levels above the project root, my .fpxconfig ended up being created outside of the project directory.
This PR fixes the issue by looking for the closest matching filepath to the current directory amongst wrangler.toml, package.json, deno.json, and deno.jsonc.

This also includes a fix that considers host.docker.internal the same as localhost when detecting whether or not the user's .env definition of FPX_ENDPOINT needs to be changed.
During the Honcathon, our project used tilt + docker containers. So, to access fpx, our API needed to specify host.docker.internal. Every time I ran the CLI, it asked if i wanted to update the fpx endpoint, since it didn't use localhost.

for the record: i've tested on a Deno app and Cloudflare Workers app, both work as expected


GH-32338: [C++] Add IPC support for Run-End Encoded Arrays

Closes #14340

Closes #32773

Closes #14179

Closes: #32338

Commits with integration tests enabled are on the way.

@zeroshade


Opening the SimpleWear app on watch triggers the Google Play page to open on phone, regardless of whether or not the phone app is installed

The SimpleWear app on the phone is set up with the watch and everything, however in regular use, it gets annoying that every time I open the SimpleWear app on the watch and it reconnects with the phone, it will automatically send the phone to the app's Play Store page, though the app is already installed on the phone and the watch has successfully connected.
This occurs every time I open/interact with the watch app. The only method of avoiding that bug is using the shortcuts set up on the corresponding tile
Watch: Google Pixel Watch 2
Wear OS version: 4
Watch app version: 1.14.0
Phone: Motorola Edge 40 Pro
Phone Android version: 14
Phone app version: 1.14.0

Thanks for reporting. This will be resolved in the next update

Thank you. Will #41 be as well or is that further down the line?

Thank you. Will #41 be as well or is that further down the line?

Yes, i will try to address that as well

Please check the latest beta. Issue should be resolved


Explain data retention mechanisms

We have a number of mechanisms regarding data management in
EmailAlertApi but no doc that explains the concepts. This adds one.
Trello:
https://trello.com/c/tfu9zXuy/534-delete-unused-data-after-a-year

Thanks for the review @benthorner!
As for the deactivation and nullification worker mess. I agree it's quite confusing and could be improved and so I think it would be a good idea to sort it out as you describe. My only thought was that removing 'deactivated_at` may incur reduced performance (we'd have to do a join where we wanted to know this information) but thinking about it this wouldn't be an issue as we wouldn't need to know this info apart from when we're nullifying so that's fine! 👍
I'll address your comments after I've resolved the worker mess as it makes sense to do that first.

I think I've addressed all your comments @benthorner and I've updated the doc to take into account that we're retiring the activate / deactivate concept.
Most of the 'why' comments were explained in the first attempt of the ADR, I just popped them in the wrong place! 😄

There are some interesting terms in here that I think it would benefit the wider team to understand. At some point, it may be a good idea to build a concept model of how the service works.

Thanks for the review @benthorner. I've updated the doc inline with the changes to the ADR and your comments.
I've tried to keep the doc current (as in how the system works now) as I feel it should reflect the current state of the system rather than script what it will do in the future as this may be slightly confusing for readers in the window where the changes aren't live. We can always update it again when we change the various mechanisms.


Place revamp - minor bug fixes

Sorts the parent places according to the parent place type in both old and new place page.
Before: https://screenshot.googleplex.com/73zetb4iETK6D7p
After: https://screenshot.googleplex.com/4KQ4baSMN64ZNS6
Adds source tile to the bottom of the key demographics in the overview:
https://screenshot.googleplex.com/57gfbASDD62Jx5y
Replaces the source tile from "Source" to "Sources" when there are multiple.
Before: https://screenshot.googleplex.com/8i94e76fpnWRStE
After: https://screenshot.googleplex.com/HfKwv3zrbDsHxK9

Ah good point! Resolved!
https://screenshot.googleplex.com/9CKXGryzqMUjSGy


header text overflows incorrectly

It seems that if there is not enough space for the header text to fit (e.g. the “All Done” text), it will overflow out of the header, and into clipping the information below (if there is any). This is especially noticeable with large header text (such as “All Goals, Errors”).
I think that either the header should resize to accommodate for the large text, or that the text should fade out to the right (probably using text-overflow: fade).

It's a little bit hard to picture this, can you please provide us with a screenshot?

Sure.

Thanks, I see!


DOC-501 | GraphML platform

previews:
https://deploy-preview-1441--zealous-morse-14392b.netlify.app/docs/3.11/graphml.html
https://deploy-preview-1441--zealous-morse-14392b.netlify.app/docs/3.11/arangographml-getting-started.html

Further adjustments will be done after the docs migration to the new toolchain.


ART-128: Support ODCS composes for OSBS builds

This PR gives Doozer the ability to start OSBS builds with ODCS composes instead of repofiles.
Usage
This PR doesn't enable ODCS mode by default. To building an image with ODCS mode, you must follow those steps:

Add odcs section to ocp-build-data image config.

If you know the list of RPMs that the image will install, you can use manual mode:
odcs:
  packages:
    list:
    - kibana
    mode: manual

Otherwise, You can use auto mode. auto mode will use the list of packages from source container.yaml or make all packages associated to the Koji build target available:
odcs:
  packages:
    mode: auto

YUM repos defined in enabled_repos section will also be available as well.
Images without odcs section will not be built in ODCS mode. To make all images without odcs section in a build group assume ODCS auto mode, you can turn on the odcs_aggressive feature gate in ocp-build-data group config:
doozer_feature_gates:
  # odcs_aggressive: true to build an image with ODCS auto mode even if its image config doesn't have `odcs` field defined
  odcs_aggressive: true

Run images:rebase or images:update-dockerfile with --odcs-mode option:

doozer --odcs-mode --group 'openshift-3.11' -i logging-kibana5 images:rebase --version=v3.11.161 --release=888 -m 'bump version to 3.11.161-888' --push
doozer --odcs-mode --group 'openshift-3.11' -i logging-kibana5 images:update-dockerfile --version=v3.11.161 --release=888 -m 'bump version to 3.11.161-888' --push

If you don't want to specify --odcs-mode option explicitly, You can add the following the content to ocp-build-data group config:
doozer_feature_gates:
  odcs_enabled: true # whether to enable Doozer ODCS support (without explicitly specifying --odcs-mode option)

Doozer will generate and write ODCS related configs to image's distgit repo.

Build the image with images:build. If the image enables ODCS, Doozer will be aware of the ODCS config from the dist git repo and will not inject repofiles.

Behavior changes
This is a list of important changes to the existing ODCS support:

The old auto mode tries to guess what RPM packages the image requires. It does so by matching and parsing the yum install commands from Dockerfile then filter the result with repoquery. I believe this is error-prone because text-based processing instead of really executing the commands can't get a full list packages, and it doesn't handle RPM dependencies. The new auto mode will firstly look at container.yaml provided by upstream source. If it provides such a RPM list, we will use that list. Otherwise we will make all RPM packages within the current Koji build target available.

The old implementation has an implicit pre mode, which means if upstream source provides a list of packages in container.yaml, Doozer will use that list regardless of the mode in the odcs section. I don't think having such a mode is a good choice because it just ignores whatever packages listed in odcs section of our ocp-build-data image config. I removed that mode. If the image owner wants to use upstream source provided list, he should use the new auto mode.

The old implementation will require an --odcs option when running images:build in order to bypass the repofile injection. I think it is redundant because whether ODCS is enabled can be determined by looking at the container.yaml in distgit repo. I simply removed the --odcs option and simply reuse the repo-type option from non-ODCS mode for specifying whether signed packages are required.

Precedence change: odcs and arches sections in image config > container_yaml section in image config > existing container.yaml in source repo.

Code updated.

@sosiouxme @adammhaile @shiywang PTAL.

PR rebased.


There's a tiny time window in which suggestions don't get accepted

Hit Ctrl Space and Enter as fast as Lucky Luke.
If you are fast enough you will see the Intellisense box appear before disappearing and a new line gets inserted.
Ping @alexandrudima

Turns out I was pressing Ctrl Enter


Modify indentation

Changing the compose file from the aerogear/unifiedpush-wildfly-dev to the aerogear/unifiedpush-wildfly image didn't work until I corrected the indentation. Updating here as well for consistency.
@matzew can you review?

@dimitraz cool, thanks !
I just landed it :tada:


.Net: VectorStore - Add GettingStarted project with step by step instructions

Create a getting started project for using the new VectorStore implementations.
Use https://github.com/microsoft/semantic-kernel/pull/7604 as created by @markwallace-microsoft as a starting point.

Here are the steps that I'd like to see:

Step1_VectorStore_CRUD - Using InMemory introduce the core concepts i.e.

Create a Data Model
Create a record collection to store instances of your Data Model
Perform CRUD operations against the record collection
Perform paging over data

Step2_VectorStore_Search - Using InMemory show how to perform search

Basic search
Search filters

Step3_VectorStore_Configuration - Show how to switch between different Vector Stores and what gotchas exist

Go from InMemory for local development to a real Vector DB

Step4_VectorStore_Advanced_DataModels - Dynamic data models, custom mappers, ...


Bevy 0.9.1 support?

Hi I found this package and wonder if there are any plans of patching it for Bevy 0.9.1. Switching to that version on Cargo.toml seem to give the following error:
   Compiling example v0.1.0 (/home/user/Programmering/bevy_assets_bundler/example)
error[E0277]: the trait bound `BundledAssetIoPlugin: Plugin` is not satisfied
  --> example/src/main.rs:25:61
   |
25 |               group.add_before::<bevy::asset::AssetPlugin, _>(BundledAssetIoPlugin::from(
   |  ___________________----------________________________________^
   | |                   |
   | |                   required by a bound introduced by this call
26 | |                 BUNDLE_OPTIONS.clone(),
27 | |             ))
   | |_____________^ the trait `Plugin` is not implemented for `BundledAssetIoPlugin`
   |
   = help: the following other types implement trait `Plugin`:
             AnimationPlugin
             AssetCountDiagnosticsPlugin<T>
             AssetPlugin
             AudioPlugin
             CameraPlugin
             CameraProjectionPlugin<T>
             ColorMaterialPlugin
             Core2dPlugin
           and 37 others
note: required by a bound in `PluginGroupBuilder::add_before`
  --> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/bevy_app-0.8.1/src/plugin_group.rs:83:42
   |
83 |     pub fn add_before<Target: Plugin, T: Plugin>(&mut self, plugin: T) -> &mut Self {
   |                                          ^^^^^^ required by this bound in `PluginGroupBuilder::add_before`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `example` due to previous error

Fixed by https://github.com/hanabi1224/bevy_assets_bundler/pull/10

That is great news, I'll give it a spin!


Ability to close drawer by esc key

Use react-event-listener to register global event
Bind esc keyboard event to close drawer itself
Extract handleClose() to handle all drawer close behavior

Refer to #15