generate_realm_creation_link error 500?

HI,
I have just reinstalled zulip server in order to test the new installer, but now when I run ./manage.py generate_realm_creation_link command and inserting my email address (same of zulip configuration) the server tell me "500: Internal server error." when I press the Create Organization button
How solve this problem?

We're discussing this specific issue on chat.zulip.org (turns out to be outgoing email config not working), but for anyone finding this, /var/log/zulip/errors.log has the actual traceback :).


BS4 - Replace remaining glyphicons

I rule and have completed some work on Case Manager that's ready for review!
Sub in the remaining fontawesome icons for the glyphicons. rip glyphicons.
Along the way, I have learned some valuable lessons about doing col-s in bootstrap 4, so subbed those in, and removed some extraneous comments.
This pull request makes the following changes:

remove remaining glyphicons

It relates to the following issue #s:

Bumps #1632

before selector screenshots!
old:

new:


fix($scope): fixes multiple root element error when there is a whites…

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
If one tries to load a directive with a top-level comment angular throws an error
Error: [$compile:tplrt] Template for directive 'myDirective' must have exactly one root element
https://github.com/angular/angular.js/issues/15108
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Other information:
fixes multiple root element error when there is a whitespace after a comment
Added new conditional for NODE_TYPE_TEXT inside removeComments method of $compile
Added corresponding unit tests.
Closes #15108

This issue doesn't only happen with replace directives, but with any directive that has a comment node with whitespace around it. I think these two tests should be added:
            // comments are ok
            $templateCache.put('template.html', '

 \n');
            $compile('

');
            $rootScope.$apply();
            expect($exceptionHandler.errors).toEqual([]);

            // white space around comments is ok
            $templateCache.put('template.html', '

  \n');
            $compile('

');
            $rootScope.$apply();
            expect($exceptionHandler.errors).toEqual([]);

for the test it('should fail if replacing and template doesn\'t have a single root element'

I will add your tests, but @Narretz the it block you suggested has replace:true in the setup.

@Narretz Added those tests

@prashantpawar Sorry, you are right, it's all replace directives. It looks like these tests are duplicated in a few places.


qorJob.AddTableRow undefined

I just run "go run db/seeds/main.go" command, and following bug appear.
config/admin/worker.go:90: qorJob.AddTableRow undefined (type worker.QorJobInterface has no field or method AddTableRow)
config/admin/worker.go:93: qorJob.AddTableRow undefined (type worker.QorJobInterface has no field or method AddTableRow)

Hi @skpark1987
We just changed the API a little bit, haven't push change made in qor-example to master, just pushed the change.
Thank you for your report.


register global components for the app returned from "whyframe:app"

Hi!
I'm currently building a docs site for UI components based on Ant Design Vue + vitepress, but I couldn't manage to register some global components from AntDV, perhaps because we are using our own app instance instead of the one provided by vitepress (meanwhile vitepress has it own hook named "enhanceApp" to modify the app and register what we need), so what I'm thinking is maybe we could also provide some sort of hook there so the user can easily register those global components/properties to the app returned by "whyframe:app" plugin.
I personally altered the app generation logic in my fork like below and it solved my problem, but I'm not sure if it's the "correct" way to do it, if I missed some info in the documentation or someone has a better solution please kindly let me know :)
// inside "core/src/core.js"
/**
 * @param wrapperFn a function used to modify the newly created Vue
 *  App (in some situations we may need to modify it, for example, register
 *  global components/directives from a UI library like Ant Design Vue)
 */
const devCode = `\
export async function createApp(el, wrapperFn) {
  ...
  const result = await data.createApp(el, wrapperFn)
  ...
}`

const buildCode = `\
import hashToImportMap from 'whyframe:build-data'
export async function createApp(el, wrapperFn) {
  ...
  const result = await data.createApp(el, wrapperFn)
  return result
}`

// inside vue/src/shared.js
          const entryId = api.createEntry(
...
export function createApp(el, wrapperFn) {
  const app = _createApp(App)
  typeof wrapperFn === "function" && wrapperFn(app)
  app.mount(el)
  return {
    destroy: () => app.unmount()
  }
}`
          )

and inside my FrameDefaultLayout.vue, I can now register components as need:
<script setup lang="ts">
  import { ref, onMounted } from "vue";
  // Special api to mount the app
  import { createApp } from "whyframe:app";

  import VpDemo from "./vp-demo.vue";
  // MyUI be like { install(app) { app.component(MyButton.name, MyButton) } }
  import MyUI from "my-ui-components/src/components";
  import { ClientOnly } from "vitepress/dist/client/app/components/ClientOnly";

  const el = ref();
  const enhanceApp = (app) => {
    app.use(MyUI);
    app.component("VpDemo", VpDemo);
    app.component("ClientOnly", ClientOnly);
  };

  onMounted(() => {
    // Mount the app to the ref
    createApp(el.value, enhanceApp);
  });
</script>

That make sense to me! I didn't thought about Vue's case so we should support this. Maybe we should make the second argument of createApp be an object that accepts enhanceApp instead so other frameworks can add custom ones in the future.
Happy to review the changes if you're planning to submit a PR. Otherwise I can do so today too.

yeah, glad to hear that! but I'm afraid for now it'll be better for you to make the changes, since I'm still new to whyframe and need sometime to get familiar with the internals 😃

Supported in @whyframe/core v0.1.9 and @whyframe/vue v0.1.5. You can pass the enhanceApp like this:
createApp(el, {
  enhanceApp(app) {
    app.component('GlobalComponent', GlobalComponent)
  }
})


Add opencv extra modules

HI,
It would be great if you add openCV extra modules library with the below link.
https://github.com/opencv/opencv_contrib
Thanks

See #862.

latest version of OpenCV port already contains opencv_contrib.
@ras0219-msft Please close this issue.


Potential handle leak when recreating VlcPlayer instances

I'm encountering a potential handle leak when recreating a VlcPlayer instance every second. Here's the code;
        public MainWindow()
        {
            InitializeComponent();

            var disp = Dispatcher;
            Meta.Vlc.Wpf.VlcPlayer vlc = new VlcPlayer(disp);
            vlc.Initialize("libvlc");
            vlc.LoadMedia("1.mp4");
            vlc.Play();

            Task.Run(async () =>
            {
                while (true)
                {
                    await Task.Delay(1000);

                    vlc.Stop();
                    vlc.Dispose();

                    disp.Invoke(() =>
                    {
                        vlc = new VlcPlayer(disp);
                        vlc.Initialize("libvlc");
                        vlc.LoadMedia("1.mp4");
                        vlc.Play();
                    });

                }

            });
        }

It's really lazy, I know.

On the arrow is where I started the above code and let it run for a while. The graph shows open handles by process. The above code is all that's done in the project. There's no other code running.
I'm also getting the handle leak in my custom VlcPlayer, using my own render process through SetVideoDecodeCallbacks, etc.
Any ideas?

Create player is a very heavy operation, I think you should multiplexing players.


freeze() and unfreeze() functionality

Is this for players or the ticks or what?

Players, to have an opt-in freeze system

Closed by #60


bug fix and cleanup for 0.2.16

Why are these changes needed?

await a_send
clean up comments
bump version to 0.2.16

Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 43.54%. Comparing base (f6c9b13) to head (8e8f8a8).

Files
Patch %
Lines

autogen/agentchat/groupchat.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1827      +/-   ##
==========================================
+ Coverage   35.69%   43.54%   +7.84%
==========================================
  Files          63       63
  Lines        6625     6625
  Branches     1454     1579     +125
==========================================
+ Hits         2365     2885     +520
+ Misses       4067     3508     -559
- Partials      193      232      +39

Flag
Coverage Δ

unittests
43.48% <50.00%> (+7.78%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Main B-19300

Agility ticket
INT PR
#12758
Summary
This branch contains 3 big changes:

The "Haul Price" item in the "Incentives" section of the final PPM Closeout Review screen will now update to read either "Linehaul Price" or "Shorthaul Price" depending on whether or not the move happens within the same Zip3.
This branch also fixed a bug in the pricing where items were always using the linehaul pricer for things like gross incentive, domestic area price, etc., even if a shipment would be classified as a shorthaul.
"Full Pack/Unpack Charge" has now been separated in to separate "Packing" and "Unpacking" charges.

Other minor changes:

"(Short/Line)haul Fuel Surcharge" has been changed to "(Short/Line)haul Fuel Rate Adjustment"

How to test

Create a move that goes to any two zip codes with the same first 3 digits. Where you would normally check "use my new duty location", you can instead put in an address with the same Zip3 (e.g. 90210 -> 90245).

Go through the normal process to get to PPM closeout (sign, approve as SC, upload PPM documents).

As an SC, access the move through the closeout queue, go to the last "Confirm" screen and verify that you see "shorthaul price", "Shorthaul Fuel Rate Adjustment", and the separate "Packing Charge" and "Unpacking Charge" fields  as shown here:

If you want to test that linehaul price will show up, find the actual_pickup_postal_code and actual_destination_postal_code columns for your move in the ppm_shipments table. Edit the destination code to "30183".

Refresh and continue back to the "Confirm" screen, you should now see that "Linehaul Price" and "Linehaul Fuel Rate Adjustment" shows up instead, and you should notice a substantial difference in price.

Warnings

:warning:
This PR does not include changes to storybook, even though it affects component code.

  Generated by :no_entry_sign: dangerJS against cc936d6840ecb643bc6417e48ce99088544699ba


Contractual build plan

RFC PR: https://github.com/buildpack/rfcs/pull/12
Lifecycle PR: https://github.com/buildpack/lifecycle/pull/149

@hone @nebhale awaiting approval 😄

@hone updated to match dist spec requirements. Awaiting approval 😄


Initial work on trustfall_macros, including NamedType

Relates to discussion #161, where "__typename" could be implemented as a procedural macro.
My thinking is that if we use a NamedType trait, we can possibly add that as a trait bound (or not, if it is considered breaking). Alternatively, the trait can be skipped.
Very much WIP

We could also provide a function to be used from Adapter like:
fn resolve_property(contexts: ContextIterator<'vertex, Vertex>, type_name: &str, property_name: &str) {
    if property_name == "__typename" {
        return resolve_typename(contexts);
    }
}

fn resolve_typename<'vertex, AdapterT>(contexts: ContextIterator<'vertex, Vertex>)
where
    AdapterT: Adapter<'vertex>,
    AdapterT::Vertex: NamedType
{
    // call the `NamedType` method here and produce the result iterator
}

I think this is a bit better than a trait bound on Adapter, because while this resolve_typename() approach is the easiest to code, it's actually slower than strictly necessary.
The fastest approach here would be a check on the schema to see if the type_name argument has any subtypes, and only doing resolve_typename() if the answer is "yes." That's because if it doesn't have any subtypes, the __typename is guaranteed to be the same value as type_name.
Going the route of "here's a helper you could call from your Adapter, but you don't have to use it" gives us the ability to provide a fancier helper in the future, perhaps one that does perform that schema check first.
What do you think?

See #173


Implement tick list tab

The tick list tab was implemented in the iOS app but missing in the android one.
This commit implements that tab, along with the ability to add a problem as ticked or as a project.
https://github.com/boolder-org/boolder-android/assets/8343416/f140edbe-388b-4562-abff-8b4a35599dad
The ticks are stored in a separate database meant to contain the user's data.
Resolves #28

Works great!!
Excellent job 👏
Only small improvement I see:

there is small horizontal padding for the bottom sheet buttons (bleau.info, enregistrer, partager) => it would look better if there was no padding at the start/end of the scrollview, so that we have the feeling that the buttons disappear beyond the edges of the screen

Other questions I have:

in the new tab, how is the list scroll performance with lots of ticks (let's say a few hundreds)?
what happens if the user deletes/uninstalls the app? do they lose their ticks?
what happens if a user ticks a problem, and the problem_id doesn't exist anymore after a boolder.db update?
can we easily add/remove fields in the future?

The padding on the topo actions is fixed ✅ :

in the new tab, how is the list scroll performance with lots of ticks (let's say a few hundreds)?

The list scroll performance should not be an issue, as the whole content is computed at once. I performed a test on my OnePlus 5T with 3000 problems being marked as project and here is the result:
https://github.com/boolder-org/boolder-android/assets/8343416/e29d6eda-7b4a-424f-a3c5-db2c6c4f56df
The only drawback is that the initial computing is a bit long, but the scrolling is alright. The subsequent displays of the list will be faster after this first computing.

what happens if the user deletes/uninstalls the app? do they lose their ticks?

The deletion of the app will also delete the associated databases and lose the user's ticks. I took a look at the auto backup feature but it seems that it does not work directly with database files and the limit is 25MB per user. Therefore, I assumed that the future synchronization of the ticks in a Boolder profile would be more practical for this purpose.

what happens if a user ticks a problem, and the problem_id doesn't exist anymore after a boolder.db update?

The ticked problem will simply not appear anymore in the tick list screen. A mapNotNull() is performed when trying to link to problem info to a tick, which equivalent to compactMap() in Swift.

can we easily add/remove fields in the future?

As the ticks are stored in a SQLite database, migrations have to be written when changing the database schema in order to keep the user's ticks. Not the easiest or most seamless, but still reasonably doable.

Great! Let's ship it 😎
One last thing:

bottom sheet: when the second row (like "wall / sit start") is empty we can't see the tick/favorite icon

bottom sheet: when the second row (like "wall / sit start") is empty we can't see the tick/favorite icon

Fixed, here are the various situation for the topo footer:

Marked as project
Ticked


Fix table formatting in README

@lifehackett - Thanks so much for the fix! Clean docs are really important, and while this changeset is small, it's meaningful. Thanks for taking the time to submit this, and welcome to P9k!


File storage add-on fails to install & throws error frequently..

Using below attached override.json file to deploy ROKS cluster & seeing File storage add-on fails to install & throws error frequently.
Out of 4-5 attempts, I am seeing this issue 2-3 times (50% of times).
Note: This issue is seen even while installing File storage manually on the UI.
override.json

Un-assigning Vincent. @NatarajBTIs this still an issue? Did you raise with IKS team?

This is not an issue - the daemonset associated with the addon takes time to come up, and seems it wont come up if master if updating. Since we are documenting that addons have to be Healthy, I'm going to close this


Fix ht-wrapper Test

It breaks.
in server/test you should be able to run make and have the compiled file run without error

@smonaghan I made everything pass in #33 (which will be merged soon) . Can you instead make the tests a little more complete?

@SMonaghan @phil-lopreiato  - please update this Issue or close it and create a new one listing exactly what is remaining and who will do what

Fixed in #36

Nothing more needs to be done here


feat: Realtime schema updated in README

Based on the discussion in issue #36, this is the updated schema that will be shared in the README.

@maximearmstrong Thanks for the update - should be set now!


[xbar] Reduce fifo depth

Reduce socketm1/socket1n default fifo's to depth of 1
There is no need for deeper fifos in our current system
Add rationale for why xbar nodes are configured as they are

Signed-off-by: Timothy Chen<EMAIL_ADDRESS>

LGTM

is it normal for the csr_outstanding test to run an hour with waves on? There's on seed that just kept going until timeout. I briefly looked at the waves, nothing looked locked up, but i'm not sure this is normal either.

LGTM

is it normal for the csr_outstanding test to run an hour with waves on? There's on seed that just kept going until timeout. I briefly looked at the waves, nothing looked locked up, but i'm not sure this is normal either.

I just checked the nightly history. This test used to take 40+ min at maximum. The recent one took 50+ min. With waves, it sounds normal to go over the default timeout limit which is 1hr. As we're adding more, chip-level takes longer.
We may need to increase the timeout limit for this test to 90 min.

I'll merge this once either @eunchan or @msfschaffner has a look.
i want to make sure the rationale behind how things are currently done makes sense.


Rendering a n*n gameboard

Rendering a visual representation of the gameboard. The grid also contains specific attributs/information about the current game state.

Still need a lot of visual enhancement.
Need to communicate to the server.
Rendering entities (towers) and visual particles (towershots, minions) still open.

First Version of this is done with the commit e3fb3ae.


"isActive" prop is false even while "when" is true

I'm using a ReactRouterPrompt and it works most of the time. But when I go to the same page (the page that has the Prompt) but with different url parameters and after trying to leave that page, I do not see my popup.
I debugged and the "isActive" prop is false even if "when" and all conditions give true.
Any help with this?
Thanks!

@isma-funes sorry for delay here, would you be able to share quick example on codesandbox?
I am planning to update the package to support react-router-dom >=v6.7, this would get fixed in it but it has breaking changes cz of new API's introduces in react-router-dom.
If provided I can fix this for previous versions as well.

Closing this for now. Can reopen if required.
Thanks for reporting


ColorChooserDialog Theme

When creating a ColorChooserDialog, I get a dark background. The theme() attribute is missing in this case. How does one change the theme?

+1 same problem

https://github.com/afollestad/material-dialogs/releases/tag/<IP_ADDRESS>

:)


Reversed pixel coordinates when initializing with Sky Coordinate

When I have some Sky Coordinates built from the (verified) RAs and Decs of sources in an image, and initialize Sources using those Sky Coordinates, the sources are initialized in the wrong place, with inverted x and y pixel coordinates (see image at end). Digging into it, I think this is because pos.to_pixel(wcs_) of line 56 of frame.py, in the get_pixel function returns the x and y coordinates that match the observation data, but in parts of the scarlet2 code it seems to be assuming that those pixel coordinates should be reversed, e.g. in source.py line 43. Its not a model frame issue, because if you do pos.to_pixel(wcs_) where wcs_ is from the model frame or the observation frame, the pixel coordinates match the source locations in the image. But the sources are clearly rendered in the wrong place, and the boxes are shown to be in the wrong place when plotting.
I had (quite unfortunately!) been avoiding this issue by introducing another 'bug' that cancelled out this problem: I was finding the RAs and Decs that matched the inverted pixel coordinates by also reversing the pixel coordinates of the sep source detection output, and using those for source initialization. But my collaborator noticed that those intermediate RAs and Decs were incorrect.
So, in summary, source initialization using Sky Coordinates seems to treating the pixel coordinates inconsistently, sometimes inverting them and sometimes not. (Unless I have some even weirder issues with ZTF wcs's or there's a confusing bug in the plotting code).

The fix seems to be to change line 56 in frame.py to make sure it reverses the pixel coordinates. The transpose operation doesn't do this so we can return pixel[::-1] instead of pixel or something like that. Will make a PR for testing.

Closing as fixed in #94 !


Build failure: pcl with CUDA enabled on x86_64-linux

Steps To Reproduce
Steps to reproduce the behavior:

Run nix develop with the following flake:

{
  inputs = { nixpkgs.url = "github:nixos/nixpkgs/nixos-unstable"; };

  outputs = { self, nixpkgs }: {
    devShells = nixpkgs.lib.genAttrs [ "x86_64-linux" ] (system:
      let
        pkgs = import nixpkgs {
          inherit system;
          config = {
            allowUnfree = true;
            cudaSupport = true;
          };
        };
      in {
        default = pkgs.mkShell {
          buildInputs = [ (pkgs.pcl.override { withCuda = pkgs.config.cudaSupport; }) ];
        };
      });
  };
}

Build log
https://gist.github.com/al3xtjames/64ac677568ba786ed2a1823891157d0d
Additional context
I think this broke with the recent cudaPackages changes, but I haven't figured out the responsible commit.
Notify maintainers
@viric
@samuela
@SomeoneSerge
@ConnorBaker
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.61-hardened1, NixOS, 24.05 (Uakari), 24.05.20231204.2c7f3c0`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos"`
 - channels(alex): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

Not directly relevant but we should rename withCuda -> cudaSupport for consistency at some point.


[aes] Remove hierarchical paths in DOM S-Box

This resolves lowRISC/OpenTitan#10180.

Please don't merge this yet, I am currently running formal verification - just to be on the safe side.

Update, after some more thinking and analyzing the number of flops ending up in the list I realized that:

By moving the instantiation of the pipeline registers to the outside of the DOM-dep multipliers, we can enable the sharing of pipeline registers between the DOM-dep multipliers in Stage 3. This saves another 4 FFs per DOM S-Box and the design becomes slightly more readable.
We should also use prim_flops for the PRD buffering. Otherwise synthesis tools might optimize away some of these flops because they realize that the downstream circuit only evaluates their outputs in one particular clock cycle. This will introduce unnecessary SCA leakage. (Vivado luckily doesn't do this).
The keep_hierarchy constraints in the Yosys synthesis script should be applied to all primitives, not just prim_bufs.

@msfschaffner do you have an easy way of identifying how many FFs DC ends up with? We should check this number. With the last version it's 147 FFs per S-Box.


Removed OTBR script folder

What changed
Removed scripts/OTBR script folder, since the OTBR scripts were moved to under backend/test_collection folder
Related issue
https://github.com/project-chip/certification-tool/issues/101

Should the backend SHA be updated to a commit where these scripts were moved there?

Yes, I will update this PR with the backend SHA as soon as it gets merged.


Add Selenium Swagger-UI Test cases

Swagger-SpringMvc-1.0.2 (/)
Swagger-SpringMvc-2.0.0 (/)

added basic User Read Test sample.


Schema4.Items not working as expected

NJsonSchemaItemsTest.zip
Attached is a recursive test that compares how NewtonSoft can get hold of all Properties and Items for a given Schema, while NJsonSchema does not get the Items' properties...
Schema:
{
  "typeName": "ClassRoom",
  "additionalProperties": false,
  "type": "object",
  "required": [
    "Id"
  ],
  "properties": {
    "Id": {
      "type": "integer"
    },
    "Name": {
      "type": "string"
    },
    "Size": {
      "type": [ "integer", "null" ]
    },
    "Students": {
      "type": "array",
      "items": {
        "type": "object",
        "properties": {
          "Age": {
            "type": [ "integer", "null" ]
          },
          "Name": {
            "type": [ "string", "null" ]
          }
        }
      }
    }
  },
  "$schema": "http://json-schema.org/draft-04/schema#"
}

Output of the test:
NJsonSchema - Properties >> Items:
NJsonSchema Property: Id
NJsonSchema Property: Name
NJsonSchema Property: Size
NJsonSchema Property: Students

Newtonsoft.Json.Schema - Properties >> Items:
Newtonsoft Property: Id
Newtonsoft Property: Name
Newtonsoft Property: Size
Newtonsoft Property: Students
*Newtonsoft Item:  |
Newtonsoft Property: Age
Newtonsoft Property: Name*

If only a single schema is defined for an array, then you have to access it with the Item property instead of the Items property. See
https://github.com/NJsonSchema/NJsonSchema/blob/master/src/NJsonSchema/JsonSchema4.Serialization.cs#L78

The question here is whether these two properties should be merged together (as you originally expected).
The drawback is that a collection with a single item will be automatically converted to a single schema (without array) and thus as conversion roundtrip (i.e. deserialize schema => serialize schema) may fail (i.e. not the same output).

Even if there is a single schema defined for an array, shouldn't Item be part of the Items property ideally (Items will just return the single Item in the collection like NewtonSoft does)?

We could Item change so that it only modifies the Items property and sets or removes its collection with one item...

And what returns Item when Items contains multiple items?

Just remove the _Item _ property to avoid confusion? Just have Items (for either single or more items).

Regarding your comment:

The drawback is that a collection with a single item will be automatically converted to a single schema (without array) and thus as conversion roundtrip (i.e. deserialize schema => serialize schema) may fail (i.e. not the same output).

With NJsonSchema:
Console.WriteLine(JsonConvert.SerializeObject(njsonSchema, Formatting.Indented)); {   "typeName": "ClassRoom",   "additionalProperties": false,   "type": "object",   "required": [     "Id"   ],   "properties": {     "Id": {       "type": "integer"     },     "Name": {       "type": "string"     },     "Size": {       "type": [         "integer",         "null"       ]     },     "Students": {       "items": {         "type": "object",         "properties": {           "Age": {             "type": [               "integer",               "null"             ]           },           "Name": {             "type": [               "null",               "string"             ]           }         }       },       "type": "array"     }   },   "$schema": "http://json-schema.org/draft-04/schema#" }
While with Newtonsoft Schema:
Console.WriteLine(JsonConvert.SerializeObject(jsonNetSchema, Formatting.Indented)); {   "typeName": "ClassRoom",   "type": "object",   "additionalProperties": false,   "properties": {     "Id": {       "type": "integer"     },     "Name": {       "type": "string"     },     "Size": {       "type": [         "integer",         "null"       ]     },     "Students": {      ** "type": "array", **      "items": {         "type": "object",         "properties": {           "Age": {             "type": [               "integer",               "null"             ]           },           "Name": {             "type": [               "string",               "null"             ]           }         }       }     }   },   "required": [     "Id"   ] }

Actually, both of them have the Type:Array retained. Updated the formatting above. So it should not be a problem moving Item to Items?

(Please use three ` at the beginning and end of source code blocks here so that they are formatted correctly)

The output of both libraries is correct: Only the items is allowed on the JSON Schema... NJsonSchema introduces the Item property for better access/readability

Yeah, so would be populating _Items _too now (even if there's a single Item)?

As you can see here:
http://spacetelescope.github.io/understanding-json-schema/reference/array.html
the two properties cannot be merge because
Item = Schema

is not the same as
Items = new List { Schema }

This is because the Item schema validates every item in the array and Items validates a tuple...

All I'm saying is the Type of the property should decide how it's interpreted/represented.  It's confusing when we declare something as an array, but have to probe the **Item **property instead of **Items **. In the above example, what I've been using so far with NewtonSoft is property.Items to fetch properties recursively of all Items (since I declared Students as an Array). With NJsonSchema, I need to first check if Item != null, else, probe Items. Not a big deal, but a bit confusing...

Yes, but the semantics is different:

Item: Array with uniform items (all have the same schema)
Items: Tuple array with different items

Having Item and Items with one schema is not the same and thus we need both... How does Json.NET solve this problem?

NewtonSoft: IList<JSchema> Items. (did not look into the details)
In NJsonSchema case, If Item was an array like you said, it would have been nice (but probably more confusing :-)), but it's just an instance of type JsonSchema4 - right?

The problem is, that the validator has to differentiate between a single item and a list with a single item and this is not possible with a single list property...
The only way to solve this is to make the Items property of type object so that assigning a schema or a list of schemes are allowed...

Yeah, that is what I was about to say...In example from the link above, setting the Type to object (instead of number) would mean I can have different objects with different properties (which is what I have currently and NewtonSoft is handling fine)...
  "type": "array",
  "items": {
    "type": "object"
  }
}```

Yes, but this should work with NJsonSchema too if you set the Item property...

Just to complete this.
Schema
{ "type": "array", "items": { "type": "number" } }

Data:
[5, true]

INVALID
Schema
{ "type": "array", "items": [{ "type": "number" }] }

Data:
[5, true]

VALID

Got you. I guess Newtonsoft conditionally handles it somehow making use of other properties like UniqueItems


Import of bibliography in CSL JSON

E.g. we should be able to read:
[
	{
		"id": "http://zotero.org/users/local/V2QRG5IH/items/JNF5KMDK",
		"type": "article-journal",
		"title": "Object vision to hand action in macaque parietal, premotor, and motor cortices",
		"container-title": "eLife",
		"volume": "5",
		"source": "CrossRef",
		"URL": "https://elifesciences.org/articles/15278",
		"DOI": "10.7554/eLife.15278",
		"ISSN": "2050-084X",
		"language": "en",
		"author": [
			{
				"family": "Schaffelhofer",
				"given": "Stefan"
			},
			{
				"family": "Scherberger",
				"given": "Hansjörg"
			}
		],
		"issued": {
			"date-parts": [
				[
					"2016",
					7,
					26
				]
			]
		},
		"accessed": {
			"date-parts": [
				[
					"2018",
					3,
					12
				]
			]
		}
	}
]

and map accordingly to our internal schema:
JournalArticle.schema = {
  type: 'journal-article',
  authors: { type: ['person'], default: [] },
  editors: { type: ['person'], default: [] },
  articleTitle: { type: 'text', optional: true },
  source: { type: 'string', optional: true },
  volume: { type: 'string', optional: true },
  issue: { type: 'string', optional: true },
  year: { type: 'string', optional: true },
  month: { type: 'string', optional: true },
  day: { type: 'string', optional: true },
  fpage: { type: 'string', optional: true },
  lpage: { type: 'string', optional: true },
  pageRange: { type: 'string', optional: true },
  elocationId: { type: 'string', optional: true },
  doi: { type: 'string', optional: true }
}

More publication types here:
https://github.com/substance/texture/blob/master/src/entities/EntityDatabase.js
I will do a first shot and then get help from @zuphilip.

We'll start working on support to import CSL/JSON records.
@Integral in order to fetch recoreds from DataCite we can use the following url:
https://data.datacite.org/application/vnd.citationstyles.csl+json/DOI
E.g.
https://data.datacite.org/application/vnd.citationstyles.csl+json/10.5063/f1m61h5x

New Modal shown after clicking "Add Reference(s)".

@michael You can use content negotiation for CSL JSON on doi.org directly, which then should work for DataCite, Crossref as well as mEDRA, e.g.
curl -L -H "Accept: application/vnd.citationstyles.csl+json" https://doi.org/10.5063/f1m61h5x

See also https://citation.crosscite.org/docs.html#sec-4

@zuphilip thanks for the tip! We finished a first version using DataCite but definitely makes sense to use doi.org and content negotiation. We'll work on that.
@zuphilip if you want you could now take over and improve the CSL/JSON conversion. See: https://github.com/substance/texture/blob/master/src/converter/bib/BibConversion.js

@zuphilp if you had some time to work o. BibConversion.js it would be fantastic. We are almost there with zotero import :)

@jalperin was mentioning this
http://citeas.org/cite/http:/doi.org/10.5281/zenodo.160400

@oliver---- not sure how we could make use of CiteAs. It provides some citation styles and raw metadata (not sure this is also CSL/JSON), I guess it's better to collect the fields and render the styles locally and ad-hoc using Citeproc.js.

My understanding from a very quick look is that it looked up metadata from places other than Crossref. It seems it does, but only of github repos and CRAN/PyPI project pages, so perhaps not so useful, unless they expanded to also pulling metatada using things like Zotero connectors.
Zotero does a good job of pulling metadata from URLs, I wonder if it would make sense to look into that using their code to do this so that we can do better than just matching things with Crossref DOIs.

Here's a Ruby Gem: Terrier that has a simple implementation of this.


⚠ Fortnite has degraded performance

In ddf52bc, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1569 ms

Resolved: Fortnite performance has improved in 885b489.


AutoRestart: looping media files - only video restarts, but not sound

As the title says, in looping media files (the ones with AutoRestart property), the sound track no longer seems to restart, only video does. So we have a situation where video plays/loops indefinitely but the sound plays only once.
This didn't seem to be a problem in theoraplayer 1.0.0, so it looks like the issue was introduced after 1.0.0.

Hmm, odd. Can you reproduce this in the av_player demo? if so, I can probably fix it easily.

I've never used av_player, however I have 100% reproducibility using the Big Buck Bunny movie (bunny.ogv 4.4 MB) and my simple command line program that displays the video using some ASCII-characters. I can send you this program privately if you'd like. When you run the program, you can see that the video loops indefinitely but the sound plays only once. That is not the case if I link my program with libtheorplayer 1.0.0. With the 1.0.0 lib both the video and sound loop forever as expected.
I was able to determine that this difference in behaviour is caused by changes to TheoraVideoClip.cpp and/or TheoraVideoClip_Theora.cpp and no other files. However I didn't figure out yet what change specifically is responsible for this.

sure, send it to me at kspes<!aT!>cateia{D.O.T}com

This issue is still present in the latest master (18-1-2017)

Reproduce by just starting the av demo. When it reaches the end and loops the video will play fine but the sound will not restart and is silent.

ok, cool, we'll investigate and let you know


Unit testing

Let's start using pytest for this project. The sooner the better.

I don't mean to worry you but you have too check your eyesight :wink: The project has pytest for a long long time. Check requirements-test.txt, setup.py and tox.ini. You can run it localy with pytest CLI, with . /setup.py test or using tox.
But yet there are some things to do:

clean tox.ini from obsolete settings
setup Travis CI
setup coveralls service

Closing as wontfix -- already done.


Inconsistency between clear and getKeys

Environment
<EMAIL_ADDRESS>node v20.9.0
Reproduction
Currently getKeys and clear behave differently when they are passed a prefix.
const prefix = 'test';
let keys = await storage.getKeys(prefix);
console.log(keys); // ['test:123', 'test:abc']
await storage.clear(prefix);
keys = await storage.getKeys(prefix);
console.log(keys); // ['test:123', 'test:abc']

clear seems to ignore the prefix if it is not a mount, while getKeys finds all keys which begin with the prefix. Since the options are named the same I had assumed they would behave similarly.
Describe the bug
Is this behavior intentional? Currently I'm working around it by individually deleting keys, but it would be nice if clear also worked.
const prefix = 'test';
let keys = await storage.getKeys(prefix);
console.log(keys); // ['test:123', 'test:abc']
await Promise.all(keys.map((k) => this.storage.removeItem(k)));
keys = await storage.getKeys(prefix);
console.log(keys); // []

Additional context
No response
Logs
No response

Thank you for taking the time to enter this issue--I second!  I am using Redis with Nuxt.  Initially thought that I could make life easier by using clear, but ran into the same.
While I believe the description for clear is technically accurate, i.e., "Removes all stored key/values. If a base is provided, only mounts matching base will be cleared," I do believe that it would be best to provide some kind of "bulk delete" capability driven by a prefix.  Either that or some kind of guidance with respect to how to efficiently perform the series of necessary atomic deletes.  As it stands, it looks like I will have to do what you are doing and additionally augment with something to limit the concurrency:
export const invalidateCache = async ({ group = getEnv(), name = "", key = "", } = {}) => {
  const prefix = [group, name, key].filter((v) => v != null).map((v) => String(v).replace(/[^\w]/gi, "")).join(":");
  const keys = await useStorage("cache").getKeys(prefix);
  // TODO: impose concurrency limit
  await Promise.allSettled(keys.map(async (k) => {
    console.debug("purging", k);
    await useStorage("cache").removeItem(k, {
      removeMeta: true
    });
  }), );
  // In an ideal world something like the following would work
  // await useStorage("cache").clear(prefix);
};

nuxt.config.ts
nitro: {
    storage: {
      cache: {
        driver: "redis",
        username: process.env.NUXT_REDIS_USERNAME,
        password: process.env.NUXT_REDIS_PASSWORD,
        url: process.env.NUXT_REDIS_URL,
      },
    },
  },

I would imagine that this is a common use case.  This could just be ignorance/user error on my behalf (wouldn't be the first time).  If anyone is more clueful, I am all ears.  Thanks again for this great project. 👍


Weird render effect in IDEA

Thanks for your great work!
I'm making a new monospace variable font and instantiate it using: ftcli converter vf2i {input_file} -out {output_ttf}
Everything works well until I encounter a issue https://github.com/subframe7536/maple-font/issues/182. The character spacing will change between different font weights in small font size, and the issue resolved when the font is exported by FontLab.
I need some help to deal with this issue, thanks🙏

Can the fonts with the issue be posted here?

sure, just the release file

ttf
Also, thanks for point that out. I have poor knowledge in font tables

I have PyCharm and have the same issue for the Thin and ExtraLight cuts,
The issue seems to disappear it I change the usWeightClass as follows:
Thin: 100 -> 250
ExtraLight: 200 -> 275

See image

Let me know if it works for you.
More: I have fixed the name table, so keep these files:
MapleMono-TTF (fix).zip

More: I have fixed the name table, so keep these files: MapleMono-TTF (fix).zip

I test with Light and Regular, it works well, but the usWeightClass in Light is not changed. How to make it possible?

To show the name table viewer: ftcli print font-names PATH
This is how I patched the fonts:
In the MapleMono-TTF folder, run ftcli assistant ui .

Recalculate the values by pressing c and using the default choice (0)

Look how the weight class changed:

Now, press x to exit and run the following:
ftcli assistant commit . -ls 400 700

Final touch, to delete all names from the Macintosh table except 1, 2, 4, 5 and 6:
ftcli name del-mac-names .

Read more about the usWeightClass < 250 issue here: https://forum.glyphsapp.com/t/weight-classes-differences-in-glyphs-2-5/8701

I test with Light and Regular, it works well, but the usWeightClass in Light is not changed. How to make it possible?

Because Light has usWeightClass value = 300, that is greater than 250

Thanks for such detailed guide!

Because Light has usWeightClass value = 300, that is greater than 250

But as for Jetbrains Mono, it renders correctly, even if it has 100 for Thin and 200 for ExtraLight (which I reference from)
I finally fix it in my local machine by load and save the variable font 😅
https://github.com/subframe7536/maple-font/commit/f5e5307da7059e8a45bc03bd0a8459aaa5e5775a

But as for Jetbrains Mono, it renders correctly, even if it has 100 for Thin and 200 for ExtraLight (which I reference from)

Yes, Light should work well regardless of the weight classes of other cuts. The issue if for styeles with usWeightClass lower than 250, so 300 is not affected.
Do you still face the issue? I closed PyCharm, uninstalled the first version, installed the patched files (all the family) and the re-opened PyCharm.

Noop, it is solved by following your guide. Just try to find out the reason.
Moreover, is there any way to process it programmly? the ftcli assistant ui . seems to have no option to run without interaction

If the fonts you export from variable have the correct usWeightClass values, you could just run:
ftcli assistant init .
ftcli assistant commit . -ls 400 700

If Thin and ExtraLight are still 100 and 200, it's a bit more complex. The tool is not thought to be command-line only because every designer uses his custom style names (Hairline, UltraLight, ExtraThin) or uses the default names for different weight classes (sometimes Book is 350, other times 450). So fine tuning requires manual intervention.
A command to recalculate values without interaction could be added, but you must be sure that the styles mapping (see ftCLI_files/styles_mapping.json file) is correct. I'll think about it and in case I'll make a release.

I have setup Extralight and Thin and try to fix it in https://github.com/subframe7536/maple-font/commit/c5a04b8d2ff64b5fdcea77597ee977066b240cfe, but still have no effect unless manually run the ftcli assistant ui .. I think it may be solve by the recalculation

Fonts have italic bits not properly set, be careful. And still the names are messed.
Try the following (order is important):
ftcli fix italic-angle .
ftcli assistant init .
ftcli assistant commit . -ls 400 700

hmmm... it correctly rendered when fix the name, but the option fails

That's correct. The fonts are grouped under the same family and you can choose the regular and bold styles under the Typography Settings panel.
Try to install on Windows the files int the 250&275.zip archive you posted before. On Windows 10, I only get 9 styles installed. The other 7 become accessible once I uninstall the others.
A basice principle: NameID 2 can have only the following values: Regular, Italic, Bold, Bold Italic.
Not correct:
NameID1: Maple Mono
NamiID2: ExtraBold

Correct:
NameID1: Maple Mono ExtraBold
NameID2: Regular
NameID16: Maple Mono
NameID17: ExtraBold

This is what the ftcli assistand does: apply the weight/width class values from the CSV file, set the Bold/Italic/Oblique bits and correctly compile the name table.

Anyway, what's your process? You convert the variable fonts to static? And then?

Everything works now😊 I am deeply thankful for your thorough investigation and help in addressing this problem😘

Seems that Regular / Italic / Bold / Bold Italic should remove NameID 16 & 17
https://github.com/subframe7536/maple-font/issues/183

Yes, they are not added (or automatically deleted if present) when you use the -ls/--linked-styles option. They were still present?

Oh... Find that I call them before manually setup the name
Everything works well

I'd check the uni0259 contour in MapleMono-ExtraLightItalic, seems broken.
More: after the variable to static conversion, I'd add a line to check the contours of the TTFs
run(f"ftcli fix italic-angle {output_ttf}")
run(f"ftcli ttf fix-contours {output_ttf}")
run(f"ftcli assistant init {output_ttf}")
run(f"ftcli assistant commit {output_ttf} -ls 400 700")
shutil.rmtree(path.join(output_ttf, "ftCLI_files"))

This ensures that the contours direction is correct and that overlaps and tiny paths are removed.
A tiny path is present in the 'thorn' glyph of MapleMono-Bold
Before:

After:

Thanks for so much wonderful tools!


How to restart training?

 I figured I could do this with the --restart_every argument. So I set it to 58k secs but when it reaches that it just exits

How would I make it restart by itself?
Windows 10, rtx 3070

https://github.com/autonomousvision/stylegan_xl/blob/223430d0adb5eabee9f7e38e0bce73fc4b1818f6/training/training_loop.py#L133

Could you elaborate on what you mean with that?

The argument of --restart_every is the time interval in seconds to exit code. So this works as intended.
What is stopping you from starting the program again after it exited?

Yeah I noticed it resumes. But would you know a way? I might just open a bunch of anaconda prompts and have them offset by 58k secs. I can't always manually restart it because I'm on holiday


Signalling 8 to refresh doesn't work

As the title says, script doesn't refresh when I signal 8 with pkill. But instead, if I run nwg-wrapper with --sig_refresh 7 flag, it does work if I signal 7. I have no idea why. Also, 7 is just random and 8 is the default of nwg_wrapper. Any help appreciated. Thanks.

I guess this is where things go wrong:
https://github.com/nwg-piotr/nwg-wrapper/blob/89af959d7099b9d2ca82761ea618504c424e87b1/nwg_wrapper/main.py#L229
    parser.add_argument("-sr",
                        "--sig_refresh",
                        type=int,
                        default="99",
                        help="custom Signal number to refresh the script; default: 8")

Opened a PR in:
https://github.com/nwg-piotr/nwg-wrapper/pull/25

Fixed with: https://github.com/nwg-piotr/nwg-wrapper/pull/25


Mockup: icons in list items for alerts pertaining to linodes

making an item to look at this when we get to alerts

Labelled banners because they pertain to the same alerts


[ansible/runner.rb] Add additional python3 module path for Centos8 support

Fixes https://github.com/ManageIQ/manageiq/issues/20309
Adds the mentioned module path to the list.  The list is verified for which ones are valid at runtime, so it isn't required that all of the ones listed exist.
Links

https://github.com/ManageIQ/manageiq/issues/20309

Jansa backport details:
$ git log -1
commit ca9bebad0d4f641817125f86dbd0dd395556bf48
Author: Jason Frey<EMAIL_ADDRESS>Date:   Mon Jul 6 11:59:27 2020 -0400

    Merge pull request #20322 from NickLaMuro/embedded-ansible-add-pythonpath-support-for-centos8

    [ansible/runner.rb] Add additional python3 module path for Centos8 support

    (cherry picked from commit 85f5177f93dfe5c4d7ee3a50e8211f9bbbd9ab8c)


Support edition keyword

Hi 👋🏻
I'm testing protobuf editions and the lsp complains about the keyword.
Editions is a big topic so maybe we can start small and only add support for the keyword?

Yeah this is related to the tree sitter parser. I believe, I can work on that here: https://github.com/coder3101/tree-sitter-proto

https://github.com/coder3101/tree-sitter-proto

Thank you, would like to help but I'm not familiar with how tree sitter works.

https://github.com/coder3101/tree-sitter-proto/pull/1 added support for edition. I am going to drop this to master now.


Add support for raw JQL

User should be able to pass raw JQL, user-supplied JQL should override other filters if passed to prevent confusion
example:
/jira-cli issue -j "assignee in (currentuser())"

Closing since the codebase has diverged a lot.


hierarchy parameter in library call

Hi
I am currently using KaFFPa program to obtain hierarchical partitions for FEM meshes. Do you plan to support this "-hierarchy_parameter_string" in the library call as well?
Using the file interface is cumbersome as we need to integrate KaHIP with our mesh partitioning tool.
Cheers!

Thanks, I managed to roll out my own graph_io::readGraphWeighted for our HDF5 mesh file and used a modified version of app/kaffpa.cpp to directly partition our mesh.
And thanks for the misc/cpp.vim syntax file and highly readable code base !


Transforms Documentation changes

Adds LinearTransformation to docs (closes https://github.com/pytorch/vision/issues/346)
Adds RandomApply, RandomChoice, RandomOrder to docs as well
Arrange the transforms is alphabetical order.

cc: @alykhantejani

Thanks!


Add documentation template

Empty template for documentation.
added a little logo because why not

Pull Request Test Coverage Report for Build 424

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.812%

Totals

Change from base Build 406:
0.0%

Covered Lines:
2904

Relevant Lines:
3163

💛  - Coveralls

@keon It is really awesome!


Feature/rework templates db schema

Summary | Résumé
closes https://github.com/cds-snc/platform-forms-client/issues/1480
What is left to implement:

Migration code for existing templates
Tweak to terraform code since the submission object has been replaced by deliveryOption (also it is not part of the form JSON config anymore). See changes in submit.ts
Fix broken tests

Test instructions | Instructions pour tester la modification

TBD

Unresolved questions / Out of scope | Questions non résolues ou hors sujet

TBA

Pull Request Checklist
Please complete the following items in the checklist before you request a review:

[ ] Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
[ ] The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
[ ] If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
[ ] Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
[ ] Does your code have adequate comprehensible comments? Do new functions have docstrings?
[ ] Have you modified the change log and updated any relevant documentation?
[ ] Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
[ ] If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

Nice!  Definitely on the right track.

Looks good from my local testing - thinking I got my DB into an odd state as I'm seeing this now that I swap back to develop but dropping this here in case anyone else ends up seeing this as well.

Yes you will have to run a yarn prisma:reset since the migration only works in one direction 😕


feat: e2e test suite

Add E2E test suite with 3 Ojo nodes and a price-feeder instance. The 3rd validator created has greater than 50% of the total supply and delegates its price-feeder voting to the 2nd validator.
Add OjoClient for easy GRPC use
Add GRPC tests for testing oracle functionality with a running chain and active grpc connection

Note: The median deviation e2e test is legitimately failing because some of the code added to the grpc endpoint on Umee still needs to be ported over but this should be done in a separate PR.
Matching price-feeder PR: https://github.com/ojo-network/price-feeder/pull/40
ref: https://github.com/ojo-network/ojo/issues/81, https://github.com/ojo-network/ojo/issues/12

Codecov Report

Merging #103 (f44a7e4) into main (0b56c97) will increase coverage by 0.33%.
The diff coverage is 18.58%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   17.11%   17.44%   +0.33%
==========================================
  Files          40       40
  Lines       10658    10665       +7
==========================================
+ Hits         1824     1861      +37
+ Misses       8746     8712      -34
- Partials       88       92       +4

Impacted Files
Coverage Δ

x/oracle/keeper/params.go
64.28% <0.00%> (ø)

x/oracle/types/oracle.pb.go
0.49% <0.48%> (+<0.01%)
:arrow_up:

x/oracle/abci.go
76.69% <57.14%> (-1.88%)
:arrow_down:

x/oracle/types/params.go
81.72% <81.25%> (-0.50%)
:arrow_down:

x/oracle/types/reward_band.go
86.36% <86.36%> (ø)

tests/simulation/state.go

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

For these:
  Error: exported: type name will be used as query.QueryClient by other packages, and that stutters; consider calling this Client (revive)
  Error: exported: type name will be used as tx.TxClient by other packages, and that stutters; consider calling this Client (revive)

I know I asked for the QueryClient / TxClient change, but I guess just client makes more sense when considering go packages (my bad)
As far as the unused rules, idk why it's triggering since they are used functions

No worries, I'll switch these back. I just pushed up a refactor to appease the unused method linter.

this looks like it's ready to be merged - @zarazan can you make sure there's an active GH issue for the median failure, then merge 🙏


Inner functions and classes not part of the generated output

Hello,
Quick snippet:
(function(ns) {
/** @constructor */
function Lala() {

}

/** some Lala member */
function isLala() {
}

ns.isLala = Lala.methods({
    isLala: isLala
});

})(window);

All our (numerous) .js files are declared this way, is there any way to make jsdoc "find" them or to do things manually for jsdoc with some extra markup ?

Blows my mind that this still is an issue in 2015

blows my mind this is still an issue in 2015...


Docs do not show many modules on RTD

Bug 💥
Docs have not been processed correctly which is why API doc is incomplete.
Expected behavior  🧮
Full docs on RTD
Screenshots 🖼
If possible, please add a screenshot of the error message, if possible
Desktop (please complete the following information, if any other than the one in the install requirements):

OS: [e.g. iOS]

Additional context 🧬
If necessary add some context related to the problem

V.0.19 has been reactivated and can be chosen from the drop down menu at the bottom left.

There will be new docs shortly on GitHub.io

Docs will remain on RTD

Clsoing with PR #101


api to get signed document url for ccla/icla signature

Summary
write an api to get signed document url for ccla/icla signature
Background
When user sign cla we upload that document to s3
provide an api to retrieve that document
User Story

As a project manager, I want to retrieve the icla,ccla signed document for my cla-group
As a cla manager, I want to retrieve the ccla signed document for my company

Acceptance Criteria
The "done" criteria when this feature or problem is resolved. Such as:

api accept signature_id
response of api is presigned s3 link using which project-manager,cla-manager can download signed document.
project-manager able to download signed icla,ccla document for his cla-group
cla-manager able to download signed ccla document for his company

Endpoint to be tested
https://api-gw.dev.platform.linuxfoundation.org/cla-service/v4/api-docs#operation/getSignatureSignedDocument

Tested and observed that the project-manager of cla group is forbidden to fetch the signed ccla/icla documents
User has project-manager role in IAM for DPDK Core project
User has access to the project in cla-dev-user-permissions table in V1 database
Project Name - DPDK Core
Project SFID - a092M00001IV4ARQA1
CLA Group Name - DPDK-Core CCLA_ICLA_EmployeeICLA_Yes
CLA Group ID - 6430f241-f118-4379-9713-beb68e61fedc

However as per the user story description, cla-managers of the project are able to fetch only the signed ccla document

@nirupamav
I checked it. It is working for project-manager role

@pranab-bajpai
Testing is completed. Could you please review the test plan and let me know if I missed any scenarios
Only for nirupamav user (project-manager) endpoint returns 403 and logged bug #1365 to track the issue. Since it is working for other user moving the ticket to QA Done
https://confluence.linuxfoundation.org/display/PROD/EascyCLA-V2-+Get+signed+ICLA+or+CCLA+document+Test+Plan


Add TOA to AlpacaEval

Add the result of TOA method to AlpacaEval 2.0. TOA is a method of scaling inference compute by sampling from multiple different language models.
paper: https://arxiv.org/pdf/2412.17061
code: https://github.com/oceanypt/TOA

Looks great, congrats 💯


Complete 'Get Help' Utility LI click event

We need to complete the event for the 'Get Help' button in the utility navigation.
@micchickenburger , was hoping you could help.
Visible on line 55-61 in utility.js:
    'click li.getHelp': closeAsides,      'click li.getHelp': function (event) {            location.href='/#service-providers';            $('figure.alert').addClass('active').delay(5000).queue(function(){             $(this).removeClass("active").dequeue();         });     }
We need to scroll down the page to #service-providers and display an alert with content.
Alerts have their own module where their template can be referenced.

Is this still an issue @eoghanTadhg?

This is no longer a visible issue and the button behaves as expected.


Production deployment files

Description

This PR adds a few ingestion-server specific deployment files. These are based off the top level docker-compose and justfile, but are specifically intended for production deployments.
These have currently been used on production to launch & kick off the data refresh.
Testing Instructions

Run just pull locally within the ingestion_server directory, then just up. Note that the image is pulled from Dockerhub and is launched successfully.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

The justfile at the top level directory corresponds to the dev environment, which includes all of the available services (API, analytics, elasticsearch, etc.). For production we only need the ingestion server running. I can try to test this, but I suspect that even if just is run from this directory, the docker-compose file it will pick up is the top level one and so it may attempt to spin up all of the services. If it ends up picking up the docker-compose file in the ingestion_server subfolder then we definitely don't need to duplicate the justfile!

I tested this locally and no matter where you initiate just within the repo, the files it refers to are always relative to the justfile. I've added an IS_PROD variable similar to the catalog which changes the docker-compose file that just references. I ran the steps locally and we can reuse all the ingestion server bits without having to duplicate the justfile!


Documentation - Add webhook secret error message to troubleshoot

When creating a github application without a webhook secret we get this error in our opened PR:
There was an issue validating the commit: "could not validate payload, check your webhook secret?: no signature has been detected, for security reason we are not allowing webhooks that has no secret"
We should add it to the troubleshooting section of the documentation

You mean the secret was not added when creating the app?

You mean the secret was not added when creating the app?

Yes


#716: Fixed gravity on metal layer to avoid animations on size change on iOS

By some strange reason (we've seen this before - and also tried to fix it before) the CAMetalLayer resizes itself in an animated way when changing size.
This is something we don't want, and we've had a few issues regarding this.
This fixes the problem by setting the gravity on the layer to bottom left - this removes the error we're seeing in the reports.
Fixes #716
Simple reproduction - paste into App.tsx in our example. Before this fix the size changes of the image is animated (by Metal / iOS), after the fix changes should happen directly:
import React, { useEffect, useState } from "react";
import { Canvas, Image, useImage } from "@shopify/react-native-skia";
import { View } from "react-native";

const START_SIZE = 200;

const App = () => {
  const [imageSize, setImageSize] = useState(START_SIZE);

  useEffect(() => {
    let interval = setInterval(() => {
      setImageSize(Math.random() * 200 + START_SIZE);
    }, 1000);
    return () => {
      if (interval) clearInterval(interval);
    };
  }, []);

  const skiaImage = useImage(require("./assets/oslo.jpg"));

  return (
    <View style={{ margin: 12 }}>
      <Canvas
        style={{
          width: imageSize,
          height: imageSize,
        }}
      >
        {!!skiaImage && (
          <Image
            x={0}
            y={0}
            width={imageSize}
            height={imageSize}
            image={skiaImage}
            fit="cover"
          />
        )}
      </Canvas>
    </View>
  );
};

// eslint-disable-next-line import/no-default-export
export default App;

I tested this with both the example app I made, and our client production app.
Works great in both! No more animated canvas resizings. Bonus is that canvas drawings after large react state updates (like a light mode / dark mode switch) looks and feel a lot quicker now without the animation.
Thanks a lot!


Notice to Deprecate MetaTransactionWallet and MetaTransactionWalletDeployer Wrappers in ContractKit

The MetaTransactionWallet, MetaTransactionWalletDeployer contracts were created to solve an issue of onboarding new users to Attestation Service v1 which (oversimplifying here) required funds to be sent to pay for sms codes and a small deterence on spamming the system. Since of course new users have no funds typically the MetaTransaction System was setup to allow a third party to pay. The reset of the system (ASv1, Komenci , etc) have all been deprecated and removed)
These are not governance owned contracts. And the original use case is no longer relevent. As such Contractkit will be considering its wrappers for these as Deprecated shortly and will be remove after.
as of writing this does not refer to the actual contracts themselves only the wrappers / use in contract kit
however if you need something similar consider an Account Abstraction standard.

Contracts are expected to get deleted soon, and will not be included in the release 12 of the contracts.
Work in progress here: https://github.com/celo-org/celo-monorepo/pull/10859


ForwardRef error react-spectrum 3.0.0 - 3.0.1

Error when running Firefly app ( web )
in ForwardRef($f01f0d1066865f7027d77d32f5de6fe$var$Picker) (created by App)
    in ModalProvider (created by ForwardRef($bc3300334f45fd1ec62a173e70ad86$var$Provider))
    in I18nProvider (created by ForwardRef($bc3300334f45fd1ec62a173e70ad86$var$Provider))
    in ForwardRef($bc3300334f45fd1ec62a173e70ad86$var$Provider) (created by ForwardRef($d618213cd07bac427c632ce5c90d7$var$Form))
    in form (created by ForwardRef($d618213cd07bac427c632ce5c90d7$var$Form))
    in ForwardRef($d618213cd07bac427c632ce5c90d7$var$Form) (created by App)
    in div (created by ForwardRef($f9fee2c1db386bde8f28b36a814d1eb2$var$Flex))
    in ForwardRef($f9fee2c1db386bde8f28b36a814d1eb2$var$Flex) (created by App)
    in div (created by ForwardRef($f9fee2c1db386bde8f28b36a814d1eb2$var$Flex))
    in ForwardRef($f9fee2c1db386bde8f28b36a814d1eb2$var$Flex) (created by App)
    in div (created by ForwardRef(ProviderWrapper))
    in ForwardRef(ProviderWrapper) (created by ForwardRef($bc3300334f45fd1ec62a173e70ad86$var$Provider))
    in ModalProvider (created by ForwardRef($bc3300334f45fd1ec62a173e70ad86$var$Provider))
    in I18nProvider (created by ForwardRef($bc3300334f45fd1ec62a173e70ad86$var$Provider))
    in ForwardRef($bc3300334f45fd1ec62a173e70ad86$var$Provider) (created by App)
    in ErrorBoundary (created by App)
    in App
Cannot destructure property 'scale' of '(0 , _provider.useProvider)(...)' as it is null.

This error was a result of a change to an inner dependency of react-spectrum.
The suggested path to fix your app is update all @react-spectrum component dependencies versions to "3.0.1" in your package.json file, and then npm install and re-run your app.
(note: you may need to rm package-lock.json and rm -rf node_modules also )
An update to the app generator has been published, so if you want to create a new app with the updated code, please first run aio plugins install @adobe/aio-cli-plugin-app


Transaction endpoints not serializing amount

When using the ruby-sdk I noticed that the transactions endpoints don't return the amount that was processed for a given transaction. I believe these endpoints are using this serializer (I have limited elixir exposure so don't trust me 😬) https://github.com/omisego/ewallet/blob/develop/apps/ewallet_api/lib/ewallet_api/v1/serializers/json/transaction_serializer.ex
Your environment
local rails app using omisego gem connecting to the eWallet API (omise private test env)
Expected behaviour
When calling OmiseGO::Transaction#all_for_user I expect amount to be serialized and returned in the response.
Actual behavior
amount is not serialized

I believe the discussion continued via Rocket Chat with @T-Dnzt. Let me know if you've resolved this issue. :)

amount is now available in the from and to fields since transaction can happen between two currencies with different amounts.
Closing this for now, we will update the Ruby SDK to remove the unnecessary amount field at the top level ;)

👍 Yeah, sorry missed this comment. As Thibault mentioned above.


EXP date from today is NOT expired

If Expiration date is today, it is not an expired product.
Only if the expiration date is in the past, the product is expired
expiry date < today -> expired
expiry date = today -> NOT expired
Please update.

@adiganga2002 see if this is already fixed and move it for qa


[Bug] fix image export failing to loading external stylesheet

https://github.com/uber/kepler.gl/issues/150

https://github.com/uber/kepler.gl/pull/360


Unable to Find Reference of field being in Associated Type

"Find Reference" on field x return "No references found"
struct Foo {
    x: i32,
}

trait Trait {
    type AssocType;
    fn fn_();
}

struct Implementor;
impl Trait for Implementor {
    type AssocType = Foo;

    fn fn_() {
        Self::AssocType {
            x: 0,
        };
    }
}

I think we don't resolve associated types in struct literals at all yet.


Factory is incorrectly swapping lat/long when creating point

I have a location column in my table that is a PostGIS geometry type with SRID 4326 and value<PHONE_NUMBER>E61000005C8FC2F528544B4094FB1D8A02DD18C0. It is the location of Belfast Airport. DataGrip confirms this:

In the createFromGeometry() method of Factory the $geoPHPGeometry object is created, which looks like this:

But then, for whatever reason, Factory is swapping the two coordinates with return new Point($geometry->coords[1], $geometry->coords[0], $srid);, which results in the incorrect point:
> Airport::whereIdent('EGAA')->sole()->location
[!] Aliasing 'Airport' to 'App\Domain\Airports\Models\Airport' for this Tinker session.
= MatanYadaev\EloquentSpatial\Objects\Point {#794
    +srid: 4326,
    +latitude: -6.21583,
    +longitude: 54.6575,
  }

Have I discovered a bug or am I missing something?

I'll check it out later. Meanwhile, can you please fork this repo, write a failing test that reproduces the bug? It will help me a lot.

First @MatanYadaev this is a nice package and thank you for this.
@AlexGodbehere yes I can confirm it is a bug and this is a serious problem.
@MatanYadaev please don't get me wrong, but I need to pinpoint this fundamental problem and potential solution:
Industry standard is lat long order.
Order of these lat|long values should not be changed at any case, cause it is crucial to work.
You correctly have this in class Point construct already:
public function __construct(float $latitude, float $longitude, int|Srid $srid = 0)
but then suddenly this order is changed in Point class with these functions:

getWktData():

public function getWktData(): string
{
    return "{$this->longitude} {$this->latitude}";
}

getCoordinates():

public function getCoordinates(): array
    {
        return [
            $this->longitude,
            $this->latitude,
        ];
    }

It should be the opposite i.e.:
public function getWktData(): string
{
    return " {$this->latitude} {$this->longitude}";
}

getCoordinates():

public function getCoordinates(): array
    {
        return [
            $this->latitude,
            $this->longitude,
        ];
    }

I'm writing this based on Point class in the latest release => 4.2.1
I have not analyzed the whole lib, but it seems that these small changes should fix it all.
I know it is a braking change, but it is better to fix it now then develop code further on wrong assumptions.

@MatanYadaev @AlexGodbehere  a small update,
I've looked at factory code, and unfortunately my proposed small fix would not solve all problems.
protected static function createFromGeometry(geoPHPGeometry $geometry): Geometry
    {
        $srid = is_int($geometry->getSRID()) ? $geometry->getSRID() : 0;

        if ($geometry instanceof geoPHPPoint) {
            if ($geometry->coords[0] === null || $geometry->coords[1] === null) {
                throw new InvalidArgumentException('Invalid spatial value');
            }

            return new Point($geometry->coords[1], $geometry->coords[0], $srid);
        }

Here values were mixed again:
 return new Point($geometry->coords[1], $geometry->coords[0], $srid);
Normally it should be the other way around:
 return new Point($geometry->coords[0], $geometry->coords[1], $srid);
Therefore whole package needs to reviewed again ensuring latitude is in the first place and longitude second in all classes and methods.

Hi @chilio, thanks for the detailed investigation. I'm sorry but I'm not available to investigate it at the moment, will have time in a few days.
But I just wanna say that GeoJSON uses longitude-first approach, and PostGIS, and more. I am aware of map services uses latitude-first approach. I just not sure yet what you say is a serious problem, or a problem at all. Anyway, I need to investigate it to confirm it.

Other then that, I will appreciate if you could push a failing test that will help me reproduce the problem more easily.

Thanks for diving into this @chilio.
I think I understand where the issue is here. My location column did in fact have the columns stored the wrong way around. I think DataGrip was being clever somehow and flipping them for me when displaying the map.
Running the following on the columns sovled this. The map still shows the correct location and this package is happy.
UPDATE airports
SET location = ST_FlipCoordinates(location);

Thanks for this @MatanYadaev - it's a great package.
TL;DR; My coordinates were stored in the database in the wrong order.

Hi @chilio, thanks for the detailed investigation. I'm sorry but I'm not available to investigate it at the moment, will have time in a few days. But I just wanna say that GeoJSON uses longitude-first approach, and PostGIS, and more. I am aware of map services uses latitude-first approach. I just not sure yet what you say is a serious problem, or a problem at all. Anyway, I need to investigate it to confirm it.

Hi @MatanYadaev, you were totally right about GeoJson, WKT, PostGis and others.
So please treat my recommendations as false positives.
I was wrong assuming, that the order of these vars should be consistent at all times,
Therefore even more kudos to your package. handling all these cases.
BTW:
On the other hand, It would be nice, if there was some standard for geo points, meaning order of these vars, then nobody would not have any doubts about it.
Thanks again for your package and sorry for being misleading here. Case closed again.


On Release Build, printer 🖨 is not printing

On debug build, it works flawlessly, but on release build this error message was printed as toast: "Empty print job"
I have tried all possible ways but to no avail.
Kotlin version: 1.6.10
min sdk: 21
target sdk: 33
AGP: 7.2.1
Gradle: 7.4.2
Please help me resolve this issue

https://github.com/google/gson/blob/master/examples/android-proguard-example/proguard.cfg

IF your build.gradle(:app) mihify & shrink ?
...
buildTypes {
release {
minifyEnabled true
shrinkResources true
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
}
}
...
THEN
add in your project
proguard-rules.pro:
-keep class rawbt.** { *; }

update
implementation 'com.github.402d:RawbtAPI:9238fdefc6'
Is it help (without strings from previus answer)?

IF your build.gradle(:app) mihify & shrink ?
    buildTypes {
        release {
            minifyEnabled true
            shrinkResources true
            proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
        }
    }

THEN add in your project proguard-rules.pro:
-keep class rawbt.** { *; }

Thank you 😊
Issue solved
Proguard was the problem

update implementation 'com.github.402d:RawbtAPI:9238fdefc6'
Is it help (without strings from previus answer)?

The previous answer solved it for me. Thank you 😊

BTW I crested a Flutter plugin for android with this library.
Check it out ✔


grpc client retries for metadata

https://github.com/grpc/proposal/blob/master/A6-client-retries.md

related issue #11158


Use String.prototype.repeat() in a couple of spots

Rather than using a temporary Array to manually create repeated strings, we can use String.prototype.repeat() instead.
The reason that we didn't use this from the start is most likely because some browsers, notably IE, didn't support this; note https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat#browser_compatibility

/botio unittest


Split project into ravenpy and the WPS server

Description
The python wrapper should be extracted from this repo and live in its own repo.
This repo would only contain WPS services.

Talked to the CSHS folks. We can get for sure a project there: https://github.com/CSHS-CWRA
I will just need to tell them from which GitHub to import. Or if they should just create an empty one with a licence (do you prefer one?) and a name (RavenPy?!).

An empty one will do. MIT license. ravenpy. And permissions to maintain the repo.

I've created the new project RavenPy under CSHS. I just became the admin of the whole CSHS GitHub.
I gave @dustming and @richardarsenault write permissions and @huard admin permissions. Let me know whom else you'd like to have added. For now it is private but I can make it also public if you'd like to.

Thanks! Please make it public, otherwise release could be difficult.

Done!


Update to Apache Lucene 9.6.0-snapshot-8a81515

Description
Update to Apache Lucene 9.6.0-snapshot-8a81515
Issues Resolved
N/A
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Gradle Check (Jenkins) Run Completed with:
* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/12776/

* **CommitID:** [94ffd1f](https://github.com/opensearch-project/OpenSearch/commit/94ffd1fcaae657fceb5ad182d36f1d6be5e81e63)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

2 failures (seem related to the change):
org.opensearch.index.mapper.SearchAsYouTypeFieldTypeTests.testPrefixQuery
java.lang.AssertionError:
Expected: <a_field:toolongforourprefixfieldthistermis*>
     but: was <a_field:toolongforourprefixfieldthistermis*>

org.opensearch.join.query.HasChildQueryBuilderTests.testToQueryInnerQueryType
java.lang.AssertionError:
Expected: an instance of org.apache.lucene.search.ConstantScoreQuery
     but: <_id:([ff 69 64])> is a org.apache.lucene.search.MultiTermQueryConstantScoreBlendedWrapper

Codecov Report

Merging #6790 (9a10aad) into main (f40fa82) will increase coverage by 0.01%.
The diff coverage is 69.23%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #6790      +/-   ##
============================================
+ Coverage     70.75%   70.77%   +0.01%
+ Complexity    59230    59229       -1
============================================
  Files          4810     4810
  Lines        283487   283491       +4
  Branches      40877    40877
============================================
+ Hits         200577   200631      +54
- Misses        66408    66436      +28
+ Partials      16502    16424      -78

Impacted Files
Coverage Δ

.../org/opensearch/index/mapper/RangeFieldMapper.java
87.93% <0.00%> (-0.69%)
:arrow_down:

...org/opensearch/index/mapper/BinaryFieldMapper.java
78.31% <80.00%> (-1.94%)
:arrow_down:

server/src/main/java/org/opensearch/Version.java
78.57% <100.00%> (+0.47%)
:arrow_up:

... and 487 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks @Poojita-Raj , AFAIK the 9.6 snapshot still uses Lucene95 codec [1], where have you seen Lucene96 usage, I may have missed that, thank you.
[1] https://github.com/apache/lucene/blob/branch_9x/lucene/core/src/java/org/apache/lucene/codecs/Codec.java#L58

Thanks @Poojita-Raj , AFAIK the 9.6 snapshot still uses Lucene95 codec [1], where have you seen Lucene96 usage? I may have missed that, thank you.
[1] https://github.com/apache/lucene/blob/branch_9x/lucene/core/src/java/org/apache/lucene/codecs/Codec.java#L58

Oh sorry, I misunderstood from the name of the snapshot that it uses a revised codec.

@nknize mind to take a look? thank you

@nknize @dblock please need your review


Remove dynmaic analysis

Description
The dynamic analysis has been removed. The documentation, the CLI output and the tests have been adapted.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?

[x] Manual tests

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[ ] I have added new items to the golden standard
[x] I have written/updated the Markdown file with the description of the implemented rule

Thank you, I refined the rule documentation a bit more, but otherwise it looks good to me! Well done!


Developer Workflow missing

Currently a well defined developer/contributor workflow doesn't exist for this project. It'd be good to have a few things

[ ] Well defined developer workflow documentation - #96
[ ] Well defined new contributor workflow documentation
[ ] Automations to support these workflows

Created #112 after getting motivated by this issue 😄 💥


rs-fw-logger - enforce user input validation

Check user-provided input during regex operations to avoid buffer overflow.
Tracked on: DSO-14405

Looks good


Server logfile auto-delete (several GB after a few months)

Hi there,
I'm still using this amazing script that is wonderfully improved every time i need to download it again, and i'm very thankful for that !
By the way, i just migrated a few servers these days, and my gosh, i noticed that server logfiles aren't auto removed ! On our biggest servers on Gmod, it was more than 4GB of logiles in /log/server and a lot of files, so that was the longest thing to copy from one server to the other !
I was just thinking : why not auto-remove those just like you're doing with both the script and console logfiles ?
Also, as a bonus, it could be nice to be able to setup the amount of logfiles we want to keep into the "gameserver" script.
Thanks for your attention.
PS : Kept a screenshot of the sledbuild server's logfiles... :p http://image.noelshack.com/fichiers/2015/18/1430193284-logiles-size.png

My most recent commit addresses this as I discovered the same issue :-)

Great minds think alike :o))
Well, maybe you could do something to cleanup default server's logs too, as they don't cleanup neither, but i'm not sure it's the script's logic to fix srcds' lacks of convenience.
Also but consider this as less than optional, as this is probably hard and boring to code, i'm giving the idea just in case : some plugins and addons are flooding logs too (i actually had a total of 10GB of logs in 6 months onto the DarkRP server), so if we could specify some log folders to cleanup too, with exclusion for some files that are sometimes not logs, it'd just be magic.

I like this idea. And wouldn't be to difficult to implement. I would need to know where the logs are stored or if there is a variable in the mods config file for this. It can be something that I look in to at some point :-)

As you probably know, srcds logs are located in serverfiles/gamename/logs , but addon's logs can be found in other locations.
One common admin addon for Gmod is the ULX, with logfiles located in: serverfiles/garrysmod/data/ulx_logs
For DarkRP mode, it's serverfiles/garrysmod/data/darkrp_logs
For CSS, Sourcemod admin addon seems to be the most popular, and logs are here : serverfiles/cstrike/addons/sourcemod/logs
As you may also know, Sourcemod seems to be used at least for tf2 too (maybe CSGO, DoD L4D and so on, so maybe a conditional check into the cleanup function ?).
I wish that can be a good start point. Good luck, I'm still available if i can help in any way.

Working on it...
Wait, struggling on it :D
That syntax and those functions are pretty new to me !
mtime, tee... I'm slow but i'll figure this out ! :p

Ended up with something way cleaner to me, future support for logs should be way easier. Pull requesting it !


/actuator/health not work with @EnableConfigServer in Finley.M9

using @EnableConfigServer with the following dependency cause /actuator/health reponse {status : "DOWN"}, but all works...
<dependency>
     <groupId>org.springframework.cloud</groupId>
     <artifactId>spring-cloud-config-server</artifactId>
</dependency>

Magically auto-solved


chore(pipelines): update to pipelines version 2.5.3

Updates pipelines to version 2.5.3.
The pipeline now works in 2 stages. First, it will deploy the changes to the Azure App Service Slot called "staging". Then it will swap the "production" and "staging" slots. Since there is an approval step in between, this gives the possibility to run some smoke tests against the staging slot.
The deployment is now done via a webhook from the pipeline (instead of previously from the container registry) so this fixes the issue where the webook was being sent over the internet instead of via the Virtual Network.

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix user login via LDAP (refs #1489)

User parameter was not a table anymore, and first parameter of 'is_in_group' should be the user's dn

Hi @fpeyraud, this proposed change is not valid (although it may fix problem in your env.). I'll explain in the issue #1489. Correct fix is in PR #1523.

Explanation better here. Having following LDAP structure with a (POSIX) user account and group:
dn: cn=cloud,ou=Group,dc=example,dc=org
objectClass: top
objectClass: posixGroup
cn: cloud
gidNumber: 30000
memberUid: ldapuser1

dn: uid=ldapuser1,ou=People,dc=example,dc=org
objectClass: top
objectClass: account
objectClass: posixAccount
objectClass: shadowAccount
cn: ldapuser1
uid: ldapuser1
uidNumber: 30000
gidNumber: 30000
homeDirectory: /home/ldapuser1
loginShell: /sbin/nologin
gecos: OpenNebula LDAP user
shadowLastChange: 17058
shadowMin: 0
shadowMax: 99999
shadowWarning: 7

For group membership checks, you need to specify attributes on both sides which define the user-group relationship. In this case, the relevant OpenNebula LDAP configuration (http://docs.opennebula.org/5.4/deployment/authentication_setup/ldap.html#configuration) parameters are:

:group_field: 'memberUid'     # ... attribute in the group entry which references to the user
:user_group_field: 'uid'         # ... attribute in the user entry which identifies the user in the group entry

-        if !ldap.is_in_group?(user_group_name, server_conf[:group])
+        if !ldap.is_in_group?(user, server_conf[:group])

The proposed patch fallbacks to using just user login for user-group membership matching, which is a valid for the example tree above, but not in general. We really need to use use_group_name (value of the user_group_field), we can't assume everybody is just using login there.
For example, the following example of the ActiveDirectory tree:
dn: CN=cloud,CN=Groups,DC=example,DC=org
...
member: CN=test test,CN=Users,DC=example,DC=org
member: CN=user A,CN=Users,DC=example,DC=org
member: CN=user B,CN=Users,DC=example,DC=org
member: CN=user C,CN=Users,DC=example,DC=org

dn: CN=test test,CN=Users,DC=example,DC=org
...
cn: test test
sn: test
distinguishedName: CN=test test,CN=Users,DC=example,DC=org

... have users' DN for group membership. The PR would break all these environments as it would check group member attributes always just for the login.


New Command R 08-2024 and Command R+ 08-2024 models

Any chance of benchmarking these for the creative writing test?
The new smaller Command R+ 08-2024 now uses GQA so a lot more feasible for people to run on 24GB cards.

Just added these ones on creative writing


[DOC] Documentation of batch ingestion feature

What do you want to do?

[x] Request a change to existing documentation
[x] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
We added this batch ingestion feature, user can now use it to accelerate their ingestion time if the ingest pipeline has ML processors text_embedding and sparse_encoding which connects to external ML servers.
The documentation changes would include a new parameter in _bulk API, a new paragraph in ingest processor to explain the batch enabled processors, and a new page to introduce this feature.
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

OpenSearch core: https://github.com/opensearch-project/OpenSearch/issues/12457
neural-search plugin: https://github.com/opensearch-project/neural-search/issues/743

Thanks, @chishui! Is this being released in 2.15?

Thanks, @chishui! Is this being released in 2.15?

Yes, sorry that I forgot to mention the version

Hi @chishui , what is the ETA for this doc PR? The first release candidate is today. Thanks!

Hi @chishui could you please provide a PR for this since it is labeled for 2.15 and we are approaching the release date?
Thanks.

Since there has been an active discussion on deprecating the parameter we introduced (https://github.com/opensearch-project/OpenSearch/issues/14283), whether we should announce the feature is still pending decision.

Hi @chishui please give a decision on this next Monday/Tuesday.
As we need to stay on the timeline.
If you have concerns including in 2.15.0 I would suggest removing the 2.15.0 label until resurface. That way, this would not be a blocker for 2.15.0 anymore.
Thanks.

Hi @chishui, I removed the 2.15 label. If something changes, we'll be happy to help get the content updated.

PR is raised, can we add the 2.15 label back? Thanks


Identity cookie with claims to long

I am using Claims based Authorization in my application, with like 8 different claims.
Over the last days I saw, that the cookie .AspNet.Microsoft.AspNet.Identity.Application=chunks:4
is getting bigger and bigger. And now I get an exception Bad Request - Request Too Long every time i log in.
How can I manage it to shrink that cookie?
Edit I managed to find a bug in my application, so that the amount of claims a user had increased over time, so I ended up having 660 claims in my application, which produced that enormous header.
But nevertheless: my question: is there an alternative to saving the claims as cookie?

You could do a reference cookie, then use the claims transformation piece to rebuild your actual claims. Basically put the bare minimum you need to identity a user into the cookie and then use the hook as demonstrated in http://benfoster.io/blog/customising-claims-transformation-in-aspnet-core-identity


add support for using P8 authentication tokens

Sorry, I accidentally requested a pull request to this repository. Closing this now.


resources display error x4

after installing CQUI i've got resources view error x4. tried different CQUI versions. my game version is <IP_ADDRESS>
see snapshot please

+1

this is a duplicate topic. i'm sorry guys. please close this.

Update CQUI to the latest nightly. You can download it from here. If you're still having issues, consider checking if your game install is up to date or if another mod you've installed is introducing any incompatibilities.
See issues #180 #184 #192 #267 #268 #499 #555 for further information concerning your issue.
And next time please use search on issue tracker before opening new issues.


Optional git support

Idea:

New option in config.py -> USE_GIT = True.
If USE_GIT is True then:

We try to extract git identity information from users.json for the current user; if found we use that to set the author of the commit.
We use the subprocess module and the PATH environment variable to commit changes.

Avoid adding dependencies to third-party packages for this optional feature.
Keep lines of code to a minimum; explore plug-in approach.

Thoughts?

Alternative implementation using python-git: https://github.com/johniez/wiki/commits/git-support
I have separated IO operations into Wiki class, so after that, Git support can be used just by Wiki subclass: https://github.com/johniez/wiki/commit/d65ba0f9dfcd9b28ff53e623656392e0e3ecbb30

hey @johniez I've reimplemented my fork in django. please, check it out and give me some feedback. https://github.com/mgaitan/waliki


Introducing userToProxyFQN in getProxyUser method.

Pull Request Test Coverage Report for Build 6141

0 of 11 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 44.566%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-hadoop-security-plugin/src/main/java/azkaban/security/HadoopSecurityManager_H_2_0.java
0
1
0.0%

azkaban-hadoop-security-plugin/src/main/java/azkaban/security/AbstractHadoopSecurityManager.java
0
10
0.0%

Totals

Change from base Build 6140:
0.003%

Covered Lines:
17076

Relevant Lines:
38316

💛  - Coveralls