Sending query plan between peloton nodes

This PR mainly provide the function of sending query plan between peloton nodes. The serialization/deserialization for Postgres's nested structure takes a lot of time. The details include:
1.AbstractPlan and SeqScanPlan serialization/deserialization
2.Expression serialization/deserialization
3.Value serialization/deserialization
4.Postgres TupleDesc serialization/deserialization
5.TupleResult serialization/deserialization
6.Refacor protobuf related code
7.Refacor nested loop with IN operator
8.Unit test

The checks failed due to :
04-08-2016 15:24:56 [validate_file:071] INFO : Line ::     TupleDesc tuple_desc = (TupleDesc) malloc(sizeof(struct tupleDesc));
04-08-2016 15:24:56 [:109] INFO : Validation not successful
TupleDesc is a nested structure of Postgres, and it uses malloc and free to handle TupleDesc. So I also use malloc and free in order to reuse postgres's functions

Don't they use palloc? It's managed by MemoryContext and thus safer to use.

Yes, they use malloc in palloc. But I didn't use palloc, due to MemoryContext problem.

@pmenon can you do a code review for the IN + SUBQUERY stuff. I think that we should handle it completely in the transformation phase and not changes the executors.

Sure. Michael, this PR is conflating the RPC stuff and the subquery work.  Since this is failing to build, can you close this request and create two separate ones for the RPC work and the subquery work?

Sure
On 04/08/2016 10:23 PM, Prashanth Menon wrote:

Sure. Michael, this PR is conflating the RPC stuff and the subquery
work. Since this is failing to build, can you close this request and
create two separate ones for the RPC work and the subquery work?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/cmu-db/peloton/pull/128#issuecomment-207684569


Added ABOUT.md with some content recommended by exercism author.

I was shown exercism.io a few days ago and was very impressed. I looked at http://exercism.io/languages/perl5 and saw the following text, which I thought we might as well get rid of by doing as the stub text suggests:
We're missing a short introduction about the language.
Help us by adding a file called ABOUT.md in the docs/ directory of the repo at https://github.com/exercism/xperl5.

This is excellent. I love that it talks a bit about how it's used today. Thank you.


Advice on toolchain caching

So, I have a workflow with a relatively big build matrix composed of many short jobs. As a result, toolchain downloads are one of the CI perf bottlenecks, which leads me to wonder if I couldn't speed things up by caching the toolchain.
Unfortunately, all my attempts at doing so failed so far, IIUC due to a mixture of file permission issues and my lack of knowledge on the directory layout used by the "toolchain" action. I think it would help if you either explained how to do it in the toolchain action's documentation, or clarified that it cannot be done in the current rustup installation directory layout if that's the issue.

It seems we could use this: https://github.com/actions/cache/blob/master/examples.md#rust---cargo

I tried to use it in various ways, but did not quite get it to work. Unfortunately, I did not take notes at the time, and the GH Actions environment is not amenable to quick replication, but from memory...

I tried variants of the usual ~/.rustup directory and got errors saying that it didn't exist.
I noticed that the toolchain output mentioned subdirectories of /usr/share/rust and tried caching things like /usr/share/rust/.rustup, but all I got was lots of file permission errors, most likely because I'm not allowed to write in there.

Since the GH action environment seems to be peculiarly configured in various ways, and does not provide tools for easy experimentation like similar docker containers that you can run on your machine or interactive SSH sessions, documentation and advice on what can be cached and where it's located would be nice.

For what it's worth, I just tried using action/cache@v1 in combination with overriding permissions (to avoid errors), and found minimal difference in speed. It seems the network is the restricting factor, not anything else.

So, for some reason the ~/.rustup directory itself won't be cached properly, but caching its contents works. The following setup works for me:

- name: Cache toolchain
  uses: actions/cache@v2
  with:
    path: |
      ~/.rustup/toolchains
      ~/.rustup/update-hashes
      ~/.rustup/settings.toml
    key: toolchain-${{ hashFiles('rust-toolchain') }}

This caches based on the contents of the rust-toolchain file.

I suspect that ~/.rustup might be a symlink, which would explain why caching it doesn't work while caching its content does. But indeed, I ended up using a similar strategy as yours, and with cache v2 this leads to a net speed improvement at last!
      - name: Cache stable toolchain
        if: github.event_name != 'schedule'
        uses: actions/cache@v2
        with:
          path: |
            ~/.rustup/settings.toml
            ~/.rustup/toolchains/${{ matrix.rust }}-*
            ~/.rustup/update-hashes/${{ matrix.rust }}-*
          key: run-toolchain-rust_${{ matrix.rust }}

Running ls -alh on the home folder shows the following result:
Run ls -alh ~/
total 60K
drwxrwxrwx  11 runner docker 4.0K Apr 19 12:10 .
drwxr-xr-x+  5 root   root   4.0K Apr 16 17:25 ..
-rwxrwxrwx   1 runner docker  220 Apr 16 17:25 .bash_logout
-rwxrwxrwx   1 runner docker   67 Apr 16 17:25 .bash_profile
-rwxrwxrwx   1 runner docker 3.7K Apr 16 17:25 .bashrc
lrwxrwxrwx   1 runner docker   22 Apr 16 17:25 .cargo -> /usr/share/rust/.cargo
drwxrwxrwx   2 runner docker 4.0K Apr 16 17:25 .composer
drwxrwxrwx   4 runner docker 4.0K Apr 19 12:10 .config
drwx------   2 runner docker 4.0K Apr 16 17:28 .docker
lrwxrwxrwx   1 runner docker   17 Apr 16 17:25 .ghcup -> /usr/local/.ghcup
drwxrwxrwx   6 runner docker 4.0K Apr 16 17:25 .nvm
-rwxrwxrwx   1 runner docker  807 Apr 16 17:25 .profile
lrwxrwxrwx   1 runner docker   23 Apr 16 17:25 .rustup -> /usr/share/rust/.rustup
drwxr-xr-x   2 runner root   4.0K Apr 16 17:28 factory
drwxr-xr-x   2 runner docker 4.0K Apr 19 12:10 perflog
drwxr-xr-x   4 runner root   4.0K Apr 16 17:28 runners
drwxr-xr-x   2 runner root   4.0K Apr 16 17:28 warmup
drwxr-xr-x   6 runner root   4.0K Apr 19 12:10 work

Caching /usr/share/rust/.rustup(the destination folder of symlink at ~/.rustup) worked for me.

Turns out that caching the ~/.rustup directory itself now works perfectly fine on actions/cache@v3, so there's no need to drill down into its contents anymore, as the above 3 comments all suggest. Caching the toolchain is pretty simple these days:
- id: cache-rustup
  name: Cache Rust toolchain
  uses: actions/cache@v3
  with:
    path: ~/.rustup
    key: toolchain-${{ matrix.os }}-${{ matrix.rust-version }}

- if: ${{ steps.cache-rustup.outputs.cache-hit != 'true' }}
  name: Install Rust toolchain
  uses: actions-rs/toolchain@v1
  with:
    profile: minimal
    toolchain: ${{ matrix.rust-version }}
    override: true
    components: clippy, rustfmt

Given a list of runner labels (matrix.os) and a list of valid Rust toolchain versions (matrix.rust-version), the above code should create an OS- and version-specific toolchain cache, e.g. toolchain-ubuntu-latest-1.67.1.


Azure devops Pipelines trivy "DB error: failed to download vulnerability DB: database download error"

Hello. Nice to meet you.
I am using trivy in Azure devops Pipelines to scan container vulnerabilities, but I got the error "DB error: failed to download vulnerability DB: database download error". Could you please tell me the cause of this and any solutions or workarounds?

2024-11-25T07:40:29.1089971Z ##[section]Starting: Full Scan
2024-11-25T07:40:29.1093740Z ==============================================================================
2024-11-25T07:40:29.1093885Z Task         : Trivy: Take control of your application security
2024-11-25T07:40:29.1094211Z Description  : Trivy is the world’s most popular open source vulnerability and misconfiguration scanner. It is reliable, fast, extremely easy to use, and it works wherever you need it.
2024-11-25T07:40:29.1094627Z Version      : 1.5.1
2024-11-25T07:40:29.1094710Z Author       : Aqua Security
2024-11-25T07:40:29.1094829Z Help         : Learn more about this task
2024-11-25T07:40:29.1095020Z ==============================================================================
2024-11-25T07:40:29.2527313Z Preparing output location...
2024-11-25T07:40:29.2545273Z Run requested using local Trivy binary...
2024-11-25T07:40:29.2546946Z Finding correct Trivy version to install...
2024-11-25T07:40:29.2548427Z Required Trivy version is v0.53.0
2024-11-25T07:40:29.2794681Z Downloading Trivy...
2024-11-25T07:40:29.2808517Z Downloading: https://github.com/aquasecurity/trivy/releases/download/v0.53.0/trivy_0.53.0_Linux-64bit.tar.gz
2024-11-25T07:40:30.9965229Z Extracting Trivy...
2024-11-25T07:40:30.9966624Z Extracting archive
2024-11-25T07:40:30.9982773Z [command]/usr/bin/tar xC /tmp/ -f /tmp/trivy
2024-11-25T07:40:31.7168503Z Setting permissions...
2024-11-25T07:40:31.7175487Z [command]/usr/bin/chmod +x /tmp/trivy
2024-11-25T07:40:31.7219732Z Configuring options for image scan...
2024-11-25T07:40:31.7222898Z Running Trivy...
2024-11-25T07:40:31.7229289Z [command]/tmp/trivy image --exit-code 0 --format json --output /tmp/trivy-results-0.8526500589086079.json --scanners vuln,misconfig,secret ***/xxx/yyy:check.9999999
2024-11-25T07:40:32.7122039Z 2024-11-25T16:40:32+09:00	INFO	Need to update DB
2024-11-25T07:40:32.7122689Z 2024-11-25T16:40:32+09:00	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-11-25T07:40:32.7123452Z 2024-11-25T16:40:32+09:00	FATAL	Fatal error	init error: DB error: failed to download vulnerability DB: database download error: OCI repository error: 1 error occurred:
2024-11-25T07:40:32.7124089Z 	* GET https://ghcr.io/v2/aquasecurity/trivy-db/manifests/2: TOOMANYREQUESTS: retry-after: 947.713µs, allowed: 44000/minute
2024-11-25T07:40:32.7124489Z
2024-11-25T07:40:32.7124570Z
2024-11-25T07:40:32.7153790Z ##[error]Failed: Trivy detected problems.
2024-11-25T07:40:32.7160783Z Publishing JSON results...
2024-11-25T07:40:32.7168299Z ##[error]Unable to process command '##vso[task.addattachment type=JSON_RESULT;name=trivy0.40346413770979384.json;]/tmp/trivy-results-0.8526500589086079.json' successfully. Please reference documentation (http://go.microsoft.com/fwlink/?LinkId=817296)
2024-11-25T07:40:32.7177854Z ##[error]Value cannot be null. (Parameter 'Cannot upload task attachment file, attachment file location is not specified or attachment file does not exist on disk.')
2024-11-25T07:40:32.7283547Z Done!
2024-11-25T07:40:32.7285641Z ##[section]Finishing: Full Scan

@rzo55555  see https://github.com/aquasecurity/trivy-azure-pipelines-task/issues/82#issuecomment-2404078593


Drop testing for 2.6 and 3.3. Add 3.6.

Via discussion pallets/meta#24
rewrite the configuration of appveyor.

ping @davidism


add MAX_MONEY public constant to Amount

Closes https://github.com/rust-bitcoin/rust-bitcoin/issues/740

@Kixunil thanks, updated.

We should address why @dpc reacted with thumbs down before we proceed on this.

@sanket1729 I think he thought it is an implementation of #620 but it isn't. @dpc could you clarify?

Correct. Please don't mind me.


Add low speed switch entity

Discret is the french word for low mode
Instead of a service, I suggest to use an entity switch as device option. So no need anymore to create cover template.
For the icon, I choose the same one used by the Somfy switch: https://www.somfy.fr/produits/1033114/s-so-rs100-io

Nice PR, @tetienne! This is a lot nicer than the template covers. The only downside I see is that users cannot choose to mix the functionality anymore, without changing the switch.
E.g. if they want to open covers fast in one automation and open them silently in another one. However, I have some feeling that this is an edge case that no one wants really. :-)

You are right. That’s another step in the automation. For this edge case, HA should support natively cover speed, or end user should create a template cover.

Nice PR, @tetienne! This is a lot nicer than the template covers. The only downside I see is that users cannot choose to mix the functionality anymore, without changing the switch.
E.g. if they want to open covers fast in one automation and open them silently in another one. However, I have some feeling that this is an edge case that no one wants really. :-)

You are right. That’s another step in the automation. For this edge case, HA should support natively cover speed, or end user should create a template cover.

They can't create a template cover anymore if we remove the service :-). That was my point haha, however I am fine by removing the service (or at least add the warning) and see if people complain.

Nice PR, @tetienne! This is a lot nicer than the template covers. The only downside I see is that users cannot choose to mix the functionality anymore, without changing the switch.
E.g. if they want to open covers fast in one automation and open them silently in another one. However, I have some feeling that this is an edge case that no one wants really. :-)

I think it still should be possible. The only thing you have to do is: activate or deactivate the switch prior to the moving of the cover.
But I was about to create buttons to move to a certain position with low speed and I am not sure if the custom:button-card supports two different service calls in once (activating the switch and then moving the cover).

@azrael783 For lovelace, on your card you can add a switch too. It will mimic Somfy interface.
Sometimes, you want to trigger the slow mode and sometimes not?

@azrael783 For lovelace, on your card you can add a switch too. It will mimic Somfy interface.
Sometimes, you want to trigger the slow mode and sometimes not?

I didn't get the first statement.
Yes, for example: in the morning and in the evening I want to open and close silently via an automation. But I want to have also fully control via the UI. As I understood the pull request will add for every cover a switch which allows me to activate the "silent" mode. So bevor I can move the cover with low speed I have to activate the switch, right? For me it makes then more sense to create templates for the UI because I think it is easier to just call the template rather then first activate the switch and then move the cover ...

@azrael783 Through an automation you can now toggle the silent mode the morning and the afternoon and reset it during the day.
You can also create a script taking the entity id of your cover as input. And then use this script in a template for instance.
script:
  open_slowly:
    fields:
      entity:
        description: "The cover to open slowly"
        example: "cover.bedroom"
    sequence:
      - service: switch.turn_on
        entity_id: switch.bedroom_low_speed
      - service: cover.open
        data:
          entity_id: "{{ entity }}"
      - service: switch.turn_off
        entity_id: switch.bedroom_low_speed

But to be checked, it seems you can call several services in a cover template: https://www.home-assistant.io/integrations/cover.template/#open_cover

I think it will work fine, the only complexity is that you would need to capture the current status of the switch and restore the original status afterwards. (if you want to have it very clean).
However, I believe all solutions above are fine and we can just continue with this PR :-).

@azrael783 Can you confirm the switch are well created with your setup? Another user reported me it was not the case for him.

@tetienne I will check it this evening ;)

Is this one ready to merge? Perhaps we can include this + DHCP + rebrand to Overkiz and make it 2.7.0.

Yes it should be OK. Sorry this weekend I was quite busy.


'rakudobrew build all' fails due to --gen-parrot

Asking rakudobrew to build all backends fails now due to a lack of --gen-parrot.

#29

#29 merged, so this is now closable.
I worry a bit about people who actually use rakudo-parrot and expect it to be there, but they probably don't use rakudobrew anyway (or we'll know soon enough).


Imported character is immune from damage

This is related to #308 and I thought I'd made a report about the facehugger being immune too.
I mentioned it, but didn't complete my thought.   Here's a short clip. The issue at hand is complete
immunity of the imported character:  https://youtu.be/kQAvGiDv3pA
I'm not sure why the load into the reactor core in the video took almost 45s, but I use it to get a clean entry into the alien nest map.
Also, was some weirdness in the android looked like he was doubled for a moment.
This is unique to this playthrough. I had not seen this issue before and it might just be one time.
I tried trigger binding the chr_invicibilty function onto the character and set it to be able to take damage.
I could be implementing it wrong, but it didn't appear to work.
The same thing as in #308 is happening here though. The character appears correct in game and seems to function flawlessly except for total immunity.  When looking at the model editor all of the materials are in 'fallback' condition and some textures are actually absent.    Or if they're present they're not being imported with same name as the character imported from.

This is what the Col_Android mesh looks like after import.   Something is not merging correctly during import I guess.
I can manually select one of the two meterials from the list.  I tried each w/o affect on the issue.

For some of the mesh objects the material does not exist. I compared with the model from ReactorCore.
Here's the Part_1: LOD\Mesh0

On the left is character from reactor; on the right the same mesh imported to alien_nest.
The significant part is the textures shown CA_LOW_LOD_CHARACTER are absent from the import.

Imported models will use the fallback material in the model manager as the materials are currently only applied within the script tool at the instance within the composites. Debating changing this.
Collision is a known issue, and part of why this functionality is still experimental - physics and collision don't yet port, they're the final piece of the puzzle I'm still figuring out (part of #95). I'll leave this issue open as linked though, thanks for raising it officially.

AH!  I had a feeling that you were going to say the #95 was the ultimate issue.
OK.  Hopefully that puzzle will be cracked.
Thank you for the continued work on this project.


adds changes for utf8_byte_length constraint

Issue #9 #10
Description of changes:
This PR works on adding implementation of utf8_byte_length constraint.
Grammar:
utf8_byte_length: <INT>
utf8_byte_length: <RANGE<INT>>

Ion Schema specification:
https://amzn.github.io/ion-schema/docs/isl-1-0/spec#utf8_byte_length
List of changes:

adds changes for utf8_byte_length constraint implementation
adds Utf8ByteLength enum variants for IslConstraint and Constraint
adds Utf8ByteLengthConstraint implementations
adds validation logic for utf8 _byte_length
adds unit tests for utf8_byte_length

Tests:
added unit tests for utf8_byte_length implementation.

adds tests for programmatically creating utf8_byte_length constraint
adds tests for loading a schema using utf8_byte_length constraint
adds validation tests for utf8_byte_length constraint

I think clippy was suggesting that you replace foo != None with foo.is_some() rather than Option::is_some(&foo). I don't think it makes much difference though.

Yes, I have already changed according to clippy warnings in https://github.com/amzn/ion-schema-rust/pull/130/commits/02285169a1c986f3acbf0198b4dec90f4667ae4b so it seems to be good now.


Hello-Microverse-2

[ ]  Added .gitignore
[ ] Added Node modules
[ ] Added linters
[ ] Added HTML & CSS
[ ] Added test.md

Hello @topeogunleye , please check my correction and let me know if I can go ahead. Thank you.

Hello @topeogunleye , please check my correction and let me know if I can go ahead. Thank you.

Can you please kindly change your branch name @Minuu7


 tag inside  ngDraggable

I go through the issue #12 and I tried the same logic but it's not working. So, want to ask that how can I use dropdown menu within ngDraggable. I used ng-prevent-drag directive and it allow me to click on dropdown but it doesn't populate the options.
Any suggestions ?
Thanks

The provided example does not work with the newest version of ngDraggable.
I cannot use the select boxes.
Tested in Chrome 41 and Firefox 31.4.0.
The solution with ng-cancel-drag is not realy good, because children which use select or input need to know that they are wrapped in a draggable element.
The directive should ignore input and select elements instead.


Add support for attrs_init_subclass

Summary
Fixes #595
Pull Request Check List

[x] Do not open pull requests from your main branch – use a separate branch!

There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
This is not a pre-requisite for your your pull request to be accepted, but you have been warned.

[x] Added tests for changed code.
Our CI fails if coverage is not 100%.
[ ] Updated documentation for changed code.

[ ] New functions/classes have to be added to docs/api.rst by hand.
[ ] Changes to the signatures of @attr.s() and @attrs.define() have to be added by hand too.
[ ] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
The next version is the second number in the current release + 1.
The first number represents the current year.
So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
If the next version is the first in the new year, it'll be 23.1.0.

[ ] If something changed that affects both attrs.define() and attr.s(), you have to add version directives to both.

[x] Changes (and possible deprecations) have news fragments in changelog.d.

@sscherfke I believe you mentioned interest in this features years ago, too?


Add composite types to user-level code.

Basil internally supports values of product and sum types, and uses them to represent certain internal data - for example, the tuple of arguments passed into a function when called.
We should support the construction of products and sums in userspace code via the inclusion of some new built-in operators and functions, or possibly even new grammar. These values should be implemented both as compile-time values and as runtime nodes.
In particular, the following operations should be defined on the aforementioned types:

Random-access by index of an element of a tuple.

Find the actual type of a sum type value.

Access the current value of a sum type by type (for example, we might write int of union: int|string to access the int value of a union of int and string).

We should also consider adding arrays, along with a built-in function or syntax extension to write array literals.

Composite types (tuples, unions, arrays, and intersections) are included in the current rewrite.


Cannot display pdf (file is of invalid format)

Have the Cannot display pdf (*file_name* is of invalid format) error on android. On iOS everything is fine. Also, I did an extra step for android api 30+.
Maybe its a wrong file path, i have this: /data/user/0/com.pmgmobileapp/cache/*file_name*.pdf.

Versions:
"react-native-file-viewer": "^2.1.5",
"react-native": "0.66.4",

Android:
buildToolsVersion = "30.0.2"
minSdkVersion = 21
compileSdkVersion = 30
targetSdkVersion = 30
ndkVersion = "21.4.7075529"

Code:
const options1: FetchInit = {
  method: 'GET',
  path: `${CACHED_PATH}/${file.name}`
};
const response = await FileSystem.fetch(`${CORE_URL}${url}`, options);
if (response) {
  const fileUri = `${Dirs.CacheDir}/${file.name}`;
  const fileStat = await FileSystem.stat(fileUri);
  await FileViewer.open(`${Dirs.CacheDir}/${file.name}`);
}

Already found a source of the problem and it is not related to this viewer.

Hello @kosbog how did you resolve this issue, as I also cannot open pdf links sent in Teams chat in Android?


Added a remark about uap10:TrustLevel

This remark describes the requirements for uap10:TrustLevel for partialTrust apps

@drewbatgit

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


fix: move to new nginx charts

Signed-off-by: ankitm123<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign abayer
You can assign the PR to them by writing /assign @abayer in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ankitm123: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
d9f1bf748fe0e8dfecb6eba45b767d7d04cdc022
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ankitm123: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
6b03b202e535b5dd5dab7bf61db118dcd181ca5a
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ankitm123: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
8576629fbcdc72c44934eee271d16e2affc4be35
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test kube

@ankitm123: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
8576629fbcdc72c44934eee271d16e2affc4be35
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test kube

@ankitm123: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
8576629fbcdc72c44934eee271d16e2affc4be35
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ankitm123: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
13fc5b847c931667aa1c1776593327a11ef88308
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ankitm123: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
13fc5b847c931667aa1c1776593327a11ef88308
link
/test kube

gsm
13fc5b847c931667aa1c1776593327a11ef88308
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ankitm123: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
13fc5b847c931667aa1c1776593327a11ef88308
link
/test kube

gsm
13fc5b847c931667aa1c1776593327a11ef88308
link
/test gsm

vault
13fc5b847c931667aa1c1776593327a11ef88308
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ankitm123 I merged this change into other PRs upgrading jx-gitops and other things in the version stream; all good now thanks!


Inlay hints: attempt to index a nil value

Hello tris :^)
Here's my report on an issue after the last plugin update (https://github.com/tris203/precognition.nvim/commit/6772d3a6aa98f6e68b53fd7d4dfd7762bf3ae3bf)
Error  20:37:36 msg_show.lua_error Error detected while processing CursorMoved Autocommands for "*":
20:37:36 msg_show Error executing lua callback: ...e/nvim/lazy/precognition.nvim/lua/precognition/utils.lua:77: attempt to index a nil value
stack traceback:
	...e/nvim/lazy/precognition.nvim/lua/precognition/utils.lua:77: in function 'calc_ws_offset'
	...re/nvim/lazy/precognition.nvim/lua/precognition/init.lua:280: in function 'display_marks'
	...re/nvim/lazy/precognition.nvim/lua/precognition/init.lua:316: in function <...re/nvim/lazy/precognition.nvim/lua/precognition/init.lua:304>

It doesn't happen on every lines, I might be wrong but I think the error is triggered when there are more that two hint on the line, and they must be variable type hints, for some reason it's a method hint (i.e what the function is returning) it does not trigger the error
Example 1:

Example 2:

I'm using NVIM v0.10.1
My distribution is LazyVim
And here's my precognition config
return {
  "tris203/precognition.nvim",
  opts = {
    highlightColor = { link = "String" },
    hints = { Caret = { text = "à", prio = 2 } },
  },
}

This might be related, sometimes the length is correctly calculated, sometimes it isn't
Example 1 (Almost got it):

Example 2 (Got it perfectly):

Example 3  (Way off):

Example 4 (Got it perfectly):

I don't really understand how Neovim plugins are architectured so it's difficult for me to point you in the right direction, yet don't hesitate to ask for more informations if needed
In the meantime, I wish you an excellent day

What language are you writing and which language server are you using for the hints?

And you assumed right
 Language client log: /home/monheim/.local/state/nvim/lsp.log
 Detected filetype:   rust

 1 client(s) attached to this buffer:

 Client: rust-analyzer (id: 1, bufnr: [12])
 	filetypes:       rust
 	autostart:       false
 	root directory:  /home/monheim/DocuDeux/dev/rust_proj/qr
 	cmd:             rust-analyzer --log-file /tmp/nvim.monheim/U8oXbw/0-rust-analyzer.log

As for the minimal replication file, I will create an online repo for this project
I was working offline on it, one of my PR hasn't been accepted yet on a certain dependency that I use and that's why I waited before the initial push
I'll keep you in touch tomorrow and give you the entire project so you don't have to deal with missing dependencies

If you can create a really simple reproduction that would make it easier for me.
I don't know if you can create a hello world-esque function that captures the error

Sure I'll try some things and I'll get back to you

I found something:
use std::collections::HashMap;

#[derive(Debug)]
enum Error {
    EmptyField(String),
    MissingField(String),
}

trait EmptyStringValue {
    ///Return an error if the value is empty
    fn try_get<'a>(&'a self, s: &str) -> Result<&'a str, Error>;
    ///Return an error if the value is empty
    fn try_get_owned(&self, s: &str) -> Result<String, Error>;
}

impl EmptyStringValue for HashMap<String, String> {
    fn try_get<'a>(&'a self, s: &str) -> Result<&'a str, Error> {
        if let Some(x) = self.get(s) {
            if !x.is_empty() {
                Ok(x.as_str())
            } else {
                Err(Error::EmptyField(s.into()))
            }
        } else {
            Err(Error::MissingField(s.into()))
        }
    }
    fn try_get_owned(&self, s: &str) -> Result<String, Error> {
        if let Some(x) = self.get(s) {
            if !x.is_empty() {
                Ok(x.into())
            } else {
                Err(Error::EmptyField(s.into()))
            }
        } else {
            Err(Error::MissingField(s.into()))
        }
    }
}

fn main() -> Result<(), Error> {
    println!("Hello, world!");

    let h: HashMap<String, String> = HashMap::new();

    let (a, b, c, d) = (
        h.try_get("a")?,
        h.try_get("b")?,
        h.try_get("c")?,
        h.try_get("d")?,
    );

    Ok(())
}

Error can be triggered on line 46, right on the let (a, b, c, d) = (

Can you test with the branch in the linked PR please @monheimx9
As far as the spacing goes, I know what the issue is, but i need to think about it a little bit more

I wasn't able to trigger the error again :^)


Add functions for verbose and with context execution

@locnnil please feel free to add more comments to the same branch for the remaining refactoring and test implementations.

@farshidtz Is there some specific reason to run the tests 100 times?

@farshidtz Is there some specific reason to run the tests 100 times?

I remember we had a race condition which was causing a failure around 10-20% of the time. The Go's data race detector wasn't catching it either. I can't recall the specifics, but it should be recorded somewhere. We fixed the bug and continued running the tests that way.


on-item-click not passing all data

When the on-item-click is called for a group=true type element, you see to just pass the group item, but not all the sub-items.  I need to know whether those are turned on or off as well...i.e. I don't want to hardcode the values back in again.

Hi @grosch ,
It's by design. The on-item-callback only returns the thing that you clicked.
You can simply do a loop on the input-model during on-item-click() callback to check whether the sub-items are on or off.


Add lifecycle to baremetal doc

Issue #, if available:
Documentation for Tinkerbell controller#996
Document and test terraform example for bare metal#1047
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/retest

Looks good! Left a few comments.
Can we call out that scale up and upgrade requests also can not be made in the same request, neither can they be made if one request hasn't run through?

Can we also update this doc https://anywhere.eks.amazonaws.com/docs/tasks/cluster/cluster-terraform/ and call out that we support Baremetal using Terraform now?

/cherrypick release-0.15


SF-1170: Add support for all(), allOff(), and subscribeWith() methods

Codecov Report

Merging #8 into master will decrease coverage by 1.06%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   93.85%   92.78%   -1.07%
==========================================
  Files         204      197       -7
  Lines        5367     5103     -264
  Branches      632      620      -12
==========================================
- Hits         5037     4735     -302
- Misses        246      283      +37
- Partials       84       85       +1

Impacted Files
Coverage Δ

<EMAIL_ADDRESS>50% <100%> (+3.53%)
:arrow_up:

<EMAIL_ADDRESS>98.82% <100%> (-1.18%)
:arrow_down:

<EMAIL_ADDRESS>50% <50%> (ø)

...ont/flux-capacitor/src/core/reducers/data/sorts.ts
0% <0%> (-100%)
:arrow_down:

...ux-capacitor/src/core/reducers/data/collections.ts
20% <0%> (-80%)
:arrow_down:

...ont/flux-capacitor/src/core/reducers/data/query.ts
20% <0%> (-70.91%)
:arrow_down:

...apacitor/src/core/reducers/data/infinite-scroll.ts
33.33% <0%> (-54.17%)
:arrow_down:

...efront/flux-capacitor/src/core/reducers/session.ts
50% <0%> (-50%)
:arrow_down:

...orefront/flux-capacitor/src/core/reducers/index.ts
50% <0%> (-50%)
:arrow_down:

...nt/flux-capacitor/src/core/reducers/is-fetching.ts
53.84% <0%> (-46.16%)
:arrow_down:

... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e130571...a314504. Read the comment docs.

RE: Object.values:
As discussed, Object.values was introduce by the ES017 spec, which is not targeted by our tsconfig file.

Added Do Not Merge label. To be removed when #10 flows into master.

Removing Do Not Merge label (#10 has flowed into master).

Did you re-demo after all these changes?


Proper Row object rather than Vec?

It would be nice if the QueryResult iterator yielded a proper Row object rather than a simple Vec<Value>. That is, it would be convenient if each row contained information about the query columns/statement. My specific use case would be a get method on Row that could take a &str (column name) or usize parameter, and return the Value for that position.
Both rusqlite and the postgres driver provide such an interface. I haven't put together a pull request since this might be a radical change to the API, and I don't know if there are performance/overhead concerns...
Just for fun, here is a workaround I am currently using (though it is kind of ugly and probably inefficient):
pub struct MyWrapper<'a>(QueryResult<'a>);

pub struct MyRow {
  pub row: RefCell<HashMap<usize, Value>>,
  pub columns: HashMap<String, usize>
}

impl MyRow {

  pub fn new(row: MyResult<Vec<Value>>, columns: &[Column]) -> Self {
    let _row = row.into_iter()
      .flat_map(|x| x)
      .enumerate()
      .collect();
    let _columns = columns.iter()
      .map(|x| x.name.clone() )
      .filter_map(|x| String::from_utf8(x).ok() )
      .enumerate()
      .map(|(x, y)| (y, x) )
      .collect();
    MyRow { row: RefCell::new(_row), columns: _columns }
  }

  fn at<T: FromValue>(&self, s: &str) -> Option<T> {
    self.columns.get(s).into_iter()
      .filter_map(|i| self.row.borrow_mut().remove(&i) )
      .filter_map(|x| from_value_opt(x).ok() )
      .next()
  }

}

impl<'a> Iterator for MyWrapper<'a> {
  type Item = MyRow;

  fn next(&mut self) -> Option<MyRow> {
    self.0.next()
      .map(|row| MyRow::new(row, self.0.columns_ref() ) )
  }
}

pub trait MyWrapped<'a> {
  fn wrapped(self) -> MyWrapper<'a>;
}

impl<'a> MyWrapped<'a> for QueryResult<'a> {
  fn wrapped(self) -> MyWrapper<'a> { MyWrapper(self) }
}

Which I can use like:
impl User {
  pub fn all(pool: &MyPool) -> Vec<User> {
    pool.prep_exec("SELECT * FROM users", ()).into_iter()
      .flat_map(|x| x.wrapped() )
      .map(|row| User { email: row.at("email"), ..Default::default() } )
      .collect()
  }
}

Yeah, i think this workaround would be quite inefficient.
Also looks like it's efficiency bound to a number of rows because it will call HashMap::get on each row which is slow AFAIK.
I usually prefer something like this:
let users: Vec<User> = conn.prep_exec("SELECT * FROM users", ()).map(|result| {
    let email_idx = result.column_index("email").unwrap();
    result.into_iter().flat_map(|row| row).map(|mut row| {
        User {
            email: from_value(row.remove(email_idx)),
            ..User::default()
    }).collect()
});

But anyway i think you are right and i should wrap Vec to a something with better API.
I have 2.0 branch in my local repo with a bunch of additions, but have problems with spare time last few months.

Thanks for the comment. I'm just now coming back to Rust and your library--
I really like what you've done in 2.1.0+. The Row object is nice and the column_indexes method on QueryResult is very helpful for my use case.
I still think it would be nice to have some reference to the columns available to the Row. Since we can't return a reference to self.columns in the QueryResult iterator, what would be the implications of doing something like this?
(I have no idea how Arc affects performance, etc., and I think this only needs to be Arc rather than Rc because mysql::Error uses Row.)

Thanks!
Benchmarks shows that overhead is zero. Implementation already in my local master, but change are breaking so i will publish this together with fix for #43.


where did StreamDeserializer::new go?

Im upgrading from 0.8 to 0.9 and noticed there was an undocumented breaking change for StreamDeserializer. I can no longer construct an instance for one a type implements Deserialize. it looks like its now behind into_iter on Deserialize for types that implement Read. Please advise

You can stream any JSON deserializer now:
https://docs.serde.rs/serde_json/de/struct.Deserializer.html#method.into_iter
Previously the only way to make a stream deserializer was StreamDeserializer::new which took an iterator of io::Result<u8>. This made it impossible to apply any of the optimizations that we use for &[u8] and &str input in the non-streaming case. Rather than mirroring all of the Deserializer constructors (from_reader, from_slice, from_str, from_iter) in StreamDeserializer, we let you take any Deserializer and upgrade it to a StreamDeserializer.
Let me keep this issue open until i add examples to the StreamDeserializer rustdoc and into_iter method.
Before:
  let data = "{ ... }";
- let mut stream: StreamDeserializer<Value, _> = StreamDeserializer::new(
-     data.as_bytes().iter().map(|byte| Ok(*byte))
- );

After:
  let data = "{ ... }";
+ let mut stream = Deserializer::from_str(data).into_iter::<Value>();

My use case is a stream of data  https://github.com/softprops/lux/blob/master/src/pod.rs#L17. I relied on the ability to produce a stream of deserialization where the source may not be in memory, in this case hypers support for chunked http. Is this still supported in serde json?

@softprops: There's from_reader. Is that what you need?

I'll take a look again tonight

You want:
let s = serde_json::Deserializer::from_iter(bytes).into_iter::<PodEvent>();

let s = serde_json::Deserializer::from_iter(bytes).into_iter::();

thanks @dtolnay  that works great!

Reopening until I get a chance to add an example to the StreamDeserializer documentation.

Cool. It's been an awesome help to me. I made a crate that did a similar thing way back when there was only rust serialize - https://github.com/softprops/jed once I discovered this in serde, I never turned back!

How might one place the new StreamDeserializer into a struct, where the full type needs to be known, yet Read and friends are private? Trying to update some late 2016 code that looks pretty much like this:
pub struct Client {
    reader: StreamDeserializer<serde_json::Value, Bytes<TcpStream>>,
}

pub struct Client<D> {
    reader: D,
}

fn f<D>(c: Client<D>)
    where D: Iterator<Item = Result<serde_json::Value, serde_json::Error>>

It's not great. I opened #250 to add a nicer way.
pub struct Client<R> {
    reader: StreamDeserializer<R, serde_json::Value>,
}

fn f<R>(c: Client<R>)
    where R: serde_json::de::Read

Ok, forgive me for being a bit rusty (or not rusty enough I suppose) but unfortunately it's been a while since I last had a chance to play with Rust, how would I actually assign something to that? Here's a bit more fleshed out snippet:
use std::io::{Read, Bytes};
use std::net::{TcpStream, ToSocketAddrs};

use serde_json::{self, Deserializer};

pub struct Client<D> where D: Iterator<Item = serde_json::Result<serde_json::Value>> {
    writer: TcpStream,
    reader: D,
}

impl<D> Client<D> where D: Iterator<Item = serde_json::Result<serde_json::Value>> {
    pub fn open<A: ToSocketAddrs>(addr: A) -> Result<Client<D>> {
        let writer = try!(TcpStream::connect(addr).map_err(Error::Connect));
        let reader = try!(writer.try_clone().map_err(Error::Io));
        Ok(Client {
            writer: writer,
            reader: Deserializer::from_iter(reader.bytes()).into_iter::<serde_json::Value>()
        })
    }
}

That errors with:
24 |           Ok(Client {
   |  ____________^ starting here...
26 | |             writer: writer,
27 | |             reader: Deserializer::from_iter(reader.bytes()).into_iter()
28 | |         })
   | |_________^ ...ending here: expected type parameter, found struct `serde_json::StreamDeserializer`
   |
   = note: expected type `rpc::client::Client<D>`
              found type `rpc::client::Client<serde_json::StreamDeserializer<serde_json::read::IteratorRead<std::io::Bytes<std::net::TcpStream>>, serde_json::Value>>`

The problem is that the function signature of open says that the caller is allowed to decide what D is, but in fact the body of open wants to be able to decide what D is. This is the problem that impl Trait is designed to solve.
#![feature(conservative_impl_trait)]

pub fn open<A: ToSocketAddrs>(addr: A) -> Result<Client<impl Iterator<Item = serde_json::Result<serde_json::Value>>>>

In your case a simpler stable approach might be:
pub struct Client {
    writer: TcpStream,
    reader: Box<Iterator<Item = serde_json::Result<serde_json::Value>>>,
}

impl Client {
    pub fn open<A: ToSocketAddrs>(addr: A) -> Result<Client> {
        let writer = try!(TcpStream::connect(addr).map_err(Error::Connect));
        let reader = try!(writer.try_clone().map_err(Error::Io));
        Ok(Client {
            writer: writer,
            reader: Box::new(Deserializer::from_iter(reader.bytes()).into_iter()),
        })
    }
}

To explain the increase in complexity here - previous versions of serde_json had one StreamDeserializer type that treated all input sources the same, so it can be parameterized with an input iterator like Bytes<TcpStream> and an output type like serde_json::Value in a simple way. The downside is that it treats all input sources the same... so input that is &str or &[u8] would follow the same slow codepath as Iterator<Item=io::Result<u8>>. In the new serde_json we have a less nice workaround that allows us to optimize for &str and &[u8] input and once specialization is available, we can go back to nice bounds like Bytes<TcpStream>.

I did actually already try impl trait, however in the end it asked me to
specify the return value anyway on the calling side. I'll try to take
another look later, possible there was some sort of a mistake.
Thanks for the helpful responses :)
On Fri, Feb 10, 2017 at 7:09 David Tolnay<EMAIL_ADDRESS>wrote:

The problem is that the function signature of open says that the caller
is allowed to decide what D is, but in fact the body of open wants to be
able to decide what D is. This is the problem that impl Trait
https://github.com/rust-lang/rfcs/blob/master/text/1522-conservative-impl-trait.md
is designed to solve.
#![feature(conservative_impl_trait)]
pub fn open<A: ToSocketAddrs>(addr: A) -> Result<Client<impl Iterator<Item = serde_json::Result<serde_json::Value>>>>
In your case a simpler stable approach might be:
pub struct Client {
writer: TcpStream,
reader: Box<Iterator<Item = serde_json::Result<serde_json::Value>>>,
}
impl Client {
pub fn open<A: ToSocketAddrs>(addr: A) -> Result {
let writer = try!(TcpStream::connect(addr).map_err(Error::Connect));
let reader = try!(writer.try_clone().map_err(Error::Io));
Ok(Client {
writer: writer,
reader: Box::new(Deserializer::from_iter(reader.bytes()).into_iter()),
})
}
}
To explain the increase in complexity here - previous versions of
serde_json had one StreamDeserializer type that treated all input sources
the same, so it can be parameterized with an input iterator like
Bytes and an output type like serde_json::Value in a simple way.
The downside is that it treats all input sources the same... so input that
is &str or &[u8] would follow the same slow codepath as
Iterator<Item=io::Result>. In the new serde_json we have a less nice
workaround that allows us to optimize for &str and &[u8] input and once
specialization
https://github.com/rust-lang/rfcs/blob/master/text/1210-impl-specialization.md
is available, we can go back to nice bounds like Bytes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/serde-rs/json/issues/234#issuecomment-278790415, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAB-_fwnV_aeTghnfnN1hwrA2cLC2ZUTks5ra46KgaJpZM4LxGEv
.


application.resnet has a bug

line:153 dilation_rate=dilation_rates[i],
dilation_rates=(1, 1)
How about i>1
should be dilation_rates = [(1, 1)] * blocks ？

and other bugs.


luci-app-frpc：add enable options

without the enable option, there is no control over running or stopping the plug-in. After the enable option is added, you can control whether the plug-in is enabled or not.adaptation frps
Signed-off-by: zxlhhyccc<EMAIL_ADDRESS>

Is this about frps or frpc???
Title and commit title do not match commit contents.


Update libsql to 3d52c07f5d1df9caa56fb201fb3009924b26fd05

It includes some fixes to vector search.

Updating simulator to IOS 18.1 helped:

It seems you didn't do a pod install? I'm getting changes on the Podfile.lock:

I fixed the CI command, you can merge main into your branch or rebase if you want, should fix the CI tests at least

It seems you didn't do a pod install? I'm getting changes on the Podfile.lock:

I did - just didn't commit Podfile.lock

Rebased on main

Thanks, release 11.0.1 is now building and will contain this bump.

Thanks, release 11.0.1 is now building and will contain this bump.

Thanks @ospfranco !!!

Thanks guys! @ospfranco - can you push 11.0.1 to npm?

It's already out
https://github.com/OP-Engineering/op-sqlite/releases/tag/11.0.1

@ospfranco it's not pushed to npm https://www.npmjs.com/package/@op-engineering/op-sqlite?activeTab=versions


Resetting Masteries stop character from appearing in Menu

Hi there,
So I'd like to reset my masteries (not so happy with Nature). However, the character disappears when I try using TQVault to reset masteries. Here is a copy of the character and setting I'm running:
Titan Quest - Immortal Throne_backup_2020.zip
Please advise what can be done? I am almost sure this is a bug.
I can add images but I don't think it's necessary.
I make sure I exit TQVault long before I start the game up.
I have to copy this backup back before the character is seen again by TQ but I can still see it in TQVault (with the Masteries reset).

Thanks to notice !
I just provide a fix for this.

Thanks for the fix @hguy!
Any chance of a release build soon?

@colinschwegmann How about now? :)
https://github.com/EtienneLamoureux/TQVaultAE/releases/tag/3.7.4

@EtienneLamoureux Thank you so much! That fixed worked and thanks for the release (forgot to switch my account on my work PC to reply).


UX Design Epic: Apps & Marketplace

Opening per discussion - Some UX design issues are related to each other, so we should track them as part of a project for the sake of a consistent design.

[ ] https://github.com/rancher/dashboard/issues/6402
[ ] https://github.com/rancher/dashboard/issues/5686
[ ] https://github.com/rancher/dashboard/issues/5460
[ ] https://github.com/rancher/dashboard/issues/5043
[ ] https://github.com/rancher/dashboard/issues/3152 (also a navigation issue)
[ ] https://github.com/rancher/dashboard/issues/3057
[ ] https://github.com/rancher/dashboard/issues/2672
[ ] https://github.com/rancher/dashboard/issues/2671

Closing in favor of https://github.com/rancher/dashboard/issues/6402


MM-29726 Allow disabling link previews from certain domains

Summary
Added a UI field for restricted domains under Site Configuration > Posts in the System Console and created english localizations for it.
Ticket Link
https://github.com/mattermost/mattermost-server/issues/16846
Related Pull Requests

Has server changes (https://github.com/mattermost/mattermost-server/pull/16869)

Screenshots

Hello @berkeka,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Awesome @berkeka! Nice work!

I've blocked this on the accompanying server PR since that needs to go in first.

/update-branch

@jgilliam17 This requires the server changes to be tested, so let us know if those aren't picked up by the test server. You'll know that they're not picked up since the settings in the system console won't be saved

@hmhealey Setting in the system console for "disable link previews" is not being saved. Maybe I misunderstood, and I should probably have to wait for server work to be done before testing. Let me know. Thanks.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

@jgilliam17 I've tried setting up a test server from the server PR (https://github.com/mattermost/mattermost-server/pull/16869). Hopefully that should pull these changes into it so they can be tested together

Okay, the test server is using a week old version of the code, probably corresponding to when the server branch was last pushed. I'll resolve the merge conflict and push a new version of both branches in a bit to try fixing the issue

/update-branch

/update-branch

Thanks, Jelena! Nice to finally get this merged now that the test server has decided to behave.
Thanks again for the PR, @berkeka!


Unexpected SFDX plugin hooks interface changes

Summary
Does anyone know anything about changes to the SFDX plugin hooks? It appears the latest version of SFDX includes the new source plugin that fundamentally changes the interface for the predeploy hook. Example of the new format below.
Does anyone know of anywhere where I can find out more about these changes, an announcement or such like? It looks like the documentation hasn't been updated - https://developer.salesforce.com/docs/atlas.en-us.sfdx_cli_plugins.meta/sfdx_cli_plugins/cli_plugins_customize_hooks_list.htm.
SourceComponent {
    name: 'Account',
    type: {
        id: 'flow',
        name: 'Flow',
        suffix: 'flow',
        directoryName: 'flows',
        inFolder: false,
        strictDirectoryName: false
    },
    xml: '/Users/repository/force-app/main/default/flows/Account.flow-meta.xml',
    parent: undefined,
    content: undefined,
    _tree: NodeFSTreeContainer {},
    forceIgnore: ForceIgnore { DEFAULT_IGNORE: [Array] }
}

This is a breaking change for one of my plugins, if anyone else has plugins on predeploy (or I'd assume other hooks too) - heads up they may also be broken.

Our pinned announcements are helpful to get advance warnings.
https://github.com/forcedotcom/cli/issues/1057
The release notes are a good way to stay informed of what's closer to shipping https://github.com/forcedotcom/cli/blob/main/releasenotes/README.md#71120-august-4-2021
I think we need to change the docs around the source hooks @jshackell-sfdc
https://developer.salesforce.com/docs/atlas.en-us.sfdx_cli_plugins.meta/sfdx_cli_plugins/cli_plugins_customize_hooks_list.htm

@mshanemc thanks for the info.
Is there a way of changing the contents of the package before it gets zipped up and sent to the MD API with the new hooks/source plugin? I ask because that's what I was doing before with my https://github.com/gdman/sfdx-destruction plugin i.e. copying in destructiveChangesPre and Post files.
Alternatively, are there plans for native support of destructive changes in the source plugin? There is an issue that tracks it here: https://github.com/forcedotcom/cli/issues/188 but it's not been updated in a while.

We've starting that destructive changes work.  You'll see it in the library first, then in the source plugin.
I'm gonna defer to @shetzel for how the new hook would would work with the new deploy process.

@gdman - sorry for my delayed response and the breaking hook changes.  About the hook changes, we had to make a decision on whether to keep backwards compat with hook payloads and negate many of the performance increases that come from using the source-deploy-retrieve (SDR) library, or break compat and change the hook payloads.  We never want to break backwards compatibility but in this case we thought the pros outweighed the cons.  With the SDR library there isn't any intermediary file system writing during the deploy anymore, so copying in destructive changes aren't possible.  However, I recently added support to the SDR library for destructive changes to ComponentSets.  If the hook were to add the ComponentSet as part of the payload you could modify that and it should get you the same behavior.
As for your other question, native support of destructive changes is definitely coming soon.  I'd say it's coming this Fall or Winter time frame.  Adding the support to the SDR library was the first step.  Out of curiosity, what would solve your usecases for natively supporting destructive changes?  Would this be as simple as adding a new flag for destructive changes file path to source:deploy command?  We've also been kicking around the idea of trying to maintain a destructiveChanges list per project as the CLI encounters them so they could be included in specific deploys, such as to UAT sandboxes and production.  Otherwise you're doing source control branch comparisons when maintaining your various environments (development, UAT, staging, production) to keep track of destructive changes.

@shetzel - Completely understand the decision to change the hook payloads, it makes total sense.
The issue was more that it was done without any deprecation or warning. As a plugin developer, the first I time I found out about it was when the new version had already been released and I was receiving messages to say the plugin didn't work. The only way I could have known about it sooner would have been to be checking the release notes for SFDX regularly.
In future, maybe put out an update with something that puts a message out to stdout/stderr saying that functionality is going to stop working in the next release. Maybe better still would be to have a new version of the hook, put a message on the old one to say it's no longer supported and direct people to the new one. Just changing the payload could have led to something worse than an error from trying to split a null string.
This feels like a one time kind of event so probably not something to worry too much about but knowing interfaces could change without warning is the sort of thing that would put me off developing future plugins.
Adding something as simple as --destructiveChangesPre destructiveChangesPre.xml and --destructiveChangesPost destructiveChangesPost.xml is exactly what people are after and have been for some time, see - https://github.com/forcedotcom/cli/issues/188. This is what led me to write a quick plugin in the first place.
Without destructive changes support in source:deploy, people will still need to convert and use mdapi:deploy. I made a comment in that other issue at the time, this may be a small bit of functionality but it blocks use of source:deploy so all the other great work you've all been doing isn't going to get used by the people needing destructive changes (which I'm guessing will be most people), even fewer now that there is no longer a workaround.
I've worked on projects that do destructive changes in different ways:

Our most commonly used simple approach is to maintain destructive changes files manually in source control that get pushed to all sandboxes with every deployment - need to turn warnings off on deploy so you don't get errors from trying to delete something that doesn't exist but it works. After the production deployment we clear down the destructive changes files to stop them growing for ever and ever.
The more advanced approach that I used a while back was as you suggest, dynamically build the destructive changes based on a list of deleted files from a git diff (keeping track of environment state on branches).

Thanks for taking the time to reply, especially with so much information - it's really appreciated.

Important thing I forgot to mention on my last point of automating destructive changes using the deleted files of a git diff.
Destructive changes aren't as simple as working out which files have been deleted, also need to check for modified files where sub components have been removed e.g. workflow rules, email alerts, labels, sharing rules, etc. SFDX source format should make that easier for objects but doesn't decompose all other metadata types.
That's a key reason I've not moved away from maintaining destructive changes files manually for releases at the moment.

@gdman Thank you for your feedback on communications. We definitely try to be proactive about communicating these types of changes but understand not everyone regularly monitors this repo unless they have an issue they're trying get fixed. We have some work planned in the next major release to increase our communication of changes and new features via the command line. Thanks again! Your feedback is incredibly valuable.

Found this thread via #188.  To express some additional interest in what @gdman has already stated, our CICD pipeline deploys metadata via source:deploy, and builds a list of metadata components to be deployed by performing a git diff between the last successfully deployed commit and the head commit.  We are now looking into what it would take to support destructive changes, as our project is in source format.  Our hope is that we'd be able to validate a single package containing both destructive and non-destructive changes derived from performing a diff between commits, and building a list of components to deploy (new or modified metadata), and a list of components to delete (deleted or renamed metadata).  At the moment, we manually perform pre-validation destructive changes.  However this adds friction, is not repeatable, and imposes a degree of deployment risk.  This becomes especially apparent in our lower environments that become temporarily non-compilable due to required pre-validation destructive changes.  Being able to validate a single package using source:deploy would greatly improve the capabilities of our pipeline.

I'm closing this since we've shipped all the destructive changes stuff that y'all brought up.
Closing it does not imply that we fixed the "hooks changed" problem


The forms are not being validated

I've noticed that the forms are not being validated and that the validation is being done in the models.  So the message strings for forms are never being used.

I haven't found forms which aren't being validated.


[BUG] --version option doesn't work correct

Versions:

pbicli version: v0.9.0 beta
nodejs version: v12.16.3
os name/version: Windows 10 / 19041.329

Describe the bug
pbicli -v or pbicli --version doesn't show correct info:
error: unknown option '-v'. Run 'pbicli --help for more information'
To Reproduce
Steps to reproduce the behavior:

execute pbicli -v

Expected behavior
Result should be:
pbicli      0.9.0 beta

Created by the Power BI Community

Fixed >v1.0.0


Added debugger tests, QoL API for debugger

Also splitted the debugger file that started to become a bit too big.
Writing theses tests allowed to spot a bug in the BuildLocals() method.
There is a disabled test to test the bug.

So... we need to improve the crawl logic.
I'll do it tomorrow.


Play notification functionality

Interrupt playback with new sound for notification purposes. See https://github.com/bencevans/node-sonos/blob/master/lib/sonos.js#L866L924

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Nothing happens when I modify Alliance information

Expected Results
Edit the Alliance properties
Actual Results

Basically, nothing happens except emptying the text you entered.
Steps to Reproduce
Go to the alliance tab and then enter any of the values to be changes, The name or the user limit.
App Version
0.1
Error Logs
No response
Is there an existing issue for this?

[X] I have searched the existing issues before opening this issue.
[X] I have provided all relevant details regarding this issue.
[X] I have removed my API Key from display, if visible.

Additional Context
No response

Fixed with 7eb011f


refs #177 added rake task to set slug for legacy data

Added rake task rake mongoid_slug:set that will set slug for existing records, if not already set.
We can pass optional parameters to task like rake mongoid_slug:set[Model1,Model2] so that slug will get set for records of only these models.
To load this task into Rails, I loaded task using Rails::Railtie so this task will be directly available to Rails projects. For other frameworks user have to load tasks file into their rake stack.
Added associated test cases.

Why does this have to be Rais-specific? The only rails-specific thing I see here is the Railtie, which is really just a convenience to load Rake tasks. No?

@dblock Yes, task is not Rails specific. I added Railtie just to reduce efforts of explicitly loading this rake task file into Rails project's stack.
I corrected README.

Would you please correct the minor stuff and the double-definition. This will be good to merge. Thx.

This also needs an entry in CHANGELOG, please.

I think you also want a load_tasks method like here so it can be used outside of Rails. And document it please.

Btw, there's a way to find all classes that mix in Mongoid::Slug without storing it. Maybe better? Not sure.
https://www.ruby-forum.com/topic/163430
Module.constants.find_all{ |k| k != k.upcase ? Mongoid::Slug > (Object.const_get k) : nil}

Also this motivated me to write https://github.com/dblock/module-mixins if you want to try that :)

@dblock yes, approach suggested by you for finding all classes that includes Mongoid::Slug is better than storing them in variable, will rectify PR.

I have a few nitpicks, and also please check the build.

Bump. Squash/rebase this and fix the build, I'm happy to merge.

@dblock rebased with master and squashed commits.

Merged via https://github.com/digitalplaywright/mongoid-slug/commit/8abb60d6c263f532e51b1ea064b88e6df25b2658, thanks! Just amended the CHANGELOG slightly.
I think we need a Mongoid::Slug.load_tasks for non-Rails environments, and you would also replace load File.expand_path('../../../lib/tasks/mongoid_slug.rake', __FILE__) in the tests with that. Want to try to code that up?


⚠ Bofrost.fr has degraded performance

In 0ac8bb7, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1920 ms

Resolved: Bofrost.fr performance has improved in cd78f09 after 6 minutes.


Fix: In wallpaper section mouse over is not-defined well #122

Fix : Cursor Property in Wallpaper Page

@all-contributors please add @harshit1142  for code, design, and ideas

👍 @harshit1142 Thank you for both of your contributions in improving the style and UI of the website.

@roannav Sir, My pleasure .Thanks for appreciation


Update pl.js

Description
pl.js translation update
Type of change
Please delete options that are not relevant.

Translation update

Checklist

[ ] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[ ] I have performed a self-review of my own code and test it
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

CC: @kry008, @zsxeee, @atlochowski, @NixNotCastey, @Misly16

lgtm

I added some more fixes. IMO PR is ready for final Code Review


Docstrings for Anopheles extra metadata methods

Forgot to add docstrings for the extra metadata methods.
Also cleaned up some TODO/FIXME comments which don't seem to need fixing or resolving any more, at least not in my dev environment.

It would be good to understand why some of these issues are being flagged and whether they pose actual problems or require any remedies. I suppose we could further suppress warnings or at least provide a comment about it, in case these warnings worry other developers. On the other hand, if there are no real concerns, then it's good to remove such ghost comments, which might only contribute to confusion or clutter.

These warnings that come up in pycharm generally seem to be edge cases where pycharm's type checker doesn't work correctly, or where pycharm fails to correctly find functions or methods in some external module. Basically, pycharm does generate spurious warning from time to time. With each new release, pycharm's linting resolves some of these problems, and so spurious warnings may go away after upgrading pycharm. But it's still not perfect, and so spurious warnings will come up from time to time. If they do, I think it's fine to mark them to be ignored via a # noinspection comment.
Ultimately we have the unit tests, plus we have linting via flake8 as a precommit hook and in CI, so those should catch any real problems.


Audio file transcription.

Hi,
I am interested in doing audio file transcriptions.
I saw that a toggle bar used for audio file transcription exists, just below the one for youtube links.
I tried using whisper as model, I embbed a .mp3 in a test note and I tried the summarize pattern over the current note.
I got a message stating that no audio file had been found.
Is there somewhere a documentation explaining how to use this functionality ?
Best regards,
Tristan

This feature is severely lacking right now and I’ll be making improvements to it soon. However for now it will only work on a Mac and they also have to have openai-whisper installed.Once those requirements are met you simply copy the path of the audio file to clipboard, and then use the clipboard source button in the plugin, while the toggle is on of course.Sent from my iPhoneOn Sep 13, 2024, at 11:36 AM, tcambonie @.***> wrote:
Hi,
I am interested in doing audio file transcriptions.
I saw that a toggle bar used for audio file transcription exists, just below the one for youtube links.
I tried using whisper as model, I embbed a .mp3 in a test note and I tried the summarize pattern over the current note.
I got a message stating that no audio file had been found.
Is there somewhere a documentation explaining how to use this functionality ?
Best regards,
Tristan
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>


Cannot select all in debug console

VSCode Version: Version 1.25.1
OS Version: macOS 10.13.6

Steps to Reproduce:

attach to chrome and create debug output
click into to debug console
type cmd + a to select all in the debug console

Does this issue occur when all extensions are disabled?: No, requires the https://github.com/Microsoft/vscode-chrome-debug extension

Sorry looks like it's a dupe of https://github.com/Microsoft/vscode/issues/19877


Make channel detection independent of latest_versions sort order

Previously, channel detection preferred be over beta causing flawed re-directs.

Tested the /<channel> paths for all channels and they redirect correctly. Also tried to click around in the apidocs.


Add Cloudwatch AnomalyDetector resource

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudwatch-anomalydetector.html

Thanks!


Async-connector: Show databases/tables enhancement.

Adding L1 logic db at show databases/tables;

Filtering mysql/information_schema/performance_schema/sys by show databases;

show tables statement display customize table type.

Filtering mysql/information_schema/performance_schema/sys by show databases;

Done

show tables statement display customize table type.

Done


sql 2.1 updates

Hey @tanner0101, you just merged a pull request, have a coin!
You now have 891 coins.


patch local cluster during upgrade path to support v2.8.1

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:

Post upgrade to v1.2-head and v1.3-head, rancher still complains about fleetWorkspaceName not being setup.
For new installs this is already being setup by rancherd during the initialisation phase.
Currently the upgrade still completes successfully as the old fleet agent completes the updates to the bundles.
The fleet agent itself does not get updated as a result, and this is likely to cause issues in future upgrades.
This is visible as seen here: https://github.com/harvester/harvester-installer/pull/646#issuecomment-1925792176
Solution:

An extra step is available in the upgrade_manifests step which will perform the same annotation and status subresource updates as rancherd.
Related Issue:
Test plan:

@mergify backport v1.2

@mergifyio backport v1.2


API: request edit

Update API to provide request edit methods

Need to be merged with https://github.com/hospitalrun-ua/pandaid/pull/31


Please put eval $(thefuck --alias) in your ~/.zshrc.

Hi everyone,
this thing seems amazing.
Please put eval $(thefuck --alias) in your ~/.zshrc.

(Sorry to have closed and reopened this issue, I thought it was a duplicate of #585 but it was not)

It just means to add eval $(thefuck --alias) line to your .zshrc and reload your zsh shell.  Wouldn't that be awesome ?

Please put eval $(thefuck --alias) in your ~/.zshrc.
 To apply changes please relaunch your shell or just run:
   source ~/.zshrc

in case someone doesn't want its zshrc to be modified (for example, I have my aliases in a particular file that is sourced from my zshrc and I like to keep it that way).
I think its consistant with the successive corrections shown in the gif in the readme.

So I've implemented something like this:

(not released yet)

This rocks so hard

Should work in 3.15.


AirGradient Data not Populating in Grafana

I recently setup an Internet Pi node with everything enabled for an airgradient sensor as well.
for the sensor, I have the APIROOT IP of the Pi changed:
String APIROOT = "http://<IP_ADDRESS>:9926/";
The serial monitor outputs a string of characters:
{"wifi":-65,"pm02":0,"rco2":-2,"atmp":20.50,"rhum":30} http://<IP_ADDRESS>:9926/sensors/airgradient:191ec7/measures -1
I'm going to assume Wifi:xx  is the strength and the rest are the sesor data.
When I setup the pi, this was my configuration for AirGradient:
airgradient_enable: true airgradient_sensors: id: attic ip: "<IP_ADDRESS>" port: 9926
Is there an issue in any of my configurations? Any help is greatly appreciated

The biggest issue I found was that Jeff's video did not clearly state we had to use his prometheus exporter airgradient sketch, so his instructions should be updated.


New version: VeriQuEST v1.0.2

Registering package: VeriQuEST
Repository: https://github.com/fieldofnodes/VeriQuEST.jl
Created by: @fieldofnodes
Version: v1.0.2
Commit: 374370cf51c1cc81d938cd0e699d6a4dcb39752f
Reviewed by: @fieldofnodes
Reference: https://github.com/fieldofnodes/VeriQuEST.jl/issues/27#issuecomment-2247436200
Description: Simulating quantum computing verification

[merge approved]


WinAppDriver not able to find WPF elements

Hello, I am using WinAppDriver to connect to an application that says it is Win32 but that inspect.exe lists as WPF(for at least the window and contents frameworkID). I can find all of the content(which is WPF) in the application window through inspect; however, when I tried to find any element in the window Selenium threw an error saying that none could be found using my search parameters, so I printed out the page source for the application, but it only had the correct title bar but none of the WPF content inside. Therefore, I am hoping someone knows what my error is, so that I can access all of the content in my window. I currently think it could have something to do with the page source saying the frameworkID for the window is Win32 but in inspect it says it should be WPF. My code for getting the page source is(PYTHON):
    desired_caps = {
        'app' : gui_exec_path,
    'platformName' : 'Windows',
    'deviceName' : 'WindowsPC',
    'automationName' : 'Windows',
    "appWorkingDir": gui_working_dir,
    "win_app_driver_host": "http://<IP_ADDRESS>:4723",
    "ms:waitForAppLaunch" : 15,
}
driver = webdriver.Remote(command_executor="http://<IP_ADDRESS>:4723",
    desired_capabilities= desired_caps)
time.sleep(5)
print(driver.page_source)
driver.quit()

Page Source Output(should be able to click on it to see better resolution):

Inspect Output:

joshmansky may be several windows, can you try to create a session after the app starts by process or window title and then check page source?
https://github.com/microsoft/WinAppDriver/issues/534#issuecomment-562030077 (Python code you can find in comments)


Update readme to reflect new intent of our Fork

Hello @nicks,
Please review the following commits I made in branch 'dpup-readme'.
9dbf678814bd029ccba42967383419e721f5966f (2015-11-14 10:25:09 -0800)
Update readme to reflect new intent of our Fork
R=@nicks
MANUAL TESTING=not manually tested

lg


reuse resource group

Description
When you want to reuse a resource group there is the parameter ReuseResourceGroup that is deprecated and says not to use it but if you don't pass it it prompts to delete the RG. What is the way to do this as of now?
Platforms affected

[X] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[X] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] macOS 15
[ ] macOS 15 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
N/a
Is it regression?
N/a
Expected behavior
when passing nothing it reuses the group like it says in the propt
Actual behavior
prompts to choose y or n to reuse resource group
Repro steps
run image generation without -reuseresourcegroup with an existing rg in azure.

Hi @gavintoddchurch
We request that you provide logs or any additional data about this issue to validate and reproduce it.

Fix runerge

Hi @gavintoddchurch
We request that you provide logs or any additional data about this issue to validate and reproduce it.

If you run the GenerateResourcesAndImage command without -ReuseResourceGroup it will prompt you with a yes or no if you want to delete the resource group.
If you pass -ReuseResourceGroup you get this warning
WARNING: The ReuseResourceGroup and Force parameters are deprecated and will be removed in a future release. The resource group will be reused when it already exists and an error will be thrown when it doesn't. If you want to delete the resource group, please delete it manually.

The warning indicates resource group will be reused if it exists and you must delete it manually but the logic does do that. The only way to reuse the resource group is to pass the deprecated parameter
https://github.com/actions/runner-images/blob/b4c921107cb265643b6517731f5cfe515e18a716/helpers/GenerateResourcesAndImage.ps1#L263-L291


socket_tls: add TLS 1.3 support using Mbed TLS

This PR adds:

support for TLS 1.3 from Mbed TLS;
a sample to showcase minimal configurations to get TLS 1.2 or TLS 1.3 TLS sockets. The sample uses native sockets (so it's buildable only on native_sim) because the scope here is just to test the TLS configuration of Mbed TLS. Low level details on how to get a physical connection working on some real device is out of scope of this PR. This helps in:

keeping the sample code minimal
to test it against an OpenSSL server to show interoperability.

Further details are on the readme file included in this PR.
Question to reviewers
This PR introduces a sample which requires an OpenSSL server in order to be tested. The sample includes a bash script to do this, so it's pretty straightforward to accomplish this task locally. Would it be possible to do the same on the CI? Because otherwise the sample cannot be tested.

@aescolar @stephanosio albeit you are not in the "automatic reviewer list" I would like to ask you some tip on how to let the CI test the sample I'm adding in this PR. If I can make it testable then I can also change it to be a test rather than a sample...
In short the sample uses native socket to emulate a TLS connection to a server and the server is an OpenSSL. There's already a bash script included in the PR so that the sample can easily be tested locally. Do you know if there's the possibility to start the server also on the CI?

...There's already a bash script included in the PR so that the sample can easily be tested locally. Do you know if there's the possibility to start the server also on the CI?

I would guess so. A solution may be to write a test using twister's pytest harness https://docs.zephyrproject.org/latest/develop/test/pytest.html which would run the server and your zephyr.exe.
In you want to do a quick trial before jumping into pytest, you could create a draft PR (so you don't spam too much) and start by provisionally hijacking some other of the shell scripts in tree which are run in CI. For ex., tests/bsim/ci.net.sh (remove all its content and instead do your own thing) to try that your test runs well in CI, as you may need to install more packages or so.

A general comment, please don't mix up changes in the files between commits, for example the commit introducing the sample should introduce the sample only, and not modify sockets_tls.c.

Yes, sorry, the mixing was not intentional. Changes appeared in the wrong commits due to my rebase error during the development. I should have fixed this and I will ensure this is kept in future updates as well.

A general comment, please don't mix up changes in the files between commits, for example the commit introducing the sample should introduce the sample only, and not modify sockets_tls.c.

Yes, sorry, the mixing was not intentional. Changes appeared in the wrong commits due to my rebase error during the development. I should have fixed this and I will ensure this is kept in future updates as well.

Sure, no worries, happens all the time. Just please use net:  component in the commit title prefix for networking changes, so it's easy for us to track networking-related changes in the history (makes our life easier when compiling release notes). So net: sockets: , samples: net:  etc.

Sorry, I had to rebase due to a conflict with main on the release-note-4.0. No other change was done


Implement a backend service which provides the painting in a proper format.

fix image saving issues. change DTOs because front-end needs some information. 05b079b05d639d6a1a01c6c8ce9a93642c8040c9


Update xapi-profiles-about.md

Initial draft... definitions still needed

Left one note and some others are possible, but as this is largely non-normative I've left it as is for merging


Segmentation fault (core dumped)

Editing shapes in implicit space is really cool, and I really want to try the demo!  Unfortunately, I got everything fixed, but I encountered this problem:

(In Linux env)
Is there any good way to solve it? Thank you！

Me too ,bro

You may need to ensure that your GPU servers are available for GUI. Or you can use MobaXterm to open the X server , and set "export DISPLAY=localhost:0.0" (or 10.0, 11.0).


Reformat readme file

Pull Request Description:
Summary:
This pull request addresses inconsistencies and formatting issues in the README.md file to improve the overall clarity and readability of the documentation.
Description:
What is the problem?
The current state of the README.md file contains inconsistencies and formatting issues that can make it difficult for users to understand the project and its usage. These issues include inconsistent headings, inconsistent use of code formatting, and unclear language.
How does this PR fix the problem?
This pull request aims to resolve the issues mentioned above by:

Standardizing headings and subheadings for better organization and readability.
Ensuring consistent use of code formatting for code snippets and command-line instructions.
Clarifying and simplifying language to make the documentation more user-friendly.
Checking and correcting any grammatical errors or typos.

Related Issues:
This pull request is related to the following issues:

Issue #3: README.md file has inconsistencies or formatting issues.

Checklist:

[x] The README.md file is now consistent in terms of formatting and language.
[x] Code snippets and command-line instructions are properly formatted.
[x] Spelling and grammar have been reviewed and corrected.
[x] Related issue(s) have been linked to this pull request.

Additional Notes:
I have added the Introduction part which I can modify if it does not comply with the project.

@Vedansh-777 I think the readme file is not beginner-friendly for anyone with less experience. So, I want to add some step-by-step guidance in README.md file which can be helpful for anyone who is looking to contribute to the project. May I raise an issue for this and work on this?

@Vedansh-777 I think the readme file is not beginner-friendly for anyone with less experience. So, I want to add some step-by-step guidance in README.md file which can be helpful for anyone who is looking to contribute to the project. May I raise an issue for this and work on this?

@shivathapaa  Of course! We appreciate your effort to enhance the README for better accessibility, especially for beginners. Your contributions are highly valued, and we eagerly anticipate your improvements to the project's documentation.


Parsed Err msg

Closes #1071
Description:
Now errors are well parsed and shows correctly on delegation attempt.

❤ Thank you!

CI seems to be down. Have you tried retriggering it?

i updated the snapshots because the added lines looked like what i expect a revoked validator should look like. there might have also been some errors from the e2e tests yesterday that seem to be circle's fault

@okwme Le'ts take a look into them today

i thought it had been removed since it wasn't defined anywhere else but I
think it's another piece missing from your PR
On Mon, Aug 13, 2018 at 6:52 PM Fabian<EMAIL_ADDRESS>wrote:

@faboweb commented on this pull request.
In app/src/renderer/connectors/lcdClientMock.js
https://github.com/cosmos/voyager/pull/1094#discussion_r209682471:

@@ -324,7 +324,9 @@ module.exports = {
candidate.delegator_shares = (
parseInt(candidate.delegator_shares) + amount
).toString()

 storeTx("cosmos-sdk/MsgDelegate", tx)

 // storeTx("cosmos-sdk/MsgDelegate", tx) // do we need this anymore?

yes, this stores the txs in the txs list to be able to show them in the
transaction history
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cosmos/voyager/pull/1094#pullrequestreview-145742790,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA611F9fVUpnfQiiF5dngYtkJRz2Swyxks5uQa7agaJpZM4Vzvy9
.


Install issues for cadvisor

Hello,
I am installing this container pack on an unprivileged LXC container on Proxmox PVE 7.  The container is based on the ubuntu 21.04 template and all packages are up to date and current.  I have cloned the repository and cut and pasted your default docker-compose startup command (with the admin passwords, etc.)  This is what I get:
ERROR: for cadvisor  Cannot start service cadvisor: error gathering device information while adding custom device "/dev/kmsg": no such file or directory
ERROR: Encountered errors while bringing up the project.

What am I doing wrong?

Based on my most recent testing binding /dev/kmsg into the container alone via the devices option is not enough, you need to enable the privileged flag on the container too.
You can try remove the whole devices option in the docker-compose.yml you just won't get OOM events which isn't really a big deal.

That did the trick!  Thanks

No problems, glad you got it sorted!


pre-commit: Add more jobs

% grep http .pre-commit-config.yaml
Learn more about this config here: https://pre-commit.com/

repo: https://github.com/pre-commit/pre-commit-hooks
repo: https://github.com/MarcoGorelli/auto-walrus
repo: https://github.com/codespell-project/codespell
repo: https://github.com/astral-sh/ruff-pre-commit
repo: https://github.com/tox-dev/pyproject-fmt
repo: https://github.com/abravalheri/validate-pyproject

% git diff master --name-only
.pre-commit-config.yaml  # I modified this file
pyproject.toml  # This file was modified by pyproject-fmt and validated by validate-pyproject
requirements.txt  # This file was modified by requirements-txt-fixer
test_app/models.py  # This file was modified by auto-walrus
waffle/management/commands/waffle_delete.py  # This file was modified by auto-walrus
waffle/models.py  # This file was modified by auto-walrus
waffle/tests/test_templates.py  # This file was modified by codespell as started in:

#473
#478

% grep http .pre-commit-config.yaml
Learn more about this config here: https://pre-commit.com/

repo: https://github.com/pre-commit/pre-commit-hooks
repo: https://github.com/MarcoGorelli/auto-walrus
repo: https://github.com/codespell-project/codespell
repo: https://github.com/astral-sh/ruff-pre-commit
repo: https://github.com/tox-dev/pyproject-fmt
repo: https://github.com/abravalheri/validate-pyproject

@cclauss Let me rephrase my review:
This PR adds

27 new pre-commit hooks under pre-commit-hooks
4 new pre-commit hooks

Ruff PR added

28 enabled ruff rulesets, including the ones for Airflow, numpy, and pandas
28 disabled ruff rulesets
9 linter settings

Having pyupgrade, flake8, black, etc., in place is good, but adding 96 different linter settings without discussing it first is not the best way to go.

Hello here are my first thoughts on this one
Adding pre-commit checks for things which commonly fail in CI is definitely a good idea.
I think pre commit hooks should usually be a curated subset of the CI checks.
We should avoid unnecessarily adding things which make it harder to start contributing or significantly slower to commit.
I have not specifically assessed this set of pre-commit hooks to know where they fall within that range.

I have proposed this set of pre-commit hooks.  If you tell me which ones you object to, I can remove them.

All which are not part of ci, to avoid adding noise to PRs


[VoIP] Add decline and accept buttons in notification

#658

Updated icon result:

Fix and suggestion are applied


Bug?

Thanks for this; however, I think the correct change is not to make tracer and arg to send_breakpoints, and instead, just stop passing tracer to this function because all of the breakpoints can be squired without it. Would you like to change this?

This bug might be affecting our platform so I merged the fix that I proposed: 3aec690eecd3dbea1a5d00fa69ca400a2c09a6aa
Thank you for reporting this.


Gatsby upgrade

Hey JSMNers! This has just a few changes 😉
I thought this would be a good repo to learn more about Gatsby with. I did the following:

Upgraded/migrated the site to Gatsby 2
Fixed some layout quirks. Most notable I tweaked the margins on a few things, and changed the main breakpoint for many classes from the small to medium size (as defined in the mixins.scss file)
Changed the fonts to use system fonts and removed the typography library
Added a favicon
Used the new logo from https://github.com/JavaScriptMN/JavaScriptMN
Made the Slack logo pure black to match the other logos
Use the flex spare-around justification for the header on small screens

This is magnificent. Thanks so much, Brian!


support for the upcoming 4.10 release?

OCaml 4.10 has been branched off the main development branch (trunk) a few days ago. We would like to start preparing a beta version for users to try and check their own software. ppx_tools currently (at least versions of opam) does not support the current 4.10. Would it be possible to have a release that is compatible with the current 4.10 branch? (we don't expect the parsetree to change before the release, although that's a possibility given feedback from the ppx toolchain)

(cc @Octachron @damiendoligez @kit-ty-kate)


Wierd size calculation in generated output

See: https://github.com/ARMmbed/mbedtls/blob/2.22./3rdparty/everest/library/Hacl_Curve25519.c#L412

Thanks for the issue. I get a 404 -- can you grant me access to the repo?
Thanks,
Jonathan

Thanks for the issue. I get a 404 -- can you grant me access to the repo?
Thanks,
Jonathan

Fixed URL typo - sorry

Shouldn't this oneliner do?
memcpy(output, input, 10 * sizeof(uint64));

Thanks, I agree that it's inelegant and I should fix this. However, this code seems fairly outdated (from several years back) and the newer version of this code does not feature such oddities. Could it be that the cheapest fix is to just submit a pull request to ARM to take the latest version of the code coming from upstream?
I have made sure that the code is available in GCC-compilable form (see https://github.com/project-everest/hacl-star/blob/master/dist/gcc-compatible/Hacl_Curve25519_51.c) or in C89 form if this is still a strict requirement in mbed (https://github.com/project-everest/hacl-star/blob/master/dist/c89-compatible/Hacl_Curve25519_51.c). Also, the new code has no more build headaches and it should suffice to take the dist/kremlin directory, along with the few headers that are mentioned here: https://github.com/project-everest/hacl-star/blob/master/dist/c89-compatible/Hacl_Ed25519.h#L34 (I even suspect that the first two #includes are superfluous).
Let me know if you'd like to give this a try.
Cheers,
Jonathan

The underlying issue has been fixed via 8307c5ebc49bb072ad92ac45a25440d5066df72e


Protagonist falling below the Platform

I am unable to reliably recreate the bug, but sometimes while the Protagonist is in air, upon ducking it passes through the ground, into a dark oblivion from where return is highly unlikely.

The game mechanic has been changed entirely, rendering this useless


Update readme.md with fixed instructions link

Previous wiki link led to 404, fixed

@briandelmsft Full wiki link was needed to properly display the page, fixed it with the latest commit - https://docs.github.com/en/communities/documenting-your-project-with-wikis/editing-wiki-content#adding-links

Let's see if we can pack other broken links in the repo before pushing this.

Let's see if we can pack other broken links in the repo before pushing this.

I believe all other [wiki] references are correctly formatted, only this one was missing. Happy to be proven wrong

I don't see any other files that point to the wiki using a relative path, this appears to be the only one.  Thanks for pointing this out @KostaS10


fix: Dockerfile to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:

https://snyk.io/vuln/SNYK-DEBIAN10-DPKG-2847944
https://snyk.io/vuln/SNYK-DEBIAN10-LIBTASN16-3061094
https://snyk.io/vuln/SNYK-DEBIAN10-OPENSSL-1569403
https://snyk.io/vuln/SNYK-DEBIAN10-OPENSSL-2807585
https://snyk.io/vuln/SNYK-DEBIAN10-OPENSSL-2933515

dd


Bump futures to 0.1.16, move to Notify API

Fixes #356. See that issue for previous discussion. Ping @cuviper.
The Notify API is not fond of Arc<Notify> as the old API was with Arc<Unpark>. Instead it prefers to take a generic T: Into<UnsafeNotify>. Because of the 'static restriction in the implementation provided by futures-rs we need to roll our own implementation of UnsafeNotify and jump through extra hoops to hide the lifetimes in ScopeFuture.
The implementation is easier to follow if you consider that it is analogous to the implementation for Arc in futures-rs.
As a bright side, the old make_unpark is gone along with the unpark field, we now simply reuse the this self reference.
There are probably many places where the unpark terminology should be switched to notify, I should also update the great README.md.

On AppVeyor seems like a Rust MinGW build issue(nightly regression?): https://ci.appveyor.com/project/lilianmoraru/rayon/build/1.0.4
In that build, this is being tested: https://github.com/nikomatsakis/rayon/compare/master...lilianmoraru:master
Pinging @nikomatsakis to raise awareness of a probable nightly regression.

Hmm, similar gcc issues were reported in the users forum:
https://users.rust-lang.org/t/rustup-beta-nightly-linker-error-on-windows-10/11236

The issue is fixed on the latest nightly(not sure about beta but it is not relevant to this pull request since it already passed that test): https://ci.appveyor.com/project/lilianmoraru/rayon/build/1.0.5

I'd rather make these changes atop of https://github.com/nikomatsakis/rayon/pull/344

I'll have to review this Notify API. This feels like a lot of boilerplate, but maybe it's necessary.

Sure I can rebase this on #344

We now have separated rayon-futures -- please do rebase on that!

@cuviper Thanks for the heads up, rebased!

OK so this looks pretty reasonable! I'll be honest, I'm having a bit of a hard time wrapping my head around it, in part because I'm just a bit tired right now. =) @leodasvacas did you want to update the README.md etc?

@nikomatsakis Nice, I was just looking for an OK before updating the README, will do.

@cuviper Fixed it thanks!

@tmccombs Thank you very much for the review! I've clarified the README. Regarding the clone_id and drop_id impls for ArcScopeFuture and ScopeFutureWrapped, while they will they might be useless for us and using the default would happen to be equivalent to the Notify impl for ScopeFuture, I believe the correct thing is to make them explicitly call that impl.

bors r+
I've got to dig more into the notify APIs and stuff myself, but this looks really good. We can continue iterating here regardless. Thanks @leodasvacas very much and sorry about the delays.

PS thanks to @tmccombs for the review as well. =) It's good to have more eyes on this.

bors retry

bors r=nikomatsakis

Looks like a corrupted rustc install on OSX stable.
Third time's the charm, or I'll merge it manually:
@bors r=nikomatsakis

Drop the @-sign.

Bah, thanks.
bors r=nikomatsakis


BASE-24517 Addendum add more comments

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 56s
Docker mode activated.

LGTM, but you're missing an "H" in the commit message for the ticket number.