Can we merge to master?

I was interested in updating gcalcli since I saw that master hasn't been committed to in 2 years.  So, I forked it, ported to python3, updated dependencies, started a rewrite in pythonic_snake_case instead of javaesqueCamelCase, began modularizing the code: broke the package out into a cli file, a backend for interfacing with the calendar api, a utils file, a colors file, etc---set up a unit testing framework with a start of unit tests for said modularized code, set up travis-ci, and so on but then (!)  I found out that someone has been committing to this repo in a branch that's just not getting merged to master.
Well, please, check out the work I've started here: github.com/jcrowgey/gcalcli!
Really, I'd like to foster a discussion about how we can make the work that's going on more visible.  And then, in more detail, I'd love to talk about how to get some of the improvements I've been working on merged into the project.
@tresni @RedBug312 @michaelmhoffman @unit193 @yarikoptic

I understand the project is getting a bit stale. Some commits have been made in other branches but the project isn't moving forward as you might want. After looking at the work you did in your fork I'm open to adding you as a collaborator here. @tresni what do you think?

No objections from me!
-- Brian

On Jun 6, 2018, at 2:09 PM, Eric Davis<EMAIL_ADDRESS>wrote:
I understand the project is getting a bit stale. Some commits have been made in other branches but the project isn't moving forward as you might want. After looking at the work you did in your fork I'm open to adding you as a collaborator here. @tresni what do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Alright. @jcrowgey, you want keys to the kingdom? :-)

Ha!  Keys the kingdom?  Sure!
But I also want to make sure the citizens (and the kings) of the kingdom are happy to have me here.  Can we talk about a roadmap?  Here are some things I'd like to do:
I'd defintely like to get development work back in master, and then release to tags (possible from a release branch).  Is there a anything that blocks merging arparse_over_gflags into master (beside, I assume, a million merge conflicts)?
After that, I'd like to get the unit testing and ci stuff that I got started on merged in.  I only added a few very rudimentary tests, but I think even just having the testing framework in place will really help.  Connected to unit tests is modularization: encapsulating things into functions and whatnot.
Aftter that, I know I'd like to change how the color stuff is handled.  I think we could simplify the class structure into some sort of dictionary.  And of course, there are other issues to address.  But those are the main topics I'm motivated to work on at the moment.

Collaborate invite coming your way!
I'm good with all your ideas. Go for it... :-)

Great!  I'm going to start by merging arparse_over_gflags into master.  Which will resolve this issue.  Then I'll add other issues for the testing and the other things I talked about.
Happy to be aboard!


Issue with Worx Landroid

Hassio 0.68.0 running on a Rasp pi3 and Worx WG796E.1 Firmware 2.66
Issue with sensor "worxlandroid-state" https://www.home-assistant.io/components/sensor.worxlandroid/
Link to the forum with the issue: Worx alwasy mowing
The issue is that the "worxlandroid-state" sensor never change from anything else than "mowing"
What I have in my configuration.yaml
- platform: worxlandroid
    host: <IP_ADDRESS>
    pin: XXXX

Cannot find any error messages in the log. Have been running older Hassio versions and older Worx FW, but it has never worked. Battery sensor is working fine so the communication is ok.
The mower is changing when I took the image snapshot but the sensor indicates that its mowing. When I look into the Worx ios application I can see that the unit is changing.

Below image you see that the battery indicator works like it should.

Hi, I have the same issue. I have make a try to fix this.
I have made it to 3 sensors, battery, state and error.
This is my first time I have made a sensor or change something.. Maybe this will work, maybe not...
add my file in "custom_component/sensor/" and add in configuration.yaml like you have byt change platform-name to same as the file, but without ".py"..
worxlandroid2.zip
I have not test all fails and states of Landroid..
Sensor-names will be:
sensor.worxlandroid2state
sensor.worxlandroid2error
sensor.worxlandroid2battery

Thanks man!
I have added it and let you know if I will find any bugs etc.

I have made some changes. I read little more about how hassio works and if a file in custom_component folder exist it override "original" file when loading.. So no need to change anything in configuration.yaml, just paste file in custom_component/sensor/ with 'worxlandroid.py' as name..
worxlandroid.zip
Things I change..

changed sensor.name and friendly name at once (same name but friendly name have "WorxLandroid - battery" thats why it is "__" in sensor name, bad/good ? please return to me..)

sensor.worxlandroid__battery
sensor.worxlandroid__state
sensor.worxlandroid__error
sensor.worxlandroid__batterychargerstate

One mor sensor, battery charging status.
Add icons as default, guess it is possible to change to own with customize.yaml..
Different icon for battery level. full / 80% / 60% / 40% / 20%..

Things I try to solve:

[ ] Error handling, now it only shows error message before Landroid auto turn off.. Then it shows "no"
[ ] Error icon, to highlight it when error, maybe impossible without custom_ui..

I am a newbie in Github. If I want to push my changes to official file, is it possible ? if it, how ?

https://github.com/home-assistant/home-assistant/pull/14840

This is not closed. Code was not merged.


fix: alignment add_contraction

This PR aims at solving #305
Checklist:

[x] I've added Google style docstrings to my code.
[x] I've used pydantic for typing when/where necessary.
[x] I have linted my code
[x] I have added tests to cover my changes.

@ArshaanNazir @luca-martial feel free to merge if it looks good to you

Whatever issues may come out of this, we will attack in the refactoring branch


Cannot Open Connection tab in Airflow UI

I'm trying to access the connection panel in Airflow UI, but it's giving me an error as below
Something bad has happened.

Airflow is used by many users, and it is very likely that others had similar problems and you can easily find
a solution to your problem.

Consider following these steps:

  * gather the relevant information (detailed logs with errors, reproduction steps, details of your deployment)

  * find similar issues using:
     * [GitHub Discussions](https://github.com/apache/airflow/discussions)
     * [GitHub Issues](https://github.com/apache/airflow/issues)
     * [Stack Overflow](https://stackoverflow.com/questions/tagged/airflow)
     * the usual search engine you use on a daily basis

  * if you run Airflow on a Managed Service, consider opening an issue using the service support channels

  * if you tried and have difficulty with diagnosing and fixing the problem yourself, consider creating a [bug report](https://github.com/apache/airflow/issues/new/choose).
    Make sure however, to include all relevant details and results of your investigation so far.

Python version: 3.10.9
Airflow version: 2.5.1
Node: redact
-------------------------------------------------------------------------------
Error! Please contact server admin.

@nitindr-onetrust, did you try running ./mwaa-local-env reset-db ?
Caution: it will reset your local PosgresDB

Hello @nenkie76 I did tried the reset command. But no yield, same issue!

The issue appears to be resolved when i change the postgress volume path in "docker-compose-local.yml" back to ${PWD}
postgres:
        image: postgres:10-alpine
        environment:
            - POSTGRES_USER=airflow
            - POSTGRES_PASSWORD=airflow
            - POSTGRES_DB=airflow
        logging:
            options:
                max-size: 10m
                max-file: "3"
        volumes:
            - "${PWD}/db-data:/var/lib/postgresql/data"

Previously i've removed  the "${PWD}" from the volume path as i was getting some postgress database error! like below
- "/db-data:/var/lib/postgresql/data"


emacsPackages.vterm: fix dynamic library and autoloaders

Motivation for this change
We need both the .so as well as the proper autoloaders that are generated when
we build an emacs package, so we cannot use the normal stdenv.mkDerivation but
have to inject the building of the libraries instead.
Also, use the proper libvterm-neovim we have in nixpkgs instead of vendoring it.
Without this, spacemacs doesn't detect the package as installed and instead tries to install it itself. I haven't tried with vanilla emacs but without the vterm-pkg.el and auto loader, I don't think it will work.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @lovek323 @peti @the-kenny @jwiegley

If anyone else comes across this PR with the same issue I just had, you need to purge .emacs.d/elpa/$ver/$branch/vterm-* or else Spacemacs will still try to use its local vterm despite this fix.


Nothing works on my Arduino nano

The examble does not run on my Arduino nano. It doesn't compile. There are problems with Softserial and Utility. Do you know anything about this or do you know a solution?

That is a fairly limited device but you should be able to make it work. I would be willing to help with any errors you are having. Can you copy a few at a time here?


Request triager role for lucasraziel

I have read and understood the project's Code of Conduct.
I also have read and understood the process and best practices around Express triaging.
I request for a triager role for the following GitHub organizations:
express

Hi @lucasraziel  welcome aboard! We'll give this issue approx 24 hours for all time zones to have a look and will get you added following that.

Hi @lucasraziel to clarify, you are looking for the expressjs organization, not just this repo, is that right?

Hi @lucasraziel to clarify, you are looking for the expressjs organization, not just this repo, is that right?

Yes, @dougwilson

Great. I sent your invite two days ago. Please let me know here if you're having any issue accepting.


Failing test Arcs demos can book a restaurant

This has been flaky/failing for a while now.  We should disable, then fix.

Didn't this get fixed?


Enable coop map previews and add leaderboard criteria

Closes #2737

@MrRowey Is this criteria true?

@MrRowey Is this criteria true?

It just need to be on hard difficulty secondary objective don't have to be met

I don't see the "no" value in "Secondary objectives" column in any missions

I found it. I did not search well =)

@Marc-Spector


chore: update .github files

Description
This PR is updating the config files inside the .github folder.
Fixes #12
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Chore (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

Current dependencies on/for this PR:

main

PR #15   👈

This comment was auto-generated by Graphite.


[otbn, dv] Adds otbn_rf_base_glitch_detect testcase

This commit adds a testcase called otbn_rf_base_glitch_detect to verify OTBN.RF_BASE.DATA_REG_SW.GLITCH_DETECT countermeasure.

@prajwalaputtappa
we have already supported testing one-hot countermeasure in the common sec_cm test, so in otbn_sec_cm test, it already forces the onehot primitive with these 3 types fault injection.
https://github.com/lowRISC/opentitan/blob/a4684e1331fa7f64d091e37a1a4bda140cd3d4d1/hw/dv/sv/sec_cm/prim_onehot_check_if.sv#L27-L31
perhaps you just need to check if the common sec_cm is sufficient. If you need to do any additional check, we could override the otbn_common_vseq and add it, like you did for other countermeasure, e.g. prim_count

This test is automatically taken care of by sec_cm test.


when generate FM model, but, why can't load the model to predict?

hello, when generate FM model, but, why can't load the model to predict?
Error as follow:
Exception in thread "main" java.lang.Exception: FModel.load did not recognize model with (className, format version):(org.apache.spark.mllib.classification.FMModel$SaveLoadV1_0$, 1.0).

same problem on my Mac with spark 2.1

@withDataman  Hi, do you still remember how to solve this? it happens to me as well


find() fix and deprecation

No needed anymore, because standard library method findViewById() now contains generic.

travis will pass after merging this pull request and #41


Building cell throws error

https://github.com/QCDIS/NaaVRE-container-prestage/runs/5649104763?check_suite_focus=true
Pip subprocess output:
Collecting pathlib
Using cached pathlib-1.0.1.tar.gz (49 kB)
Preparing metadata (setup.py): started
Preparing metadata (setup.py): finished with status 'error'
Pip subprocess error:
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [1 lines of output]
ERROR: Can not execute setup.py since setuptools is not available in the build environment.
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
failed
CondaEnvException: Pip failed

Looks like "pathlib is part of the standard library since Python 3.4. You don't need to install it to use."
https://github.com/pypa/packaging-problems/issues/573

Some modules are deprecated. At the moment we have no way of knowing what are they replaced with.
For new we hardcode the repalcemts


The problem with the “last” column of the table.

Hi,
thank you for your great job.
1.
I have a problem with the “last” column of the table, as shown in the screenshot, at the first loading of the table, the last column (for example “Delete”) is wrapped under the table. But when I click the button “Next” (or then “Prev”),  the table is then displayed correctly. This happens in the browsers Mozilla Firefox ver. 27 and 35 too, in CHROME ver. 40, as well as in my browser I use (for certain reasons) IE 9. I do not use custom column width in the table.

The second problem is, that if I use the custom width of columns in a table (at any one of columns), last column appears below the table, as well as in point no. 1. Even though the number of columns is low (for example only 4 columns).
3.
I know, IE 9… But in this browser is header of the table transparent and when the table scrolls, the data are mixed with header.
What could be the problem?
Thank you very much.

That's really odd, can you find a way for me to reproduce this so I can look at it? Is it your data specifically or is it any data? If I can reproduce it I can help fix it. Thanks!

It's just as well with sample data of "tutorials" table. I sent you mail with my code and libraries too, for analysis. Thank you.


Handle exceptions in operation poll/handleResponse

This addresses issue #333.
Changes:

Catch unhandled exceptions within poll and handleResponse methods for GetBlob/GetBlobInfo/Put/DeleteOperations. This ensures that operation managers do not crash when a single operation fails in an unexpected way. Operations are completed and removed from the operation list if this occurs.
Catch unhandled exceptions in PutOperation's fillChunk method. NOTE: I'm not completely sure what the correct course of action should be when things fail in the chunk filler thread.  We can discuss this. Right now, I set the operation exception and complete the operation.
Add an UnexpectedErrorCount metric.
Errors in user provided callbacks were already caught within OperationCompleteCallback::completeOperation(...)

Reviewers: @pnarayanan (Sorry for sending so many reviews your way), @vgkholla
Time to review: 29 min.
Testing: Added unit tests with induced runtime exceptions for all operation types.  ./gradlew build && ./gradlew test passes.

Looks good overall (yet to take a look at the tests) - let us make the changes that you, @vgkholla and I discussed today.

Could you rebase as well?

Rebased and addressed Priyesh's comments.


Update rust-bitcoin

It's one of our main crypto libs we are a few versions behind.
edit (justinmoon): edited this to be "update rust-bitcoin" from "update secp256k1"

This will have to happen in lock step with rust-bitcoin, miniscript, all the BTC clients using rust-bitcoin structs (bitcoind, esplora, electrum) and possibly some other crates. We need to make sure that all required ones support the same secp version.

This will likely be part of #2667.

This is also blocked on the lightning and lightning-invoice crates. They do not support bitcoin 0.30.1 or secp256k1 0.27.0 yet.

Latest LDK release is now on 0.30
https://github.com/lightningdevkit/rust-lightning/releases/tag/v0.0.119

Latest LDK release is now on 0.30
https://github.com/lightningdevkit/rust-lightning/releases/tag/v0.0.119

https://github.com/lightningdevkit/rust-lightning/pull/2799

lightningdevkit/rust-lightning#2799

If this is the only regression, I think we can still integrate because the only part of LDK that currently runs in WASM is lightning_invoice and the regression this PR fixes is elsewhere.
I propose we update on master but don't backport it.

If no one's currently working on this, I can give it a shot!

I have a broken branch attempting to do this here: https://github.com/m1sterc001guy/fedimint/tree/update_rust_bitcoin
These updates touch a lot of files and some structs in rust-bitcoin removed their Encodable and Decodable traits.

Relevant TODO https://github.com/fedimint/fedimint/blob/47eb296afc274c9526163993141edc42f8c8c9d1/fedimint-core/src/session_outcome.rs#L70-L78

Unless anyone knows of more work to do for this issue, I think we can mark this as done!

@tvolk131 is going to make a separate issue for removing bitcoin 29 from the codebase.

congrats!


Update V4 models

Fixes #591  .
Changes proposed in this PR:

update the v4 interfaces;
update the unit tests.

@mariacarmina shouldn't you have new artifacts? Alex updated the contracts a couple of days ago.

@mariacarmina shouldn't you have new artifacts? Alex updated the contracts a couple of days ago. I assume this PR is for syncing the models to the contracts, but without new (re-copied from barge) artifacts how can it work?

I have updated the artifacts in another PR and here I was just resolving the failing tests.

LGTM.


Bundle the 4gb patch and other game enhancements with the launcher

This may not be necessary.

Bundled 4GB patch. Maybe bundle some DLLs?

Bundled SC4Fix.dll with the launcher, as it is essential when running mods. Other game fixes could be added in the future as well.


Submit basic functionality for Studio Add Class

Page lives under app/studio/[studioID]
Currently some hard coding for studioID and locationID to be refactored later (see inline comments in code)
Routes back to app/studio/[studioID] on form submit and click to cancel
POSTs data to classes table as expected

I like your "to-do" comments, well done!
My only feedback is you should style your commit messages without quotations and using semantic commits: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716


optimize:use raw types instead of boxing types

Ⅰ. Describe what this PR did
optimize:use raw types instead of boxing types
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1747 into develop will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             develop   #1747   +/-   ##
=========================================
  Coverage       48.7%   48.7%
  Complexity      1858    1858
=========================================
  Files            365     365
  Lines          13249   13249
  Branches        1639    1639
=========================================
  Hits            6453    6453
  Misses          6127    6127
  Partials         669     669

Impacted Files
Coverage Δ
Complexity Δ

.../io/seata/common/loader/EnhancedServiceLoader.java
62.29% <100%> (ø)
24 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42cc591...dc05786. Read the comment docs.


feat(nexus): support project and entity with wandb.init()

Also done:

Created framework for testing graphql

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@e1e47ee). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage        ?   24.43%
=======================================
  Files           ?       16
  Lines           ?     1874
  Branches        ?        0
=======================================
  Hits            ?      458
  Misses          ?     1374
  Partials        ?       42

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BUG] Cannot Provision RKE1 on vSphere

Rancher Server Setup

Rancher version: v2.9.3
Installation option (Docker install/Helm Chart): any

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc):

Proxy/Cert Details:

Information about the Cluster

Kubernetes version:  any
Cluster Type (Local/Downstream):

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): Downstream, RKE1 node-driver vSphere

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom) Admin

Describe the bug
Currently, attempting to provision a rke1 cluster on vsphere results in the following error in both Ubuntu and Rocky (tested so far):
Error setting machine configuration from flags provided: open /FAM2EQU42T/cloud-config: permission denied:Timeout waiting for ssh key

This occurs when creating new clusters or adding nodes to an existing cluster if Rancher has been upgraded from an older version.
To Reproduce

Spin up Rancher v2.9.3
Add vSphere Cloud Creds
Create RKE1 Node Template
Create new RKE1 cluster w/vSphere node driver
No extra options, also tried multiple K8S versions

Result
The following error in Rancher UI on the nodes
Error setting machine configuration from flags provided: open /FAM2EQU42T/cloud-config: permission denied:Timeout waiting for ssh key

Expected Result

Cluster provision should succeed
Additional Inforamtion
When creating a Node Template for vSphere through the Rancher UI, the UI appends the string #cloud-config to the Cloud Config field by default. See the following screenshot

SURE-9329

The fix can be validated on the latest v2.10-head image

Ticket #47938 - Test Results - ✅

Scenario
Test Case
Result

1.
provision RKE1 cluster
PASS

Verified with (HA Helm or Docker) on Rancher v2.10-head:
Scenario 1: provision RKE1 cluster

Provision an RKE1 cluster
Verify that no permission error is observed
Login to one of the nodes
Verify that the permissions for cloud-config are set properly

Results: No error was observed the cluster provisioned successfully


Update grammar to reflect the ability to use reserved keywords in annotation names

This line states that annotation names should be IDENTs, which was true until this PR was merged.
The grammar should now allow any IDENT | RESERVED there. Or maybe the new AnyId concept in the Rust parser could be immortalized in the grammar.

Adding ANYIDENT seems like the cleanest solution to me, but open to feedback on #132


sandbox support

see how thomas ankcorn's s3 plugin works https://github.com/Ankcorn/arc-buckets-plugin/blob/master/index.js
uses s3rver, noice, a small fake s3, and i like the client lib distribution of using src/shared.
gotta tie this up with service discovery tho, see https://github.com/architect/architect/issues/1091

forcing client lib distribution via src/shared might not work for people using bundlers...

Done in 1.1.0!


refactor: convert to less (Revert "Revert "refactor: convert to less"")

Thanks to @isabelroses

Sorry for the delay, had a bit of time figuring out how this new structure works

No worries, I hope it was all good


Crash when SourceUri is null

I am having an application with MVVM binding. Below is the code snippet
  <ffimageloading:CachedImage Aspect="AspectFill"                                               LoadingPlaceholder="Image_placeholder.png>
<ffimageloading:CachedImage.Source>
UriImageSource Uri="{Binding ImageUrl}"/>
</ffimageloading:CachedImage.Source>
</ffimageloading:CachedImage>

In this when ImageUrl is null, the app is crashing. Anyway to handle this?

You could use this:
  <ffimageloading:CachedImage Aspect="AspectFill"                                               LoadingPlaceholder="Image_placeholder.png Source={Binding ImageUrl}>
</ffimageloading:CachedImage>

Thanks.. I used it...


iOS 10 Http getting requests not working

I wrote an http plugin based on homebridge-better-http-rgb plugin and homebridge-readablehttp in way to get hue, saturation and brightness from my arduino project.
Setting those values it works properly, and it should work also getting them.
The problem is that: if I use thirty apps to control my light, all works fine even if no getting function are called by homebridge.
If I open Home app, it gets stuck getting the lamp status and no requests are received by my device.
Can't figure out if it's my plugin's fault or it is homebridge + iOS 10
Edit: looking at homebridge log sometimes one or two of the getting functions work, but almost always it shows (after a while) "socket hang up" and arduino hasn't received nothing

I've got the very same problem. I even wrote my one http plugin for my NodeMCU project but i always get that status error.

I'm working with arduino + ESP8266 and then I'm going to port my project to the NodeMCU.
I hope it's not a problem related with the ESP or its library.
Can you post your http response you wrote for the NodeMCU? Is it possible that homebridge is waiting for somewhat?

So i debugged my code. It seems like the request from the Home app is requested immediately after i open the control center, but sometimes the response comes 7 seconds to late. Im trying to find a solution.

I noticed that if I set the plugin (or the configuration) to ask for one value per time (eg only the power status or the brightness) it works properly. It makes a mess requesting multiple values per time.


brew tap-new: tests.yml workflow fails with casks

Running brew test-bot --only-tap-syntax fails on ubuntu-latest if any casks are added later to the tap, since casks are macOS only.
See github.com/ncruces/homebrew-tap for my custom tap. I've fixed this in main by adding this line (which prevents brew test-bot --only-tap-syntax from running on ubuntu-latest, but still runs it on macos-latest, which should be enough to ensure correctness).
The casks-not-supported branch reverts the change, and causes the failure.
This was my best attempt for a fix, but I'm open to suggestions and doing the necessary leg work to get them through.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

This was my best attempt for a fix, but I'm open to suggestions and doing the necessary leg work to get them through.

Thanks @ncruces! My thinking is fixing that uninitialized constant Cask::Cmd::AbstractCommand would be the best bet here; it's probably just a missing require. It may be (I'm not sure, please correct me either way @Homebrew/cask @reitermarkus) that brew audit isn't expected to work for casks on Linux in which case that would be the best fix.

brew audit isn't expected to work for casks on Linux

I don't know about expectations but I can confirm that brew audit is never run on Linux in our CI. The syntax job that runs on ubuntu-latest in most situations only runs brew style.

If this PR isn't the right answer (which it probably isn't), should I close it and open an issue? Feel free to do it yourselves!
I don't think I understand Homebrew well enough to contribute the actual fix, but I'm available to test it.
Thanks!

I feel like brew test-bot --only-tap-syntax should still work on Linux, even if casks are macOS-only.

Agreed.

If this PR isn't the right answer (which it probably isn't), should I close it and open an issue? Feel free to do it yourselves!

We'd be happy to help point you in the right direction for this @ncruces if you'd be game to continue working on it?

We'd be happy to help point you in the right direction for this @ncruces if you'd be game to continue working on it?

Please do. I anticipate the workflow for a fix should be quite different (running a forked version of Homebrew, which I've successfully avoided, so far... eh). But if I feel overwhelmed, I'll say so then. Happy to help.

Thanks so much for your contribution!  You rock, @ncruces!


stake pool registration

Some minor things are to be done yet.

displaying transaction fee/ttl in the UI is IMHO not an essential information for an owner and we can jump directly into showing the stakepool registration data, or was it requested by IOHK?

All of the agreed-upon UI changes are now implemented.


Updated README.md now that docs exist

The current version of the README.md was written before we had docs. We should update it to include just a few instructions on installation and basic usage, then refer users to the docs.

We can change the installation instructions to
using Pkg
Pkg.add("MuJoCo.jl")

after the package is officially registered too.


CI fixes

A typo in the functional tests configuration, and Cargo 1.43 was failing to fetch crates.io for some reason. Update it to 1.48 since it's our current MSRV anyways.

ACK 0efdd3705052bfb8a2b4b9b58fee0f7df7989fd2


SASL PLAIN authentication failed: Kafka v0.10.1 SASL_SSL authentication not working with kafkajs versions after 2.2.0

Bug
Kafka v0.10.1 SASL_SSL authentication not working with kafkajs versions after 2.2.0
SASL PLAIN authentication failed: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received an instance of ArrayBuffer"
Getting below error:
{"level":"ERROR","timestamp":"2022-11-18T08:38:33.600Z","logger":"kafkajs","message":"[SaslAuthenticator-PLAIN] SASL PLAIN authentication failed: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received an instance of ArrayBuffer","broker":"ip-192-168-10-99:9092"}
{"level":"ERROR","timestamp":"2022-11-18T08:38:33.603Z","logger":"kafkajs","message":"[BrokerPool] SASL PLAIN authentication failed: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received an instance of ArrayBuffer","retryCount":0,"retryTime":339}
KafkaJSSASLAuthenticationError: SASL PLAIN authentication failed: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received an instance of ArrayBuffer
at Object.authenticate (/home/ashish/aws-cli/node_modules/kafkajs/src/broker/saslAuthenticator/plain.js:18:23)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async SASLAuthenticator.authenticate (/home/ashish/aws-cli/node_modules/kafkajs/src/broker/saslAuthenticator/index.js:73:5)
at async /home/ashish/aws-cli/node_modules/kafkajs/src/network/connection.js:139:9
at async Connection.authenticate (/home/ashish/aws-cli/node_modules/kafkajs/src/network/connection.js:315:5)
at async Broker.connect (/home/ashish/aws-cli/node_modules/kafkajs/src/broker/index.js:111:7)
at async /home/ashish/aws-cli/node_modules/kafkajs/src/cluster/brokerPool.js:93:9
at async /home/ashish/aws-cli/node_modules/kafkajs/src/cluster/index.js:107:14
at async Cluster.connect (/home/ashish/aws-cli/node_modules/kafkajs/src/cluster/index.js:146:5)
at async Object.connect (/home/ashish/aws-cli/node_modules/kafkajs/src/producer/index.js:219:7) {
retriable: false,
helpUrl: undefined,
[cause]: undefined
}
Code :
import { Kafka, Partitioners } from 'kafkajs';
import * as fs from 'fs';

try {
    const Kafka_Client = new Kafka({
        clientId: "my-app",
        brokers: ["ip-192-168-10-99:9092"],
        // authenticationTimeout: 10000,
        // reauthenticationThreshold: 10000,
        ssl: {
            servername: 'ip-192-168-10-99',
            ca: [fs.readFileSync('./ssl/kafka/kafka-client-ca.pem', 'utf-8')],
            cert: fs.readFileSync('./ssl/kafka/kafka-client-cert-signed.pem', 'utf-8'),
            rejectUnauthorized: true,
        },
        sasl: {
            mechanism: "plain",
            username: "user",
            password: "secret",
        },
    });

    const producer = Kafka_Client.producer({ createPartitioner: Partitioners.LegacyPartitioner });

    await producer.connect();

    await producer.send({
        topic: "test",
        messages: [{ value: 'Hello KafkaJS user!' }],
    });
    console.log('success');
    await producer.disconnect();

} catch (error) {
    console.log(error);
}

Expected behavior
Connection should be successful with SASL_SSL protocol.
Environment:

OS: [Ubuntu 20.04.5 LTS]
KafkaJS version [2.2.0, 2.2.1, 2.2.2]
Kafka version [0.10.1]
NodeJS version [v16.17.0, v14.15.0]

Additional context
However, it works fine with any version below kafkajs 2.2.0.
I cannot change kafka version in my production environment.

#1480

Fixed in v2.2.3.

Thanks! @ricardochen1996 @Nevon


UAR-91: Update landing page

JIRA link
https://companieshouse.atlassian.net/browse/UAR-91
Change description
Adding an update landing page with controller that redirects to "What is the OE Number?".
Work checklist

[ ] Tests added where applicable
[ ] UI changes meet accessibility criteria

Merge instructions
We are committed to keeping commit history clean, consistent and linear.  A BREAKING CHANGE can be part of commits of any type,
types other than fix: and feat: are allowed, for example build:, chore:, ci:, docs:, style:, refactor:, perf:, test:, and others,
footers other than BREAKING CHANGE: <description> may be provided.

The branch name should begin with feature/ so like this: feature/uar-91-what-is-oe-number

Sir Sifat @sjahir , may I keep the current branch name as I think renaming means I'd have to close this PR and delete this branch and create a new one .. I think. Unless you know of a way to rename and preserve the current PR?

Very well Mr @corybudd-ch, I shall be lenient this one time. There is no method to rename a branch within the same pull request.

.DS_Store and package-lock.json should not be in branch. "git rm --cached .DS_Store package-lock.json"? Maybe they should be in .gitignore

@corybudd-ch , there is a conflict which will need to be resolved before merge..

Remember to delete the branch after merging, please

FEATURE_FLAG_ENABLE_ROE_UPDATE_24112022 should be false in all other enviroments. This is the default. I'm unable to see the build fail - unauthorized.

FEATURE_FLAG_ENABLE_ROE_UPDATE_24112022 should be false in all other enviroments. This is the default. I'm unable to see the build fail - just not loading for me.

It is not needed at all, already set to false as default value in the config/index.ts. For the build issue, just run it locally on your environment

I do not know how the pre-check test, from husky, has been bypassed but this issue should have been avoidable.
Anyway I have looked at your test and the bug is related to the service.availability.middleware that needs to be mocked if you want to have a correct response. On another PR could you please add the following code on both your spec files
...
jest.mock('../../../src/middleware/service.availability.middleware');
...
import { serviceAvailabilityMiddleware } from "../../../src/middleware/service.availability.middleware";
...
const mockServiceAvailabilityMiddleware = serviceAvailabilityMiddleware as jest.Mock;
mockServiceAvailabilityMiddleware.mockImplementation((req: Request, res: Response, next: NextFunction) => next() );
...


No testing framework integrated to the back-end

Stackle does not have a testing framework integrated in to its back end.

Hi @psnmissaka ,
Would love to work on this issue. I can setup backend testing using mocha and chai. As well as add coverage using istanbul or nyc.


Update README.md

Fixed minor language fluency.

Hi, none of the changes you made are real grammatical fixes; some of them introduce actual grammatical errors. I'm going to close this PR. Please try to make more significant contributions to OSSs in the future than this—many projects even forbid people from sending grammar or typo fixes because it's a waste of maintainer time without improving consumer experience.


Update in silico scores based on new guidelines

Related to the work in seqr ticket #3505.
We would like to have annotations matching up with new guidelines from ClinGen. They put forth evidence ranges of scores falling into certain categories. To be consistent, we need to be using the scores for FATHMM, SIFT, PolyPhen
Currently, the old categories are being displayed.
Colors will be based on ranges as shown here but will submit another app ticket to update this in seqr

Prefer score vs pred.

Update for V3 only

This is complete.


Generate a list of random names

User should be able to generate a list of random names.
Generate a random list of 1-10 names based on

type
gender
theme
starting letter

Basic code is now implemented for type and gender. Other criteria will be added soon. Once done, this issue will be closed.

Decided to do all names based on theme. Users could add a theme of "Female cats", for example, if that sort of specificity were desired, rather than having to keep track of what names can go with what species/gender, etc., so closing this issue. See #53 for details.

Decided to do all names based on theme. Users could add a theme of "Female cats", for example, if that sort of specificity were desired, rather than having to keep track of what names can go with what species/gender, etc., so closing this issue. See #53 for details.


Panic messages are not printed on android.

I have android logger setup in the rust library.
If the library panics, there are no errors logged. Messages are only logged if the explicit info!() or error!() is called.

@faisal00813, do you use log-panics crate in additon to android-logger crate? Because of without it your library does not use log infrastructure and just print to stdout/stderr, this is how rust stdlib works.

@Dushistov Thanks!
That helped. But the log message does not have the line number.
I think passing RUST_BACKTRACE should do that. Do you know how to pass env variables to the Android app through android studio?

@faisal00813,  you can use libc::setenv in place where you initialize android logger and log-panics.
But I, personally, never use it, because of android runtime print backtrace of crashed code (native and java) to log. May be you just build without debug info?

Hey, thanks for bug report. The panic handling won't be in scope of this library. However, it is easy to create your own panic handler: the code in log-panics crate is not compex.


Customer Login Issue

While Loggin with Email and password Api Version 2024-07.
OperationException(linkException: null, graphqlErrors: [GraphQLError(message: Field 'lastIncompleteCheckout' doesn't exist on type 'Customer', locations: [ErrorLocation(line: 58, column: 5)], path: [query, customer, lastIncompleteCheckout], extensions: {code: undefinedField, typeName: Customer, fieldName: lastIncompleteCheckout})])

lastIncompleteCheckout is depreciated in the latest Flutter version 2024-07.
This has been fixed in the latest version 2.1.0.


Mesh must have normals and uvs

Hi, I use this application to convert dicom files to obj file.
When I try to use it in a 3d application, something goes wrong with this message:
"Mesh must have normals and uvs"
Could you help me/there is any option that can I set on command line?
Thanks a lot,
Stefano.

Hi Stefano,
Do you export the mesh as obj? Something like

dicom2mesh -i xxx/yyy -o myMesh**.obj**

If that is the case, please try to export the mesh as stl

dicom2mesh -i xxx/yyy -o myMesh**.stl**

We wrote the obj exporter ourself. It does not export uv coordinates. However, blender and meshlab are able to open our obj. What application do you use'

Hi eidelen, thanks for the quick response.
Yes, I export the mesh as obj and then I use a custom software (something not famous) to view it.
I'm going to talk with the team about the stl format.
Thanks a lot,
Stefano.

Hi Stefano,
Is this issue still active? If not, I suggest to close it. Fine for you?
Thanks, Adrian

Hi Adrian,
yes, you do. I resolved by using a blender script that unwrap the mesh: bpy.ops.uv.cube_project().
Thanks a lot,
Stefano.


Please add info and warning toasts

It would be great to include info (blue) and warning (yellow) toasts alongside the default "success" and "error" types.

I actually did a PR for this.
#10

Fixed in https://github.com/wobsoriano/svelte-sonner/pull/10


Fixes #1796 add proper @pico-sdk prefix to //bazel/config reference

Without this, we're trying to refer to a subpackage of the lwip directory called bazel/config, which doesn't exist. See similar references in this file.
Fixes #1796

I'm not sure how it would be best to review the various changes needed to get LWIP working. I've set up this one pull request for this one tactical change, but there are a variety of other changes needed to the bazel build files to get to a working Bazel implementation of lwip, and especially lwip with freertos. Let me know if you'd like to see all the commits in one pull request, or a separate request for each tactical change.

I'm fine with either, but @kilograham is the one with the merge button.

Do you happen to know the RPI people's typical preferences? They're extremely busy with the rp2350 launch right now so I'd love for this to be in the ideal condition for review whenever he gets around to it.

Stick all related changes in one PR.

@armandomontanez PTAL -- this now contains all the necessary changes to build the Pigweed + Pico-W thingy I showed y'all.

I'm fine with either, but @kilograham is the one with the merge button.

Yeah sorry, caught COVID at DEFCON

Don't rush on my account. Take your time.

I'm fine with either, but @kilograham is the one with the merge button.

 :) No urgency here.

@kilograham this is ready to merge whenever you're back.


⚠ Turnos 24x7 has degraded performance

In e44d367, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 968 ms

Resolved: Turnos 24x7 performance has improved in 15ba3ff.


Avy in its own Column

Added avy column to the Chat page
Avy is now bigger

Hmm, I think this takes up too much horizontal space. We're already squeezing both chat messages and people with names a little on the long side

Ok, would you like the avy column to be shorten a bit and the User column to take up the extra space so it has more breathing room, or do we leave things as they are atm

Ok, would you like the avy column to be shorten a bit and the User column to take up the extra space so it has more breathing room, or do we leave things as they are atm

I'd say leave things as they are atm, although we could try increasing avatar size a bit more. Maybe 50px

Ok sounds good👍


added windows 11

after reading this article, i confirmed windows 11 is supported

Learn Build status updates of commit 5304b03:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows/security/threat-protection/security-policy-settings/interactive-logon-do-not-display-last-user-name.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Add default colors for masks

Added default color table for mask export
Added an option to use the source colormap in VOC segmentation export when it's provided with source colormap mode
Removed label name changing when exporting masks

Motivation and context

When there are tasks with the same labels, possibly, in different order, it may be useful and is often expected that these tasks will have the same colors for the same labels. This patch adds this functionality by adding a default color table for typical labels.
How has this been tested?

Unit tests.
Checklist

[x] I submit my changes into the develop branch
[x] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Pull Request Test Coverage Report for Build 5136

52 of 58 (89.66%)  changed or added relevant lines in 2 files are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.05%) to 65.442%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cvat/apps/dataset_manager/formats/mask.py
30
33
90.91%

datumaro/datumaro/plugins/voc_format/converter.py
22
25
88.0%

Files with Coverage Reduction
New Missed Lines
%

cvat/apps/engine/media_extractors.py
6
75.37%

Totals

Change from base Build 5095:
0.05%

Covered Lines:
10756

Relevant Lines:
16040

💛  - Coveralls


fix flag  not set in the proper object

Codecov Report

Merging #25 into release-0.2.0-rc.2 will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-0.2.0-rc.2      #25   +/-   ##
===================================================
  Coverage               83.79%   83.79%
===================================================
  Files                      11       11
  Lines                     432      432
===================================================
  Hits                      362      362
  Misses                     55       55
  Partials                   15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 842941e...779048a. Read the comment docs.


Dashboard to visualize results

I've built a proof of concept dashboard to visualize the results. If you are not familiar with dash it lets you compose powerful dashboard with great interactivity in pure Python. It is a really great library. Here examples of what is possible and this is a screenshot of how the dashboard looks right now:

This is just a simple bar chart for now (to see if interest exists). The chart is interactive: You can zoom, hover over data points to get values or click on the legend to hide/show the items.
To start the dashboard use the command with python app.py after installing the dependencies from the requirements.txt. The data is currently hard coded into the Python file, but it should be fairly easy to change it.
ToDo:

[ ] Change docker command to open port 8050
[ ] Automatically start dashboard after benchmarks have been run (and add link to click on)
[ ] Load actual benchmark data into the dashboard (via csv)?
[ ] Move files to a better location

For a first iteration I would not change the dashboard that much (just a bar plot). Future additions could be:

Add sorting options (sort after individual benchmarking cases)

It's a good idea but I don't want to increase maintenance time, right now I have very little time and anything needs maintenance.
Sorry


Deprecate Account Provider

Changes

Replace the use of account provider with loadMetadataForUser. The implementation queries on site load and relies on subscriptions to update but they open a large ammount of connections with the more tokens the user has (this just isn't NFTs but any spl token)

Replaced by
https://github.com/holaplex/metaplex/pull/143


WIP – Handle new flavor of MCAS data

Issue

#1171

TODO

[x] Add new model for "Next Generation" MCAS
[x] Add fake data generator with new "Next Generation" scaled scores
[x] Add new chart to Student Profile if relevant data is present
[ ] Think about what impact this should have on the School Overview page
[ ] Think about what impact this should have on the Homeroom page
[ ] Student Report
[ ] Update X2AssessmentImporter code to correctly classify incoming MCAS data from X2
[ ] Write migration to re-assign "Next Generation" student assessments to the correct parent Assessment

How will the School Overview need to change?
To the end user, the School Overview looks like it's just filtering by performance category, a string value (fake distributions below):

But behind the scenes in SlicePanels.jsx, it's reading an integer value and converting it to performance category:

This data is coming from precomputed Student#most_recent_mcas_math_scaled and Student# most_recent_mcas_ela_scaled.
One approach would be to test the integer score and surface Next Gen MCAS categories if we detect scores above 400.
Another would be to ditch testing integers altogether in this slice panel and just use the strings that surface from X2 to let users filter.
One advantage to the strings-only approach is that the categories could naturally bubble up into the School Overview page from X2 as students go through the system. For example, Uri mentioned that the high school is going to use the old system. Students who go to HS next year might get different MCAS performance categories than they're getting this year.

How will the Homeroom Roster page need to change?

If we go with the "flavors" data structure, I don't think it will need to change at all. As students take the Next Generation MCAS tests, their most_recent_mcas_math_scaled / most_recent_mcas_ela_scaled scores will update from the old performance categories and 200-280 scale to the new categories and the 400-600 scale. And when students graduate to HS (assuming the HS stays with the old MCAS for at least 1 more year), their scores will naturally revert to the older scales.

Closing this in favor of #1178.


Version Number in dist/*.js

Enhancement request:
Add the Reflux version number as a header-comment to the javascript files in dist/*.js.

We now do this in reflux-core: https://github.com/reflux/reflux-core/blob/master/scripts/version / https://github.com/reflux/reflux-core/blob/master/src/index.js#L78
:+1:


Codecov issues

Hi, Tom from Codecov here. I saw the tweet you posted earlier about having issues with Codecov, and I just wanted to reach out and see what we could do to help here.

Seems to be working now. I still can't see settings for this repo in codecov, when I click "Settings", I'm directed to https://app.codecov.io/gh/pydantic/speedate/settings and shown a 404.
Then to make matters works, "back" doesn't work properly. The whole web interface is pretty poor quality at the moment I'm afraid.


CPANSA-ActivePerl: There is no ActivePerl distribution on CPAN

This should perhaps be moved to external_reports

external_reports has a different purpose. Ignore the ActivePerl reports for now.


V2 - Appropriate message is not displayed and email notification is not to user who does not have LFID

Prerequisite

Create a CLA group with CCLA enabled
Add github repository for the CLA group
Generate template

Steps to Follow

Login to Github as corporate contributor
Navigate to the repository used in prerequisite
Create PR
CLA check fails
Click on CLA NOT SIGNED
Contributor is redirected to Contributor Console
Click on Proceed as a Corporate Contributor
Select Company that has not signed CLA for the project
Click No
Enter email of user that does not have LFID
Error message is displayed and email is not sent to the user to create LFID. I checked in IAM to see if the user was created with LFID but the user was not available

Tested and observed that appropriate error message is displayed, however invite email is not sent to the user to create LFID

Verified that the issue is fixed


contextualizing Tell

In order to fully support passing contextual information the current PID.Tell model will not work.
One suggestion is to move the Tell operation over to the actor Context.
e.g.
//instead of
pid.Tell(msg)

//we would instead have
ctx.Tell(pid, msg)

This would allow us to build things like tracing using e.g. Zipkin.
It would also greatly simplyfy having multiple actor systems running at the same time. e.g. for parallel testing.
ctx would then be like a phone and the PID would just be the phone number.
Currently PID is both.
This would be a major breaking change, so I'm not completely sold on this idea myself, but I do see the added value it brings

If we go for this approach, we also need to solve how to talk to PID's from outside an actor.
this could be done by having a Tell func directly in actor
actor.Tell(pid, msg)

That would be a "contextless" Tell.
If you have some sort of context, for example Zipkin data, and you want to call into the actor world using this context.
We could have something like this:
ctx := actor.NewRootContext( whatever context data)
ctx. Tell(pid, msg)

I think this would be fairly clean, even if this approach is more verbose than what we have currently.

I'm not too familiar with how the context and PID interact yet, but from a user perspective I think it's important that there are as few ways as possible of doing something, preferably just one if possible.
Would it be a bad coupling if the PID knew about the context it belongs to? So calling pid.Tell would notify the context of the Tell operation, so it can do tracing or whatever it is it needs to do.

Discussed API:
context.Tell(pid, message)
Related tasks

Introducing a message envelope type carrying message headers.
Introduce way of reading message headers from actor Context
Introduce outbound middleware allowing code to read from actor context and write to outgoing message headers

have you considered
func (c Ctx) Tell(pid *PID, message interface{}) {
    if msg, ok := message.(Message) {
      c.tellMessage(pid, msg)
    }
    c.tellMessage(pid, Message{Object: message})
}

Pros:

flexibility of telling with a simple message, or with additional details in the headers with a small API surface

Cons:

not discover-able from IDE

Additionally, I'd remove the helper Tell from PID and keep it as a DTO (functional style) rather than have two different methods to achieve the same operations as cpx86 suggested.
Have you considered changing Message.Object to Message.Body?  I feel it's more descriptive.


Add ArchiveAll() Support

This function (on pachctl CLI) allows a user to 'reset' the cluster quickly, since calling DeleteAll() can be expensive

Ok, think I addressed all your inline comments. Just need to make sure that it plays nice w CI


Pack commons-text and its transitive dependency commons-lang3

Commons-text is used in axiom to fix the issue https://github.com/wso2/product-ei/issues/3789.
Therefore packing commons-text and its transitive dependency, while packing the axiom itself in the kernel.

Need to merge this only after merging https://github.com/wso2/wso2-axiom/pull/57


Tabbed content fix

Docs Build status updates of commit 2ec64cd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webdriver-chromium.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


ash::vk::PFN_vkFreeFunction has unfortunate signature

ash::vk::PFN_vkFreeFunction is currently defined as
type PFN_vkFreeFunction = Option<unsafe extern "system" fn(p_user_data: *mut c_void, p_memory: *mut c_void) -> c_void>;

Notice that the return type is c_void instead of ().
The c_void documentation makes it clear that this is incorrect:

Equivalent to C's void type when used as a pointer.
In essence, *const c_void is equivalent to C's const void* and *mut c_void is equivalent to C's void*. That said, this is not the
same as C's void return type, which is Rust's () type.

The current signature sadly makes it impossible to actually provide a vkFreeFunction to vulkan (without crazy function pointer casts), because a c_void cannot be constructed inside an implementation of type PFN_vkFreeFunction .

Looks like quite a few functions (even "irrelevant" internal ones) return c_void now, should be trivially fixable in the generator :)

Looks like quite a few functions (even "irrelevant" internal ones) return c_void now, should be trivially fixable in the generator :)


Module should chain-output "security_group_id" from child module "service"

Describe the solution you'd like.
The child module "service" is outputting the security_group_id tied to the ECS service. However, the "root" module does not further chain this output, making it inaccessible for module calls outside of this module.
This would be particularly useful in order to limit the network access scope between the load balancer and the ECS services, rather than just using the CIDR of the whole VPC.

it does, you just have to extract it from https://github.com/terraform-aws-modules/terraform-aws-ecs/blob/3b70e1e46e1b96a2da7fbfe6e2c11d44009607f1/outputs.tf#L59-L62


Fast server not starting.

Hello, when postal starts up on its own, fast server is retried 5 times in under a minutes, then fails.
If I start it manually, it runs fine, and there is no output.
Is there something in particular I should be looking for here?
Nothing relevant in the logs either.
Thanks.

When you start it manually, are you running as the postal user? It may be a permissions problem.

I don't know what went wrong there. I just reinstalled everything.


custom_lint doesn't provide VM service URI for debugging

Describe the bug
When running dart run custom-lint --watch in terminal or looking in custom_lint.log, no VM service Uri is to be found to attach the Dart process of the custom_lint package.

Even though custom_lint in analysis_options.yaml is set to debug: true and verbose: true, only errors are outputted into the custom_lint.log file.
To Reproduce
I tried setting up my own custom_lint package and another dart project depending
Here, I have added a sample project used to reproduce the issue. it depends on pyramid_lint, a custom_lint package that should be debuggable.
sample.zip
Expected behavior

Should be fixed in 0.6.5


Fixed file permissions and updated entry points configuration.

Modulus Pull Request
Description

Fixed file permissions - removed erroneous "execute" permission.
Removed setup.py considered deprecated, moved entry points to pyproject.toml.
Replaced usage of deprecated pkg_resources with importlib.metadata.

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

/blossom-ci

/blossom-ci

/blossom-ci

/blossom-ci


Introduce helper functions for monitoring firewall

Feature scope
AWS WAF
Describe your suggested feature
AWS Offers Several different firewall tools. Having Web Application Firewall being monitored in this library would be greatly helpful.

https://docs.aws.amazon.com/waf/latest/developerguide/monitoring-cloudwatch.html
Can you describe which metrics would be useful for you to monitor and alarm on?

Just curious - what does this metricName parameter do? I see the metric names are specified already in the doc. What changes when you modify it?

Based on what I've seen metricName allows you to specify custom names for the rule or WAF itself.
As far as API to define monitoring, to keep consistent with other APIs it probably would be a good idea to either take the ACL directly (if we can query the metricNames assigned for that ACL) its also worth noting that ACLs can be assigned to an AWS resource, so maybe its possible to "automagically" determine the ACL metrics for services that have them tied already if the API supports it (i.e. API Gateway may have an ACL so .monitorAPIGateway() can automatically pull ACL metrics in?, or similar with CloudFront?)

We can take it step by step, e.g. start with something simple and keep extending it.
I have been researching some existing solutions and it seems that people are usually just monitoring allowed vs. blocked requests, typically for ALL rules in the given ACL.
So, what is the basic unit we are monitoring here... is it ACL + subset of rules? Or just list of rules and ACL separately?

Probably the latter as it seems from what I've seen that most ACLs will contain very very similar rules, we may also want to include count as well since that will tell the user if a request matched a rule but was not blocked (generally used for testing new rules?)

Basic support was added in #89. It'd be best to create a new issue detailing enhancements in more depth if desired.


Elements don't replace each other in place when dragged

When I try to use this library like in tutorial it doesn't work as in it.
<GridLayout :layout="cards" :col-num="4" :is-draggable="true" :is-resizable="false" :row-height="280" :margin="[12.5, 12.5]"         :use-css-transforms="true" :vertical-compact="true" ref="grid">         <GridItem v-for="card in cards" :key="card.id" :x="card.x" :y="card.y" :w="card.w" :h="card.h" :i="card.id">           <Card :data="card" :size="card.size"></Card>         </GridItem>       </GridLayout>
It just shows placeholder but doesn't move other cards. When I add move event handler it works but a bit weird. It can't replace some of cards and a big card of 3/4 of width can't take away 3 other little 1/4 width cards.
handleMove(id, newX, newY) {       sample.forEach(function (v) {         if (v.id === id) {           v.x = newX;           v.y = newY;           console.log(v.x + ':' + v.y)         }       })     }
I am using vue-grid-layout 2.1.13 and vue 2.5.2

Sorry, please submit a way to reproduce the problem, like a jsfiddle


Add support for LogisticRegression

Is your feature request related to a problem? Please describe.
Implements LogisticRegression for Logistic Regression (aka logit, MaxEnt) classifier：
API Like：https://scikit-learn.org/stable/modules/generated/sklearn.linear_model.LogisticRegression.html
the param i need：

penalty {‘l1’, ‘l2’, ‘elasticnet’, ‘none’}, default=’l2’

Specify the norm of the penalty:

C float, default=1.0

Inverse of regularization strength; must be a positive float. Like in support vector machines, smaller values specify stronger regularization.

class_weight dict or ‘balanced’, default=None

Weights associated with classes in the form {class_label: weight}. If not given, all classes are supposed to have weight one.

solver {‘newton-cg’, ‘lbfgs’, ‘liblinear’, ‘sag’, ‘saga’}, default=’lbfgs’

Algorithm to use in the optimization problem. Default is ‘lbfgs’. To choose a solver, you might want to consider the following aspects:
like:lbfgs, saga

multi_class {‘auto’, ‘ovr’, ‘multinomial’}, default=’auto’

If the option chosen is ‘ovr’, then a binary problem is fit for each label. For ‘multinomial’ the loss minimised is the multinomial loss fit across the entire probability distribution, even when the data is binary. ‘multinomial’ is unavailable when solver=’liblinear’. ‘auto’ selects ‘ovr’ if the data is binary, or if solver=’liblinear’, and otherwise selects ‘multinomial’.

l1_ratio float, default=None

The Elastic-Net mixing parameter, with 0 <= l1_ratio <= 1. Only used if penalty='elasticnet'. Setting l1_ratio=0 is equivalent to using penalty='l2', while setting l1_ratio=1 is equivalent to using penalty='l1'. For 0 < l1_ratio <1, the penalty is a combination of L1 and L2.

Perhaps not all solvers can be implemented as a distributed algorithm, do you need all solvers or just the one can work?

just lbfgs is ok， if saga can be implemented is better

class_weight and l1_ratio are not supported by now.
The other parts look good to work, we will try to implement the absent algo and optimize the performance.


daemon/graphdriver/overlay/ fix lint errors/warnings

Addresses #14756
Signed-off-by: Srini Brahmaroutu<EMAIL_ADDRESS>

Seems good once CI passes. No lint errors
Maybe verify if applyDiffProtoDriver and naiveDiffDriverWithApply should be exported since they are returned by exported functions.

Needs rebase.

@icecrime rebased.

@brahmaroutu needs another rebase :(

Done @tiborvass

Couple of comments. Also needs a rebase.

@cpuguy83 can you please review. I hope that I have addressed your comments.

LGTM although CI seems to be having some issues.

Just ran the tests myself and everything is working as expected.
LGTM. Merging!


[EMB-228] Dim dashboard projects on sort

Purpose
Any change to the dashboard filtering/sorting should cause a dim. This ensures that
Summary of Changes

Move the loading set out of the filtering wrapper and into the task that actually does the filtering.

Side Effects / Testing Notes
This should be all better for any similar cases.
Ticket
https://openscience.atlassian.net/browse/EMB-228
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
~[ ] testable and includes test(s)~
~[ ] changes described in CHANGELOG.md~

Coverage remained the same at 48.217% when pulling c3ed4b7b4e6301c282e05e330012ad6f070306db on brianjgeiger:feature/dashboard-dim-on-sort into 25ec78404ad2971908a4f98357095dc9c07df737 on CenterForOpenScience:develop.


semantic zoom event to trigger the "opening" of a node

Much like how when a shopper approaches the doors of a grocery store they automatically open, a given node should open (and load its relevant subgraph) when a user zooms in close enough to it.

Implemented by feature-infinity branch merge in July 2023


Add a message when text sets are empty

Feature Description
We should show a message or image to the user letting them know when there are no text sets. Currently the panel is empty when there are no text sets.
Alternatives Considered
none
Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

This would be good to get some input on from design.
@aaecheverria @tmagalhaes-huge @samitron7 could we request a mock for an empty state in text sets?

I think we can move forward with this relying on the 'empty' state of the media search.
So we can copy the same desert svg (that's in the design system already) and just say there's no text sets currently available. Something similar to the no search results on the dashboard.

Hi @samwhale - Read the qa instructions in 8825 and don't know how to edit that code directly. On thing I did notice is that I see the "no text available" state when I turn on "Match fonts from story" when there is no actual text in the story:

So I am seeing the new "no text sets" message, but am unsure if that satisfies testing here

Hi @samwhale - Read the qa instructions in 8825 and don't know how to edit that code directly. On thing I did notice is that I see the "no text available" state when I turn on "Match fonts from story" when there is no actual text in the story:
So I am seeing the new "no text sets" message, but am unsure if that satisfies testing here

This satisfies testing too and it's a way better way to test it. Nice find!

Hi @samwhale - Read the qa instructions in 8825 and don't know how to edit that code directly. On thing I did notice is that I see the "no text available" state when I turn on "Match fonts from story" when there is no actual text in the story:
So I am seeing the new "no text sets" message, but am unsure if that satisfies testing here

This satisfies testing too and it's a way better way to test it. Nice find @csossi!

@BrittanyIRL maybe we should change the message here when trying to match a font in the story and there's no text in the story?

maybe we should change the message here when trying to match a font in the story and there's no text in the story?

great idea! yes!

I'll fix that up real quick 👍

@csossi should see new text for the test case that you tested:

Verified in QA


EH is unresponsive

Seems to be spending a lot of time in issueMarkdown, I am only seeing this in the vscode repo. If I reload the window it works for awhile.
GitHub.vscode-pull-request-github-insiders-unresponsive.cpuprofile.txt

I think this happens every time I start typing an issue number in the scm input

issueMarkdown has gotten more expensive since I added link detection within the issue body text. This needs to move to resolveCompletionItem.


Add String methods

http://ruby-doc.org/core-2.2.0/String.html

String will be defined with a fixed encoding of UTF-8, and in terms of elements not codepoints.
Using codepoints for various operations is significantly more complex, and due to combining marks attempting to splice at random points is not correct even for codepoints.


release v1.0.0

this 0.0.x versioning if very annoying to deal with :)

I'm not very familiar with NPM. Should I just set the version to 1.0.0 and then push to NPM?

Yes. Read up on semver!


Uncaught (in promise) TypeError: .__wbindgen_add_to_stack_pointer is not a function

Summary
Hello, I wasn't sure if my issue was a bug or a misusage (i.e. question) so I just chose question!
I am in the process of building a very barebones lexer/parser for a custom file type in rust, and I want to load it into my react/electron app. It seems like I can almost load it, but I'm throwing a weird type error when attempting to call the function.
Additional Details
I'll paste my logs below:
printing of the loaded module (console.log(wasm))
Module {__esModule: true, Symbol(Symbol.toStringTag): "Module"}
parse_ias: (...)
Symbol(Symbol.toStringTag): "Module"
__esModule: true
get parse_ias: ƒ ()
__proto__: Object

printing of the type of loaded module function (console.log(typeof wasm.parse_ias))
typeof wasm.parse_ias: function

error from console after calling function
Uncaught (in promise) TypeError:
_ias_parser_bg_wasm__WEBPACK_IMPORTED_MODULE_0__.__wbindgen_add_to_stack_pointer is not a function
    at Module.parse_ias (ias_parser_bg.js?010e:99)
    at eval (NewSessionModal.tsx?aa6d:47)
    at step (NewSessionModal.tsx:52)
    at Object.eval (NewSessionModal.tsx:33)
    at eval (NewSessionModal.tsx:27)
    at new Promise (<anonymous>)
    at __awaiter (NewSessionModal.tsx:23)
    at test (NewSessionModal.tsx?aa6d:43)
    at HTMLUnknownElement.callCallback (/Users/aaronleopold/Documents/museum/imageant_alternative/node_modules/react-dom/cjs/react-dom.development.js:188)
    at Object.invokeGuardedCallbackDev (/Users/aaronleopold/Documents/museum/imageant_alternative/node_modules/react-dom/cjs/react-dom.development.js:237)

ias_parser_bg.js --> auto gen file
/**
* @param {string} ias_file
* @returns {string}
*/
export function parse_ias(ias_file) {
    try {
        const retptr = wasm.__wbindgen_add_to_stack_pointer(-16);
        var ptr0 = passStringToWasm0(ias_file, wasm.__wbindgen_malloc, wasm.__wbindgen_realloc);
        var len0 = WASM_VECTOR_LEN;
        wasm.parse_ias(retptr, ptr0, len0);
        var r0 = getInt32Memory0()[retptr / 4 + 0];
        var r1 = getInt32Memory0()[retptr / 4 + 1];
        return getStringFromWasm0(r0, r1);
    } finally {
        wasm.__wbindgen_add_to_stack_pointer(16); -----> ERROR HERE
        wasm.__wbindgen_free(r0, r1);
    }
}

lib.rs
mod util;
use wasm_bindgen::prelude::*;

pub mod parser;
pub mod lexer;
pub mod token;
pub mod task;

use parser::Parser;
use serde_json::{Result, json};

// When the `wee_alloc` feature is enabled, use `wee_alloc` as the global
// allocator.
#[cfg(feature = "wee_alloc")]
#[global_allocator]
static ALLOC: wee_alloc::WeeAlloc = wee_alloc::WeeAlloc::INIT;

#[wasm_bindgen]
pub fn parse_ias(ias_file: &str) -> String {
  let mut parser = Parser::new(ias_file.to_string());
  let ias = parser.parse_source();

  let j_obj = serde_json::to_string(&ias);

    if j_obj.is_err() {
        panic!("TODO: handle me");
    }

    j_obj.unwrap()
}

Wrap up
Sorry wall of text! I wasn't sure how thorough to be. I can post a link to the repo if needed, as well

Unfortunately I'm not entirely sure what might be causing this. It may be something in the packaging pipeline like webpack causing issues, but it could also be something like a mismatch in wasm-bindgen crate/cli version, or just a bug in wasm-bindgen itself.
If you could reduce this to only using wasm-bindgen I could try to help and investigate.

Of course, thanks for responding! I isolated my rust lib into the add example and got a different error (however the example add left as is worked) so I imagine I am just using wasm wrong?
Could it be because I have split up my library across multiple files? i.e. defining my Token struct in token.rs, my Parser in parser.rs? I figured adding the bindgen directive to the function in lib.rs would have been sufficient enough? This is the error putting my lib in the add example:
RuntimeError: unreachable
    at http://localhost:8080/62b1d741b9dc0de3024b.module.wasm:wasm-function[393]:0x7a4b7
    at http://localhost:8080/62b1d741b9dc0de3024b.module.wasm:wasm-function[571]:0x7f720
    at http://localhost:8080/62b1d741b9dc0de3024b.module.wasm:wasm-function[604]:0x7fda6
    at http://localhost:8080/62b1d741b9dc0de3024b.module.wasm:wasm-function[459]:0x7ced8
    at http://localhost:8080/62b1d741b9dc0de3024b.module.wasm:wasm-function[291]:0x73b13
    at f (http://localhost:8080/62b1d741b9dc0de3024b.module.wasm:wasm-function[194]:0x6a359)
    at Module.w (http://localhost:8080/2.index.js:1:1168)
    at http://localhost:8080/index.js:1:155550

Its not a finished lib yet but I went ahead and uploaded this to a separate repo if that helps at all: https://github.com/aaronleopold/ias_parser

Okay, so I added console_error_panic_hook after searching a little more through other issues on here, and see that rust panicked:
2.index.js:1 panicked at 'Something went wrong reading the .ias file: Custom { kind: Other, error: "operation not supported on wasm yet" }'

corresponding to this line:
let file_contents = fs::read_to_string(ias_file)
    .expect("Something went wrong reading the .ias file");

So I guess this relates to https://github.com/rustwasm/wasm-bindgen/issues/1727

So it was definitely a webpack issue, specifically I think electron-webpack. I switched away from electron-webpack and moved to a typical webpack config and it seems to loading okay now. I'll go ahead and close this issue


Support for Docking

Imgui has a docking branch and it's great (link). I think it opens up many more applications for the library such as an editor for a small engine or a full desktop app. This is the only reason that I stil use imgui-rs for my project and I'd love to make the switch.

I'd really get behind this!

https://github.com/emilk/egui/discussions/424
relevant discussion

This looks excellent -> https://github.com/lain-dono/egui_docking

Wow, that does look neat @cirrusone !

With the author's consent I forked egui_docking, added some documentation, and published it on crates.io. https://crates.io/crates/egui_dock
I encountered a few bugs which I'm going to work on when I find time. I'll also appreciate all contributions.

With the author's consent I forked egui_docking, added some documentation, and published it on crates.io. https://crates.io/crates/egui_dock
I encountered a few bugs which I'm going to work on when I find time. I'll also appreciate all contributions.

it would be nice to add padding in tab body but it's not possible to create issues on fork

@boonkerz I just enabled issues, thanks for spotting that. Feel free to open one for this.

There are two good libraries for docking within a single egui viewport:

https://github.com/Adanos020/egui_dock
https://github.com/rerun-io/egui_tiles

For proper support of docking using multiple viewports (e.g. like how tabs in a browser can be detached into its own window, then dragged back in again), I've created this issue:

https://github.com/rerun-io/egui_tiles/issues/30


Move (most of) Travis to Ubuntu Bionic, and add Clang 9

As mentioned in #495, Travis CI made Ubuntu Xenial a default some time ago. While updating our config, it occurred to me that we can upgrade straight to the most recent LTS release, Ubuntu Bionic, so I did that. The only job that's left on Xenial is GCC 4.9 builds, because Bionic doesn't ship this version of GCC.
I also added Clang 9. Figured I'd make it part of this PR, because it's not too big of a change.
This fixes #495 and #648. Will merge in three days unless someone—anyone—will stop me for a review.

Coverage increased (+0.1%) to 40.343% when pulling 0e1a1478606cf0a05acba3166d5c137d0b996039 on feature/495-travis-ci-xenial into 1d685e2927c7cf10ff1b578ebb5b13f809bc860b on master.

Coverage increased (+0.1%) to 40.343% when pulling 0e1a1478606cf0a05acba3166d5c137d0b996039 on feature/495-travis-ci-xenial into 1d685e2927c7cf10ff1b578ebb5b13f809bc860b on master.


Kubernetes services not being created in DB after network-services upgrade

Rancher Versions:
Server:v1.4.1
**Docker Version:**1.12.6
**OS and where are the hosts located? (cloud, bare metal, etc):**Ubuntu, Cloud
**Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)**Single node
**Environment Type: (Cattle/Kubernetes/Swarm/Mesos)**Kubernetes
Steps to Reproduce:

Create pods/ingresses/lbs on a v1.4.1  Kubernetes setup. Ensure they are functional
Point the library catalog to  https://github.com/rancher/rancher-catalog, v1.4.3-updates branch
Upgrade IPsec and then Network services stack
After network services stack is upgraded, create new pods and ingress.
Pod creation is successful. But ingress is not programmed correctly and is not functional. The haproxy.cfg file does not show the targets programmed for the ingress LB.

Ingress controller logs below:

4/11/2017 2:22:15 PMtime="2017-04-11T21:22:15Z" level=error msg="Failed to apply lb config on provider: Failed to find service [319b0663-1eeb-11e7-bbf7-02d2df5c13ed] in Rancher"
4/11/2017 2:22:15 PMtime="2017-04-11T21:22:15Z" level=error msg="Failed to apply lb config on provider: Failed to find service [319b0663-1eeb-11e7-bbf7-02d2df5c13ed] in Rancher"
4/11/2017 2:22:15 PMtime="2017-04-11T21:22:15Z" level=error msg="Failed to apply lb config on provider: Failed to find service [d5470a68-1ef4-11e7-bbf7-02d2df5c13ed] in Rancher"

The root cause of the ingress not working is the kubernetes services being created were not being added to the service table in the DB as there was an issue in the kubernetes-agent. After restarting the agent, services were being inserted in to the DB correctly.

Rancher server 1.6.2 to 1.6.3-rc7
Setup: HA setup with 3 rancher server nodes
I am seeing the same issue after upgrading network-services stack to newer version after upgrading rancher server, kubernetes-agent doesn't populate the services created in rancher DB.


Terraform apply fails - IAM permissions not checked before creating gemini model

│ Error running command 'poetry run bq query --use_legacy_sql=false --max_rows=100 --maximum_bytes_billed=10000000 < ../../sql/query/create_gemini_model.sql
Waiting on bqjob_r33a79743008e71dc_00000192bae30f5d_1 ... (0s) Current status: RUNNING
│ Waiting on bqjob_r33a79743008e71dc_00000192bae30f5d_1 ... (0s) Current status: DONE
│ Error in query string: Error processing job 'marketing-data-engine-
│ demo:bqjob_r33a79743008e71dc_00000192bae30f5d_1': bqcx-216235317801-s3pp@gcp-sa-
│ bigquery-condel.iam.gserviceaccount.com does not have the permission to access
│ or use the endpoint. Please grant the Vertex AI user role to the service account
│ following https://cloud.google.com/bigquery/docs/generate-text-tutorial#grant-
│ permissions. If issue persists, contact<EMAIL_ADDRESS>for help.
│ Failure details:
│ - query: bqcx-216235317801-s3pp@gcp-sa-bigquery-
│ condel.iam.gserviceaccount.com does not have the permission to
│ access or use the endpoint. Please grant the Vertex AI user role to
│ the service account following
│ https://cloud.google.com/bigquery/docs/generate-text-
│ tutorial#grant-permissions. If issue persists, contact bqml-
│<EMAIL_ADDRESS>for help.
│
╵
Workaround: Run terraform .. apply again.

Maintaining roles assigned to service Agents. E.g. preserving roles assigned to<EMAIL_ADDRESS>in the event of redeploy of Vertex AI Connection.
Integrate deployment of the service account and service agent roles in the Terraform installation

Solved!


Remove requirement for empty new-line on key inputs

Issue
Currently when inputting private keys to the app, it requires there to be a new (empty line) prior to progressing in the user journey.
Potential solution
Remove the requirement for a new (empty) line and process each input on text-changes. Additionally, we should consider accepting alternative key types (seed phrase, wallet connect like APIs, etc.) but that is beyond the scope of this issue & will be raised/addressed separately.
Questions
n/a

Adding some screen shots illustrating proposed UI changes

Pasting into the input box or the paste button (on the right) provides feedback on the type of key (and if successful)

Recognizes ecdsasecp and ed25519

And provides reasons why it didn't recognize the key:

the list looks similar to before, but is explicit about key types:


Raise timeout and client error exceptions

I think we should raise the timeout and client error expectations here to be captured in the android_ip_webcam integration. This allows us to specify the kind of error (whether is it timeout or invalid credentials).

Yes. Probably set raise_for_status and then raise library specific exceptions from the aiohttp exceptions.


Crunchyroll KeyError: u'url'

[x] I've verified and I assure that I'm running youtube-dl 2016.03.27

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
youtube-dl.exe "http://www.crunchyroll.com/myriad-colors-phantom-world/episode-13-the-eternal-phantom-world-691713" -u user -p password --write-sub --sub-lang enUS -v
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'http://www.crunchyroll.com/myriad-colors-phantom-world/episode-13-the-eternal-phantom-world-691713', u'-u', u'PRIVATE', u'-p', u'PRIVATE', u'--write-sub', u'--sub-lang', u'enUS', u'-v']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2016.03.27
[debug] Python version 2.7.10 - Windows-8-6.2.9200
[debug] exe versions: ffmpeg N-76479-gc878082, ffprobe N-76479-gc878082, rtmpdump 2.4
[debug] Proxy map: {}
[Crunchyroll] Logging in
[Crunchyroll] 691713: Downloading webpage
[Crunchyroll] 691713: Downloading media info
[Crunchyroll] 691713: Downloading media info for 360p
[Crunchyroll] 691713: Downloading media info for 480p
[Crunchyroll] 691713: Downloading media info for 720p
[Crunchyroll] 691713: Downloading media info for 1080p
[Crunchyroll] 691713: Downloading subtitles for English (US)
[Crunchyroll] 691713: Downloading subtitles for Español
[Crunchyroll] 691713: Downloading subtitles for Español (España)
[Crunchyroll] 691713: Downloading subtitles for Français (France)
[Crunchyroll] 691713: Downloading subtitles for Português (Brasil)
[Crunchyroll] 691713: Downloading subtitles for ???????
[Crunchyroll] 691713: Downloading subtitles for Italiano
Traceback (most recent call last):
  File "__main__.py", line 19, in <module>
  File "youtube_dl\__init__.pyo", line 419, in main
  File "youtube_dl\__init__.pyo", line 409, in _real_main
  File "youtube_dl\YoutubeDL.pyo", line 1724, in download
  File "youtube_dl\YoutubeDL.pyo", line 680, in extract_info
  File "youtube_dl\YoutubeDL.pyo", line 725, in process_ie_result
  File "youtube_dl\YoutubeDL.pyo", line 1268, in process_video_result
KeyError: u'url'

Description of your issue, suggested solution and other information
Above error occurs in version 2016.03.27 when trying to download ANY video on Crunchyroll (at least with the 5 or so I tested), not only the one example I have provided.
Please note that downloading works fine in version 2016.03.18, which is the one I had before I updated today. So this bug seems to have been introduced at some point between the 18th and the 27th.

This issue is already fixed and fix will be incorporated in the next version of youtube-dl.


Fixes and Adds Item on Npc

Fixes the packet size issue
Adds Item on Npc message and decoder
#304 Issue

LGTM besides the 2 comments.

Actually, also, which packet sizes does your first commit fix?

@garyttierney  57

@garyttierney @ryleykimmel
Added another quick fix to the source. Can this be accepted yet?

@Lmctruck30 I made one more comment on the ReportAbuseMessage class https://github.com/apollo-rsps/apollo/pull/306/files/d95e8931f62bdeca5c889fc99fc2c4e0788a1a12#diff-ad489f93dbc2cdf2490e0dc79f686ab1

Also if you don't mind can you make your documentation more consistent?

@garyttierney @ryleykimmel All changes have been made and those fields have already been turned into final in the previous commit.

@Lmctruck30 @ryleykimmel Few nitpicks, but nothing I can't fix before squashing and merging.  LGTM.  One thing I want to check before merging this is this: are rule ID's very much just static identifiers, or do we need to map them to something with better semantics?
Should a plugin listen on events for "rule_id == 5", and have its own definitions for rules, or should a plugin listen on events for "rule_id == ReportAbuseRule.INAPPROPRIATE_MESSAGE" ?

@garyttierney best information on this would be to log the report with chat history, pm history, trade/duel/attack/action history.

Dealt with the comments, thanks for the original PR!


Add Preset for historic=millstone

OSM Tag(s)
historic=millstone
How would you like this tag to see supported?
As a Preset
Label
Millstone
Aliases
mill stone, mill-stone
Terms
grindstone, quernstone, quern-stone, quern, grinding stone, grinding wheel, mill wheel
Link to OSM Wiki page
https://wiki.openstreetmap.org/wiki/Tag:historic=millstone
Status of the Tag
Approved
Usage of the tag
55
Replaces other Tag?
No response
Regional Tag?
global
Further Information
No response

Usage is currently still pretty low with less than 100 occurrences in OSM. But given that these features are probably relatively rare in general, and are typically quite significant local landmarks, I'd say a preset for these should be added.
As a first step, I have now added an translatable option to select the value millstone  in the Type field of the generic Historic Site preset.

can I start working on this issue?

surely, go ahead @anmolchhabra21


[Feature Request] Keep the same pages pins

i would like to be able to always keep the original page that i pin so when i use the pins no matter what the page is gonna be the same so exemple i put https://www.youtube.com/ and i  go on a video i don't want the video to be the pin i want the original https://www.youtube.com/

Hey, unfortunately this is not possible with only css due to its limitation. There's still hope though, it seems that someone created a pull request to integrate this functionality in the browser itself ( https://github.com/zen-browser/desktop/pull/1848 ) We can only hope that this gets merged or implemented in a similar way


Force should not remove PRs from the queue

Currently, when someone uses @homu: force, it forcibly cancels the previous PR which gets marked as a failure (with a "test failed" message that can be confusing).
Could it instead be kept in the queue, with a more gentle message? "Another pull request was forced into the queue [link to PR]" or something.
(We'd discussed this in IRC, but I'll end up forgetting thus this issue)

Yesssssssssssss


[spring-cloud-kubernetes-configuration-watcher] Shared ConfigMap refresh

Is your feature request related to a problem? Please describe.
Refresh all SpringBoot applications reading a shared ConfigMap.
Describe the solution you'd like
My requirement is to have a shared ConfigMap. All SpringBoot applications read it.
When this ConfigMap gets updated then spring-cloud-kubernetes-configuration-watcher would refresh all SpringBoot applications using it.

I think this is similar to https://github.com/spring-cloud/spring-cloud-kubernetes/issues/740
We need a way for an app to say its interested in being notified of changes in configmaps/secrets other than the one that match its name.


Improvements organization user quota slider UI

Avoid calculations in the views using model attributes. Instead add methods to the own model to return them directly to the view. (See feature envy)
Return flash message if the user sends the form with an invalid value in the quota input.

cc @viddo @xavijam

:+1:


feat: implement ingest v2

Checklist

[x] make test passes
[x] tests and/or benchmarks are included
[x] documentation is changed or added
[x] commit message follows commit guidelines

Affected core subsystem(s)
Ingest
Description of change
This PR implements v2 of the Ingest API, supporting more extensive ingest (upsert and delete), both as single records and as a stream.
Multiple functions are added to the SDK, available in the ingest.V2Client

IngestRecord - to ingest a single record
StreamRecords - a helper function that takes a list of records, streams them to the API, and closes the stream

If you want to manage iteration of the records and/or manage the stream yourself, you can use the following functions

OpenStreamClient - opens the stream to the API
`SendRecord - sends a record on the stream
ReceiveResponse - reads a response from the stream
CloseStream - closes the stream

Have we not already reviewed this? 😅

Not the SDK side @bakkelim 🤔

Not the SDK side @bakkelim 🤔

Jeebus 🙈

I personally prefer to keep test code separated, I would have prefer to have NewTestClient in test files but I saw we did the same with consent


Create a filter and update signature in gmail

Description
Create a filter & returns Draft object, including filter id.
Create and update signature in gmail & returns Draft object, including updated signature.
Fixes # (210008391)
Has it been tested?

[X] Development testing done
[ ] Unit or integration test implemented

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have performed a peer-reviewed with team member(s)
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] Any dependent changes have been merged and published in downstream modules

create_filter and update_signature are the file to review


Introduce more helper methods in gprpp/atomic.h

Retire the old atomic_with_atm.h and atomic_with_std.h as they are not
needed anymore.
Introduce helper methods which call GPR_ATM_INC_ADD_THEN and
GPR_ATM_INC_CAS_THEN, and use them everywhere.
Also introduce AtomicIncrementIfNonzero, originally authored by
<EMAIL_ADDRESS>This is going to be used for completion queues.

Thank you for the review @markdroth !

Thank you @markdroth !

Thank you @vjpai ! Yes, I agree that it would leak std:: enums everywhere.
So, I ended up adding an enum class aliasing the enum values for memory order. This forces not using std:: :P
Could you and @markdroth  please take another look?

Thank you @markdroth !

Thank you both!


Update description of OpenSTValue.stake to reflect changes in 0.9.3

The @dev documentation comment for OpenSTValue.stake currently states: "In order to stake the tx.origin needs to set an allowance for the OpenSTValue contract to transfer to itself to hold during the staking process."
This is inaccurate as of 0.9.3 and should be updated to reflect that the utility token's staking account (the respective Gateway, in practice) is what is needs to set an allowance.
This is a hotfix that should be completed on the release branch.

@jasonklein what is the status of this? I assume it was closed in #234.


Prevent console errors when clicking to change page while in Presentation Mode (issue 8498)

The click handler used in Presentation Mode didn't check if the first/last page was already reached, which after PR #7529 now causes an unnecessary console error.
Hence we should simply use the already existing _goToPreviousPage/_goToNextPage methods instead, since they do the necessary bounds checking.
Fixes #8498.

/botio-linux preview

Looks good. Thank you!