Gateway timeout with long running API call

What happened?
In "Request" kind, if the API call takes longer than 4 min, HTTP provider returns timeout error (504 Gateway Error) and calls the same API again. The same call in "DisposableRequest" completes successfully.
How can we reproduce it?
To call long running API using "Request" kind. (see below snippet)
- name: test
  base:
    apiVersion: http.crossplane.io/v1alpha2
    kind: Request
    spec:
      deletionPolicy: Orphan
      forProvider:
        headers:
          Content-Type:
            - "application/json"
          Accept:
            - "application/json"

        waitTimeout: 10m
        payload:
          baseUrl: https://some-long-running-API
          body: |
            {
              "serviceParameters":
                {
                  "key": "value"
                }
              }
        mappings:
          - method: "POST"
            url: .payload.baseUrl
            body: |
              {
                "serviceParameters": .payload.body.serviceParameters
              }

With debug mode enabled, HTTP provider returns following error message after 4 min.
2024-07-22T13:13:09Z    DEBUG   provider-http   Cannot create external resource {"controller": "managed/request.http.crossplane.io", "request": "/jbapp1-qwzbj-pvj29", "uid": "dfa2877c-56bb-4542-8e89-fddbaf4aa266", "version": "4297455", "external-name": "", "error": "something went wrong: HTTP POST request failed with status code: 504", "errorVerbose": "HTTP POST request failed with status code: 504\ngithub.com/crossplane-contrib/provider-http/internal/controller/request/statushandler.(*requestStatusHandler).incrementFailuresAndReturn\n\tgithub.com/crossplane-contrib/provider-http/internal/controller/request/statushandler/status.go:83\ngithub.com/crossplane-contrib/provider-http/internal/controller/request/statushandler.(*requestStatusHandler).SetRequestStatus\n\tgithub.com/crossplane-contrib/provider-http/internal/controller/request/statushandler/status.go:54\ngithub.com/crossplane-contrib/provider-http/internal/controller/request.(*external).deployAction\n\tgithub.com/crossplane-contrib/provider-http/internal/controller/request/request.go:205\ngithub.com/crossplane-contrib/provider-http/internal/controller/request.(*external).Create\n\tgithub.com/crossplane-contrib/provider-http/internal/controller/request/request.go:214\ngithub.com/crossplane/crossplane-runtime/pkg/reconciler/managed.(*Reconciler).Reconcile\n\tgithub.com/crossplane/crossplane-runtime@v0.20.0-rc.0.0.20230413174155-c8cff1a7fb74/pkg/reconciler/managed/reconciler.go:959\ngithub.com/crossplane/crossplane-runtime/pkg/ratelimiter.(*Reconciler).Reconcile\n\tgithub.com/crossplane/crossplane-runtime@v0.20.0-rc.0.0.20230413174155-c8cff1a7fb74/pkg/ratelimiter/reconciler.go:54\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\tsigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:122\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:323\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:235\nruntime.goexit\n\truntime/asm_amd64.s:1598\nsomething went wrong\ngithub.com/crossplane-contrib/provider-http/internal/controller/request.(*external).Create\n\tgithub.com/crossplane-contrib/provider-http/internal/controller/request/request.go:214\ngithub.com/crossplane/crossplane-runtime/pkg/reconciler/managed.(*Reconciler).Reconcile\n\tgithub.com/crossplane/crossplane-runtime@v0.20.0-rc.0.0.20230413174155-c8cff1a7fb74/pkg/reconciler/managed/reconciler.go:959\ngithub.com/crossplane/crossplane-runtime/pkg/ratelimiter.(*Reconciler).Reconcile\n\tgithub.com/crossplane/crossplane-runtime@v0.20.0-rc.0.0.20230413174155-c8cff1a7fb74/pkg/ratelimiter/reconciler.go:54\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\tsigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:122\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:323\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:235\nruntime.goexit\n\truntime/asm_amd64.s:1598"}
2024-07-22T13:13:09Z    DEBUG   events  something went wrong: HTTP POST request failed with status code: 504    {"type": "Warning", "object": {"kind":"Request","name":"jbapp1-qwzbj-pvj29","uid":"dfa2877c-56bb-4542-8e89-fddbaf4aa266","apiVersion":"http.crossplane.io/v1alpha2","resourceVersion":"4298039"}, "reason": "CannotCreateExternalResource"}
What environment did it happen in?
Crossplane version:
Client Version: v1.16.0
Server Version: v1.14.5-up.1
Kubernetes version:
Client Version: v1.29.1
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.27.3
Kubernetes distribution: kind
OS: Ubuntu 22.04.3 LTS
Kernel:
Linux ip-10-251-8-27 6.5.0-1022-aws #22~22.04.1-Ubuntu SMP Fri Jun 14 16:31:00 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Hi there,
It appears that the issue is not within the provider itself but rather related to the specific API call timing out. Since the same call completes successfully when using the DisposableRequest kind, the issue might be with the configuration or request body in the Request kind.
I recommend the following:
1.	Review Request Body:

The request body in the provided YAML snippet seems correct. However, the mappings body should be a jq string, not JSON. It should be updated as follows:

mappings:
  - method: "POST"
    url: .payload.baseUrl
    body: |
      {
        serviceParameters: .payload.body.serviceParameters
      }

Check Request Status:
Review the status of the Request resource to see the exact request sent. This will help identify any issues with the request body or headers.

By making these adjustments, you should be able to resolve the issue.

Thanks for the reply.
Using jq string didn't change the result.
The sent body looks fine on the target API server and the request completes successfully and returns 200 (around 5 min).
But HTTP provider gets 504 before the API calls finish (after 4 min).

Hi,
If the request body looks good and there is a response from the server, it confirms that the request was sent successfully, so there is no issue with the provider itself.
The 504 Gateway Timeout error suggests that the API call did finish. The provider only returns what it gets from the server, so your server returned this.
Please take a look at the status of the Request resource to further investigate the problem. It should contain the request details and the response from the server. If you need help understanding the status, don’t hesitate to ask.

Hi, indeed HTTP request seems to return 504, while Azure function behind kept running and completed the job. That's why I didn't see any error message on the API server side. Thank you very much for your support.
One more question: Is it possible to stop the repeating API call when the first call gets failed?

Happy to hear it worked for you!
Defining what constitutes a failure can be quite challenging since a failure could be, for example, a 404 response before the POST even happens. The Request resource is designed to provision resources, so stopping operations on a failure could disrupt its intended behavior in many cases.
Perhaps adding a configurable “failure” indicator in future updates could help address this. For now, stopping API calls is only possible with the DisposableRequest resource.


Imphash differs from standardized imphash for PE binaries with delayed imports

Currently, we calculate imphash also from delayed imports, but if we want to use our imphashes fro example in YARA, or any other place which use standardized imphash, we should not consider delayed imports into imphash.
I propose keeping delayed imports in import table as we do now, but without them being taken into account when calculating imphash. This will probably require some flag to be added for each import (It doesn't necessarily need to be flag called delayed but rather something in terms of excludeFromImphash).

Fixed in 7523e073b1d05213810a0493de579df31480c2d4 and 582f8cc0be91dd1491a19e58a54037a75cefc9e8


publish core support

Description:
Add support to publish core.
You can publish core locally via command: ./gradlew :core:publishToMavenLocal to include in your project for local testing
Type
Builds

Hi @Andati is this ready for review? thanks!

@jingtang10 I see that the master has changed, let me update the pr first


removing leading slashes for paths from requests

cma-sdk is using retrofit 2 and sending requests with leading slashes ("/") and as mentioned in retrofits documentation (https://square.github.io/retrofit/2.x/retrofit/retrofit2/Retrofit.Builder.html#baseUrl-okhttp3.HttpUrl-) if endpoint have leading slash it ignores the path of base url. and it causes the bugs if base url have path at url. there is a PR about that issue. can you review it

Thanks! Released in v.3.4.7


Other di containers

Hey Guys,
We're attempting to use this in a .net framework application that uses autofac.  While attempting to register the various dependencies:

ConfigurationFeatureDefinitionProvider
FeatureManager
EmptySessionManager
FeatureManagerSnapshot

I've discovered that they are all sealed, is there any guidance or is it even possible to use this without resorting to reflection hacks?

... or any other number of containers, Simple Injector etc, These classes are the public interface into feature flags they shouldn't be internal, we need to instantiate them to use this.

We're having this problem also.  It would be great to see some guidance of how to use the FeatureManager with other IoC containers.

Update:
The PR #302 of exposing FeatureManager to public has been merged into main branch. Now the FeatureManagement should be compatible with other DI framework.

Fixed in release 3.1.0

Fixed in release 3.1.0

I created a repo to demonstrate how to use Microsoft.FeatureManagement in third-party Di containers: https://github.com/zhiyuanliang-ms/FeatureManagement-Dotnet-DependencyInjection
:)


Make user and client keys endpoints pass Pedant specs

Depends on chef/chef#4587 and chef/chef-server#740.

Implement ActorKeyEndpoint, ActorDefaultKeyEndpoint, ActorKeysEndpoint.

Implement user, client keys in ActorEndpoint#delete, #put.

RestBase

Fix RestErrorResponse exceptions to report actual rest_path
instead associated with the failed data store operation instead of
request.rest_path.
Move json_response, already_json_response args request_version
and response_version into options hash; add docs.

DataError, RestErrorResponse: Pass useful message text to super.

RestRouter: Clean up logging

Print request methods, paths and bodies more readably for log_level >= INFO.
Pretty-print RestRequest objects (only printed when log_level == DEBUG).

Server: Change default log_level to :warn (to enable logging cleanup above).

Rakefile, spec/run_oc_pedant.rb

Consume RSpec, Pedant options from ENV['RSPEC_OPTS'], ENV['PEDANT_OPTS'] (see rake -D).
Consume ENV['LOG_LEVEL' (see rake -D).
Clean up ChefZero::Server default opts and move duplicated logic to start_chef_server method.

There were two things I didn't understand. Also, I'm assuming we need to merge the chef change to make travis happy. Everything else is :+1: Really like the logging and test running improvements.

@chef/client-dev-tools can I get another review on this?

:+1:, this has a lot of great simplification too! Awesome job.


Remove organization_name from base URL

Resolves #4240
Description
Now that roles are implemented, the URLs don’t need to be prepended with organization_name anymore. The role determines the organization that a user can access.
The main things I changed are:

In ApplicationController, the organization_url_options and default_url_options are removed since we don’t need to append the organization_name param anymore
Routes have been updated in routes.rb, view files and test files to no longer use organization_name

Discussion
One thing remains up for discussion at this point: what behavior should be allowed for super admins?
My understanding of the current behavior is: super admins can access routes that are outside of the /admin namespace. This is done by prepending the URL with the organization_name. There is no way for a super admin to switch roles.
In this PR since the organization_name is removed from the URL, the super admins won’t be able to access routes outside of the /admin namespace unless the organization_name param is added to the URL. I removed a couple of links that would bring a super admin in the /admin namespace to a place outside of it (see example of such link in screenshot below).

Until a PR exists for #4293, super admins won’t be able to access routes outside of /admins. If this is not okay I can find a way to automatically append the organization_name param to any request made by a user with super admin role.
Type of change

New feature (non-breaking change which adds functionality) -> for users that are not super admins
Breaking change (fix or feature that would cause existing functionality to not work as expected) -> super admins won’t be able to access routes outside of the /admin namespace (see Discussion section)

How Has This Been Tested?
Tests files have been updated to not use the organization_name param. I ran the test suite locally every so often to ensure changes were having the intended effect.
I also addressed some flakiness I was encountering in the audit system tests by implementing the fix described in PR #4248. I’m aware that this is not an ideal solution but it helps for now.

@jp524 this is an enormous PR which I can't possibly look through all at once. Can this be split up into logical pieces?
I think your comment is correct though - this is likely blocked on #4293 .


[RFC][WIP] Make DEVICE init and device_get dt aware

This is prototype based on conversations at ELC-E 2019 on how we can make the device api be dt aware.
The idea here is that we'd use a unique identifier (Zephyr Device ID/ZDID) for each device tree node that would correspond to how we name the struct device for that device.  We can then generate various DT defines like DT_INST_0_SILABS_GECKO_I2C_ZDID.  These defines allow us to construct direct access to the struct device.  This PR show changes to the silabs i2c gecko driver and a hacked up change to the i2c_scanner to show but the changes on the driver side (how a DEVICE_AND_API_INIT_DT would look like, and how device_get_dt_binding would work.
There's at least one issue that needs to be figured out on how / where to do an extern struct device __device_<ZDID>.

Benefits of this approach:

ability to remove the 'label' property from DT nodes [ been a long term goal]
ability to remove the device name and thus string storage
code and perf improvement for device_get_dt_* -- its just a pointer dereference now!

ability to remove the 'label' property from DT nodes [ been a long term goal]

I'm still not convinced this is something desirable.
Or at least I think information held in 'label' is a valid an pertinent information.
Referencing to instance, ie index of the enabled peripheral is actually random from board configuration point of view, and so referencing to instance from application perspective is misleading. Besides, it means nothing neither from SoC documents point of view, (ref mans and so on).
If label is removed, we need to be able to get access from the code to device node name, which hold same information.

I'm still not convinced this is something desirable.
Or at least I think information held in 'label' is a valid an pertinent information.
Referencing to instance, ie index of the enabled peripheral is actually random from board configuration point of view, and so referencing to instance from application perspective is misleading. Besides, it means nothing neither from SoC documents point of view, (ref mans and so on).
If label is removed, we need to be able to get access from the code to device node name, which hold same information.

The application can reference via instance, alias, path.  I just did it via instance in here.
so we can have:
device_get_dt_by_path(SOC_I2C_4000C400)
device_get_dt_by_alias(I2C_0)
etc.

The application can reference via instance, alias, path. I just did it via instance in here.
so we can have:
device_get_dt_by_path(SOC_I2C_4000C400) [maps to /soc/i2c@4000C400]
device_get_dt_by_alias(I2C_0)
etc.

Seems pretty neat.
Guess the aliases generated by out_dev() are needed in that case. Would expand to a different *_ZDID alias depending on how you look it up, and then that gets resolved to the right device struct.
Still wonder if there's a nicer name than ZDID. Could make it *__ZDID (or just *__ID) maybe, corresponding to _id = ..., though it might be overkill.

The application can reference via instance, alias, path. I just did it via instance in here:

device_get_dt_by_path(SOC_I2C_4000C400) [maps to /soc/i2c@4000C400]

I don't think this scales, peripheral address is not used in ref manuals (it is not even available) nor available on most of board documentation. User have to go and check:

CMSIS file (in which it is not even directly available #define GPIOH_BASE            (AHB1PERIPH_BASE + 0x1C00UL)).
.dtsi (which are split in multiple files, so need to parse several files)

device_get_dt_by_alias(I2C_0)

So we need to define an alias for each peripheral instance... Not sure this scales either.
Anyway we can use node name (ie phandle)?

Anyway we can use node name (ie phandle)?

The vision for this that I discussed with Kumar was that "it's just a pointer dereference!" makes phandles "just work": from prop = <&gpioM ...> you can translate the &gpioM phandle to &__device_N in the generated header "right away", since the script knows the ID number for the node pointed to by the phandle.

Anyway we can use node name (ie phandle)?

The node name isn't the phandle, which isn't text; the generic syntax is:
    [label:] node-name[@unit-address] {
      [phandle = <*int32*>;]
      ...
   }

The label is what's used as the reference in things like <&gpiof 1 0>, and it evaluates (in blob representations) to the integer that is the (usually implicit) phandle property.  The node-name need only be unique within its parent, so it's not a good choice.
Nomenclature nit-picking aside, I agree that device_get_dt_by_label() would be useful, if we can figure out how to name it so it's not confused with the label property.

The vision for this that I discussed with Kumar was that "it's just a pointer dereference!" makes phandles "just work": from prop = <&gpioM ...> you can translate the &gpioM phandle to &__device_N in the generated header "right away", since the script knows the ID number for the node pointed to by the phandle.

This makes sense.
Something to consider is that AFAIK to this point the only way to get a struct device * was to use device_get_binding(LABEL), and the result is null if the device exists but does not function.
device_get_dt_binding*() appears to return a pointer to a struct device whether or not that device works (and will fail to build if the referenced device is not linked in).  This is a "good thing" as it enables progress on #19448 where we need to be able to turn off devices, or turn on devices that weren't enabled at boot.  However, we do need to take care that driver access is made safe against invocations where the pointer was obtained without validating the device or before the device was started.  That may require a tree-wide inspection, or something injected at the driver wrapper level.

Too bad I'm not there; this is exactly the sort of thing I'm interested in.
In principle I think this is great. I'd intended to use the ordinal generated by #19454 for this, with the thought of providing a lookop table rather than external name, but this works. A benefit of using the ordinal is that we could put all the device instance records into a linker section in dependency order, which could simplify initialization.

Agreed, the intent was the assign the numbers in that order, I was just being quick with giving some numbering system to show something work.  But totally agree this should be

One concern is that the generated names like DT_INST_0_NORDIC_NRF_SAADC_ZDID intrude on the binding namespace, since it conflicts with a binding property named ZDID. We've made progress to eliminating that by using prefixes instead; it's sad to introduce a new case.

Fair, I thought about that and agree.  This will get fixed.

To @erwango's point I think keeping the label property is fine: it should just be used for its defined purpose "human readable string describing a device" rather than as a handle that identifies the device within a registry. Though I don't know how we deal with all the device_get_binding(DT_INST_0_FOO_LABEL) uses that already exist.

The hope is to remove the string at some point since it would reduce footprint.

To @erwango's point I think keeping the label property is fine: it should just be used for its defined purpose "human readable string describing a device" rather than as a handle that identifies the device within a registry. Though I don't know how we deal with all the device_get_binding(DT_INST_0_FOO_LABEL) uses that already exist.

The hope is to remove the string at some point since it would reduce footprint.

I was thinking of a Kconfig option that would cause the value of the label property to be stored in the device device_config structure.  This would allow access to that property from user code, and would contribute to solving the problem of displaying device information in a human-readable way at runtime.

... use the ordinal generated by #19454 ...
Agreed, the intent was the assign the numbers in that order

That would allow us to use the ordinal (ZDID) as the opaque device handle, with -1 to represent an unknown device (or 0 if we muck with the device array indexing, so references initialize to "no known device").
Then there's still a barrier of going through device_get_binding_by_id() to get a validated  struct device *.

@pabigot

Something to consider is that AFAIK to this point the only way to get a struct device * was to use device_get_binding(LABEL), and the result is null if the device exists but does not function.

That was a quick hack to solve the issue when device init fails.
But we need to fix this (in another PR) in a better way (either storing the actual init error for a device, or having just a bit array: when 0, it's non functioning. Stored in kernel/device.c, not struct device. driver APIs or device driver would obligatory check this etc... just wet finger thoughts), since writing in struct device voids the possibility to get it always in ROM. (and if struct device was never touched at all, it would be possible to make it const also).


Myget feed

Not really an issue, but anyway:
What is the status on the "daily " build, seems to have been stuck for some days now (and I am falling more and more behind)

Hey Erik,
There was some wide-reaching dependency upgrades going on that affect EF7 and ASP.NET 5... should be resolved today.
~Rowan

Aaah - love "beta" land!


cargo run --target=x86_64-unknown-linux-musl fails

I followed the rustup tutorial found here: https://blog.rust-lang.org/2016/05/13/rustup.html
Im not sure if its a rustup issue, but I tried to compile my crate  and got this error:
cargo run --target=x86_64-unknown-linux-musl
   Compiling byteorder v0.5.3
   Compiling inflate v0.1.1
   Compiling winapi v0.2.8
   Compiling color_quant v1.0.0
   Compiling lazy_static v0.2.2
   Compiling rustc-serialize v0.3.21
   Compiling regex-syntax v0.3.9
   Compiling glob v0.2.11
   Compiling utf8-ranges v0.1.3
   Compiling strsim v0.5.2
   Compiling miniz-sys v0.1.7
error: failed to run custom build command for `miniz-sys v0.1.7`
process didn't exit successfully: `/home/kosinix/rust/raster-cli/target/debug/build/miniz-sys-60c8d67696f63a43/build-script-build` (exit code: 101)
--- stdout
TARGET = Some("x86_64-unknown-linux-musl")
OPT_LEVEL = Some("0")
PROFILE = Some("debug")
TARGET = Some("x86_64-unknown-linux-musl")
debug=true opt-level=0
HOST = Some("x86_64-unknown-linux-gnu")
TARGET = Some("x86_64-unknown-linux-musl")
TARGET = Some("x86_64-unknown-linux-musl")
HOST = Some("x86_64-unknown-linux-gnu")
CC_x86_64-unknown-linux-musl = None
CC_x86_64_unknown_linux_musl = None
TARGET_CC = None
CC = None
HOST = Some("x86_64-unknown-linux-gnu")
CROSS_COMPILE = None
TARGET = Some("x86_64-unknown-linux-musl")
HOST = Some("x86_64-unknown-linux-gnu")
CFLAGS_x86_64-unknown-linux-musl = None
CFLAGS_x86_64_unknown_linux_musl = None
TARGET_CFLAGS = None
CFLAGS = None
running: "musl-gcc" "-O0" "-ffunction-sections" "-fdata-sections" "-g" "-m64" "-fPIC" "-static" "-o" "/home/kosinix/rust/raster-cli/target/x86_64-unknown-linux-musl/debug/build/miniz-sys-60c8d67696f63a43/out/miniz.o" "-c" "miniz.c"

failed to execute command: No such file or directory (os error 2)
Is `musl-gcc` not installed?

--- stderr
thread 'main' panicked at 'explicit panic', /home/kosinix/.cargo/registry/src/github.com-1ecc6299db9ec823/gcc-0.3.38/src/lib.rs:958
note: Run with `RUST_BACKTRACE=1` for a backtrace.

You need to install (or build) musl. On Debian-based systems, apt install musl-tools will set up everything you need.

Thank you. Closing.


Add Cvent Software Engineering Apprenticeship

Add Cvent Software Engineering Apprenticeship

✅ By submitting this PR, I have verified the following

[] Checked to see if a similar PR has already been opened 🤔
[] Reviewed the contributing guidelines 🔍
[] Added my name to the bottom of the list under the Credits section in the README.md with a link to my website or GitHub profile 👥

I'm going to close this PR since its covered here: https://github.com/FrancesCoronel/apprenticeships/pull/644


[Feature request] make updates to a driver available

When updating a SDK driver (adding/removing capabilities) its currently not possible to chose update driver like with "real" drivers. A similar feature would be nice.

Hello !
Definitely a must-have option 👍

:+1:

I am needing this as well... 👍

Are there any news on this one?
Without Updates, it is a bit heavy to perform checks during coding.
Thanks in advance

We're getting started on device updates for the SDK drivers. You'll be able to specify a version, on SDK start up the NEEO Brain will automatically run available updates.
The processes roughly will look like this:

SDK restarts with new version
NEEO Brain gets the registration and checks version
Added devices using an older version will try to run the update

All capabilities not currently in the device will be added.
Devices settings changes are updated
Changed capability settings will be detected and updated
Migrations of capabilities (changing "name" field, migration format to be defined)

This will be tackled in multiple steps, these might be added over multiple releases.

[ ] Detect device version changes
[ ] Add new capabilities to existing devices
[ ] Update device settings (for example add alwaysOn or change timings)
[ ] Update existing capabilities (for example label or slider range)
[ ] Migrate capabilities (for example rename "PWR OM" to "POWER ON")

Note: out of scope update features for now:

Updates to the device name, manufacturer and type
Removing capabilities

Won't getting the full data (like in the initial adding of the device) not solve all these steps at once?

Will this feature also cover the internal SDK drivers?
Means:
When e.g. Sonos brings a new device, will there be a way to update the sonos driver without the needs of a firmware update?
So basically I would like to see the update will also apply for internal SDK drivers, so a feature enhancement or new device coverage or new features can be implemented without the need of a firmware update from neeo side.
There is still the approach that one of the team members check the code before pushed to the user's but it would be helpful for the future to have this ability.

That's a good idea, currently however the devices provided on the NEEO Brain are bundled with the firmware. We might change this in the future but downloading driver updates is outside the scope of this issue.
A lot of the built-in devices will still benefit from this feature. If they are updated with new components as soon as the new firmware version is installed the new components will be available without having to remote and re-add the device.
Regarding @nklerk's comment getting the full definition is part of the solution, but then internal representation of the device needs to updated as well so it's a bit more complex.

This will be part of the next release: https://github.com/NEEOInc/neeo-sdk/blob/f3448ca00814945f6e2dcbd750f98de96acdc659/lib/device/devicebuilder.js#L58


Fix external resource ids lost

Fixes #77172.

Thanks!

I forgot to add that the uids the editor save adds are still lost when re-saving from script. I'm a bit confused about that being expected or not.


Use CaptionAttribute for enum values if available.

Enum titles are currently based solely on the member name. To allow adding more information for the user, and separate the internal names from the representation to the user, it makes sense to allow setting the CaptionAttribute for enum members.
The attached commit checks if an explicit caption was set, and otherwise falls back to the default behaviour.

I am adding this patch with reservations.
Very few people will ever have access to modify the base enumerations to sprinkle them with [Caption] attributes.   This is really bordering on "just use the Elements API".
Additionally, you did not provide any documentation, and as I stated before, undocumented features just add bloat as nobody will ever see them

Thanks for applying the request. Regarding the documentation, at least I was surprised that the CaptionAttribute was actually not used when I added an enum field. So I thought making it respect that attribute would be just natural ;) But thanks for adding documentation.


Transylvania by night

Submitter: Amar.k
In Transylvania by night, there are several variations of tzimice, but, the only way to change tzimice disciplines are by going into free mode

I'm not totally sure about all the variations of Tzimisce. I know of the Old Clan which are different, I think there's been a request to add the Old Clan already. The only other one I can think of is Koldunic Sorcerers, but I am not aware if that is a separate version of Tzimisce with a different title.
I'll look into Transylvania by Night, but I will say this is probably something I'll remedy with adding the Old Clan, but I'm not 100% on making a distinction for the other types.


Fix nullpointer issue with edit geometries sample

handle case where nothing is clicked
move logic for changing feature location out of method

@john0005 Can you please review?

Looks good.


Set skip_special_tokens in runtime

CVS-152371
PR to GenAI repo https://github.com/openvinotoolkit/openvino.genai/pull/859/files

Discussed in Tokenizer weekly and decided to move this transformation to GenAI


chore(release): v1.1.0 🎉

:robot: I have created a release beep boop
1.1.0 (2024-11-30)
Features

base64: support base64 serde (82e3e48)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ehmpathy/serde-fns/releases/tag/v1.1.0 :sunflower:


problem with exwm-input-prefix-keys

there is no way to add s- to the exwm-input-prefix-keys list.

I don't use exwm, don't understand what you're asking for, and don't understand what this has to do with Perspective. Kindly provide an explanation of what you're looking for.

Sorry I shouldn't have opened this issue here. rough night.


No Android icon generated if /build/ is part of app path

no Android Manifest is found if /build/ is part of searchRoot, as the build folder rex excludes everything in this case
see https://github.com/dwmkerr/app-icon/blob/master/src/android/find-android-manifests.js
(this could be a new test case for https://github.com/dwmkerr/app-icon/blob/master/src/android/find-android-manifests.specs.js)

Hi @ath0mas can you let me know the path in your example you'd like to find? I think in general it seems that excluding the build intermediary folders seems to be useful, I'm trying to think of a way to keep this behaviour but still fit your use-case! It might be that if search paths are specified, we exclude nothing. This is maybe a little odd but might be the easiest way.

The cordova application I create is located in /c/workspace/cdvapps/cdvappexample/build/dev
then I call appIcon.generate() from here without searchRoot, equivalent to running it from anywhere else with searchRoot set to this same path
Detection for Android (and possibly for iOS too?) should not match on the searchRoot part of files found

Oh I see - actually then the solution should be simple, if the project is rooted at:
root/folder/another/myproject

then the skipping of folders with 'build' in the name should not include the actual root folder of the project, this would solve your issue but also mean that things like:
root/folder/another/myproject/android/app/build

Would still be successfully ignored!

@ath0mas Can you try using the branch feat/better-android-build-folder-checking and see if it resolves your issue? If so I will merge the change into master!

I'll try using your branch today

It works fine with this branch changes 👍

To better understand: why AndroidManifest.xml detection can find multiple results?
I create a new Cordova project, add platform android and add plugins ; then running generate shows:
Found Android Manifest: platforms\android\CordovaLib\AndroidManifest.xml...
Found Android Manifest: platforms\android\app\src\main\AndroidManifest.xml...
Found Android Manifest: plugins\cordova-plugin-ABC\android\common\src\main\AndroidManifest.xml...
Found Android Manifest: plugins\cordova-plugin-ABC\android\CDVAbc\src\main\AndroidManifest.xml...
. . .

To me, here, the only expected result should be the 2nd: platforms\android\app\src\main\AndroidManifest.xml... ?

OK! I'm going to merge in the changes and release. For the manifest multiple results, I think it is because the plugins and cordova dependencies themselves also have manifests, and it is difficult to consistently and programatically work out which one is the right one. This is where you'd use --search-path to limit to the folder you know works!

OK! I'm going to merge in the changes and release. For the manifest multiple results, I think it is because the plugins and cordova dependencies themselves also have manifests, and it is difficult to consistently and programatically work out which one is the right one. This is where you'd use --search-path to limit to the folder you know works!
Published as 0.13.0

Thx @dwmkerr for the release!
I tried using --search-path targeting the platforms dir for my cordova project so that it can work well whether I add platform android or ios
For android it is better as there is no match in plugins, but still get platforms\android\CordovaLib\AndroidManifest.xml result
Would it be possible to ignore CordovaLib on 'your' side? or to be able to pass our own custom matchers to detections (android and ios)?


Quick Access pins broken after 24H2 update

Windows Version
Microsoft Windows [Version 10.0.26100.2033]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[x] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-2
Distro Version
Ubuntu 22.04
Other Software
No response
Repro Steps

Pin folder inside \\wsl$ to quick access in file explorer
Click on pinned folder

Expected Behavior

Pin folder inside \\wsl$ to quick access in file explorer
Click on pinned folder
Pinned folder opened in file explorer

Actual Behavior

Pin folder inside \\wsl$ to quick access in file explorer
Click on pinned folder
"Element not found" error shown

Diagnostic Logs
No response

See relevant comment: https://github.com/microsoft/WSL/issues/11252#issuecomment-2413694881

I'm having the same issue as OP and in the other referenced thread. Running wsl --update and wsl --update --pre-release gives me back "The most recent version of Windows Subsystem for Linux is already installed." so no help there. I first noticed the issue yesterday (2024-10-21).

Exact same issue here after updating.

The log file doesn't contain any WSL traces. Please make sure that you reproduced the issue while the log collection was running.
Diagnostic information

I did reproduce whilst the log collection was running.  This seems like the kind of issue that would be logged in Windows logs (it being an issue with File Explorer) rather than WSL logs.

Same issue here.
Slight workaround is to map your '\wsl.localhost' to a network drive. Pinning folders from that mapped network drive works.
For those who have a non-working Pin in their explorer stuck, I was able to remove it with;

Workaround for removing a folder that points to the '\wsl$' is to navigate to that folder and right button click 'Pin to quick access'

Another workaround method is add network location in 'This PC' and show 'This PC' tree in navgation pane.

If use Network driver, it will failed path conversition when we open a WSL terminal from right click menu or you want start a WSL application from this location.

Same issue here.
I tried to pin \wsl.localhost to the quick access. But when I click on it, this error appear:

And now, I cannot even unpin it. It is stuck there.
My windows updated to 24H2 W11.

Some updates:

It hadn't occurred to me to try to unpin my WSL quick access options, I can confirm I am unable to
Can confirm the workaround of mapping \\wsl$\Ubuntu to a Network Drive worked for me

Same problem for me with WSL quick access dissapeared.

Same issue here. I tried to pin \wsl.localhost to the quick access. But when I click on it, this error appear:  And now, I cannot even unpin it. It is stuck there. My windows updated to 24H2 W11. Edition Windows 11 Pro Version 24H2 Installed on 25/10/2024 OS build 26100.1742 Serial number 5XA29FFT800042H Experience Windows Feature Experience Pack 1000.26100.18.0 And My WSL is updated to the latest:

Same issue here.
You can remove file to reset quick access (will remove all your custiomize icon in quick access). C:\Users\sum\AppData\Roaming\Microsoft\Windows\Recent\AutomaticDestinations\f01b4d95cf55d32a.automaticDestinations-ms
If you really want add icon into quick access to open WSL path. try use network drive please. It's work to me.
However, you can not directly open WSL terminal in network drive location using right click in the Explorer. Only 'network locations' available it.

fixed in https://support.microsoft.com/pl-pl/topic/november-12-2024-kb5046617-os-build-26100-2314-1fa61a6d-a99a-47ca-a169-6974f08c3a0b

Automatically started working for me with the latest fix, thanks @Hofundur

Same, updated wsl this morning and that resolved the issue.

the issue look been fixed.
my system version:

WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>-1
WSLg version: 1.0.65
MSRDC version: 1.2.5620
Direct3D version: 1.611.1-81528511
DXCore version: 10.0.26100.1-240331-1435.ge-release
Windows version: 10.0.26100.2314

Same issue, after the update to win11 24h2 all the links are gone, if I add them again they don't work with the error on explorer.exe "Element not found." and actually I'm unable to remove that broken links.
I tried both linking \wsl.localhost\path and \wsl$\path but doesn't work.
I have all the components updated with the same version of the last comments but it doesn't work

I have the same issue:
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>-1
WSLg version: 1.0.65
MSRDC version: 1.2.5620
Direct3D version: 1.611.1-81528511
DXCore version: 10.0.26100.1-240331-1435.ge-release
Windows version: 10.0.26100.2314

Installed 24H2 yesterday, the problems appeared right after.
Interestingly, I can access the files from File Explorer, double-click in them works fine, but wslview gives the same Start : This command cannot be run due to the error: Element not found. error; also, double-clicking the same files from Total Commander raise the same "Element not found." error.

Also seems to be working for me now, although I've been using the network drive workaround so I can't pinpoint exactly when.
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>-1
WSLg version: 1.0.65
MSRDC version: 1.2.5620
Direct3D version: 1.611.1-81528511
DXCore version: 10.0.26100.1-240331-1435.ge-release
Windows version: 10.0.26100.2314

@conan Could you please test something for the rest of us?

Start PowerShell in a WSL folder or change directory to a WSL folder after starting PowerShell (e.g. cd \\wsl$\distro\some\existing\folder);
Type Start ., which should open the current folder in File Explorer.
Does it work? If yes, does it open the correct folder?

Thank you!

I have the same WSL- and Windows versions as @conan but still have the issue with Quick Access pins to WSL directories not working. I ran the test suggested by @zoliszabo with the following result:

PowerShell 7.4.6
PS Microsoft.PowerShell.Core\FileSystem::\wsl.localhost\Ubuntu-22.04\home\johsj47> Start .
Start-Process: This command cannot be run due to the error: An error occurred trying to start process '.' with working directory '\wsl.localhost\Ubuntu-22.04\home\johsj47'. Element not found.

And to affirm I am running the same version as @conan :

PS Microsoft.PowerShell.Core\FileSystem::\wsl.localhost\Ubuntu-22.04\home\johsj47> wsl --version
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>-1
WSLg version: 1.0.65
MSRDC version: 1.2.5620
Direct3D version: 1.611.1-81528511
DXCore version: 10.0.26100.1-240331-1435.ge-release
Windows version: 10.0.26100.2314

Maybe a dumb question, but did you reboot after updating wsl? I had to reboot after the update for mine to work.

I have the same WSL- and Windows versions as @conan but still have the issue with Quick Access pins to WSL directories not working. For comparison, I ran the test suggested by @zoliszabo with the following result:

PowerShell 7.4.6
PS Microsoft.PowerShell.Core\FileSystem::\wsl.localhost\Ubuntu-22.04\home\johsj47> Start .
Start-Process: This command cannot be run due to the error: An error occurred trying to start process '.' with working directory '\wsl.localhost\Ubuntu-22.04\home\johsj47'. Element not found.

And to affirm I am running the same version as @conan :

PS Microsoft.PowerShell.Core\FileSystem::\wsl.localhost\Ubuntu-22.04\home\johsj47> wsl --version
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>-1
WSLg version: 1.0.65
MSRDC version: 1.2.5620
Direct3D version: 1.611.1-81528511
DXCore version: 10.0.26100.1-240331-1435.ge-release
Windows version: 10.0.26100.2314

@CameronGo I have rebooted multiple times, yes. Worth mentioning is perhaps that my computer is managed by my employer. While I have some local admin rights I have little to no control over which updates are pushed and when to install them, i.e. I am somewhat limited wrt what I can do to explore this issue as far as it entails installing and/or rolling back updates.

Same problem after latest Windows Update. WSL folder disappeared from Network folder in File Explorer, and can't access pinned WSL folders from Quick Access in File Explorer. When I run wsl --update it says that the most recent version is already installed, and I also have all latest Windows Update installed, so not sure what you guys mean by it's fixed after updating.

Can confirm that this is also still happening for me.
WSL Version:
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>-1
WSLg version: 1.0.65
MSRDC version: 1.2.5620
Direct3D version: 1.611.1-81528511
DXCore version: 10.0.26100.1-240331-1435.ge-release
Windows version: 10.0.26100.2314

Windows update KB5048667 was installed on my PC overnight and it fixed the issue for me.
I must note that I also clicked WSL in the start menu by mistake (I almost never do that to start WSL) and it triggered the installation process of version <IP_ADDRESS> (the version I already had installed since weeks ago). _
Anyway, all issues seem to be gone now.
Current configuration:

WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>-1
WSLg version: 1.0.65
MSRDC version: 1.2.5620
Direct3D version: 1.611.1-81528511
DXCore version: 10.0.26100.1-240331-1435.ge-release
Windows version: 10.0.26100.2605

I've applied Windows update KB5048667 and wsl --version tells as same as zoliszabo's previous post.
But still my Quick Access pins for WSL region is broken. sad.

kiddingbaby, thak you. That worked.
But maybe correct command would be:
wsl.exe --update --pre-release

kiddingbaby, thak you. That worked.
But maybe correct command would be: wsl.exe --update --pre-release

You're right, I edited  my comment.
By the way, it broken again today, after reboot, the problem disappears again. I think there must be some magic that triggers it.

I can confirm that the trick mentioned by @zoliszabo about opening WSL app from start menu can indeed bing back the WSL folder in File Explorer by triggering some installation process and after rebooting the pc.

For me the update with --pre-release flag (and a reboot) fixed the issue

I also noticed that Linux had disappeared from under the Network entry.
But updating with --pre-release flag (which ended in an error about not being able to create a link), rebooting, launching Ubuntu from start menu, then reopening Explorer, voilà I now have Linux again below the Network entry, and the pin in Quick Access is working again, no need to map the network drive. For now at least.


updated project to class library

In case your interested, I have updated the project to a class library

new update in new pull request


Make ExternalLoginsPageFilter accessible

Scaffold identity, but want to remove the "Identity" area folder. Have to add Razor page options to new area. Would be nice if we didn't have to duplicate ExternalLoginsPageFilter because its internal to UI. If we're scaffolding identity, one can assume we'd want this filter, too.

Actually, I'm not positive this is actually used anywhere? Even in DefaultIdentity? ManageNav takes care of this on its own? What's this filter for?


bug(youtube-player): Ready event is never emitted

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
16.1.1
Description
ready event no longer emits, however some other events work as expected.
Reproduction
StackBlitz link: https://stackblitz.com/edit/stackblitz-starters-saqwwz?file=src%2Fmain.ts
Steps to reproduce:

Run file (might need to open preview in new tab)
Click play on Youtube

Expected Behavior
ready event to be emitted (and set isReady to true)
Actual Behavior
ready never emits
Environment
Package                         Version
@angular-devkit/architect       0.1701.3
@angular-devkit/build-angular   17.1.3
@angular-devkit/core            17.1.3
@angular-devkit/schematics      17.1.3
@angular/cdk                    17.1.2
@angular/youtube-player         17.2.0
rxjs                            7.8.1
typescript                      5.3.3
zone.js                         0.14.3

Browser(s): Edge/Firefox
Operating System (e.g. Windows, macOS, Ubuntu): Windows 10

It's because the ready event fires when the API has been loaded. Now we no longer need to load the API until the video is played so the player is ready from the beginning. If you want to get the old behavior, you can set the disablePlaceholder attribute to go back to the old behavior.

This obviously crashes since player isn't ready yet.
In what way does it crash? I'm asking since we have some logic in the component where calling mute before the player is ready will get cached and applied when it starts playing. See https://github.com/angular/components/blob/main/src/youtube-player/youtube-player.ts#L320.

Crashes because the whole YouTubePlayer component isn't ready yet, or at least available through @ViewChild

TypeError: Cannot read properties of undefined (reading 'mute')

pendingPlayerState will work fine if YouTubePlayer component is ready and YT.Player isn't.
This is why we relied on ready event, since we didn't care when it is ready, but just mute when it is.

I think the problem is that you're accessing the player before ngAfterViewInit. It should be defined if you move the call there.

It works fine with ngAfterViewInit when component is immediately visible, but not when it's behind @if.
This example shows exactly the problem https://stackblitz.com/edit/stackblitz-starters-q5wasm?file=src%2Fmain.ts

I see. I think that you should be able to add mute: 1 to the playerVars. I know you mentioned earlier that "playerVars has no muted property, so we relied on ready event to mute video before it started playing.", but I see it when I look at the typings: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/youtube/index.d.ts#L524

Thanks, that worked. I was looking at YouTube Embedded Players and Player Parameters which doesn't have that property listed.
I think we can easily shift the rest of the functionality that was called on ready to other events, so this should work fine.


fix: 🐛 update dashboards management grid

https://metakeen.atlassian.net/browse/FEE-568

Checked, it works correctly right now.


Please transform this "fork" in an origin repo

Because it's a fork:

you cannot find it in github search
you cannot fork it if you had already a fork of the original

...and probably a few other things.
I think it would be good to transform this "fork" in a full-fledged repo, so that it's easier for others to find & contribute.

Because it's a fork:

you cannot find it in github search
you cannot fork it if you had already a fork of the original

...and probably a few other things.
I think it would be good to transform this "fork" in a full-fledged repo, so that it's easier for others to find & contribute.

I agree. It is time to move Buefy-next to Buefy. I will need to discuss this with @kikuomax

I agree. It is time to move Buefy-next to Buefy. I will need to discuss this with @kikuomax

Or we could make this repo independent from the Buefy repo.

Or we could make this repo independent from the Buefy repo.

What are the benefits of doing that?

@kikuomax @dagnelies I believe this is the solution we are looking for https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/detaching-a-fork#about-detaching-forks

Putting it under the traditional Buefy repo would definitely be a show of confidence for current/future users.
Currently, if you go to buefy/buefy-next the last commit is from almost a year ago. You as maintainers know vue3 dev is active, and yes, there's a note on the main page linking to this repo. For those less involved in the project, it's fairly easy to look at the buefy-next branch and think vue3 migration was abandoned.
Maybe moving this repo under the Buefy org account and deleting the buefy/buefy-next branch could work?
I'm just some random guy so feel free to discard this.

Putting it under the traditional Buefy repo would definitely be a show of confidence for current/future users.
Currently, if you go to buefy/buefy-next the last commit is from almost a year ago. You as maintainers know vue3 dev is active, and yes, there's a note on the main page linking to this repo. For those less involved in the project, it's fairly easy to look at the buefy-next branch and think vue3 migration was abandoned.
Maybe moving this repo under the Buefy org account and deleting the buefy/buefy-next branch could work?
I'm just some random guy so feel free to discard this.

I completely forgot about that branch 🤣

Putting it under the traditional Buefy repo would definitely be a show of confidence for current/future users.
Currently, if you go to buefy/buefy-next the last commit is from almost a year ago. You as maintainers know vue3 dev is active, and yes, there's a note on the main page linking to this repo. For those less involved in the project, it's fairly easy to look at the buefy-next branch and think vue3 migration was abandoned.
Maybe moving this repo under the Buefy org account and deleting the buefy/buefy-next branch could work?
I'm just some random guy so feel free to discard this.

I personally am leaning towards moving Buefy-next back to Buefy. However I want to remain on the same page as @kikuomax when it comes to such a major change. Plus our original goal was to wait for a RC of Buefy-next to be stable before we move back to Buefy.
The only concern I have right now with changing this fork to a stand alone is can we reverse it back to a fork to keep all the commit history? And if not how would we handle the VSC history? @kikuomax @mgd722 @dagnelies

Three main concerns identified so far:

you cannot find it in github search (@dagnelies)
you cannot fork it if you had already a fork of the original (@dagnelies)
the fractured development pattern can be interpreted as instability (@mgd722)

Could you merge relevant branches from this repo into buefy/buefy-next and then continue development there? Further development would be centralized in the place where people already go to look for buefy updates.

Three main concerns identified so far:

you cannot find it in github search (@dagnelies)
you cannot fork it if you had already a fork of the original (@dagnelies)
the fractured development pattern can be interpreted as instability (@mgd722)

Could you merge relevant branches from this repo into buefy/buefy-next and then continue development there? Further development would be centralized in the place where people already go to look for buefy updates.

Yes that's possible. The only issues that I can think of is the additional complexity from having two version of Buefy in one repo (PRs, Issues, and Branches would all be affected).

@wesdevpro To be honest, I need a "quiet" place to focus on the migration to TypeScript. I believe the TypeScript migration will make Buefy consistent and solid, and be the foundation for the future Buefy.
Btw, can we simply delete the buefy/buefy-next branch not to confuse people?

@wesdevpro To be honest, I need a "quiet" place to focus on the migration to TypeScript. I believe the TypeScript migration will make Buefy consistent and solid, and be the foundation for the future Buefy.
Btw, can we simply delete the buefy/buefy-next branch not to confuse people?

The branch was successfully deleted.


Invalid repository

This project lists a repository from where to obtain the binaries of this project that is no longer active.
An alternative seems to be: https://plugins.gradle.org/plugin/org.kordamp.gradle.markdown

Fixed.


Fixed recompilation of controller with gcc7

Fixes #176.

test me

test me

Build Passed :ok_hand:
You can safely merge 'fix-recompilation-of-controllers' into 'master'.

👍

Build Passed :ok_hand:
You can safely merge 'fix-recompilation-of-controllers' into 'master'.

test me

Build Passed :ok_hand:
You can safely merge 'fix-recompilation-of-controllers' into 'master'.

test me

Build Passed :ok_hand:
You can safely merge 'fix-recompilation-of-controllers' into 'master'.

👍

👀


Support Windows Nano Server

Description
Windows Nano Server is missing some dlls, so SkiaSharp does not work. Related to https://github.com/mono/SkiaSharp/issues/591
Having a look at Nano Server... Ran the NanoServerApiScan.exe tool from: https://blogs.technet.microsoft.com/nanoserver/2016/04/27/nanoserverapiscan-exe-updated-for-tp5/
=== libSkiaSharp.dll ===

ERRORS:

  FONTSUB.dll
    CreateFontPackage(Proc not found)
  USER32.dll
    SystemParametersInfoW(Proc not found)
  MSVCP140.dll
    …
    …
    …
      Please copy Nano Server compliant MSVCP140.dll from %ProgramFiles(x86)%\Microsoft Visual Studio 14.0\VC\redist\onecore\x64\Microsoft.VC140.CRT\
  VCRUNTIME140.dll
    …
    …
    …
      Please copy Nano Server compliant VCRUNTIME140.dll from %ProgramFiles(x86)%\Microsoft Visual Studio 14.0\VC\redist\onecore\x64\Microsoft.VC140.CRT\

I need to investigate the 2 usages that appear to be bad:

FONTSUB.dll (CreateFontPackage)
USER32.dll (SystemParametersInfoW)

Just did some investigation :)
CreateFontPackage from FONTSUB.dll is just for XPS support - and this is also just for font subsetting. The UWP build does not have this at all, so I could just remove it for a nano build.
SystemParametersInfoW from USER32.dll is also not too essential - it is just for determining the default font. Again, this is not available for UWP - we just pick the "Segoe UI" which we know is available by default.
Nano Server support could very well be possible in the near future - just have to check priorities.
Add your vote to this issue so we can prioritize this issue.

VS bug #727251

We just ran into this issue while trying to deploy an ASP.Net Core microservice dependent on SkiaSharp with the microsoft/dotnet:2.2-aspnetcore-runtime image.
Are there any news regarding this? 😢

@mattleibow Are there any news or other issues to follow related with this?

@mattleibow We encountered the same problem when deploying Azure Functions. Are there any news about this?

Hi Team,
Are there any news regarding this?
Regards,
Vijayasurya A

Sounds like we just need a new target externals-nano-server and leave out the parts that depend on not supported api. So in the end this is mostly how the UWP build works.

We just need to figure out how we would actually package this. Right now the Win32 is in the main NuGet. We might need to see how devs would use this. Will they use VS on Windows and do testing, and then deploy to Nano? If so, we need to find a way to have dotnet publish (and similar) to actually use the Nano binaries. That will probably be the hardest part - how do we distinguish between desktop vs nano Win32? NuGet has RIDs, but this is just win-xxx versions. Unless there is a more specific one for Nano?

Just wrapped the NanoServerApiScan tool in a nice .NET Core tool: https://github.com/mattleibow/nano-api-scan
nano-api-scan path/to/libSkiaSharp.dll

After switching to static builds and Clang, we now only have a single method that we have to worry about:
=== libSkiaSharp.dll ===

ERRORS:

  FONTSUB.dll
    CreateFontPackage(Proc not found)

Good news! I think we can get Nano Server in for the next release I am planning next week if this build goes well: https://github.com/mono/SkiaSharp/pull/1013/commits/b265b430f098259fc5bba2d4b8531cec1c37d311
Pretty much, I can exclude the usage in the comment above and no one woulds care - that is just for the experimental XPS document type subsetter. I have no numbers, but I don't think anyone would use that as we have better PDF support. Who uses XPS anyway? Hoping that the logic that I have for the "no dependencies" build of linux can be reused to created a "nano server" build.
From what I can see so far, we could get this working. Not going to be the prettiest at the moment because of the way the PackageReference and things work - and the open issue on NuGet (https://github.com/NuGet/Home/issues/7375) makes is messy.
But, the usage looks to be:
<PackageReference Include="SkiaSharp" ExcludeAssets="runtime" />
<PackageReference Include="SkiaSharp.NativeAssets.NanoServer" />

This is basically saying work as normal, but instead of using the native runtime bits from "SkiaSharp", ignore it and use the "SkiaSharp.NativeAssets.NanoServer" instead. This only has to be done on the top-level app as the runtimes are only used on dotnet run and dotnet publish.
Not sure if this will work nicely, need to do a bit of testing. Fingers crossed.

Heh, I think I was getting ahead of myself... next week is like Wednesday and there is no way a reasonable person should go stable with just a weekend hack :) Moved it out to a new PR #1014 that I will merge after I release. I want to try and get a more frequent release cadence with SkiaSharp - and give people more time to actually test Nano Server.

This is the CI for that PR: https://dev.azure.com/xamarin/public/_build/results?buildId=9981&view=results You can check out the artifacts when the build completes.

Check out this build's artifacts: https://dev.azure.com/xamarin/public/_build/results?buildId=9982&view=resultsa

I think I am almost ready to get this in with #1040 So far, Nano Server seems to be working

Merged into master! Will push out some packages to the early-access feed as soon as CI is done. Also hope to go public preview soon as well.

Just linking this new issue : https://github.com/NuGet/Home/issues/8894


Create FUNDING.yml

Add funding entries based on the core team and offline discussions.
Part of #1634.
Additional context and info (if any)
Once we have a new core contributor, his/her name can be added to the list too.

@ueman Thanks!


ItzChkn Ban Appeal

I admit to griefing and lying to the staff and I'm really sorry about it. If I get another chance I will not grief anymore and I will gladly return the items I stole and will give the person I stole from all of the in-game money I have an I have about 10500.

Your victim has already been refunded, but it's nice of you to offer. What I do not understand however, is why you would lie about breaking the rules. The only reason you were permanently banned, instead of temporarily banned, is because you lied when staff asked you about your connections to a raid.

I don't know either why I lied. I just did it because it didn't know what to say. I won't lie anymore to the staff if I get unbanned.

This hasn't had any updates in quite a while. Feel free to reapply if you are still interested.


Use the official AWS SDK to operate with S3

I read the official AWS SDK docs and goamz docs and this is the translation :).
What changes the most is the use of the upload manager to switch to multipart upload if the file is large and dropping the NewBucket function because there's no bucket struct in the official SDK, you create a client and operate on it. Maybe I should create a NewClient function instead.
This is a work in progress, I need your help to test it properly as it involves some parts of the code I'm not yet familiar with. I opened the pull request to gather comments.
This will fix https://github.com/pachyderm/pachyderm/issues/107.

Hey, super thanks :)
There's a couple things, and I think in general we should re-think the s3utils package, but this is a great start. For testing, if you have an aws account handy (I promise this requirement will go away :) ) you can just export aws creds per normal environment variables, and make test should do the trick.

How do you think we should change it? And I'll create a AWS account to test, this won't be a real problem.

Ya actually for now, this is fine and an improvement over what we have. I made a couple comments but otherwise, thank you so much!

ignore the travis stuff

Can you change the Dockerfile and remove the goamz stuff and add go get github.com/aws/aws-sdk-go?

also go get github.com/vaughan0/go-ini

also i get these errors with make build:
$ make build
go get -d -v ./...
go build ./...
# github.com/pachyderm/pfs/src/btrfs
src/btrfs/replica.go:72: undefined: s3utils.BucketOwnerFull
src/btrfs/replica.go:72: cannot use r.uri (type string) as type *s3.Bucket in argument to s3utils.PutMulti
src/btrfs/replica.go:76: undefined: s3
src/btrfs/replica.go:78: undefined: err
src/btrfs/replica.go:79: undefined: s3
src/btrfs/replica.go:104: undefined: err
src/btrfs/replica.go:105: undefined: err
# github.com/pachyderm/pfs/src/pipeline
src/pipeline/pipeline.go:106: undefined: s3
src/pipeline/pipeline.go:143: undefined: s3
Makefile:48: recipe for target 'build' failed
make: *** [build] Error 2

I took care of the errors (sorry about that). I still need a complete make test to run but it's on its way.
About the s3utils errors, it's just because we're referring to the package on github, which doesn't have the new code yet, but I changed the path and it builds properly.
Also, why do you want me to include go get github.com/vaughan0/go-ini in this PR?

Passes! Woot!


v1.15.4 NoneType' object has no attribute 'UnimplementedError

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.15.4
Python version: 3.6.9
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version:  N/A
GPU model and memory: N/A

Describe the current behavior
I am working on distributed learning in tensorflow through estimators API using below simple code template:
# TrainSpec for training
    train_spec = tf.estimator.TrainSpec(
        input_fn=lambda: csv_input_fn(TRAIN_PATH, FLAGS.batch_size, True),
        max_steps=FLAGS.train_steps,
        hooks=[])
    # EvalSpec for test
    eval_spec = tf.estimator.EvalSpec(
        input_fn=lambda: csv_input_fn(TEST_PATH, FLAGS.batch_size, True))
    print("---training and testing---")
    tf.estimator.train_and_evaluate(classifier, train_spec, eval_spec)
    print("---training finished---")

    # All role are workers, pick the task_index with 0 to save model
    if FLAGS.task_index == 0:
        classifier.export_saved_model(export_dir, serving_input_receiver_fn)
        # classifier.export_savedmodel(export_dir, serving_input_receiver_fn, strip_default_attrs=True)
    print("finish...")

I encountered the following error during training.
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/training/server_lib.py", line 158, in __del__
AttributeError: 'NoneType' object has no attribute 'UnimplementedError'

I analyzed the source code and found that the errors object may be garbage collected.
I will submit a PR later, please pass it. Because I will use v1.15.4(v1.15.4 version on our production environment)
for distributed training on kubeflow,
I don’t want to modify the code there every time.
Thanks!!!

@UrmsOne,
TensorFlow 1.x is not actively supported. Could you please update TensorFlow to v2.4 and check if you are facing the same issue? Thanks!

same issue here, any updates?

same issue here, any updates?

Modify the source code to solve the problem by myself.  You could try it, too.
Reference:
https://github.com/tensorflow/tensorflow/pull/45836/commits/7bb1dbc3991854c92b1aa03fd7a7159e8bc4dfe5

Modify the source code to solve the problem by myself.  You could try it, too.
Reference:
https://github.com/tensorflow/tensorflow/pull/45836/commits/7bb1dbc3991854c92b1aa03fd7a7159e8bc4dfe5

@power1628
Modify the source code to solve the problem by myself. You could try it, too.
Reference:
https://github.com/tensorflow/tensorflow/pull/45836/

@power1628
Modify the source code to solve the problem by myself. You could try it, too.
Reference:
https://github.com/tensorflow/tensorflow/pull/45836/


DockerFileIssue

First issue was the docker compose up --build not working because of libc failing due to a downgrading issue.
lines 15 and 33 get replaced with:
RUN apt-get update && apt-get install -y --allow-downgrades libc-bin=2.36-9+deb12u7 \

lines 15 and 33 get replaced with:
RUN apt-get update && apt-get install -y --allow-downgrades libc-bin=2.36-9+deb12u7 \


Build for 64-bit ARM by default when compiling or exporting for Android

All Android devices that support Vulkan support 64-bit ARM. Once OpenGL support is ready (most likely H2 2022-H1 2023 with Godot 4.1), it's unlikely that 32-bit ARM devices will still be in use for Android gaming.
This also removes NEON opt-out code for ARMv7 as pretty much all ARMv7 devices also support NEON. (It's currently enabled by default, so the default behavior doesn't change here.)
This was discussed with @m4gr3d a while ago. I remember him agreeing to this idea for 4.0 :slightly_smiling_face:

Thanks!


State Monad

📖 Documentation
Is it possible someone could add a few examples for the State monad and State monad transformer to the docs?

I googled a lot of articles, go for it too.

@baetheus I added to the documentation a link to this nice post about the State monad: https://paulgray.net/the-state-monad/


[Gateway] Fix the estimation of fast deposit cost

Fix the gas estimation for the fast deposit

Codecov Report

Merging #345 (29912d1) into develop (c15ea95) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #345   +/-   ##
========================================
  Coverage    53.79%   53.79%
========================================
  Files           13       13
  Lines          329      329
  Branches        58       58
========================================
  Hits           177      177
  Misses         152      152

Flag
Coverage Δ

core-utils
53.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15ea95...29912d1. Read the comment docs.


uhdm: 1.74 -> 1.75, surelog: 1.73 -> 1.75

Description of changes
Version update of both UHDM and Surelog. Surelog and UHDM are developed alongside, so Surelog should typically be the same version as UHDM fore compatibility.
One pull request, but two separate commits to update

UHDM 1.74 -> 1.75
Surelog 1.73 -> 1.75

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Looks like this is partially done in #259267, but here, UHDM and Surelog are updated both to make sure Surelog compiles.

Ah, and today, the versions got bumped to 1.76, so incorporated that while this PR is still open.

Result of nixpkgs-review pr 261128 run on aarch64-darwin 1

2 packages built:

surelog
uhdm


[Android][Tablet][Chrome] Tablet layout mode not showing on portrait mode

When tablet is on portrait mode, the tablet button for layout mode does not show.  Please view screenshots for comparison.

WAI


45410811 - UEFA Champions League 2006–2007

Validation

[X] I've read the FAQ.
[X] The Xenia build used is from a canary branch. (not MLBS/AlexVS/master/pull requests, etc)
[X] This issue isn't for help (tech support) with Xenia, or a game.
[X] I've checked if this game doesn't already have a compatibility report.

Xbox 360 Marketplace link
http://marketplace.xbox.com/en-US/Product/UEFA-CL-2006-2007/66acd000-77fe-1000-9115-d80245410811
Xenia version
https://github.com/xenia-canary/xenia-canary/commit/1eb61aa9ab2564a683d8a49547c5c8260e9ff067
Issues
similar issue <-> https://github.com/xenia-project/game-compatibility/issues/633#issuecomment-1185414354
xenia version issue page: https://github.com/xenia-project/game-compatibility/issues/604
Log
UEFAChampionsLeague06-07-consoleoutput.zip
Screenshots

Labels
state-menus

xenia-canary/xenia-canary@85723f1

Seems like invalid memory allocation causes guest breakpoint. Please set log_level = 3 and send log from it

xenia.log.zip
xenia-canary.config.zip

https://github.com/xenia-canary/xenia-canary/commit/b0268ab87629d55f4c5a9d1cdd2833c17fa47eff

same: https://github.com/xenia-canary/game-compatibility/issues/107#issuecomment-1364547951

ITS 2024 And still there is no fix for this, can some explained in simple terms if this game works on Xenia. I've tried every method but everyone speaks in code......

Tested on: https://github.com/xenia-canary/xenia-canary/commit/adce6c0919d75c8ed5942bcc37a76878315240ec
log_crash.zip
log_gameplay.zip
Nothing changed since 2022, loading to a match is timing sensitive. Set 1 or 2 thread affinity for Xenia.exe in task manager just before loading to a match. Once loaded, all core affinity can be restored. Black flickering lines are caused by Nvidia GPU, it won't happen on AMD or Intel.


Graves not returning armor for specific players

Issue: On a Fabric Server w/ v2.0.0-beta.10, graves don't return armor for some specific players, but they get all other items back.
The graves of the players do no show them as having armor in /yigd grave [player].
Observations:
I personally witnessed this happen to one of the players affected..
They died with armor on, within an FTB Chunk claim, used /back to return to their death point, claimed their grave, then no longer had the armor.
This happens whenever they die, to any grave of their graves that they reclaim.
I did a bunch of testing on the server it occurred, in a Local Private Server, and in multiple different Singleplayer worlds, but I cannot reproduce the issue even having the same exact inventories as the players who died.

They aren't putting curse of vanishing on all of their armor are they? I assume not...
Could you check their inventories through the GUI system, and untick the buttons for destroyed, kept, respectively dropped items? Let me know if the armor appears in that case, and which toggle makes them appear. I'll try to look into this when I get enough time, but testing this would probably help a lot if it gives results.
PS. If the players aren't online you can use the /yigd moderate command

Yea, I've looked at all this while they were online right after it happened on a couple of occasions.
Their armor was not enchanted at all.
I witnessed it happen to them on a couple of occasions, they died with armor on, then no longer had it upon recovery.
It doesn't happen to many players at all, but only a specific few.
I can see the grave within /yigd grave [player], the rest of their items show up and recover properly, but in the grave listing it appears that they didn't have armor at all (nothing within the armor slots).

Did you untick the boxes to the right? There were still no armor in the slots when doing that?

Did you untick the boxes to the right? There were still no armor in the slots when doing that?

Yep, unticked all the boxes, ensured I was looking at the correct graves by identifying the coordinates of the graves, and made sure I was at the exact death point where the grave was generated,

I would ask which modpack/collection of mods you're using, but I'm not sure that I'd be able to reproduce the issue. I could try though, so having a copy of your (or rather the player who this happened to)'s instance might help

Yea.. I couldn't reproduce it personally, on the server it happened, with the exact items the players had.. From the armor that they were wearing and didn't receive back, to every item in the exact same slots of the inventory, at the exact death points they previously died.
It seems to only affect specific players, regardless of any other conditions.
I'll have notify the pack dev of the latest release, of the mod, and test with the affected players if the issue continues to happen. Since reproducing it seems impossible for unaffected players.

I don't think video would help much tbh. The only thing I can think of currently that would put players aside from other ones would be if they used like a hacked launcher, playing minecraft without having bought the game or something. Let me know if you think you can find any defining trait to these players, or a common factor.
These kind of issues are very hard to fix, as there's no real way to find out what happens, but I'd appreciate any information if it would arise

The server is an online server (online property enabled in server config, requiring proper UUID authentication through Mojang), with VPN traffic blocked using TCP Shield, and we crack down on hacks pretty heavily and quickly..
The players seem p honest with no abnormally quick progress, actually p slow progress compared to others I.M.O.
So Idk if that's the case but I'll def do some investigation regarding this.
And try to think of anything else I can investigate that may set the players apart.
Thanks for the quick responses, I'll update you when I get the chance to do this investigation proper.

Hi, sorry I took so long to get back to this.
After testing with the affected players, the issue seems to have gone away after the server update to FMC v2.8.0, notably in this version, yigd was updated from v2.0.0-beta.10 to v2.0.0-beta.11.
Thanks for releasing this update! As whatever changes you'd looks to have resolved this issue.


ODBC quickstart missing

Describe the bug
A copy-paste style quickstart, including basic odbc setup and the spice oss setup for ODBC is needed.

https://github.com/spiceai/quickstarts/pull/134


cpprestsdk missing pplx threadpool

Describe the bug
When installing the cpprestsdk package not pplx threadpool is not copied to the installed/{triplet}/include folder and is missing from the compiled library.
Environment

OS: Windows, Linux
Compiler: vs2019, clang, gcc

To Reproduce
Steps to reproduce the behavior:

./vcpkg install cpprestsdk
Look at ./vcpkg/installed/{triplet}/include/pplx
Compile code with reference to threadpool.h functions

Expected behavior
All headers and symbols are present.

@acceleratxr, may be you need to add '#include "pplx/threadpool.h" to your project? could you provide us the repro code?
BTW, I can't repro this issue with CMake project

./vcpkg install cpprestsdk
./vcpkg integrate install
Creat a test with following code:

#CMakeLists.txt
cmake_minimum_required(VERSION 3.0)
project(main)
add_executable(main main.cpp)
find_package(cpprestsdk CONFIG REQUIRED)
target_link_libraries(main PRIVATE cpprestsdk::cpprest cpprestsdk::cpprestsdk_zlib_internal cpprestsdk::cpprestsdk_boost_internal cpprestsdk::cpprestsdk_openssl_internal)

//main.cpp
#include "pplx/threadpool.h"
int main()
{
   return 0;
}

cmake "-DCMAKE_TOOLCHAIN_FILE=/home/test/vcpkg/scripts/buildsystems/vcpkg.cmake" ..
cmake  --build .

@acceleratxr, please reopen this issue and provide us the repro code if it still be a problem for you.


Presenting Programmatically

Is there a way to present the menu programmatically?

Sure thing! However I haven't exposed the methods for it. At the moment however, you can set it up with any activate option type other than .asSoonAsPossible and then change it to .asSoonAsPossible to trigger it. You may need to call reloadData afterwards. The other way is that you could submit a pull request to expose the presentMenuItems and dismissMenuItems publicly and I'd be happy to merge it!


Verify should provide a diff

This would make it far easier to understand what's going on.

closing because this repo is going to be archived


Update security-compliance-overview.md

Added lines about Wiki and OneNote

@Ansuman777 - thank you for your contribution! I will get this reviewed and merged. Appreciate it.


The time when the whole study ends.

Thanks for providing good code.
I am currently training, but it seems to be taking too long.
I am wondering if it takes a long time or will it stop if the result is okay to some extent in the middle.
If you had to run all epochs 100 (100 iterations for each epoch), how long did it take to learn?

Hi,
Sorry for the delay in my response. I have been very busy lately.
The training epochs in phase one and the training iterations in phase two are needed to be set based on the dataset you are training. In the code provided, these values are set to high numbers so that the difference in performance stability with the baseline can be easily observed. If you are training on a smaller dataset, say MNIST, less than 10 epochs are sufficient to observe this behavior.


Add more options for ajaxUpload

I think the following upload options should be available for complete flexibility:

http methods (POST, PATCH, DELETE)
file input name
setting header (needed for many authorization methods)

I'm thinking now I should have also included the dist builds.

Would you please add documentation and tests ?

Sure. I'll try and find some time tomorrow.

Yes please! Merge, merge, merge!

@lightswitchr if you contribute documentation and tests, it will get merged

@PowerKiKi It's alright asking for tests, but you have no existing tests for the project anyway.Asserting true == true is not a test...

Sorry. I've been on vacation and playing catch up on projects. I haven't forgotten about this.

Awesome. +1 on a1c66ca3d077326382e00cc3b1a787661d00eb6f

FYI, headers support were added in #19

This PR is unlikely to be merged as is now. But if somebody still need it and rebase it as a new PR, it could get merged.


Generalize definition of cleavage

SBO:cleavage (SBO:0000178) is currently defined as "Rupture of a covalent bond resulting in the conversion of one physical entity into several physical entities."
For molecules with more complex topologies, however, cleavage may change the topology of the molecule without actually separating it into more than one entity. For example, a single cleavage of a circular DNA molecule results in a linear DNA molecule (and likewise for conversion of circular to linear proteins).
I would therefore propose to slightly generalize the definition to "Rupture of a covalent bond resulting in the conversion of one physical entity into several physical entities or into a physical entity of a different topological class."

@jakebeal the request has been resolved!

Thank you; this update looks good.


read the image directly from S3, don't write to a tmpfile

tmpfile seems unnecessary GD can use the s3 stream directly with no issues.

meant to open PR against our fork, please ignore


Update parboiled to 1.0.1

Updates org.http4s:parboiled from 1.0.0 to 1.0.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

I'll rebase on this and push my WIP branch tomorrow.

Build error is due to some changes in ordering in error messages due to 2.13 collection changes.


JSONDecodeError: Expecting value: line 1 column 1

After some seconds with a lot of
ALSA lib confmisc.c:160:(snd_config_get_card) Invalid field card
ALSA lib pcm_usb_stream.c:482:(_snd_pcm_usb_stream_open) Invalid card 'card'
ALSA lib confmisc.c:160:(snd_config_get_card) Invalid field card
ALSA lib pcm_usb_stream.c:482:(_snd_pcm_usb_stream_open) Invalid card 'card'

I receive this error:
Recognized in 22.253703594207764 seconds - maybe try using a small model. See https://github.com/openai/whisper#available-models-and-languages.
Recognized:  You
Traceback (most recent call last):
  File "/home/timeu/PYTHON/chatgpt-conversation/chatgpt.py", line 21, in <module>
    resp = chatbot.get_chat_response(message)
  File "/home/timeu/.local/lib/python3.10/site-packages/revChatGPT/revChatGPT.py", line 54, in get_chat_response
    response = json.loads(response)
  File "/usr/lib/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Same error. Would be nice if someone help us with debugging.


Cannot set content of Item when user not logged in

Hello, unfortunately I get in the browser console the following error when a guest visits the forum. Because of that error, there's an error message in the #flarum-loading-error container displayed.
Error message:
Error: [ItemList] Cannot set content of Item. Key 'discussions' is not present.
I assume the problem is that no discussions are loaded when the user isn't logged in.

Once the visitor is logged in, everything works.
If i disable this extension everything works.

What is your permission "View forum (discussions and users)" like?

My forum is closed and accessible only to users, so only users are allowed to see the discussions. Guests are not allowed to see anything.

Yeah so that is the issue. The search bar has no discussion key because the user isn't logged in and guests have no permission to see discussions.

Well, but that's a problem. I'm sure I'm not the only one who only gives access to registered visitors. Can you please fix this?


Conflicting special characters when using 'alt'

Hello, awesome and much needed TWM! I'm recreating my linux workflow on aerospace, but unfortunately using shortcuts like 'alt-o' are outputting special chars instead of being used as shortcuts. Is there anyway to remove them completely, or have Aerospace take priority?
Thanks!

Checklist

[x] I've searched for duplicates. My search queries were (please don't forget to search in closed issues too):

...

[x] I've read the documentation https://nikitabobko.github.io/AeroSpace/guide & https://nikitabobko.github.io/AeroSpace/commands
[x] I've searched in the documentation. My search queries were:

<!-- Replace with `aerospace --version` output -->

aerospace CLI client version: 0.14.2-Beta 0cb8dbdfc5ee73b8cbc200f175f467ebead55201
AeroSpace.app server version: 0.14.2-Beta 0cb8dbdfc5ee73b8cbc200f175f467ebead55201

Ah, the mappings aren't directly correlated with the layout selected in the OS. Since Im on Colemak, I need to use the compiled keymapping first. Interesting approach that Im sure is needed due to MacOS.
Using the compiled mapping works, thanks!


Fix StringReaderand InputStreamReader

According to JavaDoc, Reader#read()) should return -1 if the end of the stream has been reached
Return value of Reader#skip(int) after reaching the end is only documented in StringReader, but other Reader implementation do same as far as I tested.
However, some of Scala.js Reader implementation does not behave same as JRE implementation.
This PR fixes the Scala.js implementation.

Please add an appropriate test in https://github.com/scala-js/scala-js/blob/0.6.x/test-suite/shared/src/test/scala/org/scalajs/testsuite/javalib/io/ReadersTest.scala.
Since we are in the middle of a release, I'll look at this next week, probably.

Added tests and fixed InputStreamReader as well.

Their constructors are not documented to throw NPE when receiving a null, but it should be as same as JRE implementation so that users can notice NPE on construction before using methods.

NPEs are undefined behavior in Scala.js. The rule of thumb is not to explicitly check them. If they happen to throw a TypeError, fine. If they happen not to throw one, that's fine too. But we don't add code dedicated to throwing NPEs.

Their constructors are not documented to throw NPE when receiving a null, but it should be as same as JRE implementation so that users can notice NPE on construction before using methods.

NPEs are undefined behavior in Scala.js. The rule of thumb is not to explicitly check them. If they happen to throw a TypeError, fine. If they happen not to throw one, that's fine too. But we don't add code dedicated to throwing NPEs.

OK.
I skipped the commit for NPE


Question: How to hide preview

I am looking for the proper way to stream video without showing the live preview. When I simply did not add the subview to my previewView, it seemed to still work, but it throws a lot of errors in the logs. Is there a fully-sanctioned way to just hide the preview view?

It should simply be enough not to add the preview view, any chance you could paste the errors?

it just throws this error a lot:
OGL(<path_to_project>/sample/SampleBroadcaster/Pods/VideoCore/api/iOS/VCPreviewView.mm):: 253: Invalid Operation

Did you find a solution?
@nspaul

Did you find a solution?

@bintu1234 Did you find a solution?

Same issue

Hi All @jgh- when I am trying to unlock the screen/screen after automatically lock it gives me this issue..how can I avoid it.


Remove EventsCenter

Fixes #936
Fixes #731
Fixes #701
Fixes #834
Fixes #835
Remove EventsCenter from the codebase.

Phew, this is finally ready :X Spent way too much time on this...
@damithc Please do take a look at the changes to the Developer Guide / Learning Outcomes

@damithc Please do take a look at the changes to the Developer Guide / Learning Outcomes

Checked. Both look good 👍

Fixes #834 and #835 too? 👍

[7/10] Wondering whether it'll be good to explain why InvalidationListenerManager has a locked variable. I didn't manage to catch it the first time I read it ><

I'm looking at this btw, will get back to you.

@Zhiyuan-Amos

[7/10] Wondering whether it'll be good to explain why InvalidationListenerManager has a locked variable. I didn't manage to catch it the first time I read it ><

I'm looking at this btw, will get back to you.

Alright, I ended up removing the term "locked" entirely. Do take a look at the new implementation.

Also added a CommandResultTest to boost test coverage :-P

@Zhiyuan-Amos

I may have misunderstood your comments, but it seems like the tempListeners are used as a temporary storage. As such, I'm wondering if we can simplify the following method:

Yes, you are right :+1:

@Zhiyuan-Amos

. I happened to use this library Lombok which automatically implements equals and hashCode for us.
Will this be a good enough reason for us to not have to write tests for equals and hashCode? :P

Hrm, seems like it uses internal compiler APIs to do code generation. https://github.com/rzwitserloot/lombok/blob/db19327cb4b9f5a08665b85d4cb953118ce69c13/src/core/lombok/javac/handlers/HandleEqualsAndHashCode.java I'm quite hesitant since these might be likely to break with JDK updates

@Zhiyuan-Amos

I'm reminded that we do have lots of tests for equals and hashCode.

Actually, we don't have enough :-P In fact lots of hashCode() implementations are still not covered in our code coverage.
Anyway, I don't think it is a big problem since the tests for equals() and hashCode() are obvious and follow a clear pattern. So maintenance is quite straightforward. It only becomes a hassle when someone does sweeping changes in the codebase  (ahem, like morphing a product)  But, on the bright side it'll teach readers to choose a more powerful programming language in the future that helps programmers generate this kind of boilerplate code :-P


Missing letter in Noto Sans Hebrew

The letter 'Chaf sophit' (the 11'th letter's end-of-word form) is missing.

Can you file this in the noto-fonts repo?  This does not seem to be emoji-related.

@tsmos  please open an issue in the "noto-fonts" repository if you are still experiencing this problem.
If you file a new bug, please state which OS and app you are using (browser, text editor, ...).


Db class

Excuse me, but why are you making our coding life harder than easier? Why $OSCOM_Db-> and not for example $osc_db-> ?
$osc_db-> is much easier to remember and better for the eye.

to differentiate core class objects from normal variables


Review Pull Requests + Environments + Azure DevOps

Is your feature request related to a problem? Please describe.
Reviewing pull requests in pre-production environments is only supported via GitHub actions today.
Describe the solution you'd like
It would be awesome to support this (Static Web App Environments + Pull Requests) in Azure DevOps now that DevOps is a supported repository source for Static Web Apps.
Describe alternatives you've considered
The current alternative is to create an Azure Static Web App per environment and use multi-stage build pipelines to deploy changes through environments.
Additional context

Currently, only GitHub Actions deployments support pre-production environments.

See: https://docs.microsoft.com/en-us/azure/static-web-apps/review-publish-pull-requests

For the pull request based staging environments like GitHub, we currently can’t support them in Azure DevOps due to some differences between the platforms.
You mentioned using multiple stages in a pipeline to deploy to different Static Web Apps. Would it be useful to be able to set up the same pipeline, but instead of deploying to separate Static Web Apps, you can deploy to different environments in the same static web app? For example, you could create dev, qa, staging environments in a static web app, and you can set up a pipeline to deploy to each of those environments, then to production. We are currently evaluating whether we should support something like this.

@anthonychu That would be fine too and very similar to the deployment slots pattern we use with Azure App Service apps.
Would that be a configuration parameter on the AzureStaticWebApp task or different deployment tokens per environment?
We are looking at using NetlifyCMS and while it does 'work' many of the cool features supported by using GitHub and Netlify don't seem to be possible with DevOps/Azure.

I just spent too long trying to figure out how to 'add' environments to ASWA. Coming from App Services Land, this was very straight forward. I want to add a Dev, QA and keep my Production slot/environment on ASWA. Then I'd like to configure my pipeline to push based on typical review/approve stuff built into DevOps. Right now, I'm having to do what OP does, and stand-up distinct ASWA entities to create test environments.
One of the most important edge conditions for me, is that the API functions bindings should support slot binding. So my Azure function host has three slots ( dev, qa, production ). I'd like to bind my ASWA to a specific API slot. My QA-ASWA would be bound to my QA-Azure function host.  The interface does not permit this currently. I plan to open a separate ticket for this.

Is something new with Environments support?
We would like to continue using AzureDevOps Environments with approvals for different stages.

We've recently added support for:

named preview environments in Azure DevOps
A skip_api_build flag that allows you to deploy build artifacts without the task rebuilding the app

Please give it a try and let us know if you have any feedback.

We've recently added support for:

named preview environments in Azure DevOps
A skip_api_build flag that allows you to deploy build artifacts without the task rebuilding the app

Please give it a try and let us know if you have any feedback.

Well. Am I right, that
  - task: AzureStaticWebApp@0
    inputs:
      ...
      deployment_environment: "release"

is a fixed value "release" for deployment_environment?! Every branch (well, could depend on a condition) will be deployed to the same "release" domain?
What this issue is about is something like
- task: AzureStaticWebApp@0
  inputs:
    ...
    deployment_environment: $(Build.SourceBranchName) <---

I have tested this, does not work (as intended).

We also had the need for a Netlify-like experience, but with SWA:

create an isolated deployment for each PR
put the link to the deployment right inside the PR, so that other developers can review it easily
delete unused deployments

I expected this feature set out-of-the-box from SWA, but it seems it's missing some pieces yet. We still figured out a way to solve this problem with 2 custom pipelines:

The first pipeline builds and deploys the app and posts a comment to the assigned PR with the link to the deployment.

Link to the pipeline: https://github.com/feedm3/learning-azure-swa-devops/blob/main/.azure/deploy-preview-environment.yml
Link to the script that posts the comment: https://github.com/feedm3/learning-azure-swa-devops/blob/main/scripts/pr-post-deployment-url-to-pr.ts

The second pipeline cleans up all unused deployments. We do this by fetching all open PRs and comparing it against deployments in SWA. Every deployment that doesn't have a PR will be deleted.

Link to the pipeline: https://github.com/feedm3/learning-azure-swa-devops/blob/main/.azure/cleanup-preview-environmente.yml
Link to the script that cleans up the deployments: https://github.com/feedm3/learning-azure-swa-devops/blob/main/scripts/pr-cleanup-deployments.ts

Feel free to check out my repo with all scripts and pipelines combined. The solution has some drawbacks documented in the README. They shouldn't matter that much if everyone is aware of it: https://github.com/feedm3/learning-azure-swa-devops/


[Backport release-23.11] #273748

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin release-23.11
git worktree add -d .worktree/backport-273748-to-release-23.11 origin/release-23.11
cd .worktree/backport-273748-to-release-23.11
git switch --create backport-273748-to-release-23.11
git cherry-pick -x a3ac436cfb2d494729ad40d75e4762dc3c4de83b

Originally posted by @github-actions[bot] in https://github.com/NixOS/nixpkgs/issues/273748#issuecomment-1852102134

Tracked in #272784.


[Minor] "Anzahl der abgeglichenen Schlüssel" -> "Übereinstimmende Schlüssel" & "Anzahl der bereitgestellten Schlüssel" -> "Bereitgestellte Schlüssel"

This PR fixes a minor inaccuracy in https://www.coronawarn.app/de/faq/#keys_matches.
Only German was affected.

@Ein-Tim
For Android this article no longer corresponds to the v1.8 UI of the Google Exposure Notifications System and that affects both the English and German versions.
I will open an issue to describe what is wrong for Android.

@Ein-Tim
Please check https://github.com/corona-warn-app/cwa-website/issues/1028. If you could comment which issues also affect iOS, that would be helpful. We can then work out which changes need to be made.

I changed one more thing sin this entry (see commit https://github.com/corona-warn-app/cwa-website/pull/1027/commits/966d4ca35bc0d958b6abdb69753117d66b063aec)

@Ein-Tim Thanks.