Allow toggling heading element styles with a SASS variable.

As we have the class selectors for h1 etc, it could be handy for UI vs SEO reasons, to be able to choose if we want to style default headings or to style them with the use of the proper class
Example
//Variables.scss

$enable-style-on-heading-elements:false;
$heading-sizes: () !default;
// stylelint-disable-next-line scss/dollar-variable-default
$heading-sizes: map-merge(
                (
                        1: $font-size-base * 2.5,
                        2: $font-size-base * 2,
                        3: $font-size-base * 1.75,
                        4: $font-size-base * 1.5,
                        5: $font-size-base * 1.25,
                        6: $font-size-base * 1,
                ),
$heading-sizes
);

//type.scss

@each $abbrev, $size in $heading-sizes {
    $selector: '.h#{$abbrev}';
    @if $enable-style-on-heading-elements {
      $selector: 'h#{$abbrev}, .h#{$abbrev}';
    }
    #{$selector} { @include font-size($size); }
}

Are you looking for .h1,.h2,... classes? We already have these. This is also documented: https://getbootstrap.com/docs/4.3/content/typography/#headings

No, I am looking for an option, in order to avoid styling by default  "h" elements

You could set all your $heading-* variables to null to disable styling.

I don’t see us moving anywhere beyond the functionality @MartijnCuppens has mentioned. Always need to strike a balance on this stuff to avoid making things overly complex or less approachable for the majority of folks.


New lines are created for progressive updates rather than replacing the old ones

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Windows 10 Pro build 1703 (creators update)
Hyper.app version: 1.3.1
Link of a Gist with the contents of your .hyper.js: default
Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere): n/a
The issue is reproducible in vanilla Hyper.app: is vanilla

Issue
After updating Windows 10 to the last version (creators update) I wanted to try again hyper.app with the improved bash for window. Unfortunately it seems like progressive updates are broken, new lines are constantly created instead of replacing the old ones and even the cursor is far off its position. Since I wasn't using hyper.app from some times I first disabled all the plugins and the created a fresh .hyper.js config file, but nothing changed. I attached a screenshot to better show the problem.

I'm seeing the same issue after the creators update.

+1. For me – when using yarn. Though cursor position is stable for me.

After trying to work around the same issue I've discovered that line breaks "break" at exactly 160 terminal chars  width Hyper window regardless of font size or anything else, at least at my own PC.
I can provide screenshots or record a screencast to show apparent difference in behaviour at 159 and 160 characters (making window larger doesn't help, apparently).

I observed the same behavior as @siziyman.
I'm running on Win10 with Creator's Update. The problem doesn't show up on another Win10 PC which does not yet have the Creator's Update.

What is your $TERM variable set to?

Well, it's doing this with yarn and powershell.

Also, this seems to result in the offset console bug as well.  I have to suspect that it is an issue in the underlying hterm library.

Interestingly enough, this is only happening with the progress bar.  It does not happen with the spinner.
Given that this is also triggering the console offset bug, I suspect that it is the combination of some strange width character and clear line that causes this.

has there been any progress on this issue?

I suspect that this is going to be fixed when we finish replacing the underlying terminal library.

Same problem on PowerShell with Creator Update. It maybe Yarn issue? Does anyone report to Yarn?

I test on my working laptop. I don't have Windows laptop at my home.  😅

Related issue: yarnpkg/yarn#2530

has anyone an idea when this will be fixed?

Fixed by yarnpkg/yarn#4317. 🎉
We can wait for Yarn newer version.
Or test by grabbing the artifact from https://ci.appveyor.com/project/kittens/yarn/build/3769/job/3owvdyefkpofp10x/artifacts

@gluons Thank you for your feedback!


Rectangle entity grid size mismatch

Hello, thank you for this amazing tool!

I have two layers, one IntGrid with rules and one Entity layer.
The IntGrid layer has a grid size of 16 and the Entity layer is 8.

Snapping a rectangle entity on the 8x8 Entity layer works as expected in LDtk.

When importing into Unity, the rectangle entity is twice the size it should be.

If I change the grid size of the Entity 8x8 layer to 16 before saving...

... the imported size is correct.

Hi, I will look into this so the expected size remains. Thank you :)
For now, you can make the entity's grid size match the remaining standard of your project.

 Rectangle entity grid size mismatch

Looking at this right now, it appears to only be a visual bug; the entity gameobject scale works as expected when I checked in the Entities example, though the scene-drawn box was twice the size that this issue reported.
I will make a fix so that the editor gizmo is the expected size. But just know that it shouldn't functionally affect any of your objects in an unexpected way :)

The fix is done :)
I'll pack it in with the next minor update and post back here

Hi, the update with this fix is out! (3.3.2)
I will close this now, but feel free to reopen it if nessesary.


azure vm create: required arguments

Follow up to #585, #582, it appears like required arguments like

--image,
--admin-username

are not correctly being enforced or documented in --help.

These two parameters are not required as defaults are provided.
--image defaults to Win2012R2Datacenter as shown in --help
--admin-username is only required for Windows-based images.  For VMs with Linux-based images it defaults to the current user, which is displayed in --help

--image defaults to Win2012R2Datacenter

Why? What was the thinking behind this decision?

For VMs with Linux-based images it defaults to the current user

Why? What was the thinking behind this decision?

The default image is the most recent Windows Server image found in 'az vm image list'.
We default the admin username for both windows and linux to the current user.  This means 1) admin username is optional, and 2) the default ssh works without specifying the username (i.e. plain "ssh " works on the machine the vm was created from )

The default image is the most recent Windows Server image found in 'az vm image list'.

why is this not ubuntu and windows server?

This means 1) admin username is optional, and 2) the default ssh works without specifying the username

I guess that's fine. It might provide certain ease of use at the cost of users implicitly signing up for a username that they did not intend to use. Though I don't have data to back this up.

@BurtBiel Pinging this thread as it is important. We are going to have a problem if the default image becomes a Windows image. Linux is a first class citizen on Azure and I don't see the point of favoring one over another. If you want to discuss offline, I believe my team AzLinux@ would be open to discussion.

We're discussing possibilities here with respect to the image selection process.  Do you expect the image field would have no default (user must select it) or some other behavior?

User must select it IMHO

PR #789 merged. Closing issue.


Transparent areas turn white after export to GIF

Comes from GIF.js Need to find a workaround

Actually gif.js allows to set a transparent color. I just didn't use it properly :)
Fix incoming.

Will be released in v0.5.0


Broken source maps?

This is something I'm not sure where the problem lies in as I found it via testing yew but it appears that while a source map is generated, neither Chrome or Firefox can find it. Maybe this isn't a problem with cargo-web and might be a misconfiguration of yew. I'm building with the emscripten target and not the built-in WASM from Nightly currently (using stable Rust from Rustup)

I know it's quite old issue, but it would be nice to have simple switch to generate source maps. Here is how it's done: https://github.com/yurydelendik/old-man-sandbox/tree/master/rust-wasm-hey
The idea is to run rustc with -O -g parameters and then run esmsdk/upstream/tools/wasm-sourcemap.py with parameters  ./nested_list.wasm -o ./nested_list.wasm.map --dwarfdump C:\Users\User\Documents\emsdk\upstream\bin\llvm-dwarfdump.exe. So when cargo web build is being run it actually runs rustc, all we need is adding -O and -g parameters to rustc and after all running python script. Tested on yew framework example build with cargo-web. Unless we run cargo web with --release switch it could be default behavior. sourcemap.py has also ability to strip wasm from debug info.

I know it's an old issue but it would be nice to have an easy way to generate source-maps, there is working solution: https://github.com/yurydelendik/old-man-sandbox/tree/master/rust-wasm-hey the idea is to run rustc with -O -g parameters and then emsdk\upstream\emscripten\tools\wasm-sourcemap.py with your.wasm -o your.wasm.map --dwarfdump emsdk\upstream\bin\llvm-dwarfdump.exe . Maps load and I can see sources but still I make something wrong and I get Uncaught (in promise) TypeError: Cannot perform Construct on a detached ArrayBuffer, so wasm file can't load Maybe it's something wrong in generated JS file...?


Generators for creating new content

Generators are used for generating new items of content. Generators can be used to create a tag or category index page dynamically. A good example of this is PaginationGenerator whose responsibility is to generate multiple pages around a set of items like posts or any other collection (see #43 ).
A Generator must implement GeneratorInterface:
namespace Yosymfony\Spress\Core\ContentManager\Generator;

interface GeneratorInterface
{
    /**
     * Generate items.
     *
     * @param \Yosymfony\Spress\Core\DataSource\ItemInterface $templateItem The template item where generator was declared.
     * @param array                                           $collecions   An array with the collection name
     *                                                                      as a key and collection's item as value.
     *
     * @return Yosymfony\Spress\Core\DataSource\ItemInterface[]
     */
    public function generateItems(ItemInterface $templateItem, array $collecions);
}

Generators are performed just after Data Sources are loaded.

:+1:


HAPI-159 unit tests

Just a couple of unit tests to make sure some edge cases were covered . I also re-ordered the functions in process_config_defaults to reflect the order in which they are called, and made a change to cover the "list" default parameter.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 90.864%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
547

Relevant Lines:
602

💛  - Coveralls


Update if-else.py

Please fill in this pull request template before submitting
1. This pull request resolves #115
(^Fill in the issue number after #)
2. Description
Update  if-else.py to fix grammatical errors and clarify some of the wording, as well as adding a new example demonstrating using the equal and not equals operators.
3. Fill in checklist by marking [x]

[x] I've read the CONTRIBUTING.md
[ ] I was assigned to this issue
[x] My code is formatted using required linting
[x] I've run my code locally and checked it works

@Guy-Sowden Good suggestions. Thanks for the contribution!


How to set date in datepicker input-field

Hello @kekeh
Date picker works very good, but I have a silly question :(
How can I set default date in date picker input field?
Thanks

Hello @joshi-anshul
You have to use ngModel to set initial date. Set javascript date object or mydate object to ngModel. Here is an example: https://github.com/kekeh/angular-mydatepicker/wiki/initialize-date-model-(single-date-mode)
Check the ngOnInit() method. It shows both of above methods.

@kekeh thanks a lot


feat(application integration): Add oidc token sample for creating auth configs

Description
Add oidc token sample for creating auth configs
Fixes: b/344572436
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness

[* ] Yes, merge this PR after it is approved
[ ] No, don't merge this PR after it is approved

Style

[ *] My sample follows the rules described for Terraform in the Effective Samples style guide
[ *] My sample follows the other requirements and best practices in the Contributing
guide

Testing

[ *] I have performed tests described in the Contributing guide:

[* ] Tests pass: terraform apply
[ *] Lint pass: terraform fmt check

Intended location

[ *] Yes, this sample will be (or already is) included on cloud.google.com
Location(s):  https://cloud.google.com/application-integration/docs/configure-authentication-profiles#terraform

API enablement

[ ] If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

[ ] If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

/gcbrun

Integration tests failed with the following message:
Error: Error creating AuthConfig: googleapi: Error 400: Failed to generate OIDC ID token of the
service account. Reason: IAM permission denied for service account
<EMAIL_ADDRESS> Please ensure
that<EMAIL_ADDRESS>has been granted
'Service Account Token Creator' permission.

(wrapped for readability)
Previously in https://github.com/terraform-google-modules/terraform-docs-samples/pull/658/ we were iterating on this, but this PR doesn't include any IAM resources. Can you confirm what permisions are needed and add them to this PR? Thanks!

/gcbrun

/gcbrun

/gcbrun

/gcbrun

CICD seem failed with the error reported @ https://github.com/terraform-google-modules/terraform-docs-samples/pull/689#issuecomment-2159706440

@pay20 - PTAL with provided comments.

/gcbrun

/gcbrun

cl/657845149


Type errors for operators that return ConnectableObservable

Bug Report
Current Behavior
Operators that return ConnectableObservables (ex: multicast, publish, publishBehavior, etc) lead to type errors when used in V6 with the pipe function.
Reproduction
const connectable = of(1, 2, 3, 4).pipe(multicast((new Subject<number>())));

connectable.subscribe();

connectable.connect();

The type error occurs on the last line when calling the connect() method:
[ts] Property 'connect' does not exist on type 'Observable<number>'

Because the pipe function expects to return an Observable type but the operator is actually returning a ConnectableObservable with additional methods.
Expected behavior
Expect that pipe could infer the return type based on the operators.
Environment

Runtime: Node
RxJS version: 6.x

Possible Solution
Seems to me the pipe function needs to be able to infer its return type instead of assuming it will be a plain Observable? Or maybe I am just missing something (if so I'd love to know :) )

This is an unfortunate limitation of TypeScript.
You can work around this with a cast:
const multicast$ = source$.pipe(multicast(new Subject<number>())) as ConnectableObservable<number>;


[contracts] Fix onlyOwner on enrollReplica

Removed the onlyOwner modifier from the enrollReplica function for testing, need to add that back now

It's been fixed with 4f5cc7cc074475f20bfef401ddcb929a0508920b and will be merge to amarok when we finish with https://github.com/connext/nxtp/issues/900


Parallel merkle verification

Parallel computation of subtrees (starting at each proven leaf).

Possible implementation:

Store map of leaf -> channel when initializing the verifier.
Split out the proof nodes each subtree requires and its height.
Start a go routine for each leaf that sends the root of the subtree on the relevant channel.
Read from the channel whenever that node is needed.

Obsolete.


Adjust string translation for Chinese localization

This PR also reorders the entries in the strings table.

The English-language changes look good to me.  The Chinese localization I can't comment on as I don't speak Chinese.

@xiangpengzhao All comments addressed.

sorry for delay :)
/lgtm
/approve


Update geometric.js with Math.round

use Math.round instead of Math.floor for floor makes small increments rounded back to zero.

Looks like this is duplicated by #131.

@ljharb yep, i failed to pull this onto my laptop and closed this.

@zhoutuo np :-) if that happens in the future, please ping me on slack and i can walk you through how to fix it

@ljharb took a while that i dont have access to origin and all that. :)


How to stop an Express script command without stopping the express server?

Hey all,
I'm working on a BB-8 desktop app using electron. I noticed that if I send the disco (or any custom) command to the Express server, the script never stops executing.
If I use process.exit(), the Express server stops. (I'm new to Node.js). I found one blog post that talks about throwing an exception, but not sure if/where that can be handled gracefully.
// disco.js
module.exports = function (bb8) {
    console.log('Let\'s Party!!');

    bb8.randomColor();

    setInterval(function () {
        bb8.randomColor();
    }, 1000);

    setTimeout(function () {
      process.exit();
    }, 2000);
};

Is there any other way to end the custom commands after a given time without fully disconnecting from the Express server?

P.S. for the electron app, I haven't figured out the navigation system yet. Every time he moves, it seems his internal "true north" changes to a new 0 degree orientation. E.g. his head is always in the wrong position, looking like he's moving backwards. And 90/270 turns are never what I expect them to be. I'd :heart: any ideas!

Hey I'll take a look at this sometime this week. I think I've got an idea of how to solve it just need to try it out. Would you be happy with a command called "stop" or something that stops the command but keeps the connection and server running.
Not sure throwing an error is the best idea because you would have to catch the error otherwise the script stop running.
Sent from my iPhone

On 31 Jul 2016, at 02:01, Sara Ford<EMAIL_ADDRESS>wrote:
Hey all,
I'm working on a BB-8 desktop app using electron. I noticed that if I send the disco (or any custom) command to the Express server, the script never stops executing.
If I use process.exit(), the Express server stops. (I'm new to Node.js). I found one blog post that talk about throwing an exception, but not sure if/where that can be handled gracefully.
// disco.js
module.exports = function (bb8) {
console.log('Let's Party!!');
bb8.randomColor();

setInterval(function () {
    bb8.randomColor();
}, 1000);

setTimeout(function () {
  process.exit();
}, 2000);

};
Is there any other way to end the custom commands after a given time without fully disconnecting from the Express server?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Also as for the true north issue I believe there is a function on the bb8 object that allows you to change the tracking/heading. (Can't remember the terminology).
Sent from my iPhone

On 31 Jul 2016, at 04:39, Sara Ford<EMAIL_ADDRESS>wrote:
P.S. for the electron app, I haven't figured out the navigation system yet. Every time he moves, it seems his internal "true north" changes to a new 0 degree orientation. E.g. his head is always in the wrong position, looking like he's moving backwards. And 90/270 turns are never what I expect them to be. I'd ❤ any ideas!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Would you be happy with a command called "stop" or something that stops the command but keeps the connection and server running

Yes! That would be perfect! :bow:
I tried to create a command called stop that called process.exit(); but that killed the server. As you said, I want to keep the connection active and the server running, but just stops the command.

there is a function on the bb8 object that allows you to change the tracking/heading.

there's bb8.setHeading() but not sure what's the correct combination of setHeading() and roll() to make what seems like a right-hand turn (hence my BB-8 desktop cmdr app to speed up calling commands).
E.g. if I want BB-8 to roll straight ahead with his head pointing straight ahead, I'd guess I'd call
bb8.setHeading(0);
bb8.roll(2,0);

Now if i want BB-8 to turn right, do I set the new heading to the "same" 90 degrees on both? e.g.
bb8.setHeading(90);
bb8.roll(2,90);

or do I only set the new heading once? e.g.
bb8.setHeading(90);
bb8.roll(2,0); // because bb-8 is now already pointing 90 degrees??

What's I've been currently experimenting with (which isn't working as I want) is the following:
bb8.roll(0,90);
bb8.roll(2,90);

Hey sorry I've not updated you on this. Been a bit busy with stuff. I've got a solution half written and plan on getting it finished this weekend. Basically going to return the setInterval ID to the express executer and keep a reference to the ID's when you send stop. It will then stop the BB8 Unit command but not the server. just got some edge cases to solve.

@mintuz Hey! :wave: Thanks for the update! No worries! I've also been busy with other projects, but I really appreciate you looking into this! :smile:

This has now been resolved via https://github.com/mintuz/BB8-Commander/pull/26


fix: change container/columns default Margin value [ALT-1388]

Purpose
Changes the Container and Columns default margin value back to 0 0 0 0 and added a comment to mention that the UI overrides the value to 0 Auto 0 Auto when these components are added at the root/top-level

Why are we doing this? And why is the UI not just applying this defaultValue? I feel like there is a good reason but I can't remember

@ryunsong-contentful, When you drop a new Columns or Container component on the canvas, the ComponentAddedAction in the UI calls applyNodeModifications() and if the component is dropped on the root level it will override the defaultValue from the component definition with 0 Auto 0 Auto to set left/right margin auto.
We need the defaultValue to be 0 0 0 0 for these two components here so that when that override doesn't occur on the UI side (such as dropping these two components into a nested structure instead of the root level) it will not add the left/right margin auto.


Day of the Programmer

Marie invented a Time Machine and wants to test it by time-traveling to visit Russia on the Day of the Programmer (the 256th day of the year) during a year in the inclusive range from 1700 to 2700.
From 1700 to 1917, Russia's official calendar was the Julian calendar; since 1919 they used the Gregorian calendar system. The transition from the Julian to Gregorian calendar system occurred in 1918, when the next day after January 31st was February 14th. This means that in 1918, February 14th was the 32nd day of the year in Russia.
In both calendar systems, February is the only month with a variable amount of days; it has 29 days during a leap year, and 28 days during all other years. In the Julian calendar, leap years are divisible by 4; in the Gregorian calendar, leap years are either of the following:

Divisible by 400.
Divisible by 4 and not divisible by 100.
Given a year, y , find the date of the 256th day of that year according to the official Russian calendar during that year. Then print it in the format dd.mm.yyyy, where dd is the two-digit day, mm is the two-digit month, and yyyy is y.

For example, the given  year = 1984. 1984 is divisible by 4, so it is a leap year. The 256th day of a leap year after 1918 is September 12, so the answer is 12.09.1984 .
Function Description
Complete the dayOfProgrammer function in the editor below. It should return a string representing the date of the 256th day of the year given.
dayOfProgrammer has the following parameter(s):

year: an integer

Input Format
A single integer denoting year y.
Constraints
1700 <= y <= 2700
Output Format
Print the full date of Day of the Programmer during year y in the format dd.mm.yyyy, where dd is the two-digit day, mm is the two-digit month, and yyyy is y.
Sample Input 0
2017

Sample Output 0
13.09.2017

Explanation 0
In the year  y = 2017, January has 31 days, February has 28 days, March has 31 days, April has 30 days, May has 31 days, June has 30 days, July has 31 days, and August has 31 days. When we sum the total number of days in the first eight months, we get 31 + 28 + 31 + 30 + 31 + 30 + 31 + 31 = 243. Day of the Programmer is the 256th day, so then calculate 256 - 243 = 13 to determine that it falls on day 13 of the 9th month (September). We then print the full date in the specified format, which is 13.09.2017.
Sample Input 1
2016

Sample Output 1
12.09.2016

Explanation 1
Year y = 2016 is a leap year, so February has 29 days but all the other months have the same number of days as in 2017. When we sum the total number of days in the first eight months, we get 31 + 29 + 31 + 30 + 31 + 30 + 31 + 31 = 244. Day of the Programmer is the 256th day, so then calculate 256 - 244 = 12 to determine that it falls on day 12 of the 9th month (September). We then print the full date in the specified format, which is 12.09.2016.
Sample Input 2
1800

Sample Output 2
12.09.1800

Explanation 2
Since 1800 is leap year as per Julian calendar. Day lies on 12 September.

I want to solve it using python

Hi can you assign me this issue ? I would like to solve it in C++


Django 3 is broken

Django 3 support is broken.
In Django 3: https://docs.djangoproject.com/en/3.0/releases/3.0/ there has been a backwards incompatible that from django.utils.http function cookie_date was removed. Therefore projects using this app are unable to upgrade to Django 3.
There is an easy fix to replace cookie_date with http_date which is in the same file.

There are already 3 pull requests to fix this problem: #90, #97 and #99


feat: rating can be given only after login

Title and Issue number

Title :Unlimted rating and feedback can be given by one person
Issue No. : #684
Code Stack :
Close #684

Description
A person can give feedback only after login .
Video/Screenshots (mandatory)

Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist:

[x] I have performed a self-review of my code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have gone through the  contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

[x] I am contributing under GSSOC'24
[ ] I am contributing under VSOC'24

@cecily-mee I have checked the code, but can u provide a video of the updation u have made?? like the user only will be able to give rating after she/he successfully logged in

i had forked the old version and hence pushing in all the changes together is not working since i recently cloned new version . so i made changes and made seperate prs

@cecily-mee make all the changes in one single PR ASAP maybe right now & submit it as a pr before 7 pm ....So that I can review the code & be able to merge the changes & also please try to add a video of your improvements


module's default branch different than master

If you leave out the branch, it will default to the module’s default branch, usually master.

This is the case when importing a module but not on x/
Edit : importing module also doesn't work when master doesn't exist.
For example, on my github my main branch is latest and there is no master branch.
The site should take the main branch and not master.
<EMAIL_ADDRESS>works
https://deno.land/x/remove_forever don't
Edit : I created the master branch so my example isn't relevant anymore but the issue is still there

Use the default_version option in database.json to choose which branch the module should default to.

I'm gonna stay in the master branch , so it's just cosmetics.


New Feature: Homonyms

Normally, words are assigned Glish syllables in an injective way. So, when a new word would be assigned to a syllable that has already been mapped to by a previously-assigned word, the new word is instead assigned to a worse syllable. This feature skips this check, allowing a non-injective mapping of words to syllables i.e. allowing Glish to have homonyms. This variant of Glish can be called "Ing" (as that's what "English" is translated to in this variant). The idea here is to trade distinctness of syllables for more ideal word-to-syllable correspondence. This is probably a worthwhile trade-off since English and many other language already trade semantics-to-(written or spoken)word injectivity for shorter/simpler words.

Cool PR, thanks a lot for making this! I'd be curious just how many homonyms this actually makes, but fundamentally I'd expect this is probably much more intelligible than the current glish :D
I think at some point I'll make a way for the website to show different glish variants & updates, so we can merge PRs like this and others without overriding the version of glish that matches the video.


Add deep-blame feature

Closes #2876

I need to know how I should link it.

I think

add tooltipped class to tell the user they can alt-click
add alt-click handler

What if the is no link there to go back? (There is no icon since there is no direct change for that line)
Just make a regular click?

What if the is no link there to go back?

I think we have to add the icon and yes, make it a regular click

Messy code...
@fregante something like this

I will add the loading later

@fregante something like this

How would that work?

@fregante something like this

How would that work?

Click the button and it loads the commits

@fregante can you explain to me where the user is clicking??

For example

Where is the user clicking alt??? If there is a link there I can add an alt, if not then.....

On blame page, add "deep blame this commit" button on each commit that has a PR link in its title

If there’s already a “prior blame” button, use alt-click on it
If there’s no button, add it

@fregante I should add a button even if there is not linked pull request? (so the link will do nothing)??

That is why I added a button and then it will load all and add the links.

My reasoning is that blame pages could have dozens of commits so the query could be very large. Also because this feature isn’t meant to be used that frequently, so even if the query is light, it would be useless.

That is why I added a button so only then will it load.
Sorry for getting so frustrated, I would love to see my hard work go through and I am not understanding what is wrong.

That is why I added a button so only then will it load.

But in the user’s eyes that button does nothing and maybe it really does nothing (if no PR commits exist on the page).

@fregante I should add a button even if there is not linked pull request? (so the link will do nothing)??

We only add the button if a PR number is in the title, so we have some degree of certainty that the commit has an associated PR. If that doesn’t work, we use an alert saying “No PRs associated with this commit” or something like that

Understand. I am changing the implementation anyways but that button would have not shown if there were no pr's

@fregante can you give me some feedback? I tried my best (I promise).
I should cache.function the commit right?

Test on https://github.com/yakov116/TestR/blame/master/asf

@fregante I will be away from my computer until tomorrow night.
I will try to update then

@fregante is there a way to load all the commits from cashe and if the commit is there and the commit does not exist then dont show the icon?

That’s what the first version was, we’ve been through that already.
I think we shouldn’t consider cache that much, other than for the current session. These actions are very rare (they are per file and per commit)

That’s what the first version was, we’ve been through that already.
I think we shouldn’t consider cache that much, other than for the current session. These actions are very rare (they are per file and per commit)

How do I add cache for only that session?

I forgot to attach this...
I switched the alert to this. Is this good? Or should I go back to alert?

That only appears at the top; the user might have scrolled down already.
And no, don't scroll up to it, the user will lose their position on the page.

How do I add cache for only that session?

Use mem instead of cache.function. My point was that the action is so infrequent that cache is nearly useless.

It freezes the browser in Firefox, crashing all extensions

It freezes the browser in Firefox, crashing all extensions

See Im talented.
What could be causing it? Github sometimes takes its time to respond

@fregante what did you do to get it to freeze? I tried it.

@fregante looks like if I add an href github replaces the ref with a direct link to the same line. breaking the entire feature

@fregante what did you do to get it to freeze? I tried it.

Visit /source/features/link-to-file-in-file-history.tsx@0ca864a#L29 (blame)
Click deep reblame

Same happens in Chrome, here's where it's looping:

Same happens in Chrome, here's where it's looping:

What would be the issue?

It's an infinite loop

I need help how to debug it

I think I got it. The .click() is triggering the delegate event, which tries the redirect via .click(), which triggers the redirect, etc.
Let’s undo my earlier suggestion and instead change page via location.href

This will also let you use <button type=button>

This will also let you use <button type=button>

And Remove the href right?

🙌

Wow never thought this would happen. Thanks for keeping with me! (while I have to work from home and I very busy as you can see)

https://github.com/sindresorhus/refined-github/blame/fad67fb8d8fcf608601c9b8ae1b5f12337cbccce/source/options.html#L1
This button points to a 404


Mongo driver is missing remove(opposite for insert)

There is insert but not remove. It internally uses this._run('remove') but that cannot be accessed from migration scripts.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/12580273-mongo-driver-is-missing-remove-opposite-for-insert?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github).

This is redundant to #213, please see and join the discussion there


Make sure forum post data and counts match

Filter the blocked/muted users after the query so that the correct posts are returned via the API.
https://github.com/jocosocial/swiftarr/issues/138

Looking at this now. I think the comment may be wrong. At any rate, filtering blocks in the query is what we want to be doing. It may still be the case where we have to filter some posts out after the query, but that's for cases where it's difficult to make the query do the right thing.


Update README.md

We created a logo to help the clarify the difference between js-ipfs and js-ipfs-api. Would you like to add to your client library as well? You can see how it looks here: https://github.com/ipfs/js-ipfs-api
This design is from @akrych 🌟

Thanks. Please be aware that I'm currently not maintaining this unfortunately. :(

Thank you @Fryie! Could open an issue to look for other volunteers? Perhaps @kyledrake would like to jump in :)

we have this already: https://github.com/Fryie/ipfs-ruby/issues/1
I also remember that there was some other person who was working on an alternative implementation for Ruby, unfortunately I don't remember who it was or what the name of the repo is. Maybe there is more progress there.

found it: https://github.com/hjoest/ruby-ipfs-api
It seems to do more than this current gem and was last updated in February. Maybe you can have a look at it, if so, I can discontinue this gem and link to the other one instead.


Make SFML use ELF visibility

SFML currently doesn't use ELF visibility. Follow the link if you wonder why using it could be good.
Making the library use the feature is dead simple, as it boils down to defining SFML_API as __attribute__((__visibility__("default"))) on Linux and FreeBSD systems that have GCC >= 4.0.0 and compiling and linking everything with -fvisibility=hidden there.
No issues are expected, as Windows' dllexport mechanism is quite similar and SFML works on Windows.

This looks and sounds like a great idea. Simple to implement, and provides nothing but benefits (as far as I can see).

Oh, so Mach-O does support visibility, too? I thought it's ELF specific, but apparently 私が間違っていた。
Anyway, I'd rather use __attribute__((__visiblity__("default"))) (see the two additional pairs of underscores?) to prevent some funky macro from third-party code from kicking in. It's simply safer (and uglier, but it's ugly anyway and it's hidden behind a macro anyway).


Standalone launcher - issue with instance down

Once Standalone launcher is used for instance up command
 java -jar gap.jar down

dosn't work
$ java -jar gap.jar down

> Task :instanceDown
No instances to turn off.

AEM instance related properties need to be passed to launcher always.
they could be provided via CMD line or gap/gradle.properties file.
if they are passed via CMD, maybe GAP launcher could write them to gradle.properties automatically, then reuse... maybe only when launcher used executed with --init-properties arg?
I think that it would be useful, then down task without parameters specified again will work.

done


Please make it available on Polars as well Pandas 2.x

First of all, thank you for creating such a wonderful package.
I was able to quickly understand the characteristics of the data using skim in R, and thank you for making it possible in Python as well.
Polars in the DataFrame package has been growing rapidly in popularity recently.
You can use the skim function in Polars using the to_pandas() function.
However, it would be better if polars was supported directly in pyskim.
Also, Pandas has been updated to version 2.x, but if you install pyskim, the Pandas version will be downgraded. It would be nice if Pandas were also updated to support 2.x.
Thank you

Very happy to hear the package was useful to you, and thanks a lot for the comment.
I pushed a new package version with updated dependencies.
Supporting Polars would indeed be a great addition! Unfortunately, I don't have the capacity to implement these changes right now. Will certainly consider doing so in the future. In the meantime, I am of course happy to accept PRs.

Thank you for your quick reply.
I think supporting Polars dataframes is simple.
You can convert to Pandas using Polars' to_pandas() function.
(You can use the skim function to convert the polars data frame to to_pandas().)
I think I can change the source to use the to_pandas() function in the case of the polars data frame within the skim function.
Thank you

You can use the skim function to convert the polars data frame to to_pandas()

That's definitely a good intermediate solution. Later on, polars dataframes should also be supported natively (better performance, etc).

I think I can change the source to use the to_pandas() function in the case of the polars data frame within the skim function.

Sounds very good!


Request timeout when request is sent just after starting runner [Flaky]

When a gauge api which requires runner is called right after starting gauge in daemon mode, sometimes the request times out. The error message is as follows
Error while connecting to runner : Request timed out for Message with ID => 3 and Type => ImplementationFileListRequest

Expected behavior
Request should not timeout
Actual behavior
Sometimes request is timing out when the request is sent right after starting gauge in daemon mode, if we add 10ms of sleep this does not occur
Steps to reproduce

open gauge-lsp-tests on branch stubimpl
run command: gauge run specs/generateStubs/generateStubs.spec:10

Gauge version
Gauge version: 0.9.8
Commit Hash: 506987e

Plugins
-------
html-report (4.0.3)
java (0.6.6)
js (2.2.0)
python (0.2.6)
ruby (0.4.3)
screenshot (0.0.1)
xml-report (0.2.0)

Working as expected
Gauge version: 0.9.9.nightly-2018-05-04
Commit Hash: 886dc10

Plugins
-------
js (2.3.0.nightly-2018-05-04)


Update zio-test, zio-test-magnolia, ... to 2.1.4

About this PR
📦 Updates

dev.zio:zio-test
dev.zio:zio-test-magnolia
dev.zio:zio-test-sbt

from 2.1.1 to 2.1.4
📜 GitHub Release Notes - GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #81.


Feat/text filter plus or delimiter

This PR contains

[ ] Bug fix
[x] Feature
[ ] Refactor
[ ] Documentation
[ ] Other (describe)

What is the purpose of this PR?
To add the ability to OR on values using a delimiter in text-filter-plus
...

Wrong base


✨ Estimated Success Probability (ESP)

This PR introduces a new figure of merit: estimated_success_probability
It is a slightly modified version of the original metric where only the dominant decoherence term min(T1, T2) is accounted for.

@nquetschlich do you think it is possible the ImportError: cannot import name 'FakeGuadalupe'  is due to the qiskit update?

I'd also like to take a look at this before it is merged.

For some reason the Ubuntu job seems to time out here. Which is really strange to me. What is talking 6 hours here?
@nquetschlich @flowerthrower any idea?

For some reason the Ubuntu job seems to time out here. Which is really strange to me. What is talking 6 hours here? @nquetschlich @flowerthrower any idea?

I could imagine that the (very short) RL training during the test led to a trained RL model that very much likes optimization passes and infinity loops. I re-started the check and now it looks better.


Trouble importing some character sheets into an existing actor for them

[Archive.zip](https://github.com/crnormand/gurps/files/9440656/Archive.zip)

When I import in a fresh empty new actor, it works. But next import fails. After that, I cannot open that actor's sheet until I relaunch. Archive has the .gcs files.

I've put in some protection code to allow the actor to get past this situation (where it couldn't recognize the maneuver stored in the actor).   If another error pops up, let's create a new issue.


393 remove freemium from docs

issue https://github.com/inductiva/tasks/issues/393
This PR removes the freemium reference from our docs.
After the merge to main we should merge to dev.

but this PR is including all the changes in development, no? Can you make a PR just with this small changes to the docs?

Close for this https://github.com/inductiva/inductiva/pull/1619


Test mod

Self explanatory, a mod set up to test against any TaterLib features on a test server (with some sort of smart CI/CD implementation)

Along-side this, a test server that runs TaterLib mods/plugins 24/7


brew install quaa - Quick UAA on Tomcat

Got 5 mins to try something?
cd /usr/local/Homebrew/Library/Taps/starkandwayne/homebrew-cf
git pull
git checkout uaa-tomcat
brew install quaa

quaa up

Then in another terminal:
quaa auth-client
uaa clients

I may switch the primary asset/version to quick-uaa-local/1.0.0 and move the uaa war into a brew resource


[ISSUE #2726] retrying by customizing response code

Make sure set the target branch to develop
What is the purpose of the change
retrying by customizing response code #2726, users can control retrying by themselves
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.1%) to 51.884% when pulling d6da221d869e276459c8f81a024164711b1f9d8e on wz2cool:master into e9b2d8522df084a0f8c19eb56e91d6d61bcb673b on apache:develop.

Huoc


Scam Thread Submission

Duplicate Submissions

[X] Yes, I checked that the name is not currently in the list
[X] I read the wiki explaining each different categories and examples before submitting

(Required) Spam Comment Direct Link
https://www.youtube.com/watch?v=uEBT74A_710&lc=UgygORR2EQ_oR5mogDV4AaABAg.9gvl9Nj1jZM9gvsMf2QrIL
(Optional) Screenshot of comments referencing the scammer names

(Required) List of the scammer names
peter lynch

Added


Pdf between dates

Rewrote pdf.py such that it accepts a set of dates to return data between those dates. Also added test cases to test the code and its edge cases.

Changes look good merged into addedfeatures101


Clicking the Train Button Should immeadietly show train animation

Right now it feels like the train button submits the training data, but the button isn't disabled and the training animation doesn't start until the agent status is updated to come back with a status of training. This works well locally, but remotely or when the polling of status is slowed this causes the user to not think training has begun and to try and click the button again.

Even then, it seems that you need to refresh the page. Then hit the training button again, and its completed.

@RussellSPG this is in relation to something I was seeing on master, not on 0.11.1. Can you explain your problem in more detail?
You should never have to refresh the page and never hit the training button more than once. if you do then you need to log an issue/bug.

Sometimes When I hit the training button sometimes it just hangs showing the waiting even 10+ minutes. So If I hit the refresh button it will show its training, and be completed within 2-4 seconds

Fixed with aafc80c76885a17de05164dc4d259efb9d0728e2


plugin cause j/k position incorrect

Current behavior:

Desired behavior:

Hey @defpis! I can't quite reproduce this:
https://github.com/JoosepAlviste/nvim-ts-context-commentstring/assets/9450943/b8d4e047-8047-42b9-93f0-e48af909755c
What exact keys are you pressing for the examples?
Could you create a minimal reproducible config using the minimal config? https://github.com/JoosepAlviste/nvim-ts-context-commentstring/blob/9bff161dfece6ecf3459e6e46ca42e49f9ed939f/utils/minimal_init.lua

Thanks for taking the time to check out the problem, any help would be appreciated.
There is minimal config:
local options = { -- :help options
  backup = false, -- Don't create a backup file
  clipboard = 'unnamedplus', -- Allow NeoVim to access system clipboard
  conceallevel = 0, -- Make `` visible in Markdown files
  fileencoding = 'utf-8', -- Use `utf-8` as encoding
  hlsearch = true, -- Highlight all matches on previous search pattern
  ignorecase = true, -- Ignore case in search patterns
  mouse = 'a', -- Allow the mouse to be used in NeoVim
  showmode = false, -- Hide NeoVim modes in the status bar
  showtabline = 2, -- Always show tabs
  smartcase = true, -- Ignore `ignorecase` if search pattern contains upper case characters
  smartindent = true, -- Make indenting smarter on newline
  splitbelow = true, -- Force all horizontal splits to go below current window
  splitright = true, -- Force all vertical splits to go to the right of current window
  swapfile = false, -- Don't create a swapfile
  termguicolors = true, -- Set term gui colors
  timeoutlen = 1000, -- Time to wait for a mapped sequence to complete (in milliseconds)
  updatetime = 300, -- Faster completion (4000ms default)
  writebackup = false, -- If a file is being edited by another program (or was written to file while editing with another program), it is not allowed to be edited
  expandtab = true, -- Convert tabs to spaces
  shiftwidth = 2, -- The number of spaces inserted for each indentation
  tabstop = 2, -- Insert 2 spaces for a tab
  cursorline = true, -- Highlight the current line
  cursorlineopt = 'number', -- Hightlight the current line number
  number = true, -- Set numbered lines
  relativenumber = true, -- Set relative numbered lines
  signcolumn = 'yes', -- Always show the sign column, otherwise it would shift the text each time
  wrap = false, -- Display long lines as one
  scrolloff = 8, -- Minimal number of screen lines to keep above and below the cursor
  sidescrolloff = 8, -- Minimal number of screen columns to keep left and right the cursor
  cmdheight = 1, -- More space in the neovim command line for displaying messages
  pumheight = 10, -- Make popup menu smaller
  background = 'dark', -- Tell NeoVim what the background color is
  laststatus = 3, -- Use global statusline
}

for key, value in pairs(options) do
  vim.opt[key] = value
end

local lazy_path = vim.fn.stdpath('data') .. '/lazy/lazy.nvim'

if not vim.loop.fs_stat(lazy_path) then
  vim.fn.system({
    'git',
    'clone',
    '--filter=blob:none',
    'https://github.com/folke/lazy.nvim.git',
    '--branch=stable',
    lazy_path,
  })
end

vim.opt.rtp:prepend(lazy_path)

require('lazy').setup({
  {
    'gbprod/yanky.nvim',
    config = function()
      require('yanky').setup({
        preserve_cursor_position = { enabled = true },
        highlight = { on_put = false, on_yank = false },
      })
    end,
  },
  {
    'phaazon/hop.nvim',
    branch = 'v2',
    config = function()
      require('hop').setup({ keys = 'etovxqpdygfblzhckisuran' })
    end,
  },
  -- {
  --   'numToStr/Comment.nvim',
  --   config = function()
  --     require('Comment').setup()

  --     -- local ft = require('Comment.ft')
  --     -- ft.set('json', { '// %s', '/* %s */' })
  --   end,
  -- },
  {
    'kylechui/nvim-surround',
    config = function()
      require('nvim-surround').setup()
    end,
  },
  { 'nvim-treesitter/nvim-treesitter-textobjects', dependencies = { 'nvim-treesitter' } },
  {
    'nvim-treesitter/nvim-treesitter',
    dependencies = { 'JoosepAlviste/nvim-ts-context-commentstring' }, -- FIXME: May cause j/k position incorrect
    config = function()
      require('nvim-treesitter.configs').setup({
        ensure_installed = {
          'lua',
          'typescript',
          'tsx',
          'javascript',
          'html',
          'css',
          'scss',
          'json',
          'jsonc',
          'yaml',
          'markdown',
        },
        incremental_selection = {
          enable = true,
          keymaps = {
            init_selection = '<Leader><CR>',
            node_incremental = '<CR>',
            node_decremental = '<BS>',
            scope_incremental = '<Leader><CR>',
          },
        },
        textobjects = {
          select = {
            enable = true,
            lookahead = true,
            keymaps = {
              ['af'] =<EMAIL_ADDRESS>              ['if'] =<EMAIL_ADDRESS>              ['aa'] =<EMAIL_ADDRESS>              ['ia'] =<EMAIL_ADDRESS>            },
          },
        },
        context_commentstring = { enable = true },
      })
    end,
  },
})

both terminal and vscode cursor can't move correct position.

Thanks for the minimal config!
I tried it out, but still can't reproduce the issue:
https://github.com/JoosepAlviste/nvim-ts-context-commentstring/assets/9450943/c0eb3a47-9009-4532-8059-6445143612ff
To be honest, I don't have any ideas as to what might be going wrong 😕 Maybe we could get someone else to try to reproduce it?
I don't think that this plugin should affect j/k in any way as it just sets up an autocommand on CursorHold and that's it. Maybe there's something outside of Vim that's affecting it somehow?

Thank you. There may be a problem with my computer environment. I try to find the reason by myself, I close this issue.

Can we reopen this please?
This is sensitive to updatetime. I can reproduce this with updatetime=100 and holding on an intermediate line for more than 100ms.

Hey! I was able to reproduce this now, when using the CursorHold autocommand. It looks like setting an option inside CursorHold is causing the issue, e.g., here:
https://github.com/JoosepAlviste/nvim-ts-context-commentstring/blob/ead792ccdace6a9d64a8119909af243ed0105465/lua/ts_context_commentstring/internal.lua#L89
I did a quick search, but couldn't find any other issues or questions about this behaviour, so I unfortunately don't have a good solution for this yet.
I can recommend using a commenting plugin integration, though, and disabling the autocommand like described in the integrations wiki page: https://github.com/JoosepAlviste/nvim-ts-context-commentstring/wiki/Integrations


Do not inline the version string

Few will be aware of the constant inlining done by javac so this may hurt some library authors (though outside of that few should be affected by the constant inlining). Plainly appending .toString() makes so javac does not inline the string, meaning that the version string can be used to obtain the runtime version of libGDX, not the version used to compile the library with.
Note: Obviously this won't retroactively affect older binaries, so older libraries that are compiled with older versions of libGDX may still display this anomaly
Given that the JIT compiler should inline the constant anyways (even if javac doesn't) and this field is to be outside of hot code anyways performance is not a concern. I do not expect any regressions even with non-desktop environments, but have not tested them.

What situations does this affect? The one place I have seen Version used is in gdx-liftoff, on this line and on a few others in the repo. There it is used to match a generated project's version with the version of libGDX that Liftoff was compiled with, since there's no way Liftoff can know if a future release will be 1.12.2 or 1.13.0 (or 2.0.0!). From what I can tell, Version.java exists to allow code that depends on libGDX to know what version is being depended on. I don't know what the effects of constant inlining are in this case, nor if some versions of Java may inline .toString() on final immutable classes such as String.

So... I'm not quite clear here. When building with Gradle, there's one version of each dependency that gets used, right? I can run gradlew core:dependencies and see what version was chosen, and what versions may have been overridden. How could constant inlining from a version that isn't actually being used affect the version that is being used?

When doing ./gradlew compileJava, the produced *.class files have the VERSION constant inlined. That is if my library does something like
metrics.setLibraryVersion("libGDX", com.badlogic.gdx.Version.VERSION);

then after compilation with libGDX 1.12.1 on the compile classpath, the *.class file will have the following content:
metrics.setLibraryVersion("libGDX", "1.12.1");

the problem here is that at runtime (so quite a bit after compilation), this may no longer hold true.
So if the javac in libGDX can inline the assignment expression to VERSION to a ConstantValue, then so can the javac executable for other projects (including libraries).

Some Java compilers will remove the .toString() and inline, because String::toString returns itself which is still a constant value.
I could in theory see a use for not inlining so a library could call different methods for backwards compatibility or something, but it's super niche and not common as far as I'm aware.
Also, the value is still accessible at runtime even if inlined (for example via reflection), but that's a can of worms not worth the effort for this.

Which java compilers remove the .toString()? 99% of optimization occurs during JIT, not during class compilation. And most importantly, are those compilers used to compile libGDX? I don't think we are using GCJ, Eclipse compiler, janino or any other obscure compiler here that might as well do these optimizations.
I could of course deprecate the field for removal and mandate access be done via a method instead (in fact that was what I first suggested over at discord), but that comes with it's usual problems of changing nothing to people that ignore deprecation warnings. We could of course do more "expensive" calculations that cannot be inlined but that is nonsense too.

Whatever Android Studio is using inlines it, it actually complicated a few tests for me in the past.
The question is how big is the benefit from this?
As of now, I don't see enough of a reason to change the status quo.

As long as just the compiler used by the IDE but not the compiler used by gradle or maven removes .toString(), all is good.

for beginners or people that have switched to java recently
So, not library authors, hopefully. I'll see what happens if I make a single commit of anim8-gdx (which uses a rather old libGDX version for compatibility) store and print Version.VERSION, then depend on that from a current project.


Create workflows filtering Autcompletion component

This component can suggest and autocomplete the Query that user is typing, the following is currently supported:

looks at the current cursor and relevant chunk to autocomplete
understands the type of the chunk to autocomplete: search attribute, logical operator, relation operator, value
suggest the relevant options for autocompletion, such as search attributes, operators, a value for some types of search attributes, such as a current Date value for search attributes of type datetime, etc.

Next to add to this component:
Improved UX, add full keyboard navigation, improved styling
Below are few examples
Filtering and suggesting search attributes:

Relational operators:

Values:

Logical operators:

Shows suggestions according to the current cursor location, in this case it's the attribute "RunId"

When filtering search attributes by empty value

LGTM. what is your test plan for this? also make sure to check the tab order e.g. if i tab or hit enter does the autocomplete interfere with my intuition.
i also think keyboard navigation (down/up) is impt here. see if theres a premade library we can use. in React we have downshift, theres probably a similar one for Vue.

I will create PRs for these improvements subsequently:
Improved UX, add full keyboard navigation, improved styling

fwiw as of the snapshot from https://hub.docker.com/r/markmark206/tweb its flickering every time i type a query

fwiw as of the snapshot from https://hub.docker.com/r/markmark206/tweb its flickering every time i type a query

i don't think markmark206/tweb has the image for this pull request. Will ping you in dm to discuss/demo + decide on proper feature specification

This PR is on hold pending internal agreement on feature requirements. internal notes


Add RunRequest field AdditionalInstructions

Describe the change
AdditionalInstructions is an optional string field used to append additional instructions at the end of the instructions for the run. This is useful for modifying the behavior on a per-run basis without overriding other instructions.
Provide OpenAI documentation link
https://platform.openai.com/docs/api-reference/runs/createRun#runs-createrun-additional_instructions

@chrbsg please rebase your PR, I've just fixed all the linter warnings

Done.


[docs placeholder] Matchconditions 1.30

For MatchConditions Beta graduation in v1.30.
https://github.com/kubernetes/enhancements/issues/3716
/sig api-machinery
/milestone v1.30

/assign @ivelichkovich

Hello   @tallclair   :wave:  !
Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before the deadline Tuesday March 12th 2024 18:00 PST.
Thank you!

@ivelichkovich Can you take this over? Might be easiest to open a new PR.

Opening one now

created new PR here: https://github.com/kubernetes/website/pull/45525


Change to MessagePack-CSharp

https://github.com/neuecc/MessagePack-CSharp/

Remove the structural MessagePack tests, they're nice but if they don't work easily let's just get this in
Verify that case-insensitive binding works and if not, file an issue and try to get that moving.

Make sure this kinds of scenarios work https://github.com/neuecc/MessagePack-CSharp/issues/61. When I originally looked at MessagePack-CSharp it was not mature enough.

neuecc/MessagePack-CSharp#223 to track ContractlessReflectionObjectResolver


Please adopt OpenSSF Security Insights for this project

Hello from the OpenSSF Security Insights team!
Security Insights is a specification for expressing security-relevant metadata about a project in a machine-readable format. It allows you to express things like where a project is in its lifecycle, what kind of security tools are used, and whether you want to accept automated pull requests. It complements Scorecard metrics by focusing on things that often can’t be found by analyzing repository contents.
As part of our launch, we’d like to see OpenSSF adopt the Security Insights specification across our code projects. This is as simple as adding a SECURITY-INSIGHTS.yml file to your repository root. The entire process should take less than 10 minutes. The full specification is located https://github.com/ossf/security-insights-spec/blob/v1.0.0/specification.md.
If you have questions about the Security Insights specification or this request, feel free to reach out to us on slack (#security_insights_spec) or open an issue in our repository (ossf/security-insights-spec).

I think that would be very premature - for anybody - until https://github.com/ossf/security-insights-spec/issues/24 is resolved. This should be managed at the org level for OpenSSF, and not laboriously on every individual repo.


Revert "Add support for operator deployment on PSA"

Reverts k8snetworkplumbingwg/sriov-network-operator#371

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 25.21%

Files with Coverage Reduction
New Missed Lines
%

controllers/sriovnetwork_controller.go
4
63.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
1893

Relevant Lines:
7509

💛  - Coveralls


Question: Is it possible to add $id options ?

Hi,
Thank for you're work. I would like to know if it's possible to add $id option in the schema output type ?
const type = Type.Object({
  name: Type.String()
}, { $id: "MyType"})

Thank,
Best regards
Vincent

Hi @vincent-vade
should be possible. However, since this lib is nowadays basically just a wrapper around sinclairs typebox-codegen I think the issue should be raised there. Perhaps it will become an option one can pass or it will become the default. I would tend to just have the $id per default and will update this lib here once this was added.
If it gets refused we can think about adding it here as well, but would rather first check typebox-codegen.
@sinclairzx81 Hey! Hope you are doing well! Is this something that is already in typebox-codegen? If not, could this be added?

@vincent-vade Closing for now, as mentioned, if you want this I think creating an issue in typebox-codegen should be the way to go. Can then easily update the used version here :]


clean up Sinopia stage environment EXCEPT for the resources noted below

after checking with users to see which resources and templates (if any) should be retained, create a backup of the database, delete all other resources (including templates) from the STAGE environment, since it is a sandbox environment which should be periodically cleaned out.
assigning to Michelle for now since we need user input first

Some users may want to have their templates moved to production rather than save them in stage...

do NOT delete these templates:
UMN:RT:BF2:AdminMetadata
UMN:RT:bf2:Monograph:Instance:Un-nested
UMN:RT:bf2:Monograph:Item:Un-nested
UMN:RT:bf2:RareMat:Instance

more templates to save: PCC_and_LD4P_Templates to save.xlsx

awaiting additional list to save from U of Alberta

Think I added all those, but always good to doublecheck!

here is a single list of all the resources to retain. ignore above lists.
https://app.zenhub.com/files/149367347/6ac4828b-bee4-468c-8e61-d384514e6481/download

@michelleif Here is a list of URIs that were included in the save list, but are not found in stage. OK to ignore?
save_missing.txt

at least one of these is just a typo in my list:
https://api.stage.sinopia.io/resource/TAMU:RT:BF2:MonographInstance:Un-nested should be
https://stage.sinopia.io/editor/TAMU:RT:BF2:Monograph:Instance:Un-nested
so I need to check them all and get back to those who submitted if there is something not found. will post new comment when done.

@justinlittman attached is a doc listing the missing URIs in first column, with corrections in second column, or notes as to which ones are ok to ignore
missing_corrected.xlsx

also retain these templates:
example:template
demo2:art:object
test:resource:onefield_required_v2
test:embed:1_RT_one_field_not_required
test:embed:1_RT_one_field
test:embed:notrequired_but_embedded_required
test:embed:2_RTs_one_field_both_required
test:embed:resource:noRT
test:embed:requiredfield
test:resource:noRT
test:resource:multiplenestede
test:template:one_literal
test:template:another_literal
test:resource:onefield_required
cidoc:modification:demo
demo:production
demo_ubc:slais
my:favtemplate1
rt1:friday
test:orderedlookup
test:multiple:inputLOC
test:multiple:inputQAorder
test:QA:contextRT
test:template:looking_up_name
test:template:one_field
test:template:person


✨ Separate CRDs

Summary
Updated the Makefile and kustomizer to separate the CRDs of the helm from the operator.yaml
CRDs installed by an helm chart should be included in the special chart/crds/ folder to make sure that Helm installs them first, before acting on the rest of the chart.
Related issue(s)
Fixes #

@francostellari Can you please add couple of lines to the description about the reason to do this ?

@francostellari Can you please add couple of lines to the description about the reason to do this ?

@ezrasilvera I have updated the comment as you requested:
CRDs installed by an helm chart should be included in the special chart/crds/ folder to make sure that Helm installs them first, before acting on the rest of the chart.

@pdettori please note that @MikeSpreitzer requested a different approach used for the status-addon: https://github.com/kubestellar/ocm-status-addon/pull/47/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
Let me know if you want me to match it here

@pdettori please note that @MikeSpreitzer requested a different approach used for the status-addon:

@francostellari is the difference about the use of yq ? I am fine both ways, so let's leave this as it is.

@pdettori ok


SslContextBuilder no longer raising an SSLException

I have a canary unit test for OPENSSL that is checking for a SSLException being thrown if an attempt is being made to construct an SslContext with valid but mismatching PrivateKey/Certificate.
Please note that the JDK provider doesn't raise a Exception and the new outcome of my canary test could be interpreted either as a bug or feature.
Expected behavior
javax.net.ssl.SSLException: failed to set certificate and key
  at io.netty.handler.ssl.ReferenceCountedOpenSslServerContext.newSessionContext(ReferenceCountedOpenSslServerContext.java:127)
  at io.netty.handler.ssl.OpenSslServerContext.<init>(OpenSslServerContext.java:351)
  at io.netty.handler.ssl.OpenSslServerContext.<init>(OpenSslServerContext.java:335)
  at io.netty.handler.ssl.SslContext.newServerContextInternal(SslContext.java:415)
  at io.netty.handler.ssl.SslContextBuilder.build(SslContextBuilder.java:414)
  at io.netty.handler.ssl.OpenSslContextTest.testExceptionOnMismatch(OpenSslContextTest.java:28)
  Caused by:
  javax.net.ssl.SSLException: failed to set certificate and key
      at io.netty.handler.ssl.ReferenceCountedOpenSslContext.setKeyMaterial(ReferenceCountedOpenSslContext.java:730)
      at io.netty.handler.ssl.ReferenceCountedOpenSslServerContext.newSessionContext(ReferenceCountedOpenSslServerContext.java:112)
      ... 5 more
      Caused by:
      java.lang.Exception: Error setting private key (error:0B080074:x509 certificate routines:X509_check_private_key:key values mismatch)
          at io.netty.internal.tcnative.SSLContext.setCertificateBio(Native Method)
          at io.netty.handler.ssl.ReferenceCountedOpenSslContext.setKeyMaterial(ReferenceCountedOpenSslContext.java:722)
          ... 6 more

Actual behavior
No exception being thrown
Steps to reproduce
See below
Minimal yet complete reproducer code (or URL to code)
@Test(expectedExceptions=SSLException.class)
  public void testForException() throws Exception {

    SelfSignedCertificate cert1 = new SelfSignedCertificate();
    SelfSignedCertificate cert2 = new SelfSignedCertificate();

    try {
      SslContext context = SslContextBuilder.forServer(cert1.certificate(), cert2.privateKey())
        .sslProvider(SslProvider.OPENSSL)
        .build();

      ReferenceCountUtil.safeRelease(context);
      fail("This should have failed with an SSLException!");

    } finally {
      cert1.delete();
      cert2.delete();
    }
  }

Netty version
Netty 4.1.10.Final+
JVM version (e.g. java -version)
n/a
OS version (e.g. uname -a)
n/a

This exception will be raised if you don't have a version of OpenSSL which provides the necessary methods to support the KeyManager interface. You can also simulate this behavior with -Dio.netty.handler.ssl.openssl.useKeyManagerFactory=false. Is it possible that your tests were running with an older version of openssl (<0x10002000), or if you were previously using the tcnative jar from maven central which uses openssl (which is built against 1.0.1)?

Running the test with -Dio.netty.handler.ssl.openssl.useKeyManagerFactory=false does raise the exception.
I'm pretty sure I've been running w/ OpenSSL 1.0.2.

@Scottmitch on further thought, what is the benefit of using KeyManagerFactory over straight SslContext#setKeyMaterial(...)? It seems the KeyManagerFactory is a bit more costly as it needs to create a KeyStore and do a SPI lookup.
As far as I can tell, the SslContext#setKeyMaterial(...) was the old default and my canary test is indirectly telling me that the default has changed and I now need to decide whether I want to use KMF or disable it with the system property :thinking:

@rkapsi the advantage is that its a "drop-in" replacement for the JDK implementation, which uses the KeyManagerFactory. Thats it 👍

:+1: make sense. Closing this ticket.


Portal doesn't offer a log viewer

Portal 0.52.2 running with cljs doesn't provide a log view:
(tap> (portal.viewer/log {:level :info
                            :result [1 2 3]
                            :ns ""
                            :file nil
                            :line 1
                            :column 1
                            :runtime :cljs}))

The metadata shows :default :portal.viewer/log as expected.

Actually never mind. I read the spec carefully and figured I just need to reshape the timbre example for cljs (the :time wasn't right)


Discord link not working

the Discord link not working!

Where is the broken link?
Here is a new link: https://discord.gg/nAxz6JfxXh


Stroud-Ecklund Staryard missing

Stroud-Eckland Staryard is missing. I could visit Stroud-Ecklund in Neon City, but the “Overdesigned” quest requires I visit the Staryard.

Details
Good afternoon.  Thanks for your time.
I am attempting to complete a quest called Overdesigned which requires me to travel to the Stroud-Ecklund Staryard.
I attempted to travel there numerous way to no effect.
I tried selecting the quest and using the option to travel directly there. I also tried opening the map and travel directly to the location in orbit. Either way, the Staryard is missing.
There is however, an icon for the Stroud-Eckland Staryard. But the icon for the Staryard is over 10,000km away.
I could could hail them and get a response “Welcome to Stroud-Ecklund”. But I am unable to see, travel to, or dock at the Staryard.
I’ve tried using ships boost to travel the 10,000km distance. Whenever I get halfway there, icon disappears, and then icon reappears behind me.
I’ve saw on Reddit a number of people encountered this same bug after docking there. Like me, modified their ship while docked, reentered their ship, and saw the ship was clipping the Staryard. They undocked and traveled to another system. Once they returned they experienced the same issue. Some players said the Staryard reappeared after a number of game days.  I’ve tried both. Neither worked.
A little about myself.  I have over 150 hours in playtime. I’m am a grinder and completionist. I am currently level 148.
Game Version
<IP_ADDRESS>
Language
English (EN)
New Game
Yes
Reproduction Steps
Dock at the Staryard is a small ship. Modify your ship. Take it from Class A to Class C, make it much bigger. Re-enter your ship. You will find the ship will clip the Staryard. Undock. Travel away. Then return to the Staryard. It was gone.

Sorry for the typo.  Some “SHUT”down the XBOX Series X. Not “sh!t”down. Fat fingers. Forgive me.

I was able to break it eventually after using the ship builder there multiple times last night. Station was gone, and the hull of my ship was positioned incorrectly. Seems that using ship vendors aboard star stations is still unsafe. I imagine this would be an engine-level bug.

Out of scope for the SFCP. Will need an official fix by Bethesda.


Add Node that kills itself when the watchdog fails

Description
This PR does the following:

Separates the watchdog listener logic from create_action_servers.py to its own class.
Creates a node that kills itself if the watchdog fails. This node exposes a service that allows it to be toggled on and off.

As part of that, I changed the watchdog listener behavior to set the default watchdog_failed to False. This means that if the watchdog is not publishing when the listener starts listening, it will take 0.5sec (configureable by a param) before the watchdog listener registers a failure (because that is how long we allow the watchdog to go without publishing). The reason for this change is so that if we create a watchdog listener and query it before a watchdog message has been received (e.g., if it is listening at a faster rate than the watchdog), it doesn't immediately think the watchdog failed.

Modifies ada_planning_scene.py to wait until MoveIt is running before publishing the messages to populate the planning scene. This is because of an ordering dependency: ada_feeding_launch.xml launches both the watchdog and ada_planning_scene.py. But the MoveIt launch requires the watchdog to be running before it is launched, and ada_planning_scene.py requires MoveIt to be running before it is launched. This change resolves the ordering issue.
Modifies the dummy F/T sensor to expose a re-taring service, that stops it from publishing messages for 0.75 sec (to mimic the fact that the actual F/T sensor stops publishing messages for that long when re-taring).

Testing procedure
Pull the code from ada_ros2#10.

Verify that create_action_servers.py still works as expected:

[x] Run the dummy FT sensor (ros2 run dummy_ft_sensor.py), the ada_feeding launchfile, and MoveIt in RVIZ. Send a MoveAbovePlate action and verify that it succeeds.
[x] Kill the dummy FT sensor. Send a MoveAbovePlate action and verify that it is rejected.
[x] Re-start the dummy FT sensor.  Verify that the action aborts.

Verify that re-taring the F/T sensor works properly.

[x] Run the dummy F/T sensor, echo the F/T topic, and re-tare the sensor (ros2 service call /wireless_ft/set_bias std_srvs/srv/SetBool "{data: true}"). Verify that the messages stop publishing for 0.75 sec.

[x] Run your code through pylint and address all warnings/errors. The only warnings that are acceptable to not address is TODOs that should be addressed in a future PR. From the top-level ada_feeding directory, run: pylint --recursive=y --rcfile=.pylintrc ..

Before Merging

[ ] Squash & Merge

Soo... re-taring causes the FT sensor to stop publishing for ~0.75 seconds. During that time, this watchdog listener trips and kills controllers.
Taylor and I brainstormed a couple of options and the one that seemed the most promising is to add a service call that toggles on/off this node (the one that kills itself upon watchdog failure). Only while the node is on will it kill itself if the watchdog fails. And then, in every MoveTo behavior tree, we first retare the FT sensor, then toggle this node on, and then move (I can build an idiom for this). Thoughts @egordon ?

Ready for review. I went ahead and implemented the service to toggle the listener on and off (explained above), and modified the description and testing procedure accordingly.

The above commits address PR comments. I re-ran all tests and verified that it works.
Next, I'll move the watchdog listener functionality into ada_moveit

All tested and works. Will merge.


build problem on ubuntu 1804

hello
i want to build bpftrace on  ubuntu 1804.
i have already installed the bcc manually.
when i run 'cmake -DCMAKE_BUILD_TYPE=Release ..'', it returns error as below:
root@vm_compiler-s8:~/bpftrace/build# cmake -DCMAKE_BUILD_TYPE=Release ..
-- The C compiler identification is GNU 7.4.0
-- The CXX compiler identification is Clang 6.0.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found LibBcc: /usr/local/lib/libbcc.so
-- Found LibElf: /usr/lib/x86_64-linux-gnu/libelf.so
-- Performing Test ELF_GETSHDRSTRNDX
-- Performing Test ELF_GETSHDRSTRNDX - Success
-- Found BISON: /usr/bin/bison (found version "3.0.4")
-- Found FLEX: /usr/bin/flex (found version "2.6.4")
-- Looking for name_to_handle_at
-- Looking for name_to_handle_at - found
-- Looking for bcc_prog_load
-- Looking for bcc_prog_load - not found
-- Looking for bcc_create_map
-- Looking for bcc_create_map - not found
-- Looking for bcc_elf_foreach_sym
-- Looking for bcc_elf_foreach_sym - not found
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of BPF_FUNC_get_current_cgroup_id
-- Check size of BPF_FUNC_get_current_cgroup_id - failed
-- Check size of BPF_FUNC_send_signal
-- Check size of BPF_FUNC_send_signal - failed
-- Please install the libbpf development package (missing: LIBBPF_LIBRARIES LIBBPF_INCLUDE_DIRS)
-- Please install the libbfd development package (missing: LIBBFD_LIBRARIES LIBBFD_INCLUDE_DIRS)
-- Please install the libopcodes development package (missing: LIBOPCODES_LIBRARIES LIBOPCODES_INCLUDE_DIRS)
-- Looking for sys/sdt.h
-- Looking for sys/sdt.h - found
CMake Error at CMakeLists.txt:110 (find_package):
By not providing "FindClang.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "Clang", but
CMake did not find one.
Could not find a package configuration file provided by "Clang" with any of
the following names:
ClangConfig.cmake
clang-config.cmake

Add the installation prefix of "Clang" to CMAKE_PREFIX_PATH or set
"Clang_DIR" to a directory containing one of the above files.  If "Clang"
provides a separate development package or SDK, be sure it has been
installed.
So what's the problem?
Thanks in advance.

Older Ubuntus have a bug in their LLVM CMake files - you might be hitting that here.
We don't run builds on those old versions any more, but you can take a look at our old Docker files which contain some workarounds we needed in the past:
https://github.com/iovisor/bpftrace/blob/1dbbbf03c2698c943c3a0a9efed00ba804ffa926/docker/Dockerfile.ubuntu
https://github.com/iovisor/bpftrace/blob/aa05dca06e33da0004705c96452a51f1551e58f9/docker/Dockerfile.ubuntu

i will try it later today.
thanks ajor!

i installed clang-7 and modify cmake/FindLibBpf.cmake cmake/FindLibBcc.cmake  to point to bcc directory where i build bcc.
bpftrace build ok. but i meet new problem,once run any probe then SIGSEGV.
bpftrace -e 'BEGIN { printf("hello world\n"); }'Segmentation fault (core dumped)
i use strace it shows something like as below:
prlimit64(0, RLIMIT_RSS, {rlim_cur=10485761024, rlim_max=10485761024}, NULL) = 0
uname({sysname="Linux", nodename="vm_compiler-s8", ...}) = 0
stat("/lib/modules/4.15.0-72-generic/source", 0x7ffd8f75aeb0) = -1 ENOENT (No such file or directory)
stat("/lib/modules/4.15.0-72-generic/build", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
openat(AT_FDCWD, "/sys/devices/system/cpu/online", O_RDONLY) = 3
read(3, "0-15\n", 8191)                 = 5
read(3, "", 8191)                       = 0
close(3)                                = 0
bpf(BPF_MAP_CREATE, {map_type=BPF_MAP_TYPE_PERF_EVENT_ARRAY, key_size=4, value_size=4, max_entries=16, map_flags=0, inner_map_fd=0, ...}, 120) = 3
getpid()                                = 37230
futex(0x7f9b4cd58ac4, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
--- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0x100000004} ---
+++ killed by SIGSEGV (core dumped) +++
Segmentation fault (core dumped)
does it means i miss kernel dbgsym?
Thanks.

i use gdb to trace bpftrace it shows error in libllvm-7
Starting program: /usr/local/bin/bpftrace -e kprobe:do_nanosleep\ {\ printf("PID\ %d\ sleeping...\n",\ pid);\ }
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff1e27ea3 in llvm::RegisterTargetMachinellvm::BPFTargetMachine::Allocator(llvm::Target const&, llvm::Triple const&, llvm::StringRef, llvm::StringRef, llvm::TargetOptions const&, llvm::Optionalllvm::Reloc::Model, llvm::Optionalllvm::CodeModel::Model, llvm::CodeGenOpt::Level, bool) ()
from /usr/lib/x86_64-linux-gnu/libLLVM-7.so.1
(gdb) bt
#0  0x00007ffff1e27ea3 in llvm::RegisterTargetMachinellvm::BPFTargetMachine::Allocator(llvm::Target const&, llvm::Triple const&, llvm::StringRef, llvm::StringRef, llvm::TargetOptions const&, llvm::Optionalllvm::Reloc::Model, llvm::Optionalllvm::CodeModel::Model, llvm::CodeGenOpt::Level, bool) ()
from /usr/lib/x86_64-linux-gnu/libLLVM-7.so.1
#1  0x00000000004ca968 in bpftrace::ast::CodegenLLVM::compile(bpftrace::DebugLevel, std::ostream&) ()
#2  0x00000000004a6c5a in main ()
Dump of assembler code for function _ZN4llvm21RegisterTargetMachineINS_16BPFTargetMachineEE9AllocatorERKNS_6TargetERKNS_6TripleENS_9StringRefES9_RKNS_13TargetOptionsENS_8OptionalINS_5Reloc5ModelEEENSD_INS_9CodeModel5ModelEEENS_10CodeGenOpt5LevelEb:
0x00007ffff1e27e60 <+0>:     push   %r15
0x00007ffff1e27e62 <+2>:     push   %r14
0x00007ffff1e27e64 <+4>:     mov    %r9,%r15
0x00007ffff1e27e67 <+7>:     push   %r13
0x00007ffff1e27e69 <+9>:     push   %r12
0x00007ffff1e27e6b <+11>:    mov    %rdx,%r13
0x00007ffff1e27e6e <+14>:    push   %rbp
0x00007ffff1e27e6f <+15>:    push   %rbx
0x00007ffff1e27e70 <+16>:    mov    %rcx,%rbx
0x00007ffff1e27e73 <+19>:    mov    %rsi,%r12
0x00007ffff1e27e76 <+22>:    mov    %r8,%r14
0x00007ffff1e27e79 <+25>:    sub    $0x38,%rsp
0x00007ffff1e27e7d <+29>:    mov    0x78(%rsp),%rcx
0x00007ffff1e27e82 <+34>:    mov    %rdi,(%rsp)
0x00007ffff1e27e86 <+38>:    mov    %fs:0x28,%rax
0x00007ffff1e27e8f <+47>:    mov    %rax,0x28(%rsp)
0x00007ffff1e27e94 <+52>:    xor    %eax,%eax
0x00007ffff1e27e96 <+54>:    mov    0x70(%rsp),%r9
0x00007ffff1e27e9b <+59>:    mov    0x80(%rsp),%rdx
---Type  to continue, or q  to quit---
0x00007ffff1e27ea3 <+67>:    movzbl 0x4(%rcx),%eax
0x00007ffff1e27ea7 <+71>:    mov    0x90(%rsp),%ebp
0x00007ffff1e27eae <+78>:    test   %al,%al
0x00007ffff1e27eb0 <+80>:    mov    %al,0x1c(%rsp)
it looks like %rcx has wrong memory address.

After i use clang-8, everything is ok now.
Maybe i meet the prolem in llvm, https://groups.google.com/forum/#!topic/llvm-dev/8Tcz49kTNCw


feat: update next with master

Description
This PR updates the next branch with master.

Everything looks good to me !