Refactoring Task

Hello :)
The Task enum has become a monster with so much variations of the same tasks, especially requests, that it is no longer trivial to know which one to use. I wanted to shrink it drastically to have as few cases as possible. And add the long overdue (one year and a half) upload case with Data (Fixes #1655) 🎉
Edit: This is now the second version of this PR.
Taking advantage of Swift 5.1 and the ability to have default associated values in enums (thanks @sunshinejr  for the heads up), there are now only 3 case instead of 12.
Additionally, with Alamofire 5 ParameterEncoding is now stated to be soon depreciated in favor of the new ParameterEncoder so I replaced all usages accordingly.
Some particular points I'ld like to discuss:

Atm it's possible to perform any upload or download task by providing body or query params. I don't really know how upload or download are performed and when and where it's possible to have parameters. I suspect i'll have to tweak it a bit to work as intended.
Having based Tasks on BodyParams and QueryParams, I've rejected the possibility for users to use an URLEncodedFormParameterEncoder with a .methodDependant destination. To make sure encoders then behave like there are supposed to, I've added runtime checks on provided encoders. Do you think I should allow users to use this destination? This point have been resolved by not exposing the ParameterEncoder subclasses in the Task but only their nested encoders.

Feel free to enlight me whatever the subject.

Warnings

:warning:

Any changes to library code should be reflected in the Changelog.
Please consider adding a note there and adhere to the Changelog Guidelines.

:warning:
PR is classed as Work in Progress

:warning:

Sources/Moya/MoyaProvider.swift#L159 - MARK comment should be in valid format. e.g. '// MARK: ...' or '// MARK: - ...' (mark)

Messages

:book:
iOS: 	 Executed 271 tests, with 0 failures (0 unexpected) in 12.782 (13.018) seconds

:book:
tvOS: 	 Executed 271 tests, with 0 failures (0 unexpected) in 12.715 (12.971) seconds

:book:
macOS: 	 Executed 271 tests, with 0 failures (0 unexpected) in 12.769 (12.952) seconds

  Generated by :no_entry_sign: Danger Swift against 2fe86e5d62d1d2c61c3aa0bb62a68e9443f85acf

Codecov Report

:exclamation: No coverage uploaded for pull request base (development@088cf56). Click here to learn what that means.
The diff coverage is 86.17%.

@@              Coverage Diff               @@
##             development    #1936   +/-   ##
==============================================
  Coverage               ?   91.65%
==============================================
  Files                  ?       26
  Lines                  ?      995
  Branches               ?        0
==============================================
  Hits                   ?      912
  Misses                 ?       83
  Partials               ?        0

Impacted Files
Coverage Δ

Sources/Moya/MoyaProvider+Defaults.swift
85.71% <ø> (ø)

Sources/Moya/Moya+Alamofire.swift
85% <ø> (ø)

Sources/Moya/MoyaError.swift
100% <ø> (ø)

Sources/Moya/Endpoint.swift
94.54% <100%> (ø)

Sources/Moya/MoyaProvider+Internal.swift
93.43% <79.1%> (ø)

Sources/Moya/MoyaProvider.swift
91.56% <90.9%> (ø)

Sources/Moya/Task.swift
93.93% <93.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 088cf56...2fe86e5. Read the comment docs.

Some questions regarding tests:

Looking at the Endpoint file, i'm wondering about the purpose of the adding(newHTTPHeaderFields:), replacing(task:) and add(httpHeaderFields:) functions. They only seems to be used by the tests, and. Maybe we could get rid of them? If it's really necessary to be able to change the task or headers of a Endpoint we may just make the proprties var instead of let ?

Until now, parameters encoding was performed by an homemade extension of URLRequest. The correct encoding and headers update was then checked in EndpointSpec. With the new Alamofire, this extension is no longer necessary because AF's encoders now perform these tasks. Is it still pertinent to check for both params presence & headers update in our EndpointSpec ?

Hey @amaurydavid, thanks a lot for the hard work on this one! I didn't have time to fully get into it, just got a quick look at the changes but it's not an easy refactoring for sure 😅
Also wanted to let you know that AFAIK in Swift 5.1 there is an ability to add default values for cases and we were thinking of improving the Task to also benefit from that (we could make a requirement for Swift 5.1 in Moya 15 as we are for sure gonna enforce Xcode 11+ anyways). E.g.:
enum Task {
-    /// A request body set with `Encodable` type
-   case requestJSONEncodable(Encodable)
-
-   /// A request body set with `Encodable` type and custom encoder
-    case requestCustomJSONEncodable(Encodable, encoder: JSONEncoder)
+    case request(encodable: Encodable, encoder: JSONEncoder = JSONEncoder())
}

Looking at the Endpoint file, i'm wondering about the purpose of the adding(newHTTPHeaderFields:), replacing(task:) and add(httpHeaderFields:) functions. They only seems to be used by the tests. Maybe we could get rid of them? If it's really necessary for the user to be able to change the task or headers of a Endpoint we may just make the properties var instead of let ?

yes we use it in tests to make sure these work - we don't use it anywhere in the core as it's a pure utility for Moya users

Until now, parameters encoding was performed by an homemade extension of URLRequest. The correct encoding and headers update was then checked in EndpointSpec. With the new Alamofire, this extension is no longer necessary because AF's encoders now perform these tasks. Is it still pertinent to check for both params presence & headers update in our EndpointSpec ?

if it's now in Alamofire then great - the more code we can remove from the core and leave in Alamofire the better 😄 in that case we won't really need these tests to be there, but I'd love to leave them for at least one version to make sure they didn't break our assumptions about the params/headers
also I think important note that could impact your refactor is that this PR seems like a really big change and we would love to keep the API changes to bare minimum - we want our users to keep up with version bumps and if they have too much things to update they will just stay at the previous ones as long as possible. With that in mind use your best judgement for the changes (e.g. the adding(newHTTPHeaderFields:) method updates).

Also wanted to let you know that AFAIK in Swift 5.1 there is an ability to add default values for cases and we were thinking of improving the Task to also benefit from that (we could make a requirement for Swift 5.1 in Moya 15 as we are for sure gonna enforce Xcode 11+ anyways)

Damn, I didn't catch this one! I've indeed read that you wanted to wait for defaults in enums but I've missed it would be possible with Siwft 5.1. Its strange, I just checked in playground with Xcode 11.1 and it works. Still, I don't see any mention of this from Swift 5.1 changes. Is it linked to https://github.com/apple/swift-evolution/blob/master/proposals/0242-default-values-memberwise.md ?
Now that you pointed it I'll ... refacto my refacto to use defaults, which should make things a bit simpler.
About the potential updates of mutating functions in Endpoint I understand your point of view about not changing too much API at once, but isn't it the point of updating to Moya 15? Shall we make properties var instead of let and mark those functions as deprecated? I think it would be a good compromise.

@amaurydavid yeah I’m not saying we don’t want breaking changes at all, just to try and make the migration as easy as possible. Also if we want to make big changes then I’m not opposed to that as well, but we would have to decide if the output of the change  is worth having people spend hours on migrating to newest version in bigger apps. It’s hard to do that though so we have to use our best judgement.

I think I'm done here. I'm satisfied with the actual Task, and spent (a lot of time) on tests though I'm sure they might be improved.

There are warnings in Task+internal and RawDataParameterEncoder because they are part of the Moya target and the test target as I need them in tests, but don't want to make them public. Is there a better way?

Similarly I wanted in Moya+Alamofire to make the following typealiases internal

public typealias URLEncodedFormParameterEncoder = Alamofire.URLEncodedFormParameterEncoder
public typealias JSONParameterEncoder = Alamofire.JSONParameterEncoder

but they are used in tests so it was either having them public or using Alamofire.URLEncodedFormParameterEncoder and Alamofire.JSONParameterEncoder.

I've let reflexions on https://github.com/Moya/Moya/pull/1936#issuecomment-546611729 aside as it's not the focus of this PR.

I'll update doc and guides once the PR has been reviewed and validated.

I encourage all @Moya/contributors to at least get a quick look at the changes in this PR - this is a pretty big one and I would love some opinions on that 🙏

There are few unrelated commits(combine related) on this PR I think is because this branch was created from another other than the target(I think master). So maybe we can merge master/develop into 5.1 ?
cc @sunshinejr

@LucianoPAlmeida good catch! this is because this PR targets a different branch - development_swift_5.1 which is not synced with development yet (see #1931)

Hummm I didn't notice that PR, there are a few conflicts so we can't sync it right now...
Perhaps we can target this to develop for now, so we can have a sync diff which is cleaner for us @Moya/contributors to take a look. What do you think @sunshinejr ?

Hummm I didn't notice that PR, there are a few conflicts so we can't sync it right now...
Perhaps we can target this to develop for now, so we can have a sync diff which is cleaner for us @Moya/contributors to take a look. What do you think @sunshinejr ?

Initially the PR was to be merged on develop but when I started using Swift 5.1 features I also included commits for the development-swift-5.1 branch, resulting in this PR to contains both last commits from develop and commits from development-swift-5.1 branch (with conflicts resolved). Updating #1931 to sync it with dev should eliminate those files related to Combine from the diff.

I have rebased the PR to remove all commits that were included from the develop branch.

I've studied some improvements I could make and here are 2 I've thought about
1. Shrink all parameters associated values down to 1.
It can be done by wrapping BodyParams, URLParams and CustomParams into an enum:
 public enum Task {
    enum ParametersKind {
        case body(BodyParams)
        case url(URLParams)
        case custom(CustomParams)
    }

    /// A task to request some data
    case request(parameters: [ParametersKind] = [])

    /// A task to upload some data
    case upload(source: UploadSource, parameters: [ParametersKind] = [])

    /// A task to download some data
    case download(destination: DownloadDestination, parameters: [ParametersKind] = [])
}

Pros:

A more concise declaration.

Cons:

The user would be able to provide BodyParams in Task.upload. A note in the documentation and a check at runtime can be added to notify the user via a warning log but it's better to have it at compile time.

2. Remove CustomParams
CustomParams is only there to make sure it's only used as last resort when BodyParams and URLParams can't be. We could simply let the user use Parameters however he wants.
Pros:

The new MoyaError.taskParametersUsage is no longer needed and can be removed.
CustomParams removed from the code base.

Cons:

The user would be able to encode parameters in request's body when using Task.upload. Again, updating the docu and a check at runtime can be added.

What do you think about those code improvements ?

Hey guys :) Now that Moya 14 is out (thanks @sunshinejr for taking care of it), I'ld like to ping you out. I'ld be delighted to have your feedback on this PR, it's been opened for a while now.

@amaurydavid ah yes will do! let's merge the Swift 5.1 migration first and then try to get this one afterwards!

Codecov Report

Merging #1936 into development-swift-5.1-updates will not change coverage by %.
The diff coverage is n/a.

@@                      Coverage Diff                       @@
##           development-swift-5.1-updates    #1936   +/-   ##
==============================================================
  Coverage                          92.14%   92.14%
==============================================================
  Files                                 29       29
  Lines                               1018     1018
==============================================================
  Hits                                 938      938
  Misses                                80       80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb9725...9fb9725. Read the comment docs.

@amaurydavid can you rebase on top of current develop please? 🙏

Codecov Report

:exclamation: No coverage uploaded for pull request base (development-swift-5.1-updates@6360b4b). Click here to learn what that means.
The diff coverage is n/a.

@@                       Coverage Diff                        @@
##             development-swift-5.1-updates    #1936   +/-   ##
================================================================
  Coverage                                 ?   92.14%
================================================================
  Files                                    ?       29
  Lines                                    ?     1018
  Branches                                 ?        0
================================================================
  Hits                                     ?      938
  Misses                                   ?       80
  Partials                                 ?        0

Impacted Files
Coverage Δ

Sources/Moya/Task+Internal.swift
97.56% <ø> (ø)

Sources/Moya/RawDataParameterEncoder.swift
100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6360b4b...40399e7. Read the comment docs.

I've rebased the PR on development and merged it in the branch. We are all set :)

Hey folks! 👋
What is the plan about this PR, b/c it has been open ~ 7 months. Is it planned to be merged anytime soon?

The PR looks mostly good, I just want to play with it in my projects to see how it looks/works - this is a second big rewrite to the Task type and so I really want to make sure we've got the most of it. I'd love if anyone that uses Moya in a bigger project could spin up the branch and play with it as well (cc @Moya/contributors)

Codecov Report

Merging #1936 into development will decrease coverage by 0.76%.
The diff coverage is 90.19%.

@@               Coverage Diff               @@
##           development    #1936      +/-   ##
===============================================
- Coverage        92.91%   92.14%   -0.77%
===============================================
  Files               27       29       +2
  Lines              931     1018      +87
===============================================
+ Hits               865      938      +73
- Misses              66       80      +14

Impacted Files
Coverage Δ

Sources/Moya/Moya+Alamofire.swift
85.00% <ø> (ø)

Sources/Moya/MoyaProvider+Defaults.swift
85.71% <ø> (+7.45%)
:arrow_up:

Sources/Moya/MoyaProvider+Internal.swift
94.61% <70.00%> (-3.94%)
:arrow_down:

Sources/Moya/Endpoint.swift
91.30% <85.71%> (-4.16%)
:arrow_down:

Sources/Moya/MoyaError.swift
93.22% <90.90%> (-6.78%)
:arrow_down:

Sources/Moya/MoyaProvider.swift
91.56% <90.90%> (+0.13%)
:arrow_up:

Sources/Moya/Task+Internal.swift
97.56% <97.56%> (ø)

Sources/Moya/AnyEncodable.swift
100.00% <100.00%> (ø)

Sources/Moya/RawDataParameterEncoder.swift
100.00% <100.00%> (ø)

Sources/Moya/Task.swift
100.00% <100.00%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f2b1f...40399e7. Read the comment docs.

What's the status of this PR?

@Noobish1 this is a very big change and I don't want to rush things as we did previously with introducing the Task type. It's mostly good, though we need to verify if it has all the needs we want (e.g. I would really like to be able to specify parameters by a literal, without introducing unnecessary interim Encodable type). Also would like someone else to clone & play with the API to see what else we need to discuss.


Remove client-side query rewriting in ContextRetriever

Previously, the ContextRetriever class was using a rewriteKeywordQuery function to modify the original query before sending it to the server for indexed context retrieval. This client-side query rewriting is now redundant.
This PR removes the client-side query rewriting in the ContextRetriever class. The changes include:

Removing the rewriteKeywordQuery function call from the ContextRetriever class.
Passing the original query directly to the server for indexed context retrieval.
Updating the SymfRunner class to use the original query for live results.
Updating tests to reflect these changes and ensure the original query is used throughout the retrieval process.
Updated and added tests in ContextRetriever.test.ts to verify the correct usage of the original query.

The server-side now handles query rewriting for remote searches, making the client-side rewriting unnecessary. This change simplifies the client-side code, removes the needs of rewriting the search query repeatedly.
symf is still using the rewriteKeywordQuery function in the getResults method.
Test plan

Updated existing unit tests to reflect the new behavior.
Added new tests to ensure the original query is used in all relevant methods.
Manually tested to confirm that context retrieval still functions correctly with these changes.

Changelog

I trust you've tested this against S2 as well as dotcom :)

Yea tested it on S2 and the results look the same:

DotCom - i can see the query is still getting rewritten as expected.

The server-side now handles query rewriting for remote searches, making the client-side rewriting unnecessary

@abeatrix thanks for pinging me on this. Do you have a link to this PR where we implemented server-side query rewriting?

The server-side now handles query rewriting for remote searches, making the client-side rewriting unnecessary

@abeatrix thanks for pinging me on this. Do you have a link to this PR where we implemented server-side query rewriting?

Yea Beyang and Dom told me it was moved to the server-side but I'm not sure which PR specifically. I found this doing a Sourcegraph search though: https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/commit/c733bea5de10bed3bbdd568dd630e17b755979f7

The server-side now handles query rewriting for remote searches, making the client-side rewriting unnecessary

@abeatrix thanks for pinging me on this. Do you have a link to this PR where we implemented server-side query rewriting?

@jtibshirani Yea Beyang and Dom told me it was moved to the server-side but I'm not sure which PR specifically. I found this doing a Sourcegraph search though: https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/commit/c733bea5de10bed3bbdd568dd630e17b755979f7

That's not the same query rewriting actually! That is a different, experimental rewrite and it's disabled by default. So I'm not aware of any effort to move this server-side for remote context. That means we'll be losing some important functionality like:

For long (multiple sentence) questions, rewrite the question into just the important keywords
For non-English questions, rewrite for a better chance of matching relevant code

CC @janhartman @hitesh-1997


IAM - Does UserProfile really need PGP key for password?

I am creating a temporary password for AWS IAM user. I follow the instruction by adding UserLoginProfile:
let user = new aws.iam.User("totoro", {
  name: "totoro",
});

// force new users to reset their password for the initial sign in
new aws.iam.UserLoginProfile(`login-profile-for-totoro`, {
  user: user.name,
  passwordResetRequired: true,
  pgpKey: `WHY_DO_I_HAVE_TO_PROVIDE_THIS?`
}, {
  parent: user,
  dependsOn: [user]
})

I am wondering why this resource requires me to use pgpKey to encrypt/decrypt password (/with Keybase.io) when there is already KMS mechanism provided out of the box by Pulumi.
Many thanks in advance

My bad, I misunderstand the usecase of pgpKey. My objective is to set a temporary password NOT sending the password to keybase or to local pgp.
AFIK there is no way to do so with pulumi or terraform


Custom Data segmentation  Easier conversion mask ?

Custom Data segmentation  Easier conversion mask ?
The labelme conversion script does not know how to convert to the required mask format
img = Image.open("*.PNG")
image_L = img_as_ubyte(img)
mask_dst = np.uint8(image_L) * 255
out_mask = Image.fromarray(mask_dst)
out_mask.save(*.jpg)

Whether my conversion script conforms to the mask?

Hi, could you provide us with some details about your problem, and how it's related to Anomalib? We don't recognize the code snippet in your question as our code.

labelme
1.jpg
1.json
2.jpg
2.json

How to convert mask
| mask
| -- 1.jpg
| --2.jpg

We really can't answer your question if you don't provide some more background information about your problem.
Please list clearly what you are trying to achieve, and which steps you already tried. If you are using any external tools, please provide a link to the (documentation of the) tool so that we are aware of the context.
You could have a look at the following page which gives some pointers on how to ask good questions: https://stackoverflow.com/help/how-to-ask.

Sorry English is not good
I'll rearrange the process
I'm a novice
Step 1
Labelme
| -- 1.jpg
| -- 1.json
| -- 2.jpg
| -- 2.json

Demand mask
How to convert mask
https://openvinotoolkit.github.io/anomalib/how_to_guides/train_custom_data.html
task: segmentation
Step 2
Pseudo color map     Convert Monochrome
labelme\examples\instance_segmentation\data_dataset_voc\SegmentationClassPNG

img = Image.open("*.PNG")
image_L = img_as_ubyte(img)
mask_dst = np.uint8(image_L) * 255
out_mask = Image.fromarray(mask_dst)
out_mask.save(*.jpg)

I'm sorry I didn't find the tutorial
can only do this

If I understand your question correctly, you are trying to run Anomalib with ground truth masks generated using an external tool. From the examples images you posted, I believe you are using this tool to create the masks: https://github.com/wkentaro/labelme.
The masks used by Anomalib are expected to be binary images with ones for anomalous pixels, and zeros for non-anomalous pixels. The example image you provided (the last one) should work fine. Just make sure that the images in the masks folder have the same file names as the corresponding images in the anomalous folder. So, for example:
dataset
├── anomalous
│  ├── 00.jpg
│  ├── 01.jpg
│  ...
├── masks
│  ├── 00.jpg
│  ├── 01.jpg
│  ...
└── good
│  ...
...

You could then use the following configuration for the dataset section of your config.yaml to train a model and evaluate using the provided mask files.
dataset:
  name: name-of-your-dataset
  format: folder
  path: <path-to-your-dataset>
  normal_dir: good
  abnormal_dir: anomalous
  task: segmentation
  mask: masks
  normal_test_dir: null
  ...

Thank you for your answer
The data set can be trained normally


Rewrite documentation for modularizing schemas.

Inspired by @Poincare's upcoming blog post, I've come up with a better way to split your schema up into multiple modules.
There's no magic here, and that's the point. This approach should be relatively easy to understand, while also solving some non-obvious problems (such as circular dependencies and schema fragment duplication) and scaling to large GraphQL codebases.
Each module exports a getTypes function that returns an object mapping type names to schema fragment strings, as well as a getResolvers function that returns the merged resolvers for all types used by the current module.
Representing this API using functions (getTypes and getResolvers) that are called after the modules have been imported solves the problem of circular dependencies (e.g. between Book and Author) without passing functions to the typeDefs argument to makeExecutableSchema.
Having those functions return objects rather than arrays makes it much easier to avoid duplication of schema fragment strings, because the ...spread syntax used to construct the objects ensures the type names are unique.
I could keep going with this description, but it's all in the new documentation that I wrote, which you can preview here.

I can include more details on the resolvers as soon as I rework the blog post to follow this method of schema modularization.

So, I guess this is no longer the suggested method of doing things since the blog post now uses a much simpler method. Should we close this PR and I can set up a new one that incorporates the suggested method into the documentation?

Yes please!


Fix a pair of bugs in Tagged Filth parsing

Fix a bug searching for Tagged Filth, I had assumed . included \n, it didn't.
Improve handling of the ignire_* flags for tagged filth items

Coverage remained the same at 93.943% when pulling 4b9c83175f50786806cb3e67f0c86f5f9faf52bb on bug/tagged_filth_search into 4f5eaca25e3290494d98746dfa2a504febc64990 on master.


trades not updating

Overview
when making a trade, the trade wheel does not spin/no green check mark appears upon confirmed trade, and tx history is not updated without a refresh.
References and additional details

go to app.shapeshift.com
log in with mm, kk, or native
go to the trade modal on the dashboard and make a trade
noticed the wheel does not spin on a pending trade, the green check does not appear when trade is confirmed on chain, and the trade is not updated to your history unless a refresh is performed

Acceptance Criteria
trade wheel should spin on pending trade, green check mark should appear when trade is confirmed, and tx should appear in history
Need By Date
No response
Screenshots/Mockups

Estimated effort
No response

may be fixed by https://github.com/shapeshift/lib/pull/870

closing as websocket reconnect logic is in place - @shapeshift/operations can monitor and reopen if required


how to update users collection

1)add role - Roles.addUsersToRole(userId,['rolename']);
roles was displayed in roles collection
2)but when entered statement in javascript
Meteor.users.update({_id:"userId"},{$set:{roles:["admin"]}});
this line gives error

Which error?

in browser console -
gpBqdPq2HRhv36JtX  app.js:210:7
update failed: Access denied

You might have some permission checks with deny/allow or something else which prevents you to update data on the server from the client directly.


Refer to global purs if not installed in project

The plugin will use the global purs if the project purs is not installed

Got the same problem, I even wrote my version of fixing the issue before I realized that there's already a PR. Yours looks better though.

Sorry for taking so long before being able to review this change.
I will approve this PR. I have some suggestions, but nothing that is worth keeping this PR from merging.
Would it be ok if I create a PR with my improvements and ping you in it and ask you to review, @sshark?

@Neppord sure


Remove spec that was checking redirection to /go/home while testing the agents.

@tomzo - not sure why this spec was there in the first place.
Since they spring security upgrade in GoCD 18.6.0, this no longer happens. curl -L localhost:8153/go yields the html for the add pipeline.
Edit: html for add pipeline, not dashboard.

not sure why this spec was there in the first place.

I think this was a way to check if server is up at all before looking at agents. Not mandatory anyway.


Add stereo_tool.app Latest Cask

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[x] If the sha256 changed but the version didn’t,
provide public confirmation by the developer: {{link}}

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

Added Stereotool - Freemium

Hi, this is my first cask commit (and learning git), I'm sorry for the issues.
Also, generate_cask_token suggested "stereotool.rb", and not "stereo-tool.rb".

Thank you for your contribution.


Memory leak when subscribing to observables from XAML in a data template

Bug description
Subscribing to an observable from XAML (using a caret ^ syntax, e.g. IsVisible="{Binding Foo^}") in a data template causes a memory leak: the binding recipient remains in the memory after it's long gone from the visual tree.
Likely related to #3527
Reproduction
Bind to a long-lived observable in a data template.
Minimal example, based on the default template: repo link (most relevant stuff is in the MainWindow). Dummy controls are used to track a leak.
To confirm a leak, I've used the managed memory profiler in VS 2019.

Expected behavior
All bindings made in XAML should be auto-disposed when control is detached. That seems to be true when using normal bindings (e.g. IsVisible="{Binding $parent[UserControl].Foo}" — included in the example).
Desktop

Windows 10 Pro (v2004)
Avalonia 0.10.3

Commentary
In my 100%-reactive app this issue causes colossal memory leaks: just switching a page bumps the memory gauge by 50-70 Mb. It stacks nicely with (up to) 350 Mb from the graphics bug (the one that causes memory issues when resizing a window).
I do not know if the issues is caused by a data template or a binding, but having the bug down the tree causes a huge chunk of the tree to leak, likely through a parent reference.

After updating to 0.10.6 the leak is still present, #5987 did not help. Repro repo is up-to-date. No new screenshots, reference count didn't change.

I think the leak may be happening somewhere in the pre-compiled (a)XAML. Although the compiler internals are confusing. Can someone point me in the general direction?

Taking a look now @ShadowsInRain

Yeah this is a difficult one. I've been unable to write a unit test so far that reproduces the problem, even. Seems to be related to the fact that an observable is producing a collection via the stream operator which creates data templates which themselves have observables subscribed via the stream operator.

I'm having a similar problem. i try to rewrite 1 wpf app with avalonia, wpf app only use ~50mb memory, but avalonia app go up to ~400mb


i get a message on running a file as

i get a message on running a file as
"Backend TkAgg is interactive backend. Turning interactive mode on" in pycharm.
what could be the issue
Originally posted by @medgitt in https://github.com/open-mmlab/mmdetection/issues/4365#issuecomment-798903700

Please give more details.

This is not related to mmdetection. You may google/baidu it to solve the issue of pycharm.


Using blessed over a socket?

I've been trying to use blessed with a Socket connection. Here's how initialise blessed:
  var program = blessed.program({
    input: socket,
    output: socket
  });

Some commands seem to work fine, like program.write. However, when trying to run a more complex example like in the README, I am getting:
TypeError: Object #<Socket> has no method 'setRawMode'

I wrote a response to this a while ago and forgot to post it...
cc @martindale
Yeah, we can allow this. Should have been there from the beginning, I just never added setRawMode checks to see if it was a tty stream or socket. It's a simple fix.
I'm assuming you are telnetting or ncing to a server (running blessed) from a terminal (possibly for a MUD or Rougelike?).
I have a few pointers here if this is the case, especially if there are multiple clients and/or Screens involved.
It might be screwy with telnet if telnet is line-buffered. It has to be raw (can't be cooked) and it also needs to be one byte at a time, no buffering. If it line buffers, key sequences will not go through properly.
Another gotcha: your blessed server will use whatever terminfo you have set as TERM. So if it's xterm, whoever is connecting should be using an xterm-like terminal, however, you might be able to work out some kind of (UI) handshake where the client tells you it's TERM and you switch the tput object around in screen.tput and screen.program.tput. (NOTE: Make sure you have all terminfo's available on the server, including rxvt-unicode and screen).
To swap tputs:
var clientTput = blessed.tput({
  term: clientTerm,
  extended: true
});
screen.tput = clientTput;
screen.program.tput = clientTput;
// Probably also for good measure:
// screen.leave();
// screen.enter();

Or, if you can manage to hold off before instantiating a screen, that would be ideal. You could simply do:
var screen = blessed.screen({
  term: term,
  input: socket,
  output: socket
});

Another gotcha: terminal size. The client will also have to tell you it's rows and cols in this initialization or handshake. It should be easy enough to resize the screen in question.
To resize:
socket.rows = clientRows;
socket.columns = clientCols;
socket.emit('resize');

Or, again, if you can manage to hold off before instantiating, this would be ideal (but you're likely going to have to resize later if a user resizes the terminal):
socket.rows = rows;
socket.columns = cols;
var screen = blessed.screen({
  term: term,
  input: socket,
  output: socket
});

Yet another gotcha: whether the client's machine supports unicode or not. The LANG/LC env vars will have to be relayed to the server to check and changed on the tput object depending. You'll have to hook into Tput.prototype.detectUnicode. You'll probably also have to alter the screen's _unicode property.
Also, security measures: do not allow any screen.spawn's, screen.exec's, screen.readEditor's, or textarea.readEditor's because it will use the server's editor/program and the client may then have access to a shell on your server.
More security: it would be easy for a client to DOS the server if they constantly change TERMs. Blessed will go around and parse and compile every terminfo it sees. It doesn't appear to be slow in a local blessed program, but if it's parsing hundreds of terminfos, it can block for quite a while (see node test/tput.js all for how CPU intensive this really is, if you're interested). You might want to add some kind of throttle for that.
This will be interesting, because it actually puts multiple Screen instances to use, which should technically work, although, it's never been attempted before. Let me know how it goes.
The other solution: simply get all clients to agree on a TERM, LANG, cols/rows, and use one Screen object, which might be a bit easier for the server, but not so nice looking for the clients.

@olalonde, lots of improvements have now been made. There's even an example blessed telnet server if you're interested. See #157.

@chjj thanks.


ICE crash. Reason login failed

Iam not able anymore starting up ice using plain login. Its always crashing. No java update, no changes at all. Seems like google changed the login front page.

Same here

The reason is googles new login form. they changed it and made id bot prove. Currently I think it wants keypresses. But they block events sending and things like that. Formular ID's changed and setting value doesn't work anymore

Usally i am using cookies with an auto update make into ice. Iam trying to
fix the manually log in. Let me know if you have a fix in place.
By the way, I issued an donation a couple of weeks ago. check out your bank
account,
2017-05-06 21:19 GMT+02:00 windkh<EMAIL_ADDRESS>
Same here
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nibogd/ingress-ice/issues/107#issuecomment-299660549,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGH7mk8N7zq7Z2-HRJLIJjf-ixsxuw9Jks5r3MfJgaJpZM4NRNzO
.

--
Best,
Andreas

Try this, works for me:
page.settings.userAgent = 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3 GTB5';
With this userAgent Google deliver the old login page :)

Before page open ingress intel in firePlainLogin?
2017-05-08 8:38 GMT+02:00 Alexander Grüßung<EMAIL_ADDRESS>
Try this, works for me:
page.settings.userAgent = 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5;
en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3 GTB5';
With this userAgent Google deliver the old login page :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nibogd/ingress-ice/issues/107#issuecomment-299785188,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGH7muGgCNLGWsvhi1PupXhd2AlPWPtVks5r3rhigaJpZM4NRNzO
.

--
Best,
Andreas

Directly after init page object.

@gruessung not sure if your userAgent is the reason but now iitc stopped loading for some reason. Any ideas why that happens? (of couse anyone can awnser)

No ideas, sorry.
I heard that my userAgent hotfix only works now. google try to turning it off.
We need a solution to login over the new login form.
On my local machine i get it, but the server not.

Where to add that user agent?

I am awfully sorry, but I have a lot of problems IRL now and cannot code a proper fix in the near future (I tried to, but it refuses to work after login and I don't have time to find out why). So I'll release a bugfix version with the @gruessung's workaround (thanks a lot, @gruessung!) and hope that it works for some time until we have the new login code... But it can break at any time.
@h3tz,

By the way, I issued an donation a couple of weeks ago. check out your bank
account,

Thanks! I received it and already added you to the backers.md file.

Released ICE-v4.5.1... Not closing the issue as it requires a proper fix.

Is this working for you? because I get a problem that iitc doesn't detect it has been logged in.

@MTRNord, yup, I've tested it both with and without IITC prior to uploading...

hm weird in my custom fork which uses the same login iitc says it is not logged in and failes to init

15.05.2017 10:31:20: Something went wrong. Please, sign in to Google via your browser and restart ICE. Don't worry, your Ingress account will not be affected.
Still not working for me. On the same pc I can log in to Firefox without no problem.

interim solution with mozilla in place is working fine for me(without IITC) Intelrecorder.com. I will start to investiage for final solution

On my side UserAgent now works. I needed to move the user agent way to be before the firs page.open() to get it to work.

What OS, I think it does that check as well.  FF user string + W10 not working here

Works fine with page.settings.userAgent without ice updating.

Works. Thanks.
By the way: could you add a configuration data for setting the cookiesfilename?

Last Fix working for me since weeks. For me bug seems to be solved.


[AutoPR cognitiveservices/data-plane/CustomImageSearch] Update custom image search Node.js properties

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3470

Codecov Report

Merging #2974 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2974   +/-   ##
=======================================
  Coverage   56.35%   56.35%
=======================================
  Files        8124     8124
  Lines      166280   166280
=======================================
  Hits        93699    93699
  Misses      72581    72581

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f09d0...c507f36. Read the comment docs.

NodeJS


[v7] Controlled pageIndex

How to control pageIndex? I did not find this in manual pagination api.

This is question better suited for the support forum here: https://spectrum.chat/react-table. Thanks!


Consider storing language server in a directory outside of extension

https://code.visualstudio.com/updates/v1_31#_global-storage-path
Would help with download sizes, and insiders builds.

Closing until we feel we need to this


Adding Jacksonville, FL

Trying to follow alphabetic order.

Carl,
I've been trying to find the discretionary threshold for JAX and couldn't find the limit or the URL.  Have been looking for a while here: https://www.municode.com/library/fl/jacksonville/codes/code_of_ordinances

I included the URL. Hang on.

i = 'carlvlewis'
i[dot]net
@i
github[dot]com/i

"Technology is neither good nor bad; nor is it neutral." -Melvin Kransberg
On Sat, Oct 17, 2015 at 10:52 AM -0700, "Alan Mond"<EMAIL_ADDRESS>wrote:
Carl,
I've been trying to find the discretionary threshold for JAX and couldn't find the limit or the URL.  Have been looking for a while here: https://www.municode.com/library/fl/jacksonville/codes/code_of_ordinances
—
Reply to this email directly or view it on GitHub.

I think the URL you included does not talk about the discretionary limit.  That is why I dove deep into the MuniCode library...

http://www.coj.net/departments/central-operations/procurement/bidding-opportunities-(including-capital-improveme.aspx
--
Carl V. Lewis
Sent with Airmail
On October 17, 2015 at 1:52:24 PM, Alan Mond<EMAIL_ADDRESS>wrote:

I'll merge your PR and we can add it later if we find it :)

This is a clearer definition on a different page:http://www.coj.net/departments/intra-governmental-services/procurement/doing-business-with-the-city.aspx
--
Carl V. Lewis
Sent with Airmail
On October 17, 2015 at 1:55:47 PM, Alan Mond<EMAIL_ADDRESS>wrote:
Merged #34.
—
Reply to this email directly or view it on GitHub.

that's helpful.  I found the link for the discretionary spending: http://www.coj.net/departments/central-operations/docs/procurement/procurement-manual-revised-8-2-13(3).aspx#page=7


default wallpaper's season only work for users from the northen hemisphere

Describe the bug
the default wallpaper's season is set to the opposite season
What did you expect to happen?
the wallpaper's season should be also able to match the season in the southern hemisphere
Output of rpm-ostree status
No response
Output of groups
No response
Extra information or context
The seasons in the southen hemisphere are oppisite to the seasons in the northen hemisphere

I'd love to have this if someone wants to work it up!

What would be a route to this? I thought maybe a script to sed the right wallpaper names in with an accompanying systemd service to run on first boot, but I'm not sure how I would go about getting the hemisphere of the user.

for getting info about the hemisphere the user
maybe it could just be set via a ujust script that could toggle an environment variable stored somewere? or maybe a script could be used to scrape the system timezone information and compare it to a list of tz that are in the southen hemisphere could work? like something like this pseudocode could be okay?
gettz=$(timedatectl show | grep Timezone)
listofsouthenhemispheretzs=("list" "of" "tzs" "that" "are" "in" "the" "southen" "hemisphere")
for item in $listofsouthenhemispheretzs
 if item == $gettz
 then
   #do someting to set the default wallpaper to an appropriate one for the southern hemisphere
 else
   #do nothing keep it as the one appropriate one for the northen hemisphere


Further autocomplete improvements

As with #393, this still doesn't solve our underlying "only syntactically-valid templates can produce completions" problem, but it does resolve the main issue called out in #436.
At a high level, several different related issues were coming together to produce the behavior described in #436:

completions triggered as the result of typing a partial identifier are always considered CompletionTriggerKind.Invoked (this is per the LSP, not just a weird choice on Code's part)
we weren't forwarding TS's sorting information through the LSP, so items didn't necessarily display in order of relevance
standalone templates with a syntax error end up mapping to a 0-length span at the top level of the corresponding backing module, meaning that when we tried to produce completions for e.g. {{foo.}}, we'd return the full list of hundreds of available globals

Fixing those three errors, completion now looks like this:

(Note that in a loose-mode template we can't provide completions for myHashObject, as we have to assume during emit that e.g. myH is referring to some global and not an incomplete reference to a local identifier)

This is a big improvement. Thank you, as ever.


How to specify toolset?

Hello! How to specify toolset correctly? For visual studio generator I can paste only few strings in CMakePresets and it targets correctly
For example:
        "toolset": {
          "value": "v120_xp,host=x64",
          "strategy": "external"
        },

But I have no ideas how to do it with WindowsToolchain

I think the problem here will be that the toolsets are a feature of MSBuild and are implemented via MSBuild configuration XML files. We'd have to replicate the same compiler/linker configuration in a CMake/Ninja friendly way.
This is something that I've done for my own projects but it's not simple and certainly not easy to guarantee the same settings as MSBuild without a lot of complexity.

There's documentation at the top of the Windows.MSVC.toolchain.cmake file that explain which properties control behavior. To set the host to be x64, you'd need CMAKE_VS_PLATFORM_TOOLSET_HOST_ARCHITECTURE to be x64. TBH, I'm not sure what v120_xp corresponds to; if I install the "C++ Windows XP Support for VS 2017 (v141) tools" on my VS2022 Community install, then it installs the '14.16.27023' toolset, which you'd get by specifying VS_PLATFORM_TOOLSET_VERSION to be 14.16.27023. Note that I just fixed a bug (#78) in specifying the toolset version via VS_PLATFORM_TOOLSET_VERSION, so you'd need a build from the main branch.

@MarkSchofield thank you! v120_xp corresponds to 12.0.40629.0 but I'm not sure it's correct.


Auth: Implemented ApiKey Authorization

This pull request should make the Postman "API Key" Authorization available on collections.
I would appreciate if this feature could be included, it is longingly needed in another project, which also uses postman-to-k6 for automated load testing with Postman Tests.
Kind Regards
Christoph Pader

Hi,
Thank you for your contributions. I'd love to include this, however, the tests are currently failing. Would you mind having a look at that?
Thanks again,
Simme

Ok, so i just have one question @simskij ... How are you building the production script (in ./bin, the one that is included with the npm-package), so i can test the functionality before pushing to the repo.. can't seem to find a 'main' property in package.json or any building script.
Kind regards

You shouldn't need to build anything. Running the "bin" in `./bin/postman-to-k6.js' will use the code in the lib folder.

Ok so locally the tests are succeeding, idk why they are failing in CI/CD...
√ auth » apikey

46 tests passed

Getting a Rejected promise returned by test error

@simskij error fixed, tests are passing! :-)
I can confirm the authentication is working and the header is being added.
I still have another question... As of now, pm.collectionVariables is not supported or is it? Because when running the generated script pm.collectionVariables.<key> throws an error, as it is undefined.. Maybe this feature could be implemented or i would have a look at it.
Kind regards
Christoph Pader

Hey @simskij ! Is this still being reviewed?
Kind regards
Chris

LGTM! Merging. Regarding collectionVariables; from what I can tell there is no explicit support for this, sounds great if you'd like to have a look at it. Let me know if I can assist you in any way.


1.7.4 release

Binary wheels using frs-wheel-builds 1.2.0: https://github.com/sgillies/frs-wheel-builds/blob/master/CHANGES.txt#L4

[x] resolves issues
[x] update version, change log
[x] tag
[x] build and publish sdist and wheels

Thanks for the PR @youngpm!

Thanks!
On Mon, Feb 20, 2017 at 5:27 AM, Sean Gillies<EMAIL_ADDRESS>wrote:

Thanks for the PR @youngpm https://github.com/youngpm!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Toblerity/Fiona/issues/424#issuecomment-281066701,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUNU17JqRliAcZEgfjOr1YTpodB2Dhnks5reYadgaJpZM4MGHTh
.


Using bare variables is deprecated

Sorry I didn't notice this earlier; it was fixed in a follow-up in #48.


Feature Request: Link to WordPress article on confirmation

I would like to be able to have a link from Obsidian that I can click that takes me to the WordPress admin panel and opens up the post in edit mode:
/wp-admin/post.php?post={{post-id}}&action=edit
This will make doing final edits from the WP editor and setting any other metadata quicker and easier.

I have added this feature in 0.10.0, please check it out.

Works as designed. Thanks!


Converting Image to PNG data using toByteData does not work in all cases in the HTML renderer

Converting Image to PNG data using toByteData does not work in all cases in the HTML renderer. In particular, cases where the image is sourced from RGBA data, it just completely fails to convert to PNG data.

https://github.com/flutter/flutter/issues/119065 looks related

#119065 looks related
Yep you're right. I'll close this as a duplicate of that issue.


Prevents header from rendering with one tab

Small tweaks to ensure that when there are <= 1 tabs, the <Header /> component renders null rather than <header>. Also changes the style in <Terms /> to make sure that the 34px top margin is only rendered if there are enough tabs open to justify it.

For everyone using TMUX rather than native tabs, this should make hyperterm a viable option. I don't actually run OSX to test it on, so it's worth checking that the removed margin doesn't cause any visual accidents there.
Fixes #127 and #92.
I've been dreaming about a web powered terminal forever. Great job!

What do you think about tweaking padding in the config instead? The reason I like the consistent height is that we don't trigger pty resizes when opening new tabs :) in addition to no jump visually

I've got the padding turned down to 0 at the moment, but there's still a 34px block of space that can't be used for tiling wm/tmux users.

How about allowing tabs to be disabled with a config option instead?

@danprince that sounds wonderful. And if we do it right, we can turn off the title extraction and make things even more efficient for your usecase.
I think it should be an advanced option, not present in config-default.js, but documented in the website (https://github.com/zeit/hyperterm-website).
Thanks!

Hey @rauchg, here's a first attempt. How's this looking?

I added a fullScreenMode option to the config format, which when set to true prevents the entire <Header /> from rendering and adds a style to get rid of that margin. Not sure that fullScreenMode is necessarily the best name though, maybe disableTabs would work better?

I'm wondering about the implications of tabless mode a bit. What should we do about the keyboard shortcuts like cmd+T?

If this is implemented, please consider allowing the user to make the electron window frameless (frame: false) rather than using titleBarStyle: "hidden-inset".
Being able to disable the frame (on OS X at least) is nice when using a tiling window manager like kwm. Without it, this PR hides the tab bar but still shows the OS X traffic lights buttons and in fact these buttons are shown on top of the terminal text which is not ideal.
Here's a screenshot of what it looks like if you use this PR and also disable the frame (i.e., replace titleBarStyle: "hidden-inset" with frame: false):

@freebroccolo I think the ability to decorate the window settings passed to createWindow is in order as a hook?

@rauchg ah, yes a plugin hook would be a nice way to handle this. That should be sufficient I think.

@freebroccolo if you want to add it in a PR, decorateBrowserOptions would be a good name I think. Pretty much same code as decorateConfig

I'm wondering about the implications of tabless mode a bit. What should we do about the keyboard shortcuts like cmd+T?

Because of this I'm not sure it's really a good idea to allow the tab bar to be disabled completely as an option. I mean, I'd rather have that feature than nothing at all but the problem with disabling it completely is the UI becomes somewhat weird and surprising.
Even if the user purposely disables tabs, they could end up in a situation where they've accidentally created a new tab but there is no visual indication of this aside from whatever happens in their shell during login. Or maybe they create some tabs to do some task and then forget that the others exist.
This could be partially addressed by adding some other kind of indicator when a tab is created or when it's switched to, maybe like a temporary overlay in one of the corners, but that means additional work and complexity to support this feature nicely.
I guess you could just disable tabs completely in tabless mode and have cmd + T do nothing.
I think it would be better to not disable the tab bar completely, just have it hidden unless the number of tabs is >= 2. I'm probably biased though because this is a configuration I use in iTerm2 😄

@freebroccolo I prefer the hide until >= 2 option, but if @rauchg isn't keen on doing the resize and repaint then I think that "tabless" mode needs to kill the CMD+T and CMD+n options for tab creation and navigation.
I don't have OSX to test on, but hiding the titlebar sounds sensible. My goal would be to get hyper term working as a drop-in replacement for URXVT or xterm, so that I could start using it as part of a tiling wm on a daily basis. Being able to achieve all of this stuff with a single "tiling mode" or "fullscreen mode" configuration option would be brilliant.

@danprince definitely open to helping support the tiling WM usecase, whether in core or userland. Just need to think a bit more about the implications

Sure, not trying to suggest otherwise. What would the userland solution look like? It'd be possible to remove the header by decorating the component, but removing that margin is going to be harder. I'd be happy to move this PR out into a "hypertile" plugin if there's a solution which doesn't involve fiddling with the core.

Userland solution on the way: https://github.com/danprince/hypertile. Once the decorateBrowserOptions hook exists in core, it'll be pretty complete.

Awesome. Let's focus on decorateBrowserOptions for the time being then. Thank you so much!


Fix catalog chart rbac to use new namespacedServiceBrokerDisabled flag

namespacedServiceBrokerDisabled is defaulted to false in charts/catalog/values.yaml. Service catalog has new ns-scoped resources but could not work with them cause of missing rbac settings.

/ok-to-test

CLA signature has beed fully registered

/approve
/lgtm
Thanks @PK85


CI jobs on ROS2 build farm are not triggered for Iron and Rolling

@pablogs9 @Acuadros95
the ci pipeline on OSRF build farm is not triggered for Rolling and Iron for all of the pending pull requests. Do you have any idea what else to check?
pending pull requests:

https://github.com/ros2/rclc/pull/363
https://github.com/ros2/rclc/pull/362
https://github.com/ros2/rclc/pull/359
https://github.com/ros2/rclc/pull/358
https://github.com/ros2/rclc/pull/357

I have also seen that you have updated the line in one of the micro-ros/setup repos:
https://github.com/ros2/rclc/blob/master/.github/workflows/ci.yml#L26

uses: actions/checkout@v2 to
uses: actions/checkout@v3

Might this be the reason? Where is this documented? Could you provide a link to the documentation for the changes of v2 and v3?

I would say its related to the branch used, maybe something needs to be configured on the build farm side?

I updated the action/checkout version for some PR. This did not resolve the issue.

I would say its related to the branch used, maybe something needs to be configured on the build farm side?

That's a good point.

Indeed, Iron and Rolling build jobs are using the master branch:
https://github.com/ros/rosdistro/blob/0ad9c9e92cab4d0955ebf35dd3237acabf7b38a4/iron/distribution.yaml#L4068
https://github.com/ros/rosdistro/blob/0ad9c9e92cab4d0955ebf35dd3237acabf7b38a4/rolling/distribution.yaml#L3967
I need to change the branch to rolling and iron, respectivly.

I would do the following:

I would merge all the pending pull requests. The Github Action CI job ran successfully or is on hold (for one PR)
then I have a clean status on master, rolling and iron.
then I can create a new revision number, add a tag
then create a new bloom release (change the branch names for Iron and Rolling).

@Acuadros95 , @pablogs9 Do you agree?

Created a bloom release for Iron, however the iron branch was not updated with the bloom-release tool. I need to create another pull reqest again that changes the branch name.
PR on ros/rosdistro: https://github.com/ros/rosdistro/pull/37664


sc-8715 GDS Admin UI: display N/A for empty value on vasps list

Scope of changes
sc-8715 GDS Admin UI: display N/A for empty value on vasps list
Type of change

[x] bug fix
[ ] new feature
[ ] documentation
[ ] other (describe)

Acceptance criteria
https://app.shortcut.com/rotational/story/8715/vasps-with-no-certificate-have-the-current-timestamp-for-expiration-date
Author checklist

[x] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[x]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[x]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report
Base: 44.14% // Head: 39.20% // Decreases project coverage by -4.93% :warning:

Coverage data is based on head (9eb6658) compared to base (4baa498).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
- Coverage   44.14%   39.20%   -4.94%
==========================================
  Files         587      155     -432
  Lines       22281     2436   -19845
  Branches     1330      623     -707
==========================================
- Hits         9835      955    -8880
+ Misses      11168     1305    -9863
+ Partials     1278      176    -1102

Flag
Coverage Δ

unittests
39.20% <100.00%> (-4.94%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

web/gds-admin-ui/src/pages/app/lists/index.js
30.30% <100.00%> (+30.30%)
:arrow_up:

web/gds-user-ui/src/components/Section/Login.tsx

...ment/X509IdentityCertificateInventoryDataTable.tsx

web/gds-user-ui/src/hoc/withRHF.tsx

...m/trisacrypto/directory/pkg/gds/admin/v2/errors.go

web/gds-user-ui/src/modules/verify/index.tsx

web/gds-user-ui/src/components/ui/Button.tsx

.../components/Section/IntegrateAndComply.stories.tsx

...rc/components/CertificateManagement/Statistics.tsx

...ents/CertificateReview/ContactsReviewDataTable.tsx

... and 427 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update mailbox-usage.md

added a statement about recoverable items
Fixes https://github.com/MicrosoftDocs/microsoft-365-docs/issues/12249

@JohanFreelancer9 Please copy review

@kwekuako Please merge this PR. Thanks


Delete support/azure/general/support-policy-containers.md

As per the comments/discussion in the work item: https://supportability.visualstudio.com/AzureContainers/_workitems/edit/81349
Marking this article for deletion.
Pull request guidance
Thank you for submitting your contribution to our support content! Our team works closely with subject matter experts in CSS and PMs in the product group to review all content requests to ensure technical accuracy and the best customer experience. This process can sometimes take one or more days, so we greatly appreciate your patience.
We also need your help in order to process your request as soon as possible:

We won't act on your pull request (PR) until you type "#sign-off" in a new comment in your pull request (PR) to indicate that your changes are complete.

After you sign off in your PR, the article will be tech reviewed by the PM or SME if it has more than minor changes. Once the article is approved, it will undergo a final editing pass before being merged.

@reknai, I will close this PR, and use internal repo for retiring the article. It should include serval steps like setting the article to no-index, update the TOC, create redirection and etc.


chore(release): adding 2.5.0

2.5.0 (2016-08-19)
Bug Fixes

Modal: set focus state before showing (#104) (a358233)
Modal: use togglePortal on componentDidMount (#106) (942b24a)

Features

Progress: add Progress component (#105) (bc185d8), closes #78

Coverage remained the same at 100.0% when pulling 3ac4aaa918e2eaa10325f29e133ae716c8773954 on release-2.5.0 into 942b24a5f8443e3e470c68ed183652878904c8dc on master.


stack-update() will not correctly parse template within zsh

https://github.com/realestate-com-au/bash-my-aws/blob/simpler/lib/stack-functions#L104
This line will not correctly parse the template file argument into a local variable. It will always appear that no template file parameter has been passed. I have narrowed this down to how zsh (at least in this instance) will interact with passing a string of space-seperated words into a function.
Going to look more into this but interesting to find, and might be a root cause for zsh weirdness.
I have tried to reproduce in /bin/bash and the function appears to work as expected.

Thanks for posting.
Unfortunately (your zsh users) I don't use zsh or claim to support it.
If you find a simple fix for that please reopen and I'll consider updating.


It's hard to get through the door

Players will be returned when they cross the door

Thank you very much for fixing it


allow default privacy list to be set

...Migrated from Ignite Jira OF-1364...
Ignite Forum Post
When creating a new user, it would be handy if a default privacy list can be defined. Gugli contributed a change to the registration plugin that allows for this.

This was added in version 1.7.1 of the plugin (released in July 2017). I suspect we simply forgot to close the JIRA issue at that time.


Add code highlighting for webpack loaders names

Fixes #
Add highlighting for webpack loaders awesome-typescript-loader, source-map-loader
(Just to make reading easier)

Thank you for helping contribute to the TypeScript Handbook! We're trying to get through the large backlog of open PRs. As part of that effort, we're only merging PRs that clearly improve the content. PRs that only change phrasing, style, nits, or other aspects not directly related to accuracy or coverage won't be accepted - this will greatly reduce merge conflicts in PRs that do have content-critical changes. We'll be closing PRs like this one that make subjective improvements; often given two ways of writing the same thing, opinion will be split on which is better, and we have to defer to making fewer changes rather than more. Thanks for understanding.


Update create-and-configure-database.sh

@CarlRabeler,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Update case-study-representing-humans-in-mixed-reality.md - Changed metadata, formatted text

Changed metadata, formatted text

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/case-study-representing-humans-in-mixed-reality.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/case-study-representing-humans-in-mixed-reality.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


RN 0.62.2

Not working with RN 0.62.2.
https://stackoverflow.com/questions/61226530/typeerror-undefined-is-not-an-object-evaluating-reactnative-animated-text-pr

You can use my fork as a temporal solution (I've updated a dependency which causes an error)
npm install https://github.com/talyuk/react-native-hide-show-password-input.git

it is also not working in react native.....


Pods crash when scheduled on nodes with >24 CPU's

What happened:
Installing and running MagTape on worker nodes with 24 or more CPU's generates a high number of threads with Gunicorn and there appears to be a memory leak of some sort.
What you expected to happen:
Pods to startup normally
How to reproduce it (as minimally and precisely as possible):
Run the simple install in a cluster with worker nodes that have 24 or more CPU's
Anything else we need to know?:
Experienced on worker nodes with 24 cores x 128GB RAM
Example output from MagTape container logs:
[2020-10-02 04:52:27 +0000] [107] [INFO] Booting worker with pid: 107
[2020-10-02 04:52:27 +0000] [1] [CRITICAL] WORKER TIMEOUT (pid:62)
[2020-10-02 04:52:27 +0000] [1] [CRITICAL] WORKER TIMEOUT (pid:63)
[2020-10-02 04:52:27 +0000] [1] [CRITICAL] WORKER TIMEOUT (pid:64)
[2020-10-02 04:52:27 +0000] [62] [INFO] Worker exiting (pid: 62)
[2020-10-02 04:52:27 +0000] [64] [INFO] Worker exiting (pid: 64)
[2020-10-02 04:52:27 +0000] [63] [INFO] Worker exiting (pid: 63)
[2020-10-02 04:52:29 +0000] [108] [INFO] Booting worker with pid: 108
[2020-10-02 04:52:29 +0000] [109] [INFO] Booting worker with pid: 109
[2020-10-02 04:52:30 +0000] [1] [INFO] Unhandled exception in main loop
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/gunicorn/arbiter.py", line 211, in run
    self.manage_workers()
  File "/usr/local/lib/python3.8/site-packages/gunicorn/arbiter.py", line 545, in manage_workers
    self.spawn_workers()
  File "/usr/local/lib/python3.8/site-packages/gunicorn/arbiter.py", line 616, in spawn_workers
    self.spawn_worker()
  File "/usr/local/lib/python3.8/site-packages/gunicorn/arbiter.py", line 567, in spawn_worker
    pid = os.fork()
OSError: [Errno 12] Out of memory

Environment:

Kubernetes version (use kubectl version): v1.15.5
Worker Node OS: Ubuntu 16.04
Cloud provider or hardware configuration:
Others:

This is related to the dynamic sizing for workers/threads in the Gunicorn config. While the docs recommend (2 x $num_cores) + 1, they also recommend not going above 12 workers total. I'm testing out hard coding the values for workers/threads to a reasonable default and using an HPA for scaling out vs. up.
Thanks to Alex, Ian, and Shahar for the consultations!


Added ability to skip generating boilerplate code and runline

New command line flag to fix #47

Please take a look at new changes. I just implemtented python for now.
Also I added tests but in seemed crazy to add tests for all flag combinations so I added py-no-tls-no-run-line-no-code tests.
if you OK these I will add other languages. Let me know.

I added changes for other languages, another unit test, and addressed your comments.
Please take a look, should be close

PTAL

ptal

ping

Please take a look

ptal

I will squash and merge; the tests passed on Travis on Linux but have not even started on macOS, so skipping those.

@gennadiycivil — thank you for your contribution and for your patience with this review!
BTW, since you used your master branch, you won't be able to merge this cleanly; please consider deleting your fork on GitHub and creating a new fork. For future PRs, please create a new feature branch for every PR and keep the master simply for syncing with upstream (i.e., this repo).

@mbrukman thank you. I deleted my fork and re-created new one just in case.


Initial Sort not working, SyntaxError

Syntax Error ,  Unexpected token, expected
The error is at column inside initialSort object
`

83 |             initialSort={column: 'Name', order: 'asc'}
84 |             showRowHover={true}
85 |             showHeaderToolbar={true}
86 |             showFooterToolbar={true}`

I am using<EMAIL_ADDRESS>

@akki199421 Hi, have you tried initialSort={{column: 'Name', order: 'asc'}}?
(because it's an object.)

Yeah, i didn't realize that. Thanks.


Specify Content-Length header when redirect()

What version of Remix are you using?
^1.11.1
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce

Create a new Remix project;
Create a new resource route (e.g. /) that just returns a redirect('/some-page');
Run the following (or visit the page in your browser and inspect the network request):

$ curl -s -I http://localhost:3000
HTTP/1.1 302 Found
location: /login
Date: Mon, 27 Feb 2023 21:11:33 GMT
Connection: keep-alive
Keep-Alive: timeout=5

Notice that there is no Content-Length header in that response and thus it is invalid.

Expected Behavior
There should be a Content-Length header of 0 when returning a 302 redirect.
Actual Behavior
There is no Content-Length header. This is an invalid HTTP response.
Temporary Solution
I've implemented a small wrapper around the Remix redirect function:
import { redirect as remixRedirect } from '@remix-run/node'

export function redirect(path: string, init?: ResponseInit) {
  // TODO remove this explicit header once the automatic content-length
  // header setting is fixed upstream (e.g. in the express app or remix).
  const headers = new Headers(init?.headers)
  headers.set('Content-Length', '0')
  return remixRedirect(path, { ...init, headers })
}

This may be an issue upstream with Express or whatever Remix is using to handle setting the Content-Length header for other requests. Note that I am not using a custom Express server and instead use @remix-run/serve.

I dug into this a bit more and this is feeling more like an adapter-layer concern to me.  It turns out that if you remove the compression middleware included by default in the express template, then the transfer-encoding: chunked goes away and content-length: 0 shows up correctly.  So I think this is a concern you can/should handle in your express server.
Per https://groups.google.com/g/nodejs/c/4HyYmbBjbiE?pli=1 it sounds like setting Content-Length manually like you are is the correct way to tell node not to use chunked encoding.


Push Notifications

From @ivanmauricio on November 10, 2016 12:50
We need to investigate how to implement these.
Copied from original issue: foundersandcoders/keep-the-lights-on#16

From @andrewMacmurray on November 10, 2016 12:50
https://developers.google.com/web/fundamentals/getting-started/primers/service-workers


A documented utility to access store in plain js functions in React

What is the new or updated feature that you are suggesting?
We should have a utility where we can connect to provider store in plain js functions instead of need to directly import the store in plain js files in a react app. I understand this will not bring rerenders and that totally fine.
Example would be, I have an axios file where I need to read token from store. Passing token/ store from useStore hook everywhere is troublesome. Only way I am left with is importing store directly which does not seems right
Why should this feature be included?
Currently if we need to get some value from store, we need to import store and then use getState method is not right. Using useStore is not possible everywhere.
What docs changes are needed to explain this?
In section how to connect to store, this new feature should be added as below
To connect to provider store directly in plain js use [new] utility.

Functions that need access to dispatch or getState should usually be thunks.

Already covered here:

https://redux.js.org/faq/code-structure#how-can-i-use-the-redux-store-in-non-component-files


control placement

Hi, does it possible to control placement (near, far) in case of using this package?
For example i have rack with servers and ring contains 40 nodes and i have 3 replica count, how can i specify that i need to place data on far servers?
Or another use-case - i have 3 racks and replica count 2, how can i place data on rack that far from another?

I’m not quite sure if this library is capable of rack-aware placement. Have a look at this: https://github.com/Netflix/dynomite/wiki/Replication


Add missing <fmt/ranges.h> includes

Added missing #include <fmt/ranges.h>. Without them the build on macOS fails with multiple error: no member named 'join' in namespace 'fmt'.
Issue: https://github.com/userver-framework/userver/issues/689

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/


Some of the API errors are not displayed in the staff details view

Some of the API errors are not displayed in the staff details view in the new dashboard:

changing "isActive" flag for your own account
trying to remove your own account

Maybe related but I'm not sure if it's problem in JS or in the API - I have an admin account with full permissions; I'm deselecting "User has full access to the store" and trying to select some specific permissions; after hitting "save" and refreshing the page nothing happens, although a success message is displayed.

Still happens.


private func updateNowPlayingInfoCenter() should be public

I have the following scenario:
I want to start playing a web audio livestream. Therefore I define the AudioItem and call the player to play it.
I also want to set an artwork image for the lockscreen. However this is an async network request. So currently if I want to set the artwork image and play the AudioItem I have to wait until the artwork request completed to start the player.
I would like to do the following:
        currentItem = AudioItem(mediumQualitySoundURL: event.streamurl)
        currentItem?.artist = event.podcastSlug
        currentItem?.title = event.title
        player.playItem(currentItem!)

        // fetch coverart from image cache and set it as lockscreen artwork
        Alamofire.request(.GET, event.imageurl)
            .responseImage { response in
                if let image = response.result.value {
                    self.currentItem?.artworkImage = image
                    self.player.updateNowPlayingInfoCenter()
                }
        }

However this is not possible as updateNowPlayingInfoCenter() is currently declared as private.

You don't need to call updateNowPlayingInfoCenter() because properties of the currentItem are observed within the player to change whenever you change it's property.
Doesn't it work? I haven't noticed bugs with that on my app.

Oh that's even better! However currently it does not work yet but I think this another issue, because the MPRemoteCommand Center is not configured at all currently for me. No play/pause or title working.

@delannoyk By the way: Really nice code! I am very happy and thankful you wrote that code. Makes my life a lot easier :heart:

Thanks man!
I'll look into your other issues later today and probably fix them in the evening if possible.


Update http4s-blaze-client, http4s-circe, ... to 0.21.28

Updates

org.http4s:http4s-blaze-client
org.http4s:http4s-circe
org.http4s:http4s-dsl

from 0.21.26 to 0.21.28.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, semver-patch

Superseded by #136.


Problem with max length on ion-input type="text"

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
When I set max length on an ion-input type="text" it do not work correct on Android (I have not tried it on iOS). If i set the max length to 75 I can write more than 75 characters, but the exstra characters disappear when I hide the virtual keyboard. When i use type="tel" with max length I cannot write the exstra characters.
Expected behavior:
I would expect the input to not accept more characters than the max lenght when the virtual keyboard is open.
Related code:

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
global packages:

    @ionic/cli-utils : 1.4.0
    Cordova CLI      : 7.0.1
    Ionic CLI        : 3.4.0

local packages:
    @ionic/app-scripts              : 1.3.7
    @ionic/cli-plugin-cordova       : 1.4.0
    @ionic/cli-plugin-ionic-angular : 1.3.1
    Cordova Platforms               : android 6.2.3
    Ionic Framework                 : ionic-angular 3.2.1

System:

    Node       : v6.10.0
    OS         : Windows 8.1
    Xcode      : not installed
    ios-deploy : not installed
    ios-sim    : not installed
    npm        : 3.10.10

I tried to do something like this once, take a look at this, see if it is relevant.
In my case, the problem was that writing for example more than 75 characters, trims the new characters, so the change detection does not recognize anything as changed, but when I do something that updates the change detection it gets the correct value.
Not sure this is the case though.

@RuneStenstroem out of curiosity are you using the default google keyboard that comes in stock android? We've ran into some weird issues before that were similar to this with people using third party keyboards on android.

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

Sorry for the late reply, i am using a huwai phone so i do not think it is a stock keyboard. I will try it on another phone today.


Feature - Allow for Calendars to be Joint

Feature to mix all the calendars on output into one node rather then separated as a feature.

I'm sorry, I don't understand. Could you elaborate?

So say the output is:

Calendar 1

14:00 Management Meeting
17:30 Team Meeting

Calendar 2

10:00 Stand Up

We should have the option to have:

Calendars

10:00 Stand Up
14:00 Management Meeting
17:30 Team Meeting

So we have a joint boolean setting, should be relatively easy to do by joining the output objects and re-ordering.

Do you mean gantt view here?

No, this is when you press the calendar button from the plugin in the journal and it pastes the agenda (fetching from calendar)


Window.blur - Release All

Only release buttons actually held instead of releasing everything on window blur.

This is not even working for held buttons 😒


awverify?

Have you removed the possibility to use awverify to prepare the custom domain name mappings? I have not managed to do this like usual and the UI in Azure Portal seem to have changed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 224b73dd-c59d-a833-0d4d-a778af6086a9
Version Independent ID: c6b167c9-9589-45d0-ee6a-7a47a4aec41e
Content: Map an existing custom DNS name to Azure Web Apps | Microsoft Docs
Content Source: articles/app-service/app-service-web-tutorial-custom-domain.md
Service: app-service-web
GitHub Login: @cephalin
Microsoft Alias: cephalin

@Zebusch It's documented here: https://docs.microsoft.com/en-us/azure/app-service/app-service-custom-domain-name-migrate

@Zebusch Thanks for your feedback. Does Cephas' answer provide you the information you need?

@MicrosoftDocs/azure-cxp-triage #please-close, issue can be reopened if the document provided isn't sufficient.

@Zebusch
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Better register handling

Need a better way to consider register behaviour, e.g. being clobbered after function calls, and in particular, both avoid string comparisons and deal with different ABIs sensibly.

Related conversation: https://github.com/ethteck/splat/pull/148#discussion_r883127237

Idea: make a class for registers that can have appropriate attributes.

Idea: ABI-indexed dict of sets for each category.

Cons:
* Have to always carry the ABI around.

The current ABI is stored on InstructionConfig.GPR_ABI_NAMES and InstructionConfig.FPR_ABI_NAMES, which are accessible everywhere, so that shouldn't be a problem


[WIP] Add support to make module glob work

Current coverage is 93.10% (diff: 100%)

Merging #7 into issues/2 will increase coverage by 0.12%

@@           issues/2         #7   diff @@
==========================================
  Files             2          2
  Lines           114        116     +2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            106        108     +2
  Misses            8          8
  Partials          0          0

Powered by Codecov. Last update d0798f6...8d0ed0a


We now have the ability to increase the default "timeout" setting via SPRING_CLOUD_DEPLOYER_CLOUDFOUNDRY_TASK_TASK_TIMEOUT flag and it is documented.


[FEATURE] Add String Case Methods in Expressions

Description of the requested feature
Add the following string case related functions to the expression language:

lower(string) -> string
upper(string) -> string
I don't other conversions (uppercase first letter, snake case, camel case, etc) are that common and can be done with regex.
Potentially also useful:
strip(string) -> string - (remove whitespace from either side of a string) maybe the default string widget and label should  automatically strip their text?

Proposed configuration syntax
I'm assigning css classes based on the battery status from EWW_BATTERY.BAT0.status, which returns the status as a string starting with a capital letter, which isn't the convention for css classes. It would look like this:
(defwidget battery []
  (box :class "battery ${lower(EWW_BATTERY.BAT0.status)}"
  ...)
)

Additional context
All these operations are already possible with regex, but I feel like they're common enough to warrant dedicated methods.

hi dear
Sounds good, i coded it but i had no time to test it can you please test it if it works i can open a pull request to the main
String Methods

hi dear Sounds good, i coded it but i had no time to test it can you please test it if it works i can open a pull request to the main String Methods

I tested it and it works great, I think trim is actually a better name than strip (I was looking at the python string methods names when thinking about the names)

Okay, thanks i will rename it and open a pull request to the master later on today


Identifiers validation failed for dataset Caracterización y monitoreo de la condición arrecifal en cinco áreas naturales protegidas y un área de influencia de Quintana Roo, México: Primera etapa

Identifier validation failed for the dataset Caracterización y monitoreo de la condición arrecifal en cinco áreas naturales protegidas y un área de influencia de Quintana Roo, México: Primera etapa:

Crawler attempt: 321
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 3683
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 3683 total records; 3683 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3741452/step

New IDs sample:

Old IDs sample:

000bd6bfe6199ad213889e328aba6a9b
01fc7200bfd02f97d199c969ecd34091
02a22ba2b508abdda9a5e7a577b31650
03648e6591b6f180b4f79bdb16e31b3a
04a6f1bb5e016f47c4eb34e7e9728cc1
04c52c1658e30e2f0a13c0166fa4f92b
0582d8d199e45efa840eec9c832a9858
062efef3ce50f2daadc6847607c97a45
06c6405e8297b05f7c493c63ffea9dc0
073f06a83a461a78f9b658c7f20b6dbc

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Caracterización y monitoreo de la condición arrecifal en cinco áreas naturales protegidas y un área de influencia de Quintana Roo, México: Primera etapa : https://doi.org/10.15468/yx7eck.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Caracterización y monitoreo de la condición arrecifal en cinco áreas naturales protegidas y un área de influencia de Quintana Roo, México: Primera etapa:

Crawler attempt: 323
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 3683
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 3683 total records; 3683 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3741770/step

New IDs sample:

Old IDs sample:

000bd6bfe6199ad213889e328aba6a9b
01fc7200bfd02f97d199c969ecd34091
02a22ba2b508abdda9a5e7a577b31650
03648e6591b6f180b4f79bdb16e31b3a
04a6f1bb5e016f47c4eb34e7e9728cc1
04c52c1658e30e2f0a13c0166fa4f92b
0582d8d199e45efa840eec9c832a9858
062efef3ce50f2daadc6847607c97a45
06c6405e8297b05f7c493c63ffea9dc0
073f06a83a461a78f9b658c7f20b6dbc

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Caracterización y monitoreo de la condición arrecifal en cinco áreas naturales protegidas y un área de influencia de Quintana Roo, México: Primera etapa : https://doi.org/10.15468/yx7eck.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


use ipcRenderer.sendSync instead of remote.getGlobal

As of electron v10, enableRemoteMoudle is set to false by default, and I had to enable it for this library.
And from v12, remote module was deprecated for security reason and it started to show warning message on devTools console.
I found that getInitialStateRenderer is using remote.getGlobal so I substitute ipcRenderer.sendSync to it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@victorhqc Can this be merged and published soon? I know there's version 2, but it's still technically in alpha stage and Electron is already at version 17, 3 versions after the remote module was removed.


HTTP 404 error on reload

It seems the presentation view in the browser is not automatically updated as expected on code/files change.
Instead, this is shown on the browser:
Traceback (most recent call last):
  File "/container/miniconda/envs/python37/lib/python3.7/site-packages/tornado/web.py", line 1699, in _execute
    result = await result
  File "/container/miniconda/envs/python37/lib/python3.7/site-packages/tornado/web.py", line 2577, in get
    self.absolute_path = self.validate_absolute_path(self.root, absolute_path)
  File "/container/miniconda/envs/python37/lib/python3.7/site-packages/tornado/web.py", line 2779, in validate_absolute_path
    raise HTTPError(404)
tornado.web.HTTPError: HTTP 404: Not Found

Reloading the browser is enough (i.e.: Markdownreveal does not really crash).

any steps to reproduce this?
I'd like to take a look at it and fix it. ie., asking to assign me this issue.

@sakethramanujam Yeah:

Install Markdownreveal on a fresh environment with Python 3.6+
mdr presentation.md to open the presentation on your browser
Edit and save changes in presentation.md

That should trigger the error. You can use this presentation as an example (maybe it only occurs with "big" presentations, I do not know):
https://github.com/Peque/PyConES-Spain-2019-tools


Default sort order is reversed

Issue:
Default sort order is reversed
what should be:
When opening a list page, the default sort is first column using alphabetical sort
what happen:
When opening a list page, the default sort is first column using reverse alphabetical sort
Screenshot:

cc:// @orenc1


Cursor fragment isn't rendered anymore

When Surface is blurred the cursor disappears, when before we had the cursor fragment rendered.

We don't master the native blur event yet -- it is pretty inconsistent across browsers regarding order of events, when it gets called and so on.
Let's shift it and find a quiet time for that.

We don't do this ATM.


Improve logging of network programming latency measurement

Refactor exsiting measurements to make use of shared utilities.
ref https://github.com/kubernetes/perf-tests/issues/640
/hold

/test pull-perf-tests-clusterloader2
/test pull-perf-tests-clusterloader2-kubemark

/assign @mm4tt @krzysied

/hold cancel

/lgtm

/hold

/hold cancel


fix(forge-bind): allow attrs and mod single_file imports

Motivation

clippy fails for generated code.
--module --single-file added a pub use counter::*; before every generated module, when modules were already pub. This would fail compilation.

Solution

Add #[allow(clippy::all)]
Remove unnecessary pub use module_name::* from single file modules.

@mattsse any reviews? Else merge pls


[DO NOT MERGE] Rename "Gambia" to "The Gambia"

https://trello.com/c/iwDCm6tR/353-change-slugs-from-gambia-to-the-gambia

Making this DNM until we get the go ahead.


Bring in DevOps updates

This repo predates the "official" release of our QuickStart.  Misc ticket to bring over new pipeline features and actions.  Please expect multiple tickets.

@DerekRoberts great job! Thanks for bringing that in. I believe that our dev workflow are working almost as expected (I think it's a little behind the latest version of the deployer-action) but for test and prod definitely some work is required, since all the workflows are still using the manual deploy actions.


Unable to retrieve child resources.

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.23.1
Regression From
No response
Architecture
x64
Storage Explorer Build Number
20220406.1
Platform
Linux (snap)
OS Version
Linux Mint 20.2
Bug Description
I connected the application with a customer key, in his server I can see all tree, but on my PC I have a "not found" error browsing the tree.
This is the log:
azure_trace.log
Many thanks
Luca
Steps to Reproduce

Launch Storage Explorer
Expand a blob container node

Actual Experience
When I browse the tree I have an ENOTFOUND error popup
Unable to retrieve child resources.
Details:
{
"name": "RestError",
"message": "request to https://xxx.blob.core.windows.net/?comp=list&include=metadata failed, reason: getaddrinfo ENOTFOUND xxx.blob.core.windows.net",
"stack": "RestError: request to https://xxx.blob.core.windows.net/?comp=list&include=metadata failed, reason: getaddrinfo ENOTFOUND xxx.blob.core.windows.net\n    at NodeFetchHttpClient.sendRequest (/snap/storage-explorer/33/resources/app/node_modules/@azure/core-http/dist/index.js:2670:23)\n    at processTicksAndRejections (node:internal/process/task_queues:96:5)\n    at async CoreHttpLogHttpClient.sendRequest (/snap/storage-explorer/33/resources/app/node_modules/@storage-explorer/azure-sdk-helpers/dist/src/HttpClients/CoreHttpLogHttpClient.js:31:34)\n    at async StorageRetryPolicy.attemptSendRequest (/snap/storage-explorer/33/resources/app/node_modules/se-blob-extension/node_modules/@azure/storage-blob/dist/index.js:14086:24)\n    at async StorageClientContext.sendOperationRequest (/snap/storage-explorer/33/resources/app/node_modules/@azure/core-http/dist/index.js:4934:31)\n    at async BlobServiceClient.listContainersSegment (/snap/storage-explorer/33/resources/app/node_modules/se-blob-extension/node_modules/@azure/storage-blob/dist/index.js:23132:20)",
"code": "REQUEST_SEND_ERROR",
"request": {
"streamResponseStatusCodes": {},
"url": "https://xxx.blob.core.windows.net/?comp=list&include=metadata",
"method": "GET",
"headers": {
"_headersMap": {
"x-ms-version": {
"name": "x-ms-version",
"value": "2020-10-02"
},
"accept": {
"name": "Accept",
"value": "application/xml"
},
"user-agent": {
"name": "User-Agent",
"value": "Microsoft Azure Storage Explorer, 1.23.1, linux azsdk-js-storageblob/12.8.0 (NODE-VERSION v16.9.1; Linux 5.4.0-109-generic)"
},
"x-ms-client-request-id": {
"name": "x-ms-client-request-id",
"value": "5c37dfe7-d4e6-4901-a679-04e169af8767"
},
"x-ms-date": {
"name": "x-ms-date",
"value": "Thu, 21 Apr 2022 14:46:05 GMT"
},
"authorization": {
"name": "Authorization",
"value": "Signed SharedKey Redacted="
},
"cookie": {
"name": "Cookie",
"value": ""
}
}
},
"withCredentials": false,
"timeout": 0,
"keepAlive": true,
"decompressResponse": false,
"requestId": "5c37dfe7-d4e6-4901-a679-04e169af8767",
Expected Experience
No response
Additional Context
No response

how can we fix this ?

Hi,
tell me why I can browse the tree on a Windows machine, but I can't on my Linux machine even when I put the same key.
It seems to me a bug of the Linux version of storage-explore, so I reported to community, but if you think it's not, close the thread.
Bye

@f1zb4n72 can you try enabling System Proxy? Go to settings (gear on the left) -> application -> proxy, and then change the dropdown to "System Proxy (Preview)".

Closing due to lack of response. If you are still encountering this problem we recommend opening an Azure support ticket from the portal. You can also open a new issue here.