Make CLI work for RPC calls

This PR includes:

Test cases to ensure we can call RPC by passing string arguments
An update to the CLI to call RPC by passing string arguments. Results are displayed to the console.

Well Excellent job plus @Aprogiena comments ;)

I haven't made a full review, just couple of suggestions, feel free to require fixing them or ignoring them.

Thanks @quantumagi


debug target

how do you think - what can be a reason of no debug target available in status line?
this is in cmakelists and user settings:
cmake_minimum_required (VERSION 3.7.2)
    "cmake.experimental.useCMakeServer": true,
helper script does no present in cmakelists however
however I could set this from command palette via set/debug target
I mean status bar was empty initially, after selecting from command palette this was reflected in status line too
it can be easily reproduced by deleting your extension's settings json

got the reason of the problem.
firstly , need to add that added debug target from command palette, didn't work because of "can't find "...\my.exe".
actually , this was not my project and I've looked at the cmakelists with more attention just now and find this:
set(CMAKE_BINARY_DIR ${CMAKE_SOURCE_DIR}/Build)
set(EXECUTABLE_OUTPUT_PATH ${CMAKE_BINARY_DIR}/bin)
set(LIBRARY_OUTPUT_PATH ${CMAKE_BINARY_DIR}/lib)

you see - script sets the folders manually, but the extension looks for the exe in Build folder specified in own settings:
           "buildDirectory": "C:/dev/workspace/Restweb/build",
correct?
is it possible (for the extension) to check CMAKE variables which contain those paths?

That's peculiar... It should be able to find the output file, no matter what settings are used to set its path.
Setting CMAKE_BINARY_DIR looks extremely fishy... I'm not sure what CMake will even do in that case.

for the settings above, when CMAKE_BINARY_DIR refers to the same folder as an extension setting,
cmake did exactly what is described in cmakelists:

various build files were placed into Build folder
exe - into Build/bin subfolder.
but debug target does still refer to unexisting exe in Build folder

I suggest to close this type of issues, due the problem is in cmake

This problem should be fixed in the latest release.


Accessibility

It'll would be awesome if we can make this plugin accessible.
/CC @Lausselloic, and @patrickhlauke if you have time 😄

Hello,
I will try to make a PR. But the ideas are :

Use the tabs pattern for accessibility. aria-controls,
Replace links by buttons as they don't go to another page, and set the state disabled on disabled states
On non linear stepper add a previous button when previous state is available


[INLONG-4761][Manager] Optimize DataNode related business and write some unit tests

Prepare a Pull Request
(Change the title refer to the following example)

Fixes #4761

Motivation

Missing unit tests
The validation method is not used correctly
Find some bugs

Modifications

Add addReq and UpdateReq interfaces for add and update validation
Add unit test DataNodeControllerTest

Verifying this change
(Please pick either of the following options)

[x] This change is already covered by existing tests, such as:

DataNodeControllerTest

@leosanqing please process the conflict firstly.

@leosanqing please process the conflict firstly.

done


Add new Property SpotRestorePolicy to VMScaleSets

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

The test failures in the CI checks are failing due to the API version not being updated for the Compute RP tests.

/azp run

/azp rerun

@sandeepkv93 Could you please provide the link to the Swagger PR?

@nisha-bhatia  https://github.com/Azure/azure-rest-api-specs/pull/14692


Support external Mangadex downloads

Support Mangadex downloads where the link to the image exists on external sites

not possible due to hosting problems


Created Login Form

Description
This is the form for login in order to review resume
Fixes # (44)
How to test?
can be tested in storybook
Checklist

[x ] I have performed a self-review of my own code
[x ] I have commented my code, particularly in hard-to-understand areas
[x ] I have made corresponding changes to the documentation
[ x] This PR is ready to be merged and not breaking any other functionality

@kamalrsa see if you can refactor the way this one uses validation and setting form data values:
ref: https://github.com/HackYourFuture-CPH/rate-my-cv/pull/131
Also, it would be great if you could do a review here.

@kamalrsa see if you can refactor the way this one uses validation and setting form data values:
ref: #131
can we make the same pattern for password
Also, it would be great if you could do a review here.


Deprecate the old reference implementations, once this is released

We should update the pages of the old implementations to reference this new one.
The old reference implementations are under https://github.com/eclipse/lyo.rio
https://github.com/eclipse/lyo.rio/tree/master/rio is one
https://github.com/eclipse/lyo.rio/tree/master/rio-oslc4j is two
https://github.com/eclipse/lyo.rio/tree/master/rio-oslc3/org.eclipse.lyo.oslc.v3.sample is not a full RIO but just a sample of OSLC3/LDP implementation.

We should actually ask Eclipse to archive the RIO repo.


adding in function to have separate cohorts or combine them together for package

At the moment a user has to instanstiate each drug of interest for cohort symmetry but what if a user wants to combine different drugs cohorts together in one cohort as well as test them individually. Example is dementia medications there are two types 1) Ache inhibitors (three ingrediants) and 2) memantine. I want to run cohortsymmetry with Ache inhibitors with all three ingrediants together as well as them indivdually against my marker drugs of choice. @xihang-chen suggested including an argument in the getSequenceRatio() which gives the user flexibility to do this.

Also does the package make sure that we have unique entries when combining cohorts? ie one record per person when combining cohorts otherwise there might a patient might contribute multiple times?

Regarding point above when you create a cohort with multiple ingredients it will take the first one of all the ingredients combined - therefore only 1 person contributes. However when you run each ingredient there is a chance if a person has been prescribed different ingredients from the same class meaning that a person could contribute to multiple times. @xihang-chen and I discussed this and think if users want to make sure each cohort of ingredients only have 1 person per ingredient then users can group_by and add a filter to only keep the first ingredient they are prescribed. So meaning this is a user problem not a package problem


Exact command to obtain base waterbirds model

I'm trying to reproduce the 74.9% worst case and 98.1% average test accuracy on Waterbirds, but could not do so. I'm running the command below.
python3 train_classifier.py --output_dir=<OUTPUT_DIR> --pretrained_model \
  --num_epochs=100 --weight_decay=1e-3 --batch_size=32 --init_lr=1e-3 \
  --eval_freq=1 --data_dir=<WATERBIRDS_DIR> --test_wb_dir=<WATERBIRDS_DIR> \
  --augment_data --seed=<SEED> --num_minority_groups_remove=0

Were you able to?

Hi! Which worst-group and average accuracies do you get instead? @alexlioralexli @rahulv54

I did it sometime back. Let me check again.

I ran your example command of ERM (base model) in README for Waterbirds, and I can only get average accuracy of 90-93% instead of >=97% (reported in your paper). Could you try re-running the codebase & provide the exact commands for the reproduction of your results? Thank you! @PolinaKirichenko @izmailovpavel @andrewgordonwilson

Hey @Haoxiang-Wang, the average accuracy in the paper (and in general reported in the papers in this area) is the accuracy according to the training group distribution. I.e. you compute accuracy on each group and average these accuracies with weights corresponding to the proportions of groups in the training data.
Our training script does not output average accuracy, it simply outputs the accuracy on the test set. In waterbirds, the test set is close to uniform across groups, so the test set accuracy is lower than the average accuracy.


KYLIN-4336 Global domain dict for MR build engine

issue link: https://issues.apache.org/jira/browse/KYLIN-4336

Pull Request Test Coverage Report for Build 5515

19 of 111 (17.12%)  changed or added relevant lines in 8 files are covered.
8 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.02%) to 27.502%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
5
6
83.33%

core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/DictionaryRule.java
4
5
80.0%

engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java
0
1
0.0%

core-metadata/src/main/java/org/apache/kylin/metadata/model/DataModelDesc.java
5
8
62.5%

core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapMeasureType.java
0
4
0.0%

core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java
3
10
30.0%

core-cube/src/main/java/org/apache/kylin/cube/model/DictionaryDesc.java
2
10
20.0%

core-cube/src/main/java/org/apache/kylin/cube/model/CubeDescTiretreeGlobalDomainDictUtil.java
0
67
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java
1
69.81%

core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
2
80.23%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
5
77.81%

Totals

Change from base Build 5512:
-0.02%

Covered Lines:
24139

Relevant Lines:
87771

💛  - Coveralls

Codecov Report

Merging #1056 into master will increase coverage by 0.02%.
The diff coverage is 10%.

@@             Coverage Diff              @@
##             master    #1056      +/-   ##
============================================
+ Coverage        25%   25.03%   +0.02%
- Complexity     6180     6225      +45
============================================
  Files          1438     1441       +3
  Lines         87669    87972     +303
  Branches      12256    12305      +49
============================================
+ Hits          21926    22026     +100
- Misses        63593    63779     +186
- Partials       2150     2167      +17

Impacted Files
Coverage Δ
Complexity Δ

...be/model/CubeDescTiretreeGlobalDomainDictUtil.java
0% <0%> (ø)
0 <0> (?)

...apache/kylin/measure/bitmap/BitmapMeasureType.java
18.86% <0%> (ø)
4 <0> (ø)
:arrow_down:

...ache/kylin/engine/mr/common/AbstractHadoopJob.java
15.21% <0%> (-0.04%)
2 <0> (ø)

...va/org/apache/kylin/cube/model/DictionaryDesc.java
65.38% <10%> (-34.62%)
8 <1> (+1)

...ain/java/org/apache/kylin/cube/model/CubeDesc.java
63.56% <20%> (-0.57%)
182 <1> (+1)

...org/apache/kylin/metadata/model/DataModelDesc.java
59.21% <25%> (-0.58%)
72 <1> (-1)

...c/main/java/org/apache/kylin/cube/CubeManager.java
36.52% <50%> (+0.02%)
44 <0> (ø)
:arrow_down:

...lin/cube/model/validation/rule/DictionaryRule.java
86.84% <60%> (-4.59%)
16 <1> (+1)

...engine/spark/util/PercentileCounterSerializer.java
90.47% <0%> (-9.53%)
3% <0%> (ø)

.../org/apache/kylin/dict/lookup/SnapshotManager.java
68.5% <0%> (-3.82%)
30% <0%> (+3%)

... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3777021...1c1fbe5. Read the comment docs.

Merged in PR https://github.com/apache/kylin/pull/1058


Add paths-ignore

I offer to make two changes:

rename input parameter filters to paths, so it looks like workflow event
add paths-ignore: set true if at least one file doesn't match any path in filter group

Thanks for the offer :)
Regarding 1)
In the beginning of the project I actually decided to not try it to look like the workflow event paths option.
The reason was that workflow paths option is directly list of paths while this action accepts several lists, each given a name.
Also here we use minimatch, while workflow uses some custom syntax.
This differences could be confusing for the user. Well, I'm really not sure if it was a good decision, but it's already there.
If we should change it, then I would do it on the develop branch together with other changes and release them together.
I will think about it.
Regarding 2)
Could you please add some example use case? I'm not sure if I get correctly how it should work.

Regarding 2)
for example I have such repo

src
.gitignore
.github
README.md

In workflow I want to check if pull request change only files in src folder or other files. So I need check in workflow
- uses<EMAIL_ADDRESS>  name: "src files changes
  id: filter
  with:
    paths: |
      src_changed:
        - 'src/**'
    paths-ignore: |
      other_changed:
        - 'src/**'

Cases:

changed:

src/index.js
result:
src_changed: true
other_changed: false

changed:

src/index.js
.gitignore
result:
src_changed: true
other_changed: true

changed:

.gitignore
result:
src_changed: false
other_changed: true

changed:
[]
result:

src_changed: false
other_changed: false

But while I try to realize it, I understand that it would some troubles with output values. And it will be much easier to add one more parameter: NOT (I am not sure how to call it).
Previous example will be changed like that
- uses<EMAIL_ADDRESS>  name: "src files changes
  id: filter
  with:
    not: true
    paths: |
      src_changed:
        - 'src/**'

Cases:

changed:

src/index.js
result:
src_changed: false

changed:

src/index.js
.gitignore
result:
src_changed: true

changed:

.gitignore
result:
src_changed: true

changed:
[]
result:

src_changed: false

Ah, got it.
This is actually already supported by minimatch - library which is internally used to evaluate the path matches.
You just have to add leading ! and wrap the whole path with ' or " as leading exclamation mark has some special meaning in YAML.
Given your first example, I think this should work fine:
- uses<EMAIL_ADDRESS>  name: "src files changes
  id: filter
  with:
    paths: |
      src_changed:
        - 'src/**'
      other_changed:
        - '!src/**'

Could you please verify if it works for your use-case?

Yes, you were right, it works.
I think it will be nice to add link to minimatch to readme file. It make easy to understand how filter input works.

Actually, the link is there, on top of the usage section.
But it doesn't matter, the README is doing quite poor job and I'm aware of it.
I'm reworking it completely. It will have much more examples that are easier to understand than bunch of text and links.
I will add this use-case as one of the examples.


Remove Reset.qs, move to qsharp-runtime.

This PR removes Reset.qs from the libraries in preparation for moving this file to qsharp-runtime. Note that this PR should not be merged in before #246.

Looks like the build is failing because https://github.com/microsoft/qsharp-runtime/pull/199 needs to be completed first. Let me merge that one since you approved, @swernli, and then I'll update this PR to use the CI version built from that PR. Thanks!


Darin's data more of South America, semi processed, Miocene

Activity
Show details
Write a comment…
Oscar Wilson Apr 3, 2023 4:06 PM
@indrezliobaite Will go through and add/check starting early next week when I'm back from my research visit
Reply • Delete
indre.zliobaite Apr 3, 2023 2:15 PM
Oscar is actively doing South America. His call what to do with this?
Reply • Delete
indre.zliobaite Sep 25, 2019 11:42 AM
Indre: I can enter at some point, but not in the coming months. Data is not just for entering, needs a bit of curation.

Croft 2009 IMC Miocene Localities Poster.pdf
Faunal Lists 1 Late Mio.xls
Faunal Lists 2 Mid Mio.xls
Faunal Lists 3 Early Mio.xls


Race conditions

Since 'mountedInstances' is a static property on DocumentTitle it's shared state across all requests.
Doesn't this cause race conditions? I'm not sure I totally get how it works yet (i'm new to nodejs and react too).

It wouldn't be thread safe but I'm not aware of any JS environment that has threads.
Node is single-threaded too, or to be more correct, parts exposed to the user are.
That's why there are no synchronization/locking mechanisms in JS.

However there very well may be potential concurrency issues if parts of component hierarchy are async.
Would you like to submit a failing test?

Yes, I'm aware of the fact that nodejs and js in general is single threaded.
Just browsed your code a bit more, it seems like this line:

DocumentTitle.mountedInstances.splice(0);
in the rewind function does the magic.
Thanks anyway!

Yeah, it helps to clean up between the requests.
But I wonder what happens if requests are render asynchronously:

User A requests page, we're waiting on a promise a la third example with fetchData
User B requests another page and we're waiting on another promise
Promise for user A completes. But whoops! The title from B's request has already leaked into static instances!

So I think there's a potential pitfall there, thanks for reporting.
I'm not sure how to solve this API-wise, what do you think?
cc @pluma

I wonder if we should split component in two, similar to how react-router has separate Router.create and RouteHandler.
One would be at the root, and it would be created per each request. This is where rewind() would be defined:
var DocumentTitle = require('react-document-title');

something.serve(function (req, res) {
  // note: this runs for each request
  var DocumentTitleRoot = DocumentTitle.createRoot();

  Router.run(routes, req.path, function (Handler, state) {
    fetchData(state.matches).then(function (data) {
      var html = React.renderToString(
        <DocumentTitleRoot>
          <Handler data={data} />
        </DocumentTitleRoot>
      );

      // Get title from our per-request type
      var title = DocumentTitleRoot.rewind();

      req.send(`<html><head><title>${title}</title></head><body>${html}</body></html>`);
    });
  });
});

I think this + #5 would make a nice 1.0.
also cc @insin, I think he may have comments about this approach

React.renderToString (which is used to render React on the server) is synchronous, so the entire point seems moot. The only environment in which race conditions could be an issue are multi-threaded ones using React.render (which requires a DOM) -- but then the DOM is already broken if it is shared between threads.
As long as you don't make assumptions about the state of the components outside the event loop iteration in which they were rendered, you'll be fine. Just fetch the current document title immediately after rendering if you need to access it asynchronously.

Oh wait, you're actually right.
fetchData example is async but componentWillMount and friends run sync inside renderToString.
Sorry, that was a brainfart on my part!
Closing.

FWIW, I had the exact same brainfart with fetchData and this :smile:

lol

@gaearon

It wouldn't be thread safe but I'm not aware of any JS environment that has threads.
Node is single-threaded too, or to be more correct, parts exposed to the user are.
That's why there are no synchronization/locking mechanisms in JS.

Wrong.
The point of Node.js is not being single threaded — it would be absolutely pointless that way.
The point of Node.js is that it's concurrent by its very nature the main thing being streams and events.
So this library surely has a bug and breaks in case of any concurrency.

@pluma

React.renderToString (which is used to render React on the server) is synchronous, so the entire point seems moot.

Wrong.
There's a big movement currently towards asynchronous rendering in React and it has been admitted even in Facebook themselves.

@halt-hammerzeit First of all, please consider adjusting your tone. "Wrong" is unnecessarily confrontational and not conducive to any discussion. If you want a maintainer of an open source project to change something in their code for you, you probably should try not to alienate them.
Now to your comments:

The point of Node.js is that it's concurrent by its very nature

The dismissal of "thread safety" was based on the original title of this issue. Node.js indeed doesn't use threads, nor do any browsers. In fact, multi-threaded JS environments (in the sense that C++ or Java are multi-threaded) would be inherently incompatible with much of the JS ecosystem, hence @gaearon's dismissal of the worries about "thread safety".
To clarify: there are environments where JS is executed on multiple threads, but the threads are almost completely isolated. For example web workers are basically worker threads but they can only communicate with the main thread via strings, not shared objects.

There's a big movement currently towards asynchronous rendering in React

I'm sure @gaearon is aware of that as you're likely talking about Fiber. However the comment you're replying to is from January 2015, more than two years ago. At the time renderToString was synchronous and it's been that way for a long while. So not only wasn't my statement wrong within its context but it's still true now. The change from synchronous to asynchronous will be backwards incompatible so by definition pre-existing code may break in (un)expected ways.
That said, with renderToString potentially becoming asynchronous in the future it's probably worth looking into how to make react-document-title (and similar libraries like react-helmet) work without relying on global state. When this library came out Context wasn't a big thing yet and even state libraries generally didn't use it (Redux itself didn't get started until May 2015 and wasn't really "a thing" until July 2015 when Dan presented it at React Europe). It'd be interesting to come back to these problems with a modern understanding of React and see what could be done differently.

@pluma

First of all, please consider adjusting your tone. "Wrong" is unnecessarily confrontational and not conducive to any discussion. If you want a maintainer of an open source project to change something in their code for you, you probably should try not to alienate them.

Don't you tell me how to express my attitude, boy

The dismissal of "thread safety" was based on the original title of this issue. Node.js indeed doesn't use threads, nor do any browsers.

This has nothing to do with "threads", it is about "thread safety", so you clearly don't understand the real meaning of this phrase.

So not only wasn't my statement wrong within its context but it's still true now.

No, it was and it is still wrong

The change from synchronous to asynchronous will be backwards incompatible so by definition pre-existing code may break in (un)expected ways.

Yeah, if you release a broken package once, you can't ever update it, right, because it would break things that are already broken, sure, great logic in that.

 But everybody else is also at liberty to ignore you if you are unnecessarily hostile.

This has nothing to do with "threads", it is about "thread safety", so you clearly don't understand the real meaning of this phrase.

Here's what Wikipedia has to say:

Thread safety is a computer programming concept applicable in the context of multithreaded programs. A piece of code is thread-safe if it manipulates shared data structures only in a manner that guarantees safe execution by multiple threads at the same time.

Note how it says "in the context of multithreaded programs". No threads, no thread safety. The title was later corrected to put "thread safety" in scarequotes because the issue is about concurrency in general rather than thread safety in the concrete sense.

Yeah, if you release a broken package once, you can't ever update it, right, because it would break things that are already broken, sure, great logic in that.

Within the limitations of React at the time, this library is not broken. It's still possible to use it correctly although you need to be aware that the title can only be read in the same tick renderToString was called. So it's not broken, just error prone when used incorrectly. But it's certainly not future proof (i.e. it will no longer be useful when the API changes post-Fiber) and it's worth revisting this and other libraries built on react-side-effect to address that concern.
That said, this is the last time I will respond to your comments here. I have better things to do than spending my free time on people as abrasive as you are presenting yourself here.

You can never reclaim it back.
Deal with it.

Reminder: React 16 is out and ReactDOMNodeStream.renderToNodeStream(element) is there.


Refactor utils/tmpdir.go

utils/tmpdir.go includes only one function and it's only used inside daemon/daemon.go. I think it could be better to get rid of utils/tmpdir.go and move tempDir inside daemon/daemon.go

#dibs


search in only modified files

I often want to search for a term in only files I've modified.
for example, if I use console.log all over the place for debugging and then solve the problem, I'd like to search for that in files I've modified so that I can remove those and then commit the other changes.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


bugfixcatch exception for fetching SchemaTableData

Proposed changes
If the exception is not caught manually, the exception will be handled by the RPC framework, resulting in the inability to intuitively obtain error information from the MySQL client.
Manually catch the exception and view the error information directly from the client when an error occurs.
before：
ERROR 1105 (HY000): errCode = 2, detailMessage = (<IP_ADDRESS>)[CANCELLED][THRIFT_RPC_ERROR]failed to call frontend service, FE address=<IP_ADDRESS>:39021, reason: Internal error processing fetchSchemaTableData

after:
ERROR 1105 (HY000): errCode = 2, detailMessage = (<IP_ADDRESS>)[CANCELLED][INTERNAL_ERROR]TStatus: Table does not exist: db1.iceberg_position_orc

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


fix(databases): moved codes to global configs.

Issue link
Closes #41
What does this PR do?

Moved workaround logics from manage.py to settings.py

What does not include in this PR?
   3 seconds ago   Up 2 seconds   <IP_ADDRESS>:3306->3306/tcp, :::3306->3306/tcp   mysql

% docker exec -it django curl -s -D - -o /dev/null -X GET localhost:8000/home/
HTTP/1.1 200 OK
Server: gunicorn
Date: Wed, 20 Dec 2023 16:54:18 GMT
Connection: close
Content-Type: text/html; charset=utf-8
X-Frame-Options: DENY
Content-Length: 3679
X-Content-Type-Options: nosniff
Referrer-Policy: same-origin
Cross-Origin-Opener-Policy: same-origin


[BUG] Performance is slower when using consolidateBy function and maxdatapoints

Describe the bug
When querying a graphite metric over 150d, I was expecting to use the consolidateBy function and the maxdatapoints options to speed up the query: Both approach failed
To Reproduce
When decreasing the datapoints number the request take longer.
When trying to leverage this performance (using the consolidatebyfunction last ) the results are equivalent:
root@nuc:~$ time wget   --post-data="target=openhab.consommeHP_Fours&from=-150d&until=now&format=json&maxDataPoints=1000"  http://<IP_ADDRESS>/render
--2021-05-24 14:14:56--  http://<IP_ADDRESS>/render
Connexion à <IP_ADDRESS>:80… connecté.
requête HTTP transmise, en attente de la réponse… 200 OK
Taille : 25924 (25K) [application/json]
real    0m0,804s
user    0m0,001s
sys     0m0,009s

root@nuc:~$ time wget   --post-data="target=openhab.consommeHP_Fours&from=-150d&until=now&format=json&maxDataPoints=100"  http://<IP_ADDRESS>/render
--2021-05-24 14:15:01--  http://<IP_ADDRESS>/render
Connexion à <IP_ADDRESS>:80… connecté.
requête HTTP transmise, en attente de la réponse… 200 OK
Taille : 2820 (2,8K) [application/json]
real    0m2,017s
user    0m0,006s
sys     0m0,005s

root@nuc:~$ time wget   --post-data="target=openhab.consommeHP_Fours&from=-150d&until=now&format=json&maxDataPoints=10"  http://<IP_ADDRESS>/render
--2021-05-24 14:15:06--  http://<IP_ADDRESS>/render
Connexion à <IP_ADDRESS>:80… connecté.
requête HTTP transmise, en attente de la réponse… 200 OK
Taille : 404 [application/json]
real    0m9,091s
user    0m0,009s
sys     0m0,001s

root@nuc:~$ time wget   --post-data="target=consolidateBy(openhab.consommeHP_Fours%2C'last')&from=-150d&until=now&format=json&maxDataPoints=1000&"  http://<IP_ADDRESS>/render
--2021-05-24 14:15:34--  http://<IP_ADDRESS>/render
Connexion à <IP_ADDRESS>:80… connecté.
requête HTTP transmise, en attente de la réponse… 200 OK
Taille : 23727 (23K) [application/json]
real    0m0,921s
user    0m0,004s
sys     0m0,009s

root@nuc:~$ time wget   --post-data="target=consolidateBy(openhab.consommeHP_Fours%2C'last')&from=-150d&until=now&format=json&maxDataPoints=100&"  http://<IP_ADDRESS>/render
--2021-05-24 14:15:40--  http://<IP_ADDRESS>/render
Connexion à <IP_ADDRESS>:80… connecté.
requête HTTP transmise, en attente de la réponse… 200 OK
Taille : 2519 (2,5K) [application/json]
real    0m1,806s
user    0m0,001s
sys     0m0,010s

root@nuc:~$ time wget   --post-data="target=consolidateBy(openhab.consommeHP_Fours%2C'last')&from=-150d&until=now&format=json&maxDataPoints=10&"  http://<IP_ADDRESS>/render
--2021-05-24 14:15:46--  http://<IP_ADDRESS>/render
Connexion à <IP_ADDRESS>:80… connecté.
requête HTTP transmise, en attente de la réponse… 200 OK
Taille : 391 [application/json]
real    0m9,175s
user    0m0,001s
sys     0m0,010s

Expected behavior

I was expecting reducing the maxdatapoint would reduce the query time (I can understand this one because graphite has to calculate all the average, but it is surprising)
I was expecting the consolidateBy function with 'last' or 'first' to be quicker than the default 'avg'
I was expecting faster queries on this database.

Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS flavor: ubuntu with docker and graphiteapp/graphite-statsd:latest@sha256:8ba1a7724618c3140566ab5471ef8464c9e340c24023b2f972caa64243daf45b
Graphite-web version 1.1.8
Python version  3.8
Setup type : docker

Additional context
I am using the following retention :
retentions =  30s:30d,60s:180d,120s:1095d,600s:3650d

and the wsp file info return this:
root@XXX:/var/lib/docker/volumes/graphite-storage/_data/whisper/openhab# whisper-info consommeHP_Fours.wsp
aggregationMethod: average
maxRetention: 315360000
xFilesFactor: 0.5
fileSize: 19915264

Archive 0
offset: 64
secondsPerPoint: 30
points: 86400
retention: 2592000
size: 1036800

Archive 1
offset: 1036864
secondsPerPoint: 60
points: 259200
retention: 15552000
size: 3110400

Archive 2
offset: 4147264
secondsPerPoint: 120
points: 788400
retention: 94608000
size: 9460800

Archive 3
offset: 13608064
secondsPerPoint: 600
points: 525600
retention: 315360000
size: 6307200

Hi @viknet365 ,
Unfortunately, nor consolidateBy nor maxDataPoints not designed to help with query performance. All functions and approximations are done after fetching all data, so, it will only add more work instead of reducing it.

Hi @deniszh,
thank you for your answer, so I understand that by design the full file is fetched in memory before doing calculation, so I can understand in memory calculation can add some overhead,  but in this case, it's a ten time overhead (1s for 1000 points vs 10s for 10 points, and this time is the same when using 'avg' and 'first'/'last' (in this case it should only cherry pick some data and not doing calculation).
Furthermore, If I try to use whisper-fetch ( quite slow, it takes 2,2s) and awk to average the result  (take 200ms to average all the line on a the same computer) :
root@nuc:/var/lib/docker/volumes/graphite-storage/_data/whisper/openhab# time awk '{ total += $2; count++ } END { print total/count }' ./consommeHP_Fours.txt
691537

real    0m0,274s
user    0m0,256s
sys     0m0,017s

and we all agree that both tool are not designed for performance !!!!
There is maybe some good reason for such low performance  in my use case (low CPU, low memory use of docker or a combination of them ), but I am quite puzzled....

behaviour is the same with graphite 1.0.2-3  (4 years old)  so the behaviour has not changed for many years (so its probably not a bug).   still, very surprised with this.
After trial and error I have set many of my grafana maxdatapoints to 2500.
I remove the BUG tag but If anyone has time to explaining this behaviour I will be happy.

I guess the consolidate function is not written with performance in mind. See https://github.com/graphite-project/graphite-web/blob/master/webapp/graphite/render/datalib.py#L100-L135 . The list operations could be done faster by just summing.
Anyway, if you really care about performance you'd better check out the go-graphite stack.

thank for the answer and advice, I realy like golang but I was a bit  skeptical about go-graphite and specially I was not sure it implement all graphite function (there are tons and keeping two project like this synchronized is not easy) . I will try and give performance results I obtain.
In the meantime I tried hacking datalib.py to see where is the bottleneck. I first remove the use of the intermediate use of the buffer buf[] and end up changing :
def __iter__(self):
    if self.valuesPerPoint > 1:
      return self.__consolidatingGenerator( list.__iter__(self) )
    else:
      return list.__iter__(self)

by this
def __iter__(self):
    return list.__iter__(self)

completely removing the use of the __consolidatingGenerator function (we all understand it won't give meaningfull data but it was just a test)
and the performance result are roughly the same (less than a 2s gain ), so it seems the bottleneck is not in these two functions

same hardware, same docker, same wsp file but using go-carbon instead of graphite-web:
root@nuc:~$ time wget   --post-data="target=openhab.consommeHP_Fours&from=-150d&until=now&format=json&maxDataPoints=10&"  http://<IP_ADDRESS>:81/render
--2021-05-25 16:24:50--  http://<IP_ADDRESS>:81/render
Connexion à <IP_ADDRESS>:81… connecté.
requête HTTP transmise, en attente de la réponse… 200 OK
Taille : 373 [application/json]
real    0m0,011s
user    0m0,007s
sys     0m0,003s
root@nuc:~$ time wget   --post-data="target=openhab.consommeHP_Fours&from=-150d&until=now&format=json&maxDataPoints=100&"  http://<IP_ADDRESS>:81/render
--2021-05-25 16:26:48--  http://<IP_ADDRESS>:81/render
Connexion à <IP_ADDRESS>:81… connecté.
requête HTTP transmise, en attente de la réponse… 200 OK
Taille : non indiqué [application/json]
real    0m0,102s
user    0m0,001s
sys     0m0,009s
root@nuc:~$ time wget   --post-data="target=openhab.consommeHP_Fours&from=-150d&until=now&format=json&maxDataPoints=1000&"  http://<IP_ADDRESS>:81/render
--2021-05-25 16:26:55--  http://<IP_ADDRESS>:81/render
Connexion à <IP_ADDRESS>:81… connecté.
requête HTTP transmise, en attente de la réponse… 200 OK
Taille : non indiqué [application/json]
real    0m0,101s
user    0m0,004s
sys     0m0,005s

I will see how it behave in real life use........


Switch to Visual Studio 2019, disabled Screen Resolution Modification, added handling for the two GUID flags and added "return address" to log of interface calls

The two possible GUID flags DDCREATE_EMULATIONONLY and DDCREATE_HARDWAREONLY were not handled before.
Resolution Modification caused issues at least with the game "Stronghold Crusader"
Return address is received by using the intrinsic _ReturnAddress.

Found no method to get application call address of exported functions.

Hello,
One comment related to the display mode modification. Except that, LGTM.
Thank you for your contribution.


Cannot compile external module

I am trying to compile the external module but i keep getting bluetooth errors when compiling, the esp-01 Sbus reciver compiled and flashed ok.
Compiling .pio\build\esp32doit-devkit-v1\liba50\ESP32 BLE Arduino\BLEBeacon.cpp.o
Compiling .pio\build\esp32doit-devkit-v1\liba50\ESP32 BLE Arduino\BLECharacteristic.cpp.o
In file included from C:/Users/Geo/Documents/CODE/hx_espnow_rc-0.1/lib/hx_espnow_rc/HX_ESPNOW_RC_Base.h:5,
                 from C:/Users/Geo/Documents/CODE/hx_espnow_rc-0.1/lib/hx_espnow_rc/HX_ESPNOW_RC_Master.h:5,
                 from src/main.cpp:8:
C:/Users/Geo/Documents/CODE/hx_espnow_rc-0.1/lib/hx_espnow_rc/HX_ESPNOW_RC_Common.h:26:10: fatal error: esp_wifi_internal.h: No such file or directory

***************************************************************************
* Looking for esp_wifi_internal.h dependency? Check our library registry!
*
* CLI  > platformio lib search "header:esp_wifi_internal.h"
* Web  > https://registry.platformio.org/search?q=header:esp_wifi_internal.h
*
***************************************************************************

 #include "esp_wifi_internal.h"
          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
*** [.pio\build\esp32doit-devkit-v1\src\main.cpp.o] Error 1
In file included from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLECharacteristic.h:19,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLEDescriptor.h:14,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLE2904.h:13,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLE2904.cpp:15:
.pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/FreeRTOS.h:61:28: error: 'ringbuf_type_t' has not been declared
  Ringbuffer(size_t length, ringbuf_type_t type = RINGBUF_TYPE_NOSPLIT);
                            ^~~~~~~~~~~~~~
In file included from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLECharacteristic.h:19,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLEDescriptor.h:14,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLE2902.h:13,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLE2902.cpp:15:
.pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/FreeRTOS.h:61:28: error: 'ringbuf_type_t' has not been declared
  Ringbuffer(size_t length, ringbuf_type_t type = RINGBUF_TYPE_NOSPLIT);
                            ^~~~~~~~~~~~~~
*** [.pio\build\esp32doit-devkit-v1\liba50\ESP32 BLE Arduino\BLE2904.cpp.o] Error 1
*** [.pio\build\esp32doit-devkit-v1\liba50\ESP32 BLE Arduino\BLE2902.cpp.o] Error 1
In file included from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLEAdvertising.h:15,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLEAdvertising.cpp:21:
.pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/FreeRTOS.h:61:28: error: 'ringbuf_type_t' has not been declared
  Ringbuffer(size_t length, ringbuf_type_t type = RINGBUF_TYPE_NOSPLIT);
                            ^~~~~~~~~~~~~~
In file included from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLERemoteDescriptor.h:18,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLERemoteCharacteristic.h:18,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLERemoteService.h:16,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLEClient.h:19,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLEScan.h:17,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLEAdvertisedDevice.h:17,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLEAdvertisedDevice.cpp:17:
.pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/FreeRTOS.h:61:28: error: 'ringbuf_type_t' has not been declared
  Ringbuffer(size_t length, ringbuf_type_t type = RINGBUF_TYPE_NOSPLIT);
                            ^~~~~~~~~~~~~~
*** [.pio\build\esp32doit-devkit-v1\liba50\ESP32 BLE Arduino\BLEAdvertising.cpp.o] Error 1
In file included from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLEDescriptor.h:16,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLECharacteristic.h:17,
                 from .pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/BLECharacteristic.cpp:15:
.pio/libdeps/esp32doit-devkit-v1/ESP32 BLE Arduino/src/FreeRTOS.h:61:28: error: 'ringbuf_type_t' has not been declared
  Ringbuffer(size_t length, ringbuf_type_t type = RINGBUF_TYPE_NOSPLIT);
                            ^~~~~~~~~~~~~~
*** [.pio\build\esp32doit-devkit-v1\liba50\ESP32 BLE Arduino\BLEAdvertisedDevice.cpp.o] Error 1
*** [.pio\build\esp32doit-devkit-v1\liba50\ESP32 BLE Arduino\BLECharacteristic.cpp.o] Error 1
========================================= [FAILED] Took 10.93 seconds =========================================
 *  The terminal process "C:\Users\Geo\.platformio\penv\Scripts\platformio.exe 'run'" terminated with exit code: 1.
 *  Terminal will be reused by tasks, press any key to close it.

```

`

thank you. I will get back to you.

could you upload a binary so I can test hardware while I sort out the software issues.

can you post a binary, I have it compiling but im getting flash errors and its just constantly resetting.
rst:0x10 (RTCWDT_RTC_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
flash read err, 1000
ets_main.c 371
ets Jun  8 2016 00:22:57

Did you upload filesystem after flashing?

#include <ESP-FTP-Server-Lib.h>

<EMAIL_ADDRESS>This dependecy is listed in platformio.ini
It should be installed automatically.

upload file system?

There is \data folder in the project with configuration and data files.
After flashing, upload it using (2)

ok i dont that and I think its working its now showing as Waiting for CH16 profile on the serial port.

Yes it is waiting for CH16 value to select profile
https://github.com/RomanLut/hx_espnow_rc/blob/main/doc/tx_external_module.md#see-next

ok how do i bind it to a recevier?

you should make a post over at https://discuss.ardupilot.org/c/blog/ Im sure there are a lot of people there that would be very interested in a high bandwidth mavlink RC system.

ok how do i bind it to a receiver? ok nevermind i think its not doing anything until it gets that channel 16 signal from a transmitter.

There is no bind process. You just need to have the same
"espnow_channel": 3,
"espnow_key": 0,
"espnow_long_range_mode": false,

in profile.json and in config.h of receiver.

It looks like it's all working, apart from I don't have a transistor to invert the SBUS input into the transmitter module. so i have ordered some and they should get here in a day or so , so im going to work on some 3d printed modules for my taranis x9d.

do you support the esp8285? its something like 250mw of rf compared to the <100mw you get with the rest of the modules.

https://www.espressif.com/sites/default/files/documentation/0a-esp8285_datasheet_en.pdf
802.11 b: +19 dBm
20dbm => 100mW

25db with PA
https://www.aliexpress.com/item/32846843421.html

I just noticed the esp8266MOD also has the PA https://www.aliexpress.com/item/32675165049.html

It has nothing to do with real output power, no external PA there, https://www.esp8266.com/viewtopic.php?p=938
Real output is 20 dbm to pass certification.
You may try to compile for 8285 by changing project settings.

https://fccid.io/2A54N-ESP8266/Internal-Photos/Internal-Photos-5839753

cool. il just stick to the esp32 and 8266.

I have been busy, flashed an esp01, a pair of wemos D1 modules, one as mavlink and one as SBUS. when i was digging though my box of modules i found this pixhawk wifi adapter, you can get them for around 10usd, the d1 mini mavlink firmware flashes to it fine.
https://i.loli.net/2021/10/12/S3PvGlRwiMcLN1X.jpg

I have been busy, flashed an esp01, a pair of wemos D1 modules, one as mavlink and one as SBUS. when i was digging though my box of modules i found this pixhawk wifi adapter, you can get them for around 10usd, the d1 mini mavlink firmware flashes to it fine.
https://www.aliexpress.com/item/1005003434945109.html
this looks really interesting, if it ever goes on sale
https://www.crowdsupply.com/
bison-science/esp32-m1-reach-out#products

A module with aliexpress, this is a regular module stitched with this firmware.

Yes i have that firmware on one of my d1 minis to connect it to my wifi network.

@RomanLut Have you thought about using the OpenTX multimodule interface to configure the modules and profiles?

Looks like a lot of work to get the the same functionality which is implemented already.
As for profiles configuration, a configurator web page hosted on module  would have much better user experience and also serve well for DIY controller. So far plain text editor web page is implemented only. I plan to implement full featured configurator some time later. Currenlty focused on INAV HITL project.

nearly have a JR module built.
https://discuss.ardupilot.org/uploads/default/original/3X/0/6/069cfbb748416ce63a7c35e0535b5b147b3d7243.jpeg
https://discuss.ardupilot.org/uploads/default/original/3X/0/3/0375831f110d4982bf33ef643c25b0c177f22332.jpeg

unrelated but this looks like a good receiver
https://www.aliexpress.com/item/4001054031743.html

https://www.aliexpress.com/item/1005004604063847.html


Properly fix test_subscription test

The start_paused config means to start the test with time paused. The documentation isn't very clear about what happens if you depend on time in the test when time is paused, but my best guess is it's undefined?
Removing this fixed all the mysterious time interval issues.

The start_paused config means to start the test with time paused. The documentation isn't very clear about what happens if you depend on time in the test when time is paused, but my best guess is it's undefined? Removing this fixed all the mysterious time interval issues.

The whole point of the time paused flag is to reliably test function where time is involved :)

Oh didn't know that. But then in that case, there is no way to rely on batch behavior deterministically, right? Because you could be ticking all the time and hence batching at arbitrary times.

Is https://docs.rs/tokio/latest/tokio/time/fn.advance.html properly used in the test to advance time?

Probably would also need to make sure we used https://docs.rs/tokio/latest/tokio/time/struct.Instant.html instead of the stdlib type to make sure the mocked time in tests is properly handled

Thanks Brandon! That might be the issue here.
Replaced all sleep with either yield or advance depending on the need.

Looks like this is failing on Linux. I am out of depth.

The core of this issue is this:
On Mac, the transaction stream stops at 105, and end up with a batch there, and then start from 106 afterwards.
On Linux, the transaction stream doesn't stop at 105 but continue all the way to 109.


Package for installation instead of requiring running from source dir

Yes please! This would be required to be able to add your software to a package management system.


tf.keras.utils.get_file inconsistent behavior with keras.utils.get_file

System information

OS Platform and Distribution: Colab
TensorFlow version: v2.2.0-rc3-0-gaad398b5e9 2.2.0-rc3
Python version: 3.6.9

Describe the current behavior
tensorflow.keras.utils.get_file by default saves any file to a subdirectory of ~/.keras. This behavior is specified here.
Describe the expected behavior
The function should behave the same as keras.utils.get_file, which uses the path specified in the KERAS_HOME environment variable instead of ~/.keras if it is set. This behavior is specified here
Standalone code to reproduce the issue
https://colab.research.google.com/drive/1pfS-BgACkgkCQ9nXT_iz123lvdlTk9Hg
Other info / logs
This is relevant especially for cases where the user is not able to specify the fname parameter manually to set an absolute path. One example for this mentioned in #33501 are the weights downloaded by tensorflow.keras.applications models. In my case, the user home directory is write-protected on the compute nodes of our HPC cluster and the fallback /tmp also should not be used.
The issue keras-team/keras#11923 set the behavior in keras.

Was able to reproduce the issue with TF v2.1, TF v2.2.0-rc3 and TF-nightly. Please find the attached gist. Thanks!

This is still an issue with the latest Tensorflow. By running the Colab notebook mentioned above (https://colab.research.google.com/drive/1pfS-BgACkgkCQ9nXT_iz123lvdlTk9Hg), it's shown that Tensorflow v2.5.0-0-ga4dfb8d1a71 2.5.0 still ignores the environment variable KERAS_HOME. Furthermore, there is no way to change the download location without modifying Python codes - the get_file function always use ~/.keras or /tmp/.keras [1]. The issue prevents downloading tf datasets to a custom location. For example,
from tensorflow.keras.datasets import cifar10
cifar10.load_data()

Always downloads the CIFAR-10 dataset to one of the two locations mentioned above.
[1] https://github.com/tensorflow/tensorflow/blob/v2.4.0/tensorflow/python/keras/utils/data_utils.py#L224-L231

While running the above mentioned colab, I'm getting error AttributeError: module 'keras.utils' has no attribute 'get_file'.

AttributeError: module 'keras.utils' has no attribute 'get_file'

Yeah, the latest version of Keras is synced with Tensorflow, and keras/utils/__init__.py no longer has the line  from .data_utils import get_file [1]. I can call keras.utils.data_utils.get_file, but the latter does not have the expected behavior, either.
To reproduce the expected behavior, I need to run pip install 'keras<2.4' first. Here are results on my machine:
$ ipython
Python 3.9.5 (default, May 24 2021, 12:50:35)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.24.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import os
   ...: os.environ['KERAS_HOME'] = '/tmp/my_keras_home'
   ...:
   ...: import tensorflow
   ...: import keras
   ...:
   ...: print('Tensorflow', tensorflow.version.GIT_VERSION, tensorflow.version.VERSION)
   ...: print(tensorflow.keras.utils.get_file('example.html', 'http://example.com/'))
   ...: print()
   ...:
   ...: print('Keras', keras.__version__)
   ...: print(keras.utils.data_utils.get_file('example.html', 'http://example.com/'))
Using TensorFlow backend.
Tensorflow unknown 2.5.0
/tmp/.keras/datasets/example.html

Keras 2.3.1
/tmp/my_keras_home/datasets/example.html

Somehow placing !pip install 'keras<2.4' at the first line of the Colab results in mysterious errors.
[1] https://github.com/keras-team/keras/commit/b5cb82c689eac0e50522be9d2f55093dadfba24c

Hi There,
This is a stale issue. As you are using an older version of tensorflow, we are checking to see if you still need help on this issue. Please test the issue with the latest TensorFlow (TF2.7 and tf-nightly). If the issue still persists with the newer versions of TF, please feel free to open it in keras-team/keras repository by providing details about the issue and a standalone code to reproduce the issue. Thanks!
Please note that Keras development has moved to a separate Keras-team/keras repository to focus entirely on only Keras. Thanks!


fix: When user goes offline, the download button do not disappear for other file types.

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/35200
PROPOSAL: https://github.com/Expensify/App/issues/35200#issuecomment-1911082807
Tests

Go to the chat where you have sent the attachment (.mp4, .doc, etc.)
Go offline
Verify download icon disappears and user can't download the file by pressing on it
Verify there is default cursor shown on the file preview instead of hand cursor in offline mode

[x] Verify that no errors appear in the JS console

Offline tests

Go to the chat where you have sent the attachment (.mp4, .doc, etc.)
Go offline
Verify download icon disappears and user can't download the file by pressing on it
Verify there is default cursor shown on the file preview instead of hand cursor in offline mode

QA Steps

Go to the chat where you have sent the attachment (.mp4, .doc, etc.)
Go offline
Verify download icon disappears and user can't download the file by pressing on it
Verify there is default cursor shown on the file preview instead of hand cursor in offline mode

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/85894871/0e4e6ff7-9843-46ed-9bfb-d3d5fdb4a996

Android: mWeb Chrome
https://github.com/Expensify/App/assets/85894871/573afe6c-2850-467f-ab71-fc2195b43c5f

iOS: Native
https://github.com/Expensify/App/assets/85894871/af84196e-841e-4661-9df8-da5d9f25f172

iOS: mWeb Safari
https://github.com/Expensify/App/assets/85894871/5d9acaee-8c44-4235-936e-2b67326ec71d

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/85894871/d99beebd-02b0-459c-ba15-4f344db59233

MacOS: Desktop
https://github.com/Expensify/App/assets/85894871/c5c8eb36-1d99-4f6d-9bc4-944d0647d4a6

@ishpaul777 what app/launcher/whatever do you have installed on your phone to show your download speeds on the toolbar here? :gimme-plz: 😂

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.33-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.34-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.34-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

oh very cool, what phone/OS do you have? I don't see that on my pixel sadly 😢

ah cool never heard of that brand before, looks l like they have their own OS https://www.oppo.com/en/coloros14/ which adds some of those features. very cool!

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.34-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


tuples: Treat Type::timestamp as an array

Previously, we were seeing issues like:
$ sudo bpftrace -e 'BEGIN {@a[pid]=(nsecs, strftime("%M:%S", nsecs)); }'
FATAL: BUG: Struct size mismatch: expected: 24, real: 32
Aborted (core dumped)

on certain LLVM versions. The issue most likely has to do with padding
and whether LLVM considers the 16 byte type as a single 128 bit integer
or two 64 bit integers. If considered as a single 128 bit integer, then
the padded struct size is indeed 32 bytes. If as two 64 bit integers,
then 24 bytes is correct.
Instead of trying to fight with LLVM on this, mark Type::timestamp as an
array so that codegen will tell LLVM that Type::timestamp types are an
array of 16 8-bit integers. This effectively packs the type. We know
this is safe to do b/c Type::timestamp types are accessed from userspace
as two 64-bit integers anyways (see AsyncEvent::Strftime) which is
naturally packed on both 32-bit and 64-bit machines.
Note that this is also how Type::Usym is implemented.
Checklist

[ ] Language changes are updated in docs/reference_guide.md
[x] User-visible and non-trivial changes updated in CHANGELOG.md
[x] The new behaviour is covered by tests

I think this is technically supposed to be correct:
diff --git a/src/types.cpp b/src/types.cpp
index 0c86bbc1..56a6fa8c 100644
--- a/src/types.cpp
+++ b/src/types.cpp
@@ -488,8 +488,10 @@ ssize_t SizedType::GetAlignment() const
     return GetSize();
   else if (GetSize() <= 4)
     return 4;
-  else
+  else if (GetSize() <= 8)
     return 8;
+  else
+    return 16;
 }

Chatted about this on IRC

Chatted about this on IRC


Google Auth for Admin and User provider - "...non-object"

Go to admin/settings/security
Select Google Auth for Admin and User provider
Click Submit

Results:
https://image.prntscr.com/image/P8oVOLlURnquqA1OaXKhqw.png

@dawid-g Fixed and available after install fresh instance

Verified as fixed.


Fix formatting check script issue

Fix formatting options and improve formatting script
Motivation:
An option not yet supported by swift format as of the 0.44.6 version was present in the .swiftformat file, which prevented validate_format.sh from properly checking that code formatting validity.
Furthermore this change prevents validate_format.sh from actually modifying the code, which could be unexpected.
Modifications:

Remove unsupported --disable redundantType option (doesn't exist yet in swiftformat v0.44.6)
Don't ignore invalid swiftformat invocations
Prevent validate_format.sh from actually modifying the code
Modify formatting according to the rules specified in .swiftformat

Result:
Fixed formatting options and improved formatting script

CI will fail but soundness should pass now I think.

@swift-ci please smoke test

@swift-server-bot add to allowlist


feat: portal-improvement-week1

🌟 TL;DR
This is the 2nd week of UI optimization for the Portal project. This week's focus is on identifying and addressing any remaining issues, and improving the overall user experience, especially after the initial launch.
Feel free to add any additional issues below.
🌈 UI/UX

[x] Enhance the layout of the Leap and Trade components
[x] Improve the UI for the no-data state on the Assets page
[x] Change the title of the session keys
[x] Change the name of the action button
[x] Auto remove the expired session keys

🛠 Functionalities

[x] Implement transfer coin functionality
[ ] Fix the routing issue for 404 error while refreshing browser [ ISSUE ]

coin & nft transfer needs to support btc addresses


Stroke for Pie Chart Sections

It would be great if we could specify a stroke (color, thickness) for individual pie chart sections. See attached image:

Hi. we have just added borderSide property in PieChartSectionData.
Please check it out in 0.36.3

You guys/gals are legends! Thank you very much!!!

Thanks
checkout our pie sample 1.

Sample 1 (Source Code)


FUIArray is not correctly invalidated and cannot be restarted

Environment

Objective C or Swift: ____ SWIFT
iOS version: _____ iOS 12.0
Firebase SDK version: _____ 5.9.0
FirebaseUI version: ____ 5.2.2
CocoaPods Version: ____ 1.5.3

Problem:
The FUIArray handles are not removed from their storage once the listeners are removed when invalidating the array. Thus calling observeQuery gain does not recreate the listeners.
Steps to reproduce:

_____ Create a FUIArray
_____ Call observeQuery
_____ Call invalidate
_____ Call observeQuery
_____ Modify data in Firebase that would normally trigger an array change

Observed Results:

Listeners are not active anymore and Firebase changes not detected anymore

Expected Results:

Listeners to be re-created and the FUIArray to work as before the first invalidate call

Relevant Code:
- (void)invalidate {
for (NSNumber *handle in _handles) {
  [_query removeObserverWithHandle:handle.unsignedIntegerValue];
}

  // NOTE: Fix handles array not being emptied and thus breaking observers after invalidation
  [_handles removeAllObjects];
  // End of fix

  ...

Thanks @morganchen12 . When can we expect a new release?


optimize generateMethodContent to avoid unnecessary StringBuilder cre…

…ation
What is the purpose of the change?
avoid unnecessary StringBuilder creation
Checklist

[x] Make sure there is a GitHub_issue field for the change.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[x] Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

ci fixed in https://github.com/apache/dubbo-samples/pull/1195


ENH: Add support for Artinis SNIRF data

Reference issue
This is an issue as PR.
Artinis provided me with half a dozen files exported from their fNIRS device (the files are too large for me to share).
The sampling times of their devices aren't spaced to the level of precision that we currently expect. Which causes the current implementation of the SNIRF reader to throw an error.
They sent me the following screenshot where they describe the issue...

What does this implement/fix?
I implemented a maximum allowed percentage jitter for the file to be still considered uniformly sampled.
I (fairly arbitrarily) specified that we now allow for a 1% variation in the sampling times relative to the average sampling time difference of the file. I specified this parameter as MAXIMUM_ALLOWED_SAMPLING_JITTER_PERCENTAGE
Additional information
This solution doesn't seem ideal. I am open to alternative suggestions.
I also tried reducing the precision when calculating fs_diff = np.around(np.diff(time_data), decimals=4), but this broke support (and unit tests) for other devices.
The files exhibiting this behaviour are too large to add to our testing data. I have requested a test file from the manufacturer, but it might not be possible to capture this phenomenon in a small file as it seems to occur only many minutes into a recording. And if we read, crop, export and use the modified file, it will not reflect the manufacturer's formatting.
The submitted code allows me to read the files the manufacturer shared with me.

@larsoner @agramfort @drammock could you please review.
There seems to be some unrelated issue in pip-pre, but I am pretty sure I didn't introduce that.

Good idea. I can write that test

Thanks @drammock that is amazing! I appreciate you taking the time to make the edits directly!

I'm happy but CI "old" is not. I'll debug tomorrow morning

ok I'm stumped. I created a local env that mirrors the compat_old env, replicated the failure, then got it passing locally, but it's still failing on the CIs.
(there's also now an unrelated pip-pre failure dealing with dependency resolution)

Okay I'll look


4.2.0 MOL 356 1.7.7 bo order creation fix

Fixed issue when creating order via BO. First, merge install fix

All changes were already merged with other PR's, you can close this.


Functions With Improper Derivatives

Right now the Stan autodiff implements functions with improper derivatives (i.e. the derivatives do not exist at certain points), which is formally improper.  We have seen issues where people use functions like step, floor, and ceil in their models and the resulting sampling is very poor.
Personally I'd prefer to limit Stan to functions with proper derivatives only, but in any case we should have the discussion.

This issue was moved to stan-dev/math#33


YouTube Mix playlist links w/ bad songs

This is an incredibly specific nitpick so I'm not really sure if it's worth addressing. Using Lavaplayer 1.3.47 in Lavalink.
Loading this url:  https://www.youtube.com/watch?v=FuAHR4lkjCo&list=RDFuAHR4lkjCo&start_radio=1
Gives this traceback:
com.sedmelluq.discord.lavaplayer.tools.FriendlyException: Could not find tracks from mix.
        at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeMixProvider.load(YoutubeMixProvider.java:68) ~[lavaplayer-1.3.47.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager$LoadingRoutes.mix(YoutubeAudioSourceManager.java:244) ~[lavaplayer-1.3.47.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager$LoadingRoutes.mix(YoutubeAudioSourceManager.java:220) ~[lavaplayer-1.3.47.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.source.youtube.DefaultYoutubeLinkRouter.routeFromUrlWithVideoId(DefaultYoutubeLinkRouter.java:91) ~[lavaplayer-1.3.47.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.source.youtube.DefaultYoutubeLinkRouter.routeFromMainDomain(DefaultYoutubeLinkRouter.java:61) ~[lavaplayer-1.3.47.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.source.youtube.DefaultYoutubeLinkRouter.route(DefaultYoutubeLinkRouter.java:39) ~[lavaplayer-1.3.47.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager.loadItemOnce(YoutubeAudioSourceManager.java:188) ~[lavaplayer-1.3.47.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager.loadItem(YoutubeAudioSourceManager.java:127) ~[lavaplayer-1.3.47.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.checkSourcesForItemOnce(DefaultAudioPlayerManager.java:437) ~[lavaplayer-1.3.47.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.checkSourcesForItem(DefaultAudioPlayerManager.java:419) ~[lavaplayer-1.3.47.jar!/:na]
        at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.lambda$createItemLoader$0(DefaultAudioPlayerManager.java:218) ~[lavaplayer-1.3.47.jar!/:na]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[na:1.8.0_232]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[na:1.8.0_232]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[na:1.8.0_232]
        at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_232]

The FriendlyException returned is Could not find tracks from mix. which is true as the page provides no mix tracks or other tracks to pull, but the exception I expected to see was Video unavailable / This video contains content from SME, who has blocked it in your country on copyright grounds. from the page/video that was returned (https://www.youtube.com/watch?v=FuAHR4lkjCo)

Linking to #259 as I originally reported that URL not working on that issue.

The appropriate string/error ("Video unavailable / This video contains content from SME, who has blocked it in your country on copyright grounds.") is provided on 1.3.50+, not sure what changed and when but this is resolved.


Enhancement: New Logo?

What is your suggestion, and why should it be implemented?
what: a new Kade Engine logo me and my friend made (my friend did all the letters individually and I pieced them together)
why: new look, old one is meh at most
alone with glow

with FNF logo but without glow

just a note:
I did not take the color from the FNF logo.
I actually used this color and then on another layer the same color again but blurred and with the 'glow' Blend.

dude that's kinda gaming

kinda gaming
@KadeDev

drip

/!\ Kade Engine drip required beyond this point /!\
Without Kade Engine drip, you will be:

unaffected
still cool :+1:

the spritesheet if it ever gets accepted

thanks I guess :)

The new logo spritesheet i put above works, just needs some offset changing 👍

Kade could add this to the 'watermark' section in option to enable/disable it

honestly I like it

drip

/!\ Kade Engine drip required beyond this point /!\
Without Kade Engine drip, you will be:

unaffected
still cool 👍

i have aflac drip

drip

/!\ Kade Engine drip required beyond this point /!
Without Kade Engine drip, you will be:

unaffected
still cool 👍

i have aflac drip

We also accept alfac drip

we really out here friday night drippin'

this is sick, since this isn't a pr. consider it accepted??? idk lol


Channel Icon Stuck

When I was first playing around with channel icons I set one for channel 6 and all the others were the default one. I have since gone through and made channel icons and replaced all the channel icons in dizquetv, they all appear in Plex now except for the first icon that I changed has stayed the same. I have checked the XML and followed the link and it goes to the new one, seems like its stuck in plex. Is there a way to force icon refreshes?

Tried removing the DVR, restarting plex and then adding it again. Little icon comes back!

@elit3ge It's not clear to me.  Is this resolved or still an issue?

@MoRBiD-MaNGLeR still an issue.

What player are you using? If it's a web browser, maybe try clearing your cache?
Also, have you tried stopping and restarting the Plex Media Server application?

@nwithan8 It's an AppleTV. Yes to the restart.

Resolved itself.


Help Boa have easier efficient conversions from Vec to JsTypedArray

We want to be able to convert any Vec<numType> where numType is u8, u16, u32 etc to JS Uint8Array, Uint16Array etc. Right now we have a small change in a branch off of boa that allows us to convert a Vec<u8> into a JsObject that is a Uint8Array under the hood. It would be nice to upstream the change and have this work generally. There are some problems though as described here: https://github.com/boa-dev/boa/issues/2058#issuecomment-1162416288

We don't use Boa


Close #309, Improve  invariant validation error message

This should fix #309

Thanks!

Thanks for this. Knee deep in containers. Very helpful.

I guess this problem is back. At least I just got that error message with react 15.6.1 :/


Convert tests back to node-tap

This resolves switching from istanbul to nyc because tap includes nyc and coverage reporting by default.

⚠ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.
Please include a minimal reproducible example
when opening a new issue.


fix: bugs on safari nav bar

Description
Sovled bug styling on nav bar in safari browser.
Changes Made

add scroll-bar hidden styling in globals.css
remove duplicated conditional styling in src/containers/editor/sidenav/index.tsx

Related Issue
issue#22
Type of Change

[x] Bug fix

Thanks for your contribution. It seems it does not fix the popover disappearance problem, but did it fix the icon shaking problem?

@loggerhead ouch, I didn't even noticed there was a popover disappearance bug lol, but yeah my changes aim to solve the icon shaking problem.


Request: Example of accessing Pipeline parameters in Config SDK

Is there an existing issue that is already proposing this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe it
I'm unable to find a way to access pipeline parameters in JS/TS code.
I see there're some implementations related to Git or VCS project itself, but I was unable to access any custom parameters during setup stage.
That being said, I also assume that any parameters that were passed to the pipeline trigger should be exposed in setup config, since CircleCI will raise a warning ⚠ Unexpected argument(s): foo, even if it is stated in the dynamically generated config.

Describe the solution you'd like
Such as config.pipeline.git(), we can have a config.pipeline.parameters(), which I expect to be a dictionary of parameters or even something more type-safe.
Teachability, documentation, adoption, migration strategy
.
What is the motivation / use case for changing the behavior?

Adapting config to external triggers
Providing more flexibility for dynamic configuring

Hello @Kylmakalle. While I would like to support pipelines eventually (and they are currently defined), it is not possible today to get the pipeline values from within the job. CircleCI's pipeline parameters are a config-level construct that is "processed" out before the config is actually run. The code that is executed within a job unfortunately has no knowledge of a pipeline or pipeline parameter. We would like to get there at some point but it may require some changes outside this SDK. We may look to remove it from the SDK for the time-being to avoid confusion, thank you for pointing that out.
What use-case were you attempting? From my experimentation, what I would recommend is setting any similar type values to environment variables, which will be available at runtime.
example:
version: 2.1
orbs:
  continuation<EMAIL_ADDRESS>  node<EMAIL_ADDRESS>setup: true
parameters:
  my-pipeline-parameter:
    type: string
    default: "foo/bar"
jobs:
  generate-config:
    executor: node/default
    environment:
        PARAM_PIPELINE_VALUE: <<pipeline.parameters.my-pipeline-parameter>>
    steps:
      - checkout
      - node/install-packages:
          app-dir: .circleci/dynamic
      - run:
          name: Generate config
          command: node .circleci/dynamic/index.js

This will populate PARAM_PIPELINE_VALUE with the value you are looking for. Then you can reference it as:
process.env.my-pipeline-parameter


feat: replace expected in third party with ros package

replace expected in third party with ros package

@ahcorde @john-maidbot could you review this PR?

https://github.com/Mergifyio backport humble iron


ERROR: Unable to download webpage: HTTP Error 410: Gone and bad option flag

istr this happening before, an upgrade fixed??
stephen@i7:~$ youtube-dl --verbose --match-title wanhao https://www.youtube.com/user/vernonbarry/videos
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', '--match-title', 'wanhao', 'https://www.youtube.com/user/vernonbarry/videos']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2014.08.05
[debug] Python version 2.7.9 - Linux-3.16.0-4-686-pae-i686-with-debian-8.1
[debug] Proxy map: {}
[download] Downloading playlist: vernonbarry
[youtube:user] vernonbarry: Downloading video ids from 1 to 51
ERROR: Unable to download webpage: HTTP Error 410: Gone; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 203, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 1231, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python2.7/urllib2.py", line 437, in open
response = meth(req, response)
File "/usr/lib/python2.7/urllib2.py", line 550, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib/python2.7/urllib2.py", line 475, in error
return self._call_chain(*args)
File "/usr/lib/python2.7/urllib2.py", line 409, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 558, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
tried this as well
youtube-dl --verbose --callhome --match-title wanhao https://www.youtube.com/user/vernonbarry/videos
Usage: youtube-dl [options] url [url...]
youtube-dl: error: no such option: --callhome
youtube-dl: error: no such option: --call-home

You are using an outdated version of youtube-dl. Read our FAQ if you have troubles updating.

apols, should take my own advice:-)
i've just rebuilt it from github zip and all ok
stephen
On 18 July 2015 at 11:14, Sergey M<EMAIL_ADDRESS>wrote:

You are using an outdated version of youtube-dl. Read our FAQ
https://yt-dl.org/update if you have troubles updating.
—
Reply to this email directly or view it on GitHub
https://github.com/rg3/youtube-dl/issues/6269#issuecomment-122526698.


Added Iceberg integration notebooks which work with AWS Glue

LGTM - let's just add a comment to the NYC notebook to upload the file to the repo and commit it.

Added comment


fix(refresh): temp fix wallpaper refresh task

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#93
#92  👈
#91
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @libhide and the rest of your teammates on  Graphite

Merge activity

Jun 10, 9:30 AM EDT: @libhide started a stack merge that includes this pull request via Graphite.


Remove upperbound on numpy

Closes #979

@martinkim0 - do you need this soon?  If so, we will need to drop a release containing the change.  Please let us know.

Great, thanks for approving @bkmartinjr! Not very urgent, but it would be nice to have as soon as possible. Is there a schedule for the next release?

Is there a schedule

We do them as needed, and not on a regular schedule.  I'll raise the issue with the team and see if we can get it moving.


error handling in serverStream

Pass errors from serverStream() to application's observable.

Hi @jkgneu12
thanks for the PR :)

@smnbbrv thank you for building this lib! made my life easy :)


With Progress, could auto create a bar

Simple Request, can this project add a WithProgress option without a progress bar?
        public static async Task WithProgress<T>(this PerformContext performContext, IEnumerable<T> rows)         {             var bar = performContext.WriteProgressBar();             rows.WithProgress(bar, rows.Count());         }

Added in 1.3.5