new Node tileDraw

Describe the project you are working on
This is a tileSet editor Ive made for the godot editor
----///---newer version -----//-------
https://youtu.be/kgiRmHoHIX4?si=dRrOpSpIefaa6GVu
----///---old-version-video-----//-------
https://github.com/user-attachments/assets/503e4823-e78b-4144-b009-a7f09459a486
the benefits are big ( PROS ).

draw with tiles like in a photoshop drawing program
change tile color
add filters like blur, pixelatte, Hue/Saturation..etc..
merge all layers into one layer
all basics are here, draw with left Mbutton / erase right Mbutton
select/copy tiles from editor viewport

the CONS

it creates a new texture for each tile
The user will have to decide the best approach... Merge all layers into one to reduce the nº of textures
The user will have to decide, the canvas size ( image size )
Its mostly used to draw levels like in "HOLLOW KNIGHT". Not destructive levels like "BRO FORCE"

Describe the problem or limitation you are having in your project

unability to change a tile(s) color
unability to blur the background layers in 2D ( giving a deph of field effect )
colors not matching using a normal tileMap
extra effects like blur/pixelatte take a lot of work and RAM resources in a normal tileMap
In a normal tileMap only the entire color can be changed, not a tile or group of tiles

Describe the feature / enhancement and how it helps to overcome the problem or limitation
This tileDraw editor, would benefit users that are making more advanced 2D games ( HOLLOW KNIGHT TYPE ).
currently a user has to change between photoshop / tiled and then engine editor, to make a level of this sort.
This node would give the user the oportunity, to make / draw the level and edit it in just on place, making the level look better, and easier to edit.
Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams
dificult to describe in only a few words
This is a very old example of the code on gitHub
https://github.com/jonSP12/tileDraw_plugIN_test3
The code needs to be remade, but this is not a problem, i can do it very fast with my eyes closed.
The reason i havent yet remade the code is:

The undo / redo feature is not working 100%, has this feature is part of the engine.

If this enhancement will not be used often, can it be worked around with a few lines of script?
na
Is there a reason why this should be core and not an add-on in the asset library?
It can be added has a plugIN, but making it core is not very hard the code is very basic, and easy to change based on changes made to the redot editor. Seeing this changes on the editor its the kind of things Users want.
This would put redot on the right track and going foward, since tiles in godot always seem to fail, or lead to Bans. Redot can start from the top, instead of starting from the same tileMaps clucky 3.x to 4.x negleted process that godot comes up with.
The main reason and my personal experiece, is that tileSets were always some sort of TABU in godot. Starting in 3.x, later in 4.x. Mentioning this topic is like steping into a nest of vipers...
You can see in this post in 3.x  https://github.com/godotengine/godot/issues/61187  i mentioned the tiles in tileAtlas were all scrambeled like a jigSaw puzzle... At the time i didnt knew how godot worked so i didnt knew how to fix the problem myself.  The issue seemed to negleted by the person in charge of making tiles, then easly fixed by a user ( kleonc )
Having the tiles showen like in the image is just a very basic thing. Funny enough they only seemed to pay attention to the subject after 3 years when i was banned... This is the main problem i have with the godot engine, and why i think opening issue or even mentioning improvement is just a waste of time... the devs there dont know how to do it.
This results in excuses that dont make sense, and myself and others being tagged has "rude" or other weird labels.... A very easy insight is that we are making this things and not asking users money for this !!!
( why are the people making bad editors apps not BANNED ), its a discustion that leads to nonSense.

I don't see what the point of this proposal is, Godot already has a tileset system that competent, if you need more it probably should remain a plugin.

if you need more it probably should remain a plugin.

The undo/redo isnt working 100% with the engine undo/redo, the only way i can get it working is to code a new redo/undo.

I don't see what the point of this proposal is, Godot already has a tileset system thats competent

open any tileMap in godot 4, and apply these filter and change color to each tile or group of tile(s) there.

[edit] you ve opened redot and said you would wanted to add new features to make game Dev easier ....
This is has best has it gets, change tile color / add filters...
People were holding on using godot 3.x because of its tiles, tiles in godot 4.x are good, but can be better.
Anyhow new feature easier to draw levels, any person using tiles can see changing the tile color is a great improvement... Its either that or use a drawing program instead of a tileSet.

The undo/redo isnt working 100% with the engine undo/redo, the only way i can get it working is to code a new redo/undo.

Then the current system should be fixed.

open any tileMap in godot 4, and apply these filters or change color to each tile or group of tile(s) there. ( tiles in the same layer )

Its rarely worth it to add features just to add them, it create complexity the introduces bugs and maintenance burden, it needs a usecase that justifies the maintenance even aside from community consideration.

But at a certain point its better to use better designed and maintained tools anyway and bring them into Redot, Redot isn't intended to be an all encompassing tool

I dont know of any tool that can do this... Photoshop doesnt allow to draw with tiles... Tiled doesnt allow to change the tile color or effect.

Its rarely worth it to add features just to add them, it create complexity the introduces bugs and maintenance burden

I think that in this case the burdens would be minimal. The blunt part of the plugIN are the menus and options, these are  things made using the engine existing nodes... That is the reason why i though adding this node would minimal but i could be wrong.

it needs to be measured by community interest.

I have yet to notice any mass desire for such a feature.

Ive always read requests to add an option to change the tile color, in godot and other places. Requests like this will keep poping up now and then. I think most people have just gave up on asking for these options, or they are too afraid to ask because someone else always says its impossible.... + Plus if you would saw a request feature to change the tile color you would problably tell them to use alternative tiles, witch is a very destructive way of doing this type of things.

Then the current system should be fixed.

Then plugIN is fine by me, i just wanted to get it running with the engine undo/redo, so it would look better... instead of having 2 undo/redos working at the same time. I was hoping someone who already knew the engine source code could provide a solution for this i believe it could be done in 10/15min, but for me its going to take me about 1 month or weeks to get it working the right way...

I think that in this case the burdens would be minimal.

It inherently isn't, adding a feature requires maintenance, that is a burden, either we must know what it does and manage it ourselves or we have someone on our team who does, neither of which will happen with that feature as it stands right now regardless, we do not have the manpower to do so.

Ive always read requests to add an option to change the tile color, in godot and other places.

I've read the godot proposals issue tracker daily for a while and I've never seen it, in "other places" is irrelevant, we can't support a feature on pure theory.

A google search in any tileSet editor will show some kid(s) requesting to change the tile color

Okay, that's still not a Redot problem.

I think most people have just gave up on asking for these options, or they are too afraid to ask because someone else always tells them its impossible

Then they either don't need the feature or they don't care enough about the feature, its a lot more likely most people don't actually care, I've not seen this case widely desired and merely saying there are some people that may desire it is not good enough justification. If people need something why do people ask for all these other features that are harder to define and why do they get all this support but the same is not said of what you're referring to.

you would problably tell them to use alternative tiles, witch is a very destructive way of doing this type of things

No its not, that's by definition non-destructive, like out of everything doing that would be destructive is most certainly not true.

I was hoping someone who already knew the engine source code could provide a solution for this

Being a fork the expectation is that contributions for some features would also need to be done on the desires of the community's work too, and if it were just 15 minutes of work by someone who knows the engine, it would've already been done in Godot, not that I have an exact idea of even what you want with that.

Just to simplify - Adding a feature to change the tile color in gd4.x tileSet would be a bad idea...
The current feature there "alterate tiles" doesnt cover this... Just to change the tile color from yellow to orange, can lead to a lot of problems there are 255 variations of yellow, 255 variations of orange... You could end with billions of alternate tiles.
I had to frase "new Node" in the title request " new Node tileDraw #33 "
adding a feature to change the color in the current gd4 tileSet would destroy it...
keeping things seperate with a new node, would be easly done. Of course "changeColor" would defer from a normal tileSet, and would look more like a drawing program... This allows to do more things to the image filters / blur / pixellate etc...
To simplify...

this is the part were i get in trouble, it works the same way has in photoshop
select the layers / merge the layers / remove the selected layers except for the one the user selected frist...

the layers are in an itemList ( a thing that in the engine i dont know how is coded )
#----//--REMOVE-itemList-layer-//----
func _on_btn_del_layer_pressed():
	var listSize = itemList.get_item_count();
	var itemListSelectedItems: Array = itemList.get_selected_items();

	if ( listSize <= 1 ):
		return;

	if ( itemListSelectedItems.size() <= 1 ):
		for n in range(listSize, -1, -1 ):
			if ( itemListSelectedItems.has(n) ):
				itemList.remove_item(n);
				PlugTileDrawNode2.layerMax = listSize-1;
				PlugTileDrawNode2.layers.Lnum.remove_at(n);
				PlugTileDrawNode2.layerName.remove_at(n);

				itemList.select(0, true);
				_on_item_list_multi_selected(0, true);
	elif ( itemListSelectedItems.size() > 1 ):
		for n in range(listSize, -1, -1 ):
			if ( itemListSelectedItems.has(n) ):
				if ( n != itemListSelectedItems.min() ):
					itemList.remove_item(n);
					PlugTileDrawNode2.layerMax = listSize-1;
					PlugTileDrawNode2.layers.Lnum.remove_at(n);
					PlugTileDrawNode2.layerName.remove_at(n);

		_on_item_list_multi_selected(itemListSelectedItems.min(), true);

#----//--MERGE-layers----//----
func _on_btn_mer_layer_pressed():
#var lays = itemList.get_selected_items();
var lays: Array = itemList.get_selected_items();
var listSize = itemList.get_item_count();
if ( lays.size() <= 1 ):
	print( "tileDraw: only 1 layer selected" );
	return;

arrMax_x.clear();
arrMax_y.clear();

for a1 in range(0, lays.size() ):
	var idx2 = lays[a1];
	var imgPos10 =  PlugTileDrawNode2.layers.Lnum[idx2].keys();

	for a2 in imgPos10.size():
		var imgPos15 = imgPos10[a2];
		arrMax_x.append(imgPos15.x);
		arrMax_y.append(imgPos15.y);

var arrMax1_x = arrMax_x.max();
var arrMax1_y = arrMax_y.max();
var arrMin1_x = arrMax_x.min();
var arrMin1_y = arrMax_y.min();

var arrMax1_x2 = abs( arrMin1_x - arrMax1_x ) + 32;
var arrMax1_y2 = abs( arrMin1_y - arrMax1_y ) + 32;

var format = PlugTileDrawNode2.drawText.get_image().get_format();
var imgSelect1 = Image.create(arrMax1_x2, arrMax1_y2, false, format);

for i in range(0, lays.size() ):
	var idx = lays[i]
	var imgPos = PlugTileDrawNode2.layers.Lnum[idx].keys();
	var img11 =  PlugTileDrawNode2.layers.Lnum[idx].values();

	for p in img11.size() :
		var imgPos2 = imgPos[p];
		var img12 =  img11[p];
		imgSelect1.blend_rect(img12.get_image(), Rect2(Vector2(0, 0), Vector2(32, 32) ), imgPos2 - Vector2(arrMin1_x, arrMin1_y) );

var combined_texture = ImageTexture.create_from_image(imgSelect1);

#---breaking-the-image-into-pieces-and-drawing-it-on-screen----
PlugTileDrawNode2.mouseGroup.Fnum.clear();
for i in range(0, combined_texture.get_image().get_size().x,32 ):
	for j in range(0,  combined_texture.get_image().get_size().y, 32):
		PlugTileDrawNode2.mouseGroup.Fnum.append(  { "cords": Vector2(i, j), "img": ImageTexture.create_from_image(combined_texture.get_image().get_region( Rect2( i, j, 32, 32) ) ) } );

for i in range (0, PlugTileDrawNode2.mouseGroup.Fnum.size() ):
	var coords = Vector2( arrMin1_x, arrMin1_y ) + PlugTileDrawNode2.mouseGroup.Fnum[i].cords;
	var imgText  = PlugTileDrawNode2.mouseGroup.Fnum[i].img;
	PlugTileDrawNode2.layers.Lnum[ lays.min() ][ coords ] = imgText;

print("TileDraw: layers selected: " + str (lays) )
print("TileDraw: Layers mergeded into: " + str( itemList.get_item_text( lays.min() ) ) )
mergeRemove = true;
_on_btn_del_layer_pressed();

this is were i stopped because the undo/redo gets confusing to me...

- This is the undo/redo working has normal on a mouse press/release

	```

	#------------------//-DRAWING--//---------------------
	#------------------//-DRAWING--//---------------------

	if ( Input.is_mouse_button_pressed(MOUSE_BUTTON_LEFT) && mouseJustPress == false ):
		mouseJustPress = true;

		if ( drawText == null ):
			return;

		mouseGroup.Fnum.clear();
		#-----------------------------------------------------------
		#-----------------undo-rendo-draw-------------------------------
		undoredo.create_action("tileDraw - drawing Tiles");
		undoredo.add_undo_method(self, "remove_element", layers.Lnum[ layerPOS ].duplicate(true) );
		undoredo.add_do_method(self, "add_element", layers.Lnum[ layerPOS ].duplicate(true) );
		undoredo.commit_action();
		#-----------------------------------------------------------

--------------//-------//--------------------
```

#----------------------//-ERASER--//---------------------
#----------------------//-ERASER--//---------------------

if ( Input.is_mouse_button_pressed(MOUSE_BUTTON_RIGHT) && eraseCheck == false ):
	eraseCheck = true;

	if ( drawText == null ):
		return;

	#-----------------------------------------------------------
	#-----------------undo-rendo-erase-------------------------------
	undoredo.create_action("tileDraw - erasing Tiles");
	undoredo.add_undo_method(self, "remove_element", layers.Lnum[ layerPOS ].duplicate(true) );
	undoredo.add_do_method(self, "add_element", layers.Lnum[ layerPOS ].duplicate(true) );
	undoredo.commit_action();
	#-----------------------------------------------------------
	mouseGroup.Fnum.clear();

Dont try to understand the code above, but the undo works with a very simple function like this:

#---------//--UNDO-RENDO--//--------------

func add_element( value ):
layers.Lnum[ layerPOS ] = value;
notify_property_list_changed()
func remove_element( value ):
layers.Lnum[ layerPOS ] = value;
notify_property_list_changed()

But for me to add this to the merge layers section ( the part were is not working 100% )
Its too painfull because i dont know whats happening on the other side...
There are more complicated menus in godot/redot like the current tileSet layer menu that use the undo/redo... and even the tileSet in gd3.x that also seems to use an itemList to store its tiles... Just to put it simple engine DEVs know put it, i dont... That is why i said it would problably take a dev about 10 to 15min to put the undo/redo in there, because its been made in the engine multiple times in much more dificult situations...

Have you had your fill of internet MTV popularity ?
Just to be clear, iam not one of those that believed this nonsense, you cant go far with only marketing skills.


:dancer: no results header style

:rocket: deployed to http://connecting-to-services-pr-262.dev.c2s.nhschoices.net and using the latest release of nearby-services-api (0.4.1)

:rocket: deployed to http://connecting-to-services-pr-262.dev.c2s.nhschoices.net and using the latest release of nearby-services-api (0.4.1)

:warning: deployment of 262 for nhsuk/connecting-to-services failed


Unnecessary border-t when field is first in Panel

Nova has already divide-y divide-gray-100 on the parent, so I don't even think the boder-t class is necessary at all

Thanks! Fixed in 2.3.0.


[CWS] remove some defunct process from tests

What does this PR do?
This PR is a collection of fixes for tests that were creating some defunct processes:

TestProcessMetadata/credentials was fork/exec-ing but never called wait
TestContainerCreatedAt was never starting the docker wrapper causing some issues with previous containers
TestProcessResolution was never waiting the correct cmd because of function variable shadowing (yeah..)

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


refactor: remove applyWhen in favor of explicit props overlap check with alwaysApply exception

Description

Simplify applyWhen to just check for presence of props from the new props key as discussed with @colbyfayock, add an alwaysApply key that can be used for exceptions like SanitizePlugin that should always run regardless of the presence of associated keys.
Issue Ticket Number
Fixes #<ISSUE_NUMBER>

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Fix or improve the documentation
[ ] This change requires a documentation update

Checklist

[ ] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
[ ] I have created an issue ticket for this PR
[ ] I have checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] I have performed a self-review of my own code
[ ] I have run tests locally to ensure they all pass
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes needed to the documentation

here's the build error from the logs in case its not visible

@colbyfayock My bad on the overlapping plugin props issue there, at least there was a clear type error that I definitely should have noticed :P


show a error api demo In FluxDB WebUI

Error Info Page Url
http://<IP_ADDRESS>:8086/orgs/092443229ce498f4/load-data/client-libraries/java
Location:
In webUI,choose LoadData->Sources->Client Libraries-> Java
Then you can see the Option 2: Use a Data Point to write data
Error Describe:
web show insert data in influxdb with POJO use api writeApi.writePoint(), but I found the apiDoc, this api interface cant suitable for insert POJO, i think we should use writeMeasurement() instead of  writePoint();

Library version: influxdb-client-java-3.1.0.jar

I suggest developer to modify this page information in Next version

I submitted a Merge request
https://github.com/influxdata/ui/pull/6329


Wrap mask-image to avoid Edge crash

https://github.com/vaadin/vaadin-material-theme/pull/22#issuecomment-361536843

Where do we need a mask-image in this theme?

We aren’t using any mask images in the theme at the moment. Closing as invalid.


Add initial version of focus events pump

The service is intended to be used for load testing Recommendation Service.
It generates focus events (randomly picking the customer and department) and publishes them to an MQTT topic.

[ ] Describe the service's API (HTTP)
[ ] Dockerize the service
[ ] Rebase!!!

fixed with #24


How reliable these results are?

Hi,
I did a couple of tests and it look like there is a lot of scaffolding going on
There are 10Mya difference between the assembly to scaffold and its reference.
Reference: EisaPacBio.assembly.v1.0.fasta
____________________________
N50: 1613086.0
Number of contigs: 580
Longest contig: 6085293
Genome length: 401008328

My query: Etal.curated.fasta
____________________________
N50: 39539
Number of contigs: 25749
Longest contig: 401059
Genome length: 461252547

The output: ragoo.fasta
____________________________
N50: 2449116
Number of contigs: 504
Longest contig: 97232201
Genome length: 463829447

and this is the way I'm runnig RaGOO
python ragoo.py -t 32 -i 0.5 -b Etal.curated.fasta EisaPacBio.assembly.v1.0.fasta
How reliable is this result?
Thanks
Great tool!
F

Hi there,
Thanks for the question. Please take a look at the FAQ where I address this.
There are basically two questions:

How will does RaGOO construct pseudomolecules that are syntenic with the reference.

This is the easiest to evaluate. I would align the ragoo.fasta file back to the reference and look at the synteny plots (dot plots). The confidence scores can also help with this.

How accurately do the pseudomolecules represent the true chromosomal structure.

This is harder to evaluate. Generally speaking, the results should be most accurate for species that have shared chromosomal structure (closely related species). The best way to see how reliable the results are is to validate with some independent data. In our preprint, we used Hi-C for this.

Looking at your results a little more, which pseudomolecule is of length 97232201 bp? Is that chr0? Two other things stand out. Firstly, your assembly is quite a bit larger than the reference. Is that expected? Also, you set -i to be fairly high. You could probably stand to lower that a little. I have a feeling a good chunk of your assembly is ending up in chr0.


want to add background

will add backgound color which is attractive. And i would like to work on this plzz assign this to me.

@gouravkhunger I want to add this kind of light color which infact will not impact any of the color themes and will look better as white is looking so simple. If you find this correct plzz tell me. Also i can browse more colors which are light and will fit with this.


Mistake in docstring

user_playlist_remove_all_occurrences_of_tracks' docstring says "add to the playlist" instead of "remove from the playlist" in the description of the parameters.

Done in https://github.com/plamere/spotipy/pull/414


remove bs4 from bs triggers

if the "ibs" trigger is "from bs4 import BeautifulSoup" then why do all the "bs" triggers include the "bs4" part?
otherwise I can see this being quite useful.

Hello there, I'm not quite sure what you mean, could you please clarify?
The beautifulsoup4 snippets don't have bs4 as part of the triggers, are you referring to the descriptions instead?

I was referring to the above.

Ah, I see now. Yeah, these are just descriptions of the snippets, not the actual triggers.
Closing the issue if you don't have any further concerns. Thanks for reaching out!

Yep all good.


pull request for e2e test at 01/02/2017 11:56:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Refactor pid process ref

Fixes #52

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Looks good, just the few interlocked reads/writes that needs fixing :)

Done

👍


HDFS-16254. Cleanup protobuf on exit of hdfs_allowSnapshot

Description of PR

Moved the call
google::protobuf::ShutdownProtobufLibrary()
to main method instead of
AllowSnapshot::HandlePath
since we want the clean-up
tasks to run only when the
program exits.

How was this patch tested?
Unit tests ran fine. Also, verified
by running the tool locally,
as shown below -

The directory was marked as
snapshot-able without any
errors -

For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
23m 37s

Docker failed to build yetus/hadoop:13467f45240.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/3518

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3518/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
43m  2s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 24s

trunk passed

+1 :green_heart:
compile
2m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 29s

trunk passed

+1 :green_heart:
shadedclient
56m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 17s

the patch passed

+1 :green_heart:
compile
2m 27s

the patch passed

+1 :green_heart:
cc
2m 27s

the patch passed

+1 :green_heart:
golang
2m 27s

the patch passed

+1 :green_heart:
javac
2m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 18s

the patch passed

+1 :green_heart:
shadedclient
17m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
95m 41s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

219m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3518/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3518

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell golang

uname
Linux d0e0d2ac28a4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 95b537ee6a9ff3082c9ad9bc773f86fd4be04e50

Default Java
Red Hat, Inc.-1.8.0_302-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3518/2/testReport/

Max. process+thread count
625 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3518/2/console

versions
git=2.9.5 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
25m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
21m 51s

trunk passed

+1 :green_heart:
compile
2m 48s

trunk passed

+1 :green_heart:
mvnsite
0m 43s

trunk passed

+1 :green_heart:
shadedclient
43m 58s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 22s

the patch passed

+1 :green_heart:
compile
2m 37s

the patch passed

+1 :green_heart:
cc
2m 37s

the patch passed

+1 :green_heart:
golang
2m 37s

the patch passed

+1 :green_heart:
javac
2m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 22s

the patch passed

+1 :green_heart:
shadedclient
18m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
106m 27s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

200m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3518/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3518

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell golang

uname
Linux d41f2df2da4e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 95b537ee6a9ff3082c9ad9bc773f86fd4be04e50

Default Java
Red Hat, Inc.-1.8.0_302-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3518/2/testReport/

Max. process+thread count
544 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3518/2/console

versions
git=2.27.0 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
15m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
26m 46s

trunk passed

+1 :green_heart:
compile
2m 37s

trunk passed

+1 :green_heart:
mvnsite
0m 26s

trunk passed

+1 :green_heart:
shadedclient
54m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 16s

the patch passed

+1 :green_heart:
compile
2m 22s

the patch passed

+1 :green_heart:
cc
2m 22s

the patch passed

+1 :green_heart:
golang
2m 22s

the patch passed

+1 :green_heart:
javac
2m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 18s

the patch passed

+1 :green_heart:
shadedclient
24m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
108m 57s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

210m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3518/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3518

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell golang

uname
Linux 9ffd18d828db 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 95b537ee6a9ff3082c9ad9bc773f86fd4be04e50

Default Java
Debian-11.0.12+7-post-Debian-2deb10u1

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3518/2/testReport/

Max. process+thread count
731 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3518/2/console

versions
git=2.20.1 maven=3.6.0

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 28s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
27m 39s

trunk passed

+1 :green_heart:
compile
3m 46s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
3m 29s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
mvnsite
0m 28s

trunk passed

+1 :green_heart:
shadedclient
60m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 18s

the patch passed

+1 :green_heart:
compile
3m 19s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
cc
3m 19s

the patch passed

+1 :green_heart:
golang
3m 19s

the patch passed

+1 :green_heart:
javac
3m 19s

the patch passed

+1 :green_heart:
compile
3m 27s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
cc
3m 27s

the patch passed

+1 :green_heart:
golang
3m 27s

the patch passed

+1 :green_heart:
javac
3m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 19s

the patch passed

+1 :green_heart:
shadedclient
25m  3s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
88m 38s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

186m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3518/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3518

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell golang

uname
Linux caa7d242ca97 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 95b537ee6a9ff3082c9ad9bc773f86fd4be04e50

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3518/2/testReport/

Max. process+thread count
737 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3518/2/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


How to add Highcharts to apache superset?

Make sure these boxes are checked before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if any
[ ] I have reproduced the issue with at least the latest released version of superset
[ ] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
Expected results
Actual results
Steps to reproduce
Can someone give tutorial on how to add Highcharts to superset from backend to frontend?

Highcharts has a not-so-permissive license and can't be bundled with Apache Superset. Much work has been done and is still ongoing around allowing new chart types as plugins though, so you could make a Highcharts plugin once that's ready.

So for now there is now way to add Highcharts into Apache Superset?


help can't install on windows 11

I have windows 11 home single language. I got erro message telling me it's need windows 11.

....this is not the discussion for the actual Arc Browser.... you can go to their official Discord community for that


downstream

Pull requests without a rationale and clear improvement may be closed
immediately.
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly.

Any test improvements or new tests that improve coverage are always welcome.
All other changes should have accompanying unit tests (see src/test/) or
functional tests (see test/). Contributors should note which tests cover
modified code. If no tests exist for a region of modified code, new tests
should accompany the change.
Bug fixes are most welcome when they come with steps to reproduce or an
explanation of the potential issue as well as reasoning for the way the bug
was fixed.
Features are welcome, but might be rejected due to design or scope issues.
If a feature is based on a lot of dependencies, contributors should first
consider building the system outside of Bitcoin Core, if possible.
Refactoring changes are only accepted if they are required for a feature or
bug fix or otherwise improve developer experience significantly. For example,
most "code style" refactoring changes require a thorough explanation why they
are useful, what downsides they have and why they significantly improve
developer experience or avoid serious programming bugs. Note that code style
is often a subjective matter. Unless they are explicitly mentioned to be
preferred in the developer notes, stylistic code
changes are usually rejected.

Bitcoin Core has a thorough review process and even the most trivial change
needs to pass a lot of eyes and requires non-zero or even substantial time
effort to review. There is a huge lack of active reviewers on the project, so
patches often sit for a long time.

upstream sucks gui non responsive

Yeah there is just something wrong with the GUI, it's not from upstream, at least not this time. I suspect the usual suspect: QT

idk something seems to be hanging in a bitcoin-qt-init thread but it was in before this downstream and aint nobody got time for debugging that

idk something seems to be hanging in a bitcoin-qt-init thread at least on linux but it was in before this downstream and aint nobody got time for debugging that AND i upgraded QT at some point and would never rule that out as the culprit I sure don't remember ever getting so many 'deprecated' type of warnings spat out at me by QT headers while compiling the GUI code; I say all of QT should be deprecated by now


NEW INDEX: NSDSI2

Please, complete the following information:
NSDSI2=SpectralIndex(
    short_name='NSDSI2',
    long_name=' Normalized Shortwave-infrared Difference Bare Soil Moisture Indice 2,
    formula='(S1- S2)/ S2',
    reference='https://doi.org/10.1016/j.isprsjprs.2019.06.012',
    type='water',
    date_of_addition='2022-09-29',
    contributor="https://github.com/CvenGeo"
)

Hi @CvenGeo!
I revised your index suggestion and it was perfectly aligned with the Awesome Spectral Indices (ASI) standard!
The index was added to the catalogue and it will be available in the next version of ASI.
Cheers!


[Feat] Option or shortcut to choose only shallow folder

Current Behavior:
Selecting a folder to add to the Chatpanel as additional context automatically includes all sub-folders.
Desired Behavior:
To have the option to include sub-folders or only the first-level folder, excluding sub-folders and their files.

Thanks for the suggestion @PriNova.
This issue is in progress!


Input np.array as input layer

Hi,
I'm currently using two models, one that takes in a Numpy array and generates an audio file using Tensorflow and the other that inputs these audio files for further processing. I tried using z -= Input(shape=(1, 100)) but I get an error stating that I cannot input a tf.object into a given Tensorflow graph.
Is there any way that I can transform my input layers in Keras into a numpy array?
Thanks!

Hi, your problem looks similar to this Were you able to solve it?

Please fill the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Along with the template, please provide as many details as possible to find the root cause of the issue. It would be great if you can provide a small code to reproduce the error. Thanks!

@jvishnuvardhan I think the issue is solved now. I must have made some typo. The link provided by @psschand really helped me. Thanks a lot!


Glitches in display of rdfs:label

There are multiple issues in how the ontological characteristics of rdfs:label is displayed:

for which resource is it displayed like this? i want to check what data the backend returns

for which resource is it displayed like this? i want to check what data the backend returns

https://spec.edmcouncil.org/fibo/ontology?query=http%3A%2F%2Fwww.w3.org%2F2000%2F01%2Frdf-schema%23label

@dasawanaka:

we should avoid string manipulations on IRIs
the domain statement should look: label Domain Resource and not Resource Domain Resource.


Update install instructions (rls->rls-preview)

The rls component has been renamed to rls-preview.

Thanks!


Add more performance tests

Thanks for opening this PR, and apologies that we seem to have entirely missed it!
I'm in the process of archiving this repository, since we're evolving Unity to overcome some limitations of this public git submodule setup. More details about the new system, and how you can reach out for any questions or to add your project, can be found at https://github.com/cue-lang/cue/discussions/2427. I'd be happy to help you add any of your code to the Unity corpus :)
In the meantime, I'll close this PR for the sake of the repo archiving.


Update manifest for ActivityWatch.ActivityWatch

Microsoft Reviewers: Open in CodeFlow

Why was the v prefix added to PackageVersion? Doesn't seem like the common thing for other packages in this registry.
Commenting/discovered this because it leads to services like Repology to incorrectly report the version as out of date: https://repology.org/project/activitywatch/versions

@ItsLevvie After further looking around the repo and attempting to understand the best practices, this should probably be reverted.

Submitted a PR #17564 which fixes the version prefix.


[HOLD for payment 2023-10-02] [$500] Web -  Editing request money while the user paid the requested money will still notify the change

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click '+' FAB from user A
Click on  request money and request any amount from user B
When the request  opens for user A go to editing page and click on the amount
Edit the amount from user A and leave it unsaved
Pay the request from USER B
Immediately after you paid the request save the change you made from User A in step 4

Expected Result:
No change should be reflected
Actual Result:
A notification that shows change will appear in the edit room
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/4fdc9922-33a6-4095-b42a-8b4bb6a838a1
https://github.com/Expensify/App/assets/93399543/0a3a936f-f217-4872-834f-708b2eb0f7dc
Expensify/Expensify Issue URL:
Issue reported by: @lidiyakelay
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693558160950359
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b9b7308912bc30e7
Upwork Job ID:<PHONE_NUMBER>216015872
Last Price Increase: 2023-09-15
Automatic offers:

namhihi237 | Contributor | 26743504
lidiyakelay | Reporter | 26743507

I've run out of time today and will test soon.

Still on my testing list

@ntdiary - can you please review if the proposal will fix this issue? Thanks!

@ntdiary - all good, we are in different timezones. 😄 Thanks for the quick review here.

@namhihi237's proposal LGTM, and I agree iou.error.genericEditFailureMessage looks like the right message to use 👍🏼

@ntdiary @roryabraham While executing the step, I found an error in addition to the above one on current main and stg.
Steps:

Click the FAB button from user A
Click on request money and request any amount from user B
User A turns off the network
User B paid the request money
User A Edit amount and back online, Sometimes it is observed that messages are located in the wrong position

This error will not occur when there is any message before going offline.

Click the FAB button from user A
Click on request money and request any amount from user B
User A edit amount and save
User A turns off the network
User B paid the request money
User A Edit amount and back online

I think this error is not within the scope of this PR. What do you think? If agree, I will report a bug for this error and this will fix it in another issue.
Detail video.
https://github.com/Expensify/App/assets/39086067/8a8dac03-04e2-4b26-8a48-8f04c380da5f

I personally think we can create a separate issue to investigate it

Sure. @namhihi237 you should post it in #expensify-bugs so you can get the reporting bonus.

@ntdiary - please complete the checklist to prepare for the payment date. Thanks!

Alright, everyone has been paid here. Great work!


Warns

This should remove all compiler warnings about dead code...

Codecov Report

Merging #210 (1e041a6) into main (6f0cd01) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   73.35%   73.35%
=======================================
  Files          30       30
  Lines        5040     5040
=======================================
  Hits         3697     3697
  Misses       1343     1343

Files Changed
Coverage Δ

limitador/src/storage/disk/expiring_value.rs
94.54% <ø> (ø)

limitador/src/storage/disk/mod.rs
0.00% <ø> (ø)

limitador/src/storage/disk/rocksdb_storage.rs
87.65% <ø> (ø)

limitador/src/storage/mod.rs
91.20% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Admin [Your Profile] panel calls /ghost/null

Issue Summary
The Ghost admin user-panel calls the URL /ghost/null
Steps to Reproduce
(start with fresh install)

Open the Ghost admin
Click on the user-panel in the bottom-left corner of the screen
Click "Your Profile"

Ghost Version
5.96.1
Node.js Version
18.20.4
How did you install Ghost?
Docker ghost:5-alpine
Database type
MySQL 8
Browser & OS version
Firefox 131.0.2
<div class="flex min-h-[40vmin] flex-wrap items-end justify-between bg-cover bg-center" style="background-image: url("null");"> ... </div>

No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Closing issue. Opening new issue with clearer description and DOM content


SF-1153: Update tslint-config-groupby package version

Bump tslint-config-groupby version to v1.1.0 and update tsconfig.json to accommodate tslint updates.

Codecov Report

Merging #103 into master will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   93.93%   94.12%   +0.18%
==========================================
  Files         214      207       -7
  Lines        5953     5767     -186
  Branches      753      721      -32
==========================================
- Hits         5592     5428     -164
+ Misses        266      248      -18
+ Partials       95       91       -4

Impacted Files
Coverage Δ

<EMAIL_ADDRESS>0% <0%> (-92.86%)
:arrow_down:

<EMAIL_ADDRESS>0% <0%> (-60%)
:arrow_down:

...nt/flux-capacitor/src/core/reducers/is-fetching.ts
88% <0%> (-0.89%)
:arrow_down:

...ont/flux-capacitor/src/core/reducers/is-running.ts
100% <0%> (ø)
:arrow_up:

<EMAIL_ADDRESS>100% <0%> (ø)
:arrow_up:

...capacitor/src/core/reducers/data/productsLoaded.ts
100% <0%> (ø)
:arrow_up:

...ux-capacitor/src/core/reducers/data/site-params.ts
100% <0%> (ø)
:arrow_up:

<EMAIL_ADDRESS>100% <0%> (ø)
:arrow_up:

...efront/flux-capacitor/src/core/reducers/session.ts
100% <0%> (ø)
:arrow_up:

<EMAIL_ADDRESS>100% <0%> (ø)
:arrow_up:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e188b4...fd56b90. Read the comment docs.


Attachments

Is it possible for me to get at the the attachments for each individual email rather than to get all attachments from all emails?

You want to be able to get a list of search results, then pull the attachments for each email one at a time, instead of pulling them all at once?
No, that is not possible with the current implementation. I think you could probably do that with node-imap though. If you want to make a change to this library to support that, one way I could think to do it would be to expose a new method that allows you to perform a fetch on a uid without a search. This would allow you to use the normal search() to retrieve the minimal details for the search you are performing, then do a followup fetch() to get extended details on the uids you want.

I think you can do that if you specify in your search criteria the subject of the mail you want to download only their attachment


MapView - setOnCameraChangedListener

Hi everybody!
There is anyway to "listen" camera events? I've tried to set OnCameChangeListener to mapView or mapController but i noticed that classes didin't implement the according interface.
I have no idea the correct way to add this feature...
Any help will be great!
Thanks in advance.

You can set MapListener and get notified when onScroll or onZoom event occurs.

ziem,
It's a good approach. I'll try in that way.
Thanks!


Author pages

This closes #21

Thanks for taking a crack at this. I think we should standardise on a single "list of posts" components. Based on your PR I've done that and added author pages. I've also added you to the list of contributors as this was mostly inspired by your PR.


Chore: 6.3.0

:scroll: Description
#skip-changelog
:bulb: Motivation and Context

:green_heart: How did you test it?
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] I updated the docs if needed
[ ] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps

Codecov Report

Merging #741 (36a362e) into main (2f58f46) will increase coverage by 5.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
+ Coverage   90.55%   95.65%   +5.09%
==========================================
  Files         104        2     -102
  Lines        3357       46    -3311
==========================================
- Hits         3040       44    -2996
+ Misses        317        2     -315

Impacted Files
Coverage Δ

dart/lib/src/version.dart

dart/lib/src/protocol/sdk_info.dart

dart/lib/src/http_client/breadcrumb_client.dart

dart/lib/src/http_client/sentry_http_client.dart

dart/lib/src/sentry_span_interface.dart

dart/lib/src/protocol/sentry_app.dart

.../lib/src/integrations/debug_print_integration.dart

dart/lib/src/protocol/sentry_request.dart

.../lib/src/enricher/io_enricher_event_processor.dart

dart/lib/src/diagnostic_logger.dart

... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f58f46...36a362e. Read the comment docs.


Page gets redirected, if the page URL is the same as portal alias with a different domain

Description of bug
If the page name is the same as the portal name in a different domain, the page can't be accessed since it redirects to the other portal when tried to be accessed.
Steps to reproduce

Let's say the root portal has a page with URL "922e.dnndev.me/dallas" (notice that the site has a subdomain of "922e" and a postfix of "dallas")
Admin created a new portal with "dnndev.me/dallas" url
Try to access the "dallas" page of the root portal from Step 1.

Current behavior
The request gets redirected to the new portal's home page from Step 2.
Expected behavior
The "dallas" page of the main site from Step 1 (922e.dnndev.me/dallas) should be opened.
Screenshots
Reproduction video: https://drive.google.com/file/d/1syAoLyUFDKJumYP5ImqX7bkTJeaXP1y1/view
Affected version

[X] 10.00.00 alpha build
[ ] 09.09.00 latest supported release

Affected browser

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Internet Explorer 11
[ ] Microsoft Edge (Classic)
[ ] Microsoft Edge Chromium

the problem seems to be in the routine to create a sub-website, which needs to check for an existing page path and should prevent the site to be created in this case (AFAIK creating a page URL doesn't work, if there already is a sub-website with same address.)

btw. I disagree that a page URL should override a sub-website with same URL.
Is there any specific use case you are having in mind?

Github applied a formatting to an important text there and I fixed it and it might have created this confusion. I edited the following:

To explain the issue in more detail: If there is a site with "test" name for example, you can't have a page named as "test" (in the same site) and there is already a check for that. However, the problem occurs only when the portal gets created on a different domain. Because the following URLs should return different pages:

domain.dnndev.me/test1 (refers to page)
dnndev.me/test1 (refers to a site's home page)

You can check my PR from https://github.com/dnnsoftware/Dnn.Platform/pull/4670 btw.

there is a problem caused by the redirect for sub-portals.
If I remember correctly, if you create a sub-website "domain.dnndev.me/test1", a folder is created in the root folder (/test1) with a redirecting default.aspx. This should be accessible with higher priority than a page with same name in the parent site.
However, UI of DNN should try to avoid sub-website and page with same path to be created.

Asking for additional confirmations that this can't be implemented before closing the issue.

Hi @bdukes . The issue is not related to subdirectory creation in any way.
The your last paragraph you stated that for the ambiguity cases, the alias should take the precedence. However, that case is not possible at all because if you have a site with example.com/dallas URL, you can't have a page named "dallas" in the same domain because there is already a validation for that:

and vice versa (creating the page first and then the site):

The problem with the code was that it wasn't checking the pages at all and it was returning directly in case there is a possible match in the alias and my code fixes that. I can provide detailed debugging pictures etc. if you require, just let me know.

As far as I can see, PR #4670 does contain some discussion.
Did you check out feedback from @bdukes ?

yes, the conversation there ended by redirecting the discussion here, and feedback from Brian was commented

Hey team, could you please check this individually or discuss the impact and solution on then next TAG meeting?

@v-karbovnichy We discussed this today during the approvers meeting, we will review this with a proposed recommended path and comment back after our next meeting.

Any updates on this?

Hi team, any updates on this?

Please share updates on this issue


Squashed changes from messed up merge

Description of change
Replacement of messed up PR https://github.com/uktrade/data-hub-api/pull/4920
Every day at 8AM we need to generate reminders based on the reminder settings inside each task, and add them to the list of task reminders. Email reminders should be send to advisers who have this enabled.
Testing

Sign up for an Gov Notifications account at: https://www.notifications.service.gov.uk/
Create a Trail mode service
Create an email template:
Template name: Overdue Task (trail)
Subject: Your task is now overdue: ((task_title))
Message:

# Your task is now overdue: ((task_title))

Company: ((company_name))
Date due: ((task_due_date))

[View task](((task_url)))

Add the following to your API's .env file:

INVESTMENT_NOTIFICATION_API_KEY=`your-datahub-notification-api-key`
TASK_REMINDER_STATUS_TEMPLATE_ID=`your-task-reminder-status-template-id`

Ensure you have the adviser-tasks user feature flag enabled.
Ensure you have the email address you used to setup gov notify set for your test account adviser in the API.
Create a Investment Project Task with reminder due of tomorrow and the number of reminder days = 1.
Run the following python from the command line:

import os
from datetime import datetime
from logging import getLogger
import django
import environ

os.environ.setdefault('DJANGO_SETTINGS_MODULE', 'config.settings.local')
'config.settings.local'
django.setup()
from datahub.task.tasks import generate_reminders_upcoming_tasks
generate_reminders_upcoming_tasks()

Checklist

[x] Has this branch been rebased on top of the current main branch?

Explanation
The branch should not be stale or have conflicts at the time reviews are requested.

[x] Is the CircleCI build passing?

General points

Other things to check

Make sure fixtures/test_data.yaml is maintained when updating models
Consider the admin site when making changes to models
Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Replaced by https://github.com/uktrade/data-hub-api/pull/4940


Performance Testing

Need to hit apollo with everything I got and see how it performs. Will be using systrace and traceview. Let me know how else I can perf test

Not sure if it's relevant, but I find that requests with apollo seem an order of magnitude slower at times than plain old rest requests. Maybe it's just Github's API being slow though


fix: keyboard overlaps pdf error modal

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/48263
PROPOSAL: https://github.com/Expensify/App/issues/48263#issuecomment-2319480394
Tests

Send a corrupted PDF file corrupted.pdf

Verify Attachment error modal shows

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Send a corrupted PDF file corrupted.pdf

Verify Attachment error modal shows

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/f4cbbdb4-4782-4192-9f4f-d0d0388098e4

Android: mWeb Chrome

https://github.com/user-attachments/assets/ff162e12-55d5-48c9-862e-a069e98a7427

iOS: Native

https://github.com/user-attachments/assets/e15cd91a-c71e-4baf-a0c0-746375da3ca7

iOS: mWeb Safari

https://github.com/user-attachments/assets/f1e1d9cb-dbcd-42cf-9bbc-0f28790f361a

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/f459fcca-3c2c-4fc9-ab81-5d02039ec4bb

MacOS: Desktop

https://github.com/user-attachments/assets/34d70574-f229-4648-87ab-e7407012b724

Hey @dominictb, do you think you could take a look at the eslint changes whenever you get a chance?

Awesome thanks @dominictb. I did ask internally and it is preferred we fix the lint as a part of the issue when possible so that is great.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.0.40-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Enhancement request: allow @Weak annotation to generate __unsafe_unretained or __weak

The request is for a new command line argument for j2objc to optionally generate __weak attribute, instead of __unsafe_unretained, for @Weak annotation.

Why not use Java's WeakReference? If it's possible that a variable could be accessed after it's no longer strongly referenced, it seems likely that you would need similar functionality on the Java side as well.

I would go a step further in saying that @Weak* so go back to their previous behavior as the name implies and if unsafe/un-retained is to be supported it should have it's own annotation. However, I am not aware of any mechanism to check if a pointer is valid,  so the only safe use of unsafe/un-retained instance variable is to check if it is null. Any attempt to use weak in an environment that does not support it should be a compile (or transpile) time error left to the developer to deal with.

@danieldickison I think most people who use the @Weak annotation to prevent memory leaks that can happen in Objective-C but not in Java. As you know Java's GC is much more sophisticated than ARC and the @Weak annotations helps programmers deal with the difference without refactoring their code. Having and unsafe/un-retained instance variable in ARC means you can never safely use the variable without having some other means of verifying its validity.

If you want a field that may vanish and be validated at runtime, follow Daniel's suggestion to use WeakReference. The @Weak annotation should only be used to break retention cycles, and does not have the same semantics as __weak (we need a new annotation name, like DontRetain). An example where this is very appropriate is LinkedList.Node, where its prev field is @Weak, while its next field isn't. This ensures that when a LinkedList is deleted, its nodes all are. Normally these fields are private (they're an aspect of the hidden implementation), and it's worth taking a hard look at any that aren't.
With this big restriction, it doesn't matter whether generated code uses __weak or unsafe/unretained, since the only code that should reference those fields is generated.
As I've had to do in the past, I must again deeply apologize for naming the project "J2ObjC", since it's purpose has always been to compile Java to iOS, not translate it into another language. "ObjC" shouldn't have been part of the name, because (like @Weak fields) that implementation should have been hidden from its public API. This is why engineers need to tolerate their marketing people, as most actually know what they're doing. :-)

What you are saying is correct. I think there is a misunderstanding of why we want it. Your stated reason for using @weak is the only reason anyone would use it for (to break retention cycles). No variable marked with @weak will ever be set to null in a Java environment. That only happens in ObjC.
If I have my own implementation of LinkedList (or something similar) in Java, I would have to rewrite it to make it work with J2ObjC. Aside form the rewrite work; it would also become much slower. I have simply modified the translator instead.  If I were forced to use a non-ARC environment, I would probable modify the translator the generate macro calls, to replace direct access to the variable with a function call that manages the memory for me.
A differently named annotation would be fine. I think most folks who want this back just want a way to break retention cycles within their own code.


Get params from handler fn

Params are handled by order, not by name. Don't think there is a way to get parameter names.
Currently treats each parameter after the first three as capture arguments. Might want to only pull the 4th argument, and then use a struct?

Would close #79

Alright, it should function now. I'm going to do one more pass and see if I can make it look nicer, and then see where we are

Thanks a lot for this leroycep! This is much appreciated :)


try npm install node

It might make moro node version independent!
Might help with #163 etc as well

Didn't help with running moro on real old nodes.
What about packaging the binary?
https://github.com/pmq20/node-packer?utm_source=mybridge&utm_medium=blog&utm_campaign=read_more

Executables are available on release page now


vocabularies: support loading new fixtures over time

prereq: invenio-vocabularies 0.7.4

reloading can add new vocabularies/subvocabularies
already loaded vocabularies/subvocabularies are simply ignored
updating/deleting is not touched
rearrange vocabularies.yaml structure for subtypes
loads subtype metadata in DB so it can be used on frontend
closes https://github.com/inveniosoftware/invenio-rdm-records/issues/686

closing in favour of https://github.com/inveniosoftware/invenio-rdm-records/pull/734 - was easier to fix strange test issues from clean slate with cherry-picked/adapted commits.


[FEAT] Demo should not use old @daffodil/checkout features

Checkout is being overhauled. All the old features from checkout should be removed from demo

this involves an overhaul of demo checkout which adds a lot of complexity to this task


Linting and Code Cleanup

Type of PR:
Refactoring

PR Description:
This PR focuses on cleaning up the codebase by addressing linter warnings and reorganizing import statements. It also includes minor changes to improve code readability and efficiency.

PR Main Files Walkthrough:
-pr_agent/agent/pr_agent.py: Reordered import statements.
-pr_agent/algo/git_patch_processing.py: Removed unused loop variable 'i'.
-pr_agent/algo/pr_processing.py: Reorganized import statements.
-pr_agent/algo/utils.py: Removed unused variable 'result' and added newline for readability.
-pr_agent/git_providers/__init__.py: Reordered import statements.
-pr_agent/git_providers/bitbucket_provider.py: Removed unused import 'datetime' and added newline for readability.
-pr_agent/git_providers/git_provider.py: Added newlines for readability.
-pr_agent/git_providers/gitlab_provider.py: Reordered import statements and added newlines for readability.
-pr_agent/servers/github_action_runner.py: Removed unused import 're'.
-pr_agent/servers/github_polling.py: Removed unused import 're'.

/describe

Preparing review...

Preparing review...

PR Analysis

🎯 Main theme: Linting and Code Cleanup
📌 Type of PR: Refactoring
🧪 Relevant tests added: No
✨ Focused PR: Yes, the PR is focused as it clearly states in the title and description that it is for linting and code cleanup. All the changes in the PR are related to this task.
🔒 Security concerns: No, the PR does not introduce any obvious security concerns. It mainly focuses on code cleanup and does not seem to introduce new features that could potentially lead to security vulnerabilities.

PR Feedback

💡 General PR suggestions: The PR is well-structured and focuses on cleaning up the codebase by addressing linter warnings and reorganizing import statements. It also includes minor changes to improve code readability and efficiency. However, it would be beneficial to add tests to ensure that the changes do not introduce any regressions.


V1.2.0 Billing Client Integrated

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (387d506) 100.00% compared to head (4faea70) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff              @@
##                main       #23     +/-   ##
=============================================
  Coverage     100.00%   100.00%
- Complexity       585      1010    +425
=============================================
  Files             45        70     +25
  Lines           1337      2477   +1140
  Branches         141        88     -53
=============================================
+ Hits            1337      2477   +1140

Files
Coverage Δ

...ta/client/endpoint_client/billing/AddOnClient.java
100.00% <100.00%> (ø)

...client/endpoint_client/billing/DiscountClient.java
100.00% <100.00%> (ø)

.../client/endpoint_client/billing/InvoiceClient.java
100.00% <100.00%> (ø)

...eta/client/endpoint_client/billing/PlanClient.java
100.00% <100.00%> (ø)

...ient/endpoint_client/billing/PlanFamilyClient.java
100.00% <100.00%> (ø)

...nt/endpoint_client/billing/SubscriptionClient.java
100.00% <100.00%> (ø)

...dpoint_client/billing/UpdatePaymentInfoClient.java
100.00% <100.00%> (ø)

...seta/client/endpoint_client/crm/AccountClient.java
100.00% <ø> (ø)

...outseta/client/endpoint_client/crm/DealClient.java
100.00% <ø> (ø)

...tseta/client/endpoint_client/crm/PeopleClient.java
100.00% <ø> (ø)

... and 30 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


faster stream file parser

I wrote a faster version of the stream file parser. It mostly just uses more numpy and less pandas while vectorizing operations within a crystal block.

Codecov Report

Merging #216 (d0ee0d6) into main (859e75c) will decrease coverage by 1.81%.
The diff coverage is 74.39%.

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   98.39%   96.58%   -1.81%
==========================================
  Files          45       45
  Lines        1803     1845      +42
==========================================
+ Hits         1774     1782       +8
- Misses         29       63      +34

Flag
Coverage Δ

unittests
96.58% <74.39%> (-1.81%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

reciprocalspaceship/io/crystfel.py
75.86% <74.39%> (-18.84%)
:arrow_down:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Does this/could this also address https://github.com/rs-station/reciprocalspaceship/issues/213 ?

@DHekstra ,  i don't know if the information you want is available in the stream file. i would  need to see an example.

This looks pretty good to me, but I'll do another look through before approving/merging.

There are a couple of issues that still need to be addressed

Doeke provided me some more recent stream files, and they seem to break some of my formatting assumptions.
The current version doesn't respect that some files have the photon energy measured per frame. My code just uses the photon energy in the header for every crystal. This is a problem for XFEL data where the peak energy changes from shot to shot.

I'm going to hold off until I have a bit more time to look through it.

@kmdalton, what is the status of this? I'm revisiting some stream files next week, and could test drive your parser.

that's alright. I have a slow but functional parser.

Just checking in here -- is there anything left to do on this PR or should it be merged into main?

I discovered this version in was incompatible with some stream files provided by @DHekstra. I haven't been able to diagnose the issue yet. I would recommend we hold off on merging.

Does this need to be merged anymore? Or will this be superseded by #260 ?


0083 - Remove Duplicates from Sorted List

Description of the Problem
Given a sorted linked list, delete all duplicates such that each element appear only once.
Example-1:
Input: 1->1->2
Output: 1->2
Example-2:
Input: 1->1->2->3->3
Output: 1->2->3
Code
class Solution:
def deleteDuplicates(self, head: ListNode) -> ListNode:
if head==None:
return head
current= head.next
prev=head
while current!=None:
if current.val==prev.val:
prev.next=current.next
current=current.next
else:
current=current.next
prev=prev.next
return head
Link To The LeetCode Problem
LeetCode

I'm ready to deal with this problem

Can you assign this to me @vJechsmayr ?

Hey, I have the solution ready waiting for assign and commit/


Handle namespaces

Adds test that ensures that system modes work with ROS 2 namespaces, see two_lifecycle_nodes_modes.yaml#L35.

Codecov Report

Merging #77 (f369b1b) into master (86fe634) will decrease coverage by 10.78%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master      #77       +/-   ##
===========================================
- Coverage   32.15%   21.37%   -10.79%
===========================================
  Files          14       14
  Lines        1048     1048
  Branches      754      754
===========================================
- Hits          337      224      -113
- Misses        142      515      +373
+ Partials      569      309      -260

Impacted Files
Coverage Δ

system_modes/src/system_modes/mode_inference.cpp
30.24% <0.00%> (-6.54%)
:arrow_down:

system_modes/include/system_modes/mode_manager.hpp
0.00% <0.00%> (-100.00%)
:arrow_down:

system_modes/include/system_modes/mode_monitor.hpp
0.00% <0.00%> (-100.00%)
:arrow_down:

...ystem_modes/include/system_modes/mode_handling.hpp
0.00% <0.00%> (-100.00%)
:arrow_down:

system_modes/src/system_modes/mode_monitor.cpp
0.79% <0.00%> (-26.20%)
:arrow_down:

system_modes/src/system_modes/mode_manager.cpp
0.37% <0.00%> (-16.92%)
:arrow_down:

system_modes/src/system_modes/mode.cpp
45.90% <0.00%> (-9.84%)
:arrow_down:

system_modes/src/system_modes/mode_impl.cpp
36.04% <0.00%> (-2.33%)
:arrow_down:

system_modes/src/system_modes/mode_observer.cpp
20.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86fe634...f369b1b. Read the comment docs.


Bower package recognition not working

The compilation fails with a message
error: Resolving deps of app/initialize.js failed. Could not load module 'angular-jsonapi' from '/home/cygnus/Projects/home_accounting_front/app'. Possible solution: add 'angular-jsonapi' to package.json and npm install.
I went through the steps described in the FAQ to use bower packages: Run a bower init to get my bower.json, added the deps, installed, etc.
The package I'm trying to use angular-jsonapi has a valid bower.json file with a main property.
I saw in this SO question that brunch gives a very descriptive error message when a bower package does not have a main property, so this probably is not the problem.

@goshakkk

The files are being concatenated into vendor.js, and I can even see them in the web inspector. They dont seem to be modulairzed, unlike other packages from npm.
Opened an issue in the wrong repo though, closing.

I think I found out the root of the problem. When I require vedor.js its throws an error:
"Cannot find module 'process' from '/'"
when trying to process = require('process'). This makes sense because the server warned that browser.js was compiled but not writen:
01 May 03:37:52 - info: application started on http://localhost:3333/
01 May 03:37:54 - warn: /usr/lib/node_modules/brunch/node_modules/deppack/node_modules/node-browser-modules/node_modules/process/browser.js compiled, but not written. Check your javascripts.joinTo config
01 May 03:37:55 - info: compiling
01 May 03:37:55 - info: compiled 17 files into 3 files, copied 2 in 4.3 sec
01 May 03:37:56 - info: copied index.html in 70ms¡

Solved. Modified my joinTo config to include that file:
module.exports =
  files:
    javascripts:
      joinTo:
        'vendor.js': /^(bower_components|(\/usr\/lib\/)?node_modules)/
        'app.js': /^app\//

@nicooga in general, it's better to have a local brunch in your project instead of using a global one. That way, the vendor regexp won't have to account for the global location of brunch


[FIX JENKINS-38673] Update deps

Description

See JENKINS-38673.

Submitter checklist

[ ] Link to JIRA ticket in description, if appropriate.
[ ] Change is code complete and matches issue description
[ ] Appropriate unit or acceptance tests or explanation to why this change has no tests

Reviewer checklist

[ ] Run the changes and verified the change matches the issue description
[ ] Reviewed the code
[ ] Verified that the appropriate tests have been written or valid explanation given

@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.


Add FIM template for Codestral-22B

NOT TESTED! I don't have anything set up for creating VSCode extensions (not even TS... compiler?)
tl;dr:
I've tried adding Codestral into FIM templates.
BTW, it seems like it's FIM tuning is meh? Or maybe it's a quants issue(5bpw)? Anyway, back to starcoder2-15B.
Description
This is implementation of Codestral's FIM template.
Template itself is slightly different compared to Continue's implementaion (they use something like [SUFFIX]{suffix}[PREFIX]{filecontext}{prefix}) - I've put fileContext before [SUFFIX] - because as prefix grows Codestral quickly starts to lose suffix's context and use filecontext instead
Also it seems like Codestral prefers +++++ relative/file.path as a file header? I don't think I've seen anything about it in official docs though.
I've tested this template directly in oobabooga on bartowski_Codestral-22B-v0.1-exl2_5_0 (5 bpw model - enough for 24gb with 32k context) (but I've used  +++++ relative/file.path as file headers). Tests were very limited, from my findings Codestral:

heavily respects PREFIX
respects SUFFIX in easy cases (if PREFIX even slightly contradicts SUFFIX - result won't adhere to SUFFIX)
often ignores fileContext

Anyway, I haven't tested this code. And I don't mind if it won't be merged - I didn't like Codestral FIM performance anyway :P

LGTM, we can merge and see if anyone reports it's broken, I don't use codestral for FIM either...


Using Webpack breaks the app

Note: for support questions, please use one of these channels:
https://forum.ionicframework.com/
http://ionicworldwide.herokuapp.com/
Short description of the problem:
If I want to use Webpack for builds, I get the following error once the app is started with npm run ionic:serve:
main.js:34511 Uncaught Error: moduleId should be a string in "ObservationMetadataComponent". See https://goo.gl/wIDDiL for more information.
If you're using Webpack you should inline the template and the styles, see https://goo.gl/X2J8zc.
    at componentModuleUrl (http://localhost:8100/build/main.js:34511:15)
    at CompileMetadataResolver.getNonNormalizedDirectiveMetadata (http://localhost:8100/build/main.js:33863:25)
    at CompileMetadataResolver._loadDirectiveMetadata (http://localhost:8100/build/main.js:33799:42)
    at Array.map (native)
    at CompileMetadataResolver.loadNgModuleMetadata (http://localhost:8100/build/main.js:33980:68)
    at RuntimeCompiler._loadModules (http://localhost:8100/build/main.js:50670:41)
    at RuntimeCompiler._compileModuleAndComponents (http://localhost:8100/build/main.js:50640:35)
    at RuntimeCompiler.compileModuleAsync (http://localhost:8100/build/main.js:50630:21)
    at PlatformRef_._bootstrapModuleWithZone (http://localhost:8100/build/main.js:36206:25)
    at Object.<anonymous> (http://localhost:8100/build/main.js:140737:6)

What behavior are you expecting?
The app should work.
Steps to reproduce:
1.
2.
3.
insert any relevant code between the above and below backticks

Which @ionic/app-scripts version are you using?
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.4
Ionic CLI Version: 2.1.18
Ionic App Lib Version: 2.1.9
Ionic App Scripts Version: 0.0.48
ios-deploy version: Not installed
ios-sim version: Not installed
OS: macOS Sierra
Node Version: v6.7.0
Xcode version: Xcode 8.2.1 Build version 8C1002
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

@rolandjitsu,
Please provide a repo to reproduce the issue. At first glance, it seems like the developer is incorrectly distributing their lib.
Thanks,
Dan

@danbucholtz Unfortunately I cannot share code, I signed a NDA. But true, it's actually one of my own packages :) Give me a few minutes to double check that.

Yes, it was because of my own package. A moduleId slipped and it never failed when I was using Rollup.


Added null check. More descriptive cause message.

This PR backports a fix to the 0.7.x branch.
Fixes Issue
fixes issue #567
Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] All existing tests passed.

I have cherry picked a couple of commits. However some of the classes have been omitted. As they rely on commits that will never go into 0.7.x branch.

Rebased, and merged.
Thanks for your contribution !


window is not defined - nuxt

This throws an error while using with nuxt.js. Since nuxt doesn't use webpack explicitly there is no way to define it the same way.
I'm trying to declare vue-introjs as a plugins in vuex.

https://nuxtjs.org/faq/extend-webpack/

Can you give an example of how to use with nuxt?
I tried declaring it as plugins since it is similar to webpack.providePlugin. It throws an error Unexpected token import

Okay I solved it using
nuxt.config.js
const webpack = require('webpack')
build: {
plugins: [
new webpack.ProvidePlugin({
'introJs': ['intro.js', 'introJs']
})
]
}
and restart the server. Its documented in https://nuxtjs.org/faq/webpack-plugins

But now it complains about this.$intro() is not a function on initialising. Can you please help?

seems like you did not correctly registered this plugin in vue.
On Thu, Apr 26, 2018 at 9:04 AM, Ashwin A<EMAIL_ADDRESS>wrote:

But now it complains about this.$intro() is not a function on
initialising. Can you please help?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/alex-oleshkevich/vue-introjs/issues/21#issuecomment-384523748,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmzyJ3-HdVdagb1-GJHJbbu_dnACLk3ks5tsWOEgaJpZM4TjDeQ
.

--
Sincerely,
Alex Oleshkevich


fix: Simplify error

fixes #25

Pull Request Test Coverage Report for Build 77

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 72:
0.0%

Covered Lines:
28

Relevant Lines:
28

💛  - Coveralls


File "traceback.py", line 105, in print_exceptionoSError: [WinError 6]

Exception ignored from cffi callback function
_StreamBase.init..callback_ptr at Ox00000164FD1FDF70> :Traceback (most recent call last):
File "I:\RVC-beta\runtime\lib\site-packagesisounddevice.py", line 886,in callback_ptr
return _wrap_callback(
File "I:\RVc-betalruntime\libisite-packagesjsounddevice.py" , line2687, in _wrap_callback
callback(*args)
File "l:\RVC-beta\Rumeng.py", line 581, in audio_callback
self.rvc.infer(self.resampler1(torch.from_numpy(self.input_wav)))File "I:\RVC-betaRumeng.py", line 194, in infer
traceback.print_exco
File "traceback.py" , line 163, in print_exc
File "traceback.py", line 105, in print_exceptionoSError: [WinError 6]句柄无效。

MME show this errro,and wasapi or wdm cant out put any thing

My guess, you didn´t load in a .wav File and the File Format you supplied couldn´t be read.
Fixed most of my Problems by converting from .ogg/.flac/.mp3/etc  to  .wav first.


🥑🤖 v1.2.0 release prep

🥑🤖 Auto-generated PR for v1.2.0 release. Updating release versions in repo.

LGTM


Enable IPFIX export

This PR address the below issue https://github.com/netobserv/netobserv-ebpf-agent/issues/26 to provide IPFIX export of flow records, which can be consumed directly by any platform.

Doing an initial view, it looks good! I'll do later a more detailed review.
In the meantime, I think we should add e2e tests. For example, you can just copy the kafka folder into e.g. ipfix and add some modifications:
1- in the manifests/ subfolders, remove the kafka manifests, then configure the flp-transformer and agent manifests to export/accept IPFIX data (FLP already accepts IPFIX)
2- rename the kafka_test.go to ipfix_test.go, remove this lines and this lines.

Doing an initial view, it looks good! I'll do later a more detailed review.
In the meantime, I think we should add e2e tests. For example, you can just copy the kafka folder into e.g. ipfix and add some modifications:
1- in the manifests/ subfolders, remove the kafka manifests, then configure the flp-transformer and agent manifests to export/accept IPFIX data (FLP already accepts IPFIX)
2- rename the kafka_test.go to ipfix_test.go, remove this lines and this lines.

Thanks Mario, I will add the e2e tests.

Adding hold labels for the feature freeze.

@mariomac
I have added e2e tests. Do note that in FLP config, I had to fix "Interface" to  a non-zero field, since flp's ipfix input from goflow does not return interface name which was exported by ebpf agent.


pitch bend byte ordering

https://tigoe.github.io/SoundExamples/midi-pitch-bend.html says to use midiCommand(0xE0, msb, lsb); but the MIDI spec says this should be <pitch bend nibble> <channel nibble> 0LLLLLLL 0MMMMMMM where L are the 7 least significant bits, and M are the 7 most significant bits. So that would be midiCommand(0xE0, lsb, msb);

Fixed.


500 Error code when using GitHub actions and php-coveralls

Running our project locally I have been able to get my coverage report to upload to coveralls with the following commands:
docker-compose exec cms-php composer run-script tests
which runs
"tests": [ 			"cd tests ; ../vendor/bin/phpunit --verbose unit/" 		],
and then
docker-compose exec -e COVERALLS_REPO_TOKEN="INSERT_TOKEN_FROM_COVERALLS" cms-php composer run-script coverage
which runs
"coverage":[ 			"./vendor/bin/php-coveralls --coverage_clover=build/logs/clover.xml -v" 		]
when I run the same code with a custom Github Action, I get the "Server error occurred. status: 500 Internal Server Error"
This can been seen in our build runner
      env:
        COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      run: |
        composer global require php-coveralls/php-coveralls
        php-coveralls --coverage_clover=build/logs/clover.xml -v

Having a different issue currently will close this out. (Github Actions was having some issues)


slide navigation changes on slide 43 in ansible-essentials.html

Prior to the "Doing More with Playbooks" slide (43), most slides are progressed logically to the right.  However, in order to view the slides associated with this section, the presenter must navigate "down".
If this is not by design, I believe it is due to an extra <section> on line 892:  https://github.com/ansible/lightbulb/blob/10fa443916396445f0c9044208951349772a1f06/decks/ansible-essentials.html#L892

It's by design.


select all doesn't work in extension description page

Testing #54892
Select All does nothing in Extension description page. I tried some of my webview extensions and select all doesn't work as well.

Extensions description page is expected. What other webviews did you try?

Closing this as out of scope since there has been limited interest over the past two years


dragHandle issue on mobile

Hi. I'm trying to implement React-Sortable-hoc on a proyect and i'm facing a problem on mobile when i combine a grid setup with dragHangle (the small cross arrows in the upper left corner).
The element dragged get fixed and not follow the mouse. Also there's no way to end the drag. This is working just fine on desktop. Can anubody help me please?
I leave a gif video of the issue
Thanks!

I also see that the dynamic created LI at the bottom of the body, does not get the transform css style, so that's why is not following the mouse pointer.

I am getting the same issue

ok. Temporarly, I found a fix for this.

Find this line of code:
_this.listenerNode = event.touches ? node : _this.contentWindow;
and replaceit with this:
_this.listenerNode = event.touches ? event.target : _this.contentWindow;
When you import SortableContainer into your component (and only this one) should be referenced from this new file in your project and not from "plugins/sortable-hoc"
Regards

Thank you @epap-zenfolio


Minecraft "Paid Plugins" from SpigotMC

Feature Request
Feature Information:
I notice a distinct lack of ability to select paid plugins from SpigotMC (potentially others as well). Is this due to limitations on their side?
I am setting up a new server in hopes of "cloning" from an unmanaged headless server, and while I know I can manually install/update it would be amazing if it could be baked in.
I confirm:

[x] that I have searched for an existing feature request matching the description.

AMP uses "SpiGET" (https://spiget.org) as the API to get information on available plugins. SpigotMC does not have an official API to query this data or allow you to get information on premium plugins. Anything premium you must upload using AMPs file manager or internal SFTP.


create Permissions model

Probably right before being placed in the database, either in the sprocs or on the DLx server.

Or maybe they should just be Sets in the first place.

Each permissions Array should be uniqued.


PowerBI Example query has the incorrect field selection

In the following example/walk through, it references a sample query under this section:
https://docs.microsoft.com/en-us/azure/devops/report/powerbi/sample-boards-featureprogress?view=azure-devops&tabs=powerbi#sample-queries
If you look at the query, the sixth line references the select:
...
            &"&$select=WorkItemId,Title,WorkItemType,State,AreaSK "
...

I believe this is incorrect as it is missing the "Area,Iteration,AssignedTo" and should instead look like the following:
            &"&$select=WorkItemId,Title,Area,Iteration,AssignedTo,WorkItemType,State,AreaSK "

I made this comment due to if you go further down in the walk through under the transforms, it talks about the need to expand Area, Iteration,etc here: Transform
As a user following along, it wasn't immediately obvious why you didn't see those fields in the query until you slowed down and through about it. In either case, it's likely very minor detail, but might be confusing to some.
Thanks!
Justin

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8719e400-4445-59a4-c68e-628243710c36
Version Independent ID: d6a76999-81c0-33cb-47a5-9ca4d8be80c3
Content: Feature Progress rollup sample Power BI report - Azure DevOps
Content Source: docs/report/powerbi/sample-boards-featureprogress.md
Product: devops
Technology: devops-analytics
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@ploegert Thanks for finding this - We'll look into it -
If you want, you can make this change yourself. Use the edit icon to make your changes and create a PR.

@ploegert - Thank you for the correction. I'm updating the article per your feedback today.


MONDO:0011727 anorexia nervosa, susceptibility to, 1[Revise subclass]

Mondo term (ID and Label)
MONDO:0011727 anorexia nervosa, susceptibility to, 1
Suggested revision and reasons
Make a child of MONDO:0005351 anorexia nervosa instead of an "orphaned" child of Mendelian disease (MONDO:0003847)
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here

I added a logical definition so this is now classified as an 'inherited disease susceptibility'