add submodule SR2ML: raven plugin

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
close #1172
What are the significant changes in functionality due to this change request?
A new RAVEN plugin focuses on: system reliability and risk analysis.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

All jobs on e4f988f : invalidated by @wangcj05

All jobs on e4f988f : invalidated by @wangcj05

Job Test CentOS 8 on e4f988f : invalidated by @wangcj05
BUILD_ROOT/: git clone git@github.com:idaholab/raven Cloning into 'raven'... Host key verification failed.

Job Test CentOS 8 on 7158129 : invalidated by @wangcj05

Job Test mac on 951825c : invalidated by @wangcj05
add Derek account for Mac test

Job Test mac on 951825c : invalidated by @wangcj05

Job Test mac on 951825c : invalidated by @alfoa

Job Test mac on 951825c : invalidated by @alfoa

Job Mingw Test on 951825c : invalidated by @alfoa

Job Precheck on dd0b139 : invalidated by @wangcj05

Job Precheck on dd0b139 : invalidated by @wangcj05

Job Test Fedora 28 on dd0b139 : invalidated by @wangcj05
GitLab: API is not accessible fatal: Could not read from remote repository.

All jobs on dd0b139 : invalidated by @wangcj05
fetch issue

@alfoa Ready for you to review.

Strange, on windows, the Cashflow test doesn't run.

Checklist passed...
PR is approved


final analysis blog edits

[x] update copy
[ ] make axes darker (if possible)
[ ] move extracted skills image not next to each other so the image is larger and font is bigger

fyi @lizgzil based on sanjiv's comments

@india-kerle I like the extracted skills side by side - think it makes it clear!
Not sure how possible it is - but a way to make the text bigger would be to take the screen grab when you've narrowed the window a bit?, so the image isn't as wide but is longer.
I don't have the text from the job advert you put in, so can't do it - do you still have it?

argh I don't! But the GIF needs updating anyways so i'll just find a new software engineer role and save that copy


Update all dependencies + dependabot.yml configuration + node16

Fix #268, #264, #265, #263, #250, #249, and supersede most of the incomplete PR already open.
(Verified to be working, could be tested at<EMAIL_ADDRESS>

Should this be updated to node16 as well? https://github.com/softprops/action-gh-release/blob/cd28b0f5ee8571b76cfdaa62a30d51d752317477/action.yml#L61

@koplo199  thank you for all the hard work on this. merged


Fields: country select

Like this one https://github.com/stefanpenner/country_select
With predefined set of countries. Maybe names/iso codes/translations/phone number codes etc

I tried to find this as an ant.design example to share.
The thing is, primeCMS itself has a country/select/flag implementation which you can check out for language creation.
https://github.com/birkir/prime/blob/cf36a5f6e0aba7602fdf1437e6421f480b453978/packages/prime-ui/src/routes/settings/Locales.tsx#L174

I guess this is not a high priority thing


Update deprecated command for Heroku addons

Was previously getting this warning when running the setup_heroku script: WARNING: heroku addons:add has been deprecated. Please use heroku addons:create instead. This commit removes the warning.

Coverage remained the same at 99.36% when pulling dfce53936d1fecc72cb5eec7745d5a1a081a24ca on roughani:master into a75d2cd33fdb60fdd1fab6794b5193ff0a27b1a1 on codeforamerica:master.

Thanks!


Bug_Accordion> Expand Collapse All> Control prop 'iconPosition'> icon position is not getting changed

Describe the bug
Arrow icons does not get changed upon selecting the 'right', 'left' and 'none' options.
To Reproduce
Steps to reproduce the behavior:

Go to 'https://storybook-preview-290--upbeat-sinoussi-f675aa.netlify.app/?path=/story/accordion--expand-collapse-all'
Click on 'Controls'
Select the iconPosition
Verify that icon position is not getting changed accordingly

Expected behavior
icon position should get changed upon selecting the 'right', 'left' and 'none' options.
Screenshots
https://somup.com/c3no6kTVsc
Desktop:

OS: [Win 10]
Browser [chrome]
Version [Version 98.0.4758.82 (Official Build) (64-bit)]

The issue is fixed.
See Screen-cast : https://www.screenpresso.com/=9F0cf
Hence, Closing the ticket.
Thanks!


[FEATURE]: Support logs from Kubernetes audit logs

Is your feature request related to a problem?
Support security event logs from Kubernetes audit logs
https://opensearch.slack.com/archives/C051Y637FKK/p1680689503576889
What solution would you like?
Support security event logs from Kubernetes audit logs
What alternatives have you considered?
N/A - Additional log source support
https://kubernetes.io/docs/tasks/debug/debug-cluster/audit/#audit-backends
Do you have any additional context?
Add any other context or screenshots about the feature request here.
https://falco.org/docs/event-sources/kubernetes-audit/

Adding to 2.8 backlog

@praveensameneni Do we still want to work on this?


Proposal: Completely remove series after deleting and cleaning (delete in-mem metadata)

Proposal
Completely remove time series including information about respective labels, label values etc. after using /api/v1/admin/tsdb/delete_series and /api/v1/admin/tsdb/clean_tombstones instead of still returning information about removed time series for example in calls to /api/v1/label.
Use case. Why is this important?
Currently deleted time series still show up (indefinitely) in various web UIs that show all available metrics. Even after cleaning the tombstones. This is for example the case in Grafana and the Prometheus web UI, since they all use the /api/v1/label to retrieve all __name__ values. And the responses of this endpoint contain names of metrics that have been deleted.

This can get a bit annoying especially if someone has made a mistake in the naming of a metric or simply wants to get rid off old metrics that are not used anymore. But this is not possible and so these non-existant metrics continue to pollute the namespace and might irritate users that work with Prometheus and are left wondering why certain metrics are shown but contain no data points.

Thank you for your issue. I think it is a duplicate, I will try to find the original issue and link it here.

We have looked at this during our bug scrub, can you please verify that you are no longer ingesting those labels?
Also, if the data is still in head (ingested in the last 2-3 hours), you will still see the labels. Can you please confirm that it's not the case?

I will try it out in a reproducible setup once I get to it in the next few days and than come back to you / this issue

@roidelapluie We're seeing the same behaviour. I deleted the series but it still pops up in the suggestion box.

I was just on a consulting call with a customer who got the same issue - no samples anymore for deleted series, but /api/v1/series still returned the deleted series.

I was just on a consulting call with a customer who got the same issue - no samples anymore for deleted series, but /api/v1/series still returned the deleted series.

Same question as in september. Were those samples ingested very recently?

Same question as in september. Were those samples ingested very recently?

This is a good point, since it wasn't that many series (IIRC) it may well have been just ones from the most recent hours, not sure.

This is a good point, since it wasn't that many series (IIRC) it may well have been just ones from the most recent hours, not sure.

If the data delete was only on blocks, that is a bug. In the head, this is a known behaviour. Not to say it is not a bug but there might be technical reasons behind it.

If the data delete was only on blocks, that is a bug. In the head, this is a known behaviour. Not to say it is not a bug but there might be technical reasons behind it.

Not to say it is not a bug but there might be technical reasons behind it.

This is something that has changed over time, and may change back and forward again. It boils down to performance, and deleted series being returned is not a priority when considering ingestion/querying speed. So sometime the implementation happens to be synchronous, sometimes it isn't.

Not to say it is not a bug but there might be technical reasons behind it.

This is something that has changed over time, and may change back and forward again. It boils down to performance, and deleted series being returned is not a priority when considering ingestion/querying speed. So sometime the implementation happens to be synchronous, sometimes it isn't.

Yeah, I'm starting to recall past discussions about this. Then we should mention this at https://prometheus.io/docs/prometheus/latest/querying/api/#delete-series because while this behavior may be a reasonable tradeoff, it's definitely not what someone would expect when reading the API docs.

Yeah, I'm starting to recall past discussions about this. Then we should mention this at https://prometheus.io/docs/prometheus/latest/querying/api/#delete-series because while this behavior may be a reasonable tradeoff, it's definitely not what someone would expect when reading the API docs.

In our case we were trying to remove metrics from machines we no longer care about, which happens a lot since we encode video on behalf of our customers with unpredictable loads. So we scale up & down many machines. We care about the active ones, but do not about the ones that have been scaled down. When removing metrics for these machines, it seemed to have no effect as the next runs of the script that handles comparing EC2 state against Prometheus metric instances, the metrics for the same machines where targeted for deletion over and over. This puzzled me because the Prometheus API did report it successfully deleted them (✅ Success. body='', ok='true', status='204', statusText='No Content').
I think your explanation makes sense Brian, I just double checked to confirm that the machines that keep being targeted are machines that were fairly recently scaled down. Just with my lack of familiarity with the Prometheus internals I don't think I could have figured this out without Julius pointing me to this thread. Googling mostly lead me to users suggesting that I needed to properly escape the instance name, or have Prometheus clean_tombstones after I deleted them.

In our case we were trying to remove metrics from machines we no longer care about, which happens a lot since we encode video on behalf of our customers with unpredictable loads. So we scale up & down many machines. We care about the active ones, but do not about the ones that have been scaled down. When removing metrics for these machines, it seemed to have no effect as the next runs of the script that handles comparing EC2 state against Prometheus metric instances, the metrics for the same machines where targeted for deletion over and over. This puzzled me because the Prometheus API did report it successfully deleted them (✅ Success. body='', ok='true', status='204', statusText='No Content').
I think your explanation makes sense Brian, I just double checked to confirm that the machines that keep being targeted are machines that were fairly recently scaled down. Just with my lack of familiarity with the Prometheus internals I don't think I could have figured this out without Julius pointing me to this thread. Googling mostly lead me to users suggesting that I needed to properly escape the instance name, or have Prometheus clean_tombstones after I deleted them.

The deletion is of the samples, not of the series. And clean tombstones is only guaranteed to affect blocks, not the head.

it seemed to have no effect as the next runs of the script that handles comparing EC2 state against Prometheus metric instances

It sounds like you're using the wrong APIs. You should be using the query APIs, not the label ones, to determine state at a given time. The label APIs can return false positives for a number of reasons, and that will always be the case.

The deletion is of the samples, not of the series. And clean tombstones is only guaranteed to affect blocks, not the head.

it seemed to have no effect as the next runs of the script that handles comparing EC2 state against Prometheus metric instances

It sounds like you're using the wrong APIs. You should be using the query APIs, not the label ones, to determine state at a given time. The label APIs can return false positives for a number of reasons, and that will always be the case.

@brian-brazil Regarding "You're using the wrong APIs" - When nothing in our documentation makes that clear (and rather suggests the opposite), that's on us. I'll send a PR to clarify the docs.

@brian-brazil Regarding "You're using the wrong APIs" - When nothing in our documentation makes that clear (and rather suggests the opposite), that's on us. I'll send a PR to clarify the docs.

https://github.com/prometheus/prometheus/pull/8376

https://github.com/prometheus/prometheus/pull/8376

FWIW I was facing the same issue (with old job names showing up) but after deleting all time series belonging to a certain job and cleaning the tombstones afterwards, the job label was removed automatically after a few hours (Prometheus version 2.38.0).

Hello from the Bug Scrub!
Sounds like after the documentation change, this behaviour should be explicit (and is intended for now) -- essentially Metadata stored in head (in-memory) stays and will be eventually forgotten (few hours).
Sounds like for autocompletion, the consensus is that this behaviour is good enough. Might be not trivial to implement and the benefit is small. We are open for suggestions around different issues around this behaviour with metadata -- we can reopen or you can created a new issue 🤗


Pages under apphook causes 404

Summary
Create a page with an app-hook and some pages under that page with app hook. Sometimes it causes 404. I discovered this problems: sometimes in doesn't work at all (all the time error 404), sometimes it doesn't work only when I'm in published mode and go into edit mode (only during the action, when I'm already in edit mode, it works), sometimes it works just fine. I'm not able to reproduce it the same way all the time.
Restart of the server doesn't help. Once helped to change slug of the page with app-hook and then change it back to original one. Once helped to move page with app-hook somewhere else but putting it back caused that problem again.
Environment

Python version: 3.5.2
Django version: 1.11.6
django CMS version: 3.4.5

It doesn't work even in Django CMS version 3.5.0

Hello,
Thanks for reporting this.
Pages under apphooked pages have never been truly supported.
I think this mostly falls under a documentation issue.

Maybe in that case it shouldn't be allowed at all (not just write in the docs, but disable to create page under app hook) or consider to support it.

@horejsek  It's not a good idea to disable pages under apphooks. There are valid cases and depending on your apphook urls the pages can work without problems.
Also depending on the logic in your app hook views you can render child pages without problem. We used this technique even on Django CMS 2.x days (if I'm not mistaken).

@vstoykov I agree with you. But if there is problem and it's not supported for now without plan to support it, it's good to disable it for now because users can use it without knowing those problems.

Actually in my point of view the problem is in the implementation of the specific apphook and not the CMS. I need to check how it works in latest version to see if there are some changes for which I'm not aware of.
The support from the CMS will come with documentation explaining how you can have subpages to a page with apphook.
If you can show me your app urls.py file and the structure of pages with exact slugs (only the page with the apphook and it's children) then I can tell you where is your problem. and eventually how to fix it.

URLs:

/ - homepage
/app - page with an app hook
/app/subpage - manual page created by user

And the app hook have:
urlpatterns = [
    url(r'^$', views.index, name='index'),
    url(r'^view/$', views.view, name='view'),
    url(r'^view2/$', views.view2, name='view2'),
    ...
]

I think that your URLs are actually:

/
/app/
/app/subpage/

Ends with slash (/) right?
If the structure is this and the URLs are exactly these, then it should work (there is no conflict between page slug subpage/ and some regex which will match it).
But you are showing structure and URLs which are not the same as these that are giving you problems. When you show me the real structure and real urls.py that are causing you a problem then I can help you. Until then.... sorry I can't help you.

The URLs are those created by CMS, so Django will add last slash but it's not in the database.
Yes, structure and urlpatterns of app hook have no conflict.
It's random as I described in the description. Sometimes it works, sometimes not, where not can mean more situations. I haven't noticed any pattern yet.

I know that URLs are created by CMS and the slash is not in the DB. This is how Django CMS works.
You say that there is no conflict between structure of the pages and the urlpatterns but until you show us the actual structure and your urlpatterns and on which page(s) it happens I will be 100% sure that there is a conflict which you are missing.

We have two apps. One has this urlpatterns:
urlpatterns = [
    url(r'^$', views.index),
    url(r'^providers/$', views.providers),
    url(r'^providers/compare/$', views.compare_providers),
    url(r'^provider/(?P<provider_id>[0-9]+)/$', views.provider),
    url(r'^provider/(?P<provider_id>[0-9]+)/edit/$', views.edit_provider),
    url(r'^provider/(?P<provider_id>[0-9]+)/networks/$', views.provider_networks),
    url(r'^provider/(?P<provider_id>[0-9]+)/participants/$', views.provider_participants),
    url(r'^provider/(?P<provider_id>[0-9]+)/users/$', views.provider_users),
    url(r'^participants/$', views.participants),
    url(r'^participant/(?P<participant_id>[0-9]+)/$', views.participant),
    url(r'^participant/(?P<participant_id>[0-9]+)/providers/$', views.participant_providers),
    url(r'^organization/(?P<organization_id>[0-9]+)/$', views.organization),
    url(r'^organization/(?P<organization_id>[0-9]+)/providers/$', views.organization_providers),
]

Which was registered and under page with this app user created page with a slug founding. There shouldn't be any collision.
And also we have another app with the following urlpatterns:
urlpatterns = [
    url(r'^$', views.events),
    url(r'^(?P<event_slug>[\w-]+)/$', views.event),
    url(r'^(?P<event_slug>[\w-]+)/register/$', views.event_registration),
    url(r'^(?P<event_slug>[\w-]+)/submit-proposal/$', views.proposal),
    url(r'^(?P<event_slug>[\w-]+)/proposal/(?P<proposal_id>[0-9]+)/$', views.proposal),
    url(r'^(?P<event_slug>[\w-]+)/proposal/(?P<proposal_id>[0-9]+)/voting$', views.proposal_voting),
    url(r'^(?P<event_slug>[\w-]+)/programme/block/$', views.programme_block),
    url(r'^(?P<event_slug>[\w-]+)/programme/block/(?P<block_id>[0-9]+)/$', views.programme_block),
    url(r'^(?P<event_slug>[\w-]+)/presentation/(?P<presentation_id>[0-9]+)/attachments$', views.presentation_attachments),
    url(r'^(?P<event_slug>[\w-]+)/presentation/(?P<presentation_id>[0-9]+)/detail', views.presentation_detail),
    url(r'^(?P<simple_event_id>[0-9]+)/export', views.simple_event_export_to_ics),
    url(r'^(?P<event_slug>[\w-]+)/export', views.event_export_to_ics),
]

Where I can see possible conflict with user page with a slug code-conduct because of the second URL. Anyway I wouldn't expect it sometimes works and sometimes not as I described and it had the same problem with both apps.

Ok now to define what you mean by "not working". The page with slug founding sometimes shows correctly and sometimes return 404 or render some other page?
The same question for the code-conduct page?
If you say that adding pages under first app always work as expected and pages under the second app sometimes work (if there are numbers, underscores, or some nonascii characters, or are not direct children of the page with the attached app) and sometimes does not (render views.event or return 404 because there is no event with the given slug), then the problem is in the second app and is very normal behavior considering how Django URLs work.
Also you have URLs which can collide grand children of the second app if their slug start with export because your regex is too greedy (last two). And one more URL which is also too greedy (views.presentation_detail), but is very unlikely (IMHO) for your client to create such a page.
If you want to have CMS pages at the level of event pages then you have two options:

Modify the regex a little bit to add some prefix/suffix to the event slug in order to not conflict with CMS pages. Can be very ugly and there is a chance to not be liked by the client.
Make your views.event view smart and if there is no event with given slug to try to use cms.views.details to render the page. This is more complicated but will make your app to play nicely with the CMS.

We probably don't understand each other. The same problem we had with both apps, not just with that second one which can have problem with a conflict. Even in first app where is not page starting /founding, it had problem. Problems are random, can exactly say what it does. I described in the description already:

(...) sometimes in doesn't work at all (all the time error 404), sometimes it doesn't work only when I'm in published mode and go into edit mode (only during the action, when I'm already in edit mode, it works), sometimes it works just fine. I'm not able to reproduce it the same way all the time.

I don't need pages at the event level so we don't have to deal with that. Let's focus on the first app, where is clearly no greedy URL (at least from the beginning of URL) and we created on root of the app hook level another page with a slug funding which did the problems mentioned. Interestingly it behaved differently after restart, sometimes not.

Ok this will happen only on production or it happens during development?
You said that it behaved differently after restart. By behaving differently you mean that it starts working or it start breaking? In the past it was necessary to restart the server after publishing a page with app hook. I think that in latest version of Django CMS they tried to remove the need of restart by magically reloading the URLs but I'm not sure how well this works.
Also I see that you linked #6307. Are these problematic pages descendants of the Root node?
I'm not sure also what is your knowledge about how Django CMS handle URLs of apphooks under the hood. It will be very helpful if you can investigate what is the problem in your case to see if Django CMS is doing something strange which can be fixed (I know that you said that it is random, but probably there is logical explanation).
@czpython said that pages under apphooks was never truly supported which does not mean "unsupported". In the past we have problem with apphook inside another apphook (yeah definitely  not everyday problem) and there was also problem with that sometimes it worked sometimes it not. But I found where the problem was and proposed a solution which they accepted (#4121).
What I want to say is that this the functionality to have children under pages with attached application is not advertised but this does not mean that it's not there. If you can find the problem and probably suggest solution or at least clear steps to reproduce it, then it will be fixed for your case.
And again about your problem. Try to reproduce it in dev environment (copy the production DB if needed to your machine). When you see 404 with DEBUG=True you will see at least which is the view that is returning 404 and probably for what reason.

Going to respond to your paragraphs:

Both, development and production.
By differently I mean as I described all weird states, that after restart it sometimes change the state. For example I add page under app hook and then it shows 404, after restart it may work but it will show 404 during switching of edit/published mode.
The problem is only with pages under app hook.
Definitely there will be some logical explanation, but I don't know where to look or what to debug as it's changing the way how it react. It's hard then to debug something in case when I know almost nothing about Django CMS internals. That's why I created this issue as probably someone with knowledge maybe can have idea in few seconds than me debuging days. For us was simpler to just say to our users to not use it, at least for now.

@horejsek did you manage to try what I described in my last paragraph?

And again about your problem. Try to reproduce it in dev environment (copy the production DB if needed to your machine). When you see 404 with DEBUG=True you will see at least which is the view that is returning 404 and probably for what reason.

The important thing is to see Django's 404 error page during DEBUG=True.  Did you see
Raised by: cms.views.details

or the value of Raised by is something different?
If it is cms.views.details then the issue is in the CMS and you can install DjangoCMS from source in your environment and start messing with this view to inspect when this is happening. This is the way you can learn how DjangoCMS is resolving an URL to a page. After this experience you will know more about Django CMS internals ;)

As I said, it's random which makes it very hard. We don't have time capacity to learn what is happening in details so we asked our users to not use this feature. If we did, I would even post pull request. So I at least notified Django CMS team about this problem so it can be fixed for other users or at least blocked totally if it's not supported. Both solutions works for me.

We are discussing / planning to change the core apphook logic for 3.6, one of the features discussed is to officially support pages under apphooks. In the meantime, we've updated the docs to warn against this https://github.com/divio/django-cms/pull/6318.


Dismissing more than one feature

Description
When I have migrated to 1.9 version from 1.3 and started to use @ObservableState, @Presents, observe {}(I use UIKit for UI) and all what you recommend. All is good and thank you for your effort to improve TCA.
But now I have one problem with dismiss dependency. I didn't have this problem when I used 1.3 version. The problem is when I execute dismiss() from dismiss dependency at my child feature, not only my child feature set nil, but the parent feature too. The parent feature is added to main reducer by Scope(state:action:) and child feature by .ifLet(state: .$destination, action: .destination)
Yes, I have tried to use just callback effects from child features, detect them in parent reducer and set destination nil and it works well. But I want to use more simple way and exactly want to understand why this bug reproduce
Checklist

[ ] I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
[X] If possible, I've reproduced the issue using the main branch of this package.
[X] This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior
After dismiss() set nil for only one(child) feature
Actual behavior
After dismiss() set nil for two(parent and child) features
Steps to reproduce
I can't share all my project, because it's not mine and I don't have this opportunity, but I can share with you some logs and results
I will share with you two variants of my app. And this variants have only one difference

With bug. I have this sending line on View that is connected with child feature

No bug. I commented this sending line

This action "test" isn't detected on any reducers, so it can't influence for something

test1.txt

test2.txt
You can also pay your attention to logs like this "<decode: bad range for [%@] got [offs:346 len:932 within:0]>". I'm sure that this error log is connected with the problem
The Composable Architecture version information
1.9.0
Destination operating system
iOS 17.3
Xcode version information
15.2
Swift Compiler version information
swift-driver version: 1.87.3 Apple Swift version 5.9.2 (swiftlang-<IP_ADDRESS>.56 clang-15<IP_ADDRESS>.5)
Target: x86_64-apple-macosx14.0

Hi @nmalevich, can you please provide a project that demonstrates the behavior you are seeing? I don't think this is an issue with the library so I am going to convert this to a discussion for now. We can re-open an issue if it turns out to be something wrong with TCA.


⚠ API (search) has degraded performance

In 09043ca, API (search) (https://api.dev.package-search.services.jetbrains.com/search-packages) experienced degraded performance:

HTTP code: 200
Response time: 7104 ms

Resolved: API (search) performance has improved in 1780b2d after 29 minutes.


[Feature] How can i change indicator ma lines color ?

Feature Description
i want to change ma indicator lines color by override indicator
To Do
how should i do that

pls call overrideIndicator api, and change the 'styles' property.


[AndroidTV, fireTV] When holding 'down' button in Carousels screen focus jumps on @flexn/template

rnv version: 0.36.2-canary.4
flexn template version: 0.17.0
How to repro:

Navigate to Carousel screen
Hold 'down' button on remote or in keyboard
Screen scrolls down a bit and then jumps to the top

https://user-images.githubusercontent.com/65670660/189882268-2f18d4da-414a-44d4-a9de-8937dde766b5.mov
Expected: Scrolling is smooth without any jumping

not reproduced on v 0.21.3-rc.4


Replace Null Output Stream with commons io package

run starrocks_fe_unittest

starrocks_fe_unittest

starrocks_fe_unittest need trigger manually?

starrocks_fe_unittest need trigger manually?

Tests will run automatically. If some case failed, you can trigger it by the command.


ci: use reusable workflow for semgrep

Updated the build-test-release workflow to use sast-scan owned by product security team instead of using custom implementation.
Ref: https://splunk.atlassian.net/browse/ADDON-72309

Thank you!


add error handling if users assign wrong oneapi path

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[ X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ X] Command Line

Checklist for Moving samples:
Links and Details can be found in the samples WG Teams Files.

Can you provide more detail as to what this is about in the description


[stable/openvpn] How to revoke a certificate

This could be added as helper script in the chart. At the moment is up to the user to figure out a proper way to revoke a certificate.
N.B. I am still working on a solution myself. Will post here.

@kilianc have you found out how to do it?

I have a PR open which solves this:  https://github.com/helm/charts/pull/6841

@jmastr I wish. I tried a couple of approaches but it didn't work out. I will try again using the scripts in #6841

@MikeSchuette how can I help? Who did you ping? I can give it a try


social analytics?

Hi,
how integrate social analytics with your module? facebook, G+ login, sign up? facebook share? or  social interactions will be automatically reported?
regards
Stevens

This module focus on google analytics only so you have to trigger GA tracks for every single action you want to track, social or not :)


Creating Portal for documentation

We need a documentation portal to showcase all the component and how to use them.
Team please put your thoughts here so we can discuss.

ngx-markdown is good option we will be using the same.


add support for custom figure props

Support custom figure props, this is needed to be able to use this for fbia - so that data-feedback="fb:likes,fb:comments" can be added (for example).
R = @iefserge
T = minor

Looks good :tada:


add a merge option that will merge properties/keys in each file/module

finally getting around to addition this option per issue #38 I made awhile back.
Wrote a good coverage test for it.  Shouldn't be any issues.  See the end of test.js
Also added a section to readme.  It's good to go.
BTW there is no documentation the in readme for for the 'resolve' option is that intentional?

hmm... doesn't pass for 0.6 and 0.8.  Does my test need to be wrapped in that semver if?

added the if around test for > 0.8  no love.  Maybe you know how to fix this.  Outta ideas.

ok it passed albeit not for 0.6 and 0.8 (would anyone be using 5yo node with new tags?).  Willing to merge it??

Sorry I have not been able to look yet. Node.js 0.6 and 0.8 support is required to merge, to answer your most recent question.

you already have at least one feature that doesn't support 0.6
//
// requiring json only became an option in 0.6+
//
if (semver.gt(process.version, 'v0.6.0')) {
  var mydir = requireAll({
    dirname: __dirname + '/mydir'
});

readme could just indicate that it's not available in 0.6 and 0.8.  It's an option after all and those releases are now 5+ years old, most using such pre io.js merge would be using .10 anyway.
That said I will just publish my fork on npm since I want this option, am using 7+ and have no intention of supporting anything less than 4 at this point and will use it in many of my projects.  So thx for your efforts.

This module is called "require all", as in it will require() all modules. If the Node.js you're using cannot require() a module, then this will not either--it leaves that up to Node.js. Prior to 0.6 .json couldn't be directly required.
I can drop older support as soon as at least the modules I have published that use this module also don't need that support. The biggest module is the mysql module, which being such a basic driver module end sup with people using it in environments where they cannot choose the Node.js version. As far as I'm concerned, if it's easy to support, there is no reason to drop it.
I believe the issue with your PR here is that you added the assert module to the devDependencies, which you need to simply remove--assert is a module that is part of Node.js core just like net, http, and similar modules.

k,  making changes to see if it will pass all.  I run it on my travis-cl account first.

Ok, had a let in there too.  Changed to var.  Now it passes even 0.6 and 0.8 :-).

whoops, need to take out that commented alternative....another push coming

I made changes per all your requests except the one about adding the map function when merging the keys will I left as is for the reasons I explained.  So is there something else that needs attention or is otherwise an issue?

I'll take a look over the weekend and let you know.

Been awhile but I think I addressed all your requests save one which I explained.    The project I've been working on is going into production and I'll need to publish this.  I'd hate to publish a fork when this PR could just be included in node-require-all

Ok I rebased with your last 4 commits.   It passes and has no conflicts.   If you know longer have an objection to the map function I added (my reasons explained above) then all the rest of the requests had been covered.    Since I haven't heard from you for ten days I am going to publish node-requireall-merge.  But if/when you accept this PR I will unpublish it.

Sorry I didn't reply; I didn't see your reply until you @ed me 3 days ago, then looked at the PR and saw it had a conflict and then told myself I would look at it when I got to a computer. I then have been having a rough week and forgot about, so I'm really sorry. Thanks for resolving the conflict, though, that makes this much easier. When I am back on a computer in ~6 hours I'll take a look and release a new version.
Looking at the diff on my phone, I'm not sure if it's my phone or the commits, but the example doesn't seem to be intended for some reason in the readme, and it looks like you put a newline in the docs, but I don't think that will format as a new paragraph unless you have an empty line between them.
I know the docs for this module suck a bit, but I've been re-reading the added docs, and I still don't fully understand how the merge is supposed to work from the docs, so I'm not sure how other users will as well. Going back, the SO post does a better job explaining it, is there anything you can take from that? I'll also try to write up some docs as well tonight when I can to help out landing this :)
P.S. of course feel free to publish a fork if you like; usually I publish forks simply under my own name like @dougwilson/require-all instead of in the global namespace, but to each their own, I suppose..

Yea I already published under my scope so I'm good for now.
Really all this feature does is give one the option to organize modules in different files in a directory but then have them all be as though they were in one big file.
require-all  as is creates a subkey using the filename of each file and the modules therein are keys under that filename subkey.  This option just "merges" all the keys together as though all the code was in one large file with one export statement.
Of note there is NO duplicate key checking during that merge process so user is responsible for avoiding such.
As a use case I have a library of utility functions that are organized in a folder of files.  Each file is a  contains a related set of functions.   But when one requires these they should be as one.  It's kinda like underscore.  They might organize all their utilities in separate source files but when you require it they are all merged into one kitchen sink all that the same "level"

@dougwilson What is missing at this point? I would like to lend help to push this over the finish line :)

@dougwilson Ping?.. Is there anything I could do to get this PR to mergeable state?


fix(platform): add new Edge tag.

Hey, thanks for this PR. What would be the use case for detecting the Chromium/Blink-based version of Edge? I think in the current implementation of Platform we always had detection for browsers/rendering engines which could require special treatment/behave differently.

The platform codes use brand name as Tag, so that I though you maybe miss the newly Edge's tag when I audited the code.

I maybe can close it, if you don't need to specify the brand of browser.

I think we'll probably leave this as-is for now and potentially revisit if we encounter issues that are exclusive to Chromium-based Edge.


[WIP] Adds a way to create windows and events pools from a subset of their raw parts.

Adds a way to create windows and events pools from a subset of their raw parts.
A new API which allows us to make windows and events pools from a subset of their raw parts. Should be useful when interfacing with C libraries.
~Currently the raw parts we require just so happen to match the ones we receive from gfx-rs/portability in its Vk*SurfaceCreateInfo structs, as my use case for this api will be constructing Windows and EventsPools from that data (and that will just make my life easier :D).~ We now also require the dims of the surface for the wayland backend.
I currently only plan to implement this functionality on linux and windows. Currently untested.
Implemented:

[x] Linux - X11
[x] Linux - Wayland
[x] Windows

Tested:

[x] Linux - X11
[ ] Linux - Wayland
[ ] Windows

Signed-off-by: Hal Gentz<EMAIL_ADDRESS>
[ ] Tested on all platforms changed
[ ] Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
[x] Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
[x] Created an example program if it would help users understand this functionality

From a quick glance on your wayland code, it appears that you made the code behave such that a window made from raw parts is known by winit to be external, and many (most?) actions on it are not possible.
Could you detail the example you have in mind regarding why one would create a window from raw parts, and what they would do this it?
This is especially relevant regarding resizing. It appears from your code that you assume winit won't handle the resizing of the surface, though on wayland the dimensions of a surface is defined by the dimensions of the buffer you attach to it, so it's not really possible to have some other part handle the resizing without some integration.

Hi @vberger, thanks for your interest.
Yes. Most functionality would be unavailable. The goal in mind is to make a openGL context on the raw parts of a window which gfx-hal receives from vulkan applications. An example of this is here  (nonfunctional) and here (functional).
Alternatively, I could've just added another set of functions to glutin which took the raw parts instead of a winit window, however, I figured a new_from_raw_parts function might be more useful.
I sadly haven't looked into how resizing would work on Wayland, yet.

I've came to the conclusion that it works on X11, which is good enough for my intended use I guess. I don't intend to have this get merged in, as it doesn't work on Wayland, never mind other platforms.

Since there don't seem to be any intentions to get this into a mergeable state, I'm going to close this.


[skip ci] Docs: Add Bot Interactions section

Signed-off-by: Chris Evich<EMAIL_ADDRESS>

/joke

/hold

/unhold

/meow

/lint

/unhold

/lgtm

It was merged without documenting /meow? :^)


Remove Moveit2 example

The example is not working any more, fixing #217.
Please also backport to humble.

@mergifyio backport humble

https://github.com/Mergifyio backport humble


Refactor TestLinearOperator

This PR refactors TestLinearOperator to check compatibility the behavior of cupyx.scipy and scipy.

pfnCI, test this please.

Jenkins CI test (for commit 228fe1a348a3c8db553a86cd261a9d7981d12647, target branch master) succeeded!


RuntimeError: CUDA error: invalid argument

File "/home/user/segmentation/mmseg_custom/models/backbones/base/vrwkv.py", line 64, in backward
    gw = torch.sum(gw, dim=0)
RuntimeError: CUDA error: invalid argument
Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.

I am meeting this problem when trying to use your model on different datasets. Any idea why this might occur?

File "/home/user/segmentation/mmseg_custom/models/backbones/base/vrwkv.py", line 64, in backward
    gw = torch.sum(gw, dim=0)
RuntimeError: CUDA error: invalid argument
Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.

I am meeting this problem when trying to use your model on different datasets. Any idea why this might occur?

I haven't seen this error before, but some Cuda errors may occur when out of memory.  Maybe you can try to reduce the batch size.


Add support for real-time communication

Current polling model work nicely most of the cases. However, if more accurate data is needed, the approach no longer. Thus, it should be possible for client to communicate with the client whenever needed.
Example scenario: Server side client creates a WebSocket or MQTT connection to data source. Whenever a message is received, client communicates it to all the interested widgets.
@plouc: I'm sure you have an idea how to implement this without affecting too much on the API.

This is also related to #4: Once the interval can be defined per backend API, it can be decreased for specific data sources. However, it remains to see how the service will work if interval is only, say 1 second?

I think it could be saner to let the backend stream its data to the component, perhaps introducing a subscription type poll or stream|pipe without breaking the current api (poll should be default if none given). I'll try to test this approach.

Sounds good to me. Thanks.

Any progress with this?

any news ?

@juhamust, @cybernet done! available in<EMAIL_ADDRESS>see https://github.com/plouc/mozaik/pull/76, for now, there's no proper documentation on how to use the feature, I must update http://mozaik.rocks/ accordingly, but I have made a simple gist to explain how to use it https://gist.github.com/plouc/5fc5d80aa74e4a6c3196a265602c509c.
And of course, if you have any feedback/issue with it, just let me know!


docs: Prompt with messages

:tada: This PR is included in version 1.9.8 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


:book: Clarify that AI/ML doesn't count as human code review

Add this clarification per the Scorecards Zoom call meeting today (2023-05-04).
What kind of change does this PR introduce?
Docs update, to clarify code-review scope.

question, does checks.yaml have to be changed too? i don't want these changes to get overwritten next time the checks.md gets generated from the yaml

question, does checks.yaml have to be changed too? i don't want these changes to get overwritten next time the checks.md gets generated from the yaml

YES, thank you for catching this! @david-a-wheeler can you revert the checks.md changes and make them in checks.yaml instead? That's my mistake for not catching it the first time, I'm sorry!

Whups! Will fix.
In the future maybe that should be a workflow check (regenerate files, ensure that nothing changed). But that's a different issue.

See new PR that modifies the .yml file: https://github.com/ossf/scorecard/pull/3012

Whups! Will fix.
In the future maybe that should be a workflow check (regenerate files, ensure that nothing changed). But that's a different issue.

That'd be great -- I generally keep an eye out and catch quite a few PRs that edit the wrong file, but apparently I miss some too. :)


Update sensor.py

Added sensor state class of "measurement" to the Nest Protect temperature sensor definition, so that HA recognizes and collects min/mean/max statistical information for these sensors. Replacement pull request for iMicknl/ha-nest-protect#244 after re-syncing my fork. 😁

@iMicknl So as I mentioned in #244, I'm still learning Git/GitHub, and I'm not sure I actually did a proper "rebase", but hopefully this will work! Let me know if I need to do something different. 👍


feat: add env-configs:list command

Look at src/commands/app-credentials/list.ts for an example of how to transform nested data like we have with env-configs:list into a shape that is usable with the cli table.

Done with the review. Back to you.

:tada: This PR is included in version 2.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


symfony 5 support

I changed the necessary things to be able to run the library in symfony 5. Please publish this package.

Works for me.
Complains about 2 more items regarding the controllers.
The "Youshido\GraphQLBundle\Controller\GraphQLController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.
and
The "Youshido\GraphQLBundle\Controller\GraphQLExplorerController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.

You are right. Please fork my repo and create a pull request

Hello,
Nobody taking this pull request?
Regards.


including locks files in the repo

Some times tests are failing in my local repo which I use for development because of package version mismatch.
These problems can be solved by including lock files in the repo

Unfortunately, there are still no best practices for using lockfiles with Lerna. None of our other Lerna repos have lockfiles, so I'm going to leave it out for consistency.
Occasionally, you should run npm run bootstrap from the root to make sure your packages are up to date.


Let user decide which animation to use for displaying modal

Proposal: propTypes.animationType, optional prop that could be set to either none, fade, or slide, with slide as default (as today).

Perhaps even a different animation for the backdrop. A common pattern for iOS pickers is that the backdrop fades in and the picker slides in from the bottom

I like your idea for future development of this animation.


About PFC implementation and eval result

Thanks for the amazing work, authors.
I am trying to reproduce the result reported in the paper and have two questions.

What does the constant 10000 mean here in PFC's implementation? I can't map this to the formulation (10) in the paper.
https://github.com/Stanford-TML/EDGE/blob/17c3428669ed6733edd9d8c66f7dc62060b8e46d/eval/eval_pfc.py#L50

I find it hard to reproduce the PFC result 1.5363 in the paper. Do you only use the test dataset of AIST++ to compute PFC? and what do you mean here in README to Generate ~1k samples? There are only 20 data and will be 186 pieces after slice in the test dataset.

Has anyone successfully reproduced the results? 🤔

Has anyone figure it out? Need an expression about the meaning of "Generate ~1k samples" in README

@MingCongSu , hi, I also face this problem. And I run the test.py with two settings for data/test: use cache jukebox feats and use music wav directly. And I get two different pfc metrics, one is 1.5922 while the other one is 0.9621.

I assume that the generated results is not fixed ? So it leads to the dynamic results?

I don't think so. The pfc of GT (1.332) could be reproduced by "../test/motions_sliced", but when u used "../test/wavs_sliced" as input(ckpt download in github), pfc came to ~1.29, which is really confused.


Switch to camelized names for event keys

BEST code can easily get messy with lots of quotation marks used for selectors, events, etc. It'd be fantastic to switch to camelized names for event keys as it will significantly reduce the amount of quotation marks in behaviors and events section of code. Camel case is more consistent with idiomatic JavaScript too.
The only places I see that absolutely need dasherized strings wrapped with quotation marks are selectors, and we cannot really do much about it. However the rest can be changed for better developer experience.

This seems sensible to me. I don't think there was a very strong reason to adopt the dasherized convention - other than aesthetics and readability. (I personally think foo-bar-baz is prettier and easier to read than fooBarBaz.) However I think developer convenience and convention should outweigh this, so it might be worth changing our recommended conventions. Tentative :+1:


Forbidden to access camera roll

I always get an error 403 Forbidden when trying to access the camera roll through the API.
https://api.onedrive.com/v1.0/drive/special/cameraroll/children
I've tried with the following scopes:
wl.contacts_photos
wl.contacts_skydrive
wl.skydrive
wl.photos

The scopes between OneDrive and the LiveConnect APIs are different, you can see the full list under the authentication and scope section, https://dev.onedrive.com/auth/msa_oauth.htm
For your scenario where you want to read from the camera roll if you added the onedrive.readonly scope you will be able to access that folder, you shouldn't need the rest of the scopes (Saved for wl.signin & wl.offline_access which your application might be using)

I tried with onedrive.readonly as well
I used the following to authorize:
https://login.live.com/oauth20_authorize.srf?client_id=000000004412F032&scope=wl.offline_access onedrive.readonly&response_type=code&redirect_uri=https://login.live.com/oauth20_desktop.srf
I still get a 403 Forbidden.  I even tried subbing in the access token on the apigee console and it produces the 403 there.  It's very unclear which scope is required to access the Camera Roll.
The documentation for special folders doesn't indicate any special requires scopes  https://dev.onedrive.com/items/special_folders.htm

@ddurdle would you mind including the the full response headers so I can better understand what system is acting up as I'm unable to reproduce this problem locally.

Hopefully this helps:
HTTP/1.1 403 Forbidden
X-MSNSERVER:
DM2303____PAP184
Content-Length:
96
X-AsmVersion:
UNKNOWN; <IP_ADDRESS>
Connection:
keep-alive
Server:
Microsoft-HTTPAPI/2.0 Microsoft-HTTPAPI/2.0
X-QosStats:
{"ApiId":0,"ResultType":2,"SourcePropertyId":0,"TargetPropertyId":42}
Strict-Transport-Security:
max-age=31536000; includeSubDomains
Strict-Transport-Security:
max-age=31536000; includeSubDomains
Date:
Fri, 08 May 2015 19:14:42 GMT
X-ThrowSite:
022b.92e9
P3P:
CP="BUS CUR CONo FIN IVDo ONL OUR PHY SAMo TELo"
Via:
1.1 BY3301____PAP187 (wls-colorado)
Content-Type:
application/json
X-WLSPROXY:
BY3301____PAP187
{
"error":  {
"code": "accessDenied",
"message": "Access Denied",
"innererror":  {
"code": "accessDenied"
}
}
}

I also tried the other special folders -- documents, photos, music -- same 403 error.  I can access folders and files using drive/root or drive/items, but I cannot seem to access anything through drive/special

Aha! Thanks so much for that trace, I understand what is going wrong, we attempt to auto-create the app folders if they don't exist, and since you are using readonly permissions you don't have the rights to create them.  Thanks for finding this bug, we'll let you know when we get this resolved.
Until that time, you could work around this issue by adding the onedrive.readwrite scope.

Perfect, thx!  I can live with that workaround for now.
Great support and a great turnaround time.  Users will be happy.

when will this be resolved?

Have you tried using the onedrive.appfolder scope?  this provides access only to the specific app in question and no read/write access to other parts of a users OneDrive.  This should be working as expected currently.

Like the OP, I am trying to access the Camera Roll, not the app folder in OneDrive

Tipa, accessing Camera Roll will require using onedrive.readwrite, this is by design.  If there is another issue can you please update with that for us to look into it?

If this is by design - what is pretty strange as I do not need write access - I have no other issues, thanks!

To clarify, if you have read-only access to OneDrive and you try to access a special folder that doesn't exist (say, the user hasn't enabled camera roll backup) then you'll get an error that the folder doesn't exist. Today that is returned as a 403 Forbidden, and should instead be returned as a 404 Not Found (this is a bug). If the folder does already exist, read access is all you need to be able to consume the content of the folder.

Sorry,I'm having the same issue reported here and the only possibility to access special folders (documents, photos and cameraroll) is to get a token using onedrive.readwrite scope.

Hi @Joel95, the issue is when the camera roll folder doesn't already exist for the user. If it doesn't exist and you have the readonly scope, OneDrive returns 403. This is a bug. It should return 404. If it doesn't exist and you have the readwrite scope, it will auto-create the folder and return an empty folder. For now, your code can assume that 403 means the camera roll folder doesn't exist (and is empty).

Let me describe the test done.
1 - I do a get token using scope "onedrive.readonly onedrive.appfolder wl.photos wl.offline_access".
OneDrive return 403 on special/photos, special/documents, special/cameraroll.
2- I do a get token using scope "onedrive.readwrite onedrive.appfolder wl.photos wl.offline_access".
OneDrive return 200 Ok with all informations about special folders.
Second step shows that folders already exist and onedrive.readonly is no enough to get access...
I need onedrive.appfolder to be able to write in App folder.
I use wl.photos because I need access to photos only in other folders.
Now, I did a test with scope "onedrive.readonly wl.offline_access", same result...
I hope this help and you will find the root cause.
Regards

Hi @Joel95, we deployed a fix for the 403 error when a special folder doesn't exist. Can you try again? Also, the wl.photos scope is for the old LiveConnect API, and isn't used by the new OneDrive API, so you don't need to include it.

Hello Daspek,
I did the test and it works now.
I've a question about LiveConnect API but I'll open another case.
Thank you very much.

Reopening since we reverted the fix.

Seriously??? Now my app, which is live, will not work because I have the "onedrive.readonly" capability only? What will be the desired behaviour of the camera roll?

Same problem on my side.

@tipa, @Joel95, firstly we're really sorry about all this. We know how frustrating it is for a fix to stop working for a live app. Our fix for this was part of a larger change, and after turning it on we discovered that it broke something else and we had to turn it off. We're working to turn it back on as soon as we can.
To clarify, though, the only expected difference between the current behavior and the fix is the error code that it returns. Without the fix (right now), it returns 403 if the user does not have a camera roll. With the fix, it returns 404. If the user does have a camera roll, their data is returned and accessible.
So as long as your app treats 403 the same as 'no camera roll available' you should be okay. In the meantime, we're working to put the fix back as soon as we can.
Thanks for your patience.
daron

"If the user does have a camera roll, their data is returned and accessible." - this is all I need, thank you! :) :+1:

That wasn't actually the case before. There was some confusion. You need onedrive.readwrite to get a new cameraroll auto-created if there isn't one already. But if there already is one, you only need onedrive.readonly.

This issue of returning 404 is now resolved - thank you for your patience.


getting papers list doesn't work appropriately

I have tried querying
https://paperswithcode.com/api/v1/papers/?title=generative+adversarial+networks
and it returns entries sorted by the publishing date not by the most relevant orders.
I have also tried with different parameters q, and it didn't work either. Actually, title and q performs the same behaviour.
can you please check @alefnula ?

Fixed and released in 0.2.1 version of paperswithcode-client.


Replace gometalineter with golangci-lint

What this PR does / why we need it:
Makes linting a lot more faster, fixes some linting issue
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

/release-note-none

/release-note-none

/test pull-machine-controller-e2e

/lgtm
/approve


[Core] Add @runtime_checkable to TokenCredential protocol definitions

Description
See https://github.com/Azure/azure-sdk-for-python/issues/25175. With this PR, doing an isinstance check with an azure-identity credential and a TokenCredential protocol returns True -- that check errors today since these protocols aren't runtime checkable.
isinstance and issubclass checks aren't available without @runtime_checkable, but explicitly declaring the TokenCredential implementation (as shown below) could possibly satisfy static type checkers.
# from https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/identity/azure-identity/azure/identity/_internal/get_token_mixin.py
...
from azure.core.credentials import TokenCredential
...
class GetTokenMixin(ABC, TokenCredential):

# from https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/identity/azure-identity/azure/identity/aio/_internal/get_token_mixin.py
...
from azure.core.credentials_async import AsyncTokenCredential
...
class GetTokenMixin(abc.ABC, AsyncTokenCredential):

All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

@xiangyan99 good point, it probably would be worth adding. I am just now noticing, though, that this isn't supported in Python 3.7. This'll need some reworking, unfortunately 🤔

Change my approve to comment, as we need 3.6 support. Maybe Krista has an idea.

I guess what you wanted to say is we wanted 3.7 support?

@mccoyp we're dropping

Change my approve to comment, as we need 3.6 support. Maybe Krista has an idea.

I guess what you wanted to say is we wanted 3.7 support?

yeah :p

Yeah, this won't work because 3.7 doesn't support it 😔 And it doesn't solve the motivating issue (see this comment), so we'll need a different approach completely.
I don't think this change (rather, a 3.7-compatible version) is a bad idea, because being able to do an isinstance check of a protocol implementation sounds desirable. But I can also close this PR for now -- @lmazuel what do you think?

@mccoyp , ok let's try to reproduce already, it should be possible. Once we understand that, we'll talk about solution.

Identity CI failure is unrelated, and a fix is proposed here: https://github.com/Azure/azure-sdk-for-python/pull/25787
Overriding check enforcer to merge since everything else is a-okay 🙂

/check-enforcer override


Joining forces with twirp-ts

Hello, nice to meet you!
I'm the author of twirp-ts
I'm glad to see other server implementations in Typescript for twirp!
However, I was wondering what's the reason that pushed you to create a new twirp implementation over contributing to twirp-ts ?
We are using twirp-ts heavily internally and I'm willing to improve it as much as necessary, maybe we can join forces as I think that twirp-ts is a bit more mature?
If not, that's ok.
Different implementations would also bring new innovations.
Take care and good job!

Hello!
I actually started this project awhile back, before twirp-ts was available. When I have some time I'll play around with twirp-ts.
Thus far, I've focused on the following for TwirpScript:

Lean on Google's protobuf library as much as possible
Generate idiomatic JS interfaces (eg none of the Java idioms that Google's JS implementation presents like  $fieldList for array types).
A client optimized for consumption in the browser
Preserving comments as inline documentation

With this project I'm specifically interested in exploring the DX surrounding traditional full stack web applications where there is 1 server and 1 client. For multiple clients, I would pull in GraphQL, but for a single client I prefer the simpler architecture (and well defined optimization paths) found with a more traditional API server approach. A JSON API lacks the type safety I'm looking for. JSON Schema is another approach to solving this problem, but I was interested in exploring Twirp's approach to this problem.


fix: vhd build on master due to docker removals

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.817%

Totals

Change from base Build<PHONE_NUMBER>:
0%

Covered Lines:
2524

Relevant Lines:
4083

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on ace/fixVhdMaster at 61.817%

Totals

Change from base Build<PHONE_NUMBER>:
61.8%

Covered Lines:
2524

Relevant Lines:
4083

💛  - Coveralls


cms clipboard tests

add tests for cms.clipboard
remove the need to wait for dom ready to declare class instance

as usual better to review with https://github.com/FinalAngel/django-cms/pull/114/files?w=1 because changes in cms.clipboard.js are mostly indentation

nice LGTM!


YamlCspConfig::YamlLoader::DIRECTIVES is missing some CSP directives

The array YamlCspConfig::YamlLoader::DIRECTIVES is meant to specify all the various CSP directives that might be used. This list is used when determining the names of ENV vars for overrides.
For a list of all CSP directives see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy
Our list is incomplete.
The easy way to fix this is to just update the list to include all directives.
Maybe a better, but more involved solution, would be to depend on those defined in Rails in ActionDispatch, eg see the DIRECTIVES array defined in https://github.com/rails/rails/blob/main/actionpack/lib/action_dispatch/http/content_security_policy.rb#L143
Note that that list in ActionDispatch::ContentSecurityPolicy::DIRECTIVES does not include every directive, as some directives are handled in a specific way by ActionDispatch::ContentSecurityPolicy & hence instead are implemented as methods directly, eg sandbox is implemented explicitly here https://github.com/rails/rails/blob/main/actionpack/lib/action_dispatch/http/content_security_policy.rb#L265 ...
Therefore we need to take into account these extra directives not defined in DIRECTIVES, that are: [:navigate_to, :sandbox, :report_uri, :report_to, :upgrade_insecure_requests] and the deprecated ones [:block_all_mixed_content, :plugin_types,  :referrer]

Hi Steve,
I created a PR and added the missing CSP directives. I didn't see any contribution guidelines in your repo so I just went the "easy way" mentioned here. Let me know if that does the job and if you have any other comments. Thanks :)

@mhakeem thanks so much for the PR and sorry for the delay. I was unavailable for a few days. I will try look at this asap


so slow training

i train on 1 gpu v100
batchsize = 16
len(images_train) = 80k
time train per epoch = 7h
is it normal ?
Thank you so much for awesome repo.

That does not sound normal. Are you sure the GPU is getting used? Please verify using tf.config.list_physical_devices().

print(keras_ocr.version)
print(tf.version)
print("Num GPUs Available: ", tf.config.experimental.list_physical_devices())
->
0.6.3
2.0.0
Num GPUs Available:  [PhysicalDevice(name='/physical_device:CPU:0', device_type='CPU'), PhysicalDevice(name='/physical_device:XLA_CPU:0', device_type='XLA_CPU'), PhysicalDevice(name='/physical_device:GPU:
0', device_type='GPU'), PhysicalDevice(name='/physical_device:GPU:1', device_type='GPU'), PhysicalDevice(name='/physical_device:XLA_GPU:0', device_type='XLA_GPU'), PhysicalDevice(name='/physical_device:XL
A_GPU:1', device_type='XLA_GPU')]
i tried retrainning on 2 gpu, but only 1 gpu is used and it's still slow.


Update boto3 docs to be more accurate

I feel ashamed to say that my original implementation of beartype validators for boto3 types was... (gasp, shock)
incorrect
TLDR, it appears that any kind of custom annotated type that uses just object as its base will not be properly validated. Thankfully I was able to find base classes in the botos that when used will ensure correct checking of custom types. And tests to prove it too! (Thank goodness for TDD or I may never have discovered this problem).

I feel ashamed to say that my original implementation of beartype validators for boto3 types was... (gasp, shock)

Also, bearboto3 is a thing! Praise be to you, Paul, and the extend family tree that eventually begat you. Heroes one and all.
Also, a double-shocker emerges from the bearboto3 docos. I think a river dolphin with the head of a bear ...it's beautiful may have accidentally eaten a word between the "will" and the "since":

However, if you are using a runtime type-checker such as beartype, type validation will [something, something, fail, something, something] since the types technically do not match (even though they represent the same object schema).

Lastly, drop me a ping when you've released your first stable version on PyPI and/or conda-forge. I'll shill, stan, and namedrop hard for you and bearboto3 – or my real-world nickname isn't Lazy Boy.

Thankfully I was able to find base classes in the botos that when used will ensure correct checking of custom types.

I... I didn't even know the botos had classes. Like, any classes. This is truly a day of mass celebration. "Raise those keyboarding hands in the air, like Amazon just don't care!" :raised_hands:

Oh, wonderful. You already helpfully splashed bearboto3 across our docos! That's great. Quite a weight off my geriatric elderly millennial mind, really. It's in.
I'll lightly edit this to give bearboto3 top billing. Anybody that got time for both Boto3 and beartype also got time for bearboto3. Since this is non-trivial and fragile, everybody should go straight to the guy who knows what he's doing for once. Thanks again for all the QA goodies, Paul! Also, please make a river dolphin with the head of a bear happen.

...let's pretend I just didn't actually close this without merging. </awkward_moments>

...let's pretend I just didn't actually close this without merging. </awkward_moments>


Sharpening the axe

Hi,
It would be really nice to get the answers for the "Sharpening the axe" and "Quiz time" sections within the book.
regards
Andy

I agree, this is most def missing....


fix(build): show full error stats

Currently, running ng build error reporting for some classes of errors is not very useful.
For example, if you have a reference to an missing styles file in angular-cli.json, this is the output:
kamik@T460p MINGW64 /D/sandbox/master-proj (master)
$ ng build
 10% building modules 2/2 modules 0 activeresolve 'D:\sandbox\master-proj\src\nope.css' in 'D:\work\angular-cli\packages\angular-cli\models'
  using description file: D:\work\angular-cli\packages\angular-cli\package.json (relative path: ./models)
    Field 'browser' doesn't contain a valid alias configuration
  after using description file: D:\work\angular-cli\packages\angular-cli\package.json (relative path: ./models)
    using description file: D:\sandbox\master-proj\package.json (relative path: ./src/nope.css)
      as directory
        D:\sandbox\master-proj\src\nope.css doesn't exist
      no extension
        Field 'browser' doesn't contain a valid alias configuration
        D:\sandbox\master-proj\src\nope.css doesn't exist
      .ts
        Field 'browser' doesn't contain a valid alias configuration
        D:\sandbox\master-proj\src\nope.css.ts doesn't exist
      .js
        Field 'browser' doesn't contain a valid alias configuration
        D:\sandbox\master-proj\src\nope.css.js doesn't exist

D:\work\angular-cli\node_modules\webpack\lib\Compiler.js:220
                                        if(err) return callback(err);
                    ^
TypeError: Cannot read property 'hash' of undefined
    at D:\work\angular-cli\packages\angular-cli\tasks\build-webpack.ts:35:26
    at Compiler.onCompiled (D:\work\angular-cli\node_modules\webpack\lib\Compiler.js:220:21)
    at Compiler.<anonymous> (D:\work\angular-cli\node_modules\webpack\lib\Compiler.js:464:19)
    at D:\work\angular-cli\node_modules\tapable\lib\Tapable.js:148:11
(...)

This PR makes the error reporting similar to the output of ng serve, but still maintaining the error exit code:
kamik@T460p MINGW64 /D/sandbox/master-proj (master)
$ ng build
4800ms building modules
(...)
      index.html  491 bytes          [emitted]
 assets/file.txt    0 bytes          [emitted]
     favicon.ico    5.43 kB          [emitted]
chunk    {0} main.bundle.js, main.map (main) 2 MB {1} [initial] [rendered]
chunk    {1} styles.bundle.js, styles.map (styles) 10.2 kB {2} [initial] [rendered]
chunk    {2} inline.js, inline.map (inline) 0 bytes [entry] [rendered]

ERROR in multi styles
Module not found: Error: Can't resolve 'D:\sandbox\master-proj\src\nope.css' in 'D:\work\angular-cli\packages\angular-cli\models'
 @ multi styles
Child html-webpack-plugin for "index.html":
         Asset     Size  Chunks       Chunk Names
    index.html  2.84 kB       0
    chunk    {0} index.html 372 bytes [entry] [rendered]

kamik@T460p MINGW64 /D/sandbox/master-proj (master)
$ echo $?
1

Thanks for the PR!
cc @ericjim

this one small, but hides real exception

@valorkin can you clarify what you mean? In the example I gave it seemed to me that the full exception was actually hiding the error a user would need to fix.

I meant that this small fix (by amount of code ) does a great deal. Because previous implementation was hiding real error stack if stats  eq null

LGTM


fix: INT-2200 fix the CLI not showing version

Current dependencies on/for this PR:

main

PR #150   👈

This stack of pull requests is managed by Graphite.


Issues with alignment

Got some errors!
 {
                "code": "ACCESSOR_TOTAL_OFFSET_ALIGNMENT",
                "message": "Accessor's total byteOffset 7899366 isn't a multiple of componentType length 4.",
                "severity": 0,
                "pointer": "/accessors/37"
 },

Ah, looks like that was because we weren't supporting lights!


Build fails on androidx project

Is this a bug report?
Yes

Have you read the Installation Instructions?
Yes
Environment
System:
OS: macOS 10.14.4
CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
Memory: 1.20 GB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 11.14.0 - /usr/local/bin/node
Yarn: 1.15.2 - /usr/local/bin/yarn
npm: 6.9.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 23, 25, 26, 27, 28
Build Tools: 23.0.1, 25.0.0, 25.0.2, 26.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.0, 28.0.2, 28.0.3
System Images: android-27 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
Xcode: 10.2/10E125 - /usr/bin/xcodebuild
npmPackages:
react: 16.6.3 => 16.6.3
react-native: 0.57.8 => 0.57.8
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-maps: 0.24.2

Steps to Reproduce

Install react-native-maps on a non-androidx project
Migrate project to androidx https://developer.android.com/jetpack/androidx/migrate
Build project

Expected Behavior

Project should build
Actual Behavior

An complitation error occurs :
> Task :react-native-maps:compileDebugJavaWithJavac FAILED
/Users/user/Workspace/project/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:12: error: package android.support.v4.view does not exist
import android.support.v4.view.GestureDetectorCompat;
                              ^
/Users/user/Workspace/project/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:13: error: package android.support.v4.view does not exist
import android.support.v4.view.MotionEventCompat;
                              ^
/Users/user/Workspace/project/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:71: error: package android.support.v4.content does not exist
import static android.support.v4.content.PermissionChecker.checkSelfPermission;
                                        ^
/Users/user/Workspace/project/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:71: error: static import only from classes and interfaces
import static android.support.v4.content.PermissionChecker.checkSelfPermission;
^
/Users/user/Workspace/project/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:103: error: cannot find symbol
  private final GestureDetectorCompat gestureDetector;
                ^
  symbol:   class GestureDetectorCompat
  location: class AirMapView
/Users/user/Workspace/project/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:160: error: cannot find symbol
        new GestureDetectorCompat(reactContext, new GestureDetector.SimpleOnGestureListener() {
            ^
  symbol:   class GestureDetectorCompat
  location: class AirMapView
/Users/user/Workspace/project/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:399: error: cannot find symbol
    return checkSelfPermission(getContext(), PERMISSIONS[0]) == PackageManager.PERMISSION_GRANTED ||
           ^
  symbol:   method checkSelfPermission(Context,String)
  location: class AirMapView
/Users/user/Workspace/project/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:400: error: cannot find symbol
        checkSelfPermission(getContext(), PERMISSIONS[1]) == PackageManager.PERMISSION_GRANTED;
        ^
  symbol:   method checkSelfPermission(Context,String)
  location: class AirMapView
/Users/user/Workspace/project/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:907: error: cannot find symbol
    int action = MotionEventCompat.getActionMasked(ev);
                 ^
  symbol:   variable MotionEventCompat
  location: class AirMapView
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
9 errors

Reproducible Demo

@mikaoelitiana can you try https://github.com/react-native-community/react-native-maps/issues/2835#issuecomment-487839805 ?

@rborn unfortunately, it didn't fix my issue.

+1, we need support for androidx for this package

You can try to run this: https://github.com/mikehardy/jetifier and see how it works for you

Nah, it did not work for me.

@Saad-Bashar would be good if you could add your input here - https://github.com/mikehardy/jetifier/issues/8 -  with logs, what's going on,  etc 🤗

Yes just did @rborn! Thanks. This whole thing is insane. Even yesterday I was running android without any issue. Now I get this android manifest error all on a sudden in a lot of packages.

@Saad-Bashar check this, maybe it helps https://github.com/facebook/react-native/issues/25293#issuecomment-503045776

Getting same error. Is there any workaround?

You can try to run this: https://github.com/mikehardy/jetifier and see how it works for you

This worked for me, but only after I went into the node modules/react-native-map/lib/android/build.gradle and changed
dependencies {
  compileOnly('com.facebook.react:react-native:+') {
   exclude group: 'com.android.support'
  }
  ...
}

to
dependencies {
  implementation('com.facebook.react:react-native:+') {
  exclude group: 'com.android.support'
  }
  ...
}

This seems like a fix that should be included in the next PR ASAP

Does not work for me

Works for me. Now my app compiles but it is crashing on startup with error:
E/AndroidRuntime: FATAL EXCEPTION: create_react_context
I don't know if it is related to maps or other library.

I did android studio migration and then it worked for me

Will there be a new version of this package that supports androidx?

I am having the same issue

Same as @mursang I'm getting:
E/AndroidRuntime: FATAL EXCEPTION: create_react_context
after setting up jetify which fixed all the other modules I was using that are not yet androidx ready.
With the looming August 1st deadline for 64bit builds in play store this should be addressed urgently. I'm trying to get up to RN 0.59.0 to get 64 bit but I'm also having to do androidx to get there. I also assume this means this module is broken on new apps using current RN version(or >0.59.0).

On second look I think my fatal is caused by react-native-device-info and jetify at least got my app building. Will report back on whether maps works at runtime once I overcome this fatal error.
https://gist.github.com/jameslporter/54f711ccfada44c559764f43a4976065
Hey @mursang are you using device-info too? Does your error blame maps?

hey @jameslporter thanks for those tips.
I managed to compile without errors by making a fork from this library and migrating imports to the new androidx syntax.
After that I still had some issues, but they were caused by other libraries. I needed to update them to the latest version praying that they had androidx support.
But after upgrading everything and being able to compile for android, I have issues compiling for iOS. I think I need to wait for every library to properly upgrade versions and match React Native version..

hi, @mikaoelitiana
change android.supprot.v* to androidx
import android.support.v4.view.GestureDetectorCompat;
import android.support.v4.view.GestureDetectorCompat;
……
import static android.support.v4.content.PermissionChecker.checkSelfPermission;
==>
import androidx.core.view.GestureDetectorCompat;
import androidx.core.view.MotionEventCompat;
……
import static androidx.core.content.PermissionChecker.checkSelfPermission;

thanks @yangkf1985
update on AirmapView.java
import android.support.v4.view.GestureDetectorCompat; --> import androidx.core.view.GestureDetectorCompat;
import android.support.v4.view.MotionEventCompat; --> import androidx.core.view.MotionEventCompat;
import static android.support.v4.content.PermissionChecker.checkSelfPermission; --> import static androidx.core.content.PermissionChecker.checkSelfPermission;

thanks @yangkf1985
update on AirmapView.java
import android.support.v4.view.GestureDetectorCompat; --> import androidx.core.view.GestureDetectorCompat;
import android.support.v4.view.MotionEventCompat; --> import androidx.core.view.MotionEventCompat;
import static android.support.v4.content.PermissionChecker.checkSelfPermission; --> import static androidx.core.content.PermissionChecker.checkSelfPermission;

Saved my day

@yangkf1985 saved my day :)

hi, @mikaoelitiana
change android.supprot.v* to androidx
import android.support.v4.view.GestureDetectorCompat;
import android.support.v4.view.GestureDetectorCompat;
……
import static android.support.v4.content.PermissionChecker.checkSelfPermission;
==>
import androidx.core.view.GestureDetectorCompat;
import androidx.core.view.MotionEventCompat;
……
import static androidx.core.content.PermissionChecker.checkSelfPermission;

I just installedinstalled the lib all the above changes were already there, but now I am getting the following

Task :react-native-maps:compileDebugJavaWithJavac FAILED
/Users/tusharaswal/Desktop/HELAJOB59/newproject/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:12: error: package androidx.cor
e.view does not exist
import androidx.core.view.GestureDetectorCompat;
^
/Users/tusharaswal/Desktop/HELAJOB59/newproject/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:13: error: package androidx.core.view does not exist
import androidx.core.view.MotionEventCompat;
^
/Users/tusharaswal/Desktop/HELAJOB59/newproject/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:71: error: package androidx.core.content does not exist
import static androidx.core.content.PermissionChecker.checkSelfPermission;
^
/Users/tusharaswal/Desktop/HELAJOB59/newproject/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:71: error: static import only from classes and interfaces
import static androidx.core.content.PermissionChecker.checkSelfPermission;
^
/Users/tusharaswal/Desktop/HELAJOB59/newproject/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:103: error: cannot find symbol
private final GestureDetectorCompat gestureDetector;
^
symbol:   class GestureDetectorCompat
location: class AirMapView
/Users/tusharaswal/Desktop/HELAJOB59/newproject/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:160: error: cannot find symbol
new GestureDetectorCompat(reactContext, new GestureDetector.SimpleOnGestureListener() {
^
symbol:   class GestureDetectorCompat
location: class AirMapView
/Users/tusharaswal/Desktop/HELAJOB59/newproject/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:399: error: cannot find symbol
return checkSelfPermission(getContext(), PERMISSIONS[0]) == PackageManager.PERMISSION_GRANTED ||
^
symbol:   method checkSelfPermission(Context,String)
location: class AirMapView
/Users/tusharaswal/Desktop/HELAJOB59/newproject/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:400: error: cannot find symbol
checkSelfPermission(getContext(), PERMISSIONS[1]) == PackageManager.PERMISSION_GRANTED;
^
symbol:   method checkSelfPermission(Context,String)
location: class AirMapView
/Users/tusharaswal/Desktop/HELAJOB59/newproject/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:911: error: cannot find symbol
int action = MotionEventCompat.getActionMasked(ev);

If you're using jetifier you just have to run
npx jetify
after installing.

@Mattimus333 - and just like that you saved my day 👯♂

Yes just did @rborn! Thanks. This whole thing is insane. Even yesterday I was running android without any issue. Now I get this android manifest error all on a sudden in a lot of packages.

industrial sabotage ;( If you call out the package managers, half the time they'll release a miracle update and give some excuse. One time the manager said "Im doing this release just for YOU!". Yep.

I had error when use react-native-maps package on RN 0.59.9.
> Task :react-native-maps:compileDebugJavaWithJavac FAILED
/Volumes/Work/ben/develop/Nono-1.0/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:12: error: package android.support.v4.view does not exist
import android.support.v4.view.GestureDetectorCompat;
                              ^
/Volumes/Work/ben/develop/Nono-1.0/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:13: error: package android.support.v4.view does not exist
import android.support.v4.view.MotionEventCompat;
                              ^
/Volumes/Work/ben/develop/Nono-1.0/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:71: error: package android.support.v4.content does not exist
import static android.support.v4.content.PermissionChecker.checkSelfPermission;
                                        ^
/Volumes/Work/ben/develop/Nono-1.0/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:71: error: static import only from classes and interfaces
import static android.support.v4.content.PermissionChecker.checkSelfPermission;
^
/Volumes/Work/ben/develop/Nono-1.0/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:103: error: cannot find symbol
  private final GestureDetectorCompat gestureDetector;
                ^
  symbol:   class GestureDetectorCompat
  location: class AirMapView
/Volumes/Work/ben/develop/Nono-1.0/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:160: error: cannot find symbol
        new GestureDetectorCompat(reactContext, new GestureDetector.SimpleOnGestureListener() {
            ^
  symbol:   class GestureDetectorCompat
  location: class AirMapView
/Volumes/Work/ben/develop/Nono-1.0/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:399: error: cannot find symbol
    return checkSelfPermission(getContext(), PERMISSIONS[0]) == PackageManager.PERMISSION_GRANTED ||
           ^
  symbol:   method checkSelfPermission(Context,String)
  location: class AirMapView
/Volumes/Work/ben/develop/Nono-1.0/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:400: error: cannot find symbol
        checkSelfPermission(getContext(), PERMISSIONS[1]) == PackageManager.PERMISSION_GRANTED;
        ^
  symbol:   method checkSelfPermission(Context,String)
  location: class AirMapView
/Volumes/Work/ben/develop/Nono-1.0/node_modules/react-native-maps/lib/android/src/main/java/com/airbnb/android/react/maps/AirMapView.java:911: error: cannot find symbol
    int action = MotionEventCompat.getActionMasked(ev);
                 ^
  symbol:   variable MotionEventCompat
  location: class AirMapView
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
9 errors

How can I solve this issue?

react native version 0.59.0
android/gradle.properties
android.useAndroidX=true
android.enableJetifier=true
I solved this issue


Fix CharSequenceValueConverter.convertToByte implementation for Ascii…

…String
Motivation:
The implementation of CharSequenceValueConverter.convertToByte did not correctly handle AsciiString if the length != 1.
Modifications:

Only use fast-path for AsciiString with length of 1.
Add unit tests.

Result:
Fixes https://github.com/netty/netty/issues/7990

Nope, still bugged. Just remove the special AsciiString handling.

@henrik-lindqvist it works like it should as far as I can tell ... Please provide a unit test that shows that it doesn't if you think there is something wrong. I tried multiple things and all worked as expected.

An "33" or "0x21" input to convertToByte, either as AsciiString or CharSequence, should return (byte)'!' or (byte)33 output. So it's compatible with convertByte(33) which return "33". Correct fix:
@Override
public byte convertToByte(CharSequence value) {
    return Byte.parseByte(value.toString());
}

@henrik-lindqvist that a way of converting a CharSequence to a byte, but there are many ways.  As I said in #7990, there isn't a "right" conversion here.
For example, what should happen when converting 0x33 or 033 ?   What about 257 ?  What about Byte.parseByte("᧓᧓"), which is U+19D3, and is interpreted by Java as 33 ?  There isn't going to be a right answer.

Agreed, that why i reported the issue, you guys have to choose the "right" conversion. But it cant differentiate depending on input type (AsciiString or not). It's either just the first byte like convertToChar do for char, or a sequence of digits (e.g "123") which is parsed into a ASCII value, that's what Byte.parseByte() do.  As said, looking at what convertByte() return, it's probably the latter, unless convertByte() is also bugged.

@henrik-lindqvist Can you please provide a unit test that fails ? I am still a bit confused why you think there is an issue. Passing in 33 results in the same output for both at the moment as well, I agree it was not correct before in some case as we ignored the length but now I think it should be fine. With an actual reproducer it would be a lot easier for me to understand the issue.

The existing test seems correct:
@Test
public void testByteFromAsciiString() {
    assertEquals(127, converter.convertToByte(AsciiString.of("127")));
}

You might add (untested):
@Test
public void testByteFromString() {
    assertEquals(127, converter.convertToByte("127"));
}

@Test
public void testByteToCharSequence() {
    assertTrue(AsciiString.contentEquals("127", converter.convertByte(127)));
}

To me, it seems impossible the current code would pass, unless byteAt is somehow parsing numbers, or '1' has changed ASCII value to 127:
@Override
public byte convertToByte(CharSequence value) {
    if (value instanceof AsciiString && value.length() == 1) {
        return ((AsciiString) value).byteAt(0);
    }
    return Byte.parseByte(value.toString());

}

Also add:
@Test
public void testByteFromAsciiString() {
assertEquals(8, converter.convertToByte(AsciiString.of("8")));
}

Another:
@Test
public void testByteFromAsciiString() {
    assertEquals(8, converter.convertToByte(AsciiString.of("8")));

}


On Mac, hardcode the public type bindings

Do not generate them, as the Mac clang is a source of regular issues
building them.
They haven't changed in 5 years since they were introduced, so I think
this is a fairly safe change
https://github.com/tesseract-ocr/tesseract/blob/main/include/tesseract/publictypes.h#L30-L43
(check the blame).

I'm not on a Mac, so haven't been able to properly test this.
I have checked that by changing cfg( to give me the Mac options everything worked.


icinga2_config_host as child of icinga2_objects

Hello,
I'm trying to figure why the variable "icinga2_config_host" is used as a child of the icinga2_objects variable in the 'icinga2' role.
Let me explain why: as you all known the ansible variable inheritance is convenient to override variables for hosts and groups, so in my case I have a generic icinga2_objects variable at the group level 'all' that apply to all my hosts managed by ansible and monitored by icinga, a more complete icinga2_objects variable declared at group level for my 'masters' and the last icinga2_objects at 'master2' level. With that method in my variables is not convenient and I cannot specify a 'icinga2_config_host' as child for all objects, so the role doesn't work.
I'm able to use my vars with a slight mod to the role in the file 'objects.yml' like this
# - name: collect all config objects for myself
#   set_fact:
#     tmp_objects: "{{ tmp_objects| default([]) + lookup('list', hostvars[item]['icinga2_objects'][icinga2_config_host]) }}"
#   with_items: "{{ groups['all'] }}"
#   when: hostvars[item]['icinga2_objects'][icinga2_config_host] is defined

- name: collect all config objects in play vars
  set_fact:
  #   tmp_objects: "{{ tmp_objects| default([]) + lookup('list', icinga2_objects[icinga2_config_host]) }}"
  # when: vars['icinga2_objects'][icinga2_config_host] is defined
    tmp_objects: "{{ tmp_objects| default([]) + lookup('list', icinga2_objects) }}"
  when: vars['icinga2_objects'] is defined

So mine is more a question that an issue, why is designed to gather all config objects and all play vars with a host as child of objects?
I hope that I explained well my perplexity. If my mod is right to you I can submit a PR to better analyze and test the behavior
Thanks

Hi thanks for the question and I think you found a bug as well. The motive of this icinga2_objects is that you can define the variable anywhere and don't deploy the whole monitoring configuration everywhere.
Let's take a group for our master hosts, every master has kind of the same configuration but different names. But the configuration which is deployed, should be synced over the icinga cluster sync. In this case we can use the variables in the same play and only deploy monitoring configuration on the config master.
icinga2_objects:
  config_master.fqdn:
    - name: host1
       type: Host
       [...]

Thats the first code of block. You can also define for a specific satellite in his own host_vars, some lokal configuration.
On the other hand, the second block should enable you to use the icinga2_objects in the way that Ansible normally uses variables. You can define the variable and overwrite it in different files. And there is an issue, I think the following line should be changed:
- name: collect all config objects in play vars
  set_fact:
    tmp_objects: "{{ tmp_objects| default([]) + lookup('list', icinga2_objects[icinga2_config_host]) }}"
-  when: vars['icinga2_objects'][icinga2_config_host] is defined
+  when: vars['icinga2_objects'][icinga2_config_host] is not defined

Because then if there's no variable with the config host name defined, the "normal" method will be used.
Can you try to change the line and verify it is working?

Hi, thanks for the explanation, tomorrow I can test this mod and I tell you the result

Hi, I tried but with your suggestion the task fails, so i noticed it can work removing also the [icinga2_config_host] on the previous line, so the task became
- name: collect all config objects in play vars
   set_fact:
      tmp_objects: "{{ tmp_objects| default([]) + lookup('list', icinga2_objects) }}"
   when: vars['icinga2_objects'][icinga2_config_host] is not defined

let me know if I'm right

Sorry, yes this is my fault - indeed if icinga2_config_host is not defined, we should only use icinga2_objects as variable.
If this is what you are looking for, I would create a PR, documentation and fix it.

No problem, the task that I pasted in my previous comment is working as expected. If you prefer I can send the PR for you, I already have the project forked.
Thanks

If you have everything already prepared this would be helpful. Thank you :)

Hi, I've submitted PR #255