Zebra should store a persistent list of recent successful peers

Motivation
Zebra currently fetches a new list of peers from DNS each time it launches.
This design has some benefits:

Zebra behaviour is consistent and has minimal state

And some drawbacks:

Zebra will fail if DNS is down or slow when it launches

see also #1892 where Zebra regularly queries DNS for peers

Zebra relies on peer addresses from DNS, which is not encrypted or authenticated by default
Zebra leaks the exact time that it launches by making a DNS query

Solution
Zebra should keep a cached list of peer addresses on disk, and update it regularly. This list can be separate from the state cache.
To avoid privacy leaks:

the list should only store peer addresses, and no other data
it should be sorted to destroy any order in the peer list

Alternative 1: Only use DNS if cached peers don't work
zcashd tries both the cached list of peer addresses and new addresses from DNS. This design has the following tradeoffs:

Zebra doesn't rely on DNS
Every time Zebra starts, it can have bad peers added by its current DNS
Launching is as fast as possible, regardless of the quality of the cached list or DNS
Zebra leaks some information by making a DNS query every time it starts up
Zebra can easily recover from a compromised or poorly performing peer list, but some bad peers will stay in the list

Alternative 2: Only use DNS if cached peers don't work
zcashd first tries the cached list of peer addresses, then makes a DNS query if none connect. This design has the following tradeoffs:

Zebra doesn't rely on DNS unless it really needs to
Launching might be slower if it takes a while to work out that all peers have failed
Zebra leaks some information about the quality of its cached peer address list
Zebra doesn't have a peer reputation system, so it's hard to work out if all peers are "bad"
It's harder for Zebra to recover from a compromised or poorly performing peer list, because it might never use DNS again

We can re-open this if it becomes a problem.

@mpguerra this is the old ticket for the audit/stable release, I updated it with new designs.


Only create table if it does not exist Fix #57

Was attempting to create a table even if it already exist. Simply modified the table creation query.

Thank you for the PR.
But I think I can't accept it currently .
All the table creation operations don't have IF NOT EXISTS in the database backends from django project.
Imagine that a table with the same name already exists in the database. If the migration operation does not report an error but is executed normally, then the schema of this table may be different from what you defined. Then the database status will be inconsistent with what Django defines. There will be problems with migration and query in the later usage of this table.

I will write a django project later with docker compose, and you could use the project to check this issue.

Yup, @jayvynl that's a valid point. Observed the same issue with constraints, It's not checking if the same constraint exists.
Steps to achieve
Create a model Event as below
`
from django.db.models import CheckConstraint, IntegerChoices, Q
from django.utils import timezone
from clickhouse_backend import models
class Event(models.ClickhouseModel):
class Action(IntegerChoices):
PASS = 1
DROP = 2
ALERT = 3
ip = models.GenericIPAddressField(default="::")
ipv4 = models.IPv4Field(default="<IP_ADDRESS>")
ip_nullable = models.GenericIPAddressField(null=True)
port = models.UInt16Field(default=0)
protocol = models.StringField(default="", low_cardinality=True)
content = models.JSONField(default=dict)
timestamp = models.DateTime64Field(default=timezone.now)
created_at = models.DateTime64Field(auto_now_add=True)
action = models.EnumField(choices=Action.choices, default=Action.PASS)
class Meta:
    ordering = ["-timestamp"]
    engine = models.MergeTree(
        primary_key="timestamp",
        order_by=("timestamp", "id"),
        partition_by=models.toYYYYMMDD("timestamp"),
        index_granularity=1024,
        index_granularity_bytes=1 << 20,
        enable_mixed_granularity_parts=1,
    )
    indexes = [
        models.Index(
            fields=["ip"],
            name="ip_set_idx",
            type=models.Set(1000),
            granularity=4
        ),
        models.Index(
            fields=["ipv4"],
            name="ipv4_bloom_idx",
            type=models.BloomFilter(0.001),
            granularity=1
        )
    ]
    constraints = (
        CheckConstraint(
            name="port_range",
            check=Q(port__gte=0, port__lte=65535),
        ),
    )

`
1.python manage.py makemigrations - PASS
2.python manage.py migrate - PASS
3.python manage.py migrate - FAIL
If migrations is already applied and we try to migrate again, due to pre-existing same constraints it will FAIL.


Collapsible List Accessibility - Keyboard Interaction Bug

RMWC 5.7.0
When traversing a RMWC collapsible list using keyboard navigation alone, the list items have a tendency to get 'stuck' meaning that the user is unable to navigate past a collapsible list handle and allow focus to rest on the next item in the list.
Replication
The RMWC (https://rmwc.io/) site navigation uses the collapsible list component and can be used to demonstrate the issue:

Highlight the ‘getting started’ item in the site navigation
Press DOWN arrow to move the focus to the ‘Avatars’ item
Press Up arrow to move the focus back to the ‘getting started’ item
Pressing the DOWN arrow again does nothing and the user can no longer traverse the collapsible list using the keyboard alone.

The issue can be cleared by expanding the ‘getting started’ item and selecting one of the sub menu items
There are various ways to trigger the issue, additionally -

Highlight the ‘getting started’ item
Click enter to expand the ‘getting started’ menu
Click enter again to collapse the menu
Press DOWN arrow - nothing happens. The user is stuck until they re-open the sub menu item and select one of the items.

NB: If the Collapsible list parent is further down the menu, the user is able to use the arrow UP, and down, but not beyond the menu item which was last interacted with

Thanks for the simple repro steps. I’ll look into this, probably a simple fix.

Hi, i encountered this issue recently. Has it been resolved? Otherwise I'll gladly look into it.


Extending theme with pages for other types of content

Hi guys, love the theme as is, but I would really like to extend it with pages for other types of content, such as posts, projects etc. Are you perhaps working on that? Otherwise, I'll create my own extensions to the theme.

We are currently in the process of adding more features. First iteration is a successor theme available here: github.com/okkur/syna. It's still a work in progress, but each version should be stable in itself.
After this iteration is finished, I'll do my best to backport some features such as single pages, multilingual etc.

As hugo-agency-theme is mostly in maintainance mode and no new features will be added.
We created Syna as a more flexible iteration of this theme.
Syna already has a lot more features and can easily be extended.


On screen modal window

i will add an on-screen modal window for playing the trailer instead of redirecting to IMDB website

@akshay399 this issue is already open #392. Ping me there to assign you.


[fix] reduce content in sql lab localStorage

CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[x] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
recent new features increase the size of content in sql lab dropdown list (like tables etc). If we store everything in redux store into localStorage, it's very easy reach localStorage upper limit.
Solution:
remove tables/table options from localStorage.
TEST PLAN
Added unit test for this update.
REVIEWERS
@etr2460 @mistercrunch @michellethomas

Codecov Report

Merging #7998 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7998      +/-   ##
==========================================
+ Coverage   65.58%   65.62%   +0.04%
==========================================
  Files         469      469
  Lines       22413    22419       +6
  Branches     2431     2431
==========================================
+ Hits        14699    14712      +13
+ Misses       7593     7587       -6
+ Partials      121      120       -1

Impacted Files
Coverage Δ

superset/assets/src/SqlLab/App.jsx
0% <ø> (ø)
:arrow_up:

...src/SqlLab/utils/reduxStateToLocalStorageHelper.js
100% <100%> (ø)

.../assets/src/SqlLab/components/AceEditorWrapper.jsx
58.53% <0%> (+1.21%)
:arrow_up:

superset/assets/src/reduxUtils.js
68.96% <0%> (+1.72%)
:arrow_up:

superset/db_engine_specs/postgres.py
95.45% <0%> (+22.72%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e830474...643d3da. Read the comment docs.

@graceguo-supercat I'm finishing my PR moving all the state to the backend, I should have it for review early next week.


Provide advice how to build with rollup a bundle containing bootsrap v4+ popper.js + jquery

I want to create a sigle file with rollup, that contains bootstrap-4.js, popper.js and jquery-slim.  The rationale is that I want to have a single

I mean I do not understand why jquery.slim.js and popper.js behave differently.

Sorry, but we cannot help with how-to or general troubleshooting issues here; only bug reports and feature requests. You'll want to ask around in the official Slack team or Stack Overflow. See our readme for more details.


Request to Enable Discussions in Repository

I was wondering if it might be possible for you to enable discussions within this GitHub repository.
This would allow people to engage in Q&A sessions, share information about new releases or unexpected documentation, and showcase projects they've been working on. By providing this separate space for discussion, we could help prevent the issue tracker from becoming cluttered and ensure that issues are addressed in a more streamlined manner. It would also give you the opportunity to focus on more pressing matters, without feeling guilty about not responding to every comment or question that arises.
Would you be willing to consider enabling discussions within the repository?

In addition, should any discussions arise in the issue tracker, one could easily transfer them to the discussion space or close them as needed. This would help keep the issue tracker clean and organized, while also ensuring that important discussions are taking place in the appropriate forum.

Ideally, I want this to be just repository which keeps my code.
alexmercerind/dart_vlc also has 'Discussions' enabled, experience has been same (issues still got spammed).
Thinking that package will just work on macOS if they install VLC.
Advertisement (?)

I've already released my work under open-source license: use it; improve it; fix it. And it's a good deal (free).
As I said in the another issue comment, I have no interest in answering 10s of people on daily basis or do their job. If someone wants consultancy from me or a new feature for their professional project, they can reach out on a contract basis.
In complete honesty, my time is valuable as everyone else's 😢.
audio_service also asks developers to ask questions on StackOverflow instead & and that's exactly what it's used for.
[I'm pretty sure if people ask questions like this on StackOverflow, they're going to get bullied has hell]

TL;DR
I think we should instead have a community (e.g. Discord Server) where people can answer each other, share information about new releases or unexpected documentation, and showcase projects they've been working on ... (like you said).
I don't think I can answer every individual personally alongside development process of package:media_kit (already done in hobby time). Having a Discord will save my GitHub & e-mail from redundant notifications, while repository will be used solely for development. If I find some conversation interesting, I can then participate in it.
So, how does Discord sound? Flutter team also has one.

https://discord.gg/h7qf2R9n57

Discord server sounds really good! I actually thought to suggest that but for reasons I don't.

I've published current work on pub.dev & included Discord links everywhere.


Convert the timeout parameter from an integer to a double value

Search before asking

[X] I had searched in the issues and found no similar issues.

Motivation
In redis, the timeout parameter of commands like BLPOP is a double value, but in kvrocks, the parameter must be an integer.
Solution
We can change parseint in the Parse function into parsefloat.
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

Hi @Yangsx-1
Many thanks for your feedback. It should be a mistake in the Redis document, the timeout in the BLPOP is an integer indeed: https://github.com/redis/redis/blob/b00a2351865bb1d87e2d2701b77c8a68daefb054/src/t_list.c#L1218

Hi @Yangsx-1
Many thanks for your feedback. It should be a mistake in the Redis document, the timeout in the BLPOP is an integer indeed: https://github.com/redis/redis/blob/b00a2351865bb1d87e2d2701b77c8a68daefb054/src/t_list.c#L1218

But i tested it locally, timeout can be floating-point number?

Hi @Yangsx-1
Many thanks for your feedback. It should be a mistake in the Redis document, the timeout in the BLPOP is an integer indeed: https://github.com/redis/redis/blob/b00a2351865bb1d87e2d2701b77c8a68daefb054/src/t_list.c#L1218

 But i tested it locally, timeout can be floating-point number?

oh, good. You're right that Redis will parse it as a double when the unit is a second:https://github.com/redis/redis/blob/b00a2351865bb1d87e2d2701b77c8a68daefb054/src/timeout.c#L171

@Yangsx-1 assigned, thanks for your good catch.


When will you release your test code?

I find that you do not provide demo code to test wild images. When will you release your demo code?
Without demo code, it is very hard to evalute your algorithm using wild images

Hi, we've been really busy lately. We will release the demo code as soon as possible.

Hi @vigorbird, the demo code is now available.


update pr template

What this PR does / why we need it:
Update PR template
Release note:

None

Can we merge this?


[Dependency] Bump dependency version

Purpose of the pull request
https://github.com/apache/dolphinscheduler/pull/14482
https://github.com/apache/dolphinscheduler/pull/14062
https://github.com/apache/dolphinscheduler/pull/14359

Codecov Report

Merging #14575 (03c4cae) into dev (c0d7763) will decrease coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 03c4cae differs from pull request most recent head a268b67. Consider uploading reports for the commit a268b67 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14575      +/-   ##
============================================
- Coverage     38.69%   38.68%   -0.01%
+ Complexity     4578     4572       -6
============================================
  Files          1241     1241
  Lines         43569    43521      -48
  Branches       4826     4796      -30
============================================
- Hits          16857    16837      -20
+ Misses        24845    24816      -29
- Partials       1867     1868       +1

see 37 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Server side pre-request hook in tomcat does not work

https://github.com/dacapobench/dacapobench/blob/d8b6138eb58e45b0ec28c238dd436e2203d756ba/benchmarks/bms/tomcat/tomcat.patch#L117
The check t == null will prevent the hook being executed. This check is simply wrong and does not make sense.

Fixed in 72cedc96bd38d73c3a1c2e0cd4fe2beb2a413003


Implement E2E testing in create fuels

create fuels aims to provide a full stack and feature complete solution for working with and deploying dApps on fuel.
We should provide a E2E testing solution so that consumers test their frontend applications. We should use something like playwright or vitest to integrate with our own infra.

Terminoplogy-wise, perhaps this could be called ui tests.
I expanded on this thought here.


PICO Unity Integration broken

The Pico SDK has worked fine for me on their v2.0.7 version, however, the controllers no longer work when using their latest v2.1.1 update. The headset itself is being tracked as normal however the controllers are not being tracked or registering button clicks.
This was tested in a new 2022.1.18f1 unity project with URP and only Ultimate XR v0.8.4 & PICO Unity Integration SDK v211 installed.
Unity Ver: 2022.1.18f1 & 2022.1.17f1
Render pipeline: URP
Ultimate XR: v0.8.4
PICO Unity Integration SDK: v2.1.1

It is shown as not installed however this also happened in Pico SDK v2.0.7 but it was still working back then.

+1
The same from my side, however I am using different Pico version:
Unity: 2021.3.4f1
PicoXR: 2.0.5
Checked on both URP and BRP projects.

Is it possible that the controller names have been changed? Would it be possible to get a log using adb?
I'm interested in the lines that try to enable the correct input/tracking component based on the controllers that were connected. The following names have been used so far:
"PicoXR Controller-Left"
"PicoXR Controller-Right"

I installed the PicoXR Unity Integration v2.1.1 and as I suspected, the controller names changed.
It has been fixed in commit https://github.com/VRMADA/ultimatexr-unity/commit/4325a04f7384e8fba3c18d848b5ff605b0093717
I haven't created a new release (.unitypackage) yet, but if you're using github or the package manager to install UltimateXR instead, you should be able to update easily.

Would you be able to test the update to close the issue? Thanks!

Sorry for the delay. Our Pico was away being demo'd to clients. We only have 1 in the office 😔. Anyways I've tested the fix, works perfectly now. Thanks!


Respect TERM=dumb and emit no colour escape codes

Certain shells are not particularly happy with colour escape codes. To make them happy, clap should respect TERM=dumb and refrain from emitting colour escape codes.
Rust Version
rustc 1.15.0 (10893a9a3 2017-01-19)
Affected Version of clap
% grep clap Cargo.toml
clap = "2.19.0"

Expected Behavior Summary
For a program using clap to respect TERM=dumb and emit no colour escape codes.
Actual Behavior Summary
Program using clap emits colour escape codes as shown in https://github.com/BurntSushi/ripgrep/issues/353.
Steps to Reproduce the issue
Compile any program using clap as a dependency and use an unrecognised flag:
% rg --color never -asd
�[1;31merror:�[0m Found argument '�[33m-d�[0m' which wasn't expected, or isn't valid in this context

USAGE:

    rg [OPTIONS] <pattern> [<path> ...]
    rg [OPTIONS] [-e PATTERN | -f FILE ]... [<path> ...]
    rg [OPTIONS] --files [<path> ...]
    rg [OPTIONS] --type-list

For more information try �[32m--help�[0m

Thanks!
Relates to #836

I wonder if someone can reference TERM=dumb is standardize across applications. Is there any documentation that explains how it should behave?

@nateozem This is the best I could find: https://linux.die.net/man/7/term --- TL;DR the TERM=dumb convention is quite old. The behavior today is to treat TERM=dumb as "don't emit escape sequences because the terminal being used won't know how to use them."

@BurntSushi, interesting.
Seem like the behavior would depend on each individual machine. In most probability, everyone has the same capability for dumb, but there can be an instance where someone can change how the terminal type behaves by using the tic command.
 What do you guys think?
When I discover anything more, I'll report back.

@nateozem Consulting terminfo is certainly one path. It's a complex one, but it's valid. On the other hand, just respecting TERM=dumb will solve a good number of problems. Perhaps not all of them, but some of them. :-)

We could do almost the same thing as they have done
http://git.savannah.gnu.org/cgit/grep.git/tree/lib/colorize-posix.c:
/* Return non-zero if we should highlight matches in output to file
   descriptor FD.  */
int
should_colorize (void)
{
  char const *t = getenv ("TERM");
  return t && strcmp (t, "dumb") != 0;
}

It's very simple. Think this would work for us?

Fixed by #963


 Let's only load what we're actually using, where we are using it. I also removed the autoload for the vendored libraries; we can just require them.
@robfoster @RichardBlair

Really like this. :+1:


[bug] how to use tailwindCss in content-ui .

Thanks to the author for the sample code!
it work well in popup and  option , but it does not work during the content-ui injection stage...
what should i do , if i want to use it in content page ~

oh, i figure it out....
import cssText from 'data-text:~style.css';
....
export const getStyle = () => {
    const style = document.createElement('style');
    style.textContent = cssText;
    return style;
};


Add metrics for FilterExec

Which issue does this PR close?
Next part https://github.com/apache/arrow-datafusion/issues/866
Rationale for this change
We want basic understanding of where a plan's time is spent and in what operators. See https://github.com/apache/arrow-datafusion/issues/866 for more details
What changes are included in this PR?

Instrument FilterExec using the API from https://github.com/apache/arrow-datafusion/pull/909
Tests for same

Are there any user-facing changes?
More fields in EXPLAIN ANALYZE are now filled out
Example of how explain analayze is looking:
EXPLAIN ANALYZE select count(*) from (SELECT count(*), c1 FROM aggregate_test_100 WHERE c13 != 'C2GT5KVyOPZpgKVl110TyZO0NcJ434' GROUP BY c1 ORDER BY c1)

+-------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| plan_type         | plan                                                                                |
+-------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Plan with Metrics | ProjectionExec: expr=[COUNT(UInt8(1))@0 as COUNT(UInt8(1))], metrics=[]                                                                                |
|                   |   HashAggregateExec: mode=Final, gby=[], aggr=[COUNT(UInt8(1))], metrics=[output_rows=1, elapsed_compute=69.362µs]                                                                                |
|                   |     CoalescePartitionsExec, metrics=[output_rows=3, elapsed_compute=NOT RECORDED]                                                                                |
|                   |       HashAggregateExec: mode=Partial, gby=[], aggr=[COUNT(UInt8(1))], metrics=[output_rows=3, elapsed_compute=119.041µs]                                                                                |
|                   |         RepartitionExec: partitioning=RoundRobinBatch(3), metrics=[send_time{inputPartition=0}=4.775µs, fetch_time{inputPartition=0}=12.77346ms, repart_time{inputPartition=0}=NOT RECORDED]                                      |
|                   |           SortExec: [c1@0 ASC], metrics=[output_rows=5, elapsed_compute=232.203µs]                                                                                |
|                   |             CoalescePartitionsExec, metrics=[output_rows=5, elapsed_compute=NOT RECORDED]                                                                                |
|                   |               HashAggregateExec: mode=FinalPartitioned, gby=[c1@0 as c1], aggr=[COUNT(UInt8(1))], metrics=[output_rows=5, elapsed_compute=373.876µs]                                                                              |
|                   |                 CoalesceBatchesExec: target_batch_size=4096, metrics=[]                                                                                |
|                   |                   RepartitionExec: partitioning=Hash([Column { name: "c1", index: 0 }], 3), metrics=[fetch_time{inputPartition=0}=34.072102ms, repart_time{inputPartition=0}=252.872µs, send_time{inputPartition=0}=NOT RECORDED] |
|                   |                     HashAggregateExec: mode=Partial, gby=[c1@0 as c1], aggr=[COUNT(UInt8(1))], metrics=[output_rows=5, elapsed_compute=581.405µs]                                                                                |
|                   |                       CoalesceBatchesExec: target_batch_size=4096, metrics=[]                                                                                |
|                   |                         FilterExec: c13@1 != C2GT5KVyOPZpgKVl110TyZO0NcJ434, metrics=[output_rows=99, elapsed_compute=309.095µs]                                                                                |
|                   |                           RepartitionExec: partitioning=RoundRobinBatch(3), metrics=[fetch_time{inputPartition=0}=8.239528ms, send_time{inputPartition=0}=9.864µs, repart_time{inputPartition=0}=NOT RECORDED]                    |
|                   |                             CsvExec: source=Path(ARROW_TEST_DATA/csv/aggregate_test_100.csv: [ARROW_TEST_DATA/csv/aggregate_test_100.csv]), has_header=true, metrics=[]         |
+-------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

clippy failure is due to https://github.com/apache/arrow-datafusion/pull/986 I think


BButton adding class

When trying to add some color (any really) classes to the BButton it does not apply it to the class list along with the button class
 <BButton on:click=on_click class="is-primary">"Click Me: " {count}</BButton>

When looking into the view code in BButton, it looks just right
class=format!("button {}", class.get())

but it does not expand to something in the browser.
This may be of interest ?
https://github.com/leptos-rs/leptos/issues/735

Hi.
Sorry for the late reply.
I think I covered this in the last release.
You can check some examples here: https://leptos-bulma.fermyon.app/elements#button


Fixed ImageBitmap memory leak

Motivation and context
Resolved #7909
Resolved #7850
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[x] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[x] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

Bug Fixes

Addressed a significant memory leak issue by ensuring ImageBitmap objects are properly closed after use.
Updated various components to handle cleanup and termination of workers and instances correctly, preventing potential resource leaks.

Version Updates

Updated cvat-canvas to version 2.20.3.
Updated cvat-core to version 15.0.6.
Updated cvat-data to version 2.1.0.

Codecov Report
Attention: Patch coverage is 55.55556% with 20 lines in your changes missing coverage. Please review.

Project coverage is 83.46%. Comparing base (41476eb) to head (7c47dc9).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7995      +/-   ##
===========================================
- Coverage    83.47%   83.46%   -0.01%
===========================================
  Files          384      384
  Lines        40325    40356      +31
  Branches      3772     3779       +7
===========================================
+ Hits         33661    33684      +23
- Misses        6664     6672       +8

Components
Coverage Δ

cvat-ui
79.20% <55.55%> (-0.01%)
:arrow_down:

cvat-server
87.35% <ø> (ø)


Project Cant resolve File TK.CustomMap.UWP.xr.xml

Hi,
Im getting the below error when trying to build a Xamarin Forms UWP project
Payload file 'nuget\packages\TK.CustomMap\1.6.1\lib\uap10.0\TK.CustomMap.UWP\TK.CustomMap.UWP.xr.xml' does not exist.
Any suggestions as to what is causing this would be greatly appreciated
Shane

Same problem for me, any idea?


child component index not updated

Description:
In this playground is a parent with a child component. Parent renders a table and child renders the rows. parent maps the 'row' and 'index' to the child.
The child has a remove button that fires an event to the parent, passing along the index of the row to remove. The parent then removes the actual row from the data.
However the index is not adjusted when rows are removed, so the next remove operation removes the wrong row.
To produce, remove the first row, then try the last row, which isn't removed.
Versions affected:
edge

Ok, this shouldn't actually work as I thought. Otherwise mapped data will be changed.
To pass index, one should rather use @index!

I think this is a legit bug. Splicing the parent should update the index mapping on the children regardless of the source of the splice.

Yep, index models had a shuffle bug, which will be fixed on edge as soon as travis does his thing. Thanks for the report!


[Low] Docs: Error in inches to millimeters

The docs for splitTextToSize (http://raw.githack.com/MrRio/jsPDF/master/docs/module-split_text_to_size.html#~splitTextToSize)  specify, that one has to calculate 72 / 25.6 to use millimeters instead of inches.
I think it should be 72 / 25.4, since 1 inch is 25.4 millimeters, and not 25.6.

i  inspect the source code，it ues 72 / 25.4 that is inconsistent with its document.


tokenizer not detecting unterminated string literals

everything after initial double/single quotes are considered part of the string if no closing double/single quotes are found.

 uncaught unterminated string literal issue

fixed in this commit


Standardizing error messages from directives in the console

I'm adding some logic to the 'uif-icon' directive to check if the developer requested an invalid icon that isn't supported within the fabric fonts. If they didn't I'm logging an error to the console... Which brings up: how should we standardize this?
Long term I like how angular does it where they link to their site, but that's long term. I think now we just do something like:
'''
Error [ngOfficeUiFabric] fully-qualified-module - error summary: error detail (see more: link to MD file in master branch of repo located within the directive's folder / beside the directive itself)
'''
Seeking input @ngOfficeUIFabric/ngofficeuifabric-members

For me all good

Here's how it renders:

Looks nice. Should we consider this kind of validation for every typed/enumerated option, e.g. in spinner component I can have following logic:

if uif-spinner-size="large" - spinner is considered large
if uif-spinner-size="small" or uif-spinner-size without value or anything different than small or large, then I render small spinner.

Should I then consider only "small" and "large" as valid and throw error any other?

Looks good to me too. We will probably need more validation.

@jjczopek Personally I think so... anything that has deterministic options, if one out-of-bounds thing is thrown, it should throw an error in the log.

:+1:

closing the loop... used angular's $log instead of console.log ... the main demo shows it now & you can see it here in dev for now until next drop: https://github.com/ngOfficeUIFabric/ng-officeuifabric/blob/dev/src/components/icon/iconDirective.ts#L69-L74


feat: create a development environment

This PR doesn't do too much for us just yet, but is step 1 in a longer process that will introduce tests and better code quality
This PR

allows us to declare development tooling, via devDependencies
Adds a small bit of code style enforcement

I chose not to enable rules for quote type or quoted object literal props, as we use both styles, and doing so here is a lot of noise

Creates two github workflows that provide some token level of feedback to contributions

the lint job will fail if code is not valid javascript
the test job will be useless until we have tests, but when we do (and make the package.json test script run them, then GitHub will automatically run tests on push & PR

Create a jsconfig.json project config, for those who use VS Code, which provides type signatures for the Chrome / WebExtensions APIs

In the future, we can use this development environment to introduce a bundling/compiling process for generating releases, which means we can split up main.js into testable components. We can possibly also explore virtual DOM testing solutions, and inject parts of the code. It may also be possible to use a sandbox browser env, to actually test the extension's bootstrapping. (I haven't looked into any kinds of integration testing solutions for browser extensions, but I can only assume they exist.)

Thank you, I appreciate this and still benefit from a similar change to the timer bot environment.
When we get around to breaking up main.js we should be able to add a testing mechanism whereby we can feed in recorded json objects - such as a pre-hunt response and a hunt response. Or a convertible opening. No more waiting for horns / trap checks. And maybe we can add eruptions without having to actually hunt through eruptions to test it.

looks good to me, one question, why are there two checks with the same name? should we maybe name them differently?


Add real sense support for interactive face detection sample

Check the sample/interactive_face_detection folder for changes,
The sample now supports -i realSense to use real sense for object detection.

As the original code and first try for RS enabling, the code is just merged. We will review it after more code is available.


NO logs on MONO / Debian

Hello everyone,
I developed my webservice with VS 2019 on Windows 10 / Windows 2016, and NLog works very well.
Brought on Linux - Debian + Mono it does not write any log line in any way, even internally, below the configuration file.
Is there any compatibility problem?
Thanks for your suggestions / indications.

..............................

........

Hi, please check troubleshooting guide. If this is still an issue, please post the full internal log (trace level)

I used this statement in the nlog.config and internal log found that the correct authentication for writing to the folder was missing.


okay, use a btn instead of a styled link

I rule and have completed some work on Case Manager that's ready for review!
rather than fight with pseudo elements like visited, just use a dang button
It relates to the following issue #s:

Fixes #1632

godmode for iteration's sake


Remove console.log('fit')

Removed unnecessarily console.log for production usage.

No need. When you grunt all of console.* gone away.

Ok, but the .min,js version still contains it. (search for console.log in https://cdnjs.cloudflare.com/ajax/libs/fotorama/4.6.3/fotorama.min.js)

I'm seeing this as well.

Could it be that the minified file (fotorama.min.js) hosted by cloudflare was manually minified based on the official release¹, which is not minified (https://github.com/artpolikarpov/fotorama/issues/361) and has this console.log not commented?
¹ https://github.com/artpolikarpov/fotorama/releases/download/4.6.3/fotorama-4.6.3.zip

It is still present in fotorama-bower.

Thank you. When can we expect a new release?


get inquirer to accept input

some of the other starter code seems to have been messing with inquirer, I've commented it out for now


[Node] Searching with cosine metric segfaults on Ubuntu 22.04

Library language: NodeJS
OS: Ubuntu 22.04
Code:
await tbl.search(Array(1536).fill(1.2))
    .metricType("cosine")
    .limit(20)
    .execute()

})();

Bug: Segmentation fault (core dumped)

+1 on this
We're hitting the same segfault with ubuntu 22.04 after the first search in a cloud environment

@gsilvestrin
So we have two embeddings (rows) in our test. We're using "Xenova/all-MiniLM-L6-v2" for embeddings. It errors when we add .metricType(MetricType.Cosine) and search. The search returns but then segfaults.
The main thing is the Cosine search is segfaulting. "vectordb": "^0.1.8"

@Emsu , Are you able to send a simplified version of your code? We're unable to reproduce the error.


fix(button): support for wrapping text

Description
This update allows text wrapping within the Button component and updates the alignment of the label and icon when wrapping to conform with the design specs.

Fixes a previously introduced bug that disabled wrapping of lengthy text inside a Button. This removes the white-space property that prevented wrapping.

Updates styles so that buttons that contain a workflow icon have the correct icon and text alignment. Previously everything was vertically aligned center and the text was aligned center, which did not match the design in the case of wrapping text. See screenshots for reference to the design.
This is a significant change as the vertical flex alignment of the icon is now to the top/start instead of the center, and the design defined --spectrum-component-top-to-workflow-icon-* tokens are used for the spacing between the icon and the top of the component. While button is intended to be used with workflow icons, there were not previously any guidelines around not using UI icons and even SplitButton was using one---in order to support vertical alignment of any existing usage of UI icons, some additional CSS calculations were included to add some margin based on the difference between the height of the intended workflow icon size and the actual icon size used (now accessible through --spectrum-icon-block-size since the 6.0 core tokens migration of Icon).

Adds a "Wrapping" example to Storybook. This also has a Chromatic-only version with additional variations displayed.

CSS-621
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps

[x] Verify changes with design team [@jawinn]
[x] Button wrapping example exists in Storybook.
[x] Button without icon wraps and has centered text (like guidelines).
[x] Button with icon has icon aligned to the top of the component and text aligned to the left/start of the component. Matching "Design spec for wrapping behavior with icon" in screenshots.
[x] Wrapping behavior looks correct in right-to-left text direction.
[ ] Non-wrapping examples of the button with an icon have no visual changes.

Regression testing
Validate:

A legacy documentation page (such as accordion), including:

[x] The page renders correctly
[x] The page is accessible
[x] The page is responsive

A migrated documentation page (such as action group), including:

[x] The page renders correctly
[x] The page is accessible
[x] The page is responsive

Screenshots
Updated wrapping behavior (Storybook):

Chromatic view of Wrapping story that includes showing backwards compatible alignment of differently sized UI icons

Reference: design spec for wrapping behavior with icon

Previous behavior:

Reference: design spec for wrapping behavior without icon

To-do list

[x] I have read the contribution guidelines.
[x] I have updated relevant storybook stories and templates.
[x] I have tested these changes in Windows High Contrast mode.
[x] If my change impacts documentation, I have updated the documentation accordingly.
[ ] VRTs have been run and reviewed.
[ ] ✨ This pull request is ready to merge. ✨

This is ready for re-review. Storybook is updated and has a Chromatic-only template. I've updated the styles to support existing use of UI icons instead of Workflow icons to address my last comment, and have added some more explanation in the PR description.

This is ready for re-review. Storybook is updated and has a Chromatic-only template. I've updated the styles to support existing use of UI icons instead of Workflow icons to address my last comment, and have added some more explanation in the PR description.
I'm wondering if the alignment change should be marked as a breaking change. Or if it would be better to save that part of the change for Spectrum 2 ( @pfulton )?

I'm inclined to make it a breaking change and introduce it now.

FYI this one caught us by surprise over in Project X, we got unexpectedly wrapping buttons and misaligned icons!

We're disabling this wrapping behavior by default as it introduces bugs and putting it behind a [wrap] attribute for the fix. see PR https://git.corp.adobe.com/Horizon/hz/pull/89334


code changes for ceph-ansible task python 3 compatibility

Code changes:

Python 3 compatibility for ceph-ansible task.
Ship utility task is taken off from ceph-ansible.
Added ship utility task before ceph-ansible task in every test suite as per the changes in teuthology task.

please find the logs.
magna002: /home/sunnagar/teuth/18-06-20-1592537216-py3-ceph-ansible/teuthology.log


What branch should be used for PRs?

The readme isn't clear on which branch we should use as the base branch for PRs. The default branch in the repo is "main", but that branch is currently dozens of commits behind "release-6.1" and even more behind "main-6.1".

default branch is changed to main-6.1
please do any merge requests to it

Thanks!


Update aws-java-sdk-core to 1.12.590

About this PR
📦 Updates com.amazonaws:aws-java-sdk-core from 1.12.459 to 1.12.590
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #659.


Test Travis; DO NOT MERGE

I got an email from travis saying that master is broken, so I opened this to test it out.  That doesn't seem to be the case, so closing this out with no action.


Add mjear to contributors

Was removed from org admins by #376 and now automation fails because there
are still references in non-standard teams.

Alternative is to remove @mjear from the team 'Directors-PMs-Anchors' and to remove the complete team 'License Finder'.
Both teams are non-standard teams that are going to be deleted by #262.

I think it'd be fine to remove @mjear from that legacy team and to delete the License Finder team entirely.


Use json for storing js games

It would be much more compact and universal to store the games in json rather than as js code. The json library in python would turn native lists and dictionaries into functions json. This would also allow cross compatibility with native react mobile apps.

For js version, this is no longer relevant. As we want to eventually allow user uploaded files, I've written a php script to convert from ave to js, so games can be played as soon as they are uploaded.
In the scroggs branch, I have removed the compile during build completely.
Maybe we need to seperate the website version and the mobile js version, as they are diverging.

Regardless of that, compiling to JavaScript allows for somebody to embed arbitrary js code to run on the site. That shouldn't be allowed.

I'm going to put in a review stage when adding games so one of us checks them first to deal with this.

We should probably review. But json is still definitely a neater way of storing these games. Construction of it would be considerably easier and less prone to escaping errors. We simply construct the arrays in php and then run json_encode which is built into php for this exact reason. Json is the standard way to store and transmit this kind of data and would only require a few extra lines of code in game.js.
We need to do it anyway in order to transmit the game files to the mobile app, we should at least consider it to simplify the codebase.


Rename qiskit_ibm to qiskit_ibm_provider

Summary
Rename qiskit_ibm to qiskit_ibm_provider.
Details and comments
Solves https://github.com/Qiskit/qiskit-ibm-provider/issues/235

Will resolve conflicts as soon as https://github.com/Qiskit/qiskit-ibm-provider/pull/243 and https://github.com/Qiskit/qiskit-ibm-provider/pull/241 have been integrated.


Derivatives creation writing to wrong path

Steps to reproduce:

[ ] change config/initializers/curation_concerns.rb by setting a different derivatives path, for example, config.derivatives_path = '/opt/heliotrope/derivatives'
[ ] reindex to update existing derivatives (not sure this is necessary)
[ ] restart web server
[ ] upload a new file

Expected behavior:
New derivative is created in the new path defined by curation_concerns.rb
Actual behavior:
New derivative is created in the default path, which is RAILS_ROOT/tmp/derivatives; application looks for derivative in the new path defined by curation_concerns.rb; monograph show page cannot find thumbnail image and shows a link instead. If you copy the derivative from tmp/derivatives to the new path, the thumbnail appears without reindexing.

Per discussion with Justin, opened https://github.com/projecthydra-labs/curation_concerns/issues/691

I was able to recreate this issue and fix it simply by restarting resque-pool.
So:
Don't need to reindex.
Do need to restart the resque workers after config changes.

@acozine how do you restart the resque-pool?

@jmcglone: on the server, it's sudo service resque-pool restart; on a dev environment, you can use one of the rake tasks - e.g. QUEUE=* VERBOSE=1 rake resque:work. Make sure redis-server is running before you start up resque workers or a resque-pool.


Make 3rd party models parcelables

Hey.
I got a bit confused by the documentation, can you help me out please?
I have a jar library with some models that are shared between Java Spring and Android projects.
On Android I need to make them parcelable.
Can I use @ParcelClasses somehow to do it?

Yes, @ParcelClass will allow you to identify a bean for which Parceler to generate a Parcelable wrapper.  There is admittedly less configuration available since you can't annotate the bean, but out of the box it should follow the Java Serialization standard.

Hmm. For some reason just using @ParcelClass I'm my Application class with models coming from a jar didn't work. I'll try once again tomorrow.
Is it enough to use annotation once in Application class or i have to annotate every class where models are used?

It should be enough to use it once.

What about when I have library added as a source, can I still use @ParcelClass?

So far I get this when I use ParcelClass on models coming from a jar library
Error:Parceler: Unable to find read/write generator for type ....natives.elsie.model.article.Video for ...data.articles.model.VideoData.articleVideo

Issue is resolved – I forgot to include all the inner models as ParcelClasses


Provide means to get via properties file groupID, artifactid, and version   for implementations of *Application class.

A standard mechanism is needed for implementations of *Application class
to retrieve groupID, artifactid, and version from the standard (external)
properties file.
Example see file, demos/ws-bootable-jar-example/jaxws/src/test/java/org/jboss/jaxws/SoapWildflyBootableOpenShiftJarApplication.java
These lines should not be hard coded.
private String GROUPID = "org.jboss.intersmash";
private String ARTIFACTID = "jaxws";
private String VERSION = "0.0.1-SNAPSHOT";

The values should be retrievable from the properties file.
This enhancement needs to be generic so that any "key" can be specified
for retrieval.

Thanks for this issue, @rsearls - actually to me it looks like we don't need for the keys to be variable right?
I mean that this should be just a way for the runtime to be provided with G:A:V, hence I think only the values to be computed. BTW I think we should do something similar to https://github.com/Intersmash/intersmash/blob/main/deployments/intersmash-deployments-provider/src/main/java/org/jboss/intersmash/deployments/IntersmashSharedDeploymentsProperties.java

Actually I think this should be a generic utility with a method, getProperty(key) and
getProperties() which returns a map of key/value pairs.   This will allow users to more easily customize the *Application classes.
Why not consider using some MicroProfile impl.


Spring Layout 2

Description
Layout 2 of the deployed client website
Type of change

[ ] Bug fix
[x] New feature
[ ] Refactoring
[ ] Documentation

Problem
Briefly describe the root cause and analysis of the problem
Solution description
Describe your code changes in detail for reviewers.
Explain the technical solution you have provided and how it fixes the issue.
Tests
All unit tests pass?N/A
Builds successfully?
Yes
Attach screenshot of the expected result (e.g. UI of the website/ postman API call result/ database changes)

Provide steps in detail for reviewers to reproduce the expected result of the code changes.
Go to base2 folder under the scholly folder.
Using npm run dev, the layout can be run in development mode.
Relevant document/ link (if any)
Any related documents could help reviewers to review this PR
Risk
Identity the risk level (low, medium, high) and indicate which component(s) will be affected if bugs exist.

As discussed over Slack, please integrate into the existing base app. Closing for now.


[MISSING METHOD] executionsession endpoints

Describe the method you'd like
Whats the Repo API endpoint? - GET /executionsession
Ideally provide link to the method from Qlik's documentation - https://help.qlik.com/en-US/sense-developer/February2023/APIs/RepositoryServiceAPI/index.html?page=803
Possible alternatives?
(with the current state) are you able to find workaround? And what was it? - generic clients

closed with https://github.com/Informatiqal/qlik-repo-api/commit/425cbb275f78b884389ff3e9486982afe014ba20


Store pvals as log(pval)

It is possible for p-values from rejected null hypotheses (scipy.stats.binom_test) to be very small (< 1e-38) and therefore rounded when stored as a default float. An alternative would be to store the pval as as double. Alternatively, log(pval) could be stored, to save on memory.

Closed after #34


CancellationToken per request

As the documentation says
In ASP.NET Core SignalR, CancellationToken is passed for each invoke.

On the other hand, in TypedSignalR.Client, CancellationToken is passed only once when creating a hub proxy. The passed CancelationToken will be used for each invoke internally.

Why is it? In my application I store a long living client and use it for independent call chains.
It would be great if one could supply a CancellationToken for a specific request. It would be great if every method had a CancellationToken? cancellationToken = null parameter. If it is null, the request can use the global cancellation token (or combine the 2)
Is there a specific reason there is no per request cancellation token?
ps: This is such a great library, thank you for maintaining it!

There are several reasons, but the main one is that CancellationToken is usually unavailable as a parameter to methods defined on the server side. The basic idea of TypedSignalR.Client is that the server-side and client-side share the same hub and receiver interface. So, for example, the problem occurs in the following cases.
public interface IHub
{
    // Use CancellationToken.
    //     Note that you cannot actually write code like this.
    Task<int> Add(int x, int y, CancellationToken cancellationToken);
}

// client-side
//     This appears to be an unproblematic syntax.
//     Note that you cannot actually write code like this.
var hubProxy = hubConnection.CreateHubProxy<IHub>(cancellationTokenSource.Token);
var result = await hubProxy.Add(7, 99, cancellationTokenSource.Token);

// server-side
public class MyHub : Hub, IHub
{
    // SignalR Hub cannot handle this cancellationToken.
    public Task<int> Add(int x, int y, CancellationToken cancellationToken)
    {
    }
}

On the other hand, server-to-client streaming can handle CancellationToken on the server-side, so it is possible to write code like the following
public interface IStreamingHub
{
    // server-to-client streaming
    IAsyncEnumerable<Person> GetStream(CancellationToken cancellationToken);
}

// client-side
//     This code can be written.
var hubProxy = hubConnection.CreateHubProxy<IStreamingHub>(cancellationTokenSource.Token);
var stream = hubProxy.GetStream(cancellationTokenSource.Token);

I see, that's unfortunate... Thank you!

Note that if you call InvokeAsync on the SignalR client, pass a CancellationToken, and then Cancel the token, the cancellation will not propagate to the server-side. It only makes sense if you cancel before writing the serialized message to the connection is done. Therefore, passing a different CancellationToken for each call is not a good idea.
If you want to confirm that the cancellation does not propagate to the server-side, try the following example code.
public class UnaryHub : Hub
{
    private readonly ILogger<UnaryHub> _logger;

    public UnaryHub(ILogger<UnaryHub> logger)
    {
        _logger = logger;
    }

    public override Task OnConnectedAsync()
    {
        _logger.Log(LogLevel.Information, "OnConnectedAsync");
        return base.OnConnectedAsync();
    }

    public override Task OnDisconnectedAsync(Exception? exception)
    {
        _logger.Log(LogLevel.Information, "OnDisconnectedAsync");
        return base.OnDisconnectedAsync(exception);
    }

    public async Task<int> Add(int x, int y)
    {
        await Task.Delay(TimeSpan.FromSeconds(10), this.Context.ConnectionAborted);
        _logger.Log(LogLevel.Information, "UnaryHub.Add");
        return x + y;
    }
}

var connection = new HubConnectionBuilder()
    .WithUrl("http://localhost:5105/Hubs/UnaryHub")
    .Build();

try
{
    await connection.StartAsync();

    var cts = new CancellationTokenSource();

    Console.WriteLine("InvokeAsync: Add");
    var task = connection.InvokeAsync<int>("Add", 22, 77, cts.Token);

    await Task.Delay(TimeSpan.FromSeconds(2));
    cts.Cancel();

    var result = await task;
    Console.WriteLine($"result {result}");
}
catch (Exception ex)
{
    Console.WriteLine(ex.Message);
}

Console.WriteLine("waiting");
await Task.Delay(TimeSpan.FromSeconds(10));

Console.WriteLine("StopAsync");
await connection.StopAsync();

Console.ReadLine();


feature: gopher count history

We can add a gopher count history stats.
from https://research.swtch.com/gophercount

I think this is can go into the "Fun Facts" section

I will send a CL


geological timescale ontology

There is an ontology for the geological timescale here https://github.com/CGI-IUGS/timescale-ont and a dataset representing the international chronostratigraphic chart nearby https://github.com/CGI-IUGS/timescale-data
The International Commission on Stratigraphy are planning to adopt this as the point-of-truth for the standard geological timescale.
related also: proposed Darwin Core Vocabulary Enhancement - ChronometricAge: https://github.com/tdwg/chrono/issues/15

Just confirming that indeed the International Commission on Stratigraphy are indeed planning on adopting this Geo Time Scale dataset and, in future, producing all Charts from it as automated reports.
This will take a while but we should get an English-only chart generated in the first quarter of 2021. Regards Nick (who is now Webmaster of the ICS)

tdwg/chrono is targeted for reporting numeric temporal coordinate locations; the Geologic time scale reports ages using time ordinal eras-- named intervals anchored in the rock record via GSSP.  The numeric temporal coordinates of the boundaries of those intervals are updated as new data become available.

we have incorporated Chronometric age in our new data model (see: https://github.com/DiSSCo/openDS/blob/master/data-model/fdo-type/digital-specimen/0.3.0/schema/chronometric-age.json)


add how to play instruction in landingpage

page - Index.html , add instruction that looks good as well

How can we run the repo?

How can we run the repo?

You can directly clone it and open the index.html. For simplicity, we have not used any frontend framework. The project is in the very infant stage.

Done! You have a new Pull Request :)

Thanks for your contribution @Michele971

Thanks for your contribution @Michele971


2024-12-17_01-36-47_master-next_python3-boto3

Automatically created.

Backport failed for kirkstone-next, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin kirkstone-next
git worktree add -d .worktree/backport-10793-to-kirkstone-next origin/kirkstone-next
cd .worktree/backport-10793-to-kirkstone-next
git switch --create backport-10793-to-kirkstone-next
git cherry-pick -x 2e0dbee9499fc21365cada51487ee7c4b5049aad

Successfully created backport PR for scarthgap-next:

#10798

Successfully created backport PR for styhead-next:

#10799


adding favorites

Thanks for creating and maintaining this very useful workflow.
I would like to add some favorites but I can't seem to figure out what you mean by rbsetup when you say "Run 'rbtsetup' and select "Set root config folder location".
Thanks in advance.

You have to open Alfred as you would normally (with your keyword, or whatever you use that triggers Alfred in normal use) and copy paste "rbtsetup" (without quotes) into that little window. You will then be presented with options. Follow the install instructions.
However, on Alfred 4, it's not working at all for me. Silently fails on "Modify sites configuration", making the workflow non-functional.
Would love if someone could fork and fix it.


Podman stops accepting terminal input

/kind bug
Description
Podman seems to intermittently corrupt the terminal somehow while running containers. Once this happens, any new containers will not accept any input or the detach keys. The only way to regain control is by stopping the container from another terminal. When the container exits, all the keys typed into it are dumped to the shell which then causes "command not found" or other errors depending on which keys had been pressed. This issue continues to happen for any new containers started in the same terminal window. Resetting the terminal doesn't fix it, but it can be fixed either by starting a new subshell or by closing the terminal window and opening a new one.
Steps to reproduce the issue:

Start a container attached to the terminal.

Use the container some and then exit it

Repeat steps 1-2 an indeterminate number of times. At some point a newly started container will not accept any input.

Stop the container from another terminal (podman stop -l)

Run any container in the original terminal window (Ex: podman run --rm -ti ubuntu) and see it still will not accept any input.

Additional information you deem important (e.g. issue happens only occasionally):
I have run across this multiple times while developing and testing various containerized apps. I believe it's happened in both root and rootless mode, but I mostly use rootless. Once the issue is triggered neither mode works in that terminal window as tested with:
podman run --rm -ti ubuntu and sudo podman run --rm -ti ubuntu.
Output of podman version:
Version:            1.8.0
RemoteAPI Version:  1
Go Version:         go1.10.1
OS/Arch:            linux/amd64

Output of podman info --debug:
debug:
  compiler: gc
  git commit: ""
  go version: go1.10.1
  podman version: 1.8.0
host:
  BuildahVersion: 1.13.1
  CgroupVersion: v1
  Conmon:
    package: 'conmon: /usr/libexec/podman/conmon'
    path: /usr/libexec/podman/conmon
    version: 'conmon version 2.0.11, commit: '
  Distribution:
    distribution: ubuntu
    version: "18.04"
  IDMappings:
    gidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
    uidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
  MemFree:<PHONE_NUMBER>2
  MemTotal:<PHONE_NUMBER>4
  OCIRuntime:
    name: runc
    package: 'runc: /usr/sbin/runc'
    path: /usr/sbin/runc
    version: 'runc version spec: 1.0.1-dev'
  SwapFree:<PHONE_NUMBER>
  SwapTotal:<PHONE_NUMBER>
  arch: amd64
  cpus: 4
  eventlogger: journald
  hostname: computator
  kernel: 5.3.0-40-generic
  os: linux
  rootless: true
  slirp4netns:
    Executable: /usr/bin/slirp4netns
    Package: 'slirp4netns: /usr/bin/slirp4netns'
    Version: |-
      slirp4netns version 0.4.3
      commit: unknown
  uptime: 4h 2m 22.21s (Approximately 0.17 days)
registries:
  search:
  - docker.io
  - quay.io
store:
  ConfigFile: /home/computator/.config/containers/storage.conf
  ContainerStore:
    number: 40
  GraphDriverName: overlay
  GraphOptions:
    overlay.mount_program:
      Executable: /usr/local/bin/fuse-overlayfs
      Package: Unknown
      Version: |-
        fuse-overlayfs: version 0.7.6
        FUSE library version 3.4.1
        using FUSE kernel interface version 7.27
  GraphRoot: /home/computator/.local/share/containers/storage
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 14
  RunRoot: /run/user/1000/containers
  VolumePath: /home/computator/.local/share/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):
podman/unknown,now 1.8.0~7 amd64 [installed]

Additional environment details (AWS, VirtualBox, physical, etc.):
Ubuntu 18.04

I just ran across something that might help. After I had a container get stuck and stop accepting input, I stopped it in another terminal per usual as above. However, this time I tried running another podman command (that wasn't podman run), and this was the result:
$ podman container prune
WARNING! This will remove all stopped containers.
Are you sure you want to continue? [y/N] Error: error reading input: read /dev/stdin: resource temporarily unavailable
$

It wrote the prompt out, but never gave me a chance to pick yes or no, it immediately failed when it tried to read stdin. So that gives some more idea of how stdin is getting corrupted!

I just ran sh to clear the error so my terminal was usable again and I got this potentially relevant message:
user@host$ sh
$ sh: turning off NDELAY mode

Can you try clearing terminal configuration with reset to see if that resolves it? I'm wondering if some of the changes we make for terminal attach (setting raw mode, among a few other things) might be being set, but not cleared.

Resetting the terminal was the first thing I tried, sadly it doesn't help.

@computator @mheon Does this still happen with the latest versions of podman and conmon?

I haven't had it happen yet, but I haven't been using containers much in the last week or two and may just not have triggered it yet. I will update this if I run into it again.

Ok reopen if it happens again.


Multilingual fonts (or at least chinese)

I can't see any text with a different language dang it
NO MORE TOFU
Consider

OS default font lists (like ubuntu)
Options like

cm_unicode
noto-fonts

I'd rather not compile a list, but if I have to...

Looks like it's an issue with flatpak instead of system-wide. Firefox and element couldn't display it. hecc

Yep it's https://github.com/NixOS/nixpkgs/issues/119433. Darn.
Using workaround - https://github.com/NixOS/nixpkgs/issues/119433#issuecomment-1326957279


Handle docparas

Note: Do not merge until the base is merged https://github.com/stanford-crfm/helm/pull/1659

Can this be merged, or is this not needed any more?

We can close


[BUG] style customization not working

I'm pretty new to git hub issues, and English is not my native language so please excuse me if the wording is not that proper.
Problem
I'm trying to override the global font family of the theme using _override.scss described in the documentation. The file content is as follows.
@import url('https://fonts.googleapis.com/css2?family=Montserrat&display=swap');
$global-font-family: Montserrat, sans-serif;

But when I relaunch the site, I can see that the font Montserrat is requested (by looking at chrome developer tools), but the font is not set.
I also tried directly modifying the $global_font_family in _variables.scss in /themes/FeelIt/assets/css, but it seems only the title in the navbar header is changed. Looking at the generated scss files in /resources/_gen/assets, the font is still unchanged.
Environment
I'm working on macOS M1, Hugo is installed with homebrew, command hugo version gives the following result
hugo v0.88.1+extended darwin/arm64 BuildDate=unknown

I'm not sure which file I should modify. Any help would be appreciated.

Hello!
I was having the same issue, and I solved this by adding
@import "_override";
@import "_custom";

to "assets/css/home.scss" (see the change in my fork). Hope this helps!


Plugins register commands

Some plugins, have some actions that can be done, for example RSS have "Mark all as read" and "Refresh":

It would be awesome to be able to bind custom shortcuts to those actions, just like "Run in terminal" has: cmd + O

Can you not do this using System Preferences > Keyboard > Shortcuts?
I've not tried but I'd be surprised if it didn't work.


I cant seem to fifind out what to put in includeBuild("...") in the settings.Gradle

The library is somehow not recognized in code

In settings.gradle add below:
// Your relative path or absolute path
includeBuild('D:\\Git\\Omico\\androidx-compose-material3-pullrefresh') {
    dependencySubstitution {
        substitute(module("me.omico.lux:lux-androidx-compose-material3-pullrefresh")).using(project(":library"))
    }
}

In your app/library module's build.gradle add below:
dependencies {
    implementation 'me.omico.lux:lux-androidx-compose-material3-pullrefresh'
}


Second attempt to improve information on display: contents;

To accomplish the proposal in issue #4437

Seems reasonable. Thanks!


Make sure parent directory for gib.logImpactedTo exists

Noticed during development, The gib.logImpactedTo propertie does not work if the folder to save the log does not exist yet. Add a Check to test the parent folder of the Location and Create and directories if necessary. Add Catch  for SecurityException since it is possible creating directories or files could run into.

Respin of #708

Thanks @jmontanariSE!

This is part of 4.5.0 which I have released today.


glynn: command not found

I installed the gem and then tried to run glynn, but I get the following error:
-bash: glynn: command not found

Path issue it sounds like. What happens when you try this command:
which glynn

Closing as stale.

I'm having the same issue, I'm getting command not found: glynn
I am using zsh rather than bash, would this be an issue?
$ which glynn
glynn not found

This looks like an issue with your ruby installation and your PATH not including the path to gem executables.

Thanks for the reply, I have ruby installed locally at /Users/myname/.rbenv/shims/ruby and running ruby 2.2.3
My PATH is /Users/myname/.rbenv/shims:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
Is it better to have this installed at PATH /usr/local/bin/ ?
I use rbenv with bundler installed via homebrew.

Hi I decided to uninstall rbenv and bundler and just run ruby and gems via /usr/local/bin/ using sudo.
Probably not the best approach but I have Jekyll and Glynn now working.

You would need to add /Users/myname/.rbenv/bin to your PATH.


Divs not showing below nav

Hi, I just built a header/nav for the page using your demo, it works great but I can't get any content to show on the page below it. It appears right at top of the nav/header. I've tried sections, containers etc but nothing works. Is this something to do with the resets? I am using picnic.css from the root folder. Thanks

That is true, if you add the nav and in its fixed default position you'll have to add padding-top to the body or html. However, since the nav height can be variable AND you might not even include a nav, I leave that decision up to the devs since I don't want to mess with body's padding.
body {
  padding-top: 3em;
}

If that's not the issue, please feel free to reopen but add some code/jsfiddle example where I can see the issue.


CHANGECOMPANY in "Job Queue Entry".ScheduleTask

Can we have COMPANYNAME changed to CURRENTCOMPANY in the function ScheduleTask so we can enable a Job Queue Entry in another company?
Today it's not possible to loop through companies and enable job queue entries.

There is the event OnBeforeScheduleTask(Rec, TaskGUID);
you subscribe and do
TaskGUID :=
     TASKSCHEDULER.CreateTask(
            CODEUNIT::"Job Queue Dispatcher",
            CODEUNIT::"Job Queue Error Handler",
            true, **Rec.CURRENTCOMPANY** , "Earliest Start Date/Time", Rec.RecordId));

Would it work for you?

No. Note really. What I'm doing is that I'm managing Job Que Entries in multiple companies from one single company.
Let's say you have fetched stopped job queue entries into a temporary table from other companies and you want to schedule them, Then you can do CHANGECOMPANY for each record you have fetched and call JobQueueEntry.ScheduleTask as you loop throught the fetched records.
The problem is that in the function ScheduleTask "COMPANYNAME" is used instead of "CURRENTCOMPANY" so my CHANGECOMPANY in my exection loop has no effect.
If I do this change is works just perfect
TASKSCHEDULER.CREATETASK(
CODEUNIT::"Job Queue Dispatcher",
CODEUNIT::"Job Queue Error Handler",
//>>START
//TRUE,COMPANYNAME,"Earliest Start Date/Time",RECORDID));
TRUE,CURRENTCOMPANY,"Earliest Start Date/Time",RECORDID));
//<<STOP
With this change the function ScheduleTask is aware of the CHANGECOMPANY.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


SIL: More robust substituted function type lowering.

This change separates out the formation of the generic signature and
substitutions for a SIL substituted function type as a pre-pass
before doing the actual function type lowering. The only input we
really need to form this signature is the original abstraction pattern
that a type is being lowered against, and pre-computing it should make
the code less side-effecty and confusing. It also allows us to handle
generic nominal types in a more robust way; we transfer over all of
the nominal type requirements to the generalized generic signature,
then when recursively visiting the bindings, we same-type-constrain
the generic parameters used in those requirements to the newly-generalized
generic arguments. This ensures that the minimized signature preserves
any non-trivial requirements imposed by the nominal type, such as
conditional conformances on its type arguments, same-type constraints
among associated types, etc.
This approach does lead to less-than-optimal generalized generic
signatures getting generated, since nominal type generic arguments
get same-type-bound either to other generic arguments or fixed to
concrete types almost always. It would be useful to do a minimization
pass on the final generic signature to eliminate these unnecessary
generic arguments, but that can be done in a follow-up PR.
Addresses rdar://84827656 | SR-15254

@swift-ci Please test

@swift-ci Please test source compatibility

Build failed
Swift Test Linux Platform
Git Sha - b28984764cdf6ad08cdb34f40f8a39b9604c0945

Build failed
Swift Test OS X Platform
Git Sha - b28984764cdf6ad08cdb34f40f8a39b9604c0945

@swift-ci Please test

@swift-ci Please test source compatibility

@swift-ci Please test source compatibility


Fixing the UI of the homepage

This box looks bad. There is need of improvement in UI.
Please assign this to me I'll fix it. If possible add hackoctoberfest tags to it.

Assigned, you can start working now on this issue.
Do read the guidelines before contributing.
Thanks!

can you please add hackoctober fest tag to this?

@divyansharma001 Are you working on this issue?

Yes

Okay, don't forget to sync your fork regularly.

@AdityaSinha2305 If not done could you please assign this task to me

Hey @walkoverr I have assigned this issue, you can start working now.

I've already done PR to this https://github.com/AdityaSinha2305/ForkTheCaptcha/pull/61
Please review


New react state hook - useConverter

useConverter
React state hook that keeps track of the input and immediately generates the output based on the converter function.
Usage
import { useConverter } from 'react-use';

const Demo = () => {
  const [input, setInput, output] = useConverter((data) => btoa(data), 'Hello World');

  return (

      <textarea value={input} onChange={(event) => setInput(event.target.value)} />

{output}

  );
};

Checklist

[x] Perform a code self-review;
[x] Read the Contributing Guide;
[x] Comment the code, particularly in hard-to-understand areas;
[x] Add documentation;
[x] Add hook's story at Storybook;
[x] Cover changes with tests;
[x] Ensure the test suite passes (yarn test);
[x] Provide 100% tests coverage;
[x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure;
[x] Make sure types are fine (yarn lint:types);

Hello friends!  Could you please elaborate a useful scenario in which this comes handy? Thanks"

i don't see the point of this hook tbh. Could you please elaborate a useful scenario in which this comes handy? Thanks

Initially, I developed this hook for our team's markdown editor. In it, the hook allows you to enter the markdown code in real time in one place of the editor and immediately see the result in the second place. An example of similar work can be seen here - https://dillinger.io
Code example (markdown editor):
import React, { useMemo } from 'react'
import Markdown from 'markdown-it'
import Highlight from 'highlight.js'
import Preview from '../components/Preview'
import Editor from '../components/Editor'
import useConverter from './useConverter' // our hook

export default () => {
  const { render } = useMemo(() => {
    return new Markdown({
      highlight: (str, lang) => {
        if (lang && Highlight.getLanguage(lang)) {
          try {
            return Highlight.highlight(lang, str).value
          } catch (__) {}
        }

        return ''
      },
    })
  }, [])

  const [input, setInput, output] = useConverter((data) => render(data), '# Markdown Source Code')

  return (

      <Editor value={input} onChange={setInput}/>
      <Preview value={output}/>

  )
}

Also, our team in our projects often uses a similar hook to implement dynamic elements that allow you to enter data into input fields and immediately output the processed result based on the entered data. These elements are often components of searches, filters, sorts, etc.

Reading the docs, it's not clear what the second argument is for

Reading the docs, it's not clear what the second argument is for

Added jsdoc for hook args

Feedback pls


Maps as parameter should be implemented

At the moment there is no concept to work with maps

It is not clear how to create the map. Will need a key-extractor and a value-extractor. This makes probably another annotation necessary.

Maps are still possible as parameter at the emulated interface. To extract maps from the protocol is quite complex as noted above.


RBAC Support

Feature request to have MLFlow Operator support RBAC. Currently, with the deployment of Charmed MLFlow and MariaDB, all users can see other users data. It would be ideal to be able to segregate data access.

Thanks Camille.
We have a similar situation.
We split our data scientist in 2 different teams.
The training artifacts (metrics, checkpoints, numpy array, etc) generated by team 1 during a RUN execution, and stored in MLFlow under that RUN, cannot be access by team 2, and vise verse.
It seems that an MLFLow authorization plug-in does not exist.
Are there any plans to implement it?

Thanks a lot for the feedback @DomFleischmann

I haven't looked into this in a while, but in the past I believe user isolation for metadata within MLFlow was not possible.  iirc, at least in the open source version of mlflow, there were no provisions for this.  I've seen this solved by deploying multiple instance of mlflow, one for each team/isolation group.  I think a mixture of that plus some RBAC control or istio (authorization policies?) could effectively achieve this

@ca-scribner , @i-chvets - is this something you looked at after?
@misohu , will the new version of MLFlow cover this? cc: @marowid  @Barteus

@ca-scribner I do not think that this is true. Upstream mlflow allows for RBAC segregation, this is the current setup in one external environment.

@andreeamun I don't think we have RBAC in our spec for new MLflow. At least not explicitly.

@camille-rodriguez , I just checked, but it is not supported in the upstream yet either: https://github.com/mlflow/mlflow/issues/7347


Remove runner boilerplate

We will create a new dangerfile next to existing dangerfile, so user don't have to implement Danger.setUp.
So, we can reduce boilerplate from
void main(List<String> args, dynamic data) {
  Danger.setup(data);
  message('Hello World');
}

to
void main() {
  message('Hello World');
}

It seems that we need to change default dangerfile location to bin/dangerfile.dart or tool/dangerfile.dart, to enable debug dart code inside flutter project.
https://github.com/Dart-Code/Dart-Code/issues/3286

Maybe remove --debug and let vscode enable debugging.


[Issue 2608] Add ability to periodically persist hot states

PR Description
Add an option to periodically persist hot states.  This is intended to help us avoid reprocessing long chains of blocks when regenerating states.
Fixes #2608
Documentation

[x] I thought about documentation and added the documentation label to this PR if updates are required.

Am I right in thinking that currently this is only applied to regenerations after we're up and running?  So we'd still replay every block at startup.  Would be worth a follow up PR to avoid that regeneration if storing states is enabled - just need to make sure when ProtoArray inits that it takes advantage of the stored states too.

Am I right in thinking that currently this is only applied to regenerations after we're up and running? So we'd still replay every block at startup.

Yeah - disabling the replay at startup will be a follow-up PR.  Should be pretty straightforward to implement on top of this PR.

Added a follow-up ticket to disable block processing at startup: https://github.com/PegaSysEng/teku/issues/2615


while setup

while setting up project i am getting an error at enabling extension "pg_trgm" .Insufficient priviliges even though i am superuser.

Could you provide more info? What OS are you on, what Ruby version are you on, and what Postgres version are you running?

Hi sry for for late reply.I am using ubuntu-18.04,ruby-2.6.3,postgres-11.x

after disabling the enable extension 'pg_trgm'. rails db:setup worked but i think its very much needed

The Postgres user it runs the migrations as should have the same name as the operating system user that initialized the database.
So you need to give likith Super User permissions with ALTER ROLE likith SUPERUSER :)


cleanup(scap): extend scap machine info (new metrics 1/n)

Signed-off-by: Melissa Kilby<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Migrating some lookups useful as identifiers and for new resource utilization metrics from Falco to libscap.
additional machine related info useful for:

host attributions
host kernel attributions
identifiers for new resource utilization metrics logs

scap_machine_info seems a suitable place for new lookups.
https://github.com/falcosecurity/falco/pull/2333
https://github.com/falcosecurity/falco/issues/2222
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

cleanup(scap): extend scap machine info

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for the great initial feedback @gnosek and @jasondellaluce - I see the complications here, let's change it. I wasn't sure anyways where to put this data and how to best expose it with the bigger scap cleanup picture in mind. I like all of your suggestions, @gnosek I'll coordinate with you.

Addressed initial feedback. Small follow up question if I may: Given that scap_machine_info fields unfortunately are a scarce resource plus the type limitations is it ok to keep self_pid_ts_epoch in there? Because would be open to just add it to libsinsp as simple getter? Also uname_r got purged, we can keep it in Falco right where we generate the new resource utilization logs.

Addressed reviewers comments including the request to cleanup machine_info retrieval via a clean function.
Would adding the new proposed scap_agent_info work? Could be that it may come in handy in the future for extensions, especially because of the limitations of scap_machine_info because of the scap files.
Plus because of the boot time hiccup decided to retrieve start_time from the agent stat file in order to base CPU usage calculations on that without needing to rely on procfs time stamps, but I kept that metric too so we can report a constant start timestamp of the agent as it should work on most systems.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [incertum,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: b36581820ae161c291a816f4a29e25ef1fa06605


Invalid hook call. Hooks can only be called inside of the body of a function component.

Trying to duplicate this issue, a lot of time and didn't get it can you describe how you get it


Collapsed

how sidebar Collapsed

Do you mean hide sidebar like #3 ？

This menu looks great but I agree with all 3 issues the one thing you are missing is the ability to hide the menu. Like in this demo here:  http://www.primefaces.org/atlantis/

see #3


Conditionally load markets in log handlers

Clubhouse Story

Do bot merge this. I’m checking that market reporting state gets updated correctly.


Allow using Enter/Escape/- to navigate the filesystem structure

There's little downside to supporting these common and probably expected keybinds.

Let's save these binds for other actions. The current navigation works well.


reference types - synch with CVE v5?

CVE v5 now has:
https://github.com/CVEProject/cve-schema/blob/master/schema/v5.0/tags/reference-tags.json
"enum": [
    "broken-link",
    "customer-entitlement",
    "exploit",
    "government-resource",
    "issue-tracking",
    "mailing-list",
    "mitigation",
    "not-applicable",
    "patch",
    "permissions-required",
    "media-coverage",
    "product",
    "related",
    "release-notes",
    "signature",
    "technical-description",
    "third-party-advisory",
    "vendor-advisory",
    "vdb-entry"
]

Should we sync with them?

OSV currently has:
        "enum": [
          "ADVISORY",
          "ARTICLE",
          "DETECTION",
          "DISCUSSION",
          "REPORT",
          "FIX",
          "INTRODUCED",
          "GIT",
          "PACKAGE",
          "EVIDENCE",
          "WEB"
        ]

And to complicate matters, OSV uses these as a string, so you have to pick one, and CVE v5 uses an array so they're tags.
So question: what is the OSV hierarchy of importance for the reference classification? E.g. is ADVISORY more important than EVIDENCE?
We (GSD) will simply be adding a "tag": [] to our references to support all these data tags. Can I submit a PR for this for OSV?

The intention of the type field in the references section in OSV is to help humans and frontends roughly categorise links.  There is no intention to model this in exactly the same way that CVE has.


new param in function

Description
new param in function
Fixes CCXDEV-7859
Type of change
Please delete options that are not relevant.
Testing steps
Please describe how the change was tested locally. If, for some reason, the testing was not done or not done fully, please describe what are the testing steps.
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report

Merging #249 (c2c37d6) into master (ca4e43d) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   90.85%   90.77%   -0.08%
==========================================
  Files          34       34
  Lines        1137     1138       +1
==========================================
  Hits         1033     1033
- Misses         89       90       +1
  Partials       15       15

Impacted Files
Coverage Δ

tests/helpers/rules.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4e43d...c2c37d6. Read the comment docs.


Wrong proxy documentation

In the current documentation it is suggested that you configure the proxy using a path as key. I could only get it to work when you pass it an array of objects like this:
proxy: [{
      path: new RegExp('/api/(.*)'),
      rewrite: rewriteUrl('/api/$1'),
      target: 'http://localhost:9000/'
    }],

You can edit the documentation with the button on the top right corner.

This issue was moved to webpack/webpack.io#150


  Its cachedValue is stored in cachedHashCode.  That in turn makes use of a method than can be overridden to calculate the value when necessary: calculateHashCode.

If this passes the processors tests, it will be deployed locally for reach and tested.  Please don't merge yet.  In addition, several reviewers will be tagged.

This code seems to pass all the processors, reach, and eidos tests.

I was going to ask whether I should merge this and then make a release.  I may have permissions from Sonatype to do a release, but not from GitHub to merge.  Perhaps, however, I should leave Processors to someone else anyway and just do those for Eidos.  When this one is eventually available, I can complete the Eidos changes so that we're not reading one document per line on files that come from PDF conversions.

It looks like I have some new permissions, so I'll be figuring out how to release this.  The change log will be updated, release incremented, a tag created, etc.


Tune default feature configs

I'm somewhat at a loss as to what should be the default settings. I assume we consider fbank as the go-to feature extractor. The options I see:

if we want fbank to resemble mfcc-hires from Kaldi (AFAIK the only difference is DCT for storage and IDCT as the first NN layer?), we can set num_mel_bins to 40 (which is what I committed now)
ESPnet uses 80-dim fbank for their models - but IDK if that makes a significant difference in results...

Any of these is probably better than the Kaldi default of 23 Mel bins which I don't think is used anywhere.
Also, I left Kaldi's default 23 num_mel_bins and 13 num_ceps for MFCCs.
@danpovey WDYT?

Codecov Report

Merging #82 into master will decrease coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   92.96%   92.75%   -0.22%
==========================================
  Files          37       37
  Lines        2614     2538      -76
==========================================
- Hits         2430     2354      -76
  Misses        184      184

Impacted Files
Coverage Δ

lhotse/features/fbank.py
100.00% <100.00%> (ø)

test/cut/test_padding_cut.py
100.00% <100.00%> (ø)

test/dataset/test_unsupervised_dataset.py
100.00% <100.00%> (ø)

lhotse/features/spectrogram.py
90.32% <0.00%> (-0.31%)
:arrow_down:

test/cut/test_feature_extraction.py
96.92% <0.00%> (-0.22%)
:arrow_down:

lhotse/augmentation.py
91.07% <0.00%> (-0.16%)
:arrow_down:

lhotse/utils.py
82.72% <0.00%> (-0.16%)
:arrow_down:

lhotse/features/mfcc.py
96.77% <0.00%> (-0.11%)
:arrow_down:

lhotse/audio.py
96.47% <0.00%> (-0.10%)
:arrow_down:

lhotse/cut.py
89.23% <0.00%> (-0.08%)
:arrow_down:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7985b4...5f9ee13. Read the comment docs.

The defaults you are using seem OK to me.  I don't think the difference between 40 and 80 tends to be consistent.
I think people can override the default if they care.


envoy_apply_resources_failed  vhds: only 'DELTA_GRPC' is supported as an api_type

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: envoy_apply_resources_failed  vhds: only 'DELTA_GRPC' is supported as an api_type
Description:

First of all, we statically configured ads's API type as DELTA_GRPC.

dynamic_resources:
  ads_config:
    api_type: DELTA_GRPC
    transport_api_version: V3
    grpc_services:
      - envoy_grpc:
          cluster_name: xds_cluster

Then, we use rds to get RouteConfiguration with vhds configured. The vhds config_source is set to ads.
we expect the vhds would take effect, but envoy failed to apply it  and report error:
"2022-09-27 09:08:39.841623|WARN|-|1:0:203|-|server.go:819|-:xds.(*DiscoveryServer).shouldRespondDelta|-|envoy_apply_resources_failed|-:-|error_detail=code:13 message:\"vhds: only 'DELTA_GRPC' is supported as an api_type.\"

Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

Note: The Envoy_collect tool
gathers a tarball with debug logs, config and the following admin
endpoints: /stats, /clusters and /server_info. Please note if there are
privacy concerns, sanitize the data prior to sharing the tarball/pasting.

Admin and Stats Output:

Include the admin output for the following endpoints: /stats,
/clusters, /routes, /server_info. For more information, refer to the
admin endpoint documentation.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Config:

Include the config used to configure Envoy.

dynamic_resources:
  ads_config:
    api_type: DELTA_GRPC
    transport_api_version: V3
    grpc_services:
      - envoy_grpc:
          cluster_name: xds_cluster

            - name: envoy.filters.network.http_connection_manager
              typed_config:
                "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
                stat_prefix: ingress_http
                rds:
                  route_config_name: "outbound_route"
                  config_source:
                    ads: {}
                http_filters:
                  - name: envoy.on_demand
                    typed_config:
                      "@type": type.googleapis.com/envoy.extensions.filters.http.on_demand.v3.OnDemand
                      odcds:
                        source:
                          resource_api_version: V3
                          ads: {}
                        resources_locator:
                        timeout: 5s
                  - name: envoy.filters.http.router
                    typed_config:
                      "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router

Logs:

Include the access logs and the Envoy logs.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Call Stack:

If the Envoy binary is crashing, a call stack is required.
Please refer to the Bazel Stack trace documentation.

seems like envoy only send vhds request when we use rud to get a RouteConfiguration through rds.
// Schedules a VHDS request on the main thread and queues up the callback to use when the VHDS
// response has been propagated to the worker thread that was the request origin.
void RdsRouteConfigProviderImpl::requestVirtualHostsUpdate(
    const std::string& for_domain, Event::Dispatcher& thread_local_dispatcher,
    std::weak_ptr<Http::RouteConfigUpdatedCallback> route_config_updated_cb) {
  auto alias = VhdsSubscription::domainNameToAlias(
      config_update_info_->protobufConfigurationCast().name(), for_domain);
  // The RdsRouteConfigProviderImpl instance can go away before the dispatcher has a chance to
  // execute the callback. still_alive shared_ptr will be deallocated when the current instance of
  // the RdsRouteConfigProviderImpl is deallocated; we rely on a weak_ptr to still_alive flag to
  // determine if the RdsRouteConfigProviderImpl instance is still valid.
  factory_context_.mainThreadDispatcher().post([this,
                                                maybe_still_alive =
                                                    std::weak_ptr<bool>(still_alive_),
                                                alias, &thread_local_dispatcher,
                                                route_config_updated_cb]() -> void {
    if (maybe_still_alive.lock()) {
      subscription().updateOnDemand(alias);
      config_update_callbacks_.push_back({alias, thread_local_dispatcher, route_config_updated_cb});
    }
  });
}

if we skip rds and configure vhds statically, envoy won't do anything for vhds.  requestVirtualHostsUpdate is an empty method.
/**
 * Implementation of RouteConfigProvider that holds a static route configuration.
 */
class StaticRouteConfigProviderImpl : public RouteConfigProvider {
public:
  StaticRouteConfigProviderImpl(const envoy::config::route::v3::RouteConfiguration& config,
                                Rds::ConfigTraits& config_traits,
                                Server::Configuration::ServerFactoryContext& factory_context,
                                Rds::RouteConfigProviderManager& route_config_provider_manager);
  ~StaticRouteConfigProviderImpl() override;

  // Router::RouteConfigProvider
  Rds::ConfigConstSharedPtr config() const override { return base_.config(); }
  const absl::optional<ConfigInfo>& configInfo() const override { return base_.configInfo(); }
  SystemTime lastUpdated() const override { return base_.lastUpdated(); }
  void onConfigUpdate() override { base_.onConfigUpdate(); }
  ConfigConstSharedPtr configCast() const override;
  void requestVirtualHostsUpdate(const std::string&, Event::Dispatcher&,
                                 std::weak_ptr<Http::RouteConfigUpdatedCallback>) override {}

private:
  Rds::StaticRouteConfigProviderImpl base_;
  Rds::RouteConfigProviderManager& route_config_provider_manager_;
};

https://github.com/envoyproxy/envoy/pull/13463  seems meant to fix this, but not merged.

@adisuissa @htuch for comments.

Paging #13463 back in, I think the key point is https://github.com/envoyproxy/envoy/pull/13463#issuecomment-707876654. @Agent-Tao any thoughts here?


Recurring Donation Rollups fail to update when the Opportunity stage is changed from Closed/won to Closed/Lost

First Reported in this Hub Post.
When the opty record is changed from Closed/Won to Closed/Lost, the Total Paid and Total Paid Instalments don't reduce in number as they should.
Steps to reproduce:

Create Open Ended Recurring Donation
Change two of the related donation records to Closed/Won. Notice RD fields are updated to reflect two paid donation records.
Change one donation from Closed/Won to Closed/Lost. Notice the RD fields aren't updated to reflect only one is paid.

**lurch: add

Here's the line with the issue, we just need to add another conditional for o.isWon != oppOld.isWon and a new test.

**lurch: add

Tracking W-024760

We are closing this issue because we will not be updating the old Recurring Donations functionality. We will be making all updates to our new Recurring Donations functionality. We recommend that customers evaluate the new features and upgrade when it makes sense for their organization. https://powerofus.force.com/s/article/NPSP-Enhanced-RD-Upgrade-Guide