Several bugs / comments

verifyCode discrepancy bug
verifyCode()'s 3rd argument, $discrepancy is specified in units of 30s (so a discrepancy of 1 calculates codes for -1, 0, 1 timeslices e.g. your device's time and the server can be off +/- about 45 seconds in both directions on average or 1m30s worst-case). A $discrepancy of 2 should calculate for -2, -1, 0, 1, 2. However, the loop iterator $i is added by increments of 1. The code in the verifyCode() method is currently:
$calculatedCode = $this->getCode($secret, $currentTimeSlice + $i);

It should read:
$calculatedCode = $this->getCode($secret, $currentTimeSlice + ($i * 30));

getQRCodeGoogleUrl url encoding bug
The method getQRCodeGoogleUrl() encodes the string incorrectly:
$urlencoded = urlencode('otpauth://totp/'.$name.'?secret='.$secret.'');
return 'https://chart.googleapis.com/chart?chs=200x200&chld=M|0&cht=qr&chl='.$urlencoded.'';

Should read:
$url = 'otpauth://totp/'.urlencode($name).'?secret='.urlencode($secret);
return 'https://chart.googleapis.com/chart?chs=200x200&chld=M|0&cht=qr&chl='.urlencode($url);

See KeyUriFormat for what should be encoded how. (Also: an Issuer value is "STRONGLY RECOMMENDED"' this should be easy to add/implement. I would also add support for the Algorithm, Digits, Counter and Period values which also should be easy to add/implement (even though the current Google Authenticator implementations still ignore some of them).
createSecret uses non-cryptographically secure RNG
Not exactly a bug but why not use a cryptographically secure RNG?
public function createSecret($secretLength = 16)
{
    $validChars = $this->_getBase32LookupTable();
    unset($validChars[32]);

    $secret = '';
    for ($i = 0; $i < $secretLength; $i++) {
        $secret .= $validChars[array_rand($validChars)];
    }
    return $secret;
}

Should/could be:
public function CreateSecret($length = 16) {
    $validChars = $this->_getBase32LookupTable();
    $secret = '';
    $rnd = openssl_random_pseudo_bytes($length);
    for ($i = 0; $i < $length; $i++)
        $secret .= $validChars[ord($rnd[$i]) & 31];  //Mask out left 3 bits for 0-31 values
    return $secret;
}

The left 3 bits are masked out resulting in values ranging from 0-31. Because we require a nice even 5 bits we can simply mask them out. I'm no security expert but should we need values in a range of 0-100 we can't use a nice 'whole' number of bits which usually results in people using a modulo 100 operation intruducing a bias towards some numbers. This should not be the case in this code since we require an 'exact' amount of 5 bits and simply discard the rest.
Also; there's no more need to unset the last element of the array (the padding char) since it is simply never referred to.
Boobies!
The getCode() method mentions a nipple in the comments; this should probably read nibble ;-)
Others

I haven't gotten around to the _base32Decode() method but that looks overly complex too (which is just a gut-feel, I won't know until I have had time to examine it more closely).

The _base32Encode() method is never used and should be removed.

Furthermore I'd suggest a new method getQRCodeImage($name, $secret, ...) that returns a data-uri so can easily embed an image in a page:

echo '<img src="' . $ga->getQRCodeImage('Test', $secret) . '">';

This method would return a string like:
data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAG8AAABvAQMAAADYCwwjAAAABlBMVEX///8AAABVwtN+AAABHklEQVQ4jdXTu7GGIBAF4OMQkEkDztAGmS1pA1dtQFsiow1mbEAzAse9i859RCzpz5h8BLB7ZIFPXIZoS7F1iiiKbKG2ZE9SMyrY72vfTWnnE2q4BXs4VckZGFBHqFXT/yIL5H5Xt/P3236BvBofTfgLs0DjadbdFDC+RxXZajSJbmcpyTTe3jo2nKSX2Xig70b+rUEmYGdHi+9+GiqRO81hgu4+igTUAa7fnl6mCZ3hJD0tQSa0PYNdCIOGyNblZBav3qrKBL+r/hkHVBDXFDhJzh8ijedbroaI3o6KzDvJHuCWZfKLnR0GnjXIzPPLd1FsdQXz/PKw013HJcUvdzXPOIjMSQZ19FEmV5UfwL5qmXl+OXkfx+eiMj9vfQNOb/aNopC1ZAAAAABJRU5ErkJggg==
Example
You could use PHPQRCode for this. The method would look something like this: (Refer to this post for more info)
public function getQRCodeImage($name, $secret, $size = 3, $margin = 4, $level = 'L') {
    require_once 'phpqrcode.php';

    ob_start();
    QRCode::png($this->getQRText($name, $secret), null, constant('QR_ECLEVEL_'.$level), $size, $margin);
    $result = base64_encode(ob_get_contents());
    ob_end_clean();
    return 'data:image/png;base64,'.$result;
}

This method refers to getQRText() which I simple refactored out of getQRCodeGoogleUrl to it's own method so both getQRCodeGoogleUrl and getQRText can use it.
private function getQRText($name, $secret) {
    return 'otpauth://totp/'.urlencode($name).'?secret='.urlencode($secret);
}

When the getQRCodeImage() would be implemented/added you'll gain the following benefits:

Solves Possible security problem
No more reliant on 3rd parties (granted, Google isn't down often but it CAN be; also see previous point: proxies/caches/whatevers could cause problems or even be an extra attack vector (MITM))
Saves at least one more HTTP request (the page is a bit bigger in terms of bytes but a roundtrip to a 3rd party is saved)
The image is harder to 'capture' for MITM's (not impossible) and not saved in browser caches, url histories etc.

Hope this helps.

Hi Rob,
I wrote this a long time ago, let's see:
Your first suggestion is not correct I think. $currentTimeSlice is a "slice", not a timestamp. This slice is a "range" of 30 seconds, see line 91, the current time is devided by 30. That's why "just" $i is added and not $i*30. So I think the current code is correct.
Your second comment would be correct if the otpauth://-URL would be directly used somewhere. But here it is added as a GET-Parameter to the Google-URL, that's why it has to be completely urlencoded. In your version you end up having two question marks in the resulting URL-string.
You are right regarding the additional parameter "Issuer" that should be added. The Counter is just used if the type is hotp, but we are doing totp here.
Your version of createSecret() adds an addition external dependency on OpenSSL. Not all systems have it installed. There is a nice Pull Request from Steve, he is only using openssl_random_pseudo_bytes() if it exists, otherwise he falls back to array_rand(), which I would say is a better solution:
https://github.com/PHPGangsta/GoogleAuthenticator/pull/10
Good catch regarding the "nipple" ;-)
You are right, _base32Encode() is not used in the current version of the code, I think it was used in one of the first (internal) versions before putting it on GitHub. It can be removed.
I'm not sure if I want to have an external dependency on PHPQRCode. It's of cause a good idea not to use Google and external HTTP requests, but it adds an external dependency to a library not being on GitHub as far as I can see (it's on sourceforge).
Thank you for your suggestions! I would like to hear from you!
Do you want to send a pull request regarding the "nipple" and "base32Encode()", or should I do the necessary changes?
Michael

Your first suggestion is not correct I think. $currentTimeSlice is a "slice", not a timestamp. This slice is a "range" of 30 seconds, see line 91, the current time is devided by 30. That's why "just" $i is added and not $i*30. So I think the current code is correct.

Looking over this again I see you are correct. Must've misread it or had one too many beer :stuck_out_tongue_winking_eye:

Your second comment would be correct if the otpauth://-URL would be directly used somewhere. But here it is added as a GET-Parameter to the Google-URL, that's why it has to be completely urlencoded. In your version you end up having two question marks in the resulting URL-string.

urlencode should always be used on single values. The parameters are all, and each, a single value that requires encoding. However, you then send the entire url as as single value (parameter) to Google. Because the entire URL is a single value it requires URLEncoding (again). You should be able to test/reproduce this quite easily.

You are right regarding the additional parameter "Issuer" that should be added. The Counter is just used if the type is hotp, but we are doing totp here.

I never implemented totp either so I left that one out too. It was just a suggestion (though I would also consider Algorithm and Digits) as I mentioned.

Your version of createSecret() adds an addition external dependency on OpenSSL. Not all systems have it installed.

That is a good, fair, point. I would, however, consider allowing a "pluggable" random-bytes-provider so people can easily provide the function with their own provider of choice (much like I support different QR code providers by providing a simple interface. I am by no means very skilled in PHP (I'm more of a .Net kinda-guy) so I wasn't aware that openssl_random_pseudo_bytes() isn't some "built-in BCL-sort-of functionality" but relies on Cryptography Extensions being installed.

There is a nice Pull Request from Steve, he is only using openssl_random_pseudo_bytes() if it exists, otherwise he falls back to array_rand(), which I would say is a better solution:

This could very well be. As said: I'm not much of a PHP guy so all I can say is that, to me, it at least looks better than the current implementation.

Good catch regarding the "nipple" ;-)

A dirty mind is a joy forever :stuck_out_tongue_winking_eye:

You are right, _base32Encode() is not used in the current version of the code, I think it was used in one of the first (internal) versions before putting it on GitHub. It can be removed.

Yay! :stuck_out_tongue_winking_eye:

I'm not sure if I want to have an external dependency on PHPQRCode. It's of cause a good idea not to use Google and external HTTP requests, but it adds an external dependency to a library not being on GitHub as far as I can see (it's on sourceforge).

As said: why not give people a choice. It's part of good SOLID design :stuck_out_tongue_winking_eye:

Thank you for your suggestions! I would like to hear from you!

Do you want to send a pull request regarding the "nipple" and "base32Encode()", or should I do the necessary changes?

By all means go ahead; I'm currently not in a position to do (well tested) PR's.

I guess all comments/ideas are either fixed/implemented by you or me ;-)


Error: getsockname EBADF

I don't understand the error, nor why I'm getting it.  The only reason I felt confident opening the issue is because the stack trace begins with is-online and ends with one of it's dependencies, which upon review has not been updated in 2 years...
Error: getsockname EBADF
    at Socket.address (node:dgram:764:11)
    at isListening (/home/zmg/Tinker/wiener/node_modules/dns-socket/index.js:283:19)
    at new DNS (/home/zmg/Tinker/wiener/node_modules/dns-socket/index.js:36:7)
    at DNS (/home/zmg/Tinker/wiener/node_modules/dns-socket/index.js:12:12)
    at queryDns (file:///home/zmg/Tinker/wiener/node_modules/public-ip/index.js:90:17)
    at file:///home/zmg/Tinker/wiener/node_modules/public-ip/index.js:213:22
    at queryAll (file:///home/zmg/Tinker/wiener/node_modules/public-ip/index.js:224:4)
    at publicIp.v4 (file:///home/zmg/Tinker/wiener/node_modules/public-ip/index.js:240:10)
    at file:///home/zmg/Tinker/wiener/node_modules/is-online/index.js:58:48
    at isOnline (file:///home/zmg/Tinker/wiener/node_modules/is-online/index.js:62:5)

Here's me calling it if it matters...
import React, {useEffect, useState} from 'react'
import isOnline from 'is-online'
import isReachable from 'is-reachable'

export function useHasInternet() {
  const [hasInternet, setHasInternet] = useState("loading")
  const [wienIsReachable, setWienIsReachable] = useState("loading")
  useEffect(() => {
    (async () => {
      setHasInternet(await isOnline() && await isReachable('https://weekinethereumnews.com') );
    })()
  } );

 return hasInternet
}

is-online is version 10
edit: related? https://github.com/sindresorhus/is-online/issues/47#issuecomment-602411439
I'm experiencing a core dump as well

Please ignore.  Above is likely  caused by an unhandled axios error.


1566 adding to InstrumentModelEnum and InstrumentVendorEnum for sequencing applications

This PR expands on the two enumerations to support sequencing based vendors and models.

wrong branch


Adding fileUpload feature to the CKEditor

Are we need to add this to the release changes?

i fixed the wording in the taglib and committed


Building tests fails

Hey,
I am facing issues building your tests.
I get the following error:   The module "./src/index.js" was not found on the file system.
I could monkey-patch it by adding the src folder from your uvu fork to node_modules/uvu.
Creating an nro also failed and I had to install and use nxjs-pack.
Thanks!

Can you outline the steps you are taking to build it? I typically do ./build.sh tests from the root of the repo, then upload the apps/tests/tests.nro file onto the Switch.

Note that nxjs-pack was renamed to nxjs-nro. Thus nxjs-pack is deprecated.

ah ok thanks for the info. When running the build script I get devkitpro error. I think I removed the toolkit a while ago. I will reopen the issue, when I find some time :)


Twitter for Mac doesn't work with Adguard

@Sam5883 commented on Wed Nov 18 2020
Steps to reproduce

Enable Adguard for Mac with auto proxy mode
Open twitter

Expected behavior

Twitter should load all tweets and timeline
Actual behavior

twitter cant load tweets, and if adguard is toggled of, twitter works again
Screenshot:

Your environment

Environment name and version: Adguard 2.5.1 release, macos big sur 11.0.1, twitter for mac <IP_ADDRESS>
Any specific potentially conflicting software installed: none.

@Chinaski1 commented on Thu Nov 19 2020
Hello Sam!
To troubleshoot this issue, we need to get the app logs.
Here's what we need you to do:

Menu -> Gear -> Advanced -> Logging level -> Debug;
Reproduce the issue (and remember the exact time when it happened);
Menu -> Advanced -> Export Logs and System Info...;
Send the archive to<EMAIL_ADDRESS>and mention this issue number in the subject.

Hello @Sam5883
Today I checked this issue on BigSur 11.2 Beta (20D5029f) and AdGuard <IP_ADDRESS>9 nightly (CL-1.7.153)

Download link: agrd.io/mac_nightly

I was able to use the Twitter app without any problems.
Could you please check so I can close this task?

Hello @Sam5883
Today I checked this issue on BigSur 11.2 Beta (20D5029f) and AdGuard <IP_ADDRESS>9 nightly (CL-1.7.153)

Download link: agrd.io/mac_nightly

I was able to use the Twitter app without any problems.
Could you please check so I can close this task?

Hello @Sam5883
Today I checked this issue on BigSur 11.2 Beta (20D5029f) and AdGuard <IP_ADDRESS>9 nightly (CL-1.7.153)

Download link: agrd.io/mac_nightly

I was able to use the Twitter app without any problems.
Could you please check so I can close this task?

Hello @Sam5883
Today I checked this issue on BigSur 11.2 Beta (20D5029f) and AdGuard <IP_ADDRESS>9 nightly (CL-1.7.153)

Download link: agrd.io/mac_nightly

I was able to use the Twitter app without any problems.
Could you please check so I can close this task?


Purview Share V2 C# SDK

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Analytics.Purview.Sharing

/azp run net - purview - ci


Angular npm Publish GH Action fails

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have read the contributing guidelines

Describe the issue
Error:
Cannot find module '@trimble-oss/modus-web-components' or its corresponding type declarations.
See logs here:
https://github.com/trimble-oss/modus-web-components/actions/workflows/publish-angular.yml
I don't know how to fix right now, but something to do with relative paths or something?
https://stackoverflow.com/questions/37548734/tsc-throws-ts2307-cannot-find-module-for-a-local-file
For now we need to publish manually via the CLI until this is fixed.

@cjwinsor Take a look for short and long term solution


Wrong documentation

Hi, I was following this doc to install self-hosted runtime, there is wrong command Get-AzureRmDataFactoryV2IntegrationRuntimeKey -> fix it to Get-AzDataFactoryV2IntegrationRuntimeKey.
Next there is missing last step 4 in paragraph High-level steps to install a self-hosted IR to put key into runtime

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32785d15-8202-6e44-f1d2-420ef0600f3f
Version Independent ID: 3af5fa49-7bd4-18ce-f8dc-aa4a2b8c6478
Content: Create a self-hosted integration runtime in Azure Data Factory
Content Source: articles/data-factory/create-self-hosted-integration-runtime.md
Service: data-factory
GitHub Login: @nabhishek
Microsoft Alias: abnarain

@jjindrich Thanks for your contribution, I've addressed this issue in PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/74664.
The changes should be live EOD or tomorrow. In future, if you see any minor bug fixes in the doc, feel free to click on the edit button and submit a PR to update. we love to take community contributions.
About the missing steps: The complete steps are mentioned here: https://docs.microsoft.com/en-us/azure/data-factory/create-self-hosted-integration-runtime#install-and-register-self-hosted-ir-from-the-download-center

Thank you.
From: CHEEKATLAPRADEEP-MSFT<EMAIL_ADDRESS>Sent: čtvrtek 25. dubna 2019 11:49
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Jaroslav Jindrich<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Wrong documentation (#30047)
@jjindrichhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjjindrich&data=01|01|jaroslav.jindrich%40microsoft.com|064e9f64848c4a91e75b08d6c963344c|72f988bf86f141af91ab2d7cd011db47|1&sdata=VRQZOxbdUN%2Ba56Vb67cRhbVIz4HV5p0ry8K%2BQYJAuPU%3D&reserved=0 Thanks for your contribution, I've addressed this issue in PR: MicrosoftDocs/azure-docs-pr#74664https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs-pr%2Fpull%2F74664&data=01|01|jaroslav.jindrich%40microsoft.com|064e9f64848c4a91e75b08d6c963344c|72f988bf86f141af91ab2d7cd011db47|1&sdata=ouxur8lbRHzreN0XkVtepHeMh7n8JKI6%2BvpsuwGBWIM%3D&reserved=0.
The changes should be live EOD or tomorrow. In future, if you see any minor bug fixes in the doc, feel free to click on the edit button and submit a PR to update. we love to take community contributions.
About the missing steps: The complete steps are mentioned here: https://docs.microsoft.com/en-us/azure/data-factory/create-self-hosted-integration-runtime#install-and-register-self-hosted-ir-from-the-download-centerhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fazure%2Fdata-factory%2Fcreate-self-hosted-integration-runtime%23install-and-register-self-hosted-ir-from-the-download-center&data=01|01|jaroslav.jindrich%40microsoft.com|064e9f64848c4a91e75b08d6c963344c|72f988bf86f141af91ab2d7cd011db47|1&sdata=5SzCLK5D9KWyZECskZFP7SiCAZ2if6CwUXMq%2BRQMhaA%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F30047%23issuecomment-486604851&data=01|01|jaroslav.jindrich%40microsoft.com|064e9f64848c4a91e75b08d6c963344c|72f988bf86f141af91ab2d7cd011db47|1&sdata=pWhz1sGBlXZb6Z15%2Bfi8RSXskomYMD6E4kDQxUjh%2FLA%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADCAD6IYGXXEEECHD3LC3J3PSF47VANCNFSM4HIKERDQ&data=01|01|jaroslav.jindrich%40microsoft.com|064e9f64848c4a91e75b08d6c963344c|72f988bf86f141af91ab2d7cd011db47|1&sdata=tR4%2Fq7RF9i7V64xMTCEegupxQssYgZMuJ6yQUhqD%2BRk%3D&reserved=0.


Fails to convert to ico when bigger than 256x256, no message.

The conversion to ico fails when the image is bigger than 256x256 in size.
The backend doesn't tell the frontend (the user) about this, it just fails with the message "Couldn't encode image.".
This needs another error message about the reason why it failed.

Implemented with 25f0b8778bfd418cc1299d07d130447ead59aa9d


Drop ujson and switch to orjson

Implemented as requested in this comment:
https://github.com/python-lsp/python-lsp-server/pull/579#pullrequestreview-2206408333

TODO: I need to fix incompatibilities between json and orjson.

I came across this due to encountering some problems with ujson and took a stab at making the necessary updates in https://github.com/python-lsp/python-lsp-jsonrpc/pull/29. I cherry-picked @rumpelsepp's commit onto my branch so that it's correctly attributed.

Many thanks for taking care of this!


Adding Faucet Route

Adding the Faucet Route to dapp-console-api

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#365  👈
#363
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tarunkhasnavis and the rest of your teammates on  Graphite


fix: fix incorrect vertical alignment in text render

Description
The y argument in OIIO::ImageBufAlgo::render_text() should represent the top and bottom edge of the text if vertical alignment is set to TextAlignY::Top and TextAlignY::Bottom. However currently the rendered text is off. The current code adjusts y to point to the top of the text box before rendering the text, but it has to be adjusted to point to the baseline of the text.
Tests
There is a existing test case, testing vertical alignment, but the reference image seems wrong and has now been updated. See the "Topleft" and "Rightbot" texts.

Current
Fixed

Note: The testsuite contains a reference image for freetype v2.4.11 (aligned-freetype2.4.11.tif). I don't have that version built, and haven't been able to update the image. I'm wondering if this is still used or could be removed. I guess CI will tell.
Checklist:

[x] I have read the contribution guidelines.
[x] I have updated the documentation, if applicable. (Check if there is no
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
[x] I have ensured that the change is tested somewhere in the testsuite
(adding new test cases if necessary).
[x] If I added or modified a C++ API call, I have also amended the
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
[x] My code follows the prevailing code style of this project. If I haven't
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.

Lacking DCO sign-off, you'll need to add it ("git commit --amend -s" + force push).

Unless you have a strong objection, @peterhorvath111, what I'm thinking is that this fix will be for 3.0 only, not backported to 2.5. Although technically a bug fix, this very much changes behavior and image appearance that somebody might be relying on.

Unless you have a strong objection, @peterhorvath111, what I'm thinking is that this fix will be for 3.0 only, not backported to 2.5. Although technically a bug fix, this very much changes behavior and image appearance that somebody might be relying on.

Sure, that sounds reasonable.


Github Actions CLI deployment

Refactored to CLI deployment due to issues described in this issue: https://github.com/MicrosoftLearning/AZ400-DesigningandImplementingMicrosoftDevOpsSolutions/issues/565

I haven't seen anyone complaining about this recently, are you sure you still are facing the issue?

I ran into the equivalent in AzDo while testing last week. Both the GitHub action and AzDo task suffer from intermittent replication issues where the recently created app cannot be found. Looking at the upcoming v3 branch for the GitHub action, I don't see anything geared toward fixing this, but it might be considered a 'back end issue.'
I have tested @maartenvandiemen's fix, and it does work just fine.
I suppose my question to the team would be, do we want to have the ASP action as the default and make this something we could uncomment the AZ cli command if there is an issue, or switch to this completely?

I primarily face this issue in AzDO. Then we could change this lab as well. https://microsoftlearning.github.io/AZ400-DesigningandImplementingMicrosoftDevOpsSolutions/Instructions/Labs/AZ400_M05_L08_Configuring_Pipelines_as_Code_with_YAML.html
How are you looking towards this?
This issue related to this is already open for a while. I don't think this will be fixed soon

I think it would be good to keep both and one commented out

I think it would be good to keep both and one commented out

Instead if commenting out I disabled the step. With a  comment why this is done.

Thank you @maartenvandiemen for your patience and contributions. It's appreciated.


README: shared-code-entry instructions enhanced

Shared code as described in docs and sample repo only works for widgete in your-extensions. Instructions on shared-code resolution added for widgets from exb-web-extension-repos added.

@esride-nik Thanks for your contribution! Could you resolve the conflict so I can merge the PR?


Add standalone pending state provider function

Describe the feature
getting the Pending state as StateProvider currently requires:

find block hash of target block in tree
get PostStateDataProvider via 1.)
get StateProvider via 2.)

For RPC the ideal DX would be:
BlockId::Number(BlockNumberOrTag::Pending) => self.<>.pending()

ref
https://github.com/paradigmxyz/reth/blob/b9bab335e6834e0760bbab8fc5163b7e405afd39/crates/rpc/rpc/src/eth/api/transactions.rs#L93-L107
If you do this independently of a specific block, you could use self-created local blocks instead of blocks from CL.
Additional context
No response

Created getter for pending blocks, those are blocks that directly extend the canonical chain: https://github.com/paradigmxyz/reth/pull/2091

closed via #2294


Github action: more automations

We are wasting too much time with rustfmt and cargo update. I propose that we leverage github action to perform
these actions automatically. Doing a commit on the PR when:

not rustfmt correctly
not an up to date cargo.lock

Current limitations:
if the PR is created and immediately requested, it might cause problems but this should be rare enough

Would it make sense to run this on merge instead? I feel like it would be annoying to push a commit to a PR with a fmt violation, then make another commit without noticing the automatic fmt and having to reconcile the changes.

@tertsdiepraam
if you are talking about merge of the PR, why not but I found it a waste of time for everyone to fix rustfmt + Cargo in the PR.
And currently, I see too many PR with these kind of issues being unnoticed by the devs

Ah, I probably wasn't very clear. I was thinking that we could run this automatically on the merge of a PR, so the master branch is always formatted and has a refreshed Cargo.lock. Something like described here: https://brennerm.github.io/posts/trigger-github-actions-on-pr-close.html

Or, alternatively, only when pushed to master: https://github.community/t/trigger-workflow-only-on-pull-request-merge/17359/3
Running it on every commit is also fine with me if you prefer that!

oh, you were clear, don't worry ;)
My use case is:
how can I make sure that I don't waste time asking "can you please rust cargo fmt" and "can you run cargo update"
and on the merge request, it will do it but users will still have to do it when pushing
am i clear?

I'm sorry, I don't quite understand. You don't have to comment on it (might even disable the checks) if it is done automatically once the PR is merged, right? Although maybe the tests fail with an outdated Cargo.lock? In that case, it would make sense to the refresh on every commit.

oh, you are proposing that we aren't showing them anymore.
I missed that, sorry

I'd be more a fan of automating it on merge to 'master'.
Right now, it looks like it'll add two commits to each submitted PR, or any iteration on it.
Additionally, or alternatively, we could make them both hard failures on CI. Blocking CI failures would also condition people to format and update Cargo.lock where needed.
We might also want to shift to hard failures for spelling now that I've got it substantially cleaned up.

OK, I will update this PR then :)
I am not convinced that failing is a good use of our time as they can be automatically fixed by tools

OK, I will update this PR then :)
I am not convinced that failing is a good use of our time as they can be automatically fixed by tools

Yeah, I'm of mixed minds about it as well. When initially designing the CICD automation, I fell to the side of soft failures to allow better iteration flow. But the warnings keep accumulating. If we could automate it for any merge to 'master' that would seem to be the best of moth worlds. No?

I can't tell from the action documentation, but, I assume that if the formatting and Cargo.lock are correct and up-to-date that no additional empty commits will be added. Is that what you see/understand?

Yeah. No change needed, no commit
(and it was the initial behavior)

@sylvestre , @tertsdiepraam ,
I've produced a working version of this PR; see https://github.com/rivy-t/rs.coreutils/tree/change.CICD, 'change.CICD' branch. I've added you both as administrators to that repo so that you can play with it. It's a throw-away testing repo, so any changes, PRs, merges, etc. are fine.
I implemented a 'MergePR' based on @sylvestre's work that should only add fix commits for 'Cargo.lock' and code formatting if/when needed; these will be added into 'master' on top of the merge. Notably, there is no follow-up testing.
I'd prefer that this add on top of the PR before the merge but I don't see any way to trigger that without having it trigger on every PR commit (both initial and on iterative changes/updates, which could lead to a lot of additional commits).
I added a "Style/dependencies" step which will error if deps are out-of-date (eg, a 'Cargo.lock' issue).
Additionally, I changed all style warnings to errors and added instruction for fixing the error in the error message annotation. This should push submitters to fix their own errors prior to the merge so that the potential commits in 'MergePR' shouldn't be triggered. See https://github.com/rivy-t/rs.coreutils/actions/runs/934392459 for a run with example errors.
I added make test to the 'Build/Makefile' job.
I also refactored/renamed some sections of the existing workflows and improved comments, fixing all errors/warnings. On a "clean" submission, there should be only one warning annotation about the GNU BusyTests (and it should disappear if/when all the tests pass; see https://github.com/rivy/rs.coreutils/actions/runs/934392927 for a "clean" run).
Let me know what you both think...
I'll push it back to this PR if you think it's a contender.

@sylvestre , I'm going to push the changes to this PR if you're ok with that...

I think sylvestre mentioned in Discord that he's away until Friday. I could try to take a look at it later today, but I'm not really experienced with GH Actions, so I'm not sure I can help. Maybe you could push the changes and we can tweak it later if we don't feel it's right yet?

Hmm.
GitHub won't allow me to push to @sylvestre's cicd2 branch because it modifies the workflow and I don't have the 'workflow' scope privilege on his repo. I can close and re-open as another PR.
In the meantime, you can see and experiment with the current version on the rivy-t repo that I mentioned to get a flavor of how it's setup to work.

sure, @rivy  please open a new PR for this :)

sure, @rivy please open a new PR for this :)

Will do. I'm putting one together now.


Beta 6 fixes/improvements (2nd)

fixed bug in BrowserDOMElement
improved IsolatedNode step-into behavior
-> now uses TAB and tries to find first surface if no grabFocus() available

@andene can you try this out?

Yeah, it works with tab 👍

ping @oliver----

@andene ok. As soon everything is green I will merge this into master and publish as v1.0.0-beta.6.3

There is some stuff in surface-fixes, which may also go into beta.6.3. Can you check Oliver?

Will do


COMP-86: Create case file form

Codecov Report
Attention: Patch coverage is 26.96629% with 65 lines in your changes missing coverage. Please review.

Project coverage is 27.20%. Comparing base (87b1a39) to head (291c3ec).

Files
Patch %
Lines

...eb/src/components/App/CaseFiles/CaseFileDrawer.tsx
10.34%
26 Missing :warning:

...-web/src/components/App/CaseFiles/CaseFileForm.tsx
7.14%
13 Missing :warning:

compliance-web/src/hooks/useCaseFiles.tsx
47.05%
9 Missing :warning:

...c/routes/_authenticated/ce-database/case-files.tsx
14.28%
6 Missing :warning:

...mponents/Shared/Controlled/ControlledDateField.tsx
16.66%
5 Missing :warning:

compliance-web/src/store/drawerStore.ts
16.66%
5 Missing :warning:

compliance-web/src/utils/dateUtils.ts
66.66%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #35      +/-   ##
===========================================
- Coverage    27.53%   27.20%   -0.34%
===========================================
  Files           51       56       +5
  Lines          719      805      +86
  Branches       195      191       -4
===========================================
+ Hits           198      219      +21
- Misses         491      586      +95
+ Partials        30        0      -30

Flag
Coverage Δ

compliance-web
27.20% <26.96%> (-0.34%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can't get it to work

I have the following config:
		// configurable
		"rootDir": "src",
		"outDir": "out",
		"baseUrl": "src",
		"incremental": true,
		"tsBuildInfoFile": "out/tsconfig.tsbuildinfo",
		"plugins": [
			{
				"transform": "rbxts-transformer-setget",
			},
		]

but when I run npm run build I get this:
[file] - error TS roblox-ts: Getters and Setters are not supported!
More information: https://github.com/roblox-ts/roblox-ts/issues/457

11     public get isMoving(): boolean {
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
12         return this.a.attributes.isMoving;
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
13     }
   ~~~~~

[file] - error TS roblox-ts: Getters and Setters are not supported!
More information: https://github.com/roblox-ts/roblox-ts/issues/457

14     private set isMoving(isMoving: boolean) {
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
15         this.a.set("isMoving", isMoving);
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
16     }
   ~~~~~

Could you please try removing "incremental" and "tsBuildInfoFile" from your config?
incremental causes issues with this transformer and I have not added this to the readme.

Still does not work:
		// configurable
		"rootDir": "src",
		"outDir": "out",
		"baseUrl": "src",
		// "incremental": true,
		// "tsBuildInfoFile": "out/tsconfig.tsbuildinfo",
		"plugins": [
			{
				"transform": "rbxts-transformer-setget",
			},
		]

@Jack-Trent I have just updated both typescript and roblox-ts and it now works with incremental as well. Thanks for the quick response.


Minor FIX for topomap outlines:  set clip_on=False

I've noticed that the outlines on topomaps go right to the edge of the axes, which leads to the lines being cut off slightly. Setting clip_on=False is one possible solution, another would be increasing the axes limits, I am not sure if there are arguments against one or the other.

LGTM

Thanks


Connection Isuue

When me and my friend try to join each other's games (we've tried for both, and ip based) it doesn't work. It gives this message to the one joining.
"An error occurred: lobby does not exist"
But the server and game is running.
"Local Noita instance connected."

i hope you both can read this option, reopen if you still have an issue, dont use ip

I had that on, he might not have, but now its saying there was an error launching the mod in the Noita game


Perserve gamma calibration

It would be nice if xrainbow and grainbow read the current gamma ramps and restored them upon exiting.
Since the gamma settings are change so rapidly I do not think it is necessary to apply the effect beneath the gamma corrections, but if you want to be pedantic you should do that too. Doing so is a bit of work, you would have to apply your effects and then the gamma corrections on top of that using intropolation (that is, create a function like y = calibration(rainbow(x)).)

Now XRainbow restores the original gamma ramps. GRainbow already did that.
For now I won't implement the second bit you're talking about because I don't see a major benefit for the purpose of this application.

Okay.
No, I won't implement the second part either, it is way overkill for this, and should actually be display server's resonsibility. I hope that they one day support concurrent gamma-filters.


refactor: Various refactor [skip ci]

TODO:

[ ] Fix tests
[ ] Add missing tests

Tested and confirmed working with Docker.
cbf to add View tests atm. what could go wrong?


cannot find MainActivity

Trying to install the Android app on a connected Android 4.4 device. Got this error:
Starting: Intent { cmp=com.multunus.moveit/.MainActivity }
Error type 3
Error: Activity class {com.multunus.moveit/com.multunus.moveit.MainActivity} does not exist.
I did not change the application Id or package name.
Any idea??

@yidan621 Please give us a day to look into this.

@yidan621 We have some code here https://github.com/multunus/moveit-mobile/blob/master/android/app/build.gradle#L135-L145. It basically appends one of "dev" or "staging" to the package name. This is done so that both versions of the app can be installed on the same device.

Thanks for the quick reply!
It works now! I tried running it from Android Studio instead of the command line.
But when I tried registering, a Toast popped up saying, 'Sorry, we cannot connect to the server"
I have changed the appServerRootURL to my IP address with port 8081. Am I missing anything for the setup?

@yidan621 There is an accompanying server with the app. We are not maintaining this app anymore and hence there are lots of issues with the current repo. If you could tell me why you are interested in this repo, I could point you to better maintained RN repos.

@peterlazar1993  Thanks Peter！I'm a RN newbie trying to learn from open sourced RN projects.  Your app sounds really cool 👍 👍  If you could point me to some repos, that would be really great!

@yidan621 That's awesome. I'd highly recommend the f8 app from facebook http://makeitopen.com/
Also find a list of open source apps here:
https://github.com/jondot/awesome-react-native/blob/master/README.md#open-source-apps

Thanks :)


Provide a confirmation function

While waiting for #126  it would be nice to add to the prelude a confirmation function equivalent to the shell script:
    read -p "The confirmation message ? (y/n)"
    echo    # (optional) move to a new line
    if [[ $REPLY =~ ^[Yy]$ ]]
    then
	DO action
    else
        echo "Abort by the user"
    fi

Something alike :
confirm msg = do
  echo $ msg <> "? (Y/N)"
  r <- readline
  case r of
    Just "Y" -> return ()
    _ -> die "Abort by the user"

Cheers

Actually, for prompt-like logic I highly recommend the wizards library.  We use it at work and we have had a lot of success with it

Thanks for the tip.


Store duplicate entry

Hi,
I have a multistore setup, i keep getting the following error on the first step. I can solve it by deleting the entries from the database but it has implications later.
CDbCommand failed to execute the SQL statement: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1' for key 'PRIMARY'. The SQL statement executed was: INSERT INTO store_website (sort_order, default_group_id, is_default, website_id, code, name) VALUES (:yp0, :yp1, :yp2, :yp3, :yp4, :yp5)
This with the very latest version of the tool.

@rkhoury82
Did you do exactly steps in the guide of this tool at https://github.com/ubertheme/magento2_data_migration ?
Please note that, the Magento 2 have to a fresh installation ( database without any data sample) before you start data migration with this tool.
Regards,
quynhvv

@quynhvv yes exactly, I didn't install the sample data.
I installed a fresh magento2, I did login into the admin tho, but I don't think that matters.

@rkhoury82:
I think that issue because you have finished the step 1 'Migrate Settings' via tool of Magento at
https://github.com/magento/data-migration-tool-ce/issues/16#issuecomment-164047618
After  'Migrate Settings' the websites and stores in magento 1 was migrated to your magento 2 database.
and then, you use our tool to continue data migration on this database.
In this case, you have to re-install a fresh Magento 2 or you can click to 'Reset All' button in our tool to reset the Magento 2 database come back a fresh database.
And then you can do data migration with our tool step by step.
Let's do it to solve your issue.
Regards,
quynhvv

@quynhvv I'm doing these on seperate installs; both tools aren't working for me.
I started using this one on a 100% fresh copy of Magento2 without using the magento/data-migration-tool-ce

@rkhoury82
Does your Magento1 database working fine now?
Do you make re-index the data successfully on the Magento1?
Do you have re-try the data migration with this tool once more?
Regards,
quynhvv

@quynhvv
I can and did re-index magento1 successfully.
I have tried again and same problem still.
I got past the duplicate store by deleting the default store from the new magento 2 store.
Then I can't get past step 5, the next button doesn't work. The product actually migrated but the configurable product didn't keep the associated simple product attached, I saved all the attributes and re indexed. Haven't tried to trouble shoot any further yet

@rkhoury82
Can you share me the screenshot to specify that you have re-index the data in Magento 1 successfully?
Regards,
quynhvv

Never got this to work, but others have, assume it was something to do with my database.
I ended up getting the Magento data migration tool to work instead.

Same issue:
DbCommand failed to execute the SQL statement: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1' for key 'PRIMARY'. The SQL statement executed was: INSERT INTO store_website (sort_order, default_group_id, is_default, website_id, code, name) VALUES (:yp0, :yp1, :yp2, :yp3, :yp4, :yp5)

Hi Floramediaict,
It's pity that we no longer maintain the old script of our migration tool here at Github.
Please consider to take a look at our newer version UB Data MIgration Pro, as mentioned here:
https://github.com/ubertheme/magento2_data_migration/issues/52#issuecomment-278958406
Sincerely,
Ubertheme team


Dark Theme Button Missing?

As of today the dark theme button has been missing from both the website and the messenger desktop app, please fix this issue!

Not sure want your talking about. Please provide at least a screen capture.
Also what version are you using? I have been upgrading the software to version 1.5.0-beta.0 lately.

There used to be a button that would switch the site/app into a dark theme from the regular theme. I've circled in red where the button used to be. I am using the website, I have also been updated to the most recent version of the app and tried it on that but it still doesn't work. If there's anything else that needs to be provided please let me know as the issue still hasn't been resolved.

Facebook deleted it. Not our fault at all and really not an issue about our software. Please contact Facebook for that.
However, we do provide an option to switch to a dark mode. If your right/left click on tray icon you will see the theme sub-menu from which you can decide theme.
You won't get the dark theme in your web browser, but you will have it in the app.


Streaming EOS Prediction

Thank you for the excellent project.
I have a question regarding the streaming EOS prediction discussed in Section 3.1 of the paper.
Could you please specify in which file this part is implemented?

Hello zeyun, thanks for your attention! This prediction loss is achieved by setting the learning target. The implementation follows:

We implement 'stream' role in tokenizer template, e.g.

chat = [
        {'role': 'system', 'content': '...'},
        {'role': 'user', 'content': 'cool?'},
        {'role': 'stream', 'num_frames': 3, 'learn': 3},
        {'role': 'assistant', 'content': 'cool.', 'learn': True},
    ]

If you use tokenizer.apply_chat_template to see the prompt, you will get
...
User: cool?
[<v><v><v><v><v><v><v><v><v><v>,<v><v><v><v><v><v><v><v><v><v>,<v><v><v><v><v><v><v><v><v><v>]
Assistant: cool.

Here each frame contains 10 tokens. As you can see, here we set {'role': 'stream', 'num_frames': 3, 'learn': 3}, so we set every frame (the last vision token of the frame) will learn a target. If you have a look at the input_ids and labels after data_collator, you will get the last vision token of each frame, <v>, learns the next token , or ]\n.

We call , token as frame_interval_token_id, since it represents the interval token between frames. It will be regarded as EOS token in inference, which is defined in

https://github.com/showlab/videollm-online/blob/df8982632086b39fcc492db90c54bd68ae24ba5a/demo/inference.py#L80
If the next token is frame_interval_token_id, just continually input frame, otherwise do language generation.

How do we achieve the implementation? You may check

https://github.com/showlab/videollm-online/blob/main/models/tokenization_live.py
and
https://github.com/showlab/videollm-online/blob/main/data/stream.py
and
https://github.com/showlab/videollm-online/blob/main/data/data_collator.py
In short, the tokenization_live.py defines the chat templates to a string paragraph and get the learning ranges, the stream.py calls that, and data_collator.py will map the learning ranges from string indices to input_ids by return_offsets_mapping  arguments in huggingface tokenizer. You can see the details here:
https://huggingface.co/docs/transformers/en/internal/tokenization_utils
Then during training, we can learn that "EOS" by simply calling CE loss on input_ids and labels.
As you can see, we get the labels in dataloader, which is model agnostic and easy to extend. Furthermore, we can naturally enjoy the speed benefits from multiple workers.

Thank you very much for the detailed explaination. Now, I understand your approach better.
I have another issue when running demo.inference:
TypeError: PreTrainedTokenizerFast._batch_encode_plus() got an unexpected keyword argument 'add_stream_prompt'
which is caused by line 33 in inference.py. I am wondering whether you have a custom tokenizer.apply_chat_template function?

Hi zeyun, which transformers version are you used? This is not observed at 4.41.0

Hi Joya, it is indeed a transformers version issue. Upgrading from 4.37.2 to 4.42.3 solves the problem. Thanks.


[Bug]: Subscription edit preview not returning proration values

What happened?
https://developer.paddle.com/api-reference/subscriptions/preview-subscription operation response returns data.next_transaction.details.line_items[].proration object but OpenAPI file nor the documentation doesn't have it. But example in OpenAPI spec has this field.
Steps to reproduce

POST https://developer.paddle.com/api-reference/subscriptions/preview-subscription with any applicable values.
inspect the results and compare with OpenAPI file

What did you expect to happen?
We need data.next_transaction.details.line_items[].proration field to decide and visualise which item is a full price item and which item is a proration.
Logs
No response

Hi @ayhanap,
Thank you for raising this bug report.
We checked this issue and it appears that our documentation is missing this field. As the API is already returning the value, it will continue to work as is.
We will update our documentation(developer documentation and API spec) to include the field.

Hello,
I am going to close this issue as our documentation is updated with the missing property.
Please let us know if we can help with anything else.
Thank you.


[Backport] [1.x] RestIntegTestTask fails because of missed log4j-core dependency (#1815)

Signed-off-by: Andriy Redko<EMAIL_ADDRESS>Description
Backport of https://github.com/opensearch-project/OpenSearch/pull/1815 to 1.x
Using opensearch.yaml-rest-test Gradle plugin outside of the OpenSearch core (fe, in plugins), for example yamlRestTest, fails with the following exception:
> Task :yamlRestTest

org.opensearch.path.to.plugin.RenameClientYamlTestSuiteIT > initializationError FAILED
    java.lang.NoClassDefFoundError: org/apache/logging/log4j/core/Layout

Since the log4j-core is declared as optional, it is not being picked up. Adding it as an explicit dependency does not solve the problem either (see please opensearch-project/opensearch-plugin-template-java#16 for more details) because the task uses dedicated configuration yamlRestTestImplementation and only its dependencies.
Issues Resolved
Closes https://github.com/opensearch-project/OpenSearch/issues/1814
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

start gradle check


Import Failure: Unable to Import Complex JSON Druid Column Dataset into Superset

How to reproduce the bug

Create a dataset in Apache Druid that includes a column with the JSON data type. Example - https://druid.apache.org/docs/latest/querying/nested-columns.html#example-nested-data
Open the superset and establish a connection to the Apache druid.
Import the dataset which has the complex JSON column type.
During the import process, Superset will encounter an exception, specifically an import failure, caused by the presence of the complex JSON column type.

Expected results
Should support importing the dataset from apache druid which has a complex JSON column
Actual results
Fails to import the data which has the complex JSON column type.
Environment
(please complete the following information):

browser type and version: Any browser
superset version: Version: 2.0.0

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[X] I have reproduced the issue with at least the latest released version of superset.
[X] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Docker image details
image:
  repository: amancevice/superset
  tag: 2.0.0
  pullPolicy: Always

It was working fine and able to import the dataset which has the complex json column type with the Apache superset 2.1.0 version. So, I'm closing this ticket. 👍


Improved control flow caching

Fixes #8401. Thanks to @vladima for researching and prototyping the solution in #8458.

LGTM

:+1:


feat(cli): on update process add flag to opt-out from publishing

What?
This PR adds a new flag to the deploy command for publishing a new version of field plugin during the update process.
Context
As we have found out trough researching the APIs the POST request automatically publishes a field-plugin, therefore it is not possible to opt-out during the initial creations. However when using PUT method, updating the plugin, it is possible to send publish property, which will either only save the new plugin or save and publish it as a new version.
Deploy Command with --no-publish flag
Here are all the new test cases that are introduced by the change and are applied when a field plugin is updated. `
yarn deploy --no-publish
yarn deploy --skipPrompts
yarn deploy --skipPrompts --no-publish
Why?
#380
How to test?
yarn deploy
--> NEW: User is prompted with the following question Do you want to publish a new version of the field plugin?
--> Depending on the user input the field plugin will be deployed
yarn deploy --skipPrompts
--> Plugin will be updated and published inside Storyblok.
yarn deploy --no-publish & yarn deploy --skipPrompts --no-publish
--> Plugin will be updated inside Storyblok but not published.

LGTM! 🎉
Super small nit: It can be nice to add a test with the --no-publish flag in place

You are right @Dawntraoz I just added a test :)


Missing restart requirement for SMBv1 removal

The section "SMB v1 (client and server)" doesn't indicate the restart requirement (whereas other sections do).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8a91db45-ca3c-7a2e-3f32-2f5b57837b03
Version Independent ID: b83cbaab-c0df-d6e7-a67f-f4c99a46e30a
Content: How to detect, enable and disable SMBv1, SMBv2, and SMBv3 in Windows
Content Source: WindowsServerDocs/storage/file-server/Troubleshoot/detect-enable-and-disable-smbv1-v2-v3.md
Product: windows-server
Technology: storage
GitHub Login: @Deland-Han
Microsoft Alias: delhan

@IngridAtMicrosoft I tested and confirmed that computer will restart after running the PowerShell commands to enable/disable SMBv1. I have submitted a PR2395 to fix it.


SITL: emulate PWM

@LorenzMeier could we consider/simulate IO PWM limits somehow in SITL? Will help spot VTOL transition bugs

https://github.com/PX4/Firmware/blob/86d1488e523991bb2eb2a3530bcd661588cf4c38/src/modules/vtol_att_control/standard.cpp#L471

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.
(This is an automated comment from GitMate.io.)

@AndreasAntener still relevant?


[dy] Add option to run integration streams in parallel

Summary
Run streams in parallel if they are marked as parallel. I added the run_in_parallel config to the stream catalog entry.
I updated the run_integration_pipeline method in pipeline_scheduler to queue a job for each parallel stream and another job for all non-parallel streams. The code that is run for each stream should be unchanged, but the structure of an integration pipeline run is different.

Tests
tested locally

cc: @wangxiaoyou1993

@wangxiaoyou1993 I updated this PR, can you take a look?

@wangxiaoyou1993 I updated this PR, can you take a look?

Yes, will take a look

@wangxiaoyou1993 sorry for the delay, I addressed your comments


API request: MonitoredSession.run_without_hooks

Currently it is not possible to run a MonitoredSession without also calling the before_run and after_run methods of session hooks. But sometimes it is necessary. For example, I want to modify certain variables in the graph, but sometimes the SummarySaverHook decides it is time to collect summary, right when I am loading new values into the dependent variables, and then Tensorboad shows inconsistent results.
A run_without_hooks method will be immensely helpful.

As a workaround you can call monitored_session._tf_sess() to get the underlying tf.Session object.
But I also hope there is a public API for it.

If I access the raw session object, I lose the ability to auto recover session from errors.

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain mazecreator.com has exceeded the max emails per hour (26/25 (104%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from o5.sgmail.github.com ([<IP_ADDRESS>]:15392)
by server2.lowesthostingrates.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128)
(Exim 4.89)
(envelope-from<EMAIL_ADDRESS>id 1ddCtZ-0001cV-Vm
for<EMAIL_ADDRESS>Thu, 03 Aug 2017 04:58:52 -0500
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com;
h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=s20150108; bh=Ayl8meCKAIQqUp1rNnHRvdykcDY=; b=OM3UNsmExvgJNqmS
8pzFCBHdaWQGnpF1+LMgMeKvhZm9l5Kxf+kjedtTTDxUyktSbeqBuu7k+zLKbW93
iOkbEEA6fwXkGNHLjCrDemh/ziRU/vSK9T2Kj5/XhDGiNQpCAiWLQ+EphHg7tjwO
VB/7/xB1WKU/9mCSUNZxmHPTDtU=
Received: by filter0946p1mdw1.sendgrid.net with SMTP id filter0946p1mdw1-6752-5982F63E-41
2017-08-03 10:09:02.70116664 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [<IP_ADDRESS>])
by ismtpd0038p1mdw1.sendgrid.net (SG) with ESMTP id ppjHDmtcTdq2ep_x12b6dA
for<EMAIL_ADDRESS>Thu, 03 Aug 2017 10:09:02.673 +0000 (UTC)
Date: Thu, 03 Aug 2017 10:09:02 +0000 (UTC)
From: Siyuan Ren<EMAIL_ADDRESS>Reply-To: tensorflow/tensorflow<EMAIL_ADDRESS>To: tensorflow/tensorflow<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [tensorflow/tensorflow] API request:
MonitoredSession.run_without_hooks (#11971)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5982f63e678a4_f903fc59c403c3c4247a4";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: netheril96
X-GitHub-Recipient: Mazecreator
X-GitHub-Reason: subscribed
List-ID: tensorflow/tensorflow <tensorflow.tensorflow.github.com>
List-Archive: https://github.com/tensorflow/tensorflow
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/ARjzoAaNzl9anXWG8UpW1A1FT4DUxf41ks5sUZw-gaJpZM4OrTm4
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-SG-EID: BJ4qYjf5a3yL0lCrdDNghY4YYR+k1a+cluU6wEX1Jqxgank4n8nltYVYPOGXLUju+cVMIi9liIDQAb
erb0acxUNT0xu/hgZA06DMyQHn+stROMLiK9OdZJIRYhoBr8qonZaiZB4WSgOd3rW1hZZHEpsdHXYo
XjhimCPsCR47v3c3v/XlU7/Ng4R0dl84F1Wj1aNSdJ/ebQu8jz68qQAFsYZJq8m5kacFogbBuUGeAi
A=
X-Spam-Status: No, score=
X-Spam-Score:
X-Spam-Bar:
X-Ham-Report:
X-Spam-Flag: NO
----==_mimepart_5982f63e678a4_f903fc59c403c3c4247a4
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
If I access the raw session object, I lose the ability to auto recover session from errors.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tensorflow/tensorflow/issues/11971#issuecomment-319926992
----==_mimepart_5982f63e678a4_f903fc59c403c3c4247a4
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
If I access the raw session object, I lose the ability to auto recover session from errors.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_5982f63e678a4_f903fc59c403c3c4247a4--

We added MonitoredSession.run_step_fn.  We hope it satisfies the use case.


Comment in StringCheese.m needs to be updated.

There is a comment (line 30 and 47) in StringCheese.m stating you will learn more about if/else in the next checkpoint, but the next checkpoint is on Equality. This might need to be updated to state you will learn about "if/else" in a "future" checkpoint.
    /*
     (You will learn more about if/else statements in the next checkpoint.)
     */

On second thought, I have just completed the Equality Checkpoint and realized that Equality is a great intro to how if/else works. I leave this with your discretion.

Thanks, @brianllamar. I updated the comment, per your suggestion, in https://github.com/Bloc/ios-exercises/commit/df954b47a95c1fb8471fea0b267fe941adc3e186.


Adds function that exposes whether our bot is explicitely referenced

This code doesn't appear to implement the actual function of changing to True / False depending on whether a bot is referenced?
Starting at the Issue level may be helpful to understand the needs and purposes of such a function as well.

The information of whether the User-agent is referenced or not is already computed in the function Robot::new in the variable references_our_bot.

Hi there! @T-Sujeeban and I work together at @qwant, so I thought I'd drop by and shed some light on our use case :)
We are developing a crawler for a search engine and we need to know, for a given website, whether we are allowed to crawl its pages. For this use case, this library as worked very well for us.
On top of that, we would like to know, in the case where our crawler is rejected by the website, if the websites rejects all bots from crawling it, or if it rejects Qwant specifically. If it's the former, well there's nothing much we can do about it, but if it's the latter, e.g. a website that rejects our search engine but accepts Google, we could identify such websites and try to work it out with the owners.
Now, back to the PR: it would appear that this information is already computed by your library, on line 397 of lib.rs, but not exposed by the crate's public API. This PR stores this information in the Robot struct and exposes it to the outside. our_bot in this context means the agent that was provided when building the Robot using Robot::new.

Closing this as the pull request doesn't yet fill out the required spec. I'm happy to include it if it can be added in a way that works and has unit tests ensuring it's good! :)


gulp build broken

Steps to reproduce the problem:

cd ./web && yarn && gulp
pip3 uninstall mitmproxy && pip3 -v install . --upgrade   # hard way
mitmweb
each displayed request breaks the react view:

Any other comments? What have you tried so far?
I tried several version of Yarn and Gulp, just in case, but I get the same behavior...
System information
yarn -v
1.17.3
node -v
v10.16.3
gulp -v
CLI version: 2.2.0
Local version: Unknown
mitmweb --version
Mitmproxy: 5.0.0.dev    (I got the same behavior with 4.0.4)
Python:    3.6.8
OpenSSL:   OpenSSL 1.1.0j  20 Nov 2018
Platform:  Linux-5.0.0-27-generic-x86_64-with-Ubuntu-18.04-bionic

Same thing with
gulp -v
[18:05:18] CLI version 3.9.1
[18:05:18] Local version 3.9.1

Thanks @fliot! Sorry for the late reply, this has been fixed in #3745.


Router liquidity not showing up for optimism testnet

Describe the bug
See title.
To Reproduce
Steps to reproduce the behavior:

Go to explorer: https://testnet.amarok.connextscan.io/router/0xd2ad711861ab345977b7379c81165708c8717ff1
See router liquidity is 0 on Opt

Expected behavior
Router has plenty of liquidity.
Version:
Additional context
Add any other context about the problem here.
Screenshots
If applicable, add screenshots to help explain your problem.

fixed


Use peer dependencies for react and styled-components

Enough said?

Hi @pmark, Thanks for pointing that out. Unfortunately this requires testing of this package with multiple versions of react, styled-components and react-motion before adding them as peer dependencies. In the meantime maybe take a look at npm dedupe ?


fix Version field in packages to show actual version of kernel

1xross is interpreted by apt as version 1, this means if it has a version 4 kernel available elsewhere it will install that instead of this 5.8 version.

Thanks @TonyTheLion i'll give this some testing over this long weekend.


Geometry.splitLongitude crashing for polygon that crosses the poles

Reported on the forum: https://groups.google.com/forum/?hl=en#!topic/cesium-dev/O_LaBx1_1wg
ne_10m_admin_0_countries2.json.txt
For some reason this crashes in Sandcastle but not in the CesiumViewer.  It also doesn't crash when scene3DOnly = true
var viewer = new Cesium.Viewer('cesiumContainer');

viewer.dataSources.add(Cesium.GeoJsonDataSource.load('../../SampleData/ne_10m_admin_0_countries2.json'));

DeveloperError: normalized result is not a number
Error
    at new DeveloperError (http://localhost:8080/Source/Core/DeveloperError.js:44:19)
    at Function.Cartesian3.normalize (http://localhost:8080/Source/Core/Cartesian3.js:422:19)
    at computeTriangleAttributes (http://localhost:8080/Source/Core/GeometryPipeline.js:1901:24)
    at splitLongitudeTriangles (http://localhost:8080/Source/Core/GeometryPipeline.js:2058:17)
    at Object.GeometryPipeline.splitLongitude (http://localhost:8080/Source/Core/GeometryPipeline.js:2482:17)
    at geometryPipeline (http://localhost:8080/Source/Scene/PrimitivePipeline.js:135:38)
    at Object.PrimitivePipeline.combineGeometry (http://localhost:8080/Source/Scene/PrimitivePipeline.js:278:26)
    at combineGeometry (http://localhost:8080/Source/Workers/combineGeometry.js:12:41)
    at http://localhost:8080/Source/Workers/createTaskProcessorWorker.js:56:42

It also doesn't crash when scene3DOnly = true

That's because we don't need to split the geometry in 3D so this code path never gets calls.

Reported again in https://community.cesium.com/t/geojsondatasource-crash/25540/2.

Also reported in https://github.com/CesiumGS/cesium/issues/12251.


Master

Refactor from C struct to std::valarray and automatic memory management

@modocache Made some refactorings away from manual memory management

my changes silence the static analyzer


track size in @immut/sorted_set like @immut/sorted_map

Closes #1295

Pull Request Test Coverage Report for Build 4181
Details

18 of 18 (100.0%)  changed or added relevant lines in 1 file are covered.
33 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.03%) to 80.256%

Files with Coverage Reduction
New Missed Lines
%

immut/sorted_map/utils.mbt
16
72.15%

immut/sorted_map/map.mbt
17
59.32%

Totals

Change from base Build 4177:
-0.03%

Covered Lines:
4459

Relevant Lines:
5556

💛  - Coveralls


row-property is a noop?

I just noticed in the example-site that the row-attribute is not doing anything:

these are not 4 rows.
is this expected behavior?
I understand that 'row' is a bit of an odd property in the first place when using an auto-growing textarea, but if it is a noop, then it would be better to just give a type-error imo.
btw I am making a port of react-textarea-autosize for solid

either noop and type-error, or allow it and row={4} === minRow={4} maxRow={4} imo

I'd probably remove this from the types (and from examples)


Greenkeeper/tslint 5.5.0

Coverage remained the same at 74.689% when pulling e7de1c0ec47f1525c51b83ae695fca9eaa87f689 on greenkeeper/tslint-5.5.0 into d2621877849539925cbc2c800f2631753a375632 on master.


[fix #761] Update ncx.rng schema to add fixed list of pageTarget type values

fixes #761

Thanks for taking a look, @mattgarrish! 👍


Modelling an ontology/impact graph for Amadeus

What: Model the impact graph/ontology for an example "production" application for Amadeus.
Why: This will describe the requirements, we need to be able to model and measure this example application.
SoW:

Create a yaml file which describes the ontology of an Amadeus application.
The yaml file will be used as the input data for an application that will try to measure the carbon emissions of the amadeus application.

@navveenb I think this might be a good first step for you and you're colleague to work through. It's required analysis for any future ontology work.

See pull request https://github.com/Green-Software-Foundation/carbon-ql/pull/51/files for a specific formal approach to write an impact graph/ontology.

We discussed on the call, lots of similarities between the Amadeus use case and the Accenture one. We'll create the Accenture IMPL first and then come back to this as it would help explain direction.


Any plan for new custom type? I would like to suggest geolocation and reference

NewtonSoft support unconventional JSON type in C# and I think it's great
But I would like to have more type support. At least geopoint and reference to match with google protobuf. And so it would be easier to bridge things between Json in C# and ProtoBuf when use google service
Especially geopoint I think this type is common nowaday
I had written conversion function with google protobuf for firestore Google.Cloud.Firestore.V1Beta1/Document.cs#L561. It almost map perfectly except these 2 types
geopoint is just latitude/longitude and reference is just special string to keep key of any format
I think we may hack the key to use uri type. But geopoint was really needed to handle
ps. This is my bridge code
https://gist.github.com/Thaina/82071ca2814755ef3571fec352f2e44c

It can be part of a third party NuGet package. There is no reason it needs to be inside Newtonsoft.Json

@JamesNK Sure it can be 3rd party. But I think it should be part of NewtonSoft
3rd party cannot extend enum JTokenType. What I want is JTokenType.Geo or something like that


Update third party dependencies.

Several security vulnerabilities in the current list of third party dependencies.  This updates the dependencies to the latest version.
Unit tests still pass after the upgrade.

@WilliamRClark Thank you for the request. Looks good to me so I merged it into the master.


Cleared (undefined) rawLaTag disables raw #LaTeX processing

Description of the problem
Despite a #LaTeX tag, some fields are not exported as if they’re wrapped in <script>...</script>. For instance, for an entry with such a #LaTeX tag with the following characteristics:

Item Type: Journal Article
Title: Completeness of $\mathbb{R}$
Author: Bar, Foo
Short Title: $\mathbb{R}$: complete!
Extra:
Tag: #LaTeX

I get the following actual behavior where:

the title is OK thanks to https://retorque.re/zotero-better-bibtex/exporting/scripting/#detect-and-protect-latex-math-formulas
the annotation is OK thanks to <script>...</script>
the short title is not OK since:

the entry its belongs to, having the #LaTeX tag, should then have all fields exported as if they’re wrapped in <script>...</script> (literal LaTeX),
its content should hence be similar to the one of the annotation (see expected behavior).

Required informations
Report ID: U2Z8CJBC-euc
Exporter used: Better BibLaTeX
Expected behavior:
@article{BarCompletenessmathbbR,
  shorttitle = {$\mathbb{R}$: Complete!},
  author = {Bar, Foo},
  annotation = {$\mathbb{R}$ !},
  keywords = {\#LaTeX},
  title = {Completeness of {$\mathbb{R}$}}
}
% == BibLateX quality report for BarCompletenessmathbbR:
% Exactly one of 'date' / 'year' must be present
% Missing required field 'journaltitle'

Actual behavior:
@article{BarCompletenessmathbbR,
  shorttitle = {\$\textbackslash mathbb\{\vphantom\}{{R}}\vphantom\{\}\$: Complete!},
  author = {Bar, Foo},
  annotation = {$\mathbb{R}$ !},
  keywords = {\#LaTeX},
  title = {Completeness of {$\mathbb{R}$}}
}
% == BibLateX quality report for BarCompletenessmathbbR:
% Exactly one of 'date' / 'year' must be present
% Missing required field 'journaltitle'

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>00 ("debug logging for #1674")
Install in Zotero by downloading test build <IP_ADDRESS>00, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

I can't currently replicate this. With that reference, and your BBT settings, I get
@article{BarCompletenessmathbbR,
  shorttitle = {$\mathbb{R}$: complete!},
  author = {Bar, Foo},
  annotation = {<script>$\mathbb{R}$ !</script>},
  title = {Completeness of <script>{$\mathbb{R}$}</script>}
}
% == BibLateX quality report for BarCompletenessmathbbR:
% Exactly one of 'date' / 'year' must be present
% Missing required field 'journaltitle'

can you install 7300, select "restart with debug logging" from the help menu, re-export this item, and then send a new BBT debug log?

@retorquere Done with BBT debug log P63XM56S-euc. Now, the entry is exported as:
@article{BarCompletenessmathbbR,
  shorttitle = {$\mathbb{R}$: complete!},
  author = {Bar, Foo},
  annotation = {<script>$\mathbb{R}$ !</script>},
  title = {Completeness of <script>{$\mathbb{R}$}</script>}
}
% == BibLateX quality report for BarCompletenessmathbbR:
% Exactly one of 'date' / 'year' must be present
% Missing required field 'journaltitle'

BTW, the rawLaTag hidden preference is now:
extensions.zotero.translators.better-bibtex.rawLaTag;#LaTeX
and now I'm not sure: maybe the error I had was due to the fact I did reset its value (I guess I misunderstood the documentation).
Sorry for the noise.
With 7300, spurious <script>...</script> in the exported .bib file, isn't it?

With 7300, spurious  in the exported .bib file, isn't it?

Well, coming back to 5.2.84, the Zotero entry as in the OP, in particular with:

Title: Completeness of $\mathbb{R}$

but now with:
extensions.zotero.translators.better-bibtex.rawLaTag;#LaTeX
is exported as:
@article{BarCompletenessmathbbR,
  shorttitle = {$\mathbb{R}$: complete!},
  author = {Bar, Foo},
  annotation = {<script>$\mathbb{R}$ !</script>},
  title = {Completeness of <script>{$\mathbb{R}$}</script>}
}
% == BibLateX quality report for BarCompletenessmathbbR:
% Exactly one of 'date' / 'year' must be present
% Missing required field 'journaltitle'

so still spurious <script>...</script> in the title field of the exported .bib file, isn't it?

Not spurious - if you set #LaTeX, everything is passed through as-is, because you've told BBT to assume everything is valid LaTeX already, and in your case, "everything" includes those <script> tags.
Remains strange that I didn't get your initial input with your settings. I'll have to look into that.

Not spurious - if you set #LaTeX, everything is passed through as-is, because you've told BBT to assume everything is valid LaTeX already, and in your case, "everything" includes those

maybe the error I had was due to the fact I did reset its value

That must have been the problem, and that explains the difference in behavior. When you reset the value, it will be undefined, and BBT tries to find the tag with value undefined (not the string "undefined"), and that will never be found. But if you restart while it is undefined, BBT will reset it to the default #LaTeX, and I did restart after applying your settings.

the Zotero's title field contains no <script> tag ("Completeness of $\mathbb{R}$"),
the title field in the exported .bib field contains such a tag (title = {Completeness of <script>{$\mathbb{R}$}</script>}).

Because you added it in the postscript. What's added in the postscript is also assumed to be raw LaTeX for an item tagged as such. If you want to exempt such items you'd have to use something like
if (Translator.BetterTeX && reference.has.title && !item.raw) {
  reference.add({ name: 'title', value: item.title.replace(/(\$.*?\$)/g, '<script>{$1}</script>') });
}

Because you added it in the postscript. What's added in the postscript is also assumed to be raw LaTeX for an item tagged as such. If you want to exempt such items you'd have to use something like [...]

Sorry, but I'm a bit lost. Does it mean you recommend to systematically add && !item.raw to the post script which detects and protects LaTeX math formulas, having in mind entries with #LaTeX tag?

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>01 ("fall back to default for cleared pref")
Install in Zotero by downloading test build <IP_ADDRESS>01, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

I recommend not mixing the postscript protection and the #LaTeX tag on the same item. Checking for item.raw is one way to accomplish that. Another is to not use the auto-protect postscript.

I recommend not mixing the postscript protection and the #LaTeX tag on the same item. Checking for item.raw is one way to accomplish that. Another is to not use the auto-protect postscript.

Suppose a PhD student in mathematics. Several entries of his bibliography are likely to contain mathematic formulas, so he would probably be interested in the (global) postscript protection. Now, suppose some entries, because of some special fields (shorttitle, abstract, etc.), needs literal LaTeX in the export: there is a great temptation to use the (locally global) #LaTeX protection instead of adding many (locally local) <script> tags.

In that case there's currently no way around checking for item.raw.

In that case there's currently no way around checking for item.raw.

So we're going back to #1380 :wink:
In fact, I'm in the process to go into some details about BBT in a LaTeX course I'm giving to PhD students (among others) because, during the previous course (2 weeks ago), some students (in maths, in physical sciences, in computer science) were disappointed because of these LaTeX commands not exported untouched. And the configuration process of BBT is somewhat long/complicated (I'm not fully understand all the items), especially for students who are discovering (La)TeX + Bib(La)TeX + Zotero + BBT :smile: so I'd like to be as simple as possible. If I understand correctly, the advices for such students could be:

for all of them, the post script:

if (Translator.BetterTeX && reference.has.title && !item.raw) {
  reference.add({ name: 'title', value: item.title.replace(/(\$.*?\$)/g, '<script>{$1}</script>') });
}

for those who would need from time to time literal LaTeX export in other fields than the title: add the #LaTeX tag to the relevant entries,
for those who would need almost always literal LaTeX export in other fields than the title: Preferences/Advanced/Config editor/Search for rawLa/Right Click/Modify/Replace #LaTeX by * (in such a case, post script is useless but harmless).

Do you agree with these advices?

And the configuration process of BBT is somewhat long/complicated (I'm not fully understand all the items)

Even I occasionally forget about functionality in BBT. It's become a complex beast.
You can do it for multiple fields with
if (Translator.BetterTeX && !item.raw) {
  const fields = ['title', 'titleaddon']
  for (const [name, field] of Object.entries(reference.has)) {
    if (fields.includes(name)) {
      reference.add({ name, value: field.value.replace(/(\$.*?\$)/g, '<script>{$1}</script>') })
    }
  }
}

for those who would need from time to time literal LaTeX export in other fields than the title: add the #LaTeX tag to the relevant entries,

for those who would need almost always literal LaTeX export in other fields than the title: Preferences/Advanced/Config editor/Search for rawLa/Right Click/Modify/Replace #LaTeX by * (in such a case, post script is useless but harmless).

That seems correct. Note that Zotero does not understand postscripts, it's strictly a BBT thing, and those $ signs will show up if you create a bibliography in Word/LO.

And the configuration process of BBT is somewhat long/complicated (I'm not fully understand all the items)

Even I occasionally forget about functionality in BBT.

Happy to know that I'm not the only one! :smile:

It's become a complex beast.

Indeed. I'll open a new issue about ("Export" tab) "When converting to plain-text latex commands", which is somewhat obscure from my point of view...

You can do it for multiple fields with
if (Translator.BetterTeX && !item.raw) {
  const fields = ['title', 'titleaddon']
  for (const [name, field] of Object.entries(reference.has)) {
    if (fields.includes(name)) {
      reference.add({ name, value: field.value.replace(/(\$.*?\$)/g, '<script>{$1}</script>') })
    }
  }
}

OK but one has to complete by himself the const fields list. Giving to rawLaTag the value * looks simpler.

That seems correct. Note that Zotero does not understand postscripts, it's strictly a BBT thing,

OK.

and those $ signs will show up if you create a bibliography in Word/LO.

But BBT is designed to export to Bib(La)TeX, designed for (La)TeX, isn't it? Hence,  why one would rely on it for a bibliography in Word/LO?
Anyway, I still argue for a simple check box is the "Export" tab in the BBT config that let the user easily ask for literal LaTeX export in all fields (with, maybe, a list fields to omit, similar to the one in the "Fields" part).

But BBT is designed to export to Bib(La)TeX, designed for (La)TeX, isn't it? Hence, why one would rely on it for a bibliography in Word/LO?

BBT is, but Zotero is not. Many people (myself included) use Zotero both with Word (if the publisher demands Word) or LaTeX (all other times).

Anyway, I still argue for a simple check box in the "Export" tab in the BBT config that let the user easily ask for literal LaTeX export in all fields (with, maybe, a list fields to omit, similar to the one in the "Fields" part).

As a shortcut to setting rawLaTag to * you mean?

But BBT is designed to export to Bib(La)TeX, designed for (La)TeX, isn't it? Hence, why one would rely on it for a bibliography in Word/LO?

BBT is, but Zotero is not.

Indeed, I noticed :wink:

Many people (myself included) use Zotero both with Word (if the publisher demands Word) or LaTeX (all other times).

But the BBT "Export" settings doesn't change (interfere with) the content of Zotero's fields, which is what is used by Word/LO, isn't it?

Anyway, I still argue for a simple check box in the "Export" tab in the BBT config that let the user easily ask for literal LaTeX export in all fields (with, maybe, a list fields to omit, similar to the one in the "Fields" part).

As a shortcut to setting rawLaTag to * you mean?

Yes (with, maybe, possibility to exclude some fields from literal LaTeX export).

But the BBT "Export" settings doesn't change (interfere with) the content of Zotero's fields, which is what is used by Word/LO, isn't it?

That is true, but the dollar signs (and the latex formula) will show up in Word/LO bibliographies.
I'll think about the field config. I've become more hesitant adding new preferences - BBT might already have more preferences than Zotero itself.

But the BBT "Export" settings doesn't change (interfere with) the content of Zotero's fields, which is what is used by Word/LO, isn't it?

That is true, but the dollar signs (and the latex formula) will show up in Word/LO bibliographies.

Indeed, but I don't see the connection with BBT export (to a .bib file) settings.

I'll think about the field config. I've become more hesitant adding new preferences - BBT might already have more preferences than Zotero itself.

I understand but LaTeX users are the main target users of BBT and, among them, mathematicians certainly make up the majority. Hence, an easy way for them to export Zotero fields content as they expect would be very helpful (maybe much more than other settings, such as "Include JabRef-specific metadata" I guess).

No connection with bib export, just a general point about using a BBT-only facility.
I regret adding the jabref settings, but it's there, and I don't like to remove existing features. I'll think about the field exemptions.

No connection with bib export, just a general point about using a BBT-only facility.

OK. About those $ signs that will show up in bibliographies with Word/LO, it is a job for the "to Word/LO export" to deal with them, not for BBT :wink:

I regret adding the jabref settings, but it's there, and I don't like to remove existing features. I'll think about the field exemptions.

Maybe more rarely used options could be gathered in "advanced" part(s) of the BBT config tab(s), only revealed if "Show advanced" check box(es) would checked.

There's no such thing as Word/LO export. Zotero talks to Word/LO directly and must assume that whatever is in eg the title field is what you want to see as text. But Zotero has no math support, so the formulas will look janky anyhow.

BTW, there's already stuff like
tex.title= stuff with $x>y$.

which will override whatever is in the title. No need for #LaTeX tagging or postscripts.

BTW, there's already stuff like [...] which will override whatever is in the title.

Sorry, I'm puzzled:

where tex.title has to be specified?
does its value ("stuff with $x>y$" in your example) be the actual content of the title?

https://retorque.re/zotero-better-bibtex/exporting/#add-your-own-biblatex-fields
It's added in the extra field. What I showed would be the actual content - when using = instead of :, that line is treated as raw LaTeX. This would override the zotero title for BBT exports, so this would even allow use in both word and latex.

BTW, there's already stuff like [...] which will override whatever is in the title. No need for #LaTeX tagging or postscripts. [...] so this would even allow use in both word and latex.

OK but, for a LaTeX export, #LaTeX looks simpler.


Implement fftw

Codecov Report
Attention: Patch coverage is 98.05014% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 99.07%. Comparing base (e4090e6) to head (3ff9be6).
Report is 1 commits behind head on main.

Files
Patch %
Lines

russell_lab/src/fftw.rs
97.98%
7 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   99.08%   99.07%   -0.02%
==========================================
  Files         146      148       +2
  Lines       32028    32387     +359
==========================================
+ Hits        31734    32086     +352
- Misses        294      301       +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ImportProcessor missing realpath() call for DOC_ROOT

Minify version: 2.1.0
PHP version: PHP 5.2.6

What steps will reproduce the problem?
1. upload min dir into server root
2. browse to {domain.com}/min_unit_tests
3. test test_Minify_ImportProcessor.php

Expected output: PASS

Actual output: !FAIL: ImportProcessor (1 of 1 tests run so far have failed)

Did you run the unit tests? Did any FAIL? Yes, the ImportProcessor

Please provide any additional information below.

Hello guys. I'm having problems with Minify. I just uploaded min dir to
server root and wanted to play with the builder. But there is not form at
the builder page. Just title, "Need help? Search or post to the Minify
discussion list." and text "This app is minified". So i thought that some
unit isn't working and i tested all units. One failed (ImportProcessor).
What could be the problem? I'm using mod_rewrite module of Apache. Maybe
this could be the problem. But i deactivated htaccess in root dir and
nothing happened, it was the same. So can anyone help me please to get
Minify working.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 18 Oct 2008 at 7:25

I tried on another server and i got the same error. So i guess the script isn't
that
'crosssystems' build...

I got...

!FAIL: ImportProcessor (1 of 1 tests run so far have failed)

---Output: 1651 bytes

@media screen {
/* some CSS to try to exercise things in general */

@import
url(min_unit_tests/_test_files/importProcessor/min_unit_tests/_test_files/import
Processor/min_unit_tests/_test_files/css/more.css);

from where we can see that there is no local path prefix... sometimes this
general
$_SERVER variables are disabled due to security reasons so there must be also a
workaround for this kind of situation.

Original comment by<EMAIL_ADDRESS>on 18 Oct 2008 at 7:58

I manually declared variable $_SERVER['DOCUMENT_ROOT'] in index.php and now it
works
great. Nice script.

Original comment by<EMAIL_ADDRESS>on 19 Oct 2008 at 9:14

Original comment by<EMAIL_ADDRESS>on 20 Oct 2008 at 6:35

Changed title: ImportProcessor missing realpath() call for DOC_ROOT
Changed state: Verified
Added labels: Release-2.1.0

I looked into test_Minify_ImportProcessor.php and the problem is in line 29...

if (__FILE__ === realpath($_SERVER['SCRIPT_FILENAME'])) {
        echo "\n---Output: " .strlen($actual). " bytes\n\n{$actual}\n\n";
        if (!$passed) {
            echo "---Expected: " .strlen($expected). " bytes\n\n{$expected}\n\n\n";
        }
    }

This if sentence is true.

Original comment by<EMAIL_ADDRESS>on 18 Oct 2008 at 7:48

OK definitely it's the $_SERVER['DOCUMENT_ROOT'] variable. It says on the
hosting
server that $_SERVER['DOCUMENT_ROOT'] always returns just '/' and i should use
getcwd() instead.

Original comment by<EMAIL_ADDRESS>on 19 Oct 2008 at 8:38


1748 - gitattributes and file normalization

The following commit helps to prevent commits that does not follow a specific "standard".

Wrong ref branch :|


SPARK-19767 Add not about missing API doc for Kafka 0.10 integration.

What changes were proposed in this pull request?
Adding not about missing API docs for Kafka 0.10
How was this patch tested?
Viewing generated doc.

Can one of the admins verify this patch?

It looks like the change got mangled, maybe due to line-ending differences? the diff shows the entire file as a change. Check the CRLF settings in git and try again?

Should I submit a new PR or is it acceptable to resolve by adding more commits on this one ?

Sure you can update this branch too. Force push if you need to.

Looks like I need to remove the link to the Java source tree as the Java sources are generated not in github.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Doc link is going to be changed to 0.10 artifact rather than 0.8 in a new PR to address this issue.


feat: make migrations dir configurable

This PR makes the path to the migrations directory configurable, via the environment variable MIGRATIONS_DIR. The default directory is migrations, making this a backwards compatible change.
Also uses path.join to help ensure the path is normalized.

If this were merged, I could also update the example repo to include the new variable. :)

LGTM. Merging.


Interface Groups and Port Grouping

I would like to see an option to throw a specific selection of interfaces in an interface group when looking at the device interfaces. Some devices, such as a Nexus 7706, can have up to 70 ports total (48 1/10 (SFP+) ports and 24 40GE (QSFP+) ports). As for the functionality, instead of listing all 48 1/10 SFP+ interfaces (Ethernet 1/1 - Ethernet 1/48) spanning for miles down the page, you would see an interface group such as "Line Card 1 Interface Group" or "Line Card 2 Port Group". Each interface group would be a link to a page that shows all of the interfaces or ports associated with that group only like how the rack groups are set up. This would be a very useful feature for work places that use VDCs to group a selection of ports using an adapter cable, connecting to one port. (Example: Cisco 9396PX 1/10 GE ports eth 1/1-1/5 connected to Cisco 7706 40 GE port 2/1.) We can then create interfaces 2/1/1-2/1/5 to simulate the virtual ports, label them as virtual interfaces, and group them to the 40 GE port 2/1.
Creating and connecting interfaces would work exactly the same, with the only difference being that they can be grouped together and displayed as a grouped interface.
Just a suggestion, but im sure you have been getting swarmed with them, so ill end this by saying thank you for the amazing product, Netbox is a very powerful, well designed tool and I can tell a lot of thought went into this product.
Thanks again.

It's a neat idea, but practically speaking it's probably going to be more trouble to implement than it's worth. That said, I'd like to start on #284 in the near future, to allow intelligent sorting of interfaces based on a device's platform, to ensure that they are listed in their native order. It should be possible to dynamically generate interface groups based on slot number as part of that work.


auto-detect required extensions from composer.lock or composer.json file

name:  🎉 New Feature
about: add a new feature
labels:  enhancement

A Pull Request should be associated with a Discussion.

If you're fixing a bug, adding a new feature or improving something please provide the details in discussions,
so that the development can be pointed in the intended direction.

Related discussion: #869

Further notes in Contribution Guidelines
Thank you for your contribution.

Description
this actions already has auto-detect PHP version feature. This PR aims to add auto-detect required extension feature
If composer.lock or composer.json file exists then those exts will be automatically enabled/installed, by default it will install the latest version of the required exts.
If user wants to disable required extension
let's say the project/library requires xml extension but user wants to disable that ext, just simply to add :xml on extensions input.
- name: Setup PHP
  uses: shivammathur/setup-php@v2
  with:
    php-version: '8.3'
    extensions: :xml

If user wants to install specific version of the extension
let's say the project/library requires swoole extension and the action will install the latest version but user want to install specific version of swoole ext, just simply to add swoole-1.9.3 on extensions input (same as this doc https://github.com/shivammathur/setup-php?tab=readme-ov-file#heavy_plus_sign-php-extension-support) so the action will install specific version ext instead of the latest version
- name: Setup PHP
  uses: shivammathur/setup-php@v2
  with:
    php-version: '8.3'
    extensions: 'swoole-1.9.3'

In case this PR introduced TypeScript/JavaScript code changes:

[x] I have written test cases for the changes in this pull request
[x] I have run npm run format before the commit.
[x] I have run npm run lint before the commit.
[x] I have run npm run release before the commit.
[x] npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

[ ] I have checked the edited scripts for syntax.
[ ] I have tested the changes in an integration test (If yes, provide workflow YAML and link).

Thanks for contributing this, I would like to keep the extensions input manual and not connected to the composer config file. Also changing this currently would be a breaking change. Happy to look at this again at the time of v3.


Enterprise Bot Template: Azure Storage Name Space Collision

Enterprise Bot Template v<IP_ADDRESS>
Name: Enterprise Bot Template
Language: C#
Description
Microsoft.AspNetCore references Microsoft.WindowsAzure.Storage while Microsoft.Bot.Builder.Azure references Microsoft.Azure.Storage.Blob having same namespace, and same object type name so attempting to reference 'CloudBlockBlob' in my bot code results in the following complier error.
Compiler Error: The type 'CloudBlockBlob' exists in both 'Microsoft.Azure.Storage.Blob, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' and 'Microsoft.WindowsAzure.Storage, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
I haven't yet figured out a work around.  Any ideas?
To Reproduce

Create new project from Enterprise Bot Template v0.3
Add code:

using Microsoft.WindowsAzure.Storage;
using Microsoft.WindowsAzure.Storage.Blob;
. . .
string sasUri = $"{storageConfig.ContainerName}{storageConfig.ConnectionString}";
CloudBlobContainer container = new CloudBlobContainer(new Uri(sasUri));
CloudBlockBlob blob = container.GetBlockBlobReference(blobName);

I've tried to reference Microsoft.Azure.Storage instead, but without success.
Expected behavior
Project compiles without namespace conflict error
Screenshots
Current version Enterprise Bot dependencies

Prior version Enterprise Bot dependencies

Additional context
Similar issue is discussed here,
https://github.com/Azure/azure-storage-net-data-movement/issues/159

Hi @markbeau it looks like the WindowsAzure.Storage package has been split up and the Microsoft.Azure.Storage approach is the latest, but the Microsoft.AspNetCore.All package has not been updated to reflect this.
I wasn't able to find a workaround on my side so I'm going to transfer this to the SDK team. They might have run into this problem before.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "PyPi Humanqueenn",
  "product_name": "PyPi Humanqueenn",
  "product_version": "all",
  "vulnerability_type": "Malicious code",
  "affected_component": "malicious code",
  "attack_vector": "typosquatting",
  "impact": "Discord token and leveldb file stealer",
  "credit": "",
  "references": [
    "https://blog.sonatype.com/malicious-roblox-cookie-and-discord-token-stealers-hit-pypi-repository",
    "https://pepy.tech/project/humanqueenn"
  ],
  "reporter": "kurtseifried",
  "reporter_id": 582211,
  "notes": "If you have downloaded or used the PyPi Humanqueenn package you should rotate all Discord tokens and credentials immediately.",
  "description": "In the PyPi Easyfuncsys package there is malicious code that appears to be stealing Discord tokens allowing it to access Discord as that user, additionally it appears to be stealing leveldb files."
}
--- GSD JSON ---

/cc @kurtseifried

This issue has been assigned GSD-2022-1000075