fix: Added missing values for HistoryError to be sync with nwaku

Problem
Find test failure in nwaku ci:
2024-04-09T09:49:52.0513572Z   8) Waku Store, general
2024-04-09T09:49:52.0513871Z        Query generator for 2000 messages:
2024-04-09T09:49:52.0514217Z      Error: Invalid enum value
2024-04-09T09:49:52.0514929Z       at findValue (file:///home/runner/work/nwaku/nwaku/node_modules/protons-runtime/src/codecs/enum.ts:9:13)
2024-04-09T09:49:52.0516150Z       at Object.enumDecode [as decode] (file:///home/runner/work/nwaku/nwaku/node_modules/protons-runtime/src/codecs/enum.ts:24:12)
2024-04-09T09:49:52.0517376Z       at Object.decode (file:///home/runner/work/nwaku/nwaku/packages/proto/src/generated/store.ts:451:64)
2024-04-09T09:49:52.0519087Z       at Object.decode (file:///home/runner/work/nwaku/nwaku/packages/proto/src/generated/store.ts:533:54)
2024-04-09T09:49:52.0521545Z       at decodeMessage (file:///home/runner/work/nwaku/nwaku/node_modules/protons-runtime/src/decode.ts:8:16)
2024-04-09T09:49:52.0522987Z       at Object.HistoryRpc.decode (file:///home/runner/work/nwaku/nwaku/packages/proto/src/generated/store.ts:557:12)
2024-04-09T09:49:52.0524260Z       at HistoryRpc.decode (file:///home/runner/work/nwaku/nwaku/packages/core/src/lib/store/history_rpc.ts:73:34)
2024-04-09T09:49:52.0525300Z       at StoreCore.queryPerPage (file:///home/runner/work/nwaku/nwaku/packages/core/src/lib/store/index.ts:110:37)
2024-04-09T09:49:52.0526135Z       at processTicksAndRejections (node:internal/process/task_queues:95:5)
2024-04-09T09:49:52.0526996Z       at async StoreSDK.queryGenerator (file:///home/runner/work/nwaku/nwaku/packages/sdk/src/protocols/store.ts:83:22)
2024-04-09T09:49:52.0527571Z

Found missing enum values from HistoryError in protobuf definition.
Please help me elaborate this PR for me ;-)

@weboko: Can you help me? Is it "normal" that some of the CI checks fails? I see some peer discovery errors.
This change is needed for my PR on nwaku as some interface has changed on protocol level.

@weboko: Can you help me? Is it "normal" that some of the CI checks fails? I see some peer discovery errors. This change is needed for my PR on nwaku as some interface has changed on protocol level.

as long as all the required CI checks pass then it's considered good


Add support for Django 2.1

thanks. don't forget to bump the version!

@zsoldosp correct - I missed that, thanks for pointing it out.

Followup is this one https://github.com/PaesslerAG/django-admin-caching/pull/20


Cirque trackpad won't work

I just built a ChocV Stront. Lights, keys, square display, and rotary encoder all work fine. I've got the trackpad on the right side, using the precompiled firmware,  using OSX (not Windows) and I can't get the track pad to move the mouse. Is there something extra I'm missing like installing a driver? Solder a jumper that wasn't mentioned? Thanks!

did you check that the trackpad is connected correctly? e.g. VCC/GND on trackpad (there are testing pads on the bottom) have continuity to VCC/GND on the MCU?
do you use trackpad in SPI (default) mode?
which firmware exactly did you use?

Thanks zzeneg!

I've attached a photo to make sure I understand you. Are the "testing pads" what I've circled in the photo? If so, I've got continuity for most pins, but nothing when I probe RES and BL from the testing pads.
Yes, there's a resistor in R1 on the trackpad, so it should be SPI from what I read in the datasheet. I'm using a 40mm flat trackpad.
I used the file firmware/qmk/stront_zzeneg-rect-flat.uf2

No, I meant pads on the cirque itself:
https://github.com/zzeneg/stront/blob/main/build-guide/choc/17.jpg
Connect trackpad to keyboard and test continuity between testing pads and MCU - first GND and VCC to verify that cable is correctly oriented and inserted, then pin 9 to SS, 10 to SCK, 11 to SI, 12 to SO (I'm not 100% sure on this mapping but just make that pin is connected to some pad 😄).

Ah, yes, the pads on the cirque make sense. I assume the BTN1, BTN2, and BTN3 aren't wired to anything?
Otherwise it looks like I have problems:

DR and SS on the Cirque both got to pin 9 on the MCU
SDA and SCK on the Cirque both go to pin 10 on the MCU
SI and SCL on the Cirque both got to pin 11 on the MCU

2 and 3 are ok, this is how it should be (to support both SPI and I2C modes). However, I don't think that SS should be connected to DR so it may be the problem. I think you have shorted them underneath the FPC vertical connector (second from top pins on both sides). Try to clean/reflow them maybe?

For any future visitors, I removed the line below from keyboards/stront/config.h because my trackpad was now oriented a different direction:
#define POINTING_DEVICE_ROTATION_180


Official Triton Inference Server Image with TRT-LLM support has no TRT-LLM

System Info
I am using A100 GPU 80 GB
Who can help?
@byshiue @ncomly-nvidia
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
So I went to this website to download the official Nvidia image which has a support for TensorRT LLM. I pulled this image using this command:
docker pull nvcr.io/nvidia/tritonserver:24.03-trtllm-python-py3

And once pulled, I ran the image with this command:
docker run -it --gpus all nvcr.io/nvidia/tritonserver:24.03-trtllm-python-py3 bash

Expected behavior
The expected output should be that when I import tensorrt_llm or use trtllm-build inside the container, it should work. However that is not working.
actual behavior
Here is the output I am getting:
:~$ docker pull nvcr.io/nvidia/tritonserver:24.03-trtllm-python-py3
:~$ docker run -it --gpus all nvcr.io/nvidia/tritonserver:24.03-trtllm-python-py3 bash

=============================
== Triton Inference Server ==
=============================

NVIDIA Release 24.03 (build 86102893)
Triton Server Version 2.44.0

Copyright (c) 2018-2023, NVIDIA CORPORATION & AFFILIATES.  All rights reserved.

Various files include modifications (c) NVIDIA CORPORATION & AFFILIATES.  All rights reserved.

This container image and its contents are governed by the NVIDIA Deep Learning Container License.
By pulling and using the container, you accept the terms and conditions of this license:
https://developer.nvidia.com/ngc/nvidia-deep-learning-container-license

NOTE: CUDA Forward Compatibility mode ENABLED.
  Using CUDA 12.3 driver version 545.23.08 with kernel driver version 525.105.17.
  See https://docs.nvidia.com/deploy/cuda-compatibility/ for details.

root@b63ad1046956:/opt/tritonserver# python3
Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>
>>> import tensorrt
>>> import tensorrt_llm
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'tensorrt_llm'
>>>
>>>
>>> import torch
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'torch'
>>>
>>>

additional notes
I am not sure, but I hoped that simply pulling the image and using it should work. But I am blocked while importing the modules.

The Triton server docker images only have the backends installed:
$ docker run -it --gpus all --rm nvcr.io/nvidia/tritonserver:24.03-trtllm-python-py3 bash

=============================
== Triton Inference Server ==
=============================

NVIDIA Release 24.03 (build 86102893)
Triton Server Version 2.44.0

Copyright (c) 2018-2023, NVIDIA CORPORATION & AFFILIATES.  All rights reserved.

Various files include modifications (c) NVIDIA CORPORATION & AFFILIATES.  All rights reserved.

This container image and its contents are governed by the NVIDIA Deep Learning Container License.
By pulling and using the container, you accept the terms and conditions of this license:
https://developer.nvidia.com/ngc/nvidia-deep-learning-container-license

root@67aedfe801bb:/opt/tritonserver# ls -lR backends/
backends/:
total 8
drwxrwxrwx 2 triton-server triton-server 4096 Mar 16 03:58 python
drwxrwxrwx 2 triton-server triton-server 4096 Mar 16 03:57 tensorrtllm

backends/python:
total 2632
-rw-rw-rw- 1 triton-server triton-server 1362472 Mar 16 03:58 libtriton_python.so
-rwxrwxrwx 1 triton-server triton-server 1304768 Mar 16 03:58 triton_python_backend_stub
-rw-rw-rw- 1 triton-server triton-server   21877 Mar 16 03:58 triton_python_backend_utils.py

backends/tensorrtllm:
total 1846324
lrwxrwxrwx 1 triton-server triton-server         35 Mar 16 03:57 libnvinfer_plugin_tensorrt_llm.so -> libnvinfer_plugin_tensorrt_llm.so.9
lrwxrwxrwx 1 triton-server triton-server         39 Mar 16 03:57 libnvinfer_plugin_tensorrt_llm.so.9 -> libnvinfer_plugin_tensorrt_llm.so.9.2.0
-rw-rw-rw- 1 triton-server triton-server    2000936 Mar 16 03:57 libnvinfer_plugin_tensorrt_llm.so.9.2.0
-rw-rw-rw- 1 triton-server triton-server<PHONE_NUMBER> Mar 16 03:57 libtensorrt_llm.so
-rw-rw-rw- 1 triton-server triton-server     339528 Mar 16 03:57 libtriton_tensorrtllm.so
root@67aedfe801bb:/opt/tritonserver#

You need to build the engines separately by installing the necessary dependencies in a different container or potentially in this container but I've never attempted that.

The Triton server docker images only have the backends installed:
$ docker run -it --gpus all --rm nvcr.io/nvidia/tritonserver:24.03-trtllm-python-py3 bash

=============================
== Triton Inference Server ==
=============================

NVIDIA Release 24.03 (build 86102893)
Triton Server Version 2.44.0

Copyright (c) 2018-2023, NVIDIA CORPORATION & AFFILIATES.  All rights reserved.

Various files include modifications (c) NVIDIA CORPORATION & AFFILIATES.  All rights reserved.

This container image and its contents are governed by the NVIDIA Deep Learning Container License.
By pulling and using the container, you accept the terms and conditions of this license:
https://developer.nvidia.com/ngc/nvidia-deep-learning-container-license

root@67aedfe801bb:/opt/tritonserver# ls -lR backends/
backends/:
total 8
drwxrwxrwx 2 triton-server triton-server 4096 Mar 16 03:58 python
drwxrwxrwx 2 triton-server triton-server 4096 Mar 16 03:57 tensorrtllm

backends/python:
total 2632
-rw-rw-rw- 1 triton-server triton-server 1362472 Mar 16 03:58 libtriton_python.so
-rwxrwxrwx 1 triton-server triton-server 1304768 Mar 16 03:58 triton_python_backend_stub
-rw-rw-rw- 1 triton-server triton-server   21877 Mar 16 03:58 triton_python_backend_utils.py

backends/tensorrtllm:
total 1846324
lrwxrwxrwx 1 triton-server triton-server         35 Mar 16 03:57 libnvinfer_plugin_tensorrt_llm.so -> libnvinfer_plugin_tensorrt_llm.so.9
lrwxrwxrwx 1 triton-server triton-server         39 Mar 16 03:57 libnvinfer_plugin_tensorrt_llm.so.9 -> libnvinfer_plugin_tensorrt_llm.so.9.2.0
-rw-rw-rw- 1 triton-server triton-server    2000936 Mar 16 03:57 libnvinfer_plugin_tensorrt_llm.so.9.2.0
-rw-rw-rw- 1 triton-server triton-server<PHONE_NUMBER> Mar 16 03:57 libtensorrt_llm.so
-rw-rw-rw- 1 triton-server triton-server     339528 Mar 16 03:57 libtriton_tensorrtllm.so
root@67aedfe801bb:/opt/tritonserver#

You need to build the engines separately by installing the necessary dependencies in a different container or potentially in this container but I've never attempted that.

I see, building the engine through another container is not a problem, but can you help me on how can I run programs like run.py

The triton backend image only has TensorRT-LLM backend, it does not contain TensorRT-LLM python package. So, you can only run serving on Triton directly. If you want to convert checkpoint or run example on TensorRT-LLM python example, you need to rebuild the TensorRT-LLM and install it.

I see, and I understand that the reason of doing this is to allocate less space. However is it possible to have a image specific to trt llm python?

You can install tensorrt_llm via pip now, but we are still improving the issue of version mismatch.

I see, got it, thanks, will do

hi @byshiue
can you also serve llm with the following docker image?
nvcr.io/nvidia/tritonserver:23.12-py3


Edit message

public function Test(): void
    {
        $this
            ->chat
            ->editMedia($this->messageId)
            ->photo('image.jpg')
            ->send();

        $this
            ->chat
            ->editCaption($this->messageId)
            ->message('<b>caption </b>')
            ->keyboard($this->keyboard())
            ->send();
    }

Can I edit media, caption and keyboard in one request?

Hi, this is not currently supported by Telegram APIs


Fix host target not supported in depthwise_deconv2d

Since MACE v1.0.0, for some unknown reasons, host target support for depthwise_deconv2d has been dropped. This MR solves that issue.

@gasgallo Sorry for the late review, thanks for your contribution!


breaking: drop node 12 support

Breaking
Drop node 12 support (#80)
Build
Upgrade eslint-plugin-ember to v11 (#80)

@ndekeister-us
I rebased your branch, I will let you merge your PR and remove the label wait whenever you want.


User CreatePR Normal Mode – Significant  CLA Signed and  Not Approved_02ndApril2015

Hi @brilliomsinterop, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, DNFBOT;


Add API for restricting system arguments with helpful suggestions

Problem
In pairing with @scotttesler we ended up with a p: 4 on a BorderBox, an option we should not allow to be set on BorderBox. Only by reading the docs did we find the padding option that accomplished what we were trying to do.
Proposed solution
Introduce a way to restrict which system arguments can be passed to a Primer ViewComponent, starting with padding arguments for BorderBox. I've set us up with a nice error message:
ArgumentError: Found 1 violations:

The p system argument is not allowed here. Perhaps you could consider using :padding options of :default, :condensed, and :spacious?

@manuelpuyol given the conversation during our team meeting this morning, what direction do you think we should take this PR? Maybe we land it as-is as a stopgap?

@manuelpuyol given the conversation during our team meeting this morning, what direction do you think we should take this PR? Maybe we land it as-is as a stopgap while we consider better long-term options?

I think that's a good strategy :)


Organize debugging information into separate sections.

/kind documentation
/kind code-refactoring
What mistake did you find / what is missing in the documentation?
There is a lot of debugging information that's on V(4).
We should organize all the debugging information into separate sections relevant to the logs.
For example:
V(4) is for generic debugging information
V(5) is for OpenShift related debugging information
V(6) is for Devfile
V(7) for tar / copyfile scenarios, etc.
etc.
There also needs to be some investigation of what other levels of debugging is used. For example, V(10) shows http debugging information from the OpenShift / Kubernetes clients.
We also need to discuss on what the "highest" level of debugging should be for users. For example, if one were to open up a new issue / bug that they occured, what should we suggest for them to run with the debugging command, for example, we currently use -v 4 as our generic debugging output command.
Should this be odo -v 8 or something else?
TODO:

[ ] Documentation on each level, and add that to /docs/development.adoc
[ ] Discussions as to what level is used for what
[ ] Discussions on what the "highest" level of debug should be. For example, odo -v 4 is too low, it may need to be odo -v 8.

What is the relevance of it?
More organization :)

/kind code-refactoring

feature request looks good to me. @cdrage please go ahead and draft the pr. On the pr we will discuss more or maybe you get some more valuable input from reviewer cc_ @amitkrout


pmmp4

can you update this plugin to pmmp 4?

There's branch, however, I never tested it. https://github.com/CzechPMDevs/BuilderTools/tree/feature/pm-4.0.0


feat(ui): compact control panel menu

Wow, this is awesome! Please @ahochsteger Look at this

I'm thinking about keep both control panel visualizations, let's call the second one ControlPanelLite and add a switch to see one or the other. I think that the lite version is perfect for mobile devices and could be anabled by default on lower sceen size screens

Pull Request Test Coverage Report for Build 551067893

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 19.894%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/router/index.js
0
3
0.0%

Totals

Change from base Build 551028858:
-0.002%

Covered Lines:
1996

Relevant Lines:
10286

💛  - Coveralls

Really impressed, I like this new grid view and appreciate the "group by" option. Some people may prefer the current list view, would it be feasible to have an option to switch back and forth?

@jarrettv wow I'm totally impressed by this beautiful looking UI - very good work!
@robertsLando seems like I have to reconsider some of my plans, but I think the refactoring of ManagedItems that has been merged today may also be used to provide the node data with filtering, grouping and sorting functionality for this UI.
Since both UIs seem to have different strengths I see no problem in providing both UIs (until we may combine these into one if possible), ideally backed by ManagedItems to provide cross-UI functionality (filtering, grouping, sorting, ...), which may also be used by the new mesh graph.
What do you think?

Yep I think the same, I think that some users could find the table more clear others could prefer @jarrettv, if we allow to switch from one to the other esily (and store the preference in settings like for the table settings etc) it would be awesome!
I think Jarret version could be the default one on mobiles

I think Jarret version could be the default one on mobiles

Yes, that sounds good.
We may see them as the "simple UI" with most every-day features and the "advanced UI" with all available features.
I can also imagine the simple UI by default for new users in the future - at least when all important features are there.

We may see them as the "simple UI" with most every-day features and the "advanced UI" with all available features.
I can also imagine the simple UI by default for new users in the future - at least when all important features are there.

I agree!


Use continuous batching by default

for some reason only a single test is run:
======================== 1 failed, 3 warnings in 45.75s ========================

@Wovchena any ideas?

It was meant to run a single test only: the command is python -m pytest -v ./tests/python_tests/test_chat_generate_api.py::test_set_chat_template. The full testing is in the next step.

Replaced by https://github.com/openvinotoolkit/openvino.genai/pull/1455


[WIP] build and push devkit image to reduce build time

Work in progress

Sample e2e tests in GCP: https://github.com/mesosphere/konvoy-image-builder/actions/runs/4310629926/jobs/7519270863
Build time reduced by 5 to 7 minutes.

sample release job: https://github.com/mesosphere/konvoy-image-builder/actions/runs/4310964630/jobs/7519899756
It took 15 minutes compare to 1h15 mins.

Thank you @mkarroqe testing building wrapper locally on M1 Mac.
results:
1st run: time make build-wrapper 11.26s user 4.14s system 8% cpu 2:53.92 total
2nd run: make build-wrapper 1.46s user 2.11s system 53% cpu 6.612 total

Other Stacked PRs:
https://github.com/mesosphere/konvoy-image-builder/pull/715
https://github.com/mesosphere/konvoy-image-builder/pull/714

Lets aim to break this up in smaller chunks

E2e test fixes
release fixes

I was not completely break it down to between e2e fixes and release fixes.
I did moved out GHA configuration to separate PR.


tabulate fails inscrutably when passed a csv

Bug Description
qiime metadata tabulate produces an unrecognized ID column name error when passed a .csv, because it is disregarding the commas as separators and gluing all columns together. This is confusing to newer users.
Steps to reproduce the behavior

Download and unzip this guy: https://data.qiime2.org/2018.4/tutorials/read-joining/fj-joined.zip
In a QIIME 2 environment, run:

qiime metadata tabulate --m-input-file fj-joined/manifest --o-visualization metadata

Error, apparently caused by metadata combining all comma-separated columns into one.

Expected behavior
Either

Error, saying metadata tabulate only works with .tsv
Gracefully handle .csv tabulation, silently, or by adding an additional parameter that defaults to .tsv

Screenshots
If applicable, add screenshots to help explain your problem.

Computation Environment

OS: LinuxMint 19.3
QIIME 2 2020.2

Questions

Are old (V1) SingleEndFastqManifestPhred33 files are the only thing blowing this up? If so, a good error message might be sufficient.

References
forum xref

Are old (V1) SingleEndFastqManifestPhred33 files are the only thing blowing this up?

No, anything that is not a valid TSV will error.

Error, saying metadata tabulate only works with .tsv

The problem is that .tsv isn't a defined file format, generally speaking. TSV is mostly convention based (you can't even use the extension to confirm if its TSV or not, you have to parse the whole document, which is what is happening in the error message above).

Gracefully handle .csv tabulation

The metadata spec only supports TSV (and pandas dataframes), and I would prefer to keep it that way for now. I think adding new metadata-spec compliant file formats is a can-of-worms for another day.
Perhaps we can move the last line up in to the top of the error message? That might help point people towards a solution.
PS - I move this over to the framework, since this doesn't really have anything to do with metadata tabulate - the error message is coming straight from the framework.

PS - I think "inscrutably" is a little bit unfair of a word to use there - the error message has a lot to say, but I don't think that means its impenetrable (its actually all written-out prose, which is a huge step up from a traceback of doom). I think with a little bit of tweaks to the verbiage we can streamline things a bit!

Agreed, @thermokarst. Just the first word that approximated the situation. Unless you're itching to have this wrapped up soon, I'm going to self-assign and mull over how/if text changes can clarify the situation after div-lib is successfully covering core-metrics

The problem is that .tsv isn't a defined file format, generally speaking. TSV is mostly convention based

Saw this on Hacker News today: http://thomasburette.com/blog/2014/05/25/so-you-want-to-write-your-own-CSV-code/


Simplify type annotations

Motivation
Resolve https://github.com/optuna/optuna/issues/4508
Description of the changes

UP007: Fixes Union[x, y] to x | y
UP006: Fixes collection types (e.g. List[str] -> list[str])
F401: Removes unused imports such as from typing import List
I002: Enforces from __future__ import annotations

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@8a7573d). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage        ?   64.20%
=======================================
  Files           ?        3
  Lines           ?      257
  Branches        ?        0
=======================================
  Hits            ?      165
  Misses          ?       92
  Partials        ?        0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


feat(compose): add mac-address parsing

fixes #3290

Thanks, but please sign the commit for DCO
https://github.com/apps/dco
(run git commit -a -s --amend, and make sure that the Signed-off-by: NAME <EMAIL> line with your real name is included in the commit message)

Thanks @AkihiroSuda -- Signed off as requested.


Fails to run on Cygwin

Details:
I do not have either CASSANDRA_HOME or CASSANDRA_MAIN set.
I cannot seem to install getopt in Cygwin.
Problem:
Attempting to run it results in "line 133: getopt: command not found"

I had the same problem with solandra under cygwin. But I've patched solandra.bat using the lines below and the problem disappeared.
:append
set "baseFilePath=%1"
call set "baseFilePath=%%baseFilePath:%CASSANDRA_HOME%=..%%"
set CLASSPATH=%CLASSPATH%;%baseFilePath%
goto :eof


License of the code

Even though the source code is available, it doesn't have a license. I've done the changes needed for the code to build with modern tools, and to convert the graphics at build time, which hasn't required almost any modification to the source code.
@LiraNuna it would be great if you gave permission to license your code under the MIT license (or other license of your choice!). Also, since the MOD player used in this game is also used in WolveSlayer, I could add the license to the source files in that repository too (https://github.com/AntonioND/wolveslayer). I've contacted Payk, who is ok with adding the MIT license to his code, but the MOD player is yours.

Most of my public code has been implicitly licensed under the WTFPL, including ToD.

Thanks for the confirmation! I've added the license to this repository https://github.com/AntonioND/talesofdagur/commit/de174364a5fec8af8c13e31bde2262182ddc70f8 as well as to the MOD player used in WolveSlayer https://github.com/AntonioND/wolveslayer/commit/3f7744e0ee8390de19464f75c8a8ba979d937e38.


update rust version to 1.34.1

Signed-off-by: Axel Nennker<EMAIL_ADDRESS>I read that there were performance improvements in rust and that build time are shorter.
Let's see

@AxelNennker seems like the build is failed due to warnings
https://build.sovrin.org/job/indy-sdk/job/indy-sdk-ci/job/PR-1615/3/execution/node/221/log/
as far as I remember, you have already fixed the same warning in libindy, but not in libnullpay? Could you update libnullpay (and may be libvcx, not sure) in this PR please?

I searched through all file using find . -type f -exec fgrep 1.32.0 {} \; -print
Seem to have searched differently before and found two more today but not libnullpay

@AxelNennker should https://github.com/hyperledger/indy-sdk/pull/1592 changes be applied to libnullpay too?

@AxelNennker should #1592 changes be applied to libnullpay too?

Doesn't hurt. I thought that pulling master, merging and pushing did that already.

PR for nullpay is sent

Seems like vcx also has deprecated atomic declaration
https://build.sovrin.org/job/indy-sdk/job/indy-sdk-ci/job/PR-1615/7/execution/node/1033/log/

I've put the changes into its own PR.


Rename the flutter gallery before shipping

We should make sure the version of the gallery we ship doesn't look to Android to have any relationship with the version in the repo, otherwise people who have one installed will get a conflict when they try to play with the other.

Specifically the identifier here:
https://github.com/flutter/flutter/blob/master/examples/flutter_gallery/android/AndroidManifest.xml
and here:
https://github.com/flutter/flutter/blob/master/examples/flutter_gallery/ios/Runner/Info.plist
Should not be the same as the identifier used in the published Flutter Gallery.  This allows members of the Flutter team to have the officially deployed version of Flutter installed on their phones at the same time as they also have an in-development copy.
I'm not 100% sure what the official bundle identifiers are for Android or iOS but @sethladd or @jason-simmons would know.

Looks like this was fixed?
cc @jason-simmons

I fixed it on Android.  I don't know if iOS also needs changes.

Will find out later. :) Thanks for the update!


[ MB-16105 ] Display additional MTO Compliance info to office UI

Jira ticket
Summary
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Access the
Login as a

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

Messages

:book:
:link: MB-16105

  Generated by :no_entry_sign: dangerJS against 907fdc764314ac8600f8fcc4f091252d92744fd6

Based on the screenshot of the header we may need to add some additional stylings to ensure that the Flag for financial review link is right aligned.

Based on the screenshot of the header we may need to add some additional stylings to ensure that the Flag move for financial review link is right aligned.

Good 👀  Nice catch

@ronaktruss I modified the financial review link to be right aligned. Thanks for catching that!


Usage of dependency-check in .Net

Hi, Hope you're doing great.
I've been using dependency-check plugin on Java without any worries. Got to scan my code and get the report of the different vulnerabilites.
But, that's not the case when i'm trying to use it on .net, the error i keep stumbling on is:
[WARN] An error occurred with the .NET AssemblyAnalyzer;
this can be ignored unless you are scanning .NET DLLs. Please see the log for more details.
[ERROR] Exception occurred initializing Assembly Analyzer.
Regarding that, I have two questions:

Is there any Documentation to rely on and try to debug a little bit more? Got to use the different answers you posted on different posts but i don't really know where to put the builded GrokAssembly.dll (On which directory).
Related to that, which is the directory to use when you specify the route of .net launching dependency-check.sh (the flag needed in order the script to work )

Thanks in advance!

You need to have dotnet core 3.1 installed to use dependency-check to analyze dotnet projects. Our documentation and error message is pretty bad regarding this.  Note that with the pending release of ODC 7.0.0 - the engine will require dotnet 6.0 - see https://github.com/jeremylong/DependencyCheck/pull/4045.

Jeremy, thanks for the quick response.
We alreay have dotnet version 3.1 installed. As i commented, we searched for some posts regarding GrokAssembly.dll, such as this one: https://github.com/jeremylong/DependencyCheck/issues/3951, but really don't know where to put it (The dll file).
May you tell us where specific it should be located?
Previously we added GrokAssembly.dll on the base path (/usr/lib64/dotnet/sdk/3.1.416/)
Also, adding some info about our side:
**.NET Core SDK (reflecting any global.json):
Version:   3.1.416
Commit:    8d3765c609
Runtime Environment:
OS Name:     rhel
OS Version:  8
OS Platform: Linux
RID:         rhel.8-x64
Base Path:   /usr/lib64/dotnet/sdk/3.1.416/
Host (useful for support):
Version: 3.1.22
Commit:  35fa579a30
.NET Core SDKs installed:
3.1.416 [/usr/lib64/dotnet/sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.App 3.1.22 [/usr/lib64/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.22 [/usr/lib64/dotnet/shared/Microsoft.NETCore.App]**

GrokAssembly is embedded in dependency-check - you do not need to put it anywhere. If you have mulitple versions of dotnet on the system you would need to provide the path to the version 3.1 (or dotnet 6.x in the soon to be released ODC version 7). For instance on my system:
$ which dotnet
/usr/local/share/dotnet/dotnet
~/Projects/odc-falsepositives[master*]
$ /usr/local/share/dotnet/dotnet --version
6.0.101
$ dependency-check.sh --dotnet /usr/local/share/dotnet/dotnet  -s . -o .

Yes

I have installed the ASP.NET Core 6.0 Runtime but still getting the same error


hyperref + savebox warning if savebox is defined in preamble with phase-I, II and III

MWE:
\DocumentMetadata{
 testphase=phase-I,
 pdfversion=2.0
}

\documentclass{article}

\usepackage{hyperref}

\newsavebox{\mailText}
\newcommand{\mail}[1]{\savebox{\mailText}{\href{mailto:#1}{#1}}}

% triggers warning if defined in preamble
<EMAIL_ADDRESS>
\begin{document}

% does not trigger warning if defined in body
<EMAIL_ADDRESS>
My e-mail is \usebox{\mailText}.

\end{document}

Output:
lualatex mwe.tex | texlogfilter
LaTeX2e <2022-11-01> patch level 1
Document Class: article 2022/07/02 v1.4n Standard LaTeX document class
Package tagpdf Warning: The rule between parent 'StructTreeRoot/pdf'
(tagpdf)                and child 'Link/pdf2' is not allowed (struct 1)

Output written on microtype.pdf (1 page, 20235 bytes).

Found 1 warning(s)

Well at first you shouldn't do typesetting (and this includes storin text in boxes) in the preamble (quite independant from tagging). Fonts aren't fully setup there.
At second even in the document your code is not correct, the structure it produces is faulty. \savebox and \usebox aren't supported yet. The tagpdf documentation contains some remarks about the problems here (it is in now way trivial ...).


how to raise the SmsChallengeResponse??

I think it's crucial to show a demo that not only orchestrate tasks to listen for but also show how they are raised. Couldn't find anywhere the code that actually raises SmsChallengeResponse  and what bindings such a trigger should have?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32f10048-0374-3561-c66d-6279708b1272
Version Independent ID: 64cbe0eb-0e05-2432-128f-9e738735f0ef
Content: Human interaction and timeouts in Durable Functions - Azure
Content Source: articles/azure-functions/durable/durable-functions-phone-verification.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: azfuncdf

Hi @softchris Thank you for your feedback! We will review and update as appropriate.

@softchris For this tutorial, the manual way of raising an event is mentioned under Run the sample and you can use RaiseEventAsync (.NET) or raiseEvent (JavaScript) inside another function as mentioned.
The twilio binding supports just sending out SMS which is why there is no sample here for listening on receiving one.
That being said, acting on a received SMS is just about adding a webhook URL, which in this case could be the function that raises the required event.

@softchris I hope my previous comment clears things up
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Dont works with ReactForms

i'm try use this plugin with reactforms but no success. I receive the error
ERROR Error: No value accessor for form control with name: 'cpf'
Has some chance to use this with formControl,formGroup?

Hey @domzinhuu , from what I see from the code here:
https://github.com/PeterStaev/nativescript-masked-text-field/blob/deec2627c7f0082c342e2fc1cd73a75c15f99fff/angular/index.ts#L24-L27
it should be working fine. Can you provide the actual html snippet? Also have you registered the module?

i'm try use in html with this:

Thanks for the details. I think I found the problem and will try to fix it soon.

Ok, Thank you.

@domzinhuu , the new version on npm should have this resolved.

@PeterStaev many thanks for the fast solution 👍

@PeterStaev, another problem appeared, The hint property of textfield dont works anymore. can you see this

Hi Guys, Hi @PeterStaev
I am facing a problem that looks like this one but it is strange because this bug is 2 years old :(
I have the following ReactForm
<StackLayout [formGroup]="codeForm">

<MaskedTextField
#codeInput
formControlName="codeInput"
text=""
class="code-verification"
mask="9 9 9 - 9 9 9"
[isEnabled]="!loading"
keyboardType="phone"
autocorrect="false"
autocapitalizationType="none"
(textChange)="onKeyPressed()"
>
And I get the same error :
JS: ERROR Error: No value accessor for form control with name: 'codeInput'
JS: ERROR CONTEXT {
JS:   "view": {
JS:     "def": {
JS:       "nodeFlags": 403326977,
If you can find a little bit of tilme for answering, I would really appreciate.
Thanks a lot,
N

Hey @nickykln , I cannot simulate this behavior. Please refer to the following playground: https://play.nativescript.org/?template=play-ng&id=34i0a5

Angular 7.0 is not supported yet in NS. See https://www.nativescript.org/blog/nativescript-5.0-is-hot-out-of-the-oven . NG 7.0 support is coming in a future release.

i was testing with angular 7 and tns 5, doesn't work. :/

Hey @yassern , I just tried the plaground above (which from what I know is updated to the latest NS + NG) and it still works. If you are having problems please submit a new issue and provide a reproducible example via the NativeSript Playground.
Since this issue is 1+ year I'm locking conversation so users are forced to submit a new issue and provide specific details.


java.lang.UnsupportedOperationException: Not supported in this sample.

Step.1 : I followed all the steps in README, & updated the JSON file
Step:2 : When App installed it gave me a Login Screen.
I tried to login & it always returned error : "INVALID USER/PASSWORD"
Step:3: So, I created a new user in : "User & Groups" under "General Settings" @ https://us-east-2.console.aws.amazon.com/cognito/users/?region=us-east-2#/pool/us-east-2_NKUzp1WHM/users?_k=svb8zk
Step:4: Again tried to login, the App crashes as : java.lang.UnsupportedOperationException: Not supported in this sample.
PLEASE GUIDE AHEAD, ALSO PLEASE ADD FURTHER STEPS IN THE README.

@pacifire Before attempting to SignIn, did you signUp or create a new user? If you have a user signed up through the app and then when you attempt to sign in, it should work.
When you create a new user on the Cognito UserPools console, the flow for signin is different. It uses the FORCE_CHANGE_PASSWORD and the AWS Auth SDK that you are using doesn't support that flow. There are two solutions I could think of for you:

Create a new user through the app and then signin
Create a new user in AWS Cognito UserPools console but make sure a force change password update is not required
You can build your app using the Amazon Cognito UserPools SDK (https://docs.aws.amazon.com/cognito/latest/developerguide/tutorial-integrating-user-pools-android.html) which is available through com.amazonaws:aws-android-sdk-cognitoidentityprovider:2.6.+?


how can deploy like official

https://gradio.app/g/AK391/mlsd

and my deployment is this one:

solved, i found in another .py file, tnks


Change gRPC shape

The gRPC server can only accept a flat input, so we need to reshape the input accordingly.
Changelog

For SKLearn and XGBoost servers, convert the gRPC input to a numpy array and reshape.
Bump version to 0.1.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign adriangonz
You can assign the PR to them by writing /assign @adriangonz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriangonz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pr-build
9943e2e57a520de18c04619d22ffbfcd74932b41
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adriangonz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [adriangonz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fix links after repo name change

Moving from govuk-formbuilder to govuk-form-builder so it's easier to read and more consistent with other projects

Oh, yay! 🎉


[branch-2.10][fix][broker] Duplicate LedgerOffloader creation when na…

Motivation
Cherry-pick PR #21591
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Since the unit test TopicAutoCreationTest.testPartitionedTopicAutoCreation always failed, I pushed a commit on this PR to fix it.


Azure Functions support

Cleaned up the old PR https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/670
I think with the growth in popularity of Azure Functions and Serverless APIs in general, this makes a meaningful addition to Swashbuckle.  Please let me know what else I can do to help make this official.
Thank you for your consideration!

@domaindrivendev thanks! I do have it working and could create as an independent github project however it does require nuget packages targeting netstandard2.0 for at least:

Swashbuckle.AspNetCore.Annotations,
Swashbuckle.AspNetCore.SwaggerGen, and
Swashbuckle.AspNetCore.Swagger

If you could provide these, then I will be able to upload a working package for Swashbuckle.AspNetCore.AzureFunctions. The AzureFunctions does not work with the current packages in nuget.org.
Thanks!

see #913


1Torch was not compiled with flash attention.

I installed the latest version of pytorch and confirmed installation 2.4.1+cu124, when I ran an image generation I got the following message:
:\OmniGen\venv\lib\site-packages\transformers\models\phi3\modeling_phi3.py:633: UserWarning: 1Torch was not compiled with flash attention. (Triggered internally at C:\actions-runner_work\pytorch\pytorch\builder\windows\pytorch\aten\src\ATen\native\transformers\cuda\sdp_utils.cpp:555.)
attn_output = torch.nn.functional.scaled_dot_product_attention(
How do I enable flash attention?

@ialhabbal, FlashAttention does not support arbitrary forms of attention masks, so OmniGen cannot use FlashAttention at the moment.

I also have this problem.
I installed OmniGen via pinocio.computer and this happens every time I try to generate anything.
@staoxiao
I don't really care if it can/can not use flash attention i just want it to work (ie make a generation).
Could you explain how to stop this error?

experienced the same problem whenever I generate something this warning shows up and generation is stuck at 0% progress. I'm using torch==2.3.1+cu118

I have the same warning and the generation is extremely slow (about 3 minutes per single step).


Error if injection-protected expressions are used within a SQL string literal

Partially addressed in 39bb3b0, but still far from a comprehensive/user-friendly solution.


OpenEBS-NDM got stuck in "ContainerCreating" mode on local k8s cluster with docker desktop

Hey  I am new to this stuff, can someone help me resolving the issue I am facing?
So I am trying to use the openebs-local pv provisioner on my local k8s cluster, running with docker desktop. I installled the openebs provisioner according to the documentation with helm v3, but the openebs-ndm container got stuck in the "ContainerCreating" mode.
It gives me the following error message:
Events:
  Type     Reason       Age                From               Message
  ----     ------       ----               ----               -------
  Normal   Scheduled    52s                default-scheduler  Successfully assigned openebs/openebs-ndm-5t8jd to docker-desktop
  Warning  FailedMount  20s (x7 over 51s)  kubelet            MountVolume.SetUp failed for volume "udev" : hostPath type check failed: /run/udev is not a directory

The other pods are running perfectly fine as you can see below:
❯ kgp -n openebs
NAME                                           READY   STATUS              RESTARTS   AGE
openebs-localpv-provisioner-766d5f8b5d-2gvpg   1/1     Running             0          12m
openebs-ndm-5t8jd                              0/1     ContainerCreating   0          12m
openebs-ndm-operator-766cb8b878-ktrfd          1/1     Running             0          12m

Binding a pvc though works but it does not create a volume on the specified hostpath, which seems to me a bit strange. For further information please take a look at my StackOverflow post, which provides additional configuration of my jenkins deployment as well as pvc and storageclass config here.
Could this issue be related to the openbs-ndm container stuck in ContainerCreating mode?
I am really looking forward to resolving this issue, thanks in advance!
Edit:
I guess it is related to the underlying OS (Macos BigSur), because of the different filesystem there is no /run/udev.

Hi team,
I’m working on openebs on AWS instances for both Linux and Ubuntu platforms. I’m facing an issue with the complete installation of openebs using kubectl and helm. There is an ndm pod that couldn’t come in a “running” state. Its status remains creating container. I'm using minikube multi-node cluster here.
NAME                                              READY   STATUS              RESTARTS   AGE   IP             NODE          NOMINATED NODE   READINESS GATES
cspc-operator-7c645f96d9-s847s                    1/1     Running             0          20m   <IP_ADDRESS>     openebs-m03   <none>           <none>
cvc-operator-6b7d6dcbc5-dzm6q                     1/1     Running             0          20m   <IP_ADDRESS>     openebs-m03   <none>           <none>
openebs-cstor-admission-server-6ff6948d9b-trqnk   1/1     Running             0          20m   <IP_ADDRESS>     openebs-m03   <none>           <none>
openebs-cstor-csi-controller-0                    6/6     Running             0          20m   <IP_ADDRESS>     openebs-m02   <none>           <none>
openebs-cstor-csi-node-frvr5                      2/2     Running             0          20m   <IP_ADDRESS>   openebs       <none>           <none>
openebs-cstor-csi-node-pnnfw                      2/2     Running             0          20m   <IP_ADDRESS>   openebs-m03   <none>           <none>
openebs-cstor-csi-node-pw279                      2/2     Running             0          20m   <IP_ADDRESS>   openebs-m02   <none>           <none>
openebs-ndm-cluster-exporter-77dcf59f67-vwtdb     1/1     Running             0          20m   <IP_ADDRESS>     openebs-m03   <none>           <none>
openebs-ndm-node-exporter-624mz                   1/1     Running             0          20m   <IP_ADDRESS>     openebs       <none>           <none>
openebs-ndm-node-exporter-m42d2                   1/1     Running             0          20m   <IP_ADDRESS>     openebs-m02   <none>           <none>
openebs-ndm-node-exporter-pscl5                   1/1     Running             0          20m   <IP_ADDRESS>     openebs-m03   <none>           <none>
openebs-ndm-operator-74d8c6cdf6-2hwgx             1/1     Running             0          20m   <IP_ADDRESS>     openebs-m03   <none>           <none>
openebs-ndm-p9n7d                                 0/1     ContainerCreating   0          20m   <IP_ADDRESS>   openebs       <none>           <none>
openebs-ndm-qv9lm                                 0/1     ContainerCreating   0          20m   <IP_ADDRESS>   openebs-m02   <none>           <none>
openebs-ndm-sr24x                                 0/1     ContainerCreating   0          20m   <IP_ADDRESS>   openebs-m03   <none>           <none>

I have also installed the iSCSI and it was in an active state while installing. Logs for ndm pod are mentioned below.
xyz@worker01:~$kubectl describe pod openebs-ndm-p9n7d -n openebs
Name:         openebs-ndm-p9n7d
Namespace:    openebs
Priority:     0
Node:         openebs/<IP_ADDRESS>
Start Time:   Fri, 03 Dec 2021 06:56:13 +0000
Labels:       controller-revision-hash=587f7b5778
              name=openebs-ndm
              openebs.io/component-name=ndm
              openebs.io/version=3.0.0
              pod-template-generation=1
Annotations:  <none>
Status:       Pending
IP:           <IP_ADDRESS>
IPs:
  IP:           <IP_ADDRESS>
Controlled By:  DaemonSet/openebs-ndm
Containers:
  node-disk-manager:
    Container ID:
    Image:         openebs/node-disk-manager:1.7.0
    Image ID:
    Port:          <none>
    Host Port:     <none>
    Args:
      -v=4
      --feature-gates="GPTBasedUUID"
    State:          Waiting
      Reason:       ContainerCreating
    Ready:          False
    Restart Count:  0
    Liveness:       exec [pgrep ndm] delay=30s timeout=1s period=60s #success=1 #failure=3
    Environment:
      NAMESPACE:          openebs (v1:metadata.namespace)
      NODE_NAME:           (v1:spec.nodeName)
      SPARSE_FILE_DIR:    /var/openebs/sparse
      SPARSE_FILE_SIZE:<PHONE_NUMBER>0
      SPARSE_FILE_COUNT:  0
    Mounts:
      /dev from devmount (rw)
      /host/node-disk-manager.config from config (ro,path="node-disk-manager.config")
      /host/proc from procmount (ro)
      /run/udev from udev (rw)
      /var/openebs/ndm from basepath (rw)
      /var/openebs/sparse from sparsepath (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-ndzrq (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  config:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      openebs-ndm-config
    Optional:  false
  udev:
    Type:          HostPath (bare host directory volume)
    Path:          /run/udev
    HostPathType:  Directory
  procmount:
    Type:          HostPath (bare host directory volume)
    Path:          /proc
    HostPathType:  Directory
  devmount:
    Type:          HostPath (bare host directory volume)
    Path:          /dev
    HostPathType:  Directory
  basepath:
    Type:          HostPath (bare host directory volume)
    Path:          /var/openebs/ndm
    HostPathType:  DirectoryOrCreate
  sparsepath:
    Type:          HostPath (bare host directory volume)
    Path:          /var/openebs/sparse
    HostPathType:
  kube-api-access-ndzrq:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   BestEffort
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/disk-pressure:NoSchedule op=Exists
                             node.kubernetes.io/memory-pressure:NoSchedule op=Exists
                             node.kubernetes.io/network-unavailable:NoSchedule op=Exists
                             node.kubernetes.io/not-ready:NoExecute op=Exists
                             node.kubernetes.io/pid-pressure:NoSchedule op=Exists
                             node.kubernetes.io/unreachable:NoExecute op=Exists
                             node.kubernetes.io/unschedulable:NoSchedule op=Exists
Events:
  Type     Reason       Age                   From               Message
  ----     ------       ----                  ----               -------
  Normal   Scheduled    22m                   default-scheduler  Successfully assigned openebs/openebs-ndm-p9n7d to openebs
  Warning  FailedMount  11m (x2 over 18m)     kubelet            Unable to attach or mount volumes: unmounted volumes=[udev], unattached volumes=[config udev procmount devmount basepath sparsepath kube-api-access-ndzrq]: timed out waiting for the condition
  Warning  FailedMount  9m26s (x4 over 20m)   kubelet            Unable to attach or mount volumes: unmounted volumes=[udev], unattached volumes=[kube-api-access-ndzrq config udev procmount devmount basepath sparsepath]: timed out waiting for the condition
  Warning  FailedMount  2m35s (x2 over 7m9s)  kubelet            Unable to attach or mount volumes: unmounted volumes=[udev], unattached volumes=[udev procmount devmount basepath sparsepath kube-api-access-ndzrq config]: timed out waiting for the condition
  Warning  FailedMount  24s (x19 over 22m)    kubelet            MountVolume.SetUp failed for volume "udev" : hostPath type check failed: /run/udev is not a directory
  Warning  FailedMount  17s (x2 over 4m51s)   kubelet            Unable to attach or mount volumes: unmounted volumes=[udev], unattached volumes=[basepath sparsepath kube-api-access-ndzrq config udev procmount devmount]: timed out waiting for the condition

Also while installing cStor it is not able to detect the block device. I have used this documentation for the installation of cStor.
@DanielSmrecnik Can you please provide me some pointers as to how you solved this problem? Thanks in advance!!

Hi odidev,
I guess the issue is related to the instance that there is no /run/udev directory found, if you take a look at your logs:
MountVolume.SetUp failed for volume "udev" : hostPath type check failed: /run/udev is not a directory
Please check if this directory exists on your machine. In order for openebs to function properly, access to the /run/udev directory is needed.

Hi @DanielSmrecnik
I have checked that /run/udev directory is available in my system, but ndm pod is not able to mount that directory.

I think I know what the problem is with openebs not being able to mount the /run/udev directory in your case. I guess it is related to your minikube cluster, because minikube is running inside docker containers, the /run/udev directory is not mounted into the cluster by default. Try mounting the directory with the minikube mount command into the cluster and re-deploy your openebs pods.
In my case that was not convenient for me, so I switched to microk8s since the minikube mount command needs an open terminal session to have the mount enabled.


Handle 502 bad gateway

Most of the time you get this you can retry instantly and it will go through, would be nice if discordgo handled it in a similar way to rate limits

Merged/fixed with https://github.com/bwmarrin/discordgo/pull/227


Fix Issue 127

Fixes #127
Previously, the user could include any type index among the telescope of arguments in a record or datatype definition, and agda2hs would compile it as if it had type star even if it had a type that should not be compiled to star, such as Nat.
This PR fixes this issue by modifying Agda2Hs.Compile.Type.compileTeleBinds to additionally check that the type of an argument in the telescope is of the form Sort (Type _). Otherwise, it emits a new error message: Kind of bound argument not supported: (<arg name> : <arg type>).
Two fail tests have been added which test a simple datatype definition and record:

tests/Fail/NonStarDatatypeIndex.agda
tests/Fail/NonStarRecordIndex.agda

It seems the test output in test/golden has changed, could you run make golden and push the changes?

I'm sorry for letting this hang for so long! I've just rebased this on master and resolved the conflicts, if CI passes then this can be merged.


Api gateway

Description

A brief description of the changes introduced by this Pull Request.
Issue or Ticket

Fixes #000
Type of change

[ ] Bugfix
[x] New feature
[ ] Version update

Breaking Changes

[ ] Yes
[x] No

Breaking Changes Description

TODOs

[ ] Validate your code matches the style of the project.
[ ] Update the docs.
[ ] Validate all tests run successfull, including pre-commit checks.
[ ] Include release notes and description. This should include both a summary of the changes and any necessary context.

still a WIP need to be able to view the diff and have to go back and review what the code is doing, maybe add some automation, and fix syntax.
This is just an initial, not ready to merge in quite yet.


Update Miniconda version on Windows from 4.6.14 to 4.8.3/latest

Description
New tool, Bug fixing, or Improvement?
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
For new tools, please provide total size and installation time.
Updates miniconda on Windows from 4.6.13 to 4.8.3 (actually to 'latest') to make it in line with the macOS and Ubuntu versions.
Related issue: #1580
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run windows2016, windows2019

Will try to get more context about
# Lock to Miniconda 4.6 until we do the work to run `conda init` for the vsts user
# Then we can go back to installing the latest Miniconda

cc: @brcrista hello Brian! I have found that some time ago, you have hardcoded Miniconda 4.6.14 by https://github.com/microsoft/azure-pipelines-image-generation/commit/ffc77a7776aaba6e1c96a2d2d1deeef1ca11d50a
Related PR: https://github.com/microsoft/azure-pipelines-image-generation/pull/1151
Do you remember any context around it?
We would like to return back to approach of installing latest version but would like to understand if it can break any pipelines and how we can validate it.

@maxim-lobanov yeah, we used to install latest but then we hit an issue as noted in the comment.  I think what happens is that you just can't activate environments anymore because conda will complain that you haven't run conda init.
That's a step we would have to add during image generation.  Should be pretty easy.  It just adds some lines to the shell config, so we would have to do it for Bash, PowerShell, and CMD (on Windows).  Then, we can go back to latest on all OSes.

@brcrista , I have deployed the image based on current changes (without conda init in image-generation) and run canary tests. They passed successfully.
Any concerns to merge this one? Any other tests that we need to run?


Fixed regex for THM, HTB and CTF flags

(?i) can only be at the start of the regex. This caused warnings when running test

Thank youu!!!!!!!!!!!!!!!!!!!


The requested module 'attr-accept/dist/es/index.js' does not provide an export named 'default'

Node: v20.0.0
solid-js: 1.7.5
@soorria/solid-dropzone: 0.0.5

npm.

I'm having the same issue.  I think the issue is that attr-accept/dist/es/index.js uses exports instead of export:
"use strict";

exports.__esModule = true;

exports.default = function (file, acceptedFiles) {
  if (file && acceptedFiles) {
    var acceptedFilesArray = Array.isArray(acceptedFiles) ? acceptedFiles : acceptedFiles.split(',');
    var fileName = file.name || '';
    var mimeType = (file.type || '').toLowerCase();
    var baseMimeType = mimeType.replace(/\/.*$/, '');
    return acceptedFilesArray.some(function (type) {
      var validType = type.trim().toLowerCase();

      if (validType.charAt(0) === '.') {
        return fileName.toLowerCase().endsWith(validType);
      } else if (validType.endsWith('/*')) {
        // This is something like a image/* mime type
        return baseMimeType === validType.replace(/\/.*$/, '');
      }

      return mimeType === validType;
    });
  }

  return true;
};

I guess it's needs to be required instead (or the bug should be reported upstream).

I looked into this more, and there's extensive discussion here: https://github.com/vitejs/vite/issues/3024
I haven't tested yet, but it looks like the current workaround is to modify the config as described here: https://vitejs.dev/guide/dep-pre-bundling.html#the-why
Unfortunately I imagine this has to be done by the user; there's nothing the library can do. ☹
I think the library-level workaround is to use require (via createRequire) until attr-accept offers an ESM build... Or as it's a small dependency we could fork attr-accept and offer our own ESM build.

Thanks for all the help! I did a little tinkering locally, and it seems like the only viable fix is updating the ESM build downstream. I tried createRequire, but since it's a node built-in, it gets mocked in the browser :(.

Thanks for looking into this!
I've made https://github.com/react-dropzone/attr-accept/pull/64 to provide ESM upstream; hopefully it will get approved (and I got it right) and this issue can be fixed the clean way!

Finally found the time, so this should be fixed now since I've vendored the attr-accept package. Downside is, if another package is also using attr-accept, or you import from it directly, it'll be doubled up in the bundle :cry:.


Don't allow using !me after guessing during a round

There is an exploit that can be used with the !me-command. After making a guess, !me will include information about the guess

Current streak will reflect whether user guessed the correct country
Average score includes the score for the guess
5k count includes information about whether the user 5k'd.

If multiguess is turned on, then this information can be used to alter the guess!
This commit fixes this exploit by rejecting the !me-command after guessing during an active round (active being determined whether the 'BROADCASTER' has guessed or not).
Feel free (as always) to make changes as necessary.

The way I intended it to work in the previous version was that !me would exclude any data from the current round. So you could use it at any time but it would execute as if no guess had been made yet. I'm not sure if it ever actually did work like that...
I think this is an acceptable (and probably easier) way to approach it though.

I'm not at home so i can't test it but as Reanna said i'm pretty sure !me used to exclude the current round, maybe it's not the case anymore since the new db request for the specific timeframe ?

The way I intended it to work in the previous version was that !me would exclude any data from the current round. So you could use it at any time but it would execute as if no guess had been made yet. I'm not sure if it ever actually did work like that...
I think this is an acceptable (and probably easier) way to approach it though.

I'm not at home so i can't test it but as Reanna said i'm pretty sure !me used to exclude the current round, maybe it's not the case anymore since the new db request for the specific timeframe ?

It was a while ago now that I looked into this, and when I decided to investigate it a bit more I couldn't reproduce the current streak number being increased or reset after the user guessed, and reading the code, it shouldn't get updated after the user guessed (so at least that makes sense).
The

average score
Correct country statistics
5k number

all seem to be updated though.


Inject some code into bundle

Is it possible to inject some js code into a bundle? For example: I have a few lines of code that I would like to inject into the bundle on the fly. I've tried using an additional entry point, however, if a file is outside of homeDir it won't be loaded, and if I move the code into a dedicated package, it won't execute automatically, since this doesn't work ">+my-package". Any ideas on how one could achieve such behaviour?

I think we are looking at BannerPlugin

@nchanged Thank you for the tip! Plugin name was a bit misleading, I though it's just for comments. It seems that BannerPlugin does not work in combination with QuantumPlugin? Everything works fine except when I enable the QuantumPlugin. Ist there a workaround for this? Thanks!

@maximkott yeah, it doesn't work with Quantum, unfortunately, What you can do instead, is use shims, they will be added first.

@nchanged Thanks, will try that

Closing due to inactivity


Fix #246 by always reporting the 'use strict' directive in the parser

Fix #246
There was a micro optimization in the directive parsing that didn't
bother doing a string comparison to check for the 'use strict' directive
in a function if the function was already in a strict mode context.
That used to be fine but now ES6 says that it is an error if a
function's parameter list is 'non-simple' and the function has a 'use
strict' directive.
Removing the early out and always reporting the directive fixes this bug
by letting the error detection we already had in place do its job.

@pleath @akroshg @abchatra

LGTM

Added missing copyright header to the new test file

Thanks @akroshg


ryujinx: 1.1.733 -> 1.1.748

Description of changes

Update ryujinx to 1.1.748
resolves #229755
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Tested myself, works.
(I tried with an updated version:
  version = "1.1.773"; # Based off of the official github actions builds: https://github.com/Ryujinx/Ryujinx/actions/workflows/release.yml

  src = fetchFromGitHub {
    owner = "Ryujinx";
    repo = "Ryujinx";
    rev = "40c17673f5a1a7c96f548dc4efaf05bba832a340";
    sha256 = "sha256-wT2j5oVCgcQFYIcsXphDqhCzp2sqOssa3rugrvLaR+0=";
  };

)

I just made an update for
ryujinx: 1.1.733 -> 1.1.787
given the crazy pace of updates Ryujinx lately (TOTK release) idk what the preferred update cadence would be. some of these "versions" might not be stable...
in any rate, leaving this patch in case it helps anyone. I can make a PR too, but maybe it'd be better to wait to update nixpkgs until Ryujinx has calmed down?
diff --git a/pkgs/applications/emulators/ryujinx/default.nix b/pkgs/applications/emulators/ryujinx/default.nix
index 61318b300b1..8627b9a5201 100644
--- a/pkgs/applications/emulators/ryujinx/default.nix
+++ b/pkgs/applications/emulators/ryujinx/default.nix
@@ -29,13 +29,13 @@

 buildDotnetModule rec {
   pname = "ryujinx";
-  version = "1.1.733"; # Based off of the official github actions builds: https://github.com/Ryujinx/Ryujinx/actions/workflows/release.yml
+  version = "1.1.787"; # Based off of the official github actions builds: https://github.com/Ryujinx/Ryujinx/actions/workflows/release.yml

   src = fetchFromGitHub {
     owner = "Ryujinx";
     repo = "Ryujinx";
-    rev = "9f12e50a546b15533778ed0d8290202af91c10a2";
-    sha256 = "1d1hg2sv0h56a56xnarcfp73df3rbw3iax85g258l6w2kxhkc42a";
+    rev = "e0544dd9c74e86cca6ee37c4d521d2d07f9ccdcc";
+    sha256 = "tKI9t9hTK7PQ28gXeS6V/dw94FA5eIVyNOnsKg6o9+Y=";
   };

   dotnet-sdk = dotnetCorePackages.sdk_7_0;
@@ -80,7 +80,7 @@ buildDotnetModule rec {
   ];

   projectFile = "Ryujinx.sln";
-  testProjectFile = "Ryujinx.Tests/Ryujinx.Tests.csproj";
+  testProjectFile = "src/Ryujinx.Tests/Ryujinx.Tests.csproj";
   doCheck = true;

   dotnetFlags = [
diff --git a/pkgs/applications/emulators/ryujinx/deps.nix b/pkgs/applications/emulators/ryujinx/deps.nix
index 2eff905dead..5aab354498d 100644
--- a/pkgs/applications/emulators/ryujinx/deps.nix
+++ b/pkgs/applications/emulators/ryujinx/deps.nix
@@ -50,10 +50,10 @@
   (fetchNuGet { pname = "Microsoft.CSharp"; version = "4.7.0"; sha256 = "0gd67zlw554j098kabg887b5a6pq9kzavpa3jjy5w53ccjzjfy8j"; })
   (fetchNuGet { pname = "Microsoft.DotNet.PlatformAbstractions"; version = "3.1.6"; sha256 = "0b9myd7gqbpaw9pkd2bx45jhik9mwj0f1ss57sk2cxmag2lkdws5"; })
   (fetchNuGet { pname = "Microsoft.Extensions.DependencyModel"; version = "6.0.0"; sha256 = "08c4fh1n8vsish1vh7h73mva34g0as4ph29s4lvps7kmjb4z64nl"; })
-  (fetchNuGet { pname = "Microsoft.IdentityModel.Abstractions"; version = "6.29.0"; sha256 = "06sdjg78764ycaq3bd32daacd9pjsvkihdzrw8d1cnmk3c42kvq3"; })
-  (fetchNuGet { pname = "Microsoft.IdentityModel.JsonWebTokens"; version = "6.29.0"; sha256 = "0iydfzz4vzzpx24q8mgvc3n289s00inc19x6a0w2v378mx4jkfl0"; })
-  (fetchNuGet { pname = "Microsoft.IdentityModel.Logging"; version = "6.29.0"; sha256 = "04vj5h638ljz2fylr2idgjbfq5lzbw79m5ixcj1ikl4ydl9jhp9p"; })
-  (fetchNuGet { pname = "Microsoft.IdentityModel.Tokens"; version = "6.29.0"; sha256 = "05crx7w79m3jxlbnfc2c8i63m5z6h28y04qv6sc84312rzi2yw8c"; })
+  (fetchNuGet { pname = "Microsoft.IdentityModel.Abstractions"; version = "6.30.1"; sha256 = "1jb7za7kc41zx4vafpmyj42vzqb407b34npb9g6f42sk7127hip1"; })
+  (fetchNuGet { pname = "Microsoft.IdentityModel.JsonWebTokens"; version = "6.30.1"; sha256 = "1c1hs0nrzlrpvdrpj01yr7cdknh19gdxrahndb5fmn8p4k1vljlv"; })
+  (fetchNuGet { pname = "Microsoft.IdentityModel.Logging"; version = "6.30.1"; sha256 = "02dkmh0qc2sfayvhzp8fgvn58b84yn8z4x3aijvjqahcwv14wfzs"; })
+  (fetchNuGet { pname = "Microsoft.IdentityModel.Tokens"; version = "6.30.1"; sha256 = "1283v1ynl7wp5llyswj2nd8l3pkj7yhcksy2slanid52iyqzzan1"; })
   (fetchNuGet { pname = "Microsoft.IO.RecyclableMemoryStream"; version = "2.3.2"; sha256 = "115bm7dljchr7c02hiv1r3l21r22wpml1j26fyn2amaflaihpq4l"; })
   (fetchNuGet { pname = "Microsoft.NET.Test.Sdk"; version = "17.5.0"; sha256 = "00gz2i8kx4mlq1ywj3imvf7wc6qzh0bsnynhw06z0mgyha1a21jy"; })
   (fetchNuGet { pname = "Microsoft.NETCore.Platforms"; version = "1.0.1"; sha256 = "01al6cfxp68dscl15z7rxfw9zvhm64dncsw09a1vmdkacsa2v6lr"; })
@@ -177,7 +177,7 @@
   (fetchNuGet { pname = "System.Globalization"; version = "4.3.0"; sha256 = "1cp68vv683n6ic2zqh2s1fn4c2sd87g5hpp6l4d4nj4536jz98ki"; })
   (fetchNuGet { pname = "System.Globalization.Calendars"; version = "4.0.1"; sha256 = "0bv0alrm2ck2zk3rz25lfyk9h42f3ywq77mx1syl6vvyncnpg4qh"; })
   (fetchNuGet { pname = "System.Globalization.Extensions"; version = "4.0.1"; sha256 = "0hjhdb5ri8z9l93bw04s7ynwrjrhx2n0p34sf33a9hl9phz69fyc"; })
-  (fetchNuGet { pname = "System.IdentityModel.Tokens.Jwt"; version = "6.29.0"; sha256 = "09bpj7gginq25fiyq3za5i8wm482qbnx6qhm4dxb95jrl3mmb126"; })
+  (fetchNuGet { pname = "System.IdentityModel.Tokens.Jwt"; version = "6.30.1"; sha256 = "1f4x5sw9wpkk485lchl0nzdzkcy83s9b119c7g187x0qvkcvdpc2"; })
   (fetchNuGet { pname = "System.IO"; version = "4.1.0"; sha256 = "1g0yb8p11vfd0kbkyzlfsbsp5z44lwsvyc0h3dpw6vqnbi035ajp"; })
   (fetchNuGet { pname = "System.IO"; version = "4.3.0"; sha256 = "05l9qdrzhm4s5dixmx68kxwif4l99ll5gqmh7rqgw554fx0agv5f"; })
   (fetchNuGet { pname = "System.IO.Compression"; version = "4.1.0"; sha256 = "0iym7s3jkl8n0vzm3jd6xqg9zjjjqni05x45dwxyjr2dy88hlgji"; })

Not related to the PR, but I just noticed that the input stdenvNoCC isn't used for anything.

Is this PR dead?

Is this PR dead?

No, just didn't have the time to work on it. I'll update it and hopefully it'll be ready to merge

Might as well run the update script again, and ask for another review.

Arguably an update PR isn't dead because it's still an update, just not the latest.
People are always welcome to submit fresh PRs & ryujinx should be trivial to update due to the update script - nix-shell ./maintainers/scripts/update.nix --argstr package ryujinx

There was an issue when running the script, I think my laptop went to sleep. If there are any issues with the update ofborg should pick them up

The PR title should be updated.

done

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2265


fix: Use Standard Interface for Metrics Tags

Convert keyword argument into hashes in order to fulfill Temporal::Metrics API contract obligations.
Fixes: #90

@DeRauk @jeffschoner @calum-stripe Can someone kindly check this?

I don’t have permissions to merge changes in the repo. Only DeRauk can do that. However, looking at the linked issue, is it possible to add task queue tags to more of these sites?

Added in few more places that I found feasible. I would really love to get a review and if possible merge to trunk.

@DeRauk @jeffschoner @calum-stripe ^bump

@VAIBHAV7500 sorry for the (huge) delay. If you wouldn't mind resolving conflicts and tagging me again I'd be happy to merge.

@DeRauk I have resolved the conflicts. Kindly take a look.

Merged, thank you!


example still incorrect

why is issue #278 closed if the example code has not been updated ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bbb586e8-9c5d-c4da-a3ac-db93ea727e09
Version Independent ID: 64df6b50-ba8a-5d6f-2c40-eb2b5307817c
Content: Stage AV and OAuth certificates in Skype for Business Server 2015 using -Roll in Set-CsCertificate
Content Source: Skype/SfbServer/manage/authentication/stage-av-and-oauth-certificates.md
Product: skype-for-business-itpro
GitHub Login: @MicrosoftHeidi
Microsoft Alias: heidip

This issue has been added to the teams backlog internally. We can also leave this open if you prefer and close once the issue is closed on internal backlog system.

This is coming up in sprint plan. When I move the issue into the teams backlog I close it here for housekeeping and a note that they will respond to this thread. Responding re-opens an issue and it is OK to respond anytime to any issue whether it is closed or open. This is in backlog and will be fixed soon.

This should be resolved. If not please re-open.


Change IsInRoles to IsInAnyRoles

Fix #862

I have updated the tests to include a new tests that checks that a user gets authorized when only one of the roles matches.


Changes

Changes:
created a branch, created a file and made a commit, and opened a pull request.

Changes:
created a branch, created a file and made a commit, and opened a pull request.

ok

Changes:
created a branch, created a file and made a commit, and opened a pull request.

ok


Seesion cockie not provided all the times

HI,
I use the following code OIDC using express which works, However after few success calls (3-10), I sometimes get internal server error with the following  error,
Any idea what could be wrong?
Error: did not find expected authorization request details in session, req.session["oidc:accounts.rvm.com"] is undefined
at /opt/node_app/app/node_modules/openid-client/lib/passport_strategy.js:125:13
at OpenIDConnectStrategy.authenticate (/opt/node_app/app/node_modules/openid-client/lib/passport_strategy.js:173:5)
at attempt (/opt/node_app/app/node_modules/passport/lib/middleware/authenticate.js:366:16)
at authenticate (/opt/node_app/app/node_modules/passport/lib/middleware/authenticate.js:367:7)
at /opt/node_app/app/src/logon.js:92:7
at Layer.handle [as handle_request] (/opt/node_app/app/node_modules/express/lib/router/layer.js:95:5)
at next (/opt/node_app/app/node_modules/express/lib/router/route.js:137:13)
at Route.dispatch (/opt/node_app/app/node_modules/express/lib/router/route.js:112:3)
at Layer.handle [as handle_request] (/opt/node_app/app/node_modules/express/lib/router/layer.js:95:5)
at /opt/node_app/app/node_modules/express/lib/router/index.js:281:22

My code from the stack is
at /opt/node_app/app/src/logon.js:92:7

which is the end of the code
    })(req, res, next);   //here is the error

This is the full code (I pass the app which is simply express server) , am I doing something wrong?
This is the index.js
const express = require('express');
const logon = require('./logon');

const app = express();
const port = process.env.PORT || 4000;

logon(app)
  .then(() => {
    console.log('process started');
  });
app.use(express.json());

app.listen(port,
  () => console.log(`listening on port: ${port}`));

This is the logon.js
const { Issuer, Strategy } = require('openid-client');
const cookieParser = require('cookie-parser');
const cookieSession = require('cookie-session');
const azpi = require('./azpi');
const bodyParser = require('body-parser');
const passport = require('passport');

module.exports = async (app) => {

  let oSrv;
  const durl = `${process.env.srvurl}/.well-known/openid-configuration`;
  try {
    oSrv = await Issuer.discover(durl);
  } catch (err) {
    console.log('error occured', err);
    return;
  }

  app.get('/', prs(), passport.authenticate('oidc'));

  const oSrvCli = new oSrv.Client({
    client_id: process.env.ci,
    client_secret: process.env.cs,
    token_endpoint_auth_method: 'client_secret_basic',
  });

  passport.serializeUser((user, done) => {
    done(null, user);
  });
  passport.deserializeUser((obj, done) => {
    done(null, obj);
  });

  const cfg = {
    scope: 'openid',
    redirect_uri: process.env.ruri,
    response_type: 'code',
    response_mode: 'form_post',
  };

  const prs = () => (req, res, next) => {
    passport.use(
      'oidc',
      new Strategy({ oSrvCli , cfg }, (tokenset, done) => {
        const claims = tokenset.claims();
        const user = {
          name: claims.name,
          id: claims.sub,
          id_token: tokenset.id_token,
        };
        return done(null, user);
      }),
    );
    next();
  };
  app.use(
    bodyParser.urlencoded({
      extended: false,
    }),
  );
  app.use(cookieParser('csec'));
  app.use(
    cookieSession({
      name: 'zta-auth',
      secret: 'csect',
    }),
  );

  app.use(passport.initialize());
  app.use(passport.session());

  app.get('/redirect', async (req, res, next) => {
    passport.authenticate('oidc', async (err, user) => {
      if (err) {
        console.log(`Authentication failed: ${err}`);
        return next(err);
      }
      if (!user) {
        return res.send('no identity');
      }

      req.login(user, async (e) => {
        if (e) {
          console.log('not able to login', e);
          return next(e);
        }
        try {
          const url = await azpi.GetUsers(user.id_token);
          return res.redirect(url);
        } catch (er) {
          res.send(er.message);
        }
      });
    })(req, res, next);   //here is the error
  });
};

if something is missing please let me know.
Environment

Operating System: linux
Node version: 12.18.3
passport version: 0.41

Have you figured out what was the issue? I have same issue. On redirect request session is empty but if press enter and do the GET request manually the session is there.

Have you figured out what was the issue? I have same issue. On redirect request session is empty but if press enter and do the GET request manually the session is there.


retry test_big_query_legacy_sql

Addresses https://github.com/apache/beam/issues/30513 and https://github.com/apache/beam/issues/29617
Simply retry this test for now.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

PTAL: https://github.com/apache/beam/issues/29617#issuecomment-2134229550
If the problem is in the wheel, a retry also won't fix it.

PTAL: #29617 (comment)
If the problem is in the wheel, a retry also won't fix it - we'd have to rebuild the wheel.

I suggest we can retry this for now to check whether it can reduce the flaky rate.

I'm seeing this lint error: https://ge.apache.org/s/okz5qrmc7tpys/console-log/task/:sdks:python:test-suites:tox:pycommon:lint?page=1#L41

Fixed.


fix(pie): Process series data-Array . close #11247

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?
To support pie chart series.data to reduce Array .
Fixed issues

Details
Before: What was the problem?
Pie chart series.data can not support to process Array .

After: How is it fixed in this PR?
When pie chart init , process the series data to support Array data.

Usage
Are there any API changes?

[ ] The API has been changed.

Related test cases or examples to use the new APIs
NA.
Others
Merging options

[x] Please squash the commits into a single one when merge.

Other information

My first commit is not correct,so I resubmit to fix #11247 to support pie chart series.data to process Array  data.


Investigate best practices for font loading

The Material Design fonts are pretty much required for MDL.
Currently developers need to include it themselves using
<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">

We should include it automatically using an @include in the MDL CSS.

Superceded by https://github.com/material-components/material-components-web/issues/40


Added translations for new features

Added translation for:

Importer.Model.Advanced.PreferSpecular
CameraControl.Settings.AudioFromCameraViewpoint
Inspector.Audio.ExtractSides

(this comment will be updated if more changes will be made before this pull request's merge/closing)

Thank you for the new translations!

Thank you for the new translations!


Store option to auto-discover fields from the data itself

Store requires a fields config to enumerate which fields are expected to be extracted and maintained from a source dataset loaded into the Store. The developer must enumerate these fields, or they won't be loaded.
The support in GridModel to auto-configure fields for its columns alleviates much of this burden, but there are cases where fields are not the primary field for a column and yet are still needed in the records, either for use in complex column renderers or elsewhere in the code where the record is passed around. This can lead to a split definition for fields, where the store is configured with the "extra" fields and the rest are inferred from the columns.
We should explore supporting a mode for store where it auto-discovers and installs fields for any own properties of objects fed to it in its data load, avoiding the need for field enumeration in any simple cases where the developer wants (or at least doesn't mind) all fields in the source dataset being loaded and there aren't performance or other considerations that would make this overly inefficient.

I'm going to close this as NPTF given our recent emphasis on leaning on store field configs more rather than less (for types, filtering, display properties, etc)


New package: TechI v0.1.0

Registering package: TechI
Repository: https://github.com/p-w-rs/TechI.jl
Created by: @p-w-rs
Version: v0.1.0
Commit: 51aee8329cdcfcd9be3e6fc907d45c011efb2c61
Git reference: HEAD
Description: Technical indicators for algorithmic trading in Julia

[noblock] You do see the message posted by the bot, right?

Also, probably a better name for this package would be TechnicalIndicators (not totally sure if that’s an appropriate technical term, no pun intended). Or maybe TradingIndicators. Short, non-descriptive names are generally frowned upon in the Julia community.

Closing in favor of https://github.com/JuliaRegistries/General/pull/120105


Documentation: Update list of Jenkins jobs

This updates the list of Jenkins jobs that can be triggered with trigger phrases in the documentation to more closely match the jobs currently running in Jenkins.
I'm not sure if the trigger phrases are correct.

This should now be correct with respect to the trigger phrases too. I've removed the pipeline jobs from the list as they are run periodically rather than being triggered by PRs.

This should now be correct with respect to the trigger phrases too. I've removed the pipeline jobs from the list as they are run periodically rather than being triggered by PRs.


npm not aligned with github

🎉 Description

The Crowdsale.sol constructor declares argument token in 1.6.0 on github but npm installs a code without that argument.

[x] 🐛 This is a bug report.
[ ] 📈 This is a feature request.

💻 Environment
Next, we need to know what your environment looks like.

Which version of OpenZeppelin are you using? 1.6.0
What network are you deploying to? testrpc? Ganache? Ropsten? n/a
How are you deploying your OpenZeppelin-backed contracts? truffle? Remix? Let us know!
N/A

📝 Details
token argument is just missing in the npm installed code.
🔢 Code To Reproduce Issue [ Good To Have ]
mkdir InstallOZ
cd InstallOZ/
npm i zeppelin-solidity
cat node_modules/zeppelin-solidity/contracts/crowdsale/Crowdsale.sol | grep "function Crowdsale"

The output is a constructor without argument token

👍 Other Information

Happens to me too, any solution?

Hi @ddbit! Thanks for reaching out
Would you mind providing a link to the documentation you are looking at? You can check that commit was not included in the release, please see the diff and the released contract.

Hi @facuspagnuolo, definitely my fault, I wrongly assumed the 1.6.0 was carrying this novelty but actually it is not. The master is some commits ahead. We can close the issues

Hi @facuspagnuolo, definitely my fault, I wrongly assumed the 1.6.0 was carrying this novelty but actually it is not. The master is some commits ahead. We can close the issues


Include nuttx/compiler.h from string.h

NuttX' string.h is using the FAR preprocessor definition, which is
defined in nuttx/compiler.h.  Thus, it should include it.
Signed-off-by: Michael Jung<EMAIL_ADDRESS>

let's ignore the false alarm.


Popover needs set max height

Browser
No response
Description
Bug found by Matt - documenting here:

@andreancardona @francinelucca ...we need to set a height on the popover content because when its parent is position sticky, and when the popover content is tall, you can't get to the bottom of the popover content.
We could achieve this by setting overflow scroll (whatever is needed for smooth scroll iOS in CSS) and then a max-height that's 100vh minus whatever's above it.
It'd be nice to not need a new dependency for this, but this library is popular to get around cross browser mobile quirks.
https://www.npmjs.com/package/react-div-100vh

Steps to reproduce

[ ] change viewport size to mobile. In short view you cannot scroll to see the full content in the popover

https://user-images.githubusercontent.com/32720851/172722163-b0e486d0-3341-4def-9ff8-98d9d6224984.mov

Let's try to fill the viewport height if possible instead of randomly setting height like 80% because there's no backdrop on the page (like a side nav interaction.)


relatively minor edits

Tom asked me to take a look so I did. Great update! Lots of exciting stuff. Minor edits only here. May require a quick check before merging

Thanks! I made the edits in https://github.com/lbryio/lbry.com/commit/f7601086aff8626cf4512f610ce5826d4e7ac9a3 manually since the file was updated recently.


Create first release

In first release will be supported only implementations which emit GarbageCollectionNotificationInfo through GarbageCollectorMXBean. So at least OpenJDK and Oracle JDK will be supported. Also, the functionality for collection raw data from GC and the functionality for aggregation will be totally isolated from each other, so in future releases other types of JVM can be supported as well.
The corner metrics which should be implemented in first release:

How many time JVM spent in stop the world (pause initiated by GC) during last N seconds.
Rolling time window histogram for STW.
Exposing statistics via JMX.
Integration with Metrics-Core library.

Just came across gc-monitor.  A few quick things:

README mentions only OpenJDK, but this issue also mentions Oracle.  I assume this issue is correct?
The README doesn't really say how exactly to add gc-monitor to a Java app...
Is this meant to be added to an app just via CLASSPATH?  I'm asking because we run http://sematext.com/spm and I'd be curious to see if we could simply include this in our existing agent package, then somehow add it to the monitored app, and finally collect metrics this collects via JMX
Thanks!

@otisg hello,
I done testing and plan to write documentation at this weekend(and maybe release official version).
The quick answers to your questions:

Oracle JDK is supported as well, I suppose that gc-cmonitor covers any JDK which built on top on OpendJDK. gc-cmonitor relies on OpendJDK and derivatives because uses specific way to register JMX listener 1, in common case it is not required to implement NotificationEmmiter in GarbageCollectorMXBean.
GcMonitor is plain old java objects without any special requirements. To activate monitoring it is need to create GcMonitor instance and call method start. This example shows how to print statistics to console:

public static void main(String[] args) throws InterruptedException {
        GcMonitor gcMonitor = GcMonitor.builder()
                .addRollingWindow("15min", Duration.ofMinutes(15))
                .build();
        gcMonitor.start();

        try {
            while (true) {
                System.out.println(gcMonitor.getSnapshot());
                TimeUnit.SECONDS.sleep(5);
            }
        } finally {
            gcMonitor.stop();
        }
}

You can use gcMonitor.getSnapshot() inside your profiler to obtains statistics.
This example shows how to expose statistics via JMX.


Tests failed 2, passed 506

When I run the unit tests without making any change to the code, 2 tests failed, the others are fine and the tiglviewer is working.
The tests are:

OccIssues/GeomAPI_ExtremaCurveCurve
GordonSurface/TiglBSplineAlgorithms/testFromBrep/9

Machine configuration:
OS : centos 7
Used libs: oce-0.17, Qt5
The tests output:

/home/cfse/Malo/tigl/cmake-build-debug/tests/unittests/TiGL-unittests --gtest_filter=* --gtest_color=no
/home/cfse/Malo/tigl/tests/unittests/testOccIssues.cpp:52: FailureValue of: extrema.NbExtrema()
Actual: 1
Expected: 2
/home/cfse/Malo/tigl/tests/unittests/testOccIssues.cpp:56: FailureThe difference between c1->FirstParameter() and p1.Distance(p2) is 0.68237463714649649, which exceeds 1e-4, where
c1->FirstParameter() evaluates to 0,
p1.Distance(p2) evaluates to 0.68237463714649649, and
1e-4 evaluates to 0.0001.
/home/cfse/Malo/tigl/tests/unittests/testOccIssues.cpp:60: FailureThe difference between 0.215758486 and u2 is 0.020546618337591915, which exceeds 1e-6, where
0.215758486 evaluates to 0.215758486,
u2 evaluates to 0.19521186766240808, and
1e-6 evaluates to 9.9999999999999995e-07.
unknown file: Failure
FailureUnknown C++ exception thrown in the test body.
Time wingGetPoint [us]: 90Time fuselageGetPoint [us]: 0Time PointTranslator [us]: 23Triangularization time [ms]: 30
Number of Polygons/Vertices: 2434/1370Triangularization time [ms]: 1530
Number of Polygons/Vertices: 23176/11838Number of Polygons/Vertices: 13962/7368Average time: 0.000000 [ms]Runtime getIsOnTop [us]: 1800Elapsed time per projection [us]: 6.5unknown file: Failure
FailureC++ exception with description "Curves do not intersect each other" thrown in the test body.

OCE 0.17 contains a bug. Out test cases check, whether the OpenCASCADE bug is present or not.
TiGL relies on the bugfix. Therefore we provide patched OCE binaries in our releases.
To fix this issue, either

use our OCE binaries from https://build.opensuse.org/package/show/science:dlr/OCE
or patch OCE by yourself with the patch https://github.com/DLR-SC/tigl/blob/cpacs_3/patches/oce-0.17/fix-geomapi_extremacurvecurve.patch


AMQP-484: Selectable SSL Algo

JIRA: https://jira.spring.io/browse/AMQP-484
(must remain at SSLv3 when backporting to 1.4.x)
Also add overridable method for additional context customization.

Pushed

Merging and cherry-picking with appropriate fix for the SSLv3

Merged and cherry-picked

Hi Gary,
I am currently using version 1.4.5 of spring-rabbit. I need to be able to connect my rabbitmq client with the server with TLSv1.2. I see that with this version (1.4.5) I can achieve this by configuring the sslAlgotithm as TLSv1.2. However, to get this to work, using SSL certificates becomes mandatory (sslPropertiesLocation). Otherwise, it just ends up using the default, SSLv3. I would like to know if I could avoid using certificates and still use TLSv1.2. Thanks in advance.

Thank you, @kalpa7, for feedback!
Please, move you question to StackOverflow. From one side GitHub PullRequests aren't intended for community support, from other side we can't help you right now, but with StackOverflow you may get a help from other community members.
Best regards,
Artem

Sorry for the delay, I was traveling.
Please open a JIRA Issue.
Currently, you are correct.
You can work around this by creating a subclass of RabbitConnectionFactoryBean and override setUpSSL()...
protected void setUpSSL() throws Exception {
	this.connectionFactory.useSslProtocol("TLSv1.2");
}

https://jira.spring.io/browse/AMQP-500


Not finding the movesToNextViewController

I didn't find this method:
contentVC.movesToNextViewController = YES;

What is the issue you're having? movesToNextViewController is not a method, its a property on OnboardingContentViewController.

Updates?

Closing this for now until any updates come in.


fix: tag detection when no git tag

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.90%. Comparing base (5a982a2) to head (1481326).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   90.77%   90.90%   +0.13%
==========================================
  Files           7        7
  Lines         206      209       +3
  Branches       33       33
==========================================
+ Hits          187      190       +3
  Misses         16       16
  Partials        3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


converting from notebook or markdown to Rmarkdown

Hi Aaron,
thank you for this wonderful package. Is it planed or would be possible to get the option of converting markdown files or notebooks to Rmarkdown? I think that for those (like me) how use RStudio as editor would be very helpful to be able to convert from a notebook or markdown file to Rmarkdown ;-)
Cheers,
jmm

@jmmtra I've been considering doing this. As far as I can tell, all that I'd need to enable is code-blocks annotated with r:
```r
...code...
```

Is this all that would need doing?
There are code-chunk options as well, but these are lost in the notebook format so I don't think I'd enable them as output.

@aaren thank you for your reply.
I've been playing around converting back and forth. I've seen that converting from Rmd to markdown or notebook preserves the yaml header. One can always go back to Rmarkdown just using the Rmd extension when converting to markdown. For my case is enough, I will be editing ipython notebooks in RStudio.
notedown notebook.ipynb --to markdown --strip > rmarkdown.Rmd

If the files contained code cells/chunks with code in other language but python, notedown does different interesting things. The behaviors that I've seen are OK if the goal is to work on a IPython notebook (magic, etc.). I reckon that if the focus is on R, one should use an R kernel with Jupyter, right?
So, now that I've experimented a bit I only have three ideas to ease the workflow when converting back and forth:

when converting from notebook to markdown/Rmarkdown: to try to restore the programming language information for the code-chunks that were not python originally (shell, r, perl), this is more or less what you said regarding r code-blocks annoted with r.
when converting from Rmarkdown to notebook: to try to comment the yaml header (so it is kept invisible)
when converting from notebook to Rmarkdown: to try to uncomment the yaml header

Cheers!

@chozelinek In case you don't know, there is ipyrmd which specializes in Rmarkdown.