Docker Image Removal Bug By Id

There is a bug with image removal where an image with multiple tags will be allowed to be removed regardless of whether that image is in use or not if you try to remove by id.
 The daemon believes the images have been deleted, but all layers/diffs in the aufs directory are still present.
However, we have seen (in specific scenarios that we are trying to replicate) that this has actually caused  corruption of the AUFS filesystem that results in our containers failing (the mounts report stale file handles). When investigating /sys/fs/aufs, we see a tree that looks like:
/var/lib/docker/aufs/diff/9b0f8af8b250f69018b9ad8be2a38f431f052c26070999a5a853117ef3434d33=rw
/var/lib/docker/aufs/diff/9b0f8af8b250f69018b9ad8be2a38f431f052c26070999a5a853117ef3434d33-init=ro+wh
/var/lib/docker/aufs/diff/0356cece37f331dbf58a7791d3e382c3a1a94925b2f78049c1a0532f7066c776=ro+wh
/var/lib/docker/aufs/diff/97ca33ff69ce3356de59eb8f51db07add123b0b1ea60afac9334d7d301b17571=ro+wh
/var/lib/docker/aufs/diff/ac9a4e035be92cb89ff42c22ae59258d9fbdc5f8b39ba51768fad99666322e69=ro+wh
/var/lib/docker/aufs/diff/f6fab3b798be3174f45aa1eb731f8182705555f89c9026d8c1ef230cbf8301dd=ro+wh
/var/lib/docker/aufs/diff/f10807909bc552de261ca7463effc467600c3dca68d8e7704425283a6911d2ca=ro+wh
/var/lib/docker/aufs/diff/511136ea3c5a64f264b78b5433614aec563103b4d4702f3ba7d4d2698e22c158=ro+wh
/var/lib/docker/aufs/diff/6b8af1d0e4a5dbf4383dc77d35f4f8dc78aefbeb4ce309e6cbc0df081228e126=ro+wh
/var/lib/docker/aufs/diff/35907e19c7516b193cd2603eba74294108159156d9312342e7f34b11601d2f18=ro+wh
/var/lib/docker/aufs/diff/e931d87ef04c0628d7f3934ae61f5e5efb2e918a363854303ab04685a87b6132-removing\040(deleted)=ro+wh
/var/lib/docker/aufs/diff/3a827c23bfd56b9ad671d5c19ca8096e0ac3dff0278cd26f8d24108362a133a0=ro+wh
/var/lib/docker/aufs/diff/c667667f49b4c339b4b89ff65273bf43921c9e743231ccf87815a611fdb38847=ro+wh
/var/lib/docker/aufs/diff/07a6c5b3b160da1e648955e3236a530c7cf3483ef8018d1cba3739e3edfd77e8=ro+wh
/var/lib/docker/aufs/diff/fae229a5cb2207dede4f300169c72b47771da5eec7101f7bf428ef16284df3e5=ro+wh
/var/lib/docker/aufs/diff/aa74c8db2e1ca874f364995aefaea646e6dd91281bb194ddafc201a1166b2ba9=ro+wh

As mentioned, we're still trying to replicate this particular issue, but we're fairly confident it stems from the fact that the daemon allows for these images to be deleted when they shouldn't be. When this happens, we see this in our aufs/mnt directory:
root@host:~# ls -al /var/lib/docker/aufs/mnt/
ls: cannot access /var/lib/docker/aufs/mnt/9b0f8af8b250f69018b9ad8be2a38f431f052c26070999a5a853117ef3434d33: Stale file handle
total 64
drwxr-xr-x 185 root root 81920 Mar 16 13:49 .
drwxr-xr-x   5 root root    40 Jul 31  2014 ..
??????????   ? ?    ?        ?            ? 9b0f8af8b250f69018b9ad8be2a38f431f052c26070999a5a853117ef3434d33

This then causes issues when attempting to interact with the container:
root@host:~# docker exec -it ee6b516658d0377e83c60bed21a60a399f84518b160aa57cc2fd8f0fe0a06e04 /bin/bash
2015/03/16 18:45:58 docker-exec: failed to exec: close open file descriptors open /proc/self/fd: no such file or directory
root@host:~# docker restart ee6b5
Error response from daemon: Cannot restart container ee6b5: fork/exec /var/lib/docker/init/dockerinit-1.5.0: stale NFS file handle
FATA[0010] Error: failed to restart one or more containers

Appears to stem from the following section of code:
	//If delete by id, see if the id belong only to one repository
	if repoName == "" {
		for _, repoAndTag := range repos {
			parsedRepo, parsedTag := parsers.ParseRepositoryTag(repoAndTag)
			if repoName == "" || repoName == parsedRepo {
				repoName = parsedRepo
				if parsedTag != "" {
					tags = append(tags, parsedTag)
				}
			} else if repoName != parsedRepo && !force && first {
				// the id belongs to multiple repos, like base:latest and user:test,
				// in that case return conflict
				return fmt.Errorf("Conflict, cannot delete image %s because it is tagged in multiple repositories, use -f to force", name)
			}
		}
	} else {
		tags = append(tags, tag)
	}

If I'm reading this correctly, if you are deleting by ID instead of by tag, then docker reverse looks up the image ID to get an array of all matching repos, and parses the tags out of each one of those. Those tags are then all appended to the tags array. Docker bypasses the canDeleteImage check unless the length of repos <= 1 (which isn't true, becuase this image has multiple tags).
It then goes and untags everything in the tags array (which is an array of all tags, as determined via the reverse lookup). The image is now left with 0 tags. The following check is then if len(tags) == 0 (which is now true, because all tags have been removed), so Docker deletes the image even though it bypassed the canDeleteImage method (which would have returned false).
We are working on a pull request.

@colinmorelli is this related to https://github.com/docker/docker/pull/11058?

Yes and no. We're not doing force deletions, but it's the same general area of code causing problems (as far as I can tell). Interestingly, we're seeing the inverse of what that PR suggests (we're seeing that, without a force delete, deleting an image by ID deletes all tags and the underlying image)

@colinmorelli yeah, it sounded different, but I thought the other PR would be worth mentioning before you started coding :)

@colinmorelli here is the difference:
Assume this case, repo:tag1 repo:tag2 ... with same imageID, docker rmi $imageID will untag all and delete the image because they have same repo name, the tags do not matter.
In another case, repo:tag, repo1:tag1, repo2:tag2 ..., docker rmi $imageID will just untag a random image because of the different repo names.
#11058 will untag all these repo&tags(no matter repo names are the same or different) and delete the image with docker rmi -f $imageID.
Hope I've made this clear

@x1022as that clears it up a lot. In our case, all instances have the same repo name, which explains the difference in behavior.  Important: image verification is a tech preview feature and should not be relied on to provide security.
Digest: sha256:88f8d82bc9bc20ff80992cdeeee1dd6d8799cd36797b3653c644943e90b3acdf
Status: Downloaded newer image for nginx:latest
./docker pull nginx:1.9
1.9: Pulling from nginx
39bb80489af7: Already exists
df2a0347c9d0: Already exists
dc2e1697e33e: Already exists
e21d523a1481: Already exists
5ec936b59c11: Already exists
3ec5f57e729c: Already exists
1f1cfc8b4072: Already exists
514f4db63e53: Already exists
e2fde5e7e71f: Already exists
8cac0c007422: Already exists
72d73c46937a: Already exists
a785ba7493fd: Already exists
nginx:1.9: The image you are pulling has been verified. Important: image verification is a tech preview feature and should not be relied on to provide security.

CONTAINER ID        IMAGE                        COMMAND                CREATED             STATUS              PORTS                                           NAMES
1bd71ba53113        nginx                        "nginx -g 'daemon of   6 minutes ago       Up 6 minutes        <IP_ADDRESS>:32780->80/tcp, <IP_ADDRESS>:32779->443/tcp   gloomy_stallman

docker inspect -f "{{ .Image }}" 1bd71ba53113
a785ba7493fd9009be71023045790697f334486b11a45f7e830652d39665a451

docker inspect a785ba7493fd9009be71023045790697f334486b11a45f7e830652d39665a451
Error: No such image or container: a785ba7493fd9009be71023045790697f334486b11a45f7e830652d39665a451
[]

super confused because there is a unit test for that https://github.com/docker/docker/blob/master/integration-cli/docker_cli_rmi_test.go#L105

I wonder if this is how I got into the bad situation for https://github.com/docker/docker/pull/13527

@duglin Not sure, because the "Image" field of the container is not cleared in this case. I was also able to remove the container afterwards without problems.
To verify it wasn't just something with my host, I just spun up a fresh "Debian Jessy" droplet and a "Ubuntu 14.04.2" droplet on DigitalOcean, and was able to reproduce on both.
Note that this only occurs if the image has multiple tags locally. If only nginx:latest is pulled / present, I get the right error message;
docker rmi a785ba7493fd9009be71023045790697f334486b11a45f7e830652d39665a451
Error response from daemon: Conflict, cannot delete a785ba7493fd because the running container a6049358afdd is using it, stop it and use -f to force
Error: failed to remove images: [a785ba7493fd9009be71023045790697f334486b11a45f7e830652d39665a451]

I'll added it to the 1.7 milestone

Okay, was playing a bit with this and it looks like the test doesn't reveal the problem because it also uses different names for the images, not different tags);
This is working as expected (images busybox-test:latest and utest:tag1);

CONT_ID=$(docker run -d busybox /bin/sh -c mkdir '/busybox-test')
IMG_ID=$(docker commit $CONT_ID busybox-test)
docker rm $CONT_ID

docker tag busybox-test utest:tag1

CONT_ID=$(docker run -d utest:tag1)
docker rmi $IMG_ID

Error response from daemon: Conflict, cannot delete image 8b267471440e594e81b9aab4e5efcad508cebcf572fdfbb7a029c080e85a8463 because it is tagged in multiple repositories, use -f to force
Error: failed to remove images: [8b267471440e594e81b9aab4e5efcad508cebcf572fdfbb7a029c080e85a8463]

But this isn't  (images testb:latest and testb:tag1);
Docker doesn't detect the conflict and removes the image. It also ignores the container using the image.

CONT_ID=$(docker run -d busybox /bin/sh -c mkdir '/busybox-test')
IMG_ID=$(docker commit $CONT_ID testb)
docker rm $CONT_ID

docker tag testb testb:tag1

CONT_ID=$(docker run -d testb:tag1)
docker rmi $IMG_ID

Untagged: testb:latest
Untagged: testb:tag1
Deleted: ed966d9a8095bb21794cab72d99592327df47a50e78c8125e48294ff981fa52a

cool I can take a look today, thanks for finding this :)

ok made a failing test case, I will have this fixed shortly ;)

@jfrazelle thanks! looked a bit at the code earlier, could use some simplification, but didn't spot the bug directly

that code desperitely needs to be refactored but for now im just patching, then will refactor after

Thanks for reporting the regression, @softboysxp! A new test was added and a fix added in https://github.com/docker/docker/issues/13596 to resolve this issue, which will be included in the 1.7 release.


[Crosswalk-14][usecase-cordova] Update thirdparty plugin path

https://crosswalk-project.org/jira/browse/XWALK-4246

Verified PASS in usecase cordova 3.6 and 4.0.

LGTM


Multi zone - DO NOT MERGE

Base work for the multi-DC stuff. Do not merge yet.

Can one of the admins verify this patch?


Bug : CreatedBy is shown as the last changed by

Login to dev.altinn.studio
Scroll down to see the list of resources
The overview page lists all resources and the createdby, last updated etc. the created by person is listed as the same person for all the resources. It is the last changed person but created by is confusing for the user

Fixed in altinn-studio repo


Win+Up to maximize/minimize windows

Description of the new feature / enhancement
I love using Fancy Zones, and I use the setting to override windows snap shortcuts  (Win+Arrow). I like using it as a full replacement. One feature which windows snap has is how Win+Up can maximize a window, and Win+Down minimizes. I miss these features in FancyZones. It would be nice if a setting could be added that allows for these commands to work.
Scenario when this would be used?
When I'm already using Win+Arrows to shuffle a window between Fancy Zones, I can then immediately maximize or minimize the window. I can use the same Win+Arrows for all my space management needs.
Supporting information
No response

Just to make sure, do you use the Win + Left/Right to move windows based on zone index?
It allows to maximize/minimise windows with Win + Up/Down.


Update privacy.md

Changed the Navigation settings for PS

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/3733

@JohanFreelancer9 Please copy review

@Sirkkuw Please merge this PR. Thanks


Do not rely on User agent for checking native support for HLS

Current Behavior
The library currently relies on the user agent string to check the native support for HLS. This breaks in the tools (e.g. Sizzy) which use user agent to simulate testing on mobile devices.
Expected Behavior
The native HLS support should be checked using video.canPlayType('application/vnd.apple.mpegurl') as suggested in the hls.js Readme. This will ensure that it does not break when working with tools that rely on the user agent string for simulation.

You can use config={{ forceHLS: true }} to force ReactPlayer to use hls.js. Using video.canPlayType requires loading a video into memory which I'm guessing wouldn't be great for SSR or memory efficiency.


Please Add Latest Loki Library to vcpkg

Hi @krqi  thanks for posting this request.
This is duplicated with #3443. Let's track this issue here.
Thanks.


WordPress with Timber / Twig

Hi
I would like to test whether you are on the home page but I can not find the correct syntax.
I tested this:
{% if page == 'home' %}
home
{% else %}
TEST
{% endif %}
but it still shows TEST ..
Thank's in advance
Mélusine

Hi @Melusine49, page is not a pre-defined value, to make this work, you would need some PHP...
if (is_home()) {
    $context['page'] = 'home';
}
Timber::render('mytemplate.twig, $context);

... then your sample Twig snippet would work

Hi
It doesn't work .. I have to do my test in the header (basic template) to display or not a tag (a < h 1 >).
I put in PHP:
if(is_home()){
	$context['page'] = 'home';
}
And in my basic template:
{% if page == 'accueil' %}
	home
{% else %}
	TEST
{% endif %}
Thank's in advance
Mélusine

Hi
I found the solution. We must put this in php:
$context['page'] = 'home';
and this in html:
{% if page == 'home' %}
	HOME
{% else %}
	OTHER
{% endif %}
Thanks for your help


Fixed broken hash anchors (Korean)

Fixed broken links in _toc.md and some other files.

Terrific!


Milestone 3 Feeback

Congratulations on finishing milestone 3 group 3!  Nice work uploading your package to PYPI! Nice work on the Tests on R and setting up your R repo!
Below we list some specific feedback you can use to improve your project.
We provide tick boxes for you to use in the future as you address these concerns to improve the final grade of your project.
If anything is unclear, please feel free to ask questions in this issue thread.
R package

[x] At least 1 test fails ( - -20 accuracy)

Python package
Greatjob! CICD is good, and Uploaded to PYPI
Great job, you’re at the final stretch. One milestone left :)

Hi Andy @andytai7,
I tested our group R package last week with zero errors and warnings. Also, I tried to test it again this night after seeing your feedback. Still no errors at all. Can you please show me the detailed error message? Thank you.

It looks like i pulled the Rstudio package yesterday when maybe some of the team members were playing around with the tests causing them to fail? That's my only reasonable explanation.
As you can see below, all the tests pass, when i pull from the milestone repo. This was my mistake, therefore all the grades will be rewarded back. Good luck in milestone 4!

No worries. Thank you for the explanation!


⚠ Bofrost.be has degraded performance

In fc648f9, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1332 ms

Resolved: Bofrost.be performance has improved in bd3ed77 after 6 minutes.


Crash in readNextVideoFrameFromOutput

I am expiriencing random crashes in GPUImage with error message like
"Selector name found in current argument registers: processMovieFrame:"
0   libobjc.A.dylib                      0x000000019722897c lookUpImpOrForward + 300
1   libobjc.A.dylib                      0x0000000197233db8 _objc_msgSend_uncached_impcache + 52
2   Together                             0x0000000100362174 __46-[GPUImageMovie readNextVideoFrameFromOutput:]_block_invoke + 32
3   libdispatch.dylib                    0x000000019786536c _dispatch_client_callout + 12
4   libdispatch.dylib                    0x000000019786e6e8 _dispatch_barrier_sync_f_invoke + 72
5   Together                             0x000000010035c410 runSynchronouslyOnVideoProcessingQueue + 80
6   Together                             0x00000001003620d8 -[GPUImageMovie readNextVideoFrameFromOutput:] + 416

Error hints to calling selectors on deallocated objects. In this case this seems like a real case
            __unsafe_unretained GPUImageMovie *weakSelf = self;
            runSynchronouslyOnVideoProcessingQueue(^{
                [weakSelf processMovieFrame:sampleBufferRef];
                CMSampleBufferInvalidate(sampleBufferRef);
                CFRelease(sampleBufferRef);
            });

Seems like "self" is released elsewhere, but __unsafe_unretained leaves pointer "as is", broken
Is it posible to replace __unsafe_unretained with __weak? in this case it willn`t work too (when self is released) - but it will not crash at least...

Any news on that?

same problem!

Same problem

Guys, abandon this. This library has a lot of memory leaks and is not maintained for 2 years. Write it or find something different.

are you serious? @atomicus

@AbnormalProgrammer
Yes, "Latest commit 167b038  on 26 May 2016".
I've lost a lot of time with this, and finally ended up doing it myself.


PTX-25073:  Validate volume quorum for cluster and PX upgrade

What this PR does / why we need it:
Added validation for checking that volume quorum is maintained during portworx and kubernetes upgrade.
Which issue(s) this PR fixes (optional)
Closes # PTX-25073 PTX-25027
Job Runs Results :
PX upgrade

Vanilla k8s with 10 storage nodes, 4 nodes upgraded at time
https://jenkins.pwx.dev.purestorage.com/job/Users/job/krishna/job/tp-pxe-byoc/4188/console
https://jenkins.pwx.dev.purestorage.com/job/Users/job/krishna/job/tp-pxe-byoc/4193/console

Kuberenetes Upgrade

OCP cluster with 10 storage nodes

@lsrinivas-pure updated the logs as suggested. Please review.


Improving HuggingfaceLLM: Configurable RepoID option

PR Checklist

[x] Read the Contributing documentation.
[x] Read the Code of conduct documentation.
[x] Name your Pull Request title clearly, concisely, and prefixed with the name of primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Describes source of new concepts.
[x] Passes all golangci-lint checks.

Phew, your questionnaire is quite complex, feels like I'm taking exams :)
Here's a brief description of this PR. It allows the use of HuggingFace pipelines by specifying a custom repository instead of hardcoded "google/flan-t5-xl" (which not work btw). For my tests, I used the GPT-2 model, but any other model can be used if desired.
I implemented the mentioned setting through llms.WithModel and demonstrated its usage in the corresponding example. I'm sure this will help newcomers like me to understand how to use this library more quickly.
Thank you guys for this amazing extension! I've trying to integrate executing of Python scripts to LocalAI and you saved a lot of my time.
PS. Idk how to test it correctly, al lot of existing tests don't check similar thing, so maybe you may help me with it.

"Phew, your questionnaire is quite complex, feels like I'm taking exams :)" -- you're right that this is probably too onerous -- can you open a PR to shorten this checklist to the essentials?

@EvilFreelancer After thinking a bit more -> why can't we use/re-use the WIthModel option for this?

"Phew, your questionnaire is quite complex, feels like I'm taking exams :)" -- you're right that this is probably too onerous -- can you open a PR to shorten this checklist to the essentials?

Hi! You mean just update the description or recreate PR from scratch? (close this and create another one)

@EvilFreelancer After thinking a bit more -> why can't we use/re-use the WIthModel option for this?

I've just noticed this function, didnt saw it earlier, but yeah, why not :) ill change to it then

Now it looks better, thanks for the tip!

this will probably blow up if opts.model is empty -- I can accept this but do you think we should have a default?

It's a good idea, but id model will be an empty user will see an error about this,


Constructed references have too narrow type

Say I have constructed a fresh symbol
val x: DataBag[Int] = ???

and then do api.Ref(x). The resulting u.Ident node has type
this.x.type
The problem is in Id.apply:
def apply(target: u.Symbol): u.Ident = {
  // ...
  setType(mkIdent(target), target.info match {
    case u.NullaryMethodType(res) => res
    case tpe if tpe <:< Type.anyRef && is.stable(target) =>
      singleType(u.NoPrefix, target)
    case tpe => tpe
  })
}

Isn't the second case too aggressive? If I wanted to use the singleton type I could have just set the type of the corresponding symbol. This renders the foldGroupFusion transformation unsafe due to issues in some trivial cases.

This is standard Scala semantics for singleton types and path-dependent types. The check in Transversers is not so strict, because the expected type is widened. The foldGroupFusion transformation is rightfully unsafe, because it changes the type of groups from Group[K, DataBag[V]] to Group[K, B] where B is a compound of all folds in the comprehension.

OK, this resolves the issue then.


adding delete uri template for hotel groups

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingAds/hotel-ads/release-notes.md
:white_check_mark:Succeeded

BingAds/hotel-service/manage-hotel-campaigns.md
:white_check_mark:Succeeded

BingAds/hotel-service/reference.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat(docs): add for signup verification

:tada: This PR is included in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix typo in configprovider.py

Hi @mgenereu, thanks for the PR. Unfortunately, this is a breaking change. We've discussed this in #2361 previously. We could add a short note about this for future readers, but otherwise won't be changing the variable name.

@nateprewitt Like that?

Yep, thanks @mgenereu!

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (fcad884) 93.39% compared to head (3ef9644) 93.33%.
Report is 17 commits behind head on develop.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3029      +/-   ##
===========================================
- Coverage    93.39%   93.33%   -0.06%
===========================================
  Files           66       66
  Lines        13963    13963
===========================================
- Hits         13041    13033       -8
- Misses         922      930       +8

Files
Coverage Δ

botocore/configprovider.py
94.78% <ø> (ø)

... and 5 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How to build a supercell model

How can we build a supercell model to calculate the edge states? like below:
----------
AAAAABBBBB
----------

e.g., A is a topological non-trivial photonic cell and B is trivial, and "----" means Bloch boundary conditions.
By the way, it seems that we cannot build a rectangular lattice, such as a1=[1, 0], a2=[0, 2], an error would appear:
ERROR: AssertionError: norm(b1) ≈ norm(b2)

Thanks!

Hi @kabume
There are two functions to make a solver:
solver = Solver(geometry, P) will make a solver with the k-vectors of the plane waves roughly in a circle around k=[0,0]. It assumes that b1 == b2
solver = Solver(geometry, P, Q) will make a solver with the k-vectors of the plane waves in a rhombus from k=±Pb1±Qb2
For your problem, you probably want to use the second method since b1 != b2
(See the source here: https://github.com/sp94/Peacock.jl/blob/master/src/plane_wave_basis.jl#L57)

Thanks! I'm sorry for forgetting it. Would you mind showing an example of the supercell in the documentation? It would be friendly for a wider audience.

Hi @kabume
Sorry for the long delay. Did you make any progress? I may be able to share an example if you don't have one already


Live import export

@mtaylor this is breaking compatibility. an export / import test.. exporting on older version importing on newer version is broken.. this is a no-go change! Can you fix it?

(Example; CliTestBase.. there are no changes other than the order of imports on your changes).

@clebertsuconic Export/Import of what?  Are you saying the new feature does not support import/export of messages from an old to new broker?  This is a new feature, additional support for other versions can be added.

@clebertsuconic Actually I can see that the there's a failure with 155 -> Master.  There are test failures but the job reports success.  Strange.  I know the issue will send a update soon.

@mtaylor  the previous build actually failed.. testsuite failures will break TravisCI builds .
but this one seems good now.. merging it shortly.


Add renametag feature

Will be factoring out replacePersons() and editTagInPersons() and placing them in the ModelManager class instead if it is appropriate
tagName in the Tag class is now private and can be accessed with the getTagName() method.

LGTM.


⚠ Samsung has degraded performance

In 8cf6edc, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2238 ms

Resolved: Samsung performance has improved in 81b1c54.


When ticking/unticking completed checkbox, data is not persisted

Steps to reproduce:

Create a todo
tick the Completed checkbox
Refresh the page
Checkbox unticked

Potential fixes:
NotifyChange or something, so we call Save when modifying properties
If the binding values changed, prompt on exit
If the binding valued changed, have a save button that pops up somewhere

We ended up saving automatically when ticking/unticking checkboxes. We also have a save button, just in case
didn't implement the 'prompt on exit' or 'if change, then enable save' options


[Snyk] Security upgrade mock-socket from 2.0.0 to 3.0.0

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

actioncable/package.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

551/1000  Why? Recently disclosed, Has a fix available, CVSS 5.3
Improper Input Validation SNYK-JS-URIJS-1078286
Yes
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: mock-socket
    The new version differs by 8 commits.

04ac78b Update readme
f090c09 Add back dist for ES5 node imports
2a12089 Merge pull request #78 from thoov/upgrade
f70af36 Remove dist folder and change build process
d649007 Work on UX within ember
047eba8 Fixing npm token
b93109d Merge pull request #77 from thoov/modifiedTokens
a252a56 Using secure tokens

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

b


[Android] Extract the initialization process from XWalkActivity

Some activities might want to integrate the initialization process but
can't extend XWalkActivity due to its limitations. So we extract this
part from XWalkActivity for other's reuse. This is especially for the
integration into Cordova Plugin.

@halton @axinging @fujunwei

@d0ngjun this patch fixes XWALK-4072 indirectly

@lincsoon if this PR fixes XWALK-4072, please add it in your git log.

Removed the bug fixing for XWALK-4072, but added a new method getCrosswalkRuntime for the XWalkInitializer.

@d0ngjun please review this PR, i'll reply on your lgtm.

LGTM

Maybe this PR will lead XWalkCoreShell to crash since the async initialization for xwalk core, I will verify it.


Pytorch FADNet rebuild xmodel can't execute kv260 1.4 PetaLinux dpu_task fadnet

Hi
I trying to re-build the FADNet model, so I download Vitis AI 1.4 pt_fadnet_sceneflow_576_960_359G_1.4.zip,
then compile inside the quantization folder the FADNet_0_int, FADNet_1_int, and FADNet_2_int to xmodel, but it can't run kv260 Petalinux 1.4 it showed the following error:

I compare the Vitis AI MODEL ZOO 1.4 three FADNet xmodel, occur the FADNet_0 structure problem, it re-build xmodel is different output_tensor, my xmodel output_tensor is 1, the MODEL ZOO is 3.
my xmodel:

MODEL-ZOO:

How can I increase output_tensor?
like the Vitis ai zoo xmodel structure result.
using compile.sh file ->
source compile.sh kv260 ../quantization/FADNet_0_int.xmodel FADNet_0_pt ./kv260/FADNet_0

Hi,
I found your command line need change when on board terminal.
./demo_fadnet demo_fadnet_left.jpg demo_fadnet_right.jpg
The 1.4 version demo_fadnet need to execute like this.

Hi, I found your command line need change when on board terminal. ./demo_fadnet demo_fadnet_left.jpg demo_fadnet_right.jpg The 1.4 version demo_fadnet need to execute like this.

Thanks for your advice.
I follow README:

and then I have replace FADNet_0 to MODELZOO xmodel, it can work .


METRON-1261: Apply bro security patch

Contributor Comments
This should update the version of bro that is auto-installed by full-dev/quick-dev, and update some manual instructions for setting up bro to use bro 2.4.2, which recently had a security patch applied (details here).
Additional testing instructions coming soon.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[ ] Have you included steps or a guide to how the change may be verified and tested manually?
[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

Testing

Create a working directory and pull in this PRmkdir ~/metron-1261
git clone https://github.com/apache/metron ~/metron-1261/metron
cd ~/metron-1261/metron
git remote add jonzeolla https://github.com/jonzeolla/metron
git pull jonzeolla METRON-1261

Modify this to remove sensors, (to spin up the real sensors).sed -i '' "s/ansibleSkipTags=.*/ansibleSkipTags=\'quick_dev\'/" metron-deployment/vagrant/full-dev-platform/Vagrantfile

Set up the environment in full-dev.vagrant ssh
sudo su -
export PATH=$PATH:/usr/local/bro/bin
service monit stop && service sensor-stubs stop bro && broctl stop
yum -y install jq wireshark

Configure kafka in local.bro so all of the currently supported bro logs are being sent.sed -i 's/redef Kafka::logs_to_send = .*/redef Kafka::logs_to_send = set(HTTP::LOG, DNS::LOG, Conn::LOG, DPD::LOG, DHCP::LOG, FTP::LOG, SSH::LOG, SSL::LOG, SMTP::LOG, RADIUS::LOG, Weird::LOG, Files::LOG, Notice::LOG, Software::LOG, Known::CERTS_LOG, Known::DEVICES_LOG, X509::LOG);/' /usr/local/bro/share/bro/site/local.bro
echo "redef Kafka::debug = \"all\";" >> /usr/local/bro/share/bro/site/local.bro
echo "redef Known::cert_tracking = ALL_HOSTS;" >> /usr/local/bro/share/bro/site/local.bro
echo "redef Software::asset_tracking = ALL_HOSTS;" >> /usr/local/bro/share/bro/site/local.bro
sed -i '86 a @load policy/protocols/dhcp/known-devices-and-hostnames.bro' /usr/local/bro/share/bro/site/local.bro

Monitor the bro kafka topic# Open a new terminal
cd ~/metron-508/metron/metron-deployment/vagrant/full-dev-platform
vagrant ssh
sudo su -
export PATH=$PATH:/usr/local/bro/bin:/usr/hdp/current/kafka-broker/bin
kafka-console-consumer.sh --zookeeper localhost:2181 --topic bro

Monitor the storm logs.# Open a new terminal
cd ~/metron-508/metron/metron-deployment/vagrant/full-dev-platform
vagrant ssh
sudo su -
export PATH=$PATH:/usr/local/bro/bin:/usr/hdp/current/kafka-broker/bin
# Look at the storm logs (The "failed to parse" errors for ip_src_addr and ip_dst_addr are expected, and should be addressed as a part of METRON-939)
tail -f /var/log/storm/workers-artifacts/indexing-*/*/worker.log | grep -i "org.elasticsearch.index.mapper.MapperParsingException: failed to parse"
# You may want to evaluate worker.log for other errors, but the prior command is helpful to cut through some of the failed indexing of IPv6 addresses

Run bro against some public pcaps.# In the first of your three terminals
# These are kept separate so that the flat file log output won't stomp the prior ones, for ingest validation
mkdir -p ~/brotmp/nitroba ~/brotmp/example-traffic ~/brotmp/ssh ~/brotmp/ftp ~/brotmp/radius
wget https://www.bro.org/static/traces/exercise-traffic.pcap -O ~/brotmp/example-traffic/exercise-traffic.pcap
wget http://downloads.digitalcorpora.org/corpora/network-packet-dumps/2008-nitroba/nitroba.pcap -O ~/brotmp/nitroba/nitroba.pcap
wget https://www.bro.org/static/traces/ssh.pcap -O ~/brotmp/ssh/ssh.pcap
wget https://github.com/markofu/pcaps/blob/master/PracticalPacketAnalysis/ppa-capture-files/ftp.pcap?raw=true -O ~/brotmp/ftp/ftp.pcap
wget https://github.com/EmpowerSecurityAcademy/wireshark/blob/master/radius_localhost.pcapng?raw=true -O ~/brotmp/radius/radius_localhost.pcapng
cd ~/brotmp/example-traffic
bro -r exercise-traffic.pcap /usr/local/bro/share/bro/site/local.bro -C
cd ~/brotmp/nitroba
bro -r nitroba.pcap /usr/local/bro/share/bro/site/local.bro -C
cd ~/brotmp/ssh
bro -r ssh.pcap /usr/local/bro/share/bro/site/local.bro -C
cd ~/brotmp/ftp
bro -r ftp.pcap /usr/local/bro/share/bro/site/local.bro -C
cd ~/brotmp/radius
editcap -F libpcap radius_localhost.pcapng radius_localhost.pcap
bro -r radius_localhost.pcap /usr/local/bro/share/bro/site/local.bro -C

Validate that terminals 2 and 3 don't have any errors that you don't expect.
Verify proper indexing in ES and availability in kibana.# Check around and make sure things look okay
declare -a exists notexists; for protocol in http dns conn dpd dhcp ftp ssh ssl smtp radius weird files notice software known_certs x509 known_devices; do if [[ $(curl -s -XGET "node1:9200/bro*/_search?q=protocol:${protocol}" | jq '.hits.hits') == '[]' ]]; then notexists+=" ${protocol}"; else exists+=" ${protocol}"; fi; done; if [ ${#notexists[@]} -ne 0 ]; then echo -e "\n\n\033[0mThe following do exist in ES: ${exists[@]}\n\033[0;31mThe following do NOT exist in ES: ${notexists[@]}\033[0m"; else echo 'All of the log types are in ES!  Success!'; fi; unset exists notexists
# Check Kibana.  For example:  http://node1:5000/app/kibana#/visualize/create?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:now-15y,mode:quick,to:now))&_a=(filters:!(),linked:!f,query:(query_string:(analyze_wildcard:!t,query:'*')),uiState:(),vis:(aggs:!((id:'3',params:(field:protocol,orderBy:'2',size:20),schema:segment,type:terms),(id:'2',schema:metric,type:count)),type:histogram))&indexPattern=bro*&type=histogram
# OPTIONAL testing
# Run `/usr/share/elasticsearch/bin/plugin install mobz/elasticsearch-head` and look around
curl -XGET node1:9200/_cat/indices # First column should be all green
curl -XGET "node1:9200/bro*/_count" # Check the count of entries in the bro index, you can re-run bro against specific PCAPs and watch this increase, etc.

As usual, I really love your test scripts.  Well done, @JonZeolla !

Maybe we should have the checkout-pr script in the metron repo?

It's actually easier than this to pull in a PR, for future reference
git fetch upstream pull/805/head:METRON-1261
git checkout METRON-1261

Assuming upstream is GitHub, of course.  It'll just make a branch in your local and you can check it out there.

Right @justinleet I've done that in the past as well, this is me just being lazy and not wanting to look up the PR # when drafting my instructions =)
That said, those instructions don't depend on my repo, which means it's probably the right way to do it.

https://github.com/nickwallen/metron-commit-stuff/blob/master/checkout-pr

Okay, I just spun up full-dev and followed my testing instructions - all looks good to me.  This is ready for a review.

@JonZeolla.  Followed the steps, and in my monitor storm logs 'window' i have many of the following:
[root@node1 ~]# tail -f /var/log/storm/workers-artifacts/indexing-*/*/worker.log | grep -i "org.elasticsearch.index.mapper.MapperParsingException: failed to parse"
org.elasticsearch.index.mapper.MapperParsingException: failed to parse [ip_dst_addr]
org.elasticsearch.index.mapper.MapperParsingException: failed to parse [ip_dst_addr]
org.elasticsearch.index.mapper.MapperParsingException: failed to parse [ip_dst_addr]

I don't know if I should expect these or not?

never mind, I just re-read the instructions before sorry

+1
Followed instructions and everything worked as expected.
Great work @JonZeolla!


Readme should say you need a local docker

As the instructions don't work on docker-machine unless you are on the vm

cc #57

Close via #56.


[ADD] Want to add a Stone-Paper-Scissor game

Stone-Paper-Scissor game card and it leads to a simple user vs computer stone paper scissor with logics of win lose and draw,
using html css and mostly js.
it will be having 3 icons representing different hand gesture for rock paper and scissors for user/player to click and play it,
and computer will randomly generate any such of three. On the two responses the score would be decided
please assign me this task under JWOC24

okay! assigned, please complete it in 2-3 days

sure


[Storage] Switch from ClientSecretCredential to DefaultAzureCredential v2

This PR is currently WIP. Will fill this out when it's in a shareable state, currently have this just to run CI.

API change check
API changes are not detected in this pull request.

/azp run python - storage - tests

/azp run python - storage - tests

/azp run python - storage - tests

/azp run python - storage - tests

/azp run python - storage - tests

/azp run python - storage - tests

/azp run python - storage - tests

/azp run python - storage - tests

/azp run python - storage - tests

/azp run python - storage - tests

/azp run python - storage - tests

/azp run python - storage - tests


Error in Dark Mode

The dark mode only does the entire screen dark, without changing text color to white and canvas is also not visible in this case.
below is the image attached of the issue.
@vishanurag kindly assign this issue to me with labels like gssoc and hacktoberfest

Similar issue is already assigned to someone else


new drug target

add cutin-1 to fas1 target from comemnt in curs/1bc92c0f892db627

already done when Jacky submitted the session


Parameter renaming in remove_small_labels

Hi @StRigaud ,
I just noticed a name change, where I'm not sure if it was intentional:
In the prototype exclude_small_labels has a parameter "maximum_size".
In CLIC, remove_small_labels has a parameter "minimum_size".
Is this intentional? It appear unintuitive to me. I would like to remove small labels up to a given maximum size...

Hey @haesleinhuepf
Yes, it is intentionnal:

https://scikit-image.org/docs/stable/api/skimage.morphology.html#skimage.morphology.remove_small_objects

It appear unintuitive to me

It's the reverse to me. I am focused on what I want, object bigger than a certain size, not what I want to remove. Though I dont think there is a correct answer here

Ok. Fine. It has the older name in the exclude_... function and thus, is backwards-compatible. We should point this out in a deprecation message, once we add it. Hence, I leave this issue open so that we can cover this in the documentation.

Yup,
I will put back warning of deprecation when we will start to move to beta


Explore supporting ES import() proposal

Dynamic import proposal is in early stages but it will require TypeScript to support it in order to be usable in TypeScript based apps.
Basic syntax:
import('./my-module.ts').then(({export1, export2}) => {

});

This is a proposal that we are following in the committee. I would expect us to start looking into this early next year.
also referenced in https://github.com/Microsoft/TypeScript/issues/11611. i think we just need one issue to track this.

Stubbing it such that it is not a syntax error, has type (string) => Promise<any>, and is emitted as-is could be useful for using it with e.g. https://github.com/airbnb/babel-plugin-dynamic-import-webpack or eventually with https://github.com/webpack/webpack/issues/3098 in webpack 2; but I don't know how good an idea that is.

@Kovensky anyone can easily write that stub should they need it so I don't think its declaration belongs in the language any more than require, define, or System.import.

@aluanhaddad not quite. Just writing a ( after import causes a syntax error, regardless of anything you try to do declaration-wise. This needs compiler support.

@Kovensky I don't think I have actually tried to write it like that, thanks for explaining that this isn't possible.

Dynamic import() support landed in webpack master and should be in the next webpack 2 beta.

It was also promoted to stage-3 as of the last TC39 meeting

That means SystemJS may update their API to match it! :D

SystemJS can't update their API to match proposal because import() is a SyntaxError. TypeScript should definitely do it.

has apparent type (request: string) => Promise<any>

it's (specifier: any) => Promise<any>, according to latest spec ToString will be applied to specifier

Can we have a compiler option to support this syntax?

Sadly we'll loose type information when specifier should be computed :(

There are talks about attaching meta-properties to import, similarly to what was done with new for new.target. It might be better represented (for forward compatibility) as an interface with that call signature, but this might be thinking too far ahead.

airbnb/babel-plugin-dynamic-import-webpack#12 see concerns

@mhegazy is this going to be in the TS "Future" (2.3?) roadmap?

I have a solution if anyone wants a hack to use while waiting for the feature to be properly implemented in TS.
You'll need string-replace-loader or something similar setup as the last loader in your ts config. (The search and replace should probably be a regex just to make sure we don't accidentally clobber something but this was enough to test that the idea works)
module: {
    rules: [
        {
            test: /\.tsx?$/,
            use: [
                {
                    loader: 'string-replace-loader',
                    options: {
                        search: '_import(',
                        replace: 'import('
                    }
                },
                {
                    loader: 'babel-loader'
                },
                {
                    loader: 'ts-loader',
                    options: {
                        silent: true,
                        compilerOptions: {
                            noEmit: false,
                        },
                    },
                },
            ],
        },
    ]
}

Then simply create a definition like so...
declare function _import<T>(path: string): Promise<T>;

You can change the _import to really be anything but I felt the _ was pretty safe and would be easy enough to find and replace when typescript adds support.
My test was a simple react-router v4 app with two routes that were added with _import. An example of it in use is below
render() {
    return (
        <Match pattern="/" exactly render={props =>
            <LazyRoute module={() => _import('./Home')}>
                {module => module ? <module.default {...props} /> : null}
            </LazyRoute>
        } />
    );
}

It's hard to use such hack without native support if we want types. We should do things like:
import * as ModuleInit from './init';

async function main(): Promise<void>
{
	const Init: typeof ModuleInit = await _import( './init' );

	Init.default();
}

I'll note that the proposal is currently at stage 3, and only string literals should be checked (anything else should return {[key: string]: any}).
Also, it'd be nice to see it transpiled in CommonJS/AMD (Webpack 2 works with ES module syntax):
// Original
import("specifier").then(...)

// CommonJS
Promise.resolve()
.then(() => require("specifier"))
.then(...)

// AMD
Promise.resolve()
.then(() => new Promise(resolve => require(["specifier"], resolve)))
.then(...)

In particular, lazy loading in Node would be very nice for end-user apps with optional features, and import() provides a very nice way of doing that.

Promise will resolve to module namespace not any.
import * as path from 'path';
console.log(path.resolve('foo'));

and
import('path').then(path => {
  console.log(path.resolve('foo'));
});

I'm assuming TypeScript will not allow dynamic module specifier (import(moduleName + '.ts')) as spec is suggesting.

@mohsen1 I referred to {[key: string]: any} as the fallback type, not any.

@originalmoose How did you implemented <LazyRoute module={...}>. I have a hard time to create custom routes and add new properties without changing internal behaviour (e.g. here https://github.com/ReactTraining/react-router/issues/4595).
If someone is interested in a custom component instead of a custom route which imports other components written in TS2.2, here is a gist.

@donaldpipowitch Here is a gist with my lazy route not sure if it does what you need. This is for react-router v4

@mohsen1,

I'm assuming TypeScript will not allow dynamic module specifier (import(moduleName + '.ts')) as spec is suggesting.

Not allow meaning treat the result as any, or no support at all?

It looks like the result will be typed as Promise<any>. Maybe in the future improvements in the way of https://github.com/Microsoft/TypeScript/issues/13231 could help better type the return type; but you'd probably still need to do it with asserts.

Is there any plan to support import() now ?

I'm also interested in this for code splitting. This doesn't work at the moment because of import() call:
import Loadable from 'react-loadable';

function MyLoadingComponent() {
  return
Loading...
;
}

const LoadableAnotherComponent = Loadable({
  loader: () => import('./another-component'),
  LoadingComponent: MyLoadingComponent
});

class MyComponent extends React.Component {
  render() {
    return <LoadableAnotherComponent/>;
  }
}

For now, you can work around it by having
declare global {
  interface System {
    import (request: string): Promise<any>
  }
  var System: System
}

and using System.import. You will, unfortunately, not get type checking, though, but there are ways to get something good enough for now working.

@Kovensky that worked great. Thank you.
A few gotchas - webpack 2 needs a chunkFilename to load the chunk script correctly:
  output: {
    filename: '[name].js',
    path: PATHS.build,
    publicPath: '/',
    chunkFilename: '[id].chunk.js'
  },

Also used the babel-plugin-syntax-dynamic-import in .babelrc
If you are getting webpackJsonp errors make sure that the scripts are in the correct order in .html (vendor, app then chunks)

Also for react-loadable it only works with default exports #20

@Kovensky cheers for the workaround! I've used it combined with react-loadable here if anyone is interested in a demo: https://github.com/jch254/starter-pack/tree/typescript.

@Kovensky while this post is largely around react, I am attempting your interface approach via Angular 2 and still getting the import property is undefined?  Any thoughts:
main.ts:20 Uncaught TypeError: Cannot read property 'import' of undefined
    at getTranslations (main.ts:20)
    at Object.<anonymous> (main.ts:12)
    at __webpack_require__ (bootstrap 8581ef0…:52)
    at Object.<anonymous> (module.js:22)
    at __webpack_require__ (bootstrap 8581ef0…:52)
    at webpackJsonpCallback (bootstrap 8581ef0…:23)
    at app.8581ef0….js:1

Generated code looks as follows I am wondering if the interface is not being ignored in this case causing the actual import() function to go un-recognized.
var system_interface_1 = __webpack_require__(508);
core_1.enableProdMode();
// platformBrowserDynamic().bootstrapModule(AppModule);
getTranslations();
function getTranslations() {
    var locale = document['locale'] ? document['locale'] : 'en';
    switch (locale) {
        case 'en':
            system_interface_1.System.import('../locale/messages.en.xlf!text').then(function (someModule) {
                platform_browser_1.platformBrowser().bootstrapModuleFactory(app_module_ngfactory_1.AppModuleNgFactory);
            });
            break;
    }
}

/***/ }),
/* 508 */
/***/ (function(module, exports, __webpack_require__) {

"use strict";
// TODO: Remove when TS supports dynamic imports: https://github.com/Microsoft/TypeScript/issues/12364

Object.defineProperty(exports, "__esModule", { value: true });
// tslint:enable
//# sourceMappingURL=system.interface.js.map

/***/ }),

I am still having this issue - using<EMAIL_ADDRESS>

@misantronic You might need to change your tsconfig's "module" option to "esnext"


MacOS GUI hangs at "loading..."

This issue seems to come up a lot, but it's still biting me.  The command line works just fine and the various processes are started with open /Applications/Keybase.app.
I'm  43bfedd8fb76e5e40c8a66c007de3b18 and running 1.0.47-20180508010858+c06519b740.  Everything else is fine and the GUI works on my Linux machine.
What do you need from me?

Can you run keybase log send?

On 8 May 2018, at 20:04, Maxwell Krohn<EMAIL_ADDRESS>wrote:
Can you run keybase log send?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Done.

Success! Your log ID is:
a2670100d19d31a065d57d1c
Here's a URL to submit new bug reports containing this ID:
https://github.com/keybase/client/issues/new?body=[write something useful and descriptive here]

my log id: a2670100d19d31a065d57d1c
Thanks!
Thanks,
Jch

@strib this is KBFS failing to load I think....

On 8 May 2018, at 20:16, Maxwell Krohn<EMAIL_ADDRESS>wrote:
@strib this is KBFS failing to load I think....
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

That's what I thought, but if I run "keybase install" the file systems get mounted but the app still hangs after I've done that.
jch

Logs: a2670100d19d31a065d57d1c
In your logs, KBFS fails to load with this error:
Mounting the filesystem failed: cannot locate kbfuse; either install the Keybase app, or install OSXFUSE 3.x and pass in --use-system-fuse

It seems like something might have uninstalled the kernel extension somehow?  Not sure how that could happen by accident.  If so, then keybase install might have re-installed it.
@jchax have you tried restarting the Keybase app since you fixed KBFS?  It might not be able to fix itself.

On 8 May 2018, at 21:42, Jeremy Stribling<EMAIL_ADDRESS>wrote:
Logs: a2670100d19d31a065d57d1c
In your logs, KBFS fails to load with this error:
Mounting the filesystem failed: cannot locate kbfuse; either install the Keybase app, or install OSXFUSE 3.x and pass in --use-system-fuse
It seems like something might have uninstalled the kernel extension somehow? Not sure how that could happen by accident. If so, then keybase install might have re-installed it.
@jchax have you tried restarting the Keybase app since you fixed KBFS? It might not be able to fix itself.

Yep.   I tried that: it still hangs.
jch

Can you please do another keybase log send now that you've done that?

On 8 May 2018, at 21:47, Jeremy Stribling<EMAIL_ADDRESS>wrote:
Can you please do another keybase log send now that you've done that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Done.

Success! Your log ID is:
3006293564efe8c09395a21c
Here's a URL to submit new bug reports containing this ID:
https://github.com/keybase/client/issues/new?body=[write something useful and descriptive here]

my log id:<PHONE_NUMBER>efe8c09395a21c
Thanks!

@maxtaco @chrisnojima KBFS looks fine now, but the GUI is still stuck.  Not sure where else to look.

a few of my co-workers who just recently moved to keybase are having this exact issue

@supratec can you ask them to send logs via keybase log send? Thank you


Mica/acrylic effect often don't load until next restart. (Windows 11 22H2)

Microsoft PowerToys version
0.77.0
Installation method
GitHub
Running as admin
No
Area(s) with issue?
PowerToys Run
Steps to reproduce
Just open PowerToys run after boot up, often it won't load the mica/acrylic effect. It rarely loads though. Even the next restart doesn't guarantee that it will load.
✔ Expected Behavior
The mica/acrylic effect loaded properly all the time.

❌ Actual Behavior
Often the mica/acrylic effect didn't load after boot up. It fallbacks to the default opaque gray/white. If it loaded after boot up, even just turning on battery saver and turning it off could make the mica/acrylic don't load.

Other Software
Processor	Intel(R) Core(TM) i3-1005G1 CPU @ 1.20GHz   1.19 GHz
Installed RAM	8,00 GB (7,77 GB usable)
System type	64-bit operating system, x64-based processor
Pen and touch	No touch and pen support
Edition	Windows 11 Home
Version	22H2
Installed on	10/01/2024
OS build	22621.675
Experience	Windows Feature Experience Pack 1000.22634.1000.0

try restarting the entire powertoys process, it should appear normal but only for some time.


please update for the new nkeys package

Hello!
I am trying to get gnatsd in Debian but it cannot build due to the fact that the head of this repository does not build with the latest nkeys.
Could that be fixed?
Thanks!

I have fixed in my trust branch which should be merged this week. However nkeys should be vendored so should always build ok.

Surely you would not take master when building for a distro anyway

If all of the latest tagged version build together then yes this is what we would do.
I am not done yet so I haven't tested that.

Would prefer for you to package the binary release for linux from Releases and not build on your own.

I am afraid I cannot do that, Debian is built from source and does not include binaries.

If it built from source then Go will honor the vendored dependencies as it should, correct?

No, we never honor vendored dependencies in any circumstances

That's pretty foolish IMO when the development language supports and encourages it and the developer ecosystem depend on it for building properly.

Every language supports it. While Go has built tools around it, other languages supports it with copy and paste.
We just can't have multiple vendored copies of every library, we don't have the manpower to support it.

Understood about multiple copies of dependencies. That being said, if the packaging system can not produce a binary as built from a tagged release with the correct dependencies, we the NATS maintainers would be challenged to properly support it. I am sure there is an answer somewhere, let us know if we can help.

This can be done if you don't release any version of nkeys that you don't want the world to use.
If you release any version of nkeys, people will start using it and depend on it, forcing us to update to it.
Just make sure you don't release nkeys before gnatsd can build with it.
This can be done by having non-release-ready development on a development branch where it wouldn't be reached by a typical user's go-get.

Nkeys is released but had changes. The nats-server vendors projects (even ones that we maintain) as a good practice for one project not breaking another. Nkeys tests pass and all utilities built with it are updated. The server is a larger beast. It has been updated to the newest version in the "trust" branch. But again, you have to build a release package with the exact same version we build with as tagged on github. That means the exact version of nkeys that is vendored.

Someone pointed this out, not sure if it is helpful.
https://go-team.pages.debian.net/packaging.html

Yeah, I do maintain about 150 Go packages in Debian so I am part of the team that writes these guidelines.

ok once gnatsd trust branch lands will resolve, but still would only build from tagged releases. I will tag a release for nkeys though..

I have applied the trust branch as a patch already and used the head of nkeys, I am now moving on with the streaming server, which is ultimately what I really need.

It looks like the streaming server requires an older version of raft than the one we have in Debian?
I haven't analysed the log yet...
# github.com/nats-io/nats-streaming-server/server
src/github.com/nats-io/nats-streaming-server/server/clustering.go:276:28: cannot use s.log (type *"github.com/nats-io/nats-streaming-server/logger".StanLogger) as type "github.com/nats-io/nats-streaming-server/logger".Logger in argument to newRaftLog:
	*"github.com/nats-io/nats-streaming-server/logger".StanLogger does not implement "github.com/nats-io/nats-streaming-server/logger".Logger (missing Warnf method)
src/github.com/nats-io/nats-streaming-server/server/monitor.go:207:10: cannot use limits.OpenFiles (type int64) as type int in assignment
src/github.com/nats-io/nats-streaming-server/server/server.go:872:7: cannot use ss.stan.log (type *"github.com/nats-io/nats-streaming-server/logger".StanLogger) as type "github.com/nats-io/nats-streaming-server/logger".Logger in assignment:
	*"github.com/nats-io/nats-streaming-server/logger".StanLogger does not implement "github.com/nats-io/nats-streaming-server/logger".Logger (missing Warnf method)
src/github.com/nats-io/nats-streaming-server/server/server.go:1451:37: cannot use s.log (type *"github.com/nats-io/nats-streaming-server/logger".StanLogger) as type "github.com/nats-io/nats-streaming-server/logger".Logger in argument to stores.NewFileStore:
	*"github.com/nats-io/nats-streaming-server/logger".StanLogger does not implement "github.com/nats-io/nats-streaming-server/logger".Logger (missing Warnf method)
src/github.com/nats-io/nats-streaming-server/server/server.go:1454:36: cannot use s.log (type *"github.com/nats-io/nats-streaming-server/logger".StanLogger) as type "github.com/nats-io/nats-streaming-server/logger".Logger in argument to stores.NewSQLStore:
	*"github.com/nats-io/nats-streaming-server/logger".StanLogger does not implement "github.com/nats-io/nats-streaming-server/logger".Logger (missing Warnf method)
src/github.com/nats-io/nats-streaming-server/server/server.go:1457:39: cannot use s.log (type *"github.com/nats-io/nats-streaming-server/logger".StanLogger) as type "github.com/nats-io/nats-streaming-server/logger".Logger in argument to stores.NewMemoryStore:
	*"github.com/nats-io/nats-streaming-server/logger".StanLogger does not implement "github.com/nats-io/nats-streaming-server/logger".Logger (missing Warnf method)
src/github.com/nats-io/nats-streaming-server/server/server.go:4425:18: cannot use s.log (type *"github.com/nats-io/nats-streaming-server/logger".StanLogger) as type "github.com/nats-io/nats-streaming-server/logger".Logger in argument to traceSubState:
	*"github.com/nats-io/nats-streaming-server/logger".StanLogger does not implement "github.com/nats-io/nats-streaming-server/logger".Logger (missing Warnf method)
dh_auto_build: cd obj-x86_64-linux-gnu && go install -gcflags=all=\"-trimpath=/home/aviau/git/debian-pkg/build-area/golang-github-nats-io-nats-streaming-server-0.11.2\+git20181112.636da8d/obj-x86_64-linux-gnu/src\" -asmflags=all=\"-trimpath=/home/aviau/git/debian-pkg/build-area/golang-github-nats-io-nats-streaming-server-0.11.2\+git20181112.636da8d/obj-x86_64-linux-gnu/src\" -v -p 4 github.com/nats-io/nats-streaming-server github.com/nats-io/nats-streaming-server/logger github.com/nats-io/nats-streaming-server/server github.com/nats-io/nats-streaming-server/spb github.com/nats-io/nats-streaming-server/stores github.com/nats-io/nats-streaming-server/test github.com/nats-io/nats-streaming-server/util returned exit code 2

You may have similar problems then because NATS Streaming vendors a bunch of repos (including gnatsd)


Ability to load projects from URLs is broken in dev

Sigh:
ERROR - run - No such file or directory:
https://github.com/ManiacalLabs/BiblioPixelAnimations/blob/master/Projects/matrix.json

Works in master.
It has no doubt something to do with the switch to YAML.  I will investigate.
I sort of wish we hadn't done that.  It has consumed a lot of time...

I would assume this is more a loady thing isn't it?? Anything you figured
out on this?
On Sun, Jun 10, 2018 at 6:11 AM Tom Swirly<EMAIL_ADDRESS>wrote:

Sigh:
ERROR - run - No such file or directory: https://github.com/ManiacalLabs/BiblioPixelAnimations/blob/master/Projects/matrix.json
Works in master.
It has no doubt something to do with the switch to YAML. I will
investigate.
I sort of wish we hadn't done that. It has consumed a lot of time...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/852, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AA6a6q-IDYFZPZ5r0tkeoiYdTjSn52BXks5t7PDZgaJpZM4UhqEi
.

No, it's entirely us.
I broke it when I did the YAML switch - I basically bypass loady.
I already changed loady to prefer a Yaml parser if one is installed, so I
can go back to using loady, but I haven't got it entirely working - it's in
client though.
We need to add a URL project to our list of tests!!  I'll do that before
marking this closed.
On Sat, Jun 16, 2018 at 5:05 PM, Adam Haile<EMAIL_ADDRESS>wrote:

I would assume this is more a loady thing isn't it?? Anything you figured
out on this?
On Sun, Jun 10, 2018 at 6:11 AM Tom Swirly<EMAIL_ADDRESS>wrote:

Sigh:
ERROR - run - No such file or directory: https://github.com/
ManiacalLabs/BiblioPixelAnimations/blob/master/Projects/matrix.json
Works in master.
It has no doubt something to do with the switch to YAML. I will
investigate.
I sort of wish we hadn't done that. It has consumed a lot of time...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/852, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AA6a6q-
IDYFZPZ5r0tkeoiYdTjSn52BXks5t7PDZgaJpZM4UhqEi>
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/852#issuecomment-397818334,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPdsuYHN44rCSx0FTq9h7Idv9887gPrks5t9R7JgaJpZM4UhqEi
.

--
/t
https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com


App not working after the upgrade to iOS 14.3

It's not working with the initially delivered server configs nor with newly added.
The DNS setting was activated as requested.

@zero0ID Thank you for reporting. I've confirmed that the problem is reproduced. I'll investigate it.
As a workaround for a while, please try the following steps.

Open the DNSecure app
Select a server from the sidebar
Enable "Use This Server"
Open the Settings app
Go to "VPN & Network" settings
Select "DNSecure" for "DNS" settings
Force quit the DNSecure app without opening it
Re-open the DNSecure app

@zero0ID Thank you for reporting. I've confirmed that the problem is reproduced. I'll investigate it.
As a workaround for a while, please try the following steps.

Open the DNSecure app
Select a server from the sidebar
Enable "Use This Server"
Open the Settings app
Go to "VPN & Network" settings
Select "DNSecure" for "DNS" settings
Force quit the DNSecure app without opening it
Re-open the DNSecure app

Hi kkk669,
seems that the emergency solution works. Strange are the DoT test results for this server (https://blog.uncensoreddns.org/blog/) on https://rootcanary.org/test.html
Usually there I get unlocked only for the GOST line and ECC GOST column.

Hi kkk669,
seems that the emergency solution works. Strange are the DoT test results for this server (https://blog.uncensoreddns.org/blog/) on https://rootcanary.org/test.html
Usually there I get unlocked only for the GOST line and ECC GOST column.

Thank you @zero0ID.

Strange are the DoT test results for this server

The result seems to change every time I re-run test, so I'm not sure whether the test is unstable or Apple's DoT implementation is unstable.

Thank you @zero0ID.

Strange are the DoT test results for this server

The result seems to change every time I re-run test, so I'm not sure whether the test is unstable or Apple's DoT implementation is unstable.

Maybe you have an address where to check the DoT and DoH configuration please?

Maybe you have an address where to check the DoT and DoH configuration please?

@zero0ID I usually verify a DNS-over-TLS/HTTPS connection by capturing packets with Wireshark or Charles.
Also, you can use another DNS leak test described in the LibreOps blog.

@zero0ID I usually verify a DNS-over-TLS/HTTPS connection by capturing packets with Wireshark or Charles.
Also, you can use another DNS leak test described in the LibreOps blog.

Closed by #30

Closed by #30


what is the relationship between the trustee of Dapp and the trustee of the main chain?

Dapp and main chain are two chains. At present, the consensus algorithm built into dapp template is upos, so the trustee of main chain and dapp are independent of each other and do not affect each other.


Meta settings icon

As already mentioned in the UX call I do not like the new settings icon inside settings.
I feel like this should be elipses instead and this would align better with other places in vscode where we use elipses and this settings wrench.
fyi @roblourens

So the reasoning we decided to go with the gear was that the ellipsis icon isn't well suited for a notification badge (it would be dot dot dot and a notification dot). We also use the gear in other places like the debug viewlet, extensions, files/filter exclude. Here's a comparison of the two:

Curious to hear your thoughts between the two. Personally, I'm fine using either but thought the gear icon played better with the notifcation.

Yes the gear icon plays better with the dot.
4 dots do not make much sense.
I guess it is fine in the end.
My concernt was that we are overloading the gear icon with too manu dfferent meaning in different places which do not always mean "configure". Let's close for now, and see if anybody else has conernse


Method to filter based on per-language attributes?

This plugin supports filtering/sort by syntax:
[glossarist, /path/to/glossarist-dataset, filter='group=foo;sort_by=term', dataset]
----
...
----

So I have a Glossarist dataset I want to sort by term ID. However, with the latest Glossarist gem the IDs are no longer a top-level attribute.
From my experimentation yesterday this is the full structure:
{
  "localized_concepts" => {
    "eng" => "01134f51-b88c-5214-8909-5d271ea619cf",
    "fre" => "f290a3af-f1b3-527a-9045-a2dfcc0caf5a"
  },
  "term" => "concept description",
  "eng" => {
    "dates" => [],
    "definition" => [
      {
        "content" => "data structure describing the class of all known instances of a concept"
      }
    ],
    "examples" => [],
    "id" => "2122978",
    "notes" => [
      {
        "content" => "concept description: term and definition standardized by ISO/IEC [ISO/IEC 2382-31:1997]."
      },
      {
        "content" => "31.02.02 (2382)"
      }
    ],
    "sources" => [
      {
        "origin" => {
          "ref" => "ISO/IEC 2382-31:1997"
        },
        "type" => "lineage",
        "status" => "identical"
      },
      {
        "origin" => {
          "ref" => "Ranger, Natalie * 2006 * Bureau de la traduction / Translation Bureau * Services linguistiques / Linguistic Services * Bur. dir. Centre de traduction et de terminologie / Dir's Office Translation and Terminology Centre * Div. Citoyenneté et Protection civile / Citizen. & Emergency preparedness Div. * Normalisation terminologique / Terminology Standardization"
        },
        "type" => "lineage",
        "status" => "identical"
      }
    ],
    "terms" => [
      {
        "type" => "expression",
        "normative_status" => "preferred",
        "designation" => "concept description",
        "grammar_info" => [
          {
            "preposition" => false,
            "participle" => false,
            "adj" => false,
            "verb" => false,
            "adverb" => false,
            "noun" => false,
            "gender" => [],
            "number" => ["singular"]
          }
        ]
      }
    ],
    "language_code" => "eng"
  },
  "fre" => {
    "dates" => [],
    "definition" => [
      {
        "content" => "structure de données qui décrit la classe des instances connues d'un concept"
      }
    ],
    "examples" => [],
    "id" => "2122978",
    "notes" => [
      {
        "content" => "description de concept : terme et définition normalisés par l'ISO/CEI [ISO/IEC 2382-31:1997]."
      },
      {
        "content" => "31.02.02 (2382)"
      }
    ],
    "sources" => [
      {
        "origin" => {
          "ref" => "ISO/IEC 2382-31:1997"
        },
        "type" => "lineage",
        "status" => "identical"
      },
      {
        "origin" => {
          "ref" => "Ranger, Natalie * 2006 * Bureau de la traduction / Translation Bureau * Services linguistiques / Linguistic Services * Bur. dir. Centre de traduction et de terminologie / Dir's Office Translation and Terminology Centre * Div. Citoyenneté et Protection civile / Citizen. & Emergency preparedness Div. * Normalisation terminologique / Terminology Standardization"
        },
        "type" => "lineage",
        "status" => "identical"
      }
    ],
    "terms" => [
      {
        "type" => "expression",
        "normative_status" => "preferred",
        "designation" => "description de concept",
        "grammar_info" => [
          {
            "preposition" => false,
            "participle" => false,
            "adj" => false,
            "verb" => false,
            "adverb" => false,
            "noun" => false,
            "gender" => ["f"],
            "number" => ["singular"]
          }
        ]
      }
    ],
    "language_code" => "fre"
  }
}

So I have this text to render it:
== Terms and definitions

[glossarist,./../concepts,filter='sort_by=id',concepts]
----
{% for concept in concepts %}
{% render "concept", concept: concept, target_lang: "eng" %}
{% endfor %}
----

However, the id is no longer a top level data, it is only accessible under {lang}.id. What can I do?

The document with this code is accessible here:

https://github.com/metanorma/iso-iec-2382/pull/30

@HassanAkbar actually, not only this, I've added the ID attribute to the concept, but the sorting still doesn't work. Please check https://github.com/metanorma/iso-iec-2382/pull/30 . This is important. Thanks.


What's the minimum supported rustc version?

In UNIC, we've been maintain support for Rust 1.22.0, but the build recently started to fail because a build error from skeptic (https://travis-ci.org/open-i18n/rust-unic/jobs/417777108):
error[E0599]: no method named `to_ascii_lowercase` found for type `&str` in the current scope
   --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/skeptic-0.13.3/lib.rs:315:7
    |
315 |     s.to_ascii_lowercase()
    |       ^^^^^^^^^^^^^^^^^^
    |
    = help: items from traits can only be used if the trait is in scope
    = note: the following trait is implemented but not in scope, perhaps add a `use` for it:
            candidate #1: `use std::ascii::AsciiExt;`
    = help: did you mean `to_lowercase`?

I see the lowest version in travis.yml here is stable. Would be great to add some explicit version there and keep track of minimum version supported, so external libraries can depend on.
What do you think?

Hi @behnam! This line sure is problematic, it either errors on older rust or its alternative (proposed by tue compiler in your log) gives a verbose warning on newer ones.
Indeed I'd be interested in both:

making the skeptic accessble for wider range of rust versions (ideally without warnings)
providing clear info of minimal rust version  checked by CI

Unfortunately I'm more than tied reacently so can't say when I'd have time to touch the subject :(
On the other hand I'd hapilly accept PR's anytime!

Coo, @budziq! Submitted a PR (GH-86) to add explicit minimum-rust-version to the CI.


Problem: docker CI caching doesn't (always) seems to get the caches

I've seen it sometimes get the Postgres build cache for amd64, but never for arm64. And it's not consistent.
Does it have something to do with manifests/buildkit? Doesn't seem like it's updated consistently.

Looks like 3a6c4c427e53caa0ac8ff038ac36389bd5a41f5c solves this


package.json missing dependency: prop-types

Prerequisites
Please answer the following questions for yourself before submitting an issue.

[ 1.5.0] I am running the latest version
[ Y] I checked the documentation and found no answer
[Y ] I checked to make sure that this issue has not already been filed
[ Y] I'm reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior
Dashboard.jsx (and other files) has:
import PropTypes from "prop-types";
yet module is not in package.json, Its absence creates 45 warnings in JetBrains WebStorm

Hello again @ascooper57 ,
Thank you for showing this issue.
We are going to address this issue on our next update.
Best,
Manu


Go Back & Go Forward

Type: Bug
I am unable to go back and forward using mouse buttons 4 and 5 on macos.
VS Code version: Code 1.85.1 (Universal) (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:48:06.308Z)
OS version: Darwin arm64 23.2.0
Modes:
Remote OS version: Linux x64 4.18.0-513.9.1.el8_9.x86_64

We rely on standard DOM APIs for mouse buttons 3 and 4 to be reported:
https://github.com/microsoft/vscode/blob/17e0dec8cf3a60d75e5517093752af6f8e8e1978/src/vs/workbench/services/history/browser/historyService.ts#L140-L154
I suspect an issue with your mouse setup.
Does it work on https://insiders.vscode.dev/ ?


python311Packages.google-cloud-texttospeech: 2.15.0 -> 2.15.1

Changelog: https://github.com/googleapis/google-cloud-python/blob/google-cloud-texttospeech-v2.15.1/packages/google-cloud-texttospeech/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 281114 run on x86_64-linux 1

2 packages built:

python311Packages.google-cloud-texttospeech
python311Packages.google-cloud-texttospeech.dist


pick requirements.txt even if both Pipfile present

I wrote a big nasty error message that told users to either specify
Pipfile or requirements.txt if both were present. Unfortunately that
breaks a ton of existing Fleece usage so this change warns if both file
types are present.

Thanks for the quick fix

Actually, can you bump the version as well?

@Gifflen Totally. Should I do it as part of this PR?

Yes, thanks.

Done, merging after Circle passes


chore(deps): bump dependencies

:tada: This PR is included in version 1.0.0-next.16 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix links in guidelines

It used relative links before migration. Now they need to be updated.

@ahmetb Updated to link directly to the kubernetes.io website. PTAL.

/lgtm

/approve

@sebgoa lgty?


Repo manager check for variantsets misleading

In a previous fix the "Inconsistent metadata" between VCFs was ignored, however, this is still part of repo check. We should either make these checks meaningful or remove them entirely.

Could you elaborate?  What do you consider a meaningful check?

I posted an issue that the server wasn't starting after adding 1kg variant set (https://github.com/ga4gh/server/issues/946). It seems to run fine when I've added it, but repo check claims there is something wrong. What feature are we supporting by having repo check fail?

Another way to put it is... Is the ga4gh_repo check failure a false negative? The API seems to function without error (perhaps due to the fix in #946) so we are wondering if the same fix needs got be applied to the logic of the check function (or some similar logic). The alternative is that the error message from the check function is a real problem that needs to be fixed.
I am pasting the error output here for reference.
(ga4gh-server-env)azureuser@kobo-vm:/srv/ga4gh$ ga4gh_repo check /srv/ga4gh/ga4gh-example-data
Warning: The index file is older than the data file: /srv/ga4gh/ga4gh-example-data/datasets/1kg-p3-subset/variants/vcf/ALL.chrY.phase3_integrated_v2a.20130502.genotypes.vcf.gz.tbi
Warning: The index file is older than the data file: /srv/ga4gh/ga4gh-example-data/datasets/1kg-p3-subset/variants/vcf/ALL.chrY.phase3_integrated_v2a.20130502.genotypes.vcf.gz.tbi
Warning: The index file is older than the data file: /srv/ga4gh/ga4gh-example-data/datasets/1kg-p3-subset/reads/HG00096.mapped.ILLUMINA.bwa.GBR.low_coverage.20120522.bam.bai
Warning: The index file is older than the data file: /srv/ga4gh/ga4gh-example-data/datasets/1kg-p3-subset/variants/vcf/ALL.chrY.phase3_integrated_v2a.20130502.genotypes.vcf.gz.tbi
Warning: The index file is older than the data file: /srv/ga4gh/ga4gh-example-data/datasets/1kg-p3-subset/variants/vcf/ALL.chrY.phase3_integrated_v2a.20130502.genotypes.vcf.gz.tbi
Traceback (most recent call last):
  File "/srv/ga4gh/ga4gh-server-env/bin/ga4gh_repo", line 9, in <module>
    load_entry_point('ga4gh==0.2.0a2.dev170+ngcce89bc', 'console_scripts', 'ga4gh_repo')()
  File "/srv/ga4gh/ga4gh-server-env/local/lib/python2.7/site-packages/ga4gh-0.2.0a2.dev170+ngcce89bc-py2.7.egg/ga4gh/cli.py", line 1672, in repo_main
    runner.run()
  File "/srv/ga4gh/ga4gh-server-env/local/lib/python2.7/site-packages/ga4gh-0.2.0a2.dev170+ngcce89bc-py2.7.egg/ga4gh/cli.py", line 1385, in run
    self.repoManager.check(self.doConsistencyCheck)
  File "/srv/ga4gh/ga4gh-server-env/local/lib/python2.7/site-packages/ga4gh-0.2.0a2.dev170+ngcce89bc-py2.7.egg/ga4gh/repo_manager.py", line 293, in check
    dataRepo.checkConsistency()
  File "/srv/ga4gh/ga4gh-server-env/local/lib/python2.7/site-packages/ga4gh-0.2.0a2.dev170+ngcce89bc-py2.7.egg/ga4gh/datarepo.py", line 214, in checkConsistency
    variantSet.checkConsistency()
  File "/srv/ga4gh/ga4gh-server-env/local/lib/python2.7/site-packages/ga4gh-0.2.0a2.dev170+ngcce89bc-py2.7.egg/ga4gh/datamodel/variants.py", line 580, in checkConsistency
    self._checkMetadata(varFile)
  File "/srv/ga4gh/ga4gh-server-env/local/lib/python2.7/site-packages/ga4gh-0.2.0a2.dev170+ngcce89bc-py2.7.egg/ga4gh/datamodel/variants.py", line 556, in _checkMetadata
    variantFile.filename)
ga4gh.exceptions.InconsistentMetaDataException: Metadata of /srv/ga4gh/ga4gh-example-data/datasets/1kg-p3-subset/variants/vcf/ALL.chrY.phase3_integrated_v2a.20130502.genotypes.vcf.gz is not consistent with other files in this VariantSet, and inconsistent metadata is not permitted

Yeah so the check function (among other things) runs the checkConsistency methods which run any number of tests to determine if the data that you want to add is "consistent."  We should definitely evaluate if the checks are in there are still necessary, and if we should add ones that are not there... @jeromekelleher ?

I think the checkConsistency method is intended to make sure that the VCFs we're putting into a VariantSet really are all from the same VariantSet by checking the headers. We should definitely do this at add time in repo manager. If the VCFs really are from the same VariantSet and we're getting an error then there is a problem with the checking logic and we should file a specific bug against that functionality.

The original bug post was about the inconsistent metadata check was failing for the 1kg dataset. https://github.com/ga4gh/server/issues/946
I'm happy to close this and reopen as another issue, as @jeromekelleher states we need to know whether the inconsistent metadata check is meaningful (or not).

Closed by #1166.


Error with Azure OpenAI virtual key setup

I'm trying to add AzureOpenAI Virtual key. Getting "Error: Something wrong. Please try again"
I'm entering the API key, Azure deployment name, Resource name (Endpoint URL), and Azure API version.
Thank you,
Ravi.

@nlpravi confirming that this should work. Would it be possible to share the code snippet you are using to make the call?

This is happening during the creation of virtual key in the dashboard. I'm not using any code here.

Hey @nlpravi - This usually happens due to incorrect azure details of incorrect format of azure details. As you mentioned in your message that you are entering resource url which is incorrect. You just need to add resource name and not the whole url. Example: If abc is my resource name under which I created a deployment named turbo-16k and I want to use 2023-09-01-preview version
Resource name: abc
Deployment name: turbo-16k
API Version: 2023-09-01-preview
Can you please use this format for details and let us know if you still face this error

Thank you Visarg. It works now.

Great..!! We will add some detailed steps for this in our docs to avoid confusion in future. Closing this issue. Feel free to open a new one in case you have other questions.


Page Stuck on "Processing" After Logout from Moqui-Based Apps

Expected behavior
After logging out from the Moqui-based application, the user should be redirected to the login page or receive a confirmation message indicating a successful logout, without the page being stuck on "Processing."
Steps to reproduce the issue
Log out from the Launchpad.
Log in to any Moqui-based application.
Go to settings page and log out from the Moqui-based application.
Observe that the page remains stuck on "Processing."
Additional information
https://jam.dev/c/5b7765bf-bfcc-4db6-aa41-6d9fbeb8f343

Verified and working fine on launchpad production. Hence, closing this ticket.


Hover docs: match Rust behavior w.r.t implementation / interface docs

Closing as this appears to be working already


MM-10500 - Implementing Relay chat UI updates

Summary
MM-10500 - Implementing Relay chat UI updates
Ticket Link
https://mattermost.atlassian.net/browse/MM-10500
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Ran make check-style to check for style errors (required for all pull requests)
[ ] Ran make test to ensure unit and component tests passed
[ ] Added or updated unit tests (required for all new features)
[ ] Has server changes (please link)
[ ] Has redux changes (please link)
[x] Has UI changes
[ ] Includes text changes and localization file (.../i18n/en.json) updates
[ ] Touches critical sections of the codebase (auth, posting, etc.)

Have a look @esethna.
Did all the changes in the ticket except the font on the user generated image. That has to be done on the server, so probably better for a dev to look at that. (that also has to be done as a separate PR to the server repo).

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0ba77f216f2abcbf2.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-0ba77f216f2abcbf2

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-02f0944122f41648c.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-02f0944122f41648c

Thanks Asaad, a few comments:

Not sure we want to take the decreased size of team icons. I actually think they look better on pre-release - or maybe we just decreased the size a bit too much. Seems like a lot of empty space. I'll leave it up to your judgement.

"+" icon in the create team box seems too heavily weighted.

^ If you can address these points (if you agree). Then we should probably post the link to this server in the spec reviews channel plus a list of the changes that we made, mentioning that we just took some pieces from the original RelayChat PR.

I like the breathing room now compared to pre-release. Relay had the team icon sized to 32px by 32px, I made them 36 by 36 in the instance.
I agree, relay chat had that heavy one, I'd like to go with a thinner one. Mike was leaning with a heavy one.
I think we should. And probably on other places as well. LHS header, team selection menu, etc.

I'll wait for @michaelgamble feedback on this before I move forward.

Hey @asaadmahmood would it be possible for us to whip together a few designs in sketch.. its hard to make these calls without the ability to easily / quickly compare.
My feedback is somewhat inline with @eric:

would like to compare the size change, maybe something in-between current and what you have implemented in this PR
I agree the plus icon looks a bit big / imbalanced with the team names - they should feel balanced
Im not crazy about both letters being lowercase - Maybe first only, or both uppercase?
How much bigger are the emoji / attach icons? wondering if maybe something in-between is needed (hard to gauge without seeing it)

Things that look good to go:

I like the removal of the team descriptions
The post control hover menu look good

Lets do a quick zoom on Tuesday and sort out the tweaks (might be the quickest way)

Sounds cool.

Removed the test server. doing some cleanup.
Thanks for this PR :)

Spinmint test server destroyed

Spinmint test server created at: http://i-085d01a4220b83bc9.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-085d01a4220b83bc9

@asaadmahmood One concern with removing the team name entirely is that you won't be able to distinguish between "Marketing" and "Mattermost" teams. But maybe we assume people use team icons instead. Do we have any stats on how many people use the team icon?

Changes look good to me. I'm okay with removing the name on team buttons since we have team icons now, but @esethna I think we should run it by IT as well since that was originally his design decision.
0/5 on this and maybe we should do it separately, but @asaadmahmood do you think we should also update our other dropdown/pop up menus to have more rounded corners to be more consistent? For example in this screenshot the post menu and then the ... menu look like they're different styles.

@lfbrock I think I can do that in this PR. I'll also update the designs.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

@jasonblais Pretty sure that focus thing is not due to my PR. Regarding the team icons, yes. Now that we have team icons, we have a way to differentiate between teams. Plus since the team icons feature is new, not sure how accurately would it represent the usage of Team icons, but maybe @esethna has stats on that.

Spinmint test server created at: http://i-0d4201057c6782ba6.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-0d4201057c6782ba6

@lfbrock Spinmint is up with the rounded corners.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0238344a507fa7851.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-0238344a507fa7851

Spinmint test server created at: http://i-08ed69dbeeb5a9991.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-08ed69dbeeb5a9991

Spinmint test server destroyed

@asaadmahmood This needs a rebase before it can be merged

@hmhealey Done, also a package.json file got committed. See if I need to take that out.

I don't think this PR should be changing package-lock.json. It looks like you're reverting it to an older version of the file. If you have the latest version of master checked out, you can do git checkout master -- package-lock.json to get that file from the master branch

Done @hmhealey

Looks good now


Feature/minimal variant price sorting

This PR:

adds minimal_variant_price to the Product model,

a field that stores the minimal price among all the variants of the product,

updates the minimal_variant_price on:

product's creation/update,
product variant's creation/update/removal,
sale's creation/update.

Did you notice that pytest is printing 100 time:

.tox/py36-django22/lib/python3.6/site-packages/django/db/models/fields/init.py:1363

I believe it's a warning, but I don't see any message. Could you take a look?

Here is the report for f2d0ec20e7a682e7d0288f9bc430ef3319f51601 (mirumee/saleor @ feature/minimal_variant_price_sorting)
Base comparison is ee9b5ac51231de5f6c78beb0c39756a4e08645c3.
No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         43	         43	             21

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2

@derenio please rebase this PR to master

@derenio please fix CI

@derenio Please rebase this branch with master as we've merged a large PR yesterday. Then I'll be able to re-review it.

@maarcingebala just rebased the PR.

How do we handle published vs. unpublished collections in terms of minimal prices? E.g., if there is a sale for a particular collection, but the collection isn't published yet. Can we even create a sale for unpublished collections? I'm not sure how it works now but I'm writing that down for us not to forget to check it.

Publish/unpublish and calculating of minimal price are for me two separate things.
We should be able to publish/unpublish every variant we want and calculate the minimal price if there is any price to calculate.

@koradon I think it is related, but the problem is more general.  The collection is not published.
I'm creating a sale and associating it with the above collection.
Now - is the discount active, if the collection is not published yet? Currently, it seems that it is which I consider a bug. But in general - both discounts and collections can be activated/published at some point in the future, and minimal variant price should become valid from that point of time (or should be recalculated at that point).

Maybe the simplest solution is to have a periodic task that recalculates all prices based on what is currently published in the store.

@maarcingebala yes, we ware talking about designing periodic task for recalculating prices. That was the main save behavior that will fix any mistakes in our logic.
According to your example:
We should calculate min_price every time when Sale or Collection changes state.

@maarcingebala I've rebased (twice x|) onto the latest master to resolve conflicts on the Pipfile.lock and the migration files.


Using wrong device id will return integer 0 instead of string from serial_number and device_name attributes

If you run this code
import asyncio
from flexit_bacnet import FlexitBACnet

async def main():
    device = FlexitBACnet('<IP_ADDRESS>', 3) # device id = 3
    await device.update()

    print('Device Name:', device.device_name) # will return 0
    print('Serial Number:', device.serial_number) # will return 0

if __name__ == "__main__":
    asyncio.run(main())

According to function type hints these should only return str. How this should be fixed? I could also take a stab at this if needed.

@Kazhuu would returning an empty string on that occasion solve it?

I think that will but is this even supposed to be a valid connection with wrong device id? I'm not that familiar with BACnet protocol to know this. If so, could this already be checked earlier when the connection is made for the first time and some error thrown or something similar? If it's supposed to be valid connection, then this is also fine. Maybe this should be mentioned in the README as well?

I guess this solution also solves the issue @piotrbulinski. With this change I only need to compare to the empty string instead of integer.

@Kazhuu I think that's the best for now. I've released version 2.1.1 with that fix.

Thanks!


Support vhosts in rabbitmq

Fixes #30255.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @alexmv!

Since this is mostly useful setting up new systems, I think there's no point in backporting now that 9.0 is out.


Origins mod doesn't detect the client's origins mod on minehut

When joining a fabric server with origins v1.6.2 on it, it will say I have to install the origins mod to play, even though my mods folder is exactly the same as the server.

Can you provide more information about your server? e.g: the Origins and Minecraft version, whether you're using a proxy or not, the log file of the server, etc.

#261


<EMAIL_ADDRESS>

https://github.com/bnb-chain/bsc/issues/1427

Please submit the correct information, invalid information will cause the issue to close


feat(builtin): support vscode snippet variable CURRENT_TIMEZONE_OFFSET

CURRENT_TIMEZONE_OFFSET was added since April 2023 (version 1.78) in vscode.
Also Snippets in Visual Studio Code the doc here mentions:

CURRENT_TIMEZONE_OFFSET The current UTC time zone offset as +HH:MM or -HH:MM (example -07:00).

This PR is to support the variable in LuaSnip.

Hey, thanks for the contribution!
Could you exchange os.data("%z") with the more portable version described here? Seems like windows doesn't support "%z" :/

I think it'd be best to put that function into a new file, util/time.lua. But util/util.lua would also be fine

Hi @L3MON4D3
Thanks for your review, I tried to update the code based on your feedback, could you please take a look again?

Ah yes!
Looks perfect, thand you very much!