QUESTION: complete a term with a colon / :

This project makes me almost completely happy. I want to write a completion for rspec, which is mostly painless. After being finished with my (opinionated) completion, I wanted to also complete the tags, which are tag:value-pairs. I generate the list with a small helper that returns a list that roughly looks like this:
js:false
js:true
sphinx:true
type:controller
type:feature
~js:false
~js:true
~sphinx:true
~type:controller
~type:feature

(naturally, there's more, but this shows the problem well enough)
The tag sphinx:true is easy, since it has the : inside the word. It gets completed in one <TAB>. The negated tags with the ~-prefix are also unproblematic.
For the others, the difference comes after the :. So it is printed but does not allow further completion. I can go back, escape the :, add another character and complete from there.
Let's just say that the ergonomics differ slightly between
rsp<TAB>--tag sph<TAB><ENTER> and
rsp<TAB>--tag ty<TAB><BACKSPACE>\:c<TAB><ENTER>
And yes, the last <TAB> completes type\:c to type:controller, removing my escape-hack and leaving me with the intended command. However, trying to complete type:c trigger the generic fallback of file-completion for c.
I realize that I do not have a completion-issue, but a shell-escape-issue (as so often when doing things in bash). Do you know of a solution for this? I have the feeling that the _completions_filter-function might be a place for a fix. How this potential fix is the propagated into the config-yaml is as unknown as the fix itself.
This is all I know now. Can you help or provide pointers for a PR I can create?

Can you provide a minimal, most basic YAML file that shows the issue?

Sure. The above example can be reproduced by this:
rspec:
- --tag

rspec*--tag:
- sphinx:true
- type:controller
- type:model

My real setup fetches the possible tags from a script, but the problem shows both with hard-coded values and with the dynamic ones from the script.

With the default behavior of bash completions - I am unable to make it work. It indeed gets stuck after the colon.
I do not know how to solve this.
However, I am not using the default behavior of the bash completion, and it works beautifully as expected:

To achieve this behavior, you need to have a ~/.inputrc file with this line in it:
TAB: menu-complete

This is my full ~/.inputrc` in case it helps:
# Change up/down arrows behavior
"\e[A": history-search-backward
"\e[B": history-search-forward

# Change tab behavior and add shift tab for old behavior
TAB: menu-complete
"\e[Z": complete

That helps and works. Somehow, I do not like that behaviour, but since I am now in "personal preference"-land, my question is obviously answered.
Maybe I'll dive into bash-completion to search a solution that does work with complete as well while waiting for a spec or so. If I find something, I let you know.
For now, I am completely happy :-) Thanks for your help and completely.

but since I am now in "personal preference"-land

Actually, since I am using the non-default behavior, I agree that this is still an interesting issue as to why it does not work as expected in the default mode. Colons are treated differently for some reason.

$COMP_WORDBREAK

This is it.
By removing colon from this variable, your use case works as expected:

_rspec_completions() {
  local cur=${COMP_WORDS[COMP_CWORD]}
  local compwords=("${COMP_WORDS[@]:1:$COMP_CWORD-1}")
  local compline="${compwords[*]}"

  # Add this
  COMP_WORDBREAKS=${COMP_WORDBREAKS//:/}

  case "$compline" in
    *'--tag')
      while read -r; do COMPREPLY+=( "$REPLY" ); done < <( compgen -W "$(_rspec_completions_filter "sphinx:true type:controller type:model")" -- "$cur" )
      ;;

I do not want to add it to all of completely's output - but if there is a way to provide an elegant way to use a different template, or inject custom code to the generated script - I am happy to consider it.

I see three options:

add a dedicated setting to the YAML for configuring this
This conflicts with the current assumptions the YAML suggests. Currently, everything in the YAML going into the completion-script as is. In order to not go against the implied assumptions, a key like _completely_options might work (with maybe in this case a hash named remove_from_wordbreak having a list of characters to remove). This might be handy in this case, but it could open the config for other extensions that are not intended. The beauty of the current state is that it is very easy to understand, which is a very welcome contrast to creating a completion-script manually.

The other two options are more automatic. The generator could check, if the completions contain a character from  $COMP_WORDBREAK and

remove it
This might be removing too much if there is a typo and then breaking the completion for reasons that are hard to understand.

provide a helpful warning how to fix this manually in the generated script
This is the least invasive change I can think of which still somewhat resolves this.

Of course, the obvious fourth and fifth options are

add the result of 3 to the README
ignore this

but both are somewhat unsatisfying.
Which of these options would you like to see in completely (and maybe accept as a PR)?

Well - thanks for outlining the options, but I am not crazy about any of them.
Keep in mind that there is also the consideration of bashly that uses this library, and I want it to continue operating properly, without the need to add a "completely options" section to the bashly configuration.
The option that seems simplest is 2 - just remove one or more characters from the COMP_WORDBREAKS variable for everyone, without any configuration.
The default character list is this: " \t\n\"'><=;|&(:"
In our context - where we know that each word specified in the YAML is a completion word - I wonder if it would do any harm in removing these:

: colon  - which exists here since it is a path separator
; semicolon - which exists here since it is a command separator
= equal sign - which exists here since it is used in var=value

Thoughts?

Being "crazy" about any of them would be a wild overstatement. Each one of them has some aspects that I do not like. Option 2 is the one that treats this question as a bug that should be fixed in completelys generated completion-script.
Given the locality of the variable AND the reset to its previous value, tweaking it seems fine to me. Removing the = and : make sense to me.
I do have a bad feeling about removing the ; as this would - to my understanding - terminate the command if left unquoted. Therefore, it seems like an unusual choice for a character being included in a string that can be foreseen and hence completed. Or am I missing something here?

about removing the ;

I don't think keeping it will cause issues, but in general I agree.
I will remove it from.... ahm... the removal.

I am closing this, as I do not see a way around it.
If new information comes to light we can reopen.

On Fri, Jul 05, 2024 at 11:47:42PM -0700, Danny Ben Shitrit wrote:

I am closing this, as I do not see a way around it.
If new information comes to light we can reopen.

Fair enough. I think there might be a way, but I expect it to be
a little more work. As I clearly do not have the time/energy for this
right now, closing it seems like the appropriate move.


Z-index of parts' groups

Currently, all parts are drawn from bottom to top, where each new part is drawn on-top of every other part. This causes some problems where, for instance, an arm should appear both under a shirt's arm, but in front of a shirts torso.
The solution to this was to draw "empty space" in the shirt where the the arm should be visible through. This is fairly limiting sometimes, but most of all undesirable.

In order to combat this, one solution is to separate the shirt arms from the shirt torso and putting them at different z-levels. For instance, in this image the shirt arms are separated from the shirt torso in the SVG. Each part is also separated internally even further, which would allow for an human arm to be "sandwiched" between the arm parts, while still being separated from the torso completely. The only relation the arm has to the torso is that it is drawn in front of the torso.
The relation between different parts need to be addressed somewhere, and I believe that the rulebook.json is the best place for this.

As of right now there are two major issues:

The syntax for specifying different z-levels for parts. Ideally, it should be possible to relate to another part, eg. "${body left arm} - 1", which would put it one level below the z-index of the left body arm (regardless what z-index it has).
Separating the SVG into multiple parts, which would be re-arranged according to the z-index. Any SVG is handled as a text string, meaning no proper handling of the SVG happens.

An example demonstrating how the new layered version of the shirt is built up, and how body parts would relate to it.

Although differently layered parts of pieces are not currently usable, all new items will be split into multiple parts in me-generator-images.

I am thinking that a for a SVG, the top-level elements will be addressable and rearrangeable.
For instance, take this image which consists of a total of 3 elements in the following structure:
svg
├─ rect
│  └─ circle
└─ rect

I suggest a solution where only the rects will be able to have their Z-index modified, and the only other permutation would be:

I am thinking that a for a SVG, the top-level elements will be addressable and rearrangeable.
For instance, take this image which consists of a total of 3 elements in the following structure:
svg
├─ rect
│  └─ circle
└─ rect

I suggest a solution where only the rects will be able to have their Z-index modified, and the only other permutation would be:

For the example with the shirt, the structure would become:
svg
├─ "left arm (frontside)"
├─ "left arm (backside)"
├─ "right arm (frontside)"
├─ "right arm (backside)"
├─ "torso (frontside)"
├─ "torso (backside)"

To further expand on my previous comment.
All addressable elements would be in a flat list. I believe combining multiple SVG's elements into one long list will make rearranging them much easier than any other approach I have managed to come up with.
svg-1
├─ rect
└─ circle

svg-2
└─ g

  ↓

svg-combined
├─ rect
├─ circle
└─ g

Because of a flat list, the following should be easy to write rules for, as well as implementing in code. One permutation of the above could be:
svg-combined-modified
├─ rect
├─ g
└─ circle

(this is representative of putting an arm between two layers of clothing, where the arm and clothing are in different SVG files)

I am not entirely sure how the elements should be addressed yet.

I believe the proper way to handle ordering elements would be a list of instructions, similar to how rules function (when disallowing). The idea is pretty simple. Iterate all "index rules", and if that rule references a part which is present, move it.
Moving a part must be directly in front or behind another part. This is to remove complexity.
Although not fully fledged syntax for referencing a part's element, I believe a good start for the syntax would be <part>#<element id>. Possibly, if the entire part is to be moved, the trailing #<element id> would not be necessary.
To "sandwich" an arm between two layers of clothing, the rules would be structured as:
["left arm", "in front of", "ltt crewneck#left backside"]

Reads as: place the part with id left arm above the element left backside, which belongs to part ltt crewneck.

To give a simplified example of what happens.
ltt crewneck
├─ right frontside
├─ right backside
├─ … (additional parts parts hidden in this example)

right arm
└─ arm

The combined SVG would then look like
combined-svg
├─ right frontside   // id: ltt crewneck#right frontside
├─ right backside    // id: ltt crewneck#right backside
├─ …
└─ arm               // id: right arm#arm

The "index rules" would be in the rulebook.json.
// rulebook.json
{
  "index": [
    ["foo#abc", "behind", "bar#abc"],
    ["right arm", "in front of", "ltt crewneck#right backside"],
    // …
  ],
  // …
}

After parsing these rules, the following happens

In the index rules the part foo is not present, so it is ignored.
The part right arm exists, and ltt crewneck exists. Therefore all elements of right arm are placed in order before the right backside element of ltt crewneck.

Because right arm only contains one element, it makes no difference. Should there be more elements in the parts, all elements would be moved.

The final result would become
output
├─ right frontside   // id: ltt crewneck#right frontside
├─ arm               // id: right arm#arm
├─ right backside    // id: ltt crewneck#right backside
└─ …

I just realized that the "index rules" actually allows for rearranging individual elements in the same part.
If this syntax for selecting elements is implemented for "allow/disallow rules", I could theoretically generate an entire image from a single SVG…?

As of 77b492d61b4bf14f7844ac7e8903312c412d9a36, a working version of rearranging elements of parts is possible.
I am going to celebrate this with an emoji.


BitForex is missing

I`m missing the exchange "Bitforex.com"
https://github.com/githubdev2020/API_Doc_en/wiki/API-Call-Description

Feel free to open a PR

Feel free to open a PR


Support Database Identifier To Allow Connection to AWS RDS over Local Port Forwarding

Is your feature request related to a problem? Please describe.
For security reasons we restrict access to the RDS database via a bastion host in AWS. Meaning we port forward via the bastion box to reach the AWS RDS Instance. This is currently not compatible with IAM authentication in DBeaver as the host is localhost rather than that of the database identifier which is used when generating the IAM authentication credentials.
Describe the solution you'd like
A "database identification" field adding to the AWS IAM connection panel that allows the host to be different to that of the value used to generate the IAM authentication credentials. Allowing to connect to a localhost and port but still use IAM authentication when connecting to the AWS database. An example of where this has been implemented is in Datagrip: https://github.com/aws/aws-toolkit-jetbrains/issues/1238
Describe alternatives you've considered
I have tried adding a local hosts entry for the database however because the port doesnt match that in AWS i get a PAM authentication error.
Additional context
https://github.com/aws/aws-toolkit-jetbrains/issues/1238

Thank you for the feature request!


kakoune-unwrapped: 2022.10.31 -> 2023.08.05

Description of changes
This updates the package to the latest release.
Version 2023.07.29 contains feature additions and breaking changes to the default key bindings. Version 2023.08.05 contains a bug fix.
Changes: https://github.com/mawww/kakoune/compare/v2022.10.31...v2023.08.05
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2502

@rapenne-s @vrthra ping?

I currently can't try the build, I can't do the review before a few days.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1066


Add color types

I'm hijacking this PR to say sorry if I'm a bit slow to answer the review requests, I'm being busy with my exams, I'm still 100% interested in making this happen.

No worries! I've got plenty of other stuff on my plate as well, so you're not holding me up :smile:.


[Feature] Force obfuscate string list

Opposite feature to reservedStrings - if string matches regex or string - it will be obfuscated even if by random it shouldn't.
Useful for hiding some important keys or tokens.

Also in string array present many strings with equal length. Likely there are keys for objects in helper objects for controlFlowFlattening.

My idea is to mask force-obfuscated-string by splitting it and masking between many short strings.

splitStrings option already exist

splitStrings option already exist

Okay, here i agree with you.
I meant to add this feature to force-obfuscate-string, but now i understand that this is bad idea to mix them

forceTranformStrings option WILL have a priority over reservedStrings option. But right now it's a hard task to make a priority over conditional comments, because of the way how it works.

PR was merged

Will release it later today.

Released as 2.4.0


Renewing idToken fails

For renewing the idToken i noticed some bugs in msal.js
in function UserAgentApplication.prototype.renewIdToken there is a reference to "adalIdTokenFrame". This should be "msalIdTokenFrame". Otherwise navigation won't even happen.
Also in acquireTokenSiltent the response type is token and not id_token. So the navigation url that is being constructed is not valid.

@rohitnarula7176
That's awesome. Works perfectly.

Closing this issue. Fixed in dev


Broken UX Design Kit link removed

@nhsbsa-dean Can we just hold off merging this for now? Just think it might be worth checking with Ben whether he wants to replace it with another URL. He might be happy just to remove it completely - but worth double checking.

@nhsbsa-dean Ben has confirmed it can just be removed - thanks for holding off! 🚀


This repo does not contain a license file

Which is needed to be able to redistribute

Done )

Thanks!


Additional requirements on SDP files of JPEG XS Senders

Resolving #18 based on activity group input.
Not sure whether we need to also explicitly add some of the transport-related parameters to the list of "REQUIRED depending" ones, like transmode from RFC 9134 (needed if T is 0), b=AS: (used by ST 2110-22, but we require the Sender attribute bit_rate always) and TP (st2110_21_sender_type), etc.

Not sure whether we need to also explicitly add some of the transport-related parameters to the list of "REQUIRED depending" ones, like transmode from RFC 9134 (needed if T is 0), b=AS: (used by ST 2110-22, but we require the Sender attribute bit_rate always) and TP (st2110_21_sender_type), etc.

These are required by the underlying specs so we can just rely on that.


Wrong service name declaration in configuration file

I invite you again to take a look at what seems to be a critical bug. #146

This repository has been closed and moved to laminas-api-tools/api-tools-hal; a new issue has been opened at https://github.com/laminas-api-tools/api-tools-hal/issues/8.


Properly log progress messages

Log progress messages, converting timestamps to strings. This puts more allocation behind each of these messages (from an empty vector to a vector of strings) but there doesn't seem to be much to do about it if we want to see the actual progress contents moving around.
The receive side has the potentially to be much spammier than the send side, as this is a broadcast. Depending on the volume we may want to dial that down and just presume that sent messages are not lost in transit (we would lose the timing information about when they are received though). For the moment, we log lots of things.
cc: @utaal @saradecova

This doesn't address the same issues as #321, but we should double check whether it relieves any pressure there. There should be only some gap between the receive stream and the inputs to the progress tracker.

Thinking out loud, although these logging events are informative, they aren't exactly sufficient to track the frontier of the system (which would be a desirable goal). For example, operators are often created with an initial capability, which their logic then drops and workers confirm by sending progress messages around. So we see the drops, but not the initial capabilities.
It would be nice to directly log the dataflow frontier in the progress tracker, which is a bit more in line with #321 (though, not something that #321 produces as output). Afaict, #321 produces the raw pointstamp updates in progress tracking, which is possibly more immediately helpful than the progress messages for determining the state of capabilities in the system.

Closing in favor of #352, which is just a cleaned up version of this PR.

Closing in favor of #352, which is just a cleaned up version of this PR.


Dynamic icons based on file-icons

Hello @victorhqc
Just a little something I felt it was missing since I didn't really love the default icon set.
Assuming that the user have installed this pretty famous package now the icons will look like:

Github
Gitlab
Otherwise

And they will change according to the module homepage url.
In case file-icons is not installed or disabled the current look will remain untouched.

Updated with your implementation 👍

That's awesome, thank you!
If it's not too bothersome, there is one last feature I would like you see and evaluate.. So one more PR incoming ;)


Fix #1182 ASM Unsupported api 524288 after the upgrade to Gizmo 1.0.3

FIx #1182

The changed test is in the networking category that passed.


C# if (null == this.MyEvent) throws exception in ss.staticEquals

for an if comparison of a delegate where null is the first value - e.g. if (null == this.MyEvent) { }
the output JavaScript is if (ss.staticEquals(null, this.$1$MyEvent))
and throws an exception because null is the first parameter to staticEquals.
In CoreLib\Delegate.cs, I found:
[InlineCode("{$System.Script}.staticEquals({a}, {b})")]
public static bool operator==(Delegate a, Delegate b) {
return false;
}
And staticEquals throws an exception if (a) is null:
ss.staticEquals = function ss$staticEquals(a, b) {
if (!ss.isValue(a))
throw new ss_NullReferenceException('Object is null');
...
};
It seems that instead, when a is null, staticEquals could test that b is also null.
E.g.
// if either parameter is null, then both must be null
if (!ss.IsValue(a)  || !ss.IsValue(b))
return ss.IsNullOrUndefined(a) && ss.IsNullOrUndefined(b);
...

Not sure what version, or branch, of Saltarelle you're using but ss.staticEquals in the master branch doesn't look like that - https://github.com/erik-kallen/SaltarelleCompiler/blob/master/Runtime/CoreLib.Script/mscorlib.js#L171 (and a blame indicates it never did, though it might have been moved around).  It might just be that you need to update to a more recent version where this issue has been fixed or possibly just reinstall the nuget.

Thanks and sorry for the bother, it's a problem on our end.


Fix toxins

About the PR

Title. Fixed Molecular acid, Sulfuric metabolism, and uh fluorine, I messed up porting fluorine for some reason
Why / Balance

Parity. Molecular acid in CM has 0.05 metabolism (game only updates every 2 ticks so it looks like 0.01 instead of 0.02 like other chems at a glance). Fixed the spitter and boiler amounts to be correct to match this, making spitter stabs less deadly and boilers about how as deadly as they still are, sort of. Also burn and toxin was backwards.
Sulfuric Acid metabolism is at the same rate of molecular. I just did flourine wrong somehow, forgot to halve some stuff I think.
Technical details

Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

fix: Fix Boiler and Spitter molecular acid lasting forever.

CL should be less hyperbolic I think (you may make uninformed people think they actually lasted forever)

sure


Add a "clean column names" option onimport

We may need to add a "clean column names" option in the import window. This would be particularly useful for importing Json files, which produce column names full of unnecessary characters.

Having "clean" column names also allows us to use the simplified cells.column_name.value syntax rather than cells ['Column Name'].value
Resulting cleaned names should be unique and consist of only underscores (but not at the beginning of the name), ASCII lowercase letters and numbers.

This is really needed. Are you thinking about a generic option that would be applicable to multiple importers? It seems to me that this issue is mostly focused on the JSON importer (and XML to some extent). So maybe adding an option to only these two could be enough.

@wetneb Yes, I saw this as a generic option. It is almost essential for JSON files, but it would make it much easier to work in Open Refine, as I said above, as well as to export the file to a database.
Another possibility would be to allow a batch "transform" on the column names.

@wetneb @ettorerizza Yeah, we already have some issues for this at #1017 and #1241 and #898
But I'll let you guys investigate those and come up with a broader brush in this issue to address all of these needs / issues.

Also #901 Rename multiple column names at once

Additional support for this at https://groups.google.com/forum/#!topic/openrefine/ugbIcPJCBpM


Expose settings in tools extensions for specifying the interpreter command for the server

Setting that we will be using for configuring the interpreter for the LSP server.
                "<pytool-module>.interpreter": {
                    "default": [],
                    "description": "When set to a path to python executable, extension will use that to launch the server and any subprocess.",
                    "scope": "window",
                    "items": {
                        "type": "string"
                    },
                    "type": "array"
                },


Remove tab hotkey feature?

The tab key is used quite often to change focus between editable items (for example while navigating in the Attribute Editor) and I feel like setting tab as hotkey only help to put quicklauncher in your way at the wrong time. It seemed a good idea at the time, but the more I look at it the more I dislike it.

I just droped this feature (https://github.com/csaez/quicklauncher/commit/b69227b512efa5a2ddd5b62686a0b70163bf795f)


Error: ENOENT: no such file or directory, rename '.../node_modules/npm/node_modules/ansicolors'

Solution: Delete file package-lock.json and try again.


fix: unique deployment name per region

Deployment fails if the ALZ was already deployed in one region and attempt to deploy it in another region.
Since the deployment name conflicts and is not unique per region

TBH we had in mind that we should use different Deployment name, and I think in that case we should not have any issue, but it's a good suggestion we will merge it.
thanks!


[vcpkg upgrade] [boost] upgrade boost will not upgrade boost-* packages

Describe the bug
upgrade boost will not upgrade boost-* packages.
I think it should upgrade all boost-* packages to current version.
Environment

OS: Windows 10
Compiler: Visual Studio 16.7.7
To Reproduce
Steps to reproduce the behavior:

.\vcpkg.exe upgrade boost:x64-windows
See error:
The following packages will be rebuilt:

boost[core]:x64-windows
The following packages will be built and installed:
boost-stl-interfaces[core]:x64-windows
Additional packages (*) will be modified to complete this operation.
If you are sure you want to rebuild the above packages, run this command with the --no-dry-run option.

Confrimed, this issue could reproduce.
As a workround, you can try following steps:

./vcpkg remove boost-uninstall:x64-windows
Get vcpkg source by 'git pull'
./vcpkg install boost:x64-windows

This is kind of the issue with how we've implemented boost; it's not really a bug, just the way it works right now. We don't really have plans to fix this at this point, and I don't know how we'd do it in the future.
Assigning to @ras0219 since he seems like he might be interested in this.

@PhoebeHui I try your workaround steps but failed:
.\vcpkg.exe remove boost-uninstall:x64-windows
The following packages are not installed, so not removed:
boost-uninstall:x64-windows
Package boost-uninstall:x64-windows is not installed
.\vcpkg.exe install boost-uninstall:x64-windows
Your feedback is important to improve Vcpkg! Please take 3 minutes to complete our survey by running: vcpkg contact --survey
Computing installation plan...
The following packages will be built and installed:
boost-uninstall[core]:x64-windows
Detecting compiler hash for triplet x64-windows...
Starting package 1/1: boost-uninstall:x64-windows
Building package boost-uninstall[core]:x64-windows...
Could not locate cached archive: C:\Users\liugu\AppData\Local\vcpkg\archives\b5\b50d4a1f9aab9fdf55e127513a44ec144eec8ad2.zip
Please use the following command when you need to remove all boost ports/components:
"./vcpkg remove boost-uninstall:x64-windows --recurse"
-- Performing post-build validation
-- Performing post-build validation done
Stored binary cache: C:\Users\liugu\AppData\Local\vcpkg\archives\b5\b50d4a1f9aab9fdf55e127513a44ec144eec8ad2.zip
Building package boost-uninstall[core]:x64-windows... done
Installing package boost-uninstall[core]:x64-windows...
Installing package boost-uninstall[core]:x64-windows... done
Elapsed time for package boost-uninstall:x64-windows: 908.5 ms
Total elapsed time: 5.995 s
.\vcpkg.exe remove boost-uninstall:x64-windows
The following packages will be removed:
boost-uninstall:x64-windows
Removing package boost-uninstall:x64-windows...
Removing package boost-uninstall:x64-windows... done

@zibingrong, I see, boost-uninstall has been added by https://github.com/microsoft/vcpkg/pull/12851 on Aug, it doesn't work for previous revision, please try following steps instead.
./vcpkg remove boost-vcpkg-helpers --recurse
./vcpkg remove boost-modular-build-helper
./vcpkg remove boost-build

@zibingrong, I see, boost-uninstall has been added by #12851 on Aug, it doesn't work for previous revision, please try following steps instead.
./vcpkg remove boost-vcpkg-helpers --recurse
./vcpkg remove boost-modular-build-helper
./vcpkg remove boost-build

@PhoebeHui It is work. Thank you very much.

This seems to have been figured out! Thanks y'all, if you need any other help please don't hesitate to open another issue.


Display name in field schema, #3590

The PR implements an extra metadata field for storing display name.
This is a draft PR. If @ganigeorgiev have no principal disagreement with adding such a feature, I can add tests and clean ups, etc.

Thank you but as mentioned in the related discussion, this remains out of the scope for now.
It is not the specific implementation, nor the effort required for it that I'm against adding it in PocketBase for now.

OK


table without selection

related to #336
after 0.10 <table> with only md-table causes
TypeError: Cannot read property 'splice' of undefined     at md-data-table.js:1056

I just pushed an update, v0.10.4, that should hopefully fix this issue.

looks ok in 10.5


[Feature Request]: Consider switching from pandas to polars for performance improvements

What feature would you like to see?
https://docs.pola.rs/user-guide/getting-started/

Doing some basic profiling with cProfile. Testing the code from the README
client = AmericanSoccerAnalysis()
asa_players = client.get_players(names="Andre")

Pandas
         240613 function calls (238081 primitive calls) in 21.651 seconds

   Ordered by: cumulative time
   List reduced from 1475 to 10 due to restriction <10>

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
      2/1    0.000    0.000   21.651   21.651 {built-in method builtins.exec}
        1    0.000    0.000   21.651   21.651 <string>:1(<module>)
        1    0.000    0.000   21.650   21.650 client.py:477(get_players)
        1    0.004    0.004   21.640   21.640 client.py:70(_get_entity)
        6    0.001    0.000   21.588    3.598 client.py:260(_execute_query)
       13    0.009    0.001   21.549    1.658 client.py:290(_single_request)
       13    0.000    0.000   21.117    1.624 sessions.py:593(get)
       13    0.000    0.000   21.116    1.624 sessions.py:502(request)
       13    0.000    0.000   20.950    1.612 sessions.py:673(send)
       13    0.000    0.000   20.679    1.591 adapter.py:50(send)

Polars


fix: encode 0 in observe option with zero byte length

This PR should finally fix the issues reported in https://github.com/iobroker-community-adapters/ioBroker.philips-air/issues/15 by encoding a value of zero in observe options with a length of zero bytes (as it has been the case before).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

26 of 29 (89.66%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.08%) to 91.676%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/agent.ts
26
29
89.66%

Files with Coverage Reduction
New Missed Lines
%

lib/server.ts
2
86.93%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
2838

Relevant Lines:
3053

💛  - Coveralls


reproject doens't reproject AutoDim dimensions

The dim field of a lookup doesn't inherit the supertype of the dimension (XDim, etc), but defaults to Rasters.AutoDim(). reproject dispatches on this field, So reproject will silently not do anything and return the same values - but with a different crs associated!
using Rasters
import Rasters: XDim
xdim = X(Projected(1:10; crs = EPSG(4326)))
xdim isa XDim # true
lookup(xdim).dim isa XDim # false
lookup(reproject(xdim; crs = EPSG(3857))).data == lookup(xdim).data # true!

I get that when reprojecting we want all dimensions that are not x or y to keep the same values, and this is not a problem after constructing a Raster using the dimension - but maybe there's a way to change the dispatch on the internal reproject methods so this doesn't happen?

Arrg yes thats not cool. We should error on AutoDim. But if you format it first it should work?

Also nothing that is not X or Y should get a crs...

But if you format it first it should work?

Yes it does

Also nothing that is not X or Y should get a crs...

Looked at it again and this only affects Projected dimensions, and I don't think anything that is not X or Y is usually projected


Update StringTable.rsc

string for 'laborer' changed from "Arbeiter" to "Hilfsarbeiter"

Much thanks for fixing this!


update ECR docker url

https://github.com/developmentseed/titiler/blob/810dfeda3cadf8e183f020476df78d77a9fd7adc/deployment/aws/cdk/app.py#L143
https://github.com/developmentseed/titiler/blob/810dfeda3cadf8e183f020476df78d77a9fd7adc/deployment/k8s/titiler/values.yaml#L5
-> public.ecr.aws/developmentseed/titiler

closed by https://github.com/developmentseed/titiler/commit/1c7bf42615a615844f20847ba2682a331a475f44


Settings shown are for Powershell not Powershell Core

[Enter feedback here]
The updated settings.json should show this:
    {
      "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
      "hidden": false,
      "name": "PowerShell",
      "source": "Windows.Terminal.PowershellCore",
      "fontFace": "Cascadia Code PL"
    },

instead of what is currently shown. The currently shown guid is for Windows Powershell not Powershell Core.
At the very least adding a note regarding which section to add the fontFace setting to based on what version of powershell you are using may be helpful and keep others from running into the issue where their change does not seem to work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d3cbeb9a-9e7c-f8f4-5c03-5d6262d2b440
Version Independent ID: eb575c79-5b2a-45f6-646f-9d41d5d223e8
Content: Windows Terminal Powerline Setup
Content Source: TerminalDocs/tutorials/powerline-setup.md
Service: terminal
GitHub Login: @cinnamon-msft
Microsoft Alias: cinnamon

I mean, you could just as easily set up powerline for both Windows PowerShell and PowerShell Core, right? The only really important bit of that settings blob is the "fontFace": "Cascadia Code PL" bit...

Closing as this doesn't appear to require a doc update. Please reopen if this isn't the case.


feat(build-and-test-differential): skip cuda build when tag:require-cuda-build-and-test is not attached

Description
This PR is to prevent the execution of build-and-test-differential (humble, -cuda) for PRs related to packages that are not cuda-related.
For PRs that do not have the tag:require-cuda-build-and-test label, all steps within build-and-test-differential (humble, -cuda) will be skipped.
Related links
This PR reflects the advice of https://github.com/autowarefoundation/autoware.universe/pull/8547.

How was this PR tested?
The setting of this action works well in https://github.com/autowarefoundation/autoware.universe/actions/runs/10488733741/job/29051839562?pr=8562.
Notes for reviewers
This PR should be merged after https://github.com/autowarefoundation/autoware.universe/pull/8555 is merged.
Interface changes
None.

Effects on system behavior
None.

Is this still draft PR?

@youtalk
PR is now open! Please review!


in 1.27, the StatefulsetAutoDeletePVC is default true

in 1.27, the StatefulsetAutoDeletePVC is default true

/cc @dipesh-rawat  Please review this modification

@SuQiucheng, The test cases failed due to Netlify build timeout failures.
please re-push the commit.
git reset
git commit --amend --no-edit
git push --force-with-lease

@SuQiucheng, The test cases failed due to Netlify build timeout failures. please re-push the commit.
git reset
git commit --amend --no-edit
git push --force-with-lease

thanks, i have done it

Thanks.
/lgtm
/approve
May need to fix release-1.27 branch as well.

Thanks. /lgtm /approve
May need to fix release-1.27 branch as well.

ok，I will do it.

/cherrypick release-1.27

@SuQiucheng Looks like the /cherrypick command doesn't work on the website repo. How about a manual PR?

@SuQiucheng @tengqm
If we fix this in the release-1.27 branch then we have to fix this in the release-1.28 branch as well.

@SuQiucheng @tengqm If we fix this in the release-1.27 branch then we have to fix this in the release-1.28 branch as well.

The current live site is 1.28, still evolving. The release-1.27 branch is an archived branch, manual cherry-pick is needed.

@SuQiucheng Looks like the /cherrypick command doesn't work on the website repo. How about a manual PR?

okk.


Failed to parse animated-vector resource

Error:Execution failed for task ':my_project:processReleaseResources'.
> Failed to parse XML resource file '/Users/mms/AndroidStudioProjects/my_project/my_project_lib/build/intermediates/res/merged/release/drawable-v21/avd_downloading_begin.xml'

Hey Alex, I copied and pasted the avd_downloading_begin into my projects drawable-v21 folder along with the vd_downloading, but the IDE is still giving me an error in avd_downloading_begin for target animation attribute should be defined
I have noted to use VectorDrawableCompat and have set vectorDrawables.useSupportLibrary = true in the defaultConfig of both the project and library, and am using AppCompatImageView
Any ideas why this wouldn't work?

Do you still see this error?

Don't have the source/environment anymore.

Hey, I am having the same issue and have no idea what to do about it.
need help!

I just pushed an update to the sample app. I noticed that some of the gradle files were using some stuff from the older gradle 2.4 plugin that has since been deprecated. Not 100% sure if it will fix the issue, but it is worth a shot.
Let me know if you are still encountering the issue after you try out the change...

Hey Alex,  it's still not working. I am able to use another animated vector drawable xml file but not this one(avd_downloading.xml) , any ideas?

Could you include more information about your current dev environment? Because the app is building fine for me.
Specifically, could you go to "Android Studio" --> "About Android Studio" and copy and paste the contents of the dialog that pops up? Mine looks like this:

Other things to try:

Delete the project, re-clone it, and try again (just as a quick sanity check).
Run ./gradlew assembleDebug in the project's root directory and copy/paste the resulting output if there is an error.

Are you still seeing this issue?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/alexjlockwood/adp-delightful-details/issues/3#issuecomment-353737577,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC9zFJoMEC6KdcWAb8pQXh9tA75zIIWGks5tDTS2gaJpZM4Mo-EK
.


WIP logging api change

Revendor client and after merging: https://github.com/keybase/client/pull/6407

Closing for archival.


[UI/UX] BUG: Make the dropdown of heading 50% smaller  with only links so that we can see the content

The Menu Drop Down on the heading is too big and hurts the UI/UX experience by blocking important content.

We want to remove heading and description and just provide links
All links will be on the same line with the names as follows: Quick Start, Governance, Running a Node, Setup LimitOrder Bot, Github, Security.
Remove the spacings above and below the headers so the content on the page is not blocked. Currently no content is readable with these headers.

Shipped.


Installing package 2.0.0 failed

After installing, I got following error:
> elm install y0hy0h/ordered-containers
Here is my plan:

  Add:
    y0hy0h/ordered-containers    2.0.0

Would you like me to update your elm.json accordingly? [Y/n]: y
-- CORRUPT PACKAGE DATA --------------------------------------------------------

I downloaded the source code for y0hy0h/ordered-containers 2.0.0 from:

    https://github.com/y0hy0h/ordered-containers/zipball/2.0.0/

But it looks like the hash of the archive has changed since publication:

  Expected: 3de944919fd7d0204de1eb6462ecfede583844a8
    Actual: 6374f27eb668ca44224aefd3e5e10e1e29be72e7

This usually means that the package author moved the version tag, so report it
to them and see if that is the issue. Folks on Elm slack can probably help as
well.

Thanks for reporting. I don't recalling messing with the tags. I'll investigate.

I just moved the tag around and now back to where it was before and I can install the package again. 🤷
@jevanlingen Can you confirm that the issue is fixed for you, too?

Yeah, works like a charm now. Thx for the quick response!!


Update to 4.0.4 for Npgsql and plugins

Per discussion here.

4.0.4 just hit NuGet, rebuilding on AppVeyor.

Merged via 8dff6394cf1a509ee1a790abce4f24b7e32b2a14


Node is not given a hostname on first boot after install

You need an extra reboot for the hostname to get set. This causes issues with the k3s node name getting changed.
I'm not sure this is the right place to file this ticket.

Where and when are you trying to set the hostname ?

We now usually put
spec:
  cloudConfig:
    hostname: ros-node-{{ trunc 4 .MachineID }}

into the machine registration to have the hostname set during initial deployment.
Maybe this should be made standard in all examples ? (It certainly needs more documentation :wink:)

I hadn't set anything so was just taking the default rancher-xxxxx that got added. I'll add the specific line to see if it changes the behavior in my set up.

Confirmed this is not an issue when the hostname is set in the cloudConfig settings


tableOddRowBackgroundColor changes all table colors below the first odd row

I was trying to remove the zebra from the tables but using tableOddRowBackgroundColor(Color.WHITE) cleared half the borders of the table. I then switched to Color.RED and got the screenshot below

After taking a look at the code, adding tableBorderColor(…) to the SpannableTheme fixes it.
The odd row sets the paint color and the border uses it because there's nothing set on the theme. Seems like a bug on the SpannableTheme since, by default, the table has a border color and should use it.

@carlosefonseca you are on 🔥 today! :)

Hello @carlosefonseca !
I did snapshot version with the fix. I also added customizations for even and headers rows


Seems like its not working with ember 1.9.1 and ember-cli 1.7

Seems like its not working with ember 1.9.1 and ember-cli 1.7
 Uncaught Error: Could not find module ember-metal/streams/utils

If i remove the package, it all work fine... ( clean project)

Correct, 0.0.5 is a bad release. You'll need to rollback to 0.0.4. 0.0.6 will be ember 1.10+

Alternatively if you use the master branch and the latest beta of Ember 1.10 you should be good too

I'm trying to incorporate this gem into my project, and I installed v0.0.4, after having initially installed v0.0.5 and getting the error mentioned above. However, I'm still getting the same error on the browser's console, after downgrading to v0.0.4.
Uncaught Error: Could not find module ember-metal/streams/stream

I'm using the following versions of stuff:
node       : 0.10.35
npm        : 2.1.8
Ember CLI  : 0.1.12
Ember      : 1.8.1
Ember Data : 1.0.0-beta.12
Handlebars : 1.3.0
jQuery     : 1.11.2

But supposedly the 0.0.4 release is ok. Any ideas why?

There are certain APIs that aren't available in Ember 1.8 that 0.0.5 is expecting. However, 0.0.5 is also broken. We are awaiting the release of Ember 1.10 before cutting 0.0.6

@gnapse maybe try handlebars 2.0.0

@kellyselden the issue is that he is using Ember 1.8 which doesn't have Stream support

Ember 1.8 is what the latest ember-cli gives me out of the box. I'll dig into upgrading it, but fi you could suggest anything, let me know.

Upgraded to Ember 1.10 and handlebars 2.0.0. Everything's fine now. Thanks again.

@gnapse you can use master branch of this repo as well now that you're on the 1.10


dbeaver/pro#2729 SSH page settings load fix

To reproduce:

Choose the "public key" authentication method and specify the path to a key
Save the connection
Delete the specified key
Open the connection, open the SSH page

Also, check:

[ ] Changing the active profile updates the current configuration, including the "Enable XXX" checkbox next to the combo

verified


CrazyFlie2 COLLADA mesh not loaded properly

I'm not sure whether the issue comes from yourdfpy or one of its dependencies, but the CrazyFlie2 URDF does not load properly.
The URDF has a single Collada mesh, here it is loaded by Blender (left) and yourdfpy 0.0.52 (right):

In yourdfpy, three out of four propellers are missing.

I can't really reproduce this error. The link above is not pointing to any URDF. What's the URDF in question?
I tried it with https://github.com/utiasDSL/gym-pybullet-drones/tree/master/gym_pybullet_drones/assets and both cf2x.urdf and cf2p.urdf look fine in the current yourdfpy version:

Sorry for the missing link, the URDF was indeed the one from gym-pybullet-drones.
I just tried again with the latest versions and it works :+1:


Feature/multiple translations

This PR is mainly focused on adding translations but also consists:

Cleanup of old Filamentphp v2 code to v3
Cleanup of menu
Ordening of code to make it more readable
General small adjustments i came accross while translating

Unintentially became a bigger PR then i wanted it to be.


Why the data path is to real images?    'gen-nuscnes-train-infos.pkl'

Follow your instruction, the gen image will be in the path ./data/nuscenes/gen-nuscenes-train
But the data path in 'gen-nuscnes-train-infos.pkl' is to ./data/nuscenes/samples/, which contains real images.

Is that mean you train the model on the real data?
Also, I find 8 pictures in the fold, which one should be used for training?

Hi， the path in the gen-nuscnes-train-infos.pkl is the original path of nuscenes, but in training the root path will be replaced by /data/Dataset/nuScenes/gen-nuscenes-train/, so it actually uses Gen-nuScenes rather than real nuScenes. Each folder contains a video with 8 consecutive frames.  You should use all 8 frames for training.

Oh, I have found the code for replacing in nuscenes_dataset.py
Thank you for your prompt reply !


Insert Metrics Tracker in the toolchain

Add tracker to tracker metrics in the toolchain
Add option to disable tracker
Add environment variables to capture tracker option and chatbot name without timestamp.
Add privacy notice

I think my branch doesn't have the cf login credential to pass the build.

@Tomcli how did you test this out?

All the UI changes are in the deploy.json file. I added a new section that allows users to disable the tracker. You can create a new branch with my changes and try it out with any chatbot by adding &branch=yourBranchName at the end of the toolchain link. This way you should able to test the new UI and pipeline code.

Thank you for your feedback @stevemart. I updated the toolchain UI to a dropdown and added some logs for the tracker. Please use the below link to test the new UI and pipeline code because I am merging from my tracker branch.

https://console.bluemix.net/devops/setup/deploy?repository=https%3A//github.com/Tomcli/chatbot-deployer&chatbotName=Simple Banking Chatbot&chatbotWorkspaceURL=http://developer.ibm.com/code/wp-content/uploads/sites/118/2017/09/banking.json&cm_sp=dw-bluemix-_-code-_-devcenter&branch=tracker


Count rows as a metadata only operation

closes issue: Count rows as a metadata-only operation #1223

Question: Does it make sense to expose this as the __len__ dunder method because python? It would just return the self.count()


[Help] Truncating of filename doesn't work for sidecar files like info.json

The args I'm using are these, I'll have to get un-429's by YT before I can retry and provide verbose logs I think. Sorry :/ But maybe the args already tell the story?
    '-o',
        'subscriptions/channels/イル_フローラ/%(uploader)s [%(channel_id)s]/%(upload_date)s - %(title)200B [%(id)s].%(ext)s',
        '--write-info-json',
        '--print-json',
        '-f',
        'bestvideo+bestaudio',
        '--merge-output-format',
        'mp4',
        '--cookies',
        'appdata/cookies.txt',
        '--download-archive',
        '/app/subscriptions/archives/イル_フローラ/merged_video.txt',
        '--write-thumbnail',
        '--no-call-home',
        '--write-info-json',
        '--no-clean-infojson',
        '--write-subs',
        '--sub-langs',
        'en.*,de,fr,jp,ko,zh.*,live_chat',
        '--sub-format',
        'srt/ass/best',
        '--write-thumbnail',
        '--write-comments',
        '--extractor-args',
        'youtube:comment_sort=top',
        '--extractor-args',
        'funimation:version=uncut',
        '--geo-bypass',
        '--sponsorblock-mark',
        'all',
        '--no-call-home',
        '--write-info-json',
        '--no-clean-infojson',
        '--write-subs',
        '--sub-langs',
        'en.*,de,fr,jp,ko,zh.*,live_chat',
        '--sub-format',
        'srt/ass/best',
        '--write-thumbnail',
        '--write-comments',
        '--extractor-args',
        'youtube:comment_sort=top',
        '--extractor-args',
        'funimation:version=uncut',
        '--geo-bypass',
        '--sponsorblock-mark',
        'all',
        '--no-clean-infojson'

Context:

I am using yt-dlp within a project I (try to) help maintain (I'm not a programmer, but I like to think I'm not bad at troubleshooting, support and some other stuff. Currently I'm keeping the ship afloat whilst the creator of the app is on a needed hiatus, so I'm trying to do my best)

the previous comment trail:

Use .200s for 200 characters and .200B for 200 bytes

Could it be that this only propagates to the video file name and the info.json can still fail? Either that or the application I'm trying to maintain interferes with yt-dlp handling this well otherwise.
Originally posted by @GlassedSilver in https://github.com/yt-dlp/yt-dlp/issues/1837#issuecomment-1101469382

'subscriptions/channels/イル_フローラ/%(uploader)s [%(channel_id)s]/%(upload_date)s - %(title)200B [%(id)s].%(ext)s',

It should be .200B. You missed the dot. But since your video download is fine, I assume that isn't the issue. Nothing else looks wrong in the config. Provide the log when you are able to

I added the period, and it seems to have fixed it. I'll close the issue now and if I encounter the bug again or if I just got lucky on some files I'll comment again, but so far so good I guess! :D
Thank you so much!


Security Vulnerabilities

Hi,
Thanks for the amazing work on this project. Just have a few concerns. After running npm audit in a project that works with scraperjs as a dependency, I get the following results:

Also, since phantomjs has been archived, alternatives to that are also worth looking at because the security vulnerabilities that come with phantomjs have creeped into scraperjs as well.
I think something must be done about these vulnerabilities as some of them are on moderate as well as on a high level. Please let me know if there's something else need from my end.

The last commit was 5 years ago. I think it's safe to assume that this project is abandoned.


Ejectable GetConnect

Hello @jonataslaw,
Thanks to creating getx.
i have a problem there is ambiguity when calling FormData and MultipartFile classes when i use dio. because the same does not use the default getconnect from getx. I use dio in my project. is there a feature to eject getconnect in getx.
thanks very much

I do have same prob like you so as i put mine for the mean time i add alias for the import on dio.


[Fix] DateInput: Address accessibility issues with date input

@henten20 please stop opening duplicate PRs on this repo.


Clean up the filtering logic in the build routine

Make the filtering/disabling logic in the build routine a bit clearer.

thanks - please let me know when the new package is up on PyPI.

@gvwilson I'll make an updated release tomorrow but note that this PR doesn't actually change any functionality -- both the build_node filter and the disable flag were already supported, this PR just refactors the code to make the logic a bit more readable.
So you don't need to wait for a new release to make use of the filter -- it's always been there ;)


Shouldn't we use Float64Arrays instead of Float32Arrays?

This does not seem to hinder the layout and saves up some RAM. Can probably close for now.


directvnc: 0.7.5-test-051207 -> <IP_ADDRESS>5-04-16

Motivation for this change
0.7.7 has fixes for known bugs in 0.7.5. (They were not enough to make it run properly on my Eee PC, though, but that might be due to kernel driver issues.)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

directvnc works for me (at least after this PR; I have not checked before).


[Feature Request]: SD XL support

I'm willing to implement SDXL once I've improved the support for SD 1.x and added support for SD 2.x.

Beside LCM being available for XL models, stability.ai released SDXL-turbo a destil(finetune?) that can generate good images with a single step.

https://huggingface.co/stabilityai/sdxl-turbo

is is compatible with this repo?

@leejet this can be closed

@zhongwei Support for SDXL has been added. You can try pulling the latest code from the master branch.

@leejet this can be closed

Generally, I don't proactively close issues unless they've been resolved for an extended period without any response from the person who opened the issue. I prefer the individuals who opened the issue to confirm its resolution and close it themselves.

Did anyone try running sd_xl ? For some reason its generating a empty image (its pitch black) .. Following is the command i used and its output
$ ./bin/sd  -m ~/downloaded_models/sdxl-turbo/sd_xl_turbo_1.0_fp16.safetensors -p "a lovely cat"
[INFO]  stable-diffusion.cpp:5386 - loading model from '~/downloaded_models/sdxl-turbo/sd_xl_turbo_1.0_fp16.safetensors'
[INFO]  model.cpp:638  - load ~/downloaded_models/sdxl-turbo/sd_xl_turbo_1.0_fp16.safetensors using safetensors format
[INFO]  stable-diffusion.cpp:5412 - Stable Diffusion XL
[INFO]  stable-diffusion.cpp:5418 - Stable Diffusion weight type: f16
[INFO]  stable-diffusion.cpp:5573 - total memory buffer size = 6570.56MB (clip 1565.66MB, unet 4909.43MB, vae 95.47MB)
[INFO]  stable-diffusion.cpp:5579 - loading model from '~/downloaded_models/sdxl-turbo/sd_xl_turbo_1.0_fp16.safetensors' completed, taking 1.78s
[INFO]  stable-diffusion.cpp:5593 - running in eps-prediction mode
[INFO]  stable-diffusion.cpp:6486 - apply_loras completed, taking 0.00s
[INFO]  stable-diffusion.cpp:6525 - get_learned_condition completed, taking 1547 ms
[INFO]  stable-diffusion.cpp:6535 - sampling using Euler A method
[INFO]  stable-diffusion.cpp:6539 - generating image: 1/1 - seed 42
  |==================================================| 20/20 - 18.15s/it
[INFO]  stable-diffusion.cpp:6551 - sampling completed, taking 353.73s
[INFO]  stable-diffusion.cpp:6559 - generating 1 latent images completed, taking 353.89s
[INFO]  stable-diffusion.cpp:6561 - decoding 1 latents
[INFO]  stable-diffusion.cpp:6571 - latent 1 decoded, taking 17.36s
[INFO]  stable-diffusion.cpp:6575 - decode_first_stage completed, taking 17.36s
[INFO]  stable-diffusion.cpp:6590 - txt2img completed in 372.80s
[INFO]  main.cpp:538  - save result image to 'output.png'

i also tried downloading the unets/vae etc.. and passing the same as argument (along with some minor code changes to load f16.safetensor instead of just .safetensor - std::string unet_path = path_join(file_path, "unet/diffusion_pytorch_model.safetensors");)
$ ./bin/sd  -m ~/downloaded_models/sdxl-turbo/sd_xl_turbo_1.0_fp16.safetensors --vae ~/downloaded_models/sdxl-turbo/ -p "a lovely cat"
[INFO]  stable-diffusion.cpp:5386 - loading model from '~/downloaded_models/sdxl-turbo/sd_xl_turbo_1.0_fp16.safetensors'
[INFO]  model.cpp:638  - load ~/downloaded_models/sdxl-turbo/sd_xl_turbo_1.0_fp16.safetensors using safetensors format
[INFO]  stable-diffusion.cpp:5395 - loading vae from '~/downloaded_models/sdxl-turbo/'
[INFO]  model.cpp:632  - load ~/downloaded_models/sdxl-turbo/ using diffusers format
[INFO]  stable-diffusion.cpp:5412 - Stable Diffusion XL
[INFO]  stable-diffusion.cpp:5418 - Stable Diffusion weight type: f16
[WARN]  stable-diffusion.cpp:5503 - unknown tensor 'unet.add_embedding.linear_1.bias' in model file
[WARN]  stable-diffusion.cpp:5503 - unknown tensor 'unet.add_embedding.linear_1.weight' in model file
[WARN]  stable-diffusion.cpp:5503 - unknown tensor 'unet.add_embedding.linear_2.bias' in model file
[WARN]  stable-diffusion.cpp:5503 - unknown tensor 'unet.add_embedding.linear_2.weight' in model file
[WARN]  stable-diffusion.cpp:5503 - unknown tensor 'model.diffusion_model.output_blocks.2.1.conv.bias' in model file
[WARN]  stable-diffusion.cpp:5503 - unknown tensor 'model.diffusion_model.output_blocks.2.1.conv.weight' in model file
[INFO]  stable-diffusion.cpp:5573 - total memory buffer size = 6570.56MB (clip 1565.66MB, unet 4909.43MB, vae 95.47MB)
[INFO]  stable-diffusion.cpp:5579 - loading model from '~/downloaded_models/sdxl-turbo/sd_xl_turbo_1.0_fp16.safetensors' completed, taking 2.61s
[INFO]  stable-diffusion.cpp:5593 - running in eps-prediction mode
[INFO]  stable-diffusion.cpp:6486 - apply_loras completed, taking 0.00s
[INFO]  stable-diffusion.cpp:6525 - get_learned_condition completed, taking 1592 ms
[INFO]  stable-diffusion.cpp:6535 - sampling using Euler A method
[INFO]  stable-diffusion.cpp:6539 - generating image: 1/1 - seed 42
  |==================================================| 20/20 - 18.09s/it
[INFO]  stable-diffusion.cpp:6551 - sampling completed, taking 353.85s
[INFO]  stable-diffusion.cpp:6559 - generating 1 latent images completed, taking 353.85s
[INFO]  stable-diffusion.cpp:6561 - decoding 1 latents
[INFO]  stable-diffusion.cpp:6571 - latent 1 decoded, taking 17.08s
[INFO]  stable-diffusion.cpp:6575 - decode_first_stage completed, taking 17.08s
[INFO]  stable-diffusion.cpp:6590 - txt2img completed in 372.51s
[INFO]  main.cpp:538  - save result image to 'output.png'

But its the same result.. i have tried the older stable diffusion - stable-diffusion-2-1/v2-1_768-nonema-pruned.safetensors it works..
I m running on ubuntu 22.03.

@ranjithum The VAE in SDXL encounters NaN issues under FP16, but unfortunately, the ggml_conv_2d only operates under FP16. Hence, a parameter is needed to specify the VAE that has fixed the FP16 NaN issue. You can find it here: SDXL VAE FP16 Fix.
./bin/sd -m ../models/sd_xl_base_1.0.safetensors --vae ../models/sdxl_vae-fp16-fix.safetensors -H 1024 -W 1024 -p "a lovely cat" -v

@leejet - Perfect thanks.. It worked..

@leejet we should probably put up a warning in the program, when f32 vae is used. (until its fixed).

Works for me, but colors are weirdly off:

Works for me, but colors are weirdly off with SD XL plus fp16 fix:

Try changing the image size to 1024x1024. SDXL is not suitable for generating images of size 512x512.

Try changing the image size to 1024x1024. SDXL is not suitable for generating images of size 512x512.

Nope, still just as broken for me.

can confirm the black screen. Out of 10 SDXL checkpoints I got from civitai only 2 work.  For example Crystal Clear XL is broken. These checkpoints work in diffusers and a1111. Would also like to request functionality to generate a batch of images with different seeds (preferably generated within the tool) without reloading and reinitializing everything. I understand that model is cached in RAM but I'm pretty sure there are still seconds that could be saved here.

stable-diffusion.cpp/build/bin/sd -m stable-diffusion.cpp/models/sd_xl_turbo_1.0_fp16.safetensors --vae stable-diffusion.cpp/models/sdxl_vae.safetensors --steps 1 --cfg-scale 1 -s -1 -p "a lovely cat"
Work perfectly for me

Loras don't work for me for some reason. maybe I'm doing something wrong.
I'm using the following command
for m in models/SDXL/.safetensors; do ./stable-diffusion.cpp/dist/bin/sd -m "${m}" -p "a cute cat <lora:SCRATCHBOARD ILLUSTRATION:0.8>" -W 1024 -H 1024 --steps 30 --sampling-method dpm++2m --schedule karras --embd-dir models/embeddings/ --vae models/SDXL/vae/sdxl_vae.safetensors -s $RANDOM -b 2 --lora-model-dir models/SDXL/lora/ -v -o images/$(basename -- "$m" ".${m##.}"| tr " " "-").png -v ; done;
and this lora https://civitai.com/models/279729/wizards-scratchboard-illustration
Relevant portion of output:
[INFO ] model.cpp:645  - load models/SDXL/lora/SCRATCHBOARD ILLUSTRATION.safetensors using safetensors format
[DEBUG] model.cpp:711  - init from 'models/SDXL/lora/SCRATCHBOARD ILLUSTRATION.safetensors'
[DEBUG] ggml_extend.hpp:555  - lora params backend buffer size =  874.24 MB (10240 tensors)
[INFO ] lora.hpp:35   - loading LoRA from 'models/SDXL/lora/SCRATCHBOARD ILLUSTRATION.safetensors'
[DEBUG] model.cpp:1262 - loading tensors from models/SDXL/lora/SCRATCHBOARD ILLUSTRATION.safetensors
[DEBUG] lora.hpp:58   - finished loaded lora
[WARN ] lora.hpp:154  - unused lora tensor lora.te1_text_model_encoder_layers_0_mlp_fc1.alpha
[WARN ] lora.hpp:154  - unused lora tensor lora.te1_text_model_encoder_layers_0_mlp_fc1.lora_down.weight
[WARN ] lora.hpp:154  - unused lora tensor lora.te1_text_model_encoder_layers_0_mlp_fc1.lora_up.weight
[WARN ] lora.hpp:154  - unused lora tensor lora.te1_text_model_encoder_layers_0_mlp_fc2.alpha
[WARN ] lora.hpp:154  - unused lora tensor lora.te1_text_model_encoder_layers_0_mlp_fc2.lora_down.weight
[WARN ] lora.hpp:154  - unused lora tensor lora.te1_text_model_encoder_layers_0_mlp_fc2.lora_up.weight
[WARN ] lora.hpp:154  - unused lora tensor lora.te1_text_model_encoder_layers_0_self_attn_k_proj.alpha

The official example LoRA is failing for me too (from https://huggingface.co/stabilityai/stable-diffusion-xl-base-1.0/tree/main).
(base) tnunamak@pc:~/stable-diffusion.cpp$ ./build/bin/sd -m models/sd_xl_base_1.0.safetensors --vae models/sdxl_vae.safetensors -H 1024 -W 768 --cfg-scale 1 --steps 35 -p "A lovely cat <lora:sd_xl_offset_example-lora_1.0:0.8>" --lora-model-dir models
ggml_init_cublas: GGML_CUDA_FORCE_MMQ:   no
ggml_init_cublas: CUDA_USE_TENSOR_CORES: yes
ggml_init_cublas: found 2 CUDA devices:
  Device 0: NVIDIA GeForce RTX 3090, compute capability 8.6, VMM: yes
  Device 1: NVIDIA GeForce RTX 3090, compute capability 8.6, VMM: yes
[INFO ] stable-diffusion.cpp:165  - loading model from 'models/sd_xl_base_1.0.safetensors'
[INFO ] model.cpp:705  - load models/sd_xl_base_1.0.safetensors using safetensors format
[INFO ] stable-diffusion.cpp:176  - loading vae from 'models/sdxl_vae.safetensors'
[INFO ] model.cpp:705  - load models/sdxl_vae.safetensors using safetensors format
[INFO ] stable-diffusion.cpp:188  - Stable Diffusion XL
[INFO ] stable-diffusion.cpp:194  - Stable Diffusion weight type: f16
[INFO ] stable-diffusion.cpp:400  - total params memory size = 6558.89MB (VRAM 6558.89MB, RAM 0.00MB): clip 1564.36MB(VRAM), unet 4900.07MB(VRAM), vae 94.47MB(VRAM), controlnet 0.00MB(VRAM), pmid 0.00MB(VRAM)
[INFO ] stable-diffusion.cpp:419  - loading model from 'models/sd_xl_base_1.0.safetensors' completed, taking 3.72s
[INFO ] stable-diffusion.cpp:436  - running in eps-prediction mode
[INFO ] model.cpp:705  - load models/sd_xl_offset_example-lora_1.0.safetensors using safetensors format
[INFO ] lora.hpp:38   - loading LoRA from 'models/sd_xl_offset_example-lora_1.0.safetensors'
[WARN ] lora.hpp:160  - unused lora tensor lora.unet_input_blocks_1_0_emb_layers_1.alpha
[WARN ] lora.hpp:160  - unused lora tensor lora.unet_input_blocks_1_0_emb_layers_1.lora_down.weight
[WARN ] lora.hpp:160  - unused lora tensor lora.unet_input_blocks_1_0_emb_layers_1.lora_up.weight
[WARN ] lora.hpp:160  - unused lora tensor lora.unet_input_blocks_1_0_in_layers_2.alpha
[WARN ] lora.hpp:160  - unused lora tensor lora.unet_input_blocks_1_0_in_layers_2.lora_down.weight
[WARN ] lora.hpp:160  - unused lora tensor lora.unet_input_blocks_1_0_in_layers_2.lora_up.weight
[WARN ] lora.hpp:160  - unused lora tensor lora.unet_input_blocks_1_0_out_layers_3.alpha
[WARN ] lora.hpp:160  - unused lora tensor lora.unet_input_blocks_1_0_out_layers_3.lora_down.weight
[WARN ] lora.hpp:160  - unused lora tensor lora.unet_input_blocks_1_0_out_layers_3.lora_up.weight
[WARN ] lora.hpp:160  - unused lora tensor lora.unet_input_blocks_2_0_emb_layers_1.alpha
...
[WARN ] lora.hpp:160  - unused lora tensor lora.unet_output_blocks_8_0_skip_connection.lora_up.weight
[INFO ] stable-diffusion.cpp:524  - lora 'sd_xl_offset_example-lora_1.0' applied, taking 1.01s
[INFO ] stable-diffusion.cpp:1602 - apply_loras completed, taking 1.01s
[INFO ] stable-diffusion.cpp:1712 - get_learned_condition completed, taking 93 ms
[INFO ] stable-diffusion.cpp:1728 - sampling using Euler A method
[INFO ] stable-diffusion.cpp:1732 - generating image: 1/1 - seed 42
  |==================================================| 35/35 - 2.90it/s
[INFO ] stable-diffusion.cpp:1769 - sampling completed, taking 12.61s
[INFO ] stable-diffusion.cpp:1777 - generating 1 latent images completed, taking 12.61s
[INFO ] stable-diffusion.cpp:1779 - decoding 1 latents
[INFO ] stable-diffusion.cpp:1789 - latent 1 decoded, taking 0.99s
[INFO ] stable-diffusion.cpp:1793 - decode_first_stage completed, taking 0.99s
[INFO ] stable-diffusion.cpp:1810 - txt2img completed in 13.70s
save result image to 'output.png'
double free or corruption (fasttop)
Aborted (core dumped)


Add feature for revoking access packages

@OWinfreyATL
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Create ecr_registry resource to login to ecr

Referencing https://github.com/chef-cookbooks/docker/issues/660
To access docker images in ECR we need to login using awscli.
See https://gist.github.com/chrisferry/f716d3e74d534598eaa5 for an example.

@chrisferry Can you please explain how to use this "https://gist.github.com/chrisferry/f716d3e74d534598eaa5 " ?

Here is a workaround for this issue.

Setup your access keys to your node.
Add this to your recipe. It will simply login to ECR.
cmd = "aws ecr get-login --region us-east-1"
value = #{cmd}
list = value.split(" ")

docker_registry 'AWS ECR registry' do
serveraddress 'https://xyz.ecr.us-east-1.amazonaws.com'
username 'AWS'
password "#{list[5]}"
email 'none'
end

I'd like to begin work on this feature (have a dire use case for it), but it would require the aws cookbook to depend on the docker cookbook to implement fully. In the interest of keeping aws lightweight, I'm thinking of creating a separate aws_ecr cookbook with nothing but an aws_ecr_registry LWRP, but will defer that decision to this cookbook's maintainers.

+1 to this. Staggering that Chef has no native resource to be able to log into ECR. What year is this?

@petewilcock 2018 apparently.

@turtleDev Greetings from 2019.

Are you all blocked or you just want a Chef resource?
If blocked, I don't mind providing the way to do it.
Ping me and I'll post solution here 👨🍳

@rashidmahmood already demonstrated how to work around the issue.
But here's the thing, the cookbook should already provide a resource for ECR, since that's the 'proper' way of doing it.

@turtleDev I don't think it's a good workaround as you refresh the token within the valid interval for no reason as well as having the username hardcoded (creds are base64 encoded with the username inside).
But sure.

The username for the ECR login never changes S far as I’m aware, so there’s no huge issue with it being hard-coded. As far as refreshing the token, since it’s only valid for a relatively short amount
of time (compared to the standard Docker login), you should probably just refresh it when your client runs to avoid any pitfalls.
Either way, the other solutions seemed to be missing things or weren’t as flexible as I’d hoped. I ended up writing a quick recipe that works with the Docker cookbook and allows me to login during the run. I’ll share the gist if anyone wants to use it. It’s pretty adaptable and could be converted into a resource.

Have a look at: https://github.com/awslabs/amazon-ecr-credential-helper

@scalp42

don't think it's a good workaround as you refresh the token within the valid interval for no reason as well as having the username hardcoded (creds are base64 encoded with the username inside).

I totally agree.
But rather than having another workaround, I'd rather have a resource to work with.
That said, I think it's a good idea for you to post your work around here anyway, if you think it solves the problem better than the current fix. It maybe useful for other people who ran into the same problem as the rest of us.

@scalp42 Ah, that's a great callout, actually, and a much better solution. I always forget about the credential helper (despite using it elsewhere).

@charlieoleary I think so too as well.

install golang
download or install the helper with the go get
use a file resource in Chef with target /root/.docker/config.json
dump the content of a hash of attributes for your repositories with JSON.dump:	file '/root/.docker/config.json' do
		content JSON.pretty_generate(node['my_repositories'].to_h, quirks_mode: true)
	end

Bonus point is that you can also have ECR, Quay etc working at the same time in the my_repositories hash.
I just don't think it registries auth have much to do with Chef resources to be transparent but if it works for you 🤷♂

Yeah, totally. The previous use case was to avoid persisting a DockerHub / Quay / whatever login on each instance for anyone to use and making that only available to Chef. The docker cookbook made this workable with the docker_registry resource. This is less of an issue with ECR since it’s handled with IAM roles, so the logins can be handled in a much more flexible manner.


[release-v1.0] Change Mem and CPU for CI jobs

This is a cherry-pick of https://github.com/openshift-knative/eventing-kafka-broker/pull/117

/cherry-pick release-v0.26

/assign @aliok

/test 49-e2e-aws-ocp-49

/test 49-images


Elm app: 'Shutting down tauri process' in 5 seconds after tauri dev

Thank you for an awesome project! Eager to try and use it!
Describe the bug
I have an Elm app https://github.com/fluencelabs/p2p-fileshare , and I wanted to try tauri with it. So I run elm-app start and then npx tauri dev (configured to http:/localhost:3000/`), tauri starts, shows white window, and then stops:
$ npx tauri dev
[tauri]: running dev
(node:90475) ExperimentalWarning: The fs.promises API is experimental
 app:spawn Running "cargo run" +0ms

   Compiling app v0.1.0 (/Users/folex/Development/p2p-fileshare/src-tauri)
   Compiling tauri v0.7.1
    Finished dev [unoptimized + debuginfo] target(s) in 5.91s
     Running `target/debug/app`
 app:tauri Shutting down tauri process... +6s

To Reproduce
Steps to reproduce the behavior:

Clone p2p-fileshare
Run npm install
Configure tauri with: { "distDir": "./build", "devPath": "http://localhost:3000/" }
npm run start will run elm-app start
npx tauri dev

I'm not sure if that has any effect, but to produce ./build directory, run npm run build, it will generate release bundle (it takes a while).
Expected behavior
Tauri development window appear
Screenshots
Just a white window which closes pretty fast.
Platform and Versions (please complete the following information):
$ npx tauri info
[tauri]: running info

Operating System - Darwin(18.7.0) - darwin/x64

Node.js environment
  Node.js - 10.16.0
  tauri.js - 0.8.1

Rust environment
  rustc - 1.46.0-nightly
  cargo - 1.45.0-nightly
  tauri-bundler - Not installed

Global packages
  NPM - 6.14.4
  yarn - 1.17.3

App directory structure
/.circleci
/.git
/build
/elm-stuff
/node_modules
/public
/src
/src-tauri
/tests

App
  tauri.rs - 0.7.1
  mode - embedded-server
  build-type - bundle
  CSP - default-src blob: data: filesystem: ws: http: https: 'unsafe-eval' 'unsafe-inline'
  Windows - Edge
  distDir - ./build
  devPath - http://localhost:3000/

Stack Trace
$ npx tauri dev
[tauri]: running dev
(node:90475) ExperimentalWarning: The fs.promises API is experimental
 app:spawn Running "cargo run" +0ms

   Compiling app v0.1.0 (/Users/folex/Development/p2p-fileshare/src-tauri)
   Compiling tauri v0.7.1
    Finished dev [unoptimized + debuginfo] target(s) in 5.91s
     Running `target/debug/app`

Would be awesome to have some --verbose option to enable debug logs, or maybe RUST_LOG=debug via env_logger :)

Will take a look at it tomorrow. Sorry I've been busy with Windows :/
I totally agree with you regarding logging, but we're a small team :( maybe you could start a PR starting it?

Tried it with the latest published Tauri and it seems to work fine, can you try again?
If it still doesn't work then it might be your macOS version or the nightly Rust.

Regarding logging, there is a new feature request. I highly recommend checking it out and helping figure out the requirements:
https://github.com/tauri-apps/tauri/issues/735

I've tried on tauri 0.7.5 (btw, awesome updates on UX!) and stable rust – same behaviour: white window opens and closes.
I asked a friend to try on ubuntu, and it worked (after a few additional apt-gets).
So I guess it's a macOS that's the problem, or maybe some system-wide packages. I'll try to dig into code to debug this problem when I have free time, but can't promise that yet :)
Regarding logging: I see that #735 is about in-app logging, I was talking more about debugging tauri itself. If I will have a chance to dig into tauri's code, I'll try to submit a PR, but can't promise.
P.S. here's what my friend had to install apart from packages described in the docs:

libdbus-1-dev
libgtk-3-dev
libsoup2.4

hope that helps!

So, I have no problem getting this to work, but on reviewing I noticed a couple things: npx is buggy, or rather the CDN / and potentially NPM's move to the Microsoft empire.  It actually wrongly installed an outdated template file, which pulled in tauri.rs: 0.5.
I saw a few other troubling issues with npm install, that had to do with potentially corrupted tarball data.
Screenshot 2020-07-13 at 13.19.56
Technically offtopic, but there are also a number of "unpatchable vulns" in create-elm-app, most of which have to do with your friend and mine, lodash.
Please note: you have not installed the bundler. You can do so with:
cargo install tauri-bundler
I did install tauri with yarn add tauri and ran yarn tauri dev. npx does work as well, however there are (as I mentioned above and here) concerns with npx as a part of your toolchain.

I forgot to mention in the previous message, but I have installed tauri-bundler, it didn't help.
But yarn did. With yarn tauri dev it runs! I gotta fix Content-Security-Policy for the networking to work, but otherwise everything seems working now.
I guess the problem was node version, because running yarn add tauri errored with
[2/4] 🚚  Fetching packages...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">= 10.17.0". Got "10.16.0"

Now it works with both yarn and npm :)
Thanks a lot!

Couldn't reproduce on Linux with node v10.16.0. Anyway weird that npm doesn't validate the engine.

Closing it since we're not encouraging npx anymore and the nodejs CLI is being rewritten in Rust so this issue isn't relevant anymore.


preparation for release 3.3.0

@WellingR added the link and reviewed all the links at the end of the README.md file.
Because I move part of the content to the wiki, we now have broken links there. It seems that this notataion [link-name]: url doesn't work in the week. I will fix it.


[WIP] Add cross-account FT & NFT supporting scripts & transactions

⚠ WORK IN PROGRESS 🏗
This PR contains a script to discover the paths related to a FungibleToken Vault and generalized transaction to facilitate transfers between child & parent accounts.
TODO:

[ ] Add test coverage
[ ] NFT-related scripts & transactions

Codecov Report
Patch and project coverage have no change.

Comparison is base (0ddf6b8) 83.95% compared to head (c67706b) 83.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   83.95%   83.95%
=======================================
  Files           4        4
  Lines         349      349
=======================================
  Hits          293      293
  Misses         56       56

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ObjectId <-> ID conversion is broken after an update to 0.14.20

  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `async_graphql::base::OutputValueType` is not implemented for `bson::oid::ObjectId`

for
impl RecordType {
    async fn id(&self) -> Option<ObjectId> {
        self.id.clone()
    }
}

and
the trait bound `bson::oid::ObjectId: std::convert::From<async_graphql::scalars::id::ID>` is not satisfied

for
    let id: ObjectId = id.try_into()?;

where id: ID

Can you help me look around here?
https://github.com/async-graphql/async-graphql/blob/215922ee1f4fb8bf1d4d9429bbef55ba69fc3ec5/src/scalars/id.rs#L61

It's strange, because this file has not changed for 12 days, yet the error only popped up in 0.14.20.
I will definitely look into that, but it seems like the problem lies elsewhere, I'm going to try cleanup cache first..

Yeah, I have tried rebuilding the project to exclude any kinds of glitches - the problem only pops up in 1.14.20 and not the 1.14.19.

Yeah, I have tried rebuilding the project to exclude any kinds of glitches - the problem only pops up in 1.14.20 and not the 1.14.19.

Maybe that's the reason. #159

I’ll investigate this next week unless somebody beats me to it.

Maybe if I upgrade the bson package in my project it’d help. Will keep you updated.

That does not help, gotta keep investigating.

Actually it does @sunli829 , I was testing a 1.14.19 and forgot to change it back.
So the version has to be consistent.
The fix is: the bson crate version should be consistent with that in async-graphql.

async-graphql = { version = "1.15.0", features = ["bson"] }
bson = { version = "0.15.0", features = ["u2i"] }

That works just fine!


Internal Server Error

Hello Guys,
I tried acess my product and received Internal Server Error.
When I look the log :
[14/Apr/2022 18:36:21] ERROR [django.request:224] Internal Server Error: /product/21
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
  File "/usr/local/lib/python3.8/site-packages/django/db/backends/mysql/base.py", line 73, in execute
    return self.cursor.execute(query, args)
  File "/usr/local/lib/python3.8/site-packages/MySQLdb/cursors.py", line 206, in execute
    res = self._query(query)
  File "/usr/local/lib/python3.8/site-packages/MySQLdb/cursors.py", line 319, in _query
    db.query(q)
  File "/usr/local/lib/python3.8/site-packages/MySQLdb/connections.py", line 254, in query
    _mysql.connection.query(self, query)
MySQLdb._exceptions.OperationalError: (1054, "Unknown column 'dojo_notifications.template' in 'field list'")

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/app/./dojo/authorization/authorization_decorators.py", line 30, in _wrapped
    return func(request, *args, **kwargs)
  File "/app/./dojo/product/views.py", line 143, in view_product
    instance=Notifications.objects.filter(user=request.user).filter(product=prod).first())
  File "/usr/local/lib/python3.8/site-packages/django/db/models/query.py", line 674, in first
    for obj in (self if self.ordered else self.order_by('pk'))[:1]:
  File "/usr/local/lib/python3.8/site-packages/django/db/models/query.py", line 280, in __iter__
    self._fetch_all()
  File "/usr/local/lib/python3.8/site-packages/django/db/models/query.py", line 1324, in _fetch_all
    self._result_cache = list(self._iterable_class(self))
  File "/usr/local/lib/python3.8/site-packages/django/db/models/query.py", line 51, in __iter__
    results = compiler.execute_sql(chunked_fetch=self.chunked_fetch, chunk_size=self.chunk_size)
  File "/usr/local/lib/python3.8/site-packages/django/db/models/sql/compiler.py", line 1175, in execute_sql
    cursor.execute(sql, params)
  File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 66, in execute
    return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
  File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 75, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
  File "/usr/local/lib/python3.8/site-packages/django/db/utils.py", line 90, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
  File "/usr/local/lib/python3.8/site-packages/django/db/backends/mysql/base.py", line 73, in execute
    return self.cursor.execute(query, args)
  File "/usr/local/lib/python3.8/site-packages/MySQLdb/cursors.py", line 206, in execute
    res = self._query(query)
  File "/usr/local/lib/python3.8/site-packages/MySQLdb/cursors.py", line 319, in _query
    db.query(q)
  File "/usr/local/lib/python3.8/site-packages/MySQLdb/connections.py", line 254, in query
    _mysql.connection.query(self, query)

Deployment method:
Kubernetes
Environment information:
DefectDojo version: 2.9.0
Is there any command I can use to create this Column  ?
_MySQLdb.exceptions.OperationalError: (1054, "Unknown column 'dojo_notifications.template' in 'field list'")

Looks like missing migrations, can you run migrations

$ python manage.py migrate
[14/Apr/2022 20:57:18] INFO [dojo.models:3753] enabling audit logging
Operations to perform:
  Apply all migrations: admin, auditlog, auth, authtoken, contenttypes, django_celery_results, dojo, sessions, sites, social_django, tagging, watson
Running migrations:
  Applying dojo.0150_dedupe_endpoint_status...[14/Apr/2022 20:57:22] WARNING [dojo.db_migrations.0150_dedupe_endpoint_status:23] We identified 10 group(s) of endpoint status which needs to be deduplicated
Traceback (most recent call last):
  File "manage.py", line 11, in <module>
    execute_from_command_line(sys.argv)
  File "/usr/local/lib/python3.8/site-packages/django/core/management/__init__.py", line 419, in execute_from_command_line
    utility.execute()
  File "/usr/local/lib/python3.8/site-packages/django/core/management/__init__.py", line 413, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/local/lib/python3.8/site-packages/django/core/management/base.py", line 354, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/usr/local/lib/python3.8/site-packages/django/core/management/base.py", line 398, in execute
    output = self.handle(*args, **options)
  File "/usr/local/lib/python3.8/site-packages/django/core/management/base.py", line 89, in wrapped
    res = handle_func(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/django/core/management/commands/migrate.py", line 244, in handle
    post_migrate_state = executor.migrate(
  File "/usr/local/lib/python3.8/site-packages/django/db/migrations/executor.py", line 117, in migrate
    state = self._migrate_all_forwards(state, plan, full_plan, fake=fake, fake_initial=fake_initial)
  File "/usr/local/lib/python3.8/site-packages/django/db/migrations/executor.py", line 147, in _migrate_all_forwards
    state = self.apply_migration(state, migration, fake=fake, fake_initial=fake_initial)
  File "/usr/local/lib/python3.8/site-packages/django/db/migrations/executor.py", line 227, in apply_migration
    state = migration.apply(state, schema_editor)
  File "/usr/local/lib/python3.8/site-packages/django/db/migrations/migration.py", line 123, in apply
    operation.database_forwards(self.app_label, schema_editor, old_state, project_state)
  File "/usr/local/lib/python3.8/site-packages/django/db/migrations/operations/special.py", line 190, in database_forwards
    self.code(from_state.apps, schema_editor)
  File "/app/dojo/db_migrations/0150_dedupe_endpoint_status.py", line 28, in dedupe_endpoint_status
    finding = Finding.objects.get(id=eps_group.get('finding'))
  File "/usr/local/lib/python3.8/site-packages/django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/django/db/models/query.py", line 435, in get
    raise self.model.DoesNotExist(
__fake__.DoesNotExist: Finding matching query does not exist.

Now, How can i identified this ?
We identified 10 group(s) of endpoint status which needs to be deduplicated
I tried:
$ python manage.py dedupe
but doesn't work.

@kiblik do you know workaround for this?

This bug was fixed in https://github.com/DefectDojo/django-DefectDojo/pull/6136 and I hope will be released soon as part of 2.9.1
If you need it ASAP, apply changes in file dojo/db_migrations/0150_dedupe_endpoint_status.py from https://github.com/DefectDojo/django-DefectDojo/pull/6136/files should be enough

I have same problem

I have same prob, modified the 0150, data migration completed, still getting 500 error when trying to access the product.

Fixed in 2.9.1


Download the graph of lightweight-charts

Is there a way to download the graph by clicking on a button in order to share the stock movement?

<script>
  import { Chart, LineSeries } from 'svelte-lightweight-charts';

  let chart;
  let data = [
    { time: '2019-04-11', value: 75 },
    { time: '2019-04-12', value: 85 },
    { time: '2019-04-13', value: 90 },
    { time: '2019-04-14', value: 80 },
    { time: '2019-04-15', value: 70 },
  ];

  function downloadScreenshot() {
    const canvas = chart.takeScreenshot();
    const link = document.createElement('a');
    link.download = 'chart-screenshot.png';
    link.href = canvas.toDataURL('image/png');
    link.click();
  }
</script>

<Chart width={600} height={400} ref={ref => chart = ref}>
    <LineSeries data={data} />
</Chart>
<button on:click={downloadScreenshot}>Download Screenshot</button>

This does not work in REPL. I do not know why. Perhaps downloading in REPL iframe is prohibited. It works locally.