Can't add Bitcoin address

Brief Description:  Can't save Bitcoin address under settings -> general.
Operating System (OS and version):  Windows 7 Pro 74 bit
OpenBazaar version (shown on About OpenBazaar page in menu): 1.0.6
Hardware: PC
Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce):
Always
Steps to reproduce:

Go to "Settings"
Under "General" enter a valid Bitcoin address
Click "Save Changes"

Observed Behavior:
Error message "Data could not be saved"
Expected Behavior:
Save changed data with Bitcoin address
Additional info (links, images, etc go here):
I'm able to save settings after emptying the Bitcoin address field again.

@sabotrax did you use a testnet address when you tried this?
We are currently on the testnet, and only testnet bitcoin addresses are usable.

@sabotrax need to use a testnet address. Let me know if you need some testnet coins.


Alluxio CLI doesn't show right mount info (readonly/shared)

Alluxio Version:
Tested in both branch-2.1 and master branch
Describe the bug
CLI doesn't show right mount info (readonly/shared)
Start alluxio with
alluxio.master.mount.table.root.ufs=${alluxio.work.dir}/underFSStorage
alluxio.master.mount.table.root.readonly=true
alluxio.master.mount.table.root.shared=true

but mount info shows not read-only and not shared
$ ./bin/alluxio fs mount
/Users/alluxio/alluxioFolder/alluxio/underFSStorage  on  /  (local, capacity=465.72GB, used=-1B(0%), not read-only, not shared, properties={})
$ ./bin/alluxio fsadmin report ufs
Alluxio under storage system information:
/Users/alluxio/alluxioFolder/alluxio/underFSStorage  on  /  (local, capacity=465.72GB, used=-1B(0%), not read-only, not shared, properties={})

Try to delete file but find the mount point should be read-only
$ ./bin/alluxio fs rm /LICENSE
Failed to delete /LICENSE (Operation WRITE not allowed on ufs path /Users/alluxio/alluxioFolder/alluxio/underFSStorage/LICENSE under maintenance mode READ_ONLY) from the under file system

To Reproduce
Steps to reproduce the behavior (as minimally and precisely as possible)
Expected behavior
Mount should show read-only in my case
Urgency
Describe the impact and urgency of the bug.
Additional context
Add any other context about the problem here.

@LuQQiu Actually when creating the root mount as readonly and shared, I don't think it really takes effect. For example I started Alluxio with readonly root mount using your config properties, and then I can put files in the root mount.
$bin/alluxio fs copyFromLocal ./LICENSE /LICENSE
Copied file:///Users/jiachengliu/Documents/Alluxio/alluxio-jiacheng/alluxio/LICENSE to /LICENSE

Do you know if readonly works at all?

Confirmed that readonly doesn't work for root mount but seems to work for nested mount. See different behavior below.
$ ./bin/alluxio fs mount --shared --readonly /readonly_folder /Users/jiachengliu/Documents/Alluxio/alluxio-jiacheng/alluxio/readonly
Mounted /Users/jiachengliu/Documents/Alluxio/alluxio-jiacheng/alluxio/readonly at /readonly_folder
$ bin/alluxio fs mount
File system class class alluxio.client.file.BaseFileSystem
/Users/jiachengliu/Documents/Alluxio/alluxio-jiacheng/alluxio/readonly        on  /readonly_folder  (local, capacity=420.03GB, used=-1B(0%), read-only, shared, properties={})
/Users/jiachengliu/Documents/Alluxio/alluxio-jiacheng/alluxio/underFSStorage  on  /                 (local, capacity=420.03GB, used=-1B(0%), not read-only, not shared, properties={})
$ bin/alluxio fs touch /readonly_folder/aaaaa
A write operation on /readonly_folder/aaaaa under a readonly mount point /readonly_folder is not allowed

Please update the title of this issue.

Readonly attribute is fixed by https://github.com/Alluxio/alluxio/pull/10895
Shared attribute problem is more tricky and logged in https://github.com/Alluxio/alluxio/issues/10896
Closing this issue as we can keep track on #10896


Make the download requirement clearer

It surprises me just how often people struggle with hitting  the import screen and not having installed RtL/MoM think it is broken.
What is the best way to make this requirement clear?

When the game executes try to find the REGEDIT register where you locate the installed Apps for importing. If you cant find it, replace the Import button with a "Valkiries Requires Steam App...."

Yeah it does that check already, but just says import unavailable.
The more I think on this the more I want to solve it with this:
https://github.com/NPBruce/valkyrie/issues/13

Done with this for now.


[FEAT]: Support for one file linking (using header)

Hello!
Your plugin is great. I needed just a way to handle contact on a single file instead of directory.
I added support for this behavior:

You can use a single files or multiples singles files to get contact, instead of one file per contact.
If a contact doesn't exists, you can create a new header in the selected files (the suggester will show all registered files if multiple exists)
You can restrict by the heading level (0=use all header)
Using this disable the folder directories option

Internally:

Updated and fixed the two eslint config. My major issue was VScode struggle a lot to found the new configuration (flat config), so I updated the old config with the option set in the new.
I fixed a typo in the new config about ts-comment
I passed app in some function where needed, as using the global app instance is deprecated and should be avoided (see).
I passed some //@ts-ignore where needed
I adjusted the suggestion popup when needing to create new files instead of set the "create a new file" in the name.

Your code is pretty well rediged, and it was easy to understand things! Also, THANK YOU for the eslint config, as a lot of people forget it and it create big mistakes with the diff view.

Hi @Mara-Li there are quite a few out of scope changes to this branch that step well beyond a contribution.
I imagine at one point this was a smaller contribution, but you expanded it on the main branch?
Is there a certain commit where I could "cut off" the changes so to speak?


Update flash, reduce markup and alignment improved

Flash message content are misaligned, and there is extraneous markup.
Replace check icon with exclamation icon for :error flash.
Removes the solid attribute on the calls to <.icon> (as that doesn't appear to be implemented on the component).
This commit improves alignment, slightly tweaks the icon sizes (subjective), matches colors, and uses what I believe to be more idiomatic Tailwind.

Before

After

beautiful. Thanks!

❤❤❤🐥🔥


Publish-BCContainerApp on environment fails after upgrade to BC24

PLEASE DO NOT INCLUDE ANY PASSWORDS OR TOKENS IN YOUR ISSUE!!!
Describe the issue
Yesterday we upgraded our test environment to BC24. We have setup a pipeline in devops that uses Publish-BCContainerApp to update the environment with our latest apps from our build pipelines.

Scripts used to create container and cause the issue
# Create temporary directory
$TempDirectoryName = [System.IO.Path]::Combine($env:TEMP, [guid]::NewGuid().ToString('N'))
New-Item -ItemType Directory -Path $TempDirectoryName -Force | Out-Null

Write-Host "The following Apps will be published:"
(Get-ChildItem -Path $AppFolder -Filter '*.app' -Recurse) | % {
    Write-Host "$($_.Name) (found in directory '$($_.Directory)')"
    Copy-Item -Path $_.FullName -Destination $TempDirectoryName
}

Write-Host "Installing Apps"
Publish-BcContainerApp `
    -bcAuthContext $AuthContext `
    -environment $Environment `
    -appFile $TempDirectoryName `
    -dependencyPublishingOption default `
    -syncMode ForceSync

# Remove temporary directory
Remove-Item $TempDirectoryName -Recurse

Full output of scripts
See above
Screenshots
N/A
Additional context
BCContainerHelper fails when executing the API call to BC:

When I inspect the environment after the error, I notice the app is published but not installed. So it appears the install fails. I also noticed it takes a while for the published app the show up in extension management. It seems there's a delay that might cause this error.
On BC23 the update of our test environment was already quite slow (we have 27 apps to publish) but It worked. The environment has quite some companies.

Does the extension management page reveal what the problem is?

Does the extension management page reveal what the problem is?

No, nothing is displayed. It takes a while for the published extension to show up and when it does I can install it manually without a problem.
I'm currently updating a copy of our test environment (still on bc23) and it works perfectly fine there.

are you using s2s or impersonation for deployment?

Looks like impersonation (dev scope) - right?

Looks like impersonation (dev scope) - right?

Jep.
Here's the full script:
[CmdletBinding()]
param (
    [Parameter(Mandatory = $true)]
    [string]$AppFolder,
    [Parameter(Mandatory = $true)]
    [string]$Environment,
    [Parameter(Mandatory = $true)]
    [string]$RefreshToken,
    [Parameter(Mandatory = $false)]
    [array]$PublishedApps,
    [Parameter(Mandatory = $false)]
    [Switch]$PublishTestApps = $false
)

if (!(Get-Module -ListAvailable -Name 'BcContainerHelper')) { Install-Module BcContainerHelper -Force }
Import-Module BCContainerHelper

Write-Host "Sorting Apps"
$AppsToInstall = Sort-AppFilesByDependencies -appFiles ((Get-ChildItem -Path $AppFolder -Filter '*.app' -Recurse).FullName)

Write-Host "Retrieving Authentication Context"
$AuthContext = New-BcAuthContext -refreshToken $RefreshToken

foreach ($App in $AppsToInstall) {
    $AppFileNameSplitted = [System.IO.Path]::GetFileName($App).Split("_")
    $Publisher = $AppFileNameSplitted[0]
    $Name = $AppFileNameSplitted[1]
    $Version = $AppFileNameSplitted[2]

    if ((-not $PublishTestApps) -and ($Name -like "*-test*")) { continue }

    $PublishedApp = $PublishedApps | Where-Object { ($_.publisher -eq $Publisher) -and ($_.displayName -eq $Name) }
    if ($null -ne $PublishedApp) {
        $PublishedAppVersion = "$($PublishedApp.versionMajor).$($PublishedApp.versionMinor).$($PublishedApp.versionBuild).$($PublishedApp.versionRevision)"
        if ($Version -eq $PublishedAppVersion) {
            Write-Host "App $Name with version $Version for publisher $Publisher already installed" -ForegroundColor Yellow
            Remove-Item -Path $App
        }
    }
}

$bcContainerHelperConfig.NoOfSecondsToSleepAfterPublishBcContainerApp = 5

# Create temporary directory
$TempDirectoryName = [System.IO.Path]::Combine($env:TEMP, [guid]::NewGuid().ToString('N'))
New-Item -ItemType Directory -Path $TempDirectoryName -Force | Out-Null

Write-Host "The following Apps will be published:"
(Get-ChildItem -Path $AppFolder -Filter '*.app' -Recurse) | % {
    Write-Host "$($_.Name) (found in directory '$($_.Directory)')"
    Copy-Item -Path $_.FullName -Destination $TempDirectoryName
}

Write-Host "Installing Apps"
Publish-BcContainerApp `
    -bcAuthContext $AuthContext `
    -environment $Environment `
    -appFile $TempDirectoryName `
    -dependencyPublishingOption default `
    -syncMode ForceSync

# Remove temporary directory
Remove-Item $TempDirectoryName -Recurse

Could you try this:
Replace-DependenciesInAppFile -Path $appFile -replacePackageId

before publishing the app?

Replace-DependenciesInAppFile -Path $appFile -replacePackageId

I'm afraid this doesn't help.
WARNING: The names of some imported commands from the module 'BCContainerHelper' include unapproved verbs that might make them less discoverable. To find the commands with unapproved verbs, run the Import-Module command again with the Verbose parameter. For a list of approved verbs, type Get-Verb.
Attempting authentication to https://api.businesscentral.dynamics.com/user_impersonation offline_access using refresh token...
Authenticated using refresh token as user ...
Authenticated to common, using tenant id ...
Replacing Package ID with new GUID
Replacing Package ID with new GUID
Replacing Package ID with new GUID
Publishing Dynavision_Dynavision Advanced Finance_<IP_ADDRESS>55_sandbox_23.1_w1.app to https://api.businesscentral.dynamics.com/v2.0/DynavisionDEV/dev/apps?SchemaUpdateMode=forcesync&DependencyPublishingOption=default
Status Code 422 : Unprocessable Entity
Er is geen gepubliceerde extensie die overeenkomt met de opgegeven parameterwaarden.

At C:\Program Files\WindowsPowerShell\Modules\BCContainerHelper\6.0.15\AppHandling\Publish-NavContainerApp.ps1:295 char:25
+                         throw $message
+                         ~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Status Code 422...meterwaarden.

After the error above was thrown I checked the environment and the app was published but not installed:

It took over a minute for the app to show op in extension management. So it really looks like for some reason the publish has not completed yet when the app is installed.

I have a repro of this - will investigate why this happens.

I have a repro of this - will investigate why this happens.

Thx! In the meantime we've restored our environment to BC23. We still have a copy of the BC24 environment for investigating the issue.

https://github.com/microsoft/AL/issues/7721


Make streams publishable to NPM

Fixes #1629
Had to guess at a name, stream is already taken. Something cooler is probably preferable!

ru means "tiny riverlet" in old French, and it is concise, but sadly squatted (registered 3 years ago, the package is empty at v0.0.0)... by a cofounder of surge.sh. I suppose he has enough on his plate and may release the name if we ask kindly...

I can ping him, but it'll be a day or two. @lhorie is that something you'd want to tackle?

I can also do it. I didn't want to bother him before gathering support here.

@pygy probably best if it gets transferred to @lhorie

Off course!

BTW @lhorie I'd rather have your opinion on the name before (a thumb up/down will do) I attempt to contact the ru package holder

In my mind, it'd be called mithril-stream (mostly because of the folder structure). To be honest, ru kinda reminds me of the winnie the pooh character.

I hadn't thought of the fact that the french sound for "u" (hit the 🔊 icon to hear it contrasted to other French sounds) doesn't exist in English...
"U" has the same pronounciation in French and Dutch (and the sound exists in German and Turkish as "ü"), but folks from other country would indeed hear it as "roo"... Not what I had in mind either...

@pygy FWIW other cool stream libraries have this problem too — Flyd's Danish 'y' has the same issue ;)

Oooh, I had forgotten about the Danish "y" (and I didn't know that flyd was Danish). Flugh... Danish is a weird language when it comes to mapping written words to sounds (though French and English have their lot of surprises as well).

Now that the PR has been merged, has it been published on npm ?
Because I don't see it when I search for mithril-stream on npm.

@oligot I just published it: https://www.npmjs.com/package/mithril-stream
Cheers!

Thanks !


V4 fast iavl

What is the purpose of the change
@faddat 's work to get the fast IAVL patch onto v4!

LGTM aside from my one comment, and tests failing

Hey, just saw this, let me have a go at the tests tomorrow :)

Gentle bump

@ValarDragon hey, so I decided it likely made more sense to not put more time into fixing the liveness test and walking through the layers of "why doesn't rbuilder work?" -- if you'd prefer that we do, please just let us know.
I think that this is set now.

My 2 cents is this is still really slow. We are working with crypto.com to have something much faster which puts no requirement on iavl

Ohhh, what is that, can you show me


@manipulate sometimes doesn't create the Comm link successfully

I have a notebook with one cell:
using Interact
using PlotlyJS

and another:
p = plot(scatter())

@manipulate for phase=0.0:0.01:2pi
    e = sin(linspace(0.0, 2pi, 50)+phase)
    restyle!(p, y=[e])
end

p

I think in the past this used to work, but right now when I run both cells the first time, the sliders don't update the plot. After I refresh the page and re-run the 2nd cell, I get a bunch of this error in the javascript console:
comm.js:127 Comm promise not found for comm id 6837a751-a367-4e5f-a482-828a1d607712

If I use display(p) before @manipulate (instead of returning p from the cell) it seems to work.
In talking to @spencerlyon2 one theory is that it's trying to create a Comm link before the plot has been rendered. I think it's OK if this isn't supported and the user should always display the plot first, but if possible @manipulate should throw an error telling the user that it couldn't talk to the plot, and maybe guiding them to display it first.

Try this in the second cell:
p = plot(scatter())

@manipulate for phase=0.0:0.01:2pi
    e = sin(linspace(0.0, 2pi, 50)+phase)
    restyle!(p, y=[e])
    p
end

Basically, the @manipulate block returns a signal whose value is the last thing in the block.
If the @manipulate is the last thing in the cell, i.e. the result of the cell, then IJulia displays it by default. The restyle! apparently returns nothing, so having that at the end of the @manipulate block creates a signal with value nothing.
Changing the @manipulate block as above makes it return a signal whose value is the plot. IJulia displays this plot (signal) and Interact then ensures the display of that plot (signal) is updated as the slider/plot (signal) value is changed.

Sorry, I didn't realise PlotlyJS handles its own comms and syncing. I assumed it was relying on Interact for that. My code above (where Interact basically outputs an entirely new plot each time the slider is changed) does actually work both before and after refresh, but it's less smooth than when you use PlotlyJS's own sync. In any case, this warrants further investigation.
There seem to be two possibly related issues here:

When using @manipulate the plot doesn't update when p is the result of the cell (it seems to work when display is called before or after the @manipulate).

N.b. Re-running the cell in your code with the p at the end, works the second time.
Also, having the @manipulate call in the cell after also works, like so:
Cell 2:
p = plot(scatter())

Cell 3:
@manipulate for phase=0.0:0.01:2pi
    e = sin(linspace(0.0, 2pi, 50)+phase)
    restyle!(p, y=[e])
end

Curiously, this also works:
p = plot(scatter())
phase_slider = slider(0:0.01:2pi)
restyle_it! = map(signal(phase_slider)) do phase
    e = sin(linspace(0.0, 2pi, 50)+phase)
    restyle!(p, y=[e])
end
display(phase_slider)
p

PlotlyJS's sync on refresh doesn't work (there is Comm promise ... comm id) error, regardless of whether you use display or p is the result of the cell.

Seems to me they're both more likely to be bugs in PlotlyJS than in Interact, since @manipulate is only modifying p and is not involved in sending the comms to sync the plot in the cases that don't work.
HTH, sorry again for the earlier misunderstanding.

One other thing, this is basically what the @manipulate expands to:
p = plot(scatter())
let phase_slider = slider(0:0.01:2pi)
    display(phase_slider)
    restyle_it! = map(signal(phase_slider)) do phase
        e = sin(linspace(0.0, 2pi, 50)+phase)
        restyle!(p, y=[e])
    end
end
p

It doesn't work, but without the let, it does.
Also, similar story for this (doesn't work with let, does without):
p = plot(scatter())
restylein(n) = begin
    sleep(n)
    restyle!(p, y=[e])
    println("done")
end

let
    e = sin(linspace(0.0, 2pi, 50))
    @schedule restylein(1)
end
p

How is let affecting the restyle! call?

Thought about issue 1) some more, and (ignoring the @schedule stuff for now) it seems that issue is with Interact after all. I think what's happening is that the signal/map created by your manipulate block is being garbage collected, so it doesn't run later. This is because, unlike the usual case, it's not connected to any other (e.g. downstream) signals - since you're only running it for its side effect (the call to restyle!) and the output isn't displayed  - so no Nodes/Signals have references to it. Search for preserve on this page. This is why the let block makes a difference, because without it, there's a reference to the signal created by @manipulate in global scope and it doesn't get GC'd.
There are lots of ways to work around this issue, you could

call preserve on the whole manipulate block: preserve(@manipulate ... end) (ugly)

hold a reference to the signal returned by manipulate: hold = @manipulate ... end (best use a different name for each manipulate block if you don't want the earlier ones to die)

maybe the neatest solution (not tested much) is to redefine @manipulate like so:
macro manipulate(expr)
<EMAIL_ADDRESS>$expr)) |> esc
end

Having said that I think there's a strong argument to be made to make @manipulate preserve its signal by default, if only because @manipulate effectively hides the complexity of doing the great stuff Interact allows so well, so we might as well continue to try do that.
@manipulate is, I assume, many new users first exposure to Interact/Reactive and IMO it's best to make it as painless as possible for those people, even if they may possibly run into memory usage issues (which I guess prob could be handled with a note in the docs).

Hey @JobJob that makes more sense to me.
I believe the issues @ssfrr talked about were with Comms whose id was a UUID4. The Comm I'm using in PlotlyJS.jl is named :plotlyjs_eval.
What I've always done that seems to make it work is:
p = plot(...)
display(p)

@manipulate for ...
end

The key is to display the plot after making it, but before the @manipulate block.
I've never had an issue that way -- not sure if that fits in well with your diagnosis or not.

Yeah, I think the reason that's working is only because the @manipulate happens to be at the end of the cell, so the Signal it creates gets displayed as the result of the cell.  When Interactdisplays a Signal, it creates a new "downstream" Signal to handle syncing of values to the front-end. This downstream signal then holds a reference to the Signal created by @manipulate so it doesn't get GC'd.
Try this:
p = plot(...)
display(p)

@manipulate for ...
end

gc() #even without this it doesn't work for me, but included just to be sure
nothing

Also, I've realised that some other things I thought were working earlier mentioned above, either don't work every time, or break when you call gc() afterward, namely, running the cell twice, and putting the display(p) after the @manipulate.
So yeah, seems that GC is the problem here with issue 1.
I think the issue with the comms on refresh is to do with the global Comm manager in PlotlyJS. The bug happens if you refresh the page after using PlotlyJS and before calling display. Seems Interact sets up a new Comm manager for each Signal it displays see here. I'm a little vague on the details but when the page is refreshed, the front end seems to lose the reference to the _ijulia_eval_comm.id. Maybe you need to create a new Comm manager on each call to display a SyncPlot? Ok, looked into it, and submitted a PR to PlotlyJS which seems to fix this, not sure it's the best way to do it, but it works: https://github.com/spencerlyon2/PlotlyJS.jl/pull/91

Thanks or the PR!
I'm not totally sure I understand how that PR is different in practice than what I had.
It seems to me that what I had created one Comm when the julia code using PlotlyJS or PlotlyJS.init_notebook(true) is run.
I believe that what is in that PR creates a Comm whenever the Julia code plot(...) or JupyterPlot(...) is run.
Either way, the Comm is only created after the user asks the Julia kernel to execute some code.
Does interact on its own (i.e. just interacting with a julia expression) work between page refreshes?
I would think that the behavior or "pure" Interact.jl Comms or the PlotlyJS.jl Comm(s) should be identical and described by: whenever the gc runs to clear out Julia-side Comms kept in the kernel -- e.g. maybe (? not sure) on page refresh -- the user needs to re-execute the code that created the Comm.

Firstly, just to clarify, the use case that the (new and old) PRs fix is:
using Interact, PlotlyJS
Then run
p = plot(...)
display(p)

@manipulate for ...
end

refresh page, then run cell again.
Previous behaviour: Doesn't work, JS console displays: Comm promise not found for comm id
New behaviour: works fine
This issue is not related to issue 1) above and GC. It is simply caused by the fact that on page refresh the Jupyter front end clears all registered comms, so the _ijulia_eval_comm held by PlotlyJS becomes stale.
The original PR was slightly more complicated because I had an error in the test case I was using. I thought just updating the global Comm on each call to JupiterDisplay wasn't working with multiple plots, so I made it more like the Interact code in that Interact stores a mapping between Signals (equivalent of a plot)->Comms, but in fact this wasn't necessary in the end because of the way PlotlyJS uses the plot's divid.
Anyway, have made a new PR, much simpler. It just creates a new global Comm every time JupiterDisplay is called, this stops the old comm reference from being stale on page refresh.

I'm glad you have seemed to figured out a fix.
FWIW I can't reproduce Spencer's initial failure on Jupyter 4.2.3 + latest Interact

does this work for you when you move the slider?:
p = plot(scatter())

@manipulate for phase=0.0:0.01:2pi
    e = sin(linspace(0.0, 2pi, 50)+phase)
    restyle!(p, y=[e])
end
gc()
p

Yes, just fine.

Even with the gc()?
Does it work for you @spencerlyon2 ? I'm also on Jupyter 4.2.3 and Interact master with Julia 0.5.0. I was pretty sure that the signal created by the @manipulate would have no references to it and get GC'd, but maybe I'm missing something?

your guess should be correct. I did copy-paste the same code you posted and it works...

It works, and the plot updates when you move the slider?

yes

wow, ok... confusing

julia 0.5.0 ?

Eek, wait. I'm so sorry I was trying it without gc. With gc(), sure enough it doesn't work.

whew :)

@shashi How do you feel about changing @manipulate to either:

use preserve (or foreach instead of map if it works)?
adding the manipulate created signals to a vector that you could clear with say Interact.freemanipulates() or something

That way people using @manipulate for side effects won't run into the OP's problem.

So, I think it's reasonable to make @manipulate call preserve on its output by default. Because

I agree that it is not easy to think of GC when there's a problem like this
Since @manipulate blocks are usually self-contained, they will get gc'd once all the inputs go out of scope anyway

Only problematic situation is when you have something like
ticks = fps(60)

in one cell
@manipulate for t=ticks, x=1:100
    ...
end

in another. As opposed to
@manipulate for t=fps(60), x=1:100
    ...
end

But this is almost never used

Right, you're saying that won't get gc'd because of the reference to ticks being held. Yeah I agree that's probably not a major problem, people who are doing that are more likely to make their own signal chain without using manipulate, I would think.


Please add a license

Wow, you've done a ton of work on this project. Thank you!
I was about to share it with my network then noticed that there is no license file. Without that the project is automatically "All Rights Reserved" and no one can legally use it.
Could you please add some sort of (preferably open source) license to the project? I'm happy to help, if you'd like.

There is a MIT license file in the repo. Does this suffice?

You are totally right and I am totally wrong for having missed that. Thanks for the correction!


Is there any way to create custom template for each node?

I am planning to deploy new version and this will be included 2 weeks later I will be planning to deploy new version

I work on v2.0 and I will try to implement this one but not short term


修复针对pytorch1.3.0版本bug的一个bug

Description：简要描述这次PR的内容
Main reason: 做出这次修改的原因
Checklist  检查下面各项是否完成
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [$CATEGORY] (例如[bugfix]修复bug，[new]添加新功能，[test]修改测试，[rm]删除旧代码)
[ ] Changes are complete (i.e. I finished coding on this PR)  修改完成才提PR
[ ] All changes have test coverage  修改的部分顺利通过测试。对于fastnlp/fastnlp/的修改，测试代码必须提供在fastnlp/test/。
[ ] Code is well-documented  注释写好，API文档会从注释中抽取
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change  修改导致例子或tutorial有变化，请找核心开发人员

Changes: 逐项描述修改的内容
Mention: 找人review你的PR
@修改过这个文件的人
@核心开发人员

Codecov Report

Merging #246 into master will not change coverage.
The diff coverage is 81.81%.

@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   77.23%   77.23%
=======================================
  Files          84       84
  Lines       10128    10128
=======================================
  Hits         7822     7822
  Misses       2306     2306

Impacted Files
Coverage Δ

fastNLP/modules/decoder/utils.py
8.33% <0%> (ø)
:arrow_up:

fastNLP/core/losses.py
83.15% <100%> (ø)
:arrow_up:

fastNLP/modules/encoder/star_transformer.py
98.85% <100%> (ø)
:arrow_up:

fastNLP/models/snli.py
91.57% <100%> (ø)
:arrow_up:

fastNLP/models/biaffine_parser.py
96.07% <100%> (ø)
:arrow_up:

fastNLP/core/metrics.py
81.8% <100%> (ø)
:arrow_up:

fastNLP/modules/encoder/transformer.py
94.59% <100%> (ø)
:arrow_up:

fastNLP/modules/decoder/crf.py
83.79% <100%> (ø)
:arrow_up:

fastNLP/embeddings/char_embedding.py
82.35% <33.33%> (ø)
:arrow_up:

fastNLP/embeddings/bert_embedding.py
78.09% <66.66%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3761c32...6cb3713. Read the comment docs.


crypto/x509: check that private key matches the issuer

I have checked several examples and couldn't find out why my client certificate was invalid, until @FiloSottile pointed out that I'm trying to sign the cert with its own key.
A check is possible as we pass the public key.
https://github.com/golang/go/blob/c3b9042132efc4e9f3485cd12b07acd1ca9c7d57/src/crypto/x509/x509.go#L2084
Behaviour: after successful creation of certificate on connection checks fail with "x509: ECDSA verification failure"
Expected behaviour: CreateCertificate would return an error stating signing with own key will not be a successful tactic.

@FiloSottile shall we move this perhaps to the Go1.16 milestone or are thinking of more work on this during Go1.15? Thank you!

Yep, definitely slipped to Go 1.16.

Moving this to Go1.17, as we didn’t get action for Go1.16.


Some more Pathlib additions

Translated some os lines into the better looking pathlib notation:
https://docs.python.org/3/library/pathlib.html#correspondence-to-tools-in-the-os-module

Does this fix/is related to #485 ?

@kolibril13 this is ready for merge, but unfortunately there are now conflicts. I can't solve the conflicts for you as they come from your fork. If you have any doubts, please let me know (as this has to do with the config system)

@leotrs : Ok, thank you!
Tomorrow, I will test if the script still does what it should do with the new config system, and if it is so, then I will merge it.

What happened here?

This file graphical_units.py so there was a merge conflict.
Further, I guess that https://github.com/ManimCommunity/manim/pull/640 will also probably change the behaviour of graphical_units.py, so I thought it might be better to wait with this pr.


querying-over-self-references

Please use the form below, leaving the prefilled data to help us. Thank you.
Page link: querying-over-self-references
Document link: query-over.md
My Issue/Suggestion
If I compare this to
https://academy.mendix.com/link/modules/373/lectures/3037/6.3.1-Querying-Players-(Children)-from-a-Buddy-(Parent)
then I would name the association "SubFolder_Folder" or "SubFolder_ParentFolder". Unless I understood the concept wrong.

Hi Alex,
Thanks for bringing this to our attention.
In the end, the naming of associations, and the direction you choose, is entirely up to you - as long as you are clear about what the association represents.
I agree that the two examples are named the opposite way around In the academy course the query [SoccerSquad.Apprentice_Buddy = '[%CurrentObject%]'] returns all the Apprentices who are associated with a Buddy. I would therefore argue that it is more justified to call this relationship Buddy_Apprentice as, when queried this way around, it is defining the relationship between the Buddy and the Apprentice.
The convention used in the Querying Over Self-References document - is that when you use the query the right way around it returns all the SubFolders (the second part of the association) associated with the Folder (the first part of the association) and so the relationship is named Folder_SubFolder. When you used the reversed() expression it turns the association around and you match on the subfolder it is SubFolder->Folder.
I will discuss this with Academy and see whether we can agree on the naming here. It is obviously a complex area where it would be nice to have things as simple as possible.
I hope this helps to explain the difference. As always, you can rename associations in your apps to match the way you think about them.
Yours
Mark van Ments.

Dear Mark,
No problem at all. I understand that most of it are recommendations and
best practices and they can be changed/adapted based on the real use
case and context, with the main goal to make it easier for another
developer (or myself) to understand what that association is.
However, I found that it somehow makes sense for associations which are
owned by one side to start with the name of the owning side.
Also Mendix Studio Pro seems to make that by default. If I would have 2
separate entities apprentice and buddy or sub-folder and folder and
would connect from the many to the 1 then Mendix Studio Pro would name
the entities automatically Apprentice_Buddy and SubFolder_Folder. That
is the main reason why I would apply the same naming patterns also for
the self-reference if folder and sub-folder are the same entity.
Nevermind, I am preparing for the Advanced Developer Certificate and
thought if you guys spent so much time preparing so good documentation
and courses then if I see something which might need your review then I
will shortly point it out.
So all good here :-)
Cheers,
Photo https://www.linkedin.com/in/lechalexandermurawski 	Alex Murawski
CEO & Founder
+86 186 1710 1085 <tel:+86 186 1710 1085>
@.*** 	Reviews https://g.page/noa-labs-ltd?gm
www.noa-labs.com https://www.noa-labs.com/
On 2023-05-30 22:56, Mark van Ments wrote:

Hi Alex,
Thanks for bringing this to our attention.
In the end, the naming of associations, and the direction you choose,
is entirely up to you - as long as you are clear about what the
association represents.
I agree that the two examples are named the opposite way around In the
academy course the query |[SoccerSquad.Apprentice_Buddy =
'[%CurrentObject%]']| returns all the |Apprentices| who are associated
with a |Buddy|. I would therefore argue that it is more justified to
call this relationship |Buddy_Apprentice| as, when queried this way
around, it is defining the relationship between the |Buddy| and the
|Apprentice|.
The convention used in the Querying Over Self-References
https://docs.mendix.com/refguide/query-over/ document - is that when
you use the query the right way around it returns all the |SubFolders|
(the second part of the association) associated with the |Folder| (the
first part of the association) and so the relationship is named
|Folder_SubFolder|. When you used the |reversed()| expression it turns
the association around and you match on the subfolder it is
|SubFolder|->|Folder|.
I will discuss this with Academy and see whether we can agree on the
naming here. It is obviously a complex area where it would be nice to
have things as simple as possible.
I hope this helps to explain the difference. As always, you can rename
associations in your apps to match the way you think about them.
Yours
Mark van Ments.
—
Reply to this email directly, view it on GitHub
https://github.com/mendix/docs/issues/6102#issuecomment-1568586929,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFEHME4GYOUROMKLK4XVHB3XIYDA7ANCNFSM6AAAAAAYSWVCGY.
You are receiving this because you authored the thread.Message ID:
@.***>

Dear Mark,
You are very welcome. And just to clarify it: in the screenshot or
example I mentioned in my last email I just used drag-and-drop from the
one entity to the other entity. Which creates automatically a *-1
association from the first to the second entity. And automatically a
name with the FirstName_SecondName.
Which in most cases actually makes even sense. Though I fully agree with
you that in certain cases the developer should adjust those
automatically generated association names where it helps to make the
meaning of that association easier or more clear to understand.
In any case: Good luck updating and creating new content! As it helps
new and old Mendix developers a lot to learn general and Mendix specific
topics to accelerate building no-code/low-code Apps :-)
Regards,
Photo https://www.linkedin.com/in/lechalexandermurawski 	Alex Murawski
CEO & Founder
+86 186 1710 1085 <tel:+86 186 1710 1085>
@.*** 	Reviews https://g.page/noa-labs-ltd?gm
www.noa-labs.com https://www.noa-labs.com/
On 2023-05-31 15:01, Mark van Ments wrote:

Thanks for your detailed response, Alex.
I now understand a bit more where the naming is coming from and, I
agree, the default naming would be better to follow in the
documentation. I wasn't aware that the "child/owner" is the default to
have first in Mendix naming - it is something I should have been aware of.
I'll reopen this issue and look at the document and let you know when
I've made the changes.
Thanks again for taking the time to explain the issue and point out
the confusion in the documentation.
—
Reply to this email directly, view it on GitHub
https://github.com/mendix/docs/issues/6102#issuecomment-1569605353,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFEHME27UZB7NNGCIMRUUULXI3UDNANCNFSM6AAAAAAYSWVCGY.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi @NOA-Alex
I've updated the text and diagrams in pull request #6172 .
I'll merge it now and it should be published later today.
Thanks again for pointing out this mistake and taking the time to explain it.
Please do let us know if you spot anything else which is wrong or could be improved.
Yours
Mark van Ments.

Issue addressed.

Dear @MarkvanMents,
You are the best!
Thanks for maintaining and updating the very good Mendix documentation. Which makes it easier for developers to build useful and beautiful web and smartphone apps.
Regards,
Alex


[Large Tensor] linalg ops fail w/input dim >= 2**32

Description
While testing the linalg_* ops on large tensor (dimension >= 2**32) data, I found that all of these ops fail with a segmentation fault on large tensor data. In a test run with the linalg_det op, I traced the error to line 485 of src/operator/tensor/la_op-inl.h. This line lies within the Map void function which takes in several parameters, namely an int i, an int N, and an int* pivot. The error is thrown in the iteration portion of the function, where an int j is incremented up to the value of int N.
This error occurred irrespective of which BLAS engine MXNet was built with (MKL or OpenBLAS).
Environment
----------Python Info----------
Version      : 3.6.6
Compiler     : GCC 7.2.0
Build        : ('default', 'Jun 28 2018 17:14:51')
Arch         : ('64bit', '')
------------Pip Info-----------
Version      : 19.3.1
Directory    : /home/ubuntu/anaconda3/lib/python3.6/site-packages/pip
----------MXNet Info-----------
Version      : 1.6.0
Directory    : /home/ubuntu/forked-mxnet/python/mxnet
Num GPUs     : 0
Hashtag not found. Not installed from pre-built package.
----------System Info----------
Platform     : Linux-4.4.0-1102-aws-x86_64-with-debian-stretch-sid
system       : Linux
node         : ip-172-31-41-238
release      : 4.4.0-1102-aws
version      : #113-Ubuntu SMP Wed Jan 29 14:54:54 UTC 2020
----------Hardware Info----------
machine      : x86_64
processor    : x86_64
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                96
On-line CPU(s) list:   0-95
Thread(s) per core:    2
Core(s) per socket:    24
Socket(s):             2
NUMA node(s):          2
Vendor ID:             GenuineIntel
CPU family:            6
Model:                 85
Model name:            Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
Stepping:              7
CPU MHz:               2499.998
BogoMIPS:              4999.99
Hypervisor vendor:     KVM
Virtualization type:   full
L1d cache:             32K
L1i cache:             32K
L2 cache:              1024K
L3 cache:              36608K
NUMA node0 CPU(s):     0-23,48-71
NUMA node1 CPU(s):     24-47,72-95
Flags:                 fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm $
onstant_tsc arch_perfmon rep_good nopl xtopology nonstop_tsc aperfmperf tsc_known_freq pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe $
opcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single kaiser fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms in
vpcid mpx avx512f rdseed adx smap clflushopt clwb avx512cd xsaveopt xsavec xgetbv1 ida arat pku

MXNet build flags
BLAS = MKL
✖ CUDA, ✖ CUDNN, ✖ NCCL, ✖ CUDA_RTC, ✖ TENSORRT, ✔ CPU_SSE, ✔ CPU_SSE2, ✔ CPU_SSE3, ✔ CPU_SSE4_1, ✔ CPU_SSE4_2, ✖ CPU_SSE4A, ✔ CPU_AVX, ✖ CPU_AVX2, ✔ OPENMP, ✖ SSE, ✔ F16C, ✖ JEMALLOC, ✖ BLAS_OPEN, ✖ BLAS_ATLAS, ✔ BLAS_MKL, ✖ BLAS_APPLE, ✔ LAPACK, ✖ MKLDNN, ✖ OPENCV, ✖ CAFFE, ✖ PROFILER, ✖ DIST_KVSTORE, ✖ CXX14, ✔ INT64_TENSOR_SIZE, ✖ SIGNAL_HANDLER, ✔ DEBUG, ✖ TVM_OP
BLAS = OpenBLAS
✖ CUDA, ✖ CUDNN, ✖ NCCL, ✖ CUDA_RTC, ✖ TENSORRT, ✔ CPU_SSE, ✔ CPU_SSE2, ✔ CPU_SSE3, ✔ CPU_SSE4_1, ✔ CPU_SSE4_2, ✖ CPU_SSE4A, ✔ CPU_AVX, ✖ CPU_AVX2, ✔ OPENMP, ✖ SSE, ✔ F16C, ✖ JEMALLOC, ✔ BLAS_OPEN, ✖ BLAS_ATLAS, ✖ BLAS_MKL, ✖ BLAS_APPLE, ✔ LAPACK, ✖ MKLDNN, ✖ OPENCV, ✖ CAFFE, ✖ PROFILER, ✖ DIST_KVSTORE, ✖ CXX14, ✔ INT64_TENSOR_SIZE, ✖ SIGNAL_HANDLER, ✔ DEBUG, ✖ TVM_OP
Steps to reproduce
Script
Create a Python script with the following content:
from mxnet import nd
print(nd.linalg_det(A=nd.random_normal(shape=(2**16, 2**16))))

and run it with Python3.
Error
With both BLAS engines, the error is the same:
Segmentation fault (core dumped)

Additional Information
The linalg ops do not throw errors on data with dimension <= 2**32. See the following example script and output:
Script
from mxnet import nd
print(nd.linalg_det(A=nd.random_normal(shape=(2**15, 2**15))))

Output
[inf]
<NDArray 1 @cpu(0)>

@mxnet-label-bot add [MKL]

@mxnet-label-bot remove [MKL]

@mxnet-label-bot add [MKL]

@ElaineBao could you help take a look?

@connorgoggins From the description, it seems that the issue is not directly related to MKL, but rather indext_t is not correctly used for these Map functions.

@connorgoggins The segment fault happens in line 485 of src/operator/tensor/la_op-inl.h, when the index j * (N + 1) is larger than the maximum value of int32 range (2**31-1).
Since N = 2**16 in this case, when int j is incremented to a value larger than 2**15-1, the segment fault happens.

@szha - Large Tensors has been enabled on master, but not on v1.x. I'm not sure if it supposed to be - if not than this issue is fixed and can be closed

Large-tensor support for 1.x it will be opt-in only.


TODOs

Bigger issues:

[x] The NASSA schema should be formalized and versioned. The .yml file should get a field nassaVersion
[ ] If the keywords in subjects, regions, periods, modellingKeywords and programmingKeywords should be standardized and enforced, then we need a mechanism for that
[x] create a template yml file with all possible fields so module authors can copy it and adapt it more easily. The template should note which nassa-hs version it refers to.

Details:

[x] "Netlogo" should be renamed to "NetLogo"
[x] More programming languages beyond R, Python and NetLogo should be allowed
[ ] When the format of the id field is clear, it should also be validated
[x] Some fields have length limits, which should be checked (title: 100c)
[x] The reading function should check if the files/dirs listed in readmeFile, docsDir and designDetailsFile actually exist

Software:

[ ] add some unit tests for the parsing code

[ ] Add function to check if the NASSA.yml field "license" is expressed as a valid SPDX identifier (https://spdx.org/licenses/)


Error Importing the .csv

Followed the instructions to the letter on a hyperv guest and I get an error when I try to import the csv. Error Code: 802 - InvalidZtdHardwareHash

@PJMarcum Somehow your issue got opened without being associated with a specific topic. Could you add a link to the topic you're referring to? Thanks.

@AndreaBarr Recommended closure.


Organisation? Roadmap?

I've started working on a version of this for .NET. Would be good to start to put together documentation around what TC delivers right now and then future work as well.
Time to turn it into a github organisation? @rnorth

Yup, cool! Will try and set this up over the weekend.

OK, this is in progress:

Github org is set up: https://github.com/testcontainers/
testcontainers.org is purchased and set up; basic DNS and mail, no website. We need this at a minimum to use the org.testcontainers prefix in maven central.
will migrate this project over to the organisation next

Please note that I've switched ownership of the repo and renamed it to testcontainers-java. New URL is: https://github.com/testcontainers/testcontainers-java

How about testcontainers.io ?

Happy to go half way with the costs in regards to all of this btw :)

Cheers! If you want to chip in a :beer: sometime would be more than generous enough ;)
I went for testcontainers.org basically because it was readily available, plus org.* is more common in java package naming than io.* so looks less jarring.
Next steps:

rename all the source packages and POM groupIds
release via bintray and maven central (probably v0.9.6)
update docs and add roadmap
when you're ready, set up a testcontainers-dotnet (name?) repo under the org


DEV-81 - sharing process in action bar is more clear

Description
Some users were confused about how to add reviewers and they would try to add reviewers by clicking on the share button. But the share button only copies the shareable link to the plan to the user's clipboard. The button with a person icon is where users could add or remove reviewers. To eliminate this confusion in navigating the UI, the share button is moved to where button with person icon was and now contains two options: add reviewers OR get shareable link to the plan. When the user hovers on the [Copy Plan Link] button or Add Reviewers title, they can get brief description of each feature.
Implementation
In Actionbar.tsx, I deleted the existing share button and replaced the button with person icon with share button icon. Then I added [Copy Plan Link] button to the pop up that appears when new share button is clicked. I added a hovering message with ToolTip from MUI library to the [Copy Plan Link] button. Then I went to Reviewers.tsx to add hovering message with MUI ToolTip to the Add Reviewers title.
Testing
Tested locally.
Screenshots

Made the wording more clear and UI better according to @mattliu-mygit comments

Not sure why prettier is failing - it's the same weird problem with the two files I never edited as it was with DEV-39

Can you add a hoverable tooltip (much like other parts of the app that give a description on what this share snapshot button does? This is because I foresee people not understanding what this button does from vocabulary, or misunderstanding because of the place where it's at.

Can you add a hoverable tooltip (much like other parts of the app that give a description) on what this share snapshot button does? This is because I foresee people not understanding what this button does from vocabulary, or misunderstanding because of the place where it's at.

I already added a hoverable, would this work?
Screen Shot 2023-03-06 at 12.00.53 PM

Remove the parenthesis in the tooltip and you're good to merge! ^.^


Correct title in downloaded Configuration Management files

Purpose or Intent
Fix the title of the downloaded files from Configuration Management - Jobs
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1364995

@miq-bot add_label ui, bug

@h-kataria please review.

@bmclaughlin can you add before/after screenshots.

Before:

After:

looks good.

Darga backport details:
commit 166621b48b8c1702baf98c445a74cd24e2017d69
Author: Harpreet Kataria<EMAIL_ADDRESS>Date:   Tue Aug 9 12:45:32 2016 -0400

    Merge pull request #10347 from bmclaughlin/fix-title-in-downloaded-files

    Correct title in downloaded Configuration Management files
    (cherry picked from commit bcb1d40a3a8b21ef366317f7b8d77bc3ff6a7d14)


Clean up removal messages

For some reason removing item dialog's have "from the VMDB" while create and modify do not.
There is no advantage to this as the VMDB is not something that the user would necessarily know about and does not convey any additional information.  This pull request removes this superfluous information.
https://bugzilla.redhat.com/show_bug.cgi?id=1354044

I went ahead and cleaned up the rest of the dialogs (sorry for the number of commits).  This should have the added bonus of cleaning up about 80 rubocop warnings.

@mikedahlgren 100+ commits??  please rebase and push again.

@chessbyte Sorry, I was editing this through GitHub and every file edit turned into a commit.  I'm currently trying to download this branch and squashing it locally.  Would you prefer this how it is, or as one commit for everything?


Extension issue

Issue Type: Bug
Extension Name: LiveServer
Extension Version: 5.7.4
OS Version: Windows_NT x64 10.0.19042
VSCode version: 1.54.1

:warning: We have written the needed data into your clipboard. Please paste! :warning:
{
	"messages": [],
	"activationTimes": {
		"codeLoadingTime": 45875,
		"activateCallTime": 8,
		"activateResolvedTime": 39,
		"activationReason": {
			"startup": false,
			"extensionId": {
				"value": "ritwickdey.LiveServer",
				"_lower": "ritwickdey.liveserver"
			},
			"activationEvent": "onLanguage:javascript"
		}
	},
	"runtimeErrors": []
}

What happened ? Slow?

VS Code, just hanged, couldn't save or make changes in any files. Online
advice was to check running extensions. I did that and Prettier and Live
Server were shown as unresponsive, so I just reported the issue on both.
On Mon, Jan 24, 2022 at 2:03 PM Ritwick Dey @.***>
wrote:

What happened ? Slow?
—
Reply to this email directly, view it on GitHub
https://github.com/ritwickdey/vscode-live-server/issues/2333#issuecomment-1020328662,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMT4OQA4Z5OAODWBE2QIWALUXWA7PANCNFSM5MVVRLQQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Rodrigo Simon
(21) 99446-0999


File picker dialogue not popping up for Load in Firefox-110.0.1 on Ubuntu-22.04

The file picker dialogue is not popping up for Load in Firefox-110.0.1 on Ubuntu-22.04. Preliminary investigation showed that the browser is blocking it with the message: "<input> picker was blocked due to lack of user activation.". So i tried a very simple experiment: I created a simple HTML file to see if file inputs worked at all and it failed. This means that the problem is not related to PAM. It is more fundamental.
This is the minimal test HTML file that was able to duplicate the problem:
<!DOCTYPE html>

    <title>System File Dialog Test</title>
    <meta name="author" content="Joe Linoff">
    <meta http-equiv="content-type" content="text/html; charset=utf-8" />
    <meta charset="utf-8">

input type="file"

    <input type="file" value="/" accept=".js,.pam,.txt" onclick="console.log('click',this)">

I am trying to figure out a workaround.

Found the problem. It was reported here: https://support.mozilla.org/en-US/questions/1375244
In a nutshell, the fix is to change widget.use-xdg-desktop-portal.file-picker in about:config from 2 to 0 in Firefox.


[SPARK-23455][ML] Default Params in ML should be saved separately in metadata

What changes were proposed in this pull request?
We save ML's user-supplied params and default params as one entity in metadata. During loading the saved models, we set all the loaded params into created ML model instances as user-supplied params.
It causes some problems, e.g., if we strictly disallow some params to be set at the same time, a default param can fail the param check because it is treated as user-supplied param after loading.
The loaded default params should not be set as user-supplied params. We should save ML default params separately in metadata.
For backward compatibility, when loading metadata, if it is a metadata file from previous Spark, we shouldn't raise error if we can't find the default param field.
How was this patch tested?
Pass existing tests and added tests.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/945/
Test PASSed.

Test build #87521 has started for PR 20633 at commit 69648d6.

Test build #87521 has finished for PR 20633 at commit 69648d6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87521/
Test PASSed.

cc @jkbradley This is to save default params separately in metadata file. Please help review after 2.3. Thanks!

also ping @MLnick @WeichenXu123  for review.

@viirya Have you run backward compatibility test ? e.g., saving estimator/models via master version spark, and load estimator/models via this PR version spark. To check whether it works fine and all params get saved and restored correctly.
Especially this should be done against QuantileDiscretizer/Bucketizer which you remove temporary fix code.

@WeichenXu123 I've added unit test in DefaultReadWriteSuite/DefaultReadWriteTest to test if this can read old metadata back.
Sounds like the backward compatibility test you suggested should be checked manually. I will test it. Thanks!

Test build #87996 has started for PR 20633 at commit 166cdbb.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1308/
Test PASSed.

Test build #87996 has finished for PR 20633 at commit 166cdbb.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87996/
Test FAILed.

retest this please.

Test build #87998 has started for PR 20633 at commit 166cdbb.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1311/
Test PASSed.

@WeichenXu123 Thanks for comment! I've run the backward compatibility test locally against QuantileDiscretizer/Bucketizer. They work fine. With this PR, the saved models can be read back and all params are restored correctly.

LGTM. Thanks! @jkbradley

Test build #87998 has finished for PR 20633 at commit 166cdbb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87998/
Test PASSed.

cc @dbtsai if you have time to look at this too.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1701/
Test PASSed.

Test build #88502 has started for PR 20633 at commit a2b6917.

Test build #88502 has finished for PR 20633 at commit a2b6917.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88502/
Test FAILed.

Merged build finished. Test FAILed.

retest this please.

Test build #88510 has finished for PR 20633 at commit a2b6917.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88510/
Test PASSed.

@jkbradley Thanks for your comments! I've addressed them. Please review it again. Thank you.

Can you address the conflicts? Gonna start to review it soon. Thanks.

@dbtsai Thanks! I've solved the conflicts.

Test build #89421 has started for PR 20633 at commit 80b668a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2363/
Test PASSed.

Test build #89421 has finished for PR 20633 at commit 80b668a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89421/
Test PASSed.

Merged build finished. Test PASSed.

ping @jkbradley

Sorry for the pause in review.
LGTM
Merging with master
@dbtsai  I'm going to merge this since I'm worried it will collect more conflicts, but let's discuss more if needed.
@viirya We'll need to update Python's DefaultParamsReader as well for Spark 2.4 in order to keep it in sync with Scala/Java.  R thankfully should not require anything since it only has wrappers.  I'll make & link a JIRA.  Will you have time to work on that?
Thanks @viirya !

Test build #4156 has started for PR 20633 at commit 80b668a.

@jkbradley Thanks! I'll work on SPARK-24058.


[WIP] Add Uni V3, stCelo, rstCelo, Algebra

Minima was recently taken offline due to changes in the regulatory landscape in the US.  While we await clarity on the licenses required to run a router as a service, some entities on Celo find themselves needing a routing solution to replace Minima. To ensure that the Celo community still has access to a router than can handle most protocols on the network, Ill be adding some additional pairs here.
Minima is a bit different from Swappa, so these pairs will be largely written from scratch (save for the input-output math). Extra care should be taken when using these added pairs until they are fully vetted by community.

[x] Uni V3
[x] stCelo
[x] rstCelo
[x] Algebra (Ube V3)

This will be a pretty big pr - is it preferred for me to break this up into multiple PRs instead?

Hey, yes this is a massive diff and is very difficult to review. I think separating it into three PRs for different pairs would be a good start.
I think STCelo stuff should be very easy so i can review those quickly.
I am guessing Uni v3 one is the biggest one so would be best to have a way to review it separately.

Fyi, I merged in stCelo and UniswapV3 stuff separately.
Just a heads up @d-mooers , there were bugs in both stCelo stuff and in UniswapV3 stuff too. UniswapV3 stuff is still not fully fixed, but I will take another pass at trying to fix it. Just a heads up in case you are using this code somewhere else too.
I don't know what the Algebra stuff is? Does it have any TVL? If it does, can consider merging that in too, otherwise can skip it.


Reciprocal is not executed on GPU for complex number

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below):
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: colab GPU
GPU model and memory: colab GPU

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
Reciprocal is not executed on GPU for complex number.
import tensorflow as tf

tf.debugging.set_log_device_placement(True)
with tf.device("gpu"):
  tf.math.reciprocal(tf.complex(1.0, 0.0))

"""
Executing op Complex in device /job:localhost/replica:0/task:0/device:GPU:0
Executing op Reciprocal in device /job:localhost/replica:0/task:0/device:CPU:0
"""

Describe the expected behavior
The reciprocal op can be executed on GPU for complex number
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
https://colab.research.google.com/drive/1x0NX11ZBjA95KSeafLg0_LRvVe8L2uyD?usp=sharing
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

I have tried in colab with TF version 2.2, 2.3-rc1,nightly versions(2.4.0-dev20200719) and was able to reproduce the issue.Please, find the gist here.Thanks!


WebElement tab() doesn't work on Android

In Detox 18.7.0, you have supported WebElement for Android device. But it didn't work for me when I used tap(). It works for other methods such as .toHaveText(text) or toExist(). I want to use runScript(script) and runScriptWithArgs(script, args) for a work around, do you have any example for using runScript(script) and runScriptWithArgs(script, args) ?
Detox: 18.20.2
@OrenZak

can you share your html and your test code ?

Thanks @OrenZak!
@thaole2021 please also elaborate on what it is exactly about tap that doesn't work. We have it working on our self-test suites with 0 flakiness.

can you share your html and your test code ?

I want to tap on aria-label="Login" element.
it("should be able to go to LOGIN page", async () => {
    const logIn = by.web.xpath('//*[@aria-label="Login"]');
    await ascendWebView.element(logIn).tap();
    await device.takeScreenshot("After_tap_Login");
  });

Login.html.zip

There are tests for those methods :)
runScript - https://github.com/wix/Detox/blob/50aa69723a029294dd2562f091562b56d1e85fad/detox/src/android/AndroidExpect.test.js#L463
and
runScriptWithArgs - https://github.com/wix/Detox/blob/50aa69723a029294dd2562f091562b56d1e85fad/detox/src/android/AndroidExpect.test.js#L475

@ThaoThiThuLE can I close this issue?

Yes, please close it. Thanks.


Proto 3 support ?

Are there plans to support Proto 3 any time in the near future ?
Thanks!
--Nick

I've just pushed an update to the latest version of gpb, which is what exprotobuf uses for parsing ProtoBuf definitions. There is proto3 support available in that version. I haven't been able to do testing on what features work out of the box, and which things I need to extend exprotobuf to handle properly. Give 1.2 a shot and let me know if there are things missing and I'll look into it.

@bitwalker, Fantastic!  I give the updated version a try;


ARROW-6048: [C++] Add ChunkedArray::View method that dispatches to Array::View

In the case where there are no chunks, it is not possible at the moment to validate whether a view would have been compatible if there had been chunks. Not sure if we want to fix that now

Codecov Report

Merging #5127 into master will increase coverage by 1.6%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5127      +/-   ##
==========================================
+ Coverage   87.62%   89.23%    +1.6%
==========================================
  Files        1014      731     -283
  Lines      145892   105089   -40803
  Branches     1437        0    -1437
==========================================
- Hits       127843    93774   -34069
+ Misses      17687    11315    -6372
+ Partials      362        0     -362

Impacted Files
Coverage Δ

cpp/src/arrow/table.h
100% <ø> (ø)
:arrow_up:

cpp/src/arrow/array.cc
82.37% <ø> (ø)
:arrow_up:

cpp/src/arrow/array.h
98.48% <ø> (ø)
:arrow_up:

cpp/src/arrow/table_test.cc
100% <100%> (ø)
:arrow_up:

cpp/src/arrow/table.cc
95.73% <100%> (+0.07%)
:arrow_up:

cpp/src/arrow/csv/column_builder.cc
95.54% <0%> (-1.49%)
:arrow_down:

cpp/src/plasma/thirdparty/ae/ae.c
70.75% <0%> (-0.95%)
:arrow_down:

python/pyarrow/parquet.py
92.17% <0%> (-0.13%)
:arrow_down:

js/src/util/fn.ts

go/arrow/memory/memory_avx2_amd64.go

... and 282 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747b476...45d20f3. Read the comment docs.


[riverpod_lint] analyzer just get crushed repeatedly

Describe the bug
i had tried riverpod_lint in my project, after globaly activate it the flutter analyzer just get crashing ,
i have removed the package and upgraded flutter and the same problem appear

Dart Code extension: 3.58.0
Flutter extension: 3.58.0 (activated)

App: Visual Studio Code
Version: 1.75.1
Platform: mac

Workspace type: Flutter
Analyzer type: LSP
Multi-root?: false

Dart SDK:
    Loc: /Users/noamanmonther/flutterDev/flutter/bin/cache/dart-sdk
    Ver: 3.0.0-245.0.dev
Flutter SDK:
    Loc: /Users/noamanmonther/flutterDev/flutter
    Ver: 3.8.0-13.0.pre.92

HTTP_PROXY: undefined
NO_PROXY: undefined
[9:56:46 AM] [FlutterDaemon] [Info] Spawning /Users/noamanmonther/flutterDev/flutter/bin/flutter with args ["daemon"]
[9:56:46 AM] [FlutterDaemon] [Info] ..  in /Users/noamanmonther/flutterDev/flutter
[9:56:46 AM] [FlutterDaemon] [Info] ..  with {"toolEnv":{"FLUTTER_HOST":"VSCode","PUB_ENVIRONMENT":"vscode.dart-code"}}
[9:56:46 AM] [FlutterDaemon] [Info]     PID: 53801
[9:56:46 AM] [FlutterDaemon] [Info] ==> [{"id":"1","method":"emulator.getEmulators"}]
[9:56:46 AM] [Analyzer] [Info] Spawning /Users/noamanmonther/flutterDev/flutter/bin/cache/dart-sdk/bin/dart with args ["language-server","--protocol=lsp","--client-id=VS-Code","--client-version=3.58.0"]
[9:56:46 AM] [Analyzer] [Info]     PID: 55236
[9:56:46 AM] [General] [Info] Returning cached results for project search
[9:56:46 AM] [General] [Info] Activating Flutter extension for Flutter project...
[9:56:46 AM] [General] [Info] Extension:Startup timing: 18ms
[9:56:46 AM] [DevTools] [Info] Spawning /Users/noamanmonther/flutterDev/flutter/bin/cache/dart-sdk/bin/dart with args ["devtools","--machine","--try-ports","10","--allow-embedding","--port","9100"]
[9:56:46 AM] [DevTools] [Info] ..  with {"toolEnv":{"FLUTTER_HOST":"VSCode","PUB_ENVIRONMENT":"vscode.dart-code"}}
[9:56:46 AM] [DevTools] [Info]     PID: 53801
[9:56:46 AM] [General] [Info] Version last used for Pub is 3.0.0-245.0.dev (3.0.0), current is 3.0.0-245.0.dev (3.0.0)
[9:56:46 AM] [General] [Info] Found 0 folders requiring "pub get" or "pub upgrade":
[9:56:46 AM] [General] [Info] Done!
[9:56:46 AM] [General] [Info] !! PLEASE REVIEW THIS LOG FOR SENSITIVE INFORMATION BEFORE SHARING !!

Have you tried using the "newest" lints? Add riverpod_lint: ^1.0.1 to pubspec.yaml.

The stacktrace says Analyzer itself is the problem, not custom_lint/riverpod_lint
Do you have a way to reproduce the error?

@rrousselGit  , as i mention, i has part and part of in my code , after remove them every thing just work fine , need to find out more

I'm also experiencing the same crashing while using riverpod_lint: ^1.0.1, immediately when adding it to a Dart project.
So far, I'm unsure of what the cause could be and don't have a work around; if you need additional info about my project or something else, I can try to be of help.
[✓] Flutter (Channel stable, 3.3.5, on macOS 13.2.1 22D68 darwin-arm, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc1)
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
[✓] Android Studio (version 2021.1)
[✓] VS Code (version 1.75.1)
[✓] Connected device (1 available)
[✓] HTTP Host Availability

If you could create a git repository to reproduce the issue, that would be great

I can't progress on this issue without any more information.
If anyone has this issue, it'd be lovely if you could make a GitHub repository with your project that faces this issue.

Closing as there's nothing I can do.
If you still have the problem, please open a new issue with more information.


Update links to HTTPS in Quickstart application

This also resolves a rendering problem when accessing the quickstart application over HTTPS: the font wasn't loaded from insecure connection.

Thank you, @aldaris !


Keep docs up-to-date (es6, fcm-node, json/quote)

Expected Behaviour

Use standard modern javascript on the node.js examples
Use standard libraries from Firebase on the node.js examples
Use standard json notation when needed, and use homogeneous javascript object literal notation when needed.

Actual Behaviour

Lots of var usage
Usage of third party package fcm-node, when we now have official support from Firebase
Mixed quoted/unquoted object literal notation in JSON and javascript contexts

We should review the docs to make use of a more modern dialect of javascript when refering node.js context. var -> let is just the most visible change, there might be others.
Firebase node.js package

One of the forks of the fcm-node package now mentions the existence of a module officialy from Firebase that provides the functionality offered by fcm-node:

Warning: on February 2, 2017, the Firebase Team released the admin.messaging() service to their node.js admin module. This new service makes this module kind of deprecated (source)

Should the examples on payload be changed accordingly?
Docs on the new official node.js API is here

Copied verbatim from https://github.com/phonegap/phonegap-plugin-push/pull/1736#issuecomment-303879546 , see source for more context.

@fredgalvao - is it possible that we can move the second task to a seperate issue?

Use standard libraries from Firebase on the node.js examples

Happy to update the es6 and json code in the examples, but have no idea about Firebase have never used it before.

@jacquesdev  Please do! There's nothing that prevents these inner tasks to be broken and done separately.

@fredgalvao -about Firebase - I started using it and it is quite opinionated about how the message is sent - it currently supports only string properties so anything else (include, for example, the ledColor) must be stringy-fied before sending.
I'd be happy to share my experience/code as I gain familiarity with admin-fcm (not a great markdown writer or an expert node js - but whatever I can do help, I'd happily try to...
Maybe a different issues is indeed in order?
P.S. I search for both admin-fcm and "value must be string" (which is the error I get using the official library) but didn't find any issue here (and in SO either). If there is such issue - sorry for "spamming" here (and let me know what it is so I can learn).

@tomercagan I'm not at all familiar with the details regarding fcm-node, however I might agree that said project being so (mis)opinionated might be an issue for some attributes on our API. However, I'd guess that we could still document most of the usages with some version or workaround using fcm-node or whatever is the most up-to-date lib.

not a great markdown writer

Don't worry about that if you want to help document the plugin. We can always review and improve on formatting on a pull request, for example.

Maybe a different issues is indeed in order?

We can always break this into smaller issues and separate PRs, there's no holding back.


Rename config.toml to hugo.toml in exampleSite

Hi there,
I'm new to Hugo and found your great Hugo template hugo-scroll which I'm planning to use for a company website within the next months, once the company is founded... ;)
While following the Hugo QuickStart guide in conjunction withe the Readme of the Hugo Scroll template, I (as a new Hugo user) got confused for a minute when I copied the content of the exampleSite folder to the folder of my new website. I linked my new Hugo site to the Hugo Scroll template before copying over the contents from the example website.
What irritated me, was that the example website is using a config.toml as a config file for Hugo, while the (new) default config file for Hugo is called hugo.toml.
I think it would things easier for new users if you would rename config.toml to hugo.toml. 😄

Hm, ok that must be something that changed over the years. If they are equivalent and compatible it sounds a good idea to adhere to the standard.


Can not display existing tasks after installation

No task appears after installation using sudo gem install taskwarrior-web.
I can use the "Add task" button to create a new task. The new task can be viewed using taskwarrior's command line interface, but is not displayed on the web interface.
I'm using taskwarror-web-1.1.11, versions are
rack 1.2
sinatra 1.4.5
vegas 0.1.11
taskwarrior version is 2.4.0.beta3
OS is Ubuntu 14.10

Same with me...
It worked with taskwarrior <IP_ADDRESS>. I've update to stable 2.4 an since then there is the problem already mentioned above.

TW 2.4.1
Task show
ruby 2.1.5p273 (2014-11-13 revision 48405) [x86_64-linux]   (Also tried 1.9.3)
gem 2.4.6

Confirming. Nothing shows up in task-web. Any ideas how we could get more info to help debug this issue?

Yes the issue seems to be that it is not pulling the .taskrc  tasks for display if you add a task it tells you the correct task number was created but it does not see the new task in the webui.

Confirming. After installing task-web with sudo no task is shown

Ok I got it fixed, with taskwarrior-2.4.4 and taskwarrior-web-1.1.11.
First thing in lib/taskwarrior-web/services/builder/base.rb:9:
-:query => TaskwarriorWeb::Config.version < '1.9.2' ? '_query' : 'export',
+:query => 'export',

I don't know how this was supposed to work, the taskwarrior manpages don't mention _query. export seems to have been around for quite a while (as far back as 1.7.0), but the default format changed from CSV to JSON for 1.9.3 (this is consistent with what's found in lib/taskwarrior-web/services/parser.rb).
Next thing is to fix the broken JSON parsing in lib/taskwarrior-web/services/parser/json.rb:7:
-json == '[No matches.]' ? [] : ::JSON.parse(json)
+json == '[No matches.]' ? [] : ::JSON.parse(json.gsub(/\n/,','))

Otherwise as soon as there are several tasks, the resulting json string is just a newline-separated array-like thing instead of a well-formed comma-separated JSON array.
Hope that helps.

Submit a PR and I'll merge it.

On Thu, May 28, 2015 at 7:13 AM, Quentin Minster<EMAIL_ADDRESS>wrote:

json == '[No matches.]' ? [] : ::JSON.parse(json.gsub(/\n/,','))

It works, thank you.

Also, it works/shows the tasks again. Many Thanks @laomaiweng :-)
But, editing (click/action is ignored) and annotating (shows an error page complaining about nothing to find with the GUID) doesn't work.
Also, if add a new task (works ;-) ), then taskserver is complaining with an error about a false priotity property. Beware of adding tasks via web in combination with use of taskserver (taskd)...


Add new Style/ArrayIntersect cop

In ruby 3.1 Array#intersect? has been added which is faster than (receiver & argument).any? since the new method avoids creating an intermediate array while evaluating for common elements. Also new method returns true as soon as it finds a common element between arrays.
Also new method is more readable.
I have added cop Style/ArrayIntersect which identifies and corrects this cases. It can find & usage with .any?, .present?, .empty? and .blank? methods.
Moved from rubocop-perfomance#312.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named new_style_intersect_predicate_cop.md if the new code introduces user-observable changes. See changelog entry format for details.

Speedup confirm by @koic (copied from rubocop-perfomance#312.
require 'bundler/inline'

gemfile(true) do
  gem 'benchmark-ips'
end

Benchmark.ips do |x|
  x.report('&') { ([1, 2, 3] & [2, 3, 4]).any? }
  x.report('intersect?') { [1, 2, 3].intersect?([2, 3, 4]) }

  x.compare!
end

% ruby intersect.rb
(snip)

Warming up --------------------------------------
                   &   452.504k i/100ms
          intersect?   708.976k i/100ms
Calculating -------------------------------------
                   &      4.458M (± 1.8%) i/s -     22.625M in   5.076782s
          intersect?      6.818M (± 4.8%) i/s -     34.031M in   5.004272s

Comparison:
          intersect?:  6817812.7 i/s
                   &:  4457969.2 i/s - 1.53x  (± 0.00) slower

I like the cop in general, but I'm wondering about the name - perhaps it should be ArrayIntersect, so it's a bit clearer what is it about. Anyways, I'm open to suggestions - naming continues to be hard. :-)

Naming is definitely hard. :slightly_smiling_face: At first it was abstract IntersectionCheck. I think ArrayIntersect is good.

Name was changed to Style/ArrayIntersect.

Yeah, I also think ArrayIntersect is a better name!

Two small notes:

Add some @safety section to the docs, as clearly that cop is unsafe as we can't be sure if something is an array or not.
Perhaps using in the examples names like array1 and array2 will make it clearer that this is array specific functionality.

Thanks!


Proper .gitignore support

This looks like it actually does the trick: https://www.npmjs.com/package/ignore

Why not just parse gitignore from cwd and then append defaults? And then update them like in the last lines of the index.js which is weird btw.

Part of the issue is the gitignore patterns are not the same as monarch/glob patterns. The ignore package above looks looks like it reconciles these patterns.

PR welcome! The ignore package looks like the way to go.

If we do this, could it be done in a 4.0 branch as couldn't it be stated that this could violate semver if someone needed to modify their .gitignore file to achieve the same results?

it should follow the npm ignore algorithm: https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package

Okay, I have this working. Should it be 3.x or 4.0.0?
@jprichardson The "ignore" property of package.json isn't going away. The .gitignore is purely additive; it's adding new ignored files. That makes me think this should be 3.x. No one's tests should break because of this. When I originally added .gitignore support, it was also done in a minor release.
Anyone have any thoughts (in the next 30 minutes) before I cut this release?

Well, actually, I have another definitely breaking change (operators go before line break
) I wanted to get into 4.0.0. Might as well just release this change together with that one to be on the safe side.

Okay, standard 4.0.0 is released! Enjoy :)

operators go before line break

Excellent :)

for the sake of anyone searching back through issues trying to figure out a change in ignore behavior like I was:
in ~3.0.0, package.json "ignore": ["artifacts/"] worked. with this change, in ~4.0.0, it must be "ignore": ["artifacts/**"]

@jden That's odd. "ignore": ["artifacts/"] works just fine for me. What platform are you on? Node version? Standard version?

@feross on<EMAIL_ADDRESS>ci *= ~/dev/agilemd/api
 2:21> node -p "require('os').platform() + ' ' + require('os').arch()"
win32 x64

ci *= ~/dev/agilemd/api
 2:21> node -v
v0.10.36

@jden I think I know what's causing this, but it's not easy for me to test on Windows.
Can you try using the code on the windows-gitignore-fix branch and see if that fixes the problem for you?

@feross I tried that out and get the same behavior. Note, I'm setting my ignores in the "standard" property of the package.json, not in .gitignore.

@jden Yep, I'm aware you're using the standard.ignore property of package.json :) Sorry, I made a silly mistake. Can you try that branch once more?

@feross yep, confirmed working!

@jden Cool, thanks for the help. I released this fix as 4.1.1. :+1:


Update react-yarn sample

Me and @AccraZed noticed that the react-yarn sample was not working correctly.

I created a new react-yarn sample app that works like the other samples.

@bhh1893  The change here is the missing

? Everything else is just cosmetic. Right?


move reading active validators to RPC / SDK.

now we have this logic in Coin.ts, we should expose this in RPC / SDK instead
https://github.com/MystenLabs/sui/blob/2fdc7ed9bd27a6d4bc2e807dcfb2a9ed712a5da2/apps/wallet/src/ui/app/redux/slices/sui-objects/Coin.ts#L225

I interpreted the TG question as asking about reading historical validator sets in addition to the current one. That won't be possible yet because we don't yet support reconfiguration, but perhaps we can do this via emitting an event with the new validator set each time we reconfigure (cc @emmazzz).
Aside: Coin.ts seems like it might not be the most logic home for this API...

@sblackshear oh, thanks sry I misunderstood that. Yes the Coin.ts was a quick hack to unblock Stake feature. naively I think we still want some endpoints in SDK / RPC to fetch active validators


⚠ Fetchers has degraded performance

In d918995, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 247 ms

Resolved: Fetchers performance has improved in cb85dde.


refactor: return static lifetime for validation errors and warnings

Description of changes
Return static lifetime for ValidationError and ValidationWarning so lifetime will live enough. 3.1.0 is not working with latest nightly version this PR fix that issue by returning static lifetime instead of custom lifetime
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):

[X] A bug fix or other functionality change requiring a patch to cedar-policy.

I confirm that this PR (choose one, and delete the other options):

[X] Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

[X] Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Latest nightly error message
error: lifetime may not live long enough
    --> cedar-policy/src/api.rs:1677:9
     |
1676 |     pub fn validation_errors<'b>(&self) -> impl Iterator<Item = &ValidationError<'b>> {
     |                              --  - let's call the lifetime of this reference `'1`
     |                              |
     |                              lifetime `'b` defined here
1677 |         self.validation_errors.iter()
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method was supposed to return data with lifetime `'1` but it is returning data with lifetime `'b`

error: lifetime may not live long enough
    --> cedar-policy/src/api.rs:1682:9
     |
1681 |     pub fn validation_warnings<'b>(&self) -> impl Iterator<Item = &ValidationWarning<'b>> {
     |                                --  - let's call the lifetime of this reference `'1`
     |                                |
     |                                lifetime `'b` defined here
1682 |         self.validation_warnings.iter()
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method was supposed to return data with lifetime `'1` but it is returning data with lifetime `'b`

error: lifetime may not live long enough
    --> cedar-policy/src/api.rs:1920:5
     |
1914 |   pub fn confusable_string_checker<'a, 'b>(
     |                                        -- lifetime `'b` defined here
...
1920 | /     cedar_policy_validator::confusable_string_checks(templates.map(|t| &t.ast))
1921 | |         .map(std::convert::Into::into)
     | |______________________________________^ returning this value requires that `'b` must outlive `'static`

error: could not compile `cedar-policy` (lib) due to 3 previous errors

I have already created issue at rust-lang/rust#122230 which if fixed will solve this issue for nightly but I believe even if it gets fixed code should be changed to return static lifetime when it is possible to return static lifetimes

@john-h-kastner-aws I have removed some unnecessary lifetimes to solve above issue. If it is not desired than I can revert PR to original accepted PR?

Ya you are correct. I think I will only add original changes to this PR and create new PR for next breaking changes


Lwaftrctl: allow nixos guest image

cc @teknico @dpino

LGTM in general. I haven't tried yet with the stock Ubuntu image we use, but I'm OK to merge it. Perhaps I would need modify the script again in the future, but if I do it so I will make sure it works with a NixOS VM too.


Additional fixes for deprecated moment params

What kind of change does this PR introduce?
Additional fixes for deprecated call to moment().subtract

@nevrending I already have  PR #1510 with this change.


refactor(app): confirm exit modal to appear over run details and run panel

closes #9053
Overview
This PR adds a portal to the confirm exit modal so it appears over the run details and run panel rather than only appearing over the run details.

Changelog

added top level portal

Review requests

make sure it matches AC of ticket

Risk assessment
low, behind ff

@emilywools should the background be black? I can't remember

full screen workflows (like robot calibration) use a black background. this modal background looks correct to me


code needs help

$ terminus code
Error: You need to specify a task to perform, site and environment on which to perform.

and terminus help code doesn't help.
It would be nice to have a complete help output like the other commands.
=C=

Apologies. :)
=C=


FocalNet-DINO checkpoints from huggingface. config

[06/30/2023] 💥 Please find FocalNet-DINO checkpoints from huggingface. The old links are deprecated.
where is the configuration of this ckpt? https://huggingface.co/microsoft/focalnet-large-fl4-dino-o365/tree/main
and where is the base model's configuration in mmdet's type?
Thanks

Here it is: https://github.com/FocalNet/FocalNet-DINO/blob/main/config/DINO/DINO_5scale_focalnet_large_fl4.py


Validation for ME4

Is your feature request related to a problem? Please describe.
Validation for Me4

Issue number 1254 is successfully merged


mocking plugins used within nuxt

Hey, firstly thank you for making this plugin, it looks very useful :)
Running this module seems to run the whole nuxt environment, including the plugins, and we have a plugin that makes a api call. We normally just mock the module where we import the api function but it doesn't seem to work in this case. For example:
// somePlugin.ts
import { fetchProducts } from "~/service/products";

export default defineNuxtPlugin(async () => {
    const products = fetchProducts();
    // do something with the products
});

// SomeComponent.nuxt.spec.js
import { describe, it, expect, vi } from "vitest";
import { shallowMount } from "@vue/test-utils";
import SomeComponent from "../SomeComponent.vue";

// trying to mock the products service so that the real api doesn't get called during the plugins
vi.mock("~/service/products");

describe("SomeComponent", async () => {
  it("Is a Vue instance", () => {
    const wrapper = shallowMount(SomeComponent);
    expect(wrapper.vm).toBeTruthy();
  });
});

I assume these mocks only work for the component that we are testing and not for the plugins in the nuxt environment for example. Do you have a suggestion about how to solve this?

I had a similar problem, my rest client is setup in a nuxt plugin and a subsequent plugin uses that client to make an app init api call.
In my rest client plugin i have something like the following:
const client = process.env?.TEST ? createMockClient() : createClient()
provideClient(client)

How you actually mock the requests is up to you

I had a similar problem, my rest client is setup in a nuxt plugin and a subsequent plugin uses that client to make an app init api call.
In my rest client plugin i have something like the following:
const client = process.env?.TEST ? createMockClient() : createClient()
provideClient(client)

How you actually mock the requests is up to you

Thanks! Indeed we could do this but I personally like not having any test related logic in the actual code so I would definitely prefer somehow moving this to the vitest config or the test files themselves :/

it's worth noting that you can mock api routes with registerEndpoint: https://github.com/danielroe/nuxt-vitest#registerendpoint.
There may be other reasons you would want to mock a plugin, and I think it should be possible, so leaving this issue up until we document it.

I'm using a plotting library in my project that is installed as a client side only plugin using the name convention (yourplugin.client.ts) since it uses browser API's. When running tests I get errors indicating the plugin is being executed in an environment that doesn't support it. Could it be that I need additional steps to get client side plugins to behave properly? Being able to mock this all together would be great since none of the things I want to test rely on this plugin. This is my code:
// vitest.config.ts
import { defineVitestConfig } from 'nuxt-vitest/config'

export default defineVitestConfig({
  test: {
    environment: 'nuxt'
  }
})

// plugins/09.plotly.client.ts
import Plotly from 'plotly.js-dist-min'

export default defineNuxtPlugin(() => {
  return {
    provide: {
      Plotly
    }
  }
})

@danielroe Would it be possible to have something akin to provide/inject for replacing a plugin in tests?
Api would be akin to
// In the test
import { overridePlugin } from 'nuxt-vitest'

it('allows me to do things that have great power', () => {
  overridePlugin('something', () => {
    ...function that would override the plugin and receive the same arguments
  })
})

I'd like to echo the desire to be able to mock and/or exclude functionality within plugins. For a project I work on, either or both of the following resolutions would be ideal for our use case:
1. Some way to easily specify which plugins to include/exclude in the nuxt-vitest Nuxt runtime
The ability to exclude plugins that don't need to run in our testing environment would save us from needing to mock that plugin logic despite questionable value to the quality of our tests.
Note:
We tried to specify a subset of our plugins using environmentOptions.nuxt.overrides.plugins in our vitest.config.ts, but Nuxt appears to auto-import all of the plugins despite our explicitly-passed subset.
2. A way to run test setup files (specifically, files with the same context as Vitest setupFiles) before spinning up the Nuxt runtime environment
Upon running vitest from the command line (through npm test), we see the following output. (Sample repo with reproducible output here).
❯ npm test

><EMAIL_ADDRESS>test
> vitest

global setup

 DEV  v0.33.0 /Users/adam.gipril/Developer/nuxt-vitest-playground

stdout | unknown test
<Suspense> is an experimental feature and its API will likely change.

stdout | unknown test
setup file

 ✓ app.test.ts (1)
   ✓ is 2

 Test Files  1 passed (1)
      Tests  1 passed (1)
   Start at  14:31:58
   Duration  553ms (transform 216ms, setup 3ms, collect 6ms, tests 1ms, environment 382ms, prepare 53ms)

 PASS  Waiting for file changes...
       press h to show help, press q to quit

So to put this ask in other words, is there a way to run some sort of setup with the same Vitest context and mocking abilities as the setupFiles, but such that they execute after globalSetup and before the Nuxt runtime starts?

@adam-gipril Yes, we should build this in in future. (Adding setup files easily.) For now, you can likely implement with this hack:
import { defineVitestConfig } from 'nuxt-vitest/config';

export default defineVitestConfig({
  test: {
    environmentOptions: {
      nuxt: {
        overrides: {
          plugins: [
            // path to custom file
          ]
        }
      }
    }
  }
});


Optionally disable sending current value after subscription

Description
Adds an option to Scenic.PubSub.subscribe to  disable sending current value immediately.
Motivation and Context
When subscribing for a source, the current value is sent immediately if exists. Sometimes this behaviour is not desired, for example if we are not interested in past state, but only only want new events. In my particular use case, there is hardware that generates an event when a coin is inserted into coin acceptor, but the scene is only interested in payments made after it was started
Types of changes

[x] New feature (a non-breaking change which adds functionality)

Checklist

[x] Check other PRs and make sure that the changes are not done yet.
[x] The PR title is no longer than 64 characters.

@ademenev Sorry for the extremely late review--is it alright for now if we simply disregard the return of subscribe/2 in client code? I think that would accomplish the same thing, yes?

Closing for now, please re-open if needed. :)


Add sbt-eclipse plugin and wiki for how to build gearpump on eclipse

The wiki is here: https://github.com/intel-hadoop/gearpump/wiki/Eclipse-and-Intellij-IDE-development-environment-setup


Restoring folds from sessions could be more robust

Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
Currently, when restoring a session that contains folds, E490: No fold found is thrown if there's an invalid fold. This might be the desired behavior in some circumstances, but it also has some unintended consequences, specially within the neovim ecosystem.
Describe the solution you'd like
Instead of throwing an error, the default behavior when restoring a session could be to give a warning for the fold regions that can't be restored, and then restore the remainder of the session as usual.
Having a session lacking some folds is more intuitive than the current behavior: the user needs to open the session file, manually remove the offending folds and then launch vim again, to have a "successfully" restored session. This situation can be quite common: a user might edit a file outside a session and try to restore the session afterwards. Another example would be switching git branches.
Describe alternatives you've considered
Additional context
This context is mostly neovim specific, so that's why I decided to have it here in this session.
Now that treesitter folds are getting more popular, numerous issues have been raised reporting problems that are either caused by (or heavily related to) this error being thrown. Some examples:
From neovim core: https://github.com/neovim/neovim/issues/28692, contains a more extensive list.
From session plugins:

https://github.com/pysan3/autosession.nvim/issues/2
https://github.com/Shatur/neovim-session-manager/issues/133
https://github.com/jedrzejboczar/possession.nvim/issues/52

Can you please provide a minimal reproducible example?

Can you please provide a minimal reproducible example?

Sure!
Sample markdown file:
- foo
    - bar
        - biz
        - biz
    - bar

- foo

Open the file and :set foldmethod=indent
Open the fold on the second line, with zO
Close the fold on the third line, with zc
:mksession and exit vim
Open the file again (normally) and edit it to become

- foo
- foo

Close vim, without generating a new session
vim -S Session.vim

When launching the session, the error will be thrown

It is documented behavior in :mkview:
#  /usr/local/share/vim/vim91/doc/starting.txt (lines 1503-1504)
- When storing manual folds and when storing manually opened/closed folds,
  changes in the file between saving and loading the view will mess it up.

I think the warning could be equally annoying, at least with many folds that cannot be re-created. We could ignore the errors completly:
diff --git a/src/fold.c b/src/fold.c
index 3353cc55f..ac1f043bb 100644
--- a/src/fold.c
+++ b/src/fold.c
@@ -3614,9 +3614,10 @@ put_foldopen_recurse(
            if (fp->fd_nested.ga_len > 0)
            {
                // open nested folds while this fold is open
+               // ignore errors
                if (fprintf(fd, "%ld", fp->fd_top + off) < 0
                        || put_eol(fd) == FAIL
-                       || put_line(fd, "normal! zo") == FAIL)
+                       || put_line(fd, "sil! normal! zo") == FAIL)
                    return FAIL;
                if (put_foldopen_recurse(fd, wp, &fp->fd_nested,
                                                             off + fp->fd_top)
@@ -3657,7 +3658,7 @@ put_fold_open_close(FILE *fd, fold_T *fp, linenr_T off)
 {
     if (fprintf(fd, "%ld", fp->fd_top + off) < 0
            || put_eol(fd) == FAIL
-           || fprintf(fd, "normal! z%c",
+           || fprintf(fd, "sil! normal! z%c",
                           fp->fd_flags == FD_CLOSED ? 'c' : 'o') < 0
            || put_eol(fd) == FAIL)
        return FAIL;

Hey there! Ignoring the errors completely does sound better. If the change isn't that controversial, and if it's as simple as your patch, I can open a PR.