device_tracker: save and restore consider_home attribute

When using the device tracker 'see' API without explicit 'not_home'
events, HA used to show all previously seen devices as 'home' after
restarts, because the consider_home attribute got lost.
When no consider_home attribute has been saved for an entity before,
apply the global default value in order to mark previously seen one-
time visitors as away.
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox.

@ballob you're right. It appeared to work correctly because the default value was applied in my local test. Do you have a suggestion how to parse the timedelta from a string? I can't use the timedelta object, because Python complains about it not being serializable. The web API parses it, but I haven't found the location inside HA's source code yet.

After looking at my patch for another time, I noticed that my theory about the default value influencing my test seems wrong.

@balloob I've just uploaded a new version, tested locally. What do you think about it? I'll figure out how to create a test when there's a chance for it to land.

@balloob: I wasn't able to figure out how to write a good test, because I don't know much about HA's internals. Let's wait until someone else jumps in.

The odds of someone jumping in are very slim. I am going to close this PR as I'm cleaning up the board. You can re-open it when you or someone else has added tests.


Use buffers to increase speed

I noticed that the XML Parser takes a lot of time when processing bit amounts of data. I noticed that you use ByteStreams but no buffers. Using buffers usually improves performance by a lot. Therefore it would be wise to use them here as well to increase speed

https://github.com/codemonstur/simplexml/blob/ad60080569b15a2ca41e8fa588d788a0805ebb50/src/main/java/xmlparser/XmlParser.java#L126-L128
This can be improved by using e.g. a BufferedReader
        try (InputStreamReader streamReader = new InputStreamReader(stream, this.charset);
             BufferedReader bufferedReader = new BufferedReader(streamReader)) {
            return XmlReader.toXmlDom(bufferedReader, this.trimmer, this.escaper);
        }

My primary concern with writing the library was to make it correct, simple and clean. Speed has always been a secondary concern. That said, I'd love to make it faster. My problem has been that I can't find a good benchmark project that I can use to compare simplexml against other libraries or to compare it against real world XML.
I'm hesitant to make changes to the code base based on guesses about what would make it faster. The BufferedReader thing I can add though. That isn't going to hurt :)

I've pushed a new version of the library. Mostly I added a BufferedInputStream where appropriate, and cleaned up some minor stuff. Without any benchmarks I won't be able to tell if anything is going faster or not.


Remove all YAML references

@guilhermeblanco I think this covers everything except the documentation files, should we also change them?

@lcobucci Documentation will be revisited once we get close to an alpha release. For now we're safe to experiment/implement stuff.

I love the cleanup! GJ

Since everyone keeps asking, and a lot of YAML afficionados keep poking me on other channels, I'm clarifying the reasoning for this change.

@guilhermeblanco is rewriting the internals of the mapping component, both for performance and for type-safety/ease of usage
due to the mapping internal changes, mapping drivers would have required constant re-adapting. We simply don't have the throughput to deal with that, so we decided to get rid of some code instead.
we are aiming for less mapping drivers to maintain ourselves. If YAML is such a big deal, then somebody may write a driver for it once the metadata changes are complete. It would not live in the Doctrine\ namespace though.
we aim at unifying mapping drivers via https://webmozart.io/blog/2014/10/24/defining-php-annotations-in-xml/ (not yet there, but that's the aim)
Over the years, we got hundreds of help requests due to a missing key, a lacking indentation level, etc. These are not important problems, they are just noise, and given the limited amount of time that all of us have, we identified this as the actual problem. Getting rid of an "unfit-for-work" format seemed like a better decision.

If you want to use the develop branch, consider using the orm:convert-mapping command to translate your YML definitions into XML for now.

@Ocramius thanks for the complete explanation.
So, to sum up what format should be used: php annotations (please no :( ) or xml files ? (Yay!).
Mickaël

@michael-lavaveshkul annotations are good for in-house projects, please use XML for anything reusable/published.

@Ocramius will you still be supporting CSV please?

@Ocramius will you still be supporting CSV please?

I hear that IDE support is poor, so we won't do it.

Touchè :trollface:

@ocramius Thank you, explanation is always great.

I'm gonna expand the work that is being done on develop branch, so any adventurous person won't shoot me on street.
Quote strategy is mostly gone, since it's not up to the ORM handle discrepancies on user's database mapping. If you define your columns and provide the column name all lowercase, it's not up to us fix it on your Oracle driver and make it uppercased. Instead of handling this for the user, which makes our code harder to maintain and also introduce serious WTF bugs (anyone interested to see some, read this method: https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Persisters/Entity/JoinedSubclassPersister.php#L233 ), we decided to leverage an easier way for users to define their own NamingStrategy. People are welcome to implement their own, solving their own casing problems.
Right now, I commented out ALL support for Embeddables. Every tiny bit I was changing was revealing random bugs, which hint a bad implementation under the hood. We'll bring it back before first alpha in a new, deeply integrated support, but for now, no go.
All 300's unit tests that are failing are due to quoting being now enforced everywhere. I dropped the backtick support and every single column, table, schema, etc is now quoted. I have yet to find a solution that makes quote comparisons proper and work across all drivers when running the unit tests.

I've never been a fan of XML files, but I understand where your decision is coming from. I haven't used the YAML mapping since the introduction of annotations. I'll keep in mind if I ever release a library it's preferred to be in XML... why is that though?
I know previous reasons for XML vs YAML is validation, but YAML now can be validated I thought... so just curious.
Thanks for all of your hard efforts!

YAML now can be validated I thought... so just curious.

We'd have to write the validation logic for it, and that is just overhead.

@guilhermeblanco nobody is gonna shot you in the street because you made a sensible decisions ;)
I really like YAML so I belongs to the person disappointed by this decision, but I perfectly understand the rationale so thanks very much for the explanation and for working so hard for Doctrine 3 👍 👌

@Ocramius
Fully understand, I'd rather the focus be on what y'all do best than the ancillary parts. Those that really want the YAML support can create an additional library to add that support with proper focus on the YAML.
Now why is it that XML is the standard requested for third-party available libraries? Is it because it's so verbose?

@BallisticPain XML it is a tool of choice for configuration as you can validate your config against an XSD schema. For example when using PHPUnit, if you have:
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/5.2/phpunit.xsd">

You'll be able to have syntax highlighting and auto-completion when writing your PHPUnit file.

@BallisticPain what @theofidry said. In addition to that, should we change our schema to remove configs that we don't support, or alter how they are to be set up, you'd get immediate feedback from the XSD validation (which would fail, highlighting the issue).

@theofidry @Ocramius
Thanks! That makes a lot of sense. I just usually try to stay away from XML is the reason I'm asking. I've used it in almost every project, but I avoid it for a while before jumping in ... :-P

I'd love if someone would still maintain YAML driver.

We're having major issues in keeping the most important bits maintained and supported (as in helping people out): either somebody builds a repository for YAML support (and maintains that outside of the doctrine organization) or it is not going to happen for now.

I represent the repressed people of Yaml and would like to say I stand strong against this carnage of configuration of the yaml kind. YAML IS ALSO TEXT!
Actually, no, kill it with fire.

Even if I'm sad (was one of YAML users), I do understand your choices: time and motivation aren't unlimited :)

Since I'm lazy, here's a longer explanation of why we're dropping the thing: https://github.com/doctrine/DoctrineBundle/issues/776#issuecomment-363812362

Is Yaml support being dropped? Just visited the documentation today to find it's no longer there for associations.

yes @zquintana see this PR and the immediate last comment prior to yours.

Looks like docs is being build from master, that's not a good idea since master now points to version 3.0-dev with BC breaks and many changes.
@ocramius can we somehow set the build process to use 2.7 branch instead?

@Majkl578 I think we should rather have proper versioning of the docs, no? I think @mikeSimonson and @malarzm were working on that.

@Ocramius I am sorry but what will happen to Symfony projects which used YAML files almost exclusively and the primary driver? Should we not be updating Doctrine anymore? Is there a converter to at least move from YAML to XML and/or Annotations?

XML sucks! Not as much as annotations, but still the same shit :hankey:

@SergeyPodgornyy unless you are willing to set up to provide proper support for YAML why are you being disrespectful and offensive instead? OSS is toxic enough as it is, no need to spread more of it

As I pointed out in my comments, lesser static but more driver/provider-based code is more flexible. It is good that this project heads that way. Still I miss real annotation support in PHP itself like it has been done in Java. @Override seem to be a superfluous annotation but it helps a lot when it comes to implementing against interfaces or super classes (inherited classes). Okay, wrong tracker, just my feelings about them. :-)


Copy release binary to github pages to avoid rate limit on install (403)

403 errors can occur when installing ddb because of github rate limit.
Binary should be available on github pages site to avoid this rate limit, and update installer script accordingly.

I'll implement another solution : use git command to retrieve the latest tag (instead of github api).

https://github.com/inetum-orleans/docker-devbox/commit/cb0700b345ad4517eca6a55956c4f0716d3798ac

It still doesn't work.
curl: (22) The requested URL returned error: 403
Can't find docker-devbox-ddb last release.

Should be fine now.
https://github.com/inetum-orleans/docker-devbox/commit/e37b1fafefb38592144eaa0a71047f44c412823d


Assigning Pods to Nodes - example missing mentioned values

The label with the key topology.kubernetes.io/zone not exist in the example for node affinity:
https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#node-affinity

/kind bug
/language en
/triage accepted
Thanks for reporting this.
I would fix this discrepancy by copying the example manifest to make a new example, that does use the key topology.kubernetes.io/zone key. The Git history might show a previous version that already did, which would make it easier to write the copy.
The reason I'd make that copy is because I suspect that more than one page relies on the same example (and that's why an unhelpful change has slipped through).

/assign


Not create the folder, otherwise the link can't be done

If we create the folder the link can't be done and data is not available on the volume. I still think that it may not work because data should be in /ldap, so maybe it would be better to change that the folder shared is /var/lib/apacheds-2.0.0_M20/

You are correct. Silly me :)
Thanks for the pull request


[RFC] go2 error handling best reference

I read the https://github.com/golang/proposal/blob/master/design/go2draft-error-handling.md
The new go2 error handling design paper.
Sorry for create this issue, ( i can not find any place to submit my thought and worry about the doc)
This issue is to talk my thought about the go2 error handler.
The go2draft error handling design a ugly error handle proccess way.
I can not agree with the design.
And I would like to suggest some good error handling

C# https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/exceptions/
F# https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/exception-handling/

these two exception handling design , provided us a clean interface, and easy to deal , easy to track problems.
the Go2Draf handler Check seems too complicated and not well structed
And here some other article talk about exception handler, very well document .
https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/exceptions
https://docs.microsoft.com/en-us/dotnet/standard/exceptions/best-practices-for-exceptions
Exception handling has many advantages over return-value-based error reporting.
Good framework design helps the application developer realize the benefits of exceptions.
This section discusses the benefits of exceptions and presents guidelines for using them effectively.

A well-designed app handles exceptions and errors to prevent app crashes.

Discussion about the error handling design is welcome.  But it would help quite a bit if you could be more specific.  What exactly is ugly?  What exactly do you not agree with?
Referring to exception handling is a non-starter.  We are not going to implement C# style exception handling in Go, for the reasons explained at https://go.googlesource.com/proposal/+/master/design/go2draft-error-handling-overview.md .  While alternative suggestions are welcomed, a general pointer to other languages that use exceptions is not going to be adopted.  Sorry.

The handler and check not match , you have to write a lot check , check check, and define lot's of handler.

Your check and handler was nosense. Check what ? handler what?
nothing to know, no problem resolved. you just make things worse and worse

( i can not find any place to submit my thought and worry about the doc)

This is the place - https://github.com/golang/go/wiki/Go2ErrorHandlingFeedback.
Please feel free to outline all your thoughts in a post,gist,google doc and add a link in the wiki. It looks like you have more of a feedback, rather than a concrete proposal. So I will close the issue and request you to use the wiki page.
Thank you.


Issue: Using escaped strings is not working correctly

In issue #65 some issues regarding the usage of escaped strings have been fixed. I am currently facing another issue in combination with escaped characters (backslashes and quotation marks).
TextParser.cs seems to not handle those scenarios correctly.
I have been able to reproduce the issue in unit tests:
[Fact]
public void ParseLambda_StringLiteral_Backslash()
{
    string expectedLeftValue = "Property1.IndexOf(\"\\\")";
    string expectedRightValue = "0";
    var expression = DynamicExpressionParser.ParseLambda(
        new[] { Expression.Parameter(typeof(string), "Property1") },
        typeof(Boolean),
        string.Format("{0} >= {1}", expectedLeftValue, expectedRightValue));

    string leftValue = ((BinaryExpression)expression.Body).Left.ToString();
    string rightValue = ((BinaryExpression)expression.Body).Right.ToString();
    Assert.Equal(typeof(Boolean), expression.Body.Type);
    Assert.Equal(expectedLeftValue, leftValue);
    Assert.Equal(expectedRightValue, rightValue);
}

[Fact]
public void ParseLambda_StringLiteral_QuotationMark()
{
    string expectedLeftValue = "Property1.IndexOf(\"\\\"\")";
    string expectedRightValue = "0";
    var expression = DynamicExpressionParser.ParseLambda(
        new[] { Expression.Parameter(typeof(string), "Property1") },
        typeof(Boolean),
        string.Format("{0} >= {1}", expectedLeftValue, expectedRightValue));

    string leftValue = ((BinaryExpression)expression.Body).Left.ToString();
    string rightValue = ((BinaryExpression)expression.Body).Right.ToString();
    Assert.Equal(typeof(Boolean), expression.Body.Type);
    Assert.Equal(expectedLeftValue, leftValue);
    Assert.Equal(expectedRightValue, rightValue);
}

I think the issue is that the current implementation assumes that it is always a full string (starting and ending with an escaped quotation mark) and not only a single escaped character.
Edit: Updated unit tests code

Hey, I got this issue again but only for backslashes, when switching from the NuGet package
wilx.System.Linq.Dynamic.Core

(https://www.nuget.org/packages/wilx.System.Linq.Dynamic.Core/)
to
System.Linq.Dynamic.Core

I think the later one should be used?
Error:
System.Linq.Dynamic.Core.Exceptions.ParseException: 'Unterminated string literal'

Console app code to reproduce:
static void Main(string[] args)
{
    var strings = new[] { "test \\ string" }.AsQueryable();

    var count = strings.Count("ToString().Contains('\\')");
    //var count = strings.Count(s => s.ToString().Contains('\\'));

    Console.WriteLine("Elements found (should be 1): " + count);
    Console.ReadKey();
}

As a workaround you can use:
var count = strings.Count("Contains(@0)", "\\");

Thank you for the answer, this worked for me in the given example. At a different point we use an input string to filter out elements, so it would be quite complicated to get it to work that way, having multiple inputs for each argument in the string predicate, as well as that filter string containing the arguments.
Is there a plan to fix this in the future?
Thank you for your help!

I see your point, it seems that the parsing code in this library is different regarding escaping. I'll take a look if I can find and fix the logic.

@hypetsch and @SolidWhiteSven
I've changed the code, please try version 1.0.13-ci-11242 from MyGet.
https://www.myget.org/feed/system-linq-dynamic-core/package/nuget/System.Linq.Dynamic.Core

Hey @StefH, I've added the prerelease package with version 1.0.13-ci-11244 to the solution, but sadly I still get the 'Unterminated string literal' exception. I also thought the changes were only in the mentioned 11242 version, but that one also throws the error for this code:
using System;
using System.Linq;
using System.Linq.Dynamic.Core;

namespace Test
{
    class Program
    {
        static void Main(string[] args)
        {
            var strings = new[] { "test \\ string" }.AsQueryable();

            var count = strings.Count("Contains('\\')");

            Console.WriteLine("Elements found (should be 1): " + count);
            Console.ReadKey();
        }
    }
}

You are correct, this test does not work. I've to double check the code again...

@SolidWhiteSven
Can you try 1.0.13-ci-11260 ?

@StefH Works like a charm, thank you!

@hypetsch Can you also do some tests please?

@StefH, thanks for sour work. Just did a quick test: the test case ParseLambda_StringLiteral_Backslash() I added in the first comment still fails with a ParseException ('Unterminated string literal'). Think the test itself should be ok?

@hypetsch
Yes I noticed that also, so I changed the unit-test to be :
string expectedLeftValue = "Property1.IndexOf(\"\\\\\")";

Which means (to my knowledge):

\" --> escape the double quote (start)
\\\\ --> define a backslash : because the backslash is inside the double quotes, you need to escape it twice. If you just use \\, this will be translated to \ which is not valid because this is an escape character (https://devblogs.microsoft.com/csharpfaq/what-character-escape-sequences-are-available/) So we need to double escape the backslash
\" --> escape the double quote (end)

Sorry, think you are right.
Some other tests I did meanwhile worked well. Thanks.

Thank you both for your help !
I will close this issue and merge the PR; in some time, I'll create a new official NuGet.


Cross updating with Microservices eBook v2.1.02 - Chapter 8

Summary
Synchronized Microservices e-book <--> docs.microsoft.com (Chapter 8)
Fixes #5395, fixes #6311
Changes have been grouped and the type of changes is included in the commit description.
Just waiting to run the Acrolinx review to submit the text content changes.

Replaced by #8506


Fix CI Devfile Registry URL used in OCP interop tests

What type of PR is this:
/area testing
/kind bug
What does this PR do / why we need it:
We had a lot of failures because the OCP Interop tests were still using the old Devfile registry URL, which is no longer reachable since we created a new cluster.
See https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-redhat-developer-odo-main-odo-ocp4.14-lp-interop-odo-scenario-aws/1675746432100864000
Which issue(s) this PR fixes:
—
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

...

  [odo]   __
  [odo]  /  \__     Developing using the "maurzc" Devfile
  [odo]  \__/  \    Platform: podman
  [odo]  /  \__/    odo version: v3.12.0
  [odo]  \__/
  [odo]
  [odo] ↪ Running on podman in Dev mode
  [odo] I0703 09:23:13.675772  272591 schema.go:61] validated devfile schema
  [odo] I0703 09:23:13.681062  272591 validate.go:45] Successfully validated devfile sections
  [odo]  •  Deploying pod  ...
  [odo] I0703 09:23:13.682378  272591 utils.go:77] Updating container runtime with mandatory volume mounts
  [odo] I0703 09:23:13.682453  272591 utils.go:149] No entrypoint defined for the component, setting container runtime entrypoint to 'tail -f /dev/null'. You can set a 'command' and/or 'args' for the component to override this default entrypoint.
  [odo] I0703 09:23:13.682586  272591 podman.go:201] executing [podman volume ls --format {{.Name}} --noheading]
  [odo] I0703 09:23:13.983934  272591 watch.go:433] Error from Push: exit status 125: Error: no volume with name odo-shared-data-lsiocx-app found in database: no such volume
  [odo]  ✗  Deploying pod [302ms]
  [odo] Error occurred on Push - exit status 125: Error: no volume with name odo-shared-data-lsiocx-app found in database: no such volume
  [odo]
  [odo]
  [odo]
  [odo] ↪ Dev mode
  [odo]  Status:
  [odo]  Watching for changes in the current directory /tmp/1088296253
  [odo]
  [odo]  Keyboard Commands:
  [odo] [Ctrl+c] - Exit and delete resources from podman
  [odo]      [p] - Manually apply local changes to the application on podman
  exit status 125:
  [FAILED] in [It] - /home/runner/work/odo/odo/tests/helper/component_podman.go:67 @ 07/03/23 09:23:23.122
....
Summarizing 1 Failure:
  [FAIL] odo dev command tests when running odo dev and composite command is marked as parallel:true - with metadata.name [It] should execute all commands in composite command [podman]
  /home/runner/work/odo/odo/tests/helper/component_podman.go:67

Ran 181 of 934 Specs in 1306.300 seconds
FAIL! -- 180 Passed | 1 Failed | 0 Pending | 753 Skipped

Unrelated.
/override ODO-PODMAN-TEST


Add new navigation events included in RNN 4.5.0

Version 4.5.0 introduced two new events for iOS as described in RNN 4.5.0 changelog:

registerModalAttemptedToDismissListener (iOS 13+ only)
registerBottomTabLongPressedListener

:tada: This issue has been resolved in version 5.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


New cmd/tx-storm

New cmd/tx-storm is ported from develop branch and adopted to the existing scripts.

Codecov Report

Merging #553 into develop2 will increase coverage by 0.19%.
The diff coverage is 2.78%.

@@             Coverage Diff              @@
##           develop2     #553      +/-   ##
============================================
+ Coverage     46.46%   46.66%   +0.19%
============================================
  Files           167      168       +1
  Lines         11201    11168      -33
============================================
+ Hits           5205     5212       +7
+ Misses         5470     5432      -38
+ Partials        526      524       -2

Impacted Files
Coverage Δ

cmd/tx-storm/acc.go
23.80% <0.00%> (ø)

cmd/tx-storm/config.go
0.00% <0.00%> (ø)

cmd/tx-storm/flags.go
0.00% <0.00%> (ø)

cmd/tx-storm/metrics.go
0.00% <ø> (ø)

cmd/tx-storm/nodes.go
0.00% <0.00%> (ø)

cmd/tx-storm/sender.go
0.00% <0.00%> (ø)

cmd/tx-storm/txgen.go
0.00% <0.00%> (ø)

utils/avg_buff.go
0.00% <0.00%> (ø)

cmd/tx-storm/main.go
31.57% <33.33%> (-0.93%)
:arrow_down:

gossip/execqueue.go
88.88% <0.00%> (-2.78%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7635d14...359a3d4. Read the comment docs.


UNC path to the vault database does not work.

I created a Vault database file on a windows share and tried to register the vault with a unc path and it fails to register.

Hi @manojpotluri,
can you please provide more information, such as the logs or a specific screenshot of the message when it fails to register?
In general UNC paths are not supported currently but they may work in some circumstances, I'd recommend you map a drive and see if that works.

Hello @JustinGrote
Here is the error i am seeing when i try to register a test vault database created on a share location.

I tried the Mapped Drive suggestion as well and it errors out too

appreciate you taking time looking into this.
Thanks,
Manoj.

This looks like something that would be deeper into SecretManagement itself, not my extension. Can you provide the output of
$error | export-clixml $home\desktop\error.clixml after running the command and attach the clixml to this issue?

Attaching the Zipped error.clixml file here.  please let me know if you need more information.
error.zip

I don't think your system is fully loading the module correctly, your second error is:

and the details are:
Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified.
It looks like you're doing this on Powershell 5.1, have you tried it in Powershell 7?

Hello @JustinGrote
yes i am using powershell 5.1 on a windows 2016 datacenter server, i will try to install PowerShell 7 and see if works.
Thanks,
Manoj.

Hello @JustinGrote
I installed PowerShell version 7 and tried to register a vault with a shared location and it worked :) .
Screenshot:

Thanks for your help in resolving this issue.
Thanks,
Manoj.


Handling of multiple overlapping rule sets in the same config

We would like to implement rules for multiple use cases, is in different projects that require different restrictions regarding licenses based on the customer of the project.
A very abstract example would be, external customers require us to exclude any non-permissive license, while we can use most if not all copyleft licenses.
We defined categories for our Use Cases in license-classifications.yml and created rules to return an error if a license is not permitted in one of those Use Cases. This works without problems.
Now for the usability of this config, we would like to provide the ability to specify the Use Case of the projects in regards to ORTs evaluation.
The problem I'm facing is, where and how to define this. Especially, if you want the rule configs to share rules, e.g. the copyleft rules in the example rules file (as warnings). The last thing you want is redundant code, even in a config repo.
From what I understand, the rules can not "import" any secondary files [1], as ORT only reads the rules.kts script and parses it with BasicJvmScriptingHost [2], which does not support "sideloading" as I understand it from this post in the kotlin forum.
Then we checked out resolutions, which do what we want in theory. However, the documentation explicitly tells you not to resolve license rules [3]. Also it currently is not suited for our use case, since we would need a new RuleViolationResolutionReason, which are defined in the code [4] instead of a config file. Right now I do not see the reason for this, as it is just matched against the given reasons and printed for the report, correct? Am I missing something?
We also looked into curations and package-configurations, both of which seem not to fit our needs here.
Maybe we can find a solution for this problem together. Preferably one without redundant rules in multiple config files.
[1] https://github.com/oss-review-toolkit/ort/blob/f506303e98c8d4d672d025e9c785c9c425d26678/cli/src/main/kotlin/commands/EvaluatorCommand.kt#L249
[2] https://github.com/oss-review-toolkit/ort/blob/f506303e98c8d4d672d025e9c785c9c425d26678/utils/scripting/src/main/kotlin/ScriptRunner.kt#L41
[3] https://github.com/oss-review-toolkit/ort/blob/main/docs/config-file-resolutions-yml.md#resolving-policy-rule-violations
[4] https://github.com/oss-review-toolkit/ort/blob/main/model/src/main/kotlin/config/RuleViolationResolutionReason.kt

@pepper-jk I think it best we have a call to discuss you specific rules requirements - it's possible in ORT to write rule where OK / Not OK = code context + license context + delivery context + security context + customer context. However writing these type of rules in the right way requires experience.  See https://github.com/tsteenbe/ how you can reach me.

@tsteenbe that would be great actually. Let me talk to my colleagues on Monday and get back to you. I'll just create a slack account and reach out to you. Maybe we can find a time next week that works for both of us.
Thanks for the fast reply.

Hey @tsteenbe , I sent you an email to your open source address as @pepper-jk . Looking forward to have this discussion.

@pepper-jk  @jens-erdmann  Quick recap of our call today I recommend you adopt 1 rules.kts and use labels -L passed to ORT's Analyzer to which rules to execute. For an example see https://github.com/oss-review-toolkit/ort-config/blob/main/evaluator-rules/src/main/resources/example.rules.kts#L1214-L1242 which has a section of shared rules and a label based switch between PolicyRules.PROPRIETARY_PROJECT and PolicyRules.OSS_PROJECT based on the project=oss-project label passed (see related getEnabledPolicyRules() function in https://github.com/oss-review-toolkit/ort-config/blob/main/evaluator-rules/src/main/resources/example.rules.kts#L123-L127)

Thanks for your help @tsteenbe.
We now use labels for our internal use cases and it works like a charm.
Sorry for the late reply, I don't use my personal GitHub account on my work machine. So every time I thought about replying and closing this issue during the work hours I couldn't and in the evening I forgot. :see_no_evil:


update doc in how to create a user in the command line

Thanks @cpanato for the PR! Can you please resubmit this to the v3.6-documentation branch since this feature is releasing with 3.6 in January?


[Spanner] Improvements to nursing pool back to health.

This is way cleaner.
All tests are green on local.

We now have tests in Google.Apis and it seems to be fine. I guess the only difference is that this won't log errors in the same way that it used to with ConsumeBackgroundTask.

Yes, although we were doing everyting in a try catch in the background task so I think we wouldn't have logged any exceptions anyway, maybe for a very edge case of something happening whe starting the task or similar?
Are you OK with me mergin then? I'm fine either way, the only thing that's really needed is the using statement, and I can add that to the existing code in another PR.

Yes, I'm fine for you to merge :)


convert torch 7 model and get an error :AttributeError: type object 'torch.cuda.FloatStorage' has no attribute 'from_buffer'

wangjian@lhtserver-2:~/wj$ python convert_torch.py -m vgg.t7
Traceback (most recent call last):
File "convert_torch.py", line 286, in
torch_to_pytorch(args.model,args.output)
File "convert_torch.py", line 233, in torch_to_pytorch
model = load_lua(t7_filename,unknown_classes=True)
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 599, in load_lua
return reader.read()
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 584, in read
return self.read_object()
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 514, in wrapper
result = fn(self, *args, **kwargs)
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 537, in read_object
return reader_registry[cls_name](self, version)
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 242, in read_nn_class
attributes = reader.read()
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 586, in read
return self.read_table()
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 514, in wrapper
result = fn(self, *args, **kwargs)
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 563, in read_table
v = self.read()
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 586, in read
return self.read_table()
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 514, in wrapper
result = fn(self, *args, **kwargs)
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 563, in read_table
v = self.read()
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 584, in read
return self.read_object()
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 514, in wrapper
result = fn(self, *args, **kwargs)
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 539, in read_object
return TorchObject(cls_name, self.read())
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 586, in read
return self.read_table()
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 514, in wrapper
result = fn(self, *args, **kwargs)
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 563, in read_table
v = self.read()
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 584, in read
return self.read_object()
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 514, in wrapper
result = fn(self, *args, **kwargs)
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 537, in read_object
return reader_registry[cls_name](self, version)
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 146, in read_tensor
storage = reader.read()
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 584, in read
return self.read_object()
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 514, in wrapper
result = fn(self, *args, **kwargs)
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 537, in read_object
return reader_registry[cls_name](self, version)
File "/usr/local/anaconda2/lib/python2.7/site-packages/torch/utils/serialization/read_lua_file.py", line 165, in read_storage
return python_class.from_buffer(reader.f.read(size), 'native')
AttributeError: type object 'torch.cuda.FloatStorage' has no attribute 'from_buffer'

Where did you download the vgg.t7? You can try check the size of the vgg.t7 and convert torch.cuda.FloatStorage to torch.FloatStorage before using it.
vgg model from https://github.com/jcjohnson/cnn-benchmarks has been tested, you can use this version.

@clcarwin I got the same error. I try to use this library to convert a standalone training model (from my experiments; not vgg). So is that mean I cannot use this library to convert torch.cuda.FloatStorage?

@johnny5550822  convert GPU to CPU model first.
m = torch.load('xxxx.t7')
m = m:float()
torch.save('xxxx.cpu.t7',m)

Got it. Thanks!

Thanks ;)

@johnny5550822 do you get the problem "     'torch.FloatTensor' object has no attribute 'output'   ",how should I do?

@heyalqh did not get this problem. Can you share the screenshot of the code and error?

@johnny5550822

Does this mean that I cannot use the model on the GPU after conversion?
When I do module.cuda() and attempt to evaluate module.forward(data), I get the error:
RuntimeError: expected CPU tensor (got CUDA tensor)

@clcarwin
when i do like this:
m = torch.load('xxxx.t7')
m = m:float()
torch.save('xxxx.cpu.t7',m)

i got an error when save the model. it says:
cannot open './xxx.cpu.t7' in mode w at ./torch/pkg/torch/lib/TH/THDiskFile.c:649
do you know why? thanks~

when I try to convert the following torch net to pytorch,
require 'torch'
require 'nn'
require 'nnx'
require 'optim'
require 'rnn'
function buildModel_MeanPool_RNN(nFltrs1,nFltrs2,nFltrs3,nPersonsTrain)
local nFilters = {nFltrs1,nFltrs2,nFltrs3}
local filtsize = {5,5,5}
local poolsize = {2,2,2}
local stepSize = {2,2,2}
-- remember this adds padding to ALL SIDES of the image
local padDim = 4
local cnn = nn.Sequential()
local ninputChannels = 5
cnn:add(nn.SpatialZeroPadding(padDim, padDim, padDim, padDim))
cnn:add(nn.SpatialConvolutionMM(ninputChannels, nFilters[1], filtsize[1], filtsize[1], 1, 1))
cnn:add(nn.Tanh())
cnn:add(nn.SpatialMaxPooling(poolsize[1],poolsize[1],stepSize[1],stepSize[1]))
ninputChannels = nFilters[1]
cnn:add(nn.SpatialZeroPadding(padDim, padDim, padDim, padDim))
cnn:add(nn.SpatialConvolutionMM(ninputChannels, nFilters[2], filtsize[2], filtsize[2], 1, 1))
cnn:add(nn.Tanh())
cnn:add(nn.SpatialMaxPooling(poolsize[2],poolsize[2],stepSize[2],stepSize[2]))
ninputChannels = nFilters[2]
cnn:add(nn.SpatialZeroPadding(padDim, padDim, padDim, padDim))
cnn:add(nn.SpatialConvolutionMM(ninputChannels, nFilters[3], filtsize[3], filtsize[3], 1, 1))
cnn:add(nn.Tanh())
cnn:add(nn.SpatialMaxPooling(poolsize[3],poolsize[3],stepSize[3],stepSize[3]))
local nFullyConnected = nFilters[3]108
cnn:add(nn.Reshape(1,nFullyConnected))
cnn:add(nn.Dropout(0.6))
cnn:add(nn.Linear(nFullyConnected,128))
-- cnn:cuda()
local h2h = nn.Sequential()
h2h:add(nn.Tanh())
h2h:add(nn.Dropout(0.6))
h2h:add(nn.Linear(128,128))
-- h2h:cuda()
local r1 = nn.Recurrent(
128,
cnn,
h2h,
nn.Identity(),
16)
local rnn1 = nn.Sequencer(
nn.Sequential()
:add(r1)
)
Combined_CNN_RNN_1 = nn.Sequential()
Combined_CNN_RNN_1:add(rnn1)
Combined_CNN_RNN_1:add(nn.JoinTable(1))
Combined_CNN_RNN_1:add(nn.Mean(1))
local r2 = nn.Recurrent(
128,
cnn:clone('weight','bias','gradWeight','gradBias'),
h2h:clone('weight','bias','gradWeight','gradBias'),
nn.Identity(),
16)
local rnn2 = nn.Sequencer(
nn.Sequential()
:add(r2)
)
Combined_CNN_RNN_2 = nn.Sequential()
Combined_CNN_RNN_2:add(rnn2)
Combined_CNN_RNN_2:add(nn.JoinTable(1))
Combined_CNN_RNN_2:add(nn.Mean(1))
-- Combined_CNN_RNN_2 = Combined_CNN_RNN_1:clone('weight','bias','gradWeight','gradBias')
local mlp2 = nn.ParallelTable()
mlp2:add(Combined_CNN_RNN_1)
mlp2:add(Combined_CNN_RNN_2)
-- mlp2:cuda()
local mlp3 = nn.ConcatTable()
mlp3:add(nn.Identity())
mlp3:add(nn.Identity())
mlp3:add(nn.Identity())
-- mlp3:cuda()
local mlp4 = nn.ParallelTable()
mlp4:add(nn.Identity())
mlp4:add(nn.SelectTable(1))
mlp4:add(nn.SelectTable(2))
-- mlp4:cuda()
-- used to predict the identity of each person
local classifierLayer = nn.Linear(128,nPersonsTrain)
-- identification
local mlp6 = nn.Sequential()
mlp6:add(classifierLayer)
mlp6:add(nn.LogSoftMax())
-- mlp6:cuda()
local mlp7 = nn.Sequential()
mlp7:add(classifierLayer:clone('weight','bias','gradWeight','gradBias'))
mlp7:add(nn.LogSoftMax())
-- mlp7:cuda()
local mlp5 = nn.ParallelTable()
mlp5:add(nn.PairwiseDistance(2))
mlp5:add(mlp6)
mlp5:add(mlp7)
-- mlp5:cuda()
local fullModel = nn.Sequential()
fullModel:add(mlp2)
fullModel:add(mlp3)
fullModel:add(mlp4)
fullModel:add(mlp5)
-- fullModel:cuda()
local crit = nn.SuperCriterion()
crit:add(nn.HingeEmbeddingCriterion(2),1)
crit:add(nn.ClassNLLCriterion(),1)
crit:add(nn.ClassNLLCriterion(),1)
return fullModel, crit, Combined_CNN_RNN_1, cnn
end
fullModel, crit, Combined_CNN_RNN_1, cnn = buildModel_MeanPool_RNN(16,32,32,150)
torch.save('Combined_CNN_RNN.t7',Combined_CNN_RNN_1)
But it is not working:
Not Implement nn.Sequencer
Not Implement JoinTable
Not Implement Mean

@clcarwin , when i try to convert the model to use float tensors (the original model was trained on GPUs and CUDA tensors is not usable in the code), I get this error:
[string "m = m:float()"]:1: attempt to call method 'float' (a nil value)
stack traceback:
[string "m = m:float()"]:1: in main chunk
[C]: in function 'xpcall'
/home/dravi/torch/install/share/lua/5.1/trepl/init.lua:679: in function 'repl'
...ravi/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:204: in main chunk
[C]: at 0x00405d50
I'm doing this via the command line 'th', is there any package that is missing and needs to be 'required' for the float tensor conversion?

@stalagmite7 @huntkao  I am having the same issue! Did either of you end up solving this issue?
Thanks a lot!

No, @huntkao and @Spandan-Madan . I finally ended up not going down this route because it was so buggy

@clcarwin
Hi, I have SyntaxError on the line "m = m:float()". How to solve it? Thanks a lot!

In my specific case, this is what happened:-
lua uses tables for all data arrays pretty much. So the only way to find
out if the object is a model itself or a table containing model and other
things is to look inside the table and see what it contains. In my case,
the table object was a list of tables and one of the tables inside it was
the model. So, I indexed inside to the right element. And then converted
that model to CPU using model = model:float() and it worked perfectly.
I know it sounds silly, but give it a shot. You never know you might have
the same problem as me!
On Sat, Aug 18, 2018 at 6:10 PM, dmortem<EMAIL_ADDRESS>wrote:

@clcarwin https://github.com/clcarwin
Hi, I have SyntaxError on the line "m = m:float()". How to solve it?
Thanks a lot!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clcarwin/convert_torch_to_pytorch/issues/8#issuecomment-414096009,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AU8Xo45ExiBYx1z0Y8ItlYXr2WTROPgGks5uSLsDgaJpZM4NjX48
.

@LaiPiXiong Hi, I solved it by put codes into a lua file, not python.

@dmortem Thanks, do you change torch to pytorch successfully? I met error as @stalagmite7. And I try to download xnornet.py but it still show error "string m=m:float() attempt to call method 'float' (a nil value) ".

@LaiPiXiong After I configuring torch environment, I put three sentences in a lua file, and execute it. The model has been converted successfully. And whether you can use this model in Pytorch depends on the original torch model since some torch structures cannot be used in Pytorch, so maybe we still cannot use the converted model.

@dmortem I can't convert it right.  Does "convert_torch.py" also based on torch?

@LaiPiXiong I'm sorry, I didn't convert the model successfully, and my error is "torch.utils.serialization.read_lua_file.T7ReaderException: unknown type id 436207616. The file may be corrupted.". This error is because my model has some different layers which are absent in torch.legacy.
And what I do is to run lua file to convert the model of the GPU version into the CPU version, and then run python file to convert it into a pytorch model.

@dmortem I can't convert model in GPU to CPU version. Do you install luarocks before torch?

@dmortem Hi, I convert torch model to pytorch successfully. I use 'import 'cudnn'' before "m = torch.load(model-name)". I learn this from https://github.com/rwightman/pytorch-planet-amazon/issues/1

@LaiPiXiong It's rather
require 'cutorch'
require 'cudnn'

as it is in lua.

Somebody resolved the problem ?

I have the same issue. Anyone help me please !

I have the same issue. Anyone help me please !

I am  trying to convert this model driveLink from this repo repoLink but it gives  the error
    return python_class.from_buffer(reader.f.read(size), 'native') AttributeError: type object 'torch.cuda.FloatStorage' has no attribute 'from_buffer'
i tried to convert it to cpu but the model wont load using torch with error  magic_number = pickle_module.load(f) _pickle.UnpicklingError: invalid load key, '\x03'.
any help will be appreciated

m = torch.load('xxxx.t7')

I am trying to use this way to convert the model to cpu but torch.load gives this types of error UnpicklingError: invalid load key, '\x03'.


Feature Request: Upstream proxy?

Hi,
I want to hide my request to DNS server also, so I want to route the TCP request coming out of the dnscrypt-proxy to a socks5 proxy. I read the example toml, it said the TCP requests to the upstream server can be routed to tor, but without elaborate. I think it needs a uptream_proxy right after the force_tcp setting.
Thanks

Is it something you could contribute?

Yes, I could. I already read the code and it seems like a minor change (just plug in the socks5 dialer?). But this is my first time using Go, it might take a while.
Thanks.

I'm not very familiar with Go and this is my first project in this language as well, but indeed it looks like it comes with everything we need to support SOCKS.
There's already a dialer defined for HTTP/2 queries (see xtransport.go), so I'm not sure how two dialers could be stacked together, or if there is another way to do it for HTTP.

Thanks, I will check it.
Just want to make sure, all outgoing traffic is handled by functions in xtransport.go, right?

xtransport.go is only for HTTP traffic.

This feature is a great idea, why closing the issue?


Fix issue #298

Coverage decreased (-0.02%) to 99.982% when pulling 1f8651f997b00af32c1453494bfa6c91cd4fb36b on issue_298 into 33cb4afb48a4f798f3771ad32a5f05b4a62eb18e on master.


Evaluation tests failing after qp update

On creating a recent PR today, I saw two of the test_evaluation.py tests are now failing.  I see a new release for qp was created yesterday with some changes that we apparently did not keep up with in a couple of the evaluator stages, we should track those down and fix them.  Problems are namely:

test_pit_metrics calls rail.evaluation.metrics.pit.PITAD, which has
pit = qp.Ensemble(qp.quant_piecewise, data=dict(quants=eval_grid, locs=np.atleast_2d(data_quants)))
causing error
E       AttributeError: module 'qp' has no attribute 'quant_piecewise'
test_evaluation_stage's evaluator.evaluate(pdf, truth) tries to evaluate a CDF and sees multiple x values with the same (0.0) value, and make_interp_spline throws exception:
E           ValueError: Expect x to not have duplicates

It looks like evaluator.evaluate calls a bunch of the deprecated functions that were moved to qp.  Should we clean this up a bit, just remove those deprecated functions and update the rail.evaluation.evaluator.py stuff to call the qp functions?  Or, was there some reason we left things as deprecated and didn't do this earlier?  @drewoldag do you remember why you decided to do things this way?

Actually, do we even need the Evaluator class in rail.evaluation.evaluator.py anymore?  Could we just drop it altogether, and just call the qp stuff directly in the goldenspike notebook?  I think that might be the only place it's used (well that and the demo notebook in examples/evaluation)

The class let’s you put it in a pipeline…-eOn Apr 11, 2023, at 5:24 PM, Sam Schmidt @.***> wrote:
Actually, do we even need the Evaluator class in rail.evaluation.evaluator.py anymore?  Could we just drop it altogether, and just call the qp stuff directly in the goldenspike notebook?  I think that might be the only place it's used (well that and the demo notebook in examples/evaluation)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

My vote would be to call the qp functions….-eOn Apr 11, 2023, at 5:24 PM, Sam Schmidt @.***> wrote:
Actually, do we even need the Evaluator class in rail.evaluation.evaluator.py anymore?  Could we just drop it altogether, and just call the qp stuff directly in the goldenspike notebook?  I think that might be the only place it's used (well that and the demo notebook in examples/evaluation)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Ah, true, having the functions easily pipeline-able is nice. I'll look at swapping out the functions tomorrow.

Re: Evaluator, it's also necessary for the metrics that don't belong in qp, i.e. any that require information beyond the PDFs themselves. That would include the CDE loss and any others that account for the photometry (probably the guts of the Cal-PIT, SOM QC, and other "recalibration" approaches really belong in rail.evaluation, too) as well as those involving point estimates (even if qp can be used to extract those from the PDFs once specified). But rail.evaluation is indeed underdeveloped relative to the other subpackages so probably merits a thorough audit before v1.

@sschmidt23 To you question about why I chose to leave the deprecated methods in pit.py is for the reason that you're noticing here. Basically I tried to find references to the PIT and Brier methods in RAIL and updated those, but I figured there might be some that I missed.
That's in this PR: https://github.com/LSSTDESC/RAIL/pull/283
I used the RAIL implementation of PIT and Brier in the tests (even though they are marked as deprecated) because it doesn't make sense to have unit tests in RAIL to test code in qp. I implemented/ported unit tests to qp for these as well.
I am in favor of removing the deprecated methods and class eventually, my recommendation would be to remove the implementation and replace it with a raised exception or a logger warning directing the user to switch to the qp implementation. And then at a later date (after v1.0?) remove the methods entirely.
But if it makes sense to just yank them out now, then that's cool too :)

This all makes sense, thanks Drew.  I decided to just leave as-is for now, we can decide when to clean this up and remove the deprecated methods at a later date.  I'll go ahead and close this now that the PR is merged.


build:  support Angular version 8 via ng update

Version info

Angular: 7.2.14
Firebase: 5.10.0
AngularFire: 5.1.3 and 5.2.0-beta.4
Other (e.g. Ionic/Cordova, Node, browser, operating system): macOS Mojave
How to reproduce these conditions
Failing test unit, Plunkr, or JSFiddle demonstrating the problem
Angular CLI doesn't run in those environments.

Steps to set up and reproduce

Create a new Angular CLI version 7 project with ng new my-app
add Angular Material with ng add @angular/material
add @angular/fire
try to update the project to Angular version 8 ng update --next @angular/cli @angular/core @angular/material

Sample data and security rules
N/A
<-- include/attach/link to some json sample data (or provide credentials to a sanitized, test Firebase project) -->
Debug output
** Errors in the JavaScript console ** N/A
** Output from firebase.database().enableLogging(true); ** N/A
** Screenshots ** N/A
Expected behavior
The update would succeed.

Actual behavior
The update fails with:
Package "@angular/fire" has an incompatible peer dependency to "zone.js" (requires "^0.8.0", would install "0.9.1").
Incompatible peer dependencies found. See above.

Can the version of zone.js be made a little more flexible to support Angular version 8?
https://github.com/angular/angularfire2/blob/2469e7721ffaea755ab6b95b66610e1495692342/package.json#L53

I added some || pipes to get rid of peers for the other deps, haven't had a chance to give it a spin against the latest. Thanks for the feedback.
Happy to accept a PR here!
Else I'll get to it with the last couple things I want to get to before 5.2 stable release.

^0.8.0 || ^0.9.0 would probably be the direction until we break with v6.0

Closed in https://github.com/angular/angularfire2/commit/f6815bed01e44284f11aa48d976ed8c25ac9c18c.

Thanks again I'll include in the next beta.


Attribute Error: 'NoneType' object has no attribute 'tobytes'

To create a public link, set share=True in launch().
loading weights/Nanami_e600_s2400.pth
gin_channels: 256 self.spk_embed_dim: 109

Traceback (most recent call last):
File "C:\Users\Desktop\Mangio-RVC-v23.7.0_INFER\Mangio-RVC-v23.7.0\infer-web.py", line 316, in vc_single
audio_opt = vc.pipeline(
File "C:\Users\Desktop\Mangio-RVC-v23.7.0_INFER\Mangio-RVC-v23.7.0\vc_infer_pipeline.py", line 564, in pipeline
self.vc(
File "C:\Users\Desktop\Mangio-RVC-v23.7.0_INFER\Mangio-RVC-v23.7.0\vc_infer_pipeline.py", line 450, in vc
(net_g.infer(feats, p_len, pitch, pitchf, sid)[0][0, 0])
RuntimeError: CUDA error: the launch timed out and was terminated
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with TORCH_USE_CUDA_DSA to enable device-side assertions.
Traceback (most recent call last):
File "C:\Users\Desktop\Mangio-RVC-v23.7.0_INFER\Mangio-RVC-v23.7.0\runtime\lib\site-packages\gradio\routes.py", line 437, in run_predict
output = await app.get_blocks().process_api(
File "C:\Users\Desktop\Mangio-RVC-v23.7.0_INFER\Mangio-RVC-v23.7.0\runtime\lib\site-packages\gradio\blocks.py", line 1349, in process_api
data = self.postprocess_data(fn_index, result["prediction"], state)
File "C:\Users\Desktop\Mangio-RVC-v23.7.0_INFER\Mangio-RVC-v23.7.0\runtime\lib\site-packages\gradio\blocks.py", line 1283, in postprocess_data
prediction_value = block.postprocess(prediction_value)
File "C:\Users\Desktop\Mangio-RVC-v23.7.0_INFER\Mangio-RVC-v23.7.0\runtime\lib\site-packages\gradio\components.py", line 2586, in postprocess
file_path = self.audio_to_temp_file(
File "C:\Users\Desktop\Mangio-RVC-v23.7.0_INFER\Mangio-RVC-v23.7.0\runtime\lib\site-packages\gradio\components.py", line 360, in audio_to_temp_file
temp_dir = Path(dir) / self.hash_bytes(data.tobytes())
AttributeError: 'NoneType' object has no attribute 'tobytes'
I need help ;-;)

Ev

I was trying to figure out this issue myself and what worked for me was downgrading the av package. Hope it works for everyone else too.
pip install --force-reinstall -v "av==11.0.0"

doen't work. any other solution?

doen't work. any other solution?

go to infer\lib\audio.py
-> Line 61, replace
open(file, "r") as f:
with:
open(file, "rb") as f:
Hope that does it 👍

It seems that the issue is with the Gradio library. To update the library, run the following command:
pip install --upgrade gradio
Since the new version of Gradio has deprecated concurrency_count, you need to use the new method for setting concurrency limits.
Solution
Remove the concurrency_count parameter: Use Ctrl+F to find where the error is occurring in the code, and replace it with the following:
if config.iscolab:
app.queue(max_size=1022).launch(max_threads=511)
else:
app.queue(max_size=1022).launch(
server_name="<IP_ADDRESS>",
inbrowser=not config.noautoopen,
server_port=config.listen_port,
quiet=True,
)
After making these changes, run the script again, and it should work.

pip install gradio==3.48.0


[added] ability to change default 'ReactModalPortal' class

Changes proposed:

new portalClassName prop to change the ReactModalPortal class.

Upgrade Path (for changed or removed APIs):
Acceptance Checklist:

[x] All commits have been squashed to one.
[x] The commit message follows the guidelines in CONTRIBUTING.md.
[x] Documentation (README.md) and examples have been updated as needed.
[x] If this is a code change, a spec testing the functionality has been added.
[x] If the commit message has [changed] or [removed], there is an upgrade path above.

Thanks for this project!
What do you think about adding this?
I think this is useful because:

code can be cleaner when also using custom content and overlay classnames. If using BEM classes, it makes more sense to have a DOM like .CustomModal > (.CustomModal-content + .CustomModal-overlay) and not like .ReactModalPortal > (.CustomModal-content + .CustomModal-overlay).
my current use case is opening a modal from a content-script in an browser extension. I want to be able to target the portal DOM element precisely in order to prevent conflicts with the page css.

Few questions on my side:

I went with "portalClassName" but I'm not sure if this is really speaking to everyone.
I added a brief sentence about the change in the README but didn't add anything in the examples. I figured the readme change would be enough, but let me know if you don't think so.

Looks good to me and I see no reason this can't go through.


Update threejs toolbar

Fixes issue #1358
Brief summary of changes
Testing I've completed
CHANGELOG.md (choose one)

no need to update because...
updated...

@aymanhab I just tested this in Windows 10 and it is working properly now.

Great, thanks @AlbertoCasasOrtiz


Resizable SplitPageLayout is not discoverable for non-screen reader users

Description
I don't believe the solution to https://github.com/primer/react/issues/2522 works for all users. In https://github.com/primer/react/pull/2593 a hidden focusable input was added to control the width of the SplitPageLayout panes. The purpose of the input is announced to screen reader users, but non-screen reader users have no idea that it is there or what it is for. It's just adding an extra tab stop for them with no visual indication which is confusing. The pane needs to be resizable for keyboard only users who are not using a screen reader as part of WCAG 2.1. A better solution would be to use the aria separator role with accompanying attributes. An implementation of this that works for both screen reader and non-screen reader users can be seen in the ADO component library.
Steps to reproduce

Go to https://primer.style/react/SplitPageLayout#with-resizable-pane
Try tabbing to the hidden input and changing the pane width without a screen reader. There's no indication of where the hidden input is, what values are allowed, or that you have to type a number and hit enter.

Version
v35.20
Browser
Chrome

Just linking this issue here that might be helpful for extra context. https://github.com/github/primer/issues/1865

Thanks for filing @jdrush89! We're actively working on the issue @broccolinisoup linked above, which may help resolve this. If it's not resolved by that issue, we'll keep this in the backlog to pick up after nearer-term accessibility efforts with broader reach (particularly https://github.com/github/primer/issues/1627 & https://github.com/github/primer/issues/1790) have been addressed.

Noting that this issue is blocking completion of an a11y audit issue, which I didn't notice when reviewing it earlier. https://github.com/github/accessibility-audits/issues/3477

Not stale.
I believe there is active exploration happening in https://github.com/primer/react/pull/3903 that might address this; @pksjce would you mind taking a look at the issue described/linked here and see if you can validate whether the splitter approach would resolve this?

Hi @jdrush89 - Thanks for filing this issue. I have been working on making this splitter more accessible and implemented the role=separator as seen on the ADO component library. Unfortunately we got a11y feedback that JAWS + Firefox which is a popular combination is unable to read the respective aria values. I have updated my PR with new guidance and I am awaiting feedback. Will close this issue once my PR gets merged.

Hey @pksjce! With your changes merged in #3903, should we close this out? If so, we can probably ask to get this issue closed out too https://github.com/github/accessibility-audits/issues/3477 :grin:

Yes! This issue is now fixed.


New feature:  ellipse crop

I don't know where to put this, so I just write here.
I'd like to see this directive be able to crop an image into an ellipse shap.
Thanks

ellipse will have rectangle as result, but yes, we can support this. But still, very few cases need it, i don't remember any that i needed it.

As of the plugin being Open Source the best way to tackle your request is to build it yourself @astw
That's what i also been doing when i needed features.

Yes, mostly enhancements are coming from people which need them. No one get payed to build things which they don't need :)

Well fair enough.  Thanks.

Closing the issue since no interaction has been done.
If you want the feature, build it and share it with us.


Add examples from dictionaria

See https://dictionaria.clld.org/sentences

Requires adding raw/cldf and raw/cldf/catalog.csv.


Enable customisation of chromeArgs

We should allow customisation of the chromeArgs settings.
The chromeArgs defaults currently used by the service were defined when looking to fix the DevToolsActivePort file doesn't exist error on CI, so in the first instance we should define which defaults are actually required and for what reasons.
Required args should still be applied by the service but with the option for users to override them if they wish.  There is some logic around which args are applied (CI / non-Windows platforms); the service should use the default for each required arg only when the user has not specified that particular arg.
Additionally, https://github.com/webdriverio-community/wdio-electron-service/issues/47 could be a part of this work.

Verified no args at all are actually required with the current CI setup, so they have been removed.

Released in 4.3.0


Not completed challenges are marked as 'Done'

Hi Team of FreeCodeCamp!
Thank you for really fascinating work you're doing!
But after August update I've encountered an issue.
Now I see that the task I haven't completed yet are marked with green ticks.
Can I update the status of tasks somehow?
For example I haven't already completed sections after Basic Algorithm scripting, but some of them are marked as completed. If you need more complete explanations with screenshots let me know.
Thanks,
Alexander

See, that you know about this problem.
I'll close the issue.
Thank you!


gh-pages branch cleanup

Let's remove unwanted files from gh-pages.

[x] invalid MD files should be removed from jeckyll-docs and keep those files insync with vmware:master

[x] remove unwanted images

[x] remove unwanted yaml files from jeckyll-docs/_data

in short, go through jeckyll-docs and remove unnecessary stuff.

Addressed as part of issue #1861 and #1862


Feat/nocss entry

Separate bundle without styles was released in v8.4.1 https://reactflow.dev/docs/theming/

Separate bundle without styles was released in v8.4.1 https://reactflow.dev/docs/theming/


feat(admin): support ruder admin:init and ruder admin:info

Support ruder admin:init and ruder admin:info
Fixes #12
Signed-off-by: zhuhuijun<EMAIL_ADDRESS>

@Ghostbaby Please help fix the issue.
➜ go run cmd/rudrx/main.go admin:init
Successfully initialized.
➜  go run cmd/rudrx/main.go admin:info
oam-kubernetes-runtime not found in your kubernetes cluster, please use `ruder admin:init` to install.
client  version: UNKNOWN

@zzxwill copy


Nothing in /results after running

There is nothing in ../experiments/results/ after I run tum.sh, is it the only way to visualize by SIBR_viewer? How can I get a traj or .ply file?

I encountered the same issue while running it with Docker.
There is nothing in experiments/results

I also encountered the same problem. There is nothing under the result. Have you solved this problem?

Exporting results are not implemented, but I'm working on it!
It will be added soon.

Exporting results are not implemented, but I'm working on it! It will be added soon.

Looking forward to it! Thanks for your excellent work!

There is nothing in ../experiments/results/ after I run tum.sh, is it the only way to visualize by SIBR_viewer? How can I get a traj or .ply file?

hi~do you successfully use the SIBR_viewer to visualize the result? I can not get any result after I run the ./install/bin/SIBR_remoteGaussian_app --rendering-size 1280 720

Hi, did you launch the slam algorithm before the visualization tool ?


Record duration of geocodings in events

Currently we're storing the creation time but not the duration of the geocoding itself. Regarding metrics and diagnosing it is convenient to add processing time and maybe queue waiting time.

Obviously the original author and I understood timeouts in a different way:
rspec ./spec/models/geocoding_spec.rb:120 # Geocoding#run! raises a timeout error if geocoding takes more than 15 minutes to start

Failures:

  1) Geocoding#run! raises a timeout error if geocoding takes more than 15 minutes to start
     Failure/Error: geocoding.reload.state.should eq 'failed'

       expected: "failed"
            got: "finished"

       (compared using ==)
     # ./spec/models/geocoding_spec.rb:129:in `block (3 levels) in <top (required)>'

This was already done time ago


PollExisting only work once

The first time you make a PollExisting it is working okay. But if you try to perform at a second PollExisting on the same instance nothing is happining. It is at as the subscription is lost after first PollExisting.

Can you reproduce this with a test?

At first I will say that I am quite new to Rx but I am trying to do this
    private BindingList<FileDropped> dataContext;

    [Test]
    public void PollExistingTwice()
    {
        dataContext = new BindingList<FileDropped>();
        using (var watcher = new FileDropWatcher(TempPath, "Monitored.Txt"))
        {
            watcher.Dropped.Subscribe(OnReceiveFileDropped);
            var monitoredFile = Path.Combine(TempPath, "Monitored.Txt");
            File.WriteAllText(monitoredFile, "foo");

            watcher.PollExisting();

            Assert.IsTrue(dataContext.Count > 0);

            dataContext.Clear();

            Assert.IsTrue(dataContext.Count == 0);

            watcher.PollExisting();

            Assert.IsTrue(dataContext.Count > 0);
        }
    }

    private void OnReceiveFileDropped(FileDropped item)
    {
        dataContext.Add(item);
    }

Fixed in adc91c60723a0b47d094eb783e5c1f5a8e63801d

https://www.nuget.org/packages/ReactiveFileSystemWatcher/<IP_ADDRESS>


Update marvin version with Span one and move to shared

Contributes to https://github.com/dotnet/coreclr/pull/16945

What is the performance impact of this change, for small strings in particular?
This implementation avoids unsafe code, but it is slower and less portable (assumes that the platform supports unaligned access). We have thousands of lines of unsafe code like the one you are removing in low-level routines to get extra bit of performance and to make the code more portable: https://github.com/dotnet/corert/blob/master/src/System.Private.CoreLib/shared/System/SpanHelpers.Byte.cs . Why do we want to make this different?

Why do we want to make this different?

My motivation was to only have one Marvin implementation as we are moving the Span version into the shared folder in coreclr which is used by CompareInfo.

I think we need to understand what we are losing by doing so.

I think we need to understand what we are losing by doing so.

Don't we already have measurements and figures about the same change in corefx (from ptr to Span) (https://github.com/dotnet/corefx/pull/25735)? If my head serves me right I can remember Dan mentioning that this change in corefx also regressed perf.

30% slower where slowest cases are around 8-15 bytes

I do not think that this regression is acceptable for String.GetHashCode

I agree. To get the coreclr PR in for now I will remove the latest commit that switches to Marvin for string.GetHashCode and then we can continue exploring options here.

Sounds good.

As the coreclr PR is now merged into master, the changes will soon come into corert. We could keep both implementation (either by renaming or converging) or try to optimize the Span version further?

We should have just one implementation. To get the mirror PR built, I would add a helper method to the CoreRT implementation that takes Span and forwards it to what's there.

I had to deal with this in https://github.com/dotnet/corert/pull/5557 to fix the build break and unblock the mirror.


CoreDNS not working

Environmental Info:
K3s Version:
k3s version v1.20.5+k3s1 (355fff30)
go version go1.16.2
Node(s) CPU architecture, OS, and Version:
Linux raspberrypi1 5.10.17-v7l+ #1403 SMP Mon Feb 22 11:33:35 GMT 2021 armv7l GNU/Linux
Cluster Configuration:
4 nodes: 1 master, 3 agents
Describe the bug:
Overnight, my cluster stopped being able to resolve external hostnames.  CoreDNS logs show the following:
[ERROR] plugin/errors: 2 github.com.telenet.be. AAAA: dial udp [2a02:1800:100::41:2]:53: connect: network is unreachable
[ERROR] plugin/errors: 2 github.com.telenet.be. A: read udp <IP_ADDRESS>:36102-><IP_ADDRESS>:53: i/o timeout
[ERROR] plugin/errors: 2 index.docker.io. AAAA: read udp <IP_ADDRESS>:40000-><IP_ADDRESS>:53: i/o timeout
[ERROR] plugin/errors: 2 index.docker.io. AAAA: dial udp [2a02:1800:100::41:1]:53: connect: network is unreachable
[ERROR] plugin/errors: 2 quay.io.telenet.be. AAAA: dial udp [2a02:1800:100::41:2]:53: connect: network is unreachable
[ERROR] plugin/errors: 2 quay.io.telenet.be. A: dial udp [2a02:1800:100::41:2]:53: connect: network is unreachable
[ERROR] plugin/errors: 2 quay.io.telenet.be. AAAA: dial udp [2a02:1800:100::41:1]:53: connect: network is unreachable
[ERROR] plugin/errors: 2 quay.io.telenet.be. A: dial udp [2a02:1800:100::41:1]:53: connect: network is unreachable
[ERROR] plugin/errors: 2 quay.io. AAAA: dial udp [2a02:1800:100::41:1]:53: connect: network is unreachable
[ERROR] plugin/errors: 2 quay.io. AAAA: dial udp [2a02:1800:100::41:2]:53: connect: network is unreachable
[ERROR] plugin/errors: 2 quay.io. A: read udp <IP_ADDRESS>:41973-><IP_ADDRESS>:53: i/o timeout
[ERROR] plugin/errors: 2 quay.io. A: dial udp [2a02:1800:100::41:2]:53: connect: network is unreachable

telenet.be is my ISP.  Name resolution in the nodes:
cat /etc/resolv.conf
# Generated by resolvconf
search telenet.be
nameserver <IP_ADDRESS>
nameserver 2a02:1800:100::41:2
nameserver 2a02:1800:100::41:1

To the best of my knowledge, that hasn't changed.
Steps To Reproduce:

Installed K3s:

Master installed as follows:
curl -sfL https://get.k3s.io | sudo INSTALL_K3S_EXEC="server --tls-san <> --disable traefik" sh -
Agents installed as follows:
curl -sfL https://get.k3s.io | sudo K3S_URL=https://<IP_ADDRESS>:6443 K3S_TOKEN= sh -
Expected behavior:
CoreDNS should resolve external hostnames
Actual behavior:
It doesn't.
Additional context / logs:
Nothing special in syslog, etc.
Tried rebooting the cluster, but got the same behaviour.
Switched back to legacy iptables & iptables6, (with reboot), but got the same behaviour.

Update:  things tried:

rebuild the cluster (no change)
disabling IPv6 (no change)
setting DNS resolution to use only <IP_ADDRESS> and <IP_ADDRESS>:

cat /etc/resolv.conf
# Generated by resolvconf
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>

After that, things started working again.  No clue why (as DNS resolution was working fine outside of the cluster).  Will leave this open if you want to investigate further.

IPv6 does not work within the cluster, and K3s will actively work to ensure that you don't have IPv6 servers in the resolv.conf used by pods so I'm not sure how coredns ended up trying to use those servers.


feat: add tab bar header navigation

Description
Adds the top navigation for tab navigation screens. In the screen shots below, the header is the main point of focus as different wallets were used to take enabled and disabled screenshots. Header icons were adjusted to allow for ripples on tap on Android and a few changes had to be made to keep alignment with the existing side DrawerTopBar.tsx.
Screenshots

Android Disabled
Android Enabled
iOS Disabled
iOS Enabled

Test plan

[x] Tested locally on iOS
[x] Tested locally on Android
[x] Unit tests added

Related issues

Fixes #ACT-1108

Backwards compatibility
Yes
Network scalability
N/A

@satish-ravi in regards to keeping the TopBarIconButton.tsx it was used in too many other places to justify removing it in this PR. The main reason not to use is its lack of handing Android ripples. There are some notes in src/components/BackButton.tsx from @jeanregisser about what it took to get the ripple correct and it requires placement specific styling and seems like a general hassle.  In my opinion we should create a better Icon wrapper and deprecate TopBarIconButton.tsx in a separate PR / ticket.

@satish-ravi in regards to keeping the TopBarIconButton.tsx it was used in too many other places to justify removing it in this PR. The main reason not to use is its lack of handing Android ripples. There are some notes in src/components/BackButton.tsx from @jeanregisser about what it took to get the ripple correct and it requires placement specific styling and seems like a general hassle. In my opinion we should create a better Icon wrapper and deprecate TopBarIconButton.tsx in a separate PR / ticket.

that sounds good. Can we mark this deprecated now and link to a placeholder issue so no new stuff is added that uses this?


Adding http://www.learn-angular.fr to resources

Hi,
Can i propose a PR to add les link http://www.learn-angular.fr to angular resources ?  This blog is a set a courses about Angular.
It's in french.
Thank you in advance.
William

Hi,
@StephenFluin, are you ok to add this link to Angular ressources ?
ty
William

@wKoza I've added you to the index temporarily, but please be aware that list list is undergoing changes, and will soon be reduced in number of posts and refocused on more traditional courses rather than self-driven blog style content.

thanks @StephenFluin !


Updated Newtonsoft.Json from 8.0.3 to 9.0.1

Our Newtonsoft.Json versions were all over the place. This puts all solutions and all projects on, the expected, 9.0.1

Hi @thecodejunkie, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;


ERROR: unable to create file docs

I am trying to add Security Guidelines to Eclipse site, but I'm facing issue with git cloning.
I'm using Windows.

@FaGru3n Hi Fabian, sorry to bother you, but maybe you know who can be helpful with this issue?

I guess this looks like there is a little problem with your git config.
Maybe git config --global core.longpaths true or some similar windows cmd will work. see for example https://github.com/dart-lang/pub/issues/3803

it worked! thanks :)


adds support for anonymous azure blobs

replaces #172 for #168
/assign ellis-bigelow

This change is

Resolved nit and integration tested with tensorrt... will the initializer container magically update?

/hold (found a bug)

fixed (now omits prefixes from dest path)

/lgtm
/approve


Can I specify a list in the 'database' field?

I have created many databases under a database management software. Of course, their host, username, and password are the same. Can I specify a list in the 'database' field?

NO, by currently design, one database with on model.

Then, is there a way that I don't have to repeatedly specify the host, username, and password?

You can try using the YAML default function to put the configuration of the same data into default.
For example:
app_db_default: &app_db_default
  type: mysql
  host: localhost
  port: 3306
  username: root
  password: root

models:
  my_app:
    databases:
      my_app:
        <<: *app_db_default
        database: my_app_db1
      my_app2:
        <<: *app_db_default
        database: my_app_db2

thanks a lot!


[WFLY-18817] Test that provisioning channel information is logged at boot

https://issues.redhat.com/browse/WFLY-18817
This builds on #17248 by adding an additional test method to the test added there. But I needed to rework the way provisioning is done to get it to work.
Requires https://github.com/wildfly/wildfly-core/pull/5724

@bstansberry do you foresee more tests requiring prospero in the Wildfly testsuite? I'm wondering if it would be better to create a mock prospero module that could be added to the provisioned server to test the integration up to the API level and test the implementation in prospero codebase instead. This way we could avoid adding dependency on prospero to Wildfly codebase

@spyrkob Potentially, yes. The management integration @yersan did could be tested in WF.
Some kind of integration TCK for that that could executed in both places would make sense.

https://github.com/wildfly/wildfly/pull/17470/files#diff-ab7939563ab2ed2a32ec4f069f5755fe052e9555777de64f3c0dbe8489bbdde3R455-R467 -- otherwise it fails to resolve org.jboss.universe:community-universe and org.jboss.universe.provider:wildfly-providers when installing the Prospero FP.

The problem here is that when creating the prospero-wildfly-galleon-pack feature pack, the reference to org.wildfly:wildfly-ee-galleon-pack becomes <dependency location="wildfly-ee@maven(org.jboss.universe:community-universe):current#30.0.0.Final">. To resolve this back to maven coordinates, Galleon requires universe artifacts. Maybe we could add an option to the wildfly-galleon-maven-plugin to preserve the maven GA of the dependencies? Alternatively the wildfly channel could define the universe artifacts.

https://github.com/wildfly/wildfly/pull/17470/files#diff-ab7939563ab2ed2a32ec4f069f5755fe052e9555777de64f3c0dbe8489bbdde3R440 and the same in all the other executions. Otherwise each execution hangs for 15 secs after CliMain completes and then exec-maven-plugin warns about 2 daemon threads that don't respond to interrupt.

This seems to be an issue with jgit implementation. It creates some daemon thread in an executor that is never shutdown. I created https://github.com/wildfly-extras/prospero/issues/517 to track it and I'll try to submit a fix upstream.

Thanks for the analysis, @spyrkob. I added the test I need to https://github.com/wildfly/wildfly-core/pull/5724, and the other uses of integrated-prospero are also there.
I started a zulip thread where we can talk about how to handle the universe thing:
https://wildfly.zulipchat.com/#narrow/stream/174184-wildfly-developers/topic/Defining.20Galleon.20universe.20artifacts.20in.20a.20WF.20channel
So, given all that I'll close this. I'll leave the branch for a while though, in case it's useful in some way.
I don't see a need for this test in WF, although something like it in prospero's TS might make sense, as I surfaced a few issues by doing it.


Approval voting

With given radius

https://github.com/frcroth/elections/commit/c5df504f8c416c359b84c8e0aee138374ee73a8c

Radius is currently not editable


Fix *_Twh key names

The schema of the data added in https://github.com/mlco2/codecarbon/commit/4949003f1599c2b7a5b29c5571ffcc9adcdde7dc is different from before, breaking untyped code.

_TWh suffixes was changed to _Twh
geothermal_TWh data is no longer provided

While I fixed what was necessary to get things working, I did not bother fixing https://github.com/mlco2/codecarbon/blob/master/codecarbon/data/private_infra/our_world_in_data-2021_data.ipynb which is now out-of-date and misleading.

Oops, sorry duplicate of https://github.com/mlco2/codecarbon/pull/424


Universal on the Bootstrap branch?

I see that universal was removed from the Bootstrap branch. Any particular reason? Seems like it would be as useful for Bootstrap as it is for Material Design.

It wasn't compatible with Universal when I created it and I didn't know if there were any plans to make it compatible, but I think they say it's supposed to be compatible with it now. I suppose I can can add another branch that has them together when I have time.


add simple carousel for react native

simple dynamic carousel for react native

Keep up the Good Work! ❤

thank you bro


PSbot Inquiry

Hey @taylorhansen  you have done some good work on this project! I am thinking about creating a Pokemon Showdown AI as well, and I would love to build off some of your work here, namely PSbot. Would you be interested in the idea of separating your PSbot code into a separate repo so that my project can also interface with it? Please let me know soon, if possible. Thank you!

Thanks for taking interest. I was thinking of doing something like that at
some point. Will look into it this week.
On Sun, Jul 7, 2019 at 1:38 PM acxz<EMAIL_ADDRESS>wrote:

Hey @taylorhansen https://github.com/taylorhansen you have done some
good work on this project! I am thinking about creating a Pokemon Showdown
AI as well, and I would love to build off some of your work here, namely
PSbot. Would you be interested in the idea of separating your PSbot code
into a separate repo so that my project can also interface with it? Please
let me know soon, if possible. Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/taylorhansen/pokemonshowdown-ai/issues/68?email_source=notifications&email_token=ADHLMI3HVJYA5J4T2NT6NZ3P6JH4XA5CNFSM4H6WRURKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5XGLFA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADHLMI35P4E4BHUN2KA7THTP6JH4XANCNFSM4H6WRURA
.

Thanks so much! Maybe our project will be able to contribute to PSbot as well.

While it would be nice to separate code into separate repositories, this would make it more difficult to manage cross-project changes (e.g. API refactoring). I think I'll keep this as a monorepo for now. I'm opening #70 for later once the codebase is mature enough.
If you would like to use code from this project, I suggest using a git submodule in some lib/ folder for now. Then you can build the project and import what you need, similar to what I did with Pokemon-Showdown's server and sim code.

I see that is understandable, thank you!


Feature: Add config.yml and styles.yml File for Raising Enhancement Requests Separately

Feature description
style.yml (Custom ISSUE_TEMPLATE):

The style.yml file, on the other hand, serves as a custom ISSUE_TEMPLATE for issues related to coding style, code formatting, and linting rules within your GitHub repository. This template helps contributors or users report code style-related concerns or seek guidance on adhering to the project's coding standards.
The contents of style.yml might include specific questions or prompts related to coding style, requesting users to provide examples of code snippets that need formatting adjustments or explanation. Additionally, you might include instructions on how to check code against the project's style guidelines and best practices.

👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Hi @rohanbabbar04 . Please Review on this Issue as soon as Possible. Thank You !

I did'nt understand it fully...
What is the use of config.yml ?
Also is the style.yml going to generate issue templates and fail if someone does'nt follow that?

I did'nt understand it fully...
What is the use of config.yml ?
Also is the style.yml going to generate issue templates and fail if someone does'nt follow that?

See @rohanbabbar04 .For Raising Enhancement related Issues , this styles.yml Issue Template is Simple Choice.Coming to config.yml , In this file, we can write to allow Blank Issues.These two files are used in lot of Repositories in this Open source program.So, that's why I am raising this Issue.Ofcourse, aa your project requirements basis on take your decision.Thank You👍

Any Updates on this Issue @rohanbabbar04


Unexpected token s in JSON at position 2

Question, im wondering how you work with alphine js inside the editor? When i use it on alway getting a error on a block that uses alphine js.
It seems im getting a json error on the x-data="{ }" part. Dont you have this, or is there a workaround that you implemented?

Hi! Alpine code should work in the visual editor. Can you provide code that I can test?

I'm closing this issue. Please re-open if you'd like me to look into this more.


Chromium Just Waits Forever On First Sync

Hi,
Chromium Version 69.0.3497.100 (Official Build) Arch Linux (64-bit)
xBrowserSync extension 1.4.0 from the store
When trying to create a new sync, it just waits forever with the "Do not close this window" message.
The background.html page for the extension has the following errors:
background.html:1 Error in response to bookmarks.getSubTree: TypeError: Cannot read property '0' of undefined
    at Object.callback (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:3327:30)
    at getLocalBookmarkTreeById (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:3326:30)
    at Object.getBookmarks [as Get] (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:2878:29)
    at sync_handlePush (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:2320:47)
    at sync (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:2136:27)
    at Object.queueSync [as Sync] (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:1879:9)
    at chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:3673:30
    at chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:140:44
background.html:1 Unchecked runtime.lastError while running bookmarks.getSubTree: Can't find bookmark for id.
    at getLocalBookmarkTreeById (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:3326:30)
    at Object.getBookmarks [as Get] (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:2878:29)
    at sync_handlePush (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:2320:47)
    at sync (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:2136:27)
    at Object.queueSync [as Sync] (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:1879:9)
    at chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:3673:30
    at chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:140:44

No worries. Let me know if there's anything else I can provide to help debug.
P.S. and congrats. Hope everything goes smooth.

Hi @evmcl, after some investigation I can't see why getLocalBookmarkTreeById would be being called with an id that does not exist (only the root children folders are called here, i.e. Bookmarks bar:2 and Other bookmarks:1). As I do not have Arch Linux, I've prepared a beta release that contains additional logging in getLocalBookmarkTreeById to reveal the local bookmark id that is being requested when the error occurs.
Could I possibly ask you to install the .crx file attached to the release, enable debug mode in xBrowserSync settings, then try creating a release? You can then copy the debug mode message log out of xBrowserSync or grab the output from the background.html console.
Please paste here so I can understand what's going on! 😄

Hi.
I've run as requested. The output is below.
On a lark, I tried running with a new profile and it worked fine, so there's something in my existing profile that is causing the issue. I will do some further analysis on my end.
In the meantime, here is the output from when it fails:
background.min.js:1395 getLocalBookmarkTreeById: 2
background.min.js:1395 getLocalBookmarkTreeById: 1
background.html:1 Error in response to bookmarks.getSubTree: TypeError: Cannot read property '0' of undefined
    at Object.callback (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:3326:30)
    at getLocalBookmarkTreeById (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:3325:30)
    at Object.getBookmarks [as Get] (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:2876:29)
    at sync_handlePush (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:2318:47)
    at sync (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:2134:27)
    at Object.queueSync [as Sync] (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:1877:9)
    at chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:3672:30
    at chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:140:44
background.html:1 Unchecked runtime.lastError while running bookmarks.getSubTree: Can't find bookmark for id.
    at getLocalBookmarkTreeById (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:3325:30)
    at Object.getBookmarks [as Get] (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:2876:29)
    at sync_handlePush (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:2318:47)
    at sync (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:2134:27)
    at Object.queueSync [as Sync] (chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:1877:9)
    at chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:3672:30
    at chrome-extension://lcbjdhceifofjlpecfpeimnnphbcjgnc/js/background.min.js:140:44

@evmcl ok so that's failing when using the chromium API to get the bookmarks sub tree for "Bookmarks bar" (id 1). Do you have any bookmarks in the bookmarks bar, and does it appear under chrome://bookmarks like so:

Yes, I have a fair number of bookmarks on my bookmarks bar. The folder structure looks like this:

Yeah that looks fine, can't for the life of me understand why the native bookmarks API is saying Can't find bookmark for id when it's being passed the native ids for Bookmarks bar and Other bookmarks!
Are you able to create a backup in xBrowserSync Settings (you don't have to be synced to create a backup)? If so, would you be willing to email it to me so I can debug what's happening - could be something in your bookmarks as you mentioned it works with a new profile.

I think I've come up with a minimum viable repeat of the issue. Attached is the Bookmarks file from my profile (zipped). I deleted all my bookmarks so this only has the three basic root folders.
If you create a new profile, then copy this Bookmarks file into it, then try installing xBrowserSync and syncing you'll reproduce the error.
Bookmarks.zip

@evmcl that backup shows the other bookmarks id as "4656" when it should be "2". As far as I'm aware, both the bookmarks bar and other bookmarks root nodes cannot be modified so I'm not sure how you ended up in that situation but it looks corrupted to me. Are you able to get a fresh profile to get into this state?
Also, how did you generate that JSON backup file from Chromium? I thought it could only export as HTML?

how did you generate that JSON backup file from Chromium?

I didn't. I just copied the ~/.config/chromium/Default/Bookmarks file directly out of my profile.

Are you able to get a fresh profile to get into this state?

As I was using my bookmarks in Firefox as my canonical copy, I just deleted the above Bookmarks file and synchronised, so I am all up and running now. Feel free to close this issue if you think there is nothing further to be done.
Thanks for all your help.

Ah I see. Ok glad the issue has now been resolved!


Any way to change the download speed for the song?

I open a video and the download speed is really low on AIMP.
The song is reaching the buffer size really fast and the song keeps breaking / interrupting.
I don't see a way to change it.

I was having this problem since a long and i realized that the plugin it's fine but the youtube-dl.exe in the plugin folder is the reason for slow download speed. I reemplazed that .exe with the yt-dlp.exe (another fork of youtube-dl) and now works fine.
don't know if this can help you or if it's the right solution for your problem but it works for you.

Seams to working for now. Thanks

Am aceeasi problema. Nu stiu sa o rezolv,ma puteti ajuta?

Like i said, you need to remplace the youtube-dl.exe in the plugin folder with the yt-dlp.exe, but you need to rename the yt-dlp.exe to youtube-dl.exe. Make a backup of the original and then remplace it.
In theory they have the same features and the same code, more or less.

Oh,thank you so much <3


Add support for Alias in IngressRoute

Fixes #451 by adding support for Aliases inside IngressRoute documents. Any alias defined is appended to the RDS domains array.
Signed-off-by: Steve Sloka<EMAIL_ADDRESS>

@davecheney I rebased and also added suppport for aliases in Secure VHosts since that was merged. Thanks!


Remove blocking modal overlay

First things first i want to say thank you guys for what are you doing for people. As megacorps like Google become more greedy, people forced to create solutions to save their money on a voluntary basis. Thank you
So, theres an issue (at least in google chrome) with overlay layout which is not dissapearing after popup is hidden. You can't interact with page at all. Neither scroll nor clicks don't work. This simple solution is created to hide this all-blocking overlay.

Thank you for your pull request! It's great to see you addressing this issue.


Add README.md

Solving: https://keboola.atlassian.net/browse/COM-365
Changes:

Added README.md

Thanks. I'm pretty weak in English.

not at all!  on the contrary, it's really good!


Update function corections

Choosing Note to update and putting nothing the Note is empty. The note should not be empty.  Maybe some validations.

Added some validations to prevent empty slots.


Track 'VAPTCHA'

Vendor Site - https://en.vaptcha.com
Example Site: http://deepfacedrawing.geometrylearning.com/index_EN_621.html
Category - Security
Detection - Script imported from https://v.vaptcha.com/v3.js

Hey @John4266 , added to security category. Do you have pricing information for this product?

Hey @John4266 , added to security category. Do you have pricing information for this product?

uh there is at least a Free version, tho i dont have info about the other pricing plans.

Hey @John4266 , added to security category. Do you have pricing information for this product?

uh there is at least a Free version, tho i dont have info about the other pricing plans.

ok, thanks!!


Cannot find OpenSSL's libraries

I've tried my luck with google and nothing came up.
Whenever I run "phpbrew install 5.5.19 +default +mysql +fpm"
I get the following error: configure: error: Cannot find OpenSSL's libraries
I'm running CentOS 6.6 with cPanel. I'm trying to use phpbrew in combination with nDeploy.
OpenSSL should be installed in /usr/bin/openssl
The version is: openssl-1.0.1e-30.el6_6.4.x86_64
Any help would be greatly appreciated!

@c9s @marcioAlmada @xreeckz @mfham
phpbrew install 5.5.19 +default +mysql +fpm +openssl=/usr -- --with-libdir=lib64 solves the issue. The point is that we must specify --with-libdir=lib64 with +openssl=/usr. The reason why it needs --with-libdir=lib64 is described at https://gist.github.com/shinnya/beb7c5f0e64c19dcb940.

@c9s @marcioAlmada @xreeckz @mfham
phpbrew install 5.5.19 +default +mysql +fpm +openssl=/usr -- --with-libdir=lib64 solves the issue. The point is that we must specify --with-libdir=lib64 with +openssl=/usr. The reason why it needs --with-libdir=lib64 is described at https://gist.github.com/shinnya/beb7c5f0e64c19dcb940.

The same solution is mentioned at http://php.net/manual/en/image.installation.php#105155.

The same solution is mentioned at http://php.net/manual/en/image.installation.php#105155.

The solution of @shinnya works for me also. Installing PHP on a 64-bits Fedora install works with the following command: phpbrew install 5.428 +default +mysql +fpm +openssl=/usr -- --with-libdir=lib64

This simply works for me on fedora too: phpbrew install 5.428 +default +mysql +fpm +openssl

On FreeBSD, need to use:
phpbrew install 5.5.32 +default +openssl=/usr/local

To compile a PHP 5.5.38 on i386 (with phpbrew 1.22.5) I still had to create a link to prevent this error:
cd /usr/lib
ln -s i386-linux-gnu/libssl.so

This is on Debian "Jessie".

For googlers:  to get past this openssl error on Ubuntu 16.10, trying to install 5.6.5 with just +default required  -- --with-openssl.  No dir prefix required, no +openssl required.

I'll put the Fedora solution into  the Cookbook.

+default  -- --with-openssl works on Ubuntu for 5.3.4 also.

It got past the openssl error but produced a new one
Makefile:510: recipe for target 'ext/openssl/openssl.lo' failed
phpbrew install -j $(nproc) --old 5.4 +default -- --with-openssl

For MacOS also this works:
export OPENSSL_CFLAGS=-I/usr/local/opt/openssl/include
export OPENSSL_LIBS=-L/usr/local/opt/openssl/lib

phpbrew ext install openssl


Update client3:akka-http-backend, ... to 3.5.0

Updates

com.softwaremill.sttp.client3:akka-http-backend
com.softwaremill.sttp.client3:core

from 3.3.18 to 3.5.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #319.