MkDocs - theme

Change the mkdocs theme to resemble the vizzu lib doc site https://lib.vizzuhq.com/0.4/

[x] colors, font-sizes
[x] add vizzu logo, favicon
[ ] add social logos/links
[ ] syntax highlight

github image background in the menu is still blue (mobile view)

Syntax highlighting is poor

Syntax highlighting is poor

I changed pygments to highlightjs because it provides more freedom.
We cannot use both, because I did not find a way to select languages in mkdocs highlight plugin api.
python code snippet highlights are the same with highlightjs, but javascript snippets are better.
still need to set some colors in the css to fully highlight the code reference.


add: IQL Example

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jemma Daniel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Deployment issue when using Azure Devops

I´m running into this error, when trying to deploy the Contoso Enterprise Scale via Release Pipeline:
Deployment template validation failed: 'The template resource 'policydeployment' at line '1' and column '4592' is not valid: The language expression property 'location' doesn't exist, available properties are 'name, properties'.. Please see https://aka.ms/arm-template-expressions for usage details.
This seems to be the "breakpoint" with the policy template:

Any hint what the issue could be?

Can you point me to the exact file you are trying to deploy?

Can you point me to the exact file you are trying to deploy?

https://github.com/Azure/Enterprise-Scale/blob/main/docs/reference/contoso/armTemplates/auxiliary/policies.json
I´ve uploaded all files to a Repo inside my DevOps project and run the main es-vwan.json for deployment.

Pls note that all these templates are crafted in a way where they are optimized for portal deployment experience as we are doing multiple (conditional) linked template deployments - which we cannot do using templates deployed from local machine/pipeline. I'd recommend you deploy via portal, and if you want to transition to IaC later, you can connect AzOps to your tenant after the fact.


Can't navigate to multi-word headers using the navigation

You can't navigate to a multi-word header (e.g. "Artificial Intelligence" or "Machine Learning") using the navigation section at the top on fffaraz.github.io/awesome-cpp/.
This is because the words in the href attributes of the navigation are split with "-" (e.g. a 'href="#machine*-*learning"') but the section ids don't have anything between the words in their id attributes (e.g. '<h2 id="machinelearning"').

:+1:

I find it interesting to note that when displaying the README.md on Github, the anchors work, while they don't work on http://fffaraz.github.io/awesome-cpp/.
The HTML code differs:

Standard Libraries
 on http://fffaraz.github.io/awesome-cpp/, vs
 [...] on here.
There seem to be two different Markdown renderers at work?

Yes, I have used (probably an old version of) showdown.js.
https://github.com/showdownjs/showdown
Please take a look at the gh-pages branch of this repo.


React 17  workaround doesn't work anymore

Hi,
I don't know if it's because of the Win 11 update or VSCode but using "_" doesn't work anymore. eg : _rfce shows nothing.
Thank you.

@radoRandriamahandry there is no _. Instead you have settings for react top import.

Ok, didn't read the doc, Thank you for your help.


Doc Feedback:

Location : https://apim.docs.wso2.com/en/latest/InstallAndSetup/SettingUpDatabases/ChangingDefaultDatabases/changing-to-mysql/
Why do you not indcate the other databases in use that you can configure, like carbondb etc.
This setup still shows h2 on the management UI since carbon is still on h2

@Bhashinee , can you please share your opinion on this Git issue.

@robbla Carbon DB is an internal DB and the user is not expected to change it in APIM 3.0 onwards.


Set custom user agent for outbound requests

Description

It would help when debugging traffic to distinguish between different Golang clients. We may need to make a change to go-tuf to pass the custom user agent.

This was done in https://github.com/sigstore/sigstore-go/pull/216


Usage of std::this_thread::sleep_for isn't supported by all GCC versions

eg. test/cpp/end2end/end2end_test.cc:99:9: error: ‘sleep_for’ is not a member of ‘std::this_thread’ under 4.6.4.
Should be using gpr_sleep_until() instead

Also not available under VS2010, as an FYI.

Thanks. Even more of a reason for the change :)

Part of #1689


Export to gzip appends status line

When using the documented way to export data and compress it with gzip the status line is added which makes the output file no valid JSON
Thu, 27 Aug 2015 13:36:24 GMT | Total Writes: 2177

I see the same problem.

Will be solved by https://github.com/taskrabbit/elasticsearch-dump/pull/112.  Thanks for reporting!


Bug: field name conflicts with keyword is surprising

Kùzu version
No response
What operating system are you using?
No response
What happened?
field name conflicts with keyword. This will make it difficult in real world scenarios.
kuzu> create node table acme(id string, call string, primary key(id));
Error: Parser exception: mismatched input 'call' expecting PRIMARY (line: 1, offset: 34)
"create node table acme(id string, call string, primary key(id))"

Are there known steps to reproduce?
No response

The issue has been fixed in our latest master, please compile kuzu from source, or use our python nightly build package


JedisClusterInfoCache renewClusterSlots() is not thread-safe

Expected behavior
correct double-checked locking used on renewClusterSlots()
Actual behavior
In rare conditions renewClusterSlots() could be executed multiple times, if several threads are triggering it at almost the same time.
Steps to reproduce:
couldn't reproduce
Jedis version:
2.9.0
Description:
since the condition if (!rediscovering) is not checked again inside the locked block, it's not totally thread-safe.
It should actually look like this:
if (!rediscovering) {
      try {
        w.lock();
        if (!rediscovering) {
           rediscovering = true;
           ...

See https://github.com/xetorthio/jedis/pull/1856

Closed by #1856


Problem with mutation analysis Time 9f

Hi, I have some issues when running mutation analysis on Time 9f
defects4j mutation -w ~/time_9f -s ~/evosuite_time_9f_mutationOrg/Time/evosuite-weakmutation/1/Time-9f-evosuite-weakmutation.1.tar.bz2 -i ~/time_9b/instrument_classes_time9b
[junit] MAJOR: org.joda.time.Chronology_ESTest[test00] failed!
	[junit] MAJOR:  -> java.lang.NoSuchMethodError
	[junit] MAJOR:  -> "org.joda.time.chrono.ISOChronology.withEra(Lorg/joda/time/LocalDateTime;I)Lorg/joda/time/LocalDateTime;"
	[junit] MAJOR: org.joda.time.Chronology_ESTest[test02] failed!
	[junit] MAJOR:  -> java.lang.NoSuchMethodError
	[junit] MAJOR:  -> "org.joda.time.Chronology.fromDateFields(Ljava/util/Date;)Lorg/joda/time/LocalTime;"
	[junit] MAJOR: org.joda.time.Chronology_ESTest[test03] failed!
	[junit] MAJOR:  -> AssertionFailedError
	[junit] MAJOR:  -> "expected same:<10:32:12.196> was not:<10:32:21.196>"
	[junit] MAJOR: org.joda.time.Chronology_ESTest[test04] failed!
	[junit] MAJOR:  -> java.lang.NoSuchMethodError
	[junit] MAJOR:  -> "org.joda.time.chrono.ISOChronology.withDayOfMonth(Lorg/joda/time/LocalDateTime;I)Lorg/joda/time/LocalDateTime;"
	[junit] MAJOR: org.joda.time.Chronology_ESTest[test05] failed!
	[junit] MAJOR:  -> java.lang.NoSuchMethodError
	[junit] MAJOR:  -> "org.joda.time.chrono.GJChronology.minusDays(Lorg/joda/time/LocalDateTime;I)Lorg/joda/time/LocalDateTime;"
	[junit] MAJOR: org.joda.time.Chronology_ESTest[test06] failed!
	[junit] MAJOR:  -> java.lang.NoSuchMethodError
	[junit] MAJOR:  -> "org.joda.time.chrono.GJChronology.minusDays(Lorg/joda/time/LocalDateTime;I)Lorg/joda/time/LocalDateTime;"
	[junit] MAJOR: org.joda.time.Chronology_ESTest[test07] failed!
	[junit] MAJOR:  -> java.lang.NoSuchMethodError
	[junit] MAJOR:  -> "org.joda.time.chrono.IslamicChronology.minusDays(Lorg/joda/time/LocalDateTime;I)Lorg/joda/time/LocalDateTime;"
	[junit] MAJOR: org.joda.time.Chronology_ESTest[test08] failed!
	[junit] MAJOR:  -> java.lang.NoSuchMethodError
	[junit] MAJOR:  -> "org.joda.time.Chronology.now(Lorg/joda/time/Chronology;)Lorg/joda/time/LocalDate;"
	[junit] MAJOR: org.joda.time.Chronology_ESTest[test09] failed!
	[junit] MAJOR:  -> java.lang.NoSuchMethodError
	[junit] MAJOR:  -> "org.joda.time.Chronology.fromDateFields(Ljava/util/Date;)Lorg/joda/time/LocalTime;"
	[junit] MAJOR: org.joda.time.Chronology_ESTest[test10] failed!
	[junit] MAJOR:  -> java.lang.NoSuchMethodError
	[junit] MAJOR:  -> "org.joda.time.Chronology.fromDateFields(Ljava/util/Date;)Lorg/joda/time/LocalTime;"
	[junit] MAJOR: org.joda.time.Chronology_ESTest[test11] failed!
	[junit] MAJOR:  -> java.lang.NoSuchMethodError
	[junit] MAJOR:  -> "org.joda.time.Chronology.now(Lorg/joda/time/Chronology;)Lorg/joda/time/LocalDate;"

BUILD FAILED
/home/defects4j/framework/projects/defects4j.build.xml:216: Test org.joda.time.Chronology_ESTest failed

The methods exists in the source code folder.  Not sure why Major cannot find them?
Any idea?
Thanks.

Hi Rod,
Any chance that you could provide your test suite and list of classes to instrument:

Time-9f-evosuite-weakmutation.1.tar.bz2

instrument_classes_time9b

Thanks,
René

Hi René, here the requested files.
Thanks for your support.
Rodrigo.
On 5 February 2017 at 15:14, René Just<EMAIL_ADDRESS>wrote:

Hi Rod,
Any chance that you could provide your test suite and list of classes to
instrument:

Time-9f-evosuite-weakmutation.1.tar.bz2
instrument_classes_time9b
Thanks,
René
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rjust/defects4j/issues/66#issuecomment-277545722, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFRDrT9QeMkdoWUMAwLs2ZlmfNu695guks5rZi3AgaJpZM4LqqhR
.

Hi Rod,
Unfortunately, GitHub ignores attachments. Any chance that you could share these files in a different way. Just sending an email works, too.
Thanks,
René

Hi Ruben, sorry for the inconvenient, I was not aware that github removes
the attachments.
I set a google drive link to the files.
https://drive.google.com/drive/folders/0B77dm5mEsmNEZ3NqcGN4dHVpTms?usp=sharing
Thanks.
On 10 February 2017 at 18:46, René Just<EMAIL_ADDRESS>wrote:

Hi Rod,
Unfortunately, GitHub ignores attachments. Any chance that you could share
these files in a different way. Just sending an email works, too.
Thanks,
René
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rjust/defects4j/issues/66#issuecomment-279097269, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFRDrYbBqDjaJfY9Dg7Wc8bqtOQpx2OMks5rbPbogaJpZM4LqqhR
.

Hi Rod,
Thanks for sharing the test suite. I can reproduce the issue with that test suite -- in fact, that test suite doesn't even compile for me due to the references to methods that do not exist in the Time-9 project version.
However, I could not reproduce the issue when generating test suites from scratch, using run_evosuite.pl.
Is it possible, that the test suite was generated (and potentially compiled) for a different project version?
Thanks,
René

Hi René, in fact I checkout the project from scratch and generated the original test suite.
commit 428004892ddc9cf139feeeb116767af2e84613c2
Author: defects4j <defects4j@localhost>
Date:   Tue Jan 10 13:34:27 2017 -0800

	D4J_Time_9_FIXED_VERSION

As you can observe this is the last commit in the repo.
I can share it with you if you think is necessary.  The thing is that I generated the test suite over this version, and although it says that the methods does not exist, they actually do.  That's why I'm surprised.
Is there any cache directory or file that can cause this issue?

Hi Rod,
I double-checked the source code of the Time-9f project version, and it does not seem to include the methods called by the test suite:
I checked out Time-9f:
/tmp/Time-9f$ git log | head -5
commit b76823fa153e72552dd0c48c8ca336e9f06c9799
Author: defects4j <defects4j@localhost>
Date:   Sat Mar 4 15:17:20 2017 -0800

    D4J_Time_9_FIXED_VERSION

When I grep for the first missing method (withEra), it does not show up as a method in ISOChronology:
/tmp/Time-9f$ find src/main/java/ -name "*.java" -exec grep -s "withEra" {} +
src/main/java//org/joda/time/DateMidnight.java:    public DateMidnight withEra(int era) {
src/main/java//org/joda/time/DateTime.java:    public DateTime withEra(int era) {
src/main/java//org/joda/time/LocalDate.java:    public LocalDate withEra(int era) {
src/main/java//org/joda/time/LocalDateTime.java:    public LocalDateTime withEra(int era) {

Can you please check again whether the withEra method indeed exists in your working directory and, if so, let me know what git status reports?
Thanks,
René

Hi Rod,
Is this still an issue for you or have you been able to resolve it?
Thanks,
René


Two KDE environments running?

I'm not a competent Linux user - so bear with me.
I seem to have two KDE environments running. When I startkde from ChromeOS it loads into KDE fine. But I have Transmission running which says the active torrents are idle, everything else seems to be working fine. When I switch back to ChromeOS using ctrl+shift+alt+back it takes me to another KDE login for an environment that seems to already be running, Transmission is running and the torrents are downloading. When I do the command again to get back to ChromeOS it seems to end the session - i.e. I can't type commands in the crosh shell, I have to close the window and load it up again and go into shell. When I startkde the whole process just repeats itself.
I've tried the instructions in the Wiki before reporting the issue - i.e. downloading and running crouton again.
I've tried to force an unmount-chroot because I thought that might solve it after searching the site for things that sound similar to what I am experiencing.
Can anyone help?
I hope my explanation is clear enough - I'm not a Linux person.

This is what crosh says immediately after exiting KDE - normally the 'suspending aiglx clients for vt switch' message is the last thing it says

I don't really understand the issue.  The crosh shell is running startkde, so you won't be able to type any commands into it.

I believe I had two chroots mounted concurrently, the issue resolved itself - apologies for the confusion

OK, awesome.


Faster imports for pre-bundled libraries

I'm hoping to find a way to speed up bundle generation when importing (large) libraries that are pre-bundled as UMD scripts.  When importing a pre-bundled library, there shouldn't be any need to parse the imported script or walk the AST.
Would you suggest creating another plugin for this purpose, or do you think this one could be given an option to skip parsing and AST walking when there are no additional dependencies to resolve?

I like where your head's at. Excuse me while I think aloud. I think it's possibly a bit risky to skip parsing altogether (e.g. the bundle might very will not have any dependencies in its package.json, but it might still use modules like fs and path – without knowing about those requires it's not possible to shim them for use in browser, etc. Plus we need to detect things like global, and try to figure out if there are named exports. Also it creates a configuration burden on the user) but I think we probably can speed it up.
The json plugin has quite a nice trick – it generates a synthetic AST and hands that over to Rollup, which then doesn't need to parse the resulting JavaScript. We could do something similar here, creating a 'black box' whereby Rollup skips the actual module code. That would speed things up considerably by skipping the second parse (one of the shortcomings of the plugin system is that code sometimes has to get parsed more than once).
We then just have the initial parse performed by this plugin. I recently made a package called tippex which allows you to robustly identify things like require statements without generating and traversing an AST. It falls over in pathological cases like this...
(function (require) {
  var foo = require('foo');
}(notActuallyRequire));

...but as long as no-one does anything that daft, it works well and is an order of magnitude faster than Acorn.
So those two techniques, working together, could drastically improve the performance of this plugin. The downside is that you would no longer get sourcemaps (because they're generated with the help of the correct AST), so it should possibly be behind an option:
plugins: [
  commonjs({ fast: true })
]

you can run it through derequire first to change the internal requires to a different name so this won't find them

Hey folks (this is a canned reply, but we mean it!). Thanks to everyone who participated in this issue. We're getting ready to move this plugin to a new home at https://github.com/rollup/plugins, and we have to do some spring cleaning of the issues to make that happen. We're going to close this one, but it doesn't mean that it's not still valid. We've got some time yet before the move while we resolve pending Pull Requests, so if this issue is still relevant, please @ me and I'll make sure it gets transferred to the new repo. :beer:


sensors: BME280: obtain device pointers directly

The main point of this pull request is to show the advantage of declaring device structures using the DEVICE_DT_DEFINE() and DEVICE_DT_DEFINE_INST() macros introduced in e643ee26a71and 3a83f0ec69e.
I'm using the BME280 sensor driver as a proof of concept. We used the same driver as a testing ground for the new DT API when that was introduced in zephyr v2.3.
Avoid calling device_get_binding() at boot time to grab the device. Instead, the BME280 driver can just use DEVICE_DT_GET() and device_is_ready() to make sure the relevant SPI, I2C, and GPIO devices it may depend on are available instead. This saves RAM by moving a struct device* and a struct spi_cs_control from the driver data to its config structure since all the devices are known at build time, and avoids error-prone boilerplate by reusing common macros from drivers/spi.h.
A secondary goal of this PR is to add more helper macros to the SPI API for initializing SPI device configuration data from devicetree nodes. This eliminates boilerplate in the BME280 driver in a way that could be reused elsewhere.
Update the sample likewise to use DEVICE_DT_GET to get the BME280 device instead of calling device_get_binding(). I re-worked the sample a bit as well so that it works on any board that has Arduino SPI and I2C pins while we're here, in hopes that makes this PR easier for others to try out.

That's sweet!

Rebased and addressed review feedback. I suppose this could be merged for Zephyr 2.5, but I'm not in a rush.

Rebased and addressed review feedback. I suppose this could be merged for Zephyr 2.5, but I'm not in a rush.

Need some time to figure out how to fix the tests/drivers/build_all/sensors.build.a_h in frdm_k64f:tests/drivers/build_all/sensors.build error in BK output.
@MaureenHelm @galak do you think it would be OK for the build_all test to create fake I2C and SPI struct device instances so the BME280 driver has something to DEVICE_DT_GET()? Right now, the test_i2c and test_spi nodes in app.overlay don't have any corresponding devices, so the build fails at link time since the bus devices are nowhere to be found (which is actually pretty sweet if you think about it...).

Need some time to figure out how to fix the tests/drivers/build_all/sensors.build.a_h in frdm_k64f:tests/drivers/build_all/sensors.build error in BK output.
@MaureenHelm @galak do you think it would be OK for the build_all test to create fake I2C and SPI struct device instances so the BME280 driver has something to DEVICE_DT_GET()? Right now, the test_i2c and test_spi nodes in app.overlay don't have any corresponding devices, so the build fails at link time since the bus devices are nowhere to be found (which is actually pretty sweet if you think about it...).

Rebased and removed the declaration macros that are obsoleted by 98b6e4f834d0be4fadabcfeb648b6128b9706217, which should also solve the build_all problem.
Added on another cleanup commit that separates the SPI and I2C bus routines into their own files.

Rebased and removed the declaration macros that are obsoleted by 98b6e4f834d0be4fadabcfeb648b6128b9706217, which should also solve the build_all problem.
Added on another cleanup commit that separates the SPI and I2C bus routines into their own files.

@MaureenHelm @galak do you think it would be OK for the build_all test to create fake I2C and SPI struct device instances so the BME280 driver has something to DEVICE_DT_GET()?

I went ahead and added this.

@MaureenHelm @galak do you think it would be OK for the build_all test to create fake I2C and SPI struct device instances so the BME280 driver has something to DEVICE_DT_GET()?

I went ahead and added this.

Will you open an issue to finish the job by doing the same thing for gpio and serial, and to document somewhere that this should be done for any future vnd,* binding related to devices that come from devicetree?

https://github.com/zephyrproject-rtos/zephyr/issues/31435

Will you open an issue to finish the job by doing the same thing for gpio and serial, and to document somewhere that this should be done for any future vnd,* binding related to devices that come from devicetree?

https://github.com/zephyrproject-rtos/zephyr/issues/31435

Comments addressed, thanks again for continuing review.

Comments addressed, thanks again for continuing review.

We'll have to have a task to update all the sample early in 2.6.

Yep, I created https://github.com/zephyrproject-rtos/zephyr/issues/32139 already to track that. Thanks for all the review.

@mbolivar-nordic seems that it does not work on C++ :-(
.m_spiCfg = {
	.frequency = DT_PROP(DT_NODELABEL(nfc_reader), spi_max_frequency),
	.operation = SPI_OP_MODE_MASTER | SPI_TRANSFER_MSB | SPI_WORD_SET(8) | SPI_LINES_SINGLE,
	.slave = DT_REG_ADDR(DT_NODELABEL(device)),
	.cs = SPI_CS_CONTROL_PTR_DT(DT_NODELABEL(device), 0)
}

error: ISO C++ forbids compound-literals [-Werror=pedantic]
   31 |  })
      |  ^
xxx.hpp:70:14: note: in expansion of macro 'SPI_CS_CONTROL_PTR_DT'
   70 |        .cs = SPI_CS_CONTROL_PTR_DT(DT_NODELABEL(device), 0)}
      |              ^~~~~~~~~~~~~~~~~~~~~
xxx.hpp:25:28: error: taking address of rvalue [-fpermissive]
   25 |  (&(struct spi_cs_control) {       \
      |                            ^~~~~~~~~
   26 |   .gpio_dev = DEVICE_DT_GET(         \
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   27 |    DT_SPI_DEV_CS_GPIOS_CTLR(node_id)),   \
      |    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   28 |   .delay = (delay_),              \
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   29 |   .gpio_pin = DT_SPI_DEV_CS_GPIOS_PIN(node_id),\
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   30 |   .gpio_dt_flags = DT_SPI_DEV_CS_GPIOS_FLAGS(node_id),\
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |  })
      |  ~
xxx.hpp:70:14: note: in expansion of macro 'SPI_CS_CONTROL_PTR_DT'
   70 |        .cs = SPI_CS_CONTROL_PTR_DT(DT_NODELABEL(device), 0)}

@alexanderwachter

seems that it does not work on C++ :-(

https://github.com/zephyrproject-rtos/zephyr/pull/30536#discussion_r558928356 should have addressed that.

I see why a pointer-to-object is needed (because struct spi_config requires one), and it may be that we can't do anything else, but I now think we need to discuss this more.

Missed this comment in my above reply. Yes, this is the crux of the issue.
I've rebased and pushed a version with these macros ifdef'ed out on C++. No other changes.

@avisconti please review, you may want to do this in the ST sensor drivers

@avisconti please review, you may want to do this in the ST sensor drivers

@MaureenHelm he is waiting for it to go in before updating one of his PRs actually; see: https://github.com/zephyrproject-rtos/zephyr/pull/31775#discussion_r576314716

@avisconti please review, you may want to do this in the ST sensor drivers

@MaureenHelm he is waiting for it to go in before updating one of his PRs actually; see: #31775 (comment)

@mbolivar-nordic Thanks for the reminder. I'd seen that comment earlier, but forgot about it.

@avisconti please review, you may want to do this in the ST sensor drivers

@MaureenHelm he is waiting for it to go in before updating one of his PRs actually; see: #31775 (comment)

@mbolivar-nordic Thanks for the reminder. I'd seen that comment earlier, but forgot about it.

Yes, sorry for not reviewing it. I was busy with other stuff as well


Change the layout and pagination of the pricing component following the mockup created with Figma

Nice preview, Let me know when you are ready with your PR!


Can't find dist/js folder

Hi,
How to get the toc.js file?

https://github.com/jgallen23/toc/tree/0.3.2/dist


Feat/1746 idc dev tool

Description
This PR exposes a new method in @ohif/extension-dicom-p10-downloader that allows uploading the current study in a different server.
Basic Usage
The command takes the server configuration, which is the object with the values used to create a new instance of DICOMwebClient.
const serverConfig = {
  url,
  headers,
  errorInterceptor
};

ohif.app.commandsManager.runCommand("downloadAndUploadStudy", { serverConfig });

@JamesAPetts can you help me on how to test it properly?
Fixes #1746

PR Checklist

[x] Brief description of changes
[x] Links to any relevant issues
[ ] Required status checks are passing
[ ] User cases if changes impact the user's experience
[x] @mention a maintainer to request a review

Hey Rodrigo, the easiest way to test this would be try posting from the dcmjs server to a local instane of orthanc/dcm4che.
I gave it a quick go, but the upload portion throws a JS exception before the push.
Let me know if you need some help with this.


Cannot read property _values of undefined

Hello, I am trying out your Github Action with a fairly simple workflow [1].
On the particular step for this action it yields: Cannot read property _values of undefined
[1] https://github.com/AaronMT/firefox-ios/blob/main/.github/workflows/build-contributor-pr.yml
The Xcodebuild step is running a test-plan of XCUITests from a particular scheme. I am not sure if analyze-xcoderesults-action is running into issues with this particular setup or if it's even supported. Thought I'd ask here. I assume it's having a problem parsing out the result bundle.

Hi sorry you ran into issues.
Can you please try version 0.1.1. In your workflow file you are using 0.1.0.

That was it, thanks.
https://github.com/AaronMT/firefox-ios/runs/2577850126?check_suite_focus=true
(Aside, are the warnings treated as a GitHub ❌  here? With 50 tests passed / 0 failed, and the job finished successfully)

@AaronMT yeah that seems like a bug, I'll have a look tonight.

(Apologies for re-using the same issue, I can open a new one if need be)
Another issue seems to be that it is not always writing out the check on Github for some reason. For example, on a re-run today https://github.com/AaronMT/firefox-ios/runs/2602937245?check_suite_focus=true I was expecting Xcode Results on the left side. But on an earlier run this morning it worked https://github.com/AaronMT/firefox-ios/actions/runs/850381155 – no difference in results in my XCResult artifacts.


Use Projen and include workflows-sdk

Description
This change updates the repository to use projen and adds the workflows-sdk to the main branch.
Testing
yarn build
Checklist
I have:

[ ] Added new automated tests for any new functionality
[x] Run yarn build

Licensing statement (do not modify)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Lgtm


Setting overlayClose via modalFactory does not work because of casing

When creating a dialog using modalFactory

modalFactory({ overlayClose: "false" })

and the "prop=overlayClose" property is added to the attribute

element.attr(prop, config[prop]);

the attribute becomes lowercase "overlayclose" in the attrs object of the modal directive.

attrs.overlayclose === "false"

This results in the scope.overlayClose to always be true

scope.overlayClose = attrs.overlayClose === 'false' ? false : true;

I resolve this by

scope.overlayClose = (attrs.overlayClose || attrs.overlayclose) === 'false' ? false : true;

I assume the same will apply to other capitalized properties such as "animationIn" and "animationOut"

I should mention that this was discovered in Chrome v43. I did not test it on other browser.

Facing same issue, with the current code, there is no way to set overlay-close attribute to false.
 if(config[prop]) {
   switch (prop) {
     [...]
     case 'overlayClose':
       element.attr('overlay-close', config[prop] ? 'true' : 'false'); // must be string, see postLink() above

Maybe the line should be simply replaced by
element.attr('overlay-close', config[prop]);
https://github.com/zurb/foundation-apps/blob/master/js/angular/components/modal/modal.js#L279

This is still an issue. Any timeframe for when this will be fixed?

This was merged and fixed @chr22
Any example of code where it does not work for you?

var modal = new this.ModalFactory({
                overlay: true,
                overlayClose: false,
                templateUrl: "Web/Areas/FarmTaskList/FarmTaskAddDialog.html",
                contentScope: {
                    close: () => {
                        modal.destroy();
                    },
                    farmTask: farmTask,
                    farmTasks: this.Tasks
                }
            });

            modal.activate();

The problem is that the the overlayClose attribute won't be added because of the "if" in the picture below when the value is false.

And this line only checks if the value is "false", but it will never be false because it will never be added when it is false.

Set it as a string false?

Thanks it works.
The documentation should be updated to reflect that. The current documentation uses a boolean value.
http://foundation.zurb.com/apps/docs/#!/modal


Variables are not parsed in the Url of an Http Request

Describe the bug
When using a variable in the Url field of an HTTP request, like so;
${dialog.apiUrl}
The variable is not parsed. The help icon of the Url field says that data binding is supported.
Version
4.7.0-preview-191208-1
Browser

[ ] Chrome
[ ] Safari
[ ] Firefox
[ X] Edge

OS

[ ] macOS
[ X] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Add Set a property (Property: dialog.apiUrl, Value:'http://www.test.com')
Add Send a HTTP request (Method: Get, Url: ${dialog.apiUrl})
Run the bot
See error

Expected behavior
Variable should have been parsed in the Url field

@cxbuilders , I think that is because the version you are using is too old. could you check the latest master, you can refer to the HttpRequest step in the DialogActions template:

Works now!

I have the same issue. I'm on 1.3.0.
My Url field shows required and has (abc) in the icon to the left and not (fx). I can set a property to the URL string and it shows fine in a message but passes the actual property name.
value in message: https://graph.microsoft.com/v1.0/users/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
value in Http GET command: label: "HttpRequest[GET =`${$game.userTargetUrl}`]"

I have the same issue. I'm on 1.3.0.
My Url field shows required and has (abc) in the icon to the left and not (fx). I can set a property to the URL string and it shows fine in a message but passes the actual property name.
value in message: https://graph.microsoft.com/v1.0/users/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
value in Http GET command: label: "HttpRequest[GET =`${$game.userTargetUrl}`]"

@rslavey We've updated some of the fields to adaptive expressions in 1.3.0, could you try to add a '=' before your string.

This was successful. Thank you.

I am trying to use variable substitution in Bot Composer 1.3.1, and I cannot make substitution to work. I am trying to substitute an entity country extracted in the LUIS trigger. I tried the following:

http://my.rest.service/api/${@country} - does not do substitution
=http://my.rest.service/api/${@country} as suggested by @luhan2017 - gives an error "mismatched input ‘:’ expecting " in the bot chat
I have tries assigning @country to another variable such as ${user.country} in a separate block, and using ${user.country} instead - no difference
I would appreciate any help. @rslavey, what was the exact syntax you have used which solved the problem?

Same here - I cna't seem to add variables in any URL for HTTP requests.

Here is how I made it work:
=concat('https://graph.microsoft.com/v1.0/users/',$game.whoUserId,'/photo/$value')

I think once you put the equals sign, you have to use the concat function to put strings together. It may work if you assign the whole URL to a single variable and then use
=${@url}

but I'm not sure.

@shwars Did it work for you? I am also facing the same problem as you faced . Did you fing solution for it?

I still cannot get this working btw. I am on 2.0

@Sakyawira instead of title={$user.anime}, write it like title=${user.anime}.

Hi, i am having the same issue,

grabbing an input

results in

any help appreciated


ENH: use xarray DataArray for spectrogram, to be able to index frequency and time bins with labels

Current vocalpy.Spectrogram uses NumPy arrays for its data, frequencies and times attributes.
I think we should instead use an xarray.DataArray with named dimensions, e.g. "time", "frequency".
The main reason to do this would be that it makes accessing portions of the spectrogram easier.
There's two immediate contexts I can think of where this would be helpful. The first would be in existing plotting functions, where e.g. we need to find the appropriate set of indices to use to index the data from the frequencies array when we only plot a certain frequency range. We would instead use positional indexing by label:
spect_to_plot = spect.loc[flim[0]:flim[1], tlim[0]:tlim[1]]

The second would be in feature extraction, where we often want to specify a range of frequencies or a specific time. With a Spectrogram backed by an xarray.DataArray, we can do so using the same logic as in the snippet above. This obviates the need for bookkeeping logic that can couple functions together, e.g. having to find a set of freq_inds with a helper function, get min_freq_ind and max_freq_ind from that vector, and then finally pass min_freq_ind and max_freq_ind to all the feature extraction functions. Instead we just will specify min_freq and max_freq directly as an argument to the function. This has the added benefit of making the defaults for these frequencies into explicit parameters, "the default max_freq is 11000 Hz".
If we do this, we should convert the existing frequencies and times vectors into @propertys that return the corresponding co-ordinate vector (the array used for indexing by label, an attribute of a DataArray). Also note xarray has integration with pint which I think would allow us to additionally specify units (Hz, s) for the dimensions

So given that this works, the question becomes, how would we re-write vocalpy.Spectrogram?
We could make the data attribute of the current Spectrogram an xarray.DataArray but then we're not really giving ourselves the advantage of DataArray; that is, if we index the attribute as above we'll get back an instance of a DataArray, not another Spectrogram.
So the question is: do we subclass DataArray, and/or do we have the same methods as a DataArray and dispatch to those?
In general, sub-classing for code sharing is bad, but sub-classing to specialize can be good.
Things get more complicated though when we're dealing with a really complex class like xarray.DataArray.
The xarray docs recommend composition over inheritance but the recommended way to achieve this is with an accessor much like Pandas has. This means we'd end up using something like a named voc accessor on a DataArray instance. I don't like this, because I want the class to be called Spectrogram, so that code is readable--that's the whole point. So I think for now we should consider this a possibility but not sink a bunch of time into it.


Dailymotion issue

Terminal output here: http://pastebin.com/AQLx6Z6i

I assume this is the same as #6151. From which country do you access dailymotion?

Currently in the Philippines. Looks like Dailymotion pushed out a new player today.


Add bindings for useRestoreFocusTarget

Bindings for the hook useRestoreFocusTarget from @fluentui/react-components are missing.

Added in recent commit (https://github.com/sydsutton/FS.FluentUI/commit/a28e3054c32907dea24a2573363f9fa6fe32189a) and will be with next version bump. Thanks!


Kernel capabilities to run Docker in Hyper

It would be nice to extend kernel config to support: all cgroups, veth, iptables with filter, nat and conntrack.
That would allow to run docker in hyper VM, making the hyper best choice to be used as CI worker.
What do you think?

@ayufan I think in most of the cases, you can directly run docker image with hyper. And I'd like to learn your case, why you want to run docker in hyper.
And actually, you can use your own kernel in the config file, and reference our kernel configuration . PS: if you want use a customized kernel, you need disable the Cbfs config item, or build a new cbfs rom (reference our make cbfs code), and I will add a document page on build your own kernel/initrd.

@gnawux I did it yesterday (recompiled kernel and rebuilt cbfs) and it works great.
About the use case:
Currently Docker-in-Docker is possible, but insecure (requires --privileged). With using full-virtualization docker-in-hyper can work without any security concerns. It's especially useful for CI that for time of build spinups new VM and requires access to Docker in order to build, test and deploy container.
I specifically were thinking about implementing it in https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/ as additional method to run builds.
I guess that your main concern is not inclusion of features, but boot time that can be longer with them enabled. Am I right?
@gnawux One quest: do volumes work in 0.2.1?

@ayufan the volumes work in current version, and if you meet any problems, you can file an issue.
I do not think it will take too much time to boot with a few more options :), just curious about the scenario. If it is a common case for many users, the features should be add to the release package.

Is it common? hard to guess. It would be nice to have, because there's no secure option to run dind :) You could sell it that this is supported in secure manner. There are companies that are fighting with creating selinux, apparmor policies for LXC to have it working and isolated, but still this is not "that" secure as full VM.

True. Thanks for your case @ayufan .
We will do further investigation, and maybe have all these options in next release.

@gnawux I'll be happy to prepare PR with required kernel features enabled. Just let me know :)

I think it makes sense to support cgroup and other namespaces in pod. So when I create a pod, I have the option to isolate multiple containers in a pod, or share namespace.
The multi-container feature should do the job for @ayufan , though it doesn't require docker daemon in the VM instance.

Any news on this? I have exactly the same use case and would like to use Hyper pods running a Docker daemon to build Docker images in a secure, isolated way.

Any progress on this? I have same issues as well.

@junoyoon Latest docker can be run smoothly inside Hyper pods, just don't forget to mount cgroups before starting dockerd, refer here.

@feiskyer  thanks for reply.
I've tried the following steps to test it.

run cgroupfs-mount in centos7 PM.
install hyperd in centos7 PM.
run hyperd container using hyperctl run -t centos:latest bash
install docker in the hyperd container using

https://docs.docker.com/engine/installation/linux/centos/#/install-with-yum

start docker daemon in the hyperd container.

Finally I got the following errors.
[root@centos-latest-6240306100 /]# systemctl start docker
Running in chroot, ignoring request.
[root@centos-latest-6240306100 /]#

Do I need special steps more for docker daemon?

@junoyoon Systemd requires much more configurations in containers, try to start dockerd without systemd, e.g. just run dockerd

@feiskyer Thanks... I could run successfully run docker daemon just run dockerd
Then I tried to run docker command docker run -it centos:latest
And I see following result.
ERRO[0029] containerd: start container                   error=oci runtime error: container_linux.go:247: starting container process caused "process_linux.go:359: container init caused \"could not create session key: function not implemented\""
                                     id=2dec4e56ab4579541bc35a509cfbbe0b6b70c67c6c0a2a46d629e7ddbb13bf67
                                                                                ERRO[0030] Create container failed with error: invalid header field value "oci runtime error: container_linux.go:247: starting container process caused \"process_linux.go:359: container init caused \\\"could not create session key: function not implemented\\\"\"\n"
                                                                                ERRO[0030] Handler for POST /v1.24/containers/2dec4e56ab4579541bc35a509cfbbe0b6b70c67c6c0a2a46d629e7ddbb13bf67/start returned error: invalid header field value "oci runtime error: container_linux.go:247: starting container process caused \"process_linux.go:359: container init caused \\\"could not create session key: function not implemented\\\"\"\n"
docker: Error response from daemon: invalid header field value "oci runtime error: container_linux.go:247: starting container process caused \"process_linux.go:359: container init caused \\\"could not create session key: function not implemented\\\"\"\n".

Is not  hyperd container compatible docker 1.12?
[root@centos-latest-6240306100 /]# docker --version
Docker version 1.12.3, build 6b644ec

@junoyoon Did you update hyper-initrd.img & kernel to the latest version? https://github.com/hyperhq/hyperstart

@gao-feng
I've installed the hyperd yesterday following its instruction. https://docs.hypercontainer.io/get_started/install/linux.html
Does the binary distribution outdated?
Do I need to build it from source?

@junoyoon I think you should update hyperhq/hyperstart to the latest master.
Could you confirm this, @gao-feng ?


Enable SSE-S3 encryption as an option

Basically set the appropriate header to enable SSE-S3 server side encryption for all put/upload operations.
Docs here: http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingServerSideEncryption.html
Header is defined in appropriate Input params here: https://docs.aws.amazon.com/sdk-for-go/api/service/s3/  by setting the input parameter:
ServerSideEncryption = AES-256
Am working towards a PR.

PR: https://github.com/kahing/goofys/pull/106

55c235cf0dec33bd5c0542e5c0ed4fe2ced7628f


Use prettier for formatting

Standard is good, but prettier is even better. Prettier takes
auto-formatting to the next level.
https://prettier.io/

This Pull Request has been closed by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

1
4
0
5

Vote Breakdown

User
Yes
No
Abstain

ags131

✔

semperrabbit

✔

Graham42
✔

tedivm

✔

PostCrafter

✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
False


uniform_int not/no longer present on Dense matrices

According to the tutorial, Mat.uniform_int should be there. However it seems to be availabe only for sparse matrices and not for dense.

It was removed because the generated matrix still uses float numbers. Generating an integer matrix can be done in several ways, by casting functions, or round, floor, ceil, trunc, fix, etc.

About the inconsistency between dense and sparse is, long story short, I have been trying very hard to make dense and sparse have the same interface since the very beginning of Owl. However, it only works fine for basic operation like add, sub, mul, div, and etc. Later, the focus shifted onto dense part because more people are using dense structure so the sparse part is lagging behind.
Also, the sparse module depends on eigen which I am not particularly happy with, so I always consider it as a temporary solution. In the long run, I will replace it with something else, e.g. https://sparse.tamu.edu/ so that Owl can get rid of Eigen completely (Dense module already got rid of Eigen thanks to Jianxin @jzstark great work) long time ago.


missing "

Hello polymer team,
I have noticed that there is missing "  in your how to install polymer with bower section right in the tip block  ( https://www.polymer-project.org/1.0/docs/start/getting-the-code.html#using-bower )
Tip: --save adds the item as a dependency in your app’s bower.json:
{
"name": "my-project",
"version": "0.0.0",
"dependencies": {
"polymer": "Polymer/polymer#^1.0.0             <-------- there is missing " on the end of the line
}
}
not a big deal, but can cause problems, especially for people who starts with Polymer

Already create a PR for that: https://github.com/Polymer/docs/pull/1092 :)

Fixed by prior commit.


Fix CSS specificity

Enable the slotted part=“value” to flex (fixes vaadin-dropdown-menu
styles).

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


Fix firefox NS_ERROR_FAILURE issue caused by the new titles feature

NS_ERROR_FAILURE when rendering titles in off-screen chart in firefox only. This is a reintroduction of same issue in #131. Applied same fix as cd004fea.

Superseded by #1231.


Support multi-line PR code suggestion comments

Create (a) function(s) in the

[ ] framework-core
[ ] CLI

where it takes as input

[ ] the complete file content changeset is taken as input
[ ] gnu diff string is taken as input

and automatically creates a PR code-suggestion comment, (see step 6)

supports multi-line comments
preserve framework-core independence from git

@chingor13 Great work! What's the status on the comment-pr branch? This work is on the comment-pr branch only.


Latest euwe version slow accessing users

A newly spinned euwe image.
If you try to access group and role configuration, it takes more than a minute the first time

@miq-bot add_label   bug


Add PS debug to nexthop during mark up/down

In relation to #8049 , we should add similar debug to the new nexthop strategies during parent mark down and up

Petition to not mark stale or close, this is very useful and very easy. In fact, adding good-first-issue

@rob05c @ezelkow1  Hi, can you please assign me this issue , I am interested in solving this issue and please guide me

Is this what you had in mind? [Jul  3 09:49:57.824] [ET_NET 9] NOTE: [0] NextHop initially marked as down p1.example.com for request example.com


fix(cd): add tests to ensure wasm filters are in place

Summary

Checklist

[ ] The Pull Request has tests
[ ] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4489

see https://github.com/Kong/kong/actions/runs/9092877617/job/24990612395?pr=13033 for result


[Dependencies] Update php-cs-fixer dependency

In fact, problem does not come from the bundle dependencies but another bundle.


Fix linting failures

Description:

Linting has started to fail in internal/signalfx-agent. This should resolve linting failures.
Failing lint runs:
https://github.com/signalfx/splunk-otel-collector/actions/runs/6816529495/job/18538120568?pr=3898
https://github.com/signalfx/splunk-otel-collector/actions/runs/6764645328/job/18383244412?pr=3882

I think the failures result from https://github.com/signalfx/splunk-otel-collector/pull/3898/files#diff-8770730bfa9304e1f62ea3ad904253c3653028e5fc741ab6b8221c2f03e69da3R14. Do you mind updating golangci-lint to v1.55.2 in these changes?

I didn't realize I'd updated the lint version for the MSI PR, so I assumed the lint failures unrelated to the new golangci-lint release. I've closed this PR and will update in the original dependabot PR.


Add Elasticsearch "fuzzy" search feature

Add this feature, please! I red about this here: Learning Elasticsearch with Laravel

plus one on this feature... would be a good one to have

It should be possible to do this already by modifying the query array using the callback parameter passed to search.

@kronthto could you show us an example?

Somewhat like this (not tested):
/** @var \Laravel\Scout\Builder $builder */
$builder = MyModel::search(
    'searchstring',
    function (\Elasticsearch\Client $client, $query, $params) {
        return $client->search([
            'multi_match' => [
                'query' => $query,
                'fuzziness' => 'AUTO',
                'fields' => ['title^3', 'content'],
            ],
        ]);
    }
);

I agree it would be nice if the Builder API provided a way to add this automatically, but we are bound to the interface laravel/scout provides.

@kronthto wow it works, you're awesome man. Thank you!
Could you explain what is title^3?

That's a boost. ES calculates a score how well the item matches and uses that for sorting. So in this example, a match in the title yields 3x the score-points and title-matches will be sorted above content-only matches.

@kronthto It work very well for me thank thank

@kronthto works like magic! Thanks!

late question, whats the diff between this and the default ?
i tired both and i get

different found count "default is more"
some items that are found in fuzzy but not in default & vice versa

to get the highlight and any other data along with the model "if anyone have a better solution plz add it"
$data = Model::search($request->query, function (\Elasticsearch\Client $client, $query, $params) {
    // ...
})->raw();

return collect($data)->pluck('hits')->filter()->values()->flatten(1)->map(function ($v, $k) {
    return array_merge($v['_source'], [
        'highlight'=> $v['highlight'] ?? null,
        'score'    => $v['_score'],
    ]);
});


[RELENG-5806] fix readhat daemon.json file

Codecov Report

Merging #104 (673486e) into main (7c0a534) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   70.64%   70.64%
=======================================
  Files          12       12
  Lines         729      729
=======================================
  Hits          515      515
  Misses        214      214

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c0a534...673486e. Read the comment docs.


[Support] Allow nil to be a value in parameters

I'm unsure whether this report should be included in this library, but I want to mention that the error below occurs when the content is nil during function calls.
; Execution error (ExceptionInfo) at schema-tools.coerce/coerce-or-error! (coerce.cljc:24).
; Could not coerce the value to schema: {:body {:messages [nil nil nil nil nil nil {:content (not (instance? java.lang.String nil))} nil]}}

This issue can be reproduced when using function calls as a response of create-chat-completion. The response value appears as {:role "assistant", :content nil, :function_call {:name "some-function", :arguments "{\n  \"name\": \"someName\"\n}"}}), but it's an invalid schema in the API. I may have a workaround, but I'd like to inquire if supporting nil as a value is allowed.
Reference: https://platform.openai.com/docs/api-reference/chat/create,
content string Optional
The contents of the message. content is required for all messages except assistant messages with function calls.

There was an update to the openai spec not so long ago that now allows null for content
I have updated this latest schema in v0.9.0 so this issue should now be fixed

Great for the work. Thanks!


added segment tree folder  and related question answers

Firstly I created the segment tree folder and added 5 questions from cses proble set and answers to them

Please give this repo a star and follow me follow back🐱🏍


Handling of groups named after upper levels (..)

Issue
The IDE can take groups named ... However group named like this will propagate to $CONFIG_NAME$/BrowseInfo's parent directories. When a single parent level is involved, the generated browser data stills inside $CONFIG_NAME$. Above that using the output defaults, (i.e. ..\..) it will build inside the $PROJ_DIR$.
Workaround
After project is populated, rename/move/remove affected groups while avoiding .., ..\.., etc. in their names.
Remediation

This will be fixed in a future version.
Affects documentation.

Fixed in EWARM 9.40


[B16] Linked mirrors stack with unlinked; general mirror confusion

While I was experimenting in previous betas I ended up making 3 Essentia mirrors. I have all 3 in my inventory now; two are linked.
Which ones, though?

Seems to me there's a bug currently allowing 1 of a linked pair to stack with another unlinked mirror. I had placed what I thought was the "extra" mirror in a chest, only to find it was actually the linked one which had lost its linked texture (or never had it, as becomes apparent in the comment below). Since the mirrors don't allow relinking while they both exist, the only way to be 100% sure which 2 are linked is to scrap all of them and recreate, it seems...
To avoid this, would it be possible for mirrors to show their linked coordinates while they're being looked at (via JEI for example)? Not sure if this is a request for you or the author of Thaumic JEI though.
And could both mirrors show coordinates while we hover over them in the inventory? Currently I've only been able to see coordinates for one of the pair.

More info if it helps...

In the pic above, I placed a new mirror on the ceiling (after smelting the other 3). Clicked on it with another new mirror. The one I'm holding has acquired coordinates, and the black "linked mirror in inventory" texture. The one on the ceiling still looks unlinked though, has the regular mirror texture.

Only the mirror I clicked with has the linked texture in inventory as well, and the other one shows no indication of being linked at all.
Now If I remove the apparently unlinked one, place the one I previously clicked with on the wall instead, and click with the one that looks unlinked, Thaumcraft tells me "yeah it's already linked", finally.

But it doesn't tell me it's linked to the one in my hand. So if I made a third or a fourth mirror above? I have to guess.
I think this is really user-unfriendly because you have to fiddle around with both mirrors to figure that out.
IMO both mirrors should acquire the linked textures and display coordinates as soon as they're paired to avoid the issue above.

IIRC the linked texture should appear on both when they have both been placed down, and the problem you're experiencing is related to the situation where picking up one mirror before placing it's linked partner causes odd behavior, correct?

I placed the first (new, never linked) mirror next to my essentia jars, clicked on it with the other (new) mirror, and the first image above occurred.  I didn't move the first mirror before trying to link.

In my experience, both mirrors need to be placed in the world at the same time to be and remain properly linked.  If you place a mirror on the ground and use another mirror on it, you have to then place that mirror in the world for the link to work between them.

Sorry but what you're saying is not clear at all.

at the same time

Not always possible: my altar is about 100 blocks away. That's why I place the first mirror in the world, click it with the second mirror, then go place the second mirror.

If you place a mirror on the ground and use another mirror on it, you have to then place that mirror in the world for the link to work between them.

And that's exactly what I did.

Place your mirror.  Right click using another mirror.  Go and place that mirror.  Then the mirrors should be set up correctly.
I'm trying to reproduce your issue but I'm not encountering any problem with mirror stacking.  The only somewhat related situation I've found is: if you have two paired mirrors in the world, you can break one and place it elsewhere without breaking the link. Because of this, if you break one mirror and then break the other, the first will still show itself to be linked and the other will return to being just a standard, stackable mirror.  This can be fixed by placing and re-breaking the first, still-linked mirror.  I've had no issues linking, relinking, unlinking, and relocating mirrors.
Do you have a more consistent way to replicate this bug you're experiencing?

Do you have a more consistent way to replicate this bug you're experiencing?

Nope, it's really just the steps I gave above in the images:

Create both mirrors.
Place one in the world (no. 1)
Click on no. 1 with no. 2: notice the texture for no.1 does not change (at least that's what happened to me, which I find abnormal)
Take no. 1 off the wall, place no. 2 in its place
Place no. 1 somewhere else: I would expect them to still work, but they don't, which I also consider undesirable behavior.

The reason why I'm saying it's a problem is because it feels way more logical to let players move both mirrors wherever they choose, but that doesn't seem possible at the moment...

For what purpose are you breaking the first mirror before you place down the second?  You're breaking it before a link has been established.  In order for a link to be completely established between mirrors, it seems that they have to both be present in the world at the same time, and once you have mirrors in that state, you can only move one at a time, as breaking both of them will cancel the link.
Until you actually have both mirrors placed down, the one without the hole in it is just a plain unlinked mirror.  The one in your inventory with the black spot on it is simply marking where it's partner can be found, so that it can form a link once placed in the world.  If a mirror is not present on a block in the world, it cannot be linked to.
Following your results, no linked mirrors stack with unlinked mirrors at all.  If I start with 3 unlinked mirrors, I end up with 2 unlinked mirrors and one mirror storing the coordinates of empty air, which can be fixed by simply placing and breaking it again.

Following your results, no linked mirrors stack with unlinked mirrors at all.

Well I've shown that it does happen for me, so there's still a problem.

I don't think your problem with the mirrors isn't an actual issue with the mirrors themselves, and moreso with your understanding of their function.
The actual mirror items do not "link" to eachother in your inventory.  When you right click on a placed mirror with one in your hand, you're telling the mirror in your hand where in your world it should search to find a partner to exchange items with when placed down.  That is what the change in texture means, the mirror has coordinates saved.  If you destroy the mirror already at those coordinates, you are preventing a link from forming.  When you place the mirror with the coordinate information down, it will look at those coordinates, see that there is no mirror there, and revert to being a regular unlinked mirror. The mirror on the wall does not become physically connected to the mirror in your inventory until both of them have been placed down and allowed to communicate with eachother, which is why when you break it before that happens, it stacks with the rest of the unlinked mirrors in your inventory.  It has no linking information at all.
This functionality is not fiddly nor temperamental at all, it's straightforward and very much deterministic.

Yup - what you are experiencing is not a bug. You are not really linking two mirrors - you are linking one mirror in your inventory with another already placed mirrors location and if you remove the placed mirror it means there is no longer a link.
Secondly I have no control over what stacks and what doesn't - that is is part of MC itself. As long as their internal nbt data differs mirrors will not stack - if they do stack it means you either linked multiple mirrors somehow or they are not linked at all.


Fix installed_on_request for dependencies.

Dependencies were using Tab.for_formula(df) to get a Tab which meant that they were always ending up with the (default) value of true for installed_on_request. Fix this by:

setting installed_on_request to false by default in empty Tabs; we always override it on installation so we'd rather have it default to false
only read and use a Tab for the existing dependency formula if there's an existing Keg

Review period will end on 2021-02-24 at 10:22:11 UTC.

Review period ended.


Use current namespace and not hardcoded

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind cleanup
What this PR does / why we need it:
Better deployment on single-namespace env. You don't have to change the deployment anymore.
Tested on openshift online ( openshift version 3.11 )
Which issue(s) this PR fixes:
https://github.com/tnozicka/openshift-acme/issues/115
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/ok-to-test

looks like the e2e flaked on openshift infra (image pull backoff)
to fix verify you need to run make update

/retest
for the e2e flakes now that the registry fix merged https://github.com/tnozicka/openshift-acme/pull/118
passing verify requires you to run make update to update fixtures

/retest
looks like OCP 4.4 CI is having a bad day

/retest

@rbo e2es are green, can you please run make update to update generated fixtures and we can merge. thanks

Doesn't work on OSX:
 make update
Running `gofmt -s -l -w` on 34 file(s).
mv ./deploy/.diffs/* /var/folders/zg/djswqxd52v39541s7q8zntz80000gn/T/tmp.MGYh3JpH || true
hack/diff-deploy-files.sh ./deploy/.diffs
readlink: illegal option -- f
usage: readlink [-n] [file ...]
make: *** [update-deploy-files] Error 1

In a fedora container, it works :-)
$ docker run -ti -v $(pwd):/work fedora bash
# dnf install -y go make diffutils
# make update
Running `gofmt -s -l -w` on 34 file(s).
mv ./deploy/.diffs/* /tmp/tmp.vfGiTRTuNV || true
mv: cannot stat './deploy/.diffs/*': No such file or directory
hack/diff-deploy-files.sh ./deploy/.diffs

Updated and pushed.

Yeah, mac is always missing some options, this is kind of evergreen :(
I think in the end the output also sometimes differ so containerized is the best option. Although we accept best effort PR for Mac compatibility.
Squash the first 3 commits and it is good to go.
/approve

Squashed...

@rbo thanks
/lgtm

/retest
openshift CI run into some issues today

looks like a stressful PR - sorry.

yeah, these flakes are coming from the actual OCP CI infra (openshift-acme test don't even start running), it's having a bad week
/retest


Create an assert_eq function that checks for equality and reverts with the given value if inequality is found

I'd really like to see an assert_eq that reverted with the given value if inequality is found.
So in this example:
script;

use std::assert::assert_eq;

struct Data {
	value: u64,
}

fn main() {
	let data = Data {
		value: 7,
	};
	assert_eq(data.value, 1);
}

This would revert with the value "7". I haven't thought too hard about what this would look like for more complicated cases like structs and such though.

that reverted with the given value if inequality is found

What is the reasoning for this? I get that assert_eq would be useful, but why should the revert signal be the same as the first value?

What is the reasoning for this? I get that assert_eq would be useful, but why should the revert signal be the same as the first value?

When an assert like assert(foo == 42) fails, all that I see as a user is Revert(0). If I want to see what the value is of foo is, I have to either add a log(foo) before the assert (logs the value of foo even if the assert succeeds) or rewrite that bit to a manual if expression. So an assert_eq that reverts with that value (or does something comparable), might be a good solution to this.
In Rust for instance, assert_eq panics with the values contained on the left and right, I believe.

In Rust for instance, assert_eq panics with the values contained on the left and right, I believe.

Oh! If that's the case, then I'm all for it :)

If foo is a struct what would that look like to the user, i.e: what would the receipt look like, Revert(...)? It could be implemented similar to requirewhere a failingassert_eq`:

logs the 2 values,

reverts with a special code to signify to toolling (SDK) to decode the preceding 2 log/logd receipts

Yeah without a rvrtd opcode, we can't do much when comparing complex types. Instead, we can do what require does as you said:
fn assert_eq<T>(v1: T, v2: T) where T: Eq {
    if (v1 != v2) {
        log(v1);
        log(v2);
        revert(0xffff_ffff_ffff_0004);
    }
}

@emilyaherbert Would the example above be a reasonable way forward for achieving what you want?
It would offload the work of decoding the logs to the SDK rather than the compiler I guess, buts that's what we do for requires already so maybe this is fine?

Sorry for the delay in reply---OOO.

@emilyaherbert Would the example above be a reasonable way forward for achieving what you want?

Yes I think so!


Pre-processor for sims

https://blockscienceteam.slack.com/archives/C057QFZU9SM/p1716396114560639

Related to #314


Add alias for connection-aware result

Something like:
type DbAction[T] = SqueryConnection ?=> T

Done 459178ef1ce3847910d7f7fa12df592d6fefa82e


NW-7.52 compatibility issues

Due to several hard to fix compatibility issues, especially the non-existing CDS View ARS_ADT_API_FILTER which is only available starting from NW 7.52 a new branch should be created for NW 7.52

Branch nw-752 was created to solve compatibility issues
Using this branch instead of master should solve the following issues
#2
#3
#4
#5
#6
#7
#8
#9

great! Works like a charm. Closing the issues.


Please use BannerLord Tweaks Mod Menu!

Bannerlord Tweaks uses a great mode menu and I think his code for it is open? maybe you can incorporate it in and make it the standard mod menu?

I had issues with the Free Play mod pushing the mod Options button down!

https://github.com/Tyler-IN/MnB2-Bannerlord-CommunityPatch/issues/61
Only if it's spun off as a separate library.


Messages shouldn't fail to send if they can't be inserted into the DB

Sep-11 17:09:18.842 [DiscordBot] error: DiscordBot Failed to send message into room. { [Error: SQLITE_CONSTRAINT: UNIQUE constraint failed: discord_msg_store.msg_id]
  cause:
   { Error: SQLITE_CONSTRAINT: UNIQUE constraint failed: discord_msg_store.msg_id errno: 19, code: 'SQLITE_CONSTRAINT' },
  isOperational: true,
  errno: 19,
  code: 'SQLITE_CONSTRAINT' }

If this happens, it should be a warning (or remain an error) but otherwise not prevent the message from flowing.

This could lead to issues down the road like being unable to delete that message. Just something to keep your eye on when resolving this

yea, that kind of behaviour shouldn't break due to lack of a message. Another option is to fix the database so that key violations don't occur, and update the relevant bits to handle multiple messages.

We no longer block on database actions at all.

I'll leave this open for a while to actually ensure this is enough.


Temporarily restore Python 3.8 support

This temporarily reverts #1003 as we want to keep the 2.7.1 release small. We will un-revert it in a day or two once we make the 2.7.1 release.
This ended up being a bit tricker than I hoped since Ruff had rewritten a lot of type annotations to make them no longer compatible with 3.8, so I had to unwind that.

As usual pylint is giving useless warnings.

Giving up, don't have the bandwidth to fight pylint.

Draft PR to remove pylint in #1023


Quering nested resources using Restangular: ID missing in the nested resource

In my application, I have two REST resources,
To get the User based on the ID /users/123
To get the buddy details of the user /users/123/buddies/456
Below is the code I am using,
//get the user
Restangular.one("users", 123).get().then(function(user){
$scope.user = user;
});
Restangular makes a call to /users/123. So far so good.
//get the buddy
var getBuddy = function(){
$scope.user.one("buddies", "456").get();
}
But here, Restangular makes the call to /users/buddies/456 instead of /users/123/buddies/456.
I have gone through the samples provided and I can't spot a mistake. Do I need to do anything different?

Got the solution here https://github.com/mgonto/restangular#i-use-mongo-and-the-id-of-the-elements-is-_id-not-id-as-the-default-therefore-requests-are-sent-to-undefined-routes
Sorry, should have read the documents more carefully. Awesome library, thanks!!


context param name completed

Javacomplete2 look like can't complete context param name, such as
public void foo() {
    String str = "hi";
    st
}

It's can't complete 'str'.
I think if it can complete  context param name will make the wonderful plugin more perfect. I don't know will it need many workload. Just a little suggestion.

by the way, I find   java.util.Collections has same problem https://github.com/artur-shaik/vim-javacomplete2/issues/93

Consider switch to jc.nvim


Year & Periods appeared again after deletion

In Raj Associates deleted some year and periods but after an hour login again all deleted year & periods appeared again.

Its is Linked to Year Start Date from Settings
It YearStartDate is  1st January it will Create Year as 2019 Jan, 2019 Feb
else 2019-20 Jan, 2019-20 Feb


Chunking and dask memory errors

What is the standard way of sub-chunking to prevent dask memory errors?   For large dataset files there could be a dimension, say nCells, that is large enough to fill RAM.  If this occurs, is there an automatic mechanism to prevent out-of-memory errors in dask or is the user's responsibility to specify maximum chunk sizes on their own?

Currently it's the user's responsibility to choose appropriate chunk sizes for their workflow and available memory. Dask doesn't provide any functionality to help with this, though perhaps it could. You might raise an issue on the Dask issue tracker.

Thanks @shoyer.  This is what I was thinking but I just wanted to double check.  Feel free to close the issue if you would like- I'll move this to dask issues.


Keep etc\roles directory on Windows during upgrade

High-level description
Bootstrap requires the etc\roles directory and contents to exist. Tell winpanda to keep this directory during upgrade.
Corresponding DC/OS tickets (required)

D2IQ-ID JIRA title / short description.

Related tickets (optional)

D2IQ-ID JIRA title / short description.

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot request-review @DominikDary

@mesosphere-mergebot changelog-not-required unreleased code


Clarification on licence for elvish

This really isn't an issue as much as it is a question, I'm working on getting Elvish in Arch Linux's AUR and PacBSD's PUR and need to state which license this project uses.  Looking at the LICENSE.md file it looks like it's under the BSD 2-cause license.  Is this correct?

Never mind, looks like you beat me to uploading it to the AUR, and from there you have that it is MIT licensed.  That pretty much clarifies my question.

Ha it's actually BSD-licensed. A friend of mine did that and added me as co-maintainer afterwards. I need to fix that.
Thanks for your interest in elvish though! I am having much fun building it, and I hope you will have much fun playing with it.

I've been enjoying using elvish very much, and impressed how far the project has come along.   Hopefully when I can find some free time I could help contribute to it.  One area of interest would be to try and add Vi/Vim keybindings to Elvish.

@vendion vi/vim keybinding is something I would love to have but it's not very high on my priority queue, so helping hands are very welcome! By the way, be sure to start a discussion before you start working on the code since I might refactor the editor in the near future and it's important to be coordinate.


Make url paths consistent.

This PR makes the paths in the PatternPedia consistent. It introduces global constants for some path
segments.
Signed-off-by: LisaPodszun<EMAIL_ADDRESS>

hey @LisaPodszun can you check why the build is failing?

looks like the new lint rule's need to be applied (refer to developer docu:
✖ 1 problem (1 error, 0 warnings)
Lint errors found in the listed files.
Linting "pattern-pedia-e2e"...
All files pass linting.
/home/travis/build/PatternPedia/pattern-pedia-views-ui/src/app/core/model/pattern-language.model.ts
58:1  error  This line has a length of 161. Maximum allowed is 160  max-len
/home/travis/build/PatternPedia/pattern-pedia-views-ui/src/app/core/util/uri-converter.ts
84:1  error  This line has a length of 162. Maximum allowed is 160  max-len
✖ 2 problems (2 errors, 0 warnings)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
The command "yarn lint-ci" exited with 1.
32.51s$ yarn test-ci
yarn run v1.22.0
$ ng test --no-watch --no-progress --browsers=ChromeHeadlessNoSandbox
08 06 2020 10:07:08.367:INFO [karma-server]: Karma v4.0.1 server started at http://<IP_ADDRESS>:9876/
08 06 2020 10:07:08.373:INFO [launcher]: Launching browsers ChromeHeadlessNoSandbox with concurrency unlimited
08 06 2020 10:07:08.377:INFO [launcher]: Starting browser ChromeHeadless
08 06 2020 10:07:20.603:INFO [HeadlessChrome 83.0.4103 (Linux 0.0.0)]: Connected on socket BVqDiK-lO-C_wkOCAAAA with id 75378361
HeadlessChrome 83.0.4103 (Linux 0.0.0): Executed 0 of 9 SUCCESS (0 secs / 0 secs)
e 83.0.4103 (Linux 0.0.0): Executed 1 of 9 SUCCESS (0 secs / 0.225 secs)
e 83.0.4103 (Linux 0.0.0): Executed 2 of 9 SUCCESS (0 secs / 0.232 secs)
e 83.0.4103 (Linux 0.0.0): Executed 3 of 9 SUCCESS (0 secs / 0.237 secs)
''mat-form-field' is not a known element:

If 'mat-form-field' is an Angular component, then verify that it is part of this module.
If 'mat-form-field' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message.'
HeadlessChrome 83.0.4103 (Linux 0.0.0): Executed 3 of 9 SUCCESS (0 secs / 0.237 secs)
WARN: ''mat-form-field' is not a known element:
If 'mat-form-field' is an Angular component, then verify that it is part of this module.
If 'mat-form-field' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message.'
''mat-label' is not a known element:
If 'mat-label' is an Angular component, then verify that it is part of this module.
If 'mat-label' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message.'
HeadlessChrome 83.0.4103 (Linux 0.0.0): Executed 3 of 9 SUCCESS (0 secs / 0.237 secs)
WARN: ''mat-label' is not a known element:
If 'mat-label' is an Angular component, then verify that it is part of this module.
If 'mat-label' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message.'
''mat-list' is not a known element:
If 'mat-list' is an Angular component, then verify that it is part of this module.
If 'mat-list' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message.'
HeadlessChrome 83.0.4103 (Linux 0.0.0): Executed 3 of 9 SUCCESS (0 secs / 0.237 secs)
WARN: ''mat-list' is not a known element:
If 'mat-list' is an Angular component, then verify that it is part of this module.
If 'mat-list' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message.'
'Can't bind to 'ngModel' since it isn't a known property of 'textarea'.'
HeadlessChrome 83.0.4103 (Linux 0.0.0): Executed 3 of 9 SUCCESS (0 secs / 0.237 secs)
WARN: 'Can't bind to 'ngModel' since it isn't a known property of 'textarea'.'
e 83.0.4103 (Linux 0.0.0): Executed 4 of 9 SUCCESS (0 secs / 0.251 secs)
e 83.0.4103 (Linux 0.0.0): Executed 5 of 9 SUCCESS (0 secs / 0.254 secs)
e 83.0.4103 (Linux 0.0.0): Executed 6 of 9 SUCCESS (0 secs / 0.258 secs)
''mat-toolbar' is not a known element:
If 'mat-toolbar' is an Angular component, then verify that it is part of this module.
If 'mat-toolbar' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message.'
HeadlessChrome 83.0.4103 (Linux 0.0.0): Executed 6 of 9 SUCCESS (0 secs / 0.258 secs)
WARN: ''mat-toolbar' is not a known element:
If 'mat-toolbar' is an Angular component, then verify that it is part of this module.
If 'mat-toolbar' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message.'
''pp-navigate-back' is not a known element:
If 'pp-navigate-back' is an Angular component, then verify that it is part of this module.
If 'pp-navigate-back' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message.'
HeadlessChrome 83.0.4103 (Linux 0.0.0): Executed 6 of 9 SUCCESS (0 secs / 0.258 secs)
WARN: ''pp-navigate-back' is not a known element:
If 'pp-navigate-back' is an Angular component, then verify that it is part of this module.
If 'pp-navigate-back' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message.'
e 83.0.4103 (Linux 0.0.0): Executed 7 of 9 SUCCESS (0 secs / 0.267 secs)
e 83.0.4103 (Linux 0.0.0): Executed 8 of 9 SUCCESS (0 secs / 0.267 secs)
e 83.0.4103 (Linux 0.0.0): Executed 9 of 9 SUCCESS (0 secs / 0.272 secs)
e 83.0.4103 (Linux 0.0.0): Executed 9 of 9 SUCCESS (0.334 secs / 0.272 secs)

Looks like 2 lines exceeding the max-line length. The warnings from test-ci can be ignored here. The relevant part is the following:
/home/travis/build/PatternPedia/pattern-pedia-views-ui/src/app/core/model/pattern-language.model.ts
58:1 error This line has a length of 161. Maximum allowed is 160 max-len
/home/travis/build/PatternPedia/pattern-pedia-views-ui/src/app/core/util/uri-converter.ts
84:1 error This line has a length of 162. Maximum allowed is 160 max-len


New example showing how to use lark+qscintilla (Issue #150)

Sorry, fixed the previous PR which wasn't a proper mcve :/ , my bad. This one has a cleaned git history btw

I already fixed and merged the previous one. You can add your changes to it if you want.


util: add comment

What have you changed? (mandatory)
Improve comment for src/util
What are the type of the changes? (mandatory)

Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)
not necessary
Does this PR affect documentation (docs) update? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No

Thanks @brson

The descriptions here use the second person verb tense ("Write the log to file"), but I think it's easier to write in the third person ("Writes the log to file"). This is more noticeable and reads more naturally the more has to be written about a single function. The standard library uses third person, and I'd prefer doing the same. Second person does seem to be common throughout TiKV though so I'm not sure how to make that change, and don't think you should do it here.

Do we need to change all the person to the third person?
PTAL @lilin90 @queenypingcap

Some of the function descriptions begin by restating the name of the function, like "encode_u32 writes the encoded value".

@brson this is inherited by Golang, You may know that most of us are Gophers :-)
But now we must follow the Rust style.

@brson   Thank you very much!  I will address your comments.

@siddontang Yes.
When used for description, comments should be descriptive rather than imperative.
Opens the file    (right)
Open the file      (wrong)

Thanks for the prompt followup @Hijiao. It looks great now, though please do respond to @CaitinChen's comments still.

@tikv/pingcap-i18n  Please take a look, thanks!

@CaitinChen   Please take a look, thanks!

@Hijiao PTAL

@CaitinChen please take a look again :)

@CaitinChen  PTAL, thanks

@CaitinChen PTAL, thanks.


Generate panoramic view

I have a curve including sample points, how to generate a panorama from CBCT based on that curve?

I am not sure whether there is an ITK implementation of it, but it can be done in Slicer, and this repo is top google code result.

Thanks @dzenanz  for giving the Slicer reference.


ProxyToServerConnection localAddress usage

Seems to call both "bind" and "connect" on the Bootstrap. This was not working until I removed the "bind" call. The "connect" is all that is needed.

This LGTM. I'm curious, were there any performance implications do the superfluous bind()?

It didn't work. Any attempt to connect would timeout with the bind() in place. I am no netty expert, but the two operations appear to be mutually exclusive. At least based on fact they both return ChannelFuture rather than Bootstrap.
Note that I am using netty 4.0.28 in case that behaves differently.

I've tested it manually with Netty 4.0.23 (and 28) in my Linux environment with the address of my WLAN card:
HttpProxyServerBootstrap bootstrap = DefaultHttpProxyServer.bootstrap() //
        .withPort(port) //
        .withNetworkInterface(new InetSocketAddress("<IP_ADDRESS>", 0));

This (withNetworkInterface) is neccessary to set localAddress. (what's the difference to bootstrap.withAddress() ? )
With bind I've noticed some blocking behavior, but after timeouts the page seems to be loaded complete with all references. Without bind everything works well. So we should remove this line.

Okay, perhaps I was a little impatient and didn't see it eventually connect.
Difference to withAddress - that sets which interface the proxy will listen on (eg eth0). The withNetworkInterface determines which interface will handle the outgoing connection (eg a VPN, tun0). If not specified, it just uses the default gateway interface for the destination IP. Being able to set this means you can have multiple outbound adapters and let your application choose which one to use.

I'm satisfied. Any reason not to merge, @ganskef?

@andrewtaylor Great catch - thank you very much. I would descibe it a little more than didn't work :-) .
@jekh I'm happy with it. Let's merge.


fix: add the clusterrole of event for controller

The initial implement PR lacks of the clusterrole for Event. I forget it in last PR of fixing panic bug.

@NickrenREN Please check

closing since this is merged in upstream repo
/close


vercel-sdk

Function that can be called by a component that:

Takes a string
sends to ai api to summarize string
potentially formats as markdown?
returns ai output as string

No longer using Vercel AI SDK: OpenAI API is great for our use case (mainly no streamed text)


Multichoice dropdown exceeds page limits

When I have a multichoice ui element, and select many values, the visual element exceeds the page limits:

I have set a maximum layout width, and also tried to control the width of ui.dropdown.
Maybe it is also just me doing something wrong here.

Thanks for reporting @psinger, I will take a look at it.

@aalencar just create a multi-choice dropdown with many many options and then select them

@psinger ok, thank you!

After further investigation with @psinger we came to the conclusion that the behavior depicted above is caused by the presence of tooltip.
Repro:
# Form / Dropdown
# Use dropdowns to allow users to choose between available choices.
# #form #dropdown #choice
# ---
from h2o_wave import main, app, Q, ui

choices_dialog = [ui.choice(str(i), f'Option {i}') for i in range(1, 102)]
choices = [ui.choice(str(i), f'Option {i}') for i in range(1, 102)]

@app('/demo')
async def serve(q: Q):
    if not q.client.initialized:
        q.page['meta'] = ui.meta_card(box='', layouts=[
            ui.layout(
                # If the viewport width >= 0:
                breakpoint='xs',
                zones=[
                    ui.zone('form')
                ]
            )
        ])
        q.client.initialized = True
    if q.args.show_inputs:
        q.page['example'].items = [
            ui.text(f'dropdown_multi={q.args.dropdown_multi}'),
        ]
    else:
        q.page['example'] = ui.form_card(box='form', items=[
            ui.dropdown(name='dropdown_multi', width='200px', tooltip='aa', label='Pick multiple', values=['B', 'D'], required=True,
                        choices=choices, popup='never'),
        ])
    await q.page.save()

Click Select All.


Device status does not update

Describe the bug
When the device status is changed manually, it does not update in HomeKit. Version 1.6 is not updating device statue. Using version 1.6 works fine.
Expected behavior
For example then a lamp is turned on, It remains off in the Home app. On version 1.7.
The older version works fine.
Screenshots
If applicable, add screenshots to help explain your problem.
Device info (please complete the following information, which can be found in log):
request path = /v1.0/iot-01/associated-users/devices
like this:
{
"active_time":<PHONE_NUMBER>,
"biz_type": 18,
"category": "cz",
"create_time":<PHONE_NUMBER>,
"icon": "smart/product_icon/cz.png",
"id": "aaaaaaaaaaa",
"ip": "xxxxxxxxxxxxxxxx",
"lat": "30.30286857361191",
"local_key": "xxxxxxxxxxxxx",
"lon": "120.0639743842656",
"model": "",
"name": "Living Room Socket",
"online": false,
"owner_id": "34794909",
"product_id": "yfemiswbgjhddhcf",
"product_name": "Switch Product",
"status": [
{
"code": "switch",
"value": false
},
{
"code": "countdown_1",
"value": 0
},
{
"code": "cur_current",
"value": 0
},
{
"code": "cur_power",
"value": 0
},
{
"code": "cur_voltage",
"value": 2343
}
],
"sub": false,
"time_zone": "+08:00",
"uid": "xxxxxxxxxxxxxxxxxxx",
"update_time":<PHONE_NUMBER>,
"uuid": "xxxxxxxxxxxxxxxxxx"
}
Device functions (please complete the following information, which can be found in log):
request path = /v1.0/devices/functions
Same device Id, like this:
{
"category":"cl",
"devices":[
"aaaaaaaaaaa"
],
"functions":[
{
"code":"control",
"desc":"control",
"name":"control",
"type":"Enum",
"values":"{"range":["open","stop","close"]}"
},
{
"code":"percent_control",
"desc":"percent control",
"name":"percent control",
"type":"Integer",
"values":"{"unit":"%","min":0,"max":100,"scale":0,"step":1}"
},
{
"code":"control_back",
"desc":"control back",
"name":"control back",
"type":"Boolean",
"values":"{}"
}
],
"product_id":"xaabybja"
}
Additional context
Add any other context or logs about the problem here.

Is this fixed yet?

still not fixed.


[WIP] INTLY-7486

JIRA: https://issues.redhat.com/browse/INTLY-7486
This change ensures amq online url points to the parent console instead of address space on os3.
Reason for change
The AMQ console route has changed from console-proxy to console in the new AMQ version 1.4. It's path to the address space also has a new format.
After upgrade from rhmi 1.6 to 1.7, the dashboardUrl in the address space of the service instance still remained pointing to the console-proxy route which is being used by the webapp to populate the amq console links in the managed services menu and within the walkthroughs.
This dashboardurl field is managed by the AMQ service broker itself and cannot be modified once created.
Instead of pointing to the address space itself, we should point to the 'parent' amq console link. This will enable us to no longer rely on the dashboardUrl field in the service instance. It will also allow us to ensure that the url to the amq console will always be correct on future versions if it changes again. The AMQ url will now be made available to the webapp through the INSTALLED_SERVICES field.
Related Walkthrough changes: https://github.com/integr8ly/tutorial-web-app-walkthroughs/pull/137
Verification steps

Run the webapp locally and ensure you pass the following env var when running:

INSTALLED_SERVICES='{   "amq-online-standard":{       "Host":"https://console-openshift-enmasse.f2d1.rhmi-qe1.openshiftapps.com/"  }}'

Verified on OSD OS3:
Before amq was provisioned:

After amq was provisioned, each amq console link redirected you to the following url: https://console-openshift-enmasse.f2d1.rhmi-qe1.openshiftapps.com/#/address-spaces
This was also verified on OS4 by @pb82.
Changes did not affect routes in OS4. This change only affected the AMQ route on OS3.

ping @tiffanynolan


start.bat crashing when pick ban in-game opens

Greetings!
Since the new League of Legends patch 12.3. my Champselect UI is not responding!? I did everything step by step by the league-prod-toolkit/wiki Installation and it worked perfectly for me last month until this patch. I open start.bat, it initializes, then I open League Observer after opening League of Legends Client, and then it connects through the Observer tool normally. I open localhost:3003 and it shows me everything perfectly fine until I enter a game pick/ban lobby when my start.bat crashes and a JavaScript error pops up from League Observer. Please help!
Screenshot 2022-02-07 194444
!

That is most likely due to the fact that the static content for league is not finished downloading.
Sometimes it takes Riot a bit of time to publish this data. If you run into trouble after one or to days after a new patch, just set your version in the config to the last patch and try it again later. And please make sure it finishes downloading before you use it :)


add a readme file

Fix: https://github.com/casbin/SwiftCasbin/issues/12

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Performance improvements

Hello,
I am trying to improve the search performance of AutomationElements in an application.
At the moment, I found out that the standard methods are slower than a simple backtracking. But is there another way of improving the Search methods?
This method is faster than a .FindAllDescendants(docCondition). Any suggestions of doing a fast document Find?
private void TryFindAllOfType(AutomationElement element, ControlType type, ref List<AutomationElement> result)
{
  try
  {
     foreach (AutomationElement item in element.FindAllChildren())
     {
       if (item.Properties.ControlType.ValueOrDefault == type)
        result.Add(item);
     else
       TryFindAllOfType(item, type, ref buttons);
     }
  }
 catch (Exception ex) {   }
}

You aren’t respecting nesting of the same type, since you only call the recursion if the type doesn’t match.
Which I believe the method .FindAllDescendants(docCondition) isn’t doing, and also searches inside of controls of the given type.

FindAllDescendants is almost always slower than any other slightly optimized search routine. The best would always be to get to your item by just using FindFirstChild with a specific condition on each level until you reach your desired item.


Argo Workflows UI Crashes when having a misconfigured Sensor

Checklist

[x] Double-checked my configuration.
[x] Tested using the latest version.
[x] Used the Emissary executor.

Summary
What happened/what you expected to happen?
A new sensor was deployed with a typo having argument instead of arguments. When trying to load Argo Workflows UI, the UI was completely stuck highlighting the HTTP error response as be illustrated below:

From the workflow controller logs I could see that there are some healtz error logs:
level=info msg=healthz age=5m0s err="json: unknown field \"argument\"" instanceID= labelSelector="!workflows.argoproj.io/phase,!workflows.argoproj.io/controller-instanceid" managedNamespace=

The sensor was updated to remove the typo and was re-deployed. Argo Workflows UI was still broken. Using kubectl get wf -n default, it was noticed that these are failed workflows. After deleting such workflows, Argo Workfows UI came back to life.
What version are you running?
Argo Workflows v3.3.9.
The above scenario was tested also on Argo Workflows v3.3.7.  With this version, as expected Argo UI loaded and showed the respective workflow in error state.

Diagnostics
Paste the smallest workflow that reproduces the bug. We must be able to run the workflow.
Notice that it's reading argument and not arguments
apiVersion: argoproj.io/v1alpha1
kind: Sensor
metadata:
  name: webhook
spec:
  template:
    serviceAccountName: operate-workflow-sa
  dependencies:
    - name: test-dep
      eventSourceName: webhook
      eventName: example
  triggers:
    - template:
        name: webhook-workflow-trigger
        k8s:
          operation: create
          source:
            resource:
              apiVersion: argoproj.io/v1alpha1
              kind: Workflow
              metadata:
                generateName: webhook-
              spec:
                entrypoint: whalesay
                argument:
                  parameters:
                    - name: message
                      # the value will get overridden by event payload from test-dep
                      value: hello world
                templates:
                  - name: whalesay
                    inputs:
                      parameters:
                        - name: message
                    container:
                      image: docker/whalesay:latest
                      command: [cowsay]
                      args: ["{{inputs.parameters.message}}"]
          parameters:
            - src:
                dependencyName: test-dep
                contextKey: type
              dest: spec.arguments.parameters.0.value

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Work-around - delete the bad workflow.


Update package name input and access scope check

Allow Swift as a package name
Update AccessScope::isChildOf
Add more tests for package access level
Resolves rdar://106728606

@swift-ci smoke test

This PR addresses comments in https://github.com/apple/swift/pull/64230 as well as adds more tests. Merging this PR but feel free to leave any comments and they will be addressed in the upcoming PRs.

Thank you for testing this extensively, Ellie!


Add the ability to upload any files to s3

Description
This PR add the ability to upload just any file to S3, along with an IPA/APK or not.
Motivation
Uploading stuff to S3 is more and more common. Typically upload test screenshots after a snapshot run is a common usecase.
To avoid making another plugin (and another action i could not name!) and handling all the s3 auth complexity again: add the ability to pass files to upload to s3 along with the ipa file (or not)
May solve https://github.com/joshdholtz/fastlane-plugin-s3/issues/32

@joshdholtz following our talk yesterday.
I added the possibility to upload a complete folder to s3 🚀

Wow, this PR is what I need. (Hidden +1. Need to upload mapping.txt too, not just the apk)


Update the versions of vagrant and virtual box that are installed.

Grab recent versions of vagrant and virtual box as the defaults.

Updated by #175


HL-401: fix error that prevented applicant from sending messages

The allowed statuses are listed in APPLICANT_MESSAGE_ALLOWED_STATUSES
Also add validation that the handler must send a message first,
before the applicant is able to do so.

Description :sparkles:
Issues :bug: HL-401
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #661 (b7afb7b) into develop (0a81a0a) will increase coverage by 30.42%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           develop     #661       +/-   ##
============================================
+ Coverage    64.38%   94.80%   +30.42%
============================================
  Files          724      167      -557
  Lines        18271     6818    -11453
  Branches      1763        0     -1763
============================================
- Hits         11763     6464     -5299
+ Misses        6180      354     -5826
+ Partials       328        0      -328

Impacted Files
Coverage Δ

backend/benefit/messages/serializers.py
100.00% <100.00%> (ø)

backend/benefit/messages/tests/test_api.py
100.00% <100.00%> (ø)

backend/shared/shared/audit_log/viewsets.py
46.96% <0.00%> (-43.94%)
:arrow_down:

backend/shared/shared/azure_adfs/views.py
41.17% <0.00%> (-41.18%)
:arrow_down:

backend/shared/shared/audit_log/audit_logging.py
76.59% <0.00%> (-21.28%)
:arrow_down:

backend/shared/shared/common/tests/conftest.py
87.87% <0.00%> (-12.13%)
:arrow_down:

backend/shared/shared/oidc/auth.py
81.48% <0.00%> (-1.86%)
:arrow_down:

...yer/src/hooks/backend/useUpdateApplicationQuery.ts

...tend/shared/src/backend-api/BackendAPIProvider.tsx

frontend/shared/src/components/pages/ErrorPage.tsx

... and 554 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a81a0a...b7afb7b. Read the comment docs.


[INLONG-9558][Sort] Add Dameng Connector for flink 1.13

Prepare a Pull Request

Fixes #9558

Motivation
Dameng, Oceanbase and GaussDB are three widely used datasources which Inlong does not have support yet.
This pr supports dm datasource.
Modifications
Added the DM datasource
Verifying this change
This datasource has been tested in the production environment.
Documentation
The design doc is as follows:
https://doc.weixin.qq.com/doc/w3_AUcANQaJAFk4a11n0ZlRR0aTTeiHa?scode=AJEAIQdfAAod9AStYjAUcANQaJAFk
A more detailed doc will be introduced in later stages, after the code has been reviewed and is about to be merged.

please fix build failure thx