Building a lyrics search app with vanilla javascript

Article checklist
Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

@adrianmurage i have fixed the issue

👍🏽  @shegz101 I'll be looking over the changes later today

this closes #3990

@adrianmurage do I need to open a new pull request

@adrianmurage do I need to open a new pull request

No, just make changes here

@adrianmurage I have made all neccessary changes

@adrianmurage just checked my code editor, the quotes are wrong, funny how I never noticed this, how can I make changes without this pull request being closed

@adrianmurage i have sorted out the issues of the quotation marks, and I have corrected them with the right quotes

@adrianmurage i have sorted out the issues of the quotation marks, and I have corrected them with the right quotes

@shegz101 I'll take a look at it tomorrow
Have a lovely Sunday evening 👍🏽

@adrianmurage thanks for all you've done..looking forward to your reply tomorrow.

@adrianmurage can I know specifically the type of error, if it is the one about undefined, it's from the end of the API I am using


PFCOUNT does not work for multiple keys

I'm using version 0.4.1.
PFCOUNT is working for one key, but not working for multiple keys:
pfcount key1
> pfcount {user1}-hll1
(integer) 3
> pfcount {user1}-hll2
(integer) 2
> pfcount {user1}-hll1 {user1}-hll2
Error: Server closed the connection

is multiple keys for PFCOUNT not supported? or do I need to do some extra configuration to enable it?

@freedom1989 do you have a resolution for this?

https://github.com/twitter/twemproxy/pull/599/files should fix this

<IP_ADDRESS>:22121> pfadd pfkey a b c
(integer) 1
<IP_ADDRESS>:22121> pfadd pfkey1 d e f
(integer) 1
<IP_ADDRESS>:22121> PFCOUNT pfkey pfkey1
(integer) 6
<IP_ADDRESS>:22121> pfcount pfkey
(integer) 3
<IP_ADDRESS>:22121> pfcount pfkey1
(integer) 3

This works with twemproxy with a single backend server. Note that this will be inaccurate for multiple keys, especially with host ejection handling and failover patches planned for 0.6.0 making it harder to reason about whether keys should go to the same backend server


Top-Right technology's name is not shown on many sites.

Platform
Which platform does the bug apply to?

Web Extension (Version: 6.7.0)
Firefox Beta (Version: 89.0b15 (64-bit))

Describe the bug
On most sites that i visit, the Top-Right technology's name is not shown.
To Reproduce
Steps to reproduce the behavior:
https://www.prepaiddigitalsolutions.com/
https://www.programmableweb.com/

Go to any of this sites.
Click on the Wappalyzer extension.
Look at the Top-Right technology.

Expected behavior
The technology name should be shown as usual.
Additional context
Pictures:

Thanks, this is fixed in the upcoming update.


refactor: proper extends rootClasses

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[x] Refactoring

Context

refactoring smol stuff

Copilot Summary

🤖 Generated by Copilot at f68c27c
Refactored the NeoField component to use JavaScript instead of TypeScript and improved its styling and functionality with Oruga classes. Renamed the file NeoInput.vue to NeoField.vue to match the component name.

🤖 Generated by Copilot at f68c27c

NeoField transforms
From TypeScript to JavaScript
Oruga in autumn

made some changes in #6160 could you check if UI breaks?

made some changes in #6160 could you check if UI breaks?

fixed "expanded" props. the rest, looks same

Lets go!


fix(STONEINTG-1033): fix for format in status report

a fix for format in status report

Signed-off-by: Hongwei Liu<EMAIL_ADDRESS>Maintainers will complete the following section

[ ] Commit messages are descriptive enough (hints)
[ ] Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
[ ] Controllers diagrams are updated when PR changes controllers code  (if applicable)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.17%. Comparing base (5f676c1) to head (0391cb7).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
+ Coverage   69.07%   69.17%   +0.09%
==========================================
  Files          43       43
  Lines        4573     4581       +8
==========================================
+ Hits         3159     3169      +10
+ Misses       1075     1072       -3
- Partials      339      340       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LGTM

rosa & dashboard failures
will retest ,

/retest

/retest

failed on network issue
error: dial tcp: lookup api.kx-cfcfb588b7.l5qz.p3.openshiftapps.com on <IP_ADDRESS>:53: no such host
/restest


Apply darkmode on other projects page

fix  #131
Added the dark mode to the other project page

implemented the darkmode functions in the otherProjects.js
Added the light and dark mode variables to the CSS of the
otherProjects
Added the toggle switch on the otherProjects page
Updated the position of the toggle switch

Thanks! Merging

@all-contributors, please add @aliraza944 to the doc for their contribution

@all-contributors please add @JeffBucherDev to the doc for their contribution


Spm

spm interface added
imports fixed
example updated

No reason to keep Sources/DashdevsNetworking/Classes/.gitkeep

It's bad practice to have lowercased classes and file names: dashdevsnetworkingTests

Change dashdevsnetworkingTests class and file name, otherwise all good)

fixed


SDI: Workflow and technology to manage input data (OKR 2.3.7, 2.3.9, 3.4.1)

The Climate Modeling Alliance: Workflow and technology to manage input data (OKR 2.3.7, 2.3.9, 3.4.1)
Software Design Issue 📜
Purpose
This SDI describes challenges and proposes a solution on how to manage input data. This SDI expands the policy document drafted by @sbryne addressing the issues with large datasets and parallel runs.
Science and technical goals

Data should come with comprehensive metadata that includes sources, how the data was prepared, a version number, URLs, ...
Datasets should be reproducible, ideally from the original source with a single automated script
Data distribution should respect the licenses and additional requests attached to the data (e.g., if the data has to be acknowledged in a specific way)
It should be possible to run a simulation without having the data for components that are not used in that particular simulation
It should be possible to list all the datasets used in a particular simulation without having to dig through the source code
Users should not have to worry about downloading data, unless the size is larger than a given value
Datasets should be stored on reliable archival servers that are freely accessible and not tied to anyone's subscription

The technical solution
Background
The Julia language supports artifacts, pieces of non-source-code data that have to be distributed with a package. In Julia, artifacts are primarily used to distribute binary component that are needed to run a package (e.g., compiled libraries). Using the "official" data-distribution stream for Julia comes with several benefits that automatically check some of the boxes above, such as integrity verification and download on-demand.
Julia artifacts are tarballs declaratively defined in a package Artifact.toml file. They are accessed via the @artifact_str macro, which ensures that the artifact is present when it needs to be used. This might require downloading the artifact upon instantiation of the package (for greedy artifacts), or downloading it when needed (for lazy artifacts). Users do not have to worry about the artifacts being present or their location as everything is handled behind the scenes.
The Artifact.toml can contain additional fields that can be queried through the Pkg.Artifact APIs. For example, we can add the acknowledgment field to generate automatically a report on what has to be acknowledged for the datasets used for a given simulation. We do not need to about this too much now, but it is good to know that we are working with an extensible framework.
Building upon Artifacts
While Julia artifacts do not have all the capabilities we need, they provide a good starting point to build our solution. The three main shortcomings of Julia artifacts are that they don't handle large files, MPI runs, and they cannot process additional runtime information (e.g., if they are accessed). Pkg.Artifacts is modular enought that we implement the missing features.
This SDI proposes to develop a new (small) package ClimaArtifacts. ClimaArtifacts mainly provides two functionalities:

A new Julia artifact macro, @clima_artifact_str, which fills the gaps in @artifact_str, by handling parallel runs, artifact tagging, and all the complexity that we need but is not captured by Pkg.Artifacts
Tools to query and produce reports on the datasets used in a given simulation (e.g., which datasets were used, which papers have to be cited, ...) and other user-friendly utilities (e.g., to simplify the creation of an artifact). Only the tools that are currently needed will be developed at this time.

Large datasets (and compute clusters/CI)
Large datasets always require special treatment (where "large" is yet to be quantified). For instance, we cannot assume that any one folder is large enough to contain 1 TB of data. Instead, we need to the user take care of obtaining and storing that data where they see fit. Luckily, this can be handled directly with Pkg.Artifact.
The Julia artifact system provides a reasonably good way to connect external data with the artifact system (albeit, a little clunky to set up). Julia artifacts were developed to be distribute system libraries/binaries, but sometimes it is best to use the native library/binary on the system. To achieve this, Julia artifacts can be overridden with an Overrides.toml that specifies the path of a given artifact.
Our packages will keep track the required artifacts in the Artifacts.toml  but those that are too large will be marked as "not-downloadable" (by removing the .download section).
Let us look at an example
Artifact.toml
[rrtgmp]
git-tree-sha1 = "43563e7631a7eafae1f9f8d9d332e3de44ad7239"

   [[rrtgmp.download]]
   url = "https://data.caltech.edu/records/ppv8a-4q131/files/rrtmgp-lookup-data.tar.gz"
   sha256 = "e65d2f13f2085f2c279830e863292312a72930fee5ba3c792b14c33ce5c5cc58"

[era5]
git-tree-sha1 = "43563e7631a7eafae1f9f8d9d332e3de44ad7210"

The era5 artifact here cannot be downloaded because it does not have a .download section. Trying to use that dataset will yield an error. To use era5, users will have add a Overrides.toml in their Julia depot:
43563e7631a7eafae1f9f8d9d332e3de44ad7210 = "/groups/esm/data/era5"

The clunkiness in setting this up comes from the fact that everything is done with hashes. The benefit of using hashes is that multiple packages that use the same dataset will share the same files instead of requiring copies. A question and potential problem that has not been investigated yet is related to this. Pkg.Artifacts verifies the integrity of artifacts by computing and matching a cryptography hash. It has to be seen how this works when the artifact is a 1 TB folder. We suspect that the override system will automatically take care of this.
The Caltech cluster
On the Caltech cluster, several repositories use shared depots, so Overrides files are shared across users. Once set up, everything should just work.
At this point, we can use /groups/esm to store the data we need for runs. It has 30 TB of total space (24 TB currently used) and it is fast enough for our current needs. /groups/esm does not have purge policies.
Distributed computing is difficult
While handling large data files can be dealt with with relative ease, artifacts for parallel runs are much more complex. When we run our codes with MPI, multiple copies of the same executable are running at the same time. This means that if a piece of data is not available and has to be downloaded, multiple processes will try to fetch the data and store it in the same location. This is problematic for at least two reasons: (1) we don't want 100s of identical network requests at the same time, (2) we don't want 100s of processes to try to write the same file in the same place. Number (1) is good etiquette and might lead to performance degradation for everyone on the system (and for slow servers, as the ones that might host scientific data, also everyone using the server). On a good day, number (2) also leads to performance degradation, but most generally it leads to race conditions and kills the run.
The ideal solution to this problem is that only the root process downloads the data. In turn, this requires extending the artifact system to be MPI-aware. This is the key reason why we need a new module.
Some of the implementation details
The core logic of how artifacts are handled in Julia can be found here. The key is that @artifact_str does some basic processing and calls the (private) _artifact_str function for most of the heavy lifting. ClimaArtifacts will provide a new @artifact_str that does additional processing before invoking _artifact_str. @clima_artifact_str will be called with a small additional payload that contains the ClimaComms context (plus any additional structs that might be needed for tracking). When the context is not MPI, @clima_artifact_str will just call _artifact_str. When the context is MPI, @clima_artifact_str will first have the root process download the required artifact, and then call _artifact_str, ensuring that no additional download is performed.
Public and archival data storage
CaltechDATA offers free archival storage for datasets below 500 GB (and paid storage for larger datasets). We already have a community there. CaltechDATA seem to use Amazon S3 as backend and my first benchmarks seem to indicate that it is reasonably fast download speeds.
Those that wish to upload their data to CaltechDATA need to:
0. Curate their artifact

Make their profile visible on CaltechDATA from the settings
Get in touch with me or @szy21 to be added to the community
Accept the invitation to be part of the clima community

Process to add a new artifact
This section will be updated as the details become more clear

Create a project and script for creating the data in the repository

e.g. artifacts/<artifact-name>/create_artifact.jl
Cleaning/preprocessing into a convenient format
Pkg.Artifacts provides some helpful functions (ClimaArtifacts could automate some of this work)

create_artiface
archive_artifact

Check in the Project.toml and Manifest.toml
Add a README.md

What the artifact contains (files, links to sources)
Who created it, relevant citations
Any preprocessing performed
Include this in the archive

Upload and update the Artifacts.toml file.

Cost/Benefits/Risks
The main risk associated to the proposed solution is that we are adding a layer in between @artifact_str and _artifact_str. Future versions of Julia might change how this is implemented, leading to some maintenance work required.
The key benefit provided is that datasets will be handled in a unified (and for the most part transparent) way. In the process, we will document and list all the datasets that are being used. This will also fix issues as https://github.com/CliMA/ClimaLSM.jl/issues/423.
With this infrastructure, we will also be able to provide precomputed artifacts (e.g., topo maps already regridded to standard resolutions) that will speed up startup time.
People and Personnel

Lead: @Sbozzolo

Task Breakdown And Schedule
Next actions:

Prototype technical solution

Test case with MPI run and lazy artifact
Test case with larger dataset on Caltech cluster

Quantify what "large data" is
Go through all the repositories, compile list of all the artifacts

[ ] ClimaLSM
[ ] ClimaAtmos
[ ] ClimaCoupler
[ ] ClimaCore
[ ] ClimaOcean
[ ] SurfaceFluxes
[ ] Thermodynamics
[ ] RRTGMP
[ ] Insolation
[ ] More repos

Find people responsible for artifacts, have them document and provide a script to generate the artifact according to the policy
When artifact metadata is submitted, move them to the new system (upload them on CaltechData and use ClimaArtifacts)

CC
@tapios @simonbyrne @cmbengue

Thank you for the thorough and detailed plan! It looks good.
Could you please add some rough time estimates for the tasks (especially the first bullet)?

Thank you for the thorough and detailed plan! It looks good.
Could you please add some rough time estimates for the tasks (especially the first bullet)?

If no unexpected problems come up, the first bullet point will take one day of work for a draft implementation. We might have something by the end of this week.
What will take much longer is collecting the census of all the artifacts alongside their metadata (and the script needed to generate the datasets). However, this can be done in a perfectly incremental and non-disruptive way.

Sounds great!

This is implemented in ClimaArtifacts and ClimaUtilities.
As a test, I uploaded the fluxnet2015 data (41 GB) to the cluster. Any user that uses climacommon can access the data with
using Artifacts
fluxnet_data_folder = artifact"flunext2015"

as long as flunxet2015 is defined in the Artifacts.toml of their package. Accessing artifacts this way has 0 runtime cost. However, the preferred way to access artifacts is
using ClimaUtilities.ClimaArtifacts
fluxnet_data_folder = @clima_artifact("flunext2015"[, context])

When provided the ClimaComms context, this is MPI-safe. This has nearly 0 runtime costs, but it also keeps track on what artifacts are being accessed in a given simulation.
Among the other things, ClimaArtifacts:

fixes all the races conditions associates to MPI
fixes all the races conditions associated to Buildkite (when the artifact is uploaded with climacommon)
uses the "official" Julian way to handle external data, fixing the problems associated to ArtifactsWrappers (including non-determinism and corruption)
centralizes and cleans the artifacts we produce and use (artifacts will be required to have a script that reproduces them) and allows different packages to share the same artifacts
automatcally verifies the integrity of downloaded artifacts
provides a path to adding more metadata to the input data if we wanted to (e.g., license/required acknowledgments)

A user/developer guide is provided in the README. ClimaArtifacts also provides an interactive guided procedure to create new artifacts.
The next step in this is having someone who is not me trying to add and use a new artifact using the provided documentation.


Support additional CMake build options

This pull request proposes additional build options to the CMake-based install. Some files have been moved around/touched slightly also to facilitate some of these options/features, which are described below. These options would be helpful for building/shipping libsdptransform for use in package managers and other distributions.
The defaults for these new options have been set to follow the existing behavior at build right now (with no options), so build commands/scripts should work like before and produce the same build outputs.
The changes here are not trivial, so please advise if there's anything that you don't like here and we can hopefully find some happy medium or workaround.

Add option BUILD_TESTS. Default to ON (following existing behavior)
Add option BUILD_README_HELPER. Default to ON (following existing behavior).
Add option BUILD_SHARED_LIBS. Default to OFF (following existing behavior).
Add option USE_EXTERNAL_JSON. Default to OFF (following existing behavior).

BUILD_TESTS and BUILD_README_HELPER toggle whether contents in subdirectories test and readme-helper will be built.
BUILD_SHARED_LIBS toggles whether libsdptransform will be built as a static or shared library. add_library automatically checks the value of BUILD_SHARED_LIBS at configure/build time.
USE_EXTERNAL_JSON toggles whether an external (e.g. system) copy of nlohmann-json should be used instead of the bundled one. If enabled, CMake will automatically search for an installation of nlohmann-json on the system and configure step will fail if not found. If nlohmann-json is installed in a non-standard location, CMAKE_MODULE_PATH can be set so that CMake can find the nlohmann-json installation.
json.hpp has been moved from include/ to new folder thirdparty/, so that the thirdparty folder can be added as an include directory when external nlohmann-json is not in use.
include/sdptransform.hpp is now include/sdptransform.hpp.in. At configure time, the .hpp.in file is preprocessed into the build tree. This step is necessary in order to set the #include path to json.hpp in sdptransform.hpp.

@jmillan can you take a look?

Hi @alebcay,
I find the changes OK overall, but this PR modifies a file in sdptransform, which is an external dependency that cannot be modified here.

Thanks for taking a look.

I find the changes OK overall, but this PR modifies a file in sdptransform, which is an external dependency that cannot be modified here.

Just wanted to clarify - are you referring to sdptransform.hpp? And is the issue that I've modified it (touched the line for the #include "json.hpp"), or is the issue that the build now preprocesses this file at configure time (substitutes @JSON_HPP_LOCATION@ with include file path)?

sdptransform.hpp is part of a separate library that we include in libmediasoupclient. We cannot modify it here. Please look for sdptransform project in Versatica GitHub repositories.

I see, you are referring to https://github.com/versatica/libmediasoupclient/tree/v3/deps/libsdptransform.
Would the correct course of action be to open this PR in that repository instead, to make the changes there first?

I see, you are referring to https://github.com/versatica/libmediasoupclient/tree/v3/deps/libsdptransform.
Would the correct course of action be to open this PR in that repository instead, to make the changes there first?

Exactly :)
Then we release a new version of libsdptransform, and current PR must update it.

I see, thanks. It was unclear to me whether here or the other repository was the "upstream".
Can I make the CMake-related changes in this PR over there too? The modification to sdptransform.h needs to happen together with the CMake-related changes in this PR.

Not sure if I follow. Can you make a PR to libsdptransform, we release a new version and then you update this PR with that new version? See scripts/get-dep.sh in this repo.

Sure, opened https://github.com/versatica/libmediasoupclient/pull/125.

Ok. This PR already targets libdsptransform 🤦 , sorry for the confusion @alebcay. We were thinking it was targeting libmediasoupclient.
I just have one question:
- install(TARGETS sdptransform DESTINATION lib)
+ install(TARGETS sdptransform)

why the removal of the DESTINATION?

The sdptransform target contains a library (libsdptransform), and the implicit/default destination for installing those is lib.
It can be added back of course; my understanding however is that it's unnecessary.

@alebcay libsdptransform 1.2.10 has been released and comes with Catch v3. Can you adapt your PR to it?


Small typo

Hi! I copy-pasted the minimal example of the README.qmd. When I tested it with my own document, the in-text citations were not working properly. I finally found that it was simply caused by a small typo, where it should be written bibliography instead of bibliograpy:
https://github.com/wjschne/apaquarto/blob/25b79d335b3e6f1236cd03e8bd052707a2e4c9ca/README.qmd#L156
It is a small detail, but since it took me some time to find out, I thought you'd like to know (especially for new users). I also found the same typo on the related website:
https://wjschne.github.io/apaquarto/installation.html#an-existing-file
...
(Unrelated: Thank you for this amazing template! The instructions on the website are very clear 💯)

Thanks so much! The typo has been fixed.


Find my mouse with touchscreen buggy

Microsoft PowerToys version
0.82.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
Mouse Utilities
Steps to reproduce
Setup: a touchscreen laptop hooked up to a bigger no-touch display (Display set to extended)
I use the mouse normally and double click left CTRL to find the mouse pointer. It works.
Then I use the touchscreen with my hand, mouse pointer dissappears. When I now double click left CTRL , nothing happens (expected, as there is no mouse pointer visible).
Then I move the mouse and pointer reappears - now double click left CTRL should find the mouse again, but nothing happens.
Only after I have clicked the mouse once, find-my-mouse works again as it should
✔ Expected Behavior
Always find the mouse, as long as there is a mouse pointer visible
❌ Actual Behavior
does not work after using the touchscreen and then moving the mouse
Other Software
No response

/dup https://github.com/microsoft/PowerToys/issues/17315

i can't repro this,

click mouse via track pad
ctrl twice
find my mouse appears
click mouse to dismiss
touch screen on Windows Settings to cause touch screen pointer, cursor disappears as windows is in touch mode now
ctrl twice
FMM appears where touched
touch screen to disappear

seems to be fixed now. can't reproduce either.


[SPARK-24312][SQL] Upgrade to 2.3.3 for Hive Metastore Client 2.3

What changes were proposed in this pull request?
Hive 2.3.3 was released on April 3rd. This PR aims to upgrade Hive Metastore Client 2.3 from 2.3.2 to 2.3.3.
How was this patch tested?
Pass the Jenkins with the existing tests.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3323/
Test PASSed.

Merged build finished. Test PASSed.

Test build #90777 has finished for PR 21359 at commit 8b44f58.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90777/
Test FAILed.

Retest this please.

Test build #90798 has started for PR 21359 at commit 8b44f58.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3338/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90798/
Test PASSed.

@gatorsmile and @cloud-fan . Could you review this?

Oh, thank you, @gatorsmile !


Is there a way to access the each video frame and is it possible to add overlay object to video frame?

I am new to this. This is a question on iOS
I wonder if there is a way to access to image of each video frame. There is a UIImage *currentImage property in LFLiveSession, however, the LFLiveSession delegate callback is only triggered when live state change.
If I can access each video frame, I would like to overlay objects to the video frame. Is this possible?
Thanks

You can set a watermark view with   self.session?.warterMarkView = self.overlayView where overlayView is a simple UIView

thanks @y4nnick.
is there are way to access to each video frame? For instance, iOS provides this delegate AVCaptureVideoDataOutputSampleBufferDelegate in AVFoundation. LFLiveKit uses this as well in the GPUImageVideoCamera, however, what is the API to access so that I can get image from each video frame? What I want to do is the get image from each video frame, process the image to create a overlay (using waterMarkView). thanks

I don't know how you can get each frame out, but why aren't you just using the waterMarkView?
The watermark overlays over the original video.

I want to process each frame and update watermarkView in each frame. So I need to access each video frame.
I added a delegate to LFLiveSession
- (void)liveSession:(nullable LFLiveSession *)session pixelBuffer:(nullable CVPixelBufferRef)pixelBuffer;
and invoked this callback at - (void)captureOutput:(nullable LFVideoCapture *)capture pixelBuffer:(nullable CVPixelBufferRef)pixelBuffer
Not sure if it is best / right way to achieve thought. I am looking for is if LFLiveKit has an API or delegate that allow me to do that.

LFLiveSession @property (nonatomic, strong,readonly, nullable) UIImage *currentImage;

@chenliming777  thanks. I saw this property. Is there a delegate function or callback to notify the application that video frame has been updated where I can use currentImage property?

@chenliming777 Just want to follow up on this. I tried to use LFLiveSession currentImage and in
- (void)captureOutput:(nullable LFVideoCapture *)capture pixelBuffer:(nullable CVPixelBufferRef)pixelBuffer
however the currentImage is always nil, but the pixelBuffer isn't. Is this expected? I. could technically convert pixelBuffer to UIImage, but I don't want to do that for performance reason.
anybody else can advise? I basically want to have a callback to know each UIImage frame in the video.
thanks


auro-fineprint needs a different color

Describe the bug
The color of fineprint on the doc site and the color specified on the design specs are different.
To Reproduce
Steps to reproduce the behavior:

Compare https://auro.alaskaair.com/typography/usage and https://www.figma.com/file/Gl6R27DUvlKzbcpnpnvUAA/Fineprint?node-id=322%3A298

Expected behavior
Text color should be var(--auro-color-text-secondary-on-light) instead of var(--auro-color-text-primary-on-light).
Screenshots

Removed from RC. This is a bug and should be addressed and released right away.


DigitalOcean Appliance - Let's Encrypt Certificate Issues

After installing at 0.4.2, and updating as prompted to 0.4.3, when I add a Let's Encrypt certificate the process appears to complete but I am unable to access the site.
Various responses: -

Chrome says "- "ERR_SSL_VERSION_OR_CIPHER_MISMATCH""
Firefox times out.
Qualys SSL Labs test says "No response to Server".

After trying a couple of times I've nuked it and restarted accessing via IP address - happy to fire up another VM to recreate the issue if that would help.

I've just tried this again and it works for me. Things that could be going wrong @glimmung :

Did you point a domain name to your droplet with DNS entries A record @ pointing to your droplet IP?
Did you Use this domain name to reach your server when enabling let's encrypt? You may have to wait sometime for your browser to be able to use this domain name
Did you enter the same domain name as the base URL?
Did you restart saltcorn through It's admin panel when you had enabled let's encrypt?
do you continue to contact through domain name? HTTP through the ip address IP will no longer work

Here's what I did to enable just now: I have a domain name saltcorn.xyz. DNS is:

i use http://saltcorn.xyz to login as admin user
i set Base URL to: http://saltcorn.xyz in About application settings
and then enable let's encrypt and restart saltcorn -> 5 second wait, then page reloads, padlock appears in address bar, address is https://saltcorn.xyz

Thanks for the quick and detailed response. I will work through it again and pay more attention once DNS points at new IP. Thinking through, I wonder if I hit refresh before "restart[ing] saltcorn through It's admin panel when you had enabled let's encrypt", although I did then restart the VM just in case.

At the point that I enable Let's Encrypt, having checked the items to that point, the page comes back indicating that it's enabled. and a green link inviting me to restart the server appears - the issue kicks in when I click that link.
If I log in in under HTTP under incognito mode, the problem kicks in when I click "Restart server". I gave it 20 mins and then rebooted the VM.
If I wget/curl the HTTP URL I get a 301 redirect to HTTPS, if I go to the HTTPS URL I get "SSL_ERROR_SYSCALL"
On the balance of probabilities I'm doing something daft, I just can't figure out what. I've left that VM up and will try to puzzle it out - please let me know if you have pointers.

If you tell me the domain name you are using, i can check the DNS settings?
On Tue, Apr 6, 2021 at 12:37 PM glimmung @.***> wrote:

At the point that I enable Let's Encrypt, having checked the items to that
point, the page comes back indicating that it's enabled. and a green link
inviting me to restart the server appears - the issue kicks in when I click
that link.
If I log in in under HTTP under incognito mode, the problem kicks in when
I click "Restart server". I gave it 20 mins and then rebooted the VM.
If I wget/curl the HTTP URL I get a 301 redirect to HTTPS, if I go to the
HTTPS URL I get "SSL_ERROR_SYSCALL"
On the balance of probabilities I'm doing something daft, I just can't
figure out what. I've left that VM up and will try to puzzle it out -
please let me know if you have pointers.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/saltcorn/saltcorn/issues/687#issuecomment-814050342,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAKWHA5CKUI3WI5WL45YBTTHLXAJANCNFSM42OJFAUQ
.

Grepping for the hostname in JSON (looking for e.g. certbot setup), I found a reference to the "www." form. Added a CNAME record for, zapped the server and started again, and all seems well - it look as though the missing "www." form in DNS was the issue. I got one of DO's floating IPs so I could repeatedly nuke it without faffing with DNS.
The only other surprise was the inability to get to the insecure URL (I mean, that makes sense - but is contrary to what is suggested at  https://wiki.saltcorn.com/view/ShowPage?title=HTTPS encryption ).
Thanks for Saltcorn - I'm having a lot of fun!

I use the DigitalOcean template, but I ended up installing nginx, doing a reverse proxy, and installing certbot to handle this.

@mwdiers - I'm working on getting this going on Linode, because I prefer their backup/snapshot setup.
@glutamate  - I can ping www.saltcorn.xyz, and so I think that your example works because www. resolves. When I re-tested with a domain with a www. alias in place, all was well. When I went through the process on a domain with nothing under www. the server ended up dead as before.
I believe that the issue here is that the SSL provisioning expects to provision for the www. alias, fails when it cannot, and the error is not caught and leaves the SSL provisioning in an indeterminate state.

I think we should just get rid of the www subdomain.

I agree - I usually redirect www to the bare version or vice versa, but that'd be outside of Saltcorn, and aliasing it potentially causes confusion/complexity.

implemented in #707 / 0.4.4


Avoid interpreting KeyError and TypeError as method-not-found and invalid params

This addresses #72 and is targeted for the 5.0 branch.
The first two commits are already included in PR #94 .
A point for discussion is whether to keep AssertionErrors causing an InvalidParamsResponse. While assertions can be used for argument validation they might also simply check internal server invariants which should cause a generic server error.

Could we add the new exceptions without removing the existing ones? This way it’s not a breaking change. The removal of the existing ones can go into 5.0.

I just uploaded a new version with the legacy exceptions and rebased it onto #94. So, this can then directly go into 4.0?

Yep looks good, won’t break for existing users. It’s doing three different things, generally I’d prefer separate PRs, as it stands it’ll need extensive testing before accepting.

You could consider #94 first, which already includes the first three commits of this PR.

Still some outstanding comments on #94 @steinymity

Shouldn't that be suitable for the 4.x branch since I re-added the legacy except blocks (TypeError, KeyError) in dispatcher.py?
IMHO, for 5.0 we should really consider removing these exceptions to avoid misinterpreting random failures in methods.

Thanks for reminding me, I’ll merge into master

Merged into master.

@steinymity  I’m writing the changelog for the new release, and I’m not clear on why we’ve replaced TypeError with InvalidArgumentsError when checking the params against the function signature. TypeError is fine in this case.
InvalidArgumentsError should be to replace assert when validating user input. It should be explicitly raised inside methods. (In fact it should be InvalidParamsError to match the spec.)
But for checking the arguments against the signature, TypeError is sufficient in my opinion.

This is where I'm confused about where ApiError fits - the example you've given in the docs (invalid path) could really be raised as an InvalidParamsError.

Suggest we either scrap InvalidParamsError or ApiError, essentially they're the same.

But for checking the arguments against the signature, TypeError is sufficient in my opinion.
The disadvantage of just using TypeError is that it might just indicate a random programming error in a method — it is not necessarily a client-side error. So, responding with invalid params is not always reasonable.
The same actually applies to AssertionError — it might simply point to a server side error which has nothing to do with the client doing something wrong.

This is where I'm confused about where ApiError fits - the example you've given in the docs (invalid path) could really be raised as an InvalidParamsError.

Maybe the example does not fit perfectly. My reasoning was that reading a file might fail for a ton of reasons (see e.g. manpage read(2)) and the author of such a method might want to expose these details to the client. By using ApiError he can actually include errno and other data in the response. If reading a file failed it might point to a client error but there is no necessity that it actually does.

Let’s keep both since they’re different parts of the spec, but I’ll make a small adjustment to the invalid params exception.

Sure — I agree that InvalidParamsError is a better name and that catching AssertionErrors has several disadvantages.

The disadvantage of just using TypeError is that it might just indicate a random programming error in a method

This is true for AssertionError and KeyError, but TypeError is only being caught when we’re checking if the supplied values match the signature of the method. Not when the method is executed.

We still need InvalidParamsError for validating inside the method (replacing AssertionError).

TypeError is only being caught when we’re checking

Are you sure about that?
I just added this test case using the current master branch (d1deccd), and it fails:
def test_safe_call_method_failure():
    def fail():
        raise TypeError()

    response = safe_call(Request(method="fail", id=1), Methods(fail), debug=True)
    assert isinstance(response, ExceptionResponse)

According to the error message, safe_call indeed returns an InvalidParamsResponse:
E       assert False
E        +  where False = isinstance(<jsonrpcserver.response.InvalidParamsResponse object at 0x7f36f6533550>, ExceptionResponse)

When I only change raise TypeError() into raise ValueError(), the test passes.
Since handle_exceptions() is a context manager, exceptions thrown in the body of the with-clause, including inside the methods, are caught in handle_exceptions()'s try-except statement.

You're right, I thought it was being handled separately.
@steinymity I'm preparing the release PR, would you mind reviewing it when it's ready?

@bcb  No, I don't mind. I'm happy if I can help :) Just add me to the PR.

Great. Added you as reviewer to #100.


GH 1451

Description
A CLI Tool to generate a stub for new observability integrations
Issues Resolved
https://github.com/opensearch-project/observability/issues/1451
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@yaniveliash Thank you so much for your contribution. I see the DCO is failing on the pull request. Can you please provide sign-offs to your commits? You can checkout more details here: https://github.com/opensearch-project/observability/pull/1454/checks?check_run_id=11814492848

@yaniveliash Thank you so much for your contribution. I see the DCO is failing on the pull request. Can you please provide sign-offs to your commits? You can checkout more details here: https://github.com/opensearch-project/observability/pull/1454/checks?check_run_id=11814492848

Done
I'm pretty sure there will be more to fix ;-)

Hi @yaniveliash
Thanks again for your contribution .

can you plz add categories & collection section for user interaction ?

Can you plz add a README.md describing the flow of this CLI ?
thanks 🙏

IMO u can mark this PR as draft for now ...

Hi,
The requirements for the tool have been considerably fleshed out. The updated spec is available on issue #1451. Are you available to keep working on this?
For an initial PR, it would be sufficient to stub out the 3 described commands, create, package, and check. These can just be routed to different no-op methods with arguments. If you want to add more functionality on top of that, by all means, feel free to do so.

Closed for inactivity. The design of the CLI has changed considerably since the integrations project has taken off, so the modern form of it fills a different purpose. The current version of the CLI is available at the OpenSearch Catalog.


Render links in one method

Task linked: CU-86930ngwv Improve method

Task linked: CU-86930ngwv Improve method


Update Swashbuckle.AspNetCore to 6.8.1

Motivation and Context (Why the change? What's the scenario?)
Updated the Swashbuckle.AspNetCore package version from 6.8.0 to 6.8.1 in the Directory.Packages.props file.

merged into https://github.com/microsoft/kernel-memory/pull/815


About Requirements package version

Hi , Could you tell about the version of the packages ?

Hello，have you ever get the information of packages‘ version?


Editor doesn't recognize generic type without args<>,<,>,<,,>...

Thanks. Fixed.
PS: please you C# repository for reporting next issue https://github.com/consulo/consulo-csharp/issues


Added new login with spotify

As discussed into #107 the old anchor account is deprecated for new users.
So in this PR i've implemented the new login process using the spotify account. That can be activated setting the ANCHOR_LOGIN env variable to false.
By default that's set to true so up to now the anchor login remains the default one.
I've added to the yaml file the new secrets for running the action with SPOTIFY_EMAIL and SPOTIFY_PASSWORD, so here could be worth updating the action and .env docs too? I've already updated the .env.sample in this commit with the new env variables.
Any opinion on this?

@matevskial @abe-101 @TheJoin95

Refers to #113 too


Add rule to support ReactDOM (React 0.14 beta)

In React 0.14, JSX will use two packages, React and ReactDOM (see https://facebook.github.io/react/blog/2015/07/03/react-v0.14-beta-1.html). This adds a rule, jsx-uses-reactdom exactly similar to jsx-uses-react.
I took the approach of copying the jsx-uses-react rule rather than modifying it to take multiple vars to use. The relative merit of the approach I took is debatable.
I probably wouldn't accept this pull request until 0.14 goes out of beta but I found it useful for me today.

Mmm, if I understand correctly, the JSX elements still expands to a call to React.createElement so JSX will not use the ReactDOM package.
And for the calls to ReactDOM (like ReactDOM.render) the ESLint no-unused-vars rule will perfectly work.
Did I miss something?

Ooh, I thought this was extracting React.DOM instead of just the render methods (thus affecting jsx). The beta build in NPM supports your take. Sorry about that!


Small bugfix for temporary files.

I noticed growing number of docker-client-[something].tar.gz files in /tmp dir. Adding try-with-resources seems to fix the problem.

Codecov Report

Merging #987 into master will decrease coverage by 0.02%.
The diff coverage is 75%.

@@             Coverage Diff              @@
##             master     #987      +/-   ##
============================================
- Coverage     67.46%   67.44%   -0.03%
  Complexity      749      749
============================================
  Files           170      170
  Lines          3123     3124       +1
  Branches        354      355       +1
============================================
  Hits           2107     2107
  Misses          862      862
- Partials        154      155       +1


feat: allow configuring min tls for grpc

This will allow configuring grpc min grpc version very similarly to how we allow configuring the HTTP version.
Checklist

[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements
[x] A PR is opened to update our Helm chart repo
[x] A PR is opened to update the documentation on repo
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #6270

/run-e2e internal


Revert optional dependencies for cargo features

The automation shall no longer strip dev-dependencies before publishing, therefore the workaround of using dev-dependencies as optional dependencies (from #12768) will no longer be necessary.

Why was this closed? I think we often have this problem, or?

@ggwpez I found out that stripping dev-dependencies is regardless necessary (https://github.com/rust-lang/cargo/issues/4242 for context), but perhaps the stripping algorithm could be smarter as I mentioned in https://github.com/paritytech/substrate/pull/12899#pullrequestreview-1213033933.

Reopening to check a use-case


Rocm 2.9+Ubuntu18.04.3+rx580+tensorflow-rocm-2.0 could not retrieve ROCM device count: HIP_ERROR_NoDevice

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04.3
TensorFlow installed from (source or binary):binary
TensorFlow version:2.0.0(rocm)
Python version:3.6
Installed using virtualenv? pip? conda?:pip3
ROCm/MIOpen version:2.9
GPU model and memory:rx580 8G

rocm install is ok!
➜  ~ /opt/rocm/bin/rocm-smi

========================ROCm System Management Interface========================
================================================================================
GPU  Temp   AvgPwr   SCLK    MCLK     Fan     Perf  PwrCap  VRAM%  GPU%
0    31.0c  31.232W  600Mhz  1000Mhz  28.63%  auto  150.0W    5%   0%
================================================================================
==============================End of ROCm SMI Log ==============================

➜  ~ /opt/rocm/bin/rocminfo
ROCk module is loaded
dave is member of video group
=====================
HSA System Attributes
=====================
Runtime Version:         1.1
System Timestamp Freq.:  1000.000000MHz
Sig. Max Wait Duration:<PHONE_NUMBER>3709551615 (0xFFFFFFFFFFFFFFFF) (timestamp count)
Machine Model:           LARGE
System Endianness:       LITTLE

==========
HSA Agents
==========
*******
Agent 1
*******
  Name:                    Intel(R) Xeon(R) CPU E3-1231 v3 @ 3.40GHz
  Marketing Name:          Intel(R) Xeon(R) CPU E3-1231 v3 @ 3.40GHz
  Vendor Name:             CPU
  Feature:                 None specified
  Profile:                 FULL_PROFILE
  Float Round Mode:        NEAR
  Max Queue Number:        0(0x0)
  Queue Min Size:          0(0x0)
  Queue Max Size:          0(0x0)
  Queue Type:              MULTI
  Node:                    0
  Device Type:             CPU
  Cache Info:
    L1:                      32768(0x8000) KB
  Chip ID:                 0(0x0)
  Cacheline Size:          64(0x40)
  Max Clock Freq. (MHz):   3800
  BDFID:                   0
  Internal Node ID:        0
  Compute Unit:            8
  SIMDs per CU:            0
  Shader Engines:          0
  Shader Arrs. per Eng.:   0
  WatchPts on Addr. Ranges:1
  Features:                None
  Pool Info:
    Pool 1
      Segment:                 GLOBAL; FLAGS: KERNARG, FINE GRAINED
      Size:                    16387844(0xfa0f04) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Acessible by all:        TRUE
    Pool 2
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED
      Size:                    16387844(0xfa0f04) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Acessible by all:        TRUE
  ISA Info:
    N/A
*******
Agent 2
*******
  Name:                    gfx803
  Marketing Name:          Ellesmere [Radeon RX 470/480/570/570X/580/580X]
  Vendor Name:             AMD
  Feature:                 KERNEL_DISPATCH
  Profile:                 BASE_PROFILE
  Float Round Mode:        NEAR
  Max Queue Number:        128(0x80)
  Queue Min Size:          4096(0x1000)
  Queue Max Size:          131072(0x20000)
  Queue Type:              MULTI
  Node:                    1
  Device Type:             GPU
  Cache Info:
    L1:                      16(0x10) KB
  Chip ID:                 26591(0x67df)
  Cacheline Size:          64(0x40)
  Max Clock Freq. (MHz):   1380
  BDFID:                   256
  Internal Node ID:        1
  Compute Unit:            36
  SIMDs per CU:            4
  Shader Engines:          4
  Shader Arrs. per Eng.:   1
  WatchPts on Addr. Ranges:4
  Features:                KERNEL_DISPATCH
  Fast F16 Operation:      FALSE
  Wavefront Size:          64(0x40)
  Workgroup Max Size:      1024(0x400)
  Workgroup Max Size per Dimension:
    x                        1024(0x400)
    y                        1024(0x400)
    z                        1024(0x400)
  Max Waves Per CU:        40(0x28)
  Max Work-item Per CU:    2560(0xa00)
  Grid Max Size:<PHONE_NUMBER>(0xffffffff)
  Grid Max Size per Dimension:
    x<PHONE_NUMBER>(0xffffffff)
    y<PHONE_NUMBER>(0xffffffff)
    z<PHONE_NUMBER>(0xffffffff)
  Max fbarriers/Workgrp:   32
  Pool Info:
    Pool 1
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED
      Size:                    8388608(0x800000) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Alignment:         4KB
      Acessible by all:        FALSE
    Pool 2
      Segment:                 GROUP
      Size:                    64(0x40) KB
      Allocatable:             FALSE
      Alloc Granule:           0KB
      Alloc Alignment:         0KB
      Acessible by all:        FALSE
  ISA Info:
    ISA 1
      Name:                    amdgcn-amd-amdhsa--gfx803
      Machine Models:          HSA_MACHINE_MODEL_LARGE
      Profiles:                HSA_PROFILE_BASE
      Default Rounding Mode:   NEAR
      Default Rounding Mode:   NEAR
      Fast f16:                TRUE
      Workgroup Max Size:      1024(0x400)
      Workgroup Max Size per Dimension:
        x                        1024(0x400)
        y                        1024(0x400)
        z                        1024(0x400)
      Grid Max Size:<PHONE_NUMBER>(0xffffffff)
      Grid Max Size per Dimension:
        x<PHONE_NUMBER>(0xffffffff)
        y<PHONE_NUMBER>(0xffffffff)
        z<PHONE_NUMBER>(0xffffffff)
      FBarrier Max Size:       32
*** Done ***

Install tensorflow-rocm-2.0
pip3 install --user tensorflow-rocm=2.0 --upgrade

Using GPU errors
➜  ~ python3
Python 3.6.8 (default, Oct  7 2019, 12:59:55)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow as tf
>>> print("Num GPUs Available: ", len(tf.config.experimental.list_physical_devices('GPU')))
2019-11-05 18:59:08.171120: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libhip_hcc.so
No suitable runtime detected. Fall back to CPU!
2019-11-05 18:59:08.171466: E tensorflow/stream_executor/rocm/rocm_driver.cc:1032] could not retrieve ROCM device count: HIP_ERROR_NoDevice
Num GPUs Available:  0

Hi @davewang , to narrow down the issue, can you try to use the docker container per instructions below in the "overview" section:
https://hub.docker.com/r/rocm/tensorflow

using docker is ok!

@davewang , if it would work with docker, the issue is more likely to be related to your bare metal environment for ROCm.
We recommend to use docker container, however, if you do need bare metal configuration, the following instructions might help:

Clean up the bare metal ROCm packages

sudo apt autoremove -y rocminfo hsakmt-roct hsa-rocr-dev rocm-cmake hsa-ext-rocr-dev rocm-device-libs hip_base hip_samples rock-dkms

Follow the document below to install TF dependencies and TF whl package:

https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/blob/develop-upstream/rocm_docs/tensorflow-install-basic.md

Dear all,
I have encoutered the same issues running the tensorflow container using singularity 3.7.4
Rocm 4.2 is also installed on the host system.
singularity run --rocm -B `pwd`:$HOME,/group/pawsey0001/cdipietrantonio:/group/pawsey0001/cdipietrantonio /group/pawsey0001/cdipietrantonio/singularity/images/tensorflow_rocm4.2-tf2.5-dev.sif python3


⚠ Bofrost.at has degraded performance

In da059a7, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2727 ms

Resolved: Bofrost.at performance has improved in e2bcf01 after 6 minutes.


Update defaults for WandbLogger's run name and project name

What does this PR do?
Fixes #14054
Script to test the behavior if you want to play with it:
import os

import torch
from torch.utils.data import DataLoader, Dataset

from pytorch_lightning import LightningModule, Trainer
from pytorch_lightning.loggers import WandbLogger

class RandomDataset(Dataset):
    def __init__(self, size, length):
        self.len = length
        self.data = torch.randn(length, size)

    def __getitem__(self, index):
        return self.data[index]

    def __len__(self):
        return self.len

class BoringModel(LightningModule):
    def __init__(self):
        super().__init__()
        self.layer = torch.nn.Linear(32, 2)

    def forward(self, x):
        return self.layer(x)

    def training_step(self, batch, batch_idx):
        loss = self(batch).sum()
        self.log("train_loss", loss)
        return {"loss": loss}

    def on_train_start(self) -> None:
        print(self.trainer.logger.save_dir)
        print(self.trainer.logger.name)
        print(self.trainer.logger.version)

    def configure_optimizers(self):
        return torch.optim.SGD(self.layer.parameters(), lr=0.1)

def run():
    train_data = DataLoader(RandomDataset(32, 64), batch_size=2)

    model = BoringModel()
    logger = WandbLogger(project="this")
    trainer = Trainer(
        default_root_dir=os.getcwd(),
        limit_train_batches=1,
        limit_val_batches=1,
        limit_test_batches=1,
        num_sanity_val_steps=0,
        max_epochs=1,
        enable_model_summary=False,
        logger=logger,
    )
    trainer.fit(model, train_dataloaders=train_data)

if __name__ == "__main__":
    run()

Folder structure:

Wandb online record:

Does your PR introduce any breaking changes? If yes, please list them.
Yes, but they are necessary to satisfy the users.

name: used to return the wandb.Run.name, but now returns the project name.
Since name can't be None, we had to use a default name for the project name, and setting it to "lightning_logs" makes it more consistent with the other loggers.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
I made sure I had fun coding 🙃
cc @tchaton @rohitgr7 @borda @justusschock @awaelchli @morganmcg1 @borisdayma @scottire @manangoel99 @akihironitta

gatekeeper rerun


Default host to *

Set host to <IP_ADDRESS> only when we are certain the appstate feature will be enabled.

thanks!


Use nyc to allow coverage of es6 syntax

Coverage decreased (-2.9%) to 58.589% when pulling 86a6da597a5cc36283526231295ace9e0398b124 on fixed-circle-coverage into 44dfddb5985c1345b0c992dde4601d371607ddd5 on master.

Coverage decreased (-2.9%) to 58.589% when pulling 86a6da597a5cc36283526231295ace9e0398b124 on fixed-circle-coverage into 44dfddb5985c1345b0c992dde4601d371607ddd5 on master.

Coverage decreased (-2.9%) to 58.589% when pulling 86a6da597a5cc36283526231295ace9e0398b124 on fixed-circle-coverage into 44dfddb5985c1345b0c992dde4601d371607ddd5 on master.


TypeError: '<' not supported between instances of 'TorchVersion' and 'Version'

On running python generate.py in the main directory for the first time, I was met with this traceback:
Traceback (most recent call last):
  File "A:\Ai Overflow\Games\Oasis by Decart\open-oasis\generate.py", line 6, in <module>
    from dit import DiT_models
  File "A:\Ai Overflow\Games\Oasis by Decart\open-oasis\dit.py", line 12, in <module>
    from embeddings import Timesteps, TimestepEmbedding
  File "A:\Ai Overflow\Games\Oasis by Decart\open-oasis\embeddings.py", line 11, in <module>
    from diffusers.models.embeddings import TimestepEmbedding
  File "C:\Program Files\Python310\lib\site-packages\diffusers\__init__.py", line 3, in <module>
    from .configuration_utils import ConfigMixin
  File "C:\Program Files\Python310\lib\site-packages\diffusers\configuration_utils.py", line 34, in <module>
    from .utils import DIFFUSERS_CACHE, HUGGINGFACE_CO_RESOLVE_ENDPOINT, DummyObject, deprecate, logging
  File "C:\Program Files\Python310\lib\site-packages\diffusers\utils\__init__.py", line 22, in <module>
    from .import_utils import (
  File "C:\Program Files\Python310\lib\site-packages\diffusers\utils\import_utils.py", line 207, in <module>
    if torch.__version__ < version.Version("1.12"):
TypeError: '<' not supported between instances of 'TorchVersion' and 'Version'

I am running Windows 10 and using Python 3.10, if that's relevant at all. I wasn't sure this was going to work locally for me anyways at this point, but any help is nonetheless greatly appreciated!

I have the same issue


Build on RN <0.65 and Expo

Hey guys!
Thank you so much for your work, I love it. I just patched Android to make it build on RN <0.65 and Expo like @mrousavy did here: https://github.com/mrousavy/react-native-mmkv/pull/267/files
I'm going to send a PR :)

Hi, @axeldelafosse - Thanks for reporting this! We're still in alpha mode here, so we haven't focused too much on backwards compatibility and the multiple versions of RN yet.

was this PR accepted?

Not sure if there is a PR yet? We will support Expo - that is a high priority for us - but for now, we are still in alpha here and need to focus on becoming feature complete and stable first.

Hey guys-- sorry I'm pretty busy preparing the alpha release of the Showtime app. Here is the PR: https://github.com/Shopify/react-native-skia/pull/126. It also adds monorepo support.

Expo support is still very much under or radar but we are not yet ready for it. There are a couple of items we want to finish first.

@chrfalch Should we close this issue?

I would think so? It should be done :)


Remove loops argument from Mixer fade functions

Ref: #923 comment
In addition to the referenced comment, it doesn't make sense to loop a simple linear volume change over time.  That is, unless the underlying implementation actually plays the music, in that case, the implementation is probably incorrect.

The fade loop arguments are specific to and part of the SDL Mixer API. Requiring the loop arguments in the base Interface should be re-evaluated.

I'm not opposed to reconsidering this. We could just remove the loops part of the interface and assume that the user always wants the music to loop. I'm not sure in any of the times that I've used the playMusic or fadeInMusic interfaces I've ever used anything besides the default values. In the event that there's a point where we don't want it to be continuous we can address that later with a different interface function versus a paramter.

Closing as too similar to https://github.com/lairworks/nas2d-core/issues/945


vite3现在启动,需要惊人的20分钟,在windows上,macos则是3分钟,这非常影响效率

Describe the bug
vite3现在启动,需要惊人的20分钟,在windows上
Reproduction
aaa
Steps to reproduce
No response
System Info
vite3现在启动,需要惊人的20分钟,在windows上

Used Package Manager
pnpm
Logs
vite3现在启动,需要惊人的20分钟,在windows上
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

We can't know what the issue is without more information about your project, and a reproduction.

We can't know what the issue is without more information about your project, and a reproduction.

我提交了我们的代码,请重新开放问题

You've re-created an issue at https://github.com/vitejs/vite/issues/10993


Can't import package ml_insights

ML Inspector version: the latest version
Python 3.12.5:
Operating System: Windows

Description
I was trying to install ml_insights
But it failed to build wheel for splinecalib
What I Did
cmd: pip install ml_insights
Output:
Building wheels for collected packages: splinecalib
Building wheel for splinecalib (pyproject.toml) ... error
error: subprocess-exited-with-error
× Building wheel for splinecalib (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [12 lines of output]
running bdist_wheel
running build
running build_py
creating build
creating build\lib.win-amd64-cpython-312
creating build\lib.win-amd64-cpython-312\splinecalib
copying splinecalib\calib_utils.py -> build\lib.win-amd64-cpython-312\splinecalib
copying splinecalib\splinecalib.py -> build\lib.win-amd64-cpython-312\splinecalib
copying splinecalib_init_.py -> build\lib.win-amd64-cpython-312\splinecalib
running build_ext
building 'loss_fun_c' extension
error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for splinecalib
Failed to build splinecalib
ERROR: ERROR: Failed to build installable wheels for some pyproject.toml based projects (splinecalib)

Hi @Pak-02  - thanks for logging this issue.  I don't use Windows so not an expert on these problems, but what is happening is that the installer is looking for a C compiler since the code uses Cython (which compiles to C) for faster running code.  It looks like you need to install the version of Visual C++ mentioned.  Did you try looking through the link in the error message?
If you install Visual C++ as suggested it should be able to finish the installation.  Let me know if that helps.

Thank you so much, professor. I have set up it already


Adding a school or work account shows a dialog with code/url - this is not explained here

On adding a work or school account in Microsoft Authenticator, I get a dialog showing 2 text boxes "code" and "url" - I have no idea what these are supposed to be and the possibility of this dialog showing is not mentioned here at all. Is this a bug in the product or an omission in the documentation here?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5699f56d-758d-e3c2-cd44-571f9364dfef
Version Independent ID: 91ec729c-9ffd-a705-c03f-3608e01ce83a
Content: Add your work or school account to the Microsoft Authenticator app - Azure Active Directory
Content Source: articles/active-directory/user-help/user-help-auth-app-add-work-school-account.md
Service: active-directory
Sub-service: user-help
GitHub Login: @eross-msft
Microsoft Alias: lizross

@PandaWood Thanks for your feedback! We will investigate and update as appropriate.

@pandawood  I haven't seen these boxes before, it could be the way your organization has configured your system. Would you add screenshots of both of them, so I can dig a bit further into this? Thanks!

Hi,I since discovered these text boxes show if the authentication app does
not have access to the camera (on iPhone) - it doesn’t warn of no access to
the camera, it just shows these text boxes.
Worth a mention in the documentation
On Thu, 26 Sep 2019 at 12:13 am, Elizabeth Ross<EMAIL_ADDRESS>wrote:

@PandaWood https://github.com/PandaWood I haven't seen these boxes
before, it could be the way your organization has configured your system.
Would you add screenshots of both of them, so I can dig a bit further into
this? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/39432?email_source=notifications&email_token=AAAKETVGG7JO5AOG2R5WIY3QLNWYZA5CNFSM4IZ6DZPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7SBYYA#issuecomment-535043168,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAKETQONCQSCFF7YH3J7FLQLNWYZANCNFSM4IZ6DZPA
.

@PandaWood  We have a note that says, "If this is the first time you're setting up the Microsoft Authenticator app, you might receive a prompt asking whether to allow the app to access your camera (iOS) or to allow the app to take pictures and record video (Android). You must select Allow so the authenticator app can access your camera to take a picture of the QR code in the next step. If you don't allow the camera, you can still set up the authenticator app, but you'll need to add the code information manually. For information about how to add the code manually, see see Manually add an account to the app."
I'm guessing that the first time you set up the app, you didn't allow permission and its continued. You typically only get the access message once if you say no. If the app can't use your camera, you get those two boxes to manually enter your information.

#please-close

Still, the documentation should cater for the possibility that this camera
access issues might arise.
For me, it's definitely not the first time I set up the app, and I've never
knowingly denied access to the camera.
I've been using it for at least 1 year and have about 15 accounts.
I have changed phones in the last few months, and probably upgraded iOS
various times, so perhaps there is some bug in iOS that caused this.
On Fri, Sep 27, 2019 at 12:14 AM Elizabeth Ross<EMAIL_ADDRESS>wrote:

@PandaWood https://github.com/PandaWood We have a note that says, "If
this is the first time you're setting up the Microsoft Authenticator app,
you might receive a prompt asking whether to allow the app to access your
camera (iOS) or to allow the app to take pictures and record video
(Android). You must select Allow so the authenticator app can access
your camera to take a picture of the QR code in the next step. If you don't
allow the camera, you can still set up the authenticator app, but you'll
need to add the code information manually. For information about how to add
the code manually, see see Manually add an account to the app."
I'm guessing that the first time you set up the app, you didn't allow
permission and its continued. You typically only get the access message
once if you say no. If the app can't use your camera, you get those two
boxes to manually enter your information.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/39432?email_source=notifications&email_token=AAAKETSIT6KVCAJSMQHAQW3QLS7VPA5CNFSM4IZ6DZPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7VW2UQ#issuecomment-535522642,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAKETUTZGCAQMGVGZQZLHLQLS7VPANCNFSM4IZ6DZPA
.


add code coverage badge

https://stackoverflow.com/questions/59203704/how-create-a-badge-with-test-coverage-jacoco-on-github-actions

done


Adding existing EXIF information to resized image

Exif data now also available if Blob option selected. Using piexifjs since exifjs does currently not support writing.

@goodnic Thank you for your contribution and patience! While I appreciate the functionality introduced, I'm not entirely convinced by the new dependency introduced. So for the time being, I'll leave this open until I have time to do some due diligence and the current state of exif libraries available.

Closing this in favour of upcoming (hopefully) changes mentioned in #36.


calico3.2.0 kubernetes1.11

2018-08-27 08:57:45.294 [INFO][1] main.go 73: Loaded configuration from environment config=&config.Config{LogLevel:"info", ReconcilerPeriod:"5m", CompactionPeriod:"10m", EnabledControllers:"policy,profile,workloadendpoint,node", WorkloadEndpointWorkers:1, ProfileWorkers:1, PolicyWorkers:1, NodeWorkers:1, Kubeconfig:"", HealthEnabled:true}
2018-08-27 08:57:45.314 [FATAL][1] main.go 85: Failed to start error=failed to build kubernetes client config: invalid configuration: no configuration has been provided

Please fill out the issue template when raising new issues.
How did you install Calico? What environment is this running in?


product_items currently is mandatory

Hi @MarcosNicolau,
Should product_items from InteractiveActionSection be mandatory only for product type messages?
As state here: Required for Multi-Product Messages.
Currently it is mandatory regardless of the message type...

Yes you are right, I'll change it now.

I've also realized that the title and rows fields should be optional as well...


Unknown/Unsupported extension not handled

Describe the bug
When providing -x with some unknown extension, Tern will just skip ahead to creating a report without warning.
To Reproduce
Steps to reproduce the behavior:

Try tern report -x cve-bin-tool -i debian:buster
See no output for cve-bin-tool. The actual extension name is cve_bin_tool.

Expected behavior
A warning should show up saying "unknown extension" and list supporting extensions

Should the program exit in case of unsupported extension or continue creating a report but with a warning

@nishakm what do you think about @jaindhairyahere's question? I personally think Tern should exit in the case of an unsupported extension so the user doesn't waste time generating a report that does not have the extension information they are looking for...

I agree with @rnjudge that when an undefined extension is provided we should just exit with a CRITICAL error.

@nishakm If we want to utilize the existing Stevedore DriverManager which knows all about the names of the valid extensions, we have to untar the first layer prior to exiting if the extension name is not valid. Does this seem early enough to exit? (I think 23ish seconds to fail is reasonable considering tradeoffs). This would be the cleanest approach and look like this:
(ternenv) rjudge:tern$ tern report -x cve-bin-tool -i debian:buster
2022-02-10 13:54:07,700 - DEBUG - __main__ - Starting...
2022-02-10 13:54:07,700 - DEBUG - prep - Setting up...
2022-02-10 13:54:11,078 - DEBUG - rootfs - Running command: sudo chmod +x /home/rjudge/ternenv/tern/tern/tools/fs_hash.sh
2022-02-10 13:54:11,101 - DEBUG - run - Starting analysis...
2022-02-10 13:54:11,101 - DEBUG - skopeo - Attempting to pull image "debian:buster"
2022-02-10 13:54:11,101 - DEBUG - rootfs - Running command: skopeo copy docker://debian:buster dir:/home/rjudge/.tern/temp
2022-02-10 13:54:16,701 - DEBUG - skopeo - Inspecting remote image "debian:buster"
2022-02-10 13:54:16,702 - DEBUG - rootfs - Running command: skopeo inspect docker://debian:buster
2022-02-10 13:54:21,196 - DEBUG - rootfs - Running command: tar -tf /home/rjudge/.tern/temp/a024302f8a017855dd20a107ace079dd543c4bdfa8e7c11472771babbe298d2b
2022-02-10 13:54:21,985 - DEBUG - rootfs - Running command: tar -x -f /home/rjudge/.tern/temp/a024302f8a017855dd20a107ace079dd543c4bdfa8e7c11472771babbe298d2b -C /home/rjudge/.tern/temp/1/contents
2022-02-10 13:54:22,782 - DEBUG - rootfs - Running command: sudo /home/rjudge/ternenv/tern/tern/tools/fs_hash.sh /home/rjudge/.tern/temp/1/contents
2022-02-10 13:54:30,227 - CRITICAL - passthrough - Extension "cve-bin-tool" not found. Exiting.

The alternative is hard-coding the known extension names in main.py which feels brittle to me.

@rnjudge This looks good to me.


Small fix for is_preview messages.

Fixes reported issue where, when declaring a command group to be in preview, using commands in that group resulted in a double warning.
Before (not that the az group command group is not actually in preview):
(env) D:\github>az group list
This command group is in preview. It may be changed/removed in a future release.
Command group 'group' is in preview. It may be changed/removed in a future release.

After:
(env) D:\github>az group list
This command group is in preview. It may be changed/removed in a future release.

This checklist is used to make sure that common guidelines for a pull request are followed.

[N/A] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

/azurepipelines run


Build issue

The cloud profile build is not working properly with autoInstallPackage and autoInstallAll profiles. Fixing the same

Upgraded the versions of the content-package maven plugin to support contentFilePackage property
Using file-vault plugin to package examples
Removing bundles getting installed from the examples package
adding htl plugin for the examples as well. Though not being used currently

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[x] I ran all tests locally and they pass.

This is already merged, https://github.com/adobe/aem-core-forms-components/commit/9f4015efe370e8035250c8d065baade3d076f4df


Inconsistent font size in code samples

Describe the bug

Note how the text given is larger than the surrounding text.
I see in the dev tools that there are pretty different font-size rules applied to the control CSS class (1rem) vs the pre element (0.875rem). Disabling that part of the rule makes it look better so I don't think it's an issue with my setup.
To Reproduce
Steps to reproduce the behavior: View any page with code, notice that some keywords are larger than others.
Expected behavior
Code is all the same size.
Screenshots
See above.
Desktop (please complete the following information):
Running Mozilla/5.0 (X11; Linux x86_64; rv:130.0) Gecko/20100101 Firefox/130.0 on Fedora Linux 40 at a resolution of 1920x1200.
Smartphone (please complete the following information):
Additional context

@avuserow thank you for posting this issue. It is an irritating flaw once its been pointed out.
The problem is (almost certainly) in the syntax highlighting of code blocks, or rather the CSS associated with span classes within which the words are embedded. Some bad news and good news.

bad news: syntax highlighting with the tool chain used to render the Raku documentation suite is done with software that has not been maintained for several years. Further the highlighter was based on a NET framework that is itself out of date, and the only part of toolchain that uses NET. It has long been an aim to replace this software.
goodish news: two new syntax highlighters written in Rakudo have been developed in the last two/three months by @lizmat and @patrickbkr . These are used in the new RakuAST::RakuDoc renderer, so they will be used as soon as the new renderer can render the entire Raku documentation suite.

To fix the current problem, without waiting for the new rendering, it will be necessary:

identify which of the categories are given 0.75em and which are not
why there is a difference
Highlighting SCSS can be located in this distribution under Website/plugins/hiliter/scss, and the colors are labelled cm-ayaya. The colors are defined separately for the light and dark themes.

I did look quickly at the SCSS, but it will take rather more time to sort out than I have at this moment.
If you think this needs solving now, your help in finding a consistent fix would be appreciated.
Since there will be new span classes, all of the CSS will need to be changed. The new highlighters classify keywords differently, and there are different categories keywords are put into.

@avuserow We have just changed the syntax highlighter, from one developed for the Atom editor to one that has been developed entirely in Raku (its called Rainbow).
The change will no doubt have different problems.
Would you please look to see if the issue raised here has been solved?

@avuserow I found the code snippet you cited above. The new highlighter does not change the font.
Closing this issue as resolved


Can't install gluonts.model completely

I did install GluonTS on a cluster via pip install gluonts but I'm unable to use from _gluonts.model.deepar import DeepAREstimator_  and gluonts.model.transformer import TransformerEstimator since it is not defined, getting ModuleNotFoundError. I don't know why I can't install the whole models in gluonts via pip install gluonts command line. I'm using python 3.8.2 version on Macbook, but as mentioned above, I'm installing  _gluonts_ on a Cluster in virtual machine.
Any help would be appreciated @lostella et al :)

@ArianKhorasani does that do it?

@ArianKhorasani does that do it?

Yes, @lostella! Thanks for your help! for DeepAREstimator, it's working as you mentioned, but I'm facing issues while using TransformerEstimator, I'm using from gluonts.model.transformer import TransformerEstimator but getting error that It is not defined. please note that I have already installed gluonts for torch and mxnet!
I did try gluonts.mx.model.transformer import TransformerEstimator which works fine, but I was looking for torch models and using TransformerModel there too!
Appreciate your suggestions!


Using "---" in an email draft results in text replacement and removed linebreak

When you type three dashes in an email draft, save the draft and re-open it, it's replaced with a full-length line of underscores, and removes a linebreak.
To Reproduce
Start a new email draft. Write
Line 1
---
Line 2

Save the draft and re-open it.
It becomes
Line 1_____________________________________________
Line 2

Expected behavior
Keep text as-is
Environment (please complete the following information):

K-9 Mail version: 5.6
Android version: 10
Device: LG G8
Account type: imap

Hi, I can confirm this issue in the newest version with a small different. The do not show any underscore.
I extract the source code of the mail:
From: xxx<EMAIL_ADDRESS>Subject:
User-Agent: K-9 Mail for Android
Message-ID<EMAIL_ADDRESS>MIME-Version: 1.0
Content-Type: multipart/alternative;
 boundary=----OMHCJFFSQWKFVUCYFTUGOAAB7LMQ6Z
Content-Transfer-Encoding: 7bit
X-K9mail-Identity: !l=8&o=0&pl=11&po=0&qs=PREFIX&f=HTML&p=9&q=NONE

------OMHCJFFSQWKFVUCYFTUGOAAB7LMQ6Z
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

L1
---
L1
------OMHCJFFSQWKFVUCYFTUGOAAB7LMQ6Z
Content-Type: text/html;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

L1<hr>L1
------OMHCJFFSQWKFVUCYFTUGOAAB7LMQ6Z--

Environment (please complete the following information):

K-9 Mail version: 5.714 SNAPSHOT
Android version: 8
Device: SHIFT 6m
Account type: imap

Hi @cketti, hi @kurupted,
I'm currently not sure, if it is a bug or a feature. The problem is the class DividerReplacer that is used by creating html from the plain text. In this class three or more signs of -,= or _ are replaced in a divider. This result in this problem.