Pipe mode can't work

Hi, awesome work! I use it as a reference for the unified-engine. I noticed that
echo "test" | alex

or here  can't work because the files option is always set and therefore the std stream is ignored. In my project I use a flag called --stdin to indentify the pipe mode and wheather he wants to redirect the output to a file or to stdout.

Any suggestions on what we should do?
I’m thinking something along the following pseudo-code lines:
if (input.length !== 0) {
  // use args
} else if (process.stdin.isTTY) {
  // definitely no stdin. use defaults
} else {
  someFunctionToReadFromStdin(function (_, buf) {
    if (buf) {
      // definitely stdin
    } else {
      // no data on stdin, use defaults.
    }
  })
}

/CC @sindresorhus - What do you think?

Here's how I handle it: https://github.com/sindresorhus/strip-css-comments-cli/blob/ac32c3a959b3bc7cfc6c994b48c05b747bf9260b/cli.js#L34-L43

Right, but we have default globs if there’s no input 😬


Docker Compose up -d fails to launch clickhouse reporter due to image platform mismatch

When running docker-compose up -d to launch the clickhouse reporter, the following error occurred:
! gitlab-exporter-clickhouse-recorder-migrate The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested 0.0s
! gitlab-exporter-clickhouse-recorder The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested 0.0s
! gitlab-exporter The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested 0.0s
dependency failed to start: container clickhouse exited (126)
It appears that the requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8), and no specific platform was requested. This is preventing the clickhouse reporter container from starting.

Steps to reproduce:
Run docker-compose up -d to launch the clickhouse reporter.
Expected result:
Clickhouse reporter container starts successfully.
Actual result:
Clickhouse reporter container fails to start due to image platform mismatch.
Additional information:
Docker version: 4.29
Docker Compose version: v2.26.1
Operating system: MacOS 14.4 (Sonoma)

Hi, yeah I've only built linux/amd64 container images for now.
Can you try adding
platform: linux/amd64

to the docker-compose.yaml?


CLI a warning is missing when using an old version of benchopt

A warning is missing when using an old Benchopt version with a more recent benchmark.
For example, with version 1.2.0, when user run :
benchopt run . --config example_config.yml --env
The output is :
Launching benchopt in env benchopt_benchmark_lasso
Usage: benchopt run [OPTIONS] BENCHMARK
Try 'benchopt run -h' for help.

Error: No such option: --output

to make the issue clearer: The issue is that the env benchopt_benchmark_lasso was created with benchopt 1.2.0, then benchopt was updated to 1.2.1.devXX in the main env.
We should issue a warning if there is a discrepancy between the version in the env where benchopt run -e is called and in the env where it is actuallly run.


Version 1.4.0 rc

Sync version-1.4.0-rc to main prior to making more changes to tie up loose ends. Splitting closed https://github.com/p4lang/p4runtime/pull/496 into separate "sync" and "update changelog" PRs.

Instead of merging/squashing, I wonder if we should we be rebasing instead?
I'm a bit worried about potentially losing history otherwise?

Thanks for bringing this up. In hindsight, I think we should omit the squashing and preserve the same commits as main.
What benefit would rebasing have?

Also, arggghh: Look slike I inherited 4 missing signoffs:
https://github.com/p4lang/p4runtime/pull/498/checks?check_run_id=29638974713

Rebasing does exactly that -- preserve all the commits from main without change.
It also puts your extra commits on top and gets rid of the merge commit, so less noise in the history.
And of course, that means you don't inherit things like missing sign offs :)
But it does mean you may have to deal with some merge conflicts when rebasing.

@smolkaj I rebased and force-pushed, check out the commits and see if it satisfies. Thanks for the idea. I also did commit --amend -s to fix one missing signoff of my own, but there are four remaining, see checks. What do you think the best way to handle this is? There are caveats about rewriting history which I'm unsure about.

@smolkaj @jafingerhut Any suggestions how to resolve the unsigned commits? Conventional wisdom is to rebase -s but also warns about force-pushing public commits. Shall I just go ahead and back-sign those commits anyway?

@chrispsommers you shouldn't force push to a branch that's not in your own repo (fork) usually. The unsigned commits predate the addition of the DCO check to this repo AFAIK. These 4 commits were also not authored by you, so you should not be signing them anyway. This is also mentioned in the DCO help page:

You should only do this if:

You are the only author of the commits in this branch
You are absolutely certain nobody else is doing any work based upon this branch

The best thing to do is to ignore the DCO check here. The check should only apply to new contributions, it is not relevant to previous contributions that you are cherry-picking / merging into another branch.

@antoninbas Thanks for jumping in! I am working from a forked branch in my repo, so any forcing would be done on that branch.
Assuming I follow your advice and ignore the DCO check, should I be able to merge into version-1.4.0-rc w/o problems?

I am not certain, but the DCO settings on this repo might be still "DCO optional", meaning that people with the right permissions can merge PRs that fail the DCO checks anyway if they wish.  Some p4lang repos (maybe only p4c right now?) are "DCO mandatory", and do not permit that.
If this repo is still in "DCO optional", I'd say go for forcing the merge regardless of DCO failures for now, but plan ahead for a few months from now that you might want to try getting all PRs passing the DCO check, in case you want to do branching/merging stuff that would be blocked by failing DCO checks.

As maintainer you should also see a little escape hatch :)

Sorry for leading you astray here, Chris. I'm not used to this "fork of a fork of main" workflow, I guess rebase + force push is not recommended in that case. If we're okay with making an exception this time around, you should be able to do
git push -f origin version-1.4.0-rc

but of course that bypasses the review process.
(I double checked that force push to the main branch is disabled, so at least there should be no danger of accidentally corrupting main.)
What is the typical review process in this "fork of a fork of main" model? Do people review once when things get merged into the feature branch, and then again when the feature branch gets merged into main?

As maintainer you should also see a little escape hatch :)
@fruffy Nice, thanks for pointing this out!

Closed, superseded by https://github.com/p4lang/p4runtime/pull/499


cmake: missing CMakeLists.txt in lib/chck

Hi, tried to configure fresh clone of wlc and got this error:
CMake Error at CMake/subproject.cmake:39 (add_subdirectory):
  The source directory

    /home/marek/src/wlc/lib/chck

  does not contain a CMakeLists.txt file.
Call Stack (most recent call first):
  lib/CMakeLists.txt:5 (add_subproject)

Oh, yeah, I forgot to update submodules, my bad. Sorry for filing this issue.
But maybe that could be checked by cmake and an error message about submodules raised?

I think the error there already has enough clues to figure out. The submodule updated is after all documented in readme. Closing.


ASP.NET Core configuration preferentially treats appsettings file instead of IConfiguration

ASP.NET Core SDK only
Actual:
AddApplicationInsightsTelemetry is "favoring" configuration from appsettings.json.
Expected:
AddApplicationInsightsTelemetry should simply respect IConfiguration, which is fully controlled by application owner.
To Reproduce
See https://github.com/MicrosoftDocs/azure-docs/issues/90862
Rootcause:
https://github.com/microsoft/ApplicationInsights-dotnet/blob/main/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/DefaultApplicationInsightsServiceConfigureOptions.cs#L36-L43
^ This first loads user's IConfiguration, then loads appsettings.json. This causes appsettings.json to override.
https://github.com/microsoft/ApplicationInsights-dotnet/blob/main/NETCORE/src/Microsoft.ApplicationInsights.WorkerService/DefaultApplicationInsightsServiceConfigureOptions.cs#L31https://github.com/microsoft/ApplicationInsights-dotnet/blob/main/NETCORE/src/Microsoft.ApplicationInsights.WorkerService/DefaultApplicationInsightsServiceConfigureOptions.cs#L31
WorkerService does not have this issue. So, I think this added to maintain backward compatibility when the feature was added to AddApplicationInsightsTelemetry() to automatically read IConfiguration.

I think the reason is:
Prior to ~2.15, AddApplicationInisghtsTelemetry() ONLY considered appsettings.json to look for config.
in 2.15, it was modified to fetch user's IConfiguration and look for config inside it. Since the previous behavior was to only read settings from appsettings.json, in the new behavior, appsettings.json was treated "preferentially".
For a new user, this might be confusing/surprising, though it was done for a reason, which made sense for migrating users.
At this stage, I think the best option, is to do nothing, and document that appsettings.json settings overrides anything else.
Workarounds include: Use the overload AddApplicationInsightsTelemetry(IConfiguration).

Being new to AppInsights myself, I had to digest all of this and realized that I should be using the method signature which takes in my version of IConfiguration. The documentation does call it out but should likely better reinforce this concept and explain the behavior.  I would expect IConfiguration to be used by default and for it to be the sole source of truth and never overridden by re-reading from appsettings.json as I have overloads i.e. the typical per-environment file approach.
What I found after switching to that method signature was that I lost the ability to tweak the 'options' in conjunction with loading from the referenced instance of IConfiguration - which I had been leveraging that to explicitly set the Developer Mode based on my own specific logic.
It seems like now I have to find the equivalent way to explicitly set it in my appsettings.json file - or overload files - otherwise it looks like I'd have to set if by code where I resolve & use the TelemetryConfiguration/Channel (I think). I'd much rather do it once in the same place I'm registering things.

... I lost the ability to tweak the 'options' in conjunction with loading from the referenced instance of IConfiguration

Perhaps we need an overload of AddApplicationInsightsTelemetry that takes an IConfiguration and a delegate (Action<ApplicationInsightsServiceOptions>)
Alternatively, does this work:
services.AddApplicationInsightsTelemetry(options =>
{
    configuration.Bind("ApplicationInsights", options);
    // TODO: Modify options.DeveloperMode as required
});

where configuration is your configuration root object. If your code doesn't already have it in hand, it may be available on the builder context object.

Yes, having that in addition to the IConfiguration argument on the method would be very useful IMO. Also sounds like it should be fairly trivial to support.
I'll have to see if the other workaround can be used, but I'd much rather use the 'official' approach rather than trying to sort of hack at it - I'm assuming that internally it's just doing that binding to a named config section but I wouldn't want to assume that and try to recreate/stay in sync with what the official code is doing.
For now I'm just going to try and leverage the appsettings.json file and set it; Which I believe I found an example where it's just an element under "ApplicationInsights" with the expected name of "DeveloperMode" so I can make that work for me for now.


feat(circle): add total amount of members

Related: HELP-1204
Already done on the ViewMembers page for bodies, but not for circles.

:tada: This PR is included in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


python -m discord -v Fails.

Summary
Running python -m discord -v fails due to left-over code from discord.py.
Reproduction Steps
Install discord.py-self and run python -m discord -v.
(venv) ➜  src git:(master) ✗ python -m discord -v
Traceback (most recent call last):
  File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/root/code/Templates/Selfbot/venv/lib/python3.9/site-packages/discord/__main__.py", line 298, in <module>
    main()
  File "/root/code/Templates/Selfbot/venv/lib/python3.9/site-packages/discord/__main__.py", line 295, in main
    args.func(parser, args)
  File "/root/code/Templates/Selfbot/venv/lib/python3.9/site-packages/discord/__main__.py", line 52, in core
    show_version()
  File "/root/code/Templates/Selfbot/venv/lib/python3.9/site-packages/discord/__main__.py", line 41, in show_version
    pkg = pkg_resources.get_distribution('discord.py')
  File "/root/code/Templates/Selfbot/venv/lib/python3.9/site-packages/pkg_resources/__init__.py", line 466, in get_distribution
    dist = get_provider(dist)
  File "/root/code/Templates/Selfbot/venv/lib/python3.9/site-packages/pkg_resources/__init__.py", line 342, in get_provider
    return working_set.find(moduleOrReq) or require(str(moduleOrReq))[0]
  File "/root/code/Templates/Selfbot/venv/lib/python3.9/site-packages/pkg_resources/__init__.py", line 886, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/root/code/Templates/Selfbot/venv/lib/python3.9/site-packages/pkg_resources/__init__.py", line 772, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'discord.py' distribution was not found and is required by the application

This occurs because Line 41 of __main.py__ contains code that refers to normal discord.py.
Using commit 0f2dda9dd4392039576243a27fc34f7ab9542e2e

Fixed by #241.

@dolfies uh, would it be fine if you didn't fix this yourself? I want to get more commits here >-<

Since #241 won't conflict I don't need to

Fixed.


It draw won games vs floating buildings

Fix that by going air if that happens

Possibly solved by #80

#80 failed bug I think its fixed by #102 need to be tested on the ladder still


Cannot find module '@nestjs-plus/common'

The solution is to just install it, but figured either it should be a dep in this package's package.json file or specify in the docs to also install this module.
(originally posted this as a secondary issue in #58)

@jubairsaidi What version of @nestjs-plus/rabbitmq are you currently using?

@jubairsaidi Thanks for bringing attention to this. I'm surprised that it had gone unnoticed for a while. I've published a new version 1.4.3 of @nestjs-plus/rabbitmq that fixes this issue

awesome! thanks!


Create release.yml

Just to note, using the default github token for releasing will create a release under the name of "github-actions", instead of yourself.
For other actions the github token is sufficient.

Also the changelog generation template is .grenrc (other formats also accepted), so you may want to set that up beforehand.
Some of the template options doesn't work in gren Release unfortunately in my case, so some things I copy and paste in after the release is made.

Ah ok, thanks.  Yeah I'm new to GitHub actions, I've only worked with Jenkins and AppVeyor in the past.


Add multiplayer auto-start countdown timer

Prereqs:

[ ] https://github.com/ppy/osu/pull/17402
[ ] https://github.com/ppy/osu-server-spectator/pull/109
[x] https://github.com/ppy/osu-web/pull/8740

I haven't looked through the code yet, but I'm a bit confused as to how this is intended to work. If the host isn't ready, should the countdown not start?
https://user-images.githubusercontent.com/191335/160071277-2f2d4178-a4da-451a-9fbc-ab34af94a0e1.mp4
I'd argue that it should probably start even when the host isn't ready, for cases like "host rotate" where the host may be afk?

Didn't notice the base PR wasn't merged yet, so I pushed some changes here that alter the behaviour of normal countdowns too as discussed in Discord. I can try moving them to the base PR upon request though it wouldn't be a pretty change.

I've deployed this to the dev server for further testing.


Mono export templates lack mono shared libs on Linux system using /usr/lib64

Godot version:
3.2 master (5a23ab61)
OS/device including version:
Linux, RPM-based distro or similar using /usr/lib64 for 64-bit libraries (versus /usr/lib on Debian-based distros).
Issue description:
Our current logic to copy shared mono libraries to the export templates' data.mono.* folders rely on mono_root + 'lib':
https://github.com/godotengine/godot/blob/5a23ab61fae79cce576fe7ec60fd928d2bd27fca/modules/mono/build_scripts/mono_configure.py#L389-L396
This fails on 64-bit RPM-based distros where mono is installed in /usr/lib64 instead of /usr/lib.
We should rely on pkg-config when available to figure out what is the proper lib folder, and otherwise the logic should be (pseudo code):
if 64bit build:
  if lib64 exists: use lib64 (rpm)
  else: use lib (deb)
elif 32bit build:
  if lib32 exists: use lib32 (deb)
  else: use lib (rpm)

That's not all though, as mono hardcodes those installation paths, so trying to load a fix data.mono with the libraries in Mono/lib will still fail:
System.TypeInitializationException: The type initializer for 'System.Random' threw an exception. ---> System.DllNotFoundException: /home/akien/tmp/godot/test-export/lin/data_DodgeTheCreepsCS/Mono/lib/../lib64/libmono-native.so

So the data folder would need to have:
Mono/bin/*
Mono/lib/  (empty)
Mono/lib64/*

I'm not sure how we can influence the base path before ../lib64/libmono-native.so, but if we can change it, it should likely point to Mono/bin/ instead of Mono/lib/, so that we can have either:
Mono/bin/*
Mono/lib/*

or
Mono/bin/*
Mono/lib64/*

depending on whether the template was packaged on Ubuntu or CentOS, basically.

That's not all though, as mono hardcodes those installation paths, so trying to load a fix data.mono with the libraries in Mono/lib will still fail:
System.TypeInitializationException: The type initializer for 'System.Random' threw an exception. ---> >System.DllNotFoundException: /home/akien/tmp/godot/test-export/lin/data_DodgeTheCreepsCS/Mono/lib/../lib64/libmono-native.so

We can use a dlopen fallback to find the so at the right location, just like we're doing on Android.

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?

Yes, this is still reproducible any time I do a local build on my system (Mageia).
With this hack + manually creating a lib64 symlink to lib in bin/GodotSharp/Mono/ I can then use the compiled binary properly:
diff --git a/modules/mono/build_scripts/mono_configure.py b/modules/mono/build_scripts/mono_configure.py
index<PHONE_NUMBER>..ec731a4773 100644
--- a/modules/mono/build_scripts/mono_configure.py
+++ b/modules/mono/build_scripts/mono_configure.py
@@ -510,6 +510,8 @@ def copy_mono_shared_libs(env, mono_root, target_mono_root_dir):
     def copy_if_exists(src, dst):
         if os.path.isfile(src):
             copy(src, dst)
+            return True
+        return False

     platform = env["platform"]

@@ -562,7 +564,8 @@ def copy_mono_shared_libs(env, mono_root, target_mono_root_dir):
             ]

         for lib_file_name in lib_file_names:
-            copy_if_exists(os.path.join(mono_root, "lib", lib_file_name), target_mono_lib_dir)
+            if not copy_if_exists(os.path.join(mono_root, "lib64", lib_file_name), target_mono_lib_dir):
+                copy_if_exists(os.path.join(mono_root, "lib", lib_file_name), target_mono_lib_dir)

 def pkgconfig_try_find_mono_root(mono_lib_names, sharedlib_ext):

Any reason that hack isn't good enough to merge?
I've been failing to get a locally built binary to work on Fedora and it seems like this is why.

Any reason that hack isn't good enough to merge?

It only does part of what's needed, I still need to copy or symlink lib64 to lib manually, so it's not a good solution. The symlink could also be created from Python but that too is too much of a hack.
Might be possible to copy /usr/lib64 and rename to lib though.


Add possibility to create GitHub gist from SQL and/or CSS

For future reference or training purposes, I often create GitHub gists from my CartoDB SQL and/or CSS (most often a combination of the two, such as: https://gist.github.com/peterdesmet/8555766). I love it if this could be done directly from CartoDB, with the click of a button.
GitHub gists has an API.

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


p2p: use the same shutdown context for all components

Motivation

Closes #1313

Changes

make all p2p components share the same shutdown context so they can be in sync wrt to shutdown timeing.
Test Plan

unit tests
TODO

[ ] Explain motivation or link existing issue(s)
[ ] Test changes and document test plan
[ ] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

@y0sher i accidentally changed go.sum in this PR. i will revert it in the next iteration after your first round of review.

bors merge


ASP.NET Core Example

Why isn't there an ASP.NET Core Example here?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 245ef8a4-a811-19b7-676c-aa9b82e2126f
Version Independent ID: ad2ec743-2aa7-b3c7-3350-2986a78d7c90
Content: What is Azure Active Directory B2C?
Content Source: articles/active-directory-b2c/active-directory-b2c-overview.md
Service: active-directory-b2c
GitHub Login: @davidmu1
Microsoft Alias: davidmu

FYI, the ASP.NET Core team has added some documentation for this.  Perhaps some links can be added?
https://docs.microsoft.com/en-us/aspnet/core/security/authentication/azure-ad-b2c?view=aspnetcore-2.1
https://docs.microsoft.com/en-us/aspnet/core/security/authentication/azure-ad-b2c-webapi?view=aspnetcore-2.1

@spottedmahn Thanks for the feedback !  I have assigned the issue to the content author to investigate and update the document as appropriate.

Quickstarts have a very specific purpose and structure. One isn't there because it just hasn't been created yet :) We have opened an item in our documentation backlog to have this investigated and updated. We'll respond back to you on this issue when we've done the work. For now, we'll close this GitHub issue.
#please-close


Fix category picker and make use of NodeCategory component to show icons

Fix category picker.

@adlius this is a change that should have broken a test -- at some point, we should update this test to check that the option text is rendered, and also invoke the component in block form (<form.select ... as |option|>...</form.select>).

@adlius this is a change that should have broken a test -- at some point, we should update this test to check that the option text is rendered, and also invoke the component in block form (<form.select ... as |option|>...</form.select>).

Good call. I'll make a notion ticket to address.


feat: upgraded bitKeepWallet

Hi, Team tronprotocol,
This PR upgrades bitkeep wallet to the bitget wallet to make it easier for our users to connect to tronwallet-adapter dapps.
Please let me know if anything needs to be added or changed to satisfy your requirements.
Cheers,
Bitget Wallet team

Thank you very much! We will merge the PR and publish a new version later.

hello, does the bitget wallet app support Tron Dapp? I found that there is not window.tronLink or window.tronWeb in Bitget Wallet App browser.

Hello, does the bitget wallet app support Tron Dapp? I found that there is no window.tronLink or window.tronWeb. And i can not use Tron Dapp anymore.


TypeError: Class constructor BasicTracerProvider cannot be invoked without 'new'

What happened?
Steps to Reproduce

clone the reproduction repository link git
run docker compose up: this spins up grafana and tempo with collectors enabled. grafana
npm install
npm run dev
open http://localhost:3000 and wait till NextJS compiles the pages
See terminal output

Expected Result
No errors.
Actual Result
TypeError: Class constructor BasicTracerProvider cannot be invoked without 'new'
    at new WebTracerProvider (webpack-internal:///(ssr)/./node_modules/@opentelemetry/sdk-trace-web/build/esm/WebTracerProvider.js:51:28)
    at initTelemetry (webpack-internal:///(ssr)/./src/lib/otel/instrumentation.client.ts:44:22)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:540:9)
    at process.processTimers (node:internal/timers:514:7)

Additional Details
The tracing seems to work fine. I added a test button that triggers a client side trace which is correctly processed.
However, additional logging doesn't seem to be processed (when using .addProcessor but I think this is because it already errors out on the initial trace execution.
Attempts to work-around / fix the issue

update the packages to latest version. version .0.44.0 of the OTLP http exporter currently has an issue with sending the traces
directly import the WebTracerProvider from @opentelemetry/sdk-trace-web/build/esm -or- /build/esnext
setup otel the same as the web example
copy/paste the NextJS sample project

Extra info
I've tried a couple of versions of all the @opentelemetry/ packages and sometimes it's a different class that cannot be instantiated but it boils down to the same error. Like here
OpenTelemetry Setup Code
see /src/lib/otel/instrumentation.client.ts

Relevant log output
TypeError: Class constructor BasicTracerProvider cannot be invoked without 'new'
    at new WebTracerProvider (webpack-internal:///(ssr)/./node_modules/@opentelemetry/sdk-trace-web/build/esm/WebTracerProvider.js:51:28)
    at initTelemetry (webpack-internal:///(ssr)/./src/lib/otel/instrumentation.client.ts:44:22)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:540:9)
    at process.processTimers (node:internal/timers:514:7)

I updated all the NPM packages to the latest version and updated the OTEL stack. I still get an error but not the same as I had. Also the traces are coming in. They are still a bit bloated but at least it seems to be doing something.
The following error still appears but maybe that's because of how the @opentelemetry package is bundled?
Import trace for requested module:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>./src/lib/otel/instrumentation.client.ts
./src/components/otel.tsx

I converted the repo from an issue reproduction to a working OTEL implementation. Maybe it helps others struggling with getting it all setup. I ignored the warning in the webpack config.
Will close the issue now.


Insert small delay before starting node-local-dns

What this PR does / why we need it:
On some slow at the boot systems it may happen (race condition) that nodelocal dns will start before kube-proxy and that will mess up whole iptables setup. To make room for kube-proxy to be first to run we delay node-local-dns at the start s little bit.
This is TEMPORARY workaround, until the time when node-local-dns would start supporting iptables-nft
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1037
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Fix race condition between kube-proxy and node-local-dns

/cherrypick release/v1.0


Use profiling to determine whether to always use the adjusted splay trees.

Even for reads or membership testing, one need to keep the self-adjusted trees after the operation so that the amortized analysis really applies. However, this should be determined by profiling.

I have done a little profiling, and as far as I can tell, using lists is slightly faster than using splay trees. My testing is completely unscientific, of course, but here's some data from running on our hardest proofs (in ua.prl):
with splay trees in abt lib, telescopes
0.73 seconds of CPU time (0.36 seconds GC)
                         function                           cur
---------------------------------------------------------- -----
<gc>                                                       33.0%
SplayTree.splay                                             5.5%
SplayTree.findAndSplay                                      5.5%
Abt.makeAppTerm                                             4.6%
LnScope.liftTraversal                                       4.6%
Abt.abtRec                                                  3.7%
Abt.makeVarTerm                                             3.7%
Abt.sort                                                    2.8%
SplayRDict.map                                              2.8%
Abt.check                                                   1.8%
Abt.infer                                                   1.8%
FinalPrettyPrinter.sequence_                                1.8%
SplayRDict.operate'                                         1.8%
SplayRDict.foldl                                            1.8%
Abt.outb                                                    0.9%
Abt.assertSortEq                                            0.9%
Abt.instantiateAbt                                          0.9%
SplayRDict.find                                             0.9%
RedPrlLrValsFun.ParserData.Header.Jdg.makeAtLvl.fn          0.9%
RedPrlLrValsFun.ParserData.Actions.actions.fn               0.9%
RedPrlLrValsFun.ParserData.Actions.actions.fn               0.9%
Ast.annotate                                                0.9%
SplayRDict.singleton                                        0.9%
RedPrlTactical.orelse_.fn                                   0.9%
SplayRDict.insert'                                          0.9%
LcfTactic.eachSeq                                           0.9%
ListDeque.showcons                                          0.9%
LcfTactic.unifySubtelescopeAux                              0.9%
Refiner.StepEqNeuByUnfold.fn                                0.9%
LnScope.intoScope                                           0.9%
Abt.abstractAbt                                             0.9%
RefinerTypeRules.InternalizedEquality.TypeFromTrueEqAtType  0.9%
Telescope.Internal.ConsView.out                             0.9%
SplayRDict.singleton                                        0.9%
DictFun.union                                               0.9%
Abt.makeMetaTerm                                            0.9%
Abt.systemAnnLub                                            0.9%
LnScope.outScope                                            0.9%
Abt.instantiateAbt.shouldTraverse                           0.9%
Sequence.new                                                0.9%
Integer.fmt                                                 0.9%

with lists in abt lib, telescopes
0.64 seconds of CPU time (0.26 seconds GC)
                         function                           cur
---------------------------------------------------------- -----
<gc>                                                       28.9%
Abt.infer                                                   5.6%
Abt.makeAppTerm                                             4.4%
LnScope.intoScope                                           4.4%
RedPrlAtomicJudgment.map.fn                                 3.3%
General.o                                                   3.3%
Sequence.append                                             3.3%
Abt.abstractAbt                                             2.2%
LnScope.liftTraversal                                       2.2%
DictFun.singleton                                           2.2%
Abt.sort                                                    2.2%
LcfTactic.wrap.fn                                           2.2%
Abt.makeVarTerm                                             2.2%
ListPreDict.map                                             2.2%
ListPreDict.lookup                                          1.1%
LcfTactic.rule                                              1.1%
ListPreDict.foldl                                           1.1%
Abt.instantiateAbt                                          1.1%
ListPreDict.find                                            1.1%
RedPrlSequent.relabelHyps                                   1.1%
ListPreDict.operate'                                        1.1%
ListPreDict.insert'                                         1.1%
Ast.annotate                                                1.1%
Abt.outb                                                    1.1%
ListDeque.showcons                                          1.1%
RedPrlSequent.telescopeEq                                   1.1%
RefinerTypeRules.Fun.Eta                                    1.1%
RefinerTypeRules.InternalizedEquality.TypeFromTrueEqAtType  1.1%
RefinerTypeRules.Fun.SynthApp                               1.1%
Refiner.Equality.VarFromTrue                                1.1%
Telescope.Internal.map                                      1.1%
ListPreDict.map.fn                                          1.1%
TermPrinter.ppOperator                                      1.1%
ListPreDict.operate'                                        1.1%
Abt.eq                                                      1.1%
TermPrinter.ppBinder                                        1.1%
TermPrinter.ppTerm                                          1.1%
Abt.inferb                                                  1.1%
RedPrlLexFun.makeLexer.lex.continue.scan                    1.1%
ContextUtil.merge                                           1.1%
Abt.check                                                   1.1%
RedPrlOperator.arity.fn                                     1.1%

Thanks. This issue was actually for different usage of splay trees but I will update the title. What is Abt.makeAppTerm doing, I wonder?


CLI interface for modules

Routing might be similar to current pages routing, but cli sub-directory inside module directory will be used (similarly to how admin and api directories are used).
System should be aware of CLI requests similarly to how it is aware about API request and should not render HTML page in response.
Question about how to print results is still open.

Expected UX
Simplest case
./cli clean_cache:System/optimization or php cli clean_cache:System/optimization
Where clean_cache is analogy for HTTP method and System/optimization is path.
Basically, for API call it would look like: CLEAN_CACHE /api/System/optimization
With arguments:
./cli clean_cache:System/optimization --path_prefix=languages --force
./cli clean_cache:System/optimization --path_prefix="languages" --force
./cli clean_cache:System/optimization --path_prefix='languages' --force
If there is no = after key - this is boolean argument with true value.
If argument value starts with ' or " than value is taken in quotes, escape internal quotes if needed.
With data
Data piped to cli might be obtained with regular STDIN stream and parsed as necessary

Initial support landed in 4edca1e

https://github.com/wp-cli/php-cli-tools bundled with system as primary CLI output tool since c1b03cf

Since 214a559 ./cli cli:* calls for printing available paths and methods are supported

Added support for help: command on System module and few CLI paths/methods in e508a19

Generally, implementation is ready


Implement filesystem check

Description
Implementation of the filesystem check operation.
The implementation is fairly straight forward with a HEAD call being made for each active file to check if it exists.
A remove action is then made for each file that is orphaned.
An alternative solution is instead to maintain a hashset with all active files and then recursively list all files. If the file exists then remove from the set. All remaining files in the set are then considered orphaned.
Looking for feedback and if the second approach is preferred I can make the changes
Related Issue(s)

closes #1092

Instead of heading each individual file, wouldn't it be more efficient to issue an prefixed list call to gather all current files in the table? This way, we can reduce API call count by about 1000x.

@houqp I modified the process to instead use a list call but I'm not quite sure on how I would take advantage of prefixes in this case. For partitioned tables it could perform a list per partition path but I think non-partitioned tables would still require a full list on the root.
For non-partitioned tables would it be possible to perform a list without including the files in _delta_log?

@Blajda the prefix filter can only be applied with the table root unfortunately, so it will always include the _detal_log folder unfortunately. The main benefit it provides is we can restrict the listing to the table we are running the operation on, not all other tables stored in the same bucket.

@roeap @wjones127 want to take a final look?

@wjones127 I updated the PR to fail when an absolute path exists in the Delta log. Also added an additional test to demonstrate the operation will only work on the latest table version.


beginning message framework IN MEM

My intention is to pull this stuff out of Main.go into a subfile and import the functions into the Main.go file, but I couldn't figure out how to do it yet


mongolian vowel separator

There was a backwards-incompatible change in ES7 corresponding to whitespace, as the Unicode version pin was removed:
https://www.ecma-international.org/ecma-262/6.0/#sec-white-space

ECMAScript implementations must recognize as WhiteSpace code points listed in the “Separator, space” (Zs) category by Unicode 5.1.

https://www.ecma-international.org/ecma-262/7.0/#sec-white-space

ECMAScript implementations must recognize as WhiteSpace code points listed in the “Separator, space” (Zs) category.

The MONGOLIAN VOWEL SEPARATOR U+180E used to be in Zs but was moved to Cf in Unicode 6.3.0.  ES7 mandates Unicode 8.0.0 or higher.  As a result, whitespace-sensitive methods will behave differently.
For example, consider "\u180e".trim().length.  An ES6-compatible browser like Safari 11 will remove the character, yielding a length of 0.  However, an ES7-compatible engine should not remove the character, yielding a length of 1.
String#trim and other methods that lean on whitespace are affected.

https://github.com/tc39/ecma262/pull/1698 corrects this omission in the spec's Annex E.


benchmarks: recording layer size distribution in remote runs

With #7780 we added a new remote benchmark. For the remote benchmarks, we don't really know the tenant and timeline easily from the test. We could learn them in the first connection.
If we would have them, we could record the size distribution of layers which would pretty much always be valid. This would however require that the tests would create a new branch for the execution. In the case of #7780 it is easy to see how this would start the test from a clean imported dataset slate, unsure if other tests would benefit.
Size distribution:

at the end of test, it would be great to do a pageserver checkpoint, but that is not a method we compile in staging binaries

alternatively we could just sleep for 10 minutes after index building
this is however completely optional, but something we should keep in mind

accessing the layer map info would reveal timelines layers and their sizes

record min, avg, max, and count for the historic_layers

Cc: https://github.com/neondatabase/cloud/issues/13759

Wild idea:

expose layermap (name, size) via neon_test query to do the min/avg/max?

Requires the neon_test extension, which we might not compile for staging even.

After filing this, I found a better way to reproduce the problem and created a regress test, so perhaps this is not needed.
I am not closing this as every now and then we have a need of getting some metrics for these remote tests. But I no longer have one acute.


Add vflip, hflip, motion and upload keys to config schema

Add vflip, hflip, motion and upload keys

Thanks 🙏


ENH: Support Vision-1

Vision-1 sensor potentially used in CEMS.
It would be great to support it.

Done in 09a16d3e9be9f2bbde460b9c588f73c2a4de7476


Update sbt, scripted-plugin to 1.3.10

Updates

org.scala-sbt:sbt
org.scala-sbt:scripted-plugin

from 1.3.8 to 1.3.10.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt" } ]

labels: library-update, semver-patch

superseded by https://github.com/mefellows/sbt-dotenv/pull/64


Do we have any way to hidden API-Key with Amplitude SDK?

Summary
The Client User can get pure text API-Key from Browser, Do you have any solution to hidden it from curious Users?

Sorry, there's no way to hide the key. To make it invisible to users, you can consider switch to backend tracking.


Make NXP SOC clock init functions weak

Make NXP SOC clock init functions weak for all platforms, see #64342
This would allow board/app redefinition of clock init rather than changing in soc folder

Even better: move SoC clock configuration to the devicetree.

Even better: move SoC clock configuration to the devicetree.

WIP actually but this is shorter term


Pixel leaks when drawing two circles on top of each other with MSAA on

Issue description
Similar to this closed issue, pixel leaks occur when two circles are drawn on top of each other with DrawCircleV and MSAA on:

MSAA off

Reproduced by @Peter0x44  on AMD:

Environment
Win 11, Nvidia
INFO: GLAD: OpenGL extensions loaded successfully
INFO: GL: Supported extensions count: 390
INFO: GL: OpenGL device information:
INFO:     > Vendor:   NVIDIA Corporation
INFO:     > Renderer: NVIDIA GeForce GTX 1080 Ti/PCIe/SSE2
INFO:     > Version:  3.3.0 NVIDIA 512.15
INFO:     > GLSL:     3.30 NVIDIA via Cg compiler
INFO: GL: DXT compressed textures supported
INFO: GL: ETC2/EAC compressed textures supported

Code Example
#include "raylib.h"

int main(void)
{
    SetConfigFlags(FLAG_MSAA_4X_HINT);
    InitWindow(200, 200, "circle with holes");
    SetTargetFPS(60);

    while (!WindowShouldClose())
    {
        BeginDrawing();
            ClearBackground(RAYWHITE);
            DrawCircle(100, 100, 5.0f, GRAY);
            DrawCircle(100, 100, 5.0f, RED);
        EndDrawing();
    }

    CloseWindow();

    return 0;
}

@shiMusa I'm afraid this issue is out-of-scope of raylib. I think it could be related to the way triangles are processed and how MSAA softens the junctions between triangles but trying to solve this issue will probably require a big redesign of the library.
If anyone else finds this issue, feel free to investigate the cause and the possible solution.

It seams issue only happens when DrawCircle() uses RL_QUADS and not RL_TRIANGLES. It worth investigating it!

Reviewed the issue. DrawCircle() calls DrawCircleSector() that uses RL_QUADS as expected, drawing two segments per quad. I concluded the time and efford to review this issue is greater than the benefit it provides so I'm closing it.

OK, I agree
I think users who have this need can just use the RL_TRIANGLES implementation.

I also have this problem when drawing small circles with AA enabled, but I traced it back to the implementation of DrawCircleV:
rshapes.c
// Draw a color-filled circle (Vector version)
// NOTE: On OpenGL 3.3 and ES2 we use QUADS to avoid drawing order issues
void DrawCircleV(Vector2 center, float radius, Color color)
{
    DrawCircleSector(center, radius, 0, 360, 36, color);
}

The circle segments are always set to 36 which is not an appropriate value for smaller circles. I rebuilt the library with a zero in that place and this way the current implementation of DrawCircleSector automatically calculates a proper segment count for the given radius. This also fixes the issue, that very large circles (e.g. 1000 pixel radius) drawn with DrawCircle aren't very smooth, because the segment count is always 36.
My code:
#include <raylib.h>

int main(int argc, char** argv) {
    SetConfigFlags(FLAG_MSAA_4X_HINT);
    InitWindow(800, 600, "Yello :D");
    SetTargetFPS(60);

    while(!WindowShouldClose()) {
        BeginDrawing();
        ClearBackground(RAYWHITE);

        DrawCircle(300, 300, 10.0, BLUE); // Small circle
        // DrawCircle(1100, 300, 1000.0, BLUE); // Large circle

        EndDrawing();
    }
    CloseWindow();
    return 0;
}

Before changes:

My proposal would be to change the DrawCircleV function to the following:
rshapes.c
// Draw a color-filled circle (Vector version)
// NOTE: On OpenGL 3.3 and ES2 we use QUADS to avoid drawing order issues
void DrawCircleV(Vector2 center, float radius, Color color)
{
    DrawCircleSector(center, radius, 0, 360, 0, color); // Zero indicates that DrawCircleSector calculates an appropriate value for the segment count
}

After changes:

One note: Something that I'm not happy with would be that the small circle is now rather jagged, but that can be fixed by defining SMOOTH_CIRCLE_ERROR_RATE to something like 0.25 when building the library.
Final result:


Problem with autosave=true and this package.

There appears to be a problem with autosave=true and this package. Does this only work for autosave=false in autoform?

please give me solution :)

@comerc this package is really slick and worked when I used autosave=false and had a submit button for my autoForm. I only have 2 fields that are using typeahead feature in my application so I ended up switching out this package for https://atmospherejs.com/sergeyt/typeahead which solved my problem.


Make actor type definition useful

By adding type annotation to customSteps, we get hint, that this is actually CodeceptJS.I and therefore we can do much more, while having some type checks.

Thanks! That should be useful


feat: Handle cases when the remote schema is not publicly accessible

Codecov Report

Merging #397 into master will decrease coverage by 0.11%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage     100%   99.88%   -0.12%
==========================================
  Files          25       25
  Lines        1797     1793       -4
  Branches      284      286       +2
==========================================
- Hits         1797     1791       -6
- Misses          0        1       +1
- Partials        0        1       +1

Flag
Coverage Δ

#unittests
99.88% <71.42%> (-0.12%)
:arrow_down:

Impacted Files
Coverage Δ

src/schemathesis/cli/__init__.py
98.34% <71.42%> (-1.66%)
:arrow_down:

src/schemathesis/extra/pytest_plugin.py
100% <0%> (ø)
:arrow_up:

src/schemathesis/models.py
100% <0%> (ø)
:arrow_up:

src/schemathesis/runner/events.py
100% <0%> (ø)
:arrow_up:

src/schemathesis/lazy.py
100% <0%> (ø)
:arrow_up:

src/schemathesis/runner/__init__.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8804716...c715999. Read the comment docs.


validating appears to use ux.surfshark.com

I am unable to get the script to work with api.surfshark.com for wg_check_pubkey() after checking the windows logs (excerpt below) it appears that ux.surfshark.com is the correct server for the validation check.
2022-03-08 05:46:21.1852|INFO|Surfshark.Infrastructure.DnsResolving.DnsResolver|'api.surfshark.com' resolved to '<IP_ADDRESS>'|
2022-03-08 05:46:23.1463|INFO|Surfshark.Infrastructure.DnsResolving.DnsResolver|'ux.surfshark.com' resolved to '<IP_ADDRESS>'|
2022-03-08 05:46:24.3972|INFO|Surfshark.API.Http.Handlers.LoggingHandler|API call POST https://<IP_ADDRESS>/v1/account/users/public-keys/validate status 'OK', reason 'OK'|'
2022-03-08 05:46:24.4393|INFO|Surfshark.API.Http.Handlers.LoggingHandler|API call GET https://<IP_ADDRESS>/v1/server/user status 'OK', reason 'OK'|
Making this change allowed the script to complete and everything now functions as expected.

For me using ux rather than api for tge validation I get 404 vs 401.
I still have to run with the -g -f option and follow that with the -g option several times.
I still haven't determined if it is a timing issue or dufferent times to run the script.
I do run the full script every six days to recreated new keys and wg0.conf file.

I find it varies, I've found a another of other server name that is used by surfshark for validation etc. uymgg1.com, I've also discovered /v1/auth/renew as the probable means of renewing expired tokens, but haven't yet done anything with it.
I've forked the script (and having had some spare time with insomnia) have done some updates that includes rotating through api & ux for both surfshark & uymgg1.com. I've also set it to update openwrt settings using uci, please give it a go..

Another possible to be used for validation surf-chiny.com.
For me surfshark.com website is blocked but uymgg1.com and surf-chiny.com are both  ok.
Playing with your fork looks cool.

:

I find it varies, I've found a another of other server name that is used by surfshark for validation etc. uymgg1.com, I've also discovered /v1/auth/renew as the probable means of renewing expired tokens, but haven't yet done anything with it. I've forked the script (and having had some spare time with insomnia) have done some updates that includes rotating through api & ux for both surfshark & uymgg1.com. I've also set it to update openwrt settings using uci, please give it a go..

Been following your development of the bash script and pretty cool things you have done.
I modified it for my own use (last one i used is the one done 6 hours ago i beleive  beta5) as all I really need is the generation of keys and confs since I'm running wireguard in a docker and don't really need the down and up portion or the interactive part of the script. (I take care of stopping and starting wireguard container myself since I have to also restart all other containers that are using wireguard)
The way I run the original script is in full mode every 6 days (no parameters) to generate new keys and confs.
Then I run daily with the -f -g option followed by the -g option .
I guess your -n option can be run instead?
Keep up the good work.

@kyndair found an error in bash script gen_client_confs() in srv_conf line ur using the wrong pubkey

gen_wg_config.bash.txt
@kyndair my fixes attached couldn't figure out how to do it through git :)

@kyndair My fixes attached couldn't figute out how to do it through git :)
gen_wg_config.bash.txt

@kyndair found another error in bash script
In wg_reg_pubkey() when writing out token_expires.json ur using ${key_ren} when it should be ${key_reg}

@yarafie  @kyndair Thanks for your interest. If you can submit PR from your updated/improved scripts that would be great

@yarafie @kyndair Thanks for your interest. If you can submit PR from your updated/improved scripts that would be great

@yazdan I will let @kyndair do that as its his script.

@yarafie @kyndair Thanks for your interest. If you can submit PR from your updated/improved scripts that would be great

Ok. @yazdan. I cleaned up @kyndair bash script fixed a few things and removed extra bits from original bash script by @kyndair . Check README.bash. I've tested this myself snd its working for the most part


Support for secrets in docker-swarm backend

Docker Swarm supports a secret store which is currently not supported by ShinyProxy. It's a best practice way to store sensitive information in a central place and make these available to containers/services as required.
It would be great to be able to define Docker secrets in the configuration.yml of ShinyProxy which will then be added to launched app services via the --secret argument.
For example:
proxy:
  specs:
    - id: example_app
      ...
      container-secrets:
       - my_secret

@fmichielssen What shall we do order to pass through the application.yml file Docker Swarm Secrets to the Docker Containers?
I have been trying to pass Docker Secrets from ShinyProxy Docker Container, to Application Containers, without success:
container-env:
  VAR1: "${cat run/secrets/my-secret}"

Shall I pass the secret on the DockerFile itselft?
CMD java -jar \
    -Dproxy.specs.my-container.container-env.my-var="$(cat /run/secrets/my-password)" \
    /opt/shinyproxy/shinyproxy.jar

Which would be the right syntax?
Thanks

Any suggested syntax here? I am also interested.


Add support for SLES 15 configure service

Signed-off-by: Jaymala Sinha<EMAIL_ADDRESS>

@jaymalasinha can you fix the cookstyle errors? https://travis-ci.org/chef/automate-liveness-agent/jobs/449946124


autologin failed

Autologin doesn't work for me, and my server is like:
centos7.5,
I installed wetty following the README.
sshpass installed
When I typed the url:
http://172.18.10.xx:3000/wetty/ssh/app?sshpass=123456
I found that the web terminal turned to an invalid user: app?sshpass=123456,

The autologin is broken on master. Will have to fix it. I will try and make a PR soon.

you can use my fork koushikmln/wetty in case you need it on priority.

Please help to fix this bug asap . Thank you !


Address Tuya EnchantedDevice inheritance for remotes

EnchantedDevice already inherits from CustomDevice.
Follow-up to:

https://github.com/zigpy/zha-device-handlers/pull/2299

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 84.489%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
7163

Relevant Lines:
8478

💛  - Coveralls

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (be0fc65) 84.49% compared to head (3d37415) 84.48%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2316      +/-   ##
==========================================
- Coverage   84.49%   84.48%   -0.01%
==========================================
  Files         265      265
  Lines        8479     8478       -1
==========================================
- Hits         7164     7163       -1
  Misses       1315     1315

Impacted Files
Coverage Δ

zhaquirks/tuya/ts004f.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Allow fci.transform_ci to change number of electrons

As far as I can tell, pyscf.fci.addons.transform_ci accepts non-square orbital rotation matrices, u,
but it assumes that the number of electrons remains the same in the old and new basis.
How difficult would it be to implement a change of the electron number?
I'm mainly interested in projecting down a FCI WF onto a subspace,
but I guess the case of padding in (uncorrelated) electrons could also be of interest.

transform_ci function is based on the overlap between two determinants. The requirement for det-overlap is that the number of electrons in bra and ket are identical. It is not clear to me how to define the determinant overlap between wavefunction of different number of electrons. I guess you'll need to freeze certain orbitals and treat the wavefunction as a CASCI wavefunction. Then the projection can be carried out in the active space


Added support for dark mode in twitter timeline widget in Footer Element closes #1242

Description
This PR fixes #1242
Notes for Reviewers
I have added dark mode functionality for twitter timeline widget for dark mode.
Implementation details:
first, i had tried using changing the data-theme attribute of the  tag of twitter widget, it was working but it required reloading the page to see the changes, so it was not feasible at all.
Now, what I have done is for dark mode and light mode, whenever toggle happens, it creates a new widget and then appends to the page, so no refresh is required.
Signed commits

[x] Yes, I signed my commits.

Screenshots:

dark mode

light mode

@thisiskaransgit @vishalvivekm Even tho meshery has some tweets on it's profile it's displaying "Nothing to see here - yet" 🤔
Also @ranjanmangla1 there's a slight delay while switching to light/dark modes

@thisiskaransgit @vishalvivekm Even tho meshery has some tweets on it's profile it's displaying "Nothing to see here - yet" thinking
nothing to see here yet is happening on meshery.io too, @Savio629

Also @ranjanmangla1 there's a slight delay while switching to light/dark modes
yeah, I know, that is because whenever a toggle happens, a new widget is created and then it is appended to the page. This is the only solution that is working, other wise, the page has to be reloaded to see the changes. I have added implementation details in the pr description.
Out of the 3 possible solutions, I figured out, this is the only solution that is working well

hey @Savio629, so what changes I have to make in this pr to be merged?

@ranjanmangla1  Let's discuss this on Websites Meeting call on Monday. Please add this as an agenda item in the meeting mintes if you would. :)

@samyakshah3008 , hey Samyak, can you review this pr, in past two website meetings this has been an agenda but could not be discussed on both occassions due to lack of time?

Sure man, let me look into it today.

@thisiskaransgit, I'm removing prhold label, as twittter issue is resolved now

@ranjanmangla1 Merge conflicts to resolve...

Thanks for the PR, but since the widget is not working, due to twitter's new open-access policy, we'll be closing this issue. Thank you for your efforts though.


Add direct binary search (DBS)

As described in [1] and Chapter 7 of Modern Digital Halftoning by Lau & Are.

[1] Analoui, M.; Allebach, J.P. (February 1992). "Model-based Halftoning by Direct Binary Search". Proceedings of the 1992 SPIE/IS&T Symposium on Electronic Imaging Science and Technology. 1666: 9–14.

what's the issue sir

Hi @Jay-sanjay,
together with issues #24 and #26, this issue tracks a dithering algorithm that would be nice to have in DitherPunk.jl.
For a list of already implemented methods, refer to the list in the README and the gallery.
If you are looking to contribute the direct binary search algorithm to DitherPunk.jl, you only need to create an algorithm struct that is a subtype of AbstractDither, a function binarydither! and optionally a function colordither. The source code of ClosestColor is probably the best entry point into the code.
I would be more than glad to assist you if you are interested in contributing! :)

@adrhill  Sir, while implementing  the  binarydither! ( )  function should it return 1 if pixel value in the input image is greater than the threshold and 0 in the else case . What must be done could you please assist me further !

Hi @Jay-sanjay, functions binarydither! are supposed to modify the argument output in-place.
In-place modifying functions in Julia are usually indicated by an exclamation point ! in their name by convention.
Writing a 1 into out will turn that pixel white.
Writing a 0 into out will turn that pixel black.
I hope the following screenshot helps illustrate this:

Yes , Sir should the algorithm be something like :
binarydither! function should iterate over each pixel in the input image and assign the output pixel to the closest color in the color palette and the distances between the two colors measured via theirdiif. in grayscale values if
it is greater than thresold , return 1
else return 0.


[Steam Version] This mod disable the Steam's keybinds

Describe the bug
When using this mod on the steam version keybinds such as F12 (take a screenshot) and Shift+TAB (open the Steam overlay) are not working anymore.
Browser
Steam Version (Electron)

I currently don't have the Steam version myself so I can't really investigate this. Do you have this issue with other games/mods?

Steam keybinds seem to be working for me

The recent commit did not do anything specifically with keybinds. Can other uses report whether they are experiencing issues?

I had the same issue but it also became fixed for me within the last ~18 hours.

If somebody else also reports that this is now fine I am going to close this!

Works fine now

Closing this then! Thanks for all the reports!


Updated to support Ember 1.13 and Ember 2.x

Removes:

Support for Ember.Select, because Ember.Select has been removed from Ember.

Amazing! Thanks a lot @ivanvanderbyl. This looks awesome.


Decouple Page and App.Model, promote Home to a proper page

Attempt to address #209.

Yes that looks much better

Let me know if you'd like to merge it as is and I'll update the tomato example.

yes please fix readme and I'll merge. Thank you!

thanks!


Plugin locale

Is it possible to make  Payment Sheet  multilingual? For now I cannot change  Payment Sheet  or  Payment Flow language if user switch app`s language.
Thanks

The Language of the Payment Sheet follows the settings of the application. This is not a plugin issue and will be closed.

@rdlabo OK, so can you please guide me what should I search? On android the sheet is in a correct language but on iOS is still in English....

Maybe, only localization settings issue. Please check this:

@Perfect, that's it. Is there a possibility to change this localization when user change his language in the app?

User can change device language settings.


[WIP] domd: Append sndbe and camerabe to IMAGE_INSTALL

Not sure that this is the correct approach. We don't need sndbe or any other back-end if there are no guests that require that back-end.
So it is more

Sorry. That was huge missclick :)
I wanted to cancel my comment, but instead clicked on "close with comment"

So, you think it's better to add something like sound in DISTRO_FEATURES? Just like we already have pvcamera and vis?

So, you think it's better to add something like sound in DISTRO_FEATURES?

Well, if you wish, you can reuse an existing DISTRO_FEATURE (alsa or pulseaudio maybe?). But I'd prefer to not add new ones.
Besides, whole idea of our "product" is to have some known set of features that we are supporting. So I'm thinking it is better to limit "configurability" of  the product. I.e. are there any changes that we might want prod-devel without sound enabled?

Successfully tested with https://github.com/xen-troops/meta-xt-common/pull/28 on h3ulcb-4x2g-kf.

RB is added.
Successfully tested.
Ready to be merged.


have different Config implementations for different channels

@amircodota I have no idea what this suppose to do

@boaz-codota Ths idea is to have a Config class with constants for each of the supported channels - alpha, beta, production, and include the right Config.java based on the given channel.
This way, we can have a different configuration based on the channel we are compiling for, so for example, we can know which channel we are on, what url to download the binary from etc.

@boaz-codota Ths idea is to have a Config class with constants for each of the supported channels - alpha, beta, production, and include the right Config.java based on the given channel.
This way, we can have a different configuration based on the channel we are compiling for, so for example, we can know which channel we are on, what url to download the binary from etc.

Is it a prep for the future? (If so, please note that "premature optimisation is the root of all evil")

@boaz-codota hehe... no, I use it to pass the clientChannel metadata field to the binary


Can I get the the class of point cloud through lidar-synthesis?

Hi @rockywind,
Could you clarify what you mean by "class of point cloud"?

Hi, @jonathsch
Sorry for that. I mean can I get the point cloud's label, such as, vehicle, road and etc.

Thanks for the clarification,
No. Currently, the framework does not generate semantic labels for the point cloud.

Hi,
if I want to generate the semantic labels for the point cloud, there are any suggest?


first naive implementation of virtual table

see test/test_vtable.rb for example
only select is supported (update/insert is not yet implemented)

Hello,
@luislavena Is there anything you'd like me to fix/change/review so that this pull request can be integrated ? May be some documentation ?
Regards,
Lionel

is there a chance to merge vtable feature into sqlite3 gem?


patched some TH errors

I encountered these errors while trying to compile with GHC version 8.10, and patched them like this. Now the package builds as expected.
I have not used the preprocessor before so I am unsure of how to make sure that users with older versions of GHC can still run the code. Does anyone have any suggestions?

Thank you for the report! I've fixed it in a way that also works for older GHCs.
The new version is on Hackage.

Thank you for the report! I've fixed it in a way that also works for older GHCs.
The new version is on Hackage.


[WIP] ENH: Nonlinear warp-based susceptibility distortion correct

Closes #496

For the distortion atlas, the authors provide an unspecified template (I'll call the distortion template), I would guess a symmetric MNI template. My current strategy for getting a distortion atlas in the EPI ref space is:

Find an affine transformation from the distortion template to the template in use by FMRIPREP
Apply (distortion template -> template) + inv(T1 -> template) + inv(EPI ref -> T1) to distortion atlas

If we don't think an affine transformation is sufficient to go between templates, then I think it would make more sense to calculate a transform from the T1 to the distortion template and invert that, since we're going to go through the trouble of a nonlinear transform anyway.
Alternately, we can pre-calculate a (distortion template -> template) warp for each template we support.
WDYT?

I think affine is perfectly fine for this purpuse. BTW the template they
used (defining the space) is this one http://neurovault.org/images/43982/
AFAIK.
On Fri, Jun 2, 2017 at 9:31 AM, Chris Markiewicz<EMAIL_ADDRESS>wrote:

For the distortion atlas http://neurovault.org/collections/2426/, the
authors provide an unspecified template (I'll call the distortion
template), I would guess a symmetric MNI template. My current strategy
for getting a distortion atlas in the EPI ref space is:

Find an affine transformation from the distortion template to the
template in use by FMRIPREP
Apply (distortion template -> template) + inv(T1 -> template) +
inv(EPI ref -> T1) to distortion atlas

If we don't think an affine transformation is sufficient to go between
templates, then I think it would make more sense to calculate a transform
from the T1 to the distortion template and invert that, since we're going
to go through the trouble of a nonlinear transform anyway.
Alternately, we can pre-calculate a (distortion template -> template) warp
for each template we support.
WDYT?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/poldracklab/fmriprep/pull/544#issuecomment-305839354,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOkp94S41UsyuutCWIB780fWuc5ePxEks5sADjEgaJpZM4NuVYr
.

Right, they used that template, but it's not clear if it's a standard template or if they created it from their collection of subjects. Not sure that it makes a difference for our purposes; just noting the situation.

How do I get the phase-encoding direction from the JSON file associated with a BOLD image? Just make sure I have the original filename and replace nii.gz with json? Or does pybids have some relevant magic?
Another thing to consider: This atlas is only valid for anterior/posterior phase-encoding. In the event of an i/i- or k/k- image, we probably wouldn't want to use the atlas...

There are two things to consider:

AFAIK distortions happen in the same place in the brain independently of the phase encoding direction. It only changes which way the tissue will be pulled/pushed. Thus I think we can use this atlas for both i/i- and j/j-
most datasets without fieldmaps do not have any phase encoding information. In such cases it is worth assuming that the distortions happen in either i or j (because we already assume k is slice direction). There are two things we could do: 1) restrict ants to two direction - i and j (instead of one) 2) run ants twice once with i and once with j and see which gives better fit with bbregister

I've searched a bit, and can't find any articles that discuss the effect of PE direction on where artifacts occur. Presumably there's some effect, even though the "epicenters" might be consistent. ANTs' smooth deformation constraints may save us here. In either event, we can start from that assumption.

I suppose I'd rather go with the second option in cases where we don't know; that way we're not using an effectively different algorithm when we don't know. In this case, we should verify on datasets where we do know PE direction that our heuristic (e.g. bbregister min cost) selects the true one.

Yes, theoretically the fieldmap is the same regardless the encoding direction. I don't think you'll find a scan with k/-k for PE since that's the B0 direction.
As regards the case of unknown PEs, as @effigies I'd say better going to option 2 (two registration processes). However, it shouldn't be that hard to look at the disagreement map of the T1 mask linearly mapped into EPI space and the EPI mask. Then project to X and Y. The PE axis should a bimodal distribution in the PE axis and monomodal in the FE axis.

Current status: This performs the warping as expected and generates a report (currently SyN-registered reference EPI to the inverted-T1-in-EPI space).
Still in progress:

[ ] PE-direction guessing (switching to MapNode, followed by BBR-based assessment, though making sure this works with FLIRT-BBR will be necessary)
[ ] Atlas-based restriction of SyN warp

I believe this is basically set. The main remaining issue is that --use_syn needs t1_2_mni to generate a transform, so if our --output-space doesn't include template, we'll throw an error. The hangup here is that, if we move to --use-syn by default: If I have fieldmaps and don't want MNI outputs, then I don't want to waste time with that conversion; if I don't have fieldmaps, I still want SyN to work, so we'll have to run that.
I'll need to think about the best way to manage this, but for now I think we should just warn if 'template' is not in output_spaces and use_syn is on. That will minimize the logic that needs reworking when we settle on an approach.

Looks like this is going to require upgrading to ANTs 2.2.0. Sorry for the delay. I'll work on upgrading existing ANTs nodes, and then return to this.

This is just about ready. I'm going to work on some documentation today and plan to release 0.5.0 by tonight.

+1
On Wed, Jun 21, 2017 at 3:57 AM, Chris Markiewicz<EMAIL_ADDRESS>wrote:

This is just about ready. I'm going to work on some documentation today
and plan to release 0.5.0 by tonight.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/poldracklab/fmriprep/pull/544#issuecomment-310043298,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOkp_VtjxzKRtf39pG-KTTdzc3prE80ks5sGPcTgaJpZM4NuVYr
.

Added to the SDC docs, in the fieldmap estimation section.
It may make sense to move this workflow out of workflows.epi into workflows.fieldmaps, and manage its selection in a similar way to fmap and phdiff, but I don't want to hold this up further right now. That refactorization can come along with stabilizing, after we've had a chance to test the functionality more broadly.


Publish AWS Scripts

@dcbroad3, We are missing the file 'PIDA_Scripts.zip' under scripts/PIDA/

@dcbroad3, We are missing the file 'PIDA_Scripts.zip' under scripts/PIDA/

I see the issue now. In the global .gitignore there is a rule for *.zip. We'll need to add a flag for our AWS subfolder.

Modify .gitignore so we are not excluding 'PIDA_Scripts.zip' under scripts/PIDA

@cholzmer This should be fixed now, let me know if you still see anything missing.

@dcbroad3, yep the files look good now. Thanks.

we should update the outside readme with the links to these

we should update the outside readme with the links to these
@derekendres , Sounds good.

@dcbroad3, I will update the readme within Azure DevOps and then give you a copy of the new readme to update GitHub.

the details link in the scripts readme for azure takes you to AWS

the details link in the scripts readme for azure takes you to AWS

Fixed this.


@ionic-native/file": "^5.1.0 compatibility

Hi,
please this plugin is fantastic for image loading. But due the other requirements I need to update to @ionic-native/file": "^5.1.0 and this plugin require<EMAIL_ADDRESS>version.
Please do you plan to upgrade, or anyone else do you please know how to fix it?
Thanks a lot.
Peter

I found v4 branch, but it is not compatible with ionic 5.1.0.

@peterpullmann how is it not compatible?
If it's just throwing a warning when doing npm i that you have unmet peer dependencies, you can ignore it and keep using latest version of @ionic-native/file.
Otherwise, please provide more details about any errors or issues you're experiencing.

Same issue. Have dependencies that do not allow me to have lower than ionic-native: 5.0.0.
Its an amazing plugin, are there any plans to update it?
Besides the warning it also doesn't work.
Gives an error.
Uncaught Error: Can't resolve all parameters for ImageLoader: ([object Object], ?, [object Object], [object Object]
thats with ionic-native: 5.6.0


Demo person credential atttribute issues

When getting a demo person credential from the prod showcase, two attributes have issues:

The image doesn't show up
The date of birth is very far into the future

See attached:

Resolved by: https://github.com/hyperledger/aries-mobile-agent-react-native/pull/839


:seedling: support set imagepullsecret credential in helm chart and run e2e using helm chart

Summary

support set imagepullsecret credential in the helm chart.
set the token-secret length to 16 in the chart.
use helm chart to deploy in e2e.
add a flag to control if create operator CR, because do not need create klusterlet CR in e2e deploy stage.  the default is to create.
move the chart config struct to the helper dir. the consumer will only import the helper dir.

Related issue(s)
Fixes #

/assign @qiujian16


Additional testing of status concept of the board and additional documentation for the already existing test cases for the board.

Codecov Report

Merging #21 (143869e) into development (d493651) will increase coverage by 0.32%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development      #21      +/-   ##
===============================================
+ Coverage        49.51%   49.83%   +0.32%
===============================================
  Files               76       76
  Lines             2791     2791
===============================================
+ Hits              1382     1391       +9
+ Misses            1409     1400       -9

Impacted Files
Coverage Δ

src/SMCE/Board.cpp
95.34% <0.00%> (+6.97%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d493651...143869e. Read the comment docs.


Add ContactPointRef and ContactPointSelector fields to rulegroups.alerting.grafana.crossplane.io

Description of your changes
This PR adds reference and selector support to the alerting.grafana.crossplane.io RuleGroup resource.
With that, one can use a contact point selector like follows:
apiVersion: alerting.grafana.crossplane.io/v1alpha1
kind: RuleGroup
metadata:
  name: "example"
spec:
  forProvider:
    name: "example"
    ...
    rule:
      - notificationSettings:
        - contactPointSelector:
            matchLabels:
              label: value

I have:

[X] Read and followed Crossplane's [contribution process].
[X] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Tested locally with kind cluster and k8s objects against grafana cloud API.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report
Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@803d418). Learn more about missing BASE report.

Files
Patch %
Lines

apis/alerting/v1alpha1/zz_generated.resolvers.go
0.00%
32 Missing :warning:

apis/alerting/v1alpha1/zz_generated.deepcopy.go
0.00%
16 Missing :warning:

Additional details and impacted files
@@          Coverage Diff           @@
##             main    #166   +/-   ##
======================================
  Coverage        ?   0.00%
======================================
  Files           ?     201
  Lines           ?   29579
  Branches        ?       0
======================================
  Hits            ?       0
  Misses          ?   29579
  Partials        ?       0

Flag
Coverage Δ

unittests
0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Stop using the deprecated DefaultFinder on Config

You deprecated this class but you are still using it.
This produce not wanted and not solvable deprecation errors like this: https://travis-ci.org/Soullivaneuh/php-cs-fixer-styleci-bridge/jobs/153204311#L392
Related failing PR from my bridge: https://github.com/Soullivaneuh/php-cs-fixer-styleci-bridge/pull/74

Fixed CS.

The reason why we have introduced new class instead of modifying exisitng one is that the changes we have made are BC breakers.
For compatibility reasons we still use original finder, but we also deprecated it and encourage to use new one. If you are ready to use new one, that will works in different way - specify it in you config file.

Closing as stated.

@keradus I can understand, but how shall I fix the failing test so? https://travis-ci.org/Soullivaneuh/php-cs-fixer-styleci-bridge/builds/153204307
Thanks.

Configure Finder in .php_cs file.
You could use our new one (Finder instead of DefaultFinder) or one of your own.
Be aware that they will behave differently (that's why we didn't switch to not break BC)

Also, you could not treat deprecation notices as errors

I'm not talking about .php_cs but the bridge which create a config.
For your 1.12 version, I use \Symfony\CS\Config::create(); as recommended. But this method use your deprecated DefaultFinder which trigger a deprecation error.
This is why I provided this PR. The error is triggered even if we make sure to use the right class.
Concerned line: https://github.com/Soullivaneuh/php-cs-fixer-styleci-bridge/pull/74/files#diff-b77b80825f9a37eb99f8064048f80d9fR113

Also, you could not treat deprecation notices as errors

This is not an acceptable solution because I won't be warned of deprecation at all, even for my usage.

See also the related test: https://github.com/Soullivaneuh/php-cs-fixer-styleci-bridge/blob/2406ac6ab7a243e1b4d4f5f73c12e5905c629877/tests/ConfigBridgeTest.php#L14
I can't mark it as legacy because it is not, and I can't fix the deprecation because it's triggered from your code. :-)

I also tried that:
$config = \Symfony\CS\Config::create()->finder(new \Symfony\CS\Finder());

This change nothing, still have the error.
And this is logic, because the trigger_error is placed on the constructor, which is called on the config constructor.

Indeed, always creating a default finder in the configuration class is not needed (as it might be set to something else using the setter before using the finder).
Only creating the finder (of type DefaultFinder for BC reasons) in the getFinder-method if the finder is null is not possible, since it would be a BC break (as the finder is a protected attr. of the class and it would change that is always set as it is now).
Changing the finder to the new finder class would be a BC break as well (as prop. in this PR).
So for now there is not much we can do, I would ignore the warning. On the master branch I hope we ditch the protected fields and only create the finder when needed (and not always as it is now)

ref https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2244/commits/3f67e32fdcdf4d2c2f4bfeef438253a5fda9df15

@keradus Good thing, but only for 2.0.
I'll mark tests as legacy waiting dropping 1.x support form my library.


Added tweet for MATIC

#6
Keshav Agrawal
PES2UG21CS229
Added separate tweet for polygon matic

Ok this is perfectly working, api-id 'magic-network' wasn't working before, but now it seems to work

!bounty 25


[android] support "make" based ports

Adds support for android builds using make.
Based on previous pull requests

https://github.com/microsoft/vcpkg/pull/21222 (by @holmescn) for the bare minimum to get things working

https://github.com/microsoft/vcpkg/pull/15605 (by @xandox) for the logic to extract variables from using get_cmake_vars

What does your PR fix?
Fixes building make based ports using android ndk

Which triplets are supported/not supported? Have you updated the CI baseline?
android, no

Does your PR follow the maintainer guide?

yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

no ports affected

I have cloned the branch fix-android-ndk-clang of opengisch/vcpkg and run vcpkg install libiconv:x86-android for test. the result is sa
config-x86-android-dbg-out.log
config-x86-android-dbg-err.log
d:
$ ./vcpkg install libiconv:x86-android
Computing installation plan...
The following packages will be built and installed:
    libiconv[core]:x86-android -> 1.16#11
Detecting compiler hash for triplet x86-android...
A suitable version of ninja was not found (required v1.10.2). Downloading portable ninja v1.10.2...
Downloading ninja...
  https://github.com/ninja-build/ninja/releases/download/v1.10.2/ninja-linux.zip -> /mnt/wsl/vcpkg/downloads/ninja-linux-1.10.2.zip
Extracting ninja...
Restored 0 packages from /home/holmescn/.cache/vcpkg/archives in 3.5 us. Use --debug to see more details.
Starting package 1/1: libiconv:x86-android
Building package libiconv[core]:x86-android...
-- Using community triplet x86-android. This triplet configuration is not guaranteed to succeed.
-- [COMMUNITY] Loading triplet configuration from: /mnt/wsl/vcpkg/triplets/community/x86-android.cmake
-- Downloading https://ftp.gnu.org/gnu/libiconv/libiconv-1.16.tar.gz;https://www.mirrorservice.org/sites/ftp.gnu.org/gnu/libiconv/libiconv-1.16.tar.gz -> libiconv-1.16.tar.gz...
-- Extracting source /mnt/wsl/vcpkg/downloads/libiconv-1.16.tar.gz
-- Applying patch 0002-Config-for-MSVC.patch
-- Applying patch 0003-Add-export.patch
-- Applying patch 0004-ModuleFileName.patch
-- Using source at /mnt/wsl/vcpkg/buildtrees/libiconv/src/1.16-b0c41d3469.clean
-- Getting CMake variables for x86-android-dbg
-- Getting CMake variables for x86-android-rel
-- Configuring x86-android-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
    Command failed: /bin/bash -c "V=1 ./../src/1.16-b0c41d3469.clean/configure --build=x86_64-pc-linux-gnu --host=i686-linux-android \"--enable-extra-encodings\" \"--without-libiconv-prefix\" \"--without-libintl-prefix\" \"--disable-silent-rules\" \"--verbose\" \"--disable-shared\" \"--enable-static\" \"--prefix=/mnt/wsl/vcpkg/installed/x86-android/debug\" \"--bindir=\\${prefix}/../tools/libiconv/debug/bin\" \"--sbindir=\\${prefix}/../tools/libiconv/debug/sbin\" \"--libdir=\\${prefix}/lib\" \"--includedir=\\${prefix}/../include\" \"--datarootdir=\\${prefix}/share/libiconv\""
    Working Directory: /mnt/wsl/vcpkg/buildtrees/libiconv/x86-android-dbg
    Error code: 77
    See logs for more information:
      /mnt/wsl/vcpkg/buildtrees/libiconv/config-x86-android-dbg-out.log
      /mnt/wsl/vcpkg/buildtrees/libiconv/config-x86-android-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_make.cmake:843 (vcpkg_execute_required_process)
  ports/libiconv/portfile.cmake:29 (vcpkg_configure_make)
  scripts/ports.cmake:142 (include)
...

config-x86-android-dbg-out.log shows that the c compiler does not work. And check the config.log we can see that it is caused by the -l-static-libstdc++ is unknown, which is fixed but deleted by this PR. The original detected CMAKE_CXX_STANDARD_LIBRARIES contains " -static-libstdc++ -latomic -lm" where the -static-libstdc++ is not the standard library link option, and will be transformed by the script. Another problem here is that no --target option is specified, which is critical of cross-compile with clang. It will cause that the linked C/C++ standard library contains unexpected instruments or cause the compiling crash.

Please get failure logs here.

Maybe you should check the port detect-compiler's logs?

IIUC -static-libstdc++ is a gcc option which should not be used with clang. If this is what is detected by CMake, then cmake needs more help.
Q: Which android toolchain shall be chainloaded? There is a toolchain file in vcpkg, and there is a toolchain file in the NDK ("upstream"). And there is CMake operation on top of it.
FTR the file from vcpkg does the following:
if (VCPKG_CRT_LINKAGE STREQUAL "dynamic")
    set(ANDROID_STL c++_shared CACHE STRING "")
else()
    set(ANDROID_STL c++_static CACHE STRING "")
endif()

Please get failure logs here.

I think it is impossible. Since the PR here is going to fix a community driven triplet that does not covered by the statandard CI pipeline. I could not find any failure logs about Android platform.

Maybe you should check the port detect-compiler's logs?

OK, I would like to try it.

@dg0yt I found some documentations here:

Warning: CMake has its own built-in NDK support. Before CMake 3.21, this workflow is not supported by Android and is often broken with new NDK releases. Starting from CMake 3.21, the implementations are merged. CMake's built-in support has similar behavior to the NDK toolchain file, though variable names differ. Starting from Android NDK r23, the toolchain file will delegate to CMake's built-in support when using CMake 3.21 or later. See Issue 463 for more information. Note that the Android Gradle Plugin still uses the NDK's toolchain file automatically.

@holmescn this PR only works with NDK <= r21, if possible I'd like to deal with the r23 in a separate PR.

Good to know that NDK and CMake are aligning. We can probaly assume building with CMake >= 3.21. (vcpkg ports will use it so users can use it, too.) But I don't think we can always assume NDK >= r23.

Good to know that NDK and CMake are aligning. We can probaly assume building with CMake >= 3.21. (vcpkg ports will use it so users can use it, too.) But I don't think we can always assume NDK >= r23.

Yes, more tests found more problems with the older NDK version. More patches needed. Sad.

BTW the CMAKE_SYSTEM_VERSION isn't reliable. I have switched to NDK r16 installed by SDK manager and point the ANDROID_NDK_HOME to it. The CMAKE_SYSTEM_VERISON is still 21. And tests on that version shows that the detect_compiler port need help.

IIUC CMAKE_SYSTEM_VERSION is meant to set the "target API level" and does not correspond to the NDK version.

IIUC CMAKE_SYSTEM_VERSION is meant to set the "target API level" and does not correspond to the NDK version.

But old NDK do not have new API level. It causes a crash. Since the API level 21 is invalid in NDK r16

I think it's the users responsibility to make sure he has tools (ndk) that handle his settings (target API). What could be done is a warning/error to help point that out.
What I understood from https://github.com/microsoft/vcpkg/pull/21831#issuecomment-986514354 is that the CMAKE_SYSTEM_VERSION should be modified based on the installed NDK version, I would strongly suggest against that.

I think it's the users responsibility to make sure he has tools (ndk) that handle his settings (target API). What could be done is a warning/error to help point that out and with this help the user fix the mismatch. That would be a nice to have / enhancement. What I understood from #21831 (comment) is that the CMAKE_SYSTEM_VERSION should be modified based on the installed NDK version, I would strongly suggest against that.

That is what I have done in #21847 which give two choices to solve this kind of problem:

one can specify the ANDROID_NATIVE_API_LEVEL in the triplet file
warning message would be shown in the android toolchain file when detect the compiler flags
But there are other problems with the detect_compiler port.


V4: Unable to target name for styled component in tests, the name is always "ForwardRef"

Reproduction
https://codesandbox.io/s/yv7l2p76q9
Steps to reproduce
Write enzyme test for a styled component to ensure the correct components are rendered.
Expected Behavior
You should be able to target styled components by their name or explicitly set displayName
Actual Behavior
All styled components have the name ForwardRef instead of the name you give it, making it difficult to differentiate between them
Ideally, it would be nice if the functionality was the same as it was before, where it automatically took the name of whatever you named the styled component as. Most of the tests in our test suite use enzyme in this way and it would cause a considerable refactor to go through and either set an explicit displayName to each instance, or start using specific classes and apply them to all affected components.
Is there a better way of handling this situation?
Thank you!

We actually do forward the displayName: https://github.com/styled-components/styled-components/blob/develop/src/models/StyledComponent.js#L265
Enzyme must be ignoring it or something

You should be able to target the styled-component like this though right?
const Component = styled.div``

mount(
<Component />
).find(Component)

Unfortunately not :/ Using mount or shallow, I can't call the styled component by name. Shallow just shows the ForwardRef name, and mount does BaseStyledComponent wrapped in the ForwardRef.  I updated the repro link to show what I mean between the two

https://github.com/airbnb/enzyme/issues/1810

@maureenwaggl so I think with react 16.5.1 and newest enzyme, things should be targetable again?

@probablyup Thanks for all your help with this and your fast replies and follow ups! I'll keep an eye out for the latest enzyme release and try upgrading when that's available. Thanks again!

FYI I'm adding this to our test-utils: https://github.com/styled-components/styled-components/pull/2049

It's a little tough to test on codesandbox because it uses CRA, but a non-CRA project with the babel plugin should be able to grab the names in the latest enzyme version I think.

Awesome, thank you! I'll try to upgrade soon and hopefully all will work as expected. Thanks again for all your help and followup with this!

ohi, i was wondering if there a way to hack around enzyme for nested styled-components?
const Icon = styled.i`...`;
const BlueIcon = styled(Icon)`color: blue`;

const Thing = () => <BlueIcon />;

mount(<Thing />).find(Icon); // -> returns empty

the styled component ID hack doesn't seem to work in this case, because classes seem to be reshuffled

Try using the new enzymeFind test util
On Tue, Oct 23, 2018, 9:12 PM Nikolay Nemshilov<EMAIL_ADDRESS>wrote:

ohi, i was wondering if there a way to hack around enzyme for nested
styled-components?
const Icon = styled.i...;const BlueIcon = styled(Icon)color: blue;
const Thing = () => ;
mount().find(Icon); // -> returns empty
the styled component ID hack doesn't seem to work in this case, because
classes seem to be reshuffled
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/1985#issuecomment-432486604,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiy1mvpe_oC6hp2wGnuj3G4zpLW56E8ks5un8x2gaJpZM4WfFKd
.

yup, the problem though is that the original styledComponentId gets lost in this case. hence i'm wondering if there is a clever way to get around that. here's the full test case:
import styled from 'styled-components';
import { mount } from 'enzyme';
import { enzymeFind } from 'styled-components/test-utils'

describe('bug', () => {
  it('aint no nothing works', () => {
    const Icon = styled.i`color: black`;
    const RedIcon = styled(Icon)`color: red`;
    const BlueIcon = styled(Icon)`color: blue`;

    const TestComponent = () => (

        <RedIcon />
        <BlueIcon />

    );

    const wrapper = mount(<TestComponent />);

    console.log(wrapper.find(Icon).length);
    console.log(enzymeFind(wrapper, Icon).length);

    console.log(wrapper.find(BlueIcon).length);
  });
});```

it spits out:

0
0
1

hmm, another interesting consequence of this is that createGlobalStyles doesn't seem to work with base components either now:
const Sidebar = styled.aside`.....`;
const LeftSidebar = styled(Sidebar)`....`;
const RightSidebar = styled(Sidebar)`...`;

const GlobalStyles = createGlobalStyle`
  ${Sidebar} {
      /* doesn't do anything */
  }

  ${LeftSidebar}, ${RightSidebar} {
     /* works */
  }
`;

is that intentional?

Any progress on the Styled Component display Name? Or will enzyme fix this issue?
Always show


Mistake in the IDoc (waterfill command)

On the main page of IDoc waterfill in the command tab is noted as Virtual (and double):
https://explosivegaming.github.io/scenario/addons/Virtual.html

Fixed in #272


Cargo.toml dependencies aren't accurate

Describe the bug

Currently arrow-rs doesn't compile successfully with the full range of dependencies in its Cargo.toml.
This is similar to the issue reported by https://github.com/apache/arrow-rs/issues/3525. That was closed with a suggestion to bump dependencies, but doesn't help for other projects that want to test that their Cargo is accurate — https://github.com/wangfenjin/duckdb-rs/pull/135 & https://github.com/PRQL/prql/pull/2112. The intention behind Cargo.toml is that it specifies the full range of dependencies, IIUC.
To Reproduce

cargo +nightly update -Z minimal-versions
cargo build

error[E0599]: no method named `powi` found for struct `f16` in the current scope
   --> arrow-array/src/arithmetic.rs:351:25
    |
351 |                 Ok(self.powi(exp as i32))
    |                         ^^^^ method not found in `f16`
...
380 | native_type_float_op!(f16, f16::ONE, f16::ZERO);
    | ----------------------------------------------- in this macro invocation
    |
    = help: items from traits can only be used if the trait is in scope
    = note: this error originates in the macro `native_type_float_op` (in Nightly builds, run with -Z macro-backtrace for more info)
help: the following traits are implemented but not in scope; perhaps add a `use` for one of them:
    |
18  | use num::Float;
    |
18  | use num::traits::float::FloatCore;
    |
18  | use num::traits::real::Real;
    |
...

Thank you!

I was getting errors trying to install recent versions of arrow:
error[E0432]: unresolved import `num::complex::ComplexFloat`
  --> /Users/martin/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-array-30.0.1/src/arithmetic.rs:21:5
   |
21 | use num::complex::ComplexFloat;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ no `ComplexFloat` in `complex`

error[E0599]: no method named `powi` found for struct `f16` in the current scope
   --> /Users/martin/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-array-30.0.1/src/arithmetic.rs:351:25
    |
351 |                 Ok(self.powi(exp as i32))
    |                         ^^^^ method not found in `f16`
...
380 | native_type_float_op!(f16, f16::ONE, f16::ZERO);
    | ----------------------------------------------- in this macro invocation
    |
    = help: items from traits can only be used if the trait is in scope
    = note: this error originates in the macro `native_type_float_op` (in Nightly builds, run with -Z macro-backtrace for more info)
help: the following traits are implemented but not in scope; perhaps add a `use` for one of them:
    |
18  + use num::Float;
    |
18  + use num::traits::float::FloatCore;
    |
18  + use num::traits::real::Real;
    |

error[E0599]: no method named `powi` found for struct `f16` in the current scope
   --> /Users/martin/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-array-30.0.1/src/arithmetic.rs:356:22
    |
356 |                 self.powi(exp as i32)
    |                      ^^^^ method not found in `f16`
...
380 | native_type_float_op!(f16, f16::ONE, f16::ZERO);
    | ----------------------------------------------- in this macro invocation
    |
    = help: items from traits can only be used if the trait is in scope
    = note: this error originates in the macro `native_type_float_op` (in Nightly builds, run with -Z macro-backtrace for more info)
help: the following traits are implemented but not in scope; perhaps add a `use` for one of them:
    |
18  + use num::Float;
    |
18  + use num::traits::float::FloatCore;
    |
18  + use num::traits::real::Real;
    |

It seemed to become problematic between 30 and 35. I was able to fix this by adding
num-complex = "0.4.3"

to my Cargo.toml. I've submitted #4482 .

I filed https://github.com/apache/arrow-rs/issues/4486 to track adding a CI check for this.


scene.removeLayer概率出现buffer must not be deleted already

L7 Version:2.17.4
Platform:
Mini Showcase(like screenshots):
CodePen Link:

scene.removeLayer 此方法概率出现 buffer must not be deleted already

升级到最新的已经解决了


Gramm, flags and semantic

RNC should get only this params in query, raise and exception if sth went wrong.

Completed in 0.6.2