Validate Object existence when casting

When Object::cast_to<>() is used from a message it's possible that the
object has been deleted by the time the method is actually called. This
can then lead to a crash when trying to use dynamic_cast<>.
This commit adds a check to Object::cast_to<> to check in ObjectDB if
the object is in fact still valid. This appears to have a positive
impact on performance. I can't entirely explain why though. I assume it
is because we actually return NULL From dynamic_cast<> way more often
than we think. The hashtable lookup may be faster than a dynamic_cast<>
on a NULL object.
Some Bunnymark results:
Before:
benchmark output: 5497
benchmark output: 5460
benchmark output: 5584
benchmark output: 5587
benchmark output: 5611

After:
benchmark output: 5830
benchmark output: 5679
benchmark output: 5696
benchmark output: 5758
benchmark output: 5705

This fixes #26394 (The other case) and probably many other random crashes.

Sorry, this is an unnecesary check to me, if the pointer is invalid it should crash.
In 99.999999% usages of the cast_to function, the pointer is valid, I think you should check the instance when you use it and you are not sure instead, and not automatically every time.

The increase in performance is quite puzzling, though, dynamic_cast just does a few pointer comparisons.

I also wonder why does BunnyMark depends on the use of cast_to, that looks pretty inefficient, guess a lot needs to be researched here

I think the right solution for this is to add a method to Variant:
Variant::validate_object_instance() and call it in MessageQueue before submitting the message.

The problem is that the objects are valid when the message is put on the queue but no longer when the time comes to call the method.
In the editor we use both synchronous and asynchronous calls to change state. The problem is that a synchronous codepath can delete an object that has a message in flight. I can just make the messages in question synchronous instead (just make them function calls) perhaps?

Considering that dynamic_cast (depending on the compiler implementation) may require an indirection per class hierarchy level, it actually is quite possible for it to take more (way more) time than the hash table lookup. However, the performance should be checked with all supported compiler stacks to see whether that's the case everywhere, as dynamic_cast can be implemented in various ways.

Needs rebasing after #30934 - though that PR may have solved the issue that this aimed at fixing?
For 4.0, @reduz plans to rewrite this code, but for 3.2 we still need to make sure that we have the best fix possible.

Needs rebasing after #30934 - though that PR may have solved the issue that this aimed at fixing?

Just tested, #30934 did not fix the crash from https://github.com/godotengine/godot/issues/26394#issuecomment-469057689

@hpvb Is this still desired? If so, it needs to be rebased on the latest master branch.
If not, abandoned pull requests will be closed in the future as announced here.

I think this change is still desirable for 3.2. I'll have a look to see if this issue still exists in 3.2 today and rebase it if it does.

I think this change is still desirable for 3.2. I'll have a look to see if this issue still exists in 3.2 today and rebase it if it does.

I'd like to check how the dangling Variant fix can help with this. It will be promoted to release builds (according to some approved proposal), so it may have some overlap with what it's done here.

I'd like to check how the dangling Variant fix can help with this. It will be promoted to release builds (according to some approved proposal), so it may have some overlap with what it's done here.

Is this still relevant?
Just want to confirm because it's been a more than a year since last update and there were few changes(iirc) to Object in the past year.

@reduz says that this is no longer relevant in the master branch so this can be closed.
For Godot 3.x, there were a lot of iterations to improve this notably from @RandomShaper, I think we're in a pretty good state now? Could be revisited if some of the problems this aimed to solve are still valid.


Insufficient documentation regarding sockets

Since I don't know where else to put it, I figured creating an issue might be "least wrong" way.
There are quite some places which I, as a Sails beginner, did not understand and which seem to be nowhere documented. The list below are a few of these things. If I encounter more, I will update it.
undocumented features in routes.js:
{ action: '...', hasSocketFeatures: true },
A documentation on hasSocketFeatures, when it's needed, what it does etc. is nowhere to be found. Even Google finds only 1 result for "sails hasSocketFeatures" and that result is the routes.js.template file in the sails-generate repository.
Realtime communication (aka Sockets):
In the docs it says "To respond to requests to GET /say/hello, we use an action." But there is no explanation, how the "hello" action in the "SayController.js" is wired to GET /say/hello. To a beginner, it is unclear what that action definition has to look like in order to achieve the desired result.

Hi @caylab, hasSocketFeatures is used by the rebuild-cloud-sdk script in the Sails web app template.


Add battery kill circuit

The following is auto power off circuit.

We need to change auto power off function more smooth turn-on. And we should add function to turn-off direct.


First changes for building in Openshift the oai-base-build image

Added entitlement and subs (https://docs.openshift.com/container-platform/4.1/builds/running-entitled-builds.html)

@fzdarsky please review

In a local build, the subscription data is passed to the built container without requiring this step. You could add a condition (via an environment variable) to add the entitlements only if the build is on top of OpenShift, if that's what you want. Otherwise, this PR breaks the local builds.

closing this pull request as discussed


Empty sheet remains in view after Sign out

I am doing sign out and empty sheet remains in view like this:

This is the error I get in Xcode:
List failed to visit cell content, returning an empty cell. - SwiftUI/UICollectionViewListCoordinator.swift:373 - please file a bug report.
It started to malfunction today and it was working well previously.
This is the code structure for replication:
ContentView.swift
var body: some View {
            VStack {
                if clerk.session != nil {
                    TabView {
                        HomeView().tabItem { Label("Home", systemImage: "house") }
                        NewsView().tabItem{ Label("News", systemImage: "newspaper") }
                        MeView().tabItem{ Label("Me", systemImage: "person") }
                    }
                } else {
                    Spacer()
                    AdaptiveImage(light: Image("BlackLogo"), dark: Image("WhiteLogo"))
                    Spacer()
                    Text("Start here")
                    UserButton()
                }
            }
    }

Also I am using:
Xcode Version 15.0.1 (15A507)
and building on:
iOS 17.0

Hey @semirteskeredzic, thanks for the report. While Clerk prebuilt views are still very much a work in progress and subject to change, I think I see what's going on here.
Based on your screenshot, I'm guessing you have another UserButton somewhere else? Maybe in your MeView? At the moment, the UserButton isn't meant to be conditionally shown/hidden based on the presence of a session.  The user button is intended as a view that remains on screen between sign in and sign out. It functions as the sign in button when there isn't a session, and the account switcher / user profile when there is one. In your implementation it looks like you might be using it as a sign in button and separate sign out button.
I think what's happening is you are removing the parent view of the sheet (the UserButton) before it has a chance to dismiss.
Either way, thanks for the report. We'll take this use case into consideration as we continue working on Clerk's prebuilt views.


[Python][Packaging] Remove numpy required dependency from conda-forge packaging for PyArrow

Describe the enhancement requested
In https://github.com/apache/arrow/issues/43846 we removed numpy as a required dependency from PyArrow but this change only removed the dependency from our packages on PyPi and not on conda-forge. We should probably continue the effort and remove numpy as a required dependency on conda-forge.
I was able to confirm this locally, not that numpy is included:
❯ conda install --dry-run -c conda-forge pyarrow==18.0.0
...>%...
The following packages will be downloaded:

    package                    |            build
    ---------------------------|-----------------
    aws-crt-cpp-0.29.0         |       h871d450_6         224 KB  conda-forge
    aws-sdk-cpp-1.11.407       |       h19709bb_6         2.6 MB  conda-forge
    libarrow-18.0.0            |   h6fea68a_0_cpu         5.2 MB  conda-forge
    libarrow-acero-18.0.0      |   h286801f_0_cpu         480 KB  conda-forge
    libarrow-dataset-18.0.0    |   h286801f_0_cpu         486 KB  conda-forge
    libarrow-substrait-18.0.0  |   hdcc9e87_0_cpu         447 KB  conda-forge
    libparquet-18.0.0          |   hda0ea68_0_cpu         861 KB  conda-forge
    numpy-2.1.3                |  py312h94ee1e1_0         6.1 MB  conda-forge
    pyarrow-18.0.0             |  py312ha814d7c_0          25 KB  conda-forge
    pyarrow-core-18.0.0        |py312hc40f475_0_cpu         3.7 MB  conda-forge
    ------------------------------------------------------------
                                           Total:        20.1 MB

Component(s)
Packaging, Python

As discussed on Zulip, we may retroactively update the conda-forge packages for v18.0.0, see work in https://github.com/conda-forge/pyarrow-feedstock/pull/138. We should evaluate whether this should be moved into the now-closed 18.0.0 milestone before closing this issue.

@pitrou responded in https://ursalabs.zulipchat.com/#narrow/channel/453421-py-chat/topic/numpy.20as.20optional.20dep.20in.20pyarrow.2018/near/481075402 and that none of the three user packages should have a runtime dependency. I think that makes sense too.

I have updated the PR in that sense (https://github.com/conda-forge/pyarrow-feedstock/pull/138), I only kept the dependency for the pyarrow-tests package

Thanks for working on this. I can confirm I no longer get numpy when I install pyarrow==18.0.0 from conda-forge.

And thanks for testing!


Move to Svelte 4 style custom element API

Svelte 4.0.0 has been released: https://svelte.dev/blog/svelte-4.
Work can now be done to  align svelte-retag's API to the new format in Svelte 4's  <svelte:options customElement={…} /> (documented  here). For example (copied from https://github.com/sveltejs/svelte/issues/8681#issuecomment-1583128649):
// String syntax:
svelteRetag(component, 'example-element');

// Object syntax:
svelteRetag(component, {
	tag: 'example-element', // ('tag' removed in v5)
	shadow: 'none',
	props: {
		greetPerson: { reflect: true, attribute: 'greet-person' },
	},
});

Propose passing in the component as the first required parameter and then allow for an easy direct copy/paste of the Svelte 4 style customElement options as a second parameter (with the same baseline requirements). This will be supported features only.
Important: Rolling into v2 milestone., since this syntax should replace the old component definition syntax. Doing so should make the API of svelte-retag overall easier to comprehend for others (a huge plus for a library). Plus it’s likely easier to implement/maintain.
Supported features
Due to the complexity of the API (at time of writing) it may be worthwhile to outline exactly what we want as “must have” vs. “nice to have” if possible in this ticket. Otherwise, implement the “must haves” and delegate the “nice to have” features to a separate issue for now.
Must have

[ ] tag for tag name
[ ] shadow for use of shadow DOM or not (must default to true, methinks)
[ ] props where each key defines the property (e.g. greetName) with support for

[ ] attribute defines alternative attribute name
[ ] type to coerce to a particular type (instead of always being type String (per HTML attribute spec)

Nice to have

[ ] props where each key defines the property (e.g. greetName) with support for

[ ] reflect to perform the inverse of the current reactive forwarding, i.e. watch for changes in the component and forward that to the attribute in the DOM.

[ ] extend add ability to pass main class constructor to provided callback so it can extend and then return the class to instantiate for the main customElements.define() call.

Quick note: Clarified that this will be for supported features only, i.e. either features that already exist or ones being added specifically in this ticket (e.g. custom attribute names and attribute type coercion).
This is worth calling out so that the expectation isn't set that we'll always 100% support all features of <svelte:options customElement={…} /> per se, but rather have an API that is very similar in order to support migration. This is not intended to be a drop-in but instead an alternative with the ability to enhance with additional features, where feasible. 🙂


[BUG] [BUG] tokenCachePersistenceOptions.unencryptedStorageAllowed not functioning on Linux

I'm reopening the following issue that was planned for this November. Please see the original issue for details. Thanks!

Hi @zc07, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

Originally posted by @github-actions in #32138

Thanks for re-opening this @zc07.
@g2vinay, @billwert could you look into this.


New-AtwsContractServiceAdjustment: Get-AtwsData : This entity type does not support the query action.

Operation succeeds, but it appears that there is no get-function for the AtwsContractServiceAdjustment anymore, (not queriable according to the API...)
New-AtwsContractServiceAdjustment -EffectiveDate $adjustmentDate -ContractServiceID 381 -UnitChange 17
Get-AtwsData : This entity type does not support the query action.
At C:\Program Files\WindowsPowerShell\Modules\Autotask\<IP_ADDRESS>\Static\New-AtwsContractServiceAdjustment.ps1:244 char:15
+ ...   $Result = Get-AtwsData -Entity $EntityName -Filter $NewObjectFilter ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Get-AtwsData

Hi, I have a fix for this out in the beta module, and I hope to publish the fix to the main module today.

Should be fixed in newer module versions.


Envoy: make ext-authz gRPC service cross-compatible with V2Alpha version

https://github.com/envoyproxy/envoy/issues/5727

Done on the Envoy side.


fix dependabot config format

But but but… these two variations are equivalent :thinking:
a:
- foo
- bar

a:
  - foo
  - bar

Are you experiencing a failure or is it only a cosmetic fix?

mhm another linter told me it's not the same :thinking: I will take a look again.

indeed you're right


Profile page styling looks a little off

Here's what the profile page looks like after I created and account and logged in for the first time:

You need to close the inspect section on the right. Since this is built for most scientists to use, they would not click on inspect like us as the col style is maximize for profile with 100% screen size. Thanks :)


In Contributor Guide, fetch instruction produces error

In the Contributor Guide on the Find and claim an issue page, Step 5, you are instructed to fetch all the changes from the upstream/master branch:
$ git fetch upstream/master
This produces an error: fatal: 'upstream/master' does not appear to be a git repository
Rather, you should be fetching from the upstream remote:
$ git fetch upstream
This works!
remote: Counting objects: 1388, done.
remote: Compressing objects: 100% (512/512), done.
remote: Total 1388 (delta 486), reused 209 (delta 209), pack-reused 667
Receiving objects: 100% (1388/1388), 1.12 MiB | 872.00 KiB/s, done.
Resolving deltas: 100% (679/679), done.

Hmm, it might be confusing, but the right instruction is already there:

Fetch all the changes from the upstream/master branch.

$ git fetch upstream
...

#dibs
upstream/master is the local copy of the upstream master branch, upstream master refers to the master branch on the remote upstream repository.
There's some confusion about this in the docs, I'll take a stab at clarifying.

oops, race condition :)


Load page x keeps incrementing even when nothing can be retrieved

Hmm, will investigate. Def shouldn't increase pages when there is nothing, tho sometimes you can keep loading stuff and its all under "Read" (b/c its filtered when you're on Unread).
I might need to tweak the design to make this more obvious. Maybe even an alert after 1-2 pages that's like "New stuff is under Read" or w/e.
Or maybe I put a count under read/unread and you can also see that increment? Dunno.

Just checked this and on both unread and read, the number is just constantly incrementing!
Also on the unread tab, if there are no new notifications then you have to scroll down a tiny bit to see the pagination button.
IMO: The load page button should only show if it's applicable to the content you're viewing - if there isn't 2 pages of unread notifications then don't show it (but then give me the option to when I toggle over to read ones)

Tracked down & fixed

This seems to have resurfaced?

@BasThomas are you sure it's just not loading stuff that is unread?

Nope, and disappeares after 3. Really strange.

Looking in to this it seems like it now only shows the load next (2), then disappears.
poing the link first gives:
"<https://api.github.com/notifications?access_token=xxx&all=true&page=2&participating=false&per_page=100>; rel=\"next\", <https://api.github.com/notifications?access_token=xxx&all=true&page=2&participating=false&per_page=100>; rel=\"last\""

Then after tapping load page 2:
"<https://api.github.com/notifications?access_token=xxx&all=true&page=1&participating=false&per_page=100>; rel=\"first\", <https://api.github.com/notifications?access_token=xxx&all=true&page=1&participating=false&per_page=100>; rel=\"prev\""

I almost think this is a GitHub API issue?

Ya, I've done some digging here and am almost positive its a GH issue. The Link header isn't consistent whatsoever.

Haven't being seeing this lately, could it be that this has been fixed?

I think by breaking up the requests this no longer happens!


Show page header only once for adjacent results from the same page

Related to https://github.com/dvargas92495/roam-js-extensions/issues/486
For the case of queries

On a page with many matching blocks, the page title appears many times and is distracting. I would like to have the page header appear only once:

I think a more flexible approach than the current one would be having a series of sorting criteria, such as
Sort: [Page Title, Block Title, Block Created]

maybe with an additional setting like
Merge Blocks Under Page: True

I really like the Merge Blocks Under Page idea! I could also see Default Sort taking an array of sorting criteria
I think you want to have a flag to either sort page or blocks - the two have pretty different sorting logic and not immediately obvious how you would interleave them

I really like the Merge Blocks Under Page idea! I could also see Default Sort taking an array of sorting criteria
I think you want to have a flag to either sort page or blocks - the two have pretty different sorting logic and not immediately obvious how you would interleave them

Query Builder is now the go to query/sorting/view management extension


C API prevents GC'ing externref values

I'm in the process of trying to update wasmtime-py to the latest C API to weed out any issues ahead of the 20.0.0 release. One test is currently failing which asserts that a value is collected and unreferenced in Python, but it's failing. The general shape is:

Create a wasmtime_externref_t
Put that in wasmtime_val_t
Pass that to wasmtime_func_call
Run store.gc()
Assert that the value has geen gc'd

The problem appears to be here if I'm understanding this correctly. Notably in this location there's no RootScope so the to_val, which creates a Rooted<T>, attaches itself to the Store directly meaning that it's now un-collect-able.
cc @fitzgen

Yeah that function takes any impl AsContextMut and it is on callers to provide a suitable context, since that function cannot (it returns a rooted value, so that function can't create the scope, callers must).
So the question is: which caller needs to be updated to add a root scope? I guess wasmtime_func_call?


Adds Login Instructions to README.md

Adds instructions for login for a nice user experience with slightly less troubleshooting (maybe?)
(Seems like it's also removing an extra space on line 137 which is fine I think)

@JimLynchCodes this looks good, thanks!


flutter/packages needs a LUCI solution for check overrides

The version-check command in the flutter/packages CI is set up to, in presubmit, look for likely-missing version changes, as well as for major version changes to platform interface packages (since we almost never actually want to do those). Because it can have false positives, we need a way to override it when it's wrong—the idea is that this is something that we frequently forget (missing versions) or someone might not realize is a big deal (major version bumps to platform interfaces), so we want something that requires a human to explicitly say "yes, we looked at this, and we deliberately chose not to do what we are doing, rather than forgetting or not realizing".
How can we handle this in LUCI tests?
(The way it works with the Cirrus config is that one of the special env variables Cirrus passes to all runs is CIRRUS_PR_LABELS, which has the current set of GitHub labels on the PR, and so we set a label to indicate that we want to override, re-run that check, and the tooling knows to then not fail. We don't need it to be that specific flow, but we need some solution.)

Would the characteristics of this requirement be satisfied by having a value set in the .ci.yaml file?

I'm not following; how would we override a check for one specific PR with .ci.yaml?

This is now the last dependency on Cirrus in flutter/packages.

@stuartmorgan change is in to propagate the labels to build properties, which you can use in your recipes.

which you can use in your recipes.

We just have the one recipe; could you update it to transfer that property to an environment variable? That would let us directly migrate the existing task.

Yes, I'll do that

https://flutter-review.googlesource.com/c/recipes/+/50421

Change submitted. closing.

This does not appear to be working. I made a test PR, verified that it failed as expected, then added an override label and re-ran the test. On the re-run, there environment variable is empty:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8771239673077318481/+/u/Run_package_tests/CHANGELOG_and_version_validation/execution_details

I think my change hasn't been pushed to prod yet, so its not appearing. tracking down the deployment.

Looks like https://github.com/flutter/cocoon/pull/3032 blocking deployment of changes.

Thanks for tracking that down; I saw the variable being there and assumed that things had propagated, and didn't consider that just the recipe part could have.
Let me know when it's good to re-test!

Override labels now propagating: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8771227551692090177/+/u/Run_package_tests/publishability/execution_details


ColorFilter layers not working on Firefox HTML backend

import 'package:flutter/material.dart';

void main() {
  runApp(
    MaterialApp(
      title: 'Demo',
      theme: ThemeData(primarySwatch: Colors.blue),
      home: const Scaffold(
        body: SizedBox(
          height: 50,
          width: 50,
          child: ColorFiltered(
            colorFilter: ColorFilter.mode(Colors.red, BlendMode.srcIn),
            child: Icon(Icons.abc),
          ),
        ),
      ),
    ),
  );
}

On CanvasKit, this renders the ABC icon in red on Chrome, Firefox, and Safari. On the HTML backend, it renders it in black on Firefox. Tested on Firefox 98.0.1 and 98.0.2 on macOS, but also reported on a Linux workstation.
Framework revision info:
[✓] Flutter (Channel master, 2.13.0-0.0.pre.226, on macOS 12.3 21E230 darwin-x64, locale en)
    • Flutter version 2.13.0-0.0.pre.226 at /Users/dnfield/src/flutter/flutter
    • Upstream repository git@github.com:dnfield/flutter
    • Framework revision 3420b9c50e (22 hours ago), 2022-03-23 19:30:07 +0100
    • Engine revision 4fbff7a511
    • Dart version 2.17.0 (build 2.17.0-227.0.dev)
    • DevTools version 2.11.4

root cause of dnfield/flutter_svg#687

Is this going to be addressed somewhen?

Really need it to be fixed!

Any progress here? This is so annoying.

Just created another demo before finding this issue here:
https://higaski.at/flutter_color_filter_issue/
First logo in this demo should be black, the second one red...


Question about data type used

Hi, I'm considering littlefs to use with an MSP430 MCU and noticed that lfs.c has the datatype "int" whereas datatypes of other widths use C99 datatypes like uint16_t. "int" is treated as 16-bit for the MSP430 and I was wondering if there was a reason for using "int" in lfs.c. Is that because littlefs is expected to work with 32-bit MCUs only?

Hi @abtj, sorry about late response. littlefs is not intentionally 32-bit only, but I haven't tried running it on a 16-bit platform and there is nothing testing 16-bit support.
The most common use of int is in return types, where it is used with functions that can return negative error codes that match POSIX definitions. These do not exceed -256. For other parameters there is an explicit lfs_size_t and lfs_off_t, both of which are defined to be 32-bits.
Unfortunately the internals use the C99 types much less consistently and skimming the code base it looks like there are several cases where it may fail.
But do let us know if you are able to get the MSP430 working.


Support J2V8 3.1

We should finalize J2V8 3.1 and move to this version in Tabris-Android. This adds a few stability fixes for long running instances, and some small performance improvements.

:+1:


How to pass --harmony to the fly command?

I have ES6 codebase and ES6 Gulp files and even the code in the flightplan.js is ES6-based...
How can I specify the '--harmony' flag to flightplan?

fly --harmony ... does the trick

Please reopen this ticket if you have any further questions.

fly --harmony ... does the trick ---- this definitely do not do anything ....

first line of my flightplan file:
var config = require('./configServices').env().argv().config();

That config services is using functions definitions like this:
env: () => {
	_.merge( this.conf, process.env );
	return this;
},

And flightplan dies here because of the ()=>
Running that line with simple node using --harmony work perfectly.

fly --harmony staging
✈ Running default:staging
✈ Executing local task
localhost Run build
localhost $ gulp build
localhost > /.../configServices.js:5
localhost > 	env: () => {
localhost > 	      ^
localhost > SyntaxError: Unexpected token )


Error: "value" must be an object

Hi, there
i trying to use postman for check this api but evertime i get this :
{
  "statusCode": 400,
  "error": "Bad Request",
  "message": "\"value\" must be an object",
  "validation": {
    "source": "payload",
    "keys": [
      "value"
    ]
  }
}

Thanks for creating an issue.
Since there is no value key in the login route handler, I suspect someone else is happening here.
Also you likely don't want to pass query parameters or use the "Authorization" feature with Postman, since you're trying to establish a new session when POSTing to /api/login.

ohum i get it, sorry i just new with postman.
thanks so much


Add option for using PhantomJS

Add an option to use the website-scraper-phantom module to download pages.
This can might be accomplished by

Providing an config option to use the module
Using the module if it is installed (users just have to install the module & the normal install doesn't fail if their platform is not supported by PhantomJS)

This was implemented in this commit


Command failed dot -Tpng

Hello!
For code below
    await graphviz.exportToFile('digraph g { a -> b }', {         format: "png",         output: 'example.png',     });
i have a error
Uncaught Error: Command failed: dot -Tpng -o example.png /var/folders/yq/bxh3c38d5z9bc8zxtklmkkcm0000gn/T/tmp-16365-XTc0c1Fr1uTU

@ArtemAdamenko It did not occur in my environment.
Please give me as much information as you can reproduce, including OS, Node.js version, package version, and Module format.

`import * as graphviz from "@ts-graphviz/node";
(async function test() {
let dot = 'digraph g { a -> b }';
await graphviz.exportToFile('digraph g { a -> b }', {
format: "png",
output: 'example.png',
});
})()`
macOs Monterey 12.5.1
Nodejs 16.14.2
"@ts-graphviz/node": "^0.4.1"
Module format default - im not setup module format in package.json

@ArtemAdamenko
I tried to create a reproducible environment, but it didn't seem to reproduce with only the information I could find.
Are there any other factors?

I don't own a macOS device, so I would appreciate your help in forking the repository to reproduce the phenomenon.

@ArtemAdamenko
This project has been merged into ts-graphviz.
When we migrated to ts-graphviz, we changed to a method that does not use temporary files, so we do not expect this problem to occur.
We recommend that you migrate to the adapter module of ts-graphviz.


Progamatically blur active field (plus misleading docs)

Right now, I think the docs have a typo in them. On the "Action Creators" page, blur has the following content:
https://redux-form.com/6.7.0/docs/api/actioncreators.md/
blur(form:String, field:String, value:any)
Saves the value to the field.
I can't imagine that's right. It leads me to a followup question, how do you use this action creator, and is it possible to use it without the field being given to it, essentially blurring whatever field is focused?
If not, is there a way to get the currently focused field programatically?
Cheers! Great product!

blur is not dissimilar to the change action, so the docs are not incorrect even if not entirely helpful. However unlike change action it will remove the meta.active flag on the field.
A fields meta state is not expected to be reflected in the DOM in the same way that e.g. the value is. In particular you'll notice that the meta.active flag only works if you are calling focus on focus and blur on blur.
If you want to work with the focused element, you can do that with native dom api, but it's not something redux-form manages for you.

Closing due to lack of response, but I should started with the fact that document.activeElement.blur() will possibly do what you want :).


Have removed the image from header navbar and fixed classes.

Image has been removed from the header.jsx file.
I've also renamed all instances of "class" with "className".


Key Error: httpdbg_current_tag

This error may happen when using httpdbg 0.24.0 with pytest.
Will be fixed soon.

Fixed in v0.24.1.


Rename board_urls() to board_url()

The R package has the URL board as board_url() and the plural here was a bit of an oversight, so let's harmonize these names eventually. Related to rstudio/pins-r#650.

I think this may be completed already. Using board_urls gives a deprecation warning in pins-python, encouraging the use of board_url. Do you mind double checking and closing / letting me know if more is needed?
https://github.com/rstudio/pins-python/blob/main/pins/constructors.py#L298-L309

I think the switch to board_url was done in the reference (but wouldn't be surprised if there are lingering board_urls references)

Ah yep, you did this last month. Apologies for not looking carefully enough! 🙌


Splitgen skip fix

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] I have read the CONTRIBUTING.md document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

This PR fixes a bug introduced by my previous PR on categorical splits. The issue was that even though splits are ignored on write time by checking against the SKIP flag, all split names returned by the SplitStep were encoded in the output artifact, including SKIP. This is now fixed by removing SKIP from the output split names by list comprehension.
Additionally, I added the .DS_Store to the .gitignore file to suppress these files from my local Git on macOS.

Not sure about where, to be honest? This is on the executor level, which is usually not where the user directly selects anything. The SKIP flag itself and its usage are documented in both of the categorical split steps. This is just an internal cleanup - split step logic is untouched.

Not sure about where, to be honest? This is on the executor level, which is usually not where the user directly selects anything. The SKIP flag itself and its usage are documented in both of the categorical split steps. This is just an internal cleanup - split step logic is untouched.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: nicholasmaiot:x: htahir1You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: nicholasmaiot:x: htahir1You have signed the CLA already but the status is still pending? Let us recheck it.

Not sure about where, to be honest? This is on the executor level, which is usually not where the user directly selects anything. The SKIP flag itself and its usage are documented in both of the categorical split steps. This is just an internal cleanup - split step logic is untouched.

I updated the structure. Please try to build the docs (guide is in docs/README.md) after installing the requirements.txt in the root. Then you would see the new docs locally created at docs/book/_build/html/index.html. Check out what i did in the Steps section with the split. Here you can now add a small note about the SKIP_STEP?

Not sure about where, to be honest? This is on the executor level, which is usually not where the user directly selects anything. The SKIP flag itself and its usage are documented in both of the categorical split steps. This is just an internal cleanup - split step logic is untouched.

I updated the structure. Please try to build the docs (guide is in docs/README.md) after installing the requirements.txt in the root. Then you would see the new docs locally created at docs/book/_build/html/index.html. Check out what i did in the Steps section with the split. Here you can now add a small note about the SKIP_STEP?

Not sure about where, to be honest? This is on the executor level, which is usually not where the user directly selects anything. The SKIP flag itself and its usage are documented in both of the categorical split steps. This is just an internal cleanup - split step logic is untouched.

I updated the structure. Please try to build the docs (guide is in docs/README.md) after installing the requirements.txt in the root. Then you would see the new docs locally created at docs/book/_build/html/index.html. Check out what i did in the Steps section with the split. Here you can now add a small note about the SKIP_STEP?

Done in the latest commit. Thanks for revising the structure!

Not sure about where, to be honest? This is on the executor level, which is usually not where the user directly selects anything. The SKIP flag itself and its usage are documented in both of the categorical split steps. This is just an internal cleanup - split step logic is untouched.

I updated the structure. Please try to build the docs (guide is in docs/README.md) after installing the requirements.txt in the root. Then you would see the new docs locally created at docs/book/_build/html/index.html. Check out what i did in the Steps section with the split. Here you can now add a small note about the SKIP_STEP?

Done in the latest commit. Thanks for revising the structure!


remove an extraneous line of output when launching the simulator

Remove an extraneous line of output when launching the simulator. Before we showed:
[~/flutter/flutter_sunflower] flutter -d B0484E69-8A54-4CCF-8804-4780BD7D5DD4 start
Starting lib/main.dart on iPhone 6s...
io.flutter.runner.Runner: 67375

This removes io.flutter.runner.Runner: 67375 - it wasn't totally clear to the user what that's for.
@chinmaygarde

lgtm


Prepare next Dev Cycle v1.105.0-dev

How to categorize this PR?

/kind enhancement
What this PR does / why we need it:
Prepare next Dev Cycle v1.105.0-dev.
Release note:

NONE

/hold

/hold cancel

/test pull-gardener-e2e-kind-upgrade


Improvements of SEO Tab

The current SEO Tab should be improved, changed with the following:

Add titel for SERP Preview
Left aline SERP Preview
Add correct titles for elements (as in code: Meta Title, Meta Description, Meta Keywords)
Add counter for Title length (55 Characters with Space recommended)
if possible change color to red if character count is 0

@berndhep Do you agree? Should this be done before the 1.1 release?

@danrot No, that's 1.2


FB convert PostgresImagery.java to imagery.clj

imagery.clj:

Lines 13,27,34,38: Non-idiomatic function name. Sequence functions
take their sequence as the last argument (to be compatible with
->> semantics) and should take a function to apply to the elements
in the sequence. Consider renaming this to prepare-imagery to
match prepare-institution in institutions.clj.
Line 20: (json/read-str extent)
Line 21: (if admin? (json/read-str source_config) (clean-source (json/read-str source_config)))
Line 33: :token-key -> :tokenKey (camelCase matches the Java
implementation and is consistent with all other params and sessions
keywords (except flash-message, which should be renamed to
camelCase).
Lines 42-45: Incorrect implementation. get-imagery-source-config
returns a source-config map, not a response map. Also, call-sql
can only call functions, not arbitrary SQL. My comments for
imagery.sql include a new function definition to resolve this issue. Use this code instead:

(defn get-imagery-source-config [imagery-id]
  (if-let [imagery (first (call-sql "select_imagery_by_id" imagery-id))]
    (json/read-str (:source_config imagery))
    {}))

Line 51: No json/read-str since we have to pass a stringified version of the JSON to "add_institution_imagery".
Lines 52,93: str-bool -> str->bool
Lines 52,93: str->bool will not default to true if :addToAllProjects
is missing because (boolean nil) is false and will not throw an
exception. Use this code instead:

(tc/str->bool (:addToAllProjects params "true"))

Line 72: :geeParam -> :geeParams
Line 85: (json/write-str source-config)
Line 92: No json/read-str since we have to pass a stringified version of the JSON to "update_institution_imagery".
Line 94: call-sql can only call functions, not arbitrary SQL. My
comments for imagery.sql include a new function definition to
resolve this issue.  You just needed to change the :tokenKey params keyword to camelCase.)

type_conversion.clj:

Add these function aliases for completeness:

(def clj->json json/write-str)

(def jsonb->json str)

Line 18: (str string) -> string (If string isn't a string, the function has been called incorrectly and should throw an error.
Also, add back try/catch to match str->int's behavior. Otherwise, (str->bool 10 true) returns false, which is probably not what we intend.
The following code ensures that str->int and str->bool both have these properties:
1. If string = nil, return default
2. If string is not a string, return default
3. If string is an incorrectly formed string, return default
4. Otherwise, return the parsed value

(defn str->bool
  ([string]
   (str->bool string false))
  ([string default]
   (if string
     (try
       (Boolean/parseBoolean string)
       (catch Exception _ default))
     default)))


default extension list is different depending on PHP versions being preinstalled or no.

Describe the bug
When the selected PHP version is not pre-installed, the extensions available by default (without any extensions config being set) are not the same than when the version is preinstalled.
With github migrating ubuntu-latest from ubuntu-18.04 to ubuntu-20.04 which removed PHP 7.3 and older from preinstalled versions, this issue is likely to break more repositories.
Version

[x] I have checked releases, and the bug exists in the latest patch version of v1 or v2.
[x] v2
[ ] v1

Runners

[x] GitHub Hosted
[ ] Self Hosted

Operating systems
linux (maybe others too, but not tested)
PHP versions
7.1
To Reproduce

Expected behavior
As pdo_mysql is enabled by default in preinstalled PHP versions, it should also be enabled by default when installing another PHP version without configuring extensions IMO (same for other extensions of course)
Screenshots/Logs
See https://github.com/symfony/maker-bundle/pull/828 for an example
Additional context

Are you willing to submit a PR?

Installing the same extensions on ubuntu-20.04 with PHP 7.3 as the preinstalled versions would take 1-2 minutes for everyone. Instead all the extensions which are needed should be specified so that workflow is optimised as per the requirement.
Also, You can always use ubuntu-18.04 or ubuntu-16.04 instead of ubuntu-latest.
https://github.com/shivammathur/setup-php#github-hosted-runners
But, in my opinion GitHub Actions images should provide the same PHP versions pre-installed on all ubuntu versions as ondrej/ppa supports PHP 5.6 and above, and provides security patches for them. So please ask actions team to improve this.
I think they are following Travis CI, but Travis compiled PHP using php-build, which does not provide any security patches and thus required dropping PHP versions as they deprecated.

@stof
Installing the same extensions on ubuntu-20.04 with PHP 7.3 as the preinstalled versions would take 1-2 minutes for everyone. Instead all the extensions which are needed should be specified in extensions input so that workflow is optimised as per the requirement.
Another solution is using ubuntu-18.04 or ubuntu-16.04 instead of ubuntu-latest.
https://github.com/shivammathur/setup-php#github-hosted-runners
But, in my opinion GitHub Actions images should provide the same PHP versions pre-installed on all ubuntu versions as ondrej/ppa supports PHP 5.6 and above, and provides security patches for them. So please ask actions team to improve this.
I think they are following Travis CI, but Travis compiled PHP using php-build, which does not provide any security patches and thus required dropping PHP versions as they deprecated.

Considering mysql and pdo_mysql are widely used, They should now be installed with every PHP version on ubuntu. As for other extensions they should be specified in extensions input as required.

@stof @driesvints
After cache improvements in https://github.com/shivammathur/php-ubuntu/commit/1693db3f0707e0d1201282dab40857cd341d6664, on all three supported ubuntu versions same set of extensions should be available by default when PHP is installed as they are when PHP is pre-installed.

@shivammathur that's great, thanks! I'll roll out updates for ubuntu-20.04 soon.

@shivammathur that's great news


feat!: autoscaler with scaling schedules

what

Add the ability to use an autoscaler to scale down to zero outside the defined schedules.
No more than one instance will be created at the same time.
Since we can only attach autoscalers to non-stateful MIGs, this commit also removes the responsibility of creating the home folder disk (atlantis-disk-0) from it, effectively making it a stateless MIG. Nonetheless, destroying the group will not destroy the disk.
Add resources for the disk and the autoscaler, and a usage example. Updated the README.

BREAKING CHANGE: the 50GB stateful disk is no longer created by the MIG, which makes the MIG no longer stateful. Additionally, if terraform destroy is executed, the disk is destroyed.
why

Many times, teams only use Atlantis during certain week days and periods of the day (e.g. 8AM to 7PM). This feature allows the MIG to scale down to zero outside the defined periods. Scaling down during the weekends alone will reduce costs by ~28%.
Cost is usually the main concern when adopting Atlantis vs GitHub Actions.

Notes:

How responsive is the scaling with respect to the schedule?

~2-3 minutes to scale up, ~10 minutes to scale down after the window ends.

Will the MIG scale down even if an apply is executing?

Yes. The plan becomes stale, and an atlantis plan and apply will fix the drift.

What happens if the instance is destroyed after a plan is calculated?

When the instance is brought back up, the disk is attached and you can atlantis apply as usual.

Let me know if you find this useful, and whether it fits your vision for the module! 😄

Sidenote: We also tried to implement an on-demand scale up (to deploy an instance outside the schedules) using Monitoring metrics based on the load balancer, which is technically possible, but we were unsuccessful. While the group indeed scales from 0 to 1 when requests arrive, it never scales back down: in the absence of requests, the metric will keep the last value. For reference, we tried the following:
resource "google_compute_autoscaler" "default" {
  # ...
  autoscaling_policy {
    dynamic "metric" {
      for_each = var.autoscaling.scale_up_on_demand ? [
        # You can only use the AND operator for joining selectors. You can only use direct equality comparison operator (=) without any functions for each selector.
        # Metric types must be unique within the scaling configuration.
        {
          # Keep instance up when used
          name   = "loadbalancing.googleapis.com/https/request_bytes_count"
          filter = "metric.labels.response_code_class = \"200\" AND resource.type = \"https_lb_rule\" AND resource.labels.project_id = \"${var.project}\" AND resource.labels.forwarding_rule_name = \"${var.name}\""
          target = 1
        },
        {
          # Scale up when needed
          name   = "loadbalancing.googleapis.com/https/request_count"
          filter = "metric.labels.response_code = \"503\" AND resource.type = \"https_lb_rule\" AND resource.labels.project_id = \"${var.project}\" resource.labels.forwarding_rule_name = \"${var.name}\""
          target = 0.001
        }
      ] : []
      content {
        name   = metric.value.name
        target = metric.value.target
        type   = "DELTA_PER_SECOND"
        filter = metric.value.filter
      }
    }

references

Scaling schedules: https://cloud.google.com/compute/docs/autoscaler/scaling-schedules#schedule_configuration_options
google_compute_autoscaler resource: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_autoscaler#nested_scaling_schedules

Thanks for opening this extensive PR @d-costa - allow me to review it as soon as possible together again with the other PR (which I already reviewed but just need to merge). End of year was really hectic for me unfortunately!

No problem at all! And happy new year 😄

Could you please resolve the conflicts @d-costa, I've just merged the Shared VPC PR from you (#137)

hey @bschaatsbergen , how are you?
Any idea on when you might be able to review this and #131 ?
We are currently using a local version of this but we would love to point all the way to your upstream :)

hey @bschaatsbergen , how are you? Any idea on when you might be able to review this and #131 ?
We are currently using a local version of this but we would love to point all the way to your upstream :)

Hi @dgteixeira, thanks for getting in touch. Now that the repository has been transferred to the runatlantis organization, and you, @d-costa, @DanielRieske, and @cblkwell are maintainers of this repository, I encourage you to collaborate on addressing these PRs together :)

This one looks good to me if we can resolve the conflicts -- once that is done I don't think I'll have a problem signing off.

Hrm. What's up with the ci? :/


Program crash when using copy command in filter->preview

When go to option->filters->click on the box->preview, then right click->copy everything, the program will crash.

try updating your runtimes.
It's a little hard to debug the error without a log.

This is the error message:
 System.ArgumentNullException: Value cannot be null. Parameter name: text    at System.Windows.Forms.Clipboard.SetText(String text, TextDataFormat format)    at StaxRip.UI.RichTextBoxEx._Lambda$__7-1()    at StaxRip.UI.ActionMenuItem.OnClick(EventArgs e)    at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)    at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)    at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)    at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)    at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)    at System.Windows.Forms.Control.WndProc(Message& m)    at System.Windows.Forms.ToolStrip.WndProc(Message& m)    at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)    at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

It's expecting text it never receives the text.
It looks like whatever is being added it causing problems.
Try:
add the text after the source inside the editor and see if it crashes. That way we can rule out if the filters are causing the problems are not.
Also go into the app list and make sure MS runtimes are all listed. Also make sure you have all the fonts installed too.
This is my own personal version of StaxRip, which I have tested heavily. I have zero crashes with it. If the same errors happen with this version. It's something to do with your PC. It's missing or file got corrupted some how.
link: https://github.com/Revan654/staxrip


Added matplotlib visualizations

Removed the print statements for sentiment ratios

@vinitshahdeo Can you please add the hactoberfest label in the repo? Or else it won't count towards the event.
Thanks!


【enhance】auto test restruct

What type of PR is this?
/feat
Which issue(s) this PR fixes:
Fixes #966
Use case description:

All test case will hava the unified entrance for framwork versions
Workflow will has itself concurrency group
Workflow will trigger by code path
Fix the problem that package agent failed when jdk is 11+

Does this PR introduce a user-facing change?
No
Additional documentation e.g., usage docs, etc.:
No

后续pr补充当前自动化测试架构说明文档


FS-3684 - Remove unneeded copilot environment files

Change description
Since workflows now handle copilot environments, we can remove these separated and unsynced files
+ref: FS-3684
+semver: minor
[ N/A ] Unit tests and other appropriate tests added or updated
[ N/A ] README and other documentation has been updated / added (if needed)
[ X ] Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

Failing workflow (copilot_build) failing due to no longer having an environment. Expected, as it's using the 'copilot deploy' command rather than the new 'copilot svc deploy' command. Will be resolved in a later commit, no impact on workflow operations otherwise.


Validating Arrays Bug

Hi @thetutlage
Thanks for your hard work. I am using Laravel and I like it soo much but I like your work too.
I am watching your video at youtube and learning the Adonis ( thnks for them too, pls keep them with better sound its hard to listen & and lower resolution )
I found a bug on Validation module  at this video you are telling about.
When we have form for multiple user form and if user gives us same info it passes the validation we get duplicate users at database...
( https://www.youtube.com/watch?v=4MB0_X1fm5k )
Thanks for all...
Mustafa

Cannot help much without any code to reproduce the issue

Closing since no response from issue reporter


exclude query not respected for Time consuming prepare / bind reports

Using pgBadger 11.8 latest and Postgres 14.2
2022-07-09 23:52:57 UTC [711397]: db=smdb,user=successmaker,app=PostgreSQL JDBC Driver,client=<IP_ADDRESS>,session=62c751ee.adae5,sessionstart=2022-07-07 21:36:46 UTC,tx=0LOG:  duration: 0.022 ms  parse : SET SESSION CHARACTERISTICS AS TRANSACTION ISOLATION LEVEL READ UNCOMMITTED
2022-07-09 23:52:57 UTC [711397]: db=smdb,user=successmaker,app=PostgreSQL JDBC Driver,client=<IP_ADDRESS>,session=62c751ee.adae5,sessionstart=2022-07-07 21:36:46 UTC,tx=0LOG:  duration: 0.004 ms  bind : SET SESSION CHARACTERISTICS AS TRANSACTION ISOLATION LEVEL READ UNCOMMITTED
2022-07-09 23:52:57 UTC [711397]: db=smdb,user=successmaker,app=PostgreSQL JDBC Driver,client=<IP_ADDRESS>,session=62c751ee.adae5,sessionstart=2022-07-07 21:36:46 UTC,tx=0LOG:  execute : SET SESSION CHARACTERISTICS AS TRANSACTION ISOLATION LEVEL READ UNCOMMITTED
--exclude_query="^(SET|SHOW")
Note that the HTML report in the "Top" menu exclude these except for "Time consuming prepare" and "Time consuming bind" which include them.
Expected behavior is --exclude_query should apply to Time consuming prepare and bind as well

Commit e4da5f2 fixes this issue.


[Question] Can I properly render a custom component?

Hi, everyone! @noraesae thank you for a great job!
I have a question from the subj. For example, my HTML comes to me from the backend and it contains something like that:

Hello, <Link to={"/people/bro"}>@bro</Link>!

<Link> is the component from react-router. So the question is can I hope to render this component as it should be and expect that it would work properly? Also, can I render some project-specific components?
Thank you for your future answer!

I'm not the owner of the library, but it seems that the goal of this library takes HTML as input (not JSX) and converts it to a tree of react elements that you can then render.

@jnak Thanks for your comment. I guess you're right, as I needed to render inner links, first of all, I came up with a workaround of catching click events.

No worries. You should close the ticket if you're done.

FYI, I just did something similar. I am pulling my content from a back and was trying to make the links coming in relative for react-router.
For instance my backend is wordpress sitting at admin.site.com and my frontend is react/redux/xyz:
This code might need some tweaking and I apologize for bad style as this is my first time posting some type of help.
`swap(obj, component){
// instantiating a null node
let c = null
// if the obj matches type ''
if(obj.type == "a"){
// check if domain is external ...
		// we now have the url and can parse it
		let url = new URL(obj.props.href)
		// if the host is the backend site
		if(url.host == 'fam.pica.is'){
			// we are dealing with an internal link
			url = url.pathname
			// we need to clone elements so clone the element and do what we need to.
			// attach the old object key and children to it
			// *** for react-router set the to element
			c = React.cloneElement(component, {to: url, key:obj.key}, obj.props.children)
			// return the new element
			return c
		}
	}
	// return the old one if we didn't to anything
	return obj
}
// trying to be general but may need some tweaking.
// takes a string type
// takes a renderHTML element list
replaceType(type, list){
	// if the list is empty just return the list
	if(list.length == 0){
		// do nothing
		return list
	}
	// iterate through the list
	for (var i = list.length - 1; i >= 0; i--) {
		// for renderHTML we have two types string and object
		// for string we don't do anything it's just text or something else
		if(typeof list[i] == 'object'){
			// if it an object renderHTML has rendered a REACT element
			if(list[i].type == type){
				// if it's the type we are looking for
				// send it through the swap function
				list[i] = this.swap(list[i], <Link />)
			}
			// if this element has children then we need to repeat this on those children. recursive
			if(list[i].props.children != undefined && list[i].props.children.length > 0){
				// again we can't edit the props or children so just clone the element and call the replaceType on the children
				list[i] = React.cloneElement(list[i], list[i].props, this.replaceType(type, list[i].props.children))
			}
		}
	}

	// return the list changed
	return list
}`


Automated generation of build and documentation files

As we store build objects in the repo along with documentation and of course code, code reviews can get quite difficult when all of the auto-generated files get in the way. If we instead generated these objects post-review, it would mean that the review could focus on the code itself and not have to wade through other files.
Something like

pre-merge: npm run build && npm run doc

Isn't that exactly what https://github.com/resin-io-modules/resin-procbots/pull/123/commits/c6e171b0e01b29063dc0f46cb474f25b36ca9168 helps to mitigate?

Yeah, but we could have auto-generation and "hiding" for want of a better word bundled together, to reduce the manual tasks that must be done before merging a PR.

On Etcher, we similarly have some files that are autogenerated from others (SASS/CSS files, Docker templates, etc.), with both the source and autogenerated files being stored in the repo. A long time ago I asked @jviotti if it would make sense to only have the source files stored in the repo, with the autogenerated files only created at build / install time, and he replied that he preferred seeing the autogenerated files in the GH diff too, as it allowed him to double-check that the tools that created those files were always doing "the right thing".

Yeah, I don't really trust pre-processors, after some incidents from our CoffeeScript days, specially if we're not locking down the version of the transpiler.
I wonder if we can somehow get the best of both worlds: have ProcBots auto-generate the build files, but still provide a way for us to double check the result if we need to do so.

This is a recurring theme and so far the winning argument is the predictability one mentioned by @jviotti (and also @Page- in the past); for interpreted languages, we get to have git history of the exact reversion/codebase that runs in a production setting.
I couldn't agree more that having diffs of autogenerated files is really annoying, but imo suppressing them reduces the pain by a lot (to the point I don't matter having suppressed diffs around, which I can easily skip)

Personally I dislike committing built files on every PR because it makes rebasing and conflict resolution a nightmare, at the same time I don't mind either way for tagged/released versions as it does give that historical view without causing the same pain


Single host items contain the hostname in the legend

Hi, new version 4.1.1 did not fix the issue https://github.com/grafana/grafana-zabbix/issues/1335
I`m using Grafana v 9.5.5 and zabbix v 5.0

hi, the current version of the grafana zabbix plugin is 4.4.1.
based on the changelog at https://github.com/grafana/grafana-zabbix/blob/master/CHANGELOG.md,
the fix was first available in 4.4.0.
please try with the latest version, it should be fixed there.
(i'll close the issue for now, if the problem still persist, please write back and we can reopen the issue).


Pausing audio and video decoder

Occuring stream TCP timeout not handled yet

If you pause decoder, the stream will stop in some servers because you are not sending packets. So this isn't a general solution and I need check it.
About "stream TCP timeout", what do you mean?

Yes you are right, it is no TCP-timeout. Like you already said:

stream will stop in some servers because

The timeout occurs due to no packages received. Do you have an idea if it is possible to send some empty packages in this case? This could allow to keep the stream alive.

Do you have an idea if it is possible to send some empty packages in this case?

With audio this is easy. You can do something like this (send an empty buffer with same size of normal buffer):
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/blob/master/encoder/src/main/java/com/pedro/encoder/input/audio/MicrophoneManager.java#L177
But with video this is not easy because you need render a surface. I'm not sure if you can do it with video.

Mute in Audio decoder is already developed but in this case you need stop extract frames from MediaExtractor.


'watch' task not watching for new files

Gulp process has to be restarted every time a new file is added

thanks, this was bothering me for a while

:smile: yeah, me too


extend to 3d cluster of points

The actual use of this would come if it can handle large 3-d clusters of points and return the concave hull in fast computation

This is unfortunately out of scope for this library.


Add finalizers or implement SafeHandle

There are a few managed handles that, if leaked, result in a native leak:

sqlite3
sqlite3_backup
sqlite3_blob
sqlite3_stmt

Luckily, SQLite has it's own memory management so the consequences are never severe.
This could be further mitigated, however, by adding finializers (or implementing SafeHandle) to the classes. This would allow the .NET garbage collector to free any native handles as soon as the managed wrappers go out of scope.
You're original statement on the matter still stands, however: If an object implements IDisposable, you should always dispose it.

I recall previous discussions, where it was agreed that in hindsight these low level wrappers should not of implemented IDisposable, but that it was too late to make that change. Finalizer support IMO really belongs in a higher level library. For instance, SQLitePCL.pretty goes to extreme lengths to guarantee proper disposal and finalization of sqlite resources.

I need to take a fresh look at this issue.  If a change can be made without breaking anything, I would like to make it.  But I need to be certain.
The sqlite3 C API expects the caller to manually manage memory.  In keeping with its low-level philosophy, SQLitePCL.raw passes that expectation and responsibility upward to its caller.
So there are two ways to think of a possible change:
(1)  New philosophy:  Instead of the statement just above, try this:  "SQLitePCL.raw takes care of memory management such that its caller no longer needs to worry about it."
(2)  Safety net:  Keep the philosophy, but treat the symptoms.  SQLitePCL.raw still expects the caller to be responsible, but it has certain things (finalizers) to minimize the damage when the caller drops the ball.
Choice (1) has some appeal, but I'm not convinced that it should be done.  Every time I think of implementing (1), the first thing that comes to mind is that I would still want the lower layer to preserve the C API semantics.  So it seems like I would be changing SQLitePCL.raw to become something else, and then introducing a new even-lower-level layer to become what SQLitePCL.raw was before, etc...
In a more practical sense, I'm skeptical about whether (1) can be done reliably with just finalizers.  And SafeHandle would be a breaking change.
So any realistic change in the short term is probably choice (2).  But this choice makes me squirm a little bit as well.  Covering up (some of) the consequences of a developer's mistake usually just makes the mistake harder to find.
Maybe I'm seeing this as a bit more bleak than it needs to be.  Push-back or corrections are welcome.

I'm fine implementing finalizers in my library to free these too. I just wanted to discuss it since adding them here would be convenient to all consumers.

I agree we should go with option 2. My intention was only as a safety net. It also allow me to pass the buck along to consumers of my API: You must dispose IDisposable objects. But instead of every library having to add it's own safety net, there would already be one provided by SQLitePCL.raw.

My motivation here is that if I'm writing a library and doing everything right (using IDisposable responsibly), I shouldn't have to treat the managed sqlite3 objects as native resources and add my own finalizers to explicitly dispose them to implement best practices. sqlite3 (and friends) are managed objects, and I should be able to assume they already implement .NET best practices with regards to freeing up unmanaged resources.

That's a reasonable perspective.
But just to clarify (since I tend to let the details around finalizers and GC get swapped out of my brain's RAM onto a slow disk):  If the library is "doing everything right", what case requires finalizers?

Also:
We're going to have an issue with ordering of the finalizer calls, right?  The sqlite3 handle can't be cleaned up until its sqlite3_stmt handles are all done.

@ericsink SQLitePCL.pretty handles the finalizing/disposing sqlite3 instances with open sqlite3_stmt handles via event handlers. It works quite well, but results in a non-threadsafe api. This isn't an issue for SQLitePCL.pretty which offers threadsafe via an async scheduling API, but I imagine would be a non-starter for raw.

I'll express a preference for deprecating (in documentation) support for IDisposable (though leave the interface intact), and requiring the use raw.sqlite3_close() etc.
Afaik, most higher level libraries built on raw that I previously looked at manually close connections/stmts/etc. using the the actual sqlite apis and don't depend on dispose().

If the library is "doing everything right", what case requires finalizers?

If consumers of my library don't dispose my objects which own sqlite3 handles.

We're going to have an issue with ordering of the finalizer calls, right?

This is why sqlite3_close_v2 was added.

This is why sqlite3_close_v2 was added.

Darn.  I knew that.  But I forgot.  :-(

There was also a comment about it not being available on the iOS (or was it OSX) version. So ...things might be getting a little messy.

BTW, I'm deferring wholly to what you think is best here, @ericsink; I'm not pushing one way or the other. I just wanted to have the conversation one last time.

Looks like all iOS versions >= 8.2 contain a SQLite new enough for sqlite3_close_v2.  This issue is fading away.

I just wanted to have the conversation one last time.

No worries here.  I see this kind of conversation as an opportunity to (1) learn, and (2) find the best answer.  I appreciate you bringing it up again.

most higher level libraries built on raw that I previously looked at manually close connections/stmts/etc. using the the actual sqlite apis and don't depend on dispose().

Interesting. Given that SQLite will eventually clean these things up anyway, I think deprecating IDisposable is also reasonable albeit a little unorthodox for .NET.

Just to be clear, the IDisposable issue here is not related to the issue of whether there should be a finalizer or not, right?  You guys are just suggesting that these objects should perhaps not offer Dispose() as an alternate spelling for sqlite3_close (et al)?

Current thinking:  Use SafeHandle, and use the opportunity to make the jump to 2.0.  I've got other stuff that has been waiting for a compatibility-breaking change, such as removing support for Windows Phone 8.0.

I dig it. While I agree with @bordoley that libraries need to be very aware of these native wrappers and always dispose/close/finalize/free them (or expose a way of doing that) it is also good to take advantage of the garbage collector to free any that slip through the cracks sooner rather than waiting for SQLite to do it later.

FYI, in aspnet/Microsoft.Data.Sqlite#386 I've started using raw.sqlite3_close_v2() explicitly instead of sqlite3.Dispose(), and added finalizers to explicitly free these objects whenever my library's objects go undisposed.

Which answers a question I was going to ask you:  Are you okay with restricting to iOS 8.2 and above?  (Looks like yes.)

@bricelam Could you take a look at commit 8e52dad?  I haven't had to do finalizers in quite a while, so I did some remedial study on the topic.  I'd love to have another pair of eyes reviewing the code.  :-)  Thanks.

LGTM

Fixed in version 1.1.8, which has been pushed to nuget.org.


feature: numberPhone attribute - No model

Maybe we could have an attribute to insert an attribute without being a model.
Now I use Vuex and would like to put a computed property inside it.

v-bind:value It works well


App crashes on startup with latest engine roll

Starting with engine roll 31e5db7a5c9dd6511f9dde5488480c4365f641ce, I'm seeing the following error when trying to run any Flutter app:
Incompatible protocol version: client=3.26 vm=4.0
Failed to connect to the VM observatory service at: ws://<IP_ADDRESS>:59503/xXlS3fEI9Wk=/ws
java.io.IOException: Incompatible protocol version: client=3.26 vm=4.0

Duplicate of #65456


Add scoring system

The game needs some way to score players! Add points when players are under a significant amount of acceleration due to outside influence to give incentive to slingshot around the universe.

We will most likely end up doing something slightly different, but I'll leave this open so we can track progress on this general concept.

Relevant existing implementation is float Player::getSkill(SkillType) and void Player::addSkill(SkillType, float) which we can use to convert scores into an XP system.


Update dependencies

Ah, I accidentally closed this PR. I'll create a new PR if I have a time.

Ah, I accidentally closed this PR. I'll create a new PR if I have a time.


Adding meta tag for blog post

Description

I've added meta tag for blog post such that if user copy paste blog link, it should display an embedded preview

Note:

I've installed a package  svelte-meta-tags according to Svelte recommendation that help displaying the meta tag

Screenshots:

look like the DOMParser() caused the 500 error thar fail website check, will fix it tmr

Update

I just refactored. deleted DOMParser() and use existed query from Github instead

Note
I have to use string literals here since the allowed type is string | undefined form 'svelte-meta-tag' while the existing type of data.post.lastEdited is string | null
modifiedTime: `${data.post.lastEdited}`,

Screenshot


Fix building error

main currently don't build

Merging to unblock CI. Tested locally that it compiles.


Remove default prop usage from SimpleHeader.js

Not sure where I initially saw defaultProps usage in this component but don't see it anymore.


Register remote endpoint in TracingStatementInterceptor if cannot parse IP

Related issue: https://github.com/openzipkin/brave/issues/561
This change ports this fix https://github.com/openzipkin/brave/pull/700
to mysql connectors 6 and 8
As Endpoint can exist with ipv4 and ipv6 both equal to null it worth registering endpoint if connection.getHost() returns domain name instead of IP.

thanks for noticing and putting your hands towards this


Avoid sending SubDataset and use broadcast for datasets

In mpi4py objects sent with Comm.send() are always pickled every time;
Thus, whole dataset is pickled at sending to each of all rank > 0
nodes, as self._dataset is included in all SubDataset [1]. Thus in
scatter_dataset function has been inefficient that took >30 seconds
when distributing ImageNet 2012 dataset, even if it was just for file
names and tags, for example, which is optimized to finish in <5
seconds in our experimental environment.
This patch changes the repeat of Comm.send() to a combination of
Comm.bcast() of whole dataset and Comm.send() of range of each
scattered dataset. With this change number of picking whole dataset
has been reduced from N to 1, where N denotes number of MPI processes.
But this fix as a drawback in error handling, especially in case
OverflowError is raised by mpi4py. Rank 0 node may handle that error
because it knows the error, while other nodes may or may not know the
error and may wait for broadcast message for ever in busy loop. Those
behavior shall depend on MPI implementation, as it is not defined in
MPI specification 3.1 [2] afaik.
To solve the second issue dataset passed to scatter_dataset() is
forcible split into chunks whose default size is 256MB. This size is
configurable, but must not be larger than max value of signed integer.
And those chunks will be sent via a course of Comm.Bcast() instead of
single Comm.bcast(). Also, chainermn.datasets.DataSizeError is
emptied.
Note that any dataset passed to scatter_dataset() is forcibly pickled
into single buffer without any streaming, and the pickling and unpickling
may consume long time proportional to the size of the dataset.
[1] https://github.com/chainer/chainer/blob/v3.1.0/chainer/datasets/sub_dataset.py#L50
[2] http://mpi-forum.org/docs/mpi-3.1/mpi31-report.pdf
Note: this is a substitute and rebased version of #138.

Fixed, updated and all tests have passed!


5.2.1 Error in resultset when ordering and filtering

Hi,
I have the following table:
CREATE TABLE `exp_codes_bags_manhattan_codes_requests` (
  `request_id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `provider_id` int(10) unsigned NOT NULL,
  `name` char(20) NOT NULL,
  `status` enum('created','pending','completed','failed') NOT NULL DEFAULT 'created',
  `amount` int(10) unsigned NOT NULL,
  `error_code` int(10) unsigned DEFAULT NULL,
  `error_message` varchar(500) DEFAULT NULL,
  `created_at` int(10) unsigned NOT NULL,
  `modified_at` int(10) unsigned DEFAULT NULL,
  PRIMARY KEY (`request_id`),
  UNIQUE KEY `name` (`name`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

In the resultset, if using the GUI I order by request_id desc and then filter by status = 'pending', I get this error:

Query execution failed
Razón:
SQL Error [1054] [42S22]: (conn:6240180) Unknown column 'x.1' in 'order clause'
Query is : SELECT x.* FROM vams.exp_codes_bags_manhattan_codes_requests x
WHERE x.status = 'pending'
ORDER BY x.1 DESC,x.status DESC

This is the error detail:

SQL Error [1054] [42S22]: (conn:6240180) Unknown column 'x.1' in 'order clause'
Query is : SELECT x.* FROM vams.exp_codes_bags_manhattan_codes_requests x
WHERE x.status = 'pending'
ORDER BY x.1 DESC,x.status DESC
(conn:6240180) Unknown column 'x.1' in 'order clause'
Query is : SELECT x.* FROM vams.exp_codes_bags_manhattan_codes_requests x
WHERE x.status = 'pending'
ORDER BY x.1 DESC,x.status DESC
(conn:6240180) Unknown column 'x.1' in 'order clause'
Query is : SELECT x.* FROM vams.exp_codes_bags_manhattan_codes_requests x
WHERE x.status = 'pending'
ORDER BY x.1 DESC,x.status DESC
Unknown column 'x.1' in 'order clause'
Query is : SELECT x.* FROM vams.exp_codes_bags_manhattan_codes_requests x
WHERE x.status = 'pending'
ORDER BY x.1 DESC,x.status DESC
Unknown column 'x.1' in 'order clause'
Query is : SELECT x.* FROM vams.exp_codes_bags_manhattan_codes_requests x
WHERE x.status = 'pending'
ORDER BY x.1 DESC,x.status DESC

It works if I do it in the reverse order: first filtering, then ordering.

Thanks for the bug report.


More efficient catalog generation

Picks up from #49
Background
Currently, _get_one_catalog runs show tblproperties and describe extended on every single relation, one by one. As a result, dbt docs generate can take several minutes to run.
All the same information is available at a schema level by running show table extended in [schema] like '*', which dbt-spark knows as the LIST_RELATIONS_MACRO_NAME.
Challenge
The tricky part is the formatting: the result of show table extended... is structured, but strange:
Database: my_db
Table: view_model
Owner: root
Created Time: Wed Jan 29 01:58:46 UTC 2020
Last Access: Thu Jan 01 00:00:00 UTC 1970
Created By: Spark 2.4.4
Type: VIEW
View Text: select * from my_db.seed
View Default Database: default
View Query Output Columns: [id, first_name, last_name, email, gender, ip_address]
Table Properties: [transient_lastDdlTime=1580263126, view.query.out.col.3=email, view.query.out.col.0=id, view.query.out.numCols=6, view.query.out.col.4=gender, view.default.database=default, view.query.out.col.1=first_name, view.query.out.col.5=ip_address, view.query.out.col.2=last_name]
Serde Library: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
InputFormat: org.apache.hadoop.mapred.SequenceFileInputFormat
OutputFormat: org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat
Storage Properties: [serialization.format=1]
Schema: root
 |-- id: long (nullable = true)
 |-- first_name: string (nullable = true)
 |-- last_name: string (nullable = true)
 |-- email: string (nullable = true)
 |-- gender: string (nullable = true)
 |-- ip_address: string (nullable = true)

As @aaronsteers helpfully found, we could use this regex string to parse out all the info we need from the result above:
\|-- (.*): (.*) \(nullable = (.*)\b

This will require changes to _get_columns_for_catalog, and possibly to parse_describe_extended as well.
Alternatives

Open a PR against Apache Spark to add an information schema :)

Who will this benefit?
Faster docs generation for everybody!

This would also resolve the fact that Statistics are currently missing in docs for Delta tables. They're returned by describe detail instead of describe extended (docs, but regardless, they populate in the result of show table extended like '*'.

Adding to the discussion here, show table extended can be very costly depending on the account's Spark architecture.
The current instance I'm working with has a single schema for data_lake tables which has 1000+ tables; even with my dbt project using just 4 sources from this schema, the command pulls metadata from all tables.
A simple dbt docs takes 1 hour to run 😰

From what I understood, the challenge here would be to change dbt-spark's behavior to query describe extended {{ table }} instead of show table extended, is that right?

@felippecaso Ah no, just the reverse: We want to run just one show table extended in [schema] like '*' and use that to populate information about all catalog objects, rather than needing to run one describe extended for every object.
I don't know if there's anything we can do in the case where show table extended in [schema] like '*' takes an hour to run! It's pretty standard database behavior to ask for that kind of metadata. Is there anything obvious we're missing? Any chance this is faster with a bigger cluster?

Hey @jtcohen6,
There was indeed a leap of performance with my previous lack of understanding of how threading worked in dbt executions Haha.
Still, my point relates to the fact that show table extended in <schema> can process a lot more tables than it needed to. For instance, our database currently has those 1000+ tables in a single data_lake schema, and no more than 50 are currently being consumed in our dbt project.
Those 50 would be the number of tables that dbt needs to understand metadata from, but show table extended in <schema> pulls from all 1000+, spending unnecessary time to finish execution. Does it make sense?
As always, I may also be missing something =)

@felippecaso I don't think you're missing anything, and you've got a really good point. It's slow for dbt to run a separate describe table query for every single object it needs to know about (50 times in your case). It's also slow to run show table extended in <schema> like '*' against schemas with lots of objects in them (1000 objects, of which you only need 50). It's sort of a lose-lose.
For my part, on other databases / warehouses / query engines, dbt expects to be able to run metadata queries by limiting its scope to the database/schema of interest. It's pretty reasonable to expect that returning metadata queries on a schema with 1000 objects should actually be fairly quick... so I'm inclined to see this as a limitation of Apache Spark, more than anything.
Is this behavior we need to make configurable? Could we offer an optional/configurable wildcard, in case (e.g.) all the tables in your source schema share a common prefix/suffix? Are there other secret SparkSQL approaches I don't know about (yet)?


ImportError

Hi,
thanks for developing RNA-FM. I run the extract embedding step using python launch/predict.py , and it raised an Error:
ImportError: cannot import name 'make_data_loader' from 'data' .
Thanks.

Hi, sorry for the late reply.
This ImportError may be caused by your working directory. You should ensure you conduct the "python launch/predict.py" in "redevelop" folder. Then 'make_data_loader' can be found in the data module by the interpreter.


What happened to the original version??!!

I decided to see if there was a more updated version of this tool so I could avoid having errors or a rejected skill from Amazon, in case I decided to start using it again. I found this. I'm really confused, because it's nothing like the original at all. Will I still be able to use the original version? Or do I have to start all over again? I never had to use Twine or anything, and this seems like it would take a lot longer (and be much more complicated) than the original I've been working with before. What is the difficulty to set up, use, and get skills approved by Amazon compared to the original?
Thanks,
Camden

No idea, trying to figure out the same thing. This version's .git destination doesn't even exist!

I'm looking into this.  What would constitute the key aspects of the 'original  version'?  Did you want to just not use Twine to build the game?  Did you want to be able to convert from an earlier data file version to a current one?  Help me understand what would be helpful to get you to where you want to be, other than a rollback (which would also rollback other changes as well).

It would be nice to have the zip file to upload instead of having to guess
what should go into it since I can't find gamebook.zip anywhere.
On Tue, May 22, 2018 at 12:51 PM, franklin-lobb<EMAIL_ADDRESS>wrote:

I'm looking into this. What would constitute the key aspects of the
'original version'? Did you want to just not use Twine to build the game?
Did you want to be able to convert from an earlier data file version to a
current one? Help me understand what would be helpful to get you to where
you want to be, other than a rollback (which would also rollback other
changes as well).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/alexa/skill-sample-nodejs-adventure-game/issues/72#issuecomment-391118701,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOm99THeGq0yIB-hKd70FBYFxUf4KTZZks5t1Gw7gaJpZM4TcpuE
.

The issue is that I have so much saved already in the original version. I liked the interface a bit more. Unfortunately, my choose-your-own-adventure typed skill kept getting rejected from certification due to their own template's coding faults. I have been working on my story through InkleWriter. I was just about to suggest somehow making a way to connect with those stories, but I just found out that they are shutting down for good in August. :( I do have a copy of the json and html files generated from them. Any way for me to use those? I'd love to not have to start over with making my story. Again.

@agro23 The skill now deploys using the ask-cli, so you don't need to find the gamebook.zip if you use that (which is recommended).  Otherwise just zip up all of the contents of the lambda/custom folder (keeping that folder as the root) and upload that zip.

@talk2camden understood.  I will add investigating that to our backlog.

seems like amazon/alexa removed the original repo to make a commercial tool from it. This twinery thing is nothing like the ui or the tutorial/blogs that linked me here.


Context menu on offset

Description
The extra context menus on "More..." is offset up by one menu, only if I right-clicked a folder or a file near the bottom of the window. This might need some readjustments.
Steps To Reproduce

Open Files Explorer
Un-maximize and shrink the Window enough to a decent size
Find a file or a folder that is roughly 40% to 50% above the absolute bottom of the Window (A bit tricky to reproduce, might need to be exact)
Right-click it and hover on "More..."
Check the sub-context menu position

Expected behavior
Should be either lined up to the "More..." menu and not on offset, since it's really tricky to hover my cursor on the sub-menus
Files Version
v<IP_ADDRESS>
Windows Version
Windows 10 Pro 21H1 - build 19043.1165
Relevant Assets

Thanks for the report. Afraid this is not something we can fix ourself as looks like a WinUI issue.

Haven't tested it on Windows 11, see if that's fixed later on when they launched it.


Unable to extract uploader ID

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar bug reports including closed ones
[ ] I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.youtube.com/watch?v=XEFs_I4GsE0', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg 2023-02-02-git-7d49fef8b4-essentials_build-www.gyan.dev, ffprobe 2023-02-02-git-7d49fef8b4-essentials_build-www.gyan.dev
[debug] Proxy map: {}
[youtube] XEFs_I4GsE0: Downloading webpage
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line 815, in wrapper
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line 836, in __extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\common.py", line 534, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\youtube.py", line 1794, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\common.py", line 1012, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

WRITE DESCRIPTION HERE

#30839
The point of the check-boxes is to prompt you to do the things listed. If you don't, why would you expect any help?

#30839
The point of the check-boxes is to prompt you to do the things listed. If you don't, why would you expect any help?

yeah i don't really know how to use github, but i did all of those


Fix proc resource embedding issue with search_path and refactor return type

I created a new db, role with login, tables clients, projects and proc getproject(id int) returns setof projects, all defined just as in fixtures/schema.sql.
I tested the proc embedding feature with POST rpc/getproject?select=id,name,clients{id,name} and the relation was not found.
This happened because the tables were created in thepublic schema and by default the role has that schema in his search_path and the detection of the return type only works if the schema is qualified.
This test already fails when adding the ALTER ROLE postgrest_test_authenticator set search_path = 'public', 'test';, that's why I didn't thought of adding a new one.

Overall this is a good quick fix, the only thing needed here is to add a few tests (a few different procs with different return types) and check that the relation detection on them works.
As a mid term goal i think there is too much logic in haskell for parsing the return types.
The reflection query should provide a description of the proc in a more reliable way without needing to parse strings.
Here is a query that can be built upon
with compound_types as (
        select t.oid as ooid, attname as att_name, a.oid::regtype as att_type
        from pg_type t
        join pg_class on (reltype = t.oid)
        join pg_attribute on (attrelid = pg_class.oid)
        join pg_type a on (atttypid = a.oid)
    )
    select
        n.nspname as "schema_name",
        p.proname as "procedure_name",
        (SELECT array_to_json(array_agg(cast(n as regtype))) FROM unnest(p.proargtypes) AS n) as "arg_types",
        (SELECT array_to_json(array_agg(cast(n as regtype))) FROM unnest(p.proallargtypes) AS n) as "all_arg_types",
        array_to_json(p.proargnames) as "arg_names",
        array_to_json(p.proargmodes) as "arg_modes",
        p.prorettype::regtype as "return_type",
        (
            select array_to_json(array_agg(row_to_json(ttt)))
            from
            (
                select c.att_name, c.att_type
                from compound_types as c
                where c.ooid = p.prorettype
            ) ttt
        ) as return_type_components,
        d.description as "description",
        case
            when p.provolatile = 'i' then false
            when p.provolatile = 's' then false
        else true
        end as "is_mutation",
        p.proisstrict as "is_strict",
        p.proretset as "returns_set"

    from pg_proc as p
    left join pg_namespace as n on n.oid = p.pronamespace
    left join pg_description as d on d.objoid = p.oid and d.objsubid = 0
    where p.proisagg = false -- no aggregate functions
        and p.proiswindow = false -- no windows functions
        and n.nspname not in ('pg_catalog', 'information_schema')

Nice! looks good to me

(please open an issue in relation to the search path bug in relation to tests and how it's tied to the authenticator role, wee need to clean that up)

The only thing missing are tests. Here is what i think should be tested
If you don't have time for all these tests, maybe add the 2-3 that you think are the most important and i think it's good to merge

return a scalar
return a "row" with two scalars
return a custom type (similar to row, just a few scalars, but this time the type is defined) and the custom type is defined in the exposed schema
return a custom type, the custom type is defined in a hidden schema
tables that are exposed in the api schema

return a single row from a table (relations  should work as long as the related table is also exposed)
return multiple rows from a table (relations should work as long as the related table is also exposed)
return a row from a table that has relations to an unexposed table, relations should not work

the function should return rows from a hidden table (that has relations) but that table and the related tables are exposed as views, this case should transparently work just as if the tables themselves are exposed

Thanks for the hints @ruslantalpa, I already included the tests.

awesome work!

Thanks @steve-chavez, I'll look this over tomorrow but guessing it'll be good given the adjustments you guys have already done.

Look into the readRequest argument type and see if my suggestion makes sense. After we decide what to do there then this is good to merge!


feat: added dynamic contributors section

Closes: #470

Great @Viveksati5143! Your PR got merged!
Keep contributing like this in GSSOC'23. 🚀


Remove author tags in engine (game-logic)

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/328/
Hooray Jenkins reported success with all tests good!


Look at sort order of voucher IDs

The client-side sorting of vouchers seems to have an oddity when handling the voucher ID column. For example, see the business 'Crave' (ID<PHONE_NUMBER>552).
Nik advised that the sort order only works well for strings, so potentially this requires replacing the Angular Material sorting component?

Hi @johndowns could you please identify the oddity?
Ascending should be: Special Characters > [0-9] > [A-Z]

Descending should be: [Z-A] > [9-0] > Special Characters

Seems to be working fine for me, am I missing something?

Hi @johndowns I've figured out what the oddity is.

There are some voucher IDs which are all numbers. These are the ids which are displaying the oddity of not being sorted. If I suffix a string (in the above picture, I have suffixed "-"), these ids are sortable again.
My recommendation is, do not replace the paginator (it would take too much effort for too little value addition). Instead, force voucher ids, or any ids to have atleast one alphabetic character. I've pushed a branch "sortable-oddity" which shows the logic in vendor-vouchers.components.ts:56

@johndowns what do you think about this?

@blckqdrnt sorry for the delay! As it happens we have revised the way vouchers are imported, and in the process I have made a change to ensure that we always use alphanumeric voucher IDs. So I think this should take care of the issue based on your investigation. I will leave the issue open until I confirm once we deploy the change though.

Cool. Let me know if there's anything else I can help with


New expr syntax

Replaces limited, django-like "filter" style syntax with more Pythonic syntax.

Coverage remained the same at ?% when pulling c43b84eb36a8dff2bc17c87093bfd4ad3005b0af on new-expr-syntax into df534701f55f344b9d1d66b0d0ad480773cff45e on master.

Coverage remained the same at ?% when pulling c43b84eb36a8dff2bc17c87093bfd4ad3005b0af on new-expr-syntax into df534701f55f344b9d1d66b0d0ad480773cff45e on master.


Docs/create injectable es translation

create injectable spanish translation

Thank you for your contribution. Can you remove the package-lock.json since we're not using npm

Done! :)

After this PR, my intention is translate every pending page and, if you need to review some of them, as I said, I am a native Spanish speaker. ;) @nartc @eneajaho

Is there any pending thing to be changed, from my side?

I supose is not a good pr, waiting for a long time...

Hello @sergidt
Sorry for taking this long 🙏
I removed the package-lock.json and I'm merging this now.

Ok, no worries, if you want I will proceed to translate others. Thanks @eneajaho


Create CONTRIBUTING.md

Some typo's!

If you find a typo in a document, a bug in the code or want too suggest an improvement

If you find a typo in a document, a bug in the code or want to suggest an improvement

After finishing yor wwork, commit your changes.

After finishing your work, commit your changes.

Push the commits the the local repository.

Push the commits to the local repository.

Phrasing

Clone your fork the your local repository.

Not sure of the correct phrasing here.....


Travis build on Node 0.12 fails (timeout)

builds get stuck on the karma test
Running "karma:ci" (karma) task
No SAUCE credentials found (missing SAUCE_USERNAME and SAUCE_ACCESS_KEY env variables). Skipping SauceLabs testing.
08 06 2016 10:15:36.446:WARN [karma]: No captured browser, open http://localhost:9876/
08 06 2016 10:15:36.453:INFO [karma]: Karma v0.13.22 server started at http://localhost:9876/

Failed builds:
https://travis-ci.org/yahoo/xss-filters/jobs/79610450
https://travis-ci.org/yahoo/xss-filters/jobs/131198435
@adon-at-work

As far as I can remember, the default setting would skip setting the SAUCE_USERNAME AND SAUCE_ACCESS_KEY env variables for commits from non-authors. That explains why 131198435 was failed. 79610450 worked. Can you confirm if I'm right?

Further to the timeout problem in 79610450, it reported "Android on SauceLabs failed 2 times (timeout)"
It's known to me that Android on SauceLabs are not so reliable, i.e., sometimes not starting, and thus often require another attempt.
I probably should restart the build, but didn't bother as that particular commit has changed only the README.

looks good now - https://travis-ci.org/yahoo/xss-filters, closing

thank you @dmitris :)


Externalize settings.php via config map

Technically we are already externalizing this via persistent volumes... so may not need this?

Agree.