patch 2

added code cov

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e1ace8b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   94.92%
=========================================
  Files             ?        5
  Lines             ?      315
  Branches          ?        0
=========================================
  Hits              ?      299
  Misses            ?       16
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ace8b...11a7673. Read the comment docs.


Support for Objective-C and Objective-C++

Objective-C = .m
Objective-C++ .mm
Both use:
Single line: //
Block: /* */

thx!


Replace copy configuration with automatic copying via Webpack

As mentioned in #33, the current way how copying assets (fonts, images) work is by manually configuring paths for a copy task. This works a bit against the concept of Webpack, which should automatically resolve dependencies and then copy them.
I can provide these changes via a pull request, as I already updated this behavior in my projects which are using patternlab-edition-node-webpack. So it's tested in multiple production projects.

Very interested in this. I'm happy to assist if I can somehow take work off your shoulders here.

I'm also very interested in the result!


Hint position even more advanced

Hi,
I think it would be great and complete to position the hint as follows:

This below will fix the bottom-right tip

[class*="hint-bottom-right"]:after {
  right: 0;
  left: auto;
  -webkit-transform: translateX(0);
  -ms-transform: translateX(0);
  transform: translateX(0);
}

[class*="hint-bottom-right"]:before {
  right: 0;
  margin-right: 5px;
}```

Did you check if it broke the animations/transitions? I don't really have time to update it with new positions, but if you put in a pull request I'll definitely look at it.

Feature added in https://github.com/catc/simple-hint/releases/tag/3.0.0. Closing.


Updated maintenance windows main descritption

We need to get this content updated before end of day today 3/13

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/Microsoft/azure-docs/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Microsoft/azure-docs-pr/blob/master/articles/azure-portal-overview.md
We have closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions


GPUImage framework leaks memory.

The filters shown below worked fine on IOS 7. However, once they were modified for  IOS 8 , memory. leak has become an issue. The memory keeps going up until the app crashes. Even if only one filter is used ( for example the median filter) it leaks memory. Is there anything wrong with the code or have I missed some requirement for the new version. By the way the results from the filters are fine, memory is the issue.
#pragma mark -
#pragma mark filter and process image .. form all sources
// Image to process
GPUImagePicture *GPUstillImageSource = [[GPUImagePicture alloc] initWithImage:self.image];
    // first thing .. reduce noise: use median and unsharpenmask filters for this.
  GPUImageMedianFilter *medianFilter = [[GPUImageMedianFilter alloc] init];

  GPUImageUnsharpMaskFilter *unsharpMask =[[GPUImageUnsharpMaskFilter alloc] init];
  unsharpMask.intensity = 12.5;
  unsharpMask.blurRadiusInPixels = 3.0
    // chain the median and unsharpen mask filters.

 GPUImageSobelEdgeDetectionFilter *sobelVignetteEdgeDetection = [[GPUImageSobelEdgeDetectionFilter alloc] init];
 sobelVignetteEdgeDetection.edgeStrength = .14;

    // get edge image for vignette detection.
 self.vignetteFilteredImage = [sobelVignetteEdgeDetection imageByFilteringImage:self.filteredImage];

    // sharpen the vignette edge detection filter..
 GPUImageSharpenFilter *sharpenFilter = [[GPUImageSharpenFilter alloc] init];
 sharpenFilter.sharpness = .9;
 self.vignetteFilteredImage = [sharpenFilter imageByFilteringImage:self.vignetteFilteredImage];

    // run edge filter for perforation detection .. will not need to sharpen this one.
 GPUImageSobelEdgeDetectionFilter *sobelPerfEdgeDetection = [[GPUImageSobelEdgeDetectionFilter alloc] init];
 sobelPerfEdgeDetection.edgeStrength = .23;
 self.perfFilteredImage= [sobelPerfEdgeDetection imageByFilteringImage:self.filteredImage];

Where did you put this line of code? In the filter files themselves?


add 4257050-ZHAC Centralite plug

added 4257050-ZHAC to devices.js so it is recognized.  It appears to operate just the same as 4257050-RHAC. I'm a git newbie, I hope I did this right...

Thanks!


Printing the PDF

i think we could use this.
https://github.com/DavBfr/dart_pdf/tree/master/printing
It is NOT driven from HTML, but i think i make it work.
Is this something others want too ?

My main idea when I started working html_to_pdf plugin was to bring the ease of creating dynamic documents into Flutter. I was trying to use dart_pdf plugin but for the tables it requires more complicated code than HTML.

@joeblew99 where you able to print using the printing library you mentioned. If so would you care to show how you implemented it?

@premy i never got time to try.
Instead i decided to use the PDF to Printing Plugin. You have to write builders for each widget to output as PDF.
I used HTML to Flutter Widgets so i can drive the system from just HTML.

@joeblew99 thanks for your answer mate. Do you mean these packages:
dart pdf: https://pub.dartlang.org/packages/pdf
flutter printing: https://pub.dartlang.org/packages/printing
???
I checked them out but didn't find an example on how to "to write builders for each widget to output as PDF." Could you maybe share some code?

@premy
Look here: https://github.com/DavBfr/dart_pdf/blob/master/pdf/example/main.dart#L9
As you can see they are outputting PDF for a Page, but there is no reason you cant do that at a Widget level too right.
So then all you really want to to do is when you make a Flutter widget add add a BuildPDF() function also.

@joeblew99 Okay, in previous comment I was talking about the much earlier concept of this plugin when you had to set (x,y) coordinates to draw elements on the PDF page. Now this rendering looks much easier and it's looks like good alternative to HTML rendering.

@Afur actually i think your HTML to PDF is the right way to go these days.
I use HTML to describe all Flutter page and widgets. These are just converted at runtime to flutter widgets.
SO for the PDF i can use the same HTML and then convert to PDF.
SO i get a nice clean architecture.
For doing html to PDF everyone uses the wkhtmltopdf lib.
For golang wrapper you can use this: https://github.com/SebastiaanKlippert/go-wkhtmltopdf
SO i just do the PDF output Server side and return it to the Flutter client.
The HTML came from the HTML on the server anyway.
This might seem like cheating but i just got sick of dealing with all the printing and PDF issues with flutter.
I used to think that  https://github.com/DavBfr/dart_pdf is better but i found that its WAY too much work..

@Afur I use your package to create a pdf from html, and it works just fine, cause I can see it displayed with the aid of flutter_full_pdf_viewer. Now I would like to be able to simply grab generatedPdfFilePath and send it to the native printer app. Could you pls point me into the right direction?

@premy I believe that you can use this plugin https://pub.dev/packages/printing since you have direct path to PDF document. However I've never had to use printing functionality inside flutter apps so I'm not 100% sure whether that plugin will be enough or not.


Unable to update the x ticks dynamically in a line chart

C3 version: "0.4.18"
D3 version: 3.5.6
Browser: Version 61.0.3163.100 (Official Build) (64-bit) (Google Chrome)
OS: The operating system. (Windows 10)
Hi,
I am trying to update the x-axis ticks dynamically  as I will be getting them in an ajax calls.
Just for clarification
In one instance I will get x-axis tick values as ['2013-01-01', '2013-01-02', ......]
And after some interval I will get as ['2013-02-02', '2013-03-04',.....]
Hence I need to update the x-ticks dynamically
I am trying the same scenario in  http://c3js.org/samples/timeseries.html inside a setTimeOut function.
However I am not able to understand the way to proceed.
Please let me know if you need more information from my side

I am also interested in this.  I have a chart and when it is on a small width I show only 5 tick values on the x axis. I would like when enlarged to fullscreen to display 15 tick values instead of 5. Any ideas?

chart_name.internal.config.axis_x_tick_values=['08/01/2017'];
chart_name.flush();
Worked for me right now.


Allow the server to send an error (don’t always set the error length …

…to zero)
Parse properly the reason string on the receiver of the error

Current coverage is 71.77% (diff: 0.00%)

No coverage report found for master at 22d8bf9.

Powered by Codecov. Last update 22d8bf9...d57c02f


Cherry-pick ALPN patch into v1.19.x.

The original fix is #18563.

@nicolasnoble This is the same fix as #18563. I refactored the code by moving the ALPN check in ssl_security_connector.cc to ssl_utils.cc, which is needed for unit tests. Since we already defined TSI_OPENSSL_ALPN_SUPPORT in ssl_utils.cc, ALPN check will be always enabled in ssl_utils.cc unless a user explicitly disables it (I manually verified its correctness).

Friendly ping @nicolasnoble. Jiangtao is OOO this week.

@yihuazhang don't hesitate to ping me on IM directly for these.


Fixed compilation on macOS Sierra

Added flags to binding.gyp for Clang to find the correct C++ library.

Hrmm, adding '-stdlib=libc++' is mac specific and errors on linux
><EMAIL_ADDRESS>install /home/jroback/Github/atom-clang
> node-gyp rebuild

make: Entering directory '/home/jroback/Github/atom-clang/build'
  CXX(target) Release/obj.target/clang/src/clang_translationunit.o
clang.target.mk:122: recipe for target 'Release/obj.target/clang/src/clang_translationunit.o' failed
make: Leaving directory '/home/jroback/Github/atom-clang/build'

g++: error: unrecognized command line option ‘-stdlib=libc++’
make: *** [Release/obj.target/clang/src/clang_translationunit.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/share/atom/resources/app/apm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Linux 4.4.0-53-generic
gyp ERR! command "/usr/share/atom/resources/app/apm/bin/node" "/usr/share/atom/resources/app/apm/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /home/jroback/Github/atom-clang
gyp ERR! node -v v4.4.5
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok

npm ERR! Linux 4.4.0-53-generic
npm ERR! argv "/usr/share/atom/resources/app/apm/bin/node" "/usr/share/atom/resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/home/jroback/.atom/.apm/.apmrc" "--userconfig" "/home/jroback/.atom/.apmrc" "install" "--runtime=electron" "--target=1.3.13" "--arch=x64"
npm ERR! node v4.4.5
npm ERR! npm  v3.10.5
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the atom-clang package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs atom-clang
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls atom-clang
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/jroback/Github/atom-clang/npm-debug.log

Ah OK, there seems to be conditions available for the binding.gyp file to configure properly for different OSs, I'll have a look

In addition, using clang-3.9 on macOS it also results in error, as that seems to be an option specific to only Apple's LLVM/CLANG...
><EMAIL_ADDRESS>install /Users/jroback/Dropbox/Projects/Github/atom-clang
> node-gyp rebuild

  CXX(target) Release/obj.target/clang/src/clang_translationunit.o

c++: error: unrecognized command line option '-stdlib=libc++'
make: *** [Release/obj.target/clang/src/clang_translationunit.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Applications/Atom.app/Contents/Resources/app/apm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 16.1.0
gyp ERR! command "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /Users/jroback/Dropbox/Projects/Github/atom-clang
gyp ERR! node -v v4.4.5
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok

npm ERR! Darwin 16.1.0
npm ERR! argv "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/jroback/.atom/.apm/.apmrc" "--userconfig" "/Users/jroback/.atom/.apmrc" "install" "--runtime=electron" "--target=1.3.13" "--arch=x64"
npm ERR! node v4.4.5
npm ERR! npm  v3.10.5
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the atom-clang package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs atom-clang
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls atom-clang
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/jroback/Dropbox/Projects/Github/atom-clang/npm-debug.log

I'll have to think about how to handle this.

Fair enough, I added the conditions there and it still works building on my Mac so maybe that would be worth using in some form.

yea this totally helps figure out your mac compile issue,  I just have to make sure not to break the other platforms/compilers :)

damn this is where binding.gyp really shows how much it sucks as a reinvention of the wheel.. why doesn't npm just not use CMake? binding.gyp is not smart enough to know that its using the Apple compiler, which needs -stdlib=libc++ for C++11, but if you are using G++ and CLANG (not Apple's), they both do not. CMake can handle this situation.
If Apple's clang included the libclang headers, we wouldn't even need to install clang, but it doesn't, it only includes libclang.dylib, not the headers required to build.
So I am inclined at this point to not do anything, as most people using this package are using GCC or CLANG (not Apple's compiler), until binding.gyp gets smarter and is able to tell which compiler it is using. Otherwise, if I add this flag, Apple's compiler will work, but GCC/CLANG will fail. Catch 22.
Argh!

fixed in https://github.com/joeroback/atom-clang/pull/18


bind doorkeeper error response into WineBouncer errors

Add message of exception back - leverage doorkeeper error response's description.
Also updated UPGRADING and CHANGELOG.

Great! Merging :+1:


socket.io connecting to wrong port

Tried setting up a demo conference using the tutorial given but I'm running into issue where as I'm running the server on one port (9000) and the front-end on another (8080), the request to socket.io is going to the wrong port (this case http://localhost:8080/socket.io/1/ where it should his http://localhost:9000/socket.io/1/).
Reporting it here as I'm not sure who is responsible for checking the port number, easyrtc or socket.io, but as this is the first port-of-call as it where I thought I'll try here.
Thanks.

Handled. See https://easyrtc.com/docs/guides/easyrtc_with_other_servers.php


what is cor?

https://github.com/chime-sps/FDMT/blob/c5117f065dc16bacb1ba8078e0126504156ae7dc/fdmt/cpu_fdmt.py#L182-L185
this is the only place in the code that I can find cor, and with cor = 0 C01 and C12 are exactly the same as C
I think we should either find out what cor is supposed to do and what would be a decent value for it, or remove it and refactor C01 and C12 to C

also based on the name it was probably supposed to be
 C01 = ((f1 - cor) ** -2 - f0**-2) / (f2**-2 - f0**-2)
 C12 = ((f2 + cor) ** -2 - f1**-2) / (f2**-2 - f0**-2)
``

I'm not sure on the details, but I think intuitively cor represents the degree of correction that needs to be done when the dispersion curve is jumps across time-sample boundary as it crosses a subband boundary. I think, looking at other implementations, cor = df / 2.0 if i > 1 else 0 is typical, but "it is beneficial to play with this correction" according to a comment.
I think C01 and C02 are correct as written. C01 is used to determine the total delay in one subband, while C02 is used to find the total delay in the other subband (by first finding the total delay from the bottom of subband A to the bottom of the other subband B, which is not the same as the top of subband A when cor != 0).


Support for CHARACTER LARGE OBJECT[(p)] and CHAR LARGE OBJECT[(p)]

Adding support for CHARACTER LARGE OBJET[(p)] and CHAR LARGE OBJECT[(p)], both defined on ANSI (1).
Add tests for both and CLOB[(p)].

(1) : https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#character-large-object-type

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

17 of 17 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 85.841%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
10537

Relevant Lines:
12275

💛  - Coveralls


Added "Blank Strings" extensions

isBlank  - to check if string is null, empty or contains only whitespaces;
isNotBlank -  to check if string is not null, empty or contains only whitespaces;
ifBlank - Return the current string if not blank. Otherwise return other string;
asIf -  compares a string using a function and returns  first string if true, otherwise return second string;

Hello there and thanks for the contribution. Would you mind adding some tests for those methods ?

Sure, ill add the tests late today


Bluetooth only connects to one Operating System on dual-boot systems

I have dual boot systems with Windows and Ubuntu GNU/Linux.  The keyboard using bluetooth will only connect to one operating system on an individual PC.  It won't connect to both.  My Logitech MX Anywhere mouse though does connect to both systems.  I am only using one Operating System at a time, of course.  I am using the multiple device connections feature of the keyboard.  Other than this it works well!  Thanks!

see here: https://github.com/zmkfirmware/zmk/issues/1503

As the other issue mentions this is because ZMK is strict with bluetooth security and doesn't allow different keys for the same physical device. There's a workaround for the time being. I do not plan on changing the bluetooth security behaviour until the recquisite changes are implemented in ZMK main


Add Note & Warning Blockquote Syntax

Is your feature request related to a problem? Please describe.
I noticed that the Note & Warning blockquote syntax isn't in the markdown cheatsheet. Hence, I wish to add the relevant syntax to the repository.
Describe the solution you'd like
I will raise a PR containing the syntax for generating Note & Warning blockquotes in GitHub markdown.
Additional context
Submitting this PR as part of Hacktoberfest 2022 🎉

@atapas Hey Tapas, its me Melvin again. Noticed the above issue, while scanning for enhancements & improvements to the existing markdown cheatsheet.
If you would like me to work on it, please kindly assign me this issue & label it with 'hacktoberfest', after which I would proceed to submit a PR with your kind permission :).
Thanks!


DependaBot PRs do not respect project's .gitattributes file

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
Maven
Package manager version
Irrelevant to this use case
Language version
Irrelevant to this use case
Manifest location and content before the Dependabot update
No response
dependabot.yml content
https://github.com/Alfresco/acs-packaging/blob/master/.github/dependabot.yml
Updated dependency
Irrelevant to this use case
What you expected to see, versus what you actually saw
DependaBot PRs should respect .gitattributes files located within the repository they're making changes against. In this case, it should have taken https://github.com/Alfresco/acs-packaging/blob/master/.gitattributes#L6 into consideration, rather than rewriting all line endings without respecting the .gitattributes file rules.
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
https://github.com/Alfresco/acs-packaging/pull/2869/files
Smallest manifest that reproduces the issue
No response

Other relevant issues that could be automatically fixed if DependaBot supported .gitattributes specifications: https://github.com/dependabot/dependabot-core/issues/8642 & https://github.com/dependabot/dependabot-core/issues/8693


[BUG]: Image is copied by sliding the screen

https://github.com/user-attachments/assets/953ad319-a074-42e8-90b2-4838b5f9afc2

The image should only be copied when I press the screen for a few seconds, not when I swipe. 🤔

Hey!
This doesn't happen on my device, so I need more info:

What OS and OS version are you on?
Are you on the latest Obsidian and plugin version?
This is reading view, right?
Is this a local or an external, online image?
Could you try it in another vault with no other plugins installed?

I'm on Android 14.
Yes, I'm in the last version.
Yes! Reading view.
It's a internal image.
I tried with another test. A clean vault with only the plugin installed.

It's very weird... It only happens when I slide along the side of the image. Sometimes it happens and sometimes it doesn't.
Maybe it happens when I slide my finger too close to the image?
https://github.com/user-attachments/assets/7897e112-0143-4c7a-86e5-21a254dfaff1
https://github.com/user-attachments/assets/a5ac43a1-300c-4d28-badc-d249de3804e4

Thanks for the details!
Unfortunately I won't have the time to work on this plugin soon, but I'll get there eventually (and I encourage others to do so).


[core] Added calculateRetryDelay helper

Packages impacted by this PR
@azure/core-util
Issues associated with this PR
Contributes to #30187
Describe the problem that is addressed by this PR
Ports over the logic from @azure/core-rest-pipeline's exponentialRetryStrategy
to a helper function that can be used by client libraries.
This code was duplicated in @azure/identity and a partner team attempted to add
exponential-backoff as a dependency to add support for this logic.
A helper function can be used to calculate the next interval, leaving the
business logic / deciding what to do next to the specific usecase
Provide a list of related PRs (if any)
https://github.com/Azure/azure-sdk-for-js/pull/30172#discussion_r1655215478
Checklists

[x] Added impacted package name to the issue description.
[x] Does this PR need any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here.)
[x] Added a changelog (if necessary).

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure/core-util

Usages:
https://github.com/maorleger/azure-sdk-for-js/blob/bb555ae72da4940b5170914a8f13fc20b35e99c2/sdk/identity/identity/src/credentials/managedIdentityCredential/imdsRetryPolicy.ts#L31-L44
https://github.com/maorleger/azure-sdk-for-js/blob/bb555ae72da4940b5170914a8f13fc20b35e99c2/sdk/core/core-rest-pipeline/src/retryStrategies/exponentialRetryStrategy.ts#L69-L76

oh also don't forget unbranded core :B


Generate serializers dynamically

We are going to want the ability to specify some serializers explicitly.  Ideally, we'd only create serializers for models that don't already have them.  This could probably be something like:
for _model_name, model in inspect.getmembers(models):
      if not inspect.isclass(model):
          continue
      parent = model
      while len(parent.__bases__):
          if base_models.Model in parent.__bases__:
              break
          parent = parent.__bases__[0]
      if base_models.Model in parent.__bases__:
          model_fields = {}
          serializer_name, serializer_class = create_serializer(model, model_fields)
          if serializer_name not in globals():
              globals()[serializer_name] = serializer_class

in geodata/serializers.py and core/serializers.py.  This could be placed in a utility function, where those serializer files would call make_serializers(globals(), models) or something similar.

I merged a branch to master that will cause minor conflicts with this one.  Please merge master and resolve those conflicts.  Otherwise, with the variable name change and added comment, this looks good.


[ISSUE #4687] enhance RewritePlugin

Fixes #4687

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #4907 (cdbce6a) into master (e3cf9ed) will decrease coverage by 0.16%.
Report is 1 commits behind head on master.
The diff coverage is 63.63%.

:exclamation: Current head cdbce6a differs from pull request most recent head f8a714e. Consider uploading reports for the commit f8a714e to get more accurate results

@@             Coverage Diff              @@
##             master    #4907      +/-   ##
============================================
- Coverage     64.04%   63.89%   -0.16%
+ Complexity     8312     8305       -7
============================================
  Files          1180     1180
  Lines         34865    34858       -7
  Branches       3115     3113       -2
============================================
- Hits          22328    22271      -57
- Misses        10763    10805      +42
- Partials       1774     1782       +8

Files Changed
Coverage Δ

...a/org/apache/shenyu/admin/model/dto/PluginDTO.java
62.16% <ø> (ø)

...u/plugin/logging/common/AbstractLoggingPlugin.java
0.00% <0.00%> (ø)

.../shenyu/common/dto/convert/rule/RewriteHandle.java
47.36% <16.66%> (-12.64%)
:arrow_down:

...rg/apache/shenyu/plugin/rewrite/RewritePlugin.java
68.42% <66.66%> (-3.81%)
:arrow_down:

...ava/org/apache/shenyu/common/enums/PluginEnum.java
100.00% <100.00%> (ø)

...pache/shenyu/plugin/base/AbstractShenyuPlugin.java
57.81% <100.00%> (ø)

...u/plugin/base/condition/data/URIParameterData.java
100.00% <100.00%> (ø)

...nyu/plugin/global/DefaultShenyuContextBuilder.java
79.16% <100.00%> (ø)

...in/logging/common/utils/LogCollectConfigUtils.java
73.80% <100.00%> (ø)

...rg/apache/shenyu/plugin/metrics/MetricsPlugin.java
47.82% <100.00%> (ø)

... and 20 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

pending

ISSUE #4923 , I have a suggestion to adjust the execution order of the plugins.
This change will increase the priority of the rewrite plugin, which may cause external users' URLs to bypass the authentication plugin.

maybe next version?


Remaining responsiveness issues

General:

When the browser is narrow enough that the primary nav bar has a hamburger, there is slightly different spacing between the remaining nav items than there was without a hamburger. [Rob says: I've pretty much fixed that with my recent changes]
When the browser is narrow enough that the primary nav bar has a hamburger, click on the hamburger, then Help. The (?) icon next to Help will not have any margin to its left.

Search:

As the browser narrows and the left pane starts to shrink, the horizontal lines under each category run into the vertical divider instead of maintaining some kind of margin. They also run under the PS.
In the widgets, the vertical divider on the right and the > and X end up in a weird place if the widget shrinks such that they can't fit on the same line as the widget title. I think they should always stay in the top right, and only the test should wrap.
When the browser is narrow, the "Reset Search" button is pressed up against the left edge of the browser even though there is space to the right of "Reset Search and Metadata" that could be used to center the two buttons.
When the browser is narrow, the green hinting "min: X max: X nulls: x" break across multiple lines, but the value doesn't stay with the label. It would be nice to keep "min: X" etc together as a unit for reflow.

Browse:

Make the slider fill the available space when the browser is wide.
The "Save Changes" and "Discard Changes" buttons in the Metadata Selector should have a little space between them.
The metadata selector has way too much white space between the left pane search terms and the left pane scroll bar when the browser is narrow.

Cart:

When the browser hits 700px width, the font size of the secondary nav bar changes slightly

When the primary nav bar has a hamburger and you open the hamburger and then open the help menu, the whole nav bar gets really tall instead of the menu dropping below the nav as it normally would.

When the browser is really narrow and you bring up a help menu pane, the PS is no longer attached to the right edge and there is a lot of whitespace to the right of the PS.


Added two papers from EMNLP

Thanks for your pull request! However, this repo aims to collect those papers based on the realistic environment, e.g., Matterport3D. Thanks again!


Sandmark Perfstat Output is broken at the moment

The landing page at https://sandmark.ocamllabs.io/ > Perfstat Output shows the following error.
KeyError: 'alt-ergo.yyll.why'
Traceback:

File "/usr/local/lib/python3.9/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 562, in _run_script
    exec(code, module.__dict__)
File "/sandmark-nightly/app/app.py", line 23, in <module>
    app.run()
File "/sandmark-nightly/app/multiapp.py", line 45, in run
    app["function"]()
File "/sandmark-nightly/app/apps/perfstat.py", line 182, in app
    ndf = normalise(df, baseline, "instructions_M")
File "/sandmark-nightly/app/apps/perfstat.py", line 65, in normalise
    df = add_display_name(df, variant, topic)
File "/sandmark-nightly/app/apps/utils.py", line 89, in add_display_name
    disp_name = [
File "/sandmark-nightly/app/apps/utils.py", line 90, in <listcomp>
    name + " (" + str(round(name_metric[name], 2)) + ")" for name in df["name"]

Other selections give different errors but it is impossible to get results for turing, for instance.

This is fixed in #98


xgov-115 - AlgoMinter - dApp that allows users to create highly customizable generative Algorand NFT collections

I am developing an app that allows users to generate NFT collections utilizing user-uploaded image data (layers) as well as customizations that offer fine-grain control over the generated images.
The dApp will allow users to upload layer files, set rules for specific traits, preview images based on collection size, and then either download the images or mint them straight to the Algorand blockchain using ARC69, ARC19 specifications.
Thanks so much for your time and consideration!

Let me know if there's anything else I need to do here! This is my first proposal so not sure if I've done this correctly. Thanks!

Open sourcing of the code is preferred as it is community funding. Open sourcing helps to create a pool of code base that future developers can refer to for their projects. But there are always exceptions.

@Vidhyanandcs No worries! I can make it open-source!

Proposer, please post your algorand forum discussion thread link here. Thank you.


Close account - Tooltip appears in the comments section

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch App
Login with any account
Navigate to Settings > Security
Enter information in the comments section

Expected Result:
Tooltip does not appear in the comments section
Actual Result:
Tooltip appears in the comments section
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/217274989-d8ae9189-3c16-4843-9daf-a38b31f1a399.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kbecciv - can you clarify what you mean by Tulip appears in comments section? I'm not familiar with that phrase. ty!

@maddylewis Corrected

got it, thanks for clarifying!

reviewing now

im unable to reproduce this in my iOS app. the tool tip doesn't appear in the comments section at all - before/during/after typing text in the comments section.

okay, i ended up being able to reproduce the behavior but this is seemingly expected. the tooltip is showing predictive text so it makes sense that it shows up when deleting text. if you click the text in the tool tip bar it updates the word in the comments section.
since this is seemingly expected behavior, ill go ahead and close this out.


[Dubbo-6034] Fix the RegistyUrl mismatching to ZoneAwareClusterInvoker.PREFER_REGISTRY_KEY

What is the purpose of the change
Fixes #6034
When I have follow setting, the final registry URL is: nacos://<IP_ADDRESS>:8849/....?preferred=true.
<dubbo:registry address="nacos://<IP_ADDRESS>:8849" preferred="true"/>

Because of ZoneAwareClusterInvoker.PREFER_REGISTRY_KEY is mismatching to RegistryConfig.preferred key, the following code can't works as expect.
// method => org.apache.dubbo.rpc.cluster.support.registry.ZoneAwareClusterInvoker#doInvoke
if (clusterInvoker.isAvailable() && clusterInvoker.getRegistryUrl()
        .getParameter(PREFER_REGISTRY_KEY, false)) {
    return clusterInvoker.invoke(invocation);
}

Brief changelog

Aliasing preferred equal to ZoneAwareClusterInvoker.PREFER_REGISTRY_KEY when invoking AbstractConfig#appendParameters method.

Verifying this change

The final registry URL should be: nacos://<IP_ADDRESS>:8849/....?registry.preferred=true.

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[x] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[x] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #7788 (43bd0c6) into master (1a7ca1e) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7788      +/-   ##
============================================
- Coverage     59.47%   59.25%   -0.22%
+ Complexity      556      555       -1
============================================
  Files          1083     1083
  Lines         43755    43708      -47
  Branches       6380     6347      -33
============================================
- Hits          26022    25899     -123
- Misses        14876    14955      +79
+ Partials       2857     2854       -3

Impacted Files
Coverage Δ
Complexity Δ

...n/java/org/apache/dubbo/config/RegistryConfig.java
86.17% <ø> (ø)
0.00 <0.00> (ø)

...ng/transport/dispatcher/all/AllChannelHandler.java
62.06% <0.00%> (-27.59%)
0.00% <0.00%> (ø%)

...rg/apache/dubbo/remoting/utils/PayloadDropper.java
76.92% <0.00%> (-15.39%)
0.00% <0.00%> (ø%)

...ng/transport/dispatcher/WrappedChannelHandler.java
47.82% <0.00%> (-15.22%)
0.00% <0.00%> (ø%)

...bo/config/event/listener/LoggingEventListener.java
50.00% <0.00%> (-12.50%)
0.00% <0.00%> (ø%)

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
0.00% <0.00%> (ø%)

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
81.13% <0.00%> (-11.33%)
0.00% <0.00%> (ø%)

...che/dubbo/remoting/transport/mina/MinaChannel.java
35.52% <0.00%> (-10.53%)
14.00% <0.00%> (-1.00%)

.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java
62.06% <0.00%> (-10.35%)
0.00% <0.00%> (ø%)

.../dubbo/remoting/transport/netty4/NettyChannel.java
54.45% <0.00%> (-8.92%)
0.00% <0.00%> (ø%)

... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7ca1e...43bd0c6. Read the comment docs.

Would you please add some unit test cases for this PR?

Would you please add some unit test cases for this PR?

I will

Would you please add some unit test cases for this PR?

I have finished the unit test for this PR, please have a look at it.


Enhance supported data documentation table

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (3fb8b32) to head (9c752c8).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #42   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           16        16
  Lines          146       146
  Branches        24        24
=========================================
  Hits           146       146

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Hide rejected does not work

Clicking it seems to have no effect.

This has now been fixed (GUI only change, no need to update the backend for this fix).
"Hide rejected", and "Show accepted only" should both work now. However, I disabled the other option to show only those units corresponding to visible electrodes. That will involve some more work to get working again.

Disabled these options once again because I think it is causing the browser to hang.

Sounds good. I’ll be able to test again in ~30 minutes.

On Jul 5, 2021, at 7:18 PM, Jeremy Magland @.***> wrote:
Disabled these options once again because I think it is causing the browser to hang.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/magland/sortingview/issues/9#issuecomment-874411921, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV4PSIQKOKAIC5FRJT3PWDTWJRZHANCNFSM47Z6QAJQ.

This should be fixed now in version >= 0.2.16


[master] Make Longhorn UI Listen Binding configurable

https://github.com/longhorn/longhorn/issues/3829
Signed-off-by: Siye Wang<EMAIL_ADDRESS>

@smallteeths we also need to update longhorn/longhorn repo.


Cannot Run backend with given command. Build failure

Describe the bug
Unable to successfully run the backend with ./gradlew run_backend
To Reproduce
Steps to reproduce the behavior:

cd into RollBuddy
run ./gradlew run_backend

Expected behavior
A clear and concise description of what you expected to happen.
Expected the backend to show message that indicates succesful build
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Did you make sure to correctly setup java on your system?

Hi Michael, thanks for your bug report. I believe this is an issue with environment variables, if you can share the output of echo %JAVA_HOME% (via Command Prompt) or Get-ChildItem Env:JAVA_HOME (via PowerShell) with us we can try to help!
Alternatively, you can use app directly by visiting https://ngutn24.github.io/RollBuddy

@leftl  @Esauidk  Hey guys, here's what I get when I run Get-ChildItem Env:JAVA_HOME

Thank you for the response, it's definitely an environment variable issue. If you follow the instructions here it will help you update this variable (you may have to run where java to find the destination of your JDK installation).
I will update the installation portion of our user guide if this is not automatically set by the installer, thanks again for pointing this out.
I do suggest that you review our app via the hosted version here: https://ngutn24.github.io/RollBuddy as opposed to hosting it yourself.

@leftl awesome. Thanks!


allow_unknown_urls is only in master branch, not in 1.5.2

Driver#allow_unknown_urls is only in master branch, not in 1.5.2

This may have been deliberate, but :+1: for getting allow_unknown_urls into our hands asap please! I'm using HEAD for now on a feature branch or three, but would very much prefer an official numbered release before releasing this into our masters.

This was deliberate.
I try to restrict patch level releases to only bugfixes that I'm reasonably sure won't cause other bugs. Even in those cases, we've accidentally introduced new bugs, as was the case with 1.5.1.
The remaining changes on master will be released in 1.6.0.
I'm going to close this, as I don't think there's a bug here. Please let me know if I'm missing something.


Fremmy Isles ores requirement wrong

https://github.com/Zoinkwiz/quest-helper/blob/b319672fbbf8e48a27e4b8f42bee2bd24673c329/src/main/java/com/questhelper/quests/thefremennikisles/TheFremennikIsles.java#L296-L307
The coal and mithril check should be flipped. Currently it will recommend coal for mining level >= 55 as well.

Good spot, fixed in https://github.com/Zoinkwiz/quest-helper/commit/e27b0b37d1e150f02b21bbefc0e21b30ea7e061f, thanks!


feat(university-of-lagos): add faculties and departments to the university data

I'm not sure if this shouldn't be a draft PR instead. A lot of departments and faculties (okay, practically all of them except science) don't have acronyms. And by don't have, they probably do, and I just don't know them, and it's not on the website (also, God abeg these websites <<<<<<).

Hehe! I feel your pain regarding the websites 😃
And I think the PR is good to go.  We can add the acronyms later on when you're able to get them.
A couple of school's data here do not have all the acronyms for each department


Uncaught SyntaxError: Unexpected token '<' api.js:1 in webGL

I'm trying to intwegrate WebGL but when i run the same in browser i'm getting this error:

Uncaught SyntaxError: Unexpected token '<'
api.js:1
Uncaught ReferenceError: WE is not defined
    at initialize (index-new.html:7)

<!DOCTYPE HTML>

        <title>WebGL Earth API: Hello World</title>

This

Uncaught SyntaxError: Unexpected token '<'
api.js:1

makes me think (know), that the js-file is probably not loaded correctly.
Checklist:

In the developer-tools, when you switch to network, what exactly is the response of the requested js-file?
(like is it really the expected content, or maybe a server-error?)
Have you tried downloading the js-file and serving it to your application locally?
Or maybe try https and not http


Fix Iam->Ipam Resource Names

Fixes #2758

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2285b8b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2783   +/-   ##
=========================================
  Coverage          ?   58.33%
=========================================
  Files             ?        1
  Lines             ?       12
  Branches          ?        0
=========================================
  Hits              ?        7
  Misses            ?        4
  Partials          ?        1

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Packages without Releases with/without Tags

This is in continuation of #13 as you resolved that larger problem, but arrow as it is still doesn't build and (along with some other packages without tags) is causing a build error to show at R-universe which may look alarming to novice users.
The entry for Arrow looks like this:
[submodule "arrow"]
path = arrow
url = https://github.com/apache/arrow
branch = r-universe-release
subdir = r
The Apache team have a policy of updating the 'r-universe-release' tag with the latest release.
There are also repos with no tags or releases at all. I think the policy needs to be flexible in those cases and take them from the Github CRAN mirror. I mean it is up to the maintainer whether or not they make tagged releases.

In case it helps to know, I am the one who contributed the entry for arrow. Maybe that makes this make more sense.
I was actually planning to write to the arrow team to introduce r-releases and ask if they would be willing to create GitHub releases for the R front-end. Releases are easy to create, certainly much easier than submitting to CRAN (especially given their recent experiences), so I think they may be open to it.
I agree that whether the maintainer wants to use the CRAN mirror or a GitHub release is up to them. It does not matter where release is hosted as long as

It is the production release, not the development version.
The release is somewhere R-universe can pick up.

However, I hope the creation of a GitHub release is something we can gently request from package maintainers, as long as we do it in a way that does not make it a deal-breaker. Regardless of our r-releases project, the creation of releases is a good documentation practice, and feeding the habit will be a service to the community in itself.
On this, would it be okay to make assert_package() check if a release exists and flag the package for manual review if it does not? I agree that the failing check does not look good, even if it is pretty much innocuous. And the manual review will allow us to add guidance in an automated way, and it will allow us to catch these cases before the bot piles up and merges too many.

Another way to look at it: if the bot finds a release, then the smooth experience of the automatic merge is a reward. In other words, we enforce positive incentives to create releases.

Thanks, I was aware you contributed arrow. The ones without releases I think were dependencies of Shiny I added at an early stage when I hadn't yet realised this problem.
I think it makes sense in specific cases such as this, in that they already target R-Universe as a release location and it may actually simplify their workflow.
Equally though, the fact they create a separate tag may mean that they supply a 'special' version to CRAN (I've not determined if this is the case) and it may not work for them to create a single 'release'.
More broadly though, even if you do try to reach out to maintainers, I can see many cases where they will be unwilling to change practice (I can anticipate responses such as 'I've done this for the past 20 yrs, I'm not going to change now', 'x large company does this, if it's good enough for them it's good enough for me', etc. etc.)
So my point was, in the spirit of transparency and to ensure a consistent experience, should we add this to the policy that where releases are not made, the CRAN mirror can be accepted instead (and may be swapped for the official Github once releases appear).
CRAN mirror submissions are already flagged for manual review so I don't think we need to change anything there.
As for submissions where the submitter does not realise the releases are not present, agree that we should add an automated check for this. I think the PR should be directly rejected with the message that quotes the policy about using the CRAN mirror in these cases - in order to minimise the need for manual intervention.

Submitted https://github.com/r-releases/r.releases.utils/pull/6 and https://github.com/r-releases/help/pull/19.
GitHub releases are easy to detect, but GitLab is a pain because curl redirects to the sign-in page. I think it wouldn't be a burden to manually review GitLab URLs because there are so few anyway.

Thanks for addressing these so quickly!
I do want to make the observation that I think it's fine to be opinionated about this at r-releases, as it is a core proposition that everything remains available for reliability, and we don't want to see CRAN dependencies get taken down and disappear. However addressing your comment https://github.com/r-releases/help/issues/17#issuecomment-1975515555 I'd caution against more intrusive measures reaching out to specific maintainers (at least in a blanket way) as I feel it's somewhat a slippery slope - at what stage is it ok to make an intervention.

However addressing your comment https://github.com/r-releases/help/issues/17#issuecomment-1975515555 I'd caution against more intrusive measures reaching out to specific maintainers (at least in a blanket way) as I feel it's somewhat a slippery slope - at what stage is it ok to make an intervention.

That's a good point, and it would be a time-consuming chore to go seek out individual maintainers anyway. In the future, I think these issues can be sorted out when the PRs are flagged for manual review and the moderator can discuss in the thread?
For the moment, how do you suggest we handle packages like arrow which are currently in our packages.json?

I think these issues can be sorted out when the PRs are flagged for manual review and the moderator can discuss in the thread?

I think that's the best course of action. We should be respectful of anyone who did not initiate the interaction and it would be completely optional whether a maintainer joins such a discussion or not.

For the moment, how do you suggest we handle packages like arrow which are currently in our packages.json?

Well, now that the policy is clear, I'm ok to use the CRAN mirror as an interim measure to clear the build errors.

Nice green check mark now at https://r-releases.r-universe.dev/ :)


[WIP] PIN: Upgrade nipype to include networkx fix

Tracking nipy/nipype#2171 to make sure we're not breaking things downstream.

Closed by 41f187b. (Wrong PR in commit message.)


Update description of cpu_affinity_final

To align with the change in https://github.com/opencontainers/runtime-spec/pull/1261

Please wait for merged https://github.com/opencontainers/runtime-spec/pull/1261

@utam0k Can you take a look since the PR was merged?

@utam0k Ping!


I met a problem when compiling

[demovfuscator] make                                    17:57:49  ☁  master ☂ ✭
clang++ -Wall -Wextra -pedantic -std=c++11 -lcapstone -lkeystone -lz3 -lssl -lcrypto elfhlp.o demov.o test.o memhlp.o dishlp.o utils.o ctlhlp.o ctlelem.o node.o asmhlp.o -o demov
asmhlp.o: In function `asmhlp':
/home/assassinq/demovfuscator/asmhlp.cpp:21: undefined reference to `ks_open'
asmhlp.o: In function `~asmhlp':
/home/assassinq/demovfuscator/asmhlp.cpp:25: undefined reference to `ks_close'
asmhlp.o: In function `asmhlp::replace(cs_insn*, cs_insn*, symbl)':
/home/assassinq/demovfuscator/asmhlp.cpp:170: undefined reference to `ks_asm'
/home/assassinq/demovfuscator/asmhlp.cpp:179: undefined reference to `ks_free'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Makefile:8: recipe for target 'demov' failed
make: *** [demov] Error 1

I don't know how to solve it

There seems to be a problem with keystone. I see your compiler not complaining about not finding the keystone library, so i would like to ask you for the version of keystone you are using

@leetonidas How to check the version of keystone? I just git clone it from https://github.com/keystone-engine/keystone and compile.

Can you please check whether your libkeystone.so actually exports the symbols ks_open, ks_close, ks_asm, and ks_free? You can use nm to found exported functions in shared libraries.

@kirschju I only find libkeystone.a...
[demovfuscator] whereis libkeystone.so                   6:43:56  ☁  master ☂ ✭
libkeystone: /usr/local/lib/libkeystone.a
[demovfuscator] nm /usr/local/lib/libkeystone.a | grep ks_
0000000000000000 T ks_arch_supported
0000000000000000 T ks_asm
0000000000000000 T ks_close
0000000000000000 T ks_errno
0000000000000000 T ks_free
0000000000000000 T ks_open
0000000000000000 T ks_option
0000000000000000 T ks_strerror
0000000000000000 T ks_version
0000000000000000 t _ZL6InitKsiP9ks_structNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
0000000000000000 W _ZN9ks_structD1Ev
0000000000000000 W _ZN9ks_structD2Ev
0000000000000000 n _ZN9ks_structD5Ev
0000000000000000 b _ZZL6InitKsiP9ks_structNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEE11initialized

You need a shared library, not a static one. Please consult the appropriate readmes to find out how to create one.

@leetonidas Thanks


Details about Experiment on STARE Vessel Dataset

Thank you for your remarkable work. MedSAM2 used a mask prompt on the STARE dataset, as shown in Figure 4 of the paper. I would like to know whether the mask covers the entire vessel region in one large area, or if it is detailed enough to cover each vessel individually with an approximate mask.
If you could  guide me on how to perform testing and visualization on STARE, I would be extremely grateful.

Also want to know more details about how to achieve good results with vessel segmentation. What about 3D vessel segmentation? I wonder if it is possible to get comparable results.

Hi,
I am still reading the paper, however, you can use perplexity.ai tool that can search internet and answer your questions with more-based answers. I gave paper link and your questions, and the answer:
In the context of the STARE dataset, the mask prompt used in MedSAM2 is designed to provide a detailed approximation of the vessel regions. According to the paper, the mask does not cover the entire vessel region in one large area; instead, it is crafted to delineate individual vessels more precisely. This allows for better segmentation performance, as the model can focus on the specific contours and characteristics of each vessel rather than treating them as a single entity.

Furthermore, as being new to concept, I searched through that tool and found out mmsegmentation toolbox. Seems it preprocesses data and probably used to prepare REFUGE 2d dataset using: python tools/convert_datasets/refuge.py  from mmsegmentation.
Here is the link to convertion: https://github.com/open-mmlab/mmsegmentation/blob/main/docs/en/user_guides/2_dataset_prepare.md
I am plannnig to contribute repo by adding a preprocess data guide step 🙏

@rabiaedayilmaz Hello, I have some questions to consult with you. Have you trained Medical-SAM2 using your dataset? Is the dataset you used a 3D medical imaging dataset? I want to use my dataset to train Medical-SAM2. How should I proceed?


2.0: Invalid field error when trying to create additional tenant manually

I have succeeded in creating my user and root tenant however, when trying to create further tenants I am receiving a unauthorized error on the parent field:
ERROR (payload): ValidationError: The following field is invalid: parent

    at beforeChange (/home/node/app/node_modules/payload/src/fields/hooks/beforeChange/index.ts:56:11)

    at processTicksAndRejections (node:internal/process/task_queues:95:5)

    at create (/home/node/app/node_modules/payload/src/collections/operations/create.ts:197:31)

    at createHandler (/home/node/app/node_modules/payload/src/collections/requestHandlers/create.ts:26:17)

Dependencies:
{
  "dependencies": {
    "@aws-sdk/client-s3": "^3.427.0",
    "@aws-sdk/lib-storage": "^3.427.0",
    "@payloadcms/bundler-webpack": "^1.0.3",
    "@payloadcms/db-mongodb": "^1.0.3",
    "@payloadcms/plugin-cloud": "^0.0.10",
    "@payloadcms/plugin-cloud-storage": "^1.0.19",
    "@payloadcms/richtext-lexical": "^0.1.5",
    "cross-env": "^7.0.3",
    "dotenv": "^8.2.0",
    "express": "^4.17.1",
    "payload": "^2.0.13",
    "payload-tenancy": "^2.0.0"
  },

It is also a required field so I can't create any additional tenants.
Any help appreciated!
Screencap
https://github.com/joas8211/payload-tenancy/assets/54963231/1e7cca42-6007-4421-adbd-8629f0ecda0e

I can't reproduce this. I need some more help to figure out what might be the problem.
The "Unauthorized" validation error triggers when selected parent is some tenant that user has no access to. Access to the tenant depends on what tenant the current user belongs to. The tenant user belongs in and all tenants under that are authorized for that user.
Normally the parent field won't list tenants that user don't have access to, because tenants collection limits read access to only documents that are authorized for the user. So it's weird that this happens at all.

@joas8211 Thanks for taking a look,  I just dropped by database to try again and can reproduce under the following conditions:

Enable plugin like so:

plugins: [
    tenancy()
]

Create initial user manually using the Admin UI
Create root tenant manually using Admin UI
After creating root tenant, I receive the following error in my docker console:

[20:22:32] WARN (payload): rollbackTransaction called when no transaction exists
 [20:22:32] ERROR (payload): NotFound: The requested resource was not found.
    at findByID (/home/node/app/node_modules/payload/src/collections/operations/findByID.ts:109:15)
     at processTicksAndRejections (node:internal/process/task_queues:95:5)
     at findByIDHandler (/home/node/app/node_modules/payload/src/collections/requestHandlers/findByID.ts:19:17)

At this stage my admin UI will not load, to remedy this, I enable the path based isolation strategy with:

plugins: [
    tenancy({
        isolationStrategy: "path"
    )
]

I can now see all my collections at the path based url localhost:3000/tenant-slug/admin.
Try to create a child tenant which is where I encounter the previously reported validation error

Maybe there's just some setup that I've missed...I will also try to do the programmatic setup as written in the docs see if that changes anything.

@joas8211 Finally found my issue, it was due to my code but i'll leave this here if anyone else comes across it:
auth: {
    depth: 0,
  },

instead of:
auth: true

Had it left over from Payloads docs about creating multi-tenancy before I found your plugin.
Thanks again for taking a look!


Remember the location selected in the sidebar

If no selection is stored, or the previously selected location is no longer available, we should select the first available location.

Reverse-duplicate of #156.


TimeDistributed(Dropout()) with the same dropout mask

System information

TensorFlow version (you are using): 1.14
Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
Here is an example block of my code. I am trying to apply a time distributed dropout to the output of a many to many GRU. I would like to keep the dropout to have the same dropout mask for all time steps. However, I did not find a solution to this purpose based on the current API. Did I miss anything or is it a new feature on the roadmap? Thanks a lot!
from tensorflow.keras.layers import Dense, Input, GRU, Dropout, TimeDistributed
x= TimeDistributed(Dense(512, activation='relu', kernel_regularizer=l2(1e-5), \
                bias_regularizer=l2(1e-5), name='cam_fc'))(input_tensor)
out = GRU(
                512,
                dropout=0.1,
                recurrent_dropout=0.1,
                activation='relu',
                kernel_regularizer=l2(1e-5),
                bias_regularizer=l2(1e-5),
                return_sequences=True,
                name='intentNet_gru')(x, training=self.is_train)

out = TimeDistributed(Dropout(0.1))(out, training=self.is_train)

I think what TimeDistributed does is that it slide the inputs based on timestep, and feed each timestep one by one to the wrapped layer. Note that when feeding multiple input to a dropout layer, each of them will get different dropout mask, which is aligned with current behavior.
If you want to apply same mask across time steps, what you can do is just using one dropout layer, but with noise_shape param specified. See https://www.tensorflow.org/api_docs/python/tf/keras/layers/Dropout for more details.


Anvil build creates 'config.h' in source tree, not build tree

I haven't investigated yet (if I get a chance, I'll update further), but I've noticed that Anvil creates include/config.h in the source tree instead of the build tree. This is probably not the desired behavior, and leads to a bit of an annoyance because Git wants me to add the file even though it's generated.

Fixed internally. This change will be included in the coming update.

The latest version contains a fix for this issue. Thanks for reporting.


[WIP] First cut for the modal dialog for iteration association of work items, fixes #714

Signed-off-by: Soumya Deb<EMAIL_ADDRESS>

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Will have to send in a new PR to resolve this. This one getting quite messy.
Initially it was intended to be only the visual implementation, but now that we've already made quite some progress on the api and interaction, it's pointless to send in another PR for just that. So, another patch will be sent, fixing all these in one go, while having the branch updated, as this one is getting stale.


IntentTEDPolicy: Adapt rasa interactive

Description of Problem:
When there is an unlikely intent, IntentTEDPolicy predicts an action_unlikely_intent to indicate the unlikely intent. This could be confusing to the user as they don't know where this action is coming from.
Overview of the Solution:
When the model predicted this action as part of rasa interactive we want to give them additional explanation why this action was predicted. Users can then choose to confirm / deny the action prediction as usual but it doesn't really matter as running this action doesn't have any implications.
See more information in the implementation proposal.
Blockers (if relevant):

[x] Implemented IntentTEDPolicy
[x] https://github.com/RasaHQ/rasa/issues/8417

Definition of Done:

[ ] Interactive displays the explanation for the prediction of action_unlikely_intent to the user.
[ ] somebody from CSE double checked the UX of the explanation

@RasaHQ/cseteam there are multiple ways of how we can do that. What do you think would be the correct message for this case?


Support for PyTorch's optimize_for_inference mode

🚀 Feature

Leverage PyTorch's optimize_for_inference mode for performance benefits during model evaluation and inference
PyTorch has recently introduced an experimental API optimize_for_inference:

https://pytorch.org/docs/master/generated/torch.inference_mode.html#torch.inference_mode
https://pytorch.org/docs/master/notes/autograd.html#locally-disabling-gradient-computation
https://github.com/pytorch/pytorch/issues/56608 / https://github.com/pytorch/pytorch/pull/58045

Motivation
Reap performance improvements
Pitch
This can be used during Trainer.predict in place of the no_grad if optimize_for_inference is available: https://github.com/PyTorchLightning/pytorch-lightning/blob/4c79b3a5b343866217784c66d122819c59a92c1d/pytorch_lightning/trainer/trainer.py#L1078-L1083
Alternatives
Keep as is
Additional context

If you enjoy PL, check out our other projects:

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.
Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, finetuning and solving problems with deep learning
Bolts: Pretrained SOTA Deep Learning models, callbacks and more for research and production with PyTorch Lightning and PyTorch
Lightning Transformers: Flexible interface for high performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

We could also enable it for test, right?

We could also enable it for test, right?

Yup! I wonder if we could with validation too, as long as we're careful to reset the mode before the next train loop call

I wonder if we could with validation too, as long as we're careful to reset the mode before the next train loop call

Not sure about this one, I can image somebody saving a validation inference-only tensor and trying use it on a computation that has a training tensor. This would fail, right?


[Draft] Make espresso outfiles/outdir water tight

Summary of Changes
Currently, users can still bypass Quacc's intended behavior by using environment variables and other workarounds to obtain output directories outside of Quacc's control. This PR aims to address this issue by enforcing specific keywords to be either deleted or set to certain values at the last moment before writing the input files, ensuring that no tampering can occur.
In addition to this change, I would like to discuss a current problem faced when using Quacc with Espresso for larger systems:
Let's consider a scenario where I want to perform a calculation on a relatively large system (600 atoms), with a wavefunction file size of approximately 1TB. If I want to execute a static job followed by a projwfc job to calculate the projected DOS, I will end up with two folders:
tmp-static: This job will take around 3 hours of compute time and produce 1TB of data.
tmp-projwfc: This job will need to copy the data from tmp-static and run for 5 minutes.
The problem is straightforward: it seems inefficient to copy 1TB of data for a job that will run for only 5 minutes.
As a potential solution, I propose the following (although I suspect it may not be well-received): This solution would require setting GZIP_FILES: False and WORKFLOW_ENGINE: None. When both of these conditions are met, instead of copying files to new jobs, we would set the previous directory inside Espresso's keyword. Espresso will then read from the previous data without the need for copying.
Pros:

Not intrusive on the code side, requiring only a few additional lines.
Current working directories are still used, but not for storing already existing data.
It solves the problem entirely, allowing users with limited scratch space to use Quacc and Espresso.

Cons:

This mode requires setting unrelated settings, such as GZIP_FILES: False (because QE cannot read gzipped files) and WORKFLOW_ENGINE: None (because I'm unsure of the behavior if multiple QE instances try to read the same files).
It may go against Quacc's design philosophy to some extent.

It's worth noting that this problem is somewhat niche, and Espresso's extreme modularity is defintely the problem here.
Checklist

[ ] I have read the "Guidelines" section of the contributing guide. Don't lie! 😉
[ ] My PR is on a custom branch and is not named main.
[ ] I have added relevant, comprehensive unit tests.

Notes

Your PR will likely not be merged without proper and thorough tests.
If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.
When your code is ready for review, ping one of the active maintainers.

Can one of the admins verify this patch?

Regarding the first part (file handling), all efforts are appreciated here. Espresso is especially tricky because most other codes don't give the user an option on where to write things --- it just dumps everything in the current working directory. Espresso's significant flexibility here is a blessing and a curse, mostly the latter in the context of a workflow engine. I'll trust your approach on this. If it's not too painful, you could consider logging a warning if the user sets one of these parameters in Espresso, but I anticipate that there are so many of them that this might not be a worthwhile effort.
As for the second topic about space, it is an interesting point to consider. These kinds of scales are just not possible with other codes. For VASP, I've run 500+ atom calculations and the wavefunctions are never more than a few GBs (1 TB would be absolutely wild). For VASP, there's also no way to avoid file copying because VASP has no knowledge of how to deal with files that aren't in the current working directory, and you'd overwrite the original output files if you ran in the same directory. That's true for most other codes as well, although Espresso is flexible here --- that's the blessing rather than the curse.
I think it is worth finding a mechanism to do this cleanly in Espresso given that it supports this kind of thing. Now for some implementation brainstorming:

I think there might be a way to avoid hard-coding the GZIP_FILES = False behavior. Presumably, in the Espresso calculator, we could check to see if the previous_directory parameter (or whatever that setting is called in Espresso --- sorry, I don't know) is set and if it is, automatically gunzip everything there. That might be a robust approach.
Regarding the workflow engine business, that might be one scenario worth trying to find out. Concurrent read operations really shouldn't be a problem. Concurrent read operations are only generally an issue when you have some locking mechanism, which Espresso has no reason to implement. So, perhaps one would not need to play with this.

@Andrew-S-Rosen
Some further details:

I agree for GZIP_FILES, it should not be that hard to get around.
Good news: It seems that it does not matter how many instances are reading files.
Bad news: some post-processing binary still write files to the "outdir" (xml files), meaning that potentially multiple instances will be writing to the same file.

I think that you actually found the solution: adding a kwargs to the concerned post processing jobs (they don't have many kwargs anyway) like "in_place", or "prev_outdir" giving the choice to the users about how to do things. If they are concerned about disk space then they should use it. With proper documentation and a warning about the potential writing conflict that should be ok.
This PR is good to go if you are ok with it.

@tomdemeyere: Thanks! I'm setting this to auto-merge. I fixed an issue with a docstring, but the rest is fine.
Agreed regarding the file copying approach. If there is a case of file clashing, we need to ensure that users have the option to avoid that. Giving users the option here seems like the most logical approach to me. I don't think that would be too much of a challenge.


Crash when using deep profiling.

unity 2018.1.6f1
Open fsm example, enable deep profiling, run the example - crash.

Cannot reproduce, can you try on the latest Unity version with the latest ReGoap's updates?


Speckle Manager signs out after installing Revit connector

Used Speckle Manager to install Revit connector. It signed me out after the installation and I had to go sign in again and re-approve the app using google sign on.

This also started working when installing Grasshopper and Rhino connectors. I can see it logs out and logs back in automatically. The first time it failed to log back in though. Not sure why.

Closing this for now since it started working.

It's a small glitch when installing connectors, we've fixed it and will be shipped in the next manager release :)
Thanks for reporting it!


Camera.unproject with Camera viewport scala size.

Result of Method Camera.unproject is weird when the camera viewport size is inconsistent with the window size , and the value of y always has a small deviation. I don't understand the graphics transformation, so the source code is not understood. The above is the situation I can provide. Using my code, try changing x and y to output the corresponding result of unproject result, and the result of my own unproject method.(using google translator，sorry)
public class CameraControl extends ApplicationAdapter {
    SpriteBatch batch;
    Texture     img;
    Camera      camera;

    @Override
    public void create() {
        batch = new SpriteBatch();
        img = new Texture("test.bmp");
        Gdx.graphics.setWindowedMode(200, 200);
        camera = new OrthographicCamera(Gdx.graphics.getWidth()/2, Gdx.graphics.getHeight() /2) ;
        camera.position.set(0, 0, 0);
        camera.update();

        float x = -300;
        float y = 300;
        Vector3 v3   = new Vector3(x, y, 0);
        camera.unproject(v3, camera.position.x, camera.position.y, camera.viewportWidth, camera.viewportHeight);
        System.out.println("unproject:  "+v3.x + " " + v3.y);

        Vector2 v3_2  = new Vector2(x, y);
        unproject(camera, v3_2);
        System.out.println("   mycode:  "+v3_2.x + " " + v3_2.y);
    }

    Vector2 unproject(Camera camera, Vector2 mouse) {
        Vector3 cameraPosition = camera.position;
        float   cameraX        = cameraPosition.x;
        float   cameraY        = cameraPosition.y;
        float   viewportWidth  = camera.viewportWidth;
        float   viewportHeight = camera.viewportHeight;
        float   screenHeight   = Gdx.graphics.getHeight();
        float   screenWidth    = Gdx.graphics.getWidth();
        mouse.x = (cameraX - viewportWidth / 2)
                + viewportWidth * (mouse.x / screenWidth);
        mouse.y = (cameraY - viewportHeight / 2)
                + viewportHeight * ((screenHeight - mouse.y) / screenHeight);
        return mouse;
    }

    @Override
    public void render() {
        camera.update();
        batch.setProjectionMatrix(camera.combined);

        Gdx.gl.glClearColor(1, 0, 0, 1);
        Gdx.gl.glClear(GL20.GL_COLOR_BUFFER_BIT);
        batch.begin();
        batch.draw(img, 0, 0);
        batch.end();
    }

    @Override
    public void dispose() {
        batch.dispose();
        img.dispose();
    }
}

You didn't really follow the guidelines for reporting an issue.
What platform and version?
What LibGDX version?
What's the expected result versus what you actually got?
Etc.
We can't (and probably won't) help you without enough information.

@EtK2000
platform windows10
IDE intellij
used gdx-setup.jar lastest version
libgdx 1.9.8

Vector3 v3=new Vector3(-100,100,0)
camera.unproject(v3, camera.position.x, camera.position.y, camera.viewportWidth, camera.viewportHeight);
I expect the result to be x:-100.0 y:0.0
Actually I get  x:-150.0  y:49.0
I suspect that unproject is not working as I imagined. If my use is wrong, please correct me.


A new, consistent name for the Gallery app?

When I install the app on Android, I see "Flutter Material" in my home screen. On iOS, I see "Material Gallery".
We're a bit more than just material. What about "Flutter Gallery" ?

cc @HansMuller @vlidholt @mpcomplete

+1 to Flutter Gallery.  We should probably rename the directory to match too.

https://github.com/flutter/flutter/blob/master/examples/material_gallery/ios/Info.plist#L14
https://github.com/flutter/flutter/blob/master/examples/material_gallery/android/AndroidManifest.xml#L11

We'd intended to call the app "Flutter Gallery", I will make it so.


fix bug: opts.rejectUnauthorized for SSL option

Using cli args
the options passed to the client does not include rejectUnauthorized because the value is added after the client is create.
So, I moved the code right before the client creation.
Using configuration file
the check for allowed keys will skip the key if the value is false, so the options will not include the key. To fix this, the code should only skip if the value is undefined.
allowedProps.forEach(key => {
      if (config[key] !== undefined) { flags[key] = config[key] }
    })

Could you add a test for this?

sorry for late reply. Sure, can I just write a unit test to make sure the option passed to the client? Or I need to test using the ES (I assume so when I see those docker-compose files) ?

the former is ok

@mcollina
Added a new test file for the cli and made some  changes to file cli.js so I can make unit tests for it.
I only write some tests for starter, but I hope that is enough to cover the issue I try to raise in this PR.


Remove Willing-specific components

We're moving away from Codebuild into Github Actions, and the ci-start script belongs in willing-zg if we are going to continue to use it.

Likely here at a later date


Devel

The game is completely created, except for completing the part of putting X number of cards per column.


Add timeouts

API requests can hang when there are issues on campus like what happened today.

This can now be done natively. See: GitHub docs


service unavailible

when i was looking at triggers, i got the error:
`Traceback (most recent call last):
  File "main.py", line 373, in _recognize
    self._handle_result(self.recognizer.do_request())
  File "/home/pi/voice-recognizer-raspi/src/speech.py", line 259, in do_request
    return self._handle_response_stream(response_stream)
  File "/home/pi/voice-recognizer-raspi/src/speech.py", line 207, in _handle_response_stream
    raise Error('Server error: ' + resp.error.message)
speech.Error: Server error: Service unavailable.
`

although i don't think it is relevant: my test weirdly recognized sound at start -> thinks -> this error spoken to the speaker -> ready -> my thing listens but callback can't be called anymore

my (very unclean) code: gist

I guess this is a temporary error in the backend. Did you see it repeatedly or just once? Are you still seeing it?
Also, could you explain further what you mean by "my thing listens but callback can't be called anymore"? In particular, which callback are you referring to?

Closing due to inactivity.


This is a test issue for gh-sync

Describe the bug
A clear and concise description of what the bug is.

Adding a comment


🌱 E2e Gitlab Issues

What kind of change does this PR introduce?
E2e tests for Gitlab issues. The list issues will fail as it requires additional permissions.
(Is it a bug fix, feature, docs update, something else?)

[ ] PR title follows the guidelines defined in our pull request documentation

What is the current behavior?
What is the new behavior (if this is a feature change)?**

[ ] Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Requested more details. The PR template was empty, and the test didn't clarify much.

I have updated it. This is e2e tests for GitLab issues. The Gitlab issues API requires additional permissions that would prevent the normal token from fetching the issues.


Build a true complaint module

Big issue is getting the summons.
Would it be possible to work with the court to accept an electronic summons?

Use the revised complaint draft from Stefanie


⚠ Bofrost.nl has degraded performance

In f3322af, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1986 ms

Resolved: Bofrost.nl performance has improved in d299d9c.


Server Crash - Cause: Stack overflow

Bug
Replace this line with the bug you've encountered and what is the expected behaviour.
Steps to reproduce

[error] Cause: Stack overflow
[error] At: server.dll + 0x58bda2

Specifications

Northstar version: V1.9
Platform:  Steam

🤨

Not relevant anymore?

No way to diagnose the problem anyways

This is nearly two years old now with no response. I think it's fine to close. If this is somehow still an issue on latest release please LMK and make a new issue or re-open this one.


Crash 30sec to 5min after swapping deployment

I am testing Telepresence out, and have a persistent problem swapping out deployments on my GKE cluster. I am running the following command:
telepresence --namespace staging --swap-deployment pentagon --method inject-tcp --run-shell --verbose
(I'm using inject-tcp because I'd like to be able to swap more than one out at a time, but I'm not getting that far. Same error happens with vpn-tcp method also though - I tried.)
After somewhere (seems to be random) in the realm of 30 seconds to 5 minutes, Telepresence reports Proxy to Kubernetes exited. This is typically due to a lost connection. with a stack trace to a failed umount, but that appears to be common with other issues here. This only seems to happen with a swapped deployment. If I'm not trying to swap and just connect to the cluster with telepresence, it seems stable.
I have uploaded the relevant looking piece of the telepresence.log file to a gist here.
I am using MacOS 10.13.2.
Any ideas would be much appreciated.

An very persistent automatic sync by weaveworks/flux (which was also running on the cluster) caused this. This had nothing to do with telepresence - apologies. If anyone else happens upon this, the solution was to add the annotation flux.weave.works/ignore: "true" to any deployment that I intended to swap with telepresence.

Thanks for tracking this down! (And sorry for the delay in not responding).


v6.0.4

Improve README

Coverage increased (+99.1%) to 99.103% when pulling cf64c25e68896f80c1819454ce15a3e7a4661168 on 6.0.4 into 25b4b255422de4a40e41fa26fc6a7561e03a5b97 on main.


Fix memory leak and (kinda) cleanup code?

To try and preserve behaviour I used do while which I don't think ended up making the code much more readable... ah well, fixed a memory leak at least.
Testing:

Not really certain, but I think a good number of hooks would break if this code was broken, so uhh launch the game and play a match or something I guess

Considering we want to nuke AUTOHOOK is there any use in potentially breaking it just for it to look slightly nicer?

Tried testing on Linux but it failed to launch and in the process my Wine prefix got polluted to the point where EA would crash. I'm not sure if this is a Linux skill issue or an effect of this PR.
Either way, if someone could test this on Windows in the meantime to LMK whether it works or not, that'd be great <3

@RoyalBlue1 said she agrees with @F1F7Y on this.


Support special characters in LDAP bind password

This addresses an issue where a valid LDAP password that contained special characters would not work as expected when configured in chef-server.rb.

:+1:
It may be worth using this helper function in any of our bits that write passwords to config, since this can affect any service where the user provides a password.  In particular, postgres and rabbitmq can be provided externally, with passwords we have no control over.

@marcparadise I'm all for that, but I think supporting special characters in postgres and rabbitmq will require more work than just adding this helper in the sys config. There are libs that would need to be updated as well. I think coming back to address special characters in those places should be a separate change.


Fix typo once again from "Update YAMT"

Don't know why I keep doing this. Sorry if I'm kinda annoying creating pull requests.

This time I won't delete my branch since I did a mistake and had to create a new one.


enable sctp support in OTP 19

enable sctp support
at runtime this will work only if the kernel of your host has sctp support
quick test to see if it works:
root@2e25e3a0f7b0:/# erl
Erlang/OTP 19 [erts-8.0] [source] [64-bit] [smp:4:4] [async-threads:10] [hipe] [kernel-poll:false]

Eshell V8.0  (abort with ^G)
1> gen_sctp:open() .
{ok,#Port<0.441>}
2>

looks good; do you have image size before and after?

Odd, however in my case images are even smaller
docker@vm1:~$ docker version
Client:
 Version:      1.11.1
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   5604cbe
 Built:        Wed Apr 27 00:34:20 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.11.1
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   5604cbe
 Built:        Wed Apr 27 00:34:20 2016
 OS/Arch:      linux/amd64
docker@vm1:~$ docker images
REPOSITORY                       TAG                 IMAGE ID            CREATED             SIZE
<IP_ADDRESS>:5000/colrack/erlang   19.0-slim-sctp      135848c53523        15 hours ago        286.6 MB
<IP_ADDRESS>:5000/colrack/erlang   19.0-sctp           4990bf883654        15 hours ago        759.9 MB
erlang                           19.0-slim           b0ad5abde9b7        2 weeks ago         286.8 MB
erlang                           19.0                37eebbec8d71        2 weeks ago         760.1 MB

could be the base image buildpack-deps or some dependencies shrinked size; it's fine, as long as it doesn't increase size dramatically
thanks :+1:

@colrack I applied same changes to Erlang 18 as well, guess Erlang 18 is still the largest deployment and still has a long life cycle,
Please verify the official images' sctp features once docker-library/official-images#1943 is merged.

ok, thanks!

@c0b images from dockerhub are ok.
Thanks!


graphql: support new v16

grpahql has a new major version: 16 npm
Our tests seems to fail for this version, as can be seen in this renovate PR
The instrumentation reports supporting version >=14. But tests for v16 fail.
This issue is to investigate why tests are failing and create a PR with fixes and support for v16

Rauno already opened an issue for this here: https://github.com/open-telemetry/opentelemetry-js-contrib/issues/836 so i'm closing this one

Sorry it was this one: https://github.com/open-telemetry/opentelemetry-js-contrib/issues/784


feat(storage): adding example of using Client::DeleteResumableUpload()

Simple example of using DeleteResumableUpload() with running script.
Relates: https://github.com/googleapis/google-cloud-cpp/pull/5004

This change is

First, thank you for sending the PR, those are always welcome.
Second, as you probably noticed, you need to sign the CLA or we would be unable to accept any contributions.
Third, I know this review is asking for a lot of changes, if it becomes too much no worries, we can close the PR and we (Google) will get to this eventually.
Last, can you let me know how is this related to #5004 which is a Pub/Sub issue?

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @tina80lvl)

google/cloud/storage/client_example.cc, line 11 at r2 (raw file):

int main() {
  const auto& client_options =

I believe you want auto here, otherwise the value returned by ClientOptions() goes out of scope and the reference is invalid.
nit: this is an east const project, so that would be auto const&
google/cloud/storage/client_example.cc, line 21 at r2 (raw file):

  const auto& session_url = stream.resumable_session_id();
  const auto& client_status =
      client.DeleteResumableUpload(session_url, client_options);

In general, we like our examples to be:

compiled as part of the normal CI build
executed as part of the normal CI tests
runnable from the command-line
placed in a standard location so we can extract them into the Doxygen documentation.

Would you be able to move this example to this file:
https://github.com/googleapis/google-cloud-cpp/blob/master/google/cloud/storage/examples/storage_object_resumable_write_samples.cc
make it look similar to this example:
https://github.com/googleapis/google-cloud-cpp/blob/819050d3c3b575484edaf873067dc3191a32147e/google/cloud/storage/examples/storage_object_resumable_write_samples.cc#L29-L47
and make it run as part of the normal tests:
https://github.com/googleapis/google-cloud-cpp/blob/819050d3c3b575484edaf873067dc3191a32147e/google/cloud/storage/examples/storage_object_resumable_write_samples.cc#L112-L113
and make it runnable from the command-line:
https://github.com/googleapis/google-cloud-cpp/blob/819050d3c3b575484edaf873067dc3191a32147e/google/cloud/storage/examples/storage_object_resumable_write_samples.cc#L142
google/cloud/storage/sc.sh, line 1 at r2 (raw file):

#!/bin/bash

This should be unnecessary, the existing build scripts should work.

Thank you for a such quick review! Now I get what did you mean as "example", I'll fix that soon. But the main idea of  such kind of code is that there are huge difficulties with running this rep on Mac especially with benchmark so I have no ability to run tests for now so used my own main and my own script.

Thank you for a such quick review! Now I get what did you mean as "example", I'll fix that soon.

Oh the contrary, thanks to you.

But the main idea of such kind of code is that there are huge difficulties with running this rep on Mac

Okay, that seems like a more serious problem than just one missing example.  Could you tell us if the documentation here:
https://github.com/googleapis/google-cloud-cpp/blob/master/google/cloud/storage/quickstart/README.md
helps?  We tested that on macOS, and continuously test these steps in our CI builds too, but there are always fidelity problems between documentation and test scripts.

especially with benchmark so I have no ability to run tests for now so used my own main and my own script.

Are there specific issues with benchmarking that we can help you with?

Moreover, using of Client::DeleteResumableUpload() causes that kind of mistake:
➜  google-cloud-cpp git:(feat/4923) ✗ ./google/cloud/storage/sc.sh
In file included from google/cloud/storage/client_example.cc:1:
In file included from /Users/tina/dev/google-cloud-cpp/google/cloud/storage/client.h:19:
In file included from /Users/tina/dev/google-cloud-cpp/google/cloud/storage/internal/logging_client.h:18:
In file included from /Users/tina/dev/google-cloud-cpp/google/cloud/storage/internal/raw_client.h:20:
In file included from /Users/tina/dev/google-cloud-cpp/google/cloud/storage/internal/bucket_acl_requests.h:19:
/Users/tina/dev/google-cloud-cpp/google/cloud/storage/internal/generic_request.h:210:12: error: no matching member function for call to
      'set_option'
    Super::set_option(std::forward<H>(h));
    ~~~~~~~^~~~~~~~~~
/Users/tina/dev/google-cloud-cpp/google/cloud/storage/client.h:1262:13: note: in instantiation of function template specialization
      'google::cloud::storage::v1::internal::GenericRequest<google::cloud::storage::v1::internal::DeleteResumableUploadRequest,
      google::cloud::storage::v1::UserProject>::set_multiple_options<const google::cloud::storage::v1::ClientOptions &>' requested here
    request.set_multiple_options(std::forward<Options>(options)...);
            ^
google/cloud/storage/client_example.cc:21:14: note: in instantiation of function template specialization
      'google::cloud::storage::v1::Client::DeleteResumableUpload<const google::cloud::storage::v1::ClientOptions &>' requested here
      client.DeleteResumableUpload(session_url, client_options);
             ^
/Users/tina/dev/google-cloud-cpp/google/cloud/storage/internal/generic_request.h:66:12: note: candidate function not viable: no known
      conversion from 'const google::cloud::storage::v1::ClientOptions' to 'google::cloud::storage::v1::UserProject' for 1st argument
  Derived& set_option(Option p) {
           ^
/Users/tina/dev/google-cloud-cpp/google/cloud/storage/internal/generic_request.h:111:12: note: candidate function not viable: no known
      conversion from 'const google::cloud::storage::v1::ClientOptions' to 'google::cloud::storage::v1::UserIp' for 1st argument
  Derived& set_option(Option p) {
           ^
/Users/tina/dev/google-cloud-cpp/google/cloud/storage/internal/generic_request.h:111:12: note: candidate function not viable: no known
      conversion from 'const google::cloud::storage::v1::ClientOptions' to 'google::cloud::storage::v1::QuotaUser' for 1st argument
  Derived& set_option(Option p) {
           ^
/Users/tina/dev/google-cloud-cpp/google/cloud/storage/internal/generic_request.h:111:12: note: candidate function not viable: no known
      conversion from 'const google::cloud::storage::v1::ClientOptions' to 'google::cloud::storage::v1::IfNoneMatchEtag' for 1st
      argument
  Derived& set_option(Option p) {
           ^
/Users/tina/dev/google-cloud-cpp/google/cloud/storage/internal/generic_request.h:111:12: note: candidate function not viable: no known
      conversion from 'const google::cloud::storage::v1::ClientOptions' to 'google::cloud::storage::v1::IfMatchEtag' for 1st argument
  Derived& set_option(Option p) {
           ^
/Users/tina/dev/google-cloud-cpp/google/cloud/storage/internal/generic_request.h:111:12: note: candidate function not viable: no known
      conversion from 'const google::cloud::storage::v1::ClientOptions' to 'google::cloud::storage::v1::Fields' for 1st argument
  Derived& set_option(Option p) {
           ^
/Users/tina/dev/google-cloud-cpp/google/cloud/storage/internal/generic_request.h:111:12: note: candidate function not viable: no known
      conversion from 'const google::cloud::storage::v1::ClientOptions' to 'google::cloud::storage::v1::CustomHeader' for 1st argument
  Derived& set_option(Option p) {
           ^
1 error generated.

So I can conclude that set_option() is not implemented for that type of Options.

Moreover, using of Client::DeleteResumableUpload() causes that kind of mistake:
➜  google-cloud-cpp git:(feat/4923) ✗ ./google/cloud/storage/sc.sh

[snip]

google/cloud/storage/client_example.cc:21:14: note: in instantiation of function template specialization
'google::cloud::storage::v1::Client::DeleteResumableUpload<const google::cloud::storage::v1::ClientOptions &>' requested here
client.DeleteResumableUpload(session_url, client_options);
^
/Users/tina/dev/google-cloud-cpp/google/cloud/storage/internal/generic_request.h:66:12: note: candidate function not viable: no known
conversion from 'const google::cloud::storage::v1::ClientOptions' to 'google::cloud::storage::v1::UserProject' for 1st argument

[snip]

Derived& set_option(Option p) {
^
1 error generated.

So I can conclude that `set_option()` is not implemented for that type of _Options_.

  Yes.  You cannot pass ClientOptions to the DeleteResumableUpload() function, the valid arguments are documented here:
https://googleapis.dev/cpp/google-cloud-storage/latest/classgoogle_1_1cloud_1_1storage_1_1v1_1_1Client.html#ade8d4dc43d3aa3fb7c1a592d2d7493e6
I think UserProject is the only thing you could reasonably provide there.
May I ask: what are you trying to do?  Maybe I can point you to an existing example or benchmark that shows what you need.

This has gone quiet for a week, please let us know how we can help. Feel free to reopen this PR once you have signed the CLA and addressed the issues above.


chore: fixing maven build issues, updating plugin versions, app build

name: Pull request
about: Polishing Maven Build
title: '[pull-request]'
labels: ''
assignees: 'zambrovski'
Description
Short description or comments
Reference
Issues #509
Checklist

[ ] Acceptance criteria are met
[ ] Pipeline has been run successfully
[ ] JUnit tests have been run successfully
[ ] Changelog is adjusted
[ ] Documentations are completed
[ ] Frontend is tested
[ ] Created sub-branches are deleted
[ ] Boards are updated ( Digitalisierung , Support , Zenhub )
[ ] feature process is created or extended
[ ] git-ops is customized
[ ] Openshift environments are prepared (Secrets, etc.)

Merged as part of #107


⚠ Bofrost.de has degraded performance

In 9691713, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2077 ms

Resolved: Bofrost.de performance has improved in 06bce26 after 6 minutes.