Looking Good!

Are you planning on porting all functionality or just a subset?

Not all but the most frequent and important functions.


Update of our interface

Sorry for doing such a big rewrite.
I removed the CacheItem::isExpired function because !(CacheItem::isExpired) === CacheItem::isHit. Which feels redundant.
I removed the interface inheritance because it is no reason to have it. This way it could be reused by others. I would aslo suggest to move this interface to a separate package according to the common reuse principle.

Current coverage is 29.80%

Merging #3 into master will decrease coverage by -3.83% as of 7af8a49

@@            master     #3   diff @@
=====================================
  Files            2      2
  Stmts          110    104     -6
  Branches         0      0
  Methods         20     19     -1
=====================================
- Hit             37     31     -6
  Partial          0      0
  Missed          73     73

Review entire Coverage Diff as of 7af8a49

Powered by Codecov. Updated on successful CI builds.


Adding Hgroup

I added an hgroup to the website on lines 93 and 122.

Thanks Phil94comp for contributing.


OP-18094: integrate pipeline trigger to verify fiat permissions

https://devopsmx.atlassian.net/browse/OP-16464

This PR  triggered this build in this execution, please wait for it  and child pipelines to succeed before merging:  https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01GGRSFXRKSMR0JMD5YHB997EA

This PR  triggered this build in this execution, please merge to v4.0 branch only if this succeeds:  https://isd.prod.opsmx.net/deck/#/applications/isd40/executions/details/01GGRSGG5S5BH384R46B87878X


OpenAPIEndpointChain not imported in tool.py

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.

Example Code
requests = Requests(headers=headers, verify=False)
my_toolkit = NLAToolkit.from_llm_and_spec(
    llm,
    spec=OpenAPISpec.from_file("DLM_Lite_Gateway_openapi.json"),
    requests=requests,
    max_text_length=1800,  # If you want to truncate the response text
)

in tool.py
if TYPE_CHECKING:
from langchain.chains.api.openapi.chain import OpenAPIEndpointChain
Error Message and Stack Trace (if applicable)
File "C:\Users\suchaudn\OneDrive - Legrand France\PYTHON\langChain\natural_language.py", line 54, in
my_toolkit = NLAToolkit.from_llm_and_spec(
File "C:\Users\suchaudn\OneDrive - Legrand France\PYTHON\langChain\venv\lib\site-packages\langchain_community\agent_toolkits\nla\toolkit.py", line 74, in from_llm_and_spec
http_operation_tools = cls._get_http_operation_tools(
File "C:\Users\suchaudn\OneDrive - Legrand France\PYTHON\langChain\venv\lib\site-packages\langchain_community\agent_toolkits\nla\toolkit.py", line 52, in _get_http_operation_tools
endpoint_tool = NLATool.from_llm_and_method(
File "C:\Users\suchaudn\OneDrive - Legrand France\PYTHON\langChain\venv\lib\site-packages\langchain_community\agent_toolkits\nla\tool.py", line 50, in from_llm_and_method
chain = OpenAPIEndpointChain.from_api_operation(
NameError: name 'OpenAPIEndpointChain' is not defined
Description
i'm starting from the exemple:
https://python.langchain.com/docs/integrations/toolkits/openapi_nla
but i've an error because OpenAPIEndpointChain class is never imported cause by TYPE_CHECKING in tool.py
System Info
langchain==0.1.8
langchain-community==0.0.21
langchain-core==0.1.25
langchain-openai==0.0.6
langchainplus-sdk==0.0.21
langsmith==0.1.3

This is a bug. Easy to fix. Just remove if TYPE_CHECKING:
https://github.com/langchain-ai/langchain/blame/master/libs/community/langchain_community/agent_toolkits/nla/tool.py#L14


can't generate definitions when use  struct alias

Describe the bug
can't generate definitions when user struct alias
To Reproduce
Steps to reproduce the behavior:
1、comment contains this
// @Success  200 {object} Res  "ok"
2、struct
type JsonTime time.Time  // give a alias
// Res is used to response
type Res struct {
Name       string
CreateAt JsonTime
}
3、After execute command swag init, you can see  definitions like this in docs.go and swagger.json
"JsonTime": {
"$ref": "#/definitions/time.Time"
}
4、open swagger web page, you'll see  Resolver error : /definitions/time.Time does not exist in document
Expected behavior
I think JsonTime can be given a type like "object" or time.Time must be added in definitions
Screenshots

Your swag version
swag version v1.6.5
Your go version
go version go1.13.5 darwin/amd64
Desktop (please complete the following information):

OS: [masos]
Browser: [chrome]

Use refactored branch

Use refactored branch

Can you make it clear? I don't quite understand -，-

Use refactored branch

sorry，I'll try refactored branch

Yes, I solved it by use refactored branch, thanks sdghchj's answer  very much!!!


[Bug] Lack of migration path from user configs defined in profiles.yml to the 'flags' key in dbt_project.yml

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
Initially introduced with https://github.com/dbt-labs/dbt-core/pull/9289 and released with dbt-core v1.8 (though I see from https://github.com/dbt-labs/dbt-core/issues/9183 that it was also backported to 1.6 and 1.7), there isn't a viable migration path for moving from user configs defined in profiles.yml to the 'flags' key in dbt_project.yml.
The current behavior is that if user configs ARE defined in profiles.yml and the 'flags' key is NOT defined dbt_project.yml, dbt will yield this warning:
[WARNING]: Deprecated functionality

User config should be moved from the 'config' key in profiles.yml to the 'flags' key in dbt_project.yml.

if user configs ARE defined in profiles.yml and the 'flags' key is ALSO defined in dbt_project.yml, dbt will yield this error:
Runtime Error
  Do not specify both 'config' in profiles.yml and 'flags' in dbt_project.yml. Using 'config' in profiles.yml is deprecated.

The issue is that, as mentioned in dbt's documentation, profiles.yml is often not part of the dbt project and so not version-controlled:

This file generally lives outside of your dbt project to avoid sensitive credentials being checked in to version control

For an organization to make this change, then, each member of the organization would need to update their profiles.yml simultaneously with the creation of the flags key in dbt_project.yml in order to avoid a runtime error.
Expected Behavior
My expectation is that setting both user configs defined in profiles.yml and the 'flags' key in dbt_project.yml would yield a deprecation warning, with the user config defined in profiles.yml being ignored in favor of the 'flags' key in dbt_project.yml. This would allow users to opt-in to the new behavior, as intended, instead of making this, effectively, a hard deprecation for any organization with more than one user.
Steps To Reproduce

Use dbt-core v1.8.x
Define both a user config in profiles.yml:

config:
  use_colors: false

and a 'flags' key in dbt_project.yml
flags:
  use_colors: false

Run any dbt command (say, dbt debug)
See runtime error

Runtime Error
  Do not specify both 'config' in profiles.yml and 'flags' in dbt_project.yml. Using 'config' in profiles.yml is deprecated.

Relevant log output
No response
Environment
- OS: macOS-14.5-x86_64
- Python: 3.11.4
- dbt: 1.8.3

Which database adapter are you using with dbt?
snowflake
Additional Context
No response

@wherrmann Appreciate you noticing this and taking the time to bring this to our attention 🤩
Acceptance criteria
@jtcohen6, @dataders, and myself discussed this today. We agree with your expected behavior that:

setting both user configs defined in profiles.yml and the flags key in dbt_project.yml should be allowed but yield a deprecation warning
any individual user config defined in both profiles.yml should be ignored in favor of the one under flags key in dbt_project.yml. e.g. similar to how dictionaries for the meta config are merged

The would allow multiple users of the same dbt project to add flags: to their shared dbt_project.yml file but update their local profiles.yml on their own individual timing.
Example
profiles.yml
config:
  use_colors: false
  printer_width: 80

dbt_project.yml
flags:
  use_colors: true
  partial_parse: true

After merging values from profiles.yml and dbt_project.yml (with the latter taking precedence), we'd get the following:
  use_colors: true
  partial_parse: true
  printer_width: 80

this just bit me as well

Hey @mahiki, I'm not quite following how you implemented your workaround within Databricks.
Did you supply a templated profiles.yml from your repo and then modify it somehow? Was a profiles.yml file dropped into a folder from a key vault? Did you decide to add --project-dir to each of your command line flags? What indicates that a databricks workflow job is improperly configured? (Because possibly ours is 'improperly configured' and we just have been working around the quirks of the Databricks dbt job this whole time.)
My team also recently ran into this issue when trying to enable dbt_elementary in Databricks (dbt-core v1.7.x currently, hoping to upgrade to v1.8.x soon) using a Databricks dbt Job.
I assumed Databricks already specified the --project-dir (given that my dbt_project.yml is not at the root of my repo, I had to specify the subfolder), and I can see that dbt is reporting that the profiles directory is /tmp/tmp-dbt-run-703977762881311-profiles which was clearly automatically created for the purposes of the run...


Upgrade to Rider 2023.1

Love the plugin, however it does not work with the latest version of Rider
I tried editing the jar to force it to load, and it does. The settings menu hangs however, so it might require a little work.
The tasks do run though, and the rest seems to work well

+1

Any update on how this is going?

Still waiting on it.

I wish it was possible to +1 react to a comment, so I apologise for how asinine this comment is! 😄
I also love the plugin and waiting for the 2023 support. Going to roll my sleeves up and take a look and what's required for the fix and if there's any breaking API change.

@LoveDuckie there are some minor breaking changes, nothing serious though.
The main obstacle currently is the settings pages crashing when the settings are opening.
So far I have somehow been unable to get a handle on that.

@LoveDuckie I think I found the problem - something in the way the icons were loaded in the settings pages.
You wouldn't have the cycles to check out #351 and take it for a spin, would you? 😉

I have made a preview version available in the beta chanel for everyone to test.

Hey @nils-a ! Thanks for pushing that out. The version appears to be working on the 2023 version of Rider that I'm using.
I just wanted to say that I've noticed that the same task will appear multiple times (one per .cs file) in the "Tasks" panel for the extension, if the derived Cake FrostingTask type is partially defined (i.e. partial) in multiple .cs files. I can open a new ticket for this if you like. Not sure if this is existing behaviour before the 2023 fix.

@LoveDuckie yes, I'd appreciate it if you could open a new issue.
(That way I won't forget about it 😬)


Add extension to Supabase

I've read this issue about not adding this function to the core, and it makes sense; I'm embarking on on project on Supabase and I'd love to see this extension available here.
Thank you for considering!

That's really up to supabase - they can add include this extension if they choose to.


chore: downgrade docker nodejs to 18

Motivation
We're still facing problems related to node-fetch/cross-fetch/native fetch in node 20.
Description
Downgrade docker nodejs version backto 18

:tada: This PR is included in v1.10.0 :tada:


Elyra dependency management for Python packages/dependencies

What is prompting the discussion?

Elyra releases in the wild stopped installing/working because a new version of black was released and it was incompatible with Elyra. The specific issue was about click version incompatible with back, but to put in generic terms there was an incompatibility between black 8 and Elyra x

How we tried to fix the issue
#2431 removed even more caps
What is next
The side effect of removing additional caps is that now, when the next release of X, Y Z comes out (e.g. Jupyter Client with incompatible changes to Jupyter Core, or back as described above) we are now even more exposed with our Elyra releases that will start picking up new transient dependencies automatically and failing to install or work properly.
Where else did we see these issues
This was a constant issue with our NPM packages, and we solved this by introducing package.lock which goes to the extreme of pinning to the exact version available at the time of the build/update.
How should we fix the issue thinking long term?
I would suggest we pin ALL python dependencies to at least <NEXT_MAJOR_VERSION

Some References:

Coming soon

The Extreme
The extreme would be to adopt some sort of tool like pip-tools to pin to the exact version which I am actually not suggesting. The side effect of pinning to the exact version is that, to support patch releases and security fixes, Elyra will always need to produce a patch release to all versions supported.

NOT A CONTRIBUTION

I believe this is a damned-if-you-do-damned-if-you-don't situation here.  I guess I don't have a problem capping every dependency and that we make this a project policy with no (or few, documented,) exceptions.  What really bugs me is having dependency caps on packages we don't even use - where does that stop?  Obviously, we have made a decision to only pin certain transitive dependencies (what were those circumstances?), and I guess I'm advocating for a similar approach to capping certain direct dependencies - as needed.
There are also examples where placing caps on everything doesn't work - and, hypothetically speaking, we (Elyra) have broken consumers with our actions.  Consider this example...

Acme Pipeline Inc, uses elyra in its product.  It also uses minio, and has a project policy that all required packages be capped less than their next major release.  This results in a snippet of their setup.py that resembles the following:
install_requires = [
    'elyra>=3.3.0,<4.0.0',
    'minio>=5.0.7,<7.0.0',
]

Elyra releases 3.4.0, which includes support for AWS ISRA.
All AcmePipeline releases are now broken because Elyra bumped a dependency across a major version (and within its own major version) that is incompatible with AcmePipeline's.  AcmePipeline must release patch releases where minio is capped at its next (non-existent) version despite not depending on any functionality from that major release.  OR they decide to cap elyra at <3.4.0 and not benefit from features added in 3.4 (in addition to violating the project's capping policy).  Had no caps been in place, they (and their customers) would be none the wiser.

So, I guess I don't think capping everything really buys you much more, has its own pitfalls, and, frankly, feels paranoid.  Until you pin the union of all packages to the exact version (i.e., essentially what containers provide), and what you mentioned above, then I really don't think any approach is very solid.

@lresende - would you mind updating the "Some References:" section in the description?  I'm curious what projects or best practices suggest an all-capped approach, and why.
Here is a link I just found indicating why unconditional upper bounds can be problematic.
We should also consider the fact that Elyra is not an application but a library given that it is two extensions: a server extension and a lab extension - both of which can be installed alongside other such extensions (with their own sets of dependencies).

I initially agreed to @lresende but after reading @kevin-bates 's article I think we should follow the practice recommended in the following section of this article as it makes totally sense to me when upper limits are valid

Was this issue essentially resolved via https://github.com/elyra-ai/elyra/pull/2583 where any caps that are necessary are commented and will be periodically revisited per the blog post linked in https://github.com/elyra-ai/elyra/issues/2435#issuecomment-1029386017?


Use C++ for '.ipp' file extension

This is a common C++ file extension for inline template includes, used in popular C++ libraries such as Boost.

Thanks @aleksijuvani !


deleteCascade="true" on addForeignKeyConstraint is simply ignored

Environment
Liquibase Version: 4.3.1
Liquibase Integration & Version: n/a
Liquibase Extension(s) & Version: n/a
Database Vendor & Version: Oracle and MSSQL
Operating System Type & Version: n/a
Description
If you have an addForeignKeyConstraint change with attribute deleteCascade="true" it is simply ignored.
This code: https://github.com/liquibase/liquibase/blob/43ed0e54adedc5f12c7933b998550e777d9b683d/liquibase-core/src/main/java/liquibase/change/core/AddForeignKeyConstraintChange.java#L195-L199 suggests that it should be automatically translated to onDelete="CASCADE" which would make sense, but it is not.
It currently is simply ignored.
┆Issue is synchronized with this Jira Bug by Unito

Hi @Vampire Thanks for creating this issue.  Do you have an example changeset that we can use to reproduce this issue?

   <changeSet id="xxx" author="n/a">
      <addForeignKeyConstraint baseTableName="BASE_TABLE" baseColumnNames="BASE_COLUMN" referencedTableName="OTHER_TABLE" referencedColumnNames="OTHER_COLUMN" constraintName="FK_BASE_OTHER" deleteCascade="true"/>
   </changeSet>


Ground Control on OpenELEC?

Is it possible to install Ground Control on OpenELEC?
After reading your installation readme, I realize there's no /etc/init.d folder in openelec.

Hi, I believe there should be some kind of init mechanism, Groundcontrol is a simple binary and doesn't require anything else as prerequisite, so you can use any init mechanism you wish.
On OpenELEC, check this out http://wiki.openelec.tv/index.php?title=Autostart.sh

thanks!

thanks!


Portals auto-remove itself over time

The portals, over time, are removed! First of all, they tp the player perfectley to the designed end but after a while, the tp delays a bit and then eventually, it delays so much it feels there is no portal... Any ideas!
Thanks
Major

Note I am on genisys...

I haven't tested with genesis, so I don't know.

I think it is lag, probably not SP issue.

No it wouldn't be lag because others work instantly...
On 2 Oct 2016 01:34, "Legoboy0215"<EMAIL_ADDRESS>wrote:

I think it is lag, probably not SP issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Falkirks/SimplePortals/issues/11#issuecomment-250946306,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AS__XwG1MObDVVwXLQ5vRjCCfxZ7oUyIks5qvvwhgaJpZM4KKgOE
.

How to remove that portal in config ?????????????<<<


enquote call to elevate

On Windows, if the Electron app/package is located in a folder with a space in its name, the call to elevate.exe fails to execute. This fixes the issue.

@peakwinter Сool, thanks for this fix. Could you check it out under different versions of Window?

I only have access to Windows 10 at the moment, sorry!


build(deps): bump regctl from 0.4.7 to 0.4.8

Release notes https://github.com/regclient/regclient/releases/tag/v0.4.8

Nice!
Curious how you noticed this? Is there a change in the latest release you need or just happened across it?

I came across it and figured it would be a good to add here :)


[USABILITY] Request modifications to Feedback button and panel title.

We have closed the "Submit Feedback" form in Safer Illinois.
The reason for doing so was because >90% of the messages submitted ask for technical support help, and although we redirect them to the proper help contacts, it results in significant delay for critical problems such as building entry. And some people don't include their email addresses, so it's possible they still haven't found help.
Isaac has changed the feedback form so that users are redirected to the Covid Wellness Center.
We would like to make some other wording changes to create a consistent context.

Remove the text that says "We need your ideas! Enjoying the app? Missing something? Tap on the bottom to submit your idea."
The "Submit Feedback" button should be renamed "Get Help"
The "Provide Feedback" title on the feedback panel should be renamed "Get Help"

The attached screenshots show the button and panel title in question.

Fixed in version 2.11.0


LogoCloud breakpoint

Current Behavior

My half screen is finding all the wonky breakpoints!
Steps To Reproduce
No response
Anything else?
No response

Seems to be a quirk of rendering it within the preview given the thick padding. Man, container queries need to be widely available already!

Merged into responsive ticket


Error with make_training_splits method

When runninglabels.make_training_splits() with sleap-io v'0.1.8', the generated splits seems to be inconsistent as below:
Source file: Labels(labeled_frames=1200, videos=1, skeletons=1, tracks=0, suggestions=0)

Splits: (Labels(labeled_frames=960, videos=1, skeletons=1, tracks=0, suggestions=0),
 Labels(labeled_frames=1, videos=1, skeletons=1, tracks=0, suggestions=0),
 Labels(labeled_frames=120, videos=1, skeletons=1, tracks=0, suggestions=0))

Notebook to recreate the error: https://colab.research.google.com/drive/1wnbrV8Yz6dakGV0ASqMoV94Pnvlg9LSL?usp=sharing
(Also for the sleap file in Y:\\talmo\\foundation-datasets\\mice\\sleap-mice_of\\labels.full.v043.pkg.slp)
Thanks!

This is now fixed in v0.1.9.


ERROR: The system was unable to find the specified registry key or value.

When run application(32bit) in window 64bit, I meet this errror

ERROR: The system was unable to find the specified registry key or value.
{ Error: Command failed: REG QUERY HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Cryptog
raphy /v MachineGuid
ERROR: The system was unable to find the specified registry key or value.
at checkExecSyncError (child_process.js:495:13)
at execSync (child_process.js:535:13)
at childProcess.(anonymous function) (ELECTRON_ASAR.js:685:22)
at Object.c [as machineIdSync] (XXX\

dist\win-ia32-unpacked\resources\app.asar\node_modules\node-machine-id\dist\inde
x.js:1:7226)

And I found this link: http://superuser.com/questions/625568/unable-to-delete-registry-key-in-hklm-microsoft-windows-currentversion-run-via-c

Are you using Windows 10?

I'm using window 7 64bit, in more detail:
when I execute cmd:

%windir%\System32\REG QUERY HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Cryptography /v MachineGuid
-> OK

%windir%\SysWOW64\REG QUERY HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Cryptography /v MachineGuid
->ERROR: The system was unable to find the specified registry key or value.

@khanhtranhd thanks for the tip, i'll fix it soon

https://github.com/automation-stack/node-machine-id/commit/890e3a49d698235c9f5d34558cee7d42ad879b5b

This still doesn't work, in windows 64bit you want to use the %windir%\System32\REG version. Needs to be corrected here: https://github.com/automation-stack/node-machine-id/blob/master/index.js#L7

@automation-stack ping

@ssboisen We had to use a random ID assigned if it doesn’t exist in localStorage due to this bug.

fixed in @1.1.4

It's still happening with 1.1.4 for me.
By the way, I also tried
%windir%\System32\reg query HKLM\SOFTWARE\Microsoft\Cryptography /v MachineGuid
on the command line, and I still got the error.

I found a clue about what's happening: I'm on 64-bit, and even %windir%\System32\reg is behaving like a 64-bit program (ie, it's affected by WOW64 and effectively looking under HKLM\SOFTWARE\Wow6432Node\Microsoft\Cryptography instead of HKLM\SOFTWARE\Microsoft\Cryptography.
I discovered that by actually adding a value under HKLM\SOFTWARE\Wow6432Node\Microsoft\Cryptography and requesting it via HKLM\SOFTWARE\Microsoft\Cryptography, and I got it back (again, using %windir%\System32\reg).

Sorry to spam, but I found the cause. You can read about it in this article.
tl;dr: I think you have to check for 32-bit or 64-bit Windows, and use %windir%\Sysnative on 64-bit, and %windir%\System32 on 32-bit. Please verify.
So, %windir%\System32\reg on my system turned out to be a 64-bit application, and it was pointing at the Wow6432Node part of the registry. It seems System32 only has 64-bit binaries, the 32-bit binaries are in SysWOW64. Running %windir%\SysWOW64\reg still didn't work. However, after reading the article, I tried %windir%\Sysnative\reg, and that worked just fine.
However, the article says that Sysnative doesn't exist in 32-bit Windows at all, so I suppose that to be correct, you'll need to check and use the appropriate one for each architecture.
Note that node's os.arch() and process.arch don't give you the system architecture, but rather the one that the node executable was built against. You'll need to use this moduel to get the architecture (the README there explains it in more detail).

@automation-stack?

@frontierpsycho can confirm this.
We only distribute a 32-bit build of our electron app on windows. C:\windows\system32\ fails on a 64-bit system, but works fine from powershell, and checking for and using C:\windows\sysnative\ works fine.

I'm in the same situation: I want to distribute a 32-bit electron app.
I tried to find the time to create a pull request, but it was quicker to just work around this by generating a UUID and saving to disk. I'd still like to get the proper machineId, though.

We're also using ember, so I couldn't be bothered importing non-ember dependencies anyway, so I just simplied and put the code straight in:
        // hardware id, based on node-machine-id and arch
        let is64 = false;
        try {
          is64 = !!requireNode('fs').statSync('C:\\windows\\sysnative');
        } catch(e) {
          // leave as false
        }
        this.set('hardwareId', requireNode('child_process')
          .execSync(`C:\\windows\\${is64 ? 'sysnative' : 'system32'}\\reg QUERY HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Cryptography /v MachineGuid`).toString()
          .split('REG_SZ')[1].replace(/\r+|\n+|\s+/ig, ''));

Ugly but works perfectly.

Is there any update on this? I'm also trying to distribute a 32 bit electron app to both 32 bit and 64 bit machines, and came across this issue.

I think it's a standoff between us about who will find the time to submit a pull request first :)

ooops spoke too soon, this seems to work fine v1.1.9. Thanks!

! Thanks for that, I didn't know!

Looks like it was fixed by this commit: dd2ea8ed0a6851e29156163255dcf8976948e1f3 :-)

Version 1.1.12 still exists


Prebuild fixes

I made that big production of how the prebuild command has to be a valid one line shell script and then completely failed to make it a valid one line shell script. No idea what I was thinking that day...
Also, reverted the lzma stuff, #166 should take care of that. After I get that merged and released and Jenkins updated, if you subsequently merge this and then rebase #146, we should be good. I was able to build wheels if you want to test: https://depot.galaxyproject.org/nate/ldaps/

Excellent, thanks!


Configure Maven inside Eclipse

In order to build from command line:

In order to build from Eclipse:
pom.xml
Add astahPath property as /Applications/astah professional/astah professional.app/Contents/Java


Pylance seems to forget the selected interpreter after a (short) while: reportMissingImports

 Environment data

Language Server version: 2023.7.20
VS Code with Remote-SSH
Remote OS and version: ubuntu linux 22.04
Python version: 3.11.4 installed with pyenv
python.analysis.indexing: true
python.analysis.typeCheckingMode: basic

 Code Snippet
import numpy

 Repro Steps

Open the source file.
Select Python interpreter: point to the python executable in the pyenv environment where numpy, matplotlib, pandas, ... are installed.

No warnings and code completion and type info works well.
After some editing, lots of problems are shown because the imports could not be resolved.

Nothing changed to the selected interpreter
However, Pylance trace output shows that (at least part of) Pylance is still using the standard interpreter of Ubuntu.

 Expected behavior
Pylance should only use the selected interpreter.
  Do you perhaps have more than one workspace folder open and you're switching back and forth between files?
This output here says the current interpreter is just 'python3':
2023-07-14 12:25:32.011 [info] [Info  - 12:25:32 PM] (14561)   Executing interpreter: 'python3'
2023-07-14 12:25:32.011 [info] [Info  - 12:25:32 PM] (14561)   Skipping '/usr/lib/python310.zip' because it is not a valid directory
2023-07-14 12:25:32.011 [info] [Info  - 12:25:32 PM] (14561)   Received 4 paths from interpreter
2023-07-14 12:25:32.011 [info] [Info  - 12:25:32 PM] (14561)     /usr/lib/python3.10
2023-07-14 12:25:32.011 [info] [Info  - 12:25:32 PM] (14561)     /usr/lib/python3.10/lib-dynload
2023-07-14 12:25:32.011 [info] [Info  - 12:25:32 PM] (14561)     /usr/local/lib/python3.10/dist-packages
2023-07-14 12:25:32.011 [info] [Info  - 12:25:32 PM] (14561)     /usr/lib/python3/dist-packages

And it oscillates between that setting and the other one in your log:
2023-07-14 12:25:31.311 [info] [Info  - 12:25:31 PM] (14561)   Executing interpreter: '/home/janfr/.pyenv/versions/3.11.4/envs/jkx-3.11.4/bin/python'
2023-07-14 12:25:31.311 [info] [Info  - 12:25:31 PM] (14561)   Skipping '/home/janfr/.pyenv/versions/3.11.4/lib/python311.zip' because it is not a valid directory
2023-07-14 12:25:31.311 [info] [Info  - 12:25:31 PM] (14561)   Received 3 paths from interpreter
2023-07-14 12:25:31.311 [info] [Info  - 12:25:31 PM] (14561)     /home/janfr/.pyenv/versions/3.11.4/lib/python3.11
2023-07-14 12:25:31.311 [info] [Info  - 12:25:31 PM] (14561)     /home/janfr/.pyenv/versions/3.11.4/lib/python3.11/lib-dynload
2023-07-14 12:25:31.311 [info] [Info  - 12:25:31 PM] (14561)     /home/janfr/.pyenv/versions/3.11.4/envs/jkx-3.11.4/lib/python3.11/site-packages

Like one right after the other.
Is this setting on purpose? This might be the cause of the problem:
"python.venvPath": "/home/janfr/.pyenv/versions",

What does your python extension log output look like? Perhaps that setting is causing it to attempt to change the current intepreter continually?
The Python log should show it telling pylance what the interpreter path is. You can turn on trace logging for python with the 'Developer : Set Log Level" command and changing this to Trace:

That should generate output like so in the Python output channel:
2023-07-14 09:13:05.018 [debug] Extension ms-python.vscode-pylance accessed getActiveEnvironmentPath with args: undefined
2023-07-14 09:13:05.021 [debug] Extension ms-python.vscode-pylance accessed resolveEnvironment with args: {"id":"C:\\USERS\\RCHIODO\\SOURCE\\TESTING\\TESTING_PYRIGHT\\.VENV\\SCRIPTS\\PYTHON.EXE","path":"c:\\Users\\rchiodo\\source\\testing\\Testing_Pyright\\.venv\\Scripts\\python.exe"}
2023-07-14 09:13:05.025 [debug] Extension ms-python.vscode-pylance accessed getEnvironmentVariables with args: undefined
2023-07-14 09:13:06.004 [debug] Couldn't locate the conda binary.

Which is the result of Pylance asking the Python extension what the active environment is for a file.

Hi @rchiodo, thanks for helping me out!
I added
"python.venvPath": "/home/janfr/.pyenv/versions",

to the settings in an attempt to make vscode to only use the interpreters in that folder instead of the system Python. But it didn't help, so I'll remove it.
I restarted the Language Server and traced both Python and the Python Language Server.
First everything was ok. At the end, the problem returned: none of installed libraries were found.

Here the Python trace:
python.trace.txt
And the Python Language Server trace:
pylance.trace2.txt
I have Pylanve v2023.7.20 and Python v2023.12.0

The beginning of the log shows we're resolving paths for a notebook. What is the kernel being used in the notebook? That trumps the python interpreter selected for python files.
Additionally, do you have more than one workspace folder open?

And the 'short' while might be the Jupyter extension loading the kernel back into the notebook. Before that happens we don't show any warnings in the notebook.

Indeed, I'm running a notebook next to developing .py files.
The notebook is running on a remote server, so it is a remote kernel, accessed through https://. It has the same Python version and packages installed.
Today I had only one workspace open.

Are the warnings showing up in the notebook or a python file?
If the notebook is using a remote kernel we should be hiding all import errors. In fact, we can't really provide completions and such for a remote kernel because pylance has no idea what's running on the remote machine. But the hiding of errors I believe requires a pretty new version of the Jupyter extension. They have to pass us nothing for the kernel python path.
If the errors are in a python file, then something else is happening. I'd probably likely need to repro locally.

The warnings are showing up in the Python file.
No errors are showing up in the notebooks. I have Jupyter extension v2023.6.1101941928.
I disabled the Jupyter extension a few days ago and the import errors didn't come up again in my Python files.
So the problem is the combination of Pylance and the Jupyter extension (at least using a remote kernel).

Thanks for the response. I have a vague idea of what the problem might be. The jupyter kernel is changing the python path we use to perform analysis. Which makes sense from the notebook's point of view. However, the analysis happens on ALL open files and it's mistakenly applying the same path to the other open files and then pushing new diagnostics for the other files that are open.
I can repro with a jupyter notebook if I set its kernel to a python environment that is missing things that are in the environment used for python files and I open a python file and the notebook.

This issue has been fixed in prerelease version 2023.7.41, which we've just released. You can find the changelog here: CHANGELOG.md

@rchiodo Thanks for the fast resolution!
Is there a way to select the interpreter environment that Pylance uses for the remote jupyter kernel? Or is it now the same as the environment selected for normal .py files?

No each notebook actually has their own 'python environment'. If you select a remote jupyter kernel (like one with an https url), then the environment is the one on the remote machine. However, Pylance knows nothing about this remote environment and is basically disabled for the notebook.  Completions in that case actually come from the kernel itself.
However, the python files will use a local interpreter.
The bug here was that the remote kernel disables any environment for the notebook, but then the analysis of the notebook was also analyzing all the open python files too. And it was doing so with NO environment set, and hence the errors. The fix was to skip errors for files that weren't part of the same environment.

I encountered similar problem. It seems sometimes can not resolve, but sometimes works well.

@GF-Huang, you may be hitting https://github.com/microsoft/vscode/issues/199800. If not, please open a new issue.

@GF-Huang, you may be hitting microsoft/vscode#199800. If not, please open a new issue.

Thanks your guide. It seems the same issue to me. Relative issue (https://github.com/microsoft/pylance-release/issues/5172) for some who need more clue.


Options for (child) properties in object?

Hi,
I've a JSON Schema (transformed by tcomb-json-schema which looks a bit like this:
{
  "schema": {
    "type": "object",
    "properties": {
      "anObject": {
        "type": "object",
        "properties": {
          "aBool": { "type": "boolean" },
          "aString": { "type": "string" }
        }
      }
    }
  }
}

Is there any way I can reach the firstBool and secondBool in my options, e.g. an options object looking a bit like this:
{
  options: {
    fields: {
      anObject: {
        properties: {
          aBool: { label: 'hi' },
          aString: { help: 'This is a string' }
        }
      }
    }
  }
}

Yep. Just replace properties with fields:
options: {
  fields: {
    anObject: {
      fields: { // <= here
        aBool: { label: 'hi' },
        aString: { help: 'This is a string' }
      }
    }
  }
}

Gaah! Could have sworn that I tried that, but I guess I missed it amongst field, properties, props and the rest of the list ;)
Cheers!

In case anyone else finds this I was having a problem getting this to work. If you have a field that is a type t.list() that uses another type with multiple fields. It needs to be nested inside an item element.
The above example should be changed to:
options: {
  fields: {
    anObject: {
      item: {
        fields: {
          aBool: { label: 'hi' },
          aString: { help: 'This is a string' }
        }
      }
    }
  }
}


Add python client docs to docs/, run in CI

Adds a tox target, which runs in CI, which only passes if the
generated version of the python armada client docs are the same
as the version committed.
Adds a new top level page to armadaproject.io (will be added to
menu in separate PR once this merges) containing basic
information about libraries provided for armada usage. This will
be improved significantly over time as we develop examples for
our clients and generally make them more friendly.
Initial commit of generated python armada client docs.

This is part 2 of issue #1027.

This PR exists primarily for early review; it will be rebased against master once g-research/armada#1084 merges.


Danger doesn't post to PRs

Report
What did you do?
I have a private repo whose PRs I want to run danger for. I'm using RVM with a 2.2.x Ruby + Bundler with danger and danger-swiftlint in the Gemfile. I've set up a GitHub user with an access token (all repo permissions) and this user is invited with write access to collaborate on the private repo. I'm running danger as follows:
$ DANGER_GITHUB_API_TOKEN="<token>" rvm ruby-2.2.1 do bundle exec danger pr https://github.com/myorg/myrepo/pull/<pull_id>

What did you expect to happen?
I expected danger to perform the steps in the Dangerfile, then post the result in a comment to the PR.
What happened instead?
Danger executes, finds the PR, properly logs the metadata and all issues to the console, then it exits with error code 0 WITHOUT posting anything to the PR. No errors are printed.
Your Environment
CI: Jenkins (but the issue can also be reproduced from the development machine)
Danger version: 5.2.2
# Warn when there is a big PR
warn("Big PR") if git.lines_of_code > 1000

# run swiftlint
swiftlint.config_file = '.swiftlint.yml'
swiftlint.lint_files

Danger PR is not meant for writing on the issue, its a development tool. You could just use danger.
I wonder if we should add a large warning if ENV["CI"] is set when someone uses danger pr as this is the second time it's come up.

Hmm I see, so what exactly should be set in the environment for danger to recognize a PR? I'm getting Not a Pull Request - skipping ``danger`` run messages on Jenkins, even though the build was triggered by a GitHub PR webhook.

I don't use Jenkins, but I thought it was set up by default for the pull request extension - it looks for these vars: https://github.com/danger/danger/blob/master/lib/danger/ci_source/jenkins.rb#L74

Awesome, thanks for pointing it out, for some reason the ghprbPullId was missing from the env vars, added it and now it works like a charm!

👍

I've updated the docs a bit in https://github.com/danger/danger/pull/829

Rishabh Tayal liked your email
Spark by Readdle


github: rename PR.owner into PR.user

Closing as this is actually not a good idea. PR.user is already there and means "user or org" where the repo which the PR has been made live.


Groups for clear key configuration and open restriction

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Renkon sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

The PR is too large and too stale to be reviewed. Please:

Rebase and squash the commits on top of the dev branch.
Ensure basic style check is done and CI is passed for the first two stages.

Sorry, wrong base branch.


.NET implementation for https://github.com/appwrite/appwrite/issues/1911

@Meldiron the function works fine in my local but when I execute it in appwrite I get the following error. Could you please help?


There is a need to handle options which are not pre-programmed

There needs to be an option to add options which are not pre-programmed in to the library.  I am currently working on some code which needs an option that is not there and thus need to change the library to handle that specific option.  There needs to be a way for an application to add an option  to a message which is not hard coded in and to receive options which are not hard coded.

ARM Internal Ref: IOTCLT-2884

Hi,
Can you please provide code place where you need to this functionality?

I am doing an implementation of https://datatracker.ietf.org/doc/draft-ietf-core-object-security/ which uses an option currently 9.  This option has not yet been finalized so I would not necessarily expect that it would be recognized by your code at this time.  It would still be nice to be able to create and share the code for this with others.  At this time it would require sharing a hacked version of the mbed-os code.  I don't know of any of the OCF people would want to use your library or not, I assume that they are probably using a different one.

This specification https://datatracker.ietf.org/doc/draft-ietf-core-echo-request-tag/ has two more options that I would not expect to see immediate implementation of but which I may want to put into my project as some time.


Develop High-Fidelity User Journey Designs

Develop high-fidelity designs for 2-3 user journeys
See sub-tasks for more details.

:calendar: March Status: progress ongoing. on schedule.


Sous status

Accomplished here: config/serving named servers.
There's some work towards a test of the StatusPoller happy path - it's the only
test currently failing. :)
Goal would be to finish that test (mostly around constructing the right
statusJSON, I think) and confirm that the statuspoller itself works. Incidentally, constructing the JSON by hand is something of an experiment. It may be more effective simply to arrange the appropriate structs and serialize them... We lose some "does it handle incomplete or weird input" there, but I'm unsold on the value.
After that, I'd like to proceed to adding some tests for intermediate states,
making calls directly to StatusPoller/subPoller methods.

Current coverage is 65.06% (diff: 65.62%)

Merging #282 into master will increase coverage by 1.18%

@@             master       #282   diff @@
==========================================
  Files           132        132
  Lines          6700       6721    +21
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           4280       4373    +93
+ Misses         2074       1990    -84
- Partials        346        358    +12

Powered by Codecov. Last update aceb847...8273157

This is, pending automatic review, ready to go.


Slideshow functionality is not working

When trying to setup slideshow functionality from the latest clerk (0.13.842) clerk fails with the error:
Unhandled java.io.FileNotFoundException
Could not locate nextjournal/clerk_slideshow__init.class, nextjournal/clerk_slideshow.clj or nextjournal/clerk_slideshow.cljc on classpath. Please check that namespaces with dashes use underscores in the Clojure file name.

If I manually include clerk_slideshow in deps.edn like:
io.github.nextjournal/clerk-slideshow {:git/sha "562f634494a1e1a9149ed78d5d39fd9486cc00ba"}

the error goes away, but slideshow viewer is not working at all.
Markdown line separators are shown as lines and no "slideshow" is happening.
I have also tried to manually cloning this repo and trying to run against a local clerk setup, but same error about classpath is shown.
I am not sure how to proceed with this issue really.

If I manually include clerk_slideshow in deps.edn like

yes, it's probably not clear from the README, but you have to include this library in your deps in order to require the slideshow viewer. With that in place you should be able to require it e.g. from the notebook namespace
(ns my-slideshow
  (:require [nextjournal.clerk :as clerk]
            [nextjournal.clerk-slideshow :as clerk-slideshow]))

(clerk/add-viewers! [clerk-slideshow/viewer])

Note, you also need to call clerk/add-viewers! in order for it to have an effect.

In addition, using the latest version of this library might help. The one you pasted probably doesn't work in combination with the Clerk version you mentioned. This deps.edn setup actually works
 {:deps {io.github.nextjournal/clerk {:mvn/version "0.13.842"}
        io.github.nextjournal/clerk-slideshow {:git/sha "c7fcc3186790399e0f0090061c24c44200adb872"}}

Please reopen if that doesn't fix your issue.


Make SB2 -> Blockly XML tool

Maybe this tool should live in the VM. For now, it would be really helpful to have a tool that reads an SB2 and turns it into Blockly XML. This will help us get a sense for how projects are going to look when loaded into scratch-blocks.

I think this should be within the VM

If this should be within the VM, it seems like we should work out how the VM will create blocks, categories, etc., in scratch-blocks. Then it seems like we should do this before #443, then? since we'll otherwise be duplicating a lot of work.

Moving to VM


Follow symlinks forever

Changes
It allows symlinks that contain directories with files in them to be followed and built properly.
First mentioned here: https://github.com/snowpackjs/snowpack/discussions/1242
For reference: https://github.com/isaacs/node-glob/issues/139
Testing
Manually with https://github.com/aaronjensen/snowpack-symlink-repro
Docs
No, it's a bug fix.

LGTM!


logs error

Hello,
Describe the bug
When entering in a container to show the logs, it show continuously :
Error grabbing logs: invalid character '\x00' looking for beginning of value
Screenshots

Smartphone (please complete the following information):

Device: Pixel 6
OS: Android 15 build AP4A.241205.013.A2
Application Version : 0.2.0
Portainer 2.21.4

Hey thank you for the feedback,
I believe this is a problem with your actual docker installation, please take a look here
Also be sure you are using the latest apk version, to be sure uninstall, download and install again.
From your screenshot I can't see the container metrics such as memory and cpu usage, which should appear.
Let me know if you happen to find solution to your problem, will keep the issue open for a while.
Sorry for the delay replying, holidays season.
Thank you!


Crashes in libraries

using this library com.github.SpongeBobSun:mCalendarView:6c384cdc8b my calender is worked,i added compile 'com.google.android.gms:play-services-maps:8.3.0',, this error showing
Caused by: android.view.InflateException: Binary XML file line #30: Error inflating class sun.bob.mcalendarview.views.WeekColumnView,, how i solve this issue

You mean that, if you don't add the 'com.google.android.gms:play-services-maps:8.3.0', everything is ok?
Because the WeekColumnView is a very sample class, you can see its code directly.


DevTools attempts to clone uncloneable objects

I am dispatching the state of a react-router Router however it has some instances of a Routes attached on it which for some reason Marty is unable to clone and post into the DevTools frame. Not quite sure how we could handle this!

Just realised this is a copy of https://github.com/jhollingworth/marty/issues/109. Seems like this hasn't gone away fully? I'm using Marty 0.8.12 with the latest dev tools. It only happens when using Immutable state in my stores.

Experienced this as well in version 0.8.13

Currently working on a re-write of DevTools for v0.9 which will include a fix for this issue

In Marty DevTools v0.9 (Will be released once React Router v0.13 is done) we've got the concept of pluggable serialisers that allow you to define your own serialisation process (This was actually @oliverwoodings idea)
MartyDevTools.registerSerializer({
  canSerialize: function (obj) { return true; },
  serialize: function (obj) { ... }
});


Improve test suite robustness

As a Pillarbox developer I want CI workflows to run as fast as possible.
Hints
Look for ``::error` in build logs on GitHub. Some examples of tests that recently failed:

testPausedDvrStream
testPlayerSetToNil
testPlayerChange
testPlaylistEnd
testPreferredAudibleLanguageIsPreservedBetweenItems
testMediaSelectionReset
PlayerItemTrackerMetricPublisherTests.testPlaylist()
MetadataPublisherTests.testEntirePlayback()
ProgressTrackerTimeTests.testEntirePlayback()
ProgressTrackerProgressTests.testEntirePlayback()
ErrorTests.testInvalidStream()
CurrentItemTests.testCurrentItemWithMiddleFailedItem()

Acceptance criteria

The test suites have been optimized to run faster and reliably.

Tasks

[ ] Try to serialize execution and see if tests run better.
[ ] Try to execute test suites separately (player, analytics, core business, etc.) and see if some test suites have more issues.
[ ] Optimize unit tests so that they run faster.
[ ] Improve tests that might still be flaky.

I tried to force GitHub Actions formatting for xcbeautify but this does not make failing expectations more visible in logs. Reverted.

We tested several different approaches in combination:

Serialization with parallel_testing delivers the best stability at the expense of some execution time.
Similar parameters like disable_concurrent_testing, max_concurrent_simulators (set to a minimum meaningful value of 2) do not deliver significant stability improvements.
Replacement of expect equal / similar with expect at least equal / similar to avoid hardcoded timeouts which might more easily be reached on CI agents. This can be an improvement, especially if we want to further reduce the job time.
Rewrite of some tests with arbitrary long delays (e.g. analytics tests which wait 5 seconds). This can be an improvement, especially if we want to further reduce the job time.
Simplification of tests relying on time comparison (loosen tolerances or simple comparison to nil values). This can be an improvement.
Use of alternative HTTP servers or related settings (e.g. using http-server from npm or HTTP version settings). No significant change.
Disable TCP / UDP network offloading, manually or using a corresponding action. Does not seem to improve the situation.
Global Nimble timeout increase. This makes things worse.
Enabling skip_package_dependencies_resolution and skip_package_dependencies_resolution to avoid repeated SPM resolution appearing in the logs. Does not change anything (still visible in the logs).

Note that the most problematic test target is PillarboxPlayer, other targets are much more stable.


Allow docker job to fail

This job requires secrets, and will fail on external PR builds.
Ideally, we should not run this job at all, but until we have such capability, we just allow it to fail.

The feature I mention above is: https://github.com/travis-ci/travis-ci/issues/7181


Switch to 'max-bundle' and 'require' bundle and rtcp-mux policies

Firefox now supports bundle and mux, so we can enable the new policies that ensure these features are used.
cc @pthatcherg

w00t


Create Pages “help-me”

Automatically generated by Netlify CMS

👷 Deploy Preview for gentle-unicorn-6f3e19 processing.

Name
Link

🔨 Latest commit
19897558eb2070ea5462e23eb223a03929acf36f

🔍 Latest deploy log
https://app.netlify.com/sites/gentle-unicorn-6f3e19/deploys/65f9685569e02c0009b6a21e


Refactor rg3d-ui message system to use any data in messages

rg3d-ui still has a rigid set of messages that it can handle with some exceptions for user defined messages. This should be changed to use Box<dyn MessageData> instead of this ugly enum. This is very huge refactoring, but it is pretty straightforward. It also will affect rusty-editor, StationIapetus, rusty-shooter and probably some other user projects.

Overall usability improvements should overweight potential performance implications, which are expected to be quite low.


Nullable.fromOption does not return null for None

None->Nullable.fromOption

should return null, but instead returns undefined, which is not the same. :(

This is actually intended. Maybe it's the naming that's a bit confusing, but Null.t and Null.fromOption would return null for None. Nullable has both undefined and null.
Closing since it's working as intended, but please feel free to continue the discussion.

Related to https://github.com/rescript-lang/rescript-compiler/issues/6533

Yes, this was exactly what got me. The nullable name made me assume it returned null, rather than it being a nomenclature fore both null and undefined coercing to undefined. I also thought null only defined the null constant value. I hadn't noticed Null.t<'a>.


feat: 3941 - refactoring about up-to-date product data for StatefulWidgets

What

Refactoring about up-to-date product data for StatefulWidgets.
The code is a bit cleaner (e.g. less fields).
That gives a better view of future improvements (e.g. being able to say to the user that the nutriscore is perhaps out of sync because for that product there are pending changes on category and we're waiting for the server response cf. #4254)

Fixes bug(s)

Closes: #3941

Files
New file:

up_to_date_manager.dart: Provides the most up-to-date local product data for a StatefulWidget.

Impacted files:

add_new_product_page.dart: now using new class UpToDateManager
edit_new_packagings.dart: now using new class UpToDateManager
edit_ocr_page.dart: now using new class UpToDateManager
edit_product_page.dart: now using new class UpToDateManager
knowledge_panel_page.dart: now using new class UpToDateManager
new_product_page.dart: now using new class UpToDateManager
nutrition_page_loaded.dart: now using new class UpToDateManager
product_image_gallery.dart: now using new class UpToDateManager
product_image_swipeable.dart: now using new class UpToDateManager
product_image_viewer.dart: now using new class UpToDateManager
summary_card.dart: now using new class UpToDateManager

Codecov Report

Merging #4262 (c011380) into develop (1b098d0) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4262      +/-   ##
===========================================
- Coverage    10.87%   10.86%   -0.02%
===========================================
  Files          285      286       +1
  Lines        14170    14187      +17
===========================================
  Hits          1541     1541
- Misses       12629    12646      +17

Impacted Files
Coverage Δ

...smooth_app/lib/data_models/up_to_date_manager.dart
0.00% <0.00%> (ø)

...e_panel/knowledge_panels/knowledge_panel_page.dart
0.00% <0.00%> (ø)

...th_app/lib/pages/product/add_new_product_page.dart
0.00% <0.00%> (ø)

...oth_app/lib/pages/product/edit_new_packagings.dart
0.00% <0.00%> (ø)

...es/smooth_app/lib/pages/product/edit_ocr_page.dart
0.00% <0.00%> (ø)

...mooth_app/lib/pages/product/edit_product_page.dart
0.50% <0.00%> (ø)

...smooth_app/lib/pages/product/new_product_page.dart
0.00% <0.00%> (ø)

...h_app/lib/pages/product/nutrition_page_loaded.dart
0.00% <0.00%> (ø)

.../lib/pages/product/product_image_gallery_view.dart
0.00% <0.00%> (ø)

...ib/pages/product/product_image_swipeable_view.dart
0.00% <0.00%> (ø)

... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


FI-1303/1304 Prevent multiple tests

Codecov Report

Merging #35 (30769fc) into main (c408192) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   93.64%   93.67%   +0.02%
==========================================
  Files          88       88
  Lines        1937     1945       +8
==========================================
+ Hits         1814     1822       +8
  Misses        123      123

Impacted Files
Coverage Δ

...b/inferno/apps/web/controllers/test_runs/create.rb
80.00% <100.00%> (+3.80%)
:arrow_up:

lib/inferno/repositories/test_sessions.rb
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c408192...30769fc. Read the comment docs.

Could you rebase this against main, and force push?  Also, add a description about what has changed and what a reviewer should look out for?  If you've changed the UI,  a screenshot is sometimes nice in the description too in case that helps the reviewer.

Should we have the UI be a little more obvious about what is wrong?  Right now i'm getting a 0/0 progress bar, which seems a little strange.  Also, it looks like we are now issuing a request http://localhost:4567/api/test_runs/undefined?include_results=true, probably because some downstream code is expecting to be returned a test run id always?
Another alternative is to have our regular 'get all test data' query also return if there is an active test run, so the UI can just automatically pick up on the existing running test run (show the progress bar, etc).  We'd just want to be careful that we do that query efficiently then.

@arscan I only get a 0/0 progressBar after refreshing the page during an unfinished run and then trying to run another test. I'm reasonably certain this 0/0 issue is an extension of this ticket: [https://oncprojectracking.healthit.gov/support/browse/FI-1324]. Is this the case for you, or are you getting the 0/0 at another point? I'll have to look into the error more deeply to get a sense of what's happening, but it feels like it's own separate ticket.

@Jack-Fraser16 Yes, I created the 0/0 progress bar by refreshing the page when other tests were running, because that was the most obvious way I could think of exercising the code in this ticket through the UI.  Its a good idea to provide some direction to reviewers on how to observe the change in the PR description.

My bad will fix in the future. I'll repush with clearer directions.

This PR deals with preventing multiple tests both on the back-end and front-end. The back-end change entails checking whether a test run is currently in process and, if true, raising an error on a request to begin another test run. On the front-end,  the run buttons are disabled when a test run is in progress - further, tooltips alerting the user why the buttons are disabled now appear upon hover over a disabled button. The tooltip appearing on every button is a bit overkill, but it gets the message across and I think is solid until we get a UX/UI specialist on the project to come through and clean it up. To view these changes, select the 'Demonstration Suite' on the Inferno landing page. Then, run the 'Wait Group' test to observe the front-end changes. Refreshing the page will cause an alternate issue viewable in the 0/0 of the progressBar, though that is captured in: https://oncprojectracking.healthit.gov/support/browse/FI-1324. Pictures of disabled buttons and tooltip functionality:


[feature] Enable customizing networking library reducing bundle size

Fixes #103 .
Motivation
The core of rest-hooks clocks in at around 7kb gzip. However, there is one part - superagent - which is quite sizable. If someone decides to override their networking library it won't get tree-shaked out due to it being included in the Resource class. This results in what is essentially a doubling of this library's impact on their bundle size.
Solution
Splitting out the fetch implementation to a derived class allows those implementing their own fetch solution to not have to import the superagent fetch solution. This means with tree-shaking superagent will never even be included in the bundle.
Will have a follow blog post to talk about bundle sizes to clear things up since bundlephobia is pretty misleading and we have no desire to make the rest-hooks library worse just to rig artificial metrics that have no bearing in real life.

I'm very open to naming suggestions for the base class. (Known now as SimpleResource)


Add extra documentation for app.import

I struggled for a while to figure out how to import a web worker and eventually stumbled across this merged RFC.
It is very possible this is documented elsewhere and I missed it, but this seems like the appropriate place for the information. 😅

Hey @matteddy 👋  thanks for the contribution.
While I'm not against adding documentation for something that actually works with ember-cli, I'm pretty sure that the "recommended" way to do things is to use ember-auto-import these days 🤔  Did you give it a go? Did that also not work for you?
If ember-auto-import does work for you I wonder if you think we should add something like https://guides.emberjs.com/release/addons-and-dependencies/#toc_regular-npm-packages to the cli-guides as well? 🤔

I think ember-auto-import only helps you out if your file is in an npm package. For serving up individual files in vendor, this is still useful. I vaguely recall that web workers are really particular about how they get imported.
Even if auto-import helped here, the "advanced" section of the CLI guides is where things like this belong, I think. That way, if someone sees it in an app file they didn't write, they can learn something about it. @mansona is it ok with you to merge?

Related conversation for posterity: https://discord.com/channels/480462759797063690/486548111221719040/842424159610077214


Missing plots.

I'm not able to see my and opponent plot.

Also on following turns

My other concern is that when I hover over a revealed plot card it zooms in on the card below it (if any). From those small pictures I cannot sometimes recognize what the opponent's plot is.

There's a pull request in to fix this, I just need to review it and merge it

Fixed in 17d4c7a2fab5478fa4b7d7e43c227e549cc652a0


Cleanup standard streams definitions

Following the memleak fixup, I wanted to go through an audit the streams code for any remaining possible issues. This is the first pass. Much of this is cleanup along the way but there's at least one bug fix in here addressing a UAF. This is ready for review but I'll be doing some extensive testing on it before landing.

Few internal CI failures to investigate before this progresses


Update TD plugin to released version 2.2.2

The ge.gradle.org instance has been upgraded to 2021.4, so merging should be safe.
Following the precedent of assigning to RC milestone.

@bot-gradle test rFM

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Make tab navigation easier when working with many tabs & long tab names

Is your feature request related to a problem? Please describe.
Reported via https://jira.camunda.com/browse/SUPPORT-7415.
When working with many open tabs and long tab filenames, it becomes hard to navigate / maintain overview.
Describe the solution you'd like
Two solution options are seen:

Trim tab description of too many tabs are open and tab names are too long.
Offer dropDown (in case not all tabs can be shown?) to allow quicker tab navigation

See sketch

Describe alternatives you've considered
:arrow_up:
Additional context
https://jira.camunda.com/browse/SUPPORT-7415

In the new Modeler UI architecture, these topics are already considered. They are currently in design development.
A tab action area with access to all opened editors (see "tab context menu"): https://github.com/camunda/camunda-modeler-design/issues/36
A redesigned tab area with tabs that shrink: https://github.com/camunda/camunda-modeler-design/issues/37

Both mentioned design tasks are now defined and ready to review and kickoff.
The feedback from here has been considered: Tabs now have equal widths and a max-width. And a list of opened editors is provided as a dropdown.

Feedback @nikku (2021-12-06) regarding the new tab design: I find it odd that we now truncate tabs in all cases, also when there is sufficient space available (cf. screenshot below).
My expectation would be that truncation is not required in the happy path, i.e. with concisely named diagrams. We do already truncate with newly created diagrams, which looks odd:

For reference, browsers, i.e. Chrome, if taken as a reference, do not truncate per default (which is what I'd expect):

Feedback @nikku (2021-12-06) regarding the new tab design: I find it odd that we now truncate tabs in all cases, also when there is sufficient space available (cf. screenshot below).
My expectation would be that truncation is not required in the happy path, i.e. with concisely named diagrams. We do already truncate with newly created diagrams, which looks odd:

For reference, browsers, i.e. Chrome, if taken as a reference, do not truncate per default (which is what I'd expect):

I agree.
Otherwise the customer who reported the feedback of this issue might likely feel that we actually deprecated quality rathen than increased quality with 5.0.0. cc @andreasgeier @pinussilvestrus

For reference, browsers, i.e. Chrome, if taken as a reference, do not truncate per default (which is what I'd expect):

Chrome also truncates per default as tabs reach a certain max-width. The max-width is just higher as in the new tab design.

What I could imagine is to set our initial tab-width also higher so that the default tab names (diagram_1.bpmn) don't get truncated.

Exactly, I guess we got to find a good place in the middle. My personal favorite would be: Decrease the font size by 1 or 2 pixels, slightly increase the default width.

@pinussilvestrus

What I could imagine is to set our initial tab-width also higher so that the default tab names (diagram_1.bpmn) don't get truncated.

That's a good idea! We can increase the initial width while keeping the other behaviors. Let's do it and change max-width from 160 to 220px.

Closed via https://github.com/camunda/camunda-modeler/pull/2709


Allow setting of env vars for containers

What this PR does / why we need it:
#1946

I can set the KUBECONFIG environment variable as a workaround.

I want to be able to set environment variables to do this workaround.
In addition, I need to be able to mount kubeconfig, but I'm still working on how to specify this in values.yaml, so I'll do a separate PR.
Which issue(s) this PR fixes:
Related to #1946
Does this PR introduce a user-facing change?:

NONE

/cla sign

Thank you.
/lgtm

/trigger presubmits

🚀
/approve


WIP: feat: Add Cloudflare AI Provider

Closes #647
This is a work in progress I wanted to put up for initial feedback. I still need to test it a bunch more locally and update the docs as well.

@typpo Anything else major besides docs that you think might be missing, assuming a correct implementation on my part of the CF API calls?

Note to self, look at https://github.com/promptfoo/promptfoo/pull/711/files for inspiration on examples + docs

@typpo the line changes related to formatting are due to VS code auto-format. I tried to remove then by running npm run format but that command generated a MASSIVE diff so I think you might want to consider enforcing the styling in CI in a separate effort

Nice change!  This looks pretty much ready to go.  Hopefully @CamdenClark can find the time to verify this weekend, otherwise I'll figure out how to get myself set up on Cloudflare AI :)

Nice change! This looks pretty much ready to go. Hopefully @CamdenClark can find the time to verify this weekend, otherwise I'll figure out how to get myself set up on Cloudflare AI :)

I got to it! It works on my machine!
Thanks for taking this up, I got super distracted and forgot to do it :sweat:
In the future it would be cool to get LoRA support but that's not necessary to merge in my opinion.
Feel free to tag me on a non-draft PR if you want another review.

one other thing you might want to know -- I had to build promptfoo on a new machine with node 22 and I got some weird C++ errors with better-sqlite. Might want to put a note recommending node 20

@CamdenClark thanks for testing for me....
@typpo im working now on the docco after fixing the failing tests today. Would you mind please re-triggering the CI test workflow so that I can verify that worked? Assuming thats green, and once I push one more commit for the docs and a few more examples, then this should be good to go (though I'll do a final rebase against master before un-drafting it)

@typpo this is now done and awaiting final review + green CI

🎉 Amazing work @jacobdr and thanks @CamdenClark for helping too!


Feature/746 tabbed cav view

Note:  the div that wraps the map has to have a specific pixel height.  It will not render with a height of 100%.  how do we get this right?
Also: list styles have not been approved by uiux

Looks really good. I love having the list and map views. It will help with accessibility as well.

@sabind @ashwinkjoseph   this is ready to merge to development

@sabind @ashwinkjoseph  ready to merge

dev is blocked until this is merged @ashwinkjoseph

@ashwinkjoseph I moved the containers back to the requests/ container but i had raised the issue before that they should be moved @sabind
(Open|Accepted|Ongoing|Finished|Archived) Requests are all the same page -- same functionality, same code, same person.
Single Responsibility Principle for requests/ module.
"CreateRequest" and "FoundRequests" have a different purpose and structure.  They do not belong in the same module as requests/ pages
https://github.com/reach4help/reach4help/issues/747
Rename FindRequests, NewRequests to CAV_HOME and PIN_HOME #747
These two pages have nothing in common with the other pages in src/modules/requests. Rename them and possibly move to src/landingPage or src/mapView
They either belong in a home folder or a maps folder

@ashwinkjoseph you broke the merge.  you need to unrevert that change


corruption on data-block

my system use this library for msg store. but now i have got a problem when writing data:
leveldb/table: corruption on data-block (pos=13237412): checksum mismatch, want=0x3120352f got=0x81fee9 [file=000428.ldb]
i restarted app got peace for a while.  is there anywhere to fix up even by hand? or it recovered by restart and go wrong quickly?
this is the leveldb log:
14:45:04.187500 log@legend F·NumFile S·FileSize N·Entry C·BadEntry B·BadBlock Ke·KeyError D·DroppedEntry L·Level Q·SeqNum T·TimeElapsed
14:45:04.250000 db@open opening
14:45:04.265625 journal@recovery F·1
14:45:04.796875 journal@recovery recovering @437
14:45:05.015625 mem@flush created L0@440 N·53 S·23KiB "729..918,v851085":"100..635,v851059"
14:45:05.046875 db@janitor F·9 G·0
14:45:05.046875 db@open done T·796.875ms
14:47:02.859375 table@compaction L0·1 -> L1·1 S·10MiB Q·851117
14:47:07.218750 table@build created L1@443 N·24337 S·10MiB "100..:98,v828878":"100..103,v835169"
14:47:07.281250 table@compaction committed F-1 S-547B Ke·0 D·0 T·4.421875s
14:47:07.281250 table@remove removed @440
14:47:07.281250 table@remove removed @439
15:54:59.984375 table@compaction L1·1 -> L2·5 S·329MiB Q·851746
15:55:02.296875 table@build error I·41905 "leveldb/table: corruption on data-block (pos=13237412): checksum mismatch, want=0x3120352f got=0x81fee9 [file=000428.ldb]"
15:55:02.296875 table@build exiting (corruption detected)

You have two options:

Rebuild the database using leveldb.RecoverFile when corruption detected, you can check wether an error is caused by corruption using errors.IsCorrupted
Mask out StrictCompaction and StrictReader strict flag, so that corrupted block will be just ignored instead of throws error, i.e. leveldb.OpenFile("path/to/db", opt.Options{Strict: opt.StrictJournalChecksum | opt.StrictBlockChecksum})


Border Color

Is any way to change the border color.
const borderRight = { right: { style: 'thin', color: { auto: 1 } } }
The above case the output looks  like black border on the right side (cell). I want to change and place different border colour for each cells. Is it possible to change border colour?

HI , are you able to apply any other kind of styles to the cell like bold , or color? If yes , what is the node module you are using and the node version?

@happy0088 I think these features are available only on the pro 💵version ( according to #1268 )

https://stackoverflow.com/questions/50110595/how-to-add-cell-border-to-sheetjs-xlsx-generated-file

Cell Styling, including border styles, are a feature of our Pro builds


The import edu.cmu.minorthird cannot be resolved

there is no package 'edu.cmu.minorthird', and lots of errors show up

I guess we can either remove all references to MinorThird, or add dependencies to their library?
https://github.com/TeamCohen/MinorThird


chore: permit custom format for the NOW placeholder

The placeholder [NOW] and the related one including offsets [NOW +/- offset] can now include a custom format. Here, some examples:
[NOW('%Y-%m-%dT%H:%M:%SZ')]
[NOW('%Y-%m-%dT%H:%M:%SZ') + 10 MINUTES]
[NOW('%Y-%m-%d') - 180 DAYS]
...

Coverage increased (+0.04%) to 89.104% when pulling b5a06da1c03f694731f68654ab2d69cf0d861193 on rmescandon:feat/date_placeholders_permit_custom_format into be8db0af2e83d3554f9f4ab5754eaae792c7724d on Telefonica:master.


port listen

Hello ant,
thank for you awesome job,
we try multiple time the glorytun (tcp version) from OMR and it works great,
I did not succeed in making glorytun udp market (this repo) whether in V0.035, in V0.2.2 or the last stable,
I manage to run the server (virgin kvm machine)
and client (debian 11 blank)
the interfaces are well created (ip a) but after adding the first path (with the TX RX defined) I have no message from GT indicating a connection attempt or whatever, but what to me calls out after having tested with KVM servers under debian, ubuntu from a different supplier I port 5000 bind of course <IP_ADDRESS> but it is never open with netstat, I have this behavior with all the versions, am I missing something?

Hello,
I'm not really sure about your question, but with ss or netstat I see the port:


How to use this in a real project?

Hi,
Whats is the aim of this project?
How to use this in a real project?
Do you have any example?
Thanks.

It provides a more powerful renderer for cocos2dx. Now it's used by https://github.com/Xrysnow/cocos2d-x/tree/gfx and https://github.com/Xrysnow/LuaSTG-x

Nice.
Whats is the difference from original cocos2d-x and other forks like https://github.com/axys1/axys?
Thanks.

There is no much different from the original, you can check its commit history.
axys has a lot of improvment but using the old renderer now. I'm considering porting it to axys later.


Removed key not in catalog filter from dbt and added node filter using AllowDenyPattern

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

The recently added metadata filter "if key not in catalog and load_catalog is False:" is filtering out some valid datasets so I removed the filter and added node filter based on AllowDenyPattern class.

@hsheth2 @vijayan-nallasami-curve the node_type_pattern is definitely good to have, I tested it and it worked as expected.
Also, load_catalog should be renamed load_schemas in the code (it is already named load_schemas in the config file) to avoid confusion.

@remisalmon @vijayan-nallasami-curve - I think it makes sense to merge this and the related https://github.com/linkedin/datahub/pull/2705, and we can refactor and rename the load_catalog variable in a follow up PR


composer should declare the vips extension dependency

We don't declare the dependency on the vips extension in composer.json.
If you add the line:
        , "ext-vips" : ">=0.1.0"

to requires: composer fails with the error:
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested PHP extension ext-vips >=0.1.0 is missing from your system. Install or enable PHP's vips extension.

Even though vips.so is installed and enabled (all the phpunit tests pass).

If I add "ext-vips": ">=0.1.1" in the composer require block then it's working properly. (it's not throwing any errors).
If I change it for example to "ext-vips": ">=0.2.0" (a version number that doesn't exits) then it's throwing a error:
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested PHP extension ext-vips >=0.2.0 has the wrong version (0.1.1) installed. Install or enable PHP's vips extension.

So that works.
Are you sure that composer is executed with the same PHP that has the extension=vips.so in the php.ini? You can try to run php -m for a list of compiled modules and check if it's in there. If not you could check the location of php.ini with php -i (on the top of the output it should tell where the ini file is loaded from) and then add  extension=vips.so to that ini file.

I was doing composer install and having problems. I hadn't realized that the system composer on Ubuntu always runs the system php, it doesn't pick up any local phps from the path. If I do php composer.phar install, it's all fine.
I'll close.


packu instruction not decoded as illegal when extension RV32B=RV32BBalanced

Observed Behavior

packu instruction(encoding with 32'h4822c433) is part of Zbp extension.
When excluding Zbp extension RV32B= RV32BBalanced, we expected packu instruction to be flagged as illegal in decoder
It is not the case from  what is coded in ibex_decoder module:
...
{7'b010_0100, 3'b100}, // packu
{7'b000_0100, 3'b111}, // packh
// RV32B zbs
{7'b010_0100, 3'b001}, // bclr
{7'b001_0100, 3'b001}, // bset
{7'b011_0100, 3'b001}, // binv
{7'b010_0100, 3'b101}, // bext
// RV32B zbf
{7'b010_0100, 3'b111}: illegal_insn = (RV32B != RV32BNone) ? 1'b0 : 1'b1; // bfp
...
Version of the Ibex source code:

I think this observation is correct based on the current B ISA extension. This may have been a change since B was added to Ibex, which was before the 1.0 release. We may want to fix this when we review the B-extension in Ibex in the future. @GregAC any further comments on this?


Fix validation and dynamic block for optional gpu_driver

Fix validation and dynamic block for optional gpu_driver as it errors out on null when the block is not provided.
Checklist
I applicable, I acknowledge that I have:

[X] Read the contributing guide
[X] Ran terraform fmt on all modified files
[ ] Regenerated the relevant README.md files using tools/tfdoc.py
[ ] Made sure all relevant tests pass

Thanks Artur!


cli: Add 'observe' command

Register Hubble's observe command in Cilium CLI. The actual command
is defined in:
https://github.com/cilium/hubble/blob/3369e7d653f002847a61dc1e0d60cbcbe1e1e1f6/cmd/observe/observe.go#L85

Ref: #9925
Signed-off-by: Michi Mutsuzaki<EMAIL_ADDRESS>

This change is

this PR depends on https://github.com/cilium/cilium/pull/10238
wasn't sure if cilium observe is a good name for the command. let me know if anybody has suggestions.

Coverage decreased (-0.04%) to 45.516% when pulling 3e4295edf19e2170b20b95b85b7b1a2f29a62ad8 on pr/michi/cli into 0688f4265413d33f6a7565026130424c64104862 on master.

Observe and monitor seem very similar, we should probably figure out whether we really want both long term and how to avoid confusing users between the two options.

we are exploring other options, maybe keeping hubble-related stuff to a separate command. closing this for now.


chore: update to node 6

The new harp version should allow us to move to the latest LTS node version, 6.
See https://github.com/sintaxi/harp/issues/571

There is also a file in the root for nvm.

Good catch, updated.


Question: disabling for any language except for select few

Hi!
Many thanks for making Neomake!
I'm sorry if this question has been answered before, but how do I enable Neomake only for a restricted set of languages (for instance, ['rust', 'python'])?
I don't want to see lints for C/C++ (and possibly any new language I'd like to use Neovim for), but I dislike the idea of writing down a complete list of "banished languages", like:
let g:neomake_c_enabled_makers   = []
let g:neomake_cpp_enabled_makers = []
" etc...

Is there an elegant way to solve this problem?

Good question.
It depends on how you setup/configure Neomake.
You could for example do something along:
augroup my_neomake
  au!
  autocmd FileType rust,python call neomake#configure#automake_for_buffer('nw', 1000)
augroup END

But also of course more manual using autocmd BufWritePost rust,python Neomake etc.

Let me know how this works for you, and we could add it to the docs.

@blueyed yep, it works, thanks!


Remove hotfix

https://github.com/grafana/tanka/blob/master/pkg/kubernetes/diff.go#L16-L21:
prevent https://github.com/kubernetes/kubernetes/issues/89762 until fixed
This is issue actually is fixed (https://github.com/kubernetes/kubernetes/issues/89762). So might be considerable to remove it.

While the issue is fixed, specific 1.18.0 still contains it. Upgrading to 1.18.1 or downgrading to 1.17.x solves this.
Agreed, we should change to message to reflect this


Bug fix for touch gestures on Windows in Chrome and FF Issue #679

Issue #679

I know there's conflicts in this PR, but will this issue ever be addressed? It still reproduces on Firefox and Chrome devices that have touch events and mouse events (e.g., touch screen windows laptops).
cc @tomasAlabes


Switch default home location to ~/.thelounge

This is a follow-up of #1717 meant to actually change the location. This is not a deprecation, but definitely a breaking change, so making it a v3 PR.

@xPaw, I've added a commit to this PR to stop reading .lounge_home. You might want to give it another review. I thought I did that in another of the v3 PRs, but apparently not.


New Release

The new state within dialogs would really make my life easier. As it is already implemented in master, is there a plan to have a new release?

Just to add to this comment. @nlopes could you make a new release please. There's breaking changes in master since September and any dependency system basically uses tags so everything relying on it breaks. A new release would be appreciated. Thanks!

@asim he doesn't maintain the repository anymore. =) I'll do a new release soon.


wasilibc: add flag for thread support; add extra test case

Description of changes
GHC's wasm backend needs LLVM 16 (due to new flags), bumping the default version for WASM seems like the simplest solution for this. While we're at it, update wasilibc which uses LLVM 16 in release 20 as well.

[ ] Port to at least _git
Tests

[x] firefox (retest)
[x] firefox-esr

[ ] Finish #225000

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

firefox-esr now fails with 010bce9: error: unexpected opcode: 0xfc 0xa
/build/firefox-102.12.0/media/ffvpx/config_unix64.h:219:9: warning: 'HAVE_LINUX_PERF_EVENT_H' macro redefined [-Wmacro-redefined]
#define HAVE_LINUX_PERF_EVENT_H 0
        ^
/build/firefox-102.12.0/mozobj/mozilla-config.h:56:9: note: previous definition is here
#define HAVE_LINUX_PERF_EVENT_H 1
        ^
In file included from <built-in>:2:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil_visibility.h:16:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/log.h:25:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/avutil.h:296:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/common.h:114:
In file included from /build/firefox-102.12.0/media/ffvpx/config.h:52:
In file included from /build/firefox-102.12.0/media/ffvpx/config_common.h:3:
/build/firefox-102.12.0/media/ffvpx/defaults_disabled.h:232:9: warning: 'CONFIG_AV1_PARSER' macro redefined [-Wmacro-redefined]
#define CONFIG_AV1_PARSER 0
        ^
/build/firefox-102.12.0/media/ffvpx/config_unix64.h:681:9: note: previous definition is here
#define CONFIG_AV1_PARSER 1
        ^
In file included from <built-in>:2:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil_visibility.h:16:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/log.h:25:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/avutil.h:296:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/common.h:114:
In file included from /build/firefox-102.12.0/media/ffvpx/config.h:52:
In file included from /build/firefox-102.12.0/media/ffvpx/config_common.h:3:
/build/firefox-102.12.0/media/ffvpx/defaults_disabled.h:233:9: warning: 'CONFIG_AV1_DECODER' macro redefined [-Wmacro-redefined]
#define CONFIG_AV1_DECODER 0
        ^
/build/firefox-102.12.0/media/ffvpx/config_unix64.h:676:9: note: previous definition is here
#define CONFIG_AV1_DECODER 1
        ^
In file included from <built-in>:2:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil_visibility.h:16:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/log.h:25:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/avutil.h:296:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/common.h:114:
In file included from /build/firefox-102.12.0/media/ffvpx/config.h:45:
/build/firefox-102.12.0/media/ffvpx/config_unix64.h:219:9: warning: 'HAVE_LINUX_PERF_EVENT_H' macro redefined [-Wmacro-redefined]
#define HAVE_LINUX_PERF_EVENT_H 0
        ^
/build/firefox-102.12.0/mozobj/mozilla-config.h:56:9: note: previous definition is here
#define HAVE_LINUX_PERF_EVENT_H 1
        ^
In file included from <built-in>:2:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil_visibility.h:16:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/log.h:25:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/avutil.h:296:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/common.h:114:
In file included from /build/firefox-102.12.0/media/ffvpx/config.h:52:
In file included from /build/firefox-102.12.0/media/ffvpx/config_common.h:3:
/build/firefox-102.12.0/media/ffvpx/defaults_disabled.h:232:9: warning: 'CONFIG_AV1_PARSER' macro redefined [-Wmacro-redefined]
#define CONFIG_AV1_PARSER 0
        ^
/build/firefox-102.12.0/media/ffvpx/config_unix64.h:681:9: note: previous definition is here
#define CONFIG_AV1_PARSER 1
        ^
In file included from <built-in>:2:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil_visibility.h:16:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/log.h:25:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/avutil.h:296:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/common.h:114:
In file included from /build/firefox-102.12.0/media/ffvpx/config.h:52:
In file included from /build/firefox-102.12.0/media/ffvpx/config_common.h:3:
/build/firefox-102.12.0/media/ffvpx/defaults_disabled.h:233:9: warning: 'CONFIG_AV1_DECODER' macro redefined [-Wmacro-redefined]
#define CONFIG_AV1_DECODER 0
        ^
/build/firefox-102.12.0/media/ffvpx/config_unix64.h:676:9: note: previous definition is here
#define CONFIG_AV1_DECODER 1
        ^
3 warnings generated.
3 warnings generated.
3 warnings generated.
In file included from <built-in>:2:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil_visibility.h:16:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/log.h:25:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/avutil.h:296:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/common.h:114:
In file included from /build/firefox-102.12.0/media/ffvpx/config.h:45:
/build/firefox-102.12.0/media/ffvpx/config_unix64.h:219:9: warning: 'HAVE_LINUX_PERF_EVENT_H' macro redefined [-Wmacro-redefined]
#define HAVE_LINUX_PERF_EVENT_H 0
        ^
/build/firefox-102.12.0/mozobj/mozilla-config.h:56:9: note: previous definition is here
#define HAVE_LINUX_PERF_EVENT_H 1
        ^
In file included from <built-in>:2In file included from <built-in>:2:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil_visibility.h:16:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/log.h:25:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/avutil.h:296:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/common.h:114:
In file included from /build/firefox-102.12.0/media/ffvpx/config.h:45:
/build/firefox-102.12.0/media/ffvpx/config_unix64.h:219:9: warning: 'HAVE_LINUX_PERF_EVENT_H' macro redefined [-Wmacro-redefined]
#define HAVE_LINUX_PERF_EVENT_H 0
        ^
/build/firefox-102.12.0/mozobj/mozilla-config.h:56:9: note: previous definition is here
#define HAVE_LINUX_PERF_EVENT_H 1
        ^
:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil_visibility.h:16:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/log.h:25:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/avutil.h:296:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/common.h:114:
In file included from /build/firefox-102.12.0/media/ffvpx/config.hIn file included from <built-in>:2::
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil_visibility.h:16:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/log.h:25:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/avutil.h:296:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/common.h:114:
In file included from /build/firefox-102.12.0/media/ffvpx/config.h:52:
In file included from /build/firefox-102.12.0/media/ffvpx/config_common.h:3:
/build/firefox-102.12.0/media/ffvpx/defaults_disabled.h:232:9: warning: 'CONFIG_AV1_PARSER' macro redefined [-Wmacro-redefined]
#define CONFIG_AV1_PARSER 0
        ^
/build/firefox-102.12.0/media/ffvpx/config_unix64.h:681:9: note: previous definition is here
#define CONFIG_AV1_PARSER 1
        ^
In file included from 52<built-in>:2:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil_visibility.h:16:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/log.h:25:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/avutil.h:296:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/common.h:114:
In file included from /build/firefox-102.12.0/media/ffvpx/config.h:52:
In file included from /build/firefox-102.12.0/media/ffvpx/config_common.h:3:
/build/firefox-102.12.0/media/ffvpx/defaults_disabled.h:233:9: warning: 'CONFIG_AV1_DECODER' macro redefined [-Wmacro-redefined]
#define CONFIG_AV1_DECODER 0
        ^
/build/firefox-102.12.0/media/ffvpx/config_unix64.h:676:9: note: previous definition is here
#define CONFIG_AV1_DECODER 1
        ^
:
In file included from /build/firefox-102.12.0/media/ffvpx/config_common.h:3:
/build/firefox-102.12.0/media/ffvpx/defaults_disabled.h:232:9: warning: 'CONFIG_AV1_PARSER' macro redefined [-Wmacro-redefined]
#define CONFIG_AV1_PARSER 0
        ^
/build/firefox-102.12.0/media/ffvpx/config_unix64.h:681:9: note: previous definition is here
#define CONFIG_AV1_PARSER 1
        ^
In file included from <built-in>:2:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil_visibility.h:16:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/log.h:25:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/avutil.h:296:
In file included from /build/firefox-102.12.0/media/ffvpx/libavutil/common.h:114:
In file included from /build/firefox-102.12.0/media/ffvpx/config.h:52:
In file included from /build/firefox-102.12.0/media/ffvpx/config_common.h:3:
/build/firefox-102.12.0/media/ffvpx/defaults_disabled.h:233:9: warning: 'CONFIG_AV1_DECODER' macro redefined [-Wmacro-redefined]
#define CONFIG_AV1_DECODER 0
        ^
/build/firefox-102.12.0/media/ffvpx/config_unix64.h:676:9: note: previous definition is here
#define CONFIG_AV1_DECODER 1
        ^
3 warnings generated.
3 warnings generated.
3 warnings generated.
3 warnings generated.
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/media/libdav1d'
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/media/ffvpx/libavcodec/x86'
3 warnings generated.
3 warnings generated.
3 warnings generated.
3 warnings generated.
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/toolkit/components/places'
rm -f rlbox.wasm
/nix/store/7k0niyhlmadcs30pcb462diwkdb9kadc-wasm32-unknown-wasi-clang-wrapper-16.0.6/bin/wasm32-unknown-wasi-c++ --sysroot=/nix/store/33cpnqkbwy26jdd88gjx67d828d4j9hi-wasi-sysroot -o rlbox.wasm -Wl,--export-all -Wl,--stack-first -Wl,-z,stack-size=262144 -Wl,--no-entry -Wl,--growable-table ogg_alloc.wasm ogg_bitwise.wasm ogg_framing.wasm xmlparse.wasm xmlrole.wasm xmltok.wasm wasm2c_sandbox_wrapper.wasm mozHunspellRLBoxSandbox.wasm affentry.wasm affixmgr.wasm csutil.wasm hashmgr.wasm hunspell.wasm phonet.wasm replist.wasm suggestmgr.wasm GraphiteExtra.wasm CmapCache.wasm Code.wasm Collider.wasm Decompressor.wasm Face.wasm FeatureMap.wasm FileFace.wasm Font.wasm GlyphCache.wasm GlyphFace.wasm Intervals.wasm Justifier.wasm NameTable.wasm Pass.wasm Position.wasm Segment.wasm Silf.wasm Slot.wasm Sparse.wasm TtfUtil.wasm UtfCodec.wasm call_machine.wasm gr_char_info.wasm gr_face.wasm gr_features.wasm gr_font.wasm gr_logging.wasm gr_segment.wasm gr_slot.wasm json.wasm RLBoxWOFF2Sandbox.wasm table_tags.wasm variable_length.wasm woff2_common.wasm woff2_dec.wasm woff2_out.wasm -lwasi-emulated-process-clocks
../../dist/host/bin/wasm2c -o rlbox.wasm.c rlbox.wasm
3 warnings generated.
010bce9: error: unexpected opcode: 0xfc 0xa
make[3]: *** [/build/firefox-102.12.0/config/rules.mk:510: rlbox.wasm.c] Error 1
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/security/rlbox'
make[2]: *** [/build/firefox-102.12.0/config/recurse.mk:72: security/rlbox/target-objects] Error 2
make[2]: *** Waiting for unfinished jobs....
3 warnings generated.
3 warnings generated.
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/tools/profiler'
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/js/src/gc'
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/netwerk/dns'
3 warnings generated.
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/widget'
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/toolkit/components/url-classifier'
3 warnings generated.
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/toolkit/components/reputationservice'
3 warnings generated.
3 warnings generated.
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/security/manager/ssl'
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/toolkit/components/telemetry'
3 warnings generated.
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/media/ffvpx/libavcodec'
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/media/libdav1d/asm'
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/netwerk/base'
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/layout/style'
warning: `webrender` (lib) generated 1 warning (run `cargo fix --lib -p webrender` to apply 1 suggestion)
warning: `style` (lib) generated 1 warning
   Compiling gkrust v0.1.0 (/build/firefox-102.12.0/toolkit/library/rust)
    Finished release [optimized] target(s) in 19m 54s
warning: the following packages contain code that will be rejected by a future version of Rust: bindgen v0.56.0 (/build/firefox-102.12.0/third_party/rust/bindgen), cose v0.1.4, nom v5.1.2
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
make[3]: Leaving directory '/build/firefox-102.12.0/mozobj/toolkit/library/rust'
make[2]: Leaving directory '/build/firefox-102.12.0/mozobj'
make[1]: *** [/build/firefox-102.12.0/config/recurse.mk:34: compile] Error 2
make[1]: Leaving directory '/build/firefox-102.12.0/mozobj'
make: *** [/build/firefox-102.12.0/config/rules.mk:361: default] Error 2
builder for '/nix/store/i2m2akx5zf77cp6zmk2b9y6drks8gxcf-firefox-esr-102-unwrapped-102.12.0esr.drv' failed with exit code 2

Firefox 102 ESR is gone!

Wadilibc 20 is currently on staging-next

Remaining changes are an additional test case and optional, off by default support for the new pthread API in wasilibc.

This looks like it is still applicable and just needs a rebase.


Validation with CACAO json schemas cds03

Currently the CACAO schema validation is performed at schemas at models/validators/schema.go, with the CACAO V2 draft 1. The most up to date is the CACAO V2 draft 3, at: "https://raw.githubusercontent.com/cyentific-rni/cacao-json-schemas/cacao-v2.0-csd03/schemas/playbook.json".
This feature request is to change the schema validation from CACAO V2 draft 1, to CACAO V2 draft 3

FYI, the roaster maintainers also maintain schema's based on the latest spec: https://github.com/opencybersecurityalliance/cacao-roaster/tree/main/lib/cacao-json-schemas/schemas
Maybe they could be helpful at some point.

Aah yes indeed, good one. We should use those actually

Actually to add to this, I remember now that there is yet another repo that should contain the maintained official cacao schemas from the cacao TC: https://github.com/oasis-open/cacao-json-schemas/tree/main/schemas

But those in OCA have a more recent edit