make collection strategy={None, "api"} selectable when run via pytest

The doctest layer allows the choice of strategy={None, "api"}. The pytest layer hardcodes "api". Would be nice to make it selectable in the plugin, too.

This is needed for dev.py -t _impl/file: otherwise all is deselected.
Sadly, this is only testable in a package, as pytest -t path/to/file just works in seld-tests. That make sense: self-tests run on scpdt itself, and it does not have the public/private split.


Datasets using DISC transcriptions should not select 'stressed vowels' subset

ISCAN incorrectly selects a 'stressed vowels' subset in the 'phone subset' enrichment for datasets using DISC transcriptions which do not distinguish stressed vowels:

Ideally this page would look like it does for Buckeye and would not allow a selection of stressed vowels:

The datasets we have which use DISC transcriptions are SOTC, GlasgowBiD & Glaswasian

Additionally, the 'syllabics' subset does not automatically select all the vowels, but a small subset. This should also be fixed.

Bizarre. @MichaelGoodale could you investigate/fix?

So these default subsets weren't using the SPADE config files, but I'm in the process of updating them so that that's the case. From now on it'll use the spade config file, and if that config file is empty (e.g. no stressed vowels), that subset will be empty


Allow sst password to be loaded from an encrypted data bag

The backup/sst user password was previously stored in an encrypted data bag but never used.  This uses it and allows for the wsrep_sst_auth directive to be loaded from node["percona"]["cluster"]["wsrep_sst_auth"] or the backup user in the data bag (in that order as to not created breaking changes)

Tests fail due to things outside the scope of this PR

I am new in this, but to extent I understand it - Shouldn't you rather use "replication" user than backup one when loading the passwords?

@epcim probably but that is not how the cookbook is currently structured.  I did not want to make a change like that in this PR

When using xtrabackup for the SST, the default user is backup


Codepage issue?

Hello,
There is a problem when I try to download videos like this:
https://www.youtube.com/watch?v=79vp65pOM58
But on the disk I get a file named "  (1 )-79vp65pOM58.mp4" instead of "Неуловимый Фунтик (1 )-79vp65pOM58.mp4".

How did you invoke youtube-dl? Post the full verbose log with option -v.

Here is a screenshot. Sorry for delay.

The output goes in cp 437, while the source is using 1251. Maybe that's the problem?

Duplicate of #5045.
This is intentional behavior for now. See #4787 for the rationale and #5527 for alternative solution discussions.


How to use the checkpointer to save replay buffer in the disk?

I found that there are no files in the directory of the checkpointer's folder, neigther /tmp/xxxxx or the specific predefined directory.
I also noticed that the TFCheckpointer class have inferfaces for saving and loading replay buffer, but when i call replay_checkpointer.save() i got the error said "Don't have the attribute 'save' ".
So how to use the checkpointer class or reverb's saver class to save replay buffer in the disk?
Thanks~

(James gave the solution)


Add Chinese (Simplified, PRC) localization

Hi Ardent. Thank you for translating the app into simplified Chinese.
I don't have time to review your PR at the moment, but I appreciate the effort.


Ignore experimental Swift3 tests

Some of these tests are failed sometimes and breaks the CI pipeline. Ignoring the tests was agreed.

We should also ignore the test in Swift3ActionContainerTests in tests/src/actionContainers


fix/tracing

Issue

Solution

Context

Testing Instructions

Release Notes

closing this one, needed to make some changes: see #22 instead


Renamed IPC to IPCRenderer in plugins

*Fixed some IPC listeners to electron v0.35.0 standard
*Moved around some code in Files to be closer to where they're relevant

@DavidVorick @lukechampine this should be pretty uncontroversial


Fix #53: Implement SMS OTP verification

Note that a new DB table ba_sms_authorization has been added to store SMS authorization codes, messages and maintain SMS authorization status. The bank can use this table or provide their own with some changes to the sample code.
There is one TODO left - template and i18n for the message sent in SMS OTP, right now it is generated by code. We should discuss whether the template should come from Web Auth project or Credential Store / Bank Adapter will have its own resources and how will the message language be switched.

Here are requests for testing:
POST http://localhost:8080/powerauth-credential-server-sample/sms/create
{
"requestObject": {
"userId": "12345678",
"operationName": "payment",
"operationData": {
"amount": 100,
"currency": "CZK",
"account": "238400856/0300"
}
}
}
http://localhost:8080/powerauth-credential-server-sample/sms/verify
{
"requestObject": {
"messageId": "76da0913-1201-4f66-9f99-b01f9ad00611",
"authorizationCode": "61443592"
}
}

Updated testing requests:
POST http://localhost:8080/powerauth-credential-server-sample/api/auth/sms/create
{
	"requestObject": {
		"userId": "12345678",
		"operationName": "payment",
		"lang": "cs",
		"operationData": {
			"amount": 100,
			"currency": "CZK",
			"account": "238400856/0300"
		}
	}
}

POST http://localhost:8080/powerauth-credential-server-sample/api/auth/sms/verify
{
	"requestObject": {
		"messageId": "76da0913-1201-4f66-9f99-b01f9ad00611",
		"authorizationCode": "61443592"
	}
}


Add missing doc of X509_REQ_get/add_extensions() [3.1/3.0]

This is a cherry-pick fixing a CI failure I've mistakenly introduced on 3.1/3.0 branches.
(cherry picked from commit 47dc828c6b652feb9cef5b0e4186d010986f197c)
Checklist

[x] documentation is added or updated

This pull request is ready to merge

Merged to the 3.1 and 3.0 branches. Thank you for the reviews.


Bot on AWS hosting

Hi,
I am trying to host my bot c# on AWS.
I am facing an issue in SSL.
I generated certificate from StartSSl.com but it gives an 500 internal server error in BotManagerController.cs when I do 'Test connection to bot'.
I am unable to debug the issue. Please help or recommend what kind of certificates will work for the bot framework? Will certificates from third-arty free sites like StartSsl work?

@afficionaddo you can try cloudflare, getting and setting ssl certificate with cloudflare is easy

You should also be able to verify the SSL certificate for you web site in your browser as well, before even considering it as a web service.

Thanks for the reply @puneetsngh
Buddy do I need to configure anything else? Also the HTTPS cert will be a normal one or something extra property should it have for BotFramework compatibility. Sorry if sound naive!

Thanks for the reply @willportnoy !
Do I need to configure anything else also or just the HTTPS cert apply, verification in browser and i am good to go?

@afficionaddo with regard to SSL, testing the https endpoint in the browser should be sufficient.  Once you have that working, then you'll need to deploy your bot code and make sure bot authentication works as well.

It depends on which OS you're using. If you're using a stock Windows installation from Microsoft, using a browser is probably a decent test. If possible, please try your certificate before buying it.

I'm going to close this issue, but feel free to open a new issue for further discussions.


Plug-in suddenly missing

Hi
I have experienced that sometimes Homebridge simply stops and my iPhone gets no response on all accessories. The error message in the log is saying the homebridge-automower plug-in is not installed. It happened yesterday, and I do not know what triggers this.
When I go into Homebridge Config UI X, I can see that the plug-in is indeed missing. So I simply install the plug-in using Config UI X, and everything works fine again. I do not know why this happens (maybe new release of plug-in?) and therefore I also do not know if this is a problem in automower or Homebridge Config UI X.
However, I never experience this with the other 5 homebridge plug-ins I am using.
Thanks.

Hi, last update imposed to clean cahced accessories due to service id changes. Next one will force a reinstall since platform name is changed to be consistent with other plugins.
Might be linked, let me know if it happens again.
Please post exact logs in case it happens again

see #19


Version 0.11.17 not on GitHub

Hello,
I don't see the commits to version 0.11.17 on GitHub, but I got notification for update.
I am not sure if it's not something malicous, could you confirm, that it fine? Thanks!

It would be nice to have the source code again on GitHub to be able to make the adjustments. Currently in the version 0.12.0 the text has went a bit higher for some reason. It would be nice to check, correct it and send PR, what would push this beautiful project forward.

I've been slow to update Github because someone has taken all the code for Itsycal and put it on the App Store as their own work. So far, working with Apple on this has gone nowhere for over a month. It has temporarily soured my enthusiasm for sharing. That said, I will likely update the code again. I'm just not quite ready yet.
Could you please create a new issue for the menubar bug? I will address it there.

That sucks, I hope you will be able to straighten the things up soon!
I have created an issue which corresponds to the mentioned bug. Thanks a lot, closing this issue.


[IMPROVEMENT] Fix slow page load on maps page.

What would you like to share?
On the maps page, we need to load all the users and we do it on getServerSideProps. The result is extremely slow page load. This is a challenging issue that we need to resolve.
Additional information
No response

We have to load all the users to display them on the map. Could we load them in batches (paginated)? For example load 100 at a time with a progress bar

But it should be automatic right? The api should be called repeatedly and the new users added and displayed accordingly. This is a method I found on stackoverflow that we can use with your approach. Thankfully the react-leaflet works flawlessly with dynamic state updates.
https://stackoverflow.com/questions/42835692/react-leaflet-add-markers-dynamically

Is the query slow or the map rendering the data slow?  Meaning, do we know if this is a data problem or a leaflet problem?

I think it is slow (similar to the search page) because loading the large dataset takes time

I think it is slow (similar to the search page) because loading the large dataset takes time

I guess what I'm thinking about is the fact that this isn't a lot of points for leaflet and by using marker cluster, we are further decreasing the load on the map as the points aren't all rendering on page load. So, I'm not completely convinced pagination is indicated and also unsure what that will do to the map rendering since it's client side. Untested though, I don't currently have another path to offer just thinking so still work a try if it's not too heavy a lift

I think it is slow (similar to the search page) because loading the large dataset takes time

I guess what I'm thinking about is the fact that this isn't a lot of points for leaflet and by using marker cluster, we are further decreasing the load on the map as the points aren't all rendering on page load. So, I'm not completely convinced pagination is indicated and also unsure what that will do to the map rendering since it's client side. Untested though, I don't currently have another path to offer just thinking so still work a try if it's not too heavy a lift

I looked into this on stackoverflow and found that client side state updates work flawlessly on markers. However, I am not sure how performant it is on multiple consecutive state updates but we should definitely try it out.

I looked into this on stackoverflow and found that client side state updates work flawlessly on markers. However, I am not sure how performant it is on multiple consecutive state updates but we should definitely try it out.

Oh amazing! Thank you for checking into this

I put some code together in the static-map branch that should fix this.
I am waiting on #6049 to be merged before creating a PR for more pages using Incremental Static Regeneration.

I am waiting on #6049 to be merged before creating a PR for more pages using Incremental Static Regeneration.

OMG sorry Dan, I completely forgot, I will do this first thing tomorrow morning


pls fix the 'werkzeug' library

  File "/usr/local/lib/python3.6/dist-packages/robobrowser/browser.py", line 8, in <module>
    from werkzeug import cached_property
ImportError: cannot import name 'cached_property'

Just commit #97 to fix this

bump

bump.
Please fix / commit the fix.

I have fixed it and it is available for the pip install with the package name of robobro which would install robobrowser.
Would be removing it once the owner commits the changes to the original package robobrowser.

@andersonneo67 hey, I've tried using your fix and it still gives me the same error :/ . Does its source code come from your robobrowser directory? Because upon inspection the browser.py line 8
from werkzeug import cached_property
hasn't been changed into
from werkzeug.utils import cached_property

you could try uninstalling the already installed robobrowser
1 step : pip uninstall robobrowser ,other
2 step: pip install robobro
Robobro is same as the robobrowser with the werkzeug fix
This should do the update and then you can import the package the usual way

@andersonneo67 hey, I've tried using your fix and it still gives me the same error :/ . Does its source code come from your robobrowser directory? Because upon inspection the browser.py line 8
from werkzeug import cached_property
hasn't been changed into
from werkzeug.utils import cached_property

you could try uninstalling the already installed robobrowser
1 step : pip uninstall robobrowser ,other
2 step: pip install robobro
Robobro is same as the robobrowser with the werkzeug fix
This should do the update and then you can import the package the usual way

Could contact me on whatsapp +919113237818
If any queries about that fix :) happy to help

@andersonneo67 The owner seems to have abandoned this project. Have you considered forking and maintaining it? I like this library and it would be nice to have a new "official" repository that can accept fixes in case something breaks.

Another solution is to downgrade werkzeug from version >=1 to version 0.16.1.
pip uninstall werkzeug
pip install werkzeug==0.16.1
The reason for the import error is because werkzeug new version is not backward compatible.

Another solution is to downgrade werkzeug from version >=1 to version 0.16.1.
pip uninstall werkzeug
pip install werkzeug==0.16.1
The reason for the import error is because werkzeug new version is not backward compatible.

Another solution is to downgrade werkzeug from version >=1 to version <1.
pip uninstall werkzeug pip install werkzeug==0.16.1
The reason for the import error is because werkzeug new version is not backward compatible.

This is a solid fix and useful, though I would not use this library going forward outside of quick scripts which you won't heavily rely upon.


Added item flags

Incase you wonder, yes i tested this with Timespinner
New server, new multiword data (then server sends the correct flags)
New server, old multiword data (then the server just sends "flags": 0
Old server, old multiword data (then server sends no flags)
in all cases, no crashed and flags where either deserialised to the correct flags or to 0 aka None


App isn't remove on Delete until refresh

Rancher versions: 6/5
Steps to Reproduce:

Deploy a template
Go to Application main page and delete the "app"

Results:  App stays showing until refresh browser.

@westlywright route needs to return a live array filtered in the controller instead of filtered in the route.

Version - 6/12 (2.0 alpha)
Verified fixed


MB-16219 Allow address customization in shipment_address_update

Jira ticket
Summary
This brief PR adds the ability to customize the two addresses associated with a shipment_address_update. It also makes use of this functionality to ensure the original and new addresses differ from one another in the shipment_address_updates created by the factory (devseed).
To Validate

Run make db_dev_fresh and ensure there are no errors
Look in the database to ensure the new and original addresses assiocated with a shipment_address_update are different from one another. You can use the below query to ensure the postal_codes differ:

SELECT oa.postal_code, na.postal_code FROM shipment_address_updates sau
	Left Join addresses na on sau.new_address_id = na.id
	Left Join addresses oa on sau.original_address_id = oa.id

Messages

:book:
:link: MB-16219

  Generated by :no_entry_sign: dangerJS against 3ef52a443f1005fdf329c3ac657e72492d322cbb


Add @paulodamaso as fan

@yegor256/z please, pay attention to this pull request

@paulodamaso/z this pull request is too small, just 1 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @yegor256/z please review this and merge or reject

@paulodamaso thanks!

The job is not in WBS, won't close the order


packagecloud key is expired since 2018-10-08

Hello,
The GPG key delivered by https://packagecloud.io/github/git-lfs/gpgkey expired in October 2018:
/tmp➤ wget https://packagecloud.io/github/git-lfs/gpgkey
--2021-01-05 13:15:57--  https://packagecloud.io/github/git-lfs/gpgkey
Loaded CA certificate '/etc/ssl/certs/ca-certificates.crt'
Resolving packagecloud.io (packagecloud.io)... 2600:1f1c:2e5:6901:2d15:30a5:c746:c02d, 2600:1f1c:2e5:6900:da62:ff28:8bff:54ed, <IP_ADDRESS>, ...
Connecting to packagecloud.io (packagecloud.io)|2600:1f1c:2e5:6901:2d15:30a5:c746:c02d|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://d28dx6y1hfq314.cloudfront.net/1358/1665/gpg/github-git-lfs-6B05F25D762E3157.pub.gpg?t=1609849257_5234f68d051d0dd099cc41e2e80e1e9a88cd9ee8 [following]
--2021-01-05 13:15:57--  https://d28dx6y1hfq314.cloudfront.net/1358/1665/gpg/github-git-lfs-6B05F25D762E3157.pub.gpg?t=1609849257_5234f68d051d0dd099cc41e2e80e1e9a88cd9ee8
Resolving d28dx6y1hfq314.cloudfront.net (d28dx6y1hfq314.cloudfront.net)... 2600:9000:2190:ba00:1a:455d:3600:21, 2600:9000:2190:3e00:1a:455d:3600:21, 2600:9000:2190:3a00:1a:455d:3600:21, ...
Connecting to d28dx6y1hfq314.cloudfront.net (d28dx6y1hfq314.cloudfront.net)|2600:9000:2190:ba00:1a:455d:3600:21|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 3941 (3,8K) [text/plain]
Saving to: ‘gpgkey’

gpgkey                  100%[==============================>]   3,85K  --.-KB/s    in 0s

2021-01-05 13:15:58 (83,4 MB/s) - ‘gpgkey’ saved [3941/3941]

/tmp➤ gpg gpgkey
gpg: WARNING: no command supplied.  Trying to guess what you mean ...
pub   rsa4096 2018-10-08 [SCEA]
      6D398DBD30DD78941E2C4797FE2A5F8BDC282033
uid           https://packagecloud.io/github/git-lfs (https://packagecloud.io/docs#gpg_signing<EMAIL_ADDRESS>sub   rsa4096 2018-10-08 [SEA]

Is there a new Key available?

Wrong Repository -.-

Wrong Repository -.-


Adds support for SPFx v1.18.2. Closes #5690

Adds support for SPFx v1.18.2. Closes #5690

ready to merge 🚀

Merged manually. Awesome work 👏


Add frames data-model support

After #3,

codegen datatypes and validators for the frames object hierarchy
Add a .frames property to datatypes.Figure
Add validation logic to make sure that a Figure doesn't have both frames and a widget at the same time.

Done in 554abb057b2164d433b9743af348f1b7b268ecce


Pyro docker image

As discussed in #114, it will be nice to have a dockerfile that we can use to build a docker container with pyro and all its dependencies packaged in, specially for running on a GPU. I suppose this will need to wait until we make Pyro public (as pip / git clone will not work with restricted access), but opening this task to keep track of the issue.

@neerajprad let's try to have this ready after the new PyTorch release

Yes, that's next on my task list.


Can we still get a long-term token:

🚨 The issue tracker is not for questions 🚨
If you have a question, please ask it on https://stackoverflow.com/questions/tagged/wechaty
[question]
https://juzibot.wjx.cn/jq/80103105.aspx cannot be filled anymore

@wechaty/juzi

Yes, you can get a long-term WeCom token if you join the contributor program, please feel free to contact me via WeChat(ruirui_0914) and send me the issue.
I will close this issue, feel free to create a new one if you still have any questions.


libpod crashes when numeric gid is not in group file

[//]: # kind bug
Description
When an image config sets config.User to a numeric value (like 1000:1000), but those values do not exist in the container's /etc/passwd and/or /etc/group, libpod is currently breaking.  However, the OCI spec requires converters to copy numeric uid and gid to the runtime config without attempting to look them up.
Steps to reproduce the issue:
$ podman version
Version:       0.11.2-dev
Go Version:    go1.10.3
Git Commit:    "5f6ad82524ca7a3281c8464c84b4f9be4ff90aef"
Built:         Tue Dec  4 11:05:15 2018
OS/Arch:       linux/amd64
$ podman run --rm -it registry.svc.ci.openshift.org/ci-op-zvml7cd6/pipeline:installer --help
error creating temporary passwd file for container 228f6e9943d6f18b93c19644e9b619ec4d459a3e0eb31680e064eeedf6473678: unable to get gid 1000 from group file: no matching entries in group file

with an image built from this.  I'm skipping podman info, because I don't think it matters, and I'm working up a fix for this myself ;).
Describe the results you expected:
A successful container run.

Off topic:

@mheon mheon added the bug label an hour ago

If you want to adjust the issue template, Prow might pick up /kind bug on its own so you don't have to do that manually.  Haven't tested recently though, and I haven't checked to see if the label plugin is enabled for this repo.

I think you're right... I'll poke at it


Check URL before redirect

This is useful to protect users from malicious actors.
These screenshots have taken from Fedilab for Android app but also ProtonMail app has a similar feature.
The ProtonMail solution is better than this one because Proton team didn't implement a "check" button; when you click on a link a popup is showed automatically. So URL check is by default. Afterwards the popup is showed you can choose the proper action.

This si really useful thanks! It has to be included!

@FrontendCrypto bottom drawer or popup?

Well, we are using bottom sheet for almost everything hehe. I'd use it here again.


add pre-push ci checks

this is to save time in the pull request -> ci failure -> fix problems  workflow
It will be a little embarrassing if this doesn't pass CI.

everything is docker now. Should be good to go.


Update documentation links in README.md

Change: http://pythonhosted.org/jams/ to http://jams.readthedocs.io/en/stable/

Thanks for catching that!  Is there anything else to add here, or are you happy if we merge?  (LGTM)

No problem!  Looks good to me, please merge 👍

:shipit: done.  Thanks!


Documentation indicates lnd will run with bitcoind using cookie authentication for RPC, but it throws an error

Background
This is either an issue with the documentation or the implementation:

The lnd documentation states lnd can be run with bitcoind using cookie authentication here: https://github.com/lightningnetwork/lnd/blob/master/docs/INSTALL.md#using-bitcoind-or-litecoind "The auth parameters rpcuser and rpcpass parameters can typically be determined by lnd for a bitcoind instance running under the same user, including when using cookie auth. In this case, you can exclude them from the lnd options entirely."

When running lnd with bitcoind as a backend, if rpcuser and rpcpassword are not set in bitcoind environment, bitcoind uses cookie authentication for rpc as documented here: https://github.com/bitcoin/bitcoin/blob/7fcf53f7b4524572d1d0c9a5fdc388e87eb02416/doc/init.md

When bitcoind is running with cookie authentication for RPC, lnd checks explicity for rpcuser and rpcpassword and if they do not exist an error is generated.  This is implemented on lines 1496-1503 in config.go ... here: https://github.com/bitcoin/bitcoin/blob/7fcf53f7b4524572d1d0c9a5fdc388e87eb02416/doc/init.md

Your environment

version of lnd: lnd version 0.12.1-beta commit=v0.12.1-beta
which operating system (uname -a on *Nix): Linux 5.8.0-1021-raspi #24-Ubuntu SMP PREEMPT Tue Apr 13 11:00:57 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux
version of btcd, bitcoind, or other backend: bitcoind Bitcoin Core version v0.21.0
any other relevant environment details

Steps to reproduce

install run, and sync bitcoind Bitcoin Core version v0.21.0 with no rpcuser or rpcpassword set (forcing bitcoind to use cookie authentication)
install lnd, do not include rpcuser or rpcpassword in .lnd/lnd.conf

Expected behavior

config.go should not throw an error, unless it is not possible (or recommended) for lnd to use bitcoind with cookie authentication

Actual behaviour

Receive this error message:  "unable to load RPC credentials for bitcoind: please set all or none of bitcoind.rpcuser, bitcoind.rpcpass, bitcoind.zmqpubrawblock, bitcoind.zmqpubrawtx"

Can you post your full lnd config here please? It sounds to me like you need to remove the ZMQ parameters from it as well as they are also read from the bitcoin.conf (and the example in the INSTALL.md file is wrong).

Your solution is correct and resolved the issue.  Removing both ZMQ parameters from lnd.conf resulted in this response when running lnd:

Attempting automatic RPC configuration to bitcoind
Automatically obtained bitcoind's RPC credentials

I read the documentation again and it isn't wrong per se, just not very clear. The section could definitely be improved.
Though the error message is pretty clear in what needs to be done IMO. Closing for now, but feel free to add a PR to improve the documentation.

Thank you


Check deprecated node modules

npm WARN deprecated<EMAIL_ADDRESS>All versions below 4.0.1 of Nodemailer are deprecated. See https://nodemailer.com/status/
npm WARN deprecated<EMAIL_ADDRESS>to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

Closed by https://github.com/o2r-project/o2r-muncher/commit/92d3b89d8a2d166c1b79a90e4a8dd2e7e236236e


Fix jirarc projectName with spaces

No hubot-deployments-config.json set up for this repository.
PROJECT NAME= CRM Product Family
PROJECT KEYS [ 'CPED', 'TW', 'PM', 'WE' ]
PROJECT NAMES [ 'Carrier Post Enrollment Development',
  'OneExchange',
  'Project Management ',
  'Web Experience Product Family' ]

It seems only a subset of the expected projects are returned by the await jiraClient.listProjects() call...
No hubot-deployments-config.json set up for this repository.
PROJECT NAME= CRM Product Family
PROJECT KEYS [ 'CPED', 'TW', 'PM', 'WE' ]
PROJECT NAMES [ 'Carrier Post Enrollment Development',
  'OneExchange',
  'Project Management ',
  'Web Experience Product Family' ]

Whereas this jira api call combined with my credentials returns much more (everything)...
https://{{host}}/rest/api/2/project?


move logic which TargetResolver to use into library

How to categorize this PR?

/area dev-productivity
/kind enhancement
/priority 3
What this PR does / why we need it:
Before this change, we had one TargetResolver implementation, which can resolve secret references and should be used if there is a secret reference within the Target. The problem with this approach is that someone from the outside who wants to work with Targets (e.g. when using the results (=exports) of an Installation programmatically) would need to know which TargetResolver implementations exist and when to use which one. The only way to figure this out is by checking usages of the TargetResolver within the Landscaper code.
Since it should be as easy as possible to build upon the exports of an Installation, this logic was moved into the targetresolver package:

There is now a GenericResolver. It implements the TargetResolver interface, but doesn't resolve anything by its own, instead it checks which other implementation to use and calls that one.
The targetresolver package now has a Resolve function that can resolve any Target. It does so by constructing a GenericResolver internally.

While this makes using TargetResolvers significantly easier, there is a disadvantage: Both methods require all arguments that any TargetResolver implementation takes. Currently, there is only one implementation and that only requires a client.Client to access the cluster, but if we add another implementation, e.g. for resolving references to a secret vault, both - the GenericResolver as well as the Resolve function - need to be given the client as well as the vault configuration. They could still be instantiated with a nil vault configuration, but then trying to resolve a secret that references a vault would cause an error. This also means that each new TargetResolver implementation causes a breaking change (for developers) and requires each call to GenericResolver or the Resolve function to be modified.
However, there are two reasons why this is probably not as bad as it sounds:

We used the TargetResolver for quite some time now and did not require any other implementation. It is unlikely that new implementations will be created often in the future.
Whenever a Target is resolved, we usually want it to be resolvable by all supported implementations - I can't imagine a place in the code where it would be fine to be able to resolve just some of the allowed Targets and not all of them (except for tests). This means that wherever Targets are resolved, we would require all arguments for all implementations anyway, so having them all gathered in a single function call is not really a drawback.

Release note:

The `NewResolvedTarget` constructor has moved from the `targetresolver` package to the `v1alpha1` api package. This has been done to avoid import cycles in the refactored `targetresolver` package, but it also makes sense, as the `ResolvedTarget` type is also declared there.

New options for resolving a `Target` have been added to the `targetresolver` package:
1. The package itself now contains a `Resolve` function.
2. There is a new `generic` sub-package containing the `GenericResolver` implementation of the `TargetResolver` interface.
Both of these have the advantage that they contain the logic when to use which TargetResolver implementation (although there currently is only one, but they will be expanded when new implementations are added). It is strongly recommended to use one of these methods instead of using the SecretRefResolver explicitly.

Perhaps when implementing something in controller-utils, we could add unit tests in the main pkg folder. Ok, these tests are not nearby the coding but this is anyhow better than no tests and this is the way to go in most other languages. Perhaps we could add a folder under pkg named contoller-util-testing or something like that.


Make ignoring .ist files for glossaries-extra ...

There has been an accepted pull request recently which added *.ist pattern to the bottom of the TeX.gitignore. I see two issues with this pull request:

The major one: *.ist files are also custom style files for makeindex. Therefore, simply adding *.ist pattern under #glossaries-extra section can be misleading for those who use makeindex but not glossaries-extra. This problem is similar to the *.pdf problem. So, I suggest solving it the same way: let's add a commented line for *.ist files under #glossaries-extra section with an extended comment.

The minor one: there is already #glossaries section in TeX.gitignore. I suggest moving *.ist pattern to this section for easier navigation.

cc @MohHizzani who submitted #3056 - do those changes make sense for you?

glossaries-extra is a different package, but I thinks its okay to move it to glossary section, and yes it may cause a problem form who uses makeindex, but you comment it out
Anyway, these changes are good

Thanks @Anton-Sakovich and @MohHizzani!


unable to add keys to dictionaries

both clerk's integration exaltation and clerk's distillation give an error
log can be found at https://pastebin.com/M3MtZGHF
-this is on the hexxycraft modpack

gonna need more context
What was the value you were trying to insert

still no clue, but try the latest update?

nope it broken

definetly fixed


Support for Azure DevOps Server?

Are there any plans to add support for On-Premises environments of Azure DevOps Server?

@Cj-Scott Yes, you can find it on TFSDemoGenerator Repo. You need to host it in your IIS.

Is this really correct that the same features are in the TFS DemoGenerator project? Can you extract templates with it?

No, we have not extended all the features. It has some limited support with azure devops server.

Would it be a good thing to make this tool work for AzDO Server? Or do you think it is way too much work compared to continue work to implement the missing features in the TFSDemoGenerator?

Shared the repository for TFS demo generator which has limited support and features. We no longer supporting the TFS demo generator. The same source code (with minor changes) might work for later versions of Azure DevOps Server (2020 and 2022).


How can i directly use PhpHtmlParser  (no Composer)

Hi,
until now i 've used PhpHtmlParser via composer, now i can't because i'm working on a poor hosting.
Specifically, i can't understand how to load the library, that is, on which file i need to do the require_once.
Can someone help me ?
Thank you in advance.
PS:
you could write that in the "Basic Usage" guide section

Ok, I solved by myself.
I added the dependencies, namely MyCLabs and stringEncode packages


Update for channel metrics

Proposed Changes

Adds part of #115 and it is a rebased version of #97
Produced via:

./hack/update-deps.sh --upgrade
./hack/update-codegen.sh

/cc @matzew

/ok-to-test

/cc matzew slinkydeveloper

@matzew hitting test_runner.go:159: Couldn't initialize clients: error while retrieving the config-tracing config map: configmaps "config-tracing" in integration tests any idea?

/lgtm
/approve

@matzew @pierDipi the coverage tests in the previous run passed, not sure why it is unstable, my last commit didnt affect yet them they report failure :)

/retest

/test pull-knative-sandbox-eventing-kafka-go-coverage

/lgtm
/test pull-knative-sandbox-eventing-kafka-integration-tests


add a GeoDB downloader file counter

The inconsistent blank spot in the blue numbers column suggests something went wrong with the GeoDB download.

I compared the two large numbers for equality to comfort myself that things were probably okay.
Please add a file counter like you have for other rows. Set it to 0 at the start and increment to 1 when successful.

As a side note, the image in your ReadMe needs to be updated; it doesn't include the blue column with file counts.

Thank you.


Fix #7417

Short description of what this resolves:
Fixes disappearing menuToggle when hideBackButton is true or swipeBackEnable is false.
Changes proposed in this pull request:

Match the code to the intent described in the comment

Ionic Version: 3.x
Fixes: #7417
Details:
Use of Array.some() with the given filter function is not achieving the goal stated in the comment, filter returns "true" on self, contradicting the stated purpose. That results in menu getting disabled even in a single menu configuration, while the intent is to find x>1, while Array.some() finds x>=1.
The fix is to either exclude self from consideration (that is a bit convoluted change to either filter function or the Array), or convert !Array.some() to Array.filter().length < 2 in proposed fix.
Bug in the code was introduced by https://github.com/ionic-team/ionic/commit/ff24152524fabb1aaca0ab7314e2e8ca2bbb7af7
However, the issue seems to be conditional on CSS being applied for "back button" removal, entangling it with hideBackButton and [swipeBackEnabled]="false". Another way to "fix the issue" is remove hideBackButton or [swipeBackEnabled]="false", but it only masks the bug.

Hi there! We're going to be closing this as the repo is now organized for V4. For V3 related issues/PRs, please direct them here
https://github.com/ionic-team/ionic-v3
Thanks!


Try adding badges to Einsum page

x-ref: https://github.com/JuliaPackageComparisons/JuliaPackageComparisons.github.io/issues/4#issuecomment-1872498836
Screenshot:

Wow, this looks amazing! So you suggest we add the badges only to this page, as a test? And if it works out, we can re-use the format?

So you suggest we add the badges only to this page, as a test?

Yes!

And if it works out, we can re-use the format?

I think we need more customization to apply this format to other pages.
Here are some thoughts:

We need to specify the default branch for the "last commit" badge. (https://github.com/badges/shields/issues/6114#issuecomment-1869315714, )
A repository may contain more than one Julia package. (monorepo)

It would be troublesome to maintain these information manually on each page, so it would be nice to have some package database with a CSV file (or just a Julia script?). I have not tried yet, but hfun_* seems able to generate the badges. (Franklin docs: https://franklinjl.org/syntax/utils/#html_functions_hfun_)
I'll make another PR with hfun_* after this PR is merged.

That sounds amazing. I wish you the best of luck in your efforts - stuff like automatically updating badges are essential to making this resource really good.


module_1a: debug

make sure module_1a works on both local and production environments

generate correct pdf and legend result
show result in the map

PDF output seems to be OK now (06ff517)


tests/benchmarks/timing_info doesn't print userspace stats

The test, when built with -DCONF_FILE=prj_userspace.conf, doesn't print out the stats for userspace tests.
Here is the output I get:
starting test - Time Measurement
Timing Results: Clock Frequency: 25 MHz
Interrupt latency                            :1563 cycles , 15630 ns
Heap Free                                    :15115 cycles , 151150 ns
Mutex lock                                   :2707 cycles , 27070 ns
Mutex unlock                                 :3363 cycles , 33630 ns
Timing Measurement  finished
PASS - main
===================================================================
===================================================================
PROJECT EXECUTION SUCCESSFUL
QEMU: Terminated
[100%] Built target run

What's the root cause?

@andrewboie I filter all values which are too big to be true.
If you have a emulator which is cycle accurate you can run this. But this cant be run on qemu_x86 or mps2_an385. The main purpose of this was to get info from the hardware platforms and not emulators. Therefore i believe we can close this.

I filter all values which are too big to be true.

Please get rid of this filter and have it print unconditionally.

Please get rid of this filter and have it print unconditionally.

No, this was asked hence I had to placed it. If you still need it, enable the macro PRINT_ALL_MEASUREMENTS and run.

No, this was asked hence I had to placed it

By who?

I am not able to recollect. This was a long time ago.

@andrewboie I believe we can close this.

Please get rid of this filter and have it print unconditionally.

If you want to leave a warning that some values are suspicious that is fine but just dropping the data with no explanation to the end user is unacceptable


Fix build script for Unity 2018, by using reflection instead of version defines

Changes

Use reflection instead of version defines to see if the addressables package is installed.

Fixes #233
Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Readme (updated or not needed)
[ ] Tests (added, updated or not needed)

Great work! Thank you very much for fixing it across the board.


linuxPackages/ixgbevf: 4.3.4 -> 4.6.1, unbreak

Motivation for this change
Update. Kernel ships it's own version of ixgbevf driver, so this out-of-tree driver should only be used with extremely old kernels.
I've marked it as broken for newer kernels, both because it is broken and no longer of much use.
Related https://github.com/NixOS/nixpkgs/pull/58956
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @peterhoeg

Related Hydra failures: https://hydra.nixos.org/eval/1536115?filter=ixgbevf&compare=1536056&full=1#tabs-still-fail


Set appArmor profile for istio-cni to unconfined

Please provide a description of this PR:
Conditionally set CAP_SYS_PTRACE when repairPods is enabled

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@jaellio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2d8275c5dcc8e1681adc6317281cc4572eabc8cb
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Still looking into whether or not PTRACE is needed for ambient or just repair mode. Want to confirm the ambient and repair mode disabled scenario is covered in testing.

@jaellio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
b172b26ea223cf0fdc083c6b6a6f1a2af07afa80
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jaellio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
b172b26ea223cf0fdc083c6b6a6f1a2af07afa80
link
true
/test integ-ambient

unit-tests-arm64_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test unit-tests-arm64

gencheck_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jaellio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test unit-tests-arm64

gencheck_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test gencheck

integ-ambient_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test integ-ambient

integ-cni_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jaellio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test unit-tests-arm64

gencheck_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test gencheck

integ-ambient_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test integ-ambient

integ-cni_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test integ-cni

lint_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jaellio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test unit-tests-arm64

gencheck_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test gencheck

integ-ambient_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test integ-ambient

integ-cni_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test integ-cni

lint_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test lint

integ-helm_istio
f40f472818adc9fcd9b550bfdc3e901dd38ff025
link
true
/test integ-helm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Approved but it has a do-not-merge label

In response to a cherrypick label: new pull request created: #53947


How would I include assets in a React component?

So I have a partial right now, the code is below (_deal.html.erb). I'm now trying turn that into a React component, but in the partial I have an image_tag "img-avatar-1.png". How would I include that in the React component?
I know one option is to pass it in as a prop, but I'm wondering if there's another way to do it that's easier?

Cordellia Webb

Project Narwhal

Collaborators

                  <%= image_tag "img-avatar-3.png" %>

                <%= image_tag "img-avatar-1.png" %>
                <%= image_tag "img-avatar-1.png" %>
                <%= image_tag "img-avatar.jpg" %>
                <%= image_tag "img-avatar-4.png" %>

March 18th

@chintanparikh If the image is more of a CSS background image, then handle that with CSS.
Otherwise, with image tags, you need to decide if you will use the asset pipeline and fingerprint the images. In that case, you need to pass the image path as a prop.

Here's my solution for anyone who sees this in the future:
Add gem "non-stupid-digest-assets" to Gemfile - this will create two copies of your assets, one which is fingerprinted and one which is not. Note that if you don't supply a whitelist (next step), it will do this for all assets, and will make asset compilation take twice as long.
Next, I created 'config/initializers/non-digest-assets.rb` with the following line:
NonStupidDigestAssets.whitelist += ["*.jpg", "*.png", "*.svg"]

Now I can just reference my images using the path /assets/image_name.jpg

@chintanparikh @jbhatab This might be worth adding to /docs/additional-reading.


Allow auto-fetch of train information

App should allow you to choose how often you want to fetch for new data. This should obviously be done via AJAX.
Will likely implement with React.

Auto-fetch is a possibility, but perhaps only by selecting a checkbox for how frequently you want the page to update itself.

Could be done with web sockets! The server already does the data scraping, so formatting it to send only what's changed to all clients via a websocket shouldn't be too hard to implement.

Good idea, @toish . I'm reluctant to implement this feature because I don't want to hit the GO Transit website with too many requests.


fix: added gitsyncid assignment to DataSource constructor with dataSourceS…

Description

Added gitsyncid assignment to DataSource constructor with dataSourceStorage as argument

PR fixes following issue(s)
Fixes #23816 (partially)
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

[x] Manual
[ ] Jest
[ ] Cypress

Test Plan

To test this, please import an application to a workspace from git and commit the changes that come up in git sync tool. > Check that the datasources dont have their gitsyncid updated as it was happening in the issue https://github.com/appsmithorg/appsmith/issues/23816

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/build-deploy-preview

The issue is fixed, and verified on DP

/ok-to-test

/build-deploy-preview

https://github.com/appsmithorg/appsmith/issues/23822 is also verified on DP and is working fine.

/ok-to-test


bump cpr to 1.10.5

this PR is to resolve the following ERROR:
ERROR: Conflict in cpr/1.10.4:
'cpr/1.10.4' requires 'libcurl/8.2.1' while 'prometheus-cpp/1.1.0' requires 'libcurl/8.4.0'.
To fix this conflict you need to override the package 'libcurl' in your root package.

The libcurl dependency has already been resolved by bumping libcurl. this change shouldn't be required.

The libcurl dependency has already been resolved by bumping libcurl. this change shouldn't be required.

@szmyd
i can not build the latest master branch in my local environment, since cpr and prometheus requires different version of libcurl, which cause a conflict

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0e23f80) 45.16% compared to head (66a0c12) 45.27%.
Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   45.16%   45.27%   +0.11%
==========================================
  Files          54       54
  Lines        3999     4000       +1
  Branches      478      478
==========================================
+ Hits         1806     1811       +5
  Misses       2059     2059
+ Partials      134      130       -4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


SDF <-> USD: USD does not allow to use names with "."

USD does not allow to use names with "." . Some SDF file might contain "." in names, we should replace this "." for something else, maybe "_".
This will generate an error like this:
 Warning: in SdfPath at line 151 of ../hechk/USD/pxr/usd/sdf/path.cpp -- Ill-formed SdfPath
: syntax errorCoding Error: in _IsValidPathForCreatingPrim at line 3303 of /hechk/USD/pxr/usd/usd/stage.cpp -- Path must be an absolute path: <>

Fixed here https://github.com/ignitionrobotics/sdformat/pull/976


Adding FMIL to .gitignore since it's checked out in the source directory

Since the CMake project checks out FMIL in the source directory it's reasonable to provide a default .gitignore that ignores the FMIL directory,

More reasonable would perhaps be using git submodule or git subtree. But if you want to keep CMake pulling git repositories instead of using git primitives, a git ignore seems reasonable

Sure, but FMIL lives in svn and I'm not sure that you can use svn repositories as submodules?

FMIL also lives as GitHub mirror, see https://github.com/svn2github/FMILibrary.

Which is an unofficial poll based mirror and besides that it doesn't mirror tags and the compliance checker is tied to a specific FMIL release tag. If jmodeliga.org would release tar balls one could point to that instead, but they are using zip files (http://www.jmodelica.org/FMILibrary) and as far as I know CMake external projects cannot handle zip files.

git subtree is not tied to any specific git repository though.


typo for variables user_ocid & tenancy_ocid

file https://github.com/oracle-quickstart/terraform-oci-open-lz/tree/master/examples/oci-open-lz/shared/oci-credentials.tfvars.json.template
Has this content:

tenancy_id should be tenancy_ocid
and
user_id should be user_ocid
Regards,

I'll fix it

Fixed & merged


Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './dist/style.css' is not defined by "exports"

Hi,
I am getting this eslint error with the latest version of this package:
Oops! Something went wrong! :(

ESLint: 7.32.0

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './dist/style.css' is not defined by "exports" in /{my workspace dir}/node_modules/allotment/package.json
Occurred while linting /{my workspace dir}/src/pages/{my js file}.js:36
    at new NodeError (node:internal/errors:399:5)
    at exportsNotFound (node:internal/modules/esm/resolve:361:10)
    at packageExportsResolve (node:internal/modules/esm/resolve:697:9)
    at resolveExports (node:internal/modules/cjs/loader:565:36)
    at Module._findPath (node:internal/modules/cjs/loader:634:31)
    at findModulePath (/{my workspace dir}/node_modules/eslint-import-resolver-alias/index.js:99:27)
    at exports.resolve (/{my workspace dir}/node_modules/eslint-import-resolver-alias/index.js:75:10)
    at v2 (/{my workspace dir}/node_modules/eslint-module-utils/resolve.js:116:23)
    at withResolver (/{my workspace dir}/node_modules/eslint-module-utils/resolve.js:121:14)
    at fullResolve (/{my workspace dir}/node_modules/eslint-module-utils/resolve.js:138:22)

Any idea how to fix this? Thanks

Hi @LinKassem. Could you provide some more information about your build environment? Or if it's an eslint error what the rule is?
This is what I currently provide for the exports field:

which I expect to capture paths like allotment/dist/style.css.

Hey! I have the same problem. To provide more context: I've only started to see this error after i started using eslint-import-resolver-alias package with configuration to enable absolute paths.
With node version 16 I got "Deprecation warning" that folder mapping ./dist/ will be deprecated and pattern ./dist/* should be used in package.json file of allotment package.
After i switch to node 18 I got the same error as @LinKassem. When manually changing the pattern in node_modules/allotment/package.json from ./dist/ to ./dist/* im no longer getting this error.
Can i open a PR resolving this issue or do you see any complications @johnwalley ?


Adapt to changes by huawei and small fix

Hi,
Huawei changed their captcha verify URL to now reject non-client user agents.
This PR sets a normal chrome user agent such that the captcha prevalidverify mechanism works again.
Also fixes a bug with captchas not being picked up after they have been correctly solved.
Cheers!

Hi @Spiritreader
Thanks a lot for the new features!


Whether to support Chinese feature names？

Thank you so much for your contribution. Today, I use it for a Chinese dataset which the columns name are Chinese. However, it broken down and output the infomation "UnicodeEncodeError: 'ascii' codec can't encode characters in position 3-13: ordinal not in range(128)". I want to know whether the tools support the Chinese feature names?

I don't think it support Chinese column name so far. Sorry about that.


On-Board SD Card support for LPC11U37H_401 board

On-Board SD Card support for LPC11U37H_401 board, test cases related to SD Card updated too.

For future reference, please use rebase command to update your branch on top of the master.


Fix array port export

When trying to export an array port, sub indexes for that port
were all being set to zero, raising a "exported in/out ports
not sorted" warning and failing the flow creation.

Refer to PR #104 with v2


About optionalDependencies on package.json

It is really necessary to have packages like eslint, mocha, c8, etc. as optionalDependencies. If I'm not ignoring something, it seems that it would be more correct for them to be devDependencies.
I say this because when installing zwave-js-ui as an NPM package it installs 1172 packages and among them I can see for example:
# ls -l /usr/local/lib/node_modules/zwave-js-ui/node_modules/ | grep eslint
drwxr-xr-x    1 root     root            20 Dec 15 21:11 @eslint
drwxr-xr-x    1 root     root            38 Dec 15 21:11 @eslint-community
drwxr-xr-x    1 root     root           256 Dec 15 21:11 conventional-changelog-eslint
drwxr-xr-x    1 root     root           116 Dec 15 21:12 eslint
drwxr-xr-x    1 root     root            96 Dec 15 21:11 eslint-import-resolver-node
drwxr-xr-x    1 root     root           394 Dec 15 21:11 eslint-module-utils
drwxr-xr-x    1 root     root           114 Dec 15 21:11 eslint-plugin-babel
drwxr-xr-x    1 root     root            62 Dec 15 21:11 eslint-plugin-es
drwxr-xr-x    1 root     root           224 Dec 15 21:12 eslint-plugin-import
drwxr-xr-x    1 root     root            86 Dec 15 21:11 eslint-plugin-node
drwxr-xr-x    1 root     root           112 Dec 15 21:11 eslint-plugin-promise
drwxr-xr-x    1 root     root            62 Dec 15 21:12 eslint-plugin-vue
drwxr-xr-x    1 root     root            92 Dec 15 21:11 eslint-rule-composer
drwxr-xr-x    1 root     root            70 Dec 15 21:11 eslint-scope
drwxr-xr-x    1 root     root           164 Dec 15 21:11 eslint-utils
drwxr-xr-x    1 root     root            70 Dec 15 21:11 eslint-visitor-keys
drwxr-xr-x    1 root     root           116 Dec 15 21:11 vue-eslint-parser

# npm -g ls eslint
/usr/local/lib
└─┬<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>deduped
  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>deduped
  ├─┬<EMAIL_ADDRESS>  │ ├─┬<EMAIL_ADDRESS>  │ │ └──<EMAIL_ADDRESS>deduped
  │ └──<EMAIL_ADDRESS>deduped
  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>deduped
  ├─┬<EMAIL_ADDRESS>  │ ├─┬<EMAIL_ADDRESS>  │ │ └──<EMAIL_ADDRESS>deduped
  │ ├──<EMAIL_ADDRESS>deduped
  │ └─┬<EMAIL_ADDRESS>  │   └──<EMAIL_ADDRESS>deduped
  └──<EMAIL_ADDRESS>

Them are there just because:

The term optional dependencies apply to dependencies that won't cause a failure during the installation of an application or project since npm will ignore them if they fail. Whether these dependencies are present or not, the application will still work as expected

I suppose it will be useful for CI, for the rest of the cases I don't quite see the usefulness because those dependencies for production do not seem to be necessary and for development they seem highly recommended (although not required).
I do not know why:
npm install -g --omit=optional zwave-js-ui

Installs the same 1172 dependencies and doesn't skip the optional ones.

Could be an issue with your npm version? What is your npm/nodejs version?

I was previously using nodejs 18, this last weekend I upgraded it to nodejs 20 and retry to install zwave-js-ui with same result.

nodejs: v20.10.0
npm: 10.2.5

I may be missing something here but optional dependencies should be skipped, I will look at this tomorrow, thanks for letting me know 🙏🏻

Great, now it install 445 packages vs previous 1172 packages.

@alexojegu thanks for your feedback Alex glad the issue is now solved 🙌🏻


script error when deploying bot via msbot clone

I have visual studio code and the bot framework sdk installed on my mac and I believe I am running into a script error when trying to run the msbot script to deploy my chatbot to Azure. I am issuing  the following command from the csharp_dotnetcore/02.echo-with-counter/ dir:
msbot clone services -f deploymentScripts/msbotClone -n echobot -l "westus" --subscriptionId MYAZUREGUID
I get back the following error:
Command failed: az account show--subscription MYAZUREGUIDWARNING: Unable to load extension 'botservice'. Use --debug for more information.ERROR: az account: 'show--subscription' is not in the 'az account' command group. See 'az account --help'.
If I try running that command by itself, it fails as expected. However, if I insert a space between "show" and "--subscription", I get back some nice json showing that it works.  Does anyone know where I can find this particular script so that I can add the space myself?

I think I found the problem in the msbot utility.
https://github.com/Microsoft/botbuilder-tools/blob/6499585e8d96584adebd0f4373898ef13a4123e3/packages/MSBot/src/msbot-clone-services.ts#L255
I have reported my bug there and will close this issue.


Cabana: limit X-axis range from settings

display max [n] minutes data in chart, default is 3 minutes.
resolve https://github.com/commaai/openpilot/discussions/26091:

separate setting for the time range on plots instead of just using the cache size. for example, I have lots of RAM, so I want to keep tons of segments in memory, but this makes the plots unusable without zooming. 180s is a good default for this I think

done with the following changes:
1.limit X-axis range from settings.
2.fixed some display issues (e.g, background not refreshed after the line marked moved).
3.refactored chartview to make it easier to support multiple signals in one chart later.


fix: tests for Jest 27

@anmonteiro Thanks, I'm gonna merge this as it unblocks the work in #12. The nix build is failing for some reason, but now that there's opam pipeline at least we can keep checking things work. Could you please help fix it? 🙏


Add all PT members to CODEOWNERS

Proposed Changes
Add all PT members to CODEOWNERS. This gives all Purple Team members the chance to serve as a reviewer for every PR that comes in.
Related Issue(s)
N/A
Testing
N/A
Documentation
N/A
Screenshots/GIFs (optional)
N/A
Checklist

[x] Ran mage runprecommit locally and fixed any issues that arose.
[x] Curated your commit(s) so they are legible and easy to read and understand.
[x] 🚀

@cedowens @godlovepenn @twinvega heads up you'll most likely get a lot of github notification emails for PR activity because as CODEOWNERS members you'll be added to every PR - make sure you set your Github notification settings, configure email filters, etc to match your preferences


support APPEND operation in mp_binarycopy.sas

This will enable a solution for https://github.com/sasjs/fileuploader/issues/9

:tada: This issue has been resolved in version 2.41.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update installation instructions in README.md

This minimal PR documents the installation command. It took me a moment to look it up from the github.com/golang repo. Hopefully this can help save a few moments for others.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you!

Amazing turnaround! 🎆  Thanks @sywhang


Duplicate Entry when save Session into database

I have activate sess_match_ip, but when save to database, its says Duplicate Entry ..... for key 'PRIMARY'.
Is should be unique

'but' is the wrong word to use ... you're getting this error because you've enabled that setting, without reading the manual about it.
http://www.codeigniter.com/userguide3/libraries/sessions.html
Also, please use our forums to ask your questions. We don't provide support here.


WithCors and WithNotAllowedHandler are used at the same time conflict

Is your feature request related to a problem? Please describe.
1.2.3 New cors support, in which the router's SetNotAllowedHandler used exclusively owns the callback function
However, sometimes, due to business needs, the http interface returns a unified standardized format (such as: JSON), including all situations such as NotFound, NotAllowed, Unauthorized, etc.
Currently subject to the implementation logic inside WithCors(), it is impossible to enable WithCors() and WithNotAllowedHandler() on the rest server at the same time
Describe the solution you'd like
WithCors and WithNotAllowedHandler can be enabled at the same time and take effect correctly
Describe alternatives you've considered
Don't use WithCors temporarily
Configure cors at the reverse proxy layer (e.g. nginx)
Additional context
Add any other context or screenshots about the feature request here.

@zfkun would you please give me the demo code?
the status code might be set in each handler, so it's hard to deal with the status code in multiple handlers.
thanks!

ok

demo.api
syntax = "v1"

type (
	LoginReq {
		Account  string `json:"account"`
		Password string `json:"password"`
	}

	LoginReply {
		Id uint32 `json:"id"`
	}
)

service user-api {
	@handler userLogin
	post /user/login (LoginReq) returns (LoginReply)
}

user.go
package main

import (
	"flag"
	"fmt"
	"net/http"

	"demo/internal/config"
	"demo/internal/handler"
	"demo/internal/svc"

	"github.com/tal-tech/go-zero/core/conf"
	"github.com/tal-tech/go-zero/rest"
        "github.com/tal-tech/go-zero/rest/httpx"
)

// Result std response struct
type Result struct {
	Status    int         `json:"status"`
	ErrorCode interface{} `json:"error_code"`
	Error     interface{} `json:"error"`
	Data      interface{} `json:"data,omitempty"`
}

var configFile = flag.String("f", "etc/user-api.yaml", "the config file")

func main() {
	flag.Parse()

	var c config.Config
	conf.MustLoad(*configFile, &c)

	ctx := svc.NewServiceContext(c)
	server := rest.MustNewServer(
		c.RestConf,
		rest.WithCors(),                                                                      // 1
		rest.WithNotFoundHandler(notFoundHandler()),
		rest.WithNotAllowedHandler(notAllowedHandler()),          // 2
		rest.WithUnauthorizedCallback(unauthorizedHandler),
	)
	defer server.Stop()

	handler.RegisterHandlers(server, ctx)

	fmt.Printf("Starting server at %s:%d...\n", c.Host, c.Port)
	server.Start()
}

func notFoundHandler() http.HandlerFunc {
	return func(w http.ResponseWriter, r *http.Request) {
		httpx.OkJson(w, &Result{Status: 0, ErrorCode: 1000, Error: "NOT_FOUND"})
	}
}

func notAllowedHandler() http.HandlerFunc {
	return func(w http.ResponseWriter, r *http.Request) {
		httpx.OkJson(w, &Result{Status: 0, ErrorCode: 1001, Error: "ACCESS_DENY"})
	}
}

func unauthorizedHandler(w http.ResponseWriter, r *http.Request, err error) {
	httpx.OkJson(w, &Result{Status: 0, ErrorCode: 1001, Error: "UNAUTHORIZED", Data: err.Error()})
}

make request
GET /user/login HTTP/1.1
Host: <IP_ADDRESS>:8888
Connection: close
User-Agent: Paw/3.3.0 (Macintosh; OS X/11.2.3) GCDHTTPRequest

response case:

rest.WithCors()

header is ok (include access-Control-*)
but, status code is 404 and body is empty
HTTP/1.1 404 Not Found
Access-Control-Allow-Headers: Content-Type, Origin, X-CSRF-Token, Authorization, AccessToken, Token, Range
Access-Control-Allow-Methods: GET, HEAD, POST, PATCH, PUT, DELETE
Access-Control-Allow-Origin: *
Access-Control-Expose-Headers: Content-Length, Access-Control-Allow-Origin, Access-Control-Allow-Headers
Access-Control-Max-Age: 86400
Vary: Origin
Date: Thu, 18 Nov 2021 12:36:04 GMT
Content-Length: 0
Connection: close

rest.WithCors() + rest.WithNotAllowedHandler()

status code ok (200),  body ok (json string)
but, no access-Control-* headers
HTTP/1.1 200 OK
Content-Type: application/json
Date: Thu, 18 Nov 2021 12:40:17 GMT
Content-Length: 52
Connection: close

{"status":0,"error_code":1001,"error":"ACCESS_DENY"}

You defined as POST, but requested as GET, so 404 is the correct status code.


feat: move hello to foreground once window exists

This checks for the existence of the Windows Hello window (className Credential Dialog Xaml Host) and moves it to the foreground once it is found.
Not the optimal solution yet, as this happens only once per auth process. If the authentication fails (which sometimes happens for whatever reason, #1), the Hello prompt is recreated behind the Terminal and this time stays there as the FocusHelloWindow task has already returned.
A more comprehensive solution would require some form of AutomationEventHandler or usage of the Win32 window hook API, but that's nothing I can dig into right now and even without that, this is already a massive UX improvement.
fix #4

Alright, I also got a version working that, once it moved the Hello window to the foreground, keeps checking every second if it's still in the foreground and if not puts it there again. But

I couldn't verify yet that it actually works when Hello errors because Hello auth didn't fail me yet today 😅
(it does work however when you manually move focus back to the Terminal) Will report back later.
I'm not sure if this is actually desired behavior? I don't think there's a situation where you'd intentionally want to move focus away from the Hello popup without confirming/cancelling it, but not sure, it's definitely quite "pushy" behavior.
(but so are e.g. UAC popups so it should be ok imo)

What you you think @nullpo-head ?

Hi Jonas! Thanks a lot for your big contribution again!!

I couldn't verify yet that it actually works when Hello errors because Hello auth didn't fail me yet today 😅

me neither, but I think we can get the feedbacks from the users in #4.

it's definitely quite "pushy" behavior.

I agree. Why don't we just setting it foreground only once? Do you have any cases where it is not enough?

Do you have any cases where it is not enough?

The issue described in #1, which (unfortunately) happens quite regularly for me, too:
You press "OK" on the Hello prompt, the window disappears but immediately re-appears again with an error message because the face unlock failed for whatever reason. (and keeps failing until you switched to PIN and back to Face Unlock once)
Without the continuous checks, the re-appearing Hello prompt appears in the background, so you got super confusing behavior:
You click OK, Face Unlock disappears, you think you've authenticated successfully but instead the Face Unlock window just hid in the background, which takes some time to realize.
If instead we keep checking the window until the auth is complete, the re-appeared Unlock prompt and its error message are visible in the foreground and you know what's happening. And the only downside is that you can't intentionally let the pending unlock window linger in the background – for normal usage nothing changes, Hello appears, you hit OK/Cancel, done.

Hmm either way, any extension to fix the window in the foreground can and should be part of a separate PR, no need to discuss that before even the basic move-to-foreground functionality is added. This can be merged imo :)
But I'm afraid I can't make the same contribution to @BlackHoleFox's Rust implementation of the HelloAuthenticator as I really don't know a lot about Rust, and especially not how to achieve something akin to C# Tasks in Rust/Win32 :(

Hmm either way, any extension to fix the window in the foreground can and should be part of a separate PR, no need to discuss that before even the basic move-to-foreground functionality is added. This can be merged imo :)
But I'm afraid I can't make the same contribution to @BlackHoleFox's Rust implementation of the HelloAuthenticator as I really don't know a lot about Rust, and especially not how to achieve something akin to C# Tasks in Rust/Win32 :(

Looks like your comment got duplicated, @jonaskuske :rip:
The changes here look somewhat simple so it wouldn't be hard to bring this to Rust. Biggest difference would be a background thread to replace the C# task, but that'd just be something like this. Everything else can come from the windows or windows-sys  crate.

You press "OK" on the Hello prompt, the window disappears but immediately re-appears again with an error message because the face unlock failed for whatever reason. (and keeps failing until you switch to PIN and back to Face Unlock once)

Without the continuous checks, the re-appearing Hello prompt appears in the background, so you got super confusing behavior:

I see. It makes sense.

@jonaskuske It looks this does not work on Windows 11. Even if I move the Window Hello's dialog to the background, it was not moved to the foreground. Do you have any idea why? The window title seems the same, but I'm not sure.
The output of winlister, though I'm not sure what is the best way to get the window's title.
Windows Security	Yes	(984, 586)	(912, 801)	003D082E	Credential Dialog Xaml Host	No	No	No	Yes	00003F24	00001210	C:\Windows\System32\CredentialUIBroker.exe	Microsoftｮ Windowsｮ Operating System	Credential Manager UI Host	10.0.22000.1 (WinBuild.160101.0800)	Microsoft Corporation

BTW, could you rebase your branch to the latest master, please? I've made a change to CI so that it builds the release asset for pull requests for easier review.

It looks this does not work on Windows 11

Oh, that's too bad! Unfortunately I don't have a W11 device to test on... Maybe now's the time to update my SB2?
And yeah, the window className seems to be the same, so not sure what causes this.
But anyway, moving the window to the background manually won't work. I didn't commit the "pushy" implementation that stickies the window in the foreground (though I can if you want), it just moves it there once.

I didn't commit the "pushy" implementation that stickies the window in the foreground (though I can if you want), it just moves it there once.

Ah, I missed that. I'm sorry for that. I now think the both of "pushy" and non-pushy make sense. So, if you're ok, I proceed with merging the current commit. If you want to bring back the behavior, I'll merge this after you make that change. I tested the change on my environment, too. Everything seems to work file. Thanks for your contribution!

See https://github.com/nullpo-head/WSL-Hello-sudo/pull/29, maybe we can get it to work on Windows 11 with one of the methods I tried there. If none of them work, sure, merge this one and we have Windows 10 support at least! :)
Also, ever since using my version here, I haven't seen the random Hello error a single time, so maybe moving the window to the foreground somehow fixes it and thus also makes the pushy behavior obsolete? 🙏 I'd keep it non-pushy for now and maybe add the pushy behavior later, if others still experience the problem even after this is merged.

I just tested locally and it seems to work 👍

maybe we can get it to work on Windows 11 with one of the methods I tried there

This works for me on Windows 11. YMMV 😄

Is there a way to implement this fix ona normal Win11 install or is this just a self-contained/testable type thing for special dev environments?


Test with OpenJDK 8 on Travis

This requires configuring the build run on an Ubuntu 14.04 VM, as OpenJDK 8 is not available on the default VMs.

Looks good. Merge when you're ready.


testGtsamPose3SLAMExampleChordal takes too long for day-to-day testing

26 seconds really slows down the edit/test/debug cycle.  If we need to run a test this big I suggest checking for a special command line argument and only running it when passed, or something.

@dabrahams  I think we could try reducing the number of iterations and find a lowest number of iters to make it converge

If we make it deterministic by using only PRNGs, mightn't it be enough to check that the error follows some prescribed pattern for the first N iterations, rather than testing it all the way to convergence?

Yeah I agree, I can put this on my TODO :)


Add event interceptor to server config.

1.add eventInterceptor interface.
2.add List into configuration.
3.run eventInterceptors when namespace.onEvent.

@mrniko is it possible to look at this PR and possibly merge it?

@yosiat
Yes, if you name it EventListener and add to ClientListeners interface instead of configuration.

@mrniko applied your suggestions here - https://github.com/mrniko/netty-socketio/pull/707


PHP 8.2 compatible?

Does the Slim work with PHP 8.2 properly or are there any known issues?
My PR #3243 adding it to the tests seems to work.

As far as I know, there should be no issue with PHP 8.2.

It was merged so that this issue can be closed.


fix(runtime-core): ensure app instance can be gargabe collected after unmount (close #2907)

When unmounting an app, we need to remove the __vue_app__ property from the container element, otherwise the app instance can't be garbage collected for as long as that element exists.
closes #2907

@Akryum Tagged you for a review as that hook is for devtools. I think it's safe to remove it here. Agree?

@Akryum Tagged you for a review as that hook is for devtools. I think it's safe to remove it here. Agree?


Update dvdstyler to 3.0.3

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 67a528ee5bb7a78777a15755f1192e7a0de2727e. Your contribution is still credited to you.


Routing and

I am having a little trouble trying to get my basic application airborne. I can't seem to make the connection between the initial route and initialization. My route is set up in the router:
    var exported            =this || {};

    function init() {                                                                                // self-contained initialization avoids leaking temp objects into module closure
        router.config({
            useHist         : true,
            root            : "/"+window.location.pathname,

            init: function() {
                /**/console.log("[**] router config init",window.location.pathname);
                appMain.state.view=domvm.view(appMain.View,{ appMain: appMain, router: router });
                appMain.state.view.mount(document.body);
                appMain.state.view.hook({
                    willRedraw: function() {
                        /**/console.log("[**] Redraw App");
                        },
                    didRedraw: function() {
                        /**/console.log("[**] Redraw App done");
                        },
                    });

                router.refresh();
                },
            });
        Object.freeze(exported);
        }

    exported.root=Object.freeze({
        path: "/",

        onenter: function(segs) {
            /**/console.log("[**] Entered root path");
            document.title=setTitle();
            },
        })

    init();

(I use a pattern whereby I assign this to exported and then make separate assignments into exported.)
The console logs:
20:10:10.810 [**] router config init /temjs/App1 AppScript;01:164:235
20:10:10.812 Could not find route1 AppScript;01:37:473

Though what actually displays is "Could not find route", suggesting the trailing 1 in the copied text is a Firefox bug.

Have you looked at https://github.com/leeoniya/domvm#route-module yet?
I would recommend trying the router in hash mode first (useHist: false). Also, setting root            : "/"+window.location.pathname doesn't make sense. Root is a static prefix that will be prepended to all route paths during regex route compilation; it is meant to define a uniform route root and only applies to history mode routing (not hash).

Have you looked at https://github.com/leeoniya/domvm#route-module yet?

Yes, I've read all the docs thoroughly and examined the ThreadIt.js code. I am just missing the immediate connection in setting up the route. I believe I am overlooking something simple, but subtle.
I don't understand the sentence:

The router argument passed to the closure is the same one returned by externally. However, until the closure returns the routes, it is not fully initialized and cannot be used from inside for routing yet. If you [prefer] to keep everything in the closure, you can set up some config

In ThreadIt.js the router returns an entirely different object from the router argument it's given. I basically copied ThreadItRouter, with minor adaptions for my module structure.

I would recommend trying the router in hash mode first

I've already tried it both ways.

Also, setting root : "/"+window.location.pathname doesn't make sense.

It does for once off init of the router if you want it to adapt to an unknown installation location (which I do). I may well be misunderstanding it's use and significance.

only applies to history mode routing (not hash).

Yes, I got that from the docs.
PS: Thanks for this library; I am enthusiastic about building something real with it.

I assume it should be "... returned externally"

yes.

However, in ThreadIt.js the router returns an entirely different object from the router argument it's given

In both cases, the router is the api [1],[2]. Externally and within init it is after route compilation (so can be used for routing). But in the router closure it's not yet fully initialized, cause you havent returned the routes yet (duh).

It does for once off init of the router if you want it to adapt to an unknown installation location (which I do). I may well be misunderstanding it's use and significance.

Here's a different explanation for why this won't work.
Imagine your defined root is /myApp and single defined route path is /threads. The compiled route is /myApp/threads and matched by thr router against window.location.pathname. This is all good and well if your user hits any path initially, not just the root path. If the user lands initially in /myApp/threads, the compiled routes will remain the same.
If you use the window.location.pathname to dynamically define the root, then when the user lands in /myApp/threads, your compiled route will now be /myApp/threads + /threads. So the root must be static because it allows the routes to be compiled uniformly regardless which route the user opens the app in. This does not apply in hash mode because the root is irrelevant since the router simply grabs window.location.hash.
If you have a more complete (but reduced-case) app example, I will be able to help you better.
[1] https://github.com/leeoniya/domvm/blob/master/src/route.js#L114
[2] https://github.com/leeoniya/domvm/blob/master/src/route.js#L126

OK, if I can't resolve it quickly on Monday morning, I'll work up a jsfiddle, and if that doesn't pinpoint it for me, I'll post a link to it. Just thought I might be overlooking something simple.

BTW, it's uniformly how views/vms work.
function MyView(vm, data) {
  // vm is not yet fully initialized here, so cannot be used for `redraw()`
  // until the render() template generator is returned from this closure
  return function() {
     return ["div", "foo"];
  };
}

// externally, the returned vm is initialized
var myVm = domvm.view(MyView, data);

Same with router:
function MyRouter(router, data) {
  // router is not yet fully initialized here, so cannot be used for `goto()` or `refresh()`
  // until the routes are returned from this closure
  return {
    home: {...}
  };
}

// externally, the returned router is initialized
var router = domvm.view(MyRouter, data);

The only distinguishing aspect is that the router's config can take an init callback that runs once the routes have been initialized/compiled. I could add the same init option to the vm's config to have 100% uniformity.

Resolved this problem. I was expecting this to be set since the Router module is typically shown with a leading-uppercase, indicating a constructor. So I wasn't explicitly returning anything from the function.

I would argue that no element of DOMVM, nor it's example should use constructor semantics if they are not, in fact, invoked as a constructor.

Right, they're technically init closures.
In views, this === vm.api, so you can expose view state and methods. Generally though I'm in the this considered harmful camp (especially for JS, where the context can be defined ad-hoc at the call site). In the router this is left alone.
I dont use this in any examples, docs or demos when inside either the route or view closures. I only reference the closure as constructor once in the docs and perhaps it should be removed.
All that being said, I think using Title-case is appropriate. There is no use of new or this anywhere and there should be no assumption that there are such semantics. I would be fine with removing "constructor" wording from the docs, though. For all intents and purposes, these view closures in practice have the same characteristics as constructors...they init once per instance and retain state. There is no reason to make them look like lesser helper functions.
my $0.02.

I'm in the "this considered harmful" camp.

As am I, which is why I have the style that treats all constructors as module initializers and assigns var exported=this at the top and contains all functions within the initializing closure. Except for that one assignment I never use this at all. But I do use new in invoking one of these "module" constructors; that is, in making a "new" module instance.

All that being said, I think using Title-case is appropriate.

With this I will respectfully disagree. Title case is all important in JavaScript to signal something that should be invoked using new. But, hey, it's your lib.

For all intents and purposes, these view closures in practice have the same characteristics as constructors... they init once per instance and retain state.

Then why not simply invoke them as constructors and follow the principle of least surprise? Especially because the surprise is forced on users of the lib, and not limited to its internals.
It's easy enough for me to work-around, but now my code contains a surprising artifact that needs to be explained to each engineer who works on it.

With all that said, if it's limited to the router, it's not that big a deal. But I suspect it applies to all VMs except for pre-constructed ones (static state with injected context).

There is nothing that enforces specific naming conventions in your app code; use whatever case you feel comfortable with. I prefer title-case, so the docs are written this way. The expectations set up by the docs is an orthogonal discussion and has no bearing on the lib's semantics. I see your point, and would be happy to revisit altering the docs if in fact many users turn out to have your expectations.
However, use of the lib in undocumented ways is explicitly undefined and should be considered "subject to change without notice". My semver contract is only to the docs and existing tests. Obviously, at this stage while the docs are sparse, it's hard to know what is intentionally omitted rather than simply incomplete.
Making them real constructors is not currently feasible since domvm.view() does much more than simply execute the closure. I don't want to give the impression that you could simply use new on the view closures because you absolutely cannot.

With all that said, if it's limited to the router, it's not that big a deal. But I suspect it applies to all VMs except for pre-constructed ones (static state with injected context).

It applies to all vms. You simply cannot use new. If you want to use a convention that implies this within your own codebase, then feel free to do so.
For me, there is greater usefulness in seeing which are stateful components and which are render helpers. You can always use a lowercase prefix if you prefer: function vwContent() {...}

There is nothing that enforces specific naming conventions in your app code

Doh! Of course, you are quite right. How's that for pure habit kicking in. I'll need to think about how I want to handle this in my context.
And for that matter, that was something I disliked about Mithril; it's conventions bled into the user's code in several places.

My semver contract is only to the docs and existing tests.

That's fine -- I'd expect nothing more.

I don't want to give the impression that you could simply use new on the view closures because you absolutely cannot.

Hmmm. That raises the question as to under which circumstances the closure will be invoked vs. the VM be simply used. Is that documented yet?

i'm gonna close this, since it no longer relates to routing. we can open a new issue for this discussion if needed.

Was just about to do the same.

Hmmm. That raises the question as to under which circumstances the closure will be invoked vs. the VM be simply used. Is that documented yet?

declarative [myView, data] within another template will invoke it once. and imperative domvm.view(myView, data) will invoke it once. that's the whole story.


x/mobile/cmd/gomobile: RunOnJVM is not available from init functions

In my library, JNI functions are called from Go side. JVM is accessed via a global C variable current_vm. I admit depending this variable is not a good way, but there is no other way to access JNI from Go. Actual code is https://github.com/hajimehoshi/ebiten/blob/master/internal/jni/jni_android.go
I realized that current_vm is not initialized yet when init functions are called. IIUC, current_vm is initialized at SetCurrentContext when the activity's onCreate is called, and this onCreate is called after all init functions are called and before main is called.
Wouldn't it be possible to make JVM available even from init functions? For gomobile-bind, as init functions are automatically called before calling SetCurrentContext, then it might be impossible. If this is impossible, is there other way to call JNI functions from Go side?
As for iOS, Objective-C binding via cgo is available and there is not such problem.

https://github.com/golang/mobile/commit/56e3592fa7a0582e84d783579d2eb8e6114e0312 makes it impossible to access current_vm, which means that calling JNI functions directly is no longer available... :-/

The above problem was solved https://github.com/golang/go/issues/26815
BTW, to use JNI in init() function, I also tried to use JNI_GetCreatedJavaVMs, but failed due to the below message. Adding #cgo LDFLAGS: -ljvm didn't help since libjvm couldn't be found.
gomobile: go build -buildmode=c-shared -o=/var/folders/b7/w11sqqrx7kx6fqfbn24wdsmh0000gn/T/gomobile-work-277134993/android/src/main/jniLibs/armeabi-v7a/libgojni.so gobind failed: exit status 2
# github.com/hajimehoshi/ebiten/internal/devicescale
../ebiten/internal/devicescale/impl_android.go:25: error: undefined reference to 'JNI_GetCreatedJavaVMs'
clang60: error: linker command failed with exit code 1 (use -v to see invocation)

My understanding is that Seq.setContext (gomobile-bind case) tries to initialize the context and invokes a Go function, but this invocation provokes all the init function before setting the context. Then, in order to solve this issue, we'd need to set the context without Go. Is that correct?
CC @hyangah @timcooijmans

Sorry I missed this issue.
Yes that's the way it works at the moment. This change was needed because older versions of gomobile used reflection that was blacklisted by Android. Do you really have to use init() functions? Can't you use your own initX() functions?
You don't have to bind to an activity, you can also do it from a Service or even from the Application. But I guess that doesn't solve your problem.

Hi,

Do you really have to use init() functions? Can't you use your own initX() functions?

I might not, but other people might. I'm developing a library working with gomobile. If a function uses RunOnJVM, the function can be called from main and after but not from init, and this is not a good user experience.

It looks like RunOnJVM disappeared from gomobile? How do we access the application context now?

https://github.com/golang/mobile/blob/35478a0c49da882188b186a3893d45be6ff74327/app/android.go#L72


Error404 medium small format #482

Draft PR for issue 482. Need to resolve:
-Vertical alignment of Error icon with 404 text to match FIGMA.
-Margins of "Oops" message need to be implemented to match FIGMA.

WIP code ready for merge. Does not close issue, but updated test spec for 404 page should enter code base ASAP.


feat(prettier): implement is_next_line_empty_after_index

Current dependencies on/for this PR:

main

PR #1575   👈

This stack of pull requests is managed by Graphite.

Merge activity

Nov 29, 1:37 AM: @Boshen merged this pull request with Graphite.


Standardise margins and padding

Gonna move this into ready, just so someone can have a check over it. Update here if stuff does need doing


USART/USART mode: Missing mode setup

Copied from internal issue tracker:

USART setup is not done properly if the first mode to be entered is the "normal" mode.
When first entering the USART mode, the requested mode is compared against the reset mode, which is the normal USART mode. Therefore, in enter_mode, the check

    if self.mode() == H::MODE {
        // Already in the requested mode
        return;
    }

returns early and leaves my USART uninitialized unless I've switched to some other mode before.
My suggestion would simply be to remove this check, unless there's some really good reason why we wouldn't want to let the user soft-reset the peripheral by switching to the same mode.

CC @axel-grepit


Missing Website functionality for item creation

Use Case
I am trying to use the 1pass API to automatically sync passwords from one of my company's internal tools
Requirements and desired behavior
Allow me to associate a "website" to use for auto-filling.
Additional information
I am happy to contribute this feature on my own, if this repo accepts public contributions (or if it's even possible). If not possible, is there also an ETA on this feature being available?

Hey @nikita-tkachov,
Thank you for the feature request! I'll forward it our product team for prioritization. 😄
Additionally, thank you for your offer to help out! I really appreciate it - unfortunately this feature requires changes to code that's not (yet) open source. We've built the SDKs using a common core that's shared across all programming languages in which we build SDKs. This common core shares a lot of logic with our desktop and mobile applications as well as the browser extension. The development of this core is currently too coupled to internal processes and our closed source repository (of the apps) to easily open source.
While we'd love for this to be available for you and open to contributions, this is not (yet) the case today.
In the meantime, thanks for expressing your interest - gauging the interest for such contributions helps us greatly in prioritizing any initiatives of open-sourcing more of the codebase. 💙

Hi @nikita-tkachov
I’m Sadia, the product manager leading the SDK initiative, it’s nice to meet you. Thank you submitting your feature request and providing more context. I totally understand the urgency given the volume you are managing. While I can’t provide an exact number of weeks, we plan to start work on this in the upcoming month and I’ll make sure to keep you in the loop as we move forward. Thanks again for your patience and understanding!

@nikita-tkachov version 0.1.3 of the JS SDK should now offer the possibility to customize items with autofill websites.
Please let us know if this addresses your use-case - I'll be closing the ticket, but do reopen otherwise!


Decouple from "guzzlehttp/psr7" and "php-http/discovery", replace by "friendsofphp/well-known-implementations"

Related to https://github.com/getsentry/sentry-php/discussions/1411 and https://github.com/FriendsOfPHP/well-known-implementations/issues/2
In this PR, I propose to rely on FriendsOfPHP/well-known-implementations to ensure a working out-of-the-box experience. This package is a composer-plugin that will install the most suited async-http-implementation depending on the existing dependencies of the projects that require sentry-php.
The package also provides a discovery mechanism that covers roughly the same purpose as php-http/discovery, but that plays well with the plugin part of the package.
The attached patch removes php-http/discovery from the mandatory dependencies, but also removes the dependency on guzzlehttp/psr7.

Thanks for proposing this @nicolas-grekas
This is definitely something we will consider when making a decision on the path forward in the next major of the SDK.

@cleptric here is the result of what we talked about at SymfonyCon: https://github.com/php-http/discovery/pull/208