Add documentation

Add documentation to
MedImage_data_struct.jl file

@divital-coder  Describe shortly first enums what they mean; secondly the MedImage struct together with information that it is immutable
@divital-coder show how to change fields using accessors.jl on the basis of the function "update_voxel_and_spatial_data" from Utils.jl

Utils.jl file

@JanZubik describe get_base_indicies_arr as function for convienient cartesian indicies extraction ; give examples of execution and show shapes of the resulting array

@JanZubik cast_to_array_b_type give example that we will change the array of one type to the array of other also example when array a is float and array b is int and describe that the function prevent from getting inexact error message when casting float to Int

@JanZubik interpolate_point - explain convention @JanZubik  that all negative indiciec will be casted to extrapolated value and the we are interpolating points here - show examples to get values from negative indicies, indicies in range of the image and indicies way futher than image physical space (which will be extrapolated)

@JanZubik interpolate_my explain the function particularly stressing what happens at extrapolation, negative indicies, that we deal with non isovolumetric voxels and what are the diffrences between diffrent interpolators - mainly that nearest neighbour is usefull for discrete lebels; linear is fast, b spline give good resolution

@divital-coder  TransformIndexToPhysicalPoint_julia show examples how we can get a point in physical space from indexes and how it will change for images with diffrent spatial metaata values - move origin show how it will affect, change spacin show how it affect, change direction ...

@divital-coder ensure_tuple - just utility function needed becouse we expect in medimage struct tuples not lists show example of usage with list and with tuple

##Spatial_metadata_change.jl
9) @divital-coder  change_orientation function - explain what is orientation show how to get orientation code (using string_to_orientation_enum from orientation_dicts.jl and vice versa using orientation_enum_to_string ), show example that will make it possible to see that changing direction can change order of spacing can change origin and show that it flips image and permute axis

@JanZubik  explain resample_to_spacing - show examples how the resolution of the image changes with diffrent spacing (for example using printscreens from slicer) explain what is the goal and copy here also what interpolators to use in what cases

Resample_to_target.jl

@JanZubik resample_to_image explain what is the goal of the function give some example how it will look like and how changing spatial metadata like changing origin or spacing ... will affect change in the resulting image; consider adding simple schematic you used to understand the concept

##Load_and_save
12) @divital-coder  you know all about topic make descriptions of the functions explain that both dicom and nifti will load into the same format; explain arguments and why setting all files orientation to rAS at the begining may be good idea (standarization)
HDF5_manag.jl

@divital-coder  simple save and load of the MedImage struct describe functions tell why hdf5 format is good (it is explained for example in julia con when hdf5.jl had their talk - it is fast, convinient for multidimensional arrays handling , can load in parts ... )

##Basic_transformations
14) @JanZubik  Jan Zubik you know the issue from bottom up; so just describe all functions and make tests work
tests

@JanZubik resample_to_image, change_orientation and resample_to_spacing has their tests ready but they need to be integrated together with other tests from test_spatial_metadata_change.jl into single test set, look into docs of tests in order to make it work https://docs.julialang.org/en/v1/stdlib/Test/ ; the test set combining all of the tests should be in a separate file, also the path to the test file should be relative - hence automatic testing in future could be run.
@divital-coder if possible change simple itk function invocation from tests into wrapped C++ lib version and get rid of all Pycall conda etc from the package :)

A separate Readme for each of the documented jl files?

basically all medimage docs should be organised using DocumenterVitepress.jl look here https://github.com/orgs/JuliaHealth/projects/3/views/2?pane=issue&itemId=62645761

Yes, I was originally going to ask if I should setup documenter vitepress for medimage.
Sounds good.


BadRequestError: 400 Missing required parameter: 'messages[3].content[0].type'. when tool returns array

I'm getting the error BadRequestError: 400 Missing required parameter: 'messages[3].content[0].type' when calling a custom tool that returns an array.
However, if I wrap it in an object, I do not get an error and it succeeds (see the examples below).
It would be good for tools to support returning an array.  But if that isn't possible, it would be helpful to have a more informative error, maybe something like BadRequestError: 400 Invalid return type: array is not a supported return type.

This tool fails:
import {tool} from "@langchain/core/tools";
import {PrismaClient} from "@prisma/client";

const prisma = new PrismaClient()

export const getClipsterCategories =
    tool(async () => {
        const categories = await prisma.category.findMany()
        return categories
    }, {
        name: "getClipsterCategories",
        description: "Gets product categories from the Clipster database."
    })

This tool succeeds:
import {tool} from "@langchain/core/tools";
import {PrismaClient} from "@prisma/client";

const prisma = new PrismaClient()

export const getClipsterCategories =
    tool(async () => {
        const categories = await prisma.category.findMany()
        return {
            categories
        }
    }, {
        name: "getClipsterCategories",
        description: "Gets product categories from the Clipster database."
    })

Error Details:
BadRequestError: 400 Missing required parameter: 'messages[3].content[0].type'.
    at APIError.generate (webpack-internal:///(rsc)/./node_modules/openai/error.mjs:60:20)
    at OpenAI.makeStatusError (webpack-internal:///(rsc)/./node_modules/openai/core.mjs:304:65)
    at OpenAI.makeRequest (webpack-internal:///(rsc)/./node_modules/openai/core.mjs:347:30)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async eval (webpack-internal:///(rsc)/./node_modules/@langchain/openai/dist/chat_models.js:1378:29)
    at async RetryOperation.eval [as _fn] (webpack-internal:///(rsc)/./node_modules/p-retry/index.js:50:12) {
  status: 400,
  headers: {
    'access-control-expose-headers': 'X-Request-ID',
    'cf-cache-status': 'DYNAMIC',
    'cf-ray': '<REDACTED>',
    connection: 'keep-alive',
    'content-length': '219',
    'content-type': 'application/json',
    date: 'Mon, 23 Sep 2024 14:41:43 GMT',
    'openai-organization': 'user-<REDACTED>',
    'openai-processing-ms': '20',
    'openai-version': '2020-10-01',
    server: 'cloudflare',
    'set-cookie': '__cf_bm=<REDACTED>; path=/; expires=Mon, 23-Sep-24 15:11:43 GMT; domain=.api.openai.com; HttpOnly; Secure; SameSite=None, _cfuvid=i<REDACTED>; path=/; domain=.api.openai.com; HttpOnly; Secure; SameSite=None',
    'strict-transport-security': 'max-age=15552000; includeSubDomains; preload',
    'x-content-type-options': 'nosniff',
    'x-ratelimit-limit-requests': '10000',
    'x-ratelimit-limit-tokens': '200000',
    'x-ratelimit-remaining-requests': '9998',
    'x-ratelimit-remaining-tokens': '199956',
    'x-ratelimit-reset-requests': '16.106s',
    'x-ratelimit-reset-tokens': '13ms',
    'x-request-id': 'req_<REDACTED>'
  },
  request_id: 'req_<REDACTED>',
  error: {
    message: "Missing required parameter: 'messages[3].content[0].type'.",
    type: 'invalid_request_error',
    param: 'messages[3].content[0].type',
    code: 'missing_required_parameter'
  },
  code: 'missing_required_parameter',
  param: 'messages[3].content[0].type',
  type: 'invalid_request_error',
  attemptNumber: 1,
  retriesLeft: 6,
  pregelTaskId: '<REDACTED>'
}

Yes definitely - it should be allowed, will investigate.

OK thanks.
To simplify the example, here is a repro without involving Prisma:
This fails:
import {tool} from "@langchain/core/tools";

export const getClipsterCategories =
    tool(() => [
        {id: "c1", name: "foo"},
        {id: "c2", name: "bar"}
    ], {
        name: "getClipsterCategories",
        description: "Gets product categories from the Clipster database."
    })

This succeeds:
import {tool} from "@langchain/core/tools";

export const getClipsterCategories =
    tool(() => ({
        categories: [
            {id: "c1", name: "foo"},
            {id: "c2", name: "bar"}
        ]
    }), {
        name: "getClipsterCategories",
        description: "Gets product categories from the Clipster database."
    })

Interestingly, if it is a simple string array, it succeeds.  It only seems to fail if it is an array of objects.
This succeeds:
import {tool} from "@langchain/core/tools";

export const getClipsterCategories =
    tool(() => ["foo", "bar"], {
        name: "getClipsterCategories",
        description: "Gets product categories from the Clipster database."
    })

Got it - for now, does stringifying the output work?
It should get passed to the LLM fine either way.

does stringifying the output work?

Yes, stringifying the result works.

Facing the same problem when using langchain

I'm having this exact issue swell - the work around in the short term is just to JSON.stringify() the data. I can't work out what causes this issue however - some of my tools work fine with an array response, some do not.

Sorry, forgot to follow up. I believe this is a consequence of how we handle artifacts in core:
https://js.langchain.com/docs/how_to/tool_artifacts
We should definitely clean this up in the next breaking release CC @baskaryan


Integration test "redis_tests::test_quit_drops_conn" is flaky

I've seen it flake pretty consistently in TravisCI, but I've noticed it flake once or twice for me when running the tests locally.  We should try hard to fix this.

Fixed this in #28.


[Bug] Clicking action in F1 command pallet does not refocus editor

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.79.2
OS Version: https://vscode.dev/ on Chrome and FireFox

can be reproduced on https://vscode.dev/
Steps to Reproduce:

open a file
focus in the file
press F1 to open command pallet
CLICK a command to place the cursor (ex: Add cursor below)
Try and type but can't because the editor is not focused

Expected Behavior:
When I click on an item that places a cursor I expect to be able to type where that cursor is placed.

/duplicate https://github.com/microsoft/vscode/issues/158576

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


webui: add type and program to search form

Codecov Report

Merging #145 into master will decrease coverage by 1.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage    60.2%   59.13%   -1.08%
==========================================
  Files          26       26
  Lines        2792     2792
==========================================
- Hits         1681     1651      -30
- Misses        939      975      +36
+ Partials      172      166       -6

Maybe my local setup is wrong, but I'm not seeing the new fields locally.

Thanks!


chore(travis): deploy master to gh-pages

Deploy master branch to gh-pages
Format README.md as HTML page using voorhoede-ocelot-formatter
Rebase relative links inside the HTML page
Write HTML page to gh-pages/index.html so it becomes the new project index page

@sveroude Publishing the main README as an HTML page is a good start. When this PR is done, I'd suggest we open another issue to also convert all the markdown files in docs/ to HTML pages. And we then need to make sure all the links still work everywhere.


website design improvements

@olafveerman & Co have offered to help improve the dat website!
Pages:

home
team
docs
about
stickers

The docs will ideally something simple along
the lines of http://pouchdb.com/api.html
It would also be awesome to have a generic layout design
for a sort of 'blog post'. Even if it's something simple where each
post is just a rendered markdown document paired with a separate UI
for listing all the posts (e.g. thats how http://maxogden.com/ is set
up)
In general I'm not 100% sure how the website will evolve over the next
year so it is probably best to keep things as
simple/flexible/componentized as possible. E.g. another project we're
working on is http://transform.datadex.io/, which deserves it's own
website but is also part of the Dat project. If we can re-use components across
projects so that Dat has a sort of visual identity/style guide then
that would be super awesome!
p.s. the dat sticker illustrator (designed by @jlord) is now at https://github.com/maxogden/dat-data.com/blob/gh-pages/logo.ai

So, as a supplement, however as a main point try this amazing free app. Createer.com is an online software for easily designing online ads, responsive landing pages and print materials such as flyers, posters, covers, invitations and more. Createer lets you easily share your designs on social media, send them via email, download as HTML, image or PDF. You can even design UI mockups for mobile as for standard display (html, js, css always generating without any coding required from you). Createer also includes 3,000 predesigned templates (browse here: https://beta2.createer.com/Templates?ghi) and over 250,000 images (illustrations, photos and icons) to work with in its user-friendly drag’n’drop enviroment. And finally this amazing stuff is here: https://beta2.createer.com/?ghi


Does not work with tinymce

Expected behaviour
Setting a textarea target that is being controlled by tinymce should allow copying
Actual behaviour
There are no errors but the text is not copied. Paste is empty.
Steps to reproduce

include tinymce
set target
attempt to copy and paste

I think tinymce has a specific plugin for copy and paste. It has some tricky to copy because there are a textarea hidden.

clipboard.js works with selectable HTML elements such as inputs and textareas. From my understanding tinymce doesnt use that, but you can still make clipboard.js work with it by using the imperative API: https://github.com/zenorocha/clipboard.js#advanced-options
All you have to do is, grab the string from your WYSIWYG editor and return it on the clipboard.js text function. Here is a full example: https://github.com/zenorocha/clipboard.js/blob/master/demo/function-text.html


count-lines line end missing in the output

Output of:
 rapidgzip --count-lines -P 0 --import-index foobar.gz.idx foobar.gz

does not have the end of line character.
Environment

python3 --version: 3.12.3
rapidgzip --version: 0.13.1 (installed from pypi)
Linux: Red Hat Enterprise Linux Server release 7.4 (Maipo)

I'm not entirely sure why I did it like this. I guess it shouldn't hurt to add the newline, but I might include this only in the next non-bugfix version. I'm assuming it is "only" a visual bug when using it in the terminal and therefore not urgent. Programmatic usages such as count=$( rapidgzip --clount-lines foobar.gz ); echo $count work as one would expect.

Thank you. The bash command  works OK.
Not a "must have" but having rapidgzip able to count lines per file in a glob pattern and outputting number_of_lines file_name can simplify some task. What I mean:
rapidgzip --count-lines foobar_?.gz

# output:
12345     foobar_1.gz
54321     foobar_2.gz
98765     foobar_3.gz

That would be not a bug but an enhancement obviously.

Fixed with 0.13.3.
As for the suggestions with multiple arguments. I think it adds too much complexity with command line parsing without much benefit, especially as --count-lines would be the only action command allowing multiple files to be specified. A simple bash for-loop can be used instead. If there is more demand, I may give this another thought.


Changes for the web demo GUI

Moved the "by sentence" formatter from the web server to an Formatter implementation (JSONBySentenceFormatter)
Created a "by sentence" plain formatter (PlainBySentenceFormatter)
Added the new formatters as redpen-cli output options json2 and plain2
Modified PlainTextParser to add the offset within each line each Sentence appears to assist sorting errors by their position within a document
Added a comment or two
Added primitive sentence highlighting in the editor of the erroneous sentence on mouse-over

Thank you a lot for the contribution @gerryhocks! I will look into the change for follow the changes.

Thank you as always!


Other frameworks

Both MAUI and Blazor are a mess.
It's worth trying to go back to WPF.

Delayed for now.

Avalonia might be a better option since it's multi platform and all.

Trying Avalonia

MAUI + Blazor seems the best option so far since the project's main platform is Android. There's too much progress at the moment to choose anything else.


Falso positive when package name and lib name differ

Any dependency where the package name is different from the lib name (use pkg::*;) is marked as a false positive, this seems to be consistent across the board:
[package]
name = "package"

[lib]
name = "pkg"
path = "src/lib.rs"

$ cargo machete --version
0.6.1

Example:
https://github.com/maciejhirsz/tiny-bip39/blob/master/Cargo.toml#L1-L19

Thanks for opening an issue. Does it work if you run cargo-machete --with-metadata? this will look for crate renamings like this one, if I remember correctly.

Thanks for the help @bnjbvr that does ameliorate it!

It would be nice if there was an option to whitelist dependencies for generated code:
[dependencies]
prost-types.workspace = true

[build-dependencies]
prost-types.workspace = true

prost-types gets flagged in this case because the generated code gets sent to OUT_DIR. I'm assuming scanning rust code generated by build.rs in OUT_DIR is a bit of a lift right now though.


python312Packages.dissect-volume: 3.8 -> 3.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.dissect-volume is: Dissect module implementing various utility functions for the other Dissect modules
meta.homepage for python312Packages.dissect-volume is: https://github.com/fox-it/dissect.volume
meta.changelog for python312Packages.dissect-volume is: https://github.com/fox-it/dissect.volume/releases/tag/3.9
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.9 with grep in /nix/store/rla60qy5s88lmlmifnhj7gyagnqvidvf-python3.12-dissect-volume-3.9
found 3.9 in filename of file in /nix/store/rla60qy5s88lmlmifnhj7gyagnqvidvf-python3.12-dissect-volume-3.9

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

8 package rebuild(s)

First fifty rebuilds by attrpath
acquire
python311Packages.acquire
python311Packages.dissect
python311Packages.dissect-target
python311Packages.dissect-volume
python312Packages.acquire
python312Packages.dissect-target
python312Packages.dissect-volume

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rla60qy5s88lmlmifnhj7gyagnqvidvf-python3.12-dissect-volume-3.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.dissect-volume https://github.com/r-ryantm/nixpkgs/archive/f47f948999089d475dbb72ee46c215492b884bb5.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/f47f948999089d475dbb72ee46c215492b884bb5#python312Packages.dissect-volume

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rla60qy5s88lmlmifnhj7gyagnqvidvf-python3.12-dissect-volume-3.9
ls -la /nix/store/rla60qy5s88lmlmifnhj7gyagnqvidvf-python3.12-dissect-volume-3.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages failed to build:

python312Packages.acquire
python312Packages.acquire.dist

12 packages built:

acquire (python311Packages.acquire)
acquire.dist (python311Packages.acquire.dist)
python311Packages.dissect
python311Packages.dissect-target
python311Packages.dissect-target.dist
python311Packages.dissect-volume
python311Packages.dissect-volume.dist
python311Packages.dissect.dist
python312Packages.dissect-target
python312Packages.dissect-target.dist
python312Packages.dissect-volume
python312Packages.dissect-volume.dist

Maintainer pings
cc @fabaff for testing.

Superseded by #294244


Attempt to build for windows

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Bit of a long shot since I know this is known to be a difficult package to build for windows, but going to give it a try.

@conda-forge-admin please rerender

@nehaljwani - I was wondering if you had any thoughts on how to get this building on Windows? I thought your experience with the mysql, mysql-connector-python, etc builds might be pertinent here.
The instructions for windows upstream are here:
https://github.com/PyMySQL/mysqlclient#windows
and there is a github workflow for how they build the wheels here:
https://github.com/PyMySQL/mysqlclient/blob/main/.github/workflows/windows.yaml

@halldc @jimbudarz - I just wanted to ping you again and request a review of this PR. Thanks!

Thanks for this work, @synapticarbors !
I don't feel qualified to review this PR, so if @halldc would be able to jump in, that would be terrific.
Otherwise, if you could provide some context and examples where this has been implemented similarly elsewhere that would help me review.

@jimbudarz -- I am by no means an expert on this package or on building compiled windows software. I was mostly just following the recommendations from the mysqlclient README:
https://github.com/PyMySQL/mysqlclient#windows
This is the github workflow that they use to build the official windows wheel:
https://github.com/PyMySQL/mysqlclient/blob/main/.github/workflows/windows.yaml
I believe it does basically the same thing except they are building the mariadb-connector from scratch, and then setting the connector in the site.cfg. I think setting the environment variable does the same thing, but I'm not 100% sure.


Adds Guzzle cache and increase timeout

Changes

Upgrade phpstan (only used by GitHub Actions)
Adds Guzzle cache to improve performance of Module Selection & Theme Catalog pages
Increase timeout to fix issues encountered by merchants with slow network
https://www.prestashop.com/forums/topic/1030080-theme-catalog-error/
https://www.prestashop.com/forums/topic/1029064-prestashop-addon-impossible/
https://www.prestashop.com/forums/topic/1028687-have-trouble-connecting-to-addons/
https://www.prestashop.com/forums/topic/1027334-error-a-conectarse-a-addons-marketplace-en-prestashop-17/
https://www.prestashop.com/forums/topic/1025591-error-occur-when-get-recommend-add-on/
https://www.prestashop.com/forums/topic/1032084-catalogue-de-modules/

Warning
This module is available start PrestaShop <IP_ADDRESS> with PHP 5.6 minimum.
So I cannot reuse PrestaShop core services introduced in <IP_ADDRESS> for Circuit Breaker and cache directory provider, that's why I create my owns.

How to test ?
Everything should works same as previously, Module Selection & Theme Catalog pages should be displayed as before.
If network is slow, we try to retrieve external content a little more longer before display "It looks like we have trouble connecting to Addons. Please refresh the page or check your firewall configuration."
Without network connection
Please note MBO cache is build on click on a recommended button or on display page with recommended modules after content or on display page with external content from Addons (Module Selection and Theme Catalog).
If you clear Cache on Advanced Parameters > Performance without network connection with PrestaShop 1.7.6+, you should have an error but not related to MBO.
I recommend to clear cache on Advanced Parameters > Performance with network connection then after cache clear confirmation you can disable network connection.
If MBO cache is not set and no network connection available or if we are unable to retrieve content before timeout :

Migrated pages except Module Catalog page should display : It looks like we have trouble connecting to Addons. Please refresh the page or check your firewall configuration.
Pages with a recommended button should display in modal : Service Unavailable - It looks like we have trouble connecting to Addons. Please refresh the page or check your firewall configuration.
Pages with recommended modules displayed after content should display in modal : Service Unavailable - It looks like we have trouble connecting to Addons. Please refresh the page or check your firewall configuration.

@Matt75 could you fixe the conflicting file ?
Thank you


Merge navigationOptions defined in component and routeConfigs

navigationOptions can be defined in two places:

In StackNavigator

StackNavigator(RouteConfigs, {
  navigationOptions: {
    header: {
      style: { backgroundColor: '#ffffff' },
      titleStyle: { color: '#00ff00' },
    },
  },
});

In Component as a static property

class MainScreen extends React.Component {
  static navigationOptions = {
    title: 'Main',
    header: ({ state, setParams }) => ({
      // Render a button on the right side of the header
      right: (
        <Button
          title={'Edit'}
          onPress={() => setParams({ editing: state.params.editing ? false : true })}
        />
      ),
    }),
  };
  ...

It will be convenient to define some global properties (such as global header style) when implementing StackNavigator and leave by-screen customizations (like right button) in each component. However, the header object in StackNavigator will replace the header in the screen component. For example, the right button above (and those in all the other screen components) will be discarded. This PR will merge the two header defined in different place.

@grabbou 😂

I have the same problem... I can't extend navigation options per screen when I define navigationOptions on StackNavigator. The only way to show right button in specific screens  is setting navigation options screen per screen

cc: @ericvicenti

We already do merge navigation options between the route and screen. But I agree, it gets confusing because the options are two levels deep.
The documentation explains all of this, and demonstrates how you can merge options like header manually: https://reactnavigation.org/docs/navigators/navigation-options#Default-Navigation-Options (see "Extending defaults").
I think the API is more complex than it needs to be, which is why people are having troubles even though the behavior is documented. In order to avoid this sort of confusion, I think we should have a flat list of navigation options. We wouldn't run in to this problem if we had headerStyle and headerRight instead of header.style and header.right.

There are 2 or 3 configuration levels?
I see:

StackNavigator RouteConfigs navigationOptions (per screen definition)
StackNavigator StackNavigatorConfig navigationOptions (global configuration)
Component static navigationOptions

Closing as options are now flat and there's no need to magically merge them :)


JSON marshaling of Program is incomplete

The documentation states that marshaling and unmarshaling of a program is supported.
However, the following test fails:
func Test_marshalRegexp(t *testing.T) {
	prog, err := expr.Compile(`"hello" matches "h.*"`)
	if !assert.NoError(t, err) {
		t.FailNow()
	}

	marshaled, err := json.Marshal(prog)
	if !assert.NoError(t, err) {
		t.FailNow()
	}

	unmarshaledProgram := &vm.Program{}
	err = json.Unmarshal(marshaled, unmarshaledProgram)
	if !assert.NoError(t, err) {
		t.FailNow()
	}

	output, err := expr.Run(unmarshaledProgram, nil)
	if !assert.NoError(t, err) {
		t.FailNow()
	}
	assert.Equal(t, true, output)
}

Hmm, I think this is due to cached regex.

hi, i'am interested in using this library in my project, but it requires to store the expression into database.
i've created some benchmark regarding the marshalling process with comparison to govaluate performace and found that Unmarshaling from json takes as much time as re-compiling the script (though it allocated less bytes). Shouldn't vm.Program implement encoding.TextMarshaler instead and use faster serialisation method?
func BenchmarkLibrary(b *testing.B) {
	parameters := map[string]interface{}{
		"s_age": 10,
	}
	s := `s_age == 10 || s_age < 10`

	b.Run("expr", func(b *testing.B) {
		for n := 0; n < b.N; n++ {
			p, _ := expr.Compile(s, expr.Env(parameters))
			expr.Run(p, expr.Env(parameters))
		}
	})

	b.Run("expr-marshalled", func(b *testing.B) {
		p, _ := expr.Compile(s, expr.Env(parameters))
		j, _ := json.Marshal(p)
		for n := 0; n < b.N; n++ {
			uP := &vm.Program{}
			json.Unmarshal(j, &uP)
			expr.Run(uP, expr.Env(parameters))
		}
	})

	b.Run("govaluate", func(b *testing.B) {
		for n := 0; n < b.N; n++ {
			expression, _ := govaluate.NewEvaluableExpression(s)
			expression.Evaluate(parameters)
		}
	})
}

BenchmarkLibrary/expr-8         	   50000	     30502 ns/op	   11309 B/op	     236 allocs/op
BenchmarkLibrary/expr-marshalled-8         	   50000	     24719 ns/op	    3113 B/op	      89 allocs/op
BenchmarkLibrary/govaluate-8               	  300000	      4221 ns/op	    2136 B/op	      52 allocs/op

Hi,
If you want to store a compiled program in DB why do you benchmark compiling and unmarshaling at the same time?
+	p, _ := expr.Compile(s, expr.Env(parameters))
+	j, _ := json.Marshal(p)
	b.Run("expr-marshalled", func(b *testing.B) {
-		p, _ := expr.Compile(s, expr.Env(parameters))
-		j, _ := json.Marshal(p)
		for n := 0; n < b.N; n++ {
			uP := &vm.Program{}
			json.Unmarshal(j, &uP)
			expr.Run(uP, parameters)
		}
	})

But this is really interesting. I think it's will be cool to implement fast marshal/unmarshal for a program. In my use case, we keep the program compiled in memory, so I never taked a look at speed on unmarshaling.
Currently, a program consists of these things:
type Program struct {
	Source    *file.Source       // Original source code
	Locations []file.Location // References of bytecodes to source  code location (used for showing code snippets on error)
	Constants []interface{}   // List of constants
	Bytecode  []byte              // Bytecode of a program itself.
}

Maybe you can create a PR with improvements?

If you want to store a compiled program in DB why do you benchmark compiling and unmarshaling at the same time

Oops, my mistake, should have taken that out from run(). But i think it won't change the overall result .
I can create a PR, but i'm not confident with what binary encoding would be best. It also hasn't solve the regex problem too.

Will be cool first, understand which part of a program slow to unmarshal (Sorce, Locations, Constants, Bytecode) and may be using encoding/gob for Constants will help?

Depends on what will be stored in Constant (currently i haven't dig deeper on the source code). AFAIK encoding/gob will return error when a struct has no exported field.

Constant usually it is int, string, vm.Call and some maps/slices.

And the maps/slice are also int, string, and vm.Call ?
Just out of curiousity, is Constant related to the cached regex you've mention before?
Btw, What about Source?, this is the one that failed applying encoding/gob to vm.Program as a whole

Yes, regex also stored in Constants (as we don't want to recompile regexp on each execution of a program).  Usually map/slice stored in Constants are from expressions. For example, if you compile
foo in [1, 2, 3]

Constants will contain []int slice, so we don't need to recalculate it on program execution.
Source is just a string of source code with some chaced offest indexes. Fields can be made public to mage it available for gob.

after exposing fields of Source, it was able to be encoded with gob. But when you add regex, gob also fail
func TestProgram_Marshall(t *testing.T) {
	param := map[string]interface{}{
		"subject": map[string]interface{}{
			"age": 10,
		},
	}
	s := `subject.age > 10 && "hello" matches "hell"`
	p, err := Compile(s, Env(param))
	if err != nil {
		t.Error(err)
	}

	var buff bytes.Buffer
	enc := gob.NewEncoder(&buff)
	dec := gob.NewDecoder(&buff)

	if err := enc.Encode(p); err != nil {
		t.Error("encode error: ", err)
	}
	p2 := &vm.Program{}
	if err := dec.Decode(p2); err != nil {
		t.Error("decode error: ", err)
	}
	o, err := Run(p2, param)
	if err != nil {
		t.Error(err)
	}
	if v, ok := o.(bool); !ok || !v {
		t.Error("should match")
	}
}

encode error:  gob: type not registered for interface: regexp.Regexp

Did you know any library that can marshall regexp.Regexp ?

+1


[tests] make cuda-only test work on other hardware accelerators

What does this PR do?
The below test works on XPU, and it should also work on other hardware accelerators:
===================================================================== PASSES ======================================================================
============================================================= short test summary info =============================================================
PASSED tests/test_modeling_utils.py::ModelingUtilsTester::test_get_balanced_memory

@muellerzr

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Add ending locations in line/column format

Needed for diagnostics in https://github.com/apollographql/router/pull/5247 .
Seems like maybe we want to have a single struct somewhere instead which returns start and end to save a bit of extra work in calling both methods? But not sure how to align that with the need of GraphQLLocation to be the spec's execution error location.

Maybe instead of _start and _end, we could have a method that returns a (GraphQLLocation, GraphQLLocation) tuple? This would address the double-lookup and I think it would be extremely rare to only need the end but not the start.
The methods could be called get_line_column and get_line_column_range for getting the start only or the start+end range respectively.

+1 for get_line_column and get_line_column_range. The latter could even return std::ops::Range<GraphQLLocation> (or Option of)

Having the range available would be a nice convenience for the language server. The type that's most interesting for my use case is the lsp_types::Range which says 0 indexed with an exclusive end, so that sounds compatible with the suggested Range<GraphQLLocation> approach. I am indifferent to tuple or struct, I think in this case the ordering of the tuple is very clear. A struct would match the lsp_types::Range type more closely, but in either case I will be mapping the type.

I've reworked this PR to a completely new proposal that uses new structs for representing both line/col, decoupled from the GraphQL error representation.
However, given that we're going to need an exclusive end & zero-indexing for LSP (and therefore composition), this may need further tweaking to get everything just right, maybe with Range<LineColumn> instead of the new dedicated struct. Interested to hear any ideas on how to best handle exclusive ends.

Also, a quick prototype of these changes in router: https://github.com/apollographql/router/pull/5263


Make a separate macro with all the new DAQ options

We have lots of new options relating to the DAQ that can be set via the macro. Since vis.mac and novis.mac are getting pretty long, I think we should consider making more specialized macros that show all of the available macro options for a particular topic. We could try this first with the DAQ options.

Cutting and pasting from the comment section of PR #124, the number of options are:
/DAQ/Digitizer
/DAQ/Trigger
/DAQ/DigitizerOpt/DeadTime
/DAQ/DigitizerOpt/IntegrationWindow
/DAQ/RestrictDigitsPerTrigger
/DAQ/TriggerSaveFailures/Mode
/DAQ/TriggerSaveFailures/TriggerTime
/DAQ/TriggerSaveFailures/PreTriggerWindow
/DAQ/TriggerSaveFailures/PostTriggerWindow
/DAQ/TriggerNDigits/Threshold
/DAQ/TriggerNDigits/Window
/DAQ/TriggerNDigits/AdjustForNoise
/DAQ/TriggerNDigits/PreTriggerWindow
/DAQ/TriggerNDigits/PostTriggerWindow
/DAQ/Construct
So, perhaps we can keep:
/DAQ/Digitizer
/DAQ/Trigger
/DAQ/Construct
in vis.mac and novis.mac to just show the bare functionality of the DAQ and then include the entire list above in the newly created DAQ macro.

I think we can close this issue now


feat: Coverage converter arguments parser and runner

Fixes #728
Checklist

[x] Documented
[x] Unit tested

@mergifyio refresh


it should have config for set max limit when "$top" is not provided

Hi @liratanak, appreciate your suggestion!
I expanded on your PR to include both a "default" page size, and a "maximum" page size that the server will not go beyond. These are included in v5.2.0.


Can't exclude shows from rule

Describe the bug
I created a rule to remove all watched episodes after x days. But I'm having difficulties to exclude shows from this rule.
I apologise in advance if i misread the purpose of the settings.
I tried this in two ways:

Exclude from the overview page
Added a second rule to exclude shows present in a collection

To Reproduce
Steps to reproduce the behavior:

Create the following rule:

Exclude shows from overview:

Run rules and check playlist

Collection contains excluded shows:

Alternatively, add second rule

Collection in Plex have the shows I want to exclude:

Run rules and check playlist

Collection contains excluded shows:

Expected behavior
Collection should had excluded the shows.
Device (please complete the following information):

OS: Ubuntu
Version: 20.4
docker container

After I clicked 'Submit' I realized what's the issue.
The Rule media type is episodes and both the overview exclusions and the collection in the second rule regards shows and not episodes. I created another collection with the episodes instead of the shows and they were excluded.
Is there an easy way to do this without going through every season of every show I want to exclude and add them to a collection?
(another minor issue: sometimes the collections take a long time to load when I click them on the collections page)

Hey, this is indeed a limitation with episodes and seasons. There’s an open task to extend the exclude feature: https://github.com/jorenn92/Maintainerr/issues/472
for now, you can remove the episodes from the collection through Plex. On next rule execution Maintainerr will sync and create exclusion rules.

You mean the 'add list exclusions' option? If I remove them manually from the collection on Plex, that option will prevent them (the episodes) from being re-added by the rule? Is that it?

When you remove items from collections within Plex, Maintainerr will not add them again but will create exclusions for that collection instead.
The ‘add list exclusion’ option is something else.  This will add Radarr/Sonarr exclude records, so lists in those apps won’t add the media again.

Oh, I got it.
Can I add a rule with a Sonarr tag to exclude the shows? Or, since the tag on Sonarr is on the show level and my media type is episodes, won't work as well?

I can't check right now, but i believe that should work. It should fetch the show's tags when using episodes & seasons.
If it doesn't work, please let me know and i can dig into it.

Sorry, I should have commented here. I ended up trying it and it works fine.
For now it's my current solution. Thank you.

Closing this due to inactivity. Additionally, since a the previous update, you can now exclude seasons and episodes. If you encounter any issues, please feel free to submit a new issue.


Alerts, RecordingRuleGroupSet and OutboundWebhook that are owned should be reconciled

Currently, when deleting or updating Alert/RecordingRuleGroupSet that were created from a PrometheusRule, the operator does nothing, and there is misalignment between what is defined in the PrometheusRule and the cluster actual state. If Alerts and RecordingRuleGroupSet (which are owned by a PrometheusRule) gets deleted/updated, the operator should reconcile them and restore the resources as they are defined in the PrometheusRule. PrometheusRule should be the single source of truth for its underlying resources, same as other object owners in k8s.
Note:  This is relevant for AlertmanagerConfig and OutboundWebhook as well.
Steps to reproduce:

Apply PrometheusRule with alert
Delete alert
Notice Alert wasn't recreated

Expected Behaviour:
Alert to be recreated according to the PrometheusRule.

@OrNovo WDYT? does it make sense to fix?


Style branch selection

There is still one weird problem with the filtering. When some characters (s and a for example) are entered when the paper-input is empty, the branch-selector loses focus. The same happens when removing the last character from the paper-input

Issue has been fixed :tada:

Toggle preview, toggles the description when no description is made and when there is a description it toggles the standard "Enter a description for your pull request. Markdown is supported.".
Furthermore when switching repo's, the title and the description previously filled in but not submitted are filled in.

Your second point I know of but thought this was not very relevant to fix for the tuesday RITE session.
I cannot seem to reproduce your first point. When I enter some markdown and then click the toggle, it shows the rendered markdown, like this:

When the description is empty, the preview is also empty. But this is intended behavior.

Ah, I get it.
So, when you click toggle preview you can not edit anymore.
I understood it incorrect, because of the fact that the title stays editable.

Yes, when you go to an existing PR you can see what the non-editable version looks like
Op 15 mei 2016 om 19:56 heeft Eva Anker<EMAIL_ADDRESS>het volgende geschreven:
Ah, I get it.
So, when you click toggle preview you can not edit anymore.
I understood it incorrect, because of the fact that the title stays editable.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[ ] Initially it was not clear what I was supposed to do. Maybe instead of hiding the description and pull request diff, we could show a message similar to the No project selected. E.g. "Select a branch to merge".
[ ] When I click a branch tag, I expect the paper-input to be focused. (I might have broken this in my commit).
[ ] The input fields are not clearly separated. I have a hard time visually separating them. Maybe we should add some borders or different background-colors?
[ ] The shadow behind the pull-request-chunks is a bit too much imo. Maybe also switch to using borders?
[ ] "Enter a title" is used multiple times. Maybe we should differentiate between the pull request title and the title for a chunk. E.g. "Enter a pull request title" and "Enter a chunk title".
[ ] On hover on the + icon, I expect a tooltip (title="") to show up with what it does. "Add a new chunk to this pull request".
[ ] Maybe we should also state to the user that you can drag the different chunks.
[ ] When I click "New comment" I get VM131 polymer.html:2260 Uncaught TypeError: Cannot read property 'length' of undefined. Probably we forgot to initialize an array of comments.
[ ] For some reason (I also observed this behavior in other branches) sometimes our per-page property of authenticated-ajax becomes undefined. Will have to test tomorrow more thoroughly what this is causing.
[ ] I think it is better to not hide the - icon on hover if you collapsed the chunk. When you did not collapse, I think showing on hover is just fine.
[ ] We should add a (visual, using css ::after)down-arrow on the branch-selector to indicate it is a dropdown.
[ ] When switching from branches with different diff views, I get pull-request-chunk.html:143 Uncaught TypeError: Cannot read property 'getElementsByClassName' of null.

This PR is getting really big, so I would say we merge this sooner rather than later. Most of the issues are fixed. Let's fixed the last couple of pionts in a different PR?

Merge


Unable to send (see in the first place) files from SD card - Android

I think this is a missing functionality. By default I am only presented with items on the internal memory to select and send. Is there a configuration change that needs to be done to show files from external SD or is this not supported as of now ?

Good catch, NitroShare does not currently provide an option for browsing the SD card. I will add this in an upcoming release.


filters: show fkey label when filtering

https://github.com/simonw/datasette/issues/1696
Example: https://dux-demo.fly.dev/cooking/posts?_facet=owner_user_id&owner_user_id=67

The amount of spooky action at a distance for me to patch this into Datasette from a plug in scares even me, not gonna try.

In https://github.com/cldellow/datasette-ui-extras/issues/38 I learned a little bit about how this code works, and am beginning to wonder if the level of spooky might be more Casper than Bloody Mary.
Assumptions:

it's OK to make a synchronous sqlite query to look up a value

if we're concerned about perf, maybe we'd check to see the column is indexed and only proceed if so

Challenge: a filter only has access to the table and column: https://github.com/simonw/datasette/blob/0b4a28691468b5c758df74fa1d72a823813c96bf/datasette/filters.py#L172-L181
We'd need to know the database name, too, so that we can find a SQLite connection to use.
A challenge is that these are created here: https://github.com/simonw/datasette/blob/0b4a28691468b5c758df74fa1d72a823813c96bf/datasette/views/table.py#L357
We could patch build_where_clauses to go spelunking in the call stack (see https://stackoverflow.com/a/6618825) to pull out the db
Then we have one of these: https://github.com/simonw/datasette/blob/main/datasette/database.py
Ah, but here I think we run into an issue. The connections that are created for asyncio would not be usable by us, as their underlying sqlite3 handle might be in use by the other thread (and would need the appropriate SQLite compile-time flag to ensure that it was OK to use it from a different thread).
It would only work if the num_sql_threads was set to 0 (ref: https://github.com/simonw/datasette/blob/0b4a28691468b5c758df74fa1d72a823813c96bf/datasette/app.py#L348-L353), which I think would practically never be true for the cases I care about.

A mildly more officially sanctioned option:

monkey-patch https://github.com/simonw/datasette/blob/0b4a28691468b5c758df74fa1d72a823813c96bf/datasette/filters.py#L259 to remove the exact filter
implement filters_from_request to add support for the exact filter. This is an awaitable, so it can do everything we need.

Hm, I note that __exact is maybe special?
eg https://dux-demo.fly.dev/cooking/posts?owner_user_id=67 and https://dux-demo.fly.dev/cooking/posts?_sort=id&owner_user_id__exact=67 seem to both work. What's up with that? Can we take over both of them?

Ah, that's this bit here: https://github.com/simonw/datasette/blob/0b4a28691468b5c758df74fa1d72a823813c96bf/datasette/filters.py#L396-L402
It'd "just work", I think.

Removing the filter breaks the filters UI - it no longer has the dropdowns for = and !=.
Somehow it still manages to generate SQL?

We have to operate directly on request.args, so we need to handle the __exact vs absent case.


pylossless_qc fails to launch the QC dashboard

Do you mean that, the dashboard doesn't open in the browser automatically?

Sorry for the non-descriptive issue. I created these as I was on a call with a student who was trying to run PyLossless and it was not running.

Do you mean that, the dashboard doesn't open in the browser automatically?

Nope. I created #182 for that. I meant that pip install --editable .[dash] while being in the cloned repo installed pylossless fine, except that the command pylossless_qc was not recognized by the system. We did not have much time to investigate this specifically on the call, so I would need to check if I can manage to reproduce this issue to pinpoint the cause.

ah OK.
if it's of any help, I just install Pylossless in a fresh virtual environment and pylossless_qc worked fine for me:
Sounds like it could have been a Python PATH problem?

conda create -n ll_test python=3.10
conda activate ll_test

# confirm that python path is to the virtual env
which python

python -m pip install --editable ".[dash]"

pylossless_qc

Dash is running on http://<IP_ADDRESS>:8050/

 * Serving Flask app 'pylossless.dash.app'
 * Debug mode: on

Playing around with this installation, we got this error message:

So... as far as I can tell, this seems not to be related to PyLossless at all but some issue with system installation. We added the corresponding binary path to the PATH system variable in .bashrc. I'll close this issue as it does not seems specific to the PyLossless.


Refactors of BigSamplerAvro and adds ability to control hashing of byte  sequences.

Refactors BigSamplerAvro to only perform the type checking in one
place.
Avoids string serialization in buildKey.
Makes BigSamplerAvro and BigSamplerBigQuery consistent in how they
handle repeated fields.
Adds ability to control how Bytes fields are hashed, this is to allow
users to hash strings and byte sequences consistently when the strings
are string encoded byte sequences.
Handles Avro unions properly.

Sorry for the slow progress on this, it was difficult to get some time over for this. The PR became much larger than I would have wanted, I understand if you want me to split it somehow.

Great! Will merge when tests pass just out of paranoia


Macro: new created preset does not draw on canvas

Steps to Reproduce

Go to 'RNA builder'
Create new preset. Save
Click to canvas to draw preset

Actual behavior
Draw last selected monomer

Expected behavior
Draw selected preset

Manual tests added to the automation table.

Working not properly. We have open bug https://github.com/epam/ketcher/issues/3615
https://github.com/epam/ketcher/assets/62464241/ad6cf642-0260-4ea8-87e7-efae50f0a745


[do not merge] example of ocm_idp module using api

@paulczar What do you think about breaking out just the API usage part into a separate PR? Then we could add some smaller use cases to get things rolling.


Issue #144: Added internal customer private key to kickstart customer.

Fixes #144 .

thanks @RoSk0 <3


Adding Custom themes

Is your feature request related to a problem? Please describe.
I think we should apply themes to our website,
Describe the solution you'd like
Till now, we have only white background on each page, but what if we provide an option for custom themes, check below video for a better understanding
https://user-images.githubusercontent.com/53515714/113472979-3faf9e80-9484-11eb-952f-e84f6a7e6d0e.mp4
So we can do this like chrome, where we put a theme option in the drawer section and there are multiple images available and also solid colors, so that user can set his favorite background theme and we will display this theme in each page
Describe alternatives you've considered
Additional context

@nishant23122000 would you like to work on this issue?

@nishant23122000 would you like to work on this issue?

Yes sure


suggestion

maybe you can add inventory changer from cs2-sdk v1 and add basic aimbot , trigger so this base can become new csgosimple aka cs2simple

the author said that the changer will no longer be update it


Load Reporters dynamically, using provided ktlint version

Follow up on https://github.com/jeremymailen/kotlinter-gradle/pull/279#discussion_r996320177 - which moves all ktlint classes to be loaded in process isolation, within workers. The same way RuleSetProviderV2s are.

I believe this is also now solved for in 5.0.0


feat: add light-beaconchain-explorer

Changelog picked up from commits here:
feat: add light-beaconchain-explorer

Indexing seems to be not working right now.
You can run this branch with kurtosis run github.com/kurtosis-tech/eth2-package@bbusa/light-beaconchain

Thanks for that command :)
Spinning up a local devnet that way is impressively easy.
I've fixed various issues in the explorer that in combination lead to that bad result.
The main issue has probably been, that the indexer thread silently died when the first RPC call wasn't successful.
I've published a new bugfix release for the explorer, so a working image is now available via the pk910/light-beaconchain-explorer:latest image too.


need (integration?) tests that exercise JSON schema validation

Our editor uses JSON schema validation to ensure any resource templates used can be correctly interpreted by the editor to create expected RDF;  tests are needed to ensure we don't break key functionality:

diff sorts of errors get reported out to the user (e.g. unparseable JSON vs missing schema url vs schema validation errors)
valid profiles and valid resource templates are imported cleanly (for schemas expecting and not expected to contain schema urls)

We have:

schemaValidation.test that currently has a single test for a template with bad json.
We have
ImportFileZone.test that looks at different possible wrinkles of schema valid (i.e. diff schema versions) and schema invalid (diff reasons templates fail) ... BUT it doesn't actually use the app's plumbing to perform the schema validation -- the tests are like this:

      it('resolves the passing profile validation, returning undefined', async () => {
        expect.assertions(1)
        template = require('../../__fixtures__/place_profile_v0.2.0.json')
        schemaUrl = wrapper.instance().schemaUrl(template)
        const resolution = await wrapper.instance().promiseTemplateValidated(template, schemaUrl)

        expect(resolution).toBeUndefined()

It may be that some additional mocking can prove the functionality is working;
it may be that some of the tests in ImportFileZone could become integration tests;
etc.

For reference, see https://github.com/LD4P/sinopia_editor/commit/877c5e17a6b32a293857cf938e581ea3c5f75ebe#diff-c62dd4f387e63a1410365c8d90f62132 and/or the history of the schemaValidation.tests file

Current tests for valid and invalid resource templates are adequate for testing validation.


Use the grouped workers worker_key function in scale outside of adaptive

Seen thanks to https://github.com/dask/dask-kubernetes/issues/98.
Currently, _job_id_from_worker_name function is used as worker_key in adaptive options: https://github.com/dask/dask-jobqueue/blob/master/dask_jobqueue/core.py#L145.
However, this is not inplace when manually scaling down or up. This could be a nice thing to stopping to much worker when scaling down.
This may have to be change upstream in distributed, somewhere here: https://github.com/dask/distributed/blob/master/distributed/deploy/cluster.py#L103. We could use a self.worker_key method if defined as another kwarg.
@mrocklin any opinion on that?

Yes.  That makes sense to me.
On Mon, Sep 17, 2018 at 9:19 AM, Guillaume Eynard-Bontemps <
<EMAIL_ADDRESS>wrote:

Seen thanks to dask/dask-kubernetes#98
https://github.com/dask/dask-kubernetes/issues/98.
Currently, job_id_from_worker_name function is used as worker_key in
adaptive options: https://github.com/dask/dask-jobqueue/blob/master/dask
jobqueue/core.py#L145.
However, this is not inplace when manually scaling down or up. This could
be a nice thing to stopping to much worker when scaling down.
This may have to be change upstream in distributed, somewhere here:
https://github.com/dask/distributed/blob/master/
distributed/deploy/cluster.py#L103. We could use a self.worker_key method
if defined as another kwarg.
@mrocklin https://github.com/mrocklin any opinion on that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-jobqueue/issues/152, or mute the thread
https://github.com/notifications/unsubscribe-auth/AASszH-3VVy1QfgZMAIRoh0J-UoVDZPGks5ub6FKgaJpZM4Wr5vV
.


Bump to etcd 2.1.1; properly test it with Jenkins

replaces #4121
closes #4135

Code LGTM.

@mboersma I'll defer to you as to whether we ship this for 1.9. I'd argue that we should bump to the latest etcd version when we're making the big etcd version jump (especially since there are substantial improvements), but 2.0.13 has admittedly been vetted for a bit longer.

One argument for v2.1.1 is that it has fixed a few bugs related to leaking fds.

One argument for v2.1.1 is that it has fixed a few bugs related to leaking fds.

Yeah. I'm leaning on the side of shipping this in 1.9.

:ship:

Code LGTM.


Merge refs/heads/feature/find-as-cursor into alpha

Merge refs/heads/feature/find-as-cursor into alpha

This PR has been merged into alpha and tagged as 1.6.0-alpha-202304121351. Thanks for your contribution!


Fixed max char length for metasmoke token

Resolves issue #91, details can be found there.

@Cerbrus [status-urgent] with reference to this comment.

@Cerbrus it's already been merged after being approved by 2 others. Sadly you can only leave comments as reviews after it has been merged, rather than explicit approve/reject reviews.


Improve Ellipse Tool

Implement Ellipse tool as specified in #89.

This change is

oh and sorry for sounding a bit harsh at times


add COUNT_PRIVATE for including private repo's commits in total commits

Hello!
i'm grateful to you for making a useful project!
I thought it would be nice to include the commit count of the private repository in total commits, so I modified that part.
And it would be nice to manage GIST_ID in secrets.

Hi,
I think the private contributions are already counted, but if you have an example showing I'm wrong, please tell me.
The problem with the Gist ID being in a secret is that the Github Actions are initially disabled when you fork the repo. Editing run.yml activates the action, that's why I decided to include a wrong Gist ID directly in it.


Placeholder: go vet report

Here's a truncated report from go vet on our issues:
api/agent/agent.go:17:2: could not import github.com/fnproject/fn/fnext (can't find import: "github.com/fnproject/fn/fnext")

api/agent/drivers/docker/docker_client.go:116:12: too many arguments

api/agent/hybrid/client.go:29:27: DataAccess not declared by package agent

api/datastore/mock_test.go:6:2: could not import github.com/fnproject/fn/api/datastore/internal/datastoretest (can't find import: "github.com/fnproject/fn/api/datastore/internal/datastoretest")

api/datastore/internal/datastoretest/test.go:67:9: invalid operation: ds (variable of type github.com/fnproject/fn/api/models.Datastore) has no field or method UpdateCall

api/datastore/internal/datastoreutil/metrics.go:89:9: invalid operation: m.ds (variable of type github.com/fnproject/fn/api/models.Datastore) has no field or method UpdateCall

api/datastore/sql/sql_test.go:8:2: could not import github.com/fnproject/fn/api/datastore/internal/datastoretest (can't find import: "github.com/fnproject/fn/api/datastore/internal/datastoretest")

api/datastore/sql/sql.go:518: can't check non-constant format in call to Sprintf

api/logs/log_test.go:9:13: could not import github.com/fnproject/fn/api/logs/testing (can't find import: "github.com/fnproject/fn/api/logs/testing")

api/logs/s3/s3_test.go:8:13: could not import github.com/fnproject/fn/api/logs/testing (can't find import: "github.com/fnproject/fn/api/logs/testing")

api/server/app_listeners.go:7:2: could not import github.com/fnproject/fn/fnext (can't find import: "github.com/fnproject/fn/fnext")

examples/middleware/main.go:28:27: cannot use &(CustomMiddleware literal) (value of type *CustomMiddleware) as github.com/fnproject/fn/api/server.Middleware value in argument to funcServer.AddMiddleware

fnlb/main.go:15:2: could not import github.com/coreos/go-semver/semver (can't find import: "github.com/fnproject/fn/vendor/github.com/coreos/go-semver/semver")

fnlb/lb/allgrouper.go:14:2: could not import github.com/coreos/go-semver/semver (can't find import: "github.com/fnproject/fn/vendor/github.com/coreos/go-semver/semver")

images/fn-test-utils/fn-test-utils.go:10:6: could not import github.com/fnproject/fdk-go (can't find import: "github.com/fnproject/fdk-go")

test/fn-api-tests/utils.go:74:23: WithDBURL not declared by package server

test/fn-api-tests/fn/formats/json/go/func.go:34: can't check non-constant format in call to Fprintf
test/fn-api-tests/fn/formats/json/go/func.go:41: can't check non-constant format in call to Fprintf
test/fn-api-tests/fn/formats/json/go/func.go:52: can't check non-constant format in call to Fprintf
test/fn-api-tests/fn/formats/json/go/func.go:65: can't check non-constant format in call to Fprintf

I assume most of them needs to be fixed.
How to reproduce:
go vet -v ./...

we pass go vet in every CI build now. just turn off -v


Transformer API

Is your feature request related to a problem? Please describe.
In some cases, you might want to transform the data from PostgREST after fetching it, e.g. create a js Date for timestamptz columns, or convert the snake case to camel case (#244)
Describe the solution you'd like
Add a transformer API to all query hooks, that accepts a transformer: (result: R) => TransformedResult method. The transformer is applied within the fetcher, and before the data is written to the cache. It also transforms the Result type to ensure type-safety.
Describe alternatives you've considered
Wrapping the hooks and transform them afterwards.

This is one of the first features that I was looking for. Simple use case: parse Dates.

Any update on this one?


Add StaxLayer: tuple with properties

This is a simple and stateless way of exposing properties of interest on stax layers.
Came about when thinking about ppipe and that it would be nice if the user could simply pass in a stax.serial model to split those layers across devices.
Also @levskaya's Let and LetP could use this to expose params and values.
This PR wraps serial and parallel outputs in StaxLayer, exposing the layers property.

This is definitely a step towards one of the remaining practical deficiencies of extended stax models, which is that the params state-tree is quite opaque to the user.  There's no reason the params tree has to be a tree of tuples, it could easily be a tree of dicts or wrapped tuples like yours with named params and layers, which enable manual access or even allowing a simple subtree query syntax for grabbing or selecting+modifying parts... all while still mostly enforcing the simple discipline of a stax layer as a init, apply tuple.  Would definitely enjoy talking about this more.

We're no longer evolving stax (in favor of libraries like Flax and Haiku), and this PR is now ancient history.


Make IntervalTrigger stateful to fix PTB example bug #1384

Bug #1384 is caused by epochs in PTB not being evenly divisible into iterations. An IntervalTrigger set on a particular number of epochs should trigger after exactly that many epochs, if that corresponds to an integer number of iterations, or on the first iteration after exactly that many epochs, if it doesn't.

Thank you for your PR. Is it possible to write unitests?

@jekbradbury How are you? If you cannot spare time, I will write unittests and send PR to your repository. I would appreciate you if you let me know the way that is convenient for you?

Thank you for reminding me -- I will write unittests this weekend.

Thank you! Let me know if you encounter any problem.

Is it OK to start reviewing this PR?

Yes, I am done pushing

In the original document, we restrict period argument to be integer as you can see here. So could you change it as well?

The conflict is derived from the change by#1506, in which IntervalTrigger is moved under training.triggers namespace. So could you merge or rebase the latest master branch?

In the current implementation, we allow period to be float even if unit is iteration. Do you think it is acceptable? It could do harm to the operation here. So I think we should change it if we want to do this extension.

Well, the period should have to be an int if the unit is iteration -- there's no such thing as a partial iteration. Is it ok to specify that the period must be an int if the unit is iteration but it can be a float if the unit is epoch?

Is it ok to specify that the period must be an int if the unit is iteration but it can be a float if the unit is epoch?

Yes, it is reasonable.

A comment on the conflict occurred. We moved IntervalTrigger to training.triggers namespace, so could you rebase the master branch to resolve the conflict?

Also, I would like you to consider the comment on the document of __call__ method.

I ran the PTB example in test mode. The example did stop, but the number of epoch processed is longer than specified. Specifically, we set the number epoch to 39 in test mode. But as 1 iteration consumes 7 epochs, the test finishes with 42 epochs, the least number which is multiple of 7 and is larger than or equals to 39.
I would like to ask if you think it is acceptable behavior or we should fix it, although I do not think we need not include this change if any.

LGTM, I am now running on the GPU server. I will merge it when I confirm the test passes.

Thank you for your contribution!


Add ContainerType to BlobContainerService Interface

Adds ContainerType to Metadata interface in BlobContainerService.ts for use by the Storage Container Service Client.
ContainerType describes how a container is used.
Format is not being removed, it is defined by the service itself, and will be returned with metadata from the requestToken() response. It is not required for creating a new container.

@MichaelSwigerAtBentley please see my changes to this interface in this PR. They won’t conflict with this change, but you should be aware of them.

@MichaelSwigerAtBentley please see my changes to this interface in this PR. They won’t conflict with this change, but you should be aware of them.

Looks good, I'll add support for the RequestAccessLevel change and "writeIfPossible" into the client and the service.

I think the “if possible” concept and be implemented client-side if it’s difficult server-side (e.g. somehow returning what level was returned.) The client implementation should somehow cache recent requests, because I’m presuming that repeated requests for the same token don’t actually cause any http delay unless necessary (e.g an lru cache, with a validity timeout).

I think the “if possible” concept and be implemented client-side if it’s difficult server-side (e.g. somehow returning what level was returned.) The client implementation should somehow cache recent requests, because I’m presuming that repeated requests for the same token don’t actually cause any http delay unless necessary (e.g an lru cache, with a validity timeout).

That makes sense. If I'm understanding this right: I'll implement a cache client-side that stores the last few requests and their token's expire time. If a cache hit occurs and the token isn't expired I pass back the old token and never send a request to the service.

That makes sense. If I'm understanding this right: I'll implement a cache client-side that stores the last few requests and their token's expire time. If a cache hit occurs and the token isn't expired I pass back the old token and never send a request to the service.

Something like that. The cache expiry should be well shorter than the token expiration (maybe 10 minutes?) so you can refresh it before it expires. Also, keep in mind that the user token may vary even for the same backend through RPC, so the user token needs to be part of the cache key.


Is there a way to configure dashboards in code?

I was wandering if it is possible to define dashboards in code so that they can be easily recreated when setting up a new instance?

You can actually do that via "/api/dashboard/remoteCreate". We are currently in the works for putting on documentation on how to use this. Stay tuned.


Make a version for mobile devices

🙏

I... think it might just work on android? Do you have that?

I use android

4 days ago lol


Lack of initialization weights

Kindly request a weighted download link："../pretrained_models/R-101.pkl"
or
Whether this weight consists of the weights of the same four FCOS of "catalog://ImageNetPretrained/MSRA/R-101"
thanks~

thanks for open-source code again
I have solved this issue by below URL
URL:https://dl.fbaipublicfiles.com/detectron2/ImageNetPretrained/MSRA/R-101.pkl


why exactly 3 persistence class objects will created after creating SessionFactory object.

Configuration cfg=new Configuration();
cfg.configure();
...... at this point the default constructor of persistence class will not call.That means no instance will create for persistence class
but after creating Sessionfactory object i.e
Configuration cfg=new Configuration();
cfg.configure();
SessionFactory sf=cfg.buildSessionFactory();
....default construct will call 3 times exactly so the question is why exactly 3 persistence class objects will created after creating SessionFactory object.

The project have 3 hibernate.cfg file, this create 3 persistence class


Draft: Restructure slightly

Rename and number the chapters
Moving some content around

On pause - but not forgotten about! Will pick up the restructuring in September


unable to start

hello,
after spending hours downloading steam server components I have faced the following issue:
Success! App '730' fully installed.
cp: cannot create regular file '/home/steam/cs2-dedicated/game/csgo/cfg/server.cfg': No such file or directory
cp: cannot create regular file '/home/steam/cs2-dedicated/pre.sh': Permission denied
cp: cannot create regular file '/home/steam/cs2-dedicated/post.sh': Permission denied
sed: can't read /home/steam/cs2-dedicated/game/csgo/cfg/server.cfg: No such file or directory
entry.sh: line 71: cd: /home/steam/cs2-dedicated/game/bin/linuxsteamrt64: No such file or directory
bash: /home/steam/cs2-dedicated/pre.sh: No such file or directory
Starting CS2 Dedicated Server
entry.sh: line 104: ./cs2: No such file or directory
bash: /home/steam/cs2-dedicated/post.sh: No such file or directory

what could be the reason of it? would it be possible to check these files and permissions before wasting time on downloading?

Could you drop your docker run command in here, please?

I shouldn't have executed it under root account, in best case we should be using a user with id 1000 on a host machine, so that the bind-mount would correctly map users between container and host, that's my bad, apologies


Package name
spack-stack
Package version/tag
1.6
Build options
use /penguin/openmpi/4.1.6
Installation timeframe
ASAP
Other information
1.6 and all previous version of spack-stack have been built with /penguin/openmpi/4.1.5rc2.  This version is no longer supported.  The recommend /penguin/openmpi/4.1.6
WCOSS2

[ ] Check this box if and only if your package should be installed on WCOSS2 Cactus and Dogwood (all spack-stack packages will be installed on Acorn). If not, you may disregard the rest of the items below and submit this request.

WCOSS2: General questions
No response
WCOSS2: Installation and testing
No response
WCOSS2: Technical & security review list

[ ] The code is mature, stable, and production ready
[ ] The code is does not and cannot use the internet, and does not contain URLs (http, https, ftp, etc.) except in comments
[ ] The package does not contain prebuilt binary files that have not been approved by NCO security review
[ ] The code has no publicly disclosed cybersecurity vulnerabilities and exposures (search https://cve.mitre.org/cve/)
[ ] The code is not prohibited by DHS, DOC, NOAA, or NWS
[ ] The code comes from a trusted source. Trusted sources include other NWS, NOAA, or DOC, agencies, or other Federal agencies that operate at a FISMA high or equivalent level. Additionally, trusted sources could be third-party agencies through which there is an existing SLA on file (such as RedHat).
[ ] The code is actively maintained and supported (it continues to get updates, patches, etc.)
[ ] The code is not maintained by a private entity operating in a foreign country (if it is, make a note below)
[ ] There is sufficient documentation to support maintenance
[ ] There are no known security vulnerabilities or weaknesses
[ ] Installing and running the code does not require privileged processes/users
[ ] There are no software dependencies that are unapproved or have security concerns (if there are, make a note below)
[ ] There are no concerns related to SA, SI, and SC NIST control families

WCOSS2: Additional comments
No response

I built spack-stack-1.6.0 (but none of the earlier versions) with<EMAIL_ADDRESS>here:
/p/app/projects/NEPTUNE/spack-stack/spack-stack-1.6.0/envs/ue-openmpi416/

All that is needed is to replace the module use command and the module load openmpi command from spack-stack-1.6.0 with the following (after loading the usual modules):
module use /p/app/projects/NEPTUNE/spack-stack/spack-stack-1.6.0/envs/ue-openmpi416/install/modulefiles/Core
module load stack-intel/2021.5.0
module load stack-openmpi/4.1.6
module load stack-python/3.10.13

See also the latest spack-stack documentation (https://spack-stack.readthedocs.io/en/latest/PreConfiguredSites.html#navy-hpcmp-nautilus)
Can you check if that works? Do you also need that for earlier versions of spack-stack, or is 1.6.0 enough?

When I load stack-openmpi/4.16, I get the following message:

20 nautilus08:~/neptune_atmos1/drivers> module load stack-openmpi/4.1.6
Loading stack-openmpi/4.1.6
Loading requirement: penguin/openmpi/4.1.6/intel-classic-2022.0.2 slurm

Just want to make sure that that is the expected behavior

I think that is correct. I get this, which worked for testing with jedi-bundle:
$ umask 0022
$ module purge

$ module load slurm
$ module load intel/compiler/2022.0.2
Loading compiler version 2022.0.2
Loading tbb version 2021.9.0
Loading compiler-rt version 2023.1.0
Loading oclfpga version 2023.1.0
  Load "debugger" to debug DPC++ applications with the gdb-oneapi debugger.
  Load "dpl" for additional DPC++ APIs: https://github.com/oneapi-src/oneDPL

Loading intel/compiler/2022.0.2
  Loading requirement: intel/tbb/latest intel/compiler-rt/latest intel/oclfpga/latest
$ module load penguin/openmpi/4.1.6/intel-classic-2022.0.2

$ module use /p/app/projects/NEPTUNE/spack-stack/modulefiles
$ module load ecflow/5.8.4
$ module use /p/app/projects/NEPTUNE/spack-stack/spack-stack-1.6.0/envs/ue-openmpi416/install/modulefiles/Core
$ module load stack-intel/2021.5.0
$ module load stack-openmpi/4.1.6
$ module load stack-python/3.10.13
Loading stack-python/3.10.13
  Loading requirement: tar/1.30 gettext/0.21.1 libxcrypt/4.4.35 zlib/1.2.13 sqlite/3.43.2 util-linux-uuid/2.38.1 python/3.10.13

$ module li
Currently Loaded Modulefiles:
 1) slurm                      4) intel/oclfpga/latest                           7) ecflow/5.8.4          10) tar/1.30          13) zlib/1.2.13             16) python/3.10.13
 2) intel/tbb/latest           5) intel/compiler/2022.0.2                        8) stack-intel/2021.5.0  11) gettext/0.21.1    14) sqlite/3.43.2           17) stack-python/3.10.13
 3) intel/compiler-rt/latest   6) penguin/openmpi/4.1.6/intel-classic-2022.0.2   9) stack-openmpi/4.1.6   12) libxcrypt/4.4.35  15) util-linux-uuid/2.38.1

the NEPTUNE build failed with in the compilation of CCPP.  Not sure why it's trying to install the ccpp_framework library into /usr/local/lib or why the version of spack-stack should make a difference, unless it's some CMAKE thing?
Install the project...
/p/app/projects/NEPTUNE/spack-stack/spack-stack-1.6.0/envs/ue-openmpi416/install/intel/2021.5.0/cmake-3.23.1-l5uiid2/bin/cmake -P cmake_install.cmake
-- Install configuration: "Release"
-- Installing: /usr/local/lib/libccpp_framework.a
CMake Error at ccpp-framework/src/cmake_install.cmake:46 (file):
  file INSTALL cannot copy file
  "/p/home/reinecke/neptune_atmos1/external/ccpp/build/ccpp-framework/src/libccpp_framework.a"
  to "/usr/local/lib/libccpp_framework.a": Permission denied.
Call Stack (most recent call first):
  ccpp-framework/cmake_install.cmake:47 (include)
  cmake_install.cmake:47 (include)

the NEPTUNE build failed with in the compilation of CCPP. Not sure why it's trying to install the ccpp_framework library into /usr/local/lib or why the version of spack-stack should make a difference, unless it's some CMAKE thing?
Install the project...
/p/app/projects/NEPTUNE/spack-stack/spack-stack-1.6.0/envs/ue-openmpi416/install/intel/2021.5.0/cmake-3.23.1-l5uiid2/bin/cmake -P cmake_install.cmake
-- Install configuration: "Release"
-- Installing: /usr/local/lib/libccpp_framework.a
CMake Error at ccpp-framework/src/cmake_install.cmake:46 (file):
  file INSTALL cannot copy file
  "/p/home/reinecke/neptune_atmos1/external/ccpp/build/ccpp-framework/src/libccpp_framework.a"
  to "/usr/local/lib/libccpp_framework.a": Permission denied.
Call Stack (most recent call first):
  ccpp-framework/cmake_install.cmake:47 (include)
  cmake_install.cmake:47 (include)

That is weird. cmake version is the same between 1.6.0 unified-env and 1.6.0 ue-openmpi416. Wondering what is triggering the install, usually this only gets triggered by make install. Any changes to CCPP between what used to work and now?

The code is the same that built with the previous spack-stack version.  Here is a partial diff between the cmake_install.cmake file that is throwing the error.  The only difference is the version of spack-stack that is loaded.
10 nautilus05:~/neptune_atmos1/external/ccpp> diff ~/neptune_atmos{1,2}/external/ccpp/build/ccpp-framework/src/cmake_install.cmake
5c5
<   set(q"/usr/local")
---
>   set(CMAKE_INSTALL_PREFIX "/p/home/reinecke/neptune_atmos2")

CMAKE_INSTALL_PREFIX  is set in the build_ccpp.sh script where it sets
CCPP_CMAKE_FLAGS="-DCMAKE_INSTALL_PREFIX=${CCPP_DIR} -DNETCDF_DIR=${NETCDF} -DMPI=ON"

This is difficult to debug for me - once I have access to the code (and know the steps how to build it), I can help. I am puzzled because I don't see how changing the openmpi version can have any effect on where cmake wants to install code.

Yay. Closing, thanks for letting me know.


BUG: Invisible text in the pricing section on switching to dark mode

The bug
Text in the pricing section cards is invisible on switching to dark mode
Expected behavior
The text colour should remain the same
Screenshot

**Additional Context **
would like to get this bug cleared
Are you contributing under any open-source program ?
JWOC 2024

@Aswinr24 Welcome to the REPO.
I have assigned you. You just have 1 day to submit your PR .
Happy Coding!!!!!!!!!

Sorry saw this message late..will make a PR by tonight


Do we need to rename $0 to $1 (like in Postgres)

See examples in Postgres docs: http://www.postgresql.org/docs/9.2/static/sql-prepare.html
PREPARE fooplan (int, text, bool, numeric) AS
    INSERT INTO foo VALUES($1, $2, $3, $4);
EXECUTE fooplan(1, 'Hunter Valley', 't', 200.00);

The start parameters number with $1, but not $0 (like in AlaSQL).
From another point we keep JavaScript. If you want to start with $1 you can do:
    alasql('SELECT $1',{1:100});

I beleave that is a good thing.
Also breaking change - so must be for 0.2.0

I still not sure. Let's postpone a little bit. This is not JavaScript way...
Отправлено с iPhone

29 мая 2015 г., в 8:26, Mathias Rangel Wulff<EMAIL_ADDRESS>написал(а):
I beleave that is a good thing.
Also breaking change - so must be for 0.2.0
—
Reply to this email directly or view it on GitHub.

No problem. Let's postpone.
Bfor when we look at it again: It's not really an array index - but specification to what argument to use. It reminds a bit of how to use regexp in is where first (...) is \1 second is \2 and so on. Another strong argument is the Postgres syntax
Do we use $0, $1 ... in other parts of the syntax?

I tried always change 0 to 1 (for example, for string functions). But here... The parameter object can be array, but can be object with named properties... Let"s think...

Any new inputs?

Let's close it.

Missed opportunity, imho, to change this early to be compatible with one of the biggest RDMS out there (Postgres).
I manually construct an object from my param array now to support that.

I suggest making this as a config option. PRs welcome.

I'll do just that beginning of next year ;)


Adds the paramedic job to barratry

About the PR

adds paramedic to barratry
part of #22146
and #22145
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog
:cl: JoeHammad

add: Paramedics are now available on barratry

PR speedrun by the way


"noice" better to be replaced by "novice"

i think "noice" better to be replaced by "novice", am i right?

Hi, thanks for the PR!
But this is not a typo, it's a slang word for "nice" :)


auto timeout long running queries

Long-running queries recently brought down chainquery. We should time them out with a nice error.

I spoke with @nikooo777 about this today. Now that we configured things for replication, we should just have a replicated server for non-lbry environments. Chainquery can run the api server as well so the sql api can be available for the machine.


Support output for standard Wasm imports

Deno 2.1 added support for standard Wasm modules (though there was a bug where it was missing exports like memory, though that's now fixed in the latest canary version deno upgrade canary or in the released version if this is being read after November 28th).
https://docs.deno.com/runtime/reference/wasm/#wasm-modules
It would be really cool to have support for it in wasm-bindgen because it would mean that the .wasm files would be part of the module graph, so remote Deno modules wouldn't need to do orchestration for downloading and caching the wasm files anymore.
Since Wasm modules are implemented in a standard way in Deno (or at least should be 😅), this should translate to having support for the browser as well.
Edit: Or I guess this is the "bundler" output? I didn't test yet if it works with imports.

Edit: Or I guess this is the "bundler" output? I didn't test yet if it works with imports.

Unfortunately I have absolutely no idea about Deno or the bundler output. I will also have a hard time reviewing something I absolutely have no understanding of.
In conclusion: I'm happy to do my best to review fixes to existing targets, but adding a new target is out of the cards unless someone steps up and offer long-term maintenance for that target in wasm-bindgen.

I renamed the title. This is not Deno specific. It's just standard Wasm imports, which feels like something this project would want to support? It would allow dropping a bunch of the outputs in the future.
https://github.com/WebAssembly/esm-integration/blob/main/proposals/esm-integration/EXAMPLES.md

That's definitely in scope.


Fix XMLParser with special elements.

Stitch uses a .NET XML format to nicely write out html documents.  There are some special characters that users can put in (an ampersand, &, for example) we need to find a work around for these.

This was an issue with special characters, like &, not being HTML encoded.  The fix is that the user will HTML encode their special characters.


Issue while torch installation on R Studio workbench

JIRA: https://issues.redhat.com/browse/RHOAIENG-368
What steps did you take and what happened:
Trying to install “torch”- package. Have no idea what the immediate fix is.. It is likely due to missing the cmake package. Would be nice to try it again after the required package in the previous comment is installed.
{standard input}: Assembler messages:
{standard input}:14785460: Warning: end of file not at end of a line; newline inserted
g++: fatal error: Killed signal terminated program cc1plus
compilation terminated.
make: *** [/usr/lib64/R/etc/Makeconf:200: RcppExports.o] Error 1
ERROR: compilation failed for package ‘torch’
* removing ‘/opt/app-root/src/Rpackages/4.2/torch

What did you expect to happen:
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

OpenDatahub Version: (please check the operator version)
Workbench: (all, data-science, etc)
Workbench Version: (2023.1, etc)
Specific tool: RStudio
Notebook-Controller Version: (please check the image version in notebook-controller deployment)

Logs/Screenshots
Acceptance criteria

[ ] Execute the installation on the image, and debug the result.

Closing this issue as we have the jira: https://issues.redhat.com/browse/RHOAIENG-368.


WorldWind multi-point MilStdSymbols are not drawing correctly

MilStd multi-point symbols are drawing incorrectly or not at all.

AssemblyArea and Boundary are two examples that will not draw
Contain does not draw correctly

Reintegrate, tested Boundary, Assembly Area, and Contain and all were drawn on the map correctly.


allow any RNG, improve SA example

Resolves #138.
The old example was overwriting previous param_n iterations so I fixed that.
Rosenbrock in the example could also allow any RNG if we remove the Default implementation.

oh huh, never worked with a cargo fmt --check CI. It wants me to move use rand::distributions::Uniform; up to join the other rand stuff I guess

Thanks for this PR! I'm sorry about the delayed reply. Seems like the CI is failing on the tests. Could you have a look please? Thanks! :)

Oh I didn't update the test code. I tried to run tests locally but couldn't due to an esoteric ndarray linker error. tests.rs is the only file which requires it so this time I disabled it locally.

Thanks for adapting the tests, the CI passes now. It would be great if you could adapt the example to use clamp instead of min and max. Otherwise it is ready to go. Thanks a lot for your work! :)

Looks good now. Thanks a lot once more for your work and for improving the English in the comments! :)


Dos it work with SDXL?

I tried to use Latent Couple with SDXL, it seems not working most of the time, especially with more than 2 people, I wonder if this extension is not meant to work with SDXL, I had the output size set to 1024 by 1024, so there should be enough space for 3 people that each is supposed to occupy 1/3 of the region, but the results may contain one or two people, hard to have three.

With 2 persons it is working me in SDXL. With 3 persons it is hard. Try to change aspect ratio from 1:1 to for exaple 16:9. This mean 1280 x 819 or 820 (somethink like higher HD resolution) if you want to use full SDXL capability. Or maybe 5:3. I think that this is about that you need enough space for 2 persons. Simply aspect ratio where image is wider then higher.
I'm thinking about test to use 3 person with ControlNet. My idea is to force persons presence by OpenPose. This will also fully control persons position in image.


Tweak the disabled files text color in FileDialog for readability

Contrast rate is still fairly low, but the text needs to be easy enough to distinguish from non-disabled items.
This partially addresses https://github.com/godotengine/godot-proposals/issues/4566.
Preview

Before
After

Needs classref update, otherwise seems good.

Thanks!

Cherry-picked for 3.5.


Grabbing ntpClientRecvTime Twice

In udpSocket: didReceiveData: fromAddress: withFilterContext: you grab the ntpClientRecvTime, then you call decodePacket: and grab it again right after?
I assume the 2nd one should be skipped, plus it'll be about 8 nanoseconds later.

It would seem the second assignment is unnecessary (though 8 nanoseconds don't amount to a hill of beans in this code) !!

On Aug 3, 2017, at 3:53 PM, Victor Stewart<EMAIL_ADDRESS>wrote:
In udpSocket: didReceiveData: fromAddress: withFilterContext: you grab the ntpClientRecvTime, then you call decodePacket: and grab it again right after?
I assume the 2nd one should be skipped, plus it'll be about 8 nanoseconds late.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


jjb: correctly set the storage method

setting want_ceph is useless, as it is overwritten by storage_method

Does storage_method=none imply swift? Or what will ensure there will be no ceph?

Does storage_method=none imply swift? Or what will ensure there will be no ceph?

case "$storage_method" in
  none)
    want_ceph=0
    want_swift=0
    ;;
  swift)
    want_ceph=0
    want_swift=1
    ;;
  ceph)
    want_ceph=1
    want_swift=0
    if [[ $nodenumber < 5 ]] ; then
      export nodenumber=5
    fi
    cephvolumenumber=2
    ;;
  *)
    unset want_ceph
    unset want_swift
esac

@jsuchome the values are (see also comment of the variable storage_method of the openstack-mkcloud job):

none: mkcloud will not deploy ceph or swift at all (you have to make sure that a storage is added otherwise to the deployed cloud)
default: mkcloud will pick the storage method (depending on other settings, like nodenumber)
ceph: enforces deployment of ceph
swift: enforces deployment of swift

I thinnk we want swift backend for upgrade, so we have it as glance backend

@jdsn @jsuchome updated to swift


Example: irradiation_planar fails

Traceback (most recent call last):
  File "E:\intership\Scarce-master\scarce\examples\irradiation_planar.py", line 122, in <module>
    transient_irrad()
  File "E:\intership\Scarce-master\scarce\examples\irradiation_planar.py", line 75, in transient_irrad
    _, _, I_ind_e, I_ind_h, T, _ = dd.solve(p0, q0, dt, n_steps)
ValueError: too many values to unpack

this issue is currently solved by adding two more ",_" before the "=", since the "dd.solve()" returns 8 objects


Use crossbeam_deque::Injector instead of crossbeam_queue::SegQueue

Injector and SegQueue are almost identical, down to the very same
comments in their implementations. One difference is that Injector
allocates its first block as soon as it's created, but SegQueue waits
until its first push, which complicates it to allow being null.
Injector also has methods to steal batches into a deque Worker,
which might be useful to us.
At the very least, this lets us trim a dependency.

bors r+


Blob_Id_V3 encrypted bit decommitment.

Ignore V3 encrypted bit in BlobId#toBytes, BlobId#getID and BlobId#toString.
V3 isEncrypted is valid in frontend memory for metrics.

Codecov Report

Merging #899 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #899      +/-   ##
============================================
- Coverage     67.22%   67.09%   -0.13%
+ Complexity     4278     4266      -12
============================================
  Files           356      356
  Lines         27887    27893       +6
  Branches       3547     3547
============================================
- Hits          18746    18715      -31
- Misses         8164     8186      +22
- Partials        977      992      +15

Impacted Files
Coverage Δ
Complexity Δ

...src/main/java/com.github.ambry.commons/BlobId.java
83.14% <100%> (+0.58%)
50 <0> (+1)
:arrow_up:

...c/main/java/com.github.ambry.network/Selector.java
78.48% <0%> (-3.59%)
44% <0%> (-1%)

...github.ambry.rest/AsyncRequestResponseHandler.java
88.59% <0%> (-2.29%)
23% <0%> (ø)

....github.ambry.router/NonBlockingRouterMetrics.java
89.37% <0%> (-1.64%)
27% <0%> (-4%)

.../com.github.ambry.router/GetBlobInfoOperation.java
81.81% <0%> (-1.22%)
34% <0%> (-1%)

...in/java/com.github.ambry.store/BlobStoreStats.java
69.61% <0%> (-1.2%)
80% <0%> (-2%)

...ava/com.github.ambry.router/NonBlockingRouter.java
80.46% <0%> (-1.18%)
40% <0%> (-3%)

...b.ambry.network/BlockingChannelConnectionPool.java
62.6% <0%> (-0.87%)
7% <0%> (-1%)

...java/com.github.ambry.router/GetBlobOperation.java
90.43% <0%> (-0.84%)
34% <0%> (-1%)

...in/java/com.github.ambry.network/SocketServer.java
82.78% <0%> (-0.41%)
13% <0%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94b460...5152461. Read the comment docs.

To decommit encryption bit in Blob V3, isEncrypted() will return False only.
However, some metrics rely on BlobId.isEncrypted().
Some of them were fixed by restUtils.isEncyrpted(BlobIdString)
Some of them were fixed by blobInfo.isEncrypted()
But in some error paths, blobInfo and blobIdString are not available. We are not able to do the right metric tracking for these paths.

LGTM


Add constructor with parameters to Injector

This makes is possible to declare final variables in Injector components

This is similar to how Spring does it.
It could look like this:
public class MyComponentImpl implements MyComponent {

    private final OneDependency one;
    private final AnotherDependency two;

    @Inject // <-- This allows the use of final injected fields
    MyComponentImpl(OneDependency one, AnotherDependency two) {
        this.one = requireNonNull(one);
        this.two = requireNonNull(two);
    }
}


Support icon in Content Header

Support header icon.
Usage:
$content->headericon('fa-home');

Sample:

@z-song
Sorry, I mistaked.
I re-commited so please check again.