Fix Clippy errors with Rust 1.66/1.67

Rust 1.66.0 is due out as stable today.
Under that version the following new Clippy errors are shown:
$ cargo clippy --all-targets
warning: the borrowed expression implements the required traits
   --> libcnb/src/layer/handling.rs:266:42
    |
266 |     default_on_not_found(fs::remove_file(&layer_toml))?;
    |                                          ^^^^^^^^^^^ help: change this to: `layer_toml`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

warning: variables can be used directly in the `format!` string
  --> libcnb/src/buildpack.rs:48:9
   |
48 |         eprintln!("> {:?}", error);
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
note: the lint level is defined here
  --> libcnb/src/lib.rs:2:9
   |
2  | #![warn(clippy::pedantic)]
   |         ^^^^^^^^^^^^^^^^
   = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]`
help: change this to
   |
48 -         eprintln!("> {:?}", error);
48 +         eprintln!("> {error:?}");
   |

warning: `libcnb` (lib) generated 2 warnings
warning: the borrowed expression implements the required traits
  --> libcnb-test/src/build.rs:46:9
   |
46 |         &cargo_manifest_dir.join("buildpack.toml"),
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `cargo_manifest_dir.join("buildpack.toml")`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default

warning: `libcnb-test` (lib) generated 1 warning
warning: `libcnb-test` (lib test) generated 1 warning (1 duplicate)
warning: variables can be used directly in the `format!` string
  --> libherokubuildpack/src/error.rs:66:51
   |
66 |             log_error("Internal Buildpack Error", format!("{}", libcnb_error));
   |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
note: the lint level is defined here
  --> libherokubuildpack/src/lib.rs:3:9
   |
3  | #![warn(clippy::pedantic)]
   |         ^^^^^^^^^^^^^^^^
   = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]`
help: change this to
   |
66 -             log_error("Internal Buildpack Error", format!("{}", libcnb_error));
66 +             log_error("Internal Buildpack Error", format!("{libcnb_error}"));
   |

warning: `libherokubuildpack` (lib) generated 1 warning
warning: `libherokubuildpack` (lib test) generated 1 warning (1 duplicate)
warning: the borrowed expression implements the required traits
   --> libcnb/src/layer/handling.rs:880:28
    |
880 |         fs::create_dir_all(&layer_dir).unwrap();
    |                            ^^^^^^^^^^ help: change this to: `layer_dir`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits
   --> libcnb/src/layer/handling.rs:913:28
    |
913 |         fs::create_dir_all(&layer_dir).unwrap();
    |                            ^^^^^^^^^^ help: change this to: `layer_dir`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits
   --> libcnb/src/layer/handling.rs:943:28
    |
943 |         fs::create_dir_all(&layer_dir).unwrap();
    |                            ^^^^^^^^^^ help: change this to: `layer_dir`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits
   --> libcnb/src/layer/tests.rs:475:24
    |
475 |     fs::create_dir_all(&test_layer_dir).unwrap();
    |                        ^^^^^^^^^^^^^^^ help: change this to: `test_layer_dir`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits
   --> libcnb/src/layer/tests.rs:483:9
    |
483 |         &test_layer_toml,
    |         ^^^^^^^^^^^^^^^^ help: change this to: `test_layer_toml`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits
   --> libcnb/src/layer/tests.rs:565:24
    |
565 |     fs::create_dir_all(&test_layer_dir).unwrap();
    |                        ^^^^^^^^^^^^^^^ help: change this to: `test_layer_dir`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits
   --> libcnb/src/layer/tests.rs:573:9
    |
573 |         &test_layer_toml,
    |         ^^^^^^^^^^^^^^^^ help: change this to: `test_layer_toml`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits
   --> libcnb/src/layer/tests.rs:644:24
    |
644 |     fs::create_dir_all(&layer_dir).unwrap();
    |                        ^^^^^^^^^^ help: change this to: `layer_dir`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits
   --> libcnb/src/layer/tests.rs:674:9
    |
674 |         &layer_toml_path,
    |         ^^^^^^^^^^^^^^^^ help: change this to: `layer_toml_path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits
  --> libcnb/src/platform.rs:90:24
   |
90 |         fs::create_dir(&dummy_dir).unwrap();
   |                        ^^^^^^^^^^ help: change this to: `dummy_dir`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits
   --> libcnb/src/platform.rs:107:48
    |
107 |         std::os::unix::fs::symlink(&dummy_dir, &dst_symlink).unwrap();
    |                                                ^^^^^^^^^^^^ help: change this to: `dst_symlink`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: `libcnb` (lib test) generated 13 warnings (2 duplicates)

And then under Rust 1.67.0 (currently in beta, and what I run locally), the following additional errors are shown:
$ cargo clippy --all-targets
warning: used `seek` to go to the start of the stream
  --> libherokubuildpack/src/tar.rs:12:13
   |
12 |     tarball.seek(SeekFrom::Start(0))?;
   |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `rewind()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#seek_to_start_instead_of_rewind
   = note: `#[warn(clippy::seek_to_start_instead_of_rewind)]` on by default

warning: `libherokubuildpack` (lib) generated 1 warning
warning: `libherokubuildpack` (lib test) generated 1 warning (1 duplicate)
warning: variables can be used directly in the `format!` string
   --> libcnb/src/layer/handling.rs:544:17
    |
544 | /                 panic!(
545 | |                     "Expected WriteLayerError::MissingExecDFile, but got {:?}",
546 | |                     other
547 | |                 );
    | |_________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
    = note: `#[warn(clippy::uninlined_format_args)]` on by default

warning: `libcnb` (lib test) generated 1 warning

The vast majority of these were fixed using the --fix option to cargo clippy.
GUS-W-12225195.

Restarted unit-test check as cache restore was hanging.


Sensor not created

Describe the Bug
After installing the repo, integration installs and server is listed with 0 entities
The Error
No error; just no sensor created, nothing to do
Indicate if you followed all steps in the troubleshooting doc
No troubleshooting as the upcoming media card can't be used without the sensor
What data does the sensor display if any?
None, it's never created
Home Assistant Version
2023.10.3
Additional Context

I'm seeing this too. Ever figure out a solution?


Fixed #30036 -- Removed unused imports in pagination example.

https://code.djangoproject.com/ticket/30036

There were a couple of other flake8 issues, but I don't know if the docs examples need to be compliant...


remove Friday's recycling/compostable material

all material must be removed from Nash Hall at the end of  each day.

done and done


Feat/revproxy istio support

Jira Ticket: PXP-xxxx

[ ] Remove this line if you've changed the title to (PXP-xxxx):

New Features
Breaking Changes
Bug Fixes
Improvements

Support for ISTIO service mesh proxy

Dependency updates
Deployment changes

Hey @andrzejgrzelak, I'm on the Gen3 team and we're interested in merging this PR. I did notice it was marked as a draft, are you interested in moving forward? I do have a few small questions, and we'd need to set up an Istio environment for ourselves to test.

Hey @AidanHilt
This is marked draft because those changes do not cover all problems that you will encounter with istio. It only fixed obvious problems that revproxy had.
I planned to continue adding next steps as my project will implement them, but later we found out that this is not worth our effort, especially regarding workspaces feature so we disabled istio for our project completely.
This means that I probably won't finish this istio integration. If you want you can go from here and finish it.


Top layer of CFFC design is shorted

The top and bottom layers of the Cffc inductor designs appear shorted out.

Closed by PR #5


[7.13] [elasticsearch] only configure ES_JAVA_OPTS when value is set (#1089)

Backports the following commits to 7.13:

[elasticsearch] only configure ES_JAVA_OPTS when value is set (#1089)

jenkins test this please


Error downloading course

i am trying to download a course using organization login and i get the following error
[*] : Trying to login as organization (calgarylibrary.ca)...
[+] : Logged in successfully.
Traceback (most recent call last):on ..
File "C:\lyndadl\lynda-dl.py", line 395, in
main()
File "C:\lyndadl\lynda-dl.py", line 391, in main
lynda.course_download(path=options.output, quality=options.quality)
File "C:\lyndadl\lynda-dl.py", line 162, in course_download
course = lynda.course(url=self.url, username=self.username, password=self.password, organization=self.organization, cookies=self.cookies)
File "C:\lyndadl\lynda_lynda.py", line 38, in course
return Lynda(url, username, password, organization, cookies, basic, callback)
File "C:\lyndadl\lynda_internal.py", line 43, in init
super(InternLyndaCourse, self).init(*args, **kwargs)
File "C:\lyndadl\lynda_shared.py", line 65, in init
self._fetch_course()
File "C:\lyndadl\lynda_internal.py", line 55, in _fetch_course
self._info              =       self._real_extract(self._url)
File "C:\lyndadl\lynda_extract.py", line 257, in _real_extract
_lynda['assets'] = self._extract_assets(course_id)
File "C:\lyndadl\lynda_extract.py", line 157, in _extract_assets
entry.update(self._extract_asset_download_url(url='https://www.lynda.com/ajax/{href}'.format(href=entry.get('download_url'))))
File "C:\lyndadl\lynda_extract.py", line 138, in _extract_asset_download_url
return {'type' : 'file', 'file_size' : int(response.headers.get('Content-Length')), 'download_url' : response.url, 'extension' : response.headers.get('Content-Type').split('/')[-1]}
TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'

I am getting the sane issue and this issues only happen for the courses that have multiple exercise file links like 10 20 or more.
raceback (most recent call last):on ..   File "D:\webserver\PythonPractice\lynda\lyndadl.py", line 244, in <module>     pat  = os.path.join('some', 'test', 'sample')   File "D:\webserver\PythonPractice\lynda\lyndadl.py", line 238, in main     lynda.course_download(path=output, quality=quality)   File "D:\webserver\PythonPractice\lynda\lyndadl.py", line 162, in course_download     course = lynda.course(url=self.url, username=self.username, password=self.password, organization=self.organization, cookies=self.cookies)   File "D:\webserver\PythonPractice\lynda\lynda\_lynda.py", line 16, in course     return Lynda(url, username, password, organization, cookies, basic, callback)   File "D:\webserver\PythonPractice\lynda\lynda\_internal.py", line 21, in __init__     super(InternLyndaCourse, self).__init__(*args, **kwargs)   File "D:\webserver\PythonPractice\lynda\lynda\_shared.py", line 44, in __init__     self._fetch_course()   File "D:\webserver\PythonPractice\lynda\lynda\_internal.py", line 33, in _fetch_course     self._info              =       self._real_extract(self._url)   File "D:\webserver\PythonPractice\lynda\lynda\_extract.py", line 235, in _real_extract     _lynda['assets'] = self._extract_assets(course_id)   File "D:\webserver\PythonPractice\lynda\lynda\_extract.py", line 135, in _extract_assets     entry.update(self._extract_asset_download_url(url='https://www.lynda.com/ajax/{href}'.format(href=entry.get('download_url'))))   File "D:\webserver\PythonPractice\lynda\lynda\_extract.py", line 116, in _extract_asset_download_url     return {'type' : 'file', 'file_size' : int(response.headers.get('Content-Length')), 'download_url' : response.url, 'extension' : response.headers.get('Content-Type').split('/')[-1]} TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'


all: add GOARM64=v8.1 and so on

Similar to: https://github.com/golang/go/issues/45453.
Each ARM sub-architecture iteration adds some new instructions, some of which may be useful for Go. For example, ARMv8.2 introduced:

v8.2: FEAT_LSE, Large System Extensions (though it looks like there have been changes to this extension in later iterations)

LDADD (atomic add), useful for atomic.Add*.
CAS (compare and swap), useful for atomic.CompareAndSwap*
SWP (swap), useful for atomic.Swap*
...more similar atomic instructions.

These instructions are already used after a capability check (thanks @prattmic for pointing this out). These capability check jumps predict perfectly, but the blocks aren't tiny either (godbolt):

It might be useful to define some new possible GOARM values akin to GOAMD to elide these checks, potentially increasing performance and reducing binary sizes by some tiny amount. I have not done any performance measurements, but received hearsay from colleagues that using these instructions was a significant win for them (but I did not ask whether they used a capability check or whether they were comparing with always using the less capable version).
Other potential candidate:

v8.1: FEAT_CRC32, Changes to CRC32 instructions (made mandatory)
v8.8: FEAT_MOPS, Standardization of memory operations, slides). runtime.memmove is >1% of cycles when looking at data available here. Using FEAT_MOPS unconditionally could also have good icache effects.
v8.8: FEAT_HBC, Hinted conditional branches (perhaps indented branches or anything that can be proven to contain a non-nil error via dataflow could be hinted "unlikely").

The currently valid values for GOARM are 5, 6, and 7.  Are you suggesting that we add 8 and 8.1 as valid values?

It would be surprising to have GOARM used both by GOARCH=arm and GOARCH=arm64 imo should be a GOARM64=8, GOARM64=8.1, ...

Good point, thanks, it should be GOARM64.
That may mean that we don't need to be compatible with GOARM, and could use v8, v8.1, ....

The leading v seems like it emphasizes that this is the ARMv8.1 v numbers not any other kind of ARM numbering (like ARM11 which implements ARMv6). It also makes sure that nothing tries to strconv.Atoi("8") and then get messed up by strconv.Atoi("8.1"). So I think we should keep the leading v.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

I would like to sound extra support for retaining v and emphasize that it's not a number -- a number is not enough to represent Arm capabilities.
Currently Arm defines Armv8.0~Armv8.9 and Armv9.0~Armv9.3, but Armv9.0 is not the next version of Armv8.9, it actually branched off Armv8.5. Parsing the version into number will create an illusion of linear progression.
Further, each of these versions are actually "extensions." Each extension defines a number of "features," e.g. FEAT_LSE, with some being mandatory and some optional. Some, like LSE, are optional up to a version (8.1) and then become mandatory later (8.2).
Because of this, both gcc and clang have complicated ways to precisely specify what Arm version to target: https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html#index-march-2, https://lists.llvm.org/pipermail/llvm-dev/2018-September/126346.html
In this system, the compiler cannot assume the target machine has LSE instructions if we only compile with -march=armv8.1-a and thus needs to emit capability tests. But -march=armv8.1-a+lse means targeting a machine that implements all the mandatory features defined in v8.1 extension, but also assume the machine has LSE, which would be enough for the compiler to skip the capability test and use instructions like LDADD directly.
My suggestion is we also implement similar notations in GOARM64 so that GOARM64=v8.2 and GOARM64=v8.1+lse both suffice in using LSE instructions directly.

Is there a list of all the ARM64 versions somewhere, so we know what to accept?
As far as adding other modifiers, the other architectures have set the precedent of using comma-separated lists, so it would be GOARM64=v8.1,lse not v8.1+lse.

I believe the canonical source is the ARM Architecture Reference Manual. Chapter A2 describes the versions. It is not at all consise; a summary table would be nice, but it does describe the requirements if you dive into the details. e.g., "FEAT_SB, Speculation Barrier ... This feature is OPTIONAL in Armv8.0 implementations and mandatory in Armv8.5 implementations."
The full list of features is very long. I'm personally a bit skeptical about having GOARM64 accept the full set when we'll likely only adjust compilation based on a few of them.

Sorry, I wasn't asking for the full set of features, only for the full set of version numbers, which I hope is much smaller.

We need the full set so we know which (older) build tags to enable when we have GOARM64=v8.3 for example.

Those are easier! From the same chapter, I believe the full set of versions is v8.0 through v8.9 and v9 [1] through v9.3.
[1] The document uses the name v8.0 for the first v8 version, but v9 (not v9.0) for the first v9 version. I'm not sure if that is an intentional difference or not.

It is also worth noting that v8 and v9 overlap.

v9 implements v8.5
v9.1 implements v8.6
v9.2 implements v8.7
v9.3 implements v8.8
(I don't know why there is no v9.4 for v8.9...)

i.e., the v9 build should not include the v8.6 build tag.

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

[1] The document uses the name v8.0 for the first v8 version, but v9 (not v9.0) for the first v9 version. I'm not sure if that is an intentional difference or not.

I think V9.0 is the first version of V9, and V9 is the major version number. There is also V9.0 in the document, non-strictly we can say that V9 refers to V9.0, but V9.0 is more accurate.

(I don't know why there is no v9.4 for v8.9...) Edit: https://community.arm.com/arm-community-blogs/b/architectures-and-processors-blog/posts/arm-a-profile-architecture-2022 mentions a v9.4 to accompany v8.9, but it seems to be missing from the manual.

From here https://developer.arm.com/documentation/ka005398/1-0/?lang=en v9.4 should be compatible with v8.9.

[1] The document uses the name v8.0 for the first v8 version, but v9 (not v9.0) for the first v9 version. I'm not sure if that is an intentional difference or not.

The v9.0 is still the first version of v9.  This document https://developer.arm.com/documentation/102378/0201/Processor-implementation?lang=en mentions that Armv9.0-A is the base specification and original release.

Given that this is accepted, in triage I think we've determined that we just need someone to work on it. If you plan to work on it, please reply here and I'll remove the help wanted label. Thanks!

I'm thinking about some implementation details for this, would be good to clarify if this makes sense from what I gathered from the comments here.
Sounds like we have two main toggles, the version number (vX.X) and the feature set (e.g FEAT_LSE).
These two can be mixed and matched in a couple ways:

Versions might have a certain feature out of the box (eg v8.1 ships with LSE)
Others might have optional features (eg v8.1 has optional FEAT_SB)
Some versions implement protocols from another version (eg v9.0 inherits the set of features from v8.5, its own plus any optional features)

So we need to take proper care in order to validate that this mix of pairs is enforced properly.
Syntax would be GOARM64=vX.X,lse,sb, version followed by a comma separated list of optional features.
From what I understood the idea is to reduce the amount of instructions being put on the final binary by selectively filtering certain cpu capabilities. Regarding the actual implementation, should we follow the same approach as amd64 flags, for example avx2, where there is a proper guard  at runtime to prevent certain instructions from being used if the cpu does not support them?
eg
#ifndef hasArm64LSE
	CMPB	internal∕cpu·arm64+const_offsetArm64HasLSE(SB), $1
	JEQ     optimized_atomic
	JMP	generic_atomic
#else
	JMP	optimized_atomic
#endif

Also the SSA should be aware of these flags and versions in order to emit instructions based on the selected features?

I have first version of a patch adding support for GOARM64 + unconditional atomics for ARM8.1/LSE ready. Unless someone else is also happen to work on this at the moment and ready to publish his/her changes (@mauri870 ?), let me get stub on this and publish my patch early next week (I still need to comb it before public code review; also, I will split the patch to two: one just adding GOARM64 and another that actually uses GOARM64 for atomics). @mknyszek , please remove "help wanted" label.
For reference, "go test -bench" expectedly shows huge gains for runtime/internal/atomic package:
goos: linux
goarch: arm64
pkg: runtime/internal/atomic
                 │    old.txt    │                 new.txt                 │
                 │    sec/op     │    sec/op      vs base                  │
AtomicLoad64-96    0.4814n ± ∞ ¹   0.7701n ± ∞ ¹         ~ (p=1.000 n=1) ²
AtomicStore64-96    3.851n ± ∞ ¹    3.851n ± ∞ ¹         ~ (p=1.000 n=1) ³
AtomicLoad-96      0.7698n ± ∞ ¹   0.4812n ± ∞ ¹         ~ (p=1.000 n=1) ²
AtomicStore-96      3.851n ± ∞ ¹    3.850n ± ∞ ¹         ~ (p=1.000 n=1) ²
And8-96            10.010n ± ∞ ¹    7.314n ± ∞ ¹         ~ (p=1.000 n=1) ²
And-96             10.010n ± ∞ ¹    7.313n ± ∞ ¹         ~ (p=1.000 n=1) ²
And8Parallel-96     47.28n ± ∞ ¹   308.70n ± ∞ ¹         ~ (p=1.000 n=1) ²
AndParallel-96      44.21n ± ∞ ¹   246.80n ± ∞ ¹         ~ (p=1.000 n=1) ²
Or8-96             10.010n ± ∞ ¹    7.315n ± ∞ ¹         ~ (p=1.000 n=1) ²
Or-96              10.010n ± ∞ ¹    7.319n ± ∞ ¹         ~ (p=1.000 n=1) ²
Or8Parallel-96      42.97n ± ∞ ¹   247.20n ± ∞ ¹         ~ (p=1.000 n=1) ²
OrParallel-96       43.32n ± ∞ ¹   248.20n ± ∞ ¹         ~ (p=1.000 n=1) ²
Xadd-96             42.79n ± ∞ ¹   243.20n ± ∞ ¹         ~ (p=1.000 n=1) ²
Xadd64-96           42.45n ± ∞ ¹   242.40n ± ∞ ¹         ~ (p=1.000 n=1) ²
Cas-96              85.03n ± ∞ ¹    93.75n ± ∞ ¹         ~ (p=1.000 n=1) ²
Cas64-96            84.99n ± ∞ ¹    91.80n ± ∞ ¹         ~ (p=1.000 n=1) ²
Xchg-96             42.45n ± ∞ ¹   242.50n ± ∞ ¹         ~ (p=1.000 n=1) ²
Xchg64-96           42.38n ± ∞ ¹   243.30n ± ∞ ¹         ~ (p=1.000 n=1) ²
geomean             16.06n          33.04n        +105.69%
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05
³ all samples are equal

but more importantly, this patch shows repeatable +4.6% performance gain for a real-world application (etcd) on my ARM64 server (Kunpeng920 chip).

Thanks for your efforts, @andreybokhanko! I've only begun collecting some notes and haven't started working on an implementation. I'll be happy to review yours!

https://go-review.googlesource.com/c/go/+/559555 submitted.
@rsc @mauri870 Please kindly review.

Change https://go.dev/cl/559555 mentions this issue: cmd/dist,internal: add ARM64 environment variable

Note that current code reviews discussion leans towards dropping support for ",lse" and ",crypto", as nobody gave an example of real ARM hardware that implements LSE and not fully supports 8.1 -- as well as real ARM hardware that implements crypto and not fully supports 8.1.

A fix is landed to mainline (https://go-review.googlesource.com/c/go/+/559555), so this can be closed.

Assuming this issue only tracked the addition of the GOARM64 variable, it looks like it can be closed.


Make the bot follow multiple users

Fixes https://github.com/codetheweb/aoede/issues/31

Added a bunch of upgrades as well

Tested to be working just fine
Required breaking change:
DISCORD_USER_ID is now DISCORD_ADMINS which is a list
For supplying via env vars, DISCORD_ADMINS = '["user1","user2"]'

Thanks for the quick review, will resolve the requested changes

Did any feature like this ever get merged into the main branch?


Control+Space (aka C-@ aka NUL) is not being sent

Windows Terminal Preview Version: 1.13.10395.0
Windows Version: [Version 10.0.19043.1466]
User Action:
Connect to a bash prompt. Run od -c to see the exact characters that are received.
Type in Control '@' (Control Shift 2 on a US keyboard)
Expected Result:
The od -c invocation should look like this.
od -c
^@^@^@^@^@^@
0000000  \0  \0  \0  \0  \0  \0  \n

That's the output that I receive when I do the test through putty.
Actual Result:
Nothing. The invocation of od -c is unaware that anything has been sent.
Comments:
I know this issue has some history so I can appreciate if its something that is not easily resolved.

Ctrl+Space works for me, but it seems that's not the case for everyone. I think this is probably covered by issue #11721.

Don't know how to enter in Windows terminal, where to go and when I tipe @ when i am tipping apt-get and other. I'm not sure what to do. Want to learn more about security and terminal services security but I need help from someone who understands all staff about it. Thank you for your time.
Get Outlook za Androidhttps://aka.ms/AAb9ysg

From: Eric Johnson @.>
Sent: Saturday, February 12, 2022 7:08:56 PM
To: microsoft/terminal @.>
Cc: Subscribed @.***>
Subject: [microsoft/terminal] Control+Space (aka C-@ aka NUL) is not being sent (Issue #12481)
Windows Terminal Preview Version: 1.13.10395.0
Windows Version: [Version 10.0.19043.1466]
User Action:
Connect to a bash prompt. Run od -c to see the exact characters that are received.
Type in Control '@' (Control Shift 2 on a US keyboard)
Expected Result:
The od -c invocation should look like this.
od -c
^@^@^@^@^@^@
0000000  \0  \0  \0  \0  \0  \0  \n
That's the output that I receive when I do the test through putty.
Actual Result:
Nothing. The invocation of od -c is unaware that anything has been sent.
Comments:
I know this issue has some history so I can appreciate if its something that is not easily resolved.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/terminal/issues/12481, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AV46347XF3W55OOQEE4DYK3U22O3RANCNFSM5OHIA7AQ.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

I wonder if there's a difference in the particular ssh binaries that we are running from within the Windows Terminal powershell environment that is getting in the way. My hand wavy thought process is - I wonder if the Windows Terminal is handling it, but hands it over to the ssh process which then properly drops it on the floor.

Yea, I'd suspect that this is a problem with your particular SSH client / server. We're definitely capable of sending NULs on Ctrl+Space, but NULs are hard and there's a lot of pieces in the system. We should continue the discussion in /dup #11721


Android GLES3 doesn't clear depth buffer

Godot version:
Commit 4e0eb752c2bfd7aac05023af67cd368061012bab
OS/device including version:
Xiaomi Pocophone F1 (https://en.wikipedia.org/wiki/Xiaomi_Pocophone_F1), looks like its running an Adreno 630 GPU
Issue description:
Alright, surprised to find out GLES3 is working on this phone :)
Renders find until you start to move/animate 3D objects, looks like it is not clearing the depth buffer after each frame and drawing black where the object is now behind its previous position.
Haven't figured out yet how to take a screenshot on this phone...
Steps to reproduce:
Create a simple 3D scene, add a camera, add a cube, add some logic to rotate the cube
Minimal reproduction project:
test_android.zip

@akien-mga this could be a regression related to the changes we did for iOS.

Note that the test project runs fine on GLES2

probably it's related with #25994
because the depth prepass is off on mobile for default. so it's same condition.

@BastiaanOlij does it look like this? https://streamable.com/3ijyp
This is on Android using Calinou's build from d9cf780 on a SAMSUNG SM-T825(Adreno 530). Same issue on a Motorola XT1572 ( Adreno 418).
Works fine exporting with 3.1-beta4

@noidexe looks same with #25994
you can see it on desktop too if you disable depth prepass on project setting.

@noidexe that is indeed the issue :)
it makes sense it still worked in beta-4, I think this is a result from the fixes we applied iOS bringing this issue to light
@volzhs that makes sense, part of what was fixed was the fact that on mobile GPUs depth prepass is turned off. Wonder through why iOS isn't suffering the same fate now that it also have depth prepass turned off. Or maybe it will also fail on iOS but wasn't introduced yet the last time I tested. Might give it another go tonight.

Is this fixed by 8fd2eb6?

I've just tested it in the editor and on some Android devices and it seems it's fixed now.

Thanks!

Works fine for me now too :)


Research and fix the caching problem that causes edited posts to not show changes in feed

No introduction necessary. This is arguably our biggest UX complaint, since it scares people.

#1907


[Governance] Upgrade playbook and downstream investigation

Objective
Write the playbook on how we'll handle on-chain governance updates.
Origin Document

Cosmos upgrade module: https://docs.cosmos.network/v0.50/build/modules/upgrade
Morse RC-0.11 Release Plan: https://buildwithgrove.notion.site/RC-0-11-0-Release-Plan-6b33e7b7634f458796b1c3f0a3a2a994?pvs=4
Related to #622 but solely for on-chain purposes

Goals

Research and understand the tools available in the Cosmos SDK for governance upgrades (i.e. x/upgrade)
Identify missing gaps or differences between how we'll handle governance upgrades
Collaborate with the team at Informal Systems (CometBFT) or Binary Builders (Cosmos SDK) if need be

Deliverables

[ ] Manage a real consensus-breaking governance upgrade on TestNet
[ ] A copy-paste template + playbook + instructionsfor every governance upgrade
[ ] Answer the following questions:

[x] How do we handle consensus-breaking changes?
[x] How do we increase the block size like in Morse? (e.g. increase the block size)
[x] How do we activate a new feature at a specific height? (i.e. boolean feature switch)
[ ] Document protocol updates and governance upgrades

Non-goals / Non-deliverables

Implementing new features (e.g. features switches) if the need arises
Achieving complete parity with how Morse work

General deliverables

[ ] Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
[ ] Testing: Add new tests (unit and/or E2E) to the test suite.
[ ] Makefile: Add new targets to the Makefile to make the new functionality easier to use.
[ ] Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @Olshansk
Co-Owners: @okdas

The functionality and code examples are in #702, with more documentation incoming in #719

Both PRs are now merged. We're going to continue adding/chainging the process as we issue upgrades in Beta testnet.


Some info is missing in PartialAssemblySignature when signature file exists

Here're several cases which may be connected:

Consider a type with attributes declared in *.fs and *.fsi files. After type-checking the *.fs file and getting its partial assembly signature, the type contains attributes from the signature file only. When getting the same type via GetAllUsesOfAllSymbolsInFile, all attributes are shown.
When type-checking a signature file, its partial assembly signature doesn't contain types defined in this file (but contains files defined in previous files in the project).
When symbols are hidden by a signature file they do not appear in PartialAssemblySignature.

Hi @auduchinok
This is a bit tricky to fix - as you can imagine the way the compiler is set up the information is truly hidden.
What IDE features are you using PartialAssemblySignature for?
thanks

Hi @dsyme, thank you for the reply!
We're mapping FCS symbols to ReSharper ones during ReSharper cache population and resolve process. If a PartialAssemblySignature contains symbols from all files prior to the checked one, we're able to create proper ReSharper cache symbols to resolve to without additional checks of prior files in the project.
Currently we type-check the prior files to create ReSharper symbols when they are needed in resolve and using GetSymbolUseAtLocation (or GetAllUsesOfAllSymbolsInFile in some cases). It looks like caching the biggest available assembly signature and getting another if a bigger part of the project is needed may be a better strategy.


Add currying

Add curry and compose, curry all public API functions.
Both exact 2/3-ary functions and varargs functions are curried. Varargs functions are curried to a minimum number of args.  For example, since it doesn't make much sense to call combine with 2 args, most.combine is curried to 3 arg-minimum.  So, most.combine(f) returns combine curried with f, and most.combine(f, a) returns combine curried with f and a.  However, most.combine(f, a, b) calls combine, as does most.combine(f, a, b, c) etc.
That's totally up for discussion!  Another perfectly reasonable approach would be not to curry varargs functions at all.

There is at least one potential blocker: most.periodic has an optional argument to specify the value.  If you don't specify, it uses undefined.  But if we curry most.periodic it will mean that not supplying a value (i.e. only a time) lead to partial application.  That's a breaking change.  We could go back to most.periodic not accepting a value, and forcing callers to use .map or .constant to provide the value.  We could also not curry most.periodic, but I'd rather be consistent if we can.
So, I'm really not sure what's best.  Any thoughts?

You've convinced me that currying might be better in a future release. Lots to consider.

Closing this in favor of putting it on the roadmap and getting more feedback.


refactor(steps): make all steps submodules private

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.71%. Comparing base (690dbda) to head (97baa9f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   84.71%   84.71%
=======================================
  Files          21       21
  Lines        1531     1531
=======================================
  Hits         1297     1297
  Misses        234      234

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added timeout annotation to performance tests

Added TIMEOUT annotation to performance tests. Renamed MUTE10_04_A in MUTE10_04A (max source name length 10 char). Removed MUTE11_02 from performance tests.

Given all tests pass now I can approve it


buffer don't have space

buffer don't have space

buffer don't have space

have you solved this problem?


[ERROR DRT-0073] No access point for tile_prci_domain/tile_reset_domain/boom_tile/frontend/bpd/clock.

Describe the bug
This is from https://github.com/The-OpenROAD-Project/megaboom/commit/f5dd1af7841cf1c811a51206bda6f36b446ff335
untar https://drive.google.com/file/d/1BVX_h7KegG6F6Qa48d2bkDXRW-nZoL5e/view?usp=sharing
$ ./run-me-DigitalTop-asap7-base.sh
OpenROAD v2.0-11600-g1bb904876
[deleted]
[INFO DRT-0077]   Complete 2000 pins.
[INFO DRT-0077]   Complete 3000 pins.
[ERROR DRT-0073] No access point for tile_prci_domain/tile_reset_domain/boom_tile/frontend/bpd/clock.
[ERROR DRT-0073] No access point for tile_prci_domain/tile_reset_domain/boom_tile/core/FpPipeline/clock.
[ERROR DRT-0073] No access point for tile_prci_domain/tile_reset_domain/boom_tile/frontend/icache/auto_master_out_a_bits_address[0].
[ERROR DRT-0073] No access point for tile_prci_domain/tile_reset_domain/boom_tile/dcache/auto_out_a_bits_address[0].
[ERROR DRT-0073] No access point for subsystem_l2_wrapper/l2/auto_ctrls_ctrl_in_a_bits_address[0].
Error: detail_route.tcl, 69 DRT-0073
openroad>

Expected Behavior
No error
Environment
OpenROAD v2.0-11600-g1bb904876

To Reproduce
See above
Relevant log output
No response
Screenshots
No response
Additional Context
No response

The pin tile_prci_domain/tile_reset_domain/boom_tile/frontend/bpd/clock is completely covered by routing obstruction on M4 and M5. So there is no way to route to the pin.

@osamahammad21 I think this might be a red herring. I'll refile a github issue with more detail if it recoccurs.


perf: optimize loading context

Closes #42

:tada: This PR is included in version 0.0.14 :tada:
The release is available on:

v0.0.14
GitHub release

Your semantic-release bot :package::rocket:


Implement function/method to find the corners of a HEALPix pixel

This is already possible by using the dx/dy offsets, but we could provide a convenience function to help with this.

Done! (boundaries_lonlat)


algo::bellman_ford should return the source and target indices when returning the NegativeCycle error.

This can be useful when using bellman_ford to find negative cycles (e.g. in exchange arbitrage).

:smile: That's a fun idea, but I will actually close this. We don't need all loose ideas as issues. If this is an actual use case that you are pursuing, make sure to say so in the issue (and it will not be closed).
As always, I hope that algorithms can be built upon petgraph and just not in petgraph.


required and $error.required

I updated to this version of the control, and moved the control to a input group instead of the input type and I can't figure out how to make the angular error stuff work. Any suggestion ?

what do you mean by 'angular error stuff'


Accessibility checklist

The app needs to be as accessible to as many people as possible, especially when you consider the older population have generally been considered to be the most at-risk.

[ ] Support dynamic text sizing
[ ] Ensure VoiceOver works correctly
[ ] Post accessibility notifications when screen updates as necessary

Not a complete list but a few more features I can think of are:

[ ] Accessibility Labels, localised, short
[ ] Accessibility traits, buttons, image, headings
[ ] Order of UI elements when using VoiceOver
[ ] Grouping of UI elements, grouping labels and value labels that make sense
[ ] Supports Switch Control
[ ] Custom actions to reduce taps when using VoiceOver/Switch Control
[ ] VoiceControl, check Accessibility label length
[ ] Colour contrast on buttons and text


re-use http client in garbage collection to reduce number of open connections

Fixes #3995

Awesome! Turns out that design principles are still valid today! We should actually validate that dependency injection is implemented all around the scala/spark/java area if you ask me...

Actually this disappoints me: HTTP clients are supposed to re-use connections for you.  OkHttp is different, and the generated ApiClient code doesn't realize this.


Fix issue with unrecognized JVM option while running with Java 11

Motivation:
While running with Java 11, hit the following issue
# Created at 2023-10-03T16:18:21.784
JVMJ9VM007E Command-line option unrecognised: -D

# Created at 2023-10-03T16:18:21.786
Error: Could not create the Java Virtual Machine.

# Created at 2023-10-03T16:18:21.786
Error: A fatal exception has occurred. Program will exit.

Modification:
Update pom.xml to change new JVM option to default to -D_
Result:
Runs now don't hit this issue on JDKs other than 21

@normanmaurer Can I get a review for this? Found this issue while testing with the latest 4.1 changes related to the updates to Java21


[Feature] Low resolutions for low pcs

I'm using:

Device: Desktop
OS: Windows 10 Pro
Browser: Microsoft Edge

I want to suggest this feature:
My pc has an extremely bad cpu that has difficulty processing streaming at "high" resolutions. I would like them to add resolutions such as: 480p, 360p, 240p and 144p.

Duplicate #123
xCloud only supports 720p and 1080p.
The upcoming version will allow you to lower the video's quality a little bit. You can try it here: https://github.com/redphx/better-xcloud/raw/feature/translation/better-xcloud.user.js
It could help in your case. Set "Visual quality" to "Low", only available in Chrome/Edge...

@andrey-tar-xz please report back your result
You can check this page for the details of your GPU: chrome://gpu/

@andrey-tar-xz please report back your result
Not related, but you can check this page for the details of your GPU: chrome://gpu/

Apologies for the delay. Activating this option made streaming much better, but when the sharpness option is set to 1 or more, frames are lost. (Translated from Portuguese to English)

@andrey-tar-xz please report back your result
Not related, but you can check this page for the details of your GPU: chrome://gpu/

Apologies for the delay. Activating this option made streaming much better, but when the sharpness option is set to 1 or more, frames are lost. (Translated from Portuguese to English)

yea, don't use the Clarity feature if your device is slow.


[OmniSci] Slow import in H2O Join benchmark

Data import for join benchmarks takes ~10sec while CSV parsing takes only 0.6 sec. Most probably time is spent in a dictionaries build. We should check if there is an opportunity for improvement.

Dictionary encoding is slow for columns with high cardinality and it doesn't seem reasonable to dictionary encode such columns.  However, currently in omnisci-on-ray backend, we encode all columns, as we don't have an option not to encode them.
With arrow 2.0 we would have such option and also we would use arrow's dictionary encoding, so let's wait until we have arrow 2.0 and measure performance with it.

In H2O benchmarks we join by string columns and therefore dictionary encoding is what we need. Do we build all required dictionaries in parallel?

Yes, we do. But OmniSci's bulk insert in the dictionary is almost serial. Maybe we could gain some performance using arrow's dictionary encoding. Let's wait arrow 2.0 and test it.

@AndreyPavlenko is this still relevant? Maybe you know.


Build failure :(

C:\Users\Lebo\Documents\GitHub\Hystrix\hystrix-examples-webapp [master]> ../gradlew jettyRun
[Fatal Error] httpcore-4.2.4.pom:2:1: Content is not allowed in prolog.
[Fatal Error] httpcore-4.2.4.pom:2:1: Content is not allowed in prolog.
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring root project 'hystrix'.

Could not resolve all dependencies for configuration ':classpath'.
Could not resolve org.apache.httpcomponents:httpcore:4.2.4.
Required by:
:hystrix:unspecified > com.netflix.nebula:gradle-netflixoss-project-plugin:2.2.5 > com.netflix.nebula:gradle-in
fo-plugin:2.0.0 > org.eclipse.jgit:org.eclipse.jgit:<IP_ADDRESS>404171909-r > org.apache.httpcomponents:httpclient:4.2.5
Could not parse POM https://jcenter.bintray.com/org/apache/httpcomponents/httpcore/4.2.4/httpcore-4.2.4.pom
Content is not allowed in prolog.
Could not parse POM http://plugins.gradle.org/m2/org/apache/httpcomponents/httpcore/4.2.4/httpcore-4.2.4.pom
Content is not allowed in prolog.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED
Total time: 25.491 secs

Thanks for the report, @TJMshaisa.  Sorry for the delay responding - was out of the country on vacation and just got back.
I haven't seen this failure before, and building the head of master (with Java 7 on a Macbook Pro) works as expected for me.  Are you still able to consistently replicate this failure?

Pleas open a new issue if you can reproduce this, @TJMshaisa

Hello!
New message, please read http://nikwatch.com/cast.php?kp64
<EMAIL_ADDRESS>

Hello!
New message, please read http://majorinvesting.com/being.php?bp
<EMAIL_ADDRESS>

Hello!
New message, please read http://saolucasnatal.com.br/fond.php?jr6pm
<EMAIL_ADDRESS>

Hello!
New message, please read http://antistatikzeminkaplama.com/I.php?hw
<EMAIL_ADDRESS>

Hello!
New message, please read http://mhpearls.com/voice.php?v5
<EMAIL_ADDRESS>

Hello!
New message, please read http://mannyaniceto.com/determined.php?x9x
<EMAIL_ADDRESS>


Ctrl key disabled in text area?

Hi, it appears that the Ctrl key is explicitly disabled in the translation textarea of the web app which has the negatove side effect that pasting with Ctrl-v doesn't work, nor attempting to tyle any of the symbols from the numer row, e.g. "{" which is quite handy for parameter placeholders etc.
Is this really by design, or is there a particular use-case being served by disabling it?

Looks like at big nasty bug we didn't get because we all have Macs and use Command+V for copy pasting :)
the idea behind this code that to prevent the enter key to save the translation and instead introduce a new line in the string. To save the translation you'd to type ctrl+enter.
This actually annoyed me last time I used it. Not sure in the case of software string it is so often we have return lines.
So as it is buggy... maybe we should just remove that feature.
@jeeyi @hkanabiajeuskaja thoughts?


LambdaNotUsedImportFixer - add heredoc test

It's a shame the CI is configured with that fast fail, so we can't see the test output from PHP 5.6...


Create ActiveGate CR within DynaKube reconciler

Description
As soon as the dynakube is reconciled, an activegate CR should be created out of it if necessary.
How can this be tested?

Create a dynakube with activegate section

Checklist

[x] Unit tests have been updated/added
[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

Codecov Report
Attention: Patch coverage is 33.33333% with 90 lines in your changes are missing coverage. Please review.

Project coverage is 66.58%. Comparing base (a2c61fa) to head (0674c70).

Files
Patch %
Lines

pkg/api/v1alpha1/activegate/activegate_types.go
0.00%
53 Missing :warning:

pkg/api/v1alpha1/activegate/feature_flags.go
0.00%
12 Missing :warning:

...ontrollers/dynakube/subcr/activegate/reconciler.go
76.92%
7 Missing and 5 partials :warning:

pkg/api/v1alpha1/activegate/properties.go
0.00%
7 Missing :warning:

...g/api/v1alpha1/activegate/zz_generated.deepcopy.go
0.00%
2 Missing :warning:

pkg/api/v1beta1/dynakube/properties.go
0.00%
2 Missing :warning:

pkg/controllers/dynakube/controller.go
71.42%
1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2865      +/-   ##
==========================================
- Coverage   66.86%   66.58%   -0.29%
==========================================
  Files         253      254       +1
  Lines       13785    13911     +126
==========================================
+ Hits         9217     9262      +45
- Misses       3759     3834      +75
- Partials      809      815       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Line on a map projection not plotted correctly

Description
When plotting a line on a projection, 360 degrees gets added to the longitude of each point, except the first, resulting in the line wrapping around the globe between the first and second points.
Steps to reproduce
import proplot as pplt
lons = [307., 292., 280., 269., 259., 249., 239., 228.]
lats = [ 51.,  32.,  11.,  -8., -24., -36., -46., -54.]
fig, ax = pplt.subplots(proj='cyl',basemap=False, width=20, height=12, proj_kw={'lon_0': 180})
ax.plot(lons, lats)
Expected behavior: line without 360 degree warp
Actual behavior: first point wrapped 360 degrees.
Equivalent steps in matplotlib
Please make sure this bug is related to a specific proplot feature. If you're not sure, try to replicate it with the native matplotlib API. Matplotlib bugs belong on the matplotlib github page.
# your code here, if applicable

Proplot version
3.3.3.   0.8.1

This was due to unnecessary normalization of 1D geographic data attempting to make it "monotonic" for user convenience. But the algorithm was full of holes -- among other things it failed for descending data like in your example. Have simply revmoed that bit of code (c8a8faa).


save_alt not displaying

I was trying to use save_alt. It doesn't appear for me.
<i aria-hidden="true" aria-label="Save" class="material-icons">save_alt</i>

Sorry for the delay. Added new fonts and released a new version. Please update package and try again.


Should I put all my 50 Routes pages in App.js

Where should you put all 50 Routes

Put it where it best fits in your use case. It's that simple!


bug:Returns the expected amount of  data

name: Pull request
about: bug:returns the expected amount of  data
title: ''
labels: ''
assignees: ''
1. Are you opening this pull request for bug-fixes, optimizations or new feature?
Yes.
2. Please describe how these code changes achieve your intention.
If the inboundBuffer length is greater than we want，just intercept.
3. Please link to the relevant issues (if any).
4. Which documentation changes (if any) need to be made/updated because of this PR?
4. Checklist

[x] I have squashed all insignificant commits.

[x] I have commented my code for explaining package types, values, functions, and non-obvious lines.

[ ] I have written unit tests and verified that all tests passes (if needed).

[ ] I have documented feature info on the README (only when this PR is adding a new feature).

[x] (optional) I am willing to help maintain this change if there are issues with it later.

Sorry for the delay, really busy these days.
I've taken a glance at this PR and I believe there is no bug in the current code, in fact, your code changes here don't make any real impact.

when I look at the code, depending on the context, I feel something is wrong.
but I wrote some demos and no errors occurred, I was wrong.
sorry~~


Format: "x11" not recognized. (plot / Windows)

julia> using Graphs

julia> g = simple_graph(4, is_directed=false)
Undirected Graph (4 vertices, 0 edges)

julia> add_edge!(g, 1, 2)
edge [1]: 1 -- 2

julia> add_edge!(g, 1, 4)
edge [2]: 1 -- 4

julia> add_edge!(g, 2, 4)
edge [3]: 2 -- 4

julia> add_edge!(g, 3, 1)
edge [4]: 3 -- 1

julia> add_edge!(g, 3, 2)
edge [5]: 3 -- 2

julia> add_edge!(g, 4, 3)
edge [6]: 4 -- 3

julia> plot(g)

julia> Format: "x11" not recognized. Use one of: bmp canon cmap cmapx cmapx_np dot emf emfplus eps fig gd gd2 gif gv imap imap_np ismap jpe jpeg jpg metafile pdf pic plain plain-ext png pov ps ps2 svg svgz tif tiff tk vml vmlz vrml wbmp xdot xdot1.2 xdot1.4

Same issue on OS X Yosemite 10.10.2

same for me on yosemite 10.10.3

Same on Windows 8.
Switching what follows the -T command on line 85 of dots.jl:
stdin, proc = open(`neato -Tx11`, "w")

From x11 to a GraphViz Output Format should clean that error up, so long as your system supports the format you choose.
I can't get a plot yet, but that's because I am getting this error now plot --> Linux #176.

As a partial solution, I recommend (shamelessly) using my IJuliaPortrayals package, at least for interactive Jupyter-based work. For example,
using Graphs
using IJuliaPortrayals

g = simple_complete_graph(10)
GraphViz(to_dot(g), "circo", "svg")

@jbn: Good work! Nice library!


Add CI for Linux & macOS

Hello,
I hope this is useful. It automatically creates packages for macOS & Linux (DMG for macOS, AppImage for Linux) on every commit to master using Github Actions (the tab here on top). A nice badge can be added on the readme for people to be able to download the builds or something similar, but I'll leave the niceties for somebody else if you accept this PR :).
Also, a Windows build is missing. Should be a matter of mostly copying what the macOS build is doing. And the commits are separate (more or less) in case you want to add only Linux or only macOS support for any reason :).
Finally, this is not perfect and can be improved a lot, but I've already spent too much time on it already :).

Sorry, I forgot I had this open. I've been fixing this today, as GH changed stuff that made it break, so builds will now be red until I do. You can either revert or wait until I fix it, your choice 🙂

Ok :)


Setup window appears, and not recognize the emulator

Any log files or additional information?

This is the last log, i only open start.bat -> Setup and open Nox, but nothing happens, the emulator doesn't appear on Setup.
debug_2021-03-22--08-53-01.log

Try to remove this file: settings\gui\game.json and run start.bat again.
If it fails then send me new log from that setup.

debug_2021-03-22--09-02-39.log

I think one of the reason why this happens: not enough OS permissions to get emulator's process here:
https://github.com/tmarenko/mff_auto/blob/f21743da7fb02a41972a4b2bfbdfa41bef07eed0/lib/gui/widgets/setup_player.py#L95
Did you try to run start.bat as Administrator?
If it doesn't help you can try to create game.json manually.
Structure of game.json file for NoxPlayer:
{ 	"timeline_team": 1, 	"mission_team": 1, 	"acquire_heroic_quest_rewards": true, 	"player_name": "NoxPlayer", 	"player_type": "NoxWindow", 	"game_app_rect": null }
Replace NoxPlayer with your Nox's name from here:

then put this game.json file into settings\gui folder and try to run the bot.
The downside of this method is that you will have empty game_app_rect (because bot calculates it dynamicly in setup) so no restart game/farm bios options for you.

When i try to run as administrator, start.bat closes in miliseconds.

Did you start the emulator before starting the bot?

Nope
On Mon, 22 Mar 2021, 12:11 Timofey Marenko, @.***>
wrote:

Did you start the emulator before starting the bot?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tmarenko/mff_auto/issues/20#issuecomment-804014849,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATK47MAF3ZPXZHFKQNCO5U3TE4XW5ANCNFSM4ZSBSZ6Q
.

Nope

You should start NoxPlayer and the start the bot. Bot can't get any information from Nox Player for set up because NoxPlayer needs to be running for this.

You will see your running NoxPlayer then:

Nothing happens, i downloaded it again and started after having the nox open, I even tried with the bluestacks.

Nothing happens, i downloaded it again and started after having the nox open, I even tried with the bluestacks.

You can simply delete settings\gui\game.json to start Setup again, don't need to redownload it.
Well, maybe the other reason why this happens is something went wrong with getting key handle from Nox.
You can test by editing this file lib\players\android_emulator.py at 157 line here:
https://github.com/tmarenko/mff_auto/blob/f21743da7fb02a41972a4b2bfbdfa41bef07eed0/lib/players/android_emulator.py#L154
Replace this line with keys_found = True (make sure to keep spaces at the start of the line same) and run Setup again.
Also, what's your OS, OS language and NoxPlayer version?

Putting keys_found = True worked, thanks

Putting keys_found = True worked, thanks

Well it's not a real fix because now bot doesn't know how to send keystrokes into emulator now (i.e. you can't use "restart game" function).
If you still need ability to restart game, please tell about OS and NoxPlayer version. I'll try to test them myself sometimes later.

Windows 10 and Nox Version <IP_ADDRESS>

I couldn't reproduce this issue with brand new Windows 10 Home Edition and NoxPlayer.
With clean setup NoxPlayer always has Qt5QWindowToolSaveBits handler for keys.
If you will found anything new or related to this issue then reopen it.


fix the hostname when no dhcp or dns configured

We changed a while ago for some reason I don't remember 😓 . I guess it would be better to check if the hostname has been set first, otherwise use the /etc/hostname file.

Closed because it's included on -> https://github.com/suse-edge/misc/pull/97


Failover when an originator becomes unresponsive, and return to originator once responsive

This might already be done. To be investigated.

We will re-establish a connection in the syncworker if an originator crashes. I have seen this work plenty of times. I don't think that we have any explicit testing for it.
Is there anything else that needs to happen here @richardhuaaa?

I think there's two more cases we need to handle:

If the originator is in the registry, but for some reason we are unable to connect to it even on retry, we should pull that originator's payloads from other nodes on the network (perhaps multiple).

if the originator was recently removed from the registry (e.g. within 1 day), or they have been removed long ago but we are a brand new node that has no history, we should pull that originator's payloads from other nodes on the network (perhaps multiple)

The XIP could def do a better job of going through these

Gotcha. Thanks for the details


Youtube direct downloadable link

Is there a way to get a downloadable link, instead of getting it to play on browsers for youtube ? right now when we open link on browser, it will play. I would like to get a link, which downloads directly.

As documented in the Fine Manual:
--get-url (or -g)

With YouTube, the URL(s) returned expire quite quickly, so your workflow must act on them soon and not (eg) stash them in a queue to be downloaded tomorrow.
For a single link that plays both audio and video, use --format best (or similar), but not all sites offer such links.
If you want both audio and video and the site doesn't offer a combined format with audio and video, or the quality of the best combined format isn't good enough for you, yt-dl can list (eg, with the default format option) the separate audio and video links: you'll have to download them and then merge them into a single AV container with a separate tool (eg ffmpeg).
If downloading a YT link, the download can be throttled unless you specify an acceptable HTTP chunk size (10MB) for the downloader.
The formats offered by a site may change over time (though for YT, point 1 generally overrides this): running yt-dl again ensures that the media link(s) are the best available matching your format specification.

Also read "FORMAT SELECTION" in the Manual.


Make images display at the left by default

Right now, we are causing all images to be centered on the page by default:
https://github.com/executablebooks/sphinx-book-theme/blob/master/src/scss/_page.scss#L80
This is actually a departure from what most sphinx themes do by default, and also results in some wacky-looking behavior like this:

What do folks think about changing our default image behavior to be the same as what other Sphinx themes do, and then using a center class for when users want to explicitly center an image.
@pradyunsg what does Furo do w/ images?

Yeh was gonna bring this up. Left would be better I think (didn't @najuzilu have an issue/PR about this?)
With these badges actually it would be ideal if they actually mirrored the Markdown and were inline. But not sure what this would require in markdown-it-py/myst-parser (without messing up normal images)

https://pradyunsg.me/furo/reference/images/
No custom layout CSS for the default. There's a bit of CSS for alignment, but nothing specific for img's with align-default.

OK cool - I am +1 on:

No opinionated styling added for images (beyond maybe whitespace above/below)
Figure directives result in centered images by default

Awesome! ^>^


weekly image cve patching from Sec Pipelines

weekly image cve patching from Sec Pipelines

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall First build on chuhua/20230727-cve-patch at 60.655%

Totals

Change from base Build<PHONE_NUMBER>:
60.7%

Covered Lines:
2576

Relevant Lines:
4247

💛  - Coveralls


Can not create hyper::Error

You are advising to make TcpStream::connect(addr).await That returns io::Error
But I can not convert io::Error to hyper::Error - everything is private
Next you recommend to do is handshake. handshake already returns hyper::Error.
This 2 steps will always go together. And no ability to convert one error into each other is not good.
thank you, if you could help

I think the rational is that hyper should be in full control in where a hyper::Error comes from and how it was created. Next to that in a sufficient complex scenario you'll anyway also end up with other possible error types that have nothing to do with std or hyper and that you within the same code path have to return.
I think the answer is the same either way, box it or wrap it in a type such as an enum.
That is at least how I see it. I am however not a contributor or maintainer. So not sure how much that is worth.

The error from TcpStream::connect() is not a hyper error. You could define your own Error type, maybe an enum, or you could use a Box<dyn std::error::Error>, or one of the crates like anyhow.


Maybe forward to origin now v3 is out

This comes up first in google searches. Now that v3 is out with full Deno support, would it makes sense to forward back to porsager/postgres?

Obviously, that's what I planned do that do soon anyway :+1: However, there are now 2 packages about the postgres library on deno.land (postgresql and postgresjs), I don't know if that would be possible to merge both or at least redirect urls from mine to yours? I know deno.land wants immutability, but in that case, mine is just a clone now
Anyway, if that's not possible, I can still recycle this repository for a new postgres library, or even better: publish a final version with a single file containing a single line : export * from 'https://deno.land/x/postgresjs' :laughing:

Oh cool. Yeah i got this github repo on top on google searching for postgres and Deno. Hadn't even thought about the Deno package, i was just sad to see postgres was already taken 😊

publish a final version with a single file containing a single line : export * from 'https://deno.land/x/postgresjs' 😆

Lol, that would break with the idea about immutability pretty quickly 😝
We could ask the Deno team on discord how they think best to handle it.


Refactor virtual_engine_factory

Factor out create_noiseless_virtual_processor_from_proto for use in create_noiseless_virtual_engine_from_proto
Factor out _create_device_spec_from_template for use in create_noiseless_virtual_processor_from_template and create_noiseless_virtual_engine_from_templates
Factor out MOST_RECENT_TEMPLATES for use in create_noiseless_virtual_engine_from_latest_templates and (manually) in create_noiseless_virtual_processor_from_template

This unblocks creating one processor at a time for use in #4842

@dstrain115 PTAL at changes and new PR description

@dstrain115 friendly ping


Replace 'infinite' with 'arbitrary'

Signed-off-by: Mihai Budiu<EMAIL_ADDRESS>Fixes #1084

2022-Aug-08 LDWG meeting comment: We should ensure that there is at least one occurrence of "infinite precision integer" type, and that it is the former name of what is now called "arbitrary precision integer", for anyone coming to the spec and searching for the older name.  I @jafingerhut recommend merging this PR, and I will create another PR on top of this one to add a new line in the change log with such a sentence.


[$500] Android - Compose  box -App crashes on sending message in offline while page is loading

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.94-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Launch app
Tap profile icon--preferences
Toggle on forced offline
Navigate back to LHN
Tap on a admin page with no activity and loading (or any page which is loading)
Send a message

Expected Result:
App must not crash on sending message in offline while page is loading.
Actual Result:
App crashes on sending message in offline while page is loading.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/115492554/87d028aa-2b31-4372-a3f5-23b9cf20a60e
crash.txt

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01459aaf4e457cbbe8
Upwork Job ID:<PHONE_NUMBER>728323072
Last Price Increase: 2023-11-01

@burczu what do you think of the above proposals?

@sonialiap I'm sorry - I was OOO last week. I'll be reviewing proposals soon.

I've just tried to reproduce the issue but with no luck - how to do you get the loading state of the app while being offline? I'm opening the admin page but it loads normally even when forced offline...

@tienifr Thanks for help!
I've checked one more time and seems it's not reproducible on the current main:
https://github.com/Expensify/App/assets/7771498/61c49c6c-662f-48fc-8160-f1b84f8b7605
Can someone else confirm it?

App crashes on sending message in offline while page is loading.

I just tested and my android app does not crash when I send a message to a loading #admins room while "force offline" is toggled.
Since multiple people cannot reproduce. Closing


Exclude Unity's *_DoNotShip directory when uploading to Steam

Changes
As discussed in #21
Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Readme (updated)
[x] Tests (not needed)

I'd appreciate a sanity check that this actually works for someone else before merging 😛

Cool so what happens next? 😛 I can't merge it myself

At the very least, this doesn't break anything for me, so I went ahead and merged.
For my project, however, there is no {currentDepotPath}_BurstDebugInformation_DoNotShip folder. The Unity folder that I remove is {currentDepotPath}_BackUpThisFolder_ButDontShipItWithYourGame. We might want to add that as well.


fix: assign 100% width to fill widgets on mobile viewport

Description
Issue: Fill widgets are not assigned 64 columns on mobile viewport if placed in the same flex layer.
Fix: Add a check for mobile viewport to override the minWidth logic.
Fixes # (issue)
Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual
Jest

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

/ok-to-test


Follow semver when determining dependencies’ versions

I noticed that a package still appears as 2.0.0 even though 2.0.1 was published.
Example<EMAIL_ADDRESS>webext-dynamic-content-scripts depends on "webext-additional-permissions": "^2.0.0", which npm install resolves to<EMAIL_ADDRESS>today, but npmgraph still shows 2.0.0

Semver details: https://flaviocopes.com/npm-semantic-versioning/
I published the 2.0.1 version 10 minutes ago so I'm not sure if this is due to cache.

Closing as this was probably due to cache. The same link looks like this now. Notice 2.0.1 and only 1 dependency of webext-additional-permissions


Example h.265 convert-to-jpeg

is it possible to add example to read h.265 steram and save frame to disk with jpeg format.
Thanks in advance

examples have been improved with #398


subject_alternative_names doesn't change, terraform still wants to recreate

Related issue: https://github.com/terraform-providers/terraform-provider-aws/issues/8531
Please introduce the workaround described there:
lifecycle {
  ignore_changes = ["subject_alternative_names"]
}

Until the issue above is fixed, this module cannot be used with multiple SAN-s without the ignore_changes hook being in place.

Hi @reegnz !
Please take a look at complete-dns-validation example, where multiple SANs are used.

@antonbabenko I use 4 SAN-s and the more you use the higher the probability that the AWS API returns the San list in a different order. With only two the probability of them swapping places is just 50%.
Try running that example about 10 times and I'm sure you'll encounter this issue (that's the thing with randomness, it doesn't always change the order).

This is exactly the reason why there is some magic in the module:
https://github.com/terraform-aws-modules/terraform-aws-acm/blob/1d8e823cd08c9dcd2ffd2bd22a509c7633db253e/main.tf#L2-L6
If you can show the values you are trying to get I can maybe suggest the solution (you can replace domain name with something, but keep subdomains).

That magic doesn't fix the case when you have multiple subdomains in the SAN-s. That just filters out the wildcards.

Ok, so my current module parameters look something like this (domain changed for obvious purposes - you won't be able to verify with my domain):
locals {
  domain_name = "example.com"
}
module "cert" {
  source  = "terraform-aws-modules/acm/aws"
  version = "v2.3.0"
  domain_name = local.domain_name
  subject_alternative_names = [
    "*.${local.domain_name}",
    "api.${local.domain_name}",
    "*.api.${local.domain_name}",
    "infra.${local.domain_name}",
    "*.infra.${local.domain_name}",
  ]
}

Now in this case these are 5 SAN-s in the certificate. The order of those 5 will randomly change and that screws up the aws_acm_certificate change detection. Hence why this module is affected, since it makes use of the aws_acm_certificate resource.
Everything about this is also elaborated in detail in terraform-providers/terraform-provider-aws#8531, even how to work around that issue.

Yes, I am well aware of this issue in Terraform AWS provider and yet we can't add subject_alternative_names to ignored_changes because it will break this module for many users.
Also,
subject_alternative_names = [
    "*.${local.domain_name}",
    "api.${local.domain_name}",
    "*.api.${local.domain_name}",
    "infra.${local.domain_name}",
    "*.infra.${local.domain_name}",
  ]

is the same as:
subject_alternative_names = [
    "*.${local.domain_name}",
    "*.api.${local.domain_name}",
    "*.infra.${local.domain_name}",
  ]

It's broken either way for me, with ignore_changes I cannot modify the SAN when I need to, without it terraform recognizes the cert as changed even if it isn't and will recreate the cert.
I choose option 1 as the safer alternative and I guess that means I cannot use this module then.
That's a shame. ¯_(ツ)_/¯

It's broken either way for me, with ignore_changes I cannot modify the SAN when I need to, without it terraform recognizes the cert as changed even if it isn't and will recreate the cert.
I choose option 1 as the safer alternative and I guess that means I cannot use this module then.
That's a shame. ¯_(ツ)_/¯
by the way, I wonder who relies on that broken functionality if you say it will 'break' when it's already broken in a different way.

I seem having issue with us-east-1 but not us-west-2.
About using lifecycle workaround, now about introducing  with an option "true" or "false"?

I'm having this issue in us-east-1

I'm having the same issue.
I'm using
  subject_alternative_names = [
    "*.${local.traefik_url}",
    "${local.traefik_url_no_prefix}",
    "*.${local.traefik_url_no_prefix}"
  ]

and the certificates are recreated on every apply which makes it hard to see if there is any "real" change in the infra. If this is expected behavior, as indicated above, I'll rewrite my code to not use the module.

As @xueshanf is saying, the problem is not on the module side but rather on the AWS API side, because it returns a different response for different regions&AWS accounts and there is no extra workaround in place on Terraform AWS provider side to make it consistent.
Honestly, I don't know what we can do in this module to get 100% working solution for 100% cases. There were several open issues in Terraform AWS provider which, I believe, should help us very much. Maybe someone can take a look into those if you have time.
@kevingimbel If you can take this module as basic and adjust it for your own needs it is great.

@antonbabenko I agree there isn't much you can do, and the only thing you could do is have one resource with the lifecycle and one without, but that'd be duplicated code to maintain so -- not a good solution.
My case is very limited and for me it is no problem to set the lifecycle so I'll just do that.

Ok, if you (or anyone else) can make a PR and update documentation saying the reason for this, I will be glad to merge this as a workaround.

I don't think my solution is good.
I'd create a second resource like so (haven't tested this)

resource "aws_acm_certificate" "this" {
  count = var.create_certificate && !var.validation_ignore_subject_alternative_names_changes  ? 1 : 0

  domain_name               = var.domain_name
  subject_alternative_names = var.subject_alternative_names
  validation_method         = var.validation_method

  tags = var.tags

  lifecycle {
    create_before_destroy = true
  }
}

resource "aws_acm_certificate" "this_ignore_changes" {
  count = var.create_certificate && var.validation_ignore_subject_alternative_names_changes ? 1 : 0

  domain_name               = var.domain_name
  subject_alternative_names = var.subject_alternative_names
  validation_method         = var.validation_method

  tags = var.tags

  lifecycle {
    create_before_destroy = true
    ignore_changes = [subject_alternative_names]
  }
}

and then assign the cert to a local variable.
locals {
    this_cert = var.validation_ignore_subject_alternative_names_changes ? aws_acm_certificate.this_ignore_changes[0] : aws_acm_certificate.this[0]
}

all other resources could then use the local.this_cert variable.
But as I said, I don't think this is a good solution. I don't think introducing a second, copy-pasted resource is justified for a workaround of an upstream API "issue".
For me, I'm totally fine with rolling my own cert management, I basically copied some of the code here and my certificate domains never change because they are part of a module.
@antonbabenko If you're ok with these changes I could wrap them up in a PR.

Same here, all the time it wants to re-create certificates, because of subject_alternative_names change order every time.

I'm having the same issue, even if I sort the list:
  subject_alternative_names = sort([
    "*.test.development.example.com",
    "*.development.example.com",
    "test.development.example.com",
  ])

@kevingimbel , I believe that there is no universal hack which we can easily apply in the module unless the root issue (https://github.com/terraform-providers/terraform-provider-aws/issues/8531) exists. As of now, it is the most upvoted issue in that repository with 288 upvotes.
I don't know what else we as community (not HashiCorp employees) can do to get this issue fixed in the provider. :(

@antonbabenko I don't think we can do anything really.
For my case I simply refactored our internal terraform code and copied some of this modules' code in (like the locals from https://github.com/terraform-aws-modules/terraform-aws-acm/blob/master/main.tf#L1-L7).
Then I just added the lifecycle on the resource aws_acm_certificate.
resource "aws_acm_certificate" "my_cert" {
[...]
  lifecycle {
    ignore_changes = [subject_alternative_names]
  }
}

But this works for us, it may not work for anyone and introducing a resource with ignored lifecycle and one without (as I suggested in my previous comment https://github.com/terraform-aws-modules/terraform-aws-acm/issues/20#issuecomment-607702444) is just a very weird workaround - I would not like to introduce that.
Unless terraform fixes the issue in the provider or they allow to set ignores in modules I think there's nothing we, as a community, can do.

Just to chime in here, since I opened the issue.
I still regard the ignore_changes solution closest to usable behaviour. Even though it ignores changes in SAN, you can still taint the resource manually for recreation.
If we don't ignore the SAN, there's basically no workaround like that, there will be no clean 'terraform plan' for you.

small change to fix this https://github.com/terraform-aws-modules/terraform-aws-acm/pull/53

Finally, this issue has been solved in AWS provider version 3 - https://github.com/terraform-providers/terraform-provider-aws/issues/8531
There is nothing we should be doing in this module. Phew!

I believe the problem is not related to the module but to your terragrunt configuration. The original bug was fixed 1+ years ago in the provider.


use VSCode 1.2 extension install

code 1.2 command line support installing extensions, which obsoletes my curl scripts.

When I run code --install-extension saviorisdead.RustyCode in the docker build, I am getting this error:
Error: watch /home/vscode/.config/Code/User ENOENT
    at exports._errnoException (util.js:890:11)
    at FSWatcher.start (fs.js:1323:19)
    at Object.fs.watch (fs.js:1351:11)
    at new e (/usr/share/code/resources/app/out/vs/code/node/cliProcessMain.js:6:1245)
    at m (/usr/share/code/resources/app/out/vs/code/node/cli.js:4:11378)
    at t._createInstance (/usr/share/code/resources/app/out/vs/code/node/cliProcessMain.js:6:7605)
    at t._createAndCacheServiceInstance (/usr/share/code/resources/app/out/vs/code/node/cliProcessMain.js:6:8580)
    at t._getOrCreateServiceInstance (/usr/share/code/resources/app/out/vs/code/node/cliProcessMain.js:6:7766)
    at /usr/share/code/resources/app/out/vs/code/node/cliProcessMain.js:6:7122
    at Array.map (native)

How do I debug “Error: spawn ENOENT” on node.js?
http://stackoverflow.com/a/35677181/23059

It looks to be an initialization issue of some sort. I can reproduce the error if I haven't launch the code gui and I try to install any extension, such as:
code --install-extension Ionide.Ionide-fsharp
code --install-extension ms-vscode.csharp

I just need to create that directory. You can't install an extension is ~/.config/Code/User/ does not exist. I'm able to reproduce the error by removing that directory. I'm able to avoid it by create it.


[FLINK-13388][web][docs] Updated screenshots to ones taken from the new UI

What is the purpose of the change
Starting from 1.9 we changed the default UI. Therefore we should also update the screenshots in the documentation
Verifying this change
This is update for documentation which does not need tests. Verified manually that the pictures render correctly.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@dawidwys ping

@zentol sorry I missed your first comment.
I updated the mentioned picture. If you are fine with it, I'll merge it soon.

@dawidwys That's a lot better, thanks!


Adding characters' affiliation (Galactic Empire, Rebel Alliance, etc) #71

Having trouble getting all dependencies set up on my machine, but wanted to gauge interest in this?
Adding a key-value pair for 'affiliation': 'Galactic Empire' to each character with a UID for each affiliation...

Just saw that this is already an issue! Closing now, okay to remove.


anamorphous, examiningly

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[a,e]

/trunk merge


SMS Issues

I tried to enable the SMS responses, however I haven't been able to get it set up.
I tried typing in the "config settings" (both manually and through a batch file) but command prompt wouldn't give me a response (no error or confirmation messages). So, I went into the source [config.go] and hard-coded my config codes (commenting out the automated setup lines).

I blurred out my info for security reasons
Now, I am getting nvidia stock results back on the debug console (yay), however, I don't see any SMS messages (even after running the test flag).
Any thoughts on why this isn't working?

So a few things can you download the latest release binary linked, and then provide the list of commands you're executing. Thanks!

Apologies for the delay, been trying to keep up with all the builds. Nice progress by the way! :)
Question on the config:

Is the "set" command supposed to be in a particular folder or just the base nvidia-clerk-0.9 folder?

Also, the nvidia-clerk-windows executable should be included in the Build Release, instead of a separate download.

It doesn't matter where it's actually stored, as long as you use the same cmd.exe to run the nvidia-clerk command.

Late update here but you don't need to specify the sku at all anymore just a region.
Also just double check your Twilio export commands

Okay, just to be 100% sure this is being completed correctly, I'm going to give a rundown of what steps I'm performing.

Download the latest release (currently nvidia-clerk-1.5) and the nvidia-clerk-windows executable.
Open cmd.exe in administrator mode (for the sake of consistency, I am using my home directory C:\Users\NAME).
I type in nvidia-clerk-windows.exe -region=USA
I get a successful run.
I then configure Twilio. Done.
I run an sms test [nvidia-clerk-windows.exe -region=USA -sms -test] and it works (whatever error I was having before was resolved in this or a previous build). Thanks for the assistance! 😄

Now, the issue I'm having is the SMS sends to my phone...but the message does not contain a link
Here's a screenshot:

Feature Request
It would be really appreciative if the application's EXE file was also included in the source code's zip file :)

Feature Request
It would be really appreciative if the application's EXE file was also included in the source code's zip file :)

Probably not going to go this route, it's not typical of any GitHub repositories to do this but feel free to checkout the latest builds section at any time for all the newest updates

Okay, just to be 100% sure this is being completed correctly, I'm going to give a rundown of what steps I'm performing.

Download the latest release (currently nvidia-clerk-1.5) and the nvidia-clerk-windows executable.
Open cmd.exe in administrator mode (for the sake of consistency, I am using my home directory C:\Users\NAME).
I type in nvidia-clerk-windows.exe -region=USA
I get a successful run.
I then configure Twilio. Done.
I run an sms test [nvidia-clerk-windows.exe -region=USA -sms -test] and it works (whatever error I was having before was resolved in this or a previous build). Thanks for the assistance! 😄

Now, the issue I'm having is the SMS sends to my phone...but the message does not contain a link
Here's a screenshot:

Probably not going to do a link, the bot will have already opened the checkout on your computer so you'll be able to login there. The checkout session requires browser based cookies so it's not simple to link you to the checkout on another device.

Going to close this out for now as your main issue is solved, glad to see you got everything up and running.


Functionality to unfix input variables, display degrees of freedom

Added functionality to unfix variables

this includes the option to set lower and upper bounds

Added dof attribute to display the degrees of freedom

this relies on https://github.com/watertap-org/watertap/pull/966


⚠ ClamAV has degraded performance

In b5a0e92, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 203 ms

Resolved: ClamAV performance has improved in 2717d88 after 11 minutes.


Add option to disable showing an item in totals

Shift+Click an item in totals and it gets permanently hidden from display. Would need a simple UI for managing hidden items.

UI presently displays the status of both hidden items and account filter.
Hidden items have their render displayed with no number and no selection ability. Tooltip is bound. Shift+Clicking an item will remove it from the hidden items filter.

Published in v9.3.0.


make-pack.py: name section

For possible update for icon packs.
Merged when and if feature comes (source).

v2.2.2 introduced support for the name field. No need to make any changes on your end right now, everything should continue to work as before! Just an FYI in case you want to make use of this field.

v2.2.2 introduced support for the name field. No need to make any changes on your end right now, everything should continue to work as before! Just an FYI in case you want to make use of this field.

Thanks, I noticed the release. But I probably won't add it on here (at least for now), because of extra work of JSON editing.


Horisonatl scroll bar is missing - it's impossible to read the full content of the page

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e480de06-b14a-5c82-73dc-65dbc3ecd03f
Version Independent ID: c0e88ab1-ef73-3f0b-3a35-ee5d201b1486
Content: BlockBlobClient Class (Azure.Storage.Blobs.Specialized) - Azure for .NET Developers
Content Source: xml/Azure.Storage.Blobs.Specialized/BlockBlobClient.xml
Service: azure
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Hi @vrozovmicrosoft.   Thank you for your feedback.  This appears to be related to the structure of the MS Docs page structure;  we've transferred this to the Azure Docs repository as #83503 to bring it to the attention of the team best able to address it.


Minor improvements in README.md

Thank you!

Coverage remained the same at 95.128% when pulling<PHONE_NUMBER>20fe23def4ca75ddf1a17d16431770 on lex111:patch-1 into 9416d0dc1a16641029846dc84def1fa3665e4200 on spiral:develop.


Do not register default HttpClient to prevent auto wire issues

Q
A

Bug?
no

New Feature?
yes

Version
1.14.0

Actual Behavior
We are heavily using Symfony's auto wire functionality. Sometimes, developer inject HttpClient in the constructor without actually specifying the exact httplug.client.name. No error is thrown, and HTTPlug just picks the httplug.client.default service (or the first client it can find)
Expected Behavior
Don't register a default Http\Client\HttpClient service and Symfony will automatically warn the developer that multiple services of Http\Client\HttpClient exist. Developer is then notified about this and will think :)
Possible Solutions
I really propose to get rid of this behaviour in the next major version of this bundle.
Related code
https://github.com/php-http/HttplugBundle/blob/8b7cb00d58a4699bad47c0bed4c5b0455b9f5704/DependencyInjection/HttplugExtension.php#L115-L123
https://github.com/php-http/HttplugBundle/blob/a6466b46a68b330ce55107cbc6111213f95b5f8c/Resources/config/services.xml#L44-L46

hm, i think that really depends on the scenario, or use case of your application. if it is small and needs only one client, autowiring might be desired. if it is large, it is not desired.
the best solution probably is a configuration option that by default and in the recipe is off, but that you can enable to support autowiring. do you want to do a pull request for that? we can add it in the current system but with the default being enabled, and change the default in the next major version - as you say, that is a BC break.

@dbu Good idea. I will create something for this.


Adding addons.js and webpack.config.js removes action logger

Starting with a clean install, if you add an addons.js file and a webpack.config.js file in the .storybook folder, then the actions logger is removed and 'No Panels Available' is displayed instead.
The contents of the addons.js file is empty. The contents of the webpack.config.js file is from the documentation:
const path = require('path');

module.exports = {
  module: {
    loaders: [
      {
        test: /.scss$/,
        loaders: ["style", "css", "sass"],
        include: path.resolve(__dirname, '../')
      }
    ]
  }
}

It seems you can have an addons.js file OR a webpack.config.js file but not both.
This might be intended behaviour, but how do you get the actions logger back?
I've tried installing the 'Actions' addon, and adding the following to addons.js, but the action logger is still not displayed:
import '@kadira/storybook/addons'
import '@kadira/storybook-addon-actions/register'

Actually, you only need to put this line only:
import '@kadira/storybook/addons'

And you need to reload the browser window to see those changes.

Sorry, this still isn't working for me (testing on Windows), steps to reproduce:

New folder, npm init, npm i react react-dom --save
getstorybook
Create addons.js with import '@kadira/storybook/addons' content in .storybook folder
Create webpack.config.js file in .storybook folder with following content:

const path = require('path');

module.exports = {
  module: {
    loaders: [
      {
        test: /.scss$/,
        loaders: ["style", "css", "sass"],
        include: path.resolve(__dirname, '../')
      }
    ]
  }
}

npm run storybook

Expected: Actions logger is displayed
Actual: No Panels Available is displayed

Let me try this exact steps to reproduce it.

@devdigital I checked again. It's working pretty fine with the steps you mentioned.
I assume, that's something only happening in windows.
Unfortunately, I don't have a windows box to test this right now.
I am seeking help from someone who could try to follow these steps and verify it's happening or not.

as I remember, getStorybook works not properly on Windows
I can test it tomorrow
@devdigital if you just starting a new project you can do it many other ways
https://getstorybook.io/docs/react-storybook/basics/slow-start-guide

I think the issue is unrelated to getstorybook, that was just used to reproduce the problem. Would be useful to know if those steps cause the same problem for you on Windows, including not using getstorybook.

Ok, just tried npm run storybook from a command prompt rather than Git bash, and the action logger appears. So it looks like it's related to a webpack casing issue on Windows. Warnings are displayed in Git bash when you run npm run storybook, but the issue is actually causing the action logger to break. See https://github.com/webpack/webpack/issues/2694 and https://github.com/storybooks/react-native-storybook/issues/113.

Ok. I reproduced your steps with same result.
but did you note the issue during getstorybook?

so doing npm i after getstorybook solves this problem

@UsulPro could you send me the npm debug log where installing deps gets failed.
I'll have a look at it.

Here is a repo after getstorybook https://github.com/UsulPro/myjunkstaff/blob/master/clean2.zip
but there are no npm-debug.log in it.
everything in node_modules - it is React and React-dom only

@arunoda maybe this could help?
var spawnSync = require('spawn-sync');

result = spawnSync('npm', ['install'], { stdio: 'inherit' });

console.log(result);

Here is a log with error I got:
spawnSync.txt

Yes I ran npm install after, so it looks like this is 2 issues

I think has been resolved / answered ?

Just in case it helps. I had this issue, I had had an old version of storybook alongside a new version of the plugins, reinstalling solved the issue :)


Remove generated site from master branch

We have moved the site over to the gh-pages branch, so we can delete the generated content on the master branch.

@etefera fyi


Shortcut keys to send current window to a FancyZone

Hot Keys to Send Window to a Fancy Zone
Rather than only being able to do shift-click and drag to the fancy zone, it would be awesome if you could press a shortcut (for instance, ctrl-shift-F) to enable fancy zone mode, and then type a user-defined key  (e.g. "q") to send the window to the upper left fancy zone.
This would be much faster than using the mouse.
I ❤ this app, thanks so much!

If you'd like to see this feature implemented, add a 👍 reaction to this post.

Already tracked in #6611 by #492


Add support for strict Content-Security-Policy to flask-admin

Flask-admin can't be used with "strict" content security policy (https://csp.withgoogle.com/docs/strict-csp.html), i.e., with content-security-policy headers that allow scripts based on a nonce rather than on a whitelist of origins. Given that nonce-based CSPs are the recommended way to use CSP, it would be nice if flask-admin supported them.
To be compatible, it needs:

a way to specify a nonce to be added to


error: missing_scope

conversations.list
[ERROR]	2022-12-09T13:02:29.519Z	3148ff81-f3ec-4e5b-a265-f4feb94e34b6	error: missing_scope

Make sure your bot has at least the following scopes:
Your Slack App requires the following Bot Token Scopes:
channels:history
channels:manage
chat:write
chat:write.customize
chat:write.public
groups:history
links:write


pull request for e2e test at 12/31/2016 20:15:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


When will MRDL be merged with MRTK

Now that we are getting very close to the Windows Creators Edition  release and the Release of the MR Headsets, It would be nice to have the tools we use integrated and stableized for Unity 2017.2 that was just released. Would anyone be able to provide a timeframe for this integration?
Thanks, HR

It's a little hard to say for certain, given the whirlwind leading up to the aforementioned product launch, but we hope to have a first-pass, usable version of the integrated MRTK within two weeks. @paseb may have a more accurate view of the timeline.

Hi @hridpath,
We'll be integrating some of the tools from MRDL into MRTK once the build and apis stabilize.  That will coincide with the public release of 2017.2 when it's out of beta.  I will have an updated fork this week for those that would like to preview or take a look at it integration and what functionally we're going to initially pull over.
thanks,
-pat

@hridpath This is the pull request for the initial migration of MRDL's fundamental elements
https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1007

First set of UI controls and building blocks are merged.
https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1197
This PR brings baseline functionality and UI controls from MRDL
Buttons(Interactable Object)
Interaction Receivers
Object Collection
Two test scenes were included under Assets/HoloToolkit-Examples/UX/Scenes. InteractableObjectExample.unity and ObjectCollectionExample.unity
Next UI controls and utilities that we will bring from MRDL
App Bar and Bounding Box (with updated support for motion controllers)
Dialogs
Progress(loading indicator)
Hand coach(from Lunar Module)
Tool tips and Tool tip manager
Motion controller pointer visualizations (Straight & Parabolic)
Radial menu system
Debug Menu and Debug Panel
Solvers
Utility Extensions
Thanks!

When do you think you will finish the merge completely. So the whole MRDL will be in MRTK?

Hi @Druelik
I don't think we will ever have the whole of MRDL integrated into MRTK otherwise there wouldn't be a MRDL.  The simple reason is that we will always have functionality that will be seen as experimental and exploratory.  We're trying to migrate what is really core functionality that should be part of MRTK into MRTK.  As we migrate we will update MRDL with the correct version of MRTK and make sure everything plays nice.
thanks,
-pat