use(swagger()) return error:   The last overload gave the following error.

mouse move to the use(swagger()) return error:   The last overload gave the following error.

But still able to access swagger

Same issue here. The app compiles and swagger works fine. But the editor is complaining.
bun v1.0.7 and bun.lockdb:
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
# yarn lockfile v1
# bun ./bun.lockb --hash: C34DBC2701F70AE4-69e0f13ce5c1229c-44F8A9453AFAA2DC-d5a07984016a1325

"<EMAIL_ADDRESS>
  version "0.7.4"
  resolved<EMAIL_ADDRESS>  integrity sha512-dTZ2ucf9cBgol8X8ekq7dVJ7agw1bvB4ICMpOf7lihfIA8Te3Z0FpXPuGkog27qUKJC8LF5xLxcGwJtAFiVeSg==
  dependencies:
<EMAIL_ADDRESS>"^4.5.7"
    "@types/swagger-ui" "^3.52.2"
    lodash.clonedeep "^4.5.0"
    openapi-types "^12.1.3"

"<EMAIL_ADDRESS>
  version "0.31.18"
  resolved<EMAIL_ADDRESS>  integrity sha512-p2JGz+SciGJVl1zokCIK15f7LYDrI2ZsxItcLhkAyx50hEYEj/Qdy7z30qRYiakzdIu8dV4DfBi+e6xEZuugiQ==

"<EMAIL_ADDRESS>
  version "0.31.21"
  resolved<EMAIL_ADDRESS>  integrity sha512-Wtq/K44EMkREaXytK+2c5DrygtYsH7ZxT0StQL8HMJz2BoOM7NZ/xfrUFBVuZxDrhJCoXf5Im282P2CCz5DHwQ==

"@types/lodash@*":
  version "4.14.200"
  resolved<EMAIL_ADDRESS>  integrity sha512-YI/M/4HRImtNf3pJgbF+W6FrXovqj+T+/HpENLTooK9PnkacBsDpeP3IpHab40CClUfhNmdM2WTNP2sa2dni5Q==

"<EMAIL_ADDRESS>
  version "4.5.8"
  resolved<EMAIL_ADDRESS>  integrity sha512-I5toZLLfTvhnuAnejjVgSpBSLSC316bVURbI0sCYI0dKY3jaJgOg2arfPC6miTNnHRi/Tk/J6BB+kzT3iB5mcw==
  dependencies:
    "@types/lodash" "*"

"<EMAIL_ADDRESS>
  version "3.52.3"
  resolved<EMAIL_ADDRESS>  integrity sha512-CeD8e7peng0ONguJiDsUOaebsf39Dthxqt1geUNecgFFtuKTGxN8D+FEAEkJi3AH4sKf5v42eijU5QGcwL4K7g==

bun-types@latest:
  version "1.0.7"
  resolved "https://registry.npmjs.org/bun-types/-/bun-types-1.0.7.tgz"
  integrity sha512-zlIp+SCutbbugs6xDy+3WC3KO3zKySpF/bRfiTk/VJUdKt+WHAzlCtLplS7XglRYDFzhRhlzXMW/R5BHkw+u2Q==

<EMAIL_ADDRESS>
  version "11.1.0"
  resolved "https://registry.npmjs.org/commander/-/commander-11.1.0.tgz"
  integrity sha512-yPVavfyCcRhmorC7rWlkHn15b4wDVgVmBA7kV4QVBsF7kv/9TKJAbAXVTxvTnwP8HHKjRCJDClKbciiYS7p0DQ==

<EMAIL_ADDRESS>
  version "0.5.0"
  resolved "https://registry.npmjs.org/cookie/-/cookie-0.5.0.tgz"
  integrity sha512-YZ3GUyn/o8gfKJlnlX7g7xq4gyO6OSuhGPKaaGssGB2qgDUS0gPgtTvoyZLTt9Ab6dC4hfc9dV5arkvc/OCmrw==

"elysia@>= 0.7.0":
  version "0.7.17"
  resolved "https://registry.npmjs.org/elysia/-/elysia-0.7.17.tgz"
  integrity sha512-d+kopAonTBezt5ATijVAe4pwvbxTr+yQAP52K8cbMwbHR07HmnwFa4EpZi+sAjqCU20CJNIs1WpJFnnie2ukwQ==
  dependencies:
    "@sinclair/typebox" "^0.31.17"
    cookie "^0.5.0"
    eventemitter3 "^5.0.1"
    fast-querystring "^1.1.2"
    memoirist "0.1.4"
    openapi-types "^12.1.3"

<EMAIL_ADDRESS>
  version "0.7.21"
  resolved "https://registry.npmjs.org/elysia/-/elysia-0.7.21.tgz"
  integrity sha512-E0QVS8ry6PGU195FqJPH1B9BViXI0lveazr8zzuojiBwhPZBcL8aeWfIcSyF44i/T+zppeNGrlInU/mpiTZKVg==
  dependencies:
    "@sinclair/typebox" "^0.31.17"
    cookie "^0.5.0"
    eventemitter3 "^5.0.1"
    fast-querystring "^1.1.2"
    memoirist "0.1.4"
    openapi-types "^12.1.3"

<EMAIL_ADDRESS>
  version "5.0.1"
  resolved "https://registry.npmjs.org/eventemitter3/-/eventemitter3-5.0.1.tgz"
  integrity sha512-GWkBvjiSZK87ELrYOSESUYeVIc9mvLLf/nXalMOS5dYrgZq9o5OVkbZAVM06CVxYsCwH9BDZFPlQTlPA1j4ahA==

<EMAIL_ADDRESS>
  version "1.0.1"
  resolved "https://registry.npmjs.org/fast-decode-uri-component/-/fast-decode-uri-component-1.0.1.tgz"
  integrity sha512-WKgKWg5eUxvRZGwW8FvfbaH7AXSh2cL+3j5fMGzUMCxWBJ3dV3a7Wz8y2f/uQ0e3B6WmodD3oS54jTQ9HVTIIg==

<EMAIL_ADDRESS>
  version "1.1.2"
  resolved "https://registry.npmjs.org/fast-querystring/-/fast-querystring-1.1.2.tgz"
  integrity sha512-g6KuKWmFXc0fID8WWH0jit4g0AGBoJhCkJMb1RmbsSEUNvQ+ZC8D6CUZ+GtF8nMzSPXnhiePyyqqipzNNEnHjg==
  dependencies:
    fast-decode-uri-component "^1.0.1"

<EMAIL_ADDRESS>
  version "4.5.0"
  resolved "https://registry.npmjs.org/lodash.clonedeep/-/lodash.clonedeep-4.5.0.tgz"
  integrity sha512-H5ZhCF25riFd9uB5UCkVKo61m3S/xZk1x4wA6yp/L3RFP6Z/eHH1ymQcGLo7J3GMPfm0V/7m1tryHuGVxpqEBQ==

<EMAIL_ADDRESS>
  version "0.1.4"
  resolved "https://registry.npmjs.org/memoirist/-/memoirist-0.1.4.tgz"
  integrity sha512-D6GbPSqO2nUVOmm7VZjJc5tC60pkOVUPzLwkKl1vCiYP+2b1cG8N9q1O3P0JmNM68u8vsgefPbxRUCSGxSXD+g==

<EMAIL_ADDRESS>
  version "12.1.3"
  resolved "https://registry.npmjs.org/openapi-types/-/openapi-types-12.1.3.tgz"
  integrity sha512-N4YtSYJqghVu4iek2ZUvcN/0aqH1kRDuNqzcycDxhOUpg7GdvLa2F3DgS6yBNhInhv2r/6I0Flkn7CqL8+nIcw==

"typescript@>= 5.0.0"<EMAIL_ADDRESS>
  version "5.2.2"
  resolved "https://registry.npmjs.org/typescript/-/typescript-5.2.2.tgz"
  integrity sha512-mI4WrpHsbCIcwT9cF4FZvr80QUeKvsUsUvKDoR+X/7XHQH98xYD8YHZg7ANtz2GtZt/CBq2QJ0thkGJMHfqc1w==

I got the same type errors after upgrading Elysia and the plugins. I don't know why.
I tried deleting node_modules and purging the Bun cache and reinstalling, but same issue. But if I bun create elysia <name> again and add the plugins anew, I don't get the issue. I investigated some and found both the old and new project to be using the exact same versions of both Elysia and the plugins (checked the package.json inside node_modules for each).
Maybe resetting the lockfile would help, that's the only thing I can think of that I didn't try.
I ended up just moving all the source code over to the newly created project folder, and the issue was "fixed".

I got the same type errors after upgrading Elysia and the plugins. I don't know why.
I tried deleting node_modules and purging the Bun cache and reinstalling, but same issue. But if I bun create elysia <name> again and add the plugins anew, I don't get the issue. I investigated some and found both the old and new project to be using the exact same versions of both Elysia and the plugins (checked the package.json inside node_modules for each).
Maybe resetting the lockfile would help, that's the only thing I can think of that I didn't try.
I ended up just moving all the source code over to the newly created project folder, and the issue was "fixed".
It smells like some kind of versioning or caching on Bun's side, but I honestly have no clue.

Yes, I have deleted bun.lcokb file and node_modules and then bun install it again. The editor typescript stopped crying. It is versioning issue


#9 added the remaining CSS for JS and Pictures

added the remaining CSS for JS and all pictures displayed.

added the remaining CSS for my site.


Fix for #643.

the #selectorsDo: method is in an RB package so doesn't exist during the image stripping process. This is a simple fix. I have no strong opinion if it is right, but it works for me!

I'll merge this, since it fixes the issue, and move the original method later (since the offending change was to speed up the search for resources, and this will slow it down again).
It occurs to me that we can detect this class of issue on many occasions by using SmalltalkSystem>>unimplementedSelectorsIn: (it surfaces up as the Browse/Unimplemented Selectors command in the package browser). Its not 100% foolproof, but it should allow a test to be defined which will catch future mistakes like the one I made which caused this issue. Or at least it will if I also fix #645.


Equipment lifetime

PR Checklist

Please check if your PR fulfills the following requirements:

[] All new classes have class-level documentation comments, if there are any at all
[x] Tests for the changes have been added (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation update
[ ] Other... Please describe:

What is the current behavior?

Equipment creation is not synced currently
What is the new behavior?

Resolves #860 & #861

Equipment creation is synced.
Other information
I am not sure about Equipment deletion. There are quite a few Equipment instances created during the game start.
One idea I had is to delete the corresponding Equipment whenever a hero dies in the hero lifetime service.

crashing after server starts new game with following null errors for craftingLifetime (either for CreatePreCraftedWeaponPostfix -> CraftingRemoved __instance = null or for CultureObject = null as seen below)
System.NullReferenceException
Nachricht = Object reference not set to an instance of an object.
"Common.Messaging.MessagePayload.What.get.CultureObject" war "null".
Stacktrace:
at
private void Handle(MessagePayload payload)
{
objectManager.AddNewObject(payload.What.Crafting, out string newCraftingId);
CraftingCreatedData data = new(newCraftingId,
    payload.What.CraftingTemplate.StringId,
    payload.What.CultureObject.StringId,
    payload.What.TextObject.Value);

...
}
GameInterface.Services.CraftingService.Handlers.CraftingLifetimeHandler.Handle(MessagePayload`1 payload) in C:\Programming Projects\Bannerlord Coop\BannerlordCoop\source\GameInterface\Services\CraftingService\Handlers\CraftingLifetimeHandler.cs: line48


Removal of duplicate emojis

Automated message from Dropbox CLA bot
@abhayKashyap03, it looks like you've already signed the Dropbox CLA. Thanks!

@abhayKashyap03, thanks for working on this. Can you remove that '.java' file? What is the purpose of the changes in 'build_emoji' file; I can't find any place where they are actually used.

Sorry, I put that .java file by mistake.

#3036 was fixed, so closing this.


[Loc] update to Arc XLF

This PR fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.656%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
27183

Relevant Lines:
59220

💛  - Coveralls


DnsNameResolver hangs if search domain results in invalid hostname

Motivation:
DnsNameResolver manages search domains and will retry the request with the different search domains provided to it. However if the query results in an invalid hostname, the Future corresponding to the resolve request will never be completed.
Modifications:

If a resolve attempt results in an invalid hostname and the query isn't issued we should fail the associated promise

Result:
No more hang from DnsNameResolver if search domain results in invalid hostname.

@Scottmitch good catch!


Description of method and statistics from the creation of the supersense-expanded Elexis corpus

The key figures and the key algorithms used to create the new dataset.
Also, challenges, e.g. underdescribed IDs.

Tagging ELEXIS-WSD 1.1 with supersenses
This document concerns itself with the process (and associated challenges of) adding supersenses to the Danish part of the Parallel sense-annotated corpus ELEXIS-WSD 1.1.
Many of the Danish tokens were annotated with sense IDs from the DanNet dataset, meaning that semantic information derived from DanNet could be used in part to further annotate these words; specifically in this case: the synsets/senses in DanNet are annotated with EuroWordNet ontological types.
From ontological type to supersense
Bolette et al had already produced a partial mapping from EuroWordNet ontological types to a (slightly expanded) set of supersenses. This mapping was only partial since it didn't map ontological types to every possible part-of-speech. Supersenses are discrete and partitioned according to part-of-speech. Nevertheless, many supersenses could be assigned based on this direct mapping.
One issue we rant into was the orthogonal nature of the two types categorisations. Ontological types are precise and numerous where multiple semantic "tags" make up a composite type. Supersenses are broad categories with no clear demarcation so words sometimes have no "obvious" home.
One case where this issue manifested had to with the set of words tagged with the supersense verb.creation which ended up containing many words that were clearly verb.consumption or another supersense. We ended up reassigning supersenses for all words tagged as verb.creation in a semi-automatic based on assigning supersenses to a closed set of shared hypernyms.


Issues configuring headers in http-log plugin

Summary
I'm unable to configure headers on the http-log plugin using the headers config option. I've tried several formats, but still Kong refues the configuration. I'm not sure whether I'm not configuring this correctly, or if there's a bug. Can someone provide an example of how to use the option?
I seem to need this functionality to log to splunk, which requires the auth header on the format Authorization: Splunk -token-
Steps To Reproduce

Configure the plugin:

plugins:
  - name: http-log
    service: echo.new-logger
    config:
      http_endpoint: http://mockbin.org/bin/bc1bd4ed-563b-4787-92cd-aed657598d27
      headers:
        - "Headername:headervalue"
#       - Headername: headervalue

The logoutput:

2021/02/18 12:09:37 [verbose] Kong: 2.3.2
2021/02/18 12:09:37 [verbose] prefix in use: /usr/local/kong
Error:
/usr/local/share/lua/5.1/kong/cmd/config.lua:110: Failed parsing:
in 'plugins':
  - in entry 13 of 'plugins':
    in 'config':
      in 'headers': expected a string
stack traceback:
	[C]: in function 'error'
	/usr/local/share/lua/5.1/kong/cmd/config.lua:110: in function 'cmd_exec'
	/usr/local/share/lua/5.1/kong/cmd/init.lua:88: in function </usr/local/share/lua/5.1/kong/cmd/init.lua:88>
	[C]: in function 'xpcall'
	/usr/local/share/lua/5.1/kong/cmd/init.lua:88: in function </usr/local/share/lua/5.1/kong/cmd/init.lua:45>
	/usr/local/bin/kong:9: in function 'file_gen'
	init_worker_by_lua:49: in function <init_worker_by_lua:47>
	[C]: in function 'xpcall'
	init_worker_by_lua:56: in function <init_worker_by_lua:54>

Additional Details

Kong version 2.3.2, declarative

I had the same problem today and the following format worked for me:
plugins:
  - name: http-log
    service: echo.new-logger
    config:
      http_endpoint: http://mockbin.org/bin/bc1bd4ed-563b-4787-92cd-aed657598d27
      headers:
        Headername:
        - headervalue

@espeandr Could you give the above format a try?

Thanks, it works! The format makes sense considering headers can be multi-valued.

I had the same problem today and the following format worked for me:
plugins:
  - name: http-log
    service: echo.new-logger
    config:
      http_endpoint: http://mockbin.org/bin/bc1bd4ed-563b-4787-92cd-aed657598d27
      headers:
        Headername:
        - headervalue

Thank @apehkone support.
Issue work for me !


Dump HLSL/GLSL/VKSL shaders

This allow to dump HLSL / GLSL / VKSL to the temp folder. This is useful to debug the XCompiler output. Currently it supports VS/FS/CS.

I'm not confortable integrating this sort of functionality in the importer. I don't like outputting data as a side effect of another operation, even if just for debugging. Plus I usually find it easy enough to set a breakpoint and just read the shader source directly there.
I'd perhaps be fine with it if it was a separate utility class & method for dumping the shader. And ideally this would be something that's only called from the import tool (with a flag that tells it to dump shader data).

I understand. I used it to dump all shaders for a XCompiler test.

XShaderCompiler comes with an optional GUI debugger tool that translates shader code on the fly as you type it, it's quite useful. Requires wxWidgets as a dependency.


Also cluster regular sockets?

I was wondering if it would be easy to add support for clustering regular TCP connections. I have a project where I need to accept connections with a plain TCP protocol, and having the SC infrastructure is nice. Right now I have only the one process accepting connections.
Alternatively, is it possible to somehow accept plain TCP with the websocket server?
I can only ask 😄

It would be a lot of work since WebSocket connections start with a HTTP request and a lot of properties that exist with WebSockets would not be present with TCP.


Internationalization

As a visitor to the KBSS website, I may not be fluent in English. Since our group is a public part of the university, we should consider having the pages in Czech as well.

I see this is low priority, first everything must work in english.


JS error creating a new map

STR

"New map" button.
Pick a dataset (my example was a points one).

There's a JS error in the console:
cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/models.js:5 Uncaught TypeError:

Cannot read property 'get' of undefineddefault

For @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/models.js:5initialize @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/models.js:5a.Model @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5d @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5d @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5_form @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/models.js:5_updateForm @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/models.js:5initialize @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/models.js:5a.Model @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5d @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5d @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5initialize @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/models.js:3a.Model @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5d @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5d @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5d @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5d @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5model @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/models.js:3_prepareModel @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5add @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5add @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/models.js:3reset @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5b.success @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:5l @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:2fireWith @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:2d @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:4d @ cartodb-libs.global.ssl.fastly.net/cartodbui/assets/3.27.27/javascripts/cdb.js:4

Navigated to https://team.cartodb.com/u/juanignaciosl/viz/68a61ede-39e6-11e6-9206-0ecd1babdde5/map

I can't find anything that doesn't work though.
cc @xavijam @matallo

can't reproduce, investigating furher :S

Ok, let me know if I can help, because it always happens in my account. This is the line var form_data = cdb.admin.forms.get(type)[this.table.geomColumnTypes()[0] || 'point'];. cdb.admin.forms is undefined.
It doesn't happen in another account I use for testing, so it might be because a wrong metadata entry in my dashboard. Doesn't look like a general problem 👍

can we close this @juanignaciosl I have not been able to reproduce 😞

it happens @matallo, but it is related with the dashboard.


in /demo/README.md explain how to use requirements.txt

e.g.

pip3 install -r requirements.txt

Since PR #17 requires to run the demo only with docker, we probably don't need the requirements.txt instruction

Onnnnitttttt

requirements.txt

readme (1).md
readme (1).md

Why are they still coming up as links ??

I've updated the file


Restic restore fails for dynamically provisioned EFS volume

After having successfully performed a restic-integrated backup, and deleting the backed-up namespace, restoring the same fails. The output from the restic pod on the host shows:
time="2018-06-21T22:02:50Z" level=error msg="Error getting volume directory name" controller=pod-volume-backup error="volume not found in pod" error.file="utils.go:66" error.function=GetVolumeDirectory logSource="pkg/controller/pod_volume_backup_controller.go:158" name=nginx-example-pb4kc namespace=heptio-ark
time="2018-06-22T10:15:35Z" level=error msg="Error restoring volume" controller=pod-volume-restore error="error identifying path of volume: expected one matching path, got 0" error.file="pod_volume_backup_controller.go:295" error.function=singlePathMatch logSource="pkg/controller/pod_volume_restore_controller.go:273" name=nginx-example-20180622121532-zfcj8 namespace=heptio-ark

Here's the full manifest of the backed up item (this was the only stuff living in the backed-up namespace):
---
apiVersion: v1
kind: Namespace
metadata:
  name: nginx-example
  labels:
    app: nginx

---
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  name: nginx-logs
  namespace: nginx-example
  labels:
    app: nginx
spec:
  storageClassName: aws-efs
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 50Mi

---
apiVersion: apps/v1beta1
kind: Deployment
metadata:
  name: nginx-deployment
  namespace: nginx-example
spec:
  replicas: 1
  template:
    metadata:
      labels:
        app: nginx
      annotations:
        backup.ark.heptio.com/backup-volumes: nginx-logs
    spec:
      volumes:
        - name: nginx-logs
          persistentVolumeClaim:
           claimName: nginx-logs
      containers:
      - image: nginx:1.7.9
        name: nginx
        ports:
        - containerPort: 80
        volumeMounts:
          - mountPath: "/var/log/nginx"
            name: nginx-logs
            readOnly: false

---
apiVersion: v1
kind: Service
metadata:
  labels:
    app: nginx
  name: my-nginx
  namespace: nginx-example
spec:
  ports:
  - port: 80
    targetPort: 80
  selector:
    app: nginx
  type: LoadBalancer

I have a feeling this will be fixed by #569

ah, gotcha. Testing.

Hm, still not good. I'm using the "efs-provisioner" (https://github.com/kubernetes-incubator/external-storage/tree/master/aws/efs) to mount EFS-based volumes with pods.
Just thinking out load: When I deleted the namespace (which contained the pvc), efs-provisioner essentially deletes that pvc dir inside the EFS. When I perform a restore, it's unclear to me what happens when ark recreates that pvc. I'll do another test where the pvc is kept outside of the deleted namespace, but still recreated (to zero it out) and see what happens.

log from the to-be-restored pod:
  Warning  FailedMount            51s   kubelet, ip-10-245-20-18.eu-west-1.compute.internal  MountVolume.SetUp failed for volume "pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0" : mount failed: exit status 32
Mounting command: systemd-run
Mounting arguments: --description=Kubernetes transient mount for /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 --scope -- mount -t nfs -o vers=4.1 fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0
Output: Running scope as unit run-r8f1b15f2ce8b4881b7a8266f85facb76.scope.
mount.nfs: mounting fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 failed, reason given by server: No such file or directory
  Warning  FailedMount  50s  kubelet, ip-10-245-20-18.eu-west-1.compute.internal  MountVolume.SetUp failed for volume "pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0" : mount failed: exit status 32
Mounting command: systemd-run
Mounting arguments: --description=Kubernetes transient mount for /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 --scope -- mount -t nfs -o vers=4.1 fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0
Output: Running scope as unit run-r0aba8a64e72d46ab84ef4b1da4d6a17c.scope.
mount.nfs: mounting fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 failed, reason given by server: No such file or directory
  Warning  FailedMount  49s  kubelet, ip-10-245-20-18.eu-west-1.compute.internal  MountVolume.SetUp failed for volume "pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0" : mount failed: exit status 32
Mounting command: systemd-run
Mounting arguments: --description=Kubernetes transient mount for /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 --scope -- mount -t nfs -o vers=4.1 fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0
Output: Running scope as unit run-r380973402f3d44c699dd3e86ad10049f.scope.
mount.nfs: mounting fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 failed, reason given by server: No such file or directory
  Warning  FailedMount  47s  kubelet, ip-10-245-20-18.eu-west-1.compute.internal  MountVolume.SetUp failed for volume "pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0" : mount failed: exit status 32
Mounting command: systemd-run
Mounting arguments: --description=Kubernetes transient mount for /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 --scope -- mount -t nfs -o vers=4.1 fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0
Output: Running scope as unit run-ra4f02e899b274aa7a43aecafb32dd0ba.scope.
mount.nfs: mounting fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 failed, reason given by server: No such file or directory
  Warning  FailedMount  43s  kubelet, ip-10-245-20-18.eu-west-1.compute.internal  MountVolume.SetUp failed for volume "pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0" : mount failed: exit status 32
Mounting command: systemd-run
Mounting arguments: --description=Kubernetes transient mount for /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 --scope -- mount -t nfs -o vers=4.1 fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0
Output: Running scope as unit run-r5eaf3439079048ed9727fbd3b5dfa3f4.scope.
mount.nfs: mounting fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 failed, reason given by server: No such file or directory
  Warning  FailedMount  35s  kubelet, ip-10-245-20-18.eu-west-1.compute.internal  MountVolume.SetUp failed for volume "pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0" : mount failed: exit status 32
Mounting command: systemd-run
Mounting arguments: --description=Kubernetes transient mount for /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 --scope -- mount -t nfs -o vers=4.1 fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0
Output: Running scope as unit run-r6fa36f9af6c94ae7b13360ba2eef7457.scope.
mount.nfs: mounting fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 failed, reason given by server: No such file or directory
  Warning  FailedMount  19s  kubelet, ip-10-245-20-18.eu-west-1.compute.internal  MountVolume.SetUp failed for volume "pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0" : mount failed: exit status 32
Mounting command: systemd-run
Mounting arguments: --description=Kubernetes transient mount for /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 --scope -- mount -t nfs -o vers=4.1 fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 /var/lib/kubelet/pods/ea283fa7-7607-11e8-8ee2-06c9704435d0/volumes/kubernetes.io~nfs/pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0
Output: Running scope as unit run-raeb6c5bcd5144568a7e67c093704241c.scope.
mount.nfs: mounting fs-59c6a090.efs.eu-west-1.amazonaws.com:/nginx-logs-pvc-b1e26f90-7590-11e8-8ee2-06c9704435d0 failed, reason given by server: No such file or directory

Ok, must be a different root cause. I'll be back online around 9:30am EDT and we can chat more if you'd like.

thanks!

Hm, I'm not able to make it take a backup if I do more granular filtering. It's not clear to me how ark behaves i i include a deployment, but exclude the pvc used by a pod in a deployment. It's also not very easy to see the list of resources (objects) contained in a backup :thinking:

@trondhindenes I have a theory for why the restore fails. I'm going to spin up a test cluster to try it out.
When backing up, Ark currently automatically includes all PVCs referenced by a pod, as well as all PVs referenced by PVCs (regardless of the excluded resources setting). We may need to consider adjusting this behavior.
We have a couple of open issues related to seeing what's in a backup: #448 (which is for restores, but we might do for backups too) and #396. In the meantime, you can run ark backup download NAME to download the backup tarball and you'll be able to see exactly what Ark backed up.
I'll report back on my theory once I run my test.

sweet, thanks! I wanted to verify that my selector had "hit" the pod but not the pvc but couldn't find an easy way to do that. Downloading the tar works as a workaround. I would definetely be interested in a backup-scoped view of "what's in the backup".

I guess the expected behavior at restore would be to create the pvc, and then let Kubernetes' control loop "satisfy" that with a pv, which would then be mounted and restored using the restic integration.
That said, a volume can also be "static" (eg not created to respond to a pvc) so there's definetely some complexity in getting the backup restore right. Personally I wouldn't mind if there truckload of options to fine-tune ark's behavior both when backing up and restoring.

Yes, the issue here is what I thought - Ark recreates the PV from the backup, which points at the path in the NFS (EFS) server that no longer exists (due to it being deleted when the PVC was deleted). We'll see what we can come up with.

imho a suitable logic would be:

if pod has volume(s), grab the list of volume (but controllable by a flag)
if volume is created based on a pvc, backup only the pvc object, not the pv (but controllable by a flag)

I haven't worked with that many other volume "drivers" but backing up/restoring a pvc-created pv object kinda never seems like a good idea to me, as there's a big chance of doing things that the volume provisioner should get to do exclusively.

My plan is to skip restoring a PV if the following 2 things are true:

We don't have a block storage snapshot for it
Its reclaim policy is Delete

yup that makes sense. I have to admit I haven't worked with EBS-based volumes.

@ncdc What's your thinking for (2) Its reclaim policy is Delete?  I'm wondering if explicit CLI option(s) would be better.

Yes, both true. If it's a dynamically provisioned PV with a reclaim policy of Delete (the default) and Ark didn't take a block snapshot, then there's no way that having Ark recreate the PV will be useful:

If the PV is still in the cluster, then when Ark tries to restore it, it will get an already-exists error, and it will be a no-op. There's no data loss because it's still there. We can't restore anything because we don't have a snapshot. If we have a restic backup, we'll be able to restore it.
If the PV is not in the cluster, then when Ark tries to restore it, it will get created successfully. However, the PV in the backup refers to some vendor-specific metadata that doesn't exist any more, because of the combination of dynamic provisioning and the Delete reclaim policy - whatever was dynamically created before has been deleted, and any PV json that says "it's NFS with path /foo" or whatever will be invalid. What you end up with is the kubelet continually attempting to attach and mount a volume that's unmountable.

Ok! I now understand.  👍

Putting this against v0.9.0, let me know if that doesn't make sense.

I'd be happy to test a prerelease build in my env

Ok great. I can get you an image tomorrow morning.
On Mon, Jun 25, 2018 at 8:57 PM Trond Hindenes<EMAIL_ADDRESS>wrote:

I'd be happy to test a prerelease build in my env
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/heptio/ark/issues/572#issuecomment-400142439, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAABYpHNINtyBy-_r5LQgB_22l7Ojw9bks5uAYcVgaJpZM4UziIr
.

@trondhindenes I just pushed gcr.io/andy-heptio/ark:restic-efs-test and gcr.io/andy-heptio/ark-restic-restore-helper:restic-efs-test. You should be able to use the same ark command line client you currently have. Let me know how it goes!

sweet, will do!

hm, how do I use the ark-restic-restore-helper image? I've updated both the ark pod and the restic daemonset pods to use the gcr.io/andy-heptio/ark:restic-efs-test image.

Heh that was probably more information than you needed :-) Ark will automatically pick it up as the image to use in the pod init containers when restoring - you won't need to do anything.

good to know :-) thanks! will try and do some testing today.

hm, I'm getting a new strange error while performing the backup operation:
time="2018-06-26T20:10:15Z" level=info msg="Backup completed with errors: restic repository not found: resticrepository.ark.heptio.com \"nginx-example2\" not found" backup=heptio-ark/nginx-backup3 logSource="pkg/backup/backup.go:301"

Exact same config/operation as before (this worked on the release version of ark)


Bi-directional communication drops sync

After a few commands and reliably after a remote command 'c' is sent out, the connection loses sync and there's an offset in the buffer that breaks the encryption. May be hard to diagnose so may be a bit.

Confirmed this isn't an issue with just the remote command but any command. m:hi repeated 3 times will drop sync.

Resolved by:
https://github.com/nuvious/aioquic/commit/9b6dfa0364e48ef3cb4d9acba78e6fcf6bb579ea
Issue was due to improper truncation of the CID history.


Parameters required by default when generating modules from JavaScript files

TypeScript Version:  4.1.2x

Search Terms:
transpile javascript optional parameters
Code
export default function example (hello, optionalParam={}) {
  console.log(hello);
}

export default function example(hello: any, optionalParam?: object): void;

The first parameter is now required. While there is syntax to make parameters optional as shown above, shouldn't all javascript parameters be optional unless specified by a JSDoc?
Ideally there would be some configuration for this to allow a "optional by default".
Expected behavior:
https://www.typescriptlang.org/docs/handbook/type-checking-javascript-files.html#function-parameters-are-optional-by-default
Actual behavior:
Parameters are not optional by default.
Playground Link:
Related Issues:

This is the intended behavior (most parameters are required) but some configurability might be something that a lot of people want, if there's evidence for that.

I don't understand the decision to make all parameters optional in js (even with ts-check and latest target), and the inconsistency that is shown there (in-ide typechecking vs generated .d.ts). IMO params should be required by default even in js since you can just write a = undefined in parameter

The goal of JS inference is to infer behavior from existing code that was written without knowledge of TypeScript. Since = undefined was not (and is not) idiomatic JS for indicating an optional parameter, we went with the more permissive rule. With the default parameter type being any, it also doesn't really make sense to allow f(3, undefined) but not f(3) - those are for all intents and purposes the same call. If you want more accurate info, JS Doc is there.


Update .gitignore

Exclude .idea which is a directory store the project settings on IntelliJ IDEA.

Thank you for your pull request! (and it's the very first pull request to this repository!!)
Since I don't use IDEA, I forgot to add the line you added.
I'll merge this pull request.


chore: add coverage

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b614160). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #75   +/-   ##
=========================================
  Coverage          ?   69.95%
=========================================
  Files             ?        3
  Lines             ?      243
  Branches          ?       34
=========================================
  Hits              ?      170
  Misses            ?       73
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b614160...d708bca. Read the comment docs.


🐛 HPC-8330: Remove incorrect status component

This was left over during the refactor, and should not exist.

tested https://red.dev.plan2-hpc-tools.ahconu.org/operations/1/forms/w/1/data/8 and working well


[FLINK-8025] Let DashboardConfigHandler directly extend AbstractRestHandler

What is the purpose of the change
Let DashboardConfigHandler directly extend AbstractRestHandler.
PR is based on #4982.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Thanks for your review @zentol. Merging.


Ember recieve script selects ember stacks above the max ember stack amount

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[x] I read the Troubleshooting Guide

FGO server
NA
FGA build number
1908
Describe the bug
The script selects incorrect stacks of embers, as if it was not looking at the entire number
Video
bruhtube video of the issue
Device model
Bluestacks <IP_ADDRESS>0 N32
Android version
7
Screen size
No response
RAM
No response

Duplicate of #1009
I can't think of any solution other than using OCR to parse the text.

If the only solution is image matching, then my vote is having available the single digits 1-9 would probably (?) be sufficient.


Use system file locks for mirror clone operations

Is your feature request related to a problem? Please describe.
We’re running multiple agents on the same EC2 instance with ECS and we’re seeing an issue when the agent is killed while checking out the repo using the experimental git mirror feature.
In this case the agent never had a chance to release the lock because we deployed and it was hard killed by ECS because the agent didn't stop before the SIGINT timeout expired and now any other builds on the same EC2 instance are failing to grab the clone lock because it's a shared mounted directory between all the agents.
Digging through the agent source, it seems like the agent is using https://github.com/nightlyone/lockfile to do file locking. The library manages temporary files itself https://github.com/nightlyone/lockfile/blob/master/lockfile.go#L205 and when the agent is forcefully killed the pid file is left on disk with the old agent pid still reserving the lock. It seems like when it tries to find if the owner of the lock is still running it can't because it’s from another docker container so it’ll return nil here: https://github.com/nightlyone/lockfile/blob/master/lockfile.go#L70 which will just see if it matches the current pid which it won’t https://github.com/nightlyone/lockfile/blob/master/lockfile.go#L146.
This issue is mentioned in this old issue in the lockfile repo https://github.com/nightlyone/lockfile/issues/25#issuecomment-454053849
Describe the solution you'd like
Our current build system uses flock https://linux.die.net/man/2/flock to implement locking for the exact same use case. Flock uses the operating system's native locking when available which uses file descriptors to ensure if the process holding the lock is killed the file descriptors are automatically cleaned up. I found https://github.com/gofrs/flock which is an alternative go library that uses flock sys calls internally with a very similar interface to lockfile that could be used as a replacement. We've used flock successfully between docker containers with shared volumes and mounts from the host system.
Describe alternatives you've considered
https://github.com/nightlyone/lockfile/issues/25 suggests storing additional metadata to determine if the lock file is invalid. I don't think that's as good as using flock since it's more work and won't be as reliable.
Additional context
The log we see until we terminate the EC2 instance on any agent running is
[2022-04-27T21:31:14Z] # Could not acquire lock on "/var/reference_repos/repo.clonelock" (Locked by other process)
[2022-04-27T21:31:14Z] # Trying again in 1s...
...

repeated until the lock timeout is reached.

@KevinGreen this is a really interesting one! i can totally understand your frustration here, it's absolutely not an ideal solution. i'd imagine that it would be even worse if the git mirror was being shared across multiple machines, ie with an EFS mount.
The flock library you posted looks really interesting, but in my (admittedly extremely limited) testing, it seems like equivalent lockfiles don't propagate locked-ness properly - ie, i have some test code:
package main

import (
	"fmt"
	"time"

	"github.com/gofrs/flock"
)

func main() {
	go func() {
		lock := flock.New("./cool.lock")
		lock.TryLock()
		time.Sleep(5 * time.Second)
		lock.Unlock()
	}()

	lock := flock.New("./cool.lock")
	slept := time.Duration(0)
	for {
		if slept > 7*time.Second {
			break
		}
		state := "unlocked"
		if lock.Locked() {
			state = "locked"
		}
		fmt.Printf("cool.lock is %s\n", state)

		time.Sleep(500 * time.Millisecond)
		slept += 500 * time.Millisecond
	}
}

which outputs
$ go run main.go
cool.lock is unlocked
cool.lock is unlocked
# ...
cool.lock is unlocked
cool.lock is unlocked

if i'm reading this output correctly (which it's entirely possible that i'm not! please correct me if i'm wrong) it seems like this wouldn't fulfill our needs of locking the git mirror directory between competing agents.
i'm happy to work with you on finding a better solution though! i agree that what we have is less than ideal.

Our current build system uses flock https://linux.die.net/man/2/flock to implement locking for the exact same use case

i'd be really interested in knowing more about how this works - if it's something we could integrate into the agent, everyone wins :)

Hi @moskyb, thanks for the quick response!
I hadn't used the gofrs/flock library before posting so I'm definitely not very used to it.
I was wondering if flock.Locked() was doing something to the lock itself so I added more logging and switch it to doing a read lock explicitly. I added logging and it looked like the go routine wasn't actually getting the lock before running the sleep call. It doesn't look like lock.TryLock() will block and since the main function grabs a read lock it may not be unlocked before it runs TryLock(). I think switching to Lock() would block until it can grab it but I tried the following code successfully.
package main

import (
        "fmt"
        "time"

        "github.com/gofrs/flock"
)

func main() {
        go func() {
                lock := flock.New("./cool.lock")
                locked, _ := lock.TryLock()
                fmt.Printf("We got the lock? %v\n", locked)
                fmt.Printf("Going to sleep\n")
                time.Sleep(5 * time.Second)
                fmt.Printf("Finished sleeping\n")
                lock.Unlock()
        }()

        lock := flock.New("./cool.lock")
        slept := time.Duration(0)
        for {
                if slept > 7*time.Second {
                        break
                }
                state := "unlocked"
                gotLock, _ := lock.TryRLock()
                if !gotLock {
                        state = "locked"
                }
                fmt.Printf("cool.lock is %s\n", state)
                lock.Unlock()

                time.Sleep(500 * time.Millisecond)
                slept += 500 * time.Millisecond
        }
}

With these changes I see:
$ go run main.go
cool.lock is unlocked
We got the lock? true
Going to sleep
cool.lock is locked
cool.lock is locked
cool.lock is locked
cool.lock is locked
cool.lock is locked
cool.lock is locked
cool.lock is locked
cool.lock is locked
cool.lock is locked
Finished sleeping
cool.lock is unlocked
cool.lock is unlocked
cool.lock is unlocked
cool.lock is unlocked
cool.lock is unlocked

oooh that's very nice! that could be really useful.
@KevinGreen if you're keen you're more than welcome to submit a PR for this, otherwise, i'll add it to our backlog of things to do, and we'll get to it eventually.

Hi Ben, I opened a PR to try this out https://github.com/buildkite/agent/pull/1624. We're seeing this pretty often as we're treating our buildkite infrastructure pretty roughly during testing.


Do not throw an error on undefined schema output

In the case that you don't have the output defined for a particular route, this plugin will throw an error. I believe this should be considered an error because the TRPC documentation states:
In version 9 docs:
"This is entirely optional and only if you want to ensure you don't accidentally leak anything e"
https://trpc.io/docs/v9/output-validation
In version 11 docs:
"Validating outputs is not always as important as defining inputs, since tRPC gives you automatic type-safety by inferring the return type of your procedures. Some reasons to define an output validator include"
https://trpc.io/docs/server/validators#output-validators
So it seems like the definition of an output should be considered optional, and it is not reasonable that an error should be thrown if the output is not defined.
I'm sure there were very well thought out reasons why throwing an error was chosen, so please correct me if I am wrong here or if there is an edge case I am not understanding correctly.

Afaik generating types from runtime stuff (eg schemas) that occurs in trpc queries and mutations if doable, but not the other way around. I dont beliebe you can, with 100% positivity, generate validators from types. I like to think as types are just an IDE hints that unfortunately can lie.
Leta take an example of userSchema below:
const userSchema=z.object({
name: z.string(),
email:z.string().email(),
password: z string().min(8)
})
type User=z.infer
//that resolves to:
type User={
name: string
email: string,
password: string,
}
So the validation is lost and just IDE hints remain.
There are some generators that help you generate schemas from types but imo they would be hard to incorporate into a library- would it need the library’s code to change when it’s consumer’s (web app’s) code changes?


BUG: Underline is not responsive in menu items

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Underline in menu items is not responsive in small screen sizes, it goes beyond the width of menu item.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a SWOC24 contributor
[X] I want to work on this issue

Hey I want to work on this can you please assign it me? @vishal-bhangare

@vishal-bhangare assigned


AppSDK 1.5 experimental 1 download links are broken

Describe the bug
All of the download links here:

do not work.
Steps to reproduce the bug

Expected behavior
No response
Screenshots
No response
NuGet package version
None
Packaging type
No response
Windows version
No response
IDE
No response
Additional context
No response

Apologies. We missed a step to activate these links. Thanks for bringing this to our awareness. This should be fixed now.


Unhandled exception in WarmUp() method on PowerShell exit

Occasionally PowerShell throws unhandled exception on exit when Microsoft.WinGet.CommandNotFound is imported.
This happens at Microsoft.WinGet.CommandNotFound.WinGetCommandNotFoundFeedbackPredictor.WarmUp() method call.
Steps to reproduce

pwsh -nop
ipmo Microsoft.WinGet.CommandNotFound
exit

Error:
An error has occurred that was not properly handled. Additional information is shown below. The PowerShell process will exit.Unhandled exception. System.Management.Automation.PipelineStoppedException: The pipeline has been stopped.
   at System.Management.Automation.Runspaces.AsyncResult.EndInvoke()
   at System.Management.Automation.PowerShell.EndInvoke(IAsyncResult asyncResult)
   at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic(IAsyncResult iar, Func`2 endFunction, Action`1 endAction, Task`1 promise, Boolean requiresSynchronization)
--- End of stack trace from previous location ---
   at Microsoft.WinGet.CommandNotFound.WinGetCommandNotFoundFeedbackPredictor.WarmUp()
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_1(Object state)
   at System.Threading.QueueUserWorkItemCallback.Execute()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()

Visuals:

System:
Name                           Value
----                           -----
PSVersion                      7.4.2
PSEdition                      Core
GitCommitId                    7.4.2
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

ModuleType Version    PreRelease Name                                ExportedCommands
---------- -------    ---------- ----                                ----------------
Binary     1.8.1133              Microsoft.WinGet.Client             {Add-WinGetSource, Assert-WinGetPackageManager, D…
Manifest   <IP_ADDRESS>               Microsoft.WinGet.CommandNotFound

similar issue, here... pwsh 7.4.2 team said to file bug here based on my strace.
Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
pwsh 7.4.2 run as administrator context from taskbar->UAC is, seemingly randomly, imploding just sitting there a few seconds after UAC validation, no command line input at all. I can't seem to recreate the issue with a standard (current winlogon) user account.
Expected behavior
I'd prefer pwsh stops randomly crashing (env vars and user's powershell profile are mostly default, where not it's app defaults like whatever vbox might drop in there.)

Actual behavior
PS> #no actual cmdline entry nor submission.

Error details
An error has occurred that was not properly handled. Additional information is shown below. The PowerShell process will exit.
Unhandled exception. System.Management.Automation.CmdletInvocationException: Failedtocreateinstance: -2147023174
———>System.Runtime.InteropServices.COMException(Øx8ØØ7Ø6BA):Failedtocreateinstance:-2147023174
	at Microsoft.WinGet.Client.Engine.Helpers.ManagementDep10ymentFactory.Create[T](Typetype,Guid&iid)
	at Microsoft.WinGet.Client.Engine.HeIpers.ManagementDeploymentFactory.CreateCreateCompositePackageCataIogOptions()
	at Microsoft.WinGet.Client.Engine.Commands.Common.FinderCommand.GetPackageCatalogReference(CompositeSearchBehaviorbehavior)
	at Microsoft.WinGet.Client.Engine.Commands.Common.FinderCommand.GetPackageCatalog(CompositeSearchBehaviorbehavior)
	at Microsoft.WinGet.Client.Engine.Commands.Common.FinderCommand.FindPackages(CompositeSearchBehaviorbehavior,UlnE32limit,PackageFie1dMatchOptionmatch)
	at Microsoft.WinGet.Client.Engine.Commands.Common.FinderExtendedCommand.FindPackages(CompositeSearchBehaviorbehavior,PackageFieldMatchOptionmatch)
	at ,Microsoft„.WinGet.Client.Engine.Commands.FinderPackageCommand.<>splayClassl_Ø.<Find>b__Ø()
	at Microsoft.WinGet.Client.Engine.Commands.Common.ManagementDep10ymentCommand.Execute[TResult](FuncS1func)
	at Microsoft.WinGet.Client.Engine.Commands.FinderPackageCommand.Find(StringpsPackageFieldMatchOption)
	at Microsoft.WinGet.Client.Commands.FindPackageCmd1et.ProcessRecord()
	at System.Management.Automation.CommandProcessor.ProcessRecord()
	---Endofinnerexceptionstacktrace—
	at System.Management.Automation.Runspaces.AsyncResult.Endlnvoke()
	at System.Management.Automation.PowerShell.EndInvoke(IAsyncResultasyncResult)
	at System.Threading.Tasks.TaskFactoryS1.FromAsyncCoreLogic(IAsyncResultiar,FuncS2endFunction,Actions1endAction,TaskSlpromise,BooleanrequiresSynchroniztion)
—Endofstacktracefrompreviouslocation—
	at Microsoft.WinGet.CommandNotFound.WinGetCommandNotFoundFeedbackPredictor.WarmUp()
	at System.Threading.Tasks.Task.<(Objectstate)
	at System.Threading.QueueUserWorkItemCa11back.Execute()
	at System.Threading.ThreadPoolWorkQueue.Dispatch()
	at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()

Environment data
Name                           Value
----                           -----
PSVersion                      7.4.2
PSEdition                      Core
GitCommitId                    7.4.2
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals

@MfMpEng The stack trace looks a bit different, so I moved yours over to #9.


remove unused block-sync-concurrency flag

Signed-off-by: Ben Ye<EMAIL_ADDRESS>

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
The flag --block-sync-concurrency in compactor is not used anywhere so remove it.

Verification

What do we you mean by is not used anywhere? It seems that the flag value was passed to the NewMetaSyncer func, no?

What do you mean by is not used anywhere? It seems that the flag value was passed to the NewMetaSyncer func, no?

It is passed into the syncer but syncer doesn't use this value anywhere.


Added missing bridge days for Russia for 2023

Proposed change
Added missing bridge days for Russia for 2023. Determined yearly by the government: https://www.consultant.ru/document/cons_doc_LAW_425407/
Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good: make pre-commit
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
[ ] The related documentation has been added/updated (check off the box for free if no updates is required)

Some issues still need to be fixed. Could you also add tests for these holidays?

Some issues still need to be fixed. Could you also add tests for these holidays?

The test ran okay on the latest one. Unless I'm doing it wrong?

Coverage: 99.681% (-0.05%) from 99.73% when pulling 94bbb02ce743ba4dc1585ea45d57e5f5c5a40a40 on leeloo-1337:updating-holidays into c2215e3a1066147da1b1c9bd3656c8252957f180 on dr-prodigy:beta.


Iterate demo page header style

Iterate demo page header style
Description
This pull-request improves the style of the Headers on the demo.html.  It puts the main title and header information in a Bootstrap 'jumbotron'.  The spacing could be improved in a follow-up iteration.   Additionally the boarder spacing is changed to use Bootstraps 'container' spacing.
Related Issue
https://github.com/JustinGOSSES/wellio.js/issues/52
Duplication of demo page between wellio & wellioviz?
Motivation and Context
This change improves the audience viewing experience of the demo.html.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

Note: Test run:

Load a las file
Convert the las file
UWI displays
Curve Headers display
Clicking on a Curve Header attempts to display visually, but fails (same behavior as before)

Let me know if this change could be accepted (or rejected) or
needs some additional changes before being approved and merged.
Thank you,
DC

Thanks for merging.
DC


[Werid Behavior] Trail will render wrong value except first child.

First, thank you for this wonderful library!
Please see this official example of Trail except opacity is 0 ~ 1

As you can see, when the animation ends, the number is decreasing rather than 1 (only the first child is 1)
I think this is unexpected behavior.
Don't know what do you think? Thanks.

@rockmandash i think i know what it could be. Trail is pretty expensive so i throttle it a little, its probably missing the tail call. I'll look into it.

@drcmda Thank you for your fast reply.

this took a while, had to figure out a way to do tail call throttling without adding too many bytes to this lib. but it should work as expected now.


Multi-Modal CelebA-HQ Dataset

Hello, I'm excited about your excellent work!
I want to download Multi-Modal CelebA-HQ Dataset described in your paper, according to the URL provided by https://drive.google.com/drive/folders/1eVrGKfkbw7bh9xPcX8HJa-qWQTD9aWvf.
Sadly, I can't access it. Is the URL correct? How can I download this dataset?
I look forward to your reply!

fixed.

Thanks.


Update Kiota API to 26.0.5

closes: #148

Nice!
@NikiforovAll Let me know if there's anything disagreeable in this PR and I'll do my best to correct.

@Persistent13 Could you please update the version of the Kitoa package manually?

Also, kiota CLI has been installed as dotnet-tool, could you please update id and try to regenerate to make sure we use the same version of Kiota CLI

Also, please make changes from https://github.com/NikiforovAll/keycloak-authorization-services-dotnet/pull/148 to this PR

First and foremost, thank you for the contribution

@NikiforovAll I've updated the kiota versions and re-ran the generation command. I used 1.14.0 as that was newer, if you'd like me to use 1.13.1 explicitly, please let me know.
I updated the nuget package version to 26.0.5.
Please let me know if there's anything else.

Thank you for your contribution. Did you run dotnet tool restore in the root of the directory? I think we have kiota 1.15 installed as a local dotnet tool. Could you please update the version of the local dotnet tool and re-run the generation?
dotnet tool install --local Microsoft.OpenApi.Kiota --version 1.20.0

Also, it would be great to test the generated SDK manually to make sure everything works. What do you think?

Yes, I did run it with the cached version. Apologies!
I think the new push should have corrected this. I won't be able to test it my time tonight, but I should be able to tomorrow. I'll update with my findings then.

I appreciate your work!

@NikiforovAll Sorry for the delay, I had some stuff that took my time away from this.
From what I can see, it all works fine. I tried out the newer organization APIs as well and didn't run into any issues. I could create and delete orgs without issue after enabling the feature for a given realm.


mdl-radio-* breaks name="..." attribution used by jQuery.validate (among others)

I admit to being a poor reader of the docs, so feel free to tell me to RTFM here if this is intended behavior. See my gist.

Please use StackOverflow for support and integration help. We can only handle problems directly related to the code MDL provides.
When filing an issue in the future, please provide a minimal reproduction case and clearly explain what is expected and what you get instead.

Link to SO question


2 players use "Portable teleporter" at same time result only 1 player get teleported

The current portable teleporter are missing a check to see if ShipTeleporter are in the "Beaming" (internal name "useTeleporter") state, and player can trigger the teleporter many times even it's already trying to teleport player back to the ship.
The possible fixes is add a check for the teleporter button status in BasePortableTeleporter.cs L113
if (teleporter == null || !teleporter.buttonTrigger.interactable)

This make portable teleporter follows vanilla 10 seconds cooldown, if teleporter are in cooldown, nobody can use portable teleporter.

Fixed in https://github.com/Malcolm-Q/LC-LateGameUpgrades/commit/d6d32d1f0243968a0bd3f8762c4f8e071d0729fb.


Single table inheritance

I have an abstract entity which uses single table inheritance. Using a discriminator map, I'm mapping 3 entities that extend my abstract entity.
In my dh_doctrine_audit.yaml under entities, I've put my parent class. Whenever I change one of the subclasses, no audits are created. I also did try splitting my audit config out by including the 3 entities individually.
Here is my yaml config:
dh_doctrine_audit:
    table_prefix: 'audit_'
    table_suffix: ''

    ignored_columns:
        - created
        - updated
        - createdBy
        - updatedBy

    entities:
        App\Entity\AbstractFooBar: ~

Here is the parent class:
/**
 * @ORM\DiscriminatorColumn(name="type", type="string")
 * @ORM\DiscriminatorMap({
 *     "example_one" = "ExampleOne",
 *     "example_two" = "ExampleTwo",
 *     "example_three" = "ExampleThree"
 * })
 * @ORM\Entity()
 * @ORM\InheritanceType("SINGLE_TABLE")
 */
abstract class AbstractFooBar
{
    // ...
}

And then my three entities look like this:
/**
 * @Entity()
 */
class ExampleOne extends AbstractFooBar
{
    // ...
}

Looking through the source code, there appears to be logic to audit these entities.

@MylesKingsnorth01 Thanks for the report, I will look at this asap.

@MylesKingsnorth01 it should work if you add each child entity that extend your abstract entity to the dh_doctrine_audit.yaml configuration file.

As long as I can't reproduce the issue and no feedback is provided, I close this issue.
@MylesKingsnorth01 Feel free to reopen if needed.

Sorry for not getting back to this in a while.
So as you've said, I added all child entities to my configuration. When I update one of the child entities, the audit shows for all children. Is that the intended behaviour? It's a bit misleading.

Hi @MylesKingsnorth01, well it is not the intended behavior and looks like a bug, I re-open the issue and will have a look at it.

@MylesKingsnorth01 I think I misunderstood what you meant: the current behavior is intended.
Single table inheritance in Doctrine means that you use one table (let's call it root table) to store different entities, all sharing the same root. The root table has a column dedicated to identify which entity a record belongs to (discriminator column).
So when you create/modify a child entity, it is stored in the root table with a specific discriminator value.
Also, as a consequence, the bundle handles an audit table for the root table (only) which means that by configuring child entities to be audited, their audit operations (inserts into audits) are done against the audit table of the root table (only).
Currently there is no way to know if an audit record belongs to a child entity or the root one so no way to filter them out in AuditReader::getAudits().
I need to find/decide if and how to manage this.

@MylesKingsnorth01 I've implemented the missing part of the inheritance support. Can you please test master branch?
Note: run the bin/console audit:schema:update command if you already have audit tables.

@DamienHarper Thanks for taking a look. I can confirm that your update works as expected. I tested a couple scenarios and they all worked. Thanks for adding the missing part.


[$2000]  If user is in invalid report, when the #focus mode is turned on, LHN show empty without any placeholder.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login into same account in 2 tabs.
Make sure LHN doesn't have any pinned or unread chats.
From first tab,  go any invalid report route (ie: https://staging.new.expensify.com/r/abcxyz)
From second tab,  turn on the #focus mode. Go back to the first tab.
Notice the the main LHN screen is empty without any placeholder.

Expected Result
If LHN is empty, the only chat showing should be Concierge
Actual Result
There's no placeholder and it shows empty green screen.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/233850871-a13297db-f784-4d5c-85e5-5d70eb5ff087.mp4
https://user-images.githubusercontent.com/43996225/233850878-c2d9c98f-2c59-4fb8-8283-abae59d26ab4.mov
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681373682222539
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01148bfbff2a089abf
Upwork Job ID:<PHONE_NUMBER>462528000
Last Price Increase: 2023-05-25

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal
Please re-state the problem that we are trying to solve in this issue.
If user is in invalid report, when the #focus mode is turned on, LHN show empty without any placeholder.
What is the root cause of that problem?
In #focus mode, we will filter the unread, pinned or current report to display the reports, in case we are in invalid report the filtered report will return empty.
What changes do you think we should make in order to solve the problem?
That will be a little weird if we only show empty screen, in other places like BasePaymentPage, Pronouns Page we will display a friendly message when the page is empty, so we can do it similar here.
So we can add ListEmptyComponent into Flatlist of LHNOptionsList.
ListEmptyComponent can be a friendly text or UI to let user know the page is empty. It can be like this:

What alternative solutions did you explore? (Optional)
None

I need to focus on some other more urgent chores today, I'm going to reassign this one.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Unable to reproduce on Chrome or Safari.  @hungvu193 anything I'm not doing right here?
https://user-images.githubusercontent.com/22508304/234149469-9588cf11-643f-4f1c-91fb-8a45424bc551.mp4

@mallenexpensify just make sure you read all the messages and there's no pinned messages, then do it again
https://user-images.githubusercontent.com/16502320/234160282-b85f468b-f292-427b-9329-375d1eea53cc.mov

ah... in the OP it didn't mention all chats needed to be read.
So.. what you're suggesting as the expected behaviour is that there is always, at least, one chat or a placeholder in LHN at all times, no matter what, is that correct? If it's a placeholder, what is it? Is there an example from another instance? I don't use #focus mode much.

Yeah, that's right, I recommended to show at least the placeholder in stead of just empty screen.
For example when there's no workspace we have a placeholder like this:

I think we can do similar for this case by showing a text or an simple UI, it's something like:
There's no report here, please click plus button and start your conversation.

Thanks @hungvu193 , it's kinda like how we have a placeholder on expensify.com when there aren't any active items that need addressing in your Inbox.

also realizing I didn't originally check your Slack post where I would have seen

don’t have any unread message, to do that you’d better create a new account, read all the message then do the steps I wrote above

I'm going to post in #expensify-open-source tomorrow-ish to get more eyes, it's not a pressing issues and the site was just down so things are a lil hectic now

Haven't had time to prioritize

Unable to reproduce on Safari and Chrome won't load for me :(
https://github.com/Expensify/App/assets/22508304/8ee1f087-9633-4337-9259-f6235000d2ce

Unable to reproduce on Safari and Chrome won't load for me :(
https://github.com/Expensify/App/assets/22508304/8ee1f087-9633-4337-9259-f6235000d2ce

Make sure you don't have pinned or unread message before going to invalid route. You will see the issue :)

oooof, thanks @hungvu193 , def missed that bit.  I was able to reproduce, see below.
@stitesExpensify , do you think this should be a bug or feature request? If bug and it can be External, please add the label.  (then we'll confirm what to show in LHN)
https://github.com/Expensify/App/assets/22508304/c30ee53a-bcf5-4709-8828-7157fbe5932b

Bug IMO

Makes sense, thanks @stitesExpensify , think it can be External??!?!

Bumped price to $2000 to get some 👀 and action, this one took a while to triage :ohnothing:

Updated my proposal:
https://github.com/Expensify/App/issues/17858#issuecomment-1519915673

@mallenexpensify Just to confirm We should show Concierge only when there are no chats to show in LHN (except the regular case when there is unread message in Concierge or Concierge is pinned). We will not show Concierge if there are other chats to show, right?
Context: #focus priority mode

We will not show Concierge if there are other chats to show, right?

@sobitneupane , correct

Thanks for the proposal everyone.

I think we need to update this getOrderedReportIDs function so that it will return Concierge report it's there is no report to be displayed.

Proposal from @hoangzinh looks good to me. All proposal are based on above idea.
🎀👀🎀 C+ reviewed
cc: @stitesExpensify

Makes sense to me! Assigning @hoangzinh

I think I hired @hoangzinh , Upwork is acting up and I was unable to hire @sobitneupane.  Also need to hire @hungvu193 for reporting, will try again tomorrow-ish

Apologies for the delay @hoangzinh , paid $3000 which includes the timeliness bonus.  @hungvu193 and @sobitneupane, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01148bfbff2a089abf
@sobitneupane , can you please complete the BZ checklist above via a comment/post? Thx
https://github.com/Expensify/App/issues/17858#issuecomment-1579470010

@hungvu193 paid, @sobitneupane , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01148bfbff2a089abf

@mallenexpensify Accepted the offer.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ]  [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

getOrderedReportIDs() was added by https://github.com/Expensify/App/pull/19945 PR. But we cannot be sure that it soley introduce the issue. It is 10 months old PR.

[ ]  [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://expensify.slack.com/archives/C049HHMV9SM/p1687535494054049

Regression Test Proposal:

Sign in to NewDot.
Make sure LHN doesn't have any pinned/unread chats/outstanding IOU/draft
Go to Preference page, change Priority mode to "#focus"
Open an invalid report route (Example: "https://staging.new.expensify.com/r/fdsa")
Verify that there is "Concierge chat report" in LHN

Do we agree 👍 or 👎

@sobitneupane paid $3000, Thanks for the test steps!
Regression test GH created.
https://github.com/Expensify/Expensify/issues/295071

@mallenexpensify Looks like you have missed the bonus amount. I received only $2000. Can you please do a quick recheck.

D'oh, sorry about that Sobit, just bonused you $1000


The hotkey funtion isn't working for me on on the "random page" plugin.

I'm not sure why.
I tried some other variations, and I tried simply using the code from the last working version (many months old, I'm slow to update), but nothing has worked yet.
Basically when I hit the relevant keys, nothing seems to happen.
I'm on a mac, OSX Big Sur, using roam in firefox (but it doesn't work in Chrome, either).
Any suggestions?

When I straight up swap out the current version of the function for this old version,
  function addKeyboardShortcut() {     document.onkeyup = function(e) {       var key = e.which || e.keyCode;       if (e.altKey && key === shortcut) {         goToRandomPage(e);       }     }   }
I get this weird behavior where the URL changes, for a split second, before reverting back to the page that I was on. Not sure what's up with that, or if it is related to the hot key not working at all, for me, in the new version.

Thanks for letting me know. I'm definitely seeing the same bug in Linux/Chrome. But it's an odd one: event though the key event is triggering the same code as clicking the button, navigation is only happening with the later. It might be a browser security policy against programmatic navigation..? I'll need to keep digging.

Took a while but I figured it out @Etyre. Issue fixed in 98746cb287a04fb3a5e60788eabfbe5de1ed24b7


ISO C90 forbids mixed declarationsa and code

When scanning code with clang scan-build, I get these:
  380: ../../../subprojects/glfw/src/x11_init.c:228:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  383: ../../../subprojects/glfw/src/x11_init.c:411:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  387: ../../../subprojects/glfw/src/x11_init.c:529:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  390: ../../../subprojects/glfw/src/x11_init.c:558:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  394: ../../../subprojects/glfw/src/x11_init.c:809:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  398: ../../../subprojects/glfw/src/x11_init.c:1049:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  401: ../../../subprojects/glfw/src/x11_init.c:1056:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  414: ../../../subprojects/glfw/src/linux_joystick.c:114:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  418: ../../../subprojects/glfw/src/linux_joystick.c:137:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  421: ../../../subprojects/glfw/src/linux_joystick.c:142:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  424: ../../../subprojects/glfw/src/linux_joystick.c:166:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  427: ../../../subprojects/glfw/src/linux_joystick.c:171:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  430: ../../../subprojects/glfw/src/linux_joystick.c:191:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  433: ../../../subprojects/glfw/src/linux_joystick.c:225:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  437: ../../../subprojects/glfw/src/linux_joystick.c:292:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  440: ../../../subprojects/glfw/src/linux_joystick.c:306:13: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  444: ../../../subprojects/glfw/src/linux_joystick.c:352:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  447: ../../../subprojects/glfw/src/linux_joystick.c:366:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  452: ../../../subprojects/glfw/src/x11_monitor.c:152:13: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  455: ../../../subprojects/glfw/src/x11_monitor.c:174:13: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  459: ../../../subprojects/glfw/src/x11_monitor.c:239:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  462: ../../../subprojects/glfw/src/x11_monitor.c:250:13: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  466: ../../../subprojects/glfw/src/x11_monitor.c:288:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  470: ../../../subprojects/glfw/src/x11_monitor.c:361:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  474: ../../../subprojects/glfw/src/x11_monitor.c:461:13: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  478: ../../../subprojects/glfw/src/x11_monitor.c:571:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  483: ../../../subprojects/glfw/src/x11_window.c:409:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  487: ../../../subprojects/glfw/src/x11_window.c:498:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  491: ../../../subprojects/glfw/src/x11_window.c:624:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  495: ../../../subprojects/glfw/src/x11_window.c:1240:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  498: ../../../subprojects/glfw/src/x11_window.c:1346:17: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  501: ../../../subprojects/glfw/src/x11_window.c:1509:21: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  504: ../../../subprojects/glfw/src/x11_window.c:1542:13: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  507: ../../../subprojects/glfw/src/x11_window.c:1552:17: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  510: ../../../subprojects/glfw/src/x11_window.c:1707:17: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  513: ../../../subprojects/glfw/src/x11_window.c:1837:17: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  517: ../../../subprojects/glfw/src/x11_window.c:1908:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  521: ../../../subprojects/glfw/src/x11_window.c:1982:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  525: ../../../subprojects/glfw/src/x11_window.c:2143:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  529: ../../../subprojects/glfw/src/x11_window.c:2580:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  533: ../../../subprojects/glfw/src/x11_window.c:2900:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  536: ../../../subprojects/glfw/src/x11_window.c:2906:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  539: ../../../subprojects/glfw/src/x11_window.c:2910:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  543: ../../../subprojects/glfw/src/x11_window.c:2965:13: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
  547: ../../../subprojects/glfw/src/x11_window.c:3091:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]

I can make PR if you think this is something that could be merged.

I believe C99 is what's being used for non-windows code:
https://github.com/glfw/glfw/search?q=C99&unscoped_q=C99

The -Wdeclaration-after-statement flag shouldn't be applied to those files. I'm not sure why scan-build thinks it should be.

Unable to reproduce this with scan-build and the X11 port and either Clang 8 or 9.

Still unable to reproduce this and there have been nearly two years of build system work in the meantime. Closing this for now. Please re-open this or post a follow-up if there is more information about how to reproduce this.


Actually staying in istio.io/istio after getting tools repo

@utka: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-upgrade-tests-1.0.2
fa4fcb7c5f27aa21a449f37d4b4cf8375dbe3782
link
/test release-upgrade-tests-1.0.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-upgrade-tests-1.0.2
fa4fcb7c5f27aa21a449f37d4b4cf8375dbe3782
link
/test release-upgrade-tests-1.0.2

prow/release-upgrade-tests-1.0.1
fa4fcb7c5f27aa21a449f37d4b4cf8375dbe3782
link
/test release-upgrade-tests-1.0.1

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utka: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-upgrade-tests-1.0.1
fa4fcb7c5f27aa21a449f37d4b4cf8375dbe3782
link
/test release-upgrade-tests-1.0.1

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[feature][connector-v2] add Postgres CDC

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

这么好的内容，为什么关闭了呢


feat: use OIDC ID token for Azure

Use the OIDC ID token instead of the UserInfo endpoint, as there are serious discrepancies between what is returned.

@hf -- I've started getting the following error for Azure users logging in:
azure: ID token issuer \"https://login.microsoftonline.com/TENANT-UUID/v2.0\" does not match expected issuer \"https://login.microsoftonline.com/organizations/v2.0\"","level":"error","method":"GET","msg":"500: Error getting user email from external provider"

Is this related to this PR? The errors began at the following timestamp: 2023-10-17T08:59:15.000Z


Added Pattern Creation Game

Issue #4694
Added Pattern Creation Game
@ishita-43 please have a look, i have followed all the contributing rules. Have a check and add gssoc and level label.
thank you
https://github.com/kunjgit/GameZone/assets/145869907/7bf392dc-101e-4e15-a3db-73be00b6e9c2

Thank you @ananyag309 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

/assign

@ishita-43 ma'am please check I have made necessary changes.

@ishita-43 @kunjgit sorry for disturbing again. it's been a week. please have a check & please letme know if any further changes need to be made.

Thank you  @ananyag309 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Mod items dont have correct name after datagen

instead of saying block of garnet it says block_tutorial_mod_block etc
also ModTags arent working

Did you make a lang for the garnet block?


docs: Update instructions for caching with Docker

In this PR:

As Docker build arguments are persisted in the final image, recommend using Docker secret for the TURBO_TOKEN in docs when using remote cache for building other images.

Issues reference:

[https://github.com/ducktors/turborepo-remote-cache/issues/
https://github.com/ducktors/turborepo-remote-cache/issues/](https://github.com/ducktors/turborepo-remote-cache/issues/418)

PS

I have not yet tested the exact commands, but I am using Turborepo Remote Cache with Docker secrets.

@all-contributors add @hsellik on docs


Proposal/Request: World.NextPositionOnStreet

GTA IV's .NET ScriptHook had this. It was extremely useful for spawning things such as vehicles on random locations on streets. Basically, you specified a Vector3, and it got the closest road position to it. It was extremely useful.

Already here.
13 июня 2015 г. 22:16 пользователь Stray<EMAIL_ADDRESS>написал:

GTA IV's .NET ScriptHook had this. It was extremely useful for spawning things such as vehicles on random locations on streets. Basically, you specified a Vector3, and it got the closest road position to it. It was extremely useful.
—
Reply to this email directly or view it on GitHub.

For vehicle PlaceOnNextStreet

Something like Vehicle::PlaceOnNextStreet?

As @IncoCode stated, there is a method within the Vehicle namespace which does this, but I agree that it would be very useful to add that to the Vector3 class as well. I would personally like to use this on Peds and other objects,

How about to move PlaceOnNextStreet method to Entity class? Then it can be used in Vehicle, Ped and Prop.

That is also something I have considered suggesting.

Or, in Vector3. Vector3.GetNextPositionOnStreet(Vector3 pos), returns the closest street position. Then you can use the vector3 it returns for anything.

This function would make more sense to be in the World class.

I agree with Sergeeeek.


Server urls with variables aren't supported

If one has openapiv3 with server urls:
  - url: https://app-pr-{prId}.herokuapp.com/api/v1
     description: Staging
     variables:
        prId:
           default: '1'

Then using https://app-pr-56.herokuapp.com/api/v1 will result into
InvalidServer('Invalid request server https://app-pr-56.herokuapp.com/api/v1/user/login',).
Workaround for now is just to skip domain with url: /api/v1.

In my opinion this is a bug, not an enhancement. The specification defines the variables property for the server object (https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#server-object)
Our validation currently fails due to this and we would really appreciate some help / support.


Meta: synthesize the intro screen, court selector, etc. for all forms

We want to make sure there is a consistent look and feel for all of the interviews.

This is really done already--the main issue before was that the branding wasn't the same for each interview. Each interview now uses the stock intro screen.


Fix domainList race condition

Frankly, these codes are full of race conditions everywhere. I don't actively maintain them. I only preserve them just in case.

yeah those race conditions are rough :( smh


Set default model for mpas_to_yaml to mpas-ocean

Checklist

[x] Testing comment in the PR documents testing used to verify the changes

Testing
I was able to convert the following namelist file:
https://github.com/MPAS-Dev/compass/blob/main/compass/ocean/tests/isomip_plus/namelist.forward_and_ssh_adjust
to the following yaml file:
mpas-ocean:
  run_modes:
    config_ocean_run_mode: forward
  time_integration:
    config_dt: 00:04:00
    config_time_integrator: split_explicit_ab2
  split_explicit_ts:
    config_btr_dt: 00:00:10
  time_management:
    config_run_duration: 0000-01-00_00:00:00
  io:
    config_write_output_on_startup: false
  decomposition:
    config_block_decomp_file_prefix: graph.info.part.
  hmix_del2:
    config_use_mom_del2: true
    config_use_tracer_del2: true
    config_mom_del2: 6.0
    config_tracer_del2: 1.0
  cvmix:
    config_cvmix_background_diffusion: 5e-05
    config_cvmix_background_viscosity: 0.001
    config_use_cvmix_convection: true
    config_cvmix_convective_diffusion: 0.1
    config_cvmix_convective_viscosity: 0.1
    config_use_cvmix_shear: false
    config_cvmix_use_BLD_smoothing: false
  land_ice_fluxes:
    config_land_ice_flux_attenuation_coefficient: 10.0
    config_land_ice_flux_boundaryLayerThickness: 10.0
    config_land_ice_flux_explicit_topDragCoeff: 0.0025
    config_land_ice_flux_tidal_Jourdain_U0: 0.01
    config_land_ice_flux_jenkins_heat_transfer_coefficient: 0.0194
    config_land_ice_flux_jenkins_salt_transfer_coefficient: 0.00055428571
  bottom_drag:
    config_implicit_constant_bottom_drag_coeff: 0.0025
  eos:
    config_eos_type: linear
  eos_linear:
    config_eos_linear_alpha: 0.03836
    config_eos_linear_beta: 0.8059
    config_eos_linear_Tref: -1.0
    config_eos_linear_Sref: 34.2
    config_eos_linear_densityref: 1027.51
  pressure_gradient:
    config_pressure_gradient_type: pressure_and_zmid
  debug:
    config_check_ssh_consistency: false
  AM_timeSeriesStatsMonthly:
    config_AM_timeSeriesStatsMonthly_restart_stream: none

with a version of MPAS-Ocean built with the latest E3SM master (updated in the submodule in https://github.com/E3SM-Project/polaris/pull/228)

@hyungyukang, do you have time to give this a quick look?  The changes are small but I know you've used this tool relatively recently.

Thanks @hyungyukang!


Edited "Resolution" section

Added a link to the documentation page for the "dx" debugger command.

Thanks for the PR!

Thanks for the PR!

Thank you @tedhudek.


[add-resource] New Plugin/Theme

I would like to add a new theme to the Grav Repository. Here are the project details: https://github.com/hibbitts-design/grav-theme-quark-open-publishing
This inherited theme is a customized version of Quark (called Quark Open Publishing) with additional setup guidance and support for the Git Sync plugin along with a 'chromeless' mode for embedding Grav pages into other systems. It will also install the Admin Panel and the Git Sync plugin.
Thanks very much,
Paul

Thanks Andy, cheers!


no events to track transitions when using carousel-fade

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
This is somewhere between a bug and a feature request, but I think it's missing a basic use case, so I'm calling it a bug.
When I use carousel-fade, I no longer receive slide.bs.carousel and slid.bs.carousel events. That's a problem because I want to add some effects to the text as each new slide is shown. I understand that the slide didn't actually slide, so I don't know if it's better to use those event names as-is, or create new events fade.bs.carousel and faded.bs.carousel.
Reduced test cases
Create a carousel with a div header like:
<div id="MainPageCarousel" class="carousel slide carousel-fade" data-bs-ride="carousel" data-bs-pause="false">
Add JavaScript:
	document.getElementById( "MainPageCarousel" ).addEventListener( "slide.bs.carousel", HandleCarouselSlide );
	document.getElementById( "MainPageCarousel" ).addEventListener( "slid.bs.carousel", HandleCarouselSlid );

and
function HandleCarouselSlide()
{
	console.log( "slide" );
}

function HandleCarouselSlid()
{
	console.log( "slid" );
}

When the page loads, those event handlers are never called as the carousel transitions from one slide to another.
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
5.1.0

@michaeladamkatz please try to provide a 'working' demo to help us debug there


demo code for I2C slave?

Do you have demo code or a snippet for using I2C slave mode ?

I wrote one according to the i2c example in stc8h user manual, but I hadn't test it yet.
Let me know if there are anything wrong.

@IOsetting Thanks for the quick response. Will try it on the hardware and let you know.


Implement minimap button with LibDBIcon

I reported an issue if LFG Bulletin Board in Sexymap where it would not be hidden until mouseover like other addon buttons. I got the reply that the minimap button needs to be implemented using LibDBIcon to play nice with other addons.

We dont have "full" LibDBIcon support but with #302 , you should be able to take advantage of LibDBIcon if you have any other addon that does use it (sexymaps likely bundles it) then you should be able to take advantage of it.