Fix: preferredSkinTone type warning

Details

The preferredSkinTone is supposed to be Number but sometimes it's passed as String since default was its legacy default value (becomes -1 now). This PR fixes that.
Fixed Issues

$ https://github.com/Expensify/App/issues/18541
PROPOSAL: https://github.com/Expensify/App/issues/18541#issuecomment-1543832625
Tests

Login with any account
Go to any chat
Type in semicolon with emoji prefix (i.e. :sm)
Verify that the error Invalid prop preferredSkinToneIndex of type string supplied to EmojiSuggestions, expected number does not appear in the JS console

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Login with any account
Go to any chat
Type in semicolon with emoji prefix (i.e. :sm)
Verify that the error Invalid prop preferredSkinToneIndex of type string supplied to EmojiSuggestions, expected number does not appear in the JS console

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screencast from 12-05-2023 01:42:18.webm

Mobile Web - Chrome

Screencast from 12-05-2023 01:53:16.webm
https://github.com/Expensify/App/assets/113963320/a32eefaa-9363-4b9a-a241-8c3b0f380481

Mobile Web - Safari

https://github.com/Expensify/App/assets/113963320/6dc02ee6-0f90-4827-bffc-8ef66da9b914

Desktop

https://github.com/Expensify/App/assets/113963320/8a338dcd-75ac-4134-bfcf-769bbc5ca08f

iOS

https://github.com/Expensify/App/assets/113963320/8f57c512-850c-434d-accf-dbe280f42cf7

Android

untitled.webm

While working on this PR, I found out that if the new getPreferredSkinToneIndex function was put in EmojiUtils then using it in Report.js would cause import cycle: Report > EmojiUtils > User > Report. Thus, I decided to move this line out of EmojiUtils:
https://github.com/tienifr/App/blob/057417c49ce8f9d2834d2dcab6546523a277cbe6/src/libs/EmojiUtils.js#L191
due to:

Prone to causing import cycle
Calling API function within an utility file is weird

Then it would be used like this:
https://github.com/tienifr/App/blob/66f7c0ab8c64749b8d2e6a3ec2f7fe6357b38086/src/pages/home/report/ReportActionCompose.js#L610-L611

There are some unit tests failing!

Comments're resolved and tests're fixed!

@mollfpr Waiting on the checklist to do a final review from my side 😄

Sorry I’ll finish it tonight!

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/25520267/da216af8-17fb-4f29-b19a-87a1397e2ec1

Mobile Web - Chrome

https://github.com/Expensify/App/assets/25520267/40d8fbe1-da64-4e9f-8ade-fb0ce75af9bb

Mobile Web - Safari

https://github.com/Expensify/App/assets/25520267/35bb04dc-995b-435b-ab7b-0c7027e60836

Desktop

https://github.com/Expensify/App/assets/25520267/cf66cc81-d613-44e3-8342-9655e7c95518

iOS

https://github.com/Expensify/App/assets/25520267/6525ec45-5157-443d-b0e9-14b6cbee127d

Android

https://github.com/Expensify/App/assets/25520267/8c53968a-1d80-419e-a82f-728da27ec2be

@tienifr Linter is complaining since you need to run npm run prettier!

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.15-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.15-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


vault set pin error (Mac Intel)

Hi,
I'm getting this error when i run goldwarden vault pin set on my mac (intel):
Pin updating failed: GETPIN response didn't start with D; got "S ERROR curses.isatty 83918950 "

Fixed in #228

Please try again on v0.3.3 (with pinentry-mac installed)


Add interpreter module to third party list

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix init-ing bug

All state variables are now being initialized correctly.

Since you've create a new pull request for this, I'm closing this one.


Update player.js

Added check for 'x-sonosapi-hls' for SiriusXM.  Without this change the display information on the Sonos controller apps does not display correctly and instead displays garbage metadata.

Thanks, will incorporate this into the beta version as well.


translated getting-started.md

translated getting-started.md

translated folder-structure.md, fixed a word
translated advanced.md


fix: wait for DOMContentLoad when requesting Realm

Not sure it this is the correct fix.
What happens is that whenever we get a context that was not created by us:
window.open or <a target=_blank> we don't wait for the context to be fully loaded and emit while it's on the about:blank page transition.
The other option would be to wait for the DomContentLoad whenever we emit the event  via registerPromiseEvent.
Also open to suggestions.
Current situation:
targetCreated (contextCreated) event, then we get executionContextCreated for the inital about:blank, Puppeteer makes a script.evaluate here, then exectionContextsCleared,  evalute fails here, executionContextCreated for navigated page.

We decided to wait for the event on the Puppeteer side.


Update qutip to 5.0.0

This updates the qutip recipe to build qutip 5.0.0.
In addition to updating the version number and the package hash, it also updates the tests.

Failed with:
FAILED test_qutip.py::test_qobj_create - ModuleNotFoundError: No module named 'setuptools'

This is really odd. Qutip does not import anything from setuptools in the source https://github.com/qutip/qutip/blob/master/qutip/core/init.py

@martinRenou Thank you for taking a look. setuptools is imported via qutip/core/coefficient.py which is imported in qutip/core/__init__.pu. Setuptools was intended to be an optional dependency though, so 5.0.1 has been released to fix that.

Yay, tests are passing. Ready for review.

Closes #849

Thank you!


Adaptive Cards on C#

Adaptive Cards with C # How to build, Adaptive Cards created button directline can be used?
                                                                                Thank   you so  much

Hi @zxy66481,
I would start taking a look at the sample in our repo:
https://github.com/Microsoft/BotBuilder-Samples/tree/master/CSharp/cards-AdaptiveCards
It contains a step by step tutorial in the readme file.
Regards,
Francisco


asterisk syntax doesn't allow spaces between equal in context options

[tcp]
        type = transport

spaces are allowed here
https://wiki.asterisk.org/wiki/display/AST/Asterisk+Main+Configuration+File

closing as the referenced PR has been fixed.

it has not been fixed in #7060


fix(input): fixing Firefox placeholder color

fixes #1310
Firefox applies a .4 opacity to input placeholders - this will just normalize the placeholders to 1.0 opacity.

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


Fix buildVersion script to calculate the latest tag

Merge #10372 from main to next.

Closing to re-open with a different HEAD.


Camera QoL Updates + Minor Bug Fix

Added visible point of rotation for the Camera tilt
Added switch, Camera.pivotOnCenter, to alter tilt behaviour

TRUE[default]: Behaviour the typical, expected behaviour.
Rotate origin is screen space center ray cast to globe
FALSE: Rotate origin is mouse point of tilt operation start

[3D Only] When zooming out, with the camera not facing globe center point,
the camera will slowly rotate itself to be face the globe center point

This also fixes a bug in the camera.
When zooming out with mouse point off the globe the globe can move out of view entirely

Thank you so much for the pull request @sololegends! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!
The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

:x: Missing CONTRIBUTORS.md entry.

Please add yourself to the contributors file!

:x: Missing CLA.

Please send in a Contributor License Agreement (CLA) and comment back here to let us know to check this!
Maintainers, here's how to check for a submitted CLA.

:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Sent CLA, updated CONTRIBUTORS.md and CHANGES.md as bot requested

Thanks for the PR @sololegends! I'll take a look at this some this week.

Thanks again for your contribution @sololegends!
No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@sololegends We're trying to be more responsive to PRs and keep our PR backlog tidy. Due to inactivity, I'm going to close this PR. But please feel free to re-open when you get the chance to work on this! Thanks for your patience.


compile problem on Ubuntu

ex share:
I have installed ubuntu 18 on vmware, and then I try to compile openfast on ubuntu, but when the compilation went to 96%, the gfortran compiler broken,the error message like blow:
 [ 96%]  Building Fortran object modules-local/openfastlibrary/CMakeFiles/openfast_postlib.dir/src/FAST_Subs.f90.o
f951: out of memory allocating 65536 bytes after a total of 491261952 bytes gfortran-6: internal compiler error: Killed (program f951)
Please submit a full bug report,with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-6/README.Bugs> for instructions.
modules-local/openfast-library/CMakeFiles/openfast_postlib.dir/build.make:110: recipe for target 'modules-local/openfast-library/CMakeFiles/openfast_postlib.dir/src/FAST_Subs.f90.o' failed
make[2]: *** [modules-local/openfast-library/CMakeFiles/openfast_postlib.dir/src/FAST_Subs.f90.o] Error 4
CMakeFiles/Makefile2:1410: recipe for target 'modules-local/openfast-library/CMakeFiles/openfast_postlib.dir/all' failed
make[1]: *** [modules-local/openfast-library/CMakeFiles/openfast_postlib.dir/all] Error 2 Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2
so is there somebody had the same quesition with me? and how you resovle it?

@smilke could you try compiling with gcc 7? I've compiled on a virtual machine running Ubuntu 14.04 with 2GB of memory without problem. And it looks like gcc 7 is directly available in apt on Ubuntu Bionic (18).

Ok great to hear that it worked. It sounds like earlier versions of gfortran don't work well CMAKE_Fortran_COMPILER_VERSION so that is the issue to fix here.

closed by #173


How to send VCard to chat?

How to send VCard to chat?

Please delete the issue template as well as follow the prompted issue guidelines, especially:

Follow the Stackoverflow Guidelines (https://stackoverflow.com/help/how-to-ask) when in need of help

#312
Thanks!


use common algorithms for filter creation

add more testing
keep children blueprints in unique pointers
@geirst please review

@arnej27959 FYI


Update to 3 in STEP and README.md

I have created a branch, created a file and made a commit.

I have a new platform!


How can I apply the motor model?

Thank you for your excellent paper!
From the paper, I understand that the model should be used from "femr/tutorials/reference/2_apply_motor_model", but I was not able to find this file. Could you please advise on how I should use the model?

@clzhang123 thanks for the interest! We'll be uploading the model within a month or so to Huggingface (as well as updated tutorials). The link will be in the camera ready version of the paper and I'll also post here when it is ready.


fman: Add version 1.7.0

If you want to add it into official extras bucket, reach to author and ask for portable installation

https://github.com/TheRandomLabs/scoop-nonportable/pull/103


Can't open browsers installed in user's Application directory on OSX

I see in the launcher files for Chrome and Firefox there are some lookups for both Windows and Linux to get the correct browser. However, with OSX, it's always being hardcoded to /Applications.
While I know this can be worked around by setting the CHROME_BIN and FIREFOX_BIN to the users Application directory, I think it's a common enough scenario that I imagine the launchers should at least attempt to see if it exists in ~/Applications first.
(As a side note, the files seem a little inconsistent in how they're looking up the different browsers, Opera doesn't appear to try to look up for any of the systems).
Is this something you guys would think about fixing? (Also not sure if this is the right place, or if I should file separate issues on each launcher repo?)

Hey, thanks for the report, but can you please repost it here: https://github.com/karma-runner/karma-chrome-launcher/issues. There were also some discussions around path issues on there, if I remember correct.


Upgrade examples and templates to 0.5

Upgrade the examples and templates to use react-server 0.5 and react 15

Hmm... we should actually be able to have Asini keep React Server deps up-to-date for us now that it supports configurable package locations. :thinking:

Thanks @doug-wade!


Bitcode is not included in built .ipa file, even with include_bitcode: true

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Hi all, I am using gym for building and exporting the IPA of our app. Our app consists of main app, widget, photo extension and  watchapp. Everything works correctly, but when I am uploading the IPA to the iTunes Connect through deliver or application loader, I am getting an email from iTunes Connect containing this: Invalid Executable - The executable '****.app/Watch/WatchKitApp.app/PlugIns/WatchKitApp Extension.appex/WatchKitApp Extension' does not contain bitcode.
I have set the ENABLE_BITCODE = YES; build settings for watchapp and also watchkitextension. I am using include_bitcode: true option for gym command. Do you have any idea, what can be wrong? I also tried adding -fembed-bitcode into the OTHER_CFLAGS part of build configuration of watchapp and also watchkit extension.
Weird thing is, that regarding the watchapp Apple has no issues, but the watchkitextension is the problem for them.
Complete output when running fastlane, including the stack trace and command used

You can use: --capture_output as the last commandline argument to get that collected for you

Captured Output
Command Used: appstore region:ausnz branch:********
Output/Log

DEBUG [2017-04-03 12:54:52.24]: Checking if there are any plugins that should be loaded...
DEBUG [2017-04-03 12:54:52.26]: Using region: ********
DEBUG [2017-04-03 12:54:52.26]: Using branch: ********
ERROR [2017-04-03 12:54:52.27]: Name of the lane 'appstore' is already taken by the action named 'appstore'
INFO [2017-04-03 12:54:52.27]: Driving the lane 'appstore' 🚀
INFO [2017-04-03 12:54:53.82]: ----------------------------------
INFO [2017-04-03 12:54:53.82]: --- Step: Switch to build lane ---
INFO [2017-04-03 12:54:53.82]: ----------------------------------
INFO [2017-04-03 12:54:53.83]: Cruising over to lane 'build' 🚖
INFO [2017-04-03 12:54:58.69]: -----------------
INFO [2017-04-03 12:54:58.70]: --- Step: gym ---
INFO [2017-04-03 12:54:58.70]: -----------------
INFO [2017-04-03 12:54:58.84]: $ xcodebuild -list -project Main/Sources/Application/Projects/iOS/********.xcodeproj -configuration Default
INFO [2017-04-03 12:55:01.10]: $ xcodebuild clean -showBuildSettings -scheme ******** -project Main/Sources/Application/Projects/iOS/********.xcodeproj -configuration Default

+----------------------+-------------------------------------------------------------------------+
|                                     Summary for gym 2.24.0                                     |
+----------------------+-------------------------------------------------------------------------+
| export_method        | app-store                                                               |
| include_bitcode      | true                                                                    |
| project              | Main/Sources/Application/Projects/iOS/********.xcodeproj                |
| scheme               | ********                                                                |
| configuration        | Default                                                                 |
| xcconfig             | Main/Sources/iOS/Application/Config/ausnz/ausnz_appstore.xcconfig       |
| output_directory     | Build/                                                                  |
| output_name          | ********                                                                |
| destination          | generic/platform=iOS                                                    |
| clean                | false                                                                   |
| silent               | false                                                                   |
| use_legacy_build_api | false                                                                   |
| buildlog_path        | ~/Library/Logs/gym                                                      |
| xcode_path           | /Applications/Xcode8.2.1.app                                            |
+----------------------+-------------------------------------------------------------------------+

+----------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------+
|                                                                                Generated Build Command                                                                                |
+----------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------+
| Option                                                                                | Value                                                                   |
+----------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------+
| set -o pipefail &&                                                                                |                                                                         |
| xcodebuild                                                                                |                                                                         |
| -scheme ********                                                                                |                                                                         |
| -project Main/Sources/Application/Projects/iOS/********.xcodeproj                                                                                |                                                                         |
| -configuration Default                                                                                |                                                                         |
| -destination                                                                                | generic/platform=iOS                                                    |
| -xcconfig                                                                                | Main/Sources/iOS/Application/Config/ausnz/ausnz_appstore.xcconfig |
| -archivePath /Users/sluptak/Library/Developer/Xcode/Archives/2017-04-03/********.xcarchive |                                                                         |
| archive                                                                                |                                                                         |
| | tee /Users/sluptak/Library/Logs/gym/****************.log                                                                                |                                                                         |
| | xcpretty                                                                                |                                                                         |
+----------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------+
INFO [2017-04-03 12:55:03.35]: $ set -o pipefail && xcodebuild -scheme ******** -project Main/Sources/Application/Projects/iOS/********.xcodeproj -configuration Default -destination 'generic/platform=iOS' -xcconfig 'Main/Sources/iOS/Application/Config/ausnz/ausnz_appstore.xcconfig' -archivePath /Users/sluptak/Library/Developer/Xcode/Archives/2017-04-03/********.xcarchive archive | tee /Users/sluptak/Library/Logs/gym/********.log | xcpretty

...
...
...

WARN [2017-04-03 13:10:04.90]: Generated plist file with the following values:
INFO [2017-04-03 13:10:04.90]: ▸ -----------------------------------------
INFO [2017-04-03 13:10:04.90]: ▸ {
INFO [2017-04-03 13:10:04.90]: ▸   "method": "app-store",
INFO [2017-04-03 13:10:04.90]: ▸   "uploadSymbols": true,
INFO [2017-04-03 13:10:04.90]: ▸   "uploadBitcode": true
INFO [2017-04-03 13:10:04.90]: ▸ }
INFO [2017-04-03 13:10:04.90]: ▸ -----------------------------------------
INFO [2017-04-03 13:10:04.90]: This results in the following plist file:
INFO [2017-04-03 13:10:04.90]: ▸ -----------------------------------------
INFO [2017-04-03 13:10:04.90]: ▸ <?xml version="1.0" encoding="UTF-8"?>
INFO [2017-04-03 13:10:04.90]: ▸ <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
INFO [2017-04-03 13:10:04.90]: ▸ <plist version="1.0">
INFO [2017-04-03 13:10:04.90]: ▸ <dict>
INFO [2017-04-03 13:10:04.90]: ▸ 	<key>method</key>
INFO [2017-04-03 13:10:04.90]: ▸ 	<string>app-store</string>
INFO [2017-04-03 13:10:04.90]: ▸ 	<key>uploadBitcode</key>
INFO [2017-04-03 13:10:04.90]: ▸ 	<true/>
INFO [2017-04-03 13:10:04.90]: ▸ 	<key>uploadSymbols</key>
INFO [2017-04-03 13:10:04.90]: ▸ 	<true/>
INFO [2017-04-03 13:10:04.90]: ▸ </dict>
INFO [2017-04-03 13:10:04.90]: ▸ </plist>
INFO [2017-04-03 13:10:04.90]: ▸ -----------------------------------------
+----------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+
|                                                                                Generated Package Command                                                                                |
+----------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+
| Option                                                                                | Value                                                                                |
+----------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+
| /usr/bin/xcrun /Users/sluptak/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/fastlane-2.24.0/gym/lib/assets/wrap_xcodebuild/xcbuild-safe.sh -exportArchive     |                                                                                |
| -exportOptionsPlist                                                                                | /var/folders/r4/dknncvn52f75ck_kzq5801180000gn/T/gym_config20170403-62905-18pi385.plist |
| -archivePath /Users/sluptak/Library/Developer/Xcode/Archives/2017-04-03/********.xcarchive |                                                                                |
| -exportPath                                                                                | /var/folders/r4/dknncvn52f75ck_kzq5801180000gn/T/gym_output20170403-62905-1etz8a2       |
+----------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+
INFO [2017-04-03 13:10:04.91]: $ /usr/bin/xcrun /Users/sluptak/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/fastlane-2.24.0/gym/lib/assets/wrap_xcodebuild/xcbuild-safe.sh -exportArchive -exportOptionsPlist '/var/folders/r4/dknncvn52f75ck_kzq5801180000gn/T/gym_config20170403-62905-18pi385.plist' -archivePath /Users/sluptak/Library/Developer/Xcode/Archives/2017-04-03/********_ausnz_app-store_2017-04-03-1254_<IP_ADDRESS>528\ 2017-04-03\ 12.55.03.xcarchive -exportPath '/var/folders/r4/dknncvn52f75ck_kzq5801180000gn/T/gym_output20170403-62905-1etz8a2'
INFO [2017-04-03 13:10:04.94]: ▸ rbenv detected, removing env variables
INFO [2017-04-03 13:10:04.95]: ▸ rbenv: no such command `shell'
INFO [2017-04-03 13:10:04.95]: ▸ + xcodebuild -exportArchive -exportOptionsPlist /var/folders/r4/dknncvn52f75ck_kzq5801180000gn/T/gym_config20170403-62905-18pi385.plist -archivePath '/Users/sluptak/Library/Developer/Xcode/Archives/2017-04-03/********_ausnz_app-store_2017-04-03-1254_<IP_ADDRESS>528 2017-04-03 12.55.03.xcarchive' -exportPath /var/folders/r4/dknncvn52f75ck_kzq5801180000gn/T/gym_output20170403-62905-1etz8a2
INFO [2017-04-03 13:10:05.59]: ▸ 2017-04-03 13:10:05.592 xcodebuild[75674:1458501] [MT] IDEDistribution: -[IDEDistributionLogging _createLoggingBundleAtPath:]: Created bundle at path '/var/folders/r4/dknncvn52f75ck_kzq5801180000gn/T/********_2017-04-03_13-10-05.590.xcdistributionlogs'.
INFO [2017-04-03 13:10:07.03]: ▸ 1.2.840.1136<IP_ADDRESS>
INFO [2017-04-03 13:10:28.58]: ▸ Exported ********_ausnz_app-store_2017-04-03-1254_<IP_ADDRESS>528 2017-04-03 12.55.03.xcarchive to: /var/folders/r4/dknncvn52f75ck_kzq5801180000gn/T/gym_output20170403-62905-1etz8a2
INFO [2017-04-03 13:10:28.59]: ▸ ** EXPORT SUCCEEDED **
INFO [2017-04-03 13:10:28.69]: Compressing 5 dSYM(s)
INFO [2017-04-03 13:10:28.69]: $ cd '/Users/sluptak/Library/Developer/Xcode/Archives/2017-04-03/********_ausnz_app-store_2017-04-03-1254_<IP_ADDRESS>528 2017-04-03 12.55.03.xcarchive/dSYMs' && zip -r '/Users/sluptak/Dev/2/Build/********_ausnz_app-store_2017-04-03-1254_<IP_ADDRESS>528.app.dSYM.zip' *.dSYM
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********.app.dSYM/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********.app.dSYM/Contents/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********.app.dSYM/Contents/Info.plist (deflated 52%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********.app.dSYM/Contents/Resources/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********.app.dSYM/Contents/Resources/DWARF/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********.app.dSYM/Contents/Resources/DWARF/******** (deflated 74%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********Photo.appex.dSYM/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********Photo.appex.dSYM/Contents/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********Photo.appex.dSYM/Contents/Info.plist (deflated 51%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********Photo.appex.dSYM/Contents/Resources/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********Photo.appex.dSYM/Contents/Resources/DWARF/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********Photo.appex.dSYM/Contents/Resources/DWARF/********Photo (deflated 62%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********Widget.appex.dSYM/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********Widget.appex.dSYM/Contents/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********Widget.appex.dSYM/Contents/Info.plist (deflated 51%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********Widget.appex.dSYM/Contents/Resources/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********Widget.appex.dSYM/Contents/Resources/DWARF/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: ********Widget.appex.dSYM/Contents/Resources/DWARF/********Widget (deflated 65%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: WatchKitApp Extension.appex.dSYM/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: WatchKitApp Extension.appex.dSYM/Contents/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: WatchKitApp Extension.appex.dSYM/Contents/Info.plist (deflated 51%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: WatchKitApp Extension.appex.dSYM/Contents/Resources/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: WatchKitApp Extension.appex.dSYM/Contents/Resources/DWARF/ (stored 0%)
INFO [2017-04-03 13:10:31.27]: ▸   adding: WatchKitApp Extension.appex.dSYM/Contents/Resources/DWARF/WatchKitApp Extension (deflated 61%)

INFO [2017-04-03 13:10:31.27]: Successfully exported and compressed dSYM file
INFO [2017-04-03 13:10:31.28]: Successfully exported and signed the ipa file:
INFO [2017-04-03 13:10:31.28]: ********.ipa
INFO [2017-04-03 13:10:31.28]: Cruising back to lane 'appstore' 🚘
INFO [2017-04-03 13:10:31.28]: Successfully generated documentation at path '/Users/sluptak/Dev/****/fastlane/README.md'

+------+---------------------------------------------------------------+-------------+
|                                  fastlane summary                                  |
+------+---------------------------------------------------------------+-------------+
| Step | Action                                                        | Time (in s) |
+------+---------------------------------------------------------------+-------------+
| 1    | Switch to build lane                                          | 0           |
| 5    | gym                                                           | 932         |
+------+---------------------------------------------------------------+-------------+

INFO [2017-04-03 13:10:31.32]: fastlane.tools just saved you 16 minutes! 🎉

🚫 fastlane environment 🚫
Stack

Key
Value

OS
10.12.4

Ruby
2.3.3

Bundler?
false

Git
git version 2.6.3

Installation Source
~/.rbenv/versions/2.3.3/bin/fastlane

Host
Mac OS X 10.12.4 (16E195)

Ruby Lib Dir
~/.rbenv/versions/2.3.3/lib

OpenSSL Version
OpenSSL 1.0.2j  26 Sep 2016

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode8.2.1.app/Contents/Developer/

Xcode Version
8.2.1

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
`./fastlane/Fastfile`
desc "Builds appstore version for AppStore submission"
desc "Provide 'region' parameter"
lane :appstore do |options|
  options.merge!(flavour: 'app-store')

  build(options)
end

private_lane :build do |options|
  gym(export_method: options[:flavour],
      include_bitcode: true,
      project: "Main/Sources/Application/Projects/iOS/********.xcodeproj",
      scheme: '********',
      configuration: 'Default',
      xcconfig: xcconfig_file_path,
      output_directory: "Build/",
      output_name: '*********')
end

No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.24.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.0.0

slack-notifier
1.5.1

CFPropertyList
2.3.4

claide
1.0.1

colored
1.2

nanaimo
0.2.3

xcodeproj
1.4.2

rouge
1.11.1

xcpretty
0.2.4

terminal-notifier
1.7.1

unicode-display_width
1.1.3

terminal-table
1.7.3

plist
3.2.0

public_suffix
2.0.5

addressable
2.5.0

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.5.0

babosa
1.0.2

highline
1.7.8

commander-fastlane
4.4.4

excon
0.54.0

faraday
0.11.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20161129

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.0.1

gh_inspector
1.0.3

uber
0.0.15

representable
2.3.0

retriable
2.1.0

mime-types-data
3.2016.0521

mime-types
3.1

hurley
0.2

little-plugger
1.1.4

multi_json
1.12.1

logging
2.1.0

jwt
1.5.6

memoist
0.15.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
2.8.3

google-api-client
0.9.24

json
1.8.3

mini_magick
4.5.1

multi_xml
0.6.0

rubyzip
1.2.0

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.1.2

bundler
1.14.3

faraday_middleware
<IP_ADDRESS>

i18n
0.7.0

thread_safe
0.3.5

tzinfo
1.2.2

activesupport
<IP_ADDRESS>

io-console
0.4.5

generated on: 2017-04-03

I also tried otool -l <PATH_TO_MY_BINARY_IN_THE_IPA> | grep bitcode and otool -l <PATH_TO_MY_BINARY_IN_THE_IPA> | grep __LLVM with zero results.

Hey @EskiMag, if you archive and export your IPA from Xcode itself, does Apple still ping you with the issue? Thanks! 🐙

Sorry, I forgot to mention this. Of course I tried to archive & export it from Xcode. This way it works properly. Do you have some idea?

Not sure right off the bat, but I'm curious, does running these two commands and then uploading the result work for you?
xcodebuild -scheme ******** -project Main/Sources/Application/Projects/iOS/********.xcodeproj -configuration Default -destination 'generic/platform=iOS' -xcconfig 'Main/Sources/iOS/Application/Config/ausnz/ausnz_appstore.xcconfig' -archivePath /Users/sluptak/Library/Developer/Xcode/Archives/2017-04-03/********.xcarchive archive | tee /Users/sluptak/Library/Logs/gym/********.log

xcodebuild -exportArchive -exportOptionsPlist /var/folders/r4/dknncvn52f75ck_kzq5801180000gn/T/gym_config20170403-62905-18pi385.plist -archivePath '/Users/sluptak/Library/Developer/Xcode/Archives/2017-04-03/********_ausnz_app-store_2017-04-03-1254_<IP_ADDRESS>528 2017-04-03 12.55.03.xcarchive' -exportPath /var/folders/r4/dknncvn52f75ck_kzq5801180000gn/T/gym_output20170403-62905-1etz8a2```

@ohayon OK, so I tried to do it with those plain xcodebuild and I received email from iTunes Connect, that my WatchKitExtension does not contain bitcode. Interesting. Looks like the problem is somewhere inside the Xcode.

When I tried to append OTHER_LDFLAGS=-fembed-bitcode OTHER_CFLAGS=-fembed-bitcode after the first xcodebuild command, I get can't write output file: /Users/sluptak/Library/Developer/Xcode/DerivedData/**********-ardwmlffacnvhcdhktnabatatkhk/Build/Intermediates/ArchiveIntermediates/**********/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/lib*******.a.strip (Invalid argument) error and some /Applications/Xcode8.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning for architecture: arm64 same member name (DetailParserPoiCategoryGroup-A44459DED4065366.o) in output file used for input files: /Users/sluptak/Library/Developer/Xcode/DerivedData/********-ardwmlffacnvhcdhktnabatatkhk/Build/Intermediates/ArchiveIntermediates/********/IntermediateBuildFilesPath/********.build/Default-iphoneos/********.build/Objects-normal/arm64/lib********.a(DetailParserPoiCategoryGroup-A44459DED4065366.o) and: /Users/sluptak/Library/Developer/Xcode/DerivedData/********-ardwmlffacnvhcdhktnabatatkhk/Build/Intermediates/ArchiveIntermediates/********/IntermediateBuildFilesPath/********.build/Default-iphoneos/SygicCore.build/Objects-normal/arm64/lib********.a(DetailParserPoiCategoryGroup-A44459DED4065366.o) due to use of basename, truncation and blank padding warnings before that.

Hmmmm 🤔. I am not too familiar with this type of issue. I just did a quick search on Stack Overflow and it looks like there are a handful of answers on there like making sure your AppID is different in the dev portal and disabling bitcode all together.
I am going to close this issue for now as it seems to be an issue with project configuration and Xcode/Apple, but please feel free to comment again on here to continue discussion and we would love to hear what fixes the situation. 🚀 🐙

OK, so I tried to generate the xcodearchive with Xcode (8.2.1) and then I used gym to export an IPA from that xcarchive and it worked correctly with no warning from iTunes Connect. So the difference is probably between the xcodebuild and the Xcode. Do you have an idea how to compare what is actually happening during both methods? I know that gym is saving a log for me, and so does the Xcode, but the format of those files is different AFAIK. Do you have some suggestion please?

Yeah! @EskiMag if you do xcode-select -p that will show you which version of xcodebuild is being used. You could then run sudo xcode-select -s /path/to/xcode/version/you/want and then you should be able to match up the xcodebuild command to be running the same version as Xcode itself.
Let us know if that is helpful! 🚀

Yes, I know that command and my xcode-select is already pointed to 8.2.1, also when I am using the Xcode itself, I am using the 8.2.1. I also tried to uninstall every other Xcode, to prevent some mismatch. So the thing you suggest is probably not the reason for this weird behaviour.

Hmm, I'm not too sure what a good solution would be for that. I would suggest taking a look at Stack Overflow to see if others are seeing the same issue between Xcode itself and xcodebuild checked out to the same version.

OK, I have another update. I created dummy empty application with WatchKitApp and WatchKitApp Extension, I replicated Bundle IDs, Versions, Capabilities and then tried gym and deliver and everything worked perfectly. So there have to be something special in our xcodeproj which is quite huge, so I am quite curious what I am going to do now. :-| :-D Wish me good luck...

OK, I have another update. I created dummy empty application with WatchKitApp and WatchKitApp Extension, I replicated Bundle IDs, Versions, Capabilities and then tried gym and deliver and everything worked perfectly. So there have to be something special in our xcodeproj which is quite huge, so I am quite curious what I am going to do now. :-| :-D Wish me good luck...

Best of luck @EskiMag ! Thanks for the follow up! We would love to hear what ends up fixing it!

OK. It seems I have found the solution. I had ENABLE_BITCODE = NO setting in my .xcconfig file and then explicitly set ENABLE_BITCODE = YES for WatchKitApp and WatchKitExtension. Somehow, it was resolved differently when using Xcode and when using xcodebuild ... it's really weird. Maybe I'll try later to investigate this issue a bit deeper, but for now it's working for me with fastlane and that's important at the moment. Thanks everybody for your support and advices. :-D

Ahhh! Thanks for following up @EskiMag! I've definitely been bitten before by values in .xcconfig files overwriting and being overwritten. Glad you got it all sorted out! 🚀


Dapr initialisation check.

Describe the proposal
In our case, we need to do some calls on application start, and we identified that we were locking app port HTTP 80 and DAPR was not being initialised. I didn't find a way to check when is the dapr sidecar initialised. It would be a nice idea to provide a boolean property or even a method to check when is the sidecar initialised and ready for receiving requests.
Thanks for this great runtime!

We have this actually. You can use DaprClient.CheckHealthAsync()
See: https://github.com/dapr/dotnet-sdk/commit/2ddb4bb7e059a28a3bb326e5c0b1cf36dd9b6bd3


2.3.4

Coverage increased (+0.04%) to 97.71% when pulling c22cd73b1891d7af3b6214b12cad224cc74f7759 on dev into 97afec37864f676199e261874a827a074552a455 on master.


Update waterfox to 55.0.1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[ ] sha256 changed but version stayed the same (what is this?).
I’m providing public confirmation below.

Please do not merge directly, I will add zap stanzas for Waterfox as they are now using their own ~/Library/Application Support folder instead of the Firefox one.
See https://www.waterfoxproject.org/blog/waterfox-55.0-release-download

Zap stanzas added ! Thanks for the wait.


Bug : Previous error message stays after changing the user name

I checked this and it is not reproducible anymore, closing it


Fix magic method generation & helper class aliases

Main fixes:

Fix magic method generation: Before this, methods added via the 'magic' configuration option were calling a method in the root class with the 'magic' name instead of the 'real' name.
Fix helper class aliases: Aliases for helper classes were mistreated before: the generator would write empty classes that hid the real helper implementation from the IDE. After the change, classes with the real namespace and class name are only generated for facades.

Miscellaneous:

Fix Generator error output: The OutputInterface given to the constructor was never saved.
Some cleanup of Alias, Method and Macro

@barryvdh This is my first time contributing here, so I'm not sure what the process is usually. Please let me know if there's anything else I need to do before this PR can be considered for a merge. Thanks!

@PantherDD - that is a lot of code to review. You may want to chunk it out into multiple pull requests if possible.

Thanks for your contribution @PantherDD , but I agree: there are too much changes and it's mixed with clean up. Best is to submit separate PRs for each feature and clean up etc.
@barryvdh I vote for closing the PR!

Thanks for your contribution @PantherDD , but I agree: there are too much changes and it's mixed with clean up. Best is to submit separate PRs for each feature and clean up etc.
@barryvdh I vote for closing the PR!

@Artistan, @mfn: Sorry, I never got time to clean this PR up when you asked. Unfortunately since then I'm not working with Laravel anymore, and didn't follow all the changes to this project, so I don't think I'll be able to get this into the desired state. Feel free to take the ideas / code from this PR and apply them as you see fit, if they still make sense; the PR itself can be closed I think.
Cheers, and keep up the good work! :)


KDE Plasma freezes after entering password on NixOS 24.11

Describe the bug
After upgrading to NixOS 24.11, I can't use the graphical login screen because it freezes after I enter my password. When I open a new virtual console using Ctrl+Alt+F1, I am able to successfully log in and then run startplasma-wayland, which launches the desktop and a KDE Wallet window asking me to enter my password (which is the same as my system password). I think this KDE Wallet behaviour is what is causing the graphical login freeze.
Steps To Reproduce
Steps to reproduce the behavior:

Launch a NixOS desktop using KDE Plasma
Attempt to log in
Observe freeze

Expected behavior
I expect to be able to log in using the graphical login screen
Screenshots

Additional context

Metadata

system: "x86_64-linux"
host os: Linux 6.6.63, NixOS, 24.11 (Vicuna), 24.11.709933.c71ad5c34d51
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.24.10
channels(root): "nixos-24.11"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Notify maintainers

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

I am seeing the same behavior with sddm on plasma5 with Xorg.

I think I'm seeing this as well, on nixos-unstable (ac35b104800bff9028425fec3b6e8a41de2bbfff).  sddm + plasma6 + wayland.

I also have this issue.

I think this KDE Wallet behaviour is what is causing the graphical login freeze.

I don't think that's the case. I tried removing the kwallet password (which disables the popup), as well as disabled the kwallet (in ~/.config/kwalletrc), none of it helped. And I also don't see any kwin processes during the freeze, so it seems like it freezes before even attempting to launch plasma? Or maybe plasma launches and immediately crashes or something and leaves sddm hanging.

I'm no longer hitting this.  I haven't updated anything - so either the issue I hit was spurious, it resolved itself, or rebuilding the font cache (which I did for a different issue) resolved it.
(In case it's the latter - I ran fc-cache -r because of the nerdfonts package split.)

I tried using an empty password in the hope that it might resolve this issue for me, but I'm still getting the freezing after trying to log in, which indicates that this is probably not related to KDE Wallet after all.

I had the same problem. Then found this workaround https://github.com/NixOS/nixpkgs/issues/363797#issuecomment-2558384445 and gave it a try:
services.displayManager.sddm.wayland.enable = true;

Plasma now starts up for me after hitting return/enter when the password is entered.
Without this option systemctl status display-manager.service listed two processes with X being one of them. Now it doesn't list X anymore. I guess something about X + SDDM is broken since 24.11?

This worked for me, thank you!

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/plasma-6-login-screen-is-broken/57742/4


GH1126: corrects issues with UploadArtifact and UploadTestResults

UploadArtifact now sends -Type instead of -ArtifactType to define the type of artifact uploaded, I blame resharper for this one!

UploadTestResults - the Content-Disposition header on the form-data content needs to specify at least a name.  Now generates a header similar to:

Content-Disposition: form-data; name=test-results.xml; filename=test-results.xml

Hi @Philo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

@Philo can confirm PR fixes issue :+1:  , I've merged the PR and @cake-build/team will look at releasing hotfix hopefully tomorrow or day after that. Thanks for contributing.

Relates to #1126


Linux: amd64 AppImage fails to launch

Describe the bug
amd64 AppImage fails to launch: I can see a black window for a fraction of a second, and then it just dies.
From the console the following log is produced:
./zmk-studio_0.1.0_amd64.AppImage
Could not create surfaceless EGL display: EGL_BAD_ALLOC. Aborting...
zsh: IOT instruction (core dumped)  ./zmk-studio_0.1.0_amd64.AppImage

To Reproduce
Try to launch the AppImage
Expected behavior
I would expect the AppImage to launch.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment:

Manjaro with KDE(Plasma 6.1.5)/Wayland, kernel 6.11.2-4-MANJARO
App
amd64 AppImage release 0.2.0

Also fails in an X11 session:
./zmk-studio_0.1.0_amd64.AppImage
Gtk-Message: 04:53:33.012: Failed to load module "xapp-gtk3-module"
Could not create surfaceless EGL display: EGL_BAD_ALLOC. Aborting...
zsh: IOT instruction (core dumped)  ./zmk-studio_0.1.0_amd64.AppImage

I am using an AMD 7900XT with the open amdgpu driver.

I have a similar issue with the AppImage. The app starts but the windows
is blank.
Gtk-Message: 10:37:46.524: Failed to load module "xapp-gtk3-module"
Could not create default EGL display: EGL_BAD_PARAMETER. Aborting...

** (app:8069): WARNING **: 10:38:13.563: atk-bridge: get_device_events_reply: unknown signature

Environment:

CachyOS (Arch)
Kernel: 6.11.6-2-cachyos
X11/i3
GPU: AMD 7900XT
App-Version: 0.2.2

I'm also having an issue with the AppImage window being blank. When run from the terminal I see similar output, only difference is I'm missing that first line:
Could not create default EGL display: EGL_BAD_PARAMETER. Aborting...

** (app:33041): WARNING **: 17:52:39.447: atk-bridge: get_device_events_reply: unknown signature

Environment

Fedora Linux 41 Workstation Edition
Kernel: 6.11.7-300.fc41.x86_64
GNOME DE (Wayland session)
App version: 0.2.3
Hardware:

Framework Laptop 13 AMD
CPU: AMD Ryzen™ 7 7840U
GPU: AMD Radeon™ 780M

Can folks give the environment variables mentioned here a try? https://github.com/getyaak/app/issues/75#issuecomment-2344749813

Just gave that a try, still got the same errors in terminal and same viewport behavior

With the variables, the behavior changes - I get new errors:
WEBKIT_DISABLE_COMPOSITING_MODE=1 WEBKIT_DISABLE_DMABUF_RENDERER=1 ./zmk-studio_0.1.0_amd64.AppImage
Gtk-Message: 14:44:11.568: Failed to load module "xapp-gtk3-module"
Gtk-Message: 14:44:11.799: Failed to load module "xapp-gtk3-module"
Could not create surfaceless EGL display: EGL_BAD_ALLOC. Aborting...
** (app:130420): WARNING **: 14:44:36.852: atk-bridge: get_device_events_reply: unknown signature

And a white screen that's just open forever (as opposed to a black window that blinked on and disappeared before):

Please try the downloaded artifact from #92 and let me know if it fixes things for you as well. If so, I will get it merged and released. Thanks!

The window contents now render correctly! Thank you for getting that working. I haven't had time to use it extensively yet but I was able to get to the studio unlock step, so that's a good sign.

Doesn't seem to be working for me yet, unfortunately. Will report back once I can do a bit more testing.

#from actions for PR 92
./zmk-studio_0.2.3_amd64.AppImage
Cannot get default EGL display: EGL_SUCCESS
Cannot create EGL context: invalid display (last error: EGL_SUCCESS)
zsh: segmentation fault (core dumped)  ./zmk-studio_0.2.3_amd64.AppImage
#0.1.0 release
./zmk-studio_0.1.0_amd64.AppImage
Gtk-Message: 23:41:03.998: Failed to load module "xapp-gtk3-module"
Could not create surfaceless EGL display: EGL_BAD_ALLOC. Aborting...
zsh: IOT instruction (core dumped)  ./zmk-studio_0.1.0_amd64.AppImage

However, WEBKIT_DISABLE_COMPOSITING_MODE=1 WEBKIT_DISABLE_DMABUF_RENDERER=1  ./zmk-studio_0.2.3_amd64.AppImage actually works now. Is there a way to use those variables as defaults?

#from actions for PR 92
./zmk-studio_0.2.3_amd64.AppImage
Cannot get default EGL display: EGL_SUCCESS
Cannot create EGL context: invalid display (last error: EGL_SUCCESS)
zsh: segmentation fault (core dumped)  ./zmk-studio_0.2.3_amd64.AppImage
#0.1.0 release
./zmk-studio_0.1.0_amd64.AppImage
Gtk-Message: 23:41:03.998: Failed to load module "xapp-gtk3-module"
Could not create surfaceless EGL display: EGL_BAD_ALLOC. Aborting...
zsh: IOT instruction (core dumped)  ./zmk-studio_0.1.0_amd64.AppImage

However, WEBKIT_DISABLE_COMPOSITING_MODE=1 WEBKIT_DISABLE_DMABUF_RENDERER=1 ./zmk-studio_0.2.3_amd64.AppImage actually works now. Is there a way to use those variables as defaults?

Let me research the impact before we try forcing the values universally. Thanks for testing!

If it matters, I launched the AppImage as root, not sure if that'd affect things for you but it's worth a shot

It really shouldn't require that. Can you please test running as a normal user?

Yeah, it does launch but it gives me issues with "permission denied" errors when selecting a device. Forgot to mention that, my bad, that was just a separate issue I worked around but need to look into.

Yeah, it does launch but it gives me issues with "permission denied" errors when selecting a device. Forgot to mention that, my bad, that was just a separate issue I worked around but need to look into.

Does your user have correct permissions to the /dev/ttyACM# device?

That was the issue, good catch! Had to add my user to the dialout group and restart, it now launches as expected and remaps keys successfully.

#from actions for PR 92
./zmk-studio_0.2.3_amd64.AppImage
Cannot get default EGL display: EGL_SUCCESS
Cannot create EGL context: invalid display (last error: EGL_SUCCESS)
zsh: segmentation fault (core dumped)  ./zmk-studio_0.2.3_amd64.AppImage
#0.1.0 release
./zmk-studio_0.1.0_amd64.AppImage
Gtk-Message: 23:41:03.998: Failed to load module "xapp-gtk3-module"
Could not create surfaceless EGL display: EGL_BAD_ALLOC. Aborting...
zsh: IOT instruction (core dumped)  ./zmk-studio_0.1.0_amd64.AppImage

However, WEBKIT_DISABLE_COMPOSITING_MODE=1 WEBKIT_DISABLE_DMABUF_RENDERER=1 ./zmk-studio_0.2.3_amd64.AppImage actually works now. Is there a way to use those variables as defaults?

I've merged the build fix. I'm hesitant to try to enable those by default until:

We've tested the impact more broadly.
We understand scope of conditions that make this required.

For now, I'd rather add this to our (planned) Studio troubleshooting documentation.


library logs messing around with application logs

go-redis is a library, and as a library, it should not be logging anything. But it's possible to see some calls to log.Printf here: https://github.com/go-redis/redis/search?q=log.Printf&type=Code&utf8=✓.
If removing logs is simply not an option, would you be open for accepting a Logger in the Client and using this Logger? Replacing log.Printf calls with c.logger.Printf. And users willing to disable logging could simply use ioutil.Discard for that.

I am fine to reduce amount of logs generated by go-redis if you can provide some evidence that those logs are useless. But generally go-redis should not be very noisy.

would you be open for accepting a Logger in the Client

What about package level variable redis.Logger? Doing logging on client level is a bit cumbersome because you have to pass logger to every function that wants to log something (if that function is not attached to *Client).

Hi @vmihailenco, sorry for the late response.
Any log written by a library is not useful. If I care about some information, I should log it. It's not like you're logging something that I don't have access to. Whenever I use the failover-enabled client, I get some noisy log messages telling me what's the Redis endpoint for a given master name. Logging errors in a library also doesn't make sense, as you're returning then later, so it should be a decision of the calling code whether to log or do something else, specially because you're logging to a shared resource (the global logger). If you have a library-wise logger, that would be fine for me.
Seems like you don't agree with me on this point, which is definitely fine. Having a global Logger would solve the issue as well. Thank you very much for your time.

Ahh, forgot to include that: if you agree with the package-wise logger, I can send you a pull request. Thanks!

I know this is closed, and you've exposed a global Logger var so we can nil this out, but I came here expressly for this purpose, as this is what I'm seeing all over my stdout:
redis: 2016/04/05 11:52:45 reaper: removed 0 stale conns (TotalConns=2 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:52:55 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:53:05 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:53:15 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:53:25 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:53:35 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:53:45 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:53:55 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:54:05 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:54:15 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:54:25 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:54:35 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:54:45 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:54:55 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:55:05 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:55:15 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:55:25 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:55:35 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:55:45 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:55:55 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:56:05 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:56:15 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:56:25 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:56:35 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:56:45 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:56:55 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:57:05 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:57:15 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:57:25 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:57:35 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:57:45 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:57:55 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:58:05 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:58:15 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:58:25 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:58:35 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:58:45 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:58:55 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:59:05 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:59:15 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:59:25 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:59:35 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:59:45 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 11:59:55 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 12:00:05 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 12:00:15 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 12:00:25 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 12:00:35 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 12:00:45 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)
redis: 2016/04/05 12:00:55 reaper: removed 1 stale conns (TotalConns=1 FreeConns=1 Requests=6 Hits=4 Timeouts=0)

...which generally isn't something I care about.  I can understand when building the pooling logic, it helps internal dev to log and see what's happening, but once the lib is released, I agree it should be configurable and off by default.  I'd adjust that PR in fact to disable the logger by default, with a short one-line description on how they can turn it back on if they're having problems with the lib, and want verbose log output.

Ok, I will disable logger by default. But you probably just don't need to run connection reaper with such high frequency (every 10 seconds?)..,


Remove trailing whitespace

retest this please

retest this please

retest this please

retest this please

guess what
retest this please


build: missing yargs package

@gulfaraz do you have some explanation on the origin/purpose? And please let me know if a review is urgent, then I can maybe get to it before Friday. Otherwise I'll leave it.

@jannisvisser the yargs package is used here and here
on a clean setup, I got the error message Cannot find module 'yargs'
running npm install --save-dev yargs resolved this problem so I believe it needs to be a part of package.json


Add debug flag

It would be nice if we could pass a debug flag to UIPilot at some point to have it print what's going on.

Good idea, will do it.

Release in version 1.1.6


Missing Interchange SRC attribute for accessibility compliance

What is missing?

Interchange component doesn't ship with a src attribute for IMG, so it is not accessible. It works fine with data-interchange for visual viewers. And I do see that in Chrome Inspect Element, Chrome adds the src attribute with the image file path. However, when viewing the source code, the src attribute does not get added to the IMG tag. Thus, this is causing accessibility testing softwares to flag it as inaccessible. We have a legal requirement to make our website accessible, even in our markup.
...
What is wrong now ?

There is currently no way to add a src attribute to the interchange plugin for it to set the src attribute on IMG tags.
...
Possible Solution

Possibly add a step in the interchange script to add a src attribute when using with an IMG tag, to detect with image was loaded via data-interchange and apply that image source to the SRC attribute?
...
Context

Our website will be unable to be compliant to our legal accessibility requirements. We are currently having to explain to them that when using third party extensions, some things are out of our hands, and we are working with the vendors to make our sites as compliant as possible.
...
Your Environment

Foundation version(s) used: 6.5.1
Browser(s) name and version(s): Google Chrome
Device, Operating System and version: Mac OS Mojave

Checklist

[x] I have read and follow the CONTRIBUTING.md document.
[X] here are no other issues similar to this one.
[X] The issue title and template are correctly filled.

Our website will be unable to be compliant to our legal accessibility requirements.

100% is not always possible in all cases.

as compliant as possible.
This.

auto / src for the type should set it properly.
https://github.com/zurb/foundation-sites/blob/develop/js/foundation.interchange.js#L233

Please provide a codepen so we can reproduce and check this. The attribute is set in the source code.

The test is green so it works in the tests, see https://github.com/zurb/foundation-sites/blob/develop/test/javascript/components/interchange.js#L70

Thank you @DanielRuf for the responses. I'm not able to see the code from https://github.com/zurb/foundation-sites/blob/develop/js/foundation.interchange.js#L233, and I notice you're indicating a line from the develop branch. This isn't available in the production-ready distributed version (https://github.com/zurb/foundation-sites/blob/master/js/foundation.interchange.js#L233). Is this something you will be publishing for public production-ready use soon?

master branch is not the 6.5 branch.

https://github.com/zurb/foundation-sites/blob/master-v6.5/js/foundation.interchange.js is from the right branch
We cherry-picked changes from develop into the 6.5 branches.
We could plan these changes for the next patch release @ncoden.

Would be https://github.com/zurb/foundation-sites/commit/40d82876c7d6b931f8c827144bfe3b2467898ddd and a few more (fixes).

Hi @sensaetions,
develop is used to prepare v6.6.0 (on master when released) and contains breaking changes. Changes made on develop that can be used in a patch release (documentation, non-breaking fixes) are cherry-picked in develop-v6.5 (on master-v6.5 when released). See https://github.com/zurb/foundation-sites/blob/develop/CONTRIBUTING.md#git-workflow
The src attribute seems to be correctly set for IMG.
https://github.com/zurb/foundation-sites/blob/v6.5.1/js/foundation.interchange.js#L154
https://foundation.zurb.com/sites/docs/interchange.html
I am missing something ?

@ncoden, we're using the production-ready v6.5.1 code for our websites. When will this Interchange img src fix be pushed to master for public production-ready use?

@ncoden @DanielRuf Is there any updates on when Interchange will work with the image src on a production release?

No updates as you can see =).


Bug fix in simulator

Cells  E2 E3 and G2 G3 need their  lower case couterparts added to fix 11111111 key generation bug
i.e. CH should be CHch
DS should be DSds

QKardDistribution Simulator v0.5_DEFCON31 fixed.xlsx
this file fixes the issue


Feature: Add REST tests.

Coverage increased (+23.19%) to 88.41% when pulling d2a860a6f942ae9a6e5326fb130a636f07cb8337 on feature-server-rest-tests into 4d37a95e0758083a303de2955058c6dbd694328b on master.


deprecate includeRelations in Bookshelf mapper

I'm working on a refactor of the mapper and I see again the includeRelations option, left as a compatible (but deprecated) option. Is it still needed to support this @jamesdixon?

RIP includeRelations ☠
Sent using CloudMagic [https://cloudmagic.com/k/d/mailapp?ct=pi&cv=6.0.64&pv=8.1.3]
On Tue, Jul 5, 2016 at 6:40 PM, Manuel Pacheco<EMAIL_ADDRESS>wrote:
I'm working on a refactor of the mapper and I see again the includeRelations option, left as a compatible (but deprecated) option. Is it still needed to support this @jamesdixon [https://github.com/jamesdixon] ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [https://github.com/scoutforpets/jsonapi-mapper/issues/46] , or mute the thread [https://github.com/notifications/unsubscribe/AAGuIgSiM58f5DcJmZgoZ_IenpbZqttgks5qSt1hgaJpZM4JFmTo] .

Gotcha. Will keep working ;)