podcast:alternateEnclosure should remove the stream attribute

This attribute has a number of problems:

Boolean attributes in XML do not work like HTML. You cannot simply specify stream, you must specify something like stream="stream" (as with XHTML) or stream="true".
This feels a lot like DRM, which is counter to the spirit of podcasting. If a device can start streaming content and play it, that content can be saved and replayed. There is no technical reason that content cannot be saved: if you can open a socket and start playing audio, you can open a file handle and start playing those same bytes.
Without specifying a mechanism for negotiating a mechanism for "true" streaming (that is, adjusting bitrate to accommodate network conditions), the content is not "streaming", it's just a regular download.

Agreed. That’s 99% of the time handled at the app later anyway.


[Question]: Incorrect condition_mode parameter value in get_condition_ppl function

Describe the bug
In the function get_condition_ppl of the class, when the condition_in_question parameter is "before", the condition_mode parameter should be "before", but it is currently "after". This may cause incorrect behavior of the function when handling the "before" condition.
Here is the relevant code snippet:
def get_condition_ppl(
    self,
    text: str,
    question: str,
    condition_in_question: str = "none",
    granularity: str = "sentence",
):
    ...
    elif condition_in_question == "before":
        return self.get_ppl(
            question + text,
            granularity=granularity,
            condition_mode="after",
            condition_pos_id=self.get_token_length(question) - 1,
        )
    ...

It is suggested to change condition_mode="after" to condition_mode="before" .
Steps to reproduce
No response
Expected Behavior
No response
Logs
No response
Additional Information
No response

Hi @charloco, the logic here is correct, and I apologize for any confusion caused by the naming convention. Specifically, the "condition_in_question" modes dictate how the conditional probability is calculated regarding the placement of the question in relation to the context. That is, "before" = $P(x_{\text{que}}, x_{\text{doc}})$ and "after" = $P(x_{\text{doc}}, x_{\text{que}})$.
The "condition_mode" controls the range considered when calculating PPL. For example, "before" = $\text{PPL}([:x_{\text{que}}])$ and "after" = $\text{PPL}([x_{\text{doc}}:])$.
Given the different "condition_in_question" modes, we aim to obtain the conditional PPL influenced by the first part on the latter, thus "condition_mode" is consistently set to "after".

Thank you for your explanation. I now understand the logic behind “condition_in_question” and “condition_mode”.


What if I want to simulate the off-chip data accesses ?

Is it necessary to add some memory simulation models such as DRAMSim2 if I want to do some simulation with memory access ?

It should be doable to implement DRAMSIM2 as a black-box C++ module in pymtl3 standard library. We don't have plan to do so yet though. Another question is that the designer might want to use his own handshake or whatever interface, but we are only able to provide our own enable/ready interface implementation in the stdlib.

It should be doable to implement DRAMSIM2 as a black-box C++ module in pymtl3 standard library. We don't have plan to do so yet though. Another question is that the designer might want to use his own handshake or whatever interface, but we are only able to provide our own enable/ready interface implementation in the stdlib.

Thanks for you suggestions. I am new for pymtl3, could you tell me how to use your own enable/ready interface to access the DRAM memory ?

It should be doable to implement DRAMSIM2 as a black-box C++ module in pymtl3 standard library. We don't have plan to do so yet though. Another question is that the designer might want to use his own handshake or whatever interface, but we are only able to provide our own enable/ready interface implementation in the stdlib.

Thanks for you suggestions. I am new for pymtl3, could you tell me how to use your own enable/ready interface to access the DRAM memory ?

We currently don't have DRAMSIM2 support yet ... Need to investigate a little bit more.


Flamegraph view gets stuck

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I made this simple script to test the new temporary flamegraphs feature:
import random
import string
from collections import Counter

def set_up():
  b = random.choice(string.ascii_letters)
  return Counter(b)

def run():
  c = set_up()
  key = random.choice(list(c.keys()))
  print(f'{key}: {c[key]}')

run()

I executed the following commands:
$ python -m memray run test.py
Writing profile results into memray-test.py.73578.bin
o: 1
[memray] Successfully generated profile results.

You can now generate reports from the stored allocation records.
Some example commands to generate reports:

/Users/mgmacias/Documents/GitHub/memray/env/bin/python -m memray flamegraph memray-test.py.73578.bin
$ python -m memray flamegraph memray-test.py.73578.bin --temporal
Wrote memray-flamegraph-test.py.73578.html

Then opened the flamegraph on my chrome browser. The flamegraph gets stuck on this loading view:

When checking the chrome dev console I can see the following error message:

Expected Behavior
An error message or a flamegraph.
Steps To Reproduce

Save the script to a python file
Run the commands mentioned above
Open the flamegraph in chrome

Memray Version
1.8.0
Python Version
3.11
Operating System
macOS
Anything else?
No response

There are two possible problems that this bug surfaces:

Is possible that the script runs so fast that the two ends of the graph are the same.
If the memory is flat the high the hwmBytes is somehow undefined.

This seems to happen because in this case high_water_mark_by_snapshot is an empty array.

I think at the very least this:
https://github.com/bloomberg/memray/blob/c2c8d53393de25670a9da0325c34027a7ed4c015/src/memray/reporters/assets/temporal_flamegraph.js#L55
should be
  if (hwms && hwms.length > 0) {

I think this is enough to fix it:
diff --git a/src/memray/reporters/assets/temporal_flamegraph.js b/src/memray/reporters/assets/temporal_flamegraph.js
index d43a509..259e5f0 100644
--- a/src/memray/reporters/assets/temporal_flamegraph.js
+++ b/src/memray/reporters/assets/temporal_flamegraph.js
@@ -52,7 +52,7 @@ function packedDataToTree(packedData, rangeStart, rangeEnd) {
   }

   const hwms = packedData.high_water_mark_by_snapshot;
-  if (hwms) {
+  if (hwms && hwms.length > 0 && memory_records.length > 0) {
     console.log("finding highest high water mark in range");
     let hwmSnapshot = rangeStart;
     let hwmBytes = hwms[rangeStart];


Can't create users if disabled

I know the title is confusing, but on an old version (probably 2), I could create users in an admin session but registers were disabled, and now I can't. Is it a feature or a bug?
Thanks

There was a bug. It's fixed now as far as I remember.

So, I cannot create users if I'm in an admin session and the server has disabled registrations?

You should be able if you have the fixed build.

The one I downloaded earlier? Like an hour?

Yes, that one should contain the fix.

Tried:
Registration disabled - SecurityException (PermissionsManager:95 < UserResource:51 < ...)

Fixed the problem. Here is a new build:
https://www.dropbox.com/s/cgmlansv32j3ii0/tracker-server.jar?dl=0

Thanks, will test shortly

I just found out that this bug is still present in traccar 3.4

@sharkile, I just double-checked and everything works correctly for me on 3.4.

That's weird, registration is disabled and if I try to add another user I got this pop-up.

If you point me to the right log I'll gladly share it with you if needed.

How did you install version 3.4? You are definitely using old binary.

It was a fresh install. I stopped traccar, dropped the database, uninstalled the daemon and deleted the installation directory, then I just unzipped the 3.4 file, ran the installation script and set traccar to use MySQL.
I also notice that whenever I run ./traccar status I get the traccar is not running message even though it is actually running, I don't know if that has anything to to with the issue.

Please provide MD5 hash of the tracker-server.jar file.

76434ec6f247da409f9519e252d0fb11
2016-03-09 0:17 GMT-07:00 Anton Tananaev<EMAIL_ADDRESS>
Please provide MD5 hash of the tracker-server.jar file.
—
Reply to this email directly or view it on GitHub
https://github.com/tananaev/traccar/issues/1670#issuecomment-194148204.

That's correct hash, but line numbers in the error don't match the code, so we must be missing something.


delete module-info.java

@rultor release, tag is 0.9.1

@rultor release, tag is 0.9.1

@rultor release, tag is 0.9.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.9.1

@yegor256 Done! FYI, the full log is here (took me 9min)


Update to Android NDK r26

Tool name
Android NDK
Tool license
Apache
Add or update?

[ ] Add
[X] Update

Desired version
26.0.10792818
Approximate size
No response
Brief description of tool
No response
URL for tool's homepage
No response
Provide a basic test case to validate the tool's functionality.
No response
Platforms where you need the tool

[X] Azure DevOps
[X] GitHub Actions

Runner images where you need the tool

[X] Ubuntu 20.04
[X] Ubuntu 22.04
[X] macOS 11
[X] macOS 12
[X] macOS 13
[X] Windows Server 2019
[X] Windows Server 2022

Can this tool be installed during the build?
No response
Tool installation time in runtime
No response
Are you willing to submit a PR?
No response

@levinli303 the latest version of android ndk is expected with the next release of images.

@levinli303 PRs merged, awaiting deployment.

The r26b version of the NDK is already available and I created a separate issue #8517 which was closed as a duplicate. May I ask why? Will the NDK r26b be available after #8327 instead?

We install the latest available version, be it b or the newest one, so it does not matter :)

Deployed


Use jinja2 templating for docker-compose file

This allows us to have one template configurable for several environments (e.g. CI test, local development, demo server) rather than several copies of a similar file.

The templating and containerization of this PR is unfortunately outside my expertise. Maybe @torbrenner is a more appropriate reviewer.

This PR is very outdated. Development and deployment scripts have diverged significantly, so this PR is no longer relevant.


Added logic to strip any existing hyphens before processing the args.

Updated the logic to handle if extra args are passed with existing hyphens in the arg. The test was updated to add the additional case of having pre-existing hyphens. The method name was also refactored based on previous feedback.

https://github.com/k3s-io/k3s/issues/3642

Codecov Report

Merging #3662 (ac177df) into master (580955d) will increase coverage by 0.01%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master    #3662      +/-   ##
==========================================
+ Coverage   11.37%   11.38%   +0.01%
==========================================
  Files         134      134
  Lines        8733     8734       +1
==========================================
+ Hits          993      994       +1
  Misses       7525     7525
  Partials      215      215

Flag
Coverage Δ

unittests
11.38% <30.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/run.go
0.00% <0.00%> (ø)

pkg/daemons/agent/agent.go
0.00% <0.00%> (ø)

pkg/daemons/control/server.go
0.00% <0.00%> (ø)

pkg/daemons/config/types.go
50.00% <100.00%> (+3.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580955d...ac177df. Read the comment docs.

It looks like you merged master into your branch, instead of rebasing onto it. Can you switch that around?


[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500][Dupe Detection] Surfacing Potential Duplicates

Part of the  project
Main issue: https://github.com/Expensify/Expensify/issues/307591
Doc section: Surfacing Potential Duplicates
Project: [Wave: Collect Approvers] Dupe Detection
UI

Feature Description
Update the comment type here since this can be a single string or a full array containing different transactions NVPs. In this case, it looks like this:

The HOLD doc implemented the logic to display the HOLD notification for each expense. You can see the details here. However, we need to make the following changes to update the HOLD notification in case it is duplicated.

Add a new function called TransactionUtils.isDuplicate(transactionID, checkDismissed) that will check if there is an existing duplicate violation for the given transactionID and has been dismissed:

Listen to the transactionViolations_* Onyx key. Remember the key looks like this:

Check if the duplicatedTransaction key is set in the above Onyx key for the transaction and return true only if the following condition is not met:

Since the violation could have been dismissed, check if the corresponding transactions_* key contains an entry for the current user:

Add a new condition to ReportUtils.isOnHold to see if the transaction is a duplicate by calling TransactionUtils.isDuplicate(transactionID, true).

In components/ReportActionItem/MoneyRequestView.js in the View for the HOLD banner:

Check if the transaction has any duplicates by checking the corresponding Onyx key transactionViolations_*. If so, replace the props.translate('iou.requestOnHold') for props.translate('iou.requestDuplicate') that contains the message defined in the screenshot at the beginning of the issue (asked me for the Spanish translations).

If there are duplicates, add a new <Button> to review duplicates. Don't navigate anywhere for now but eventually it will do the following:

Navigate the user to the route for a new page ReviewDuplicate

Pass the threadReportID of the transaction in the route to the new page.

Manual Test Steps

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016dc734e5d5fc1a3f
Upwork Job ID:<PHONE_NUMBER>213647872
Last Price Increase: 2024-04-11
Automatic offers:

akinwale | Reviewer | 0
gijoe0295 | Contributor | 0

Issue OwnerCurrent Issue Owner: @MitchExpensify

@MelvinBot Well Melvin, we are prioritizing this again, so reopening!

Will this ultimately be internal or external @pecanoro ?

@MitchExpensify Ideally external, but I am trying to wrap up the back-end first.

@MitchExpensify Assigning you back as BZ member since we are opening this one to contributors

I'd want to submit a proposal, but I would like more context beforehand. Do you have a working link for the main issue?  https://github.com/Expensify/Expensify/issues/307591 is broken.

This feature will update transaction holding functionality to include duplicate transactions. If a report is a potential duplicate, display a button to review the duplicate reports.
What is the root cause of that problem?
Some people send in multiple reports for the same expense.
What changes do you think we should make in order to solve the problem?
use the transactionViolations_* Onyx key for a report and see if it is contained as a duplicate and violation is not dismissed.
Display the UI if it is a duplicate report.

https://github.com/Expensify/Expensify/issues/307591 is an internal issue and sadly I can't share the design doc. However, I can answer any questions you might have. I just noticed you are working on a PR already and new contributors are only allowed to be assigned to one issue until it’s merged. After that, you can apply to different open issues, not restricted to one at a time.

Because of the above, assigning @gijoe0295, please don't hesitate to let me know if anything was unclear!

Done! You should have access now

Two transactions on the same expense report that have the same date, currency, amount and merchant should trigger it. Does it show in the violations key in Onyx?

not overdue, actively being worked on

I will check what's going on tomorrow with the violations, I ran out of time today

Great question! Let me ask internally in Slack!

@gijoe0295 They were still discussing yesterday, but let me bump the conversation! Thanks for the reminder

It seems we want to say Cash [dot] Duplicate [dot] Hold for when we hold due to violations!

Hmm, I need you can remove that part since it's not supported in the back-end either

@pecanoro One more question, should this view be shown to other workspace members (including admins, auditors) or just exclusive to the IOU creator?

Admins and the the creator of the expense should be able to review duplicates

Reminder set to pay, do we need BZ steps here @akinwale ?

Reminder set to pay, do we need BZ steps here @akinwale ?

@MitchExpensify Yes, we do. I'll post them shortly. Also, please note the PR was initially deployed to production 2024-06-11, so the correct payment due date should be 2024-06-18.

[x]  [@akinwale] Please propose regression test steps to ensure  the new feature will work correctly on production in further releases.

Regression Test Steps
Prerequisites

Control workspace with Expense Violations enabled
Account is an employee member of Control workspace and violations are enabled for the account
Use staging server on if testing on dev

Launch the Expensify app.
Login as a member of the Control workspace.
Submit 2 expenses with the same amount (avoiding limit violations), currency, merchant and date to the workspace.
Navigate to the workspace chat where the expense was created.
Open the expense report.
Verify that each expense preview has a red dot indicator and Cash · Duplicate · Hold at the top
Open any one of the transactions in the expense report.
Verify that the HOLD banner is displayed at the top.
Verify that the text, This expense has the same details as another one. Review the duplicates to remove the hold. is displayed.
Verify that a Review duplicates button is displayed. Clicking or tapping the button does nothing at the moment.

Do we agree 👍 or 👎?

Paid and contracts ended!


Add toggle command for entire UI

This allows the debugger to be used on a live server, and / or only by those with ACE Perms.
(Requested in issue #3)

Also some linting :)

Hey, could you lint the project with the original convention?

White spaces in the CSS and JS files.
White space around the string concatenations in the Lua files.

It looks great otherwise!

Just to confirm, you'd like me to remove the spaces in the string concatenations, and use tabs instead of spaces in the CSS and JS files?

Correct.

It will hurt my soul a bit, but I'll do it as soon as I have some time in the next day or so.

Life got in the way so it took a bit longer.
Lemme know if there's any more changes you'd like.

Looks good, great job!


Feature request: add a Set type (like cid.Set)

It would be useful for me that we could have sets of peer  IDs like we can have sets of Cids
Basically doing: https://github.com/ipfs/go-cid/blob/master/set.go here.
@lanzafame do you want to take care of this?

@hsanjuan you mean like peerset? It is not the exact same set of methods but I can extend it if peerset doesn't have sufficient functionality for what you are trying to do?

IM SO BLIND!


Immutable concise set iteration optimizations

Don't delete immutable-concise-set-iteration-optimizations branch yet - it could be PRed into master later.


SICER2 program run error

Start
Running SICER with given arguments
Preprocess the Panx2.bed file to remove redundancy with threshold of 1
Removing temporary directory and all files in it.
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
File "/usr/local/python/3.9.10-gcc11.2.0-rv2ln4esaesugyvk2qty4ur6nlwkbtea/lib/python3.9/multiprocessing/pool.py", line 125, in worker
result = (True, func(*args, **kwds))
File "/usr/local/python/3.9.10-gcc11.2.0-rv2ln4esaesugyvk2qty4ur6nlwkbtea/lib/python3.9/multiprocessing/pool.py", line 48, in mapstar
return list(map(*args))
File "/usr/local/sicer2/1.0.3/sicer2-1.0.3/lib/python3.9/site-packages/sicer/src/remove_redundant_reads.py", line 133, in find_and_filter_reads
chrom_reads = match_by_chrom(path_to_file, chrom)  # Separates all reads by chromosome
File "/usr/local/sicer2/1.0.3/sicer2-1.0.3/lib/python3.9/site-packages/sicer/src/remove_redundant_reads.py", line 120, in match_by_chrom
processed_reads[i] = tuple(reads)
ValueError: invalid literal for int() with base 10: '.'
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
Traceback (most recent call last):
File "/usr/local/sicer2/1.0.3/sicer2-1.0.3/bin/sicer", line 235, in
main()
File "/usr/local/sicer2/1.0.3/sicer2-1.0.3/bin/sicer", line 229, in main
run_SICER.main(args)
File "/usr/local/sicer2/1.0.3/sicer2-1.0.3/lib/python3.9/site-packages/sicer/main/run_SICER.py", line 52, in main
total_treatment_read_count = remove_redundant_reads.main(args, args.treatment_file, pool)
File "/usr/local/sicer2/1.0.3/sicer2-1.0.3/lib/python3.9/site-packages/sicer/src/remove_redundant_reads.py", line 147, in main
filtered_result = pool.map(find_and_filter_reads_partial, chroms)
File "/usr/local/python/3.9.10-gcc11.2.0-rv2ln4esaesugyvk2qty4ur6nlwkbtea/lib/python3.9/multiprocessing/pool.py", line 364, in map
return self._map_async(func, iterable, mapstar, chunksize).get()
File "/usr/local/python/3.9.10-gcc11.2.0-rv2ln4esaesugyvk2qty4ur6nlwkbtea/lib/python3.9/multiprocessing/pool.py", line 771, in get
raise self._value
ValueError: invalid literal for int() with base 10: '.'
Finish

Hi, this should be fixed by now, I am gonna to close this issue.


Misspell

"Over time, the list of custodians and their data sources may increase or decreasse"; decrease is misspelled.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d9a53db-59c2-5fdf-107b-a396acea8099
Version Independent ID: 3d8adbaf-c351-1948-6a67-b54223cabde7
Content: Work with custodians in Advanced eDiscovery - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/managing-custodians.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@Robright Thanks for heads up. For typos, you can also fix these and then submit a pull request.

Thanks Mark! I didn’t know I could do it myself. 😊 Thanks for the heads-up…
Thanks,
Rob
<EMAIL_ADDRESS>Rob Bright
Sr Premier Field Engineer (SharePoint)
Mobile:<PHONE_NUMBER>
rob.bright<EMAIL_ADDRESS>If you have feedback of any kind, please email my manager, Tammy<EMAIL_ADDRESS>From: Mark Johnson - MSFT<EMAIL_ADDRESS>Sent: Tuesday, March 3, 2020 12:00 PM
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Rob Bright<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Misspell (#1354)
@Robrighthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRobright&data=02|01|Rob.Bright%40microsoft.com|646ebfec9c664716b33c08d7bf9457b1|72f988bf86f141af91ab2d7cd011db47|1|0|637188516159235821&sdata=pDSp3QIXqFxf0lYKMOoPaTz8pOIirm21vYkHJnTutWs%3D&reserved=0 Thanks for heads up. For typos, you can also fix these and then submit a pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F1354%3Femail_source%3Dnotifications%26email_token%3DAOWZMGUSRRBBAMZF7EVX7ATRFUZR3A5CNFSM4LAOLA2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENUJNXI%23issuecomment-594056925&data=02|01|Rob.Bright%40microsoft.com|646ebfec9c664716b33c08d7bf9457b1|72f988bf86f141af91ab2d7cd011db47|1|0|637188516159245815&sdata=A6K30h%2F4vZ8cKRxYDk%2FS%2B7NpKNzVJKAeC29Z6W9%2BZYk%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOWZMGUOQ56DLAPRQBT3MITRFUZR3ANCNFSM4LAOLA2A&data=02|01|Rob.Bright%40microsoft.com|646ebfec9c664716b33c08d7bf9457b1|72f988bf86f141af91ab2d7cd011db47|1|0|637188516159245815&sdata=gLwH3%2BIFhDNPMwHp3ME1eVl9qri7ipPh7oTyt2InRok%3D&reserved=0.

Hey Mark, quick question: Do you have a link on submitting these via a pull request?
Thanks,
Rob
<EMAIL_ADDRESS>Rob Bright
Sr Premier Field Engineer (SharePoint)
Mobile:<PHONE_NUMBER>
rob.bright<EMAIL_ADDRESS>If you have feedback of any kind, please email my manager, Tammy<EMAIL_ADDRESS>From: Mark Johnson - MSFT<EMAIL_ADDRESS>Sent: Tuesday, March 3, 2020 12:00 PM
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Rob Bright<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Misspell (#1354)
@Robrighthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRobright&data=02|01|Rob.Bright%40microsoft.com|646ebfec9c664716b33c08d7bf9457b1|72f988bf86f141af91ab2d7cd011db47|1|0|637188516159235821&sdata=pDSp3QIXqFxf0lYKMOoPaTz8pOIirm21vYkHJnTutWs%3D&reserved=0 Thanks for heads up. For typos, you can also fix these and then submit a pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F1354%3Femail_source%3Dnotifications%26email_token%3DAOWZMGUSRRBBAMZF7EVX7ATRFUZR3A5CNFSM4LAOLA2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENUJNXI%23issuecomment-594056925&data=02|01|Rob.Bright%40microsoft.com|646ebfec9c664716b33c08d7bf9457b1|72f988bf86f141af91ab2d7cd011db47|1|0|637188516159245815&sdata=A6K30h%2F4vZ8cKRxYDk%2FS%2B7NpKNzVJKAeC29Z6W9%2BZYk%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOWZMGUOQ56DLAPRQBT3MITRFUZR3ANCNFSM4LAOLA2A&data=02|01|Rob.Bright%40microsoft.com|646ebfec9c664716b33c08d7bf9457b1|72f988bf86f141af91ab2d7cd011db47|1|0|637188516159245815&sdata=gLwH3%2BIFhDNPMwHp3ME1eVl9qri7ipPh7oTyt2InRok%3D&reserved=0.


Pem cert support to connect to kafka clusters

About this change - What it does
Currently klaw can connect to kafka clusters over ssl, with cert types for jks and pkcs12. With this minor change, it should be able to connect to kafka clusters with pem cert types too.
Resolves: #181
Why this way
With configuration enabled, it is now possible to connect to cluster with any certificate type

Ex config below :
dev1.kafkassl.keystore.certificate.chain=-----BEGIN CERTIFICATE-----
..
-----END CERTIFICATE-----
dev1.kafkassl.keystore.key=-----BEGIN PRIVATE KEY-----
..
-----END PRIVATE KEY-----


add missing translationRef export necessary for internationalization

Summary 📰
In the previous PR we made to add adds support for internationalization, we forgot to add necessary export to the translationRef to be used by people using the plugin
Details 📚
added the necessary exports to the plugins to allow the intl to be used and translated inside their backstage instance

Checklist ✅

[x] I have updated the necessary documentation
[x] I have signed off all my commits as required by DCO
[x] My build is green

Testing Notes 🔬

@gabrielcbe - add and changeset and we can merge this.

@kurtaking, added back the changeset, the one before had changes to the main plugin too so I reverted.
thanks a lot!


GlobalWindowing has no early emitting

Add support for early emitting to GlobalWindowing. This has consequences to stream processing, because combinable ReduceByKey will be possible to be run over streams. Non combinable RBK will result in unbounded data being stored in state and therefore is impractical.

Obsolete.


[cuda] Remove -iree-hal-cuda-dump-ptx

We can use -iree-hal-dump-executable-binaries-to= instead, which is consistent across all compiler backends.

Pleas don't just drop tests. Those tests were added for a reason, why are we dropping them?

Can we revert this PR? I don't understand why we would want to drop those tests

Can we revert this PR? I don't understand why we would want to drop those tests

I though this option is the same as -iree-hal-dump-executable-binaries-to= under the hood? But if they are in use, then certainly feel free to revert. :)

I'm more worried about removing tests. Can this command line dump to console?

No I don't think so. But it seems there is a way to test even with intermediate directories and files: https://github.com/iree-org/iree/pull/11916.


Version 0.6.2

What this PR does / why we need it:
Release 0.6.2
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/lgtm


Is it support XPath?

Is it?
Thanks!

Hello Alexandre,
No, it is based on an HTML(5) parser and supports CSS-style selectors (like its javascript inspiration, jQuery). You may want to check xmlpath (https://godoc.org/gopkg.in/xmlpath.v2) for a pure Go XPath engine, or gokogiri (https://godoc.org/github.com/moovweb/gokogiri/xpath) for a Go wrapper over the C libxml library.
Have fun!
Martin


update base url

Description & motivation
Fixes the base url for the site. This will update the sitemap which should help crawlers better find info!

Approved once you get a working build!


refactoring func invokeFunction

Description

Applying clean code to the invokeFunction function. The function was too large and had complexity problems, so functions and variables were renamed to better describe their purpose. In terms of modularity, the function was split into several smaller functions to improve readability and reusability. Finally, error handling has been assigned to a specific section.

Hi! I assume that this PR stems from some university course assignment in Clean Code software development? I'm all for that in theory, because I advocated and taught Clean Code myself for many years. In practice, this PR is a complete train wreck. Let me explain:
The code changes MUST have been submitted via PR without EVER testing locally. I know this because the CI/CD pipelines broke in literally all possible places at once. Tests broke, meaning that your code changes were not functionally neutral. You introduced 83 code linter errors, because your refactoring did not care about our code style conventions at all. You broke our Refactoring Safely Net (RSN) for one coding challenge, because you very likely weren't aware that this is something we even have.
In summary, this is a great example how even the most well meant actions can lead to the most ill effects. Clean Code requires knowledge of the context of the software. It also requires to follow the project team's guidelines, which is even mentioned in a chapter in Uncle Bob's book.
Most of my complaints could have been prevented by reading the contribution guidelines of the project, as those explain how to fully test locally, run the linters, run the RSN and more:
https://pwning.owasp-juice.shop/companion-guide/latest/part3/contribution.html
Long story short, this PR is unmergable as it is. If you'd like to give it a second try following the above mentioned guidelines, I'm happy to manually review it and give further feedback.


[IoT] add show-connection-string command for hub and device

Add below commands in IoT module to show connection string.
az iot hub show-connection-string
az iot device show-connection-string

@aovechki @ZhijunZhao @shizn

Also, please include the output of -h for these new commands (you can omit the global arguments). This is our standard practice with new command PRs.

>az iot hub show-connection-string -h

Command
    az iot hub show-connection-string: Show connection string of target Azure IoT Hub.

Arguments
    --name -n           [Required]: Target IoT Hub name.
    --resource-group -g [Required]: Name of resource group.
    --policy-name                 : The access policy you choose to use.  Default: iothubowner.

>az iot device show-connection-string -h

Command
    az iot device show-connection-string: Show connection string of a device in target Azure IoT
    Hub.

Arguments
    --device-id -d      [Required]: Device Id.
    --hub               [Required]: Target IoT Hub name.
    --resource-group -g [Required]: Name of resource group.


[Feature]: pinch zooming in and out of the graph on touchscreen

Feature Request
...atm it zooms the whole ui, not just graph area.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Are you on a MacBook?

Definitely can support this, I looked into it, but I'll need to get a development environment set up on my touch screen laptop in order to develop and test it, so it's pretty high-hanging fruit for now.

Oh I missed the "touchscreen" part of the title. We would have to verify other aspects of touchscreen as well, because you often need more touched states to interact with the UI. I agree it's extra work.

Are you on a MacBook?

i'm running chrome os


(<IP_ADDRESS>+) unable to connect to MySQL from outside container

Describe the bug
On versions <IP_ADDRESS> and <IP_ADDRESS> of dockware/dev container, I'm unable to connect to the MySQL from outside said container.
To Reproduce

Start a container with the following command:

> docker run --rm -p 3306:3306 dockware/dev:<IP_ADDRESS>

Attempt to connect to the MySQL database, using MySQL shell:

> \connect --mysql root@localhost -proot

Observe an error the following error is thrown:

MySQL Error 2013 (HY000): Lost connection to MySQL server at 'reading initial communication packet', system error: 0

Expected behavior
After step 2, you should be connected to the database with the following message:
Your MySQL connection id is 10
Server version: 8.0.32-0ubuntu<IP_ADDRESS> (Ubuntu)
No default schema selected; type \use <schema> to set one.

Desktop:

OS: Windows 11 22H2 (build 22621.1702)
Browser: N/A

Additional context

The issue occurs for versions <IP_ADDRESS> and <IP_ADDRESS>, but not <IP_ADDRESS>.
Attempting to connect through other means (say, DataGrip) produces similar results
Connecting from inside the container works perfectly, provided you run the mysql client as root

Can confirm. It was working fine in <IP_ADDRESS> but reinstalling today in <IP_ADDRESS> and suddenly no connection possible anymore from outside, e.g. via VS Code. "docker-compose.yml" is the same as before. The container exposes the correct port as well. Inside the container normal access is possible via Adminer.

hi
i did already fix it in the latest master.
ill try to push it soon :)i also need it

Hi there
<IP_ADDRESS> is now pushed and working
i have troubles getting the old 6.5.x to work
but once that is done its also working there
sry for the troubles

Tested in the brand new <IP_ADDRESS> release and it works great. Thanks!

perfect, thanks for letting me know :)


Add Windows Terminal theme

This is a port for Windows Terminal. I mapped colors from the .minttyrc file, with the following assumptions:

Bold* colors mapped to bright*
Magenta colors mapped to purple colors

Windows Terminal theme documentation can be  found here.
I was unsure on how to name the file. The Windows Terminal config file is settings.json. I kept the theme name and the extension as the other terminal files do, but added '-windowsterminal' to the file name to indicate the target terminal, since the extension doesn't help with that.

Thanks for your contribution! I was actually in the process of adding more terminals like WT, Kitty and Alacritty. I also ran into the same issue with naming, so I am planning to put them in subfolders like /terminal/windows-terminal/mysticaltutor,json. I'll merge your PR and do the renaming when I merge my changes.


MWPW-136372 - Fixing stuffs to make performance great again..

Thanks to @auniverseaway for the guidance on this.
Resolves: https://jira.corp.adobe.com/browse/MWPW-136372
Test URLs:

Before: https://uar-integration--milo--adobecom.hlx.live/drafts/xiasun/quiz-2/?martech=off
After: https://quiz-performance--milo--sabyamon.hlx.live/drafts/xiasun/quiz-2/?martech=off

Nice!


A bug occurred while running train.py

train.py is not running and encounters the following problems.
in pytorch 1.2
Traceback (most recent call last):
File "C:/Program Files (x86)/DM-Count-master/train.py", line 64, in
trainer.train()
File "C:\Program Files (x86)\DM-Count-master\train_helper.py", line 110, in train
self.train_eopch()
File "C:\Program Files (x86)\DM-Count-master\train_helper.py", line 126, in train_eopch
for step, (inputs, points, gt_discrete) in enumerate(self.dataloaders['train']):
File "C:\Anaconda\envs\py37\lib\site-packages\torch\utils\data\dataloader.py", line 819, in next
return self._process_data(data)
File "C:\Anaconda\envs\py37\lib\site-packages\torch\utils\data\dataloader.py", line 846, in _process_data
data.reraise()
File "C:\Anaconda\envs\py37\lib\site-packages\torch_utils.py", line 369, in reraise
raise self.exc_type(msg)
RuntimeError: Caught RuntimeError in DataLoader worker process 0.
Original Traceback (most recent call last):
File "C:\Anaconda\envs\py37\lib\site-packages\torch\utils\data_utils\worker.py", line 178, in worker_loop
data = fetcher.fetch(index)
File "C:\Anaconda\envs\py37\lib\site-packages\torch\utils\data_utils\fetch.py", line 44, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "C:\Anaconda\envs\py37\lib\site-packages\torch\utils\data_utils\fetch.py", line 44, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "C:\Program Files (x86)\DM-Count-master\datasets\crowd.py", line 124, in getitem
return self.train_transform(img, keypoints)
File "C:\Program Files (x86)\DM-Count-master\datasets\crowd.py", line 83, in train_transform
gt_discrete = gen_discrete_map(h, w, keypoints)
File "C:\Program Files (x86)\DM-Count-master\datasets\crowd.py", line 37, in gen_discrete_map
discrete_map = torch.zeros(im_width * im_height).scatter_add(0, index=p_index, src=torch.ones(im_width*im_height)).view(im_height, im_width).numpy()
RuntimeError: Expected object of scalar type Long but got scalar type Int for argument #3 'index'
Your work has given me a lot of help. Thank you very much. I really need you for this problem, and I hope to get your help.

please rewrite the crowd.py line37 into the "p_index = torch.from_numpy(p_h* im_width + p_w).to(torch.int64)"


Update classifiers

Also, now 2.6 is gone, replace function calls with set literals.
And add fix a typo in an assertIn which used to be an assertTrue.

Hi. Cool cleanup here. Really appreciated. I made a small comment. Once the change is made and the tests are fine, I'll merge this.

Coverage decreased (-0.5%) to 92.106% when pulling 4c24c8c99599601edd11e4a51ab48c915059020e on hugovk:update-versions into 5c839f1f7ed9c2af10da05dacf5d4d45bc8930ed on gccxml:develop.

Coverage decreased (-0.5%) to 92.106% when pulling 4c24c8c99599601edd11e4a51ab48c915059020e on hugovk:update-versions into 5c839f1f7ed9c2af10da05dacf5d4d45bc8930ed on gccxml:develop.

Coverage decreased (-0.5%) to 92.106% when pulling 4c24c8c99599601edd11e4a51ab48c915059020e on hugovk:update-versions into 5c839f1f7ed9c2af10da05dacf5d4d45bc8930ed on gccxml:develop.

Coverage decreased (-0.5%) to 92.106% when pulling 4c24c8c99599601edd11e4a51ab48c915059020e on hugovk:update-versions into 5c839f1f7ed9c2af10da05dacf5d4d45bc8930ed on gccxml:develop.

Coverage decreased (-0.5%) to 92.106% when pulling 4c24c8c99599601edd11e4a51ab48c915059020e on hugovk:update-versions into 5c839f1f7ed9c2af10da05dacf5d4d45bc8930ed on gccxml:develop.

Travis are running a bit behind at the moment, so patience needed :) https://www.traviscistatus.com/incidents/4vdl52d28hz3

@iMichka How does this look?

Hi. Sorry it took me so long ... I was busy with other projects. I hope I can finish the 2.0.0 release during the summer, so that the latest changes are released. Thanks for your contribution!


Generate seeds for every user in the feed

Seeds will always grab the same user from the API. If a randomly generated seed is used to generate a user, that seed can be attached to the user object and can be used later on in the app for things like a profile.

This might not be possible without making separate API calls for each user.

Not moving forward with this. Do not want to make so many calls to the random user API to make this happen. Once batch call is better.


Add 4.09 in Travis CI

Also, maybe it makes sense to deprecate a few versions? E.g. up to 4.05, since most distributions now provide at least 4.05:

Thanks!


AWS Sigv4 signer does not clear previously set headers

Title: AWS Sigv4 signer does not clear previously set headers
Description:
It seems that the AWS Sigv4 signer does not set previously set headers that are used for sigv4 signing (eg authorization, X-Amz-Security-Token, etc)
https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/aws_request_signing_filter
I'm unsure what the ideal behavior here is. It seems like either the filter should clear the headers that it needs for sigv4 header, or guidance should be given in the docs on how people can optionally set this behavior.
the issue is that setting any of the sigv4 headers from the client side will invalidate the sigv4 signature. In addition, retries do not work well when the signer is used as an upstream filter.
Repro steps:
This is particularly bad when used with retries + sigv4 signer as an upstream filter.

envoy config: https://gist.github.com/shulin-sq/4fcc25a9973ab8e6132708bcede14745
sample app: https://gist.github.com/shulin-sq/a74de03fab139ab2352d981be8db4631

# set some aws creds
export AWS_ACCESS_KEY_ID=... etc

# run envoy
envoy -c envoy-retries.yaml

# run simple go service
go run simple_srv.go

# hit retry
curl -vvv localhost:10000/retry
*   Trying [::1]:10000...
* connect to ::1 port 10000 failed: Connection refused
*   Trying <IP_ADDRESS>:10000...
* Connected to localhost (<IP_ADDRESS>) port 10000
> GET /retry HTTP/1.1
> Host: localhost:10000
> User-Agent: curl/8.4.0
> Accept: */*
>
< HTTP/1.1 502 Bad Gateway
< date: Sat, 06 Jul 2024 00:13:30 GMT
< content-type: text/plain; charset=utf-8
< x-envoy-attempt-count: 3
< x-envoy-upstream-service-time: 35
< server: envoy
< transfer-encoding: chunked
<
retry me
X-Amz-Region-Set: *
X-Amz-Region-Set: *
X-Amz-Region-Set: *
Accept: */*
X-Forwarded-Proto: http
X-Envoy-Expected-Rq-Timeout-Ms: 14967
Authorization: AWS4-ECDSA-P256-SHA256 Credential=ASIATVTSGYECX674RMVT/20240706/vpc-lattice-svcs/aws4_request, SignedHeaders=accept;host;user-agent;x-amz-content-sha256;x-amz-date;x-amz-region-set;x-amz-security-token;x-request-id, Signature=redacted,AWS4-ECDSA-P256-SHA256 Credential=ASIATVTSGYECX674RMVT/20240706/vpc-lattice-svcs/aws4_request, SignedHeaders=accept;authorization;host;user-agent;x-amz-content-sha256;x-amz-date;x-amz-region-set;x-amz-security-token;x-request-id, Signature=redacted,AWS4-ECDSA-P256-SHA256 Credential=ASIATVTSGYECX674RMVT/20240706/vpc-lattice-svcs/aws4_request, SignedHeaders=accept;authorization;host;user-agent;x-amz-content-sha256;x-amz-date;x-amz-region-set;x-amz-security-token;x-request-id, Signature=redacted
X-Amz-Content-Sha256: UNSIGNED-PAYLOAD
User-Agent: curl/8.4.0
X-Request-Id: 98a420c5-0bdc-4952-9e76-a82f1bfe5f73
X-Amz-Security-Token: some_string_3
X-Amz-Security-Token: some_string_2
X-Amz-Security-Token: some_string_1
X-Amz-Date: 20240706T001300Z
X-Amz-Date: 20240706T001300Z
X-Amz-Date: 20240706T001300Z

You can also do a simpler repro by just sending the authorization header separately. You'll see in this example that my "test" string is now part of the authorization header.
curl -vvv localhost:10000/headers -H "authorization:test"
*   Trying [::1]:10000...
* connect to ::1 port 10000 failed: Connection refused
*   Trying <IP_ADDRESS>:10000...
* Connected to localhost (<IP_ADDRESS>) port 10000
> GET /headers HTTP/1.1
> Host: localhost:10000
> User-Agent: curl/8.4.0
> Accept: */*
> authorization:test
>
< HTTP/1.1 200 OK
< date: Sat, 06 Jul 2024 00:19:22 GMT
< content-length: 1398
< content-type: text/plain; charset=utf-8
< x-envoy-attempt-count: 1
< x-envoy-upstream-service-time: 1
< server: envoy
<
X-Request-Id: c53227da-4d9b-42f4-b457-aab90f01f8b8
X-Envoy-Expected-Rq-Timeout-Ms: 15000
X-Amz-Content-Sha256: UNSIGNED-PAYLOAD
X-Amz-Date: 20240706T001900Z
X-Amz-Region-Set: *
User-Agent: curl/8.4.0
Accept: */*
Authorization: test,AWS4-ECDSA-P256-SHA256 Credential=ASIATVTSGYECX674RMVT/20240706/vpc-lattice-svcs/aws4_request, SignedHeaders=accept;authorization;host;user-agent;x-amz-content-sha256;x-amz-date;x-amz-region-set;x-amz-security-token;x-request-id, Signature=redacted
X-Forwarded-Proto: http
X-Amz-Security-Token: redacted
* Connection #0 to host localhost left intact

@nbaws

Thank you for your bug report! This issue will be addressed via https://github.com/envoyproxy/envoy/pull/35082 , which explicitly replaces (rather than appends) existing headers, and explicitly removes those headers which are going to be used in the signing process.
Documentation for this extension has also been updated to describe the behaviour of header modification/removal.

This PR has been merged, so you are free to test against latest dev build. Please let me know if you see any issues.


Do we need a BindResource field in BindingSpec?

The spec refers to a field in the binding request body called bind_resource: https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#body-5
This issue is to determine whether we need to have a user-facing field for this in the Binding resource.

Related to #818 - do we need to expose additional fields to the k8s data model to represent additional data we need to send to brokers?

I no longer this with is an issue, so I'm going to close it.  Anyone should feel free to reopen it if they believe there is some work to do and have a specific use-case formulation for it.


Fix deprecations and clean tests & CI

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.006%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
162

Relevant Lines:
167

💛  - Coveralls

Codecov Report

Merging #19 (c3f8b9d) into main (b1dba1c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   97.00%   97.00%
=======================================
  Files           4        4
  Lines         167      167
=======================================
  Hits          162      162
  Misses          5        5

Impacted Files
Coverage Δ

src/exact.jl
98.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1dba1c...c3f8b9d. Read the comment docs.


Using Beast in non-blocking style

Is it possible to use Beast websocket stream in non-blocking style?
i.e.
boost::system::error_code ec;
auto sz = stream.read(..., ec);
if (ec == boost::asio::error::would_block) {
   continue;
}

It might work, but I have never done any testing. It is on my to-do list (there's an open issue somewhere around here). If you would like to try it out and let me know, that would be cool. Don't forget to set the socket into non-blocking mode first.

@vinniefalco It's not work. I think it because any unsuccessful read (and maybe write) set stream status to failed and on the next read error_code become operation_aborted
see read.ipp read_some
    if(! check_open(ec))
        return 0;
loop:
...
            auto const bytes_transferred =
                stream_.read_some(
                    rd_buf_.prepare(read_size(
                        rd_buf_, rd_buf_.max_size())),
                    ec);
            if(! check_ok(ec))
                return bytes_written;
            rd_buf_.commit(bytes_transferred);

stream.hpp
    bool
    check_open(error_code& ec)
    {
        if(status_ != status::open)
        {
            ec = boost::asio::error::operation_aborted;
            return false;
        }
        ec.assign(0, ec.category());
        return true;
    }

    bool
    check_ok(error_code& ec)
    {
        if(ec)
        {
            if(status_ != status::closed)
                status_ = status::failed;
            return false;
        }
        return true;
    }

I think check_ok should ignore ec in case of boost::asio::error::would_block and boost::asio::error::try_again and maybe other errors (in case of SSL socket)

I think check_ok should ignore ec in case of boost::asio::error::would_block and boost::asio::error::try_again and maybe other errors (in case of SSL socket)

That sounds reasonable. Have you tried making this change?

    bool
    check_ok(error_code& ec)
    {
        if(ec)
        {
            if (ec != boost::asio::error::would_block && ec != boost::asio::error::try_again) {
                if(status_ != status::closed)
                    status_ = status::failed;
                return false;
            }
        }
        return true;
    }

This code fix the issue in my case (short messages via SSL stream). But I'm not sure it will work in other cases (i.e. big messages).
Also I'm not tested websocket write.
I will continue investigation

Sorry, it's not a fix.
read_some still loop inside
        while(! parse_fh(rd_fh_, rd_buf_, code))
        {
            if(code != close_code::none)
            {
                // _Fail the WebSocket Connection_
                do_fail(code, error::failed, ec);
                return bytes_written;
            }
            auto const bytes_transferred =
                stream_.read_some(
                    rd_buf_.prepare(read_size(
                        rd_buf_, rd_buf_.max_size())),
                    ec);
            if(! check_ok(ec))
                return bytes_written;
            rd_buf_.commit(bytes_transferred);
        }

check_ok should be
    bool
    check_ok(error_code& ec)
    {
        if(ec)
        {
            if (ec != boost::asio::error::would_block && ec != boost::asio::error::try_again) {
                if(status_ != status::closed)
                    status_ = status::failed;
            }
            return false;
        }
        return true;
    }

Sometimes a call to stream::read is going to need to perform write operations, how will we handle that case? What if the call to write returns "would block?" The way the code is currently structured, there's no way to restart the operation.

Looks like the same problem with stream::write and stream::handshake (i.e. sent half of message).
I think it's not possible without interface change.


Word countdown incorrect

When you set the type to Word and use the countdown it shows 1 remaining but after typing a space to then start to type the last word it prevents you from typing the last word and shows 1 remaining again.
Config used:
$(".sample").textcounter({
type: "word",
stopInputAtMaximum: true,
countDown: true,
countDownText: "Words Remaining: %d",
max: 250
});
If you enter 249 words it will show 1 remaining. You then press "space" (which it allows) and as soon as you type a character it will delete the character(s) typed along with the space and display Words Remaining: 1 again.

Hey, thanks for reporting this. Believe it should now be fixed in version 0.6.1 but let me know if you continued to run into any issues.


Document what contexts composite actions have access to

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
What part(s) of the article would you like to see updated?
Add in a section / column for composite actions which highlights what contexts are and aren't avaliable to them
Additional information
No response

tree
Turbulence on. 1==1
1--1
And.  .   S.    Z.
.   /|]
Okay.            . /
.
-----
__

``

Lmao sorry bored

tree
Turbines on. 1==1
1--1
And.  .   S.    Z.
.   /|]
Okay.            . /
.
-----
__

tree
Turbines on. 1==1
1--1
And.  .   S.    Z.
.   /|]
Okay.            . /
.
-----
__

👋 @toast-gear, sorry for the delayed reply. I'm pretty sure that composite actions have the same access to contexts as any other action has, so I'm not sure a docs update would be needed here. I'll double-check with the engineering team.

Hi!
I've created https://github.com/github/docs/pull/21596 to address the note that @lucascosti pointed out above. Thanks!


Logo Proposal

Hello, sir. I want to offer you something, do you need a new logo for your application? if you want i can make it.

Thanks, but I don't think a new logo needed.

Oke thanks you sir


Writing up Documentation as we go along

While not an absolute necessity for the paper submission, it would probably be helpful to start writing up docs as we go along (and still have a lot of the stuff fresh in our memory).
What am I proposing?

Deploy an initial readthedocs bare-bones documentation
Document new stuff as we along without looking at the form, or the finer formulation of the notes

I.e. we would basically have a bare-bones documentation with notes inside of it at the end, over which we can comb over after the paper submission to then have the actual documentation, and for which we can also adjust the style files etc.

Opened a first WIP pull-request to have an initial version of the documentation online. Will complete to mergable state later today.

@jcallaham @SamAhnert what do you think?

Sounds great to me and #48 looks good.  When we get to that stage (or maybe sooner) I can also make a more thorough pass at typing and docstrings, which will hopefully make the code more understandable with or without detailed docs.

Sound like a great idea to me too! Are there any dependencies we'll need installed to add to the documentation or to make sure our formatting is consistent between the three of us?

No dependencies, readthedocs builds the entire thing automatically periodically.
I think as long as Sphinx compiles, the docs will look sort of the same to the user. So no style-constraints :)


blob type to store images

I need to store images in sqlite, and currently using String field for it, how can use blob instead?

@7flash There's no API to do blobs, but I am actually working on it. But now we're debating with @honzasp whether the mapping type should be Blob or ArrayBuffer. What's your take on this @7flash?

Deno defines Blob as
type BlobPart = BufferSource | Blob | string;
type BufferSource = ArrayBufferView | ArrayBuffer;

class Blob {
    constructor(blobParts?: BlobPart[], options?: BlobPropertyBag);

    stream(): ReadableStream<Uint8Array>;

    text(): Promise<string>;

	arrayBuffer(): Promise<ArrayBuffer>;

    // ...
}

that means it can be instantiated by passing an instance of ArrayBuffer in constructor and have it extracted as arrayBuffer()
But, Blob type in MySQL is actually just text, therefore ".text()" should be called on each field of Blob type asynchronously before saving the item into database?

I see this as part of #1748 .

@BearLemma do we depend on adding reflection to do this right ?

@7flash with #1785 we've just landed the support for ArrayBuffer as entity field. I think it should be trivially possible to convert Blob to ArrayBuffer and store it that way. Is it going to solve your problem?

I am still storing images in String field.. is that very wrong? will it affect performance or anything if change to ArrayBuffer?

I can see that Blobs were implemented internally, but should I still keep using string type for images? When I try to define a Blob field in model, it doesn't seem to recognize it:
field 'image' in class 'FortyEight' is of unknown entity type 'Blob'


Slovak translation

Hi, I would like to help with Slovak translation. Can you add it to Crowdin? 🙂

Here you go: https://crowdin.com/translate/excalidraw/10/en-sk?filter=basic&value=0
Language picker label will be "Slovensky", I presume.

Thanks. I think more fitting label would be Slovenčina

Alright. Dealer's choice.

OK, I added translations.

Thanks, we'll merge it shortly.


Support Windows

File path documented here.

Windows users are welcome to use http://www.abelhadigital.com/hostsman/