[HOLD for payment 2023-08-07] [$250] Migrate InitialSettingsPage.js to function component

Class Component Migration
Filenames

[ ] src/pages/settings/InitialSettingsPage.js

type: React.Component
has state values: true
has refs: false
has context: false
lifecycle methods: componentDidMount

Task

We currently have some class components in our codebase that we would like to refactor to a function component.
Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
If you need additional guidance, please ask in #expensify-open-source
Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ed00725204fbc329
Upwork Job ID:<PHONE_NUMBER>372874240
Last Price Increase: 2023-06-26

⚠ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

I'd like to work on this issue when it goes to external

I would love to work on this!

Good catch, @0xmiroslav - @neonbhai is next on the list so shall we go with them?

I can work on this

I'd like to work on this issue.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01e385620a0a8f347c

I would like to work on this task.

I can do this in a day.

Hello
I would like to work on this issue

Just waiting on @thesahindia to review the PR!

@thesahindia PR is ready for your review. Thanks.

Bump @thesahindia!

Hi, @sophiepintoraetz @rushatgabhane I just fixed conflict. please check PR. Thanks.

Hi,  @sophiepintoraetz @rushatgabhane This task assigned me. right?
https://github.com/Expensify/App/issues/16281#issuecomment-1612296625

Yes, this task is assigned to you! Just waiting on @rushatgabhane to review the PR.

thanks!

Hi, @thesahindia @rushatgabhane Could you check this PR. Thanks.

@rushatgabhane - please can we get this PR reviewed? It's been a couple of weeks now!

Going on sabbatical, please reassign another engineer

Bumped in slack

Just assigning another engineer for the review - Daniel! (Ioni is on sabbatical)

sorry, i can't review this https://expensify.slack.com/archives/C02NK2DQWUX/p1690172449236119?thread_ts=1690171425.054239&cid=C02NK2DQWUX
asked another c+ to review the PR

Assigning myself.

i think there is small regression
cc: @mananjadhav @danieldoglas @yh-0218

Yes! @yh-0218 Can we please fix this? I did see and I thought we added this message recently for all cases?

Confirmation of payouts:
@yh-0218: $250 (I don't think these are eligible for timeline bonuses)
@mananjadhav: $250 (no timeline bonus)
@yh-0218 - I'll release payment once the regression is fixed (I've send you an offer in Upwork!)

@yh-0218 Can you add a new PR to fix the regression? It is a deploy blocker.

We should decrease the bounty here as there was a regression from this PR

I don't think we have a fix for this already? @yh-0218

Got it @danieldoglas Thanks for your reply.

@yh-0218 - we typically halve payments for introducing a regression - so the updated amounts are:

@mananjadhav = $125 - via NewDot request
@yh-0218 = $125 via upwork.

Ah, just realised we're subject to a regression period (@yh-0218 - you've been paid $125 already - let's hope another regression doesn't come through!)

I've raised a request on NewDot for myself.

payments done.

Reviewed the details for @mananjadhav. This is approved for payment via NewDot.


 Documentation and scripts are updated to reflect Go Modules usage.
Packages described in Glide are migrated to go.mod/go.sum files using exactly the same versions, however, since Go Modules are managing packages in a sightly different way, it has tainted vendor directory as well.

Good to have this use modules from 1.12 !
Did you run go mod vendor?

Good to have this use modules from 1.12 !
Did you run go mod vendor?

Indeed :-) And yes, I have ran go mod vendor!

@otaviof Adding a comment here as well.
These two files should be removed:
[1] https://github.com/openshift/source-to-image/blob/master/hack/godep-restore.sh
[2] https://github.com/openshift/source-to-image/blob/master/hack/godep-save.sh

I can't refer to the exact diff in the github UI because of too many file changes. So, I am posting here.
I saw these godep references locally which should be removed:
[1] https://github.com/openshift/source-to-image/blob/master/hack/install-tools.sh#L11
[2] https://github.com/openshift/source-to-image/blob/master/hack/common.sh#L211
[3] https://github.com/openshift/source-to-image/blob/master/hack/rebase-to-origin.sh#L62

/retitle WIP - Go Modules
This is great stuff - openshift/builder will need this for 4.3 when it too switches to use go modules

@DhritiShikhar just removed the scripts you've listed, please consider. Thanks for pointing them out :-)

@adambkaplan What's your take on removing hack/rebase-to-origin.sh? I could not identify where it's being used.

Looks good @otaviof

What's your take on removing hack/rebase-to-origin.sh? I could not identify where it's being used.

Pretty sure that is obsolete - we can drop it.

Echoing a conversation I had with @otaviof on Slack:
We try to adhere to OpenShift's conventions when it comes to updating dependencies. In general the rule is that an "update deps" PR should have up to 3 commits:

Commit titled bump(*):, with a note detailing the reason to update the dependencies. Only changes here should be related to code in the vendor/ tree and any change to files that define the dependencies (ex: glide.yaml).
(optional) Updates to generated code, if any. Typically marked as generated
(optional) An additional commit if any authored code needed to be changed to compile/run properly. In some cases this may include generated code.

This PR is a bit more complex since we're changing the machinery that updates dependencies. I would squash and isolate the changes as follows:

Commit with the changes to set up go mod
bump(*): commit with actual dep updates
Any "downstream" changes that needed to be made after deps were updated.

Thanks for the pointers, @adambkaplan. Changes applied, please consider it again :-)

@otaviof , can you remove the WIP ?

@adambkaplan @gabemontero Does this PR look good now? :)

I'll defer to @adambkaplan ... it is his call @sbose78

/approve

/lgtm
/hold
We're in the process of adding a prior commit to openshift/builder. Once that is in we can land this safely.

Bump.

/hold cancel
Bumps landed 😄

Haha! Thank you Adam!


Support for time logicalTypes

As per the Avro 1.8.2 spec (https://avro.apache.org/docs/1.8.2/spec.html#Date), there are a number of date/time related logicalTypes, which are serialized as int or long.
Currently fastavro supports conversions between:

datetime.date and logicalType date
datetime.datetime and logicalTypes timestamp-millis, timestamp-micros

I'd like support added for conversions between:

datetime.time and logicalTypes time-millis, time-micros

This seems pretty straightforward:
>>> t = datetime.time(13, 25, 9, 723743)
>>> int(t.hour * 3600000 + t.minute*60000 + t.second*1000 + t.microsecond/1000)
48309723
>>> t.hour *<PHONE_NUMBER> + t.minute*60000000 + t.second*1000000 + t.microsecond
48309723743

Done - https://github.com/tebeka/fastavro/pull/98
Waiting for approve :)


BatchNorm after pooling layer?

Hi,
During training, you add one batchnorm layer after the pooling layer, as https://github.com/quark0/darts/blob/master/cnn/model_search.py#L18. However, when testing the searched architecture, there is no batchnorm after pooling layer. Would you mind to let me know the reason?
Best Regards,

#10


python312Packages.sphinx-autoapi: 3.1.1 -> 3.1.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.sphinx-autoapi is: Provides 'autodoc' style documentation
meta.homepage for python312Packages.sphinx-autoapi is: https://github.com/readthedocs/sphinx-autoapi
meta.changelog for python312Packages.sphinx-autoapi is: https://github.com/readthedocs/sphinx-autoapi/blob/v3.1.2/CHANGELOG.rst
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.1.2 with grep in /nix/store/qs24625mzik0845kjrrczjnacada9vxc-python3.12-sphinx-autoapi-3.1.2
found 3.1.2 in filename of file in /nix/store/qs24625mzik0845kjrrczjnacada9vxc-python3.12-sphinx-autoapi-3.1.2

Rebuild report (if merged into master) (click to expand)

15 total rebuild path(s)

15 package rebuild(s)

First fifty rebuilds by attrpath

dnf5
khard
lbdb
python311Packages.sphinx-autoapi
python311Packages.sphinx-hoverxref
python311Packages.sphinx-notfound-page
python311Packages.sphinx-version-warning
python312Packages.sphinx-autoapi
python312Packages.sphinx-hoverxref
python312Packages.sphinx-notfound-page
python312Packages.sphinx-version-warning
rocmPackages.rocm-docs-core
rocmPackages_5.rocm-docs-core
rocmPackages_6.rocm-docs-core

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qs24625mzik0845kjrrczjnacada9vxc-python3.12-sphinx-autoapi-3.1.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.sphinx-autoapi https://github.com/r-ryantm/nixpkgs/archive/4435d6b904fe993dceeac3051087f1ebdcd146c8.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/4435d6b904fe993dceeac3051087f1ebdcd146c8#python312Packages.sphinx-autoapi

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qs24625mzik0845kjrrczjnacada9vxc-python3.12-sphinx-autoapi-3.1.2
ls -la /nix/store/qs24625mzik0845kjrrczjnacada9vxc-python3.12-sphinx-autoapi-3.1.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

31 packages built:

dnf5
dnf5.man
khard
khard.dist
lbdb
python311Packages.sphinx-autoapi
python311Packages.sphinx-autoapi.dist
python311Packages.sphinx-hoverxref
python311Packages.sphinx-hoverxref.dist
python311Packages.sphinx-hoverxref.doc
python311Packages.sphinx-notfound-page
python311Packages.sphinx-notfound-page.dist
python311Packages.sphinx-notfound-page.doc
python311Packages.sphinx-version-warning
python311Packages.sphinx-version-warning.dist
python311Packages.sphinx-version-warning.doc
python312Packages.sphinx-autoapi
python312Packages.sphinx-autoapi.dist
python312Packages.sphinx-hoverxref
python312Packages.sphinx-hoverxref.dist
python312Packages.sphinx-hoverxref.doc
python312Packages.sphinx-notfound-page
python312Packages.sphinx-notfound-page.dist
python312Packages.sphinx-notfound-page.doc
python312Packages.sphinx-version-warning
python312Packages.sphinx-version-warning.dist
python312Packages.sphinx-version-warning.doc
rocmPackages.rocm-docs-core
rocmPackages.rocm-docs-core.dist
rocmPackages_5.rocm-docs-core
rocmPackages_5.rocm-docs-core.dist

Maintainer pings
cc @karolchmist for testing.

Result of nixpkgs-review pr 325155 run on x86_64-linux 1

31 packages built:

dnf5
dnf5.man
khard
khard.dist
lbdb
python311Packages.sphinx-autoapi
python311Packages.sphinx-autoapi.dist
python311Packages.sphinx-hoverxref
python311Packages.sphinx-hoverxref.dist
python311Packages.sphinx-hoverxref.doc
python311Packages.sphinx-notfound-page
python311Packages.sphinx-notfound-page.dist
python311Packages.sphinx-notfound-page.doc
python311Packages.sphinx-version-warning
python311Packages.sphinx-version-warning.dist
python311Packages.sphinx-version-warning.doc
python312Packages.sphinx-autoapi
python312Packages.sphinx-autoapi.dist
python312Packages.sphinx-hoverxref
python312Packages.sphinx-hoverxref.dist
python312Packages.sphinx-hoverxref.doc
python312Packages.sphinx-notfound-page
python312Packages.sphinx-notfound-page.dist
python312Packages.sphinx-notfound-page.doc
python312Packages.sphinx-version-warning
python312Packages.sphinx-version-warning.dist
python312Packages.sphinx-version-warning.doc
rocmPackages.rocm-docs-core (rocmPackages_6.rocm-docs-core)
rocmPackages.rocm-docs-core.dist (rocmPackages_6.rocm-docs-core.dist)
rocmPackages_5.rocm-docs-core
rocmPackages_5.rocm-docs-core.dist


Bazel support

Creating this pull request just as a view to the diff.

So this codebase is a little hairy because it will now build one jar containing two gradle plugins, com.uber.okbuck and com.uber.okbazel. To build the jar run ./gradlew build -p plugin. This will build buildSrc/build/libs/plugin-0.8.5.jar.
Then in an android gradle project, you will need to add something like
buildscript {
    repositories {
        flatDir dirs: '/path/to/okbuck/buildSrc/build/libs'
    }
    dependencies {
        classpath 'com.uber:plugin:0.8.5'
        classpath 'com.android.tools.build:gradle:2.2.1'
        classpath 'org.apache.maven:maven-artifact:3.3.9'
    }
}

If you change the name of plugin-0.8.5.jar to okbuck-0.8.5.jar or okbazel-0.8.5.jar, then you can use that name instead of plugin in the classpath dependency. Note that the last two classpath dependencies are needed due to libraries that I think are configured wrong in okbuck that don't make it into the deploy jar. I should probably file an issue with okbuck about that.
Then, later in your build.gradle, you can add apply plugin: 'com.uber.okbazel' or apply plugin: 'com.uber.okbuck'. Note that you can only do one of them. This is because they both try to register the plugin name "okbuck". I did this because many of the core classes in okbuck rely on the plugin name being "okbuck". I'm not sure if those call sites can be changed to accept either okbuck or okbazel.


Temporarily removes syndicate expeditions from salvage

Short description
title
Why we need to add this
Salvage syndicate expeditions just cause a lot of issues at the moment (powergaming, bug abuse, validhunting, self antag, open play), and this is just a temporary removal until a proper solution is added
Media (Video/Screenshots)

Checks

[X] I do not require assistance to complete the PR.
[X] Before posting/requesting review of a PR, I have verified that the changes work.
[X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
[X] I affirm that my changes are licensed under the Starlight Fork License and grant permission for use in this repository under its conditions.

Changelog
:cl: PubliclyExecutedPig

remove: Temporarily removed syndicate expeditions from salvage

@Rinary1 fixed


Add support for Python 3.10

Python 3.10 has been released on 4 Oct, 2021.
We can add support for it.

oh, this image is not yet available.I'll leave it here :)

The image is available now. However, the build fails.

There are some incompatibilities with python 3.10 and older versions of pytest 1. The problem may be there...

As we moved to GHA and 3.10 tests were included there, this PR can be closed. Thanks for the initiative @laysauchoa


Codecov Report

Merging #231 (4940b3d) into main (857e448) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   99.69%   99.69%
=======================================
  Files         109      109
  Lines        1316     1318    +2
  Branches      153      153
=======================================
+ Hits         1312     1314    +2
  Misses          4        4

Impacted Files
Coverage Δ

src/containers/myInfo/ProfileSettingContainer.jsx
100.00% <ø> (ø)

src/components/base/DropDown.jsx
100.00% <100.00%> (ø)

src/components/base/UserHeaderStatus.jsx
100.00% <100.00%> (ø)

src/components/myInfo/ProfileSettingForm.jsx
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 857e448...4940b3d. Read the comment docs.


[Improvement] Stop spamming "Please Activate IME"

Giving users an easy option to switch keyboards is a good idea. However, it's currently a little much. To try it out, do this:

Set an other keyboard to be the currently used one.
Here's when the "Please Activate IME"-Popup gets triggered:

When opening the app (which is the one popup that makes sense)
When re-opening the app after having it run in the background (annoying but not a stupid decision)
When clicking on "Share 8Vim" and then pressing the back-button to get back to the app
When clicking on "Help & Feedback" and then pressing the back-button to get back to the app
When clicking on "Resize Circle" and then pressing the back-button to get back to the app
When clicking on "Set Circle Center" and then pressing the back-button to get back to the app
AFTER UNLOCKING THE SCREEN (this is the most annoying one I think)
When rotating the screen. (Please don't do this to users)

I suggest removing all those triggers except for the first one (opening the app). Instead, I suggest a "Switch keyboard" -button being placed somewhere within the app.
Also, normal users may not know what an "IME" is. I certainly don't. I suggest going for the fool-proof version of "Please Activate 8Vim"
Anyway, good job so far!  : )
(Tested on iteration-5)

Very valid point!! I seem to have missed it because 8vim is my perpetual keyboard.
Adding this as a bug. Thanks for the report.

@Glitchy-Tozier , Can you please verify if this is still an issue on iteration-6?
This seems to have been fixed as part of some other change.

Yeah, funnily enough it seems to be gone!


Book GTU on Lane only with reference point

The GTU is now booked on multiple longitudinal lanes at lane connections. This leads to difficult and often faulty situations. Instead, a GTU could be booked with only its reference point on a single Lane (or possibly two in case of a lane change). This will severely reduce the complexity of the code.

After studying this, it does not seem worth it to try to make this simplification. it is a LOT of work, but in essence, the code will remain broken after implementing this change, since it is still a booking system and therefore does not remove the inherent issues with such a booking system. For now, this issue will be closed, but may be revived at another time.
We have to address this on a much more fundamental level...


Config UI Refactor - Connection Limiting & Integration Bugfixes

Connection Limiting and use $ID Primary Key

WIP DO NOT MERGE

Key Points

[x] Implement Connection Limit Feature so that providers w/o Multi-data support can be restricted until backend is able to offer these features.

JIRA Supports Multiple Connections
Jenkins and Gitlab Limited to 1 Connection Only
Add Connection Functionality LOCKED when limit reached

[x] Use $ID as primary key parameter for connection sources
[x] Fix Loading of JIRA Settings
[x] Update Connection Manager Hook

Add routine for fetching All Connections
Add Logic for Connection Limiting

Description
This PR is to continue the Configuration UI Refactor with regard to Multi-data connection sources UX. As JIRA is the only provider at this time that supports multi-connection sources, a connection limit feature has been added so that Gitlab and Jenkins will have restricted modes limiting them to only 1 instance.
Screenshots

LGTM


Transform Object.assign with Babel in .babelrc

Replaces Object.assign with an inline helper
Not sure if #85 used to work, but adding the plugin to the .babelrc applies the transform as expected

@tajo,
In GitHub it seems that tag v5.5.0 has this implemented.
I downloaded v5.5.0 from npmjs and looking into node_modules and it looks like lib/index.js line 107 is not extending. I don't think it's an implementation issue, I believe that libs for that tag weren't rebuilt correctly before publishing to npm.

Support ie11?


NoSuchMethodError:  Class List' has no instance method 'retype'

Thank you for taking the time to file an issue!
In order to route, prioritize, and act on this as soon as possible please include:

[2.0.0-dev.63.0] Dart SDK Version (dart --version)
[5.0.0-alpha+14] AngularDart Version (i.e. 4.0.0, 5.0.0-alpha+5, MASTER)
[Linux] Whether you are using Windows, macOS, or Linux (if applicable)
[Chrome] Whether you are using Chrome, Safari, Firefox, Edge (if applicable)
[ ] Any other packages or constraints we should know about

[FINE] angular on lib/app_component.dart:Running Instance of 'Compiler'
[SEVERE] angular on lib/app_component.dart:
Unhandled exception in the AngularDart compiler!
Please report a bug: https://github.com/dart-lang/angular/issues/new
NoSuchMethodError: Class 'List' has no instance method 'retype'.
Receiver: Instance(length:1) of '_GrowableList'
Tried calling: retype()
dart:core                                                                       Object.noSuchMethod
app_component.dart
class AppComponent implements OnInit {
final Routes routes;
final Router router;
var routeData;
final name = "Angular Council";
AppComponent(this.routes, this.router);
Storage sessionStore = window.sessionStorage;
@override
ngOnInit() {
sessionStore.clear();
this.routeData = routes.getRouteData();
}
}
routes.dart  - getRouteData Method:
getRouteData() {
var routeData= Map<String,String>();
for (var route in all) {
if(route.additionalData == "Home") {continue;}
if(route.additionalData == null || route.additionalData == "") {continue;}
routeData[route.additionalData] = route.toUrl();
}
return routeData;
}

Duplicate of https://github.com/dart-lang/angular/issues/1406.
This is fixed in the latest version, +15, or you can downgrade to an older SDK to continue using +13.


WIP - rspec-puppet 2.0 updates and future parser fixes

This includes a hack to make the future parser work with stdlib 2.x since this module depends on it, and updating it would require a major version bump. It is not very pretty and I'm very open to removing it and waiting for a major update or finding a better way to do it.

Mm. Since we haven't had any complaints yet about officially supporting stdlib2 but having stdlib2 incompatible things in apt I'm inclined to say "screw that, lets continue flying under the radar". I'd be very happy to merge the rest of the commits though, that's a rather huge help.
@mhaskel what do you think?

Abandoning rspec-puppet 2.0 changes since it doesn't seem feasible right now, and abandoning inline_template changes since it's terrible. Future parser and lint fixes in #421 and #422.


Protobuff serialization/deserialization -  Array enums should be supported as they are in .proto

📝 Summary
Write a short summary of the bug in here.

Typia Version:  @latest
Expected behavior:  Enum arrays supported in typia.
Actual behavior:  Enum arrays not supported in typia.

Write detailed description in here.
Given the follow .proto type.
message MovieReleaseTypeCriteria {
  enum MovieReleaseType {
    WIDE_THEATRICAL_RELEASE = 0;
    LIMITED_THEATRICAL_RELEASE = 1;
    HOME_ENTERTAINMENT_STREAMING_ONLY_RELEASE = 2;
  }
  repeated MovieReleaseType releaseTypes = 1;
}

The generated Typescript code models this type correctly.
  enum MovieReleaseType {
    WIDE_THEATRICAL_RELEASE = 0,
    LIMITED_THEATRICAL_RELEASE = 1,
    HOME_ENTERTAINMENT_STREAMING_ONLY_RELEASE = 2,
  }

interface IMovie {
  release: Array<MovieReleaseType>
}
typia.protobuf.encode<IMovie>({
  release: [MovieReleaseType.WIDE_THEATRICAL_RELEASE]
})

Trying to produce serialize/deserialize this type with typia results in the following error:
"does not support union type in array"

This can be fixed by creating separate models for typia AND the .proto representation; I want my enums to work application side so I create a separate type with release: Array<number>. However the ideal behavior is that when Typia discovers an Array of a single type union (all strings or all numbers or a string enum or number enum) then it should simplify the resolution to follow Array or Array semantics.
Without this it makes Typia significantly harder to use because it's purpose is to avoid double declaration, However to use .proto I need to declare multiple types to get typia working properly.
⏯ Playground Link
https://typia.io/playground
Visit above playground and write code occuring the bug.
After that, copy and paste link address of that.

Example Link

> https://typia.io/playground/?script=JYWwDg9gTgLgBDAnmYBDOAzKERwERIqp4DcAUGcAHYwCmUGqAxrXAJICytIARvXAG8ycEXAD0AKglxhouNIACGaCFTwAruuAATGXPli9onQC44AZxhRqAc3KyRk6Q5GLlUVfG6pgAGyOiEoYu3n5mltZUdhRyTi7ycAqErFo08Yog1KDquABMAAzpibQAHky+6ubAAG60HKgl2bgAjPmF+kEuqDa0ZlQ5fFDkcmCoULQ0Zpzcg3AAPnD9vr7DokwAFn7a41RTXLz0ANoAuuQAvhRiYgC0t9dkV+wAyg83d2SEaAB0TONqtGxzAAeaYHKAAPgAFABKchAA

💻 Code occuring the bug
import typia, { tags } from "typia";

  enum MovieReleaseType {
    WIDE_THEATRICAL_RELEASE = 0,
    LIMITED_THEATRICAL_RELEASE = 1,
    HOME_ENTERTAINMENT_STREAMING_ONLY_RELEASE = 2,
  }

interface IMovie {
  release: Array<MovieReleaseType>
}

typia.protobuf.encode<IMovie>({
  release: [MovieReleaseType.WIDE_THEATRICAL_RELEASE]
})

Upgrade to v5.5.4, then be fixed.

@samchon absolute legend what a turnaround.
Have some more proto related tickets so will create them here. I'm building a gRPC client for node as hopefully a better successor to grpc-js and planning on utilizing typia.


Basic Hateoas, schema validation, codes have strong link to KLASS codes

Validation
We now validate on POST and PUT of Series and Versions whether only fields that are defined in the schema are present. We also validate that all required fields are present before sending to LDS.
HATEOAS
Series now have a link to self. "_links":{ "self":{"href":"/v2/subsets/{seriesId}"} }
Versions now have a link to self. "_links":{ "self":{"href":"/v2/subsets/{seriesId}/versions/{versionId}"} }
For now I wanted the links to be independent of the server address. We can discuss this.
The list of Versions in a Series contain the same links as the versions have to themselves.
Strong 1-to-1 connection to KLASS codes
Codes now have a pointer to the classification version they belong to: "version": "https://data.ssb.no/api/klass/v1/versions/473". I chose to include the whole URL to the classification version just to make sure it's explicit that this is not "our" version of the code, it is the version of the classification the code belongs to. The link to the versions is found by using the validFromInRequestedRange at the time the Version is submitted to find which version at the time has a validity period that contains that date. Calculating which version the selected code belongs to at the time of submission gives us a theoretically unbreakable 1-to-1 connection between our stored code and the equivalent KLASS code. This means we have a specific validFrom and validUntil that is not dependent on the valid[....]InRequestedRange values. The validFrom of a version can never change, so I store that in the code as well.
Schema changes required
In order for these changes to work, we should change the LDS schema again. I hope that's all right!

I realized I probably made a little mistake: I add some of the self-links at POST time instead of at GET time. I realized now that it's probably better to add self-links at GET time, to guarantee that the returned data will be correct even if something changes in the API design.


Is an AppImage forthcoming?

Would papirus be available as an AppImage at some point?
I really like the idea of an open source WYSIWYG Markdown editor by I'm not inclined to install another framework like appwrite to try out papirus.

Appimage? Do you mean Linux Appimage format? I think it's not possible since Papirus was a web app, not a desktop app.
Technically, it's possible to self-host Papirus on your machine. But you'll need Appwrite running on your device.
I know it's not an elegant way to self-host the app, and in the future, I plan to make the self-hosted version of Papirus, using SQLite as a database and packed on container images for easy deployment.
Just stay tuned for the upcoming updates!

Yes I mean the Linux AppImage format. The appnativefy  tool can wrap up a URL and create an AppImage. Of course any backend dependencies of the webapp would still have to be available on the Internet. So Papirus as an AppImage would not really make it standalone.
I look forward to a standalone version of Papirus.


Update concept-identity-protection-risks.md

Password spray detection addition

@elkuzmen : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @elkuzmen - This PR was opened in the public repository. We’ll leave this PR for review in the public repo, but would you make future article updates in the private repo?
In the private repo, content benefits from automated validations, a content staging environment, and comprehensive PR reviews. Also, you can sign off directly in your PR (in the public repo, you can't sign off in your own PR), and many PRs qualify for auto-merge.
To edit an article in the private repo from within the documentation, after you select Edit on an article page,  add “-pr” to the repo name in the URL.
SpineEdit is a Chrome extension that opens the edit option in the private repo, if there is one and if you have access to it.
Thanks!

Related links in the internal Microsoft Docs contributor guide:
Public vs. private repos | Move a commit to a different repo (public -> private) | GitHub for content reviews
Quick reference for contributing to the docs | Make changes to a Docs article | PR review quality criteria-

#please-close


Legacy question

I am confused on this new delivery method. What does it mean there's a legacy wrapped php cli inside? Is there a way for me to choose one or the other? Are new features going to be implemented in go? Is the go cli also open source? where's the code for it
Thanks!

I'm also confused about why the code isn't here in this repo.

Hello
The new CLI indeed embeds both PHP and the legacy CLI. The goal of this is to get rid of dependencies, especially for people who are not using PHP for their apps 🙂.
The PHP CLI standalone will be deprecated and all new features will be implemented in Go.
Regarding the Go code, it should become open source eventually, it's only a matter of time. I expect to be able to publish the code before the end of 2022.
I hope this clarifies 🙂


Fix parameters type for inserting transactions

If we POST an array of transactions to https://dev.lunchmoney.app/v1/transactions via query parameters, this fails. POSTing the array in the body works as expected.

Thanks @Daynil!


Fail with proper message if you use upgrade in manifest mode.

Currently you get:
➜  vcpkg git:(master) vcpkg upgrade --no-dry-run test
error: The upgrade command does not currently support manifest mode. Instead, modify your vcpkg.json and run install.
/Users/leanderSchulten/git_projekte/vcpkg-tool/src/vcpkg/commands.upgrade.cpp(49): unreachable code was reached

Which is imo not the optimal message to be shown to the user.
In the past msg_exit_maybe_upgrade was used, but since I don't expect that upgrade will ever work in manifest mode I decided to use msg_exit_with_error.
Now:
➜  vcpkg git:(master) vcpkg upgrade --no-dry-run test
error: The upgrade command does not currently support manifest mode. Instead, modify your vcpkg.json and run install.

Shouldn't upgrade in manifest mode not actually redirect to normal install in manifest mode? I mean manifest mode autoupdates the installed tree any way.

Shouldn't upgrade in manifest mode not actually redirect to normal install in manifest mode? I mean manifest mode autoupdates the installed tree any way.

We could redirect to x-update-manifest when the experimental tag comes off of that, but I don't think upgrade should do that.

Thanks!


Navigate version history on a per-file basis

One way to explore the history of a particular file:
Loop through hyperdrive version numbers, starting with the current version and going backwards. Check if drive.diff(...) returns non-null (we could use a HEAD request for this?). If so, checkout that version and display the file at that version or inform the user that the file didn't exist before that version.
What about the edge-case where a file was created, deleted, then created again? Can we just continue checking back in time until we get a non-null diff or we get to the beginning of the history?
Do you know of a better approach? I imagine that sending a new HTTP request to hyper-gateway on each loop could be slow.

Hmm, not sure if HEAD would make sense here.
Let me think about diffs for a week or two.

To accomplish this, we could extrapolate on the ideas discussed here and here.
If the latest version of the drive is version 100 and user wants to checkout the version of /example.txt before the last change, send a GET request to hyper://public-key/$/previous/100/example.txt. Assuming that the most recent different version of /example.txt is version 42, this would have the same effect as GET hyper://public-key/$/version/42/example.txt. A HEAD request should return just the headers, allowing for a quick overview of the version history of particular file, including file sizes, modification dates, and version numbers.
Going forward through version history, GET hyper://public-key/$/previous/42/example.txt should give version 43. GET hyper://public-key/$/previous/42/example.txt should give version 100 (current).

To get a diff we can use the ETag versins returned on a HEAD for a file.

Get the current version of the drive
Loop
HEAD on the hyper://key/$/version/${version}/${file_path}
If 404, break the loop
Get whatever file info you need from the HEAD response and log them
Set version to the ETag


Thousands of ubsan failures starting from build gRPC_master 17118

https://grpc-testing.appspot.com/job/gRPC_master/17118/
New commits in this build:
Fix undefined behavior (commit: 525654a164a8862e14de913753100345932af2fc) (detail)
Fix some ubsan issues: I fear no bugs were harmed in the making of this (commit:<PHONE_NUMBER>7ab5d67278365b3bd444960fa3c4c0) (detail)
Refactoring the core security code. (commit: 8ca294e417217e1577609052f18df84be437c03c) (detail)
clang-format (commit: 19cd009ec14c1a759fe4d0ef79eb3fab738137ca) (detail)
Fixing headers. (commit: 2b2f414dd1cb3d1f72c8f2713e381f1bb260b3f7) (detail)
clang-format (commit: 93dd0470cf26aed445b40a8b9332e6b06f5e5514) (detail)
"taking a this" -> "taking this" typo correction (commit: 824ad2a5b9943c35933a675688634c2f152fd340) (detail)
Revive throughput tests . (commit: 3fe694fa35a35f753249ea55a43de3bd01c053d5) (detail)

@yang-g

#6423 seems to be related to ubsan?

It is not clear to me why that PR triggers the failures,  maybe halt_on_error is enabled? I am looking at the failures and adding a ubsan_suppressions.txt.

I just disabled the ubsan test on grpc_master.


can i make pull request to include laravel spark installer?

Hi ive already added laravel spark installer in my laradock,
hope the admin , will have interest in adding it up...
if yes i will make a pull request thank you

Hi there @codeitlikemiley! That sounds like a great idea: I'd would like to see Spark supported in Laradock. Thanks in advance.

im building it now ill try to make a pull request later...

Keeps us updated @codeitlikemiley , I am currently building my first Spark app via Laradock. If it is finished, can you perhaps post a quick tutorial to get us started? Thanks in advance.

Hi @codeitlikemiley !
Is there any updates for this issue?


Reopen PMID 33143745 for full metadata+sumstats submission (without deleting existing curated studies)

Background
We have already manually curation 12 studies for PMID 33143745 - this was done manually in the curation interface, so there are no submissions involved, and they are now in production with curation status=“Publish study”.
The author would now like to submit summary statistics: not for the current 12 studies, but for 20 additional studies belonging to the same publication, which we did not curated.
We would like to keep the existing curated studies (without sumstats) and also allow the user to submit the additional studies (with metadata and sumstats).
Proposed steps

Delete the current invalid sumstats-only submission
Change the status of the publication in deposition to OPEN_FOR_SUBMISSION (so even though there are 12 curated studies already in the production database, the publication will appear in deposition as if no curation has been done)
The author makes a new metadata+sumstats submission with a blank submission template and provides metadata and new sumstats for the 20 additional studies
We import the new metadata+sumstats submission into the curation interface. Because the existing 12 studies were created in the curation interface and did not come from a submission, we think that they will not be deleted, but will change status to “Requires Review”. We want to keep these studies, so need to make sure they would not be wiped.
A curator can check the new imported studies and then make sure all 12 + 20 studies are set to “Publish study” so they should all appear in production.

Developer tasks requested

Steps 1 and 2 above
Confirm that the existing 12 manually-curated studies will not be deleted if we import a new metadata+sumstats submission (step 4)
Check if there are any other concerns/consequences of the proposed plan that have been missed

This is the current invalid submission: https://www.ebi.ac.uk/gwas/deposition/submission/61ad073606ff200001926304

@Elliot W.r.t Step 4 the studies will be deleted as they have been assigned GCST , As per the logic while designing Depo Curation we had decided to identify the studies as pre Deposition if they are not assigned GCST Ids

Ok thanks @sajo-ebi ...
@earlEBI that is a bit of a problem, but hopefully we can get around it. Do you think we can save all the data for the current studies and add them back in as an edit to the submission template later in depo-curation?

@eks-ebi ok, am happy to do that. I've downloaded the associations currently in the Catalog and also the study info so shouldn't be difficult. Happy for steps 1 and 2 to go ahead from my POV.

Nice, thanks @earlEBI! I agree - @sajo-ebi feel free to go ahead with steps 1 and 2 when you're able to

@earlEBI @eks-ebi Only concern will be new GCST Ids will be assigned for the old studies once they are submitted using Deposition App, will that be fine with you ?

@sajo-ebi we agree that it should be ok for the old GCSTs to be replaced, as they were not attached to any sumstats and are therefore unlikely to have been used for anything by the author

@earlEBI @eks-ebi the pubmed Id is now open for submission & the invalid submission has been archived

brilliant, thanks @sajo-ebi! I've confirmed that it is open in deposition. I'll keep this ticket open to track the curation side of the process @earlEBI

@earlEBI Can we close this ticket now? I see that the publication is now OPEN FOR SUBMISSION in deposition. I think we are now waiting for the user to resubmit, right?

@eks-ebi yes... I thought we'd have to keep resetting to 'open for submission' if there was a syncing issue with curation app... but it does seem to have remained open overnight. So I think this is done for now, yes.


DREF Exports > Needs (Gaps) Identified, Targeting Strategy : Move the Assessment Report and Supporting Document hyperlinks below the section title

Task description
Move the Assessment Report and Supporting Document hyperlinks below the section title and align it with the previous title. Maybe changing it to blue will also help.
Marco's feedback
In the Needs/Gap Section, add he hyperlink to the assessment report below the section title and aligned with the previous point, make it more visible. Maybe changing it to blue will also help. When clicking on it, pop out a new tab, so the user doesn’t need to go back to the previous page to continue on the export. Same for targeting strategy supporting documents
Screenshot

When clicking on it, pop out a new tab, so the user doesn’t need to go back to the previous page to continue on the export. Same for targeting strategy supporting documents

The problem cannot be implemented as it is a web browser-related issue.


[SIL Diagnostics] Fix undefined behavior due to bit shifting in ConstantFolding.cpp

Cherry picking changes from Swift master for the bug fix.
rdar://48605307

@swift-ci Please test and merge

@swift-ci Please test and merge

@swift-ci Please test and merge

@swift-ci Please merge


MODELIX-640 Handle large modules in bulk sync

The bulk sync failed for large modules as the json exceeded the string size limit.
Now we use streams instead, to handle this case.
Apart from that this PR includes several significant performance improvements for the bulk-sync.
Additionally, the legacy MPS solution bulk-model-sync-solution is removed.
Also fixes MODELIX-615

@slisson I had to force-push this, since the linter didn't like your performance commit prefix.
Your commits look good to me, I only changed the doc a bit.
Seems like the serialization changes broke sth though, could you take a look at that?

:tada: This PR is included in version 3.17.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Help] PlutoGrid via bloc pattern?

I wonder if its possibe to control the PlutoGrid using a bloc pattern where all is about re-rendering widgets when its underlying state changes ... its very hard to find an entry point for manipulating stuff, since for Example a PlutoRow isn't a widget which can be rendered on change ... instead, PlutoGrid comes with its own state manager ... any idea where to hook in or if its even possible? Any resources to this?
Thanks a lot!

Up?

Seems its not very active here. Honestly, even in the meantime i don't know how one would integrate this in a more advanced app architecture. I really like this package, but unfortunately, I am forced to go with another solution, since the data table would cover a large field of my app.

It's crucial to efficiently implement a large list and dynamically change the items within it. I have the same question: Has anyone found a solution to this problem?

How did you solve your issue @codakkk @IntCleastwood ?

Seems its not very active here. Honestly, even in the meantime i don't know how one would integrate this in a more advanced app architecture. I really like this package, but unfortunately, I am forced to go with another solution, since the data table would cover a large field of my app.
@IntCleastwood @sinhpn92 @codakkk
seems that the mainteined version is https://github.com/doonfrs/pluto_grid_plus


Unclear instructions in step 3.

It is unclear how or where to start putting any code to test and play with the same code. The documentation from step 2. goes from importing the sample DB into MS SQL Server to putting code somewhere. Do I use VS code or Command Prompt? Do I put it into SSMS? Where do I put it?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 41b87895-135f-4e2c-1828-ed25d8fa0d80
Version Independent ID: 72de0fff-f0ba-5362-754b-1e15b1044ce7
Content: Step 3: Connecting to SQL using Node.js - Node.js driver for SQL Server
Content Source: docs/connect/node-js/step-3-proof-of-concept-connecting-to-sql-using-node-js.md
Service: sql
Sub-service: connectivity
GitHub Login: @David-Engel
Microsoft Alias: v-davidengel

@Reaper-123 -- thank you for your feedback and questions.  Please consider these resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@David-Engel -- please look into this issue.


Updated information on device control and users

Added a section on user groups
Added information on differences between local groups and Entra Id groups
Added information on best practices for targeting policies in Intune

Device control policies in Microsoft Defender for Endpoint | Microsoft Learnhttps://learn.microsoft.com/en-us/microsoft-365/security/defender-endpoint/device-control-policies?view=o365-worldwide&tabs=Removable
I'm not seeing the content in the article.....how long does this take to be visible or learn.microsoft.com?
JB

From: Denise Vangel-MSFT @.>
Sent: Tuesday, April 9, 2024 5:34 PM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Josh Bregman @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Updated information on device control and users (PR #13474)
Merged #13474https://github.com/MicrosoftDocs/microsoft-365-docs/pull/13474 into public.
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/microsoft-365-docs/pull/13474#event-12413223477, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AW55WMAXMP65FT2ELIL3JATY4RNHNAVCNFSM6AAAAABFJ7FKZWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGQYTGMRSGM2DONY.
You are receiving this because you were mentioned.Message ID: @.***>

It will be visible around 10:30 am PST time


image uploader always send null to the server

Hi !,
I have a problem with the uploading, it doesn't send the file to the server, it sends null instead.
this is my script:
        var editor = new MediumEditor('.editable', {
            toolbar: {
                buttons: ['bold', 'italic', 'underline', 'h1', 'h2','pre']
            },
            buttonLabels: 'fontawesome'
        });

        $(function () {
            $('.editable').mediumInsert({
                editor: editor,
                addons: {
                    images: {
                        label: '',
                        preview: false,
                        captions: false,
                        fileUploadOptions: {
                            url: 'submit/blog/upload'
                        }
                    }
                }
            });
        });

thank you so much for this amazing plugin.

Can you reproduce this problem on codepen, jsfiddle or similar service? Without that it's really hard to figure out, where the problem might be.

Beacause the image upload progress not finished!


Remove adobe-photoshop-lightroom

The system_command uninstall calling brew is broken.

he’ll probably want to port this over to his adobe casks repo

😅  Not really! Particularly, given that I don't use it… although it should probably technically be in there.
If one of you wants to offload it in the form of a PR and it passes the CI, then I'll merge it.
Also, would this problem not be solved with the following?
uninstall_preflight do
  system_command "#{HOMEBREW_PREFIX}/bin/brew", args: ['cask', 'uninstall', 'adobe-photoshop-lightroom600']
end

Also, would this problem not be solved with the following? ...

Yep, thanks! Guess we can keep this until the next time it breaks.

since calling brew recursively in a Cask is a pretty ghetto workaround to begin with

Agreed, I now regret having adding it to virtualbox

This should be fixed in SystemCommand

I think this is the third or forth time filtering #{HOMEBREW_PREFIX}/bin has been an issue, should we disable it completely for Cask rather than specific cases when needed?
Having #{HOMEBREW_PREFIX}/bin filtered for some cases and not others is inconsistent and somewhat confusing.


chore: fibers improvements

Fix debug crash when a machine suspends and tsc is reset.
Improve a fiber test
Fix warnings.

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7824c85) 78.75% compared to head (d48e744) 78.73%.

Files
Patch %
Lines

util/fibers/detail/scheduler.cc
33.33%
2 Missing :warning:

util/fibers/epoll_proactor.cc
50.00%
1 Missing :warning:

util/fibers/uring_proactor.cc
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   78.75%   78.73%   -0.02%
==========================================
  Files         100      100
  Lines        7335     7347      +12
==========================================
+ Hits         5777     5785       +8
- Misses       1558     1562       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


App re-render 3 times when I added amp character to pug template

My Express app is like this:
app.ts
import express from 'express';

const app = express();
app.set('view engine', 'pug');

app.get('/', function (req, res) {
  console.log('Render index');

  res.render('index', { title: 'Hey', message: 'Hello there!' })
})

index.pug
html(amp)
  head
    title= title
  body
    h1= message

The funny thing is the console.log show 3 times with this template, but if I remove amp in index.pug, is only call 1.

I tried to reproduce your issue, but every browser I used (Chrome 85 on Windows, Firefox 80 on Windows, Chrome 84 on Android, Firefox 81 (spoofed UA header) on Android, Firefox 81 on Windows) requested / only once (and probably all of them tried to access /favicon.ico, but that leaves no information in logs).

What browser are you using? Have you looked at the network tab in the browser to verify that it request the page only once?

This seems like a pub / amp issue, not an express issue. Closing.


Automated tests

We need to implement automated tests based on a collected dataset from various devices (https://github.com/Andre0512/hon-test-data). These tests should be integrated into the CI/CD pipeline to automatically detect any regressions or issues in the code that handles device data loading.

Partially done in #22


Fixes regression from 6a3174 ' Fix issue where ack is not sent when d…

…uplicate packet
arrives and delayed acks is disabled.'
where duplicate acks are being sent when delayed_acks is false,
because csp_rdp_check_ack is called both from csp_read and csp_rdp_new_packet
and csp_rdp_check_ack will always return true.

I'm also wondering whether it's desirable to have the csp_rdp_check_ack at all in the csp_io? It was added there in d6aa309c


Remove non alphanumeric characters from anchors

Fixes #203 by replacing non alphanumeric characters by hyphens in anchors

/approve cancel

/approve cancel

Thanks @feloy .
/lgtm
/approve

Thanks @feloy .
/lgtm
/approve


⚠ Empornium has degraded performance

In 1121199, Empornium ($EMP) experienced degraded performance:

HTTP code: 200
Response time: 7056 ms

Resolved: Empornium performance has improved in 9617c79 after 8 minutes.


Minor QFT fixes: Avoid local ParameterTable import and fix naming

Summary
Closes #4353 and fixes the displayed name of IQFT, which previously showed up as QFT_dg and now is IQFT.

@mtreinish Sorry for the delay, the test is added 👍🏻


Documentation

Hello there! The page https://microsoft.github.io/angular-react/docs doesn't have any documentation now.
Does the documentation exist at all?  And if no, do you planning to add it in future?

Hey @egormiron, we're definitely not doing a very good job (or at all for that matter) in the documentation front at the moment.
This is something we'd like to do, but isn't prioritized too high at the moment (we do accept PRs though! 😄).
The code itself is pretty well documented though, especially for the more "interesting" stuff, which is @angular-react/core, so understanding what's going on (especially at the public api surface level) should be pretty easy.
For the @angular-react/fabric package - we try to stay as close as possible to the API that's exposed natively by the underlying office-ui-fabric-react package, with most changes being in casing of stuff (e.g. ActionButton -> fab-action-button), or transformations from render props to Angular TemplateRefs, ComponentRef or other alternatives.
Is there anything specific you're wondering about?
P.S.
There's also the @angular-react/semantic-ui package, which as the code shows - is pretty much dead, in the sense that it's not actively maintained or in active development. The original purpose of it was to keep us honest, especially in @angular-react/core, to being very UI framework agnostic, so we don't end up with coupling to Fabric where it shouldn't exist.
However, if anyone would like to submit a PR to add wrappers for it though (or any other component library), we're open to accepting them.

Reopening this since work on documentation has started. Some of it is in the code (see the docs branch) and some in the repository's wiki. Note that most of it is a work-in-progress, but expect things to get better in the next few days.
If there are any contributions or comments on things we should cover etc. - feel free to mention me here and I'll see if we can cover that as part of our current documentation effort.

Closed by #101, as well as the wiki that's now in the repo, feel free to see there and re-open this if there's anything missing etc.

Reopening this since work on documentation has started. Some of it is in the code (see the docs branch) and some in the repository's wiki. Note that most of it is a work-in-progress, but expect things to get better in the next few days.

If there are any contributions or comments on things we should cover etc. - feel free to mention me here and I'll see if we can cover that as part of our current documentation effort.

Thanks so much for adding the wiki! This is a HUGE improvement 🙏🏼
However, @bengry the docs branch is currently showing a 404:

Further, if you follow the URLs from the main repo page to "Documentation, quick start, and guides" the page is blank and there are a large number of console logs indicating 404 from resource requests:

@samuelgoff all docs are either in the code (JSDoc for the most part), as well as the repo's wiki - as you saw.
What was in the docs branch was migrated over to the repo wiki, so that's where you should mainly look.
Regarding the live example - I'm not sure what happened to it, looks like the CI build failed on something. Tagging @aarongreenwald  and @shaiRose, who are the active maintainers of this project. I'm no longer contributing to it, following me leaving Microsoft a few months ago. At any case, you should be able to clone the repo and do npm run start:docs (after the usual npm install) to check them out. There's nothing much there apart from some examples to show off performance and the like though, so I think your best bet is the repo wiki to get started with this project.


feat(store): add status dashboard

This PR provides a dashboard to show the status of the ceph cluster using ceph-dash
ceph-dash it's a wsgi application that uses librados (for python) to retrieve the status of the cluster.
There is no persistence or any dependency to run the component besides be able to connect to the ceph cluster.
This is a screenshot of the dashboard in a new deis cluster:

Awesome, @aledbf! I'll give this a shot.
As this is an optional component, we should add instructions for starting the component.

@carmstrong it's required add the service in deisctl?
There is no other "optional" component, so please tell me where's the place for the instructions.
The instructions are simple: fleetctl submit deis-store-dashboard.service and fleetctl start deis-store-dashboard.service

The instructions are simple:

Sure, but the .service file has to live somewhere, and I agree it probably shouldn't be in deisctl. Maybe put it in store/dashboard?

There is no other "optional" component, so please tell me where's the place for the instructions.

Honestly, I'm not sure. It could live in Managing Deis, but I kind of think this should live in Customizing Store like the changes in #2837.
How featured is the dashboard, @aledbf? Does it help people to recover their cluster, or is it only for an informational display?

How featured is the dashboard?

It is only an informational display.
There's only 2 alternatives to manage the ceph cluster: calamari and inkscope.
Calamari is the first option, only requires postgres (deis-database could provide the service) but as you know the current installation process is not easy. Watching CDS Hammer they mentioned that in the next ceph release calamari will provide installation packages.
Inkscope it's really nice but it requires mongodb so I don't see that as an option.
In the mean time I think that this could provide a status of the cluster without using nse or any ceph knowledge

Watching CDS Hammer they mentioned that in the next ceph release calamari will provide installation packages.

Okay. I'll give this dashboard a go. I'm wondering if it's worth waiting to implement a store dashboard until we have one that can actually change things (like Calamari), especially if they're working on making it easier to install.

@aledbf We've discussed this internally and have decided that we don't want to bring a Ceph dashboard into Deis core -- exposing a Ceph dashboard would leak the deis-store abstraction more than we're comfortable with.
That being said, we'd love to build a page linking to these sorts of tools so Deis users can find and use them: #2952.


Edge probing: UD data code & instructions

Cherry-picked from edgeprobe_docs to include the UD code only. Relative to that branch, also refactored argument handing & wrapper script for consistency with other datasets.

Once this is merged, everything for the paper should be on master. I'll continue to do some cleanup.


Add initial build info

Hi,
some additional info could be added to the readme for initial setup of prosit,
it basically helps people that are not that familiar with make and docker.
Also make build did not work, probably has to elevate with sudo.
sudo make build

which results in:
nvidia-docker build -qf Dockerfile -t prosit .
sha256:d224c2ac898b32662b6265ae7a37dd1872dd98defe4cf86c6fd3acbe7f006c2e
prosit@champagne:~/prosit$

The output looks good I think. You can try make jump and see if you get an interactive shell within the built container.

Will add detailed build information!

Very useful. A more detailed guide in README should help people get started easily.

Please refer to: https://github.com/kusterlab/prosit#installation
The required software and its versions are stated as tested.

Hi, I have not managed to run prosit on my computer, but I guess I am quite close.
I am running bash on Windows 10 (I use the Windows subsystem for Linux - Ubuntu Distribution). I can access the prosit folder (which should contain all files plus installed files, see attached image). Unfortunately, it seems like prosit cannot find the nvidia-docker when I try to use the make server command(see error message in the attached bash screen dump

).
I am not sure if this is because I did not configure the dependencies properly). I have downloaded docker, nvidia-docker and make as specified, but I did it before installing prosit..
Any tips to a computer rookie?

I would assume that the error is caused by one of the following:

nvdia-docker is not installed
nvidia-docker is not in your path

To ensure that nvidia-docker is setup in a way so that Prosit's makefile can make use of it you can run
 nvidia-docker run --runtime=nvidia --rm nvidia/cuda:9.0-base nvidia-smi

Which should show you the current utilization of you GPU(s).
https://github.com/NVIDIA/nvidia-docker recommends
docker run --runtime=nvidia --rm nvidia/cuda:9.0-base nvidia-smi

which is basically the same.

The order in which you downloaded Prosit and it's dependencies does not matter. Except for nvidia-docker that needs to be installed after docker.

@MarcIsak @gessulat
Nvidia-docker is not supported under WINDOWS. Reason, it would require a pass-through of all the GPU functionality. See https://github.com/NVIDIA/nvidia-docker/wiki/Frequently-Asked-Questions#is-microsoft-windows-supported

Is Microsoft Windows supported?
No, we do not support Microsoft Windows (regardless of the version), however you can use the native Microsoft Windows Docker client to deploy your containers remotely (refer to the dockerd documentation).
Do you support Microsoft native container technologies (e.g. Windows server, Hyper-v)?
No, we do not support native Microsoft container technologies.

So I see multiple solutions.

Use the native "jump" code example to run prosit predictions and training under Windows. Basically remove the server functionality and just run a python training and prediction set under Windows using TensorFlow GPU, Keras, pandas and all other prediction packages.

Use  Amazon or Google cloud to run prosit

Use the web-service from the Kusterlab

Ask a Linux guy if they can install the prosit software

Get a "cheap" LINUX box with a GTX 1050 (they are around 600 dollars)

@tobigithub @gessulat
Hi,
yes, I realized that it would not work to install nvidia-docker on Windows. So instead I downloaded Ubuntu and ran it through Windows 10's WSL feature. Problem was that I couldn't install Docker properly as I got this message in the end when I wanted to see that everything worked out:
System has not been booted with systemd as init system (PID 1). Can't operate.
To address the above points.

Sounds interesting, but I have no clue how to set up this workaround and would need some help.
This is a viable option, that perhaps could help me get past the problem with installing Docker on the WSL Ubuntu.
No idea how to do this. Would need some help.
Maybe the last resort. Waiting times for result output is the problem here, and the limited number of RAW-file that can be uploaded.
Very likely
I think point 2 is a better option.

Thanks for your input! I won´t keep spamming about this so the thread is definitely closed here :).

@MarcIsak
actually the docker file is available, so under Windows
you can just run the pip installer or use a conda environment.
Then you modify the code without the docker "frame".
So usage under Windows should not be a problem.
FROM tensorflow/tensorflow:1.10.1-gpu-py3
RUN pip install keras==2.2.1 h5py tables flask pyteomics lxml

ENV KERAS_BACKEND=tensorflow
ENV TF_CPP_MIN_LOG_LEVEL=3
ENV LC_ALL=C.UTF-8
ENV LANG=C.UTF-8

ADD prosit/ /root/prosit
RUN cd /root/
WORKDIR /root/


Add python binding for LinkModel

Description
This's initial python binding for link model, right now I only added the functions I needed :D
The second commit adds support for creating a robot model using urdf/srdf strings, this make it easier to create one given MoveItConfigs
Checklist

[ ] Required by CI: Code is auto formatted using clang-format
[ ] Extend the tutorials / documentation reference
[ ] Document API changes relevant to the user in the MIGRATION.md notes
[ ] Create tests, which fail without this PR reference
[ ] Include a screenshot if changing a GUI
[ ] While waiting for someone to review your request, please help review another open pull request to support the maintainers

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.52%. Comparing base (636b988) to head (bc80b58).
Report is 320 commits behind head on main.

Files with missing lines
Patch %
Lines

...src/moveit/moveit_core/robot_model/robot_model.cpp
89.48%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2247      +/-   ##
==========================================
+ Coverage   50.50%   50.52%   +0.02%
==========================================
  Files         386      387       +1
  Lines       31731    31745      +14
==========================================
+ Hits        16022    16035      +13
- Misses      15709    15710       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Authority.Ecto.Enum

By providing Authority.Ecto.Enum, things get a bit simpler.
Now, we no longer need exnumerator for tests.
 We don't need to generate tests for the Lock.Reason or Token.Purpose (because you'd be testing the library).
And now, because the submodules get so simple, we can just inline them in the parent module, which means the generator doesn't have to resolve paths for submodules. Overall, I think this change reduces complexity for both maintainers and end-users.
This still needs docs, though.

Looks good to me. We can add docs before the next release.


fixing joining licenses with AND or OR for multiple licenses per component

closes #2

Hi There
Thanks for working on this.
You have closed the PR without it being actioned - did you not want me to merge the change?
Can you also confirm your Company name so we can align with the Black Duck usage as your profile is blank in GH?
Yours


Step3: invoke terraform apply

User Story
Related story: #1523
Example github action implementation: https://github.com/ministryofjustice/github-actions/tree/main/terraform-static-analysis
AWS Nuke is documented at https://github.com/rebuy-de/aws-nuke
Parse the nuke-config.yml file and for every account nuked, run terraform apply.
User Type(s)

Value

Questions / Assumptions / Hypothesis

Definition of done

[ ] readme has been updated
[ ] user docs have been updated
[ ] another team member has reviewed
[ ] tests are green
[ ] UR test OR added to continual research plan

Reference
How to write good user stories

https://github.com/ministryofjustice/modernisation-platform/pull/1699

https://github.com/ministryofjustice/modernisation-platform-environments/pull/530

https://github.com/ministryofjustice/modernisation-platform-environments/pull/532


Ts new calc pool distr

Add some benchmarks to speed up the tickf rule

So I added some notes to https://github.com/input-output-hk/cardano-ledger/issues/3035. Did you make some changes. I note that you did a force-push .  Do I need to do anything else? (like rebase on master?)


Add close event on debug adapter inline impl

fixes https://github.com/microsoft/vscode/issues/178046
It adds an optional onDidClose field on the DebugAdapter class to allow notifying vscode when the debug adapter inline implementation was closed prematurely

We can discuss more on the issue, but I don't understand what you are trying to do that has to be done outside of DAP


Weierstrass panic: Points are the same. Use sw_double instead

Hey guys!
I am receiving the following panic when I run my zk program in my MacOS machine locally, only execution:
2024-10-18T18:25:43.958973Z ERROR execute: panic: thread '<unnamed>' panicked at 'Error: Points are the same. Use sw_double instead.': ~/.cargo/git/checkouts/sp1-20c98843a1ffc860/59c4234/crates/curves/src/weierstrass/mod.rs:176

I delved deeper into it and figured that it happens where I call TransactionSigned::into_ecrecovered in reth_primitives::transaction crate. I am using commit a206eb3690e5a51d3c797fed2a6ed722e36863eb.
I use this method multiple times, but it happens for the following specific transaction:
TransactionSigned { hash: 0x94dc0ce2952f04b9224e43322717784e177320fbfc3bdcb295472437bcb7ddce, signature: Signature { r:<PHONE_NUMBER>4943506365915457270296004249787913312232689974263100638689464413246, s:<PHONE_NUMBER>3712003418817999545753212719523848378983378602657690381670578672061, odd_y_parity: true }, transaction: Legacy(TxLegacy { chain_id: Some(5115), nonce: 808, gas_price:<PHONE_NUMBER>, gas_limit: 2950000, to: Call(0x62ef91b746f9fd31adac6c211ad8b8213c1c9ba4), value: 0, input: 0xb189fd4c11074d1e3b6566dedd5883b35c4622daeb03b324e31d5ee40a55e62bad558510 }) }

I am using sp1-sdk and sp1-zkvm v3.0.0-rc3.
I apply the following patches to my program:
sha2-v0-10-8 = { git = "https://github.com/sp1-patches/RustCrypto-hashes", package = "sha2", branch = "patch-sha2-v0.10.8" }
sha3-v0-10-8 = { git = "https://github.com/sp1-patches/RustCrypto-hashes", package = "sha3", branch = "patch-sha3-v0.10.8" }
crypto-bigint = { git = "https://github.com/sp1-patches/RustCrypto-bigint", branch = "patch-v0.5.5" }
tiny-keccak = { git = "https://github.com/sp1-patches/tiny-keccak", branch = "patch-v2.0.2" }
curve25519-dalek = { git = "https://github.com/sp1-patches/curve25519-dalek", branch = "patch-curve25519-v4.1.3" }
ecdsa-core = { git = "https://github.com/sp1-patches/signatures", package = "ecdsa", branch = "patch-ecdsa-v0.16.9" }
secp256k1 = { git = "https://github.com/sp1-patches/rust-secp256k1", branch = "patch-secp256k1-v0.29.1" }
substrate-bn = { git = "https://github.com/sp1-patches/bn", branch = "patch-v0.6.0" }
bls12_381 = { git = "https://github.com/sp1-patches/bls12_381", branch = "patch-v0.8.0" }

Hey @yaziciahmet! We recently resolved this issue by updating our patch for ecdsa-core to use the latest version of SP1. Can you retry by running cargo update -p<EMAIL_ADDRESS>to update to the latest version of the patch?
This is the relevant issue where we included the changes: https://github.com/succinctlabs/sp1/pull/1542.
After you do so, this issue should be fixed! I'd also recommend updating to SP1 3.0.0.

Thanks a lot @ratankaliani! It fixed the issue.


More complete proxying implementation for setting attributes on connection object

A lot of changes have happened to VCRpy since this ticket was opened. As this ticket has become stale, would you mind closing it if it is no longer needed / relevant?
If I haven't heard anything in a week I'll mark it as closed as we have a lot of old tickets that need to be groomed to make it easier to see what is still relevant.
However if it is still needed, please feel free to re-open or create a new ticket.
Thanks! 🙏


Fix Our latest posts

These are not the latest posts from IG. Can you fix this?

Also the figures aren't real


Does this plugin install ruff

Does this plugin install ruff and is there any way to avoid that?
I already have ruff installed and available from my nix-shell environment. The version of ruff is tied to the project which might update slowly, currently the ruff version used 0.5.0.
I installed python-lsp-server with pipx and then installed the mypy and ruff plugins like this:
pipx install python-lsp-server
cd ~/.local/share/pipx/venvs/python-lsp-server
source base/activate
python3 -m pip install pylsp-mypy
python3 -m pip install python-lsp-ruff

however the issue is that this causes ruff 0.7.0 to be installed and picked up.  (it seems like)
Is there some way to just get the connection to ruff enable (without installing ruff), and then use the ruff binary that will be loaded by my nix-shell environment (0.5.0)?

is it because of the dependency in the pyproject.toml file and is that really necessary?
I tried to just renamed the ruff binary in my python-lsp-server virtualenv, but instead now I get 0 diagnostics from ruff.

hmm, if I understand this problem correctly the issue is that, in the virtual environment, the ruff binary is not found by pip? Could you install python-lsp-ruff without dependencies (via --no-deps) and manually install the required packages ("python-lsp-server", "lsprotocol>=2023.0.1", "tomli>=1.1.0; python_version < '3.11'")?


iFrame Resizer issues

A few issues I noticed popping up on any page embedding the Landscape block. The block is pulling iframeResizer.js from landscape.lfph.io.
iframeResizer.js:8 [iFrameSizer][Host page: landscape] Deprecated: 'messageCallback' has been renamed 'onMessage'. The old method will be removed in the next major version.
DevTools failed to load SourceMap: Could not parse content for https://landscape.lfph.io/iframeResizer.map: Unexpected token < in JSON at position 0
The script also dumps quite a lot of console messages to the browser, so perhaps { log: false } could be set

Submitted upstream. We'll resolve soon.

Fixed in https://github.com/cncf/landscapeapp/issues/661


Vade Mecum Docs for Ethereal Fruit still states that there's chance at no seed

I lied, apparently I did change it and thought I didn't


HADOOP-19037. AWS SDK v2: ITestS3AConfiguration failing with region problems

Description of PR
Jira: https://issues.apache.org/jira/browse/HADOOP-19037
Currently ITestS3AConfiguration.testS3SpecificSignerOverride failing when ~/.aws/config profile region is not set. This is because if a region is not provided to STS client it will fall back to using the SDK DefaultAwsRegionProviderChain: env var, profile, EC2 Metadata(IMDS) to get the client signing region. If none of these providers are successful, this test will fail. This PR sets this test STS client region to not rely on the SDK region provider chain.
We will continue to have test coverage of configuring STS client builder in ITestS3ATemporaryCredentials.
How was this patch tested?
Tested with a bucket in eu-west-1 with mvn clean verify -Dparallel-tests -DtestsThreadCount=16

With a no region ~/.aws/config

All tests passing other than 2 failures:
ITestS3ACommitterFactory.testEverything (testInvalidFileBinding())
ITestS3AConfiguration.testRequestTimeout (Expected: https://issues.apache.org/jira/browse/HADOOP-19022)

For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 26s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 32s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m  5s

trunk passed

+1 :green_heart:
shadedclient
37m 41s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 21s

the patch passed

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m  9s

the patch passed

+1 :green_heart:
shadedclient
37m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 57s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

138m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6486/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6486

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 268d3eddaf6c 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e6bfaef37b083914607b14ca2ea863d060a186fb

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6486/1/testReport/

Max. process+thread count
526 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6486/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 00s

No case conflicting files found.

+0 :ok:
spotbugs
0m 00s

spotbugs executables are not available.

+0 :ok:
codespell
0m 00s

codespell was not available.

+0 :ok:
detsecrets
0m 00s

detect-secrets was not available.

+1 :green_heart:
@author
0m 00s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m 01s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
91m 56s

trunk passed

+1 :green_heart:
compile
5m 27s

trunk passed

+1 :green_heart:
checkstyle
4m 58s

trunk passed

+1 :green_heart:
mvnsite
5m 21s

trunk passed

+1 :green_heart:
javadoc
5m 05s

trunk passed

+1 :green_heart:
shadedclient
154m 04s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 06s

the patch passed

+1 :green_heart:
compile
2m 20s

the patch passed

+1 :green_heart:
javac
2m 20s

the patch passed

+1 :green_heart:
blanks
0m 00s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 08s

the patch passed

+1 :green_heart:
mvnsite
2m 31s

the patch passed

+1 :green_heart:
javadoc
2m 18s

the patch passed

+1 :green_heart:
shadedclient
160m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
5m 34s

The patch does not generate ASF License warnings.

429m 52s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6486

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
MINGW64_NT-10.0-17763 6d23b3a20b4d 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / e6bfaef37b083914607b14ca2ea863d060a186fb

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6486/1/testReport/

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6486/1/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Torque categories

Fixes in this PR:

[x] Categorize all type of columns, not only string ones: add a new option to categorize any selected column, no matter the its column type (cc @javierarce).
[x] Check problems with Others value (exposed max number of categories cc @javierarce).
[x] Instantiate map when a new ramp value is selected (CartoDB/cartodb.js#1409), dependencies updated (cc @alonsogarciapablo).
[x] Added tests for style-form-components-dictionary.
[x] Updated several repos dependencies (it will happen thanks to @rochoa).
[x] Add tests for new things touched in style-generator (cc @javisantana).
[x] Problem in public embed (it is likely related with sql_wrap not included) (cc @gfiorav).

Fixes #9389.

CR: @nobuti  (y a volar!)

Passing frontend and backend tests (not waiting for on premises ones).

🚀


[Docs] Add flows for OBO and Service Account

Description
As we are expanding the features in the Security Plugin we are capturing how those features work in our service architecture.  For this set of changes I'm documenting how plugins, extensions with OnBehalfOf tokens, and Extension with service accounts interact with the cluster.
Bonus added a table of contents
Check List

[ ] ~New functionality includes testing~
[X] New functionality has been documented
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RyanL1997 @scrawfor99 Would you mind taking a look at this PR, anything you'd like to see updated or changed?

while supported through the extensions API it needs to be enabled on an individual extension basis and can be revoked at runtime.
@peternied by "revoked" here means the feature itself right? Like the disable option in security config?

@RyanL1997 I've cleaned up that line, let me know if you think that is an improvement


Need to set source IP address for connections originating from a particular container.

Problem
Suppose a docker host has 4 public IP addresses:
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
It is currently possible to "publish" a particular docker container at a certain IP address and host combination using e.g. "docker run --name foo_container --publish <IP_ADDRESS>::80 foo/foo_image".
Expected
If that docker container by itself initiates UDP or TCP traffic towards the internet, the source IP address of that traffic should be <IP_ADDRESS>.
Observed
The observed source IP address of that traffic is <IP_ADDRESS>.
Analysis
Docker seems to currently use the "MASQUERADE" iptables target, while it should use the "SNAT --to-source <IP_ADDRESS>" iptables target. The IP address used as SNAT source (as well as whether or not SNAT should be used instead of MASQUERADE) could be determined as follows:

If there is a "--publish <IP_ADDRESS>" command line argument (note the absence of a port), then use MASQUERADE.
If there is a "--publish ipAddress" command line argument (note the absence of a port) and that ipAddress is not <IP_ADDRESS>, then use SNAT and this IP address.
If there is no "--publish ipAddress" command line argument, but one or more "--publish ipAddress:hostPort:containerPort" or "--publish ipAddress::containerPort" command line arguments where the ipAddress is consistent, then use SNAT and this consistent IP address.
If there is no "--publish ipAddress" command line argument, but one or more "--publish ipAddress:hostPort:containerPort" or "--publish ipAddress::containerPort" command line arguments where the ipAddress is not consistent, then fail with an error.
Else use MASQUERADE.

closing as duplicate of https://github.com/docker/docker/issues/6743


Early detection of bootloader mode during update

During an update, I forgot to put the Tessel into bootloader mode. The update got pretty far along before erroring out because it wasn't in bootloader mode. The update should probably check for the proper mode upfront so it can fail early. Also, after the error, the program didn't quite; I had to send a kill signal to end it.
$ t2 update
INFO Looking for your Tessel...
INFO Connected to scott over LAN
INFO New firmware version found...0.0.5
INFO Updating scott to latest version (0.0.5)...
INFO Beginning update download. This could take a couple minutes..
  downloading [====================] 100% 0.0s remaining
INFO Download complete!
INFO Updating OpenWRT (1/2)
INFO Transferring image of size 20.19 MB
INFO Starting OpenWRT update. Please do not remove power from Tessel.
INFO Updating firwmare (2/2)
Unhandled rejection Error: No device found in bootloader mode
    at /Users/scottgonzalez/Projects/t2-cli/lib/usb_connection.js:272:19
    at tryCatcher (/Users/scottgonzalez/Projects/t2-cli/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._resolveFromResolver (/Users/scottgonzalez/Projects/t2-cli/node_modules/bluebird/js/main/promise.js:480:31)
    at new Promise (/Users/scottgonzalez/Projects/t2-cli/node_modules/bluebird/js/main/promise.js:70:37)
    at USB.Connection._findBootedDeviceBySerialNumber (/Users/scottgonzalez/Projects/t2-cli/lib/usb_connection.js:256:10)
    at retry [as _onTimeout] (/Users/scottgonzalez/Projects/t2-cli/lib/usb_connection.js:233:19)
    at Timer.listOnTimeout (timers.js:119:15)

After rebooting in bootloader mode, I get the following output:
$ t2 update
INFO Looking for your Tessel...
WARN Detected a Tessel that may be booting.
WARN No Authorized Tessels Found.

Seems like there's no path forward.

You don't need to put the T2 into bootloader mode when using t2 update, but the board needs to be connected via both USB and LAN—can you confirm?

Well, connecting via USB is very difficult for me; it only works a small fraction of the time, and when it does, the connection doesn't last very long (see #387).
Assuming that your correct, it seems like either the update process is checking something it shouldn't be checking, or the error message is wrong (perhaps a try/catch that's surrounding too much code?).
I'll try again later. I can't connect to the wifi at work because of the way the permissions work.

Assuming that your correct,

It's a hard requirement. The issues with USB must resolved.

This is a duplicate of https://github.com/tessel/t2-cli/issues/276.


AuthorizationError: The redirect_uri MUST match the registered callback URL for this application

HELP!~~

What are you trying to do and what steps did you follow to setup Strider?

i add a git project then i want to add another,so i click the button

then error

Did you follow the readme instructions in the strider-github repo?

not working with domain name as it got worked in localhost


Adds DataViewCreator to Power BI visuals solution

adds DataViewCreator to Power BI visuals solution
npm package version 0.5.9

This change is

Hi @ignatvilesov, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Vilesov Ignat (Akvelon)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Looks good.


TFLite benchmark tool doesn't show complete Op profiling when using use_nnapi=true flag

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: All devices
TensorFlow installed from (source or binary): Source
TensorFlow version (use command below): Release 1.14.0
Python version: 2.7.15+
Bazel version (if compiling from source): 0.24.1
GCC/Compiler version (if compiling from source): gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0

Describe the current behavior
I am testing the benchmark tool found on this link: https://github.com/tensorflow/tensorflow/tree/master/tensorflow/lite/tools/benchmark
I am building and running in Android to benchmark MobileNet V1 model on some devices. I am interested in seeing the profiling information for each of the layers/operations and I am able to do that by adding the enable_op_profiling=true flag. However, I can't see the information when I also add the flag "--use_nnapi=true".
Example with NNAPI switched off:

Example with NNAPI switched on:

Describe the expected behavior
I expect that using the --use_nnapi=true flag will also display op profiling information
Code to reproduce the issue
Just enable --enable_op_profiling=true and --use_nnapi=true flags when running the benchmark on any model. Is it not implemented yet?

This information is not yet exposed from NNAPI, sadly, and won't be available in the near future.

similar issue for me
after following the instructions on the tflite benchmarking tool for desktop the tool worked but didn't show any additional information when using the --enable_op_profiling=true argument
OS: linux 19.04, built benchmarking tool with bazel 0.21 from latest tensorflow


New features

Hello,
Do you know if it is possible to add additional pages in the gui of items that the player on sale because there are only 45 slots ?
And if it is possible also to add a new category for minerals ?
And also to be able to sort the items by date added in the hdv ?
Thank you in advance for your answer.

There is a paging system built into CA that you can scroll through at the bottom.

At the moment categories can not be added unless coded in. It is planned to add custom categories to the plugin.
Sorting is also another planned feature for CA.

Okay thank you very much for your answers.
But for the "1" I only talk about items that the player sells. He has 45 places and the other items he can not see because there are no other pages.
https://image.noelshack.com/fichiers/2019/39/5/1569575630-capture-d-ecran-17-li.jpg

Ah, yes I see now. I'll look into adding that.

Thank you very much we all look forward to this ! :)


exploration phase slows down and seems never to end

I came across an issue that the exploration phase slows down gradually, from 2it/s to 10s/it. The output file shows that the 'filling bound' process is 'done' even though the progress bar is not yet 100%. For example:
Filling Bound 15:  44%|████▎     | 1305/3000 [4:31:38<4:35:37,  9.76s/it]
Filling Bound 15:    done
N_like:            137160
N_eff:               2261
log Z:           -580.748
log V:             -8.339
f_live:             0.461
The exploration phase becomes slower and slower and seems never to end. It is still exploring after 48 hours.
Weirdly, I previously run a similar code and the result is normal, returning the sampling posterior within one day. Now I only changed the data (a child sample of the data before), the likelihood function being the same. I don't understand why this issue happens.

It turned out that the likelihood function used was stochastic, i.e., would randomly yield different results even for the same parameters. nautilus should give accurate results in these cases but it may not be very efficient. That's because the initial exploration phase in nautilus is essentially a global optimization. If the likelihood function is noisy, a global maximum doesn't really exist and nautilus can slow down. The main suggestion in this case would be to increase f_live to something around 0.5. This makes the exploration phase stop sooner.
The other issue with the progress bar is related tqdm, by default, not working well with log files. But the current version of nautilus doesn't rely on tqdm, anyway.


Reading XML in Pash

Hey All,
I was pleasantly surprised to find that Pash correctly converts an xml string:
> $xml = [xml]"hello";
> $xml

HasAttributes   : False
InnerText       : hello
InnerXml        : hello
IsEmpty         : False
LocalName       : a
Name            : a
NodeType        : Element
OwnerDocument   : System.Xml.XmlDocument
ParentNode      : System.Xml.XmlDocument
ChildNodes      : System.Xml.XmlElement
FirstChild      : System.Xml.XmlText
HasChildNodes   : True
IsReadOnly      : False
LastChild       : System.Xml.XmlText
OuterXml        : hello
LastLinkedChild : System.Xml.XmlText

However, it does not appear to look up values correctly by using the dot notation.
So I was expecting:
> $xml = [xml]"hello";
> $xml.a

b
_
hello

> $xml.a.b
asdf

Any thoughts as to where the work for this support could be added?

System.Management.Pash.Implementation.SettableMemberExpression is the class that implements the behavior of Pashs member access by 'dot' expressions. Both the SetValue and GetValue methods already deal with Hashtables and PSObjects. XMLDocuments would just be another case to add there.
Maybe it also makes sense to introduce some new classes that make it more clean and dynamic to add even more ways of member accessing. Like a List<Tuple<Type, MemberAccessor>> that is looked for specific MemberAccessor objects that allow to get and/or set a member of a specific type.
Would be much nicer than adding just another condition to the methods ;-)
But feel free to do anything you like about this :)

@sburnicki - here's a start... Can you take a peek and see if I'm heading in the right direction?

Looks good to me in general :-) Commented on some stuff I noticed ;-)

There is lots of work to fully support various xml scenarios... but here's a start :)

I integrated all of your feedback (thanks for that was all good stuff).

good job :)

Mhm, I just noticed that we maybe took the wrong approach to implement these custom member accesses, like here with XML.
This approach doesn't list the members as a PSObject properties, so they aren't listed when for example Get-Member is used.
So instead we should add a class derived from PSPropertyInfo and think of a generic way to add them in PSObject.InitProperties.
Doing this will reflect these "special properties" at PSObject level and we can avoid special treatment in the member access.


Add "Kill server" task for Minecraft servers

Feature Request
Feature Information:

In Minecraft Forge 1.18 sometimes the server will stop/crash and AMP doesn't detect it.

The main reason for this would be for automated server restarts
I confirm:

[x ] that I have searched for an existing feature request matching the description.

The normal 'stop' mechanism has a timeout that will force-kill the server if it doesn't end gracefully in time.


Remove extra completionHandler.Invoke

Description of Change
Remove extra completionHandler.Invoke which causes app to terminate after a background fetch
Issues Resolved

fixes https://github.com/shinyorg/shiny/issues/1301

API Changes

None
Platforms Affected

iOS

Behavioral Changes

None
Testing Procedure

PR Checklist

[x] Rebased on top of the target branch at time of PR
[x] Changes adhere to coding standard
[ ] Sent to a v(branch) or DEV branch

I appreciate the check, but this is the only completion handler for push notifications in shiny.  Do you have your own bg fetch running?

No, I was only using Shiny to received the background fetch. The lines of code were running the Invoke twice. Removing one would result in a successful background fetch and the app would not terminate.

Perfect.  Thanks for the fix & PR.  It is already out in preview.
I did note that in your project, you are referencing 'Shiny'.  That's for v2 and deprecated in v2.  If you need to get all of the "boilerplate" stuff for Shiny - I recommend checking out the "App Builder" at shinylib.net in the future


Expose a getCredentials method

The private_key and client_email properties of a service account JSON file are required for crypto operations, such as generating a signed URL. Example from @google-cloud/storage: https://github.com/googleapis/nodejs-storage/blob/469530c744c42096e46f39f409272cca05eaf02a/src/file.js#L1646.
Evidently, the GCP metadata server can return these values. google-auth-library is the most knowledgeable of the environment and authentication choices made by the user, and ideally would expose a method like authClient.getCredentials().
This method would return the contents of the service account JSON key file, or if the user did not give a key file, i.e. they're on GCP, it would read the properties from the metadata server.

Just to make sure we're all on the same page, the Google metadata service will not reveal a private key, but that's not needed for the signed URLs in @google-cloud/storage. Instead, @google-cloud/storage should use an OAuth token from the metadata server and call IAM's signBlob API.

@stephenplusplus Are there any specific entries that you want from this method or do you want the entire content of the JSON file?
The format of a service account JSON is as follows:
{
  "type": "service_account",
  "project_id": "project-id",
  "private_key_id": "private-key-id",
  "private_key": "-----BEGIN PRIVATE KEY-----\nsomeprivatekey\n-----END PRIVATE KEY-----\n",
  "client_email"<EMAIL_ADDRESS>  "client_id": "000000000000000",
  "auth_uri": "https://accounts.google.com/o/oauth2/auth",
  "token_uri": "https://accounts.google.com/o/oauth2/token",
  "auth_provider_x509_cert_url": "https://www.googleapis.com/oauth2/v1/certs",
  "client_x509_cert_url": "https://www.googleapis.com/robot/v1/metadata/x509/000000000-compute%40developer.gserviceaccount.com"
}

@lukesneeringer @stephenplusplus What should be the signature of the method? Should it accept a callback to process the data returned by the metadata server/JSON key file or should it return the data directly?

/cc @stephenplusplus for a decision
My gut is that it optionally takes a key file, and it returns a (potentially partial) service account dictionary.

We actually talked it through a bit in the PR: https://github.com/google/google-auth-library-nodejs/pull/180


Dev

Testing deployment with merging.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@3a0e4eb). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage        ?   82.47%
=======================================
  Files           ?       14
  Lines           ?      291
  Branches        ?        0
=======================================
  Hits            ?      240
  Misses          ?       51
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0e4eb...fe8c132. Read the comment docs.


IP Not Given Problem

on line 34, I think it very useless since it will always get empty result. I think it will better if you use $ip = $_SERVER["REMOTE_ADDR"];

Lumen uses the phpdotenv library which loads environment variables from .env to getenv(), $_ENV and $_SERVER automagically.  Because of this getenv('REMOTE_ADDR) and $_SERVER["REMOTE__ADDR"] will return the same value.
With that being said the method call on line 34 was supposed to pull this information but it wasn't.  I have fixed this in the v2.0.0-RC.