Allow auto-merge from PRs made on fork of General

Registrator now lets you specify a fork of the registry to make the PRs against. Its better to use a fork for security reasons since we can reduce the bot privilege on the main registry. Can we allow auto-merge on a recognized fork of General? @DilumAluthge
We need to create this fork repository so lets also discuss how that should be done.

@DilumAluthge bump

Short answer:
No, we cannot auto-merge PRs from a recognized/authorized fork of the General registry.
To increase security of the General registry with regards to the JuliaRegistrator bot, I have blocked the JuliaRegistrator bot from merging or pushing to the master branch of the General registry.

Long answer:
The question in this issue is specifically about the JuliaRegistrator app. The issue is specifically asking two questions:

Can the JuliaRegistrator app push to a fork (e.g. JuliaRegistrator/General) instead of to the main repo (JuliaRegistries/General), and still have JuliaRegistrator PRs be auto-merged?
Would doing so increase the security of the General registry?

This issue does not concern PRs made from other forks to the General registry; the issue is specifically about JuliaRegistrator pushing to an authorized fork (JuliaRegistrator/General).
The answer to the first question is that there is no easy way to securely auto-merge PRs that are made from a fork of the General registry. GitHub has a variety of security mechanisms in place, and these mechanisms essentially prevent us from using AutoMerge (at least, with the current architecture of AutoMerge) to auto-merge PRs from a fork of the General registry. Is it possible to bypass these security mechanisms? Yes, but:

GitHub would discourage you from doing so.
At some point, the effort to bypass the security mechanisms means that you open yourself up to more potentially security risks than compared to the previous situation (JuliaRegistrator pushing to the General registry), and I think your security situation ends up net worse off.

A lot of this has to do with the fact that AutoMerge is a GitHub Action, not a GitHub App. If AutoMerge were completely rearchitected and rewritten as a GitHub App, then the situation becomes very different, and some things that were previously not possible now become possible. However:

This represents a huge amount of additional work, and it's not even clear to me that the payoff is worth it.
If AutoMerge becomes a GitHub App, then some trustworthy entity has to setup and maintain the server (and surrounding infrastructure) that the GitHub App will run on, and they have to deploy and maintain the App on that server and infrastructure, and they have to keep the App up-to-date, and they have to keep the whole thing secure. This is a nontrivial ask. Also, it will become difficult (if not impossible) for Julia community members outside of that trustworthy entity to work on deploying and updating AutoMerge. Compare that to the current situation, where AutoMerge is developed and deployed entirely on GitHub and GitHub Actions, with every step of the deployment publicly visible, and it is much easier for Julia community members to participate in the process.

The second question is a more general question about security on the General registry with respect to the JuliaRegistrator app. In response to this, I'll point out that we can restrict which users and apps can merge to the master branch of the General registry. I have applied such restrictions. The JuliaRegistrator app has been blocked from merging to the master branch; it can push to other branches, but not to the master branch.

If the above explanation is confusing (I know that it is meandering and not terribly well structured), then a different way to answer this question is by evaluating this sentence from the OP:

It's better to use a fork for security reasons since we can reduce the bot privilege on the main registry.

With the current architecture of AutoMerge as a GitHub Action, this sentence is not true.
For AutoMerge (in its current GitHub Actions architecture) to function, the registrator bots (@JuliaRegistrator and @jlbuild) are required to have commit/push privileges on the main JuliaRegistries/General repository.
We can restrict the permissions of the bots, by blocking the @JuliaRegistrator and @jlbuild bots from merging or pushing to the master branch. I have already implemented this restriction.
But we cannot remove commit/push access from @JuliaRegistrator or @jlbuild as long as AutoMerge exists in its current GitHub Actions architecture.


VDF

https://developer.valvesoftware.com/wiki/KeyValues
Steam uses Valve's KeyValues format (colloquially "VDF" for Valve Data Format, originating from the Source Engine) for app configuration. There are a few reasons this would be useful, most immediately obvious a more thorough Steam Input integration for Input, currently configured only for "Gamepad Emulation" mode.
Another potential use is unifying platform integrations such as achievements, DLC and UGC management, etc.
Not expecting anyone else to implement this, but not going to self-assign for the time being in case someone else is so inclined :-)

Looks pretty easy. Do you have any real world examples that we could use for testing?

From Valve:

https://partner.steamgames.com/doc/features/steam_controller/iga_examples

Misc. tests:

https://github.com/RoyalBingBong/vdfplus/blob/master/test/testfiles/test.vdf
https://github.com/EXayer/vdf-converter/tree/main/tests/samples
https://github.com/GerhardvanZyl/Steam-VDF-Converter/tree/master/VdfConverter.Test/InputFiles
https://github.com/andygrunwald/vdf/tree/main/testdata
https://github.com/CosmicHorrorDev/vdf-rs/tree/main/keyvalues-parser/tests/assets

Field data:

https://github.com/DHager/hl2parse/tree/master/hl2parse-tests/src/test/resources/com/technofovea/hl2parse/vdf
https://github.com/marshauf/keyvalues/tree/master/testdata
https://github.com/Jleagle/steam-go/tree/master/steamvdf/testdata

🥳🥳 thank you !!


Remove watchman option

The watchman option really doesn't make much since in conjunction with webpack. Webpack provides it's own --watch flag that monitors the src directory and automatically reruns the compile step.
Enabling watchman right now doesn't actually do anything as this plugin only invokes runner.compileAll(). Watchman is only used when using runner.watchAll().
In theory we could defer to relay-compilers internal watchman and have to FS monitors. But opens up the possibility for race conditions. Which FS monitor sees and reacts first. What if JS is compiled before new Relay files are generated. I think the most reliable way is to ensure the relay-compiler is always invoked before the rest of the webpack bundle chain. We can simply leverage the current webpack --watch or webpack-dev-server file monitoring.

CC: @danielholmes @koddsson

@danielholmes Updated branch to merge cleanly.

That all makes sense. Thanks @josh


RuntimeError: shape '[32, 2, 64, 4096]' is invalid for input of size 26214400

V100 32G GPU
CUDA 1.8
Python3.10
Llama13B
I successfully executed ：BASE_MODEL='/home/model' python3 export_hf_checkpoint.py
Loading checkpoint shards: 100%|██████████████████| 3/3 [00:18<00:00,  6.07s/it]
/usr/local/lib/python3.10/site-packages/transformers/generation/configuration_utils.py:362: UserWarning: do_sample is set to False. However, temperature is set to 0.9 -- this flag is only used in sample-based generation modes. You should set do_sample=True or unset temperature. This was detected when initializing the generation config instance, which means the corresponding file may ho                                                                                ld incorrect parameterization and should be fixed.
warnings.warn(
/usr/local/lib/python3.10/site-packages/transformers/generation/configuration_utils.py:367: UserWarning: do_sample is set to False. However, top_p is setto 0.6 -- this flag is only used in sample-based generation modes. You should set do_sample=True or unset top_p. This was detected when initializing the generation config instance, which means the corresponding file may hold incorrect                                                                                parameterization and should be fixed.
warnings.warn(
/usr/local/lib/python3.10/site-packages/transformers/generation/configuration_utils.py:508: UserWarning: The generation config instance is invalid -- .validate() throws warnings and/or exceptions. Fix these issues to save the configuratio                                                                                n. This warning will be raised to an exception in v4.34.
Thrown during validation:
do_sample is set to False. However, temperature is set to 0.9 -- this flag is only used in sample-based generation modes. You should set do_sample=True or unset temperature.
warnings.warn(

But I failed to execute the following code:BASE_MODEL='/home/model' python3 export_state_dict_checkpoint.py
root@iZwz9cc5vwcplget5j9bzdZ:/home/alpaca-lora# BASE_MODEL='/home/model' python3 export_state_dict_checkpoint.py
Loading checkpoint shards: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████| 3/3 [00:17<00:00,  5.95s/it]
/usr/local/lib/python3.10/site-packages/transformers/generation/configuration_utils.py:362: UserWarning: do_sample is set to False. However, temperature is set to 0.9 -- this flag is only used in sample-based generation modes. You should set do_sample=True or unset temperature. This was detected when initializing the generation config instance, which means the corresponding file may hold incorrect parameterization and should be fixed.
warnings.warn(
/usr/local/lib/python3.10/site-packages/transformers/generation/configuration_utils.py:367: UserWarning: do_sample is set to False. However, top_p is set to 0.6 -- this flag is only used in sample-based generation modes. You should set do_sample=True or unset top_p. This was detected when initializing the generation config instance, which means the corresponding file may hold incorrect parameterization and should be fixed.
warnings.warn(
Traceback (most recent call last):
File "/home/alpaca-lora/export_state_dict_checkpoint.py", line 116, in
new_state_dict[new_k] = unpermute(v)
File "/home/alpaca-lora/export_state_dict_checkpoint.py", line 67, in unpermute
w.view(n_heads, 2, dim // n_heads // 2, dim)
RuntimeError: shape '[32, 2, 64, 4096]' is invalid for input of size 26214400
please help me，thanks

I know the reason, because I am using Llama2's 13B model, so I should rewrite the params.json of the 13B model to export_ State_ Dict_ In the checkpoint. py file


ModuleNotFoundError when running modin with dask in AWS environment

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux 4.14.252-131.483.amzn1.x86_64
Modin version (modin.__version__): 0.8.3
Python version: 3.6.10
Code we can use to reproduce:

import os
os.environ["MODIN_ENGINE"] = "dask"
from dask.distributed import Client
client = Client('Dask-Scheduler.local-dask:8786') #path to my dask scheduler cluster
import modin.pandas as pd
frame_data = np.random.randint(0, 100, size=(2**10, 2**8))
df = pd.DataFrame(frame_data)

Describe the problem

I've created a conda environment with the following requirements, and based on this walkthrough:
conda create --name daskpy36 python=3.6.10 dask=2.14 distributed=2.14 s3fs=0.4.0 dask-glm=0.2.0 cytoolz=0.8.2 pandas=1.0.1 scikit-learn=0.23.2 matplotlib dask-ml=1.6.0 ipykernel -y

With this environment activated, I've pip installed modin[dask], and am able to load it properly, however when I try to use the library at all, I get a ModuleNotFoundError, as shown in the logs section.
For some reason it appears that my worker is using /opt/conda/lib/python for the pickle.loads call in the distributed package, instead of the specified one in my anaconda3/envs folder. This happens no matter what modin API call I make, including pd.read_csv to pd.dataframe
Source code / logs

ModuleNotFoundError                       Traceback (most recent call last)
~/anaconda3/envs/daskpy36/lib/python3.6/site-packages/IPython/core/formatters.py in __call__(self, obj)
    343             method = get_real_method(obj, self.print_method)
    344             if method is not None:
--> 345                 return method()
    346             return None
    347         else:

~/anaconda3/envs/daskpy36/lib/python3.6/site-packages/modin/pandas/dataframe.py in _repr_html_(self)
    196         # We use pandas _repr_html_ to get a string of the HTML representation
    197         # of the dataframe.
--> 198         result = self._build_repr_df(num_rows, num_cols)._repr_html_()
    199         if len(self.index) > num_rows or len(self.columns) > num_cols:
    200             # We split so that we insert our correct dataframe dimensions.

~/anaconda3/envs/daskpy36/lib/python3.6/site-packages/modin/pandas/base.py in _build_repr_df(self, num_rows, num_cols)
    166         else:
    167             indexer = row_indexer
--> 168         return self.iloc[indexer]._query_compiler.to_pandas()
    169
    170     def _update_inplace(self, new_query_compiler):

~/anaconda3/envs/daskpy36/lib/python3.6/site-packages/modin/backends/pandas/query_compiler.py in to_pandas(self)
    233
    234     def to_pandas(self):
--> 235         return self._modin_frame.to_pandas()
    236
    237     @classmethod

~/anaconda3/envs/daskpy36/lib/python3.6/site-packages/modin/engines/base/frame/data.py in to_pandas(self)
   2122             Pandas DataFrame.
   2123         """
-> 2124         df = self._frame_mgr_cls.to_pandas(self._partitions)
   2125         if df.empty:
   2126             if len(self.columns) != 0:

~/anaconda3/envs/daskpy36/lib/python3.6/site-packages/modin/engines/base/frame/partition_manager.py in to_pandas(cls, partitions)
    529             A Pandas DataFrame
    530         """
--> 531         retrieved_objects = [[obj.to_pandas() for obj in part] for part in partitions]
    532         if all(
    533             isinstance(part, pandas.Series) for row in retrieved_objects for part in row

~/anaconda3/envs/daskpy36/lib/python3.6/site-packages/modin/engines/base/frame/partition_manager.py in <listcomp>(.0)
    529             A Pandas DataFrame
    530         """
--> 531         retrieved_objects = [[obj.to_pandas() for obj in part] for part in partitions]
    532         if all(
    533             isinstance(part, pandas.Series) for row in retrieved_objects for part in row

~/anaconda3/envs/daskpy36/lib/python3.6/site-packages/modin/engines/base/frame/partition_manager.py in <listcomp>(.0)
    529             A Pandas DataFrame
    530         """
--> 531         retrieved_objects = [[obj.to_pandas() for obj in part] for part in partitions]
    532         if all(
    533             isinstance(part, pandas.Series) for row in retrieved_objects for part in row

~/anaconda3/envs/daskpy36/lib/python3.6/site-packages/modin/engines/dask/pandas_on_dask/frame/partition.py in to_pandas(self)
    119             A Pandas DataFrame.
    120         """
--> 121         dataframe = self.get()
    122         assert type(dataframe) is pandas.DataFrame or type(dataframe) is pandas.Series
    123

~/anaconda3/envs/daskpy36/lib/python3.6/site-packages/modin/engines/dask/pandas_on_dask/frame/partition.py in get(self)
     61         if isinstance(self.future, pandas.DataFrame):
     62             return self.future
---> 63         return self.future.result()
     64
     65     def apply(self, func, **kwargs):

~/anaconda3/envs/daskpy36/lib/python3.6/site-packages/distributed/client.py in result(self, timeout)
    216         if self.status == "error":
    217             typ, exc, tb = result
--> 218             raise exc.with_traceback(tb)
    219         elif self.status == "cancelled":
    220             raise result

/opt/conda/lib/python3.6/site-packages/distributed/protocol/pickle.py in loads()

ModuleNotFoundError: No module named 'modin'

Hi @fhenrywells! I think the issue here is that Modin isn't being installed on the workers - just the client. This helps to explain why the stack trace includes Modin packages - I think that the Modin package on the client is triggering remote execution on the workers via the distributed package (last part of stack trace) which is then erroring since the workers don't have Modin in their conda environments. I think one potential fix would be to include modin[dask] in the conda create command. You could also use an env.yml file similar to the one we have here to create a conda environment with the necessary dependencies!

I think one potential fix would be to include modin[dask] in the conda create command. You could also use an env.yml file similar to the one we have here to create a conda environment with the necessary dependencies! >

I tried doing the former, and there was a package conflict that caused the conda env creation to fail. I will try using the env.yml- which python version should I build that with?

Hmm - it's odd that you got a package conflict - perhaps try running conda install -c conda-forge modin-dask? This should install Modin with the Dask execution engine. If you share the package conflict here, it could help me get a better idea of what the issue is.
As for the environment-dev.yml file, that should work with any Python 3.x version - Modin supports all the way up to Python 3.9!

Modin requires python version >= 3.7.1.

I was using python 3.6.10, and this was producing massive amounts of conflicts (took conda ~4 hrs to fully resolve them) when building with the environment.yml.
I'm thinking of starting from scratch on my AWS environment since that tutorial seems to have a bit of a heavyweight Dask cluster that may have too many conflicting reqs with Modin, are there good resources for running Modin on AWS? I'm just trying to get a prototype working, so the cluster does not need to be too advanced

I think that the conflicts were probably because pandas no longer supports python < 3.7! I've also noticed that conda can take a really long time to build environments from a yaml file - two possible solutions I've found work are to use conda to build the environment without the yaml file, then update the environment by using conda env update --file <NAME_OF_FILE>. The second possible solution is to use mamba - which is a build of conda with a faster package resolver and follow the same steps as with conda (create the env without the yaml file, then update it).

@fhenrywells, we don't have any tutorial yet on how to run Modin with Dask in a cluster environment but that should be the matter in near month(s). You can follow the steps specified in that instruction (link) or in that video (link) to connect dask scheduler and dask workers on multiple nodes. Then you only need to specify dask scheduler address to dask Client and import Modin to do computations:
from dask.distributed import Client
c = Client("dask-scheduler-address")
import modin.pandas as pd
pd.DataFrame(...) # Modin will connect to Dask cluster to distribute computations
...

@fhenrywells we've recently added support for "legacy" Python 3.6 and pandas 1.1 in https://github.com/modin-project/modin/pull/4800 and https://github.com/modin-project/modin/pull/4301, this might help with installing Modin in some AWS cases. We don't have a release with this yet, so you'd have to install from master.
Please let us know if that helps!


Add video "Community & Key Aspects" to "What is Monero?" page

https://www.youtube.com/watch?v=lTdxUpkarjE
#1187 should be kept in consideration when adding this.

The 'Community' video is heavily outdated and there seems to be no plans to update it. Doesn't make sense to add it to the website. Closing this.


Sort edits by priority when outputting planned migration

Does this print the changes in the order in which they actually occur?

It should - I took the sorting from https://github.com/obsidiansystems/beam-automigrate/blob/228bf518e541e865f571ae824b8917400e924257/src/Database/Beam/AutoMigrate.hs#L2688

okay, seems good then :+1:


Bug when publishing event from inside Push plugin callback

Ionic version:
[ ] 1.x
[x] 2.x
I'm submitting a ...
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
I have a provider that handles everything related to push notifications. I want to navigate to a page that has tabs whenever I receive a push notification. To achieve this I subscribe to an event on app.component.ts and push the desired page when it's published, and I publish this event from the Push.on('notification') callback when I receive a push notification.
The problem is that when I navigate to a page that has tabs using what I described above the tabs get on top of the header. This only happens if I publish the event inside the Push.on('notification') callback, if I publish it from anywhere else everything works fine.
Expected behavior:
The desired behavior is that the tabs are displayed as usual without getting on top of the header.
Steps to reproduce:
I created a new project to reproduce the bug: https://github.com/akz92/ionic-example
I didn't add the Push plugin because you need a sender_id to use it, so to reproduce you need to have a sender_id, add the plugin and add the sender_id to the PushService provider init function.
Ionic info:
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.3
Ionic CLI Version: 2.1.13
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.45
ios-deploy version: 1.9.0
ios-sim version: 5.0.11
OS: OS X El Capitan
Node Version: v6.9.1
Xcode version: Xcode 8.1 Build version 8B62

This issue was moved to driftyco/ionic-cloud-issues#237

I may be missing something here, but AFAIK this issue isn't related to Ionic Cloud.


Demos don't work?

React not available in either of them.

React is loaded from a cdn https://github.com/mquan/cortex/blob/master/examples/skyline/index.html#L5

This demo works fine for me http://mquan.github.io/cortex/examples/skyline/
You seem to have an old version of the demo. The current demos use react 0.12

Sorry, the demo on github pages is still on 0.8.0. I'll update it immediately but the current ones should work. I just loaded from my mobile safari. You may want to check your browser security settings or try it on a different browser

All fixed. I updated the README to point to https github page. Thanks


Add option to remove/toggle columns

A cross or x that would hide a column

@bendl This is done!

PR #11 and #13 adds this feature.
However, I am keeping this open as I would like to add fully collapse-able columns, where the remaining column widths are recalculated to fill the closed space.


Create invincibel.txt

I am closing this. Please submit another one within the coding period (1st Dec - 6th Jan).


Convert optical ray tracer to path tracer

add infrastructure to support diffuse surfaces, which means switching to statistical sampling of ray paths (path tracing).

Changes made and merged into master,


Advanced Mode Compilation For TypeScript Namespaces

TypeScript has a namespace feature which generates fairly simple code that the Closure Compiler seems to not optimize how I would expect.
Setup
math_helpers.ts
namespace MathHelpers {
  export add(x: number, y: number): number {
    return x + y;
  }

  export sub(x: number, y: number): number {
    return x - y;
  }
}

export { MathHelpers };

math_helpers.js
var MathHelpers;
(function (MathHelpers) {
    function add(x, y) {
        return x + y;
    }
    MathHelpers.add = add;
    function sub(x, y) {
        return x - y;
    }
    MathHelpers.sub = sub;
})(MathHelpers || (MathHelpers = {}));

export { MathHelpers };

root.js
import { MathHelpers } from "./math_helpers";

console.log(MathHelpers.add(3, 4));

actual
'use strict';var a;(function(d){d.add=function(b,c){return b+c};d.sub=function(b,c){return b-c}})(a||(a={}));console.log(a.add(3,4));

expected
'use strict';console.log(7);

@mprobst @evmar how do you deal with this? Do you preprocess and inline such code before passing on the compiler? I remember discussing this pattern before but I don't remember what the resolution was.

We "solved" this by disallowing use of namespace in google3 code.
I have some more examples of troublesome TypeScript patterns on this bug:
https://github.com/angular/tsickle/issues/132

PS: on the example in this bug in particular, the code is bad TypeScript (this pattern is explicitly called out in the TypeScript docs on how to use namespaces).  ES6 modules are themselves namespaces already so you don't need to introduce another.
Instead write:
  export function add(x: number, y: number): number {
    return x + y;
  }

  export function sub(x: number, y: number): number {
    return x - y;
  }

The user of this then needs to use
import * as MathHelpers from './MathHelpers'

instead of
import MathHelpers from './MathHelpers'

(See "Needless Namespacing" at https://www.typescriptlang.org/docs/handbook/namespaces-and-modules.html .  However, this doesn't solve the larger problem of how namespaces and Closure compiler interact.)

If we use the import * syntax, will the Closure Compiler tree shake appropriately?

We were experimenting with namespaces under the assumption that import * was bad for minification

That particular code pattern has long been problematic. The biggest sticking point is the IIFE wrapper and the fact that type information is lost with it.

It seems like import * does the correct thing. I still think this issue is academically interesting but my issue is resolved.

The rewrite I suggested works around the problem one level of namespacing, but multiple levels of namespacing still introduce the IIFE.  However, perhaps that isn't Closure compiler's problem (the generated code is a pattern that is hard for it to understand).

I think nested namespaces should be flattened out into a form Closure Compiler is more used to. See https://github.com/google/closure-compiler/blob/master/test/com/google/javascript/jscomp/Es6TypedToEs6ConverterTest.java#L512 for examples.

I think the fix for this is https://github.com/angular/tsickle/issues/132 , and can be closed here.

Agreed


installer: .profile is not used by Bash (or Zsh); edit .bash_profile or .zprofile too

Steps to Reproduce

curl -sSf https://rye.astral.sh/get | bash
Should the installer add Rye to {} via .profile? → y
Confim .profile has been edited
Restart Bash or Zsh
which rye

Expected Result
Rye's path is shown
Actual Result
Command 'rye' not found, did you mean:
Version Info
Today
Stacktrace
No response

Bash doesn't load .profile while .bash_profile exists.
I think Zsh either (.zprofile instead)
Offending parts:

https://github.com/astral-sh/rye/blob/c14f2a73f4c7525b0d47667d5819bc26a3f4df42/rye/src/utils/unix.rs#L8-L22
https://github.com/astral-sh/rye/blob/c14f2a73f4c7525b0d47667d5819bc26a3f4df42/rye/src/cli/rye.rs#L745-L765


Erg book navigation links at the bottom (Prev|Next) are broken

The links at the bottom refer to "XX_chaptername.md" while the correct one should be "XX_chaptername.html".
The navigation can still be used via the side-bar chapter links, but it may cause inexperienced people to think that the chapter is missing or not implemented.

It is also the same for the Japanese version of the book as far as I can tell.

I already know the problem.
I use mdbook to made my documents into books. Apparently this software doesn't recognize links correctly when using html elements.
Originally this Prev|Next was set up for people looking at documentation from GitHub. In the case of the Book, there is a navigation bar, so I thought it would be good to use that.
It seems that I need to delete Prev|Next from the Book or fix it manually, but is there any good way?
Or is this a better issue to report to mdbook?

How about mechanically removing Prev|Next forms before processing of the mdbook?
This is an ad hoc response, but it could be used as a measure in the meantime.

This issue was solved https://github.com/erg-lang/erg-lang.github.io/pull/2 .


Question/feature: Only format on save when prettier config detected

I want prettier to run on save, but only if a prettier config has been detected (e.g., prettier.config.js or .editorconfig). Is that currently possible?

No, prettier config is detected by prettier module, but you can made it yourself by use viml.


Fix three additional cases where doc references are not conforming to new lookup code restrictions

Similar to #85412, fix more cases where the new dartdoc lookup will not work.
I didn't discover these because the handling of ambiguous cases had a bug where resolution was not fully stable and could vary between runs.  This will be fixed with dart-lang/dartdoc#2712.

test-exempt: only affects comments


All text is rendered as contiguous squares

Lapce Version
I can't see the version in About Lapce window because text isn't rendered there either, it's all rectangles.
I've downloaded Lapce yesterday (October 12, 2022).
System information
Windows 10 installed with BootCamp on MacbookAir 2011 (yeah, old stuff)
Describe the bug
Here's the screenshot that shows the issue:

Additional information
I'm guessing that this issue is somehow associated with that "GPU accelerated" rendering feature, because I have an old-ass Macbook from 2011 that has integrated graphics.

Duplicate of https://github.com/lapce/lapce/issues/1083 and https://github.com/lapce/lapce/issues/940


Fix formatting bug in check node

Purpose

Fix formatting bug in check node in following scenario

json[] | error ItemArr = trap <json[]>Items;
foreach var item in check ItemArr {
     //some code goes inside here
}

Fixes #20780
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #20876 into ballerina-1.0.x will decrease coverage by 0.07%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           ballerina-1.0.x   #20876      +/-   ##
===================================================
- Coverage            20.58%   20.51%   -0.08%
===================================================
  Files                   52       52
  Lines                 1394     1394
  Branches               216      216
===================================================
- Hits                   287      286       -1
  Misses                1095     1095
- Partials                12       13       +1

Impacted Files
Coverage Δ

tool-plugins/vscode/src/core/extension.ts
28.06% <0%> (-0.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b1fcd6...6847c57. Read the comment docs.


[joss][sec] possible injection and data leakage

Part of: https://github.com/openjournals/joss-reviews/issues/6336
Loading a malicious JSON file can execute code and leak MRI data (or worse). A simple validation for numeric values during loading can prevent such scenario.
{"points":[[100,164,"0\"><script>window.alert('hey jude')</script><br style=\"display: none;\" data-close=\""]],"values":[10]}

Thank you for the note. We hadn't thought about this as usually the user themselves is the producer of the json file they'll later load. We'll integrate a sanitizer.

A check for numbers only has been implemented in # 6bdaf8c. Thank you @r03ert0 .


allow online login from share extension

this seems fine, can we make an enum rather than a bool?  Or maybe pass the preferred login technique to StartLoopbackServer?


prevent array in array

Prevents get errors() to return an array-in-array with messages.
This results in all validation messages to be rendered even when showMultipleErrors is false...
ps. I've tried a unit test, but failed... :-/

does this seem legit to you?

will do...
you are correct;
arrays are returned when multiple (an array of) validators have been defined.
strings when a single validator (I assumed ember-bootstrap already handled those)
and undefined for none.

as for testing. I think i need to do this
ember generate component-test bs-form/element --unit

to create a unit test for the component. However it (empty) fails to run with 'TypeError: Cannot convert undefined or null to object'

as for testing. I think i need to do this
ember generate component-test bs-form/element --unit

to create a unit test for the component. However it (empty) fails to run with 'TypeError: Cannot convert undefined or null to object'

I think unit tests are not supported for @glimmer/component. But I also don't think we want a unit test. As the consumer will only use the addon through the template, all tests should be component integration tests, which actually renders the component. I think it should be just an additional test in ember-bootstrap-changeset-validations/tests/integration/components/bs-form-element-test.js.

hmmm... ok. how do we test undefined then. Simply no rendered message?

hmmm... ok. how do we test undefined then. Simply no rendered message?

Yes. undefined means that there isn't a validation error. So it should not show a validation message. But I think for your use case the multiple validation messages is more important.

there added a test for each case

Nope, wanted to but forgot in 34 degrees. Will do tomorrow

On 12 Aug 2020, at 19:31, Jeldrik Hanschke<EMAIL_ADDRESS>wrote:

@jelhan approved this pull request.
This looks great. Thanks a lot.
If you have some time left an additional test case that multiple validation errors are actually shown if showMultipleErrors argument of <BsForm:: Element> is true would be great. But I totally understand if you don't have any more bandwidth to work on this topic. Would merge as-is in that case.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

will you do a release or are you waiting on other stuff?

Will try to do a release later today.

Released v3.1.2 containing this fix just right now.


Why do (some) unexpected messages cause neither an alert to be sent, nor flushing of the connection?

To be standard compliant (see reference below), and because we (to quote s2n's DEVELOPMENT-GUIDE) also shouldn't "pass the buck" and place the burden of subtle or complicated TLS-specific decision making upon application authors and system administrators; I think reading unexpected messages should cause a fatal alert to be written to conn->reader_alert_out and s2n_flush() to be called on the connection.
However, almost immediately after starting to read s2n code carefully, I noticed a case where this doesn't happen:
tls/s2n_handshake_io.c: line 249 onward (in handshake_read_io()):
if (record_type == TLS_APPLICATION_DATA) {
    S2N_ERROR(S2N_ERR_BAD_MESSAGE);
} else if (record_type == TLS_CHANGE_CIPHER_SPEC) {
        if (s2n_stuffer_data_available(&conn->in) != 1) {
            S2N_ERROR(S2N_ERR_BAD_MESSAGE);
        }
        [...]
}

-1 and an errno are immediately returned to the application (through parent function s2n_negotiate()), but no cleaning up is performed at all - not even the record containing the bogus data is wiped, even though all the other conditional branches in s2n_handshake_io all call GUARD(s2n_stuffer_wipe(&conn->header_in)); GUARD(s2n_stuffer_wipe(&conn->in)); conn->in_status = ENCRYPTED; when done.
Just wondering if that's intentional; and if so, why? Wouldn't it be wiser to shut down and wipe the connection ASAP?
*) reference ---------------------------------------------------------------------------------------------
https://tools.ietf.org/html/rfc5246#section-7.2.2

Error handling in the TLS Handshake protocol is very simple.  When an
error is detected, the detecting party sends a message to the other
party.  Upon transmission or receipt of a fatal alert message, both
parties immediately close the connection.  Servers and clients MUST
forget any session-identifiers, keys, and secrets associated with a
failed connection.  Thus, any connection terminated with a fatal
alert MUST NOT be resumed.

unexpected_message
An inappropriate message was received.  This alert is always fatal
and should never be observed in communication between proper
implementations.

https://tools.ietf.org/html/rfc5246#section-6

Implementations MUST NOT send record types not defined in this
document unless negotiated by some extension.  If a TLS
implementation receives an unexpected record type, it MUST send an
unexpected_message alert.

I'm pretty sure that this isn't intentional! It's definitely worth doing the wiping. I'm less sure about sending the alert; even though the standard does say that sending alerts is required I'm not certain that it's a good idea. alert messages like this rarely help the actual users and have been implicated in protocol vulnerabilities. They also complicate the application behavior (a read suddenly becomes a write).

Regarding wiping:
I think the safest/robustest way to do this is to classify the entire set of errors that s2n can throw into separate categories within s2n_errno.c. One of these categories should contain all error numbers that are considered fatal to the associated connection. That way, whenever the S2N_ERROR macro (which actually might be better off turned into a function than a macro) is called, it can see for itself (e.g., in a static array of structs) to which category the errno belongs, and take care of wiping the connection if it matches said fatal category. A little heavy-handed perhaps, but the benefit of eliminating the risk of code in various nooks and corners forgetting to clean up after itself is worth it, I'd say.
Regarding alerts:
In general --as you no doubt agree with-- I think one best be very weary of violating specifications that RFCs are explicit and adamant about (i.e., all statements containing the absolutes "MUST" and "MUST NOT").
Either way, what I believe is of paramount importance; is that a security-critical library such as s2n demonstrate to (potential) developers and auditors that any deviations from the RFCs are based on careful consideration. At the very least the code in question should contain some comment like RFC12345 specifies that we do <this>, but instead we do <that>, because <bullet points>. In addition --but possibly excessive, because I have no idea yet how much of this there is in s2n-- I think it would be a good idea to be extra upfront about it, and add a section to the DEVELOPER-GUIDE titled "RFC Deviations" or something containing all of them together.
I'm willing to help out (through pull requests), but I'm hesitating on how/if to proceed from here on... and a little weary of the possibility of falling into a deepening rabbit hole once I get going. :)
Thoughts appreciated.

Oh we'd definitely welcome Pull Requests and always try to be productive and avoid rabbit holes. I completely agree about honoring standards in general, but TLS can sometimes be a strain on that because they're been times where implementations have had to ignore the specs (at the time) for safety reasons. The original alert assisted Bleichenbacher attacks are what I'm thinking of there, and POODLE is another recent example where there are working mitigations if you're willing to ignore the standard.
I'm planning to put some serious time of my own into s2n over the comings weeks, so keep the feedback coming.


Added BlueEyes module

All files related to the Bluetooth module are in the 'bluetooth' folder.

Fully tested all main menu items but haven't tested in use.


ipv4

Hello,
I cant find any documentation about ipv4 vs ipv6.
I want to be able to use ipv4 to connect to my db but it seems that by default everything is setup to use ipv6.
I tried the docs, i tried previous issues but there is no information.
Because of limitations in Azure for basic Tier databases i cant configure them to use ipv6 so i need ipv4.

@peter-miroshnikov could you provide more details of where you are forced to use ipv4? An example of the configuration or parameters you want to use would help.

I am sorry, it turns out that its an azure limitation.
If i am using timescale db on a basic tier Postgres single-server instance and I have configured my subnet with a service endpoint to  Microsoft.SQL (Which seemed to be the recommended way to do it from microsoft) i get an error that my postgres server is not configured to use IPV6.
After spending some time researching random places on the net i removed the Service Endpoint for Mirosoft.SQL i no longer get the error and the connection works.
The issue was between Promscale installed inside my k8s cluster and a managed Postgres Instance

Thanks for the update @peter-miroshnikov. I'm glad that you got it working in the end!


DatabricksSQL log analytics event format

The below event attributes arrive under properties json node from event hub and not at root level as described in the doc.
What is the correct format of Databricks  log analytics events ?
"properties": {
  "sourceIPAddress": "<IP_ADDRESS>",
  "logId": "XXX",
  "serviceName": "databrickssql",
  "userAgent": "",
  "response": "{\"statusCode\":200}",
  "sessionId": "xxxx",
  "actionName": "commandFinish",
  "requestId": "xxxx",
  "requestParams": "{\"warehouseId\":\"xxx\",\"commandId\":\"xxx\"}"
}

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6dee3f11-b747-ff6b-81af-e4585727d2bd
Version Independent ID: 6dee3f11-b747-ff6b-81af-e4585727d2bd
Content: Diagnostic log reference - Azure Databricks
Content Source: databricks/administration-guide/account-settings/audit-logs.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@jvmlet
Thanks for your feedback! We will investigate and update as appropriate.

@jvmlet
Thank you for bringing this to our attention.
I've delegated this to content author @mssaperla, who will review it and offer their insightful opinions.

@mssaperla
Could you please review add comments on this, update as appropriate.

Thanks for providing feedback that helps improve our documentation. We've created an internal work item (DOC-9781) to address your feedback. The timeline for resolution varies based on resourcing.
#please-close

Please leave open until it's actually completed.
#pleaese-reopen


Front End Image Uploader

How to implement an image uploader ,where authenticated users can upload their photos without accessing the dashboard.

You can try to reproduce the code that is done on the back end.


fails with private window

it seems the entire concept of this tool is based on an invasion of privacy.

user A send URL
user B send URL
user A open URL in private window

then:

Unable to load private key
Could not find the private key associated to the public key in the url in the browser. Make sure this is the correct browser and the url is correct. Only the requester can decrypt the secret.

so the intended receiver cant even open the message specifically made for them. it just seems like this whole concept is flawed.

Have you tried this workflow :

user A send URL in private window and keep it open
user B send URL
user A open URL in same private window as step 1

If this fail you are up to something, otherwise you  only proved that your browser private browser feature work as expected. (It can't access local private key created outside the private session).


build: add pull request labeler

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Using a minor version results in broken code generation [C# Client]

We're running the openApiToCSharpClient code generator to generate a C# Client from an .NET 5.0 api, together with the dotnet  tool nswag.
When annotating an action with a minor version like below, we get broken code in the generated client:
    [ApiVersion("2.1")]
    [Route("v{version:apiVersion}/auction-requests")]
    [ApiController]

Code in the generated client:
public async Task<Command> V2.1AuctionRequestsPostAsync()

The dot in the method name is breaking compilation of course. Anything we can do to prevent this? We already tried different operationGenerationMode settings, but all have the same issue.
Only using major versions on all controllers gets us correctly version methods, but we want to include minor versions as well.

We'd need to fix this either in the operation name generators or here
https://github.com/RicoSuter/NSwag/blob/d69085067b2261c75f3b49a0e43a4c26aa49d743/src/NSwag.CodeGeneration/ClientGeneratorBase.cs#L228


servicemesh, ci: run internal to NodePort test

Currently, we were skipping internal to NodePort test for all matrix entries.
Fixes: #27304

/ci-ingress

/test

Let's backport this PR to v1.15 and v1.16, so that we don't unintentionally break this functionality.

Dropped needs-backport/1.14, as b7b375cd3a752affaedea6d15933a9090ca52254 is not part of the v1.14 tree.


Added alibi

Added the interpretable machine learning Alibi, together with a tutorial on using counterfactuals for explanations with the MNIST dataset

Thanks for the PR @axsauze. Looks great!


Support for Angular 15

Angular 15 was released on November 16, 2022. Could you please provide an update for this library to support Angular 15 as well?
Thank you.

We will support recently.

We have supported

@pubuzhixing8 , why have you reopened this issue?
As far as I can see, there is a v15 on npmjs.com, but this repository does not have a git tag for v15.

There was a problem in code build at that time, but it has been resolved now.


Exit when the config is incorrect

Rather than continue we exit if we fail to read the config. This is
because the config contains information about connection to database and
without it gonymizer can't work correctly. It now also prints out the
relevant error.

Thanks for grabbing this @rkuska

@rkuska looks like this broke testing -> https://circleci.com/gh/smithoss/gonymizer/418

@junkert sorry about! Here is a fix https://github.com/smithoss/gonymizer/pull/83

No worries at all! Thanks for the fix! Merged.


IE11 error "SCRIPT5017" when load vue2-sfc-loader.js

Hi Franck,
I build my own version(to support IE11) use the {"browserslist": "> 1%, last 2 versions, not ie <= 10"} and  {"browserslist": "defaults"}, but in IE11 always encounter js error SCRIPT5017 point to the line "vue2-sfc-loader.js (9,360569)"
this error point to the vue2-sfc-loader.js.map:
parse() {
this.enterInitialScopes();

const file = this.startNode();
const program = this.startNode();
this.nextToken();
file.errors = null;
this.parseTopLevel(file, program);
file.errors = this.state.errors;
return file;
}

what can I do to fix this issue?
Thanks,
Wallace

Hi guys,
I point the exact issue at @babel/parser->lib->index.js:  const keywordRelationalOperator = /in(?:stanceof)?/y; IE doesn't recognize "/y", this express is packaged into vue2-sfc-loader.js.

@babel/plugin-transform-sticky-regex (https://babeljs.io/docs/en/babel-plugin-transform-sticky-regex)

NOTE: This plugin is included in @babel/preset-env

AFAIU babel should transform this according to the browserlist

Hi Franck,
as you mention I add babel plugin in webpack.config.js:
presets: [
...!noPresetEnv ? [
[
'@babel/preset-env',
{
useBuiltIns: 'entry', // https://babeljs.io/docs/en/babel-preset-env#usebuiltins
corejs: {
version: 3,
proposals: true
},
targets: {
browsers: targetsBrowsers,
},
}
]
] : [],
],
plugins: [
"@babel/plugin-transform-duplicate-keys",
"@babel/plugin-transform-sticky-regex"
],
}
in web.config set the browserslit:
"browserslist": "ie 11, not dead",
But the js error is not fixed, could you please test the vue3-sfc-loader.js under IE 11?

unable to find a decent RegExp polyfill that handles sticky flag (eg. RegExp("in(?:stanceof)?","y"))

... and https://github.com/FranckFreiburger/vue3-sfc-loader/commit/9111483e48a5a63a29cd40c05390939f913abf71

example: https://github.com/FranckFreiburger/vue3-sfc-loader/blob/main/docs/examples.md#ie11-example

Hi Franck,
I appreciate your kindly feedback，thanks for your help. It works well under IE11 apply your example. :)


added the feature of choosing theme for user

It is to resolve the issue #78

Hey @Ctoic can you check the pull request


[main] Add patch to make e2e tls tests work on OCP

Patch from https://github.com/openshift-knative/serving/pull/702 to main.
/assign @skonto

/lgtm


Improvements in Collections

This is great, thank you @eksperimental!  Could you please change the version in the Jekyll meta data to 1.1.0?

@doomspork done.
Could you please link me to a doc where it explains what is the protocol for updating the version number

UPDATE: I have removed the mention to "functional combinators" as they are not explained.

@eksperimental there is no documentation around the lesson versioning, it's something we've only recently rolled out, we need to update the README to include mention of that version 👍

@doomspork: thank you. I'm updating the PATCH version for typos, or links or backticks, changes that do not introduce any new content.
MINOR for any new addition.
MAJOR your call.

@eksperimental that is essentially what we've been following.  A major change hasn't occurred yet but that might be something like a total re-write.

great then. good to hear


Multiple error logs regarding to powerlauncher

Microsoft PowerToys version
0.47.1
Running as admin

[X] Yes

Area(s) with issue?
 I managed to identify the cause of the problem it was related to powerlauncher. I am not sure but probably it is because of the administrator permissions. Once I gave administrator permission to powerlauncher.exe error was gone but now when I open my computer  it always  asking for administrator permission which is annoying. I did not had this kind of issue with previous version here are the error logs that I found which related to powerlaunche

r
Other Software
No response

does this issue still happen with v0.73.0? /needinfo

does this issue still happen with v0.73.0? /needinfo
I m not really sure about the version number but  I believe I haven't encounter it since v0.58 or v0.60


Contribute as you like

Make edits as you may please.
    Hey, I want to contribute. Please assign me!!

Originally posted by @vika1221 in https://github.com/sakshian/Hactoberfest2022/issues/1#issuecomment-1274279950

can i contribute?

Raised PR #7

Assign this to me as i am well versed in dsa and i am pretty confident that you will like my merge request.

Can I add Stack Implementation in your repo? @sakshian

@sakshian
Created PR #29
Created PR #30
Created PR #31
Kindly review it.

hi @sakshian, I want to add few C++ pattern questions. Please assign this to me.

Hello @sakshian  I want to add some algorithms. Assign me please!

@sakshian Hey created #51 PR. kindly review it

Hello @sakshian created #53 PR, review it once!

hey @sakshian ,i want to contribute to this issue,could you please assign this to me


Update overview.md

One thing I'm wondering is whether I should add JSON snippets for pod, replication controller, and service?

Thanks, @davidopp. It was better, but I made some suggestions.

Please comment on PRs when you've pushed changes you'd like to be reviewed. There is no notification on push.

LGTM

Please don't create new user branches in GoogleCloudPlatform/kubernetes but in your user's fork instead. These branches in GoogleCloudPlatform/kubernetes are downloaded by everyone who clones it everytime they fetch from it which is quite annoying...

Good point. I didn't even notice that.
@davidopp Please do:
git config remote.upstream.pushurl "you really didn't want to do that"

and don't edit via the web UI.

Sorry, as Brian guessed what happened is that I was editing via the web UI. I didn't realize it caused this problem.


Connected to server but it's empty??

So I stood up Dockercraft on a Photon OS server and I am able to connect to it with no problem. However, the world is blank. I expected to see at least the container hosting the dockercraft but it is nothing but a blank world.
The only message I am getting in the portainer logs is "tcp client OnError: 111: Connection refused" over and over about 50 times a second or more.
In portainer, I setup the container with port mapping of 25575:25565, volume /var/run/docker.sock:/var/run/docker.sock and tty command -t.
Here is the results of inspecting the container.
[
{
"Id": "1d50c48284408c0158f23ae070dc8f1f1f8bf5064c947d47d427fcd3f9b49322",
"Created": "2017-12-16T23:06:27.553581001Z",
"Path": "/srv/Server/start.sh",
"Args": [],
"State": {
"Status": "running",
"Running": true,
"Paused": false,
"Restarting": false,
"OOMKilled": false,
"Dead": false,
"Pid": 8037,
"ExitCode": 0,
"Error": "",
"StartedAt": "2017-12-16T23:06:27.757120107Z",
"FinishedAt": "0001-01-01T00:00:00Z"
},
"Image": "sha256:dad8850a800d96ec7f633a8ef98ec9b39ac60b98eeb25c05079f5e63e6418d88",
"ResolvConfPath": "/var/lib/docker/containers/1d50c48284408c0158f23ae070dc8f1f1f8bf5064c947d47d427fcd3f9b49322/resolv.conf",
"HostnamePath": "/var/lib/docker/containers/1d50c48284408c0158f23ae070dc8f1f1f8bf5064c947d47d427fcd3f9b49322/hostname",
"HostsPath": "/var/lib/docker/containers/1d50c48284408c0158f23ae070dc8f1f1f8bf5064c947d47d427fcd3f9b49322/hosts",
"LogPath": "/var/lib/docker/containers/1d50c48284408c0158f23ae070dc8f1f1f8bf5064c947d47d427fcd3f9b49322/1d50c48284408c0158f23ae070dc8f1f1f8bf5064c947d47d427fcd3f9b49322-json.log",
"Name": "/mc",
"RestartCount": 0,
"Driver": "overlay2",
"MountLabel": "",
"ProcessLabel": "",
"AppArmorProfile": "",
"ExecIDs": null,
"HostConfig": {
"Binds": [
"/var/run/docker.sock:/var/run/docker.sock"
],
"ContainerIDFile": "",
"LogConfig": {
"Type": "json-file",
"Config": {}
},
"NetworkMode": "bridge",
"PortBindings": {
"25565/tcp": [
{
"HostIp": "",
"HostPort": "25575"
}
]
},
"RestartPolicy": {
"Name": "no",
"MaximumRetryCount": 0
},
"AutoRemove": false,
"VolumeDriver": "",
"VolumesFrom": null,
"CapAdd": null,
"CapDrop": null,
"Dns": null,
"DnsOptions": null,
"DnsSearch": null,
"ExtraHosts": [],
"GroupAdd": null,
"IpcMode": "",
"Cgroup": "",
"Links": null,
"OomScoreAdj": 0,
"PidMode": "",
"Privileged": false,
"PublishAllPorts": false,
"ReadonlyRootfs": false,
"SecurityOpt": null,
"UTSMode": "",
"UsernsMode": "",
"ShmSize": 67108864,
"Runtime": "runc",
"ConsoleSize": [
0,
0
],
"Isolation": "",
"CpuShares": 0,
"Memory": 0,
"NanoCpus": 0,
"CgroupParent": "",
"BlkioWeight": 0,
"BlkioWeightDevice": null,
"BlkioDeviceReadBps": null,
"BlkioDeviceWriteBps": null,
"BlkioDeviceReadIOps": null,
"BlkioDeviceWriteIOps": null,
"CpuPeriod": 0,
"CpuQuota": 0,
"CpuRealtimePeriod": 0,
"CpuRealtimeRuntime": 0,
"CpusetCpus": "",
"CpusetMems": "",
"Devices": [],
"DeviceCgroupRules": null,
"DiskQuota": 0,
"KernelMemory": 0,
"MemoryReservation": 0,
"MemorySwap": 0,
"MemorySwappiness": -1,
"OomKillDisable": false,
"PidsLimit": 0,
"Ulimits": null,
"CpuCount": 0,
"CpuPercent": 0,
"IOMaximumIOps": 0,
"IOMaximumBandwidth": 0
},
"GraphDriver": {
"Data": {
"LowerDir": "/var/lib/docker/overlay2/577ca66cce3e66d05242bded12a6b28dc73fe4e10a4714ccba21f2d853d570a8-init/diff:/var/lib/docker/overlay2/3787f6b8fabd22ffa287714fe2fb72f402720eb52b1d03e01ce64b849add7c77/diff:/var/lib/docker/overlay2/e2abe38bab171f241b0d8a22323b95cacd98100483ad54bd4b2f8a2817377080/diff:/var/lib/docker/overlay2/3a2c3a4cdf9c0e558941a1310e6aa2ef6d1d001e221da1b95118966f904d8a09/diff:/var/lib/docker/overlay2/5fdad9f1883c13f70a79b712e1845946a6e04d290450180682ef7911b58b18c5/diff:/var/lib/docker/overlay2/0c8320dc2e616060e58616df2c2316e7fdfd5634f3c12f125e89aa155d0cfe23/diff:/var/lib/docker/overlay2/17b0f491af64911cd021dd969099d0c9072a188fe992bc9c9b2480069c497562/diff:/var/lib/docker/overlay2/9622e55000efa3098b7694ad95ccc5b784fb4a02a42436aceeb9332ca9577fcb/diff",
"MergedDir": "/var/lib/docker/overlay2/577ca66cce3e66d05242bded12a6b28dc73fe4e10a4714ccba21f2d853d570a8/merged",
"UpperDir": "/var/lib/docker/overlay2/577ca66cce3e66d05242bded12a6b28dc73fe4e10a4714ccba21f2d853d570a8/diff",
"WorkDir": "/var/lib/docker/overlay2/577ca66cce3e66d05242bded12a6b28dc73fe4e10a4714ccba21f2d853d570a8/work"
},
"Name": "overlay2"
},
"Mounts": [
{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Destination": "/var/run/docker.sock",
"Mode": "",
"RW": true,
"Propagation": "rprivate"
}
],
"Config": {
"Hostname": "5332b660f2a7",
"Domainname": "",
"User": "",
"AttachStdin": false,
"AttachStdout": false,
"AttachStderr": false,
"ExposedPorts": {
"25565/tcp": {}
},
"Tty": true,
"OpenStdin": false,
"StdinOnce": false,
"Env": [
"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
"tty=true"
],
"Cmd": [],
"ArgsEscaped": true,
"Image": "gaetan/dockercraft:latest",
"Volumes": {
"/var/run/docker.sock": {}
},
"WorkingDir": "",
"Entrypoint": [
"/srv/Server/start.sh"
],
"OnBuild": null,
"Labels": {}
},
"NetworkSettings": {
"Bridge": "",
"SandboxID": "8f1cfa1f6cbe9b1b147c5d1aae9c6c67399fa2cb241452f99cbe8469b25ad58b",
"HairpinMode": false,
"LinkLocalIPv6Address": "",
"LinkLocalIPv6PrefixLen": 0,
"Ports": {
"25565/tcp": [
{
"HostIp": "<IP_ADDRESS>",
"HostPort": "25575"
}
]
},
"SandboxKey": "/var/run/docker/netns/8f1cfa1f6cbe",
"SecondaryIPAddresses": null,
"SecondaryIPv6Addresses": null,
"EndpointID": "7abd3911bb852325cc2ebd30cdb67526be618914e9037a36672ed44897682381",
"Gateway": "<IP_ADDRESS>",
"GlobalIPv6Address": "",
"GlobalIPv6PrefixLen": 0,
"IPAddress": "<IP_ADDRESS>",
"IPPrefixLen": 16,
"IPv6Gateway": "",
"MacAddress": "02:42:ac:11:00:05",
"Networks": {
"bridge": {
"IPAMConfig": {},
"Links": null,
"Aliases": null,
"NetworkID": "d39e6ff4a80b67e36e6e12018bb68cd0130d97d2ae7374f8060a4947cb52351b",
"EndpointID": "7abd3911bb852325cc2ebd30cdb67526be618914e9037a36672ed44897682381",
"Gateway": "<IP_ADDRESS>",
"IPAddress": "<IP_ADDRESS>",
"IPPrefixLen": 16,
"IPv6Gateway": "",
"GlobalIPv6Address": "",
"GlobalIPv6PrefixLen": 0,
"MacAddress": "02:42:ac:11:00:05",
"DriverOpts": null
}
}
}
}
]

Same issue here too.

I'm getting this issue as well, and it seems the error is coming from here: https://github.com/docker/dockercraft/blob/master/Docker/tcpclient.lua#L27
So it's trying to connect to something running in the container on port 25566. Running netstat yields nothing running under that port, though:
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
tcp6       0      0 :::8080                 :::*                    LISTEN      17/Cuberite
tcp6       0      0 :::25565                :::*                    LISTEN      17/Cuberite

@lolpants' image seems to fix the issue: https://github.com/docker/dockercraft/pull/86
So I guess a temporary fix until their PR gets merged would be to just use the lolpants/dockercraft image.

I can confirm too on latest MacOS (High Sierra currently), running latest Docker CE, that the current master branch does not work but this lolpants image does: https://github.com/docker/dockercraft/pull/86;
I also had this same error though on an older version of Linux (Ubuntu Wily 15.10), and an older version of Docker (the last supported version for the EOL Wily): 1.12.6, and lolpants image did not work.  However, I took an older commit from this repo (pre multi-stage dockerfile since this older version of Docker couldn't interpret syntax like "alpine:3.6 AS wget"), for example this commit:
``git checkout 4c0b567249651634e09cbc3fd1a876fde85d5f70
Then, did a docker build and run, and voila, no more error.  Instead just seeing "tcp client OnError: 111: Connection refused" endlessly, it eventually spawned and connected the client with "tcp client connected".  Hopefully these instructions help someone else running a legacy version of Linux and Docker ;)

I can also confirm that on Arch Linux the current version is not running, but I suspect that the error is in the docker binary choosing function in the go code of /bin/dockercraft in the container, because if a link it to the normal docker binary it is working.
Also the docker binary is 0 bytes long:
$ docker exec -it dockercraft /bin/ls -l /bin/docker-18.05.0-ce
-rw-r--r-- 1 root root 0 Aug 16 12:55 docker-18.05.0-ce

I use this command on the docker host to fix the problem
$ docker exec -it dockercraft /bin/bash -c "rm /bin/docker-18.05.0-ce; ln -s /bin/docker /bin/docker-18.05.0-ce"

If you just remove the docker-18.05.0-ce binary and execute /bin/cubecraft inside the container it fails:
# rm /bin/docker-18.05.0-ce
# dockercraft
INFO[0000] looking for docker binary named: docker-18.05.0-ce
INFO[0000] docker binary (version 18.05.0-ce) not found.
INFO[0000] downloading docker-18.05.0-ce...
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x70 pc=0x5f5ad2]

goroutine 1 [running]:
compress/gzip.(*Reader).Close(0x0, 0x871d20, 0xc4200105c0)
        /usr/local/go/src/compress/gzip/gunzip.go:292 +0x22
main.extractClient(0xc42000e410, 0xc4202cc090, 0x871d20, 0xc4200105c0)
        /go/src/github.com/docker/dockercraft/setup.go:128 +0x2c6
main.getClient(0xc42000e410, 0xc420018550, 0x4c, 0x72be08, 0x0, 0x0)
        /go/src/github.com/docker/dockercraft/setup.go:115 +0xa9
main.(*Daemon).GetDockerBinary(0xc4202aa190, 0x0, 0x0)
        /go/src/github.com/docker/dockercraft/setup.go:54 +0x46d
main.main()
        /go/src/github.com/docker/dockercraft/main.go:30 +0xcf

So I think it would be a possible fix to rename the docker binary in the Dockerfile or remove the version tag from the docker binary called from the go daemon.

After some more research, I found that the docker maintainer for Arch Linux is building docker based on a tag from Github. But the current package version (18.05.0-ce) is not built and uploaded to https://download.docker.com/linux/static/stable/x86_64/ and so the dockercraft binary tries to download a version that you need to compile by yourself.

Same problem on Arch Linux. Right now a simple solution I figured out is to mount the missing docker build using something like "-v /path/to/docker:/bin/docker-18.09.6-ce" where the "/path/to/docker" folder is the unzipped docker-18.09.6.tgz downloaded from https://download.docker.com/linux/static/stable/x86_64/

Same problem here on Arch Linux. I changed the DOCKER_VERSION argument in Dockerfile to 18.09.7 and built the image. The log says docker binary (18.09.7-ce) cannot be found and later gives ton of "tcp client OnError: 111: Connection refused". I suspect that this problem occurs because recent docker builds removed the "-ce" in the filenames.
I made the following modifications to the Dockerfile and it solved the problem for me:
between COPY ./Docker /srv/Server/Plugins/Docker and EXPOSE 25565, addRUN ln -s /bin/docker /bin/docker-18.09.7-ce && ln -s /bin/docker /bin/docker-18.09.7. Then build the image and use it.


Problem: Vm execution failed due to network interface

occasionaly vm creation vm because the assigned tap network inteface was already existing. Probably not properly teared down from a previous execution or from a concurrency issue
Displayed Error was :
OSError: [Errno 16] Device or resource busy
it was then looped as a retry and blocked the whole thing
Solution:
When assigning a vm_id, check that the network interface for that vm doesn't already exists This act as a double check for a variety of issues

Can we easily get this code tested ?

Not really automatically as it is at low level but if you want to test it manually you can create a network interface, prior to launching using
sudo ip tuntap add mode tap vmtap4


Fix missing libcontainer syscall file

I noticed this file showed up when revendoring dependencies with vndr.
Also removed github.com/Microsoft/opengcs from vendor.conf as it was not used;
2017/12/05 22:41:58 WARNING: package github.com/Microsoft/opengcs is unused, consider removing it from vendor.conf

Codecov Report

Merging #1889 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1889   +/-   ##
=======================================
  Coverage   47.29%   47.29%
=======================================
  Files          89       89
  Lines        8830     8830
=======================================
  Hits         4176     4176
  Misses       3968     3968
  Partials      686      686

Flag
Coverage Δ

#linux
50.66% <ø> (ø)
:arrow_up:

#windows
42.24% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89623f2...0eec9c0. Read the comment docs.


[Potential Bug]: Station Mules find trades to haul within target station, moving cargo inplace

Describe the Bug
Station Mules will resell stuff to warehouse (pick stuff from warehouse and sell it back immediately instead of idle)
To Reproduce
Steps to reproduce the behaviour:

Assign station mules with two-way trade to a production station as a source and warehouse as a target
Populate the goods (make warehouse works)
Make sure production station is supplied
See that station mules start hauling stuff back and fourth on the warehouse
(seems to be more likely with more production stations and lots of mules)

Expected Behaviour
If no trades are available - idle. Mule never makes a trade to the same station it wants to pick stuff from
Version Info (please complete the following information):

X4 Foundations : v. 5.1.0 HF3 beta (479084)
Mules Extended Mod : v6.4.2
I downloaded the mod from: Nexusmods

Screenshots

can you use this post to provide a debug log for a mule that it doing this?
https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/issues/98#issuecomment-714633061

I will probably be adding another continue here to check that supplySource and supplyTarget are not the same object:
https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/blob/96d41971573955593cdc598d500d866f9b904434/aiscripts/station_mule.xml#L441
I could put it up higher but the loop nesting and logic in station mule has always been confusing and I think putting it there with the other continue is the safest place not to introduce a new bug.
Would still like to see a log file just to confirm everything that's going on.

It will be the same logic used by the supply mule to avoid same-station trades:
https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/blob/96d41971573955593cdc598d500d866f9b904434/aiscripts/mule.lib.evaluate_tradeoffers.xml#L69

Here you go. It did a few correct trades but then started its shenanigans with MREs and Paste (i.e. "moving 2060 Terran MRE (54/2) from Earth Warehouse to Earth Warehouse")
Pastebin to log

Eyo any luck with quick fixes?
Breaks the mod for me :(

Sorry I haven't gotten to it yet

Hope it's not a sign that something changed in the game that's causing the station mule to get into a weird part of the logic that it's not usually in. I've never actually seen this behavior before in hundreds of hours of using them. If multiple people are seeing it now, something else could be going on.

To be honest I'm not really all that interested in X4 or mules development right now, but I'll at least try to get the simple fix in and tested soon. If it's still broken after that, not sure when I'll feel like fixing it.

I'm in same boat I haven't played X4 in  while, but the MRE ware not being
traded has come up on steam.
Best Regards,
Geoffrey Hughes
On Mon, 8 Aug 2022, 11:54 pm Brian Hayden, @.***> wrote:

To be honest I'm not really all that interested in X4 or mules development
right now, but I'll at least try to get the simple fix in and tested soon.
If it's still broken after that, not sure when I'll feel like fixing it.
—
Reply to this email directly, view it on GitHub
https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/issues/160#issuecomment-1208161959,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFH3SZ2GMDJI2KV635PJNATVYEGQFANCNFSM53YEO44Q
.
You are receiving this because you were assigned.Message ID:
<Misunderstood-Wookiee/Mules-and-Warehouses-Extended/issues/160/1208161959
@github.com>

I will probably be adding another continue here to check that supplySource and supplyTarget are not the same object:
https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/blob/96d41971573955593cdc598d500d866f9b904434/aiscripts/station_mule.xml#L441

I am also experiencing this issue. I tried adding this at line 441
<do_if value="$supplySource == $supplyTarget">
    <continue />
</do_if>

and it didn't fix it.
I also spent some time looking for a workaround (and didn't succeed). I did find that checking the "No player in-system trade" option resulted in no activity at all, so I suspect the issue is that it's not finding any valid trades with the target station.

Hey I'm facing the same issue now. It was fine where there was just one factory supplying the warehouse but the second factory onward they keep buying and selling to the warehouse and starving my stations. Any way I can help?

I'm not sure what kind of bugs exist now as this hasn't been in active
development since x4 foundations version 5.0 I am not entiely sure why it
would do that but I dont have an interest for developing for X4 currently
Best Regards
On Sun, 26 Mar 2023, 3:01 pm Deeparth Gupta, @.***>
wrote:

Hey I'm facing the same issue now. It was fine where there was just one
factory supplying the warehouse but the second factory onward they keep
buying and selling to the warehouse and starving my stations. Any way I can
help?
—
Reply to this email directly, view it on GitHub
https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/issues/160#issuecomment-1483987923,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFH3SZ5GBJ3QUJEFPHB7LM3W565QZANCNFSM53YEO44Q
.
You are receiving this because you were assigned.Message ID:
<Misunderstood-Wookiee/Mules-and-Warehouses-Extended/issues/160/1483987923
@github.com>


issue with trust wallet connection

when i connect with trust wallet it show An unknown error occurred

Hi, is this a duplicate of https://github.com/nextchapterstudio/walletconnect_qrcode_modal_dart/issues/23?


Enhanced Footer and made it responsive #96

Description

Enhanced the Footer UI by adding social icons and making it thin/short
Made it responsive

Fixes #96

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] New and existing unit tests pass locally with my changes
[ ] I have maintained a clean commit history by using the necessary Git commands
[ ] I have checked that my code does not cause any merge conflicts

Screenshots (if applicable)

good work @devarsheecodess , can you please add the scroll-to-top button as well.
try to add it at the bottom right corner, then we are good to go ;)

good work @devarsheecodess , can you please add the scroll-to-top button as well. try to add it at the bottom right corner. and also on desktop screen, keep the logo at center and not at left side.
update the changes then we are good to go ;)

Sure, give me some time

https://github.com/user-attachments/assets/f2d24529-f3c9-4e50-91c6-419120fa9ee8
@yashmandi plz add gssoc-ext, hacktoberfest-accepted and level2 label here too as some of my PRs were not counted for GSSoC

good work @devarsheecodess !
kindly resolve the merge conflicts

Hi, i have resolved the conflicts and have added a scroll on top button. Plz add the labels on pull request too as it was told to us today by the program manager


Documentation not up-to-date with latest PyPI version

Before posting a bug report

[X] I have searched existing GitHub issues and documentation to make sure the issue and relevant resolutions do not already exist.

Expected behavior
There should be documentation for the latest PyPI version of FlamingPy 0.10.1b1
Actual buggy behavior
Only 0.10.1b1.dev0 and v0.8.2a5 are listed on the readthedocs
How to reproduce
Visit https://flamingpy.readthedocs.io/
System information
N/A

Tracebacks
No response
Additional context
No response

Thanks @nariman87 😌


readonly controls should be able to display an icon in addition to text

Schema updates for https://github.com/elyra-ai/canvas/issues/418

not needed


Discovery and MUC with Sharp XMPP

How does one with S22.Xmpp use the service discovery to list the available chatrooms, and then how does one join such a chat room?
Could not find a sample for that.

Unfortunately Sharp.Xmpp does not support for the time being MUC (XEP-0045, http://xmpp.org/extensions/xep-0045.html) and its not on the immediate roadmap, however I could provide any help needed if someone decided to implement that.

Thanks for the feed back. I was able to find another lib that does the MUC for me. Good luck with S22. It's by far the easiest to start with. But it lacks some major features (IMHO).

@sbsrouteur what other library are u using thanks


When using SqlColumnEncryptionAzureKeyVaultProvider with an expired client secret, bizarre error messages and symptoms result

When using SqlColumnEncryptionAzureKeyVaultProvider with an expired client secret, the following error is returned:
SqlException: New request is not allowed to start because it should come with valid transaction descriptor.
This error is very confusing and has nothing to do with the actual problem. After seeing this error, we then see the following error on all queries even when column encryption is not enabled on the command:
IndexOutOfRangeException: SOME_COLUMN_NAME
    at Microsoft.Data.SqlClient.SqlDataReader.GetOrdinal(string name)

(Note that the query actually does select SOME_COLUMN_NAME)
Full stack trace
SqlException: New request is not allowed to start because it should come with valid transaction descriptor.
Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, bool breakConnection, Action<Action> wrapCloseInAction)
Microsoft.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, bool breakConnection, Action<Action> wrapCloseInAction)
Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, bool callerHasConnectionLock, bool asyncClose)
Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, out bool dataReady)
Microsoft.Data.SqlClient.SqlDataReader.TryConsumeMetaData()
Microsoft.Data.SqlClient.SqlDataReader.get_MetaData()
Microsoft.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, string resetOptionsString, bool isInternal, bool forDescribeParameterEncryption, bool shouldCacheForAlwaysEncrypted)
Microsoft.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, bool returnStream, bool isAsync, int timeout, out Task task, bool asyncWrite, bool inRetry, SqlDataReader ds, bool describeParameterEncryptionRequest)
Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, bool returnStream, TaskCompletionSource<object> completion, int timeout, out Task task, out bool usedCache, bool asyncWrite, bool inRetry, string method)
Microsoft.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior)
NHibernate.AdoNet.AbstractBatcher.DoExecuteReader(DbCommand cmd)
NHibernate.Loader.Loader.GetResultSet(DbCommand st, QueryParameters queryParameters, ISessionImplementor session, IResultTransformer forcedResultTransformer)
NHibernate.Loader.Loader.DoQuery(ISessionImplementor session, QueryParameters queryParameters, bool returnProxies, IResultTransformer forcedResultTransformer, QueryCacheResultBuilder queryCacheResultBuilder)
NHibernate.Loader.Loader.DoQueryAndInitializeNonLazyCollections(ISessionImplementor session, QueryParameters queryParameters, bool returnProxies, IResultTransformer forcedResultTransformer, QueryCacheResultBuilder queryCacheResultBuilder)
NHibernate.Loader.Loader.DoList(ISessionImplementor session, QueryParameters queryParameters, IResultTransformer forcedResultTransformer, QueryCacheResultBuilder queryCacheResultBuilder)

Expected behavior
I expect a clear error message to be returned which states that column encryption was not possible due to the expired client secret
I do not expect it to "pollute" the connection pool and make all requests to the same database fail with bizarre error messages.
Further technical details
Microsoft.Data.SqlClient version: 5.1.4
.NET target: .NET 8.0
SQL Server version: 2022
Operating system: Windows 11
Additional context
<PackageReference Include="Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider" Version="3.0.0" />
NHibernate 5.5.2

Have you tried with 5.2.1 ?

SqlClient 5.2.1 does the same thing.

Hi @jehhynes thanks for filing this issue. I'm working on reproducing it. In the meantime if you already have a minimal repro you can share that would be much appreciated.

Hi @mdaigle I could create a minimal repro but it's dependent on a specific state in an external system (i.e. Expired Azure client secret) which I would be unable to share.

Understood. Even with that limitation it will be helpful to see.

I haven't been able to reproduce this with straight SqlClient usage. I'm wondering if the issue has something to do with the way that NHibernate is interacting with SqlClient.

@jehhynes Could you share the repro, please?

This repro's consistently in my application, but I have not been able to exactly reproduce outside of my application. It seems to be caused by a more complex combination of factors than I originally thought.
The error is occurring in an ASP.NET Core app, and I think it may have to do with multithreading. Upon further investigation, this error is initially received when rendering a view (using Html.PartialAsync):
Failed to decrypt column 'ssn59_479_'. Failed to decrypt a column encryption key using key store provider: 'AZURE_KEY_VAULT'. Verify the properties of the column encryption key and its column master key in your database. The last 10 bytes of the encrypted column encryption key are: 'C1-BA-F1-E9-5C-97-6D-39-D7-F6'. ClientSecretCredential authentication failed: A configuration issue is preventing authentication - check the error message from the server for details. You can modify the configuration in the application registration portal. See https://aka.ms/msal-net-invalid-client for details.  Original exception: AADSTS7000215: Invalid client secret provided. Ensure the secret being sent in the request is the client secret value, not the client secret ID, for a secret added to app '6859ea32-a175-4d32-9511-6f0d40637e1a'. Trace ID: 9989e0a9-5487-4530-9934-286a2f597c00 Correlation ID: ca4e081b-04d1-47bc-b5d3-4514f6e2a3fa Timestamp: 2024-08-20 19:33:12Z
Then another database query occurs from an IResultFilter attribute (in OnResultExecuted), which triggers this error:
New request is not allowed to start because it should come with valid transaction descriptor.
It seems the first error (which is the expected error) is hidden (presumably due to AspNetCore's multithreaded behavior) and instead the second error is show (which is not expected).
Based on these theories, I attempted to create a minimal repro using AspNetCore (attached). Although I wasn't able to get the exact same exception, I did encounter some strange/unexpected behavior/errors so I think it's starting to touch on this issue and may provide you what you need at least to begin troubleshooting.
The repro project

There's a connection string hardcoded into NHibernateConfigurationBuilder that will need to be set
It expects the following table: COR_Entity (Id long, Ssn varchar(20))
The Ssn column should be encrypted
There should be at least one row in the table with a non-null Ssn.
AzureTenantId and AzureClientId should be specified in the ColumnEncryption class
DisplaySsn.cshtml triggers the initial (expected) error, which you can see if you comment out OnResultExecutedAttribute
In OnResultExecutedAttribute, I observed two unexpected errors, as described in comments

AlwaysEncryptedRepro.zip
Thanks!

Update: I discovered that by adding a second attribute implementing IResultFilter.OnResultExecuted, we uncover an additional sequence of bizarre exceptions that you can observe by refreshing the page repeatedly:

The updated repro project:
AlwaysEncryptedRepro.zip

Update 2
So I further discovered that by making the ISessionFactory static (instead of rebuilding it with every request) I get a different sequence of errors:

This sequence is similar to what I observed in my application - see my StackOverflow question here:
https://stackoverflow.com/questions/78759572/sqlexception-new-request-is-not-allowed-to-start-because-it-should-come-with-va
The updated repro project:
AlwaysEncryptedRepro.zip

Thanks for the repros @jehhynes. I've been working through them and have a couple avenues for investigation.
Just to double check, are you running each of these repros with pooling enabled?
And same question for the original issue in your application, is pooling enabled there?
If you can, can you tell me if the issue still repros when you disable pooling?
Thanks!

This is a bug that is leaving connections in an inconsistent state with unread bytes still hanging on the wire. When pooling is enabled, the inconsistent connections are recycled back through to your application and result in undefined error behavior for new connections with the same connection string. The unread bytes off the wire from the last command interfere with the results for the new command.
A fix was merged to main last month and it looks like it's slated for the 6.0 release: #2618

Fixes for this have been ported to the 5.1.6 (#2818) and 5.2.2 (#2817) hotfixes that are coming out soon.

Hotfixes for 5.1.6 and 5.22 have been released!

What I'm seeing is that DrainData() is double counting the encrypted column.
Here's the sequence of events:

column header read
sharedState._nextColumnHeaderToRead++ (incremented from 0 to 1)
column data read
column data decryption (fails)
data drained

So at the time we drain the data, we've already read all of the bytes for the encrypted column off of the wire or out of the buffer, but we've not incremented the _nextColumnDataToRead  value from 0 to 1. This value is only incremented after we exit the scope of TdsParser.TryReadSqlValue(). DrainData() compares _nextColumnDataToRead to _nextColumnHeaderToRead to determine if we stopped part way through reading a column. If _nextColumnDataToRead < _nextColumnHeaderToRead, it assumes that the column data still needs to be read off the wire/out of the buffer. But we did already read out the column data. So when DrainData() tries to flush enough data for the length of the column, it will fail. Either this was the last column and there's no data available or we get into an inconsistent state where we read some of the next column but treat it as if it's this column.
If there's not enough data available, we wait on the socket for more data which will never arrive. This leads to a timeout, which is thrown in place of the column decryption error.

I have a draft PR here (#2825) that, in local testing, fixes the issue. Using this change with the repro produces the expected error.
I'm still looking into the best way to add tests for this to prevent regressions in the future.

Closing issue as PR has been merged


control the timer before it is put to sleep / futex etc

how to control the timer before it is put to sleep?

sorry, my bad. my repo didnt update in go.mod


restrucuture the code base

restructured the source code

Added a new class named SpecValidator

Added LicenseHeader in source files
Updated .gitignore
Added VisualStudio .njsProj and .sln files (helps while debugging using VS on windows)

Hi @amarzavery, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Amar Zavery). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


1.15.2 Crash

Running Forge 31.1.0 with these mods
jei-1.15.2-<IP_ADDRESS> (Just enough items)
Hwyla-forge-1.10.7-B71_1.15.1 (Heres what you're looking at)
MineMenu-1.15.1-1.8.3 (Self explanatory)
Opening Minemenu is fine until i try and click a submenu
only then does my game force me to the main menu and proceed to crash

Fixed in https://github.com/GirafiStudios/MineMenu/commit/2cbff182302fb898ef33ed9e8263b84b1e8552c2


outgoing webhooks: Fix docs, error handling, etc.

(Feel free to merge once you fix the comment above and get CI to pass; not sure why it hasn't finished yet but probably a GitHub operational problem...)

Oh, never mind the GitHub operational error comment, I see the last couple commits are very new; well, I did review them, so we just need to wait for CI there.

I added more commits, so I'll hold off on merging until you take another look at this, @timabbott.
@aero31aero This might be a good thing for you to review, since you've been looking at bot code lately.  No hurry--if you look at this after we merge, it would still be good to get your feedback and get another person knowing this code.

Merged, thanks @showell!  I'd love it if you still gave this PR (or maybe just the outgoing webhook code) a read @aero31aero!

@showell a quick follow-up project for you might be to check out https://github.com/zulip/zulip/pull/10027; that improves the documentation for sample response types.  (I'm going to give it a look now as well)

Okay, I'll give this a read today.


Refactor - Exthost: Move handlers to Msg module

It's not too different from the Exthost_SCM/Exthost_Terminal model we have - I just pivoted it based on Request/Reply/Response to document the protocol. The modules are still standalone and could be split out. The challenge is the Request depends on Client, which depends on Msg, so I pivoted it this way to avoid the dependency cycle.

/azp run

Hmm, yeah I don't really understand the overall context of this, but as you say it's easy to split them out later anyway. I just find a Msg layer very odd architecturally as it describes a technical concept rather than a domain concept.

I just find a Msg layer very odd architecturally as it describes a technical concept rather than a domain concept.

Right, Msg probably isn't the right name anymore - might get shuffled around as I implement sending responses back. I'm sure there's a better, more descriptive name. 🤔  But I'll bring this in for now and continue to think about it.


Support httpsProxy in OpenSearch Dashboards for OIDC support

Is your feature request related to a problem? Please describe.
When configuring OIDC OpenSearch Dashboards needs to connect with https to our outside OIDC / OpenID Connect provider.
Since OpenSearch Dashboards is installed in a closed environment all outside / internet connection has to go through an httpsProxy / SOCKS proxy.
Pr now I have not found / not found documentation to support setting httpsProxy parameters for OpenSearch Dashboards.
Describe the solution you'd like
Add support for setting httpsProxy / httpProxy for OpenSearch Dashboards.
Documentation for the same.
Describe alternatives you've considered
The current workaround we are using are local proxying with netcat + host aliases. Not a very nice sollution, but "works".
Additional context
N/A

Sorry for not responding earlier.
We are doing something like this how, only using an socat proxy.
However, I consider this a workaround, not a good solution, so in my mind this issue should not be closed.
A good solution would be that OpenSearch Dashboards supported proxy directly.
And the underlying software for dashboards do have support for proxies.

Hello,
Some news about the support of this setting ?
This is a blocking point in the use of OIDC in some environments
Thanks

Dear,
Have also issue when configuring alert to slack channel. Opensearch Dashboard is ignoring system proxy.
Pretty annoying.

If you are behind a proxy you need to add below configs to your “/etc/opensearch/jvm.options” file

This will apply to OpenSearch proper, but not to OpenSearch Dashboard which the security-dashboards-plugin / OpenSearch Dashboards Security Plugin

PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE PLEASE

I really need this

@DavidoRotho This PR was merged recently and will be released in 2.12 in January. #1650
Would this PR solve the issue?

@cwperks, thanks for the reply, I don't think so as it doesn't appear to update anything related to a proxy.
There seems to be a poor understanding of the issue here, this incorrectly closed issue details the problem well: https://github.com/opensearch-project/security-dashboards-plugin/issues/114

https://github.com/opensearch-project/security-dashboards-plugin/blob/main/server/auth/types/openid/routes.ts#L90 - setupRoutes, or better yet, a common place, needs to support setting an https_proxy ++ proxy, such as squid and similar.
Again, this is for when OpenSearch Dashboards is installed with no direct internet access, but has to go through a explicitly defined* proxy server.
opensearch-dashboards --> https_proxy --> OIDC-provider

There are quite a few issues regarding this floating around, such as https://github.com/nodejs/node/issues/8381
Different programming languages have various options for how you configure this as an environment variable
http_proxy=<proxy-host>
https_proxy=<proxy-host>
HTTP_PROXY=<proxy-host>
HTTPS_PROXY=<proxy-host>

http.proxyHost=<proxy-host>  # java

@sastorsl we are hitting this issue as well. The above solution that was posted by @aoguan1990 is unclear to me.
What is your current work around to allow OIDC to reach out to login.microsoftonline.com when a https_proxy like squid is required ?

+1 we have the same problem here

WORKAROUND:

Setup an socat proxy as a separate pod / container that proxies requests to your OIDC providers hostname through the company / internal proxy (i.e. squid)
Add an entry to hostAliases to OpenSearch Dashboards, see https://kubernetes.io/docs/tasks/network/customize-hosts-file-for-pods/

See i.e. https://github.com/fluxcd/source-controller/issues/131#issuecomment-769419918 for a similar discussion.

+1 we have the same problem here

WORKAROUND:

Setup an socat proxy as a separate pod / container that proxies requests to your OIDC providers hostname through the company / internal proxy (i.e. squid)
Add an entry to hostAliases to OpenSearch Dashboards, see https://kubernetes.io/docs/tasks/network/customize-hosts-file-for-pods/

See i.e. fluxcd/source-controller#131 (comment) for a similar discussion.

Thanks for the hint, the solution works fine for requests which do not depend on the headers being sent. I'm using something like this:
  containers:
  - image: alpine/socat:<IP_ADDRESS>
    name: socat-proxy
    args:
      - -v
      - -dddd
      - -lh
      - TCP-LISTEN:8443,fork,reuseaddr,children-shutup=1
      - PROXY:proxy.server.url:<host>:443,proxyport=8080,proxy-authorization=<username>:<password>
    command:
    - socat
    ports:
    - containerPort: 8443
      protocol: TCP

As soon as the http request sends an authorization header the request via the proxy fails. Is there anything I'm missing?

To have Proxy support this code https://github.com/opensearch-project/security-dashboards-plugin/blob/<IP_ADDRESS>/server/auth/types/openid/openid_auth.ts#L179-L190 should you ProxyAgent instead of HTTP.Agent or HTTPs.Agent


Feature/tron indexer

Tron indexer
Uses pooling with configurable interval to get latest block transactions and notify clients.
Test coverage added.
Can use Ankr api for testing.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


reloading the pull request creation page creates duplicate pull requests

Description
See https://gitea.com/gitea/go-sdk/pulls: there are two identical pull requests:

https://gitea.com/gitea/go-sdk/pulls/598
https://gitea.com/gitea/go-sdk/pulls/597

It happened while trying to submit a pull request while the gitea.com gateway was timeout (504 Gateway Time-out). Multiple requests were sent (reloading the URL creating the pull request https://gitea.com/gitea/go-sdk/compare/master...earl-warren/go-sdk:wip-issue-delete).
The final attempt showed a page explaining the pull request already exists:

But despite this safeguard two of the attempts raced against each other and created a duplicate. There is a race condition somewhere. An integration test trying to repeat these conditions would eventually run into this problem.
Gitea Version
dev
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
a
Screenshots
a
Git Version
a
Operating System
a
How are you running Gitea?
a
Database
No response

I don't think it's likely that this is due to reloading the page - I think it's more likely to be due to a double click on create pull request button - we need to add a disable after click on these.

Browse https://gitea.com/gitea/go-sdk/compare/master...earl-warren/go-sdk:wip-issue-delete (GET)
click submit https://gitea.com/gitea/go-sdk/compare/master...earl-warren/go-sdk:wip-issue-delete (POST)
Gateway timeout 504
Reload https://gitea.com/gitea/go-sdk/compare/master...earl-warren/go-sdk:wip-issue-delete (POST)


litreally can't use the 0.5.2 engine

Describe your bug here.
everytime i extract the engine and launch the exe it opens, closes, and deletes itself. if i try to re-extract the exe it says i need admin permission for the folder (i am an admin)
https://user-images.githubusercontent.com/87594698/157180879-be043b6f-57a6-4cf4-80ec-2d7401cf38e6.mp4
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
no

Antivirus

I have the same thing happening

Antivirus
I turned off the antivirus but it still doesn't work

Antivirus

I turned off the antivirus but it still doesn't work


Post release automated changes for databoxedge releases

Post release automated changes for azure-arm-databoxedge-profile-2020-09-01-hybrid

API change check
API changes are not detected in this pull request.


Fix: opae.io init command exit with error message in case of iommu  n…

…ot enabled
opae.io init  bind PCIE end point with VFIo-PCIe driver,
if iommu  not enabled on system opae.io init command exit with error message
“iommu is not enabled” without unbind current dfl-pci driver

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.508%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
15809

Relevant Lines:
24507

💛  - Coveralls

Can we improve the commit message to something like the following?
opae.io: Fix error handling when binding the vfio-pci driver fails
The 'opae.io init' command can fail to bind the vfio-pci driver when the IOMMU is disabled, leaving the system seemingly unable to bind another driver. The fix is to check if the IOMMU is enabled before even attempting to bind the vfio-pci driver.