Unable to create pvc using cephfs

Describe the bug
We have a cephfs cluster and we have deployed the  ceph-csi-cephfs chart in our kubernetes cluster (v1.19.9) with the following values:
USER-SUPPLIED VALUES:
csiConfig:
- cephFS:
    subvolumeGroup: csi
  clusterID: 8fxxxxxxxxxxxxxxxxxxxxxxxa0
  monitors:
  - <IP_ADDRESS>:6789
  - <IP_ADDRESS>:6789
  - <IP_ADDRESS>:6789
provisioner:
  replicaCount: 1
secret:
  adminID: admin
  adminKey: AQCccccccccccccccccccccc==
  create: true
storageClass:
  allowVolumeExpansion: true
  clusterID: 8fxxxxxxxxxxxxxxxxxxxxxxxa0
  create: true
  fsName: k8sfs
  name: csi-cephfs-sc
  reclaimPolicy: Delete

we have checked and we can mount the volume in the kubernetes nodes using the following command:
mount -v -t ceph -o name=admin,secretfile=ceph.keyring <IP_ADDRESS>:6789:/k8scephfs /srv/cephfs3/

but when we try to deploy a pvc we see the pvc in pending mode showing the following status:

This is the ceph status:

here you can see the logs (ceph.audit.log) when we try deploy the pvc.

A clear and concise description of what the bug is.
Environment details

Image/version of Ceph CSI driver :  quay.io/cephcsi/cephcsi:v3.8.0  first we were checking with v3.4.0 with the same result

Helm chart version : ceph-csi/ceph-csi-cephfs        3.8.0

Kernel version : Linux vm-k8s-test-worker-1 4.15.0-109-generic #110-Ubuntu SMP Tue Jun 23 02:39:32 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Mounter used for mounting PVC (for cephFS its fuse or kernel. for rbd its
krbd or rbd-nbd) :

Kubernetes cluster version :

Ceph cluster version :

Steps to reproduce
Steps to reproduce the behavior:

Deploy the chart with the previos values
Deployment pvc and statefulset
See error: the pvc it is in pending status without the bonding

Actual results
When we try to deploy a pvc it is getting in pending status.
Expected behavior
Run the pod with the pvc mounted inside.
Logs

csi-rbdplugin/csi-cephfsplugin and driver-registrar container logs from
plugin pod from the node where the mount is failing.

I0329 10:59:56.394232       1 utils.go:195] ID: 26 Req-ID: pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 GRPC call: /csi.v1.Controller/CreateVolume
I0329 10:59:56.394554       1 utils.go:206] ID: 26 Req-ID: pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 GRPC request: {"capacity_range":{"required_bytes":1073741824},"name":"pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424","parameters":{"clusterID":"8f7b6e44-5b7a-48f7-83c5-dd83fb0b7ea0","csi.storage.k8s.io/pv/name":"pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424","csi.storage.k8s.io/pvc/name":"www-web-0","csi.storage.k8s.io/pvc/namespace":"storage","fsName":"k8s_fs"},"secrets":"***stripped***","volume_capabilities":[{"AccessType":{"Mount":{}},"access_mode":{"mode":7}}]}
E0329 10:59:56.394667       1 controllerserver.go:269] ID: 26 Req-ID: pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 an operation with the given Volume ID pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 already exists
E0329 10:59:56.394697       1 utils.go:210] ID: 26 Req-ID: pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 GRPC error: rpc error: code = Aborted desc = an operation with the given Volume ID pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 already exists
I0329 11:00:28.774657       1 utils.go:195] ID: 27 GRPC call: /csi.v1.Identity/Probe
I0329 11:00:28.774902       1 utils.go:206] ID: 27 GRPC request: {}
I0329 11:00:28.774974       1 utils.go:212] ID: 27 GRPC response: {}
I0329 11:01:28.749331       1 utils.go:195] ID: 28 GRPC call: /csi.v1.Identity/Probe
I0329 11:01:28.751994       1 utils.go:206] ID: 28 GRPC request: {}
I0329 11:01:28.752024       1 utils.go:212] ID: 28 GRPC response: {}
I0329 11:02:04.408556       1 utils.go:195] ID: 29 Req-ID: pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 GRPC call: /csi.v1.Controller/CreateVolume
I0329 11:02:04.408948       1 utils.go:206] ID: 29 Req-ID: pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 GRPC request: {"capacity_range":{"required_bytes":1073741824},"name":"pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424","parameters":{"clusterID":"8f7b6e44-5b7a-48f7-83c5-dd83fb0b7ea0","csi.storage.k8s.io/pv/name":"pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424","csi.storage.k8s.io/pvc/name":"www-web-0","csi.storage.k8s.io/pvc/namespace":"storage","fsName":"k8s_fs"},"secrets":"***stripped***","volume_capabilities":[{"AccessType":{"Mount":{}},"access_mode":{"mode":7}}]}
E0329 11:02:04.409167       1 controllerserver.go:269] ID: 29 Req-ID: pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 an operation with the given Volume ID pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 already exists
E0329 11:02:04.409292       1 utils.go:210] ID: 29 Req-ID: pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 GRPC error: rpc error: code = Aborted desc = an operation with the given Volume ID pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 already exists

If the issue is in PVC creation, deletion, cloning please attach complete logs
of below containers.

csi-provisioner and csi-rbdplugin/csi-cephfsplugin container logs from the
provisioner pod.

I0329 10:54:48.792549       1 event.go:285] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"storage", Name:"www-web-0", UID:"7edca0a0-
f18f-4de1-9ba9-73bf239ab424", APIVersion:"v1", ResourceVersion:"128546450", FieldPath:""}): type: 'Normal' reason: 'Provisioning' External provisioner i
s provisioning volume for claim "storage/www-web-0"
W0329 10:57:48.792937       1 controller.go:934] Retrying syncing claim "7edca0a0-f18f-4de1-9ba9-73bf239ab424", failure 0
E0329 10:57:48.793184       1 controller.go:957] error syncing claim "7edca0a0-f18f-4de1-9ba9-73bf239ab424": failed to provision volume with StorageClas
s "csi-cephfs-sc": rpc error: code = DeadlineExceeded desc = context deadline exceeded
I0329 10:57:48.793844       1 event.go:285] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"storage", Name:"www-web-0", UID:"7edca0a0-
f18f-4de1-9ba9-73bf239ab424", APIVersion:"v1", ResourceVersion:"128546450", FieldPath:""}): type: 'Warning' reason: 'ProvisioningFailed' failed to provi
sion volume with StorageClass "csi-cephfs-sc": rpc error: code = DeadlineExceeded desc = context deadline exceeded
I0329 10:57:49.293732       1 controller.go:1337] provision "storage/www-web-0" class "csi-cephfs-sc": started
I0329 10:57:49.294592       1 event.go:285] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"storage", Name:"www-web-0", UID:"7edca0a0-
f18f-4de1-9ba9-73bf239ab424", APIVersion:"v1", ResourceVersion:"128546450", FieldPath:""}): type: 'Normal' reason: 'Provisioning' External provisioner i
s provisioning volume for claim "storage/www-web-0"
W0329 10:57:49.303371       1 controller.go:934] Retrying syncing claim "7edca0a0-f18f-4de1-9ba9-73bf239ab424", failure 1
E0329 10:57:49.303401       1 controller.go:957] error syncing claim "7edca0a0-f18f-4de1-9ba9-73bf239ab424": failed to provision volume with StorageClas
s "csi-cephfs-sc": rpc error: code = Aborted desc = an operation with the given Volume ID pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 already exists
I0329 10:57:49.303416       1 event.go:285] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"storage", Name:"www-web-0", UID:"7edca0a0-
f18f-4de1-9ba9-73bf239ab424", APIVersion:"v1", ResourceVersion:"128546450", FieldPath:""}): type: 'Warning' reason: 'ProvisioningFailed' failed to provi
sion volume with StorageClass "csi-cephfs-sc": rpc error: code = Aborted desc = an operation with the given Volume ID pvc-7edca0a0-f18f-4de1-9ba9-73bf23
9ab424 already exists
I0329 10:57:50.303664       1 controller.go:1337] provision "storage/www-web-0" class "csi-cephfs-sc": started
I0329 10:57:50.303858       1 event.go:285] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"storage", Name:"www-web-0", UID:"7edca0a0-
f18f-4de1-9ba9-73bf239ab424", APIVersion:"v1", ResourceVersion:"128546450", FieldPath:""}): type: 'Normal' reason: 'Provisioning' External provisioner i
s provisioning volume for claim "storage/www-web-0"If the issue is in PVC mounting please attach complete logs of below containers.

- if required attach dmesg logs.

**Note:-** If its a rbd issue please provide only rbd related logs, if its a
cephFS issue please provide cephFS logs.

# Additional context #

Add any other context about the problem here.

For example:

Any existing bug report which describe about the similar issue/behavior

W0329 10:57:50.322911       1 controller.go:934] Retrying syncing claim "7edca0a0-f18f-4de1-9ba9-73bf239ab424", failure 2
E0329 10:57:50.323268       1 controller.go:957] error syncing claim "7edca0a0-f18f-4de1-9ba9-73bf239ab424": failed to provision volume with StorageClas
s "csi-cephfs-sc": rpc error: code = Aborted desc = an operation with the given Volume ID pvc-7edca0a0-f18f-4de1-9ba9-73bf239ab424 already exists
I0329 10:57:50.323380       1 event.go:285] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"storage", Name:"www-web-0", UID:"7edca0a0-
f18f-4de1-9ba9-73bf239ab424", APIVersion:"v1", ResourceVersion:"128546450", FieldPath:""}): type: 'Warning' reason: 'ProvisioningFailed' failed to provi
sion volume with StorageClass "csi-cephfs-sc": rpc error: code = Aborted desc = an operation with the given Volume ID pvc-7edca0a0-f18f-4de1-9ba9-73bf23
9ab424 already exists

If need it some other data, please only tell me.
Francisco Rodriguez

Hi, Madhu,
I'm going to check.
thanks for your quick response!!

@franitel please check if its a network connectivity issue or not, https://rook.io/docs/rook/latest/Troubleshooting/ceph-csi-common-issues/#ceph-health can help you with the steps for debugging.

We have check this before and it seems to be working fine
root@ceph-mon-test1:/home/pedrop# ceph health detail
HEALTH_OK

❯ k exec -it -n storage ceph-csi-driver-ceph-csi-cephfs-provisioner-7f84fc97fb-j9rwh -c csi-cephfsplugin -- /bin/bash
[root@vm-k8s-test-worker-2 /]# curl curl <IP_ADDRESS>:3300 2>/dev/null
ceph v2

monitors:

<IP_ADDRESS>:6789
<IP_ADDRESS>:6789
<IP_ADDRESS>:6789

Did you check for the 6789 port as well?

monitors:

<IP_ADDRESS>:6789
<IP_ADDRESS>:6789
<IP_ADDRESS>:6789

Did you check for the 6789 port as well?

yes
root@vm-k8s-test-worker-2:/home/pedrop# nc -zv <IP_ADDRESS> 6789
Connection to <IP_ADDRESS> 6789 port [tcp/*] succeeded!

❯ k exec -it -n storage ceph-csi-driver-ceph-csi-cephfs-provisioner-7f84fc97fb-j9rwh -c csi-cephfsplugin -- /bin/bash
[root@vm-k8s-test-worker-2 /]# curl curl <IP_ADDRESS>:6789 2>/dev/null
[root@vm-k8s-test-worker-2 /]#

@Madhu-1 i've managed to execute commands from the plugin container but i have to specify the user/keyring. Could be the case the provisioner is not fetching properly the configuration?
k exec -it -n storage ceph-csi-driver-ceph-csi-cephfs-provisioner-9584bc97-j6vgq -c csi-cephfsplugin -- /bin/bash
[root@vm-k8s-test-worker-2 /]# ceph status --user=admin --key=my_key
  cluster:
    id:     8f7b6e44-5b7a-48f7-83c5-dd83fb0b7ea0
    health: HEALTH_OK

  services:
    mon: 3 daemons, quorum ceph-mon-test2,ceph-mon-test3,ceph-mon-test1 (age 6h)
    mgr: ceph-mon-test3(active, since 5d), standbys: ceph-mon-test2, ceph-mon-test1
    mds: k8s_fs:1 {0=ceph-mon-test1=up:active} 2 up:standby
    osd: 6 osds: 6 up (since 5d), 6 in (since 8d)
    rgw: 3 daemons active (radosgw.ceph-mon-test1, radosgw.ceph-mon-test2, radosgw.ceph-mon-test3)

  task status:

  data:
    pools:   21 pools, 337 pgs
    objects: 564 objects, 914 MiB
    usage:   8.7 GiB used, 51 GiB / 60 GiB avail
    pgs:     337 active+clean

@ppodevlab are you able to execute ceph commands from the container? see https://www.mrajanna.com/troubleshooting-cephcsi/ might help you

we just did a test creating static pvcs following https://github.com/ceph/ceph-csi/blob/devel/docs/static-pvc.md#cephfs-static-pvc. We created the volume and volumegroup from the plugin container within the provisioner pod and we can mount static volumes into pods... So i do not think it is a network issue.

@ppodevlab am not sure what the problem is with your setup, one thing is you need to pass the monitor,user and key mentioned in the storageclass and configmap when you are executing the commands from the provisioner pod because those are not available by default on it

Kubernetes v1.19.9 is rather old and unmaintained. We do not test recent Ceph-CSI versions against that version anyore, possibly something broke and recent kubernretes-csi sidecars are not compatible with the old version?


proposal: errors: In() to check Is against multiple errors

Proposal Details
Problem
The code looks redundant and cumbersome in cases when you need to check an error match several times. Example:
func foo() {
  err := bar()
  if errors.Is(err, err1) || errors.Is(err, err2) || errors.Is(err, err3) {
    // some logic
  }
}

Solution
A new function that will allow you to check for errors like this:
func foo() {
  err := bar()
  if errors.In(err, err1, err2, err3) {
    // some logic
  }
}

Implementation
package errors

func In(err error, target ...error) bool {
  for _, v := range target {
    if errors.Is(err, v) {
      return true
    }
  }

  return false
}

Related Issues

proposal: errors: add Errors as a standard way to represent multiple errors as a single error #47811 (closed)
proposal: errors: add Errors function to undo Join #57358 (closed)
proposal: errors: add error matching utility functions #65121 (closed)
[Feature Request] Shorter error catching #18425 (closed)
proposal: errors: add NewJoinedErrors #48831 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

I don't think it's a very common thing to do:
https://github.com/search?q=language%3AGo+%2F(errors.Is.*\|\|)%2B%2F&type=code

How about
// Match returns the matched error in targets for err.
func Match(err error, targets ...error) error

?


Errors: GraphiQL vs Apollo

I know there's a lot of issues about errors but I'm not quite sure where this one fits in… I noticed that GraphiQL gives you a lot more useful details about errors compared to Apollo. For the exact same mutation, I got:
Apollo:
Uncaught (in promise) Error: Network error: Converting circular structure to JSON
    at new ApolloError (modules.js?hash=1b8807c…:151984)
    at modules.js?hash=1b8807c…:151360
    at meteor.js?hash=e3f53db…:1105

GraphiQL:
{
  "data": {
    "sendNewsletter": null
  },
  "errors": [
    {
      "message": "Cannot read property 'addHttp' of undefined",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "sendNewsletter"
      ]
    }
  ]
}

Oh weird… now the mutation works in GraphiQL but not in the app. I guess it's not an error reporting problem after all, so I'll close this for now.


JPM deps does not support repositories with the branch name 'main'

It seems to expect master only.

You can manually specify a branch or any commitish with :tag in a dependency specification.
(declare-project
  :dependencies [{:repo "https://github.com/a/b.git" :tag "main"}])


An Ising Optimization algorithm for solving the 0-1 Knapsack Problem

Summary
A method of solving the 0-1 Knapsack optimization problem using the VQE algorithm
Details and comments
The code adds a way of generating a list of WeightedPauliOperator that form a Hamiltonian for the cost function of the Knapsack problem. This list can be used with a VQE algorithm for solving this problem similar to max-cut and tsp.
This code was largely developed during Qiskit Camp Asia 2019 together with @dongsin-kim,
@R07222062, @ylchen0918 with the help of @a-matsuo.
The cost function is detailed in the comments/documentation, but a detailed explanation together with testing code can also be found here

@woodsp-ibm Thanks for the info.
P.S. I'm really excited I get to be part of the contributors of Qiskit.


lewd filter does not work on statistics

Steps to reproduce
Add some lewd entries and turn on the "x" on lewd filter in the library(to not show lewd entries) but if you go to statistics, the lewd entries show there in the "in library" and "completed series"(if you have one) and more...
Expected behavior
Filter statistics based on if filter is on, off or only lewd
Actual behavior
Shows lewd entries in statistics
Crash logs
No response
Tachiyomi version
tachiyomisy r530
Android version
Android 12
Device
s10
Other details
No response
Acknowledgements

[X] This is a TachiyomiSY specific issue that does not happen in Tachiyomi Preview.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 1.9.3.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Not sure why you expected lewd filter to work there, it doesn't consider library filters there at all.

So is there any chance to implement a lewd filter for statistics?

🤷♂


webapp config container set fail after network reset

This is autogenerated. Please review and update as needed.
Describe the bug
Command fails during network outage. Cannot run if again.
Command Name
az webapp config container set
Errors:
'NoneType' object has no attribute 'reserved'
Traceback (most recent call last):
python3.7/site-packages/knack/cli.py, ln 206, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 603, in execute
    raise ex
cli/core/commands/__init__.py, ln 661, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
cli/core/commands/__init__.py, ln 654, in _run_job
    six.reraise(*sys.exc_info())
...
cli/command_modules/appservice/custom.py, ln 1049, in update_container_settings
    _add_fx_version(cmd, resource_group_name, name, docker_custom_image_name, slot)
cli/command_modules/appservice/custom.py, ln 804, in _add_fx_version
    linux_fx = fx_version if web_app.reserved else None
AttributeError: 'NoneType' object has no attribute 'reserved'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az webapp config container set --name {} --resource-group {} --docker-custom-image-name {}

Expected Behavior
Environment Summary
Darwin-18.7.0-x86_64-i386-64bit
Python 3.7.5
Shell: bash

azure-cli 2.0.77

Extensions:
front-door 1.0.2
webapp 0.2.24

Additional Context

Please re-try there is no  change on our end here . Who re-trying run with --debug flag to get detailed errors.

Closing since there was no update on this for more than 3 days. Please re-activate if this is still an issue. Thanks!

I am experiencing the same error with the same az webapp config container set --name {} --resource-group {} --docker-custom-image-name {}. Is there any update?


Capitalize the letters 'API' in the readme

Change it from Discord api to Discord API.

thanks for pointing it out


Confusing subtyping annotations muddy real issues

I'm not sure how fixable this issue is. Take the following example, and associated error:
module Test

open FStar.List

assume val pairs_with_sum (n: nat) : list (p: (nat * nat){fst p + snd p = n})

assume val product (a: Type) (l1: list a) (l2: list a) : list (a * a)

type bin_tree =
| Leaf
| Node of bin_tree * bin_tree

let rec trees_of_size (s: nat) : list bin_tree =
  if s = 0 then
    [Leaf]
  else
    List.Tot.concatMap (fun (s1, s2) -> List.Tot.map Node (product _ (trees_of_size s1) (trees_of_size s2)))
                       (pairs_with_sum (s - 1))

Subtyping check failed; expected type Prims.list ((s:Prims.nat{ s << s }) * (s:Prims.nat{ s << s })); got type Prims.list ((p:(Prims.nat * Prims.nat){ Prims.b2t (Prims.fst p + Prims.snd p = s - 1) }))

Where does the annotation on s:Prims.nat{ s << s } come from? I tend to see similar annotations (z:…{z << z}) from time to time, but I'm never sure what to make of them.

concatMap is polymorphic and got wrongly instantiated with s:Prims.nat{ s << s }, which indeed looks strange, since if indeed the s on both sides were the same (which I'm not completely sure of, this might be a printing issue?) then this refinement is false since our termination ordering is of course irreflexive.
If passing #(p:(nat*nat){ Prims.fst p + Prims.snd p = s - 1 }) as an explicit argument to concatMap this works, so this seems indeed a type inference problem.
@nikswamy Is this a bug or a feature? :)


Decouple NewSegmentFromHeader from package http

This is a continuation of @jamiecuthill's question in #220. I believe we're in a similar situation.
We're currently using 0.9.4 (which is working great) and are looking to upgrade to the 1.x.x release.
Each of our microservices pass a seg.DownstreamHeader().String() to the microservice it is calling.
At the moment, each of our internal microservice RPC handlers have code that is something similar to this:
func (v voucherService) GetVoucherCode(
	ctx context.Context,
	in *pb.GetVoucherCodeRequest,
	out *pb.GetVoucherCodeResponse,
) error {
    ctx, seg := xray.NewSegmentFromHeader(
        ctx,
        "internal.Voucher.GetVoucherCode",
        header.FromString(in.GetTraceHeader()), // the "downstream header" from above
    )

    ...
    ...
    ...

    seg.Close(nil)
}

So in 1.x.x the NewSegmentFromHeader function has changed from this
func NewSegmentFromHeader(ctx context.Context, name string, h *header.Header) (context.Context, *Segment)

to this
func NewSegmentFromHeader(ctx context.Context, name string, r *http.Request, h *header.Header) (context.Context, *Segment)

In my testing, with the latest version of this library, if we set the *http.Request parameter to nil but continue to pass through the downstream header in the fourth parameter then X-ray doesn't create a new subsegment and instead attaches subsegments in the method to the parent segment.
I'm not really sure what is the correct method to use now that is the equivalent of what we were doing before?

Hi,
Thanks for opening this issue. I think as part of the 1.x.x release we might have changed some of the code behaviors. I think as per your use case if you pass request as nil in 1.x.x version then it will execute this (https://github.com/aws/aws-xray-sdk-go/blob/master/xray/segment.go#L86) codepath and results in not respecting sampling decision (https://github.com/aws/aws-xray-sdk-go/blob/master/xray/segment.go#L93) in trace header. I think we can come up with a way to incorporate your use case so when you pass request as nil it should work. Feel free to post a PR to resolve this issue!

Hi @alexbilbie ,
Ideally NewSegmentFromHeader should create a new segment even if you pass request as nil. The only behavior change introduced in GA release was related to sampling. If you're still experiencing this issue, would you be able to provide repro steps so that I can confirm if this a bug and needs to be fixed ?

Hi @alexbilbie ,
Ideally NewSegmentFromHeader should create a new segment even if you pass request as nil. The only behavior change introduced in GA release was related to sampling. If you're still experiencing this issue, would you be able to provide repro steps so that I can confirm if this a bug and needs to be fixed ?


Full path to vignettes

Changed relative path to full path in README.md to fix links in pkgdown

Great, thanks @schifferl! Should I merge this pull request by myself?

Good work @d-golzato, merging and closing now.


Scraper: Add NONE to IMAGE SOURCE option

Why always have to download the image source? is there any reason? If I only need the manual or the video to complete my gamelist or game, right now there is no way to download it without overwriting the thumbnail. It would be very positive and a more complete and powerful Scraper tool with a pure “cherry picker” function simply adding a “NONE” option to image. This is possible?

scrapping "image" don't overwride the thumbnail !?!

Sorry when I say "thumbnail" I mean the main image showed either in format, mix v1, mix v2, screenshot etc... In any case, what I propose here is clear. Simply if it would be possible to scrape without being forced to choose an image type without always overwriting the main image (ok not thumbnail). I have created my own mixes, if I need to scrape only videos or manuals right now it is not possible without overwrite mi own mixes.

You are talking about the "manual per game scrap" ?

I'm talking about the general scraper, about the options screen before starting the scraping, as in the attached image. And more specifically from the "image source" option as highlighted in the image.

"manual per game scrap"

Hmm, where is the "manual per game scrap"? in the game options only appears the option "SCRAPE" for me. When I choose to scrape, it doesn't give me any options and it goes directly to scrape all the data.

This is another thread but I think it would be good to also show the options screen before scraping a single game, as in global scraping, choosing which data or media to download and which to discard before starting to scrape the specific game.

done

Tested! works fine!! good job @fabricecaruso!
This feature can also be very good to implement ... IMO:
"When I choose to scrape, it doesn't give me any options and it goes directly to scrape all the data. This is another thread but I think it would be good to also show the scraper options screen before scraping a single game, as in global scraping, choosing which data or media to download and which to discard before starting to scrape the specific game."


when will the code and/or checkpoints be released?

Hello, thank you for your wonderful work. When will the code and/or checkpoints be released? If possible, please provide how much time is required for this release?
Thanks!

Hello, thank you for your wonderful work. When will the code and/or checkpoints be released? If possible, please provide how much time is required for this release? Thanks!

I apologize for only just noticing the issue. Due to my application for a PhD, I will be quite busy in the near future. The checkpoint is expected to be in February.


[API/Vue/DB] /matches makes too much sql queries

currently match table only holds team1id, team2id, serverid and owner id(userid).
which means it doent contains team's name, roasters, server name or user names.
I know this is pretty normal DB structure,but we may need to create a lot of sql queries to get match list with team name and etc.
this is current get5-web-go log when user opens http://localhost:8081/#/matches .

potential solution1 :
currently front-end requests matchinfo for each match in list(20).
so, embed teamname and other informations into list request(GetMatches) .
it decreases HTTP requests,Howerver, MySQL queries won't decrease.
so this is not best solution imo.
I think I can solve this issue by using Gorm's Preloading method.

#214


Publish the Community CRM Runbook

Remove the draft flag from the Community CRM Runbook so that it's visible on the live site, contribute.cncf.io.
Preview at https://deploy-preview-114--cncf-contribute.netlify.app/maintainers/community/crm-runbook/

I don't know that much about CRMs or how they are being used for CNCF project communities. So can I ask a few dumb questions?

Which projects are currently using CRMs?
Where are these CRMs hosted and who has access to the data?
Is there any worry about data collection (related to previous question)?

@CathPag Can you help answer Saad's questions about CRMs?

Thanks, let me have someone else respond as I'd be mostly guessing.

I'll try to answer @saad-ali's questions from Savannah's perspective:

Which projects are currently using CRMs?

Linkerd is currently using Savannah CRM.
In addition to that it's been used by the EdgeX and LFEdge projects in the Linux Foundation as well.

Where are these CRMs hosted and who has access to the data?

Savannah CRM is hosted on AWS. Only people added to your community's account on Savannah has access to the data. Other CRMs appear to all be similar (hosted on a public cloud, access only to invited team members).
Savannah CRM is open source (AGPLv3) which means you can run it yourself if you want, but you will need to configure all the integrations with other platforms to work with your instance if you do that.

Is there any worry about data collection (related to previous question)?

Savannah CRM will only collect publicly available data by default (you can collect from private Slack channels, but it will warn you against doing that). You can choose to add other data if you wish, but that data will only be available to the team members you invite to help you managed your community's account.
And, again, it's open source, so you can inspect the code and know exactly what it is and isn't doing with the data it collects.

@saad-ali Does that answer your question well enough to review this PR?

@carolynvs: @mhall119 comment is useful. As an end user, I'd appreciate this information to be included to the page source. What do you think?

Thanks for the details.
/lgtm
/hold
In case you want to address @alena1108's comment.

lgtm on the pr content. Up to @carolynvs on whether to include those extra bits of info, not blocking.

Apologies that this has moved so slowly. In the future we'll make sure to have the content author submit the PR to the TOC instead of the WG lead so that they can address feedback within the same PR.
Let's merge this now and then @CathPag can follow-up on the content suggestions.
@jberkus @parispittman @justaugustus Would one of you please approve (with a github review) and then merge? Since we aren't hooked into prow, we've got to do this the old fashioned way. 😀


BUG - Some test bug

Describe the Bug
A clear and concise description of what the bug is.
Expected Behaviour
A clear and concise description of what you expected to happen.
Actual Behaviour
A clear and concise description of what actually happens.
Implications
A clear and concise description of any implications.
Steps To Reproduce
Steps to reproduce the behaviour:
User/Role:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Tested and this part is working but this other part is still broken.

This is a test card


Licensing information

@mzucker
I am afraid that there are parts of the world that cannot use your program simply because there is no LICENSE file or any other information about the legal status of the code.
I would recommend GPLv3 or MIT license. But there are more options depending on what aspect of the legal status of the code is your concern.
Cheers!

I would also be glad to see your program become free software. I think it would be a good contribution to the community.

Added MIT license in ab3178d – had totally forgotten to think about this when preparing the repo/writeup.


Add files via upload

@Kennesou07 First stage of verification passed, official domain is ucc-caloocan.edu.ph as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@Kennesou07 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


feat:版本合并

合并morn-projects
升级SpringBoot至2.1.4.RELEASE
适应性修复

Codecov Report

Merging #35 into master will increase coverage by 0.39%.
The diff coverage is 53.11%.

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
+ Coverage     50.87%   51.26%   +0.39%
- Complexity       24       41      +17
============================================
  Files            40       82      +42
  Lines           515     1065     +550
  Branches         36       68      +32
============================================
+ Hits            262      546     +284
- Misses          242      498     +256
- Partials         11       21      +10

Impacted Files
Coverage Δ
Complexity Δ

.../morn/boot/autoconfigure/WebAutoConfiguration.java
11.11% <ø> (ø)
1 <0> (ø)
:arrow_down:

...java/site/morn/boot/support/entity/TreeEntity.java
0% <ø> (ø)
0 <0> (?)

...main/java/site/morn/rest/RestPageableConstant.java
0% <0%> (ø)
0 <0> (?)

.../src/main/java/site/morn/translate/Translator.java
0% <0%> (ø)
0 <0> (?)

...c/main/java/site/morn/util/OptionalCollection.java
0% <0%> (ø)
0 <0> (?)

...n/java/site/morn/constant/ApplicationConstant.java
0% <0%> (ø)
0 <0> (?)

...java/site/morn/boot/support/JpaRepositoryImpl.java
12.5% <0%> (ø)
1 <0> (?)

...n-core/src/main/java/site/morn/util/UUIDUtils.java
0% <0%> (ø)
0 <0> (?)

...site/morn/boot/support/mongo/MongoCrudService.java
0% <0%> (ø)
0 <0> (?)

...e/src/main/java/site/morn/constant/MetricUnit.java
0% <0%> (ø)
0 <0> (?)

... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eedb3c0...e481a69. Read the comment docs.


Add graph node roundness option

Its cool if user can control roundness of visual script nodes, so I've added possibility for this. I bring a new option interface->theme->Graph Node Roundness, Its off by default - "0" .

For example, If you change it to "10" - (changes will apply immediatly)
 - with header
 - without header

For some reason engine crashes when GraphNode creates by user in Editor if StyleBoxFlat used.. need time to investigate, do not merge for now

Ok, I think Im done, roundness is private for public usage on custom GraphNodes for now, but the new option is work for visual scripting nodes.

Thanks for that feature, I like it!
Though, for the version with header I think it would look better if the top corners of the inner body were not round. Like in this mockup:

would that be possible, too?
I research the possibility of it, after(as well as rounded input fields)


Stop rendering between save and close modal?

Maybe a basic question and more about livewire than the modal…
I open a modal and let’s say I have a title at the top with my current title. Below I have a title input where you can change the title with defer on it. Once I press save and the modal closes, the new title appears at the top of the modal because it’s faster than the close action. Is there anything I can put between my save action and modal close action in the livewire component that will make the view not re-render? I know I can put wire:ignore on the title, but in some scenarios I don’t want to do that. To be clear, I want the old title to stay at the top without wire:ignore or saving into a new variable.
Thanks!

Livewire have skipRender() function to not render html. use it on your save function, maybe it will work as you expect

Livewire have skipRender() function to not render html. use it on your save function, maybe it will work as you expect

That’s cool! Will give it a try. Thanks!


npmrc - Could not find a part of the path 'U:'

I have downloaded the vsts-npm-auth package here and followed the instructions
npm install -g vsts-npm-auth -- This is successful
vsts-npm-auth -config .npmrc - This is throwing the error saying "Could not find a part of the path 'U:'" Where I don't have any drive named 'U:' locally.
This is the first time I am running, I was expecting a credential probe window. but instead I was getting this error.

Who cares

From: PrakashRajanSakthivel<EMAIL_ADDRESS>Sent: Wednesday, February 19, 2020 4:33 AM
To: microsoft/azure-pipelines-tasks<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [microsoft/azure-pipelines-tasks] npmrc - Could not find a part of the path 'U:' (#12382)
I have downloaded the vsts-npm-auth package herehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.npmjs.com%2Fpackage%2Fvsts-npm-auth%23install-and-run-the-tool&data=02|01||2aa3b8f45d9a4737ddfe08d7b52f8bb9|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637177088114323637&sdata=f5bQc2LTuF4QqePb9sCiZSyIvAKJkl%2FzE0sFSWWKVVQ%3D&reserved=0 and followed the instructions
npm install -g vsts-npm-auth -- This is successful
vsts-npm-auth -config .npmrc - This is throwing the error saying "Could not find a part of the path 'U:'" Where I don't have any drive named 'U:' locally.
This is the first time I am running, I was expecting a credential probe window. but instead I was getting this error.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fazure-pipelines-tasks%2Fissues%2F12382%3Femail_source%3Dnotifications%26email_token%3DALUUZL674JQ3W7YTBQ4YHHTRDUKITA5CNFSM4KXXO7RKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IOTOVSA&data=02|01||2aa3b8f45d9a4737ddfe08d7b52f8bb9|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637177088114323637&sdata=xaHfH8Q4k3m1MEaNzCZe2o9X6ooioCqoPgMN1%2BGCOwk%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALUUZL5UGE5GN6CFCB5SQG3RDUKITANCNFSM4KXXO7RA&data=02|01||2aa3b8f45d9a4737ddfe08d7b52f8bb9|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637177088114343647&sdata=ZjkztficXpFt4QjsxzpCrOccgIAgcL7Tmm%2FTPjjZ8Fk%3D&reserved=0.

+1

Hello,
Any information about this? I got same problem on my machine.

Hello again,
The problem is that probably you have you HOMEDRIVE variable set to U
you can check it by executing echo %HOMEDRIVE% in your cmd
you have to set it to proper system drive (in my case it's C:)
To do it execute in cmd (don't forget to run it as admin) SET HOMEDRIVE=C:
Then just execute vsts-npm-auth -config .npmrc once again

We recently had to troubleshoot this... it is caused the the environment HOMEDRIVE being set incorrectly.
PS> $env:HOMEDRIVE=c:
You can set the environment variable to C:, and check if this fixes the issue for you.

Thanks everyone for the suggestions. @PrakashRajanSakthivel - are you still having issues here?

we were able to make that work by using this command: vsts-npm-auth -config .npmrc -TargetConfig ~/.npmrc This actually creates the token in the workspace then we were utilizing this at the userlevel token.
I will try to do the above approach and check.

Thanks! Going to close this for now, though please do reopen this issue (or a new one) if you have problems. :)


Messages not sent

I'm having trouble sending messages.
Using publish configuration and sending strings, sometimes they are sent, and sometimes nothing is send. Went they are not sent the memory usage of the app starts increasing until it is completely full and the app crashes.
Apparently this behaviour is random, can't really find out what makes it work sometimes but most of the time is not working. Any suggestion?

Never mind, apparently it was an issue on my network.


Xcode 11.1 Swift 5 problems

Hi, there were incompatibilities with the new version of Xcode and Swift 5. I Fixed it and would like to create a PR.

Same with XCode 11.3 Does not compile

i'm getting so many errors while compiling with the latest swift and xcode, can u help?


Integrate memory accounting into LuceneOrderedDocCollector

Summary of the changes / Why this improves CrateDB
See commit messages for details
Checklist

[ ] User relevant changes are recorded in CHANGES.txt
[x] Touched code is covered by tests
[x] Documentation has been updated if necessary
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Shoudl we have a release notes entry for this and backport it to 4.0?

@mfussenegger Yes I think this is worth backporting.

@seut pushed a fixup with a release notes entry.


Keytool SIGSEGV in temurin-8-jdk

Please provide a brief summary of the bug
This command
keytool -genkey -alias localhost -keyalg RSA -keysize 4096 -keystore "./httpskeystore.ks" -dname "CN=Kura, OU=Kura, O=Eclipse, L=Amaro, S=UD, C=IT" -ext eku=digitalSignature,nonRepudiation,keyEncipherment,dataEncipherment,keyAgreement,keyCertSign -ext eku=serverAuth,clientAuth,codeSigning,timeStamping -validity 1000 -storepass changeit -keypass changeit

cause keytool to crash with SIGSEGV.
Please provide steps to reproduce where possible
Run the following command:
keytool -genkey -alias localhost -keyalg RSA -keysize 4096 -keystore "./httpskeystore.ks" -dname "CN=Kura, OU=Kura, O=Eclipse, L=Amaro, S=UD, C=IT" -ext eku=digitalSignature,nonRepudiation,keyEncipherment,dataEncipherment,keyAgreement,keyCertSign -ext eku=serverAuth,clientAuth,codeSigning,timeStamping -validity 1000 -storepass changeit -keypass changeit

Expected Results
The keystore is created without any errors.
Actual Results
The output of the command is:
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x0000007fb017c8e4, pid=1243, tid=0x0000007fbe4671c0
#
# JRE version: OpenJDK Runtime Environment (8.0_345-b01) (build 1.8.0_345-b01)
# Java VM: OpenJDK 64-Bit Server VM (25.345-b01 mixed mode linux-aarch64 compressed oops)
# Problematic frame:
# J 244 C2 java.math.BigInteger.multiplyToLen([II[II[I)[I (216 bytes) @ 0x0000007fb017c8e4 [0x0000007fb017c8c0+0x24]
#
# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /home/pi/hs_err_pid1243.log
#
# If you would like to submit a bug report, please visit:
#   https://github.com/adoptium/adoptium-support/issues
#
Aborted

hs_err_pid1243.log
What Java Version are you using?
openjdk version "1.8.0_345" OpenJDK Runtime Environment (Temurin)(build 1.8.0_345-b01) OpenJDK 64-Bit Server VM (Temurin)(build 25.345-b01, mixed mode)
What is your operating system and platform?
RaspberryPiOS 64bit
root@raspberrypi:/home/pi# uname -a
Linux raspberrypi 5.15.32-v8+ #1538 SMP PREEMPT Thu Mar 31 19:40:39 BST 2022 aarch64 GNU/Linux
How did you install Java?
sudo apt-get install -y wget apt-transport-https gnupg
sudo wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | sudo apt-key add -
sudo echo "deb https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main" | sudo tee /etc/apt/sources.list.d/adoptium.list
sudo apt-get update
sudo apt-get install temurin-8-jdk

Did it work before?
It works if the keytool from openjdk-8-jre-headless is used.

Did you test with other Java versions?
It works if the keytool from openjdk-8-jre-headless is used.

Relevant log output
No response

Just to report that the platform is arm 64 bit, not 32.
Thanks.


Upload logs after the assignment has finished

This avoids a situation where the log has not been closed yet and might
still be written to while being uploaded.
As a side effect, _upload_logfile() now no longer takes a log
identifier, since an assignment is only supposed to have one log anyway.

Coverage increased (+0.06%) to 73.67% when pulling de473038fae1b0668e43155230b4cb8c0c3630fd on guidow:upload_log_after_close into 06fbf564eb85941c7c76327659643fd12b0ea959 on pyfarm:master.

LGTM, merging.


WIP: Test build on .NET 7

Not to be merged
Ref: https://app.zenhub.com/workspaces/the-outlaws-6193fe815d79fc0011e741b1/issues/gh/energinet-datahub/team-the-outlaws/989

Test succeeded, closing PR


2D mode : blue circle when game lost

Don’t know how to describe....but when playing on frag mode. Flag wrong cell, and click active cell to open more -> game lost
Blue circle shows up

That’s really odd. That looks like an the old mine texture with the blue tint, but you have the new mine texture as well o_O
I cannot reproduce this, either.

heh, it was consistently happening both desktop and mobile, but I cleard Indexed DB on desk top and does not happen anymore. So closing this. Should be fine.

reopening this because it still exist, and I just loaded PROXX to brand-new device and same happened.

Feels to me that hole that's touching active cells are couching to already open cell are being drawn blue.


Use math.prod instead of np.prod on lists, tuples, and iters

math.prod requires Python 3.8+, so historically it wasn't used in the codebase.
It's 20~40x faster than numpy.prod on pure python lists and tuples, and it doesn't need to convert iterators to lists, resulting in cleaner code.
>>> a = (1,2,3)
>>> %timeit numpy.prod(a)
3.27 µs ± 51.9 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)
>>> %timeit math.prod(a)
92.5 ns ± 0.38 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)
>>> %timeit numpy.prod(list(range(1, 4)))
3.42 µs ± 19.2 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)
>>> %timeit math.prod(range(1, 4))
159 ns ± 0.677 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)

Also, numpy.prod returns a numpy.int64, which can cause problems down the line.

rerun tests


feat(plugin): add build plugin via unplugin

Opening as draft and looking for early feedback - I want to add actual tests for every plugin and just generally looking for opinions on the PR. Imo the logic is simple enough where this doesn't warrant a separate package, but happy to split this out @markerikson

Did some work to try this out with our actual Replay frontend at https://github.com/replayio/devtools , which is a Next app.
Found a couple typos in the plugin exports here, and I ran into issues where the filename reported by remapping was:
webpack://_N_E/node_modules/react-dom/cjs/react-dom.production.min.js

but the filename in the sources content was:
webpack://_N_E/./node_modules/react-dom/cjs/react-dom.production.min.js

Looks like trace-mapping does a resolve on the path segments.
Updated the logic to do the same resolve comparison as a fallback, and it works!  Here's a screenshot of the framework-*.js sourcemap from the Next build:

Gonna merge this and put out 0.0.3 so I can actually try it with a PR to Replay!  Please feel free to file follow-up PRs with tests and such.

Okay, quick update:

published 0.0.4 with a fix to more strictly search for "react-dom.production.min", to avoid the second pass where remapping lists our react-dom.production.js replacement filename (and also tried to handle the plugin options not existing)
Put up https://github.com/replayio/devtools/pull/9706 to add it to Replay...

AND IT WORKS!
Uh, mostly.
The actual sourcemapping replacement step works.  But the sourcemap itself is a bit wonky.  Function arguments don't appear to be getting mapped right:

that definitely reduces usability.
Going to have to investigate further and see if that's coming straight from Closure Compiler, or if something else is going on.

Oh drat.  This is a Next problem, isn't it!
I'm looking at one of my generated sourcemaps, and it pretty clearly has per-argument mappings:

but the sourcemap for the entire Next app doesn't - functions seem to get smooshed together.
My teammate Holger has an open bug against Next complaining about something similar, and I wonder if that's a problem here:
https://github.com/vercel/next.js/issues/53253

@markerikson thank you so much for the investigation!
with a fix to more strictly search for "react-dom.production.min", to avoid the second pass where


Vectorizer runtime config

Adds the possibility of typed input for runtime module configuration of api-keys, rate limits and other things that can be affected by headers at the request time.
Currently only adds this for OpenAI, Cohere and VoyageAI as these two are already supported by the batch vectorization and need the rate-limit input.
Also adds some tuning of the dynamic batching for low-rate-limit api keys
Syntax:
    collection = client.collections.create(
        name="Test",
        properties=[
            wvc.config.Property(name="url", data_type=wvc.config.DataType.TEXT),
            wvc.config.Property(name="title", data_type=wvc.config.DataType.TEXT),
            wvc.config.Property(name="raw", data_type=wvc.config.DataType.TEXT),
            wvc.config.Property(name="sha", data_type=wvc.config.DataType.TEXT),
        ],
        vectorizer_config=[
            wvc.config.Configure.NamedVectors.text2vec_cohere(name="cohereFirst"),
            wvc.config.Configure.NamedVectors.text2vec_cohere(name="cohereSecond"),
        ]
    )
integrations=[
            wvc.init.Integrations.cohere(
                api_key="KEY"
            ),
            wvc.init.Integrations.openai(
                api_key="KEY", base_url ="...."
            ),
            wvc.init.Integrations.voyageai(
                api_key="KEY",
            ),
        ]
client.integrations.configure(integrations)

Wdyt about adding the keys via a client method, like:
client.set_apikey(cohere="<SOME KEY>")

A challenge with this:
        integration_config=[
            wvc.init.Integrations.cohere(
                api_key="KEY"
            ),

That this would not persist when the user calls client.collections.get("<SOMECOLLECTION>") - unless we're somehow storing them server-side.
The same user would probably have one key per client, rather than one key per collection.

Codecov Report
Attention: Patch coverage is 70.27027% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 94.64%. Comparing base (b58761f) to head (9d478a9).

Files
Patch %
Lines

weaviate/collections/batch/base.py
39.02%
50 Missing :warning:

weaviate/connect/integrations.py
93.87%
3 Missing :warning:

weaviate/collections/batch/client.py
90.90%
1 Missing :warning:

weaviate/collections/batch/collection.py
88.88%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##           dev/1.25     #981      +/-   ##
============================================
- Coverage     94.71%   94.64%   -0.08%
============================================
  Files           176      178       +2
  Lines         18337    18459     +122
============================================
+ Hits          17368    17470     +102
- Misses          969      989      +20

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: pulse button not animating

What does this PR do?
This PR  will fix the  issue #39 in which pulse button was not  animating,
Why are we doing this?
If someone wants to use pulse animation they can use easily.

Test Case(s):
Test Result(s):

Checklist

[✅] Tested locally
[ ] Added new dependencies
[ ] Updated the docs
[ ] Added a test

Thanks for the PR! Already fixed in a previous PR!


No migrations to apply.

After Edit home/models.py , I keep the cmd to runnserver. Open another cmd to execute "python manage.py makemigrations" , the answer is "No migrations to apply." .
What should I do to makemagrations.
Thank you!

Hi @CodyZhuo - please use the Wagtail tag on Stack Overflow for support queries.


Istio 1.4.10

https://istio.io/latest/news/releases/1.4.x/announcing-1.4.10/
Changes: https://github.com/istio/istio/compare/1.4.9...1.4.10

Validated with Rancher v2.4.6-rc1, v2.3.8, and v2.4.5

Upgrade from Istio v1.4.900 to v1.4.1000 is successful
All UI links work
Airgap works using v2.4.6-rc1.
New default for Istio version is v1.4.1000
All regression checks pass: (sidecar injection, graphs, links, use of rancher image mirrors)


Update links in AWS-CREDENTIALS file

https://github.com/rusoto/rusoto/blob/master/AWS-CREDENTIALS.md has some broken links and one we can update.
The two links in the Local integration testing of IAM credentials section are broken: credential/src/container.rs and credential/src/instance_metadata.rs. Those should point to the correct locations of the files.
The link to moe can be removed and the section reworded to use the credential service mock. It's like moe, but in Rust, using warp. 😄

I use Rusoto a ton and wanted to help contribute to the project in return. I think I followed the contributing guidelines but let me know if this pull request misses the mark

Done!


Fix massive slowdown when editing TileMap

Fixes #61645
release_debug build before this PR:

debug build with this PR:

I just noticed that bucket fill still has the slowdown problem. Will try to fix it too.

Did some investigation using Xperf/WPA. As the flame graph shows, a lot of time is wasted in _find/_lookup_pos, even for small/medium tilemaps.

Ok pushed also changes for tile previews.
Went from 2 second lag in release_debug

To instant in debug

Is this superseeded by #61934?

If that PR will be merged then yes.

Superseded by #61934.


[Taskbar] Add option "all_workspaces"

I have started to implement(research) feature show tasks only for current workspace. Feature will be controlled by option "all_workspaces": bool

Very cool. How does this work with the foreign-toplevel-manager protocol? As far as I know, there is no knowledge about workspaces.

Yes, there is true. And it's problem. I planned do something like in:
https://github.com/Alexays/Waybar/pull/343
Information about workspaces can be obtained via IPC. Need to find way how to bind Task.id with node.id right.
Any other ideas? Maybe I miss something?

Hm, I implemented the original taskbar so that it will work on any wlroots based compositor that implements the foreign-toplevel-manager protocol. That is also the reason why the module is named wlr/taskbar. My long goal is to get support for this type of functionality (identifying the current workspace as well as knowing on which workspace the current toplevel is on) as a protocol extension into wlroots.
If you really want to use the IPC mechanism of sway for this, please make it optional for the module. For example I use the taskbar on wayfire which doesn't have such an IPC mechanism. That's also the reason why I want to get support for this into wlroots, so that this will work out of the box on many different compositors and not only on sway/wayfire …

I don't really want to bound with IPC too. But not found way how to do it with foreign-toplevel.
So what way to do it correctly?
Write another protocol for "workspace" entity?
Or register foreign-toplevel for each workspace? As I know workspace in sway use wl_seat for representation.

Another problem: what unique id for app in foreign-toplevel? app_id is not unique.
It required for case when have 2 Alacrity instance, for example and move one to another workspace.

I don't really want to bound with IPC too. But not found way how to do it with foreign-toplevel.
So what way to do it correctly?
Write another protocol for "workspace" entity?
Or register foreign-toplevel for each workspace? As I know workspace in sway use wl_seat for representation.

As I said. To support this properly, the foreign-toplevel-manager protocol needs to be extended and the compositors need to support it … That's quite some steps, hence I don't know when exactly this will happen.

Another problem: what unique id for app in foreign-toplevel? app_id is not unique.
It required for case when have 2 Alacrity instance, for example and move one to another workspace.

If the protocol gets extended this is not a problem. If you have a look in the code, you will see that we get a special handle structure for each toplevel on our system. By using this handle one can implement all these features. However not with the sway IPC. As I said, we need support for this on the wlroots protocol level.

How about writing something like toplevel_manager, but for workspace and extend toplevel_manager to pass new entity "workspace" with handler?
In this case sway/workspace also can be replaced with wlr/workspaces for other WMs.
Will it be right way to implement that?
Or any other ideas?

If this idea is good - let me know and I'll try to write such protocols and maybe some UMLs.

Yes, this is what needs to be done. Have an additional protocol for workspaces in wlroots and extend the toplevel_manager protocol to also support workspaces. At least that would be how I would try to get it accepted. If you get it accepted into wlroots, than we can enhance the compositors to support this protocol and then we can extend this module and add the wlr/workspaces ;) Buts that quite some steps …

Waiting for:
https://github.com/swaywm/wlroots/pull/2357
https://github.com/WayfireWM/wayfire/pull/647
https://github.com/swaywm/sway/pull/5597

@Anakael Do you have an implementation for Waybar already? It would be needed eventually for merging the protocol into wayland-protocols, because the requirement is to have at least one client implementation.

@Anakael Do you have an implementation for Waybar already? It would be needed eventually for merging the protocol into wayland-protocols, because the requirement is to have at least one client implementation.

I've start implement workspace module. I'll try to finish by end of the week.

I've start implement workspace module. I'll try to finish by end of the week.

Great news! Meanwhile, I have submitted the MR herre: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/40
Let's hope it is approved.

@Anakael Do you have an implementation for Waybar already? It would be needed eventually for merging the protocol into wayland-protocols, because the requirement is to have at least one client implementation.

I've start implement workspace module. I'll try to finish by end of the week.

Do I understand the protocol right that it is not yet integrated into the foreign-toplevel-manager protocol? Hence, @Anakael you implement a completely separate module for workspaces based on wlroots?

The protocol is just for listing the currently focused workspace. If this gets accepted, I'll also add the corresponding event to foreign-toplevel.

Ok, than I understood it correctly. Great work @ammen99. Thank you very much for your effort!

https://github.com/Anakael/Waybar/tree/workspace-manager-implementation
branch for tracking implementation

https://github.com/Anakael/Waybar/tree/workspace-manager-implementation
branch for tracking implementation

I really don't mess high-level WorkspaceManager with wlr C code. Any ideas how to separate them?

No, that's the ugly life of a C++ programmer working with C interfaces. What you did is basically what I usually also do. Have some very small static C-style functions that are used as callbacks for the C interface. These C-style functions only do one thing, call the proper C++ member function.

No, that's the ugly life of a C++ programmer working with C interfaces. What you did is basically what I usually also do. Have some very small static C-style functions that are used as callbacks for the C interface. These C-style functions only do one thing, call the proper C++ member function.

Yeah, but there are (about FTM) half of file such small functions and bindings and it's become harder to read high-level taskbar API.
I think about additional abstract layer as controller who create manager and bind C to C++.

Yeah, but there are (about FTM) half of file such small functions and bindings and it's become harder to read high-level taskbar API.
I think about additional abstract layer as controller who create manager and bind C to C++.

I don't think this is worth the effort. You will probably end up with more code doing exactly the same thing, which in the end will be even worse to read.

https://github.com/Alexays/Waybar/pull/805
Done.

Any news about this? I would love this feature. I usually have dozens of windows open on multiple workspaces, and a taskbar is only useful if only the tasks on this workspace are shown :)
Thank you for constantly adding great features!

@AGCaesar The PRs and MRs are still waiting to be merged.

Hello there, any news about this? I would like to have such option.
Couldn't find a PR related to this.

Hello there, any news about this? I would like to have such option. Couldn't find a PR related to this.

There are no PR for this feature yet. We are waiting for workspace protocol merging.

Hello there, any news about this? I would like to have such option. Couldn't find a PR related to this.

There are no PR for this feature yet. We are waiting for workspace protocol merging.

Can I help in some way?

Probably not. We have to be patient and wait for the upstream developers to have a proper look at the PRs so that they can be merged or improved if necessary.

Hi,
any news about that? Sounds like a must-have. . .


Mazumder - Add connection to the Front End site to the data.argosdb tabs

Just as in GlyGen, please add a tab for the ArgosDB Front End to the tabs in data.argosDB

ARGOS Portal: https://argosdb.org/

Thanks @rykahsay
It seems the PORTAL Tab redirects right back to the home pages of data.argosdb.org, but I need it to point, here: ARGOS Portal: https://argosdb.org/


Element ref was specified as a string (inner) but no owner was set.

Hi I have followed the example
http://intljusticemission.github.io/react-big-calendar/examples/index.html#intro
"dependencies": {
"@rails/webpacker": "^3.3.1",
"babel-preset-react": "^6.24.1",
"bootstrap": "4.0.0",
"react": "^16.2.0",
"react-big-calendar": "^0.19.2",
"react-dom": "^16.2.0",
},
It giving this error https://cl.ly/3z3c42292l0e

you have multiple copies of react installed! Sorry i know the error says that, but that is actually the propblem 99.9999% of the time, even tho it can feel like its not

@amanmibra I ran into this issue tonight on a new project (no other dependencies) after installing react-big-calendar v 0.19.1 with React 16.4.1.
I was able to remedy it by installing React 15.6.2 instead.

yarn list my be misleading, i think it only checks the what the lockfile says, not what is on disk. nuke node_modules and yarn.lock and reinstall to get an accurate picture

Yea, it still shows up as one dep

I too am having this same issue -- it looks like some libraries are having this issue with newer versions of React.

Having this issue as well. In my case I have react-big-calendar installed into a module that is being transpiled with Babel before being used by another module. When I use react-big-calendar from the top-level module directly, I do not have this problem. Any ideas? I tried listing react, react-dom, and react-big-calendar as devDependencies and peerDependencies in the submodule to no avail.

The issue is multiple instances of react or react-dom, there isn't anything we can do as a library, please double check your build process


feat: Add skaffold.yaml for helm charts

Please provide a description of this PR:
Developers can now pull the repo and 'skaffold run' to install istio.
Profiles can be selected for gateways.
Also acts as documentation on helm installation.
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ X] Docs
[ X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ X] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @mmcloud. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Incorrect json serialization in sample command, azure model management

When I create a json-serializable schema using python I seem to generate a correct schema but the sample code in the sample commands (curl as well as az) is incorrectly formatted.
Steps to reproduce:
Generate a model management function with a boolean as sample parameter
Deploy
use sample commands to poll the function
"Input failed JSON deserialization"-error
Expected results:
Sample command should return a valid response

inputs = {"is_weekday":SampleDefinition(DataTypes.STANDARD, True),"hour":SampleDefinition(DataTypes.STANDARD, 13),"temperature":SampleDefinition(DataTypes.STANDARD, 29.3)}

{"input":{"hour": {"internal": "gANjYXp1cmVtbC5hcGkuc2NoZW1hLnB5dGhvblV0aWwKUHl0aG9uU2NoZW1hCnEAKYFxAX1xAlgJAAAAZGF0YV90eXBlcQNjYnVpbHRpbnMKaW50CnEEc2Iu", "type": 0, "swagger": {"type": "integer", "format": "int64", "example": 13}}, "is_weekday": {"internal": "gANjYXp1cmVtbC5hcGkuc2NoZW1hLnB5dGhvblV0aWwKUHl0aG9uU2NoZW1hCnEAKYFxAX1xAlgJAAAAZGF0YV90eXBlcQNjYnVpbHRpbnMKYm9vbApxBHNiLg==", "type": 0, "swagger": {"type": "boolean", "example": true}}, "temperature": {"internal": "gANjYXp1cmVtbC5hcGkuc2NoZW1hLnB5dGhvblV0aWwKUHl0aG9uU2NoZW1hCnEAKYFxAX1xAlgJAAAAZGF0YV90eXBlcQNjYnVpbHRpbnMKZmxvYXQKcQRzYi4=", "type": 0, "swagger": {"type": "number", "format": "double", "example": 29.3}}}}

note: true in lower case

curl (...) --data "{"hour": 13, "is_weekday": True, "temperature": 29.3}" (...)

note: True with T in upper case

@mufflon
Thanks for the feedback !  Please provide Git-hub link to further investigate the issue.

@mufflon Can you please help providing the GitHub Doc link to look into this issue.

@mufflon We will now proceed to close this thread. Please create a new issue with above requested information and we will gladly work on your feedback.


Implement buildx release

Use docker buildx, we should not be having 2 dockerfiles and 2 new tags for each architecture (arm and x64), we should have single tag that supports both architectures, Example https://github.com/opensearch-project/opensearch-ci/blob/main/.github/workflows/docker.yml#L26-L32, final image https://hub.docker.com/r/opensearchstaging/jenkins/tags (ECR also supports multi architecture) OS/ARCH should have amd64 and arm64.
Since we will be appVersion to our helm charts https://github.com/Opster/opensearch-k8s-operator/blob/main/charts/opensearch-operator/Chart.yaml#L24, having single tag will allow users not to change for each architecture.

Added on latest release


Extension causes high cpu load

Issue Type: Performance
Extension Name: html-css-class-completion
Extension Version: 1.18.0
OS Version: Linux x64 4.9.0-8-amd64
VSCode version: 1.31.1

:warning: Make sure to attach this file from your home-directory: /home/agonzalez/Zignd.html-css-class-completion-unresponsive.cpuprofile.txt :warning:
Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

Duplicate of #155. Also, missing the report itself.


HPACK dynamic table size update must happen at the beginning of the header block

Expected behavior
HPACK decoder accepts dynamic table size update at the beginning of the block.
Cf RFC 7531, section 4.2
Actual behavior
HPACK decoder tolerates dynamic table size update anywhere in the block
io.netty.handler.codec.http2.HpackDecoder can be modified to only allow setDynamicTableSize to be called only if that is the first of the block processing and fail otherwise with a connection error like it does already.
Steps to reproduce
Send an HTTP/2 header frame with a dynamic table size update anywhere, e.g at the end of the stream
Minimal yet complete reproducer code (or URL to code)
N/A
Netty version
4.1.84.Final
JVM version (e.g. java -version)
N/A
OS version (e.g. uname -a)
N/A

I can contribute a fix for this.


Change sh to bash

The if [ is incorrect syntax for Shell and raise the errors like:
./aws-setup.sh: 8: [: unexpected operator

I've changed it to /bin/bash

Thanks for the change.   In the feature-12 branch, we are working on moving aws-setup.sh into the Lucy Docker image.  Since Lucy is derived from Alpine, this will need to /bin/sh.  However, since this is a standalone script for the master branch, your change is appropriate (and necessary).


Can we use it for our project.

Thanks for codes,
Can we use it directly as it is licensed.
Thanks

https://github.com/openxc/android-webcam/blob/master/LICENSE


Check all the expired links in the SEF handbook Repo

Describe the bug
I checked all the links that direct to different outside entities such as SEF's Fb profile, SEF hive , other resources (github doc) & etc.
All the links are up-to-date except the slack link on the navbar.
To Reproduce
Steps to reproduce the behavior:

Go to SEF handbook
Click on slack in the navbar
(Please make sure to open the link in a private window ( incognito tab))
See error

Expected behavior
Update the outdated slack link on the docusaurus.config.js file.

Screenshots

Are you working on it?
Yes

Shall I fix this bug? after that all the links are up-to-date.

Shall I fix this bug? after that all the links are up-to-date. @jayasanka-sack

Go ahead! @janithlahirukariyawasam

Fixed with https://github.com/sef-global/sef-handbook/pull/18


Add RWX_SUPPORTED envar

I took the liberty to change the variant of the "clear repository" button from link to default to be able to clearly show when the button is disabled. I believe this is also allow to better follow the application standard.

A tooltip is provided when the button is disabled which is the case when RWX is not supported (RWX_SUPPORTED = "false").

https://github.com/konveyor/tackle2-operator/issues/140

LGTM! Nice idea with the tooltip!


Support YesNoCancel for MessageButtons

I'd like to represent a dialog like this in my application:

I don't think this is possible currently, as there's no way to have three buttons -- nor distinguish between "No" being clicked and "Cancel".
Is it possible to add support for this? Thanks.

This is fixed in the newest release of rfd.
Here's some example code incase anyone finds this issue through google:
					let choice = rfd::MessageDialog::new()
						.set_title("My App")
						.set_description(format!(
							"Save changes you made?",
						))
						.set_buttons(rfd::MessageButtons::YesNoCancel)
						.show();

					match choice {
						rfd::MessageDialogResult::Yes => {
							// save, close
						},
						rfd::MessageDialogResult::No => {
							// don't save, close.
						}
						rfd::MessageDialogResult::Cancel => {
							// don't close.
						}
						_ => {
							// can't happen.
						}
					}


Don't work when trying to pass various files in order to gulp.src

I`m trying to concat files in a specific order. So i follow the info to put each file inside [' ']:
gulp.task('concat', function () {
  return gulp.src(['./stylesheets/framework/initialize.scss',
                  './stylesheets/framework/grid.scss',
                  './stylesheets/framework/utilities.scss',
                  './stylesheets/framework/typography.scss',
                  './stylesheets/framework/icons.scss',
                  './stylesheets/framework/navigation.scss',
                  './stylesheets/framework/slider.scss',
                  './stylesheets/framework/forms-tables.scss',
                  './stylesheets/theme/general.scss',
                  './stylesheets/theme/header.scss',
                  './stylesheets/theme/footer.scss',
                  './stylesheets/partials/searchbar.scss',
                  './stylesheets/partials/product-grid.scss',
                  './stylesheets/partials/breadcrumbs.scss',
                  './stylesheets/partials/pagination.scss',
                  './stylesheets/partials/modal.scss',
                  './stylesheets/partials/social-share.scss',
                  './stylesheets/partials/rich-text-content-editor.scss',
                  './stylesheets/templates/index.scss',
                  './stylesheets/templates/collections-lists.scss',
                  './stylesheets/templates/collection.scss',
                  './stylesheets/templates/product.scss',
                  './stylesheets/templates/pages.scss',
                  './stylesheets/templates/search.scss',
                  './stylesheets/templates/blog-article.scss',
                  './stylesheets/templates/cart.scss',
                  './stylesheets/templates/customer-accounts.scss',
                  './stylesheets/templates/about-us.scss',
                  './stylesheets/templates/faq.scss',
                  './stylesheets/templates/our-fight.scss',
                  './stylesheets/templates/policies.scss',
                  './stylesheets/templates/wholesale.scss',
                  './stylesheets/tests-utilities/tests.scss',
                  './stylesheets/trumps/trumps.scss',
                  './stylesheets/vendors/select2.scss'
                  ])
    .pipe(concat('all.scss'))
    .pipe(gulp.dest('./stylesheets/'));
});

The task finishes but no file is generated.

Do those files exist? Pipe to gulp-debug

the files exits, but my it was my bad. I thought it worked as sass partials, forgot the underscore (_).


LaTeX template

I think @bjmorgan might have a preferences for a template for the handout/worksheet material.

@bjmorgan let me know what you think of the style in PR #14

Closing as the LaTeX template seems to be alright. @bjmorgan reopen if you wanna change it


center the search bar and ratings

The search bar and the ratings button is centered.

The search bar and ratings  button placement looks ok.


Perform Slack vote in multi-person DM

Allow caller to pass a list of users (using existing eligible_users param?) to perform the vote in a private message. This could be as simple as: if eligible_users is provided, but channel is NOT provided, the vote is performed in a new "mpim" (group message) among the eligible voters. See the post_message function on the Slack plugin for a how a new mpim channel is opened using conversations.open.

We could support this in Discord, too.


Include files in the list

The report is incomplete since it doesn't include the size of the files in $BasePath.
get all of the folder information , but do it for files in $BasePath
#Get folder info / sizes
$folderSize = Get-Childitem -Path $BasePath -Force -ErrorAction SilentlyContinue | Measure-Object -Property Length -Sum -ErrorAction SilentlyContinue
#We use the string format operator here to show only 2 decimals, and do some PS Math.
$folderSizeInMB = "{0:N2} " -f ($folderSize.Sum / 1MB)
$folderSizeInGB = "{0:N2} " -f ($folderSize.Sum / 1GB)

#Here we create a custom object that we'll add to the array
$folderObject = [PSCustomObject]@{
    FolderName    = '"files"'
    'Size(Bytes)' = $folderSize.Sum
    'Size(MB)'    = $folderSizeInMB
    'Size(GB)'    = $folderSizeInGB
}

#Add the object to the array
$folderList.Add($folderObject) | Out-Null

Thank you for a very useful tool.

Good morning! Glad the tool has been useful for you. I will be working on the two issues you have opened, and roll them into my next version release that includes the other open ones as well.


Show before-and-after sample images in GitHub workflow

Fixes #958
This PR add before and after image samples to the "PR Preview" GitHub check tab.  It only shows locations where there is a change in rendering.  The sample locations are defined in tests/sample_locations.json. The before and after images are generated in userland, uploaded to s3, while a markdown file with the change is pushed over the the privileged CI runner.
I had to change the GitHub action to run the before and after builds in separate folders so they wouldn't stomp on each other.  I also use the PR branch's render test list and apply it to both the main and PR branch.  This ensures that we have apples to apples comparisons. For this reason, the comparison and clipping scripts are also run out of PR branch code.
I also tweaked some of the sample location sizes and added a dense area of NYC and a recently located 7-way concurrency because Americana :)
I've also made a change the Historic US-66 to demonstrate the change in the checks tab, however, I will remove that change prior to merging this PR.
Below is what it looks like in the checks tab, and you can click down in the checks to view it. There are links to the location in the current demo map as well as the PR preview map.

If we think it's useful, a future PR could also generate an image diff to show the pixel differences, perhaps using pixelmatch.

Looks like the PR preview isn't pulling in the web font. The Interstate 40 shield has the wrong width.

This PR incorporates changes from #991.

Is https://github.com/ZeLonewolf/openstreetmap-americana/pull/956/checks?check_run_id=19668104694 supposed to have a preview of all the sample locations?

The preview is intended to only show sample locations for places where the PR changes the rendering from what's in the main branch.

Thanks @akadouri for your review, are you good with merging this PR?


About the code for training data synthesis.

It is a nice work. And I am wonder do you have any plans to release the code for training data synthesis?

good question，and where is the training code


Use intptr_t for cuDNN handles

Modified size_t with intptr_t for cuDNN as a part of #2716

Jenkins, test this please

Jenkins CI test (for commit 1bc4e097435ee2fef09f00006894cbc350dee143, target branch master) succeeded!


Consistently pre-lookup the metrics for a given queue in queue manager.

Signed-off-by: Tom Wilkie<EMAIL_ADDRESS>

/cc @cstyan

I've triggered a config reload on this change, and the wal watcher did explode.  Not fully convinced this is a complete fix though.

And restarted prometheus.  Both successful.

Fixes #5299


Incorrect aspect ratio

Jonny - Movies are being display at an incorrect aspect ratio in some cases. Not sure what those cases are yet.

I believe I have one file that exhibits this behavior. I need to try it under Laika again to confirm that it looks right in Laika.

This may be an issue with anamorphic videos. There is a capabilities flag you send send to the server which says "I do NOT support anamorphic videos" which forces them to transcode. (It defaults to Direct Streaming those videos.)

So I have one file that exhibits this behavior. What do I look for in MediaInfo to tell if it's anamorphic?

Play it on the Roku, and then paste the transcoder lines in here and I'll have a look. I think it's in the PAR/DAR lines.

So I'm not sure what changed, but the same file I had issues with before now works fine. Not sure if it's something that got tweaked inside the Roku channel or PMS, but it's working fine for me now.
I'll have to see if I can find an example from someone else if this is still occurring.

One issue we found is that certain files do not play correctly on the Roku 1 but do play correctly on the Roku 2. This seems to be a firmware limitation as it is scaling by height instead of width, which is definitely incorrect.
Still investigating the "squeezed" display issue people are reporting. In 1.7 I disabled support for anamorphic videos and I'm waiting for feedback as to whether or not that helps people, and if not, if I can get an example of an offending video.

Bumping the milestone on this. One user sent me a file which does scale by height on the Roku 1 (a clip of the Universal logo). We need to work with Roku to find out why this is not playing correctly on the Roku 1 firmware.
I have not gotten feedback from people experiencing the squeezed issue, so I reverted the anamorphic change. I don't want people transcoding videos unnecessarily.

http://dl.dropbox.com/u/4442975/Universal logo.mkv

There are too many factors with this to aim for fixing it in 2.0.


Problem to build your dockerfile

Hi, first of all, thank you for sharing your work.
I'm using an odroid XU4 (ARM32v7) with a robot, trying to get ros2 humble working on it.
I manage to build humble sources on the odroid.
Now I would like to do the same but in docker. So I found your repo and start working with it. I made a copy of your Dockerfile.humble and change a little bit. I use my own ros2.repos, which is the same as yours but with rviz2 and visualization packages removed.
Everything is working fine but I can't get all packages build.
I see on your readme that you talk about cross compile. That is mean that I can run docker buildx build -t rclex/arm32v7_ros_docker:humble -f Dockerfile.humble . on an Ubuntu PC and get all package compiled for odroid? Once I get the image may I push to dockerhub and then pull on Odroid computer?
Thank

Hi @elgarbe, thank you for posting on this, but sorry for my late reply,,,
First of all, as we mentioned at README, please understand that our motivation to prepare this repository and Docker image is just for Rclex on Nerves. This means that we don't have experience operating the image built from our Dockerfile on the actual board (this is not required for our project).
However, I don't think this Dockerfile and image don't work fine on your board. At least --platform linux/arm/v7 option should be required (this is a README deficiency, will be corrected later).
docker buildx build --platform linux/arm/v7 -t rclex/arm32v7_ros_docker:humble -f Dockerfile.humble .

If you want, please share details of your issue with your Dockerfile. I may be able to help you.

Sorry for confusion. --platform linux/arm/v7 option was not required because this Dockerfile is based on the arm32 image. See the detail at #8.


Custom namespace support

Hi,
I would like to be sure: are custom namespace authorized in epub 3.1 ?
For example can I add my namespace:
<html xmlns="http://www.w3.org/1999/xhtml" xmlns:epub="http://www.idpf.org/2007/ops" xmlns:custom="http://custom-namespace.com">
and then use my own prefixed tags:
<custom:menu>This is the menu</custom:menu> ?
It doesn't seems to be supported by epubcheck but I saw epub 3.1 was supposed to support custom attributes: reference
Did I misunderstood the w3 doc or is it an epubcheck bug?
Thanks

Please post issues regarding the spec to this issue tracker: https://github.com/IDPF/epub-revision/
I can confirm that there are other epubcheck issues regarding the use of custom namespaces in SVG: #491 #489

@mattgarrish Matt, can you help out regarding the use of custom prefixed tags? Is this missing from 3.0 validation or do we need to add this for 3.1 validation?

Custom namespaced elements are not valid in either version.
Custom namespaced attributes were allowed as some vendors are using them, and namespaced attributes are a recognized extension point (hence epub:type). But this was only allowed because attributes are essentially metadata.
Custom Elements may come at some point, but the spec that defines them is still only a working draft and needs to be referenced by HTML to be valid.

Alright, thanks for clarifying this, Matt! Closing this issue then.

Thanks for the clarification!


Replace the outdated Win32 API and support Win11

Now the Message Box can't be rendered correctly on Windows 11. The win32 API the project used seems to have a breaking change but I can't find any document about it.
Updating the API and support Win11 Mica effect is expected.

Is there any soliton for this ?


Pass dataset as props to react element

Lgtm
On Fri, 16 Jun 2017 at 12:50, Sergio Arbeo <notifications<EMAIL_ADDRESS>wrote:
@Serabehttps://github.com/serabe requested your review on: src-d/landing#34https://github.com/src-d/landing/pull/34 Pass dataset as props to react element.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/src-d/landing/pull/34#event-1126626617, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABQFF7CDP5kcfQqe0rvtrwuo5x6xVHFFks5sEl3RgaJpZM4N8UEE.


graph failing with SubgraphSyncingFailure

Getting the following error in my graph :
Subgraph instance failed to run: Error while processing block stream for a subgraph: store error: invalid byte sequence for encoding "UTF8": 0x00, code: SubgraphSyncingFailure, id: QmWHc5DG8PYTL8xJKZrekR5YtMp6swnBxSpL75LKRj5GAT

And as debug, we get this log before :
Subgraph stopped, WASM runtime thread terminated

Could you include reproduction instructions, with a link to a repo and commit of the subgraph on which you saw this?

Hi @leoyvens sorry for the lack of details
The graph is the following https://thegraph.com/explorer/subgraph/wighawag/eip721-subgraph?selected=logs
the repo is : https://github.com/wighawag/eip721-subgraph
Unfortunately I am not sure which commit is representative as I was playing with various thing

Was this resolved? Dealing with essentially the same error on a separate subgraph.


Not woking iOS

this lib is not working on iOS
is there any requirement for using this library
My Problem is

not opening the camera.
there is a white background in the screen

+1

+1


kotlin 1.3.0-rc-146 not working with 1.0.0-rc2

Updated 0.7.1 -> 0.7.2 -> 0.9.0, all working well.
But when attempting to update 0.9.0 -> 1.0.0-rc2 get errors:
Could not find
org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.0-rc-146
org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.3.0-rc-146

Note that this is different from https://github.com/square/sqldelight/issues/1004, where the
kotlin path was "allopen" i.e. org.jetbrains.kotlin:kotlin-allopen:1.3.0-rc-146
Tried a few maven urls one at a time, but to no avail
url "https://dl.bintray.com/kotlin/kotlin-dev/"
url "https://mvnrepository.com/artifact/org.jetbrains.kotlin/kotlin-gradle-plugin"
url "https://dl.bintray.com/jetbrains/kotlin-native-dependencies"
url 'https://dl.bintray.com/kotlin/kotlin-eap' // worked with the "allopen" 1.3.0-rc-146 as per #1004

Probably unrelated, but 1.3 RC4 commit bfdd2bb (18 Oct 2018, upped kotlin RC version from 146 to 190) was made a few days after 1.0.0-rc2 was released (6023c28, 15 Oct 2018)

i think we probably just need to do another rc that targets 1.3.0
that should happen shortly

@AlecStrong Any ETA on the fix for this?

You can specify an explicit classpath dependency on 1.3.0 (or 1.3.10) for now to force resolution to a newer version.


Update flake-buildkite-pipeline

There's a race condition with derivation upload/fetching. Fix it by waiting for the derivation to be available.

!ci-build-me


Doesn't do anything

Hello,
I built this with Visual Studio 2015 Community on Windows 10, copied the DLLs into the dist\Debug\Win32 folder (where the KeeFarce.exe was created) and ran it normally and as an administrator. KeePass 2.29 was running unlocked at the time of all executions.
A window opened for a split second then disappeared. No new files created.
I then ran it via PowerShell several times, checking the %APPDATA% folder:
PS F:\Downloads\KeeFarce-master\KeeFarce-master\src\dist\Debug\Win32> .\KeeFarce.exe
[.] Injecting BootstrapDLL into 1424
CallExport: Could not get module Snapshot for remote process.
CallExport failed
[.] Done! Check %APPDATA%/keepass_export.csvPS F:\Downloads\KeeFarce-master\KeeFarce-master\src\dist\Debug\Win32> .\KeeF
arce.exe
[.] Injecting BootstrapDLL into 1424
CallExport: Could not get module Snapshot for remote process.
CallExport failed
[.] Done! Check %APPDATA%/keepass_export.csvPS F:\Downloads\KeeFarce-master\KeeFarce-master\src\dist\Debug\Win32> .\KeeF
arce.exe
[.] Injecting BootstrapDLL into 1424
CallExport: Could not get module Snapshot for remote process.
CallExport failed
[.] Done! Check %APPDATA%/keepass_export.csvPS F:\Downloads\KeeFarce-master\KeeFarce-master\src\dist\Debug\Win32>

But no file keepass_export.csv exists therein:

PS F:\Downloads\KeeFarce-master\KeeFarce-master\src\dist\Debug\Win32> cd $env:APPDATA
PS C:\Users\brian\AppData\Roaming> dir

    Directory: C:\Users\brian\AppData\Roaming

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        4/26/2015  12:40 PM                Adobe
d-----        4/28/2015   6:58 AM                Apple Computer
d-----        4/26/2015   1:15 PM                Battle.net
d-----       10/31/2015   6:34 AM                Dropbox
d-----        8/20/2015  12:34 PM                inkscape
d-----       10/30/2015  11:06 PM                KeePass
d-----        4/28/2015   9:09 PM                Macromedia
d---s-       10/31/2015   7:37 AM                Microsoft
d-----       10/31/2015   9:01 AM                NuGet
d-----       10/30/2015  11:06 PM                vlc
-a----        8/20/2015   6:48 PM            600 winscp.rnd

Downgrade to Windows 8.1 :)
https://github.com/denandz/KeeFarce#compatibility

I was able to get the prebuilt binaries running on Window 10, but was unable to successfully compile and run the C++ projects under Windows 10 and VS2015


Move processUtils into globals

Description
Move into globals.
Related Issues
#47161
Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

[x] No, no existing tests failed, so this is not a breaking change.
[x] Yes, this is a breaking change. If not, delete the remainder of this section.

ProcessUtils is already restricted from injection in tests, so no test changes are expected from this change.

@jonahwilliams Would you rather me not making this change?  I found the globals prefix helpful for finding what needs to be injected, but I can also just rely on testWithoutContext to point it out.

Sorry I wasn't clear, that was an ACK to the fluttergithubbot


"do expressions" are incorrectly minified

See https://babeljs.io/docs/plugins/transform-do-expressions/
Note: You need to explicitly enable the transform, or use the stage-0 preset.
Example input:
var foo = do {
  if (aaa) {
    'a';
  } else {
    'b';
  }
}
console.log(foo);

Example Babel output:
'use strict';

var foo = aaa ? 'a' : 'b';
console.log(foo);

Example Babili output:
'use strict';var foo=(aaa,void 0);console.log(foo);

(notice 'a' and 'b' disappear)
Example of the output I'd expect from Babili:
'use strict';var foo=aaa?'a':'b';console.log(foo);

It sounds like Babili is running before the transform-do-expressions plugin, rather than after.

This is the usual passPerPreset=false issue (just verified locally). Since we enable it by default in a preset now, I'm closing. Thanks for the report @Daniel15


run travis files from propert directory;add scancode again.

These changed were originally submitted and arpproved on https://github.com/apache/incubator-openwhisk-deploy-kube/pull/33 ; however, someone updated the setup.sh and build.sh scripts in their old folder causing a conflict in git that I could not resolve because it does not like merging changes in files that another branch moved.  So we are starting "fresh" with this PR...


Replaced assignment of members for constructors with initializer lists

In C++, it is considered good practice to use initializer lists for initializing members. This ensures classes that are const, references, or without default constructors are easily initialized.

[x] Read the contribution guidelines
[x] Added unit tests (or unit tests have already been added)

@faheel I am unsure about what style I should use for these lists, so your review would be appreciated!

@arnavb Thanks! This is helpful, but as mentioned in #163, almost all of the code is being moved around and some of it is being refactored, including code for BinarySearchTree and SinglyLinkedList. So instead of merging this now in master and having to deal with a merge conflict later, I'll fix this myself in the reorganise branch right now.
Sorry for not merging your PR (and for any inconvenience) and thanks again for contributing.

FYI, the preferred style for constructor initializer lists is the one given in the section on Constructor Initializer Lists in the Google C++ Style Guide.

@faheel Ok, I will come back with another PR when you are done with the moving around of your files. 👍


Added max_tokens property to CreateChatCompletionRequest interface

According to the documentation there should be a max_tokens property that works similarly to how it works when using the createCompletion() method. However, it seems that the CreateChatCompletionRequest interface is missing the max_tokens property.

Fixed in v3.2.1 – but thank you for opening!


Hardcoded App\Models\User in PulseActiveSessionRecorder

Hello,
please make User model configurable or maybe take it from auth.php config. In many projects, User model is not in default namespace.
In my modularized project is:
 'providers' => [
        'users' => [
            'driver' => 'eloquent',
            'model' => Modules\User\Entities\User::class,
        ],

Thank you

Same problem here.

@webard  - Thanks for the suggestion. Let me check and will make related changes.

I don't know if it will be faster, but instead of using ReflectionClass to check if User has HasApiTokens trait, You can use Laravel helper trait_uses_recursive (probably do the same under the hood).

I have an issue here because I have two user clases, one in auth.providers.users and another in auth.providers.trainers and I want to track the Trainer users.

Hi @joskfg ,
we designed the active session package with a general use case in mind, which typically revolves around tracking active users in the application.
However, we understand that there are scenarios where users might have different roles or classes beyond the standard User model. To address this limitation and cater to a wider range of use cases, we encourage you to submit a pull request (PR) that introduces support for tracking multiple user classes or allows for customization to specify which user class to track.


Fixed return type for AnswerInlineQuery::getResults

Hi and  thanks for this PR! I believe that function returns an encoded json which is a string, but I'll be able to test this further on wednesday.
In the meantime I'll just merge. If everything is ok, a new release will be launched on.. you've guessed it: wednesday haha

Thanks 👍
According your source code in addResult() it's array of Result objects.
I'm using your getResult() method for checking, if there is at least one inline query answer look here and it works just fine. Otherwise I would need to maintain list of answers by myself.


Fix CI snapshots publish. Move Scala versioning into single place

Fixes #1128
Problem

+publish is not applicable because of -Dspark.include=true.
Exact scala versions are hardcoded at several places, which is easy to forget update one of them on bumping scala version

Solution

separate publish command
locate scala versions in travis files, and read these lines in other places

@getquill/maintainers

ping @fwbrasil

@fwbrasil Please review, this PR has only code regarding publish snapshots now


Best way of handling npm dependencies (examplified with our websites)

I made an observation today about our websites and how we handle dependencies there (disclaimer - I don't know much about the actual website!)
We use bootstrap, applied into our local git repo using some npm command and we commit those dependencies.
The commit will contain one folder, containing all dependencies.
We use the same set of dependencies, on all our websites - probably in different versions as the dependency have been added over time.
There are even websites where we might have changed the bootstrap files after adding it. We are not sure.
There are other alternatives, like depending on the official hosted bootstrap online. The drawback is if that service is down, then our website won't work.
Some also uses a json npm dependency file, so they dependencies are fetched and used when needed with npm instead of being committed directly to the git repo. The drawback of this is that if the npm packages are removed (we saw that problem some year ago...) then we can build.
Problems I see:

adding the dependencies manually using npm install to local git doesn't guarantee the exact code matched the npm package, and the developer (accidentally) my have changed it before commit
editing a local dependency package is untraceable (without looking through git history) and it should be very obvious to see we are not compliant with official version for some reason
our projects doesn't use the same version of the same dependency, and they are not updated to later versions

I'm unsure what the best approach to this is - but it might be a mix.
The result I want to have is that:

we can always build - even offline
we can always run and serve our website - even if other services are down (except obviously our own host)
we know exactly version of a package is being uses
when a dependency is edited, so it becomes a local fork, then we need to make that visual
we want an easy way to use newer version of a dependency
we should have an easy way to pull updated of a dependency and see if the work with our local edits (forks)

@lakruzz @kryptag this could be something for a blog post one day...
I got the idea from https://github.com/josra/josra.github.io/issues/31


⚠ Thumbnails API Endpoint has degraded performance

In fc20a9b, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1098 ms

Resolved: Thumbnails API Endpoint performance has improved in 3ebc8d1.