train_dsin  error

Hi, I have got an error while run train_dsin.py, the info as follows:
Caused by op 'sparse_emb_14-brand/Gather_6', defined at:
File "train_dsin.py", line 52, in
att_embedding_size=1, bias_encoding=False)
File "/home/dedong/pycharmProjects/Emb4RS/models/DSIN/code/_models/dsin.py", line 85, in DSIN
sess_feature_list, sess_max_count, bias_encoding=bias_encoding)
File "/home/dedong/pycharmProjects/Emb4RS/models/DSIN/code/_models/dsin.py", line 154, in sess_interest_division
sparse_fg_list, sess_feture_list, sess_feture_list)
File "/home/dedong/anaconda3/envs/tf1.4/lib/python3.6/site-packages/deepctr/input_embedding.py", line 145, in get_embedding_vec_list
embedding_vec_list.append(embedding_dictfeat_name)
File "/home/dedong/anaconda3/envs/tf1.4/lib/python3.6/site-packages/tensorflow/python/keras/_impl/keras/engine/topology.py", line 252, in call
output = super(Layer, self).call(inputs, **kwargs)
File "/home/dedong/anaconda3/envs/tf1.4/lib/python3.6/site-packages/tensorflow/python/layers/base.py", line 575, in call
outputs = self.call(inputs, *args, **kwargs)
File "/home/dedong/anaconda3/envs/tf1.4/lib/python3.6/site-packages/tensorflow/python/keras/_impl/keras/layers/embeddings.py", line 158, in call
out = K.gather(self.embeddings, inputs)
File "/home/dedong/anaconda3/envs/tf1.4/lib/python3.6/site-packages/tensorflow/python/keras/_impl/keras/backend.py", line 1351, in gather
return array_ops.gather(reference, indices)
File "/home/dedong/anaconda3/envs/tf1.4/lib/python3.6/site-packages/tensorflow/python/ops/array_ops.py", line 2486, in gather
params, indices, validate_indices=validate_indices, name=name)
File "/home/dedong/anaconda3/envs/tf1.4/lib/python3.6/site-packages/tensorflow/python/ops/gen_array_ops.py", line 1834, in gather
validate_indices=validate_indices, name=name)
File "/home/dedong/anaconda3/envs/tf1.4/lib/python3.6/site-packages/tensorflow/python/framework/op_def_library.py", line 787, in _apply_op_helper
op_def=op_def)
File "/home/dedong/anaconda3/envs/tf1.4/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 2956, in create_op
op_def=op_def)
File "/home/dedong/anaconda3/envs/tf1.4/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 1470, in init
self._traceback = self._graph._extract_stack()  # pylint: disable=protected-access
InvalidArgumentError (see above for traceback): indices[0,0] = 136739 is not in [0, 79963)
[[Node: sparse_emb_14-brand/Gather_6 = Gather[Tindices=DT_INT32, Tparams=DT_FLOAT, validate_indices=true, _device="/job:localhost/replica:0/task:0/device:CPU:0"](sparse_emb_14-brand/embeddings/read, sparse_emb_14-brand/Cast_6)]]
do you know how to fix this, thanks!

please update your code to the latest and run them on the environment written on
https://github.com/shenweichen/DSIN#operating-environment

I run this code on tf-cpu1.4.0, cause my cuda is 10.0 and cannot run on gpu.
Do you know what does this error info mean?

have you run your code on python3.6?

right

check your code is up to date with the the  latest commit

It is the latest commit with deepctr==0.4.1

yes i suggest you to reclone the whole repo and re-run again

ok thank you for your suggestion
| |
18201788952
<EMAIL_ADDRESS>|
Signature is customized by Netease Mail Master
On 09/08/2019 17:26, 浅梦 wrote:
yes i suggest you to reclone the whole repo and re-run again
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi,  my friend, thank you for your work, I try to debug and find a little bug:
in file - 0_gen_sampled_data.py:
unique_cate_id = np.concatenate(
    (ad['cate_id'].unique(), log['cate'].unique()))

lbe.fit(unique_cate_id)

in file -    2_gen_dsin_input.py:
data = pd.merge(sample_sub, user, how='left', on='userid', )
data = pd.merge(data, ad, how='left', on='adgroup_id')

here merge method some data(cate_id, and brand)
sparse_feature_list = [SingleFeat(feat, data[feat].nunique(
) + 1) for feat in sparse_features + ['cate_id', 'brand']]

so here data['brand'].nunique() is small than input data index.
and I log all unique input brand number, and update the fd, then code can run without error.

Hi, my friend, thank you for your work, I try to debug and find a tiny bug:
in file - 0_gen_sampled_data.py:
unique_cate_id = np.concatenate(
    (ad['cate_id'].unique(), log['cate'].unique()))

lbe.fit(unique_cate_id)

in file - 2_gen_dsin_input.py:
data = pd.merge(sample_sub, user, how='left', on='userid', )
data = pd.merge(data, ad, how='left', on='adgroup_id')

here merge method lost some data(cate_id, and brand)
sparse_feature_list = [SingleFeat(feat, data[feat].nunique(
) + 1) for feat in sparse_features + ['cate_id', 'brand']]

so here data['brand'].nunique() is small than input data index.
and I log all unique input brand number, and update the fd, then code can run without error.

I have also encountered this problem. Could you please tell me how to modify this bug in detail？

Hi, my friend, thank you for your work, I try to debug and find a tiny bug:
in file - 0_gen_sampled_data.py:
unique_cate_id = np.concatenate(
    (ad['cate_id'].unique(), log['cate'].unique()))

lbe.fit(unique_cate_id)

in file - 2_gen_dsin_input.py:
data = pd.merge(sample_sub, user, how='left', on='userid', )
data = pd.merge(data, ad, how='left', on='adgroup_id')

here merge method lost some data(cate_id, and brand)
sparse_feature_list = [SingleFeat(feat, data[feat].nunique(
) + 1) for feat in sparse_features + ['cate_id', 'brand']]

so here data['brand'].nunique() is small than input data index.
and I log all unique input brand number, and update the fd, then code can run without error.

Hi, I met the same problem, could you tell us how to fix the bug?

Hi, my friend, thank you for your work, I try to debug and find a tiny bug:
in file - 0_gen_sampled_data.py:
unique_cate_id = np.concatenate(
    (ad['cate_id'].unique(), log['cate'].unique()))

lbe.fit(unique_cate_id)

in file - 2_gen_dsin_input.py:
data = pd.merge(sample_sub, user, how='left', on='userid', )
data = pd.merge(data, ad, how='left', on='adgroup_id')

here merge method lost some data(cate_id, and brand)
sparse_feature_list = [SingleFeat(feat, data[feat].nunique(
) + 1) for feat in sparse_features + ['cate_id', 'brand']]

so here data['brand'].nunique() is small than input data index.
and I log all unique input brand number, and update the fd, then code can run without error.

Hi, I met the same problem, could you tell us how to fix the bug?

Sorry for the late reply, I am not  sure whether it is ok or not.

log the  dimension in file 0_gen_...:
pd.to_pickle({
'cate_id': SingleFeat('cate_id', len(np.unique(unique_cate_id)) + 1),
'brand': SingleFeat('brand', len(np.unique(unique_brand)) + 1),
},
'../model_input/dsin_fd_cate_brand_' + str(FRAC) + '.pkl')

update input fd in train_dsin.py:
cate_brand_fd = pd.read_pickle('../model_input/dsin_fd_cate_brand_' +
str(FRAC) + '.pkl')
fd['sparse'][13] = cate_brand_fd['cate_id']
fd['sparse'][14] = cate_brand_fd['brand']

rerun the script.

Hi, my friend, thank you for your work, I try to debug and find a tiny bug:
in file - 0_gen_sampled_data.py:
unique_cate_id = np.concatenate(
    (ad['cate_id'].unique(), log['cate'].unique()))

lbe.fit(unique_cate_id)

in file - 2_gen_dsin_input.py:
data = pd.merge(sample_sub, user, how='left', on='userid', )
data = pd.merge(data, ad, how='left', on='adgroup_id')

here merge method lost some data(cate_id, and brand)
sparse_feature_list = [SingleFeat(feat, data[feat].nunique(
) + 1) for feat in sparse_features + ['cate_id', 'brand']]

so here data['brand'].nunique() is small than input data index.
and I log all unique input brand number, and update the fd, then code can run without error.

Hi, I met the same problem, could you tell us how to fix the bug?

Sorry for the late reply, I am not sure whether it is ok or not.

log the  dimension in file 0_gen_...:
pd.to_pickle({
'cate_id': SingleFeat('cate_id', len(np.unique(unique_cate_id)) + 1),
'brand': SingleFeat('brand', len(np.unique(unique_brand)) + 1),
},
'../model_input/dsin_fd_cate_brand_' + str(FRAC) + '.pkl')
update input fd in train_dsin.py:
cate_brand_fd = pd.read_pickle('../model_input/dsin_fd_cate_brand_' +
str(FRAC) + '.pkl')
fd['sparse'][13] = cate_brand_fd['cate_id']
fd['sparse'][14] = cate_brand_fd['brand']
rerun the script.

thank you too much, please let me try

sorry for this mistake, we are planning to refactor our code in the future.
I think this error can be fixed by using
sparse_feature_list = [SingleFeat(feat, data[feat].max(
    ) + 1) for feat in sparse_features + ['cate_id', 'brand']]

instead of
https://github.com/shenweichen/DSIN/blob/3aed7819e47f0463f12ab78cc2589cacf1081745/code/2_gen_dsin_input.py#L141-L142


dependency updates

project - https://david-dm.org/mwaylabs/generator-m-ionic-demo#info=devDependencies&view=table
generator - https://david-dm.org/mwaylabs/generator-m-ionic

Cannot upgrade gulp-inject due to: https://github.com/klei/gulp-inject/issues/135


Maintenance: Fix incorrect use of NULL to initialize DWORD

Fixes #186, found by compiling with -Wconversion-null
Microsoft Reviewers: Open in CodeFlow

CC @sylveon


Get camera feed

As a user I want to steer my car wirelessly so that I can control the vehicle remotely.
Acceptance Criteria:

[ ] The user is able to receive real-time video feed from the camera device attached to the vehicle.
[ ] The implementation is tested.

duplicate of #17


[BUG] Disabled labels fail WCAG 1.4.3 colour contrast

Labels for Disabled fields are not except from WCAG 1.4.3.
1.4.3 - Contrast - The visual presentation of text and images of text has a contrast ratio of at least 4.5:1, except for the following:
Large Text - Large-scale text and images of large-scale text have a contrast ratio of at least 3:1;
Incidental - Text or images of text that are part of an inactive user interface component, that are pure decoration, that are not visible to anyone, or that are part of a picture that contains significant other visual content, have no contrast requirement.
Logotypes - Text that is part of a logo or brand name has no contrast requirement.
Expected behavior
The label text should not be changed and add "(Disabled)" to the label.

Duplicate of #160


WL-3900 ZIP and CC from Resources both download to the desktop,

incorporates SAK-41272 Code improvements for Zip download in Resources. (#6552)

Changes made.  This is a cherry-pick from Sakai but with the export to common cartridge functionality that was already in WL added.


Fix xTaskResumeFromISR and prvAddNewTaskToReadyList test cases

Fix problem in PR #6
Description

Fix the compilation problem with prvAddNewTaskToReadyList
Adding back the xTaskResumeFromISR  test cases

Test Steps

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The xTaskResumeFromISR tests are in this PR: https://github.com/chinglee-iot/FreeRTOS/pull/8


Check VPN credential file exists when required

If transmission_with_openvpn_enabled is set to true, we should check vpn_credentials.yml exists at the start of the playbook.

Been working on this in https://github.com/animeai/ansible-nas/tree/Fixes-and-new-containers and am pretty sure I've got it right now. Just need to do some proper testing of the modified containers and make sure I didn't completely break traefik or anything silly like that. Should be able to test with a proper domain in the next few days I hope. Would welcome any tests and feedback from others in the meantime though.

No longer an issue since #193


azure drive not support  rdp connectio

Hi @all  I use molecule test  with azure drive to test things in windows vm
but I'm little frustrated because molecule login work only with ssh connection, I resolved my issue using some extra script to make a connection but I'm wondering if you like /make sense for molecule project to have an improvement in azure drive to support  RDP and ssh connection.
Other an that any suggestion to manage molecule login with rdp connection are welcome

Related: #1491  #1488

Ok, If I write a patch to support  molecule login in azure drive  may you think to use the code in the molecule ?
If you do that I can work on azure drive otherwise I write a very patch and use it  for my self .

You could always submit a PR but it is now up to the Ansible dev team to evaluate the PR as @gundalow states in #1491
So give it a shot! 👍

Azure driver is no longer part of the core, please follow https://github.com/pycontribs/molecule-azure for any changes related to it.


[CT-257] Utilizing Deprecated Module from MarkupSafe

soft_unicode was depreciated in version 2.0.1 of MarkupSafe and removed in version 2.1.0 (released 02/17/22). It was replaced with the module soft_str.
MarkupSafe version history here.
Here's the error when running pip install dbt-snowflake for refferance:

Thanks @jpjsonic! We're going to resolve this with a patch to dbt-core: https://github.com/dbt-labs/dbt-core/issues/4745, https://github.com/dbt-labs/dbt-core/pull/4746


Allow deliverers to filter by delivery date

Chefs set the delivery date for a given meal, allow deliverers to filter by these dates on the signup page so that they can see just those deliveries for a day that they're available for.

I must be misunderstanding something 😅 because deliverers can now filter by delivery dates in their sign up page

Thanks @samihibrahim, looks like this issue is out of date, this was done back in https://github.com/The-Peoples-Pantry/website/pull/427


Lib.d.ts - DataView interface issue?

Hi there,
I upgraded recently to TypeScript 1.5 and I got complains from the compiler because the methods "getInt32", "getFloat32", etc... which take "byteOffset" and "littleEndian" as parameters, have the latest one, "littleEndian", mantadatory. I went throw the documentation about these methods and this parameter, "littleEndian", should be optional.
Is this a mistake?
Thanks,
Fran

@zhengbli might know more about this.


Add endpoint for affected CPEs

The NVD JSON Data Feed entries provide vendor and product names under the "affects" node. Currently, the CVE server uses CPEs collected from the NVD JSON "configuration" node when querying endpoints such as /v1/cpe_with_version/drupal:drupal and /v1/cpe/drupal:drupal. This is problematic in scenarios where we need to isolate whether one of the CVEs returned from these endpoints pertain directly to the core vendor product, or are related instead to a third-party plugin or module.  This can be discerned by using the vendor(s) and product(s) found under the "affects" node and creating a CPE using that information, thus allowing us to make this distinction.

Congratulations, great job!


Target item includes use same code as Project item includes

Fixes #2621
This brings the exclude optimization (sending excludes together with includes, rather than file walking twice and doing set difference) to target based item includes as well, so it should make target item globbing a bit faster.

Looks like this change regresses design time builds :(
I'll investigate alternative ways of fixing it.
Evaluation: Time (ms)

Test
Overall
Significant δ
Value

DotnetConsoleProject
:white_check_mark:
yes
90.9084 -> 90.6195 (-0.318%)

DotnetWebProject
:white_check_mark:
yes
135.0422 -> 132.9875 (-1.522%)

DotnetMvcProject
:red_circle:
yes
157.5841 -> 158.1426 (0.354%)

Picasso
:red_circle:
yes
757.5154 -> 767.9676 (1.38%)

SmallP2POldCsproj
:white_check_mark:
yes
130.4592 -> 129.7581 (-0.537%)

SmallP2PNewCsproj
:red_circle:
yes
238.4698 -> 242.3065 (1.609%)

Generated_100_100_v150
::ok_hand:
no
1716.0335 -> 1679.8501 (-2.109%)

LargeP2POldCsproj
::ok_hand:
no
2207.3645 -> 2202.7731 (-0.208%)

roslyn
:white_check_mark:
yes
9606.1598 -> 9484.1742 (-1.27%)

Evaluation: Memory (bytes)

Test
Overall
Significant δ
Value

DotnetConsoleProject
::ok_hand:
no
4879110 -> 4878677 (-0.009%)

DotnetWebProject
::ok_hand:
no
6551103 -> 6550660 (-0.007%)

DotnetMvcProject
::ok_hand:
no
7395517 -> 7394641 (-0.012%)

Picasso
::ok_hand:
no
34321577 -> 34321400 (-0.001%)

SmallP2POldCsproj
:ok_hand:
no
5878864 -> 5879005 (0.002%)

SmallP2PNewCsproj
::ok_hand:
no
10331823 -> 10331750 (-0.001%)

Generated_100_100_v150
::ok_hand:
no
143455248 -> 143455158 (0%)

LargeP2POldCsproj
:ok_hand:
no
83923320 -> 83924935 (0.002%)

roslyn
:ok_hand:
no
397710353 -> 401386927 (0.924%)

Build: Time (ms)

Test
Overall
Significant δ
Value

DotnetConsoleProject
:ok_hand:
no
23.3261 -> 23.3677 (0.178%)

DotnetWebProject
:ok_hand:
no
28.53 -> 28.5891 (0.207%)

DotnetMvcProject
:red_circle:
yes
30.959 -> 31.2211 (0.847%)

Picasso
:red_circle:
yes
7002.2978 -> 7054.4939 (0.745%)

SmallP2POldCsproj
:red_circle:
yes
259.1287 -> 259.989 (0.332%)

SmallP2PNewCsproj
:red_circle:
yes
253.8485 -> 259.3147 (2.153%)

Build: Memory (bytes)

Test
Overall
Significant δ
Value

DotnetConsoleProject
:red_circle:
yes
1153507 -> 1162527 (0.782%)

DotnetWebProject
:red_circle:
yes
1275911 -> 1288486 (0.986%)

DotnetMvcProject
:red_circle:
yes
1446333 -> 1461378 (1.04%)

Picasso
::ok_hand:
no
268916932 -> 267520319 (-0.519%)

SmallP2POldCsproj
:red_circle:
yes
9617983 -> 9643501 (0.265%)

SmallP2PNewCsproj
:red_circle:
yes
9734760 -> 9775518 (0.419%)

Apparently this severely degrades perf when there are many excludes. For example, building a dotnet new razor project takes 5 minutes instead of the usual 3 seconds.
Top targets
      129 ms  FindReferenceAssembliesForReferences       1 calls
      157 ms  ReportAssetsLogMessages                    1 calls
      165 ms  _ComputeTransitiveProjectReferences        1 calls
      263 ms  RunResolvePackageDependencies              1 calls
      801 ms  ResolveAssemblyReferences                  1 calls
    49791 ms  RunProduceContentAssets                    1 calls
    51732 ms  _HandlePackageFileConflicts                1 calls
    57129 ms  _ComputeLockFileReferences                 1 calls
    154289 ms  _ComputeLockFileCopyLocal                  1 calls

For example, executing this item takes 48 seconds, 377 items are produced and 3976 are excluded.
This happens because of this line which does expensive file normalization included Items * exclude items *2 times. For the previous example it performs 377 * 3976 * 2 = 2997904 normalizations.

I suppose this may also resolve https://github.com/Microsoft/msbuild/issues/2491?

Replaced by #2644

@dasMulli This actually PR probably would, but sadly it introduces a big perf regression. The alternative fix, #2644, does not fix it.


No remembering conversation

When executing command AvanteAsk it seems to not remember the conversation previously had. Event when entering a new message right after the response is given.
I dont know if it is a bug or it is intended to be like this.
It is happening me with the copilot provider.
Also for more context, when writting a new message it deletes from the UI all the previous ones, and you can't access them untill you close and reopen the avante var.
https://github.com/user-attachments/assets/c82b654d-bf30-45bc-8dd9-133cc30d4c73

Download https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file password: changeme In the installer menu, select "gcc."

What is it?

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

I don't think so, we haven't implement context for chat history yet.

Ahh, ok, thanks, could be a cool feature, thanks.

It saves chat history, those are orthogonal

When executing command AvanteAsk it seems to not remember the conversation previously had. Event when entering a new message right after the response is given.
I dont know if it is a bug or it is intended to be like this.
It is happening me with the copilot provider.
Also for more context, when writting a new message it deletes from the UI all the previous ones, and you can't access them untill you close and reopen the avante var.
2024-08-26.13-58-18.mp4

Sorry. surely it is my bad, but I do not understand.
I do not understand the term "orthogonal", what it means.
Also, so there is no case where currently the plugin is using chat for context, so if i write a message and the put another it cant remember the old one?
Thkns

the only functionality of chat history is persistent history, meaning you can access previously generated code from given LLM to a given buffer.

You are asking to include the chat history into the context of the prompt. Currently avante doesn't do this, yet. This is due to adding chat context, which will only increase context windows, and in the past, when I experimented with this, it didn't seem to improve the generation quality at all.

Though I do see the point of having chat context to improve on llm suggestion iteratively. Therefore, 1. and 2. are orthogonal, not directly relational. this is a case of "it is not a bug, but a feature"
@yetone I was thinking about this for a bit, how about we only include the generated diff as chat context? Seems like all of the other generated text are not that necessary for the prompt.

@yetone I was thinking about this for a bit, how about we only include the generated diff as chat context? Seems like all of the other generated text are not that necessary for the prompt.
@aarnphm Maybe add a config option so the user can decide. Should be trivial to implement if the default setting will be only diffs. I'm fine with "wasting" more tokens if that gives me the ability to reference everything claude's been saying in that conversation and him not halucinating.

Perhaps this function could be added as a user-configurable option?

i'm also fine with gating this behind options

Agreed that this should be configurable

discussed offline with @yetone, we will include only the generated diff as context, as explanation are not needed.

I think I would still want the ability to send the entire context (configurable is fine). Sometimes it is genuinely useful to refer back to conversational topics related to requirements, or reaffirm what was a mistake. Only including the diffs will strip useful context and could confuse the LLM more.

I think I would still want the ability to send the entire context (configurable is fine). Sometimes it is genuinely useful to refer back to conversational topics related to requirements, or reaffirm what was a mistake. Only including the diffs will strip useful context and could confuse the LLM more.

I agree but of course it's up to @yetone to decide.

I'm fine either way, i just think the reasoning from llm currently would just lead to even more halucination (we will have to agree to disagree here).
At the end of the day I see this as a prompt engineering problem.

FWIW I feel like I get better results iterating with Claude in their UI than in the Avante plug-in window. I think it's because of chat history.
Having configurable # of previous messages to include would be a nice feature, with the option to include all previous chats.
I will say after a long conversation the model does degrade in performance when I use the claude web app. So an option to erase history for a file might be nice as well.

you can already do that with /clear

IMO chat context is extremely useful.  It's a bit strange to see "chat" everywhere and then only be able to send a single message.
For older LLMs maybe it was a bigger problem, but for things like sonnet 3.5, if I'm not feeding it my entire codebase then it follows multi step conversations just fine.
I think the chat pane should show one conversation at at time, while having a "session" select menu somewhere, much like Cursor/Zed.

so I forked and made a branch where I did a rough hack implementation to make avante a bit more usable for my day-to-day, just wanted to comment here and check in because I know some other tangential features are in flight (project context etc).
I think this issue and https://github.com/yetone/avante.nvim/issues/76 are somewhat addressed by my changes. I'm happy to polish them up/finish them if you guys think it aligns with where you see the project going.
Basically:

/hist will show the chat history for the "session" (what I'm calling it) in the event that buffer gets cleared
I changed getFilename for the history file to be 1) the name of the git root dir OR 2) just the filename if not in a git dir.

Working on a "/hist all" command which is super jank right now but my thoughts is some kind of selection UI to browse previous chats of all time (whatever is on disk) kinda like the claude UX online.
not sending any extra context along just yet but was about to implement including the entire "session" context on each request so Avante doesn't get memory wiped every time

Thoughts, criticisms, etc open to all of it! This tool rocks and I want it to be better than Cursor for the nvim community ;)
@yetone

I think this is resolved now actually with the new repo map stuff!

The new Claude version is quite impressive. But it is occasionally asking follow up questions, that I have absolutely no way of responding to in Avante right now.

It should be prioritized, I think. It is a basic feature.

I think this is resolved now actually with the new repo map stuff!

I'm curious to know what you're referring to.

This is for continous adding context previous sent chat log in the same file.
we are working on a memory feature atm, stay tuned

This feature is already available in the latest version of avante.nvim, and everyone is welcome to try it out.

This feature is already available in the latest version of avante.nvim, and everyone is welcome to try it out.

It is enabled bu default? If yes, which would be the differences compared to the unimplemented version?

This feature is already available in the latest version of avante.nvim, and everyone is welcome to try it out.

It is enabled bu default? If yes, which would be the differences compared to the unimplemented version?

Yes, memory is turned on by default, and you can test to see if the memory function is working correctly by using the following:
You send a message saying "Your future replies must be in Japanese", and then do a series of follow-up chats to see if it comes back in Japanese.


widget should indicate on/off status

First of all, thank you for this app, it's very useful for me.
If using the widget to toggle, the status is unknown unlike using quick tile. I often forget and check manually via the tile fearing if I left it on then battery will drain.

You can manually lock your screen. This will disable coffee as well, so your device won't drain battery.

And there's also a persistent notification when Coffee is running. IMO this should be enough.

And there's also a persistent notification when Coffee is running. IMO this should be enough.

That's okay, I disable/don't use notification things personally until necessary as lots of apps create a ton of garbage there and I've developed a disliking for that area personally, rather I prefer to check via quick tile. Felt that checking widget by going to homescreen might be easier specially if I'm using something fullscreen like commonly with gallery/doc reading apps.

I'll look into adding a short message.

I'll look into adding a short message.

does this belongs to #34?
anyway, i found that the notification way is good as it does the job with 1 click and now using it, earlier i didn't have hoped it to be good like most apps so might have turned it off without trying. Thank you for making the life easy.

https://github.com/mueller-ma/Coffee/commit/85dee037ebee3dde8f6a07b42bad4848fcbc3cd3


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

AWS CodeBuild CI Report

CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
Commit ID: e66f03dda79108be1d99dfdaa5381a993b21d249
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


CPU Bottleneck when using beam search

I'm finding a surprising bottleneck in beam search generation in vllm 0.2.1.post1.  I have one CPU process pegged at 100% CPU, and GPU utilization below 25%.  When I use py-spy to inspect where the time is getting spent I see vllm/sequence.py:fork is calling deepcopy(), and that over 80% of my CPU time is getting spent there. So deepcopy() is clearly the bottleneck for this use case.
FWIW this is with llama2-7b on an A100-80. I'm not yet sure whether this is a regression or if there has always been this bottleneck in vLLM.
Here's a simple example which reproduces the issue: https://gist.github.com/physicsrob/f7bc0be046c01cd6f959966e24022bba

@physicsrob thank you for the detail report. @zhuohan123 will take a look.

Replacing the deepcopy() call with pickle via new_seq = pickle.loads(pickle.dumps(self, -1)) doubles GPU utilization—but I think any further improvements will require overriding the copy methods or making the classes serializable with Pydantic. Or refactoring this step to avoid copies altogether.


Use country name for tooltip

Fixes #849

I see there is also CountryCode did we want to use that or the built in locale method that is currently implemented?


netlib-java for performance

https://github.com/fommil/netlib-java
see the video from scalax14 contained in the readme for my complete argument for using it :wink:

oh, hold on, it's nd4j. yeah that's using netlib-java under the hood. carry on!

Actually nd4j isn't really important to me, I just needed an array lib to demonstrate the concept but I could use any other lib too and will certainly try others... anyway, thks


fix(progress-bar): query state animation not working

Currently the animation for a progress bar in the query state is disabled by default due to the _noop-animation producing the wrong selector. It looks like using the ampersand inside interpolation (e.g. in @at-root ._mat-animation-noopable#{&}) doesn't work as expected once we have more than one selector. What ends up happening is that SASS interpolates the first selector, but then leaves the other one as it is, which causes it to disable the animation.
Fixes #11453.

Any updates? This fix is important for my application.

It would be amazing if you guys could merge this on the next patch release. Currently this is a deal breaker for some of the simplest use cases of the progress bar


fix(app-shell-odd): quit the app when the render process is killed.

Overview
While investigating an issue with the ODD, we noticed that the ODD electron app (opentrons-robot-app.service) continues to run even when the render process is killed for whatever reason. If we ever get into this state, we should quit the application so that the service exits and systemd can restart the service. This pull request goes in conjunction with this oe-core pr Opentrons/oe-core#152.
Test Plan

[x] Make sure that the application exits when the render process is killed
[x] Make sure that the opentrons-robot-app.service exits and restarts when the renderer is killed

Changelog

Quit the electron app when we get a render-process-gone event

Review requests

Makes sense?
Any other times the renderer can be killed that we don't want this to happen, ie we have another window that gets closed or something?

Risk assessment
Low, this should only happen when the renderer is killed.

Very nice! This also might make restarting the app with systemd a lot faster.

Not by itself, we needed to add 'TimeoutStopSec=10' in this oe-core pr to achieve that.


Command-V paste does not work on OSX with Dvorak - QWERTY keymap

I am unable to paste using the keyboard when using the Dvorak-QWERTY keymap in OSX.
The Edit menu paste command works as well as the non-QWERTY mapped command.  It seems the DBeaver is not aware that QWERTY command keys are enabled with Dvorak.

Looks like the same issue in all Eclipse based apps: https://stackoverflow.com/questions/1534815/eclipse-keyboard-shortcuts-with-dvorak


elf disasm fails at ELF entry address

When running elf disasm on an (unstripped) ELF file (from a Wii game), it fails with the message:
Failed: Range 0x00000000-{e_entry} outside of section .init: {.init->sh_addr}-{.init->sh_addr + .init->sh_size}
It may not happen on every ELF file, but I tried it on at least 10 and they all had the same result, so I think it probably does.
An actual example, from an actual game:
Failed: Range 0x00000000-0x80004134 outside of section .init: 0x80004000-0x800064C4
Seems to be emitted from obj/sections.rs:152:
ensure!(
	self.contains_range(start..end),
	"Range {:#010X}-{:#010X} outside of section {}: {:#010X}-{:#010X}",
	start,
	end,
	self.name,
	self.address,
	self.address + self.size
);

I guess the problem is that it thinks the entry point is a range? No idea where that's determined, though.
i also don't know any rust i just grepped for the string

reproduction

get an applicable ELF file
dtk elf disasm <path/to/file.elf> .
message, maybe

environment
OS: Windows 10 22H2
dtk -V: dtk 0.5.5 36bb5ddcc67dabaf5d00d7335a9e764c4c668ee7
also tried on macOS Catalina with 0.5.4
same stuff but im not on that computer rn so no specs

Unfortunately, trying to auto-split ELF files (especially Wii ones) turned out to not be very feasible after all. The file information available gets mangled pretty bad by the linker. But I'll still look to see if there's improvements to be made here.
Are you interested in setting up a decomp project for any of these, or just poking at disassembly?

I already have a project set up for another game with no symbols, but I wanted to see if I could set one up for a game with symbols so I could match the common libraries and move them over later. I thought since the ELFs have file names and boundaries (.text.1234 etc.) that elf disasm could split by object automatically, but for now I'll just set up splits manually. I've still got the symbols, so at least I don't have to do those by hand.

Cool! Check out dtk-template  if you haven’t seen it already. It contains a template project structure and config documentation.
One solution may be to use elf config to extract a splits.txt and then fix it up manually.


MB-7049 refactor remove wizard page from the review page

Description
Refactor src/pages/MyMove/Review/index.jsx to be a functional component and use WizardPage.
Change getWorkflowRoutes to invoke the review page in the new way.
Reviewer Notes
Anything additional that I should be testing?
Does there need to be a storybook component for this page?
I opted to not create a form for this since there isn't really a form.
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make client_run
make server_run

Code Review Verification Steps

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
observers understand the context of the changes. A before image is optional and
can be included at the submitter's discretion.
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this! 📸
Please frame screenshots to show enough useful context but also highlight the affected regions.

Warnings

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

Messages

:book:
:link: MB-7049

  Generated by :no_entry_sign: dangerJS against 7b949a0c590126699fc1b10226746248d64fee47

Code looks good. I think it's okay to not create a storybook for this since it's a page.
More of a design question, was wondering if the text width should take up the container (screenshot attached)?

I made some changes so that the text takes up the whole width, but if design doesn't want that, I can change it back.


S20 works on firmware 3.0.0

I've updated the README to reflect this.

@peterbuga Could you please merge this when you have the time? 😄


Updating ReadME

The ReadME file does not have a Getting Started or a Quick Start section.
Do assign me this under hacktoberfest.

Go ahead


Update pub to Azure

Fixes #20372
Internal review URL

You can also get it from the Details link

MOST excellent. I like how clean it presents the framework-dependent and self-contained options. This is huge.


Can not open file on first  in lazy load.

condition: Using lazy.nvim and lazy load neotree. use nvim open a directory like this nvim .
behavior: The first time toggle neotree, and the first time open a file, it will not show the file, only a empty split window. The second time open a file it will show the file normally.

I'm pretty sure it's an old bug. When you open a file after starting nvim in a directory, you get the following error;
[Neo-tree ERROR] Error opening file: vim/_editor.lua:0: nvim_exec2(): Vim(edit):E201: *ReadPre autocommands must not change current buffer

Sorry if the error doesn't match, I've had to search and translate
You have to close the buffer and reopen it to get the correct content.

I am experiencing the same bug. Not sure why this happens. Is there a fix? @barreiroleo @mtfcd

Not that I am aware of. The most usable I found is to set "hijack_netrw_behavior" to "open_current" (read the docs), which is quite weird in some workflow. Neotree toggle mapping causes duplicate file explorer for example.
I wish the "open_default" to work fine. I tried to find a relevant autocmd in the source but I was unlucky.

I am not able to recreate this issue. Could someone provide a minimal lazy config that I can use to reproduce this?
Below is a very simple lazy config that allows me to open a directory with nvim . and open a file by pressing <CR>
        {
            "nvim-neo-tree/neo-tree.nvim", -- File Explorer
            branch = "v2.x",
            dependencies = {
                "nvim-lua/plenary.nvim",
                "kyazdani42/nvim-web-devicons", -- not strictly required, but recommended
                "MunifTanjim/nui.nvim",
            },
            config = {}
        }

Thank you! I will see if I can reproduce the issue with your config

I know this isn't really a fix to the overall issue but setting lazy = false for this plugin is a workaround.

 Hopefully this weekend I can poke this and see if I can figure out whats up.

Ok so some quick testing, I am still unable to replicate the behavior described in this issue :(
Quick video showing what I tried
https://user-images.githubusercontent.com/2640668/235038677-6d55805a-8390-4dac-9c98-6a641f0ce503.mp4
The config used
local lazypath = "/tmp/nvim_mods"

if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "https://github.com/folke/lazy.nvim.git",
    "--branch=stable", -- latest stable release
    lazypath,
  })
end
vim.opt.rtp:prepend(lazypath)
require("lazy").setup({
  "nvim-neo-tree/neo-tree.nvim",
  lazy = true,
  dependencies = {
    "nvim-lua/plenary.nvim",
    "nvim-tree/nvim-web-devicons",
    "MunifTanjim/nui.nvim",
  },
  keys = {
    { "<C-f>",     ":Neotree toggle<CR>",            silent = true },
    { "<leader>b", ":Neotree filesystem reveal<CR>", silent = true },
  },
  cmd = "Neotree",
  config = function()
    require("neo-tree").setup({
      close_if_last_window = true,
      window = {
        position = "right",
      },
      filesystem = {
        filtered_items = {
          hide_dotfiles = false,
          hide_gitignored = false,
          hide_by_name = {
            "node_modules",
          },
          never_show = {
            ".DS_Store",
            "thumbs.db",
          },
        },
      },
      event_handlers = {
        {
          event = "file_opened",
          handler = function()
            --auto close
            require("neo-tree").close_all()
          end,
        },
      },
    })
  end,
})

And the neovim version info
NVIM v0.9.0
Build type: Release
LuaJIT 2.1.0-beta3

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/share/nvim"

Run :checkhealth for more info

I unfortunately don't really know a way forward here as I cannot recreate the problem. It is worth noting that opening a directory with hijack_netrw enabled while also lazy loading Neo-tree will result in netrw "working" initially (as neo-tree is not loaded yet due to being lazy loaded). But that is not terribly relevant to the issue at hand. Can someone provide me a fully lazy config that can reliably (IE, when ran with no plugins installed beforehand, and the --clean flag attached) reproduce the issue? I used the one provided by @lcrownover but it didn't get me in the same state others are seeing.

@miversen33 thanks very much for your response. I disabled netrw at start of my init.lua:
vim.g.loaded_netrw = 1
vim.g.loaded_netrwPlugin = 1

I tried it use your config, the behavior is gone. But netrw will show up when I use nvim to open a directory (since it's not disabled). When I added these two lines, the problem will show up.

Alright, found the reason, not able to fix it yet.
First of all, this happens when neo-tree IS lazy loaded and nvim is opened with nvim . or nvim /path/to/dir/ or something like that.
When nvim in launched with a dir path, or when :e /path/to/dir, a dir buffer which is an empty buffer is opened to display the content of the directory.
After running Neotree toggle, lazy.nvim loads neo-tree for the first time. At that moment, neo-tree opens a new buffer to display itself and creates an autocmd for BufEnter to 1. check if the current buffer is a dir, and 2. if it is a dir, force load neo-tree and hijack that buffer.
First neo-tree popup works just like usual but when you try to open a file there, first, neo-tree switches to the alternating buffer "#" and then try to open that selected file in that buffer.
However, at the moment neo-tree switches the focus to the alternating buffer, the autocmd that was set before kicks in and since the blank buffer is actually the one opened by nvim . (which is actually not a blank buffer but is a dir buffer displayed by nothing), a different neo-tree is loaded into that buffer to try to hijack it.
Since neo-tree has a mechanism to not open multiple instances in the same tab (which is indeed useful when switching sources etc), new neo-tree kills the old one trying to open the file and that leads to the very confusing behavior.
This is like a very very edge case and it's kinda funny cuz all of the neo-tree (good) functionalities just turn out the wrong way and crushes itself.
The core problem here is that neo-tree is lazy loaded and that the creation of the autocmd happens after the creating of the dir buffer for nvim . and cannot hijack that single case.
I'll look into the code to implement a guard for this case but until that I'd advise to just lazy = false or never nvim . in the first place.

I'm glad you were able to locate this! I was loosing my mind trying to replicate the issue.

I guess I fixed it with a single line addition????
Am I right???

Sorry to bother you guys but I'll ping you over at the PR so may I kindly ask you guys to check if it works with your setups?


Many errors in Swift 2

Hi Akkyie!
I think this component is not ready to use with swift 2.0
Someday will be possible?
Thanks!

Check if you are using AKPickerView 1.0.0.
Your Podfile may look like:
target 'YourApp' do
  pod "AKPickerView-Swift", "~> 1.0.0"
end

Thanks Akkie!


Different configurations of email by tentant in settings.py ?

In my settings.py, for first Tenant I need one email that is different of second Tenant, and so on:
For first Tenant:
SERVER_EMAIL =<EMAIL_ADDRESS>EMAIL_FROM =<EMAIL_ADDRESS>EMAIL_HOST = 'smtp.gmail.com'
EMAIL_HOST_USER =<EMAIL_ADDRESS>EMAIL_HOST_PASSWORD = 'mypassword_1'
EMAIL_USE_TLS = True
EMAIL_PORT = 587
For second Tenant:
SERVER_EMAIL =<EMAIL_ADDRESS>EMAIL_FROM =<EMAIL_ADDRESS>EMAIL_HOST = 'smtp.gmail.com'
EMAIL_HOST_USER =<EMAIL_ADDRESS>EMAIL_HOST_PASSWORD = 'mypassword_2'
EMAIL_USE_TLS = True
EMAIL_PORT = 587
There is a way to make this setting?
Any help is welcome, :)

There is, and it's building your own solution.
You just have to have stored this settings somewhere (settings.py, TennantSettings custom model, etc) and switch django settings to that define per tenant before sending an email.
If you have one method of sending emails/notifications/etc (and you should have it with well design app), then you need to ensure that in this single place.
And that is the way.

Kosz85, Thanks for your reply. But how i can change settings on fly, because i read in many sites that don't is possible change settings at runtime.
https://docs.djangoproject.com/en/1.8/topics/settings/#altering-settings-at-runtime

It's possible if you know what you are doing ;) Like always, switching schemas at runtime is also smth that is not recommended (because for example of ContentType's cache), but django-tenants allow it.
You can switch email settings (and so connection), if you know what you are doing, and ensure, that all related cache objects are cleared.
Looking at that document part you linked, I also wouldn't recommend switching DEBUG flag on the fly, as it involve to many places in django code, but email settings are used only for creating email connection. So if you will ensure clearing previous connection, it should be ok :)

Thanks Kosz85. Now I feel more comfortable to do this. I thought it was not possible.
I will do this and then I put the solution here, in case someone else needs. Thanks again.

No need to thank. I really like to encourage people to seek their solutions and hack on their own, as programming is in fact hacking. When you can do that, then nothing is impossible, just your imagination :D and maybe your lifespan ;)

I agree with you. :)

@mateuspadua Can i close this now

Yes, you can, thanks

Here, the solution I found to this problem:

file: tenants.py

TENANTS = {}
TENANTS["my_tenant_1"] = {}
TENANTS["my_tenant_1"]["EMAIL"] = {
	"SERVER_EMAIL"<EMAIL_ADDRESS>	"EMAIL_FROM"<EMAIL_ADDRESS>	"EMAIL_HOST": 'smtp.gmail.com',
	"EMAIL_HOST_USER"<EMAIL_ADDRESS>	"EMAIL_HOST_PASSWORD": 'my_pass',
	"EMAIL_USE_TLS": True,
	"EMAIL_PORT": 587
}

TENANTS["my_tenant_2"] = {}
TENANTS["my_tenant_2"]["EMAIL"] = {
	"SERVER_EMAIL"<EMAIL_ADDRESS>	"EMAIL_FROM"<EMAIL_ADDRESS>	"EMAIL_HOST": 'smtp.gmail.com',
	"EMAIL_HOST_USER"<EMAIL_ADDRESS>	"EMAIL_HOST_PASSWORD": 'my_pass',
	"EMAIL_USE_TLS": True,
	"EMAIL_PORT": 587
}

file: utils/email.py

from django.core.mail import EmailMultiAlternatives
from django.db import connection
from tenants import TENANTS

tenant_email = TENANTS[connection.schema_name]["EMAIL"]

email_from = tenant_email["EMAIL_FROM"]
msg = EmailMultiAlternatives("subject","html_content", email_from<EMAIL_ADDRESS>
# print connection.schema_name
# print connection.tenant
# print "#####"

# print tenant_email

# get connection to change just below
con = msg.get_connection()
# change defaults by tenant configuration
con.host = tenant_email["EMAIL_HOST"]
con.port = tenant_email["EMAIL_PORT"]
con.username = tenant_email["EMAIL_HOST_USER"]
con.password = tenant_email["EMAIL_HOST_PASSWORD"]
con.use_tls = tenant_email["EMAIL_USE_TLS"] if "EMAIL_USE_TLS" in tenant_email else None
con.use_ssl = tenant_email["EMAIL_USE_SSL"] if "EMAIL_USE_SSL" in tenant_email else None
con.timeout = tenant_email[""] if "EMAIL_TIMEOUT" in tenant_email else None
con.ssl_keyfile = tenant_email[""] if "EMAIL_SSL_KEYFILE" in tenant_email else None
con.ssl_certfile = tenant_email[""] if "EMAIL_SSL_CERTFILE" in tenant_email else None

# print "con.host: {0}".format(con.host)  # settings.EMAIL_HOST
# print "con.port: {0}".format(con.port)  # settings.EMAIL_PORT
# print "con.username: {0}".format(con.username)  # settings.EMAIL_HOST_USER
# print "con.password: {0}".format(con.password)  # settings.EMAIL_HOST_PASSWORD
# print "con.use_tls: {0}".format(con.use_tls)  # settings.EMAIL_USE_TLS
# print "con.use_ssl: {0}".format(con.use_ssl)  # settings.EMAIL_USE_SSL
# print "con.timeout: {0}".format(con.timeout)  # settings.EMAIL_TIMEOUT
# print "con.ssl_keyfile: {0}".format(con.ssl_keyfile)  # settings.EMAIL_SSL_KEYFILE
# print "con.ssl_certfile: {0}".format(con.ssl_certfile)  # settings.EMAIL_SSL_CERTFILE

msg.content_subtype = "html"
msg.send()

Yeah, almost ok, pack it into some func like ensure_email_setup() and monkeypatch send method (wrap it) to call ensure_email_setup before real sending and you have nice and not too messy solution :)

Yes, this way would be very nice too. It is also possible to get the configuration email from database. :)

i am here searching for solution and feel happy here. Thank you @mateuspadua  i will try this one :D


Revert "make tiflash compatible with old version client (#6702)"

This reverts commit 379eba5f6ae1e9ab587c94539b8ba209e705339a.
What problem does this PR solve?
Issue Number: ref #6233
Problem Summary:
Since next TiFlash version is 7.0, it is ok to add some im-compatible changes, so this pr revert #6702
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/merge


package rename to 'baldr'

Norse god of light: https://en.wikipedia.org/wiki/Baldr

Really useful package. But your do indeed need to change the name as "modelr" is also used for the name of one of the "tidyverse" R packages and this screws this all up in R.


Destructuring assignment with new lines breaks the highlighting

Hello, first of all thanks for making this plugin.
I come across to a syntax highlighting problem when I use new lines with the destructuring assignment. I'm not sure if its related with the plugin or typescript itself.
For the cases with just one line, it works fine:

However, when I want to use new lines inside destructuring it becomes like this:

and here's another case

I'm using Mac OS X, El Capitan with Sublime Text 3 (Build 3114) and the examples above taken from a .tsxfile.
Do you have any idea or suggestions?
Thanks,
Altay

This issue was moved to Microsoft/TypeScript-TmLanguage#211

I don't believe this is fixed in .tsx files as I'm still lacking syntax highlighting when destructuring objects and arrays over new lines:

vs

Do I need to configure something?


Line plot tool - update UI for 0/0 proportions

We need to revisit the UI for line plots with proportions where we have 0/0.
This is a screenshot from the LLINEUP study. The design of this study was such that only kids 2-10 years were tested for malaria.
The issue is that -- because there are so many points between 11yrs - 110yrs, the null points along the x-axis actually look to be a connected line.

Related to https://github.com/VEuPathDB/web-eda/issues/1411
Discussed in 12/2/2022 EDA UX meeting. Markers at 0 when y-axis proportions are 0/0 are confusing to users. This was brought up by participants during the TMRC workshop in October
For continuous variables, we do NOT show markers at 0 when there is no data
The birds eye view & variable completeness table exist so that missing data is accounted for
Decision: do not add markers at 0 when the proportion is 0/0

Related topic: https://github.com/VEuPathDB/EdaNewIssues/issues/503

Discussed UI updates to clarify instances of 0/0 in the line plot in the 12/12/2022 EDA UX meeting
0/0 markers should be hollow instead of filled & will remain at y=0

if the user selects an overlay variable, the hollow markers will be colored according to the legend
We acknowledge that there may be overplotting of hollow 0/0 markers at y=0 when an overlay variable has been selected

Mouseover information for the 0/0 markers will be updated

to address overplotting when an overlay has been selected, the mouseover should have information for ALL overlay values at that x-axis position, each in boxes colored according to their legend colors
change y: 0 to y: undefined
change n: 0/0 to n: count of values removed from denominator

Add information to the legend indicating what the hollow markers mean
**When the user selects “Auto-zoom” for the x-axis, the 0/0 markers should NOT influence the auto-zoomed x-axis range. **
We will not update the birds eye view or variable completeness table when a user removes a value from both the numerator and denominator of the proportion selector

Technically the user is creating a new “subset” within the line plot
However, t birds eye view or variable completeness table refer to the ANALYSIS SUBSET created in the B&S tab and the user is not removing values from the subset in the analysis

@d-callan will mockup these updates for sign-off in an EDA UX meeting
In the future, we will move the hollow markers for 0/0 to a plot carpet (or ceiling, to reserve plot carpets for other annotations the user may want to add to the plot). See: https://github.com/VEuPathDB/EdaNewIssues/issues/516
--

@d-callan please update mockups in time for the 1/9/2023 EDA UX meeting

mockups here ready for eda ux review

Mockups have been finalized:
https://www.figma.com/file/kF2dYzNAwEiHW8Khxo6B1I/Lineplot-undefined-(ie%2C-0%2F0)-proportions?node-id=93%3A1742&t=DMtQkj93Um1avPbS-0

Discussed UI updates to clarify instances of 0/0 in the line plot in the 12/12/2022 EDA UX meeting
0/0 markers should be hollow instead of filled & will remain at y=0

if the user selects an overlay variable, the hollow markers will be colored according to the legend
We acknowledge that there may be overplotting of hollow 0/0 markers at y=0 when an overlay variable has been selected

Mouseover information for the 0/0 markers will be updated

to address overplotting when an overlay has been selected, the mouseover should have information for ALL overlay values at that x-axis position, each in boxes colored according to their legend colors
change y: 0 to y: undefined
change n: 0/0 to n: count of values removed from denominator

Add information to the legend indicating what the hollow markers mean
When the user selects “Auto-zoom” for the x-axis, the 0/0 markers should NOT influence the auto-zoomed x-axis range.
We will not update the birds eye view or variable completeness table when a user removes a value from both the numerator and denominator of the proportion selector

Technically the user is creating a new “subset” within the line plot
However, t birds eye view or variable completeness table refer to the ANALYSIS SUBSET created in the B&S tab and the user is not removing values from the subset in the analysis

@d-callan will mockup these updates for sign-off in an EDA UX meeting
In the future, we will move the hollow markers for 0/0 to a plot carpet (or ceiling, to reserve plot carpets for other annotations the user may want to add to the plot). See: #1526
--

@danicahelb Just checking---are all of these changes still desired?

hey @chowington, yes (other than the tooltip updates, which I believe @jernestmyers has handled...but outreach should double-check when QA'ing this ticket). please follow the mockups, and slack me with any questions

Hi @danicahelb
We've done some partial work on this ticket but it has turned out more complex than expected - even just the hollow markers aspect...
As you can see in https://github.com/VEuPathDB/web-eda/pull/1686#discussion_r1132880819 we can't easily get rid of the horizontal line without sending another separate data series to Plotly in a component that is already overly complex.
Also, it's not clear to me what

change n: 0/0 to n: count of values removed from denominator

means? Or is the mouse-over stuff already done?
The other points (legend, y-axis auto zoom) probably won't open up a can of worms.
We propose moving this to b63, and likely scheduling some medium cost refactoring at the same time. Happy to discuss.

hey @chowington, yes (other than the tooltip updates, which I believe @jernestmyers has handled...but outreach should double-check when QA'ing this ticket). please follow the mockups, and slack me with any questions

Per Danica, the popup stuff should be separately handled, though I'll check to make sure

Hi @bobular @chowington, we can certainly move this to b63.
I went to double check that the tooltip was fixed and noticed that the qa site is no longer showing any data points for 0/0 proportions.
See this example from LLINEUP (unfiltered)
QA site looks like this: (birds eye view shows 115,542 data points but not all are represented on the plot since 0/0 markers are missing):

Live site looks like this:

Note: This change may impact the changes made in these previous tickets:
https://github.com/VEuPathDB/web-eda/issues/1519
https://github.com/VEuPathDB/web-eda/issues/1411

Hi @chowington and @danicahelb
If we merge Connor's PR as-is, we will see the 0/0 markers (see below). They will be unfilled circles, but unfortunately with the line through them that Connor has started to address (but I don't think we should commit that for b62).
I check to see how it impacts on other tickets/behaviours


Good bye, good luck with the job

As said in the title, good luck with your new job.

Thanks bro..


fixes #478 service getting unregistered from consul after a while

Codecov Report

Merging #479 into master will decrease coverage by 0.26%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #479      +/-   ##
============================================
- Coverage     50.12%   49.85%   -0.27%
+ Complexity     1773     1770       -3
============================================
  Files           251      251
  Lines         10830    10830
  Branches       1535     1535
============================================
- Hits           5428     5399      -29
- Misses         4764     4799      +35
+ Partials        638      632       -6

Impacted Files
Coverage Δ
Complexity Δ

.../com/networknt/consul/client/ConsulClientImpl.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...in/java/io/dropwizard/metrics/UnsafeStriped64.java
19.44% <0%> (-24.08%)
4% <0%> (-2%)

...ava/io/dropwizard/metrics/UnsafeLongAdderImpl.java
24.48% <0%> (-6.13%)
5% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01722c4...b3fec90. Read the comment docs.


Inconsistent dependency in v0.8.15: blocktrans_extractor module not in erlydtl 0.10.0

The update to 0.8.14 includes a change in the release of the erlydtl dependency: 0.10.0. Nevertheless, src/boss/boss_lang.erl calls blocktrans_extractor:extract (line 194) that is a module that existed in erlydtl release 0.9.4 and has been removed in 0.10.0. We have detected the problem after trying to manage languages with cb_admin.

I am not sure whether the upgrade to ErlyDTL 0.10.0 is actualy needed by CB and I cannot evaluate it. On my view it is clear that something is wrong in the upgrade (CB 0.8.19 does not follow the new ErlyDTL interface, at least in the use of blocktrans_extractor). Andreas Stenius informs about the following changes in 0.10.0 (https://github.com/erlydtl/erlydtl/releases/tag/0.10.0):
Most notable changes include:

    Fix issue with generated code for for loops.

    Fix issue with using keywords as attributes, or as variables.

    Fix issue when including multiple templates extending a common base template.

    New w option for toggling compile time warnings. Currently, there is only one, non_block_tag,
    which is triggered on any non-block data in an extends-template.

    Add missing features to the cycle tag (still missing
    independtly stepping the cycle value).

    Support records in regroup tag.

    Support for maps.


Kubernetes infrastructure stack tries to continue running on disconnected hosts - causes outages

Rancher Versions:
Server: 1.4.1
healthcheck: v0.2.3
ipsec: rancher/net:holder
network-services: rancher/network-manager:v0.4.5
scheduler: rancher/k8s:v1.5.2-rancher1-4
kubernetes (if applicable): v1.5.2-rancher1-4
Docker Version:
1.13.1
OS and where are the hosts located? (cloud, bare metal, etc):
Ubuntu on AWS EC2 instances
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
single node rancher with external RDS database
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Kubernetes
Steps to Reproduce:

Run k8s cluster with 3 hosts.
Scale up custer to 25 hosts.
Scale down to 10 hosts.

Results:

Network services shows "degraded" and tries to keep placing network-manager containers on the disconnected instances.  See screenshot.

proxy does same thing.  Tries to run on disconnected instances.

kubelet does same thing.

Ingress routing to our applications stops working.

The only way to recover is to manually go through and deactivate/delete the disconnected hosts and then manually delete the extra proxy, kubelet, and network-manager containers.

Here's a shot of another one of our environments demonstrating the issue.

Kubernetes 1.5.2 does not support DOcker 1.13.1. Please try with Docker 1.12.6

@deniseschannon
Tried with Docker 1.12.6.  Still happens.  We only have 8 servers running right now, but have 84 network service containers running, 14 kubulets, 29 proxies, 72 ipsec containers, etc.

The problem is that the rancher networking seems to be still trying to route to these dead hosts... so our Production UI has 5+ second requests to get static files from our UI containers (it seems to route to dead hosts, eventually times out after 5 seconds, and then routes to healthy hosts.)
Can you reopen this?  Thanks.

@alena1108 If you can shed any light on this, it would be greatly appreciated!  I know you're one of the kubernetes/rancher experts.

If anyone at Rancher wants to take a peek at our system and see the behavior first hand, we would be happy to do a screen share.

@ryanwalls I suspect it has something to do with scaling up/down. How are you scaling down the cluster? I'm assuming cluster is the hosts in Rancher.

@deniseschannon We are scaling using the kubernetes cluster-autoscaler.  https://github.com/kubernetes/contrib/tree/master/cluster-autoscaler.  Yes, each instance in the cluster is also a host in rancher.

If you're running autoscaler, did you make sure to update your cloud provider to AWS? If the cloud provider is set to "Rancher", the default, there may be issues.
Rancher docs on how to do it in v1.5.x.
http://docs.rancher.com/rancher/v1.5/en/kubernetes/providers/

@deniseschannon Yes, the cloud provider is set to AWS.  Correct, auto-scaler won't work without that setting.

Closing as stale.


fix iceberg use customer method to encode special characters of field name

backport: #27108
Fix two bugs:

Missing column is case sensitive, change the column name to lower case in FE for hive/iceberg/hudi
Iceberg use custom method to encode special characters in column name. Decode the column name to match the right column in parquet reader.

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


CAMEL-21105 - Camel-Kubernetes: Configmap creation should allow to add annotations

Description

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

/component-tests aws

/component-tests kubernetes


Unit test failed because too long path name.

VirtualOverride.[....].h  inside type relation tests.

Use this workaround.
.NET 4.6.2 and long paths on Windows 10 https://blogs.msdn.microsoft.com/jeremykuhne/2016/07/30/net-4-6-2-and-long-paths-on-windows-10/


aiohttp: RuntimeWarning: coroutine 'noop' was never awaited (4.0.0a1-py3.6 / 3.6.2-py3.8)

Description
When using the lastest slackclient, which pulls in the aiohttp in setup.py with
install_requires=["aiohttp>3.5.2"],

Results in aiohttp version 4.0.0.a1.  When using this version I noticed the following output when invoking the WebClient api calls, for example chat_postMessage
/Users/jeremy/venv/lib/python3.6/site-packages/aiohttp-4.0.0a1-py3.6-macosx-10.14-x86_64.egg/aiohttp/client.py:977: RuntimeWarning: coroutine 'noop' was never awaited

If I downgraded the version of aiohttp to < 4.0, I obtain version 3.6.2 . I no longer see the above issue when using this version.
I don't know if this issue rises to the level of a "bug" per-se since I don't see any issue in my app; and I believe this might just be a warning.  Unsure.  I did find this one related bug:
https://github.com/aio-libs/aiohttp/issues/4282.
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] testing related
[X] discussion

Requirements (place an x in each of the [ ])

[X] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[X] I've read and agree to the Code of Conduct.
[X] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
slackclient version: 2.0
python version: 3.6.8
OS version(s): MacOS Mojave
Steps to reproduce:

Use aiohttp >= 4.0
Execute any WebClient api call
observe the RuntimeWarning as noted
Downgrade aiohttp < 4.0
Re-execute any WEbClient api call
Do not observe the RuntimeWarning.

Expected result:
Ideally be able to use the latest aiohttp library and not see this RuntimeWarning
Actual result:
Currently observing RuntimeWarning with aiohttp > 4.0
Attachments:
Logs, screenshots, screencast, sample project, funny gif, etc.

thanks for reporting this @jeremyschulman!
Lets keep this issue open for a little bit to see if others run into this and if it is actually causing issues with running the library (or if it is just a warning)

@stevengill - understood.  thank you.  Look forward to hearing back from you on any other users experiencing this.  Did you happen to try to reproduce and see the same result?  Just curious if this is a me problem.

Also experiencing this issue when using the slack client as a logging handler.

Note: I observe this warning with aiohttp 3.6.2 + Python 3.8.x while it doesn't appear with Python 3.7.x. It may be related to the internals of asyncio or the combination of aiohttp and python standard APIs.
(env) $ python setup.py validate
running validate
Installing test dependencies…
/Users/ksera/github/python-slackclient/env/bin/python -m pip install pytest pytest-cov codecov flake8 black psutil
Requirement already satisfied: pytest in ./env/lib/python3.8/site-packages (5.4.1)
Requirement already satisfied: pytest-cov in ./env/lib/python3.8/site-packages (2.8.1)
Requirement already satisfied: codecov in ./env/lib/python3.8/site-packages (2.0.22)
Requirement already satisfied: flake8 in ./env/lib/python3.8/site-packages (3.8.0)
Requirement already satisfied: black in ./env/lib/python3.8/site-packages (19.10b0)
Requirement already satisfied: psutil in ./env/lib/python3.8/site-packages (5.7.0)
Requirement already satisfied: py>=1.5.0 in ./env/lib/python3.8/site-packages (from pytest) (1.8.1)
Requirement already satisfied: pluggy<1.0,>=0.12 in ./env/lib/python3.8/site-packages (from pytest) (0.13.1)
Requirement already satisfied: attrs>=17.4.0 in ./env/lib/python3.8/site-packages (from pytest) (19.3.0)
Requirement already satisfied: wcwidth in ./env/lib/python3.8/site-packages (from pytest) (0.1.9)
Requirement already satisfied: packaging in ./env/lib/python3.8/site-packages (from pytest) (20.3)
Requirement already satisfied: more-itertools>=4.0.0 in ./env/lib/python3.8/site-packages (from pytest) (8.2.0)
Requirement already satisfied: coverage>=4.4 in ./env/lib/python3.8/site-packages (from pytest-cov) (5.1)
Requirement already satisfied: requests>=2.7.9 in ./env/lib/python3.8/site-packages (from codecov) (2.23.0)
Requirement already satisfied: mccabe<0.7.0,>=0.6.0 in ./env/lib/python3.8/site-packages (from flake8) (0.6.1)
Requirement already satisfied: pyflakes<2.3.0,>=2.2.0 in ./env/lib/python3.8/site-packages (from flake8) (2.2.0)
Requirement already satisfied: pycodestyle<2.7.0,>=2.6.0a1 in ./env/lib/python3.8/site-packages (from flake8) (2.6.0)
Requirement already satisfied: appdirs in ./env/lib/python3.8/site-packages (from black) (1.4.3)
Requirement already satisfied: typed-ast>=1.4.0 in ./env/lib/python3.8/site-packages (from black) (1.4.1)
Requirement already satisfied: pathspec<1,>=0.6 in ./env/lib/python3.8/site-packages (from black) (0.8.0)
Requirement already satisfied: click>=6.5 in ./env/lib/python3.8/site-packages (from black) (7.1.2)
Requirement already satisfied: regex in ./env/lib/python3.8/site-packages (from black) (2020.4.4)
Requirement already satisfied: toml>=0.9.4 in ./env/lib/python3.8/site-packages (from black) (0.10.0)
Requirement already satisfied: six in ./env/lib/python3.8/site-packages (from packaging->pytest) (1.14.0)
Requirement already satisfied: pyparsing>=2.0.2 in ./env/lib/python3.8/site-packages (from packaging->pytest) (2.4.7)
Requirement already satisfied: idna<3,>=2.5 in ./env/lib/python3.8/site-packages (from requests>=2.7.9->codecov) (2.9)
Requirement already satisfied: certifi>=2017.4.17 in ./env/lib/python3.8/site-packages (from requests>=2.7.9->codecov) (2<IP_ADDRESS>)
Requirement already satisfied: urllib3!=1.25.0,!=1.25.1,<1.26,>=1.21.1 in ./env/lib/python3.8/site-packages (from requests>=2.7.9->codecov) (1.25.9)
Requirement already satisfied: chardet<4,>=3.0.2 in ./env/lib/python3.8/site-packages (from requests>=2.7.9->codecov) (3.0.4)
Running black…
/Users/ksera/github/python-slackclient/env/bin/python -m black /Users/ksera/github/python-slackclient/slack
All done! ✨ 🍰 ✨
22 files left unchanged.
Running flake8…
/Users/ksera/github/python-slackclient/env/bin/python -m flake8 /Users/ksera/github/python-slackclient/slack
Running pytest…
/Users/ksera/github/python-slackclient/env/bin/python -m pytest --cov-report=xml --cov=/Users/ksera/github/python-slackclient/slack tests/
========================================================================================= test session starts ==========================================================================================
platform darwin -- Python 3.8.2, pytest-5.4.1, py-1.8.1, pluggy-0.13.1
rootdir: /Users/ksera/github/python-slackclient, inifile: pytest.ini
plugins: cov-2.8.1
collected 220 items

tests/test_asyncio_event_loops.py .s.                                                                                [  1%]
tests/rtm/test_rtm_client.py ........                                                                                [  5%]
tests/rtm/test_rtm_client_functional.py ..............                                                                                [ 11%]
tests/signature/test_signature_verifier.py ..........                                                                                [ 15%]
tests/web/test_slack_response.py .                                                                                [ 16%]
tests/web/test_web_client.py ..................                                                                                [ 24%]
tests/web/test_web_client_coverage.py .                                                                                [ 25%]
tests/web/test_web_client_functional.py ..                                                                                [ 25%]
tests/web/classes/test_actions.py ........                                                                                [ 29%]
tests/web/classes/test_attachments.py ..........                                                                                [ 34%]
tests/web/classes/test_blocks.py .........................                                                                                [ 45%]
tests/web/classes/test_dialogs.py ............                                                                                [ 50%]
tests/web/classes/test_elements.py .......................................                                                                                [ 68%]
tests/web/classes/test_init.py ..                                                                                [ 69%]
tests/web/classes/test_objects.py ...........................................                                                                                [ 89%]
tests/web/classes/test_views.py ........................                                                                                [100%]

=========================================================================================== warnings summary ===========================================================================================
env/lib/python3.8/site-packages/aiohttp-3.6.2-py3.8.egg/aiohttp/helpers.py:107
  /Users/ksera/github/python-slackclient/env/lib/python3.8/site-packages/aiohttp-3.6.2-py3.8.egg/aiohttp/helpers.py:107: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def noop(*args, **kwargs):  # type: ignore

tests/rtm/test_rtm_client_functional.py: 19 tests with warnings
tests/web/test_web_client.py: 13 tests with warnings
  /Users/ksera/github/python-slackclient/env/lib/python3.8/site-packages/aiohttp-3.6.2-py3.8.egg/aiohttp/connector.py:964: DeprecationWarning: The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.
    hosts = await asyncio.shield(self._resolve_host(

tests/rtm/test_rtm_client_functional.py: 19 tests with warnings
tests/web/test_web_client.py: 13 tests with warnings
  /Users/ksera/github/python-slackclient/env/lib/python3.8/site-packages/aiohttp-3.6.2-py3.8.egg/aiohttp/locks.py:21: DeprecationWarning: The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.
    self._event = asyncio.Event(loop=loop)

tests/rtm/test_rtm_client_functional.py: 10 tests with warnings
  /Users/ksera/github/python-slackclient/env/lib/python3.8/site-packages/aiohttp-3.6.2-py3.8.egg/aiohttp/web_server.py:53: DeprecationWarning: The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.
    await asyncio.gather(*coros, loop=self._loop)

-- Docs: https://docs.pytest.org/en/latest/warnings.html

---------- coverage: platform darwin, python 3.8.2-final-0 -----------
Coverage XML written to file coverage.xml

============================================================================= 219 passed, 1 skipped, 75 warnings in 10.94s =============================================================================
(env) $

I'm not planning to actively work on this in the short term. If someone finds a solution and shares it with us, it'd be greatly appreciated.

4.0.0.a1, python 3.9
BTW:

@dima-kov , I get "RuntimeWarning: Enable tracemalloc to get the object allocation traceback", does this confirm your point?
helpers.py workaround did not help.

aiohttp/client.py:977: RuntimeWarning: coroutine 'noop' was never awaited
  self._resp.release()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

This does not fix it:
helpers.py
old_debug = coroutines._DEBUG  # type: ignore

# prevent "coroutine noop was never awaited" warning.
coroutines._DEBUG = False  # type: ignore

async def noop(*args: Any, **kwargs: Any) -> None:
    return

coroutines._DEBUG = old_debug  # type: ignore

4.0.0.a1, python 3.9
BTW:

@dima-kov , I get "RuntimeWarning: Enable tracemalloc to get the object allocation traceback", does this confirm your point?
helpers.py workaround did not help.

aiohttp/client.py:977: RuntimeWarning: coroutine 'noop' was never awaited
  self._resp.release()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

This does not fix it:
helpers.py
old_debug = coroutines._DEBUG  # type: ignore

# prevent "coroutine noop was never awaited" warning.
coroutines._DEBUG = False  # type: ignore

async def noop(*args: Any, **kwargs: Any) -> None:
    return

coroutines._DEBUG = old_debug  # type: ignore


Ability to drop unsaved changes in file in case of conflict

In case external file is edited from outside the editor, there is no option to drop current editor changes in case of conflicts.
This is especially annoying when dealing with log files that are not in current git repository (no way to reset by git) and were edited accidentally from the editor.
Below message is shown:

Failed to save 'filename': The content of the file is newer. Please compare your version with the file contents or overwrite the content of the file with your changes.

and there are only 2 options:

override by editor change
compare (still I see no option to sync to outside changed)

and user is left without option to sync the file to it current state. Restart does not help. You cannot close this editor as well (looks like "frozen" X button does not work - a bug or feature?).
Checked with disabled extensions as well.

There is option to "discard changes" from within "compare" panel. Closing

Anyway this would be usefull to ovoid such problems: #4873


Make image scanning feature work with --enable-host-scan flag

Is your feature request related to a problem? Please describe.
It would be nice if image scanning feature could be run as follows
kubescape scan --enable-host-scan \
          --kubeconfig /mnt/config-k8s-cls-test \
          --submit \
          --account=<account_id> \
          --client-id=<client_id> \
          --secret-key=<secret_key>

Currently according the the documentation at https://hub.armosec.io/docs/configuration-of-image-vulnerabilities you have to install the kubescape helm chart in the scanner cluster in order to get image scanning to work.
If I execute the command above without installing the helm chart in the cluster I get an error
* failed to pull image scanning data: no vulnerabilities found for any of the images. for more information: https://hub.armosec.io/docs/configuration-of-image-vulnerabilities

and controls related to image vulnerabilities are skipped
...
| High     | Workloads with Critical vulnerabilities exposed to external traffic                                                       |        0         |         0          |       0       |   skipped*   |
...

No data are submitted to the Armo dashboard

Describe the solution you'd like.
I would expect this command
kubescape scan --enable-host-scan \
          --kubeconfig /mnt/config-k8s-cls-test \
          --submit \
          --account=<account_id> \
          --client-id=<client_id> \
          --secret-key=<secret_key>

to create proper kubescape deployment in the target cluster set up with given credentials so that the image scan can be performed.

@MMquant do you mean like if kubescape command could install all components as helm install would do?

@MMquant yes - if it is even possible.

We'll discuss that with @yossi77 and @dwertent to check if that makes sense, I cannot promise anything.
Thanks for the suggestion 👍

Just for posterity, this is a topic that frequently comes up.
We have brought it up previously, and the consensus was that the Kubescape CLI tool scans clusters for misconfigurations, not vulnerabilities. When you want to scan for vulnerabilities, we offer a separate set of tools — the Kubescape Helm chart, also known as the in-cluster components. Kubescape CLI does not communicate with in-cluster components, and does not submit vulnerability data to the ARMO Platform. However, the Helm chart does.

do you mean like if kubescape command could install all components as helm install would do?

yes - if it is even possible.

@MMquant
Would you expect this to happen during kubescape scan or like a separate command, as  in kubescape deploy-components && kubescape scan? Or something else?

@vladklokun It could be integrated in the scan subcommand. The user could just provide additional flag --enable-image-scan which would deploy components and perform the image scan.
Currently I'm using something like this
kubescape scan \
          --enable-host-scan \
          --enable-image-scan \
          --cluster-name "${cluster}" \
          --kubeconfig /configs/${cluster}/root/.kube/config \
          --disable-color \
          --format pretty-printer \
          --output "/kubescape/${cluster}" \
          --submit \
          --account=<account_id>

We can approach this issue in 2 ways -

Kubescape CLI will scan for misconfigurations and deploy the helm chart components for scanning the images
Kubescape CLI will scan for misconfigurations and for CVEs in images.

I think the solution here is to add in the Kubescape CLI the ability to scan images, and not deploy the helm charts.
This is in our backlog for a while now but we do not yet have an estimation of when we will develop this capability
/cc @amirkCA , @yossi77
This has been requested multiple times in the past: #598 , #287 , #668

This will be supported once we release the #1320.


allow color edit of existing maps persist for the map

Maybe add new role like pancanAtlas-edit to make permanent.
It would also be nice if dynamic color changes are saved to state and so to the bookmark.

colors now persist for users with edit ability
We still want to save dynamic color changes to state & bookmarks.


Mili Material Edge Lines

Description
Resolves #17950
Resolves #19025

We need VisIt to calculate ghost zones using global node ids. VisIt won't calculate ghost zones if there are already ghosts present. The mili plugin creates ghost zones and ghost nodes, so we determined it made sense to plumb the ghost zones and nodes created by the plugin differently. We now pass them through with different names, "avtExtraGhostZones" and "avtExtra GhostNodes". These arrays get stitched together with the newly calculated ghost arrays later in the process.

Type of change

[x] Bug fix~~
[ ] New feature
[ ] Documentation update
[ ] Other

How Has This Been Tested?

built and ran on rzhound toss4. All tests pass in serial and parallel
Reminders:

Please follow the style guidelines of this project.
Please perform a self-review of your code before submitting a PR and asking others to review it.
Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

[x] I have commented my code where applicable.~~
[x] I have updated the release notes.~~
[ ] I have made corresponding changes to the documentation.
[ ] I have added debugging support to my changes.
[x] I have added tests that prove my fix is effective or that my feature works.~~
[x] I have confirmed new and existing unit tests pass locally with my changes.~~
[x] I have added new baselines for any new tests to the repo.~~
[x] I have NOT made any changes to protocol or public interfaces in an RC branch.~~

Is a single bool that lives in avtMiliFileFormat.h sufficient to catch node ids not being read? Are there strange parallel cases that could mess us up here?

@JustinPrivitera can you elaborate here a bit on why the ghost data Mili ws providing was not sufficient?

@JustinPrivitera can you elaborate here a bit on why the ghost data Mili ws providing was not sufficient?

@markcmiller86 yes. Mili does not provide ghost data, but it does provide a variable called sand. Sand is a mask that is always either 0 or 1 that says if a particular zone was destroyed in the simulation. We mark the destroyed zones as ghosts using the sand data.
This ghost data tells us nothing about duplicated edges across domain boundaries, which is the information we need in order to hide the edge lines correctly.
We need to leverage global node ids to get VisIt to mark ghost zones appropriately to eliminate extra edge lines which can be seen in the picture in the original ticket. VisIt won't use the global node ids to make ghost zones unless the dataset already does not have ghosts.

@JustinPrivitera can you elaborate here a bit on why the ghost data Mili ws providing was not sufficient?

@markcmiller86 yes. Mili does not provide ghost data, but it does provide a variable called sand. Sand is a mask that is always either 0 or 1 that says if a particular zone was destroyed in the simulation. We mark the destroyed zones as ghosts using the sand data.
This ghost data tells us nothing about duplicated edges across domain boundaries, which is the information we need in order to hide the edge lines correctly.
We need to leverage global node ids to get VisIt to mark ghost zones appropriately to eliminate extra edge lines which can be seen in the picture in the original ticket. VisIt won't use the global node ids to make ghost zones unless the dataset already does not have ghosts.

Ok, thanks for that description. Did you by chance look at the possibility of handling Mili sand data as "missing values"? I agree they are not ghost values and so am wondering why we are allowing Mili plugin to treat them as ghost. I think we have other mechanisms in VisIt for handling "there but should be ignored" values.

Also, do we know for sure that Mili sand functionality is even essential to support in the plugin? My recollection (from long, long ago now) was that it was an experimental feature of Mili/Griz at the time and maybe a one off. Who is the right authority to say for sure that VisIt's Mili plugin must support sand variable.

Ok, thanks for that description. Did you by chance look at the possibility of handling Mili sand data as "missing values"? I agree they are not ghost values and so am wondering why we are allowing Mili plugin to treat them as ghost. I think we have other mechanisms in VisIt for handling "there but should be ignored" values.

Cyrus and I looked into providing the sand data as missing values, but ultimately determined that we should leave it as is. I don't remember the rationale as this has been a journey of 1-2 years.

Also, do we know for sure that Mili sand functionality is even essential to support in the plugin? My recollection (from long, long ago now) was that it was an experimental feature of Mili/Griz at the time and maybe a one off. Who is the right authority to say for sure that VisIt's Mili plugin must support sand variable.

This I can answer definitively, having spoken to the engineering stakeholders about this quite recently. Sand is very necessary to support and removing it will have a large impact on a minority of workflows. Not all mili problems use sand but there are a significant number that do. I spoke to them about the possibility of forcing users to use threshold to get rid of sanded out portions of the mesh and they vetoed the proposal.

BTW...if sand is defined 0/1 everywhere on the mesh, why isn't the right answer a threshold operator/expression variable that just does that?

BTW...if sand is defined 0/1 everywhere on the mesh, why isn't the right answer a threshold operator/expression variable that just does that?

Github isn't fast enough for back and forth 🙃
Like I said:

I spoke to them about the possibility of forcing users to use threshold to get rid of sanded out portions of the mesh and they vetoed the proposal.

They told me that that would be too much of a change for folks, especially when things have just worked for years. They said that any way we can keep supporting sand as we have been is much preferred to asking users to use the threshold operator.

I spoke to them about the possibility of forcing users to use threshold to get rid of sanded out portions of the mesh and they vetoed the proposal.

:confused:...hacking on our already hugely complex ghost functionality is not really apetizing for us, either. Sorry to be uncooperative. Maybe I am not the right person to review this. I think its the wrong strategy and just complicates what ghosts mean (which now raises a proliferation risk to other plugins) and how they get computed and handled in generic db. I think the right answer is to push-back on customers. "Too much of a change". Um, sorry, VisIt is a different tool than Griz. Its going to be different. You are going to have to change practices to use. It does the same things (and more) Griz does differently. Learn to use it just like you once had to learn to use Griz and stop asking VisIt to behave just like Griz. Or, use Griz and don't bother us.

I spoke to them about the possibility of forcing users to use threshold to get rid of sanded out portions of the mesh and they vetoed the proposal.

😕...hacking on our already hugely complex ghost functionality is not really apetizing for us, either. Sorry to be uncooperative. Maybe I am not the right person to review this. I think its the wrong strategy and just complicates what ghosts mean (which now raises a proliferation risk to other plugins) and how they get computed and handled in generic db. I think the right answer is to push-back on customers. "Too much of a change". Um, sorry, VisIt is a different tool than Griz. Its going to be different. You are going to have to change practices to use. It does the same things (and more) Griz does differently. Learn to use it just like you once had to learn to use Griz and stop asking VisIt to behave just like Griz. Or, use Griz and don't bother us.

There's no need to apologize. I'm inclined to agree with you. I don't like that we had to hack generic db to make this happen.
It's not my call to say whether or not we should push back (or emplace back?) on customers. In this case, this is a feature that Eric, Cyrus, and myself have spoken to the engineering stakeholders about many times over the past 2 years. Eric's initial approach to solve this involved hacking ghost logic in generic db. We tried all manner of approaches in the mili plugin itself, and more recently went back to an approach that modified generic db in a minimally invasive way. Other plugins will only be affected if they provide extra ghosts arrays, and none of them do other than mili.
@cyrush has told me that we are getting this feature in for this release. This solution was something we worked on together. We can discuss more at the meeting today if you'd like, but I think that in this case, we need to make this feature work for these users.

The current Mili implementation provides the primary mesh w/o the "sand" zones, as well as a secondary mesh that includes all the zones.
This is what the end users want -- they have been this and are mostly happy.
However, the way we are using ghost zones to do sand-based threshold this in the current implementation undermines proper ghost zone creation and breaks some things in VisIt.
We have tried several solutions over 2 years -- with restrictions on where we can do collective communication in the DB plugin vs later in Generic Database, this is a very complex problem.
VisIt can create the proper ghost zones from global node ids that are available.
We trust VisIt to do this robustly.
However, VisIt will not create any ghost zones if the plugin provides them, which we were doing to "solve" to sand issue.
The current Mili plugin does not provide complete ghost info, and we can't leverage VisIt's ghost zone comm in the plugin. It has to happen later.
Missing data is not appropriate b/c it applies to values in a specific array vs using one array to screen others (yes what we want is like a threshold).
They don't want to apply a threshold every time when we can present the mesh they are after, again they know we can b/c we have been doing that with some limitations.

Merge w/ develop in #19936


MEC1428 support

Skylake and TigerLake Intel RVP boards use the MEC1428, I dont see any mention of the MEC1428 here. I am having a heck of a time finding the source for this RVP as I need to add some additional features. Intel only provides a compiled MEC1428 EC firmware but no source.
Intel and Microchip tech support are not helping me out much at all.
Would the better move be to skip the MEC1428 chip and use the MEC1501 or MEC172x which appear to be supported with Intel source code provided in this repo.
Thanks!

Intel basic EC FW open source framework is not same source code used to generate the EC FW for Intel RVP.
The open source provided a subset of features. Refer to https://intel.github.io/ecfw-zephyr/reference/overview.html
Skylake and tigerlake didn't use Zephyr-based EC FW so there is no plan to add support for that in this project.
For any new designs intending to use this project as reference recommendation is to use MEC152x and MEC172x. Refer to https://intel.github.io/ecfw-zephyr/reference/supported_hw.html

Skylake and tigerlake didn't use Zephyr-based EC FW so there is no plan to add support for that in this project.

It looks like the MEC15xx has this config switch for TigerLake "CONFIG_MEC15XX_AIC_ON_TGL"
https://github.com/intel/ecfw-zephyr/blob/a324501d1e32a317330ad0e2922d3a7d5b3ccbf0/boards/microchip/mec15xx_mecc/mec15xx_aic_rvp_selection.h#L16
It references this file so maybe there is TigerLake support?
https://github.com/intel/ecfw-zephyr/blob/a324501d1e32a317330ad0e2922d3a7d5b3ccbf0/boards/microchip/mec15xx_mecc/tgl_mec1501.h#L4

No, ICL/TGL RVP have MEC1428 soldered down on the motherboard. There is no Intel Basic EC Open source support for that.
The files mentioned are to support TGL RVP + MEC152x MECC card setup, in such case the MEC1428 is disabled and the EC used is the one from add-on card.
https://docs.zephyrproject.org/latest/boards/arm/mec1501modular_assy6885/doc/index.html

@albertofloyd Thanks, I am trying to build a case to not use the MEC1428 and instead use the MEC15xx for our new tiger lake design.
It sounds like zephyr supports the "TGL RVP + MEC152x MECC card setup" so I think this seems like the way to go.
We have been waiting for a TGL RVP platform from Intel for a few months now and I have had not too much luck with the MECC1428 dev board in standalone mode.


[err-msg] Need to restart service reconcile

Rancher versions:
1.6.5+
Symptom:
What this message means is unclear to us. It is seen sometimes when finising an upgrade, but possibly other times as well.
Expected behavior:
This message needs to indicate better it's meaning. We can't advise on what it should say because we don't understand what it means.

https://github.com/rancher/cattle/blob/v0.183.45/code/iaas/service-discovery/server/src/main/java/io/cattle/platform/servicediscovery/deployment/ServiceDeploymentPlanner.java#L168
There are multiple reasons which qualify for service reconcile. Instead of just returning True/False, may be we can associate a message for each condition and return which can then be shown in the error message in UI.

After further investigation, the above messages are already displayed in the Service log. Will update the error message to : reconciling service state

Tested with latest build fro master:
Created a service with invalid entry point do that containers get to "stopped" state as soon as they get to "running" state , which results in constant attempt to restart containers that would keep failing.
Upgrading / rolling back this service , would now result in the following error message presented to the user:


Accumulation allure-results

I run tests through Visual Studio more than once, but each test suite is separate. In this regard, the results of the allure are deleted and new ones begin to be created. But I want to keep the old ones, but there is no opportunity to accumulate these results. Is there any way to fix this?

NUnit: 3.12.0
Allure: 2.6.2

@cerebellum13
For local history of test runs, you can use the setting in the config allure.allowLocalHistoryTrend

@Noksa
But, it doesn't work for me. Still continues to delete.

@cerebellum13
My mistake - i mixed up the history with the trend.
Currently, the local launches history is not implemented and is not planned, because the CI server does this.

Very sorry of course, have to make crutches = (


How to customize query for sorting models

I use plugin with belongsToMany and I want to get models ordering by createdAt
 Multiselect::make('Tags', 'latestTags')                 ->belongsToMany(\App\Nova\Tag::class, true)
I made such query in my model, but it gives me no effect
public function latestTags()     {         return $this->tags()->orderBy('id', 'DESC');     }
How to implement sorting?

You have to create your own endpoint and use the ->api() function.

Just a tip, what you also could do is use dependsOn to fetch the options from the database, like this:
`Multiselect::make('Market', 'market')
->indexCharDisplayLimit(100)
->required()
->belongsToMany(Market::class, false)
->placeholder(' ')
// depend on a non-existing field, we simply need to load the items with an orderBy, regular ->options does not work
->dependsOn('non-existing-field', function (Multiselect $field, NovaRequest $request, FormData $formData) {
$options = \App\Models\Market::withoutTrashed()->orderBy('title')->pluck('title', 'id');
                $field->options($options);
            }),`

using ->options doesnt seem to work, so just use dependsOn with a fake field. Works fine!


add find button only in subtraction of any no. sys

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
i wud like to work on this

@sairish2001 closing this issue as this feature is already there


Fix broken SVG links pointing to another sample

Q
A

Bug fix?
Yes

What's in this Pull Request?

SVG icons were pointing to another sample and only one of them was working. This PR has the links fixed to display the 3 images

thx @joaoferreira, appreciated.


Rounding errors during interval count

Hi,
I've found that in some cases the emitted value has got a lot of decimals. I suggest that in the directive where the emit is done the value should be rounded closest integer while counting. In the end of the count the directive can pass _this._countTo as intended with or without decimals.
What do you think?

I will take a look on that. You can create PR if you want to speed up things.

You should handle rounding with pipes or custom methods.