bump version to 0.13.0 and update CHANGELOG

@ethagnawl @adamstrickland This diff looks straight forward to me. Looking forward to seeing the new version available via rubygems.org. :wink:


Web - Error is shown when clicking link icon in paypay.me

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click settings
Click wallet
Click Add payment method
Click paypal.me
Click 'supported currency' text and observe there is no error
Click the icon next to 'supported currency'

Expected Result:
No error should be showed since the icon leads to the same page as the 'supported currency' text
Actual Result:
It does the same job as the 'supported currency' text but shows error
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
error in paypal.me icon.webm
https://github.com/Expensify/App/assets/93399543/ea741a86-8001-4cee-8973-bb6f3effc969
Expensify/Expensify Issue URL:
Issue reported by: @kassahun-asefa
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693037403105089
View all open jobs on GitHub

Proposal by: @kassahun-asefa
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693037403105089
Proposal
Please re-state the problem that we are trying to solve in this issue.
Clicking on the NewWindow icon throws an error
What is the root cause of that problem?
The icon is supposed to be part of the TextLink but it is not in actuality
What changes do you think we should make in order to solve the problem?
The NewWindow icon should be a child of TextLink, and sit beside the text (supportedCurrencies)
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Clicking the icon besides supporting currencies link triggers the validation and causes an error if the text field is empty.
What is the root cause of that problem?
The RC of the problem lies in the structure of the JSX code here (can also be seen below) as the Icon is in a separate View tag and not part of the TextLink and as a result it triggers the validation.
 <View style={[styles.flexRow, styles.cursorPointer]}>
                            <TextLink
                                // eslint-disable-next-line max-len
                                href="https://developer.paypal.com/docs/reports/reference/paypal-supported-currencies"
                                style={[styles.textMicro]}
                            >
                                {props.translate('addPayPalMePage.supportedCurrencies')}
                            </TextLink>
                            <View style={[styles.ml1]}>
                                <Icon
                                    src={Expensicons.NewWindow}
                                    height={variables.iconSizeExtraSmall}
                                    width={variables.iconSizeExtraSmall}
                                />
                            </View>

What changes do you think we should make in order to solve the problem?
We can move the Icon inside the TextLink, however after doing that I noticed that the link text and icon were misaligned from the rest of the text so we need to apply a few styles i.e styles.dFlex,styles.alignItemsCenter to the TextLink and {paddingBottom: 2} to the Icon.After applying these styles the final code looks like this:

                      <View style={[styles.flexRow, styles.cursorPointer]}>
                            <TextLink
                                // eslint-disable-next-line max-len
                                href="https://developer.paypal.com/docs/reports/reference/paypal-supported-currencies"
                                style={[styles.textMicro,styles.dFlex,styles.alignItemsCenter]}
                            >
                                {props.translate('addPayPalMePage.supportedCurrencies')}
                                    <Icon additionalStyles={[styles.ml1,{paddingBottom: 2} ]}
                                        src={Expensicons.NewWindow}
                                        height={variables.iconSizeExtraSmall}
                                        width={variables.iconSizeExtraSmall}
                                    />
                            </TextLink>
                        </View>

This results in the same UI as before and fixes the bug.We can create a custom style for the Icon in styles.js like below and use it to keep code clean.
    payPalSupportedCurrenciesIcon: {
        marginLeft: 4,
        paddingBottom: 2
    },

What alternative solutions did you explore? (Optional)
N/A
Result:

Can't reproduce this one.

Bump @muttmuure to check this again as it is reproducible on STG consistently.


Support rake 11.x for rspec-core 2.99

This is the same fixes with https://github.com/rspec/rspec-core/pull/2197 for 2-99-maintenance  branch.

@tricknotes is there a reason you can't just upgrade to RSpec 3.4?  RSpec 2.99 is meant only to be a stepping stone to help users upgrade to RSpec 3 and is not intended to be a version users stick around on.  What you have here looks OK but there are travis build issues (unsurprising, given how long it's been since we've done anything on this branch) and we generally aren't OK releasing software that doesn't pass its travis build.  We also don't have the time to spend to figure out how to fix it.
If you are going to stick around on RSpec 2.99 (a release that's nearly 2 years old) why do you need to be on rake 11 (which just came out today)?

@tricknotes we don't support older releases of RSpec; and as @myronmarston notes this release was intended as an upgrade step to 3.x, if you can't upgrade RSpec for some reason you probably shouldn't upgrade Rake either.


Regarding the problem that the Configuration method returns an empty object

What happened?
I have a test autho well-known url https://dev-nlrbn2g36fhj2yma.us.auth0.com/ which can normally access metadata through the browser. Now I am using version 6.1.4 of openid-client discovery using the discovery method which returns an empty object configuration

I have provided screenshots of the code running results in order. Is this the expected behavior?
Version
6.1.4
Runtime
Browser
Runtime Details
nodejs 23.2..0  chrome latest  os： win11 24h2
Code to reproduce
See screenshot I only added part of the print in the build code

Required

[X] I have searched the issues tracker and discussions for similar topics and couldn't find anything related.
[X] I agree to follow this project's Code of Conduct

It's not empty, it's just that its properties are intentionally hidden away.


Add a feed-forward term

The total control signal (PID + feed-forward) is to be limited by the
integral anti-windup.

I would like to use DiscretePID.jl with a feed-forward contribution: sometimes the sum of the two control inputs (PID and feed-forward) exceeds the actuator range.

I didn't expected such a fast review and positive feedback (no pun intendend).

No worries, I can squash in the web interface! :)

Oh, I didn't know one could do that!

Thanks for the PR! I will update an unrelated thing that caused tets to fail and then have a new release out ASAP :)


opt.compute_gradients() returns values different from the weight difference of opt.apply_gradients()

This isn't a bug, bug I wasn't sure where to ask for help on this one, so I'm sorry to just throw in another issue here on github.  I've tried searching, but haven't found answers to my questions yet.
My question is what is the most efficient way to get the delta of my weights when training?  I assume it's related to gradients, but the optimizer (I think) does a lot more than just apply the raw gradients returned from opt.compute_gradients().
Where I'm at: I've got the operators hooked up as follows (thanks to this SO question):

self.cost = `the rest of the network`
self.rmsprop = tf.train.RMSPropOptimizer(lr,rms_decay,0.0,rms_eps)
self.comp_grads = self.rmsprop.compute_gradients(self.cost)
self.grad_placeholder = [(tf.placeholder("float", shape=grad[1].get_shape(), name="grad_placeholder"), grad[1]) for grad in self.comp_grads]
self.apply_grads = self.rmsprop.apply_gradients(self.grad_placeholder)

Now, to feed in information, I run the following:

feed_dict = `training variables`
start_weights = self.sess.run([self.w1,self.b1, etc])
grad_vals = self.sess.run([grad[0] for grad in self.comp_grads], feed_dict=feed_dict)

feed_dict2 = `feed_dict plus gradient values added to self.grad_placeholder`
self.sess.run(self.apply_grads, feed_dict=feed_dict2) # Updates the weights
end_weights = self.sess.run([self.w1,self.b1, etc])
delta_weights = [end_weights[i]-start_weights[i] for i in range(len(start_weights))]
# Note: delta_weights != grad_vals...

The command of run(self.apply_grads) will update the network weights, but when I compute the differences in the starting and ending weights (run(self.w1)), those numbers are different than what is stored in grad_vals[0].  I figure this is because the RMSPropOptimizer does more to the raw gradients, but I'm not sure what, or where to find out what it does.  I could go to the paper and write it myself, but I don't want to hardcode things in like that where TF already does it somewhere else.  I'll admit I'm still new to TF, but I tried to figure out what happens by looking at the source, but it's still confusing for me.
So back to the question: Is there a way to get the delta's for the weights in a more efficient way than calculating the difference?  Am I stuck running self.w1.eval(sess) multiple times to get the weights and calculate the difference?  Is there something that I'm missing with the tf.RMSPropOptimizer (or any other Optimizer for that matter) function that I haven't seen or heard about
Thanks!  And sorry again for adding to the issues list.

Tensorflow has the code calculates the difference in tensorflow/core/kernels/training_ops.cc, look at it.
Additionally, I see that there are no python interfaces for it now.

Thanks for the pointer @qbx2, I'll look there and come back if I have any problems still.


[ktx] update to v4.3.0-beta1

Library name
ktx
New version number
v4.3.0-beta1
Other information that may be useful (release notes, etc...)
Upstream fixed https://github.com/microsoft/vcpkg/issues/33687
We can test and close it after port update
When testing please install ktx[core,tools]:x64-uwp

We should update the release version instead of the beta version, right?

We should update the release version instead of the beta version, right?

Well at this moment it is alpha I guess won't be worse if it would be beta
also, it seems the upstream only releases alpha/beta for a long time but better check

Well at this moment in vcpkg it is alpha I guess won't be worse if it would be beta
also, it seems the upstream only releases alpha/beta for a long time but better check

Okay, if the upstream always releases a beta version, then I will update it according to the released version.


cmd: verify if the URL List config value is required

What
This PR fixes the SetConfigOptionURLList adding a check if the config value is empty.
Why
It was returning errors even if it wasn't a required value.
Known limitations
N/A
Checklist
PR Structure

[x] This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR title and description are clear enough for anyone to review it.
[x] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

[x] This PR adds tests for the new functionality or fixes.
[ ] This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

[x] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[x] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[x] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[x] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

[x] This is not a breaking change.
[x] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

[ ] Does the deployment work after merging?

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr135.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr135.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr135.previews.kube001.services.stellar-ops.com


Angular user interface for python script

Description
New web user interface using Angular 14 framework and Python EEL
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] New enhancement (non-breaking change which adds small functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update
[x] This change requires a build update
[x] This change requires a configuration update

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings or errors
[x] Any dependent changes have been merged and published in downstream modules

one-man dev


[Bug]: An error occurred attempting to use chrome headless shell in puppeteer: Invalid file descriptor to ICU data received

Minimal, reproducible example
import puppeteer from "puppeteer-core"

(async () => {
    await puppeteer.launch({
        headless: true,
        executablePath: "./chrome-headless-shell/win64-118.0.5993.18/chrome-headless-shell-win64/chrome-headless-shell.exe",
    });
})()
    .catch(err => console.error(err));

Error string
Error: Failed to launch the browser process! [0926/130444.910:ERROR:icu_util.cc(240)] Invalid file descriptor to ICU data received.   TROUBLESHOOTING: https://pptr.dev/troubleshooting
Bug behavior

[ ] Flaky
[ ] PDF

Background
From: https://googlechromelabs.github.io/chrome-for-testing/
Expectation
Normal launch.
Reality
Error: Failed to launch the browser process! [0926/130444.910:ERROR:icu_util.cc(240)] Invalid file descriptor to ICU data received.   TROUBLESHOOTING: https://pptr.dev/troubleshooting
Puppeteer configuration file (if used)
No response
Puppeteer version
21.1.1
Node version
18.16.1
Package manager
npm
Package manager version
9.5.1
Operating system
Windows

It does not look an issue with Puppeteer: could you raise the issue via crbug.com (headless component)?


Marking that a C++ compiler is required to build

On some linux distributions a C++ compiler is not installed by default. This can frustrate some new users.

Coverage remained the same at 71.601% when pulling 63268318ed26469afe9a31898941767a8e284367 on peterbaumgarten:master into a28d9f145642e8ac97333327d4f409e1efb11077 on sourcelair:master.


RTC blacklist permanent & fix wake black screen

Make RTC blacklist more permanent & fix black screen after wake from hibernation

Also you can update latest nvmefixup kext i checked its working fine


Pop-up selecters not popping up

Describe the bug
When I am in Collection Object to-do, and I try to assign a depiction to another object, the pop-up collection object selector does not appear.
To Reproduce
Steps to reproduce the behavior:

When I am in Collection Object to-do, and I am transcribing a depiction.
Then I see that the identifier is already taken, so I want to move that depiction to another CO.
And I use the radial annotator to select that depiction, edit it, and go to select the appropriate CO.
And I type in the identifier.
Then I do not see the pop-up box for the identifier, except maybe behind the CO annotator window.

Note window popping up behind radial annotator window at the very bottom (just visible):

Expected behavior
Pop-up should appear for me to select Collection Object.
Environment (please identify where you experience this bug:
*** One of ***

Production
Firefox
Windows 10

Could not replicate on Google Chrome or Firefox on Mac OS.
See video sent in Gitter.

@tmcelrath where did you use the radial annotator? which task?

"TODO"/Transcribe depiction.


HBASE-24562: Stabilize master startup with meta replicas enabled

This is related to HBASE-21624 .
I created a separate ticket because in the original one a "complete solution for meta replicas" was requested and this is not one. I'm just trying to make master startup more stable by making assigning meta replicas asynchronous and preventing a potential assignment failure from crashing master.
The idea is that starting master with less or even no meta replicas assigned is preferable to not having a running master.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m  6s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 28s
the patch passed

+1 :green_heart:
compile
1m 10s
the patch passed

+1 :green_heart:
javac
1m 10s
the patch passed

+1 :green_heart:
shadedjars
6m 15s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
189m 25s
hbase-server in the patch passed.

223m 31s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1903

JIRA Issue
HBASE-24562

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 381ad010a11f 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2ecbaf130e

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/1/testReport/

Max. process+thread count
3286 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m  8s
master passed

+1 :green_heart:
compile
0m 56s
master passed

+1 :green_heart:
shadedjars
6m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 45s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

+1 :green_heart:
shadedjars
5m 59s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
198m 35s
hbase-server in the patch passed.

224m 31s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1903

JIRA Issue
HBASE-24562

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d4b445ce22c6 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2ecbaf130e

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/1/testReport/

Max. process+thread count
2886 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 47s
the patch passed

+1 :green_heart:
compile
1m 17s
the patch passed

+1 :green_heart:
javac
1m 17s
the patch passed

+1 :green_heart:
shadedjars
6m 45s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 51s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
219m 13s
hbase-server in the patch passed.

250m  4s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1903

JIRA Issue
HBASE-24562

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux aea6c5a33454 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 510aad3125

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/2/testReport/

Max. process+thread count
2887 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m  7s
master passed

+1 :green_heart:
compile
0m 58s
master passed

+1 :green_heart:
shadedjars
6m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 57s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
shadedjars
6m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

-1 :x:
unit
232m  9s
hbase-server in the patch failed.

259m 12s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1903

JIRA Issue
HBASE-24562

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 100d7dc7025f 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 510aad3125

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/2/testReport/

Max. process+thread count
2581 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@huaxiangsun About your last question. Well, yes, the test is not obvious. If you check the code you can see that setting a Procedure on the master replica node just before we would call assignAsync would make preTransitCheck fail and throw an HBaseIOException. I would have preferred something more direct, but finishActiveMasterInitialization is a monster method and couldn't find a nice way to show what's happening. I was considering reading the logs to verify an exception was logged, but that felt like an overkill.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 47s
master passed

+1 :green_heart:
checkstyle
1m 17s
master passed

+1 :green_heart:
spotbugs
2m  5s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 42s
the patch passed

-0 :warning:
checkstyle
1m 12s
hbase-server: The patch generated 5 new + 110 unchanged - 0 fixed = 115 total (was 110)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 16s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

35m 32s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1903

JIRA Issue
HBASE-24562

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux c32c6db1e880 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bd79c4065c

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 48s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 35s
master passed

+1 :green_heart:
compile
1m  6s
master passed

+1 :green_heart:
shadedjars
7m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 41s
the patch passed

+1 :green_heart:
compile
1m 18s
the patch passed

+1 :green_heart:
javac
1m 18s
the patch passed

+1 :green_heart:
shadedjars
7m  9s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 45s
hbase-server generated 2 new + 26 unchanged - 0 fixed = 28 total (was 26)

_ Other Tests _

-1 :x:
unit
225m 40s
hbase-server in the patch failed.

256m 48s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1903

JIRA Issue
HBASE-24562

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e953dd5d1810 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bd79c4065c

Default Java
1.8.0_232

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/3/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/3/testReport/

Max. process+thread count
3600 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 47s
the patch passed

+1 :green_heart:
compile
1m 13s
the patch passed

+1 :green_heart:
javac
1m 13s
the patch passed

+1 :green_heart:
shadedjars
6m 42s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 49s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
221m 24s
hbase-server in the patch passed.

252m 20s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1903

JIRA Issue
HBASE-24562

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 06e505436c79 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 537a3caccd

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/4/testReport/

Max. process+thread count
3142 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 39s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 19s
master passed

+1 :green_heart:
compile
1m  1s
master passed

+1 :green_heart:
shadedjars
6m 14s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  3s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
6m 15s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 38s
hbase-server generated 2 new + 26 unchanged - 0 fixed = 28 total (was 26)

_ Other Tests _

+1 :green_heart:
unit
234m 43s
hbase-server in the patch passed.

262m 19s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1903

JIRA Issue
HBASE-24562

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d06dd3ae6cde 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 537a3caccd

Default Java
1.8.0_232

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/4/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/4/testReport/

Max. process+thread count
3049 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@huaxiangsun Made the last change requested. Thanks a lot for your feedback!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 46s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

+1 :green_heart:
shadedjars
6m 49s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 49s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
220m 19s
hbase-server in the patch passed.

251m 11s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1903

JIRA Issue
HBASE-24562

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux abb15ee4aba6 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 537a3caccd

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/testReport/

Max. process+thread count
3118 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 15s
master passed

+1 :green_heart:
compile
1m  2s
master passed

+1 :green_heart:
shadedjars
6m 12s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 55s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
6m  9s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 37s
hbase-server generated 2 new + 26 unchanged - 0 fixed = 28 total (was 26)

_ Other Tests _

+1 :green_heart:
unit
234m 46s
hbase-server in the patch passed.

262m  2s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1903

JIRA Issue
HBASE-24562

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ff9e1443d53a 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 537a3caccd

Default Java
1.8.0_232

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/testReport/

Max. process+thread count
2917 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Next time please fix the checkstyle issues before merging? We do not count checkstyle as -1 only because sometimes it is a bit hard to fix all the problems and also sometimes the violations are not introduced by the patch. But here the checkstyle issues are introduced by the PR...
And please do not comment out a line of code? Just remove it. I see this in patch
  public static class BrokenTransitRegionStateProcedure extends TransitRegionStateProcedure {
    protected BrokenTransitRegionStateProcedure() {
      //super(env, hri, assignCandidate, forceNewPlan, type);
      super(null, null, null, false,TransitionType.ASSIGN);
    }
  }


Role selector

All functional parts are complete and seem to be in order, user-facing strings and embeds might need to be adjusted.


CAPM3 (capm3-system namespace pods) should not be running among workloads

What steps did you take and what happened:
As discussed in metal3-sec group related to https://github.com/metal3-io/baremetal-operator/pull/1241 CAPM3/IPAM (capm3-system namespace) should not be running among user workloads, but with k8s controlplane or infra nodes.
What did you expect to happen:
CAPM3/IPAM (capm3-system) is running on controlplane or in infra nodes, not among regular workload. These should be sensible default value, and documentation should be available to explain the options.
Environment:

CAPM3 version: any/latest
Environment (metal3-dev-env or other): any

/kind bug
/kind documentation
/assign @lentzi90

/triage accepted
/help

Would be welcomed I will move this to frozen, no need to always remove the stale
/lifecycle frozen


_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ branch-3 Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for branch

+1 :green_heart:
spotless
1m  4s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  7s

Maven dependency ordering for patch

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
spotless
0m 54s

patch has no errors when running spotless:check.

_ Other Tests _

+0 :ok:
asflicense
0m  0s

ASF License check generated no output?

4m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6441/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6441

Optional Tests
dupname asflicense codespell detsecrets shellcheck shelldocs spotless

uname
Linux 32a07d3415e0 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 /<PHONE_NUMBER>8319ad4733b04c9db79340411c8074

Max. process+thread count
47 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6441/1/console

versions
git=2.34.1 maven=3.9.8 shellcheck=0.8.0

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


How to set the size of tab in CodeArea?

According to https://bugs.openjdk.org/browse/JDK-8233810 JavaFX 14 supports -fx-tab-size property. I use javafx-19-ea+3. As I understand from https://github.com/FXMisc/RichTextFX/issues/86#issuecomment-58573872 CodeArea internally uses TextFlow. So,  -fx-tab-size must be supported. This is my code:
   Java
    this.textArea = new CodeArea();
    this.textArea.getStyleClass().add("xml-text-area");
    final var highlighter = new XmlHighlighter();
    textArea.textProperty().addListener((obs, oldText, newText) -> {
        textArea.setStyleSpans(0, highlighter.computeHighlighting(newText));
    });
    textArea.setEditable(true);
    textArea.setParagraphGraphicFactory(LineNumberFactory.get(textArea));
    textArea.setPadding(new Insets(0, 0, 0, 0));
    textArea.getUndoManager().atMarkedPositionProperty().addListener((ov, t, t1) -> {
        viewModel.doOnTextAreaModified(!t1);
    });

  CSS
  .xml-text-area {
        -fx-tab-size: 10;
  }

However, when I load files with tabs I don't see that my code works. Could anyone say how to fix it?
PS What I want is to set tab size in view, so I could to control the tab size when I render files with tabs.

Try the following CSS instead:
.xml-text-area .paragraph-text {
    -fx-tab-size: 10;
}


Filled and outlined do not work with FormControl

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
Filled and outlined should work like it works on TextField with FormControl. FormControl api specifies that this prop should work.
Current Behavior
It doesn't. Codesandbox link below explains it pretty well.
Steps to Reproduce
https://codesandbox.io/s/nwl42ym41p
Your Environment

Tech
Version

Material-UI
v3.1.0

There is a FilledInput and OutlinedInput for this use case. We should update the demos in the documentation.


MODFISTO-269. Allow user to base encumbrance on "Initial encumbrance" during rollover

Updated tests for support MODFISTO-269 and  MODORDERS-599

Test on testing:
Re-encumber logic

Ledger rollover:


Cannot read property 'chart' of undefined

Expected Behavior

Chart dataset visibility is toggled when using the defaultLegendClickHandler = Chart.defaults.legend.onClick
Current Behavior

Throws  Uncaught TypeError: Cannot read property 'chart' of undefined
Possible Solution

Steps to Reproduce (for bugs)

Follow code example from https://www.chartjs.org/docs/master/configuration/legend
https://jsfiddle.net/j9ucfm6e/
Environment

Chart.js version: https://cdnjs.cloudflare.com/ajax/libs/Chart.js/3.0.0-alpha/Chart.js
Browser name and version: Chrome Version 83.0.4103.97

This is already fixed on master. https://jsfiddle.net/m92aqh0j/


SQLITE_ERROR: no such column: author_id

I've run a ghost:4 container for a long time, though I haven't looked at my blog for a couple of years.
Today I spinned up the container again, and I was met with the "We'll be right back. We're busy updating our site to give you the best experience, and will be back soon." page.
I looked at the logs, and I get:
[2023-07-02 15:53:24] ERROR Unhandled rejection: select `id`, `uuid`, `slug`, `comment_id`, `feature_image`,
`featured`, `type`, `visibility`, `email_recipient_filter`, `author_id`, `created_at`, `created_by`, `updated_at`,
`updated_by`, `published_at`, `published_by`, `canonical_url`, `newsletter_id`
from `posts` where (`posts`.`status` = 'published' and `posts`.`type` = 'post') limit 999
- SQLITE_ERROR: no such column: author_id

Now, starting from the fact that I dunno how this is possible (I assume since I am explicitely on ghost:4 there should have been some breaking changes) , I seem to understand that it's having an issue with the table posts, not finding the column author_id.
In my current database, author_id lives inside the table posts_authors, and I can clearly see it's there and correctly mapped to the posts.
I recreated the container, and sadly I still get the same error.
My compose:
ghost:
    container_name: ghost
    image: ghost:4
    volumes:
      - ${DOCKER_PATH}/ghost:/var/lib/ghost/content
    environment:
      - url=${GHOST_URL}
      - TZ=${TZ}
    ports:
      - 2368:2368
    restart: always

EDIT: I took a look and indeed, there was no author_id column, but the author id is inside created_by. I tried creating the column manually with ALTER TABLE posts ADD author_id; and that made Ghost happy.


Removing confusing installation language in README.md

Removed unnecessary mention of the rc version of the @apollo/client package. This should remove confusion around which version should be installed. See https://github.com/apollographql/apollo-client-nextjs/releases/tag/v.0.8.0

@spenweb: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Good catch, thank you! :)


syslinux: fixup build with gcc14

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Arch has a fix: https://gitlab.archlinux.org/archlinux/packaging/packages/syslinux/-/blob/main/0027-use-correct-type-for-size.patch?ref_type=heads


PyDataset of exactly correct size breaks when used in conjunction with exactly correct validation_steps

See title. For instance, creating a PyDataset of size batch_size * num_batches and then running model.fit(..., validation_data=dataset, batch_size=batch_size, validation_steps=num_batches) breaks because no val_logs are created in model.evaluate() (the value is None, which raises an error the validation loop of model.fit() where it is assumed to be a dict).
Minimal Example for torch backend:
import os
os.environ["KERAS_BACKEND"] = "torch"

import keras

class MyModel(keras.Model):
    def __init__(self, **kwargs):
        super().__init__(**kwargs)
        self.dense = keras.layers.Dense(10)

    def call(self, x):
        return self.dense(x)

class MyDataset(keras.utils.PyDataset):
    def __init__(self, batches, batch_size, **kwargs):
        super().__init__(**kwargs)
        self.batches = batches
        self.batch_size = batch_size

        self.x = keras.random.normal((self.batches * self.batch_size, 2))
        self.y = keras.random.normal((self.batches * self.batch_size, 10))

    def __len__(self):
        return self.batches

    def __getitem__(self, item):
        start = item * self.batch_size
        stop = start + self.batch_size
        item = slice(start, stop)

        return self.x[item], self.y[item]

def test_validation_steps():
    model = MyModel()
    batches = 4
    batch_size = 4
    train_data = MyDataset(batches=batches, batch_size=batch_size)
    validation_data = MyDataset(batches=batches, batch_size=batch_size)

    model.compile(optimizer="AdamW", loss="mse")

    # works fine
    model.fit(train_data, epochs=2, validation_data=validation_data, steps_per_epoch=batches)

    # works fine
    model.fit(train_data, epochs=2, validation_data=validation_data, steps_per_epoch=batches, validation_steps=batches - 1)

    # doesn't work
    model.fit(train_data, epochs=2, validation_data=validation_data, steps_per_epoch=batches, validation_steps=batches)

This workaround makes the code run, but incorrectly displays zero loss:
class MyModel:
    ...
    def evaluate(self, *args, **kwargs):
        val_logs = super().evaluate(*args, **kwargs)

        if val_logs is None:
            val_logs = {}

        return val_logs

When you are using steps_per_epoch or validation_steps, you keep drawing from the same generator across different epochs. At epoch 2, you have no data since you already consumed all the data during epoch 1, hence the failure.
Two options for you would be:

Don't pass validation_steps if you want to use a new generator at every epoch.
Modify your generator so that it can return steps * epochs batches instead, and pass an exact validation_steps value.


Williams2020

Pull Request
This PR is for a

[x] New Publication(s)
[ ] Correction

For the following list(s):

[ ] ancientmetagenome-anthropogenic (README)
[ ] ancientmetagenome-environmental (README, ask @thedir-team-dirt for advice)
[ ] ancientmetagenome-hostassociated (README, ask @thedir-team-bugparty for advice)
[x] ancientsinglegenome-hostassociated (README, ask @thedir-team-pathopeeps for advice)

New Publication
Publication Information
This pull request is to add samples from the following publication(s): Williams 2020, https://europepmc.org/article/pmc/pmc7585846
This is to close #326
Checklist

[x] Publication is published (preprints currently not accepted)?
[x] Checked the publication is not already in the database?
[x] Checked samples in this publication are not previously published data (newly re-sequenced metagenomes are OK!)?
[x] Samples are shotgun metagenomes (hostassociated-singlegenome may also contain whole-genome enriched data)?
[x] Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
[x] Changelog is updated to include the publication under 'Added'?
[ ] Pull request has passed validation checks (see automated comment from github-bot)?
[ ] Review requested from corresponding team (see list of lists above for each team)?
[x] (If applicable) Made a separate PR to add new categories to controlled lists (stored under /assets/enums, e.g. material or archive)? If so the corresponding PR is here: #333

If you do not know how to check errors in failed validation checks, expand here

Correction
This PR is for

[ ] ancientmetagenome-hostassociated
[ ] ancientsinglegenome-hostassociated
[ ] ancientmetagenome-environmental
[ ] ancientmetagenome-anthropogenic

Reference
This pull request is to correct samples from the following publication(s):
This is to close
Description
The issue is:

Checklist

[ ] Checked the corrected entries follow conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)
[ ] Changelog is updated to include the publication under 'Changed'?
[ ] Pull request has passed validation checks (see automated comment from github-bot)?
[ ] Review requested from corresponding team (see list of lists above for each team)?

confirming that the NMNH in question is indeed Washington DC!

Sorry for the commit mess from formatting mistakes from myself :sweat_smile: thank you very much @shreyaramachandran !
The data_type error was my mistake, was too optimisitc that I memorised all the categories correctly ;)


artificial intelligent view 8.46

https://github.com/suleram/View8/tree/main

Closing as not actionable.


Account Page - Settle button not Required on All Tab

Account Page - Settle button not Required on All Tab

Some of the Transactions are already settled on All Transaction tab, so its confusing for user that some are settled and some can not be Settled,
so Removing "Settle" Button from All Tab, "Settle" Button will be Available only in Open Transaction to remove confusion
This is also needed to stop confusion with Email/ Send Notification functionality


Loading bar doesn't stop for the individual searches

Fixed https://github.com/smith-chem-wisc/MetaMorpheus/pull/325


Feature request:bulk users

Thanks for the good projects
It's configs work on every single isp in my country Iran
Would be good if I could create many users at once

You can use user.sh script to automate user creation.
Here's an example for creating "User 1" to "User 10":
sudo bash
cd /root/libertea
for i in $(seq 1 10); do ./user.sh add "User $i"; done

You can edit the start and end index in the seq 1 10 part of the script.


Windows installer select destination folder does not shown on already cli installed system

Command
Download latest Windows x64 installer
What occurred
Select destination folder does not shown on system where cli is already installed
What you expected to occur
Select destination folder should be always shown on installing cli
CLI Version
cf version 6.29.0+ff886fa.2017-07-24
CC API Endpoint Version
api endpoint:   https://api.run.pivotal.io
api version:    2.89.0
CF Trace
Platform & Shell Details
Windows 10 Eng 64-bit
Any other relevant information
Steps for reproduce:

Download latest Windows cli installer
Install cli to default or desired folder (Select destination folder appears)
Ensure cli -v is working
Run cli installer again (Case when you want upgrade old cli version with new one)
Installer automatically installs cli to C:\Program Files\Cloud Foundry folder without asking destination folder (Select destination folder does not appear)

Hi @ibakirov
The idea of an update install (which is what you get when the installer detects an existing cf CLI (there is a registry setting it checks) is that it updates the CLI in place.
If you want to change the installation folder, please uninstall and then run the installer.
Regards,
Dies Koper
CF CLI PM

@dkoper
I understand the idea, but whenever you install cli for example to D:\apps\cli and then you when you try to install again, installer won't detect installed path and installs automatically C:\Program Files\Cloud Foundry
I think there might something wrong with detection and you got two different installations of cli.

ah sorry, I misunderstood. I could reproduce the issue - we'll investigate. Thanks for the report!

Hi @ibakirov thanks, sorry this issue has been unresolved for so long. We are going to try to reproduce this first and will provide an update soon. Thanks.

Hey @ibakirov, @a-b and I were able to reproduce this issue on a Windows 10 machine, using the current CF installer (6.47.2) for 64 bit Windows, the installer detects somehow if you ran it before, and installs Program Files regardless of where you put the original installation, would it make sense for it to just always prompt for a install location?

@JenGoldstrich I agree, to always prompt for a installation location.

Hi @ibakirov
You can download an "edge" installer with this fix from:
32-bit
64-bit
This doesn't support changing the destination directory on subsequent installs; you'll still need to uninstall the package to do that.
We'll appreciate if you could test this out and let us know the results.
Thanks,
Eric Promislow and @acrmp

@ericpromislow thanks!
Tested 64-bit version, on fresh install it prompts for installation directory and on upgrade/reinstall installer automatically finds previous installation directory.


ansible 2.10 fails to parse existing playbook

Describe the bug
It seems somehow the 2.10 package has regressed and stopped to parse an existing playbook. Reverting back to 2.9 "fixes" the issue.
Error
ERROR! couldn't resolve module/action 'authorized_key'. This often indicates a misspelling, missing collection, or incorrect module path.

The error appears to be in '/home/otavio/src/yocto-aws-ec2-provisioning/provisioners/ansible/playbook.yml': line 9, column 7, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

    - name: set authorized keys for "ubuntu" user
      ^ here

Maintainers

@joamaki
@costrouc
@hexa

AFAIU this is not a packaging bug. See https://docs.ansible.com/ansible/2.10/collections/ansible/posix/authorized_key_module.html vs https://docs.ansible.com/ansible/2.9/collections/ansible/posix/authorized_key_module.html, in 2.10 you seem to have to use ansible.posix.authorized_key. Ansible 2.9 appears still supported, so it's fine to keep it in the package set, so I don't see anything to do here.

Indeed @Ma27; this solved the issue. I upgraded to use the schema of the new collection, and it worked just fine. Thanks for the help.


Add the vectorized matmul

This PR implements the vectorized matmul.
FYI. There is no improvement or decrease in performance on m2 pro.

LGTM, will try it on the M1 max, thanks!


(Crash) Setting property in class constructor to a property

This causes an instant crash (in Framer authoring environment):
class test
	constructor: ->
		@a = @

Not saying you want to do this. Just saying.

Thanks for reporting!
This has since been fixed. And works in the latest stable of Framer


Option to include the aspnet core healthcheck apis into the swagger?

Microsoft offered the possibility to have Healthcheck endpoints directly in the startup > https://docs.microsoft.com/de-de/aspnet/core/host-and-deploy/health-checks?view=aspnetcore-2.2
If we want to include this Healthcheck APIs in the generated swagger is there a way with NSwag to achieve this?

If they are exposed by the aspnetcore api explorer then you should just see them, otherwise it would require some manual code, eg an additional document processor which looks them up and adds them as new operations

Tested with NSWag Studio and ASP.NET Core via API Explorer and it seems the healthcheck routes defined in the startup are not exposed via aspnetcore api explorer.

So this is only a single operation with a simple route (eg /health) and GET?

Yes correct. We try to get this manual in. Seems more an issue for Microsoft to have these kind of APIs available in the api explorer.

Not sure if it makes sense to include that for all users - not everyone might want this to end up in the spec. Should probably opt-in via explorer settings. /cc @pranavkm any plans to do this?

@rynowak \ glencc, what do you guys think? The current contract with Swagger generator is integrated with MVC, we may have to come up with something different if we want to consider this.

We have no plans to do this in ASP.NET Core 3.0. This is possible for someone else to provide with extensibility, either:

by integrating the global endpoint collection directly with NSwag/Swashbuckle through their extensiblity
by implementing an IApiDescriptionProvider

Endpoint Routing (ASP.NET Core 3.0+) is a good foundation to build OpenAPI on top of, it's much more information/metadata rich than middleware. I want the community to have an OpenAPI story that's endpoint-centric eventually, but it's not clear what work that requires from us and when we would slot that in. We're much more focused now on getting users of MVC onto the new routing system as a primary concern.
I would be really interested to see what it would look like for a framework like NSwag or Swashbuckle to integrate directly with the endpoint collection.

We have no plans to do this in ASP.NET Core 3.0. This is possible for someone else to provide with extensibility, either:

by integrating the global endpoint collection directly with NSwag/Swashbuckle through their extensiblity
by implementing an IApiDescriptionProvider

Endpoint Routing (ASP.NET Core 3.0+) is a good foundation to build OpenAPI on top of, it's much more information/metadata rich than middleware. I want the community to have an OpenAPI story that's endpoint-centric eventually, but it's not clear what work that requires from us and when we would slot that in. We're much more focused now on getting users of MVC onto the new routing system as a primary concern.
I would be really interested to see what it would look like for a framework like NSwag or Swashbuckle to integrate directly with the endpoint collection.

Hi,
So we have just stumbled across this issue with health checks not being exposed.
I've seen the work around involving adding a proxy controller and it feels hacky and requires effort at every touch point.
I liked the idea of using a Document filter within swagger hooks, felt more open close.
However the more I read the more this feels like the problem lies with default IApiDescriptionProvider and actually of that returned the health check then the rest would just 'work'.
Currently working on trying to add a new HealthCheckDescriptionProvider that adds just that with lower priority than the default.
Can anyone see any issues with this plan?
Appreciate any guidance thanks

Currently working on trying to add a new HealthCheckDescriptionProvider that adds just that with lower priority than the default.

I think this should work, ie a decorator around the original description provider which passes everything through and adds another operation for the health endpoint


[Feature Request] Add bump-pydantic rules

Hello!
I remember seeing some library-specific rules (like NPY). What do you think about adding rules for the recentely released Pydantic V2? They even made their own rule-set BP.
https://github.com/pydantic/bump-pydantic

[ ] BP001: Add default None to Optional[T], Union[T, None] and Any fields
[ ] BP002: Replace Config class by model_config attribute
[ ] BP003: Replace Field old parameters to new ones
[ ] BP004: Replace imports
[ ] BP005: Replace GenericModel by BaseModel
[ ] BP006: Replace __root__ by RootModel
[ ] BP007: Replace decorators

Given that these rules are only useful for the transition from Pydantic v1 -> v2 I'm not sure if it belongs in Ruff. It seems more like a useful standalone tool whereas general lints for Pydantic that apply beyond upgrading seem worthy of including in Ruff. What do you think?

@zanieb That is a valid concern. But Pydantic models are an essential part of the popular FastAPI framework and quite numerous in larger codebases. To me these rules feel no less useful than NPY.
On the other hand, more general rules for Pydantic and FastAPI can be very useful, but I can't make a good list of them from the top of my head. I don't have that much of the experience of writing code using them (yet). Any help from the users would be appreciated.

To me, it’s not so much that they’re framework-specific as that they’re intended for a specific one-time migration, as opposed to being rules that would be useful for the ongoing maintenance of Python code. E.g., it’d be unusual to run these rules on a CI system or install this as an ongoing dependency — you’d likely install + run it once, then move on. The closest analogy would be the Pyupgrade rules, but even those exist to apply best practices as good is written and as versions are incremented.
I think it’s great that the Pydantic team shipped a standalone tool for this, but I don’t think there’s as much value in integrating it into Ruff.

I hope it will be like that and people won't be copying obsolete examples from the net.

We can revisit if that's the case, but I'm ok deprioritizing this for now. Thanks for bringing it up and for the helpful checklist.


Question: ServerUtility Functionality

I am trying to find a way to access the mavsdk_server console output string. Is the purpose of the ServerUtility plugin to access the server output strings?
If not then is there another plugin that offers this capabilty?
Thanks!

The best way right now is to run mavsdk_server in command line manually (e.g. ./mavsdk_server udp://:14540) and then to connect MAVSDK-Python to it with:
from mavsdk import System
drone = System(mavsdk_server_address="localhost")

Setting mavsdk_server_address means that MAVSDK-Python will not start the embedded mavsdk_server and will instead just connect to the one you started manually. The output of the one you start manually will appear in the terminal.

Is there a way to subscribe to the servers output that can be accessed from within the python script or is that what you are referring to when mention adding an API or file output?

That's what I am referring

Sounds good. Thanks for the response.


Lint with ruff Oct 10, 2023

[x] Closes Issue #xxxx
[x] Tests added
[x] Changes are documented in CHANGELOG.rst

Thanks @hmaarrfk!


UICollectionViewFlowLayout has cached frame mismatch

I'm getting this warning on iOS 9 which causes some slowness.
UICollectionViewFlowLayout has cached frame mismatch for index path <NSIndexPath: 0xc000000000000116> {length = 2, path = 1 - 0} - cached value: {{54.5, 418}, {266.5, 81}}; expected value: {{27.5, 418}, {266.5, 81}}
2015-09-24 14:01:45.242 Cymbal[2129:598465] This is likely occurring because the flow layout subclass UICollectionViewRightAlignedLayout is modifying attributes returned by UICollectionViewFlowLayout without copying them

Hey @GabeJacobs thanks for reporting the issue, an sorry for the late reply.
I fixed it and pushed an updated version, 0.0.3.
Enjoy :beers:


Finish (Travis) CI integration

It would be really nice to have a CI integration that at least builds the library and the examples.
There already exists https://travis-ci.org/cyndis/qmlrs/ from a year ago - maybe it can be brought to live with stable rust?

It might be possible if travis has updated their Ubuntu version since - when I tried to add CI integration then it was pretty much impossible to install a new enough version of Qt.

I did some experiments and got the basic build running on Ubuntu 14.04.
I'm stuck with the test cases, though. I added some dummy println!s to see whether the execution stalls before the exec() stall, but that's not the case. So for some reason, the quit() signal is not triggered. :cry:
Any idea what could go wrong there? Maybe related to the build servers running headless?

Could be, even though Qt5Gui shouldn't be invoked at all with a headless engine. Still, there might be some dependency. Could also be a change or bugfix between Qt 5.2 and 5.5. You could try changing the interval to something greater than zero or adding prints, checking if you can print a debug message from onComponentCompleted for example.

You were exactly right with the zero interval for the timer, that was the problem! :+1:
See #33  for the results. The badge is already for /cyndis/qmlrs repo, therefore it currently shows build error, but I already tested it for my fork. Only thing left would be to enable travis for your repo again.

Nice :) I just enabled the repo on travis, but I don't know if I can actually kick off a build for the latest commit (without making a new one). Still, we can probably consider this issue done.

For you as repo owner, there should be a restart circle-arrowish button at the top right of the colored boxes describing the build status. :smile:

Yeah, there is one and I tried it, but looks like it will only retry the old run I tried a year ago.. :)

Oh, that's very helpful, indeed. xD Well, but everything should be ready for the next PRs / commits now. :)

Found a trivial change to do, and hurray, everything works!
Thanks for Collaborator status! :D


Current playground URL is confusing / error prone

Current current local development URL for the VM playground is:
http://localhost:8073/playground/
Going to (what is normative for local development) of simply http://localhost:8073 leads to:

And going to http://localhost:8073/playground (note the lack of trailing /) leads to:

I would expect either of these paths to work. The current path seems to be convenient from a technical perspective, but not from a human one.

Moved to LLK/scratch-vm#466


getPathToAuth(): bail on any error, not just ENOENT

It's possible for stat() to fail in ways other than ENOENT.
If it does, bail out instead of silently cascading an
error condition.
Signed-off-by: Ed Santiago<EMAIL_ADDRESS>

@mheon done, and I'll close this.


Executable is not included in the 2.4.1 release

The downloadable exe file is not included in the 2.4.1 release.

I see it's in the zip file next to the latest source code. Shouldn't be more appropriate to have it stored by GitHub as a release?

fixed.


Tweak IsClosed behavior for Session receiver

Addresses https://github.com/Azure/azure-sdk-for-net/issues/29116

/azp run net - servicebus - tests

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Messaging.ServiceBus

/azp run net - servicebus - tests

/azp run net - servicebus - tests

/azp run net - servicebus - tests

/azp run net - servicebus - tests

IsClosed on ServiceBusSessionReceiver will now return true if the session link dropped (either due to network flakiness or session lock lost), in addition to returning true if user calls CloseAsync or DisposeAsync.

We would still want developers to call CloseAsync or DisposeAsync in this case, right?   Otherwise, the underlying link and other network goo will live until the idle timeout or the associated ServiceBusClient is closed?    Assuming there's no way to recover from the session link error, is there a way that we can detect as it happens and just do a full close flow?


cloud reader, zipped EPUB loading

The Javascript zip library returns the following error codes / messages:

http://www.daisy.org/projects/tobi/readium/?epub=epub_content%2Finternal_link.epub
=>
Failed to load resource: net::ERR_CONTENT_DECODING_FAILED
Error while reading zip file.
See:
https://github.com/gildas-lormeau/zip.js/blob/master/WebContent/zip.js#L36
var ERR_READ = "Error while reading zip file.";

http://development.readium.divshot.io/?epub=epub_content%2Finternal_link.epub
=>
File format is not recognized.
See:
https://github.com/gildas-lormeau/zip.js/blob/master/WebContent/zip.js#L32
var ERR_BAD_FORMAT = "File format is not recognized.";

So, investigating with CURL:
curl "-H Range:bytes=16-" "-I" "http://www.daisy.org/projects/tobi/readium/epub_content/internal_link.epub"
=>
HTTP/1.1 200 OK

Server: Apache

Accept-Ranges: bytes
Content-Length: 21577
Cache-Control: max-age=1209600
Vary: Accept-Encoding

Content-Type: application/epub+zip

curl "-H Range:bytes=16-" "-I" "http://development.readium.divshot.io/epub_content/internal_link.epub"
=>
HTTP/1.1 200 OK

Server: nginx/1.4.3

Cache-Control: public, max-age=31536000
Content-Encoding: identity
X-Accel-Expires: 31536000
X-Robots-Tag: noindex
Connection: keep-alive

Content-Type: application/epub+zip

In both cases, the HTTP CORS headers are present:
Access-Control-Allow-Origin: *
Access-Control-Allow-Credentials: true
Access-Control-Allow-Methods: GET, HEAD, POST
Access-Control-Allow-Headers: Range, Content-Type, Origin, X-Requested-With, Accept, Accept-Language, Content-Language
Access-Control-Expose-Headers: Accept-Ranges, Content-Encoding, Content-Type, Content-Length, Content-Range, Content-Language, Cache-Control, Expires, Last-Modified, Pragma

It would appear that DivShot.io does not support the HTTP 1.1 "partial range" protocol, as the Accept-Ranges: bytes header is missing.
The daisy.org HTTP server seems to support this, yet the EPUB fails to load.
To add further confusion, the local HTTP server used at development time (npm run http) works fine, but does not actually advertise Accept-Ranges: bytes in its headers:
curl "-H Range:bytes=16-" "-I" "http://<IP_ADDRESS>:8080/internal_link.epub"
=>
HTTP/1.1 200 OK

server: ecstatic-0.7.6

cache-control: max-age=-1
content-length: 21577
Connection: keep-alive

content-type: application/epub+zip; charset=utf-8

Note: the internal_link.epub sample is actually hosted on GitHub:
https://github.com/readium/readium-js-viewer/blob/feature/pluginsX/epub_content/internal_link.epub
...but the "raw" download URL ( https://raw.githubusercontent.com/readium/readium-js-viewer/feature/pluginsX/epub_content/internal_link.epub ) only allows HTTP CORS requests from https://render.githubusercontent.com (Access-Control-Allow-Origin header), and does not seem to support HTTP 1.1 partial ranges requests anyway.
https://raw.githack.com does not support HTTP CORS at all.

curl "-H Range:bytes=16-" "-I" "http://github-raw-cors-proxy.herokuapp.com/readium/readium-js-viewer/feature/pluginsX/epub_content/internal_link.epub"
=>
HTTP/1.1 200 OK
Server: Cowboy
Connection: keep-alive
X-Powered-By: Express
Access-Control-Allow-Origin: *
Content-Type: application/json; charset=utf-8
Content-Length: 55317
Date: Tue, 02 Jun 2015 11:42:46 GMT
Via: 1.1 vegur

The daisy.org case (Failed to load resource: net::ERR_CONTENT_DECODING_FAILED) was fixed by disabling gzip compression, by adding this to .htaccess:
SetEnv no-gzip 1

<ifModule mod_gzip.c>
  mod_gzip_on No
</ifModule>

In the DivShot.io case, it seems that the HEAD HTTP request does not return the expected Content-Length (which is needed by the ZIP Javascript lib):
curl -X HEAD "http://development.readium.divshot.io/epub_content/internal_link.epub" -I
=>
HTTP/1.1 200 OK`
Access-Control-Allow-Credentials: true
Access-Control-Allow-Headers: Range, Content-Type, Origin, X-Requested-With, Accept, Accept-Language, Content-Language
Access-Control-Allow-Methods: GET, HEAD, POST
Access-Control-Allow-Origin: *
Access-Control-Expose-Headers: Accept-Ranges, Content-Encoding, Content-Type, Content-Length, Content-Range, Content-Language, Cache-Control, Expires, Last-Modified, Pragma
Cache-Control: public, max-age=31536000
Content-Encoding: identity
Content-Type: application/epub+zip
Date: Tue, 02 Jun 2015 22:12:21 GMT
Server: nginx/1.4.3
X-Accel-Expires: 31536000
X-Robots-Tag: noindex
Connection: keep-alive

Issue filed at DivShot Superstatic: https://github.com/divshot/superstatic/issues/169

Closing, as this is not a Readium issue.

Related: https://github.com/readium/readium-js-viewer/issues/336


Using distro in setup.py

Hi, I want to use distro to choose what to do in setup.py. I was wondering if there's some recommended way of doing this ?
The ideas we've thought of:

Using setup_requires, We're not sure this is a good method of doing it - There have been quite a few bugs with it (On windows, old versions of pip, etc.)
There was a suggestion of directly downloading https://github.com/nir0s/distro/blob/master/distro.py and importing that using urllib.

I wanted to ensure that I use the recommended way so that the app doesn't break later.

Bump, would love some input on this ?

So, I haven't heard of someone using distro in setup.py yet so it's hard for me to tell you what's the "recommended" way of doing that. setup_requires sounds like a good idea though I'm not familiar with its windows breakages.
If you know you have pip in your environment, you can call subprocess to install distro via pip (I wouldn't use pip directly from Python as its API is not official - thus the subprocess method) and then import it. somewhat hacky, but will work cross platform and should never break.

Nod, I found https://bitbucket.org/dholth/setup-requires which was mentioned in https://github.com/pypa/pip/issues/1820 which describes that rather than using setup_requires a subprocess invoking pip may be the best bet for reliability.

I would appreciate a PR for the docs stating that as a use case and how you solved it eventually.

@nir0s Agree, I'll do that after I have sufficiently tested the method I'm using right now.
I also noticed that there's an issue in pip and pip may soon depend on distro ... https://github.com/pypa/pip/issues/3823
So, in that case maybe we wouldn't even need that extra documentation as distro would be available due to pip itself ?

If pip is ready to integrate distro (as indicated in https://github.com/pypa/pip/issues/3823), then I think we should release distro 1.0.0, to make it clear that the API is stable from now on (at least within 1.x.x).

Sounds reasonable to me.

@andy-maier , pip already merged 0.6.0. I guess we should still release 1.0.0 after we add the CLI. Does that make sense?

@AbdealiJK, any updates on this? Interested in submitting that PR or can I close this?

I'm a bit busy right now, so no PR at the moment.
To give a brief idea for others who have the same issue, I had to call pip install using subprocess to install the package to the current directory - https://github.com/pywikibot-catfiles/file-metadata/blob/master/setupdeps.py#L49
This seems to work fine (although pip install is called twice)
There seems to be no elegant solution at this time that I was able to use without problems.


Tasks should support specifying the output encoding

I think it's related to some global language problem.
The output message is broken like this
'luac'��(��) ���� �Ǵ� �ܺ� ����, ������ �� �ִ� ���α׷�, �Ǵ�
��ġ ������ �ƴմϴ�.
P.S> My environment is Win10 Ko(Korean version)
https://onedrive.live.com/redir?resid=73F0A5AA67A0D48F!212183&authkey=!ACjcDNvjj7PjRmY&v=3&ithint=photo%2Cpng

For sure we're blindly converting to/from utf8 somewhere...

+1 . hope to fix as soon as possible

+2. It's really a boring bug, hope to get it down in the next release version. 🎱
Now I use the internal console instead of tasks. :-(

Please see https://github.com/Microsoft/vscode/issues/15179. The idea here to move forward is to execute tasks in the terminal instead in its own output channel.

Have the same problem Win10/Russian MsBuild. Really annoying.

Agree. The plan forward here is to use the integrated terminal to run tasks. This will make this work and even support input and ANSI control characters

Why is it a "feature-request"? Not garbling an output is not a feature. I think it should be "bug" and "important".

In tasks.json:
use
"command": "cmd",
"args": ["/c chcp 65001 >nul && mingw32-make"]

instead of
"command": "mingw32-make"

and everything seems to work fine.

compiling...
main.cpp
e:\projects\c++\vscode_test\main.cpp(247): error C2143: 语法错误: 缺少“;”(在“return”的前面)
mingw32-make: *** [main.obj] Error 2
Makefile:37: recipe for target 'main.obj' failed

@EternalPhane thanks for this. Actually I am working on support for running tasks in the integrated terminal which should make the encoding problem go away.

@dbaeumer update on this feature would be much appreciated. Not being able to figure out what the error message is makes the task feature almost unusable, thanks.

@gyuhyeon this will be addressed by using the terminal as the execution engine for tasks. You can alreadz opt into using the terminal by adding "runner": "terminal" to your tasks.json

"runner":"terminal" does not appear to work anymore, I have had success setting the ENV before my command. I am on a Mac.
I was trying to run Jekyll.
"command": "export LANG=en_US.UTF-8 && export LC_ALL=en_US.UTF-8 && jekyll serve --watch"

@rajannpatel strange, "runner": "terminal" is still supported. You can also switch to tasks version 2.0.0. Can you provide a tasks.json file which demonstrates the behavior.

after update to .net core 2.0
the problems window shows messy code
the output window also shows messy code like this:
e:\Work\Server\LoginServer\LoginServer\LoginServer.csproj : warning NU1701: Package 'Nancy.Owin 2.0.0-clienteastwood' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.0'. This package may not be fully compatible with your project.
���� .NET Core �� Microsoft (R) ��������汾 15.3.409.57025
��Ȩ����(C) Microsoft Corporation����������Ȩ����

I have a workaround for this issue here:
https://gist.github.com/doggy8088/ca1dd1fff42e0dd4f0ce175a460feae5/revisions

Thanks!
export LC_ALL=en_US.UTF-8 (for Russian export LC_ALL=ru_RU.UTF-8) helped me on Debian Linux added in file .bashrc

I am closing this issue since this can now be control using normal Terminal setups in task 2.0.0. I also wrote some doc explaining how this is best used here: https://github.com/Microsoft/vscode-docs/blob/vnext/docs/editor/tasks.md#changing-the-encoding-for-a-task-output
I will close the issue. Please reopen a new issue against the current support if it is not satisfactory for you.


rewrite and simplify the resource monitor package

Reduce the API surface as much as possible in order to simplify the package and trim down the size.
We get rid of the intermediate representation, with all the extra complexity this encompesses.
Along the way, we add the option to refresh the allocatable resources before each polling cycle,
instead of just once at the initialization time.

The only minor comment I have is that since we have moved all the code to resourcemonitor.go and it seems like a lot squeezed into a single file. Maybe we keep excludeList logic in a separate file and datatype definitions in the type.go like it was previously? Let me know if that sounds reasonable.

I'm not sure. We extract indeed some components, but these components will be tiny and used all over the place in the bigger file. I'm not sure this modularization actually improves redability.

That is indeed a valid point, having to go back and forth to other files will impact the readability. Let's leave it like this for now and see what the maintainers think. I am happy enough with the PR!
/lgtm

That is indeed a valid point, having to go back and forth to other files will impact the readability. Let's leave it like this for now and see what the maintainers think. I am happy enough with the PR!
/lgtm

thanks! :)


Template Operator Verification Bug Hunt: kustomize in manifest operator is on v3 and needs to be updated in Makefile

In the Makefile of manifest-operator, the kustomize version in the Makefile is outdated:
https://github.com/kyma-project/manifest-operator/blob/main/operator/Makefile#L121-L129
Please compare it to kyma-operator and use the same Makefile Configuration.
AC:

Makefile is adjusted
Build on ARM succeeds
Mac M1 make install command succeeds

The version was updated to v4.5.6, closing this one.


Bitwarden Biometric Integration

System Details

OS: MacOS
Thorium Version: 116.0.5845.169 (Official Build) (arm64)

Problem
I installed the Bitwarden extension, then tried to set up biometric approval with the Bitwarden Vault. I was asked for a permission, granted it, then tried to activate it. The extension then throws an error mentioning that the browser integration is not set up (see screenshot).
Screenshots

Additional Notes
I am aware this might sound like a Bitwarden issue, but I have the same extension working with biometric approval in the same system with Edge, Chrome, Opera and Brave, so it does seem something specific to Thorium.

You may need to correctly set up Thorium's native-messaging-hosts in bitwarden
@kladskjasd

@kladskjasd Yeah, people have made issues on this before, and someone got it working, just by tweaking the native messaging hosts. Since they don't make these with esoteric or small browsers in mind.

Yup here is the link https://github.com/Alex313031/thorium/issues/363


Add support for AlarmRemoteController (rtds:RTDSRemoteControllerComponent)

Device information
https://boutique.somfy.fr/telecommande-tahoma-serenity.html
Remote control for TaHoma serenity, Somfy's connected security:
• 5-button remote control
• Manage the modes of TaHoma Serenity
• SOS function to generate alerts in case of emergency
Device details

2020-09-14 11:06:15 DEBUG (MainThread) [custom_components.tahoma] Unsupported TaHoma device detected (rtds:RTDSRemoteControllerComponent - RemoteController - AlarmRemoteController)
{
	"commands": [],
	"states": [{
		"type": "ContinuousState",
		"qualifiedName": "rtds:ControllerBatteryState"
	}, {
		"type": "ContinuousState",
		"qualifiedName": "rtds:ControllerBipState"
	}, {
		"type": "ContinuousState",
		"qualifiedName": "rtds:ControllerOrderTypeState"
	}, {
		"type": "ContinuousState",
		"qualifiedName": "rtds:ControllerOriginatorState"
	}, {
		"type": "ContinuousState",
		"qualifiedName": "rtds:ControllerSensingState"
	}, {
		"type": "ContinuousState",
		"qualifiedName": "rtds:ControllerSirenState"
	}],
	"dataProperties": [],
	"widgetName": "AlarmRemoteController",
	"uiClass": "RemoteController",
	"qualifiedName": "rtds:RTDSRemoteControllerComponent",
	"type": "REMOTE_CONTROLLER"
}

What would be the use case for this device in Home Assistant? It looks like it is only possible to read the status, thus mapping it to a sensor is the only option.
Another option is to ignore this device in Home Assistant, which means that it won't show as an unsupported device in the log anymore?

Can you see this device in your Tahoma interface?

No, i don't see the device in thaoma. I have activate the debug mode to view this.
I would like to be able to use it to open and close the gate which is not Somfy brand. (run script)
I bought 433Mhz modules and I would like, when pressing one of the buttons, to open or close the gate in full or pedestrian opening mode.
I have see that the button clicks activate / deactivate the alarm created by the integration and i can use this in automation.
But, the update delay is important and when I set the update interval to 3 seconds, I can no longer connect to the tahomalink interface because message of too many requests

Just to be clear, does it show up in the interface on tahomalink.com? I am not sure if this is an use case that we could easily support. Why not use another remote that you could use with Home Assistant?
By the way;

currently we don't support opening the gate in pedestrian opening mode, this could be added as a service in HA
would you need a lower polling interval than 3 seconds? It should work with low intervals as well, are you using other integrations / programs with the same Somfy TaHoma account?

I use this remote control because it is  a device of the simple tahoma pack.
I will use a contactor for the different modes for the gate. I don't need any support for this..
The remote control appears in tahomalink.
Since this morning I have set an interval of 1 second which is sufficient and the message of too many requests is random...
As it is an accessory of the simple pack (I bought the tahoma in October 2019), I thought that the integration would be simple ...
I don't really need it because I can actually buy a 433mhz remote control but I just wanted to be able to use this one because otherwise it is in a drawer and is useless.
But when i use the Total Alarm Mode button, the state of alarm_control_panel.alarm of tahoma integration change.
so if you can add this remote that would be great (with all button support) but otherwise i will start using it by scanning the alarm.
However:
Thanks for this component 👍

Should I close? Is a job going to be started?

Should I close? Is a job going to be started?

For now, this hasn't been planned yet. There are some other issues which we prioritised at the moment.
I have added the 'help wanted' tag, which means that the issue won't be closed automatically and that it is visible for people who would like to contribute.

Let's imagine we finally successfully map this remote to a sensor. As we poll the Tahomalink website, it will me that once one button pressed you will have a delay with the action.
By the way how do you configure the buttons?

You are right to talk about the polling time because I set it to one second to have the least possible latency. If Somfy alerts when the time is too short, this remote control will be of no use. Thanks for the support but don't waste time on it (for my part).

Thanks for the effort 👍.
I would like to use this remote controller to trigger opening and close of a Wifi garage opener integrated into Home Assistant.

@LoicRivoal due to #289, the lowest update frequency has been changed to 30 seconds. This means that it could take up to 30 seconds before your remote controller command will be received by Home Assistant.
Due to this limitation, I don't see a good use-case for this remote controller. We won't spend time to implement this feature, but I will leave your issue open in case someone would like to contribute.

@LoicRivoal due to #289, the lowest update frequency has been changed to 30 seconds. This means that it could take up to 30 seconds before your remote controller command will be received by Home Assistant.
Due to this limitation, I don't see a good use-case for this remote controller. We won't spend time to implement this feature, but I will leave your issue open in case someone would like to contribute.

Anyone still interested in this sensor in HA? @LoicRivoal / @clemalex824? We can now easier add binary_sensor or sensors.
The polling time will still be high, however this could be lowered if you have local support. (currently only possible by jailbreaking your box).

I'm always interested. But I don't want to touch the firmware or other manipulation on the tahoma... 😱


CUDA running out of memory

Hi
Thanks for this wonderful script. It is really helpful when testing various models!
I have issue of running out of memory in GPU. I know that this is NOT exactly a bug too. This is a CUDA memory issue.
Is there any way to reduce GPU memory usage. I only have 2 GB on my Geforce GTX 1050.
Only happens when training from scratch and training Deep
This is the error:
[29,    30] loss: nan [0.0044375000000000005]
[30,    30] loss: nan [0.0043333333333333392]
[31,    30] loss: nan [0.0011041666666666609]
[32,    30] loss: nan [0.0041250000000000002]
Finished Training
Evaluating...
THCudaCheck FAIL file=/pytorch/torch/lib/THC/generic/THCStorage.cu line=66 error=2 : out of memory
Traceback (most recent call last):
File "retrain.py", line 380, in
CLR=use_clr)
File "retrain.py", line 322, in train_eval
stats_eval = evaluate_stats(net, testloader)
File "retrain.py", line 304, in evaluate_stats
outputs = net(Variable(images))
File "/usr/lib64/python3.6/site-packages/torch/nn/modules/module.py", line 224, in call
result = self.forward(*input, **kwargs)
File "/usr/lib64/python3.6/site-packages/torch/nn/parallel/data_parallel.py", line 58, in forward
return self.module(*inputs[0], **kwargs[0])
File "/usr/lib64/python3.6/site-packages/torch/nn/modules/module.py", line 224, in call
result = self.forward(*input, **kwargs)
File "/usr/lib/python3.6/site-packages/torchvision/models/inception.py", line 81, in forward
x = self.Conv2d_2b_3x3(x)
File "/usr/lib64/python3.6/site-packages/torch/nn/modules/module.py", line 224, in call
result = self.forward(*input, **kwargs)
File "/usr/lib/python3.6/site-packages/torchvision/models/inception.py", line 325, in forward
x = self.bn(x)
File "/usr/lib64/python3.6/site-packages/torch/nn/modules/module.py", line 224, in call
result = self.forward(*input, **kwargs)
File "/usr/lib64/python3.6/site-packages/torch/nn/modules/batchnorm.py", line 37, in forward
self.training, self.momentum, self.eps)
File "/usr/lib64/python3.6/site-packages/torch/nn/functional.py", line 639, in batch_norm
return f(input, weight, bias)
RuntimeError: cuda runtime error (2) : out of memory at /pytorch/torch/lib/THC/generic/THCStorage.cu:66
[tomppa@localhost pytorch-retraining]$
nvidia-smi
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 387.22                 Driver Version: 387.22                    |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  GeForce GTX 1050    Off  | 00000000:01:00.0  On |                  N/A |
| 54%   58C    P0    N/A /  75W |   1942MiB /  1998MiB |     84%      Default |
+-------------------------------+----------------------+----------------------+
+-----------------------------------------------------------------------------+
| Processes:                                                       GPU Memory |
|  GPU       PID   Type   Process name                             Usage      |
|=============================================================================|
|    0      1405      G   /usr/libexec/Xorg                             18MiB |
|    0      1444      G   /usr/bin/gnome-shell                          42MiB |
|    0      1776      G   /usr/libexec/Xorg                            114MiB |
|    0      1870      G   /usr/bin/gnome-shell                          87MiB |
|    0      6652      G   gnome-control-center                           1MiB |
|    0      7139      C   python3                                     1665MiB |
+-----------------------------------------------------------------------------+
CUDA version:
nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2016 NVIDIA Corporation
Built on Tue_Jan_10_13:22:03_CST_2017
Cuda compilation tools, release 8.0, V8.0.61

Yes, try to decrease the batch size first. I'm not sure how low you have to go for a 2gig card though.

That Solved it, thanks!
Looks like 2gig card is is not too much to play with

Great. Keep in mind that the optimal learning rate is affected by batch size. Good luck.


Refactor Effects System and Implemented Animated Overlays

Description
Refactored effects, decoupling them from attacks. Implemented poison and stun effects properly with an animated overlay. More info can be found in the task ticket.
Fixes / Closes #427
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Testing

[x] Play testing
[x] Modified components' tests passing.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Fix the Kitsune Fire that currently got replaced with dragon fire, will review again

SEVERE: Error reading Map from configs/pets.json: Unable to convert value to required type: type: knockback (com.csse3200.game.components.effects.EffectType)
Serialization trace:
type (com.csse3200.game.entities.configs.EffectConfig)
effects (com.csse3200.game.entities.configs.AttackConfig$MeleeAttack)
melee (com.csse3200.game.entities.configs.AttackConfig)
attacks (com.csse3200.game.entities.configs.NPCConfigs$NPCConfig)
15:52:58:186 com.csse3200.game.files.FileLoader readMap
SEVERE: Pet Config map is empty or null
15:52:58:186 com.csse3200.game.entities.factories.PetFactory loadConfigs
Exception in thread "main" java.lang.NullPointerException: Cannot invoke "java.util.Map.keySet()" because "this.npcConfigs" is null
at com.csse3200.game.entities.configs.NPCConfigs.getNpcTypes(NPCConfigs.java:25)
at com.csse3200.game.entities.factories.PetFactory.getTextureFilepaths(PetFactory.java:207)
at com.csse3200.game.entities.factories.LoadedFactory.load(LoadedFactory.java:70)
at com.csse3200.game.entities.factories.LoadedFactory.(LoadedFactory.java:17)
at com.csse3200.game.entities.factories.PetFactory.(PetFactory.java:47)
at com.csse3200.game.components.player.inventory.Tombstone.randomPetGenerator(Tombstone.java:58)
at com.csse3200.game.components.player.inventory.Tombstone.effect(Tombstone.java:37)
at com.csse3200.game.components.player.inventory.BuffItem.pickup(BuffItem.java:28)
at com.csse3200.game.components.player.inventory.InventoryComponent.pickup(InventoryComponent.java:37)
at com.csse3200.game.components.player.inventory.ItemPickupComponent.handleItemPickup(ItemPickupComponent.java:185)
at com.csse3200.game.components.player.inventory.ItemPickupComponent.lambda$create$0(ItemPickupComponent.java:49)
at com.csse3200.game.events.EventHandler.lambda$trigger$0(EventHandler.java:85)
at java.base/java.lang.Iterable.forEach(Iterable.java:75)
at com.csse3200.game.events.EventHandler.forEachListener(EventHandler.java:152)
at com.csse3200.game.events.EventHandler.trigger(EventHandler.java:85)
at com.csse3200.game.components.player.KeyboardPlayerInputComponent.pickupItem(KeyboardPlayerInputComponent.java:174)
at com.csse3200.game.components.player.KeyboardPlayerInputComponent.lambda$getDownActions$17(KeyboardPlayerInputComponent.java:235)
at com.csse3200.game.components.player.KeyboardPlayerInputComponent.keyChange(KeyboardPlayerInputComponent.java:295)
at com.csse3200.game.components.player.KeyboardPlayerInputComponent.keyDown(KeyboardPlayerInputComponent.java:306)
at com.csse3200.game.input.InputService.keyDown(InputService.java:80)
at com.badlogic.gdx.InputEventQueue.drain(InputEventQueue.java:58)
at com.badlogic.gdx.backends.lwjgl3.DefaultLwjgl3Input.update(DefaultLwjgl3Input.java:189)
at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Window.update(Lwjgl3Window.java:378)
at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.loop(Lwjgl3Application.java:192)
at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.(Lwjgl3Application.java:166)
at com.csse3200.game.desktop.DesktopLauncher.main(DesktopLauncher.java:10)
Crashing on pet pickup @mblauberg

Im gonna update the team branch so if there are merge conflicts from this please resolve these while fixing the above bug