"Failed to send thanks" notification, but thank actually sent successfully

Steps to reproduce:

Compile and run latest master.
Tap "Review"
If the picture is good, tap to end a thank
See notification, it says "Failed to send thanks"

Example:

Even though the thank has actually been sent successfully:

I've seen this too.

Can I try to work on this?
I was able to reproduce this issue for betaDebug. I observed that we get the same failure notification when the thanks is recorded and when it actually fails (I did this by turning off the WiFi just before sending thanks).

@6point022 Yes it's yours! Please use "prodDebug" instead. Thanks :-)

I'll really appreciate some help with this.
This is from the ThankClient.java file
/**
* Handles the Thanking logic
* @param revesionID The revision ID you would like to thank someone for
* @return if thanks was successfully sent to intended recepient, returned as a boolean observable
*/

public Observable<Boolean> thank(long revisionId) {
        try {
            return service.thank(String.valueOf(revisionId), null,
                csrfTokenClient.getTokenBlocking(),
                CommonsApplication.getInstance().getUserAgent())
                .map(mwQueryResponse -> mwQueryResponse.getSuccessVal() == 1);;
        } catch (Throwable throwable) {
            Log.d("Thanked", "Inside throwable");
            return Observable.just(false);
        }
    }

I tried to see what getSuccessVal() will return.
public class MwPostResponse extends MwResponse {
    @Nullable @SuppressWarnings("unused") private String options;
    @SuppressWarnings("unused") private int success;

    public boolean success(@Nullable String result) {
        return "success".equals(result);
    }

    @Nullable public String getOptions() {
        return options;
    }

    public int getSuccessVal() {
        return success;
    }
}

I could be way off here (I am just learning!!), but I think the reason for failure could be that it is actually returning 0, since the default value of success will be 0 and we are never initialising it to anything else. So, in ThankClient.java, Instead of checking the returned value for 1, we should check for 0. Does this seem correct?

@6point022 It's a good thing you shared your doubts here :) I'm not so familiar with the code base but I'll share my views here assuming others will correct me if I'm wrong.

... but I think the reason for failure could be that it is actually returning 0, since the default value of success will be 0 and we are never initialising it to anything else

You won't find the code that initializes the value of success anywhere in the app or in the data-client library. It's automatically set when you receive the response for the query (I believe it's done by Retrofit). So, don't worry about the value not being initialized. It would be :)
I think you're in the right track, though. If I were to just go by the example  pointed to by the API page, the value of success would be 1 for a successful thank. But the example might be outdated or there might be other values that indicate success. So, I would suggest that you check for what values of success we're incorrectly getting the thank failed notification.
Hope this helps.

@sivaraam Thanks a lot for the response. ^_^

So, I would suggest that you check for what values of success we're incorrectly getting the thank failed notification.

So, I checked for two cases.

When the thanks is sent successfully, getSuccessVal() returns 0, and we're checking for a 1. This is the reason for the incorrect notification.
I tried to generate a failure by turning off the phone's WiFi before sending the thanks. In this case, we actually get a throwable and move into the catch block and get the correct notification.

Can you help me understand in what case getSuccessVal() could return a number other than 0, and how to check for them? Also, is it safe to assume that it will only return 0 when there's a success?

When the thanks is sent successfully, getSuccessVal() returns 0, and we're checking for a 1. This is the reason for the incorrect notification.

How do you know that the thank succeeded? Did you check the thank log (Special:Log?type=thanks) of the corresponding wiki? I just tried using the API sandbox and could see that the value of success is 1 for a successful thank:

I tried to generate a failure by turning off the phone's WiFi before sending the thanks. In this case, we actually get a throwable and move into the catch block and get the correct notification.

Well, that's what would happen when the app could not connect to the network. But we're actually interested in a different kind of failure here. We have to send a request that reaches the server and the server would respond to us indicating that for some reason the server could not complete the request. It's easier to check that via the API:Sandbox. You can try a thank API request using the following link. Make sure you're logged in before you visit the link.
https://commons.wikimedia.org/wiki/Special:ApiSandbox#action=thank&format=json
I'm not sure for what cases we would be able to see a different value for success though.

Can you help me understand in what case getSuccessVal() could return a number other than 0, and how to check for them?

Ideally it should be present in the API documentation. Unfortunately, the API page doesn't help us here as it doesn't have an exhaustive list of values that success could have.

Also, is it safe to assume that it will only return 0 when there's a success?

It doesn't seem to be returning 0 on success as you could see from the API response above. But if we do get 0 for getSuccessVal() then I think the issue is somewhere else and we would have to figure it out. My knowledge is limited. We'll see if @maskaravivek, @ashishkumar468 or @misaochan could help us here.
I'll just note one thing I observed when checking for this. I was checking if the Wikipedia app (which also uses the data client library albeit a different version, I suppose) was correctly receiving the success value correctly in a MwPostResponse object. I observed that it was indeed getting the value appropriately (MwPostResponse#getSuccessVal() returns 1). Beware that I was checking the response of a different API query [1] [2] and NOT the response of a thank API query.

Thanks a lot for taking out the time to explain, it's really helpful. 😄

How do you know that the thank succeeded? Did you check the thank log (Special:Log?type=thanks) of the corresponding wiki?

Yes, I checked the thank log and if the thank appeared in it, I considered it a success. If the thank is successful, the value of success returned by getSuccessVal() is actually 0, and not 1.

But if we do get 0 for getSuccessVal() then I think the issue is somewhere else and we would have to figure it out. My knowledge is limited.

Even I am not sure how to proceed from here. Let's see if someone else can help us. :)

I'd like to try my hand at figuring out what's going on.

Please feel free, @Daykeras !

can i work on this issue

can i work on this issue

Yes
On Thu, Jan 21, 2021, 10:54 AM Prince kushwaha<EMAIL_ADDRESS>wrote:

can i work on this issue
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/3559#issuecomment-764741111,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD6MJD6SUFOLZT5DSGRTB33S3BE3XANCNFSM4LQ2MSEA
.

Yes
On Thu, Jan 21, 2021, 10:54 AM Prince kushwaha<EMAIL_ADDRESS>wrote:

can i work on this issue
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/3559#issuecomment-764741111,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD6MJD6SUFOLZT5DSGRTB33S3BE3XANCNFSM4LQ2MSEA
.


"The request signature we calculated does not match the signature you provided."

Hi,
I am using latest aws-java-sdk-s3', version: '1.11.158'. I am getting SignatureDoesNotMatch error. I am using below code.
The request signature we calculated does not match the signature you provided. Check your Google secret key and signing method. com.amazonaws.services.s3.model.AmazonS3Exception: The request signature we calculated does not match the signature you provided. Check your Google secret key and signing method. (Service: Amazon S3; Status Code: 403; Error Code: SignatureDoesNotMatch; Request ID: null
ClientConfiguration clientConfiguration = new ClientConfiguration();
AWSCredentials awsCredentials = new BasicAWSCredentials("XXX","XXX");
AmazonS3 amazonS3Client = AmazonS3ClientBuilder.standard().withCredentials(new AWSStaticCredentialsProvider(awsCredentials)).withClientConfiguration(clientConfiguration)
.withEndpointConfiguration(new AwsClientBuilder.EndpointConfiguration("https://storage.googleapis.com","Multi-Regional")).build();
        String keyName = UUID.randomUUID().toString();
        FileInputStream f = new FileInputStream(new File(filePath));
        TransferManager tx =  TransferManagerBuilder.standard().withS3Client(amazonS3Client).build();

        // Request server-side encryption.
        ObjectMetadata objectMetadata = new ObjectMetadata();
        objectMetadata.setSSEAlgorithm(ObjectMetadata.AES_256_SERVER_SIDE_ENCRYPTION);
        objectMetadata.setContentType("application/octet-stream");

        tx.upload("XX", keyName, f,objectMetadata);

Can you walk me through how I can reproduce this?

Hi Stephen,
I am attaching the sample gradle project. Please unzip and run the project with your access,  secret key and file.
aws-sdk-test.zip

Is there a way to reproduce this error outside of the AWS environment?

I am storing the files in the  google cloud s3 bucket (Google cloud S3 environment) using aws sdk S3. As google lets Cloud Storage interoperate with tools written for other cloud storage systems like aws sdk. I am using latest aws sdk s3.

@lukesneeringer is it clear to you how we should debug this issue?

@lukesneeringer - if you require more information, please let me know.
Is there any thing that I need to check at signature version. In my code- i commented out signature version code . I tried various possibilities and could not get through.

Hi @kirankumar-mahi,
Thanks for reporting.
This repository is for the Node.js client libraries, which I am fairly certain is not what you are after, since as best as I can tell, you are writing Java code. I would recommend opening an issue on google-cloud-java.
Sorry...I know it is frustrating to be redirected, but none of the folks who maintain this repo are going to know how to help you. :-(
I am going to close this, but if I goofed somehow, please feel free to re-open.


Add Cargo format and clippy checks to our CI for all rust code

Similar to what we do in bpfman at -> https://github.com/bpfman/bpfman/blob/main/.github/workflows/build.yml#L84
we should be running cargo fmt and cargo clippy against all our rust based code to make sure it's formatted and checked correctly.

Happy to take this on per our conversation on slack. To confirm, this looks as simple as adding these two steps to our GH actions for all rust contexts. Based on my perusal, I see the following rust contexts:
dataplane/
tools/udp-test-server

Do we want this in ci.yaml and, if so, one or both of the build steps? Looks like there is one first for all PRs then another for pushes to main.
A manual run of these commands throws warnings -- will fix up those too.

Yes, and also a note (cc @aryan9600) that we are rewriting our control-plane into Rust as well.

I'm tracking the migration. If one of those PRs beats this in, I'll add coverage for those contexts too.

As a new contributor, I'm interested in rust and k8s. so can I take this issue?

Hiya @qzqsmile Last I checked @EandrewJones was already looking into this one!
@EandrewJones Can I assign you here?

Yes. Please assign.
Best
Evan Jones
Website: www.ea-jones.com
On Wed, Mar 27, 2024 at 11:42 AM Andrew Stoycos @.***>
wrote:

Hiya @qzqsmile https://github.com/qzqsmile Last I checked @EandrewJones
https://github.com/EandrewJones was already looking into this one!
@EandrewJones https://github.com/EandrewJones Can I assign you here?
—
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/blixt/issues/212#issuecomment-2023095665,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ2T6AJTDNLQGPQE5HVGKFLY2LSF5AVCNFSM6AAAAABE6QRFH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRTGA4TKNRWGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

/assign @EandrewJones


Remove GLS from the list of carriers that support pickup requests

We do not (as of now) support pickup requests for the carrier GLS - so we shouldn't mention GLS here.

Ready to merge!


feat: do not memorize entity value when the doNotMemorize flag is set

:tada: This PR is included in version 0.285.0 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add specialist-publisher

Trello: https://trello.com/c/7MGgrIwa
Depends on PR #8
Viewing the app using the "backend" image

Publishing a document using the "e2e" image:

The format of the makefiles has been changed in #9

I've tried making the suggested changes, but I'm getting errors see commit: https://github.com/alphagov/govuk-docker/pull/10/commits/910d69ff498593662dc00ebec5f9f413be042ff0

@barrucadu I've updated the Makefile

@barrucadu I've moved the files. 🤞 nothing else has moved.

@barrucadu I'm on leave tomorrow. Can you re-review and merge this if you're happy? Thanks,

I've rebased this against master and fixed the way govuk-docker is invoked in the Makefile (it was changed by the rubyification team).  Looks good to me now.


Type Check in Props and Delta Change Values

This PR fixes the issue issue-498
Added typecheck to avoid throwing onChange Error when nextContents and this.lastDeltaChangeSet are undefined.
Before Fix:

After Fix:

This fix is now included in the last release! Thanks!


text update

a few seconds ago -> just now
to save space.

Where can I see that?
Can't find it

right bottom section of front page.

i just did a search. it is not very trivial fix. let close for now.


Overflow menu motion updates

Overview
This request applies the System 360 motion specs to the overflow-menu -> floating-menu -> collapsible-element components.
overflow-menu

classTransient added
SCSS updated to utilize the collapsible-element component

floating-menu

updated to utilize the collapsible-element component

Global motion variables
The following variables in the following files were changes to the System 360 specs:
// src/components/button/_mixins.scss
$bx--ease-in
$bx--ease-out
$bx--standard-easing
$transition--base

Added
// src/globals/scss/_vars.scss
$bx--ease-in-out

@ibm/motion package
@ibm/motion NPM package was imported as a dev dependency to ensure that the motion definitions are up to date and in sync with other codebases that use the System 360 motion.

added as a dev dependency

a proxy was created under src/globals/js/misc/motion-generator.js

Updated bazier curve and duration

staging URL:
http://carbon-dev-environment-bracteate-akvavit.w3ibm.mybluemix.net/demo/overflow-menu

Thanks for all the help @asudoh.

Hey @wonilsuh , can you put up a staging URL so the designers on our team can review this as well?

@marijohannessen here is a staging URL: http://carbon-dev-environment-bracteate-akvavit.w3ibm.mybluemix.net/demo/overflow-menu

👀 ❗
It looks like the caret at the top of the menu is disappearing before the transition gets to the top. Something about that last millisecond before the menu is closed feels off.

I slowed down the animation using google dev tools and Anna is right, the caret disappears before the menu starts to close. It also looks like a thin piece of the menu is remaining at the end when the box height is decreasing, than fading away after the fact, as opposed to the whole box disappearing in one fell swoop. I think both these issues need to be addressed before it is merged.


audit: --strict --online: "should use HTTPS rather than HTTP" false positive

brew doctor output
Your system is ready to brew.

Verification

[X] My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update twice and am still able to reproduce my issue.
[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output
HOMEBREW_VERSION: 4.1.0-15-g5226cd4
ORIGIN: https://github.com/Homebrew/brew
HEAD: 5226cd434494991fae9da7eb6ab6a3095a16f563
Last commit: 5 hours ago
Core tap origin: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 0a3bd62fb9b444f562f7e4e30dcedab66ed5a913
Core tap last commit: 2 hours ago
Core tap branch: master
Core tap JSON: 22 Jul 01:58 UTC
HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: :0
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 8
Homebrew Ruby: 2.6.10 => /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.10_1/bin/ruby
CPU: octa-core 64-bit skylake
Clang: N/A
Git: 2.41.0 => /home/linuxbrew/.linuxbrew/bin/git
Curl: 7.81.0 => /bin/curl
Kernel: Linux 6.4.4-arch1-1 x86_64 GNU/Linux
OS: Unknown
Host glibc: 2.35
/usr/bin/gcc: 11.3.0
/usr/bin/ruby: N/A
glibc: N/A
gcc@11: N/A
gcc: N/A
xorg: N/A

What were you trying to do (and why)?
What: brew audit --strict --online xz
Why: I was experimenting with brew audit on the most installed formulae and stumbled across it
What happened (include all command output)?
$ brew audit --strict --online xz
xz
  * Stable: The source URL http://archive.org/download/xz-5.4.3/xz-5.4.3.tar.gz should use HTTPS rather than HTTP
Error: 1 problem in 1 formula detected.

What did you expect to happen?
I did not expect the number 1 dependency, xz (365d), to have audit errors, regardless of the flags being used.
Note: I don't know for sure if the same happens with other formulae, but I checked the last box because this seems to be about brew audit not xz so I decided to open the issue here as opposed to homebrew-core.
It seems that the http mirror is an intentional fallback from the url right before it, which is why I think this is a false positive.
$ grep -nC1 'archive.org' "$(brew formula xz)"
5-  homepage "https://tukaani.org/xz/"
6:  # The archive.org mirror below needs to be manually created at `archive.org`.
7-  url "https://downloads.sourceforge.net/project/lzmautils/xz-5.4.3.tar.gz"
8-  mirror "https://tukaani.org/xz/xz-5.4.3.tar.gz"
9:  mirror "https://archive.org/download/xz-5.4.3/xz-5.4.3.tar.gz"
10:  mirror "http://archive.org/download/xz-5.4.3/xz-5.4.3.tar.gz"
11-  sha256 "1c382e0bc2e4e0af58398a903dd62fff7e510171d2de47a1ebe06d1528e9b7e9"

I don't know if --strict --online is expected to sometimes report false positives. It is not clear from the flags' documentation.
...
      --strict                     Run additional, stricter style checks.
...
      --online                     Run additional, slower style checks that
                                   require a network connection.
...

Side note: I was unaware that using the flags in combination runs even more tests. In other words, brew audit --strict xz and brew audit --online xz both pass, but not --strict --online, which is not something I was able to find documented in brew help audit.

The http mirror was added in

xz: add HTTP mirror (https://github.com/Homebrew/homebrew-core/commit/2fbf45c94a7432b6e161a238be1d5a6186436870)
https://github.com/search?q=org%3AHomebrew SHA%3A2fbf45c94a7432b6e161a238be1d5a6186436870

CC @carlocab
Step-by-step reproduction instructions (by running brew commands)
brew audit --strict --online xz

If this is not expected behavior, would it be a viable solution for brew audit --online --strict ... to check if the http url is an intended fallback? Maybe also making sure that the http mirrors are all at the bottom. Thoughts?

Thanks for the write-up @osalbahr. A few notes:

as a general principle: it's somewhat expected that brew audit --strict --online may fail for some stuff in Homebrew/homebrew-core as --strict audits are not enabled by default for that reason.
in this case, though, it's two audits contradicting: https://github.com/Homebrew/brew/blob/3b3300546b5a4e40b74f4ee33cf225cca280defe/Library/Homebrew/resource_auditor.rb#L106-L113 this audit is ensuring that curl's deps do have HTTP mirrors so that curl can be built on older systems lacking new enough certificates or protocols.
given this: you're right that this audit is a false-positive and should invert the curl audit's logic to not complain in those cases

Would you be up for opening a PR to address? Thanks!

Would you be up for opening a PR to address?

Sure! What would be a better behavior? Should the audit handle curl’s deps as a special case and ignore that there are http mirrors?

Should the audit handle curl’s deps as a special case and ignore that there are http mirrors?

Exactly, thanks!

@osalbahr Are you working on a PR for this?

@osalbahr Are you working on a PR for this?

Not currently but I do plan to give it a shot soon.


report sht31_flask_server runtime parameters at program start

print output is not going to the flask server console, need to investigate


Redirect processing more toward the internal 'word problems', less towards drawing the graph

Reduce spasms of the graph and potentially increase performance
The graph seems to be redrawn several times per second, which on my devices looks like it's doubled since it mostly jumps around wildly between two configurations.
I propose to redraw (update) it less frequently, instead focusing a bit more power onto generating ahead new potential elements to also decrease the number of times where a vertex is shown that is actually the same group element as another vertex, thus will be collapsed into the existing graph.

The spasms have been fixed.
But with groups coming from the random graph group functionality the first seconds of the creation are still very violent. We might profit from simulating new nodes without showing them for a few seconds

this also relates to #42

I also reduced the spasms by reducing the time step inverse proportionally to the generator count.

I remove this since we can reduce the presentations.


docs: update documentation for all apps

closes #337
Description

update the main README.md file at the root of the project

Comment

I noticed that some directory don't a readme file but i still referenced them

shared
dashboard_app

@Luluameh Any updates?

hello @djeck1432 I  am on it and will soon make a push


[8.x] Improves type definitions by using generics, generic arrays, callable types, and more

This pull request attempts to show what were the pros and cons if we were to introduce serious strong type definitions into Laravel's core. Now, so people can have an idea of what these represent in terms of work, this pull request only includes:

Partially migrates the Enumerable interface.
Test Enumerable interface type definitions.
Adds CI job that to run type definitions tests.

In terms of advantages, we would of course offer much better native support for Psalm and PHPStan. And also, we would have better native auto-completion in editors like PHPStorm:
Before:

After:

In addition, functions like tap, collect, retry,  and more, would 100% static analyzable and understood by static analysis tools.
Now, in terms of disadvantages, it seems that PHPStorm support for generics is very primitive, so there are a few cases where type inference does not work as expected - like VSCode and TypeScript:
$users->each(function ($user) {
    $user->; // $user is mixed...
});

Another disadvantage is the fact that not everyone is comfortable with this type of annotations. So doing it right - for new/existing contributors - may be a friction point.
Finally, the goal of this pull request is not to have this pull request merged, but rather debate if we plan to have this improved type system across the entire code base or not.

agreed that these stuff are very confusing and add friction. On the other hand if Laravel initiate this movement, it could cascade to a lot of community contribution in educating what are these things and how we use them.

With these type definitions, does PHPStorm know that User::all()->get(0) returns a User? Or does it only know that it's a Model?

@SjorsO With this changes, PHPStorm will infer that User::all()->get(0) will return a User.

agreed that these stuff are very confusing and add friction. On the other hand if Laravel initiate this movement, it could cascade to a lot of community contribution in educating what are these things and how we use them.

The ideal situation is that it doesn't get in the way of new users, but it does help with users that want this. My team relies heavily on static analysis and typesafety, so this would be an awesome addition.
I do agree that it shouldn't add too much friction for new users, but I don't think it's the case with this implementation.

The friction is not for users, but for contributors. Laravel gets a great stream of contributors that would all need to learn how to use these stuff. I don't think there's any friction for users?

The friction is not for users, but for contributors. Laravel gets a great stream of pull requests from people that would all need to learn how to use these stuff. I don't think there's any friction for users?

Not for users, but as long StyleCI points out places where Generics and static types should be pointed, checks would come automatically.
Now, I'm not keen to add type definitions on Laravel 8.x. It should be done and mandatory for Laravel 9.x.

StyleCI is not a static analyzer. It's a fully automated code style fixer. It cannot "point out places that are wrong for a human to fix". StyleCI can only detect things it can fix, and then it goes and fixes them on PR merge.

I do personally think it is in our user's best interest to provide the best type information we can in these situations - so I'm 👍  on improving the DX here.


How to properly use sources for dynamic pages routes?

Details
Brief explanation:
I would like to add some urls that I can generate from a json file to the sitemap.
I'm making a website for an illustrator portfolio, which has some static pages and some dynamic urls for each gallery. The galleries pages have the url "MY_DOMAIN/work/GALLERY_NAME".
The galleries are created from a json file I have in my public folder. Each entry in this json file has the name of the gallery, and each gallery has a folder with images in "/public/galleries/work/GALLERY_NAME", and in "pages" folder I have a file "/work/slug", where the slug is the name of the gallery that I use to get the images from the public folder.
The issue:
Now, I'm trying to figure out how to add the urls to the sitemap. I'm following the guide here without success: https://nuxtseo.com/sitemap/guides/dynamic-urls
What I have done so far
So I created a file /server/api/sitemap/urls.ts with this content:
import { data } from "~/public/galleries/home/data";

export default defineSitemapEventHandler(() => {
  let ret = [];
  for (let i = 0; i < data.length; i++) {
    ret.push({ loc: "/work/" + data[i], _sitemap: "pages" });
  }
  return ret;
});

The endpoint seems to work, because If I go to "MY_DOMAIN/api/sitemap/urls" I can see the list of URLS like this:
[
  {
    "loc": "/work/picture-book-erase-otra-vez",
    "_sitemap": "pages"
  },
  {
    "loc": "/work/la-foto-perfecta",
    "_sitemap": "pages"
  },
  (...and so on)
]

Then in my nuxt.config.ts I have this:
export default defineNuxtConfig({
(...some other options)
  modules: ["@nuxt/image", "nuxt-icon", "nuxt-simple-sitemap"],
  sitemap: {
    defaults: {
      changefreq: "daily",
      priority: 1,
      lastmod: new Date(),
    },
    sources: ["/api/__sitemap__/urls"],
  },
});

However, when I go to "MY_DOMAIN/sitemap.xml" I only see the static pages.
I would think that the api endpoint is being ignored, but I don't think so, because while I was coding the function in "/server/api/sitemap/urls.ts", I got some error messages from fetching the data from mistakes I made in the code, so it seems to be fetched, just the returned array is ignored by the sitemap generator.
Is there anything I'm missing here?

Classic: I figured out the solution right after submitting the ticket.
I only had to remove the "_sitemap": "pages" thing from the function. As I only have one sitemap, I only needed to return an array of strings, so the urls.ts ended up like this:
import { data } from "~/public/galleries/home/data";

export default defineSitemapEventHandler(() => {
  let ret = [];
  for (let i = 0; i < data.length; i++) {
    ret.push("/work/" + data[i]);
  }
  return ret;
});

Hey @molul, thanks for the issue.
I've pushed up a fix so that it won't filter the sitemaps even if you provide a _sitemap for single sitemap configs.

Oh, nice. Thank you :)
I would also suggest adding to the docs (to https://nuxtseo.com/sitemap/guides/dynamic-urls) that the "/api/sitemap/urls.ts" file should be created under /server. That must be pretty evident for someone who already knows Nuxt, but I started not long ago and hadn't worked with the /server directory yet.

Good point, have updated that as I made that mistake in a couple of spots.


Fix stopping unstarted metrics. (#139)

(#139)

+1

Looks good, tests pass.
It might be worth adding an additional quick test_stop_idempotent that checks that mm.stop(); mm.stop() doesn't crash.


Send Random Messages NPC Command Not working.

Running this command does nothing at all even though its in the docs, Please fix as this is a feature i was hoping to use!

Bug still occuring in version 2.0.8

When sendRandomly is disabled, does it send all messages? Is there any error in console when toggling sendRandomly or interacting with the npc?


Fixing a Path Traversal Vulnerability

Hello,
It's possible that you don't use this code in production or the project is not maintained anymore, but we wanted to also increase security awareness and make the public codes more secure when they are being learnt by LLMs. also if it's only for development, securing the server increases security of the developer. Sorry if it bothers you.
We are a group of researchers from Leiden University, and found a vulnerability in your project.
Due to unsafe usage of path.join, this project is vulnerable to Local File Inclusion vulnerability.
You can read more about this vulnerability and its side effects here: https://cwe.mitre.org/data/definitions/22.html
The vulnerable code is at ./examples/browser/server.js file, which you can access online via: https://raw.githubusercontent.com/wavey-ai/mel-spec/HEAD/examples/browser/server.js
If any of path.join arguments is a relative path to the parent directory (../), the returned path can be outside the intended directory and this might lead to leakage of sensitive files.
Running the project:
We used node command to run the file directly: node ./examples/browser/server.js
Verified proof-of-concept(poc) to read passwd file(Path traversal vulnerability):
curl --path-as-is server_address:port/../../../../../../../../../../../../../../../../../../../etc/hostname

Denial of service vulnerability:
We also verified that this vulnerability can also lead to a Denial of Service attack, as it first loads the whole file content into memory, then tries to send the response.
Loading a large file (for example reading /dev/urandom/) can use all the memory within a few seconds and crash the server.
By default, running the vulnerable file opens a port in the network scope. Thus the Attack Vector (AV) of CVSS is: (N)etwork
Impact:
We've calculated the base score of the vulnerability as 9.1, with a severity of "Critical" using following the following vector_string: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:H
You can view the CVSS score online via: https://www.first.org/cvss/calculator/3.1#CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:H
This patch is generated with the help of LLMs, we verified it's working and doesn't break application functionality but still we recommend you verify that it correctly mitigates the bug and doesn't hurt the functionality of your software.
Credits: Jafar Akhoundali and Hamidreza Hamidi
Feedback:
We would like to know your opinion about the quality of this report by filling a really brief survey with 4 questions:
https://leidenuniv.eu.qualtrics.com/jfe/form/SV_4JkS2loxBXVDlum

it was just in an example app but this should be good practice, thanks for the report.


[New Feature]: Made it easier for developers to contribute to winget.

Description of the new feature/enhancement
I have made a Github Action currently in the Github Marketplace which makes it easier for the users to push/submit their packages to this repository as well as made it a lot easier to test the pushing of the package via the workflow and experience how it's going to look like (this is the place where I struggled at the beginning when I want to test my package long ago - so this solution). (just my little contribution to the developers). An example usage is here: https://github.com/gnpaone/MSEdgeRedirect/blob/main/.github/workflows/winget-test.yml
It helps users/developers a lot. Any reviews or suggestions is greatly appreciated.
Proposed technical implementation details (optional)
As I mentioned in here (https://github.com/gnpaone/winget-push-test/blob/master/README.md) default submission will be done to this repository or can try submitting to test repositories before directly submitting here, all done using Github workflow. One example is here: https://github.com/gnpaone/MSEdgeRedirect/blob/main/.github/workflows/winget-test.yml
I did tests to verify the working.
uses: gnpaone/winget-push-test@v1
with:
  url32:
  url64:
  version:
  token:
  packageid:
  user:
  repo:

I viewed the source code and since you are using winget-create, most of the developers will need to tweak their build-installer workflow, until winget-create gets better. Currently MSFT is focusing a little more on winget-cli.

Not sure this is an "Issue", but it's more of a discussion topic

+1 on the discussion topic (you should be able to convert it in the sidebar), but this looks really cool. Thanks!
How long has GitHub let you package Actions that run on Windows only? That was the major reasoning behind https://github.com/microsoft/winget-create/discussions/160

Yah, it's kinda discussion topic.

How long has GitHub let you package Actions that run on Windows only? That was the major reasoning behind microsoft/winget-create#160

The user mentions specifically to run in Windows in Github workflow so those Actions run in Windows only right. Commands like runs-on: windows-latest and shell: powershell

Actually, it is possible to specifically mentioning to run wingetcreate update in linux or macos via Github workflow but runtime will increase by 1-2 mins


_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 27s
master passed

+1 :green_heart:
compile
0m 38s
master passed

+1 :green_heart:
checkstyle
0m 16s
master passed

+1 :green_heart:
spotless
0m 45s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 40s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  9s
the patch passed

+1 :green_heart:
compile
0m 37s
the patch passed

+1 :green_heart:
javac
0m 37s
the patch passed

+1 :green_heart:
checkstyle
0m 14s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 25s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 43s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

26m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4658/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4658

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 63ade4454ef5 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 80b366817e

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-client U: hbase-client

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4658/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[Caching] Use subInvocation to verify interface

The interface verification needs to read some command-line from the interface file so it needs to be built inside sub-invocation.
rdar://122423965

@swift-ci please smoke test

Please test with following pull request:
https://github.com/apple/llvm-project/pull/8165
@swift-ci please smoke test

Please test with following pull request:
https://github.com/apple/llvm-project/pull/8165
@swift-ci please smoke test

Please test with following pull request:
https://github.com/apple/llvm-project/pull/8165
@swift-ci please smoke test

Please test with following pull request:
https://github.com/apple/llvm-project/pull/8165
@swift-ci please smoke test

Please test with following pull request:
https://github.com/apple/llvm-project/pull/8165
@swift-ci please smoke test macOS platform

Please test with following pull request:
https://github.com/apple/llvm-project/pull/8165
@swift-ci please smoke test macOS platform

Please test with following pull request:
https://github.com/apple/llvm-project/pull/8165
@swift-ci please smoke test

Please test with following pull request:
https://github.com/apple/llvm-project/pull/8165
@swift-ci please smoke test

ping


Wrangle data

Looks great to me Kiren! I just changed the path to the parquet files since I changed it in the s3 bucket. We will push it to main so Nikita can get everything compiled!


Charts[Network]: add PVCs for Hedera Nodes

add a shared PVC for leveraging across Hedera nodes so that they can share a downloaded package
add a unique PVC per Hedera node to store its persisted files so that if the pod is killed when it comes back up it will have everything it needs to start back up correctly

required by: https://github.com/hashgraph/solo/issues/89

:tada: This issue has been resolved in version 0.23.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat(TimeDate): If timestamp is more than 24 hours old show date

@akonsowski @clarkjefcoat

@clarkjefcoat

:+1: looks good

:+1:


Roll Engine from 2a76e06247df to 71b9c32b6cc9 (1 revision)

https://github.com/flutter/engine/compare/2a76e06247df...71b9c32b6cc9
2021-11-11<EMAIL_ADDRESS>Roll Skia from ae36ced3cfde to f848782e1fc8 (2 revisions) (flutter/engine#29678)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add ResNetVD presets

Adds the presets for the ResNet_vd variant, including the Kaggle handles. Parameter counts include the classification head.

Please fix the GPU tests

Please fix the GPU tests


update README

@paulmon,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


point out how to install for VSCode noobs like me

@benhutchison Very sorry I didn't see this until now. Thank you for your contribution! Much appreciated!


Please recompress the PNGs

ZopfliPNG is a tool to recompress PNGs. I tried 3 images and saved between 7% and 40% of the size. I don't know if there are better tools available.

Currently, pngquant is used when building the application using Docker (https://github.com/StrandedKitty/streets-gl/blob/dev/Dockerfile#L23). It compresses all textures, reducing the resulting bundle size drastically. Note that it's lossy.


Show image preview in a webview to avoid memory leaks

New description @bpasero
We should try to host binary resources in a webview container instead of inside the renderer because large images can cause memory growing. See https://github.com/electron/electron/issues/6275
Old

VSCode Version: 1.2.1-1.3.0 latest
OS Version: windows(test) most likely all

1- Steps to Reproduce:

Open a folder with 5 or so large images in vscode
click between them quickly
vscode crashes

2- Steps to Reproduce:

Open a project in vscode
Enable tabs
Open some large files quickly and switch between them

Will add further details later e.g. memory usage, dumps etc.. /cc @bpasero (If you want to track)

@eByte23 how large are those images? can you attach the files you use?

@bpasero I can't provide the images as the are client images probably copyrighted also.
But here are the sizes and types

Thanks. And the files you open are all of the same file type and similar size?

Just varying of all those types, it was happening switch between the biggest file in the list to others very quickly

Since this has been like that since day one, and my proposed solution using a webview is rather large, I am moving this to July to investigate further.

I pushed a workaround for now to not add a random number to the image URL when showing the image. This has the benefit of keeping the memory pressure low because we avoid loading the same image over and over. It has the downside that the image will not show any changes if it has been updated. I plan to add an explicit refresh action to the image viewer so that you can still force it to repaint.

Marking as upstream due to https://github.com/electron/electron/issues/6275

In gulp there is a watch functionality for sensing changes in the source code for a given folder/glob (usually for recompiling). Can we use the same technique for updating the cached images?

Verify: images changed outside are reloading in VS Code (both for when the image is active in a tab as well as if inactive and you make it active).

this is still happening to me


The first character of each response will appear repeatedly.

Describe the bug
The first character of each response will appear repeatedly.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Additional context
Add any other context about the problem here.

Hi, what provider are you using and can you provide a little more context?

The first word "it" appear repeatedly, v1.4.0+llama3:8b

Can you try testing it with some hosted LLM providers like OpenAI or Groq?

sorry , i havn't their api key


[feat]: Option to turn on allow-self-payment

Prerequisites

[X] I have searched for existing issues that already suggest this feature.

Describe the Feature Request
I am trying to use lnbits with LND, but in order for me to fund my lightning wallet using the funds already on my node, LNBits documents say that I must enable 2 options
https://github.com/lnbits/lnbits/blob/main/docs/guide/faq.md
Funding my LNbits wallet from my node it doesn't work.
If you want to send sats from the same node that is the funding source of your LNbits, you will need to edit the lnd.conf file. The parameters to be included are:
allow-circular-route=1
allow-self-payment=1
I can find an option to enable the circular route, but I cannot find an option to allow-self-payment. When I SSH and modify the lnd.conf manually, it wipes it and replaces it when I restart the service.
Describe the Use Case
Trying to load sats from my own lightning node running LND, to a wallet on LNBits on the same node.
Describe Preferred Solution
Enable a toggle like allow circular route but for allow self payment.
Describe Alternatives
No response
Anything else?
No response

Self payment is not required to fund a wallet with your underlying lightning node.
You can fund any wallet by opening the Superuser Account (found in LNbits Properties) then navigating to "Manage Server" > "Topup". On the resulting form, the "Wallet ID" will can be found in LNbits Properties as the last query param of your desired wallet url, and it will be preceded by "wal=".

Self-payment I believe is a requirement for continual funding on a LNBits wallet (think hosting a wallet for family members, and using it to pay them for chores - they create an invoice, I pay it with funds from my own node - except it has to LEAVE my node first to just come back to it - which causes fees).
An option within the GUI to enable this as an option is what I'm asking for, not that the code is written to actually do this. It shouldn't be difficult to enable this.

While that is one way LNbits could be used, routing payments as a rebalance creates unnecessary fees when the funds don't actually need to leave the underlying node. LNbits is like an accounting layer on top of the chosen LN implementation. It doesn't make much sense to route a LN tx through other nodes just to send those sats back to the same node when LNbits can simply edit the accounting layer database and decrease/increase the appropriate wallet balances.
Continual funding of a LNbits wallet can work in several different ways without the need for allow-self-payments=true:

A LNbits wallet can receive funds from any other LN node (provided the underlying node has sufficient inbound liquidity).
Additional funds can be allocated to an LNbits wallet using the Superuser user (the method I detailed in my previous comment).
One LNbits account can pay another LNbits account without allow-self-payments=true even though they are on the same node as long as it is another LNbits account paying the invoice.

If you are using multiple LNbits wallets for family members, any of the above methods should allow paying a family member and increasing their LNbits wallet balance without the need for allow-self-payments=true or paying the associated fees. That said, it is not apparent to me why self-payment would be a requirement for continual funding of a LNbits wallet.


Add processing of meds-transform data to the integration tests

We currently have a script that generates MEDS data and JNRTs from raw CSVs of dummy EHR data. We can integrate this into the meds_dir package level scope pytest fixture that sets up the input data directories.
Currently, the meds_dir fixture just copies the MEDS data and JNRTs from the GitHub repo to a temporary directory. Instead, we can directly transform the data from raw dummy CSVs to MEDS data and JNRTs in the temporary directory once at the beginning of each pytest call.
To implement this, we would move a single call to tests/helpers/generate_test_data.sh to the beginning of this fixture.
Thoughts @mmcdermott?

I think this is essential. Right now, there are > 100 files of just sample data that you rely on in tests, which significantly complicates the repository and introduces brittleness. I don't think you necessarily want to generate all data on every test, though -- rather; what would be better is either adding the data generation step to the github workflows for the integration test, so it happens before any tests are run, or simplifying the sample data so that it will not add any time costs and / or simplifying the integration tests so fewer tests need these files.


align dropdown groups with PF styles

Fixes
https://issues.redhat.com/browse/HAC-2970
Description
Updated action menu groups to use PF styling.
See examples here: https://www.patternfly.org/v4/components/menu
Type of change

[ ] Feature
[x] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review
before:

after:

How to test or reproduce?

Browser conformance:

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

/lgtm


Error in bin/console product-export:generate  ..."is not in list of available languages"

PHP Version
8.1.16
Shopware Version
6.4.20
Expected behaviour

Using CLI command bin/console product-export:generate <sales-channel-id> to generate xml-export file for product comparison sales channels
Possibility of using sheduler / cron

Actual behaviour
CRITICAL
[console] Error thrown while running command "product-export:generate 413ccac257b04d9cb80f5c0ead3a32c4".
Message: "Provided language 2fbb5fe2e29a4d70aa5854ce7ce3e20b is not in list of available languages: " ["exception" => RuntimeException { …},"command" => "product-export:generate 413ccac257b04d9cb80f5c0ead3a32c4","message" => "Provided language 2fbb5fe2e29a4d70aa5854ce7ce3e20b is not in list of available languages: "]
In BaseContextFactory.php line 336:
Provided language 2fbb5fe2e29a4d70aa5854ce7ce3e20b is not in list of available languages:
How to reproduce

configure product-comparison sales channel, linked to main domain, with working dynamic group
preview and test xml export in template backend > success
generate export by visiting export-url and check generated file in folder ../files/export/ > success
find product-comparison sales channel id with bin/console sales-channel:list
try to generate export with bin/console product-export:generate <sales-channel-id>

Extra steps:

try manually linking the product-comparison sales channel with the missing language in the database under sales_channel_language
receive new error message: In ProductExportGenerateCommand.php line 65:  No matching sales channel found.

Similar issue: https://issues.shopware.com/issues/NEXT-25958

Hi,
thx for your issue we will put it into our new evaluation process and have a look at it again.

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-37928.
[created from NEXT-37928, comment 488866]


Is "set_autopilot" working according to Route Planner?

Hi,
CARLA version: 0.9.11
Platform/OS: Ubuntu18.04
I tryed the following.

I started UnrealEngine and deleted all route planner.
Press the play button in UnrealEngine.
Started a new terminal and run spawn_npc.py.

My guess was that vehicles would stop or go out of control because I removed the route planner. But vehicles ran fine.
Is the car following the route planner? Please teach me.
Thank you!!

I guess it made in blueprint.
 // carla/Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Vehicle/WheeledVehicleAIController.h
  /// Set a fixed route to follow if autopilot is enabled.
  UFUNCTION(Category = "Wheeled Vehicle Controller", BlueprintCallable)
  void SetFixedRoute(const TArray<FVector> &Locations, bool bOverwriteCurrent = true);


Update to Rust 1.45

Tag docker image as 0.9.0.
This is needed to compile 0.10.0-prerelease contracts as the changes for Binary::from need 1.44.1+

@ethanfrey can you tag and upload this?

I try to do it on my own …

Done https://github.com/CosmWasm/rust-optimizer/commit/dfcefa21e7f81c6be6d4792e94bc5e44c8f471f5 https://hub.docker.com/r/cosmwasm/rust-optimizer/tags


chore: upgrade vite/storybook/nx

TODO

ClientDecorator isn't working with latest storybook

copilot:all

Current dependencies on/for this PR:

main

PR #3081   👈

This comment was auto-generated by Graphite.


Sign multisig inputs with Trezor

Currently the Trezor implementation does not support signing multisig inputs. It would be nice if it did.

There seems to be: https://github.com/trezor/trezor-core/issues/388
It's needed for coinjoins or proofs-of-reserves.


Basic implementation of Rotex/Daikin S protocol

Working on my older Rotex RDLQ014AA6V3 unit.
All fields are not identified yet...
This should fix https://github.com/raomin/ESPAltherma/issues/46 and https://github.com/raomin/ESPAltherma/issues/74 (too bad it took me so long to finalize this change, looks like we did stuff in parallel).
My unit is quite old and doesn't have a lot of fancy sensors. I'm not sure of all the meanings either, but graphs look "quite OK" (some strange spikes sometimes, probably some logic to add to limit cases).

That is great job @agrenott, bravo et merci!
I'll review this and merge it asap.


Minor fixes plus reformat to one-sentence-per line

Some minor fixes (and a line or two of new content) here and there; also reformats the whole document to one-sentence-per-line style for better version control with GitHub. Also some responses to comments.
@JIMonroe review?

Looks good!  Thanks, from now on it should be a lot easier to see changes.


Server group targeting fails (add used on list instead of append)

Targeting to dynamic clusters seems to still be WIP but even if you currently try to do so, it bails out early and crashes on a call to add() in wlsdeploy/tool/util/target_helper.py.
It seems the target is supposed to be added to 'cluster_members' on line 360
https://github.com/oracle/weblogic-deploy-tooling/blob/3058d27259e74577a84a8ae0e0acd071d79553bd/core/src/main/python/wlsdeploy/tool/util/target_helper.py#L360
but a call to 'add' is used instead of 'append', resulting in an AttributeError.

Fix will be included in the next release. WIP

Merged into master. Available in next release. Please view known issues document

Fixed by #396


redo setup.py to be compatible with newer setuptools, fix latest black suggestions

Codecov Report

Merging #174 (96ec720) into main (fc29df3) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   76.86%   76.74%   -0.12%
==========================================
  Files         110      110
  Lines        5493     5505      +12
  Branches      714      714
==========================================
+ Hits         4222     4225       +3
- Misses       1114     1126      +12
+ Partials      157      154       -3

Impacted Files
Coverage Δ

tributary/streaming/graph.py
73.13% <ø> (-2.99%)
:arrow_down:

tributary/streaming/input/http.py
26.92% <ø> (ø)

tributary/streaming/input/kafka.py
19.04% <ø> (ø)

tributary/streaming/input/ws.py
11.68% <ø> (ø)

tributary/streaming/node.py
88.55% <ø> (-1.00%)
:arrow_down:

tributary/streaming/output/text.py
46.15% <ø> (ø)

tributary/tests/streaming/test_utils_streaming.py
97.43% <ø> (ø)

...utary/tests/lazy/calculations/test_finance_lazy.py
100.00% <100.00%> (ø)

...s/streaming/calculations/test_finance_streaming.py
95.45% <100.00%> (+0.71%)
:arrow_up:

... and 2 files with indirect coverage changes


Usecase for triggering a rule at a certain time everyday

Description:
I have a usecase where we want a sql to run at a certain time everyday depending on different timezones. I see that we have triggers, but they are for injecting events and not for when to run the sql.
For eg.
I want to detecting missing events for 5 minutes and want this to be triggered at 2pm PST everyday. Documentation doesn’t have details related to this.
from not inputStream[key == "1234"]  for 300 sec select "1234" as key insert into outputStream
Note: I need this to be run at a specific time everyday since this rule sends out alerts only once and we have certain logic in place to filter out the alerts based on inactive time.
Is it possible to have a query that does the following?
from not inputStream[key == "1234"]  for 300 sec select "1234" as key insert into outputStream  RUN_AT <TIME> TIMEZONE <TIMEZONE>
Affected Siddhi Version:
OS, DB, other environment details and versions:
Steps to reproduce:

Related Issues:

I can help to solve this issue @madhurijain97

steps to solve this issue 👍
" First step "
To achieve running a SQL query at a specific time every day based on different timezones in Siddhi, you can use the "corn" scheduler along with Siddhi's 'window' and 'trigger' extensions. Unfortunately, Siddhi does not directly support executing queries at specific times with time zones out of the box, but we can work around this limitation.
"Second step"
Here's how you can achieve your use case:

Define a trigger that fires at a specific time every day in the desired timezone.
Use a window to detect missing events for a certain duration.
Use the trigger to start the window processing at the specified time.

Here's an example Siddhi application to illustrate this:
@App:name("MissingEventDetectorApp")
@App:description("Detect missing events and trigger an alert at a specific time every day in different timezones")
define stream InputStream (key string);
define stream OutputStream (key string);
-- Window to detect missing events for 5 minutes (300 seconds)
-- Adjust the duration based on your requirements
from every e1 = InputStream[key == "1234"] -> e2 = InputStream[key == "1234"] for 5 min
select e1.key as key
insert expired events into MissingEventStream;
-- Define your alerting logic here, for simplicity, let's just log the missing event
from MissingEventStream
select key
insert into AlertStream;
-- Trigger to start window processing at 2 PM every day in PST timezone
-- Adjust the cron expression and timezone according to your requirement
@info(name = 'Trigger')
from every cron: 0 0 14 ? * * *  America/Los_Angeles
select currentTimeMillis() as triggerTime
insert into TriggerStream;
-- Start the processing of the window at the trigger time
from TriggerStream#window.time(1 sec)
join MissingEventStream
select triggerTime, key
insert into FinalAlertStream;
note
In this example:
The InputStream stream represents your input data.
The MissingEventStream stream captures events where the key "1234" is missing for 5 minutes.
The AlertStream stream represents the alerts for missing events.
The TriggerStream stream generates a trigger event at 2 PM every day in the PST timezone.
The FinalAlertStream stream captures the final alerts triggered by combining the trigger events and missing event detections.
note
Remember to adjust the cron expression, window duration, and timezone according to your specific requirements. Additionally, you may need to implement your own logic for handling alerts based on inactive time.


Add method to submit raw JSON to clients

When working with advanced features that aren't on the ledger yet (e.g. NFTs, hooks, sidechains), you'd need to create your own models. But you can't use new models in the existing system.

Turns out you can do this by using req = xrpl.models.requests.request.Request.from_xrpl(req_dict). However, this is a bit quirky as the req_dict argument needs to be in approximately WebSocket format, except with a method field instead of command. For example:;
import xrpl
with (xrpl.clients.WebsocketClient("wss://s.altnet.rippletest.net:51233") as client:
    req = {
            "method": "account_info",
            "account": "rPT1Sjq2YGrBMTttX4GZHjKu9dyfzbpAYe",
            "ledger_index": "validated"
        }
    client.send(req)

I ended up writing my own solution: https://github.com/XRPLF/xrpl-py/blob/sidechain/xrpl/asyncio/clients/client.py#L46

Resolved by #313


Double trouble ... with 2 toc instead of 1

Any idea why the table of contents doubles?

These are my settings:

Here is the complete file content:

aliases: [Icons]
tags: [Icon, Folder, File]
Dateiname: Plugin supercharged links.md
filename: Plugin supercharged links
filenamemd: IT Grundlagen/MD Anleitungen/Obsidian Tricks/Obsidian plugins/supercharged links/Plugin supercharged links.md
filenamemd2: P:\Obsidian/IT Grundlagen/MD Anleitungen/Obsidian Tricks/Obsidian plugins/supercharged links/Plugin supercharged links.md
template: [TEMPLATE Neue Notiz]
number headings: first-level 2, max 6, 1.1, auto, contents ^toc
erstellt: Samstag, 28. Januar 2023, 18:20:33 Uhr
geändert: Samstag, 28. Januar 2023, 18:29:13 Uhr
Plugin supercharged links
Links

[[#Plugin supercharged links|Plugin supercharged links]]
[[#Inhaltsverzeichnis ^toc|Inhaltsverzeichnis]]

[[#1 Einstellungen|1 Einstellungen]]

Inhaltsverzeichnis ^toc

[[#Plugin supercharged links|Plugin supercharged links]]
[[#Inhaltsverzeichnis ^toc|Inhaltsverzeichnis]]

[[#1 Einstellungen|1 Einstellungen]]

1 Einstellungen
![[2023-01-28-superchared-links-settings.png|900]]

Thank you for trying.
When I delete the line number headings: first-level 2, max 6, 1.1, auto, contents ^toc from yaml, the table of contents appears only once.
Do you have any idea, what I can do to narrow down the isue? I suspect the problem has something to do with my other plugins.
 Just came back to this, and I am still unable to reproduce it.


Desktop.Fixed menu: Mismatch with design

Needs to remove underlining after you hover on menu items
Pay attention on screenshot

Tested


Ignore migration that no need to green

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6e76417). Click here to learn what that means.
 Consider uploading reports for the commit cdab734 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff            @@
##             main        #4   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         7
  Lines           ?       186
  Branches        ?         0
========================================
  Hits            ?       186
  Misses          ?         0
  Partials        ?         0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


JWTs issued by application registration created through graph client doesn't contain oid

Describe the bug
I tried two ways of creating an "App registration" in my Azure Active Directory. First, I tried

where I set the default values in the config

Then I create a client secret, and I use it to log on an application like this:
request_data = {
            "grant_type": "client_credentials",
            "client_id": active_directory_user.client_id,
            "client_secret": active_directory_user.client_secret,
            "scope": f"{authentication_app_id}/.default",
        }
token_data =requests.post(url=f"https://login.microsoftonline.com/{tenant_id}/oauth2/v2.0/token", data=request_data)
token = token_data["access_token"]

The access token (JWT) I then get is filled with many data, like this:
    payload = {
            "aud": ...,
            "iss": ...,
            "iat": ...,
            "nbf": ...,
            "exp": ...,
            "aio": ...,
            "azp": ...,
            "azpacr": ...,
            "oid": ...,
            "rh": ...,
            "sub": ...,
            "tid": ...,
            "uti": ...,
            "ver": ...,
        }

Note that this JWT payload contains the oid.
Now, I want to create the Application registration programmatically. For that, I use the GraphClient like so:
client = GraphClient(
        credential=my_credential
    )
# 1. create application registration
payload = {
	"displayName": application_name,
	# is this necessary?
	"requiredResourceAccess": [
		{
			"resourceAppId": "00000003-0000-0000-c000-000000000000",
			"resourceAccess": [
				{"id": "e1fe6dd8-ba31-4d61-89e7-88639da4683d", "type": "Scope"}
			],
		}
	],
	"signInAudience": "AzureADMyOrg",
}
res = client.post(
	"/applications",
	json=payload,
)
res.raise_for_status()
json_data = res.json()

# 2. create secret
object_id = json_data["id"]
payload = {"passwordCredential": {"displayName": "secret-for-testing"}}
res = self._graph_client.post(
	f"/applications/{object_id}/addPassword",
	json=payload,
)
res.raise_for_status()
json_data = res.json()
client_secret = json_data["secretText"]

When I then log on as previously, by posting to https://login.microsoftonline.com/{tenant_id}/oauth2/v2.0/token, I get a token of this kind:
{
  "aud": "e75d4c89-6917-4398-a75c-fcb26031dc51",
  "iss": "https://login.microsoftonline.com/c12007a4-882b-4381-b05a-b783431570c7/v2.0",
  "iat":<PHONE_NUMBER>,
  "nbf":<PHONE_NUMBER>,
  "exp":<PHONE_NUMBER>,
  "aio": "E2ZgYFjuPXHFXxGtdWH3UjcU/p/eAwA=",
  "azp": "1eae7cde-4237-4a7e-bfc8-f91dfedd6353",
  "azpacr": "1",
  "rh": "0.ARMApAcgwSuIgUOwWreDQxVwx4lMXecXaZhDp1z8smAx3FETAAA.",
  "tid": "c12007a4-882b-4381-b05a-b783431570c7",
  "uti": "A0ImoHtleUWHsIAUTnnMAA",
  "ver": "2.0"
}

And here we see that there is no oid. I compared the manifest of both application registrations and they look the same.
Expected behavior
I expect to also get an oid in my JWT when I log on my application with my client id / secret produced programmatically.
What am I missing?

When I run
az ad app create --display-name "my-test-app-from-cli" --sign-in-audience AzureADMyOrg

or
az ad app create --display-name "my-test-app-from-cli" --sign-in-audience AzureADMyOrg --required-resource-accesses @manifest.json

with
#manifest.json
[
  {
    "resourceAppId": "00000003-0000-0000-c000-000000000000",
    "resourceAccess": [
      {
        "id": "e1fe6dd8-ba31-4d61-89e7-88639da4683d",
        "type": "Scope"
      }
    ]
  }
]

then I get the same result. My JWT does not contain the oid.

The problem is not related to this particular repo. However, let me share the solution, for the sake of completeness. Here's everything needed to make the oid happen in the resulting JWT. Key is to create a service principal, which I wasn't aware is done automatically when doing the same operations manually on azure portal:
app_reg=$(az ad app create --display-name my-test-app-registration --sign-in-audience AzureADMyOrg)
client_id=$(echo $app_reg | jq -r '.appId')
object_id=$(echo $app_reg | jq -r '.id')

echo "client_id: $client_id"
echo "object_id: $object_id"

client_secret=$(az ad app credential reset --id $client_id --append --display-name "my secret" --query password --output tsv)
echo "client secret: $client_secret"

# this is what I was missing
az ad sp create --id $client_id
sp_id=$(az ad sp show --id $client_id | jq -r '.id')
echo "sp_id: $sp_id"

# perform log on
curl -X POST https://login.microsoftonline.com/${MY_TENANT_ID}/oauth2/v2.0/token \
  -d grant_type=client_credentials \
  -d client_id=$client_id \
  -d client_secret="$client_secret" \
  -d scope=${MY_AUTH_APP_ID}/.default

Thanks for the update @zadigus


Cannot set orientation on android api 31

Software Versions

Python:3.10
OS:android
Kivy:
Kivy installation method: Buildozer

Describe the bug
A clear and concise description of what the bug is.
The issue tracker is a tool to address bugs only (search known bugs: https://git.io/vM1iE).
Please use the #support Discord channel at https://chat.kivy.org/ or Stack Overflow for
support questions, more information at https://git.io/vM1yQ.
Cannot set orientation to landscape mode, the result on android devices always be All orientation

How are you trying to set the orientation?

I did some investigation, and I found out what's the issue.
We're now tracking it on python-for-android (you'll also find a tested workaround): https://github.com/kivy/python-for-android/issues/2724


CLDC-1166: Include guidance partial on both income questions

We want to show the guidance about what counts as income on both questions that ask for the household’s total combined income.

Adding the partial to the first questions means we need to add a page title separate from the fieldset’s legend to keep the complexity low when form is announced by screen readers.
Page titles should be unique

This is the result:

Household’s combined income after tax
▶ What count’s as income?
Do you know the household’s combined income after tax?

Total household income
▶ What count’s as income?
How much income does the household have in total?
How often does the household receive this amount?

Before
After

@Dan13L3 Thoughts?

@paulrobertlloyd Looks clear to me!


Display: flex causes overflow

I want to inline the label and the rte. So I tried using a flexbox however that causes the rte to overflow rather than new line.

I used your sample code but both the editor and the h1 tag are displayed inline as expected. Could you try installing the latest version and override the root class of the editor? Check out the theme example for more details on how to override the style. If you still have a rendering problem please feel free to reopen the issue.

Sorry, I gave a bad example.
The issue occurs when the parent div is this:
<div style={{ display: "flex", flexDirection: "row" }}>
and the text being typed has no spaces.
Example: SomeGiantText pasted 20 with no spaces.
Expected Behaviour
When typing the above text to new-line when the text reaches near the edge of the container.

Actual Behaviour

You can see it overflows with the horizontal scrollbar.
Codesandbox

I've just opened your CodeSandbox sample, pasted the text more than 20 times as well as input a random long string without spaces and in both cases the result behaviour is as expected. By default the width of the editor is same as its parent and the content is wrapped correctly.


feat(core): make loopback edges appear nicely

🚀 What's changed?

Loopback edges (same source and destination) now render nicely
Original:

New:

🐛 Fixes

Loopback edges previously were invisible as they rendered behind the node. This routes the edge around the left side.

🪴 To-Dos

This currently only works for default handle positions. I don't know if you're willing to merge this without generic support for all nodes, but IMO it's better than the current default behavior.

Hey, thanks for the PR.
As you mentioned, I'd rather have a "fix" for this that applies to all edge types instead of just smoothstep edges.
I'll give it a look though and if possible add it to one of the next minor releases :)

Ok, adding regular step edges is trivial, and I could probably figure out something for bezier

Ok, I just updated my PR. Bezier edges and horizontal handles now work correctly.

I might have to reject this PR, solely on the basis that all edge utils will be removed from this repo in favor of @xyflow/system (the base pkg on which React Flow is going to be built, in "beta" currently but a PR for integrating the pkg exists #1017)

I'm closing this PR in favor of a docs example to create this.
If a loopback default is added at some point I'll come back to you 😄


When a movein is performed, the resulting market metering point is missing the StartOfSupplyDate

Current Behavior

When a movein is performed on a new metering point (in MR domain), the market metering point in the MP domain is created, but the StartOfSupply date is null. The date is sent in the integration event.
Expected behavior

StartOfSupply date should be set
How to reproduce

Create a new metering point in the MP domain.
Insert a new accounting point in the Market Roles domain with the same metering point ID & the same GSRN number.
Perform a movein on the newly established accounting point.
Verify the newly created market metering point in the metering point domain.

Environment

U

It does not appear the integration event receiver receives any events when a change of supplier event is sent out. I cannot see it in the trace or invocation log.


Colored text is not colored in messages

Checklist

[X] I have used the search function to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

App version
8.0b1
Where did you get the app from?
Other
Android version
12
Device model
Moto g(200)
Steps to reproduce

Open a message with colored text

Expected behavior
The colors show be shown as here from the fairmail app:

Actual behavior
The text is not colored:

Logs
No response

It looks like the K-9/Thunderbird version has been converted to plain text, while Fairemail is showing HTML. Do you have any settings around forcing plain text email? Is this just viewing email, or responding to it?

I didn't explicitly forbid HTML or set any other restrictions. You can see in the screenshot, that it's not plain text. The footer is normal text, the difflike structure is verbatim, and the head is bold and larger.


Add infrastructure for integrating BTOR2 interpreter into Calyx

Add the BTOR2 interpreter along with infrastructure necessary for integrating the interpreter with Calyx. I also created a dummy BTOR2Add primitive that reads a hardcoded program from disk and tested it against Cider 2 to ensure correctness of the integration.

This has a lot of generated files (.btor2). Is that intentional? CC @EclecticGriffin

This has a lot of generated files (.btor2). Is that intentional? CC @EclecticGriffin

Ah; those files were tests from the old repo I imported the interpreter from. I can remove/refactor those.


Rails STI

I have class Payment < ActiveRecord::Base and class Osmp < Payment.
When I osmp = Factory(:osmp) then I got error ActiveRecord::SubclassNotFound:

The single-table inheritance mechanism failed to locate the subclass: 'type'. This error is raised because the column 'type' is reserved for storing the class in case of inheritance. Please rename this column if you didn't intend it to be used for storing the inheritance class or overwrite Deal.inheritance_column to use another column for that information.

This is a bug or something I did not do so?

If you're using STI with factory_girl, you'll need to override the build_class or avoid child factories, since child factories share a build class with their parent by default.
FactoryGirl.define do
  factory :payment do
    # common fields
  end

  factory :osmp, :class => 'Osmp' do
    # osmp-specific fields
  end
end


Indirect infinite recursion doesn't get prevented

Pre-requisites

[X] I have double-checked my configuration
[X] I can confirm the issues exists when I tested with :latest
[X] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?
With a workflow which recurses the controller will attempt to recurse forever. Take the recursion example from the documentaton and make it always coinflip for an example.
It feels like this should be prevented by having a configurable maximum recursion depth.
Version
Current master
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: recursive2-
spec:
  entrypoint: coinflip
  templates:
  - name: coinflip
    steps:
    # flip a coin
    - - name: flip-coin
        template: flip-coin
    # evaluate the result in parallel
    - - name: heads
        template: coinflip              # call heads template if "heads"
        when: "{{steps.flip-coin.outputs.result}} == heads"
      - name: tails                     # keep flipping coins if "tails"
        template: coinflip
        when: "{{steps.flip-coin.outputs.result}} == tails"

  - name: coinflip
    script:
      image: python:alpine3.6
      command: [python]
      source: |
        import random
        result = "heads" if random.randint(0,1) == 0 else "tails"
        print(result)

  - name: heads
    container:
      image: alpine:3.6
      command: [sh, -c]
      args: ["echo \"it was heads\""]

Logs from the workflow controller
Not interesting

Logs from in your workflow's wait container
Not relevant

Perhaps some additional checks can be specified in the when condition?

Perhaps some additional checks can be specified in the when condition?

The actual workflow here isn't the problem, it's an obvious case which will recurse indefinitely. I'm really looking at trying to stop much more complex workflows where the recursion isn't obvious from inspection, but the outcome of chewing up resources is undesirable.
#4180 has thought about this problem before and a fix wasn't agreed on, but the basic problem does remain and does happen in the real world.

I'm pretty sure there is a depth check to prevent recursing down templates forever. It might not be configurable but I recall adding it.

@alexec Any context around closing https://github.com/argoproj/argo-workflows/pull/4193 and https://github.com/argoproj/argo-workflows/issues/4180? Was it a matter of prioritization? Now that we have more contributors willing to contribute, we may want to revisit.

@jessesuen Yes the existing check is only for nested workflow templates.

@terrytangyuan, @alexc - Would a resurrection of an updated #4193 be acceptable as a resolution to this? I can't find the check for nested workflow templates - can someone point me at it?

@terrytangyuan @alexec - did y'all have a chance to see @Joibel's message above? I'd also nominate this to be a P2 or a P1 given that #4180 was a P1 and a P2 before being closed

Yeah we should at least provide a configuration to prevent this. I don't know why the PR got closed. Alex would have more context.

I can't find the check for nested workflow templates - can someone point me at it?

@Joibel You removed it in https://github.com/argoproj/argo-workflows/pull/10785. What was the reason behind it?

Yeah we should at least provide a configuration to prevent this. I don't know why the PR got closed. Alex would have more context.

I can't find the check for nested workflow templates - can someone point me at it?

@Joibel You removed it in #10785. What was the reason behind it?

I removed it because it didn't do anything any more, and I didn't realise that we still wanted it.
depth was always zero as it was passed as a literal 0 only.

Closing this out now that #11646 has been merged


Terminal plugin: Select folder/working directory for Run Command in Shell

Feature request for the Terminal plugin.
The Run Command in Shell action can currently only be run in the root (/) directory.
Please consider adding two variants to enable selecting a folder to be used as the working directory (equivalent to "cd directory ; command"), either before or after typing the command:

Folder as object -> Run Command in Shell Here... -> text command as argument

And for the existing use case with text as the object,  allow an optional argument for "in folder" (like the Create File action)
2. Text as object -> Run Command in Shell [...]  -> (optionally) in folder
Ideally, I'd wish to be able to specify a working directory for all of the actions provided by the Terminal plugin (Run, Run in Terminal, etc.) but most of these already make use of the third pane for optional text arguments — I'm not sure how the workflow could work.  If there is a paradigm that would make it possible to start with a folder as context for the other actions (something like "Search Contents"?), without losing the ability to specify optional arguments, and/or to specify a folder after the command is fully specified, those options would be worthwhile for the other Terminal actions as well.

This seems reasonable and can be implemented. I would not implement the following, as it seems too specialised.

specify a working directory for all of the actions provided by the Terminal plugin

However, if this is required then you could just set up a trigger to open up Quicksilver with "Folder" → "Run Command in Shell Here..." → [blank] then type your command.

Still relevant