How to catch ECONNREFUSED?

In Node.js, when using the request function of the http module, you can subscribe to the error events of the returned object, such as:
var http = require('http');

var req = http.request('aaa.bbb.ccc.ddd', function (res) {
  console.log(res.statusCode);
});

req.on('error', function (err) {
  console.log('###');
});

req.end();

When I run this with a non-existent IP on Node.js, everything is fine, and the result is ### printed to the console.
When I run this using http-browserify in Chrome, I get an uncaught exception. Am I doing something wrong?

I believe you will have to listen to the window for these uncaught network errors and decide what to do with them.


How do I move the listview to the specified position or how to dynamically calculate the height of the position line?

I think this can help you :)https://github.com/debuggerx01/rect_getter;
this lib can dynamically calculate the height of the listview item.

This is a question better suited for StackOverflow, since there doesn’t seem to be anything wrong with Flutter itself. Closing, as this is not an issue report. See https://flutter.dev/community for support options.


Update index.md

Thanks for sharing! Let me make a section for Elementary school math and I'll merge and add under there. Thanks again!


Security Issue

Hello,
There's a security issue in the custom node that i'd like to discuss. Where's the most suitable place to reach you?
Thanks, Raul.

Hello,
I'm highly interested in some of these nodes (especially the distanceTransform one) but also too scared of the security issue to install them. Is there any plans to bring them to safety ?
Best, Nicolas

Hi, @ncl-mars,
That I am aware, the potentially risky nodes are the ones that use eval, or, eventually, some early node categorized under API.
As long as you are downloading and running workflows with such nodes, it should be safe.
DistanceTransfrom is just a wrapper node for the openCV function, so it should be fine.
In the future, I might migrate such nodes into a separate repo, but, as of right now, I've stopped updating this repo as I have other priorities.
If the OP - @supriza  - can disclose any additional problematic nodes, I will add them to the list of nodes to migrate.
Best Regards

Thank you very much for your quick response !
Really I would only use the distanceTransform node from your pack, since I can't find any other package having such method for computing SDFs.
Is it okay to download it from the manager (dev branch) or is it better to take it directly from the repo?
Thanks


Matt Bauer

Training images for depth track detection.

@y0y0loach I've been an absent maintainer, but planning to restart working on this. This looks like some nice rasters for finding the depth tracks -- any ideas on how we could get labels for this data?

I am thinking I'll probably just merge since it doesn't conflict with anything and it's data, but thought it's worth asking here first...


Refactor area estimation

Added:

Refactored estimation code from area_utils.py and using Olofsson et al., 2014 "Good Practices...".
Unittest for comparing area estimates using new refactored code against prior estimates computed outside of repo (using corrected Olofsson's excel tool) for Liaoning, China 2017 (crop area) and toy example in Olofsson et al., 2014 (change area).

Addressed/Fixed:
The following are fixed with the refactored code added:

Fixed RuntimeWarning: overflow encountered in long_scalars that could happen previously in computing $V(P_i)$ with large pixel marginals by using NumPy library and specifying uint64 dtype.
Fixed mistake from Oloffson excel tool in computing $V(P_i)$ where expr_2 was incorrectly calculated with the producer accuracy $P_0$ for each class $c_{i}$ regardless.
Fixed mistake in compute_area_estimate from area_utils.py where expr_2 for $noncrop$ was also being calculated using $P_{crop}$ instead of $P_{noncrop}$.
Fixed mistake from Oloffson excel tool in computing $V(P_i)$ where expr_1 for $c_{1}$ was incorrectly calculated using the marginal total of reference samples instead of mapped units.

Notes/Comments:
Items addressed here in this PR that relates to #245.

[x] Adapt existing notebook to use util functions

The refactored estimation code should be easily adaptable into each notebook without needing any modification to the functions. But both notebooks were left untouched w/ this branch work.

[x] Add code for computing area estimates from confusion matrix (was not in notebook previously)

The refactored estimation code is pulled outside of notebook and works for both area and change area type confusion matrixes.

[x] Test by comparing change area estimates for Tigray computed using this notebook and prior analysis (outside repo) Liaoning, China 2017 and toy example in Olofsson et., al 2014.

Implemented unittests for area estimation comparison with prior work that was done outside of repo using the excel tool (after correcting for mistakes 2 and 4 in excel sheet).

[ ] Test by computing change area estimates for new ROI (e.g., Bure or Jimma)

Not addressed.
Remaining TODO Items:

[x] Implement compute_area_estimate function that does entire end-to-end area estimate calculation from just the confusion matrix and marginal pixels and area.
[x] Integrate existing area estimation notebooks with newly refactored code.
[x] Merge area_utils.py with area_utils_refac.py
[x] Delete area_utils_refac.py after merge

3. Fixed mistake in compute_area_estimate from area_utils.py where expr_2 for noncrop was also being calculated using Pcrop instead of Pnoncrop.

https://github.com/nasaharvest/crop-mask/blob/f523fe21cf7709180810514626ade24740ee83d6/src/area_utils.py#L390-L397

@bhyeh This is excellent! Well done 👏 I especially appreciate the tests.
I am hoping to avoid redundancy we can just replace the existing area_utils.py with this updated code, and update the existing area and change area estimation notebooks to use these functions. It would be good for @adebowaledaniel to look this over and make sure he agrees before making that change (let's bring this up in today's operations meeting).

Thanks, @bhyeh, for catching and fixing the bug.
I just did a quick test with some data with me.
LGTM.
Also, I am considering we include the test for other functions (load_ne,..., etc.) in the area_utils.py in the unittest_area, i.e. total removal of  integration_test_area.py

Also, I am considering we include the test for other functions (load_ne,..., etc.) in the area_utils.py in the unittest_area, i.e. total removal of integration_test_area.py

I think it might be nice to keep separate the unittest for the specific estimation functions, and have the integration test that involves the entire end-to-end process of loading, binarizing, and etc.

running the unittests

[Change Area] python -m unittest unittest_area_utils.ChangeAreaTest
[Crop Area] python -m unittest unittest_area_utils.CropAreaTest

Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB

@hannah-rae @adebowaledaniel I think this is nearly ready to be merged - just hoping for a quick lookover at the notebook changes. There, I've kept the cell outputs to give a preview of what therefactored code looks like and its outputs (the outputs are also fake data from the unit tests in case you were wondering). I'll also clear them before merging.

Thanks for the notebooks improvement (especially for the single year), @bhyeh 👍🏽. @hannah-rae give you the final comment on the change area notebook.
I will update the integration test later.


DragonBones page is being redirected somewhere else

In DragonBones page we have the following snippet:
<meta http-equiv="Refresh" content="0;url=http://www.effecthub.com">
It redirects to a seemingly unrelated page, no idea why that is there.
Is it possible to change the dragonbones link so it points to its GitHub page instead?
Thanks

@dejaime do you have the right URL?

Thank you!


Overriding data-testid requires a lot of work, and can't be done completely

Describe the feature you'd like:
An easier way to override the data-testid string.
I'm really sorry to raise this: I'm aware of #76, #128 and #136, and the current proposed solution.  But they're really hard to implement in practice, fully, and a very small amount of configuration in dom-testing-library would make that significantly easier for everybody who needs to override the test id.
I definitely agree with @kentcdodds about the composability of JS, wanting to keep things simple, and the fact that it is currently possible to override most of the layers that ordinarily expose the original xxxByTestId functions, but the problem is that data-testid is baked in at a rather low level, and overriding all the things layered on top is actually quite hard/impossible.  As more things are added to the framework (e.g. within), this gets harder, and consumers of the library will need to track and override more things.
Here's what you have to do right now if you need to override data-testid:

Implement your own top-level wrapper for react-testing-library.  (I've already done this, and would expect to do so, just as I did for Enzyme.  That's not an issue.)
Do a fair bit of shenanigans around overriding render (and rerender) to return a set of queries where the implementation of xxxByTestId is changed to your own implementation.  This is not trivial, as shown by the number of times that sample code has been tweaked in the react-testing-library docs. These all then need maintaining as APIs change.
(Not documented anywhere else afaik) Override within/getQueriesForElement because that'll return the original xxxByTestId functions too.
Tell all your developers that they mustn't use any functions imported directly from dom-testing-library because those xxxByTestId functions won't work properly.  (This rules out being able to use any other helper libraries that make use of dom-testing-library.)

Suggested implementation:
A simple design such as the one proposed by @davidgilbertson in #136 would solve all of this at a stroke and guarantee that whatever functions are layered on top of the library, whatever changes are made to higher level APIs, they'll all work, because we've not had to touch them, and have merely configured the low-level primitive operations directly.
Describe alternatives you've considered:
Doing it all by hand. I've not just considered this - I've been doing it.  I've almost got it all working, but it's taken a good few hours, and I still haven't sorted out how to override within in a good way.
I also can't do anything about my devs using things directly imported from dom-testing-library because I can't override those unless I could inject some configuration into dom-testing-library. If more things are added to dom-testing-library like within, I'll have to go back and override those (and anything that returns them, all the way up).
Teachability, Documentation, Adoption, Migration Strategy:
Documentation for react-testing-library and dom-testing-library would be simpler, as the task of overriding data-testid would become a one-liner rather than a significant block of code that needs copying, customising and maintaining by each consumer.
It could easily be a non-breaking change, and I'd be very happy to provide a PR.

I think there is actually an easier way to get react-testing-library's render to create the correct bindings for within, rerender, etc.
Render takes a queries option which is passed to getQueriesForElement in dom-testing-library

https://github.com/kentcdodds/react-testing-library/blob/master/src/index.js#L6
https://github.com/kentcdodds/dom-testing-library/blob/master/src/get-queries-for-element.js#L12

So, defining the custom queries and then doing this should work:
import {queries} from 'dom-testing-library'

const customQueries = {
  /* ...queries... */
  getByTestId,
  getAllByTestId,
  queryAllByTestId,
  queryByTestId
}

const allQueries = {...queries, ...customQueries}

const customRender = (ui, opts) => render(ui, {...opts, queries: allQueries})

The hard part is then mostly in actually implementing the queries, which does take a bit of work, should be fine as documented.

Yes, I saw the extra queries parameter, which looked like it was intended for this purpose, but a) it didn't appear in any documentation I could find, b) the existing documentation specifically recommends the laborious approach, and c) queries isn't in the TS typings file, suggesting that it wasn't an officially-supported approach.
And, as you say, I'd need to do something with within/getQueriesForElement too.  It's all a lot of messing around, and leaves me worried that with future changes to the libraries I'll have to do yet more work to maintain all this, as more functions or render options are added. e.g. if something like a user object (discussed elsewhere) or another top-level API is added, I'd have to override that API as well.
The problem is that I have to override every high-level API that exposes query functions because I can't reconfigure the low-level APIs.
Although pretty appalling to consider due to the maintenance headaches, it would probably actually be less work to have my local build scripts hack the dom-testing-library.esm.js after npm install, to replace data-testid with my testid string in the code, and to maintain that hacky patch, than to provide all the overrides on top, for all high-level query-exposing APIs, and to maintain those.
I'd be interested to better understand the strength of the reluctance to add a specific API to reconfigure the low-level test id string.  For many user-space libraries I'd understand, as static configuration APIs are a nasty global stateful thing to be avoided, as they side-by-side use of different configurations hard to achieve.  But for this testing library, I can't imagine such a side-by-side use case...?  It's also such a specific piece of configuration that it could be made configurable without necessarily opening the flood gates to all sorts of other configurations.

I second @RoystonS.
We started using react-testing-library for a number of existing react application. All of them already use  data-test attributes for purposes of e2e tests. Sticking to the data-testid convention is not an option because we would have to rewrite it everywhere. We have implemented a wrapped, but doing this is every project is painful. Maintaining those wrappers when API changes will be even worse. We use TS so needed to import appropriate interfaces/type aliases - again not easy.
I think that the decision to make this dataTestId non-configurable is actually harming the adoption of this great library.

I really wanted to avoid global configuration of this library, but I can see that this is causing real problems for people.
I am willing to look at a pull request that implements this feature request. No promises it will be merged, though I'm feeling at about ~75% in favor of accepting this functionality. Still a little hesitant, but definitely willing to take a look.

Yup, I do understand and respect the desire to avoid global configuration; I've been giving the high-level wrapping approach a good go as a result, and only (re)raised this reluctantly as it is so painful.  Thanks for being willing to consider it, @kentcdodds.
I'll get a PR together, and understand 'no promises'.

Ok, I've pushed in two alternative PRs (#163 and #164) for the price of one, to enable two alternative configuration APIs to be considered.
The PRs are identical apart from the exposed configuration API.

(For anybody reading this, @kentcdodds is looking for feedback on PR #164.)

This shipped in v3.13.0. Many thanks to @kentcdodds and those who reviewed/provided input.


JPEG IRQ handler

Hello,
The function JPEG_DMA_ContinueProcess() in file stm32h7rsxx_hal_jpeg.c is only called in the function HAL_JPEG_IRQHandler(), and the function JPEG_DMA_ContinueProcess() calls the function HAL_DMA_Abort() to stop the DMA transfer, but this seems to be an error, In the IRQ handler, the function HAL_DMA_Abort_IT() should be called instead of HAL_DMA_Abort().

ST Internal Reference: 185009

Fixed in db8d9c1dbd38d79e68086d5beed8dd6c922b4d9a


Get-RubrikSnapshot returns more results than expected

Is your feature request related to a problem? Please describe.
When running Get-RubrikSnapshot with a date specified and it doesn't find a snapshot within that timestamp, it returns every snapshot.  This can cause an unexpected behavior if one were to write a script that tries to mount a snapshot that was taken overnight.
Describe the solution you'd like
Return an error code or some indication that there's no match(by default a snapshot within 1 day of the specified time.
Describe alternatives you've considered
For this case it was acceptable to use the most recent snapshot from the output so we sorted and selected the one we wanted from the output.
Additional context
PS P:\Rubrik\stuff> Get-Date
Thursday, November 7, 2019 11:10:16 AM
PS P:\Rubrik\stuff> Get-RubrikSnapshot -id $db.id -date (get-date)
databaseName           : Footprints
slaName                : SLA1
slaId                  : 2adb7581-0211-46f9-9f10-4b1dab28157b
canLiveMount           : True
cloudState             : 0
sourceObjectType       : MssqlDb
isOnDemandSnapshot     : True
id                     : 25d8afd3-417b-4a5e-bd17-f47f5307a0b9
archivalLocationIds    :
date                   : 2019-11-06T01:35:50.000Z
replicationLocationIds :
databaseName           : Footprints
slaName                : SLA1
slaId                  : 2adb7581-0211-46f9-9f10-4b1dab28157b
canLiveMount           : True
cloudState             : 0
sourceObjectType       : MssqlDb
isOnDemandSnapshot     : True
id                     : 41773e41-425f-4bfd-87da-5007b549f0f1
archivalLocationIds    :
date                   : 2019-11-04T22:16:15.000Z
replicationLocationIds :

Hello @dewbrik,
Thanks for your suggestion, I will take a look at this and see how we can best implement some changes here!

Hi @dewbrik,
I have taken a look the issue you reported, it seems that this can be resolved by using the -ExactMatch switch parameter. This ensures that no additional results exact the ones you specify in your query are executed.
Using your example you could run the following code instead:
Get-RubrikSnapshot -id $db.id -date (get-date) -ExactMatch

Let me know if you have any additional questions about this.

Hi @jaapbrasser ,
That addresses this particular use case(thank you), but I'd go a step further and say that not requiring -ExactMatch should be the default behavior for the purpose of enhanced usability.   Much like how I would not expect VM2 to be returned if I ran "Get-RubrikVM VM1", if Get-RubrikSnapshot is executed with a date specified, the snapshots that didn't match the filter should not be returned.

Hi @dewbrik,
I understand the sentiment, it was an argument we had internally as well. The default behavior of the API and therefore the function was to show all results in case there was no exact match.
We decided to address this issue, not by changing the default behavior but rather add a parameter to change the default. This prevented us from making a breaking change to existing scripts that might rely on this behavior.
I think there's something to be said for both cases, I think we might change the default behavior of the cmdlet. If we don't one of the features that is coming up will be to set module wide configuration options, which would allow you to change the defaults of command like these.
For now you can put this in your PowerShell profile, or type it at the start of your session:
$PSDefaultParameterValues = @{"Get-RubrikSnapshot:ExactMatch"=$true}


Building 0.5.0 fails<EMAIL_ADDRESS>requires<EMAIL_ADDRESS>

Problem
Building / releasing fails because of this error.
./devtools/release.sh

#15 [5/5] RUN NAME=cratedb-prometheus-adapter VERSION=0.5.0 ./devtools/release_build.sh
#15 sha256:e96a499c09b87e8c237ae6ceead4209b056bb2a7ae799269ade00320ce70a00c
#15 0.166 Building cratedb-prometheus-adapter-0.5.0.linux.386.tar.gz
#15 1.097 go<EMAIL_ADDRESS>requires
#15 1.097<EMAIL_ADDRESS>missing go.sum entry; to add it:
#15 1.097 	go mod download github.com/VividCortex/gohistogram
#15 1.101 tar: cratedb-prometheus-adapter: Cannot stat: No such file or directory
#15 1.102 tar: Exiting with failure status due to previous errors
#15 1.103 rm: cannot remove 'cratedb-prometheus-adapter': No such file or directory

Even if I am adding apparent dependencies one by one, go-kit doesn't stop aiming for more. Now, it wants to pull in Zookeeper libraries?
#13 0.165 Building cratedb-prometheus-adapter-0.5.0.linux.386.tar.gz
#13 1.942 go<EMAIL_ADDRESS>requires
#13 1.942<EMAIL_ADDRESS>missing go.sum entry; to add it:
#13 1.942 	go mod download github.com/go-zookeeper/zk

It was just about updating the Dockerfiles used for building to use the most recent Golang version. GH-112 fixes the problem


Failing in Italian

While writing italian it gives it as less probable

https://github.com/wooorm/franc#whats-not-so-cool-about-franc

Yes but this is not a solution. I am pretty sure the underneath algorithm can be improved to have the best match of probability on the top. Other use the practical use becomes useless

Use this if you are dealing with practical usage: https://www.npmjs.com/package/cld
This library even recognize english as sot, and I have passed a large document.

I experienced @albandaft issues. See simple test program results:
 const franc = require('franc-min')

  if (process.argv.length === 2) {
     console.error(`usage: node ${process.argv[1]} <sentence, in double quotes>`)
     process.exit(1)
   }

const sentence = process.argv.slice(2).join(' ')
console.log( franc.all(sentence) )

$ node languageDetection "Questa è una mela."
[
[ 'spa', 1 ],
[ 'ita', 0.9804634257155839 ],
[ 'swe', 0.7473875511131304 ],
...
$ node languageDetection "Questa è una mela marcia. Perchè dovrei mangiarla?"
[
[ 'spa', 1 ],
[ 'zlm', 0.9975283213182287 ],
[ 'ita', 0.984552008238929 ],
[ 'por', 0.9789907312049434 ],
...
$ node languageDetection "Questa è una mela marcia. Perchè dovrei mangiarla? A me le mele piacciono, ma non quelle marcie."
[
[ 'ita', 1 ],
[ 'spa', 0.9301719221054348 ],
[ 'por', 0.9287867677014585 ],
[ 'fra', 0.9051576631630408 ],
...

It seems that increasing the number of words, the function start to recognize Italian language correctly.  So I reckon that func() need a long sentence to guess correctly ( https://github.com/wooorm/franc#whats-not-so-cool-about-franc ). My problem is that i would like to run franc() in a conversational (chatbot) to filter out not Italioanh words/sentences.

Question is: how many words the function need to guess correctly?

Thanks
giorgio

Hi Giorgio!
Franc guesses languages. It is never 100% certain. The longer the text you pass in, the better the probability.
In all your cases, franc gives a 98% probability that they are Italian, you could use that.


New package: fire-eggs.DarkThumbs version 1.9

Pull request has been created with komac v2.3.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-08-06 00:21:59.353 [CLI ] ShellExecute installer failed: 1603
Action start 0:21:58: AllocateRegistrySpace.
Action ended 0:21:58: AllocateRegistrySpace. Return value 1.
CustomAction +_757B733EE9E044A2F7FE91DD8D15F40B returned actual error code -2147024770 (note this may not be 100% accurate if translation happened inside sandbox)
MSI (s) (24:B8) [00:21:59:071]: Product: DarkThumbs -- Error 1904. Module C:\Program Files\DarkThumbs\CBXShell.dll failed to register.  HRESULT -2147024770.  Contact your support personnel.
Error 1904. Module C:\Program Files\DarkThumbs\CBXShell.dll failed to register.  HRESULT -2147024770.  Contact your support personnel.
Property(S): ErrorDialog = ErrorDialog
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0
MSI (s) (24:B8) [00:21:59:211]: Product: DarkThumbs -- Installation failed.

Automated error analysis suggests -1978335226 may mean Running ShellExecute failed
Automated error analysis suggests 1603 may mean Install successful but system restart may be required. Should this be add as an InstallerSuccessCode or similar?
(Automated response - build 887.)

Hi @soredake,
The installer didn't seem to modify the filesystem. Is this expected? Could a dependency be needed?

@stephengillie

Could a dependency be needed?

I don't think so, DarkThumbs bundles vcruntime140_1.dll

Turns out installer requires visual c++ libraries.

Verify:


STARsolo Matrix with Velocyto --> Anndata function

The scanpy.read_10X_mtx works well for reading in the STARsolo output matrices, which are based on the CellRanger Outputs.
However, it would be nice to have a function or modification of the read_10X_mtx function (e.g. a boolean for STARsolo velocyto) to automate inputting the velocyto matrices that STARsolo outputs and placing them in the appropriate layers.  A boolean switch for filtered versus raw matrices would be a good addition as well.

Example code: https://github.com/alexdobin/STAR/issues/774#issuecomment-850477636

Thanks for the suggestion.
@WeilerP, do you think this would be more appropriate in scvelo? (Side note, I have thought that tutorial
of going from BAMs through scvelo would be quite useful)

@WeilerP, do you think this would be more appropriate in scvelo? (Side note, I have thought that tutorial
of going from BAMs through scvelo would be quite useful)

Hm, not sure if the functionality would match the expectation. In scvelo, we'd store only unspliced and spliced counts (spliced both in adata.X and adata.layers). Based on the proposed code snippet in alexdobin/STAR#774 (comment), the expected output would be to read all of the available information?

It doesn't look to me like it's reading in much other than those. Just the obs and var that you'd get from any cell ranger experiment and an ambiguous layer.
What additional things are you concerned about?

Yes, agreed, ambiguous isn't really a problem (could be read in optionally via a keyword argument). I was more concerned about adata.X being the original count matrix - unless I am misunderstanding the code snippet ...

I was more concerned about adata.X

Ah, yeah I see what you mean. But isn't that fine for scvelo? I guess it wasn't obvious to me from the documentation that X wasn't supposed to be "total" counts.
Also it looks like the output formats may not be documented or finalized. It might be worth reaching out to the devs to see what's up before anything is implemented.

Just from an end user perspective, I hadn't recognized spliced is put into adata.X and it seems that the other STARsolo users in the original thread didn't either.  For my edification, would it cause any problems for me to modify the code to put spiced into adata.X or am I missing something else?

@ivirshup, @JBreunig using the absolute counts isn't a problem per se. It's simply that the scvelo paper used the spliced counts in adata.X based on which the highly variable genes are selected and PCA, neighbor graph and UMAP embedding are calculated.
@JBreunig, shouldn't be a problem to put spliced into adata.X as the dimensions of spliced and total counts are the same.


Setting up environment variables not possible

It would be nice to have a way to easily set up environment variables. This is not really possible at the moment because there is no editable Webpack config. Any ideas / alternatives on how to set this up?

@niels-bosman – You can use a build-figma-plugin.main.js file (or build-figma-plugin.ui.js file) to override the underlying esbuild configuration:
module.exports = function (buildOptions) {
  return {
    ...buildOptions,
    define: {
      'process.env.NODE_ENV': `'${process.env.NODE_ENV}'`
    }
  }
}

See:

https://yuanqing.github.io/create-figma-plugin/recipes/#customizing-the-underlying-esbuild-configuration
https://esbuild.github.io/api/#define

Thanks a lot! I set it up using the dotenv package in this way:
const env = JSON.stringify(require("dotenv").config().parsed);

module.exports = buildOptions => ({
  ...buildOptions,
  define: {
    "process.env": env,
  },
});

Thanks a lot! I set it up using the dotenv package in this way:
const env = JSON.stringify(require("dotenv").config().parsed);

module.exports = buildOptions => ({
  ...buildOptions,
  define: {
    "process.env": env,
  },
});

If you're creating a plugin in TypeScript, don't forget to install @types/node.

Thanks a lot! I set it up using the dotenv package in this way:
const env = JSON.stringify(require("dotenv").config().parsed);

module.exports = buildOptions => ({
  ...buildOptions,
  define: {
    "process.env": env,
  },
});

For future readers/reference: if using TypeScript, don't forget to install @types/node.

how would you pass different env? in the script?

I'm not sure where is the right place in the documentation but this would be a really useful recipe to add to the list. On setting env variables.


Fixes a bug where bench_sign would fail due to passing in too small a…

Fixes a bug where bench_sign would fail due to passing in too small a buffer.
This was introduced by the recent API change when the signature types were split.

utACK


GRPCRoute Hostnames and BackendRef

As a user of NGF with applications that require GRPC traffic
I want NGF to support a GRPCRoute with hostname and backendref matching support
So that I have a method to ingress GRPC traffic to my applications.
Acceptance

Users can create a GRPCRoute that can direct traffic from a hostname to a valid backendref.
The conformance test for GRPCRoute is enabled.

Dev Notes

A refactor is required to genericize the use of routes in the code base so that http route is not hard coded.
The implementation should first have a draft PR for refactor above.

Draft PR: https://github.com/nginxinc/nginx-gateway-fabric/pull/1820/files


Port test/test_image.py to pytest

Currently, most tests in  test/test_image.py rely on unittest.TestCase. Now that we support pytest, we want to remove the use of the unittest module.
Similar issues: https://github.com/pytorch/vision/issues/3915, https://github.com/pytorch/vision/issues/3909
Instructions
If you're interested in working on this issue, please comment below with "I'm working on <test_method_a>, <test_method_b>, etc..." so that others don't pick the same tests as you do. The tests in this file are fairly easy to port, so it's possible to port all of them at once in a single PR, in which case please say "I'm working on porting all the tests"
How to port a test to pytest
Porting a test from unittest to pytest is usually fairly straightforward. For a typical example, see https://github.com/pytorch/vision/pull/3907/files:

take the test method out of the  Tester(unittest.TestCase) class and just declare it as a function
Replace @unittest.skipIf with pytest.mark.skipif(cond, reason=...)
remove any use of self.assertXYZ.

Typically assertEqual(a, b) can be replaced by assert a == b when a and b are pure python objects (scalars, tuples, lists), and otherwise we can rely on assert_equal which is already used in the file.
self.assertRaises should be replaced with the pytest.raises(Exp, match=...): context manager, as done in https://github.com/pytorch/vision/pull/3907/files. Same for warnings with pytest.warns
self.assertTrue should be replaced with a plain assert

When a function uses for loops to tests multiple parameter values, one should usepytest.mark.parametrize instead, as done e.g. in https://github.com/pytorch/vision/pull/3907/files. Typically here in test_image.py, these will be things like for pil_mode, mode in conversion:, etc.

Hi @NicolasHug ,
I'm working on porting all the tests in test/test_image.py.


Prepare org.mockito.release-notes Gradle plugin

Subtask of #19.
Currently, the "org.mockito.release-notes" plugin is not usable outside of Mockito project.

[x] Document org.mockito.release-notes Gradle plugin and the extension
[x] Convert the groovy plugin to java
[x] Decouple auth token from Mockito
[x] #26, Make the target repository for querying issues configurable (currently hardcoded to Mockito)

The plugin does not yet have comprehensive documentation but we can add it later. The plugin is currently used by mockito-release-tools-example project so let's close the ticket.


Add a CVaR notebook

Summary
This PR adds a CVaR notebook.
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
290

Relevant Lines:
290

💛  - Coveralls

Few initial comments:

Most important, this tutorial is meant to reproduce the results in https://arxiv.org/pdf/2312.00733 which show that twirling and over-sampling (by an amount determined by the sampling overhead of PEC) can give mitigated bitstrings and that if we calculate the cost with CVaR we're guaranteed to select the bitstrings with lowest expectation values. Right now the notebook is showcasing only CVaR but we want to include also the estimation of the PEC gamma (can be done using reported device data or code for layer fidelity in qiskit experiments), twirling of the circuit, over-sampling my an amount given by gamma and optimizing the circuit parameters by using CVaR as a cost function with alpha value related to gamma (1/sqrt(gamma)).
Can we formulate CVaR as an observable? This would allow us to use the Estimator rather than the Sampler in the optimization of the circuit parameters. There are better error mitigation techniques available for the Estimator
Switch to V2 of the Runtime Primitives
This is intended to be a utility-scale tutorial. We need to increase the number of qubits to at least 40q (like in the paper)

From our discussion:

switch to runtime simulator for testing implementation
implement automatic estimation of gamma_circ (Mirko)
Use CVaR in the optimization with SamplerV2
Pass alpha=1/sqrt(gamma_circ) to CVaR
increase number of shots from shots to shots*sqrt(gamma_circ)
Set options in SamplerV2 to do DD, Twirling, (look into measurement mitigation). Also look at https://github.com/IBM-Quantum-Technical-Enablement/quantum-enablement/blob/krylov_utility/docs/notebooks/scaling-sampler/scaling-sampler.ipynb (may be outdatad)
-See this notebook for utility scale QAOA with latest product tools

How does twirling work for Sampler?
Twirling options:
enable_gates = True
enable_measure= False
with these assumptions: num_randomizations = 50, shots = 10k
shotssqrt(gamma_circ) = num_randomizations * shots_per_randomization → shots_per_randomization = shotssqrt(gamma_circ) /num_randomizations = 200*sqrt(gamma_circ)

DD options:

enable =True
sequence_type = ‘XY4 (fallback to XpXm if it doesn’t work)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
290

Relevant Lines:
290

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
290

Relevant Lines:
290

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
290

Relevant Lines:
290

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
290

Relevant Lines:
290

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
290

Relevant Lines:
290

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
290

Relevant Lines:
290

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
290

Relevant Lines:
290

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
290

Relevant Lines:
290

💛  - Coveralls


Seems option "smartArrows" can be safely dropped?

Usually, it's enougth to have multiple memoised instances of pre-populated parsers or switch plugin with .enable / .disable on the fly when speed does not matter.

I hadn't realized that .enable/.disable work for plugins. (I guess I need to stop thinking of "plugins" as very different from "rules".)
I'll remove the option.

I've mistyped, it's not for plugins, but most of plugins have only one rule.


v4 custom-select does not support "multiple"

The current bootstrap v4 beta 6 comes with a new custom-select class, but it appears broken when the "multiple" attribute is also defined.
For example:
<select multiple class="form-control" id="exampleSelect2">
changes into
<select multiple class="custom-select" id="exampleSelect2">
Maybe the documentation could mention that multiple is not supported, or if it is not too much work, to implement custom-select a bit better for displaying on a multiple select.
Thank you.

PR: https://github.com/twbs/bootstrap/pull/23055


Nsidc access

Final updates to nsidc access tutorial

@asteiker jupyterbook is picky about markdown headings, they have to be ordered sequentially:
# title (only one)
## subtitle
### susubtitle
## subtitle

the log shows Exception: File './scripts/nsidc-download_SNEX20_SD.001.py' not found.

@scottyhq added the scripts folder- sorry for missing this earlier.

@asteiker I'm going to merge this, it's not going to render on the website as currently set up b/c of the way the credentialing is currently done: StdinNotImplementedError: raw_input was called, but this frontend does not support input requests. StdinNotImplementedError: raw_input was called, but this frontend does not support input requests.
Can sort that out later if you want

@scottyhq Thanks - I was wondering how it would render with the credential inputs. Happy to try to sort out later.


ci(metrics): add compressed sizes and improve cli

Made a bunch of changes over the weekend to the npm package. Copy/pasted those changes to the file in this repo. View the release notes for more info:
https://github.com/benelan/build-sizes/releases/tag/v3.0.0

The CSV now has Build size (MB) and Build on-disk size (MB). Is this expected?

The CSV now has Build size (MB) and Build on-disk size (MB). Is this expected?

They are different numbers, but not by much. The on-disk one uses du which doesn't work on Windows. So if we ditch one it would have to be the "on-disk" number.
I didn't want to remove the on-disk size since that's what Andy originally documented in his table. But I wanted the script to work for Windows users as well.

Window's lists both "size" and "size on disk" in their file explorer

So if we ditch one it would have to be the "on-disk" number.

I'd vote for that unless Andy has a reason to keep both. Currently they seem a bit redundant.

Sure, I'm okay with removing "on-disk". Plus, with on-disk YMMV depending on disk sectors, compression, etc etc


Opening recents from within an app breaks the animation until restart

Description
Entering the new recents panel from the home screen gives a nice animation back and forth. Entering the recents panel from an app though, the app slides down, and the recents just appears. From this point onwards, the recents panel, even from the home screen, simply fades in and out, instead of the nice slide up animation on the home screen.
Steps to reproduce
(on a clean boot)

Open and close app switcher from homescreen, and observe the animation.
Open an app.
Now, without closing the app, open the app switcher and observe the animation.
Go back to the homescreen, open and close the app switcher, and observe the animation.

ROM info
Cardinal-AOSP 5.5 on Xiaomi Redmi Note 4 Global (Android 8.1.0 Oreo) + FrancoKernel
Module version (build version)
Android P-ify version 1.0.0 #148
Video showcasing the issue
YouTube link
Xposed log / logcat
05-22 14:05:30.870 I/Xposed  ( 7652): -----------------
05-22 14:05:30.870 I/Xposed  ( 7652): Starting Xposed version 90.2-beta3 (Systemless), compiled for SDK 27
05-22 14:05:30.870 I/Xposed  ( 7652): Device: Redmi Note 4 (Xiaomi), Android version 8.1.0 (SDK 27)
05-22 14:05:30.870 I/Xposed  ( 7652): ROM: cardinal_mido-userdebug 8.1.0 OPM2.171019.029 0b09109e8f release-keys
05-22 14:05:30.870 I/Xposed  ( 7652): Build fingerprint: xiaomi/mido/mido:7.0/NRD90M/V<IP_ADDRESS>.NCFMIED:user/release-keys
05-22 14:05:30.870 I/Xposed  ( 7652): Platform: arm64-v8a, 64-bit binary, system server: yes
05-22 14:05:30.870 I/Xposed  ( 7652): SELinux enabled: yes, enforcing: no
05-22 14:05:33.577 I/Xposed  ( 7652): -----------------
05-22 14:05:33.577 I/Xposed  ( 7652): Added Xposed (/system/framework/XposedBridge.jar) to CLASSPATH
05-22 14:05:35.263 I/Xposed  ( 7652): Detected ART runtime
05-22 14:05:35.267 I/Xposed  ( 7652): Found Xposed class 'de/robv/android/xposed/XposedBridge', now initializing
05-22 14:05:35.488 I/Xposed  ( 7652): Loading modules from /data/app/xyz.paphonb.androidpify-xAHSBDtb7Ek_Kg69WiLe2Q==/base.apk
05-22 14:05:35.706 I/Xposed  ( 7652):   Loading class xyz.paphonb.androidpify.XposedHook
05-22 14:05:45.197 I/Xposed  ( 7978): [Android P-ify] [ERROR] : onAttachedToWindow: mIconManager = null
05-22 14:13:09.784 I/XposedInstaller(14022): Downloaded http://dl.xposed.info/repo/partial/14953.xml.gz with status 0 (error: null), size 21663 bytes
05-22 14:13:09.894 I/XposedInstaller(14022): Updated repository http://dl.xposed.info/repo/full.xml.gz to version 14981 (5 new / -1 removed modules)

The only fix possible will require new classes that only exist on P so this is not possible. Closed for now.


test framework: move from IstioVersions to Revisions

Should be able to run tests against multiple revisions without specifying versions for those revisions (unspecified revs are assumed to be latest versions). Now, we can express "I want to deploy echoes for revisions A, B and C. A and B are on 1.9.3 and C is on latest" as --istio.test.revisions A=1.9.3,B=1.9.3,C.
Renamed from istio.test.versions to istio.test.revisions since version is just one piece of config associated with a revision, in the future we probably want to pass other things like per-revision config overlays.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[x] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any changes that may affect Istio users.

In response to a cherrypick label: new pull request created: #32520


What exploit can use in 11.2.35?

As title, what exploit can use in 11.2.35? Ninjahax? oot3dhax?

https://www.3dbrew.org/wiki/Homebrew_Exploits


Intermittent missing output on python 3.4

This script reliably produces output for me on Python 2.7.11, but only about 20% of the time on Python 3.4.4 (both on Mac OS X 10.10.5):
from docker import Client
from docker.utils import kwargs_from_env

from dockerpty import start, RunOperation, PseudoTerminal

client = Client(**kwargs_from_env())
container = client.create_container('alpine', ['echo', 'hello', 'world'])

operation = RunOperation(
    client,
    container['Id'],
    interactive=True,
    logs=False,
)
pty = PseudoTerminal(client, operation)
sockets = pty.sockets()
client.start(container)
pty.start(sockets)
client.wait(container)

The last stanza is modelled on how Compose uses dockerpty. I can make the script reliable by replacing it with the following:
start(client, container, interactive=True, logs=False)

I haven't yet investigated any further.

client.start(container)
pty.start(sockets)

This seems like a potential race, right? Logs can be missed if they are printed before the pty.start() connects.
I'm not sure why it works with python2.

I don't think so. pty.sockets() opens the HTTP connections. pty.start() just hooks them up to stdin/out/err.

Ah right, I forgot we worked that out. Thanks

Is this issue still open?


Drop support for Python 3.8 & 3.9

Dropping py3.8 would enable updates for several packages. With that in mind we can also try to include the latest py3.12 version.

@NeffIsBack looks like now is a good time to drop 3.8 & 3.9 due to many issues with them. The last 2 Debian versions ship with 3.11, which is why we had this on hold: https://wiki.debian.org/Python

We could just increase the python version in the pyproject.toml for now without upgrading all the dependencies and if people complain we can easily downgrade.

Let's do this after the next release, so we don't have to update all the packages for kali now. After the release we update everything

Things to be reverted when we drop 3.8:<PHONE_NUMBER>7fd66307a949313ac9e14601c6a261


Add jss.version

Fixes https://github.com/jsstyles/jss/issues/207.
Updates

Added json-loader to load package.json in test code
Added __JSS_VERSION__ as the version of jss

we have 2 builds, lib and dist, dist ist created by webpack, lib is just babel, so right now the babel build is broken because the variable won't be replaced. I think we need something like a plugin for babel to do that. __VERSION__ is not the same like process.env.NODE_ENV because the last one is something we expect to be replaced by the root project build, not the version though, it results in "Uncaught ReferenceError: JSS_VERISON is not defined"

@kof Thanks for your review! I've fixed 3 points you commented.

Close by https://github.com/jsstyles/jss/issues/213#issuecomment-212549709. Also I will recreate a patch to make it simpler!


Add Changelog please : )

I love this repo, and i use it in my work heavily.
it's better if we can know change while upgrading the package

Thanks @silent-tan , you can see the change log at:  https://github.com/eBay/nice-modal-react/releases.


Issue with NewCameraCapture()

I am having a strange issue when attempting to call NewCameraCapture().
I have a function takePhoto() when ran by itself, works fine. When I have the same function in a loop that waits for a goroutine to return data over a channel, it just hangs without any error message.
I believe the line that is causing my problems is this one. Any guidance on this would be greatly appreciated. I will continue to dig and submit a PR if I find a solution.

I'm gonna bump this. Anyone having similar issues, or any suggestions on how I can fix this issue?

sorry but i don't plan to maintain the v1 API anymore. i'm going to target v2 (i.e. C++ API) in the future :D
please let me know if you have any other concern.
Thanks.


getting-started/bookshelf: oauth fails with gorilla securecookie max length

Getting an error with the bookshelf app after accepting oauth scopes from login link:
could not save session: securecookie: the value is too long

Guessing it's coming from: https://github.com/gorilla/securecookie/blob/master/securecookie.go#L288
Occurring with deployed app. Any way I can debug this?

It's probably because the OAuth token is now too long and taking up too much space in the cookie.
The OAuth token should probably be moved to a different session.
https://github.com/GoogleCloudPlatform/golang-samples/blob/master/getting-started/bookshelf/app/auth.go#L163-L177

@broady Got it. I ended up storing the profile in a separate CookieStore. Measuring the cookies sizes, interestingly enough the default cookie with token became 519B and the profile cookie with plus.Person type saved became 3779B.
On a separate topic, it does feels a little strange to be storing such large cookies on the client.

Actually after switching out plus.Person with a basic struct, the profile cookie size became 1247B. I guess plus.Person simply doesn't encode efficiently.


Layout issue on upgrade

Issue description
Layout issue.

Layout looks good on fresh k8s deployment without /media and /data volumes.

Steps to Reproduce

I think this issue is present because I use k8s to persist /data and /media directories. I upgraded streama to v1.7.4 (can't remember from what version) and now see screenshot in Firefox and Chrome.

Expected Behaviour
It should look pretty! :)
Actual Behaviour
Layout issue.
Environment Information

Streama version: v1.7.4
Container Version (If Applicable): gkiko/streama

To add to this, logging on as admin results in expected layout on deployment with volumes.

This doesn't look like issue related to volumes persisting across upgrades, can duplicate issue by allowing anonymous access.

On fresh install, you can duplicate this issue by logging in as admin and navigating to settings page and ticking "Allow anonymous access".

Log out of Streama and observe header.

Raised PR to fix this issue at https://github.com/streamaserver/streama/pull/920.


[CARBONDATA-2198] Fixed bug for streaming data for bad_records_action as REDIRECT or IGNORE

Refactored streaming functionality for bad_records_action as IGNORE or REDIRECT
Added related test cases

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2736/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3981/

@mohammadshahidkhan Please review. This issue is related to PR #1942

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3737/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3031/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4275/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3515/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4742/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4249/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5172/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4456/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5017/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6007/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4848/

LGTM

LGTM


Add Pre-Post Composite Nodes

Contains
Four new nodes for DAG (Directed Acyclic Graph), wrapping tasks that are related with Pre-Post Composition.

AmbientOcclusionPassesNode
OutlineNode
PrePostCompositeNode
SimpleBlendMaterialsNode

How to test
Check if there are any weirdness related to rendering of transparent(with some degree, blended with background) objects, Ambient Occlusion and outline option.

Hooray Jenkins reported success with all tests good!

Just went through this PR. One minor issue affecting all new nodes from my perspective, regarding PerformanceMonitor statements. Once that's out of way everything looks good for a speedy merge @msteiger.

Hooray Jenkins reported success with all tests good!

As discussed with @emanuele3d

Brrreeezing through!!


[DOCFIX] Update user-configuration.yml of the Chinese version

Update user-configuration.yml of the Chinese version

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/13019/
Test PASSed.

Merged build finished. Test PASSed.


Provided dictionary files <de_DE_frami.dic> & <de_DE_frami.aff> not recognized.  After renaming to <de_DE.*> it is working well.

Description
The provided dictionary files <de_DE_frami.dic> & <de_DE_frami.aff> are not recognized.
After renaming to <de_DE.dic> & <de_DE.aff> it is working well.
Reproduce
After installing the spellchecker, I changed the setting to.
    // Language of the spellchecker
    // Dictionary identifier, e.g. en-us
    "language": "de-de",

after saving the setting, the spellchecker didn't work.
I changed the filename of the .dic and .aff file, as explained above, and the spellchecker worked well.
Please ensure that all delivered dictionaries, incl, <_frami.> are recognized. Thanks.
Context

Python package version:

Extension version:
ipycanvas v0.10.2 enabled ok
jupyter-leaflet v0.13.5 enabled ok
jupyterlab-drawio v0.9.0 enabled ok (python, jupyterlab-drawio)
nbdime-jupyterlab v2.1.1 enabled ok
@ijmbarr/jupyterlab_spellchecker v0.7.2 enabled ok (python, jupyterlab-spellchecker)
@jupyter-widgets/jupyterlab-manager v3.0.0 enabled ok (python, jupyterlab_widgets)
@jupyter-widgets/jupyterlab-sidecar v0.6.1 enabled ok (python, sidecar)
@jupyterlab/git v0.34.0 enabled ok (python, jupyterlab-git)

Other labextensions (built into JupyterLab)
app dir: C:\DataProg\anaconda3\share\jupyter\lab
jupyterlab-spreadsheet v0.4.1 enabled ok

Operating System and its version: Windows 11
Browser and its version: Firefox

Hi @jspille thank you for opening the issue. It looks that you are attempting to use an incorrect dictionary identifier. The identifier for the de_DE_frami.dic/.aff dictionary is de_DE_frami and it is set automatically when using the dictionary selector from the status bar:

Why were you expecting de-de to work in this case? Is this mention like this in our documentation or some tutorial? If yes, this needs correcting, but I don't see need for any further action other than that.

Not the issue owner but I had the same assumption, maybe we could add the default available dictionaries and their language tag to the readme?

Had the same problem. Adding the animation above to the README would be very helpful. The statusbar doesn't seem to mentioned in the README at all. The statusbar is a great feature but the user might not look at it. Pointing this feature out in the README would be great.

We can dynamically add the enum to the settings schema to validate the available dictionaries and have a switch list in settings UI (available since JupyterLab 3.3). This would require using settingRegistry.transform to change the schema in the fetch step and then trigger update of the settings on any change to the online dictionaries or server reported dictionaries. Something like this is being done in jupyterlab-lsp and in the shortcuts extension.


Symmetric proposal 1.1

This should cover the open points I was aware of. We still need end-user documentation and then this should be good to go.
Further improvements, which we could do on top:

additional data support
more tests

Squashed. I've discovered a case where we had copying in a update()/read() or update()/readAll() loop. I went through all the comments again and marked everything as resolved this I think is solved.
One open item we might still want to address is wiping the key from memory after using it, though…


user control thread safety

I get some exceptions using ScottPlot formsPlot user control. I use the latest ScottPlot version, under VS2019 in a WinForm project. I have another project, where the exception generated always when minimizing the main Form window, however I cannot paste that project as it is, but I will try to reduce/remove company info tomorrow and post that one as well.
I attach the test project which only generates the exception randomly. Reproducing the problem: run the Release EXE, and start to resize the Form window dragging by its right border, to the minimum size (when practically the plot is not visible), then back. Repeat this many times, and sometimes you get exceptions, like the two pasted below.
scottplottest1.zip

System.InvalidOperationException: Object is currently in use elsewhere.
at System.Drawing.Graphics.MeasureString(String text, Font font, SizeF layoutArea, StringFormat stringFormat)
at System.Drawing.Graphics.MeasureString(String text, Font font)
at ScottPlot.TickCollection.UpdateLongestLabel(Settings settings, Boolean verticalAxis)
at ScottPlot.TickCollection.Recalculate(Settings settings, Boolean verticalAxis)
at ScottPlot.Renderer.FigureTicks(Settings settings)
at ScottPlot.Plot.RenderBitmap()
at ScottPlot.Plot.GetBitmap(Boolean renderFirst, Boolean lowQuality)
at ScottPlot.FormsPlot.Render(Boolean skipIfCurrentlyRendering, Boolean lowQuality)
at ScottPlot.FormsPlot.PbPlot_SizeChanged(Object sender, EventArgs e)
at System.Windows.Forms.Control.OnSizeChanged(EventArgs e)
at System.Windows.Forms.Control.UpdateBounds(Int32 x, Int32 y, Int32 width, Int32 height, Int32 clientWidth, Int32 clientHeight)
at System.Windows.Forms.Control.UpdateBounds()
at System.Windows.Forms.Control.WmWindowPosChanged(Message& m)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

System.NullReferenceException: Object reference not set to an instance of an object.
at ScottPlot.Renderer.RenderTicksOnLeft(Settings settings)
at ScottPlot.Renderer.FigureTicks(Settings settings)
at ScottPlot.Plot.RenderBitmap()
at ScottPlot.Plot.GetBitmap(Boolean renderFirst, Boolean lowQuality)
at ScottPlot.FormsPlot.Render(Boolean skipIfCurrentlyRendering, Boolean lowQuality)
at ScottPlot.FormsPlot.PbPlot_SizeChanged(Object sender, EventArgs e)
at System.Windows.Forms.Control.OnSizeChanged(EventArgs e)
at System.Windows.Forms.Control.UpdateBounds(Int32 x, Int32 y, Int32 width, Int32 height, Int32 clientWidth, Int32 clientHeight)
at System.Windows.Forms.Control.UpdateBounds()
at System.Windows.Forms.Control.WmWindowPosChanged(Message& m)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

@bukkideme I'm pretty sure this error is caused by any program which attempts to make System.Drawing calls (using GDI+) in a parallel-processing environment. I don't think GDI+ calls are thread-safe.
aTimer = new System.Timers.Timer(500);

I would guess if you make the timer 100, crashes will happen 5 times more often 😈
This is good to know, as it means programs which involve plotting live data are susceptible to crashes if updates occur while the user control is resizing!
Would an acceptable solution be to wrap your OnTimedEvent code in a try/catch?

I actually fixed this bug in your application by using a System.Windows.Forms.Timer (drag/dropping it from the toolbox onto your Form) rather than a System.Timers.Timer
I'm guessing the Forms timer has better support support for GDI+

Actually the other application which crashed at each and all resize attempt, uses the old school Backgroundworker class. I wonder how it makes it different. Actually this app was a reworked old one, in my newer apps i use TAP approach which is the recommended parallel solution. Hmm, would it make any difference using a Task...?
Anyway, since this is a window resize event, there are many options to avoid such crashes, including your suggestion.
Thanks for feedback!

Anyway, since this is a window resize event, there are many options to avoid such crashes, including your suggestion.

Keep in mind your program also crashes if System.Timers.Timer triggers an update while actively click-dragging to pan or zoom (not just resize events). Using System.Windows.Forms.Timer protects against this too.


Test Coverage

A test coverage and badge befits this elegant library

Closing this one since it's related PR has been merged


chore: update contributors in package.json

Use repo-tools to update package.json.

FWIWs, we're looking into which list of contributors we can omit so we don't duplicate that info (it's already in the git history).


Investigate 'Javascript heap out of memory' error

An error saying "Javascript heap out of memory" popped up in the WorldMap component PR, and blocked the pr from building successfully (and deploying to firebase). The source of the error seems to be the generation of typedocs, and a quick fix was just to disable typedocs (remove yarn generate-docs from the build script) for now, so as to not block merging the WorldMap.
Things we've tried so far:

Doubling the amount of allotted memory
Upgrading typedocs

It looks like this is a known typedoc issue: https://github.com/TypeStrong/typedoc/issues/1606. They are working on it, with the last progress update 9 days ago.

I've found that if we generate docs directly from the package sources instead of using the "monorepo support" then it's a lot faster and uses less memory.  The downside is the overall structure of the docs make it look like a single package with assert/src, metrics/src, etc. instead of separate modules (@actnowcoalition/metrics, etc.).  This isn't ideal for our public facing docs, but I think is probably fine for right now.
One side benefit of this change is that it makes cross-linking classes across packages work, which is currently another Typedoc bug with monorepo support (https://github.com/TypeStrong/typedoc/issues/1835).
When https://github.com/TypeStrong/typedoc/issues/1606 is addressed, we can revisit this.


Better permissions and rank system

This system for permissions and ranks are not good at all. It works for now, but seriously needs to be revamped.

In work on branch better-ranks. @gcflames5 has added CanCanCan support, the admin UI is almost done.

closed in fe864614d959a6163713ca065fcd6ca79c6d53b3


Loading a vanilla world causes it's signs to be glowing when they're not

Fixed in 064f0425e3af723dea9c81f503e48a29d7c8bbcb.


Autocategorize by label?

Hey, did you think about taking this bot a step forward in the future and make it configurable that the drafter only lists merged PR with specific label, and even that you can have different sections in a template and Pr with specific label in the section?

Hey @derberg! Absolutely. Different PR labels for different sections is super high on my wish list.

Tried to modify messages for releases. But, setting up local environment with probot of forks got me for hours.

Sorry to hear @salmanulfarzy! What were you trying to modify them from/to?

I was trying to change the release note into (#pr) message - @author format and extending them to be used with template variable, to support user customization.

@salmanulfarzy I could look at adding that for you. Perhaps a “change-template” config, that took $number, $title and $author template variables?

Perhaps a “change-template” config, that took $number, $title and $author template variables?

That sounds great :smile:

open it as a new issue tho, as I think it’s unrelated to the original issue.

Sure, I'll open up a new issue. Mentioned it here because may be it could be considered on enhancements.


Adding back the description on the About page.

Added back the missing description on about.html, similar to page.html. This could additionally be added back to the post.html template as well.

Nice catch. Apparently, it was mistakingly removed in #102. Thanks!


Code generation fails when changing names in makefile

Hi! I decided to try modifying the makefile so to generate classes with different naming scheme, like this:
#  The capitalized types used to build class and method names; boolean and object types are not listed.
TYPE_NOBOOL_NOOBJ=Byte Short Int Long Char Float Double

#  The capitalized types used to build class and method names; boolean and reference are not listed.
TYPE_NOBOOL_NOREF=$(TYPE_NOBOOL_NOOBJ) Obj

#  The capitalized types used to build class and method names; object types are not listed.
TYPE_NOOBJ=Boolean $(TYPE_NOBOOL_NOOBJ)

#  The capitalized types used to build class and method names; references are not listed.
TYPE_NOREF=$(TYPE_NOOBJ) Obj

#  The capitalized types used to build class and method names; boolean is not listed.
TYPE_NOBOOL=$(TYPE_NOBOOL_NOREF) Ref

# The capitalized types used to build class and method names; now references appear as Reference.
TYPE=$(TYPE_NOREF) Ref

#  The capitalized types used to build class and method names; only types for which big structures are built are listed.
TYPE_BIG=Int Long Float Double Obj Ref

So you'd get something like Ref2ObjMap. Ideally I wanted it to be RefObjMap for example, removing the '2', names which are described in the same file.
The thing is that it seems to break code generation, for instance I get class definitions like:
 public abstract class Abstract2BooleanFunction implements 2BooleanFunction , java.io.Serializable {

That ought to be AbstractSomething2BooleanFunction and Something2BooleanFunction, so compilation fails.
Also if I change TYPE_NOOBJ from Boolean to Bool, I get an error for a missing file:
./drv/BinIO.drv:157:63: fatal error: src/it/unimi/dsi/fastutil/io/BooleanBinIOFragment.h: No such file or directory

Since it seems the full name "BooleanBinIOFragment" is hardcoded in the BinIO.drv file. The generator instead creates BoolBinIOFragment, thus why it cant find it.
Any ideas on what might be wrong or what I am missing?

I also tried to change the names in the gensources.sh file and the problem persists. Searching around it seems there are a few hardcoded checks like
´´´
if [[ "${CLASS[$k]}" != "Object" && "${CLASS[$k]}" != "Reference" ]]; then
´´´
Which fails if you actually change the names.

I understand your concerns, but this is no no way an "issue" :).

Really? I thought the class names were configurable for a reason. So any pointers on how would I accomplish changing the generated class names like that?


Difficult to understand which tutorial is being executed in Github Actions

Logging should include the name of the tutorial being executed somehow as it is otherwise very difficult to properly see which tutorial is actually failing.

A Simple solution would be a print of the name of the playbook that is currently executed. https://github.com/devonfw-tutorials/tutorial-compiler/blob/main/engine/run.ts


Can my wheel stop on more than one preselected segment?

Hello,
I would like my wheel to stop on more than one of any preselected segments e.g segment 4, 7, 9, 10 only. Is it possible? Have I tried the code below in vain. I have tested with 'or', 'and' javascript functions but the wheel only stops on one segment.  Please help.
// Function with formula to work out stopAngle before spinning animation.
// Called from Click of the Spin button.

function calculatePrize()
{
// This formula always makes the wheel stop somewhere inside prizes at least
// 1 degree away from the start and end edges of the segment.

let stopAt = (91 + Math.floor((Math.random() * 43)))
     ||
let stopAt = (181 + Math.floor((Math.random() * 43)))
     ||
let stopAt = (271 + Math.floor((Math.random() * 43)))

// Important thing is to set the stopAngle of the animation before stating the spin.
theWheel.animation.stopAngle = stopAt;
// May as well start the spin from here.
theWheel.startAnimation();
}

Thanks
Eddy

Did you decided?

The code in the example is not valid JavaScript which is why it does not work.
I would simply add the possible options to an array and then use the Math.random() in JavaScript to choose one of the options,  at random.
There is a also a getRandomForSegment(int segmentNumber) function in winWheel.js which can be used to pick a random angle inside a segment. I will use this in the example....
let winningSegments = [
    theWheel.getRandomForSegment(4),
    theWheel.getRandomForSegment(7),
    theWheel.getRandomForSegment(9),
    theWheel.getRandomForSegment(10)
];

let stopAt = winningSegments[Math.floor(Math.random() * Math.floor(winningSegments.length));


Update ruby.

Ruby 2.1.0 is very old, at least in the Ruby community. Any good reason why this gem should be pegged to such an old release? If not.. could I get a merge in if I submit the PR? 😄

No strong reason, other than we were interested in maintaining backwards compatibility. Which is a good practice in general. However, you could add a newer version to the Travis file. In general, yes, we take pull requests so long as they make sense.

See #200

Fixed by #205


Update sbt-lucuma to 0.4.4

Updates edu.gemini:sbt-lucuma from 0.4.2 to 0.4.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "edu.gemini", artifactId = "sbt-lucuma" } ]

labels: sbt-plugin-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #143.


launchCamera and launchImageLibrary work only for the first time.

Bug
2019-11-28 18:03:32.900256+0400 myappname[515:59647] Warning: Attempt to present <UIImagePickerController: 0x159016c00> on <RCTModalHostViewController: 0x15a70ca30> whose view is not in the window hierarchy!
Environment info
React native info output:
OS: macOS 10.15.1
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Memory: 1.77 GB / 16.00 GB
Shell: 3.2.57 - /bin/bash

Binaries:
Node: 13.1.0 - /usr/local/bin/node
npm: 6.12.1 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK:
API Levels: 23, 25, 28, 29
Build Tools: 28.0.3, 29.0.2
System Images: android-28 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.5 AI-191.8<IP_ADDRESS>00203
Xcode: 11.2.1/11B53 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.2 => 0.61.2
npmGlobalPackages:
react-native-cli: 2.0.1
Library version: 1.0.1
Steps To Reproduce
1.Launch app
2.Try to take photo from camera/library - OK
3.Try to take photo from library/camera - camera open, but photo don't not change and library don't launch
4. Again try to take photo from camera/library - they don't launch!
Reproducible sample code

 _onImageSelected(response) {
            if (response.didCancel) {
                console.log('User cancelled image picker');
            } else if (response.error) {
                console.log('ImagePicker Error: ', response.error);
            } else if (response.customButton) {
                console.log('User tapped custom button: ', response.customButton);
            } else {
                console.warn(response.uri);
                api.postUserImage(response.uri).then((r) => {
                }).catch(e => console.warn(e))
                this.reloadOwnProfile()
            }
        }

    openNativeImageCamera(){
        ImagePicker.launchCamera(
          {
            quality: 1.0,
            allowsEditing: true,
            noData: true,
            storageOptions: {
                skipBackup: true,
                path: 'images',
            },
          },
      (response) => {this._onImageSelected(response);}
        );
    }

    openNativeImageLibrary(){
        ImagePicker.launchImageLibrary(
          {
            quality: 1.0,
            allowsEditing: true,
            noData: true,
            storageOptions: {
                skipBackup: true,
                path: 'images',
            },
          },
      (response) => {this._onImageSelected(response);}
        );
    }

Same issue. Sometimes I can select a picture from the library, sometimes it freezes and i can't select anything (e.g. album)

@wedusa After you select images error will occurred and permission for access is show up right ?

This is definitely 100% still happening. @chai86 Did you manage to resolve this?

Same problem here

Same problem here...very bad


README

#README
##User Story
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
##Acceptance Criteria
GIVEN the prework project repository,
WHEN I view the README for the repository,
THEN I can see a professional README that provides information on the project and how to use it

README file updated


Drop usage of the word "extension"

I should stop calling things "extensions," which makes them sound like some formal Concept©. To reduce the number of Concepts©, I should just update that section of the docs to be called "Ecosystem," then refer to them as libraries that can be used with Resourceful Redux.

Still thinking on this. I may keep it, but maybe not. Feel free to chime in if you feel one way or the other. For now, I'm going to close this

@jmeas Darn, I was working on this. :P
In many cases you refer to Extensions at the same time as the core library:
Not in the core library, but there is an [Action Creators extension]
This makes the changing Extensions to library a bit confusing:
Not in the core library, but there is an [Action Creators library]
I was thinking something like:
Not in the core library, but there is a collection of [Action Creators]
Then you can simplify a lot of sentences like
The Action Creators extension provides out-of-the-box action creators that you can use to create resources.
to this:
Resourceful Redux provides [a collection of] out-of-the-box Action Creators that you can use to create resources.
And the README change:
# Ecosystem

The Resourceful Redux ecosystem provides bits of code that make working with
the library even better.

* [Prop Types](/docs/extensions/prop-types.md)
* [Action Creators](/docs/extensions/action-creators.md)

yo @smaifullerton-wk ! Thanks for the comment!

@jmeas Darn, I was working on this. :P

I didn't mean to make it out that I'm not interested in making the change! If you think it's a good idea, then let's do it!!! ✌

I was thinking something like:
Not in the core library, but there is a collection of [Action Creators]

I agree with you that using the word "library" could lead to confusion. I'm not opposed to using another noun instead of "library," and I think "a collection of action creators" is 👌 . Another idea that might be worth considering is giving the extensions a proper name, derived from the npm package name.
The npm package name for the extensions is resourceful-{thing} (like resourceful-action-creators, so I was thinking the name of them could be, say, "Resourceful Action Creators."
Then, in some places it could be referred to directly by that name:

Not in the core library, but there is a separate module, Resourceful Action Creators.

# Ecosystem

The Resourceful Redux ecosystem provides bits of code that make working with
the library even better.

* [Resourceful Prop Types](/docs/extensions/resourceful-prop-types.md)
* [Resourceful Action Creators](/docs/extensions/resourceful-action-creators.md)

Maybe it makes sense to sometimes refer to it by name, and other times with the more general "collection of action creators," based on the context? I'm not too sure – just throwin' some ideas out there.
If you made a PR that got rid of "extensions" (in whatever way you think is best), I'd def merge it though :v:
Thanks again!

Resolved in #128


update disconnect fails when disconnecting multiple items

When I try to disconnect multiple ids on an update query, prisma throws an error. The schema generated allows for the disconnect to be a ModelWhereInput but prisma is expecting a ModelWhereUniqueInput so I can only disconnect one per query.

This should not happen as input types are generated based on Prisma DMMF, which is based on generated Prisma Client.


Re-ingesting an SBOM will leave traces of previous version

Right now, when ingesting an SBOM (probably advisories too) creates all new components (if they don't yet exist).
However, this pattern will not remove components which got removed.

sounds like we first need a test to confirm this

sounds like we first need a test to confirm this

I am also not sure if that is a the case. As a different SBOM will have a different digest, and that's how we separate that now. Which brings this discussion back to the ID problem.

so this is a kind of optimisation - as things are today they are simple but take up more space (which might impact operation) ... I guess we list such duplicates of packages in the ux as well.

I guess we list such duplicates of packages in the ux as well.

Yes, I think we just should come up with expectations on how this should work. Right now it's simple, costs more storage, and might show duplicates. If that's ok, then it's ok :)


Add search in repo and branch select

If you have a lot of repos or branches it's hard to find the repo or branch you want. This PR adds svelete-se to allow search in the selects
https://user-images.githubusercontent.com/1051509/160298316-57b08c8b-a360-423d-b8e0-819b06656292.mp4

Thanks for the great improvement!


Upgrade to Laravel 9

This PR contains an upgrade of the application from Laravel 5.4 all the way to Laravel 9 which is the current major version.
In the Laravel World we have a tool called Laravel Shift which can be used in the future for upgrades, it takes care of 99% of the work and adds comments for the manual work needed from you 👍
However I did this upgrade for you as it contains many major versions. (before Laravel 6, Laravel did not use semantic versioning, so 5.5, 5.6, 5.7 and 5.8 were all major versions also when following semantic versioning)
@carlschroedl Taking the conversation here instead of answering your email for visibility to everyone 😃
I did try out the app and everything seems to work, but please double check.
Breaking changes
Before this can be deployed, the server would need an upgrade to PHP 8.1 as the application was also using a very outdated PHP version. No idea how this is hosted, but I can supply a docker file for you if that's easier 👍

Wow! Massive thanks Oliver! I will take a closer look soon.

@carlschroedl The swagger has completely changed as it was a lot out of date.
There will prob. be more work required to make the new swagger be completely correct again. Not that familiar with it 👍


Change Style/RedundantFreeze message

This commit changes the message for Style/RedundantFreeze. The new message is less aggressive and is more uniform with other messages in the code base, like Lint/HandleExceptions.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@bbatsov Message updated.

You've broken the build by changing the style of the string quotes. You'll also need to rebase.

The build is still failing.


151: Add Metamask Token Integration

Added new placeholder icons (waiting for design to confirm)
Added metamask integration for OHM and sOHM tokens
Buttons only show up where the "Get Ohm" is also shown (ie, only for devices that have space such as tablets and desktops)

Fixes: https://github.com/OlympusDAO/olympusdao/issues/151

This is just waiting on design to confirm the sOHM icon + look and feel. Functionality is done.

@dwjanus yea regarding design/placement, still waiting on design folks to decide the final design of these icons and where they should be placed.
Regarding detecting token presence, can you elaborate? was looking into how to do this but couldn't figure it out.

@ohmie33 one more thing: is it possible to dismiss the OHM tooltip on lose focus? So clicking outside of the HTML div should close it. What do you think?

@unbanksy , nice suggestions, will do them. Regarding the dismissing menu, i spent some time trying to do that last night but couldn't. So could be an improvement in another PR. Unless you know of an easy way to do it?

@unbanksy all suggestions have been addressed.


globals.css

Updated the dark color to dark: #1c1c1c
Describe your changes
Screenshots - If Any (Optional)
Issue ticket number and link - If Any
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] Followed the repository's Contributing Guidelines.
[ ] I ran the app and tested it locally to verify that it works as expected.

Additional Information (Optional)
Any additional information that you want to give us.

Hi @KCoder29 This issue has been completed by the person it was assigned to.


Astronomy/Auroras/SolarActivity2024: G2 Watch

| G2 Watch for July 24th | NOAA / NWS Space Weather Prediction Center | Monday, July 22, 2024 13:53 UTC |
| Aurora alert: Possible geomagnetic storm could bring northern lights as far south as New York | Space | July 22, 2024 |

#4248 moved to

#4246


Feature 581 bring back fake user

Description:
This PR,

Adds a fake userId when the app starts if the user is not logged in via Auth0
Overrides the Chrome version in the electron app mainWindow to be the app's current version

This PR must be deployed with GTM tag updates for Intercom - settings Update and Intercom - Boot
Check List:

[x] integration tests pass and have sufficient coverage of new changes (npm run integration)
[x] added unit tests if necessary

LGTM

Coverage remained the same at 90.727% when pulling 07811602c5d7bcbc9e05f1596eaf23b6547d7618 on feature-581-bring-back-fake-user-id into b8395f4021d16ad7734218cb2c242eeb6de6c507 on develop.

Coverage remained the same at 90.727% when pulling 82987d248941c8eb7536d4db9bf86ad4e83ed3f2 on feature-581-bring-back-fake-user-id into b8395f4021d16ad7734218cb2c242eeb6de6c507 on develop.

Coverage remained the same at 90.727% when pulling 82987d248941c8eb7536d4db9bf86ad4e83ed3f2 on feature-581-bring-back-fake-user-id into b8395f4021d16ad7734218cb2c242eeb6de6c507 on develop.


-U --update option has problems on windows if not given absolute path to youtube-dl.exe

Clarification:
'youtube-dl.exe' is placed in a dir. on the path that I have write permissions to.
Let's say I'm in 'C:\SomeDir' and 'youtube-dl.exe' is in 'c:\users\MyProfile\bin' that is on the path.
If I then run:
C:\SomeDir> youtube-dl.exe -U

I get the 'ERROR: no write permissions on youtube-dl' message
Giving the full path on the other hand works fine:
C:\SomeDir> c:\users\MyProfile\bin\youtube-dl.exe -U

and changing directory to where 'youtube-dl.exe' is placed also works:
c:\SomeDir> cd c:\users\MyProfile\bin\
c:\users\MyProfile\bin> youtube-dl.exe -U

This happen with the version '2015.09.03'
I can't check it with latest version ('2015.09.09') as this just tells me that it's up-to-date so it never tries to write to disk.
--henrik

I think it's the same issue as #2718, could you confirm?

Yes, I can confirm. This issue, #6829, is a duplicate of #2718.
Should I close this issue?


Parse required-flatpak and enforce a minimum version for new metadata

contingency plan if the fallback mechanism does not arrive in Flatpak 1.16.0

Needs newer appstream, ubuntu-latest will switch to 24.04 next week.


Incorrect ordering of mixed-alphanumeric strings with leading 0s

var naturalOrderby = require("natural-orderby")

naturalOrderby.orderBy(["05", "06", "07*", "08A", "09 B", "10", "11", "12A", "13"])

Expected result: no change. Actual result:
["05", "06", "07*", "10", "11", "12A", "13", "08A", "09 B"]
See https://runkit.com/embed/b88ooo12p3ap
I think I have the specifics pinned down in the title, but I'm not sure if that's quite it. I know repeating the test with numbers ranging from 15 to 23 behaves as expected, and I can't find any non-alphabetic characters that prompt the same error.

Thanks for reporting this issue!
Currently a number with leading zeros is only parsed as a number, if it´s not followed by a letter to be able to sort filenames prefixed with numbers containing leading zeros (e.g. 001filename.txt, 01filename.txt).
So, in your case the numeric parts of the strings ´"08A"´ and ´"09 B"´ are kept as a string: "08" and "09". That´s why they are sorted to the end, because the numeric parts of the other elements are getting parsed to numeric values before sort.
I´ll fix this during the following week by keeping the ability to sort filenames prefixed with numbers containing leading zeros.


ContainerAnnotationAnchor is broken

This thing throws error: Class constructor EventEmitter cannot be invoked without 'new'
Probably you should remove this line as you do mixin belows.

I have a fix I think in #118. Does this help? The problem with this fix is that we pollute top-level things with EventEmitter. Also, generally, don't expect container annos to work yet.

Not sure that i get what you mean with that old issue.
I don't expect them to work, but now it's throwing error. If you switched to mixins (like in component) then you don't need to call it in constructor I think.

I must say that this error comes with es6ification of models.

Sorry wrong link. #818 it is.

Ok, it's gone wit merge.


Follow up the dialog with Amplify team/project

Contact the team and have a walkthrough of the components
Decide what is useful
Get an overview of the amount of work


notepad++ is disabled

modify(find="Notepad" vis=true)

modify(find="Edit with Notepad" vis=true)
change search string "Edit with Notepad"

modify(find="Edit with Notepad" vis=true)
change search string "Edit with Notepad"

hello, Which file should I modify？

open \imports\modify.nss in text editor, like notepad.exe
copy the code at the end of the file, save it, reload the app with ctrl+right click or restart explorer.exe

open \imports\modify.nss in text editor, like notepad.exe copy the code at the end of the file, save it, reload the app with ctrl+right click or restart explorer.exe

I copy the code and restart explorer.exe, the edit with notepad++ is still disabled, maybe I need to restart my computer?

like it , it's OK!

 like it , it's OK!

OK， it's work . thanks

modify(find="Edit with Notepad" vis=true)
change search string "Edit with Notepad"

This worked for me, thanks @RubicBG

@dijkstar0317 Please close this issue if solved.


Support async io with asyncify

I'm not sure if this completely works, but I'd like to think it does. To finish this I just need to go through all of the io functions and add async implementations.
A few questions:

Should I expose the asyncify function on the WASI object, so that users of this module can use it to implement their own async functions?
Does everything follow the coding style of wasmer-js?
Is this even in the scope of wasmer/wasi? Or should it be split out into a separate module and then used from wasmer/wasi? I purposely didn't fully implement the asyncify ABI because I knew that there should only be one entry function to the module, so the implementation might get more complicated if it was split out.
Does anyone have any better solutions for allocating the asyncify data structure than requiring a _wasi_asyncify_alloc? Should we check first for malloc and then for that function?

This PR is super interesting. Great work!
We tried to rely on asyncify before but discarded because it was too slow on doing the asyncification on the client.
However, this PR relies on a wasm already asyncified, and I have to say that I like the approach!

Should I expose the asyncify function on the WASI object, so that users of this module can use it to implement their own async functions?
Not for now, I think we can generalize once someone asks for it or have a different implementation.

Does everything follow the coding style of wasmer-js?
I will review the code in a second and post the feedback, if any.

Is this even in the scope of wasmer/wasi? Or should it be split out into a separate module and then used from wasmer/wasi? I purposely didn't fully implement the asyncify ABI because I knew that there should only be one entry function to the module, so the implementation might get more complicated if it was split out.
Yeah, anything that improves the usability and use cases of wasmer/wasi is encouraged!

Does anyone have any better solutions for allocating the asyncify data structure than requiring a _wasi_asyncify_alloc? Should we check first for malloc and then for that function?

I don't have that much feedback on that. Perhaps @tlively can give some light on that :)

I added some comments.
In general the implementation duplicates the implementation for few functions.
As a suggestion, if my first feedback works on your PR, it will be ideal to create a new asyncify "wrapper" function maybe_asyncify (similar to wrap) that will asyncify the function in case this.asyncified is true.
That way the implementation will be simpler and we will not need to re-implement the fd_write, ... functions.
Example:
      fd_read: maybe_asyncify(wrap(
        (fd: number, iovs: number, iovsLen: number, nread: number) => {
          // ...
        }
     )),

Does anyone have any better solutions for allocating the asyncify data structure than requiring a _wasi_asyncify_alloc? Should we check first for malloc and then for that function?

I don't have that much feedback on that. Perhaps @tlively can give some light on that :)

I don't have context on the change, tools, or design precedents, but from my shallow understanding of the problem, I would personally prefer to have the allocator be explicitly configured rather than having a slightly more complicated semantics with a default and a fallback behavior. But IMO you should not take my opinion into account ;)

Sorry everyone, this isn't really working in the project that I'm working on, if anyone coming from a search engine wants to pick this up and work on it feel free, but I think I'm going to look into doing something similar to wasm-terminal for running wasi programs as processes. Thanks for the insightful reviews @syrusakbary, sorry to waste your time.

@coolreader18 no worries, we are here to help!


Unit conversion fixes

I've swapped to using openscm-units for the unit conversion, so things won't break every time a new unit is given. This also required updating some other places, and highlighted an ambiguity in the N2O unit labelling.

@maritsandstad

This PR fixes the N2O ambiguity which has bitten (sort of) https://github.com/openscm/openscm-units/pull/25

This is probably a very good fix. Just need to make sure I understand it properly, so it doesn't cause any new weird behavior... @znicholls, do you know why all the expected values shifted slightly for this update? I started the full WGIII dataset rerun last night, but should I then maybe redo it again after merging this PR in?

do you know why all the expected values shifted slightly for this update?

Rounding errors I believe. The conversions used by openscm-units are exact (e.g. 14/46), as compared to the decimal approximations that were used previously (e.g. 0.304). The ~0.1% change introduced by this propagates through to all the other results (which also change by ~0.1%).

I started the full WGIII dataset rerun last night, but should I then maybe redo it again after merging this PR in?

I wouldn't worry, 0.1% change isn't an issue and there'll be more runs to come in future.

Ok, that makes sense! (After trying to chasing this bug down for a very frustrating more than a week, I'd like to know I have a bit more of a grasp of what's going on where in the code... I'll likely just forget by the time I need to go back, though...)


Improve API docs

Fixes #940
This branch currently uses a beta version of Typedoc; we may want to hold off on merging until Typedoc 0.18 is released.
Improvements:

Re-exported symbols are documented (for example: css, html, unsafeCSS show up in the lit-element modules).
Decorator API docs now show up. On the lit-element module page, they show up in their own section ("Decorator functions").
Example code for decorator functions is formatted correctly.
The API doc for the updating-element module is no longer a license header.
Functional links added in a number of places in place of static text ("css tag function" replaced with "[[css]] tag function" which creates a link to the right API member).

Staged: https://20200320t185110-dot-polymer-lit-element.appspot.com/api/modules/lit_element.html

This is a massive improvement. I say ship it ASAP :)


stub functions for wait_for_service

This is needed so that rcl can compile. All the code which uses this downstream is configured to not test this code (which just raises 'not implemented').
Connects to ros2/ros2#215

This is also in review. It's just the bare minimum for getting the rmw and rcl wait_for_services merged.

+1