NestedAggregation doesn't work as expected

PHP Version: 8.2.21   | Shopware Version: <IP_ADDRESS>  | Affected area / extension: Platform(Default)

Expected behaviour:
We want the filter to apply on the aggregation result
{
  "query": {
      ...
  },
  "aggregations": {
    "manufacturer": {
      "filter": {
        "nested": {
          "path": "categories",
          "query": {
            "terms": {
              "categories.id": [
                "7828377598bf486fae6daa8c1abf91ee"
              ]
            }
          }
        }
      },
      "aggregations": {
        "manufacturer": {
          "terms": {
            "field": "manufacturerId",
            "size": 10000
          }
        }
      }
    },
    "price": {
      "filter": {
        "nested": {
          "path": "categories",
          "query": {
            "terms": {
              "categories.id": [
                "7828377598bf486fae6daa8c1abf91ee"
              ]
            }
          }
        }
      },
      "aggregations": {
        "price": {
          "stats": {
            "script": {
              "id": "cheapest_price",
              "params": {
                "accessors": [
                  {
                    "key": "cheapest_price_rule0deb3a3e833d41838544bfbadffc8517_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_rule14ddd0286e9c4685aa1a068fc5db54c9_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_ruleab7203a8ecdb43279bb26d40aec1f6db_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_rulebb0908102ade40af8119de87f12df762_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_rule5b4eecde79174fc2ac767e9b9b9f05dd_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_rule84b53a194950443b927337ecb0b949c5_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_ruled4f41bbd1ed04a5c95a9350175f6da17_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_ruledefault_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  }
                ],
                "decimals": 100,
                "round": true,
                "multiplier": 100
              }
            }
          }
        }
      }
    },
    "rating-exists": {
      "filter": {
        "range": {
          "ratingAverage": {
            "gte": 0
          }
        }
      },
      "aggregations": {
        "rating-exists": {
          "filter": {
            "nested": {
              "path": "categories",
              "query": {
                "terms": {
                  "categories.id": [
                    "7828377598bf486fae6daa8c1abf91ee"
                  ]
                }
              }
            }
          },
          "aggregations": {
            "rating": {
              "max": {
                "field": "ratingAverage"
              }
            }
          }
        }
      }
    },
    "shipping-free-filter": {
      "filter": {
        "term": {
          "shippingFree": true
        }
      },
      "aggregations": {
        "shipping-free-filter": {
          "filter": {
            "nested": {
              "path": "categories",
              "query": {
                "terms": {
                  "categories.id": [
                    "7828377598bf486fae6daa8c1abf91ee"
                  ]
                }
              }
            }
          },
          "aggregations": {
            "shipping-free": {
              "max": {
                "field": "shippingFree"
              }
            }
          }
        }
      }
    },
    "properties": {
      "filter": {
        "nested": {
          "path": "categories",
          "query": {
            "terms": {
              "categories.id": [
                "7828377598bf486fae6daa8c1abf91ee"
              ]
            }
          }
        }
      },
      "aggregations": {
        "properties": {
          "nested": {
            "path": "properties"
          },
          "aggregations": {
            "properties": {
              "terms": {
                "field": "properties.id",
                "size": 10000
              }
            }
          }
        }
      }
    },
    "options": {
      "filter": {
        "nested": {
          "path": "categories",
          "query": {
            "terms": {
              "categories.id": [
                "7828377598bf486fae6daa8c1abf91ee"
              ]
            }
          }
        }
      },
      "aggregations": {
        "options": {
          "nested": {
            "path": "options"
          },
          "aggregations": {
            "options": {
              "terms": {
                "field": "options.id",
                "size": 10000
              }
            }
          }
        }
      }
    },
    "category-ids": {
      "nested": {
        "path": "categories"
      },
      "aggregations": {
        "category-ids": {
          "terms": {
            "field": "categories.id",
            "size": 10000
          }
        }
      }
    }
  },
  "size": 0
}

Actual behaviour:
We don't want to change the path for the exisiting aggregations. That makes no sense.
{
  "query": {
      ...
  },
  "aggregations": {
    "manufacturer": {
      "nested": {
        "path": "categories"
      },
      "aggregations": {
        "manufacturer": {
          "terms": {
            "field": "manufacturerId",
            "size": 10000
          }
        }
      }
    },
    "price": {
      "nested": {
        "path": "categories"
      },
      "aggregations": {
        "price": {
          "stats": {
            "script": {
              "id": "cheapest_price",
              "params": {
                "accessors": [
                  {
                    "key": "cheapest_price_rule0deb3a3e833d41838544bfbadffc8517_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_rule14ddd0286e9c4685aa1a068fc5db54c9_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_ruleab7203a8ecdb43279bb26d40aec1f6db_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_rulebb0908102ade40af8119de87f12df762_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_rule5b4eecde79174fc2ac767e9b9b9f05dd_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_rule84b53a194950443b927337ecb0b949c5_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_ruled4f41bbd1ed04a5c95a9350175f6da17_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  },
                  {
                    "key": "cheapest_price_ruledefault_currencyb7d2554b0ce847cd82f3ac9bd1c0dfca_gross",
                    "factor": 1
                  }
                ],
                "decimals": 100,
                "round": true,
                "multiplier": 100
              }
            }
          }
        }
      }
    },
    "rating-exists": {
      "filter": {
        "range": {
          "ratingAverage": {
            "gte": 0
          }
        }
      },
      "aggregations": {
        "rating-exists": {
          "nested": {
            "path": "categories"
          },
          "aggregations": {
            "rating-exists": {
              "filter": {
                "terms": {
                  "categories.id": [
                    "7828377598bf486fae6daa8c1abf91ee"
                  ]
                }
              },
              "aggregations": {
                "rating-exists": {
                  "reverse_nested": {},
                  "aggregations": {
                    "rating": {
                      "max": {
                        "field": "ratingAverage"
                      }
                    }
                  }
                }
              }
            }
          }
        }
      }
    },
    "shipping-free-filter": {
      "filter": {
        "term": {
          "shippingFree": true
        }
      },
      "aggregations": {
        "shipping-free-filter": {
          "nested": {
            "path": "categories"
          },
          "aggregations": {
            "shipping-free-filter": {
              "filter": {
                "terms": {
                  "categories.id": [
                    "7828377598bf486fae6daa8c1abf91ee"
                  ]
                }
              },
              "aggregations": {
                "shipping-free-filter": {
                  "reverse_nested": {},
                  "aggregations": {
                    "shipping-free": {
                      "max": {
                        "field": "shippingFree"
                      }
                    }
                  }
                }
              }
            }
          }
        }
      }
    },
    "properties": {
      "nested": {
        "path": "categories"
      },
      "aggregations": {
        "properties": {
          "nested": {
            "path": "properties"
          },
          "aggregations": {
            "properties": {
              "terms": {
                "field": "properties.id",
                "size": 10000
              }
            }
          }
        }
      }
    },
    "options": {
      "nested": {
        "path": "categories"
      },
      "aggregations": {
        "options": {
          "nested": {
            "path": "options"
          },
          "aggregations": {
            "options": {
              "terms": {
                "field": "options.id",
                "size": 10000
              }
            }
          }
        }
      }
    },
    "categories": {
      "nested": {
        "path": "categories"
      },
      "aggregations": {
        "categories": {
          "terms": {
            "field": "categories.id",
            "size": 10000
          }
        }
      }
    }
  },
  "size": 0
}

How to reproduce:
Add following filter to the \Shopware\Core\Content\Product\Events\ProductListingCollectFilterEvent
        $filter = new Filter(
            'categories',
            [] !== $ids,
            [
                new EntityAggregation('categories', 'product.categories.id', 'category')
            ],
            new EqualsAnyFilter('product.categoryIds', $ids),
            $ids
        );

Cause of this issue is following code https://github.com/shopware/shopware/blob/trunk/src/Elasticsearch/Framework/DataAbstractionLayer/CriteriaParser.php#L225-L317.

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-39776
[created from NEXT-39776, comment 516545]

Hey there, thanks for your input, however we have some trouble really understanding what you want to accomplish and also what it really is that you would expect here.
Maybe it would help if you could provide a failing testcase? E.g. in the \Shopware\Tests\Unit\Core\Content\Product\SalesChannel\Listing\Processor\AggregationProcessorTest or provide an integration test for the issue that actually interacts with the database.
Without clearly understanding the issue I would assume that the behaviour is exactly as expected, because it is expected that the aggregation is executed before the filter, e.g. we have a pretty similar setup for the manufacturer filter:
        return new Filter(
            'manufacturer',
            !empty($ids),
            [new EntityAggregation('manufacturer', 'product.manufacturerId', 'product_manufacturer')],
            new EqualsAnyFilter('product.manufacturerId', $ids),
            $ids
        );

In that case it is expected that the aggregation will return all manufacturers in the unfiltered result set and only later do the filtering based on which manufacturers were selected in the frontend, this is needed to continue to display all the other filter option for the manufacturer that are currently inactive.

Seems like it is fixed in a newer Shopware version. Somewhere in https://github.com/shopware/elasticsearch/compare/v<IP_ADDRESS>...v<IP_ADDRESS>. Can we partially upgrade the project? For example only the elasticsearch part?

It isn't fixed. The ElasticsearchProductTest isn't applying filters the same way as the productlistingroute does. This gives confusing results. We opted to do a dirty fix as this is quite complex.


Place data format op on CPU:0.

Cherrypicking cl/192302833

Agreed that this matches the already reviewed cl/192302833.


ld ra rb rc

Tested Version
v0.0
Description
It compiles but shouldn't.
Steps
Compile and run assembler.exe.
Create a file named example.asm containing: ld ra rb rc.
cmdline: assembler.exe example.asm example.bin.
Context
This test was done on 02/23/24 before the project deadline.
Actual Result (optional screenshot)
//
Security Criteria
3
Discovery/Resolve Date
02/23/24
Expected Result
It should send an error.
Possible Solution
//
Other
//

This was handled on a previous commit before the merge and the pull request of dev to main.


Request for tensorflow(not tflite) models with weights.

Could you please share initial tensorflow or keras models?
It will allow the use of transfer learning. For example, gesture recognition or the use of a RGBD sensor for more accurate results.

@kulievvitaly Pls see my comment in another related issue
https://github.com/google/mediapipe/issues/13#issuecomment-514286492

The question is about tensorflow neural networks and weights, not about datasets.

@kulievvitaly We released the tflite binary with weights. We do not release saved models for hand models


Slow test teardown

Describe the problem.
EDIT: see comments for updates.
Running pytest with --durations=50 yields:
==================================== slowest 50 durations ====================================
10.06s teardown tests/store/dim/websockets_test.py::test_websocket_store
0.24s setup    tests/integration/endpoints_test.py::test_endpoint_proxy_transfer
0.24s setup    tests/integration/endpoints_test.py::test_endpoint_transfer
0.24s setup    tests/integration/endpoints_test.py::test_proxy_detects_endpoint
0.19s call     tests/integration/endpoints_test.py::test_proxy_detects_endpoint

tests/store/dim/websockets_test.py::test_websocket_store is taking 10.06 seconds of the total 14.47 seconds for the entire test suite.
This test covers the following:
Name                                 Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------------------------
proxystore/store/dim/websockets.py     162      1     22      2    98%   217->222, 233

Which is 1) terminating the server process on store.close() and 2) raising a timeout error if the server cannot be connected to.
How did you install ProxyStore?
Installed from `main`.

ProxyStore Version
4c942ae3d8036531c3341361e3bb3f3c116574b7
Python Version
3.10
OS and Platform
x86 Ubuntu

Turns out the issue persists if you run pytest -k "not test_websocket_store" and tests/store/dim/ucx_test.py::test_ucx_server` becomes the 10s test. In both cases, it's the last test that has the expensive teardown.
Weirdly, the teardown is fast if running pytest tests/store or any of the other test modules by themselves.

Upon further investigation, the issue is related to ucx_test.py::test_run_mocked_server.


fatal error: 'cstdint' file not found

Hi,
I'm trying to install node-parquet, using "npm install node-parquet" on my macOS Sierra.
I installed all the dependencies, but i'm getting this error:
[100%] Built target parquet_static

<EMAIL_ADDRESS>install /Volumes/Data/Desenvolvimento/repositories/web/parquet_reader/node_modules/node-parquet
node-gyp rebuild

CXX(target) Release/obj.target/parquet/src/parquet_binding.o
In file included from ../src/parquet_binding.cc:3:
In file included from ../src/parquet_reader.h:8:
In file included from ../deps/parquet-cpp/src/parquet/api/reader.h:22:
../deps/parquet-cpp/src/parquet/column/reader.h:22:10: fatal error: 'cstdint' file not found
#include
^
1 error generated.
make: *** [Release/obj.target/parquet/src/parquet_binding.o] Error 1
gyp ERR! build error

cstdint refers to a missing C++ standard library header. It seems that your C++ toolchain is not properly installed.

Thanks, i will try to solve this, and let you know to close this.


fix dlrm and asr benchmark

Type of Change
feature or bug fix or documentation or validation or others
API changed or not
Description
detail description
JIRA ticket: xxx
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed

https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/3920/

https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/3935/


SAS-1527 add conversations.open route to support new slack standard

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Levente Szabo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


feature(twig): replaced the twig package with twig-new

Fixes #1119
The old twig package is gone. RIP twig. Hello twig-new.

Test are failing because the changes to the base theme (https://github.com/international-labour-organization/ilo_base_theme/issues/26) have not been merged yet.
Proceeding with merge so that we can proceed with (#1038)


vendoring github.com/camlistore/go4/lock

Please consider vendoring github.com/camlistore/go4/lock.
As they highlight in details, "go4 makes no backwards compatibility promises. If you want to use go4, vendor it.".
That's also why it is not feasible to ship go4 as package to satisfy dependency of cznic/ql...
Vendoring go4/lock should help to make ql distribution comprehensive and reliable.
Thanks.

@onlyjob Alternatively, would it be ok for your purposes if I will fork go4/lock and import this fork?

I'm not sure... Embedded forks are usually a bad practice and camlistore/go4 is unpackageable mess... Is there are any better (maintained) alternatives to handle locks?
It should be OK to bundle fork but it means extra maintenance effort to sync with upstream and forward your improvements...

Okay, I will vendor the package.

Thank you. :)

Please checkout and test branch issue122 and let me know if fit for merging.
Note: vendored in the path is not a typo, I want to avoid any vendoring mechanism handling specially the vendor subdirectory.

@onlyjob Gentle ping.

Sorry for delay. I have to deal with some other priorities for now... I'll get back to it as soon as I can...

No problem, no hurry ;-)

Looks good, thank you. It might be a good idea to vendor github.com/cznic/exp as well because it is considered to be unstable just like camlistore/go4?

Thanks for looking into this.

It might be a good idea to vendor github.com/cznic/exp as well because it is considered to be unstable just like camlistore/go4?

Will do.

Thank you.

PTAL

?

I was having this problem:
go get -v github.com/cznic/ql/ql
github.com/cznic/ql (download)
github.com/camlistore/go4 (download)
package github.com/cznic/ql/ql
	imports github.com/camlistore/go4/lock
	imports github.com/camlistore/go4/lock
	imports github.com/camlistore/go4/lock: code in directory /home/travis/gopath/src/github.com/camlistore/go4/lock expects import "go4.org/lock"

But I guess that is related to this other one, right?

@onlyjob

?

Please elaborate, I'm slow today ;-)

I was hoping you can elaborate on "PTAL". What is it stand for?

My apologies for not being clear!
It means: Please Také Another Look.

Looks good, thank you. :)


request to follow SemVer/mention it in README

Do you follow semantic versioning defined at semver.org? If yes, can you mention it in README. If not, can you consider it?

closing in favor of #39


Use official Minio Chart instead of custom one

the helmfile.d/0020.minio.yaml mentioned that the minio deployment is
based on the minio operator ... but that's not true. It's a self written
helm chart without using the CRDs of the minio operator!
Our motivation was to replace the custom helm deployment with the
upstream one from minio. So we can enable persistence, without adding
that as a feature to the self written helm chart.
Co-authored-by: Petra Scherer<EMAIL_ADDRESS>Co-authored-by: Timo Klenk<EMAIL_ADDRESS>Signed-off-by: Johannes Graf<EMAIL_ADDRESS>

@grafjo: Any updates here. Did you have time to think about my remarks?


Blas xGEMM launch failed: RTX3080 with CUDA 10.0

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04 LTS, used within a Docker container
TensorFlow installed from (source or binary): from Docker image tensorflow/tensorflow:1.14.0-gpu-py3
TensorFlow version (use command below): 1.14.0-gpu
Python version: 3.7
CUDA/cuDNN version: 10.0/<IP_ADDRESS>
GPU model and memory: 2xRTX 3080

Describe the current behavior
While loading a PointCNN model I got the following error (snippet):
(0) Internal: Blas xGEMM launch failed : a.shape=[1,20000,3], b.shape=[1,3,20000], m=20000, n=20000, k=3
Tensorflow is run with the following config options:
  config.gpu_options.allow_growth = True
  config.allow_soft_placement = True
I also tried setting them to false.
Describe the expected behavior
The same model is successfully loaded on another machine with Ubuntu 20.04 LTS within the same Docker container but with Nvidia 970GTX.
I think this may be related to CUDA 10.0 support on RTX 3080?
Full error log:
Exception has occurred: InternalError
2 root error(s) found.
  (0) Internal: Blas xGEMM launch failed : a.shape=[1,20000,3], b.shape=[1,3,20000], m=20000, n=20000, k=3
	 [[node while/generator_ops/PointCNN/MatMul (defined at src/src/tf_utils/pointfly.py:572) ]]
  (1) Internal: Blas xGEMM launch failed : a.shape=[1,20000,3], b.shape=[1,3,20000], m=20000, n=20000, k=3
	 [[node while/generator_ops/PointCNN/MatMul (defined at src/src/tf_utils/pointfly.py:572) ]]
	 [[while/preprocessing_ops/batch_nonuniform_sample/while/concat_1/_807]]
0 successful operations.
0 derived errors ignored.
Errors may have originated from an input operation.
Input Source operations connected to node while/generator_ops/PointCNN/MatMul:
 while/preprocessing_ops/batch_nonuniform_sample/Reshape (defined at src/src/tf_utils/pointfly.py:370)
Input Source operations connected to node while/generator_ops/PointCNN/MatMul:
 while/preprocessing_ops/batch_nonuniform_sample/Reshape (defined at src/src/tf_utils/pointfly.py:370)

I think that Docker image tensorflow/tensorflow:1.14.0-gpu-py3 doesn't support RTX3080. Can you try tensorflow/tensorflow:2.4.0rc1-gpu?

I think that Docker image tensorflow/tensorflow:1.14.0-gpu-py3 doesn't support RTX3080. Can you try tensorflow/tensorflow:2.4.0rc1-gpu?

Yes, it seems to be working with 2.4.0rc1. Thank you!

@AZadora,
Thank you for the update. Marking this issue as closed, as it is resolved. Please feel free to re-open if necessary.


Review faas invoked_name, invoked_provider, invoked_region attributes

I see here a duplication of data for invoked_name, invoked_provider and invoked_region. Was it needed because of strict separation between resource and not resource attributes? Should we remove it now and replace with original fields as we are going into removing this restriction in build tools?
Originally posted by @trisch-me in https://github.com/open-telemetry/semantic-conventions/pull/525#discussion_r1422265853
Currently we have notes for these fields as following:
`invoked_name`  SHOULD be equal to the `faas.name` resource attribute of the invoked function.

`invoked_provider ` SHOULD be equal to the `cloud.provider` resource attribute of the invoked function.

`invoked_region` SHOULD be equal to the `cloud.region` resource attribute of the invoked function.

I don't think this was added due to tooling restrictions but rather because the semantics are intended to be different.
Consider the following example:
  Service A           --invokes-->     Function B
------------------------------------------------------------
Resource as reported by B:
                                       faas.name=B
                                       cloud.provider=MyCloud
                                       cloud.region=World
------------------------------------------------------------
Span as reported by A:
  faas.invoked_name=B
  faas.invoked_provider=MyCloud
  faas.invoked_region=World

If both resource and span attributes would be flattened (particularly when exporting in a non-OTLP format or as OTLP to a back-end that does not distinguish them) this would cause ambiguity if the same attribute keys were used. In these cases, the span created by Service A with a span attribute cloud.provider=MyCloud would make Service A appear to be hosted there (as if it was its own resource), which might not be the case since it's instead actually describing the invoked Function B.
Service A could also itself be a function and have its own faas.name/cloud.provider/cloud.region resource attributes set and then they would even clash upon flattening.

great point @arminru!
BTW I think it's where @trisch-me embed proposal could help.
With it we could do something like
- id: faas
  prefix: faas
  attributes:
    - embed: cloud.provider

and it'd result in faas.cloud.provider attribute getting all it's properties and members from the original cloud.provider.
I think naming could be improved, but I guess we could also support custom naming when embedding attributes.


Release 1.5.0.Beta12

Summary
Releases 1.5.0.Beta12. This release contains:

https://github.com/quarkus-qe/quarkus-test-framework/pull/1223
https://github.com/quarkus-qe/quarkus-test-framework/pull/1224

Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[ ] Refactoring
[x] Release (follows conventions described in the RELEASE.md)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[ ] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[x] Example scenarios has been updated / added
[x] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

Strimzi failure not related.


AccountContract is missing #[starknet::interface]

https://github.com/starkware-libs/cairo/blob/b47729624df54bcb3691c62a4d875a8d48f6220e/corelib/src/starknet/account.cairo#L10
Because of this, no dispatcher/trait is generated. Should they be?

also why isn't this version from 3 weeks ago published in 2.0.1? 🤔

generally our compiler release process for a starknet version:
we start with some major.minor.0-rc0
we add required fixes while updating only the rc version major.minor.0-rc<i>.
when we decide we are done we release major.minor.0 - and then only do fixes that are a must in the patch version major.minor.patch.


add ci, ability to view currently playing image

bleh caching

ERROR: Could not find a version that satisfies the requirement mpv-history-daemon>=0.2.3 (from currently-listening-py[testing]) (from versions: 0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.1.4, 0.1.5, 0.1.6, 0.1.7, 0.1.8, 0.1.9, 0.1.10, 0.2.0, 0.2.1)
ERROR: No matching distribution found for mpv-history-daemon>=0.2.3

https://pypi.org/project/mpv-history-daemon/


Implement feedback, fix false positive and silent failures.

@sonialeigh @andylai12 passed along your feedback. I've implemented all that I can, but the "Follow [Name]" text is a part of the template, not the content. https://review.learn.microsoft.com/en-us/community/learn-with/index?branch=pr-en-us-205 for your review, and merge to main if 👍🏻

@bmackinney to reach to an admin before merging

@sazimi or @shivaford This is ready to merge to main.


OAuthCard for slack still does not work

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Version
GA version of the bot framework V4 4.0.8
Describe the bug
Trying to authenticate a user inside the bot using the OAuthCard flow does not work for Slack.  As per the example for AADv2 I implemented the 'dialog' way of authenticating the user and included the OAuth prompt.  On web this works fine but in Slack it opens the browser to get the magic code and the code returned is not valid.
To Reproduce
Steps to reproduce the behavior:

Use the AADv2 sample and register your bot with Slack
Attempt to login
Click the Sign In button and the login browser appears, log in and copy the magic code
Paste and process the magic code and it is returned invalid

Expected behavior
The magic code returned should work and the user be logged in
Possible fix until remedied
in Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs include "slack" in the method ChannelSupportsOAuthCard as an exception
[bug]

I have cloned the OAuthPrompt class and created my own including "slack" to stop it using the OAuthCard and it now works


Error on every word with only one replacement

In your index.json, many words have a string value for replace instead of an array. Each one of these words gives me an error when you call .join on the replacement here: https://github.com/admhlt/retext-usage/blob/master/index.js#L62
giving: TypeError: quotation(...).join is not a function.
Could you either rework this condition so it only calls join on an array, or wrap every replace in an array, even if it's just one?

Getting this error also

Got this error as well


Regression: g:scrollview_refreshing stops working with commit b4a7bb3

g:scrollview_refreshing from #88 worked fine until I updated the plugin. I looked briefly into it and could determine that commit b4a7bb3 seems to be the culprit; with 1fef0fc it all still works fine.

Thanks for reporting the issue. I put a fix in 899576707be0707eb1a8b96afd382173aef0e45d.

thanks, that comment fixes the issue again 👍


Invalid access token when deploying on this application on heroku

I have deployed this code on heroku and it is giving me error invalid access token I have double check account sid and auth token are correct.
2.4eb97410.chunk.js:2 2022-02-16T17:03:51.152Z warn [TwilioConnection #1: wss://global.vss.twilio.com/signaling] Closed: 1002 - Invalid Access Token
this work properly on serverless but i want to deploy on heroku on on our own server.
Here is the link of app.
https://mcpreflight.herokuapp.com/

Hey @jeffss99 sorry to hear that you are having some issues deploying the app to Heroku. Sounds like you are getting the web app deployed just fine, but it's having trouble talking to the backend to get an access token.
In order to assist, we will need some more information from you. Do you mind sharing what server code you are deploying to Heroku, and how are you deploying it? Can you provide some sample code?
This will help us diagnose the issue and hopefully come up with a solution to get this deployed.
Thank you!

Hi @olipyskoty  Thanks for responding , I have created a public repo of code I am using
https://github.com/jeffss99/twilio-video-diagnostics-react-app-heroku
I have also added a section how to deploy on heroku and how to set .env on heroku.
Please let me know if you need anything more I can share heroku app as well.
Thanks

On further investigating it seems like It does not work in following cases
without proxy URL
npm run build
But it wok on local system with
npm run dev

Hey @jeffss99! Looks like you're trying to use the /serverless code for your server when you deploy to Heroku. Unfortunately, this code is meant to be used to deploy serverless endpoints to the Twilio Serverless environment, which is why you're receiving the Invalid Access Token error. It won't work with a different platform.
You'd need to create your own server code that generates a Twilio Access Token (which would also be used to obtain TURN credentials to start the bitrate test) in order to host your application somewhere other than Twilio. Your question actually inspired us to add this server code to the Video Diagnostics App so that customers like you can easily host their applications outside of Twilio. I have added a ticket to our internal backlog and this should be available in the near future. I'll keep you posted 🙂.
In the meantime, and if you'd like to get a head start, check out the node /server code from our Twilio Video React App. A lot of the code in index.ts and createExpressHandler.ts can be copied over, just remember that we won't need anything "conversations" or "recordingRules" related. Also, instead of require('@twilio-labs/plugin-rtc/src/serverless/functions/token').handler in index.ts, you can point to the /token and /turn-credentials files in the /serverless directory.
I'll respond to this question when the new /server code has been merged. Please let us know if you have any other questions!

Hello, @olipyskoty thanks for your help with this. From our understanding to host the diagnostic tool on Twilio, there is a 7-day limit for it being live. Is there a way to extend this?

Hey @jeffss99 and @shawnmintz!
Wanted to let you know about a couple of updates.
Firstly, we have added a new token server to this application (can be found in /server). This server uses the same endpoints as the serverless endpoints that are used when the app is deployed to Twilio Serverless. You can use this server to run the app locally by running the npm start command, but you can also use it for deployment purposes outside of Twilio Serverless! To set up this token server, please follow the instructions in the README.
Secondly, we have updated the application so that the passcode expiration date can now be edited when the app is deployed to Twilio Serverless. However, please note that we decided to set it to one week for security reasons (the numeric passcode is weak and could be guessed). Also, the quick deploy feature is only meant to be used for demo purposes.
To update the passcode expiration date, you'll need to login into the Twilio Console and navigate to the Functions editor (Functions > Services > YOUR_UNIQUE_SERVICE_NAME). Note, if you do not see the "Functions" product in the menu on the left, click on Explore Products > Developer tools > Functions > Manage Services. With this editor, you can edit the live token server and change environment variables. Click on Settings on the left, and then Environment Variables. Then you can edit the API_PASSCODE_EXPIRY variable, like this:

The API_PASSCODE_EXPIRY is the time that the passcode will expire, represented as the number of milliseconds that have passed since 1-1-1970. Simply change this number to whatever value you want.
Hopefully all of that helps you both out, but please let me know if you have any questions! Thank you!


UnicodeEncodeError - Several Different PDFs

Bug
Docling parses some pdfs successfully but fails to write the markdown file with the results.
UnicodeEncodeError: 'charmap' codec can't encode character '\u2217' in position 51: character maps to <undefined>
I was able to resolve this for this specific PDF by changing line 1941 in this file under docling_core\types\doc\document.py but the tests failed

Steps to reproduce

Download this pdf: https://typeset.io/pdf/computational-challenges-in-bounded-model-checking-44b7toabj9.pdf
docling computational-challenges-in-bounded-model-checking-44b7toabj9.pdf

I've encountered this on other PDFs as well:
https://batch.libretexts.org/print/url=https://math.libretexts.org/Bookshelves/Combinatorics_and_Discrete_Mathematics/Elementary_Foundations%3A_An_Introduction_to_Topics_in_Discrete_Mathematics_(Sylvestre)/03%3A_Boolean_algebra/3.02%3A_Disjunctive_Normal_Form.pdf
Docling version
Docling version: 2.12.0
Docling Core version: 2.9.0
Docling IBM Models version: 3.1.0
Docling Parse version: 3.0.0
Python version
Python 3.11.9

@nickrallison thanks for pointing this out!
I'll test it more, and if it's not breaking anything (which I think it shouldn't) we'll regenerate tests.

Just wanted to chime in that I love docling, been using it quite a bit for a personal project. I've encountered this error quite a bit when trying to parse long 300+ page PDFs into markdown. In a sample of about 50 lengthy PDFs about 50% of them experience this issue


Monkey payload

Fails for RandSeed = 875
   cCommands : array [0..46] of Integer = (
      ecChar, ecString, ecChar, ecString, ecChar, ecString,
      ecTab, ecShiftTab,
      ecInsertLine, ecLineBreak,
      ecDeleteChar, ecBackspace, ecDeleteLine, ecDeleteWord,
      ecLeft, ecRight, ecUp, ecDown, ecPageUp, ecPageDown,
      ecSelectionLeft, ecSelectionRight, ecSelectionUp, ecSelectionDown,
      ecLineStart, ecLineEnd, ecWordLeft, ecWordRight,
      ecSelectionLineStart, ecSelectionLineEnd, ecSelectionWordLeft, ecSelectionWordRight,
      ecPageUp, ecPageDown,
      ecSelectionPageUp, ecSelectionPageDown,
//      ecInsertMode, ecOverwriteMode,
      ecLineComment, ecBlockComment,
      ecBlockIndent, ecBlockUnindent,
      ecCopy, ecCut, ecPaste,
//      ecUndo, ecRedo,
      ecMoveLineUp, ecMoveLineDown, ecMoveCharLeft, ecMoveCharRight
      );
   cNBActions = 30;

Fixed.


Swift List

Is there a rational reason for why the List class is marked as final?
I ran into a situation where subclassing it is logical and makes sense.
I need a collection type, that will be stored in realm, which should return data in an ordered fashion. I intend for the collection to be very large. I suspect, just inserting items into a List as they come along and querying it as ordered every time would not be very performant.
What I am trying to do is have a subclass that inserts items in the correct order as they arrive. This way querying it would have the same performance as just getting a List in "as is" order and inserting would be log(numOfItems), which i consider to be quite performant.
Really don't want to have to fork Realm...
Either remove the final or tell me that I'm done and propose a better way to do this.
Any help will be greatly appreciated.

List is marked as final as it isn't built with external extensibility via inheritance in mind. You would need to be very careful when subclassing due to Realm's partial dynamic nature at runtime. For that reason, we limited subclassing to an absolute minimum.
Instead I would propose that you could either write a method on your Object subclass or as an extension on List:
extension List where Element: MySortableObject {
    func insertSorted(obj: Element) {
         // insert it at the correct position
    }
}

But as long as you don't have really big collections, which you need to query unfiltered and sorted all the time and already run in to troubles with performance, I'd recommend to use the built-in sorting.

I can't use extensions because adding such a method requires for obj to be Comparable, which it is not. I don't see a way to enforce this without subclassing. Please help.

@ilyakooo0 extension List where Element: Comparable { … } should do the trick!


events post type and post avatars

added the possibility to add a post author avatar image via frontmatter
post frontmatter: event: true leads to slightly different post layout.

Thanks!

Might be worth using the existing authorship functionality in Jekyll here?
https://jekyllrb.com/docs/step-by-step/09-collections/#add-authors

https://github.com/jekyll/jekyll-seo-tag/blob/master/docs/advanced-usage.md


HIVE-25116: Exclude slf4j from hive-exec uber Jar included by avatica

What changes were proposed in this pull request?

removing slf4j from hive-exec jar
Why are the changes needed?

maven shade plugin config changes
Does this PR introduce any user-facing change?

no
How was this patch tested?

manually checked whether all slf4j stuff was gone from the jar, also testing it together with other software components which are pulling in that artifact

@deniskuzZ could you review this pls?


Event when finished parsing pcap file (offline session)?

I'm loading and decoding a local PCAP file using pcap.createOfflineSession(). I need to know when the module is done parsing the PCAP file, but I don't see any evidence of an "end" event. Is there such a thing? Thanks

My mistake, I found the "complete" event in the source:
pcap_session.on("complete", () => {
	console.log("DONE")
})


Bug for array table

pyproject-fmt removes the instance of array table with double square brackets [[ ... ]] since version 2.0.0.

PR welcome.

Do you have link to repro file?

https://github.com/tox-dev/pyproject-fmt-rust/pull/17 would fix it

Fixed via https://github.com/tox-dev/pyproject-fmt/releases/tag/2.1.0


[UNDERTOW-1869] fix in memory session creation concurrency

Issue: https://issues.redhat.com/browse/UNDERTOW-1869
Under review. DO NOT MERGE.

I updated v2, its thinner and should not impact performance as much, but still fix the problem.

I'll be trying the approach suggested here before deciding which proposed fix we're going to go with: https://github.com/undertow-io/undertow/pull/1174#discussion_r670185480


Update meta-rust to morty

This branch of meta-rust contains everything we need - cargo dependency fetching and the Rust 1.13 compiler that the jethro and krogoth branches don't. Combined with a set of backports in meta-resin this seems to build healthdog OK.

@resin-jenkins retest this please


Don't set a default value for -o flag and fix ODO_LOG_LEVEL check

Signed-off-by: John Collier<EMAIL_ADDRESS>What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
What does does this PR do / why we need it:
Removes the default value of json for the -o / --output flag in odo. Since our default output is not in json, we don't need to be setting the default value for that flag to that.
Previously, it was being set and causing the ODO_LOG_LEVEL env var not to work, due to the check here:
https://github.com/openshift/odo/blob/master/cmd/odo/odo.go#L54
See the discussion in https://github.com/openshift/odo/pull/3115
Which issue(s) this PR fixes:
No issue, but I can open one.
How to test changes / Special notes to the reviewer:
Johns-MacBook-Pro-3:odo johncollier$ ODO_LOG_LEVEL=4 ./odo catalog list components
I0507 22:37:13.433129   65620 preference.go:165] The path for preference file is /Users/johncollier/.odo/preference.yaml
I0507 22:37:13.433317   65620 preference.go:165] The path for preference file is /Users/johncollier/.odo/preference.yaml
I0507 22:37:14.387035   65620 preference.go:165] The path for preference file is /Users/johncollier/.odo/preference.yaml
Odo OpenShift Components:
NAME              PROJECT       TAGS                        SUPPORTED
java              openshift     11,8,latest                 YES
nodejs            openshift     10-SCL,8,8-RHOAR,latest     YES
dotnet            openshift     2.1,2.2,3.0,latest          NO
golang            openshift     1.11.5,latest               NO
httpd             openshift     2.4,latest                  NO
modern-webapp     openshift     10.x,latest                 NO
nginx             openshift     1.10,1.12,latest            NO
perl              openshift     5.24,5.26,latest            NO
php               openshift     7.0,7.1,7.2,latest          NO
python            openshift     2.7,3.6,latest              NO
ruby              openshift     2.4,2.5,latest              NO

Odo Devfile Components:
NAME                 DESCRIPTION                           SUPPORTED
maven                Upstream Maven and OpenJDK 11         YES
nodejs               Stack with NodeJS 10                  YES
openLiberty          Open Liberty microservice in Java     YES
java-spring-boot     Spring Boot® using Java               YES

Johns-MacBook-Pro-3:odo johncollier$ ./odo catalog list components -o json
{
    "kind": "List",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "items": [
        {
            "kind": "ComponentType",
            "apiVersion": "odo.openshift.io/v1alpha1",
            "metadata": {
                "name": "dotnet",
                "namespace": "openshift",
                "creationTimestamp": null
            },
            "spec": {
                "allTags": [
                    "2.1",
                    "2.2",
                    "3.0",
                    "latest"
                ],
                "nonHiddenTags": [
                    "2.1",
                    "2.2",
                    "3.0",
                    "latest"
                ],
                "supportedTags": []
            }
        },

Johns-MacBook-Pro-3:odo johncollier$ ./odo catalog list components -o yaml
 ✗  Please input a valid output format for -o, available format: json

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/3121/pull-ci-openshift-odo-master-v4.3-integration-e2e/165#1:build-log.txt%3A390
/retest

@johnmcollier It seems your change causes one spec failure on both travis and OpenShift CI. PTAL
Travis - https://travis-ci.com/github/openshift/odo/jobs/329756324#L467

@amitkrout So I did some digging:
It appears the issue is related to retrieving the value for the -o json, `jsonFlagValue:
https://github.com/openshift/odo/blob/master/cmd/odo/odo.go#L53
Basically, it seems that we only ever retrieve an "accurate" value for the -o flag if it immediately follows odo itself:
Johns-MacBook-Pro-3:odo johncollier$ ODO_LOG_LEVEL=4 ./odo -o json project create tester
-o flag value: json
{
    "kind": "Error",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "message": "unable to create new project: unable to create new project tester: project.project.openshift.io \"tester\" already exists"
}

But if it follows at the end of the command, we're unable to look up the proper value
Johns-MacBook-Pro-3:odo johncollier$ ODO_LOG_LEVEL=4 ./odo project create tester -o json
-o flag value:
I0508 10:40:35.598886   67965 preference.go:165] The path for preference file is /Users/johncollier/.odo/preference.yaml
{
    "kind": "Error",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "message": "unable to create new project: unable to create new project tester: project.project.openshift.io \"tester\" already exists"
}

So basically, we're never actually looking up the proper value of the -o flag in odo.go (but we appear to be elsewhere in the code). The reason this wasn't seen before is that before my PR, the default value of the -o flag was json, so it wouldn't have been noticed.

@amitkrout From looking through the code, I've found a fix and will be pushing it up to this PR!

/retest - odo url create flake

/test v4.2-integration-e2e

/lgtm

/hold
This is a big decision and might affect vs-code adapter, also might require docs change. and we might need to consider the fact that the verbase logs are not written to stdout ( if I remember correctly ) so can't we just print the logs if someone provides -v with a json output?

@girishramnani as far I understand things, this doesn’t impact the functionality of odo. The previous default value of “json” for -o didn’t seem to work (or do anything), as json output wasn’t displayed by default.

/hold
This is a big decision and might affect vs-code adapter, also might require docs change. and we might need to consider the fact that the verbase logs are not written to stdout ( if I remember correctly ) so can't we just print the logs if someone provides -v with a json output?

How does it affect vs-code adapter? This just fixes something that was broken. No behavior is modified.

So, after a few hours of debugging, I've finally found a fix for this issue that doesn't break either the -o flag and also fixes the ODO_LOG_LEVEL environment variable.
So it appears that there isn't a way to retrieve the value of the -o flag from within odo.go, unless  the flag immediately follows odo. I.e:
With -o after odo
Johns-MacBook-Pro-3:~ johncollier$ odo -o json project create tester
-o flag value in odo.go: json
{
    "kind": "Error",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "message": "unable to create new project: unable to create new project tester: project.project.openshift.io \"tester\" already exists"
}

And with -o at the end of the command:
Johns-MacBook-Pro-3:~ johncollier$ odo project create tester -o json
-o flag value in odo.go:
I0511 16:35:52.169117   91077 preference.go:165] The path for preference file is /Users/johncollier/.odo/preference.yaml
{
    "kind": "Error",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "message": "unable to create new project: unable to create new project tester: project.project.openshift.io \"tester\" already exists"
}

This is because the other commands' flags/args have yet to be parsed, so odo.go can only see the flags that immediately follow the root command.
However, if we move the check for ODO_LOG_LEVEL outside of odo.go to somewhere the flags for all of the subcommands have already been parsed, then this issue wouldn't occur. So, what I did was move the check for ODO_LOG_LEVEL  to genericclioptions.CheckMachineReadableOutputCommand). This function already does some validation over whether or not verbose and JSON logging is enabled, so it was easy to drop right in.

With my new change:
Johns-MacBook-Pro-3:~ johncollier$ odo list
 ✗  Please specify the application name and project name
Or use the command from inside a directory containing an odo component.
Johns-MacBook-Pro-3:~ johncollier$ odo list -v 4
I0511 17:11:40.125767   41245 list.go:51] New Context
 ✗  Please specify the application name and project name
Or use the command from inside a directory containing an odo component.
Johns-MacBook-Pro-3:~ johncollier$ odo list -o json
{
    "kind": "Error",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "message": "Please specify the application name and project name\nOr use the command from inside a directory containing an odo component."
}
Johns-MacBook-Pro-3:~ johncollier$ odo list -o json -v 4
{
    "kind": "Error",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "message": "Please specify the application name and project name\nOr use the command from inside a directory containing an odo component."
}
Johns-MacBook-Pro-3:~ johncollier$ ODO_LOG_LEVEL=4 odo list
I0511 17:12:03.575813   41254 list.go:51] New Context
 ✗  Please specify the application name and project name
Or use the command from inside a directory containing an odo component.
Johns-MacBook-Pro-3:~ johncollier$ ODO_LOG_LEVEL=4 odo list -o json
{
    "kind": "Error",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "message": "Please specify the application name and project name\nOr use the command from inside a directory containing an odo component."
}
Johns-MacBook-Pro-3:~ johncollier$ ODO_LOG_LEVEL=4 odo list -o json -v 4
{
    "kind": "Error",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "message": "Please specify the application name and project name\nOr use the command from inside a directory containing an odo component."
}

/hold cancel
This was discussed in odo contributor call. @girishramnani is ok with that. And I've checked and verified that vscode plugin is calling odo using full -o json everywhere.

/hold cancel
This was discussed in odo contributor call. @girishramnani is ok with that. And I've checked and verified that vscode plugin is calling odo using full -o json everywhere.

/lgtm


Audit error types code base wide

PR aims to achieve two things:

Make error code brain dead easy to read
Get error code closer to being ready for v1.0

The first 8 patches are pretty basic, and are broken up into really small changes. The last patch is much bigger, it has a long git log to explain it but reviewing should not take too much brain power.
This PR does not introduce anything new, it just applies what we have been doing recently with errors. Before v1.0.0 others will likely want to re go over all the error types. As such I believe this PR can be merged under the one ack carve-out.
TODOs
We have a few errors that still need splitting up:

Split up merkle_tree::block::MerkleBlockError
Split up psbt::error::Error
Split up IncompleteBuilderError

Also, all error From's should probably have #[inline], I noticed late in the process and did not have the heart to visit every error again.

This all looks great to me!


pull request for e2e test at 12/20/2016 16:15:22

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


AuthorizationHandler and database dependency injection

We develop an multi-tenant application based on Identity authentication. Each user get a token session, stored in database, to tell if the user is still connected (with expiration time). I store the token (and others informations about the user company) in user Claim. After that Identity detect that the user is still connected (or not), I need to check if the user token is still valid in our database  (but only if he's connected), so I implemented AuthorizationHandler.
public TokenValidHandler(MyDatabaseService service)
{
      // No information about the user connection string
}

protected override async void Handle(AuthorizationContext context, TokenValidRequirement requirement)
{
      // Check the token in database
}

And I register my Handler like this :
services.AddAuthorization(options =>
{
      options.AddPolicy("TokenValid",policy => policy.Requirements.Add(new TokenValidRequirement()));
});

services.AddSingleton<IAuthorizationHandler, TokenValidHandler>();

Because we have an multi-tenant application, when the user quit the application and re-open the site, his connection string is lost (and we don't want to persist database string), so I use informations stored in Claim to recover the database access. If the authentication expired, no informations are available in Claim, so I cannot access to my database.
As I can see, TokenValidHandler is instanciated even if the user is not connected, is that normal ? Because in the case he's not, and I wanted to use dependency injection for my database service, I cannot because informations about the user database access are not here : Identity is not detecting soon enough that the user authentication expired. Any ideas about that ?

I found the solution to use IServiceProvider for the moment, so I get my database service into the Handler method and not via dependency injection, not so clean solution ...

I need some clarity here. Where is the connection string stored? How does it get there? I am guessing you have a central database somewhere, and when a user logs in you store this mysterious token in it, and that resolves to a database somehow? And when the user logs out you lose this, because there's no user any more? That's kind of how it's expected to work. If the user is anonymous their identity is gone.


chore: migrate to vue 3

This migrates the package to vue 3. It basically pulls in the beta branch from https://github.com/sagalbot/vue-select/tree/beta onto our adjustments. However, I did that manually and fixed some issues along the way.
I did not really care to adjust the docs, but the component itself and the tests work fine.
Also, I don't have yarn, so someone who has it installed needs to create the yarn.lock file. Or we just migrate to npm, which might be better anyway.
I tested the library in the nextcloud/vue docs vue 3 branch, and it works just fine as far as I can tell.
Of course, we wouldn't merge into master yet, but since I don't have the appropriate rights here, I couldn't create any branch here.

+1 to migrate to npm

Rights granted @raimund-schluessler :)

Also might make sense to use something like https://github.com/vueuse/vue-demi for single branch maintenance

Also might make sense to use something like https://github.com/vueuse/vue-demi for single branch maintenance

Not sure about this. Vue 2 will be EOL in 3 months, so the better solution is to migrate to Vue 3 and drop support for 2 completely, I think.

Rights granted @raimund-schluessler :)

Thanks. How should we proceed here? Should I create a next branch from master and create a PR against it, as we do it in the nextcloud/vue repo?

Thanks. How should we proceed here? Should I create a next branch from master and create a PR against it, as we do it in the nextcloud/vue repo?

Precisely :)

Closed in favor of #25.


Update finagle-core, finagle-mysql, ... to 19.11.0

Updates

com.twitter:finagle-core
com.twitter:finagle-mysql
com.twitter:scrooge-serializer
com.twitter:util-core

from 19.10.0 to 19.11.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.twitter" } ]

labels: semver-minor

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #345 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #345   +/-   ##
========================================
  Coverage    61.23%   61.23%
========================================
  Files           50       50
  Lines         1540     1540
  Branches        40       40
========================================
  Hits           943      943
  Misses         597      597

Impacted Files
Coverage Δ

.../main/scala/com/twitter/bijection/Bufferable.scala
90.9% <0%> (-0.83%)
:arrow_down:

...a/com/twitter/bijection/CollectionInjections.scala
96.77% <0%> (+3.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93aa34b...48daf17. Read the comment docs.


Proposal: XAML support should become a Visual Studio extension

I propose to outsource XAML into a Visual Studio extension and drop it from runtime, design-time and build-time.

With the proposed – optional – Visual Studio extension, designers and programmers may choose whether they want to utilize XAML (by installing the proposed VS extension) or deal with the runtime directly and fast.

The extension is supposed to transpile .xaml files into *.designer.* partial class files at design time and to keep both in sync (by watching the corresponding files/folders).

Designers' experience won't change. They still will be using .xaml files. Yet, the suggested Visual Studio extension will immediately transpile these to *.designer.* partial class files.

Rationale
(Please pardon me for the following long essay. I'll try to lighten it up with some animations depicting the corresponding description for better reading.)

Currently, the VS designer interacts with XAML files. A new VS designer should instead interact with *.designer.* files (this is actually a workflow that's flawlessly working for Windows Forms for decades). This approach would result in much faster designer execution because the XML in the XAML file wouldn't be required to be parsed and matching objects to be found by Reflection for the designer to display its surface. Plus, the VS designer itself would supposedly be significantly more streamlined to implement.

Currently, in a pre-build step, the build process parses all XAML files and transpiles them into designer partial classes (\obj\**\*.g.*). This pre-build step will become redundant, since (like with Windows Forms) standard *.designer.* partial classes may be used, maintained by the new VS designer (mentioned before) that's manipulating native .NET language code.

By outsourcing XAML to a Visual Studio extension and at the same time removing XAML support from current XAML project types (e.g. WPF, WF, UWP, Xamarin.Forms, MAUI, Uno Platform) themselves, this would greatly reduce the current overhead for dealing with XAML:

The Visual Studio designer could JIT compile its partial *.designer.* files and run them immediately to display its surface ‒ instead of being required to parse XAML, find the corresponding objects via Reflection and trying to instantiate each of the objects manually.

The compiler could just compile the *.designer.* partial classes along with the user defined partial classes. No additional pre-build step would be required to transpile XAML to native .NET language code by parsing the XML, finding the corresponding objects via Reflection and derive code for each of the objects manually.

The Windows Runtime wouldn't be required to read and parse BAML/XBF files at runtime and find the corresponding objects in memory to complete the object tree.

Benefits are ...

Faster development
Faster build
Faster execution
Windows Runtime code can be reduced
(thereby reducing Microsoft development and maintenance time and cost)
Visual Studio designer code can be reduced
(thereby reducing Microsoft development and maintenance time and cost)
The Visual Studio Blend product may be deprecated
(thereby reducing Microsoft development and maintenance time and cost)
By implementing a new, separate, optional XAML extension, all project types that support *.designer.* files may optionally support XAML, even Windows Forms.
Designers who prefer to use XAML/XML may use the proposed extension and won't notice the difference.

The proposed extension is supposed to provide the following functionality ...

The extension provides a file watcher that's syncing XAML files from *.designer.* files and vice versa.

Summary
I propose to create a Visual Studio extension that transpiles .xaml files to *.designer.* files.
This will enable all current XAML project types to have any XAML support removed/stripped while designers will still be able to utilize XAML.
The Visual Studio debugger's Compile and Continue feature will still allow to edit both,.xaml files and *.designer.* files, during debugging.
The .NET runtime may still provide methods for parsing XAML at runtime, but these will not intrinsically be used but only by programs that explicitly call them.

/ref: #4127
@VagueGit : done

Much of the problems I've brought up in the original issue have not been addressed by this update. Namely:

The fact XAML supports other languages like C++, which are incredibly more complex to parse, leading to a poor designer experience. (for ex, much longer time to initially render and update the designer view due to requiring code compilation)
The fact the C++/WinRT projection is quite heavy, and that piles of autogenerated code creating and laying out controls will inevitably make compile times longer than turning XAML files into XBF.
The fact loading XBF files is actually faster than creating and laying down controls in code. Especially if you consider how heavy the C#/WinRT interop and GC transition for every WinRT function being called (including property setters) is. The XBF representation has been optimized to allow direct bytewise deserialization of internal control classes from it. No XAML is parsed at runtime, and the XBF parsing is minimal. The only time XAML is even parsed at runtime is when a developer explicitly asks for it by calling XamlReader::Load
The fact C++ Edit and Continue and code hot reload are not proper replacements for XAML hot reload. Edit and Continue and code hot reload requires to be on a breakpoint, while XAML hot reload does not. Plus, EnC and code hot reload are slow and only work half the time at best in C++, while since XAML hot reload has no actual code to recompile: it's fast, reliable, and doesn't require to be on a breakpoint.

So, it does not actually result in faster developments, builds or runtime. It actually worsens all 3 in C++.
Designer files also should preferably not be checked in to source control. The source of truth, in this case the developer-edited XAML files, should be checked in. Checking in the designer files and regenerating XAML from them would lead to losing important information like comments. It makes reviewing UI changes harder too - if the Winforms designer is anything to go by, a small change (like moving a control by a few pixel) can entirely reorganize the designer file, making code reviews practically impossible, especially on complex forms.
Neither the XAML designer or the XAML compiler actually use reflection - in case of the XAML designer the code is actually loaded and ran within the IDE - your code actually runs in the designer itself (and there are APIs to detect this). As for compilation, I'm pretty sure the XAML compiler relies on WinMD metadata, generated by the C# compiler (or IDL files in C++). These two facts are evidenced by the fact you need to compile the project at least once for the designer features to even show up, and that in C++ you need to add anything you want to x:Bind to in an IDL file.
Additionally, some XAML concepts like DataTemplates and retemplating cannot be represented in code currently, only XAML.
Another issue is that this increases coupling of WinUI with VS - it would leave users who desire to use XAML from other IDEs without the possibility of doing so, or force Microsoft/the community to implement extensions for many IDEs out there, instead of being able to rely on the build system to handle their XAML files for them. The XAML compiler finally became a standalone exe instead of a MSBuild task in WASDK 1.2 - let's not revert that.

* The fact XAML supports other languages like C++, which are incredibly more complex to parse, leading to a poor designer experience. (for ex, much longer time to initially render and update the designer view due to requiring code compilation)

Can you give an example of much more complex C++ Managed Extensions would compared to .NET CLR to render for a designer?
What do you believe the current implementation does when you hit Build Project?

* The fact the C++/WinRT projection is quite heavy, and that piles of autogenerated code creating and laying out controls will inevitably make compile times longer than turning XAML files into XBF.

On the contrary: complile times will shorten – because there won't be anything left to compile.
Please make sure to grasp the proposal fully.

Additionally, some XAML concepts like DataTemplates and retemplating cannot be represented in code currently, only XAML.

That ain't true. There isn't something like "XAML" as you perceive it. All XAML is getting converted into C++. There is always a code representation of any XAML you write.
Are you sure you understood the XAML concept completely?

Another issue is that this increases coupling of WinUI with VS - it would leave users who desire to use XAML from other IDEs without the possibility of doing so, or force Microsoft/the community to implement extensions for many IDEs out there, instead of being able to rely on the build system to handle their XAML files for them. The XAML compiler finally became a standalone exe instead of a MSBuild task in WASDK 1.2 - let's not revert that.

That ain't true, either. These already exist. How do you believe you'll get to see a visual representation in your IDE?

Can you give an example of much more complex C++ Managed Extensions would compared to .NET CLR to render for a designer?

The version of C++ that UWP and WinUI XAML supports is not managed, and does not run on the .NET CLR. It is native C++. Compiling C++/WinRT code is much heavier than the equivalent C#, due to C++/WinRT being a library that's very liberal with its use of templates, a C++ feature that is already inherently expensive to parse/compile. The C++ compiler has to parse that code everytime too, while the C# compiler just parses metadata.
Examples where brought up in the original thread too, for example the fact that C++ has at least 20 different ways to initialize a variable. You'd practically need to implement a full C++ parser/AST to be able to support C++. At which point, one could also take a look at the C++ parser of compiler projects like Clang and GCC. It is massive and very complicated, and to this day, still bugs out ever so often.
On my i5-5200U laptop (now admittedly this is a bit old, but it's still pretty long even on my Ryzen desktop), simply writing the following (which is required to use XAML):
#include <winrt/Windows.UI.Xaml.Controls.h>

Makes the build take an additional 2-3 minutes, even if nothing from that namespace is actually used. The more controls/properties you use, the longer it will take to compile.

What do you believe the current implementation does when you hit Build Project?

Builds the code, of course. But a designer should not take several minutes building code in the background just to show or update a preview. For bigger projects, this could be as high as half an hour of building code instead of a several minutes.

On the contrary: complile times will shorten – because there won't be anything left to compile.

You are suggesting to generate a significant amount of code that will need to be compiled, instead of a small binary file and a small amount of code. I don't see how that would make compile times shorter, especially considering the slow compile time of C++.

That ain't true. There isn't something like "XAML" as you perceive it. All XAML is getting converted into C++. There is always a code representation of any XAML you write.

While the framework does end up with an internal representation of the DataTemplate, currently it is not possible for users to create a DataTemplate purely from code, without XAML. The class that allowed this in WPF (FrameworkElementFactory) does not exist in UWP. The only way is to use XamlReader to parse XAML at runtime, which is much slower than loading a DataTemplate that was compiled to a XBF file.

Are you sure you understood the XAML concept completely?

This kind of remark is disrespectful and offtopic, please avoid them.

That ain't true, either. These already exist. How do you believe you'll get to see a visual representation in your IDE?

Sure, a few GUI designers for XAML exist in other IDEs, but their only responsibility is generating a preview from the XAML. They do not parse code, or generate big amounts of code. The task of compiling XAML and generating XBF is left to the build system, because XAML support is part of the build system.
If it was moved to a VS extension, now every extension also has to get in the business of parsing code for a designer, and generating code. We would ultimately get divergence between addons (code generated from IDE A may not be understood correctly by IDE B's designer) and it would become even harder to add designer support to other IDEs compared to today. Also, if you're writing XAML without a designer (in tools like VSCode or vim, for example), you would need an addon, instead of being able to just build the project and get the required code/XBF generated.


Mirahc emits static variable access on an instance variable

Consider this Mirah code
class Foo

	def some_instance_method
		@foo = 1
	end

	def self.some_static_method
		puts foo
	end
end

Foo.some_static_method

This code should fail to compile, as the puts foo statement refers to a foo which should either be a (static) method or a local variable. There is neither a static or non-static method "foo" nor a local variable "foo". However, there is an instance variable "foo", which is completely inaccessible to the static method "some_static_method".
Not recognizing this impossibility, the compiler currently emits a "getstatic" bytecode instruction on instance variable "foo", which then fails during runtime as
java.lang.IncompatibleClassChangeError: Expected static field Foo.foo

A fix for this bug should not try to detect such a situation too soon, as the Mirah AST is subject to transformations which may make illegal code later legal. However, the situation should be attempted to be detected, and if detected, and the compiler should emit a compilation error.

Yeah, I think this is due to the way the typer interacts with the type system. With the new fields used elements in scopes, I think we could make this better.


set correct out variable for single remote operations

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/2417/

https://github.com/arangodb/arangodb/pull/7632#issuecomment-444218319 - obsolete as change is already merged.


bug: section on assertion not quite right.

https://github.com/Web3NL/motoko-book/edit/main/src/common-programming-concepts/assertions.md
In an actor method, assertions don't stop the program. In general, they abort the current message up to the last commit point and can be caught by the sender as an error. Might be tricky to explain this correctly.
When running outside the IC, say in the wasi target or the current intepreter, they do cause the program to abort/terminate, but not on the IC. That true for all traps, not just those forces by assertions, btw,

This will be explained in chapter 6 on cabuster rollbacks. I would link to it from assertions

Cool. I guess you could just say it causes a trap in the section, and then link to the section on traps.


Add screencopy dmabuf backend

This PR will contain the changes required for my Google Summer of Code 2024 project with waycrate as described here: https://cheerfulpianissimo.github.io/notes/GSOC/GSOC.html

It isn't clear to me why that build is failing. Seems to be some issue with the wayland deps?
A more detailed description of the changes so far is available at https://cheerfulpianissimo.github.io/notes/GSOC/GSOC Devlog (June).html#!week-4 :
Reading the code, I discovered that there are three levels of abstraction in libwayshot:

The screenshot_* series of functions: These are the public API and mostly wrap around one of the capture_* series of functions.
The capture_frame_copy* and capture_output_frame_shm_fd series of functions: capture_output_frame_shm_fd is a part of the public libwayshot API  that allows for low-level access to the screencapture data in the form of file descriptors and a FrameGuard struct that contains a WlBuffer. The capture_frame_copy* functions handles the creation of a FrameCopy struct which is a sort of intermediate data structure between raw shared memory and a DynamicImage, these functions are used by the screenshot* function layer above and are not public.
The capture_output_frame_get_state and capture_output_frame_inner functions: These two functions deal with the nitty-gritty of interacting with the wlr-screencopy protocol. The primary data structure here is CaptureFrameState.

capture_output_frame_get_state sets up a zwlr_screencopy_manager_v1 with the correct sub-region and the output to be captured to get a  zwlr_screencopy_frame_v1
capture_output_frame_inner manages the copy of frame data from the created zwlr_screencopy_frame_v1 into the shared memory buffers.
capture_output_frame_shm_fd and it's sister function capture_output_frame_shm_from_file call the above two functions one after the other to handle everything to do with wlr-screencopy.

First Draft API Implementation
For the first phase I decided to create dmabuf version of the lower two levels of abstraction. My goal was to create a dmabuf equivalent for capture_output_frame_shm_fd which would provide low level access to the dma buffer objects and a wl-buffer.
To this goal, I created the new function variants capture_output_frame_get_state_dmabuf and capture_output_frame_inner_dmabuf to replicate the lowest layer and capture_output_frame_dmabuf to replicate the public API on the level above. capture_output_frame_dmabuf would return a GBM BufferObject, a FrameGuard containing a WlBuffer and the frame format descriptor.
Two new structs DMAFrameFormat and DMAFrameGuard were created as counterparts to FrameFormat and FrameGuard.
For the most part adapting the code from the MVP into these functions was straightforward with the shm variants as a reference.
One part I have some trouble with is error handling. Using unwrap() in library code is generally frowned upon but I haven't figured out a good way to pass up errors to the caller without running into compiler errors like "? couldn't convert the error to error::Error
the question mark operation (?) implicitly performs a conversion on the error value using the From trait". This requires some research.
The next phase will be testing. I will need some way to test the new API, ideally without having any VRAM->CPU copying. The simplest plan is to start with a basic wayland window demo and attach the WlBuffer obtained from the API to a WlSurface and see what the result looks like.

Apart from these minor changes, everything else looks good!

Apart from these minor changes, everything else looks good!

Ci is failing @CheerfulPianissimo

The addition of wayland-sys as a dependency is causing it to fail I think. That library requires a preinstalled wayland system library.

fixed that but it seems we need something for egl too.

alright, the build is passing now but I think it may be wise to document the new deps somewhere and/or feature-gate it.

We can have it as part of changelog or release notes. Sounds good?

Yeah that's fine by me. I already have a draft changelog for this at https://cheerfulpianissimo.github.io/notes/GSOC/GSoC Changelog.html

Congratulations and thank you for your service to the open source community @CheerfulPianissimo


Incompatible shapes between op input and calculated input gradient.

When I try to implement a SegNet with tensorflow, I met up with the following issue:
Incompatible shapes between op input and calculated input gradient.

My net structure is here below:
 def buildNet(self):
        #TODO: Implemente this method
        self.X = tf.placeholder(dtype=tf.float32, shape=(self.batchsize, self.width, self.height, self.channel))
        self.Y = tf.placeholder(dtype=tf.int32, shape=(self.batchsize, self.width, self.height))

        norm = tf.nn.lrn(self.X, depth_radius=5, bias=1.0, alpha=1e-4, beta=0.75)
        # Encoder of segnet
        self.enconv1 = batchnorm(conv2d(norm, [3,3,self.channel,64], [1,1,1,1]))
        self.enconv2 = batchnorm(conv2d(self.enconv1, [3,3,64,64], [1,1,1,1]))
        self.enpool1 = maxpooling2d(self.enconv2, [1,2,2,1], [1,2,2,1])

        self.enconv3 = batchnorm(conv2d(self.enpool1, [3,3,64,128], [1,1,1,1]))
        self.enconv4 = batchnorm(conv2d(self.enconv3, [3,3,128,128], [1,1,1,1]))
        self.enpool2 = maxpooling2d(self.enconv4, [1,2,2,1], [1,2,2,1])

        self.enconv5 = batchnorm(conv2d(self.enpool2, [3,3,128,256], [1,1,1,1]))
        self.enconv6 = batchnorm(conv2d(self.enconv5, [3,3,256,256], [1,1,1,1]))
        self.enpool3 = maxpooling2d(self.enconv6, [1,2,2,1], [1,2,2,1])

        self.enconv7 = batchnorm(conv2d(self.enpool3, [3,3,256,512], [1,1,1,1]))
        self.enconv8 = batchnorm(conv2d(self.enconv7, [3,3,512,512], [1,1,1,1]))
        self.enpool4 = maxpooling2d(self.enconv8, [1,2,2,1], [1,2,2,1])

        self.enconv9 = batchnorm(conv2d(self.enpool4, [3,3,512,512], [1,1,1,1]))
        self.enconv10 = batchnorm(conv2d(self.enconv9, [3,3,512,512], [1,1,1,1]))
        self.enpool5 = maxpooling2d(self.enconv10, [1,2,2,1], [1,2,2,1])

        # Decoder of segnet
        self.depool1 = deconv2d(self.enpool5, [3,3,512,512], self.enconv10.shape, [1,1,1,1])
        self.deconv1 = batchnorm(conv2d(self.depool1, [3,3,512,512], [1,1,1,1]))
        self.deconv2 = batchnorm(conv2d(self.deconv1, [3,3,512,512], [1,1,1,1]))

        self.depool2 = deconv2d(self.deconv2, [3,3,512,512], self.enconv8.shape, [1,1,1,1])
        self.deconv3 = batchnorm(conv2d(self.depool2, [3,3,512,256], [1,1,1,1]))
        self.deconv4 = batchnorm(conv2d(self.deconv3, [3,3,256,256], [1,1,1,1]))

        self.depool3 = deconv2d(self.deconv4, [3,3,256,256], self.enconv6.shape, [1,1,1,1])
        self.deconv5 = batchnorm(conv2d(self.depool3, [3,3,256,128], [1,1,1,1]))
        self.deconv6 = batchnorm(conv2d(self.deconv5, [3,3,128,128], [1,1,1,1]))

        self.depool4 = deconv2d(self.deconv6, [3,3,128,128], self.enconv4.shape, [1,1,1,1])
        self.deconv7 = batchnorm(conv2d(self.depool4, [3,3,128,64], [1,1,1,1]))
        self.deconv8 = batchnorm(conv2d(self.deconv7, [3,3,64,64], [1,1,1,1]))

        self.depool5 = deconv2d(self.deconv8, [3,3,64,64], self.enconv2.shape, [1,1,1,1])
        self.deconv9 = batchnorm(conv2d(self.depool5, [3,3,64,32], [1,1,1,1]))
        self.deconv10 = batchnorm(conv2d(self.deconv9, [3,3,32,self.classes], [1,1,1,1]))

        self.pred = tf.nn.softmax(self.deconv10)
        self.oneHotY = tf.one_hot(self.Y, depth=2, on_value=1.0, off_value=0.0)
        self.loss = tf.reduce_mean(tf.losses.softmax_cross_entropy(onehot_labels=self.oneHotY, logits=self.pred))
        print self.loss.shape
        self.optimizer = tf.train.AdamOptimizer(self.learningrate).minimize(self.loss)

I think it is the problem of tf.conv2d_trainspose. Does anyone have idea about it?

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

Could you try to simplify your program to the minimum program that exhibits the error?

OS Platform: MacOS High Sierra
No GPU, just on CPU, for testing
Tensorflow Version: 1.7
Terminal Output: ValueError: Incompatible shapes between op input and calculated input gradient.  Forward operation: conv2d_transpose_4.  Input index: 2. Original input shape: (4, 256, 256, 64).  Calculated input gradient shape: (4, 512, 512, 64)

Nagging Assignee @drpngx: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

encountered same issue on older tensorflow version: 1.4

Does this still occur in the latest version?

U mean tensorflow r1.9? I am not sure and will check it later.

I have the same error. My message looks liek this: ValueError: Incompatible shapes between op input and calculated input gradient.  Forward operation: decoder/conv3d_transpose/conv3d_transpose.  Input index: 2. Original input shape: (30, 149, 149, 1, 8).  Calculated input gradient shape: (30, 298, 298, 1, 8). It seems that the calculated shape of the gradient does not match with the output shape one ha s to give the function. In my case the error only occurs in my code with a stride > 1 and a deconv -> conv  -> deconv -> conv ... architecture for the decoder (For an AE). Iam not sure if this is a bug or If I did something wrong. But since I have a symmetric AE it could be a bug.

Nagging Assignee @drpngx: It has been 18 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@Aaron19960821 I think we're at 1.10 now.

@2649 thanks, that seems strange. Do you have a simpler repro case, maybe with just one call to the conv operator?

I extracted the variables of this layer and performed only one convolution. Now I get a different error, but the behaviour is the same. It falsely uses valid padding although I pass "SAME" as padding.
import tensorflow as tf
import numpy as np

input_tensor = tf.placeholder(tf.float32, (30, 298, 298, 8))
y_tensor = tf.placeholder(tf.float32, (30, 298, 298, 8))
x = np.random.normal(size=(30, 298, 298, 8))

weight = tf.get_variable("weight", [2, 2, 8, 8])
bias = tf.get_variable("bias", [8])
stride = [1, 2, 2, 1]

conv = tf.nn.conv2d(input_tensor, weight, stride, padding="SAME")

loss = tf.losses.mean_squared_error(y_tensor, conv)
optimizer = tf.train.GradientDescentOptimizer(0.001)
train = optimizer.minimize(loss)

sess = tf.Session()
sess.run(tf.global_variables_initializer())
sess.run(train,
        feed_dict={
            input_tensor: x,
            y_tensor: x
        })

The error:

ValueError                                Traceback (most recent call last)
 in ()
12 conv = tf.nn.conv2d(input_tensor, weight, stride, padding="SAME")
13
---> 14 loss = tf.losses.mean_squared_error(y_tensor, conv)
15 optimizer = tf.train.GradientDescentOptimizer(0.001)
16 train = optimizer.minimize(loss)
C:\Program Files\Anaconda3\lib\site-packages\tensorflow\python\ops\losses\losses_impl.py in mean_squared_error(labels, predictions, weights, scope, loss_collection, reduction)
627     predictions = math_ops.to_float(predictions)
628     labels = math_ops.to_float(labels)
--> 629     predictions.get_shape().assert_is_compatible_with(labels.get_shape())
630     losses = math_ops.squared_difference(predictions, labels)
631     return compute_weighted_loss(
C:\Program Files\Anaconda3\lib\site-packages\tensorflow\python\framework\tensor_shape.py in assert_is_compatible_with(self, other)
842     """
843     if not self.is_compatible_with(other):
--> 844       raise ValueError("Shapes %s and %s are incompatible" % (self, other))
845
846   def most_specific_compatible_shape(self, other):
ValueError: Shapes (30, 100, 100, 8) and (30, 298, 298, 8) are incompatible
I use version 1.8, but on my workstation 1.6 and it yields the same error.

@drpngx  Ok I thought about it again and it is not a bug. When using a stride > 1 with same padding the image will automatically scale down. Otherwise the padding must happen between pixels in the image to maintain the original size. I think you can close this thread.

Thanks for looping back! Closing.

I experience the same issue, already implementing the padding as specified by @2649
Have I written custom code
No
OS Platform and Distribution
Windows 10, 64 bit
TensorFlow installed from
Anaconda https://anaconda.org/anaconda/tensorflow-gpu
TensorFlow version
1.10.0 (result from print(tf.version))
Any help please!

@2649 did you solve this issue?
I'm using Python3.6 with TensorFlow 1.5.1 and my issue is [Report Error]ValueError: Incompatible shapes between op input and calculated input gradient. conv2d_transpose any idea how to solve it?


Second IF in Mysql query doesn't work

        $order = \app\models\User::find()
            ->select([
                'IF (ISNULL(`users`.`nickname`), `users`.`firstname`, `users`.`nickname`) as `name1`',
                '(IF (ISNULL(`users`.`nickname`), `users`.`firstname`, `users`.`nickname`)) as `name2`'
            ])
            ->asArray()->one();

It is work, but if I set select via string. I get error.
$order = \app\models\User::find()
            ->select(
                'IF (ISNULL(`users`.`nickname`), `users`.`firstname`, `users`.`nickname`) as `name1`,
                (IF (ISNULL(`users`.`nickname`), `users`.`firstname`, `users`.`nickname`)) as `name2`'
            )
            ->asArray()->one();

SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')) as name2 FROM users' at line 1
The SQL being executed was: SELECT IF (ISNULL(users.nickname), users.firstname, users.nickname) as name1, (IF (ISNULL(users.nickname), users.nickname)) as name2 FROM users

It is happened after update Yii2 from 2.0.14 to <IP_ADDRESS>
Additional info

Q
A

Yii version
<IP_ADDRESS>

PHP version
7.1

Operating system
ubuntu 16.04

$order = \app\models\User::find()
->select([
'name1' => new Expression('IF (ISNULL(users.nickname), users.firstname, users.nickname))',
'name2' => new Expression('(IF (ISNULL(users.nickname), users.firstname, users.nickname))')
])
->asArray()->one();

What SQL do you expect?

Non simple selects need to be provided in an array to avoid them being split.
See note here, https://www.yiiframework.com/doc/api/2.0/yii-db-query#select()-detail


ambiguous naming fix

I updated he ambiguous naming of variables. check it out.  if there is a problem tell me i am also new to rust  :) - This will fix issue #3

Awesome! Thanks for taking the time to do this. I'll take a look now and make comments if I spot anything.

in the k_means.rs file you need to update the signature of the UnSupModel implementation. This means changing data to inputs in both cases.

The only remaining thing is the various naming issues in the tests (and perhaps in the documentation examples).
I'm happy to go through these myself and clean them up. I'm also happy to make the changes I detailed above if you'd prefer.
Thanks for your help!

@AtheMathmo thanks for the review. and i would like to update this by myself. thanks though. :)

Hey i just updated . please check and tell me if i miss something.

There were some minor issues but I merged the PR and cleaned these up with my own commit. Thanks for all your help!

Thanks. I would like to contribute more.  And is there anywhere we can chat and discuss