Add search, filter and sort to resources page

Resolves #25

Thanks, @flickz. The filter doesn't seem to work; what am I missing? Nothing changes when I type something in.
As well, there's only one type of resource. How do I add different types?

@RichardLitt I don't know the expected type of resources but if you want to add type to resources in a project, add a type property to the resource object.
export const resources = [
  {
    title: "Detecting At-Risk Software Infrastructure",
    link: "https://blog.communitydata.science/detecting-at-risk-software-infrastructure/",
    linkText: "Read More",
    author: "Kaylea Champion",
    type: ""
  },
];

What are the expected types? I need the list ([]) to implement the type filter which is what is currently missing.

Thanks Olu. For now, why don't we add: ["website", "talk", "document"]. I can add more as they come up - would it be possible to make the list of possible types dynamic based on the values of all of the type fields?

@RichardLitt Yes, it is possible. I've implemented it now. Go ahead and type field to the project resources. As an example of this, I added type for this project.
https://github.com/digitalinfrastructurefund/website/pull/28/commits/0dbd524f76785f5ae9eb20c6496671a509e068c4#diff-75fef3b4800bfdf98e11f7594deee6d79d4a0b7c52315179adf67a79a77d1cfb

Looks great to me! Thank you, @flickz.


Max lengths for code documentation

Hi, thanks a lot for the wonderful repository and paper.
In the paper section B.3, it is mentioned that "We set the max length of input and inference as 256 and 64, respectively". However, on checking the code provided in the repository I find that inputs longer than 256 are truncated to a max length of 256, and output are truncated to a max length of 128.
So I was confused about what maximum length of the output should I use to reproduce the results, as the results provided in the paper and on the repository are the same, despite the difference in output lengths. I am specifically working on JAVA language.

Hi, thanks a lot for the wonderful repository and paper.
In the paper section B.3, it is mentioned that "We set the max length of input and inference as 256 and 64, respectively". However, on checking the code provided in the repository I find that inputs longer than 256 are truncated to a max length of 256, and output are truncated to a max length of 128.
So I was confused about what maximum length of the output should I use to reproduce the results, as the results provided in the paper and on the repository are the same, despite the difference in output lengths. I am specifically working on JAVA language.

Please follow the setting in the repo. Because we have re-produced the performance of CodeBERT paper using the setting of this repo.

Great thanks a lot for the prompt reply.

Great thanks a lot for the prompt reply. So does this mean setting max length 64 and 128 did not make any difference in the results of codebert?

I don’t try 64 max length in this repo. Maybe you can try both settings.

Great thanks a lot for the prompt reply. So does this mean setting max length 64 and 128 did not make any difference in the results of codebert?

I don’t try 64 max length in this repo. Maybe you can try both settings.

Sure I would give it a try.
I think I have a confusion now, the results reported here https://github.com/microsoft/CodeXGLUE/tree/main/Code-Text/code-to-text#result  are from CodeBert paper or with the current setting in the repository?  Because if I just compare the results from CodeBert paper and the results reported here (https://github.com/microsoft/CodeXGLUE/tree/main/Code-Text/code-to-text#result) both are the same, although with different lengths setting for outputs.

Sure I would give it a try.
I think I have a confusion now, the results reported here https://github.com/microsoft/CodeXGLUE/tree/main/Code-Text/code-to-text#result are from CodeBert paper or with the current setting in the repository? Because if I just compare the results from CodeBert paper and the results reported here (https://github.com/microsoft/CodeXGLUE/tree/main/Code-Text/code-to-text#result) both are the same, although with different lengths setting for outputs.

If you want to obtain the same result in the CodeBERT paper, you can refer to CodeBERT repo (https://github.com/microsoft/CodeBERT). This repo only provide a faster (from 30 hours to 14 hours)  and lower GPU cost (4xP100 to 2xP100) pipeline compared with the repo (https://github.com/microsoft/CodeBERT) for participants to use. The results we reported in this repo directly comes from CodeBERT paper, not from the pipeline in this repo.

Great thanks, now it's clear.


Add Create private buckets section to the app bulding tutorial

done https://docs.textile.io/tutorials/hub/user-buckets/#push-encrypted-buckets


[RC-1453] fx-ify the remote config service component

This is a re-opening #22347 which was previously merged. The PR was reverted by #22431). The previous PR introduced unintended behavior where the agent would fail to start entirely if the rc service failed to initialize. This has been fixed in this new commit (which is the only change from the previous PR).

What does this PR do?

This PR refactors a bit of remote config service initialization code that was polluting cmd/agent/common. There are no functional changes. To accomplish this, the rc service is now being provided as an uber fx component to the agent commands that need it.
Motivation

First, there is an overarching initiative to migrate to using uber.fx to supply various components throughout the agent.
Second, the remote config service initialization logic was pulled out to cmd/agent/common during a prior refactor which is an antipattern, and it did not belong there
Third, as part of the HAMR initiative, we will need to conditionally instantiate/inject a second RC service that communicates with the R2 failover datacenter. Since the RC service depends on an RCTelemetryReporter which can only be initialized/configured once, we really need a singleton telemetry reporter anyways, and uber.fx is the right way to do that regardless. By componentizing everything like this, it sets us up to provide the same telemetry reporter singleton to both services in an upcoming/unrelated PR.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

start the cluster agent with RC disabled via remote_configuration.enabled: false in the agent config. Ensure the cluster agent starts fine and that remote config is indeed disabled
start the cluster agent with RC enabled (including a valid API Key etc). Ensure the cluster agent starts fine, and that remote config is indeed enabled
start the core agent with RC disabled via remote_configuration.enabled: false in the agent config. Ensure the cluster agent starts fine and that remote config is indeed disabled
start the core agent with RC enabled (including a valid API Key etc). Ensure the cluster agent starts fine, and that remote config is indeed enabled
start the core agent with the following config (be sure NOT to explicitly set the remote_configuration.no_tls_validation config field). This should cause an error during remote config service initialization. Ensure the agent starts fine without the remote config service and logs a corresponding error:

skip_ssl_validation: true
remote_configuration:
  enabled: true

2024-01-30 13:20:32 EST | CORE | ERROR | (comp/remote-config/rcservice/rcserviceimpl/rcservice.go:61 in newRemoteConfigServiceOptional) | remote config service not initialized or started: unable to create remote-config service: remote Configuration does not allow skipping TLS validation by default (currently skipped because `skip_ssl_validation` is set to true). While it is not advised, the `remote_configuration.no_tls_validation` config option can be set to `true` to disable this protection

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


Provide setup script

Hi! Could you provide setup script that install dependencies?

Yes. We just talked about that actually.

Hey, we've added setup instructions now, and a requirements.txt, so I'm closing this issue.


Swift 4 support

• Convert the project to Swift 4
• Turn off @objc inference
• Resolve M_PI warnings
• Update to recommended project settings with Xcode 9 beta 2

Thanks @yar1vn - I've pushed a separate upgrade for Swift4 - ready with v0.7


Interactions: the Buttons

Hello everyone. Just finished implementing buttons functionality for DiscordGo. Looking forward a feedback.

After some discussion about InteractionData. I'd say that we decided to separate data into different structures. And I personally decided to make it an interface. So, waiting for feedback!

Hello everyone. It seems that documentation has been published and the buttons are ungated. I think It's time to mark this PR as ready for review. Well, enjoy the buttons!

You can add the "Component" feature to these endpoints :
https://discord.com/developers/docs/resources/webhook#edit-webhook-message
https://discord.com/developers/docs/resources/webhook#execute-webhook
https://discord.com/developers/docs/interactions/slash-commands#edit-original-interaction-response
They all support perfectly fine components objects and are needed to put buttons on a follow up message for example.

You can add the "Component" feature to these endpoints :
https://discord.com/developers/docs/resources/webhook#edit-webhook-message
https://discord.com/developers/docs/resources/webhook#execute-webhook
https://discord.com/developers/docs/interactions/slash-commands#edit-original-interaction-response
They all support perfectly fine components objects and are needed to put buttons on a follow up message for example.

Interesting, it's not documented. But if they support it, then okay, I will add components to these endpoints.

Do you think supporting components in the webhook endpoints is reasonable for this PR, or would it be better included in a separate one?

Do you think supporting components in the webhook endpoints is reasonable for this PR, or would it be better included in a separate one?

Consider making a new PR for webhooks; we should try to update the library asap when major API changes are made. Webhooks can be phased out and waited on for an extra couple of days, but we need to catch up with other libraries.

Unless I am missing something, sending something like Components: []discordgo.MessageComponent{} back is needed to remove buttons when updating a message with the InteractionResponseUpdateMessage type, so it presumably shouldn't have omitempty?

Unless I am missing something, sending something like Components: []discordgo.MessageComponent{} back is needed to remove buttons when updating a message with the InteractionResponseUpdateMessage type, so it presumably shouldn't have omitempty?

I'm sorry, this issue will be fixed in next commits. I just noticed it.

Do you think supporting components in the webhook endpoints is reasonable for this PR, or would it be better included in a separate one?

Consider making a new PR for webhooks; we should try to update the library asap when major API changes are made. Webhooks can be phased out and waited on for an extra couple of days, but we need to catch up with other libraries.

Well, we can, but we can't: this PR depends on this functionality.

Do you think supporting components in the webhook endpoints is reasonable for this PR, or would it be better included in a separate one?

Yes, this is reasonable. This PR covers the full buttons functionality, so it covers the webhooks as well. Because webhooks are part of interactions.

Well, probably everything is finished (except webhooks API), so I think this should be merged soon.

My command router which just operates off of a MessageCreate handler breaks with this PR with the following trace:
`panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x71daff]
goroutine 56 [running]:
github.com/bwmarrin/discordgo.(*Message).UnmarshalJSON(0x0, 0xc000438600, 0x2c3, 0x300, 0x0, 0x0)
/home/chris/go/pkg/mod/github.com/!fedor!lap2006/discordgo@v0.22.1-0.20210619182440-23a197a98005/message.go:144 +0x9f
encoding/json.(*decodeState).object(0xc000284420, 0xa0d840, 0xc000010218, 0x16, 0xc000284448, 0xc0000f9d7b)
/home/chris/go/src/encoding/json/decode.go:609 +0x20a3
encoding/json.(*decodeState).value(0xc000284420, 0xa0d840, 0xc000010218, 0x16, 0xc0000f9d68, 0x524285)
/home/chris/go/src/encoding/json/decode.go:370 +0x6d
encoding/json.(*decodeState).unmarshal(0xc000284420, 0xa0d840, 0xc000010218, 0xc000284448, 0x0)
/home/chris/go/src/encoding/json/decode.go:180 +0x1f4
encoding/json.Unmarshal(0xc000438600, 0x2c3, 0x300, 0xa0d840, 0xc000010218, 0x1, 0x0)
/home/chris/go/src/encoding/json/decode.go:107 +0x11a
github.com/bwmarrin/discordgo.(*Session).onEvent(0xc00024ae00, 0x1, 0xc00001a400, 0x2eb, 0x400, 0x0, 0x0, 0x0)
/home/chris/go/pkg/mod/github.com/!fedor!lap2006/discordgo@v0.22.1-0.20210619182440-23a197a98005/wsapi.go:584 +0xf65
github.com/bwmarrin/discordgo.(*Session).listen(0xc00024ae00, 0xc0003609a0, 0xc0004f2480)
/home/chris/go/pkg/mod/github.com/!fedor!lap2006/discordgo@v0.22.1-0.20210619182440-23a197a98005/wsapi.go:250 +0x7e
created by github.com/bwmarrin/discordgo.(*Session).Open
/home/chris/go/pkg/mod/github.com/!fedor!lap2006/discordgo@v0.22.1-0.20210619182440-23a197a98005/wsapi.go:202 +0xbc5
exit status 2`

My command router which just operates off of a MessageCreate handler breaks with this PR with the following trace:

@ChrisMcDearman  Should be fixed now.

Outside of a few outstanding small things, this is looking quite solid to me; the API surface is definitely cleaner than at the start. Not to jinx it, but as long as nothing else comes up in the near future, I'm excited to get this merged in! 🤠

I agree with @CarsonHoffman - this is pretty much it. But if anyone wanna give additional review/feedback, feel free while Carson hasn't merged it yet :cowboy_hat_face:

Oh, yeah, forgot about them!

Thanks everyone for contribution, feedbacks, and special thanks @CarsonHoffman for his patience and reviews!

Thanks for this!
Could we get some comments in https://github.com/bwmarrin/discordgo/blob/master/examples/components/main.go about how to use this / what it does?
It's not immediately clear what this new interactions functionality is, or what we are supposed to see when running the example. After attempting it, I was met with:
Cannot create slash command: HTTP 403 Forbidden, {"message": "Missing Access", "code": 50001}.
Are there some prerequisite permissions that the bot needs? If so, a comment on adding them would be great.


beforeRouteUpdate don't working in Single File Component mixin

Vue.js / vue-router versions
2.2. / 2.3.0
Reproduction Link

Steps to reproduce
export default {
data () {
return {
tableData: [],
tableMeta: [],
api: '',
pagination: {},
currentPage: 1,
loading: true
}
},
methods: {
getNextPageData (page) {
this.currentPage = page
this.fetchData(this.api)
},
getInitData (to, vm) {
vm.tableMeta = vm.routeListData[to.params.type].tableMeta
vm.api = vm.routeListData[to.params.type].api
},
fetchData (api = this.api, uid = this.uid, page = this.currentPage) {
let vm = this
vm.loading = true
vm.$http({
method: 'POST',
url: api,
data: {
uid: uid,
page: page
}
}).then(data => {
// var res = JSON.parse(data.body)
var res = data.body
for (let key in res) {
vm[key] = res[key]
}
vm.loading = false
}).catch(response => {
vm.$notify({
message: response
})
})
}
},
beforeRouteEnter: (to, from, next) => {
next(vm => {
vm.getInitData(to, vm)
vm.fetchData()
})
},
// todo https://github.com/vuejs/vue-router/issues/1218
beforeRouteUpdate: (to, from, next) => {
console.log(this)
this.tableData = []
this.currentPage = 1
var toParamsName = to.params.type
console.log(toParamsName)
var api = this.routeListData[toParamsName].api
this.fetchData(api)
next(vm => {
})
}
}
export default {
data () {
return {
tableData: [],
tableMeta: [],
api: '',
pagination: {},
currentPage: 1,
loading: true
}
},
methods: {
getNextPageData (page) {
this.currentPage = page
this.fetchData(this.api)
},
getInitData (to, vm) {
vm.tableMeta = vm.routeListData[to.params.type].tableMeta
vm.api = vm.routeListData[to.params.type].api
},
fetchData (api = this.api, uid = this.uid, page = this.currentPage) {
let vm = this
vm.loading = true
vm.$http({
method: 'POST',
url: api,
data: {
uid: uid,
page: page
}
}).then(data => {
// var res = JSON.parse(data.body)
var res = data.body
for (let key in res) {
vm[key] = res[key]
}
vm.loading = false
}).catch(response => {
vm.$notify({
message: response
})
})
}
},
beforeRouteEnter: (to, from, next) => {
next(vm => {
vm.getInitData(to, vm)
vm.fetchData()
})
},
// todo https://github.com/vuejs/vue-router/issues/1218
beforeRouteUpdate: (to, from, next) => {
console.log(this)
this.tableData = []
this.currentPage = 1
var toParamsName = to.params.type
console.log(toParamsName)
var api = this.routeListData[toParamsName].api
this.fetchData(api)
next(vm => {
})
}
}
What is Expected?
What is actually happening?

Please follow the Issue Reporting Guidelines and provide a minimal JSFiddle or Github repository containing a set of reproducible steps that can lead to the behaviour you described. Make sure to boil down the problem as much as possible. Thanks!

Closing due to inactivity. Please open a new issue with a reference to this one if you can follow up with more information.

I'm seeing the same issue with vue 2.4.4 and vue-router 2.7.0.  I believe this should reproduce it if you have a console available:  http://jsfiddle.net/znmLks2w/2/

@michaelmarconi There's already an opened issue about the callback is next being ignored


build(fee): implement methods on resource bounds

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#600  👈
#547 : 1 other dependent PR (#557 )
#538
#537
#508 : 1 other dependent PR (#509 )
#507
#506
#505
#580
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nimrod-starkware and the rest of your teammates on  Graphite


Documentation request

Hi Christoph.
Thank you for creating this useful extension. I hereby want to request you to create a privacy policy for this product as it will help the users to make an informed decision while selecting this extension.

Hi, do you have an example that says nothing will be done with the user’s data?
The only http requests are for favicons, everything else stays completely local. I’ll happily accept any PR in that regard.


combat shields (ShieldWall) time off

True research time is 79s but comes up on the planner as almost 2minutes.

Can you give me an example build order (with link) where this is incorrect?
It looks correct to me:
Build order

Can you give me an example build order (with link) where this is incorrect?
It looks correct to me:
Build order

Apologies for the hasty issue. Upon further investigation the issue is that combat shields can begin before stim is finished. But it still requires 79seconds after stim is finish to be completed, leading to a longer than normal research time. Same effect for concussive shells.
See this BO.
This also lead to strange behavior where you can change the order of the upgrades in the bar at the top in a way that should not be allowed.

Apologies for the hasty issue. Upon further investigation the issue is that combat shields can begin before stim is finished. But it still requires 79seconds after stim is finish to be completed, leading to a longer than normal research time. Same effect for concussive shells.
See this BO.
This also lead to strange behavior where you can change the order of the upgrades in the bar at the top in a way that should not be allowed.

TechLab upgrades on Factory and TechLab on Starport have this bug as well. But not the other upgrades on the Engineering bay, Armory, or Fusion core.

TechLab upgrades on Factory and TechLab on Starport have this bug as well. But not the other upgrades on the Engineering bay, Armory, or Fusion core.

I've found another bug where unit construction would block the addon from researching:

But this is now also resolved:

Internally it was queueing the upgrade without checking if the addon was still busy.
Thanks for the find!

I've found another bug where unit construction would block the addon from researching:

But this is now also resolved:

Internally it was queueing the upgrade without checking if the addon was still busy.
Thanks for the find!


Reimplemented using Typescript

This PR is a complete rewrite of the API using Typescript.
The library can still be consumed by javascript folks but now, it includes typings for typescript-based projects.
In the meantime, the repository was part of the Seronet project, which seems to be over now.
My colleges apparently didn't use Blazegraph at the end of the project.
However, I'll try to continue to improve this library using Typescript.
I also added a docker-compose file which allows for testing the API.
You can run the testing container using yarn test:up.
Then run the tests using yarn test.

Hi @vsimko, this package is unmaintained!
I strongly suggest you:

Create your own
Add a PR to edit the README to point to your package

Best,


Add filler content for Service Enablement Dashboard

https://issues.redhat.com/browse/RHCLOUD-12367
acceptance criteria:

Each of those switches should be able to toggle
If you toggle the top one "Connect to Red Hat Insights" it should toggle all of the switches on/off
"Save changes" should only turn on when a change is made
If you click "Save changes" you should get an alert saying your changes were saved
We will not click "View log"
Save button needs to display a fake confirmation message

default state:

Connect to Red Hat Insights (on)
All the other 3 are off, but the demo person will toggle them on

what may be missing:

No content in "?" button popovers
"Connect RHEL 6 and 7 systems" link URL

Just a few comment about adding ouiaId's that we can consume with automation.
Can we also add an ouiaId for the NavTabs component? It can simply be sed-app-tabs

I am just deleting the NavTabs after chat with @ryelo, they are not needed at this moment. Outher ouiaIds should be added.


New syntax

Before
await Anime.Play(
    Easing.Create<InOutQuad>(beforePosition, toPosition, 0.5f),
    TranslateTo.GlobalPosition(target)
);

↓
After
await Easing.Create<InOutQuad>(beforePosition, toPosition, 0.5f).ToGlobalPosition(target);

https://github.com/kyubuns/AnimeTask/tree/new_syntax


[BUG] Colony Abandonment Not Functioning

Describe the bug
When attempting to abandon a colony its not being abandoned and the colony remains active.
To Reproduce
Steps to reproduce the behavior:

Navigate to the Abandon/Rename page for a colony.
Click the "Abandon Colony" button.
Enter the correct account password in the prompt to confirm the action.
Observe that no changes occur—the colony is not abandoned, and the interface remains unchanged.

Expected behavior
After entering the correct password and confirming the abandonment, the colony should be removed from the player’s active colonies, and the player should receive confirmation of the action.
Screenshots

Additional context

Entering the password and confirming the abandonment does not result in any changes to the colony status.
No error messages or confirmation prompts are displayed to indicate whether the action succeeded or failed.

Hi @aDwCarrazzone,
Thanks for the bug report. I just tried to reproduce this on my local environment with a new account but for me it works. Here is a screen recording showing what the happy path looks like:

So unfortunately I cannot reproduce this locally. Do you see any errors in the JS console or can you try to debug the HTTP request from the network tab to see the internal error (on localhost)?

Well, i really don't know what happened before but i tried again and it worked.


396 | Rotate Function | C++

Title - Rotate Function
What will change -Add C++ code to 396. Rotate Function
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] C++

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Hey, I would like to work on this issue. Please assign it to me.

Okay, Thanks
On Mon, 19 Oct 2020 at 09:58, Riei-Joaquim<EMAIL_ADDRESS>wrote:

@pawki07 https://github.com/pawki07 Cool that you are interested, but I
created this issue because I want to be assigned to this activity, you can
open new issues for work in solutions of others Leetcode Problems.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SHY-Corp/LeetCode-Solutions/issues/673#issuecomment-711532521,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANU44YQ6XI2IRQZGEXMBX7TSLO57DANCNFSM4SVR6EYQ
.


Put transaction locking logic to a separate file

We want to be able to reuse most of the locking logic in the Gateway.
This PR moves those functions out of authority.rs, into transaction_locker.rs, so we could reuse them.
Feel free to suggest a better name too!
I didn't touch the shared object locking as it will be authority specific.

Just a note, as part of #891 will move some of this functionality into a new LockService that is part of a new sub-project, the Sui data store.


Add RoGeR

Insert URLs to the project here: https://github.com/Hydrology-IFH/roger

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as Good First Issue of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.
All projects listed will be posted on our Mastodon channel

@schwemro


HDFS-16749. RBF: Gets the wrong directory information from Trash

…rvice's trash path is not exists

Description of PR
As described  in HDFS-16749.
Purpose ：[RBF] Fix ls user trash path returns mountpoint path that real nameservice's trash path is not exists
There are two nameservices ns0   ns1,  and ns0 is the default nameservice.
(1) Add moutTable
/home/data -> (ns0, /home/data)
/data1/test1 -> (ns1, /data1/test1 )
/data2/test2 -> (ns1, /data2/test2 )
(2) add file
/home/data/file1
/data1/test1/file1
(3)mv files to trash,
ns0:   /user/test-user/.Trash/Current/home/data/file1
ns1:   /user/test-user/.Trash/Current/data1/test1/file1
(3) client via DFSRouter:  hdfs dfs -ls /user/test-user/.Trash/Current ,this will return
/user/test-user/.Trash/Current/home
/user/test-user/.Trash/Current/data1
/user/test-user/.Trash/Current/data2  (But this in fact not exist in ns1)
So, this PR is for this purpose, if  a namservice  that mount point  dir in trash is not really exists, it should be not display in user trash view via DFSRouter

@LiuGuH Thank you for your contribution! Could you please provide more details about your proposed modification?

@zhangxiping1 I see that you created HDFS-16749, pr#5039, and @LiuGuH also submitted a PR. Can we compare and explain the difference between the two prs?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 21s

trunk passed

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 19s

trunk passed

+1 :green_heart:
shadedclient
32m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 18s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 4 new + 3 unchanged - 0 fixed = 7 total (was 3)

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 19s

the patch passed

+1 :green_heart:
shadedclient
32m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
21m 44s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

143m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6317/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6317

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 289fa402ff9b 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 41aeea702f4d5e4683c708fc1b3fef606459190d

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6317/3/testReport/

Max. process+thread count
2841 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6317/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@zhangxiping1 I see that you created HDFS-16749, pr #5039, and @LiuGuH also submitted a PR. Can we compare and explain the difference between the two prs?
Is the same problem, returning the extra entry is the Trash prefix with mount point information(top subdirectory)


Best way to protect routes (api and client)

Hi,
So the problem is that i can't figure out an effective way to protect every client-side route. Every route should only be available when you are logged in and I don't want to check the session in every page.
Next auth middleware would be a good and clean solution but it only works with jwt and not with database based sessions.
src/components/RouterGuard.tsx
export const RouterGuard: FC<PropsWithChildren> = ({ children }) => {
  const session = useSession();
  const router = useRouter();

  useEffect(() => {
    if (!session.data && session.status !== 'loading') {
      void router.replace('/auth/signin');
    }
  }, [session]);

  if (router.pathname.includes('/auth')) {
    return <>{children}</>;
  }

  if (session.status === 'loading') {
    return <>Loading...</>;
  }

  return <>{children}</>;
};

_app.tsx
          <RouterGuard>
            <Component {...pageProps} />
          </RouterGuard>

This is what I have currently but I'm not sure how does this work with ssr.
I'm sorry if I'm missing something obvious, this stack is pretty new to me.
Thanks,
D

I am not familiar with this use-case, I have never had to protect every single route like this..
The way I usually do it is just via gSSP on a per-page basis:
export const getServerSideProps = async (ctx: GetServerSidePropsContext) => {
  const session = await getAuthSession(ctx);
  if (!session) {
    return {
      redirect: {
        destination: "/auth/signin",
        permanent: false,
      },
      props: { from: ctx.req.url }, // so that you can redirect to where they came from after login
    };
  }
  return { props: {} };
};

I feel like your approach is going to fail as soon as you add a single page where you don't want to authenticate. You probably want a landing page so that your users can see what the app is about before forcing them to sign in?


add community governance rules and membership list

What this PR does:
Add community roles description. see docs/zh/community/governance.md
Add Layotto community promote rules.see docs/zh/community/promote.md
Add Layotto community membership list. see docs/zh/community/people.md
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #203 (96c6ee2) into main (d021bb2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   56.36%   56.36%
=======================================
  Files          51       51
  Lines        2216     2216
=======================================
  Hits         1249     1249
  Misses        845      845
  Partials      122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d021bb2...96c6ee2. Read the comment docs.

I added some options in Reviewer promotion requirement:

I added explanation for why it is designed this way.Welcome to give your advice


404 Not Found

after run python app.py and python -m http.server
http://<IP_ADDRESS>:5000/ 404 Not Found
http://<IP_ADDRESS>:8000/ connection failed
can u give me some advice? thanks

Did you use  any proxy tool? I run those commands on my PC, it goes well.
You can open your browser's console to find the error details.

Is this only availabel tensorflow version? can pytorch be run？


Predict not working

Predict isn't working. Check what's going wrong.
After predicting, amount should be subtracted. Doesn't work.

To test, add to test case.
Eg, if 5 coins bet, expect wallet balance after that to be less by 5


Added docs and youtube links to a few blog posts, removed en-us from urls

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: vaheminasyan2 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Updates code coverage configuration

Description

Updates the code coverage tool configuration to set a bare minimum on testing coverage
Motivation and Context

Setting minimums for testing coverage
Types of changes

[ ] Refactor (changes the way we code something without changing its functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] Latest master code has been merged into this branch
[ ] No commented out code (if required, place // TODO above with explanation)
[ ] No linting issues
[ ] Build is successful
[ ] Code follows the API Guidelines
[ ] Updated the documentation
[ ] Added tests to cover changes
[ ] All new and existing tests passed

@all-contributors please add @DalerAsrorov for code, doc, ideas, maintenance, review and test


Updated README

#9

Great! Thanks a lot. May you add you additions to table of contents in Readme?

Done!

Merged. But I release new version after all issues for 1.1.0 have been done.


make postgres does not currently work with a remote database

I assume this should work, but it doesn't, in part because the Makefile is using hard coded values rather than environment variables.
If I shouldn't be using this for a remote database, it'd be nice if there were more detailed instructions on what to do instead.

Nevermind, I think I should just be using make migrate rather than relying on make postgres to do this.  (documentation would still be nice though.)


workflows: fix Relay pgrep check when using additional flags

When passing additional flags to cilium hubble port-forward, both the original command and kubectl child process might be conflated with additional flags.
We add wildcards for matching the additional flags.
Fixes 00ae9fb492f0c6313277106bdf50c740d0d395cc
Follow-up to #16787

Multicluster test passed: https://github.com/cilium/cilium/actions/runs/1012204661
Removing temp commit.


Video Player

We pulled down v1.7.0-rc.1 and we are noticing that the Lightbox Video Player is failing to load when a Content Block Segmented or Content Block Simple Pattern meets the following conditions:
The Pattern has both an Inline Video and a Linklist containing a video.
The LinkList Video has the same Kaltura ID as the one in the Inline Video.
Here is an example in a Drupal Lower Environment:
https://ode15.cms.ibm.net/analytics/test-kx-no-alias3
When the user clicks on the Folgers Coffee Video Link, the lightbox opens with a broken video player.

When the user closes that lightbox, the inline video player also is in an error state.

@ltitle Wondering if you can try to get confirmation from Content strategists on Reboot if the use case Ke tested above would happen:  Essentially would the same video (same Kaltura ID) be displayed in both the embedded player and the link list on a page?  thx

@ljcarot @kexuibm  I spoke with Tina Rapp and Jeff Eaton. They both agreed that while it may not be our best recommendation we should still support the ability for pages to reuse the same video in more than one place in case it is needed.
Some examples they provided for context:

A single video being used to different points in various locations
A round of up resources
A team that has very few assets so needs to reuse what they have in multiple places throughout the page

Thank you @ltitle .  @jeffchew @RobertaJHahn lets put this in backlog For sprint 12


Choosing a time for our Phase 1 Stack Club sessions

Hi all,
Let's choose a time for the phase 1 Stack Club to meet up, starting next week and continuing through till the August PCW.  Here's a quick doodle poll for you to fill out: please check the times you can make for a regular 2-hour session, starting the week of May 23 and then continuing every two weeks through till the August PCW. These will be working sessions, in which we'll take a look at the seed of a jupyter tutorial notebook, and then work together on improving it, or any of the others on our list.
It's going to be tricky to find a 2 hour window we can all make, but I think it's worth a try! The early PDT morning / late European afternoon is already pretty packed with various collaboration meetings (LSST and otherwise), so I propose we think of the DM Stack Club as either an evening hobby (if you're in Europe) or a lunchtime-ish activity in the US. We can always re-consider as we go, of course.
Thanks a lot - looking forward to seeing you next week!
Phil

@LSSTScienceCollaborations/dm-stack-club Don't forget to fill out the Stack Club doodle poll at https://doodle.com/poll/f8dqf9cq338efncr - looks like Fridays at 12 noon PDT are the early favorite, but let's see!


[WIP] Use shared Jenkinsfile

This fixes a potential issue with testing against the wrong schemas.
https://trello.com/c/YgLqWwFa

Picking this up in a couple of weeks.


Added front-end/backend async taskloop

I've taken the liberty to add a few things:

Created a UI to show dirty pages and allow user to check pages and commit/revert.
The UI resembles as much as possible the UI of Grav Admin.
Commit/revert/other request are sent async to server and passed to RequestHandler
RequestHandler detects the requested task (eg. fetch dirty pages/commit/revert/other) and handles the request.
Except for the fetching of dirty pages, the task handlers are dummies.

Environment:

Typescript
SCSS
Node

If you are interested, you may want to have a look at branch "pushy-admin-request". In case you don't like it,.. well I've had some fun anyway.
By the way, did you have a look at https://github.com/symplify/git-wrapper? The one you currently use is abandoned and quite old... Also, this one looks quite clean and simple.

Thank you! Looks good, gonna take a look shortly.

did you have a look at https://github.com/symplify/git-wrapper?

In the comment which brought this plugin about on GitSync, I mention that I discovered a few alternatives which look better and are active. Can't remember if that was one. Yes, I want to switch to one that's active and properly documented. Thanks for that too!

Was added circa e2a27c961349f9325ace9fb8def3c6779e97e1fa.
BTW @pamtbaau, do you know about referencing and closing issues in commit messages?

BTW @pamtbaau, do you know about referencing and closing issues in commit messages?

No, I didn't... Interesting feature though. Will keep in mind.


fix!: close streams gracefully

Refactors .close, closeRead and .closeWrite methods on the Stream interface to be async
The Connection interface now has .close and .abort methods
.close on Streams and Connections wait for the internal message queues to empty before closing
.abort on Streams and Connections close the underlying stream immediately and discards any unsent data
@chainsafe/libp2p-yamux now uses the AbstractStream class from @libp2p/interface the same as @libp2p/mplex and
@libp2p/webrtc

Follow-up PRs will be necessary to @chainsafe/libp2p-yamux, @chainsafe/libp2p-gossipsub and @chainsafe/libp2p-noise
though they will not block the release as their code is temporarily added to this repo to let CI run.
Fixes #1793
Fixes #656
BREAKING CHANGE: the .close, closeRead and closeWrite methods on the Stream interface are now asynchronous

Pushed to a different branch because for some reason GitHub isn't noticing pushes to #1864

Closing as GitHub appears to have woken up.


Generate #[must_use] for getters

Getters don't make sense if their values are unused, and most likely implies a forgotten bug or a misunderstanding of the API.
I am not sure whether marking a function #[must_use] breaks semver BC, but it would be healthy to add more #[must_use].

Whoa! I knew you could use it for structures, didn't know you could use it for functions!


Convert indentation to spaces

When viewing source on Github, the tabs are displayed as 8 spaces.  I think it would be helpful to update all the code to indent with 4 spaces instead of a tab.

This is only an issue of Github. And Apex Code has a hard character limit, so it's better to use one tab than multiple spaces.


CI test failure

The CI currently fails with:
Error:  Tests run: 720, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 57.881 s <<< FAILURE! - in TestSuite
Error:  com.google.refine.operations.recon.ReconOperationTests.serializeReconProcess  Time elapsed: 0.013 s  <<< FAILURE!

This is since a localization update which is obviously unrelated.
Example run: https://github.com/OpenRefine/OpenRefine/actions/runs/4730695127/jobs/8394730586

This is since a localization update which is obviously unrelated.

The serialization of operations includes their natural language description, so it seems like it could easily be related to a localization change if the locale isn't pinned or if the localization change inadvertently changed the description in English.

That's an excellent point, I forgot we had backend localization now.


Local  model support

LLaMa
GPT4ALL

hey @AlexsJones :wave: I might help here, I've been working on the llama.cpp binding for go, that allows model to be loaded directly from consumer grade hardware. you can find that over here: https://github.com/go-skynet/go-llama.cpp, hopefully that can help!
I'm also working on making an API out of it that mimics openAI, so can be used as a drop-in replacement, you can find that here: https://github.com/go-skynet/llama-cli

Hey @mudler thanks for dropping by, this is precisely one of the backends I would love to adopt.
I would be very keen to collaborate where possible on this.
I can see usecases where a company may wish to use llama + k8sgpt in a private cloud.. exciting stuff if we work together.
WDYT?

@AlexsJones definitely interested here, consider me hooked!
I see as well a lot of potential, especially if we think about situations more privacy-focused, and where vendor lock-in it's not an option.
I'm happy to jump in and contribute!

I've made some progress into mimicking the OpenAI api, supporting multiple local models, so I think I'm pretty close.
What I miss is a way to tell k8sgpt to use another API host, It seems to me that's not possible yet, or am I missing something?

I've made some progress into mimicking the OpenAI api, supporting multiple local models, so I think I'm pretty close.
What I miss is a way to tell k8sgpt to use another API host, It seems to me that's not possible yet, or am I missing something?

It's actually possible but we'd have to write a provider..
Do you want me to put something together if you can give me the local endpoint details?

We would need to "for now" write an in-tree provider against this API

I've made some progress into mimicking the OpenAI api, supporting multiple local models, so I think I'm pretty close.
What I miss is a way to tell k8sgpt to use another API host, It seems to me that's not possible yet, or am I missing something?

It's actually possible but we'd have to write a provider..
Do you want me to put something together if you can give me the local endpoint details?

that would definitely speed up things, I have few changes still to accommodate for having a good 1:1 "clone" of the OpenAI API and tag a release, but that also means that less changes should be required here (I think we can just use the same OpenAI client, but with a different host?). After that I was planning to have a look at the changes that might be required here so can have a good testbench for local iteration.
Another point that I almost forgot - we need also a configuration to specify the model to use as well in the several API calls, any input is appreciated!

Hey @mudler, I can try to help you with k8sgpt changes if you want to collaborate on this.
Feel free to touch base!

@arbreezy I'd be more than happy! I think I've almost got all the pieces from my side for a first try. I'll keep you posted when I've an API container image ready and docs with it. I'm about to tag now a release (  https://github.com/go-skynet/llama-cli/releases/tag/v0.6) which is working already - but docs aren't aligned.
There is another point to worth mentioning as part of this story - free models available up to now have a restricted license, as such some extra steps are needed, but nothing blocking I believe.

:wave: I've just tagged a new version that supports the OpenAI API, documentation on the supported calls is here: https://github.com/go-skynet/llama-cli#supported-openai-api-endpoints
Next I'll try to have a look at k8sgpt closer as soon as I have another cycle to dedicate to it so can likely help you there and try this out too!
This sounds very exciting and promising, we could even have dedicated, fine-tuned model just for suggesting Kubernetes solutions, making it quite faster instead of using generic models.

Added docker-compose file with easier-to-follow instructions https://github.com/go-skynet/llama-cli#usage sorry didn't had time to deep dive yet on k8sgpt, kubecon week, but it's next thing on my list :)

@arbreezy if you want to play with it meanwhile, feel free!

done some progress here! see the PR =)

amazing, I was about to pick this up during the weekend.
thanks for all the effort @mudler.


Moth wings should be a body part

surgery to replace meme wings with jetpack like they used to be on frontier

additionally: removing a moth's wings should make them lose their ability to fly in zero-gravity. (maybe if they take enough heat damage?)


bug: example1 fails to correctly extract number of ready pods

Describe the bug
https://docs.kubestellar.io/main/Coding Milestones/PoC2023q1/example1/#stage-3 includes the following bash command to extract the number of ready pods of the ReplicaSet named "commond".
kubectl get rs -n commonstuff --field-selector metadata.name=commond | tail -1 | sed -e 's/ \+/ /g' | cut -d " " -f 4

On my Mac this yields "0".  I think it has to do with a difference in bash or sed.  Here is some supporting evidence.
bash-3.2$ kubectl get rs -n commonstuff --field-selector metadata.name=commond
NAME      DESIRED   CURRENT   READY   AGE
commond   0         1         1       21m

bash-3.2$ kubectl get rs -n commonstuff --field-selector metadata.name=commond | tail -1 | sed -e 's/ \+/ /g'
commond   0         1         1       21m

bash-3.2$ kubectl get rs -n commonstuff --field-selector metadata.name=commond | tail -1 | sed -e 's/ \+/ /g' | cut -d " " -f 4
0

Steps To Reproduce
Shown above
Expected Behavior
The waiting succeeds when I try it.
Additional Context
No response

Also, --field-selector metadata.name=commond is an unnecessarily complex way to pick out the ReplicaSet whose exact name is already known.

FYI, the number of ready replicas can be directly output --- no text editing is required to pick it out.  Following is an example.
bash-3.2$ echo =$(kubectl get rs -n commonstuff commond -o 'jsonpath={.status.readyReplicas}')=
=1=


Which is better?

omost-llama-3-8b
omost-dolphin-2.9-llama3-8b
omost-phi-3-mini-128k
Which is better?

Search for Model Notes
https://github.com/lllyasviel/Omost

see https://github.com/lllyasviel/Omost/blob/41fda3c01dbcf7ae7d238d4fa83718f4a425e581/README.md?plain=1#L603
omost-llama-3-8b-4bits > omost-dolphin-2.9-llama3-8b-4bits > omost-phi-3-mini-128k-8bits


gmc: add authN & authZ support on keycloak

Description
Support the case that using the open source project Keycloak as the identity management tool and provide authentication materials (JWT tokens).
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.
Type of change

[ * ] New feature (non-breaking change which adds new functionality)

add gateway, authN and authZ yaml for keycloak option
add documentation for keycloak option

Dependencies
Keycloak
Istio

@irisdingbj @zhlsunshine Here's the PR for AuthN & AuthZ with Keycloak. Please take a look and help with the review.


Increase flexibility of mapping-service

Currently, the mapping-service makes some assumptions that are hard to follow and which make the service hard to be maintained. Two main issues are:

Python is required (even while Python tests are currently entirely disabled)
Plugins must be part of the source tree, which causes some tests to have dynamic pass conditions (see #8)

As a mid-term goal I would like to suggest some changes on the internal processes.

There should be an additional entity 'PluginRuntime' which can be configured in application.properties and is loaded on service startup, e.g., by a PluginRuntimeManager. In each plugin, the developer should check for the availability of a certain runtime required by the plugin, e.g., Python. If the particular runtime is not provided, the setup process of the plugin will not succeed and the plugin cannot be loaded. However, this should not result is an unsuccessful service startup. By doing so, it is also possible to adapt tests to either use a certain runtime or just stick with the default runtime(s), e.g., plain Java.
Currently, plugins must be placed in a folder of the mapping-service source tree in order to be found at runtime. However, during testing, the same folder is used which causes some issues while checking for 2 plugins (which are there by default) and after adding a new plugin, tests suddenly fail because tests are checking for 2 plugins. A solution could be, the offer another option to provide plugins for the actual running service instance. In order to cope with this issue, the altenate startup as it is described e.g. for base-repo using export JAVA_OPTS="-cp .:./config:./base-repo.jar -Dloader.path=./base-repo.jar,./lib/,." could be used to avoid classloader issues which occur if the plugins are loaded from the boot-jar. By doing so, locations of settings (./config), boot jar (./base-repo.jar), and additional libraries (./lib) can be provided easily avoiding all kinds of potential conflicts.

For the time being, sub-issue 1 (requirement of Python) stays unchanged as this would affect all existing plugins using Python.


Support integration with QuadGK with Measurement objects as endpoints

QuadGK supports out-of-the-box integration with integrand functions that return arbitrary types, including Measurement.  This pull requests further extends the quadgk method by supporting Measurement objects as endpoints of the integral.
As side effect, this fixes issue JuliaAstro/Cosmology.jl#7

Coverage increased (+0.008%) to 99.785% when pulling 370a0ba1012c2ce3d57dc3e5e7e5bee636da990f on quadgk into 38bc714b7ebd0396f2095ca4123634e548f5d9c7 on master.

Codecov Report

Merging #8 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   99.77%   99.78%   +<.01%
==========================================
  Files           7        7
  Lines         449      466      +17
==========================================
+ Hits          448      465      +17
  Misses          1        1

Impacted Files
Coverage Δ

src/Measurements.jl
93.75% <ø> (ø)
:white_check_mark:

src/math.jl
100% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38bc714...370a0ba. Read the comment docs.


Automagic GitHub repo stats display doesn't find www.github.com/user/repo URLs

As noted here, the automagic sidebar stats feature when a GitHub repo is the project homepage doesn't activate if the URL is written using www.github.com; it only finds github.com URLs.

We probably should make sure that this works for URLs like github.com and www.github.com, but not something like thisisnotgithub.com.

Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, please work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, please feel free to ask them here, #pypa-dev on Freenode, or the pypa-dev mailing list.

Mm, ... .endswith('.github.com') might suffice?

Mm, ... .endswith('.github.com') might suffice?

I don't think this would work for a URL like https://github.com/pypa/warehouse

Are there any other common *.github.com URLs that would not be composed as *.github.com/user/repo/..., and that someone might want to use as a homepage URL?
If so, a pattern matching condition might get pretty messy.  A narrower compound condition might be better.
if (parsed.netloc == 'github.com' or parsed.netloc == 'www.github.com') and ...

@bskinn Hope you don't mind -- since this is an improvement to a new feature, I'm marking it as something we can do after we shut down the legacy PyPI site.

@brainwane Nope! I figured it would get slotted for further down the pipeline, since it's a minor glitch.

To be clear: if you made a PR to fix this I would merge it, it's just not going to get fixed by one of the maintainers soon.

@di I can put together a PR to fix it, no problem; but I'm not set up with docker &c. to run the test suite locally.  Can I just rely on Travis to test it for me?
Also, if I'd need to add a test for the new behavior, I'd need guidance as to where in the test suite to add it.

@bskinn Travis will definitely test it for you. You probably don't need to be able to run the tests locally to fix this issue, but it's not too complicated and we have a pretty good guide: https://warehouse.readthedocs.io/development/getting-started/


python310Packages.readme_renderer: 37.0 -> 37.2

Description of changes
https://github.com/pypa/readme_renderer/releases/tag/37.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 192821 run on x86_64-linux 1

8 packages failed to build:

pypiserver (python310Packages.pypiserver)
python310Packages.spacy
python310Packages.spacy-transformers
python310Packages.textacy
python39Packages.pypiserver
python39Packages.spacy
python39Packages.spacy-transformers
python39Packages.textacy

59 packages built:

apache-airflow (python310Packages.apache-airflow)
check_systemd
dialect
dtrx
evdevremapkeys
home-assistant-component-tests.google_translate
keepkey_agent (python310Packages.keepkey_agent)
ledger_agent (python310Packages.ledger_agent)
luigi
mailman-web
mnemosyne
onlykey-agent
python310Packages.ansible-kernel
python310Packages.ansible-runner
python310Packages.gtts
python310Packages.invocations
python310Packages.langcodes
python310Packages.language-data
python310Packages.libagent
python310Packages.marisa-trie
python310Packages.nagiosplugin
python310Packages.ndjson
python310Packages.python-daemon
python310Packages.readme
python310Packages.readme_renderer
python310Packages.restview
python310Packages.salmon-mail
python310Packages.textx
python310Packages.toggl-cli
trezor_agent (python310Packages.trezor_agent)
twine (python310Packages.twine)
python310Packages.wheel-inspect
python310Packages.wordfreq
python39Packages.ansible-kernel
python39Packages.ansible-runner
python39Packages.apache-airflow
python39Packages.gtts
python39Packages.invocations
python39Packages.keepkey_agent
python39Packages.langcodes
python39Packages.language-data
python39Packages.ledger_agent
python39Packages.libagent
python39Packages.marisa-trie
python39Packages.nagiosplugin
python39Packages.ndjson
python39Packages.python-daemon
python39Packages.readme
python39Packages.readme_renderer
python39Packages.restview
python39Packages.salmon-mail
python39Packages.textx
python39Packages.toggl-cli
python39Packages.trezor_agent
python39Packages.twine
python39Packages.wheel-inspect
python39Packages.wordfreq
strictdoc
wlc


document otel instrumentation annotations not supported

Document that OpenTelemetry instrumentation annotations are not supported.

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-08-24T10:13:48.228+0000

Duration: 4 min 19 sec

:grey_exclamation: Flaky test report
No test was executed to be analysed.
:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark tests.

run jdk compatibility tests : Run the JDK Compatibility tests.

run integration tests : Run the Agent Integration tests.

run end-to-end tests : Run the APM-ITs.

run windows tests : Build & tests on windows.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


Needs to get stack in any region

Related to https://github.com/zalando/lizzy-client/issues/70

:+1:

Coverage remained the same at 90.249% when pulling f7bd8f524b1460df298f4e453dc40074bdd2803d on rafaelcaricio:use-region-when-gettings-stack into 61e5ca72bfb3f37efc36566b52880b15ff1b6ba3 on zalando:release2.0.


Clear search query parts using special token

Closes #67

Codecov Report

Merging #71 (2dcd7aa) into master (6c30aca) will decrease coverage by 12.63%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           master      #71       +/-   ##
===========================================
- Coverage   80.98%   68.34%   -12.64%
===========================================
  Files          51       51
  Lines        5112     5112
  Branches      616      616
===========================================
- Hits         4140     3494      -646
- Misses        735     1430      +695
+ Partials      237      188       -49

Impacted Files
Coverage Δ

...monMain/kotlin/dev/evo/elasticmagic/SearchQuery.kt
96.34% <91.66%> (-1.63%)
:arrow_down:

...in/dev/evo/elasticmagic/serde/jackson/JsonSerde.kt
0.00% <0.00%> (-100.00%)
:arrow_down:

.../evo/elasticmagic/compile/UpdateMappingCompiler.kt
0.00% <0.00%> (-96.67%)
:arrow_down:

...otlin/dev/evo/elasticmagic/compile/BulkCompiler.kt
0.00% <0.00%> (-90.91%)
:arrow_down:

...otlin/dev/evo/elasticmagic/ElasticsearchCluster.kt
0.85% <0.00%> (-90.60%)
:arrow_down:

...c/commonMain/kotlin/dev/evo/elasticmagic/Result.kt
9.33% <0.00%> (-89.34%)
:arrow_down:

...v/evo/elasticmagic/serde/jackson/JsonSerializer.kt
0.00% <0.00%> (-83.34%)
:arrow_down:

...evo/elasticmagic/serde/jackson/JsonDeserializer.kt
0.00% <0.00%> (-83.34%)
:arrow_down:

...ev/evo/elasticmagic/compile/CreateIndexCompiler.kt
0.00% <0.00%> (-81.40%)
:arrow_down:

...onMain/kotlin/dev/evo/elasticmagic/query/Nested.kt
0.00% <0.00%> (-76.48%)
:arrow_down:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c30aca...2dcd7aa. Read the comment docs.


Flutter Image Picker Plugin Error while pub get.

Because image_picker >=0.7.0 depends on image_picker_platform_interface ^2.0.0 which depends on http ^0.13.0, image_picker >=0.7.0 requires http ^0.13.0.
And because http >=0.13.0 depends on http_parser ^4.0.0, image_picker >=0.7.0 requires http_parser ^4.0.0.
And because dio 3.0.10 depends on http_parser >=0.0.1 <4.0.0 and no versions of dio match >3.0.10 <4.0.0, image_picker >=0.7.0 is incompatible with dio ^3.0.10.
So, because brief9_pro depends on both dio ^3.0.10 and image_picker ^0.7.5+3, version solving failed.
pub get failed (1; So, because brief9_pro depends on both dio ^3.0.10 and image_picker ^0.7.5+3, version solving failed.)

We don't control the dio package. If you want to use it with the latest version of image_picker you'll need to contact the dio developers about updating their dependencies.

Solved by upgrading flutter and upgrading package dio. Thank you.


Updating the Quickstarts for ODF operator

For 4.9 release, OCS operator will be replaced with the ODF at a higher level. Hence we would want to make sure that new quickstarts accurately represent the workflows for ODF operator.
This commit includes all the relevant changes that are applicable to newer UI that is coming as part of OCP 4.9
Signed-off-by: Vineet Badrinath<EMAIL_ADDRESS>

Although I'm seeing changes of 4.7 -> 4.9, meaning that these are also out of date for OCS 4.8. That should probably be something to update and backport to release-4.8, but given where we are with dev freeze we may need to raise a BZ and see if QE will approve it.

The version is just the resource version that i had added in 4.7 when i initially added these, it has no bearing on the functionality of the quickstarts. The quickstart still holds well for OCS 4.8 as well. We may remove the version information if needed.
Lot of quickstarts in https://github.com/openshift/console-operator/tree/master/quickstarts have similiar pattern.

This is not valid for ocs-operator. The quickstarts should be moved to https://github.com/red-hat-data-services/odf-operator for 4.9.

This is an interesting question here and has me confused as well.
The quickstarts provide guidance for Day 1 and Day 2 operations on the storage cluster which is managed by OCS . ODF on the other hand manages StorageSystem which has no effect on the operations that are listed here.  We are only rebranding the name here to ODF for the UI.
I believe these resources should be managed by OCS itself  and not ODF as the user will be directly interacting with the StorageCluster CR for these operations.
@jarrpa Let me know your thoughts on this?

The version is just the resource version that i had added in 4.7 when i initially added these, it has no bearing on the functionality of the quickstarts. The quickstart still holds well for OCS 4.8 as well. We may remove the version information if needed.
Lot of quickstarts in https://github.com/openshift/console-operator/tree/master/quickstarts have similiar pattern.

That's fine, if it can be removed all the better. Still, as of now they will he showing "4.7" in OCS 4.8. How urgent that is or isn't is not my call to make, however.

This is not valid for ocs-operator. The quickstarts should be moved to https://github.com/red-hat-data-services/odf-operator for 4.9.

This is an interesting question here and has me confused as well.
The quickstarts provide guidance for Day 1 and Day 2 operations on the storage cluster which is managed by OCS . ODF on the other hand manages StorageSystem which has no effect on the operations that are listed here. We are only rebranding the name here to ODF for the UI.
I believe these resources should be managed by OCS itself and not ODF as the user will be directly interacting with the StorageCluster CR for these operations.

Thing is, we are moving away from exposing the StorageCluster. All of the workflows described in these files will be moving to a different portion of the UI branded as "Storage Systems", which are CRs managed by odf-operator. Admins working through the GUI for normal day 1 and day 2 operations will never see the StorageCluster CR.

This should be inside ODF Operator. And be removed everything from here. Items related to StorageCluster should stay here. The guides need to be totally revamped as per the new dashboard and systems list page.

This should be inside ODF Operator. And be removed everything from here. Items related to StorageCluster should stay here. The guides need to be totally revamped as per the new dashboard and systems list page.

Discussed it with @jarrpa earlier.  Working on moving these to ODF.
@bipuladh What items are you referring to though?
If we move, we shall be moving both of the QS to ODF.
The guides already have information corresponding to the current design and will change accordingly if the design changes

@vbnrh If we are moving it to ODF, can we close this PR?

@umangachapagain I'll update this PR to remove Quickstarts.

@jarrpa I was wondering if we should keep the permissions and uninstaller flow for this release (or move it in some other directory)
If user upgrades from OCS 4.8 to ODF 4.9, we may need to delete the older versions quickstarts as ODF will be creating the newer ones .
How do we proceed about doing it ?

Apologies for the extended delay. :pray:

@jarrpa I was wondering if we should keep the permissions and uninstaller flow for this release (or move it in some other directory)
If user upgrades from OCS 4.8 to ODF 4.9, we may need to delete the older versions quickstarts as ODF will be creating the newer ones .
How do we proceed about doing it ?

We could have an operator make sure the old ones don't exist. That said, if the resource names of the Quickstarts are not visible to the admin we could just leave the names the same and just move the Quickstart functions to odf-operator. Either one would be fine. For now I'll merge this one and we can submit a follow-up PR if we decide to have ocs-operator deal with them.
/lgtm


remove sidecar, fix scale test

can be tested with redis-writer for function-replicas events
j.

LGTM


Air-gapped signing

As a user I want to use the Safe Multisig on a completely air-gapped device so that I can minimize attack vectors.

Closing this as it's duplicate to #986


std.math.poly: optimisation for LDC.

Many functions from std.math and std.mathspecial use poly, so
this PR affects significant part of math.
See also: http://llvm.org/docs/LangRef.html#llvm-fmuladd-intrinsic

LGTM, as long as it doesn't break any of the math/mathspecial tests when using LDC?

I don't think that we should be allowing compiler-specific things into phobos (I/we make the same complaint with dmd-specific code too).

Any hard numbers proving this generates better code?

I don't think that we should be allowing compiler-specific things into phobos (I/we make the same complaint with dmd-specific code too).

Looks reasonable, then I should move this code to LDC fork.

Any hard numbers proving this generates better code?

Yes: The ‘llvm.fmuladd‘ intrinsic functions represent multiply-add expressions that can be fused if the code generator determines that (a) the target instruction set has support for a fused operation, and (b) that the fused operation is more efficient than the equivalent, separate pair of mul and add instructions.

I might suggest using core.stdc.math.fma and core.stdc.math.fmaf instead (also, GDC recognizes all core.stdc.* declarations as builtins).

Is fma always fused or only if (a) and (b) like llvm.fmuladd ?

Please don't. If core.stdc.math.fma cannot be used (without looking at the docs, I suspect that they guarantee rounding only once), we should add an appropriate intrinsic to core.math. Phobos should be shared across all the compilers.

Agreed.

Other reason to add intrinsic to core.math is that LLVM inline assembler is not CTFEable.

Other reason to add intrinsic to core.math is that LLVM inline assembler is not CTFEable.

Not that adding it as an intrinsic will magically make the LLVM inline assembler CTFEable either...


HDDS-9485. Let integration check reuse Ozone jars from build check

What changes were proposed in this pull request?
Let integration check reuse Ozone jars created in build check, instead of building everything from scratch.  These jars are not part of the cached Maven repo, so we need to upload/download them separately.
If there is a problem downloading the artifact (e.g. it has expired), integration.sh falls back to previous behavior.
To reduce code duplication, flaky/other executions are merged into the same code block.
https://issues.apache.org/jira/browse/HDDS-9485
How was this patch tested?
Time for integration check's splits decreased by 10-20 minutes each compared to latest run on master.

@ArafatKhan2198 @devmadhuu @Galsza please review

The links in the PR description are same though.

Time for integration check's splits decreased by 10-20 minutes each compared to latest run on master.

The links in the PR description are same though.

Thanks for pointing it out.
Here's the link to the run in my fork:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/6556786545
(also updated the description)

Thanks @devmadhuu, @sadanand48 for the review.


Implement Struct-Based Components in rsx Macro

Feature Request
I would like to propose a feature where we can use structs directly as components within the rsx! macro in Dioxus. This feature would let us group related components and define both the data and the rendering logic in the same struct.
Let’s look at this code:
#[component]
pub fn Alert(#[props(optional)] class: String, #[props(optional)] children: Element) -> Element {
    rsx! {
        div {
            class: "bottom-4 right-4 flex items-center p-4 text-sm border rounded-lg bg-gray-800",
            class: class,
            {children}
        }
    }
}

#[component]
pub fn InfoAlert(#[props(optional)] classes: String, #[props(optional)] children: Element) -> Element {
    rsx! {
        Alert {
            class: "text-blue-400 border-blue-800",
            div {
                span { class: "font-medium", "Info! " }
                {children}
            }
        }
    }
}

#[component]
pub fn WarningAlert(#[props(optional)] class: String, #[props(optional)] children: Element) -> Element {
    rsx! {
        Alert {
            class: "text-yellow-300 border-yellow-800",
            div {
                span { class: "font-medium", "Warning! " }
                {children}
            }
        }
    }
}

These components are related to each other. With the Struct-Based Component feature, we could group these functions.
struct Alert {}

impl Alert {
    #[component]
    pub fn Base(#[props(optional)] class: String, #[props(optional)] children: Element) -> Element {
        rsx! {
            div {
                class: "bottom-4 right-4 flex items-center p-4 text-sm border rounded-lg bg-gray-800",
                class: class,
                {children}
            }
        }
    }

    #[component]
    pub fn Info(#[props(optional)] classes: String, #[props(optional)] children: Element) -> Element {
        rsx! {
            Base {
                class: "text-blue-400 border-blue-800",
                div {
                    span { class: "font-medium", "Info! " }
                    {children}
                }
            }
        }
    }

    #[component]
    pub fn Warning(#[props(optional)] class: String, #[props(optional)] children: Element) -> Element {
        rsx! {
            Base {
                class: "text-yellow-300 border-yellow-800",
                div {
                    span { class: "font-medium", "Warning! " }
                    {children}
                }
            }
        }
    }
}

And usage in the rsx! macro:
pub fn my_comp() -> Element {
    rsx! {
        Alert::Info{}
    }
}

This new approach would simplify how we organize and manage our code, making it cleaner and easier to maintain.

You can use a module to group components together under a namespace:
#[allow(non_snake_case)]
mod Alert {
    #[component]
    pub fn Base(#[props(optional)] class: String, #[props(optional)] children: Element) -> Element {
        rsx! {
            div {
                class: "bottom-4 right-4 flex items-center p-4 text-sm border rounded-lg bg-gray-800",
                class: class,
                {children}
            }
        }
    }

    #[component]
    pub fn Info(#[props(optional)] classes: String, #[props(optional)] children: Element) -> Element {
        rsx! {
            Base {
                class: "text-blue-400 border-blue-800",
                div {
                    span { class: "font-medium", "Info! " }
                    {children}
                }
            }
        }
    }

    #[component]
    pub fn Warning(#[props(optional)] class: String, #[props(optional)] children: Element) -> Element {
        rsx! {
            Base {
                class: "text-yellow-300 border-yellow-800",
                div {
                    span { class: "font-medium", "Warning! " }
                    {children}
                }
            }
        }
    }
}

If you have a lot of shared props, you can use #[derive(Props)] with one struct and use that struct in many components:
#[allow(non_snake_case)]
mod Alert {
    #[derive(Props)]
    struct AlertProps {
        #[props(optional)] class: String,
        #[props(optional)] children: Element
    }

    #[component]
    pub fn Base(
        props: AlertProps,
    ) -> Element {
        rsx! {
            div {
                class: "bottom-4 right-4 flex items-center p-4 text-sm border rounded-lg bg-gray-800",
                class: props.class,
                {props.children}
            }
        }
    }

    #[component]
    pub fn Info(props: AlertProps) -> Element {
        rsx! {
            Base {
                class: "text-blue-400 border-blue-800",
                div {
                    span { class: "font-medium", "Info! " }
                    {props.children}
                }
            }
        }
    }

    #[component]
    pub fn Warning(props: AlertProps) -> Element {
        rsx! {
            Base {
                class: "text-yellow-300 border-yellow-800",
                div {
                    span { class: "font-medium", "Warning! " }
                    {props.children}
                }
            }
        }
    }
}

Could you elaborate on how struct based components would improve the existing solutions?

@ealmloff, your approach is indeed a good solution. However, if we want to prepare our struct in advance and use it elsewhere, I can imagine scenarios, especially complex ones, where this approach might be the better solution. It also allows us to develop the app with an OOP approach. There could even be cases where using generics would be beneficial.

This isn't something we want to add today but if it becomes useful maybe we'll reconsider it. It's hard to support lots of variants of app architectures while also shipping other important things, so not planned as of today.

but if it becomes useful maybe we'll reconsider it.

Can you explain in more detail? How will we understand that it will become useful?

I think I can provide an example. Let's assume we want to initialize a component, but there are three different types of components that can be initialized based on the data. If we follow this implementation, it would be easier because MyStruct::Component{} can return various components. We prepare the data beforehand, and the Component function examines this data to return different components accordingly. Currently, we must prepare the struct and pass it as parameters to the component function. However, if we want to initialize the component by sending the struct as a parameter, we must either manage all views in the same function or make comparisons in the parent rsx macro, which decreases code readability. This implementation proposes writing Dioxus in a more abstracted and readable manner.

Another idea:
impl Into<Element> for MyStruct {
    fn into(self) -> Element {
        rsx! {
            ...
        }
    }
}


[TW-154] bump network-transport revision

This one has a fix to prependLength which checks for overflow. It's in
mainline master but we use a fork.

There were some bugs with CI, rebase on top of latest master to make CI pass (hopefully).


Added greenkeeper package ignore list [Finishes #148849643]

@miq-bot add_label housekeeping
@miq-bot add_label tools
@miq-bot add_label fine/no

it looks like github is sleeping on the job.  It is not reporting back status on my PR's

Build passed, but travis didn't update the status.
https://travis-ci.org/ManageIQ/manageiq-ui-service/builds/253306765


Configure httpRedirect on istio gateway in helm

Fixes #
Update knative-serving CRD to allow configuring of HTTP->HTTPS redirection on Istio Gateway through helm chart. Currently through knative operator helm chart HTTP->HTTPS redirection on Istio Gateway is not configurable. This was done only in Knative operator manifest file in this PR: https://github.com/knative/operator/pull/1912
Issue: https://github.com/knative/operator/issues/1944

@AyushSawant18588 could you join the knative org to pass the EasyCLA checking?


[usbdev/all] Interrupt loss with dif__irq_acknowledge_all

Description
Potential for losing interrupts with the auto-generated '_irq_acknowledge_all' function, as in dif_usbdev_irq_acknowledge_all.
The set of pending interrupts is read by the interrupt handler (eg. dif_usbdev_irq_get_state()) but there is no efficient means to clear just the set of interrupts that have been collected by the interrupt handler. Instead the dif_usbdev_irq_acknowledge_all clears all interrupts by writing UINT32_MAX to the register.
This has the potential to cause loss of interrupts that have set other bits in the register, between the invocation of _get_irq_state() and the call to _acknowledge_all().
Perhaps there is a convention/understanding that prevents the loss of interrupts in other blocks, eg. they will immediately be raised again since the underlying condition has not been resolved, but some of the interrupts in the usbdev IP are single-cycle events of which the software should be informed and they cannot be relied upon to occur again.
With the interrupt state register (INTR_STATE) being rw1c, should it not be the case that there is a usbdev_irq_acknowledge_<>(... , uint32_t clr) call that accepts the precise set of interrupts to be cleared, rather than force them to be cleared individually with the current dif_usbdev_irq_acknowledge(..., dif_usbdev_irq_t irq) call which clears just one?
The set of interrupts which are triggered by single-cycle events from state transitions in usbdev is:

disconnected
link_reset
link_suspend
host_lost
link_powered

If this needs wider attention, to whom should I assign it, please?

This is just about the DIFs, right? Know that those are only used for tests, so we're probably the most interested party for usbdev, heh.
Though... this is actually a more general missing feature of DIFs. Things may have changed, but @timothytrippel and I were probably the most recent maintainers of general DIF features. I don't see why we couldn't have a dif_usbdev_clear_irq_state(), perhaps taking in a dif_usbdev_irq_state_snapshot_t or similar.

Yes, it is just about the current software, and I'm aware that the DIFs have never been intended to become the basis for production code. That said, it's something that perhaps an auto-generated API should avoid, because there is a risk of frustrating development/testing, or of tripping up production interrupt-handling code.
Being new to the project, I don't know whether it would be appropriate to flag this more generally, raise a PR against the global cause (reggen?) or perhaps just a PR against dif_usbdev? Thoughts, please?
For the moment I have changed usb_testutils to acknowledge individually only the interrupts collected/processed, because we are indeed perhaps the most likely to run into problems at this stage.

Yes, it is just about the current software, and I'm aware that the DIFs have never been intended to become the basis for production code. That said, it's something that perhaps an auto-generated API should avoid, because there is a risk of frustrating development/testing, or of tripping up production interrupt-handling code.
Being new to the project, I don't know whether it would be appropriate to flag this more generally, raise a PR against the global cause (reggen?) or perhaps just a PR against dif_usbdev? Thoughts, please?
For the moment I have changed usb_testutils to acknowledge individually only the interrupts collected/processed, because we are indeed perhaps the most likely to run into problems at this stage.

Right, I just meant that we're probably the ones who will collectively do the work and approve/reject it. I went ahead and created a PR for this in #17363.
And yes, it would be best to flag this more generally. You found that the ...acknowledge_all() DIFs can create unfortunate race conditions, and it comes with pitfalls for anyone using the DIFs for potentially any IP.


test(v1.x): expand apphash test with all state machine msgs

Overview
Consistent Apphash test on v1

doesn't have to be changed here, but I still think that pursuing a table driven approach is best here, even if that means we have to add some functionality in testapp
the main reasons were similar to what we've discussed before, just that adding things to table driven tests is intuitive and we can isolate msgs. atm this test can break and we don't immediately know which module changed its state machine in a breaking way
we also don't have the ability to change the app version, which presumably is something else that we would need if we want to make it easy on ourselves in the future when we expand these tests

I'd say that I can revisit this when i have to write consistent apphash test for v2. We can then figure out how we want different versions to be tested + the structure. Then I'd also refactor this to the table driven approach. Updated the AC on the v2 testing issue: https://github.com/celestiaorg/celestia-app/issues/3624
Although the way i see this test breaking mostly is by application producing a different hash to what's expected because we accidentally made an apphash breaking change to the state machine.


[BUG] error on complex types list type field [category] has empty string, cannot process it

What is the bug?
I am creating a text embedding processor that creates vectors on a nested field. However, I receive illegal_argument_exception because not all the fields in the object meet the requirement

string
map
string list

Here is the explanation from the AWS support specialist

Our internal team informed me that this exception happened when the “id” under “brand” field has int value that is not supported by the text embedding processor from ingestion pipeline, and the fields inside the complex type must be of types: string, map or list.

However, I am not creating vectors on id so I don't understand why it must follow these requirements. Is this expected behaviour or is this a bug?
How can one reproduce the bug?
Steps to reproduce the behavior:

create ingest pipeline

PUT /_ingest/pipeline/neural-search-pipeline-v2
{
  "description": "An example neural search pipeline",
  "processors": [
    {
      "text_embedding": {
        "model_id": "WeliNowB6EaQJ_XFf05V",
        "field_map": {
          "category": {
            "name": {
              "en": "category_name_vector"
            }
          }
        }
      }
    }
  ]
}

simulate ingest pipeline

POST _ingest/pipeline/neural-search-pipeline-v2/_simulate
{
  "docs": [
    {
      "_index": "neural-search-index-v2",
      "_id": "1",
      "_source": {
        "category": {
          "id": 1,
          "name": {
            "en": "category 1"
          }
        }
      }
    }
  ]
}

What is the expected behavior?
should create vectors on category name
{
    "docs": [
      {
        "doc": {
          "_index": "neural-search-index-v2",
          "_id": "1",
          "_source": {
            "category": {
              "name": {
                "category_name_vector": [
                  0.019107267,
                  -0.029297447,
                  0.0070927013,
                  -0.022105217,
                  ...
                ],
                "en": "category 1"
              },
              "id": 1
            }
          },
          "_ingest": {
            "timestamp": "2024-01-08T17:59:39.543401762Z"
          }
        }
      }
    ]
  }

What is your host/environment?

OS: AWS Opensearch Service Managed Cluster
Version 2.11

Do you have any screenshots?
{
   "failures": {
        "index": "neural-search-index-v2",
        "id": "5302821",
        "cause": {
          "type": "illegal_argument_exception",
          "reason": "list type field [category] has empty string, cannot process it"
        },
        "status": 400
   },
   ...
}

Do you have any additional context?
invalid doc
{
   "brand": {
      "id": 123, // cannot be integer
      "description": {
         "en": "en description female",
         "fr": "" // cannot be empty string
      }
      ...
   },
   "category": {
      "id": "123", // valid string
      "sizes": [
         "XS",
         "XL",
         "", // elements in list cannot be empty strings
         123 // elements in list cannot be integers
         ...
      ]
   }
}

valid doc
{
   "brand": {
      "id": "123",
      "description": {
         "en": "en description"
      }
      ...
   },
   "category": {
      "id": "123",
      "sizes": [ ] // empty list is valid
   }
}

@toyaokeke Hi looking in your pipeline, it's the text embedding processors throwing exceptions. Should be related to the neural search plugin @navneet1v

@mingshl correct the text embedding processor is throwing the error. Should I move this discussion to that project instead?

sounds good to me. thanks!! you can close this one or move to the neural search plugin

@mingshl correct the text embedding processor is throwing the error. Should I move this discussion to that project instead?

sounds good to me. thanks!! you can close this one or move to the neural search plugin

Issue is now reported in the neural-search project. Thank you very much 🙏🏿
https://github.com/opensearch-project/neural-search/issues/678


Add checkr/flagr backward compatibility test

Adds a new test target in integration tests
Use the same integration tests for the docker image of checkr/flagr:1.1.12

Codecov Report

Merging #19 (ead3ae2) into main (9d01b81) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   81.55%   81.55%
=======================================
  Files          27       27
  Lines        2174     2174
=======================================
  Hits         1773     1773
  Misses        314      314
  Partials       87       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d01b81...ead3ae2. Read the comment docs.


Extract board outline

When pcbmode is run with the -e flag now, it extracts the location of the routed paths, vias, documentation, and components, but not the board outline (or the PCB color legend). This means that any adjustments to the outline are lost in the normal compile-extract-compile workflow, or they have to be redone on every cycle.

I'm starting to work on the next version of PCBmode at branch cinco-master.
I plan on adding a specific switch for extracting the outline (similarly to --extract-refdefs). I suggest:
--extract-outline


MINOR: avoid unnecessary UnsupportedOperationException

We did no complete KIP-714 with regard to collecting producer clients instance IDs in Kafka Streams if EOSv1 is enabled. Instead of throwing an UnsupportedOperationException, we should return an empty map.

We still don't have an RC for 3.7, so it would be great to close this minor gap to provide a better user experience. \cc @stanislavkozlovski for visibility


Update automate-document-processing-azure-form-recognizer-content.md …

Adjust readability

Thanks for raising these articles to our attention. Unfortunately, copy edits need to be done internally to ensure that articles follow Microsoft style and formatting guidelines. We'll close this PR and submit the file for an internal copy edit.
#please-close


Cumulative case and death rates dropped on Oct 27

Cumulative case and death rates, coming from the indicator-combo signal, dropped on Oct 27.  See the screenshots below from the COVIDcast map.
The counts themselves do not appear to drop, see the following two screenshots.
Lastly, both case and death rates and counts are missing on Nov 2: I'm not sure it this is related to the JHU struggles we've been having.  I couldn't find an issue on this so I'm pointing it out here.
cc @krivard, and @jingjtang who I think worked on the cases and deaths signals

@krivard @jingjtang Just an update that this appears to be fixed now, on the COVIDcast map.
There's no longer a drop in cumulative case rates or cumulative death rates, and there's also no longer data that appears to be missing.
So I guess we can close this issue?  @krivard I'll let you do that.  That said, it would be probably good to understand why this happened, to see if we still need to fix something to prevent it popping up again.
(Also, I didn't intend to assign @nmdefries that must have been a mistake, my bad.)

This work  is under way -- the combo cases/deaths indicator was running in a mode where it just updated the last week of data, instead of generating the full time span and using the archive/diff utility to extract just the updated rows. For the last few days it's been generating dense issues, which is not sustainable but did fix the symptom identified in this issue. Tonight's run will be the first using the uniform issue definition, and if that works, I'll close this then.
(Also: Nat is auto-assigned to data quality issues, since he's currently the data validation tsar)


JellySkin won't load background images

Hi! The Jellyskin skin won't load background images even wehn others and default skin does.

same for me

You should report it in JellySkin's repository (https://github.com/prayag17/JellySkin)


[BugFix][VTA] tvm.tir.Call has no name attribute

tvm.tir.Call has no name attribute, this attribute belongs to op.

Code Review: @junrushao @Lunderberg   Thanks!


Missing early error for new.target

According to the spec, this source is invalid:
var x = new.target;

Both Esprima and Espree throw an error whenever new.target is used outside of a function. Shift throws an error with early warnings turned on.
Should this throw an error in Acorn?

BTW, happy to submit a PR if this is desired.

Yes, we are forbidding return outside of functions, so it'd make sense to check this too. PR would be wonderful.

I'll work on a PR today


Fix images in BetterDiscord

Images weren't shown on https://betterdiscord.app/theme/AMOLED-Cord because a relative path was used which only works in GitHub. I put the full URL path so that the images work on BetterDiscord.

fixed in v2


Overlay image and isocenter spot not wiped

When a new isocenter/mouse is loaded, it seems like the overlay image is not wiped clean. This looks troublesome and should be adressed. Especially the old isocenter crosshair is still painted into the image, so it's impossible to see which is the correct (i.e., new) one.

Root cause: The Display object containers for the image overlay were not connected to the workflow step that is attached to the loading of Plan/Radiography images.
Fixed in ee3706a1782110b2bb76277fc8221548b514a384


How can I typecheck these examples?

Is there a typechecker which can verify all these examples? Is it this one: https://github.com/MaiaVictor/cedille-core ? If yes, how can I use it? A few lines about this in the README would be appreciated :wink:

Hi Samuel,
The type checker to use is here https://github.com/cedille/cedille.
The "artifact" branch has a document that explains how to work with Cedille for
the purpose of evaluating our generic-reuse work.
The master branch is only ahead of the artifact branch in minor ways, so the document should apply to the master branch as well.
The artifact branch includes a pre-released version of Cedille, if you don't want to separately
git clone and install it, but I suggest installing the now open source Cedille instead
(following these installation instructions).
Alternatively, if you don't want to manually install anything, there is a Virtual Box image
of the artifact branch that you can install from here,
by clicking the "Source Materials" tab on the bottom and downloading the zip file.

Thanks! (now I'm stuck on https://github.com/cedille/cedille/issues/25, though...)


Tabs emit the (selectedTabChange) in CD cycle

Bug, feature request, or proposal:
bug
What is the expected behavior?
Event (selectedTabChange) should be emitted when content has been already attached, using animation callback, not in change detection cycle?
What is the current behavior?
Event (selectedTabChange) is emitted in change detection cycle, so we can not use it to change templates.
And there is no event before the dynamic content of the selected tab is attached, so we can not select the new tab with the context, we need (fetch server data, etc).
What is the use-case or motivation for changing an existing behavior?
Make our life better pls)
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Material 6.2.1

Hello! We landed a change in August 2018 that deferred the event so that it runs a tick after the content has been checked. That might have improved the situation.
Please let us know if this still an issue. We are happy to look into it. Thanks!


deployment

I decided not to change the database to SQLite. Instead, I resolved the error in "libman.json".

This works