Fix 3D training with data augmentation

Checklist
GitHub

[x] I've given this PR a concise, self-descriptive, and meaningful title
[x] I've linked relevant issues in the PR body
[x] I've applied the relevant labels to this PR
[x] I've assigned a reviewer

PR contents

[x] I've consulted ivadomed's internal developer documentation to ensure my contribution is in line with any relevant design decisions
[x] I've added relevant tests for my contribution
[x] I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

Description
In this PR:
This PR fixes #1213 where 3D training would fail when using data augmentation after the merge of PR #1169.
The bug was created by the "sample" (stack_input or stack_gt) being passed to transforms as numpy arrays instead of list.
Because we don't have tests for training in 3D, I added test_training_3d.py to testing with 4 tests covering the following scenarios, all including transform (preprocessing and data augmentation):

3D 1-class single channel training
3D 2-class single channel training
3D 1-class multichannel training
3D 1-class multi-rater training

I also revised the other changes from PR #1169 and everything else seems correct, but I made some minor corrections on a few comments in mri3d_subvolume_segmentation_dataset.py for clarity.
To test this PR:

Run a 3D training with "RandomAffine" in transformations on master branch --> you should have an error that looks like this one:

metadata[MetadataKW.ROTATION] = [angle, axes]
Traceback (most recent call last):
  File "/Applications/PyCharm CE.app/Contents/plugins/python-ce/helpers/pydev/_pydevd_bundle/pydevd_exec2.py", line 3, in Exec
    exec(exp, global_vars, local_vars)
  File "<input>", line 1, in <module>
TypeError: list indices must be integers or slices, not str

Run the same training on this branch --> the training should start as expected.
See an example of config file and error log in the original issue: https://github.com/ivadomed/ivadomed/issues/1213#issue-1494577149

Additional note:
I will open another issue (#1223) regarding the harmonization of get_item in mri2d_segmentation_dataset.py and mri3d_subvolume_segmentation_dataset.py.
Both are doing the same thing but some changes in implementations were done at 2 different times: PR #982 in 2D and PR #1169 in 3D. Because of this, there are some discrepancies in the order of the code or in the use of keywords that makes it hard to compare between 2D and 3D.
Linked issues
Fixes #1213

Hi @dyt811, I'm having trouble with the CI here.
2 tests from test_automate_training.py are not passing for python >=3.7.
I did not do any changes in this PR regarding those tests and other PR from yesterday are OK. Any ideas?
All tests are also passing on my laptop (Ubuntu 20.04, python 3.8)

Just a heads up: I re-ran the CI for one of the failed jobs, and it's still failing. I guess we could exclude the case of GHA weird behaviour. @mariehbourget Could you share the output for pip freeze as I'm afraid it could be related to some package release?

Just a heads up: I re-ran the CI for one of the failed jobs, and it's still failing. I guess we could exclude the case of GHA weird behaviour. ~@mariehbourget Could you share the output for pip freeze as I'm afraid it could be related to some package release?~ Let it be... I always forget... I'll check in the successful GHA

Thanks @kanishk16. You're right, it may be due to new dependency releases as some of those tests were OK on Friday (and nothing changed afterwards in the PR).
I'll share the pip freeze of my laptop where the tests are passing on Ubuntu 20.04 python 3.8.
pip freeze
absl-py==1.3.0
alabaster==0.7.12
apeye==1.2.0
astor==0.8.1
attrs==22.1.0
autodocsumm==0.2.9
Babel==2.10.3
beautifulsoup4==4.11.1
bids-validator==1.9.9
CacheControl==0.12.11
cachetools==5.2.0
certifi==2022.9.24
cfgv==3.3.1
changelog==1.0
-e git+https://github.com/neuropoly/changelog.git@0e1ec93b2a8cde8077751d29db9a3ca3818207c5#egg=changelog_neuropoly
charset-normalizer==2.1.1
click==8.1.3
coloredlogs==15.0.1
consolekit==1.4.1
contourpy==1.0.5
coverage==6.5.0
coveralls==3.3.1
cssutils==2.6.0
csv-diff==1.1
cycler==0.11.0
decopatch==1.4.10
Deprecated==1.2.13
deprecation==2.1.0
deprecation-alias==0.3.1
dict2css==0.3.0
dictdiffer==0.9.0
distlib==0.3.6
docker-pycreds==0.4.0
docopt==0.6.2
docutils==0.16
domdf-python-tools==3.5.0
filelock==3.8.0
flake8==5.0.4
flatbuffers==22.10.26
fonttools==4.38.0
formulaic==0.3.4
gitdb==4.0.9
GitPython==3.1.29
google-auth==2.13.0
google-auth-oauthlib==0.4.6
grpcio==1.50.0
html5lib==1.1
humanfriendly==10.0
humanize==4.4.0
identify==2.5.7
idna==3.4
imageio==2.22.2
imagesize==1.4.1
importlib-metadata==5.0.0
iniconfig==1.1.1
interface-meta==1.3.0
-e git+https://github.com/ivadomed/ivadomed.git@d6385f1c57b7433a57003167c215f2288db3b631#egg=ivadomed
Jinja2==3.1.2
joblib==1.2.0
jsonpointer==2.3
kiwisolver==1.4.4
lockfile==0.12.2
loguru==0.6.0
makefun==1.15.0
Markdown==3.4.1
MarkupSafe==2.1.1
matplotlib==3.6.0
mccabe==0.7.0
mistletoe==0.9.0
mpmath==1.2.1
msgpack==1.0.4
natsort==8.2.0
networkx==2.8.7
nibabel==3.2.2
nodeenv==1.7.0
num2words==0.5.12
numpy==1.23.4
oauthlib==3.2.2
onnxruntime==1.13.1
packaging==21.3
pandas==1.4.4
pathtools==0.1.2
Pillow==9.2.0
pkg_resources==0.0.0
platformdirs==2.5.2
pluggy==1.0.0
pre-commit==2.20.0
promise==2.3
protobuf==3.19.6
psutil==5.9.3
py==1.11.0
pyasn1==0.4.8
pyasn1-modules==0.2.8
pybids==0.15.5
pycodestyle==2.9.1
pyflakes==2.5.0
Pygments==2.13.0
pypandoc==1.9
pyparsing==2.4.7
pytest==6.2.5
pytest-cases==3.6.13
pytest-console-scripts==1.3.1
pytest-cov==4.0.0
pytest-ordering==0.6
python-dateutil==2.8.2
pytz==2022.5
PyWavelets==1.4.1
PyYAML==6.0
requests==2.28.1
requests-oauthlib==1.3.1
rsa==4.9
ruamel.yaml==0.17.21
ruamel.yaml.clib==0.2.7
scikit-image==0.19.3
scikit-learn==1.1.3
scipy==1.9.3
seaborn==0.12.1
sentry-sdk==1.10.1
setproctitle==1.3.2
shortuuid==1.0.9
SimpleITK==2.2.0
six==1.16.0
smmap==5.0.0
snowballstemmer==2.2.0
soupsieve==2.3.2.post1
Sphinx==4.3.2
sphinx-autodoc-typehints==1.11.1
sphinx-jsonschema==1.19.1
sphinx-prompt==1.5.0
sphinx-rtd-theme==1.0.0
sphinx-tabs==3.2.0
sphinx-toolbox==2.15.2
sphinxcontrib-applehelp==1.0.2
sphinxcontrib-devhelp==1.0.2
sphinxcontrib-htmlhelp==2.0.0
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-qthelp==1.0.3
sphinxcontrib-serializinghtml==1.1.5
SQLAlchemy==1.3.24
sympy==1.11.1
tabulate==0.9.0
tensorboard==2.10.1
tensorboard-data-server==0.6.1
tensorboard-plugin-wit==1.8.1
threadpoolctl==3.1.0
tifffile==2022.10.10
toml==0.10.2
tomli==2.0.1
torch==1.11.0
torchio==0.18.84
torchvision==0.12.0
tqdm==4.64.1
typing_extensions==4.4.0
urllib3==1.26.12
virtualenv==20.16.6
wandb==0.13.4
webencodings==0.5.1
Werkzeug==2.2.2
wrapt==1.14.1
zipp==3.10.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+5.6%) to 74.552%

Totals

Change from base Build<PHONE_NUMBER>:
5.6%

Covered Lines:
4614

Relevant Lines:
6189

💛  - Coveralls


Counterpoint

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master     #3    +/-   ##
======================================
  Coverage     100%   100%
======================================
  Files           5      9     +4
  Lines         293    502   +209
  Branches       29     71    +42
======================================
+ Hits          293    502   +209

Impacted Files
Coverage Δ

rlmusician/agent/crossentropy.py
100% <100%> (ø)
:arrow_up:

rlmusician/agent/agent.py
100% <100%> (ø)

rlmusician/environment/evaluation.py
100% <100%> (ø)

rlmusician/utils/music_theory.py
100% <100%> (ø)

rlmusician/utils/misc.py
100% <100%> (ø)
:arrow_up:

rlmusician/environment/environment.py
100% <100%> (ø)
:arrow_up:

rlmusician/environment/piece.py
100% <100%> (ø)

rlmusician/agent/actor_model.py
100% <100%> (ø)

rlmusician/utils/io.py
100% <100%> (ø)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec0d0fc...1181bd9. Read the comment docs.


rename date_adopted to adopted_at

Solution
Enable heroku to run migration  (rake db:migrate)
Important files

create Procfile
release-tasks.sh


ffmpeg: Patch for compatibility with 10.12 AVFoundation

Description of changes
This patch conflicts mildly with #322724, if that is merged first this one should be updated not to disable AVFoundation, if this is merged first that PR should be updated not to introduce the disabling.
The vendored patch can be dropped as soon as we start building ffmpeg against a newer SDK but the effort to make it compatible with 10.12 was very minor.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Do you have any plans to try upstreaming this to FFmpeg or would you prefer someone else brave the rapids?

Maybe we should follow suit :')

For clarity the failures on ffmpeg_7-full are expected. That requires more fixes.


unstable addition of facts via owlToRulesConverter.addOntology

For some reason facts are ignored when loading a TTL from file via OWL API ontology manager. For instance a larger test file is loaded while a smaller fraction thereof (first 8 lines) is not.
public class LoadTripples {

	public static void main(final String[] args) throws OWLOntologyCreationException, IOException {

		/* load ABox using OWL API */
		final OWLOntologyManager ontologyManager = OWLManager.createOWLOntologyManager();
		final OWLOntology abox = ontologyManager
				.loadOntologyFromOntologyDocument(new File("small.ttl"));

		final OwlToRulesConverter owlToRulesConverter = new OwlToRulesConverter();
		owlToRulesConverter.addOntology(abox);

		System.out.println("Nbr of facts: " + owlToRulesConverter.getFacts().size());

	}
}

Test data is attached. vlog4j version as of Aug. 29.

large.ttl.zip
small.ttl.zip

This is not a bug. File large.ttl contains declaration <http://www.foo.com/test#is-made-of> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://www.w3.org/2002/07/owl#ObjectProperty> ., which is missing from small.ttl. If axiom properties are not declared, OWL API interprets axioms with these properties as Annotation Assertions.  vlog4j-owlapi only transforms Property Assertions to facts.
`public class LoadTripples {
public static void main(final String[] args) throws OWLOntologyCreationException, IOException {

	/* load ABox using OWL API */
	final OWLOntologyManager ontologyManager = OWLManager.createOWLOntologyManager();
	final OWLOntology abox = ontologyManager.loadOntologyFromOntologyDocument(new File("resources/small.ttl"));

	final OwlToRulesConverter owlToRulesConverter = new OwlToRulesConverter();
	owlToRulesConverter.addOntology(abox);

	System.out.println("Nbr of facts: " + owlToRulesConverter.getFacts().size());

	System.out.println("Nbr of abox axioms: " + abox.aboxAxioms(Imports.EXCLUDED).count());

	System.out.println("Nbr of axioms: " + abox.getAxiomCount());

	final Set<AxiomType> types = new HashSet<AxiomType>();
	abox.axioms().forEach(axiom -> types.add(axiom.getAxiomType()));

	System.out.println("Axiom types: " + types);

}

}`

Ok, I see. I need to have schema information about the property types in my ABox.
I want to propose a pure TTL import function that just reads triples.


Add badges to README.md

Add necessary badges like MIT license, number of stars, number of forks, etc to this repo. You can create badges from https://shields.io/category/license
Make sure the badges are eye catching :)

Closing this issue as it has been resolved in this commit --> https://github.com/shadmankhan/YoutubeBot/commit/3919a68e3501211430611a4d22c64756c37f80c2


Update lit_gpt commit to PyTorch 2.2

The PR's primary purpose is updating lit-gpt's commit to a PyTorch 2.2 commit. This also comes with a few other things:

Removes building of flash_attn resulting in more reliable lit-gpt image builds.
Removes Lightning.Trainer in favor of Lightning.Fabric (provided by the lit-gpt openwebtext sample)
Refactors most of the nsight workflow into a separate Callback class.
Updates the base image to 24.01, which comes bundled with PyTorch 2.2, and NCCL 2.19.
Updates the ncclPlugin and rxdmContainer versions
Adds volume mount for /data onto the host which prevents re-downloading the dataset on subsequent runs.

Mostly LGTM. In addition to my comments, two things:

From this PR it looks like we are adjusting this example to run Llama-2-13B instead of Llama-2-70B. Just want to double check this is intentional
Could you attach some link (using short-gen) where you are able to run this workload?

Good catch on 13B, I was using it to experiment.

https://pastebin.com/1iKLXCMf, added to description.


Add extraction schema support to EC3 clients

Updated interfaces and clients to support Carbon Calculation API extraction schema.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Don't forget to bump the minor version and fill out the Changelog.md


Add recvmmsg & sendmmsg syscall number for loongarch64

Motivation:
Call correct recvmmsg and sendmmsg on loongarch64.
Modification:
Add #elif declarations to ensure we pick the correct syscall number for loongarch64.
Result:
Pick the correct syscall number depending on the system architecture.

@zhaixiaojuan can you please sign our icla and let me know once done: https://netty.io/s/icla

Why aren't those values available from the #include <sys/syscall.h>, though?
I thought those defines are only for compiling on old kernels and glitch's.

@chrisvest they are... but I think even for loongarch64 the same problem with old GLIBC / Kernel etc exists, no ?

Maybe, but loongarch64 is pretty new, so I wonder why it needs this when there is no equivalent for ARM. Perhaps ARM also has this problem and we just don't use these functions there?

@zhaixiaojuan can you please sign our icla and let me know once done: https://netty.io/s/icla

@normanmaurer I have signed icla.

I have loongarch64 PR at Brotli4j also but I'm confused about whether to merge or not. The architecture is very new and very few distros support it. Tools and documentation are below average quality.
What are your take guys? Should we really support this in Java or we should wait for it to become more mature?

I have loongarch64 PR at Brotli4j also but I'm confused about whether to merge or not. The architecture is very new and very few distros support it. Tools and documentation are below average quality.
What are your take guys? Should we really support this in Java or we should wait for it to become more mature?

The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.
Documentations:
ISA: https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html
ABI: https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html
More docs can be found at: https://loongson.github.io/LoongArch-Documentation/README-EN.html
At present, the debian community has begun to support the loongarch64 architecture (https://wiki.debian.org/Ports/loong64), and communities including golang, llvm, and glibc have received loongarch64-related PRs. Although loongarch64 is a new architecture, it is currently used by a growing number of customers. It will be convenient for people to use after being merged.
I think that all architectures are evolving, and even for some mature architectures, there may be some changes.


cleanup energy functions

A bit more consistent way to compute various total energy contributions

Hi @simonpintarelli ! I think I might have broken the NLCG interface. Now I remember that the energy functions were moved out of DFT_ground_state class deliberatlely. Can you add the build of NLCGLIB to our github actions such that SIRIUS is compiled with it. So that I know if my changes are harmful or not.


Re-add ABAC deprecation status note

This was handled in the past:
https://github.com/kubernetes/website/issues/13021
https://github.com/kubernetes/website/pull/13067/files
But the current page does not mention this:
https://kubernetes.io/docs/reference/access-authn-authz/abac/
So I have added back that note.

To check EasyCLA
/easycla

There are no plans to deprecate ABAC at this moment, So the current content is correct.
the previous PR for the deprecation of ABAC was already closed: https://github.com/kubernetes/kubernetes/pull/82540
PTAL

/sig auth

@Shubham82 got it, thanks for explaining.


Color of slide number affected by background-image

When using a background-image within a slide, the color of the slide number is somehow affected. Here is an example using green text color on white background:

White becomes somewhat greyish and all other colours also become darker.
.remark-slide-number {
  color: green;
  background-color: white;
}

@pat-s, can you point us at a specific (complete) example?

@tripu I am using this implementation of remark.js.
Using a custom css file, I can modify remark.js classes. Since the xaringan implementation is not pure remark.js but uses R in the background, I can only talk about the css class modifications and not provide a complete example (as it would not be executable by you).
As mentioned above, I modified the .remark-slide-number class. Furthermore I use a layout to apply the background image:
layout: true

background-image: url(img/FSU/4-3/layout_4-3.png)
background-size: cover

This background image contains a blue bar as footer. When drawing both the slide number and the background-image, the weird colouring appears.
Here is the complete modification of .remark-slide-number:
.remark-slide-number {
  color: green;
  background-color: white;
  margin-bottom: -11.6px;
  margin-right: 20px;
  border-radius: 0px;
  padding: 1.6px;
}

@pat-s: sorry, I don't understand. You are forcing that style (green on white) for the slide numbers yourself using CSS, right? What is the issue, then?
See this pen. The first slide has a background image, and the slide number at the bottom is still shown in grey over a transparent background.
Can you reproduce the issue by forking this pen?

(Nothing like reading things twice :smirk:)
I think I understand now.
.remark-slide-number has an opacity of 50% by default. Colours there will be mixed with whatever is in the background (in your case, white in the background and green for the font).
Make sure you override that opacity if you need to.

Thanks for pointing me to remark.less and opacity! That fixed it.
Exhausting finding the defaults of all classes. :relieved:


Error: Wild type is not consistent with the sequence at the mutation location!

hello, I recently encountered this problem when using my own data for testing, what is the cause and how should I correct it?

Hello,
This error occurred inside the function positional_features when running get_features.py to generate features. It was due to that, for a particular sequence in your data, the wild-type amino acid at the mutation location (sequence[mutation_location] in the above function) was not the same as the wild-type reported (the argument wild passed to the function).
For example, the following data will cause this error:

position
wild_type
mutation
...
sequence

3
E
K
...
MEKVYFLR

where the actual wild-type amino acid at the mutation location (3) is K instead of the wild-type reported (E).
Please check if there are any such mismatches in your data.

Thank you for you nice reply, but i have another problem when I use this method, it suggested that I was missing files in the data path. After checking, I found that there were no such files, nor did they exist in github. Do you have any suggestions ?

Traceback (most recent call last):
File "eval.py", line 39, in
data.append(generate_one_vector(chain, loc, wild, mutant))
File "CTR/get_features.py", line 278, in generate_one_vector
mean = pd.read_csv(args.mean).to_numpy().flatten()
FileNotFoundError: [Errno 2] No such file or directory: 'data/mean.csv'

Hello,
After generating features (features.csv), get_features.py also calculates the mean and std values of the features and writes them to files that are, by default, located in the same folder as features.csv. You can check rawdata_config.py for path configuration.
From the error message, it seems that you have not successfully run get_features.py prior to running eval.py. Therefore,  before evaluating your dataset, please run get_features.py first, as this will generate features.csv, mean.csv, and std.csv.


Release version 1.0.0

[x] use SDK 0.23.1
[x] use 1.0.0 in WASM module source code
[x] use 1.0.0 in MSFS2020 project manifest

I accidentally pushed to main, it was not protected - I added the branch protection too


Can't copy the mnemonic when creating a new Wallet.

Please provide a way to copy the mnemonic.
This is just a test wallet =P

Yes I know, but this is useless when you want to copy and paste in another document, for example.
I think you should provide this feature and ask the user to confirm.

@sandro-csimas this is a common feature for other wallets/applications that use mnemonic phrases, making the user to be aware of the importance of recording the phrase by hand, either by writing it down on paper or typing it out in a word document.

@pbp8ntballer, I know it's common feature, but all the wallets I used until now provided a way to copy the entire mnemonic. I'm used to copy the entire mnemonic and save it to a encrypted file with password. I think the process of write by hand into a file and copy (faster) will have the same result here as you can't copy the mnemonic by half. I'm my opinion you can remind the importance of this by displaying a confirmation alert.
Anyway, just my opinion, feel free to close the issue! =P


Read multiple records from json file

With the below code, I can read the json file and assign it to the struct member, only if it is of 1 record,
let u: User = serde_json::from_reader(file)?;
How can I handle multiple records, is there a way that I can use it to read all the records at once, something like:
let records = xxx
for record in records {...}

There is, check out serde_json::StreamDeserializer.

Just wanted to mention that this also allows parsing of jsonl files (since this information is very hard to find anywhere else)


Add the about menu

Add an item to the menu that contains information about the current version and links to github.

Available in 1.1.6


Kernings lost in \mathrm and friends

Description
Kernings are lost in \mathrm and friends. According to David Carlisle in his answer:

\mathrm \mathit and friends are designed to allow multi-letter identifiers so use the same kerning and ligatures as the text fonts…

Check/indicate

[x] Relevant for XeTeX
[x] Relevant for LuaTeX
[x] Issue tracker has been searched for similar issues?

Minimal example demonstrating the issue
\documentclass{article}
%\usepackage{newtxtext}
%\usepackage{newtxmath}
\usepackage{fontspec}
\setmainfont{texgyretermes-regular.otf}
\setsansfont{texgyreheros-regular.otf}
\begin{document}
\noindent
Test $\mathrm{VAR}_p(X)$\\
Test VAR$_p(X)$\\
\sffamily
Test $\mathsf{VAR}_p(X)$\\
Test VAR$_p(X)$
\end{document}

Further details
For some reasons I cannot run LuaLaTeX, but I suspect the same issue exists.
Here is the result with fontspec under XeLaTeX or LuaLaTeX:

And here is the result with TFM-based newtxtext and newtxmath under XeLaTeX or LuaLaTeX:

Hmmm. These examples are always tricky as the LaTeX wrappers around the TeX primitives in one sense hide a lot of the detail. I’ll try to develop a plain TeX example to show the same thing. This could be something that fontspec can’t do anything about...

@wspr I just confirmed the same issue of missing kerning under LuaLaTeX.
This is very likely a bug introduced by recent versions of fontspec because I remembered having a lot of VAR in my documents but only today I started to notice the missing kerning (I could be wrong though!)

@wspr Ligatures are lost too (sorry for the multiple postings):
\documentclass{article}
\usepackage{fontspec}
\setmainfont{texgyretermes-regular.otf}
\begin{document}
\noindent
Test $\mathrm{VARfi}_p(X)$\\
Test VARfi$_p(X)$
\end{document}

Looks like I didn’t search hard enough: See Ligatures are not used in OpenType maths families? Seems to be an engine problem :(
@wspr Please feel free to close this issue if you deemed this to be out of the scope of fontspec.

Perhaps the best thing fontspec can do is mentioning this somewhere in the documentation? There is nothing to do under XeTeX, so I am resorting to
\DeclareMathOperator\VARfi{V\kern-0.125emAR\char"FB01 }

Ugly, but at least usable.

Consider the solution given by @u-fischer in https://tex.stackexchange.com/a/277395?

@stone-zeng Ulrike Fischer’s solution had one oversight: One must also pass any other OpenType features in addition to Renderer=Basic. XeLaTeX does not need this extra step and works out of the box (well, except for kerning, ligatures, etc.).
\documentclass{article}

\usepackage{amsopn}% For \DeclareMathOperator
\usepackage{fontspec}
\setmainfont{SourceSansPro-Regular.otf}[
  StylisticSet=2
  % Single-story lowercase a and straight-terminal lowercase l
]
\DeclareMathOperator\Stable{Stable}
\DeclareMathOperator\Var{Var}

\makeatletter
\ifx\XeTeXversion\@undefined
  % Modified from Ulrike Fischer
  \newfontfamily\SourceSansProOperator{SourceSansPro-Regular.otf}[
    Renderer=Basic,
    % Any additional OpenType features must be manually specified:
    StylisticSet=2
  ]
  \AtBeginDocument{%
    \SourceSansProOperator
    \DeclareSymbolFont{operators}\encodingdefault\f@family\mddefault\updefault
    \normalfont
  }
\fi
\makeatother

\begin{document}
A stable distribution is denoted\\
by $\Stable(\alpha,\beta,\gamma,\delta)$. The variance\\
of a stable random variable~$X$ is\\
$\Var(X)=\infty$ for $1\le\alpha<2$.
\end{document}


Row selection: ngModel is not defined.

Throws an error in the console even though I have an ng-model defined:
<table md-table md-row-select multiple ng-model="selected" md-progress="promise">

Same my problem.Please give me a reson.

What is the error?

I can not display select,it show ngModel is undefine?
Vào 20:58 T.5, 31 Th3 2016 Daniel Nagy<EMAIL_ADDRESS>viết:

What is the error?
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/daniel-nagy/md-data-table/issues/343#issuecomment-203952541

When I press F12,it show error like this
Row selection: ngModel is not defined

How to show select checkbox??? I tried but not working

In you controller you need to define the model, so if you have
<table md-table md-row-select multiple ng-model="selected" md-progress="promise">

In you controller you will need to define selected.
$scope.selected = [];

Why?? I am working with angular-formly,it seem like bad solution for angular-formly

I don't know why it not working??I tried define selected but it not resolve my problem

Why?? I am working with angular-formly,it seem like bad solution for angular-firmly

Otherwise two-way data binding will not work, i.e. you will not be able to access the selected items from your controller.

I don't know why it not working??I tried define selected but it not resolve my problem

You're either going to need to reproduce the error in a Codepen or provide more information for me to help.

OK,i will show you soon

Wait me 1 hour

Now you can see
http://codepen.io/duykhanhbkk57/pen/xVLvPz

@khanhdd123 because you're using formly, you will need to define any variables you want the table to see in the scope of formly. I've updated you Codepen

Can you explain for me??What is I need to define??

How do I use key in angular formly as ng-model like this : ng-model="model[options.key]"

I got same error Row selection: ngModel is not defined. Using angular1.5

Me, too. Using angular 1.4.7

Same error Row selection: ngModel is not defined. Using angular 1.5 and Angular material 1.1.0

I had this problem as well but the solution was to initialize the ng-model variable to an empty array.
As @daniel-nagy said, in your controller you have to define the ng-model variable:
$scope.selected = [];
If you are using a variable such as vm.selectedRow then in your controller you will need:
vm.selectedRow = [];.
If you only define vm.selectedRow; in the controller and don't make it an empty array, it will give you the Row selection: ngModel is not defined error.

I also have the same issue. Everything was fine and table was displaying correctly. I inculded "ui.router" instead of ngRoute and there after it starts showing the above error. Any idea???


Book a demo: copy update

Description
The current copy was created aligned to the previous messaging, this PR updates it to better align it with the current one.
Related Issue(s)

Checklist

[x] I have read the contribution guidelines
[x] I have considered the performance impact of these changes
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

suggest text that focuses more what you get if you book a call.

@Yndira-E Can we get the description to span the same length as the sub title?

Can we get the description to span the same length as the sub title?

Done! (I was already on it 😉)


make sure omitted terms in ontology mapping are discoverescase-sensitive

currently, "unknown" is the correct identifier for unknown ontology entries. as matching of these was not done case-sensitive, the term "Unknown" was skipped when the ontology mapping tsv was created. this led to an error when loading the dataset.

@davidsebfischer FYI


deep review and redesign of API for work queue functionality

As requested by @andrewboie here and rephrasing this comment:
As demonstrated in #23132 although k_delayed_work_cancel() is documented to return -EALREADY if the work item has been completed, it actually returns it if the work item has already been submitted.
I'm skeptical of the whole k_work implementation.  I'm seeing at least nine distinct states for a work item that is not cancelled:

unsubmitted
delayed on timeout
timeout expired, not yet added to queue
marked pending but not on queue
on queue
removed from queue
cleared pending
invoking handler
complete

Most of these can't be inferred by inspecting the state.
Somebody should take the time to go through the whole k_work API and implementation and revise it so the documentation accurately describes the behavior and the functionality is useful.  By "useful" I mean that after an attempt to cancel you should always be able to tell whether the item was:

submitted but not yet committed to processing (delayed or on queue): can be cancelled, 0
processing (including committed to processing, not yet in handler): cannot be cancelled, now -EINVAL  preferably -EINPROGRESS
complete (which may be indistinguishable from unsubmitted): too late to cancel, now -EALREADY preferably -EINVAL

This capability should be present whether the item is a standard work item, a delayed work item, or a pollable work item.

@andrewboie @andyross I plan to start on this later this week.  If it's something you'd like done in-house at Intel instead please reply here.


Update api.lua

Require server privs to access digicomputer until sandboxing in place.

Change to only allow those with "server" privs to access digicomputers to keep normal players from accessing or modifying authentication files. Only needed until it can be further sandboxed.

Hmmm. This isn't a bad idea. Right now it is possible for computers to break out of the filesystem, which is seriously problematic. It would be better, though, to register a computer privilege or something similar in the module's init.lua though, as the server privilege is very general.
Could you also make your commit message more descriptive and separate the if statements into multiple lines?
An example commit message that might be better:
Require computer privilege to use computers

A short description explaining why could also be good too.
On on unrelated note, I've lately been considering creating an abstract filesystem of sorts based off of node meta, not sure though.


Closing maximized window shouldn't set window size

Is your feature request related to a problem? Please describe.
Related to issue 110.  Per that issue's discussion, my understanding is that this issue is specific to Linux.
Closing a maximized window in development release 1.0.3 sets the window size for future launches to be the size of the screen.  I'm guessing this behavior was probably added as a try at keeping a window maximized in 1.x, but with the fix made in 1.0.3, this behavior is no longer needed and, in my opinion, is undesirable.
Describe the solution you'd like
It would be nice if closing a maximized window didn't set the window size.  Try these two things and see the difference between them:

open 1.0.3
make the window size somewhat small
maximize it
restore it down

At this point, the window size is the "somewhat small" size you had it at before.  This is good.  Now, try this instead:

maximize it
close it
reopen it
restore it down

At this point, the window is the same size as a maximized window, though it isn't maximized.  It would be nice if, at this point, the window size still went back to the "somewhat small" size from before.
My guess is that making this change would involve only 1 or 2 changes in the code, but if it turns out to be a very involved process, this certainly isn't a super-high-priority thing worth refactoring all your code over.

Hi @samuelznewton. Can you check the reuploaded 1.0.3 if this works like expected?
https://github.com/ransome1/sleek/releases/tag/v1.0.3

Yes, that's got it!  Thank you so much!


Hide skills from dropdown when they've been added, and validate form input.

Closing because this has unwanted a11y commits. Replaced with pull request #446.


code for other datasets?

Hi,
Thanks for your code.
Do you mind sharing the code for other datasets like KONIQ, TID2013 etc.?
Because we cannot reproduce the performance you reported in the paper.
Thanks

Hi, in our process.py file, we split the dataset for training and teseting. It is important to split the data by conent.

Yes, due to some reasons, I can not share other datasets code. But now, I will release these code and checkpoints！


Added a postgresql data import script

Not sure if you want to provide data-import scripts, but this one will work for PostgreSQL for those that want to use the database.

Hi Evan. Generally speaking, since this repo is just data, we don't accept pull requests. That said, we appreciate your interest and efforts and are looking for the best way to incorporate your scripts into our initiate. Thanks.
Ethan
Cleveland Museum of Art


Question about the output of the model

The output of the model is the animated gif or there is the possibility to get the bone o junction positioning?
So for example if I use my image can I put the junction on it and after that animate the image?
Thank you.

Hi, I don't understand exactly what you mean.
To animate the image you need to provide the keypoint positions of your animation. We do this by simply interpolating the keypoints between some images but all you really need is a series of different keypoint positions.


uploadObject method not working

It seems it's converting the body/file and causing error 504

We had this issue using the ObjectsApi#uploadObject method. The issue was related with line #137 on ApiClient file, trying to convert the body(file) to JSON.

I encountered the same problem. The documentation specify passing the file path to the uploadObject() function. When you do this, it does not attempt to json_encode it in line 136, since it's a string, but the upload times out with a 504 response, since the specified payload size is bigger than the actual content sent. The work around I implemented was changing line #196  from:
curl_setopt($curl, CURLOPT_POSTFIELDS, $postData);
to:
curl_setopt($curl, CURLOPT_POSTFIELDS, file_get_contents($postData));

@MelleDijkstra If you are still using this ;)
It seems it is just the parameter suggestion in the docblock is wrong, uploadObject does not need a SplFileObject but just the file content is fine.

@tuimz Ahh, so a patch wasn't actually needed just pass file_get_contents() straight into the function. well... the patch works anyways 😋. Thanks!

Hi @augustogoncalves I have submitted a PR wich resolves this issue. Could you take a look?

@tuimz  Thanks for your PRs, I will help Augusto to maintain the SDK, I am checking your PR but my access seems not enough to approve that, working on that now.

This bug is still present... I also had to insert following lines to get rid of a http 504 error:
        curl_setopt($curl, CURLOPT_FORBID_REUSE, 1);
        curl_setopt($curl, CURLOPT_ENCODING , "");

The 504 problem still occurs, how can I solve it?


Warlock sim way off

In raid I have 7-8K. If I use that gear and start sim it shows 2K . Don't have that problem with the mage sim or DK sim.
As far as I member that was not the case before, it seems something has changed.

Hey @Apx2023 👋 can you double check your settings, talents, and rotation to make sure everything is set to demo? I see you have warnings below the sim results. A link to your setup would also be really helpful


Errors on app.js when component name is incorrect

Solving on v3, which must be released in a few weeks. An alpha version must be out on at maximum a week.


[Enhancement] (nereids)implement CreateRoleCommand in nereids

What problem does this PR solve?
Issue Number: close #42597
Related PR: #xxx
Problem Summary:
implement CreateRoleCommand in nereids
Release note
None
Check List (For Author)

Test

[X] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall


fix: remove extra comments

I ran into an issue with this extra ants flag and hoping to resolve the comment issue so #999 can be merged

oops, looks like the rebase needs to take place on your end, going to reset

Sorry about this - never saw the comment on my earlier PR or would have happily sorted it on my own. Thanks for cleaning up!


Create scripts for bootstrapping the env

Implements https://github.com/Skyscanner/argocd-progressive-rollout/issues/28
It is not invoked via make file for now, I feel that the makefile is full of targets atm making it a bit difficult to follow, but I can add it there and update the readme accordingly if that'd be preffered.

Had a chat with @nebojsa-prodana about having a style guide since bash can very (too?) opinionated. We thought about using:

https://google.github.io/styleguide/shellguide.html for code style
https://pkg.go.dev/mvdan.cc/sh/v3 for formatting
https://www.shellcheck.net/ for static analysis

We should probably add a couple of github actions for shell as well

For the record, ran this in 5.10.19-1-MANJARO and these were my notes:

go and kubectl are pre-requisites to these scripts;
~/go/bin didn't exist on my system (freshly installed Go through AUR);
curl didn't have permissions to download the argocd CLI into /usr/local/bin in my system - this could be related to my specific installation, and is not a problem on my OSX;
I had to run export PATH=$PATH:$(go env GOPATH)/bin (temporary solution, but I'll add it permanently) to get zsh to find the kind command.

Those are minor things that are mostly user-action and we don't need to solve them all. The main logic worked as expected.


Edits to localization-overview.md

Edited to prepare for being featured in social media.

Acrolinx Scorecards
A minimum total score of 80 is required.
Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.

Article
Total score(Required: 80)
Words + phrases(Brand, terms)
Correctness(Spelling, grammar)
Clarity(Readability)

:white_check_mark: globalization/localization/localization-overview.md
79
100
88
48

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

Acrolinx Scorecards
A minimum total score of 80 is required.
Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.

Article
Total score(Required: 80)
Words + phrases(Brand, terms)
Correctness(Spelling, grammar)
Clarity(Readability)

:white_check_mark: globalization/localization/localization-overview.md
79
100
88
48

:white_check_mark: globalization/localization/localize-software.md
84
100
100
65

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

Acrolinx Scorecards
A minimum total score of 80 is required.
Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.

Article
Total score(Required: 80)
Words + phrases(Brand, terms)
Correctness(Spelling, grammar)
Clarity(Readability)

:white_check_mark: globalization/localization/localization-overview.md
79
100
88
48

:white_check_mark: globalization/localization/localize-software.md
84
100
100
65

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx


Depfile parser

Now with updated tests, new test for escaped spaces, and string instead of std::string.

Any thoughts on avoiding the separate unescape step?
(See the HACKING file for one way to look at performance-related impact.)

In graph.cc line 243 you can change the string creation to be “by reference”:
string& path = *i;

This eliminates a string copy per dependency — the unescape function does a string creation, but prior to b0dc14e there already was a string creation in line 243 of graph.cc — so except for the target path, with the above change we haven’t introduced extra copies compared to before my commits.
As for doing the parsing/unescaping as one-pass: The re2c code generated seems to be backtracking, so it’s not safe to remove the escapes in-place — one could hand-roll a parser that does the unescaping (fairly simple) and works exclusively with StringPiece.
Though I’d like to add that I feel the current way the source obtains performance is blurring memory ownership and responsibility and will hurt long-term maintainability of the source.
Writing the parser should be a pretty self-contained task but I had to read and fully understand a few other things to be sure I got things right:

The StringPiece class, as it’s paramount to understand that it only stores memory references, even when given a std::string (which are often introduced as local variables).
The call-site of the parser to learn if:

the lifetime of the parser instance extends beyond the content string passed to it (since we use StringPiece with that content)
anyone copies the parser’s member data w/o doing a “deep” copy (i.e. convert to std::string) and if so, if that lives longer than the parser / content string.

So despite having the parser in a separate class in a separate file, we really need global knowledge to write it and also to use it.
I hope you take the above as friendly advice — overall ninja is a great piece of software, and I just want to see the code not deteriorate to a Chinese game of pickup sticks :)

Yes, my behavior around memory leaves a bit to be desired.  :(
But it has a reason -- I brought in StringPiece for performance benefits after code that made more copies worked.  (See the comments on the top of the class for a description of how its memory management is external.  I know it's a bit weird but it's a common class used within Google code, including Chrome.)
I'm ok with needing somewhat of a global picture as long as the total picture remains small.
I think my ideal end state would be something like:

all files we read are either mmap()ed or allocated for the lifetime of the ninja processes
all paths are pointers into that memory
all allocations of graph state (Node/Edge objects) are arena-allocated.  (Currently they are allocated and leaked, but we could save some cost by making that more explicit with an arena)

In practice, none of this is too urgent, as Ninja is already "fast enough", and I don't like making optimization changes without a profiler telling me first that they will be helpful.  But the reasons for the current hacks are due to it not being fast enough in the past, so I'm eager to at least not regress.
So I guess my final point is: whatever you think is cleanest is fine, as long as you can demonstrate that it doesn't regress performance.

For reference, did a build of Chrome's base_unittests executable.  Here's the top of the gperf output (Google's pprof is better, but I'm using a busted laptop at the moment):
Each sample counts as 0.01 seconds.
  %   cumulative   self              self     total
 time   seconds   seconds    calls  ms/call  ms/call  name
 28.57      0.02     0.02    92527     0.00     0.00  State::LookupNode(std::string const&)
 14.29      0.03     0.01   167884     0.00     0.00  Tokenizer::SkipWhitespace(bool)
 14.29      0.04     0.01    92527     0.00     0.00  CanonicalizePath(std::string*, std::string*)
 14.29      0.05     0.01    28988     0.00     0.00  __gnu_cxx::hashtable<std::pair<char const* const, Node*>, char const*, ExternalStringHash, std::_Select1st<std::pair<char const* const, Node*> >, ExternalStringEq, std::allocator<Node*> >::resize(unsigned long)
 14.29      0.06     0.01    24150     0.00     0.00  UnescapePath(char const*, unsigned long, char const*)
 14.29      0.07     0.01     3589     0.00     0.00  Tokenizer::ReadToNewline(std::string*, std::string*, unsigned long)

What could be done is drop my commits and then after re2c has parsed the Makefile, iterate the paths and at that time remove slashes (in-place).
Since most paths will have no slashes, this should probably add very little overhead to the parser.
I must confess I’m not overly motivated to make this change myself: My problem was with a bug that is now fixed. If my fix is considered to introduce a “performance bug” I think it should be dealt with by rewriting the parser as you outlined, i.e. mmap the entire Makefile and do a one-pass of that using StringPiece and in-place removel of slashes — I think the code would be cleaner and also more effecient than iterating on the current solution.

Ok, thanks for talking through this with me!  I will apply your re2c patch immediately (since it's obviously correct) and work on the spaces-in-filenames issue separately.

btw: your profiling doesn’t account for the “moving” of the string creation from line 243 of graph.cc to UnescapePath (assuming you made it a reference as suggested in my previous comment) — so should look at total time to see how my commits have impacted performance.

Thanks — I’ve downloaded the Chrome build files and I see there are ~50 MB of dependency information (to parse), so I may take a stab at writing a faster parser (though will be busy / travelling soon, so probably after that).
I’m very curious though, with > 30.000 dependencies (gathered from these files), isn’t stat’ing all those files magnitudes slower than parsing out the path for each of them?
Each file does appear to be there ~20 times though, so I guess it’s ~20 × (UnescapePath + CanonicalizePath) per stat.

At least on Linux, stat is very fast.  On Windows the story with stat() is really different. :(
Here's an older discussion about stats on Windows:  https://groups.google.com/group/ninja-build/browse_thread/thread/bb5a37ad165621c0/b9c4a18a16789bdd?lnk=gst&q=stats#b9c4a18a16789bdd
Not sure about Mac, haven't had much opportunity to try it. I'd expect it to be somewhere in the middle.
The most similar bit of code to this is CanonicalizePath, which is one of the heaviest functions in (time-based, not CPU-based) profiles.  You are right that it's called multiple times per dep file, and that's why it's so expensive.  Somewhere I collected the relevant stats for this, but I can't find it right now.
The worst dep files are pretty huge, too:
$ find chrome-ninja-files/ -name '*.d' | xargs ls -l | sort -n -k4
[...]
$ wc -l chrome-ninja-files/obj/third_party/WebKit/Source/WebKit/chromium/src/webkit.WebViewImpl.o.d
789 chrome-ninja-files/obj/third_party/WebKit/Source/WebKit/chromium/src/webkit.WebViewImpl.o.d

You can build parser_perftest (you'll have to pull master to make it compile again, it had bit-rotted) to just run the depfile parser instead of all the ninja machinery.
PS: I've been considering an alternative approach that would move all of this parsing cost to build time instead of load time, which could help dramatically:
https://groups.google.com/group/ninja-build/browse_thread/thread/b739c6969a21b129/50b0e8f0f83a1c16

I pushed some commits that appear to resolve this.
The performance is comparable to before.
Old code:
chrome-ninja-files/obj/third_party/WebKit/Source/WebKit/chromium/src/webkit.WebViewImpl.o.d: 68.4us
chrome-ninja-files/obj/third_party/WebKit/Source/WebKit/chromium/src/webkit.WebFrameImpl.o.d: 65.9us
New code:
chrome-ninja-files/obj/third_party/WebKit/Source/WebKit/chromium/src/webkit.WebViewImpl.o.d: 69.3us
chrome-ninja-files/obj/third_party/WebKit/Source/WebKit/chromium/src/webkit.WebFrameImpl.o.d: 66.9us
It appears slower, but hopefully the difference is small enough to be noise.


Restore of configuration backup does not work, archive is not recognized!

Reason:
Something has changed within luci.http interface for file upload form parameters and the test:
local upload = http.formvalue("archive")
if upload and #upload > 0 then

around line 338 in file /usr/lib/lua/luci/controller/admin/system.lua always fails.
Find a simple fix attached. (If the change in luci.http wasn't intentional, maybe that should be fixed instead...)
--- old/system.lua	2018-04-24 11:49:18.416945765 +0200
+++ new/system.lua	2018-04-24 11:49:54.572946373 +0200
@@ -319,6 +319,7 @@
 	local archive_tmp = "/tmp/restore.tar.gz"

 	local fp
+        local found_something = false
 	http.setfilehandler(
 		function(meta, chunk, eof)
 			if not fp and meta and meta.name == "archive" then
@@ -326,6 +327,7 @@
 			end
 			if fp and chunk then
 				fp:write(chunk)
+                                found_something = true
 			end
 			if fp and eof then
 				fp:close()
@@ -338,8 +340,7 @@
 		return
 	end

-	local upload = http.formvalue("archive")
-	if upload and #upload > 0 then
+	if found_something then
 		luci.template.render("admin_system/applyreboot")
 		os.execute("tar -C / -xzf %q >/dev/null 2>&1" % archive_tmp)
 		luci.sys.reboot()

@hnyman : now it's readable... :smiley:


Feature/products back end

I created the migration for the products table with all the necessary keys. I also created the products seed by using a mock data for now. Both the migrations and the seeds were applied successfully.

Thank you guys for reviewing the PR!


fix: there's a comma missing

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   24.42%   24.42%
=======================================
  Files          18       18
  Lines         217      217
=======================================
  Hits           53       53
  Misses        164      164

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c80a30...6d55cd7. Read the comment docs.


Support for documenting Parameters of Senders and Pipes in Frank!Doc

Describe the issue
To be able to document parameters, two javadoc annotations are proposed:

@ff.Parameters: to document the generic behaviour of parameters, like 'every parameter is added as an header to the request'
@ff.Parameter: to document individual parameters, like: 'parameter destination is used as the target for the copy operation'

Reporter
Core team

#2169


vs/editor/common drags in vs/editor/browser

See screenshot:

Related: https://github.com/Microsoft/vscode/issues/8578

@alexandrudima thanks!


Checkout action requirement is missing from the docs

Summary
We started using the action and after a couple of failures that the checkout action is required with fetch-depth: 0 in order for the action properly operate.
I checked the readme again and could not find any reference to that although it is a prerequisite.
I'd be happy to add the missing information myself but I am not sure where would be the right place to do so in the readme. Probably a full action example would be most helpful

Hi @dstrants, thanks for your feedback and your offer to make the update.
The details about this are nuanced, and not every repo will require this to be added. The advice is only to include it if the task returns this as a specific error message.
I've now included details around this in the docs as suggested.


Testsite

Thank you for submitting your data!
Please ensure this checklist is complete before creating the pull request.

[ ] My branch name is the same as my Site_ID
[ ] All of my data files are named <site_ID>_data*.csv
[ ] All columns are present in my data file(s)
[ ] All columns are named properly
[ ] Data are coded according to the data dictionary
[ ] All measures are within the appropriate scales and distribution

To check boxes above, change - [ ] to - [x]

Once you create the pull request, we will automatically check your data files.
If the test fails, you can see the output:

Click Details next to the failed job
Click Run script to view the output of the QC checks

If the QC script fails, we will work with you until your data pass all QC criteria.
To fix any issues that arise:

Correct the data files on your local copy of your forked repo
Add your updated data files to the staging area and commit your changes
Push your local repo to your remote fork

This pull request will automatically update when your forked repo changes.
make sure your changes are on the same branch as the one you used to create this pull request

@dmoracze I tried to check in a test dataset, however, one of the errors is:
parental_education entries need to be one of the following: 1, 2, 3, 777, shouldn't the range be 0,1,2,3?

@nedasadeghi that is a typo in the scripts output, I'll correct that. The criteria is:
        if not educ.isin([0,1,2,3,777]).all():
            errors.append('parental_education entries need to be one of the following: 1, 2, 3, 777')

@nedasadeghi your current data file has the following parental_education breakdown:
parental_education
2    24990
4    23933
3    17668
0     3409

Ok, I fixed the output of the parental education error
        if not educ.isin([0,1,2,3,777]).all():
            errors.append('parental_education entries need to be one of the following: 0, 1, 2, 3, 777')

The check for age is that brain_behavior_measurement_date - dob must equal age. Let me know if that's too strict and you want to put a range of acceptable values.

@dmoracze Yeah, I think it would be good to leave some room. How about plus/minus a month?

Ok, I made that change but your fork is out of data again. Here is the output of the new script checking your current data:
++ Date File Summary:
    Number of rows: 70000
    Number of columns: 19
    Number of correctly names columns: 19
    Number of unique subjects: 10000
    Age column: mean=167.0352, min=83, max=278
    Number of males: 4748
    Number of females: 5252

++ 6 ERRORS FOUND:
    age range is suspect, age(s) outside of 60 - 264 months found
    parental_education entries need to be one of the following: 0, 1, 2, 3, 777
    cbcl_externalizing_raw_score range is suspect, entries should be between 0 and 70
    iq range is suspect, entries should be between the broad range of 0 and 200
    wm_volume entries must all be greater than 0 and less than 1,000,000
    amygdala_volume entries must all be greater than 0 and less than 10,000
++ ----------
++ Finished with errors.
(base) dmoracze@MH02144726MLI SimulationCopy % git pull
remote: Enumerating objects: 15, done.
remote: Counting objects: 100% (14/14), done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 10 (delta 3), reused 9 (delta 2), pack-reused 0
Unpacking objects: 100% (10/10), 10.86 MiB | 8.63 MiB/s, done.
From https://github.com/nedasadeghi/SimulationCopy
   8443270..f0fc664  testsite   -> origin/testsite
Updating 8443270..f0fc664
Fast-forward
 data/testsite/testsite_data1.csv | 140000 +++++++++++++++++++++++++++++++++---------------------------------
 data/testsite/testsite_data2.csv | 140000 +++++++++++++++++++++++++++++++++---------------------------------
 2 files changed, 140000 insertions(+), 140000 deletions(-)
(base) dmoracze@MH02144726MLI SimulationCopy % python tools/check_data.py testsite
++ 2 data files found
++ ---------
++ Checking data file: ./data/testsite/testsite_data1.csv
++ Date File Summary:
    Number of rows: 70000
    Number of columns: 19
    Number of correctly names columns: 19
    Number of unique subjects: 10000
    Age column: mean=167.0352, min=83, max=278
    Number of males: 4748
    Number of females: 5252

++ 1 ERRORS FOUND:
    age range is suspect, age(s) outside of 60 - 264 months found
++ ----------
++ Checking data file: ./data/testsite/testsite_data2.csv
++ Date File Summary:
    Number of rows: 70000
    Number of columns: 19
    Number of correctly names columns: 19
    Number of unique subjects: 10000
    Age column: mean=167.0352, min=83, max=278
    Number of males: 4748
    Number of females: 5252

++ 1 ERRORS FOUND:
    age range is suspect, age(s) outside of 60 - 264 months found
++ ----------
++ Finished with errors.


Docs vercel integration

@jan-osch great feedback. I added a new section to show both. Let me know what you think.


Remove useless dependency to rhino

Describe the improvement
The project is dependent on the Rhino lib but it doesn't seem to be used
Expected behaviour
The lib should import as little lib as possible
Content of this PR
Remove the Rhino dependency
How did you test?
Clone repo
Open in Android Studio
Run unit tests ✅

The rhino dependency was allowing the json-schema-validator library to use the ScriptEngineManager it one of it's classes.
I should spend more time testing to understand what is happening here with those two libraries, but removing the rhino implementation causes a ClassNotFoundException in some cases (my use case was to use a new JsonSchema with more inputs)

@oleksandrsarapulovgl can you take a look at this?


Font in Chome looks very diffrent to the one in  Firefox

What is going on?!

Are you sure it's not a browser cache issue?  This is Chrome 42.0.2311.135 (left) and Firefox Dev Edition 39.0a2 (right) on my machine:

Looks fine on Windows to me. Think it has something to do with my local install of the Google Font on my Linux install...

Fail. This was my local machine. Installed a bolder version of the Google Font with the same name.


DDT does not trace the internal app request time

Intended to tracing, we could not trace and benchmark internal request delays between subsystems

I'm not sure I understand. Do you have an example for what you wanted to see?

In my code, e.g. a util function, I requested another sub-system. I want to calculate the response time of such requests separately to determine the API's bottleneck,

Maybe the profiling panel answers those questions for you?
I'm afraid django-debug-toolbar doesn't help much otherwise, currently. Maybe there's a third party panel you can use or else some other way to instrument the Python code.

I want to contribute. May you share the code documentation? Unfortunately, I did not get it well.

@moghadas76 the only documentation for the project is available at https://django-debug-toolbar.readthedocs.io/en/latest/
Using the GitHub's blame feature can help you identify PR's and issues that caused changes to be made. If you have specific questions, feel free to ask us.

Closing this issue. We can continue the discussion, but it's not really a concern for the DDT in general. If you want to join Jazzband to contribute to the toolbar in a more regular fashion, see jazzband.co.


Build(deps-dev): Bump @storybook/addon-links from 6.4.19 to 6.4.20 (#3256)

Pull request opened by the merge tool on behalf of #3256

Merged in c8222e2dc7e47a1b22d679bd18690e262aa9f349


Modified look of view notes and header

I've updated the look of the Nav bar to use a different GOV.UK Header, and modified the HTML table and buttons on the view notes page to use some of the GOV.UK css classes, to give it a more GOV.UK look. I did remove the GOV.UK breadcrumbs but these can easily stay in if you'd like.

LGTM


fluid-type-validator flow on version bump needs to be more automatic and/or straightforward

See #8649, #8650
After version bump, we need to update package.json files for the new prior version dependency and update typeValidation version.  Otherwise, the next build fails in fluid-type-validator.  For client packages this can take multiple install/build cycles when building from root, as the build will fail early (before all required package.json get updated), and it's a separate step for each other build group.
This probably needs to be better integrated into the version bump flow, such that main stays in a good state at all times.

I think this has been somewhat improved since I filed the issue, closing.


[GitHub] BugFix: Issue 3390 - Update data type for AfterLineItemQuantityChangedEvent::getItems()

1. Why is this change necessary?

Expected behaviour
AfterLineItemQuantityChangedEvent::getItems() should return array of Shopware\Core\Checkout\Cart\LineItem\LineItem or the return type of getItems() should be changed to Array of Arrays.

Actual behaviour
AfterLineItemQuantityChangedEvent::getItems() returns an array of array.

2. What does this change do, exactly?

This change updates the return type of AfterLineItemQuantityChangedEvent::getItems()

3. Describe each step to reproduce the issue or behaviour.

Add a Subscriber for AfterLineItemQuantityChangedEvent.

Subscriber should call AfterLineItemQuantityChangedEvent::getItems()
`class LineItemQuantityChangedSubscriber implements EventSubscriberInterface
{
public static function getSubscribedEvents(): array
{
return [
AfterLineItemQuantityChangedEvent::class => 'onLineItemQuantityChange'
];
}
public function onLineItemQuantityChange(AfterLineItemQuantityChangedEvent $event): void
{
foreach ($event->getItems() as $itemToUpdate) {
$lineItem->getPayload();
}
}
}`

Change Qty in Cart.

Error appears cannot call getPayload() on array

4. Please link to the relevant issues (if any).
Issue - [3390]
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[x] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

🤖 Generated by Copilot at 4f80101
Modified the AfterLineItemQuantityChangedEvent class to include more details about the line items and their quantity changes. This allows event subscribers to access and use more information about the cart changes triggered by the event.

🤖 Generated by Copilot at 4f80101

Change the type of the items property and parameter in the AfterLineItemQuantityChangedEvent class to store additional information about the line items (link, link, link)

Imported from Github. Please see: https://github.com/shopware/shopware/pull/3392

[public] Shopware automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-31347.
This link is only intended for Shopware employees and for internal use only.
[created from NEXT-31347, comment 490498]


BloxStrap Not Opening

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

What problem did you encounter?
System.Net.Http.HttpRequestException: Response status code does not indicate success: 403 (Forbidden).
I tried using the new version of blox straps but its gives me the same thing
Bloxstrap Log
Bloxstrap_20241003T175606Z.log

This is possibly an issue Roblox made by doing something wrong.
Please wait until Roblox themselves fix this issue.
Please search first before doing posts.