Converted to use Wiki Auto Documentation, Appveyor Shared Code and HQRM - Fixes #25

This PR contains the following changes:

Converted AppVeyor build process to use AppVeyor.psm1.
Resolved PSSA violations.
Resolved Readme.md style violations.
Converted Integration Tests to use Test Drive and stop using Invoke-Pester.
Move strings into separate language files.
Added CodeCov support.
Clean up manifest file by removing commented out sections.
Convert Examples to pass tests and meet minimum standards.
Convert to Wiki and auto-documentation generation.
Convert to TestHarness test execution method.

This change is

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@c3025f0). Click here to learn what that means.
The diff coverage is 100%.

@@         Coverage Diff          @@
##             dev    #26   +/-   ##
====================================
  Coverage       ?    96%
====================================
  Files          ?      7
  Lines          ?   1022
  Branches       ?      0
====================================
  Hits           ?    991
  Misses         ?     31
  Partials       ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3025f0...5a31990. Read the comment docs.

@johlju - do you think I could get you to code review this for me if you ever have a moment (week)? I know this is a large change, but it's mainly around style rather than logic.

Absolutely, I can help you with this, but i'm afraid it won't be until next week. A lot of stuff in xSQLServer that has stacked up this week :)

Thank you so much @johlju - and absolutely no rush - I've had this sitting around for a couple on months so it can wait longer :grin:

Hi @johlju - seeing as there are so many style changes in this PR already I thought I'd add the HQRM ones as well - I figured you'd point most of them out in the review anyways :grin:
So this PR will also fix:
#21
#22

@johlju - This change should make the entire resource module meet guidelines (including HQRM).

@PlagueHO Awesome! I will get to this, I have not forgotten, just so you know. Was hoping to have started the review this week, but this week has been quite busy as usual.
And this weekend I need to get my trailer working so I can hit the motocross track now when it starting to get warmer here. 😄
But rest assure I will get to it! 😃

@johlju - there is no hurry - I'm extremely grateful to you for all the time you put into DSC and your code and reviews (best reviewer)! And wow - motocross!?! I had no idea - that is epic!

Haha :laughing:  I don't ride as much I did before. But try to get it out on the track during the summer at least. It's a great form of exercise, and fun! :smile:  You don't have time to think of DSC while you trying to keep the bike from going were it should not :wink:
A bunch of comments, most are the same comments throughout the examples.
44 files left to review. :smile:

Reviewed 17 of 94 files at r1, 20 of 45 files at r2.
Review status: 35 of 79 files reviewed at latest revision, 135 unresolved discussions, some commit checks broke.

.markdownlint.json, line 3 at r3 (raw file):

{
    "MD013": true
}

New line at the end here.

README.md, line 12 at r3 (raw file):

The **xDFS** module contains the following resources:

- **xDFSNamespaceFolder**: Create, edit or remove folders from DFS namespaces.

Is is possible to get a link on these resource names to their respectively wiki page?

README.md, line 13 at r3 (raw file):

Installation
Install-Module -Name xDFS -MinimumVersion <IP_ADDRESS>

You removed this.  Because it was moved to the wiki?

README.md, line 31 at r3 (raw file):

- **Windows Management Framework 5.0**: Required because the
  PSDSCRunAsCredential DSC Resource parameter is needed.

Add a reference (link) to the 'Domain Credentials' section down below? Or move up the 'Domain Credentials' section here?

Modules/xDFS/xDFS.psd1, line 40 at r3 (raw file):

    # Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
    PrivateData = @{

Remove blank line here?

Modules/xDFS/xDFS.psd1, line 58 at r3 (raw file):

'

Remove blank line here?

Modules/xDFS/xDFS.psd1, line 60 at r3 (raw file):

        } # End of PSData hashtable

Remove blank line here?

Modules/xDFS/xDFS.psd1, line 62 at r3 (raw file):

    } # End of PrivateData hashtable

Remove blank line here?

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 16 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 28 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 29 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 43 at r3 (raw file):

            Path                 = '\\contoso.com\software'
            TargetPath           = '\\ca-fileserver\software'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 53 at r3 (raw file):

            Path                 = '\\contoso.com\software'
            TargetPath           = '\\ma-fileserver\software'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 62 at r3 (raw file):

        {
            Path                 = '\\contoso.com\software'
            TargetPath           = '\\ma-fileserver\software'

This should be 'ny-fileserver'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 63 at r3 (raw file):

            Path                 = '\\contoso.com\software'
            TargetPath           = '\\ma-fileserver\software'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 74 at r3 (raw file):

            Path                 = '\\contoso.com\software\it'
            TargetPath           = '\\ca-fileserver\it'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 83 at r3 (raw file):

            Path                 = '\\contoso.com\software\it'
            TargetPath           = '\\ma-fileserver\it'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 91 at r3 (raw file):

        {
            Path                 = '\\contoso.com\software\it'
            TargetPath           = '\\ma-fileserver\it'

This should be 'ny-fileserver'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 92 at r3 (raw file):

            Path                 = '\\contoso.com\software\it'
            TargetPath           = '\\ma-fileserver\it'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 4 at r3 (raw file):

    .EXAMPLE
    Create an AD Domain V2 based DFS namespace called departments in the domain contoso.com
    with a single root target on the computer fs_1. Two subfolders are defined with targets

Maybe more detail '...sub-folders are defined under the departments folder...'?
My spellchecker in Chrome does not like 'subfolders'  it wants it to be 'sub-folders' or sub folders'. You know best here :)

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 16 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 28 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 29 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 43 at r3 (raw file):

            Path                 = '\\contoso.com\departments'
            TargetPath           = '\\fs_1\departments'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 55 at r3 (raw file):

            Path                 = '\\contoso.com\departments\finance'
            TargetPath           = '\\fs_3\Finance'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 65 at r3 (raw file):

            Path                 = '\\contoso.com\departments\management'
            TargetPath           = '\\fs_8\Management'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 4 at r3 (raw file):

    .EXAMPLE
    Create a standalone DFS namespace using FQDN called public on the server
    fileserver1.contoso.com. A namespace folder called Brochures is also created in this

Here it's named namespace and not sub-folders (seen in another example). Which is correct?

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 4 at r3 (raw file):

Brochures

Upper 'B' here, while it's lower B in the actual path below and in the resource configuration.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 16 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 24 at r3 (raw file):

    Node $NodeName
    {
        # Install the Prerequisite features first

Comment block

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 28 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 29 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 51 at r3 (raw file):

            Path                 = '\\fileserver1.contoso.com\public'
            TargetPath           = '\\fileserver1.contoso.com\public'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 62 at r3 (raw file):

            Path                 = '\\fileserver1.contoso.com\public\brochures'
            TargetPath           = '\\fileserver2.contoso.com\brochures'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 4 at r3 (raw file):

Brochures

Same comment as another example... Namespace and not sub-folder, and upper 'B', but not in the path.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 16 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 24 at r3 (raw file):

    Node $NodeName
    {
        # Install the Prerequisite features first

Comment block here

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 28 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single qoutes

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 29 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single qoutes

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 38 at r3 (raw file):

        }

       # Configure the namespace

Comment out of alignment

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 43 at r3 (raw file):

            Path                 = '\\fileserver1\public'
            TargetPath           = '\\fileserver1\public'
            Ensure               = 'present'

Upper 'P' in present

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 49 at r3 (raw file):

        } # End of DFSNamespaceRoot Resource

       # Configure the namespace folder

Comment out of alignment

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 54 at r3 (raw file):

            Path                 = '\\fileserver1\public\brochures'
            TargetPath           = '\\fileserver2\brochures'
            Ensure               = 'present'

Upper 'P' in present

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 16 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 24 at r3 (raw file):

    Node $NodeName
    {
        # Install the Prerequisite features first

Comment block

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 28 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 29 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 38 at r3 (raw file):

        }

       # Configure the namespace

Comment out of alignment

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 43 at r3 (raw file):

            Path                 = '\\contoso.com\software'
            TargetPath           = '\\ca-fileserver\software'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 53 at r3 (raw file):

            Path                 = '\\contoso.com\software'
            TargetPath           = '\\ma-fileserver\software'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 62 at r3 (raw file):

        {
            Path                 = '\\contoso.com\software'
            TargetPath           = '\\ma-fileserver\software'

Should be 'ny-fileserver'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 63 at r3 (raw file):

            Path                 = '\\contoso.com\software'
            TargetPath           = '\\ma-fileserver\software'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 74 at r3 (raw file):

            Path                 = '\\contoso.com\software\it'
            TargetPath           = '\\ca-fileserver\it'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 83 at r3 (raw file):

            Path                 = '\\contoso.com\software\it'
            TargetPath           = '\\ma-fileserver\it'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 91 at r3 (raw file):

        {
            Path                 = '\\contoso.com\software\it'
            TargetPath           = '\\ma-fileserver\it'

Should be 'ny-fileserver'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 92 at r3 (raw file):

            Path                 = '\\contoso.com\software\it'
            TargetPath           = '\\ma-fileserver\it'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 16 at r3 (raw file):

        [Parameter()]
        [pscredential]

[PSCredential] Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 24 at r3 (raw file):

    Node $NodeName
    {
        # Install the Prerequisite features first

Comment block here

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 28 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 29 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 38 at r3 (raw file):

        }

       # Configure the namespace

Comment out of alignement

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 43 at r3 (raw file):

            Path                 = '\\contoso.com\departments'
            TargetPath           = '\\fs_1\departments'
            Ensure               = 'present'

Upper 'P' in present

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 50 at r3 (raw file):

        } # End of DFSNamespaceRoot Resource

       # Configure the namespace folders

Comment out of alignement

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 55 at r3 (raw file):

            Path                 = '\\contoso.com\departments\finance'
            TargetPath           = '\\fs_3\Finance'
            Ensure               = 'present'

Upper 'P' in present

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 65 at r3 (raw file):

            Path                 = '\\contoso.com\departments\management'
            TargetPath           = '\\fs_8\Management'
            Ensure               = 'present'

Upper 'P' in present

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 4 at r3 (raw file):

    .EXAMPLE
    Create a standalone DFS namespace using FQDN called public on the server
    fileserver1.contoso.com. A namespace folder called Brochures is also created in this

Same comment about 'Brochures' and namespace as other example file comments

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 16 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 24 at r3 (raw file):

    Node $NodeName
    {
        # Install the Prerequisite features first

Comment block

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 28 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 29 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 38 at r3 (raw file):

        }

       # Configure the namespace server

Comment out of alignment

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 46 at r3 (raw file):

        } # End of xDFSNamespaceServerConfiguration Resource

       # Configure the namespace

Comment out of alignment

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 51 at r3 (raw file):

            Path                 = '\\fileserver1.contoso.com\public'
            TargetPath           = '\\fileserver1.contoso.com\public'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 62 at r3 (raw file):

            Path                 = '\\fileserver1.contoso.com\public\brochures'
            TargetPath           = '\\fileserver2.contoso.com\brochures'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 4 at r3 (raw file):

    .EXAMPLE
    Create a standalone DFS namespace called public on the server fileserver1. A namespace
    folder called Brochures is also created in this namespace that targets the

Same comment about 'Brochures' and namespace as other example file comments

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 16 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 28 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 29 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 38 at r3 (raw file):

        }

       # Configure the namespace

Comment out of alignment

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 43 at r3 (raw file):

            Path                 = '\\fileserver1\public'
            TargetPath           = '\\fileserver1\public'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 49 at r3 (raw file):

        } # End of DFSNamespaceRoot Resource

       # Configure the namespace folder

Comment out of alignment

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 54 at r3 (raw file):

            Path                 = '\\fileserver1\public\brochures'
            TargetPath           = '\\fileserver2\brochures'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 16 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 24 at r3 (raw file):

    Node $NodeName
    {
        # Install the Prerequisite features first

Comment block

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 28 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 29 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 38 at r3 (raw file):

        }

       # Configure the namespace server

Comment is out of alignment

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 46 at r3 (raw file):

        } # End of xDFSNamespaceServerConfiguration Resource

       # Configure the namespace

Comment is out of alignment

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 51 at r3 (raw file):

            Path                 = '\\fileserver1.contoso.com\public'
            TargetPath           = '\\fileserver1.contoso.com\public'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 57 at r3 (raw file):

        } # End of DFSNamespaceRoot Resource

       # Configure the namespace folder

Comment is out of alignment

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 62 at r3 (raw file):

            Path                 = '\\fileserver1.contoso.com\public\brochures'
            TargetPath           = '\\fileserver2.contoso.com\brochures'
            Ensure               = 'present'

Upper 'P'

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/1_FullMesh.ps1, line 17 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/1_FullMesh.ps1, line 25 at r3 (raw file):

    Node $NodeName
    {
        # Install the Prerequisite features first

Comment block

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/1_FullMesh.ps1, line 29 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/1_FullMesh.ps1, line 30 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/1_FullMesh.ps1, line 43 at r3 (raw file):

            Topology = 'Fullmesh'
            PSDSCRunAsCredential = $Credential
            DependsOn = "[WindowsFeature]RSATDFSMgmtConInstall"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/2_Simple.ps1, line 17 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/2_Simple.ps1, line 29 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/2_Simple.ps1, line 30 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/2_Simple.ps1, line 44 at r3 (raw file):

            ContentPaths = 'd:\public\software','d:\public\misc'
            PSDSCRunAsCredential = $Credential
            DependsOn = "[WindowsFeature]RSATDFSMgmtConInstall"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/3_Complete.ps1, line 6 at r3 (raw file):

    FileServer2. The Replication Group contains a single folder called Software. A description
    will be set on the Software folder and it will be set to exclude the directory Temp from
    replication. A manual topology is assigned to the replication connections.

Where does it set to manual topology? Was expecting a parameter for that set to 'Manual' (out of my depth here so not sure how it works) :)

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/3_Complete.ps1, line 17 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'DSC'

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/3_Complete.ps1, line 29 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/3_Complete.ps1, line 30 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/3_Complete.ps1, line 42 at r3 (raw file):

            Folders = 'Software'
            PSDSCRunAsCredential = $Credential
            DependsOn = "[WindowsFeature]RSATDFSMgmtConInstall"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/3_Complete.ps1, line 59 at r3 (raw file):

            Ensure = 'Present'
            SourceComputerName = 'FileServer2'
            DestinationComputerName = 'FileServer1.contoso.com'

Meant for this to be FQDN but not FileServer1 in previous resource?

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 6 at r3 (raw file):

    FileServer2. The Replication Group contains a single folder called Software. A description
    will be set on the Software folder and it will be set to exclude the directory Temp from
    replication. A manual topology is assigned to the replication connections.

Same question about 'manual topology' as another example file comment :)

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 17 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 25 at r3 (raw file):

    Node $NodeName
    {
        # Install the Prerequisite features first

Comment block

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 29 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 30 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 42 at r3 (raw file):

            Folders = 'Software'
            PSDSCRunAsCredential = $Credential
            DependsOn = "[WindowsFeature]RSATDFSMgmtConInstall"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 59 at r3 (raw file):

            Ensure = 'Present'
            SourceComputerName = 'FileServer2'
            DestinationComputerName = 'FileServer1.contoso.com'

Meant for this to be FQDN but not FileServer1 in previous resource?

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/1_FullMesh.ps1, line 17 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/1_FullMesh.ps1, line 25 at r3 (raw file):

    Node $NodeName
    {
        # Install the Prerequisite features first

Comment block

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/1_FullMesh.ps1, line 29 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/1_FullMesh.ps1, line 30 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/1_FullMesh.ps1, line 43 at r3 (raw file):

            Topology = 'Fullmesh'
            PSDSCRunAsCredential = $Credential
            DependsOn = "[WindowsFeature]RSATDFSMgmtConInstall"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 6 at r3 (raw file):

    FileServer2. The Replication Group contains a single folder called Software. A description
    will be set on the Software folder and it will be set to exclude the directory Temp from
    replication. A manual topology is assigned to the replication connections.

Same comment about manual here as other example

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 17 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 25 at r3 (raw file):

    Node $NodeName
    {
        # Install the Prerequisite features first

Comment block

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 29 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 30 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 42 at r3 (raw file):

            Folders = 'Software'
            PSDSCRunAsCredential = $Credential
            DependsOn = "[WindowsFeature]RSATDFSMgmtConInstall"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 59 at r3 (raw file):

            Ensure = 'Present'
            SourceComputerName = 'FileServer2'
            DestinationComputerName = 'FileServer1.contoso.com'

FQDN here, but fileserver1 above is not FQDN. Is it meant to be this way?

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/1_FullMesh.ps1, line 17 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/1_FullMesh.ps1, line 29 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/1_FullMesh.ps1, line 30 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/1_FullMesh.ps1, line 43 at r3 (raw file):

            Topology = 'Fullmesh'
            PSDSCRunAsCredential = $Credential
            DependsOn = "[WindowsFeature]RSATDFSMgmtConInstall"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/2_Complete.ps1, line 6 at r3 (raw file):

    FileServer2. The Replication Group contains a single folder called Software. A description
    will be set on the Software folder and it will be set to exclude the directory Temp from
    replication. A manual topology is assigned to the replication connections.

Same question about manual as other example

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/2_Complete.ps1, line 17 at r3 (raw file):

        [Parameter()]
        [pscredential]

Upper 'PSC'

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/2_Complete.ps1, line 29 at r3 (raw file):

        WindowsFeature RSATDFSMgmtConInstall
        {
            Ensure = "Present"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/2_Complete.ps1, line 30 at r3 (raw file):

        {
            Ensure = "Present"
            Name = "RSAT-DFS-Mgmt-Con"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/2_Complete.ps1, line 42 at r3 (raw file):

            Folders = 'Software'
            PSDSCRunAsCredential = $Credential
            DependsOn = "[WindowsFeature]RSATDFSMgmtConInstall"

Single quotes

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/2_Complete.ps1, line 59 at r3 (raw file):

            Ensure = 'Present'
            SourceComputerName = 'FileServer2'
            DestinationComputerName = 'FileServer1.contoso.com'

Meant to be FQDN here and not fileserver1 in the previous resource?

Comments from Reviewable

29 files left to review after this batch of comments :smile:

Reviewed 17 of 94 files at r1, 1 of 45 files at r2, 4 of 10 files at r3.
Review status: 50 of 79 files reviewed at latest revision, 205 unresolved discussions, some commit checks broke.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 38 at r3 (raw file):

        $TargetPath,

        [Parameter(Mandatory = $true)]

Does Ensure need to be mandatory (Required)? Isn't it enough for it to be Write with a default value of 'Present'?
If it was Write then this parameter would not be needed here in the Get-method since it doesn't seem to be used.
If it needs to be required, then add to the parameter description in comment based help that it is not used in Get-TargetResource.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 58 at r3 (raw file):

    # Remove the Ensue parmeter from the bound parameters
    $null = $PSBoundParameters.Remove('Ensure')

Why this row? Can't see it is being used anywhere.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 267 at r3 (raw file):

                    -ErrorAction Stop

                $folderProperties.GetEnumerator() | ForEach-Object -Process {

Minor: Looping through these seem excessive unless $VerbosePreference -ne 'SilentlyContinue' since the foreach does nothing unless Verbose messages should be outputted? But I'm good keeping it as is too.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 331 at r3 (raw file):

            # Output the target parameters that were changed/set
            $targetProperties.GetEnumerator() | ForEach-Object -Process {

Minor: Same comment as above

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 341 at r3 (raw file):

        else
        {
            # Prepare to use the PSBoundParameters as a splat to created

Comment block

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 356 at r3 (raw file):

                -ErrorAction Stop

            $PSBoundParameters.GetEnumerator() | ForEach-Object -Process {

Minor: Same comment as above

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 529 at r3 (raw file):

            }

            $targe = Get-FolderTarget `

Change to $targetFolder

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 533 at r3 (raw file):

                -TargetPath $TargetPath

            if ($targe)

Change to $targetFolder

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 536 at r3 (raw file):

            {
                if (($ReferralPriorityClass) `
                    -and ($targe.ReferralPriorityClass -ne $ReferralPriorityClass)) {

Change to $targetFolder

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 546 at r3 (raw file):

                if (($ReferralPriorityRank) `
                    -and ($targe.ReferralPriorityRank -ne $ReferralPriorityRank)) {

Change to $targetFolder

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 582 at r3 (raw file):

        if ($folder)
        {
            $targe = Get-FolderTarget `

Change to $targetFolder

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 586 at r3 (raw file):

                -TargetPath $TargetPath

            if ($targe)

Change to $targetFolder

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 649 at r3 (raw file):

    catch
    {
        Throw $_

lower 't'

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 690 at r3 (raw file):

    catch
    {
        Throw $_

lower 't'

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.schema.mof, line 4 at r3 (raw file):

class MSFT_xDFSNamespaceFolder : OMI_BaseResource
{
    [key, Description("Specifies a path for the root of a DFS namespace.")] String Path;

Key - Upper 'K'

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.schema.mof, line 5 at r3 (raw file):

{
    [key, Description("Specifies a path for the root of a DFS namespace.")] String Path;
    [key, Description("Specifies a path for a root target of the DFS namespace.")] String TargetPath;

Key - Upper 'K'

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 41 at r3 (raw file):

        $TargetPath,

        [Parameter(Mandatory = $true)]

Does Ensure need to be mandatory (Required)? Isn't it enough for it to be Write with a default value of 'Present'?
If it was Write then this parameter would not be needed here in the Get-method since it doesn't seem to be used.
If it needs to be required, then add to the parameter description in comment based help that it is not used in Get-TargetResource.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 67 at r3 (raw file):

    # Remove the Ensue parmeter from the bound parameters
    $null = $PSBoundParameters.Remove('Ensure')

This is not used anywhere?

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 335 at r3 (raw file):

                    -ErrorAction Stop

                $rootProperties.GetEnumerator() | ForEach-Object -Process {

Minor: Same comment as a comment in another resource

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 399 at r3 (raw file):

            # Output the target parameters that were changed/set
            $targetProperties.GetEnumerator() | ForEach-Object -Process {

Minor: Same comment as a comment in another resource

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 409 at r3 (raw file):

        else
        {
            # Prepare to use the PSBoundParameters as a splat to created

Comment block

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 424 at r3 (raw file):

                -ErrorAction Stop

            $PSBoundParameters.GetEnumerator() | ForEach-Object -Process {

Minor: Same comment as a comment in another resource

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 585 at r3 (raw file):

            # The Namespace root exists and should

            # Changing the namespace type is not possible - the namespace

Comment block

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 791 at r3 (raw file):

    catch
    {
        Throw $_

lower 't'

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 832 at r3 (raw file):

    catch
    {
        Throw $_

lower 't'

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.schema.mof, line 4 at r3 (raw file):

class MSFT_xDFSNamespaceRoot : OMI_BaseResource
{
    [key, Description("Specifies a path for the root of a DFS namespace.")] String Path;

Upper 'K' in Key

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.schema.mof, line 5 at r3 (raw file):

{
    [key, Description("Specifies a path for the root of a DFS namespace.")] String Path;
    [key, Description("Specifies a path for a root target of the DFS namespace.")] String TargetPath;

Upper 'K' in Key

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 13 at r3 (raw file):

    NamespaceRootTargetRemovedMessage                  = {0} DFS Namespace Root "{1}" Target "{2}" removed.
    TestingNamespaceRootMessage                        = Testing {0} DFS Namespace Root "{1}" Target "{2}".
    NamespaceRootTypeConversionError                   = Error- {0} DFS Namespace can not be added to a {3} DFS Namespace.

Should it be a '-' here after 'Error'?

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 14 at r3 (raw file):

    This is an array of all the parameters used by this resource
    If the property Restart is true then when this property is updated the service
    Will be restarted.

lower 'w' in 'Will'

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 19 at r3 (raw file):

{
    @(
        @{ Name = 'LdapTimeoutSec';            Type = 'Uint32'  },

Hashtable should be formatted correctly.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 20 at r3 (raw file):

    @(
        @{ Name = 'LdapTimeoutSec';            Type = 'Uint32'  },
        @{ Name = 'SyncIntervalSec';           Type = 'String'  },

Hashtable should be formatted correctly.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 21 at r3 (raw file):

        @{ Name = 'LdapTimeoutSec';            Type = 'Uint32'  },
        @{ Name = 'SyncIntervalSec';           Type = 'String'  },
        @{ Name = 'UseFQDN';                   Type = 'Uint32'; Restart = $True }

Hashtable should be formatted correctly.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 49 at r3 (raw file):

        ) -join '' )

    # The ComputerName will always be LocalHost unless a good reason can be provided to

change to 'localhost'

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 51 at r3 (raw file):

    # The ComputerName will always be LocalHost unless a good reason can be provided to
    # enable it as a parameter.
    $computerName = 'LocalHost'

change to 'localhost'

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 120 at r3 (raw file):

        ) -join '' )

    # The ComputerName will always be LocalHost unless a good reason can be provided to

change to 'localhost'

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 122 at r3 (raw file):

    # The ComputerName will always be LocalHost unless a good reason can be provided to
    # enable it as a parameter.
    $computerName = 'LocalHost'

change to 'localhost'

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 234 at r3 (raw file):

        ) -join '' )

    # The ComputerName will always be LocalHost unless a good reason can be provided to

change to 'localhost'

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 236 at r3 (raw file):

    # The ComputerName will always be LocalHost unless a good reason can be provided to
    # enable it as a parameter.
    $computerName = 'LocalHost'

change to 'localhost'

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 33 at r3 (raw file):

        $GroupName,

        [Parameter(Mandatory = $true)]

Does Ensure need to be mandatory (Required)? Isn't it enough for it to be Write with a default value of 'Present'?
If it was Write then this parameter would not be needed here in the Get-method since it doesn't seem to be used.
If it needs to be required, then add to the parameter description in comment based help that it is not used in Get-TargetResource.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 74 at r3 (raw file):

            ) -join '' )

        # Array paramters are disabled until this issue is resolved:

Comment block

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 80 at r3 (raw file):

            Description = $replicationGroup.Description
            DomainName = $replicationGroup.DomainName
            # Members = @((Get-DfsrMember @replicationGroupParameters -ErrorAction Stop).ComputerName)

Should this row be commented? If so, then it could be removed

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 81 at r3 (raw file):

            DomainName = $replicationGroup.DomainName
            # Members = @((Get-DfsrMember @replicationGroupParameters -ErrorAction Stop).ComputerName)
            # Folders = @((Get-DfsReplicatedFolder @replicationGroupParameters -ErrorAction Stop).FolderName)

Should this row be commented? If so, then it could be removed

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 82 at r3 (raw file):

            # Members = @((Get-DfsrMember @replicationGroupParameters -ErrorAction Stop).ComputerName)
            # Folders = @((Get-DfsReplicatedFolder @replicationGroupParameters -ErrorAction Stop).FolderName)
            # ContentPaths = @()

Should this row be commented? If so, then it could be removed

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 222 at r3 (raw file):

                    -f $GroupName,$DomainName
                ) -join '' )
            # Check the description

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 226 at r3 (raw file):

            {
                Set-DfsReplicationGroup @replicationGroupParameters -ErrorAction Stop
                Write-Verbose -Message ( @(

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 241 at r3 (raw file):

                    -f $GroupName,$DomainName
                ) -join '' )
            New-DfsReplicationGroup @replicationGroupParameters -ErrorAction Stop

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 242 at r3 (raw file):

                ) -join '' )
            New-DfsReplicationGroup @replicationGroupParameters -ErrorAction Stop
            Write-Verbose -Message ( @(

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 279 at r3 (raw file):

                    -ComputerName $member `
                    -ErrorAction Stop
                Write-Verbose -Message ( @(

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 297 at r3 (raw file):

                    -Force `
                    -ErrorAction Stop
                Write-Verbose -Message ( @(

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 317 at r3 (raw file):

                    -FolderName $folder `
                    -ErrorAction Stop
                Write-Verbose -Message ( @(

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 335 at r3 (raw file):

                    -Force `
                    -ErrorAction Stop
                Write-Verbose -Message ( @(

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 349 at r3 (raw file):

            $memberships = Get-DfsrMembership @replicationGroupParameters `
                -ErrorAction Stop
            # Scan through the content paths array

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 361 at r3 (raw file):

                            @replicationGroupParameters `
                            -ComputerName $membership.ComputerName
                        [System.Boolean] $primarymember = ($fqdnMemberName -eq $fqdnMembers[0])

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 362 at r3 (raw file):

                            -ComputerName $membership.ComputerName
                        [System.Boolean] $primarymember = ($fqdnMemberName -eq $fqdnMembers[0])
                        if (($membership.FolderName -ne $Folders[$i]) `

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 369 at r3 (raw file):

                            continue
                        }
                        # The Content Path for this member needs to be set

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 375 at r3 (raw file):

                            -PrimaryMember $primarymember `
                            -ContentPath $ContentPath
                        Write-Verbose -Message ( @(

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 407 at r3 (raw file):

                        $replicationGroupParameters.SourceComputerName = $source
                        $replicationGroupParameters.DestinationComputerName = $destination
                        $replicationGroupConnection = Get-DfsrConnection @replicationGroupParameters `

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 414 at r3 (raw file):

                                    -DisableConnection $false `
                                    -ErrorAction Stop
                                Write-Verbose -Message ( @(

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 425 at r3 (raw file):

                            Add-DfsrConnection @replicationGroupParameters `
                                -ErrorAction Stop
                            Write-Verbose -Message ( @(

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 444 at r3 (raw file):

                -f $GroupName,$DomainName
            ) -join '' )
        if ($replicationGroup)

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 451 at r3 (raw file):

                -Force `
                -ErrorAction Stop
            Write-Verbose -Message ( @(

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 610 at r3 (raw file):

                        -f $GroupName,$DomainName
                    ) -join '' )
                $desiredConfigurationMatch = $false

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 626 at r3 (raw file):

                        -f $GroupName,$DomainName
                    ) -join '' )
                $desiredConfigurationMatch = $false

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 645 at r3 (raw file):

                        foreach ($membership in $memberships)
                        {
                            [System.Boolean] $primarymember = ($membership.ComputerName -eq $Members[0])

Change to $primaryMember

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 649 at r3 (raw file):

                            if (($membership.FolderName -ne $Folders[$i]) `
                                -or (($membership.ContentPath -eq $contentPath) `
                                -and ($membership.PrimaryMember -eq $primarymember)))

Change to $primaryMember

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 660 at r3 (raw file):

                                    -f $GroupName,$DomainName,$membership.ComputerName
                                ) -join '' )
                            $desiredConfigurationMatch = $false

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 700 at r3 (raw file):

                                            -f  $GroupName,$DomainName,$source,$destination
                                        ) -join '' )
                                    $desiredConfigurationMatch = $false

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 710 at r3 (raw file):

                                        -f  $GroupName,$DomainName,$source,$destination
                                    ) -join '' )
                                $desiredConfigurationMatch = $false

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 739 at r3 (raw file):

                    -f $GroupName,$DomainName
                ) -join '' )
            $desiredConfigurationMatch = $false

Could you add blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 751 at r3 (raw file):

        } # if
    } # if
    return $desiredConfigurationMatch

Could you add blank row before this row

Comments from Reviewable

17 files left to review... I'm gonna circle back a bit, because I saw problems with localization strings. I have to double check them.

Reviewed 14 of 94 files at r1, 4 of 10 files at r3.
Review status: 62 of 79 files reviewed at latest revision, 214 unresolved discussions, some commit checks broke.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/MSFT_xDFSReplicationGroupConnection.psm1, line 53 at r3 (raw file):

        $DestinationComputerName,

        [Parameter(Mandatory = $true)]

Does Ensure need to be mandatory (Required)? Isn't it enough for it to be Write with a default value of 'Present'?
If it was Write then this parameter would not be needed here in the Get-method since it doesn't seem to be used.
If it needs to be required, then add to the parameter description in comment based help that it is not used in Get-TargetResource.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/MSFT_xDFSReplicationGroupConnection.psm1, line 302 at r3 (raw file):

            # Remove the replication group
            Remove-DfsrConnection @connectionParameters -Force -ErrorAction Stop
            Write-Verbose -Message ( @(

Blank row before this row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/MSFT_xDFSReplicationGroupConnection.psm1, line 494 at r3 (raw file):

                    -f $GroupName,$SourceComputerName,$DestinationComputerName,$DomainName
                ) -join '' )
            $desiredConfigurationMatch = $false

Blank row before this one

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/MSFT_xDFSReplicationGroupFolder.psm1, line 78 at r3 (raw file):

        $returnValue += @{
            Description = $replicationGroupFolder.Description
            # FilenameToExclude = $ReplicationGroupFolder.FilenameToExclude

Should this be commented? If so please remove the row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/MSFT_xDFSReplicationGroupFolder.psm1, line 79 at r3 (raw file):

            Description = $replicationGroupFolder.Description
            # FilenameToExclude = $ReplicationGroupFolder.FilenameToExclude
            # DirectoryNameToExclude = $ReplicationGroupFolder.DirectoryNameToExclude

Should this be commented? If so please remove the row

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/MSFT_xDFSReplicationGroupFolder.psm1, line 276 at r3 (raw file):

                    -f $GroupName,$FolderName,$DomainName
                ) -join '' )
            $desiredConfigurationMatch = $false

blank row before this one

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/README.md, line 4 at r3 (raw file):

'...folder Description, FilenameToExclude or DirectoryNameToExclude fields need...'

Could we revise this text?
Maybe '...folder properties Description, FilenameToExclude or DirectoryNameToExclude need...'

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/MSFT_xDFSReplicationGroupMembership.psm1, line 89 at r3 (raw file):

                -f $GroupName,$FolderName,$ComputerName,$DomainName
            ) -join '' )
        $returnValue.ComputerName = $replicationGroupMembership.ComputerName

blank row before this one

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/MSFT_xDFSReplicationGroupMembership.psm1, line 90 at r3 (raw file):

            ) -join '' )
        $returnValue.ComputerName = $replicationGroupMembership.ComputerName
        $returnValue += @{

blank row before this one

Comments from Reviewable

Thank you so much @johlju - I really appreciate this - I owe you so many beers! :grin: I'll start fixing things up now.

Still 17 files to go. Continue with the last 17 files soon.

Review status: 62 of 79 files reviewed at latest revision, 290 unresolved discussions, some commit checks broke.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 3 at r3 (raw file):

ConvertFrom-StringData @'
    GettingNamespaceFolderMessage                        = Getting DFS Namespace Folder "{0}" Target "{1}".
    NamespaceFolderExistsMessage                         = DFS Namespace Folder "{0}" exists.

This only have one placeholder, but there is two objects sent in.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 4 at r3 (raw file):

    GettingNamespaceFolderMessage                        = Getting DFS Namespace Folder "{0}" Target "{1}".
    NamespaceFolderExistsMessage                         = DFS Namespace Folder "{0}" exists.
    NamespaceFolderDoesNotExistMessage                   = DFS Namespace Folder "{0}" does not exist.

This only have one placeholder, but there is two objects sent in.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 5 at r3 (raw file):

    NamespaceFolderExistsMessage                         = DFS Namespace Folder "{0}" exists.
    NamespaceFolderDoesNotExistMessage                   = DFS Namespace Folder "{0}" does not exist.
    NamespaceFolderTargetExistsMessage                   = DFS Namespace Folder "{0}" target "{1}" exists.

Shouldn't these and most other strings say '..on target...' adding 'on'?

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 8 at r3 (raw file):

    NamespaceFolderTargetDoesNotExistMessage             = DFS Namespace Folder "{0}" target "{1}" does not exist.
    SettingNamespaceFolderMessage                        = Setting DFS Namespace Folder "{0}" Target "{1}".
    NamespaceFolderUpdateParameterMessage                = Setting DFS Namespace Folder "{0}" parameter {2} to "{3}".

This only have three placeholders, but there is four objects sent in.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 10 at r3 (raw file):

NamespaceFolderCreatedMessage

This is not used

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 13 at r3 (raw file):

    NamespaceFolderTargetRemovedMessage                  = DFS Namespace Folder "{0}" Target "{1}" removed.
    TestingNamespaceFolderMessage                        = Testing DFS Namespace Folder "{0}" Target "{1}".
    NamespaceFolderParameterNeedsUpdateMessage           = DFS Namespace Folder "{0}" {2} is different. Change required.

This only have two placeholders, but there is three objects sent in.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 15 at r3 (raw file):

    NamespaceFolderParameterNeedsUpdateMessage           = DFS Namespace Folder "{0}" {2} is different. Change required.
    NamespaceFolderTargetParameterNeedsUpdateMessage     = DFS Namespace Folder "{0}" Target "{1}" {2} is different. Change required.
    NamespaceFolderDoesNotExistButShouldMessage          = DFS Namespace Folder "{0}" does not exist but should. Change required.

This only have one placeholder, but there is two objects sent in.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 18 at r3 (raw file):

    NamespaceFolderTargetExistsButShouldNotMessage       = DFS Namespace Folder "{0}" Target "{1}" exists but should not. Change required.
    NamespaceFolderTargetDoesNotExistButShouldMessage    = DFS Namespace Folder "{0}" Target "{1}" does not exist but should. Change required.
    NamespaceFolderDoesNotExistAndShouldNotMessage       = DFS Namespace Folder "{0}" does not exist and should not. Change not required.

This only have one placeholder, but there is two objects sent in.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 2 at r3 (raw file):

ConvertFrom-StringData @'
    GettingNamespaceRootMessage                        = Getting {0} DFS Namespace Root "{1}" Target "{2}".

Should not these and the rest be '...on target...'? If so, then do that for all the strings throughout the module

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 3 at r3 (raw file):

ConvertFrom-StringData @'
    GettingNamespaceRootMessage                        = Getting {0} DFS Namespace Root "{1}" Target "{2}".
    NamespaceRootExistsMessage                         = {0} DFS Namespace Root "{1}" exists.

Only one placeholder, but two objects sent in

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 10 at r3 (raw file):

NamespaceRootCreatedMessage

This is not used

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 13 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Should it be a '-' here after 'Error'?

Only two placeholders, but four objects sent in

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 14 at r3 (raw file):

    TestingNamespaceRootMessage                        = Testing {0} DFS Namespace Root "{1}" Target "{2}".
    NamespaceRootTypeConversionError                   = Error- {0} DFS Namespace can not be added to a {3} DFS Namespace.
    NamespaceRootParameterNeedsUpdateMessage           = {0} DFS Namespace Root "{1}" {3} is different. Change required.

Only three placeholders, but four objects sent in

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 16 at r3 (raw file):

    NamespaceRootParameterNeedsUpdateMessage           = {0} DFS Namespace Root "{1}" {3} is different. Change required.
    NamespaceRootTargetParameterNeedsUpdateMessage     = {0} DFS Namespace Root "{1}" Target "{2}" {3} is different. Change required.
    NamespaceRootDoesNotExistButShouldMessage          = {0} DFS Namespace Root "{1}" does not exist but should. Change required.

Only two placeholders, but three objects sent in

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 19 at r3 (raw file):

    NamespaceRootTargetExistsButShouldNotMessage       = {0} DFS Namespace Root "{1}" Target "{2}" exists but should not. Change required.
    NamespaceRootTargetDoesNotExistButShouldMessage    = {0} DFS Namespace Root "{1}" Target "{2}" does not exist but should. Change required.
    NamespaceRootDoesNotExistAndShouldNotMessage       = {0} DFS Namespace Root "{1}" does not exist and should not. Change not required.

Only two placeholders, but three objects sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 2 at r3 (raw file):

ConvertFrom-StringData @'
    GettingReplicationGroupMessage                    = Getting DFS Replication Group "{0}".

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 3 at r3 (raw file):

ConvertFrom-StringData @'
    GettingReplicationGroupMessage                    = Getting DFS Replication Group "{0}".
    ReplicationGroupExistsMessage                     = DFS Replication Group "{0}" exists.

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 4 at r3 (raw file):

    GettingReplicationGroupMessage                    = Getting DFS Replication Group "{0}".
    ReplicationGroupExistsMessage                     = DFS Replication Group "{0}" exists.
    ReplicationGroupDoesNotExistMessage               = DFS Replication Group "{0}" does not exist.

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 5 at r3 (raw file):

    ReplicationGroupExistsMessage                     = DFS Replication Group "{0}" exists.
    ReplicationGroupDoesNotExistMessage               = DFS Replication Group "{0}" does not exist.
    SettingRegGroupMessage                            = Setting DFS Replication Group "{0}".

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 6 at r3 (raw file):

    ReplicationGroupDoesNotExistMessage               = DFS Replication Group "{0}" does not exist.
    SettingRegGroupMessage                            = Setting DFS Replication Group "{0}".
    EnsureReplicationGroupExistsMessage               = Ensuring DFS Replication Group "{0}" exists.

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 7 at r3 (raw file):

    SettingRegGroupMessage                            = Setting DFS Replication Group "{0}".
    EnsureReplicationGroupExistsMessage               = Ensuring DFS Replication Group "{0}" exists.
    EnsureReplicationGroupDoesNotExistMessage         = Ensuring DFS Replication Group "{0}" does not exist.

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 8 at r3 (raw file):

    EnsureReplicationGroupExistsMessage               = Ensuring DFS Replication Group "{0}" exists.
    EnsureReplicationGroupDoesNotExistMessage         = Ensuring DFS Replication Group "{0}" does not exist.
    ReplicationGroupCreatedMessage                    = DFS Replication Group "{0}" has been created.

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 9 at r3 (raw file):

    EnsureReplicationGroupDoesNotExistMessage         = Ensuring DFS Replication Group "{0}" does not exist.
    ReplicationGroupCreatedMessage                    = DFS Replication Group "{0}" has been created.
    ReplicationGroupDescriptionUpdatedMessage         = DFS Replication Group "{0}" description has been updated.

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 10 at r3 (raw file):

    ReplicationGroupCreatedMessage                    = DFS Replication Group "{0}" has been created.
    ReplicationGroupDescriptionUpdatedMessage         = DFS Replication Group "{0}" description has been updated.
    ReplicationGroupMemberAddedMessage                = DFS Replication Group "{0}" added member "{2}".

This has only two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 11 at r3 (raw file):

    ReplicationGroupDescriptionUpdatedMessage         = DFS Replication Group "{0}" description has been updated.
    ReplicationGroupMemberAddedMessage                = DFS Replication Group "{0}" added member "{2}".
    ReplicationGroupMemberRemovedMessage              = DFS Replication Group "{0}" removed member "{2}".

This has only two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 12 at r3 (raw file):

    ReplicationGroupMemberAddedMessage                = DFS Replication Group "{0}" added member "{2}".
    ReplicationGroupMemberRemovedMessage              = DFS Replication Group "{0}" removed member "{2}".
    ReplicationGroupFolderAddedMessage                = DFS Replication Group "{0}" added folder "{2}".

This has only two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 13 at r3 (raw file):

    ReplicationGroupMemberRemovedMessage              = DFS Replication Group "{0}" removed member "{2}".
    ReplicationGroupFolderAddedMessage                = DFS Replication Group "{0}" added folder "{2}".
    ReplicationGroupFolderRemovedMessage              = DFS Replication Group "{0}" removed folder "{2}".

This has only two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 14 at r3 (raw file):

    ReplicationGroupFolderAddedMessage                = DFS Replication Group "{0}" added folder "{2}".
    ReplicationGroupFolderRemovedMessage              = DFS Replication Group "{0}" removed folder "{2}".
    ReplicationGroupContentPathUpdatedMessage         = DFS Replication Group "{0}" Content Path for "{2}" updated.

This has only two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 15 at r3 (raw file):

    ReplicationGroupFolderRemovedMessage              = DFS Replication Group "{0}" removed folder "{2}".
    ReplicationGroupContentPathUpdatedMessage         = DFS Replication Group "{0}" Content Path for "{2}" updated.
    ReplicationGroupExistsRemovedMessage              = DFS Replication Group "{0}" existed, but has been removed.

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 16 at r3 (raw file):

    ReplicationGroupContentPathUpdatedMessage         = DFS Replication Group "{0}" Content Path for "{2}" updated.
    ReplicationGroupExistsRemovedMessage              = DFS Replication Group "{0}" existed, but has been removed.
    ReplicationGroupFullMeshConnectionAddedMessage    = DFS Replication Group "{0}" Fullmesh Connection from "{2}" to "{3}" added.

This has only three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 17 at r3 (raw file):

    ReplicationGroupExistsRemovedMessage              = DFS Replication Group "{0}" existed, but has been removed.
    ReplicationGroupFullMeshConnectionAddedMessage    = DFS Replication Group "{0}" Fullmesh Connection from "{2}" to "{3}" added.
    ReplicationGroupFullMeshConnectionUpdatedMessage  = DFS Replication Group "{0}" Fullmesh Connection from "{2}" to "{3}" updated.

This has only three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 18 at r3 (raw file):

    ReplicationGroupFullMeshConnectionAddedMessage    = DFS Replication Group "{0}" Fullmesh Connection from "{2}" to "{3}" added.
    ReplicationGroupFullMeshConnectionUpdatedMessage  = DFS Replication Group "{0}" Fullmesh Connection from "{2}" to "{3}" updated.
    TestingRegGroupMessage                            = Testing DFS Replication Group "{0}".

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 19 at r3 (raw file):

    ReplicationGroupFullMeshConnectionUpdatedMessage  = DFS Replication Group "{0}" Fullmesh Connection from "{2}" to "{3}" updated.
    TestingRegGroupMessage                            = Testing DFS Replication Group "{0}".
    ReplicationGroupDescriptionNeedsUpdateMessage     = DFS Replication Group "{0}" description is different. Change required.

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 20 at r3 (raw file):

    TestingRegGroupMessage                            = Testing DFS Replication Group "{0}".
    ReplicationGroupDescriptionNeedsUpdateMessage     = DFS Replication Group "{0}" description is different. Change required.
    ReplicationGroupMembersNeedUpdateMessage          = DFS Replication Group "{0}" members are different. Change required.

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 21 at r3 (raw file):

    ReplicationGroupDescriptionNeedsUpdateMessage     = DFS Replication Group "{0}" description is different. Change required.
    ReplicationGroupMembersNeedUpdateMessage          = DFS Replication Group "{0}" members are different. Change required.
    ReplicationGroupFoldersNeedUpdateMessage          = DFS Replication Group "{0}" folders are different. Change required.

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 22 at r3 (raw file):

    ReplicationGroupMembersNeedUpdateMessage          = DFS Replication Group "{0}" members are different. Change required.
    ReplicationGroupFoldersNeedUpdateMessage          = DFS Replication Group "{0}" folders are different. Change required.
    ReplicationGroupContentPathNeedUpdateMessage      = DFS Replication Group "{0}" Content Path for "{2}" is different. Change required.

This has only two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 23 at r3 (raw file):

    ReplicationGroupFoldersNeedUpdateMessage          = DFS Replication Group "{0}" folders are different. Change required.
    ReplicationGroupContentPathNeedUpdateMessage      = DFS Replication Group "{0}" Content Path for "{2}" is different. Change required.
    ReplicationGroupDoesNotExistButShouldMessage      = DFS Replication Group "{0}" does not exist but should. Change required.

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 24 at r3 (raw file):

    ReplicationGroupContentPathNeedUpdateMessage      = DFS Replication Group "{0}" Content Path for "{2}" is different. Change required.
    ReplicationGroupDoesNotExistButShouldMessage      = DFS Replication Group "{0}" does not exist but should. Change required.
    ReplicationGroupExistsButShouldNotMessage         = DFS Replication Group "{0}" exists but should not. Change required.

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 25 at r3 (raw file):

    ReplicationGroupDoesNotExistButShouldMessage      = DFS Replication Group "{0}" does not exist but should. Change required.
    ReplicationGroupExistsButShouldNotMessage         = DFS Replication Group "{0}" exists but should not. Change required.
    ReplicationGroupDoesNotExistAndShouldNotMessage   = DFS Replication Group "{0}" does not exist and should not. Change not required.

This has only one placeholder, but two objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 26 at r3 (raw file):

    ReplicationGroupExistsButShouldNotMessage         = DFS Replication Group "{0}" exists but should not. Change required.
    ReplicationGroupDoesNotExistAndShouldNotMessage   = DFS Replication Group "{0}" does not exist and should not. Change not required.
    ReplicationGroupFullMeshMissingConnectionMessage  = DFS Replication Group "{0}" Fullmesh Connection from "{2}" to "{3}" does not exist. Change required.

This has only three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 27 at r3 (raw file):

    ReplicationGroupDoesNotExistAndShouldNotMessage   = DFS Replication Group "{0}" does not exist and should not. Change not required.
    ReplicationGroupFullMeshMissingConnectionMessage  = DFS Replication Group "{0}" Fullmesh Connection from "{2}" to "{3}" does not exist. Change required.
    ReplicationGroupFullMeshDisabledConnectionMessage = DFS Replication Group "{0}" Fullmesh Connection from "{2}" to "{3}" is disabled. Change required.

This has only three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/MSFT_xDFSReplicationGroupConnection.psm1, line 65 at r3 (raw file):

    Write-Verbose -Message ( @(
        "$($MyInvocation.MyCommand): "
        $($LocalizedData.GettingReplicationGroupConnectionMessage) `

This localization string does not exist

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/MSFT_xDFSReplicationGroupConnection.psm1, line 391 at r3 (raw file):

    Write-Verbose -Message ( @(
        "$($MyInvocation.MyCommand): "
        $($LocalizedData.TestingRegGroupConnectionMessage) `

This localization string does not exist

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 2 at r3 (raw file):

GettingReplicationGroupMessage

This is not used

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 3 at r3 (raw file):

ConvertFrom-StringData @'
    GettingReplicationGroupMessage                            = Getting DFS Replication Group Connection "{0}" from "{1}" to "{2}".
    ReplicationGroupConnectionExistsMessage                   = DFS Replication Group Connection "{0}" from "{1}" to "{2}" exists.

This used three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 4 at r3 (raw file):

    GettingReplicationGroupMessage                            = Getting DFS Replication Group Connection "{0}" from "{1}" to "{2}".
    ReplicationGroupConnectionExistsMessage                   = DFS Replication Group Connection "{0}" from "{1}" to "{2}" exists.
    ReplicationGroupConnectionDoesNotExistMessage             = DFS Replication Group Connection "{0}" from "{1}" to "{2}" does not exist.

This used three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 5 at r3 (raw file):

    ReplicationGroupConnectionExistsMessage                   = DFS Replication Group Connection "{0}" from "{1}" to "{2}" exists.
    ReplicationGroupConnectionDoesNotExistMessage             = DFS Replication Group Connection "{0}" from "{1}" to "{2}" does not exist.
    SettingRegGroupConnectionMessage                          = Setting DFS Replication Group Connection "{0}" from "{1}" to "{2}".

This used three placeholders, but for objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 6 at r3 (raw file):

    ReplicationGroupConnectionDoesNotExistMessage             = DFS Replication Group Connection "{0}" from "{1}" to "{2}" does not exist.
    SettingRegGroupConnectionMessage                          = Setting DFS Replication Group Connection "{0}" from "{1}" to "{2}".
    EnsureReplicationGroupConnectionExistsMessage             = Ensuring DFS Replication Group "{0}" from "{1}" to "{2}" exists.

This used three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 7 at r3 (raw file):

    SettingRegGroupConnectionMessage                          = Setting DFS Replication Group Connection "{0}" from "{1}" to "{2}".
    EnsureReplicationGroupConnectionExistsMessage             = Ensuring DFS Replication Group "{0}" from "{1}" to "{2}" exists.
    EnsureReplicationGroupConnectionDoesNotExistMessage       = Ensuring DFS Replication Group "{0}" from "{1}" to "{2}" does not exist.

This used three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 8 at r3 (raw file):

    EnsureReplicationGroupConnectionExistsMessage             = Ensuring DFS Replication Group "{0}" from "{1}" to "{2}" exists.
    EnsureReplicationGroupConnectionDoesNotExistMessage       = Ensuring DFS Replication Group "{0}" from "{1}" to "{2}" does not exist.
    ReplicationGroupConnectionCreatedMessage                  = DFS Replication Group Connection "{0}" from "{1}" to "{2}" has been created.

This used three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 9 at r3 (raw file):

    EnsureReplicationGroupConnectionDoesNotExistMessage       = Ensuring DFS Replication Group "{0}" from "{1}" to "{2}" does not exist.
    ReplicationGroupConnectionCreatedMessage                  = DFS Replication Group Connection "{0}" from "{1}" to "{2}" has been created.
    ReplicationGroupConnectionUpdatedMessage                  = DFS Replication Group Connection "{0}" from "{1}" to "{2}" description has been updated.

This used three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 10 at r3 (raw file):

    ReplicationGroupConnectionCreatedMessage                  = DFS Replication Group Connection "{0}" from "{1}" to "{2}" has been created.
    ReplicationGroupConnectionUpdatedMessage                  = DFS Replication Group Connection "{0}" from "{1}" to "{2}" description has been updated.
    ReplicationGroupConnectionExistsRemovedMessage            = DFS Replication Group Connection "{0}" from "{1}" to "{2}" existed, but has been removed.

This used three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 11 at r3 (raw file):

TestingConnectionRegGroupMessage

This is not used

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 12 at r3 (raw file):

    ReplicationGroupConnectionExistsRemovedMessage            = DFS Replication Group Connection "{0}" from "{1}" to "{2}" existed, but has been removed.
    TestingConnectionRegGroupMessage                          = Testing DFS Replication Group Connection "{0}" from "{1}" to "{2}".
    ReplicationGroupConnectionNeedsUpdateMessage              = DFS Replication Group Connection "{0}" from "{1}" to "{2}" {4} is different. Change required.

This used four placeholders, but five objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 13 at r3 (raw file):

    TestingConnectionRegGroupMessage                          = Testing DFS Replication Group Connection "{0}" from "{1}" to "{2}".
    ReplicationGroupConnectionNeedsUpdateMessage              = DFS Replication Group Connection "{0}" from "{1}" to "{2}" {4} is different. Change required.
    ReplicationGroupConnectionDoesNotExistButShouldMessage    = DFS Replication Group Connection "{0}" from "{1}" to "{2}" does not exist but should. Change required.

This used three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 14 at r3 (raw file):

    ReplicationGroupConnectionNeedsUpdateMessage              = DFS Replication Group Connection "{0}" from "{1}" to "{2}" {4} is different. Change required.
    ReplicationGroupConnectionDoesNotExistButShouldMessage    = DFS Replication Group Connection "{0}" from "{1}" to "{2}" does not exist but should. Change required.
    ReplicationGroupConnectionExistsButShouldNotMessage       = DFS Replication Group Connection "{0}" from "{1}" to "{2}" exists but should not. Change required.

This used three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 15 at r3 (raw file):

    ReplicationGroupConnectionDoesNotExistButShouldMessage    = DFS Replication Group Connection "{0}" from "{1}" to "{2}" does not exist but should. Change required.
    ReplicationGroupConnectionExistsButShouldNotMessage       = DFS Replication Group Connection "{0}" from "{1}" to "{2}" exists but should not. Change required.
    ReplicationGroupConnectionDoesNotExistAndShouldNotMessage = DFS Replication Group Connection "{0}" from "{1}" to "{2}" does not exist and should not. Change not required.

This used three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 2 at r3 (raw file):

ConvertFrom-StringData @'
    GettingReplicationGroupFolderMessage                        = Getting DFS Replication Group "{0}" folder "{1}".

This uses two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 3 at r3 (raw file):

ConvertFrom-StringData @'
    GettingReplicationGroupFolderMessage                        = Getting DFS Replication Group "{0}" folder "{1}".
    ReplicationGroupFolderExistsMessage                         = DFS Replication Group "{0}" folder "{1}" exists.

This uses two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 4 at r3 (raw file):

    GettingReplicationGroupFolderMessage                        = Getting DFS Replication Group "{0}" folder "{1}".
    ReplicationGroupFolderExistsMessage                         = DFS Replication Group "{0}" folder "{1}" exists.
    ReplicationGroupFolderMissingError                          = DFS Replication Group "{0}" folder "{1}" is missing.

This uses two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 5 at r3 (raw file):

    ReplicationGroupFolderExistsMessage                         = DFS Replication Group "{0}" folder "{1}" exists.
    ReplicationGroupFolderMissingError                          = DFS Replication Group "{0}" folder "{1}" is missing.
    SettingRegGroupFolderMessage                                = Setting DFS Replication Group "{0}" folder "{1}".

This uses two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 6 at r3 (raw file):

    ReplicationGroupFolderMissingError                          = DFS Replication Group "{0}" folder "{1}" is missing.
    SettingRegGroupFolderMessage                                = Setting DFS Replication Group "{0}" folder "{1}".
    ReplicationGroupFolderUpdatedMessage                        = DFS Replication Group "{0}" folder "{1}" has has been updated.

This uses two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 7 at r3 (raw file):

    SettingRegGroupFolderMessage                                = Setting DFS Replication Group "{0}" folder "{1}".
    ReplicationGroupFolderUpdatedMessage                        = DFS Replication Group "{0}" folder "{1}" has has been updated.
    TestingRegGroupFolderMessage                                = Testing DFS Replication Group "{0}" folder "{1}".

This uses two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 8 at r3 (raw file):

    ReplicationGroupFolderUpdatedMessage                        = DFS Replication Group "{0}" folder "{1}" has has been updated.
    TestingRegGroupFolderMessage                                = Testing DFS Replication Group "{0}" folder "{1}".
    ReplicationGroupFolderDescriptionMismatchMessage            = DFS Replication Group "{0}" folder "{1}" has incorrect Description. Change required.

This uses two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 9 at r3 (raw file):

    TestingRegGroupFolderMessage                                = Testing DFS Replication Group "{0}" folder "{1}".
    ReplicationGroupFolderDescriptionMismatchMessage            = DFS Replication Group "{0}" folder "{1}" has incorrect Description. Change required.
    ReplicationGroupFolderFileNameToExcludeMismatchMessage      = DFS Replication Group "{0}" folder "{1}" has incorrect FileNameToExclude. Change required.

This uses two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 10 at r3 (raw file):

    ReplicationGroupFolderDescriptionMismatchMessage            = DFS Replication Group "{0}" folder "{1}" has incorrect Description. Change required.
    ReplicationGroupFolderFileNameToExcludeMismatchMessage      = DFS Replication Group "{0}" folder "{1}" has incorrect FileNameToExclude. Change required.
    ReplicationGroupFolderDirectoryNameToExcludeMismatchMessage = DFS Replication Group "{0}" folder "{1}" has incorrect DirectoryNameToExclude. Change required.

This uses two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 11 at r3 (raw file):

    ReplicationGroupFolderFileNameToExcludeMismatchMessage      = DFS Replication Group "{0}" folder "{1}" has incorrect FileNameToExclude. Change required.
    ReplicationGroupFolderDirectoryNameToExcludeMismatchMessage = DFS Replication Group "{0}" folder "{1}" has incorrect DirectoryNameToExclude. Change required.
    ReplicationGroupFolderDfsnPathMismatchMessage               = DFS Replication Group "{0}" folder "{1}" has incorrect DfsnPath. Change required.

This uses two placeholders, but three objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 2 at r3 (raw file):

ConvertFrom-StringData @'
    GettingReplicationGroupMembershipMessage              = Getting DFS Replication Group "{0}" folder "{1}" on "{2}".

This uses three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 3 at r3 (raw file):

ConvertFrom-StringData @'
    GettingReplicationGroupMembershipMessage              = Getting DFS Replication Group "{0}" folder "{1}" on "{2}".
    ReplicationGroupMembershipExistsMessage               = DFS Replication Group "{0}" folder "{1}" on "{2}" exists.

This uses three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 4 at r3 (raw file):

    GettingReplicationGroupMembershipMessage              = Getting DFS Replication Group "{0}" folder "{1}" on "{2}".
    ReplicationGroupMembershipExistsMessage               = DFS Replication Group "{0}" folder "{1}" on "{2}" exists.
    ReplicationGroupMembershipMissingError                = DFS Replication Group "{0}" folder "{1}" on "{2}" is missing.

This uses three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 5 at r3 (raw file):

    ReplicationGroupMembershipExistsMessage               = DFS Replication Group "{0}" folder "{1}" on "{2}" exists.
    ReplicationGroupMembershipMissingError                = DFS Replication Group "{0}" folder "{1}" on "{2}" is missing.
    SettingRegGroupMembershipMessage                      = Setting DFS Replication Group "{0}" folder "{1}" on "{2}".

This uses three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 6 at r3 (raw file):

    ReplicationGroupMembershipMissingError                = DFS Replication Group "{0}" folder "{1}" on "{2}" is missing.
    SettingRegGroupMembershipMessage                      = Setting DFS Replication Group "{0}" folder "{1}" on "{2}".
    ReplicationGroupMembershipUpdatedMessage              = DFS Replication Group "{0}" folder "{1}" on "{2}" has has been updated.

This uses three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 7 at r3 (raw file):

    SettingRegGroupMembershipMessage                      = Setting DFS Replication Group "{0}" folder "{1}" on "{2}".
    ReplicationGroupMembershipUpdatedMessage              = DFS Replication Group "{0}" folder "{1}" on "{2}" has has been updated.
    TestingRegGroupMembershipMessage                      = Testing DFS Replication Group "{0}" folder "{1}" on "{2}".

This uses three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 8 at r3 (raw file):

    ReplicationGroupMembershipUpdatedMessage              = DFS Replication Group "{0}" folder "{1}" on "{2}" has has been updated.
    TestingRegGroupMembershipMessage                      = Testing DFS Replication Group "{0}" folder "{1}" on "{2}".
    ReplicationGroupMembershipContentPathMismatchMessage  = DFS Replication Group "{0}" folder "{1}" on "{2}" has incorrect ContentPath. Change required.

This uses three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 9 at r3 (raw file):

    TestingRegGroupMembershipMessage                      = Testing DFS Replication Group "{0}" folder "{1}" on "{2}".
    ReplicationGroupMembershipContentPathMismatchMessage  = DFS Replication Group "{0}" folder "{1}" on "{2}" has incorrect ContentPath. Change required.
    ReplicationGroupMembershipStagingPathMismatchMessage  = DFS Replication Group "{0}" folder "{1}" on "{2}" has incorrect StagingPath. Change required.

This uses three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 10 at r3 (raw file):

    ReplicationGroupMembershipContentPathMismatchMessage  = DFS Replication Group "{0}" folder "{1}" on "{2}" has incorrect ContentPath. Change required.
    ReplicationGroupMembershipStagingPathMismatchMessage  = DFS Replication Group "{0}" folder "{1}" on "{2}" has incorrect StagingPath. Change required.
    ReplicationGroupMembershipReadOnlyMismatchMessage     = DFS Replication Group "{0}" folder "{1}" on "{2}" has incorrect ReadOnly. Change required.

This uses three placeholders, but four objects are sent in

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 11 at r3 (raw file):

ReplicationGroupMembershipPrimaryMemberismatchMessage

Typo in name, should be 'ReplicationGroupMembershipPrimaryMemberMismatchMessage'
This also only uses three placeholders, but four objects are sent in

Comments from Reviewable

14 files left to review, which is all the tests.  I do them tonight or tomorrow.

Reviewed 3 of 45 files at r2.
Review status: 65 of 79 files reviewed at latest revision, 295 unresolved discussions, some commit checks broke.

Modules/xDFS/Modules/DFSDsc.ResourceHelper/DFSDsc.ResourceHelper.psm1, line 11 at r3 (raw file):

        $computerInfo = Get-ComputerInfo

        if ("Server" -eq $computerInfo.OsProductType `

Single quotes

Modules/xDFS/Modules/DFSDsc.ResourceHelper/DFSDsc.ResourceHelper.psm1, line 12 at r3 (raw file):

        if ("Server" -eq $computerInfo.OsProductType `
            -and "NanoServer" -eq $computerInfo.OsServerLevel)

Single quotes

Modules/xDFS/Modules/DFSDsc.ResourceHelper/DFSDsc.ResourceHelper.psm1, line 21 at r3 (raw file):

}

<#

Missing Parameter description in comment-based help

Tests/TestHelpers/CommonTestHelper.psm1, line 33 at r3 (raw file):

        ArgumentList = @( $argumentException, $ArgumentName, 'InvalidArgument', $null )
    }
    return New-Object @newObjectParams

Minor: Blank row before this one

Tests/TestHelpers/CommonTestHelper.psm1, line 81 at r3 (raw file):

            'InvalidOperation', $null )
    }
    return New-Object @newObjectParams

Minor: Blank row before this one

Comments from Reviewable

Review status: 53 of 79 files reviewed at latest revision, 297 unresolved discussions.

.markdownlint.json, line 3 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
New line at the end here.

Done.

README.md, line 12 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Is is possible to get a link on these resource names to their respectively wiki page?

Done. Although the links will only work once this release has gone to master so that the Wiki can be published.

README.md, line 13 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

Installation
Install-Module -Name xDFS -MinimumVersion <IP_ADDRESS>

You removed this.  Because it was moved to the wiki?

No, I removed it because it wasn't part of the standard DSC Resource information header - none of the other resources (xNetworking, xStorage, xCertificate etc) included it and it just added maintenance overhead (had to remember to update it on every release).

README.md, line 31 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Add a reference (link) to the 'Domain Credentials' section down below? Or move up the 'Domain Credentials' section here?

I thought it would be cleaner to move the section up - so have done so.

Modules/xDFS/xDFS.psd1, line 40 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Remove blank line here?

Done.

Modules/xDFS/xDFS.psd1, line 58 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Remove blank line here?

Done.

Modules/xDFS/xDFS.psd1, line 60 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Remove blank line here?

Done.

Modules/xDFS/xDFS.psd1, line 62 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Remove blank line here?

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 38 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Does Ensure need to be mandatory (Required)? Isn't it enough for it to be Write with a default value of 'Present'?
If it was Write then this parameter would not be needed here in the Get-method since it doesn't seem to be used.
If it needs to be required, then add to the parameter description in comment based help that it is not used in Get-TargetResource.

I do agree - we could convert this (and all other) "Ensure" parameters over to a default value, but I was trying to avoid making any functional changes in this PR. I was restricting myself to only doing style changes to bring it up to guidelines. Happy to change it now, but might be better for another PR. Same goes for the other "Ensure" parameters.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 58 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Why this row? Can't see it is being used anywhere.

Copy/Paste :grin:. Removed.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 267 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Minor: Looping through these seem excessive unless $VerbosePreference -ne 'SilentlyContinue' since the foreach does nothing unless Verbose messages should be outputted? But I'm good keeping it as is too.

Cool. I might leave it as is, only because the DFS implementation on Windows can be a complicated and tricky thing I like to provide as much info for diagnostics as possible (even now I have trouble getting DFS correct :grin: )

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 331 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Minor: Same comment as above

Same as above :grin:

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 341 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Comment block

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 356 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Minor: Same comment as above

As above :grin:

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 529 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Change to $targetFolder

Done. Plus changed all other instances of $target to $targetFolder to match.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 533 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Change to $targetFolder

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 536 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Change to $targetFolder

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 546 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Change to $targetFolder

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 582 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Change to $targetFolder

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 586 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Change to $targetFolder

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 649 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
lower 't'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 690 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
lower 't'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.schema.mof, line 4 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Key - Upper 'K'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.schema.mof, line 5 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Key - Upper 'K'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 3 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This only have one placeholder, but there is two objects sent in.

Wow - amazing catch. I removed the other parameter - it shouldn't be there.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 4 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This only have one placeholder, but there is two objects sent in.

Wow - amazing catch. I removed the other parameter - it shouldn't be there.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 5 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Shouldn't these and most other strings say '..on target...' adding 'on'?

Fair call. Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 8 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This only have three placeholders, but there is four objects sent in.

Fixed.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 10 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

NamespaceFolderCreatedMessage

This is not used

Great catch. Fixed.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 13 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This only have two placeholders, but there is three objects sent in.

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 15 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This only have one placeholder, but there is two objects sent in.

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 18 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This only have one placeholder, but there is two objects sent in.

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 41 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Does Ensure need to be mandatory (Required)? Isn't it enough for it to be Write with a default value of 'Present'?
If it was Write then this parameter would not be needed here in the Get-method since it doesn't seem to be used.
If it needs to be required, then add to the parameter description in comment based help that it is not used in Get-TargetResource.

See previous comments about functional changes. I do think this should be done though - just in a separate PR.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 67 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This is not used anywhere?

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 335 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Minor: Same comment as a comment in another resource

See comment from previous resource.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 399 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Minor: Same comment as a comment in another resource

See comment from previous resource.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 409 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Comment block

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 424 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Minor: Same comment as a comment in another resource

See comment from previous resource.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 585 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Comment block

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 791 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
lower 't'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 832 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
lower 't'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.schema.mof, line 4 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Upper 'K' in Key

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.schema.mof, line 5 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Upper 'K' in Key

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 2 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Should not these and the rest be '...on target...'? If so, then do that for all the strings throughout the module

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 3 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Only one placeholder, but two objects sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 10 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

NamespaceRootCreatedMessage

This is not used

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 13 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Only two placeholders, but four objects sent in

Fixed and fixed.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 14 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Only three placeholders, but four objects sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 16 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Only two placeholders, but three objects sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 19 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Only two placeholders, but three objects sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 14 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
lower 'w' in 'Will'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 19 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Hashtable should be formatted correctly.

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 20 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Hashtable should be formatted correctly.

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 21 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Hashtable should be formatted correctly.

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 49 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
change to 'localhost'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 51 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
change to 'localhost'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 120 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
change to 'localhost'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 122 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
change to 'localhost'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 234 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
change to 'localhost'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 236 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
change to 'localhost'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 33 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Does Ensure need to be mandatory (Required)? Isn't it enough for it to be Write with a default value of 'Present'?
If it was Write then this parameter would not be needed here in the Get-method since it doesn't seem to be used.
If it needs to be required, then add to the parameter description in comment based help that it is not used in Get-TargetResource.

See previous comments about Functional changes (though def agree it should be done).

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 74 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Comment block

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 80 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Should this row be commented? If so, then it could be removed

I've moved these commented parameters into the previous comment as I'm waiting for the above user voice issue to be resolved so I can allow them to be added back in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 81 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Should this row be commented? If so, then it could be removed

See above.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 82 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Should this row be commented? If so, then it could be removed

I've uncommented these.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 222 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 226 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 241 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 242 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 279 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 297 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 317 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 335 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 349 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 361 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 362 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 369 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 375 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 407 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 414 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 425 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 444 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 451 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 610 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 626 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 645 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Change to $primaryMember

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 649 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Change to $primaryMember

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 660 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 700 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 710 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 739 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 751 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 2 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 3 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 4 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 5 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 6 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 8 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 9 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 10 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only two placeholders, but three objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 11 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only two placeholders, but three objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 12 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only two placeholders, but three objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 13 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only two placeholders, but three objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 14 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only two placeholders, but three objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 15 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 16 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only three placeholders, but four objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 17 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only three placeholders, but four objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 18 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 19 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 20 at r3 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.