First Draft of resources

LGTM.
Maybe can add a link in the README.md?

cool project. I'm a critical care nurse. Here some ressource you may look at to answer some of your questions:
-A pulmonologist that (while understanding this is not an FDA approved device) is willing to advise on how to make this more effective as a last resort.***https://pulmccm.org/mechanical-ventilation-review/
-Design modifications to recapture exhaust to minimze addition viral spread. This only works in already "dirty" environments, where there is likely already airborne droplets containing virus - such as quarnateened spaces or other negative air pressure environments.
****https://www.alibaba.com/product-detail/Disposable-Ventilator-filter_926984916.html
-Solutions to prevent the system from becoming unsafe if power is lost. It's not obvious to me on how to do this. Ideas welcome.***https://www.ebay.ca/itm/Power-Gate-Battery-Backup-DC-Power-Switching-System-Power-Pole-Amateur-Ham-Radio/141351712551?hash=item20e937f727:g:0YoAAOSwqu9U59gV
to help with inspiration:https://www.youtube.com/watch?v=Y_92mDYfRGs

Hi, Great project !!!
I have some experience in e-health en fast prototyping and want to help...
Is it possible to get your hands on an M5stick?  or ESP, RPI zero ect to get WIFI so we can make software to talk to it and get reading... (* I can help you setup apps, api ect )
M5STICK is here my advice because of buttons and display on board.
https://m5stack.com/products/stick-c?variant=17203451265114
I will try to make a europian version of parts you used
Also, did you look at some sensors for feedback?

VOC http://wiki.seeedstudio.com/Grove-VOC_and_eCO2_Gas_Sensor-SGP30/
Pressure sensor
O2 meter

You may want to look at this project.  May help finance further production and research.
https://www.agorize.com/en/challenges/code-life-challenge
Robin

Hello @jcl5m1
I have assembled a team from various engineering backgrounds, we are interested in helping you with the TO-DOs, it would be nice if we could get in touch with you via Skype or Zoom.
Email me if possible:
<EMAIL_ADDRESS>

Hi Mr. Lee, We're reproducing your project in Brazil and I'd like to duplicate your repository and translate to Portuguese to avoid misunderstanding here... We are working hard  to be prepared to face the pandemic pick in a few weeks. Do you agree? Congrats.,

Hello dear J. Lee
First of all i want to say Bravo !!! but above all thank you very much for sharing open source. I would like to realize your great project but i have a problem with the fan.
I choose the alternative of using a pump to inflate only i am not 3 pinout but only the + and GND, the motor is marked "HB-166E-RoHS RS-380SH-5021VN"
My question, is it possible used a motor with 2 +12V output cables and GND?
Thank you so much.
(I would share the results if i manage to do your great project)
I wish you good health, peace and happiness.

Hello Col68.
When I search for your blower, I find only the motor.  It is possible that the blower number you are using is actually just the motor part number.  Can you post a picture of the blower?
Motor speed is monitored but I think a pressure sensor could be used to monitor pressure instead of RPM.

Hı RWL-69
Thank you very much for your support, here are the pictures of the ventilation motor.

I wish you happiness.

Hello Col68.
I am correct, the part number is the motor only, not the full blower.
I cannot find the exact model number in my search but I can find the series of motors and they work off a wide variety of voltages and speeds which doesn't help in your case.
From what I have looked at in this project is that the code (third pin) is being used to calculate the pressure from the motor.  It could be used but you would have to modify the code to change the speed of the motor and control the motor due to rates and pressures.  Do you have an idea of flow rate and pressure (cm of H2O)?
It is possible but the control would need to be modified from the original project.  I will have to look at it further to give an exact answer.

Hi dear RWL-69
Respect for your help. I have not tested for flow and pressure (cm of H2O)?
The exact model is like this :
https://www.decathlon.fr/p/pompe-electrique-rechargeable-pour-le-camping/_/R-p-134786
Having seen only two output wires, i suspected that this air blower will be compatible without modification.
Unfortunately i don't have much programming knowledge to modify. I have an L298N module (motor controller) but i have no idea how to integrate it into the project.
I think I will try to find the ideal fan, in any case thank you very much for your support.
Respect to you.

Hi,
I'm trying to build this ventilator with a simple electric inflator pump.
Currently, it is able to reach a 26cm H2O (13cm heigh) at full power. Right now I'm doing a sort of stress test in order to assess its reliability.
One can see the manometer video here:
https://photos.app.goo.gl/s3gQGS5cEDV4YeMaA
Do you think its pressure and control are good enough?

I found this book online for free: 'Principles and Practice of Mechanical Ventilation, 3e' https://accessmedicine.mhmedical.com/book.aspx?bookid=520 . I thought it might help, if you haven't already seen it before.

We provide the best computer science assignment in the world with sophisticated strategies.
https://www.codeavail.com/


Much slower speed of T2T A.thaliana alignment

Hi, @baoxingsong
I just tried using different A.thaliana accessions aligned to the latest Col-0 reference (Col-CC), but I find the speed will be much slower than AnchorWave paper described. If I use TAIR10 as a reference, the alignment could finish in about 20 mins. If I choose the more complete one (added 10Mb CEN178 repeat), AnchorWave will finish in about 2 hours.
Does AnchorWave have any strategy to filter out these highly repetitive regions or very few anchor regions for alignment?

So far, I have not implemented any approach to filter repeat regions.  The time cost for Ara in the manuscript is synthetic genomes. The time cost of AnchorWave is related to sequence diversity, so the de novo genomes are slower compared with synthetic genomes.

Thanks for the explanation!


Submitting CLOB from JS variable

Hi,
This may be an issue with how I'm utilising the plugin, but I've tried the following.
Define a page with the following in Function/Global variable declaration
var sw_test; // try with simple variable

const sw = {}; // try with namespace
sw.test = {
  theClob: '';

  ,setClob:  function(pClob) {

    sw.test.theClob = pClob;
  }

  ,getClob:  function(pClob) {

    return sw.test.theClob ;
  }

};

Execute when page loads
sw_test = 'Here'; // define value with simple variable
sw.test.setClob('There'); // define another value with namespaced variable

Then I try 3 different types of invocation
This successfully returns a value in the PL/SQL code for apex_application.g_clob_01

Submit CLOB From JavaScript Variable
Submit From : sw_test

This has no value in the PL/SQL code for apex_application.g_clob_01

Submit CLOB From JavaScript Variable
Submit From : sw.test.theClob

And this successfully returns a value in the PL/SQL code for apex_application.g_clob_01

Submit CLOB From Function defined in JS initialisation
JS Init:

function(options) {
   options.submitClob = function() { return sw.test.getClob(); }
   return options;
}

Is there anything wrong with my use in the second scenario?
Cheers

Hi,
Thanks for reporting the issue.
There's nothing really wrong with your use in the second scenario per se, it's just "not compatible" with the structure of the plug-in. When the "Submit CLOB" attribute is set to "From Javascript Variable", we try to access the provided variable on the window object, but global const variables are not part of the window object. From MDN:
"...Global constants do not become properties of the window object, unlike var variables..."
The help text will be updated.
And besides that, the plug-in currently does not work with nested objects in the "Submit CLOB" attribute, this is a bug, it'll be fixed in the next release. Until that, your third example can serve as a great workaround!
Thanks

Fixed with 21.2.


Add Missing step in the tutorial

Hello,
landscape Label: both
Sprint Label: SCPTest-2008A
Scenario Label: SCPTest-eboard
Scenario URL: https://developers.sap.com/tutorials/cp-starter-ibpm-employeeonboarding-2-businessrules.html
Step 2.1: Click Design icon and select Import Project from API Business API Hub.->
here, After clicking on Design icon, we first need to click on "import logo" (upload logo) then select "Import Project from API Business API Hub"
Add this step in the document.
thanks,
Shubham

Changes have been adapted
@thecodester - close the issue


Fixes xxxhdpi width and height which was switched

Good catch. Can you switch land as well? They are wrong too.

Whoops... I missed that... Done.

Jeej :tada:! Much appreciated :beers:
Should really add tests for this to check if all widths are greater than the heights in landscape and vice versa.

Sorry for the late released but it is now fixed in 0.1.1.


Reevaluate gradle_build promotion

Reevaluate gradle_build, whether the promoteBuild is presented wrong. It is a home-made curl, not something smart and built into gradle. Maybe we should say that, maybe it shouldn't be there at all.
Perhaps do a disclaimer in the comments of build.gradle, saying that promoteBuild is an example task, and that production systems should use html libraries to do REST calls.

A disclaimer has been added, both in the exercise README and in the code.
In the case where the curl has to be manually run, the task now politely tells the user to run the curl.
Still not the greatest of situations. Not sure I want to close the issue, as the discussion of whether it should be there at all is still valid.
Maybe we want to change it so it always just prints out a curl for the user to run. Then we don't do anything hacky, we just acknowledge that we are not doing this through gradle.


Tags grouping needs to be case-insensitive

Right now tags that start with upper case letters are in their own groups rather than merged with tags that start with lower case letters. Sorting and grouping should not be case sensitive.

I was wrong about this. Tags that have start with the same letter but different case are grouped correctly, but the sorting is done by linkding and it puts the upper case letters first. So the groups and the tags need to be sorted correctly by the app.


Global channel args mutator when creating a client channel

This looks like a good API.  Can you please add a test for it?

Done. PTAL. Thanks @markdroth

Test failure: #20355

@yang-g The global channel arg mutator will also take effect on subchannels since the global args set on grpc_channel will get propagated to its subchannel's. Is it correct?

Right. It is set on client channels and then propagated to the subchannels so that it can be applied to fds.


[Bug]: Stock Split Updates are not handled in bracket orders

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When I make a bracket order of NVDA stock with the below options
1. Order type as 'BUY'
2. Market Buy amount as $1190.00
3. Limit Sell amount as $1210.00
4. Stop loss as $1185.00
5. For 5 shares
And when the stock split happens during off-hours or weekends (assuming 1:10 split)
The order is not updated fully updated and only the share counts are updated as below
1. Order type as 'BUY'
2. Market Buy amount as $1190.00
3. Limit Sell amount as $1210.00
4. Stop loss as $1185.00
5. For 50 shares
Which results in selling 5 shares when the market opens at $119.5 (assuming that the price before split was $1195 when the market opened) as the stop loss condition has met
Expected Behavior
I would expect my conditions as well to get updated along with the stock split numbers as below (assuming 1:10 split)
1. Order type as 'BUY'
2. Market Buy amount as $119.00
3. Limit Sell amount as $121.00
4. Stop loss as $118.50
5. For 50 shares
SDK Version I encountered this issue in
0.23.0
Steps To Reproduce
1. Place a bracket order for XX stock with order type as 'BUY' along with limit sell and stop loss
2. Wait for the stock to get split (either +ve or -ve)
3. The limit sell and stop loss amounts has to be updated along with the number of shares

Filled out the Steps to Reproduce section?

[X] I have entered valid steps to reproduce my issue or have attached a minimally reproducible case in code that shows my issue happening; and understand that without this my issue will be flagged as invalid and closed after 30 days.

Anything else?
Tested in live market

@eric-stanley Thank you for the report.
Seems this issue is not in scope of alpaca-py.
Could you please contact to support? ref. https://alpaca.markets/support


Doesn't show from webPath

Why does it not show images from local webPaths like capacitor://localhost/_capacitor_file_/...?

@Elardzhi i am working for images in the DCIM folder which folder do you want to adress on iOS and on Android

@jepiqueau this webPath capacitor://localhost/_capacitor_file_/.... is returned by Capacitor/Camera. On Android, it should be  http://localhost/......
It would be great if this photoviewer showed images from those webPaths.

@jepiqueau
It opens from file:// it doesn't open from capacitor://

@Elardzhi yes from file: i do not know about capacitor://

@Elardzhi if you want to open an image on android then use code:
this._src = Capacitor.convertFileSrc(data.uri);

@Elardzhi Can you give the full path of image returns by the capacitor/camera plugin

I found this closed issue: #18
So I can update local webPaths the same way.

@Elardzhi fix in 2.04


Custom healthcheck options don't work at role-level

I tried setting a custom log_lines attribute on the role-level, which did not persist to the configuration.
In fact, any custom value I set on the role-level healthcheck did not get accepted into the configuration that gets loaded by kamal. The documentation reads as if this should be working though.
Configs to reproduce:
deploy.yml
service: test

image: test/test-image

registry:
  username: testbot
  password: password

deploy.staging.yml
servers:
  web:
    hosts:
      - staging-server-1
      - staging-server-2
    healthcheck:
      log_lines: 100
      max_attempts: 4

>> kamal config -d staging
---
:roles:
- web
:hosts:
- staging-server-1
- staging-server-2
:primary_host: staging-server-1
:version: [tag]
:repository: test/test-image
:absolute_image: test/test-image:[tag]
:service_with_version: test-[tag]
:volume_args: []
:ssh_options:
  :user: root
  :port: 22
  :keepalive: true
  :keepalive_interval: 30
  :log_level: :fatal
:sshkit: {}
:builder: {}
:logging:
- "--log-opt"
- max-size="10m"
:healthcheck:
  path: "/up"
  port: 3000
  max_attempts: 7
  exposed_port: 3999
  cord: "/tmp/kamal-cord"
  log_lines: 50

Setting it at the top-level health-check succeeds:
deploy.staging.yml
healthcheck:
  log_lines: 100
  max_attempts: 4

servers:
  web:
    hosts:
      - staging-server-1
      - staging-server-2

>> bin/kamal config -d staging
---
:roles:
- web
:hosts:
- staging-server-1
- staging-server-2
:primary_host: staging-server-1
:version: [tag]
:repository: test/test-image
:absolute_image: test/test-image:[tag]
:service_with_version: test-[tag]
:volume_args: []
:ssh_options:
  :user: root
  :port: 22
  :keepalive: true
  :keepalive_interval: 30
  :log_level: :fatal
:sshkit: {}
:builder: {}
:logging:
- "--log-opt"
- max-size="10m"
:healthcheck:
  path: "/up"
  port: 3000
  max_attempts: 4
  exposed_port: 3999
  cord: "/tmp/kamal-cord"
  log_lines: 100

There's another issue that's related due to the healthcheck tied to the primary role and not being role specific. If I try to deploy to a non-primary role without deploying to a primary role, e.g.
kamal deploy -d qa -r=cron
Kamal tries to run a health check against a web role which is not available on the cron host. It looks for .kamal/env/roles/service-web-qa.env which is not available on the host with the cron role.

@fschueller @medius The healthcheck handling changed in Kamal 1.6.0 via https://github.com/basecamp/kamal/pull/740
Can you check if this is still issue for you?

I'll close this now, that healthcheck section has been removed in Kamal 2


Data preprocessing

Hello, your work is fantastic, but I have a few questions. I hope you can provide me with some advice.

How can I transform the dataset saved in the datapreprocessed folder into the dataset inside the datafiles folder?
The README file only provides preprocessing code for the Liver Tumor data. Could you please advise on how to preprocess the other datasets used in the project?

Looking forward to your response. Thank you!

Hi,
Sorry for the late response. I am trying my best to help you reimplement our method.

We generate the datapath of the processed data and save to the datafiles. I added the code to generate those files at the end of datapreprocessing.ipynb, e.g. "Step 5, Generate Datafiles". Hope this can help you generate the datapath for your own datasets.
We provide the download link for other datasets. You might refer to our other projects for the preprocessing code of the other datasets. For example, kidney tumor segmentation, and MRI preprocessing (which should be similar to use for brain tumor/lesion segmentation). Please note you need to generate the binary mask yourself as the preprocessing scripts I mention are developed for other applications.

Best,
Zeju


feat(lnd): update lnd to v0.5-beta-247-g68d96488

Description:
Update lnd to v0.5-beta-247-g68d96488 and enable alternate btcd hosts as lnd now properly supports it.
How Has This Been Tested?
Manually
Screenshots (if appropriate):
Types of changes:
Dependency update
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage increased (+0.01%) to 17.612% when pulling 92a785418d694ea385c1a35d9438b6771536f73c on mrfelton:feat/update-lnd into 029da87a207e9a0d8b560d7499ed7f45176bbf46 on LN-Zap:master.

Coverage increased (+0.01%) to 17.612% when pulling 92a785418d694ea385c1a35d9438b6771536f73c on mrfelton:feat/update-lnd into 029da87a207e9a0d8b560d7499ed7f45176bbf46 on LN-Zap:master.


Feature/659 diagnose verbose

Submisison Checklist

[x] Run tests: ./runCmdStanTests.py src/test
[x] Declare copyright holder and open-source license: see below

Summary:
Added output stmts for:

names of csv files parsed
msgs for each diagnostic;  if diagnostic is OK, outputs "satisfactory" message.
processing completed

Intended Effect:
Always provide output for command - if diagnose command doesn't find problems, then it will print the following message:
Checking sampler transitions treedepth.
Treedepth satisfactory for all transitions.

Checking sampler transitions for divergences.
No divergent transitions found.

Checking E-BFMI - sampler transitions HMC potential energy.
E-BFMI satisfactory for all transitions.

Effective sample size satisfactory.

Split R-hat values satisfactory all parameters.

Processing complete, no problems detected.

How to Verify:
unit tests
Side Effects:
none.
Documentation:
updated cmdstan user's guide accordingly
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

made requested changes to program output.
updated PR description - added example output for model which passes all diagnostics, assigned copyright to Columbia University.

For some reason, I didn't see that @syclik had already started reviewing this.  So take my input as an optional suggestion.  I just approved my change request so it won't block anything.

@syclik - done making changes - please review.
discussed Rhat msg with Ben and Aki at today's Stan meeting.  using constant to allow for future changes.

@syclik - are messages OK?

Sorry--I missed the original notification. Please feel free to ping me again if that happens.
It's approved.

@syclik - thanks!


Omitting system-wide ssh configuration

We're using wetty from a snap package and we have to ignore/omit the system-wide ssh configuration as it may contain any configuration "features" for another version of ssh. Therefore I'd like to introduce a new parameter called --ssh-no-conf to ignore them. In this case I would add the -F /dev/null parameters to the ssh command line that resulting no configuration.
@butlerx What is your opinion? Do you have any better idea?

Im not a big fan of the flag name, but i cant think of a better one.
Please also add the setting to the config.json file at ssh.noConf.
I think we should also surface the ability to specify the path to the system wide conf, would you mind adding this at the same time ?

Oh yes. Maybe it'd be better to add only --ssh-conf configfile and document it properly.
What about that:
  .option('ssh-conf', {
    description: 'Specifies an alternative ssh configuration file. For further details see "-F" option in ssh(1)',
    type: 'string',
  })

Long a bit, but needed... Anything to add?

just to also add it to ensure its added here https://github.com/butlerx/wetty/blob/main/src/shared/interfaces.ts#L1


EWAS: Multiple testing correction

Are the p-values output from meffil.ewas() corrected in some way for multiple testing?

You can find the fdr pvalues in:
names(ewas.ret$analyses)
ewas.ret$analyses$all$table$fdr


Setup Publishing for V3

Easiest would be to just publish to Jitpack.io like we are now but getting into the maven repository would be nicer.

Maven Central publishing will require us to jump through some hoops. A detailed artivle with instructions can be found here


Remove installation of packages

The Dockerfile installs some packages which are not needed to build the
project
Signed-off-by: Manuel Buil<EMAIL_ADDRESS>

This doesn't work on my system. Make is missing dep.

thanks for checking! I made a mistake, we should just remove the linux-headers since I don't think they are needed


when moving an app from DEA to Diego, DEA instances stayed running and routable for hours

Tested on superman.cf-app.com, the routing acceptance environment on AWS, deployed from release-candidate of cf-release, and Diego 1455

on router_z1, watching the /routes endpoint as described on https://github.com/cloudfoundry/gorouter/blob/master/README.md#instrumentation
pushed an app to an env where Diego is the default
cf disable-diego myapp. See that a backend on DEA is added for the route, and backend on Diego is removed
cf enable-diego myapp. See that a backend on Diego is added, and backend on DEA remains
by doing this back and forth, you can accumulate backends on DEAs
I had four backends on DEAs that stuck around for two hours then were cleaned up

I have not been able to reproduce this. Now I'm seeing the DEA backends being cleaned up within a minute or two.
From hm9000_sender.log: https://gist.github.com/shalako/ea27f490ff33a635a56e

After working with @shalako, we determined the issue was due to HM not being fresh. The behavior seen is expected. Once freshness was achieved, the apps were properly removed.


Consider adding support for the TextMate text editor

https://github.com/textmate/textmate
It has a remote editor interface which might be useful.

This is unlikely to happen unless someone builds it. The only officially supported editor is Sublime Text, the rest of them are community builds.


How to run and reproduce experimental results

Hi,
Thanks for this great study. I would like to reproduce you experimental results but I am not sure which file to run to get the experimental results. I followed the instructions from the README file for downloading and extracting files. I ran the train_supervised.py file but got the following error:
FileNotFoundError: [Errno 2] No such file or directory: './data/miniImageNet\miniImageNet_category_split_train_phase_train.pickle'
It would be amazing if you could share how to use your code for reproducing the experiment results or using it for another datasets.
Thank you so much!

Hi @ElifCerenGok, glad that you found it interesting!
The path
'./data/miniImageNet\miniImageNet_category_split_train_phase_train.pickle'
seems to have both / and . I think your system may be using \ to separate directories. If that's the case, you would need to set the path variables such as --data_root to be compatible with your system.
Hope this helps.


Fixes  SNAP-900

Changes proposed in this pull request
this change will fix the failure in junit testSerializables
by updating sanctionedDataSerializables.txt for modified  classes
Patch testing
executed the junit
ReleaseNotes changes
(Does this change require an entry in ReleaseNotes? If yes, has it been added to it?)
Other PRs
NA
(Does this change require changes in other projects- snappydata, spark, spark-jobserver, aqp? Add the links of PR of the other subprojects that are related to this change)
this change will fix the failure in junit testSerializables
by updating sanctionedDataSerializables.txt for modified  classes

@nthanvi  go ahead with merge :)


unsupported protocol scheme ""

Not sure what I am doing wrong:
pan1 := PaloAlto{
			Host: "<IP_ADDRESS>",
			Key: "XXX",  // api key omitted
		}
		err := pan1.CreateAddress("dummy","ip","<IP_ADDRESS>/32","", false)
		if err != nil {
			log.Fatal(err)
		}

Says (removed api key from output):
2017/03/21 08:48:38 Post ?action=set&element=%3Cip-netmask%3E<IP_ADDRESS>%2F32%3C%2Fip-netmask%3E&key=XXX&type=config&xpath=: unsupported protocol scheme ""
exit status 1

Ok, I'll have a look.

I'm trying the same with curl, not sure if xpath below is correct but it does not work too ;)
curl -k 'https://<IP_ADDRESS>/api/type=config&action=set&key=XXX&xpath=/config/devices/entry[@name='localhost.localdomain']/vsys/entry[<EMAIL_ADDRESS>curl: (3) [globbing] bad range specification in column 159

On your initial comment, how are you establishing a session? Based on what you posted, it doesn't look correct. It should be like:
// Parameters are host, user, password
pan1 := panos.NewSession("firewall.yourcompany.com", "admin", "paloalto")
err := pan1.CreateAddress("dummy", "ip", "<IP_ADDRESS>/32", "", false)
if err != nil {
    fmt.Println(err)
}

Can you try that and let me know how it goes? Also, your curl script won't work because you have to post the actual XML as the body of the request.

That worked like a charm..thank you very much, appreciate. I didn't know I have to create session, I thought I can use CreateAddress() method on that PaloAlto struct (without credentials, thru api key only). But know it looks like I don't need that struct at all. Just curious, what is that struct for ?
/*pan1 := PaloAlto{
			Host: "<IP_ADDRESS>",
			Key: "XXX",
		}*/
		pan1session, _ := NewSession("<IP_ADDRESS>", "admin", "password")
		pan1session.CreateAddress("dummy","ip","<IP_ADDRESS>/32","", false)

I love it anyways;)

Glad it worked for you! So, you brought up a good idea, and I think I'm going to add some basic examples to the README file. That way on the main page, people can quickly see how to use it (or at least, establish a session).
The PaloAlto struct is what holds the session information for the device (API key that was generated, platform, software version, etc.). I'll update the main README by tomorrow.


Question: Compatibility with react-custom-scrollbars

Hi,
I opened an issue at https://github.com/malte-wessel/react-custom-scrollbars/issues/30, looking for a way to leverage react-virtualized with react-custom-scrollbars.
As the author @malte-wessel mentioned, this'll require changes in both libraries. He seems keen on making the changes on his end, so I'm hopeful that I can interest you in doing the same? :)

Interesting suggestion @t1mmen. I've commented on the issue you linked, although unless I'm missing something... I don't initially see any changes that react-custom-scrollbars would need to make.

Got a proof-of-concept working in a branch.

Turns out to be easier to just pass the scroll offset properties to the container (since Grid already needs to calculate all of them).

That's looking pretty slick, good work! I'm excited to give it a try in for my project!

Great! :)
I'll try to get it finished up this evening after work. (This is a side project for me so I can't do much with it during the day.)

I completely understand @bvaughn – no rush, just thankful you've decided to take this issue on! Appreciate your hard work :+1:

Just released version 5.5.0 with this feature. Enjoy~
Updated demo: https://bvaughn.github.io/react-virtualized/?component=ScrollSync
Source code: https://github.com/bvaughn/react-virtualized/blob/master/source/ScrollSync/ScrollSync.example.js

Wow, that was quick :) I'll have a look at it!

Sadly, it looks like both libraries do not work well together :( I tried two approaches:

Integrating the Scrollbars component directly into the Grid component here
For any reason only scroll events at the end of the scrolling are recognized by the Scrollbars component. This could be due to the fact that the Scrollbars component wraps the scrollable element and passes the events from there. This approach would also assume that components like Grid would implement the Scrollbars component, which is not desired. It also introduces a new layer between Grid and the higher order components

Wrap the Grid component with Scrollbars
This doesn't work at all, since Scrollbars renders the scrollable element itself and there is currently no way to replace this behaviour.

@t1mmen Nevertheless it should be easy to implement you own scrollbars with the changes in v5.5.0. You only need to render the tracks and thumbs and update their styles like I did here

Quick update to this issue in case anyone else sees it and is curious. react-virtualized now supports a custom renderer prop- renderCellRanges. This function is responsible for rendering (and positioning) the visible range of cells. Its signature is:
function ({
  columnMetadata:Array<Object>,
  columnStartIndex: number,
  columnStopIndex: number,
  renderCell: Function,
  rowMetadata:Array<Object>,
  rowStartIndex: number,
  rowStopIndex: number
}): Array<PropTypes.node>

Grid provides a default implementation of this (obviously) but you can override it if you want to render customized UI along with your cells (eg. gantt chart style overlays, custom scrollbars, etc). Doing it this way is a little more work but it gives you much greater flexibility in what your grid looks like and react-virtualized still manages all of the data windowing for you.
If you're curious, you can see the default implementation here: https://github.com/bvaughn/react-virtualized/blob/master/source/Grid/Grid.js#L729

Hey, thank you for your help guys,
Im having hard times making these 2 packages work together, Im using react-visualized Table component and I dont have renderCellRanges to use and Im kinda lost.
I would love for some help and love, thank you guys ! :)
Great product by the way!

Hi @amitripshtos,
RV Table uses a Grid inside of itself and passes props down to it. It renders headers above the Grid, but those aren't scrollable anyway. So if you want custom scrollbars on the Grid- you should still be able to use the renderCellRanges approach mentioned above.
Maybe something more or less like this?
import { defaultCellRangeRenderer, Table } from 'react-virtualized'

function cellRangeRenderer (props) {
  const children = defaultCellRangeRenderer(props) // Render Table rows
  children.push(
    // Push custom scrollbar container
  )
  return children
}

function renderTableWithCustomScrollbars (tableProps) {
  return (

  )
}

@amitripshtos Were you able to get these two packages to work together? Also having troubles trying to get these to work and can't quite figure it out.

Actually I did not, just gave up and used normal scrollbar :)

Hello to all, and sorry for my english
I tried  to integrate the list of react-virtualized with react-custom scrollbars.
I solved this way, maybe just a little bit tricky :D
import React from 'react';
import { Scrollbars } from 'react-custom-scrollbars';
import {
  AutoSizer,
  List,
} from 'react-virtualized';
import scrollbarSize from 'dom-helpers/util/scrollbarSize';

type Props = {
  items: Array<*>,
  height: number,
  rowRender: Function,
  rowHeight: number,
  lightScrollbar?: boolean,
}

type State = {
  scrollTop: number,
}

export default class VirtualizedListScroll extends React.Component {
  props: Props;
  state: State;

  constructor(props: Props) {
    super(props);
    this.state = {
      scrollTop: 0,
    };
  }

  customScrollBar = null;

  handleCustomScroll = (event: Object) => {
    if (event) {
      const { target } = event;
      if (!(target instanceof HTMLDivElement)) {
        return;
      }
      this.setState({ scrollTop: target.scrollTop });
    }
  }

  handleVirtualizedScroll = (event: Object) => {
    if (event && event.scrollTop) {
      this.setState({ scrollTop: event.scrollTop });
      if (this.customScrollBar) {
        this.customScrollBar.scrollTop(event.scrollTop);
      }
    }
  }

  render() {
    const propsHeight = this.props.height;
    const itemsCount = this.props.items.length || 0;
    const rowRender = this.props.rowRender;
    const rowHeight = this.props.rowHeight;
    const scrollbarColor = this.props.lightScrollbar ? 'rgba(255, 255, 255, 0.3)' : 'rgba(0, 0, 0, 0.2)';
    const scrollBarWidth = ((itemsCount * rowHeight) > propsHeight) ? scrollbarSize() : 0;
    return (
      <AutoSizer disableHeight>
        {({ width }) => (
          <div className="VirtualizedScroll" style={{ heigth: `${propsHeight}px`, width }}>
            <List
              style={{ zIndex: '1', position: 'absolute' }}
              {...this.props}
              width={width + scrollBarWidth}
              height={propsHeight}
              scrollTop={this.state.scrollTop}
              rowCount={itemsCount}
              rowHeight={rowHeight}
              onScroll={this.handleVirtualizedScroll}
              rowRenderer={rowRender}
            />
            <Scrollbars
              className="ScrollContent"
              style={{ height: `${propsHeight}px`, width: scrollbarSize() }}
              onScroll={this.handleCustomScroll}
              ref={scrollbars => { this.customScrollBar = scrollbars; }}
              renderThumbVertical={({ style }) =>
}
            >

            </Scrollbars>

        )}
      </AutoSizer>
    );
  }
}

And this is the CSS
.VirtualizedScroll {
  position: relative;
  overflow-x: hidden;
}

.ScrollContent {
  background: transparent;
  z-index: 2;
  float: right;
}

.ScrollBarContainer {
  width: auto;
}

@enjoyyournoise yeah, yours is too complicated and not that efficient.
I've found that you can just rewrite the Grid's _onScroll method and it will work like a charm. Actually, the only thing preventing on using inner _onScroll in the first place is container node check.
@bvaughn can you maybe add a second parameter to _onScroll that let you pass event from another container?

@bvaughn Hey! I'm back at it again.
Seems like integrating react-custom-scrollbars with Table is a bit tricky, since the Grid component, to which this package should be applied, is obscured inside. Might you suggest way to do it properly?

Was hoping to be able to get custom scrollbars into the table as well. @5angel did you come up with/get any suggestions for solutions around how to do this cleanly? I took a quick peek at the source and it didn't look like there was any easy way to get at wrapping the grid component in the table.

@MrMint yeah, that was my first thought too. Well, there is a way—you might want to add gridrenderer prop, which will pass through the Grid element, allowing you to wrap it in custom scrollbars. That's still a bit hacky and not really useful outside that particular use case, but seems feasible at least.
That's why I asked @bvaughn if he has some thoughts already.

Got react-custom-scrollbars working with react-virtualized.Table using windowScroller. Had to make headerRow fixed to have it always on top, also it should always have background.
Here is the demo: https://codesandbox.io/s/32m23wyo9m


Client supports timeout

FIXES=#28

IIUC, each retry gets an individual timeout. Why's that? Normally, each RPC
is assigned a deadline, after which the answer to the request wouldn't be
interesting anymore. Deadlines are propagated in the context throughout the
system.
Alexander Belyaev<EMAIL_ADDRESS>schrieb am Mi., 8. Aug. 2018,
17:35:

@pifon2a approved this pull request.
Cool, thank you a lot for fixing this.
In async_grpc/client.h
https://github.com/googlecartographer/async_grpc/pull/29#discussion_r208628812
:

@@ -36,6 +37,17 @@ class Client {
using ResponseType = typename RpcServiceMethod::ResponseType;

public:

Client(std::shared_ptr<::grpc::Channel> channel, common::Duration timeout,

    RetryStrategy retry_strategy)

 : Client(channel, retry_strategy) {

timeout_ = timeout;
}

Client(std::shared_ptr<::grpc::Channel> channel, common::Duration timeout)

 : Client(channel) {

timeout_ = timeout;

Why not have an optionalcommon::Duration timeout = absl::nullopt as
default parameter for the constructors. Then you wouldn't have to introduce
2 more constructors. Also, I think it should be possible to initialize
timeout_ in constructor initialization list.
In async_grpc/client.h
https://github.com/googlecartographer/async_grpc/pull/29#discussion_r208629245
:

@@ -71,6 +83,9 @@ class Client {

bool Write(const RequestType &request, ::grpc::Status *status = nullptr) {
::grpc::Status internal_status;

if (timeout_.has_value()) {

Since Reset() has if (timeout_.has_value()), there will be 2 checks if
timeout_ has the value. Can we have only one?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/googlecartographer/async_grpc/pull/29#pullrequestreview-144477575,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFgJgCUacJ4OyMH5c5wAga_n0HgGf1Nfks5uOwVbgaJpZM4V0J8j
.

Closing in favor of another PR.


IPSec tunnel occosionally establishes using wrong IP

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
IPSec tunnels on a HA-setup are randomly using the wrong interface IP to establish the connection.
I have a /29 public IPv4 subnet on a WAN interface. One IP is set up as a virtual CARP IP between two firewalls in a HA-setup.
FW01 - x.y.z.171
FW02 - x.y.z.172
CARP - x.y.z.170 (allow service binding checked)
To Reproduce
Steps to reproduce the behavior:

Configure a IPsec tunnel with a virtual CARP IP
After a while it randomly switches to the non-CARP IP of the interface which is wrong

Expected behavior
It should keep using the virtual CARP IP (in my case x.y.z.170).
Describe alternatives you considered
I had to add additional firewall rules to allow incoming connections to these non-CARP IPs of the individual firewalls as workaround.
Screenshots
All IPsec tunnels are using IKEv2 with the x.y.z.170 virtual IP, however some are connected after a while with the x.y.z.171, as seen below:

Relevant log files
IPsec logs show the 171 (wrong) for incoming and outgoing packets as well.
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 22.1.10 (amd64, OpenSSL).

I had the same problem. Tick "Disable MOBIKE" and you'll be fine ;-)

@Ketanest Thank you for this tip. It seems to be working so far.


VS Code: Hover Service

The tooltips should display additional information depending on the target besides its EMF-class and name. This can include

parameters of annotations
parameters of functions
results of functions
the constructor of classes and its parameters

With the changes to the comment provider and the documentation provider, I'm happy with the information that gets displayed in tooltips now.


Don't merge types of resources

When doing reflection users care about the names of the variable, the
name of the type, and the name of the members.  Remove duplicates breaks
this because it removes the names one of the types when merging.

To fix this we have to keep the different types around for each
resource.  This commit adds code to remove duplicates to look for the
types uses to describe resources, and make sure they do not get merged.

This could have a negative effect on compile time, but it was not
expected to be much.

Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/1372.

Rebased, squashed, and pushed into master as f393b0e480148


nifty-ink-dev local

I tried running nifty-ink-dev branch locally and it doesn't load because it doesn't find a few fields in the graph...
Error! GraphQL error: Type Ink has no field bestPrice GraphQL error: Type Ink has no field bestPriceSource GraphQL error: Type Ink has no field bestPriceSetAt GraphQL error: Type Ink has no field likeCount GraphQL error: Type Ink has no field likes
I guess this is something that needs to be added to the mappings?

Apologies for the delay - I know what this is, will merge in the latest subgraph when I get a moment!

This should now be fixed in this commit https://github.com/austintgriffith/scaffold-eth/commit/488cf5cd9d35bfda7a2e97f4b829e882e847c3b7, but let me know if you still see issues!


Lightsail: Fix Domain does not exist error

@mholt I have a mistake when try merge from origin master. then I have clean it.

@dereknex This message is related to AllocateStaticIp method, and this method is not used in Lego
https://github.com/aws/aws-sdk-go/blob/b2e866cc3d25372c6bde1ce18dbbf11862e954e9/service/lightsail/api.go#L96

@ldez  CreateDomainEntry  method seems to only available in the N. Virginia (us-east-1) Region.
https://github.com/aws/aws-sdk-go/blob/master/service/lightsail/api.go#L1167

@dereknex I think this warning is out of date, but I cannot find any clear information about it.
Maybe you can create an env var to override this value and set the default value to us-east-1.

Without any real source of trust, I restore the constraint on the region.


MediaReplayEnginePluginHelper - '@Decorator.cleanup_tmp_dir()' can have unintended consequences

Afternoon folks,
It would be great to get your input on something we're experiencing. While we've been developing a selection of plugins & testing them locally we've discovered that the decorator function @Decorator.cleanup_tmp_dir() and the function download_media() when utilised may have unexpected behaviour on systems
Function in question
https://github.com/awslabs/aws-media-replay-engine/blob/d5ae4f57a5c3e01e874a84b06cc668bd7ce64c5c/source/lib/MediaReplayEnginePluginHelper/MediaReplayEnginePluginHelper/__init__.py#L344
The usage
https://github.com/awslabs/aws-media-replay-engine/blob/d5ae4f57a5c3e01e874a84b06cc668bd7ce64c5c/source/lib/MediaReplayEnginePluginHelper/MediaReplayEnginePluginHelper/__init__.py#L519
Expected Behaviour
When cleaning up begins, it executes as expected and remove any temporary files associated with application's logical context
Actual Behaviour
The decorator attempts to delete the entire /tmp directory including those files outside of the applications boundaries. This is especially apparent on Mac
Proposal
At the moment, we patch the MediaReplayEnginePluginHelper/__init__.py by hand to use a ./.tmp folder so that it will use a .tmp file local to where the python interpreter is executed, often the root of the project.
Before going head first into a change, we thought it would be best first to discuss how best the MRE team would see best fit to address this issue. My immediate knee jerk I can see there are 2 strong possible candidates:
Proposal 1
Update def download_media to pass the path into the decorator. I'm not entirely sure if this would actually be possible to extract out from the containing function...
Proposal 2
Remove path from def download_media and set them to be the same. Something like this:
@Decorator.cleanup_tmp_dir("/tmp/aws-media-replay-engine/media/")
def download_media(self):
    path = "/tmp/aws-media-replay-engine/media/"

Hi @deadcore , this is interesting! I assume the cleanup decorator with /tmp path becomes an issue only during local testing but not in Lambda's ephemeral storage (since MediaReplayEnginePluginHelper is intended to be built as a layer for Lambda). Nevertheless, I think it makes sense to use a dedicated folder under /tmp for MRE specific functions (such as download_media) and modify the cleanup decorator to clean only this folder so that it doesn't affect the rest of the /tmp directory. We'll look into addressing this as soon as possible and thanks for your patience!

@deadcore: We just released MRE v2.9.0 which addresses this issue. Please feel free to reopen if you have any additional questions. Thanks again for your patience!


FancyZones: Mergable Zones on Drag.

Mergable Zones on Drag.
See the two examples for clearance:
A: Merge Columns
B: Merge Rows
Grid of 3x2
 v 3 Columns
 --- --- ---
|   |   |   |  < 2 Rows
 --- --- ---
|   |   |   |
 --- --- ---

    v A: Drag to here to merge columns
 --- --- ---
|   x   |   |
 --- --- -x-  < B: Drag to here to merge rows
|   |   |   |
 --- --- ---

I would like to be able to create a grid of equal 6 squares. 3 columns and 2 rows.
If I drag a window in the middle area between two rows or columns it would merge them and use them both. For me that would make it not necessary to swap out layouts between different tasks.
Btw, what an amazing utility. Thanks!!

Hi, thanks for the suggestion! This is similar to #335, right? If so, I'll close this issue in favor of the old one.

@mthines, is this in terms of the editor or in terms of an application spanning 2 zones?

if so, we'd dup this against #335, great suggestion BTW

Yes, I think it's quite the same, though I find the other issue explained a little weird.
It's in terms of Applications. Not when setting up the editor, but when using it.
I'd like to create my zones, save. And then when I use it span over multiple :)

@mthines
feel free to add your comments to #335
I'm closing this one as duplicate.
Thanks.


preliminary emoji changes

Tentative proposal for which emoji to use in the outcome strings.
The new set of emojis (in order of severity) is:

:white_check_mark: expected
:grey_question: invalid test
:question: unexpected
:exclamation: unexpected and suspicious

Changes:

:warning: -> :question: as being less confusing

This means the two unexpected outcomes are :question: and :exclamation: which are pleasingly visually similar

dial outcomes in hyperquack are now :grey_question: Am I missing other outcomes that should change to this?
@ramakrishnansr I think you wanted to downgrade more hyperquack outcomes to :question:. Which ones?

Overall Satellite outcomes (source):

Overall Hyperquack outcomes (source):

Perhaps we can call them:
✅ expected
❔ invalid test
❓ unexpected, but inconclusive
❗ unexpected
❓ indicates methodology gaps. Outcomes for which we found issues (we should document them in the sql files). Hopefully we can address most of the issues and turn ❓  into ❗. For example, if we change the scans to only output ServFails that are repeated, we may be able to change it to ❗.  It seems timeouts have improved a lot, we should check if it still returns false positives. And we need to figure out a way to address the CDN blocking external requests.

Ideally, these are the general categories I would put under suspicious for hyperquack:

read/write tcp.reset
read tcp.timeout
content/blockpage:
read http.empty

All the dial and setup failures should be marked as measurement failures. Everything else should get unexpected.

Ideally, these are the general categories I would put under suspicious for hyperquack:

Sounds good. I've implemented that like this.
Resulting in these outcomes:

The main change is that the tls/ and http/ outcomes are now ❓.
read/http_truncated_response is still ❗. But this is such a small outcome I think it's worth it for the simpler case logic it allows.

LGTM. Thanks.


Add caretta to emrgine projects

Requesting to add Caretta to the list of emerging projects.
Caretta's ebpf code is located in https://github.com/groundcover-com/caretta/tree/main/pkg/tracing/ebpf and described in a blogpost: https://www.groundcover.com/blog/caretta

Thanks for the addition! We sort by Github stars so would you mind moving it in between pwru and bumblebee?

sure! updated


Add annotated view of torchexplorer with explanations

Should show pictorially how the histograms are computed

Done with new help.png


Configure setup_requires

Added numpy and cython to setup_requires. This fixes #30.
Poetry builds wheel dist packages for non-PEP-517 source packages in an isolated environment. Thus, there is no easy way to pre-install a package while installing lap using poetry.
Thankfully, there is a way to configure packages required for running the setup using built-in setuptools functionality.

It looks like the build fails for Python 2.7. Is there an intent to continue Python 2.7 support?


Where is the code for Dataset.get() ...?

If I go to http://googlecloudplatform.github.io/gcloud-node/#/docs/v0.14.0/datastore/dataset?method=get
And click the "view code" link (https://github.com/GoogleCloudPlatform/gcloud-node/blob/v0.14.0/lib/datastore/dataset.js#L102) I'm taken to an empty line...
Looking around in the file didn't send me to any code...
Is this method magically injected somehow?

Oh man, the complicated web that is JSDocs + the Docs -> MD + how we rig things up on the FE. A Dataset has a @mixin of the Transaction class, which is where get comes from. http://googlecloudplatform.github.io/gcloud-node/#/docs/v0.14.0/datastore/transaction?method=get
Off the top of my head, I can't think of an easy way to solve for this, but will think on it.

Hmm -- that link seems to lead me astray as well... And I don't see a
method called "get" defined on the Transaction class either....?

Oops, the web gets webbier. Transaction itself has a @mixin on the DatastoreRequest class, which is finally where get lives: https://github.com/GoogleCloudPlatform/gcloud-node/blob/v0.14.0/lib/datastore/request.js#L102

So it got the line number right, but the file wrong. I don't know if that helps make things any easier?

That does, indeed. Let's see what we can do about this...

This was resolved by #584 - I tagged the wrong issue in the PR.


[stable/sealed-secrets] Support PSP

Support PSP with sensible default.

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md
[X] Title of the PR starts with chart name (e.g. [stable/chart])

/retest

/ok-to-test

/lgtm


Invalid completion: package: is suggested after a package:

Thanks for taking a look!

@devoncarew might this be specific to Atom?

I don't think that's likely. Polling @danrubel to see if this sounds familiar.

cc @lukechurch maybe he's seen it?

in Webstorm + DAS I also get some interesting results:

However that specific example, I can't reproduce, I get no completions there in Webstorm:

Seems to do with the colon, before the colon I get this:

On the atom side I think this is a bug fixed in (0.3.11). I can't speak to the IntelliJ issue -

This might be an IntelliJ issue - incorrect handling of variants provided by DAS.

This is working as intended in Dart Plugins for Eclipse. Is IntelliJ using the replacementOffset and replacementLength to determine what characters should be used to filter the suggestion list?

I've fixed the issue at IntelliJ side, will push in minutes.


java client auto updating value cause memory leak

[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Describe the bug
A clear and concise description of what the bug is.
the class ApolloProcessor is used to auto update the config value.
so we must store the bean so that we can update.
BUT,when we use prototype bean to do something,it becomes dangerous.
After creating the bean with beanfactory or applicationContext and doing something,
the bean should be recyclable.BUT now it is store in somewhere(the queue in thread pool or springValueRegistry) with strong refrence.
To Reproduce
Steps to reproduce the behavior:
1. using prototype bean to do something repeatedly
Expected behavior
A clear and concise description of what you expected to happen.
memory leak

I think this was fixed by #1676

I think this was fixed by #1676

thank you!
I should update my client version
by the way.
the spring bean can be recyclable now,but the weakrefrence of the bean not.
should we ignore it as it just use very little space.

I think the same pr also added the clean up mechanism for SpringValue objects
https://github.com/ctripcorp/apollo/blob/4d56835c4979b372bf635eb42db98694d9e9fd7a/apollo-client/src/main/java/com/ctrip/framework/apollo/spring/property/SpringValueRegistry.java#L63

I think the same pr also added the clean up mechanism for SpringValue objects
https://github.com/ctripcorp/apollo/blob/4d56835c4979b372bf635eb42db98694d9e9fd7a/apollo-client/src/main/java/com/ctrip/framework/apollo/spring/property/SpringValueRegistry.java#L63

oh,sorry for my disregard.
I thought it was going to use CopyOnWriteArrayList to make thread safe on regist and removing.


Reduce summary wording

From Rothesay,
Reduce summary wording: Some of the high level statements could be shorter with lots of sentences repeated in a few locations. There is a lot to read through, maybe some boxes at the front of the institutional report that summarises the exposers. I.e. the big take away from UK Sovereigns could be neutral impact, which could be coloured and bolded and then the user can dig into the detail if they choose?

Addressed


knife vsphere vm clone command creates its own vlan standard port group in vCenter, instead of joining the specified --cvlan distrubuted port group

Versions:

Version of knife-vsphere: 2.0.1
Version of chef: 12.19.36

Platform Details

Version of vSphere: 6.5.0
Version of ESXi: 6.5.0

Scenario:
I am trying to spin a vm using the following command
knife vsphere vm clone testVM --dest-folder Chef_Test --template TEST_TMPT --start --cvlan vlan01 --datastore my_datastore --cspec winspec
The above command spins the vm with my customization template options but instead of joining the vlan01 Distributed Port Group(dvSwitch3), Chef creates a completely new vlan01 Standard Network Port Group for itself on the vCenter and adds the vm there.
So as means of this the VM is joined to a completely different Vlan that never existed in the vCenter itself. This causes the VM network adapter settings to stay disconnected and the network connections are failed in short.
Please paste the command and output (run with -VV). Don't forget to X out any passwords or sensitive information:
[root@chefworkstation .chef]# knife vsphere vm clone testVM --dest-folder Chef_Test --template TEST_CHEF_TMPT --start --cvlan VLAN01 --datastore my_datastore --cspec Windows_spec -VV
Cloning template TEST_CHEF_TMPT to new VM testVM
VirtualMachineCloneSpec(
  config: VirtualMachineConfigSpec(
    deviceChange: [VirtualDeviceConfigSpec(
       device: VirtualE1000e(
         addressType: "assigned",
         backing: VirtualEthernetCardNetworkBackingInfo(
           deviceName: "VLAN01",
           network: DistributedVirtualPortgroup("dvportgroup-142")
         ),
         connectable: VirtualDeviceConnectInfo(
           allowGuestControl: true,
           connected: false,
           startConnected: true,
           status: "untried"
         ),
         controllerKey: 100,
         deviceInfo: Description(
           label: "Network adapter 1",
           summary: "my_PortGroup"
         ),
         key: 4000,
         macAddress: nil,
         resourceAllocation: VirtualEthernetCardResourceAllocation(
           limit: -1,
           reservation: 0,
           share: SharesInfo( level: "normal", shares: 50 )
         ),
         unitNumber: 7,
         uptCompatibilityEnabled: false,
         wakeOnLanEnabled: true
       ),
       operation: "edit"
     )]
  ),
  customization: CustomizationSpec(
    encryptionKey: [48,
     *
     *     # Too much numbers were here, removing too make the thread look smaller
     *
     *
     30],
    globalIPSettings: CustomizationGlobalIPSettings(
      dnsServerList: [],
      dnsSuffixList: []
    ),
    identity: CustomizationSysprep(
      guiRunOnce: CustomizationGuiRunOnce(
        commandList: ["net stop myservice",
         "reg delete my_reg_key"]
      ),
      guiUnattended: CustomizationGuiUnattended(
        autoLogon: true,
        autoLogonCount: 1,
        password: CustomizationPassword(
          plainText: false,
          value: "XXX"
        ),
        timeZone: 33
      ),
      identification: CustomizationIdentification( joinWorkgroup: "WORKGROUP"
      ),
      userData: CustomizationUserData(
        computerName: CustomizationVirtualMachineName(  ),
        fullName: "IT Department",
        orgName: "My Organization",
        productId: ""
      )
    ),
    nicSettingMap: [CustomizationAdapterMapping(
       adapter: CustomizationIPSettings(
         dnsServerList: ["10.*.*.1", "10.*.*.2"],
         gateway: ["10.*.*.3", "10.*.*.4"],
         ip: CustomizationFixedIp( ipAddress: "10.*.*.5" ),
         primaryWINS: "",
         secondaryWINS: "",
         subnetMask: "255.*.*.0"
       )
     )],
    options: CustomizationWinOptions( changeSID: true, deleteAccounts: false )
  ),
  location: VirtualMachineRelocateSpec(
    datastore: Datastore("datastore-121"),
    pool: ResourcePool("resgroup-8")
  ),
  powerOn: false,
  template: false
)
Finished creating virtual machine testVM
Powered on virtual machine testVM

Expected Result:

Vm has to build with custom templates and get added to the distributed vlan passed using --cvlan
Actual Result:

Vm builded but it creates its own VLAN instead of joining an existing one

Since it's giving a VirtualEthernetCardBackingInfo I think we're hitting the block here. The code doesn't log anything and the rescue will catch anything, so this could be a variety of things.
Is the VLAN name correct? Is it on a distributed switch? Are there maybe multiple VLANs with that name?
If you can find vsphere_vm_clone.rb you could edit Line 662/663 from this:
   rescue
          # not connected to a distibuted switch?

to this:
  rescue Exception => e
     puts "Couldn't find backing info for the VLAN. I got #{e} instead"

that'll at least tell us why we're getting there.

Hi Sean,
Let me see those changes and get back to you on this.

Hi Swal,

Yes the VLAN name is correct. I can see the exam vlan name as below when i the following command
knife vsphere vlan list

list of vlans

VLAN: VLAN01   # my vlan
*
*

Yes the vlan is on a ditributed switch which vlan01(dvSwitch3)

No there are no multiple vlans of the same vlan number
I made the changes to the vpshere_vm_clone.rb and I got the following error when tried to run the vm clone command

No Title
/opt/chef/embedded/lib/ruby/gems/2.3.0/gems/knife-vsphere-2.0.1/lib/chef/knife/vsphere_vm_clone.rb:647:in rescue in block in generate_clone_spec': uninitialized constant Chef::Knife::VsphereVmClone::Exception  (NameError)         from /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/knife-vsphere-2.0.1/lib/chef/knife/vsphere_vm_clone.rb:635:in block in generate_clone_spec'
from /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/knife-vsphere-2.0.1/lib/chef/knife/vsphere_vm_clone.rb:633:in each'         from /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/knife-vsphere-2.0.1/lib/chef/knife/vsphere_vm_clone.rb:633:in each_with_index'
from /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/knife-vsphere-2.0.1/lib/chef/knife/vsphere_vm_clone.rb:633:in generate_clone_spec'         from /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/knife-vsphere-2.0.1/lib/chef/knife/vsphere_vm_clone.rb:368:in run'
from /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/knife.rb:443:in block in run_with_pretty_exceptions'         from /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/local_mode.rb:44:in with_server_connectivity'
from /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/knife.rb:442:in run_with_pretty_exceptions'         from /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/knife.rb:219:in run'
from /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/lib/chef/application/knife.rb:156:in run'         from /opt/chef/embedded/lib/ruby/gems/2.3.0/gems/chef-12.19.36/bin/knife:25:in <top (required)>'
from /bin/knife:57:in load'         from /bin/knife:57:in '

That's weird. Maybe try rescue => e for that first line? I can try a couple of things when I get into work if that doesn't work out.

Our Infra is currently under a bit of maintenance kind of thing. So I couldnt check anything as of now. Will get back on this a bit later

Hi I am trying the similar cmd for VM Clone and instead of changing the vlan a new vlan is getting created under dvSwitch3. Is the above issue resolved?

Hi, not that I know of. I wasn't able to reproduce the problem. If you want to try adding that debugging output mentioned above, it might help me figure out why it's doing that.

Hi Sea,
Sorry we got stuck with different objectives and so we have to put this on hold. So as per the error we found that our vCetner is designed in a way that everytime a Vlan is changed it would require MAC address to be passed with it which could either be manual or automatic. So specifying the Vlan without mac address is creating a completely different network group in the vCenter
In the above command I passed the MAC address using --cmacs and specified my custom mac address along with vlan and this time the VM got allocated to the existing vLan that we have specified. However we got an error message during VM power on as follows
RbVmomi::Fault: GenericVmConfigFault: Invalid VPX-assigned Ethernet address: 'my_mac_address_here'.
To avoid this error we splitted the VM build operation and it was easy because we have an orchestrator doing all these steps.

Build VM without vlan and take the default vlan from the template
Delete the existing vlan
Add the vlan with the custom mac address
Fetch Ip of the machine and bootstrap with Chef - And these steps work just fine

So the error during power on is something coming from Chef or it's the vCenter issue.

Thanks for the update. What you're seeing is coming from vsphere. I have a feeling that --cmacs option gets used for a couple of different things and you're in a corner case we didn't expect.
Crazy idea here, does it work if you pick a MAC address outside the vmware OID? The only other occurrence of that error message I see in Google comes from a python project where that was one solution. This may be more for curiosity as I don't recommend using a made up MAC, but if it works, maybe I can figure out their eventual solution.

Not exactly. Once the machine is built , I am deleting the old network adapters and replacing them with a new network adapter. It was at this point I specify my VLAN along with my Mac address. This step works fine when the VLAN operation is carried out separately and only becomes a problem when passing both Mac and VLAN using knife vsphere command.


trans a web page failed

trans :fr http://www.w3.org/
sh: https://translate.google.com/translate?hl=zh-CN&sl=auto&tl=fr&u=http://www.w3.org/: No such file or directory
Do you have any suggestions for me？ Thanks~

Thanks for reporting the issue.
Please try out the latest commit (7f181da), which should work on most Linux distros and macOS.


auth:api not working - Redirecting to login page in Postman

I have an Laravel app wherein, my routes file looks like below, but whenever I send a Postman request to store.customer.complaint, I am redirected to the login route rather than sending an unauthorized response :
Route::get('/login', function () {
    return 'Login';
});

Route::group(['prefix' => 'api/v1'], function () {

    Route::group(['prefix' => 'customer'], function () {

        Route::post('register', ['as' => 'register.customer', 'uses' => 'Api\Customer\CustomerController@store']);
        Route::post('login', ['as' => 'login.customer', 'uses' => 'Api\Customer\CustomerController@login']);

        Route::group(['middleware' => 'auth:api'], function () {

            Route::post('complaint', [
                'as'   => 'store.customer.complaint',
                'uses' => 'Api\Customer\ComplaintController@store',
            ]);

        });

    });

});

Postman Screenshot

My suggestion would be to create a duplicate of auth:api middleware, and modify it accordingly to give the response you want.

Send Accept: application/jsonwith Postman

If you see I am giving a application/json in raw body
--
Viraj Khatavkar
On Apr 26, 2016 12:20 PM, "Roman Kinyakin"<EMAIL_ADDRESS>wrote:

Send Accept: application/jsonwith Postman
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/issues/13311#issuecomment-214636575

Ok. I see now. It is not provided in Laravel. You need to modify the middleware and add $request->wantsJson() condition manually.

It is already there in Authenticate.php
--
Viraj Khatavkar
On Apr 26, 2016 1:05 PM, "Roman Kinyakin"<EMAIL_ADDRESS>wrote:

Ok. I see now. It is not provided in Laravel. You need to modify the
middleware and add $request->wantsJson() condition manually.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/issues/13311#issuecomment-214654553

Why is it closed, I am not able to solve it yet.
--
Viraj Khatavkar
On Apr 26, 2016 1:11 PM, "Graham Campbell"<EMAIL_ADDRESS>wrote:

Closed #13311 https://github.com/laravel/framework/issues/13311.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/issues/13311#event-641097583

If you see I am giving a application/json in raw body

I just realized, it is not Accept, but Content-type header

Why is it closed, I am not able to solve it yet.

With respect, this is not a laravel bug, thus we're closing it. Our GitHub is not a support forum.

Sure, not an issue :)
--
Viraj Khatavkar
On Apr 26, 2016 1:49 PM, "Graham Campbell"<EMAIL_ADDRESS>wrote:

Why is it closed, I am not able to solve it yet.
With respect, this is not a laravel bug, thus we're closing it. Our GitHub
is not a support forum.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/issues/13311#issuecomment-214664637

@rkgrep Yes, you were correct, I sent an Accept header, it worked. Thanks for the tip :)
@GrahamCampbell Sorry for the trouble as it was my mistake

I personally for convenience use ForceJson middleware for all api routes:
class ForceJson
{
    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        // Force Json accept type
        if (! Str::contains($request->header('accept'), ['/json', '+json'])) {
            $request->headers->set('accept', 'application/json,' . $request->header('accept'));
        }

        return $next($request);
    }
}

@vedmant that is such a good idea, should get this merged into the main framework.

@GrahamCampbell Say this is not a bug?! This little presumption in code bugged me an hour to find and I now have to find a way to gracefully shut it up.
Why am I forced to accept to redirect to 'login' even if I don't, and explicitly said so in the RedirectTo function? Worst of all, in the process of raising an exception, The Exceptions are meant for the programmer to catch and figure out what's what. I am working on a REST API, but not all users gonna be respectful and send Accept and my API is not going to send them only JSON.

Laravel shoud separate API layer from View layer. Its is very confusing. I cant consume default behaviour becouse i am creating Laravel API and i dont have any Views

Same issue for me I facing 419 error

We really need a clear separation between API usage and normal usage. I've lost a few hours today trying to figure out why Laravel reacts so wrong to my requests. As @khooz said, why am I abusively redirected to login when I use it as an API? Lumen is not a solution. I need functionalities from Laravel for my needs.
auth:api is a joke.

We really need a clear separation between API usage and normal usage. I've lost a few hours today trying to figure out why Laravel reacts so wrong to my requests. As @khooz said, why am I abusively redirected to login when I use it as an API? Lumen is not a solution. I need functionalities from Laravel for my needs.
auth:api is a joke.

So you don't review a default implementation, and just start developing your api. You can also implement your own login functionality by overriding the default one. How is that so difficult? If you don't review something, how come its a bug with framework,

I found top answer here helpful: https://stackoverflow.com/questions/45015586/laravel-request-expectsjson/57758245

@vedmant reply is great, I've a detailed step by step answer on SO here using that middleware pattern with a bit more explanation.

Send Accept: application/jsonwith Postman

This what solved my problem after trying a lot of other ways.

I've lost hours trying to find out:

why validation errors were not retrieving 422 errors and json responses, but apparently trying to return a redirect to '/'
why authentication errors were returning a redirect to the login route instead of simply 401

"Why there's html here?"
Ok i get, i need to add 'Accept: application/json' to ALL requests MANUALLY in any client i use, or i need to make a WORKAROUND to have a middleware to just force only json responses in all my application routes. But it wouldn't be better to have a clear separation between full-stack and back-end development?
I thinks it's nice that we can do both "web" and "api" routes and use them in the same context, but Laravel still lacks a way to build a project that is only supposed to be an api consumed by a client-side application. I know that the main focus is on full-stack development, but i'm sure that having this option would attract more people to Laravel.
PS: Also in the official docs there's no explicit section mentioning these Laravel characteristics related to needs for back-end development presented in an easy way to find. I had to see third party forums to find information about.


Queued upload stuck, restarting the app does not make it start

To reproduce, launch several large multi-uploads in quick succession without waiting for the previous one to finish, then switch off the screen and leave your phone alone for an hour.
Does not happen every time.
https://github.com/commons-app/commons-app-documentation/assets/99590/026c1405-1334-46e9-977c-553cb4462dcc
The only way to "unstuck" them seems to be launching another upload.

@nicolas-raoul just encountered this too was about to report, already looking into it, can I work on it?

@nicolas-raoul I am trying to reproduce it for the second time but am unable to do so, I am yet to reliably reproduce this. Can you please provide some more information on this:

How Many Images you send in one multi-upload
How many times you initiated uploads
What is expected behavior according to you

I think I'm able to reproduce this issue. Looking into it for the solution. Here are details about the contribution (errorInfo was added in this commit https://github.com/commons-app/apps-android-commons/pull/5752/commits/ea483354ebf367ad3844fff3025ff95b85a791a1)
Contribution(media=fr.free.nrw.commons.Media@e8fd88e, pageId=236c86df-d422-422c-89e7-493c113d9ca4, state=4, transferred=1572864, decimalCoords=null, dateCreatedSource=contentProvider, wikidataPlace=null, chunkInfo=ChunkInfo(uploadResult=UploadResult(result=Continue, filekey=1b0uiozv3f5c.7ep8ny.22742.jpg, offset=1572864, filename=null), indexOfNextChunkToUpload=3, totalChunks=5), errorInfo=Unable to resolve host "commons.wikimedia.beta.wmflabs.org": No address associated with hostname, depictedItems=[], mimeType=null, localUri=/data/user/0/fr.free.nrw.commons.beta/cache/CommonsContributions/37ebe133-5568-48d5-8752-d472c6d97c69.jpg, dataLength=2358084, dateCreated=Mon Apr 01 22:30:38 GMT+05:30 2024, dateCreatedString=null, dateModified=Tue Jun 25 00:27:45 GMT+05:30 2024, hasInvalidLocation=0, contentUri=content://com.android.providers.downloads.documents/document/msf%3A1000083847, countryCode=null, imageSHA1=a5ef6d18b30f8de7ca918be159db617c2e71a9a1, retries=2)

The upload was started by Auto Retry

Even after 10 mins upload seems to be stuck in queue state

I launched a new upload in order to see if it make it unstuck

But the upload is stuck there only


Update ApplicationConfig tests and other fixes

This has many test updates:

Updates AzConfigTests to use StepVerifier rather than block().
Fixes issue where InterceptorManager.java was not properly deserialising HttpResponses with no body (it was returning null)
Fixes AzConfigTests to clean-up after itself for each test-case (so we don't pollute ApplicationConfig with random values).
The *.json files can be ignored, they are the updated session-records after I re-ran those live tests.

Dependency updates:

Adds v3 runtime to pom.client.xml with a TODO to update version when it ships
Adds reactor-test

Other:

Adds ApplicationConfig to spotbugs and check-style.

I apologise for the large PR, I got too excited fixing things whenever I saw an issue. But it uncovered a lot more issues. :/

Can one of the admins verify this patch?


[PROPOSAL] Ability to unbind some method

Would be nice to have an ability to unbind some special functions from instance. Make it static.

@Johnius Thinking my PR #27 solves this for you.

@cpsubrian It looks working but I think you'll face problems when your class will get grow. I think still would be sweet to have @unbind and use it on specific methods. Maybe you have some thoughts about why it might be good or bad—about your and my idea.

@Johnius I can't speak to your use case, but I'm always in one of three situations:

You want most of your methods autobound, and few not bound.

The ones you don't want bound usually follow a semantic pattern (i.e. 'render', 'component*')

You want to routinely bind only methods that follow a semantic pattern (i.e. 'handle*', 'on*')
You only want to bind a few specific methods

In this case just use @autobind on those methods

I would personally find a mix of @autobind and @unbind hard to follow/remember. But my main use-case is either React components or custom 'Model' classes. Both of these follow repeatable patterns.
I wonder what your use case is for a large class that wants a scattering of methods unbound. If I understood that better I could weigh in on it :smile:

see #27


Provide SSL security policy

Fixes the following error:

aws_elastic_beanstalk_environment.default: Error waiting for Elastic Beanstalk Environment (e-kiusnj9mi2) to become ready: 2 errors occurred:

2019-05-10 12:08:15.882 +0000 UTC (e-kiusnj9mi2) : Stack named 'awseb-e-kiusnj9mi2-stack' aborted operation. Current state: 'CREATE_FAILED'  Reason: The following resource(s) failed to create: [AWSEBV2LoadBalancerListener443].
2019-05-10 12:08:15.983 +0000 UTC (e-kiusnj9mi2) : Creating Load Balancer listener failed Reason: An SSL policy must be specified for HTTPS listeners (Service: AmazonElasticLoadBalancingV2; Status Code: 400; Error Code: ValidationError; Request ID: 43157996-731c-11e9-891f-117f22424633)

Which has been reported as an issue on the upstream project: https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/issues/81

Addresses https://github.com/cloudposse/terraform-aws-jenkins/issues/46

Review comments addressed.

Can we please merge this fix?

@aknysh Is it now ok?

Please, backport to 0.6.0 and upgrade registry.

/test all

Thanks for the update @richardj-bsquare ! Sorry for the long wait. I made some updates in order to expose this input to this module.


Feature Request: Add RunCriterias for running vs exiting app

What problem does this solve or what need does it fill?
When an application exits, there is a frame after the window closed. This caused a bug in bevy_flycam which had systems that unwrapped the primary window (on that last frame, it fails to get the window and crashes). This is now fixed and it instead prints warnings when it can't find a window. However, these warnings are unnecessary when exiting the application. It would be nice if the systems didn't run when the application is exiting.
What solution would you like?
It would be nice if Bevy could provide RunCriteria for systems that run only while the application is running and also the opposite, for systems that only run when it is exiting.
They could be called run_if_running and run_if_exiting (I know RunCriteria is being reworked to use bool; I don't know if that will allow for combining/modifying them, but if so, run_if_exiting could just be !run_if_running)
I have tried to create such a system by reading AppExit events and storing the state in a resource, but to no avail.
I'm not sure how Bevy runs RunCriteria, but I imagine it could run each one once (or will with stageless ECS?), which means that upstreaming this behavior means that crates won't have duplicate systems.
What alternative(s) have you considered?
I know there is a lot of changes coming with stageless ECS so maybe there is a future solution I don't know about.

the specific issue with extra frame on window closed should be fixed by https://github.com/bevyengine/bevy/pull/5558

Ah, OK, then there is no need for this.


[Sparrow GUI - UI] Separate dialog boxes better from underlying UI

Minor issue but still...
On:

Sparrow 1.8.2
Linux Ubuntu flavor 22.04 LTS
Dark mode

Request:

Give dialog boxes (e.g. transaction details, About page) a border color to separate them from the background UI

-> No separation gives strange "embedded" look

-> Better separation by clearly visible border

What window manager are you using? Here's what I get on Ubuntu 22.04 running GNOME:

I' have still the older X11:
requestprivacy@vm:~$ xdpyinfo | grep version
version number:    11.0
X.Org version: <IP_ADDRESS>

Ok, I've added a light border. Frustrating that some window managers handle this situation so poorly. 1d32b693.


Fix broken Discord link

Checklist:

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the master branch of freeCodeCamp.
[X] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #XXXXX

It looks like #40015 added a Discord invite link that expired. I've replaced the link with the non-expiring one that Mrugesh created.
The link is present in the translated files as well - should I replace those? Or will that be done by the translation platform?

Thanks @nhcarrigan ! Yes go ahead and replace accross all files.

Sure thing~! I will update this PR in just a moment.


Zip fails on nested folders

Hi,
I am exploring the use of AWS CodePipeline for our python beanstalk applications. The order of operations in the Jenkins project:

AWS CodePipeline Source Code Management
Execute shell:

create virtualenv
activate virtualenv
pip install requirements
run tests
deactivate

AWS CodePipeline Publisher

And always get error:
[AWS CodePipeline Plugin] Publishing artifacts
[AWS CodePipeline Plugin] Compressing Directory '/var/lib/jenkins/workspace/myproject' as a 'Zip' archive
[AWS CodePipeline Plugin] /var/lib/jenkins/workspace/myproject/lib/python2.7/config (Is a directory)
[AWS CodePipeline Plugin] Stacktrace:
[AWS CodePipeline Plugin] java.io.FileInputStream.open(Native Method)
[AWS CodePipeline Plugin] java.io.FileInputStream.<init>(FileInputStream.java:146)
[AWS CodePipeline Plugin] com.amazonaws.codepipeline.jenkinsplugin.CompressionTools.compressArchive(CompressionTools.java:162)
[AWS CodePipeline Plugin] com.amazonaws.codepipeline.jenkinsplugin.CompressionTools.compressZipFile(CompressionTools.java:90)
[AWS CodePipeline Plugin] com.amazonaws.codepipeline.jenkinsplugin.CompressionTools.compressFile(CompressionTools.java:64)
[AWS CodePipeline Plugin] com.amazonaws.codepipeline.jenkinsplugin.PublisherCallable.invoke(PublisherCallable.java:78)
[AWS CodePipeline Plugin] com.amazonaws.codepipeline.jenkinsplugin.PublisherCallable.invoke(PublisherCallable.java:34)
[AWS CodePipeline Plugin] hudson.FilePath.act(FilePath.java:990)
[AWS CodePipeline Plugin] hudson.FilePath.act(FilePath.java:968)
[AWS CodePipeline Plugin] com.amazonaws.codepipeline.jenkinsplugin.AWSCodePipelinePublisher.callPublish(AWSCodePipelinePublisher.java:163)
[AWS CodePipeline Plugin] com.amazonaws.codepipeline.jenkinsplugin.AWSCodePipelinePublisher.perform(AWSCodePipelinePublisher.java:129)
[AWS CodePipeline Plugin] hudson.tasks.BuildStepMonitor$2.perform(BuildStepMonitor.java:32)
[AWS CodePipeline Plugin] hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:782)
[AWS CodePipeline Plugin] hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:723)
[AWS CodePipeline Plugin] hudson.model.Build$BuildExecution.post2(Build.java:185)
[AWS CodePipeline Plugin] hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:668)
[AWS CodePipeline Plugin] hudson.model.Run.execute(Run.java:1763)
[AWS CodePipeline Plugin] hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
[AWS CodePipeline Plugin] hudson.model.ResourceController.execute(ResourceController.java:98)
[AWS CodePipeline Plugin] hudson.model.Executor.run(Executor.java:410)
[AWS CodePipeline Plugin]

Trying lots of things, the only thing to help was to run:
zip -rm ./myapp.zip .
unlink lib64
rm -r lib
rm -r include

right before the Publisher. The version was delivered successfully but since it's double zipped the app can't run. Any suggestions?

Hi,
Thanks for bringing this to our attention, we'll take a look at the error you're getting. Are you using version 0.10 of the plugin?

Yes, version 0.10.

We've identified the problem and are working on a fix. I'll post an update once the fix is rolled out.

It might take a couple of hours for version 0.11 to be available in the Jenkins mirrors, but it should fix the compression error. Please feel free to reopen this issue if it does not.


feat!: make graphene-federation compatible with graphene v3

(approved by mistake, doing a real review now)


Xcode 7 UIAutomation Support

It would be great if you could add support for running Xcode UIAutomation using xctool.  Currently, the tests are built but as they are not built into xctest they cannot be run.

We aren't currently looking into this. But we will be happy to review any PR.

Let's switch to this issue, @sampham.
The branch https://github.com/facebook/xctool/tree/nekto/support_ui_testing has all the most recent updates I have. To be honest I don't remember what exactly didn't work there. I think I stopped when I couldn't figure out why tests aren't triggered to run. I tried to repeat all the steps Xcode does when launching UI tests and turned off "wait for debugger" flag. I saw mostly the same output of Simulator in system logs as the one that is produced when tests are run from Xcode though. But the tests weren't simply starting (I've added several NSLogs statements to a sample app I was using for testing and didn't see them being executed).
If I look into it again I would try running UI tests from xcodebuild (if it supports them). Also I will probably try avoiding usage of XCTRunner. Probably it is the one which causes problems.

yes, xcodebuild supports running UI Test. You need to create a scheme for that: https://krausefx.com/blog/run-xcode-7-ui-tests-from-the-command-line

I believe entire iOS development community is waiting for this support to be added. We really need this!

FYI: It will only work with the simulator though.

On Sep 30, 2015, at 9:28 AM, K76154<EMAIL_ADDRESS>wrote:
I believe entire iOS development community is waiting for this support to be added. We really need this!
—
Reply to this email directly or view it on GitHub.

:+1:

I will be happy to support anyone who is ready to work on it. At Facebook we are using our own infrastructure (see https://github.com/facebook/webdriveragent) to run E2E tests and as a result we aren't going to work on this feature in the nearest future.

Does the webdriver agent work with the new XCode 7 UI test? Or it only works with the old javascript UIAutomation? And how do you launch the simulator and the app automatically?

webdriveragent links with the underlying UIAutomation private objective-c framework, there is no JS involved.

There are two ui testing frameworks provided by Apple after xcode 7. One is the new xcuiapplication based tests, the other one is the old uiautomation framework. Which one does the webdriver support? I think what people wants is the support for the new xcode 7 xcuiapplication based automation.

I would better ask these questions at the project pages. cc @mmmulani

we use FBSimulatorControl (also a project on GitHub) to start up the simulator and the WebDriverAgent to automate it.
we don't support straight up UIAutomation commands but instead implement the web driver spec

@ExtremeMan I found that if I run the xcode 7 ui test with xcodebuild and custom symroot, the test will not run. It says the target app can't be found, and it really didn't install it on the simulator. I guess xctool somehow uses custom symroot implicitly, so it has the same problem. If you are seeing the no target app error, try use default symroot path.

@K76154 I was able to get xcode 7 ui test to run with xcodebuild and a custom symroot.  2 things I am doing that may help you.  1. In the symroot, I am putting the full path (so using ${PWD}) which it wasn't working without.  The other thing is doing a build command before the test command, there is a chance in you test configuration it is not setup to build the app as well.

hi. is there no news about support XC UI Testing? (Xcode7)

I have dig a little bit into the problem with UI Tests. Here is what I have found:

They are not 'regular' xctests, they are getting bundled into the special Runner. This is achieved by adding the user defined build settings; USES_XCTRUNNER=YES and TEST_TARGET_NAME=
However xctool treats them as regular xctest and tries to read xctest bundle from the default location. This might be the main failure cause.

XCTRunner app bundle:
XctoolUITestsSupprot.app
├── Frameworks
│   └── XCTest.framework
│       ├── Headers
│       └── ...
├── Info.plist
├── PkgInfo
├── PlugIns
│   └── XctoolUITestsSupprotUITests.xctest   <--- Your real xctest bundle
│       ├── Frameworks
│       │   ├── libswiftContacts.dylib
│       │   └── ...
│       ├── Info.plist
│       └── XctoolUITestsSupprotUITests
├── XCTRunner   				<--- Runner executable
└── _CodeSignature
    └── CodeResources

I want to try to fix this issue in xctool. Can someone please give me some direction where to start with or any other suggestions?
P.S. I have collected all the possible logs and bundles and can share or help getting more info if needed

@anton-matosov, thanks for the details. Have you looked into the branch I mentioned? I've already fixed querying of test cases there (see commit https://github.com/facebook/xctool/commit/118c30fe75345df537f63860bb1c69fee5038f40).

I have missed your branch @ExtremeMan, thanks for pointing it out.
I will base my future work on your changes.

(y). Wondering what happens if to set USES_XCTRUNNER=NO. I stopped on trying to launch tests and might be because of I wasn't properly calling to xctrunner.

I have found the the following difference between xctrunner and default/xctool custom test runners:
xctrunner starts the main app bundle (TEST_TARGET_NAME) before while executing first:
13:12:34.543 XCTRunner[83093:14343720] _IDE_startExecutingTestPlanWithProtocolVersion:16
Test Suite 'All tests' started at 2015-11-08 13:12:34.568
Test Suite 'XctoolUITestsSupprotUITests.xctest' started at 2015-11-08 13:12:34.569
Test Suite 'XctoolUITestsSupprotUITests' started at 2015-11-08 13:12:34.570
Test Case '-[XctoolUITestsSupprotUITests.XctoolUITestsSupprotUITests testExample]' started.
    t =     0.00s     Start Test
    t =     0.00s     Set Up
    t =     0.01s         Launch com.auction.XctoolUITestsSupprot      <------------ HERE
2015-11-08 13:12:34.894 XCTRunner[83093:14343707] Continuing to run tests in the background with task ID 1
    t =     1.07s             Waiting for accessibility to load
    t =     5.13s             Wait for app to idle

and continues to run in the background.

So we might try to run tests hosted in the app bundle itself (not 100% sure that it will work, there might be a good reason why Apple invented new runner for this)

@ExtremeMan is there a way to run xctool directly from Xcode instead of attaching to it?
I get the following error if try to simply run it
ERROR: Failed to launch reporter process /Users/amatosov.ctr/Library/Caches/AppCode33/DerivedData/xctool-aff12441/Build/Products/Debug/reporters/pretty: launch path not accessible

Yes, you should be able to directly run xctool from Xcode. I have never seen error you posted. May be try rebuilding/cleaning?

never mind, i have opened project, not workspace 😊

I have found the there is one more participant in the UI tests testmanagerd
Nov  8 15:19:50 Amatosov-MBP testmanagerd[89368]: Launched testmanagerd from /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/usr/libexec/testmanagerd, built at Friday, October 9, 2015 at 4:42:58 PM Pacific Daylight Time
...
Nov  8 15:19:53 Amatosov-MBP XCTRunner[89409]: Running tests...
...
Nov  8 15:19:53 Amatosov-MBP testmanagerd[89368]: Received new test session connection (-[XCTestManager listener:shouldAcceptNewConnection:])
...
Nov  8 15:19:53 Amatosov-MBP testmanagerd[89368]: -[XCTestManager allowUITestControlForPID:] 89409 vs 89409
Nov  8 15:19:53 Amatosov-MBP testmanagerd[89368]: Got application state update: com.auction.XctoolUITestsSupprot (89343) -> 8
Nov  8 15:19:53 Amatosov-MBP testmanagerd[89368]: -[XCTestManager allowUITestControlForPID:] 89409 vs 89409
...
Nov  8 15:19:55 Amatosov-MBP testmanagerd[89368]: -[XCTestManager allowUITestControlForPID:] 89409 vs 89409
Nov  8 15:19:55 Amatosov-MBP testmanagerd[89368]: Terminating com.auction.XctoolUITestsSupprot
Nov  8 15:19:55 Amatosov-MBP testmanagerd[89368]: PID for com.auction.XctoolUITestsSupprot: 89343
Nov  8 15:19:55 Amatosov-MBP com.apple.CoreSimulator.SimDevice.42A954DB-BBD9-4970-8BAC-5FEF9F6B0EC8.launchd_sim[85263] (UIKitApplication:com.auction.XctoolUITestsSupprot[0x8630][89343]): Service exited due to signal: Killed: 9
Nov  8 15:19:55 Amatosov-MBP SpringBoard[85280]: Application 'UIKitApplication:com.auction.XctoolUITestsSupprot[0x8630]' exited abnormally via signal.
Nov  8 15:19:55 Amatosov-MBP testmanagerd[89368]: AX Notification 1021
Nov  8 15:19:55 Amatosov-MBP testmanagerd[89368]: Got application state update: com.auction.XctoolUITestsSupprot (89343) -> 1
Nov  8 15:19:55 Amatosov-MBP testmanagerd[89368]: AX Notification 1021
Nov  8 15:19:55 Amatosov-MBP CoreSimulatorBridge[85288]: Requesting installation of file:///Users/amatosov.ctr/Library/Developer/Xcode/DerivedData/XctoolUITestsSupprot-fqplloyqdpyjphecyzimidatfiql/Build/Products/Debug-iphonesimulator/XctoolUITestsSupprot.app/ with options: {
	    CFBundleIdentifier = "com.auction.XctoolUITestsSupprot";
	    PackageType = Developer;
	    SimulatorRootPath = "/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk";
	    SimulatorUserPath = "/Users/amatosov.ctr/Library/Developer/CoreSimulator/Devices/42A954DB-BBD9-4970-8BAC-5FEF9F6B0EC8/data";
	}
...

Nov  8 15:19:59 Amatosov-MBP testmanagerd[89368]: AX Notification 4002
Nov  8 15:19:59 Amatosov-MBP testmanagerd[89368]: Got user testing notification with payload {
	    controllerClass = "XctoolUITestsSupprot.ViewController";
	    event = ViewDidAppear;
	}
...

Nov  8 15:19:59 Amatosov-MBP testmanagerd[89368]: Tearing down test session <XCTestSession: 0x7c429440>.
Nov  8 15:19:59 Amatosov-MBP testmanagerd[89368]: testmanagerd exiting, idle with no test activity.
Nov  8 15:19:59 Amatosov-MBP testmanagerd[89368]: Considering exiting, 0 test sessions, 0 sessions with identifiers, 0 unidentified sessions...

So it is testmanagerd who does the coordination between XCTRunner and main application bundle
testmanagerd is getting launched by Xcode and xcodebuild as very first step of running tests.
It seems that it is a must have piece for the UI Tests,

After several days of tries, I still can't find the way to make XCTRunner work w/o testmanagerd. And can't make testmanagerd run w/o xcodebuild.

While researching the issue I have found this opensource toolkit called fastlane that beats xctool from groundup. As part of the toolkit there is tool called scan that allows to run tests including UI tests and it is 100% forward compatible as it wraps xcodebuild + xcpretty command line

It's different, because xctool lets you to separate build and test, so you can build once and test many times. Fastlane uses xcodebuild, which has to build and test in a same command, and that sometimes is not what people want.

@anton-matosov I've been playing around with testmanagerd myself whilst trying to get https://github.com/facebook/FBSimulatorControl to launch XCTest bundles. You can start testmanagerd using simctl. I've got a SO question which has the steps I took whilst trying to get simctl to launch an XCTest bundle as a precursor to getting FBSimulatorControl to do the same thing: http://stackoverflow.com/questions/33633882/run-xctest-bundle-with-simctl

I'm somewhat aware of the challenges that testmanagerd places on running tests directly. Last time I checked you end up having to launch the tests with the DVT frameworks rather than simply launching processes like can be done with Application Tests and code injection. I think most of this boils down to the DVT frameworks opening a socket with testmanagerd.

cc @marekcirkos who is also working on a solution for launching UITests directly.
If there is some magic that will enable us to launch UITests without going through xcodebuild/ the DVT frameworks and launch the tests directly (like with the xctest cli) that will be something that we'd want to add to FBSimulatorControl. The same applies for multisim support.

@lawrencelomax Am I correct to assume that there are no plans to provide similar support for physical devices?

It is possible to run the XCode UI Tests with xctool? I tried this command line:

/pathto/xctool -workspace APP.xcworkspace -scheme "APPScheme" test -only UITestsTarget:UITestsClass/UITestsMethod

and i got this error:  ...ERROR: build-tests: 'E-UITestsTarget' is not a testing target in this scheme.

Looks like AWS device farm claimed to support Xcode 7 UI Test: http://docs.aws.amazon.com/devicefarm/latest/developerguide/test-types-ios-xctest-ui.html

@johnbill Does that really work?

You can use XCTestBootstrap which is part of FBSimulatorControl to launch xcuitests. We use it to launch  https://github.com/facebook/WebDriverAgent on simulators and devices. It might not report test results,but that should not be difficult to add :).

You can also use fbsimctl which is also part of FBSimulatorControl to start xcuitests from command line.

Am I correct to assume that there are no plans to provide similar support for physical devices?
XCTestBootstrap in isolation should provide support for launching on Devices. XCTestBootstrap  has no awareness of FBSimulatorControl but linking with some of the XCode frameworks allows it to do it's magic.

The API may not be as convenient as is currently the case for launch_xctest on fbsimctl, but we don't have anything specific to announce around Open-Sourcing of fbsimctl for devices. It is something that we want to do, but I can't make any firm commitments. It shouldn't take much to wrap up the XCTestBoostrap API in a simple CLI app for targeting Devices. cc @marekcirkos to confirm that this is feasible.

It (fbsimctl) might not report test results,but that should not be difficult to add :).
fbsimctl doesn't currently have a way of redirecting output from launched processes. If the Application into which the XCTest bundle is injected reports test results over stdout/stderr this should be easy for us to pass in a file handle and redirect output to the fbsimctl command line.

Is there any tool that currently allows to run a XCTest UI test individually, as opposed to the whole suite, like xctool does?. I looked at fastlane/scan, and while it is a very nice wrapper of xcodebuild with xcpretty that also handles many other issues, it is limited to xcodebuild capabilities, meaning you have to build and then test, and also you cannot run individual tests or classes.

Is there any tool that currently allows to run a XCTest UI test individually, as opposed to the whole suite, like xctool does

Not yet, but I've been playing with getting XCTestBoostrap working with Application tests with a full reporting interface. It connects directly to the testmanagerd service running on the Device/Simulator and receives all the progress callbacks that Xcode/xcodebuild receives. If you pour through the code there, you should see some interesting stuff.

@lawrencelomax Thanks for the update, I will take a look at XCTestBoostrap, sounds promising.

Any updates on this? Has anyone dig through to support this?

xcodebuild 8+ has 2 new actions build-for-testing and test-without-building
tools like plu/pxctest leverage this to allow running tests in multiple simulators at the same time
@oscarmk1 you can use schemas to run individual tests based on name or class

Better late than never. But I have just pushed changes which should add UI testing support. Let me know if it doesn't work for your use case.