Reserved service name errors when building Toaster KMDF samples

I'm experiencing the following errors when attempting to build the general\toaster\toastDrv KMDF projects with Visual Studio 2022:
>------ Build started: Project: dynambus, Configuration: Debug x64 ------
>Building 'dynambus' with toolset 'WindowsKernelModeDriver10.0' and the 'Universal' target platform.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\bus\dynamic\dynambus.inx(64-64): error 1293: Service name 'dynambus' is reserved.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\bus\dynamic\dynambus.inx(75-75): error 1293: Service name 'dynambus' is reserved.

>------ Build started: Project: StatBus, Configuration: Debug x64 ------
>Building 'StatBus' with toolset 'WindowsKernelModeDriver10.0' and the 'Universal' target platform.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\bus\static\statbus.inx(64-64): error 1293: Service name 'statbus' is reserved.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\bus\static\statbus.inx(75-75): error 1293: Service name 'statbus' is reserved.

>------ Build started: Project: filter (Kmdf\Filter\Generic\filter), Configuration: Debug x64 ------
>Building 'filter' with toolset 'WindowsKernelModeDriver10.0' and the 'Universal' target platform.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\filter\filter.inx(76-76): error 1293: Service name 'ToasterFilter' is reserved.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\filter\filter.inx(77-77): error 1293: Service name 'wdffeatured' is reserved.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\filter\filter.inx(96-96): error 1293: Service name 'ToasterFilter' is reserved.

>------ Build started: Project: filter (Kmdf\Filter\Sideband\filter), Configuration: Debug x64 ------
>Building 'filter' with toolset 'WindowsKernelModeDriver10.0' and the 'Universal' target platform.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\filter\filter.inx(76-76): error 1293: Service name 'ToasterFilter' is reserved.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\filter\filter.inx(77-77): error 1293: Service name 'wdffeatured' is reserved.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\filter\filter.inx(96-96): error 1293: Service name 'ToasterFilter' is reserved.

>------ Build started: Project: wdffeatured, Configuration: Debug x64 ------
>Building 'wdffeatured' with toolset 'WindowsKernelModeDriver10.0' and the 'Universal' target platform.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\func\featured\wdffeatured.inx(72-72): error 1293: Service name 'wdffeatured' is reserved.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\func\featured\wdffeatured.inx(82-82): error 1293: Service name 'wdffeatured' is reserved.

>------ Build started: Project: wdfsimple, Configuration: Debug x64 ------
>Building 'wdfsimple' with toolset 'WindowsKernelModeDriver10.0' and the 'Universal' target platform.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\func\simple\wdfsimple.inx(75-75): error 1293: Service name 'wdfsimple' is reserved.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\func\simple\wdfsimple.inx(85-85): error 1293: Service name 'wdfsimple' is reserved.

>------ Build started: Project: wdftoastmon, Configuration: Debug x64 ------
>Building 'wdftoastmon' with toolset 'WindowsKernelModeDriver10.0' and the 'Universal' target platform.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\toastmon\wdftoastmon.inx(22-22): error 1284: Class "Sample" is reserved for use by Microsoft.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\toastmon\wdftoastmon.inx(40-40): error 1285: Cannot specify [ClassInstall32] section for Microsoft-defined class.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\toastmon\wdftoastmon.inx(62-62): error 1293: Service name 'wdfToastMon' is reserved.
>C:\Windows-driver-samples\general\toaster\toastDrv\kmdf\toastmon\wdftoastmon.inx(72-72): error 1293: Service name 'wdfToastMon' is reserved.

It would be great if your could fix these errors so that the samples build out-of-the-box. Alternatively, clearly document how to rename the services. The reason for asking is that it's unclear to me if it's sufficient to change the service name, or if the SYS and INX/INF files also need to be renamed.

Even after renaming all the ones for which the errors were reported, there's this error:
Severity	Code	Description	Project	File	Line	Suppression State Error	1284	Class "Sample" is reserved for use by Microsoft.	wdftoastmon	C:\Users\nBase2\Git\repos\Windows-driver-samples\general\toaster\toastDrv\kmdf\toastmon\wdftoastmon.inx	22
And if I change "Sample" to "Sample1", it reports this error:
Severity	Code	Description	Project	File	Line	Suppression State Error	1280	Class name and ClassGuid mismatch, expecting Class "Sample" for ClassGuid "{78A1C341-4539-11d3-B88D-00C04FAD5171}".	wdftoastmon	C:\Users\nBase2\Git\repos\Windows-driver-samples\general\toaster\toastDrv\kmdf\toastmon\wdftoastmon.inx	22
Basically, we need more details to overcome this error.

And if I change "Sample" to "Sample1", it reports this error:
Severity Code Description Project File Line Suppression State Error 1280 Class name and ClassGuid mismatch, expecting Class "Sample" for ClassGuid "{78A1C341-4539-11d3-B88D-00C04FAD5171}". wdftoastmon C:\Users\nBase2\Git\repos\Windows-driver-samples\general\toaster\toastDrv\kmdf\toastmon\wdftoastmon.inx 22
Basically, we need more details to overcome this error.

Sample is a well-known class associated with ClassGuid={78A1C341-4539-11d3-B88D-00C04FAD5171}. You'll therefore probably need to also change ClassGuid if changing Class. This is documented on https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/inf-validation-errors-and-warnings


Faster / batch RMSD calculations

Scaffolded is slow but manageable. Agglomerative method is 5ish x slower.

Doing it with scatter now - massive speedup.


My last name haha

This is a minor idea, but could we take my last name "Wang" out of the array? I realize that my last name can be interpreted as referring to the nether regions of the male body, but a lot of people on this planet share my last name haha.

Better yet, allow a lot more customisation. There is currently customBadWords, but how about

disableDefaultBadWords (true/false)
ignoreBadWordsInPaths (array of paths to ignore)
ignoredBadWords (array of words to ignore)

where the latter would allow Mr Wang to use this plugin.
My own use case for this plugin is to disallow the usage a deprecated api method. This plugin looked good, but I really don't care for the default word list. Especially since it gives false positives in other languages (in Swedish "slut"  == "end").


Can creating a work order support the entry of expected working hours？

Feature Description
Currently, the working hours are counted based on how long it actually takes. In many real scenarios, the leader first estimates the required working hours before creating the work order.
If the creation of a work order could support the entry of expected working hours, and the developers could then develop and obtain the actual working hours, and if it could also display how long it has been overdue on the work order list page, having this feature would allow for better statistics on performance and development efficiency.
Screenshots

We already have Due Date below.
So this can be Due(Scheduled?) and contains Hours or/and Date.


There is no error dispaly when updating the setting

curl 'https://conduit.productionready.io/api/user' -X PUT -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:87.0) Gecko/20100101 Firefox/87.0' -H 'Accept: */*' -H 'Accept-Language: en-US,en;q=0.5' --compressed -H 'Referer: https://vue3-realworld-example-app-mutoe.vercel.app/' -H 'Content-Type: application/json' -H 'Authorization: Token xxx' -H 'Origin: https://vue3-realworld-example-app-mutoe.vercel.app' -H 'Connection: keep-alive' -H 'TE: Trailers' --data-raw<EMAIL_ADDRESS>

There is currently no way to resolve this issue because the validation is not provided by the backend with the relevant API, nor does it provide an error message that conforms to the format.


onRippleAnimationEnd called twice

I was debugging in the fork of this library and I saw that onRippleAnimationEnd is called twice.
Though when the input is finished, onPinCodeInputed is called and then If the action was successful, activity is closed. If not, an event on ui thread blocks the second handler for the onRippleAnimationEnd. I am not sure if this was the intended design.
I am working on adding better hashing method which has to be done asynchronously. When I try to do that I cannot prevent the second onRippleAnimationEnd control.
I updated to the new RippleEffect in my forked library  whose onCompleteListener is called only once.

Hello @sathvik87
Interesting!
So from what I understand, we should update to one of the latest version of RippleEffect to not have this bug anymore.
I did not encounter it on my devices though ^^
Cheers

Yes, I updated the RippleEffect library and the view code in master branch has changed quite a bit I think. If we pull the latest version available through Gradle for RippleEffect, It has a bug for Android 6.0 devices. https://github.com/traex/RippleEffect/issues/103
So I had to download the latest code and integrate it as a part of external library in my project.
But, yes, When I did that, onCompletionListener is called only once. I noticed that code of RippleEffect OG fork is quite different from the current master branch.

@sathvik87
I did not reproduce the bug with onCompletionListener called twice.
I'm gonna close it for now, I'll merge the main RippleEffect branch if I have the time.
Thanks.
Cheers

Pull https://github.com/omadahealth/LolliPin/pull/215 version where correct new version of dependency is used.


"Endpoint read failed" Javascript Error when connection to LND is lost bug

I think this error happens when you kill lnd while Zap is currently talking with lnd. During my testing with #205 and #206 I was killing lnd at different points to see the response and this error popped up on three random occasions.
Error Log:
[0] status:  { code: 0,
[0]   details: '',
[0]   metadata: Metadata { _internal_repr: {} } }
[0] end
[0] error:  { Error: Endpoint read failed
[0]     at ClientReadableStream._emitStatusIfDone (/home/pnd/zap-desktop/app/node_modules/grpc/src/client.js:255:19)
[0]     at ClientReadableStream._receiveStatus (/home/pnd/zap-desktop/app/node_modules/grpc/src/client.js:233:8)
[0]     at /home/pnd/zap-desktop/app/node_modules/grpc/src/client.js:705:12 code: 14, metadata: Metadata { _internal_repr: {} } }
[0] TRANSACTION STATUS:  { code: 14,
[0]   details: 'Endpoint read failed',
[0]   metadata: Metadata { _internal_repr: {} } }

Screenshot:

Handling for if/when Lnd crashes was updated in 0.4.x to provide feedback to the user, present the error message, and send the user back to the launchpad area.


Change version of pyinstaller to 5.5 from 5.0.1 for Amazon Linux 2023…

… running python 3.11
Description of change
X: # Using Porting Advisor on Amazon Linux 2023 on AWS Graviton (c6g) but build.sh fails
Issue
PR reviewer notes
X: # 14
Changing pyinstaller to 5.5 works on AL 2023 and Ubuntu 22.04
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jasonrandrews thank you for your contribution. The fix looks good and it passes on Ubuntu and MacOS (I also tested it on Amazon Linux 2023 with Python 3.11 as you described and it was successful). The only issue seems to be with Windows, but looking at it is just a matter of removing line 53 from Build.ps1 as it is no longer needed on this version of PyInstaller. Could you include the removal of this line on your PR?

@jamolina I have removed line 53 from Build.ps1


Unable to add new generations to the grid

Problem
Let's say I have these axes:
x-a, x-b, x-c
y-a, y-b, y-c, y-d, y-e, y-f, y-g
z-a, z-b, z-c, z-d
t-a, t-b
So script will generate all the x-a, than all the x-b, than all the x-c.
And if you stop it on x-b y-g z-d t-b - you can start script again and it continue from x-c y-a z-a t-a
But, if you stop it on x-b y-d z-b t-a - the script will anyway start from x-c y-a z-a t-a
Solution
The skipping algorithm must look at all levels, not just the first.

In addition, please also check if new variables can be added to the existing grid.
For example:

I generate grid with axis style-a, style-b and style-c
I also may change other axes
I remove style-b and add style-d
I regenerate grid with axis style-a, style-c and style-d

Yes you can add new variables to each axis.
The issue described in the opening post does not exist. It skips based on whether the image file exists already or not. It will render any images that haven't already been rendered.


Red time line

I think it would be a good idea if the vertical Tag Stamp time line was red (or any bright color that is clearly visible on the white spectrogram), just like the markers in Time Tune, for better visibility.

It's green in my personal image, but I don't know if it's good for visibility.
I wish I could set the color scheme of the display screen, but
I have to make a setting UI.
個人的なイメージでは緑だけど、視認性的に良いかは分からない。
表示画面の配色を設定できればいいんだけど、
設定用UIを作らないといけない。

Thank you, it's more visible now.


CompressedSourceTest: simplify

We should use random.nextBytes(buff) instead of making the array in a loop.
The code we now point to is the same as the for loop, so the test continues to pass.

This change also fixes a build break in our integration tests which use a very strict compiler that disallows error-prone code.

R: @lukecwik

LGTM


adding external packages docs

:rocket: What
The documentation around how to use packages or external_packages_dir is missing. Many users have been inquiring about this so having it officially on our docs is important.

:computer: How
Wrote a doc about it.

:microscope: Testing
Tested it manually.

i'll let philip approve the text but can you please make sure that it's also added to the config reference

What config are your referring to?

https://github.com/basetenlabs/truss/blob/924162313aa3dcda3cdca9ff5e610696659e5431/docs/reference/config.mdx#L4


#65-1 Improved error message for invalid JSON from Java

This fixes #65 by improving feedback when an error occurs parsing invalid JSON.
I'm not sure if line 89 is in the best way to test that but because the assertions don't halt execution I can't check for error in an assertion before and if I use an if then that throws out test.expect(2).

I'm not sure what is wrong with AppVeyor. Perhaps it is something with Windows. I'll investigate.

Closing this in favour of #67, which addresses the problem more fully.


List of integrations

This issue is an open track list about frontend side libraries for make easier microlink integration.
Feel free to discuss or suggest
Integrations / roadmap

[x] react-microlink
[x] vanilla/umd
[ ] vuejs
[ ] AngularJS
[ ] WordPress Plugin
[ ] Polymer

Note about vanilla/umd
Currently it's a bundle of the react-microlink component. The size is a little heavy (~50kb) because it needs react-dom as dependency.
Probably, using something lightweight like vuejs we can improve the bundle.
Also I tried to switch from react to preact in the build process. Currently is not possible because we are using Fragmentfrom react API and it is not supported by preact.

Bagsy WP integration! 🖐

I'm going to mention @alexjoverm and @jroji 😄

Gatsby Plugin would be much better for directly showing link previews in Blog Posts

Good idea @deadcoder0904, we're happy to receive a PR if you're up for it 🙂

Never made one actually so have to learn. But I'll do it when I make a blog with your help :)

@deadcoder0904 sure! I added it into the list 🙂

A new page has been shipped for visualizing all the integrations available: https://microlink.io/integrations


Incorrect parameter encoding for solidity address in latest Hedera Java SDK

I have discovered a potential bug in the Hedera Java SDK. This bug is related to solidity address encoding. I was working with a solidity contract its constructor has an address as argument. The contract was deployed on testnet with success. However, contract calls that reference that address failed. Based on my analysis, the root cause is the incorrect padding in the method com.hedera.hashgraph.sdk.contract.ContractFunctionParams.addAddress(String). To my knowledge, this bug has not been reported in https://github.com/hashgraph/hedera-sdk-java/issues, https://github.com/hashgraph/hedera-mirror-node/issues nor in https://discordapp.com/invite/FFb9YFX.
Bug details:
The account in question is "0.0.155271" and it's 20 byte solidity address in hex form is:
String addressInHex = "0000000000000000000000000000000000025e87";
I used the following code to create the contract:
TransactionId contractTxId = new ContractCreateTransaction()
.setBytecodeFileId(newFileId)
.setGas(100_000_000)
.setConstructorParams(
new ContractFunctionParams()
.addAddress(addressInHex))
.execute(client);
The constructor parameter (32 bytes, 64 hex characters) encoded with the following sdk method: com.hedera.hashgraph.sdk.contract.ContractFunctionParams.addAddress(String) in hex is:
0000000000000000000000000000000000025e87000000000000000000000000
which is incorrect due to padding to the right. The correct encoding (with left-hand side padding) should be:
0000000000000000000000000000000000000000000000000000000000025e87
In my test, when I did custom encoding with left-hand side padding, the same contract calls after contract deployment succeeded.

Thanks for reporting the issue. This was fixed in #351 and should be out soon.


Reduce Number of Methods Generates in Clients

Currently, depending on the configuration setup, in ClientMethodMapper we can end up generating overloads of methods that'll never be used. For example, if Context is enabled we'll end up with api(params) and api(paramsPlusContext) and if this is being used with a hand-written SDK the non-Context overload will almost never be called as the written layer will handle either propagating a Context or use an empty Context. This has a few downsides, it increases the size of JARs, results in longer compilation times, and skews test code coverage, given that we should look into the following ideas/improvements:

Only generate a Context overload if the generated client will be in implementation. The service client being in implementation is a good indicator on whether the generated code is being used in a hand-written SDK.
Only generate Response-based APIs if the generated client will be in implementation. The hand-written layer can handle cracking open the Response to return T.

If the client is generated only for implementation, one might actually use the sync-methods=NONE to only generate the Response methods (that likely be the minimum), and wrapper client can do whatever they want?


Reversing sign of xn_nyq in pySTEL/libstell/vmec.py

I am a VMEC and pySTEL user.
As I am not a developer of this repository, I do not know how to set up an issue or who would be appropriate to assign to it. Apologies if there is any rudeness.
While working with an old commit (0901f07) that I obtained in February 2023, I encountered a problem due to only xn being sign-reversed and not xn_nyq when reading the VMEC wout file in pySTEL/libstell.
Even in the latest status on GitHub, only xn appears to be sign-reversed.
https://github.com/PrincetonUniversity/STELLOPT/blob/ecc8870c7c913f6e2b32ef6274f5242186729673/pySTEL/libstell/vmec.py#L39
As far as the specifications of functions cfunct and sfunct in FourierRep and the processes that call them are concerned, I think that xn_nyq should also be sign-reversed.
https://github.com/PrincetonUniversity/STELLOPT/blob/ecc8870c7c913f6e2b32ef6274f5242186729673/pySTEL/libstell/libstell.py#L1184
https://github.com/PrincetonUniversity/STELLOPT/blob/ecc8870c7c913f6e2b32ef6274f5242186729673/pySTEL/libstell/vmec.py#L114
I do not know if such a change is correct and how it could affect other parts of the system.
I am also concerned about a difference with matlabVMEC mentioned in the following issue, for example.
https://github.com/PrincetonUniversity/STELLOPT/issues/42
If any developers are capable of making appropriate decisions, could they please consider this proposal?

Good catch!  I'll implement a fix and make a pull request.

Thank you for your quick response!


[BACKLOG-21321] Avro Streaming enhancments ( pass fields from prior s…

…tep, handle multiple rows containing avro content, add seperator bar and fix Mac UI )

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/RowMetaAndData.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.core.RowMetaAndData

Complexity Change: -0.3% :small_red_triangle_down:
Instruction Change: -0.6% :small_red_triangle_down:
Line Change: -0.7% :small_red_triangle_down:
Method Change: -0.6% :small_red_triangle_down:

org.pentaho.di.job.entries.simpleeval.JobEntrySimpleEval

Branch Change: -0.3% :small_red_triangle_down:
Complexity Change: -0.4% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -0.3% :small_red_triangle_down:
Complexity Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -3.9% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:
Line Change: -0.4% :small_red_triangle_down:

org.pentaho.di.trans.steps.processfiles.ProcessFilesMeta

Branch Change: -3.5% :small_red_triangle_down:
Complexity Change: -2.1% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.systemdata.SystemDataMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -2% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:
Line Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.ui.repository.pur.repositoryexplorer.model.UISecurityRole

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.5% :small_red_triangle_down:

License header violations

:heavy_exclamation_mark: Copyright year is not the current year on core/src/main/java/org/pentaho/di/core/RowMetaAndData.java. Found 2017. Was expecting 2018


Support pre and code

Pre tag has own logic of spaces rendering, we need to support it in canvas

Mostly all is done. Need to improve compatibility with telegram html


Better 404 handling in FileSystemStorage

File system storage can be used for local development, so binary files such as images and PDFs are stored on disk rather than S3.
Properly handling 404's in file system storage.

Coverage decreased (-0.02%) to 94.638% when pulling 0a9532fdf838df2defb73da4ade3e331ca26e028 on cody-file-storage-not-found into 7268d8e7c5e3c415cc9727ef9bfdcb86bfb8d2c2 on main.


Why is the inference so slow?

Hi,
Unlimiformer is amazing and can really help me. However, the inference is so slow that I believe I might do something wrong. Please help me. Thank you.
The task was pretty simple.   Answer with detailed responses according to the entire instruction or question. \n<</SYS>>\n\n Optimize following Python codes: " \
--prompt bad_python_codes.py \
--suffix " [/INST]" \
--test_unlimiformer True \
--fp16 \
--length 10 \
--layer_begin 0 \
--index_devices 1 \
--datastore_device 1 \
--use_datastore True \

The FAISS interval takes a lot of time, it is being performed at every head and every layer

Hi, @urialon and @AshwinRamachandran2002 ,
Thanks for your comments. --use_datastore False speeds up a lot.


Thumbnail method loses transparency

Transparent color is replaced by black:
$img = new claviska\SimpleImage();
$img
  ->fromFile('1.png')
  ->thumbnail(500,500)
  ->toFile('1_.png','image/png');

Another method (resize, bestFit) works right.

Can't reproduce. Can you provide some sample code and a source image?

https://transfer.sh/2KDox/test.tar.gz
Sample code.

This must be something specific to do with your GD version, because it's working properly for me.
Resulting image:

What version of PHP and GD do you have? You can find this info with a quick call to phpinfo().
It's working properly with PHP 7.1.0 and GD 2.1.0:

Note: I've edited your comments to use proper code formatting and embedded the test case here (you can't always rely on third-party sites to keep things online).
To format code blocks, use GitHub Flavored Markdown. For example:

Always try to post the minimum required code to reproduce the problem. This makes it easier for maintainers to help you and future visitors to understand what's going on. 😎

GD library Version | 2.2.3
PHP 5.6

That's really strange. If anything, you'd think it would be the other way around.
Unfortunately, this is clearly outside of SimpleImage. It may be worth posting an issue with the GD project, but I'm sure they'll want us to test on the latest and greatest. Problem is, most people using PHP don't know how (or can't) update GD so that won't really do much.
If you have the time and want to narrow it down to the exact method that's causing this, I can toss some more ideas around. Internally, the thumbnail method uses resize and crop. Both are pretty straightforward, but I suspect this code may have something to do with it.

This line
I think, this brokes transparent color.

Closing because this is outside of SimpleImage – likely due to a specific GD version since I'm unable to replicate. No other reports, either.


chore: Update releaserc config

Pull Request Description
Description:
Add extra types to trigger patch releases
Related Issue:
Checklist

[x] I have added the appropriate prefix  to the pull request title
[x] The CI tests are passing for this pull request.
[x] The pre-commit run -a hooks are passing for this pull request.

This PR is included in version 0.4.1 :tada:

This PR is included in version 0.4.1 :tada:


chore: include version 1.7

Purpose

Include the latest version of the Terraform CLI into the test setup
Adjust issue template
Closes #662

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe: Internal setup

How to Test

Test the code via automated test

go test ./...

Additional test steps

Execute the GitHub workflow test.yml

What to Check
Verify that the following are valid:

Automated tests are executed successfully

GitHub workflow gets executed successfully and the test matrix contains the latest version of the Terraform CLI

Other Information
n/a
Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

[X] The PR is assigned to the Terraform project and a status is set (typically "in review").
[X] The PR has the matching labels assigned to it.
[X] The PR has a milestone assigned to it.
[X] If the PR closes an issue, the issue is referenced.
[X] Possible follow-up items are created and linked.

Follow up activity: after merge of PR add the test against version 1.7 to the required conditions for PR merging


Increase default TTL and heartbeat value

Increases the default TTL and heartbeat value for discovery.
Because the node will still be listed for a long period on
docker info, there is now a Status to know if a node is
in the healthy or unhealthy state.
Fixes #1485
I think a default 3 minutes TTL and 60 seconds heartbeat is fair for now. We can reconsider and increase that default value when we'll have Node Management proposed in #1486.
Depends on #1500 .Without it, there is a probability that the scheduler will block subsequent requests for up to 60 seconds. Because of the probability to pick the downed node before it being marked as Unhealthy by the refresh loop which can take up to max_refresh_time.

LGTM

LGTM


Go service example

@goatfish100 was looking into implementing this.

Eric - can you check the project github permissions?  I tried to check in my branch but got Auth errors.

Hey @goatfish100. Did you fork or are you trying to branch the repo directly?


PHOENIX-7064 Improve prepare of local index mutations

This commit try to improve the performance of prepare local index.
The prepare logic is similar to global index and may be combined with global index.
IT needs to be added

May I ask how to trigger a jenkins test

The Jenkins tests are triggered automatically.


Deprecated rule block-closing-brace-newline-after

Deprecation warnings:
 - The "block-closing-brace-newline-after" rule is deprecated.

https://github.com/stylelint-scss/stylelint-config-standard-scss/blob/88b820a96edda3ce7f0219d74e72eead7484a6e4/index.js#L14-L19

Fixed in a patch release:
https://github.com/stylelint-scss/stylelint-config-standard-scss/releases/tag/v7.0.1


some bencher improvements

Codecov Report

Merging #758 (a1d244c) into master (070457d) will increase coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
+ Coverage   77.90%   78.10%   +0.19%
==========================================
  Files         100      100
  Lines        9665     9647      -18
==========================================
+ Hits         7530     7535       +5
+ Misses       2135     2112      -23

Impacted Files
Coverage Δ

bencher/src/bench_ext.rs
0.00% <0.00%> (ø)

bencher/src/bench_runner.rs
0.00% <ø> (ø)

bencher/src/bencher.rs
0.00% <0.00%> (ø)

bencher/src/handler.rs
0.00% <0.00%> (ø)

bencher/src/tracker.rs
0.00% <0.00%> (ø)

bencher/src/utils.rs
0.00% <0.00%> (ø)

bencher/test/src/lib.rs
0.00% <0.00%> (ø)

xtokens/src/lib.rs
65.38% <0.00%> (+0.89%)
:arrow_up:

xcm-support/src/currency_adapter.rs
51.16% <0.00%> (+6.00%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Allow lossless number type conversion

If you have some CBOR that contains some floating point numbers, and your Rust struct expects integers, it gives an error like:
invalid type: floating point `35841`, expected u64

But with serde_json this works fine, even though all numbers in JSON are effectively floating point.
I feel like it makes sense to allow number conversions as long as they don't lose information. For instance 35841 can be exactly represented in a u64.

I had a look into how this works with serde_json and I think it's something like this:

It parses the JSON number into a u64, and if that can't represent the number, an i64, and if neither of them can, an f64. There is one exception - if you have a number like 1.0 it will parse it into an f64 even though it could losslessly be a u64. That could potentially cause weirdness, however I don't think any JSON encoders would output 1.0 (they'd shorten it to 1) so it probably doesn't matter.

It then calls `visit_u64`, visit_i64` or `visit_f64` depending on how the number was parsed.

Serde will then try to convert to the target field type losslessly if it can, using FromPrimitive. This does most conversions, e.g. i8->u16 always succeeds, u64->i32 succeeds depending on the value. Conversions to f32 and f64 always succeed. However the methods from_f32 and from_f64 don't even exist, so conversions that way never succeed.

Fortunately in my case I control the serializer, so I can change it to do the conversoin there (if possible), which should also result in a more compact encoding.
I'm not 100% sure about CBOR's data model - are the values just "numbers" like in JSON, and the encoded types are just there to allow compact encoding? Or are they supposed to convey information about the actual type of that field?

Updating my CBOR generator to use the smallest possible representation fixed this.

I'm not 100% sure about CBOR's data model - are the values just "numbers" like in JSON, and the encoded types are just there to allow compact encoding? Or are they supposed to convey information about the actual type of that field?

After actually implementing integer encoding it's pretty clear that the CBOR encoding has no relationship with the actual type of fields.  Big endian despite no computers using that, much worse integer encoding than protobuf, despite being 5 years later, etc.


Write an end to end test for creating and viewing a property

 Write an end-to-end test for creating and viewing a property


improved voting app intro

Wording updates to voting app intro to simplify.
Signed-off-by: Victoria Bialas<EMAIL_ADDRESS>

LGTM


Standalone AWS cluster creation UI text needs correction for ACCESS KEY ID and SECRET ACCESS KEY

Bug Report
When using the UI to create a standalone cluster in AWS, when the One Time Credentials option is selected it states that the ACCESS KEY ID (OPTIONAL) and SECRET ACCESS KEY (OPTIONAL) are optional.  These values are not optional for the One Time Credentials option.
Expected Behavior
The (OPTIONAL) text should be removed from ACCESS KEY ID and SECRET ACCESS KEY.
Steps to Reproduce the Bug
Install 0.7.0 RC4 and run the command 'tanzu standalone-cluster create --ui'. --> Amazon EC2 Deploy --> Start Fresh --> One Time Credentials
Environment Details

Build version (tanzu version):
version: v1.4.0-pre-alpha-2
buildDate: 2021-08-18
sha: ab30672

Operating System (client):
Mac OS

Hey @miclettej - looks like we never linked this to a tanzu-framework issue to track it. Do you know if this is still an issue? I think it has been addressed, but I haven't checked lately.

Hi @stmcginnis yes we fixed this one some time back. Let me see if I can find the original TF issue.

I think we did it as

Hey @miclettej - looks like we never linked this to a tanzu-framework issue to track it. Do you know if this is still an issue? I think it has been addressed, but I haven't checked lately.

Hi @stmcginnis I thought we had addressed this but after reading back through comments there is some uncertainty as to whether or not we should make those fields optional. I checked git history and current state of the UI; no changes have been made for making these fields required. Is this still a valid request? I recall that the user experience around use of temporary creds needs a re-think, but I'm not certain what the approach should be.

Thanks for checking @miclettej! I'm not really sure either. I'm tempted to say that we've gotten better documentation around this, and it hasn't been an ongoing issue, so it probably could be closed. But let's wait a bit more and see if anyone else chimes in with any other feedback.

This is still an issue on v0.10.0, but perhaps it got fixed in a later release, we'll keep track of this to ensure there's some resolution.

We're going to close this issue to see if it ends up causing confusion in the future. For now it feels like there's not a clear path forward.


Customization with nested conditions for blob lifecycle management.

[Enter feedback here]
A little more customization would help a lot. For instance, purging blobs using last modified but having a nested condition to leave back a few based on creation date as an AND condition is a common ask for lifecycle management.
Documentation link: https://docs.microsoft.com/en-us/azure/storage/blobs/storage-lifecycle-management-concepts?tabs=azure-portal

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9a558a9e-10d0-ea34-8780-d9084f87f952
Version Independent ID: 60dda4e0-7630-f358-aa3a-6a992eae61e2
Content: Optimize costs by automating Azure Blob Storage access tiers
Content Source: articles/storage/blobs/storage-lifecycle-management-concepts.md
Service: storage
Sub-service: common
GitHub Login: @twooley
Microsoft Alias: twooley

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

#reassign: @tamram

GitHub user twooley has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

@vick-git - This is not currently supported with lifecycle management.
#please-close


Bug fixes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing due to changes being merged from a different pr


Give all NotImplementedErrors a description

Currently some NotImplementedErrors don't have a description (most do!) .
raise NotImplemented
# should be
raise NotImplemented("short description of thing which isn't implemented")

I think this would be pretty useful, and makes it less confusing for users, and at least they would be pointed in the right direction to request said feature (and know which bit of specifically is NotImplemented)...
You can find them all with grep (probably more usefully the same regex in your text editor):
grep "NotImplementedError$" pandas/**/*.py -r -n

Starting to work on this

The regular expression above is not perfect, sometimes NotImplementedError() is raised.

thanks!


Support zero-downtime rolling for ASGs with only one instance

I have an ASG which desires only one EC2 instance, but has a max of >1. I want to roll it with zero-downtime, by having two instances for a short period of time.
At present awsc does not support this case. It rejects --min-healthy-percent 100:

it is not possible to keep the minimum 100% of instances healthy for 1 instances, please lower the min-healthy-percent parameter

Is this something that could be supported?

Currently there is no support for this, but I definitely see it as a valid need.

As I currently don't use awsc I don't think I'm going to add this feature myself, but I'm happy to review a PR if you would like to add this.


Fails when trying to convert any python file

I just wrote pytocs hello.py and took the error below:
System.InvalidOperationException: '-(1): Expected token type NEWLINE, but saw ID.'

I'm unable to reproduce this error. What platform are you running on? How did you compile pytocs? Could you supply me with a copy of the hello.py file you are using in a ZIP file? Just drag the ZIP file into a comment field below.

Thanks for your reply. I am using Windows 10. For compiling, I just open src/pytocs.sln in Microsoft Visual Studio and just click run. Then the command line is being opened and I just drag and drop hello.py file that you supplied. I have also coverted it to zip file and drag&drop but no luck.

We resolved the issue on your machine. I'm closing this now and looking at the next issue.


Request

please give me 32 ETH , I want to start being a validator in goerli
0x9b7437FD97B1EaE0457c3e77b6d3DC03717056C4

0x91045Cd1BCabD0d9B47456ba53FA03EDdC3C373b
Hi there, I also need 32+ (some more for gas fee ?) Goerli ETH to became a validator
Thanks

0x1AE60D36412a6745fce4d4935FF5Bf2b8139a371
Hi there, please give me 32 ETH, thank you!

Hi there, please give me 32 ETH, thank you!
0x194Bef0264F65946F60AEbdC6aaA9b47e68E82De

I need 32 ETH, please.
0x80B89aC7a50074DFa570AF4DBb4a3d5592C28E5C


Safari extension - running total column

Defective ToolKit Feature Name:
Running total
Expected Behavior
Running total column in Accounts view
Actual Behavior
Column not visible even though checked in Toolkit settings page.
Steps to Reproduce the Behavior

Export of Toolkit Settings (Bottom Left of Settings Page)
[paste settings here]

System Settings
ToolKit Version:
Operating System (Mac/Windows/Etc):
Browser (Chrome/Firefox/Safari):
Browser Version:
Other Extensions:

@claw73 I'm going to chalk this one up as a duplicate of #631 and remove it -- please feel free to track progress there.


Commit state at every iteration

Currently the .logtstash_since_lastrun file is only updated to disk upon pipeline shutdown. This should be run after every sql run.

+1

+1
Persisting the sql last start file after every sql run is crucial for clustering logstash nodes, supposedly if 1 of the node crashes, the sql last start will not be updated and retrieval of subsequent data will not be precise. Is there any work around for this?

+1
On Jan 5, 2016 10:56 AM, "seahsiungee"<EMAIL_ADDRESS>wrote:

+1
Persisting the sql last start file after every sql run is crucial for
clustering logstash nodes, supposedly if 1 of the node crashes, the sql
last start will not be updated and retrieval of subsequent data will not be
precise. Is there any work around for this?
—
Reply to this email directly or view it on GitHub
https://github.com/logstash-plugins/logstash-input-jdbc/issues/41#issuecomment-168955255
.

This has been fixed by the following commit: https://github.com/logstash-plugins/logstash-input-jdbc/commit/bc37474b5ac692fc9bebb79d5cb236492f63f75c


Docs: show minimal permissions required for working with pre-signed URLs.

Currently the lakeFS docs show instructions on how to use lakeFS with minimal IAM permissions on AWS.
With the introduction of pre-signed URLs that also work from the client, we can also add a pre-signed mode: allow the lakeFS IAM role to Put/Get objects, but only from specific IP addresses or VPCs.
More info: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_condition-keys.html
Relevant keys:

aws:referer
aws:SourceVpc
aws:SourceIp

Perhaps there are more.
The definition of done should be a recommended IAM role that allows lakeFSFS to work with full functionality, and the CLI/UI with full functionality, without allowing a lakeFS instance on another AWS account (think lakeFS Cloud..) to access the data directly - but only to sign the URLs.

Deferring the D.O.D here to add documentation because currently its impossible to completely achieve block from Get/Put for lakeFS.
There are several bugs / features we need to figure out before doing that.

Create Repo: dummy file in the storage namespace root.
Commits / Merge needs access to  _lakeFS
UI: Get /Download Object bug
UI: Markdown rendering bug
UI: DuckDB doesn't work with pre-sign.
Import: Needs access to _lakefs directory.
Sample Data when creating repository - will not work needs access to /data dir.
Actions: Needs access to /data dir to read the contents.

Will prioritize the follow issues to achieve no get/post for lakeFS permissions.
(CC: @itaiad200 )

Create Repo: dummy file in the storage namespace root.

Blocker: users can't create repositories.

UI: Get /Download Object bug

Fixed with https://github.com/treeverse/lakeFS/pull/6462?

UI: Markdown rendering bug

Not a blocker but we should prioritize.

UI: DuckDB doesn't work with pre-sign.

Tough one, I don't think it's a blocker but I could be convinced otherwise.

Sample Data when creating repository - will not work needs access to /data dir.

Blocker - It's a UI thing, right? Can't we use presign for it?

Actions: Needs access to /data dir to read the contents.

Blocker - Ouch, that's a pain. We need a smart, resilient workaround for this.
@ozkatz do you concur?

@itaiad200

Fixed with https://github.com/treeverse/lakeFS/pull/6462?

nope, that's not related.

Tough one, I don't think it's a blocker but I could be convinced otherwise

Agreed-  in terms of R.O.I. It seems to me that the root issue is that DuckDB does not support working with pre-sign URL's so its really one as you said., @ozkatz please correct me if Im wrong.

Blocker - It's a UI thing, right? Can't we use presign for it?

Nope, the feature is indeed a UI thing but,the root cause of it comes from Actions: Needs access to /data dir to read the contents.
And that's an issue indeed sure tight now we use streaming approach to get/put those objects and ignoring pre-sign.
But, even if we use pre-sign lakeFS server will not be able to execute hooks before commits because the server itself is restricted by source vpc / account ID / IP  for get requests.
Everything else - 💯

Thanks @Isan-Rivkin  - I think it's absolutely reasonable for specific features to not be available in pre-signed only mode.
I'd say that the immediate blocker is of course the ability to create repositories.
We'll document that duckDB in the UI + sample data are current limitations for pre-signed only mode.


[WW-4043] Moves TestUtils into junit-plugin

Resolves WW-4043

Coverage decreased (-0.01%) to 49.167% when pulling 592c942c764c3eeca69ca04a4e93f824dcbd6a53 on WW-4043-moves-test-utils into 3ccbcc6f9c9f84f6f1e5644e1e266754d88a8017 on master.

LGTM 👍


Add DevHub to "Tools for Open Source"

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

I'm making this change because DevHub is probably one of the best tools that I've come across for interacting with GitHub/interacting with OSS projects in general! Thanks, @brunolemos!

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

You're welcome @kenyonj! I've just merged the master branch again


[Solutions]Merge updates into release branch.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

contributing-to/templates/sample-solution.md
:white_check_mark:Succeeded

docs/best-practices/naming-conventions.md
:white_check_mark:Succeeded
View

docs/cloud-adoption-guide/subscription-governance.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/commerce-chatbot.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/devops-with-aks.md
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/hana-large-instances.md
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/images/sap-hana-large-instances.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/sap-netweaver.md
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/sap-s4hana.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

contributing-to/templates/sample-solution.md
:white_check_mark:Succeeded

docs/best-practices/naming-conventions.md
:white_check_mark:Succeeded
View

docs/cloud-adoption-guide/subscription-governance.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/commerce-chatbot.md
:white_check_mark:Succeeded
View

docs/example-scenario/apps/devops-with-aks.md
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/hana-large-instances.md
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/images/sap-hana-large-instances.png
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/sap-netweaver.md
:white_check_mark:Succeeded
View

docs/reference-architectures/sap/sap-s4hana.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Parse CSS into css gui styles

It would be great to be able to parse regular CSS into css gui compatible styles.

Ah interesting! Sounds good.


apply doesn't run outside of a transaction

I created an ec2 instance outside a transaction and it seemed to work, but even after waiting for a while the instance id never gets populated. However, in a transaction it fills it in

did you run any other command while waiting for the instance to be created?

I was not able to replicate this. I've tried the following and both worked:

After ~2 minutes (the cron job runs every 2 min so it would depend on when you did the insert)

Then I tried to do an insert without a transaction and then run a transaction to see if that could be leaving it outside, but no, it is working:

Instances 2 and 3 are there after the commit:

I also wasn't able to replicate


Fix trace explorer / welcome page refresh corner cases

This PR consists of multiple commits that fixes refresh corner cases.

Add default dispose() method to AbstractTraceExplorerProvider
Call it from the webview dispose handler. Sub-class can add their own implementation and call super implementation. This avoids that the class is using the webview instance after it is disposed.

Ignore connection status listener notification in constructor
The TSP client implementation notifies clients when the method addConnectionStatusListener() is called. This can lead to incorrect state in on client side.

Add method to set server status in TraceServerStatusService
This method set the status bar and the traceViewer.serverUp context that is used to decide whether the trace explorer or the welcome view should be rendered. This method doesn't check the backend to get status in comparison to checkAndUpdateServerStatus. It's useful when it's known that the server is down or up (e.g. after start notification). In this case, it is not necessary to check the backend again. Don't set the status in the method isTraceServerUp() because it should not have side-effects that are not expected. Initialize and refresh flags traceViewer.serverUp and trace-explorer.noExperiments to ensure the correct view is rendered, i.e. Trace Explorer or Welcome view, when certain events happen (e.g. server started or stopped).
Fixes #227
Fixes #228.

Refresh trace viewer after server URL preference changes
For the case that with current URL the welcome view is rendered due to no experiments on server, or the server is down, this will render the trace explorer (or welcome view) after a server URL change. Without calling refresh, the welcome view stays, even if the other server has experiments.
Fixes #229

Signed-off-by: Bernd Hufmann<EMAIL_ADDRESS>

Video showing fix for #227:

Video showing fix for #228

Video showing fix for #229

@williamsyang-work I found some corner cases for the refresh of the trace-explorer/welcome-view that this PR addresses. Please let me know if have any comments for this PR.

Thanks for the assist on this @bhufmann :)

@bhufmann FYI, I noticed another corner case, that was already present before this PR while testing: https://github.com/eclipse-cdt-cloud/vscode-trace-extension/issues/236

@bhufmann FYI, I noticed another corner case, that was already present before this PR, while testing: #236

Thanks for providing this. I think that should be handled outside this PR in dedicated PR to fix #236.


AttributeError in Oxford Flowers Demo: 'dict' object has no attribute 'convert'

Hi,
First, congratulations on this amazing repository; it's a great codebase for study.
I'm attempting to run the Oxford Flowers demo but am encountering an error. I'm not sure if it's just me or if the demo is currently non-functional (perhaps due to some changes on Hugging Face's end, or something else I'm unaware of):
    images = [transform(image.convert(mode)) for image in examples[image_key]]
AttributeError: 'dict' object has no attribute 'convert'

Here's the full traceback:
Traceback (most recent call last):
  File "/notebooks/k-diffusion/train.py", line 525, in <module>
    main()
  File "/notebooks/k-diffusion/train.py", line 435, in main
    for batch in tqdm(train_dl, smoothing=0.1, disable=not accelerator.is_main_process):
  File "/usr/local/lib/python3.9/dist-packages/tqdm/std.py", line 1195, in __iter__
    for obj in iterable:
  File "/usr/local/lib/python3.9/dist-packages/accelerate/data_loader.py", line 451, in __iter__
    current_batch = next(dataloader_iter)
  File "/usr/local/lib/python3.9/dist-packages/torch/utils/data/dataloader.py", line 630, in __next__
    data = self._next_data()
  File "/usr/local/lib/python3.9/dist-packages/torch/utils/data/dataloader.py", line 1345, in _next_data
    return self._process_data(data)
  File "/usr/local/lib/python3.9/dist-packages/torch/utils/data/dataloader.py", line 1371, in _process_data
    data.reraise()
  File "/usr/local/lib/python3.9/dist-packages/torch/_utils.py", line 694, in reraise
    raise exception
AttributeError: Caught AttributeError in DataLoader worker process 0.
Original Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/torch/utils/data/_utils/worker.py", line 308, in _worker_loop
    data = fetcher.fetch(index)
  File "/usr/local/lib/python3.9/dist-packages/torch/utils/data/_utils/fetch.py", line 51, in fetch
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/usr/local/lib/python3.9/dist-packages/torch/utils/data/_utils/fetch.py", line 51, in <listcomp>
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/usr/local/lib/python3.9/dist-packages/datasets/arrow_dataset.py", line 2165, in __getitem__
    return self._getitem(
  File "/usr/local/lib/python3.9/dist-packages/datasets/arrow_dataset.py", line 2150, in _getitem
    formatted_output = format_table(
  File "/usr/local/lib/python3.9/dist-packages/datasets/formatting/formatting.py", line 532, in format_table
    return formatter(pa_table, query_type=query_type)
  File "/usr/local/lib/python3.9/dist-packages/datasets/formatting/formatting.py", line 281, in __call__
    return self.format_row(pa_table)
  File "/usr/local/lib/python3.9/dist-packages/datasets/formatting/formatting.py", line 387, in format_row
    formatted_batch = self.format_batch(pa_table)
  File "/usr/local/lib/python3.9/dist-packages/datasets/formatting/formatting.py", line 418, in format_batch
    return self.transform(batch)
  File "/notebooks/k-diffusion/k_diffusion/utils.py", line 39, in hf_datasets_augs_helper
    images = [transform(image.convert(mode)) for image in examples[image_key]]
  File "/notebooks/k-diffusion/k_diffusion/utils.py", line 39, in <listcomp>
    images = [transform(image.convert(mode)) for image in examples[image_key]]
AttributeError: 'dict' object has no attribute 'convert'

OK, I think I found the problem.
from datasets import load_dataset

dataset = load_dataset("nelorth/oxford-flowers")
image = dataset["train"][0]["image"]
print(image.keys())

gives you:
dict_keys(['bytes', 'path'])
This breaks hf_datasets_augs_helper that expect dataset["train"][0]["image"] to be a PIL Image:
def hf_datasets_augs_helper(examples, transform, image_key, mode='RGB'):
    """Apply passed in transforms for HuggingFace Datasets."""
    images = [transform(image.convert(mode)) for image in examples[image_key]]
    return {image_key: images}

A fix for this dataset would be:
import io
from PIL import Image

def hf_datasets_augs_helper(examples, transform, image_key, mode='RGB'):
    """Apply passed in transforms for HuggingFace Datasets."""
    images = [transform(Image.open(io.BytesIO(image["bytes"])).convert(mode)) for image in examples[image_key]]
    return {image_key: images}


osbuild-image-tests: ignore LVM UUID

Unconditionally ignore the UUID of the LVM container.  We don't control this value so it isn't stable and makes our image tests fail.

Thanks for this fix! I'm running the image-tests now, will report back with results soon.


Menu sizing issue: menu width is cut off

Dropdown menu not resizing properly when your screen becomes too small. See screenshot attached.
My workaround was in the setMenuSize function to set the min-width= -webkit-fill-available on line #1709.
ie:
this.$menu.css('min-width', '-webkit-fill-available');
//this.$menu.css('min-width', this.sizeInfo.totalMenuWidth);

Hello,
Unfortunately such solution cannot be applied to this project as it's a vendor-specific css property, so this would need to be fixed in another way.


Error message "Unknown action: url" when clicking repository (URL) in branch overview

When the repository URL is clicked in the main page a browser session is opened for the URL.
When clicking the same in branch overview error message "Unknown action: url" is issued.

Confirmed on the latest version in SAP Java GUI.

I have fixed it locally, but haven't figured out how to push that up here. I'm still a beginner in Git and have never contributed to any open source projects on Github. Will ask for some assistance on slack.

Can we chat on Slack - https://abapgit.slack.com/messages/C4KRH6CAJ ?

Sent you a message on slack - is it slack live chat you mean? (I don't have my password available so I can't use the link.)

But the steps are the following:

fork this repository
copy HTTPS url of your forked repository
start zabapgit
add new online repository for the package $abapgit
use the HTTPS url
create new branch
commit your changes
go back to github and open pull reques - there should be yellow bar with the green button "New Pull Request"

regression after #2540. The fix if OK, but I'll have a look how to do it without code duplication

@sbcgua  If only ABAP supported functional programming or anonymous classes like Java/C#, you would just created an internal table of (action, handler) and pass it to the parent - but in ABAP you need an interface and a class and that's too complicated and clumsy.
I am looking forward to your solution.
Maybe I would not allow pages to overwrite METHOD zif_abapgit_gui_page~on_event. but I would create a special method (I do not remember the name of this pattern - "template"?) with an  abap_bool return value signalizing the event was handled. Pages in the need to handle events on their would overwrite this method which would be called from zif_abapgit_gui_page~on_event..

@filak-sap Exactly :) lambdas would do well.
on_event. I was thinking toward some kind of middlewares. Where router is the last in the stack and page and it's components are before. Actually like router->on_event does but in a more universal way.
Didn't think about it a lot yet. But seems that there will be a problem with registering handlers. Now all pages subclass zcl_page. They may have on_event ... and also zcl_page has ... so don't forget to call super ? However, the pages can also act as kind of High Order Components like here and here.
So how will GUI know which instance is able to handle ? A page or a subcomponent should somehow let GUI know that it wants to be added to event stack. Either via parameter in render (ref to gui instance) or during construction ... and here the though stops for the moment :)


Speed up insertIntoTopicSOT

The idea is pretty straightforward.
The problem is that for every topic (almost every) it invokes topicRepo#existsById which is under the hood is a call to DB. That means it is a heavy call.
The idea is to minimize a number of calls to DB by replacement of multiple calls topicRepo#existsById by just one findAllById and then processing separately  existingTopicIds and others

thanks for taking a look


Is there an API for getting the current route object based on the state?

I'm trying to grab the current route (React Object) from the state object so I can perform the necessary data fetching on the server side. Right now the state object contains an array of 2 routes whenever I access an url. The first index is always the top level route, and the second index contains the current route. I'm wondering if there's another way to access the current route without using state.routes[1]. The context behind grabbing the route is that I've defined static loadActions on the handler objects. This is how my server looks right now
server.js
ReactRouter.run(routes, req.path, function (Root, state) {
    var currentHandler  = state.routes[1].handler;
    var renderReactToString = function () {
         //renders react component as string and insert into html
    }
    if (currentHandler.loadAction) {
         //async fetch data -> renderReactToString()
    } else {
          renderReactToString();
    }
}

I'm wondering if there's another way to access the current route without using state.routes[1]

There is no single active route object. The router always derives a set of routes from the URL and your route config. Instead of state.routes[1] which will only work with routes on the second level, you can do state.routes[state.routes.length - 1] to always get the innermost route, or loop over it to take all active route objects into account:
var loadActions = state.routes.reduce((all, route) => {
  if(route.handler.loadAction)
    all.push(route.handler.loadAction);
  return all;
}, []);

if(loadActions.length > 0) {
  // execute loadActions however you want (parallel, series)
} else {
  renderToString();
}

I see, thanks, I'll take some time to read the source code too, been just trying it out and hacking something together.


WIP: Adds partials to templates

Related to #974
Can be invoked by:
<?xml version="1.0" encoding="UTF-8" ?>
<phpdocumentor>
    <partials>
        <partial name="introduction" href="docs/introduction.md"></partial>
        <partial name="anotherIntroduction" type="markdown">
            <content><![CDATA[
                # Another introduction
                ...
            ]]></content>
        </partial>
    </partials>
    <translator>
        <locale>de</locale>
    </translator>
</phpdocumentor>

Paths are always relative to the project.

Please note that configuration in phpdoc is as follows:
<phpdoc>
    <partials>
        <entry>
            <name>introduction</name>
            <link>./introduction.md</link>
        </entry>
    </partials>
</phpdoc>

Next you have to print the entry in twig:
{{ project.partials.introduction|raw }}

If you want to define the xml with partial instead of entry, phpDocumentor/Configuration has to be annotate with XmlList.
i use
phpdocumentor 2.8.5
jms/serializer 0.16.0
symfony/symfony  v2.6.13


https://automation-test-cases.vercel.app/test/MM-T1808

Summary

Ticket Link

https://automation-test-cases.vercel.app/test/MM-T1808
Related Pull Requests

Has server changes (please link here)
Has redux changes (please link here)
Has mobile changes (please link here)

Screenshots

Release Note

Hello @M-ZubairAhmed,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.


Hello. What is the purpose of the reverting ... eb3d4ba ?
Also, I noticed that eb3d4ba introduced 2 new APIS
+//          - WebAuthNGetPlatformCredentialList
+//          - WebAuthNFreePlatformCredentialList
Why was the
#define WEBAUTHN_API_CURRENT_VERSION    WEBAUTHN_API_VERSION_4
not uprev'd to version 5 in the original eb3d4ba commit.   I feel the API Version should have been up-reved with the original commit.
Since this change is also on master is there a risk that Chromium based browsers have picked up eb3d4ba from the master branch already?


Recent change breaks npm install

A recent change after version 2.2.0 has broken my ability to run npm install in my project. I'm on node 5.12 with npm 3.10 and I had to restrict the version of react-color to 2.2.0 in order to get a deploy to work. I am skeptical of some recent changes to package.json but I have not taken a closer look.

When I run npm install it installs version 2.2.0 despite having 2.2.2 in my package.json. I'm not extremely familiar with npm, but it seems like these issues are probably related.

Can you update to the latest version and see if this is still an issue?


Add more testing for ComposedSchedule

ComposedSchedule is only implicitly tested through the cyclic schedules. This probably leaves out edge cases.

I would not mind taking a crack at this, however, I will probably need some handholding as I am relatively new to the Julia world.


ImportError: No module named pigpio

Hi, I am trying to run this using python2.7 on a pi3. I have all of the dependencies installed. Followed all of the directions. When using the following code I get an import error for import pigpio.

source ~/.profile
workon cv
sudo pigpiod
sudo bcm2835-v4l2
python2.7 rpotter.py

I've tried it in and out of the cv environment. Tried renaming the import to gpio and it still doesn't work. It appears gpio is installed correctly. Any ideas?

pip install pigpio

It sounds like you haven't installed the python libraries.  To see what you have installed in your python virtual environment first use your workon cv command to connect to it.  Then type pip freeze.  It will print the libraries you currently have in that environment.
An easy test to see if you have pigpio installed for python would be to start up a python console and try and import it:
Launch the console:
python

Try and import the library you want to check (pigpio in this case):
import pigpio


⚠ Samsung has degraded performance

In 092f6c5, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2820 ms

Resolved: Samsung performance has improved in f9629a6.


Lua scripting

Would it be possible to interface with ZNC via Lua scripting, e.g. create a modlua? It would be a great light scripting language as an alternative to Python and others.
Lua 5.2 is achievable with SWIG, and likely LuaJIT (JIT'd Lua 5.1) as well.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

If someone wants to implement it, and, more importantly, maintain it, sure...

For sure, I wouldn't mind taking a stab...  that said, I did look at the current scripting modules, and you're definitely right about maintaining... I think modpython is the only one that is really up to date!
This is from my (very) limited experience with SWIG, but do you think we could standardize modpython/modperl/modtcl (and in the future, modlua) to use a central interface file, and then have specific customizations for each one as necessary?

I think modpython is the only one that is really up to date!

Yes, more or less.
Modperl is missing several features, mostly because SWIG doesn't support Perl as well as Python, and I didn't bother implementing it (or adding workarounds) especially for ZNC.
Modtcl doesn't even use SWIG, and therefore it exposes very small subset of API, which is enough only for several basic eggdrop scripts.

do you think we could standardize modpython/modperl/modtcl (and in the future, modlua)

Another idea for this: #173

to use a central interface file, and then have specific customizations for each one

If that helps, why not. Mostly they contain language-specific typemaps, but there are a few common pieces. Some of such pieces can be useful to C++ modules too.

Have there been any updates on this? Has anyone tried to implement this? I'd like to give it a try.

@leonardus Feel free to do so. I would expect any updates to be posting here, so I guess: Nope, no updates.


defineCachedEventHandler: maxAge zero leads to eternal caching

Environment
Node 18.15.0/Nuxt 3.3.1/Nitro 2.3.1
Reproduction
export default defineCachedEventHandler(async () => {
  return {
    date: (new Date()).toISOString()
  };
}, {
  swr: true,
  maxAge: 0
});

Describe the bug
I would have expected that passing the optionmaxAge: 0 to defineCachedEventHandler() would immediately expire a cache entry, but instead it leads to eternal caching (using maxAge: -1 does the right thing)
I don't know if that's the desired behaviour – if so it should be documented in here imho.
Digging through the code i found this – in case of maxAge: 0 the calculated ttl is zero, thus expires of the cache entry isn't set at all. OTOH i couldn't find any usage of entry.expires (please forgive me if i missed something obvious, i'm new to nitro), so the culprit could be this check.
Additional context
No response
Logs
No response

same problem.
I need to disable api cache in dev env, so I set maxAge to 1  to simulate 0

@Hebilicious did this ever get shipped?


Added a path fallback for the Path()-Getter

Many Plugins (SwagPaymentKlarna, SwagTrustedShopsExcellence ...) use Shopware_Components_Plugin_Bootstrap::Path() before the required info property is loaded, so I inserted a fallback.

Thanks @b3nl, it's merged and will be released in Shopware 4.3.3 soon.


Move podAnnotations to deployment specs

After discussions in https://github.com/kedacore/charts/issues/35 and https://github.com/kedacore/keda/issues/706, this moves the podAnnotations to the correct place in deployment.spec.template

@tomkerkhove I switched from tpl to toYaml to make this work with typical helm values. Was there any particular reason you used tpl in your PR?

No not perse, thanks for the contribution!


Remove ORM from project

This PR is a continuation of Removing the Database example.
It removed the dependancies on PostgreSQL and the ORM from the Package.swift and removes the Grades models.

I agree that we should remove the PostgreSQL requirement from the sample app.  However, I think the ORM is an important part of the Kitura ecosystem, and Sample should represent it.
I had an idea about using a 'dummy' database plugin which might enable this without introducing 'real' database dependencies: #110
@kilnerm FYI.


[FLINK-6896][table] Fix generate PojoType input result exression error.

[x] General

The pull request references the related JIRA issue ("[FLINK-6896][table] Fix generate PojoType input result exression error.")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[ ] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

@sunjincheng121  Thank you for the Fix. Maybe  it had better remove the followed codes at the Func   generateFieldAccess.
        val fieldIndex = if (ct.isInstanceOf[PojoTypeInfo[_]]) {
          fieldMapping(index)
        }

And this bug was import by  [FLINK-5884], due to  the judgment input1Mapping contains the field index or not at the Func generateConverterResultExpression&generateCorrelateAccessExprs.

Hi @hustfxj Thanks for your review. If I understand you correctly. you want delete the code which you mentioned above. But I'm afraid we can not delete that code. Because when output type is PojoTypeInfo, we really need that code. Can you double check it And Please feedback me?
Thanks,
SunJincheng

@sunjincheng121  Sorry, I didn't get you. I think the column will not be out of order If we delete the code. Because we already ensure that the index is at the correct range by the  previous
code input1Mapping.contains(i). Let me know if I'm wrong. Thank you!

For example (from test case):
You can run org.apache.flink.table.api.java.batch.TableEnvironmentITCase#testAsFromAndToPrivateFieldPojo

input1:

0=age(Integer)
1=department(String)
2=name(String)
3=(Double)

input1Mapping:

0=1
1=0
2=3
3=2

Using this PR code logic,we get:
input1AccessExprs:
0=String
1=Integer
2=Double
3=String

If Using for (i <- 0 until input1.getArity if input1Mapping.contains(i)) and delete you mentioned code.we get:
input1AccessExprs:
0=Integer
1=String
2=String
3=Double

That not we want, then the following code will throw exception:
Incompatible types of expression and result type.
I try to express my point clearly. But feel free to tell me If there something not enough.
Thanks,
SunJincheng

@sunjincheng121  I get it. Thank you very much!

Looks good to me.
+1 to merged.

Thanks for your changes. @fhueske

Travis reported a bug about composite type. Fixed it. Waiting for the new CI pass.

@wuchong Can we wait one more day before merging this? I also want to take a look at it. It is related to FLINK-6881.

Please see my message in the 1.3.1 thread on the dev@ list :)

@twalthr Thank you for pay attention to this PR. Feel free to left your comments.

Hi @twalthr I have test this case using the first approach of FLINK-6896. without as clause. It's works well. And with the as clause, It can be fixed by add a case match in StreamTableEnvironment#validateAndExtractTimeAttributes. the code as follows:
case (Alias(child, name,_), _) => fieldNames = name :: fieldNames What do you think?

@sunjincheng121 Sorry, that I haven't responded earlier. I was on vacation last week. I found a solution that requires less CodeGenerator changes. I found several issues (also regarding Java expression parsing). I will open a PR shortly. We can test the PR, with the test cases of this PR.

Hi @twalthr Sounds good, And make sense to me.  I think i can do some code review or check some test case when you opened the PR. :)
Best,
SunJincheng

@sunjincheng121 I opened #4144. Feel free to review and test. I really hope that I could cover all cases.

Of course @twalthr , I haven't merged the code and thanks for your new PR. I will have a look tomorrow.


Confusing description of Tracking queries

"Query results don't contain any entity, which is added to the context but not yet saved to the database."
This is confusingly written. Does this mean to convey that a query will never return any entity that exists in the context in the Added state?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f3ffc114-df51-0be7-8972-6fcead14e011
Version Independent ID: 94c34571-7314-aab1-7898-93ac6d0f3430
Content: Tracking vs. No-Tracking Queries - EF Core
Content Source: entity-framework/core/querying/tracking.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @smitpatel
Microsoft Alias: avickers

Yes - queries return entities from the database, so any entity instance not yet saved won't be returned.

Thanks Shay. Might I suggest rephrasing the documentation along these lines:

When the results are returned in a tracking query, EF Core will check if the entity is already in the context. If EF Core finds an existing entity, then the same instance is returned. EF Core won't overwrite current and original values of the entity's properties in the entry with the database values. If the entity isn't found in the context, then EF Core will create a new entity instance and attach it to the context. Queries only return entities that already exist the database. Any unsaved entities in the context will not be included in query results.


logger: rtt: Output is no longer 'utf-8' but ISO-8859-1

Describe the bug
We used to parse the RTT output from logger in our automated high-level testing. However, yesterday an error occured:
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd3 in position 381: invalid continuation byte

After changing encoding to ISO-8859-1 this works again.
To Reproduce
We use pynrfjprog to read RTT using utf-8 default encoding.
https://github.com/NordicSemiconductor/pynrfjprog/blob/master/pynrfjprog/API.py#L1193
Log configuration:
CONFIG_LOG=y
CONFIG_LOG_DEFAULT_LEVEL=2
CONFIG_LOG_BACKEND_RTT=y
CONFIG_LOG_BACKEND_RTT_MODE_DROP=y
CONFIG_LOG_MODE_NO_OVERFLOW=y
CONFIG_LOG_PRINTK=y
CONFIG_LOG_PRINTK_MAX_STRING_LENGTH=256
CONFIG_LOG_BUFFER_SIZE=4096
CONFIG_LOG_BACKEND_RTT_MESSAGE_SIZE=256
CONFIG_LOG_BACKEND_SHOW_COLOR=n
CONFIG_LOG_BACKEND_FORMAT_TIMESTAMP=n

CONFIG_CONSOLE=y
CONFIG_USE_SEGGER_RTT=y
CONFIG_SEGGER_RTT_BUFFER_SIZE_UP=4096
CONFIG_RTT_CONSOLE=y
CONFIG_UART_CONSOLE=n

Environment (please complete the following information):

0da5d24c36f48

Update: the problem happens for showing string %s with logger.
	char addr[BT_ADDR_LE_STR_LEN];
	bt_addr_le_to_str(bt_conn_get_dst(conn), addr, sizeof(addr));
	LOG_INF("Connected to %s", addr);

[00086194] <inf> ble.connected: Connected to U�

Buffer content is correct and can be displayed with printk.
Connected to 88:83:22:3e:9a:6c (public)

I can reproduce it on application with large number of logged messages. I cannot reproduce it on Zephyr sample with exactly same logger configuration.

@Qbicz what you're getting is no surprise since the string is a stack variable that's out of scope by the time the logging thread processes the message. You'd need to use log_strdup() to get a string that's persistent until the logging thread processes it (it will also auto-free the string).

Thanks @jhedberg. Duplicating the string solves the problem:
LOG_INF("Logging transient string:%s", log_strdup(transient_str));

So the logger automatically creates a copy of stack integers, but for strings it needs to be told what to do.

So the logger automatically creates a copy of stack integers, but for strings it needs to be told what to do.

Pretty much yes. The logger doesn't differentiate at all with the parameters that come after the format string - it just copies the value of each one regardless of the type. So when you give it a pointer it just stores the pointer value for later processing, i.e. it has no knowledge of the persistency of the data that the pointer is referring to.


Build Tools

From @andrewMacmurray on November 10, 2016 12:40
Need to figure out how to set elm up, do we use webpack (do we need webpack)? How do we do things like include link tags in the head of our document?
Copied from original issue: foundersandcoders/keep-the-lights-on#11

From @andrewMacmurray on November 10, 2016 15:5
Success! Done without webpack!
this is a great article on how to set up your own html file and embed the main elm program in a div, whilst still watching for changes in the elm files:
https://maximilianhoffmann.com/posts/how-to-compile-elm-files-on-save

From @iteles on November 10, 2016 15:25
Any contributions to https://github.com/dwyl/learn-elm/ will of course be super useful for the wider community :wink:

From @andrewMacmurray on November 10, 2016 15:31
@iteles I had meant to add the learn-elm link to the readme, will pop it up there and consolidate some of the resources in the wiki. How / where do you think it would be best to add them to the dwyl  repo (as there's not much up there just yet)?

From @iteles on November 10, 2016 15:35
@andrewMacmurray As you go along!
The way I tend to do it is to have the readme for the learn-xyz repo open alongside the project I'm using to learn. Then I just keep adding to it as I go along: I start with a 'Reading list' type section and commit that and then I just keep adding sections as I'm learning. It doesn't have to be perfect, taking people along for the ride through the commit history is pretty awesome!


Misplaced type property in realtime messages?

Bug report
Hello folks. I encountered a problem and after some investigation I think there might be a slight problem with how realtime messages are serialized when being sent to sockets.
Describe the bug
Messages are serialized incorrectly when being broadcast. Specifically, the type property is "in the wrong place", which causes messages not to be picked up by subscribers.
I had the issue when using the official JavaScript library on the subscriber side.
To Reproduce
Publish a message as follows:
let payload = {| playerId = playerId |}
let! _ = channel.Send(Constants.ChannelEventName.Broadcast, "joined", payload)

which will be mapped onto the SocketRequest type and serialized to JSON (with the default encoder) as:
{
  "type": "joined",
  "topic": "realtime:35dc5021-8f5b-4303-95e7-01e0ddbff781",
  "event": "broadcast",
  "payload": {
    "playerId": "0d492920-caa5-4a88-81d5-0d7c4ae4e77b"
  },
  "ref": "313bd635-a779-4c42-8406-6684f6906095"
}

On the receiving end, set up like so:
supabase
    .channel(lobbyId)
    .on('broadcast', { event: 'joined' }, payload => {
        console.log("Player joined", payload);
    })
    .subscribe();

nothing will happen, as the JavaScript library expects the type property to be part of payload, as described on the Broadcast Protocol page.
Manually adding a type property as part of the payload causes the message to be processed correctly on the subscriber side.
Interestingly, if I inspect the WebSockets connection in the browser, the type property is not even present:

Expected behavior
It should be possible to consume messages from the JavaScript library.
System information

OS: Debian Trixie
Version of supabase-js: 2.37.0
Version of supabase-csharp: 0.13.3

Sorry for the double-post. Looking again at the broadcast protocol, it seems I might just be misunderstanding what the type argument of the Send method is supposed to represent.
If that has nothing to do with the event property that subscribers are supposed to be using for listening to specific messages, then this bug report is completely wrong.

@aurecchia sorry for the delay getting to this one. I think you're right with the broadcast message type, specifically here: https://supabase.com/docs/guides/realtime/protocol#broadcast-message. The API has changed over time and this has probably been overlooked. I'll need to poke around a bit with the api - You're welcome to do a PR if you like!

No worries, there was no need to rush :)
I wasn't entirely sure, because the names used in the protocol and in the library are slightly different.


Review my project

https://github.com/sakshi-1604/InstagramClone

Hey @sakshi-1604 some thoughts :

add a license
add a contributing.md
add a first release
maybe make the signin and login button the same style (screenshots)
maybe a how to start / build the project would be nice
nice that you use screenshots

@schmelto  thanks for your advice...I will surely implement them

Thanks for sharing 👍 I will review on a live stream soon - great to see you are getting community feedback already 🤓

Hide release/packages section
Add the following

Code of conduct
Contributing
Writing contributing guidelines
License
Issue templates
Pull request template
Remove wiki/ project if not using

You can include some of your experience or projects in readme !!
Add Eddiehub to organization in Github profile
Read me of the project can be more better as you have only added ss but there should be some details like info about project releases etc !!

Reviewed on live stream https://youtu.be/h0UN06O4YIc
Looks great, some thoughts...

join EddieHub GitHub Org 😉
Suggest having a GitHub profile picture
hide releases, packages, wiki if not being used
Readme could benefit from quickstart guide
Also using the issues section will help people discover and get involved in the project


JDK 17 fails to install on Ubuntu 20.04 on bare metal

Please provide a brief summary of the bug
Attempted to install JDK 17 on a bare metal Ubuntu 20.04 machine following the standard instructions and it fails.
Instructions:  https://adoptium.net/installation/linux/
Failure:
Err:1 https://packages.adoptium.net/artifactory/deb focal/main amd64 temurin-17-jdk amd64 <IP_ADDRESS>.0+8
403 Forbidden [IP: ...]
E: Failed to fetch https://(long url hosted at cloudfront.net)  403 Forbidden
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Please provide steps to reproduce where possible
Just follow the standard instructions:  https://adoptium.net/installation/linux/
Expected Results
Expected JDK 17 to be installed.
Actual Results
Got the following failure message:
Err:1 https://packages.adoptium.net/artifactory/deb focal/main amd64 temurin-17-jdk amd64 <IP_ADDRESS>.0+8
403 Forbidden [IP: ...]
E: Failed to fetch https://(long url hosted at cloudfront.net)  403 Forbidden
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
What Java Version are you using?
17.0.4
What is your operating system and platform?
Ubuntu 20.04
How did you install Java?
Following these instructions:  https://adoptium.net/installation/linux/
Did it work before?
This installs on Ubuntu VMs.  However, something interesting.  I have a VM that has 17.0.3 installed.  I attempted to upgrade it to 17.0.4, and it claims 17.0.3 is the latest release available and it is already installed.  You can see in the error above that 17.0.4 is the version that seems to be automatically selected for installation on the bare metal machine.

A difference that I noticed that may be related.  On the VM, /etc/apt/sources.list.d/adoptium.list contains the following:
deb https://packages.adoptium.net/artifactory/deb focal main

In the error above, you can see the following during the install attempt:
https://packages.adoptium.net/artifactory/deb focal/main amd64 temurin-17-jdk amd64 <IP_ADDRESS>.0+8

Why is this appearing differently on the bare metal system?

Also, why is the 17.0.4 version not being seen by the Ubuntu VM I have when trying to upgrade?

Did you test with other Java versions?
This seems to be a new issue with installing 17.0.4 on bare metal.

Relevant log output
No response

@gdams is CDN still disabled as per https://github.com/adoptium/adoptium-support/issues/554?

Yes it's still disabled so it should be working right now

Thank you - things appear to be fixed now.


[docs] Add 'size' prop to ToggleButton API docs

[x] I have followed (at least) the PR section of the contributing guide.

Closes #21976

@zenje Thanks!


Unable to read Azure:SignalR:ConnectionString from Azure App Service Configuration Application Settings

Describe the bug
I  am working on an Azure SignalR application and everything is working fine on my local machine when I set the following section in my appsettings.json:
 "Azure": {
    "SignalR": {
      "ConnectionString": "XXXXX"
    }
  }

And then initialize in my startup.cs as follows:
services.AddSignalR().AddAzureSignalR();
However when I create the same environment variable in my Azure App Service using App Service>Configration>ApplicationSettings:

My application is unable to start and I get the following application error:

System.ArgumentException: Connection string missing required properties endpoint and accesskey. (Parameter 'connectionString')
at Microsoft.Azure.SignalR.ConnectionStringParser.Parse(String connectionString)
at Microsoft.Azure.SignalR.ServiceEndpoint..ctor(String connectionString, EndpointType type, String name)

It is very strange because:

I can log my connectionstring and it does appear.
When I hardcore my connection string onto the AddAzureSignalR() connectionstring parameter and deploy everything works fine.
When I add the connection string to my applicationsettings.json directly everything works fine,

It would seem that azuresignalR is unable to pickup this environment variable, despite also being able to see it via the Kudo Appsettings page as Azure:SginalR:ConnectionString.
Further technical details

Microsoft.Azure.SignalR (1.5.1)

When I deploy a sample SignalR service to an AppService directly from Visual Studio it automatically create the following Application Settings variables:

When I try to use these same application settings in my codebase and deploy via Az DevOps pipeline it doesn't work

Possibly related to https://github.com/Azure/azure-signalr/issues/1048 as I also tried setting the connection string via ConfigOptions

ASP.NET Core uses EnvironmentVariablesConfigurationProvider to load configuration from environment variables, from the reasons described here:

The : separator doesn't work with environment variable hierarchical keys on all platforms. __, the double underscore, is:

Supported by all platforms. For example, the : separator is not supported by Bash, but __ is.
Automatically replaced by a :

EnvironmentVariablesConfigurationProvider automatically replaces __ with : . So when you configures connection string via environment variables, you should use Azure__SignalR__ConnectionString as the key. When you configures it via JSON file, you should use the origin key Azure:SignalR:ConnectionString.

Yea that was it. I tried with the double underscore and worked! Thank you. First time I had tried it my connectionstring was malformed.


[bug] WSL not detected correctly, tries to use xdg-open instead of wslview

Describe the bug
Go-aws-sso does not correctly detect it is running inside WSL. As a result, it does not try to use wslview to open the auth request URL, it instead tries to use xdg-open which requires the installation of xdg-utils
To Reproduce
Steps to reproduce the behavior:

Using WSL once go-aws-sso is configured, attempt to run go-aws-sso to authenticate
Observe the error output when it attempts to open the URL in browser

Expected behavior
go-aws-sso should try to use wslview to open the URL
Error Output
2023-02-16 15:49:38 ERROR exec: "xdg-open": executable file not found in $PATH
github.com/theurichde/go-aws-sso/pkg/sso.openUrlInBrowser

Closed with #97
Thanks for your contribution! 🎈


Update museeks to 0.8.1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 8fd50076d4c09e48bf825cb7db50ea5e5a9f20e3. Your contribution is still credited to you.


auth: Revert to the old auth method order

We used to always try first local user, then passthrough, then
oidc. The OIDC methods have therefore grown accustomed to returning
errors which shuts down the auth flow completely, even when it wasn't strictly an error.
This effectively reverts to the hard-coded order, so that OIDC can be
made to behave in peace and quiet.

Code looks good, taking it for a quick spin..


Convert code-blocks to literalincludes in ReadingAndWritingImageFiles.rst

The example code in website/ReadingAndWritingImageFiles.rst should be moved to individual files in website/src and included in the documentation files via .. literalinclude::, and also included in website/src/all.cpp so that it get built by CMake for testing and validation. See the other uses of literalinclude as examples.
This task requires some basic familiarity with reStructuredText and sphinx but the concepts are easy to pick up from other examples. See Building the Website for how to test the formatting.

I'll take a look at this for dev days.

Just a clarifying question on this - There's about 34 code-blocks left in ReadingAndWritingImageFiles.rst, does that mean I'll need to add 34 new cpp files?
whenever possible, would it make sense to put code in the same cpp file, and reference what gets included in the rst files  with the start-after and end-before directives?

Whatever makes sense is fine, but start-after/end-after sounds like a good approach for the shorter code snippets sounds like a good approach!

Leaving an update here - I've made most of the changes for this, I will submit a PR soon. Thanks for all the help, Cary!


Enforce Laravel param spacing.

Enforce Laravel param spacing.

I like this spacing, but do the StyleCI enforces it? Or new changes will need this check manually?

Or new changes will need this check manually?

Next changes will automatically be fixed by StyleCI.
Anytime docblocks are added or updated.

Can this be reviewed @iget-esoares ?

@lucasmichot Thanks for your contribution. I'm merging this.


Incorrect interpreter path in ./node_modules/.bin/gdaxConsole

Hi there,
This looks great!
I was going to test and see how it works but the first step failed:
$ ./node_modules/.bin/gdaxConsole --product BTC-USD -t
bash: ./node_modules/.bin/gdaxConsole: /bin/env: bad interpreter: No such file or directory

Changing the file to use /usr/bin/env instead of /bin/env fixed it. I noticed all the other files in that same folder are already using /usr/bin/env

Thanks for pointing this out. The demos changed just before launch and clerly forgot to updte the docs.

Fixed in v0.1.14


Fix/httplog generalized the plugin for re-use

includes #1689 and adds some comment updates and exposing the conf table to the serializer (in case a different content-type is configured)

@WALL-E merged the generic modifications, you can now update the influxdb one based of this.

@Tieske ok, I will fix it


openExternalView() & openExternalEdit() are broken

Hey,
On iOS physical device I experience an unexpected behavior with:
await FlutterContacts.openExternalView(itemData.id);

or
await FlutterContacts.openExternalEdit(itemData.id);

Console log:
[PPT] Error creating the CFMessagePort needed to communicate with PPT.

The contact card opens up, however:

Issue 1: In openExternalEdit mode it opens the view mode instead of edit mode.
Issue 2 (breaking) : If you tap Edit the contact you cannot pop the modal anymore and the app is completely stuck on this screen.

Any idea how to fix this?

For information, seems to work in this library
https://pub.dev/packages/contacts_service

I have donen a PR : #104

Should be fixed in version 1.1.7
Thanks @starshipcoder

@loic-hamdi can you see the edit mode opened by default when you do openExternalEdit? Or does the user have to press edit button manually?


:hammer: model subclassing with summary and giving tensor a name

Model Subclassing
Model Summary
Giving tensors a name

I think Model subclassing is explicitly something we don't want. If you want a summary, try DEBUG=1 (this can be cleaned up further)

I think Model subclassing is explicitly something we don't want. If you want a summary, try DEBUG=1 (this can be cleaned up further)

hmm, ok...


Missing items: [ITEMS]

[Links to WOTLK Wowhead for each item:](https://www.wowhead.com/wotlk/item=50355/herkuml-war-token)
(Phase 3 was selected)

Item is shown with Phase 4 tag in wowhead (and is in sim under phase 4)


Certain items are not prevented from being used

From testing so far, here is a list of items that can and cannot be used when the cooldown timer is active:
Cannot:
ender pearl
eye of ender
fishing rod
bucket (of water/lava/fish AND empty)
boat
book & quill
snowball
armor
Bottle o' Enchanting
Empty Bottle
Splash or Lingering Potion
Saddle or Horse Armor (but it results in odd behavior where the horse's inventory is accessed instead, rather than the item's use (equipping) or the empty-handed interaction (riding))
Egg
Empty Map
Spyglass
Can:
firework
axe (i.e. stripping wood)
hoe
bonemeal
flint and steel
shears
fire charge
minecart
spawn egg
Shield (ideally let's not change this actually)
Item Frame
Armor Stand
Dye (i.e. dying a sheep - tested with light blue dye but I assume it's the same for all)
Name tag
Coal (i.e. fueling a furnace minecart)
Some possible explanations:
-some of these are marked as entity interactions, and are thus handled by "interactEntity." This is almost surely the case for shears, for instance.
-some of these might be considered "block interactions" that are NOT cancelled by sneaking. Currently, block interactions are only cancelled if they would be cancelled by sneaking. This works well for interactions such as opening a crafting table or chest, but may not work for things such as placing a minecart, using bone meal on a block, or using flint and steel. This would explain quite a lot, but possibly not everything (why does it still prevent using an empty bucket? Wouldn't that be a block interaction?)

Cancelling block interactions by intercepting the PlayerEntity's "shouldCancelInteraction" code is actually super busted. This code is also used for other things, such as minecarts (you don't enter a minecart while crouching) and, noticeably, horses: you open a tamed horse's inventory when right-clicking while sneaking. Perhaps it may be more appropriate to replace the specific call to "shouldCancelInteraction" within the interactBlock method of ClientPlayerInteractionManager.java

There is, in fact, a useOnBlock method within the ItemStack class that is NOT currently affected by the eating cooldown timer in any way. Fixing this (and ideally changing the shouldCancelInteraction code) will hopefully fix the issue

Fixed by #16


add logos

Is there something uncommitted? These addresses don't contain any deployed token contract and the images are purple squares

Closing for lack of an image. Please open another PR with any token images you wish to add, thanks!


Sutract fee when send amount equals to current LBTC balance

If I try to send my total balance, an error is thrown (due to lack of funds for paying the fee), the catch() undefines feeCurrency so I lose the LBTC icon on the Choose fee component. See video:
https://user-images.githubusercontent.com/9318412/149127177-ceb5e7df-aae5-41ea-a19d-03871684f170.mov
I don't see the reason to undefine feeCurrency:
    } catch (err) {
      console.error(err);
      setErrorMessage((err as Error).message);
      setFeeCurrency(undefined); // Here
      setFeeChange(undefined);
      setTopup(undefined);
    }

in src/presentation/wallet/send/choose-fee.tsx

The most obvious fix is to recognize LBTC amount === LBTC balance and switch to "send all" mode ie. subtract fee

Should I do it, or https://github.com/vulpemventures/marina/pull/244 will fix it?
I got that impression from https://github.com/vulpemventures/marina/pull/287 discussion.

not sure, Can you test with #244 PR this bug to confirm?

@tiero tested with PR #244, works like a charm.
I think we can close this.