dbt's handle_and_check should return a set of run results

we don't have a standard way of writing out invocation results. an example result might be:
{
  "node": "models.redshift.columns",
  "started_at": "...",
  "ended_at": "...",
  "duration_seconds": 0.01
  "status": "success",
  "result": "CREATE TABLE"
}

we want to standardize this so it can be easily written to disk.
tasks:

create the object, and wire it up everywhere we execute dbt nodes.

questions:

is there an invocation result for a model compilation?
how much detail do we store for errors?

in RunnableTask (task/base_task.py), we have both the set of results, as well as the project (self.project). this seems like the appropriate place to write the invocation result object out to disk.
the path that it writes to should be target/invocations/{timestamp}.json
each node_runner returns a RunModelResult object. runner.py does a thread pool parallel map over the nodes and spits out a list of these objects. so we need to do things:

modify RunModelResult to include a start and end timestamp
add serialize to RunModelResult
write the list of RunModelResults out to disk

envelope:
{
  "task_type": "run",
  "started_at": "...",
  "finished_at": "...",
  "status": "...",
  "results": [
  ]
}

child_map is depends_on, parent_map is the inverse
"child_map": {
    "model.fishtown_internal_analytics.dependent": [
      "model.fishtown_internal_analytics.estimates"
    ]
}

"parent_map": {
    "model.fishtown_internal_analytics.estimates": [
      "model.fishtown_internal_analytics.dependent"
    ]
}

closing this in favor of a more actionable issue describing a stable API for dbt as a library. handle_and_check will probably remain undocumented forever. Let's revisit the spec above when we do get to an API for running dbt


Vector iseq

Checks if two vectors are equal (Doesn't work for real tuples but does work for rational tuples)

I think that this PR ought to be closed in favor of implementing propositional equality. I'll work on that now.


Vulnerability roundup 77: gcc-8.3.0: 1 advisory

search, files

[ ] CVE-2019-15847 (nixos-19.09, nixos-unstable)

Scanned versions: nixos-19.09: 5f506b95f9f; nixos-unstable: c1966522d7d. May contain false positives.

Well, POWER9 is probably not important to us ATM; I can't remember hearing anyone using Nix* there recently.


fix(node/npm_specifiers): tell the user how to run the example

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Redux support needed

Hi
this is awesome project, but it definitely needs redux support.
Is this on the road-map?

Do you have an example of how would you envision this to work?

Maybe something like this:
import {Provider} from 'preact-redux';
import {applyMiddleware, createStore} from 'redux';
import { renderToString } from 'react-router-server';
...

let store = createStore(
      rootReducer,
      applyMiddleware(epicMiddleware)
    );

renderToString(<Provider store={store}><App/></Provider>)
  .then(({ html, state }) => {
    // state here should actually be the redux-state at the end of all async operations.
  });

and just the normal redux connect within the components.

Would also be interested in knowing if this is in the works

How would we know when all async operations are done in redux?
Wouldn't it currently work with redux by doing something like this:
import * as React from 'react';
import {fetchState} from 'react-router-server';
import {connect} from 'react-redux';
import {bindActionCreators} from 'redux'

@fetchState(
  state => state,
  actions => ({ done: actions.done })
)
@connect(
  ({ message }) => ({ message }),
  dispatch => ({ actions: bindActionCreators(actionCreators, dispatch) })
)
class Example extends React.PureComponent {
  componentWillMount() {
    this.props.actions.loadSomeMessage()
      .then((message) => this.done({ message }));
  }

 render() {
    return (

Hello World

    );
  }
}

export default Example;

what seems to be the most popular option is a double render on the server, the first one to create the state and the second to render the code.
    <Root store={store} history={history} />
  );

  // send signal to sagas that we're done
  store.dispatch(END);

  // wait for all tasks to finish
  await sagasDone();

  // capture the state after the first render
  const state = store.getState().toJS();
  const appState = `window.APP_STATE = ${htmlescape(state)}`;

  // 2nd render phase - the sagas triggered in the first phase are resolved by now
  const body = renderToString(
    <Root store={store} history={history} />
  );```

@gabrielbull Could you clarify usage with Redux - use your comment above or the README 'with Redux` section?


Blackhole rises weird exceptions leading to crash

Under heavy tests blackhole v0.2 raises weird exceptions, most of which lead to crash
Here is one of them, I noticed attributes = std::unordered_map with<PHONE_NUMBER>42976 elements line, which looks wrong. Elliptics log string elliptics: self: addr: no address, resetting state: 0xa73e50 is quite ordinary, it is emitted when client disconnects.
I have coredump, if needed
(gdb) bt full
#0  0x00007f6e68df79c8 in raise () from /lib64/libc.so.6
No symbol table info available.
#1  0x00007f6e68df965a in abort () from /lib64/libc.so.6
No symbol table info available.
#2  0x00007f6e69731b4d in __gnu_cxx::__verbose_terminate_handler() () from /lib64/libstdc++.so.6
No symbol table info available.
#3  0x00007f6e6972f996 in ?? () from /lib64/libstdc++.so.6
No symbol table info available.
#4  0x00007f6e6972e989 in ?? () from /lib64/libstdc++.so.6
No symbol table info available.
#5  0x00007f6e6972f2e5 in __gxx_personality_v0 () from /lib64/libstdc++.so.6
No symbol table info available.
#6  0x00007f6e69192f13 in ?? () from /lib64/libgcc_s.so.1
No symbol table info available.
#7  0x00007f6e69193437 in _Unwind_Resume () from /lib64/libgcc_s.so.1
No symbol table info available.
#8  0x00007f6e6c6fdc54 in blackhole::logger_base_t::get_event_attributes (this=0x7f6d7c001a50) at /usr/include/blackhole/implementation/logger.ipp:165
        tv = {tv_sec =<PHONE_NUMBER>37770, tv_usec = 1}
        attributes = std::unordered_map with<PHONE_NUMBER>42976 elements
#9  0x00007f6e6c727b66 in boost::detail::variant::make_initializer_node::apply<boost::mpl::pair<boost::detail::variant::initializer_root, mpl_::int_<0> >, boost::mpl::l_iter<boost::mpl::list8<blackhole::dynamic_t::null_t, bool, unsigned long, long, double, std::string, std::vector<blackhole::dynamic_t, std::allocator<blackhole::dynamic_t> >, std::map<std::string, blackhole::dynamic_t, std::less<std::string>, std::allocator<std::pair<std::string const, blackhole::dynamic_t> > > > > >::initializer_node::initialize(void*, blackhole::dynamic_t::null_t&&) (dest=0xa385e8, operand=<unknown type in /home/zbr/awork/elliptics/build/library/libelliptics.so.2.26, CU 0xb7c69, DIE 0x12ac2f>) at /usr/include/boost/variant/detail/initializer.hpp:115
No locals.
#10 0x00007f6e6c71ae3e in boost::move<blackhole::dynamic_t::null_t&> (t=...) at /usr/include/boost/move/utility_core.hpp:183
No locals.
#11 0x00007f6e6c79976f in dnet_sink_t::emit (this=0xa5ef40, prio=cocaine::logging::error, app="storage/core", message="elliptics: self: addr: no address, resetting state: 0xa73e50 ") at /home/zbr/awork/elliptics/srw/srw.cpp:274
        record = {attributes = std::unordered_map with 8 elements = {["source"] = {value = {which_ = 7, storage_ = {<boost::detail::aligned_storage::aligned_storage_imp<16ul, 8ul>> = {data_ = {buf = "\270\026\000|m\177\000\000.nonbloc", align_ = {<No data fields>}}}, static size = <optimized out>, static alignment = <optimized out>}}, scope = blackhole::log::attribute::scope::local}, ["app"] = {value = {which_ = 7, storage_ = {<boost::detail::aligned_storage::aligned_storage_imp<16ul, 8ul>> = {data_ = {buf = "\030\230\245\000\000\000\000\000\000\000\000\000m\177\000", align_ = {<No data fields>}}}, static size = <optimized out>, static alignment = <optimized out>}}, scope = blackhole::log::attribute::scope::local}, ["message"] = {value = {which_ = 7, storage_ = {<boost::detail::aligned_storage::aligned_storage_imp<16ul, 8ul>> = {data_ = {buf = "(\026\000|m\177\000\000\270\210\r\000\000\000\000", align_ = {<No data fields>}}}, static size = <optimized out>, static alignment = <optimized out>}}, scope = blackhole::log::attribute::scope::event}, ["severity"] = {value = {which_ = 0, storage_ = {<boost::detail::aligned_storage::aligned_storage_imp<16ul, 8ul>> = {data_ = {buf = "\004\000\000\000\000\000\000\000\245\207\r\000\000\000\000", align_ = {<No data fields>}}}, static size = <optimized out>, static alignment = <optimized out>}}, scope = blackhole::log::attribute::scope::event}, ["pid"] = {value = {which_ = 1, storage_ = {<boost::detail::aligned_storage::aligned_storage_imp<16ul, 8ul>> = {data_ = {buf = "\001\062\000\000\000\000\000\000\000\000\000\000n\177\000", align_ = {<No data fields>}}}, static size = <optimized out>, static alignment = <optimized out>}}, scope = blackhole::log::attribute::scope::universe}, ["lwp"] = {value = {which_ = 5, storage_ = {<boost::detail::aligned_storage::aligned_storage_imp<16ul, 8ul>> = {data_ = {buf = "Q3\000\000\000\000\000\000\371\206\r\000\000\000\000", align_ = {<No data fields>}}}, static size = <optimized out>, static alignment = <optimized out>}}, scope = blackhole::log::attribute::scope::thread}, ["timestamp"] = {value = {which_ = 8, storage_ = {<boost::detail::aligned_storage::aligned_storage_imp<16ul, 8ul>> = {data_ = {buf = "D0\356U\000\000\000\000\027\211\r\000\000\000\000", align_ = {<No data fields>}}}, static size = <optimized out>, static alignment = <optimized out>}}, scope = blackhole::log::attribute::scope::event}, ["request_id"] = {value = {which_ = 5, storage_ = {<boost::detail::aligned_storage::aligned_storage_imp<16ul, 8ul>> = {data_ = {buf = '\000' <repeats 12 times>, "n\177\000", align_ = {<No data fields>}}}, static size = <optimized out>, static alignment = <optimized out>}}, scope = blackhole::log::attribute::scope::event}}}
        level = blackhole::defaults::severity::error
#12 0x00007f6e6bc9f80d in cocaine::logging::log_t::emit<std::string> (this=0xa60ea0, level=10882720, format=...) at /usr/src/debug/libcocaine-core2-<IP_ADDRESS>/include/cocaine/logging.hpp:69
No locals.
#13 0x00007f6e0832c078 in cocaine::storage::log_adapter_impl_t::handle (this=0xa63030, record=...) at /home/zbr/awork/elliptics/cocaine/plugins/storage.cpp:70
        level = blackhole::defaults::severity::error
        cocaine_level = cocaine::logging::error
#14 0x00007f6e6c6fdbe3 in blackhole::logger_base_t::push(blackhole::log::record_t&&) const (this=0xa62bc0, record=<unknown type in /home/zbr/awork/elliptics/build/library/libelliptics.so.2.26, CU 0xb7c69, DIE 0x17c014>) at /usr/include/blackhole/implementation/logger.ipp:161
        lock = {m = 0xa62da0, is_locked = true}
#15 0x00007f6e6c727b66 in boost::detail::variant::make_initializer_node::apply<boost::mpl::pair<boost::detail::variant::initializer_root, mpl_::int_<0> >, boost::mpl::l_iter<boost::mpl::list8<blackhole::dynamic_t::null_t, bool, unsigned long, long, double, std::string, std::vector<blackhole::dynamic_t, std::allocator<blackhole::dynamic_t> >, std::map<std::string, blackhole::dynamic_t, std::less<std::string>, std::allocator<std::pair<std::string const, blackhole::dynamic_t> > > > > >::initializer_node::initialize(void*, blackhole::dynamic_t::null_t&&) (dest=0xa648b8, operand=<unknown type in /home/zbr/awork/elliptics/build/library/libelliptics.so.2.26, CU 0xb7c69, DIE 0x12ac2f>) at /usr/include/boost/variant/detail/initializer.hpp:115
No locals.
#16 0x00007f6e6aacd35a in dnet_log_write (logger=0xa648b8, record=0x7f6d187aa5d0, format=0x7f6e6ab156e0 "self: addr: %s, resetting state: %p") at /home/zbr/awork/elliptics/bindings/cpp/logger.cpp:263
        args = {{gp_offset = 40, fp_offset = 48, overflow_arg_area = 0x7f6d187a8480, reg_save_area = 0x7f6d187a83c0}}
#17 0x00007f6e6aabe213 in dnet_io_process_network (data_=0xa65cf8) at /home/zbr/awork/elliptics/library/pool.c:896
        local_dnet_log = 0xa648b8
        local_dnet_record = 0x7f6d187aa5d0
        addr_str = "no address", '\000' <repeats 117 times>
        nio = 0xa65cf8
        n = 0xa64cd0
        data = 0xa74240
        st = 0xa73e50
        evs_size = 100
        evs = 0x7f6d7c0008c0
        evs_tmp = 0x0
        ts = {tv_sec =<PHONE_NUMBER>62816, tv_nsec = 10888720}
        tmp = 1
        err = -104
        num_events = 1
        i = 0
        prev_tv = {tv_sec =<PHONE_NUMBER>, tv_usec = 269220}
        curr_tv = {tv_sec = 10888720, tv_usec = 10888720}
#18 0x00007f6e6a6f2555 in start_thread () from /lib64/libpthread.so.0
No symbol table info available.
#19 0x00007f6e68ec5b9d in clone () from /lib64/libc.so.6
No symbol table info available.

Hi!
Concrete exception type information would help.

Show me your compile args, I suspect there is BLACKHOLE_DEBUG defined.

We do not set any additional debug macroses:
cd /home/zbr/awork/elliptics/build/library && /usr/bin/c++   -DBYTEORDER=1234 -DCONFIG_ELLIPTICS_VERSION_0=2 -DCONFIG_ELLIPTICS_VERSION_1=26 -DCONFIG_ELLIPTICS_VERSION_2=7 -DCONFIG_ELLIPTICS_VERSION_3=0 -DCONFIG_ID_SIZE=64 -DHAVE_COCAINE_SUPPORT=1 -DHAVE_HANDYSTATS=1 -DHAVE_IOPRIO_SUPPORT=1 -DHAVE_LARGEFILE_SUPPORT=1 -DHAVE_MODULE_BACKEND_SUPPORT=1 -DHAVE_PROC_STAT=1 -DHAVE_SENDFILE4_SUPPORT=1 -DHAVE_SYNC_ATOMIC_SUPPORT=1 -D_LARGEFILE64_SOURCE=1 -Delliptics_client_EXPORTS -std=c++0x -std=gnu++0x -fPIC -I/home/zbr/awork/elliptics/include -I/home/zbr/awork/elliptics -I/home/zbr/awork/elliptics/monitor    -W -Wall -Wextra -fstack-protector-all -fno-strict-aliasing -g -o CMakeFiles/elliptics_client.dir/__/bindings/cpp/logger.cpp.o -c /home/zbr/awork/elliptics/bindings/cpp/logger.cpp

There is no exception info, since program has already crashed.
I suppose it is not blackhole per se, but stl::allocator because of corrupted std::unordered_map with<PHONE_NUMBER>42976 elements
This<PHONE_NUMBER>42976 looks like value from stack.
Uninitialized ts at the very beginning of the stack unwind has similar value<PHONE_NUMBER>62816

140106538842976 is clearly from the stack, it is 0x7f6d00000000, all other stack variables have the same base


Fix 3xTF32 precision issues

See #4603.
(cc @apgoucher)

Could you add the perf impact in description? (maybe perf numbers with and without on large matmul)

These are listed on the issue page, see this comment.  The precision loss and latency (smaller is better for both) vs. CUTLASS are listed under "Test script output for vanilla Triton build", and with this PR under "Test script output for Triton build with patch 2 above".

Could you add the perf impact in description? (maybe perf numbers with and without on large matmul)

These are listed on the issue page, see this comment. The precision loss and latency (smaller is better for both) vs. CUTLASS are listed under "Test script output for vanilla Triton build", and with this PR under "Test script output for Triton build with patch 2 above".

got it, any chance you can copy it to the description? @apgoucher we still think this is useful even if this is slower than existing implemention?

got it, any chance you can copy it to the description?

Sure, copied.

Yes. The issues is that, at the moment, we are accumulating the small parts directly into C, which pretty much negates the 3xtf32 effect. We want to first accumulate them together, then into the A_big @ B_big and then into the accumulator.
We do get a perf hit, but it's better than having a mode that doesn't fully do what it advertises.
@alexsamardzic the PR was closed by mistake (and the branch deleted?)

@apgoucher we still think this is useful even if this is slower than existing implementation?

Yes. I'd make the stronger statement that the existing implementation of 3xTF32 is useless as it's slower than 1xTF32 but without giving any meaningful additional accuracy. Whereas with this change it's actually useful (fp32-comparable accuracy but with tensor core acceleration).
@alexsamardzic can you please recreate this PR without closing it so that it can be approved and merged? Thank you!

@alexsamardzic the PR was closed by mistake (and the branch deleted?)

Hmm, I probably messed it up, did some renaming of the branch in my fork of the Triton repo...  The PR seems to point to correct branch, but I cannot reopen it - does any of you guys have right to reopen the PR in the Triton repo?

attempt to reopen

(wait, that didn't work -- I think it's because the branch has been deleted so there's nothing to merge; can you push a fresh branch?)

Sorry for the hassle.  I had "Reopen and comment" button enabled, and the branch alexsamardzic:fix-3xtf32-prec, that is pointed here:

is there in my fork of the repo.  Just in case, I rebased it on Triton main once again, and force pushed, but now "Reopen and comment" button is again disabled for me.
Would it be the quickest that I just create a new PR, and delete this one?

Would it be the quickest that I just create a new PR, and delete this one?

yes that sounds good

The new PR is #4934.


[cljfmt] Format the project using Cljfmt

This is purely a code formatting PR using the basic settings for Cljfmt (which I believe are set to be the defaults for Bozhidar's Clojure community style guide).

Try as I might I really don't like cljfmt's default style rules. I definitely see the value in having an automated formatter! I'll have to see how configurable cljfmt is and whether it can match my current style.

It supports a fair amount of configuration, afaik. Let me know how you want to proceed.

BTW I've made a ton of progress on ClojureScript support in the past two weeks; haven't uploaded everything yet but it's definitely happening :)

It supports a fair amount of configuration, afaik.

I eventually settled on the following. Based on some experimentation it seems to preserve most of the syntax I want. I haven't checked to see if there's a way to exert finer control over blank lines, but those are rare enough errors that I'm not too worried about it.
{:remove-consecutive-blank-lines? false
 :indents {ns [[:block 1] [:inner 1]]
           defrecord ^:replace [[:block 1] [:inner 1]]
           with-options [[:inner 0]]
           #"[^\[{].*" [[:block 0]]}}

I added the above in 2c21185 and corrected the remaining issues (some of which were legit!) in ab20638.

BTW I've made a ton of progress on ClojureScript support

Awesome, glad to hear it!


Use ground truth data for ground truth mavlink message

Previously the ground truth data that is published over the mavlink hil_state_quaternion message, were filled with information from non-groundtruth messages. Some of them such as vehicle_global_position message is sent by the EKF only after the passing checks. The ground truth gps coordinate was therefore not available from beginning and only for vehicle flying using GPS data for estimation. This is causing issues during integration tests. https://github.com/PX4/Firmware/issues/14760
Is there a reason why the non groundtruth messages were used?
This PR solves this by using the data from the already existing groundtruth variants that are available during simulation. This message is during simulation runs immediately available. From a conceptually standpoint this is also the correct choice. Since the vehicle_global_position is filled with the output from the estimator, it is not ground truth data. It is the estimator output which we want to check against some ground truth data.
Issues:
In the ground truth information from the simulator is no acceleration information available. This was previously available from the estimator.
It could be that there is a static offset in the global position between groundtruth and the output of the estimator. For the existing checks in the mavsdk tests, this is not a problem, since only groundtruth data is compared to groundtruth data.
Testing:
Visualized message fields through mavlink inspector for ground_truth (plot 1) and estimate (plot) by running iris model in simulation.
Latitude (Attention: offset is visible)

Velocity (Attention: HIL_STATE_QUATERNION's velocitty is in cm/s)

Quaternion q0

Yawspeed

All tests are passing now with speedfactor 1:
Before:

After:

For the non-gps model it is also not comparing 0 against 0 anymore.

This certainly sounds like the correct thing to do, I'm not sure if this previously made sense for some use case.


objc_release taking significant cpu time in profile

I'm noticing that objc_release is taking significant cpu time.

Looking at the generated assembly for mtlnvg__convexFill, it seems that a retain/release is due to using a @property for pipelineState.

Based on examining generated assembly, I think the solution may be to make all the properties of MNVGcontext instance variables, then use methods. For example:
-(void) convexFill:(MNVGcall*)call {

    const int kIndexBufferOffset = call->indexOffset * indexSize;
    [self setUniforms:call->uniformOffset image: call->image];
    [renderEncoder setRenderPipelineState:pipelineState];

    if (call->indexCount > 0) {
        [renderEncoder drawIndexedPrimitives:MTLPrimitiveTypeTriangle
                                      indexCount:call->indexCount
                                       indexType:MTLIndexTypeUInt32
                                     indexBuffer:buffers.indexBuffer
                               indexBufferOffset:kIndexBufferOffset];
    }

    // Draw fringes
    if (call->strokeCount > 0) {
        [renderEncoder drawPrimitives:MTLPrimitiveTypeTriangleStrip
                              vertexStart:call->strokeOffset
                              vertexCount:call->strokeCount];
    }

}

and then
static void mtlnvg__convexFill(MNVGcontext* mtl, MNVGcall* call) {
   [mtl convexFill: call];
}

This seems to work. I made the change to convexFill and it no longer appears on the profile.

@wtholliday Thanks. I created a new branch and moved MNVGcontext-related implementation to the Objective C part. Can you try if it works for you? https://github.com/ollix/MetalNanoVG/tree/objc

@olliwang that was fast! :)
It's improved, but I'm still seeing a bit of retain/release:

It's still accessing properties of MNVGbuffers. Is there a clean way to avoid that?

Actually, you can declare an ivar @public. I didn't know that.
So perhaps a cleaner solution to all of this is to use public ivars, which would avoid the objc_msgSend I'm seeing creep into the profile (2.5%).
See https://stackoverflow.com/questions/17508777/need-to-declare-a-public-instance-variable-in-objective-c

@wtholliday I'm not sure if it works. Try the latest commit. https://github.com/ollix/MetalNanoVG/commit/68fe3b2209baebafb652f4f1f7fed52181bbb3a4

@olliwang There are still properties on MNVGbuffers. I tried making one into a public ivar and it seemed to help.
Getting there :)

@wtholliday All rest properties are strong references. Wouldn't that be a problem in ARC?

@olliwang  I think the public ivars will work fine in terms of ARC.
I converted one of the properties over to a public ivar, and I saw a call to objc_storeStrong in the assembly when assigning the ivar.

@wtholliday Is the strong object released properly when assigning a new object to the same public ivar?

@olliwang I assume objc_storeStrong does that.
I converted commandBuffer (created per frame) over to a public ivar and I don't see any leaks in the memory graph debugger or in the leaks instrument.

@wtholliday Thanks. I just updated the branch. Please check if the latest commit works.

Resovled in https://github.com/ollix/MetalNanoVG/commit/583f16334e58b06843e2c52335180d61277dcc17


progress callback get resource as the first argument instead of downloadtotal

as the title said, this is the result of var_dump(func_get_args()); die;  inside the progress callback
array(4) {
  [0] =>
  int(0)
  [1] =>
  int(0)
  [2] =>
  int(0)
  [3] =>
  int(0)
}
array(5) {
  [0] =>
  resource(116) of type (Unknown)
  [1] =>
  int(0)
  [2] =>
  int(0)
  [3] =>
  int(0)
  [4] =>
  int(0)
}

Press ENTER or type command to continue

i followed the code and i see that in CurlFactory you already shifting args if the first arg is a resource, so why is it sending a resource, and the function is called twice?

curl requires the handler to be first.. This is a programming "trick" that we are proxying the progress callback passed by the developer in order to push the handler first.
will close this for now as it does not seem as a bug of guzzle.
for support questions you can use other channels as well as listed below: https://github.com/guzzle/.github/blob/master/.github/SUPPORT.md


Trying to use react-dnd

I've been trying to use react-dnd with this boilerplate and am not having a lot of luck -- I can't get the provider to work
https://react-dnd.github.io/react-dnd/docs/api/dnd-provider
I'm wondering if it has to do with HMR -- I guess I'll try turning that off to reduce the number of moving parts...
my wrap (includes are above)
// this is in app.tsx
// Render components
const render = (Component: () => JSX.Element) => {
    ReactDOM.render(
        <DndProvider backend={HTML5Backend}>
            <AppContainer>
                <ThemeProvider theme={theme}>
                    <Component />
                </ThemeProvider>
            </AppContainer>
        </DndProvider>,
        mainElement
    );
};

their example:
import { HTML5Backend } from 'react-dnd-html5-backend'
import { DndProvider } from 'react-dnd'

export default class YourApp {
  render() {
    return (
      <DndProvider backend={HTML5Backend}>
        /* Your Drag-and-Drop Application */
      </DndProvider>
    )
  }
}

the error (on a reload)
[HMR] Waiting for update signal from WDS...

Visit https://fb.me/react-error-boundaries to learn more about error boundaries.

Did you install the react-dnd-html5-backend package before using it?


Dictionary Path not accepted?

I tried to set a custom dictionary, but for some reason it does not work. I guess it's something with the paths, since I see in the demo that you enter an absolute path on Windows?
# vault-relative path
Meta/Autocomplete Dictionary.md

# absolute path (I'm on Mac)
file:///Users/chrisgrieser/Library/Mobile%20Documents/iCloud~md~obsidian/Documents/Vault/Meta/Autocomplete%20Dictionary.md

It uses Obsidian API, so it should support Mac.

but for some reason it does not work

Does it does not work mean that it shows errors as follows?

when I use the absolute path, it shows this:

with the relative path, it displays this:

Thank you!
Mmm.. I don't know why they are not accepted. First of all, I will survey a bit more.

@chrisgrieser
I have released v1.2.1.
It includes bug fixes related to this issue, so please try it and inform me it is working correctly or not.
(v1.2.1 becomes to show error details more than v1.2.0 💚 )

Thanks! here is what I get in the notification

btw, you could also use console.log(), which makes it a bit easier to catch the error messages (other than trying to screenshot the notification before it disappears 😅 )

Thank you for your screenshot!
How about absolute path? Relative path is not supported for now and not working in my environment, too.

(other than trying to screenshot the notification before it disappears 😅 )

If you use v1.2.1 or later, notification never disappears because I set timeout to 0 :)

ah found the issue – absolute paths do not have to the in the file:/// format. /Users/chrisgrieser/Library/Mobile Documents/iCloud~md~obsidian/Documents/Vault/Meta/Autocomplete Dictionary.mddoes work!
For purposes of mobile & syncing vaults onto different devices, a vault-relative path would probably be more advantageous. (And would also prevent the problem I had from even occurring.)

@chrisgrieser
Good!

a vault-relative path would probably be more advantageous

I think so, too. I'll try it 👍

Once, I'll close this issue.

@chrisgrieser
Coming soon! (v1.4.0)

@chrisgrieser
I have released v1.4.0 🚀
Would you please confirm it?

can confirm, runs perfectly 🥳

Great!
However, it doesn't work on mobile.. 😅 (https://github.com/tadashi-aikawa/obsidian-various-complements-plugin/issues/21)
So I think it will not support an absolute path in the next release. 😢


Need a context-specific property bundle for MFTRecord properties

From Eoghan Casey:
mftRecord
Attribute Range Comment
mftFileID xsd:integer
mftParentID xsd:integer
ntfsInitializedSize xsd:integer
mftDeletionCount xsd:integer
ntfsHardLinkCount xsd:integer
mftResident xsd:boolean 0=resident, 1=non-resident
mftRecordChangeTime xsd:dateTimeStamp NTFS record change time
ntfsOwnerSID xsd:string
ntfsOwnerID xsd:string Represent as Account related to mftRecord
mftFlags xsd:integer
mftFileNameCreatedTime xsd:dateTimeStamp
mftFileNameModifedTime xsd:dateTimeStamp
mftFileNameAccessedTime xsd:dateTimeStamp
mftFileNameRecordChangeTime xsd:dateTimeStamp
mftFileNameLength xsd:integer
mftRuns List of (start cluster, length, offset) Represent as ContentData related to mftRecord
mftAlternateDataStreamName xsd:string
mftAlternateDataStream List of (start cluster, length, offset) Represent as ContentData related to mftRecord
(leave security descriptors and compressed/sparse files until next version)

Just to ensure I am understanding what you are proposing for the bolded elements, the following is my interpretation (none of the bolded properties would exist natively within the outlined PBs but would rather be expressed on Relationships):

For ntfsOwnerID
-- You would specify a Trace containing the MftRecord PB to represent the ntfs properties of a file, specify a Trace containing an Account PB characterizing the owning account, specify a Relationship (with kindOfRelationship something like “has-ntfs-owner-id”) with the file trace as the source and the account trace as the target
For mftRuns
-- You would specify a Trace containing the MftRecord PB to represent the ntfs properties of a file, specify one or more Traces containing a ContentData  PB characterizing the data content of the run, specify a Relationship (with kindOfRelationship something like “has-mft-run”) with the file trace as the source and the run contentdata trace as the target
For mftalternatedatastretms
-- You would specify a Trace containing the MftRecord PB to represent the ntfs properties of a file, specify one or more Traces containing a ContentData PB characterizing the alternate data stream content, specify a Relationship (with kindOfRelationship something like “has-mft-run”) with the file trace as the source and the alternate data stream contentdata trace as the target
-- I would suggest that the mftAlternateDataStreamName property should also be conveyed within the “name” property of each alternate data stream contentdata trace.

I have a concern about mftAlternateDataStream: A file can have multiple alternate data streams.  One system file related to the on-disk security database has no primary data stream, and two named alternate data streams.

From discussion on our phone call this morning (me, Alex, Harm), we think the mftRuns property is not necessary for draft 1.

From discussion on our phone call this morning (me, Alex, Harm), we have some consensus on the ntfsOwnerId and mftAlternateDataStream properties.
For ntfsOwnerID
Change the type of this property to be a UCO object reference.
You would specify a Trace containing the MftRecord PB to represent the ntfs properties of a file, specify a Trace containing an Account PB characterizing the owning account, set the value of the ntfsOwnerID property to be the ID of the account Trace object.
For mftalternatedatastretms,
There would be no direct property within the MftRecord PB.
You would specify a Trace containing the MftRecord PB to represent the ntfs properties of a file, specify one or more Traces containing the "name" property set to the alternate data stream name and a ContentData PB characterizing the alternate data stream content, specify a "contained-within" Relationship with the file trace as the target and the alternate data stream contentdata trace as the source

After writing Issue 6, I had a thought (if I didn't misremember there).  Should also have mftStandardInfoCreatedTime (etc.)?  Would that be redundant with the timestamp stored in the file property bundle, or reinforcing by illustrating derivation source?

For ntfsOwnerID
Change the type of this property to be a UCO object reference.
You would specify a Trace containing the MftRecord PB to represent the ntfs properties of a file, specify a Trace containing an Account PB characterizing the owning account, set the value of the ntfsOwnerID property to be the ID of the account Trace object.

Overall agree, but to clarify, we are not using the UUID/GUID auto-generated by the documentation as the ntfsOwnerID? Are we using the ID originally defined by the file system and simply making sure both the MFTRecord PB's "ntfsOwnerID" property and Account PB's "identifier" property are the same?

For mftalternatedatastretms,
There would be no direct property within the MftRecord PB.
You would specify a Trace containing the MftRecord PB to represent the ntfs properties of a file, specify one or more Traces containing the "name" property set to the alternate data stream name and a ContentData PB characterizing the alternate data stream content, specify a "contained-within" Relationship with the file trace as the target and the alternate data stream contentdata trace as the source

Agreed, although what property bundles (if any) would be in the Relationship object? By adding a "AlternateDataStream" property bundle to the Relationship object, we stay consistent with how we show the relationships between files.

Trace1
Relationhip1
Trace2

MFTRecord:   - name: null   - {metadata}
source: Trace2  target: Trace1  kindOfRelationship: "contained-within"
MFTRecord:   - name: "secret_data"   - {do we repeat the metadata in Trace1?}

ContentData:    - {data for default data stream}
AlternateDataStream:   - name: "secret_data"
ContentData:   - {data for "secret_data" data stream}

I think the clarification/suggestion above for AlternateDataStream looks good with a few clarifications/caveats:

The "name" property will not be part of the MftRecord PB (as is shown in the table) but on the base Trace object itself.
The "{metadata}" may be in the MftRecord PB but may also be in other file-related PBs like File.
Trace2 will not have an MftRecord PB. (It is just the ADS data and not a file itself).
I would strongly suggest that the ADS trace (Trace2) NOT contain the file metadata from Trace1 as this Trace is not a file but simply a range of data from within the file described in Trace1.

This issue looks to be addressed in observable.ttl of v0.3.0
I am not sure exactly when it was added.


Mapping extra properties to tdComp's

We need to write simple datatable wrapper components like the one below in order to put supply them as tdComp values:
<template>
    <user :username="value"></user>
</template>
<script>
    import User from '../../User.vue';

    export default {
        props: ['value'],
        components: {
            User
        }
    }
</script>

If only some there was a mechanism like defining a property mapping to the tdComp, maybe something like:
{title: 'User', field: 'creatorUserName', tdComp:'User', propertyMap: {'username': value}}

Or I am just missing an easier approach.

$props.row should help

Thanks for the ultra-fast reply :)
I might not have not understood your reply, or did not make myself clear.
The thing is, the simple component above works, but it is just a wrapper for tdComp->User component. It just supplies the 'value' property of itself as the username property of the User component.
I really could not understand how the $props.row would prevent writing a wrapper component, without rewriting the User component.

tdComp provideds props: row / field / value / ...

this.row.username is as same as this.value if field: 'username'

Wrapper components then it is.


Auto-disconnect and connect based on client's Public IP address

Is your feature request related to a problem? Please describe.
Firezone is a great VPN solution, we had been testing 0.7, but stopped to wait for 1.0 when it's ready. But, I feel Firezone, with it's own branded client, instead of the usual wireguard client, could use an On-Premise network detection feature based on the WAN IP address the client is connecting to the Firezone controller from, to auto-disable the VPN. This is a feature that could prevent routing issues in some environments. Such as Firezone keeping the tunnel up to my corporate LAN from a laptop, when I'm already physically onsite at the office, on that LAN directly via ethernet or wifi. Having the client up in a scenario like that can cause some odd routing issues for the user on the laptop, since Windows is not smart enough to prefer the on-prem route over Firezone's route.
Describe the solution you'd like
It would be helpful to have the ability to auto-disable the Firezone defined routes or disconnect the VPN client when the FireZone controller detects the client is connecting to the Firezone network from an internet IP address known to the controller, in a blacklist that administrators can populate. The Firezone client on the laptop or device could receive a disconnect command from the Firezone controller in these scenario's and do a periodic check in with the controller server and/or when a network connection state change is detected in Windows (Event ID 10000 in Windows) to determine if the client is connecting from an internet IP address on this blacklist and then tell the client on the device to disconnect the tunnel if the IP is on the list. This mechanism can also connect the client automatically again if they are connecting from internet IP address NOT on the blacklist.
This new feature could allow a preference to use the already existing routing in the office LAN, and not use the routes that come from the Firezone tunnel if they are not needed since the servers or networks the user needs access to, are physically on site with them, on the same network. This allows the local physical router/firewall appliance on the LAN to handle traffic and access to devices, and when the user leaves the office with the laptop or device, let Firezone take over again and automatically re-connect the client to the WireGuard tunnel and continue using the routes coming from Firezone.
Also could be helpful to have the client also disconnect if communication with the Firezone server's/controller are lost, so the client is not left in a state where it's keeps thinking it's connected and continues to try to use a route that's not online.
Describe alternatives you've considered
Use of an event ID in Windows when there is a change in network adapter state to kick off a script that will perform a check similar to the one I described above using text files, ipinfo.io to get the WAN IP and powershell script to access a web server for the lists. And depending on the results, run a connect or disconnect command on the wireguard client in Windows.
Additional context
A GUI on the controller such as this can provide this feature. (I understand the screenshot is from 0.7).

Thanks for the feedback!

Windows is not smart enough to prefer the on-prem route over Firezone's route.

The Firezone clients' are smart enough to connect directly to gateways over your LAN. They'll automatically discover the shortest path to your gateways, even if that pesky operating system tries to interfere.
The way this works is:

When the Firezone tunnel comes up, it adds routes for all IP and CIDR resources you've defined so that they're routed into the tunnel
When our connectivity library (connlib) sees a packet come into the tunnel, it runs a path searching algorithm to find the best gateway to connect to. This involves sending tiny probes out from all interfaces on both client device and gateway.
When they discover each other, the WireGuard tunnel is established, encapsulating the original destination IP of your packet with the local LAN IP of the gateway. The benefit here is all connections are WireGuard-encrypted.
The gateway performs the decapsulation and forwards the packet on to its intended destination

With this approach, all access to resources is logged and can be managed centrally in Firezone, regardless of the user's physical network location. Firezone was designed with this architecture to meet Zero Trust™® requirements.
Based on the above, we likely won't prioritizing building a network detection auto connect/disconnect feature in the clients soon as it would be a step backwards we feel for organizational security.
Does the above explanation make sense? Would that work for your use case?

Thank you for responding! I suppose I'm too used to working an environment where the VPN is completely turned off when on-premise (we currently use SoftEther VPN at my workplace, the server software is configured to block our own office's public IP's from connecting to the VPN), so it intentionally takes the local route over our firewalls (we use FortiGates, and control a lot of network security from those firewalls, we even use a SIEM, FortiAnalyzer with them). For myself and the IT team I work with, it helps to see exactly how our internal site-to-site tunnels and routes for VLANs are functioning on our network for troubleshooting purposes with our end users. Running VPN clients can skew results when doing a tracert command from the client machine or trying to solve a network issue with a user at one of our remote offices. I'm still getting used to most WireGuard bases solutions completely taking a different approach than most VPN solutions. One of the reasons we looked at WireGuard based solutions like Firezone, is because of the ability to break through GCNAT. We have end users with ISPs at home that kill our SSLVPN bases VPN's. And CGNAT is becoming more prevalent. I understand this will not be a feature. But I do appreciate the response, and everything else Firezone can do, looks promising. Thanks again.


[Suggestion] Improve output log

Add datetime to each line: Could be useful. Sometimes when user is walking to pokemon you dont know how many time has passed
Add colors to important messages: Maybe green when captured and red when they flee...

Good work btw

Use dev branch

Lol... nice and sorry :)


⚠ Bofrost.at has degraded performance

In 560cdfc, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 991 ms

Resolved: Bofrost.at performance has improved in 616c365 after 6 minutes.


Feature request: get akamai siteshields maps

Name of the app
akamaiwaf. NOTE: It is actually a feature request
Describe the bug
Hi!! It is actually a feature request, not a bug, I think it is something valuable to have implemented
To Reproduce
It would be great to have a new action to get the siteshields map, it is very straightforward. Currently, we have a custom akamai app implemented in our company, and we have found yours and everything is covered but the siteshields map action. We would like to switch to this app but we need this feature.
The code we have to implement this is like:
def _handle_get_akamai_siteShields(self, param):
    # Implement the handler here
    # use self.save_progress(...) to send progress messages back to the platform
    self.save_progress("In action handler for: {0}".format(self.get_action_identifier()))

    # Add an action result object to self (BaseConnector) to represent the action for this param
    action_result = self.add_action_result(ActionResult(dict(param)))

    # Optional values should use the .get() function
    # optional_parameter = param.get('optional_parameter', 'default_value')

    s = self._get_akamai_session()
    akamaiHost = self.get_config().get("host")

    # make rest call
    try:
        response = s.get("https://{0}/siteshield/v1/maps".format(akamaiHost))
        self.save_progress("Response status from Akamai is: {}".format(response.status_code))
        siteShieldsData = json.loads(response.content)
    except Exception as e:
        self.save_progress("Error connecting to akamai. Error: " + str(e))
    finally:
        s.close()
        self.save_progress('Closed session')

    if not siteShieldsData or not response or response.status_code != 200:
        self.save_progress("Connection with Akamai was not successful.")
        return action_result.set_status(phantom.APP_ERROR, "Review app configuration")

    # Now post process the data,  uncomment code as you deem fit

    # Get ips from response. The full policy structure is required (policySettings[0] must be created)
    for siteShield in siteShieldsData["siteShieldMaps"]:
        for ipRange in siteShield["currentCidrs"]:
            action_result.add_data({"cidr": ipRange})

    self.save_progress("Action handler for: {0} ended".format(self.get_action_identifier()))

    # Add a dictionary that is made up of the most important values from data into the summary
    summary = action_result.update_summary({})
    summary['num_data'] = action_result.get_data_size()

    # Return success, no need to set the message, only the status
    # BaseConnector will create a textual message based off of the summary dictionary
    return action_result.set_status(phantom.APP_SUCCESS)

I think it would be very easy to include this feature in this project.
Could it be possible to add this new feature? Do you think is valuable for the project?
Thank you very much!!

implemented in v1.10


Crochet can't see installed port u-boot-rpi

Crochet stops with error "Please install u-boot-rpi and re-run this script." while the port is installed.
I was able to proceed after the following:
cd /usr/local/share/u-boot/u-boot-rpi
ln -s u-boot.bin u-boot.img

Looks like the file name has changed in the port.
Raspberry PI, 12.0-RELEASE

This PR seems to Be relevant: https://github.com/freebsd/crochet/pull/228

Same for OrangePi-One.
cd /usr/local/share/u-boot/u-boot-orangepi-one
ln -s u-boot-sunxi-with-spl.bin u-boot.img


Does grid_sample work for openVINO?

Thanks for your sharing! As it grid_sample is not mentioned in README, I wonder whether it works for openVINO custom layer?

Hi! Yes, just merged with https://github.com/dkurt/openvino_pytorch_layers/pull/14. Works fone with OpenVINO 2021.2 (forgot to add to README)

Thank you so much for the reply. Got it.
I am working on implementing the Categorical distribution sampling (tf.distributions.categorical or torch.distributions.categorical) for openVINO, which is commonly used in RL models.
It is so wired that there is no random generation ops in openVINO like random.uniform.  May I ask what is the optimal way for such an implementation? e.g., some c++ math library, intel MKL, or implement it in the front phase.  Appreciate your help and hope to merge it to your repository if I get it done.

@SamitHuang, the thing is that random ops are non-deterministic. You may start with just a reference custom CPU layers (using OpenCV for random array generation, as for example). OpenCV is a part of OpenVINO.

Thanks. That's good advice to me. I was thinking about using an external library like gsl_ran_multinomial. Now using uniform distribution sampling in opencv plus intel MKL math library for transforming the uniform dist. to categorical dist. (by gumbel-softmax or binary search) should be more efficient.
By the way, did you try to use the mkl library when doing the op extension? It would be helpful if there is some examples!
The RL model is a q-learning model for a game agent, but it is not released on github. I would to like to do so after permission!

By the way, did you try to use the mkl library when doing the op extension? It would be helpful if there is some examples!

Please take a look at https://github.com/dkurt/openvino_pytorch_layers/pull/13. It's an example with Fast Fourier Transform from MKL.

I think that we can close it


Meshes on root objects aren't properly exported, are missing "Mesh" class identifier (USDU-235)

To reproduce:

create a cube
export as USDZ or USD
open in usdview
note no Cube.

Opening the .usda shows that, similar to #282 and #283, the class identifier is missing, in this case "Mesh".
#usda 1.0
(
    defaultPrim = "Cube"
    endTimeCode = 0
    startTimeCode = 0
    upAxis = "Y"
)

def "Cube"
{
    uniform bool doubleSided = 0
    float3[] extent = [(-0.5, -0.5, -0.5), (0.5, 0.5, 0.5)]

Adding def Mesh "Cube" brings the cube back.

This should be fixed by #348 - please let us know if you're still having issues :)


Java based configuration not working

Hello,
I tried the java-based configuration but it doesn't work.
I created a custom filter as in the example on the website and registered it in my Spring MVC application according to the code below.
JAKARTA EE 17
SITEMESH 3.2.0-M2
SPRING FRAMEWORK 6.0.12
APACHE TOMCAT 10.1.13
ECLIPSE 2023-09 (4.29.0)
 //custom filter public class MySiteMeshFilter extends ConfigurableSiteMeshFilter { @Override   protected void applyCustomConfiguration(SiteMeshFilterBuilder builder) {     builder.addDecoratorPath("/*", "/decorator.html")            .addDecoratorPath("/admin/*", "/admin/decorator.html");   } }
`public class AppConfig extends AbstractAnnotationConfigDispatcherServletInitializer {
@Override
protected Class<?>[] getRootConfigClasses() {
	return new Class[] {SpringConfig.class};
}

@Override
protected Class<?>[] getServletConfigClasses() {
	// TODO Auto-generated method stub
	return null;
}

@Override
protected String[] getServletMappings() {
	return new String[] {"/"};
}

@Override
protected Filter[] getServletFilters() {
    CharacterEncodingFilter characterEncodingFilter = new CharacterEncodingFilter();
    characterEncodingFilter.setEncoding("UTF-8");
    return new Filter[]{ characterEncodingFilter, new CustomSitemeshFilter() }; //HERE
}

}`
If I register the custom filter using web.xml, works.
<filter> 		<filter-name>sitemesh</filter-name> 		<filter-class>com.myapp.filter.MySiteMeshFilter</filter-class> 	</filter> 	<filter-mapping> 		<filter-name>sitemesh</filter-name> 		<url-pattern>/*</url-pattern> 	</filter-mapping>
EDIT 1:
With Java based config I can set a breakpoint and debug my CustomSitemeshFilter class, but the decorator is not applied.
Thank you very much in advance.

Hello @fcruzrj
Thanks for reporting the issue.  I am looking into it.
Why don't you use a FilterRegistrationBean to register the filter?

Hello @codeconsole.
Thanks  a lot. Your answer helped me configure Sitemesh in Spring Boot, which I didn't know was possible. The error I reported occurs in a Spring MVC Eclipse project.

Hi @fcruzrj, yeah, there is a full SiteMesh3 String Boot starter example app.
All you need is the starter dependency:
org:sitemesh:spring-boot-starter-sitemesh:3.2.0-M2
The issue you were having with AbstractAnnotationConfigDispatcherServletInitializer is that it is trying to add the ConfigurableSiteMeshFilter a second time because it was automatically injected due to the @WebFilter annotation it has.  The ConfigurableSiteMeshFilter must be configured prior to the application container attempting to add the @WebFilters.   Using web.xml always overrides all Filter settings.

Hi @codeconsole,
Thanks for the example!
I used web.xml because java based config didn't works. With java based only, I debug the filter but the generated html isn't decorated.

@fcruzrj What I am saying is there was no need to use web.xml in the first place because SiteMesh configures automatically without Spring Boot if you have the sitemesh jar in the class path.  All you need to do is add sitemesh3.xml to configure it or just add a meta tag to any html page and it will decorate it automatically using convention over configuration.
The default (non spring boot) configuration expects decorators to be in the /WEB-INF/decorators folder.
Here is a very simple example:
https://github.com/codeconsole/spring6-filter

@fcruzrj - I've updated https://github.com/codeconsole/spring6-filter to resemble your configuration and show that you are ending up with 2 filters initialized.
The first one is because Sitemesh is initialized by tomcat automatically due sitemesh being in the classpath.   ConfigurableSiteMeshFilter  has a @WebFilter annotation which is detected in the scan.
The second initialization was due to  your protected Filter[] getServletFilters() { method.
The reason why you were not seeing anything and thinking it was not working is because you did not have a sitemesh3.xml file that defined url mappings and/or did not define a decorator in any html page using the decorator meta tag.
I've added logging to show when SiteMesh is initialized and also to detect if more than 1 filter has been initialized.
I am closing this ticket due to https://github.com/sitemesh/sitemesh3/commit/f8556d3747fa63481b8fa79543ba3984bf1e7ed3 and
https://github.com/sitemesh/sitemesh3/commit/eea55c3b2ada5f0a7bdc61cbd61f29a8f6d13e8c now providing this logging information.
Feel free to reach out if you are experiencing any other issues.

Similar issue here.
Currently i used sitemesh 3.1, springframework 5, fully Java based configuration. (without any xml)
I created CustomFilter, which implements applyCustomConfiguration.
public class MeshFilter extends ConfigurableSiteMeshFilter {

  @Override
  public void init(FilterConfig filterConfig) throws ServletException {
    log.info("Start URI checking");
    super.init(filterConfig);
  }

  @Override
  protected void applyCustomConfiguration(SiteMeshFilterBuilder builder) {
    builder.setDecoratorPrefix("/WEB-INF/views/layout")
       .addDecoratorPath("/*", "main.jsp")
       .addDecoratorPath("/auth/*", "auth.jsp");
  }

  @Override
  public void destroy() {
    log.info("End URI checking");
    super.destroy();
  }
}

So, I enrolled
FilterRegistration.Dynamic filter =
        servletContext.addFilter("sitemesh", MeshFilter.class);
    filter.addMappingForUrlPatterns(null, false, "*");
    filter.setInitParameter("encoding", "utf-8");
    filter.addMappingForServletNames(null, false, "dispatcher");

It always logged register twice.
It not only works, but also I want to replace Sitemesh Default Filter, not 2 filter initialized.
If I use sitemesh3.xml and use default filter, it works. But java based config? not works.
How can I achieve this? ONLY IN FULLY JAVA CONFIG. (Even sitemesh3.xml too. because i set this config in my custom filter)

@xkguq007 it registers twice because you are using a different name than the java config.
If you want to override the default configuration, you have to register your filter with the name configurableSiteMeshFilter
See https://github.com/sitemesh/sitemesh3/blob/382faab5e6977ae8202910e03ae991d4d04537cc/sitemesh/src/main/java/org/sitemesh/config/ConfigurableSiteMeshFilter.java#L137

@codeconsole thanks for fast reply.
public class SpringStarter implements WebApplicationInitializer {

  @Override
  public void onStartup(ServletContext servletContext) {
    FilterRegistration reg = servletContext.getFilterRegistration("configurableSiteMeshFilter");
    FilterRegistration.Dynamic filter =
        servletContext.addFilter("configurableSiteMeshFilter", new MeshFilter());
    filter.addMappingForUrlPatterns(null, false, "*");
    filter.setInitParameter("encoding", "utf-8");
    filter.addMappingForServletNames(null, false, "dispatcher");

    // Root Context
    AnnotationConfigWebApplicationContext rootContext = new AnnotationConfigWebApplicationContext();
    rootContext.register(RootContextConfiguration.class);
    servletContext.addListener(new ContextLoaderListener(rootContext));

    ...
  }
}

FilterRegistration.Dynamic filter always null which means already enrolled.
@Slf4j
@RequiredArgsConstructor
public class MeshFilter extends ConfigurableSiteMeshFilter {

  @Override
  public void init(FilterConfig filterConfig) throws ServletException {
    log.info("Start URI checking");
    super.init(filterConfig);
  }

  @Override
  protected void applyCustomConfiguration(SiteMeshFilterBuilder builder) {
    builder.setDecoratorPrefix("/WEB-INF/views/layout")
       .addDecoratorPath("/*", "main.jsp")
       .addDecoratorPath("/auth/*", "auth.jsp");
  }

  @Override
  public void destroy() {
    log.info("End URI checking");
    super.destroy();
  }
}

My Custom Filter does not have any annotation which indicates filter, component, or else.
I set my filter on top of onStartup method. and, reg which define first line on method, is not null.
reg is already set by org.sitemesh.
any thought about this problem?
ps)
fun thing is
when i debugged in first line of configurablesitemeshfilter init method and first line of onStartup method,
it breaks onStartup method first.

hello @xkguq007, I need some more time to look into this, but I will get it working for you.

@xkguq007 can you please provide me with a very minimal gradle example that does not work?

https://github.com/xkguq007/spring5-filter
I forked you test repository, https://github.com/codeconsole/spring6-filter.
Just delete sitemesh3.xml and set version spring6 to spring5, jakarta to javax, sitemesh3.2 to 3.1.
In this code, you've been set your own filter and first line of onStartup, you check already that enrolled default filter or not.
Run your code, you can check the log that already initialized default filter.
This is exactly same as my condition.
I think my forked code's log must not hit the code logger.severe(String.format("*** '%s'  this line. but still hit.
So, Any decorator is not work. Because i removed sitemesh3.xml, and not register my custom filter.
In conclusion, the problem is
"I didn't register any sitemesh filter before, except for my customs. It still has default filter"
with condition,
do not use any xml, including web.xml, sitemesh3.xml, etc.

@xkguq007 the issue is that you need to register your filter prior to @WebFilter being initialized by the container.
https://stackoverflow.com/questions/18704226/disable-webfilter-embedded-in-dependency-jar

@codeconsole Thank you for your help.
I'm using Spring Framework not Spring Boot.
I saw stackoverflow links, two answers which is in link is not proper, neither.
One is for spring boot, the other(selected) is little hacky way I think. Not unregister, but makes unwanted filter useless.
New release version without @Webfilter will be the best option for me. Also I prefer registering filter explicitly to implicitly.

Ok, we will look into repackaging.   You can expect a new release in a week timeframe.

@xkguq007 you want to give the latest snapshot a try?
repositories {
    mavenCentral()
    maven { url "https://oss.sonatype.org/content/repositories/snapshots/" }
}

dependencies {
    runtimeOnly 'org.sitemesh:sitemesh:3.2.1-SNAPSHOT'
}

I separated it here:
https://github.com/sitemesh/sitemesh3/commit/7b01ebb46833f0531a1626428b155f6d0d498d56

@codeconsole Thank you I'll give it a try it.
I'll close this issue when this dependency works.

@xkguq007 I will do an official  release after you confirm it working

@xkguq007 were you able to confirm this working?

@codeconsole
Sorry for late.
Yeah, I checked it works and it's related source code changes.
I will use this SNAPSHOT version until GA version released.
Thanks for your help and I close this issue.

I am using javabase configuration, i have followed the official doc for implementation.
Spring boot version: 3.2.3
Sitemesh version: 3.2.0
Jakarta EE version :17
Issue I get when the page is rendred!
org.sitemesh.webapp.WebAppContext : Error 302 processing decorator '/WEB-INF/decorators/layout/layout.jsp' . In the console only thing I get.
Your feedbacks are highly appreciated!
Thanks

@xkguq007 3.2.1 and 3.1.1 have both just been released to maven central.

@codeconsole I checked maven central that version has been released!
Thanks for your help.


Calling authorize second time always fails when application credentials are used

Calling authorize second time fails when application credentials are used, because b2.accountId gets re-written with actual accountId.
Related to #64

I've submitted a patch for it: #67
Meanwhile you can use npm i @phil-r/backblaze-b2 with
const b2 = new B2({
    applicationKeyId: 'applicationKeyId', // instead of accountId
    applicationKey: 'applicationKey'
})

waiting for @yakovkhalinsky about your pull @phil-r. Tks


So sorry I don't know this... :)

But am curious about trying out the current "dev" or "nested" version, but have no idea how to do that in my current project. Is there a way to point my "packages" to the dev and use that instead of the latest released version?
Cheers

I don't think you can do this from atmosphere packages... But it should be possible to do it manually by cloning the nested branches of the repo, and loading the files into you're project. Now, @jagi said the new version should be out in beta in the next two weeks so...

Yes it's possible.

Create packages directory:

cd workspace
mkdir packages

Clone Astronomy repository:

cd packages
git clone https://github.com/jagi/meteor-astronomy.git

Swich to nested branch as @shadowRR said

cd meteor-astronomy
git checkout nested

Add PACKAGE_DIRS environment variable (of course replace jagi with your user name).

PACKAGE_DIRS="/home/jagi/workspace/packages"

The last one you should add to the .bashrc file to run it at the system start.
export PACKAGE_DIRS="/home/jagi/workspace/packages"

Thanks, that got me up and running. Curious to find out more about Astronomy, thanks for all the effort!


Microsoft Teams Emergency Operations Center secret expired

Our Microsoft Teams Emergency Operations Center secret has expired. We have generated a NEW secret value but do not know where to update it?

Hi @frspecial,
Thanks for reaching out to us.
Please refer to the this section of the wiki to update your client secret - https://github.com/OfficeDev/microsoft-teams-emergency-operations-center/wiki/Troubleshooting#1-client-secret-expiry
After performing the steps please allow some time, clear out cache and try again.
Thanks.

Thanks ! That did it. Much appreciated.
Rgds,
Frank Special
Cloud Architect
TECO An Emera Company
Cell:<PHONE_NUMBER>

From: v-saikirang @.>
Sent: Monday, July 29, 2024 11:40 PM
To: OfficeDev/microsoft-teams-emergency-operations-center @.>
Cc: Special, Frank R. @.>; Mention @.>
Subject: Re: [OfficeDev/microsoft-teams-emergency-operations-center] Microsoft Teams Emergency Operations Center secret expired (Issue #226)
*** CAUTION! EXTERNAL SENDER *** STOP. EXAMINE. VERIFY!! Were you expecting this email? Are grammar and spelling correct? Does the content make sense? Can you verify the sender? To report a suspicious email, use the Forward to Phishing button or forward the email to<EMAIL_ADDRESS> Do not click links, open attachments, or enter your ID or password.
Hi @frspecialhttps://urldefense.com/v3/__https://github.com/frspecial__;!!B7pEFg!i13emK3ND4zJDpGVuMOcJUbl1k0TDIkEuCYKURMzbYPa65MIxoYx0IW3noTNetqBff0gqPeZ4n1kwZOCZw071f0wpK4f$,
Thanks for reaching out to us.
Please refer to the this section of the wiki to update your client secret - https://github.com/OfficeDev/microsoft-teams-emergency-operations-center/wiki/Troubleshooting#1-client-secret-expiryhttps://urldefense.com/v3/__https://github.com/OfficeDev/microsoft-teams-emergency-operations-center/wiki/Troubleshooting*1-client-secret-expiry__;Iw!!B7pEFg!i13emK3ND4zJDpGVuMOcJUbl1k0TDIkEuCYKURMzbYPa65MIxoYx0IW3noTNetqBff0gqPeZ4n1kwZOCZw071Qxw63em$
After performing the steps please allow some time, clear out cache and try again.
Thanks.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/OfficeDev/microsoft-teams-emergency-operations-center/issues/226*issuecomment-2257395569__;Iw!!B7pEFg!i13emK3ND4zJDpGVuMOcJUbl1k0TDIkEuCYKURMzbYPa65MIxoYx0IW3noTNetqBff0gqPeZ4n1kwZOCZw071b2yCDzX$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/BKF52NZWXO4L5HG53BS6IDDZO4DLFAVCNFSM6AAAAABLUUJXXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJXGM4TKNJWHE__;!!B7pEFg!i13emK3ND4zJDpGVuMOcJUbl1k0TDIkEuCYKURMzbYPa65MIxoYx0IW3noTNetqBff0gqPeZ4n1kwZOCZw071ZENrUkt$.
You are receiving this because you were mentioned.

NOTICE: This email is intended only for the individual(s) to whom it is addressed and may contain confidential information. If you have received this email by mistake, please notify the sender immediately, delete this email from your system and do not copy or disclose it to anyone else. Although we take precautions to protect against viruses, we advise you to take your own precautions to protect against viruses as we accept no liability for any which remain.


Swedish is missing é

Description of the new feature / enhancement
Swedish needs the option to type é like in the word kafféet (the cafe) in Quick Accent.
Scenario when this would be used?
Anytime a word with é needs to be typed.
Supporting information
No supporting info, just a missing letter option.

This has been worked on for the 0.74.0 release. Please update PowerToys to the latest version. 😉
https://github.com/microsoft/PowerToys/releases


[BUG] Continuous AutoFocus fails to converge

Please only report one bug per issue!
Describe the bug
When using continuous autofocus, the lens position mostly keeps oscillating and fails to settle.
Only in some cases, depending on the framed scene, it succeeds to converge to a stable value.
To Reproduce
from picamera2 import Picamera2
from libcamera import Transform, controls
import cv2
import numpy as np
import matplotlib.pyplot as plt

#init fig to plot lens position
fig, ax = plt.subplots()
ax.axis([0, 500, 0, 10])
lenspos = np.zeros(500)
plot = ax.plot(lenspos)
fig.canvas.manager.set_window_title('LensPosition')
fig.canvas.manager.show()

#init camera
cam = Picamera2()
m=(2304, 1296)
w=(384,216)
window=(m[0]-w[0], m[1]-w[1], w[0]*2, w[1]*2)
config=cam.create_preview_configuration(main={"format": 'RGB888', "size": m})
cam.configure(config)
cam.set_controls({"FrameDurationLimits": (33333, 33333)})
cam.set_controls({"AfMode": controls.AfModeEnum.Continuous,
                  "AfMetering": controls.AfMeteringEnum.Windows,
                  "AfWindows": [window]})
cam.start()

while True:
    im = cam.capture_array("main")
    metadata = cam.capture_metadata()
    cv2.rectangle(im, ((m[0]-w[0])//2,(m[1]-w[1])//2), ((m[0]+w[0])//2,(m[1]+w[1])//2), (0,0,255), 2)
    cv2.imshow("frame",im)

    key = cv2.waitKey(1)
    if key == ord("q"):
        exit()

    #plot lens position over time
    lenspos[:-1]=lenspos[1:]
    lenspos[-1] = metadata['LensPosition']
    plot[0].set_ydata(lenspos)
    fig.canvas.draw()
    fig.canvas.flush_events()

Expected behaviour
The lens position should always settle to some optimal value.
Console Output, Screenshots

Hardware :
Raspberry pi 5
Pi camera module 3 noir wide

Hi, and thanks for the report. The autofocus works by performing correlations between pixels on the sensor that get a slightly different view of scene. It's not terribly difficult for this process to get confused, either because the details in the scene look similar in slightly different places, or because there aren't any terribly strong details, or because there different parts of the scene are at different distances.
@njhollinghurst may be able to suggest some possible workarounds, or perhaps some debug that could be collected to try and see what's going on.

At first sight it looks like CDAF is working but PDAF is unstable.
In general, is there a certain type of scene that will make it focus successfully, compared to those for which it fails? Could you check also that the lens is clean and undamaged.
Could you try setting the environment variable LIBCAMERA_LOG_LEVELS=RPiAf:0 and report the logged output please, e.g. the first 50 lines when starting the camera, for typical"good" and "bad" cases? Thanks.

Hi,
Yes, it seems that areas with less details are more likely to focus (like the wooden surface I posted above or an empty wall). When I try to focus on some object or on a printed page it usually fails.
The lens looks clean and undamaged.
 It looks like we may need to tweak the algorithm to be more stable with small AF windows and low "confidence" values.

Thank you.
Just as a note, it does not seem that the AF window size matters, I observe the same behavior also with large AF windows or with Auto AfMetering.

"phase" and "conf" are the PDAF data coming from the camera sensor (not quite in their raw form -- this is after applying the window). In the "GOOD" example, phase makes some bizarre jumps; fortunately it's ignored. In the "BAD" example the confidence is high enough that it's no longer ignored; those sudden jumps of +/-10 might be what's making it bounce.
I have seen it become wobbly in the past, though this seems to be an unusually bad example. I'll have to try to reproduce this, and   maybe revise the control algorithm.
Right now it runs in a continuous loop (as longs as "conf" is high enough) - it will never settle completely - but perhaps it should.

Is there any possibility of adjusting the "conf" value in the tuning file, at least as a workaround for the time being?

Yes. Can edit the tuning file /usr/share/libcamera/ipa/rpi/pisp/imx708_wide_noir.json (make a copy first!)
In the "rpi.af" section near the end of the file, try increasing the numbers for "conf_thresh" (which gates PDAF on a per-region granularity) and "conf_epsilon" (which is more of a global threshold). Perhaps "conf_epsilon": 24, "conf_thresh" : 32,.
Other parameters that affect stability are "rpi.af"/"speeds"/"normal"/"pdaf_gain" (reduce its magnitude) and "pdaf_squelch" (increase it). Those parameters are applied here: af.cpp:370
Please ensure also that the lighting is good and not glaring into the camera.

Thanks, I run a quick test with "conf_epsilon": 24, "conf_thresh" : 32, and indeed it seems to reduce the amplitude of the oscillations.

Right now it runs in a continuous loop (as longs as "conf" is high enough) - it will never settle completely - but perhaps it should.

Yes, it would be nice to have it to always settle completely after some timeout (like in the GOOD low "conf" case) in order to avoid differences in the captured frames.
Or alternatively, is it possible to get some focus indication like the FocusFOM metadata but only for the AfWindow region? In that way I could use AfPause to stop and restart autofocus when triggered.

FocusFOM is only reported on a (not very well-specified) central region right now; there doesn't seem to be a control defined to set a window. If scenes are mostly static, "Triggered Auto" mode might be a better fit than Continuous AF.
OTOH if you stick with Continuous AF, try increasing (e.g. doubling) "squelch". That will create more of a dead-band, though admittedly it is a soft rather than hard threshold and doesn't completely stop the lens moving.

But "Triggered Auto" mode requires a trigger, I need the camera to be able to refocus automatically.
Anyway, I will play with the parameters in the tuning file, the changes you suggest already make a big improvement.


[Refactor] Renaming constant variable in persistent index to obey our coding style, to improve readability.

What type of PR is this：

[ ] bug
[ ] feature
[ ] enhancement
[x] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

you can not realize the const-ness of a variable named a_constant_variable, this style may misleading you think it is a mutable variable, instead of a constant.

run starrocks_admit_test

run starrocks_admit_test


Support specifying single HDF Group in open_virtual_dataset

[x] Closes #159, and part of #84
[x] Tests added
[x] Tests passing
[x] Full type hint coverage
[x] Changes are documented in docs/releases.rst
[ ] New functions/methods are listed in api.rst
[x] New functionality has documentation

@TomNicholas @forrestfwilliams I took a pass at this for basic functionality of loading a single group. Seems to be working for the couple datasets I'm trying out from https://nisar.jpl.nasa.gov/data/sample-data/

One other thing is that the group kwarg could also be supported when reading references from Zarr, but that could also just be flagged as an issue and left for a later PR, as the logic will be independent of the kerchunk-parsing logic here.

Yeah, sounds like a plan. I think this is now refactored and minimally functional. I'm sure working with other example datasets  with groups (https://github.com/pydata/xarray-data/blob/master/cmip6.nc) will uncover improvements or the need for additional tests.

Thank you @scottyhq !


Add slide caption option for a descriptive text

Small addition to the slide display options. Add a paragraph text below the slide title.

Seems reasonable. No points for maintaining test coverage :-1: Let's :shipit:


Add discord grouping method

Allow for users to join a discord group via the click of a button.

Add discord in plugin config, with verify button.

Add Match With Verified Users Bool in plugin config, default False.


Check if swiftc exists at path in bootstrap

Currently, when the bootstrap script is given an invalid swiftc path, its error message is unhelpful:
--- bootstrap: error: [Errno 2] No such file or directory

The boostrap script should clarify which exact file it was looking for and at what path. With this change a check for swiftc path is added, which is consistent with an existing path check in get_llbuild_source_path. Now the error message specifies the exact path it was looking for:
--- bootstrap: error: unable to find swiftc at
/home/builder/source/host-toolchain-sdk/swift-wasm-DEVELOPMENT-SNAPSHOT-2020-05-18-a/usr/bin/swiftc

@swift-ci please smoke test


Updating ipfs-coord for better UX

:tada: This PR is included in version 2.13.3 :tada:
Your semantic-release bot :package::rocket:


fix for lowercase comparison bug

Fix for #79

Interesting I think this might have gotten lost when I went from storing individual keys to storing them as a JSON blob.
Good catch, thanks!


[FEATURE] Implement logic to validate detector model

Is your feature request related to a problem?
Implement the logic from this method into the placeholder REST request handler created in #221 for the validate detector handler.
Issue #222 handles the detector type validation.  This issue handles the model validation in the else block here.

Superceded by #353


Include Year in parenthesis after movie names when adding content

Include the Year in parenthesis after movie names like this:
Wrong Turn (2021)
This would be great when adding content.
Without it, I've had to look up the Duration of a movie to determine which one to add.  Here's an example:

@vexorian
I found out that if you Remove Duplicates, it will remove one of the movies even though they are different movies.  This happened to me for both Wrong Turn and House on Haunted Hill.  Because of this, I've added the Bug label to Issue #267 and hope that Year can be taken into consideration when adding/listing/removing content, removing duplicates, etc.

It's a different problem, would rather it was a different report to prioritize it different


[Storybook] Basic style guide

https://storybook.js.org/docs/react/writing-stories/naming-components-and-hierarchy
https://storybook.js.org/docs/react/writing-stories/introduction


test: add test for goto_definition for label

I hope to implement goto_reference with labels, here is where I get started

I made a very simple implementation for goto_reference for labels, and it just works, I can split this pr into two if you find that better. BTW, may I ask where can I find ur discord channel?

I can split this pr into two if you find that better.

Let us split it.

BTW, may I ask where can I find ur discord channel?

Typst Discord Server > universe > Tinymist
Go to there if we are going to discuss features for tinymist.

Typst Discord Server > forge > IDE
Go to there if we are going to continue pushing features to typst/typst. Note: some features are not needed, and they prefer minimal implementations.

Thank you.


Deprecate tsocks

Describe the bug
tsocks last build was in 2013. the package is no longer maintained and its features are covered by torsocks.
I don't think we have any reason to keep this package:
7102ef5d49171bf1d42461df828773a41f78037d

torsocks and tsocks are not equivalent. torsocks needs a tor proxy for DNS, tsocks do not.

This is no longer accurate: https://gitlab.torproject.org/legacy/trac/-/wikis/doc/torsocks
Notify maintainers
@edwtjo

If it is feature complete, and continues to build, then I see no reason to remove it. It may continue to serve a purpose for those who desire a more lax proxy.


Check for **kwargs when adding handler

Raise exception otherwise to prevent runtime errors.

oh man this idea is awesome!


os.path replacement

Summary
This PR replaces all os.path to pathlib Path class.
Changes these areas

[ ] Bugfixes
[ ] Feature behavior
[ ] Command line interface
[ ] Configuration options
[x] Internal architecture
[ ] Archived data layout on disk

@afreydev got it. Please add tests if necessary for those cases.

nice job 👍 very focused PR and is exactly what I was imagining for this cleanup task


Contract Expiration Refactor

bulkRoleManager

removes expireContracts command

transactions

adds expireContracts command

adds transaction log
sends message to player who's contract expired to explain their free agency options

misc updates

formatting, spacing, typing

Approve


Displaying the “Default Value” so users don’t have to open each record to see the value

The Monitor Default grid does not display the actual default value (see screenshot). You have to click view/edit in order to see the value, but this shouldn't be happening.

Suggestions/comments from RT#72629

@annalbrecht  we discussed this ticket internally and would like to deprioritize this to Phase 1B. Could you please relabel this? Thank you.
FYA - This ticket was deprioritized since it isn't a blocker for industry submission and is a low priority compared with other development work.

@annalbrecht - could we relabel this from P-1B to 2025 (Q1 or Q2)? Internally, we discussed this ticket and are prioritizing other functionality. If the dev team has any questions, we can discuss them at the next meeting.


Remove macro in iter_to_array for List

Which issue does this PR close?

Ref #7988
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

I also did some ad hoc performance testing and this change did not change the performance for count distinct queries for me:
andrewlamb@Andrews-MacBook-Pro:~/Downloads$ /Users/andrewlamb/Software/arrow-datafusion/datafusion-cli/target/release/datafusion-cli -c 'select count(distinct trace_id), count(distinct "span.kind") from traces group by "service.name";'
DataFusion CLI v33.0.0
+---------------------------------+----------------------------------+
| COUNT(DISTINCT traces.trace_id) | COUNT(DISTINCT traces.span.kind) |
+---------------------------------+----------------------------------+
| 30714                           | 1                                |
| 30678                           | 1                                |
| 30714                           | 1                                |
| 30678                           | 1                                |
| 30673                           | 1                                |
| 3632710                         | 2                                |
+---------------------------------+----------------------------------+
6 rows in set. Query took 1.771 seconds.

And I verified (by putting a println in ) that this build array was getting called


Added plug-in release number to user-agent

Signed-off-by: Brady Siegel<EMAIL_ADDRESS>Changed the user-agent field aws-privateca-issuer to the GitHub release number. The big change on the cert request controller is due to the linter I believe.

/assign @maelvls


Use File.cp! rather than File.rename!

For users with /tmp mounted on another filesystem, File.rename! will
fail with EXDEV: cross-device link not permitted.

I had to merge manually, thanks! :heart:


Test PR workflow

Task/Issue URL: https://app.asana.com/0/1202552961248957/1202798538526951/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #2184   👈

This comment was auto-generated by Graphite.


Adding Scroll bar

Adding Scroll bar
Adding Scroll bar and track color gives the user good experience
@Anshgrover23 ,please assign this to me

https://github.com/Groverio/To-Do-List/pull/103 @Anshgrover23 ,I have opened the pr ,kindly review it
Thankyou


Provision "Crisis Communications"  template failed

Describe the issue
I tried provisioning the crisis communication template to my tenant, it failed
Expected behavior
Expected to have this template site available in our site collection for use.
Screenshots
n/a
Details (please complete the following information):

PnP Correlation ID: eb3424d5-b8e7-4355-8c96-2c48ee5e56eb
Reference Template: https://lookbook.microsoft.com/details/8f8337d2-b1f6-4a84-91a4-9081f841f0f6
Primary language of the target tenant: English
Are you using a Tenant Global Admin account to provision the template: Yes

Additional context
N/a

Hi,
Thanks for using the Look Book site. Based on the event log, we can see - based on the provided Correlation ID - that you targeted an already existing site and the exception was "Forbidden". Could you please try to provision the solution to a different site URL? In case of any issue, please create another item and provide the corresponding Correlation ID for further investigation. Thanks for your cooperation.


Add missing extension functions + prop window fix

Added missing getCurrentValue functions for functions that already had getDefaultValue: PropWindow, TurnSpeed, AcquireRange
Added functions with angle as parameter/return value for prop window functions.
Fixed a problem with getDefaultPropWindow:
The native returns the value in degrees, so it has to be converted to radians first. Usually all natives use radians.
Typo: AcquireRange

if the native returns it, an implicit conversion is even worse imo.
The getters should also return angle tuples.

The problem is, that GetUnitDefaultPropWindow uses degrees and GetUnitPropWindow uses radians, which makes it inconsistent.
There are getters that use angle, so they will be safe. I can change the functions that use real to return the same as the native and add hotdoc, so the user knows whether it is degrees or radians.
Similar to how it was done with facing angle, I used getPropWindow and getPropWindowAngle.

+1 for angle tuples, as far as we have them as standart. I think there shouldn't be a single function across the entire stdlib that takes or returns angle as a real instead of the tuple.

Ok I will remove the functions that return real then.
As I already said, I did it like this, because it's the same with getFacing and getFacingAngle.
Also regarding the latest commit. The name for the function is quite long, if you know a better name, let me know.

Hm, maybe you could do an overload for old function with a flag that decides whether to save ratio or not.

public function unit.setMaxHp(int hp, boolean keepRatio)
public function unit.setMaxMana(int mana, boolean keepRatio)
That's sound about right.

Yes, I agree. We want angle safety everywhere so the user never has to worry about mixing up radians/degrees again.

Only uses angle type for functions that use angles. Two old functions that still used reals have been annotated with deprecated.
As suggested setMaxHp/Mana was overloaded with a boolean keepRatio. Wurst's optimizer will remove the condition, as the boolean will be constant in most cases.

Yea looks good now 🍺


Update zh.json

Simplified Chinese translation

thank you so much for the effort!! With time a new releases more translations will appear,I\ll try to move here the English keys as they are so you can point them and make this same process :)


General issue for global_planner suggestion

Dear people
I have tested the global_planner with the command
$roslaunch global planner_sitl_mavros.launch in the outdoor environment the drone is suppose to work and I had some issues:

The drone suddenly stop during flying  the planned path.
When the drone got into the goal position after executing the planned path, it suddenly disarmed, then I armed it again  and it kept arm for a short period   and then it disarmed again.

Well, I guess if these issues happen in real simulation, the drone will crash.

Just a general question :)

What shall be the best way to use global_planner algorithm in a real simulation?.  I mean, Is  the best way to use it together with QgroundControlStation? Or,  just RVIZ and the real drone.

What is the safest way to use global_planner algorithm?

I guess, I need a secure mechanism in case global planner fail, right?

Thank you

@acpl00 please do not post duplicate issues.

I am sorry I forgot to delete the other one, but thank you for the replay :)


sched: replace sync pause with async pause for nxsched_suspend

Summary
In the kernel, we are planning to remove all occurrences of up_cpu_pause as one of the steps to simplify the implementation of critical sections. The goal is to enable spin_lock_irqsave to encapsulate critical sections, thereby facilitating the replacement of critical sections(big lock) with smaller spin_lock_irqsave(small lock)
Impact
nxsched_suspend
Testing
Configuring NuttX and compile:
$ ./tools/configure.sh -l qemu-armv8a:nsh_smp
$ make
Running with qemu
$ qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic -machine virt,virtualization=on,gic-version=3
-net none -chardev stdio,id=con,mux=on -serial chardev:con -mon chardev=con,mode=readline -kernel ./nuttx

[Experimental Bot, please feedback here]
The provided PR information is incomplete to determine if it meets the NuttX requirements.
Here's why:

Incomplete Summary:

It mentions removing up_cpu_pause and simplifying critical sections.
Missing: What functional part is changing? How does the change work exactly?

Unclear Impact:

Only mentions nxsched_suspend without explaining the impact.
Missing: Details about all other impact areas (build, hardware, documentation, security, compatibility, etc.).

Missing Testing Information:

No details about build host(s) or target(s) used for testing.
Missing: Testing logs before and after the change.

To meet the NuttX requirements, the PR needs to provide:

A complete summary: Clearly explain the functional change, the method used, and any related issues.
Detailed impact analysis: Address all impact areas with specific explanations.
Thorough testing information:  List the build hosts, target platforms, and include relevant testing logs from before and after the change.


blurred corners

I don't sure is this Hyprland's fault or tofi's, but when I use layerrule = blur, launcher in Hyprland to enable blur for tofi and corner-radius=20 there is blurred corners:

As I assume this is because tofi just sets corner color to transparent, but normal window border rounding works fine (without blurred corners) in Hyprland:

You may need another layerrule.
It's all the way at the bottom of Hyprland's Window Rules page. Try creating a new layerrule with ignorealpha.
layerrule = blur, launcher
layerrule = ignorealpha, launcher

Before:

After:

It works. Thanks.


These are wonderful spinners! Are they available on bower...?

Thank you for making these!
Are they available on bower? Your bower.json says:
{
  "name": "css-loading",
  "version": "1.4.0",

But bower install css-loading doesn't work. Searching bower doesn't return anything useful either:
bower search loaders
Search results:
ng-loaders https://github.com/jfeigel/ngLoader.git
yu-loaders https://github.com/lutaiphong/yu-loaders.git
loaders.css https://github.com/ConnorAtherton/loaders.css.git
svg-loaders https://github.com/SamHerbert/SVG-Loaders.git
css-loaders https://github.com/javoire/css-loaders.git
angular-loaders https://github.com/the-cormoran/angular-loaders.git
CNJS-LoaderSpinner https://github.com/cnelson87/CNJS-LoaderSpinner.git
ngWeaselLoaders https://github.com/redahas/ngWeaselLoaders.git
css-loading-spinners https://github.com/lukehaas/css-loaders.git

...?

@mercmobily now, this issues were be fixed. You can run bower install css-loading to install this repo! 😄

Hi,
Thanks!
Merc.
On 25 July 2016 at 09:00, Jovey Zheng<EMAIL_ADDRESS>wrote:

@mercmobily https://github.com/mercmobily now, this issues were be
fixed. You can run bower install css-loading to install this repo! 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jovey-zheng/loader/issues/2#issuecomment-234815191,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACB7XvWalRx_-eQjHWPcgDe47_CxR3zZks5qZAqbgaJpZM4JThro
.


Go to file by entering directly the path (Library / File / Member)

Changes
Go to file by entering directly the path (Library / File / Member)

Checklist

[X] have tested my change
[ ] updated relevant documentation
[X] Remove any/all console.logs I added
[ ] eslint is not complaining
[ ] have added myself to the contributors' list in CONTRIBUTING.md
[ ] for feature PRs: PR only includes one feature enhancement.

Very simple but it works.
Not sure to understand ...
My modifications was in the code-for-ibmi.goToFile command not in code-for-ibmi.openFileByPath.
I have put a placeholder with  quickPick.placeholder = `Go to file..`; I can change it to what you want.

@sebCIL Since code-for-ibmi.goToFile and code-for-ibmi.openFileByPath are the same now, I am suggesting we remove code-for-ibmi.openFileByPath.
What do you think of this?

Is it (still?) possible to open a file in the IFS using this - or is it limited to QSYS filesystem?

@chrjorgensen It supports both IFS and QSYS.

@worksofliam @sebCIL Then we just need to make sure that this is reflected by the prompt or placeholder - that both member and streamfile can be specified.

Ok, I made some changes.


Issue where in larger directories with more files scroll effect will move farther than the cursor

https://github.com/face-hh/griddycode/assets/61124766/e0e1ea4f-8e15-4879-b3aa-be44bec52b26

Duplicate of #19

Sorry didn't see that


fix: update collectible hover icon, closes #4971

This PR:

replaces the collectible hover icon with ExternalIcon
improves the hover effect so it doesn't disappear on hover in light mode as per https://github.com/leather-io/extension/issues/4971

Some more work is needed as on hover there is still as slight gap around the icon related to the button padding as you can see here:
https://github.com/leather-io/extension/assets/2938440/2dc6f147-9f18-4fe7-8804-55c922d36a51

@pete-watters I made a commit here, am I missing something or aren't the changes this simple? The IconButton is pretty well setup to receive these adjustments from what I see, if anything changes should be made to the component in the mono repo if needed? I'm not sure why you were adding a div around the icon passed to it? If nec, we could create a new recipe for the icon button and/or not use the Button component at all for it and create it's own variants, but I think the changes here are actually pretty simple?
cc @fabric-8 @markmhendrickson for design review here:

@pete-watters I made a commit here, am I missing something or aren't the changes this simple? The IconButton is pretty well setup to receive these adjustments from what I see, if anything changes should be made to the component in the mono repo if needed? I'm not sure why you were adding a div around the icon passed to it? If nec, we could create a new recipe for the icon button and/or not use the Button component at all for it and create it's own variants, but I think the changes here are actually pretty simple? The button should already have the 2px corners.
cc @fabric-8 @markmhendrickson for design review here:

Thanks @fbwoolf . This change doesn't give the icon itself a hover of ink.component-background-hover. That's the tricky part I was asking for help with here
The icon needs to look as we both made it but then on hover it should apply a colour effect of ink.component-background-hover to the full area of the button without disappearing in light mode.

applying the hover bg to the ExternalIcon leaves a gap of 8px of hover colour due to the padding
applying it to IconButton makes it disappear when in light mode

Here is a video demonstrating it:
https://github.com/leather-io/extension/assets/2938440/935a3b5d-5707-4a79-81e0-0e3edb5f3585
@kyranjamie @alter-eggo maybe you have some ideas on how to solve this?

@pete-watters I made a commit here, am I missing something or aren't the changes this simple? The IconButton is pretty well setup to receive these adjustments from what I see, if anything changes should be made to the component in the mono repo if needed? I'm not sure why you were adding a div around the icon passed to it? If nec, we could create a new recipe for the icon button and/or not use the Button component at all for it and create it's own variants, but I think the changes here are actually pretty simple? The button should already have the 2px corners.

cc @fabric-8 @markmhendrickson for design review here:

Thanks @fbwoolf . This change doesn't give the icon itself a hover of ink.component-background-hover. That's the tricky part I was asking for help with here
The icon needs to look as we both made it but then on hover it should apply a colour effect of ink.component-background-hover to the full area of the button without disappearing in light mode.

applying the hover bg to the ExternalIcon leaves a gap of 8px of hover colour due to the padding

applying it to IconButton makes it disappear when in light mode

Here is a video demonstrating it:
https://github.com/leather-io/extension/assets/2938440/935a3b5d-5707-4a79-81e0-0e3edb5f3585
@kyranjamie @alter-eggo maybe you have some ideas on how to solve this?

Got it, I can fix that, np. I didn't see a hover to the icon in the designs so misssed that was the issue. You want to reassign the issue to me? Happy to fix that part.

I think it makes more sense to change the IconButton itself so it can handle the icon hover? Still don't totally understand wrapping the icon here?

I think it makes more sense to change the IconButton itself so it can handle the icon hover? Still don't totally understand wrapping the icon here?

Thanks @fbwoolf . The wrapping solution was a suggestion from Fab in his initial report: https://github.com/leather-io/extension/issues/4971#issue-2148979607
It works in that the icon doesn't disappear but then it has this spacing issue. With what I got released last time, the hover effect is working but it's using the old icon.
I can re-assign to you. It's not an urgent thing to work on so no panic