HDDS-1779. TestWatchForCommit tests are flaky.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
57
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
473
trunk passed

+1
compile
269
trunk passed

+1
checkstyle
74
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
864
branch has no errors when building and testing our client artifacts.

+1
javadoc
163
trunk passed

0
spotbugs
316
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
505
trunk passed

_ Patch Compile Tests _

+1
mvninstall
450
the patch passed

+1
compile
268
the patch passed

+1
javac
268
the patch passed

-0
checkstyle
42
hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
682
patch has no errors when building and testing our client artifacts.

+1
javadoc
162
the patch passed

+1
findbugs
520
the patch passed

_ Other Tests _

+1
unit
338
hadoop-hdds in the patch passed.

-1
unit
2469
hadoop-ozone in the patch failed.

+1
asflicense
41
The patch does not generate ASF License warnings.

7595

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.hdds.scm.pipeline.TestRatisPipelineProvider

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1071

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux d6815f71900a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4a70a0d

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/1/artifact/out/diff-checkstyle-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/1/testReport/

Max. process+thread count
5231 (vs. ulimit of 5500)

modules
C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
95
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
537
trunk passed

+1
compile
265
trunk passed

+1
checkstyle
78
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1049
branch has no errors when building and testing our client artifacts.

+1
javadoc
194
trunk passed

0
spotbugs
338
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
547
trunk passed

_ Patch Compile Tests _

+1
mvninstall
495
the patch passed

+1
compile
285
the patch passed

+1
javac
285
the patch passed

-0
checkstyle
45
hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
781
patch has no errors when building and testing our client artifacts.

+1
javadoc
277
the patch passed

+1
findbugs
589
the patch passed

_ Other Tests _

+1
unit
336
hadoop-hdds in the patch passed.

-1
unit
2192
hadoop-ozone in the patch failed.

+1
asflicense
42
The patch does not generate ASF License warnings.

8010

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion

hadoop.ozone.web.client.TestKeysRatis

hadoop.ozone.TestStorageContainerManager

hadoop.ozone.web.TestOzoneRestWithMiniCluster

hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler

hadoop.ozone.web.TestOzoneVolumes

hadoop.ozone.client.rpc.TestContainerStateMachineFailures

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestBCSID

hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode

hadoop.ozone.om.TestOzoneManagerHA

hadoop.ozone.web.client.TestKeys

hadoop.ozone.dn.scrubber.TestDataScrubber

hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline

hadoop.ozone.client.rpc.TestWatchForCommit

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestReadRetries

hadoop.ozone.client.rpc.TestBlockOutputStream

hadoop.ozone.ozShell.TestOzoneShell

hadoop.ozone.client.rpc.TestKeyInputStream

hadoop.ozone.client.rpc.TestContainerStateMachine

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1071

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e3a0d0644ba4 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 1502e6a

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/2/artifact/out/diff-checkstyle-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/2/testReport/

Max. process+thread count
5245 (vs. ulimit of 5500)

modules
C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
36
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
485
trunk passed

+1
compile
266
trunk passed

+1
checkstyle
70
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
807
branch has no errors when building and testing our client artifacts.

+1
javadoc
163
trunk passed

0
spotbugs
317
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
510
trunk passed

_ Patch Compile Tests _

+1
mvninstall
437
the patch passed

+1
compile
258
the patch passed

+1
javac
258
the patch passed

+1
checkstyle
80
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
685
patch has no errors when building and testing our client artifacts.

+1
javadoc
163
the patch passed

+1
findbugs
526
the patch passed

_ Other Tests _

-1
unit
300
hadoop-hdds in the patch failed.

-1
unit
1690
hadoop-ozone in the patch failed.

+1
asflicense
51
The patch does not generate ASF License warnings.

6705

Reason
Tests

Failed junit tests
hadoop.hdds.scm.container.placement.algorithms.TestContainerPlacementFactory

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.TestSecureOzoneCluster

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1071

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux eb6c64493a2f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3dc256e

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/3/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/3/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/3/testReport/

Max. process+thread count
5340 (vs. ulimit of 5500)

modules
C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1071/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thanks @mukul1987 and @supratimdeka for the review. I have committed the change to trunnk.


update csrf link

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
https://github.com/yiisoft/yii2/issues/19017

👍🏻


fix(package): update eslint to version 4.4.1

Description of change
Update eslint.
Associated issue(s)
Closes #68

[x] The acceptance criteria for all associated issues have been completed, tested, and validated.

PR check-list

:white_check_mark: Please review and check the appropriate items.

1. Code standards compliance

[x] ESLint passes.

2. Code quality.

[ ] The quality gateways pass with an "A" grade.

Measure
Scores

Complexity

Duplications

Issues

Maintainability

Reliability

Security

3. Test coverage

[x] The source code is 100% covered with passing specs.

4. Contributor License Agreement (CLA)

[x] I have signed the Contributor License Agreement (CLA).

:information_source: These tasks are not required to open a PR, and may be addresses while the PR is open.

Changes Unknown when pulling c1167c0168abb9367c4f7977c291052239692bda on greenkeeper/eslint-4.4.1 into ** on develop**.

Changes Unknown when pulling c1167c0168abb9367c4f7977c291052239692bda on greenkeeper/eslint-4.4.1 into ** on develop**.

Changes Unknown when pulling c1167c0168abb9367c4f7977c291052239692bda on greenkeeper/eslint-4.4.1 into ** on develop**.

Changes Unknown when pulling cbbd728eb82b2640c671d28e3207bac7aa35813a on greenkeeper/eslint-4.4.1 into ** on develop**.

Changes Unknown when pulling cbbd728eb82b2640c671d28e3207bac7aa35813a on greenkeeper/eslint-4.4.1 into ** on develop**.

Changes Unknown when pulling cbbd728eb82b2640c671d28e3207bac7aa35813a on greenkeeper/eslint-4.4.1 into ** on develop**.


Warn of a higher grade road only connecting to lower grade roads

If one tries to save an isolated road in the middle of nowhere, iD will warn that it is unconnected to the road network.
That's good. But here is another situation iD could warn about too:

A higher grade road only connecting to lower grade roads.

(Except for the highest grade road in the whole island/continent.)

@jidanni Can you provide a link to a location you're seeing this?
I'm not sure this is always an error or something we need to bother iD mappers about, but perhaps I could be convinced.

(No link because I already hastily fixed that road already.)
Perhaps I could be convinced such items are not mistakes: provide one shopping center (campground, etc., even suburb) whose bigger road(s) inside are connected to the outside world by a smaller/poorer road.

@jidanni Yeah even if this warning would be valid it doesn't seem like a common or important issue for OSM right now. I think let's spend our development time elsewhere.

(Actually, the current check,

Is this road not connected to any other roads?

Is just a special case of the better check,

Is this road not connected to any other equal or higher class roads?

And in fact the same concept can be applied to any hierarchy,

roads, paths, trails
streams
bodies of water (ocean > sea > bay)
railroads
telephone, power, cable TV, gas. oil pipeline etc. networks
cell towers
political and cadastral boundaries (country > state > county ...)

Not only for lines and areas, but more generally:

Is this chain store missing which regional group it belongs to?

And in fact depending on what part of the world we are in, we can enforce

this District Office must belong to a Regional Office. You can't just
directly fill in the Headquarters or leave it blank, without getting a
warning.

And in the very rare case one is e.g., actually

Creating a new independent country
Building an island's first expressway

One can ignore the warnings.)

@jidanni Those are interesting ideas that might be useful for another tool, but again, I don't think this kind of thing is worth bothering iD mappers over right now.
Also, please refrain from changing the scope of issues after they've been closed. It creates confusion and is not an effective way to have an idea considered.


dynamic remaining count for gifts

count down the remaining number on a landing gift as its added to the basket

completed in 5241e3c19409d7d0703791867a78e54e0539a946


Preview Plugin - Support video preview of files stored in a Nexus Storage

Description
For a KG entity to which is attached a video File. we should be able to preview the video in place without having to download the file locally. For now we would play that file as it is if the media type can be supported without any form of conversion.
Initially, we will enable the Preview plugin to handle a distribution with an @type DataDownload and an encodingFormat video/mp4 to be previewed with a video player. To start with we can investigate if the React player used in the video plugin can be reused.
The plugin should be reading video data by asking Delta to provide the byte[] of the file stored.
Potential issue, with this strategy, if the video file is large, it might take a while for the client to first download it and before anything happens on screen. A message might help the user know that the video is being downloaded.
Errors should be shown int he following case:

if the user doesn't have necessary ACLs to read that file (HTTP 403)
if the file does not exist (HTTP 404)

Example of distribution payload
{
    "@type": "DataDownload",
    "contentUrl": "https://bbp.epfl.ch/nexus/v1/files/bbp/aibs/a642de11-a168-4e11-bf06-a89475780682",
    "digest": {
      "algorithm": "SHA-256",
      "value": "353bae9fce681cefa67b1dacdd2b51d31e2f43443e86c6f73f5239409b5d6266"
    },
    "encodingFormat": "video/mp4",
    "name": "Simulation.mp4"
  }

@smitfire has implemented a version of this in SBO. Worth checking before starting up.

@smitfire has implemented a version of this in SBO. Worth checking before starting up.


readme installation steps are wrong

README shows to install eslint-plugin-unused-import while the actual package name is eslint-plugin-unused-imports

Thanks for finding this!


Fix Settlement button total

Details
Displays the actual report reimbursable total in the display.
Fixed Issues
$ https://github.com/Expensify/App/issues/34618
$ https://github.com/Expensify/App/issues/34626
Tests
Pre-requisite: admin account with a free workspace and expensify card set up

Set the free workspace as your default
Incur a charge on an Expensify Card
Tap the report preview
Verify that the pay button does not show up in the expense report
Add a manual request
Verify that the total shown in the Pay button only includes the amount for the manual request

[x] Verify that no errors appear in the JS console

Offline tests
N/A
QA Steps
Same as test steps.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop
![desktop](https://github.com/Expensify/App/assets/22219519/d3213493-86a6-43b1-9345-4768423c985d)

@ntdiary yeah sure, thanks

Assigning @rushatgabhane per the comment above.

Bump for review

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Updated!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/techievivek in version: 1.4.33-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

@luacmartins @techievivek  I'm not sure which account the QA team should use for this PR?

@kbecciv do you have any account with the expensify card setup?

@luacmartins The Applausecard account has an Expensify card.
I tried using it, but I couldn't create a manual request for step 5
https://github.com/Expensify/App/assets/93399543/84d034f6-1ff8-4005-890d-e002d8528c69

@kbecciv could you try creating a manual request from the Workspace chat OR from global create?

Np, sorry I wasn't clearer in my initial steps. Anyways, it seems like the report with the ecard transactions had already been closed/approved so that's why you couldn't create transactions on it.

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Swift 3

Any plans to migrate to swift 3?

I did this in #10.

We just finished pushing up swift2.3 and swift3 branches. Cheers. 🍻


document.title incorrectly contains "(Preview)"?

The document.title of https://docs.microsoft.com/en-us/azure/cdn/endpoint-multiorigin is currently "Azure CDN endpoint multi-origin (Preview) | Microsoft Docs". This indicates that the feature is in preview. However, there is no indication other than this that the feature is in preview. This makes me unsure of whether the feature is in fact in preview, or if the title of the document is simply outdated.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bf4f77f8-2ec1-ab54-4ad7-08b65fb42603
Version Independent ID: 333e97b8-3016-b0cb-19b3-f8cde2447b5e
Content: Azure CDN endpoint multi-origin (Preview)
Content Source: articles/cdn/endpoint-multiorigin.md
Service: azure-cdn
GitHub Login: @asudbring
Microsoft Alias: allensu

Hi @taraldr
Thank you for reaching out. At this time we are reviewing the ask and will provide an update as appropriate

@taraldr , the feature is still in preview as mentioned here : https://azure.microsoft.com/en-us/updates/release-of-new-azure-cdn-microsoft-standard-capability/
It has not gone GA yet but will soon. We do not have a definite ETA though.


misc post-typing edits

[x] remove comments about type
[x] remove type slot_usages
[x] https://github.com/microbiomedata/nmdc-schema/issues/1574
[x] https://github.com/microbiomedata/nmdc-schema/issues/1553
[x] #1592

Looks like all these are completed, closing the issue.


Fix another case of spaces being decorated as types. [phab:D2237]

Created by fromberger at 2018-04-01 22:34:34:
Commit c6d09dd1 fixed one case of this, but missed another.

danielmoy-google accepted this revision at 2018-04-02 03:36:10

fromberger closed via commit 99c69fb38d565c9565a81a3e336ca952dce2aac5 at 2018-04-02 03:43:52


[WIP] Commands rework assembler

Summary
This updates assemble_schedule for commands-rework.
Details and comments

We need lo frequency configuration (LO is removed from Schedule in rework branch)
We need to include #8 to avoid conflict on pulse naming update

Agreed with @itoko

I added a test for assembler in another PR #22


displaying custom timezone in alert text got error

I've already done #861, but there still problems. After using time enhancement, I can receive right time in alert text, but elastalert print error:
ERROR:root:Error writing alert info to Elasticsearch: TransportError(400, u'mapper_parsing_exception', u'failed to parse [match_time]')
Traceback (most recent call last):
File "/opt/elastalert/elastalert/elastalert.py", line 1385, in writeback
doc_type=doc_type, body=body)
File "/usr/lib/python2.7/site-packages/elasticsearch-5.4.0-py2.7.egg/elasticsearch/client/utils.py", line 73, in _wrapped
return func(*args, params=params, **kwargs)
File "/usr/lib/python2.7/site-packages/elasticsearch-5.4.0-py2.7.egg/elasticsearch/client/init.py", line 298, in index
_make_path(index, doc_type, id), params=params, body=body)
File "/usr/lib/python2.7/site-packages/elasticsearch-5.4.0-py2.7.egg/elasticsearch/transport.py", line 312, in perform_request
status, headers, data = connection.perform_request(method, url, params, body, ignore=ignore, timeout=timeout)
File "/usr/lib/python2.7/site-packages/elasticsearch-5.4.0-py2.7.egg/elasticsearch/connection/http_requests.py", line 90, in perform_request
self._raise_error(response.status_code, raw_data)
File "/usr/lib/python2.7/site-packages/elasticsearch-5.4.0-py2.7.egg/elasticsearch/connection/base.py", line 125, in _raise_error
raise HTTP_EXCEPTIONS.get(status_code, TransportError)(status_code, error_message, additional_info)
RequestError: TransportError(400, u'mapper_parsing_exception', u'failed to parse [match_time]')

I have same issue,
ERROR:root:Error writing alert info to Elasticsearch: TransportError(400, u'mapper_parsing_exception', u'failed to parse [match_time]')
Traceback (most recent call last):
  File "/home1/irteam/naver/profile/keyolk/.local/lib64/python2.7/site-packages/elastalert/elastalert.py", line 1385, in writeback
    doc_type=doc_type, body=body)
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elasticsearch/client/utils.py", line 73, in _wrapped
    return func(*args, params=params, **kwargs)
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elasticsearch/client/__init__.py", line 298, in index
    _make_path(index, doc_type, id), params=params, body=body)
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elasticsearch/transport.py", line 312, in perform_request
    status, headers, data = connection.perform_request(method, url, params, body, ignore=ignore, timeout=timeout)
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elasticsearch/connection/http_requests.py", line 90, in perform_request
    self._raise_error(response.status_code, raw_data)
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elasticsearch/connection/base.py", line 125, in _raise_error
    raise HTTP_EXCEPTIONS.get(status_code, TransportError)(status_code, error_message, additional_info)
RequestError: TransportError(400, u'mapper_parsing_exception', u'failed to parse [match_time]')
WARNING:elasticsearch:POST http://staging.logiss.navercorp.com:29200/elastalert_status/elastalert [status:400 request:0.009s]
ERROR:root:Error writing alert info to Elasticsearch: TransportError(400, u'mapper_parsing_exception', u'failed to parse [match_time]')
Traceback (most recent call last):
  File "/home1/irteam/naver/profile/keyolk/.local/lib64/python2.7/site-packages/elastalert/elastalert.py", line 1385, in writeback
    doc_type=doc_type, body=body)
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elasticsearch/client/utils.py", line 73, in _wrapped
    return func(*args, params=params, **kwargs)
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elasticsearch/client/__init__.py", line 298, in index
    _make_path(index, doc_type, id), params=params, body=body)
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elasticsearch/transport.py", line 312, in perform_request
    status, headers, data = connection.perform_request(method, url, params, body, ignore=ignore, timeout=timeout)
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elasticsearch/connection/http_requests.py", line 90, in perform_request
    self._raise_error(response.status_code, raw_data)
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elasticsearch/connection/base.py", line 125, in _raise_error
    raise HTTP_EXCEPTIONS.get(status_code, TransportError)(status_code, error_message, additional_info)
RequestError: TransportError(400, u'mapper_parsing_exception', u'failed to parse [match_time]')

and more ...
INFO:elastalert:Sleeping for 9.943924 seconds
ERROR:root:Traceback (most recent call last):
  File "/home1/irteam/naver/profile/keyolk/.local/lib64/python2.7/site-packages/elastalert/elastalert.py", line 1245, in alert
    return self.send_alert(matches, rule, alert_time=alert_time, retried=retried)
  File "/home1/irteam/naver/profile/keyolk/.local/lib64/python2.7/site-packages/elastalert/elastalert.py", line 1325, in send_alert
    alert.alert(matches)
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elastalert/alerts.py", line 392, in alert
    body = self.create_alert_body(matches)
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elastalert/alerts.py", line 242, in create_alert_body
    body += unicode(BasicMatchString(self.rule, match))
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elastalert/alerts.py", line 135, in __str__
    self._add_custom_alert_text()
  File "/home1/irteam/profile/keyolk/.local/lib64/python2.7/site-packages/elastalert/alerts.py", line 72, in _add_custom_alert_text
    alert_text = alert_text.format(*alert_text_values)
IndexError: tuple index out of range

For the first error, change the name of the new field from @timestamp to local-timestamp or something, and use that in the alert_text instead.
The second error posted is because the number of alert_text_values doesn't match the number of {}'s in alert_text.

@Qmando It works! Thank you so much!

Hello,
How the rule extension look like in first case:
"For the first error, change the name of the new field from @timestamp to local-timestamp or something, and use that in the alert_text instead."
In other words, how store timestamp in new field ES?
In Python ...
Tell me Please!

Assuming your enhancement code is
from elastalert.util import pretty_ts
from elastalert.enhancements import BaseEnhancement

class TimeEnhancement(BaseEnhancement):
    def process(self, match):
        for k, v in match.items():
            if isinstance(v, basestring) and v.endswith('Z'):
                try:
                    match[k] = pretty_ts(v)
                except:
                    pass

Change the line
                    match[k] = pretty_ts(v)

to
                    match['local-timestamp'] = pretty_ts(v)

then add that to alert text
alert_text: "The alert occured at {}"
alert_text_args: [local-timestamp]

Thank you very much )


MIDI IN output from the optocoupler is missing a pull-up resistor

The MIDI IN output from the optocoupler is missing a pull-up resistor. Here's the schematic as of v1.0.0:

And here is the MID standard:

The pull-up resistor, Rd is missing.

Fixed in v1.0.1.


build status 'fail'

The wercker status has been showing the 'fail' state for quite some time now. I guess it was because of some machine error than an actual test failure. @rakyll can you rebuild it so that it won't deter any new visitors.

Sorry, I just noticed the wercker account is of @superlogical .

@hariharan-uno What do you need me to do? Sorry haven't really been helping out that much with martini-contrib

Don't worry. I did a workaround by sending an empty commit as a PR and it triggered the rebuild on that branch. Anyways, now the status is green. :)


Richer SASS / CSS framework

We should enrich the SASS framework to build Chartist styles more easily. This could include the following things:

Mixins to create most common animations on SVG CSS attributes
Cleanup existing SCSS code
Add more mobile specific things like swiping in containers with fixed width charts

This is no longer required


CA vs client validity

The 30 year validity described in the doc is apparently for the CA cert, while the client certs (I believe described in the line below) are only valid for 2 years.
"The kubectl client has a certificate for communicating with the AKS cluster."
In research for my current case I have run across at least 3 cases where this has caused confusion. Can we please update to make the difference clearer in this doc? Contact me at v-dibr internally if you need more info.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9b78509d-73eb-6c32-aee1-9b34685a64ff
Version Independent ID: 6f87cf70-1f5a-0f9e-862d-ae1436595f3b
Content: Rotate certificates in Azure Kubernetes Service (AKS) - Azure Kubernetes Service
Content Source: articles/aks/certificate-rotation.md
Service: container-service
GitHub Login: @zr-msft
Microsoft Alias: zarhoads

@dcbrown16
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@zr-msft
Can you please check and add your comments on this doc update request as applicable.

Yup this is correct the CA cert has 30 years validity but the others have 2 years validity..
@zr-msft please update the docs.
FYI @andyzhangx

Thank you for the feedback @dcbrown16. I've updated the docs and the changes should be available soon.

Thanks for the quick work everyone!


web projects

Have you read the Contributing Guidelines?

[✅ ] YES
[ ] NO

Project URL

What is the current behavior?

Issue Number: #... No issues

Category

[ ] 𝑴𝒊𝒔𝒄𝒆𝒍𝒍𝒂𝒏𝒆𝒐𝒖𝒔 𝑺𝒕𝒖𝒇𝒇.
[ ] 𝑫𝑺𝑨 + CP
[ ] 𝑻𝒆𝒄𝒉𝒏𝒊𝒄𝒂𝒍 𝑺𝒖𝒃𝒋𝒆𝒄𝒕
[ ] 𝑳𝒐𝒘 𝑳𝒆𝒗𝒆𝒍 𝑫𝒆𝒔𝒊𝒈𝒏
[✅ ] 𝑷𝒓𝒐𝒋𝒆𝒄𝒕𝒔
[ ] 𝑰𝒎𝒑𝒐𝒓𝒕𝒂𝒏𝒕 𝑩𝒐𝒐𝒌𝒔 𝒂𝒏𝒅 𝑹𝒆𝒔𝒐𝒖𝒓𝒄𝒆𝒔
[ ] 𝑩𝒆𝒉𝒂𝒗𝒊𝒐𝒖𝒓𝒂𝒍 𝑰𝒏𝒕𝒆𝒓𝒗𝒊𝒆𝒘 𝑸𝒖𝒆𝒔𝒕𝒊𝒐𝒏𝒔

Changes

Description of changes

Screenshots

(Add Running Work Demo Image)

React Blog Project

MERN project

Checklist ✅

[ ✅] I've read the instructions on the README file before submitting my application.
[✅ ] I've read the Contributing Guidelines.
[✅] I've checked the issue list before deciding what to submit.
[ ✅] I've follow Tree of Index.
[ ✅] I've add work in proper folder
[ ✅] I've not delete/modify previous codes.

You delete the many files
Don't remove any file
If any issue in the file so, create an issue

I have deleted the node_modules folder nothing else

I have deleted the node_modules folder nothing else

Check-in file change section
You change a total of 163 files
In these files, many files are deleted
Check the above comment code where I maintain Restore
These files are deleted


findWithQuery() issue when using ? as a param

In using the findWithQuery() method, I receive the error message:
      Caused by: android.database.sqlite.SQLiteException: near "?": syntax error (code 1): , while compiling: SELECT * FROM ? ORDER BY ROWID ASC LIMIT 1

when using the ? in the query string. Am I not using this correctly? When I remove the ? and put the table name in, it works fine. I'm not sure if this is related to how findWithQuery() builds the string/list for running sqLiteDatabase.rawQuery()
This line works:
    List<UpTimeEvent> list = UpTimeEvent.findWithQuery(UpTimeEvent.class, "SELECT * FROM UP_TIME_EVENT ORDER BY ROWID ASC LIMIT 1");

but this line does not.
    List<UpTimeEvent> list = UpTimeEvent.findWithQuery(UpTimeEvent.class, "SELECT * FROM ? ORDER BY ROWID ASC LIMIT 1",NamingHelper.toSQLName(UpTimeEvent.class));

I see that in the SimpleExtendModelTests.java it is being used like this:
SugarRecord.findWithQuery(SimpleExtendedModel.class, "Select * from " +
                                      NamingHelper.toSQLName(SimpleExtendedModel.class) +
                                      " where id >= ? ", "50");

shouldn't it be able to work both ways? e.g.
 SugarRecord.findWithQuery(SimpleExtendedModel.class, "Select * from ? where id >= ? ",                                           NamingHelper.toSQLName(SimpleExtendedModel.class), "50");

I see. It is part of the [SQLite API](http://developer.android.com/reference/android/database/sqlite/SQLiteDatabase.html#rawQuery(java.lang.String, java.lang.String[], android.os.CancellationSignal)). Only the where clause can take ? arguments.

You may include ?s in where clause in the query, which will be replaced by the values from selectionArgs. The values will be bound as Strings.
[Android SQLiteDatabase API](http://developer.android.com/reference/android/database/sqlite/SQLiteDatabase.html#rawQuery(java.lang.String, java.lang.String[], android.os.CancellationSignal))


Check that weave router is running before launching plugin

Fixes #2293.
I decided to error the entire launch-plugin operation if weave is not running; if I just errored on the network creation then there is no way to re-try that operation; next time round the code will see the plugin is running and return early.
Fundamentally, it doesn't seem to be very useful to run the plugin and output an error.

This has broken a test:
>>> Test ./090_docker_restart_policy_2_test.sh finished after 47.0 secs with error: exit status 1
Test docker restart policy
ERROR: weave container must be running before plugin can be launched

The broken test was starting just the plugin because it "knew this was OK"; the network had already been created.  We may expect that customers have the same assumption in special cases, so we need to highlight this in the release notes, but at the end of the day it isn't OK to run the plugin without the router.

argh. I've just realised that this was on the wrong branch.

argh. I've just realised that this was on the wrong branch.

Fixed.


IP update behavior can incorrectly assign a forwarder IP instead of the actual device IP

What issue do you have? Please be as thorough and explicit as possible.
Line 94 of lan.js tests if the packet address matches the device info. If it doesn't, line 95 assigns the packet IP to the device info. However, in complex networks (especially those with multiple subnets) this packet address may not actually be the device address! In my network, packet.address is the router address. This means that when the device info IP is updated, it is replaced with my router IP address, which causes the plugin to then send update requests to my router instead of my ewelink devices. In the logs, I am presented with a device unreachable error with my router's IP address.
Tested workaround:
As a workaround, I simply commented out line 95. This stopped the IP from being reassigned to my router IP, and restores correct LAN control behavior on my network.
Proposed fix:
Note that I am using DHCP reservations for all of my ewelink devices, and I am using static IP configuration within the plugin. The above workaround could negatively impact people with simple DHCP setups and no static plugin configuration. Instead, I would propose either of two more appropriate fixes:

Parse the packet for the true origin IP instead of using the packet IP (assuming dns-sd packets include this information.)
Check if static IP plugin configuration is being used for that device, and if so, do not attempt to update the IP at all.

I would submit a PR for one of these fixes, but I'm not yet familiar enough with the plugin structure and dns-sd to implement them properly myself.
Details of your setup.

Do you use (1) Homebridge UI-X (2) Homebridge CLI or (3) HOOBS?
Homebridge UI-X

Which version of Homebridge/HOOBS do you have?
v1.6.1

Which platform do you run Homebridge/HOOBS on (e.g. Raspberry Pi/Windows/HOOBS Box)? Please also mention your version of Node.js/NPM if known.
Run in a ProxMox container, with Node.js v20.5.1

Which version of this plugin (homebridge-ewelink) do you have? Has the issue started since upgrading from a previous version?
v12.0.0

Which eWeLink devices do you have that are causing issues? Please include product models if applicable.
Sonoff iFan-04

Hi @trevorirwin thanks for the issue here
I made some changes here:
https://github.com/bwp91/homebridge-ewelink/commit/70f8c1eb0c04f471b60074e5e221e8f5e9317ca2
and posted a new beta version of the plugin, could you try this?

Hi @bwp91,
I've installed and tested the beta. It is working, with no errors in the logs. However, there is unexpected output in the logs just after initialization:
[10/25/2023, 5:30:50 PM] [eWeLink] [Living Room Fan] changed IP address to [MY_ROUTER_IP].

and periodically:
[10/25/2023, 5:33:06 PM] [eWeLink] [Living Room Fan] receiving update {"light":"on","fan":"off","speed":1,"ip":"MY_ROUTER_IP","online":true,"updateSource":"LAN"}.

(I've replaced the actual router IP in both messages with MY_ROUTER_IP)


feat: better permission checking

Please describe the changes this PR makes and why it should be merged:
This adds a new function that will throw an Error if the bot does not have a required permission. Function still needs to be tested. Also this function still needs to be implemented.
Status

[ ] Code changes have been tested against the Discord API, or there are no code changes

Semantic versioning classification:

[ ] This PR changes the library's interface (methods or parameters added)

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

What is the difference between botDependsChannelPermissions() and botHasChannelPermissions()?
This should be mentioned as a note in the JSDoc comment block.

The difference is if the bot does not have permission an error will be thrown.
Comment still needs to be added for botDependsPermission()

botDependsChannelPermissions() needs a better name.

Again, can you remove irrelevant changes from the PR? (editChannelOverwrite())

That function got removed somehow due to PR interfering.

That function got removed somehow due to PR interfering.

Could you open a new PR for it and remove the function from this PR?

Could you open a new PR for it and remove the function from this PR?

Will create PR when this PR is is merged. Don't want merge issues.

Rewritten the code is not tested yet. Could still contain bugs.

@Skillz4Killz What are your thoughts on adding a test case for this?

Closing this due to inactivity.


[Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2021-09-01-preview

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

End of Sept.

When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

End of Sept.

If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

/azp run

@gavinfish , can you go thru ARM API Review Checklist in the first comment of this PR so that ARM can be notified for the further review?

    "content": {

does this need to be handled as a secret?  https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html#oapi013-secrets-must-be-annotated-with-x-ms-secret-and-x-ms-mutability

Refers to: specification/appplatform/resource-manager/Microsoft.AppPlatform/preview/2021-09-01-preview/appplatform.json:3984 in 5910c8b. [](commit_id = 5910c8b63e0d4ded0ae86a8312c4f9e1ee15cb01, deletion_comment = False)


[Error][Swift][deliver][submit] Use of Advertising Identifier (IDFA) is required to submit

New Release Candidate Issue Checklist

[x] Updated fastlane to the latest release candidate version (2.150.0.rcX)
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Information

Breaking version: 2.151.1
Last working version: 🤷♀
State of app: Prepare for Submission
First version of app?: No

Issue Description
I've always specified the submissionInformation in my Deliverfile.swift file and it used to work (pre-2.150.0). I haven't been able to submit a build for review (from 0 to hero with no human interaction) ever since 2.150.0, and this is the latest error I've been facing:
Deliverfile.swift:
    /// Extra information for the submission (e.g. compliance specifications, IDFA settings).
    var submissionInformation: Any? {
        return [
            "add_id_info_limits_tracking" : true,
            "add_id_info_serves_ads" : false,
            "add_id_info_tracks_action" : true,
            "add_id_info_tracks_install" : true,
            "add_id_info_uses_idfa" : true,
            "content_rights_has_rights" : true,
            "content_rights_contains_third_party_content" : true,
            "export_compliance_platform" : "ios",
            "export_compliance_compliance_required" : false,
            "export_compliance_encryption_updated" : false,
            "export_compliance_app_type" : nil,
            "export_compliance_uses_encryption" : false,
            "export_compliance_is_exempt" : false,
            "export_compliance_contains_third_party_cryptography" : false,
            "export_compliance_contains_proprietary_cryptography" : false,
            "export_compliance_available_on_french_store" : false
        ]
    }

This PR might be related to this: https://github.com/fastlane/fastlane/pull/16706
Complete output when running fastlane, including the stack trace and command used

+--------------------------------------+-------------------------------------------+
|                             deliver 2.151.1 Summary                              |
+--------------------------------------+-------------------------------------------+
| username                             |<EMAIL_ADDRESS>                    |
| app_identifier                       | com.zilly.zilly                           |
| app_version                          | 2.30.0                                    |
| platform                             | ios                                       |
| edit_live                            | false                                     |
| use_live_version                     | false                                     |
| metadata_path                        | ../tellus-ios-app-store-metadata/metadata |
| skip_binary_upload                   | true                                      |
| skip_screenshots                     | true                                      |
| skip_metadata                        | false                                     |
| skip_app_version_update              | false                                     |
| force                                | true                                      |
| overwrite_screenshots                | false                                     |
| submit_for_review                    | true                                      |
| reject_if_possible                   | false                                     |
| automatic_release                    | false                                     |
| phased_release                       | false                                     |
| reset_ratings                        | false                                     |
| run_precheck_before_submit           | true                                      |
| precheck_default_rule_level          | warn                                      |
| individual_metadata_items            | []                                        |
| ignore_language_directory_validation | false                                     |
| precheck_include_in_app_purchases    | true                                      |
| screenshots_path                     | ./fastlane/screenshots                    |
+--------------------------------------+-------------------------------------------+

[…trimmed…]
…
…
[20:28:57]: fastlane finished with errors

[!] Use of Advertising Identifier (IDFA) is required to submit
Add information to the :submission_information option...
   It seems like submissionInformation is getting sent over from the Swift interface to the Ruby runner 🤔 I will try to take a look at this tomorrow to see what’s going on!

Thanks for the prompt response again! 🚀

In this issue I noticed that there was an issue with the example copy printed out ☝ So I opened a fix here https://github.com/fastlane/fastlane/pull/16807

@joshdholtz I took a stab at fixing this issue today, and I'm happy to say I resolved the issue! Although I'm not sure if a fix is needed...
So due to lack of better debugging knowledge 🤷♀ I added dozens of UI.message logs around the ruby code, printed the stack trace until I tracked down where the submission_information was being lost... Apparently it wasn't being received even in the lowest level of the socket layer, in socket_server.rb:
def parse_and_execute_command(command_string: nil)
  UI.message("Roger's logs parse_and_execute_command(command_string: #{command_string}") // It wasn't present here
  command = CommandParser.parse(json: command_string)
  UI.message("Roger's logs command: #{command.to_yaml}")
  case command
  when ControlCommand
    return handle_control_command(command)
  when ActionCommand
    return handle_action_command(command)
  end

  # catch all
  raise "Command #{command} not supported"
end

So I started thinking that was too weird, and decided to check the Swift code more closely... Until I realized this sneaky change:
https://github.com/fastlane/fastlane/commit/fb4a23c5b19607a8eefa81ad5a83099b573ed425#diff-62f1882363af9a2f50f7e0603fe971ddR518
And I realized that I was using the old type notation (var submissionInformation: Any?) as you can see in this issue's original description.
tl;dr: This change in my Deliverfile.swift fixed the issue:
    /// Extra information for the submission (e.g. compliance specifications, IDFA settings).
-    var submissionInformation: Any? {
+    var submissionInformation: [String: Any]? {
        return [
            "add_id_info_limits_tracking" : true,
            "add_id_info_serves_ads" : false,
            "add_id_info_tracks_action" : true,
            "add_id_info_tracks_install" : true,
            "add_id_info_uses_idfa" : true,
            "content_rights_has_rights" : true,
            "content_rights_contains_third_party_content" : true,
            "export_compliance_platform" : "ios",
            "export_compliance_compliance_required" : false,
            "export_compliance_encryption_updated" : false,
-            "export_compliance_app_type" : nil,
+            "export_compliance_app_type" : "",
            "export_compliance_uses_encryption" : false,
            "export_compliance_is_exempt" : false,
            "export_compliance_contains_third_party_cryptography" : false,
            "export_compliance_contains_proprietary_cryptography" : false,
            "export_compliance_available_on_french_store" : false
        ]
    }

(note that I don't know what to do with export_compliance_app_type, nor know what it is for, but using "" worked 🙈 )
Doing that made the submission_information.[…]-related entries show up in deliver Summary table again, and fastlane finished with success 🚀
Now, not sure how you wanna address this issue... Maybe leaving as is isn't too bad, people will definitely face issues but they can find this issue in GitHub. Other 2 ways to fix it would be make Any readable again, or revert the code to receive Any instead of the Swift dictionary... But sounds like these alternatives are too much hassle for a non-issue 🤷
Hope this helps you @joshdholtz , since my issue was resolved, feel free to close this issue if no change is going to happen 👍
Cheers

@rogerluan Oops! I missed this response 😱 We should probably change Any to Any? but maybe @minuscorp might have a better thought? 😇

@joshdholtz no worries! I think that omitting the key that would have a nil value would work (I haven't tested doing that in my Swift config), and essentially it's the same behavior as [String:Any?], but requires no changes in the fastlane 😇 What do you think?

I can test this on my next release btw, just to make sure

Or I could actually use the right export_compliance_app_type value, the problem is that idk what to put there, cuz idk the possible values (there's no documentation for this) 🙈
I think this falls into the "split submission_information into separate fields" task hehe

If you want to try to put nil change the type to [String: Any?] directly, idk if that works when being parsed to Ruby though

@minuscorp What is the different between Any? and AnyObject?? 😇
@rogerluan I completely agree with the split submission information part. I do really want to focus on a rework here 🙃 Maybe we close this since things will get reworked in #16854?

Gotta be Any, AnyObject is a metatype protocol which all classes conform to, so Int, Double, String, are structs cannot be AnyObject my bad, my brain is dead today.

Sure, I'll test that case too @minuscorp !
@joshdholtz I'd be in favour of that, maybe we'd be wasting time here. I just wanna test those cases to make sure we understand what's the current state of things 👍

Closing this issue.
Current workaround: https://github.com/fastlane/fastlane/issues/16799#issuecomment-657170824
Future improvement: https://github.com/fastlane/fastlane/issues/16854


Improve docs of embed_id

This is PR for improving docs of functions/links. Related issue: #2182
Modified functions/links:

functions/connection/embed_id.py

LGTM

Jenkins, test this please


BUG: Cannot save OCR output after scanning image

Error:
(cp: cannot stat '../img/sample2.jpg': No such file or directory)
After scanning sample image.

FIXED!


IotHub Service Client full implementation and unit tests

Hi it looks like this is very close to being approved is there anything I can do to help speed it up?  Perhaps add samples?  We're having a terrible time trying to build the C dependencies for azure-iothub-service-client 1.4.6 on OSX 10.15 and it would really simplify things if we could just use this release.  Alternatively, is there a way with azure-iot-hub 2.0.0rc2 to query for device names?  Thanks!

We are finishing this PR with samples. Yes, there is a "query_iot_hub" API on RegistryManager

In reply to: 561771987 [](ancestors = 561771987)

/azp run


Upgrade react-native to the 0.15.0, there is a warning  in ParseHTML

Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of ParseHTML.

working on this issue at the moment

The master has been updated with react native 0.16 and all warnings have been resolved.


InstancesAdvancedIT test setup fails on PermissionDeniedException

Setup method (attributed with @BeforeAll) of the test class InstancesAdvancedIT fails. It calls untested code sample compute.CreateInstancesAdvanced.createFromPublicImage.
See test log1, test log2 for the error.
The test class is disabled until the issue is fixed.

Due to a large amount of flaky tests that fail with similar error I made a change to the description of #9373.
I close this as a duplication of #9373.


Add extra settings for puzzle rules

Adds two additional settings that affect the puzzle rules:

Require all tiles to be locked for the game to be considered solved (I personally like systematically solving every tile, so want to be able to confirm that, even if the puzzle ends up in a solved state).
Remove all edge marks on a tile when it is locked (most of the time I remove edge marks from locked tiles to keep the board tidier).

I don't think I want to adopt the extra rule for "everything locked"... If you really want this behaviour you could lock some tile away from its proper place and only turn it back at the very end when everything else is locked down.
Now considering edgemarks I get the desire to see less visual noise on the board. But maybe this should be a display only thing - don't remove the marks from tile data but instead don't show them if they match a locked edge. This way if you accidentally lock a tile you don't lose edgemark information.
This will need some querying of a tile's neighbours to determine if an edge is locked from any side and if the locked wall/connection matches the mark.
I'm currently working on supporting non-uniform grids and may refactor how edgemarks are shown. So maybe create an issue for this but wait a bit before working on an implementation.


ecc: support ECDH algs

This PR mainly support ECDH algs, including:

support ECDH keygen and derive algs
support switching to openssl software methods
add test commands of ECDH

Add bugfix about the code framework of RSA


feat: updated camera to react-native-vision 3

Summary of Changes
Replaced the depricated RNCamera module with react-native-vision-camera. Updated tests to be compatible. I had to make some modifications to the android permissions text... but it looks like they weren't being used anyway for some reason. This should be a transparent change, I've tested in the android emulator API version 30 and 32, as well as an iphone physical device. I was running into an issue on API version 30, but I wasn't sure if that was just a problem with the emulator itself. Other than android API 30 it works great on all versions. I'd appreciate some help testing the changes on different versions especially on android.
Additionally I've made sure the torch functionality works well.
Other advantages of this library:
It provides support for non QR code barcodes out of the box so we can provide more specific error messages if the user tries to scan their driver's license, etc.
Related Issues
Fixes bcgov/bc-wallet-mobile#1653
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

[x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[x] Updated documentation as needed for changed code and new or modified features;
[x] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

What was the issue on API 30? Just so we can look out for it

Looks like you may need to update the gradle lockfile in Bifold too

What was the issue on API 30? Just so we can look out for it

I'd get a repetitive error saying failed to load depricated vision dynamite module

@wadeking98 We go back pretty far for Android API compatibility - no? Do you think we'll loose anything with this change?

I've fixed the issue for api level 29 but I'm still running into issues with API level 30: https://github.com/mrousavy/react-native-vision-camera/issues/2287

I've confirmed this is working with API level 29, 30, 31 now


[fix] add estimators to allowed_symbols in contrib.learn

Fix
import tensorflow as tf
tf.contrib.learn.estimators

results in
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'module' object has no attribute 'estimators'

Can one of the admins verify this patch?

Which symbol do you need from estimators? Is it not accessible directly in tf.contrib.learn

Seems like the code in docs has been updated to use
tf.contrib.learn.ModelFnOps

instead of
tf.contrib.learn.estimators.model_fn.ModelFnOps

I think this can be closed now.


Training on own data set without groundtruths

Is there any way that we can make this as unsupervised learning as I wanted to try on indoor dataset

I suggest you use the augmentation of SiLK with our architecture.
I have tried making the objective unsupervised but haven't had success so far.


Register append function to list type

This is my attempt to add append to the list object

I see what you mean about the chicken-egg problem with all these methods. I think we need a vm.new_method to handle it.
This looks good though.


请问这个项目还继续开发吗，半年不更新了。

请问这个项目还继续开发吗，半年不更新了。

Weex 的代码一直在更新，参考这里： https://github.com/apache/incubator-weex/pulse/monthly

July 13, 2018 – August 13, 2018
Excluding merges, 19 authors have pushed 84 commits to master and 93 commits to all branches. On master, 238 files have changed and there have been 13,389 additions and 1,138 deletions.


Why nothing in the doc mention data-vaul-drawer-wrapper ?

Maybe I missed it but I cannot see anything in the doc mentioning the need of the data-vaul-drawer-wrapper wrapper, why is that ?
Additionally, would it be possible to get rid of it altogether and just have it working out of the box with only the option shouldScaleBackground set to true ?

It took me a while to understand what makes the background scale on the main page of vaul. This should be documented, shadcn is using it by default.


Fix format of ServerConnector toString

Once I noticed this in the logs I couldn't unsee it anymore...

Thanks!


Error objet '_tseriespatterns_label_direction' not found

Hi Jonathan,
I try your package but i have some mistakes...
install_github("tr8dr/r-tseries-patterns")
library(tseriespatterns)
getSymbols("AAPL", from="2001-1-1", src='yahoo')
df = data.frame(time = index(AAPL), price = as.vector(AAPL[,'AAPL.Adjusted']))
obj <- AmplitudeBasedLabeler$new (minamp = 2000, Tinactive = 50)
labels <- obj$label (df[200:1000,], time = "time")
Error in label_direction(self$cumr, self$minamp, self$Tinactive) :
objet '_tseriespatterns_label_direction' not found
Have you idea ?
Regards
Ludo.

Hi, Sorry, I missed this question.  It looks like the Rcpp library is not being found in your path.  I did not encounter that on OSX or Linux, so suspect is a difficulty with Windows.   I would need to get access to a windows box to check.   Might be easier to get working in the python package.


add price for sejuno, seasy from osmo pools

Could we remake this branch from master? It seems there's a lot of conflicts.
Maybe all changes? here-
https://github.com/osmosis-labs/osmosis-frontend/pull/826/files#diff-2a21e7fe48d12f0605b436af3ebf0197d40c964cd00da0600a2032a52c72c0d6

Updated https://github.com/osmosis-labs/osmosis-frontend/pull/844


docs/node/validator-node: Improve Initializing an Entity

Fixed in #626 in combination with https://github.com/oasisprotocol/cli/pull/155.


[5.0] when() on router doesn't run middleware.

Currently the when method of the router only runs filters when used. However, when using the route:list command it shows the middlewares as registered on the routes just fine.
From the comment for the when method, I would assume the list generation is buggy since they shouldn't be registered. However, I would like to see if Router::when() could also work for middlewares to reduce duplication of definitions throughout routes.
Which is the bug and how should it be go about getting fixed?

Thanks for reporting this.

So you saying when the when method is used no middlewares are run at all?

Yea, they never execute. Nor do they execute when using the group method. However, they appear in route:list as if they are attached for execution.

Can't recreate. Submit a failing test if you feel the problem persists.


enhancementuse new method to serialize keys in batch if the key is too large

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.23 seconds
load time: 437 seconds
storage size:<PHONE_NUMBER>0 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221122081457_clickbench_pr_50552.html


Adds browserless login

Adds browserless login and the ability to automatically log into a cluster on container launch.

Got some one thing that may help us until srelogin is in a final form:
Can we pull it from the source? On my local setup I put it as a volume and kept pulling it, though for now taking the lastest should work aswell.

I tried to "merge upstream" the srelogin, and found all we need to so is set one of 4 env vars to make it work without modifications
see closed PR https://github.com/mbarnes/work-environment/pull/3#issue-525330571

Nice, thanks for the tip @georgettica.  I've updated the cluster-login script to what's current as of 10 minutes ago and updated ocm-container.sh to reflect the USER env var (I still want to give flexibility for those who's OCM username might be different from their kerberos username.)

which is mine aswell, you can always do
$ USER=aaa python3 -c 'import getpass; print(getpass.getuser())'
aaa

and call the srelogin with that argument

Right.  If it changed a lot, or on a per-call basis you could do that.  But setting it as a config var inside your env.source once is kind of a set-it-and-forget-it-until-you-have-to-set-this-up-again-and-then-you're-confused-because-nothing's-working-the-way-it-used-to approach.

hahha, oki I am fine with that

@drewandersonnz should we do something else before merging?
maybe a knowledge sharing on the internal setup of the configs?

/lgtm


Enable typing for external users

Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[x] Did you write any new necessary tests?
[x] Did you update the CHANGELOG?

Proposed Changes
Enable typing for external users by add py.typed marker.
Enable typing docs

Closing issues

Codecov Report

Merging #868 (6c0cfba) into master (ced2072) will decrease coverage by 35.29%.
The diff coverage is n/a.

:exclamation: Current head 6c0cfba differs from pull request most recent head f7e35d6. Consider uploading reports for the commit f7e35d6 to get more accurate results

@@             Coverage Diff             @@
##           master     #868       +/-   ##
===========================================
- Coverage   84.75%   49.45%   -35.30%
===========================================
  Files         132      132
  Lines        7471     7471
===========================================
- Hits         6332     3695     -2637
- Misses       1139     3776     +2637

Impacted Files
Coverage Δ

etna/commands/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

etna/commands/backtest_command.py
0.00% <0.00%> (-97.06%)
:arrow_down:

etna/commands/forecast_command.py
0.00% <0.00%> (-94.88%)
:arrow_down:

etna/models/utils.py
12.50% <0.00%> (-87.50%)
:arrow_down:

etna/commands/__main__.py
0.00% <0.00%> (-87.50%)
:arrow_down:

etna/libs/pmdarima_utils/arima.py
16.00% <0.00%> (-84.00%)
:arrow_down:

etna/commands/resolvers.py
0.00% <0.00%> (-80.00%)
:arrow_down:

etna/analysis/outliers/density_outliers.py
22.44% <0.00%> (-75.52%)
:arrow_down:

etna/datasets/datasets_generation.py
27.02% <0.00%> (-72.98%)
:arrow_down:

etna/transforms/timestamp/time_flags.py
27.02% <0.00%> (-72.98%)
:arrow_down:

... and 81 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Organize template display to be in row, group badges elements in just one div, and correct License path

@Fernanda-Kipper after just take a look of it, please!
And I hope that you doing great.


Expand properties on computed decorators

Solves #38

Can you add the new ember-1-13-x and ember-2-0-x scenarios to .travis.yml (can be a separate PR though).

This is a breaking change (arguments to callback changes), so I'll release master first then we can bump properly.

@rwjblue d'oh.

Released as v0.2.0


Remove logrus dependency and use common logger.

This dependency seemed arbitrary and completely unneeded. So why not remove some code? :)

@markusthoemmes thanks! that's some leftover code we had there.. also the unit tests fails due to go-cmp (if you use the 4.0 this is fixed).
Let me try to get a PR merged that fixes this, and then you can rebase.

Rebased!

/lgtm

/approve
/lgtm


style: Fixed styling for commit message hook

The Issue
Commit hook needs improvement
How This PR Solves The Issue
Fixes style and logic errors in bash  script
Manual Testing Instructions
None
Automated Testing Overview
None
Related Issue Link(s)
N/A
Release/Deployment Notes
No changes to release flow

When making a PR like this, make an effort to explain and show visually what you're doing. The title says "Fixed styling" but nothing in the PR says how, why, what was wrong with the styling, or how it's better now. Please edit to show these things, thanks!

When making a PR like this, make an effort to explain and show visually what you're doing. The title says "Fixed styling" but nothing in the PR says how, why, what was wrong with the styling, or how it's better now. Please edit to show these things, thanks!

Commit message is with the changes is not enough?

No, the commit message doesn't give any info at all, and the whole idea of a PR is to explain the purpose and result of a change. This is super important when working with teams, whether open-source or not. Good communication is more important even than good code when collaborating with others.

Thanks !


Organize Available Packages in Installer GUI

As packages continue to increase, it'd be great if we had a way to better display / organize available packages.
Initial ideas:

By category
By distribution flavor (e.g., FLARE VM, Commando VM, Threat Pursuit VM)

I'm planning to take a stab at improving the FlareVM GUI packages interface and sorting things into categories.
My initial attempt has led me to realizing that we may need a slight design change somewhere, so that I'm able to get categories (and ideally their associated packages) over to the flare-vm installer easily.

I wish we could pass more metadata through our CI via choco push to our myget so that when we pull the info via choco search, we'd be able to get the associated category as well, but that seems to be unlikely, since that's not what it's designed for.

My current though is to modify categories.txt so that we include the associated package names with each category using an xml structure instead.

This would require us to keep it in sync with any category changes (either at a package level or just category name level), but I think this tradeoff is worth the investment.
This also gives us a quick high level overview of what packages fall into each category at a glance, which might be useful data to be aware of.
This would also of course require some modifications to various templates and scripts that rely on categories.txt the way it is now, which should be fairly trivial imo.


[PROD] Wording/text updates (spelling, new link)

A few requests please - all are front end spelling/wording/links, so hope it's OK I've put them all in one ticket.
Catalogue of Surge Services

[x] Spelling fix please - several of the Catalogue of Surge Services pages (e.g. IM, Cash and others) have incorrect spelling in the technical competencies section (say "compentencies", should be "competencies")

- [ ] Additional link please - IM Catalogue of Surge Services - please add an additional link in the Technical Competency Framework section - "Information Management" (above the existing "Assessment" link) Alice is requesting this to happen via the usual process rather than my ticket  - now logged as https://github.com/IFRCGo/go-web-app/issues/566
Resources page

[x] Update the GO Contacts section on https://go.ifrc.org/resources - Europe Region should no longer be Luis Fanovich, should now be Henk HOFF<EMAIL_ADDRESS>[x] Data Playbook link in the IFRC Guidance Material section is outdated - should instead link to https://preparecenter.org/toolkit/data-playbook-toolkit-v1/

Thanks!

I updated the contacts for Europe and MENA as I noticed it can be done from https://goadmin.ifrc.org/en/admin/api/maincontact/

Great catch, @nanometrenat , this compent... mispelling comes out a lot of places:

Both look good on https://go-stage.ifrc.org/surge/catalogue/information-management - thanks

All good in Production, thanks a million

Reopening - I have just seen in GO today that the "compentencies" spelling gremlin is still there in Production in non-English languages.  It was fixed in English but not in other langs.  This is a screenshot of Spanish IM CoS page but this issue is also in other sector CoS pages.
@tovari I am not familiar with how translations are managed so if I should update wording directly somewhere then please let me know the process - thanks a million

Reopening - I have just seen in GO today that the "compentencies" spelling gremlin is still there in Production in non-English languages. It was fixed in English but not in other langs. This is a screenshot of Spanish IM CoS page but this issue is also in other sector CoS pages.
@tovari I am not familiar with how translations are managed so if I should update wording directly somewhere then please let me know the process - thanks a million

Recently this "spanish compentencies" seems to be ok:

I found the "compentencies" in the database dump, so it's true that they must be fixed there also (not only in the frontend code's English texts). I am on it...

postgres=> select id, value from lang_string where value like '%compentenc%';
...
27953 | Tiered compentencies describing the knowledge and skills expected of personnel in this sector.
27954 | Tiered compentencies describing the knowledge and skills expected of personnel in this sector.
(49 rows)
I fix them asap...

@nanometrenat hi, fixed in the database of tranlsations also. (Sorry that only now.)

Belatedly closing as the typo is now fixed in Spanish/French as well - thanks a million!


Use AA+ 2.44, with necessary modifications

~Not tested.~ Did ran SwiftAATests, 7 failing out of 197.
Do note that KPCAAElliptical now has Pluto commented out, as its removed from AAElliptical.
Maybe fixes #110

Thanks a lot for this large and great pull request! I'll have a look asap this week-end!

@vincentneo please allow me to write on your branch. Your PR is helping fixing a few things along the way, that's really cool (I am reviewing all the failing tests, fixing one after the other).

That's it, I've all tests green again.

@vincentneo please allow me to write on your branch.

btw, do I need to do anything to allow write access?

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Well I don't know if you did something. On my side, not completely sure of how to use the GitHub CLI, I nonetheless tried to push my changes to that PR and tadaaa, here there are. Hence, I can now merge. And I will make a release right after it.

I haven’t had the chance to do anything just now, so I guess it does work by itself after all :)

Well, PR is merged, thanks you very much. However, I am just unable to make a CocoaPod release for now. Too many cryptic compilation errors. Even the command swift test doesn't work. I am playing updating the Package.swift file, but to no avail.

It seems the AA+ author updated some stuff. One needs to investigate how he changed his way of compiling... What I don't understand is that Xcode is able to compile and run the tests. Yet, impossible to go beyond that.

@onekiloparsec
I had to change ObjCAA to compile using C++ 17 because of a change in AA+.
In AAVSOP87D_EAR.cpp,

PJN / 22-04-2020 1. Reworked C arrays to use std::array.

I believe this change, which uses constexpr, required it to be compiled using C++ 17, at least when I couldn't compile it, I searched around and C++ 17 seemed to be the solution as it worked. (I am not a C/C++ developer)

My guess is swift test internally compiles C++ code at a lower C++ dialect, hence failure, and CocoaPods is just using the default behaviour.
This change in this answer may help in CocoaPods deployment, if the C++ issue is the reason: https://stackoverflow.com/a/63233322

Still struggling a bit (pod spec lint still fails). I'll be off in vacations for a week, and I'll restart right after that.

I just realised you haven't created a release (2.4.0) on GitHub, maybe its that.
(in case if the lint error was due to fatal: Remote branch 2.4.0 not found in upstream origin)
Anyways, just ignore this and enjoy your vacation first! I am just leaving this comment down, in case I forget in a week's time.


Cleanup: Improve the wording in the greeting endpoint description.

Rephrased the description of the greeting endpoint to add clarity.
@rhoads-zach please take a look and merge if it looks OK to you.
resolves #298

@Ladicek I've fixed the endpoint name. Thanks for the feedback:)

LGTM, merging.

merged: https://github.com/openshiftio/appdev-documentation/commit/313b765597e327d462b1d3ca0de41635aa338b5f


Compatibility with Angular 9

Hi,
I'm trying to update my apps to Angular 9. When I tried to execute the ng update, these messages appear:
Package "saturn-datepicker" has an incompatible peer dependency to "@angular/cdk" (requires "^8.2.0", would install "9.0.0").
Package "saturn-datepicker" has an incompatible peer dependency to "@angular/material" (requires "^8.2.0", would install "9.0.0

I think my datepicker would work. But not sure. It's time to update, but I quite busy in this week. Please remind me later, if I forget

@SaturnTeam remembering you now!

Sorry, I forgot. I hope during this week I'll update finally. Publishing package is the most hardest thing

That is a great news! Thank you for your attention and glad to test new version when it was available.

I'm getting this when installed alongside Angular 9 despite the warnings:

Hi, while the official solution is not available, we did a small change into the js just to be possible to compile, run and debug the whole project.
At node_modules directory, look for:
saturn-datepicker > fesm2015 > saturn-datepicker.js
Then, just change the SatCalendar scope, from:
let SatCalendar = class ....
to
var SatCalendar = class ....

Ride on @cmdaniel solution, it works.
However in my case is that since the ng will compile all packages in node_modules folder and it a folder likes this

I have to update the file(saturn-datepicker.js) within this folder directly and it works the same.
If you haven't that folder that means the ng not yet compile the saturn-datepicker, just follow @cmdaniel solution to update the file.
Thanks @cmdaniel a lot.

Hey @SaturnTeam, any progress on the upgrade?

@NRaf 8.0.5

This likely means that the library which declares SatDatepickerModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also, consider checking
with the library's authors to see if the library is expected to be compatible with Ivy.

Non of the above helped either ...


real build is slow, testing fixes locally is slow too

slow in actual Jenkins runs:
we keep having to up the limit on how many hours the community builds are allowed to take. lately they've been in the ~8 hour range
slow during testing:
e.g.  Due to its limitations, and due to the fact that the parts are built independently, it does not offer the same advantages and checks of a standard build file, in which all projects are built on top of one another", which seems like additional confirmation (and comes close to disclaiming that any of this should still work once 2.12 enters the picture)

note: I tried upgrading dbuild from 0.9.1 to 0.9.3. it didn't help.

whenever one project needs a resolver, we add it to a global list. presumably this slows down everything. can we add resolvers for a particular project only?

@SethTisue, concerning tweaking the meta-build, check: http://typesafehub.github.io/dbuild/0.9.3/plugins.html#build-levels as well as the following section; it may help.
The resolvers list is global; however, you should ideally rely on a local artifactory proxy. Therefore the list of resolvers should only list the proxy in ivy and maven versions, and inside the artifactory instance you can then define the virtual repository ("repo", for instance) in a way suitable to proxy all the other external repositories you are interested in.

fixed by @adriaanm in #243


multiplayer Uncaught ReferenceError: io is not defined

I am having trouble using this for a multiplayer game.  I'm currently using 'python -m http.server' to host the web files, after running 'node server.js' in another command prompt.  In multiplayer.html, I receive the above error after I press 'Enter' to submit my user name.

Just wanted to add that this also happens when using 'http-server' in the main project directory.

It seems socket.io is never included in the HTML. You'll need to add a
script tag after glmatrix to include it. I'm not sure how that happened.
On Mon, Feb 1, 2016, 15:46 jmarrismoboces<EMAIL_ADDRESS>wrote:

Just wanted to add that this also happens when using 'http-server' in the
main project directory.
—
Reply to this email directly or view it on GitHub
https://github.com/Overv/WebCraft/issues/10#issuecomment-177999967.

Realized socket.io.js was not being served, despite having done npm install socket.io in the project directory.  Changed the reference in the multiplayer.html file to refer to the socket.io CDN.  I'm now getting 'GET http://localhost:8080/socket.io/?EIO=3&transport=polling&t=LATPEgI 404 (Not Found)' repeatedly, where the t parameter changes each time.  I'm a little confused as to how and where the node server should be supplying the socket.io library.  It would seem that the client is looking for it at :3000/socket.io/socket.io.js, but when I run npm install socket.io, the files don't seem to end up that way.  Here's what I have in node_modules:
...
socket.io
|- lib
|    |-client.js
|    |-index.js
|    |-namespace.js
|    |-socket.js
socket.io-adapter
socket.io-client
|- lib
|    |-index.js
|    |-manager.js
|    |-on.js
|    |-socket.js
|    |-url.js
socket.io-parser
...

It seems socket.io is never included in the HTML.

                <script type="text/javascript">
			var head = document.getElementsByTagName( "head" )[0];
			var script = document.createElement( "script" );
			script.type = "text/javascript";
			script.src = "http://" + location.host + ":3000/socket.io/socket.io.js";
			head.appendChild( script );
		</script>

This seems to be where multiplayer.html loads the socket.js library.  I changed it to read

                <script type="text/javascript">
			var head = document.getElementsByTagName( "head" )[0];
			var script = document.createElement( "script" );
			script.type = "text/javascript";
			script.src = "http://" + location.host + ":3000/socket.io/lib/socket.js";
			head.appendChild( script );
		</script>

per the file structure above.
Thank you for your quick response!  I like what I see, and hope to use this with my class!

Just wanted to clarify that those changes didn't fix my problem.  I understand that the socket.io lib should be served over port 3000, but the path seems to be incorrect somehow.  The installed version is 1.4.5.
What's strange to me is that once I replace the locally hosted socket.io to the CDN hosted one, the client appears to be attempting to access socket.io on the web port (8000 or 8080 for python or node https-server, respectively) rather than 3000.  I'm new to sockets.io and node, so I appreciate any information you can offer.

I'll look into this tomorrow.

Okay, the latest code was completely incompatible with newer versions of Socket.IO. I've fixed the problems and the server will now properly host the socket.io files too.
Run node server and browse to http://localhost:3000/multiplayer.html.

Receiving the same issue. I'm not sure how to rectify the situation.