How to avoid mz-sidenav going back while clicking on the content ?

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

Version used:
Angular version used:
Browser Name and version:
Operating System and version (desktop or mobile):
Link to your project (if appropriate):

At this moment in Materialize, there is no option to configuration the sidenav close when clicking outside.

Materialize fixed the behavior for sideNav for closeOnClick in v0.99.0 (f97bf0b).
Unfortunatly, we are currently using v0.99.2 that does not include the fix above.
So basically right now, the sideNav will close if...

closeOnClick === true
OR
window.width < 992px (no matter what closeOnClick value is)

This will be fixed when we will update to use Materialize v0.99.0 which we should do in a near futur.
Sorry for the inconvenience.

Thanks for the update :)
Is it possible "Push mode" ?

We updated Materialize version 0.100.2 which include the fix for closeOnClick mentioned earlier.
This will be available in our next release 1.6.0 planned for early october.

@sijithc40 "push mode" does not seems to be a feature offer by Materialize library, therefore it is not provided through our library. Although this can probably be something achieved anyway with some tweek but I don't have any example for that matter.


[New Feature]: Add ability to display warning to user before upgrade

Description of the new feature/enhancement
While upgrading programs, all my explorer windows closed with no warning due to WinMerge closing it as part of its upgrade path. Would it be possible to add a warning to programs known to interfere with others as part of their upgrades or installs?
Proposed technical implementation details (optional)
Add a upgrade after user issues command to the tone of "This upgrade might close other programs as part of its upgrade, make sure you save your work first!" with a prompt Y/N before continuing and a flag to the upgrade command to ignore possible upgrade closures to disable the prompt for scripts and people who don't care

WinMerge closing it as part of its upgrade path

WinMerge uses Inno Setup which does support the Restart Manager. It would perhaps be nice if we could figure out if WinMerge is doing something special or if there is an issue with Inno.

All I know is it kills all open explorer windows on install upgrade or uninstall because it adds a properties sheet which requires explorer to be closed. haven't done much research been at work all day

Actually I think it adds a context menu entry rather than a properties sheet

I think it manually closes all open explorer windows as part of its install script, so there might not be much able to be done to mitigate it other than a warning

But does it have custom code to close Explorer or does it use Restart manager?
Manually closing Explorer is broken by design since other applications (anything with a open/save dialog) might also have the shell extension .DLL loaded.
Restart manager is supposed to fix this. You give it a list of files, it closes all apps using said files, you replace/update the files and finally you tell Restart manager to restart the apps. Explorer is somewhat special since it also owns the taskbar and that might be the same process as a File explorer window.

I'm not sure, this is all from observation, not taking a look at the scripts or anything. I don't know if it tries to kill all of explorer or not, as I run File Explorer as a separate process from the taskbar for stability reasons

What kind of name were you thinking for the manifest key?
"VolatileInstaller" as a boolean?
We could provide a message like:
"This installer is known to interfere with running applications"
I'm open to suggestions here.

The original PR for this has been closed, so this is not truly https://github.com/microsoft/winget-cli/labels/In-PR


Broken links

Hello, I found 2 broken hyperlinks:

[ ] https://github.com/EdvinVikstrom/filetree.nvim (file: README.md, status code: 404)
[ ] https://github.com/CanKolay3499/CNvim (file: README.md, status code: 404)

Hi, you're welcome to create a PR to remove them.

I just created a PR to remove the broken link to EdvinVikstrom/filetree.nvim, I had a look to make sure the repo had not been renamed. It seems like it was either deleted or made private.

As @korbexmachina said, I also tried to find the EdvinVikstrom/filetree.nvim as well, I can confirm that it is deleted or made private. WaybackMachine shows and entry on April 18, 2022 but as of snapshot March 27, 2023, it is gone. Couldn't find it on GitHub as well.

Please create a PR so it can be discussed there as well.


204 NO CONTENT regression fix

Regression between Dash 0.41 and 0.42
Reproducible with Byron's code below:
import dash
import dash_html_components as html
import dash_core_components as dcc
from multiprocessing import Value
from dash.dependencies import Input, Output
from dash import callback_context, no_update
from dash.exceptions import PreventUpdate
from multiprocessing import Value

initial_input = 'initial input'
initial_output = 'initial output'

app = dash.Dash(__name__)
# app.config['suppress_callback_exceptions'] = True
app.css.config.serve_locally = True
app.scripts.config.serve_locally = True

app.layout = html.Div([
    dcc.Input(id='input', value=initial_input),
    html.Div(initial_output, id='output1'),
    html.Div(initial_output, id='output2'),
])

callback1_count = Value('i', 0)
callback2_count = Value('i', 0)

@app.callback(Output('output1', 'children'), [Input('input', 'value')])
def callback1(value):
    callback1_count.value += 1
    if callback1_count.value > 2:
        return no_update
    raise PreventUpdate("testing callback does not update")

@app.callback(Output('output2', 'children'), [Input('output1', 'children')])
def callback2(value):
    callback2_count.value += 1
    return value

if __name__ == '__main__':
    app.run_server(debug=True)

Introduced in: https://github.com/plotly/dash-renderer/pull/152/files#diff-4e3037116dbc2bc69a473b7ace3d02abR678 and https://github.com/plotly/dash-renderer/pull/162/files#diff-4e3037116dbc2bc69a473b7ace3d02abR682

But I do think this warrants a test case.

the above sample app from one of integration would be able to catch the issue
but failed to notify as I believe there is a bug in old implementation of check clear console log in selenium. consolidate the IntegrationTest for both dash and dash-renderer with desired_capabilities disclosed it.  yes but we would need more customized case later

consolidate the IntegrationTest for both dash and dash-renderer with desired_capabilities disclosed it.

Ok, if you have a test to :lock: this elsewhere, we can merge this PR without one. Though it looks like there’s a test already that’s sensitive to this and needs fixing?

Not sure what's going on here but the error was already present when the renderer was bumped to 0.23: https://circleci.com/gh/plotly/dash-renderer/2189?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Ah! So this comes from this change in DCC: https://github.com/plotly/dash-core-components/blame/master/src/components/Input.react.js#L103
As previously discussed, some attention to the builds is still required when bumping versions as some combinations of packages don't get automatically tested yet. In this case dcc was last updated after renderer and the diff was only caught at release.
Updating the test.

The percy diffs above are caused by the previous failure in master erasing the baseline screenshots for  test_callbacks_generating_children


Build failed android/util/IntProperty

Not a very long error message:
'app:transformClassesWithInstantRunForDebug'.
> android/util/IntProperty

Let me know if you need more logs with --stacktrace

please provide me more logs with --stacktrace
thank you

When building it with IDE(Ctrl + F9) or grade command line everything works fine.
It only throw this error when try to install the app with IDE(Shift + F10), So there isn't any way to run it with --stacktrace
However I manage some how to get a more descriptive error message after some cleaning and building, Looks like it nags about a class uses an API from Marshmallow.
Executing tasks: [:app:assembleDebug]

Parallel execution with configuration on demand is an incubating feature.
NDK is missing a "platforms" directory.
If you are using NDK, verify the ndk.dir is set to a valid NDK directory.  It is currently set to C:\Android\sdk\ndk-bundle.
If you are not using NDK, unset the NDK variable from ANDROID_NDK_HOME or local.properties to remove this warning.

:app:buildInfoDebugLoader
:app:preBuild UP-TO-DATE
:app:preDebugBuild UP-TO-DATE
:app:checkDebugManifest
:app:prepareComAndroidDatabindingAdapters131Library
:app:prepareComAndroidDatabindingLibrary131Library
:app:prepareComAndroidSupportAnimatedVectorDrawable2531Library
:app:prepareComAndroidSupportAppcompatV72531Library
:app:prepareComAndroidSupportCardviewV72531Library
:app:prepareComAndroidSupportConstraintConstraintLayout102Library
:app:prepareComAndroidSupportDesign2531Library
:app:prepareComAndroidSupportRecyclerviewV72531Library
:app:prepareComAndroidSupportSupportCompat2531Library
:app:prepareComAndroidSupportSupportCoreUi2531Library
:app:prepareComAndroidSupportSupportCoreUtils2531Library
:app:prepareComAndroidSupportSupportFragment2531Library
:app:prepareComAndroidSupportSupportMediaCompat2531Library
:app:prepareComAndroidSupportSupportV42531Library
:app:prepareComAndroidSupportSupportVectorDrawable2531Library
:app:prepareComAndroidSupportTransition2531Library
:app:prepareComAurelhubertAhbottomnavigation206Library
:app:prepareComBluelinelabsConductor214SNAPSHOTLibrary UP-TO-DATE
:app:prepareComBluelinelabsConductorSupport214SNAPSHOTLibrary UP-TO-DATE
:app:prepareComGithubVarunestSparkbutton105Library
:app:prepareComGjiazheScrollparallaximageview10Library
:app:prepareComGoogleDaggerDaggerAndroid210Rc2Library
:app:prepareComInfstoryProguardAnnotations102Library
:app:prepareComJakewhartonRxbinding2Rxbinding200Library
:app:prepareComJakewhartonRxbinding2RxbindingAppcompatV7200Library
:app:prepareComJakewhartonRxbinding2RxbindingDesign200Library
:app:prepareComJakewhartonRxbinding2RxbindingRecyclerviewV7200Library
:app:prepareComLetvSarrsdesktopBlockCanaryExJRT0991Library
:app:prepareComXwrayGroupie111Library
:app:prepareIoReactivexRxjava2Rxandroid201Library
:app:prepareIoRequeryRequeryAndroid130Library
:app:prepareItSephirothAndroidLibraryBottomnavigationBottomNavigation201Rc1Library
:app:prepareJpWasabeefGlideTransformations202Library
:app:prepareDebugDependencies
:app:compileDebugRenderscript UP-TO-DATE
:app:generateDebugResValues UP-TO-DATE
:app:generateDebugResources UP-TO-DATE
:app:mergeDebugResources UP-TO-DATE
:app:dataBindingProcessLayoutsDebug UP-TO-DATE
:app:compileDebugAidl UP-TO-DATE
:app:generateDebugBuildConfig UP-TO-DATE
:app:processDebugManifest
:app:processDebugResources
:app:generateDebugSources
:app:dataBindingExportBuildInfoDebug
:app:incrementalDebugJavaCompilationSafeguard
:app:javaPreCompileDebug
:app:transformClassesAndDataBindingWithDataBindingMergeArtifactsForDebug
:app:compileDebugJavaWithJavac
warning: View field context collides with a variable or import
  file://C:\Users\ME\Documents\github\project\app\src\main\res\layout\controller_home.xml Line:6
warning: The following options were not recognized by any processor: '[autovaluegson.defaultCollectionsToEmpty]'
Note: C:\Users\ME\Documents\github\project\app\src\main\java\com\github\pedramrn\parent\App.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 warning

:app:mergeDebugShaders
:app:compileDebugShaders
:app:generateDebugAssets
:app:mergeDebugAssets
:app:processDebugJavaRes UP-TO-DATE
:app:transformResourcesWithMergeJavaResForDebug
:app:packageInstantRunResourcesDebug
:app:fastDeployDebugExtractor
:app:generateDebugInstantRunAppInfo
:app:checkManifestChangesDebug
:app:transformClassesWithBlockCanaryExForDebug
:app:transformClassesWithExtractJarsForDebug
:app:transformClassesWithInstantRunVerifierForDebug
:app:transformClassesWithDependencyCheckerForDebug UP-TO-DATE
:app:compileDebugNdk UP-TO-DATE
:app:mergeDebugJniLibFolders
:app:transformNativeLibsWithMergeJniLibsForDebug
:app:transformNativeLibsAndResourcesWithJavaResourcesVerifierForDebug UP-TO-DATE
:app:transformClassesWithInstantRunForDebug
Failed to find byte code for android/util/IntProperty
IncrementalVisitor parseParents could not locate android/util/IntProperty which is an ancestor of project class com/github/pedramrn/parent/ui/changehandler/AnimUtils$1.
com/github/pedramrn/parent/ui/changehandler/AnimUtils$1 is not eligible for hot swap.
If the class targets a more recent platform than 22, add a @TargetApi annotation to silence this warning.
Failed to find byte code for android/util/FloatProperty
IncrementalVisitor parseParents could not locate android/util/FloatProperty which is an ancestor of project class com/github/pedramrn/parent/ui/changehandler/AnimUtils$3.
com/github/pedramrn/parent/ui/changehandler/AnimUtils$3 is not eligible for hot swap.
If the class targets a more recent platform than 22, add a @TargetApi annotation to silence this warning.
:app:transformClassesWithInstantRunForDebug FAILED
:app:buildInfoGeneratorDebug

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:transformClassesWithInstantRunForDebug'.
> android/util/IntProperty

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 37.764 secs

The problem will go away if I change this:
@TargetApi(Build.VERSION_CODES.LOLLIPOP)
public class AnimUtils { ... }

to
@TargetApi(Build.VERSION_CODES.M)
public class AnimUtils { ... }

I have notice this line :app:transformClassesWithInstantRunForDebug FAILED
After turning the Instant Run off the problem goes away.


POC of using background writer.

Just exposing for visibility. Will need heavy refactoring.
This PR shows how we can use public frozen Realm while delegating writes to a background writer, that when it completes, will update the frozen Realm.

Replaced by https://github.com/realm/realm-kotlin/pull/291


Pedantic v2.0.2 is not supported

Starting from pydantic==2.0.1, there is no support for strawberry.experimental.pydantic.
Traceback
...
  File "<path>/gql.py", line 15, in <module>
    @strawberry.experimental.pydantic.type(model=schemas.Location)
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'strawberry.experimental' has no attribute 'pydantic'

System Information

Strawberry version: 0.194.4

It's a work in progress, see #2888.


qbittorrent: 5.0.1 -> 5.0.2; move to by-name; modernize derivation

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 358115

x86_64-linux

:white_check_mark: 2 packages built:

qbittorrent
qbittorrent-nox

aarch64-darwin

:white_check_mark: 2 packages built:

qbittorrent
qbittorrent-nox

x86_64-darwin

:white_check_mark: 2 packages built:

qbittorrent
qbittorrent-nox


How to set retain flag

When I restart home assistant the initial values of my plant sensors are unknown.
This first paragraph here
https://www.home-assistant.io/components/sensor.mqtt/

If messages in this state_topic are published with RETAIN flag, the sensor will receive an instant update with last known value.

tells us that the retain flag has to be set to avoid this.
Is it possible to set the retain flag in the configuration file?

Retain flag is already set, has to be an issue with my config in ha.

@h4nc Did you resolve your issue as I've just come across this today too?

Yes, my values show up after a ha restart but to be honest I don't remember what solved this.
I think adding force_update: true to my mqtt sensor configuration fixed it for me. Please let me know if this solves your issue too.

Ah yes, force_update. That's the one! Thank you.


Missing compiler error: Integer overflow on constant evaluation

There is the following constant expression: const a: Int = 1 >> -1073741824;
When evaluating it in compile time the following stack trace appears:
💼 Compiling project sample...
Tact compilation failed
RangeError: Maximum BigInt size exceeded
    at reduceInt (/home/bh/Dev/tact/dist/types/resolveConstantValue.js:35:22)
    at resolveConstantValue (/home/bh/Dev/tact/dist/types/resolveConstantValue.js:153:16)
    at buildConstantDescription (/home/bh/Dev/tact/dist/types/resolveDescriptors.js:266:67)
    at resolveDescriptors (/home/bh/Dev/tact/dist/types/resolveDescriptors.js:1047:35)
    at precompile (/home/bh/Dev/tact/dist/pipeline/precompile.js:18:55)
    at build (/home/bh/Dev/tact/dist/pipeline/build.js:56:43)
    at Object.run (/home/bh/Dev/tact/dist/node.js:53:47)
    at /home/bh/Dev/tact/bin/tact:25:20
    at Object.<anonymous> (/home/bh/Dev/tact/bin/tact:30:3)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)

Expected: A readable compiler error like: This constant expression cannot be evaluated due to integer overflow.
Part of: #183
Found while working on #133

Okay. In essence the compiler error handling needs a facelift


Particle migration doesn't work correctly.

There's an issue with the MPI implementation where something is not quite correct, and particles with 0 position seem to occur on every node.

Ok, no rank is expecting to be sending a 0.0 value, but every node is receiving one. This is strange.

It looks like its the sending/receving of position/velocity is wrong in the DSL code, it also needs * ...extent(2).


[Task] Determine weights for cards based on rarity in pack

We need a way to figure out the different weights a card has per pack based on its rarity. Right now we don't have any good data on it but I will be looking at different forums and posting them. After we get that info we need to capture that and save it somewhere so we can associate it with the card data we will be storing.

https://www.google.com/search?q=yugioh+odds+for+different+rarity+of+cards+in+a+pack&rlz=1C1RXQR_enUS935US935&oq=yugioh+odds+for+different+rarity+of+cards+in+a+pack+&aqs=chrome..69i57j33i160l5j33i299.10033j0j7&sourceid=chrome&ie=UTF-8

https://yugioh.fandom.com/wiki/Forum:Pull_ratios#:~:text=There is a 1%3A1,1%3A5 %3D 20%25(.

https://www.ygoprog.com/About


🐻 feat(nextcloud): Update nextcloud image to custom version

Updates the nextcloud image used in the docker-compose file to a
custom version that includes the smbclient package. This allows the
nextcloud instance to access SMB shares, which is a requirement for
the organization's file storage needs.

Summary by CodeRabbit

New Features

Updated the Nextcloud application to a new versioning scheme and Docker image.

Bug Fixes

Resolved issues related to outdated Docker images for Nextcloud and cron services.

Docker image code is at: https://github.com/bigbeartechworld/big-bear-docker-images/tree/main/nextcloud-with-smbclient


Added limit exceed error message with new limit

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/18647
PROPOSAL: https://github.com/Expensify/App/issues/18647#issuecomment-1540620661
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@dhairyasenjaliya Can you please update the Test Steps/QA Steps to cover all features where we applied the fix?

@mananjadhav updated steps & screenshots

@mananjadhav  @youssef-lr do we need to handle the legal name as well?

@mananjadhav @youssef-lr do we need to handle the legal name as well?

Yes. We closed one the linked issue stating we'll take care of it here.

Okay and any other remaining @mananjadhav

Okay and any other remaining @mananjadhav

I am checking through the issues.

@dhairyasenjaliya did we cover legal name? I can't find new commits.
@youssef-lr @dhairyasenjaliya  any comments on this one?

@mananjadhav legal names added and steps also updated

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@dhairyasenjaliya @youssef-lr I can see one potential issue:
When more than one fields have the validation error, we only show the error to the first field. Is that the expected behavior? Because we don't have the validation in the current form we can't make out.

I have other forms where both the fields show the error.

@mananjadhav Yeah we should stick with the current approach to show both error validations I have added that on the new commit

Is that the only place? Do we need to worry about any other places?

I checked its only for one place which I just updated @mananjadhav

@dhairyasenjaliya One more issue, the latin error message doesn't get cleared in the legal name.
https://github.com/Expensify/App/assets/3069065/1b5b1dde-010c-4adf-97f3-68f51827cff4

@mananjadhav fixed on latest commit

Thanks @dhairyasenjaliya the above listed bugs are resolved in the latest push.

@dhairyasenjaliya We've got Typescript check failing. Can you merge the latest main to see if it fixes it?

@youssef-lr quick bump.

Reviewing today

Sorry folks couldn't get to it last week, I'm on it today or tomorrow.

@dhairyasenjaliya left a small comment, let's get those conflicts fixed and merge this!

Lots of checks failing.

@youssef-lr This is globally failing context - https://expensify.slack.com/archives/C01GTK53T8Q/p1706808000490579

hey @youssef-lr all conflicts fixed please check

I remember we had changes in ReportWelcomeMessagePage, we also changed this to be max 500, right now it's 10000

@youssef-lr on latest main it was removed for welcome message

@dhairyasenjaliya there are conflicts, once fixed I can approve & merge.

@youssef-lr all done please merge once you get a chance

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.40-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
failure ❌

This PR is failing because of issue https://github.com/Expensify/App/issues/36342
The issue is reproducible in: All environments
https://github.com/Expensify/App/assets/78819774/8ff0637d-a0fc-47e8-864e-2ac1213aa1a5

@dhairyasenjaliya can you look into this asap please?

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.40-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
failure ❌


Update scala-collection-compat to 2.3.1

Updates org.scala-lang.modules:scala-collection-compat from 2.1.6 to 2.3.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-collection-compat" } ]

labels: library-update, semver-minor

Superseded by #2048.


Sync kfctl with kubeflow/kubeflow at dfd8b2b

This change is

/assign @kkasravi

@richardsliu were the tests moved over as well?

@kkasravi You mean the e2e tests? I copied them manually (they failed one of the previous runs).

@kkasravi You mean the e2e tests? I copied them manually (they failed one of the previous runs).

ok. We may want to add that logic into the hack/ script. Also i was add a note in the description of what the kubeflow/kubeflow kfctl version is and the time. Prior sync PRs have this info.
/lgtm
/approve


upgrades: private state rollover during testnet 62

Is your feature request related to a problem? Please describe.
In #2917, we were able to exercise the MVP upgrade functionality and test both: 1/ the coordination mechanism that node runners use to signal their intent to perform an upgrade 2/ the operational implications of doing so if the node runner chooses to, sharing context along the way.
Since then, we have added more functionality like checkpointing the genesis state, and performing full InitChain handshakes with CometBFT, completely pruning the consensus state and adhering to the recommended best-practice by the CometBFT team.
During the course of testnet 62, we should re-perform this test:

[x] with new tooling that incorporate @conorsch's feedback:

change the export command flag to --home
change the upgrade command flag to --upgrade-path
improve the command description
improve logging to explain the cause of halt when an upgrade height is reached
add an explainer message when a node refuses to restart because it the full node is in statis

[x] exercising a full checkpointed genesis and InitChain handshake
[x] upgrading a full node
[ ] upgrading a block producing node
[ ] pointing a 07 lightclient at the chain and making sure that it can validate across the upgrade boundary

This is important but not urgent, and blocked on #3093 - targeting 63.

Marking as blocked until #3093 is resolved; then we can pick this back up.

pointing a 07 lightclient at the chain and making sure that it can validate across the upgrade boundary

This is the single remaining item tracked in the OP. However, it's blocked on #3506, so we've broken it out into its own ticket: #3577. Closing this as resolved.


Vstsextend jenkins

Setting up the Jenkins VM
Step 1 - Added detail to choose the password as the authentication type
Step 2 - Updated instructions make note of the IP from the overview page, updated screenshot
Create a new build job in Jenkins
Step 4 - Clarified which credentials to use
Approach 1: Triggering the CI via a service Hook
Step 3b - Added instructions to include port in the URL/IP Address
Approach 2: Wrapping Jenkins Job within Azure Pipelines
Step 2 - Added instructions to include the port

Looks good to me, @sriramdasbalaji please review


Fix for issue #230 set/unsetwriter symmetric wrt color support detection

Pls tell me if you want to add tests around this -- requires that is spend a bit of time, kind of forgot the context :(

Thank you @ataypamart


feat: Add listRetain and allow slices for listFetch

@ben-kugler any idea what the test failures are about?


remove github from relation property names

Fixes https://github.com/elwayman02/ember-data-github/issues/114
Since we are pre-1.0 I think this could be released in a new minor version with a release note calling out the change, but I'm open to other ideas.

Yea I'm ok with that release strategy.


pgeof as a pip package

Packaging pgeof as a pip package, free from the conda dependency of eigen3 would be great.
@rjanvier I think you were thinking of working on this at some point. Is this still something you are considering ?

yep, "new" pgeof use Eigen as submodule, to come this week

it's already packaged for PyPI here https://pypi.org/project/pgeof/ pip install pgeof just do the trick.

yep, "new" pgeof use Eigen as submodule, to come this week

Oh cool ! So, to be sure I understand correctly: you intend to release pre-compiled binaries for pegeof which can be installed  withpip install pgeof without the need for explicitly installing eigen before with, say:
conda install -c omnia eigen3
export EIGEN_LIB_PATH="path_to_eigen_root_dir"
``` ?

Maybe if you want to test the current package without risk, in your console try something like
python -m venv testpgeof  -> create a virtual env in the directory testpgeof
source testpgeof/bin/activate -> activate the virtual env (now you are isolated from other python distribution
python -m pip install pgeof -> install a precompiled wheel of pgeof from PyPI
python -c "import pgeof;help(pgeof)" -> should display pgeof help
deactivate -> deactivate your virtual env, come back to your current python distribution
rm your venv if needed

Cool, thanks for the feedback. I will likely setup a DL machine from scratch in the coming days, will test it then !

@drprojects,
I remember I put a placeholder in the copyright here https://github.com/drprojects/point_geometric_features/blob/main/LICENSE because it was the one from Ashleve.
Maybe you could update the copyright with a proper attribution (Loic, you or your institution...). Thank in advance!

Thanks for reminding me, I did not think of checking it. Just updated it and added you to it, since you have been actively pushing this project too !


stories #2

Adding items
As Martin, I want to add items to the basket on the website
So that I can create an order
Acceptance criteria:
Given I'm on the home page
When I click "Add" on "All Butter Croissant"
Then I see "Basket: 1 item(s)" in the header
Given I'm on the home page
When I click "Add" on "All Butter Croissant"
And I click "Add" on "All Butter Croissant" again or any other item
Then I see "Basket: 2 item(s)" in the header
Note: When Martin opens Cake Factory web-site on another device or when Joanne does that, they should see different number of items in the basket. So basket should be bound to a session, but not user.

Adding items
As Martin, I want to add items to the basket on the website
So that I can create an order
Acceptance criteria:
Given I'm on the home page
When I click "Add" on "All Butter Croissant"
Then I see "Basket: 1 item(s)" in the header
Given I'm on the home page
When I click "Add" on "All Butter Croissant"
And I click "Add" on "All Butter Croissant" again or any other item
Then I see "Basket: 2 item(s)" in the header
Note: When Martin opens Cake Factory web-site on another device or when Joanne does that, they should see different number of items in the basket. So basket should be bound to a session, but not user.

completed


Duplicate affiliate key requests

With newest SDK's release (2.5.1) is requested to pass affiliate key both within SumUpLogin builder and within SumUpPayment builder.
Furthermore, if affiliate key within SumUpLogin builder is not correct the resultCode obtained from SumUpAPI.openLoginActivity will be a SumUpAPI.Response.ResultCode.SUCCESSFULresponse.   After that, if i pass the correct affiliate key to SumUpAPI.checkout the payment will be performed correctly and it generate an inconsistent situation.

Hey there. Are you also using an access token in SumUpLogin? If so your affiliate key is indeed being ignored. The next SDK version will deprecate the affiliate key at checkout so it will be only required in login. By version 3.0 it will be removed

Yes, i'm using an access token within SumUpLogin. I'll wait for next release, thanks

Hi,
SDK 2.5.2 just got released: https://github.com/sumup/sumup-android-sdk/releases/tag/v2.5.2
Closing the issue!


Compatibility with the new javascript module api

RFC: https://github.com/emberjs/rfcs/blob/master/text/0176-javascript-module-api.md
import Component from '@ember/component';

generates an error : [ts] Cannot find module '@ember/component'.
This import is possible thanks to https://github.com/ember-cli/ember-cli-shims/pull/92 available in https://github.com/ember-cli/ember-cli-shims/releases/tag/v1.2.0-beta.2.
How can we make typescript aware of those new modules ?

@bartocc I believe what we'll need to do is update the typings in the Definitely Typed repo for that. We'll need to come up with a strategy for defining the imports at both locations in some way or another, given that we're certain to have some users on the old and some on the new import paths. 🤔

@chriskrycho that's roughly what I thought. But I am not familiar with the Definitely Typed repo and the way @types/ember is generated. Do you know who might know more about this ?

Unfortunately, it's generated by hand. It's a matter of forking the repo and then updating this file. I started on some tweaks a few weeks ago (before I went on vacation) but ran into a number of issues there around extracting the RSVP bits to reference the dedicated RSVP typings. My goal is to get that done first, then put together the plan for updating the typings in general. I need to work through and identify what needs to be done and then I'll try to write up an issue in terms of things people can tackle.

Work on this has started and I'll add updates here early next week with links to the places where it's in work so people can help.

Watch for a PR at https://github.com/typed-ember/ember-typings/pulls adding these in the next few days. The work is done, just need to land a few other pieces first!


Automatic subscription via JWT claims doesn't support array of strings as values

Summary and context

Automatic subscription only supports strings as claims value. When passing claims with array of strings, the automatic subscription doesn't work at all. The most common use case for this is the "Roles" claim which is typically provided as an array of strings. Though this subscriptions can be added later after initiating the websocket/sse connection, it would be beneficial to have this as part of the automatic subscription via JWT claims during connection.

How to reproduce
When I run RIG with these settings:

JWT

{
    "iss": "Online JWT Builder",
    "iat":<PHONE_NUMBER>,
    "exp":<PHONE_NUMBER>,
    "aud": "www.example.com",
    "sub"<EMAIL_ADDRESS>    "GivenName": "Johnny",
    "Surname": "Rocket",
    "Email"<EMAIL_ADDRESS>    "Roles": [
        "Admin",
        "Tester"
    ]
}

Example Event

{"data":{"clientId":"Personnel30","name":"User1","position":{"x":5170,"y":-2480,"z":370},"timestamp":"12304967032","userType":"Admin"},"id":"58bc0707-a9d7-41f8-91eb-12db371ff272","source":"test","specversion":"0.2","time":"2021-05-04T02:58:16Z","type":"position"}

Extractor json

{
        "position": {
                "userType": {
                        "stable_field_index": 1,
                        "event": {
                                "json_pointer": "/data/userType"
                        },
                        "jwt": {
                                "json_pointer": "/Roles"
                        }
                }
        }
}

..and set up clients and services like this:

Websocket connection

wscat -c ws://localhost:4000/_rig/v1/connection/ws\?jwt\=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJPbmxpbmUgSldUIEJ1aWxkZXIiLCJpYXQiOjE2MjI0NTgzMjQsImV4cCI6MTY1Mzk5NDMyNCwiYXVkIjoid3d3LmV4YW1wbGUuY29tIiwic3ViIjoianJvY2tldEBleGFtcGxlLmNvbSIsIkdpdmVuTmFtZSI6IkpvaG5ueSIsIlN1cm5hbWUiOiJSb2NrZXQiLCJFbWFpbCI6Impyb2NrZXRAZXhhbXBsZS5jb20iLCJSb2xlcyI6WyJBZG1pbiIsIlRlc3RlciJdfQ.H8y1h8lwC4Jw-zUWY5Rlmkut9xnv9lVCDRue7NVLWSY

Websocket response

{"data":[{"eventType":"position","oneOf":[{"userType":["Admin","Tester"]}]}],"id":"da125119-090c-4687-b3d7-a9d41c739887","source":"rig","specversion":"0.2","time":"2021-05-31T11:20:52.842666+00:00","type":"rig.subscriptions_set"}

..I see the following error and/or log output:

Unable to receive any events, neither "userType": "Admin" nor "userType": "Tester"

{"data":{"clientId":"Personnel30","name":"User1","position":{"x":5170,"y":-2480,"z":370},"timestamp":"12304967032","userType":"Admin"},"id":"58bc0707-a9d7-41f8-91eb-12db371ff272","source":"test","specversion":"0.2","time":"2021-05-04T02:58:16Z","type":"position"}

or

{"data":{"clientId":"Personnel30","name":"User1","position":{"x":5170,"y":-2480,"z":370},"timestamp":"12304967032","userType":"Tester"},"id":"58bc0707-a9d7-41f8-91eb-12db371ff272","source":"test","specversion":"0.2","time":"2021-05-04T02:58:16Z","type":"position"}

..but I really expected this:

RIG should accept events with /data/userType value of either "Admin" or "Tester". I think there should be parsing during automatic subscription when the value of the json pointer is an array of strings, it should add the values in the array as "oneOf" values.
Current subscription

{"data":[{"eventType":"position","oneOf":[{"userType":["Admin","Tester"]}]}],"id":"da125119-090c-4687-b3d7-a9d41c739887","source":"rig","specversion":"0.2","time":"2021-05-31T11:20:52.842666+00:00","type":"rig.subscriptions_set"}

Expected subscription

{"data":[{"eventType":"position","oneOf":[{"userType":"Admin"},{"userType":"Tester"}]}],"id":"da125119-090c-4687-b3d7-a9d41c739887","source":"rig","specversion":"0.2","time":"2021-05-31T11:20:52.842666+00:00","type":"rig.subscriptions_set"}

Versions (please complete the following information):**

Host OS: MacOS(RIG running on docker)
Frontend: curl, wscat, kafkacat
RIG version as shown on startup: Reactive Interaction Gateway 3.0.0-alpha.2<EMAIL_ADDRESS>ERTS 11.1.8, OTP 23]

Related with #377 with regards to JWT validation using external service during connection.


Fix for AD group names in persistent environments

Data scientists + developers AD groups were named with suffix_override which was ok for transient builds but blank in persistent builds. Moves to naming_suffix instead.

/test

:robot: pr-bot :robot:
:runner: Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/4732789073 (with refid b55f5bfd)
(in response to this comment from @damoodamoo)


Show example output

May an example of program output please be shown/linked on the README file?
This would help me see if this is a project I would like to use?

Can't work on the README right now but you can find examples of output in cli.test.ts.md. I know this isn't the best format, sorry.
Keep in mind you can customize the output using templates as shown in https://github.com/OpenZeppelin/solidity-docgen/pull/290.

Cool, thank you


feat(sqip): implement sqip && fix mobile layout

updates all dependencies and fully implements sqip previews

Alright, will add some docs :)

Docs added, comment added, rebased.
Ready for review :)

Any update on this?

@axe312ger I just tried your changes, and it looks very cool!
One problem, though, is starting time: now, instead of 3 seconds it is 65.
After this change:

Before this change:

Can we make this part (with sqip) optional? What do you think?
Thanks!

Ah, I see. I have MBP 2017, 3,1 GHz Intel Core i7 and 16GB DDR3, so it should be good.
I've just reinstalled all packages and it is 3 seconds again! Super weird, since I think I did before as well, but if it is for you the same (no changes in time) then I think all good.

I am wondering if this gives first time Contentful/Gatsby users the impression it is slow.
Maybe this isn't that great idea and we should maybe switch to traced SVG output since this is supported now in Gatsby in combination with Contentful.
What do you think?

Actually, I just tried it again, and it seems that fast rebuilding (3 seconds) is only if everything is in cache, so in case I do the following:

clone the repo
git checkout feat/sqip
npm install
npm run dev

It takes ~50 seconds now (weird). Also, it does not really run for me (graphQL server works, but not usual http://localhost:8000), and also npm run build fails with this stack trace:

Hmm thats very weird, looks like a Gatsby problem to me, for some reason it cant fine some files o.O
With the 50 seconds: Thats normal, primitive is a random algorithm so it might take some more or less time. But the settings here are maybe to crazy, it shouldn't take that long on your machine.
🤔

@axe312ger I have to say I agree with @Bloomca here, that 50s might give users the impression that this is the overall development experience.
Any chance to only get the CSS fixes in? 😊


RC4: ion-footer's content not animated with custom component

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x (RC 4)
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
The ion-footer does not animate custom component during iOS transitions. It was working in beta-11.
Expected behavior:
The ion-footer component should animate its whole content, even a custom component.
As you can see on the animation, the footer's content of the first page is not animated but the second is. The only difference is the use of a custom component.

Steps to reproduce:
please check out this repository with the 2 examples:
https://github.com/dbaq/ionfooteranimation-issue
You can use chrome dev tools and select an iOS device.
Related code:
1 - ANIMATION NOT WORKING
import { Component } from '@angular/core';

@Component({
  selector: 'custom',
  template: `<div style="height:40px; width:100%; background-color: red; color: white">:(</div>`
})
export class Custom {}

<ion-footer>
  <custom></custom>
</ion-footer>

2 - ANIMATION WORKING
<ion-footer>

:(

</ion-footer>

Other information:
Here is the forum discussiona about this issue: https://forum.ionicframework.com/t/nav-animations-for-ion-footer-bar-and-ion-header-bar/55645/19
It was working in beta-11.
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Your system information:
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.4
Ionic CLI Version: 2.1.18
Ionic App Lib Version: 2.1.9
Ionic App Scripts Version: 0.0.47
ios-deploy version: Not installed
ios-sim version: 5.0.13
OS: macOS Sierra
Node Version: v7.3.0
Xcode version: Xcode 8.2.1 Build version 8C1002

This is still occurring in newer versions of Ionic. Any fixes/workarounds?
Cordova CLI: 6.5.0
Ionic Framework Version: 2.2.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.2.1
ios-deploy version: 1.9.0
ios-sim version: 5.0.13
OS: macOS Sierra
Node Version: v6.9.1
Xcode version: Xcode 8.2.1 Build version 8C1002

I am also facing this issue and cannot solve it.
global packages:
@ionic/cli-utils : 1.2.0
Cordova CLI      : 7.0.1
Ionic CLI        : 3.2.0

local packages:
@ionic/app-scripts              : 1.3.0
@ionic/cli-plugin-cordova       : 1.2.1
@ionic/cli-plugin-ionic-angular : 1.2.0
Cordova Platforms               : android 6.2.3
Ionic Framework                 : ionic-angular 3.0.1

System:
Node       : v6.10.3
OS         : Windows 10
Xcode      : not installed
ios-deploy : not installed
ios-sim    : not installed

Same here with ionic-angular 3.6.1

You need to wrap your component in an <ion-toolbar> element, otherwise Ionic won't know what to animate.

@yannbf  I have tried wrap in ion-toolbar, no luck


improved mysql parser support. for interval function

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.高铁 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.


Output when integral is locked

It seems, when the integral term gets locked because the process is far from the setpoint, the PID output always goes to 0 (which leads to overheating in my use case).
Looking at the code I cannot figure out what happens to node. integral when the integral term gets locked. It seems node.integral is not set at all. If wind up is to be prevented, should'nt the I term be locked to 0 then?

I suspect you have not set something correctly.  Can you  post a chart showing the process value and the node output when the problem appears?

I suspect you have not set something correctly.  Can you  post a chart showing the process value and the node output when the problem appears?

I'll be back when I get more clear what's happening, I'm not fully sure myself yet... thanks sofar.

I'll be back when I get more clear what's happening, I'm not fully sure myself yet... thanks sofar.

Is it possible that you have the direction of the control reversed?  The algorithm assumes that an increasing output from the node will cause the process value to rise.  If your process value decreases when the output is high then you may need to invert the output before sending it to the process.  You could do that with a Range node configured to scale the input range 0 to 1 to the output range 1 to 0.

Is it possible that you have the direction of the control reversed?  The algorithm assumes that an increasing output from the node will cause the process value to rise.  If your process value decreases when the output is high then you may need to invert the output before sending it to the process.  You could do that with a Range node configured to scale the input range 0 to 1 to the output range 1 to 0.

This is exactly what's happening. If the pv (ie. CPU temperature) rises, the cooling fan of my Pi should blow more, ie. the PID should steer a higher value to the PWM pin. So I'm indeed mapping PID output 1-0 to 0-100.

This is exactly what's happening. If the pv (ie. CPU temperature) rises, the cooling fan of my Pi should blow more, ie. the PID should steer a higher value to the PWM pin. So I'm indeed mapping PID output 1-0 to 0-100.

You said at the start:
It seems, when the integral term gets locked because the process is far from the setpoint, the PID output always goes to 0 (which leads to overheating in my use case).
But if you are mapping 0 pid output to 100 PWM then that should cause increased cooling which should bring the process temperature down again, so what you describe should work.

You said at the start:
It seems, when the integral term gets locked because the process is far from the setpoint, the PID output always goes to 0 (which leads to overheating in my use case).
But if you are mapping 0 pid output to 100 PWM then that should cause increased cooling which should bring the process temperature down again, so what you describe should work.

Yes indeed. Let's close this for now, I can't seem the recreate the issue I was having. Thanks for your help anyway!

Yes indeed. Let's close this for now, I can't seem the recreate the issue I was having. Thanks for your help anyway!

No problem, ask again if you have further issues.

No problem, ask again if you have further issues.


podman ps on macOS

$ bin/ramalama ps
Cannot connect to Podman. Please verify your connection to the Linux system using podman system connection list, or try podman machine init and podman machine start to manage a new Linux VM
Error: unable to connect to Podman socket: failed to connect: dial tcp <IP_ADDRESS>:49825: connect: connection refused
we don't use containers by default on macOS yet

Have you tried it with a podman machine?
ramalama --container ps

It works great if podman machine is started.
We should either print a more informative message when we are not using containers, that ramalama ps is not supported when not using containers
or
maybe do some kind of a fancy pgrep for llama.cpp, vllm processes, etc. depending on runtime


Update the migration guide with the latest version.

Update one changelog
New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[x] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...
Pull Request Description
This PR contains any update for the wiki/documentation/changelog. You can just put anything to change for these into single PR.
Everyone who need to change documentations can directlly add commit here. So we don't need to merge again and again.
Until final update is done, we can merge and release the 5.0 version (Or another beta version if we find something important to change and test)

Good idea @dreampiggy

Codecov Report

Merging #2388 into 5.x will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              5.x    #2388      +/-   ##
==========================================
- Coverage   68.77%   68.71%   -0.07%
==========================================
  Files          47       47
  Lines        6607     6607
==========================================
- Hits         4544     4540       -4
- Misses       2063     2067       +4

Flag
Coverage Δ

#iOS
69.72% <ø> (-0.02%)
:arrow_down:

#macOS
68.11% <ø> (-0.02%)
:arrow_down:

Impacted Files
Coverage Δ

SDWebImage/SDWebImageManager.m
81.3% <0%> (-0.82%)
:arrow_down:

SDWebImage/SDWebImageDownloaderOperation.m
87.62% <0%> (-0.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 957de6d...ffad516. Read the comment docs.

@bpoplauschi This one now been updated to the latest 5.x. Maybe it's time to merge.


Creating Buzz

[ ] Netzwerk nutzen

[ ] Social Sharing

[ ] Marketing Copy

[ ] Sales Copy

Since this is in "Done" now, I'm closing this


Humidity not passed

First of all great plugin, but I have a few things I would like to have included :) First of all the humidity seems to not be passing through to homekit. I don't see the value showing up while it is included in the script output. Below the current output. It also returns the air pressure which can be ignored.
{ "targetTemperature": 19, "temperature": 20, "humidity": 48.4, "pressure": 104546 }

Hello,
CurrentHumidity and TargetHumidity are currently managed by the plugin. Presure is not managed yet because apple is not expecting such a value. If you can tel me what the value for a thermostat to handle this, I will consider this or you can suggest a pull request.
Finally, I played a bit with additional Characteristics and "Home" App is not that fancy when it comes to complex objects (only basic stuff are perfectly integrated for now. (eg speakers and displayed as "not managed" even if present in the documentation)
Best,


Call mediator with blocking attribute set to "true" does not comply with "POST_TO_URI" value

Description:
It seems that when you use the "call" mediator with the "blocking" attribute set to "true", the "POST_TO_URI" axis2 property is ignored.
Suggested Labels:
Suggested Assignees:
Affected Product Version:
Micro Integrator Server 1.1.0 (embedded in Integration Studio), maybe MI1.1.0 "standalone" too.

The first one performs as expected, the second one does not.
curl --location --request GET 'http://localhost:8290/test/false/http/proxy/www.mocky.io/v2/5ea964d12d0000c6623a45cc/?q=pippo'

curl --location --request GET 'http://localhost:8290/test/true/http/proxy/www.mocky.io/v2/5ea964d12d0000c6623a45cc/?q=pippo'

Related Issues:

Hi, any news about this?

@gspadotto Thank you for taking the time to raise this issue; we genuinely appreciate your input and feedback.
This bug, along with others labeled "IceBox," was closed as part of some recent triage to streamline active work.
We’ll review the issue further and provide updates.


[FEATURE]Reduce IT Test time

Is your feature request related to a problem?
Currently it takes more than 60 minutes to complete the tests for the  test & build github workflow
What solution would you like?
We need to significantly reduce this time for better development responsiveness and fail-fast
Do you have any additional context?

attempt to parallel the IT tests

[Catch All Triage - 1, 2, 3, 4, 5]


Make openstack_keys param support no acls list

A recent change [1] required that the openstack_keys
param always containe an acls list. However, it's
possible it might not contain that list. Thus, this
param sets a default for that list to be empty if it
is not in the structure as defined by the user.
[1] d65cbaa53952269ec9a2e76fca8203ce7ad22c2b

related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1506625


insomnia: 7.0.3 -> 7.0.5

Motivation for this change
https://github.com/Kong/insomnia/releases/tag/v7.0.5
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @markus1189 @babariviere

This change is

Thanks!


Stash Support

First off, awesome package so thanks for making it!
Second, any chance for Stash support. I was thinking of keeping it simple and having creating a stash and applying it on the current branch.

I am using stash without any issues. It seems to work with any git repo (used with github, bitbucket and stash)

@GradyD Do you mean on the command line? because as far as I can tell, there is no stash support in git-control yet.

When you say stash I assume you are talking about the enterprise stash (git) server?
We have stash internally and I haven't had any issues. Once I configure the repo via command line (add the origin and git init) I can use stash without any issues.
Stash is just software that provides a GUI and permissions to git repos. You are still using the basic git commands to work with stash.

This bug is about git stash. I doubt there is any need for support for a git server. As long as it talks the right protocol, there's no issue.

Ahh my bad! Yes this would be handy.

I want Stash button like in SourceTree.

+1


cpu: No Errors But No Answer

what are the min req for cpu ? I ran this on i7 32g ram
but ran for over 20min with no answer / then killed it used the .env default models as noted in readme
anytricks to get this up and working on cpu only?

Yeah I ran the default
model_path_llama=WizardLM-7B-uncensored.ggmlv3.q8_0.bin
No getting answer.. will try again
Thanks

Ok.  Yes, that's our default case that's part of our test suite too.
Are you using CLI or UI?

The ui .. I will try on a gpu tomorrow
Where is the cli version?

Also windows or linux?
The CLI way is described here: https://github.com/h2oai/h2ogpt#cli-chat

Streaming in UI for CPU models isn't supported yet.  Perhaps you didn't wait long enough?
error: requested results 1000 is greater than number of elements in index 266, updating n_results = 266

not actually an error, you can ignore
llama_tokenize: too many tokens

I see, probably large input and even tokenizer can't handle beyond some limit of input text.  Will review.


Error on upgrading DB from V1 to V2

Description
A error shows up on startup, this is from having luckperms before when it was on V2 storage
Reproduction Steps
Server version 1.19.4 and run the LuckPerms version that released during 1.19.4 (or whatever version that used V1 H2)
Download LuckPerms latest
Restart server
Expected Behaviour
For this error not to show up
Server Details
[09:29:12 INFO]: Current: git-PufferfishPlusPurpur-19 (MC: 1.19.4)* You are on the latest version!
LuckPerms Version
LuckPerms v5.4.84
Logs and Configs
[09:26:33 WARN]: [LuckPerms] [DB Upgrade] Found an old (v1) H2 database file. LuckPerms will now attempt to upgrade it to v2 (this is a one time operation).
[09:26:33 INFO]: [LuckPerms] [DB Upgrade] Stage 1: Exporting the old database to an intermediary file...
[09:26:33 INFO]: [LuckPerms] [DB Upgrade] Stage 2: Importing the intermediary file into the new database...
[09:26:33 WARN]: [LuckPerms] Something went wrong whilst upgrading the LuckPerms database. Please report this on GitHub.
org.h2.jdbc.JdbcSQLSyntaxErrorException: Sequence "SYSTEM_SEQUENCE_C93A0991_FD00_4F42_9BD6_B9BAF3B349D5" already exists; SQL statement:
CREATE SEQUENCE "PUBLIC"."SYSTEM_SEQUENCE_C93A0991_FD00_4F42_9BD6_B9BAF3B349D5" START WITH 1 BELONGS_TO_TABLE [90035-214]
at org.h2.message.DbException.getJdbcSQLException(DbException.java:632) ~[?:?]
at org.h2.message.DbException.getJdbcSQLException(DbException.java:477) ~[?:?]
at org.h2.message.DbException.get(DbException.java:223) ~[?:?]
at org.h2.message.DbException.get(DbException.java:199) ~[?:?]
at org.h2.command.ddl.CreateSequence.update(CreateSequence.java:53) ~[?:?]
at org.h2.command.ddl.SchemaOwnerCommand.update(SchemaOwnerCommand.java:33) ~[?:?]
at org.h2.command.CommandContainer.update(CommandContainer.java:169) ~[?:?]
at org.h2.command.Command.executeUpdate(Command.java:252) ~[?:?]
at org.h2.command.dml.RunScriptCommand.execute(RunScriptCommand.java:108) ~[?:?]
at org.h2.command.dml.RunScriptCommand.update(RunScriptCommand.java:70) ~[?:?]
at org.h2.command.CommandContainer.update(CommandContainer.java:169) ~[?:?]
at org.h2.command.Command.executeUpdate(Command.java:252) ~[?:?]
at org.h2.jdbc.JdbcStatement.executeInternal(JdbcStatement.java:252) ~[?:?]
at org.h2.jdbc.JdbcStatement.execute(JdbcStatement.java:223) ~[?:?]
at me.lucko.luckperms.common.storage.implementation.sql.connection.file.H2ConnectionFactory$MigrateH2ToVersion2.run(H2ConnectionFactory.java:137) ~[?:?]
at me.lucko.luckperms.common.storage.implementation.sql.connection.file.H2ConnectionFactory.init(H2ConnectionFactory.java:67) ~[?:?]
at me.lucko.luckperms.common.storage.implementation.sql.SqlStorage.init(SqlStorage.java:164) ~[?:?]
at me.lucko.luckperms.common.storage.Storage.init(Storage.java:115) ~[?:?]
at me.lucko.luckperms.common.storage.StorageFactory.getInstance(StorageFactory.java:87) ~[?:?]
at me.lucko.luckperms.common.plugin.AbstractLuckPermsPlugin.enable(AbstractLuckPermsPlugin.java:184) ~[?:?]
at me.lucko.luckperms.bukkit.LPBukkitBootstrap.onEnable(LPBukkitBootstrap.java:175) ~[?:?]
at me.lucko.luckperms.bukkit.loader.BukkitLoaderPlugin.onEnable(BukkitLoaderPlugin.java:50) ~[LuckPerms-Bukkit-5.4.84.jar:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:279) ~[pufferfishplus-api-1.19.4-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin() ~[pufferfishplus-1.19.4.jar:git-PufferfishPlusPurpur-19]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin() ~[pufferfishplus-1.19.4.jar:git-PufferfishPlusPurpur-19]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:507) ~[pufferfishplus-api-1.19.4-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.v1_19_R3.CraftServer.enablePlugin() ~[pufferfishplus-1.19.4.jar:git-PufferfishPlusPurpur-19]
at org.bukkit.craftbukkit.v1_19_R3.CraftServer.enablePlugins() ~[pufferfishplus-1.19.4.jar:git-PufferfishPlusPurpur-19]
at net.minecraft.server.dedicated.DedicatedServer.e(DedicatedServer.java) ~[pufferfishplus-1.19.4.jar:git-PufferfishPlusPurpur-19]
at net.minecraft.server.MinecraftServer.w(MinecraftServer.java) ~[pufferfishplus-1.19.4.jar:git-PufferfishPlusPurpur-19]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java) ~[pufferfishplus-1.19.4.jar:git-PufferfishPlusPurpur-19]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
[09:26:34 INFO]: [LuckPerms] Loading internal permission managers...
[09:26:34 INFO]: [LuckPerms] Performing initial data load...
[09:26:34 INFO]: [LuckPerms] Successfully enabled. (took 2089ms)

Best course of action in this situation is to:

Roll back to the last installed version of LuckPerms that worked, and do a /lp export
Stop the server
Delete (create a backup / move it somewhere else) the old database file
Start the server and run /lp import


Fix tekton results structure

Changes

Simplify tekton results folder structure
Add service monitor config.

/test pipeline-service-test

/test pipeline-service-upgrade-test

OK @sayan-biswas we have to remember that after this merges, rather than using the auto-generated PR to update infra-deployments, you have to create a manual version of that PR, where you include the same changes it has, but also remove the servicemonitor currently being created in infra-deployments

@gabemontero Yes. Need to remove the service monitor components there and update the kustomize.


how to refresh grid in another tab

Hi
I have a form with 3 tabs. I want to refresh the grid in third tab after a record is saved in second tab.
Thank you for the help

Its a PropertGridtab or Custom tab by customizing the template?
Case1 i,e (PropertGrid Tab)
As far as its in same form and if the grid belongs to list of items the editor will be EntityGrid/Datagrid/MemoryGrid, in this case, you can call
this.form.fieldname.refresh(); after whatever your event is (on change of another form field in your case)
Case2 (i,e Template based tab)
In this case first you need to have reference to your form where grid is located
this.form_in_thirdtab= new Default.FormName(this.idPrefix + "FormName");
and then you can call
this.form.fieldname.refresh();
or you can directly get the grid reference by id inside a dialog and call the refresh method.

@djhonb
thank you for the response but I am going to refresh Grid in another Tab.

you can do it in Tab click event

@ms4hafiz ,
as @welcometoall already stated - do the refresh (mentioned in code by @djhonb) when you click on 3rd tab - as you only need the visible refresh when focus is going back to 3rd tab.
With kind regards,
John

Closed due inactivity
Also check the issue guidelines.
If you still need help, you can ask this on stackoverflow with our new tag.
https://stackoverflow.com/tags/serenity-platform


per-element dropdown expand-direction setting

As You can see, sometimes elements, especially like dropdowns is better to place in corners. In that case the theme is not an easy option for making expand direction for the particular element.

I would suggest add expand_direction parameter in __init__ or make a method, something like this:
def set_expand_direction(self, direction:str) -> None:
    self.expand_direction = direction
    for state in self.menu_states.values():
        state.expand_direction = direction

Thanks!
Sorry, I really don't want to make PR, as I'm not sure the pygame and pygame_gui are the frameworks I'll stick with...

Thankyou for the feedback.
It is fairly easy to give each of the dropdowns a theming class ID so you can change the expansion direction for just the ones at the bottom:
code snippet:
from pygame_gui.core import ObjectID

note_pick_box = UIDropDownMenu(['Item 1', 'Item 2', 'Item 3'],
                               'Item 1',
                               pygame.Rect(10, 450), (200, 25)),
                               manager,
                               object_id=ObjectID(class_id="@bottom_drop_down",
                                                  object_id="#note_picker")
                               )

audio_pick_box = UIDropDownMenu(['Item 1', 'Item 2', 'Item 3'],
                                'Item 1',
                                pygame.Rect(10, 10), (200, 25)),
                                manager,
                                object_id=ObjectID(class_id="@up_drop_down",
                                                   object_id="#audio_picker")
                               )

midi_pick_box = UIDropDownMenu(['Item 1', 'Item 2', 'Item 3'],
                               'Item 1',
                               pygame.Rect(250, 10), (200, 25)),
                               manager,
                               object_id=ObjectID(class_id="@up_drop_down",
                                                   object_id="#midi_picker")
                               )

theme snippet:
{
    "@bottom_drop_down":
    {
        "misc":
        {
            "expand_direction": "up"
        }
    }
}

Is that good enough for your purposes?

Thanks!


remove deprecated dependency

removes deprecated @type/commander dependency - this seperate type package is no longer needed as its provided by the main package (which is why its deprecated)
the package version was updated as well by npm install (looks like it was out of date)

I am using tunnelmole-client in a project and installing packages warned me of the deprecated sub-dependency. See: https://www.npmjs.com/package/@types/commander
npm run build and npm run tests complete without error.

Thanks


[ServiceBus] Remove dedupe of buffer in rollup script

For more context to issues leading to these changes refer to #5983

I filed #6029 to update the lockfile and am running a full CI pass from there. If everything is good to go there, we can rebase this PR and scope it to just the rollup config change for service bus.

The linked issue talks about the wrong updates to the lock file which this PR attempts to fix as per the PR title.
But we are also removing the deduping of buffer in this PR.
Are we to assume that the bad changes to the lock file was the reason for introducing the dedupe?

@ramya-rao-a that's what it looks like - the lockfile was specifying different versions of buffer for direct dependencies and the version used by amqp-common. How such a lockfile got generated in the first place is a mystery.

The other thing is that if version 5.4.3 is the one that has the fix for rollup issue, shouldn't we be using that as the minimum version? @mikeharder @KarishmaGhiya @bterlson

The fix for #5983 doesn't have to do with buffer itself but how Rush selects versions to link together, which is determined by the contents of the lockfile. Users doing an npm install will likely get 5.4.3 unless other parts of their application require an older version.

@ramya0820 #6029 is merged. Please rebase/merge from master

/azp run js - servicebus-client - tests

/azp run js - servicebus - tests


Reuse Rebuild IO handles

fix(rebuild): reuse rebuild IO handles

Reuses the rebuild IO handles, rather than attempting to allocate
them per rebuild task.
The main issue with handle allocation on the fly is that the target
may have not cleaned up a previous IO qpair connection, and so the
connect may fail. We started seeing this more on CI because we forgot
to cherry-pick a commit increasing the retry delay.
However, after inspecting a bunch of user support bundles I see that
we still have occasional connect errors. Rather than increasing the
timeout, we attempt here to reuse the handles, thus avoid the
problem almost entirely.

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

refactor(rebuild): rebuild completion is not an error

When the rebuild has been complete, if we wait for it this fails because
the channels are not longer available.
Instead, simply return the rebuild state, since this is what we want anyway.

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

lgtm. As I understand we'll now make all 16 rebuild tasks use the same connection for reading/writing the rebuild segments.

Yes, each task has the immutable RebuildDescriptor and reuse the handles from there.

Is the rebuild descriptor destroyed today as soon as rebuild finishes and the nexus channels are reconfigured to add rebuilt bdev's handle? We wouldn't want a lingering handle in rebuild descriptor while the rebuilt child bdev handle has been added to main nexus channels too.

Yes that's right, the rebuild backend "runs away" when the rebuild is started. When the rebuild completes the backend terminates, and on the drop, the handles are also dropped.
Eventually we can also improve things here by moving the handle to the tasks themselves, allowing us to drop the handles if the rebuild is paused for example. Also that could be the first step to allowing the rebuild to run on multi-cores too.
For now simply moving the handle to descriptor is good enough for solving the connection issues.

bors merge


Migrate sample server to v1beta1

The current server implementation uses the v1alpha1 which makes it incompatible with kritis reference implementation.
The only conflict in the migration is how to treat the operations API which does not exist in v1beta1.

Thanks @vtsao and @aysylu, we need the v1beta1 migration to embed the code in kirtis.
I already started the migration in #220 and I think that the required changes are relatively minor.

Hi @liron-l sorry for the delayed response. Could you attend our next Grafeas developers sync to discuss this PR? If you haven't already, please join https://groups.google.com/forum/#!forum/grafeas-dev and you should see the meeting on your Google calendar. The next sync is on Oct 9.

Sure @vtsao. Please let me know if additional details should be added to #220.


Update banking.yml

Added Canadian Bank called Tangerine. Does not support any 2FA.

you need to add a 32x32px logo. See the CONTRIBUTING.md

Sorry about that. I'm not sure how to do that easily but I do have the image right here.

cheers

Images can't be added from the website. You need to download and install the Git client to add the file to your pull.

Please remove hardware: No and software: No since you've already stated the bank doesn't provide any form of tfa.


Clarify config for NotificationQ and BusEvent

Today they both use similar properties exposed in the base class PersistentQueueConfig, but some properties are not available for both, and some mean different things (e.g getQueueCapacity which refers to a different queue)

Closed with https://github.com/killbill/killbill-commons/compare/f2baacaf0239f954f320a5086ca4f22a3d5687d7...72ed7ac58027c5061f6ba7eeefefc780c91dc3c9


Multi-architecture, runnable Docker image

Fix #18
Title says all.
This is a dockerfile allowing one to cross-compile goplay2 and produce a usable, runnable multi-architecture image.
The invocation command is a bit of a mouthful though that could be made simpler.
The main "limitation" right now is that it expects pulseaudio to be running on the host or in another docker image (I really did not feel like cramming in pulseaudio here).
I'm running this in docker on a RPI 3.

I also updated the README to reflect these changes.
Specifically, I removed the mention about having to change the mDNS implementation to be able to use it in a container - I don't think that's true. Brutella is just fine running inside a container - it's more a matter of using the right networking mode (mac/ip vlan or host), since the protocol needs to be able to broadcast.

About mdns it is specially true on Mac where docker run in a Vm.
Anyhow, there is no pulseaudio file on Mac…
I was about to remove the Docker part (see features/audio-sync branch) but I will let yours instead.
I have trouble with pulseaudio, I might come back to alsa. Do not know if it will work with docker though ?…

About mdns it is specially true on Mac where docker run in a Vm.

Yeah, I can look more into the docker4mac side if this is useful - networking has always been a bit dark magic over there - but personally, I would rather focus more on providing a brew formula on mac.

I have trouble with pulseaudio, I might come back to alsa.

+1 on this. As far as I'm concerned, Pulse does not provide value to my use cases (RPI as audio receivers) and just adds a useless layer of complexity on top of alsa.
I understand why some people may want Pulse on the desktop.
Is there a world where goplay would have a concept of backends (alsa, stdout, pipe, pulse) that the user could select?
As far as Docker is concerned, using alsa is trivial. You just need to mount the appropriate device and group.
This shows a concrete example with a shairport-sync image: https://github.com/dubo-dubon-duponey/docker-airplay#run

@AlbanSeurat I was also thinking about this: if you want to publish a multi-architecture version of your image to Docker Hub (of ghcr), let me know and I can just add a shell script / makefile (or more documentation) with the right buildctl/buildkit invocation to do so.

Is there a world where goplay would have a concept of backends (alsa, stdout, pipe, pulse) that the user could select?

I would rather have one backend perfectly working than allow to have several. Audio-sync require timing precision and it is not simple to ensure that on multi-backend.
For now, pulseaudio with the go lib I am using prevent me to have good timing, I will see all in September.

@AlbanSeurat I was also thinking about this: if you want to publish a multi-architecture version of your image to Docker Hub (of ghcr), let me know and I can just add a shell script / makefile (or more documentation) with the right buildctl/buildkit invocation to do so.

I am not in a phase where I focus on publishing binaries but any helps is welcomed !

Is there a world where goplay would have a concept of backends (alsa, stdout, pipe, pulse) that the user could select?

I would rather have one backend perfectly working than allow to choose from several options. Audio-sync require timing precision and it is not simple to ensure that with one backend…
For now, pulseaudio with the go lib I am using prevent me to have good timing, I will look at that in September.

Makes perfect sense to me.
And my vote is for just alsa indeed.


Doc has differences from the actual Microsoft Entra Admin Portal and Azure Portal (ibiza)

I noticed some small differences between the public doc and the Entra Portal. (Customer Walmart noticed the same)
Docs shows Passkeys (FIDO2) but Portal still shows FIDO Security Tokens, it will get customers confused wondering if their tenant did not received the feature:

On Advanced Settings, our doc shows a selection box that doesn't exist anymore:
Doc Image:

Actual portal:

We should update it to avoid confusion with customers.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 784337eb-25c8-e8b5-58ff-b5d3b32c6298
Version Independent ID: 784337eb-25c8-e8b5-58ff-b5d3b32c6298
Content: Enable passkeys for your organization (preview) - Microsoft Entra ID
Content Source: docs/identity/authentication/how-to-enable-passkey-fido2.md
Service: entra-id
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@rodrigoffonseca
Thanks for your feedback! We will investigate and update as appropriate.

@rodrigoffonseca
I'm going to assign this to the document author so they can take a look at it accordingly.
@Justinha
Can you please check and add your comments on this doc update request as applicable.

@rodrigoffonseca thanks for raising this! Yes, the portal UX change is delayed. We reverted the screenshots. #please-close


Refactoring: move module member to different module

Related existing issues: microsoft/vscode-python#4628
Same feature as described on this PyCharm documentation page:
https://www.jetbrains.com/help/pycharm/move-refactorings.html#move_module_members
Would be used as such:

Select variable or function foo
Press shortcut or select "Move" action
Select an existing destination module bar.py
The imports of foo across the whole project are updated to reflect the change

I'm creating a new feature request since microsoft/vscode-python#4628 seems to focus on the file renaming refactoring feature.

I consider Move Refactorings (and Changing Signature) a fundamental functionality for every developer working on any non-trivial codebase. I've been a long term PyCharm user but I always give a try to VS Code once in a while to see if it is ready to be my primary IDE. Unfortunately lack of this sends me again back to PyCharm.
I'm also not sure if votes on this issue are the right measure of its importance. I think many developers who give VS Code a try but then are not able to do basic stuff which they are used to do easily in other IDEs like PyCharm just give up and go back to their IDE without digging deep into issues on GitHub in multiple different repos. It took me quite a while to land on this page.

I also consider this a very useful feature. I can't really list the use cases of this except for when I realize that a method/function that is already working properly would be better suited residing in another class/module, but changing all of its usages in the code would be really tedious and error-prone.
Right now I do it by using the Ctrl + Shift + H functionality (Replace in Project), but having a foolproof, automated way would be awesome.

I believe people at Microsoft don't use VSCode at all... It is just impossible to be productive without refactorings, good auto complete, real auto import, and many other things. If you work without that stuff, dude.... download some pro tools and try them off to get inspired!

not sure what you're on about, but Pylance has most of the stuff you mentioned

@jakebailey, that doesn't work, I already tried it from the post you mention. I am not getting the behavior I expect... I recommend you to try PyCharm and see how autocomplete has to work...
And you can ask me why don't just use PyCharm? Well, I am a professor, and many students don't have enough resources to work with PyCharm in their computers, so we need a more lightweight IDE.
Parallely I'm looking for a PyCharm replacement for my job, because lately it is out of control with resources usage, completely missoptimized.
But when I try to do IDEs stuff I find this kind of WTF.

Can you please try enabling indexing with this?
"python.analysis.indexing": true

For user code, see also #1055.

@jakebailey, that doesn't work, I already tried it some time ago.

Any updates on this? Not being able to refactor is a huge obstacle.

@bjarkemoensted we started doing incremental rollout for module rename refactoring. member move is being worked on. still require more work.

@cperezabo @hmoravec if you can open your own issue with issues you are having, it would be easier for us to track and address the issues. and leave this issue for the refactoring.


WebSocket for connection

It looks like when you use TCP to connect to erlamsa as a network service, you get one input back and then the connection closes. This seems like a pretty big performance hit due to the time it takes to setup a TCP connection.
Is there a way to have erlamsa listen on a websocket and then we can connect with a weboscket and push/pull. Thinking the following:

Client (Frida in the demo) connects up to erlamsa server over websocket
Client sends specification for the type of data/mutation it wants
Server sends back a mutation
Client tests mutation
Client sends back some sort of crash or not crash message to server
Server sends next mutation
Repeat as needed

The sending back of crash vs no crash would be duplicate if erlamsa was already monitoring the process, but in the event that it wasn't able to monitor (remote for instance), it could still keep track of what worked. Similarly, it might imply a crash if the client disconnects without sending a 'quit' message.

I was thinking of implementing and additional websocket interface [to plain HTTP and JSON endpoints]. So far it have very low priority in the todo list, as the TCP connection setup time is incomparable with the computational time required by mutation process.


nthChild test does not appear to work...

Challenge http://www.freecodecamp.com/challenges/waypoint-target-a-specific-child-of-an-element-using-jquery has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
CODE:
$(".well:nth-child(2)").addClass("animated bounce");
No nth-child works (have tried 0, 1, 2, 3). 2 visibly works, but "The second element in each of your well elements should bounce.
Visibly working (but not 'marked as correct'):

jQuery Playground

#left-well

#target1
#target2
#target3

#right-well

#target4
#target5
#target6

I am experiencing this as well

This is how it works for me:
$(".well button:nth-child(2)").addClass("animated bounce");
from: jQuery API

Or this:
$(".target:nth-child(2)").addClass("animated bounce");

same code actually worked on the next challenge :)

I experienced the same bug, exercise need a fix.

I found that when I put a space between the class selector and :nth-child, the exercise worked. The instructions should be revised to include this space if that is the desired result.
$(".well :nth-child(2)").addClass("animated bounce");

Hey thanks for posting!
See #1927 for my explanation there (similar to what @paulboardman and @ngrandison said).  It is still open and will can remain as the main issue for this problem.  Feel free to close this as a duplicate.
Also, take a look at our Bug Posting Guidelines to see the best way to resolve a problem with the site.


Spleen bundle spatial_shape not match in metadata.json

In https://github.com/Project-MONAI/tutorials/blob/32dfc1cf45f0fceeab4ab9e2828d571e317d8a1a/modules/bundle/spleen_segmentation/configs/metadata.json#L37
The spatial_shape is (160, 160, 160), but the spatial size for training and the roi size for inference is (96, 96, 96) (see here).
The size should be unified.
In addition, I still have the following questions about the metadata.json part.

The data_type is "dicom" (see here), but the data is in nii.gz form. Is it an error here? How should we define the data_type here?
How should we define the format of image (see here). For spleen dataset, it is "magnitude", how about the brats dataset?
As for the spatial_shape mentioned above, if the input size of the network in training is different from the roi size used for inference, which one should be used for spatial_shape in the metadata? As for a segmentation model, different sizes are supported usually, thus I'm not sure how to define it.

Hi @ericspod , may need your help to explain these questions, thanks!

The spatial_shape value is provided if there is a set size of inputs the network requires, this can be specified as literals or expressions based on variables if the size varies but has constraints. In this case the shape should match what's in training and what's in the specification. If a network is trained patchwise but applied to whole images at inference or vice versa then these would be different.
Data type should be "type of source data used for training/validation" as in the spec so here probably should be nifti, this is meant for human understanding so saying more than just that would be helpful as well.
The idea with format is to specify something about what the contents of the data are, so the data are images but specifically for MR they are magnitude values as opposed to categories for segmentations or Hounsfield Units for CT. The value here should be "hounsfield" as the inputs are CT. The "modality" value should be "CT" as well.

Thanks @ericspod  for the detailed clarification.

expressions based on variables if the size varies but has constraints
As for the expression, do you have any advices on how to do that? Should it be a sentence? For instance, if the input size should be divisible by 16.

The specification states at the bottom what this would look like:
Spatial shape definition can be complex for models accepting inputs of varying shapes, especially if there are specific conditions on what those shapes can be. Shapes are specified as lists of either positive integers for fixed sizes or strings containing expressions defining the condition a size depends on. This can be “*” to mean any size, or use an expression with Python mathematical operators and one character variables to represent dependence on an unknown quantity. For example, “2**n” represents a size which must be a power of 2, “2**n*m” must be a multiple of a power of 2. Variables are shared between dimension expressions, so a spatial shape of [“2**n”, “2**n”] states that the dimensions must be the same powers of 2 given by n.

This would be used as the example describes to define constraint between dimension sizes the network imposes. A more complex example like [m*(2**(3+n)),m*(2**(3+n))] would require inputs to have shapes that are multiples of powers of 2 with a minimum size of 8, another way to state the same thing would be [8+m*(2**n),8+m*(2**n)].


Fix my blogpost title in the README :)

I even missed it myself when scanning the readme to see if I needed to add it :)

Haha sorry about that!


invalidate the preload cache when checkout cancels, completes or fails

What are you trying to accomplish?
Fixes a current bug where:

preload is enabled
preload is never called
present is called (view cached)
checkout is closed
cart is modified
checkout is opened (cached view is used, without reflecting changes to the cart)

Follows the recommendation here, coupling the cached view to a present() call, and clearing the cache when:

checkout is closed/cancelled
checkout is completed
checkout fails with an error

Before you deploy

[x] I have added tests to support my implementation
[x] I have read and agree with the contributing documentation readme
[x] I have read and agree with the code of conduct documentation readme
[x] I have updated any documentation related to these changes.
[x] I have updated the README (if applicable).

👏🏻


Package manifpy

Since 0.0.4, manif also can install python bindings based on pybind11 . We should package them.

Given that manif is an header-only library, so differently from ruckig (https://github.com/conda-forge/staged-recipes/pull/14459) we don't need to have a single build process that generates two outputs with a dependency between the two, but it should be sufficient to just run the existing setup.py .