Update to ical 6 and update exception handling

Codecov Report

Merging #354 (9132cb7) into main (023d9be) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
- Coverage   97.41%   97.31%   -0.10%
==========================================
  Files           9        9
  Lines         928      932       +4
==========================================
+ Hits          904      907       +3
- Misses         24       25       +1

Files
Coverage Δ

gcal_sync/model.py
97.40% <100.00%> (-0.24%)
:arrow_down:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!


5.9: [Test] Marked execution test requires execution.

rdar://111066023

@swift-ci please test and merge


Crash when receiving FCAttemptToSaveAfterDelete

Statium iOS 0.2.1 got several crashes due to FCAttemptToSaveAfterDelete exceptions.
Investigation identified 2 scenarios when this could happen:

When a start message is sent twice in a row => this shouldn't happen
When starting/stopping messages, the reference of the callback can mess up the call of
+ cancelPreviousPerformRequestsWithTarget:selector:object:

Done.


build error when try to use custom library and header

Hello,
I'm trying to build netopeer2 with custom library and header that I've put in other directory by doing this:

but end up meet this error

what am I missing here

Looking at the OpenSSL repository, it seems this header is being generated. That means your OpenSSL include directory must be not only the one you have used but also the one where generated files are put in. It is up to you to find it.
However, you would spare yourself these problems if you followed the usual way of using custom libraries in compilation. Which is installing all of them into a specific path and then pass only this path as include/library directory. You will never miss any files that way.

Thank you for quick response and your advice. I installed all of them into same directory and only need to use prefix to install sysrepo, libnetconf2, netopeer2 still need include/library path as you said. 👍

If I use custom path directory to build:

how can I specify the sysrepoctl path to automatically install netopeer2 YANG model by script

how can I use lib files that I store in my custom directory to run sysrepoctl after I specify its path (I used to use export LD_LIBRARY_PATH to run)

why I don't find netopeer2-cli in prefix directory

I got this error message

It is expected that it is somewhere in PATH. If it is not, you can temporarily make it so by adding the directory with it into the PATH environment variable.
Generic Linux question but fine, I will answer. You can either do it the way you mentioned or make sure your ld(1) finds it. Look into ldconfig(8) man page to learn how to add new paths with libraries to it.
Because it is installed in the last step of netopeer2 installation but in your case it has failed before it.

Thanks, I set SYSREPOCTL_EXECUTABLE to sysrepoctl's path and then make install and netopeer2 installation successful


Architect Online Server and Transfer Mechanism

For our online server, we need to establish how we will sync data from our local Pi's, we should have some kind of REST API in place. I'd rather not expose the raw DB over the net.
Waiting for more details on this, hosting wise.

Thinking Heroku & mLab for our cloud system. This would be free up to 500MB of data.
Thoughts?

Closing this, going to use the same code base, will develop a HTTP endpoint as part of the existing webhook to push all the data from local to the cloud.
Additionally, this functionality can be leveraged later to clone data between Pi's if we'd like.


Include publishing notes in footer

I would like to include publishing notes in the footer / specify a custom footer.
There does not seem to be a theme option for that:
https://sphinx-rtd-theme.readthedocs.io/en/stable/configuring.html#theme-options
=> What is the recommended way to include publishing notes?
Also see
https://stackoverflow.com/questions/76809542/how-to-include-publishing-notes-in-sphinx-documentation
Related: #1410

Already answered in https://github.com/readthedocs/sphinx_rtd_theme/issues/349


HTTP ERROR undefined while browsing sub/category pages.

Relates to:
#3298
Current behavior
502 errors in dev console.
In the following configuration, where:
filterUnavailableVariants = true
configurableChildrenStockPrefetchStatic = false
configurableChildrenStockPrefetchDynamic = false
HTTP ERROR undefined appears when browsing different pages.

Expected behavior
There should be no errors.
Steps to reproduce the issue

Just open vsf with the latest develop branch
Go to any category/sub-category page

Repository

Can you handle fixing this bug by yourself?

[ ] YES
[x] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser:
OS:
Node:
Code Version:

Additional information

Can't reproduce this on develop. My settings:
"configurableChildrenStockPrefetchStatic": false,
"configurableChildrenStockPrefetchDynamic": false,
"configurableChildrenStockPrefetchStaticPrefetchCount": 8,
"filterUnavailableVariants": true,


Fonts2

Both Font Awesome and Source Sand Pro are now used from TeX installation, no need to bundle them.

Thanks! It's very useful changes 👍


Increment version for appconfiguration releases

Increment package version after release of azure-app-configuration

@chidozieononiwu ping!

@chidozieononiwu ping!

We can go ahead and close this.


Reset jwt status when acquire_jwt is 0

parodus connection is keep on retrying when acquire_jwt is 0 or FEATURE_DNS_QUERY is OFF with recent change in dns query logic. Reset of jwt_status is missed in these 2 cases. So added reset to fix retry issue.

Codecov Report

Merging #183 into master will increase coverage by 0.18%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   83.64%   83.83%   +0.18%
==========================================
  Files          39       39
  Lines        4024     4026       +2
  Branches      336      336
==========================================
+ Hits         3366     3375       +9
+ Misses        399      392       -7
  Partials      259      259

Impacted Files
Coverage Δ

src/connection.c
73.7% <0%> (-0.65%)
:arrow_down:

tests/test_client_list.c
91.42% <0%> (+6.42%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af33be...7eba72b. Read the comment docs.


Ability to reset the demo to a preset baseline configuration

There are various use cases for the reset. Variations specific to with/without > 1 users and with/without GPCS as part of the demo. The demo system should also remove licenses from the fw before deleting the image.
For a basic single user w/out GPCS, easy to go into Panorama and delete all device-groups and stacks then commit. Or use the Vistoq portal to go to a preset configuration file. This puts Panorama back to the initial state. In relation, the instantiated firewalls can be deleted from the portal. In this case, the automated model would:
Reset Panorama to baseline or delete device-groups and stacks (assumes no other config changes) with a commit
Return the fw licenses back to the pool
Delete the fw instances
If GPCS is included in the demo it gets a bit more complex. Panorama should remove all of the remote network configurations, commit and push to the cloud. This ensures the cloud config is sync'd. In the current version of Panorama (no multi-tenancy) the DG and stack stay as part of the core. In future versions, the demo may require core and remote_network config deletions.
Flow may be for simple remote network demo:
Remove all remote networks and commit to the cloud
A full demo including a new core (non-multitenancy) may require reset of Panorama to a snapshot image, just after the OTP is added. Early version of GPCS had issues with modifying the core configuration including changes to the infrastructure subnet. Once reset then a commit to the cloud to sync.
Multi-user demos as required will require more precise deletions. Thus likely manual with proper documentation. More complex solution would be to keep state of each demo addition and back out specific pieces.

Delete any DG/stacks for VM demos.
Delete the VM instances with license returned to the pool
Delete remote_network configurations (inc. IPSEC/IKE elements)

Should be opened on Vistoq


feat(auth): add secondary role option

Add secondary role option --secondary-role to allow assuming a role from another role. This is needed when a role can only be assumed from another role.
In this example, you must assume OpsUser role before you can assume SecretsAdmin role.
aws-okta-processor authenticate --user jdoe ... --role arn:aws:iam::111111111:role/OpsUser --secondary-role arn:aws:iam::111111111:role/SecretsAdmin

Is there anything else @dclayton-godaddy needs to do here to get this over the line?

@dduric-godaddy yes. That is the current behavior.


Why phone number required?

I don't think it is nessasary.

I don't think it is nessasary.
Are you talking about the domestic version?

As you can see, there are two versions available for Flat: one that requires phone number/binding and another that does not.
Based on Chinese privacy, a real-name system is necessary for all users. So, when you use the domestic version, no matter which method you use to register, a phone number is required (of course, there are other real-name authentication methods, and Flat currently chooses the mobile phone number).


Creating a single pin per iterm instead of one per mpin

Hello,
Currently, multiple Pins are created per PORT (mpin) of a PIN (in LEF terminology). This causes the sink-source check fail for any macro/cell that does have multiple ports on a pin. I have fixed it, so now all shapes across different mpins of an iterm are first merged then only a single Pin is created per iterm. All tests on openroad of OpenROAD are passing with this change.
Please let me know if I missed or misunderstood something.
Thanks.

@ax3ghazy Thanks for your updates. I will merge and test your PRs with other designs and let you know if I find any issue

Thank you @eder-matheus.


Declare the desired asyncio_default_fixture_loop_scope

pytest-asyncio is moving towards defaulting to the function scope. Select this now.

Thank you!!


Unbelievable! house of fun free coins bonus collector - The Ultimate Hack to Get house of fun free coins bonus collector Players Revealed!

Unbelievable! house of fun free coins bonus collector - The Ultimate Hack to Get house of fun free coins bonus collector  Players Revealed! You Won't Believe Your Eyes When You See How Easy It Is to Get house of fun free coins bonus collector  With This Game-Changing Tool!
🔴📺📱👉 Click here to get house of fun free coins bonus collector
🔴📺📱👉 Click here to get house of fun free coins bonus collector
🔴📺📱👉 Click here to get house of fun free coins bonus collector
🔴📺📱👉 Click here to get house of fun free coins bonus collector
🔴📺📱👉 Click here to get house of fun free coins bonus collector
🔴📺📱👉 Click here to get house of fun free coins bonus collector
"Unlocking the Secrets of the House of Fun Free Coins Bonus Collector"
In the dynamic world of online gaming, the House of Fun free coins bonus collector has become a coveted tool for avid players seeking to maximize their gaming experience. This feature-rich platform offers a unique opportunity to accumulate a steady stream of free coins, allowing users to explore the endless possibilities within the House of Fun ecosystem without financial constraints.
Navigating the House of Fun Free Coins Bonus Collector
One of the key benefits of the House of Fun free coins bonus collector is its user-friendly interface. The platform is designed to seamlessly integrate with the House of Fun gaming experience, making it easy for players to access and manage their free coin collection. With just a few clicks, users can claim their daily bonuses, participate in special events, and even unlock exclusive in-game content.
The House of Fun free coins bonus collector operates on a simple, yet effective premise. By completing various tasks and activities within the game, players can earn free coins that can be used to purchase upgrades, power-ups, and other valuable in-game resources. These tasks can range from simple daily check-ins to completing level challenges, participating in tournaments, or even engaging with the game's social features.
Maximizing Your Free Coin Collection
To truly make the most of the House of Fun free coins bonus collector, it's essential to develop a strategic approach. One effective tactic is to set daily or weekly goals for the amount of free coins you aim to accumulate. This can help you stay motivated and focused, ensuring that you don't miss out on any opportunities to earn those coveted coins.
Another valuable tip is to closely monitor the platform's promotional campaigns and special events. The House of Fun team regularly introduces new ways for players to earn free coins, such as limited-time bonuses, referral programs, or social media-based challenges. By staying up-to-date with these offerings, you can maximize your free coin collection and stay ahead of the game.
The Power of the House of Fun Free Coins Bonus Collector
The true power of the House of Fun free coins bonus collector lies in its ability to enhance the overall gaming experience. By accumulating a steady stream of free coins, players can unlock new levels, access exclusive features, and even compete in high-stakes tournaments without the financial burden of purchasing in-game currency.
This, in turn, can lead to a more immersive and rewarding gaming experience, as players can explore the game's content and features at their own pace, without the constant worry of running out of resources. The free coins bonus collector ultimately empowers players to focus on the fun and excitement of the game, rather than the financial aspect.
Conclusion
The House of Fun free coins bonus collector is a game-changing feature that has revolutionized the way players approach online gaming. By providing a reliable and accessible source of free coins, this platform allows users to truly immerse themselves in the House of Fun ecosystem, unlocking new levels of excitement and engagement.
Whether you're a seasoned House of Fun enthusiast or a newcomer to the game, the free coins bonus collector offers a unique opportunity to elevate your gaming experience and unlock a world of endless possibilities.


Nope
Test Plan
Related PRs

thanks 👍


NVDA steals keybindings for moving cursors

Environment Details:
VSCode Version : 1.24.0
OS Version : Win10
Additional Details:
MAS Violated: MAS 2.1.1
Repro Steps:

Launch VS Code.
Open VS Code Editor window.
Type some code within the editor and try commands for "Add Cursor Above/Below" and "Add Cursor To Line Ends".

Actual:
Keyboard shortcuts for :
"Add Cursor Above" - Ctrl + Alt + UpArrow
"Add Cursor Below" - Ctrl + Alt + DownArrow
"Add Cursor To Line Ends" - Shift + Alt + I
are not working in editor.
Expected:
Keyboard shortcuts should work for the above mentioned commands.
Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
User Impact:
User will not be able to use possible shortcuts listed in the application that might disrupt his working.
MAS Reference:
MAS 2.1.1 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={8492c4eb-c179-40ae-8777-cd044ed725a2}
Attachment For Reference:
A11y_VSCode_Editor_Keyboard_ShortcutsNotWorking.pptx
Does this issue occur when all extensions are disabled?: Yes

These keybindings are stolen by NVDA. A user can configure different keybindings for those actions.
There is nothing we can do here imho, but leaving to @alexandrudima to decide

No action for us here.


Would like an example showing full maps

Until we have embedded/composited video support (which I presume https://github.com/flutter/flutter/issues/2319 tracks) we should consider adding an example (possibly to @szakarias's new  flutter_view example?) of playing a full screen video with Flutter.
If this is straightforward to do, I think it could be a useful example for talking to potential flutter customers/partners.  If it's a ton of work (that would be concerning), but I'm happy to defer as we definitely have other very important fish to fry. :)

@lukef let us know if you have trouble using https://flutter.io/platform-channels/ to do this yourself. Currently setting to M3, happy to pull into M2 if needed.

Customer Lefty also asked about this.

We got yet another request in Gitter just now for an example showing bringing up a full-screen iOS/Android view from Flutter.

if it can help :) : https://pub.dartlang.org/packages/video_launcher

Thanks @rxlabz that works great!

Updating present bug to track an example showing maps.

Another request on Gitter (from @orette).

I did a sample android only for this
https://github.com/FaisalAbid/flutter-google-maps-activity

Thanks @FaisalAbid !!
I think we can close this now :)

@FaisalAbid's is Android-only, so I think we should still keep this open?  I also think @szakarias was looking at adding an example to flutter/flutter itself.

Ah, I wonder if @szakarias and @FaisalAbid could join forces? Ideally, we have one full-screen-maps plugin out there :)

I can do an iOS one easily and make it into a plug-in if you guys want!
On Fri, May 26, 2017, 11:34 AM Seth Ladd<EMAIL_ADDRESS>wrote:

Ah, I wonder if @szakarias https://github.com/szakarias and @FaisalAbid
https://github.com/faisalabid could join forces? Ideally, we have one
full-screen-maps plugin out there :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/8863#issuecomment-304314293,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPfBIStkAO8y4lq0p--7nZXSD0Pk944ks5r9vESgaJpZM4Mg787
.

--
Sent from my phone

Plugin FTW!
On Fri, May 26, 2017 at 9:14 AM, Faisal Abid<EMAIL_ADDRESS>wrote:

I can do an iOS one easily and make it into a plug-in if you guys want!
On Fri, May 26, 2017, 11:34 AM Seth Ladd<EMAIL_ADDRESS>wrote:

Ah, I wonder if @szakarias https://github.com/szakarias and
@FaisalAbid
https://github.com/faisalabid could join forces? Ideally, we have one
full-screen-maps plugin out there :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/8863#issuecomment-304314293,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPfBIStkAO8y4lq0p--
7nZXSD0Pk944ks5r9vESgaJpZM4Mg787>
.

--
Sent from my phone
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/8863#issuecomment-304324147,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAVZ2LIoaInnGC_ExdPjiJhqDKbmaJSks5r9vppgaJpZM4Mg787
.

You got it. Will do it!
On Fri, May 26, 2017, 12:15 PM Seth Ladd<EMAIL_ADDRESS>wrote:

Plugin FTW!
On Fri, May 26, 2017 at 9:14 AM, Faisal Abid<EMAIL_ADDRESS>wrote:

I can do an iOS one easily and make it into a plug-in if you guys want!
On Fri, May 26, 2017, 11:34 AM Seth Ladd<EMAIL_ADDRESS>wrote:

Ah, I wonder if @szakarias https://github.com/szakarias and
@FaisalAbid
https://github.com/faisalabid could join forces? Ideally, we have
one
full-screen-maps plugin out there :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/flutter/flutter/issues/8863#issuecomment-304314293
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAPfBIStkAO8y4lq0p--
7nZXSD0Pk944ks5r9vESgaJpZM4Mg787>
.

--
Sent from my phone
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/8863#issuecomment-304324147,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAAVZ2LIoaInnGC_ExdPjiJhqDKbmaJSks5r9vppgaJpZM4Mg787
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/8863#issuecomment-304324427,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPfBHY4RE4znYh0eZotwIQfmft-2CRfks5r9vqygaJpZM4Mg787
.

--
Sent from my phone

I have added an example to flutter/flutter showing how to bring up a full-screen platform view from Flutter, passing information in both directions. The example is both for iOS and Android. (Ideally this example should have been part of the existing flutter_view example, but for technical reasons this is not possible at the moment.)
@FaisalAbid  you can have a look and see if it's useful for you. Also, I would love to help out with the maps example if there is anything I can do.

Closing based on the last comment.


Make a migrations file to avoid using the command makemigrations

Make a migrations file in the app folder to avoid using makemigrations in the READme file.
Fixes for issue #147

@anshuldutt21  LGTM. Merging. Thanks!


Death in multiplayer causes crash

Crash log:
https://hastebin.com/uzogajakim.lua

Confirmed again by Kyblie on discord, same error message:
java.lang.NullPointerException
	at rh.SetEntityItemAsDroppedOnPlayerDeath(EntityItem.java:755)
	at sq.a(EntityPlayer.java:739)
	at so.m(InventoryPlayer.java:744)
	at sq.a(EntityPlayer.java:652)
	at ng.a(EntityLiving.java:2490)
	at sq.a(EntityPlayer.java:454)
	at bdk.a(NetClientHandler.java:903)
	at dn.a(SourceFile:31)
	at ci.b(SourceFile:350)
	at bdk.d(NetClientHandler.java:100)
	at bds.b(WorldClient.java:70)
	at net.minecraft.client.Minecraft.l(Minecraft.java:1878)
	at net.minecraft.client.Minecraft.K(Minecraft.java:850)
	at net.minecraft.client.Minecraft.run(Minecraft.java:773)
	at java.lang.Thread.run(Unknown Source)

Caused by: java.lang.NullPointerException: Cannot read field "worldServers" because the return value of "net.minecraft.server.MinecraftServer.getServer()" is null
in EntityItem.SetEntityItemAsDroppedOnPlayerDeath( EntityPlayer player )

I ran some test on an old build, and it doesn't seem to call this method clientside on old  methods, while it does in the newer versions

Found the difference to be in EntityPlayerMP. An added line has EntityLivingOnDeath(par1DamageSource); while older versions don't. disabling this stops the crash from happening

not sure what it's used for, potential (tested it) solution: put if (world.isRemote ) around it?

Fixed for next release. Thanks Hiracho :)


Documentation for Cursor data type wrong

It seems like the PositionOnly and Cursor constructor's descriptions are swapped.

Fixed, thanks!


research detection architectures implementation

I used this one. Very clean implementation.
https://github.com/kuangliu/pytorch-retinanet

@i008 thanks

done


IIF(fieldvalue contains "substring",0,1)

Hello ALASQL team,
This is probably an easy one but I cannot figure is out.
What is the code for something like: IIF(fieldvalue contains "substring",0,1)
Kind regards,
Mario

I tried this one which seems to work: IIF(fieldvalue LIKE "%substring%",0,1)
Thanks.


mako: 1.5 -> 1.6

Motivation for this change
https://github.com/emersion/mako/releases/tag/v1.6
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 129996 at bdf42f22 run on x86_64-linux 1

3 packages built successfully:

mako
python38Packages.loo-py
python39Packages.loo-py


Missing destination name id

I'm trying to get all rows from a table in a postgres database but I get the following error "Missing destination name id" even if the id exists on the model.
Can anyone help?
Thanks,

@mahaben can you share a code snippet to look at?

@mahaben check this https://github.com/jmoiron/sqlx/issues/234

I checked the issue #234 but it did not helped me.
Here's my code:
type MachinesModel struct {
ID          *int        json:"id" db:"ID"
EntityName  string      json:"entity_name" db:"ENTITY_NAME"
Description zero.String json:"description" db:"DESCRIPTION"
}
and my table is as following:
CREATE TABLE IF NOT EXISTS MACHINES (ID SERIAL PRIMARY KEY,ENTITY_NAME TEXT ,DESCRIPTION TEXT)
Here's my code to select all rows:
err := Db.Select(&models, "SELECT * from machines")
I'm getting "Missing destination name id".
Note that it works when I use the function "Db.Query" but I want to use Db.Select and I want to understand why it doesn't work.
The same code works with oracle, sqlite, mssql and mysql.
Thanks,

@mahaben By convention Postgres uses lower case identifiers unless they are quoted. My guess is Postgres has translated your DDL to:
create table machines
(
   id serial not null
   	constraint machines_pkey
   		primary key,
   entity_name text,
   description text
);

Postgres is case-sensitive so try updating your struct tags to lower case and give that a try:
type MachinesModel struct {
	ID          *int `json:"id" db:"id"`
	EntityName  string `json:"entity_name" db:"entity_name"`
	Description zero.String `json:"description" db:"description"`
}

https://www.postgresql.org/docs/current/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS

@jhngrant  Thank you for your reply. I understand but I have to keep them in upper case  because I have 100 models written in the same way...

Found the solution, now I'm using a new mapper:
db.Mapper = reflectx.NewMapperFunc("json", strings.ToLower)
Thanks @jhngrant  again for your help!

@mahaben my misunderstanding. In Postgres you'll have to recreate your table using quoted identifiers:
CREATE TABLE "MACHINES"
(
  "ID"          SERIAL NOT NULL
    CONSTRAINT machines_pkey
    PRIMARY KEY,
  "ENTITY_NAME" TEXT,
  "DESCRIPTION" TEXT
);

@jhngrant This might be a solution but I don't want to be obliged to use upper case when doing queries in psql cmd. I finally found a solution. I added the following statement when my database is "postgres" and it works perfectly
case "postgres":
		db, err = postgresOpen(dsn)
		db.Mapper = reflectx.NewMapperTagFunc("db",
			nil,
			func(s string) string {
				return strings.ToLower(s)
			},
		)

For anyone else who faces a similar issue, I came across something similar due to a really silly mistake on my end as well.
type user struct {
	ID        uuid.UUID `json:"id,omitempty", db:"id"` // notice the comma in the tags this screwed up everything.
}
``

I had added a silly comma somehow and it was just invisible to my eye for 1 whole day 🤯

Also hit this issue by using unexported struct identifiers. Silly mistake which seems obvious in retrospect.
 type Foo struct {
-    bar string `db:"bar"`
+    Bar string `db:"bar"`
 }

Facing this issue, if i have an underscore in my sql attribute name,
TokenHash string    json:"token_hash" sql:"token_hash"   -> is giving me an error "missing destination name token_hash"
whereas
TokenHash string    json:"tokenhash" sql:"tokenhash" -> is executing fine without any error.

Added Test Data for Zestril


Client Allocation Request for:  湖南星韵医疗美容有限公司

Client Allocation Questions
Core Information

Name:  湖南星韵医疗美容有限公司
Website / Social Media: https://mp.weixin.qq.com/mp/profile_ext?action=home&__biz=Mzg2MDYzNzA1Mw==&scene=124#wechat_redirect
Region: Greater China
DataCap Requested: 100TiB
Addresses to be Notarized: f3u3unadf654vezf62cd4jo6r7h6qpkx26g5amcdc3oe6rmpmk2nfosfd2kjkdhj4ndvr626gsm7fhpmt7gg2q
Notary Requested: steven004

@dhg1906807876 Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hey @dhg1906807876 , thanks for your request. Can you kindly add more information / context here on:

yourself/ your organization (with links to official website/social media/news mentions etc)
Your history working on IPFS/Filecoin (notable contributions to the community, type of engagement shown over time etc)
Use case: type/source/quantity/diversity/scarcity of the data you plan to store on Filecoin
Miners you intend to allocate DataCap with allocation proportion(with redundancy/location/specific requirement of storage miners), if you are working with a service provider to store your data to Filecoin network, please name the provider.
How could people retrieve the data you store in Filecoin Network, do you have a tool/app for it?
What's your next plan for the data you plan to store in Filecoin Network? For-profit or not?
Would you be OK in posting deal transactions here?

Thanks

Close due to no response.
@dhg1906807876 , please reopen it if you still need datacap, or submit a new one.


cherry-pick: Changes for v1.19.1

The key cherry pick is https://github.com/GoogleContainerTools/kpt-config-sync/pull/1372, which adds the githubapp authentication type for 1.19.1.
The other cherry picks are mostly refactors and test improvements. Cherry picking these should help:

address some test speed/stability issues
minimize future cherry pick conflicts associated with refactoring

/label tide/merge-method-rebase

Do we need to cherrypick all?
The following seems can be deleted without any merge conflicts:

Add profiling tests and watch filtering doc
[test: Add e2e tests to cover additional scenarios where external files are rendered (https://github.com/GoogleContainerTools/kpt-config-sync/pull/1393)
Update OWNERS_ALIASES
update clientgen to use helper script
chore: bump golangci-lint to 1.60.3

Do we need to cherrypick all?
The following seems can be deleted without any merge conflicts:

Add profiling tests and watch filtering doc
test: Add e2e tests to cover additional scenarios where external files are rendered
Update OWNERS_ALIASES
update clientgen to use helper script
chore: bump golangci-lint to 1.60.3

These changes are either low risk or create cherry pick conflicts if dropped. I opted to just fast forward to simplify current/future cherry pick conflicts.

Add profiling tests and watch filtering doc

This introduces some conflicts, because some of the subsequent changes touch the e2e tests (e.g. pauseDeploymentYAML).

test: Add e2e tests to cover additional scenarios where external files are rendered

This adds test coverage which should have been included in 1.19.0, so I think this cherry pick is warranted.

Update OWNERS_ALIASES

Can be omitted, but is a low risk change.

update clientgen to use helper script

Can be omitted.

chore: bump golangci-lint to 1.60.3

Can be omitted, but is a low risk change.


⚠ Thumbnails API Endpoint has degraded performance

In e2087ec, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 5092 ms

Resolved: Thumbnails API Endpoint performance has improved in 9717bb4 after 7 minutes.


Fix for Crash on devices without flash, Fix for play-services 9.0.0 so

[fix, flash disabled for devices without flash capability][play services 9.0.0]

is a bug fix
is for those who want to use this with firebase which requires playservices >= 9.*

This may no longer be relevant, but if you think it is, could you move your PR to https://github.com/bpappin/material-barcode-scanner


Add OBI:0002988 'duration of specimen collection'

#1296

This PR was dropping the new OBI:0002989, so I started a new PR. I'm closing this in favour of #1305


refactor(auto-api.ts): chatgpt o1 cleanup

What is it?

[ ] Feature / enhancement
[ ] Bug
[ ] Docs / tests
[ ] Other

Why is it needed?
•	Variable Renaming: Changed variable names like lol to capture and hacky to exportedApi for better readability.
•	Regex Enhancements: Updated regex patterns to be platform-independent by matching both / and \ using [\\/].
•	Edge Case Handling: Added checks to prevent accessing undefined variables when arrays may be empty.
•	Error Logging: Included error logging in the catch block of writeToDocs to output any errors during file writing.
•	Path Handling: Used path.resolve to handle file paths in a platform-independent way.
•	Comment Trimming: Trimmed comments to remove unnecessary whitespace.

Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have ran pnpm change and documented my changes
[ ] I have add necessary docs (if needed)
[ ] Added new tests to cover the fix / functionality

Took your comments into account. Thanks for the review 🙇♂ . I think the regex is good for windows. But if it's problematic feel free to re-change in another PR :)


fix: Migrate recovery_target_timeline to prevent restarting

In the pull request, we migrated settings from postgresql.auto.conf to override.conf. During this migration, we overlooked the recovery_target_timeline setting. As a result, the reloaded configuration file does not include recovery_target_timeline, leading to a PostgreSQL restart.
closes: #3221

/test limit=local ft=upgrade

/ok-to-merge


Support oraclejdk and openjdk 8 in CI

Ref #2570

Coverage remained the same at 16.247% when pulling 2a309d3f4203f5deb1c303f254f81af5a41ce1c5 on ci into 4da0f486b5fec3d31ae59f58e4bb66528477077d on master.


[BUG]: DatabaseErrorException: ERROR: column "due_date" is of type timestamp without time zone but expression is of type text; Hint: You will need to rewrite or cast the expression.

What version of drizzle-orm are you using?
0.30.9
What version of drizzle-kit are you using?
0.20.17
Describe the Bug
I'm using pg adapter and RDSDataClient
When inserting a new record with a timestamp column, the query fails with the error:
DatabaseErrorException: ERROR: column "due_date" is of type timestamp without time zone but expression is of type text; Hint: You will need to rewrite or cast the expression.
Here is my schema with the timestamp column type:

Here is where I'm trying to insert the record:

Expected behavior
I expect the record to be saved with a properly formatted timestamp and not throw an error.
Environment & setup
local

I've tried all permutations of the configuration, mode string, mode date, precision 3, with and without timezone, passing a date object and passing a string. Nothing seems to work.

Looks like it is a duplicate of this bug #2097

Looks like it is a duplicate of this bug #2097

I also think so, they are very much related. Possible also even #1934. Sadly both issues are already closed, so for now it's probably worth keeping this open for visibility. I'm also facing a lot of similar issues with the typings in AWS Data Api queries.
The issue seems to boil down to mergeQueries where the typings are set. Below is my proposed solution for it, which I also commented on the other issue.
Unfortunately, I'm lacking the ability to properly implement tests for this to create an PR here. It would be awesome if anyone of you could assist here.
function mergeQueries(queries: QueryWithTypings[]): QueryWithTypings {
	const result: QueryWithTypings = { sql: '', params: [] };
	for (const query of queries) {
		result.sql += query.sql;
		result.params.push(...query.params);
		if (query.typings?.length) {
			if (!result.typings) {
                                // setting an array of "none" for possible prior params
                                // without typing resolves the issue for me:
				result.typings = new Array(result.params.length - query.params.length).fill("none");
			}
			result.typings.push(...query.typings);
		}
	}
	return result;
}


Give templates access to request URL via pageConfig object

Type
🚑  Health
Value
Gives every template access to the requested URL (i.e. the path being rendered) via the pageConfig object. Useful for e.g. consistently passing the shareable URL along with Twitter card and Open Graph data.
Checklist
All

[x] PR labelled and assigned
[x] Any introduced code complexity has been flagged

I'd like to do some research into how this works with cache i.e. it depends on the request, so maybe config might be better?

@jamesgorrie can you explain what you mean a bit more? Or we can discuss when you're back in.


postgres nunique on table fails

In this example, es is a postgres table with the following dshape:
In [15]: es.f69185227fdf48b98f08fdf6382a974b.dshape
Out[15]:
dshape("""var * {
  asof_date: datetime,
  open: ?float64,
  high: ?float64,
  low: ?float64,
  close: ?float64,
  volume: ?float64,
  adjusted_close: ?float64
  }""")

Calling nunique on the table itself raises a programming error from psycopg2.
In [11]: es = bz.Data('postgresql://localhost/bz')
In [12]: es.f69185227fdf48b98f08fdf6382a974b.nunique()
...
ProgrammingError: (psycopg2.ProgrammingError) function nunique() does not exis
LINE 1: SELECT nunique() AS f69185227fdf48b98f08fdf6382a974b_nunique...
               ^
HINT:  No function matches the given name and argument types. You might need to add explicit type casts.
 [SQL: 'SELECT nunique() AS f69185227fdf48b98f08fdf6382a974b_nunique \nFROM f69185227fdf48b98f08fdf6382a974b']

I imagine it should issue nunique(*) or something; however, I am not sure yet where to make this change.

the sql expression would be
select count(*) from (select distinct * from table);

this can be done in blaze with

Okay; should this raise a NotImplementedError then or do you think that this should continue to bubble up the ProgrammingError?

I actually think this should work.

I've got an implementation in the pipeline

Awesome


FirestoreRecyclerAdapter: onBindViewHolder not called when item is changed AND moved

Describe your environment:

Android device: Emulator
Android OS version: Nougat
Google Play Services version: 11.7.43
FirebaseUI version: 3.1.0

Describe the problem:
I've written an adapter that extends the FirestoreRecyclerAdapter. My RecyclerView uses the adapter to display items. The adapter uses a query that is ordered by a boolean field named 'checkedIn'. The adapter also uses a custom parser that implements SnapshotParser. When I'm binding the data to my viewHolder, I use the value of checkedIn to set the background color of the item. I think everything that I'm doing is typical.
Here are the situations where I'm having trouble:
(1) When the value of checkedIn is changed on a document (for example: checkedIn goes from true to false), the FirestoreRecyclerAdapter 'hears' the change but treats it as a 'MOVE' instead of a both a 'MOVE' and a 'CHANGE'. The consequence of it being treated as only a 'MOVE' is that onBindViewHolder() never gets called and it never gets a chance to update the background color of the item. In the RecyclerView, the item does get moved. It's just the wrong color and contains the wrong data.
(2) The second situation relates to how the cache deals with moves that are also changes. If a MOVE ( with a CHANGE) comes through, the cache does not invalidate the old object in the cache. Consequently, the old cached object is passed to onBindViewHolder.
Expected Results:
I would expect onBindViewHolder to get called with the most current data whenever there is a change.
Relevant Code:
As a workaround on my local system, I've made the following changes:
For (1), I added a call to notifyItemChanged(newIndex) in the 'MOVED' case of FirestoreRecyclerAdapter.onChildChanged(). I placed it right after the existing call to  notifyItemMoved(oldIndex, newIndex);
For (2), I changed BaseObservableSnapshotArray.notifyOnChildChanged() to call mCachingParser.invalidate(snapshot) when the change type is MOVED. I realize that change undermines the effectiveness of the cache.
These two changes aren't ideal but they do resolve the problems I'm seeing. Could you recommend a better workaround or is this a bug?

Oops, that's an oversight on our part. I'm working on a fix right now.

This is fixed in version 3.1.1.

Thanks for taking care of this so quickly!


Adds 'spo file roleassignment remove' command. Closes #3693

Adds spo file roleassignment remove command. Closes https://github.com/pnp/cli-microsoft365/issues/3693

Thank you @nanddeepn,  we'll review it ASAP!

@pnp/cli-for-microsoft-365-maintainers 2nd review is always appreciated 😊

Merged manually, thank you! 👏


Change Battle Background

We need to update battle background to some img more related with a terrifying forest

Actually the battle background looks like:

This the img we are using is this:

@juandiegocv27 @RolandoDrRobot I need your review to select one or this backgrounds:

1:

2:

3:

4:

5:

@juandiegocv27 @RolandoDrRobot I need your review to select one or this backgrounds, remember the battle is inside a dark forest so the background should be relate to that

1:

2:

3:

I only like 2nd photo, because the 1st and 3rd are not capable to manage more than 1 beast in the zone, perhaps 2nd could work more for a time, but you could try to implement it mate, and show us the final result😎


Fixing error message placment

Signed-off-by: Mostafa Gamal<EMAIL_ADDRESS>Before, it would just exit without showing any message to the user if it encounters that error

A fix for the build issues has been implemented (https://github.com/hyperledger/indy-sdk/pull/2470).  Please rebase this PR on the latest from the main branch so it is no longer blocked by the related build issues.


Prevent certain scenes in stack from always being mounted?

Hey folks!
Question:
Is it possible to prevent certain scenes in the nav stack from always being mounted?
This question has been asked before, but was considered "closed" once V3 became obsolete; however, I'm still seeing this behavior without any viable solutions.
I've got a few scenes in a todo-like app. The hierarchy looks like:
Lists -> List Todos -> List Options.
On the List Options scene, you have the ability to delete the list. Upon doing so, I send you back to the Lists scene (which is 2 scenes back). However, the List Todos, being still mounted in the stack, tries to pull in props from the now non-existent list, and therefore throws errors.
This would not be the case if previous stack scenes became unmounted. I try to catch this error before the component is updated like so, but to no avail:
componentWillReceiveProps(nextProps) {         if (!nextProps.currentList) {             console.log('NO LIST');             Actions.pop();         }     }
I have been racking by brain over this the past few days. This behavior doesn't seem right, but the current RNRF framework doesn't allude to supporting anything like this. It would be very helpful.
On the other hand, I'm open to rethinking my code architecture if that is the issue. I am at a complete production standstill, so any advice is welcome. Thank you!
Versions:
"react-native": "0.45.1",
"react-native-router-flux": "^4.0.0-beta.17",

All screens in nav stack must be mounted, it is by design for any navigation. You really need to rethink your architecture. I'd just catch exception for non-exist ID (i.e. render empty screen) and do 'double' pop after item removing.

Another option is to 'reset' whole stack to Lists instead of Actions.pop usage.

Hey Pavel, thanks for your replies!
I do currently pop twice in an attempt to navigate back two screens after deleting the item. The code snippet I posted above should catch if the list exists or not (since that scene is still mounted before/after the deletion) but the component lifecycle still renders before pop() happens.
As for the reset - how would you recommend handling this? I have <Scene ...props type='reset' /> which does replace the screen without the transition animation, but throws the same errors I've been seeing immediately following.
As far as architecture, I'll probably rework it as you suggested. Instead of deleting the item immediately, I'll throw it into a queue and resolve the queue once I've reached the initial scene in the stack after pop()

As far as architecture, I'll probably rework it as you suggested. Instead of deleting the item immediately, I'll throw it into a queue and resolve the queue once I've reached the initial scene in the stack after pop()

Yes, it seems to be good idea - I think you could just try Actions.pop();Actions.pop();delete_item() or Actions.Lists({type:'reset'});delete_item()

Sounds good. Alternatively, I've begun to check if certain props exist in shouldComponentUpdate.  Thank you for your help!


W-8603843 - Fix Date disappears from Create Disbursement wizard on edit

Fix bug regarding scheduled dates disappearing on Edit in the Create Disbursements modal.
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata
Definition of Done
Refer to Definition of Done to see any additional details for the items below:

[ ] ~Any net new LWC work has JEST test coverage 50% or above~
[ ] ~Default Sa11y tests pass for all LWC components~
[ ] ~🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary~
[ ] ~🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary~
[x] Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
[x] Make sure that ACs are updated (if any gaps)
[ ] All acceptance criteria have been met

[x] Developer
[ ] Code Reviewer

[ ] Pull Request contains draft release notes
[ ] Labels, help text, and customer facing messages are reviewed by Docs
[ ] QE story level testing completed

W-8603843: CCE/Outbound Funds - Date disappears from Create Disbursement wizard when attempting to edit

@sella24 In the work item there's a note to try to rebuild this table component in LWC, were you able to consider that option?

@seanpat09 :  I added a datatableWrapper.lwc that displays the disbursements and sends back any inline edit to the aura component.
The save/cancel operations are still handled by the aura component.


A map become blank when an app resume.

Hi,
I tried your TileView v2.0.0 demo app.
When I start "Real Map", Everything is fine.
But if I pause and resume it, the map become blank like attached image.
Then I do action like scroll, the map become fine.

How can I redraw as soon as resuming?
Thanks.

Probably needs an invalidate - I'll check it out.

Actually was a little more complicated than that, and I needed to force the tile computation to recalculate on a resume - it's fixed now and available in the current version 2.0.1, both on gradle and pushed here.
thanks for catching that and posting

I tried v2.0.1 and it was fixed.
Thanks.

The issue is still present in the latest version 2.1.1.
I have tested it on multiple devices with Android versions from 4.2 to 6.0 and with your sample app.

Weird. I don't have this issue. Which version of Android are you using?

actually i am seeing it too, not on orientation change, but if you put the device to sleep then wake it up.  i'll work on a fix

fixed in 2.1.2 (available now)

Can confirm it's fixed. Thanks!

thanks for letting us know about the issue and the fix confirmation


Add Dispersion Index to sample notebook in analysis

This PR adds index of dispersion to the sample notebook in /analysis/notebooks/BuzzBlogExperimentAnalysis.ipynb.
The source code for the estimation algorithm is at analysis/notebooks/dispersion_index along with a test script.
I've tested the notebook by running an experiment and also with the sample experiment in docs/sample/BuzzBlogBenchmark_2021-03-08-01-12-30. Both yielded close dispersion index of ~3.8, with sampling resolution set to 60ms and convergence tolerance of 0.025.

@rodrigoalveslima You can consider using black formatter to format notebooks. (https://black.readthedocs.io/en/stable/editor_integration.html#jupyter-notebook-magic, https://github.com/dnanhkhoa/nb_black)


Event Loop 2.0 API and Windows implementation

Changes winit's API as discussed in #459 and implements said changes on Windows.
This PR does not provide implementations for the new API on any non-Windows platform. Said platforms have not been tested, and there should be no expectations that they even compile. However, it does provide a working version of the API on Windows as well as API docs.
Before this is merged, we should thoroughly review the code changes and make sure all the documentation is correct/includes working links.
Changelog entry is included below for convenience and potential further discussion:

Change all occurrences of EventsLoop to EventLoop.
Previously flat API is now exposed through event, event_loop, monitor, and window modules.
os module changes:

Renamed to platform.
All traits now have platform-specific suffixes.
Exposes new desktop module on Windows, Mac, and Linux.

Changes to event loop types:

EventLoopProxy::wakeup has been removed in favor of send_event.
Major: New run method drives winit event loop.

Returns ! to ensure API behaves identically across all supported platforms.

This allows emscripten implementation to work without lying about the API.

ControlFlow's variants have been replaced with Wait, WaitUntil(Instant), Poll, and Exit.

Is read after EventsCleared is processed.
Wait waits until new events are available.
WaitUntil waits until either new events are available or the provided time has been reached.
Poll instantly resumes the event loop.
Exit aborts the event loop.

Takes a closure that implements 'static + FnMut(Event<T>, &EventLoop<T>, &mut ControlFlow).

&EventLoop<T> is provided to allow new Windows to be created.

Major: platform::desktop module exposes EventLoopExtDesktop trait with run_return method.

Behaves identically to run, but returns control flow to the calling context can take non-'static closures.

EventLoop's poll_events and run_forever methods have been removed in favor of run and run_return.

Changes to events:

Remove Event::Awakened in favor of Event::UserEvent(T).

Can be sent with EventLoopProxy::send_event.

Rename WindowEvent::Refresh to WindowEvent::RedrawRequested.

RedrawRequested can be sent by the user with the Window::request_redraw method.

EventLoop, EventLoopProxy, and Event are now generic over T, for use in UserEvent.
Major: Add NewEvents(StartCause), EventsCleared, and LoopDestroyed variants to Event.

NewEvents is emitted when new events are ready to be processed by event loop.

StartCause describes why new events are available, with ResumeTimeReached, Poll, WaitCancelled, and Init (sent once at start of loop).

EventsCleared is emitted when all available events have been processed.

Can be used to perform logic that depends on all events being processed (e.g. an iteration of a game loop).

LoopDestroyed is emitted when the run or run_return method is about to exit.

Rename MonitorId to MonitorHandle.

Who would be up for reviewing the changes made here? I don't have a good idea of who has access to a Windows machine, and I'd rather this didn't wait around in the backlog forever.

Hello, I've tried some experiments with this branch, and run into an issue where I get a panic if I try to spawn a win32 context menu on handling a right-click event using the TrackPopupMenuEx winapi function.
It's something to do with the context menu creating its own modal run loop I think, and then the panic occurs within SubclassInput::send_event when it tries to mutably borrow an already borrowed value.
It's pretty easy to replicate, but let me know if you'd like a code snippet.  I also note that this is already a great improvement to the current master winit event loop on win32 which has the second thread; since TrackPopupMenuEx needs to be called on the thread owning the Window, it just silently fails to create the context menu, and would require some inter-thread message passing shenanigans to work at all.  Overall I find the API design of this branch much nicer for my use-cases.
Cheers

@hardiesoft Thanks! The reason that's happening is because, as you said, TrackPopupMenuEx tries to send its own events. That would call into the event loop closure that called TrackPopupMenuEx, violating Rust's aliasing rules and causing undefined behavior, but the implementation has a RefCell that triggers the panic when we attempt to borrow it mutably twice.
The best way I can think of to solve this without changing the API would be to buffer up events if new events are generating during the closure then send them all off when the closure returns, although that would pause user event processing while the TrackPopupMenuEx function is being called.
It may also be worth adding a function to EventLoop that lets you buffer up a series of functions to be called after the event closure returns. With that API, you could do something like this:
let event_loop = EventLoop::new();
let window = WindowBuilder::new()
    .with_title("A fantastic window!")
    .build(&event_loop)
    .unwrap();

event_loop.run(move |event, event_loop, control_flow| {
    match event {
        Event::WindowEvent {
            event: WindowEvent::CloseRequested,
            ..
        } => *control_flow = ControlFlow::Exit,
        Event::WindowEvent {
            event: WindowEvent::MouseInput {
                state: winit::event::ElementState::Released,
                button: winit::event::MouseButton::Right,
                ..
            },
            ..
        } => {
            event_loop.queue_function(|| unsafe {
                use std::ptr;
                use winapi::um::winuser::{self, *};

                let menu = winuser::CreatePopupMenu();
                winuser::InsertMenuA(menu, 0, MF_BYPOSITION | MF_STRING, 0, "Hello\0".as_ptr() as _);
                winuser::TrackPopupMenuEx(
                    menu,
                    0,
                    512,
                    512,
                    window.get_hwnd() as _,
                    ptr::null_mut()
                );
                winuser::DestroyMenu(menu);
            });
        }
        _ => *control_flow = ControlFlow::Wait,
    }
});

And winit would call the popup-creation method after the main event loop closure returns, allowing user event processing to continue while TrackPopupMenuEx runs its own loop.

Hi @Osspial I do like your idea of queuing a function to be run after the main loop closure; for full flexibility ideally I don't want to stop other user event processing while a context menu (or OS file dialog etc) is open.  The main issue I see here is just one of documenting this properly if this is the direction you decide to go in - perhaps providing an example that addresses this use-case?  Would the proposed API be useful outside of Windows, or would it essentially be a platform specific thing to work around this issue?
If you decide it's not worth the specialised API to handle this I'd be okay with it just buffering the events (or even throwing them away) and blocking.  If I care about things like animations continuing to run in my window I'd probably have my render loop off the main thread, and I generally don't expect to receive input to my window while a context menu or other OS UI element has focus.  IIRC, macos will just block the calling thread in this case too, so it's sort of a lowest common denominator behaviour.

@hardiesoft Thanks! The reason that's happening is because, as you said, TrackPopupMenuEx tries to send its own events. That would call into the event loop closure that called TrackPopupMenuEx, violating Rust's aliasing rules and causing undefined behavior, but the implementation has a RefCell that triggers the panic when we attempt to borrow it mutably twice.

This model doesn't seem to be compatible with SendMessage, which has legitimate uses. Is there any way we can make event handlers reentrant?

@caitp The only way I can think of doing that would be to make the run functions take a Fn instead of a FnMut, but that carries API limitations that clearly aren't practical for any reasonable application.

How is continuous rendering meant to be handled with the new API? I'm trying to do my rendering in response to WindowEvent::RedrawRequested. I then call Window::request_redraw() after rendering in order to get schedule the next render. This doesn't seem to actually work though. If I instead put the redraw request in response to Event::EventsCleared, rendering only happens continuously whilst other events are firing (e.g. mouse movement). If I put the call in response to both RedrawRequested and EventsCleared, rendering is continuous, but the window is unresponsive.

I've also managed to get winit to hit unreachable code inside EventLoopRunner::process_event.

I just ran all of the examples, and tried to break them in order to provide some useful feedback. This is what I have discovered.
Errors in examples:

cursor_grab - pressing H a bunch of times causes the window to become unresponsive.
handling_close - doesn't seem to work anymore when attempting to enter Y in the terminal.
fullscreen - becomes unresponsive after entering fullscreen.

The other examples seemed to work correctly. I'm excited to see this PR progress! 🎉

Using a proxy in combination with Poll seems to cause that unreachable code to be hit as well.

@dylanede @JohnDoneth
Thanks for the reports! I've pushed fixes that seem to fix all of those issues. I haven't tested the Poll/EventLoopProxy crash, but that should have been fixed as well.

I also still hit that unreachable code, but only in --release mode.

@Osspial I think the problem I mentioned with Poll and proxies is in fact just the issue @hardiesoft has reported above, since it only happened in release mode and I have not boiled it down yet.

@hardiesoft Your example should be fixed in the latest commit. @dylanede, can you run your Poll code again and see if that crashes?

@hardiesoft well done! That's stopped the crashes for me.

What is the status of this? Can it be merged into eventloop-2.0 to bootstrap the implementation of the other platforms?

@vberger AFAIK the main thing this is waiting on is a review of the code. @francesca64 volunteered to do it, but it doesn't seem like she's found the time to make that happen.

Ping  @francesca64

The API this exposes is pretty stable, and it's taking a while time to get a code review done. If a review can't happen soonish I think it may make sense to merge this as-is so that people can start working on implementations for other platforms, then do a review later as required.

@mtak- I wrote up an answer to that in the API change thread, but it's been buried pretty thoroughly (I couldn't even find it at first) so I can't blame you for not finding it 😄! Regardless, I've pasted that here.

Why do this? With the return-based solution, there are cases where there are several "correct" ways to handle control flow. Consider the following event loop:
event_loop.run(|event| {
    match event {
        Event::LoopEnd => ControlFlow::Poll,
        _ => ControlFlow::Wait
    }
});

That situation leads to return patterns like Wait, Wait, Wait, {...}, Poll. What do you do with the Waits that are returned before the Poll? You could take that as "halt the event loop between each call to the function", which is pretty clearly nonsense. However, it's the only solution that doesn't involve throwing away values. Other solutions could be to have some sort of "control flow precedence pattern" where returning one type overrides future returns of another type, or to ignore all of the return values except for the one from LoopEnd (in which case what's the point of having it return anyway!).
As a persistent parameter, there are no values we have to ignore and it's clear when the control flow of the loop actually changes. Under this, Wait, WaitTimeout, and Poll would only impact control flow when all of a loop's events have been cleared, and Break would essentially kill the loop immediately (barring destruction events).

I really need to make a post summarizing all the rationale discussion from that thread...
Also @francesca64, I've been rebasing this onto master and have gotten to a point where, to include the new windows drop handler implementation, it looks I need to use crossbeam_channel's select macro to get FileDropHandlerData's event sending working. However, that has a minimum Rust version of 1.26. How should we handle that?

Ooops! Burned again by the Hidden Items while cmd+f'ing. Thanks that makes a lot of sense! I've started on an iOS implementation.

@mtak- Thanks for working on that! I just rebased this PR onto master, so you may want to update to the new code before you get too far into your implementation.

I'm ok with merging this as it is now, so that other platforms can start working on the API.

When testing on Windows 10, I've noticed that set_decorations causes the window to freeze. with_decorations works fine, though. This can be reproduced in the fullscreen example app by pressing D.

@francesca64 Thanks! That should be fixed now.

Okay, I have a wayland implementation that compiles. Do we stick to the initial plan, and I make a PR for it to the eventloop-2.0 branch, once this is merged?

@vberger That sounds good.
Also, I just went though the code and fixed some places where freezes happened after setting window state, so those issues should be resolved going forward. Let me know if anyone runs into another one.

While the fix worked, many methods still don't work correctly if called from another thread:
extern crate winit;

fn main() {
    let event_loop = winit::event_loop::EventLoop::new();
    let window = winit::window::WindowBuilder::new()
        .with_dimensions((400, 300).into())
        .build(&event_loop)
        .unwrap();
    let (tx, rx) = std::sync::mpsc::channel();
    std::thread::spawn(move || {
        loop {
            match rx.try_recv() {
                Ok(event) => match event {
                    winit::event::WindowEvent::CloseRequested => break,
                    winit::event::WindowEvent::KeyboardInput { input: winit::event::KeyboardInput {
                        state: winit::event::ElementState::Pressed,
                        virtual_keycode: Some(key),
                        modifiers,
                        ..
                    }, .. } => {
                        use winit::event::VirtualKeyCode::*;
                        match key {
                            Escape => break,
                            // These do nothing
                            F => {
                                let monitor = match modifiers.shift {
                                    true => None,
                                    false => Some(window.get_current_monitor()),
                                };
                                window.set_fullscreen(monitor);
                            },
                            M => window.set_maximized(!modifiers.shift),
                            D => window.set_decorations(!modifiers.shift),
                            A => window.set_always_on_top(!modifiers.shift),
                            // These freeze (i.e. the close button/escape won't work)
                            G => window.grab_cursor(!modifiers.shift).unwrap(),
                            H => window.hide_cursor(!modifiers.shift),
                            _ => (),
                        }
                    },
                    _ => (),
                },
                Err(_) => (),
            }
        }
        drop(window);
    });
    event_loop.run(move |event, _, control_flow| {
        *control_flow = winit::event_loop::ControlFlow::Wait;
        match event {
            winit::event::Event::WindowEvent { event, .. } => {
                if let winit::event::WindowEvent::Destroyed = event {
                    *control_flow = winit::event_loop::ControlFlow::Exit;
                } else {
                    let _ = tx.send(event);
                }
            },
            _ => (),
        }
    })
}

Also, entering/exiting fullscreen no longer generates a Resized event.

@francesca64 Both of those issues should be fixed now.

I found a pretty niche regression. When I use screen sharing in Discord, winit programs will panic as soon as I try to select an application window:
thread 'main' panicked at 'already borrowed: BorrowMutError', libcore\result.rs:945:5
stack backtrace:
   0: std::sys::windows::backtrace::unwind_backtrace
             at C:\projects\rust\src\libstd\sys\windows\backtrace\mod.rs:65
   1: std::sys_common::backtrace::_print
             at C:\projects\rust\src\libstd\sys_common\backtrace.rs:71
   2: std::sys_common::backtrace::print
             at C:\projects\rust\src\libstd\sys_common\backtrace.rs:59
   3: std::panicking::default_hook::{{closure}}
             at C:\projects\rust\src\libstd\panicking.rs:211
   4: std::panicking::default_hook
             at C:\projects\rust\src\libstd\panicking.rs:227
   5: std::panicking::rust_panic_with_hook
             at C:\projects\rust\src\libstd\panicking.rs:511
   6: std::panicking::continue_panic_fmt
             at C:\projects\rust\src\libstd\panicking.rs:426
   7: std::panicking::rust_begin_panic
             at C:\projects\rust\src\libstd\panicking.rs:337
   8: core::panicking::panic_fmt
             at C:\projects\rust\src\libcore\panicking.rs:92
   9: core::result::unwrap_failed<core::cell::BorrowMutError>
             at C:\projects\rust\src\libcore\macros.rs:26
  10: core::result::Result<core::cell::RefMut<core::option::Option<winit::platform_impl::platform::event_loop::EventLoopRunner<()>>>, core::cell::BorrowMutError>::expect<core::cell::RefMut<core::option::Option<winit::platform_impl::platform::event_loop::EventLoopRunner<()>>>,core::cell::BorrowMutError>
             at C:\projects\rust\src\libcore\result.rs:809
  11: core::cell::RefCell<core::option::Option<winit::platform_impl::platform::event_loop::EventLoopRunner<()>>>::borrow_mut<core::option::Option<winit::platform_impl::platform::event_loop::EventLoopRunner<()>>>
             at C:\projects\rust\src\libcore\cell.rs:826
  12: winit::platform_impl::platform::event_loop::public_window_callback<()>
             at .\src\platform_impl\windows\event_loop.rs:880
  13: DefSubclassProc
  14: DefSubclassProc
  15: CallWindowProcW
  16: CallWindowProcW
  17: IsWindowVisible
  18: KiUserCallbackDispatcher
  19: NtUserGetMessage
  20: GetMessageW
  21: winit::platform_impl::platform::event_loop::EventLoop<()>::run_return<(),closure>
             at .\src\platform_impl\windows\event_loop.rs:245
  22: winit::platform_impl::platform::event_loop::EventLoop<()>::run<(),closure>
             at .\src\platform_impl\windows\event_loop.rs:190
  23: winit::event_loop::EventLoop<()>::run<(),closure>
             at .\src\event_loop.rs:145
  24: window::main
             at .\examples\window.rs:14
  25: std::rt::lang_start::{{closure}}<()>
             at C:\projects\rust\src\libstd\rt.rs:74
  26: std::rt::lang_start_internal::{{closure}}
             at C:\projects\rust\src\libstd\rt.rs:59
  27: std::panicking::try::do_call<closure,i32>
             at C:\projects\rust\src\libstd\panicking.rs:310
  28: panic_unwind::__rust_maybe_catch_panic
             at C:\projects\rust\src\libpanic_unwind\lib.rs:105
  29: std::panicking::try
             at C:\projects\rust\src\libstd\panicking.rs:289
  30: std::panic::catch_unwind
             at C:\projects\rust\src\libstd\panic.rs:392
  31: std::rt::lang_start_internal
             at C:\projects\rust\src\libstd\rt.rs:58
  32: std::rt::lang_start<()>
             at C:\projects\rust\src\libstd\rt.rs:74
  33: main
  34: invoke_main
             at f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:78
  35: __scrt_common_main_seh
             at f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:288
  36: BaseThreadInitThunk
  37: RtlUserThreadStart
error: process didn't exit successfully: `target\debug\examples\window.exe` (exit code:<PHONE_NUMBER>)

This doesn't happen on master, and can be reproduced with the window example.

@francesca64 That too works now.

iOS is ready. Just waiting on a merge.

I've been working on a macOS implementation, and it's just about complete.
@Osspial I realize in retrospect that rebasing could be a pain, especially since more things will continue to change on master... feel free to just force-push that branch back (which I think you can do now?) if you'd rather merge as-is. Alternatively, we could work towards one last pre-EV2 and then freeze master and rebase everything.

@francesca64 Thanks for reviewing this! Sorry it took so long to respond to those - for some reason I didn't see that you posted the review.
Anyhow, we've got a lot of unreleased changes, so I think it's a good idea to go through any recent PRs that aren't much effort to merge, merge those, then freeze master and get ready to release this.

@francesca64 It's... been a while. Any status updates on the X11 and MacOS backends? From what you said it sounded like they were pretty much ready to go, but it's been over a month since we've heard anything about it.
If those two are ready, I'm tempted to go ahead and release what we have (Windows, MacOS, X11/Wayland, and iOS). Emscripten is already broken anyway (notwithstanding @iceiix's work in #760 and #767), and I don't want to hold up everyone else for Android support - that can be patched in in a future update, when you have time to work on it.

Also, this is now merged against the latest master! It was a whole lot less of a PITA than rebasing, but it still takes time so I don't want to do that sort of thing yet again. (pro tip: if you've got a massive PR like this use git merge not git rebase if you enjoy having time to do other things)

Is there anything blocking the merge of this in the eventloop-2.0 branch right now, so we can setup the other PRs to it and hopefully merge the whole thing to master when it is ready?
Or has this part of the initial plan been completely dropped?

@Osspial

From what you said it sounded like they were pretty much ready to go

macOS is indeed complete (aside from some minor correctness issues that I know how to fix but haven't gotten around to yet), but I haven't done any work on X11 aside from the rough one I did during the API discussion. An X11 implementation should be easy, though.

I don't want to hold up everyone else for Android support - that can be patched in in a future update, when you have time to work on it.

That's reasonable. I'll definitely be handling the Android implementation, but it's not the priority right now.

Emscripten is already broken anyway

I'm honestly not sure how many people will want to use/maintain Emscripten after #589 anyway, so I'm fine with this too.

Just want to say: I’m delighted with this, because my Win32 EdgeHTML experimentation (Windows.Web.UI.Interop.WebViewControl, which incidentally requires a single-threaded apartment) had not been working, in a very opaque manner, and I finally today tried minimising and translating a known-good C++ implementation, and that worked; the key difference then was the use of winit, which I had erroneously thought a completely harmless component. I began to get suspicious of its event loop implementation (though I still don’t have any sort of grasp on why it makes an IAsyncOperation seem to be working but never complete, even when polling on the original thread). So I came to the issue tracker, and found recent discussion about all this and this very-recently-merged work; and guess what? It all works now. So with this work I will finally be able to resume work on a good web view control (MSHTML is disqualified from that classification, naturally).
So: thanks for sorting this out!

I just realized that, instead of aborting the entire process at the end of run, we could potentially use libunwind to unwind the stack. I just tested out building and I wasn't able to get libunwind compiling on Windows MSVC (so we'd have to sort that out), but it's a potential avenue forwards for allowing execution of run on non-main threads.

@francesca64 Do you have any sort of timeline for when you think the MacOS and X11 backends will be done by? I really don't want to be pushy, but these changes have been in progress for the better part of a year I'd like to move on from this. There's a bunch of stuff I'd like to make, both within Winit and without, that are either waiting on this to get going or would be significantly improved from having these overhauls on crates.io. I'm tired of having to choose between either writing Winit stuff that will make EL2.0 harder to merge, or writing stuff against the EL2.0 branch and not knowing when that code will see the light of day.

If there have been any personal or work issues that have made it hard to work on this, that's okay. Stuff happens. But (and I'll admit that I absolutely need to get better on this too) going radio silent doesn't really work.

@Osspial I'm not interested in working on an X11 implementation at this time. As for macOS, that's something I have to coordinate with @mtak- (going forward, macOS and iOS will likely have shared components), though there shouldn't be much left that needs to be done.

I may be able to work on the x11 migration, with two caveats:

It'll be a lot of I-have-no-idea-what-Im-doing.gif
It won't be before two weeks

So if someone feels more competent and/or has more time, don't hesitate. :)

winit Events Loop 2.0 with wasm32-unknown-unknown seems relevant to the requestAnimationFrame discussion in https://github.com/rustwasm/gloo/issues/1 if anyone has any ideas to contribute there.

@francesca64 If you don't have the time to finish the macOS implementation up, could you post a link to your current work and whatever remaining issues it has so that someone else could potentially pick it up and finish it?

For the record, I'm in the process of porting the X11 backend to eventloop 2.0.
I'm finished with the "fixing imports and moving stuff around" part, and I'm down to the hard part: implementing run, run_return and request_redraw.

I intend to port the MacOS via to use of cargo check --target x86_64-apple-darwin, and if I can get a VM to work, some minimal testing. Probably will take 2-3 weeks and will be not tested to actually be functional - only to compile.

@ZeGentzy I have a Mac but not much time on my hands right now, but if you ping me during development I'll be able to build and run your branch within a day or two.

@ZeGentzy I finally managed to find @francesca64's WIP implementation! This branch should provide a good start: https://github.com/francesca64/winit/tree/macos-ev2

Is there a reason for why extension traits were renamed to include the name of the operating system? This isn't usually the standard convention (and feels awkward imo) so I'm curious as to the reasoning for this.


GPULightmapper: do not smoothen position

Smoothen position caused positions to move outside their triangle which caused
side-effects as rays from those positions intersected with triangles which
could not be reached from the original triangle.

This PR fixes the artifact of strange blob that was mentioned in #51638.

After removing the smoothening of positions:

@JFonS, do you know the situation this smoothening was needed, or do you have a scene that needed it, as I may have broken that case and like to look into it so can fix it (maybe in another way without this side-effect). Thanks.

If this section of code is causing artifacts then there's probably something wrong with it, but ideally we should try to keep it.
I did not write the original implementation of the GPU lightmapper, I just worked on some fixes and improvements, but I'm pretty sure this section is here to improve shadow termination. The same article is referenced somewhere in this file, but I believe this section is what Juan referenced while working on this feature. It has a good explanation of the problem and the solution we are (in theory, at least) implementing.

Thanks @JFonS for the reference. I will investigate:

if there is an issue with the implementation (or if this a known side-effect)
the reference and determine if we could implement it without side-effects (if 1. seems to be correct)

I propose not to merge this PR till the investigation is concluded.

This PR is replaced by #53322 is the solution of this PR is incorrect.


[ISV-1484] Add signing tasks to release pipeline

@wcheang I just realized that this PR needs to be released in sync with Radas changes and community certification changes. So please don't merge it now. We got a confirmation from community folks that they will be able to test preprod signing pipeline next week and then we have to synchronize the production release of all components including this PR.


make pip installable again

originally removed from https://github.com/adelenelai/classify_homologues/commit/816b28fc64073cb59421b48a9455b68e293147d4

Achieved with commits:
https://github.com/adelenelai/classify_homologues/commit/aaf2e9addbea7e56e39b8b55d5b59892231daf69
https://github.com/adelenelai/classify_homologues/commit/16947ae3b8b1cc28a017dd328ed7c9c391e9add7
https://github.com/adelenelai/classify_homologues/commit/ba9509d136d649030c8258e3436569ec216fe4a3
https://github.com/adelenelai/classify_homologues/commit/772207c1e847f8b64e3742384f9d2803fb64c9a2


Assignment

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

created and copied new files and directories

What did you learn from the changes you have made?

copying and moving directories and files

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

multiple options to move between directories, I tried various options.

How were these changes tested?

pasted some into the terminal.

A reference to a related issue in your repository (if applicable)
-n/a
Checklist

[x] I can confirm that my changes are working as intended

@drdhennessy
Please make sure that you have completed part 2 of the assignment (which is mentioned in the assignment_instruction file).
And please keep your PR open for review.

You are almost done Dean! You just have to finish Part 2 of assignment


[Backport] [1.2] [FEATURE] Add OPENSEARCH_JAVA_HOME env to override JAVA_HOME (#2040)

Signed-off-by: Andriy Redko<EMAIL_ADDRESS>Description
Backport of https://github.com/opensearch-project/OpenSearch/pull/2040 to 1.2
Issues Resolved
Closes https://github.com/opensearch-project/OpenSearch/issues/1872
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock @andrross no objections from your side guys to bring it into 1.2? thanks!

I would think this change doesn't meet the definition of "hotfix" defined in the release policy. Do you have a particular reason for wanting to backport this to the 1.2 branch?

I would think this change doesn't meet the definition of "hotfix" defined in the release policy. Do you have a particular reason for wanting to backport this to the 1.2 branch?

Thanks @andrross  I don't have the compelling  reasons for 1.2 (besides matching the original documentation section), no objections to close this backport, @dblock sounds good to you?

Agreed, let's close. Shipping this in 1.3.0 (1.x branch) is good.


Missing constants/ dir

Hey,
I tried compiling the app but it's missing the constants directory which should be in the core directory.

I have mentioned in the Readme that you have to add it to run the application. I haven't pushed it as it has credentials, but let me push one with mock data. thank you.


scan is broken

Probably have to do with encryption
[1] basicRAT> scan <IP_ADDRESS>
Running scan...
[1] REI> Exception in thread Thread-1:
Traceback (most recent call last):
File "C:\Python27\Lib\threading.py", line 530, in __bootstrap_inner
self.run()
File "C:\Users\someone\Desktop\rei_Rat\basicRAT_server.py", line 75, in run
client = ClientConnection(conn, addr, uid=client_id)
File "C:\Users\someone\Desktop\rei_Rat\core\common.py", line 19, in init
self.dh_key = crypto.diffiehellman(self.conn)
File "C:\Users\someone\Desktop\rei_Rat\core\crypto.py", line 43, in diffiehellman
b = bytes_to_long(sock.recv(256))
error: [Errno 10053] An established connection was aborted by the software in your host machine

Is this a persistent problem? has it happened multiple times? Its working on the master branch for us. did you change anything?

Closing this issue as it is not an issue with the current master branch. Looks like your own edits to the project produced this error.


Header-component

Create a header component with nav menus

[x] Create Header with Menu Items
[x] Update Header theme and active color on menu items
[ ] Align Menu Items to Center.
[ ] Update Logo section margin and alignments


Un-nest the  example

Nesting  within  would be very unusual.  The point of this page is to demonstrate commonly used styles.
In some cases the nesting causes the individual "keys" to lose their distinction.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/kbd#usage_notes
It's perfectly normal use:

You can also create a new document using the keyboard shortcut
Ctrl+N.

agree with @davidsneighbour - I approved the PR, but then took a look at it and decided to 'unapprove' it.
In this context it looks correct:

I appreciate the Mozilla docs. I had not seen those semantics before.
However, how many Hugo themes include style rules to render nested  correctly?  I think I've only seen one.
The point of this page is to demonstrate common styles.  Would you argue that nested  is more common than un-nested?  If it's a quibble, how about we just include examples of both?


registry: use const for status code 429

Now Docker is built with go1.6 /cc @aaronlehmann
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

[Current coverage][cc-pull] is 55.03%

Merging [#1772][cc-pull] into [master][cc-base-branch] will decrease coverage by 6.58%

4 files (not in diff) in ...istry/storage/driver were modified. more

Misses +807
Partials -92
Hits -716

9 files (not in diff) in registry/storage were modified. more

Misses +19
Partials +9
Hits +54

4 files (not in diff) in registry/handlers were modified. more

Misses -3
Partials +2
Hits -5

1 files (not in diff) in registry were modified. more

Misses +6
Hits -6

File ...ion/configuration.go (not in diff) was modified. more
File manifests.go (not in diff) was modified. more
File .../schema1/manifest.go (not in diff) was modified. more

Misses 0
Partials -1
Hits +1

File ...ge/signaturestore.go (not in diff) was created. more

@@             master      #1772   diff @@
==========================================
  Files           120        121     +1
  Lines         10455      10605   +150
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           6442       5836   -606
- Misses         3418       4256   +838
+ Partials        595        513    -82

[][cc-pull]

Powered by Codecov. Last updated by [feddf6c...4901f1b][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/distribution/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/distribution/compare/feddf6cd4e439577ab270d8e3ba63a5d7c5c0d55...4901f1b2781c5de0d06a18a3990bf091bcd4f081
[cc-pull]: https://codecov.io/gh/docker/distribution/pull/1772?src=pr

LGTM

LGTM


Wrapper commands for native AutoMod

This PR introduces wrapper commands for server staff to manage the discord native AutoMod configuration.
Breaking changes:

Introduces two new config variables to store the ID of the automod rules

Just an observation: When I manually attempted to add an AutoMod rule, and I didn't have permission to send messages in the logging channel, the rule would fail to update and claim that I was missing permissions.


RUMM-1376 Fix nightly test for setBundleWithTraceEnabled() API

What does this PR do?
It fixes the API used in logs_logger_builder_bundle_with_trace_enabled to the correct one.
Additional Notes
This wasn't reported by "[RUM] [Android] Nightly - logs_logger_builder_bundle_with_trace_enabled: number of logs is below expected value" monitor because it's query is not strict enough:
logs("service:com.datadog.android.nightly @test_method_name:logs_logger_builder_bundle_with_trace_enabled").index("*").rollup("count").last("1d") < 1

As far as I see, we can't access span_id and trace_id in logs, so I don't know how this query can be fixed. Maybe we should query spans() not logs()?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #621 (7bb035f) into master (0508433) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #621      +/-   ##
============================================
+ Coverage     88.60%   88.67%   +0.07%
- Complexity     1612     1614       +2
============================================
  Files           181      181
  Lines          5394     5394
  Branches        657      657
============================================
+ Hits           4779     4783       +4
+ Misses          378      377       -1
+ Partials        237      234       -3

Impacted Files
Coverage Δ

...nternal/tracking/OreoFragmentLifecycleCallbacks.kt
89.74% <0.00%> (-5.13%)
:arrow_down:

...g/android/rum/internal/domain/scope/RumEventExt.kt
81.82% <0.00%> (-1.82%)
:arrow_down:

...droid/rum/internal/domain/scope/RumSessionScope.kt
96.00% <0.00%> (-1.33%)
:arrow_down:

...c/main/kotlin/com/datadog/android/DatadogConfig.kt
94.03% <0.00%> (-0.50%)
:arrow_down:

...oid/src/main/kotlin/com/datadog/android/Datadog.kt
83.33% <0.00%> (ø)

...g/internal/domain/event/DdSpanToSpanEventMapper.kt
93.88% <0.00%> (ø)

...ernal/instrumentation/gestures/GesturesListener.kt
91.45% <0.00%> (+1.71%)
:arrow_up:

...droid/rum/tracking/ActivityViewTrackingStrategy.kt
86.79% <0.00%> (+1.89%)
:arrow_up:

...l/net/info/BroadcastReceiverNetworkInfoProvider.kt
79.17% <0.00%> (+2.08%)
:arrow_up:

.../android/error/internal/DatadogExceptionHandler.kt
92.00% <0.00%> (+4.00%)
:arrow_up:

... and 2 more


Test Sessionwindow happens panic：panic: runtime error: index out of range [0] with length 0

Logs:
time="2021-01-21 08:34:55" level=info msg="Successfully subscribe to topic /v1/+/service/data/TTAH" file="extensions/mqtt_source.go:193" rule=internal-xstream_query_rule
time="2021-01-21 08:34:55" level=info msg="Successfully subscribe to topic tcp://<IP_ADDRESS>:1883: 89ad3bf0-5bc3-11eb-9ff0-0242ac110002" file="extensions/mqtt_source.go:157" rule=internal-xstream_query_rule
panic: runtime error: index out of range [0] with length 0
goroutine 55 [running]:
github.com/emqx/kuiper/xstream/nodes.(*WindowOperator).execProcessingWindow(0x40002e2aa0, 0xfbca20, 0x4000381730, 0x0, 0x0, 0x0, 0x40002f4540)
/go/kuiper/xstream/nodes/window_op.go:280 +0x19bc
created by github.com/emqx/kuiper/xstream/nodes.(*WindowOperator).Exec
/go/kuiper/xstream/nodes/window_op.go:121 +0x4c8
Sql:SELECT * from TTAH GROUP BY SESSIONWINDOW(ss, 10,10)
Stream: bin/kuiper create stream TTAH '(deviceId string,param  STRUCT(deviceId STRING, data STRUCT(Tmp float, Hum float)))WITH (DATASOURCE="/v1/+/service/data/TTAH", FORMAT="JSON", STRIC
T_VALIDATION="false", CONF_KEY="default")'

Hi @swing99527,
Thanks for opening the issue. /window_op.go:280 is a debug log. Just to confirm, are you running in debug mode? What version do you use?

Hi @swing99527,
Thanks for opening the issue. /window_op.go:280 is a debug log. Just to confirm, are you running in debug mode? What version do you use?

Hi @swing99527,
Thanks for opening the issue. /window_op.go:280 is a debug log. Just to confirm, are you running in debug mode? What version do you use?

version: docker kuiper 1.1.1-alpine,
and after panic happend, container exit
How can I check whether run in debug mode?

Hi @swing99527,
Thanks for opening the issue. /window_op.go:280 is a debug log. Just to confirm, are you running in debug mode? What version do you use?

version: docker kuiper 1.1.1-alpine,
and after panic happend, container exit
How can I check whether run in debug mode?


linting update

updates linter to latest version
using latest particle config
adds lint:fix npm script
excludes softap-browser.js (generated file)

Coverage remained the same at 67.907% when pulling fd1ba9e4fb84701b5e8250dc26db7cb298fabe07 on feature/linting_update into 44f95ab19e580087211d1437935c824ffeb5585f on master.

Coverage remained the same at 67.907% when pulling 521e7eeacd9b7e3501457589bf7416a5a7a33ac9 on feature/linting_update into 44f95ab19e580087211d1437935c824ffeb5585f on master.

Coverage remained the same at 67.907% when pulling 521e7eeacd9b7e3501457589bf7416a5a7a33ac9 on feature/linting_update into 44f95ab19e580087211d1437935c824ffeb5585f on master.

Coverage remained the same at 67.907% when pulling 521e7eeacd9b7e3501457589bf7416a5a7a33ac9 on feature/linting_update into 44f95ab19e580087211d1437935c824ffeb5585f on master.


Security updates for default turn server configuration.

Relevant components:

[x] Signalling server
[ ] Frontend library
[ ] Frontend UI library
[ ] Matchmaker
[x] Platform scripts
[ ] SFU

Problem statement:
The default turn server configuration has a serious security vulnerability allowing internal network traversal from an external entity.
Solution
This change introduces a set of configuration options in a config file that will close off traversal to certain subnets.
Documentation
NA
Test Plan and Compatibility
Running the existing with-turn or turn scripts on windows/linux/docker should now mention that it loaded a config file and dump out a list of the blocked subnets.

Changes look okay - passing over to @MWillWallT to verify if this still works as expected on AWS Linux/Windows.

Fixed in https://github.com/EpicGames/PixelStreamingInfrastructure/pull/196


[Question]: cannot start ragflow-server

Describe your problem
(base) yumu@QLing:/mnt/d/QLing/llm_app/ragflow/docker$ sudo docker-compose -f docker-compose-CN.yml up -d
WARN[0000] The "ELASTIC_PASSWORD" variable is not set. Defaulting to a blank string.
[+] Building 0.0s (0/0)                                                                                docker:default
[+] Running 4/5
✔ Container ragflow-redis   Running                                                                               0.0s
✔ Container ragflow-mysql   Healthy                                                                               0.0s
✔ Container ragflow-es-01   Healthy                                                                               0.0s
✔ Container ragflow-minio   Running                                                                               0.0s
⠸ Container ragflow-server  Starting                                                                              1.3s
Error response from daemon: driver failed programming external connectivity on endpoint ragflow-server (d57d3bb0e3c77e349c26a4bc999be00cd66d916c0666f47b6733377c698aa95f): Error starting userland proxy: listen tcp4 <IP_ADDRESS>:443: bind: address already in use
(base) yumu@QLing:/mnt/d/QLing/llm_app/ragflow/docker$ sudo lsof -i:443
(base) yumu@QLing:/mnt/d/QLing/llm_app/ragflow/docker$

解决了，用的wsl，是windows系统占用了443端口

想问一下wsl是不是除了安装docker子系统还要安装unbuntun子系统呀？我进入docker系统之后，运行chmod +x ./entrypoint.sh和docker compose up -d显示没有docker-compose


↩  DCOS-17242: Adjust MarathonErrorUtil to handle missing detail errors

↩  This PR back-ports a fix to release/1.9 introduced with #2319

Adjust the parseErrors util to translates messages with empty or missing detail errors.
DCOS-17242

run integration tests

retest this please

run unit tests

@ahoskins Please note that Marathon 1.5 (DC/OS 1.10) responds with the following error messages, which we simple parse and display. Though I have to admit that the two messages are confusing.
{
	"message": "Object is not valid",
	"details": [{
		"path": "/",
		"errors": ["must not be root"]
	}, {
		"path": "/id",
		"errors": ["Path must contain at least one path element"]
	}]
}

Please retest using Marathon 1.4 (DC/OS 1.9).