News redesign

Related to #1120.
The avatar and the bold parts of the news item titles are clickable (except from the branch name). The branch name isn't clickable due to the architecture of the app, and such an implementation couldn't be done easily as of yet. This isn't to say that the branch shouldn't be clickable in the future.
Because these things are clickable, long pressing the item to navigate to the user name or repository page is unnecessary so it was removed.

Before
After

I'm gonna try this out for a while but from first impressions I'm not sold. Feels like a cluttered screen and I also think that those touch targets are to small, I know it's text but it's now also a target for interaction.

I feel like the cluttering of the screen is more to do with the design, i.e. having the links underlined and being such a vibrant blue. Maybe we can get rid of the blue styling for the username as it's unnecessary when you know you can click the avatar as well.
As with the target interaction, I don't feel that's a problem. If you look at Instagram with their hashtags, they have a similar touch target size and they don't seem to have a problem.

Regarding Instagram that's not one of their main navigation sources. That's content links just like we have in comment bodies. At least that's how I see them.

Aight, been using it a bit over the last couple of weeks. It's been easier to click the text when it's close together than I expected so that's nice. I'm still not sold on it though. Do some more work on the design and I'll have another look.

I've removed the underline from the links. I've left the link color as it is just using the accent color which I believe is semantically correct. Admittedly the color combination between the toolbar and link color isn't great (i.e. primary and accent color), but that is related to #1225, not this PR.

Initial design
Final design

In my opinion, I think this is pretty good.
And, I'm more than glad to merge it.

Thanks @fadils! I'd love to see this get merged as I think it is a step in the right direction for UX.


New cop RSpec/DocString to check Example/Example Group quoting

We prefer to use double-quoted strings for our example documentation, since those strings may contain contractions or interpolation. Elsewhere we prefer single-quoted strings. As a result, we have Style/StringLiterals disabled for our spec directory.
This change adds a cop to check string quoting just for examples and example groups.
Even better would be to also have a cop that does the complement -- only checking string literals that are not doc strings. I may work on that as a follow-up to this, but this seems like a good first step.
I've added the cop as disabled by default.

Hey @tjwp thanks a ton for the PR. @nevir gave me permission to take over maintaining this project so I'm going through the open PRs right now in order to get things moving again.
With that said, I'm not sure how I feel about this particular cop. I understand this is a policy that your dev team follows but I don't know if anyone else would really benefit from how specific this cop is. I think you probably agree to some extent given that you opted to make it disabled by default.
With this said, I appreciate the work you put into this cop, but I don't know if it is right for this project. I'm going to close this PR for now. I am always open to having my opinion changed though so feel free to continue discussion here.

No problem. My inclination was to share it just in case anybody else found it useful, and additional eyes from the community are always helpful.
But if it is too obscure I'm happy to maintain it in our own gem, along with the opposite cop that only checks non-doc strings.

For anybody that stumbles across this discussion, the cop is publicly available as part of https://github.com/salsify/salsify_rubocop under the name Salsify/RspecDocString.


Remove dropdown menu from navbar (desktop breakpoint)

Remove dropdown menu from navbar (Services Offered/About us) and switch to sticky (scroll to) tabs in each page.

Fixed


Add Toml comment preservation and header methods

Describe the solution you'd like
It would be useful to implement comment preservation and header methods on Toml files.

Hey Leonardo,
thank you for this idea. Are you able to create a PR for this? It would spare us a lot of time.
Regards,
Leonhard

I will see what can I do.

User didn't respond.

User didn't respond.

For now I don't have time, but let this issue open for remainder (that's what are supposed to do).


Add note about skipping initial notification emission.

Closes #59.

I'd add the same comment to BriteContentResolver as well, looks like that was #59 was referring to.

looks good other than that :+1:

:+1: Thanks!


Update nonexistent default 'test' image

We're receiving daily notifications from ArtifactHub vulnerability scannings with errors because it's not able to find the image specified in this chart:

Updating it to use https://hub.docker.com/_/hello-world/tags

I guess we still need to remove the previous Chart versions from the index to prevent them from being scanned.


[ALGO] Refactor integrations with OSRS Hiscores and CML

The player.rb model had cluttered logic for integrating to OSRS Hiscores and CML. I refactored this logic and placed it into two separate classes. This way we clean up a bit in the player model's logic, and separate it from the integration logic for OSRS Hiscores and CML.

Found a small error in player.rb. Will remove WIP tag when I have time to fix this.


chore: bumping superset ui to 15.18 and deckgl to 0.3.2

SUMMARY

Bumping both sets of plugins to the latest versions.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI passing!
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12078 (bbb5cd3) into master (148a001) will decrease coverage by 2.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12078      +/-   ##
==========================================
- Coverage   65.96%   63.65%   -2.32%
==========================================
  Files         959      476     -483
  Lines       47160    29371   -17789
  Branches     4613        0    -4613
==========================================
- Hits        31111    18696   -12415
+ Misses      15898    10675    -5223
+ Partials      151        0     -151

Flag
Coverage Δ

cypress
?

javascript
?

python
63.65% <ø> (-0.66%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/db_engine_specs/presto.py
69.95% <0.00%> (-12.45%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/utils/celery.py
96.42% <0.00%> (-3.58%)
:arrow_down:

superset/examples/world_bank.py
97.10% <0.00%> (-2.90%)
:arrow_down:

superset/examples/birth_names.py
96.51% <0.00%> (-2.33%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

superset/result_set.py
96.69% <0.00%> (-1.66%)
:arrow_down:

... and 494 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148a001...bbb5cd3. Read the comment docs.

Should we bump the lock file, too?

Hah! This occurred to me immediately after opening the PR, but I had rushed out the door to attend to something. Adding now.


Install failure

OS Debian 11

First way of install:

cargo install bard-rs

Updating crates.io index
error: failed to fetch https://github.com/rust-lang/crates.io-index

Second way:

cargo build --release

error: failed to parse manifest at /home/jes/Bard-rs/Cargo.toml
Caused by:
failed to parse the edition key
Caused by:
supported edition values are 2015 or 2018, but 2021 is unknown

Can you try this?: https://www.reddit.com/r/rust/comments/sjoht3/receiving_error_supported_edition_values_are_2015/

Perfect! Thank you so much. Please close this issue.


TAF-Demo is not able to clone

I tried to clone the demo code which described in the README, it seems need to provide the username and password.
$ git clone --recurse-submodules https://github.impcloud.net/IVS/TAF-Demo.git
Cloning into 'TAF-Demo'...
Username for 'https://github.impcloud.net':

@ramya-ranganathan Could you help check the TAF-Demo repository?

Sorry that was the reference to the original repo, will create a PR to update it.

I created a PR with the fix for this issue.

Why are you cloning into GitHub.impcloud.net?

The README was done when we had the repo in github.impcloud.net. I created a PR with the updated command:
git clone --recurse-submodules https://github.com/edgexfoundry-holding/edgex-taf.git

Fixed by https://github.com/edgexfoundry-holding/edgex-taf/pull/4


[nexusRepo] Add changelogTemplate

From #6424 to add changelogTemplate

@BiNZGi this need a bit more work , older releases are not matching with current template , so we need link: "" for the versions which are lower than 3-59-0 . 3-59-0 and above working

It looks like there is another pattern if a patch version is released, e.g.
https://help.sonatype.com/en/sonatype-nexus-repository-3-58-0---3-58-1-release-notes.html
https://help.sonatype.com/en/sonatype-nexus-repository-3-57-0---3-57-1-release-notes.html
https://help.sonatype.com/en/sonatype-nexus-repository-3-54-0---3-54-1-release-notes.html
https://help.sonatype.com/en/sonatype-nexus-repository-3-53-0---3-53-1-release-notes.html
https://help.sonatype.com/en/nexus-repository-3-47-0---3-47-1-release-notes.html
https://help.sonatype.com/en/nexus-repository-3-29-0---3-29-2-release-notes.html
I think that is possible to do with a special changelogTemplate.


Markdown headers are not rendered when more than one header is in a given cell

VSCode Version: 1.40.2
OS Version:  10.14.6 (18G1012

Steps to Reproduce:

Add the following content in a cell

## Header 1

### Header 2

Change the content to Markdown
Render the cell

Does this issue occur when all extensions are disabled?: Yes

/needsMoreInfo
Could you please clarify what cell to you mean?
If it's cell in Jupyter notebook then this issue should be reported in Python extension repo.

@IllusionMH a Jupyter notebook is made by "cells", which kind of isolate codes. Cells can also host markdown content.
Please see here for the reference
https://jupyter-notebook.readthedocs.io/en/stable/notebook.html#structure-of-a-notebook-document

/causedByExtension
Please fill in this issue against Python extension: https://github.com/microsoft/vscode-python/issues


How to find neighbors

Hi. Thank you for your work in this library. I have a feature request:
Given a reference point, and a heterogeneous set of points, one might want to search some points in the set based on the distance with the reference point. In the geohash world this is usually done by computing the 8 neighbor cells.
A ticket at s2geometry suggest to build a S2PointIndex and querying it with a S2ClosestPointQuery (in the cpp implementation). It seems those datastructures are not present in this library, and this is fine, since I would prefer to use my own datastructures (or at least the one my database library allow me to use).
I suggest implementing a method that, given a cell and a precision, returns all the neighbor cells.
This would allow me to implement the algorithm described in this SO answer.
It is possible that there are some concepts about S2 that I do not really get though. In this case maybe a word about this in the documentation would be welcome?
What do you think?

Hi, I hadn't looked much at adding neighbour functions yet, since they're outside of the core conversions. However, I think I have the necessary primitive functions to do it though, since it happens in the IJ coord space IIRC.
If you want a direct mapping of the C++ implementation classes into Python though, you may be better off with the s2geometry built-in python module or s2sphere.

See #16


[TypeRecovery] Makes sure the receiver is the one with argumentIndex 0

The starting point here was a discrepancy wrt methodFullNames in Python for the following two samples:
a = 10
foo(a) # methodFullName = __builtin.int.foo

vs
foo(10) # methodFullName = <unknownFullName>

It was noticed that in setTypeInformationForRecCall it isn't true (in general) that the argument i is the actual receiver, hence the extra guard for argumentIndex = 0. We could try to make sure this method is only invoked with the proper (receiver) arguments, but this extra guard seemed to have the best cleanliness:succinctness ratio.
Now both samples have an unknown methodFullName.

Taking a look at the failing Kotlin test.


filter error segment when export trace to kafka

[ ] If this is non-trivial feature, paste the links/URLs to the design doc.

[x] Update the documentation to include this new feature.

[ ] Tests(including UT, IT, E2E) are added to verify the new feature.

[ ] If it's UI related, attach the screenshots below.

[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #10717.

[ ] Update the CHANGES log.

Please fix code styles.

Check this, https://github.com/apache/skywalking/actions/runs/4881492482/jobs/8710467345?pr=10760

@yqjdcyy The codes compiling seems failing, please fix.

Please update the changes.md for this new feature.

recompile passed and changes.md was updated.


Dataflow Tuning

This PR add support to tune the most commonly used params for dataflow.
The changes include:

New dataflow form for configuration that groups networking and performance parameters.
Add a preset section that is not editable by default. The user must explicitly click edit to modify these parameters.
Remove the green tick next to tune dataflow step by default. It now appears only if configured

Pending improvements:

Add more validation in the dataflow form
Change KMS key name to a radio button

Dataflow Form:

Networking Section:

Performance Section:

Presets section:

Tested:
UI:

Sharded: datastream workers passed correctly
NonSharded: datastream workers passed correctly
Sharded: dataflow params VPC (via subnet and autonetwork), numWorkers, maxWorkers, machineType, userLabels, region, customPath set correctly.
NonSharded: dataflow params VPC (via subnet and auto network), numWorkers, maxWorkers, machineType, userLabels, region, customPath set correctly.

CLI:
Non-sharded: parameters passed correctly
Sharded:  parameters passed correctly

I think this looks good overall, minor comments. We do need the following though -

We need to test against different combinations of these parameters are ensure that they work. I will recommend using the CLI here to run these tests.
Documentation updates
Please talk to @darshan-sj about these test scenarios so that he is aware of the need of this kind of integration testing.

Added testing details
Doc updates covered here: https://github.com/GoogleCloudPlatform/spanner-migration-tool/pull/638


Back button shows incorrect background color on hover

Describe the bug

Back button's hover background should be the same as the hamburger button's.
Steps to reproduce the bug

Steps to reproduce the behavior:

Start an app with NavigationView
Move cursor to hover over the pane toggle (hamburger button)
Now move cursor to hover over back button

Expected behavior

Both buttons should show the same color on their hover backplate.
Screenshots

Version Info

NuGet package version:

Current prerelease version

Windows 10 version
Saw the problem?

Insider Build (xxxxx)
Yes

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Anniversary Update (14393)

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

Additional context

Was this resolved already? I'm unable to reproduce - both the back button and navigation menu give hover values of 53, 53, 53.

Indeed this appears to have been fixed. At least, I'm no longer seeing the issue in the Controls Gallery. @ojhad may have fixed in this while correcting some HC styles.
The Search button still looks off, but that's a separate issue.


Frontend - Map markers update

Done:

#245
#279

Merging due to finishing this PR in pair programming, thus already reviewing the code by another SD.


AUR .tar.gz link is not found

Hello! Thank your great project!
I know it is working, but apropriate arch linux package is missing at your server right now.
Could you check it or should we just update the PKGBUILD to support your github repo?
(Propably just update the link to https://github.com/stroobantstom/duckdns/archive/master.zip, apropiate md5sum and change from cd duckdns to duckdns-master

Hi, it seems I've put some mail settings wrong and I just noticed these issues. I'm terribly sorry for the two years wait (not a big github user ;-) ). I've also seen someone has already updated the PKGBUILD on the AUR repositories so I will close this issue. I will also start checking Github more ;-)


Can't Scroll with Keyboard Open

existing issue?
This is a new problem with yesterday's release.
Expected behavior
Ability to scroll within message while composing.
Actual behavior
Can't scroll. Message is stuck in a tiny frame. My extra long signature (which I'm NOT trying to edit) monopolizes the screen, and can't be scrolled out of view.
Steps to reproduce

Compose a reply

Environment
K-9 Mail version: 5.703
Android version: 7.1.1
Account type (IMAP, POP3, WebDAV/Exchange): IMAP
logs
Not a crash or bug.

Duplicate of #4342


Add goto support

As byproduct fix processing return; statement.
Add support for '%' operator.

Thanks!


Deploy on tag

[ ] generate PyPI token for deployment
[ ] encrypt token for .travis.yml and add it there
[ ] modify .travis.yml to execute commands on tag
[ ] add commands for uploading pypack on tag

https://docs.travis-ci.com/user/deployment/pypi/


python311Packages.keyrings-alt: 4.2.0 -> 5.0.0

Changelog: https://github.com/jaraco/keyrings.alt/blob/v5.0.0/NEWS.rst
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 251344 run on x86_64-linux 1

4 packages failed to build:

python310Packages.heudiconv
python310Packages.heudiconv.dist
python311Packages.heudiconv
python311Packages.heudiconv.dist

27 packages built:

aws-google-auth
aws-google-auth.dist
datalad
datalad.dist
home-assistant-component-tests.icloud
maestral (python310Packages.maestral)
maestral-gui
maestral-gui.dist
maestral.dist (python310Packages.maestral.dist)
myfitnesspal (python310Packages.myfitnesspal)
myfitnesspal.dist (python310Packages.myfitnesspal.dist)
python310Packages.keyrings-alt
python310Packages.keyrings-alt.dist
python310Packages.orange3
python310Packages.orange3.dist
python310Packages.pyicloud
python310Packages.pyicloud.dist
python311Packages.keyrings-alt
python311Packages.keyrings-alt.dist
python311Packages.maestral
python311Packages.maestral.dist
python311Packages.myfitnesspal
python311Packages.myfitnesspal.dist
python311Packages.orange3
python311Packages.orange3.dist
python311Packages.pyicloud
python311Packages.pyicloud.dist

Result of nixpkgs-review pr 251344 run on x86_64-linux 1

31 packages built:

aws-google-auth
aws-google-auth.dist
datalad
datalad.dist
home-assistant-component-tests.icloud
maestral (python310Packages.maestral)
maestral-gui
maestral-gui.dist
maestral.dist (python310Packages.maestral.dist)
myfitnesspal (python310Packages.myfitnesspal)
myfitnesspal.dist (python310Packages.myfitnesspal.dist)
python310Packages.heudiconv
python310Packages.heudiconv.dist
python310Packages.keyrings-alt
python310Packages.keyrings-alt.dist
python310Packages.orange3
python310Packages.orange3.dist
python310Packages.pyicloud
python310Packages.pyicloud.dist
python311Packages.heudiconv
python311Packages.heudiconv.dist
python311Packages.keyrings-alt
python311Packages.keyrings-alt.dist
python311Packages.maestral
python311Packages.maestral.dist
python311Packages.myfitnesspal
python311Packages.myfitnesspal.dist
python311Packages.orange3
python311Packages.orange3.dist
python311Packages.pyicloud
python311Packages.pyicloud.dist


better error handling in download_file

I was trying out the tool and its really cool! But i noticed the error handling in download_file is not up to the mark. I was behind proxy and my internet was particularly slow. When i tried, i kept getting below error -
Traceback (most recent call last):   File "C:\Anaconda3\Scripts\googleimagesdownload-script.py", line 11, in <module>     load_entry_point('google-images-download==2.0.4', 'console_scripts', 'googleimagesdownload')()   File "C:\Anaconda3\lib\site-packages\google_images_download-2.0.4-py3.6.egg\google_images_download\google_images_download.py", line 819, in main   File "C:\Anaconda3\lib\site-packages\google_images_download-2.0.4-py3.6.egg\google_images_download\google_images_download.py", line 777, in download   File "C:\Anaconda3\lib\site-packages\google_images_download-2.0.4-py3.6.egg\google_images_download\google_images_download.py", line 666, in _get_all_items   File "C:\Anaconda3\lib\site-packages\google_images_download-2.0.4-py3.6.egg\google_images_download\google_images_download.py", line 577, in download_image UnboundLocalError: local variable 'output_file' referenced before assignment
It looks like below finally block gets executed for whatever reason, there will not be any meaningful error thrown to user. It will be good if you add this message.
finally: output_file.close()

I am also having this problem

Thanks!
UnboundLocalError bug should now be resolved. @hegman12 , @HappyAdjustableSpanners could you download the latest version of this repo and try again?

The latest version of this script should resolve this issue. Closing this issue.
If you guys do still see this issue, do let me know.

Hey, Thanks for quick response!


HC-421: Return non-0 exit code when disk space fills up

This PR updates Sciflo such that if there is no more disk space while it is running, it will return a non-0 exit code. Previously, it was always returning 0, which caused verdi to flag the job as "job completed".
To err on the side of caution, as well as to achieve backwards compatibility, we are only going to throw a non-0 exit code specifically for disk space full use cases.
2022-05-24 21:25:56 PGE_L1B_LR_INTF:DEBUG [executor.py:654] Got OSError in shutdown() for sciflo 'PGE_L1B_LR_INTF':[Errno 28] No space left on device: '/data/work/jobs/2022/05/24/21/22/SCIFLO_L1B_LR_INTF__SSDS-2234-L1B_LR_INTF_001_175-state-config-20220524T174647.588944Z/output/workunit_result-0.txt'
Exception Type: <class 'OSError'>
Exception Value: [Errno 28] No space left on device: '/data/work/jobs/2022/05/24/21/22/SCIFLO_L1B_LR_INTF__SSDS-2234-L1B_LR_INTF_001_175-state-config-20220524T174647.588944Z/output/workunit_result-0.txt'
Traceback (most recent call last):
  File "/home/ops/verdi/ops/sciflo/sciflo/grid/executor.py", line 643, in shutdown
    with open(resFile, 'w') as f:
OSError: [Errno 28] No space left on device: '/data/work/jobs/2022/05/24/21/22/SCIFLO_L1B_LR_INTF__SSDS-2234-L1B_LR_INTF_001_175-state-config-20220524T174647.588944Z/output/workunit_result-0.txt'

Running sflExec.py command:
/home/ops/verdi/bin/sflExec.py -s -f -o output --args "sf_context=/data/work/jobs/2022/05/24/21/22/SCIFLO_L1B_LR_INTF__SSDS-2234-L1B_LR_INTF_001_175-state-config-20220524T174647.588944Z/_context.json" /home/ops/verdi/ops/swot-pcm/swot_chimera/wf_xml/L1B_LR_INTF.sf.xml
Exit status is: 256

Regarding the circleci test failures, spoke with @pymonger on this and the suggestion was to run it on Mozart due to a known issue with running the sciflo test through Circleci. I ran the unit tests on Mozart and it passed:

@mcayanan could you also bump the minor version?

Good catch! I keep forgetting. It's been bumped now.


Change the webdriver package to run with install-only flag.

add flag install-only to install the driver without running it. Also add driver for chrome 78.
The possible ways of running the webdrivers:
dart lib/web_driver_installer.dart & (used in flutter/flutter. uses chromedrivers command. installs and runs the driver)
dart lib/web_driver_installer.dart chromedriver (not it use. installs and runs the chrome driver)
dart lib/web_driver_installer.dart chromedriver install-only (will be used in e2e package PR )

The possible ways of running the webdrivers:

dart lib/web_driver_installer.dart & (used in flutter/flutter. uses chromedrivers command. installs and runs the driver)

dart lib/web_driver_installer.dart chromedriver (not it use. installs and runs the chrome driver)

dart lib/web_driver_installer.dart chromedriver install-only

That sounds like fantastic documentation for the README.md file :P

Done! Thanks for the suggestion


How to use table widget's ColumnResizer ?

Could you update the table.go example so that one of the tables uses ColumnResizer ?
Thanks...

Did you figure out how to use it ?


Use lldb-vscode debug adapter from Swift Toolchain

This is only available in the Windows toolchain at the moment. If you want to use it on other platforms you need to build a toolchain yourself and extract the lldb-vscode executable out of the build folder and copy into the bin folder alongside swift.
This is not enabled by default. You have to go into the settings and select swift.debugger.useDebugAdapterFromToolchain

@compnerd

Would there be a way to make CodeLLDB optionally installed so if we don't use it we don't have to have it installed?

Would there be a way to make CodeLLDB optionally installed so if we don't use it we don't have to have it installed?

Not easily. I have looked into breaking the dependency and setting it up programmatically. They haven't been 100% successful so far.

This is super exciting! I'm looking forward for a path to better debugging support through this!

@tristanlabelle there is a pre-release out which includes this PR.

Merging into pre-release/1.6 branch


How can I generate a picture from taskbook

https://github.com/klauscfhq/taskbook/blob/master/media/header-boards.png
Just like the image above, is there any tool to generate a picture from terminal output?

In my opinion, you simply use any software which can take the screenshot.

@duynguyenhoang Thanks for your help.
But actually what I want is exactly the same as the picture above.
I think it is done in Hyper.js, with a special theme which can hide the address in the status bar, and of course, with cmd+shift+4.

Looks more like iTerm2 (in Dark Mode), Window manually resized and taken an Screenshoot with the macOS build in Tools...

Screenshots display the hyper terminal along with the hyperocean theme and the hyper-hide-title plugin : )


[Add-ins] (admin) Update docs metadata.

This PR does the following:

updates docfx.json to specify author, ms.author, and ms.technology metadata attribute values for all .md files in the add-ins folder
removes those individual metadata attributes from all individual files in the add-ins folder
removes legacy-addins.md (empty/obsolete file) and adds redirect for it

OPS Build status updates of commit e0db732:
:clock10: Preparing: average preparing time is 41 sec(s)

OPS Build status updates of commit e0db732:
:clock10: Incremental building: average incremental building time is 18 sec(s)

OPS Build status updates of commit e0db732:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/add-ins/activation-rules.md
:white_check_mark:Succeeded

docs/add-ins/add-and-remove-attachments-to-an-item-in-a-compose-form.md
:white_check_mark:Succeeded

docs/add-ins/add-in-commands-for-outlook.md
:white_check_mark:Succeeded

docs/add-ins/add-in-requirements.md
:white_check_mark:Succeeded

docs/add-ins/add-mobile-support.md
:white_check_mark:Succeeded

docs/add-ins/addin-tutorial.md
:white_check_mark:Succeeded

docs/add-ins/apis.md
:white_check_mark:Succeeded

docs/add-ins/authenticate-a-user-with-an-identity-token.md
:white_check_mark:Succeeded

docs/add-ins/authenticate-a-user-with-an-sso-token.md
:white_check_mark:Succeeded

docs/add-ins/authentication.md
:white_check_mark:Succeeded

docs/add-ins/compare-outlook-add-in-support-in-outlook-for-mac.md
:white_check_mark:Succeeded

docs/add-ins/compose-scenario.md
:white_check_mark:Succeeded

docs/add-ins/contextual-outlook-add-ins.md
:white_check_mark:Succeeded

docs/add-ins/extension-module-outlook-add-ins.md
:white_check_mark:Succeeded

docs/add-ins/extract-entity-strings-from-an-item.md
:white_check_mark:Succeeded

docs/add-ins/get-and-set-item-data-in-a-compose-form.md
:white_check_mark:Succeeded

docs/add-ins/get-and-set-recurrence.md
:white_check_mark:Succeeded

docs/add-ins/get-attachments-of-an-outlook-item.md
:white_check_mark:Succeeded

docs/add-ins/get-or-set-the-location-of-an-appointment.md
:white_check_mark:Succeeded

docs/add-ins/get-or-set-the-subject.md
:white_check_mark:Succeeded

docs/add-ins/get-or-set-the-time-of-an-appointment.md
:white_check_mark:Succeeded

docs/add-ins/get-set-or-add-recipients.md
:white_check_mark:Succeeded

docs/add-ins/implement-sso-in-outlook-add-in.md
:white_check_mark:Succeeded

docs/add-ins/index.md
:white_check_mark:Succeeded

docs/add-ins/insert-data-in-the-body.md
:white_check_mark:Succeeded

docs/add-ins/inside-the-identity-token.md
:white_check_mark:Succeeded

docs/add-ins/item-data.md
:white_check_mark:Succeeded

docs/add-ins/legacy-addins.md
:white_check_mark:Succeeded

docs/add-ins/limits-for-activation-and-javascript-api-for-outlook-add-ins.md
:white_check_mark:Succeeded

docs/add-ins/manifests.md
:white_check_mark:Succeeded

docs/add-ins/match-strings-in-an-item-as-well-known-entities.md
:white_check_mark:Succeeded

docs/add-ins/metadata-for-an-outlook-add-in.md
:white_check_mark:Succeeded

docs/add-ins/outlook-addin-design.md
:white_check_mark:Succeeded

docs/add-ins/outlook-mobile-addins.md
:white_check_mark:Succeeded

docs/add-ins/outlook-on-send-addins.md
:white_check_mark:Succeeded

docs/add-ins/pinnable-taskpane.md
:white_check_mark:Succeeded

docs/add-ins/privacy-and-security.md
:white_check_mark:Succeeded

docs/add-ins/quick-start.md
:white_check_mark:Succeeded

docs/add-ins/read-scenario.md
:white_check_mark:Succeeded

docs/add-ins/sideload-outlook-add-ins-for-testing.md
:white_check_mark:Succeeded

docs/add-ins/testing-and-tips.md
:white_check_mark:Succeeded

docs/add-ins/tips-for-handling-date-values-in-outlook-add-ins.md
:white_check_mark:Succeeded

docs/add-ins/troubleshoot-outlook-add-in-activation.md
:white_check_mark:Succeeded

docs/add-ins/understanding-outlook-add-in-permissions.md
:white_check_mark:Succeeded

docs/add-ins/use-regular-expressions-to-show-an-outlook-add-in.md
:white_check_mark:Succeeded

docs/add-ins/use-rest-api.md
:white_check_mark:Succeeded

docs/add-ins/validate-an-identity-token.md
:white_check_mark:Succeeded

docs/add-ins/web-services.md
:white_check_mark:Succeeded

docs/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jasonjoh at long last, here's the PR to update metadata values for the Add-ins docs in OfficeDev/outlook-dev-docs. Can you please review? Please note the following:

Metadata values for ms.technology, ms.author, and author are being specified at the folder level (i.e., for all .md files in the add-ins folder) in docfx.json.
It's by design that we're using the user/account o365devx for the ms.author and author metadata attributes.
The APEX team has recently whitelisted the metadata values ms.prod = outlook and ms.technology = add-ins -- so this PR updates ms.technology value accordingly (ms.prod = outlook is already being set at the global level for this doc set, so no changes were necessary to set this metadata value).

Thanks in advance for your review!


Improve prerequisites for “Run a Replicated Stateful Application”

Replication doesnt work by following this https://kubernetes.io/docs/tasks/run-application/run-replicated-stateful-application/
slave can not connect to master. (There is no replication user in mysql.user) I used namespace: mysql for all yml
mysql> SHOW SLAVE STATUS\G;
*************************** 1. row ***************************
               Slave_IO_State: Connecting to master
                  Master_Host: mysql-0.mysql
                  Master_User: root
                  Master_Port: 3306
                Connect_Retry: 10
              Master_Log_File: mysql-0-bin.000010
          Read_Master_Log_Pos: 154
               Relay_Log_File: mysql-2-relay-bin.000004
                Relay_Log_Pos: 4
        Relay_Master_Log_File: mysql-0-bin.000010
             Slave_IO_Running: Connecting
            Slave_SQL_Running: Yes
              Replicate_Do_DB:
          Replicate_Ignore_DB:
           Replicate_Do_Table:
       Replicate_Ignore_Table:
      Replicate_Wild_Do_Table:
  Replicate_Wild_Ignore_Table:
                   Last_Errno: 0
                   Last_Error:
                 Skip_Counter: 0
          Exec_Master_Log_Pos: 154
              Relay_Log_Space: 154
              Until_Condition: None
               Until_Log_File:
                Until_Log_Pos: 0
           Master_SSL_Allowed: No
           Master_SSL_CA_File:
           Master_SSL_CA_Path:
              Master_SSL_Cert:
            Master_SSL_Cipher:
               Master_SSL_Key:
        Seconds_Behind_Master: NULL
Master_SSL_Verify_Server_Cert: No
                Last_IO_Errno: 1045
                Last_IO_Error: error connecting to master 'root@mysql-0.mysql:3306' - retry-time: 10  retries: 300
               Last_SQL_Errno: 0
               Last_SQL_Error:
  Replicate_Ignore_Server_Ids:
             Master_Server_Id: 0
                  Master_UUID:
             Master_Info_File: /var/lib/mysql/master.info
                    SQL_Delay: 0
          SQL_Remaining_Delay: NULL
      Slave_SQL_Running_State: Slave has read all relay log; waiting for more updates
           Master_Retry_Count: 86400
                  Master_Bind:
      Last_IO_Error_Timestamp: 201027 10:20:56
     Last_SQL_Error_Timestamp:
               Master_SSL_Crl:
           Master_SSL_Crlpath:
           Retrieved_Gtid_Set:
            Executed_Gtid_Set:
                Auto_Position: 0
         Replicate_Rewrite_DB:
                 Channel_Name:
           Master_TLS_Version:
1 row in set (0.00 sec)

/retitle Replication not working in “Run a Replicated Stateful Application”

Thanks for reporting this @sdwerwed - we'll check it out.

Changing the namespece form mysql to somethink else like mysqlns works

Hi @sdwerwed I think what you're saying is that in your cluster this didn't work if the Kubernetes namespace you deploy it into is named mysql, but does work if you use a different (non-reserved) namespace name.
Have I got that right?

Hi @sdwerwed I think what you're saying is that in your cluster this didn't work if the Kubernetes namespace you deploy it into is named mysql, but does work if you use a different (non-reserved) namespace name.
Have I got that right?

Hello, yes you got it 👍

Let's document that this example assumes you're using the default namespace or another namespace that doesn't contain any conflicting objects.

/retitle Improve prerequisites for “Run a Replicated Stateful Application”
/triage accepted
/language en

Closed as #27128 is merged


MLR

Token Address
https://scan.tomochain.com/tokens/0x5080781e91237b6d7f026d5306b7233e26cd6c16
Token Symbol
MLR
Token Name
Mega Lottery
Token Logo
https://drive.google.com/file/d/1T4-0JaSa1K6SUJjmE9DkiFYXcdRmNE-u/view?usp=sharing
Token Description
MLR Token TRC21 is used to pay ticket and rewards of  Megamillions & Powerball US lottery at MegaLTR.com
It applies blockchain technology to buy tickets and receive rewards via smart contracts.
Website
https://megaltr.com
Social links
https://github.com/MegaltrLottery, https://t.me/MegaLTR_Lottery, https://twitter.com/MegaLTR

done


[BUG] - UI Crashes when I add Tooltip

NextUI Version
v2.3.6
Describe the bug
Uncaught Error: Only two keyframes currently supported with spring and inertia animations. Trying to animate scale(0.6),scale(0.61547),scale(0.65082),scale(0.69443),scale(0.73944),scale(0.78204),scale(0.82036),scale(0.85368),scale(0.88195),scale(0.90551),scale(0.92487),scale(0.94061),scale(0.95328),scale(0.9634),scale(0.97144),scale(0.97779),scale(0.98278),scale(0.98668),scale(0.98973),scale(0.99209),scale(0.99393),scale(0.99534),scale(0.99644),scale(0.99728),scale(0.99792),scale(0.99842),scale(0.99879),scale(0.99908),scale(0.9993),scale(0.99947),scale(1)
at invariant (chunk-LI6MNC3Y.js?v=bd30c072:1769:13)
at MainThreadAnimation.initPlayback (chunk-LI6MNC3Y.js?v=bd30c072:3066:9)
at MainThreadAnimation.onKeyframesResolved (chunk-LI6MNC3Y.js?v=bd30c072:2416:15)
at KeyframeResolver.onResolved [as onComplete] (chunk-LI6MNC3Y.js?v=bd30c072:3051:67)
at KeyframeResolver.complete (chunk-LI6MNC3Y.js?v=bd30c072:1976:10)
at KeyframeResolver.scheduleResolve (chunk-LI6MNC3Y.js?v=bd30c072:1936:12)
at new MainThreadAnimation (chunk-LI6MNC3Y.js?v=bd30c072:3057:19)
at AcceleratedAnimation.stop (chunk-LI6MNC3Y.js?v=bd30c072:3496:31)
at MotionValue.stop (chunk-LI6MNC3Y.js?v=bd30c072:3893:22)
at chunk-LI6MNC3Y.js?v=bd30c072:3764:18
at Object.process (chunk-LI6MNC3Y.js?v=bd30c072:192:11)
at processStep (chunk-LI6MNC3Y.js?v=bd30c072:229:20)
at Array.forEach ()
at processBatch (chunk-LI6MNC3Y.js?v=bd30c072:237:16)
   <Tooltip  showArrow={true} className='dark:text-white animate-none' content={platformUserName}>
      <Avatar
        style={{zIndex:"1"}}
        className='cursor-pointer'
        size="md"
        src={avatarUrl || '/src/Images/download.png'}
      />
      </Tooltip>

      when i hover tooltip more then 1 time then my ui crashes

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Add a tooltip
hove the element for tooltip
ui will crash
check the error in inspact

Expected behavior
I expected the username(tooltip) hovering on  Avatar , but my ui is crashing
Screenshots or Videos
No response
Operating System Version
Windows
Browser
Chrome

I've seen this error before. It's from framer-motion. Which version are you using?

Thanks Bro , I thing it's resolved , when i update the version of the framer-motion then it's not crashing the ui


Add GCS Action (#121)

init

fix types, set output

init

fix types, set output

refactor

enable tests

get bucket name from secret

rebuild

remove prints

rename action

add DS_Store to gitignore

lint

address comments

rename action

addressed review comments

fix pr comments, new testing approach

update IT secret names

fix filename

update run paths

fix readme add credentials field for setup gcloud

This looks like an accidental PR. Please feel free to reopen with a note on the purpose of this PR.


jekyll 3.8.6 | Error:  wrong number of arguments (given 2, expected 1)

I am getting below error:
$ npm run local

> chalk@ local /Users/<user>/Documents/projects/blog/chalk
> bundle exec jekyll serve --drafts

Configuration file: /Users/<user>/Documents/projects/blog/chalk/_config.yml
            Source: /Users/<user>/Documents/projects/blog/chalk
       Destination: /Users/<user>/Documents/projects/blog/chalk/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
jekyll 3.8.6 | Error:  wrong number of arguments (given 2, expected 1)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! chalk@ local: `bundle exec jekyll serve --drafts`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the chalk@ local script.

Trace logs:
ArgumentError: wrong number of arguments (given 2, expected 1)
  /Users/<user>/.rvm/gems/ruby-2.6.3/gems/jekyll-assets-3.0.12/lib/jekyll/assets/manifest.rb:58:in `find_directory_manifest'
  /Users/<user>/.rvm/gems/ruby-2.6.3/gems/sprockets-4.0.0/lib/sprockets/manifest.rb:56:in `initialize'
  /Users/<user>/.rvm/gems/ruby-2.6.3/gems/jekyll-assets-3.0.12/lib/jekyll/assets/manifest.rb:29:in `initialize'
  /Users/<user>/.rvm/gems/ruby-2.6.3/gems/jekyll-assets-3.0.12/lib/jekyll/assets/env.rb:48:in `new'

Machine: MacOS Catalina.
Can you please help me to solve the issue?

Getting a similar error on both my Windows machine, and macOS. It seems very Ruby-specific. Any attempt I make at fixing the issue, either by updating Gems, or elevating permissions, seems to fail to circumvent it. Anyone got an idea on what it might be?

So if you enter the Gemfile and remove the 3.8.6 requirement from Jekyll, it will install 4.0.0, which is slightly more verbose about the error. The error will say that _includes/head.html fails to locate og-image.jpg. This can be remedied by adding _assets/images to sources in the _config.yml file. However, I am now getting an error that there are two incompatible character encodings in layouts/post.html: UTF-8 and ASCII-8BIT.

I run bundle exec jekyll serve --trace and i found something that might be a root cause of the problem.
Traceback (most recent call last):
 ...
     3: from C:/Ruby26-x64/lib/ruby/gems/2.6.0/gems/jekyll-assets-3.0.12/lib/jekyll/assets/env.rb:48:in `new'
     2: from C:/Ruby26-x64/lib/ruby/gems/2.6.0/gems/jekyll-assets-3.0.12/lib/jekyll/assets/manifest.rb:29:in `initialize'
     1: from C:/Ruby26-x64/lib/ruby/gems/2.6.0/gems/sprockets-4.0.0/lib/sprockets/manifest.rb:56:in `initialize'
 C:/Ruby26-x64/lib/ruby/gems/2.6.0/gems/jekyll-assets-3.0.12/lib/jekyll/assets/manifest.rb:58:in `find_directory_manifest': wrong number of arguments (given 2, expected 1) (ArgumentError)

From the stacktrace it seems that the issue is sprockets 4.0.0 breaks recent version of jekyll-assets (3.0.12 as the writings).
I search for suggestions and comments regarding the issue and i found rgant's comment in https://github.com/envygeeks/jekyll-assets/issues/622, which is suggesting that forcing sprockets to earlier version in Gemfile might do the trick.
gem "sprockets", "~> 3.7"

@cartjonye confirmed, thank you. The above fix is working for me.


raise when time col not in cluster cols

Addresses https://github.com/david26694/cluster-experiments/issues/145

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.01%.  Consider uploading reports for the commit 1b1b3b6 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   97.00%   97.01%
=======================================
  Files           9        9
  Lines         902      905    +3
=======================================
+ Hits          875      878    +3
  Misses         27       27

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


charging limit keep 100%

seems issue from tibber.
even if the value is on 90%, it still keep on 100%

Hi
Thanks for your work. Overall Is work really god for automation.
Is will be perfect if this issue can be fixed
Uffe


Syntax highlighting breaks when using # inside an inline monospace

Hi there!
Example document:
* `hello` world
* `hello #` world
* highlighting now broken

Renders as

I'm running into the same issue for ~ and * contained in inline code sections. See how that * breaks the highlighting here:

If you escape it to \* the highlighting is fixed but the backslash gets rendered into the output.


Quyend

如果是文字类 PR，请按照 中文排版指北 进行编写(提交时可删除该提示)。
What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[x] Other, please describe:
add some test in TwoSumTest.java

The description of the PR:
Other information:

No need for test code.


There is a problem with the 3-pixel error code in fintune

When I change the size of the batch, the same model calculates different errors！！！
batch=1 ，3-pixel error=1.520
batch=3，3-pixel error change to  1.623
Can anyone explain the problem？

@JiaRenChang Can you provide the kitti2015 pre training model of 300epoch in the paper for me to test，The 1000 epoch model is difficult to reflect the real effect of the model in the val dataset

Happily, I think I may have found the problem. There is an error in the calculation of less than 5% in fintune. I think it might be because  it's disp_ True and true_ Disp points to the same memory.
So you can have an easy way to fix it，as follow：
correct = (disp_true[index[0][:], index[1][:], index[2][:]] < 3)|(disp_true[index[0][:], index[1][:], index[2][:]] < true_disp[index[0][:], index[1][:], index[2][:]]*0.05)
change to
p5 = true_disp[index[0][:], index[1][:], index[2][:]]*0.05
correct = (disp_true[index[0][:], index[1][:], index[2][:]] < 3) | (disp_true[index[0][:], index[1][:], index[2][:]]<p5)

Hi, @Baboom-l
Thanks for pointing out the bug.  However, the 3px errors in the paper are calculated by the Matlab code from official KITTI site.
I suggest to change the line 128 with deepcopy, i. e., true_disp = copy.deepcopy(disp_true).


Enable Azure Active Directory Identity Protection

Step 2 should be click dashboard and then click Marketplace (when signing to the Azure portal you are presented with the Azure Services page). Minor I know. Also, step 3 (selecting the Identity category) doesn't result in including in the filter Azure AD Identity Protection (even if you click -> see more). However, you can search for it. Many thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 824cd4c8-3448-e778-1907-3a3271d0b38f
Version Independent ID: fd77dfac-019c-8ffa-1530-7c92dfbda415
Content: Enabling Azure Active Directory Identity Protection
Content Source: articles/active-directory/identity-protection/enable.md
Service: active-directory
Sub-service: identity-protection
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@PatrickLownds Thanks for your feedback! We will investigate and update as appropriate.


Bump to latest iohub

Bumping iohub so that napari-iohub can live in the same environment as iohub.
Includes minor import changes to satisfy iohub and pydantic warnings.
I know that users install from main, so feel free to delay this PR.

@talonchandler thanks! I have similar changes in #13 but I'm happy to merge this first.


Verbose implementation do not support common use scenarios.

I was looking at the changelog and saw something was done for verbose.
Can't the flag be passed down normally through the calling cmdlet ?
For instance,
Get-Secret -Name 'SuperSecret' -AsPlainText -vault MyVault -Verbose

I would expect that verbose flag to be passed down to the implementing module, not a flag that need to be defined in VaultParameters. (And following that logic, it should be possible to pass the -debug flag in the same manner).
With #66 , it seems that I need to unregister the vault, then register it again with verbose, then unregister / re-register it again when done. It feels like we're going the long way around.

Yes, the -Verbose flag is now passed to the extension vault cmdlets as part of the AdditionalParameters parameters.  This is done automatically, you do not have to add them to the VaultParameters field when registering an extension vault.
However, you do have to look for the Verbose parameter in AdditionalParameters in your extension vault cmdlets, and set $VerbosePreference accordingly so that verbose output is written.

@PaulHigin Yup, I see that now and it work as expected.
Maybe it should be added in the DesignDoc then ?
I edited the title of this ticket to reflect that need.

Fixed.


Term::size is broken on Windows

Since the update to the terminal-size crate, Term::size and Term::size_checked are broken on Windows due to https://github.com/eminence/terminal-size/issues/18
Term::size_checked returns None on interactive terminals. It returns (1, 1) if no terminal is attached to STDOUT.
Also, note that there is another change in behavior (which is probably good): After https://github.com/eminence/terminal-size/issues/18 has been fixed, terminal-size reports a terminal size which is larger by one in both height and width (https://github.com/eminence/terminal-size/blob/e9a708e15a5e582aad03855e40d1f41b6b01c5f0/src/windows.rs#L38-L39). The returned size is correct. The value returned by console 0.10 and before was too small.

Yup, it was one of the reasons I decided to delegate this to terminal-size crate. I saw the logic wasn't being maintained in this crate and knew that the above crate fixed the offset by 1 error. IMO It's better if the community focuses on fixing one crate instead and use it.


nf12 docs

Docs for NF12.  Backported fixes to  NF8/11.

 NF12 docs

Thanks for the review! I've fixed up the small changes. It's funny how the diffs make it look like the file mentions generators etc.. but that's just the diff between nf11 and nf12. Fortunately the edits were much simpler!


Wait containers stuck in pod watching 403

Summary
What happened/what you expected to happen?
k3d cluster create k3s-default
k create namespace argo
k apply -n argo -f manifests/install.yaml
k edit configmap -n argo workflow-controller-configmap # update configmap to use k8sapi
k create -f https://raw.githubusercontent.com/argoproj/argo-workflows/master/examples/resubmit.yaml

> k get pods -n argo
NAME                                   READY   STATUS     RESTARTS   AGE
workflow-controller-64c8b7c5b7-dtlzh   1/1     Running    0          14m
argo-server-7fd688c895-sm7x6           1/1     Running    1          14m
resubmit-d8knp-765531043               1/2     NotReady   0          9m54s
resubmit-d8knp-3592006595              1/2     NotReady   0          9m54s
resubmit-d8knp-782308662               1/2     Error      0          9m54s

> k logs -n argo resubmit-d8knp-3592006595 main
exiting with code 0

> k logs -n argo resubmit-d8knp-3592006595 wait
time="2021-03-11T20:17:07.925Z" level=info msg="Watch pods 403"
time="2021-03-11T20:17:07.926Z" level=info msg="Watch pods 403"
time="2021-03-11T20:17:07.928Z" level=info msg="Watch pods 403"
time="2021-03-11T20:17:07.928Z" level=info msg="Watch pods 403"

> k logs -n argo resubmit-d8knp-782308662 main
exiting with code 1

> k logs -n argo resubmit-d8knp-782308662 wait
time="2021-03-11T20:17:07.925Z" level=info msg="Watch pods 403"
time="2021-03-11T20:17:07.926Z" level=info msg="Watch pods 403"
time="2021-03-11T20:17:07.928Z" level=info msg="Watch pods 403"
time="2021-03-11T20:17:07.928Z" level=info msg="Watch pods 403"

Diagnostics
What Kubernetes provider are you using?
k3d version v3.4.0
k3s version latest (default)

What version of Argo Workflows are you running?
v3.0.0-rc6 or latest from master branch with k8sapi
Paste the logs from the workflow controller:
kubectl logs -n argo $(kubectl get pods -l app=workflow-controller -n argo -o name) | grep ${workflow}

time="2021-03-11T20:05:56.707Z" level=info msg="Detected ConfigMap update."
 Give it a 👍. We prioritise the issues with the most 👍.

Does your SA have ‘watch pod’ as well as ‘get pod’?

I applied https://github.com/argoproj/argo-workflows/blob/master/manifests/install.yaml directly with a fresh namespace and k3d cluster.

Does your SA have ‘watch pod’ as well as ‘get pod’?

Actually good reminder. I added serviceAccountName: argo and then everything works as expected now.

On the other hand, emissary executor has better logs pods "resubmit-qpft5-2434376666" is forbidden: User "system:serviceaccount:argo:default" cannot patch resource "pods" in API group "" in the namespace "argo"

Would you like to submit PR to improve messaging?

Sure

This has been fixed in v3.0.0-rc9


Icon in top left corner is misaligned

The picture below shows what I mean.
I've made a mockup with a slightly larger icon(36x36 pixels), in contrast to the original (28x28 pixels), as I think it looks better with a larger icon to match the size of the side-panel icons.

@Splike Is the left side what you are seeing in the product today? If so, do you always see this or is this after some resizing or some other relayout behavior?

Yes, this is what I see in the product today (1.27.2), where I have set "window.titleBarStyle": "custom" and no additional options have been set or resizing done.

I've had to reinstall VS code and now mine does look like your picture.
But would it still be possible to align  and center the icon, like in my right picture?

@Splike Thanks for the suggestion, I'll try it out and get back.


feat(utils): use multiple sources to download snark artifacts

I don't really know why we see bad gateway errors in the ci when attempting to fetch the artifacts.
https://github.com/privacy-scaling-explorations/zk-kit/actions/runs/8837164770/job/24265411154#step:9:666
As an improvement (hopefully fix), I am thinking about a retry mechanism:

use [[unpkgCdn, jsdelivrCdn], github] urls list
randomly sort the cdns part
try the next one if the 1st cdn tried failed
repeat
the ultimate fallback would be the snark artifacts github repo raw url. We can leverage the release tags urls, ex: https://github.com/privacy-scaling-explorations/snark-artifacts/tree/<EMAIL_ADDRESS>Luckily the url structure on github also matches what unpkg and jsdelivr use.

The random sorting would happen on each download attempts (whether it is for a a different proof, or different artifact for a same proof...), which should protect us against throttling (if that is the root cause of the bad gateway issues...)

Benchmark results
https://github.com/privacy-scaling-explorations/snark-artifacts/pull/23

I'm following your work here closely, because I'm working on something similar in the Zupass repo.  We're going to have some slightly different concerns and trade-offs, but I think a similar artifact-distribution scheme will work for us.  I'm most focused on artifact download in-browser, while for Node servers and utests we're more likely to use local copying, or NPM devDependencies.
A heads-up on something I learned in my own testing, in case you haven't tested your solution in-browser yet.  GitHub's raw links behave differently in a browser depending on whether you're going via github.com or githubusercontent.com, which set a different Access-Control-Allow-Origin header.  Below are two equivalent URLs for one of my artifacts I'm testing.  My tests are for files in the repo itself, rather than release packages, but I suspect the behavior will be similar:
https://github.com/proofcarryingdata/snark-artifacts/raw/artwyman/experimental/packages/proto-pod-gpc/proto-pod-gpc_1o-1e-5md-1x10l-2x2t-vkey.json
https://raw.githubusercontent.com/proofcarryingdata/snark-artifacts/artwyman/experimental/packages/proto-pod-gpc/proto-pod-gpc_1o-1e-5md-1x10l-2x2t-vkey.json
The first URL redirects to the second, but only the second one can be successfully accessed in a browser (outside of a github.com page).
The minimal documentation about raw downloads from GitHub makes me nervous about relying on it too heavily, as it could have rate-limits which aren't published.  It seems it's widely used in the community, and it is mentioned (in passing) as "always available" in this doc article https://docs.github.com/en/repositories/creating-and-managing-repositories/repository-limits
which is about limits, but doesn't say anything about download bandwidth limiting or rate limiting.

Thank you very much @artwyman 🙏🏽

@artwyman I was waiting for #275 to merge before getting back to working on this.
Thanks for sharing what you experienced with github URLs!

in case you haven't tested your solution in-browser yet

I hadn't tested dls in browser environments at all actually. I ll try to do some tests myself too.
I had just used a shell script to test/benchmark the downloads:
https://github.com/privacy-scaling-explorations/snark-artifacts/blob/main/scripts/bin/benchmark
https://github.com/privacy-scaling-explorations/snark-artifacts/pull/23

about raw downloads from GitHub makes me nervous about relying on it too heavily

If GitHub is 1 of 3 sources, probably that's ok in the beginning?
We would consider this an initial solution.
I am starting to wonder whether we should not move all this logic server side later:

Have our own delivery service like a cloudflare worker (or equivalent like amazon lambda@edge...).
The logic to try to fetch from several sources would be implemented server side in that worker

The benefits would be:

Simplify client side code: fetching logic is implemented once in the worker
Better performance and less requests: because of more efficient caching and fancy features like requests collapsing
More scalable

Wouldn't this be a more robust mitigation in the long term against the rate limiting challenge we are facing when attempting to download those relatively big artifacts files.

Would your theoretical server-side solution need to "download" at all, or just be deployed with artifacts pre-installed?  That's likely what I'll end up doing with the Zupass server, with the artifacts being delivered to the build+deploy system as an NPM package (a devDependency).  Of course, that only allows serving up a single version, which is what the Zupass web client will need.
If you need to support multiple versions and don't want to store them all on your own server the answer might be more complicated.  It's the separately-versioned cases for 3rd-party developers, and also for Zupass development during experimental phases where I'm anticipating using unpkg or GitHub, so I'm hopeful the usage rate won't lead to throttling in the near term.
But I know our requirements and trade-offs are different, so I'm sharing all this as useful context, not to say it's what you need to do as well.  I'll keep an eye on what I can learn from your experience going forward too.

Would your theoretical server-side solution need to "download" at all, or just be deployed with artifacts pre-installed?

I am still thinking about it ^^. There are indeed different solutions and trade offs I guess.
I invite you to continue discussing there if you get further ideas/thoughts as you've been sharing valuable inputs :pray:
https://github.com/privacy-scaling-explorations/snark-artifacts/issues/38

support multiple versions

yes that's a rather strong requirement we want to fulfill.


C depth example "unsupported descriptor subtype: 3" error

Required Info

Camera Model
{ D415 }

Firmware Version
{<IP_ADDRESS>}

Operating System & Version
{Mac OSX High Sierra 10.13.6}

Platform
Mac

SDK Version
{ legacy / 2.14.1 }

Language
{C }

Segment
{Other }

Issue Description
I am having trouble getting the Realsense camera to work with the C depth and C distance examples. The camera works with other code examples i.e RealSense viewer, point cloud. I am using USB 2.0 to interface with the camera.
Here is the output.
There are 2 connected RealSense devices.
Using device 0, an Intel RealSense D415
Serial number:<PHONE_NUMBER>91
Firmware version: <IP_ADDRESS>
unsupported descriptor subtype: 3
unsupported descriptor subtype: 3
unsupported descriptor subtype: 3
unsupported descriptor subtype: 3
Segmentation fault: 11
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.
Process completed
From what I gather looking at the program the error occurs when the device pipeline is created.

[Realsense Customer Engineering Team Comment]
hi @jlbeebout,
are you connecting 2 camera to PC USB2 port intentionally?
since other examples are working i think this should be issue of support formats under USB2, can you please try to connect to USB3 port and see if the examples are good?

I only have one RealSense camera attached to the computer. For some reason it is displaying that there are two connected. I unfortunately don't have a computer with USB 3.0. I do have a Raspberry Pi on order. The project I am working on requires USB 2.0 and the C examples to work together. I am testing it right now on my Mac before I try and use the C distance example on the Pi.

[Realsense Customer Engineering Team Comment]
hi @jlbeebout,
i see, so do you always see 2 camera connected on your Mac?
please make sure when fail, the selected camera is same as other sample that works.
another thinking is the resolution for USB2 is limited, some samples are specified one resolution only, so this maybe the root cause.

[Realsense Customer Engineering Team Comment]
hi @jlbeebout,
unfortunately my Mac have only USB3 port, so i verified the sample on windows, and it's working good on D415+USB2 port, so would like to know if you load any preset before testing C samples?

[Realsense Customer Engineering Team Comment]
Hi @jlbeebout,
Still need support for this topic? If not, will close this.

No I was able to get what I needed by using a different computer. Thank you!


Update README for Docker usage

Summary
Adding a section about running using docker to the README
Description for the changelog
Closes: #71
Using the .env configuration does not work with the --env-file flag when running the docker container.  Mounting the .env file works as expected.  This PR adds a note to the README to address this.
Other info
N/A

If you're good with it I'll merge after the new checks complete.

All looks good, so the merging honour is yours :-)


Add Syslog TCP framing documentation to README

This documents the new TCP framing option introduced in #472

Thanks!


Feature Request: "Model Zoo" for quantization

TensorRT-LLM has great potential for allowing people to run larger models efficiently with limited hardware resources. Unfortunately, the current quantization workflow requires significant computational resources. An int8/FP8 quant of a 70B model would easily fit in 2x RTX 6000s, but performing such quantization with that hardware would be impossible, as the recommended config is 4x A100/H100 for calibration.
The only solution for those of us without this hardware is renting big instances on AWS/etc., but this seems wasteful for every user to perform individually. Could there be a "model zoo" for the repo where these quants can be stored, similar to how quants are published on Huggingface?
I understand there may be licensing concerns associated with hosting weights for models like Llama. Instead, could we host pre-computed activation scales that can be used to compute quantized weights without excessive GPU memory? I wouldn't see any licensing issue with such a solution.

Hi @byshiue, I agree this would be nice as an open-source collaborative effort. Unfortunately, the community is limited here, as quantization for most formats like FP8 and per-channel smoothquant is now done in the closed-source NVIDIA modelopt tool. A limited subset of quantization is still open-source as part of TRT-LLM, but I'm wondering if that too will be migrated to modelopt in the near future.
If you prefer I could re-file this issue on the modelopt examples repo if you think that is more appropriate.

I could upload weight quantized on Huggingface like The-bloke.
I might start this upcoming weekend.

Uploading.
First model card !!

TheFloat16/Llama3-70b

@hchings Any update on this? I haven't seen many other models published on Huggingface aside from the ones by @matichon-vultureprime

Hi @atyshka, we have a few llama models like https://huggingface.co/nvidia/Llama-3.1-405B-Instruct-FP8 uploaded, and we're uploading more (e.g., Medusa checkpoint).
Legal clearance took a while.


Failure to parse request in Kitura-net

In BluePic, we had this issue raised: https://github.com/IBM-Swift/BluePic/issues/306
I was able to reproduce the issue in BluePic and it consistently gives me the following error:
ERROR: parse IncomingHTTPSocketProcessor.swift line 117 - Failed to parse a request

That error appears when trying to post an image in BluePic and sometimes when trying to login, preventing these actions from succeeding.
These errors only happen with the 0.24 releases of the Kitura suite, using the older 0.22 releases, everything works great. Since we've made no code changes, we are concluding right now that our packages are causing this error. For reference, here are the packages I tested that worked and didn't work:
Succeeds
    .Package(url: "https://github.com/IBM-Swift/Kitura.git", majorVersion: 0, minor: 22),
    .Package(url: "https://github.com/IBM-Swift/Kitura-CouchDB.git", majorVersion: 0, minor: 22),
    .Package(url: "https://github.com/IBM-Swift/Swift-cfenv.git", majorVersion: 1, minor: 4),
    .Package(url: "https://github.com/ibm-bluemix-mobile-services/bluemix-simple-http-client-swift.git", "0.4.1"),
    .Package(url: "https://github.com/ibm-bluemix-mobile-services/bluemix-objectstorage-swift-sdk.git", majorVersion: 0, minor: 5),
    .Package(url: "https://github.com/ibm-bluemix-mobile-services/bms-mca-kitura-credentials-plugin.git", "0.3.2"),
    .Package(url: "https://github.com/ibm-bluemix-mobile-services/bms-pushnotifications-serversdk-swift.git", majorVersion: 0, minor: 3)

Fails
    .Package(url: "https://github.com/IBM-Swift/Kitura.git", majorVersion: 0, minor: 24),
    .Package(url: "https://github.com/IBM-Swift/Kitura-CouchDB.git", majorVersion: 0, minor: 24),
    .Package(url: "https://github.com/IBM-Swift/Swift-cfenv.git", majorVersion: 1, minor: 4),
    .Package(url: "https://github.com/ibm-bluemix-mobile-services/bluemix-objectstorage-swift-sdk.git", majorVersion: 0, minor: 5),
    .Package(url: "https://github.com/ibm-bluemix-mobile-services/bms-mca-kitura-credentials-plugin.git", majorVersion: 0, minor: 3),
    .Package(url: "https://github.com/ibm-bluemix-mobile-services/bms-pushnotifications-serversdk-swift.git", majorVersion: 0, minor: 3)

I see, good to know. We will most likely revert to the 0.22 versions for now.

@tfrank64 Is it possible to get the URL that was failing to parse?

@tfrank64 Is it possible for me to easily set up locally enough to run the failing request?

At least one place it fails is with this endpoint http://localhost:8090/users. The app tries to create a user before posting an image.

@shmuelk there is a somewhat easy way to get setup, you can follow this wiki to get the right credentials in your local BluePic: https://github.com/IBM-Swift/BluePic/wiki/Configuration-Process-for-Internal-Developers. Also, make sure your Package.swift looks like the one that fails, mentioned above. After that, you should be able to run locally and see it fail when posting an image.

@shmuelk Any updates on this or were you able to reproduce the issue?

I had a lot of trouble compiling the iOS code. I have XCode 8 beta 6 installed. I donloaded XCode beta 3, but I haven't gotten around to installing it and trying to build your iOS code.

@rob-deans Were you looking at this?

@ianpartridge I think the current plan is for us to update BluePic to the latest version of Kitura to test if the issue got resolved at some point.

@rob-deans So we updated BluePic-Server to use Kitura 0.32.0. Unfortunately, the issue persists when trying to post an image. The error is slightly different now:
ERROR: parse IncomingHTTPSocketProcessor.swift line 124 - Failed to parse a request. Parsed fewer bytes than were passed to the HTTP parser
Hitting the http://localhost:8090/users endpoint through something Postman works great.

To be clear, the issue happens when creating a user, which happens right before posting an image. For some reason I can get a curl request to work, but it fails when coming from the iOS app. Here is an example curl request:
curl -X POST -H "Content-Type: application/json" -H "Cache-Control: no-cache" -d '{ "name": "<myName>", "_id": "<userID>" }' "http://localhost:8090/users"

I just tagged Kitura-net 1.0.1 which includes the fix for issue IBM-Swift/Kitura#734 which we believe fixes the issue here as well. Please test again, make sure that you refetch Packages.

@shmuelk @rob-deans I tested things out, seems to be working great now! Thanks


Unpleasant flash of styles while in dark mode, navigating between pages

When opting into dark mode via button toggle, then navigating from page to page, the theme defaults to light for a split second. Therefore, it creates an unpleasant flash of bright light. This is apparent on slow connections. Test it in devtools by switching network connection to Fast 3G, then navigate from page to page.
Watch this screencast: https://cloudup.com/cdNhCTAgHmM
While I'm not using your darkmode component in my project, I ran into a similar situation. I found setting the JS script to is:inline instead of default or module helped me prevent the flash of unwanted style in my case.

Hey @djmtype, thank you for submitting this issue and taking the time to explain it so well with an additional screencast. It is much appreciated 🙂 I'll take a look at it and I'll test your suggested solution of setting the script to is:inline.


BTNApplicationContinueUserActivityRestorationHandler crash

Since updating to version 0.12.27 we've been getting a lot of crashes related to BTNApplicationContinueUserActivityRestorationHandler
Signal: SIGSEGV: SEGV_ACCERR at 0x616fabeb8
Reason: objc_msgSend() selector name: setResponseSerializer:
Here is a stack trace of one of the crashes: http://pastebin.com/1jaB9pRt

Sorry wrong repo :)


tsserver and Promise.all = boom

TypeScript Version:  2.5.2 / nightly 19 september 2017
Note: It's only my guess that the culprit is tsserver. tsc with/without watch mode didn't exhibit the issue but using either of the two main webpack loaders did. VSCode also reports no error.
Code
type Lol = { code: string, label: string, lol: string }

const p1 = Promise.resolve({ code: '', label: '' })
const p2 = Promise.resolve({ code: '', label: '', lol: '' })

Promise.all([
  p1,
  p2
])
.then(([_, b]) => {
  const z: Lol = b
  console.log(z)
})

Expected behavior:
This snippet should always compile.
Actual behavior:
With tsserver, it compiles the first time only. Any incremental recompilation will fail with this error, which obviously makes no sense:
ERROR in ./main.ts
(12,9): error TS2322: Type '{ code: string; label: string; }' is not assignable to type 'Lol'.

ERROR in ./main.ts
(12,9): error TS2322: Type '{ code: string; label: string; }' is not assignable to type 'Lol'.
  Property 'lol' is missing in type '{ code: string; label: string; }'.

I created a tiny repo that showcases this behavior:
git clone https://github.com/AlexGalays/tsserver-bug-repro-1.git
cd tsserver-bug-repro-1
yarn
npm run watch

Then add a ; at the end of main.ts or any other non structural change and the above errors will appear.
It's a blocker for us because we'll soon have hundreds of these and it will be hard to visually sort fake errors from real errors.
Of course, I encountered the issue while using Promise.all but the source of the bug could be unrelated.

The issue seems to be loader related. i do not see the same behavior with tsc --w.


Saving new file: the save-dialog doesn't use last working directory

VSCode Version: Code 1.17.1 (1e9d36539b0ae51ac09b9d4673ebea4e447e5353, 2017-10-10T14:21:18.489Z)
OS Version: Linux x64 4.13.5-200.fc26.x86_64
Extensions:

Extension
Author (truncated)
Version

contextualduplicate
laf
0.2.0

MDTools
sea
1.0.1

Steps to Reproduce:

Make new file.
Attempt to save.
Save-dialog always uses home directory (e.g: /home/user/). It doesn't use current working directory (for the file next to it), or last working directory (if there are no files opened next to it).

Reproduces without extensions: Yes
Would you please check?
Thank you,

https://github.com/Microsoft/vscode/issues/22697


CASE storage: FabricSession() key is slightly inconsistent

Problem
DefaultStorageKeyAllocator.h uses the key FabricSession() formatted as "f/%x/s/%08" PRIX32 "%08" PRIX32 which is slightly inconsistent with the convention used for all the other numeric keys that do not use zero padding and do not use uppercase hex. For fabric 1/1 we end up with the key "f/1/s/0000000000000001".
Proposed Solution
Use "f/%x/s/%" PRIx64 which for the example above will result in "f/1/s/1".

Use "f/%x/s/%" PRIx64 which for the example above will result in "f/1/s/1".

We can't use PRIx64 on devices....  not all libcs support it.

Closing as per above.


Remove unneeded dev dep.

This PR removes an unneeded dev dep.

Ping.

Ping.

Ping.

Would be nice to get it merged

+1

Thanks so much for creating this PR!!
Sorry this never got merged, I have created a new PR #138 which implements this change.
I would merge this PR but it has a merge conflict.

Better late then never :sweat_smile:


V6 address design

This has been hanging around an old branch of mine forever. Since we're not doing it soon but no-one told me it was dumb, I'd rather have it in the main tree; linked the "postponed" category.

This change is


adds ploomber cloud deployment

Pull Request Template
📝 Summary
documents ploomber cloud as an option for deployment

🔍 Description of Changes

changed the guides/deploying indes and added a new subpage
🛠 Additional Information

📋 Checklist Before Submitting

[ ] I have read the contributor guidelines and the Pull Request section.
[ ] This PR fixes an issue (If applicable, specify issue number #).
[ ] This change was discussed or approved through an issue or the community discussions (Please provide a link if applicable).
[ ] I have added necessary tests for the changes made.
[ ] I have run the code and verified that it works as expected.

🧩 Related Issues

📜 Who Can Review?

@akshayka OR @mscolnick

I have read the CLA Document and I hereby sign the CLA
recheck

I have read the CLA Document and I hereby sign the CLA

recheck


FwQueryConfig: allow extra ecus for specified platforms

It would be a good idea to start using these extra ecus to fingerprint while in data collection mode, but only for newer platforms. Opening to finish later

This enables fuzzy fingerprinting for 459707e5f696e897 which shares or skips every ECU except the engine (with hybrid that makes two, the minimum).


Ashraf branch

Ran your branch and errors appeared please fix so I can push.

Could not figure out issue with error, it is running fine with me


Update random quote api url in 05-http-requests example

The 05-http-requests example is currently not working due to the https://api.quotable.io/random api url being out of date. This PR replaces it with https://dummyjson.com/quotes/random

Ohhh thank you, great catch!


opencollective.dev domain

opencollective.dev

The .dev domains are already out in the public.
Most of the giants are already available on .dev domains sharing their awesome resources, projects, documentation, and whatnot. mdn.dev, nodejs.dev, women.dev, github.dev to name a few.
What resources/website we want to share?
We can share our documentation through that domain as well or sharing stories about our collectives and other entities.
Is it available?
YES
How?
https://get.dev is the place google is sharing these domains via various partners.

@znarf @piamancini :point_up:

Thanks for the heads -up @maddhruv we purchased it already.
Closing issue.


Fix #22: Add printc() function

Added std.printc() function. It behaves identically to std.print except it does not append a newline.
Added basic unit tests for printing various built-in types.

Looks great! I've left a minor comment at #22 , let me know what you think!

Added a commit for this ^^. Modified all existing uses of print to println in the repo, converted printc to print. This affects the tests and examples, but not the docs.


AnimatedVisualPlayer - Pause animations when suspended and maybe when minimized

Describe the bug
Follow XAML policy for pausing animations that cannot be seen. Currently once the animation starts we will cause DWM to wake up 60 times a second even if the app got suspended.
Steps to reproduce the bug

Expected behavior

Screenshots

Version Info

NuGet package version:

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop

Mobile

Xbox

Surface Hub

IoT

Additional context

Unless I am missing something, we already are listening to suspended/resume and stop the animation if needed:
https://github.com/microsoft/microsoft-ui-xaml/blob/36fb735b62b87f9bc1c0f6928d99df77e56abfb7/dev/AnimatedVisualPlayer/AnimatedVisualPlayer.cpp#L292-L315
Is there an easy way to check whether this is behaving correctly, or do you have scenario where this was not the case @ajbennet ?


Implement Background Element Components (Issue #18)

I've made the website's background adapt to different screen sizes for a better user experience. To speed things up, I created a (Layout.jsx) file to avoid repeating the same background code over and over. I also combined the navigation and footer into this file to keep things tidy and avoid extra work. This change makes the code cleaner, faster, and easier to manage for everyone working on the project.

I've made the website's background adapt to different screen sizes for a better user experience. To speed things up, I created a (Layout.jsx) file to avoid repeating the same background code over and over. I also combined the navigation and footer into this file to keep things tidy and avoid extra work. This change makes the code cleaner, faster, and easier to manage for everyone working on the project.

Hi, Thank you for your excellent contribution! I appreciate the work you've done to enhance the website's background adaptability and streamline the code with the new Layout.jsx file. Combining the navigation and footer into this file is a smart move that indeed keeps things tidy and efficient.
I noticed that a .DS_Store file was accidentally pushed with your changes. Please remove that file from your pull request.
Additionally, for better support of a dark theme, could you create root variables for the element colors in index.css? If you need to use new colors that are not yet defined in the root variables, feel free to add them as necessary.
Thanks again for your hard work and attention to detail. Your efforts are greatly appreciated!

'.DS_Store' file still in the commit.

I attempted to delete the file, and despite removing it from my local repository and committing the changes, the file persists in both the commit and the pull request. Can you delete the file after the merge?

Sure, I can delete the file after the merge. and don't forget to join our Discord community: https://discord.com/invite/kgJDWKj8


Use single library for generating mocks (mockery or gomock) but not both

Description
It is very confusing to have both in different parts of the application. I have a slight preference towards gomock, because it allows to write expectations in Golang instead of strings. But either one is fine.
Affected code
mockery is used in tortoisebeacon
gomock is used in activation and p2p

Let's use mockery since we are already using stretchr/testify, and mockery just generates mocks for it.
cc @nkryuchkov

Actually gomock is definitely better.

you have normal autocomplete when defining expectations (no need to double check that string matches the method name)
if you want to have side-effects gomock will dispatch arguments into correct types automatically (no need to cast interface{} by yourself)


chore: update SECURITY.md

Description

Make SECURITY.md reflect current example of TRG 7.01 pointing to the GitHub Security Tab instead of directly to Eclipse

Pre-review checks
not applicable

@pablosec please edit the PR to point at the 'develop' branch.

@borisrizov-zf done. But I don’t fully understand, how the two other commits, not related to SECURITY.md, got into this PR...?

@pablosec We use a bot for semantic releases and it adds some CHANGELOG stuff and updates the main Helm chart.

@pablosec can you rebase, I've merged some other branches and now there are conflicts. Thanks!


iOS target

Hello
I got the following error when I'm compiling to ios targets:
error[E0412]: cannot find type `TryFromBigIntError` in crate `num_bigint`
   --> /Users/romansztergbaum/.cargo/git/checkouts/tezos-rust-sdk-1c87e5341bf84ccf/8885fac/tezos-core/src/error.rs:38:29
    |
38  |         source: num_bigint::TryFromBigIntError<num_bigint::BigInt>,
    |                             ^^^^^^^^^^^^^^^^^^ help: a struct with a similar name exists: `ParseBigIntError`
    |
   ::: /Users/romansztergbaum/.cargo/registry/src/github.com-1ecc6299db9ec823/num-bigint-0.4.3/src/lib.rs:141:1
    |
141 | pub struct ParseBigIntError {
    | --------------------------- similarly named struct `ParseBigIntError` defined here

error[E0412]: cannot find type `TryFromBigIntError` in crate `num_bigint`
   --> /Users/romansztergbaum/.cargo/git/checkouts/tezos-rust-sdk-1c87e5341bf84ccf/8885fac/tezos-core/src/error.rs:41:29
    |
41  |         source: num_bigint::TryFromBigIntError<num_bigint::BigUint>,
    |                             ^^^^^^^^^^^^^^^^^^ help: a struct with a similar name exists: `ParseBigIntError`
    |
   ::: /Users/romansztergbaum/.cargo/registry/src/github.com-1ecc6299db9ec823/num-bigint-0.4.3/src/lib.rs:141:1
    |
141 | pub struct ParseBigIntError {
    | --------------------------- similarly named struct `ParseBigIntError` defined here

error[E0277]: the trait bound `i64: From<BigUint>` is not satisfied
   --> /Users/romansztergbaum/.cargo/git/checkouts/tezos-rust-sdk-1c87e5341bf84ccf/8885fac/tezos-core/src/types/mutez.rs:157:23
    |
157 |         Ok(Self(value.try_into()?))
    |                       ^^^^^^^^ the trait `From<BigUint>` is not implemented for `i64`
    |
    = help: the following other types implement trait `From<T>`:
              <i64 as From<NonZeroI64>>
              <i64 as From<bool>>
              <i64 as From<i16>>
              <i64 as From<i32>>
              <i64 as From<i8>>
              <i64 as From<u16>>
              <i64 as From<u32>>
              <i64 as From<u8>>
    = note: required for `BigUint` to implement `Into<i64>`
    = note: required for `i64` to implement `TryFrom<BigUint>`
    = note: required for `BigUint` to implement `TryInto<i64>`

error[E0277]: `?` couldn't convert the error to `error::Error`
   --> /Users/romansztergbaum/.cargo/git/checkouts/tezos-rust-sdk-1c87e5341bf84ccf/8885fac/tezos-core/src/types/mutez.rs:157:33
    |
157 |         Ok(Self(value.try_into()?))
    |                                 ^ the trait `From<Infallible>` is not implemented for `error::Error`
    |
    = note: the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait
    = help: the following other types implement trait `From<T>`:
              <error::Error as From<FromUtf8Error>>
              <error::Error as From<ParseBigIntError>>
              <error::Error as From<ParseIntError>>
              <error::Error as From<String>>
              <error::Error as From<TryFromIntError>>
              <error::Error as From<[type error]>>
              <error::Error as From<bs58::decode::Error>>
    = note: required for `std::result::Result<Mutez, error::Error>` to implement `FromResidual<std::result::Result<Infallible, Infallible>>`

Some errors have detailed explanations: E0277, E0412.
For more information about an error, try `rustc --explain E0277`.
error: could not compile `tezos-core` due to 4 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `tezos-core` due to 4 previous errors

I need to support macabi for cross-platform, so far it's only supported on nightly:
command used:
cargo +nightly build -Z build-std --target aarch64-apple-ios-macabi --target x86_64-apple-ios-macabi --release

Currently, we do not support these targets. num_bigint seems to have some limitations because they focus on performance instead of being more agnostic.
@m-kus has integrated ibig-rs successfully, which seems to fix the compatibility issues you are facing.
Give it a try: https://github.com/m-kus/tezos-rust-sdk/pull/1
On our side, we still need to evaluate the ibig-rs migration. Hopefully, we will merge Michael contribution soon.

Yes, sorry, I will allocate some time soon to backport all the changes I made.
Regarding the ibig crate specifically, there's a follow-up refactoring changing the underlying representation of Nat and Int (UBig and IBig instead of String) and unification of bigint field types in all crates (especially tezos_rpc).


Question - Is there a way to disable printing cloudprobe metrics to sdtout?

I have a log collector that captures and I would like to avoid filtering it there, but instead, disable it in cloudprobe side, because metrics are escraped by prometheus already
Thanks

Yes. Cloudprober has this concept of surfacers: https://cloudprober.org/surfacers/overview/. By default it enables "prometheus" and "file" surfacers, and "file" surfacer writes to stdout by default. You can disable metrics to stdout by adding this to your config:
surfacer {
  type: PROMETHEUS
}

Explicitly specifying a surfacer disables the default behavior.

Thank you @manugarg
closing it


Block download protocol

This solves #123

block download protocol
tests using direct and connect functions

@avieth could you review it?


[docs][base-ui] Preview code is not in sync with selected styling option code

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example: https://mui.com/base-ui/react-menu/#basics
Current behavior 😯
As you can see preview code is not changing when option is changed from system to tailwind or css
https://github.com/mui/material-ui/assets/60743144/2fb02ec4-84f0-438a-9588-ed7b3a682c1a
Expected behavior 🤔
Preview code should be in sync with selected styling option

I was reviewing #38548, which aimed to address this problem. I believe the issue arises because preview files aren't generated for JSX code exceeding 16 lines, as indicated in the script.
I also observed that the preview functionality now functions correctly for the Tailwind option after the changes made in #38618. However, it still doesn't work for Plain CSS, likely because the returned JSX code exceeds 16 lines for it.


I have no idea how to use SacanaWrapper and PluginManager

So, as I said in my previous post, I was trying to mess with the Hex Code of the script from ToToNo (Steam), but I had some issues when showing the letters in the textbox ingame, so I was wandering around here to find a solution and found out about your plugin NUTEditor, and I don't know how to use it or download it, so I tried to download the PluginManager and see how it goes

When I run it, it appears an error message (sorry for the different language if anyone else's reading it xd)

If you need the details attached, just reply
And when I click continue, this appears

By the way, the Plugins file is empty, should it be supposed to have anything inside?
As I read another Issue question about a similar problem, I understood I needed to Drag and Drop the .nut file on the StringTool.exe to be able to edit it, but when I do it, it happens the same as my last problem with NPK3Tool, it won't open, it appears that something opened in the taskbar but it closes instantly
If I'm correct about this NUTEditor plugin, it should be a complement for another application, the problem is, I have no idea what to do with it
Again, sorry if I'm bothering and for my ignorance, it's all new for me, I just wanna translate the game's script and that's all.
Thank you for your patience.

By the way, another question I have about the script modification
I'm using just the raw "HxD" hex editor to do it, when I tried to translate the first line of the game, it needed an "é", but it somehow appears as a blank rectangle

I still don't know how the data structure works entirely, but by my tests I can't add more null bytes than the original amount, if I do it the entire text becomes rectangles or simply crashes
But as I searched in this forum, I see you actually translated that piece of the game too, and for you the accentuation works
Here's your own print of that

My question is, did you messed with the font of the game for that? or was it work of the NUTEditor?
Again, I'm a newbie, be patient with me please

I can't say what is wrong without the details content that you left out.
Also, just to be sure StringTool and PMan.exe should be extracted both in the same directory to works.

here is
Consulte o final desta mensagem para obter detalhes sobre como chamar a
depuração just-in-time (JIT) em vez desta caixa de diálogo.
************** Texto de Exceção **************
System.IO.FileNotFoundException: C:\Users\Erik\Documents\Translate tools\Plugin.Manager\SacanaWrapper.dll
em System.Diagnostics.FileVersionInfo.GetVersionInfo(String fileName)
em PMan.Updater.TreeRepositorie() na C:\projects\sacanawrapper\PMan\Update.cs:linha 20
em PMan.Main.Form1_Load(Object sender, EventArgs e) na C:\projects\sacanawrapper\PMan\Main.cs:linha 26
em System.Windows.Forms.Form.OnLoad(EventArgs e)
em System.Windows.Forms.Form.OnCreateControl()
em System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible)
em System.Windows.Forms.Control.CreateControl()
em System.Windows.Forms.Control.WmShowWindow(Message& m)
em System.Windows.Forms.Control.WndProc(Message& m)
em System.Windows.Forms.Form.WmShowWindow(Message& m)
em System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
************** Assemblies Carregados **************
mscorlib
Versão do Assembly: <IP_ADDRESS>
Versão do Win32: 4.8.9181.0 built by: NET481REL1LAST_C
Base de Código: file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/mscorlib.dll
PMan
Versão do Assembly: <IP_ADDRESS>
Versão do Win32: <IP_ADDRESS>
Base de Código: file:///C:/Users/Erik/Documents/Translate%20tools/Plugin.Manager/PMan.exe
System
Versão do Assembly: <IP_ADDRESS>
Versão do Win32: 4.8.9172.0 built by: NET481REL1LAST_C
Base de Código: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.dll
System.Windows.Forms
Versão do Assembly: <IP_ADDRESS>
Versão do Win32: 4.8.9181.0 built by: NET481REL1LAST_C
Base de Código: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.Windows.Forms.dll
System.Drawing
Versão do Assembly: <IP_ADDRESS>
Versão do Win32: 4.8.9037.0 built by: NET481REL1
Base de Código: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a/System.Drawing.dll
System.Configuration
Versão do Assembly: <IP_ADDRESS>
Versão do Win32: 4.8.9037.0 built by: NET481REL1
Base de Código: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a/System.Configuration.dll
System.Core
Versão do Assembly: <IP_ADDRESS>
Versão do Win32: 4.8.9181.0 built by: NET481REL1LAST_C
Base de Código: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.Core.dll
System.Xml
Versão do Assembly: <IP_ADDRESS>
Versão do Win32: 4.8.9037.0 built by: NET481REL1
Base de Código: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.Xml.dll
System.Windows.Forms.resources
Versão do Assembly: <IP_ADDRESS>
Versão do Win32: 4.8.9037.0 built by: NET481REL1
Base de Código: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms.resources/v4.0_<IP_ADDRESS>_pt-BR_b77a5c561934e089/System.Windows.Forms.resources.dll
mscorlib.resources
Versão do Assembly: <IP_ADDRESS>
Versão do Win32: 4.8.9037.0 built by: NET481REL1
Base de Código: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/mscorlib.resources/v4.0_<IP_ADDRESS>_pt-BR_b77a5c561934e089/mscorlib.resources.dll
************** Depuração JIT **************
Para habilitar a depuração just-in-time (JIT), o arquivo .config deste
aplicativo ou computador (machine.config) deve ter o valor
jitDebugging definido na seção system.windows.forms.
O aplicativo também deve ser compilado com a depuração
habilitada.
Por exemplo:

Quando a depuração JIT está habilitada, qualquer exceção sem tratamento
será enviada ao depurador JIT registrado no computador,
em vez de ser tratada nesta caixa de diálogo.
by the way, when you say stringtool and pman extracted both in the same directory you mean in the same folder, right?

Your problem is probabbly because you didn't extracted correctly, then yes, both files should be in the same folder.

Yeah it was my mistake, it's solved now
Now, I would like to go back to my second question, I see you translated yourself the start of the game as well, and you managed to place the accents, how did you do that? did you messed with the fonts? letters like "é", "ã" or "ô" don't show correctly for me ingame.
If you indeed messed with the fonts, can you give me advisement of how to do it? (I already decoded the font folder btw)

Only changing the font, it's impossible to put accents in the script without patch the engine.


CSS overrides don't seem to be taking effect when creating custom themes

[x] I have checked issues with bug label and found no duplicates

Expected Behavior
I would expect adding the path to a saas file in my custom themes directory would allow me to override some styles like it lets me override html by providing the path to a handlebars file.
Specifically I'm updating css in:
assets/css/layouts/_default.saas
Actual Behavior
No style changes are observed. It uses the same css
Steps to reproduce the bug

Create a theme directory
Add assets/css/layouts/_default.saas to it
Update styles in this file
generate output by calling typedoc path/to/src --theme path/to/custom-theme-directory
Observe no style changes from the file in step two are taking effect

Environment

Typedoc version: 0.15.0
Node.js version: 10.16.0
OS: windows

I'm not sure how TypeDoc would know to import _default.saas (also, shouldn't it be .sass?).
Unfortunately there isn't a way to directly include just extra CSS right now. Forking the default theme repo and modifying the theme inside it is probably your best bet.

Hi, thanks for your reply :)

Forking the default theme repo and modifying the theme inside it is probably your best bet.

That's sort of what I did, sorry if it wasn't very clear. I grabbed all the contents of this folder: https://github.com/TypeStrong/typedoc-default-themes/tree/master/src/default and stuck it in my project. Then called the cli with the path to that folder after modifying the _default.saas file. Am I missing something? Should I fork the entire thing and not just the default branch? A little surprised about how changes to mustache templates seem to be working though.

also, shouldn't it be .sass?
I'm not sure what you mean here. I marked the extension as .saas

@crhistianramirez You can definitely have a repo that only has one theme. With the default themes, there is a build process which creates the final files (the sass needs to be compiled for it to be used. Can you share the theme code you are working on?

@aciccarello  thank you for your attention. Here's a  minimal reproducible example
Steps to recreate:

git clone https://github.com/crhistianramirez/typedocs-styles-repro
cd typedocs-styles-repro
npm install
npm run repro to generate the docs
open the globals.html file

windows: start docs/globals.html
mac: open docs/globals.html

I made two overrides in custom-themes:

added partials/index.html and changed the text Index to CUSTOM_TEXT_ADDED_HERE
added assets folder as described in the custom theme guide and then changed the last line in custom-theme/assets/css/layouts/_default.saas which should update the breadcrumb separator to /CUSTOM_BREADCRUMB_SEPARATOR

The only change that I see is for the update to the handlebars file. I would expect my override to the saas file would also take place. Doesn't handlebars have to get compiled as well?

I'm not sure what you mean here. I marked the extension as .saas

saas != sass

Thanks for the repro. I pulled it down and now that I see what you are doing, it makes sense to me.
TypeDoc compiles the handlebars templates at documentation-time because each project is different, however the sass files don't change from project to project, so they are compiled before the theme is published. This makes it possible to gain a not-insignificant speed boost when rendering docs and removes the need to bundle a sass compiler.
If you want to use some custom sass, you'll need to compile it yourself before passing it off to TypeDoc. If you compile to custom-theme/assets/css/main.css, you will replace the default styles.

saas != sass

oops! 🤦♂

If you want to use some custom sass, you'll need to compile it yourself

I don't particularly care to use sass, I just thought that was the route I had to take to have custom styles. Is there a simpler way of providing custom styles that would allow me to avoid having to compile sass to css?

Yes, just create custom-theme/assets/css/main.css.

There isn't a built in way to just include some extra CSS. You could follow the above use, but then you'll remove all the default styling. If you don't want to do this you can create custom-theme/layouts/default.hbs with the default text and add <link rel="stylesheet" href="{{relativeURL "assets/css/custom.css"}}">, then adding custom-theme/assets/css/custom.css should let you include some custom CSS without overwriting the default.

Beautiful! Thank you so much for your help. I think it might be a good idea to add that to the theme guide. I will make a PR and tag you if that's ok

@Gerrit0  link to docs update PR: https://github.com/TypeStrong/typedoc-site/pull/19

Thank you @Gerrit0 and @crhistianramirez . I stumbled upon this discussion while going through the exact same issue. It is probably a good idea to merge this PR soon to update the docs