HDFS-17486. Unify the logic of the dumpXattrs method

Description of PR
For more information about this PR, please refer to the following issue：
[HDFS-17486] (https://issues.apache.org/jira/browse/HDFS-17486)
VIO: dumpXattrs logic optimization
How was this patch tested?
The test class TestOfflineImageViewer already exists.TestOfflineImageViewer.testPBImageXmlWriter()  method will  call dumpXattrs  when input parameter of dumpXattrs has xattrs.
For code changes:

[√] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[×] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[×] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
55m 38s

trunk passed

+1 :green_heart:
compile
1m 37s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 29s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 25s

trunk passed

+1 :green_heart:
mvnsite
1m 43s

trunk passed

+1 :green_heart:
javadoc
1m 20s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 58s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
4m  6s

trunk passed

+1 :green_heart:
shadedclient
49m 20s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
1m  0s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
compile
1m  5s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.

-1 :x:
javac
1m  5s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1.

-1 :x:
compile
0m 59s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.

-1 :x:
javac
0m 59s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 13s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 6 unchanged - 0 fixed = 8 total (was 6)

-1 :x:
mvnsite
1m  5s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
javadoc
1m  2s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 43s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

-1 :x:
spotbugs
1m  0s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
shadedclient
18m  4s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 59s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

144m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6797/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6797

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 08974c36b16d 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 93b3dd0f717464135f836b26813a9304e1f6b310

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6797/1/testReport/

Max. process+thread count
551 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6797/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 01s

No case conflicting files found.

+0 :ok:
spotbugs
0m 00s

spotbugs executables are not available.

+0 :ok:
codespell
0m 00s

codespell was not available.

+0 :ok:
detsecrets
0m 00s

detect-secrets was not available.

+1 :green_heart:
@author
0m 01s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m 00s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
89m 30s

trunk passed

+1 :green_heart:
compile
5m 53s

trunk passed

+1 :green_heart:
checkstyle
4m 37s

trunk passed

+1 :green_heart:
mvnsite
6m 43s

trunk passed

+1 :green_heart:
javadoc
6m 03s

trunk passed

+1 :green_heart:
shadedclient
151m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 39s

the patch passed

+1 :green_heart:
compile
3m 27s

the patch passed

+1 :green_heart:
javac
3m 27s

the patch passed

+1 :green_heart:
blanks
0m 01s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 27s

the patch passed

+1 :green_heart:
mvnsite
4m 25s

the patch passed

+1 :green_heart:
javadoc
3m 32s

the patch passed

+1 :green_heart:
shadedclient
160m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
5m 23s

The patch does not generate ASF License warnings.

428m 18s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6797

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
MINGW64_NT-10.0-17763 5ae641b16f00 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / 2f2b0c95e9420e8fbed97ce41534b0f9576b35b7

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6797/2/testReport/

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6797/2/console

versions
git=2.45.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

The test class TestOfflineImageViewer already exists.
TestOfflineImageViewer.testPBImageXmlWriter() method will call dumpXattrs when input parameter of dumpXattrs has xattrs.


Project file panel does not reflect real situation in OS file system.

Issue Type: Bug
When I open VCode it automatically shows the last files I opened in the last session. I continue editing a file called 'style.scss' making some changes, saving the file.
Then closing VCode, then opening it again with the last files I still openened. Reflecting the last change I made to the file.
But the strange thing is that the file can not be found, when I use my OS file system. And I'm looking in the correct folder!.
Adding manually a file in this folder. It doesn't show in the VCode project file panel. Even when I use REFRESH.
If I navigate to that file, using open file in VCode it shows the files correctly.
I even did a disk check to see how healthy is was, but no problems found.
VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:20:56.183Z)
OS version: Linux x64 4.15.0-38-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3630QM CPU @ 2.40GHz (8 x 3193)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: unavailable_softwarevideo_encode: unavailable_softwarewebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
7.68GB (1.10GB free)

Process Argv
--unity-launch

Screen Reader
no

VM
0%

Extensions (9)

Extension
Author (truncated)
Version

vscode-svgviewer
css
1.4.7

vscode-eslint
dba
1.6.1

tslint
eg2
1.0.40

compareit
in4
0.0.2

language-polymer
jon
1.1.0

Polymer2Snippets
jus
1.1.0

debugger-for-chrome
msj
4.10.2

polymer-ide
pol
0.6.0

preview-vscode
sea
1.4.6

Additional note: I renamed my project folder, to force VCode to setup a new 'Open folder' project.
Even then, the file content and folder structure, within the Project file panel, contains wrong file content and files.
My unix file privileges are normal. As in all other files.
Also, my project disk is an external one. I use this to work at home, on a windows machine. But also the same problems on that machine.

OK, sorry to bother you. Problem solved! Something with my backup restore feature (scripting).


class decorators for cdef classes

This would be a nice add-on to http://trac.cython.org/ticket/336. A major requirement would be that the decorator must not wrap the type or otherwise change its reference. It must return the reference it got, which should be checked at runtime. It may alter the type in any other way, though.
Migrated from http://trac.cython.org/ticket/337

If I understand it correctly this issue is about supporting
cdef class Klass:
    @classmethod
    cpdef funcion(self):
        ...

Are there any ways of retrieving http://trac.cython.org/ticket/336 ?

I think trac ticket 336 became #897, which related to PEP 3129 and was implemented. The added test is tests/run/classdecorators_T336.pyx, which has a "not-done" section: https://github.com/cython/cython/blob/31e9bb73988fd6c77bcc419d702df748feb24b4a/tests/run/classdecorators_T336.pyx#L28-L45


Hello！ could you provide the CLIP pretrained checkpoint and zero-shot script for us?

The pretrained checkpoint link has been added in the readme. The zeroshot scripts would be released soon.


General documentation update

Here's a list of commits that require some amount of documentation updates:

[x] lexical.rst has a bunch of empty sections.

[x] graphql: Implement reflection of ObjectTypes. (commit 0d8d5a7215f15ae16e2127f0973cfb5364e18b16)
ObjectTypes get reflected as type INTERFACE into GraphQL. Additionally,
non-abstract ObjectTypes get reflected as type OBJECT, but with the
"Type" appended at the end of their name.
This allows the return type of fields/functions to be specified in terms
of INTERFACE types and the actual object __typename to reflect the
OBJECT type of the specific instance.

[x] Allow aliasing links in shapes (commit ec91dcedc1d764d02dbef8badaac759f1830e2e0)
When a computable expression contains a path, use the trailing
link or property as a base for the computable in shape.
For example, in Spam { alias := Foo.bar }, Spam.alias
is derived from Foo.bar inheriting its properties.

[x] edgeql: Add re_replace function to std. (commit 9c20ef1b6768b616a91d09d66269068c1a586d73)

[x] graphql: Use a filter argument for more flexible filtering. (commit aa1c201e77c8aa7494a1819c1266ced29320fffa)
Rather than taking arguments corresponding to the individual fields, use
a single filter argument to specify the filtering conditions. This is
more generic and easier to add more functionality to in the future.

[x] graphql: Add orderBy argument. (commit 20f59c43d0df12996fda5f19e815350b01834716)
All fields that return a list of objects can now be ordered by one or
more of the scalar fields on that object.

[x] Disallow overriding the 'id' property (commit e502f4c8b96c6b45d26b8b9a0ea56908a1583146)
The value of the id property of an object coresponds to object's identity
(and value).  It is both unsafe and unintuitive to allow arbitrary
re-definition of id.
SELECT Foo ORDER BY Foo;
SELECT Foo ORDER BY Foo.id;

The above queries are equivalent by default, but would stop being equivalent
if id was re-defined in a view.
Fixes: #214

[x] graphql: Add slicing support. (commit f0190771b99d8608c1f3f92d437283193437967c)
Add after, first, before and last arguments to anything that
returns an object list. The arguemnts have the same semantics as in
Relay Connections regardless of whether the field returns a Connection
or a plain List.

[x] edgeql: Update the type specification syntax. (commit 03b3d5219eab8b5e5798bbfcfc613549264423df)
Introduce type expressions - syntactical constructs denoting types and
type composition.
Operator | produces a union type that is a duck type having the
intersection of all of the links and properties of the component types.
Semantically any object that is an instance of at least one of the
component types is also an instance of the union type.
Operator & produces an intersection type that is a duck type having
the union of all of the links and properties of the component types.
Semantically only an object that is an instance of all of the component
types is also an instance of the intersection type.
Syntactically type expressions are general and can be used anywhere
where a type can be used. There may be some exceptions, notably only
base types can be used in extending specification.

[x] edgeql: Add REQUIRED expr syntax. (commit 1bf7fd96ecf9100e90a818004b764131741e3848)
Issue #217.

[x] edgeql: Add INDEX syntax. (commit 1ae3b8b3d5592ce436e6b6f52724ae07dd3b3b5c)
Issue #148.

[x] Add schema::Database type to allow listing cluster databases (commit a6dbe9dd9192f3e2c64c78eb5261b22e694f851d)

[x] edgeql: Add ON TARGET DELETE... syntax to concrete links. (commit 69feb44b431eae162560ac643c393f6d37285aec)

[x] schema: Add on target delete ... syntax to the schema. (commit 9306fffb10e18a97c1962730c3e693565e7af9e2)

[x] edgeql: Disable GROUP statements util they are implemented. (commit d9ad223ee84de02379649482213e482cee3081dd)

[x] edgeql: Add array_get. (commit 2b309f9932d625e78ad921994cf666db84ade3b8)
Function array_get returns an array element or an empty set if the
index is out of bounds.

[x] Implement new syntax for function parameters (commit 78b97c3227a46ebabb1f3fa2b87c1a430deb5c14)
Paremeter kind and parameter type are now different things.
The following parameter kinds are supported right now:

regular positional parameters
VARIADIC
NAMED ONLY

The syntax for declaring functions & constraints not longer
allows to specify unnamed parameters -- names are required.
Old syntax:
  CREATE FUNCTION foo(int64)
  CREATE FUNCTION foo(VARIADIC SET OF str)
  CREATE FUNCTION foo($a: VARIADIC SET OF str)

New syntax:
  CREATE FUNCTION foo($p: int64)
  CREATE FUNCTION foo(VARIADIC $name: SET OF str)
  CREATE FUNCTION foo(VARIADIC $a: SET OF str)

Syntax for declaring named-only parameters (not yet supported by the
compiler):
  CREATE FUNCTION foo($pos1: int64, $pos2: str,
                      NAMED ONLY $n1: str, NAMED ONLY $n2: int64)

Named-only parameters will only be supported by functions (not
constraints).

[x] edgeql: Add JSON funcitonality. (commit 6d3352c5509ab9fd9b985b51ec8b8b2dffd64fa9)
New JSON functions:

str_to_json
json_to_str
json_typeof
json_array_unpack
json_object_unpack
json_get

The [] indexing operator is also available for JSON. This operator is
strict and will raise an exception if it is used with a non-existent
index value (this is true for JSON, strings and arrays).
There's a new array_get function that doesn't perform the boundary
check on the index value and returns an empty set if there is no such
index.

[x] Add support for casting objects and tuples to std::json (commit 8b7a72e27f9d45d55d1c10ab638c630f9becdd9d)
<json>Object now always returns a std::json value containing
the output representation of the object. That is, the result is
the same as the output of SELECT Object in JSON mode, including
the type shape.
Now, casting a non-named tuple to std::json returns a JSON array,
and casting a named tuple to std::json returns a JSON object.
Casting non-scalar JSON values to scalars is now an error, as well as
casting a non-matching JSON scalar value.
Issue: #251.

[x] Prohibit VARIADIC parameters from having default values (commit 952be2f82e897f0b994553ec017d1432e2e18267)

[x] Implement named and variadic arguments; fix type system. (commit 57a24bfd5f4556adc42ac084a1b2846eb38722e9)

Now we support named arguments and variadic parameters:
SELECT foo(1, 2, 3, $arg := 'val')

Type system was fixed to correctly handle implicit casts for
ints and floats.

[x] Add support for on target delete clause for links (commit ef120bd52bbb3bd846be303f850571b895998e29)
The new on target delete clause of concrete links is a mechanism
to specify what happens when a target object of a link instance
is deleted.
Currently implemented modes are:

RESTRICT -- produce an error indicating that deletion cannot be
done due to an existing link. This is the default.
DEFERRED RESTRICT -- same as the above, but the check is postponed
until the end of the current transaction, if there is no transaction,
equivalent to RESTRICT.
SET EMPTY -- remove the link, can only be used with links that are
not required.
DELETE SOURCE -- remove the link and the source of the link
(cascaded deletion).

[x] Update function declaration and call syntax (commit 6377f9309d90216c40d3a79c0ea873fa72aa88ef)
No longer use '$' as a prefix for parameter names in function
signatures and call expressions.  This is to declutter the syntax
in expressions like the following:
  func($foo, $default := $something)

which now becomes
  func($foo, default:=$something)

It's now immediately clear what refers to a variable and what sets a
value for a named argument.

[x] edgeql: Alter the precedence rules. (commit c9a3164b7a190555fae53311f24e65ca0acc96fa)
Move shapes {} to a higher precedence, same group as [].
Move DETACHED in between :: and . in precedence.
Update existing tests and add more tests on interactions between
precedence, shapes, scopes, and DETACHED.

[x] Add new b'bytes' literal (commit 7cecc9bb8e4e204837cac5f36e76fe5fed4d2573)
Can contain (lexical structure):

any printable ascii character
\xXX hex escapes
', ", \
\n, \t, \r
new lines

Requires a 'b' prefix before quotes, e.g.:
  SELECT b'bytes';

Supports slicing and indexing:
  db> SELECT b'bytes'[1]
  b'y'

  db> SELECT b'bytes'[0:2]
  b'by'

[x] Enforce lexical structure in string literals; support escape seqs (commit 094fc1830e1b227cf192679917d724d11fafc482)
Allowed escape codes in string literals:

\n, \t, \r
\, ', "
\xXX, \uXXXX, \UXXXXXXXX

Otherwise string literals allow any unicode characters and new lines.

[x] Add support for raw string literals; tweak lexer/ast. (commit 399cb02fe8b86fbcccbc4b6ec985c455b68b0249)

Add raw strings.

$$ ... $$ strings are now raw strings.

New syntax: r'...' and r"..." -- raw string literals.

Raw strings do not process any escapes, meaning that \ symbol
acts just as any other one.

Tweak string literals.

Regular strings no longer accept \xhh codes over 0x7F.  This is
modeled after Rust strings [1], quoting:
"Higher values are not permitted because it is ambiguous whether
they mean Unicode code points or byte values."

New AST nodes.

EdgeQL and IR implementations got two new nodes: StringConstant and
RawStringConstant.  SQL has also a new node: EscapedStringConstant
(compiles to an E'...' string).
[1] https://doc.rust-lang.org/reference/tokens.html#character-escapes

[x] schema: Add support for spaces + tabs indents. (commit af76bc27c0b97348330dc007159b0916ce338e51)
Indentation must be consistent, so if a mix of tabs and spaces is used,
tabs must come first and shallow indentation must be an exact prefix of
deeper indentation.
It is illegal to use a tab after a space in indentation.
It is illegal to use a line continuation immediately after indentation.
Some other content must appear first on that line.
Whitespace is still ignored in parentheses or in the middle of a line
even if it is extended via line continuation.

[x] Implement support for polymorphic functions (commit a8424aaa6625f92e093017b3b9d1f552e8400c2f)

[x] Update re_* functions to have "pattern" as a first parameter (commit c69770b8f648e7069b8612a4ab21426501699325)
Closes #269.

[x] Make regular division return floats and add a floor division operator (commit d0b572ecd6e050e3c61ec82998147ca2423a9d38)
In another break with tradition, / now always performs a true division:
even if the operands are integers, the result is a floating point
approximation of the division result.  The new // operator allows
pefforming floor division explicitly.
In this change we largely follow the motivation of Python's PEP 238.
Classic behavior of integer division makes it hard to write polymorphic
functions that work with arbitrary numeric types, especially if one
considers numbers beyond the real plane, as blind casting of one of the
operands may not work as expected.

[x] Allow indexing named tuples by position; fix named tuples serialization (commit 3e0832cb1f631fade5e3efebc904d61576c4f1ca)
Named tuples can now be indexed by position.  The below two queries are
equivalent:
  db> SELECT (a:=1).a;
  db> SELECT (a:=1).0;

Named tuples will now be correctly serialized to JSON in more cases,
for example:
  db> SELECT [(a:=1)][0];
  {"a": 1}

Serialization of nested named tuples is still broken in some cases
though:
  db> SELECT [(a:=(x:=1))][0];
  {"a": {"f1": 1}}

[x] Rename "any" to "anytype" (commit ac30a5ffb8293ed54180c885b0b71e4052590ab1)
We want to add a "std::any()" function and it seems that renaming
"any" to "anytype" is a better option than specialcasing any()
production in the grammar.  Also "anytype" plays nice with "anyscalar"
and "anyint".

[x] Rework the way relationship cardinality constraints are expressed (commit f77fe8c84b522f1129d8958bfdfe19347e148327)
We currently represent relationship cardinality as the cardinality
attribute in concrete link and property definitions.  The accepted
values are '11' (one-to-one), '1*' (one-to-many), '*1' (may-to-one),
and '**' (many-to-many).  While this is accepted parlour, the
interpretation of the constraints, together with the separate required
qualifier produces a fair amount of cognitive load.
In reality, the current monolithic relationship cardinality actually
represents two distinct properties: the cardinality of the target set
when traversing a pointer from a given source (the second '1' or ''),
and the exclusivity constraint on the target (the first '1' or '').
The first property needs to be specified far more often than the second,
so it makes sense to separate them.
Now, a concrete link or property declaration can include the new target
set cardinality qualifier in the form of the new single and multi
keywords.  For example:
  type User:
      link friends -> User:
          cardinality: '**'

becomes:
  type User:
      multi link friends -> User

The single qualifier is the default, but can still be specified:
  type Issue:
      single link status -> Status

The required qualifier can be combined with the single/multi
qualifier to form a precise target set cardinality requirement:
single means zero-or-one, required single means exactly one,
multi means zero-or-more, required multi means one-or-more.
The second relationship cardinality property is target exclusivity, i.e.
how many sources can relate to a given target, is now represented by the
exclusive constraint, which is the current unique constraint, but with
a new, more appropriate name.  It is more natural to say that a given
relationship is exclusive, rather than unique. For example, in the
relationship Person -> owns -> Chair, "this chair is exclusive to this
person" is better than "the Person/Chair relationship is unique":
  type Person:
      single link owns -> Chair:
          constraint exclusive

So, to summarize:
Former '11' is now single + constraint exclusive.
Former '1*' is now multi + constraint exclusive.
Former '*1' is now just single (this is the default).
Former '**' is now just multi.
The new qualifier syntax is also significantly more natural to use with
computable links and properties when an explicit cardinality qualifier
needs to be given to override the inferred value:
  type Person:
      multi link items := {'item'}

This now extends to ad-hoc computables in queries as well, so:
  SELECT Person {
      multi items := {'item'}
  }

instead of the awkward and somewhat arcane:
  SELECT Person {
      items := (WITH CARDINALITY '*' SELECT 'item')
  }

The WITH CARDINALITY '*' syntax is now entirely unnecessary and has
been removed.
The new syntax also allows expressing the non-zero cardinality
requirement with the required qualifier on the computable, but that is
left for a subsequent commit (see #217).
Closes: #303.

[x] edgeql: Update how time and date is handled. (commit a3457f33b7af7739ece0cad19bc66d1cccfb02bc)
The time and date scalars are:

datetime
naivedatetime
naivedate
naivetime
timedelta

There are 3 different functions for obtaining "current" datetime:

datetime_now
datetime_of_statement
datetime_of_transaction

There are also a suite of functions that extract specific date or time
parts:

datetime_get
date_get
time_get
timedelta_get

[x] edgeql: Add converter functions for multiple data types. (commit 19e6a2343fb0f652dac2e2f9f779ebd3816b2a15)
The to_str function is meant to be like a cast when called
without the format parameter.
to_str usage with json scalars is not equivalent to casting, it is
producing a string representation of JSON. The inverse function to_json
is therefore parsing a string, not casting either:

str_to_json becomes to_json
json_to_str becomes to_str

Add various date and time converter functions.

[x] Restrict usage of abstract scalars and anytype. (commit a23af17c68ca45e0e9eb6e80b5b6fc6a9997f2d6)
Casting into an abstract scalar or anytype is now forbidden.
Technically anytype is a valid type that is the supertype for both
anyscalar and Object. However, it is currently illegal to use it
anywhere outside of a function signature definition.
Anytype is also special in the fact that it doesn't have a corresponding
entry in the schema module (no Type object).

[x] edgeql: Make casts more consistent. (commit fe0e8cb48fcd67fd1b6c22ebeb710bb08e3d3dbd)
Forbid casting bytes into anything other than bytes (this makes sense
for scalar types derived from bytes).
Make JSON casts symmetric. For any type that allows a cast into json, it
should also allow to cast back without additional intermediate steps
(such as casting into str first).

[x] Formally implement fundamental operators as part of stdlib (commit f406f99ea951bf96df33424a5d02bf610dd17775)
This declares currently supported binary and prefix operators
on standard scalar types using the new CREATE OPERATOR DDL.
Expression type inference has been switched over from a
hardcoded table to looking up operators from the schema.
This also allows removing a bunch of hardcoded logic from the
compiler, since we can now consistently rely on the operators
properly reflected in the backend.
This commit also features correct implementation of the floor division
(//) and division remainder (%) operators, which now truncate toward
negative infinity, like Python does.

[x] Implement array, string and byte concatenation via the ++ operator (commit de73ddf94951dccaccfe031cd473f0852ef1ec14)
The current + operator is a poor choice for concatenation, especially
in the array case, since the latter may be interpreted as an
element-wise vector addition.  Instead, use ++ consistently as the
concatenation operator for all data types that support it.
Closes: #330.

[x] Prohibit casting of object types (commit deacffbdf50e4c7dbcff060f53f66b5423376b74)
Object types cannot be cast between themselves, as cast is a
constructor operation, and the only valid way to construct
an object is to INSERT it.

[x] Implement new syntax for the SET command. (commit 6bd90217c495358825954b27162a573154a1d615)
Supported variants:

SET CONFIG name := expr;
SET MODULE default;
SET ALIAS my_foo AS MODULE foo;

Partially addresses issue #347.

[x] edgeql: Add more library functions. (commit 1553f270f07ab58b890464958a32b64d35156653)
Add more generic functions to std module like min, max, round, etc.
Add some specialized functions to math module.

[x] Remove invalid DETACHED test (commit c323d4b994e8a0714612839c5a6d34b4e1dd8b4d)
DETACHED no longer works the way the test expects it to.

[x] Rework schema item attributes (commit 9cf7c8aab936824202d24c32763defb329ef0e81)
Schema attributes are named values associated with schema items and are
designed to hold arbitrary user-defined schema-level metadata.
There are several shortcomings with the current implementation that
need tweaking.
First issue: attributes can currently be of any primitive type, which
makes it really hard to represent the attribute collection as a
coherent whole without resorting to some string serialization, and that
can go sideways quickly if the attribute type is reasonably complex.
Thus, we stop pretending to support arbitrary types in attributes, and
only support std::str.  Complex structures can be stored as JSON and
coerced to a specific EdgeQL type explicitly, so this change has no
practical usability loss.  This also means that abstract attribute
declaration does not require a type specification anymore, although we
may revisit this in the future and allow std::str sub-types to be used,
to, for example, allow specifying constraints on attribute values.
Abstract attribute declarations continue to be required for
disambiguation purposes.
Second issue: standard schema item aspects, like link cardinality, are
represented as attributes in the introspection schema. There is no
reason to do it, and this creates confusing duality, since some aspects
are represented as properties and links of the appropriate
schema::Object subtype. We stop doing this, and only reserve
schema::Object.attributes to things that are true annotations and bear
no effect on the core schema behavior. Currently the only attributes
that satisfy this requirement are "title" and "description".
In DDL, the SET <attribute-name> := <attribute-value> is changed to
SET ATTRIBUTE <attribute-name> := <attribute-value>.
In schema DSL we allow setting attribute values on foreign schema items
using the regular declaration syntax with a qualified name:
  type othermod::Foo:
      attribute attr := 'value'

Issue: #306

[x] Make attributes non-inheritable by default (commit 9798846ddd7cc6192dea4f2de9376a1d5414e718)
Automatic inheritance of attributes is sometimes inconvenient or
undesirable. A "description" attribute, for example, is unlikely to be
useful when inherited. Thus, we make all attributes non-inheritable by
default, with an option to opt-in to automatic inheritance with the new
INHERITABLE qualifier for CREATE ATTRIBUTE:
  CREATE INHERITABLE ATTRIBUTE foo;

Issue: #306

Some functions to consider for standard library:

position(sub: str, full:str) -> int32 find a position of a substring in a string
position(el: anytype, arr: array<anytype>) -> int32 find a position of an element within an array
str_join(sep: str, arr: array<anytype>) -> str cast each element into  and join them, or we can have only the version that handles specifically an array<str>
str_split(sep: str, full: str) -> array<str> split a string by non-overlapping instances of separator

Documentation is now up-to-date.


Feature Request: Support directly operating on files

One thing we have noticed during our Big Data Journey is that while DB / Query engines are a convenient way to get access to data, if you want to do any kind of meaningful heavy lifting it is sometimes better to skip them altogether.
One thing we have been working on lately is directly operating on ORC files via Spark.
For example - doing a simple table copy from an unpartitioned table into a partitioned table (insert into <x> select * from <y> or load data inpath...) with the size of data and number of partitions we have (50 x 90) = 4500 via Hive with several well powered nodes (16 CPU x 104G Memory) takes days to complete. (Even with stats generation turned off for inserted rows!).
However looping the same query in Spark over a dataset like this:
val day = spark.read.orc("gs://pipeline/unpartitioned/ts_date=2019-02-15/state_code=CA/")
day.write.option("orc.bloom.filter.columns","id,place_cat,place_name,city").option("orc.compress","ZLIB").option("orc.compress.size","262144").option("orc.create.index","true").option("orc.row.index.stride","50000").orc("gs://pipeline/partitioned/ts_date=2019-02-15/state_code=CA/")

Finishes in hours on a very small and basic 3 node standard cluster.
As scramble generation is basically a transmutation of the data in one table into another one - avoiding the overhead of these Query Engines would go a long way to making this more efficient.
Currently most of our plans for this has been in crippling the scramble generation somehow - whilst it is possible to get the scrambles created using a reduced partitioning system - it might not be necessary if you can take full advantage of an MPP system such as Spark directly (and not relying on the HiveContext).
What do you think?

Naturally this wouldn't just be limited to ORC. Spark supports all sorts of writers from Parquet and Avro to even CSV and JSON files!

Thank you suggestion!  I agree with you on the usefulness of directly operating on file(s), but it won't always be magical (in comparison to SQL-based ones).
I see several orthogonal things in your comment:

A possibility of operating directly on files (either compressed or raw files): This will be very useful. We keep debating about common use cases, and we will definitely work on this.
Spark is faster than Hive: I agree, but it's mainly due to Spark vs Hive (or Hive's legacy Hadoop engine), not due to Spark SQL vs Spark. Spark SQL is all translated into Spark's map-reduce functions eventually. Also, Spark SQL's external table simply works on files (e.g., ORC, Parquet, csv, etc).
Operating on files may allow a larger number of partitions: If so, it will be useful. But, there may be negative performance impact, which I don't have a good understanding.

Eventually, I think Verdict should support direct data loads from your local disk or from Google cloud storage, etc., without requiring you all messy data transformation.

Sorry I just want to clarify - I am only talking about scramble creation here - not necessarily running Verdict directly on files as its own "Query Engine".
I find that Tez (the default engine underneath Hive in more recent versions) is not great at Memory Management compared to MR and Spark as execution engines, we see jobs fail much more regularly - even jobs that have previously completed on the same hardware. The only reliable way of processing anything on our kind of datasets are by trying to actually "reduce" the amount of processing that has to be done.
For example - to convert to ORC at the moment - the "easiest" way to do this in terms of effort is to create an external table on the CSV files, create an ORC table and then insert into orc select * from csv
Spark takes a bit more effort to get set up initially but can process the files much faster on a single node than Hive can do using a multi node cluster on the above.
I think for the time being - a way to simply create a scramble from an RDD / Dataframe and be able to write those to ORC files would be a great huge step - I don't think it would be too much effort to develop (we had a brief try but we have deadline to meet) as all the code to do this is basically there just using HiveContext to materialise them. If we can do the computationally difficult stuff such as creating scrambles in Spark and then keep the SQL interface so it can do all of the query translation that would be perfect :)

@voycey Assuming you will be using Google BigQuery (or at least Google Cloud ecosystem), what do you think of this workflow?  This is to figure out the simplest way for you to use VerdictDB. Once the interface is determined, we can engineer its internals for higher efficiency.

You store raw (or compressed) files in Google Cloud Storage. Let's say on Jan 1, you collected mydata_jan1.csv and on Jan 2, you collected mydata_jan2.csv, and so on.
You let VerdictDB load your data into its own some data store by pointing the locations of those files. The some data store will simply be BigQuery tables (managed by VerdictDB).
You run queries to VerdictDB.

BigQuery will be able to create the scrambles much faster than any other
DBMS that's for sure, if everything can be run in there I think that is a
good solution.
However *some data store *is likely to be problematic at the scale we are
talking about, hence why I am suggesting working directly on the files for
scramble creation.
Spark (Not SparkSQL) has been the only reliable method of processing bulk
files at the scale we are at cheaply, the moment any kind of query engine
is placed around it the overheads become problematic (we reduced our
cluster sizes yesterday and some counts now take 4 hours)
It may not be possible without this query engine, I don't know? But the:
File.read().doSomething().write()
Workflow is something that has reliably worked for us at scale.
I think this is due to the fact that our data is partitioned, so we can run
exactly the day & state we want.
On Wed, 5 Jun. 2019, 02:51 Yongjoo Park<EMAIL_ADDRESS>wrote:

@voycey https://github.com/voycey Assuming you will be using Google
BigQuery (or at least Google Cloud ecosystem), what do you think of this
workflow? This is to figure out the simplest way for you to use VerdictDB.
Once the interface is determined, we can engineer its internals for higher
efficiency.

You store raw (or compressed) files in Google Cloud Storage. Let's
say on Jan 1, you collected mydata_jan1.csv and on Jan 2, you
collected mydata_jan2.csv, and so on.
You let VerdictDB load your data into its own some data store by
pointing the locations of those files. The some data store will
simply be BigQuery tables (managed by VerdictDB).
You run queries to VerdictDB.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mozafari/verdictdb/issues/372?email_source=notifications&email_token=AAIEBCTMV7XW4UUPKHYAC43PY2MQBA5CNFSM4HPLOIO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW5GDFY#issuecomment-498753943,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIEBCSNJZQNG5X3MBUYS2TPY2MQBANCNFSM4HPLOIOQ
.


Bug fix: ignore 0 in TDaTing cell match

This PR fixes a bug in the pysteps.tracking.tdating.match function. As far as I can tell, in this bug the label 0 was included in possible match IDs, even though 0 denotes pixels that are not part of any cell. So there could be cases, where the advected cell would have e.g. 55% of 0 and 45% of some cell and it would not be matched to that cell. So this fix will first check if the advected cell contains only 0-labeled pixels, it is initiated as a new track. If not, then 0 is removed from the possible ID labels and the matching is done as previously.

sorry for taking so long, I think we can merge this bugfix if @feldmann-m has no objections to this?


Xamarin.Forms Portable Solution is very slow

Hi,
making a "blank app Xamarin.Forms Portable" solution, will take a long time for a blank project to finish doing all the inner projects.
also, closing the solution and re-opening it, takes a long time.
lastly, the compiling of the blank project in debug/release takes a very long time.
Regards.

This issue has been submitted to bugzilla.xamarin:
https://bugzilla.xamarin.com/show_bug.cgi?id=41059

Thank you for creating the bugzilla and it will be tracked through there.


Do not auto-escape output

All you need to do is tell Nunjucks to not escape values. We don't care about XSS here :smirk:

Uh oh. It looks like the only way to do this is to edit the templates from
! Base16 {{ scheme }}

to
! Base16 {{ scheme | safe }}

(source)
@aloisdg, do you think it'd be possible to write a small script to do this conversion automatically?

Hold the phone. I just found this.

Alright, think I fixed it in d910c19960b139567c969508ac907301529a8a77

Perfect! :)


PathMarkupParser doesn't support implicit lineto commands following a moveto command

This works:
<Path Data="M0,0L10,10" />

This doesn't work:
<Path Data="M0,0 10,10" />

According to the SVG specification:

If a moveto is followed by multiple pairs of coordinates, the subsequent pairs are treated as implicit lineto commands

https://www.w3.org/TR/SVG/paths.html#PathDataMovetoCommands

You already posted the same issue https://github.com/AvaloniaUI/Avalonia/issues/1606; please close either issues for brevity.

Can you combine this with https://github.com/AvaloniaUI/Avalonia/issues/1606 ? If you have any Path related queries, make them in a single ticket :)

This is a different issue, but I can merge them together if you prefer.

Yeah sorry 'bout that, they looked the same at a glance ;)

#1606 snippets exhibit both issues. I can edit them to make the difference more obvious.

Alright, please edit them as you see fit 😄

@miguelrochefort Thanks! and sorry again that i misunderstood the issues you filed

I am currently working on a rewrite of the PathMarkupParser to improve error handling and make the component testable.  Can you tell me what exactly isn't working? Is the implicit move command executed?

The two snippets above should be equivalent.
Given:
<Path Data="M0,0 10,10" />

Actual:

moveto 0,0
moveto 10,10

Expected:

moveto 0,0
lineto 10,10

Those two paths aren't equal.
M0 0 10 0 is translated to moveto(0, 0) moveto(0, 10)
If you wanted to have moveto(0, 0) lineto(10, 0) you would have to write M0 0L10 0 or M0,0L10,0

I will adress this case in my rewrite of the PathMarkupParser


Support different console appearances per cartridge

Game Play Color currently displays uses a Game Boy Color theme for all cartridges. It'd be nice to show a Game Boy theme when playing original Game Boy carts, and a Game Boy Color theme only when playing Game Boy Color carts.

Additionally, it would be cool if you could choose a specific theme per cartridge- for example, launching LOZ- Link's Awakening DX in green, and Pokemon Yellow in Yellow.

Won't fix.


Simple Activity View Assumes All Transactions In Default Currency

The 'Simple Activity View' includes a transaction type total for each activity. However, it appears to make the assumption that all transaction are in the default currency so produces incorrect totals when transactions have been published in multiple currencies.

Are these XSLT still in active use?
When I looked at this a few years back, the challenge was that default-currency was not always being provided, and there were very few mixed currency files, so to take only default currency values was difficult, and led to more empty transaction type totals than not.
That might have changed in the data quality now, and it might be possible to handle better - or to find some method of just returning no value when there is no default currency and there are mixed transactions.

Thanks for that Tim. This facility is actually just about to be removed from the IATI Registry in order that data users are directed to use the IATI datastore instead. However, I just posted this issue just in case anyone else was using the software or intended to use it in the future.


Remove RestBird.xcodeproj

Since swift package generate-xcodeproj should be executed to include the required package dependencies, the generated Xcode project should not be under version control.

Since .xcodeproj was removed the project doesn't build anymore on Travic CI.
Add generate-xcodeproj as a buld step as follows. swift package update can be removed:
os:
  - osx
language: swift
osx_image: xcode10
script:
  - swift package generate-xcodeproj
  - xcodebuild -scheme RestBird-Package build test


install error

i install alfred use comman "make all",and i account an compilation error like below:
lboost_system -lboost_program_options -lboost_date_time -L/Analysis/biosoft/02.RNA_Soft/alfred/src/htslib/ -L/Analysis/biosoft/02.RNA_Soft/alfred/src/htslib//lib -lpthread -lhts -lz -llzma -lbz2 -Wl,-rpath,/Analysis/biosoft/02.RNA_Soft/alfred/src/htslib/
In file included from src/alfred.cpp:50:0:
src/count_rna.h:27:44: fatal error: boost/icl/split_interval_map.hpp: No such file or directory
#include <boost/icl/split_interval_map.hpp>
^
compilation terminated.
make: *** [src/alfred] Error 1
Is it possible that the installation package I downloaded is incomplete,or my system problem ,thanks!

That looks like an outdated boost version. You can try updating boost or what might be easier you can also get alfred on bioconda, as a static binary or as a docker container

Hello,
I installed alfred via Bioconda  conda install -c bioconda alfred
Now I'm getting always an symbol lookup errror
alfred: symbol lookup error: alfred: undefined symbol: _ZN5boost15program_options3argE
What could I do to fix it?
Regards
Fabian

Probably a dependency issue if that's an existing bioconda environment. I have added a test directory to alfred, https://github.com/tobiasrausch/alfred/tree/master/test that includes a Makefile which downloads miniconda, adds the bioconda channel and then installs alfred. This worked for me. Can you please try if a clean bioconda installation works for you? Thanks.

I tried to install it in an empty/new conda env and I tried your make file.
Both time came the error again.
Here is the error after running your make file
alfred: symbol lookup error: alfred: undefined symbol: _ZN5boost15program_options3argE
Makefile:19: recipe for target '.test' failed
make: *** [.test] Error 127

I am sorry, I cannot reproduce this error. I tried different Ubuntu and CentOS versions but it always works with bioconda. What is your OS? You could also try using the previous build using an older boost version:
conda install alfred=0.1.17=he089337_1
Alternatively, I also provide static binaries for alfred.

My OS is Ubuntu 16.04.6 LTS
But the previous build works just fine, thanks a lot.

Thanks, good that it is working now.


Add connection status

If the port is not connected, the packet should just be dropped instead of awaiting forever:
async def send(packet):
   if self.connected:
    #normal send
   else
     return

Closed in 2d16bb6


[Bug] Getting Started page codesandbox doesn't work

The codesandbox in https://milkdown.dev/getting-started shows just a blank page and a MIME type error:

On Brave/chrome:

Safari:

It's working well on 3 devices on my side.


onClick event from cloneElement is not available in shallow rendering

I have a component (lets say a list) which maps the children and attach an onclick even on each one of them. When testing using the shallow renderer, the onClick event doesn't work and is not in the item.props() list for the item. When testing with the full dom (mount), it works fine.
{React.Children.map(children, child =>
    React.cloneElement(child, {
        onClick: () => {
            onItemClick(child.props.name);
        }
    })
)}

Do you know if this works with React's TestUtils.shallowRenderer?

@tleunen were you able to find a workaround for this? I can't seem to get children with dynamic props (similar to your example) with shallow or mount.

@anthonator do you have a test case? The code in the OP seems to work.

ah, looks like this might fail in React 0.13, but works in 0.14+?


Add disk encyption key to the google_compute_instance_template - Sovereign support

Checklist

I applicable, I acknowledge that I have:

[ ] Read the contributing guide
[ ] Ran terraform fmt on all modified files
[ ] Regenerated the relevant README.md files using tools/tfdoc.py
[ ] Made sure all relevant tests pass

Thanks @rune92. This looks good now
Can you sign the CLA?

@rune92 can you accept our CLA?

Thanks @rune92. This looks good now
Can you sign the CLA?

yepp, thanks I accepted.

Thanks @rune92. This looks good now
Can you sign the CLA?

yepp, thanks I accepted.

there's one commit by<EMAIL_ADDRESS>which is not passing the CLA

Thanks @rune92. This looks good now
Can you sign the CLA?

yepp, thanks I accepted.

there's one commit by<EMAIL_ADDRESS>which is not passing the CLA

Alright, then I signed the CLA with<EMAIL_ADDRESS>email as well. Can you check now?


Website throws error when searching for nothing

Thanks in advance for your bug report!

[X] Have you reproduced this issue in incognito/private browsing?
[X] Have you made sure you issue doesn't already exist?

Where is the URL that this occurs?
https://web.pulsar-edit.dev/
What's your issue?
When searching for something in the search bar but not actually putting anything but then hitting enter to search for it, will throw an error.
Which OS/Browser/Version does this happen on?
Arch-Linux/Firefox/112.0.2(64-Bit)
Firefox Version is from Official Arch Repos
Steps to Reproduce/Additional Details:

Go to https://web.pulsar-edit.dev/
Click the search bar to search for something but don't put anything
Hit enter
Error will show up
https://imgur.com/a/unjnbFD

Thanks a ton for submitting an issue, I'll look into this one!


refactor:[ISSUE #1866] remove lombok dependency

// Describe your PR here; eg. Fixes #issueNo

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #1887 (91e450f) into master (fced0b9) will decrease coverage by 0.64%.
The diff coverage is 49.49%.

@@             Coverage Diff              @@
##             master    #1887      +/-   ##
============================================
- Coverage     68.33%   67.68%   -0.65%
- Complexity     2710     2739      +29
============================================
  Files           492      497       +5
  Lines         11163    11303     +140
  Branches       1091     1110      +19
============================================
+ Hits           7628     7651      +23
- Misses         2959     3075     +116
- Partials        576      577       +1

Impacted Files
Coverage Δ

.../sync/data/websocket/WebsocketSyncDataService.java
0.00% <0.00%> (ø)

...c/data/websocket/client/ShenyuWebsocketClient.java
0.00% <0.00%> (ø)

...in/sync/data/websocket/config/WebsocketConfig.java
0.00% <0.00%> (ø)

.../sync/data/zookeeper/ZookeeperSyncDataService.java
71.16% <ø> (-0.14%)
:arrow_down:

...u/sync/data/consul/handler/ConsulCacheHandler.java
81.13% <16.66%> (ø)

...shenyu/sync/data/consul/ConsulSyncDataService.java
66.10% <20.00%> (-1.70%)
:arrow_down:

...e/shenyu/sync/data/consul/config/ConsulConfig.java
36.84% <33.33%> (ø)

...pache/shenyu/sync/data/http/config/HttpConfig.java
40.00% <36.84%> (ø)

...che/shenyu/sync/data/http/HttpSyncDataService.java
63.10% <38.46%> (-11.66%)
:arrow_down:

...nyu/sync/data/nacos/handler/NacosCacheHandler.java
77.46% <41.66%> (-0.15%)
:arrow_down:

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fced0b9...91e450f. Read the comment docs.


Add Pass the Hash capability to the NTLM client

This PR adds the ability for the NTLM Client to perform Pass the Hash functionality.
https://en.wikipedia.org/wiki/Pass_the_hash

@zenchild Bump. :smile:

Sorry, for some reason I thought I merged this already. Thanks for the bump @jlee-r7


problem with loading a glb/gltf file

Describe the bug
While passing a glb file to the three-gpu-path tracer the mesh looks wierd
Expected behavior
It should load fine
Screenshots and Repro Model
Model Link - https://github.com/adityakailash0399/model/blob/main/omega_watch_v02.glb

Please check the screenshot
Platform:

Device: [Desktop]
OS: [MacOS]
GPU: [M1]
Browser: [Chrome]
Browser Version: [116.0.5845.187 (Official Build) (arm64)]
Three.js version: [r0.152.0]
Library version: [v^0.6.3]

If you just ignore the issue template the requests for a model to test and system specs then I can't help you.

Hey @gkjohnson ,I have added the necessary details. Please check

Again, please provide the model. Nothing can be investigated with just a screenshot.

Library version: [v0.152.0]

And there is no version 0.152.0 of this library. Please provide the version of this project you're using.

I have provided the link to the model. Plus I have updated the library version as well

I am unable to reproduce the issue on my machine - this may be a browser / device issue but please make sure you're on the latest version of the project. You still have not provided the version of the library you are using. There is no v0.6.3 of three-gpu_pathtracer. Please provide the version for three-gpu-pathtracer.
If v0.6.3 is the version of three-mesh-bvh you are using then that is out of date, as well. Make sure you are using the latest versions of your packages.

@gkjohnson , tried rendering on the Windows machine, this worked fine. Can I say is it an issue on the M1 and browser both?

Hey @gkjohnson , Apologies! I got the versions now, I have been using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>.

Those versions are many revisions behind and almost a year old... I have already told you to make sure your versions are up to date before testing again. Why ask for help if you just ignore everything I say?
Please do not waste my time again.


JS capybara tests are causing database issues in non-JS capybara tests that follow

I figured I'd drop this here and see if anyone has any clue as to why this is happening:
http://stackoverflow.com/questions/36074585/rspec-capybara-js-tests-pass-in-isolation-but-fail-when-run-together
Any help would be appreciated, or at least to know if running JS tests at the end of my tests suite is the recommended solution.

@gregblass Could you try to run your specs with the configuration suggested in the README? https://github.com/DatabaseCleaner/database_cleaner#rspec-with-capybara-example

Closing due to lack of activity. Feel free to reopen if you're still having issues.


Re-enable the resource condition tests for mono-repo mode

The Constraint and ConstraintTemplate CRD have been updated to use the v1 apiversion. The test can run on clusters with k8s 1.22+.

/lgtm
/approve


feat: BindingOperations IsDataBound

What does the pull request do?

Add BindingOperations.IsDataBound to check AvaloniaProperty is bound.
What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Add BindingOperations.IsDataBound
Checklist

[x] Added unit tests (if possible)?
[x] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/avalonia-docs with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

close #13410
close #14546

Suppressed by #16214


[Question] Why does librespot_playback::audio_backend::find return a None option even if the backend is valid?

Hi all!

The problem is this: I'm trying to write a very simple application that, after receiving the credentials, plays a song from Spotify (whose ID is written directly in the code) but I can not create an instance of Player.
When I try to search the backend using the function librespot_playback::audio_backend::find, in fact, the program crashes saying it has received a None value. Obviously this would be normal if it wasn't that the specified backend (rodio) was told to be available (I checked the backends using the command target/release/librespot -n test --backend '?' and librespot listed me rodio (default), pipe and subprocess).
If it helps, this is my source code:
fn login(username: QString, password: QString) {
    let username: String = QString::into(username);
    let password: String = QString::into(password);

    let mut core = Core::new().unwrap();
    let handle = core.handle();
    let session_config = SessionConfig::default();
    let player_config = PlayerConfig::default();

    let credentials = Credentials::with_password(username, password);

    println!("Connecting ...");
    let session = core
        .run(Session::connect(session_config, credentials, None, handle))
        .unwrap();
    println!("Connected!");
    let create_mixer = librespot_playback::mixer::find(Some("softvol".to_owned())).expect("could not create softvol mixer");
    let mixer = create_mixer(None);

    let backend_string: Option<String> = Some(String::from("rodio"));
    let device_string: Option<String> = None;
    let backend = audio_backend::find(backend_string).unwrap();

    let mut spot_player = Player::new(player_config, session, mixer.get_audio_filter(), move || (backend)(device_string)).0;
    spot_player.load(SpotifyId::from_uri("spotify:track:1y9QiBBJynizfLbYjHM2Sg").unwrap(), true, 0);
}

I am aware that, in all likelihood, this problem is from some error in my code, but I hope someone can help me solve it.
I thank you in advance for your help.

Did you enable the rodio-backend feature flag in your Cargo.toml?

No, I didn't know that was necessary.
What do I need to do to activate it? Pardon the question, but, as you probably noticed, I'm quite new to Rust...

I'm not sure if it's necessary since it should be enabled by default. However, it would be like this:
librespot = { version = "0.1.3", features = ["rodio-backend"] }

Does "pipe" work as backend?

pipe does not throw errors, but it does not play audio. From what I understand, however, this is normal due to the fact that pipe generates a stream of data without actually sending it to any backend.
As for adding the rodio-backand, so far I've imported librespot_core and librespot_backend separately. How can I access them through librespot?

Ah, this makes sense, librespot_playback doesn't set default features. Just do the same as above with librespot_playback instead.

Now the program doesn't seem to throw errors anymore, but the playback still doesn't start.
No sound can be heard and the official Spotify apps don't detect connected devices.

The official Spotify apps won't detect your device unless you use the librespot_connect crate. Just take a look at the source code of librespot or spotifyd to see how it works.
I can't tell you though why there's no playback.

Alright, thanks for the help anyway.
At least I solved part of the problem....


Epic: Deliver on the remaining .NET Core customer promises from .NET 5

This is a draft/proposed Epic and not committed for .NET 6.0 yet.
Why
In .NET 5, many factors contributed to the fact that some features were developed in one area, and were not always supported across the entire stack or for all workloads. While many of these features are dialable, investing in finishing these promises will both help .NET developers to better adopt these platform features as we continue to evolve the .NET platform.
Summary
Finishing the remaining promises from .NET 5 includes features that support cross-cutting platform enablement and ensure that we have a more complete end-to-end experience in the .NET platform. Many of these features will require more definition and scoping during .NET 6 planning beyond what is described in the User Stories below.
User Stories

[ ] Developers can build libraries for HTTP3 to meet their client/server needs https://github.com/dotnet/runtime/issues/43546 (P0)
[ ] Developers can confidently generate single file apps that work for the supported target platforms https://github.com/dotnet/runtime/issues/43540 (P0)
[ ] Add Streaming API support to MVC https://github.com/dotnet/aspnetcore/issues/11558 (P1)
[ ] .NET Core developers can verify more APIs for their correct usage to speed up their development https://github.com/dotnet/runtime/issues/43617 (P1)
[ ] Developers using C# nullable reference types can use them with more Microsoft SDKs to validate correctness of their code https://github.com/dotnet/runtime/issues/43619 (P1)
[ ] Expanding Linker tooling in VS (P1)
[ ] Improvements to web api experience around OpenAPI and API Explorer https://github.com/dotnet/aspnetcore/issues/27889
[ ] Developers should be guided away from more obsolete APIs in .NET 6 https://github.com/dotnet/runtime/issues/46767
[ ] ASP.NET Core and SPAs in .NET 6 https://github.com/dotnet/aspnetcore/issues/27887
[ ] Evaluate what we want to do with Bootstrap for .NET 6 https://github.com/dotnet/aspnetcore/issues/23017
[ ] Narrow the feature gap between EF Core and EF6 https://github.com/dotnet/efcore/issues/24106

One that I'd really love to see included is this C#10 proposal:
https://github.com/dotnet/csharplang/issues/3630
If this isn't the right place to include it under, please LMK! Thanks : )

Closing from .NET 5


PubSub: Add undelivered messages metric

Is your feature request related to a problem? Please describe.
I would like to access the number of undelivered messages metric directly from the client library. Currently it's only available via Stackdriver monitoring.
Describe the solution you'd like
It seems like there are already some client metrics available below. Perhaps that's a good place to add the undelivered messages metric.
https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/SubscriberStats.java
Describe alternatives you've considered
Perhaps there's a stackdriver client that could be used? However, it makes more sense to access it from the pubsub client directly.

Are you looking for the information for just a single client?

@agolomoodysaada, what's your use case for needing these statistics?  That will help us tailor a solution.

Hey @sduskis ,
Our use case is for a client that exposes their pubsub topic to us with a service account. However they do not want to provide us access to their GCP  project for security reasons.
This puts us in an awkward situation where we can't really get alerted when we're behind on the pubsub topic. Or autoscale consumers for example. Having access to those metrics would allow us to do those operations without accessing the third-party's GCP project, Stackdriver, and so on.

First, we'd definitely need to expose the stats in a single VM, as per PR #4688.
We could theoretically integrate with OpenCensus which would allow you to quickly aggregate those statistics into your own Stackdriver project.  Would this type of integration be of interest?

I want to make sure we're talking about the same thing. The PR #4688 is exposing getTotalNackedMessages. Is that the same number_of_undelivered_messages metric?
If yes, then that's exactly what we're after.
We use Prometheus for monitoring, which I believe integrates with OpenCensus. Having access to this metric would allow us to expose this metric and autoscale our consumers accordingly.

@agolomoodysaada The getTotalNackedMessages() method will return the number of messages that the subscriber has processed and for which it has returned a nack.
Am I correct in assuming that you are looking for the number of messages that the subscriber has received, but not yet processed and responded to? In the PR #4688 that would be the calculation getTotalReceivedMessages() - getTotalAckedMessages() - getTotalNackedMessages.

Hey @olavloite , that's not what I'm interested in. I'm looking for the number of messages that were published but not yet consumed. This is the equivalent of the Kafka consumer lag metric.

I'm afraid that that metric is not included in the statistics for the client, and I also don't see a way to get those into a Subscriber client. I've looked through the gRPC API of pubsub, and there is nothing there that could be used to fetch that metric.

I understand @olavloite . Thanks for taking a look; that's the reasoning behind filing this issue.
Is there a way we can expose that metric via the gRPC API? Should this issue be filed in another repo?

@agolomoodysaada, I don't think that there's a way around getting access to Stackdriver metrics on the project that owns the topic.

In the kafka world, subscribers can get information about their offset on a specific topic on their own. Subscribers should own their offset, not topic owners. I understand if this is not available. And I was hoping that filing an issue here would allow the team to explore solutions for this. But it seems like the design is tied to stackdriver.

@agolomoodysaada, that's correct.  Stackdriver is the only way to access the metrics.
This repository's issue tracker is for Java client related issues.  You can ask for a Pub/Sub feature from https://cloud.google.com/pubsub/docs/getting-support.  Here's a link to the issue tracker that would be better suited for your request.

Thanks. For those interested, here's my submitted issue: https://issuetracker.google.com/issues/129396362


Docker setup - missing step

Hello,
I was trying to set up the WagTail Demo locally and using the specified commands did setup my environment. But it didn't allow me to log in to the backend(authentication error) until I ran the below command.
docker-compose run app /venv/bin/python manage.py createsuperuser

Can I create a pull request by changing the instruction?
Cheers
V

Hey @Big-Vi,
Have you seen the

Log into the admin with the credentials admin / changeme.

line in the README? did it not work for you?

The below credentials did not work for me.
username: admin
password: changeme

I agree with @cmuc24, thanks @Big-Vi.  I should also note that the hosted demo site is having a similar issue; when asked for the username and password, admin / changeme does not work.

I think the issue with the hosted demo site is different - since there's a single database shared across all users, it's easy for anyone to casually change the default login (and they may well even think it's the right thing to do, because the password is "changeme" after all).
I'm not sure why the extra createsuperuser step would be necessary here, because the admin / changeme account is hard-coded in the fixture along with the rest of the site data - if that account was missing, then the rest of the demo data would be missing too. We've previously had issues with the Docker setup due to the fact that the webserver setup and the database setup happen in parallel, so it's possible for the webserver to become available before the data is fully loaded - but again, if that was the problem here, you wouldn't see the bakery homepage either at that point (only the default "Welcome to your new Wagtail site" splash page).

I was also having trouble with logging in to either the docker container or the demo site.  The 'fix' does allow me to log in, but none of the data is there, so I figured it's probably due to the database not being up when the initial data load was running as mentioned by @gasman above.
Anyway - to fix both issues, I ran the command:
docker-compose run app /venv/bin/python manage.py load_initial_data
This fixed the login issue as well as the missing content.

Have confirmed that the current instructions do work, but you have to wait several seconds after docker compose up --build -d for the database initialisation to complete before running the load_initial_data command. Instructions updated accordingly in 274bba12799335665372e9ca5a05e4cdd0d43797.


Add Windows script support and native file extensions on Unix platforms

When running a sbt script, this change lets the user on UNIX and
Windows platforms to use native file extensions like none/.sh or
.bat/.cmd. The code copies the file to the sbt boot/hash/src_managed
directory with a .scala extension.

Hi @ekrich,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:
http://www.lightbend.com/contribute/cla

@ekrich LGTM. have you signed http://www.lightbend.com/contribute/cla?

Yes, I signed the Lightbend and Scala ones today.
On May 10, 2016 11:05 PM, "eugene yokota"<EMAIL_ADDRESS>wrote:

@ekrich https://github.com/ekrich LGTM. have you signed
http://www.lightbend.com/contribute/cla?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/sbt/sbt/pull/2603#issuecomment-218350149

Merged. Could you forward port this by branching out from 1.0.x and cherry picking (git pk fd5f87e) this commit on top?

Sure, I'll do so tomorrow.
On May 10, 2016 11:17 PM, "eugene yokota"<EMAIL_ADDRESS>wrote:

Merged. Could you forward port this by branching out from 1.0.x and cherry
picking (git pk fd5f87e) this commit on top?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/sbt/sbt/pull/2603#issuecomment-218351403

Does this come with documentation?


Change the docs for configuration API  for response from an array to dictionary

What content needs to be created or modified?

The existing configuration API docs needs to be changed to use dictionary based on the new change in dapr runtime and sdks.
Main issue in dapr/dapr in pasted here.
https://github.com/dapr/dapr/issues/4556
Describe the solution you'd like

Where should the new material be placed?

The associated pull request from dapr/dapr, dapr/components-contrib, or other Dapr code repos

Additional context

Linking docs for Configuration overview and API reference:
https://docs.dapr.io/reference/api/configuration_api/
Please update here.

Could you assign this to me? @hhunter-ms

/assign

@artursouza to confirm if we can close this out due to potential doc updates. So moving back a column.

This is the correct result as per the latest runtime (it means the docs needs update):
{
    "myConfigKey": {
        "value":"myConfigValue"
    }
}


Let the double-layer loop deep copy object of large array change to once

fix #40950
In our scenario, there are more than 5000 routers. When the router is in the merge filter, it will use proto.clone in a loop nested in the large array of routers. This modification moves the deep copy method to the outside of a loop,I think it is unnecessary to deep copy every time in the inner loop, a full deep copy can be made before the loop, so that the original A large number of calculations of n*n become n times
now:

fixed:

Hi @12345XXX. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I think we cannot share since they will be mutated by MERGE

It looks like this deep copy is a solution to different virtualHosts may share same routes pointer [ #18273]，(https://github.com/istio/istio/pull/18273) I think my modification different virtualHosts still has his own routes pointer

Ah maybe so, I didn't look closely since the PR was closed.. did you mean to close it?


 That broke down Kontena.run since when the commands are executed through that Clamp expects to get options and their values as separate array items.
$ k master join https://somemaster code

ERROR: Unrecognised option '--join code'

This PR fixes that by putting the options and their values as separate items in the command array.

@kke Removed the unnecessary shellescape, PTAL


Formatting "} else if (..) { }"  into an "} else { if () { } }"

Hey everyone,
I executed the following fixers in my project:

short_tag
encoding
braces
indentation
line_after_namespace
visibility

Unfortunately the fixers did the following to my else ifs:
Before:
if ($name == '-api') {
...
} else if ($name == '-target_dir') {
...
} else if ($name == '-version') {
...
} else if ($name == '-unsafe' && $params[++$i] == 1) {
...
}

After:
if ($name == '-api') {
...
} else {
   if ($name == '-target_dir') {
   ...
   } else {
      if ($name == '-version') {
      ...
      } else {
         if ($name == '-unsafe' && $params[++$i] == 1) {
         ...
         }
      }
   }

Is this a whised behavior?
Best Regards,
Lars
Edit:

Version: PHP CS Fixer version 1.11.6 by Fabien Potencier (41dc93a)
I executed the fixer with the following command: sudo php php-cs-fixer.phar fix <path_to_project> --fixers=short_tag,braces,line_after_namespace,visibility

Please provide the version you are using, CLI command and config file (if there is one)

Looks correct to me. If you enable the elseif fixer too, it won't do this.

yep, braces is adding missing braces for new scope, and else is creating a scope, in your case you have only one thing in that scope - if.

Is there a way to prevent this from happening without using the elseif fixer?
We need to still specify that braces should be on the same line, and want to use else if

no, after else you have a block which shall be wrapped with braces. if is already part of that block (and it creates it's own block)

Would you be open to a merge request for the elseif fixer that had a setting to use else if instead of elseif?

changing behaviour of elseif fixer won't affect braces fixer, and you originally asked about changing behaviour of braces fixer.
on now, you are talking about other thing? if so, my personal vote would be :-1: as it would violate PSR, but you would have to convince community, not me.


Add support for red hat distro for vscode runtime extension

Add support for Red Hat Enterprise Linux for VSCode Runtime Extension

Thanks for your hard work Annie, it looks like all of the comments minus one have been resolved. Since the other PR is now merged, we don't need this 2-PR structure, so I will close this one!


Enhance simple_update! for MPS in the Canonical form

Summary
This PR refactors the simple_update! function so now it properly uses the $\Lambda$ tensors of an MPS in the Canonical form to evolve the state without the need of recanonizing it.
Additionally, we also added the kwarg of normalize in the canonize! function.

@mofeing @starsfordummies Maybe we should put the renormalize kwarg in all truncate! functions (for all the Forms), right? Since we will lose norm every time we truncate.

ok for me!

@mofeing I refactored the normalize functions, so now we can do normalize! of an MPS in the Canonical form without recanonizing. We can also choose the bond at which it normalizes it.

@mofeing I refactored the normalize functions, so now we can do normalize! of an MPS in the Canonical form without recanonizing. We can also choose the bond at which it normalizes it.

nice! so I understand that if you don't provide the bond, then it normalizes all of them right? mmm do you have a use case for normalizing just 1 bond?

nice! so I understand that if you don't provide the bond, then it normalizes all of them right? mmm do you have a use case for normalizing just 1 bond?

 Maybe a use case would be when you truncate, right? Since you only truncate a bond and thus you want to renormalize the only "perturbed" bond.

I will do some more tests on evolve! this afternoon, for now let's keep this PR open. I think I can finish it today.

 Maybe a use case would be when you truncate, right? Since you only truncate a bond and thus you want to renormalize the only "perturbed" bond.

that could be a case. in general you would want such a method in the case that you want to normalize 1 $\Lambda$ and keep the rest of $\Lambda$s intact but I can't think of a real case where you would want that. if you want to normalize all the $\Lambda$s (or only one) calling normalize! on each $\Lambda$ shouldn't be costly because they're just vectors.

Okay for me this is ready to merge @starsfordummies @mofeing . I found that, in order to normalize all $\Lambda$, you need to divide all of them by norm(mps)^(1/(L-1)).

Okay, this was complicated... @mofeing @starsfordummies I finally managed to make everything work. For me, this makes sense. At least now, I think tomorrow I will forget for sure... Let's try to write it here:
evolve! has a renormalize kwarg, that for NonCanonical or MixedCanonical passes through truncate. This can not be done for Canonical, since simple_update_2site!(::Canonical, ...) contracts the two-site wave-function, evolves by calling  simple_update_2site!(::NonCanonical, ...), and the truncate is there, but we need to truncate after that, when in we recover the (pseudo)Canonical form, and then is when we have to normalize! the bond.


#153 Return Subscription ID as a part of ConfirmResult class

Refactored the Get-AzBP methods to return the ConfirmResult type.
Added authentication data, including Subscription ID, to the ConfirmResult type.
Updated Get-AzBP methods to consolidate the Get-* and Get-*Exist methods given the discussions during the design session and updating the methods to return the ConfirmResult type.
Locally, there are problems with the unit tests when creating a new ErrorRecord. All of the research I have done shows that what I wrote is correct, but locally it fails with a constructor error. I'm pushing the code as is, so that the PR unit tests will run, and I can determine if it's a local problem or something more.
Closes #153

It looks like the ErrorRecord constructor issue isn't just local. I'll need to find a way to resolve that before this is ready for primetime.

It looks like the ErrorRecord constructor issue isn't just local. I'll need to find a way to resolve that before this is ready for primetime.

This has been resolved. Thanks @msha1026 for the pairing!


Graphql introduction session

Those who have more experience with Graphql introduce others to it

Could we decide what to do with this? Anyone who wants this could suggest some times when to have a session like this. Also check out (if you haven't already) FullstackOpen.

25.10. 10:00 - 11:30


[firebase_auth] fix: bump transitive dependency version

Description
This PR boost the firebase_auth_platform_interface version from v1.1.1 to v1.1.5
firebase_auth v0.15.4 depends on an interface implemented in firebase_auth_platform_interface v1.1.3.
v1.1.1 will cause a transitive dependency error when user install it or upgrade it in pubspec.yaml.
Related Issues
#1885
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[ ] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Does anyone have a clue what happened with the checks? It seems that the emulator is not starting. I am not sure why.


Spanish docs

Final results for Spanish translation.
Issue: #63

Awesome @dev-oswld  thanks for this, we'll do a review ASAP!

Could you add the new file to .allcontributorssrc ?
https://github.com/zenika-open-source/open-source-promotion-cheat-sheet/blob/master/.all-contributorsrc#L5

@all-contributors please add @dev-oswld for translation

:fireworks: yeah!


Use vtkweb

@doutriaux1 @mattben @aashish24 Please review. This is needed to switch to vtkweb based vcs.js

@danlipsa I guess i should go ahead and update nighlty versions of VTK correct?

@doutriaux1 Yes, that is correct.

@doutriaux1 We need to update both vtk-cdat and vcs-js. Thanks!

@danlipsa ok will update vcs-js as well.


?Sized support, docs, tests

Basically pulled stuff from std to see what's missing. Later today / tomorrow will follow up on mutex too---you can merge this now or wait for that.

Great stuff! Will merge when the other modifications are in there too. :+1:

@mvdnes all done!

Thanks! :+1:


nodePackages.vercel: init at 23.0.1

Motivation for this change
Add node package vercel, CLI for Vercel.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 132835 at ddab8111 run on x86_64-linux 1

2 packages skipped due to time constraints:

iosevka
lumo

12 packages built successfully:

castnow
fast-cli
joplin
mirakurun
netlify-cli
postcss-cli
redoc-cli
vimPlugins.coc-prettier
vimPlugins.coc-stylelint
vscode-extensions.matklad.rust-analyzer
vscode-extensions.vadimcn.vscode-lldb
wasm-text-gen

20 suggestions:

warning: build-tools-in-build-inputs
nodePackages.node-gyp-build is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/node-packages/node-env.nix:402:7:
    |
402 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^

warning: license-missing
Package is missing a license.
Near pkgs/development/node-packages/node-env.nix:451:7:
    |
451 |       meta = {
    |       ^

warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/development/node-packages/node-env.nix:410:14:
    |
410 |       inherit dontNpmInstall preRebuild unpackPhase buildPhase;
    |              ^

warning: unused-argument
Unused argument: nix-gitignore.
Near pkgs/development/node-packages/node-packages.nix:3:31:
  |
3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
  |                               ^

warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?
Near pkgs/development/node-packages/node-env.nix:401:7:
    |
401 |       name = "${name}-${version}";
    |       ^

Near pkgs/development/node-packages/node-packages.nix:109210:5:
       |
109210 |     version = "0.12.2";
       |     ^

warning: unused-argument
Unused argument: lib.
Near pkgs/development/node-packages/node-packages.nix:3:54:
  |
3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
  |                                                      ^

warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?
Near pkgs/development/node-packages/node-env.nix:401:7:
    |
401 |       name = "${name}-${version}";
    |       ^

Near pkgs/development/node-packages/node-packages.nix:99383:5:
      |
99383 |     version = "6.0.5";
      |     ^

warning: build-tools-in-build-inputs
util-linux is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/node-packages/node-env.nix:402:7:
    |
402 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/node-packages/node-env.nix:451:7:
    |
451 |       meta = {
    |       ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall.
Near pkgs/development/node-packages/node-env.nix:417:7:
    |
417 |       installPhase = ''
    |       ^

warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:
   |
28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^

warning: unused-argument
Unused argument: stdenv.
Near pkgs/development/node-packages/node-packages.nix:3:46:
  |
3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
  |                                              ^

warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?
Near pkgs/development/node-packages/node-env.nix:401:7:
    |
401 |       name = "${name}-${version}";
    |       ^

Near pkgs/development/node-packages/node-packages.nix:106345:5:
       |
106345 |     version = "8.3.1";
       |     ^

warning: build-tools-in-build-inputs
nodePackages.node-pre-gyp is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/node-packages/node-env.nix:402:7:
    |
402 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^

warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?
Near pkgs/development/node-packages/node-env.nix:401:7:
    |
401 |       name = "${name}-${version}";
    |       ^

Near pkgs/development/node-packages/node-packages.nix:98743:5:
      |
98743 |     version = "3.7.1";
      |     ^

warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?
Near pkgs/development/node-packages/node-env.nix:401:7:
    |
401 |       name = "${name}-${version}";
    |       ^

Near pkgs/development/node-packages/node-packages.nix:69620:5:
      |
69620 |     version = "1.11.1";
      |     ^

warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?
Near pkgs/development/node-packages/node-env.nix:401:7:
    |
401 |       name = "${name}-${version}";
    |       ^

Near pkgs/development/node-packages/node-packages.nix:83922:5:
      |
83922 |     version = "3.0.1";
      |     ^

warning: missing-phase-hooks
configurePhase should probably contain runHook preConfigure and runHook postConfigure.
Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:
   |
28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^

warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?
Near pkgs/development/node-packages/node-env.nix:401:7:
    |
401 |       name = "${name}-${version}";
    |       ^

Near pkgs/development/node-packages/node-packages.nix:91160:5:
      |
91160 |     version = "2.1.2";
      |     ^

warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?
Near pkgs/development/node-packages/node-env.nix:401:7:
    |
401 |       name = "${name}-${version}";
    |       ^

Near pkgs/development/node-packages/node-packages.nix:72011:5:
      |
72011 |     version = "0.6.0";
      |     ^


Drag from bottom

Hello @jiayihu thx for this Demo application this is great staff you save my day or probably life, but i have a little issue and i will try to explain it, i will attach the screen shot's.
For example i have 3 items like on images and i want to drag the note to another column and i am start drag it from the bottom, it didn't attach to the lane and doesn't look great as in other cases!
Yes i know it's a very small issue but it's very interesting how to solve that!
Great thx for your time! And thx again for your work!
Will be waiting for your response!
I am use this version: ES6 + Webpack 2 version

Hi @Kronenberg, thanks for trying out the kanban. Unfortunately I cannot reproduce the issue in the demo, do you mean it doesn't work if you drag into another column hovering the + note button? Does it work if you hover the top of the lane and then the bottom after the last note?

No it work's its okey! I mean its not drag smoothly, after drag from bottom as u see on the screenshot button didnt move but the NOTE already on the row! Thx again ! :)

I think I got it, I'll fix it ASAP. Thanks for reporting!

Okey i will be waiting, very interesting how do you solve that!
Great thx @jiayihu!

I am check another apps which using this npm module and they have the same issue 👍
Maybe better close this issue coz it't not your's, or i will let u know when i'll find the answer!
Anyway great thx for your help!


Fix a few typos in docs and docstrings

Coverage remained the same at 60.134% when pulling 8e2784fd6b2d37ca883837d3ee62c8434e9efd35 on scampersand:typos into ef371fc63a628c85c89ad232efba829c928f4f86 on SoCo:master.

Coverage remained the same at 60.134% when pulling a11aea748f7ee6434b5196b0c6c2f39724982845 on scampersand:typos into ef371fc63a628c85c89ad232efba829c928f4f86 on SoCo:master.

Thanks, merged!


Lighthouse propagate should run at configured rate

Describe the bug
Lighthouse propagate should run at configured rate
To Reproduce
Steps to reproduce the behavior:

LH propagate task is configured to run every 30 mins
Check DD logs to find that recent runs have been in clusters of 3 runs, separated by ~30 mins

Additional context
Determine the if task configuration is working as intended.

went through RootPropagated events emitted on RootManager
Its working as configured


Issue in 5.11 with tracing-bunyan-formatter-0.1.7

Hi Luke,
I'm hitting an issue with tracing-bunyan-formatter-0.1.7
{"v":0,"name":"z2p","msg":"Starting 2 workers","level":30,"hostname":"li98-183","pid":3669213,"time":"2021-02-02T16:59:30.991252242+00:00","log.line":263,"log.target":"actix_server::builder","log.module_path":"actix_server::builder","log.file":"/home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/actix-server-1.0.4/src/builder.rs"}

{"v":0,"name":"z2p","msg":"Starting \"actix-web-service-<IP_ADDRESS>:8000\" service on <IP_ADDRESS>:8000","level":30,"hostname":"li98-183","pid":3669213,"time":"2021-02-02T16:59:30.991687848+00:00","log.module_path":"actix_server::builder","log.line":277,"log.file":"/home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/actix-server-1.0.4/src/builder.rs","log.target":"actix_server::builder"}
{"v":0,"name":"z2p","msg":"[ADDING A NEW SUBSCRIBER. - START]","level":30,"hostname":"li98-183","pid":3669213,"time":"2021-02-02T16:59:39.087001836+00:00","target":"z2p::routes::subscriptions","line":21,"file":"src/routes/subscriptions.rs","email":"joey.dean4@gmail.com","name":"Joey Dean4","request_id":"ba08c180-7945-4f7c-802c-178dd00f2760"}

{"v":0,"name":"z2p","msg":"[SAVING NEW SUBSCRIBER DETAILS IN THE DATABASE - START]","level":30,"hostname":"li98-183","pid":3669213,"time":"2021-02-02T16:59:39.087462768+00:00","target":"z2p::routes::subscriptions","line":35,"file":"src/routes/subscriptions.rs","email":"joey.dean4@gmail.com","name":"Joey Dean4","request_id":"ba08c180-7945-4f7c-802c-178dd00f2760"}

{"v":0,"name":"z2p","msg":"[ADDING A NEW SUBSCRIBER. - EVENT] /* SQLx ping */; rows: 0, elapsed: 587.002µs","level":30,"hostname":"li98-183","pid":3669213,"time":"2021-02-02T16:59:39.088641273+00:00","log.target":"sqlx::query","log.module_path":"sqlx::query","email":"joey.dean4@gmail.com","name":"Joey Dean4","request_id":"ba08c180-7945-4f7c-802c-178dd00f2760"}

{"v":0,"name":"z2p","msg":"[ADDING A NEW SUBSCRIBER. - EVENT] INSERT INTO subscriptions (id, …; rows: 0, elapsed: 2.325ms\n\nINSERT INTO\n  subscriptions (id, email, name, subscribed_at)\nVALUES\n($1, $2, $3, $4)\n","level":30,"hostname":"li98-183","pid":3669213,"time":"2021-02-02T16:59:39.097324124+00:00","log.target":"sqlx::query","log.module_path":"sqlx::query","email":"joey.dean4@gmail.com","name":"Joey Dean4","request_id":"ba08c180-7945-4f7c-802c-178dd00f2760"}

{"v":0,"name":"z2p","msg":"[ADDING A NEW SUBSCRIBER. - EVENT] request_id ba08c180-7945-4f7c-802c-178dd00f2760 - New subscriber details have been saved","level":30,"hostname":"li98-183","pid":3669213,"time":"2021-02-02T16:59:39.097601018+00:00","email":"joey.dean4@gmail.com","name":"Joey Dean4","request_id":"ba08c180-7945-4f7c-802c-178dd00f2760"}

thread 'actix-rt:worker:0' panicked at 'Timestamp not found on 'record', this is a bug', /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/tracing-bunyan-formatter-0.1.7/src/storage_layer.rs:157:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The above happens when I curl subscribe to the running server, or I run cargo test.  Prior to migrating to the tracing library the test ran with the log library.
Please see my attached repository https://github.com/cmdrtomalak/zero2production
Thanks.

Hey Luke,
I found the issue, it was misreading 5.4 when adding the query_span, I never called "instrument(query_span)" on the sqlx::query!
Thanks!


Replace calico enterprise with calico cloud

"TRY NOW should take to Calico Cloud Trial Page", Since we don't have the right link for it, we can't add it

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/merge-when-ready delete-branch

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

Hey @Kolya-kostevich , sorry about the delay in merging. Please fix up the conflict and tag me to merge.

Removing "merge-when-ready" label due to new commits

Hey @Kolya-kostevich , sorry about the delay in merging. Please fix up the conflict and tag me to merge.

Fixed

Hey @Kolya-kostevich , sorry about the delay in merging. Please fix up the conflict and tag me to merge.

Hey @Kolya-kostevich , sorry about the delay in merging. Please fix up the conflict and tag me to merge.

Hello @bcreane. Fixed.

@Kolya-kostevich @bcreane ping - is this still something we want?


Opening Interactive window breaks editor "sticky scrolling" functionality

Applies To

[ ] Notebooks (.ipynb files)
[X] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
In recent VS code there is a "sticky scrolling" feature which can be turned on via "editor.experimental.stickyScroll.enabled": true and it's actually pretty cool:-) However, when Interactive window is opened (and possibly closed, doesn't matter) this feature stops working.
Steps:

turn on sticky scrolling
start vscode
open some python file to check that sticky scrolling works
open interactive window (and leave open or close, doesn't matter)
go back to your python file and see that now the scrolling is normal as if "sticky" were turned off.

Possibly this might have the same underlying cause as #10846 since symbols analysis somehow gets messed up?
VS Code Version
Version: 1.70.0 (user setup) Commit: da76f93349a72022ca4670c1b84860304616aaa2 Date: 2022-08-04T04:38:16.462Z Electron: 18.3.5 Chromium: 100.0.4896.160 Node.js: 16.13.2 V8: <IP_ADDRESS>-electron.0 OS: Windows_NT x64 10.0.22000
Jupyter Extension Version
v2022.7.1002181843
Jupyter logs
No response
Coding Language and Runtime Version
No response
Language Extension Version (if applicable)
No response
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
No response

Not sure how an extension would affect sticky scroll in the core, moving to VS Code for now.


Tagging scheme: 3.8-beta7 or v3.8-beta7?

The latest version is tagged as 3.8-beta7, but all previous tags had the v prefix. Is this a typo or a new tagging scheme? This is important for F-Droid's autoupdate mechanism.

Sorry for the late response. I honestly can't remember making that release, it was probably late at night when I was half asleep. I can't think of any reason for me to switch tagging schemes, so it was probably just a typo. I will continue using the v prefix in the next release.

OK, thanks.


Discrepancy between the number of names and addresses on profiles

Overview
There are a number of facility profiles for which the number of names and addresses does not match up, and a contributor is either left off of the name or address section.
In this case: PK2020261AP1VX1, Adidas and Fair Factories Clearinghouse are not listed as name contributors but are listed for addresses
Here: SV2019085FG7V47, Nike is not listed as a name contributor but is listed for an address
Expected Behavior
There should be a 1:1 match between name and address contributors.
Steps to reproduce
Visit these two example facilities and see the difference between name contributors and address contributors:
PK2020261AP1VX1
SV2019085FG7V47

More examples:
BD202005213JD8W
CN2019083AZF314

Related to #1793