Performance on multi-channel images

Hi,
I have a question regarding the performance of this model for multi-channel( > 3) images? Mainly I'm concerned about the running time.
Thanks

Fast-slic currenlty supports 3-channel 8-bit images. It can be modified to support up to 4-channel image(i.e. RGBA). But no more channel than 4 can be supported in the current code structure, because hand-crafted SIMD instructions in use are specialized to 3-channel or 4-channel images. Given support for 4-channel images added, running time of them would be the same as 3-channel ones.
If your image has more than 4 channels, you should reduce dimension of color vectors using PCA or other stuff to 3-channel.

Thanks for your comment. Unfortunately, I can't reduce the dimension.


Add documentation for floating window position param

Add documentation for the floating window param introduced in #215
After seeing a mention that the docs were not modified manually but rather generated with I script, I added the field to the class and generated the docs using the script provided in scripts/docgen

Thank you!


Add support for CSI Powermax Driver

Description

Add support for v2.6.0 and v2.7.0
Adds CSI reverse-proxy module
Adds unit tests for CSI Powermax and modules

GitHub Issues
List the GitHub issues impacted by this PR:

GitHub Issue #

https://github.com/dell/csm/issues/769

Checklist:

[x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[x] I have verified that new and existing unit tests pass locally with my changes
[x] I have not allowed coverage numbers to degenerate
[x] I have maintained at least 90% code coverage
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have maintained backward compatibility

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Unit Test

@delldubey , Operator supports n-2 version of driver. Please add the configs and samples for 2.5 as well


Error view is not accessible to screen reader NVDA anymore

System information:

Operating system: Windows 10 Professional up to date.
DBeaver version: Version <IP_ADDRESS>003021717
Release date: March 2, 2020
Additional extensions: None

Connection specification:

Database name and version: Snowflake - latest.
Driver name: Snowflake JDBC
Do you use tunnels or proxies (SSH, SOCKS, etc)?: No, but Snowflake JDBC uses SSL.

Describe the problem you're observing:
The Error Log tree is no longer read out by NVDA - it is simply silent - same as what the Grid Layout in the Result pane has always been. Can get by without the Grid Layout in Result panel by using the Text Layout instead, but without the Error Log being accessible it's a bit of a problem.
Steps to reproduce, if exist:

Install latest DBeaver and latest NVDA.
Write query that should fail and try and inspect the error in the Error Log - notice how the error tree is no longer voiced.

Include any warning/errors/backtraces from the logs

Here is how NVDA reports the Error Log tree UI element now if you press Caps Lock (NVDA key) + F1:
Developer info for navigator object:
name: None
role: ROLE_TREEVIEW
states: STATE_FOCUSABLE, STATE_FOCUSED
isFocusable: True
hasFocus: True
Python object: <NVDAObjects.IAccessible.sysTreeView32.TreeView object at 0x084C46F0>
Python class mro: (<class 'NVDAObjects.IAccessible.sysTreeView32.TreeView'>, <class 'NVDAObjects.IAccessible.IAccessible'>, <class 'NVDAObjects.window.Window'>, <class 'NVDAObjects.NVDAObject'>, <class 'documentBase.TextContainerObject'>, <class 'baseObject.ScriptableObject'>, <class 'baseObject.AutoPropertyObject'>, <type 'object'>)
description: None
location: RectLTWH(left=467, top=692, width=1004, height=107)
value: None
appModule: <'eclipse' (appName u'dbeaver', process ID 18980) at address 81b9dd0>
appModule.productName: exception: No version information
appModule.productVersion: exception: No version information
TextInfo: <class 'NVDAObjects.NVDAObjectTextInfo'>
windowHandle: 9767296L
windowClassName: u'SysTreeView32'
windowControlID: 9767296
windowStyle:<PHONE_NUMBER>
extendedWindowStyle: 1048576
windowThreadID: 20008
windowText: u''
displayText: u''
IAccessibleObject: <POINTER(IAccessible2) ptr=0x1083ffa4 at 86babc0>
IAccessibleChildID: 0
IAccessible event parameters: windowHandle=9767296, objectID=-4, childID=0
IAccessible accName: None
IAccessible accRole: ROLE_SYSTEM_OUTLINE
IAccessible accState: STATE_SYSTEM_FOCUSED, STATE_SYSTEM_FOCUSABLE, STATE_SYSTEM_VALID (1048580)
IAccessible accDescription: None
IAccessible accValue: exception: (-2147352573, 'Member not found.', (None, None, None, 0, None))
IAccessible2 windowHandle: 9767296
IAccessible2 uniqueID: -47
IAccessible2 role: ROLE_SYSTEM_OUTLINE
IAccessible2 states:  (0)
IAccessible2 attributes: u'margin-left:0;margin-top:0;margin-right:0;margin-bottom:0;text-align:center;text-indent:0;'

thanks for the bug report

@VantageKR did you notice when it stop work? I.e. in which version.
As we didn't change anything in Error Log (as it is provided by Eclipse platform). Perhaps it happened after some Eclipse platform update.

Unfortunately I do not have the exact version where it was still
working, but the last installer on my system was for 6.3.5 (but not 100%
sure if I actually installed that one prior to the current 7.0.0 -
probably did). I'll attempt uninstall of 7.0.0 and re-install of 6.3.5
to check if it was working there still and revert.
Thanks!
On 15/03/2020 17:18, Serge Rider wrote:

@VantageKR https://github.com/VantageKR did you notice when it stop
work? I.e. in which version.
As we didn't change anything in Error Log (as it is provided by
Eclipse platform). Perhaps it happened after some Eclipse platform update.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dbeaver/dbeaver/issues/8157#issuecomment-599223791,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJO4OXP7ISDEWCXO3GUNIVTRHTWVJANCNFSM4LFPR34Q.

--
Kerneels Roos
Vantage Data | Senior Developer
Physical. Block C, Unit 1, Sunbury Office Park
Douglas Saunders Drive, La Lucia, Durban, 4051
Website. www.vantagedata.co.za

not reproducible against 21.0.3


[Weekview] Select range for the last day of week view doesn't work

with on-date-range-select set, attempting to select timespan on the last day of the week view doesn't work.
Seems like the last cal-day-hour-part-spacer is pushed to the next row.

plunker

Thanks for the repro, I'll get that fixed up in the next release!


Add ImportDeclaration type

Also, add some linting for Typescript files as this would have been caught by the linter.
This fixes #70

Now that I see it, ImportDeclaration does not describe an existing AST node type, it's an artifact of the ANTLR grammar. It should be removed completely from the types, as it's not used anywhere.

I figured but wasn't 100% sure so I looked at the grammar and inferred what was going on there.
I'll update the PR by removing the type. Should we go and merge the rest anyway?

Sure, the rest looks fine.

There, force pushed, and updated the commit message. Should be ready to go.


Minor text correction

just a minor text correction
contents => contains

The example is actually correct, the first word is the name of the parameter being documented.


Add Basque language

I maintain a Basque diceware worldlist (diceware-eu) and I thought it would be nice to add it to your great web site.
Thanks.

Thanks for the contribution. Its merged and should show up on the site shortly. 👍


(Low) Aikido Vulnerability > path-to-regex

Aikido reports vulnerability to us because of your path-to-regex dependency version.
https://security.aikido.dev/cve/AIKIDO-2024-10181
Update your (peer)dependencies to use path-to-regex 7.1.0
TL;DR
The patched version adds a strict option to detect potential ReDOS issues. The worst case impact for these vulnerabilities can be "Attacker can trigger DOS-attack via regex".
Aikido recommends
Upgrade path-to-regexp library to patch version (7.1.0) and use the 'strict: true' option.

I guess folks are using the legacy version in express for a reason. I can look for this ReDOS issue at 0.1.x.
cc: @blakeembrey

@IamLizu there is no need to do anything here, thank you.

Note that path-to-regexp is maintained by the express team.  express itself does not use newer versions of path-to-regexp, and it is removed in the next version of express, version 5.  We will update this issue when we have more information about any impact to express 4.

Note that path-to-regexp is maintained by the express team.  We will update this issue when we have more information about any impact to express.


java 8

Hi guys,
Do you have any plans to merge this pull request?
Thanks!

there are new versions of java now, so maybe this pull request should be updated or declined

+1 in general I'd love to see upgrade to any Java 8 version. :)
On Wed, Sep 21, 2016, 09:03 Leonid<EMAIL_ADDRESS>wrote:

there are new versions of java now, so maybe this pull request should be
updated or declined
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sequenceiq/hadoop-docker/pull/38#issuecomment-248528575,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAyOd80erS4mvKK1cOQD-8GylfngPWL6ks5qsNbXgaJpZM4Gg5Yz
.

--
Henryk Konsek
https://linkedin.com/in/hekonsek

@lrusnac woud you mind updating to the lates: jdk-8u65, it think its now u101, or u102

@lalyos sorry, I think I missed that, but you could just fork my repo and change the java version, either way I think you already figured it out since it's 4 months later now, sorry

Yeah, but thanks anyway :)
On Wed, Dec 21, 2016, 21:54 Leonid<EMAIL_ADDRESS>wrote:

@lalyos https://github.com/lalyos sorry, I think I missed that, but you
could just fork my repo and change the java version, either way I think you
already figured it out since it's 4 months later now, sorry
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sequenceiq/hadoop-docker/pull/38#issuecomment-268636693,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAyOdwQHMOWuZHC96n4oUwWsxx5x-2Elks5rKZH9gaJpZM4Gg5Yz
.

--
Henryk Konsek
https://linkedin.com/in/hekonsek


FIX: Add WordPress URL

@erwinromkes this PR is closed since it is stale.
And not PR should merge to the main branch!
Please move all code logic back to the your branch from the latest develop branch instead.


Test patch

testes pass by python 2.7 and python 3.4

Thanks for the patch, will review it soon
On Apr 14, 2015 09:56, "sih4sing5hong5"<EMAIL_ADDRESS>wrote:

testes pass by python 2.7 and python 3.4
You can view, comment on, or merge this pull request online at:
https://github.com/conrado/libavwrapper/pull/1
Commit Summary

use unittest.mock for python3.3 onwards
fix the test_drawtext function.
fix readlines encoding error when there are non-ascii characters

File Changes

M libavwrapper/avconv.py
https://github.com/conrado/libavwrapper/pull/1/files#diff-0 (11)
M test.py
https://github.com/conrado/libavwrapper/pull/1/files#diff-1 (39)

Patch Links:

https://github.com/conrado/libavwrapper/pull/1.patch
https://github.com/conrado/libavwrapper/pull/1.diff

—
Reply to this email directly or view it on GitHub
https://github.com/conrado/libavwrapper/pull/1.


In a shared project with git, the handness data values are incorrect.

Description
Development environment is window 10, not docker.
In a shared project with git, the handness data values are incorrect.
Except for the project owner's pc, the data value is expressed as -1. (Other hand recognition data values are correct).
Is this a problem caused by not doing pre-installation(like bazel, etc) on all PCs?  If so, is this a problem that can be solved using Docker?
I confirmed that the build shared after downloading it as a zip file works on all PCs.
Therefore, it is not considered that there is a problem with the project uploaded to git itself.

I confirmed that the build shared after downloading it as a zip file works on all PCs.
Therefore, it is not considered that there is a problem with the project uploaded to git itself.

Maybe you're talking about the problem occurring among your project members, but the context is so lacking that I don't understand it at all.
If you need help, please use bug report form or support form and create the issue again.


Enable pre and post text of cite role

Hello,
it would be great if the pre and post text feature of the cite role could be integrated into mystmd. This could be used integrate page numbers into your citations.
The axioms were introduced by:cite:t:`{see}1977:nelson`.
The axioms were introduced by:cite:t:`1977:nelson{p.1166}`.
The axioms were introduced by:cite:t:`{see}1977:nelson{p.1166}`.
Axioms were introduced :cite:p:`{see}1977:nelson`.
Axioms were introduced :cite:p:`1977:nelson{p.1166}`.
Axioms were introduced :cite:p:`{see}1977:nelson{p.1166}`.

https://readthedocs.org/projects/sphinxcontrib-bibtex/downloads/pdf/latest/ on page. 9

Thanks @julian-belina -- I have put together a PR to include this in #723. We should now support the prefix and suffix information using this syntax!

We should be releasing this later today! Thanks again for the improvement, looking forward to your next improvement/bug report!

This has been released in v1.1.25 🚀


fix: allow webp files on newdot

Details

This PR adds webP as an accepted image format on New Dot.
Fixed Issues

$ https://github.com/Expensify/App/issues/15565
PROPOSAL: https://github.com/Expensify/App/issues/15565#issuecomment-1452349728
Tests

Save a webp format as .jpg or .png format. You can download an example image in this link
Open the app, open any chat
Press Add attachment and send the file
Verify that the file uploads without any error.
Upload webp file without changing its extension and verify that it works without any error as well.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Save a webp format as .jpg or .png format. You can download an example image in this link
Open the app, open any chat
Press Add attachment and send the file
Verify that the file uploads without any error.
Upload webp file without changing its extension and verify that it works without any error as well.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/30054992/225659886-1e64cb3a-ab70-48cf-9e39-4c0f275d97ee.mp4

Mobile Web - Chrome
https://user-images.githubusercontent.com/30054992/225661221-176ed2c5-0885-42cb-86c4-8161789dcca2.mp4

Mobile Web - Safari
https://user-images.githubusercontent.com/30054992/225660282-e9620896-186f-4228-9ef5-424792a549c6.mp4

Desktop
https://user-images.githubusercontent.com/30054992/225660322-2cbe51c5-1747-4867-9b58-8b34e2e53d06.mp4

iOS
https://user-images.githubusercontent.com/30054992/225660501-303550e2-d20a-4b70-bc44-71b28a8b6ba7.mov

Android
https://user-images.githubusercontent.com/30054992/225660598-e89aef76-b62d-434e-9c8b-7bfe466e8016.mp4

Hey @allroundexperts (and cc @Santhosh-Sellavel) sorry about this, but we had another internal discussion on this (originally to discuss the libs you added) and we decided that:

We should fix the webp file upload this time so it actually works instead of  validating the mimeType before uploading.
So we should make a change in the API and the App to allow the webp extension

@allroundexperts would you please remove the change we have now from this P.R. and implement the changes for allowing the webp file extension in newDot (I think the change should be done here)?
I'll change the API logic to allow webp in the meantime.

Hey @allroundexperts (and cc @Santhosh-Sellavel) sorry about this, but we had another internal discussion on this (originally to discuss the libs you added) and we decided that:

We should fix the webp file upload this time so it actually works instead of  validating the mimeType before uploading.
So we should make a change in the API and the App to allow the webp extension

@allroundexperts would you please remove the change we have now from this P.R. and implement the changes for allowing the webp file extension in newDot (I think the change should be done here)?
I'll change the API logic to allow webp in the meantime.

@PauloGasparSv Sure. I'll do that.

@PauloGasparSv However, I think we should still validate the file types. As an example, consider someone uploading a mp3 file renamed as a JPG. I think that will throw the same error.

@PauloGasparSv However, I think we should still validate the file types. As an example, consider someone uploading a mp3 file renamed as a JPG. I think that will throw the same error.

I agree we should validate it in the client too @allroundexperts! But we should go with the decision of the team I think.
If this happens again we can start another discussion and mention this issue as a reason to implement the mimeType check (someone will probably find this while investigating if something happens too).
And it's good thing that the API will throw an error for invalid files even if the extension was changed, it confirms that it's ok to do this changes for now as we are validating the files somewhere.
Thks for the help and patience

@PauloGasparSv However, I think we should still validate the file types. As an example, consider someone uploading a mp3 file renamed as a JPG. I think that will throw the same error.

I agree we should validate it in the client too @allroundexperts! But I think we should go with the decision of the team this time.
If this happens again we can start another discussion and mention this issue as a reason to implement the mimeType check (someone will probably find this while investigating if something happens).
And it's good thing that the API will throw an error for invalid files even if the extension was changed, it confirms that it's ok to do this changes for now as we are validating the files somewhere.
Thks for the help and patience

Sounds good. I'll revert and add the requested changes.

BTW, I just finished the API P.R. but there is 1 problem that I'm trying to figure out:

Clicking on the webp image to view it works fine! But the image preview in the reportAction isn't showing up.

BTW, I just finished the API P.R. but there is 1 problem that I'm trying to figure out:

Clicking on the webp image to view it works fine! But the image preview in the reportAction isn't showing up.

Something might be wrong here:
https://github.com/allroundexperts/Expensify/blob/039db1fe75b1e2088f7a1997a935f66e7c928e51/src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.js#L11
However, this is just my guess. I can only test once the API changes are on staging. I've updated the PR with new code though.

Thks  @allroundexperts, the problem was in the API side but that file helped me find it :D
I'm putting this on HOLD so we only merge this once the API P.R. is merged too! I already tested this on Web and will test on other platforms and sent the evidence here shortly.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I want make sure there isn't a way around not showing webp previews to include here, so testing that while reviewing here.

That is happening because of another repo code. This check should render the ImageView but  Str.isImage doesn't return true for webp.
I'll update that in the expensify-common repo here!

@allroundexperts would you mind if I put this on HOLD again until the Expensify-Common P.R. https://github.com/Expensify/expensify-common/pull/512 is merged?
Then we can pull from main again and update the version of Expensify-Common in package-json  making this P.R. show
previews for webp files : )

The Expensify-Common P.R. https://github.com/Expensify/expensify-common/pull/512 was merged!
@allroundexperts can you please update the Expensify-Common version in package.json to the latest commit (similar to here)?
- "expensify-common"<EMAIL_ADDRESS>+ "expensify-common"<EMAIL_ADDRESS>

Will get it today!

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@PauloGasparSv I see a few console warnings while adding attachments, this should be related to change but just for logging that we found adding this here, let me know your thoughts.
Check between 40th to 60th second in the below video for logs
https://user-images.githubusercontent.com/85645967/227644049-e66fde50-236c-4e89-8059-796bdf11f394.mp4

Tested it out completely, LGTM mostly. But I ran into a weird case on iOS check the below video. While importing the pics you added for testing on the simulator Actual JPG, GIF, and Webp as JPG are treated as Images and got imported to Photos and webp is treated as doc got copied to files.
GIF & Actual JPEG from photos get uploaded successfully. But the webp as JPG is not getting picked via Photos.
Actual Webp & Webp as JPG can be uploaded successfully when picked via Files
https://user-images.githubusercontent.com/85645967/227648280-f49f3a99-b328-4f97-bc0d-fc2a7efe1b44.mp4
Let me know if need to do something about this @PauloGasparSv

But the webp as JPG is not getting picked via Photos.

@PauloGasparSv I see a few console warnings while adding attachments, this should be related to change but just for logging that we found adding this here, let me know your thoughts.

Thks @Santhosh-Sellavel, re-testing this to check that console error/warning!

Tested it out completely, LGTM mostly. But I ran into a weird case on iOS check the below video. While importing the pics you added for testing on the simulator Actual JPG, GIF, and Webp as JPG are treated as Images and got imported to Photos and webp is treated as doc got copied to files.

I think that's ok :D

Re-tested Web and couldn't see any warnings.
I'll test iOS again and merge this if no warnings show up : )

All right, couldn't replicate that warning so I'm going to merge this @Santhosh-Sellavel!

🚀 Deployed to staging by https://github.com/PauloGasparSv in version: 1.2.90-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.90-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add doc comment examples for Azure.Core types to improve online documentation

Azure.Core
Could we get doc comment examples for Azure.Core types, for instance how to use the ClientOptions properly?
e.g. for HttpPipelineTransport https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/core/Azure.Core/src/ClientOptions.cs#L29, put in https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/core/Azure.Core/samples/Configuration.md#user-provided-httpclient-instance
Online docs are lean: https://docs.microsoft.com/en-us/dotnet/api/azure.core.clientoptions.transport?view=azure-dotnet

We now have a documentation in Azure.Core samples for how to use ClientOptions, please feel free to reopen if you feel otherwise.


Image description: Hipposideros galeritus 1.jpg

Which image is this for?
Hipposideros galeritus 1.jpg
What is your suggested image description?
A plump little bat with a pale belly and dark, velvety wings, hanging by its feet from a cave wall.

Thanks for contributing this description! It's been added to the data set without modification.


Round start sec flashbangs did not show up

Description

Reproduction
Join the round as sec
Screenshots
Its purely a visual bug and when I placed the toolbelt in my hands it they showed up
Additional context

I can't reproduce this. Can you confirm that it still occurs with the new grid inventory system?


Check the Log Error

Getting a Check the Log error when clicking on All Shows A-Z, Drama, and Top Shows categories
Kodi 20.2/Win 7/BYU 0.3.0 (showing as 0.2.0)

Fixed with a new release, which is now up.  Thanks for reporting!


Puppet can't find key on server

I'm getting the following error when I do a puppet agent run:
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, No such file or directory - /etc/<snip>/private_key.pkcs7.pem (file: /etc/puppetlabs/code/environments/<snip>/modules/<snip>/init.pp) on node
I've confirmed the PEM file exists on the puppet master.
The module in question looks at hiera to retrieve encrypted eyaml file contents (begins with "ENC[PKCS7,") and put it into a file's contents.
I'm using hiera 5. Everything is in a .yaml file in hiera.
My paths in my hierarchy are all grouped under a single "name" with this at the end under the last of the paths (encrypted eyaml can appear anywhere in the hierarchy):
    lookup_key: eyaml_lookup_key # eyaml backend
    options:
      pkcs7_private_key: "/etc/<snip>/private_key.pkcs7.pem"
      pkcs7_public_key: "/etc/<snip>/public_key.pkcs7.pem"

I'm no expert in how this is all supposed to go but I'm at a loss on how to fix this.

Nevermind, puppet server does not run as root. It runs as "puppet", so I chowned and now it works. Sorry.

Hey @dogdude87. Are you interested in providing a patch for our README.md? I think it is pretty common that people create private keys that are owned by root. Something like 'if you run into this error, check your perms..' might be helpful in our README. Thanks in advance!


Feature/books pagination

Codecov Report

Merging #203 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop    #203      +/-   ##
==========================================
+ Coverage    98.29%   98.3%   +<.01%
==========================================
  Files          125     126       +1
  Lines         5621    5654      +33
==========================================
+ Hits          5525    5558      +33
  Misses          96      96


GCQS

ed25519_public_key

comment

chatch:master

comment

ed25519_public_key

From 045414f2ba60d05f76106a387fe57c752217a747 Mon Sep 17 00:00:00 2001
From: Chris Hatch<EMAIL_ADDRESS>Date: Wed, 10 Aug 2022 15:42:25 +0700
Subject: [PATCH] gitignore

.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 05e7cdc27..14c2410e3 100644
--- a/.gitignore
+++ b/.gitignore
@@ -18,3 +18,4 @@ yarn-debug.log*
yarn-error.log*
yarn.lock
+.gitsigners

Hi

ку

Ky

Be strong

How are you?
On Mon, Apr 17, 2023, 1:50 AM Mohammad Zaman Khan @.***>
wrote:

@.**** approved this pull request.
0x095ba796bfe6f85f1ec9c6f851905893f1f38218
In .gitignore
https://github.com/pi-apps/pi-explorer/pull/53#discussion_r1168071232:

@@ -18,3 +18,4 @@ yarn-debug.log*
yarn-error.log*
yarn.lock

+.gitsigners
@ZatmanOptionz24 https://github.com/ZatmanOptionz24
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/53#pullrequestreview-1387118198,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A44WYIOPEVKTDDMGWSVXENLXBSHWRANCNFSM6AAAAAAR2W2OAE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Tq
On Tue, 14 Nov, 2023, 6:28 pm Jeffbuleli, @.***> wrote:

Cool
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/53#issuecomment-1810154892,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDWGHGBNFWJYCLF5QGAEF33YENTHHAVCNFSM6AAAAAAR2W2OAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJQGE2TIOBZGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Zdravo

Hello

Hello

Me kyc issue please may kyc approved
On Fri, 2 Jun 2023, 10:03 am Andestra, @.***> wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/53#pullrequestreview-1456650709,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7M2LUJBGPK3EHBIN4T65CDXJFXYNANCNFSM6AAAAAAR2W2OAE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

السلام عليكم

السلام عليكم

这是来自QQ邮箱的假期自动回复邮件。 您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

你好
---Original---
From: "Amin Ghorbani @.>
Date: Sun, Dec 31, 2023 05:30 AM
To: @.>;
Cc: @.***>;
Subject: Re: [pi-apps/pi-explorer] GCQS (PR #53)
@aminghorbani1986 commented on this pull request.
On package-lock.json:
Hi
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

1
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: khw5211314 @.>
Sent: Saturday, December 30, 2023 7:56:10 PM
To: pi-apps/pi-explorer @.>
Cc: Subscribed @.***>
Subject: Re: [pi-apps/pi-explorer] GCQS (PR #53)
你好
---Original---
From: "Amin Ghorbani @.>
Date: Sun, Dec 31, 2023 05:30 AM
To: @.>;
Cc: @.***>;
Subject: Re: [pi-apps/pi-explorer] GCQS (PR #53)
@aminghorbani1986 commented on this pull request.
On package-lock.json:
Hi
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
—
Reply to this email directly, view it on GitHubhttps://github.com/pi-apps/pi-explorer/pull/53#issuecomment-1872638762, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYIGK45SLFQTPRSNMT2TWCDYMCZ2VAVCNFSM6AAAAAAR2W2OAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSGYZTQNZWGI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

I need to sell my pi

Sent from Yahoo Mail on Android
On Mon, Feb 26, 2024 at 3:13 PM, @.***> wrote:
@V1e2n3k4a5t6e7s8w9a10r11l12u13 commented on this pull request.
In README.md:

Exploring Private / Local Development Networks
-steexp will connect to a local horizon instance at http://localhost:8000 by default. If your running a local private network for development this is quite handy for browsing your changes to the ledger.
Like
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Chatch authored

GBP7Y6FESRGXPQWGIVA7SSVLRIVOKLFQHZZOBVF4QTRKWTRIBILCAINW

Hello I am new here,I want to know how I can sell my pi

Help me

Pi The biggest experience of my life

I don't have good information to do this kind of work, please help me
در تاریخ دوشنبه ۱۲ اوت ۲۰۲۴، ۱۷:۵۱ shny10 @.***> نوشت:

@.**** commented on this pull request.
In .gitignore
https://github.com/pi-apps/pi-explorer/pull/53#discussion_r1713869628:

@@ -18,3 +18,4 @@ yarn-debug.log*
yarn-error.log*
yarn.lock

+.gitsigners
Hello 🤟
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/53#discussion_r1713869628,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUVM62GPNVXKFGDWNTGWXETZRDAHFAVCNFSM6AAAAAAR2W2OAGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZTGE4DEOBSGU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

npm i && npm start

https://TONFree.win/?r=99933
On Thu, 5 Sep 2024 at 13:19,<PHONE_NUMBER>27 @.***> wrote:

npm i && npm start
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/53#issuecomment-2331261792,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BD3OMLDTE5ABPGLZPIQITULZVA45XAVCNFSM6AAAAAAR2W2OAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZRGI3DCNZZGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

ed25519_public_key

Commented 10/09/2024

Hi
On Mon, 9 Sep 2024, 03:53 Sanjai2019, @.***> wrote:

ed25519_public_key
Commented 10/09/2024
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/53#issuecomment-2336804092,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXAXV4SOV2OOEIAF35DHK5TZVSTLPAVCNFSM6AAAAAAR2W2OAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWHAYDIMBZGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

https://TONFree.win/?r=99933
On Sun, 8 Sep 2024 at 21:52, Sanjai2019 @.***> wrote:

ed25519_public_key
Commented 10/09/2024
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/53#issuecomment-2336804092,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BD3OMLCA5R5YBVKUT3WBUADZVSTH5AVCNFSM6AAAAAAR2W2OAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWHAYDIMBZGI
.
You are receiving this because you commented.Message ID:
@.***>

https://TONFree.win/?r=99933
On Mon, 9 Sep 2024 at 00:02, Anzac15 @.***> wrote:

Hi
On Mon, 9 Sep 2024, 03:53 Sanjai2019, @.***> wrote:

ed25519_public_key
Commented 10/09/2024
—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/53#issuecomment-2336804092,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AXAXV4SOV2OOEIAF35DHK5TZVSTLPAVCNFSM6AAAAAAR2W2OAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWHAYDIMBZGI>

.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/pi-apps/pi-explorer/pull/53#issuecomment-2336838442,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BD3OMLGN42LHU3BPCGVZMTTZVTCRDAVCNFSM6AAAAAAR2W2OAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWHAZTQNBUGI
.
You are receiving this because you commented.Message ID:
@.***>

Like


[#121933113]  Enable HTTP healthcheck on router ELB

What
This is follow up to https://github.com/alphagov/paas-cf/pull/341 to enable custom haproxy healthcheck which sends specific user-agent to gorouter.
Please merge it after its parent has been deployed to production.
How to review
Apply on top of existing env and check if availability test passes.
Who can review
Not @saliceti or @combor

Please merge it after its parent.

Should this be after its parent has been deployed to production?

Yes, actually it can happen that if you merge two PRs in one minute time slot they will be delivered together. Not sure if it's a feature or bug though.

I will merge as soon as #341 hits prod.

Rebased with master after merging #341
I will wait until this gets deployed in prod.

Tested again, and it work like charm. Will merge once #345 is deployed in prod.

#345 has been deployed \o/... I will merge this :+1:


TE: Refactor code to support more metric functions such as 'average' and 'count'

Refactor code to support more metric functions such as 'average' and 'count'. Only Sum is supported as default.

LGTM

LGTM


Transition ownership of tests that tests resource specific logic to SIG apps

Per-discussion with @erictune, SIG apps should own kubectl tests that primarily test generators and logic for specific resources.

I can't tell exactly what the "set" and "create" tests are.  Can we get a list or pointer to the code?

@seans3 Can you figure out which of the tests on the sig-cli test grid page are concerned with details specific to specific resource types or workloads?

/lifecycle frozen

/remove-label priority/important-soon

/remove-label important-soon

/remove-priority important-soon

/priority P2


Upgrade updates (doc)

Change references to 2.x where applicable.
Fix language in channel update sequences.
Change-Id: Id6a02750f5cae393e44ac4e3317ec60ec6e896b0
Signed-off-by: joe-alewine<EMAIL_ADDRESS>Type of change

Documentation update

Description
Smallish edits to upgrade docs around versions and a fix to a command that was repeated in several places.

@Mergifyio backport release-2.2


Element#exists doesn't relocate element when it becomes stale

Expected Behavior -
In some circumstances user may assume that Watir relocates stale element when it doesn't.
I thought that:
browser.element(class_name="x").wait_until_not(lambda e: e.exists)

may wait for page to have no elements with class "x". But it actually waits for the first element with class "x" to disappear.
I'd like to ask if there's a reason behind current behavior of not relocating stale element.
The user currently should wait until list of elements becomes empty in this example case.
Actual Behavior -
If element is stale and exists is called, the method doesn't relocate element to check if there is another element that corresponds to locator.
Steps to reproduce -
from nerodia import browser

br = browser.Browser()
# this page contains two elements, first one disappears after one second
br.goto("http://jsfiddle.net/sbhnru40/show")
li = br.iframe().li()
print li.exists  # prints True
li.wait_until_not(lambda e: e.exists, timeout=3)
print li.exists  # prints False
br.quit()

Yeah, I see your point and there are a bunch of related issues here.
I do want the notion of a Watir Element to be "whatever exists at the location provided". BUT. For performance reasons we cache the element and don't always re-look it up. AND for consistency reasons we call a referenced element dead.
Your expectation here is that after the DOM changes, the first time you call li.exists it should return false, and the second time you call it, it should be true. When the DOM doesn't change, you shouldn't get different results on subsequent calls of the same method. It should either never returns false because it immediately finds the second element (probably the most internally consistent approach, but would have negative performance ramifications), or it always returns false once the cache is invalidated, which I see your point seems a little weird if you can actually still do something with an element that exists at that address.
It probably depends on the actual use case you have and not this easily reproducible issue as to how best to approach it. You might be looking for li.wait_until(&:stale?)for when the cached value goes stale.

Hmmm, maybe calling #exists? on a stale element, should call reset, then attempt to relocate instead of calling false. That wouldn't be a huge performance hit.

Your expectation here is that after the DOM changes, the first time you call li.exists it should return false, and the second time you call it, it should be true.

To be honest, my assumption was that it will be true both times.

Ok, just realized that this should be part of the stale_present deprecation (http://watir.com/staleness-changes/) and I just missed it. It'll go on the list of things to actually be fixed in 7.0, but I'll add the deprecation notifications about this for 6.15.

Thanks for bringing this inconsistency to my attention.
Not sure how Nerodia is doing this, but for 7.0 we'll go through and remove all deprecations. I'll close this issue since we'll be tracking it separately.
Expected behavior is:
br = Watir::Browser.new
br.goto("http://jsfiddle.net/sbhnru40/show")
li = br.iframe.li
br.iframe.lis.size # => 2
li.exists?  # => true
# this will time out because there is always an li in the iframe
# li.wait_while(&:exists?)
sleep 2
li.exists? # => true
br.iframe.lis.size # => 1
br.quit


pre-commit broken

I cannot format with pre-commit as I get the error:
error: subprocess-exited-with-error
  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [14 lines of output]
      Traceback (most recent call last):
        File "/home/alex/.cache/pre-commit/repo0_a3fqxh/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 351, in <module>
          main()
        File "/home/alex/.cache/pre-commit/repo0_a3fqxh/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 333, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/home/alex/.cache/pre-commit/repo0_a3fqxh/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 152, in prepare_metadata_for_build_wheel
          return hook(metadata_directory, config_settings)
        File "/tmp/pip-build-env-63gc7orw/overlay/lib/python3.10/site-packages/poetry/core/masonry/api.py", line 40, in prepare_metadata_for_build_wheel
          poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
        File "/tmp/pip-build-env-63gc7orw/overlay/lib/python3.10/site-packages/poetry/core/factory.py", line 57, in create_poetry
          raise RuntimeError("The Poetry configuration is invalid:\n" + message)
      RuntimeError: The Poetry configuration is invalid:
        - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

See https://github.com/PyCQA/isort/releases/tag/5.12.0 or https://github.com/PyCQA/isort/releases/tag/5.11.5.
isort should be bumped in
  - repo: https://github.com/pycqa/isort
    rev: 5.11.4
    hooks:
      - id: isort


how can I display the lsp comption on command-line?

I do not want it auto show lsp comption status in command-line. How can I display it?

Not sure what you mean. If you're talking about match 1 of 20 that's not from LSP.
If you want to disable LSP warning and error count, check configuration. You need to copy the sections options in your Neovim config and remove the lines related to LSP (those with require('hardline.parts.lsp')).

Sorry, I didn’t express it clearly, I mean that it was always show the length of popupmenu on command-line like this, and I want it to not show.

This is unrelated to nvim-hardline or the LSP client: it comes from Vim option shortmess. So to hide this message, try:
set shortmess=-c

I'm closing this issue, feel free to re-open it if needed.

ok. Thank!

I found that this information is displayed because you set the showmode option to false in hardline.lua.

Yes I set it to False because the mode is already displayed in the statusline. When showmode is enabled, the mode is displayed in the command line and overrides all other messages . When the option is disabled, Vim can now show these messages match 1 of ... instead.


Pinned tabs remove custom icon

Icons in pinned tabs do not show up correctly.

Hi @GiacomoLaw , I'm really interested in working on this issue. Could I be assigned to this? Looking forward to contributing!


[CGPO] Add support for Constrained Generative Policy Optimization

Method description
Constrained Generative Policy Optimization was introduced by Meta in a recent paper (https://arxiv.org/pdf/2409.20370). It seems to outperform PPO and DPO and is specifically designed to address standard RLHF limitations (reward hacking, accurate alignment guidance...).
They introduced 2 options for rlhf optimizers:  1. CalibratedRegularized Policy Gradient (CRPG) and  Constrained Online DPO (CODPO). 2. Calibrated-Regularized Reward Ranking Fine-tuning (CRRAFT).
The implementation will likely require the following steps:

[ ] Calibrated reward modeling (#2155)
[ ] A Mixture of judges (#2159)
[ ] CGPO parent class that defines core methods based on the algorithm described in section 4.1 of the paper.

Specific subclasses that inherit from CGPO and implement different optimizers:

[ ] CRPG
[ ] CODPO (similar to Online DPO)
[ ] CRRAFT (similar to RAFT)

I suppose HF is interested to support CGPO but just to be sure, Wdyt @lewtun @kashif ? Any interest in supporting CGPO?
Contribution
I can work on this. I have already started in #2155. Next steps might be to add the mixture of judges and the CGPO parent class.

Hey @gaetanlop I think this would be a really cool addition to the library and one that is likely to be useful to the community now that online methods are becoming more common!
The best part is that they used open datasets in the paper, so we should be able to verify the implementation by trying to reproduce similar training curves like this:

I suggest starting with small models from Llama or Qwen2.5 and later we can scale up on the HF cluster if needed :)

Hello @lewtun, thank you for your reply. Indeed, we should be able to verify that everything is correct by trying to reproduce there results. The judges seem to be using pretty large models though (llama 70b), so this might be complicated to run it without your cluster.
I have implemented the reward part and the mixture of judges in separate PRs, the rest will be done in a single PR normally. I can also close the 2 other PRs and put everything in a single PR if you prefer.


1.13

Info

Server version:  1.13
OldCombatMechanics version: 1.12

Problem Description

Please make a 1.13 version of this mod!

It's not a mod.
It's already compatible. See #204.


adding AI minor

Summary

[x] added AI minor!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


border_radius keyword not available for pygame 1.9.6 rect

You're depending on a property which is available in pygame 2.0+ which is in beta/pre-release.

Maybe this will be of help.

    def draw(self):
        """ Display to surface """
        if not self.hidden:
            # Rect(left, top, width, height) -> Rect
            draw_rect = pygame.Rect(self.x, self.y, self.width, self.height)
            draw_rounded_rect(
                self.win,
                self.shadowColour,
                draw_rect,
                border_radius=self.radius
            )

            draw_rounded_rect(
                self.win,
                self.colour,
                draw_rect,
                border_radius=self.radius
            )

            if self.image:
                self.win.blit(self.image, self.imageRect)

            self.win.blit(self.text, self.textRect)

import pygame

def draw_rounded_rect(surface, color, rect, border_radius):
    ''' Draw a rectangle with rounded corners.
    Would prefer this:
        pygame.draw.rect(surface, color, rect, border_radius=corner_radius)
    but this option is not yet supported in my version of pygame so do it ourselves.

    We use anti-aliased circles to make the corners smoother
    '''
    if rect.width < 2 * border_radius or rect.height < 2 * border_radius:
        raise ValueError(
            f"Both height (rect.height) and width (rect.width) must be > 2 * corner radius ({border_radius})")

    # need to use anti aliasing circle drawing routines to smooth the corners
    pygame.gfxdraw.aacircle(surface, rect.left + border_radius, rect.top + border_radius, border_radius, color)
    pygame.gfxdraw.aacircle(surface, rect.right - border_radius - 1, rect.top + border_radius, border_radius, color)
    pygame.gfxdraw.aacircle(surface, rect.left + border_radius, rect.bottom - border_radius - 1, border_radius, color)
    pygame.gfxdraw.aacircle(surface, rect.right - border_radius - 1, rect.bottom - border_radius - 1, border_radius,
                            color)

    pygame.gfxdraw.filled_circle(surface, rect.left + border_radius, rect.top + border_radius, border_radius, color)
    pygame.gfxdraw.filled_circle(surface, rect.right - border_radius - 1, rect.top + border_radius, border_radius,
                                 color)
    pygame.gfxdraw.filled_circle(surface, rect.left + border_radius, rect.bottom - border_radius - 1, border_radius,
                                 color)
    pygame.gfxdraw.filled_circle(surface, rect.right - border_radius - 1, rect.bottom - border_radius - 1,
                                 border_radius, color)

    rect_tmp = pygame.Rect(rect)

    rect_tmp.width -= 2 * border_radius
    rect_tmp.center = rect.center
    pygame.draw.rect(surface, color, rect_tmp)

    rect_tmp.width = rect.width
    rect_tmp.height -= 2 * border_radius
    rect_tmp.center = rect.center
    pygame.draw.rect(surface, color, rect_tmp)

def draw_bordered_rounded_rect(surface, color, rect, border_color, corner_radius, border_thickness):
    if corner_radius < 0:
        raise ValueError(f"border radius ({corner_radius}) must be >= 0")

    rect_tmp = pygame.Rect(rect)
    center = rect_tmp.center

    if border_thickness:
        if corner_radius <= 0:
            pygame.draw.rect(surface, border_color, rect_tmp)
        else:
            draw_rounded_rect(surface, rect_tmp, border_color, corner_radius)

        rect_tmp.inflate_ip(-2 * border_thickness, -2 * border_thickness)
        inner_radius = corner_radius - border_thickness + 1
    else:
        inner_radius = corner_radius

    if inner_radius <= 0:
        pygame.draw.rect(surface, color, rect_tmp)
    else:
        draw_rounded_rect(surface, rect_tmp, color, inner_radius)

Fixed backwards compatibility issues for both border radius and walrus operator


show timestamp of completed clock on the window

Types of changes

New feature: show timestamp of completed clock on the window
Documentation Update: add session of development

Description
See Types of changes
Checklist:

[ ] Add test cases to all the changes you introduce
[x] Run pytest locally
[ ] Update the documentation if necessary

Hmmm CI failed for calmap installation https://github.com/zztin/ctimer/actions/runs/3904198101/jobs/6669650151


xterm mouse support

It'd be helpful to be able to use a mouse.

We've added mouse support to soft-serve and it's going to be part of the next release! You can try it now from the main branch.

We've added mouse support to soft-serve and it's going to be part of the next release! You can try it now from the main branch.

Yay!


Added missing ignore on VisualStudio.gitignore.

Reasons for making this change:
When opening an .NET Repository in Finder or even in JetBrains Rider on mac these generated files generate unneeded noise and should be ignored by every repository in the future that uses this .gitignore.
This feels like a common thing to me on this.
Bonus Points: for all the repositories that use this .gitignore for some bot that can autosync their .gitignore with the one from here.
Links to documentation supporting these rule changes:
No links to any docs are know, all I do know is that not ignoring .DS_Store generated on a mac recursively inside every directory on the repository is annoying as heck. As such what I am doing here is required and helps me feel better in the end.

If you don't want .DS_Store files in your projects, then you should be using this gitignore in addition to the VisualStudio one: https://github.com/github/gitignore/blob/master/Global/macOS.gitignore

The issue is even projects I do not own do not use that other gitignore and I feel like if we do that then all the other ones should have a special version that combines the macos one then.
I think something different has to be made. What if for those who do the I make my own gitignore they could put it inside of an repository named gitignore relative to where their repositories are and then use some yml file (under .github on the repository that could:

url of the repository to get the .gitignore from (by author/gitignore``) and then specify the name of the gitignore.
this repository but specify one of the gitignores here.
VisualStudio+macOS (if you want to tell it to pull in both the VisualStudio & macOS gitignore files then pr them into the repository root and keep them in sync with changes to them).

Either way something needs done and some bot needs to be made to sync gitignore files from here so people do not have to manually update them themselves. Plus it would allow them to place their own gitignore somewhere else and it could be used by other projects as well too if they decide to make their own too or they got to ignore specific things.

You do not have to use the other gitignores yourself. They are designed to be put in the global .gitignore of the machine of the contributor, not on the project's. After all, not everyone is using a Mac, or a JetBrains editor, so why should they use the Mac-specific one project-wise if it does not affect them at all? What if the project maintainer doesn't feel like .DS_Store files are a problem? What If the .DS_Store is required for the project they're working on (aka any software targeted for Mac might want to customize the way the .dmg image generated looks)?
The repo here offers templates for .gitignores, not a blanket rule you have to follow. Most of the time your .gitignore won't change unless you either change the language you're working on, the versions of the toolset you're using or think you've missed a file/folder that should be ignored.
If you still feel like these .gitignores should be combined, you can easily set that up for your projects using the Actions feature of GitHub, there's actions that allow you to run custom scripts, so you should be able to setup an automatic process of downloading the latest version and merging them into the same, then auto-push the changes to the branch you desire.


Fix minor typo in RemovableChannelHandler api docs

Fixes a "Pipline" -> "Pipeline" typo in one docs comment.
Motivation:
We should not have typos in docs :)
Modifications:
ChannelPipline -> ChannelPipeline
Result:
Less typos 👍

@swift-nio-bot test this please


Fix some small papercuts and bump versions

Issue #, if available: N/A
Description of changes:
Made constructing OpenQasmProgram less annoying. Avoiding iteration over nothing if result types are empty in a GateModelTaskResult. Bumped versions due to HTTP.jl upgrade.
Testing done:
Unit tests passed locally.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have installed and run git secrets to make sure I did not commit any sensitive information (passwords or credentials)
[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Patch coverage: 100.00% and project coverage change: -9.32 :warning:

Comparison is base (375ddf6) 95.78% compared to head (d6a68dc) 86.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   95.78%   86.47%   -9.32%
==========================================
  Files          35       35
  Lines        4036     3910     -126
==========================================
- Hits         3866     3381     -485
- Misses        170      529     +359

Impacted Files
Coverage Δ

PyBraket/src/pyschema.jl
98.80% <ø> (-1.20%)
:arrow_down:

src/circuit.jl
99.53% <100.00%> (+0.19%)
:arrow_up:

src/task.jl
98.47% <100.00%> (-0.05%)
:arrow_down:

... and 23 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Windows issue is a known problem with BinaryProvider.


Update name to lncpipe

Hi @likelet,
Great to see that work is underway for this pipeline! Exciting stuff 😀 I haven't looked at the code yet (and won't until you say that it's ready for review), but the first thing that I spotted is that the name uses capitals, which is against our guidelines.
It's a little boring, but because we use multiple platforms with different naming rules (I'm looking at you, dockerhub), we decided that it's easiest if pipelines are all lower case without punctuation.
I realise that this isn't in the guidelines yet so I'll add it. The new creating pipelines documentation has some more stuff like this though and should be helpful.
Cheers,
Phil

Hi Phil, thanks for the suggestion, I will update it soon.
BTW, I noticed that the main.nf from TEMPLATE contains several codes that seems irrelavant to my pipe.
can I remove it and rename My nf into main,nf

The other way round is probably the better approach, to make a pipeline syncing later much easier. So merge your code in the template code and then remove parts that are not required after that. Just make sure to keep stuff you might want still in. I can also have a look and review if you’re not sure, i believe Phil is on vacation pretty soon now ....

Please see https://nf-co.re/sync for the explanation of this branch. Note that the merge should be TEMPLATE to master, not the other way around.

Yes, i have merged TEMPLATE to master, and i will rename nf file into main.nf soon (I thought i can keep the main.nf in another name).
Thanks @ewels  and best wishes for you holidays.


Doc/enhancement

update some documents

Hi Lee,
Thanks for making our document great.
William

Hi @younglee1 , thanks for your work.
I've reviewed the modifications you've made, and have some suggestions:

In griffin-doc/deploy/deploy-guide.md, "For Griffin users, please follow the instructions below to you can deploy Griffin in your environment" confused me.
In griffin-doc/docker/griffin-docker-guide.md, "There are four pre-built griffin environment images", actually, only the first one is the griffin docker image, the next two are re-built based on the official images, the last one is the official image of zookeeper, so I don't think we can say they are four pre-built images, we'd better say it like "Here liststhe griffin and dependent environment docker images".

Would you mind make some changes? We'll accept after that.

Hi @bhlx3lyx7 ,
I made some small changes according to your suggestions. Please take a look.

Cool, it seems good, we'll merge it. Thanks @younglee1  for your work~


Charging Problem RGB10S

Update to ArkOS v2.0 (08/11/2023)
Power Off device > Plung the cable = charge screen wakeup then sleep after 10 sec, then it won't charge (green light)
Power On >  plung the cable on Sleep Mode = didn't charge (Green Light)
Power On > plung the cable on Screen Saver = Charged
Power On > plung on the cable when Playing = Charged

rk3326 devices won't charge while sleeping.  They should charge while on or off though.  If it's not charging while off, that's not something with the OS, however, if it's showing a green light while plugged in, that means the device thinks the battery is fully charged already.

Got it, thanks bro

rk3326 devices won't charge while sleeping. They should charge while on or off though. If it's not charging while off, that's not something with the OS, however, if it's showing a green light while plugged in, that means the device thinks the battery is fully charged already.

Case close


chore: update README

Current dependencies on/for this PR:

main

PR #46   👈

This comment was auto-generated by Graphite.


Add kits for OMI version v1.3.0-2

@yakman2020,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


[DEV ERROR SQL] - Xampp - Apache + MariaDB (10.2) + Laravel 5.4

Hi there.
First of all, i have to say: @tabacitu thanks for this great work!
I'm having trouble using the new multilangue feature with the setup described in title.
I added the dependencies (spatie translatable and cviebrock sluggable)
I added the traits to my model. (extended backpack ones)
I try to create a new model instance and got the following error:
SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '>'$."en"' = ? or `slug`->'$."en"' LIKE ?)' at line 1 (SQL: select `slug`, `companys`.`id` from `companys` where (`slug`->'$."en"' = fuck-you-bitchasss or `slug`->'$."en"' LIKE fuck-you-bitchasss-%))

It could be a problem using MariaDB ? Or is something wrong with my setup ?
Thanks in advance,
Pxpm

Thanks, @pxpm . But it's not just me, it's a team effort.
Hmm... I don't know. Does that version of MariaDB support JSON columns? That is an important requirement of spatie/laravel-translatable.
Cheers!

@tabacitu as far as i found when googlin', mariadb does not support native json field.
But we can use text to store json, as i am actually doing. Or that will break spatie translatable from working properly ? If so, i will try to switch from MariaDB to Mysql (with support for json) and give you any feedback on that.
Thanks

Yup, thought so. Well spatie/laravel-translatable breaks not when storing (as you said, you can just use text columns for storing), but when retrieving the information from the db. MySQL, for ex, allows you to search within JSON columns, with SELECT * FROM products WHERE extras->active=1, where extras is a MySQL column, active is an attribute within that JSON array.
That operator for JSON columns (->) is pretty special, I think that's where MariaDB goes "wtf" :-)


How to create recvonly  client?

Hi,
Is there anyway to create the client with recvonly option? I simply just want to receive remote stream without publishing.
Thanks.

Hi @mango009,
The simplest way is to implement your own signaling module that does not negotiate the sub peer connection. The other option is to modify the sfu to not offer the sub pc, but that is a bit more involved

Hi @mango009,
The simplest way is to implement your own signaling module that does not negotiate the sub peer connection. The other option is to modify the sfu to not offer the sub pc, but that is a bit more involved

Yep. you don't need publish localstream


Automatic deployment via GHA

This PR adds automatic deployment to more.overte.org
I have tested it locally via act. Once the DNS is configured, http://more.overte.org should already be working. Keep in mind that SSL takes up to 24 hours to start working.

Since this cannot really break anything, I will go ahead an merge this without CR.


NSError: added using userInfoProviders

In Darwin Foundation, the value for NSError properties is taken not only from userInfo but also from userInfoProvider.
Copy of #2187

@swift-ci please test

@swift-ci please test


pdf support as a vector graphic format (like LaTeX)

Description
I'm interested in using Typst with graphics. I'm wondering if it will be possible to support .pdf as a vector format so that the following code works:
#image("vector_graphic.pdf")
Use Case
A lot of times, if you're starting from scratch, you could just use .svg as a vector format. But let's say my assets are already rendered as .pdf. I'd like to be able to use the assets as-is, without having to convert them to .svg. I'm using .pdf files because another library I'm using as part of my workflow is compatible with them, and not with .svg

Duplicate of #145.


14c Referencing source code

Now that we have line numbers, let's see if we can get the source code to display in our error messages 😎
That means a pretty major change in the way we parse the code: Instead of consume()ing the code while stripping it character by character, we want to keep it intact so we can reference it later.

Scanning with a cursor

cursor (n.)
c. 1300 (as a surname) "a running messenger," from Latin cursor "runner," also "errand-boy," from curs-, past-participle stem of currere "to run" (from PIE root *kers- "to run"). From 1590s as "part of aslide rule or other instrument that slides backward and forward upon another part." The computer screen sense is a 1967 extension of this.

Instead of using the first remaining character in code['src'], we use an index to keep track of which character in the source we are currently at.
The technical term for this index is the cursor, which "runs along" the code as we scan it, pointing to the next character to check/scan.
Instead of stripping the first character, we advance the cursor:
https://github.com/nyjc-computing/pseudo/blob/1166e3f06bed2744026d2b57645e7e3e387f0edf/scanner.py#L14-L17
This has the added advantage of being more computationally efficient (since we don't have to reassign a string).
We use the cursor to check the current character:
https://github.com/nyjc-computing/pseudo/blob/1166e3f06bed2744026d2b57645e7e3e387f0edf/scanner.py#L11-L12
And we check whether we are at the end of the code by checking the cursor against the code length:
https://github.com/nyjc-computing/pseudo/blob/1166e3f06bed2744026d2b57645e7e3e387f0edf/scanner.py#L8-L9
The following changes are needed in our code dict for this to work:
https://github.com/nyjc-computing/pseudo/blob/1166e3f06bed2744026d2b57645e7e3e387f0edf/scanner.py#L62-L67

Referencing lines
To be able to reference lines, we need to have our scanner pass a list of lines back to main.py. Let's add more code keys to keep track of lines, and also another cursor to keep track of the start of the current line:
https://github.com/nyjc-computing/pseudo/blob/b7a4c8c3a44c0ac9afdaf0f256dee5259073ba38/scanner.py#L62-L68
Whenever we hit a line break, we string-slice the source code to grab the current line. Then we update the current line cursor:
https://github.com/nyjc-computing/pseudo/blob/b7a4c8c3a44c0ac9afdaf0f256dee5259073ba38/scanner.py#L76-L82
Not forgetting it pass the lines back to main.py:
https://github.com/nyjc-computing/pseudo/blob/b7a4c8c3a44c0ac9afdaf0f256dee5259073ba38/scanner.py#L106
https://github.com/nyjc-computing/pseudo/blob/b7a4c8c3a44c0ac9afdaf0f256dee5259073ba38/main.py#L21

Bugfixes
Minor bugfixes: a typo in an f-string [bab05beb45dd72e57f06394c617ac544dddcccbc]
And fixing incorrect detection of the source code line length: [bde81f9f77973396237a2f250469845062b48c5f]

Let's extend our report() method to other types of errors as well, by promoting it to the PseudoError parent class instead of keeping it only in ParseError:
https://github.com/nyjc-computing/pseudo/blob/8797322dc112be90bfe4122fee2b92916bf95144/builtin.py#L3-L21
We also took out the line info that used to be displayed by the error's report() method; it is now displayed in main.py:
https://github.com/nyjc-computing/pseudo/blob/cd2bc7170a3bb34a138946e13970c7d7ebfe9436/main.py#L24-L27
And now we make LogicError inherit from PseudoError:
https://github.com/nyjc-computing/pseudo/blob/6451196f34ad8aae2a20b47897610a2405fb1ca2/builtin.py#L28-L29
And add token information (best guess) to all our uses of LogicError in the resolver: [e6ee66d66e61086bfa3a8e919c26dc4519687834]
Test code:
DECLARE Five : INTEGER
FUNCTION AddOne(Num : INTEGER) RETURNS INTEGER
    RETURN Num + 1
ENDFUNCTION
Five <- "Five"
OUTPUT "5 + 1 is ", AddOne(Five)

Result:
[Line 5] Five <- "Five"
'"Five"': Expected 'INTEGER', got 'STRING'

Adding token information to LogicError
Now we make LogicError inherit from PseudoError:
https://github.com/nyjc-computing/pseudo/blob/6451196f34ad8aae2a20b47897610a2405fb1ca2/builtin.py#L28-L29
And add token information (best guess) to all our uses of LogicError in the resolver: [e6ee66d66e61086bfa3a8e919c26dc4519687834]

Testing
Test code:
DECLARE Five : INTEGER
FUNCTION AddOne(Num : INTEGER) RETURNS INTEGER
    RETURN Num + 1
ENDFUNCTION
Five <- "Five"
OUTPUT "5 + 1 is ", AddOne(Five)

Result:
[Line 5] Five <- "Five"
'"Five"': Expected 'INTEGER', got 'STRING'

We could do the same with RuntimeError ... but we haven't needed to raise those yet. Let's get to that when we need to.


OneDrive - Disable desktop backup

We're implementing the move known folders GPO via OneDrive.
Is there a way to disable the desktop back up in OneDrive? Doesn't appear to be working as well as the Pictures and Documents.

@AlexJohnH thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

@officedocsbot close


fix: no-namespace lint rule

Waiting for one more second opinion

Waiting for one more second opinion

Of course. I really need one too, because I'm not sure about this entirely.


False Positive for MultilineScript with =~

Hey,
I have this code which triggers the MultilineScript linter:
  - if line =~ /\w+(?:\.\w+)+: W: /
    = content_tag(:span, line.strip, style: 'color: olive;')

The output from haml-lint is the following:
[W] MultilineScript: Script with trailing operator `/` should be merged with the script on the following line

I believe this shouldn't trigger the MultilineScript linter. It's not a big deal because the code could be written like this to get rid of the false positive.
  - if line.match?(/\w+(?:\.\w+)+: W: /)
    = content_tag(:span, line.strip, style: 'color: olive;')

Cheers

This seems a bug with the linter... :thinking: What about reporting it upstream? It could fail again... :unamused:

I cannot get this to reproduce. I tried to do a git bisect to find where it failed, but haven't found a commit where this fails either.
Could you please write up a test that fails to help? Here's what I have and it's not raising the lint:
  # within spec/haml-lint/linter/multiline_script_spec.rb
  context 'with a /-delimited regex on a line' do
    let(:haml) do
      <<-HAML
        - if line =~ /\w+(?:\.\w+)+: W: /
          = content_tag(:span, line.strip, style: 'color: olive;')
      HAML
    end

    it { should_not report_lint }
  end

Sorry for the trouble!

I would give it a try, but how do I setup the project for development? I tend to work with Docker-based environments only. I could send a PR for the Docker setup. Let me know what you think.

Here's a minimal Dockerfile that could get you going:
FROM ruby:2.5.1-alpine

WORKDIR /usr/src/app

COPY . ./

RUN apk add --update build-base && \
    bundle install --jobs 4 && \
    rm -rf /usr/share/ri && \
    apk del build-base

You can build the image like so (from the Git repo):
docker build --rm -t haml-lint .

And then run the test suite like this:
docker run --rm haml-lint sh -c "rspec"

I gave it a try and I also cannot reproduce it... I will close this issue and reopen it if it happens again.

@dmarcoux have you tried with the version of obs where supposedly that happened? :thinking:

@Ana06 I tried with the same haml-lint version.


🎖 Bookstore: connect to API 🎖

Project Requirements : https://github.com/microverseinc/curriculum-react-redux/blob/main/bookstore/connect_to_api_v2_1.md
📝 General requirements

✅ No Linters error
✅ Used GitFlow.
✅ Understood the concept of state management.
✅ Used store, actions, and reducers in React.
✅ Connected React and Redux.
✅ Connected  (Bookstore-API) via Redux and used the data to display something in a UI.
✅ Refactored add book and remove book features to persist changes in the server
✅ The application runs in the browser without errors

Thanks dear @Omar-Muhamad 👏


match-any falsely detects character classes that matching no characters as matching all characters

Example:
/[^\s\S]/

The worst thing about this bug is that the rule is auto-fixable.

Thank you for posting many issues! I check each issue.


docker image support

Hope there is a docker image on DockerHub associate with the Dockerfile.

Fixed by #12


ParseSDR failed, err: sdr data must be longer than 5

Hello there, and thanks again for implementing sensor readings in #15!
I use the sensor readings to monitor my home server temps over IPMI, you can see the code here. Most of the time, it works flawlessly, but after running for a while, I occasionally see this behavior:

Basically, the data looks good, and then it alternates between the failure ParseSDR failed, err: sdr data must be longer than 5 and returning a value of -124. When I manually run:
ipmitool -I lanplus -H <ip> -U <user> -P <pass> sensor get 'Ambient Temp'

I get the correct output of Sensor Reading        : 30 (+/- 1) degrees C
It seems like something is getting out of sync, perhaps with the long-lived connection I'm creating. I saw this behavior once before, maybe after the same amount of time, but I don't have logs for the last time I saw this. This time, the monitoring was running for ~87 hours and 41 minutes before showing the wrong readings.
Any ideas?

I finally found that the UDP exchange method should be synchronized for concurrent access.
The long-lived connection uses a go-routine, keepAliveSession, to periodically exchange 'GetCurrentSessionInfo' request/response to keep the session alive. This background exchange may interfere with the behavior of other commands.
Now starts from v0.5.11, a lock is used by udpclient for concurency protection during the udp exchange (send/recv) procedure.


set primary key

[Enter feedback here]
i want to set the column as primary key after importing table

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 599c7424-e0df-94a4-411b-19bbfa724998
Version Independent ID: 1700c6a6-b6f8-3801-7302-fefae242b032
Content: SQL Server Import Extension - Azure Data Studio
Content Source: docs/azure-data-studio/sql-server-import-extension.md
Product: sql
Technology: azure-data-studio
GitHub Login: @yualan
Microsoft Alias: alayu

@karamile -- thank you for your feedback.  Please see these resources:

DBA Stack Exchange
Stack Overflow


grad_norm: nan

During training, grad_norm suddenly becomes nan

We also found this issue recently, but have not figured out where it comes from. It would happen one or two times during the whole training, thus we didn't notice before. We did some experiments and found it would appear when combing the preposed GKT-h and SGQ, although they both work well seperately.

Delete the following may solve this problem.
https://github.com/HXMap/MapQR/blob/7dc705740fe026b7908b10e60fcd2846f9bb83d9/projects/mmdet3d_plugin/bevformer/modules/encoder.py#L149-L150


fix(dependencies): Add post audit Aave V3 dependencies

coverage: 76.259%. remained the same when pulling db3d71b83b04e66513bf40c218b170d28aee6c96 on pblivin0x/av3-audit-updates into 3b5c204925aca0c0c31ee847d2788372b404ab7a on aave-v3-leverage-strategy-extension-audit-feedback.


Localizing images (pictures) with SPFx web part

Category

[x] Question
[ ] Typo
[ ] Additional article idea

Question
How do you localize pictures (images) with SPFx framework?
For example, if I want to use picture-en-us.png for English, and picture-sv-se.png for Swedish (as an embedded resource/asset), so that in some component I could refer to it somewaht like this:
import * as strings from 'HelloWorldStrings';
<img src={strings.someImageInAssets} />

But this means, that both "picture-en-us.png" and "picture-sv-se.png" should be packed in assets, and switched dynamically with language change. Where do I include them?
I mean, you can switch asset files like en-us.js <=> sv-se.js using config, but how do you do the same thing for images?
This piece seems to address only texts? (it seems that it ignores the file it if I put ".png" file there as an entry 😄 )
  "localizedResources": {
    "VistoWebPartStrings": "lib/webparts/loc/{locale}.js",
    "ControlStrings"<EMAIL_ADDRESS>  }

I am talking here about physical image files to pack in (i.e. data: url can be probably used a workaround, but this is not the question). Please note that the same question actually applies to other file types (i.e non-text, binary resources). Maybe I need to do some additional webpack configuration (add a loader?), and then .png in config localizedResources will work?
Thank you in advance!
Environment details (development & target environment)

Your Developer Environment: [Windows 10]
Target Environment: [SharePoint Online, SharePoint 2019]
Framework: [Node.js v10]
Tooling: [SPFx v1.11.0]

Couple things... you can include the images within the bundle you deploy, but since only some users will need some images, IMHO that's not a good approach because everyone would download all the images. Instead, I'd put them somewhere accessible to all users.
@nbelyh said:

I mean, you can switch asset files like en-us.js <=> sv-se.js using config, but how do you do the same thing for images?

You don't... not like that. This is something that's used by the SPFx runtime module loader... by the time your code runs, that's already happened so you can't hoot into it. Plus, that's for strings... you want to reference an image, which is going to be an additional request, not a string.
What I'd do is use the context.pageContext.cultureInfo.currentUICultureName to determine the current page's 2-character locale setting and use that to dynamically build the URL to your localized image.

@andrewconnell  Thank you for the answer!
Can I bother you with one more question... If I would still include some images in the package (.sppkg), how do I properly make URL for that image?

Let me google that for you :)
https://blog.mastykarz.nl/correctly-reference-images-sharepoint-framework-solutions/

@andrewconnell The link suggests i use require() and let webpack do it, like in the example above. This would requie the require for all languages, please read my comment above - I was hoping that there is a better way?

Same concept... just make the string for the image filename dynamic in the require statement.

But if i make string in the require a variable, webpack will not pack the image file in, it will just say "file no found"?

Ah... good point. Then just list them as separate require statements.  If you do have a lot, then this is a bad approach as you're back to my point above about inflating the bundle.
Another approach you could consider is modifying the webpack config & package to include images in the SPPKG so you aren't putting the images in the bundle, rather you're just putting them in the package. This way they are deployed alongside your bundle & other assets and you can just dynamically reference the CDN location of the file. If this works, it would be preferred... just requires some webpack config work... but you'd have to test this approach out. In theory, it would work... but not sure if it's possible.

Will try! Sounds interesting.

@andrewconnell Looks like I was mistaking. Webpack has a special feature to support this scenario, so variables actually are working. I mean, the following require will actually pack all "matching by wildcard" files into bundle for example! Webpack is really awesome 😄
require('raw-loader!webparts/loc/email-template.' + context.pageContext.cultureInfo.currentUICultureName + '.txt');

Require with expression:
https://webpack.js.org/guides/dependency-management/#require-with-expression

Whoa... wasn't aware of that. Nice find!