TEOC install complete but can't sign in

After creating the teams app I click on the Login button Under the Welcome heading. A box popped up to grant permission on behalf of the organization. Which I did, now when I click login, a box appears for second then it disappears I am unable to sign in. What am I missing?

@rvwilk, Thank you for reporting this.
Can you please share console logs and network trace which will help us troubleshoot the issue.
Also request you to share the manifest files with us.

Here are the manifest logs:
{
"id": "fbf4be06-3262-41c8-8383-3cfe59ce6665",
"acceptMappedClaims": null,
"accessTokenAcceptedVersion": null,
"addIns": [],
"allowPublicClient": null,
"appId": "08627c1d-e92e-4ab7-a41f-12c7dd5d0ff5",
"appRoles": [],
"oauth2AllowUrlPathMatching": false,
"createdDateTime": "2024-02-15T22:16:32Z",
"description": null,
"certification": null,
"disabledByMicrosoftStatus": null,
"groupMembershipClaims": null,
"identifierUris": [
"api://brighameoc.azurewebsites.net/08627c1d-e92e-4ab7-a41f-12c7dd5d0ff5"
],
"informationalUrls": {
"termsOfService": null,
"support": null,
"privacy": null,
"marketing": null
},
"keyCredentials": [],
"knownClientApplications": [],
"logoUrl": null,
"logoutUrl": null,
"name": "teoc",
"notes": null,
"oauth2AllowIdTokenImplicitFlow": false,
"oauth2AllowImplicitFlow": false,
"oauth2Permissions": [
{
"adminConsentDescription": "Allows Teams to call the app’s web APIs as the current user",
"adminConsentDisplayName": "Teams can access app's web API",
"id": "4c099a9b-6f5b-4b12-ab1e-b9d7e98110bc",
"isEnabled": true,
"lang": null,
"origin": "Application",
"type": "User",
"userConsentDescription": null,
"userConsentDisplayName": null,
"value": "access_as_user"
}
],
"oauth2RequirePostResponse": false,
"optionalClaims": {
"idToken": [],
"accessToken": [
{
"name": "idtyp",
"source": null,
"essential": false,
"additionalProperties": []
}
],
"saml2Token": []
},
"orgRestrictions": [],
"parentalControlSettings": {
"countriesBlockedForMinors": [],
"legalAgeGroupRule": "Allow"
},
"passwordCredentials": [
{
"customKeyIdentifier": null,
"endDate": "2026-02-15T07:00:00Z",
"keyId": "83b85eb1-47ce-45c9-a01c-0aac566bc03e",
"startDate": "2024-02-15T22:18:42.812Z",
"value": null,
"createdOn": "2024-02-15T22:19:59.4860749Z",
"hint": "ZE~",
"displayName": "teoc secret"
}
],
"preAuthorizedApplications": [
{
"appId": "4345a7b9-9a63-4910-a426-35363201d503",
"permissionIds": [
"4c099a9b-6f5b-4b12-ab1e-b9d7e98110bc"
]
},
{
"appId": "00000002-0000-0ff1-ce00-000000000000",
"permissionIds": [
"4c099a9b-6f5b-4b12-ab1e-b9d7e98110bc"
]
},
{
"appId": "d3590ed6-52b3-4102-aeff-aad2292ab01c",
"permissionIds": [
"4c099a9b-6f5b-4b12-ab1e-b9d7e98110bc"
]
},
{
"appId": "4765445b-32c6-49b0-83e6-1d93765276ca",
"permissionIds": [
"4c099a9b-6f5b-4b12-ab1e-b9d7e98110bc"
]
},
{
"appId": "1fec8e78-bce4-4aaf-ab1b-5451cc387264",
"permissionIds": [
"4c099a9b-6f5b-4b12-ab1e-b9d7e98110bc"
]
},
{
"appId": "5e3ce6c0-2b1f-4285-8d4b-75ee78787346",
"permissionIds": [
"4c099a9b-6f5b-4b12-ab1e-b9d7e98110bc"
]
}
],
"publisherDomain": "bcutah.onmicrosoft.com",
"replyUrlsWithType": [
{
"url": "https://brighameoc.azurewebsites.net.azurewebsites.net/blank-auth-end.html",
"type": "Spa"
},
{
"url": "https://brighameoc.azurewebsites.net/auth-end.html",
"type": "Web"
},
{
"url": "https://brighameoc.azurewebsites.net/auth-end.html?clientId=08627c1d-e92e-4ab7-a41f-12c7dd5d0ff5",
"type": "Spa"
}
],
"requiredResourceAccess": [
{
"resourceAppId": "00000003-0000-0000-c000-000000000000",
"resourceAccess": [
{
"id": "0e263e50-5827-48a4-b97c-d940288653c7",
"type": "Scope"
},
{
"id": "5f8c59db-677d-491f-a6b8-5f174b11ec1d",
"type": "Scope"
},
{
"id": "4e46008b-f24c-477d-8fff-7bb4ec7aafe0",
"type": "Scope"
},
{
"id": "e383f46e-2787-4529-855e-0e479a3ffac0",
"type": "Scope"
},
{
"id": "a65f2972-a4f8-4f5e-afd7-69ccb046d5dc",
"type": "Scope"
},
{
"id": "ba47897c-39ec-4d83-8086-ee8256fa737d",
"type": "Scope"
},
{
"id": "65e50fdc-43b7-4915-933e-e8138f11f40a",
"type": "Scope"
},
{
"id": "f45671fb-e0fe-4b4b-be20-3d3ce43f1bcb",
"type": "Scope"
},
{
"id": "2219042f-cab5-40cc-b0d2-16b1540b4c5f",
"type": "Scope"
},
{
"id": "4a06efd2-f825-4e34-813e-82a57b03d1ee",
"type": "Scope"
},
{
"id": "0f4595f7-64b1-4e13-81bc-11a249df07a9",
"type": "Scope"
},
{
"id": "a9ff19c2-f369-4a95-9a25-ba9d460efc8e",
"type": "Scope"
},
{
"id": "e1fe6dd8-ba31-4d61-89e7-88639da4683d",
"type": "Scope"
},
{
"id": "b340eb25-3456-403f-be2f-af7a0d370277",
"type": "Scope"
}
]
}
],
"samlMetadataUrl": null,
"signInUrl": null,
"signInAudience": "AzureADMyOrg",
"tags": [],
"tokenEncryptionKeyId": null

Can you give instructions for gathering console logs and network trace?

I may have resolved the issue. It appears I skipped this step:
In the editor that appears, find accessTokenAcceptedVersion and update the value from null to 2

@rvwilk, Can you please confirm if the issue is resolved after updating the value in manifest?
If its resolved can we closed this ticket?


Added 'grid' direction

Re-rolling changes from this PR

There seems to be an issue with the test suite or test runner. When run locally, sometimes the tests pass and sometimes not due to missing the document.body.

This might be an issue with asynchronously loading the browser env before running the test.
In any case I don't think it's related to the changes introduced by this PR.

@bevacqua care to review if this could be merged despite the irrelevant test errors?


Filtering on Enum fails in LoadAsync using Queryable

Is there a fix or workaround for doing filtering on Enum with a Queryable?
For example
LoadResult result = await DataSourceLoader.LoadAsync(queryableSource, loadOptions);
Where queryableSource is a class that one of the properties is an Enum and we are trying to filter on that Enum property/column. The code will result in an exception because of how DevExtreme is doing the translation it seems?
System.InvalidOperationException: The LINQ expression 'DbSet<Script>
    .Where(s => s.EnumType.ToString().Contains("test"))' could not be translated. Either rewrite the query in a form that can be translated, or switch to client evaluation explicitly by inserting a call to either AsEnumerable(), AsAsyncEnumerable(), ToList(), or ToListAsync(). See https://go.microsoft.com/fwlink/?linkid=2101038 for more information.

Right now we use StringEnumConverter so when our asp.net core web api returns an Enum it returns a string to DevExtreme grid. This means that when the dxgrid filters the column it sends back loadOptions with the string and it seems LoadAsync does not know to convert the string back to the corresponding integer value of the enum to filter on.
We tried to work around this by instead storing our enum as string in SQL (instead of int). But it seems we get the same error as LoadAsync tries to still do the ToString().Contains for Enum instead of string compare that works with SQL/queryable.
It is not clear how do we setup an asp.net core web api to return enum and be filterable properly with DevExtreme using queryable instead of list?

Hello
This is an issue with EF Core 3. You can track it at https://github.com/dotnet/efcore/issues/20604.
If you need to support string operations, such as Contains, I suggest that you use the String type instead of an enum in your API.


Remotely clear all notifications

Added handling for a "clearAllNotifications": "true" key-value pair on iOS and Android which clears the notifications.
Description

Simply added code which gets the value from the payload, and if it's "true", it executes code which removes notifications from the notification area.
Related Issue

#2371
Motivation and Context

It's a straight-forward way to clear time-sensitive notifications an app may have. Simply send the payload, and it's done.
How Has This Been Tested?

Android 6.0.1 and iOS 11.3.1
Notifications sent via Postman
Sent notifications to both platforms, both in background and force-closed. Then, sent the payload which clears the notififications.
Android
Background: Notifications all disappear.
Force-closed: Notifications all disappear.
iOS
Background: Notifications all disappear
Force-closed: Nothing happens. Doesn't seem to be able to run the code. Would love some help with this if you want.
iOS note : Why does the iOS code first increment the iconApplicationBadgeNumber and then clear it before removing the notifications?
Simply put, it just didn't work otherwise. If you know better, let me know.
Notification used to clear the pre-existing notifications:
{
    "priority" : "high",
    "content_available" : true,
    "data" : {
      "notId": 0,
      "clearAllNotifications" : "true"
    },
    "to" : "id"
}

In the case that you send a notification with a body and a title, and it also contains this payload (see what I mean below), first, the old notifications will be cleared, and then the new notification will be added. This will result in one remaining notification in the notification drawer.
Android:
{
    "priority" : "high",
    "content_available" : true,
    "data" : {
      "title": "some title or another",
      "body": "some body or another",
      "notId": 0,
      "clearAllNotifications" : "true"
    },
    "to" : "id"
}

iOS:
{
    "priority" : "high",
    "content_available" : true,
    "notification": {
         "title": "some title or another",
         "body": "some body or another",
    },
    "data" : {
      "notId": 0,
      "clearAllNotifications" : "true"
    },
    "to" : "id"
}

Screenshots (if appropriate):
N/A
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

One point of possible confusion I see is the fact that the handling of the new attribute doesn't define an independent top level behavior, but instead define a new "minor feature", parallel to the usual notification handling. In other terms, you mentioned this in the issue, but we need to make sure this is explicit and clean in the docs, at the very least:

In the case that you send a notification with a body and a title, and it also contains this payload (see what I mean below), first, the old notifications will be cleared, and then the new notification will be added. This will result in one remaining notification in the notification drawer.

Instead of calling this "a notification payload do clear the drawer", we should call it "a normal notification, that can also explicitly ask to clear the drawer before being handled".
I hope I made myself clear, words are hard.

I understand what you mean. I'll try and whip up something inteligible for the documentation when I have a bit of time.

Superseded by #2521


vm: console and exec fixes

Signed-off-by: Christian Brauner<EMAIL_ADDRESS>

Testsuite passed

jenkins: test this please

@brauner the jenkins tests passed, but travis failed to build, not sure if just a glitch or not, but not sure how to re-run travis.


Fix math mode rendering in browser

Hi, I've noticed that equations written in math mode are not always rendered correctly in a browser. Fixing this would make the learning experience better for people that use separate devices for reading and solving katas.
Example of the problem
Equations written in consecutive lines are rendered as one-line equation.
In the SingleQubitGate kata under the "Matrix Representation" section the equations for $X|0\rangle$ and $X|1\rangle$ are displayed on one line instead of two.
The problem is also visible in Complex Arithmetic kata under the "Imaginary numbers" section. There three equations are displayed on one line.
I can fix this by dividing the equations into multiple math sections instead of using \\ to generate a new line. For example $$eq1 \\ eq2$$ would be transformed into $$eq1$$ $$eq2$$. Here you can view example of my fix.
Technical details
I've verified that this rendering problem exists on Edge, Firefox and Chrome.
Changing the colour of an equation is also broken in the browser (See: SingleQubitGates -> Ket-bra decomposition).

If you don't have any objections to this fix, I can search and fix the rendering problems also in other notebooks. If I do that it would be nice to know which katas are equation-heavy, so if you know please share.

This can be a good thing to fix indeed. We've always assumed that the main use case for the katas is interactive, since the project started with the katas, and added tutorials and workbooks that had valuable reading material only much later! So we never spent time on renderings in GitHub preview mode.
Some things might just not be supported - I'm not sure GitHub previewer handles color at all? And there might be more broken things, for example, Ket-bra decomposition from your example shows up as several notes broken up by > signs rather than a single unbroken note.
If you have time to track down this kind of issues and figure out how to fix them without breaking the rendering in interactive mode, that will be great!
As for which ones have the most formulas... I think the tutorials and the workbooks for the katas/tutorials that have them are going to have most multi-line formulas, the katas themselves are less likely to have them, since they only have task descriptions that are typically less formula heavy.

GitHub previewer can handle color, but it seems to color everything that comes after the \color command until the end of the line. This can be fixed by adding more curly brackets to make the scope of \color more explicit.
The note broken up by > signs was my mistake. I'm not used to using/seeing notes in notebooks, and I didn't notice that my fix broke the note. It's all fixed now, thanks for catching that!
The directions to formula heavy notebooks will be helpful. Thanks!

I've fixed the rendering problems in almost all katas and workbooks from Quantum Computing Concepts: Qubits and Gates section of the Learning Path. In this section only the Superposition workbook still has rendering errors.
Unfortunately, I don't have enough time to track down all of the rendering errors, so help would be appreciated. @tcNickolas do you think that this is a "good first issue"?

Yes, the issue is easy to identify, and you did a great job with the first batch of fixes to show how they can be applied (though it takes considerable patience!), so it will make a "good first issue". I can label it as such, and I can add a checklist of tutorials and workbooks that still have to be addressed, like I did for https://github.com/microsoft/QuantumKatas/issues/542, so that the contributors don't have to sign up to do everything at once, but rather work on subsets of notebooks.
Thank you for starting this effort!

Thanks! A tip for other contributors: almost all problems can be solved by the two techniques I mentioned previously. That is:

colour problems can be solved by adding additional curly braces \color{red} <symbol>  -> { \color{red} <symbol> }
multiline equation displayed on one line can be fixed by dividing the math mode into two $$eq1 \\ eq2$$  -> $$ eq1 $$    $$ eq2 $$


Suddenly task list does not refresh properly

Testing on top of current odalic-ui and sti commit 51bac510046b17895d58afefa6135d451000cfe1.
Just create new task. It is not depicted in the task list. You have to refresh the browser to see it!

Please try to solve asap, otherwise I would have to search (for the demo)  the version when it was working, cherry pick e.g. selection of the subset of the KBs etc. Thanks!

@istvan-satmari Could you look at it plases ASAP?
@tomas-knap Sorry about that, not sure how could I miss that...

Still working for 4915f3db9be580ac6a13b2a2a2f1e3b345e840e7

@tomas-knap @istvan-satmari Weird thing is, that it happened to me only once, when adding the first task. Now, when I restarted the server and refresh the client app, it works even in that case...

Seems to be working now, but the bug was difficult to reproduce, so no guarantees.

Still not working properly - I was testing current develop branch, cleared cache and after task was created, I had to refresh two or three times task list before it was shown up. But as I mentioned, it never happened to me before - I think it is still working with commit  4915f3db9be580ac6a13b2a2a2f1e3b345e840e7

I think it is even worth then before the fix ;-) - I opened task, closed detail and had to again refresh two times.

Yeah, I suppose it's because of the pagination component. The problem is, it should work (from a logical perspective). And if the issue is "sometimes it's working, sometimes not", it should be race-condition-related, which does not appear to be the cause, unfortunately. (Possibly related to inner implementation of Angular's digest cycle; my guess.)
Anyway, this will take a long time to debug (mainly because the issue is very hard to reproduce), so don't expect a fix so soon.

It is enough to fix that in iter 5, do not need the fix urgently for the demo ;-)

But we have to fix that, that is something the reviewer can easily see.

So, I hope it is solved now.
The problem seems to be quite complex; to my understanding the angular's digest cycle sometimes ends "pematurely" and watcher on the pagination component simply does not get called. And there is not much I can do since calling another digest cycle results in an error (because there is already one in progress).
It seems that firing the event manually (via angular broadcast) does help - this basically forces the pagination component to update anyway. But, again, no guarantees.


[#396] Go through secure instance doc + little fixes

Closes #396

@sharpattack This was a good rabbit hole to go down, because it made me see an issue on stage and it could have explained it. It helped me understand the setup better too. Even if the script didn't end up mattering, it is all good.


build: arm64 builders don't support SHA-512 extensions

The arm64 builders don't support the SHA-512 Armv8 extensions, so our crypto/sha512 assembly is untested, in violation of the Assembly Policy.
/cc @golang/security @golang/release

Related Issues and Documentation

build: amd64 builders don't support SHA extensions #69592

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

The new GCP C4A instances appear to support the SHA-512 instructions.


Add Tkinter example GUI

I created a simple GUI that users can run to interact with ChatterBot.

This looks great :+1:


Remove silent overwriting of shutil.copy in ARMI utils

safeCopy silently overwrites shutil.copy in ARMI:
https://github.com/terrapower/armi/blob/08f8c1da0a9197ff1a311070343cac9a19f14709/armi/utils/__init__.py#L807-L825
I'm making this ticket so that when shutil.copy is replaced in all downstream plugins with safeCopy, I want to remove this menace from the code base.
I also need to check in with other ARMI users so they have a heads up on a potentially breaking change (so, if shutil is being leveraged, they can do nothing and revert to the real shutil.copy, or they can also swap to explicitly using safeCopy)

I agree, silently over-writing a standard library tool whenever you import armi is a bad solution to whatever problem this was trying to solve.
I would say "let's do it right now!", but since it's an API-breaking change, we will be slow and deliberate.
@drewj-usnctech Just FYI.

this seems super low priority. I agree it is confusing and surprising but its going to be a lot of work to change and very little benifit.

Thanks for reopening @onufer
I grepped around and it won't be a huge lift. I agree it's low priority, but I'd like to get in the habit of paying back some tech debt and this is an easy one.

this seems super low priority.

I can see that from a "fixing this doesn't help us model a reactor" stand point. I really can.

Thus my concern.
Also, I could fix this problem in like... 2 minutes in each downstream repo that is affected. So, it's just the easiest thing in the world to fix.

Agreed. It actually can be done piecemeal, and doesn't need massive coordination.

replace shutil.copy with safeCopy in ARMI
repeat one by one for each plugin
last, remove the shutil.copy overwrite in ARMI.


Index in Embedded Documents

create class Account
create property Account.id string
create index Account.id unique

create class User extends V
create property User.accounts EMBEDDEDLIST Account

This works:
insert into User set accounts = [{"id":"1"}]
insert into User set accounts = [{"id":"1"}]

This doesn't:
insert into Account set id = "1"
insert into Account set id = "1"

Why indexes are not supported in the first?

This is not a bug.
The index on Account is separate from User and does not effect the embedded accounts within User.
You could add the following index to Users for what you want.
create index User.index1 on User(acounts.id) unique string

Thanks. I see what you're saying.
But I was not able to follow your suggestion. I believe my problem is the same as this #2945.

Try
create index User.index1 on User(acounts.id) unique string

and then
insert into User set accounts = [{"id":"1"}]
insert into User set accounts = [{"id":"1"}]

and you'll see that the second insert is indeed not allowed. I tried it on 2.1rc2

I removed string from:
create index User.index1 on User(acounts.id) unique string

I didn't know this was possible.
Thanks @Ziink :)

This isn't working for me anymore. Have no idea why it worked earlier and now it doesn't.

In 2.1.4: this prevents double inserts as soon as I use an unique_hash_index, but it breaks on updates. See #2945


spy does not retain the function result object if it is a promise

I have the following vitest test:
vi.mock(f).mockImplementation(() => {
   const res = new Promise()
   res.cancel = () => ....
   return res
})

When f is then called inside the production code, f.cancel is no longer there because - as far as I can see in the source code - tinyspy replaces the promise returned from mockImplementation with its result.
Edit: This is working in Jest, btw. (I am in the process of migration our Jest test code base to vitest)
Edit 2: If I remove the special handling of promises, all our tests run just fine. I did not dig deep enough into the code to fully understand why that code is there in the first place, so please forgive me for making dumb suggestions.

You are correct in your assumptions. This is an oversight, you can open a PR to fix this, if you have time. Otherwise I will fix it tomorrow

Fixed in v0.3.3


No Response with multiple esp8266 connected

I am using the temperature sensor code and have successfully added it to my Homekit Setup. Have tested for two weeks, and It works very well. If I add any other esp8266 to HomeKit using the temperature sensor code it appears that only one sensor will communicate with the others “Not Responding” if I wait a few minutes and go back and refresh, another sensor will respond, with the others “Not Responding” Any ideas what’s happening? I’ve tried changing the serial numbers and pair codes with no luck.

Here is a snippet from my log...I have done a complete new install and the esp8266 stalls at this state not able to connect to MyHome.app. As I mentioned before, this worked perfectly a week or so ago.

HomeKit: Generated new accessory ID: 3D:39:9C:71:69:E9
HomeKit: Generated new accessory key
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
HomeKit: Configuring mDNS
mDNS announcement: Name=Temperature Sensor md=MyTemperatureSensorpv=1.0id=3D:39:9C:71:69:E9c#=1s#=1ff=0sf=1ci=9 Port=5556 TTL=4500
homekit_run_server: Staring HTTP server
scandone
add 0
aid 7
cnt

connected with Unifi, channel 1
dhcp client start...
beacon timeout
rm match
scandone
add 0
aid 4
cnt
connected with Unifi, channel 11
dhcp client start...
ip:<IP_ADDRESS>,mask:<IP_ADDRESS>,gw:<IP_ADDRESS>

see for this pull request for my solution
[maximkulkin/esp-homekit] Bonjour improvements (#60)

On 24 Aug 2018, at 20:50, bryantcoles<EMAIL_ADDRESS>wrote:
Here is a snippet from my log...I have done a complete new install and the esp8266 stalls at this state not able to connect to MyHome.app. As I mentioned before, this worked perfectly a week or so ago.
HomeKit: Generated new accessory ID: 3D:39:9C:71:69:E9
HomeKit: Generated new accessory key
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
HomeKit: Configuring mDNS
mDNS announcement: Name=Temperature Sensor md=MyTemperatureSensorpv=1.0id=3D:39:9C:71:69:E9c#=1s#=1ff=0sf=1ci=9 Port=5556 TTL=4500
homekit_run_server: Staring HTTP server
scandone
add 0
aid 7
cnt
connected with Unifi, channel 1
dhcp client start...
beacon timeout
rm match
scandone
add 0
aid 4
cnt
connected with Unifi, channel 11
dhcp client start...
ip:<IP_ADDRESS>,mask:<IP_ADDRESS>,gw:<IP_ADDRESS>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/maximkulkin/esp-homekit-demo/issues/126#issuecomment-415849576, or mute the thread https://github.com/notifications/unsubscribe-auth/AV0HQthATCWd8IlZAyc5OcoOF4cn6BHdks5uUErlgaJpZM4WIRft.

implementing the fix in issue 60 per suggestion above does not resolve the issue.
esptool.py v1.2
Connecting...
Running Cesanta flasher stub...
Flash params set to 0x0320
Writing 4096 @ 0x0... 4096 (100 %)
Wrote 4096 bytes at 0x0 in 0.4 seconds (89.8 kbit/s)...
Writing 4096 @ 0x1000... 4096 (100 %)
Wrote 4096 bytes at 0x1000 in 0.4 seconds (89.8 kbit/s)...
Writing 434176 @ 0x2000... 434176 (100 %)
Wrote 434176 bytes at 0x2000 in 37.8 seconds (92.0 kbit/s)...
Leaving...
/Volumes/case-sensitive/esp-open-rtos///utils/filteroutput.py --port /dev/cu.SLAB_USBtoUART --baud 115200 --elf ./build/temperature_sensor.out
Opening /dev/cu.SLAB_USBtoUART at 115200bps...
mode : sta(60:01:94:75:51:1f)
add if0

HomeKit: Starting server
HomeKit: Formatting flash at 0x7a000
HomeKit: Generated new accessory ID: 78:51:F6:6D:F1:35
scandone
HomeKit: Generated new accessory key
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
add 0
aid 7
cnt
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
HomeKit: Configuring mDNS
mDNS announcement: Name=Temperature Sensor md=MyTemperatureSensorpv=1.0id=78:51:F6:6D:F1:35c#=1s#=1ff=0sf=1ci=9 Port=5556 TTL=4500
homekit_run_server: Staring HTTP server

connected with Unifi, channel 1
dhcp client start...
beacon timeout
rm match
scandone
add 0
aid 7
cnt
connected with Unifi, channel 11
dhcp client start...
ip:<IP_ADDRESS>,mask:<IP_ADDRESS>,gw:<IP_ADDRESS>

you must not have applied it properly since the name did not get the 4 digits of the ID appended

On 26 Aug 2018, at 21:41, bryantcoles<EMAIL_ADDRESS>wrote:
implementing the fix in issue 60 per suggestion above does not resolve the issue.
esptool.py v1.2
Connecting...
Running Cesanta flasher stub...
Flash params set to 0x0320
Writing 4096 @ 0x0... 4096 (100 %)
Wrote 4096 bytes at 0x0 in 0.4 seconds (89.8 kbit/s)...
Writing 4096 @ 0x1000... 4096 (100 %)
Wrote 4096 bytes at 0x1000 in 0.4 seconds (89.8 kbit/s)...
Writing 434176 @ 0x2000... 434176 (100 %)
Wrote 434176 bytes at 0x2000 in 37.8 seconds (92.0 kbit/s)...
Leaving...
/Volumes/case-sensitive/esp-open-rtos///utils/filteroutput.py --port /dev/cu.SLAB_USBtoUART --baud 115200 --elf ./build/temperature_sensor.out
Opening /dev/cu.SLAB_USBtoUART at 115200bps...
mode : sta(60:01:94:75:51:1f)
add if0
HomeKit: Starting server
HomeKit: Formatting flash at 0x7a000
HomeKit: Generated new accessory ID: 78:51:F6:6D:F1:35
scandone
HomeKit: Generated new accessory key
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
add 0
aid 7
cnt
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
HomeKit: Configuring mDNS
mDNS announcement: Name=Temperature Sensor md=MyTemperatureSensorpv=1.0id=78:51:F6:6D:F1:35c#=1s#=1ff=0sf=1ci=9 Port=5556 TTL=4500
homekit_run_server: Staring HTTP server
connected with Unifi, channel 1
dhcp client start...
beacon timeout
rm match
scandone
add 0
aid 7
cnt
connected with Unifi, channel 11
dhcp client start...
ip:<IP_ADDRESS>,mask:<IP_ADDRESS>,gw:<IP_ADDRESS>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/maximkulkin/esp-homekit-demo/issues/126#issuecomment-416064786, or mute the thread https://github.com/notifications/unsubscribe-auth/AV0HQifG_Dy8ByBtznQfPvVLgPM2i8ECks5uUvn4gaJpZM4WIRft.

I really appreciate all the help here. I still have unresponsive accessories after I add them to MyHome. I have followed all suggested solutions with no luck. Here is my make file and logs. Any other ideas?
Makefile
PROGRAM = temperature_sensor
EXTRA_COMPONENTS =
    extras/dht
    extras/http-parser
    $(abspath ../../components/wolfssl)
    $(abspath ../../components/cJSON)
    $(abspath ../../components/homekit)
DHT11 sensor pin
SENSOR_PIN ?= 4
FLASH_SIZE ?= 4
EXTRA_CFLAGS += -I../.. -DHOMEKIT_SHORT_APPLE_UUIDS -DSENSOR_PIN=$(SENSOR_PIN)
include $(SDK_PATH)/common.mk
ESPTOOL_ARGS=-fs $(FLASH_SIZE)MB -fm $(FLASH_MODE) -ff $(FLASH_SPEED)m
monitor:
    $(FILTEROUTPUT) --port $(ESPPORT) --baud 115200 --elf $(PROGRAM_OUT)
LOGS
LD build/temperature_sensor.out
FW firmware/temperature_sensor.bin
esptool.py v2.5.1-dev
Creating image for ESP8266...
esptool.py -p /dev/cu.SLAB_USBtoUART --baud 115200 erase_flash
esptool.py v2.5.1-dev
Serial port /dev/cu.SLAB_USBtoUART
Connecting........_
Detecting chip type... ESP8266
Chip is ESP8266EX
Features: WiFi
MAC: 60:01:94:75:51:1f
Uploading stub...
Running stub...
Stub running...
Erasing flash (this may take a while)...
Chip erase completed successfully in 2.0s
Hard resetting via RTS pin...
esptool.py -p /dev/cu.SLAB_USBtoUART --baud 115200 write_flash -fs 4MB -fm dout -ff 40m
0x0 /Volumes/case-sensitive/esp-open-rtos//bootloader/firmware_prebuilt/rboot.bin 0x1000 /Volumes/case-sensitive/esp-open-rtos//bootloader/firmware_prebuilt/blank_config.bin 0x2000 ./firmware/temperature_sensor.bin
esptool.py v2.5.1-dev
Serial port /dev/cu.SLAB_USBtoUART
Connecting........_
Detecting chip type... ESP8266
Chip is ESP8266EX
Features: WiFi
MAC: 60:01:94:75:51:1f
Uploading stub...
Running stub...
Stub running...
Configuring flash size...
Flash params set to 0x0340
Compressed 3104 bytes to 2169...
Wrote 3104 bytes (2169 compressed) at 0x00000000 in 0.2 seconds (effective 126.2 kbit/s)...
Hash of data verified.
Compressed 2048 bytes to 23...
Wrote 2048 bytes (23 compressed) at 0x00001000 in 0.0 seconds (effective 2361.5 kbit/s)...
Hash of data verified.
Compressed 433060 bytes to 309849...
Wrote 433060 bytes (309849 compressed) at 0x00002000 in 27.4 seconds (effective 126.5 kbit/s)...
Hash of data verified.
Leaving...
Hard resetting via RTS pin...
/Volumes/case-sensitive/esp-open-rtos///utils/filteroutput.py --port /dev/cu.SLAB_USBtoUART --baud 115200 --elf ./build/temperature_sensor.out
Opening /dev/cu.SLAB_USBtoUART at 115200bps...
mode : sta(60:01:94:75:51:1f)
add if0

HomeKit: Starting server
HomeKit: Formatting flash at 0x100000
HomeKit: Generated new accessory ID: DF:BB:DA:05:1B:B8
HomeKit: Generated new accessory key
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
HomeKit: Configuring mDNS
mDNS announcement: Name=Temperature Sensor md=MyTemperatureSensorpv=1.0id=DF:BB:DA:05:1B:B8c#=1s#=1ff=0sf=1ci=9 Port=5556 TTL=4500
homekit_run_server: Staring HTTP server
scandone
add 0
aid 7
cnt

connected with Unifi, channel 11
dhcp client start...
ip:<IP_ADDRESS>,mask:<IP_ADDRESS>,gw:<IP_ADDRESS>

the fact that MDNS still uses "Name=Temperature Sensor“ instead of "Name=Temperature Sensor-DFBB” shows the fix is not yet applied
Please check out if you code is really updated…
Good luck, HacK

On 27 Aug 2018, at 14:45, bryantcoles<EMAIL_ADDRESS>wrote:
I really appreciate all the help here. I still have unresponsive accessories after I add them to MyHome. I have followed all suggested solutions with no luck. Here is my make file and logs. Any other ideas?
Makefile
PROGRAM = temperature_sensor
EXTRA_COMPONENTS =
extras/dht
extras/http-parser
$(abspath ../../components/wolfssl)
$(abspath ../../components/cJSON)
$(abspath ../../components/homekit)
DHT11 sensor pin
SENSOR_PIN ?= 4
FLASH_SIZE ?= 4
EXTRA_CFLAGS += -I../.. -DHOMEKIT_SHORT_APPLE_UUIDS -DSENSOR_PIN=$(SENSOR_PIN)
include $(SDK_PATH)/common.mk
ESPTOOL_ARGS=-fs $(FLASH_SIZE)MB -fm $(FLASH_MODE) -ff $(FLASH_SPEED)m
monitor:
$(FILTEROUTPUT) --port $(ESPPORT) --baud 115200 --elf $(PROGRAM_OUT)
LOGS
LD build/temperature_sensor.out
FW firmware/temperature_sensor.bin
esptool.py v2.5.1-dev
Creating image for ESP8266...
esptool.py -p /dev/cu.SLAB_USBtoUART --baud 115200 erase_flash
esptool.py v2.5.1-dev
Serial port /dev/cu.SLAB_USBtoUART
Connecting........_
Detecting chip type... ESP8266
Chip is ESP8266EX
Features: WiFi
MAC: 60:01:94:75:51:1f
Uploading stub...
Running stub...
Stub running...
Erasing flash (this may take a while)...
Chip erase completed successfully in 2.0s
Hard resetting via RTS pin...
esptool.py -p /dev/cu.SLAB_USBtoUART --baud 115200 write_flash -fs 4MB -fm dout -ff 40m
0x0 /Volumes/case-sensitive/esp-open-rtos//bootloader/firmware_prebuilt/rboot.bin 0x1000 /Volumes/case-sensitive/esp-open-rtos//bootloader/firmware_prebuilt/blank_config.bin 0x2000 ./firmware/temperature_sensor.bin
esptool.py v2.5.1-dev
Serial port /dev/cu.SLAB_USBtoUART
Connecting........_
Detecting chip type... ESP8266
Chip is ESP8266EX
Features: WiFi
MAC: 60:01:94:75:51:1f
Uploading stub...
Running stub...
Stub running...
Configuring flash size...
Flash params set to 0x0340
Compressed 3104 bytes to 2169...
Wrote 3104 bytes (2169 compressed) at 0x00000000 in 0.2 seconds (effective 126.2 kbit/s)...
Hash of data verified.
Compressed 2048 bytes to 23...
Wrote 2048 bytes (23 compressed) at 0x00001000 in 0.0 seconds (effective 2361.5 kbit/s)...
Hash of data verified.
Compressed 433060 bytes to 309849...
Wrote 433060 bytes (309849 compressed) at 0x00002000 in 27.4 seconds (effective 126.5 kbit/s)...
Hash of data verified.
Leaving...
Hard resetting via RTS pin...
/Volumes/case-sensitive/esp-open-rtos///utils/filteroutput.py --port /dev/cu.SLAB_USBtoUART --baud 115200 --elf ./build/temperature_sensor.out
Opening /dev/cu.SLAB_USBtoUART at 115200bps...
mode : sta(60:01:94:75:51:1f)
add if0
HomeKit: Starting server
HomeKit: Formatting flash at 0x100000
HomeKit: Generated new accessory ID: DF:BB:DA:05:1B:B8
HomeKit: Generated new accessory key
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
Function called without core lock
HomeKit: Configuring mDNS
mDNS announcement: Name=Temperature Sensor md=MyTemperatureSensorpv=1.0id=DF:BB:DA:05:1B:B8c#=1s#=1ff=0sf=1ci=9 Port=5556 TTL=4500
homekit_run_server: Staring HTTP server
scandone
add 0
aid 7
cnt
connected with Unifi, channel 11
dhcp client start...
ip:<IP_ADDRESS>,mask:<IP_ADDRESS>,gw:<IP_ADDRESS>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/maximkulkin/esp-homekit-demo/issues/126#issuecomment-416214566, or mute the thread https://github.com/notifications/unsubscribe-auth/AV0HQlf65qpEj3AWBw2P73VgHsGVbJjAks5uU-nwgaJpZM4WIRft.

Hey @HomeACcessoryKid  I'm having the same issue. I'm using a Wemos D1 mini device which has 4MB flash.
In my case the fix would be something like that ?
FLASH_SIZE ?= 4
# firmware tool arguments
ESPTOOL_ARGS=-fs $(FLASH_SIZE)MB -fm $(FLASH_MODE) -ff $(FLASH_SPEED)m

I also encountered the same issue with a D1 mini

@cottsak As far as I understand, original issue was because multiple accessories had same name and thus mDNS collisions. You should use unique names for all accessories. One way to do that is to append mac address at the end of accessory name. Most examples already do that.
So, what's your issue now?

@maximkulkin
If you have some time, please check the implementation of a watchdog timer in mdnsresponder.c here :
https://github.com/RavenSystem/esp-homekit-devices/commit/f5f642fc0390047ed0600a00ac91df215eaf8c50
It may help to quickly re-announce accessories in case of any issue. What do you think?

@peros550 I've added a recurring (every 2 seconds) check for IP address and reannouncement.


Remove timestamp on metrics

Based on
https://prometheus.io/docs/instrumenting/writing_exporters/#scheduling
Adding timestamps to metrics is not recommended. Timestamps should be
set by prometheus when scrapting metrics.
This commit revert some changes made on #333

@rikonen Can you take a look at this pull requests ? It just remove the timestamp as recommended in the prometheus documentation.

@Vampouille It looks like this PR has been abandoned? Is this something you want to continue with?

@lionbee no I don't need this patch anymore.


Fix typo in broken authentication

Noticed a pretty confusing typo when reading the 2017 spec for Broken Authentication, assuming I haven't dramatically misunderstood its intention!
Also have PRs for the same issue in www-project-top-ten and Top10.

Hi
I ma not the project manager of this project.
You can contact the pm directly.
Cordialement/Regards/Mit freundlichen Grüßen/Cordiali saluti/Saludos/تحية
خالصة
Azzedine Ramrami
OWASP Morocco Chapter
OWASP AppSec Africa President
IBM Security - Senior Security & Network Architect
Data & Application Security, Cogntive Security, IoT/OT/ICS/SCADA Security &
SIEM
Certified Mile2 CPTE/CPTC/CDFE/CSWAE and EC-Council C|EH
OWASP Morocco Leader/OWASP AppSec Africa President
IBM Security Global Speaker
Consider giving back, and supporting the open source community by becoming
a member or making a donation today!
Join us at AppSec Morocco & Africa 2020 June 4 & 5 Rabat/Morocco!
Phone: +33 1 58 75 18 17 | Mobile: +33 6 65 48 90 04 / +33 6 10 25 93 15
E-mail<EMAIL_ADDRESS><EMAIL_ADDRESS>Le mar. 18 août 2020 à 08:41, Matt Lewis<EMAIL_ADDRESS>a
écrit :

Noticed a pretty confusing typo when reading the 2017 spec for Broken
Authentication, assuming I haven't dramatically misunderstood its intention!
Also have a PR in www-project-top-ten
https://github.com/OWASP/www-project-top-ten/pull/24 and Top10
https://github.com/OWASP/Top10/pull/507.
You can view, comment on, or merge this pull request online at:
https://github.com/OWASP/RiskAssessmentFramework/pull/60
Commit Summary

Fix typo in broken authentication

File Changes

M gui/src/app/view/resources/resources.component.ts
https://github.com/OWASP/RiskAssessmentFramework/pull/60/files#diff-f7e0fb0c9d6ff6e6ca539bafd4a836f1
(2)

Patch Links:

https://github.com/OWASP/RiskAssessmentFramework/pull/60.patch
https://github.com/OWASP/RiskAssessmentFramework/pull/60.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/OWASP/RiskAssessmentFramework/pull/60, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABXCECH6BQIN7CMCAMMUELSBIWCPANCNFSM4QC7M3KA
.

I believe this is not a typo, see https://github.com/OWASP/Top10/pull/507#issuecomment-676486700 for my reasoning.


Proposal: Inferred parameter types, and struct types

Types are inferred like so [in a variable declaration]:
x := 5;

However, this syntax isn't really possible for function parameters, or in structures (unless it has a default value). So perhaps we could support this with an _, for instance:
struct Cat {
    name: _ = "Terry",
}

fn some_func(a: _, b: _): int {

}

Why would you want inferred function arguments? Where are they inferred from?

This would require some deeper type inference like Rust or Haskell -- it gets quite mathematical and abstract.
Basically it infers the type of the argument based on the usage of them in the function body. It's definitely not trivial.

Sounds like it's not worth the effort.

Well, what you could do is have a struct that all other structs extend (Like the Object class in Java), this would introduce some polymorphism and it may emulate this kind of behaviour (type inference)?
func doFoo(a : Object, b : Object)

I'm all for polymorphism, but polymorphism and type inference are entirely different things. I don't think method parameter type inference should be implemented. It makes things too complicated for the programmer and compiler.

@MovingtoMars Yeah, it does seem like a lot of work for little gain, I have personally never needed this sort of behaviour in any program I've written.

It is cool, but looking in the function body and checking how it is used seems a little buggy to me. :-1:

Hmm, okay. Just an idea, and I kind of disagree with it now since I don't see any cases where I would need to use this. Thanks for the comments anyway, aye.

Well just to be clear, this isn't a bad thing per-se. Having it, along with maybe inferred return type, would allow writing a function without specifying any type information at all, while being able to sleep soundly knowing it's still statically typed.
I will agree though, it is a rather complex feature that will take a lot of work that probably has limited utility in an imperative language.
However, if done properly, @raoulvdberge it's not going to be buggy at all. It might just infer the wrong type (unlikely), or throw an error on ambiguity.


Use dart test for attributed_text

This package does not have a dependency on flutter_test and so there is no guarantee that the version of test_api from the pub solve is compatible with the flutter test command.
See https://github.com/flutter/flutter/issues/91107

@matthew-carroll ptal


[SPARK-33223][SS][FOLLOWUP] Clarify the meaning of "number of rows dropped by watermark" in SS UI page

What changes were proposed in this pull request?
This PR fixes the representation to clarify the meaning of "number of rows dropped by watermark" in SS UI page.
Why are the changes needed?
Aggregated Number Of State Rows Dropped By Watermark says that the dropped rows are from the state, whereas they're not. We say "evicted from the state" for the case, which is "normal" to emit outputs and reduce memory usage of the state.
The metric actually represents the number of "input" rows dropped by watermark, and the meaning of "input" is relative to the "stateful operator". That's a bit confusing as we normally think "input" as "input from source" whereas it's not.
Does this PR introduce any user-facing change?
Yes, UI element & tooltip change.
How was this patch tested?
Only text change in UI, so we know how thing will be changed intuitively.

Test build #131396 has started for PR 30439 at commit ec1fba1.

cc. @zsxwing @xuanyuanking @gaborgsomogyi as reviewers & author of #30151

Test build #131397 has started for PR 30439 at commit d700231.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36000/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36001/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36000/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36000/
Test PASSed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36001/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36001/
Test PASSed.

Test build #131396 has finished for PR 30439 at commit ec1fba1.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131396/
Test PASSed.

Test build #131397 has finished for PR 30439 at commit d700231.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131397/
Test FAILed.

retest this, please

Test build #131408 has started for PR 30439 at commit d700231.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36014/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36014/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36014/
Test PASSed.

Test build #131408 has finished for PR 30439 at commit d700231.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131408/
Test PASSed.

I'll leave this PR to you, @HeartSaVioR .

Thanks all for reviewing. Given this change is just a textural change and the metric was added by me, I don't feel I can get further review comments. Merging.


[11.x] Add next due to schedule:work output

Copy some code from schedule:list to extract next due information.

This can go to v10?

See above.


[BUG]: All icons need transforming

Description of the bug
using sveltekit's "npm build" - all the icons need transforming - even if not used.
node_modules/.pnpm/lucide-svelte<EMAIL_ADDRESS>Very slow of course, but also cause the builder to run out of memory :(
Steps To Reproduce
npm run build
Additional Information
No response

oh doh - seems that this is the wrong package! not "lucide-svelte" !

Using Svelte-Lucide, you can import individually. Please read this doc.


Adding decimal to binary converter

Prerequisites

[X] I am an Open Source Contributor
[X] I checked to make sure that this issue has not already been filed

Description
Would like to add a converter that coverts a decimal number into binary.
Screenshots
No response
Code of Conduct

[X] I follow Contributing Guidelines of this project.

Same issue already exist. Pls work on other issues @bhavya-anand19


TextureSystem: add a 'texsharp' attribute to let people globally scale texture sharpness

TextureSystem: add a 'texsharp' attribute to let people globally scale the filter size estimates.
Sometimes people wish our (I believe correctly-calculated) texture filters were just a bit sharper.  This global adjustment allows that, at the obvious expense of (1) possible slight aliasing, and (2) possible performance hit to the texture cache due to all texture lookups needing slightly higher-res MIPmap levels.

Recent fixes to bugs in the anisotropic footprint calculations have fixed a number of areas where it was too sharp, or too blurry.  Demand for a global sharpness tweak have died down, so I'm going to abandon and close this pull request.  It's easy to revive later if there is a renewed call for this feature.


Clear the list of _inlines after aadding last element in list

The markdown related bug has been fixed in #39
I have forget to push the last commit, which clear the array after adding the last element in children.
This part does not create issue in release, but will show warning in debug mode of app.
So, creating this pull request.

@manjotsidhu please check.
Sorry for the mistake.


Error in persisting the model of a new component

rasa NLU version : 0.9.1
Used backend / pipeline : custom pipeline
Operating system (windows, osx, ...): linux (on docker)
Content of configuration file : not relevant
Issue:
When creating a new classifier (in rasa_nlu/classifiers/) I can do the training alright but I come across a problem in the persist hook.
My code is simple, I use exactly the same as the persist hook in the sklearn classifier but I get this error :
File "/usr/local/lib/python2.7/pickle.py", line 286, in save
    f(self, obj) # Call unbound method with explicit self
  File "/usr/local/lib/python2.7/site-packages/cloudpickle/cloudpickle.py", line 631, in save_file
    raise pickle.PicklingError("Cannot pickle closed files")
pickle.PicklingError: Cannot pickle closed files

I'm not sure if it is a problem with the size of the model or if there's something that I should do to be able to persist the model (its directory is created and has the good read/write rights).
Thanks !

@thaume The code from the sklearn persist method uses the pickle protocol to persist the trained classifier.
It might not be the best way to persist your component, as it will try to persist all attributes of your components instance. It seems like there is an attribute of your object that can not be pickled (in this case a closed file, e.g. somewhere in your component you got something like `self.
How you can resolve this (there are two ways):

make sure all attributes of your component are pickable
only dump the attributes you want (e.g. have a look at the persist implementation of the crf_entity_extractor.py, it dumps specific attributes to file and writes other attributes to the metadata)

@tmbo thanks I will look into it !


brscan5 # error: cannot download brscan5-1.2.6-0.amd64.deb from any mirror - curl: (22) The requested URL returned error: 404

Describe the bug
brscan5 fails via nixos configuration
curl: (22) The requested URL returned error: 404
error: cannot download brscan5-1.2.6-0.amd64.deb from any mirror
Steps To Reproduce
Steps to reproduce the behavior:
fails
hardware = {
   sane = {
      enable = true ;
      extraBackends = [
        pkgs.utsushi
        ] ;
      brscan5 = {  # brscan4 works
        enable = true ;
      };
   };
  };

works
nix-env -i brscan5
Expected behavior
should work in each scenario
Screenshots
trying https://download.brother.com/welcome/dlf104033/brscan5-1.2.6-0.amd64.deb
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
error: cannot download brscan5-1.2.6-0.amd64.deb from any mirror
Additional context
Add any other context about the problem here.
Notify maintainers
@mattchrist
@jraygauthier
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
warning: unknown setting 'experimental-features'
warning: unknown setting 'experimental-features'
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.13, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
warning: unknown setting 'experimental-features'
 - version: `nix-env (Nix) 2.3.16`
warning: unknown setting 'experimental-features'
 - channels(root): `"nixos-21.11.335130.386234e2a61"`
warning: unknown setting 'experimental-features'
 - channels(user): `"home-manager-21.11, nixos-21.11.335665.0f316e4d72d, nixpkgs-21.11.335665.0f316e4d72d, nixpkgs-unstable-22.05pre349906.7f65e4abd5e"`
warning: unknown setting 'experimental-features'
 - nixpkgs: `/home/user/.nix-defexpr/channels/nixpkgs`

Non-free derivations aren't cached by cache.nixos.org. That means that any user of this module will try to download directly from Brother's servers instead of the cache. Unfortunately, that means that if Brother yoinks a release (as they did with 1.2.6-0), that this module breaks.
This was already updated once in nixos-unstable, where version 1.2.7-0 is being used, but it now seems that that version has been pulled as well...


az login broken with service principal

Trying to login with a service principal is now failing:
az login --service-principal -u 'xxxx' -p 'xxxx' -t 'xxxx'
File "/azure-cli/src/azure-cli-core/azure/cli/core/_profile.py", line 485, in save_service_principal_cred
    self._service_principal_creds.pop(matched[0])
TypeError: 'dict' object cannot be interpreted as an integer

This scenario works well when checking out at the commit directly before https://github.com/Azure/azure-cli/pull/2457 @yugangw-msft.
Thanks!

I am not able to reproduce it.
If you run az account clear and redo it, does that repro?

If i run az account clear the error goes away.
Thanks!

I suspect this is the same situation I get, but with a slightly different error: TypeError: an integer is required.
an integer is required
Traceback (most recent call last):
  File "/home/bridge/lib/azure-cli/local/lib/python2.7/site-packages/azure/cli/main.py", line 37, in main
    cmd_result = APPLICATION.execute(args)
  File "/home/bridge/lib/azure-cli/local/lib/python2.7/site-packages/azure/cli/core/application.py", line 157, in execute
    result = expanded_arg.func(params)
  File "/home/bridge/lib/azure-cli/local/lib/python2.7/site-packages/azure/cli/core/commands/__init__.py", line 368, in _execute_command
    raise ex
TypeError: an integer is required

In case someone's googling the error message, running az account clear will also fix this problem.

The original issue will be fixed through #2848.  an integer is required appears a different error case, please open a new issue with repro, and I will take a look


Fixing support for schema references in parameters.

This is a recreation of PR #27 that fixes #26, but with tests and merge-able. I believe it also accomplishes the goal of #35?
An additional point of concern:
I also noticed that the generated snippets with this just say qs: {pet: 'SOME_OBJECT_VALUE'} instead of giving a full example/generation of the object.
Is this an issue/improvement that needs to be made, or is my test case missing something in order to get that to work?
Either way, it seems like an issue for a different PR but I would like some clarification on this.

@vpillinger Thank you for that PR!
I agree, this successfully revives #27, and it does address #26.
I also think this fixes #35 (@codyaray)
Giving a better example than 'SOME_OBJECT_VALUE' is not yet supported. I think this may warrant a new, dedicated issue (and eventually PR). However, one concern I have is that there are different encoding styles for query strings, especially when dealing with objects / arrays - so the question becomes which one to use? My personal opinion is that relying on a popular library like https://www.npmjs.com/package/qs to handle the encoding (using default settings) may be a way to go.
For now, thanks for the PR, I will accept and create a new version.


Coult not download packages.config - server 503 error

What You Are Seeing?
Error saying Could not download packages.config.
What is Expected?
It succeeding with a 200
What version of Cake are you using?
Latest (don't think this matters)
Are you running on a 32 or 64 bit system?
64bit (don't think this matters)
What environment are you running on?  Windows? Linux? Mac?
Windows (don't think this matters)
Are you running on a CI Server?  If so, which one?
Internal TeamCity windows server (don't think this matters)
How Did You Get This To Happen? (Steps to Reproduce)
Run the build.ps1 file
Output Log
[06:07:23][Step 1/1] PowerShell Executable: C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe
[06:07:23][Step 1/1] Working directory: C:\TeamCity\buildAgent\work\a3e22591210d757f
[06:07:23][Step 1/1] Command: C:\Windows\sysnative\WindowsPowerShell\v1.0\powershell.exe
[06:07:23][Step 1/1] PowerShell arguments: -NoProfile, -NonInteractive, -ExecutionPolicy, ByPass, -File, C:\TeamCity\buildAgent\work\a3e22591210d757f\build.ps1
[06:07:26][Step 1/1] Preparing to run build script...
[06:07:27][Step 1/1] Could not download packages.config.
[06:07:27][Step 1/1] At C:\TeamCity\buildAgent\work\a3e22591210d757f\build.ps1:86 char:9
[06:07:27][Step 1/1] +         Throw "Could not download packages.config."
[06:07:27][Step 1/1] +         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[06:07:27][Step 1/1]     + CategoryInfo          : OperationStopped: (Could not download packages.c
[06:07:27][Step 1/1]    onfig.:String) [], RuntimeException
[06:07:27][Step 1/1]     + FullyQualifiedErrorId : Could not download packages.config.
[06:07:27][Step 1/1]
[06:07:27][Step 1/1] Process exited with code 1
[06:07:29][Step 1/1] Process exited with code 1
[06:07:27][Step 1/1] Step New build step (PowerShell) failed

PS C:\code> Invoke-WebRequest -Uri https://cakebuild.net/download/bootstrapper/packages -OutFile packsss
Invoke-WebRequest : Error 503 Backend is unhealthy
Backend is unhealthy
Guru Mediation:
Details: cache-ams4129-AMS<PHONE_NUMBER> 430480049
Varnish cache server
At line:1 char:1
+ Invoke-WebRequest -Uri https://cakebuild.net/download/bootstrapper/pa ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-WebRequest], WebException
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand

Do you have a corporate proxy or similar? Just tried surfing to https://cakebuild.net/download/bootstrapper/packages without issue and PowerShell worked fine

Maybe something temporary, are you still having issues?

According to this:
https://twitter.com/githubstatus/status/1014755380407296000
There was an issue with GitHub around the time that this issue was created, so it is likely related.

Yeah works again now, makes sense that it was related to temp github issue 👍


ubports-installer: Update to version 0.9.10-beta and fix autoupdate

ubports-installer: couldn't match 'ubports-installer_([\w.-]+)_win_x64.exe' in https://github.com/ubports/ubports-installer/releases

[X] I have read the Contributing Guide.

/verify


Org quota

Hi
As far as I could see this exporter does not scrape the metrics of org quota for each org & current org quota usage. Would this be added in the future, please ?
Regards.

Hi @pdev1989 !
CF exporter doesn't scrape this metric because it's configured on the deployment level through the maximum_app_disk_in_mb cc property, so currently there is no way to retrieve this setting using CF API.
https://github.com/cloudfoundry/capi-release/blob/c269265ab3e80b566d33226729c07868aaee28af/jobs/cloud_controller_ng/spec#L729-L731


Automated cherry pick of #5555: feat(notify): Compatibility and repair

Cherry pick of #5555 on release/3.0.
#5555: feat(notify): Compatibility and repair

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.0@e444d5e). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             release/3.0   #5557   +/-   ##
=============================================
  Coverage               ?   6.86%
=============================================
  Files                  ?     535
  Lines                  ?   91169
  Branches               ?       0
=============================================
  Hits                   ?    6262
  Misses                 ?   84386
  Partials               ?     521

Flag
Coverage Δ

#aFlag
6.86% <0.00%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e444d5e...8e767cc. Read the comment docs.


Make the holoviz tutorial into an anaconda-project

We currently produce only a highly pinned conda package. That's ok, because holoviz isn't a library that's designed to be integrated into someone else's package (that's what the libraries underlying holoviz are for). But a highly pinned conda package can be difficult/annoying to install, except in a dedicated environment. So we suggest: create env create -n holoviz-tutorial python=3.7 && conda activate holoviz-tutorial && conda install -c pyviz holoviz followed by holoviz examples to get the examples. A nicer alternative might be a "conda env create (remote env file on anaconda.org or maybe github)" command. Or an anaconda project/similar.
Alternatively, we could say something like "conda install pyct && pyct holoviz examples && cd holoviz-examples && conda env create" (pyct having few dependencies and hence being easy to install).

Just a note that there is no support for remote conda env spec files  at the moment. So I think we are stuck with packages.

We are still using packages, but there are at least three viable alternatives to consider:

anaconda-project: Projects neatly package an environment, a set of .py  or .pynb files, and a way to fetch data, which covers precisely what the tutorial needs.  Plus we've already worked out (and continue to optimize) methods for capturing dependencies reproducibly in a way that can be upgraded later, which is also needed here.  Specific versions can easily then be archived from specific events. Moreover, if we use examples.pyviz.org to host the projects, the files will be individually git version controlled while also generating specific zip files when the contents change.  However, it doesn't fit perfectly into examples.pyviz.org, as these literally are not examples but training material, and we also don't want a dozen different icons for it to pollute examples.pyviz.org unless it's in a separate section. We'd need a way to tell people to get the project and open it on their machine. Still seems like a viable option with a lot of advantages.
conda create: conda create --file https://raw.githubusercontent.com/binder-examples/requirements/master/requirements.txt -n test will build an environment from a remote specification, but it's not a conda spec, which could be painful.  It seems like it is possible to specify channels in that file, so maybe it would work.  We'd still need a way to distribute the .ipynb files meant for that environment, which is what the metapackage achieves.
conda env create: conda install anaconda-client -n base && conda env create jbednar/testy -- for environments uploaded to anaconda.org (see below). Doesn't currently accept a full URL but does support remote conda env spec files.  Similar to the requirements.txt option in that it doesn't provide a way to get the notebooks.

Uploading environments to anaconda.org works as follows:
$ conda env export -n testy -f testy.yml
$ anaconda upload testy.yml
...
environment located at:
https://anaconda.org/jbednar/testy
$ conda env remove -n testy
Remove all packages in environment /Users/jbednar/miniconda3/envs/testy:
$ conda env create jbednar/testy
SpecNotFound: Anaconda Client is required to interact with anaconda.org or an Anaconda API. Please run `conda install anaconda-client -n base`.
$ conda install anaconda-client -n base
Collecting package metadata (current_repodata.json): done
Solving environment: done
...
Executing transaction: done
$ conda env create jbednar/testy
Collecting package metadata (repodata.json): done
Solving environment: done
...
 To activate this environment, use
#
#     $ conda activate testy
$

Oh, and a way to eliminate some of the problems with the metapackage holoviz being confusing (why do I get out of date packages? Is this how I am meant to install holoviz?  What is this package for) is simply to rename the metapackage holoviz-tutorial.  A tutorial won't surprise anyone if it's pinned strictly, presumably, while holoviz being pinned does, and in practice we have not been updating holoviz pinning often enough for it to be useful as a guide to mutually compatible versions for purposes other than tutorials.

I think renaming the package from holoviz to holoviz-tutorial would be a good move (doesn't preclude other options in the future).

I agree that renaming it would be an improvement, but I think I favor simply releasing an anaconda-project instead. Seems much simpler than making packages.

Making an anaconda-project is a good idea regardless!

When we do that, I propose that we re-release the holoviz package unpinned, so that it works as an easy way to install the latest versions of the holoviz tools (apart from geoviews, I think), without us ever having to update and release it again.

Done!


[MNOE-301] - Refactor billing details page to use the auth design

@alexnoox can you review this please?

I think the box could be a little bit wider since there is quite some text.

@ouranos can you have a look pelase? :+1:


Exported image cut off - Safari Technology Preview

Describe the bug
When using the Safari Technology Preview browser (Release 141 (Safari 15.4, WebKit 176<IP_ADDRESS>)), the Export command produces an image that is shifted to the left by about half the image size, leaving the left half of the image off.
To Reproduce

Open carbon.now.sh in Safari Technology Preview browser
Click on 'Export'
See the image in Downloads folder

Expected behavior
Expected to see an image that isn't shifted and cropped.
Screenshots
Expected image:

Incorrect image:

Info:

OS: macOS Monterey 12.12.1
Browser: Safari Technology Preview release 141
Carbon URL: carbon.now

It happens in the standard Safari 15.4 as well

@terrymorse58  @cperezabo I just tried it out on basic Safari, and it is working for me. Please share a link to a Carbon snippet that reproduces this bug.

@terrymorse58 @cperezabo I just tried it out on basic Safari, and it is working for me. Please share a link to a Carbon snippet that reproduces this bug.

I can reproduce it:
https://user-images.githubusercontent.com/28441561/161749499-e54d4190-7160-49ab-978a-fb9422a00843.mov

It works properly when outputting in 1x size. Besides, outputting in 4x made all the canvas white.

@hatsu38 I think this came from one of your recent PRs. Do you have time to take a quick look? Otherwise I think I will have to revert :/

@erikr @pan93412 @terrymorse58 @cperezabo this seems to be a regression in Safari somehow. Would love some help finding a bug fix here, if any of you have the time.

👋 Hey there!
I have a quick patch for this issue here: https://github.com/carbon-app/carbon/pull/1405
It's my first time contributing to Carbon, so if a repo owner can take a quick look I'd appreciate it (changed 2 lines of code) 🙏
Cheers!


Error: [Errno 2] No such file or directory

IOError on an image...trying next one... Error: [Errno 2] No such file or directory: 'downloads/myQuery /1
Ex:
Starting Download...
IOError on an image...trying next one... Error: [Errno 2] No such file or directory: 'downloads/Polar bears /1. 220px-Polar_Bear_-Alaska%28cropped%29.jpg'
IOError on an image...trying next one... Error: [Errno 2] No such file or directory: 'downloads/Polar bears /1. edu-center-D00002331.jpg'
IOError on an image...trying next one... Error: [Errno 2] No such file or directory: 'downloads/Polar bears /1. Medium_WW22786.jpg'
IOError on an image...trying next one... Error: [Errno 2] No such file or directory: 'downloads/Polar bears /1. Original_WW215278.jpg'
IOError on an image...trying next one... Error: [Errno 2] No such file or directory: 'downloads/Polar bears /1. skynews-polar-bears-arctic_4130795.jpg'
IOError on an image...trying next one... Error: [Errno 2] No such file or directory: 'downloads/Polar bears /1. Facts-about-polar-bears-5.jpg'
IOError on an image...trying next one... Error: [Errno 2] No such file or directory: 'downloads/Polar bears /1. ct_110915-23.jpg'
IOError on an image...trying next one... Error: [Errno 2] No such file or directory: 'downloads/Polar bears /1. 162652-004-34A1BA10.jpg'
IOError on an image...trying next one... Error: [Errno 2] No such file or directory: 'downloads/Polar bears /1. polar-bear-help-604mk101612-604-337-7b6e7b90.rendition.598.336.jpg'
IOError on an image...trying next one... Error: [Errno 2] No such file or directory: 'downloads/Polar bears /1.<PHONE_NUMBER>_9046c0c779_b-1024x738.jpg'
Happening on Windows and Linux.

Same issue here

Can you please post the command line query?

@MFrat , @agustinmorantes the bug had now been resolved. Do let me know if you still see this as an issue in Windows OS. Closing this for now.

@hardikvasa, working now, thanks!


Fixes for creating MAC address files on Oreo

Fixes the permissions of the BT file so that the Bluetooth service can read it
Changes the format of the WLAN file to match what the kernel driver expects

please test on loire or tone

haven't tested on loire nor tone, but judging by the code that parses the address, the new format seems incompatible.
Here's the code that handles the parsing in kernel:
https://github.com/sonyxperiadev/kernel/blob/db64abe1b7856b96643efcc7898c3447f29bd771/drivers/net/wireless/controlfnc/somc-wifi-ctrl.c#L230
it simply iterates over the passed char array, so it wouldn't be able to correctly parse the new format proposed here.
A possible solution would be to add a flag for macaddrsetup to make it switch between the formats based on target device.
Another solution would be to update the parsing function in kernel, but note that changing the format would imply also applying the change to 1.3.3 branch of the kernel, since macaddrsetup is shared.

That definitely looks incompatible. This is the driver on yoshino that's expecting a different format:
https://github.com/sonyxperiadev/vendor-qcom-opensource-wlan-qcacld-3.0/blob/aosp/LA.UM.6.4.r1/core/hdd/src/wlan_hdd_cfg.c#L6644
Adding a format option to macaddrsetup seems preferable to changing the kernel, I'll push something up for that.

update bcmdhd  kernel driver to use the same format


feat: Add config file for mongodb URI, port and secret

To use this feature you must make a config/config.json file which must include mongodb_uri, and optionally port and secret. port defaults to 3000 and secret will be randomly generated.
For example
{
	"mongodb_uri": "mongodb://localhost:27071/",
	"port": 3000,
	"secret": "asdasdawd"
}

Please make the div red before we accept your pr

What div?

idk find it yourself lol


Async subscription policies not visible after migration fix

Subscription plans in Websocket APIs prior to APIM-4.0.0 are not visible after migration to a later version. These changes fixes this issue by making the original subscription policies visible after migration.
Fix for - https://github.com/wso2/api-manager/issues/165
Original (pre-migration) subscription policies for async APIs will be visible after the Async Policies with a note.

These original policies will be visible until they are deselected and will not be available for selecting after deselecting.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Deprecated PyPi Package imdirect

Hello there.
Sadly the package imdirect is no longer available via pip and therefore the requirements can no longer be installed. It would be much appreciated if you would address this issue.

Dear @florianq-two, could you try to remove the imdirect package from the environment.yml and re-run the Conda environment installation? I am pretty sure imdirect is a dependency of the PIL package. Conda should be able to fix its dependencies automatically. You may have to repeat this process also for other packages.
I will then try to clean all the python dependencies as soon as possible.
Thank you for pointing this out!


Add more lint reviews

[ ] .less with twitter/recess
[ ] .php with fabpot/PHP-CS-Fixer
[ ] .php with sebastianbergmann/phpcpd
[ ] .php with sebastianbergmann/phpdcd
[ ] .json with seld/jsonlint
[ ] * trailing whitespace

Done

[x] .php with squizlabs/PHP_CodeSniffer
[x] composer.lock with sensiolabs/security-checker

any news on that?

any news on that?

Nope haven't been able to dedicate much time to projects lately. I'm more than happy to accept PR's for any of these!


Webm export

Players should be able to record ingame videos in webm format.

Linkies for background infoz plz! :D

I vote aganist.
Video stream should be written in AVI with highest quality possible. No matter how webm codec is good, but it would decrease video stream quality and eat additional CPU time for encoding.

I'll leave it to you video wizards to sort out (I'm going to have to make a list of magic schools one day...), but we can always supply an option for what format to use, or externalize fancier formats to plugins :-)

I don't think we should enter video encoding land.
There are free screen capturing tools such as OBS or VLC that work just fine.

Agreed. Ancient issue in any case, a lot of these are still floating around but should probably be closed.


Update markdown2 dependency; keep working in Docker

This PR is to satisfy a dependabot alert about markdown2 and (unrelated) make changes to keep the Docker build and Postgres tests working.
ping @gracieflores @somexpert please verify that you can run the app and tests per the README instructions

A temporary tweak was made to docker-compose.yml (had to add :Z to web volumes as app/:Z) for podman to have permission to run app. App ran and tests passed.


Default cell language for native notebooks

For #13522 , #13520

Do not prompt to install ipykernel for non-python kernels
Default the cell of the next blank notebook to language of last saved/used notebook.
Ability to search for kernels based on language (even if kernel spec is not available)
Added Julia language, so users can install this extension and run Julia kernels (remember, they need to select a Jualia language in the cell of a VSCode native editor. However Jualia is not a built in language. Will need to submit a PR upstream).
Added tests

Pending

CI to install & setup Julia with Github actions.

Codecov Report

Merging #14314 into main will decrease coverage by 0.59%.
The diff coverage is 45.34%.

@@            Coverage Diff             @@
##             main   #14314      +/-   ##
==========================================
- Coverage   59.91%   59.32%   -0.60%
==========================================
  Files         709      713       +4
  Lines       39334    39801     +467
  Branches     5698     5771      +73
==========================================
+ Hits        23567    23610      +43
- Misses      14529    14949     +420
- Partials     1238     1242       +4

Impacted Files
Coverage Δ

src/client/common/application/notebook.ts
10.52% <0.00%> (-0.39%)
:arrow_down:

src/client/common/application/types.ts
100.00% <ø> (ø)

src/client/datascience/baseJupyterSession.ts
56.30% <0.00%> (-1.04%)
:arrow_down:

src/client/datascience/jupyter/jupyterNotebook.ts
4.20% <0.00%> (-0.02%)
:arrow_down:

src/client/datascience/jupyter/kernels/types.ts
25.00% <ø> (ø)

...ascience/jupyter/liveshare/guestJupyterNotebook.ts
8.96% <0.00%> (-0.33%)
:arrow_down:

src/client/datascience/kernel-launcher/types.ts
23.07% <ø> (ø)

src/client/datascience/notebook/notebookEditor.ts
5.71% <0.00%> (ø)

...science/notebookStorage/notebookStorageProvider.ts
50.74% <0.00%> (ø)

src/client/datascience/types.ts
100.00% <ø> (ø)

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b8fbbf...813a703. Read the comment docs.


fix 473 for fs.WriteFile

This test seems to already exist: https://github.com/filerjs/filer/blob/master/tests/spec/fs.writeFile-readFile.spec.js
But if you still want to write this test, try adding data parameter to your writeFile().
Look https://nodejs.org/api/fs.html#fs_fs_writefile_file_data_options_callback for method description.

NOTE: when you create a PR, make sure you provide both a Subject line and a full Description to describe what the changes do, why you did what you did, which Issue # it fixes (e.g., Fixes #473).


Flaky test: DoesNotThrowOnFin

This test fails occasionally with the following error:
Microsoft.AspNetCore.Connections.ConnectionResetException : Error -4077 ECONNRESET connection reset by peer
---- Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.UvException : Error -4077 ECONNRESET connection reset by peer
   at System.IO.Pipelines.PipeCompletion.ThrowLatchedException()
   at System.IO.Pipelines.Pipe.GetReadResult(ReadResult& result)
   at System.IO.Pipelines.Pipe.GetReadAsyncResult()
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Http1MessageBody.PumpAsync()
   at System.IO.Pipelines.PipeCompletion.ThrowLatchedException()
   at System.IO.Pipelines.Pipe.GetReadResult(ReadResult& result)
   at System.IO.Pipelines.Pipe.GetReadAsyncResult()
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.MessageBody.CopyToAsync(Stream destination, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpRequestStream.CopyToAsyncInternal(Stream destination, CancellationToken cancellationToken) in /_/src/Kestrel.Core/Internal/Http/HttpRequestStream.cs:line 157
   at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.UpgradeTests.<>c__DisplayClass8_0.<<DoesNotThrowOnFin>b__0>d.MoveNext() in /_/test/Kestrel.FunctionalTests/UpgradeTests.cs:line 314
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Testing.TaskExtensions.TimeoutAfter[T](Task`1 task, TimeSpan timeout, String filePath, Int32 lineNumber)
   at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.UpgradeTests.DoesNotThrowOnFin() in /_/test/Kestrel.FunctionalTests/UpgradeTests.cs:line 334
--- End of stack trace from previous location where exception was thrown ---
----- Inner Stack Trace -----
------- Stdout: -------
| [0.001s] TestLifetime Information: Starting test DoesNotThrowOnFin at 2018-07-27T00:15:06
| [0.009s] Microsoft.AspNetCore.Hosting.Internal.WebHost Debug: Hosting starting
| [0.018s] Microsoft.AspNetCore.Hosting.Internal.WebHost Debug: Hosting started
| [0.018s] Microsoft.AspNetCore.Hosting.Internal.WebHost Debug: Loaded hosting startup assembly Libuv.FunctionalTests, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60
| [0.020s] Microsoft.AspNetCore.Server.Kestrel Debug: Connection id "0HLFJAO0AVU8J" started.
| [0.020s] Microsoft.AspNetCore.Hosting.Internal.WebHost Information: Request starting HTTP/1.1 GET http:///
| [0.140s] Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv Debug: Connection id "0HLFJAO0AVU8J" reset.
| [0.140s] Microsoft.AspNetCore.Server.Kestrel Debug: Connection id "0HLFJAO0AVU8J" disconnecting.
| [0.141s] Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv Debug: Connection id "0HLFJAO0AVU8J" sending FIN.
| [0.144s] Microsoft.AspNetCore.Hosting.Internal.WebHost Debug: Hosting shutdown
| [0.144s] Microsoft.AspNetCore.Server.Kestrel Error: Connection id "0HLFJAO0AVU8J", Request id "0HLFJAO0AVU8J:00000001": An unhandled exception was thrown by the application.
| Microsoft.AspNetCore.Connections.ConnectionResetException: Error -4077 ECONNRESET connection reset by peer ---> Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking.UvException: Error -4077 ECONNRESET connection reset by peer
|    --- End of inner exception stack trace ---
|    at System.IO.Pipelines.PipeCompletion.ThrowLatchedException()
|    at System.IO.Pipelines.Pipe.GetReadResult(ReadResult& result)
|    at System.IO.Pipelines.Pipe.GetReadAsyncResult()
|    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Http1MessageBody.PumpAsync()
|    at System.IO.Pipelines.PipeCompletion.ThrowLatchedException()
|    at System.IO.Pipelines.Pipe.GetReadResult(ReadResult& result)
|    at System.IO.Pipelines.Pipe.GetReadAsyncResult()
|    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.MessageBody.CopyToAsync(Stream destination, CancellationToken cancellationToken)
|    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpRequestStream.CopyToAsyncInternal(Stream destination, CancellationToken cancellationToken) in /_/src/Kestrel.Core/Internal/Http/HttpRequestStream.cs:line 157
|    at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.UpgradeTests.<>c__DisplayClass8_0.<<DoesNotThrowOnFin>b__0>d.MoveNext() in /_/test/Kestrel.FunctionalTests/UpgradeTests.cs:line 314
| --- End of stack trace from previous location where exception was thrown ---
|    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication`1 application) in /_/src/Kestrel.Core/Internal/Http/HttpProtocol.cs:line 555
| [0.149s] Microsoft.AspNetCore.Hosting.Internal.WebHost Information: Request finished in 128.7423ms 101
| [0.149s] Microsoft.AspNetCore.Server.Kestrel Debug: Connection id "0HLFJAO0AVU8J" stopped.
| [0.165s] TestLifetime Information: Finished test DoesNotThrowOnFin in 0.1639264s

Other tests within that build may have failed with a similar message, but they are not listed here. Check the link above for more info.
CC @Eilon,@muratg,@mkArtakMSFT
This issue was made automatically. If there is a problem contact @ryanbrandenburg.

Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:

Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)

[ ] File a bug against the product (TODO: Link to other bug)
Is it possible to change the test to avoid the flakiness?

Yes? Go to the "Change the test!" section.
No?

[ ] Disable the test (TODO: Link to PR/commit)
[ ] Wait for other bug to be resolved
[ ] Wait for us to get build that has the fix
[ ] Re-enable our test (TODO: Link to PR/commit)
[ ] Close this bug

Is it that the test itself is flaky? This includes external transient problems (e.g. remote server problems, file system race condition, etc.)

Is there is a way to change our test to avoid this flakiness?

Yes? Change the test!

[ ] Change the test to avoid the flakiness, for example by using a different test strategy, or by adding retries w/ timeouts (TODO: Link to PR/commit)
[ ] Run the test 100 times locally as a sanity check.
[ ] Close this bug

No?

[ ] Delete the test because flaky tests are not useful (TODO: Link to PR/commit)

This comment was made automatically. If there is a problem contact @ryanbrandenburg.

DoesNotThrowOnFin failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.

@halter73 , a special delivery for you.

DoesNotThrowOnFin failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.

DoesNotThrowOnFin failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.

DoesNotThrowOnFin failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.

DoesNotThrowOnFin failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.

DoesNotThrowOnFin failed with about the same error.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.

DoesNotThrowOnFin failed with about the same error.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.

DoesNotThrowOnFin failed with about the same error.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.

DoesNotThrowOnFin failed with about the same error.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.


[Enhancement Idea] Autofill

I've been testing autofill, and I really like it. Could some improvements be possible? For example in some cases it designates a man with a woman in student parts: Initial Call, Return Visit, etc, it would be necessary to create a filter so that the assistant is someone of the same gender as the student. And another interesting filter would be in the Living as Christians section he would designate the elders parts, just for elders. In this case it would be local needs and the parts where the source material appears as below:

Oh... It seems like the first issue is occuring again. We have already fixed that in the past. I will look at it again.
I will add the next one to the backlog list. It will be implemented when the new persons page is released.
Thanks!


Simple merge from an array of file

Hello,
thanks for this great job!
I'm trying to do a simple task without success, i simply try to merge xml from an array of files fectched from this command:
$fileList = glob('APPLOCK_*.xml');
I have try to get inspiration from example without success, could you please provide an example on how to achieve this and save it to mergerd.xml?
Thank you and have a nice day
Current not working code
<?php
	require 'mergexml.php';    /* load the class */
	$filelist = glob('APPLOCK_*.xml');
	print_r($filelist);
	$oMX = new MergeXML(['updn'=>true]);
	foreach($filelist as $filename){
		if(is_file($filename)){
			$oMX->AddFile($filename);
		}
	}
	$rsp = $oMX->error->text; /* missing feature */
	echo $rsp;
?>

Hi, thank you for interest to MergeXML. Using of Addfile method  is right solution.
You should check, are the $filename's correct XML files. I suppose the $filelist  gets same not empty array.


Something wrong with pars_args()

Using this example, I found a problem in def main()
def main():
    desc = "Visit check.torproject.org website"
    parser = ArgumentParser(description=desc)
    parser.add_argument('TBB_PATH')
    args = parser.parse_args()
    visit(args.tbb_path)

In line args = parser.parse_args() I got an error:

the following arguments are required: TBB_PATH

in py3.4, and

error: too few arguments

in py2.7
If I try debugging step by step it raise:

args = parser.parse_args()
        ^
SyntaxError: invalid syntax

and

SystemExit: 2

TBB_PATH writed to environment variables
OS: Win10

argparse expects you to pass TBB path as a command line argument. For instance:
python check_tpo.py  ~/tor-browser_en-US/
Let me also say that tbselenium is not tested on Windows. If you make it work let me know, otherwise try running it on a Linux VM in your Windows box.


Revise lambda application configuration test data

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/golinter fmt


Video Game Voice Chatting with WebRTC

Hello, I wrote a WebGL/HTML5 video game that runs in browser (JavaScript), and i want my players to have voice chat so they can talk to each other while playing.
So i want to have a headless linux server so that the HTML5 video game code can communicate with the server to create WebRTC voice rooms on the server so players can conference chat with each other wile playing.
I read there is a new API in JavaScript called MediaDevices.getUserMedia() that can use WebRTC for voice conferencing.
Since i really dont know anything about it (there is so many things to know these days) do you know any WebRTC type server that can set up the voice chat rooms and route the voice streams to each other, and also Javascript code in the browser to capture the mic, send streams and play streams from others using WebRTC and MediaDevices.getUserMedia(), or have any code that shows how to do all that??
Any help would be appreciated, thanks!

You need SFU (Selective Forwarding Unit) for that, there are solution you can use,

Janus Media Server
Mediasoup
Kurento


Bug: Shortened URLs fail with trailing slash (#3)

This commit strips off any trailing slashes from the URL being parsed.

Thanks!


Generic fallback image

General Support Request
Currently, auro-avatar only supports when a code is not given and it points to SEA. There is no support for a 404 request.
Support request
Update the element to support a new generic image for both cases of non-entry and 404.
https://resource.alaskaair.net/-/media/Images/common-assets/destinations/180x180/partner
https://resource.alaskaair.net/-/media/Images/common-assets/destinations/360x360/partner
https://resource.alaskaair.net/-/media/Images/common-assets/destinations/800x800/partner
having a fall back will fix #16

Increased use has exposed an issue where new destinations are being requested prior to avatar art being created. Having a consistent fallback is needed.

@blackfalcon  how is the art supposed to be created, and once it is, how is it supposed to be uploaded to Auro's CDN?

@jason-capsule42  how will this be implemented? Kayla Blyton spent some time last year making fallback images per region, depending on the station requested. There is a hook for this in the component hangar (resolving a station name to a region). Please let me know if this makes sense.

https://www.figma.com/file/y85boLCDQxxyYfgBourkaw/Partner-Destination-Images?node-id=0%3A1

From Kayla:
Link to the 180x 180 image for BZE (media library -> images -> common assets -> destinations -> partner destinations -> 180 x 180 -> BZE):
https://cms.alaskaair.com/sitecore/shell/Applications/Content Manager/default.aspx?he=Media+Library&pa=1&ic=Applications%2F16x16%2Fphoto_scenery.png&mo=media&ro={3D6658D8-A0BF-4E75-B3E2-D050FABCF4E1}&sc_bw=1
Link to the 180 x 180 image for MEX - 'Central America' is the generic image for this region (media library -> images -> common assets -> destinations -> partner destinations -> 180 x 180 -> Central America)https://cms.alaskaair.com/sitecore/shell/Applications/Content Manager/default.aspx?he=Media+Library&pa=1&ic=Applications%2F16x16%2Fphoto_scenery.png&mo=media&ro={3D6658D8-A0BF-4E75-B3E2-D050FABCF4E1}&sc_bw=1
I have trouble getting links to point to specific locations in SC8, so I provided the path too. In the "Partner Images" folder there are files for all the other image sizes.
Figma File with all final images and associated regions: https://www.figma.com/file/y85boLCDQxxyYfgBourkaw/Partner-Destination-Images?node-id=403%3A7695

@gusnaughton the idea we had was to try the URL from the requested image code and if that returns a 404 then insert a fallback image. The idea here is that we need to guard ourselves against any new destination that an avatar has not been created for yet. And when that avatar is created, then it will be used.
Your hooks are for specific endpoints, right? Why do we not have an image avatar for BZE or MEX? I don't really want to get into the business of maintaining an alias list of avatar endpoints.


perf(runtime-core): improve efficiency of normalizePropsOptions

Closes #9739.
The result of normalizePropsOptions is cached, so the performance usually doesn't matter too much. But there are two cases where the cache may not help:

SSR. The cache is per application instance, so a new cache is used for each request.
Components created on-the-fly, e.g. by defining them inside the <script setup> block of another component.

A lot of time in normalizePropsOptions is spent in getType, trying to figure out the values of the shouldCast and shouldCastTrue flags. I go into a bit more detail about that at https://github.com/vuejs/core/pull/9739#issuecomment-2144177971.
The Playground isn't necessarily the best tool for benchmarking, but here's an example to try to illustrate that my changes have improved the performance:

Playground - 3.4.33
Playground - this PR

I based my branch on 3.4.33, so it should be a fair comparison. It seems to be faster in both Chrome and Firefox (I didn't try other browsers).
The Playground example isn't very 'real'. It's designed to focus on the performance of normalizePropsOptions as much as possible, so the performance benefit would be much less in real applications. But if performance can be improved without hurting bundle size or maintainability, it seems worth it to me.
The Playground uses small arrays for the type. I think that's representative of real code. I didn't think it would be realistic to test with arrays of hundreds or thousands of items, so my conclusions are all based on the assumption that the arrays will be relatively short.
Most of my benchmarking I did using Node instead, calling normalizePropsOptions directly. Using a similar props definition to the one in the Playground above I saw an improvement of about 35%. There's a version of the code I used at:

https://gist.github.com/skirtles-code/99f3a65e38ea68c65560558bcc7919a3

That's using arrays for the prop types. I also tested using other values, such as type: String. The performance still seemed slightly better, maybe about 10% better, but it was less clear relative to the background noise in the measurements.
I also tried to reduce the size of the build. There was a lot of code involved in performing the shouldCast/shouldCastTrue checks, much of which is no longer needed. I experimented with various implementations, testing both the performance and build size. The first commit on this PR, https://github.com/vuejs/core/pull/11409/commits/3f37cf79616208cf03cff69c1fd898f1e53a5034, gave a slightly smaller build size (saving 176 bytes rather than 116), but it wasn't quite as fast as the second version (about 30% faster than 3.4.33, rather than 35%).

The original motivation for these changes came from #9739, which proposed adding a cache to getType. Since that PR was opened there have been other changes to getType via #10327. I think those other changes make adding a cache less effective. The remaining problem is just that getType gets called so much, which is essentially the problem I'm attempting to address here.

One of the changes introduced by #10327 was this code:
https://github.com/vuejs/core/blob/422ef34e487f801e1162bed80c0e88e868576e1d/packages/runtime-core/src/componentProps.ts#L610-L614
I'm not entirely sure why this code was added. It isn't explained in the PR description and there aren't any tests for it. I suspect it may have been introduced by mistake. It leads to strange handling of some edge cases. For example, consider a prop with type: [new Boolean(true)]. Obviously that's nonsense, but as of 3.4.19 (which is the first release to include that change) it behaves the same as type: Boolean. Playground example.
In the changes I've made in this PR I have not attempted to retain this behaviour. I'm now just checking for isFunction(type) && type.name, which seems to be all we need in practice.
My code does duplicate this check, once for array types and then again for non-arrays. I did try to remove the duplication, but it just ended up adding extra bytes to the build, or making it slower, or both. To see an example of one of my attempts, take a look at the first commit on this PR, https://github.com/vuejs/core/pull/11409/commits/3f37cf79616208cf03cff69c1fd898f1e53a5034. That does remove the duplication, but at the expense of being slower. I also felt that version was slightly more difficult to understand for future contributors.

I've made a change to NormalizedProp to remove null from the type. From what I can tell, the null was needed when that type was first introduced, but other code has changed since, so it can now be removed. Removing the null allowed me to remove the if (prop) check in normalizePropsOptions. While this doesn't really impact the performance, it did seem to be redundant and shaves a few bytes off the bundle.

The main change is to introduce a single for loop over the type array. The type is then checked directly against the strings 'Boolean' and 'String', rather than using multiple calls to getType to get those strings. The getType function is no longer used here, and is now only used in dev code, allowing it be to treeshaken.
I experimented with using other types of loop, such as some and for/of, but ultimately a basic for seemed to give the best performance. In particular, using for/of seemed slightly slower in Firefox. The superior performance of a basic for is maybe no great surprise, but nevertheless I did try to confirm that it really was best when working with short arrays in current browsers.

Slight tangent...
I find the Brotli sizes to be a bit erratic. They seem to jump around almost randomly. For example, at the time of writing, the Brotli/overall value given in the size report is +2. But if I swap round these two lines to be in the opposite order, it jumps to -41:
let shouldCast = false
let shouldCastTrue = true

I gave up chasing the Brotli size and chose to focus on Size and Gzip instead, as they seemed like a more reliable way to judge progress.

/ecosystem-ci run