Incomplete Infomation

Html and JavaScript source code at http://jsbin.com/iyifuh/8 I am not 100% sure how to make JSBIN work, but you can view source to capture the source codes. My browser is IE8.
This is what it captured, but did not tell me function name.
error: at document path 'http://localhost:2692/'.
at function
at function
at function
at function

Details, please (browser version, sources of failing page/script, etc.)? Can you make test example on http://jsbin.com/ ?

I have included the information you need in my original post.

:[
I don't know where you found that code, but it has nothing common with current state of stacktrace library. Try to download and attach our latest sources.
Or try to change line
var fname = fn.substring(fn.indexOf("function") + 8, fn.indexOf('')) || 'anonymous';

to just
var fname = fn || 'anonymous';

and test in IE8.


opcode(mul): refactor mul_new branch

read add op : zkevm-circuits/src/evm_circuit/execution/add.rs
rewrite mul op following the add

There's an existing implementation of mul opcode at https://github.com/scroll-tech/zkevm-circuits/tree/mul_new.
But we need to refactor it according to the new format


New command: teams channel user list

Usage
teams channel user list
Description
Lists users for the specified Microsoft Teams channel
Options

Option
Description

-i, --teamId [teamId]
The Id of the Microsoft Team.

--teamName [teamName]
The name of the Microsoft Team.

-c, --channelId [channelId]
The Id of the Microsoft Team channel.

--channelName [channelName]
The name of the Microsoft Team channel.

Additional Info
Docs: List members of a channel
Discussed in #3168

Maintainers could you have a look at the proposed command? If the above is fine, I'd like to work on this one.

Hi @milanholemans,
this command looks good to me. I would like to ask you to start with the teams channel user list, then move to #3174, #3177, and #3175.
I will assign you two commands for now. Once we are through with these we can definitely assign you the other commands.
Thank you

Looks good @milanholemans! The only suggestion I have is to remove the short -i because it's ambiguous whether it refers to team's or channel's ID.

@waldekmastykarz I have adjusted the specs with your feedback.
I also added an extra option role as enhancement. This way only the owners, members or guests are returned as result.

@waldekmastykarz @plamber during testing I encountered a quite big problem. For all suggested commands to manage users in private channels, we need ChannelMember.ReadWrite.All permission. These permissions are currently not in the PnP app registration so all graph calls are failing.

@waldekmastykarz I also noticed that we need more permissions. The permission level ChannelMember.ReadWrite.All is needed to make this (and other) commands work.

@waldekmastykarz I have adjusted the specs with your feedback. I also added an extra option role as enhancement. This way only the owners, members or guests are returned as result.

Thank you! If I look at the API, roles seem to be lowercase. Let's adjust our spec to reflect that as our enum comparisons are case-sensitive. Also, since role is optional, let's include in its description what the default behavior is.
For the options, where we have an ID and a name pair, let's extend the descriptions mentioning which options belong to a set, eg. Specify either teamId or teamName

@waldekmastykarz I also noticed that we need more permissions. The permission level ChannelMember.ReadWrite.All is needed to make this (and other) commands work.

Thanks for the heads up. We'll add it when we'll review the PR. For development, you can either use a custom app with this permission or manually grant the missing scope in your tenant.


Bump sonoff to 3.0.3

update confirmed by @GermanBluefox at 6.11.2023 by telegram

3.0.3 created 25.09.2023
1500 user
OK


Unequipping the jetpack removes other entities nearby

When in close proximity to entities when unequipping the jetpack removes other entities too

fixed


attribute "start" not allowed

When converting to epub and checking this:

I get the following error:

Error while parsing file 'attribute "start" not allowed here;

I tried to make head or tail out of this solution: http://maxdesign.com.au/articles/ordered-lists/
But I can't make it work.
Is this error really an error?

If you created an EPUB 2 file, yes, it's an error. The start attribute is not valid in XHTML 1.1.

@1manfactory can you tell us which EPUB version you're creating? As @mattgarrish stated: the start attribute is not supported in XHTML 1.1 (EPUB 2) but it is valid in HTML 5 (EPUB 3).
So if you have an EPUB 2 the error is correct and we'll close this issue.

Closing this because of missing feedback from original author @1manfactory


Use logging-facade for all error reporting.

There're a few remaining occurences of hPutStrLn stderr in the test cases (precisely RunSpec and ActionMSpec), but the messages there aren't errors as such, just conveniently capturable side-effects, so I left them alone.

Yeah, that's completely fine. LGTM.


The animate.css module: Error! Unexpected character '@'

I used the express example of the pkg project to test the animate.css module I used in my project, installed by: npm i animate.css -S, and when I ran the command: pkg package.json, it came out the result:
> Error! Unexpected character '@' (1:0)
  /home/test/pkg-master/examples/express/node_modules/animate.css/animate.css

Maybe it isn't the place to ask question, but I tried according to the readme of pkg， and with no luck. It didn't work, whether I modified the package.json by adding the assets part or other way, Does anybody know how to solve this, tell me please, thx.

Hi! Please post code of minimal example. I need to know how front-end javascript code gets compiled as back-end code into executable. And then i'll try to figure out how to avoid it.

Okay, I made a small example, as issue #79 and issue #81 described.
vue-demo.zip

@igorklopov Okay, I added a simple example of using animate.css, btw, I modified the package.json too to make it work with pkg to produce the same error I met before.
vue-demo.zip

i've had a similar(but i think not the same) problem with a powershell script, it seemed pkg was trying to bundle the css as a script.
in my case the error was that i had specified:
"scripts": [
      "libs/**/*"
    ],

changing it to:
"scripts": [
      "libs/**/*.js"
    ],

solved the problem. hope it helps!

TODO. Warning if someone tries to use a .css file in "scripts"

I ran into the exact same problem. Even using your vue-demo project:

Hi Igor,
could you help me on this issue, please? As mentioned, I get the same error even using your vue-demo project. What could be wrong?

Hey guys,
I have a similar issue with .js.map files, by trying create a package for socket.io app.

Error! Unexpected token (1:10)
/Users/.../Development/projects/app/node_modules/socket.io/node_modules/socket.io-client/dist/socket.io.js.map

Has someone any idea, how to fix this? Will be really great!
Thanks,
VK

I am running into the same issue using Typeface Roboto. I am using Next JS with Material design so maybe we can find a way to ignore some files, then add them as assets?


Don't need storybook-deployer to gh-pages anymore

https://github.com/blog/2228-simpler-github-pages-publishing
Simply build them in docs folder and make the appropriate settings for the repository.

Yeah. We can set a prepublish script or something like that to generate the storybook and put it into the docs directory.

I'll put this into the next version of documentation.

since this would mean versioning that auto-generated docs/ folder, i personally would not prefer that change. i actually prefer to have a CI job run to do this automatically rather than dealing with the noise of generated files in git.
just throwing this on the table as a reminder that some prefer the current approach in case something is done to change in this direction. please at least keep the current approach as an option

Yep. We are not going to kill this :)


QE coverage for Kubernetes Secrets, Persistent Volumes, ConfigMaps and Nodes

Epic domain
Cover the features included in https://github.com/containers/podman-desktop/pull/7640 from quality point of view.

[ ] Adding test cases verification into release testing plan
[x] #8649
[x] #8834
[x] #9139
[x] #9140
[ ] #10001

Additional context
No response

https://github.com/containers/podman-desktop/issues/8832

@amisskii Please can you make sure that all test cases for above scenarios are in testing tracker and links to a doc with steps to verify?


Hello World - WebGL p5

What does the program do ?
WebGL rotating sphere with texture mapped onto it
In what programming language it is written?
p5

This pull request exeeds the max additions limit. Please fix it and reopen


Fix some types and remove skipLibCheck option

Hi Vova, I experienced a number of type errors when I imported the @anycable/web package, but didn't notice the errors when I pulled down anycable-client and ran yarn tsc. Realized it was because skipLibCheck in tsconfig.json had skipped a number of checks.
Fixed the type errors so we don't need the skipLibCheck flag anymore.

Great! Thanks!
Could you please take a look at CI failures?

@palkan is there a way for me to kick off another CI run, or can only you do that?

is there a way for me to kick off another CI run, or can only you do that?

It's only me for first-time PRs; as soon as we get this merged, all your subsequent PRs will run automatically.

Looks like we need to add some configuration to ignore node_modules/**/* and **/error.ts files from type checking.

Hmmm, I had trouble trying to repro the type failures on the CI run because my local tests can't get that far in the process due to import issues. I think the type failures on CI stem from the check-dts step.
That didn't fail before because skipLibCheck was included.
Because we only care about the outputs from the packages directory, I propose we change the check to check-dts 'packages/**/*'. What do you think?
Running that command locally emits only the type failures in packages/core/channel/errors.ts; similar to what is on CI. Those failures are related to the swapping the position of the [Parameters<ActionsType[A]>[0]] type (e0224d2e). I'm assuming that the behavior modeled in channel/errors.ts is correct and we should work from that.
I'll try to look into that change more this afternoon, but if you have any spare time on your end, I'd love a second set of eyes on fixing this declaration: https://github.com/anycable/anycable-client/blob/9512487dec3780dd1d5125537479b6e392010d3b/packages/core/channel/index.d.ts#L67

@palkan can I please trouble you to kick off another CI run?
Also, the last commit with introducing a secondary typescript config file may be a bit controversial. I wish the logic was inverted where check-dts could take in an explicit option to skip declaration files, and tsc could just rely on the default tsconfig.json file.

Thanks!
Upgrading @types/node fixed the problem with check-dts, so we don't need a separate config.


Assessment tool group can be given a controlled name

Once I have designated a new tool group, I can label the entire tool group (i.e. not individual columns) with a concept from a controlled vocabulary (e.g. reproschema), so that I can later search for this tool and find what samples have this tool available.

[ ] There is a (new) UI element that allows me to enter a URI to a controlled term that describes this tool (e.g. from reproschema).
[ ] this mapping persists even when columns are removed or added to the tool group, unless the tool group is completely deleted
[ ] once I click on "save annotation", the entered mapping is saved in the global store
[ ] when I navigate away and back to the tool group annotation tab after having "saved" my annotation mapping, I can still see the mapping

This is already implemented in the app. We can now use this issue to make sure have tests for this behavior

Closing because we'll fundamentally redesign the annotation tool workflow


301 pages are not followed

Even the option FollowRedirects is true I don't get the final response.
Here is my code, I steel get the 301 response code :
Dim Client As New WebClient
Dim Request As New WebRequest
Dim Response As New WebResponse

Client.BaseUrl = "https://myWebService"
Client.FollowRedirects = True

Set Response = Client.Execute(Request)

If (Response.StatusCode = Ok) Then
         ' I am happy
Else
     MsgBox "WebService " & Client.BaseUrl & " error Code : " & Response.StatusCode
End If`

Getting a similar issue, are you using Excel on Mac. My case is the response is actually valid though the response status code is 301. All content including the response header is in Response.Body and you can convert the body, which is a Byte array, to a string and use it. Don't have a way to solve it yet/


Please add support for my site dessine.net

I want support for my website :
://.dessine.net/*
Thank for that !

I added your website to the extension, it should be on the list as soon as it updates to 1.2.3.
Btw this is only for WinTab support on windows, most platforms and browsers are already correctly passing pressure data in pointer events pressure property, so make sure you implement support for that. https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/pressure


How to make Has Many Through relationship? like laravel documentation

How to make Has Many Through relationship?

Please use the issue template and follow it's instructions.


Some videos are playing only once using this API

With most recent update of Youtube, the YTPlayer API is no more able to play all the video's just some videos are just playing only once. The example sample is also having the same issue.
Kindly fix the update.

Resolved


TASK-4337 Dev: Implement Java code evaluator behind feature flag JAVA_EVAL

Meant for rapidly exploring the BetonQuest API (but there are still some classpath issues that need to be resolved), and to verify that the previous refactorings now allow any kind of context object (here: the JShell object). Introduces the ability to use (ReLoAd-style) feature flags in JuicyRaspberryPie.
For showcasing the ability to invoke arbitrary JuicyRaspberryPie commands (via mc.conn.sendReceive()) and maybe rapid development of new functionality.
,----[ mcpi ]----
| In [2]: mc.conn.sendReceive(b"eval", "System.currentTimeMillis();")
| Out[2]: 'Successful addition of System.currentTimeMillis();:<PHONE_NUMBER>010'
`----
Note: The server needs to run with a full JDK; the JRE won't do. The registration uses Java reflection to handle this gracefully. Also, due to the security implications this is behind a feature flag that should only be enabled in development environments.
The JShell code is based on the REPL at https://docs.oracle.com/javase/9/docs/api/jdk/jshell/package-summary.html

Note: This is a follow-up on #33

[X] The main commit(s) reference the Fibery ticket via a TASK-NNNN prefix in the commit message subject
[X] Include a human-readable description of what the pull request is trying to accomplish
[X] The CI build passes

[ ] New automated tests have been added
[ ] The changes are already covered by automated tests and have been adapted
[ ] These manual test cases cover this change:
[X] Steps for the reviewer(s) on how they can manually QA the changes:

[X] Invoke the eval command with a simple Java expression

[ ] This is a minor internal change; basic CI/CD coverage is enough
[X] This is a dev feature hidden behind feature flag JAVA_EVAL
[ ] This is proof-of-concept / experimental code not for production / marked @Deprecated
[X] No (significant) changes to production code

[X] Classes and public methods have documentation (that doesn't just repeat the technical subject in English)
[X] Logging is implemented to monitor feature usage and troubleshoot problems in production
[ ] These ReWiki pages are affected by this change and will be adapted:

[ ] The change is unrelated to Minecraft
[X] Works in Java edition
[ ] Works in Bedrock edition

Closing because the desired access to plugins (like BetonQuest) for quick exploration is a hairy mess, because the actual plugin instances from the server need to be injected into the JShell REPL.
Allowing plugin imports can be done by copying the respective classloaders (though the mcpi client somehow would have to specify which plugins they'd like to use).
But as the classloading still would happen through a special JShell classloader, the instances would be different from the ones on the server. Instead, the actual plugin instances would have to be injected into the JShell REPL.
That should be possible:

https://stackoverflow.com/questions/54952810/jshell-access-to-variables-defined-outside-of-jshell-instance
https://stackoverflow.com/questions/48896013/sharing-dynamically-loaded-classes-with-jshell-instance

But it requires copying huge amounts of JRE code, and even that didn't work for me; I only saw classloading attempts of the JShell REPL variable stubs, but not of the actual plugin instances. Maybe it has something to do with this JDK bug.


IsTextureConsistent: IMGEGLImage is not consistent

I'm trying to start a call, but it doesn't go any further. Here are the logs

This seems like it is related to flutter_webrtc which this package uses as the dependency for managing webrtc stack details, maybe you can try to update the dependency of flutter_webrtc in pubspec.yaml file and let me know if it works for you


chore: release main

:robot: I have created a release beep boop
autonat: 2.0.10
2.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/logger bumped from ^5.1.2 to ^5.1.3

bootstrap: 11.0.10
11.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3

circuit-relay-v2: 3.1.0
3.1.0 (2024-10-28)
Features

add reprovide (#2785) (52b3b1a)

Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10
@libp2p/peer-collections bumped from ^6.0.9 to ^6.0.10
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/peer-record bumped from ^8.0.9 to ^8.0.10
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3

crypto: 5.0.6
5.0.6 (2024-10-28)
Bug Fixes

use raw asn1js int value to improve performance (#2788) (c4399dc)

Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0

dcutr: 2.0.10
2.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devtools-metrics: 1.1.8
1.1.8 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10
@libp2p/logger bumped from ^5.1.2 to ^5.1.3
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/simple-metrics bumped from ^1.2.5 to ^1.2.6

devDependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6

echo: 2.1.1
2.1.1 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10

devDependencies

@libp2p/logger bumped from ^5.1.2 to ^5.1.3

fetch: 2.0.10
2.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10

devDependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/logger bumped from ^5.1.2 to ^5.1.3
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7

floodsub: 10.1.8
10.1.8 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/pubsub bumped from ^10.0.9 to ^10.0.10

devDependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3
@libp2p/peer-collections bumped from ^6.0.9 to ^6.0.10
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7

identify: 3.0.10
3.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/peer-record bumped from ^8.0.9 to ^8.0.10
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3

interface: 2.2.0
2.2.0 (2024-10-28)
Features

add reprovide (#2785) (52b3b1a)

interface-compliance-tests: 6.1.8
6.1.8 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10
@libp2p/logger bumped from ^5.1.2 to ^5.1.3
@libp2p/multistream-select bumped from ^6.0.7 to ^6.0.8
@libp2p/peer-collections bumped from ^6.0.9 to ^6.0.10
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

interface-internal: 2.0.10
2.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/peer-collections bumped from ^6.0.9 to ^6.0.10

kad-dht: 14.1.0
14.1.0 (2024-10-28)
Features

add reprovide (#2785) (52b3b1a)

Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10
@libp2p/peer-collections bumped from ^6.0.9 to ^6.0.10
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3
@libp2p/peer-store bumped from ^11.0.9 to ^11.0.10

keychain: 5.0.9
5.0.9 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0

devDependencies

@libp2p/logger bumped from ^5.1.2 to ^5.1.3

logger: 5.1.3
5.1.3 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0

devDependencies

@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7

mdns: 11.0.10
11.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3

mplex: 11.0.10
11.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3

multistream-select: 6.0.8
6.0.8 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0

devDependencies

@libp2p/logger bumped from ^5.1.2 to ^5.1.3

peer-collections: 6.0.10
6.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6

peer-id: 5.0.7
5.0.7 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0

peer-record: 8.0.10
8.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

peer-store: 11.0.10
11.0.10 (2024-10-28)
Bug Fixes

remove peer cache (#2786) (7383821)

Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/peer-record bumped from ^8.0.9 to ^8.0.10

devDependencies

@libp2p/logger bumped from ^5.1.2 to ^5.1.3

perf: 4.0.10
4.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3

ping: 2.0.10
2.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10

devDependencies

@libp2p/logger bumped from ^5.1.2 to ^5.1.3
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7

plaintext: 2.0.10
2.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7

devDependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3

pnet: 2.0.10
2.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7

prometheus-metrics: 4.2.4
4.2.4 (2024-10-28)
Bug Fixes

fix metric group timers (#2789) (a4b2db1)

Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0

devDependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7

pubsub: 10.0.10
10.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10
@libp2p/peer-collections bumped from ^6.0.9 to ^6.0.10
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/logger bumped from ^5.1.2 to ^5.1.3

simple-metrics: 1.2.6
1.2.6 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/logger bumped from ^5.1.2 to ^5.1.3

tcp: 10.0.11
10.0.11 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3

tls: 2.0.10
2.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3

upnp-nat: 2.0.10
2.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/logger bumped from ^5.1.2 to ^5.1.3
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7

utils: 6.1.3
6.1.3 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/logger bumped from ^5.1.2 to ^5.1.3

devDependencies

@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7

webrtc: 5.0.15
5.0.15 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/circuit-relay-v2 bumped from ^3.0.0 to ^3.1.0
@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/identify bumped from ^3.0.9 to ^3.0.10
@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3
@libp2p/websockets bumped from ^9.0.9 to ^9.0.10
libp2p bumped from ^2.1.10 to ^2.2.0

websockets: 9.0.10
9.0.10 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/logger bumped from ^5.1.2 to ^5.1.3

webtransport: 5.0.15
5.0.15 (2024-10-28)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/logger bumped from ^5.1.2 to ^5.1.3
@libp2p/ping bumped from ^2.0.9 to ^2.0.10
libp2p bumped from ^2.1.10 to ^2.2.0

libp2p: 2.2.0
2.2.0 (2024-10-28)
Features

add reprovide (#2785) (52b3b1a)

Bug Fixes

only update pending incoming connections if connection accepted (#2790) (d34642d)

Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/crypto bumped from ^5.0.5 to ^5.0.6
@libp2p/interface bumped from ^2.1.3 to ^2.2.0
@libp2p/interface-internal bumped from ^2.0.9 to ^2.0.10
@libp2p/logger bumped from ^5.1.2 to ^5.1.3
@libp2p/multistream-select bumped from ^6.0.7 to ^6.0.8
@libp2p/peer-collections bumped from ^6.0.9 to ^6.0.10
@libp2p/peer-id bumped from ^5.0.6 to ^5.0.7
@libp2p/peer-store bumped from ^11.0.9 to ^11.0.10
@libp2p/utils bumped from ^6.1.2 to ^6.1.3

devDependencies

@libp2p/circuit-relay-v2 bumped from ^3.0.0 to ^3.1.0
@libp2p/identify bumped from ^3.0.9 to ^3.0.10
@libp2p/interface-compliance-tests bumped from ^6.1.7 to ^6.1.8
@libp2p/mplex bumped from ^11.0.9 to ^11.0.10
@libp2p/plaintext bumped from ^2.0.9 to ^2.0.10
@libp2p/tcp bumped from ^10.0.10 to ^10.0.11
@libp2p/websockets bumped from ^9.0.9 to ^9.0.10

This PR was generated with Release Please. See documentation.

:robot: Created releases:

plaintext-v2.0.10
tls-v2.0.10
crypto-v5.0.6
interface-v2.2.0
interface-compliance-tests-v6.1.8
interface-internal-v2.0.10
kad-dht-v14.1.0
keychain-v5.0.9
libp2p-v2.2.0
logger-v5.1.3
devtools-metrics-v1.1.8
prometheus-metrics-v4.2.4
simple-metrics-v1.2.6
multistream-select-v6.0.8
peer-collections-v6.0.10
bootstrap-v11.0.10
mdns-v11.0.10
peer-id-v5.0.7
peer-record-v8.0.10
peer-store-v11.0.10
pnet-v2.0.10
autonat-v2.0.10
dcutr-v2.0.10
echo-v2.1.1
fetch-v2.0.10
identify-v3.0.10
perf-v4.0.10
ping-v2.0.10
pubsub-v10.0.10
floodsub-v10.1.8
mplex-v11.0.10
circuit-relay-v2-v3.1.0
tcp-v10.0.11
webrtc-v5.0.15
websockets-v9.0.10
webtransport-v5.0.15
upnp-nat-v2.0.10
utils-v6.1.3
:sunflower:


Have tab to use OSM nominatim

Suggestion for OHM: ability to use nominatim from OSM.
When you search, have it search on OHM's nominatim first. Then have a button or something below it that allows you to search for "Present day" and that searches trough osm.
So in that situation, it would make it easy to just search for "show me where 'modern day ... ' is"

This is a good idea, but has been open for a while, due to other tickets being higher priority. (over and over)
The short-term workaround is that if something doesn't show up in the OHM search results, a user should map the feature in OHM so that it does.
Alternatively, users can find stuff visually using the OSM layer or by copying the #map=z/y/x portion of the OSM URL into the OHM URL headers.
Closing in light of these workarounds and relative priority.


Size of the box!

I have chosen a planar rectangle as one of the 7 configurations, how would we expect to assign the values of a and b (a=length and b=width)? Are we allowed to choose randomly? Because there are no specific values for these terms in the paper?
I will appreciated your responses.

I am going through the same issues. How to chose the position of ions?

I think we can choose any size of the box, as your wish.

@poojashresthacode how come we implement it for different configuration then?

@poojashresthacode @pratibha77118
Guys, I got to know that choosing any appropriate values of a and b, randomly, will not affect the potential energy value. The difference is only that the optimization algorithm will requires more number of steps to minimize the system with the large box size.


Fix iOS header import

Since react native version 0.40.0, iOS import headers change to <React/HeaderName.h>.
More info: https://github.com/facebook/react-native/releases/tag/v0.40.0

Could someone please approve this commit?

Please approve

Please Approve this.

It looks like the repo owners are no longer active

Hey guys, since the repo owners are no more active I suggest that @lucianomlima publishes his fork on npm so we can start to use it and we all can start contributing to his branch pending when the owners are back to merge.
What says you all ?? cc: @pmagnussen @ergunyasar @ronunism

I also strongly suggest checking out a project we've been working on for a few months now to create a music player for React Native: https://github.com/react-native-kit/react-native-track-player

I'll test React Native Track Player this weekend, @jasongrishkoff

It works for me

You can use git url version to add from my repo.

Thanks, @lucianomlima .  I am doing so.

@victor36max


Tagged helm chart values in values.yaml don't match image tag

Description
** READ BEFORE CONTINUING: If your issue is not specific to AWS, please cut a ticket in kubernetes-sigs/karpenter.
Observed Behavior:
Currently, our CD rollout for new karpenter-provider-aws images is triggered based off a git tag being pushed to the upstream repo. This push to the upstream repo results in the following operations happening:

Github Release is created
Images and Charts are packaged and pushed to the public ECR
Website changes are generated and PR is created with the changes

The order of this release process means that the changes to the repo are merged after the repo has already been tagged. What this means, is that the chart that is stored in the repo that is tagged v0.32.1 is different than the pushed chart that ends up in the OCI artifact store in our public ECR.
In general, this shouldn't happen. The tag should be our source-of-truth, implying that whatever we tag in the repository has the same representation for the chart and the image with the same tag in the ECR. This is currently true for the image, but is not true for the chart.
I'd like to see us re-work the release process so that what we tag is also what we push. Practically, this means that we need changes to the chart to be created and merged-in first before the actual tag creation happens.

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Hello!
This is problematic because currently, listing tags in OCI registries is not supported by helm (https://github.com/helm/helm/issues/11000). What is the reference list of tags for the helm chart now that index.html is unmaintained?

Definitely something that would be good to get fixed. Can't upgrade from 0.32+ to 0.33+ :/

I think this is related to https://github.com/aws/karpenter-provider-aws/issues/4248.

kill me why  its so hard to understand your repo !! branch "release-v0.35.4" it not same as tag v0.35.4
argocd cant download helm as missing index or index not config ,
helm pull --version release-v0.35.4 --repo https://github.com/aws/karpenter charts/karpenter 404 Not Found
helm pull --version v0.34.3 --repo https://github.com/aws/karpenter charts/karpenter 404 Not Found
Error: looks like "https://github.com/aws/karpenter" is not a valid chart repository or cannot be reached: failed to fetch https://github.com/aws/karpenter/index.yaml : 404 Not Found
helm not support OCI  and you push to OCI do you want us to work with karpenter ?
Thansk

Has there been any update on this? Its making it very challenging to upgrade to the newer versions due to this mismatch.

@noamgreen Karpenter is only published via OCI.
@edas-smith the Karpenter Helm chart now uses a correct SemVer.
helm pull oci://public.ecr.aws/karpenter/karpenter --version 0.36.0

As I mentioned in my duplicate ticket, I was able to work around this issue by pointing to branch release-v0.36.2 rather than the tag v0.36.2

@paul-civitas I think there might be some confusion between the Git tag (idiomatically the version with a v prefix) and the OCI tags for the image and Helm chart?
Git tags can't start with a number, thus the idiom of prefixing with a v, while the OCI tag for a Helm chart should be a SemVer version, which can't start with a v. As an OCI image tag is completely open you'll see it take both SemVer and v prefixed forms.
In the case of the Karpenter project all of the OCI tags are SemVer, for consistency, so if you have the Git tag you just need to remove the v prefix.

@stevehipwell well the fundamental issue is that the OCI tag for the helm chart, that the version with the critical fix is not in existence.
Or at least it was not at the time.

@paul-civitas the OCI tags (0.36.2) were created as part of the GH release 20 days ago (see registries for karpenter/controller & karpenter/karpenter).
You can check that they're valid with the following commands. Please note the lack of a v prefix on the tag (as explained in my comment above).
docker pull public.ecr.aws/karpenter/controller:0.36.2
helm pull oci://public.ecr.aws/karpenter/karpenter --version 0.36.2

@stevehipwell sorry I misspoke. The issue is that there was not a git tag that corresponded to this OCI tag.

Here's a simple question, that might show what the problem is.
Question: What git tag to I point argoCD to, such that I'm using a version of the helm chart, that is pointing to OCI tag 0.36.2 of the OCI image?

Here's a simple question, that might show what the problem is.
Question: What git tag to I point argoCD to, such that I'm using a version of the helm chart, that is pointing to OCI tag 0.36.2 of the OCI image in values.yaml?

Following up on this.
Git tag v0.36.2 is the wrong answer, as you can see here: https://github.com/aws/karpenter-provider-aws/blob/v0.36.2/charts/karpenter/values.yaml#L102 it points to OCI tag 0.35.4 which is an older version than the one I desire.
Git tag v0.37.0 (the most recent tag) is the wrong answer, as you can see here: https://github.com/aws/karpenter-provider-aws/blob/v0.37.0/charts/karpenter/values.yaml#L104 that it points to OCI tag 0.36.0 which is an older version than the version that I desire.
So what is the right answer?

@paul-civitas the Git tag just isn't relevant here (it'll be tracking the previous version of the Helm chart as it triggers the release process).
I'm not an Argo CD expert but it sounds like you've not configured it correctly for OCI if you're trying to use a Git tag. Could you share your config?

the Git tag just isn't relevant here

The git tag is what this issue is about. The git tag tracking the previous version of the helm chart, rather than the version corresponding to the tag, is unusual behavior that is throwing us off, and contrary to how other open source projects work That is why issues are being created.

I'm not an Argo CD expert but it sounds like you've not configured it correctly

It's pretty straightforward. You point ArgoCD to a git reference and it deploys the helm chart from git. My expectation was that by pointing ArgoCD to the git reference v0.36.2 it would deploy version 0.36.2 of the code. However it actually deployed version 0.35.4 which was contrary to exceptions.
I was able to resolve this issue by pointing ArgoCD to git reference release-v0.36.2 which does deploy version 0.36.2 of the code.

the Git tag just isn't relevant here

The git tag is what this issue is about. The git tag tracking the previous version of the helm chart, rather than the version corresponding to the tag, is unusual behavior that is throwing us off, and contrary to how other open source projects work That is why issues are being created.

@paul-civitas the Git tag triggers the Helm chart OCI release which will result in an additional commit to save the current state of the chart after the release; having the chart content be part of the release tag commit isn't expected behaviour (this is idiomatic where the chart and binary share a repo due to a chicken/egg problem). Furthermore the Helm chart releases are only provided via the OCI registry (as documented); the HTTP Helm registry was deprecated (I think in the `0.17.0 release), and any behaviour linking a Helm release to a Git release tag was incidental implementation detail (likely due to non-automated releases being cut on a developer's machine).

It's pretty straightforward. You point ArgoCD to a git reference and it deploys the helm chart from git. My expectation was that by pointing ArgoCD to the git reference v0.36.2 it would deploy version 0.36.2 of the code. However it actually deployed version 0.35.4 which was contrary to exceptions.

I'm going to have to say that it isn't that simple, as you're using it incorrectly in this case. The two documented Helm targets are HTTP registry (first example) and OCI (second example). You can use a Git reference as you're attempting to do, but it's only going to work correctly where supported (and it isn't supported for Karpenter).

I was able to resolve this issue by pointing ArgoCD to git reference release-v0.36.2 which does deploy version 0.36.2 of the code.

That might work but it's an implementation detail which could be changed at an point, please configure Argo CD to use the Karpenter OCI registry.

Please configure Argo CD to use the Karpenter OCI registry.

I know Amazon is trying to grow adoption of their OCI registry, but it currently has serious usability challenges.
This would be a practical suggestion if you were to instead move to a more stable and widely used public OCI registry.

I know Amazon is trying to grow adoption of their OCI registry, but it currently has serious usability challenges.
This would be a practical suggestion if you were to instead move to a more stable and widely used public OCI registry.

@paul-civitas could you expand on this? I'm not aware of any current issues with ECR public (ECR private has issues with figuring out the correct regional AWS account but this is more UX than anything else and not what Karpenter uses). Based on the number of EKS Kubernetes clusters in use (I remember a number like 70% passed around a couple of years ago) I'd say that ECR is probably one of most widely used public OCI registries.
FYI I don't work for Amazon.

@paul-civitas you don't need any auth for public ECR, the Karpenter docs (the ones I linked above) make this clear. FYI the issue link above is for private ECR registries (with the <ACCOUNT_ID>.dkr.ecr.<REGION>.amazonaws.com pattern) which AWS use for some of their OSS components but not Karpenter.

Ok thanks. Public ECR was only launched in 2020 so some of my experience is probably out of date. I'll give using the registry another shot.

Just ended up here after some good amount of debugging....
I can confirm that having tags 0.x.x and release-0.x.x NOT pointing to the same thing in the end is 💩
Very technically speaking yea, you might have a point but reality wise this is hard to understand


doom-one-light: use correct symbol name

fix Symbol’s value as variable is void: doom-modeline-brighter-modeline

Good catch. Thanks!


gegl_0_4: add patch for test timeouts

Commit message
This has failed at the checkPhase many times
on hydra due to a timeout in a particular testcase.
I'm unable to identify which testcase it is within the
source from the output, but I usually place winning
bets on debian patches.

Motivation for this change
Too many occasions has the gnome3 tests failed because of gegl job timing out on a test.
https://hydra.nixos.org/build/108422657
https://hydra.nixos.org/build/108162813
https://hydra.nixos.org/build/108162815
https://hydra.nixos.org/build/108095634
Other times it's checking for references to /build/ in /nix/store/k4gy2675j79g72hlj5ch2sjgxjh23abc-gegl-0.4.18-devdoc... which is annoying enough for me to notice at this point.
I'm not sure it fixes anything in NixOS, so please be critical.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

And there was a timeout again: https://hydra.nixos.org/build/108819624/nixlog/2  Let's try this.

I don't think this fixed it.

Indeed, the patch only changes the timeout for the ff-load-save test, which we don't even run?!  Our gegl builds always fail in the simple / backend-file test.


Is there an Always Encrypted KeyStoreProvider that works with both SSMS and a Java app running on a Unix box?

Question
Based on the what I understand from the article below, there are 3 out of the box keystore providers.

Java Keystore: SSMS cannot encrypt/decrypt the data.
Windows Certificate KeyStore provider: SSMS can decrypt the data but Java apps running on non-windows platform won't be able to encrypt/decrypt the data.
Azure Keystore provider: works with both SSMS and Java (but we cannot use Azure)

Is there a way to store the keys, besides Azure, in such a way that both SSMS and Java on Unix boxes can decrypt the data?
Relevant Issues and Pull Requests
Ref: https://docs.microsoft.com/en-us/sql/connect/jdbc/using-always-encrypted-with-the-jdbc-driver?view=sql-server-ver15#using-windows-certificate-store-provider

Hi @phaninra, is it not possible to just follow the instructions under "Using Java Key Store provider". After creating the JKS, the user needs to create a CMK inside the JKS, and then create a CEK from that CMK. Does the CMK created not show up in SSMS wizards?

thanks for the repsonse @rene-ye . These instructions helped to perform the following operations successfully

Generate CMK/CEKs from a Java app and insert CEKs into a sql server db.
CRUD operations on encrypted columns from a Java app.

However, from what I understand, with this approach the manual queries executed through SSMS won't be able to see the plain text data. I've not found any references suggesting otherwise. Did I miss something?

Hi @phaninra, you should be able to export certificates from ssms in pfx format. These certificates can then be added to the JKS. The reverse should be true as well, you can export certificates from a JKS to pfx format and then use whatever openssl commands to convert the pfx to a readable format by SSMS (I believe it's cer). You should then be able to use T-SQL to import the certificate into SSMS where it can use it. The question here is: what is the linux SQL Server equivalent of the windows key store, and where do users place certificates so SSMS can find them.

Thanks, I will try that.

I've tried below approaches

Let SSMS generate a certificate for CMK and import that into JKS
Inverse, i.e generate a key through command line and import that the SQL Server using SSMS

In both scenarios, sys.column_master_keys.key_store_provider_name was MSSQL_CERTIFICATE_STORE for the corresponding keys.
I ran into following issue when I tried to perform CRUD operations from a Java app, because the jdbc-driver code picked up MSSQL_CERTIFICATE_STORE  for decryption purposes.
java.lang.UnsatisfiedLinkError: com.microsoft.sqlserver.jdbc.AuthenticationJNI.DecryptColumnEncryptionKey(Ljava/lang/String;Ljava/lang/String;[B)[B
	at com.microsoft.sqlserver.jdbc.AuthenticationJNI.DecryptColumnEncryptionKey(Native Method)
	at com.microsoft.sqlserver.jdbc.SQLServerColumnEncryptionCertificateStoreProvider.decryptColumnEncryptionKeyWindows(SQLServerColumnEncryptionCertificateStoreProvider.java:61)
	at com.microsoft.sqlserver.jdbc.SQLServerColumnEncryptionCertificateStoreProvider.decryptColumnEncryptionKey(SQLServerColumnEncryptionCertificateStoreProvider.java:75)
	at com.microsoft.sqlserver.jdbc.SQLServerSymmetricKeyCache.getKey(SQLServerSymmetricKeyCache.java:157)
	at com.microsoft.sqlserver.jdbc.SQLServerSecurityUtility.decryptSymmetricKey(SQLServerSecurityUtility.java:136)
	at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.getParameterEncryptionMetadata(SQLServerPreparedStatement.java:942)
	at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.doExecutePreparedStatement(SQLServerPreparedStatement.java:564)
	at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement$PrepStmtExecCmd.doExecute(SQLServerPreparedStatement.java:524)
	at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:7194)
	at com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:2979)
	at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeCommand(SQLServerStatement.java:248)
	at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeStatement(SQLServerStatement.java:223)
	at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.executeUpdate(SQLServerPreparedStatement.java:473)
	at com.zaxxer.hikari.pool.ProxyPreparedStatement.executeUpdate(ProxyPreparedStatement.java:61)
	at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.executeUpdate(HikariProxyPreparedStatement.java)
	at org.hibernate.engine.jdbc.internal.ResultSetReturnImpl.executeUpdate(ResultSetReturnImpl.java:197)
	at org.hibernate.dialect.identity.GetGeneratedKeysDelegate.executeAndExtract(GetGeneratedKeysDelegate.java:57)

Is the error related to the below comments found at this document.
While the other keystore providers in this article are available on all platforms supported by the driver, the SQLServerColumnEncryptionCertificateStoreProvider implementation of the JDBC driver is available on Windows operating systems only.

That link error means the driver can't find the DLL, which is windows exclusive.

Yep, currently the Java app is running on a Windows box. Did you mean it'd work fine on a Unix box?

@phaninra , you need include the corresponding mssql-jdbc_auth-<version>-<arch>.dll in the classpath. For example, JDBC 8.2.2 requires mssql-jdbc_auth-8.2.2-x64.dll which can be found on Maven.

@ulvii  thanks for the response. The .dll maybe the missing piece to make it work but will this approach of using MSSQL_CERTIFICATE_STORE  work in a Java app running on a Unix box?

@phaninra , MSSQL_CERTIFICATE_STORE  is for Windows only.
You should try Rene's suggestion on this comment, JAVA Key Store seems to be the only option.

@ulvii (I believe there's some confusion)
I did try those steps from Rene and this  was my follow up question.
Rephrasing my main question to avoid ambiguity if any -
Our setup : SQL Server running on a Windows box, SSMS, and Java-app-running-on-a-unix box.
Based on my findings on keystore providers so far,

MSSQL_CERTIFICATE_STORE means only SSMS can encrypt/decrypt data. Java app running on a unix box won't be able to encrypt/decrypt data.
MSSQL_JAVA_KEYSTORE means SSMS won't be able to encrypt/decrypt data.

Is that right?
I'm hoping to find a solution where the ecnryption/decryption works seamlessly with both SSMS and Java-app-running-on-a-unix box.

How are you running SSMS on Unix? From what I know SSMS is Windows only.

@ulvii It's the Java client that's running on a Unix box, not SSMS.

Hi guys, just wondering if there's anything else I should try out? This post has my latest findngs.

Hi @phaninra, we're just trying to get this scenario set-up in our test lab. Initial investigations confirms what you've described. When encrypting a column, the server stores the type of keystore used. If using SSMS, this value is MSSQL_CERTIFICATE_STORE. When the driver attempts to decrypt a column, the server sends this keystore name to the driver. Therefore, even if a Java keystore is loaded into the driver which contains the correct keys, the driver won't attempt to do a lookup since the JKS's name doesn't match MSSQL_CERTIFICATE_STORE.

Hi @phaninra, just an update to the thread. I wasn't able to find a workaround, which means the above scenario described is currently not possible.

Thanks @rene-ye @ulvii . I'm exploring the sourcecode for potential solutions and could you keep the thread open for a few more days.

Hi @phaninra, sure, we can keep the thread open.

Based on my team's exploration so far, there may be 2 solutions. None of them is ideal but posting them for future readers.
Solution 1

Use MSSQL_JAVA_KEYSTORE i.e. generate a key on command line and push that to sql server
This will work with Java clients on on all platforms.
Use a jdbc driver based GUI client like DBVisualizer for manual querying on encrypted data. Make sure to include AE connections parameters in jdbc url. You can still use SSMS for other stuff like DBA, reading/writing non-encrypted data.

Solution 2

Use MSSQL_CERTIFICATE_STORE and import the cmk Windows certificate into a JKS. Use the value from sys.column_master_keys.key_path as the key alias while inserting into a JKS.
Write a custom SQLServerColumnEncryptionKeyStoreProvider implementation that finds the correct key in a given JKS. Note that the masterKeyPath supplied to com.microsoft.sqlserver.jdbc.SQLServerColumnEncryptionKeyStoreProvider.decryptColumnEncryptionKey(..)  at runtime is the sys.column_master_keys.key_path.
Ugly part: Use reflection to do this - SQLServerConnection.globalSystemColumnEncryptionKeyStoreProviders.put("MSSQL_CERTIFICATE_STORE", customProvider).  We need to override the default provider to keep things compatible with both SSMS and mssql-jdbc driver, especially when the latter is running on unix.

@rene-ye @ulvii   hoping for your inputs on Solution 2. I realize that updating globalSystemColumnEncryptionKeyStoreProviders  is not part of the official API. But given what's not working currently, I hope you are open to make things flexible so that no ugly reflection code needs to run in order to override the provider for MSSQL_CERTIFICATE_STORE on the mssql-jdbc client side.

Hi @phaninra, our recommendation for users with unique cross-platform needs is to use Azure Key Vault. If that can't be used then it's up to the customers to write their own provider as your team has done. Regarding the need for reflection, I don't think the driver will be able to directly support "redirecting" the key store name lookup as it seems to act as a security feature.

Closing the issue, please feel free to re-open it if you have any other questions.


Extra header in schematic?

Thank you for the amazing work here! This is exactly what I need for a project I'm working on.
I'm fairly new to reading schematics, and I'm getting tripped up as I read the example here: https://github.com/hpwit/I2SClocklessVirtualLedDriver/blob/main/extra/Schematic_4pins-virtual-8-1-20191115225252.png
I can see 3 headers to the left (H1, H2, H3). H2 and H3 look the same and both provide "Clock" and "Latch". There's only one 7HC245 in the diagram, so it seems like one of these headers might be extra (i.e. if there were instead two 7HC245s). Of course more than likely I'm reading this wrong :)
Once again, thank you for this amazing library. 🙏

Hello thank you for your comment !
I had two header incase if you wanted to daisy chain the board.
How many strips do you need ?
Can you tell me more about your project ?
I have other drawings.

Ah! That makes sense. I appreciate the help.
I'm building an LED board made of many panels. Pretty much a scaled down version of the LED panel I saw in one of your posts.
Until now, I have been daisy chaining the panels together, at the cost of very low FPS. I've learned a ton from reading this lib and the various posts that led me to it. I've been able to successfully get a demo working with nothing but a shift register at massive FPS (I ordered some level shifters too, based on what I read about it's affect on signal timing, but haven't needed to use one yet).
Many thanks!

It's 5 44x11 WS12x strips, btw.
My goal is to use a single data GPIO for simplified wiring. So far it has been working (I'm setting NBIS2SERIALPINS to 1, so not using this lib as intended, but leaning on the timing for the shift register that it provides)


Replace browsergym with browsergym-core to reduce dependencies

This PR replaces the dependency on browsergym with browsergym-core to reduce unneeded dependencies. The full browsergym package includes many additional dependencies that are not needed for our use case.
Changes:

Changed dependency from browsergym to browsergym-core in pyproject.toml
Updated poetry.lock to remove unneeded dependencies

All tests pass successfully, confirming that the core browsergym functionality works as expected.

To run this PR locally, use the following command:
docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:264b84e-nikolaik   --name openhands-app-264b84e   docker.all-hands.dev/all-hands-ai/openhands:264b84e

New OpenHands update

@neubig Sorry, we can continue to fix it here, but just for discussion, have you seen this?

https://github.com/All-Hands-AI/OpenHands/pull/5242

It's in the stage "thinking about" 😅 because:

the envs can be part of the 'evaluation' poetry group, which is not normally run in CI

CI is or should be run with poetry install --without evaluation,llama-index

but there's a browsing test with miniwob that will fail as long as they're not installed
which I had some trouble disabling in a way that remains very visible (= not prone to be forgotten)

because, for example, Xingyao recently needed it, and used it, in the latest browser action PR
https://github.com/All-Hands-AI/OpenHands/pull/5285
I mean, totally removing or commenting it out seems the wrong thing to do

this isn't a new problem, we have it already with llama-index, same thing, disabled in normal CI, should not be forgotten, needs a place to run and us keeping an eye on

So my current theory about how to fix this, is to move both the llama-index and evaluation groups tests to some other pipeline like we now have the integration tests one:

https://github.com/All-Hands-AI/OpenHands/issues/5318#issuecomment-2509428447
maybe even the same, or a new category like it?

Hey @enyst , I indeed had not seen that. Apologies! I'll look through carefully when I have a moment.

Closing in favor of #5242


bug(node): Row ids did not arrive in sorted order

LanceDB version
0.5.2 @lancedb/lancedb
What happened?
Error: lance error: LanceError(IO): Execution error: Row ids did not arrive in sorted order: integers are ordered up to the 0th element, /home/build_user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lance-datafusion-0.12.1/src/chunker.rs:47:46

Filter

Are there known steps to reproduce?
export async function append(tableName: string, data: lancedb.Data) {
  const db = await getConnection();
  const table = await getTable(db, tableName);
  await table.add(data);
  return table;
}

This seems to be a duplicate of #946.
Are you able to reproduce this in a newer version of LanceDB? This should have been fixed many months ago in https://github.com/lancedb/lance/issues/1926. You might need to rewrite the table with a newer version of LanceDB to fix it. You can run a migration in place on a table by running table.delete("false").
Out of curiosity, is there a reason you are using such an old version of the library?

Out of curiosity, is there a reason you are using such an old version of the library?

When I did the POC, the latest version was 0.5.2, and it has not changed since then. I upgraded to 0.8.0 yesterday

You might need to rewrite the table with a newer version of LanceDB to fix it. You can run a migration in place on a table by running table.delete("false").

Thank you very much for your reply. I am curious why initiating a delete operation will make the query result correct.

0.8.0 should fix this issue

rror: lance error: LanceError(IO): Execution error: Row ids did not arrive in sorted order: integers are ordered up to the 0th element, /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lance-datafusion-0.15.0/src/chunker.rs:47:46

0.8.0 version still has this issue, when compaction and insert happen simultaneously.

I am curious why initiating a delete operation will make the query result correct.

There's not thing special about the delete operation. Any write operation with the new version would trigger a fix to the manifest. delete("false") is just a way of forcing a write transaction that doesn't change any data.

rror: lance error: LanceError(IO): Execution error: Row ids did not arrive in sorted order: integers are ordered up to the 0th element, /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lance-datafusion-0.15.0/src/chunker.rs:47:46

0.8.0 version still has this issue, when compaction and insert happen simultaneously.

Hmm that's odd. That's what this test is supposed to get at:
https://github.com/lancedb/lance/blob/b9990d935b0c68ca7149ed8efe45d2f4ee3d9249/python/python/tests/test_optimize.py#L52-L89
I'm not able to reproduce this issue right now though. We can compact and insert in our tests just fine right now. I'll try once more to create a more exact reproduction. If you are able to create a reproducible example, that would help a lot here.

Here's a script where I've tried to reproduce an error when compacting and appending at the same time. I'm not able to get any error. Do you want to try to modify it to be closer to your situation and perhaps that will trigger the error?
import threading
import asyncio

import lancedb
import pyarrow as pa
import pyarrow.compute as pc

NUM_ROWS = 10_000
DIMS = 128

db = lancedb.connect("./test")
values = pc.random(NUM_ROWS * DIMS).cast("float32")
vectors = pa.FixedSizeListArray.from_arrays(values, DIMS)
data = pa.table({"id": range(NUM_ROWS), "vector": vectors})
table = db.create_table("test_table", data, mode="overwrite")

table.create_scalar_index("id")
table.create_index(num_sub_vectors=32)

for _ in range(10):
    table.add(data)

async def get_async_table():
    db_async = await lancedb.connect_async("./test")
    table_async = await db_async.open_table("test_table")
    return table_async

table_async = asyncio.run(get_async_table())

# One thread for compactions
def do_compaction():
    asyncio.run(table_async.optimize())

# One thread to append more data
def do_append():
    for _ in range(10):
        table.add(data)

compaction_thread = threading.Thread(target=do_compaction)
append_thread = threading.Thread(target=do_append)
compaction_thread.start()
append_thread.start()
compaction_thread.join()
append_thread.join()

assert table.count_rows() == NUM_ROWS * (10 * 2 + 1)

OK, I will try my best to give you a stable and reproducible case today.

@wjones127 Hi，
Hello, I spent a day today trying to reproduce the problem. However, I did not reproduce the problem, but I found two other serious problems.
Today I found that it seems difficult to find problems if the test is based on local files. I guess it is because the local operations are very fast, only tens of milliseconds. However, testing based on S3 will expose many problems.
I created two new issues:
https://github.com/lancedb/lancedb/issues/1525
https://github.com/lancedb/lancedb/issues/1526
I have made my smallest reproducible code and data public, I hope it will be helpful to you.
https://github.com/memfreeme/vector-test/tree/main
There are two other questions that I would like to confirm with you:

Is it true that compact and compact operations themselves cannot be concurrent?

In TS, can the object returned by append directly call optimize or other methods?

Like the following:
export async function ingest_jsonl(url: string, userId: string) {
  const data = await readFromJsonlFile(url);
  const table = await append(userId, data);
  if (Math.random() < 1 / 10) {
    await table.optimize({ cleanupOlderThan: new Date() });
    console.log(`${userId} table optimized`);
  } else {
    console.log(`${userId} table not optimized this time`);
  }
}

Is it true that compact and compact operations themselves cannot be concurrent?

Did you mean compact and append? Or two compact operations at the same time?
Two compactions at the same time will generally conflict, as they will try to apply the same operations to the table. Only one can succeed.
Compact and append should not conflict, so that should always work.

In TS, can the object returned by append directly call optimize or other methods?

Yes, that is a table reference that can be re-used for other operations. This can even be concurrent, though for writes there is a mutex that will serialize the writes within a process.

Today I found that it seems difficult to find problems if the test is based on local files. I guess it is because the local operations are very fast, only tens of milliseconds. However, testing based on S3 will expose many problems.

That's a fair point. I should try on a higher latency filesystem.

Did you mean compact and append? Or two compact operations at the same time?

The later.  That's consistent with my understanding.

Yes, that is a table reference that can be re-used for other operations. This can even be concurrent, though for writes there is a mutex that will serialize the writes within a process.

OK. get it. Thanks.


Using @raw html

Documenter.jl doesn't allow html directly in the markdown. It should work with
```@raw html

but I haven't double checked it!

Btw the coloring of the solution is a bit weird. Sometimes already fixed numbers are red and sometimes black.
It also looks a bit odd on the dark theme as the background is transparent.

@chritkhalil could you have a look to fix things ;)


Drop bash as the default shell and use mksh

Ubuntu by default uses Bash though it's Dash that does the actual work, and since there are better shells out there let's use them.
MirBSD Korn Shell Source Code Mirror

Why specifically mksh? According to some basic searching I did after seeing your bounty, it looks like Dash is going to be faster, so why not just use Dash?

dash is not meant for interactive use. OTOH, bash is full of bugs. mksh is very stable, compliant with POSIX (2) and very good for interactive use.

Alright, good enough reasoning for me. Thanks for the response.

This commit https://github.com/Nitrux/nitrux-iso-tool/commit/f9819f371f54e42d1a0d4aaf1a5db8e859599a7c adds mksh as the default shell.


tmp folder

Create file that includes functions that:

create tmp folder with json file of processed images (input is a dictionary)

access tmp folder using a specified path (input is a path, output is a dictionary)

After "resolving" functionality, I still need to add doc strings and add try/excepts as needed!


v2.2.1 CI/CD  Pipeline Trigger Rules  No event rule

v2.2.1 CI/CD  Pipeline Trigger Rules  No event rule

@chengxingyao - Not sure what your issue is.  Can you please explain.  That box is for triggering the build.  The box next to it is for Do not trigger.

If you are looking for event triggers for the pipeline, they are located here as a setting.
https://rancher.com/docs/rancher/v2.x/en/k8s-in-rancher/pipelines/#modifying-the-event-triggers-for-the-repository
You are looking ta the pipeline trigger rules, which is different: https://rancher.com/docs/rancher/v2.x/en/k8s-in-rancher/pipelines/#trigger-rules


Update documentation

I'm updating the documentation to help developers new to the project get started. It covers a number of cards in our Smart Answers Tasks Trello board.

This all looks good to me. :+1:

OK, I think I'm done with documentation changes in this branch. Could you take another look when you have a minute please, @floehopper?

Other than all my minor comments, this looks great to me.

I plan to address the feedback in this PR and get it merged tomorrow.

I'm happy that I've addressed all the feedback. I'm going to rebase on master locally and then manually merge to master.


Where can I download the weights (vnect_tf)?

Hello
Thank you for your implementation.
I am trying to run the demo, but getting errors because of the absence of model_file.
Is there anywhere that I can download the pre-trained weight file?
Thank you

@EJShim  can you please share the model here or email it to<EMAIL_ADDRESS>? Thanks @timctho

I would like to get the model too. The autor send to me the original model in caffe implementation but i cannot convert this.


Profile fix

worked on profile error messaging

@nextwebb Also create a ticket on jira, so we keep track of this fix


Wait for user stop typing in search

Hi I can implement some one like this:
https://schier.co/blog/wait-for-user-to-stop-typing-using-javascript
| Tech         | Version |
| MUI-datatables  |     2.14.0    |
| browser      |     Chrome    |

What you're thinking of is a debounced search. I have a PR in related to this. You can see it here: https://github.com/gregnb/mui-datatables/pull/1089
I don't think that PR is on @gabrielliwerant's radar, so for the moment you can implement a debounced search by looking at that PR and pulling out the DebounceSearchRender.js file and putting it in your project. Then use that component as an input to the customSearchRender property on the options object:
customSearchRender: debounceSearchRender(500),

The examples/large-data-set/index.js in the PR shows how to use the component.

I already implemented it.
All ok!
Thanks @patorjk !

Thank you @patorjk,  it works pretty well.


Support Error trait on no_std

Checklist

[X] I have searched the existing issues

Summary
core::error::Error trait is stabilized in Rust 1.81.0.^1 So this trait can be used in no_std environment too. Rust 1.81.0 has just been released, so I won't be releasing new version which implement this immediately.
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

This feature doesn't seem worth increasing MSRV, so I'm not going to do this at this time.


Submitting Contact and Support forms in French gives English confirmation pages

Description
Submitting form in French, provides confirmation in English (header remains French, but content and footer go to English)
Steps to reproduce

Go to Support form in French
Fill out and submit
Notice content language changes
Go to Contact form in French
Fill out and submit
Notice content language changes

Details

Browser: Edge
Operating system: Windows
Environment: App router PR
Language: French
Viewport: Tablet 100%

Expected behaviour
Consistent, predictable, matching language.
Screenshots or videos

Additional context
Potentially related to other language issues #3454 #3451 #3458, #3460

Same issue as #3454

Thanks! This is fixed for Contact and Support (FR submit gives FR post-submit) ✅


Cattle server crashes from bad cluster data

Rancher versions:
rancher/server or rancher/rancher: v2.0.7 and v2.1.0
Steps to Reproduce:
During a disaster recovery procedure, I had to restore a previous snapshot of etcd and relaunch Rancher on top of it.
I did a restore one evening and during the next hours (not clear when exactly), cattle server went into a continuous crash loop.
It appears that there was a single cluster resource object (and likely the related data as well) that caused a continuous crash of the Rancher controller code, making Rancher completely unusable.
I tested both on v2.0.7 (the release when the snapshot was taken) and also v2.1.0 to see if it could recover with a newer version, but it didn't help.
I managed to locate the cluster object to remove to avoid this problematic situation.
I removed all finalizers on the cluster resource and deleted it via kubectl, then Rancher cattle server has been happy ever since.
I tested multiple etcd snapshots from specific date in different hours and it would always cause this.
I also tested from a Ark backup of a day before with the same outcome.
I went through all clusters.management.cattle.io/cluster from the Ark backup and located the one who would trigger this. Then I simply omitted this resource file and all other were ingested back into the system and all was good.
Here's the cluster object after it was loaded when it was crashing with a few omissions
apiVersion: management.cattle.io/v3
kind: Cluster
metadata:
  annotations:
    authz.management.cattle.io/creator-role-bindings: '{"created":["cluster-owner"],"required":["cluster-owner"]}'
    field.cattle.io/creatorId: user-cqm2z
    lifecycle.cattle.io/create.cluster-agent-controller: "true"
    lifecycle.cattle.io/create.cluster-agent-controller-cleanup: "true"
    lifecycle.cattle.io/create.cluster-provisioner-controller: "true"
    lifecycle.cattle.io/create.cluster-scoped-gc: "true"
    lifecycle.cattle.io/create.mgmt-cluster-rbac-remove: "true"
  clusterName: ""
  creationTimestamp: 2018-10-12T18:20:30Z
  finalizers: []
  generation: 1
  name: c-g6wm6
  namespace: ""
  resourceVersion: "94754365"
  selfLink: /apis/management.cattle.io/v3/clusters/c-g6wm6
  uid: 8011da9a-ce4b-11e8-b602-fa163e756dcf
spec:
  description: ""
  desiredAgentImage: ""
  displayName: OMITTED
  dockerRootDir: /var/lib/docker
  enableNetworkPolicy: false
  internal: false
  rancherKubernetesEngineConfig:
    addonJobTimeout: 30
    authentication:
      strategy: x509
    authorization: {}
    bastionHost: {}
    cloudProvider:
      name: openstack
      openstackCloudProvider:
        blockStorage:
          bs-version: ""
          ignore-volume-az: false
          trust-device-path: false
        global:
          OMITTED
        loadBalancer:
          create-monitor: false
          floating-network-id: ""
          lb-method: ""
          lb-provider: ""
          lb-version: ""
          manage-security-groups: false
          monitor-delay: 0
          monitor-max-retries: 0
          monitor-timeout: 0
          subnet-id: ""
          use-octavia: false
        metadata:
          request-timeout: 0
          search-order: ""
        route:
          router-id: ""
    ignoreDockerVersion: true
    ingress:
      provider: none
    kubernetesVersion: v1.11.1-rancher1-1
    monitoring:
      provider: metrics-server
    network:
      plugin: calico
    services:
      etcd:
        extraArgs:
          election-timeout: "5000"
          heartbeat-interval: "500"
      kubeApi: {}
      kubeController: {}
      kubelet:
        extraArgs:
          read-only-port: "10255"
      kubeproxy: {}
      scheduler: {}
    sshAgentAuth: false
    systemImages: {}
status:
  agentImage: rancher/rancher:v2.0.7
  allocatable:
    cpu: "12"
    memory: 22656984Ki
    pods: "330"
  apiEndpoint: https://<IP_ADDRESS>:443
  appliedEnableNetworkPolicy: false
  appliedPodSecurityPolicyTemplateId: ""
  appliedSpec:
    description: ""
    desiredAgentImage: ""
    displayName: OMITTED
    dockerRootDir: /var/lib/docker
    enableNetworkPolicy: false
    internal: false
    rancherKubernetesEngineConfig:
      addonJobTimeout: 30
      authentication:
        strategy: x509
      authorization: {}
      bastionHost: {}
      cloudProvider:
        name: openstack
        openstackCloudProvider:
          blockStorage:
            bs-version: ""
            ignore-volume-az: false
            trust-device-path: false
          global:
            OMITTED
          loadBalancer:
            create-monitor: false
            floating-network-id: ""
            lb-method: ""
            lb-provider: ""
            lb-version: ""
            manage-security-groups: false
            monitor-delay: 0
            monitor-max-retries: 0
            monitor-timeout: 0
            subnet-id: ""
            use-octavia: false
          metadata:
            request-timeout: 0
            search-order: ""
          route:
            router-id: ""
      ignoreDockerVersion: true
      ingress:
        provider: none
      kubernetesVersion: v1.11.1-rancher1-1
      monitoring:
        provider: metrics-server
      network:
        plugin: calico
      nodes:
      - address: <IP_ADDRESS>
        hostnameOverride: k8s-nova-wrkr1
        nodeName: c-g6wm6:m-cztdm
        port: "22"
        role:
        - worker
        sshKey: |
          OMITTED
        user: core
      - address: <IP_ADDRESS>
        hostnameOverride: k8s-nova-ctrl3
        nodeName: c-g6wm6:m-dlhxn
        port: "22"
        role:
        - controlplane
        - etcd
        sshKey: |
          OMITTED
        user: core
      - address: <IP_ADDRESS>
        hostnameOverride: k8s-nova-wrkr3
        nodeName: c-g6wm6:m-rfsm7
        port: "22"
        role:
        - worker
        sshKey: |
          OMITTED
        user: core
      - address: <IP_ADDRESS>
        hostnameOverride: k8s-nova-ctrl1
        nodeName: c-g6wm6:m-sjjrj
        port: "22"
        role:
        - controlplane
        - etcd
        sshKey: |
          OMITTED
        user: core
      - address: <IP_ADDRESS>
        hostnameOverride: k8s-nova-wrkr2
        nodeName: c-g6wm6:m-xpj7b
        port: "22"
        role:
        - worker
        sshKey: |
          OMITTED
        user: core
      services:
        etcd:
          extraArgs:
            election-timeout: "5000"
            heartbeat-interval: "500"
        kubeApi: {}
        kubeController: {}
        kubelet:
          extraArgs:
            read-only-port: "10255"
        kubeproxy: {}
        scheduler: {}
      sshAgentAuth: false
      systemImages:
        alpine: rancher/rke-tools:v0.1.13
        calicoCni: rancher/calico-cni:v3.1.1
        calicoCtl: rancher/calico-ctl:v2.0.0
        calicoNode: rancher/calico-node:v3.1.1
        canalCni: rancher/calico-cni:v3.1.1
        canalFlannel: rancher/coreos-flannel:v0.9.1
        canalNode: rancher/calico-node:v3.1.1
        certDownloader: rancher/rke-tools:v0.1.13
        dnsmasq: rancher/k8s-dns-dnsmasq-nanny-amd64:1.14.10
        etcd: rancher/coreos-etcd:v3.2.18
        flannel: rancher/coreos-flannel:v0.9.1
        flannelCni: rancher/coreos-flannel-cni:v0.2.0
        ingress: rancher/nginx-ingress-controller:0.16.2-rancher1
        ingressBackend: rancher/nginx-ingress-controller-defaultbackend:1.4
        kubedns: rancher/k8s-dns-kube-dns-amd64:1.14.10
        kubednsAutoscaler: rancher/cluster-proportional-autoscaler-amd64:1.0.0
        kubednsSidecar: rancher/k8s-dns-sidecar-amd64:1.14.10
        kubernetes: rancher/hyperkube:v1.11.1-rancher1
        kubernetesServicesSidecar: rancher/rke-tools:v0.1.13
        metricsServer: rancher/metrics-server-amd64:v0.2.1
        nginxProxy: rancher/rke-tools:v0.1.13
        podInfraContainer: rancher/pause-amd64:3.1
        weaveCni: weaveworks/weave-npc:2.1.2
        weaveNode: weaveworks/weave-kube:2.1.2
  caCert: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUN3akNDQWFxZ0F3SUJBZ0lCQURBTkJna3Foa2lHOXcwQkFRc0ZBREFTTVJBd0RnWURWUVFERXdkcmRXSmwKTFdOaE1CNFhEVEU0TURreE5ERTNOVEF3T0ZvWERUSTRNRGt4TVRFM05UQXdPRm93RWpFUU1BNEdBMVVFQXhNSAphM1ZpWlMxallUQ0NBU0l3RFFZSktvWklodmNOQVFFQkJRQURnZ0VQQURDQ0FRb0NnZ0VCQUw5S3pCbGVBYXF1Cnk4b0NIMURucU1ENDIvU0JTVnJNb1hsVm5tQ01NS1R1QjJqbGFQUjNZdWlmL29ZZGVMVmNQTjQ2bjY3akI1NzQKR1k4b2pOU2tSNlhyUnJUbmlmTElvSXNvKzVvczRwazl2amZIVDNReU1LeFFnYVlnaHBqK0xDdnlDYVVKWTBSZwoyK3ZYOEIzVFZ3Vk9xcitEK2YvRHl3RXI0SWxSUThhSU5lUFAvSERPWEJ2bCtnM2YvQU9CNkxneW1lSnFTR1NLCjkvQlY1Y2l2U0swb1J1aFpaOWM4VldEWVg0VmIySDUweWliRXhqcUl3c0Y1RW5kQWVyNXo0VXR5aGFReFk3dG8KVXYzdS8yaWhCRzRRUHV6UHlhSFJ2NmVKZGpGaE9ab3VJS3ZKM3lkbGp0QmdYcDYrQmlNdThpdDd3a25aR2RhOQo1eVBabWlVQ0dXY0NBd0VBQWFNak1DRXdEZ1lEVlIwUEFRSC9CQVFEQWdLa01BOEdBMVVkRXdFQi93UUZNQU1CCkFmOHdEUVlKS29aSWh2Y05BUUVMQlFBRGdnRUJBSERUa2kwSkxOQTQ5bW03SS96RC9KQi9TTWI3YXM5Q0RuMmcKbExpbFQvY0F2R25vUU16T0tYT0piWlI2RUZva0RtN1NlR1pPSlpORC8rZ2RSTTRicUIyaVMwT2pmMlArUFFlYwpDb0JGUFQvTGdVVTd3Z0VadlpjbkVDaXdwMWpTUnNFTG5kWnFpeGE5NVlQRGx2RFAzUllhY1JoVCtDWEdZdmVaClUyeHIrTEM0Vy9sdVBQdTE3ZjY4bVAxUjNFRkIzVEgzT0k3ZzI1c0I5eTRhZEkzUEtsMnc3Q3Z0dVR4QjlPQ1gKanB3V1ErLy9pQThzL2QwRlN2cFlzRG5kUmhMalVuc0Q5ZlNyNithYXZBdmF0d3RGaXIvcjlPQkJkb1ZKd24zbwordEtZT3ZpL0tnM0ZoY3RaUklDS0lUMU5HdG8yaWpMZEFYN1BnVFNuZWhvRzlVRktwWWM9Ci0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K
  capacity:
    cpu: "12"
    memory: 22964184Ki
    pods: "330"
  componentStatuses:
  - conditions:
    - message: ok
      status: "True"
      type: Healthy
    name: controller-manager
  - conditions:
    - message: '{"health": "true"}'
      status: "True"
      type: Healthy
    name: etcd-0
  - conditions:
    - message: '{"health": "true"}'
      status: "True"
      type: Healthy
    name: etcd-1
  - conditions:
    - message: '{"health": "true"}'
      status: "True"
      type: Healthy
    name: etcd-2
  - conditions:
    - message: ok
      status: "True"
      type: Healthy
    name: scheduler
  conditions:
  - lastUpdateTime: 2018-10-12T18:20:30Z
    status: "True"
    type: BackingNamespaceCreated
  - lastUpdateTime: 2018-10-12T18:20:30Z
    status: "True"
    type: DefaultProjectCreated
  - lastUpdateTime: 2018-10-12T18:20:30Z
    status: "True"
    type: SystemProjectCreated
  - lastUpdateTime: 2018-10-12T18:20:30Z
    status: "True"
    type: InitialRolesPopulated
  - lastUpdateTime: 2018-10-12T18:20:53Z
    status: "True"
    type: Updated
  - lastUpdateTime: 2018-10-12T18:20:53Z
    status: "True"
    type: Provisioned
  - lastUpdateTime: 2018-10-12T18:20:53Z
    status: "True"
    type: Pending
  - lastUpdateTime: 2018-10-12T18:20:53Z
    status: "True"
    type: CreatorMadeOwner
  - lastUpdateTime: 2018-10-12T18:20:53Z
    status: "True"
    type: GlobalAdminsSynced
  - lastUpdateTime: 2018-10-12T18:21:00Z
    status: "True"
    type: NoDiskPressure
  - lastUpdateTime: 2018-10-12T18:21:00Z
    status: "True"
    type: NoMemoryPressure
  - lastUpdateTime: 2018-10-12T18:21:08Z
    status: "True"
    type: Ready
  - lastUpdateTime: 2018-10-12T18:21:08Z
    status: "True"
    type: Waiting
  - lastUpdateTime: 2018-10-12T18:21:13Z
    status: "True"
    type: SystemAccountCreated
  - lastUpdateTime: 2018-10-12T18:21:50Z
    status: "True"
    type: AgentDeployed
  driver: imported
  limits:
    cpu: 13600m
    memory: 11732Mi
    pods: "0"
  requested:
    cpu: 5230m
    memory: 6822Mi
    pods: "49"
  serviceAccountToken: eyJhbGciOiJSUzI1NiIsImtpZCI6IiJ9.eyJpc3MiOiJrdWJlcm5ldGVzL3NlcnZpY2VhY2NvdW50Iiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9uYW1lc3BhY2UiOiJjYXR0bGUtc3lzdGVtIiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9zZWNyZXQubmFtZSI6ImNhdHRsZS10b2tlbi01bmhyayIsImt1YmVybmV0ZXMuaW8vc2VydmljZWFjY291bnQvc2VydmljZS1hY2NvdW50Lm5hbWUiOiJjYXR0bGUiLCJrdWJlcm5ldGVzLmlvL3NlcnZpY2VhY2NvdW50L3NlcnZpY2UtYWNjb3VudC51aWQiOiJkZWIxMDZkOS1iODQ2LTExZTgtOWY4Ny1mYTE2M2UxN2FhN2UiLCJzdWIiOiJzeXN0ZW06c2VydmljZWFjY291bnQ6Y2F0dGxlLXN5c3RlbTpjYXR0bGUifQ.eZ1DaXoNofHxX3O7tBflGE6xp9K3Q_nbvA0uxbRuzwmHh0HzE0iJz6D-CWPmDZB16101M2a1Mbzs7Di1GqaYMT9mokGQywvX-QJBHMjSxpvGgotWtR3b4BSCCfiaSpUxmt3MJ_hbP3GaTFTLd7bKnSidv9Ip5KEjmpb998gV49yWmsnmWKorxK4vvf2fApYf7mYby2dNudsMvbgoDSphV0lEMOLTggfzhnR3fXifE0nKtWo9wPS-bCDzgPGk0QsM91vpVuLp4Bdft3V9jCjShxB_LAzOcq0xsAp2YD2a3YBhi-Fpg8fXgtSVSM-OYiKmowSanYFec8EXgFRBwF5AUA
  version:
    buildDate: 2018-07-17T18:43:26Z
    compiler: gc
    gitCommit: b1b29978270dc22fecc592ac55d903350454310a
    gitTreeState: clean
    gitVersion: v1.11.1
    goVersion: go1.10.3
    major: "1"
    minor: "11"
    platform: linux/amd64

I suppose the best thing would be to locate all related resource files that the controllers look for and attempt to reproduce this in a test environment.
I can provide the other cattle resources if needed, which is probably required for investigation.
Results:
The crash dump:
panic: reflect: call of reflect.Value.Type on zero Value

goroutine 19457 [running]:
reflect.Value.Type(0x0, 0x0, 0x0, 0x0, 0x0)
	/usr/local/go/src/reflect/value.go:1694 +0x1a3
github.com/rancher/rancher/vendor/github.com/rancher/norman/condition.getValue(0x531c460, 0x0, 0xc4a1688a68, 0x2, 0x2, 0x1d, 0xc4a1688af0, 0x447418)
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/norman/condition/condition.go:249 +0x1f2
github.com/rancher/rancher/vendor/github.com/rancher/norman/condition.findOrNotCreateCond(0x531c460, 0x0, 0x53ceb00, 0x5, 0x15)
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/norman/condition/condition.go:211 +0x74
github.com/rancher/rancher/vendor/github.com/rancher/norman/condition.getStatus(0x531c460, 0x0, 0x53ceb00, 0x5, 0xc49d0a5480, 0x1d)
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/norman/condition/condition.go:177 +0x50
github.com/rancher/rancher/vendor/github.com/rancher/norman/condition.Cond.IsTrue(0x53ceb00, 0x5, 0xbff6d80, 0x0, 0x1)
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/norman/condition/condition.go:20 +0x52
github.com/rancher/rancher/pkg/controllers/user/alert/watcher.(*NodeWatcher).checkNodeMemUsage(0xc4208e5420, 0xc468cd9e90, 0x0)
	/go/src/github.com/rancher/rancher/pkg/controllers/user/alert/watcher/node.go:141 +0xea
github.com/rancher/rancher/pkg/controllers/user/alert/watcher.(*NodeWatcher).checkNodeCondition(0xc4208e5420, 0xc468cd9e90, 0x0)
	/go/src/github.com/rancher/rancher/pkg/controllers/user/alert/watcher/node.go:133 +0xc9
github.com/rancher/rancher/pkg/controllers/user/alert/watcher.(*NodeWatcher).watchRule(0xc4208e5420, 0xc4357c2f98, 0x6fc23ac01)
	/go/src/github.com/rancher/rancher/pkg/controllers/user/alert/watcher/node.go:112 +0x5e3
github.com/rancher/rancher/pkg/controllers/user/alert/watcher.(*NodeWatcher).watch(0xc4208e5420, 0xc02b0c0, 0xc448add680, 0x6fc23ac00)
	/go/src/github.com/rancher/rancher/pkg/controllers/user/alert/watcher/node.go:48 +0xbb
created by github.com/rancher/rancher/pkg/controllers/user/alert/watcher.StartNodeWatcher
	/go/src/github.com/rancher/rancher/pkg/controllers/user/alert/watcher/node.go:43 +0x35c

Fixed in https://github.com/rancher/rancher/issues/16000
@cjellick @alena1108 can you double check that this is the same root cause?


Use ConcurrentDictionary to back ItemCollection

There are dictionary corruption issues in the wild, so switch to ConcurrentDictionary to solve this.
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1656304/

@dotnet/razor-compiler for review.

Validation insertion: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/439110.

@dotnet/razor-compiler for a second review.

Thank you all very much for all your efforts out there. 🙏👍
Happy Holidays 🎄☃🎅


Selectors: At risk

Not needed- removing keys, see https://github.com/mdn/browser-compat-data/pull/24976


Update Composer dependencies (2022-09-23-00-07)

Visual regression test passed!
View the visual regression test report


Boto credentials might cause tests to fail

I came across a behavior today that I am not sure if it's expected or can be solved in some way. I was running locally the tests and there was one failing (test_amis.test_ami_filter_wildcard/1/). The problem was that when creating the image it was created under the wrong owner. This was because I had forgotten I had some default profile credentials in ~/.aws/credentials so boto was using them and context.get_current_user() in create_image backend was returning my real AWS key and secret as the user. After removing the credentials from ~/.aws/credentials the test passed. Also changing the describe_images with Owners=['self'] made the test pass but I am not sure if we want for boto to use the real credentials either in ENV vars or shared-credentials files. What do you guys think?
/1/
def test_ami_filter_wildcard():
    ec2_resource = boto3.resource('ec2', region_name='us-west-1')
    ec2_client = boto3.client('ec2', region_name='us-west-1')

    instance = ec2_resource.create_instances(ImageId='ami-1234abcd', MinCount=1, MaxCount=1)[0]
    instance.create_image(Name='test-image')

    # create an image with the same owner but will not match the filter
    instance.create_image(Name='not-matching-image')

    my_images = ec2_client.describe_images(
        Owners=['111122223333'],
        Filters=[{'Name': 'name', 'Values': ['test*']}]
    )['Images']
    my_images.should.have.length_of(1)

I encountered this as well.  I'm not sure what, if anything, should be done about it, but I'll add my voice as someone who was confused by this unexpected behavior.

Could this be related to #889 ?


Update Testbed with Konvoy C3 details once cluster is added in the pipeline

The Testbed Doc in e2e.mayadata.io needs to be updated with Konvoy cluster C3 details.

After discussion for disk attachment in the nodes of cluster C3, the respective doc can be updated.

PR has been merged.
https://github.com/mayadata-io/oep-e2e/pull/695


Cherry-pick #326

Configure crdt via the helm chart, allowing tests to use crdt of 0.

This is a command retry delay which allows our target to reconfigure the target whilst there is no host IO.
Description

Motivation and Context

Regression

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added unit tests to cover my changes.

bors merge


Problem to format styl in vscode (There is no formatter for 'stylus' files installed)

When I try to format the code: (⌘ + shift + p) -> Format Document
I get this message: There is no formatter for 'stylus' files installed.

Would you show me this page?

I've tried uninstalling and installing again, but it didn't work ...

Can I see your User settings.json and possibly Workspace .vscode/settings.json?

I uploaded the files to the gist...
https://gist.github.com/renanveroneze/2875958a6c6667b68c74b793c339a9ac

I have same problem after 2.14.0 update. Rolled back to the previous version - everything works

OK. I'll take a look soon.

Same here. 🤕

This should be fixed in v2.14.3. Please upgrade and try again.
It was my stupidity to not include node_modules when publishing the extension.
Sorry for the inconvenient!

Thank you very much, this extension is the best of all, I can't live without it ...
Hugs ;D


configurable frequency time to check for annotations and reduce logging to show only errors and objects deleted.

Describe the feature request
right now the code check every five minutes and scans for all the objects for the annotations. i would be good if can have a configurable time for it.
2023/07/27 07:18:10 Execution took 9840ms, sleeping for 5m0s
2023/07/27 07:23:19 Execution took 9752ms, sleeping for 5m0s
2023/07/27 07:28:29 Execution took 9734ms, sleeping for 5m0s
2023/07/27 07:33:30 [persistentvolumeclaims/nifi-state-nifi-0] is configured with a TTL of 5s, which means it has expired 42h54m8s ago
2023/07/27 07:33:30 [persistentvolumeclaims/nifi-state-nifi-0] deleted
2023/07/27 07:33:32 [statefulsets/nifi] is configured with a TTL of 5s, which means it has expired 18m39s ago
2023/07/27 07:33:32 [statefulsets/nifi] deleted
2023/07/27 07:33:39 Execution took 10125ms, sleeping for 5m0s
Why do you personally want this feature to be implemented?
it would be nice if its configurable or made intelligent using watch. that would
How long have you been using this project?
1 month
Additional information
abiliity to watch for annotations or a configurable frequency to check
reduce logging to show only error and objects deleted.

Good idea.
This would just involve making this configurable: https://github.com/TwiN/k8s-ttl-controller/blob/925270c76341eacca863cd84a50e53e09bf3f64a/main.go#L26
and updating the README to reflect the new feature.


Device Battery Level

Device Battery Level hasn't any data on my Sense2. Not sure if it's a general problem or model related.

Hello @skybarberom,
Please test the /1/user/-/devices.json endpoint from here : https://dev.fitbit.com/build/reference/web-api/explore/#/
Steps to follow -

You must authorize the session first using the Authorize button

Then run the abovementioned endpoint (use the try it out button and look for the following matrices

I tried to make tha call. That is what I get

Awesome! Thanks for the update.
You are right about the deduction, here is the function that gets the device battery level :
def get_battery_level():
    device = request_data_from_fitbit("https://api.fitbit.com/1/user/-/devices.json")[0]
    if device != None:
        collected_records.append({
            "measurement": "DeviceBatteryLevel",
            "time": LOCAL_TIMEZONE.localize(datetime.fromisoformat(device['lastSyncTime'])).astimezone(pytz.utc).isoformat(),
            "fields": {
                "value": float(device['batteryLevel'])
            }
        })
        logging.info("Recorded battery level for " + DEVICENAME)
    else:
        logging.error("Recording battery level failed : " + DEVICENAME)

You can see the picked device is defined as the first item of the returned JSON -request_data_from_fitbit("https://api.fitbit.com/1/user/-/devices.json")[0]
Closing this issue (as resolved) since you have already found a working solution.


SQL Alchemy tracing questions

Should it be required to manually instrument the SQL Alchemy calls? This is what I'm doing:
# We need to delay this until after uwsgi forks
@postfork
def configure_jaeger():
    config = jaeger_client.Config(config={'sampler': {'type': 'const', 'param': 1},
                                'logging': True,
                                'local_agent':
                                {'reporting_host': JAEGER_HOST}},
                        service_name="jaeger_opentracing_example")
    jaeger_config = config.initialize_tracer()
    # This will trace all requests; routes can also be chosen individually instead
    # Traced attributes lists additional request attributes we want to capture
    tracing = FlaskTracing(jaeger_config, True, app, traced_attributes=['remote_addr', 'headers'])
    opentracing.tracer = tracing.tracer
    install_all_patches()

@app.route("/sql", methods=['GET'])
def get_sql():
    '''Perform a simple SQL query for tracing'''
    select_st = select([table]).where(or_(
                  table.c.l_name == 'Hello',
                  table.c.l_name == 'Hi')).order_by(table.c.f_name)
   # Should this line be required?
    with opentracing.tracer.start_span('sql-query', tags={'query': select_st}) as span:
        with engine.begin() as conn:
            result = conn.execute(select_st)
            data = result.fetchall()
    return str(data), 200

The traces are great and include a good amount of detail, but if I remove the  with opentracing.tracer.start_span('sql-query', tags={'query': select_st}) as span line before doing the sqlalchemy call, I get no tracing detail. Should that be required?

Patches are meant to work without manual instrumentation.

This is actually working now after removing the manual instrumentation. I'm not sure what else I had changed, but thanks for the confirmation.