Crash on newest driver

on RTX 3060 laptop GPU, 537.42 driver was installed.
Without CET: Game works.
With CET: Game crashes.
537.34:
Without CET: Game works.
With CET: Game works.
Willing to test and provide a log if needed.

Let it crash and make a report with crash reporter. Dont send the report!
After this, please navigate to this folder (open Windows Explorer and paste this into path field)
%LocalAppData%\REDEngine\ReportQueue
Package latest report folder there and post it here if you can (there should be no sensitive info if you are worried about that, just snapshot from crash and some info about loaded modules, so I can look where it died and what modules were active).
Also post your CET log file I guess, although I doubt it'll have any information...

Oh right, would also be nice to know OS I guess, didnt mention that.

I solved the issue, thank you. There is no need for a report. Let me report my findings.
I downloaded the game using OFFLINE gog installers and played the game offline.
I replaced Galaxy64.dll and GOGservices dll with unofficial patches and the game is working fine.
I am on windows 11 professional edition.
Thank you! There seems to be no issue for now. If there is, I will update this thread later!

However, if next time I can see this issue, I might report it again-when the game updates. thanks

I don't know if the other issues mentioned above used a GOG copy of the game. If yes, it could be the issue with GOG dlls interacting with CET-not sure


Larger xml file takes very long to decode

Hello there and thanks for providing this great package!
I have a 108mb (language dictionary with just under 5 million rows) xml file that takes over an hour to decode.
At peak the memory consumption is over 2GB (according to debug navigator).
It will finish decoding eventually (I actually did let it run for an hour once). Smaller sections of the file decode just fine.
I wonder if you've experienced something similar and if there's any easy solution.
I'm wondering if splitting up the original file into smaller chunks. Which would maybe help if you're parsing the xml as DOM under the hood, but probably not so much if it's SAX?

Hi @MartinP7r, thank you for reporting this.
I think that splitting the file is the best way to make it faster short term. Also, if your XML has deep nesting, that may slow it down too. I'd be very interested to see profiling results if you can build in Xcode and profile it with Instruments.
We use the standard XMLParserDelegate from Foundation under the hood. Profiling would help in determining how much time is spent in Foundation's code as opposed to the XMLCoder code and would allows us to decide what exactly should be optimized at first.

Thank you for your quick response!
I'll try and find out where all that time is spent. Probably towards the weekend, since it's a personal project I'm working on.
I'm not too experienced with Instruments, so thanks for the link! If you have any suggestions what else too look for, please let me know.

I think you might have it backwards since in this view the call tree is inverted.
Sorry I did not mention that, I used the settings as described in the tutorial you recommended above:

I'd be happy to isolate the profiling from UI logic to make sure. I'll try and write a test on Wednesday.

Btw, all the retrieveDict() method does is:
    static func retrieveDict() -> JMdict? {
        guard let url = Bundle.main.url(forResource: "JMdict",
                                        withExtension: "xml") else { fatalError() }
        guard let data = try? Data(contentsOf: url) else { fatalError() }

        let decoder = XMLDecoder()
        let jmdict: JMdict?

        do {
            jmdict = try decoder.decode(JMdict.self, from: data)
        } catch {
            l.error(error)
            jmdict = nil
        }

        return jmdict
    }

Looks like they are calling into SwiftUI

Just to clarify again, the call tree is inverted, so Swift UI is calling retrieveDict, once only.

I think the logic in KeyedStorage looks like the hottest path here, and it's needed to make sure that order of elements is preserved when encoding. Maybe we could could optimize parts of it, or maybe make it configurable to allow turning it off, but this would require some time to develop and to make sure that existing test cases aren't broken.
Do you plan to release your project or at least parts of it as open source? As far as I understand, the JMdict file is freely available, would you be able to share the JMdict structure you use here? This would allow me to create a test case or an isolated app to profile it on my side.

Thank you and sorry for the late reply.

needed to make sure that order of elements is preserved when encoding.

I'm not sure I fully understand. How does this come into play when trying to decode, not encode?
I can share what I have so far in terms of models. It's still incomplete and doesn't cover all of the available tags yet, though.

struct JMdict: Codable {

    var entries: [Entry]

    enum CodingKeys: String, CodingKey {
        case entries = "entry"
    }
}

struct Entry: Codable {

    var ent_seq: Int = 0
    var kanjis: [Kanji]? = []
    var readings: [Reading] = []
    var senses: [Sense]

    enum CodingKeys: String, CodingKey { case
        ent_seq = "ent_seq",
        kanjis = "k_ele",
        readings = "r_ele",
        senses = "sense"
    }
}

struct Kanji: Codable, Hashable {
    var expression: String
    let info: String?
//    let priority: [String]

    enum CodingKeys: String, CodingKey { case
        expression = "keb",
        info = "ke_inf"
    }
}

struct Reading: Codable, Hashable {
    let expression: String
    let restrictedTo: String?
    let info: String?
    //    let priority: [String]

    enum CodingKeys: String, CodingKey { case
        expression = "reb",
        restrictedTo = "re_restr",
        info = "re_inf"

    }
}

struct Sense: Codable, Hashable {

//    var stagk: String?
    let partOfSpeech: String?
    let crossReference: String?
    let antonym: String?
    let field: String?
    let misc: String?
    let languageSource: String?
    let dialect: String?
    var glosses: [Gloss]

    enum CodingKeys: String, CodingKey { case
//        stagk,
        partOfSpeech = "pos",
        crossReference = "xref",
        antonym = "ant",
        field,
        misc,
        languageSource = "lsource",
        dialect = "dial",
        glosses = "gloss"
    }
}

struct Gloss: Codable, Hashable {

    var value: String
    var type: String?
    var lang: String = "eng"
    var gender: String?

    enum CodingKeys: String, CodingKey { case
        value = "",
        type = "g_type",
        lang = "xml:lang",
        gender = "g_gend"
    }
}

I'm not sure I fully understand. How does this come into play when trying to decode, not encode?

I think the most direct way to get exposed to that is to decode into enums with something like XHTML and other similar cases:

Paragraph 1

Paragraph 2

  Random text

Paragraph 3

A super naive way to decode this would be:
struct Body: Codable {
  let p: [String]
  let span: [String]
}

But with this model you'd never know that the  element comes after the first two
 elements and before the third
 element.
Then a more suitable model would be:
struct Body: Codable {
  enum Element: Codable {
    case p(String)
    case span(String)
  }

  let elements: [Element]

  // more special enum handling omitted for brevity
}

XMLCoder decodes (and symmetrically encodes) in two stages:

It builds a tree of boxes based on their types discovered dynamically from the result of Foundation's XMLParser. For collections of elements like in the example above it needs to preserve the order, but also preserve indices of corresponding keys to handle both types of models. At this stage we can't know whether you model type expects the order of elements to be preserved, so we preserve it just in case.

It maps the tree of boxes by mapping it to the tree of coders, supplying the subtrees to corresponding Decodable implementations of each model type. Again, from the perspective of XMLCoder the Decodable implementations of your model types is a black box. It can be a standard compiler-generated boilerplate, but can also be your own highly-customized logic.

Because so much happens in runtime, and Swift doesn't allows us to examine your model types at compile time (we'd probably need something like proper macros for that, and not C/C++ macros, but something closer to what Rust has), there doesn't seem to be a way to optimize this other than a user toggling this order preservation logic on their XMLDecoder instance. At least that's my current understanding, but maybe I'm missing something and I'd gladly consider some alternative solutions.

Thank you so much for the detail explanation!
I think I understand now. Depending on the requirements of the model, essential context would get lost without keeping the order of different types of elements within the same level of the xml structure.
I've gone through the documenting comments in JMdict's header and so far I don't think there's any such case.
So, I'd really like to try and decode it without the logic for preserving element order to see if it has a significant effect on performance.
I'd try it myself locally in a fork, but I'm not sure.
If I understand it correctly, in XMLCoderElement.transformToBoxTree() the hot path goes through KeyedStorage.merge(element:) and KeyedStorage.append(:at:), whereas the later keeps stores the order?

Yes, that's correct. The elements themselves are stored in a buffer that fully preserves the order, but there's also a dictionary that maps from keys to indices in the buffer array. When elements are queried by key, you get them through that dictionary, as far as I remember.


Element is displayed as flagged instead of filtered

Let's say I have a DITA topic with an element inside:

This is changed text.

and a DITAVAL file containing these rules:
  <val>
     <prop att="props" action="exclude"/>
     <prop att="props" val="changed" action="flag" backcolor="yellow"/>
  </val>

Right now if I publish to HTML the element is displayed and flagged as yellow.
But according to the specification:
http://docs.oasis-open.org/dita/dita/v1.3/errata02/os/complete/part3-all-inclusive/archSpec/base/flagging.html#flagging
  When the same element evaluates as both flagged and filtered (for example, flagged because of a value for the @audience attribute and filtered because of a value for the @product attribute value), the element should be filtered.

So I think in this case the element should be excluded by the DITAVAL and not flagged.
oxygen_dita_ditaval.zip

Good question - but I think the current behavior is correct.
This is not the example that the spec was trying to address with that example. The spec topic is trying to address what happens when you have @audience evaluate to "flag" and @product evaluate to "exclude". In that example, because the product is excluded, the flag does not matter. In this case you've got a general "exclude" rule for @props but also a "flag" rule for a specific value. I think this is the case described here, with the 2nd and 3rd list items:
http://docs.oasis-open.org/dita/dita/v1.3/errata02/os/complete/part3-all-inclusive/langRef/ditaval/ditaval-prop.html
With your example - using <prop att="props" action="exclude"/> sets a default rule of "exclude" for that attribute. That default is only used for values that do not specify rule for a specific props value. In this case, when you set the specific "flag" it means the default rule is not used.

Thanks, I’m closing the issue


Clamp amplitude between -1.0 and 1.0.

This is intended as a fix for issue #209.

I updated to TF r1.0 in case I needed a newer version of TF to see the problem. A half dozen runs under python 2.7 locally don't fail locally, but python 2.7 fail[ed] every time on the CI server.
BTW I also added changes that TF 1.0 is going to require (tf.scalar_summary -> tf.summary.scalar).
So I give up for the moment until I get a new idea, or someone else has an idea regarding how to reproduce this failure. Maybe someone else can try a PR to fix issue 209 and see if it passes.
[Edit] I see the last failure is in the python 3.5 run, but all the prior ones were in the python 2.7 run. I'm running 2.7 locally.


[6.2 Sticky] When anchor is below the sticky element on the page, calculation is off by its height

When a sticky element (in it's non-sticky state) naturally pushes its anchor down the page, the anchor's position is off by the element's height.
The order is as follows:

sticky class is added on init

This applies position: absolute; to the sticky element, which causes the sticky container to be 0 height
This causes the content below the sticky to move up, underneath the sticky container

position of anchor is calculated

The current position of the anchor (if below the sticky element) is off by the height of the element

height of the sticky container is calculated and added

By moving the this.$element.addClass(this.options.stickyClass); into the load.zf.sticky handler in the callback of _this.setSizes, it is able to get the proper "natural" position of the anchor.
Subsequent _this.setSizes calls act as expected, since the container has had its height set (it is only the initial, without the height and without the sticky element in the flow, that it causes issues).

I think I might have run into this from two different directions.
tl;dr: What you originally ran into might be two different bugs, not one.
Check out these issues:

#8825: [Sticky] Wrong default value for data-check-every at documentation
#8791: [Sticky] Sticky causing content below to "jump" on load

When a sticky element (in it's non-sticky state) naturally pushes its anchor down the page, the anchor's position is off by the element's height.

This is how I first ran into this as well. The sticky element was un-sticking too early.
I deduced (partially correctly) that the issue was with the JS not recalculating the height after it changes the stuck/unstuck state. This lead me to the data-check-every value. Which leads right to #8825. The docs say the default should be set to 50, but it's actually set to -1. And -1 means no recalculating on scroll. Hence this issue. I set it to something other than -1 and this is no longer an issue. The element becomes unstuck at the right spot.
But you also mention:
sticky class is added on init
    - This applies position: absolute; to the sticky element, which causes the sticky container to be 0 height
This causes the content below the sticky to move up, underneath the sticky container

Which I also ran into.
It's not related (I don't think) to #8825, but it is related to #8791. The built-in .sticky class is probably setting position: absolute unnecessarily. Which is causing the initial jump you mentioned.
I see that this is closed and a merge has been made. I don't know enough to know if that is the right thing to do. It seems right. But I thought it was worth mentioning what I found, so I'm posting it here just incase and for (possible) completeness.
I hope this helps.


feat : New maven module for part type information submodel

Description

Added new maven module for part type information submodel support.

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

@almadigabor Please review and approve the PR.

@ChetanT-System  Please have a look for the CodeQL Warnings.

@ChetanT-System  Please have a look for codeql warnings as suggested by @almadigabor


Can't shrinkwrap npm-shrinkwrap on NPM 2

Because of NPM 2's upgrade to semver 4, and npm-shrinkwrap's dependency on a package that depends on two other packages that have semver 4 incompatible versions, you cannot shrinkwrap npm-shrinkwrap on NPM 2. This is the issue as far as I can see.
Here's the relevant cross-section of npm list output.
  │ ├─┬<EMAIL_ADDRESS>  │ │ └─┬<EMAIL_ADDRESS>invalid
  │ │   ├──<EMAIL_ADDRESS>  │ │   ├──<EMAIL_ADDRESS>  │ │   └──<EMAIL_ADDRESS>invalid

There is a version 200 of npm-shrinkwrap that you can use with npm 2.
Try using that instead.

So, I've edcided to use npm-lockdown in the meantime, which says in the README:

At present (as of npm v1.1.33), the implementation of shrinkwrap has a couple flaws
which make it unusable for certain applications:

No checksums! NPM shrinkwrap does not guarantee bit-wise equality of the installed
dependencies, so if an upstream server or author decides to change the contents of
version 1.2.3 of foo, you'll install something different than you intended without
knowing.
Does not play nice with optionalDependencies - If you "shrinkwrap" your app and you
have an installed dep that is optional, the dependency is no longer optional.  This might
not be what you want.

How are we doing with those, especially optionalDependencies? I consider my problem solved, but just curious for the future.

optionalDependencies are not a thing. You shrinkwrap applications.
Your application does not have optional dependencies.
As for the checksums; yep we dont have any checksums. We just assume our internal mirror is not corrupted. We have not had any issues yet.


Patch 1

What this PR does / why we need it:
I noticed that we could not create a release named "fluentd-elasticsearch" instead we would get "fluentd-elasticsearch-fluentd-elasticsearch". Also I noticed that the value for the app label was the fullname, rather than just name (e.g. release-name-fluentd-elasticsearch, this was due to "fluentd-elasticsearch.fullname" being used instead of fluentd-elasticsearch.name as label value.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
- [ ] Variables are documented in the README.md n/a

Ugh something weird happened , there are changes by another author in another chart in my PR i'll close it and open a new one...


Feature addition: navigator.mediaCapabilities.decodingInfo()

MediaCapabilities "decodingInfo()" API builds on HTMLMediaElement.canPlayType() to better surface what types of media the UA can play. The APIs responses describe when a given resolution, framerate, codec, etc... will perform well (smoothly) on the device and when the playback is power efficient (either hw accelerated decoding or a resolution low enough that sw is also comparably considered efficient).
The MediaCapabilities spec is being incubated here. The spec describes more than just the decodingInfo() API, but at this time only decodingInfo() is live in Chrome.
navigator.mediaCapabilities.decodingInfo() was first released in Chrome 66.
https://www.chromestatus.com/feature/5869632707624960
Coding samples:
https://googlechrome.github.io/samples/media-capabilities/decoding-info.html
https://beaufortfrancois.github.io/sandbox/media-capabilities/decoding-info-2.html

+1
https://developer.apple.com/documentation/safari_release_notes/safari_13_beta_release_notes

Added support for the decodingInfo() method of the Media Capabilities API for checking supported codecs, efficiently supported codecs, and optional codec features including alpha.

Available via MDN: https://caniuse.com/mdn-api_mediacapabilities_decodinginfo


Space between logos/flags and text

It was bugging me that the logos and flags were smashed against the text. This changes all the ones I found except the country list. That page draws them in separate cells and the code looks to nice to go messing with just to make things match.

woot! hey sorry I have somehow missed this PR, will approve and merge once after review!
Many thanks for the code contribution again ✈


signinRedirect() vs signinSilent() for automatic login

hello,
as I understand from docs and issue responses, signinRedirect() should be used to automatically login the app, e.g. after revisiting the url.
furthermore, I understand that signinSilent() is handled by the library.
however, I wonder why signinSilent() shouldn't be used for automatic login. I think it is better if the app tries to login in the background and if that fails, the app stays in the logged-out state and presents the user with a login button which will call signinRedirect().
this would prevent the app from instantly redirecting to the oauth provider, with no option for the user to "cancel" the login and just go back to the app without logging in. it also removes the redirect "flashes", in case the login goes through automatically.
I wonder if this use-case is currently possible without custom code?
I came up with some implementation myself, wondering if it is correct and if there is maybe an already supported, official, easier way.
bonus: I want to sync the logged-in state/access token with my redux store.
this is what I came up with:
export default function App() {
  const auth = useAuth();
  const dispatch = useDispatch();
  const [loginAttempted, setLoginAttempted] = useState(false);
  const loggedIn = useSelector(selectLoggedIn);

  // always try to silently login once via auth code grant with PKCE or refresh token grant
  useEffect(() => {
    if (
      !loginAttempted &&
      !hasAuthParams() &&
      !auth.isAuthenticated &&
      !auth.activeNavigator &&
      !auth.isLoading &&
      !auth.error  // <--- this part is missing in the docs (?)
    ) {
      setLoginAttempted(true);
      auth.signinSilent();
    }
  }, [auth, loginAttempted]);

  // handle login attempt errors
  useEffect(() => {
    if (!auth.error) {
      return;
    }

    if (
      (auth.error instanceof ErrorResponse) &&
      [  // as per https://openid.net/specs/openid-connect-core-1_0.html#AuthError
        'interaction_required',
        'login_required',
        'account_selection_required',
        'consent_required',
      ].includes(auth.error.error)
    ) {
      // oauth provider needs some form of end-user interaction,
      // due to not being logged in, or similar reasons
      // => not a real error => ignore error so user can proceed to click "login" manually
      return;
    }

    // otherwise: report error to user
    dispatch(setError(auth.error));
  }, [dispatch, auth.error]);

  // sync access token with redux
  useEffect(() => {
    const token = auth.isAuthenticated ? auth.user.access_token : null;
    // if null, loggedIn in the redux state gets set to false as well
    dispatch(setToken(token));
  }, [dispatch, auth.isAuthenticated, auth.user]);

  // do some api calls
  useEffect(() => {
    if (!loggedIn) {
      return;
    }

    // do calls to protected apis with token from redux store
    // ...
  }
}

is this a correct implementation?

hi @pamapa,
thanks for your feedback!
does that mean that your app doesn't use the refresh token, in case the access token is expired, when revisiting the app, forcing the user to re-login?
I forgot to mention that in my question, but another requirement is that the refresh token should be used, as a "fallback", if possible.

I am trying to not use the refresh token, in case the user authenticated before, the authz server will set a session cookie, which then automates the normal login like using a refresh token...

Your solution seems to be better. I don't understand the official documentation here.
Why does here exists this part:
  React.useEffect(() => {
        if (!hasAuthParams() &&
            !auth.isAuthenticated && !auth.activeNavigator && !auth.isLoading &&
            !hasTriedSignin
        ) {
            auth.signinRedirect();
            setHasTriedSignin(true);
        }
    }, [auth, hasTriedSignin]);
    ```
    Is `hasTriedSignin` every true here? If it is set to true I was redirected before to a different website. So I lose all my react states. Then I get a redirection back.
    1. Why should `setHasTriedSignin(true);` was executed, which cleary is placed after the  `auth.signinRedirect();`
    2. Why the state should be stored even after I routed to a different website and then back?

hi @Tockra,
I think the code you showed is wrong, for the reasons you mentioned.
would be interesting to get some feedback from @pamapa, if this is really a bug in the documentation.

@Tockra and @pseidemann I agree with you, this is a bug in the documentation, would be nice if you could update this. BTW: I am think if it would not be better to have that within the library itself? Notice that i am not using automatic login with my applications...

it would be nice to have this in the library, especially the auth error handling I did (the effect with the // handle login attempt errors comment)

Okay after overthinking it, I'm sure that the purpose of @pseidemann codesnippet and the code snippet from the documentation I posted is different:
React.useEffect(() => {
        if (!hasAuthParams() &&
            !auth.isAuthenticated && !auth.activeNavigator && !auth.isLoading &&
            !hasTriedSignin
        ) {
            auth.signinRedirect();
            setHasTriedSignin(true);
        }
    }, [auth, hasTriedSignin]);

The documentation aims to root yourself to the login page if you are not logged in.
This happens automatically. I think the hasTriedSignin is maybe not necessary, because it only assures that the login does not happen twice. If there is no internal behavior I don't see, I see no reason why it should happen twice if there is no auth.error.
If the login page isn't there then you end in a login loop. So an if(!auth.err) check could an alternate.
So (MAYBE) if I understand everything right the documentation could become rid of hasTriedSignin and should anyways add (!auth.err).
But the code in the documentation has a different purpose than @pseidemann code.
This loggs you in if you are not logged in before but if you are already logged into your login provider (login page redirects you immediatly back).


Add an "invert" checkbox for each dweet

Some dweets would look better inverted - white on black demos often seem more natural than the black on white default.
Add a checkbox that says "Invert" that would apply the inversion filter on a dweet.
Let the the author choose its default value for that dweet when submitting.
The viewer can switch it if they want.
This adds some aesthetic variation for dweets that cant afford the bytes to invert.

It is possible to change the background yourself with JS.


New version: Microsoft.WindowsAppRuntime.1.5 version 1.5.2

Pull request has been created with komac v2.2.0 :rocket:

Resolves #150374

Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！


Feed stories

Hi,
I would like to get the list of stories of my following, like the top row on your instagram feed.
How can i get to that?
Sorry i know this isnt a bug but im a bit lost in the docs atm.
Thank you!

found it :)


[BUG][WCAG] requests/new - No keyboard accessibility on menu or notification drawers.

Describe the bug
There is no keyboard functionality on the Menu or Notification drawers.
Keyboard functionality and navigation is essential to those using speech-to-text command, among other accessibility technologies.
Users are incapable of navigation or option selecting without the use of a mouse. The tab function continues to cycle through the requests/new options under the drawer.
Please note that this is one of the only compliance guidelines that has 0 exceptions or levels.
https://reach4help-staging-web-client.firebaseapp.com/requests/new
To Reproduce
Steps to reproduce the behavior:

Navigate to /requests/new page,
Tab through or click the Menu button.
Attempt to tab through the Menu drawer and notice that there is no focus indicator, or functionality.
Close the drawer, and attempt the same with the Notification drawer. Notice that the same issue occurs.

Expected behavior
User is able to navigate and interact with every part of the page, including drawers, using universal keyboard key-strokes.
Desktop (please complete the following information):
Windows 10 - Chrome
Additional context
https://www.w3.org/WAI/WCAG21/quickref/#keyboard-accessible

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

Winggo

Adding a comment, as it seems that the Keyboard navigation has been implemented, but theres an issue when the user want to navigate in the Menu.
The user can navigate, but he cant see where the cursor is pointing.  He can see some location, but only because the url is shown at the bottom, and its only for a few section.

We should see the section highlighted, like when we pass the cursor over.

@PhilArsHermit We actually made no specific changes to the code to address Keyboard navigation.  The reason why the Keyboard navigation is working is that we are writing our markup the right way and the markup automatically takes care of keyboard navigation.  That said, I have never been entrely clear what you mean by "Keyboard Navigation" or how you are testing for it.
@sabind @ashwinkjoseph

A simple way to test it, is with a Volunteer, click on the Map icon.  The section is then highlighted in purple, and then you can navigate by pressing "Tab" to go forward, or  "Shift"Tab" to go backward.


updated use of property generator

Moved the property generator argument to the verification context to update the notebook according to the architecture change

checked and accepted


Add build badges

Description
Add build badges
Related Issue

How Has This Been Tested?
CI
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] Other

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   94.04%   94.04%
=======================================
  Files           3        3
  Lines         168      168
  Branches       15       15
=======================================
  Hits          158      158
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6a60c...c5755a6. Read the comment docs.


Dynamic prompts, combinatorial repeats itself generation to generation, never randomizes

Turn on combinatorial
Generate 32 images
Dynamic prompts chooses your last dynamic prompt, and goes to all of the iterations for that alphabetically
as it does that it goes through the iterations of your second to the last dynamic prompt.
And because it goes through those alphabetically anytime you have combinatorial on you start over with each new generation, it produces exactly the same stuff. That's a problem. I'm going to write up an issue.
Desired behavior would be that when combinatorial is on, it's still randomizes its choices image to image, but it goes through all of the choices in accordance with the concept of combinatorial.

Not the same, but related to this issue: https://github.com/adieyal/sd-dynamic-prompts/issues/530

Actually a duplicate of https://github.com/adieyal/sd-dynamic-prompts/issues/328


[fix][client] Add support for loading non-serializable properties with ConsumerBuilder::loadConf

Motivation
Currently ConsumerBuilder::loadConf resets non-serializable of ConsumerConfigurationData to null.
It would be useful that ConsumerBuilder::loadConf supports loading non-serializable fields.
An alternative is to not modify fields not present in the property map in ConfigurationDataUtils::loadData as proposed by https://github.com/apache/pulsar/pull/13298 . This PR is for discussion.
Modifications
In ConsumerBuilder::loadConf, save values for each non-serializable property and apply it after calling ConfigurationDataUtils::loadData
Verifying this change

[ ] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

Run ConsumerBuilderImplTest::testLoadConf and ConsumerBuilderImplTest::testLoadConfNotModified

Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/cbornet/pulsar/pull/7

Codecov Report

Merging #18344 (4b6b973) into master (67d9d63) will decrease coverage by 3.56%.
The diff coverage is 96.77%.

@@             Coverage Diff              @@
##             master   #18344      +/-   ##
============================================
- Coverage     40.29%   36.73%   -3.57%
+ Complexity     8685     1938    -6747
============================================
  Files           687      208     -479
  Lines         67441    14410   -53031
  Branches       7225     1571    -5654
============================================
- Hits          27175     5293   -21882
+ Misses        37257     8537   -28720
+ Partials       3009      580    -2429

Flag
Coverage Δ

unittests
36.73% <96.77%> (-3.57%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../transaction/TransactionCoordinatorClientImpl.java
0.00% <0.00%> (ø)

...apache/pulsar/client/impl/ConsumerBuilderImpl.java
43.02% <100.00%> (+43.02%)
:arrow_up:

...che/bookkeeper/mledger/impl/ManagedCursorImpl.java

...rg/apache/bookkeeper/mledger/impl/OpReadEntry.java

...va/org/apache/bookkeeper/mledger/util/Futures.java

...broker/delayed/InMemoryDelayedDeliveryTracker.java

...sistent/PersistentDispatcherMultipleConsumers.java

...he/pulsar/broker/service/AbstractSubscription.java

...he/bookkeeper/mledger/offload/OffloadersCache.java

.../apache/bookkeeper/mledger/util/CallbackMutex.java

... and 633 more


layers: meta-freescale: use dunfell-fix-gtk branch

This is the commit we need to use and the one that matches .gitmodules.
Without this, gdk doesn't build its x11 support, which is all our
version of chromium from electron 13 can use, and doesn't work.

This works on a device (though the app moves on to some js stack errors, it no longer crashes because gtk doesn't have its x11 backend).


Make Vec* methods const

What problem does this solve or what need does it fill?
I'd like to use Vec2 in a static declaration, but that's currently not possible.
What solution would you like?
Make Vec* methods const.

This is not possible as Vec2 takes floats, and floats can't be const...
However, there is a macro const_vec2 that does that 🙂

Very reasonable. This is fundamentally blocked on float math being usable in const functions. Once that's in, I expect glam to rapidly migrate away from the mentioned macros.

Floats can't be const? TIL, though I guess that makes sense if a machine doesn't adhere to 754.

Actually, are you sure? This compiles just fine for me:
#[derive(Debug)]
struct Blah(f32, f32);

const BLAH: Blah = foo(1., 2.);

const fn foo(blah: f32, boo: f32) -> Blah {
    Blah(blah, boo)
}

pub fn use_it() {
    println!("{:?}", BLAH);
}

const fn add_two() -> f32 {
  2. + 2.
}

This should fail to compile :( Here's the Rust issue: https://github.com/rust-lang/rust/issues/57241

Hmmm, all I'd want is Vec2::new. Would it be reasonable to only allow construction? Or is there some extra magic happening that would prevent that?

That's ultimately a question for upstream. Maybe try it out in a glam fork?

Hmmm, all I'd want is Vec2::new.

If you just want that in a const context, the macro should work for you?

Good point, I guess I'll just use the macro though it seems weird to require that.

Closing out, although once the linked glam issue is resolved I'll be thrilled to be able to migrate.


Add ZFS replication metrics

This PR adds replication metrics as requested in issue #112.

Replication Metrics are fetched per node
The metrics can be enabled or disabled

I reworked the original PR #166 to the new file structure.

Hi, thanks for filing this PR. It makes sense to scrape the replications per node, so code location, naming and overall approach is correct.
I'm not too happy with the metric structure though. This project follows the common practice of exposing an X_info gauge with a complete set of labels. The actual metrics only have an id label. The following excerpt from the metrics example in the readme demonstrates the approach nicely:
# HELP pve_uptime_seconds Number of seconds since the last boot
# TYPE pve_uptime_seconds gauge
pve_uptime_seconds{id="qemu/100"} 315039.0
[...]
# HELP pve_guest_info VM/CT info
# TYPE pve_guest_info gauge
pve_guest_info{id="qemu/100",name="samplevm1",node="proxmox",type="qemu"} 1.0

Also, it would be great if the guest, source and target labels would follow the same pattern (i.e., {type}/{id}). This does simplify joining the new metrics to other time series. I'm not sure whether the id should be changed as well. This could be interesting in combination with a pve_up metric. I.e., if there is a way to determine whether a replication job is up (if there is a useful definition of up), then it could be interesting to emit pve_up{id="replication/1-0"} 1 with the same {type}/{id} pattern in order to avoid conflicts with other time series.
Finally, there is a best practice document by prometheus about metric and label naming. Metric names ... should have a suffix describing the unit, in plural form. Note that an accumulating count has total as a suffix, in addition to the unit if applicable.
Thus, I'd expect a similar structure from the replication metrics.
    # HELP pve_replication_info Proxmox vm replication duration
    # TYPE pve_replication_info gauge
    pve_replication_info{id="1-0",guest="qemu/1",source="node/proxmox1",target="node/proxmox2",type="local"} 1

    # HELP pve_replication_duration_seconds Proxmox vm replication duration
    # TYPE pve_replication_duration_seconds gauge
    pve_replication_duration_seconds{id="1-0"} 7.73584
    # HELP pve_replication_last_sync_timestamp_seconds Proxmox vm replication last_sync
    # TYPE pve_replication_last_sync_timestamp_seconds gauge
    pve_replication_last_sync_timestamp_seconds{id="1-0"} 1.713382503e+09
    # HELP pve_replication_last_try_timestamp_seconds Proxmox vm replication last_try
    # TYPE pve_replication_last_try_timestamp_seconds gauge
    pve_replication_last_try_timestamp_seconds{id="1-0"} 1.713382503e+09
    # HELP pve_replication_next_sync_timestamp_seconds Proxmox vm replication next_sync
    # TYPE pve_replication_next_sync_timestamp_seconds gauge
    pve_replication_next_sync_timestamp_seconds{id="1-0"} 1.7134689e+09
    # HELP pve_replication_failures_total Proxmox vm replication fail_count
    # TYPE pve_replication_failures_total gauge
    pve_replication_failures_total{id="1-0"} 0.0

Thank you for the review.
I have updated the following points:

metric naming
added info metric with labels (source,target,guest) in {type}/{id} format
remove unnecessary labels from other metrics
Added pve_up metric for replication jobs

Replication Jobs in Proxmox can be enabled or disabled.
The Proxomx API will return disabled: 1 is the replication job is disabled and nothing if the status is enabled.
Based on this I am currently setting the pve_up value.
I have left the id to be the replication id from the Proxmox API.
This value is unique in a cluster and a single VM can have multiple replication jobs, therefore we cannot use the qemu/lxc id.

Cool! Thanks a lot for this update. I have to confess, that I do not yet fully grasp the data model of the PVE API regarding replication jobs. I neither have access to a cluster where I could take a look myself. Thus, please bear with me a little bit while I'm putting together a mental model for it.
According to the commits in this PR and the API docs, there are two different API routes where information about replication jobs can be gathered:

nodes/{node}/replication/{id}/status
cluster/replication/{id}

Regrettably, the API docs do not specify the structure of the returned data. Thus I took a look at the respective admin ui sections in my cluster. It looks like the interesting metrics (i.e., the various timestamps) are only available from the node-endpoint. The cluster endpoint only lists configuration values and no state. If that observation is correct, then scraping the state from nodes is certainly the best option we have.
The current PR seems to scrape the pve_up metric from cluster resources. Hence, people running separate scrape jobs for node and cluster metrics end up scraping replication related stuff in two places. I fear that might lead to surprises. Also basing the pve_up metric on the enabled flag doesn't mix well with the other definitions of pve_up (i.e., vm running, container running, node running). People are using pve_up metric for alerting purposes. Alerting on the basis of a configurable value (enabled/disabled) doesn't seem very useful to me. Thus, let's drop the pve_up metric for replication jobs unless there is a more useful data source for its value.

The PVE docs state:

If a replication job encounters problems, it is placed in an error state. In this state, the configured replication intervals get suspended temporarily.

I think that would be a good data source for pve_up if the error state is available from the nodes/{node}/replication/{id}/status endpoint.

According to the pve source code, there is a chance that a failed job contains an error key in the state object. The value seems to be a textual representation of the error.
On the other hand, the code also indicates that fail_count is reset to zero after a job has recovered. As a result, it is easy to define an alerting rule using the following expression: pve_replication_failures_total != 0. But that indicates that the _total suffix isn't exactly correct here.

According to this blog post, the _count and _total suffixes shouldn't be used for gauges. Browsing through my metrics, I found one which seems to behave quite similar to fail_count: alertmanager_cluster_failed_peers:

This metric is a gauge that shows you the current number of failed peers.

So, I guess we could rename pve_replication_failures_total to pve_replication_failed_syncs. I feel that this name naturally hints towards an alerting condition of pve_replication_failed_syncs!=0.

I pushed my proposed changes. @svengerber is that usable in your case?

@znerol
Thank you for the updates!
I have tested them against our cluster with replication jobs and it looks good.
In our case we are be monitoring agains replication failures and successfull syncs, so these metrics will work for us.

Perfect. Did you ever experience replication failures? Do you think the assumption is correct that fail_count is reset to zero after a replication job recovers?

I have tested this in our environment and the fail_count will go back to 0 after a successfull replication.
Example return data after a sync failure:
        "fail_count": 1,
        "schedule": "XX:XX",
        "id": "1-0",
        "type": "local",
        "last_try": X,
        "jobnum": 0,
        "rate": 500,
        "guest": 1,
        "vmtype": "qemu",
        "source": "XXX",
        "next_sync": 0,
        "error": "command '/usr/bin/ssh -e none -o 'BatchMode=yes' -o 'HostKeyAlias=XXX'<EMAIL_ADDRESS>pvecm mtunnel -migration_network X.X.X.X/X -get_migration_ip' failed: exit code 255",
        "duration": 2.24147,
        "target": "XXX",
        "last_sync": XXXX

@znerol
Thank you for the update.
I have tested your changes against my clusters with replication enabled and it looks good.


The azd version in the github pipeline does not support the azd login --client-id parameter.

Describe the issue:
The azd version in the github pipeline does not support the azd login --client-id parameter when execute azd pipeline config.
Repro Steps:

Execute command: bash ./test-templates.sh -c false -t Azure-Samples/todo-nodejs-mongo -b pr/1129 -s ***.
Run: azd pipeline config.
Click on the link that is printed to open the actions page and you will see:

Environment:
OS: WSL, MacOS desktop, Windows desktop, Linux desktop
Template: https://github.com/azure-samples/todo-nodejs-mongo
Azd version: 0.4.0-beta.1-pr.1982037 (commit https://github.com/Azure/azure-dev/commit/0cb9c7c50e1fcdd8b0821587548e8c2a57023666)
Branch: pr/1129
With Az CLI and Without Az CLI
Expected behavior:
Action logs can pass successfully.
@rajeshkamal5050 for notification.

@ellismg @vhvb1989 can you triage if this is a generic pipeline issue or anything w.r.t to the azd authn changes?
Note: this failure was on the PR branch https://github.com/Azure/azure-dev/pull/1129

I suspect the problem here is that the pipeline references the currently shipped version of the container that has azd in it:
https://github.com/Azure-Samples/todo-nodejs-mongo/blob/1b9bca5f3d9ef91ef5550d3fa0397d4eba119a09/.github/workflows/azure-dev.yml#L20-L21
But this has not been updated to include the version of azd that uses our own authentication.
C:\dd\azure\azure-dev>docker run --rm -it mcr.microsoft.com/azure-dev-cli-apps:latest azd version
azd version 0.4.0-beta.1 (commit 2bf7a529914d86d8e9f5d7b6f95a4f20a2351e01)

We have a published version of the container in the PR with this name: azdevcliextacr.azurecr.io/azure-dev:pr-1129
For testing purposes, we should either modify the azure-dev.yml pipeline in the test repository to reference this image, or alternately add an additional step to the pipeline that does this:
      - name: Install Private AZD
        run: |
          curl -fsSL https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1129/install-azd.sh | bash -s -- --base-url https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1129 --version '' --verbose

To install the private bits.

@zedy-wj please use the bits and templates from PR #1153 for fix-verification and closure.

I opened https://github.com/Azure/azure-dev/pull/1153 which includes the changes from #1129 and makes changes to the templates to depended on the private bits in the pipeline.  We should be able to re-do this testing, but use a gesture like:
azd init -t Azure-Samples/todo-nodejs-mongo -b pr/1153

When initializing the test repository, and this will pick up these changes.

I confirmed manually that this has been fixed when using the payload from https://github.com/Azure/azure-dev/pull/1153

@ellismg - For the following two methods, do you plan to prepare for PR：

Modify the azure-dev.yml pipeline in the test repository to reference this image.
Add an additional step to the pipeline.

Currently our tests use the second method to install the latest daily version of azd. Do we always need to add this additional
step manually?

@ellismg  Any ideas？

Currently our tests use the second method to install the latest daily version of azd.

We need to keep doing this until the next azd release.
Once the release is out, the azd version in github pipeline will have the support.


[Fantastical] Something went wrong when adding event

Extension
https://www.raycast.com/devahschaefers/fantastical
Description
Error:
Error: Command failed with exit code 1: osascript -e
        tell application "Fantastical"

 parse sentence "Sunday 11-15 "Fred in London with Bob""

        end tell
78:82: syntax error: Expected end of line, etc. but found identifier. (-2741)

        tell application "Fantastical"

 parse sentence "Sunday 11-15 "Fred in London with Bob""

Steps To Reproduce
on MacOS Add event (or add event quickly - same error)
Enter value Sunday 11-15 "Fred in London with Bob"
Throws an error. If you select Reload, fantastical opens with an undefined event for today

Current Behaviour
It doesn't work
Expected Behaviour
It should work

@raycastbot assign me


CORE-2541 - added support for registering a change exec listener class on command…

… line, as well as injecting Database and/or Properties into the listener

Thanks. I merged in the change, but into master for 3.5 since I try to keep the 3.4.x releases as minor patch releases.
I also changed ChangeExecListenerAdapter to AbstractChangeExecListener and made it abstract to better match the naming of similar patterns in the codebase.


Missing charges from parmbsc1 from DT3 residue

DT3 is apparently missing charges in the residue definition. Unfortunate, but easy to fix plus Gromacs should spit out an error for the missing charges, so no incorrect simulations.

solved with #200


Rename input to sos_input?

It occurs to me that we should rename our input to sos_input, output to sos_output, and depends to sos_depends. _input etc can be kept unchanged.
The reason is simple, input, output are too common. input is a built-in function and output is a common name, so it is very likely they will be used by users, and cause surprises. At least for now,
input('a')

in a SoS kernel and python3 kernel will behave differently,
This will be a big change and will force us to change many documentations and re-record multiple videos, not sure if there can be a walkaround for it.

A semi-walkaround and a way to simplify logic is to deprecate input etc and always advertise _input....

Is it possible to improve the parser so that input: is properly handled, and in different way as input('a')? input and output is much more readable than any other syntax.

It is not about parser, it is about the existence of the input variable in sos_dict which overwrites the system input. Basically, one cannot use input and output in SoS script, and in SoS Notebook because they are manipulated by SoS in the background.
input is indeed much more readable but in the end, _input should be used in the majority of the cases (same for output and _output) so renaming it can have added benefit of less confusion on the seemingly equivalence between input and _input.

BTW, I am not suggesting the use of
sos_input: 'a.txt'

This is still be
input: 'a.txt'

But the variables produced by the input: statement will be called sos_input and _input.
sh: expand

I see. But will {input} become {sos_input} in scripts? That'd also be inconvenient.

Yes, but in the majority of such cases you only need to change {input} to {_input}.

Agreed about the "majority" claim, though I have had situation when the entire {input} and the particular iteration {_input} are both used.
BTW, snakemake decides to use input as is:
http://snakemake.readthedocs.io/en/stable/snakefiles/rules.html#wildcards

Does snakemake have input group (_input)?
Our situation is completely different from snakemake in that SoS is derived from Python and users are free to write big trunks of Python code and SoS Notebook can behave just like a Python3 kernel, so having input and output in the way is a problem.
Another consideration is that we are aiming to be the "default" kernel for JupyterLab and even Jupyter so the SoS kernel should be as close to a regular Python3 kernel as possible. The better we "hide" the SoS part of SoS Notebook, the easier it could be adopted.

Of course input has its place so I am replacing but not removing it. I actually have made several mistakes when using something like
output: `{input:n}.bai`

which works ok for
input: 'a.txt'

but failed for
input: '*.txt', group_by=1

and the failure was not immediately clear to me because of the tiny difference between input and _input. Encouraging the use of _input and having a larger difference between input and _input should help avoid such problems.

My understanding is that for make-style there is no such concept as input group. snakemake also allows for putting in chunks of Python codes, at least in principle, though of course is already limited in many ways compared to SoS.
But your latest post is more convincing. So something has to be done here. Currently the use of _ is for input group. For example
parameter: replicate = [1,2,3]
...
bash:
  echo ${_replicate}
  echo ${replicate}

distinction between those 2 commands is very clear. It feels like we will have fix a name conflict issue by abusing the _ notation or change its concept. It is something to process at least for me ...

I do not think we are abusing the _ notation because _input is the input of input groups, which is only  equivalent to input when there is only one group. I understand "normal" users might not use input group but then they might be confused with the two and use input everywhere until they run into the problem I showed. Enforcing the use of _input will help reduce such confusions and renaming input to sos_input happens to help the enforcement.

In that case, will we allow _replicate be replicate when there is only one input group? Will _replicate always be recommended over replicate? I said we "abuse" notation because to me at least in this case we are discriminating cases when _ is used.
Also not sure if you want sos_input or step_input: I'm under the impression that we have things like step_name reserved. Maybe it is time to make such variable naming convention consistent?

Yes, step_input is a lot clearer than sos_input, let us use step_input.''
The case for replicate and _replicate is similar but because they are used intentionally with input groups (to to create input group), there is far less a chance to make mistakes like input.

Feels really guilty to introduce this kind of incompatible change. If we have some more man power, we should strive to keep backward compatibility.


rtsp error

When I pasted the rtsp url and tried to run on a VLC media player on another system, It is not displaying the faces but the time is progressing what could be the reason for that?
It is sometimes showing me an error message as follows.

it was happening to me until I found  the correct IP address to broadcast, i used ifconfig in Terminal then I tested one by one each possible IP address

Hello @dihitha, as @RunningModelsUntilDawn mentions, it could be that the IP of your jetson nano is incorrect (how are you getting it?). You may try running ping <IP_ADDRESS> to check that the device is reachable.
If the device is reachable, maybe your router is blocking traffic through port 8554? Are you in your home or a company network?


Set correct minimum reverb delay value

Reverb delay currently validates from 0, but the smallest allowed value is 10ms.
Fix the validator to account for that.

Whoops, fixed this already in #549bf4f


Use web.run_app() in getting started server example

Would you convert README as well?

Done

Thanks!


Compilation error

When I tried to compile, it says:
Compilation error: Missing "" library.

What can I not do?

did you try including ""?

nope. but i've tried:
import { } from ''

with no success :(

pip install ""
problem solved

Your problem is: you try to compile it with specific compiler. Try no compiler.
Here is the example:

Oh god, thanks man, I'm so stupid.... It works now!
brice@brice:~$ ./nodecode

brice@brice:~$


fix: issue in inventory service

The changes are ready to be reviewed via fix.demo.apps.cluster-qqgjd.qqgjd.sandbox474.opentlc.com


Fix Issue 17154 – Add opDollar to std.conv.toChars

Auto-merge toggled on

In the future, please use more descriptive branch names than patch-2 which gives no clue what it is about. For example, see https://auto-tester.puremagic.com/pulls.ghtml?projectid=1


Adding WebView2 Unity Plugin API Reference

Adding API Reference documentation for the Mixed Reality WebView2 Unity plugin.
AB#44573261

We need to add a note indicating the plugin is in preview and is subject to change.


Export data to CSV for Admin

4/8 Friday Deadline
Please review with Meredith when done
There's a few places where we have an "Export" button for an admin to export data to a CSV file. Please implement these buttons to actually export the relevant data.
These Pages are:

Area Management
Area Details
Site-specific

/cib export-data-to-csv

Branch 89-export-data-to-csv created!

/cib export-data-to-csv-new

Branch 89-export-data-to-csv-new created!


Delay to open a store procedure

SQL Operations Studio Version: sqlops 0.23.6 (8a3011756318a2ded1e6e84332230a2b2bf9c544, 2017-11-06T21:51:43.232Z)
OS Version: Windows_NT x64 6.3.9600

Steps to Reproduce:

Click in a proc with right side of mouse
Select as "Script as Create"

This operation take a long time to complete, more than when I used SQL Management.
I don't know if is normal but it's a suggestion for fix in next releases.
Regards,

Had the same issue as well...

@gabcastro @GabrielBarriosT  This issue is under investigation currently.

This is a duplicate of #115


feat: experience validator [SPA-1700]

Purpose
Add new package for schema validations of experiences/patterns. Main purpose of the validators is to be used in CMA to validate experience entries upon save. This is also the reason for implementing this into a separate package and not into the core package. We want to keep this as lightweight as possible to avoid unnecessary dependencies being brought into content_api.
Approach
A new package @contentful/experiences-validators is introduced. The package file structures looks like this:
src
|-> schemas
|    |-> version1
|    |   |-> experience.ts
|    |-> version2
|    |   |-> experience.ts
|.   |-> latest.ts
|-> validator.ts
|-> index.ts
|-> types.ts

validator.ts exports the main validation function that is responsible for applying the correct schema validator based on the schemaVersion of the experience entry.
schema/<schema_version>/experience.ts defines the experience schema for each version.
schemas/latest.ts is an alias for the latest version. Currently 2023-09-28.
Types of the basic data structures, e.g. unboundValues, breakpoints, etc are inferred by the Zod schema and exported from types.ts. Currently only the types of the latest version are exported. If in the future we are going to need types of multiple versions we can expose them here as needed.
v2023_09_01 validations
Schema validation for the latest schema version can be found in packages/validators/src/schemas/v2023_09_28/experience.ts
New types
Duplicate types has been removed from packages/core/types.ts and replaced with imports from packages/validators. core package is then reexporting those types with their old names to avoid breaking changes with renamings. (Although we should at some point remove use of composition term)

@Chaoste @DanweDE thank you for the review, I believe I have addressed all the comments, so feel free to have another look.


[Checkbox] Missing property defaultChecked

Hi, maybe need to add the defaultChecked property as defaultValue. If not set checked property, checkbox work uncontrolled mode. I see switch and onChange is triggered. With this logic is needed defaultChecked property.

@fast0490f Interesting, the prop is already supported, and we try to only list the custom props. We rely on two assumptions for developers to know:

We assume that developers know that undocumented props are spread to the native elements
We assume that developers know that defaultChecked is a native attribute

However, considering that we document checked developer could conclude that defaultChecked is not supported.

@fast0490f Interesting, the prop is already supported, and we try to only list the custom props. We rely on two assumptions for developers to know:

We assume that developers know that undocumented props are spread to the native elements
We assume that developers know that defaultChecked is a native attribute

However, considering that we document checked developer could conclude that defaultChecked is not supported.

However, considering that we document checked developer could conclude that defaultChecked is not supported.

I mean, this questions all of the external props we currently document. Happy to get rid of them if this is your argument.

However, considering that we document checked developer could conclude that defaultChecked is not supported.

I mean, this questions all of the external props we currently document. Happy to get rid of them if this is your argument.

@oliviertassinari i tested the property defaultChecked version 4.11.1.
Now I have upgraded material-ui
├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>
property also doesn't work

@oliviertassinari i tested the property defaultChecked version 4.11.1.
Now I have upgraded material-ui
├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>
property also doesn't work

Considering the tradeoff we have with the Switch:
https://github.com/mui-org/material-ui/blob/b071899deabdaebd4ccf4f7948a24d1ed33a1411/scripts/generateProptypes.ts#L115-L117
How about?
diff --git a/packages/material-ui/src/internal/SwitchBase.d.ts b/packages/material-ui/src/internal/SwitchBase.d.ts
index 08040c525e..e85fc6801e 100644
--- a/packages/material-ui/src/internal/SwitchBase.d.ts
+++ b/packages/material-ui/src/internal/SwitchBase.d.ts
@@ -19,6 +19,9 @@ export interface SwitchBaseProps
     disabled?: string;
     inpit?: string;
   };
+  /**
+   * The default checked state. Use when the component is not controlled.
+   */
   defaultChecked?: boolean;
   disabled?: boolean;
   /**
diff --git a/scripts/generateProptypes.ts b/scripts/generateProptypes.ts
index 0ec4d06f53..6fd3864937 100644
--- a/scripts/generateProptypes.ts
+++ b/scripts/generateProptypes.ts
@@ -112,6 +112,7 @@ const useExternalDocumentation: Record<string, '*' | string[]> = {
   MenuItem: ['dense'],
   OutlinedInput: useExternalPropsFromInputBase,
   Radio: ['disableRipple', 'id', 'inputProps', 'inputRef', 'required'],
+  Checkbox: ['defaultChecked'],
   Switch: [
     'checked',
     'defaultChecked',

Considering the tradeoff we have with the Switch:
https://github.com/mui-org/material-ui/blob/b071899deabdaebd4ccf4f7948a24d1ed33a1411/scripts/generateProptypes.ts#L115-L117
How about?
diff --git a/packages/material-ui/src/internal/SwitchBase.d.ts b/packages/material-ui/src/internal/SwitchBase.d.ts
index 08040c525e..e85fc6801e 100644
--- a/packages/material-ui/src/internal/SwitchBase.d.ts
+++ b/packages/material-ui/src/internal/SwitchBase.d.ts
@@ -19,6 +19,9 @@ export interface SwitchBaseProps
     disabled?: string;
     inpit?: string;
   };
+  /**
+   * The default checked state. Use when the component is not controlled.
+   */
   defaultChecked?: boolean;
   disabled?: boolean;
   /**
diff --git a/scripts/generateProptypes.ts b/scripts/generateProptypes.ts
index 0ec4d06f53..6fd3864937 100644
--- a/scripts/generateProptypes.ts
+++ b/scripts/generateProptypes.ts
@@ -112,6 +112,7 @@ const useExternalDocumentation: Record<string, '*' | string[]> = {
   MenuItem: ['dense'],
   OutlinedInput: useExternalPropsFromInputBase,
   Radio: ['disableRipple', 'id', 'inputProps', 'inputRef', 'required'],
+  Checkbox: ['defaultChecked'],
   Switch: [
     'checked',
     'defaultChecked',

property also doesn't work

@fast0490f It works, see the second component of the demo https://material-ui.com/components/checkboxes/#basic-checkboxes

property also doesn't work

@fast0490f It works, see the second component of the demo https://material-ui.com/components/checkboxes/#basic-checkboxes

Now checked my final base component, and i was wrong
my code
    <FormControlLabel
      defaultChecked={true}
      onChange={(e) => {}}
      control={<Checkbox color="primary" />}
      label=""
      labelPlacement=""
    />

Now checked my final base component, and i was wrong
my code
    <FormControlLabel
      defaultChecked={true}
      onChange={(e) => {}}
      control={<Checkbox color="primary" />}
      label=""
      labelPlacement=""
    />

I checked everything, it was my mistake. But the lack of mention of the property confused me.

I checked everything, it was my mistake. But the lack of mention of the property confused me.

@fast0490f Thanks for raising, I still think that you are not alone here. I have always found the React documentation poor on how to use the form components. I often find myself searching inside StackOverflow or Material-UI's demo to do simple tasks. It's close to the native DOM API, but not always. I would propose the above diff https://github.com/mui-org/material-ui/issues/24426#issuecomment-760929004
Ant Design and Chakra UI mentions it:

@fast0490f Thanks for raising, I still think that you are not alone here. I have always found the React documentation poor on how to use the form components. I often find myself searching inside StackOverflow or Material-UI's demo to do simple tasks. It's close to the native DOM API, but not always. I would propose the above diff https://github.com/mui-org/material-ui/issues/24426#issuecomment-760929004
Ant Design and Chakra UI mentions it:


Unable to import all columns data

Hi Frederic!
Thank you so much for the this easy to use script. I am facing an odd error with the data export - it is only exporting Impressions and Spends data though I have selected Outbound click, App Installs as well.

Also, any way to pre-define the language of the headers? It is auto inputting a regional language which I would want to change.

Hi Ayush,
Glad you find the script helpful!
Does anything change if under the FILTERING constant you replace link_clicks by outbound_click?
As far as languages go, you'll want to modify the url constant in the getFacebookReport() by adding a locale parameter.
For example, if you want the output to be in english, it would look like this: https://www.facebook.com/ads/ads_insights/export_report?report_run_id=${reportId}&format=csv&access_token=${TOKEN}&locale=en_US

Where to get the report ID?

Hi @ppcmaverick!
The report ID is the result of the request-facebook-report.js.
It's cached so that it can be passed on to get-facebook-report.js.


Add a 'Downloaded' Category

Describe your suggested feature
Add the option to include 'downloaded' category, where you can find all the mangas in any category that are downloaded. The category should not be deletable, but it can be turned on or off from settings.
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.16.5.
[X] I will fill out all of the requested information in this form.

... but what about just Filtering by Downloaded, or enabled "Downloaded only"?

... but what about just Filtering by Downloaded, or enabled "Downloaded only"?

Yeah, but I just thought it would be more convenient to add it as a category, similar to how in Kotatsu you can check all of the downloaded manga.

You can have entries in multiple categories, just have one category with all your stuff in addition to your usual organization ones, enable the Downloaded filter and voila, you have this magic functionality you wished for


Invalid GID produces top-level error and erases rest of response

Product
Hot Chocolate
Version
14.0.0-p.139
Link to minimal reproduction
https://github.com/ChilliCream/graphql-platform/pull/7345
Steps to reproduce
Run the test in https://github.com/ChilliCream/graphql-platform/pull/7345
What is expected?
I would expect the rest of the response (the unrelated field) to be present and a proper error that associates the error of the invalid Id to the field / argument where it happened:
{
 "errors": [
   {
     "message": "The node ID string has an invalid format.",
     "locations": [
       {
         "line": 2,
         "column": 8
       }
     ],
     "path": [
       "byId"
     ],
     "extensions": {
       "originalValue": "invalid"
     }
   }
 ],
 "data": {
   "byId": null,
   "unrelated": "value"
 }
}

What is actually happening?
A unassociated top-level error is raised without any data:
{
  "errors": [
    {
      "message": "The node ID string has an invalid format.",
      "extensions": {
        "originalValue": "invalid"
      }
    }
  ]
}

Relevant log output
No response
Additional context
No response

I also added another test that showcases that the error is raised even if the field is skipped. This seems veeeery unexpected.

Ran into the same issue.
Quite a slow down on tracking down errors. I also didnt' find any easy workaround to get a better error.
Wrapping the default IDSerializer throwing also results in the same behaviour


feat: enable continuous mode for status button

Use VSCode's built-in commands "testing.startContinuousRun" and "testing.stopContinuousRun" to toggle continuous mode for the Vitest status button.

The extension was rewritten from the ground up in #253.
There is no longer a status bar.


Host State different between 'Hosts' and 'host' perspective

ISSUE TYPE

Bug Report

COMPONENT NAME

UI

SUMMARY
The host has different State, as shown in the following picture:

However, both perspectives return State as 'Up' from the listHost command.
listhostsresponse	{…}
	count	1
	host	[…]
	0	{…}
	id	642415ff-6e31-45fb-8a25-e20a43ee5a21
	name	kvm
	state	Up
	type	Routing
	(...)

CLOUDSTACK VERSION

<IP_ADDRESS> release (RC1)

STEPS TO REPRODUCE

View perspectives Home > Infrastructure > Hosts and Home > Infrastructure > Hosts > hostname
For new features, show how the feature would be used.

EXPECTED RESULTS

Both perspectives with the same state.

ACTUAL RESULTS

State is Up and Unsecure at the same time.

Where does the "unsecure" state come from?

I'm am not sure if this is a bug or a desired behavior, but I got confused when saw different states.
In system.js we have:
if (host && host.hypervisor == "KVM" && host.state == 'Up' && host.details && host.details["secured"] != 'true') {
	items[idx].state = 'Unsecure';
}

This is intentional to show that a connection is Up but not secured by CA cert subsystem. There is a new button for kvm hosts to provision certificate i.e secure that host. If you want we can show Up in parenthesis.

@rhtyd got it, thanks. I am ok with the way it is, but it would be nice to have it documented (I would gladly help on the 4.11.1 documentation as well)

I think that @rhtyd's suggestion might help. We could use Up (unsecured) instead.

Up (unsecured) would be perfect!


add [PUB] downloads badge

Add a badge for PUB to show the downloads for Dart/Flutter packages and plugins.
Fix #10744.

@PyvesB and @chris48s let me know if any further changes are required.


Userdata limit of 16KB is almost reached

LaunchController userdata size is almost 16KB and starts to fail if few modifications added. We need to find another way topass userdata, such as s3 bucket.

I just bumped into this when trying to move my customizations from earlier versions of kube-aws to the new ones. The error message when that happens is not pretty as well:
$ ~/kube-aws up --s3-uri ...
Creating AWS resources. This should take around 5 minutes.
Error: Error creating cluster: Stack creation failed: CREATE_FAILED : The following resource(s) failed to create: [InstanceEtcd0, LaunchConfigurationController].

Printing the most recent failed stack events:
CREATE_FAILED AWS::CloudFormation::Stack kube-aws-test The following resource(s) failed to create: [InstanceEtcd0, LaunchConfigurationController].
CREATE_FAILED AWS::AutoScaling::LaunchConfiguration LaunchConfigurationController 1 validation error detected: Value 'H4sIAAAJbogA/+z9eZeq2JYoiv+fn4JfVN6b5/zcBiDYxXlxRwEi0ggI2FbW2INm0UgrnWJWfvc37CLU0IjYTZ66r6rMMXaGMNecc821Zrsa/8UM4sKqm3Fke84vZpyCOHv6BYKKxNJzsPsLglJgxHFez/JUz4FTPUEPsW0//AJBdqBHEQgOUF6Ug9TWTfAE/ZqkXqnn4KuXlPj+JchN6yuIrCT2ojx7gtw8T7InGPaSOorUd//hj5leB3qW19FHMw6TIgePe5SRHjw1sHb3FY+p214AniAY5CbsFwZII5CDDM6yADb1xwSEZ7Agze9D70DqZuCBKL9s5oPqU63qPqj2LXcii7w8e/plj6QORXoInqAM5HV9ndVBVHppHIU7QhlIS88EezgIApFu7AjlaXF6ZMZhqEfWE5TlepofH6ZFlHvhNWCUgyh/gv7j+ACC/m0cefm/v3ztgcxMvST34uhZBTlETFXojBeo1FNvRz+DvOjQ1ytuXzARdg7S5wjk6zj163EUeBF4zPXUAfkvr9TVQ99eGdCqBDzHEcjc+BWXAkLdi/YY6Y2XP591CYLoDTDVXcflFDzDhhfBeVyY7vvcvTR6hoss3bdK/XwnNOj3FyAIqteLwrPqu6GtZ3oJnuFST+G0iODDzIdNO6p7kZc/7uCumpZxUITg2YqyL74XWc9unOVfsrhITfC8Zy4FWRyUjztd+pIC3ZKioNr3DarXw7jYifsVxUF0bxrepqmvMxCVd8heyeSVtK0H2RvaR1Tn5K8QXLEQgXxP8+pxnhbZfvpndTuNw/peoy9gVoVePXrxSbT6OjMD7ynUsxykUL0OnWQN1cuLdgf8KXC8OIJejMJNkIMYIEEvItOl9jasSPXdbKfiKE/jIADpjYZZrps+tNPqvXLmIMsv1daKTR+kV5pqpXFS96KTip/Do0j90OQg6/1InlG9oafQW12FXrSs1NN64BlHnI97nBdgUz3Ks9tg

Calico seems to the "heaviest" extension in that regard, so I had to disable it in order to put my own customizations there.

I am preparing PR where user-data files are uploaded to same bucket where CF template is uploaded. Then userdata for hosts will be something like:
#!/bin/sh
set -ue

REGION=$(curl -s http://<IP_ADDRESS>/latest/dynamic/instance-identity/document | jq -r '.region')

/usr/bin/rkt run \
   --net=host \
   --volume=dns,kind=host,source=/etc/resolv.conf,readOnly=true --mount volume=dns,target=/etc/resolv.conf  \
   --volume=awsenv,kind=host,source=/var/run/coreos,readOnly=false --mount volume=awsenv,target=/var/run/coreos \
   --trust-keys-from-https \
   quay.io/coreos/awscli:master  -- aws s3 --region $REGION  cp s3://{{ .CFBucketPath }}/controller-userdata /var/run/coreos/

exec /usr/bin/coreos-cloudinit --from-file /var/run/coreos/controller-userdata

@redbaron are these S3 buckets intended to be all kube-aws launches, or per cluster, or per node-pool?
E.g. I notice the kube-aws up and kube-aws node-pools up seem to use the same file name for the stack.json file. I wondered if that means if you launch two node-pools at once you could inadvertently cross-pollinate the stack.json unless you use different buckets?
Likewise your example here for userdata is using a generic (not prefixed) filename. For controllers this might not matter, but for node-pool workers the data could be different, and launching two node pools at once could clash if the same bucket is used.
Do you think these S3 launch files should be prefixed with the cluster/node-pool names (or folder prefix maybe)? Or should users ensure a different bucket is used for each controller/node-pool launch in every cluster?

// I'm still scratching my head about it.
Hi @crawford, we'll probably migrate from coreos-cloudinit to ignition sooner or later and would you mind telling me if ignition could be enhanced to support:

reading files from a secured(!=not accessible from anonymous users) s3 bucket probably using contents.source or
reading additional configs from a secured s3 bucket probably using config.append[].source?

I'm asking this after reading:

https://groups.google.com/forum/#!topic/coreos-dev/PPInhPPqDsw
https://github.com/coreos/ignition/pull/183

--
Our problem is that cloud-configs for kube-aws are reaching to the limit of 16KB in size and the cloud-configs "may" contain sensitive data.
AFAIK the limit is coming from AWS so it would also affects us after we've migrated to ignition.
source in ignition config as of today doesn't seem to support authentication therefore I'm assuming we need to enhance it to support authentication or discover another work-around(e.g. a http proxy between s3 and ignition? 😛)
As kube-aws relying on coreos-cloudinit, we'll probably go ahead with the @redbaron's method summarized in https://github.com/coreos/kube-aws/issues/252#issuecomment-272850696 in short term but after the future transition to ignition, I began to believe we don't have a solution to work-around the limit.

Hey @mumoshu, I'm good. How are you? :smiley:

reading files from a secured(!=not accessible from anonymous users) s3 bucket probably using contents.source or
reading additional configs from a secured s3 bucket probably using config.append[].source?

I've been thinking about this a bit recently. I'm not sure just yet how I want to encode that information in the config and if it should even be there at all. In the mean time, you can use S3 Signed URLs to allow a specific machine access to a particular resource for a set period of time.

@crawford Fine but been busy these days 😄

I've been thinking about this a bit recently. I'm not sure just yet how I want to encode that information in the config and if it should even be there at all. In the mean time, you can use S3 Signed URLs to allow a specific machine access to a particular resource for a set period of time.

Thanks 👍
It sounds like a good idea but would you mind clarifying a bit?
Is there any way to add a "hook" which starts before ignition, so that we can dynamically create signed urls and then pass those to ignition or even dynamically create an ignition config?
I'm personally thinking that creating signed urls before the cluster creation wouldn't be a solution because then we'd certainly need to set very long expiration period for signed urls, which would be a security risk.
What we're going to have (thanks to @redbaron) for providing coreos-cloudinit a cloud-config read from S3 is something like:
#!/bin/bash",
# userdata hash: {{ .UserDataWorker | sha1 }},
. /etc/environment
export COREOS_PRIVATE_IPV4 COREOS_PRIVATE_IPV6 COREOS_PUBLIC_IPV4 COREOS_PUBLIC_IPV6
REGION=$(curl -s http://<IP_ADDRESS>/latest/dynamic/instance-identity/document | jq -r '.region')
USERDATA_FILE=userdata-worker
/usr/bin/rkt run \
   --net=host \
   --volume=dns,kind=host,source=/etc/resolv.conf,readOnly=true --mount volume=dns,target=/etc/resolv.conf  \
   --volume=awsenv,kind=host,source=/var/run/coreos,readOnly=false --mount volume=awsenv,target=/var/run/coreos \
   --trust-keys-from-https \
   {{.AWSCliImageRepo}}:{{.AWSCliTag}} -- aws s3 --region $REGION  cp {{ .S3URI }}/{{ .StackName }}/$USERDATA_FILE /var/run/coreos/
exec /usr/bin/coreos-cloudinit --from-file /var/run/coreos/$USERDATA_FILE

Is there any way to hook into ignition like this?

@mumoshu me too. Very very busy.

Is there any way to add a "hook" which starts before ignition, so that we can dynamically create signed urls and then pass those to ignition or even dynamically create an ignition config?

Glad you asked. This is actually how Ignition is intended to be used. We've been working on ct, which is a tool for generating Ignition configs from a human-friendly version. It is extremely simple right now, but we have plans for providing a whole lot of sugar to make common operations very easy.

I'm personally thinking that creating signed urls before the cluster creation wouldn't be a solution because then we'd certainly need to set very long expiration period for signed urls, which would be a security risk.

You could add a service to your config which purges the remote Ignition config before accepting work on the machine. That way, if a user downloaded the userdata, they would get a URL to the actual config that just 404'd.

What we're going to have (thanks to @redbaron) for providing coreos-cloudinit a cloud-config read from S3 is something like:

How does authentication work in this case? Are the secret and key exported before that script is run or are you using IAM roles? Instead of signed URLs, another option would be to use IAM roles to allow that one instance to access it's config. That might be easier to configure.

@crawford Thanks for your reply!

This is actually how Ignition is intended to be used. We've been working on ct, which is a tool for generating Ignition configs from a human-friendly version.

ct definitely seems to be useful! In the future, kube-aws will probably generate a ct config/golang text template for customization of node bootstrap process, instead of the current one; cloud-config/golang text template.

You could add a service to your config which purges the remote Ignition config before accepting work on the machine. That way, if a user downloaded the userdata, they would get a URL to the actual config that just 404'd.

Thanks but how could you do that in an autoscaling environment?
Purging the remote ignition config in the first node would result in other nodes to be unable to find the config.

How does authentication work in this case?

We're relying on IAM roles assigned to nodes via instance profiles.
Could we use an iam role to obtain ignition configs and then feed ignition?

Closing this as the original issue is resolved thanks to @redbaron.
@crawford Sorry for bothering you but I'm still interested on how we can avoid this issue after we've migrated to ignition and ct!

https://github.com/coreos/ignition/pull/382 adds ignition an ability to write s3 objects as local files. Using it in kube-aws allows us to reduce overall size of the remote(s3) parts of cloud-config-(worker|controller|etcd). In other words, it would make the userdata splitting(into local and remote/s3 parts) not necessary.
cc @redbaron


Redis cluster async

Hey guys. It may be cool, that hitbox will be able to support redis cluster

Codecov Report

Merging #24 (804f84b) into master (b8ef10e) will decrease coverage by 2.39%.
The diff coverage is 43.85%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   68.48%   66.09%   -2.40%
==========================================
  Files          41       41
  Lines         714      755      +41
==========================================
+ Hits          489      499      +10
- Misses        225      256      +31

Impacted Files
Coverage Δ

hitbox-actix/src/builder.rs
21.73% <ø> (ø)

hitbox-redis/src/actor.rs
53.70% <37.25%> (-19.44%)
:arrow_down:

hitbox-actix/src/actor.rs
90.00% <100.00%> (ø)

hitbox-redis/tests/integration_test.rs
100.00% <100.00%> (ø)

hitbox/src/response.rs
19.23% <0.00%> (+3.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ef10e...804f84b. Read the comment docs.

We might still should to wait a bit till the https://github.com/redis-rs/redis-rs/issues/745 done - which introduces the async cluster functionality into the crate, which was added from forked lib in this PR


Errors when installing bash install-deps;

Dear all,
When I tried to run this code to install Torch
git clone https://github.com/torch/distro.git ~/torch --recursive
cd ~/torch; bash install-deps;
./install.sh

I met the error (to install install-deps):
install-deps: line 99: ${DISTRIB_ID,,} $DISTRIB_RELEASE: bad substitution
Could you please help me to fix it? Thank yuou

same here? did you fix it?

No, I still have the problem

same here... Do you have a solution?


Add notification plugin to 2.7 manifest

Description
Add notification plugin to 2.7 manifest.
Issues resolved
https://github.com/opensearch-project/notifications/issues/649
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #3377 (8db21c5) into main (0c473e0) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main    #3377   +/-   ##
=======================================
  Coverage   91.74%   91.74%
=======================================
  Files         172      172
  Lines        4991     4991
=======================================
  Hits         4579     4579
  Misses        412      412

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


SqlDacpacDeploymentOnMachineGroup System.Debug does not show all output.

When using System.Debug = True, the output returned does not contain the output of sqlpackage making it appear as though the step that executes the package does nothing.
This was only tested on a machine running PowerShell 4 and I noticed there was a split in the logic where sqlpackage is executed so it could be only a powershell 4 or lower issue.
It would be nice to see all the package output when debug is on so that problems with the deployment can be better diagnosed and just general diagnostics as to what occurred.
There are a lot of things that can go wrong and some of those do not throw exceptions so we would have no way to diagnosis except to run the command directly or to modify the task's powershell scripts to return the output.
When System.Debug is False it would be nice to show the sql package output as well or some kind of indication the package executed and something happened as currently it appears to show nothing at all in the log except what the agent puts in.

Apologies for late response. Debug statements and success messages will be added to the task.


fix: strict select of pieceinstances in timelineTriggerTime

What kind of change does this PR introduce?
Only load pieceInstances that we know we the timings may need to be updated for, ie ones that come from the current or next part. This reduces data transferred from the database and reduces the search space for when we use the cache.

What is the current behavior? (You can also link to an open issue here)
All piece instances in the currently active playlist are loaded.

Other information:
I think the current and next part covers all piece instances that could possibly have a 'now' time that will be updated but do please correct me if I'm wrong here.

Status

[x] Code documentation for the relevant parts in the code have been added/updated by the PR author
[x] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

Codecov Report

Merging #648 (bbd4381) into release39 (930e27f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head bbd4381 differs from pull request most recent head 87ce156. Consider uploading reports for the commit 87ce156 to get more accurate results

@@            Coverage Diff             @@
##           release39     #648   +/-   ##
==========================================
  Coverage      68.03%   68.03%
==========================================
  Files            275      275
  Lines          19067    19070    +3
  Branches        4271     4271
==========================================
+ Hits           12972    12975    +3
  Misses          6018     6018
  Partials          77       77

Impacted Files
Coverage Δ

meteor/server/api/playout/playout.ts
61.50% <100.00%> (+0.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 930e27f...87ce156. Read the comment docs.


Refactor to multi-command CLI using services & handlers

This PR

makes the CLI composable of multiple commands
splits the existing code into modules of services, handlers, and shared helpers. This new code organization should make it easier/cleaner to add more commands.

Future work

introduce stricter tsc / lint by adding configs from @substrate/dev
incorporate chill-bot as a command

@kianenigma I don't have write access to merge this

now you do.

danke


Build first draft of file copying

Copy files from component pack to target project. Use the indexer to find all files.
Simplifications for now:

target project is still empty, so we don't need any "matching" between files
ignore shared files for now
hard-code target paths (per "part type, e.g. helper, partial, stimulus_controller") for now, not yet configurable

Code in indexer draft branch


Refactor to flag.

Hi all,
in my firsts step with Registrator I had some troubles to configure it, because you need a defined order in parameters. Another problem I encountered was it has poor coverage of Unit Test. I made other contributions to this project and here are my other 5 cents.
I propose to integrate a vendor cli to simplify flags and cover the new related code with Unit Test. It's the first step, because I think it could be refactored in another package but I think it's a good approach to include others PR.
What do you think?

I <3 that you added tests, but is there any reason why we couldn't avoid using an alternative flag parsing library in this PR? We can revisit that later, but it seems as though the two bits aren't necessarily intertwined, and could be done separately. If you can, I'd resubmit as two separate PRs, so that we can review each individually.
Sorry it took so long to review this.


Safe Apps modal design needs tweaking

Description

The line separating gas estimation section is not getting from edge to edge on the first view.
If I go to review the actions I still see the submit buttons and gas estimation, even the separation line disappeared. This wasn't like this before, you just saw the details of the action

Screenshots

Review of 1 action showing gas details

Review of a batch of transactions (needs scroll)

Links

Reported by @dasanra here.
Original Figma designs.

The new SignOrExecuteForm in web-core makes this redundant.