Error on macos Big Sur

Followed the install using anaconda. Script fires up Chrome and starts loading up images, but then runs into the following error and fails without any images being downloaded.
I did download the chrome 95 driver (same as chrome itself) and added location to .bash_profile.
Any ideas?
(BINGIMG) Ember:bing_images me$ python download.py
Save path: /Users/me/Documents/_testImages/train_images/bing/socks/dl_001
Traceback (most recent call last):
  File "download.py", line 3, in <module>
    bing.download_images("socks",
  File "/Users/me/Documents/bing_images/bing_images/bing.py", line 58, in download_images
    urls = fetch_image_urls(query, max_number, file_type, filters)
  File "/Users/me/Documents/bing_images/bing_images/bing.py", line 28, in fetch_image_urls
    urls = crawl_image_urls(keywords, filters, limit)
  File "/Users/me/Documents/bing_images/bing_images/crawler.py", line 58, in crawl_image_urls
    image_urls = image_url_from_webpage(driver, max_number)
  File "/Users/me/Documents/bing_images/bing_images/crawler.py", line 35, in image_url_from_webpage
    smb[0].click()
  File "/opt/anaconda3/envs/BINGIMG/lib/python3.8/site-packages/selenium/webdriver/remote/webelement.py", line 80, in click
    self._execute(Command.CLICK_ELEMENT)
  File "/opt/anaconda3/envs/BINGIMG/lib/python3.8/site-packages/selenium/webdriver/remote/webelement.py", line 693, in _execute
    return self._parent.execute(command, params)
  File "/opt/anaconda3/envs/BINGIMG/lib/python3.8/site-packages/selenium/webdriver/remote/webdriver.py", line 418, in execute
    self.error_handler.check_response(response)
  File "/opt/anaconda3/envs/BINGIMG/lib/python3.8/site-packages/selenium/webdriver/remote/errorhandler.py", line 243, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.ElementClickInterceptedException: Message: element click intercepted: Element ... is not clickable at point (960, 26). Other element would receive the click:
...

  (Session info: chrome=95.0.4638.69)
Stacktrace:
0   chromedriver                        0x0000000109b79bb9 chromedriver + 2747321
1   chromedriver                        0x000000010a22fe03 chromedriver + 9784835
2   chromedriver                        0x0000000109906118 chromedriver + 176408
3   chromedriver                        0x0000000109941e21 chromedriver + 421409
4   chromedriver                        0x000000010993fa7e chromedriver + 412286
5   chromedriver                        0x000000010993d25a chromedriver + 402010
6   chromedriver                        0x000000010993bea7 chromedriver + 396967
7   chromedriver                        0x000000010992fe49 chromedriver + 347721
8   chromedriver                        0x0000000109957da2 chromedriver + 511394
9   chromedriver                        0x000000010992fbd5 chromedriver + 347093
10  chromedriver                        0x000000010995801e chromedriver + 512030
11  chromedriver                        0x000000010996a2fb chromedriver + 586491
12  chromedriver                        0x0000000109957fc3 chromedriver + 511939
13  chromedriver                        0x000000010992e40e chromedriver + 341006
14  chromedriver                        0x000000010992f735 chromedriver + 345909
15  chromedriver                        0x0000000109b405df chromedriver + 2512351
16  chromedriver                        0x0000000109b5326f chromedriver + 2589295
17  chromedriver                        0x0000000109b24cbb chromedriver + 2399419
18  chromedriver                        0x0000000109b546ea chromedriver + 2594538
19  chromedriver                        0x0000000109b35c8c chromedriver + 2469004
20  chromedriver                        0x0000000109b6df58 chromedriver + 2699096
21  chromedriver                        0x0000000109b6e0e1 chromedriver + 2699489
22  chromedriver                        0x0000000109b7ebc8 chromedriver + 2767816
23  libsystem_pthread.dylib             0x00007fff2051f8fc _pthread_start + 224
24  libsystem_pthread.dylib             0x00007fff2051b443 thread_start + 15

Can you provide more specific environmental information?
My environment is as follows, verified that there is no problem.

chrome 96.0.4664.45
driver 96.0.4664.35
mac OS 12.0.1

❯ conda create -n bing-images python=3.8.5
❯ conda activate bing-images
❯ export PATH=/Users/catchzeng/chromedriver:$PATH
❯ which chromedriver
/Users/catchzeng/chromedriver/chromedriver
❯ python download.py
Save path: /Users/catchzeng/Desktop/cat
Crawled 70 image urls.
Downloading images
#1 https://pngimg.com/uploads/cat/cat_PNG50449.png Downloaded
#2 https://purepng.com/public/uploads/large/purepng.com-catanimalscat-981524673949tj5ns.png Downloaded
#3 https://pngimg.com/uploads/cat/cat_PNG50448.png Downloaded
#4 https://pngimg.com/uploads/cat/cat_PNG50445.png Downloaded
#5 http://pngimg.com/uploads/cat/cat_PNG50482.png Downloaded
#6 http://purepng.com/public/uploads/large/purepng.com-sitting-catcatcatsanimalspetscute-cat-25152016380020k8o.png Downloaded
#7 https://purepng.com/public/uploads/large/515023057367pjqxmsnx7rgiihwwfa1yopebtptssyevfbjqwwbw8cxyucv6srtcaraobaotirnmd7zjkf3hi7oyexhybu0rkyuafuwk0hnxr5h.png Downloaded
#8 https://purepng.com/public/uploads/large/515023079169r5z6n4yjylprjqgiee36v9xirrxktv1oqnq4xbl9fzzxdbwpcsjfbypqjmwak4vfimpjchla8rxfuhpo7wdsrwf1gixcaxee7in.png Downloaded
#9 https://pngimg.com/uploads/cat/cat_PNG100.png Downloaded
#10 https://pngimg.com/uploads/cat/cat_PNG50479.png Downloaded
#11 https://pngimg.com/uploads/cat/cat_PNG50447.png Downloaded
#12 https://pngimg.com/uploads/cat/cat_PNG50433.png Downloaded
#13 https://purepng.com/public/uploads/large/purepng.com-catcat-animal-981524644802hvred.png Downloaded
#14 https://pngimg.com/uploads/cat/cat_PNG50440.png Downloaded
#15 https://purepng.com/public/uploads/large/purepng.com-cat-cuteanimalscats-115205020723cicy.png Downloaded
#16 https://pngimg.com/uploads/cat/cat_PNG113.png Downloaded
#17 https://pngimg.com/uploads/cat/cat_PNG50430.png Downloaded
#18 http://pngimg.com/uploads/cat/cat_PNG50424.png Downloaded
#19 https://pre00.deviantart.net/dc4a/th/pre/f/2017/362/3/d/cat_png_2_by_bouzid27-dby5uu3.png Downloaded
#20 https://pngimg.com/uploads/cat/cat_PNG50545.png Downloaded
Renaming images
Finished renaming
Done
Elapsed time: 86.24s

Sure, sorry about that.
macOS 11.6 (20G165)
Google Chrome: 95.0.4638.69 (Official Build) (x86_64)
ChromeDriver: 95.0.4638.69
I think I setup conda with python 3.8. I'll update to 3.8.5 and see if it makes any difference.

Well, I found that Google Chrome was trying to update itself, so it was looking for the newer chrome driver when I ran the python script. So I updated Chrome, trashed the old drivers and downloaded the latest one and placed it in the PATH. Still got the same errors though.
I'm going to try to boot in safe mode and then reboot again to make sure nothing squirrely is going on. I'm now using the same version of python, Chrome and ChromeDriver as you are.

Okay, so I safe booted, ran daily weekly monthly maintenance cron jobs and restarted again. Have made some progress.
• single word searches work
• multiple word searches fail
This Works
from bing_images import bing

bing.download_images("cat",
                      100,
                      output_dir="/Users/me/Desktop/cat",
                      pool_size=10,
                      force_replace=True)

This errors out the same way as before
from bing_images import bing

bing.download_images("old cat",
                      100,
                      output_dir="/Users/me/Desktop/cat",
                      pool_size=10,
                      force_replace=True)

Using two words it does launch Chrome, the correct search terms are used, images load, page scrolls down, etc, but then the same error happens in terminal and it doesn't download anything.

I have tried it and everything is fine, as shown in the picture below.

Can you provide the error logs?

@KeygenLLC  I will close this issue temporarily, if you still have questions, you can reopen it again.

Sorry for the delay. Been busy with other work.
strange. I have it in a virtual env so not sure what might be causing a conflict.
Which log do you need to see the output of? Just want to make sure I grab the correct one.
Thanks

You can use conda to create a new environment to verify it, the code is as follows.
❯ conda create -n bing-images python=3.8.5
❯ conda activate bing-images
❯ pip install bing-images

if there is an error, please copy the error log here for communication.

Will do. thanks

Well, good news is it worked. :)
Not sure if it's because I had a lower version of python at first, or maybe the env just got corrupted somehow. I didn't install any other packages, so... idk. I tend to get weird behavior like this that turns out to be more like ghosts in the machine than actual bugs.
Either way, it is working. Thanks for the help and for the cool tool.


Post page basic layout

Description

contains a list of all the posts (use the existing post preview component)
contains a searchbar to search all the posts
contains new post button
search function able to filter posts by title
Search function should also include the ability to filter out posts based on the test of the post, this will be made into a new issue.

Related Issue

Solves #32

Type of change

[x] New feature (enhancement)

How Has This Been Tested?
 Manually tested locally.
Chrome using windows 11.

[x] Manual testing

Checklist:

[x] Does a similar (open or closed) pull request not already exist?
[x] Is the pull request head repository a fork repository?
[x] Is the pull request compare branch a development branch?
[x] Is the code documented, particularly in hard-to-understand areas?
[x] Does the code build without new warnings?
[x] Has testing been performed that proves changes are effective and work?
[x] Has a self- and/or peer-review of the code been performed?
[x] Is the person responsible for the repository assigned to the pull request?
[x] Is the pull request linked to a project?
[x] Is the pull request linked to a milestone?

For more information, refer to the Contributing Guidelines and Code of Conduct links at the bottom of this page.

Heya please fix these issues so we can see the Netlify preview, thanks!

Just fixed it, should be working now.


Add option to set slugStartIndex

Note: This PR is based on #39, which should be merged prior to this one. (done)
This PR adds the option slugStartIndex that allows to define a custom number to start the counting of suffixes for duplicate headings.
If #40 is merged before this, I will add the change in types of course with this PR too. (done)
Breaking: This PR sets the default value for slugStartIndex to 1 to be compatible with markdown-it-anchor v6 out of the box.
Example:
# heading
# heading

will now result in something like this (note the suffix "-1" instead of "-2").

heading

heading

Fixes #38

Are there any news? We need this change (and a release) for https://github.com/codimd/react-client/pull/642 :/

@nagaozen Please let us know if you have time to review the open PRs and create a new release. We need this fixes. If you don't have time, then let us know and we'll fork the project to apply the PRs ourself.

@mrdrogdrog Sincerely apologize, I'll take a look tonight. This project is tightly coupled with markdown-it-anchor so I'll review both packages and release'em.

i'd to update the name of the option to uniqueSlugStartIndex to follow the markdown-it-anchor options.


These instructions do not work.

I get the error described @ https://github.com/Azure/azure-functions-vs-build-sdk/issues/199.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6e88ea08-81ef-2b5a-b9d6-539e85592672
Version Independent ID: f2d8b7b4-906a-d1f5-5201-fc22a7890955
Content: Quickstart: Create your first function in Azure using Visual Studio
Content Source: articles/azure-functions/functions-create-your-first-function-visual-studio.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@andrewkittredge Thank you for your feedback! We will review and update as appropriate.

@andrewkittredge As this is something specifically to a Product question , recommendation at this point is to create the product issue to the official Azure Functions Repo for better clarity. Azure Function Repo will be monitored by Product team of Azure function

@andrewkittredge For now I will proceed with closure of this and If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


chore: update repo by service bot

This is a routine update from cc-service-bot based on the service.yml in your repo. This PR
should be approved and merged as soon as CI passes.

CHANGELOG
FILE NAME - CHANGED BY - COMMIT MESSAGE
Makefile - framework - chore: update repo Makefile cc-mk-include v0.1213.0
cc-mk-include/compare/v0.1211.0...v0.1213.0


fix(afk): too many required args

This PR fixes #135.
Status

[x] Code changes have been tested on an instance of YAGPDB.
[x] I have read and followed the contribution guide

Thanks!

Thanks!

No problem!

No problem!


Update the string 'Add tag' to 'Add Tag' in the Blob Tags dialog

Storage Explorer Version: 1.16.0-dev
Build:  20200930.3
Branch: main
Platform/OS: Windows 10/ Fedora release 29/ MacOS Catalina
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Expand one storage account (make sure the 'blob tags' feature is enabled) -> Blob Containers.
Open one blob container -> Right click one blob -> Click 'Edit Tags...'.
Check the strings in the dialog.

Expect Experience:
Display 'Add Tag' in the dialog.
Actual Experience:
Display 'Add tag' in the dialog.

Verified on build 20201010.4. This issue has been fixed. So close it.


request.json() now returns empty dict when no data

There was ValueError raising when trying to access request.json() is there is no data. I think that this is incorrect behavior and empty dict (or something else) must be returned in this case.

I think ValueError is correct behavior.
Standard json module also doesn't implicitly convert empty string into empty dict:
>>> from json import loads
>>> loads('')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.4/json/__init__.py", line 318, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.4/json/decoder.py", line 343, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.4/json/decoder.py", line 361, in raw_decode
    raise ValueError(errmsg("Expecting value", s, err.value)) from None
ValueError: Expecting value: line 1 column 1 (char 0)
>>> loads(None)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.4/json/__init__.py", line 312, in loads
    s.__class__.__name__))
TypeError: the JSON object must be str, not 'NoneType'
>>>

+1 to keep ValueError behaviour.

Ok, but why in get/post cases you get empty dict <_MultiDictProxy {}> and have to catch ValueError in json-context? What's the point? Just json-module convention or something else?
@asyncio.coroutine
def get_data_from_post(request):
    data_post = yield from request.post()
    print(data_post)
    return web.Response(body='The response post'.encode('utf-8'))

@asyncio.coroutine
def get_data_from_get(request):
    print(request.GET)
    return web.Response(body='The response from get'.encode('utf-8'))

@asyncio.coroutine
def get_json(request):
    try:
        data_json = yield from request.json()
    except ValueError:
        return web.Response(body='No json-data'.encode('utf-8'))
    return web.Response(body='The response'.encode('utf-8'))

I think GET and POST are user for checking for key presence. Empty dict is pretty good sign for item not present message.
JSON has another behavior: it is either json-encoded or not. Arbitrary data is not JSON.


More info on install

Maybe I'm stupid, but while trying to install, I just added specified line to packer plugin list, and I get this error on init:

Error detected while processing /home/pickle/.config/nvim/init.lua:
E5113: Error while calling lua chunk: Vim:E475: Invalid value for argument cmd: '/home/pickle/.config/nvim/site/pack/packer/start/codesna
p.nvim/snap-server/target/release/snap-server' is not executable
stack traceback:
        [C]: in function 'connect'
        .../pack/packer/start/codesnap.nvim/lua/codesnap/client.lua:29: in function 'init'
        .../pack/packer/start/codesnap.nvim/lua/codesnap/client.lua:33: in function 'start'
        ...te/pack/packer/start/codesnap.nvim/lua/codesnap/init.lua:15: in function 'setup'
        /home/pickle/.config/nvim/init.lua:39: in main chunk

I mean I get that server-snap is not installed, but at which point should it? and is there some command that copies rust binary to path or something? kinda confused it has not happened yet

Hey @alekspickle, thx for using codesnap.nvim, and reporting the issue, if you can't install it smoothly, there are only one reason, not because you're stupid, but because the documentation isn't detailed enough, sorry about that.
Do you install codesnap.nvim using Lazy.nvim? the config looks like:

Please notice there is an option build = 'make', before lazy installing the plugin, the build content will execute immediately. Can you provide your configuration?

The reason of this because the codesnap.nvim needs build server code after installed, the document lacks this part how install this plugin with packer, I'll add it later.
Install this plugin use packer you configure like this:
use { 'mistricky/codesnap.nvim', run = 'make' }

that's exactly how I added it

After refactor, this issue may out of stale, can you try with latest version?

new error!
Error detected while processing /home/pickle/.config/nvim/site/pack/packer/start/codesnap.nvim/plugin/codesnap.lua:
E5113: Error while calling lua chunk: vim/_init_packages.lua:0: /home/pickle/.config/nvim/site/pack/packer/start/codesnap.nvim/lua/genera
tor.so: invalid ELF header
stack traceback:
        [C]: in function 'error'
        vim/_init_packages.lua: in function <vim/_init_packages.lua:0>
        [C]: in function 'require'
        ...te/pack/packer/start/codesnap.nvim/lua/codesnap/init.lua:3: in main chunk
        [C]: in function 'require'
        ...site/pack/packer/start/codesnap.nvim/plugin/codesnap.lua:1: in main chunk

Can you provide your OS version and neovim version?

Ubuntu 23.10
NVIM v0.9.1

This issue may relate to which arch you use. What output of execute uname -a on your OS?

Linux picklelap 6.5.0-25-generic #25-Ubuntu SMP PREEMPT_DYNAMIC Wed Feb  7 14:58:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Hi! CodeSnap was refactored, you can reinstall follow the latest README, if have any problems just let me know

Did not work either

Error detected while processing /home/pickle/.config/nvim/site/pack/packer/start/codesnap.nvim/plugin/codesnap.lua:
E5113: Error while calling lua chunk: ...te/pack/packer/start/codesnap.nvim/lua/codesnap/init.lua:3: module 'generator' not found:
        no field package.preload['generator']
        no file './generator.lua'
        no file '/__w/neovim/neovim/.deps/usr/share/luajit-2.1.0-beta3/generator.lua'
        no file '/usr/local/share/lua/5.1/generator.lua'
        no file '/usr/local/share/lua/5.1/generator/init.lua'
        no file '/__w/neovim/neovim/.deps/usr/share/lua/5.1/generator.lua'
        no file '/__w/neovim/neovim/.deps/usr/share/lua/5.1/generator/init.lua'
        no file '/home/pickle/.cache/nvim/packer_hererocks/2.1.0-beta3/share/lua/5.1/generator.lua'
        no file '/home/pickle/.cache/nvim/packer_hererocks/2.1.0-beta3/share/lua/5.1/generator/init.lua'
        no file '/home/pickle/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/luarocks/rocks-5.1/generator.lua'
        no file '/home/pickle/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/luarocks/rocks-5.1/generator/init.lua'
        no file './generator.so'
        no file '/usr/local/lib/lua/5.1/generator.so'
        no file '/__w/neovim/neovim/.deps/usr/lib/lua/5.1/generator.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
        no file '/home/pickle/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/lua/5.1/generator.so'
stack traceback:
        [C]: in function 'require'
        ...te/pack/packer/start/codesnap.nvim/lua/codesnap/init.lua:3: in main chunk
        [C]: in function 'require'
        ...site/pack/packer/start/codesnap.nvim/plugin/codesnap.lua:1: in main chunk

Did not work either

Error detected while processing /home/pickle/.config/nvim/site/pack/packer/start/codesnap.nvim/plugin/codesnap.lua:
E5113: Error while calling lua chunk: ...te/pack/packer/start/codesnap.nvim/lua/codesnap/init.lua:3: module 'generator' not found:
        no field package.preload['generator']
        no file './generator.lua'
        no file '/__w/neovim/neovim/.deps/usr/share/luajit-2.1.0-beta3/generator.lua'
        no file '/usr/local/share/lua/5.1/generator.lua'
        no file '/usr/local/share/lua/5.1/generator/init.lua'
        no file '/__w/neovim/neovim/.deps/usr/share/lua/5.1/generator.lua'
        no file '/__w/neovim/neovim/.deps/usr/share/lua/5.1/generator/init.lua'
        no file '/home/pickle/.cache/nvim/packer_hererocks/2.1.0-beta3/share/lua/5.1/generator.lua'
        no file '/home/pickle/.cache/nvim/packer_hererocks/2.1.0-beta3/share/lua/5.1/generator/init.lua'
        no file '/home/pickle/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/luarocks/rocks-5.1/generator.lua'
        no file '/home/pickle/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/luarocks/rocks-5.1/generator/init.lua'
        no file './generator.so'
        no file '/usr/local/lib/lua/5.1/generator.so'
        no file '/__w/neovim/neovim/.deps/usr/lib/lua/5.1/generator.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
        no file '/home/pickle/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/lua/5.1/generator.so'
stack traceback:
        [C]: in function 'require'
        ...te/pack/packer/start/codesnap.nvim/lua/codesnap/init.lua:3: in main chunk
        [C]: in function 'require'
        ...site/pack/packer/start/codesnap.nvim/plugin/codesnap.lua:1: in main chunk

I had the same issue with the module generator not being found.
In field package.preload['generator']
cache_loader: module generator not found
cache_loader_lib: module generator not found
In file './generator.lua'

I fixed the issue by using version 0.0.11, instead of ^1 like written in the documentation.
Here is my codesnap.lua if needed (I am using LazyVim though):
{
  "mistricky/codesnap.nvim",
  lazy = true,
  version = "0.0.11",
  build = "make",
  cmd = "CodeSnapPreviewOn",
  opts = {
    mac_window_bar = false, -- (Optional) MacOS style title bar switch
},
  config = function(_, opts)
    require("codesnap").setup(opts)
  end,
},

Hello guys @Simon9991 @alekspickle, this issue has been open for too long, something has changed since I released v1, can you guys test this bug in the latest version? if still not working properly, please let me know.

Hi,
I just tried with the new version, and I have no issue anymore on my end!
Thanks for this plugin, I love it!

Works like intended! Thank you but just out of curiosity, do you have the process of install described somewhere? I also want to write nvim plugin with rust backend

Hi @alekspickle sorry for replying late.

do you have the process of install described somewhere

Nope yet. CodeSnap.nvim is written by rust, and exposes FFI to communicate with Lua modules, if you are interested in this   solution, you can check this repo


Re-export BibliographyItem

Fixes #157.

Oh yeah, adding docs would make sense whoops. Should I do that, or is that something you would do @PgBiel?

Oh yeah, adding docs would make sense whoops. Should I do that, or is that something you would do @PgBiel?

This one's on us, sorry about that.
Thank you for the PR! :blue_heart:


Integrate LLamaSharp to enable LLaMa model inference

Hi all, great work so far! As the open-source LLM models become more and more hot, will semantic-kernel consider supporting some of them such as LLaMa? I'm the main author of LLamaSharp, which is the .NET binding of llama.cpp. I wonder if it's possible to integrate LLamaSharp into semantic-kernel to add support for some open-source LLM models (as you can see, llama.cpp support 10 kinds of models). I'd like to work for this integration if it's taken into account to the future version of semantic-kernel. Thank you for your consideration.

Thanks for posting, this does sound interesting and I wonder if it would be possible to provide a LLamaSharp implementation along the lines of this sample: https://github.com/microsoft/semantic-kernel/blob/main/samples/dotnet/kernel-syntax-examples/Example16_CustomLLM.cs
@dluc make have opinions here also

@AsakusaRinne , let us know if you want to do a PR for this based on the other examples of how other models work.

Hi, thanks to the efforts of community, there's an example here to use LLamaSharp with sk. The example uses the latest pre-release of sk and is easy to deploy. Please have a look and I'll improve it with your advice.

@evchaki @craigomatic Please let me know if I can provide any further information to help move this forward. Thank you for your time and attention.

We have a basic implementation of this in LLamaSharp itself now: https://github.com/SciSharp/LLamaSharp/tree/master/LLama.SemanticKernel
I'm not sure how stable the Abstractions library is though, I've had to bump it due to a recent change in IChatCompletion. I'm not sure bringing this implementation into this repo makes sense, but maybe there could be more said for changes like these?

I'm definitely going to take this in somehow :-)

I can do this =)

@drasticactions, now that the abstractions have settled down, would you be interested in bringing in LlamaSharp into the main Semantic Kernel repo?

I am currently working on the maintenance of LLamaSharp.SemanticKernel. If possible, I would be willing to do it.

All .Net issues prior to 1-Dec-2023 are being closed. Please re-open, if this issue is still relevant to the .Net Semantic Kernel 1.x release. In the future all issues that are inactive for more than 90 days will be labelled as 'stale' and closed 14 days later.

It seems that this issue is still under-working. Please reopen it. :)


win8.1

so been playing around with loading this using
IEX (New-Object Net.WebClient).DownloadString('http://bit.ly/2nea8tb'); Get-ChromeCreds
works perfectly on win7 and win10 and returns data, but for some reason win8.1 fails, not using a special profile path
also is it possible to parse the username from the url

I actually developed this on a Win 8.1 system (sadly) so I'm not aware of any specific issue. Do you get any kind of error back? Can you get me some more info about the target system, like what version of PowerShell/.NET it has? Do other downloaded PowerShell modules work? Thanks!
As for parsing the username from URL, I wasn't able to because how SQLite works is that the data is entirely contiguous. Each entry looks something like URL, field name, username, then encrypted blob. You would need to actually read the file as a database in order to determine where the URL/field name/username fields started/stopped, as there's no magic bytes to work with. Therefore I won't be supporting it anytime in the near future.

i dont receive any data back from it when i run it either from download or directly from the .ps1
not sure of anything that would prevent it, i even tried putting the path as a variable and no change
chrome Version 56.0.2924.87
`PS C:> $PSVersionTable
Name                           Value

PSVersion                      4.0
WSManStackVersion              3.0
SerializationVersion           <IP_ADDRESS>
CLRVersion                     4.0.30319.34209
BuildVersion                   6.3.9600.17400
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0}
PSRemotingProtocolVersion      2.2`

Thanks, the easiest next step for me would be to provide me with the "Login Data" file so that I can try to reproduce the issue. However, I understand that this file may contain sensitive data you don't want to send to random people on the internet. If sending me the file isn't an option let me know, I'll figure something else out.

when i get to the office tomorrow ill try to create a new profile in chrome and add some creds and see if that works

I also tried this script on the VM, Chrome version 54.0.2840.99 m (64-bit)
Windows version:Windows 8.1 Enterprise . It returns an empty string nothing is seen. I have available creds on the Chrome. I created a new test user for the chrome so the user is not duplicate. These our my test results .

Looks like mine is Win 8.1 Pro, not Enterprise. Still, I highly doubt that would be the issue. I fully support xillwillx's idea of creating a new profile in Chrome for testing. I think the issue is either objection creation related, or a regex miss. If possible please send me the "Login Data" file for a machine where the script does not work. I will know for sure once I can get a look at one of these files. Thanks!

sorry it took so long to get back , I was out of the office yesterday. So i created a new profile and it worked. The LastPass extension is the cause of it not dumping the passwords, because i enabled that in the new profile and BrowserGather failed when i retested after enabling LastPass.

That is seriously weird, because I also use LastPass and had it active during the entire development! I have no idea why it would be affecting your ability to dump Chrome's local credentials. Can you confirm the Login Data file is unchanged before and after enabling LastPass? Hashing or looking at Time Modified should be sufficient.

I think I figured out what the issue was. Testing during the cookie extraction phase revealed a regex miss in the credential extraction portion. I have updated the regex accordingly. This should fix the issue, if you have any other issues please let me know, thanks!

Brilliant work. I will test it out when I have time. Thanks for the heads
up. Take Care.
Kind Regards,
2017-04-05 22:56 GMT+03:00 sekirkity<EMAIL_ADDRESS>
I think I figured out what the issue was. Testing during the cookie
extraction phase revealed a regex miss in the credential extraction
portion. I have updated the regex accordingly. This should fix the issue,
if you have any other issues please let me know, thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sekirkity/BrowserGather/issues/1#issuecomment-291978701,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQgoaoKlTJnAK42A_33ggSHAJYl7xeUwks5rs_H8gaJpZM4McAdP
.


Remove various "share" icons for portfolio widget

Adding projects to the portfolio widget automatically includes various icons with links to presumably share the page. These include Facebook, Linkedin, Whatsapp, and Weibo. It would be useful to be able to remove these icons to clean up the page.

In the index.md file for the project you would like to remove the sharing tags from, include
share: false

Unfortunately, that did not work for me!
On Mon, Dec 21, 2020 at 1:26 PM erin-d<EMAIL_ADDRESS>wrote:

In the index.md file for the project you would like to remove the sharing
tags from, include
share: false
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wowchemy/wowchemy-hugo-modules/issues/1611#issuecomment-749203966,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALGX533WBM6U6P7JZOZLV5TSV64RBANCNFSM4LTFXUIQ
.

Unfortunately, that did not work for me!
On Mon, Dec 21, 2020 at 1:26 PM erin-d<EMAIL_ADDRESS>wrote:

In the index.md file for the project you would like to remove the sharing
tags from, include
share: false
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wowchemy/wowchemy-hugo-modules/issues/1611#issuecomment-749203966,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALGX533WBM6U6P7JZOZLV5TSV64RBANCNFSM4LTFXUIQ
.

Alternatively, you can change enable=false in all the buttons of your data/page_sharer.toml

Alternatively, you can change enable=false in all the buttons of your data/page_sharer.toml

I did not previously have a page_sharer.toml created for my site, so I just
copied it over. That worked for me, thank you!
On Mon, Jan 4, 2021 at 11:45 AM rodrigoalcarazdelaosa <
<EMAIL_ADDRESS>wrote:

Alternatively, you can change enable=false in all the buttons of your
data/page_sharer.toml
https://github.com/wowchemy/wowchemy-hugo-modules/blob/master/wowchemy/data/page_sharer.toml
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wowchemy/wowchemy-hugo-modules/issues/1611#issuecomment-754177697,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALGX53ZBUTKYXULQYL5V4U3SYILEZANCNFSM4LTFXUIQ
.

I did not previously have a page_sharer.toml created for my site, so I just
copied it over. That worked for me, thank you!
On Mon, Jan 4, 2021 at 11:45 AM rodrigoalcarazdelaosa <
<EMAIL_ADDRESS>wrote:

Alternatively, you can change enable=false in all the buttons of your
data/page_sharer.toml
https://github.com/wowchemy/wowchemy-hugo-modules/blob/master/wowchemy/data/page_sharer.toml
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wowchemy/wowchemy-hugo-modules/issues/1611#issuecomment-754177697,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALGX53ZBUTKYXULQYL5V4U3SYILEZANCNFSM4LTFXUIQ
.


Add nonblocking Teams handler

Support for a non-blocking teams handler was the reason for this (and my previous) PR(s).
I had a copy of your code already running on a system, but modified with support for a non-blocking teams handler. The standard (blocking) teams handler has too much impact on my application code.
If you decide to merge and release with the non-blocking handler, I can throw out the patched code, and switch back to just importing https://pypi.org/project/teams-logger/
Please verify if tests are also successful at your end; the multi-threading from the QueueListener required some unit test fiddling. Although I think the approach is sound.

Thank you for your valuable contributions. Once the non blocking is tested, it will be released to PyPi under the tag 0.3.0

great, thanks.

The non blocking  handler has been released under 0.3.0 (https://pypi.org/project/teams-logger/0.3.0/). However, NBTeamsHandler has been renamed TeamsQueueHandler.

Cool, thanks. TeamsQueueHandler indeed makes more sense.


https://  Radio Streams need a long time to start (40 - 60 seconds)

Radiostreams with an https:// Link need a long time, till the playback starts
In some cases almost 60s.
I testetd this with the actual DEV 2024-10-30:
DLF HTTP
Stream: http://st01.sslstream.dlf.de/dlf/01/128/mp3/stream.mp3?aggregator=web (starttime 2s)
DLF HTTPS
Stream: https://st01.sslstream.dlf.de/dlf/01/128/mp3/stream.mp3?aggregator=web (starttime 40s)
important note:
Strem URLS can not be placed in the same Label.
In my case i tried to label both Links as RADIO. But in the JSON he chnged both Links to HTTP or HTTPS. depends which on was saved first.

done, new saved url in rss or radio is change from https to http


Chore/unit tests

@joefitter this is good work, please can you fix the lint errors and I'll merge

buttery biscuit

🍪

@joefitter I am going to close this, ok?

I'm not going to ask for permission.


Leaderboard: add autocomplete benchmarks

An incomplete implementation of autocomplete evals. Want to merge this now to unblock another PR for chat evals that depend on the diff here.
Test plan
N/a

This is a low-risk PR to merge because the diff is limited to the cody-bench tool


(WIP) (PUP-7042) Externalize warning and error strings

This PR tracks the work of marking warning and error strings for externalization and translation using gettext tooling.

CLA signed by all contributors.

I will be adding commits to this as time goes on, but everything up here currently is ready for review. I will most likely be splitting this into many smaller PRs to make that review easier.

This PR is superseded by the many individual PRs with a PUP-7042 ticket number. Keeping this branch open to help docs people review strings.


Fix Union orderBy pushDown

Current coverage is 80.94% (diff: 83.60%)

Merging #4266 into union-all will increase coverage by 0.02%

@@           union-all      #4266   diff @@
===========================================
  Files           1313       1313
  Lines          44628      44655    +27
  Methods            0          0
  Messages           0          0
  Branches        7117       7113     -4
===========================================
+ Hits           36116      36148    +32
- Misses          5836       5838     +2
+ Partials        2676       2669     -7

Powered by Codecov. Last update 4e98dca...3b0f2f8

@dobe Please review. Changed union pushDown stuff to be implemented with a visitor as discussed.


Update run function and add test

A few things:

Moving validate code into run cli + libs/validate.py
Adding ability to run by state
Added a test that runs one state and make sure it works from the cli.

I have to step away for a bit - need to fully test the validate functionality.

Sorry, but for me to review this it needs to be split into smaller, more isolated PRs.  As general rules:

PRs should be small and do only one thing.
You should always try to split out pure refactors (renaming files / variables / etc.) from actual code changes.  Otherwise the refactors add a lot of noise to the diff that make it easy to overlook actual code changes.    But if you also made other code changes, it's a lot more tedious and error-prone.
And in this case, you changed validate.py enough that git doesn't even recognize it as a rename anymore, so I have to try to manually compare them.

If your work builds upon itself so that you can't easily do it as separate PRs against master in parallel, you can either created PRs chained off of each other (which admittedly is a little awkward with github) or do it in a single PR but make sure that the PR consists of separate commits for each reviewable piece, e.g.:

Rename files to my preferred directory structure / naming convention.
Rename constants to my preferred naming convention.
Switch to a dedicated logger instead of logging.info() directly.
Add comments to significant methods.
Switch to click for command-line processing.
...

Then I can quickly click through the commits and review them in isolation.

Hi Michael, thanks for the feedback! Will do!

The changes LGTM, but I will defer to Michael's feedback.

Will end up fixing these in other PRs!


-HiddenFromAddressListsEnabled

-HiddenFromAddressListsEnabled
The HiddenFromAddressListsEnabled parameter specifies whether the Microsoft 365 Group appears in the global address list (GAL) and other address lists in your organization. Valid values are:
$true: The Microsoft 365 Group is hidden from the GAL and other address lists. The group can still receive messages, but users can't search for or browse to the group in Outlook or Outlook on the web. Users also can't find the group by using the Discover option in Outlook on the web. For users that are members of the Microsoft 365 Group, the group will still appear in the navigation pane in Outlook and Outlook on the web if HiddenFromExchangeClientsEnabled property is NOT enabled.
$false: The Microsoft 365 Group is visible in the GAL and other address lists. This is the default value.
Is this still the case?  I have read on some forums that this changed so $true is now the default?
Thanks.
David

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 80326e44-6beb-8983-57ab-8333608c504b
Version Independent ID: 8962c0dc-72a3-208a-33de-6a89cd56b6fc
Content: Set-UnifiedGroup (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Set-UnifiedGroup.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@davidkench, I tested in my regular ol' E5 tenant by creating a new public M365 Group and a new private M365 Group, in the M365 admin center (apparently, you can't create them in the new EAC) and the value of the HiddentFromAddressListsEnabled property for both was False.
Perhaps I should just remove that "This is the default value" sentence?

Hi Chris,
No, I think having tested, that does still hold true.  That is "false" is the default.
Thanks,
David
From: Chris Davis @.>
Sent: Saturday, 14 August 2021 2:42 AM
To: MicrosoftDocs/office-docs-powershell @.>
Cc: David Kench @.>; Mention @.>
Subject: Re: [MicrosoftDocs/office-docs-powershell] -HiddenFromAddressListsEnabled (#8180)
@davidkenchhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdavidkench&data=04|01|david.kench%40datacom.com.au|15a0d22c86d44964a8a908d95e79426b|866c7a4c8a594bd3ad9f8512a581efc0|0|0|637644697170881131|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=KCdw0%2BX9%2ByNOlFvcZRtn%2FP5GWyqwJJh1vNVipK5xhxY%3D&reserved=0, I tested in my regular ol' E5 tenant by creating a new public M365 Group and a new private M365 Group, in the M365 admin center (apparently, you can't create them in the new EAC) and the value of the HiddentFromAddressListsEnabled property for both was False.
Perhaps I should just remove that "This is the default value" sentence?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Foffice-docs-powershell%2Fissues%2F8180%23issuecomment-898588459&data=04|01|david.kench%40datacom.com.au|15a0d22c86d44964a8a908d95e79426b|866c7a4c8a594bd3ad9f8512a581efc0|0|0|637644697170881131|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=rIrpv06D6uIX8pLsw07PX9bcAi6we7nXmISigy7VX6c%3D&reserved=0, or unsubscribehttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASNZJXHI2YK62KINNX4CHYDT4VDNBANCNFSM5CCYJQAA&data=04|01|david.kench%40datacom.com.au|15a0d22c86d44964a8a908d95e79426b|866c7a4c8a594bd3ad9f8512a581efc0|0|0|637644697170891126|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Ne%2FQw0Q74sIxGjyE726i6z%2B4Jn4YZFutT5h0cTzW2QE%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|david.kench%40datacom.com.au|15a0d22c86d44964a8a908d95e79426b|866c7a4c8a594bd3ad9f8512a581efc0|0|0|637644697170891126|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=4XrqeGqGdXA7ygeC%2F6Xaahq8Wpg%2BQdnrta0kSmKQgow%3D&reserved=0 or Androidhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26utm_campaign%3Dnotification-email&data=04|01|david.kench%40datacom.com.au|15a0d22c86d44964a8a908d95e79426b|866c7a4c8a594bd3ad9f8512a581efc0|0|0|637644697170901120|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ePgN2pqNEp64DBPn4rE1wH0ysAyxguJMnU0dLKiEfHM%3D&reserved=0.

@davidkench, OK. I removed the offending sentence.
Thanks for the feedback.
Closing


fix: In Firefox, when the URL hash changes, browser not reloaded.

environment
OS: Windows 10
Firefox: 47.0.2
SeleniumServer: 2.53.1
GeckoDriver: 0.13.0

I changed because IE did not work.
before
return this._wd.get('data:,')

after
return this._wd.get('about:blank')

@kamijin-fanta Thank you for your contribution.
//сс @sipayRT I have not such experience to verify this change 😢

what about refresh command? We can add such functionality


[fix] Mongo::Error::OperationFailure (not master (10107))

Coverage increased (+0.01%) to 84.622% when pulling ccd94b46eb0809cd3fd0248b005abb8fe91e8ef0 on fix-not-master into 4764a339ee206f247df4f3b88a0bed9ee42af8a0 on master.


Figure out what to do about hidden passes

Some passes are for internal use and undocumented.

Remove hidden passes from the Pass enum.
In the test that checks we have all the passes, check also that we don't have the hidden passes.

done


v1.3 backports 2019-03-06

v1.3 backports 2019-03-06
Not Included

#7246 -- Protect remaining local keys from kvstore delete events (@tgraf)
#7249 -- daemon: Remove old health EP state dirs in restore (@joestringer)

Included

#7286 -- contrib: Fix cherry-pick to avoid omitting parts of patch (@brb)
#7288 -- contrib: Update backporting README (@brb)

Once this PR is merged, you can update the PR labels via:
$ for pr in 7286 7288; do contrib/backporting/set-labels.py $pr done 1.3; done

This change is

test-me-please

test-me-please

test-me-please

test-docs-please

test-missed-k8s


Add contact form

In this project, we have added the contact form to my portfolio project.
Included are:

My interests in an h3 element.
The form to capture name and email address in input tags and a message in a textarea.
Social icons links
My email addressed
CSS styles to enhance the appearance of these elements.

Thanks, I will look into it.
On Tue, Mar 22, 2022, 6:29 PM anderson @.***> wrote:

@.**** commented on this pull request.
In index.html
https://github.com/dd-obua/Dan-portfolio/pull/3#discussion_r832336103:

 <form

   action="https://formspree.io/f/contact-form"

   method="post"

   class="contact-form"

 >

Good job 💯 👍 with your Formspree. So, I noticed that the user
can't send a message after completing all fields and clicking the Get
in touch button. I think you should create an account and you'll
have a unique key that you will use in: action="
https://formspree.io/f/form_id".

—
Reply to this email directly, view it on GitHub
https://github.com/dd-obua/Dan-portfolio/pull/3#pullrequestreview-917466407,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVNN55FHHN462XIS2W7O5W3VBHROPANCNFSM5RK2CWUQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Create Profile.md

Why:
Closes [issue link]
What's being changed:

Check off the following:

[ ] For workflow changes, I have verified the Actions workflows function as expected.
[ ] For content changes, I have reviewed the style guide.

I like this

This is looking good. I left a few comments that should be addressed  before this PR gets merged

Ynsubscribe
Pada tanggal Sen, 7 Nov 2022 04.14, AhaliaSuresh @.***>
menulis:

Reopened #156 https://github.com/skills/introduction-to-github/pull/156.
—
Reply to this email directly, view it on GitHub
https://github.com/skills/introduction-to-github/pull/156#event-7747857055,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZRBEW5I4FB57ZXXTNPRCCLWHAGS5ANCNFSM6AAAAAARYSQY4A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***
com>

Hi

Create profile.md


unnecessary_cast false positive

Describe the issue
I have a function with a generic type T extends Object?. Somewhere in the middle of my function, I have a test to see if my variable T object is DateTime?. I'm not sure how to describe this better than showing you the code (it can be tested with dartpad.dev):
To Reproduce
import 'package:intl/intl.dart';

/// This is an extension method so I don't always have to test for nullable values*
extension Apply<T extends Object> on T {
  R apply<R>(R Function(T self) transform) => transform(this);
}

void func<T extends Object?>(T object) {
  if (object is DateTime?) {
    final formatter = DateFormat('yyyy/MM/dd');
    object?.day; // No lint
    if (object != null) {
      formatter.format(object); // No lint
    }
    object?.apply(formatter.format); // The argument type 'String Function(DateTime)' can't be assigned to the parameter type 'dynamic Function(T)'.
    (object as DateTime?)?.apply(formatter.format); // Unnecessary cast.
  }
}

*Here is where I found it
Expected behavior
Either not triggering unnecessary_cast or not triggering the error with the line above as all the other code before works just fine.

Has this been fixed? Asking because of https://github.com/dart-lang/sdk/issues/53828#issuecomment-1819340328

It's possible. I'm not sure. I haven't specifically reproduced this one.

To help a little, I've tested it myself in the latest master, and the unnecessary_cast is not triggering anymore.

Thanks for retesting in the latest master, @FMorschel! I'm glad that the issue isn't triggering for you anymore.
I'm sorry to say that sometimes this sort of thing happens; we don't get around to fully investigating an issue before something else changes and the issue stops occurring. When this happens, it can be difficult to dig through the project history to figure out whether the bug was fixed on purpose (say, because someone else ran into it in a different form, and their issue got addressed), or whether it just kind of "went into hiding" because something else changed. Sometimes I go ahead and dig anyhow because I'm curious, or because I'm worried that maybe there's a deeper problem that still hasn't been solved. But we're all busy, so more often than not what happens at this point is that we close the issue and move on to other things.
In this particular case, I think it would be worth doing a bit more investigation, in particular into @scheglov's comment saying that we don't infer R correctly.
If I'm understanding that comment correctly, @scheglov is referring to this line from his repro of the issue:
       substitution: {T2: T, R: R}

Which suggests that when applying the extension apply, the analyzer is substituting a type of R for R. But R isn't a well-formed type at the point where apply is used; it's not even in scope:
void f<T extends Object?>(T object) {
  if (object is int?) {
    object?.apply(g);
  }
}

That seems like a problem that could potentially underlie a lot of bugs.
And just because this unnecessary_cast false positive isn't happening anymore, doesn't necessarily mean that the problem with R isn't still occurring. In fact, I suspect that the problem with R and the unnecessary cast might be unrelated, because the type parameter R only affects type checking at g, whereas the unnecessary cast had to do with the target of the extension method, object.
@scheglov, do you think you could repeat your experiment and see if R is still being substituted with an ill-formed type?

The test in https://github.com/dart-lang/sdk/issues/52117#issuecomment-1516918340 still produces the same resolution, with substitution: {T2: T, R: R}.

just because this unnecessary_cast false positive isn't happening anymore, doesn't necessarily mean that the problem with R isn't still occurring

If you then think renaming this issue to make sure we are clear about solving this substitution problem, since the unnecessary_cast false positive isn't happening anymore, would be better, then by all means, do so. I don't feel like I understand enough of the problem to make a good issue title.

Sorry for the ping, @stereotype441, but I just wanted to know if you ever saw my last comment about renaming this. Or we could even open a new issue to fix that substitution problem and differ from this. I've not tested it again so that might be a good thing to do just to make sure it is still happening.

Sorry for the ping, @stereotype441, but I just wanted to know if you ever saw my last comment about renaming this. Or we could even open a new issue to fix that substitution problem and differ from this. I've not tested it again so that might be a good thing to do just to make sure it is still happening.

Good point, thanks! I've re-titled the issue.

I think the core of this issue is when and how an intersection type is erased to a reifiable type.
As noted in https://github.com/dart-lang/sdk/issues/56028, actual type arguments for an extension in an extension member invocation (that is, for the extension itself, not for the member) are computed in the same way as the actual type arguments of a constructor invocation with a corresponding class. So we should get the same outcome (in particular, the same error) in the original example here as we do with the following example:
import 'package:intl/intl.dart';

class Apply<T extends Object> {
  final T t;
  Apply(this.t);
  R apply<R>(R Function(T self) transform) => transform(t);
}

void func<T extends Object?>(T object) {
  if (object is DateTime?) {
    final formatter = DateFormat('yyyy/MM/dd');
    if (object != null) {
      // Type of `object` is `T & DateTime`, same as receiver type with `object?.apply(...)`.
      Apply(object).apply(formatter.format); // Error.
    }
  }
}

This example yields the following error message at // Error.:
The argument type 'String Function(DateTime)' can't be assigned to the parameter type 'dynamic Function(T)'.

which is exactly the same error message that we get with the extension member invocation in the original example. However, I would in both cases have expected the error message to acknowledge that the type inference step does not produce a binding for the given type variable that satisfies the constraints. Just like this example:
void f<X extends num>(X x) {}
void main() => f('Hello'); // Error: "Couldn't infer type parameter 'X'".

Considering that the developer did not choose the given value for the type variable T (in the Apply examples), it seems unreasonable to complain that the chosen value doesn't work.
Next, it is surprising that the parameter type in the Apply example is described as dynamic Function(T), because this implies that .apply(...) is processed during static analysis under the assumption that the receiver has type Apply<T>, in spite of the fact that T does not satisfy the requirement on actual type arguments to Apply (because it isn't known to be a subtype of Object).
Consider this example:
class A<T extends Object> {
  void apply(T t) {}
}

void f<X extends Object?>(X x) {
  A().apply(x); // Error "The argument type 'X' can't be assigned to the parameter type 'Object'".
}

In this case we do not assume that the receiver has type A<X>. Instead, A<Object> is assumed, which means that apply has parameter type Object, and that makes it an error to pass x as the actual argument.
This seems to imply that the Apply example proceeds to accept a receiver type of Apply<T> even though that type is a compile-time error, possibly because it's really Apply<T & DateTime> (which is a malformed type because T & DateTime cannot be reified, but it would satisfy the subtyping constraints if it hadn't been considered malformed). Similarly for the example where Apply is an extension.

Coming back to this issue, I can see that it may not be obvious how to characterize the observed behavior, or what to do next. So here's a shorter version of what I tried to say in the previous comment. ;-)
Here is the core of the example program again, simplified a bit and modified to invoke the extension method with . rather than ?. as well:
extension Apply<T extends Object> on T {
  R apply<R>(R Function(T self) transform) => transform(this);
}

Object? f(DateTime _) => null;

void func<T extends Object?>(T object) {
  if (object is DateTime?) {
    object?.apply(f); // ... type can't be assigned ...
    if (object != null) {
      object.apply(f); // ... type can't be assigned ...
    }
  }
}

The observed behavior of the analyzer is understandable in the sense that object?.apply(f) should give rise to a failure as stated in the actual error message: "The argument type 'String Function(DateTime)' can't be assigned to the parameter type 'dynamic Function(T)'", given that the type parameter T of the extension Apply has been bound to T extends Object? (which is declared by func).
However, we should never have reached that point because Apply is not an applicable extension for this invocation because that actual type argument fails to satisfy the declared bound.
I think the fix could be to erase the receiver type from T & Datetime to T during the step where extension applicability is checked. We would then determine that no extensions are applicable, and .apply is simply an unknown member name.
Fun fact: If we force that outcome by using a different member name then we get the following:

The method 'notApply' isn't defined for the type ''.

Shouldn't that be a specific type rather than ''?


Add tests for data element Post and fix bug with AbandonChanges

Fix a bug where you had to add more than 1 issues (instead of at least 1 issue) in AbandonAllChanges.
Related Issue(s)

This includes tests for  #870

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
[ ] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Maybe a good candidate for making a HasAbandonIssues prop to keep the conditional only one place?

Or just a ProblemDetails GetAbandonResponse() to internalise the mapping to a ProblemDetails instance as well?

I would not use the ASP.NET Core ProblemDetails model directly in there, I think that responsibility (deciding what to return in the API) should lie in the API/outer layer. Maybe an extension method or something?
The IInstanceMutator property could be something like HasAbandonIssues(out IEnumerable<AbandonIssue> issues) to access the actual data?


Grind Session Antipiracy screen

tonyhax version: 1.4.3
Game name: Grind Session
Game code: SCUS-94568
Executable hash: MD5: 1b2ba55bc3eb92250b292a96ba93c656
Triggered at: Around 10 seconds after you start the first level in Competition mode, when a CDDA music track is supposed to begin playing
Is the console chipped?: No
Is it an original disc or a burned copy?: Burned copy
Also want to point out this is being played on an SCPH-30001 PS2, if it makes any difference.

Fixed in 90c989d121aa3d106c4a6a90744b7106d0b1d6f9. Will be available in next tonyhax v1.4.4.


fix: break bilibili website

It seems that v3 now breaks normal access to bilibili due to remove origin.
We might need to find a way to limit scope of request redirects.

I thought rule.json only modify requests from our extension, you mean it will modify all request from chrome？

I thought rule.json only modify requests from our extension, you mean it will modify all request from chrome？

Yes, it seems that I normal my access to bilibili breaks!

webRequest API also modify all requests, I recall some bug occured (like visit official page breaks) when hack referer has bugs. So in the future, we need to keep an eye on visit official websites when modify related function. :)


Add API endpoint for currencies

Please update doc https://github.com/rubykube/peatio/blob/master/docs/api/member_api_v2.md

@ysv Travis CI will do this for us.
https://github.com/rubykube/peatio/blob/dc52324d4be87ab725056d922d5058b4ed60eda4/bin/bump#L35

@shal I don't think we run bump in master

@ysv I think we do
https://github.com/rubykube/peatio/blob/dc52324d4be87ab725056d922d5058b4ed60eda4/ci/bump.rb#L103

@shal I don't think so https://github.com/rubykube/peatio/blob/dc52324d4be87ab725056d922d5058b4ed60eda4/ci/bump.rb#L227

@ysv you won :smile:

@ysv I updated member API documentation according to this patch.

@ysv Ready.

@shal looks good for me

@ysv Please, push this PR into wb1 branch to test it.


fixcreate mtmv failed when not specifying refresh strategy

Proposed changes
Issue Number: close #20686

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


how to add a skip button on taptargetview for cancel the session,because after start a taptargetview it not allow to touch at any other view of xml, but i need to allow a touch on skip button ,which present in my xml activity,android

[x] I have verified the issue exists on the latest version
[x] I am able to reproduce it

Version used:
Stack trace:
Android version:

This isn't supported and isn't how the library is supposed to be used. You should instead treat a cancel as a skip.


uwsgi: enable cgi plugin

How to use it with nginx and PHP:
location ~ (index)\.php$ {
  include ${pkgs.nginx}/conf/uwsgi_params;
  uwsgi_modifier1 9;
  uwsgi_pass unix:/run/uwsgi/cgi.sock;
}

services.uwsgi = {
  enable = true;
  user = "nginx";
  group = "nginx";
  instance = {
    type = "emperor";
    vassals = {
      mycgi = {
        type = "normal";
        socket = "/run/uwsgi/cgi.sock";
        async = 50;
        ugreen = true;
        cgi = "/var/www/webapp";
        cgi-allowed-ext = ".php";
        cgi-helper = ".php=${pkgs.php}/bin/php-cgi";
        plugins = [ "cgi" ];
      };
    };
  };
  plugins = [ "cgi" ];
};

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Tested that it builds. Thanks!


Recipe test results for v2.10

Recipe test results for v2.10
Here is an overview of the tests done by @zklaus for releasing v2.10. The results will be available in https://esmvaltool.dkrz.de/shared/esmvaltool/ later today.
Recipe running session 2023-11-22
Recipes that ran successfully (116 out of 152)

recipe_albedolandcover.yml
recipe_anav13jclim.yml
recipe_arctic_ocean.yml
recipe_autoassess_landsurface_permafrost.yml
recipe_autoassess_landsurface_soilmoisture.yml
recipe_autoassess_landsurface_surfrad.yml
recipe_autoassess_stratosphere.yml
recipe_bock20jgr_fig_6-7.yml
recipe_bock20jgr_fig_8-10.yml
recipe_capacity_factor.yml
recipe_carvalhais14nat.yml
recipe_climwip_brunner2019_med.yml
recipe_climwip_brunner20esd.yml
recipe_climwip_test_basic.yml
recipe_climwip_test_performance_sigma.yml
recipe_clouds_ipcc.yml
recipe_cmug_h2o.yml
recipe_combined_indices.yml
recipe_concatenate_exps.yml
recipe_consecdrydays.yml
recipe_correlation.yml
recipe_cox18nature.yml
recipe_cvdp.yml
recipe_deangelis15nat.yml
recipe_deangelis15nat_fig1_fast.yml
recipe_decadal.yml
recipe_diurnal_temperature_index.yml
recipe_ecs.yml
recipe_ecs_constraints.yml
recipe_ecs_scatter.yml
recipe_ensclus.yml
recipe_era5-land.yml
recipe_esacci_lst.yml
recipe_esacci_oc.yml
recipe_extract_shape.yml
recipe_extreme_events.yml
recipe_extreme_index.yml
recipe_flato13ipcc_figure_914.yml
recipe_flato13ipcc_figure_924.yml
recipe_flato13ipcc_figure_942.yml
recipe_flato13ipcc_figure_945a.yml
recipe_flato13ipcc_figure_96.yml
recipe_flato13ipcc_figure_98.yml
recipe_flato13ipcc_figures_926_927.yml
recipe_flato13ipcc_figures_92_95.yml
recipe_flato13ipcc_figures_938_941_cmip3.yml
recipe_flato13ipcc_figures_938_941_cmip6.yml
recipe_galytska23jgr.yml
recipe_gier2020bg.yml
recipe_globwat.yml
recipe_heatwaves_coldwaves.yml
recipe_hydro_forcing.yml
recipe_hyint.yml
recipe_hyint_extreme_events.yml
recipe_hype.yml
recipe_iht_toa.yml
recipe_impact.yml
recipe_ipccwg1ar6ch3_fig_3_43.yml
recipe_kcs.yml
recipe_lauer22jclim_fig2_taylor.yml
recipe_lauer22jclim_fig2_taylor_amip.yml
recipe_li17natcc.yml
recipe_lisflood.yml
recipe_martin18grl.yml
recipe_meehl20sciadv.yml
recipe_miles_block.yml
recipe_miles_eof.yml
recipe_miles_regimes.yml
recipe_modes_of_variability.yml
recipe_monitor.yml
recipe_monitor_with_refs.yml
recipe_mpqb_xch4.yml
recipe_multimodel_products.yml
recipe_my_personal_diagnostic.yml
recipe_ncl.yml
recipe_ocean_Landschuetzer2016.yml
recipe_ocean_amoc.yml
recipe_ocean_bgc.yml
recipe_ocean_example.yml
recipe_ocean_ice_extent.yml
recipe_ocean_multimap.yml
recipe_ocean_quadmap.yml
recipe_ocean_scalar_fields.yml
recipe_perfmetrics_CMIP5.yml
recipe_perfmetrics_CMIP5_4cds.yml
recipe_perfmetrics_land_CMIP5.yml
recipe_preprocessor_derive_test.yml
recipe_preprocessor_test.yml
recipe_pv_capacity_factor.yml
recipe_python.yml
recipe_python_for_CI.yml
recipe_quantilebias.yml
recipe_r.yml
recipe_radiation_budget.yml
recipe_runoff_et.yml
recipe_schlund20esd.yml
recipe_sea_surface_salinity.yml
recipe_seaborn.yml
recipe_seaice.yml
recipe_seaice_feedback.yml
recipe_shapeselect.yml
recipe_smpi.yml
recipe_smpi_4cds.yml
recipe_snowalbedo.yml
recipe_spei.yml
recipe_tcr.yml
recipe_thermodyn_diagtool.yml
recipe_toymodel.yml
recipe_validation.yml
recipe_validation_CMIP6.yml
recipe_variable_groups.yml
recipe_weigel21gmd_figures_13_16.yml
recipe_wenzel16jclim.yml
recipe_wflow.yml
recipe_williams09climdyn_CREM.yml
recipe_zmnam.yml

Recipes that failed because the diagnostic script failed (19 out of 152)

recipe_collins13ipcc.yml
recipe_eady_growth_rate.yml
recipe_julia.yml
recipe_landcover.yml
recipe_lauer22jclim_fig1_clim.yml
recipe_lauer22jclim_fig1_clim_amip.yml
recipe_lauer22jclim_fig3-4_zonal.yml
recipe_lauer22jclim_fig6_interannual.yml
recipe_lauer22jclim_fig7_seas.yml
recipe_lauer22jclim_fig8_dyn.yml
recipe_lauer22jclim_fig9-11ab_scatter.yml
recipe_lauer22jclim_fig9-11c_pdf.yml
recipe_psyplot.yml
recipe_rainfarm.yml
recipe_russell18jgr.yml
recipe_seaice_drift.yml
recipe_tebaldi21esd.yml
recipe_wenzel14jgr.yml
recipe_wenzel16nat.yml

Recipes that failed because of missing data (4 out of 152)

recipe_bock20jgr_fig_1-4.yml
recipe_check_obs.yml
recipe_clouds_bias.yml
recipe_lauer13jclim.yml

Recipes that failed because they used too much memory (1 out of 152)

recipe_pcrglobwb.yml

Recipes that failed of other reasons (12 out of 152)

recipe_climate_change_hotspot.yml
recipe_daily_era5.yml
recipe_easy_ipcc.yml
recipe_eyring06jgr.yml
recipe_eyring13jgr_12.yml
recipe_ipccwg1ar6ch3_atmosphere.yml
recipe_ipccwg1ar6ch3_fig_3_19.yml
recipe_ipccwg1ar6ch3_fig_3_42_a.yml
recipe_ipccwg1ar6ch3_fig_3_42_b.yml
recipe_ipccwg1ar6ch3_fig_3_9.yml
recipe_lauer22jclim_fig5_lifrac.yml
recipe_marrmot.yml

Unfortunately, the results were written to a scratch disk and left there for too long, resulting in part of them to be deleted. We will need to do a new run so this will take a bit longer.

great stuff, folks! Here's me looking at the odd 17 ones that died of unnatural causes, of various reasons (not data or diag):

collins13 - the file /home/b/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12/recipe_collins13ipcc_20231212_210804/preproc/IAV_calc_rtmt/rtmt/CMIP5_CNRM-CM5_Amon_piControl_r1i1p1_rtmt_1850-2699.nc that is causing a HDF5 issue is healthy, it is very possible a read was attempted while another process hadn't finished writing/closing it; a rerun should prob fix that
daily_era5 - it just died, prob node killed it for some personal reason
same as for easy_ipcc
same as for both eyrings
ipccAr6_atmosphere - file /home/b/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12/recipe_ipccwg1ar6ch3_atmosphere_20231212_212329/preproc/IAV_calc_tas_cmip5/tas/CMIP5_CCSM4_Amon_piControl_r1i1p1_tas_0250-1300.nc is perfectly fine, prob the same issue as above for collins13

recipe_psyplot fails due to an issue of geos, which will apparantly be fixed in their new version 3.13 (we currently have 3.11).

good find @schlunma :beer: Our env is getting somewhat rather old, we need that Py312 support sooner than later (working on it for Core, stuck at prospector, the last hurdle)

lauer22_Fig5_lifrac fails to realize data from a (240, 91, 360, 720) array with dtype('float64') - needs be run on a hefty memory node

a lot of those 17 recipes, that failed with other reasons, simply die out - all goes fine until they just stop in their tracks - any info from the SLURM logs? It looks to me like they were just run on an interactive node and the user timed out, with the system killing the session, and implicitly, the running process

I just successfully ran my 3 schlundjgr recipes, updated them in the table.
Regarding the NCL failures: Could you please cherry-pick https://github.com/ESMValGroup/ESMValTool/commit/1647d46ee3c5deb084fa4ac59024a46581d618c3 into the release branch? This needs to be in there (see https://github.com/ESMValGroup/ESMValTool/issues/3420). I just ran wenzel16jclim successfully with the current main branch.

Regarding the NCL failures: Could you please cherry-pick https://github.com/ESMValGroup/ESMValTool/commit/1647d46ee3c5deb084fa4ac59024a46581d618c3 into the release branch? This needs to be in there (see https://github.com/ESMValGroup/ESMValTool/issues/3420). I just ran wenzel16jclim successfully with the current main branch.

I pulled this in, but it is giving me these issues:
$ cat /home/b/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12/recipe_tebaldi21esd_20231213_193814/run/fig1b/plot_ts_line_mean_spread_pr/log.txt
 Copyright (C) 1995-2019 - All Rights Reserved
 University Corporation for Atmospheric Research
 NCAR Command Language Version 6.6.2
 The use of this software is governed by a License Agreement.
 See http://www.ncl.ucar.edu/ for more details.
INFO    Loading settings from /home/b/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12/recipe_tebaldi21esd_20231213_193814/run/fig1b/plot_ts_line_mean_spread_pr/settings.ncl
INFO    Loading input data description from /home/b/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12/recipe_tebaldi21esd_20231213_193814/preproc/fig1b/pr/pr_info.ncl
INFO     Wrote /home/b/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12/recipe_tebaldi21esd_20231213_193814/plots/fig1b/plot_ts_line_mean_spread_pr//pr_ts_line_1850_2100.pdf
INFO    fatal: in log_provenance (interface_scripts/logging.ncl), outfile (path to figure) '/home/b/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12/recipe_tebaldi21esd_20231213_193814/plots/fig1b/plot_ts_line_mean_spread_pr//pr_ts_line_1850_2100.pdf' does not exist (for PNGs, this function also searches for 'FILE.000001.png', 'FILE.000002.png', etc.); if no plot file is available use 'n/a'

and
$ cat /home/b/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12/recipe_collins13ipcc_20231213_193815/run/ts_line_tas/ch12_plot_ts_line_mean_spread_tas/log.txt
 Copyright (C) 1995-2019 - All Rights Reserved
 University Corporation for Atmospheric Research
 NCAR Command Language Version 6.6.2
 The use of this software is governed by a License Agreement.
 See http://www.ncl.ucar.edu/ for more details.
INFO    Loading settings from /home/b/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12/recipe_collins13ipcc_20231213_193815/run/ts_line_tas/ch12_plot_ts_line_mean_spread_tas/settings.ncl
INFO    Loading input data description from /home/b/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12/recipe_collins13ipcc_20231213_193815/preproc/ts_line_tas/tas/tas_info.ncl
INFO     Wrote /home/b/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12/recipe_collins13ipcc_20231213_193815/plots/ts_line_tas/ch12_plot_ts_line_mean_spread_tas//tas_ts_line_1850_2300.pdf
INFO    fatal: in log_provenance (interface_scripts/logging.ncl), outfile (path to figure) '/home/b/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12/recipe_collins13ipcc_20231213_193815/plots/ts_line_tas/ch12_plot_ts_line_mean_spread_tas//tas_ts_line_1850_2300.pdf' does not exist (for PNGs, this function also searches for 'FILE.000001.png', 'FILE.000002.png', etc.); if no plot file is available use 'n/a'

with output_file_type: png in config-user.yml. The files with .png extension do exist, but somehow the code appears to be looking for pdf files?

@axel-lauer Could you please copy the file /work/bd0854/DATA/ESMValTool2/download/obs4MIPs/MODIS-1-0/v20180305/clt_mon_MODIS-1-0_BE_gn_200003-201109.nc to /work/bd0854/DATA/ESMValTool2/OBS/Tier1/MODIS-1-0/? That will make it possible to run recipe_clouds_bias.yml again. Unfortunately, fully automatic download from ESGF does not work because the file has outdated facets on ESGF.

The remaining NCL problems are due to a double guessing of the output filename. I think I fixed it locally, will commit soon.

The NCL fix is in #3474.

can one of you pls have a look at Julia? I want to close (and will close) https://github.com/ESMValGroup/ESMValTool/issues/3287 since the Julia looks is the only thing outstanding there (even so, it has an issue to it)

The issue with recipe_julia.yml is still open, I suspect it doesn't correctly handle fill values since the scale is at 1e20.

lemme have a look at Julia then :grin:

ahaa! Figured out Julia! netCDF package loads missing values as 1e20s, whereas NCDatasets loads them as missing - will open Draft PR (I don't speak Julia so I couldn't make it work 100%)

Recipe running session 2023-12-14
I did a re-run of all recipes affected by late changes (i.e. all NCL recipes and a few other recipes with bug/data fixes).
Recipes that ran successfully (43 out of 155)

recipe_albedolandcover.yml
recipe_anav13jclim.yml
recipe_bock20jgr_fig_1-4.yml
recipe_bock20jgr_fig_6-7.yml
recipe_bock20jgr_fig_8-10.yml
recipe_climwip_brunner2019_med.yml
recipe_climwip_test_performance_sigma.yml
recipe_clouds_ipcc.yml
recipe_ecs_constraints.yml
recipe_ecs_scatter.yml
recipe_flato13ipcc_figure_924.yml
recipe_flato13ipcc_figure_945a.yml
recipe_flato13ipcc_figure_96.yml
recipe_flato13ipcc_figure_98.yml
recipe_flato13ipcc_figures_926_927.yml
recipe_flato13ipcc_figures_92_95.yml
recipe_flato13ipcc_figures_938_941_cmip3.yml
recipe_flato13ipcc_figures_938_941_cmip6.yml
recipe_galytska23jgr.yml
recipe_gier2020bg.yml
recipe_ipccwg1ar6ch3_fig_3_43.yml
recipe_ipccwg1ar6ch3_fig_3_9.yml
recipe_landcover.yml
recipe_lauer22jclim_fig2_taylor.yml
recipe_lauer22jclim_fig2_taylor_amip.yml
recipe_miles_regimes.yml
recipe_monitor.yml
recipe_monitor_with_refs.yml
recipe_ncl.yml
recipe_perfmetrics_CMIP5.yml
recipe_perfmetrics_CMIP5_4cds.yml
recipe_perfmetrics_land_CMIP5.yml
recipe_radiation_budget.yml
recipe_schlund20esd.yml
recipe_seaice.yml
recipe_smpi.yml
recipe_smpi_4cds.yml
recipe_snowalbedo.yml
recipe_validation.yml
recipe_validation_CMIP6.yml
recipe_weigel21gmd_figures_13_16.yml
recipe_wenzel16jclim.yml
recipe_wflow.yml

Recipes that failed because the diagnostic script failed (10 out of 155)

recipe_lauer22jclim_fig1_clim.yml
recipe_lauer22jclim_fig1_clim_amip.yml
recipe_lauer22jclim_fig6_interannual.yml
recipe_lauer22jclim_fig7_seas.yml
recipe_lauer22jclim_fig8_dyn.yml
recipe_lauer22jclim_fig9-11ab_scatter.yml
recipe_lauer22jclim_fig9-11c_pdf.yml
recipe_russell18jgr.yml
recipe_wenzel14jgr.yml
recipe_wenzel16nat.yml

Recipes that failed because of missing data (2 out of 155)

recipe_clouds_bias.yml https://github.com/ESMValGroup/ESMValTool/issues/3463#issuecomment-1855457167
recipe_lauer13jclim.yml https://github.com/ESMValGroup/ESMValTool/issues/3463#issuecomment-1855457167

Recipes that failed because the run took too long (8 out of 155)

recipe_climate_change_hotspot.yml
recipe_eyring06jgr.yml
recipe_eyring13jgr_12.yml
recipe_ipccwg1ar6ch3_fig_3_19.yml
recipe_ipccwg1ar6ch3_fig_3_42_a.yml
recipe_ipccwg1ar6ch3_fig_3_42_b.yml
recipe_lauer22jclim_fig5_lifrac.yml

Recipes that failed because they used too much memory (1 out of 155)

recipe_lauer22jclim_fig3-4_zonal.yml (failed on node with 256GB RAM)

Recipes that failed with HDF5 errors (3 out of 155)

recipe_collins13ipcc.yml
recipe_ipccwg1ar6ch3_atmosphere.yml
recipe_tebaldi21esd.yml

@axel-lauer Could you please copy the file /work/bd0854/DATA/ESMValTool2/download/obs4MIPs/MODIS-1-0/v20180305/clt_mon_MODIS-1-0_BE_gn_200003-201109.nc to /work/bd0854/DATA/ESMValTool2/OBS/Tier1/MODIS-1-0/ on Levante?

Done.

Some conclusions based on the above:

Recent changes to how NCL recipes record provenance have left 10 recipes broken (see #3422, #3474)
The HD5 errors are reprodicible
I suspect that the longer run durations for some recipes are caused by a degradation in performance of the default dask scheduler

Is the output of these tests available somewhere?

Hm. I yesterday ran successfully two of the HDF5 problematic recipes (collins and tebaldi). I also ran successfully wenzel16jclim, though wenzel14jgr continues to fail also for me.

I have not uploaded it yet, but you can access it on Levante:
slurm logs: /home/b/b381141/esmvaltool-v2.10.x-2023-12-14-logs
esmvaltool output: /work/bd0854/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12

Here is the HDF error if anyone is interested:
stdout:
OSError: [Errno -101] NetCDF: HDF error: '/home/b/b381141/esmvaltool_output/esmvaltool-v2.10.x-2023-12-12/recipe_tebaldi21esd_20231214_174448/preproc/fig6c_IAV/tas/CMIP6_MRI-ESM2-0_Amon_piControl_r1i1p1f1_tas_gn_1850-2150.nc'

stderr:
  #000: H5F.c line 836 in H5Fopen(): unable to synchronously open file
    major: File accessibility
    minor: Unable to open file
  #001: H5F.c line 796 in H5F__open_api_common(): unable to open file
    major: File accessibility
    minor: Unable to open file
  #002: H5VLcallback.c line 3863 in H5VL_file_open(): open failed
    major: Virtual Object Layer
    minor: Can't open object
  #003: H5VLcallback.c line 3675 in H5VL__file_open(): open failed
    major: Virtual Object Layer
    minor: Can't open object
  #004: H5VLnative_file.c line 128 in H5VL__native_file_open(): unable to open file
    major: File accessibility
    minor: Unable to open file
  #005: H5Fint.c line 1873 in H5F_open(): unable to lock the file
    major: File accessibility
    minor: Unable to lock file
  #006: H5FD.c line 2034 in H5FD_lock(): driver lock request failed
    major: Virtual File Layer
    minor: Unable to lock file
  #007: H5FDsec2.c line 988 in H5FD__sec2_lock(): unable to lock file, errno = 11, error message = 'Resource temporarily unavailable'
    major: Virtual File Layer
    minor: Unable to lock file

I messed up the check for file existence in https://github.com/ESMValGroup/ESMValTool/pull/3422, which gives these wrong NCL errors about non-existing plot files. Should be fixed by #3477 (I tested this successfully with wenzel14jgr, but since the other NCL errors are similar I guess those should run, too :crossed_fingers: )

Thanks, running them again now..

H5FDsec2.c line 988 in H5FD__sec2_lock(): unable to lock file, errno = 11, error message = 'Resource temporarily unavailable'

there is I/O toestepping going on - this is a fairly common HDF5 barf if the file is already opened by a process while another process is trying to open and read it/write to it - see eg https://github.com/h5py/h5py/issues/1066 and a bunch of other people complaining about it since years ago. We need to understand what process opens the file and what other process is trying to do the same, but I think that's probably just on SLURM and that's not gonna be a straightforward task. At least, I'd be up for it but not today, and not before Xmas :christmas_tree:

Good news, all NCL with diag failures except for recipe_russel18jgr run now :tada:
recipe_russel18jgr fails since some of the diagnostic don't write plots (but judging from the code they are supposed to do that). This has already been the case for the v2.9.0 release, but became evident now due to the changes in the NCL provenance code. I opened an issue here: https://github.com/ESMValGroup/ESMValTool/issues/3478
Since both maintainers of this recipe are not really active anymore, I suggest we flag this recipe as broken. @ESMValGroup/esmvaltool-coreteam opinions?

Here is a PR that fixes some issues in the russell recipe: https://github.com/ESMValGroup/ESMValTool/pull/3479. With this, all diagnostics except for the ones listed in #3478 work again.

Here are the results from the comparison with v2.9.

Here is a summary of the comparison results
Plots and data are different

recipe_albedolandcover.yml
recipe_bock20jgr_fig_6-7.yml (probably due to #3324)
recipe_clouds_bias.yml (probably due to #3326)
recipe_ecs_constraints.yml (probably due to #3327)
recipe_ecs_scatter.yml (different filesnames due to #3327)
recipe_kcs.yml (at least partly due to #3351)
recipe_lauer13jclim.yml (probably due to #3326)
recipe_modes_of_variability.yml
recipe_monitor_with_refs.yml
recipe_multimodel_products.yml
recipe_perfmetrics_CMIP5.yml (probably due to #3325)
recipe_perfmetrics_CMIP5_4cds.yml (probably due to #3325)
recipe_perfmetrics_land_CMIP5.yml (probably due to #3325)
recipe_schlund20esd.yml (probably due to #3329)
recipe_toymodel.yml

Only plots are different

recipe_arctic_ocean.yml
recipe_eady_growth_rate.yml
recipe_martin18grl.yml
recipe_monitor.yml
recipe_mpqb_xch4.yml
recipe_ocean_Landschuetzer2016.yml
recipe_ocean_amoc.yml
recipe_ocean_bgc.yml
recipe_ocean_example.yml
recipe_ocean_ice_extent.yml
recipe_ocean_multimap.yml
recipe_seaborn.yml
recipe_spei.yml
recipe_validation.yml

Only data are different

recipe_autoassess_landsurface_soilmoisture.yml
recipe_bock20jgr_fig_1-4.yml (probably due to #3324)
recipe_bock20jgr_fig_8-10.yml
recipe_climwip_brunner2019_med.yml
recipe_climwip_brunner20esd.yml
recipe_climwip_test_basic.yml
recipe_climwip_test_performance_sigma.yml
recipe_clouds_ipcc.yml (probably due to #3326)
recipe_daily_era5.yml
recipe_flato13ipcc_figure_914.yml
recipe_flato13ipcc_figure_98.yml
recipe_flato13ipcc_figures_92_95.yml
recipe_flato13ipcc_figures_938_941_cmip6.yml
recipe_galytska23jgr.yml
recipe_gier2020bg.yml
recipe_ipccwg1ar6ch3_fig_3_43.yml
recipe_lauer22jclim_fig1_clim.yml
recipe_lauer22jclim_fig1_clim_amip.yml
recipe_lauer22jclim_fig7_seas.yml
recipe_lauer22jclim_fig8_dyn.yml
recipe_marrmot.yml (different matlab files)
recipe_rainfarm.yml
recipe_runoff_et.yml
recipe_smpi.yml
recipe_smpi_4cds.yml
recipe_validation_CMIP6.yml

Results are the same as v2.9

recipe_anav13jclim.yml
recipe_autoassess_landsurface_permafrost.yml (but recipe appears to write provenance interface file to wrong directory)
recipe_autoassess_landsurface_surfrad.yml (but recipe appears to write provenance interface file to wrong directory)
recipe_autoassess_stratosphere.yml
recipe_capacity_factor.yml
recipe_cmug_h2o.yml
recipe_combined_indices.yml
recipe_concatenate_exps.yml
recipe_consecdrydays.yml
recipe_correlation.yml
recipe_cox18nature.yml
recipe_cvdp.yml
recipe_deangelis15nat.yml
recipe_deangelis15nat_fig1_fast.yml
recipe_decadal.yml
recipe_diurnal_temperature_index.yml
recipe_ecs.yml
recipe_ensclus.yml
recipe_era5-land.yml
recipe_esacci_lst.yml
recipe_esacci_oc.yml
recipe_extract_shape.yml
recipe_extreme_events.yml
recipe_extreme_index.yml
recipe_flato13ipcc_figure_924.yml
recipe_flato13ipcc_figure_942.yml
recipe_flato13ipcc_figure_945a.yml
recipe_flato13ipcc_figure_96.yml
recipe_flato13ipcc_figures_926_927.yml
recipe_flato13ipcc_figures_938_941_cmip3.yml
recipe_globwat.yml
recipe_heatwaves_coldwaves.yml
recipe_hydro_forcing.yml
recipe_hyint.yml
recipe_hyint_extreme_events.yml
recipe_hype.yml
recipe_impact.yml
recipe_ipccwg1ar6ch3_fig_3_9.yml
recipe_julia.yml
recipe_landcover.yml
recipe_lauer22jclim_fig2_taylor.yml
recipe_lauer22jclim_fig2_taylor_amip.yml
recipe_lauer22jclim_fig6_interannual.yml
recipe_lauer22jclim_fig9-11ab_scatter.yml
recipe_lauer22jclim_fig9-11c_pdf.yml
recipe_li17natcc.yml
recipe_lisflood.yml
recipe_meehl20sciadv.yml
recipe_miles_block.yml
recipe_miles_eof.yml
recipe_miles_regimes.yml
recipe_my_personal_diagnostic.yml
recipe_ncl.yml
recipe_ocean_quadmap.yml
recipe_ocean_scalar_fields.yml
recipe_pcrglobwb.yml
recipe_preprocessor_derive_test.yml
recipe_preprocessor_test.yml
recipe_pv_capacity_factor.yml
recipe_python.yml
recipe_python_for_CI.yml
recipe_quantilebias.yml
recipe_r.yml
recipe_radiation_budget.yml
recipe_sea_surface_salinity.yml
recipe_seaice.yml
recipe_seaice_feedback.yml
recipe_snowalbedo.yml
recipe_tcr.yml
recipe_thermodyn_diagtool.yml
recipe_variable_groups.yml
recipe_weigel21gmd_figures_13_16.yml
recipe_wenzel14jgr.yml
recipe_wenzel16jclim.yml
recipe_wenzel16nat.yml
recipe_wflow.yml
recipe_williams09climdyn_CREM.yml
recipe_zmnam.yml

Unable to compare because no reference run for v2.9

recipe_carvalhais14nat.yml
recipe_easy_ipcc.yml (new recipe)
recipe_iht_toa.yml
recipe_shapeselect.yml

Is it possible to see the result/log of the comparison tool? Visually I don't find any difference in the figures of recipe_martin18grl.yml, but is has a lot of Figures, so I might have missed it.

Yes, they are posted in https://github.com/ESMValGroup/ESMValTool/issues/3463#issuecomment-1859257090

Thanks! (And sorry that I didn't get the idea to look at the post before.)
The differences are tiny deviation in the way missing data are masked on the plot (really only visible, if switch between the two versions of these figures.)

autoassess, validation, and all @ledm 's oceans eleven look fine! Stellar work @bouweandela :beer:

Thanks, everyone! The release has now been published!

It's a Christmas miracle 🎄 🎅


chore: Theme Improvements for Primary Course Card

Description
Improve Primary Course Card CTAs Background Color (left is for light & right is for dark):

Attachments

Before
After
Before
After

Fixes: LEARNER-10078

I don't think this should be upstreamed as-is. I'm unclear on the benefit of adding additional colors to the quick actions, is there some reason to make hierarchy obvious for course options beyond primary quick action / secondary quick actions?

hey Sam, the main goal of adding additional colors to the quick actions is to provide a more intuitive and visually distinct hierarchy for course options. By differentiating the primary quick actions from the secondary ones, we aim to improve usability and guide users more effectively to the most critical actions.
This distinction can be particularly helpful in scenarios where users need to quickly prioritize their actions or where secondary options might otherwise blend in and go unnoticed.


Security error in provision new bundle

Hi!
I'd try today to change ansible module from kubernetes module to asb module and catch access error in deployment. I try:

Run apb provision from:

system:admin
developer
developer (with cluster-admin policy)

Run openshift-permissions.template.yaml
run in different projects:

openshift
test (my create project)

Run through:

GUI
CLI

Run with different sandbox roles:

admin
edit

My system:
minishift v1.27.0+707887e

oc v3.11.0+0cbc58b
kubernetes v1.11.0+d4cacc0
features: Basic-Auth

Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.3", GitCommit:"2bba0127d85d5a46ab4b778548be28623b32d0b0", GitTreeState:"clean", BuildDate:"2018-05-21T09:17:39Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.0+d4cacc0", GitCommit:"d4cacc0", GitTreeState:"clean", BuildDate:"2018-11-20T19:51:55Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}

Logs output:
TASK [nginx-simple : Create NGINX Example deployment config] *******************
fatal: [localhost]: FAILED! => {"changed": false, "error": 403, "msg": "Failed to retrieve requested object: {\"kind\":\"Status\",\"apiVersion\":\"v1\",\"metadata\":{},\"status\":\"Failure\",\"message\":\"deploymentconfigs.apps.openshift.io is forbidden: User \\\"system:serviceaccount:openshift:bundle-beac6728-019f-48d2-921d-1744d80ca9a5\\\" cannot list deploymentconfigs.apps.openshift.io at the cluster scope: no RBAC policy matched\",\"reason\":\"Forbidden\",\"details\":{\"group\":\"apps.openshift.io\",\"kind\":\"deploymentconfigs\"},\"code\":403}\n", "reason": "Forbidden", "status": 403}

"system:serviceaccount:openshift:bundle-beac6728-019f-48d2-921d-1744d80ca9a5\\\" cannot list deploymentconfigs.apps.openshift.io at the cluster scope

Odd. This makes me think there may be a problem with your task. Could you link please to the APB (specifically the task) that is failing?

@djzager hi! I try ro run this comman:
apb bundle provision nginx-simple --follow

I tried it under different users (like admins, cluster-admins, base-user) but all of then get this error.

@Asgoret Apologies for not being clear. I meant the source for this nginx-simple APB you are running. I would like to see the Ansible you have written for the task Create NGINX Example deployment config.

@djzager I hope not full playbook)
main.yml
- name: Read definition file from the Ansible controller file system
  k8s:
    state: present
    definition: "{{ lookup('template', 'deployment-config.yaml') }}"

and deployment config
kind: DeploymentConfig
apiVersion: v1
name: nginx-simple
namespace: '{{ namespace }}'
state: present
labels:
  app: '{{ namespace }}'
  service: nginx-simple
replicas: 1
selector:
  app: '{{ namespace }}'
  service: nginx-simple
spec_template_metadata_labels:
  app: '{{ namespace }}'
  service: nginx-simple
containers:
  - image: docker.io/twalter/openshift-nginx
    name: nginx-simple
    ports:
      - container_port: 8080
        protocol: TCP
    volumeMounts:
      - mountPath: /etc/nginx/conf.d
        name: configuration
restart_policy: Always
volumes:
  - name: configuration
    configMap:
      name: nginx-conf
      items:
        - key: nginx-conf
          path: default.conf

Could you put the name and namespace in metadata, remove state (example below) and report back?
---
kind: DeploymentConfig
apiVersion: v1
metadata:
  name: nginx-simple
  namespace: '{{ namespace }}'
labels:
  app: '{{ namespace }}'
  service: nginx-simple
replicas: 1
selector:
  app: '{{ namespace }}'
  service: nginx-simple
spec_template_metadata_labels:
  app: '{{ namespace }}'
  service: nginx-simple
containers:
  - image: docker.io/twalter/openshift-nginx
    name: nginx-simple
    ports:
      - container_port: 8080
        protocol: TCP
    volumeMounts:
      - mountPath: /etc/nginx/conf.d
        name: configuration
restart_policy: Always
volumes:
  - name: configuration
    configMap:
      name: nginx-conf
      items:
        - key: nginx-conf
          path: default.conf

@djzager yeah...ok i will do it tomorrow but i understand correctly that the default yaml from openshift doesn't work with APB and all kinds must be rewrite to APB style?

@djzager ok...seems i found error. I was logged like oc login -u test -p test and needed to login oc login https://<IP_ADDRESS>:8443 --token=AzmpyxdqUGxahINDbIu1Fb5s6AMuEvgQLJYDFfmG090 via token...i don't know, but seems it's kind of bug


[QUESTION] How to read an existing file in storage row by row?

Prerequisites

[x] Have read and understood: https://github.com/Maatwebsite/Laravel-Excel/blob/3.1/.github/SUPPORT.md
[x] Checked if your Laravel Excel version is still supported: https://docs.laravel-excel.com/3.1/getting-started/support.html#supported-versions
[x] Checked that your question isn't already asked before.
[x] Filled in the entire issue template

Versions

PHP version: 7.2
Laravel version: 6.1
Package version: 3

Description
In version 2.1 I was able to use the load method in order to grab an excel file in storage and read it row by row. I can't seem to find the same functionality in 3.0.
I need to be able to read an excel file in storage row by row so I can determine which column contains email addresses, then use said column in order to do things with.
Additional Information
n/a

You may have a look at the Import concerns page, which lists the availability of Maatwebsite\Excel\Concerns\OnEachRow (though not documented on the docs page, so you have to try/research it yourself based on the code.

toArray worked great thanks.


Exclude Length Range for Directory Enumeration

Provides an additional argument to be used with --exclude-length in order to exclude a range of content lengths. Occasionally, I've had content length enumeration come back with many slight differences due to cookies, response body caching values, UUIDs randomly generated on each request, that I want to bulk exclude, such as:
1905
2200
2199
2197

However, I don't want to specify every single one of these in the --exclude-length argument.
Instead, I added --exclude-length-range which can be used to provide a base value which will setup a Min and Max off of the base --exclude-length value.
For example, if you had an incoming content length of 2000 that you want to exclude all content lengths from 1400 - 2600, you would setup the gobuster arguments as the following:
gobuster dir -u <url> --exclude-length 2000 --exclude-length-range 600
This should also work alongside the -b arguments to combo block lengths and status codes

thanks this is already implemented in the latest versions


Optimize UserCalendar

Please do work for this task in a branch called issue-97.
Make the following changes:

[x] Optimize calendar for smaller screens.
[x] Move style code to a new CSS file.
[x] implement more comments for clarity
[x] DE-06: L61, Ensure code is readable. Intergrate code with other return code block for simplicity.

Completed as apart of issue-182


Material design bottom navigation transition

Is this possible to mimic this screen transition (the fadein one) ?
Material design video

You could try solving this via a custom transition. A first approximation would maybe be just fading over with opacity.


refactor: cleanup popcount proof

Description:
We've cleaned up the popcount proof by:

extending sym_aggregate to also search for memory effect hypotheses to simplify, and
changing the semantics of add_sub_immediate to avoid pattern-matching. It turns out that pattern-matching on the result of an if (e.g., let (a, b) := if x = 0 then (foo, bar) else (bar, foo)) get's reduced to a Decidable.rec by simp only, which then gets stuck. By rephrasing it in terms of projections, we avoid this, and get clean simplified semantics.
In the same vein, we also add existing simplification rules for AddWithCarry to the bitvec_rules simpset

Testing:
Tests haven't been run yet, and I suspect we've broken other proofs (which might now have redundant simps throwing errors), hence, the draft status.
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

To be rebased on top of https://github.com/leanprover/LNSym/pull/171

@alexkeizer after rebasing, for whatever reason, proofs in Sha512Prelude break due to maxRecDepth :(
I tried debugging this for a bit, then gave up:
✖ [129/135] Building Proofs.SHA512.SHA512Prelude
trace: .> LEAN_PATH=././.lake/packages/Cli/.lake/build/lib:././.lake/packages/ELFSage/.lake/build/lib:././.lake/packages/MD4Lean/.lake/build/lib:././.lake/packages/UnicodeBasic/.lake/build/lib:././.lake/packages/BibtexQuery/.lake/build/lib:././.lake/packages/doc-gen4/.lake/build/lib:././.lake/build/lib DYLD_LIBRARY_PATH= /Users/sidbhatz/.elan/toolchains/leanprover--lean4---nightly-2024-09-10/bin/lean ././././Proofs/SHA512/SHA512Prelude.lean -R ./././. -o ././.lake/build/lib/Proofs/SHA512/SHA512Prelude.olean -i ././.lake/build/lib/Proofs/SHA512/SHA512Prelude.ilean -c ././.lake/build/ir/Proofs/SHA512/SHA512Prelude.c --json
error: ././././Proofs/SHA512/SHA512Prelude.lean:164:0: linter Lean.Linter.constructorNameAsVariable failed: maximum recursion depth has been reached
use `set_option maxRecDepth <num>` to increase limit
use `set_option diagnostics true` to get diagnostic information
error: ././././Proofs/SHA512/SHA512Prelude.lean:283:0: maximum recursion depth has been reached
use `set_option maxRecDepth <num>` to increase limit
use `set_option diagnostics true` to get diagnostic information
error: ././././Proofs/SHA512/SHA512Prelude.lean:284:0: maximum recursion depth has been reached
use `set_option maxRecDepth <num>` to increase limit
use `set_option diagnostics true` to get diagnostic information
info: stderr:
PANIC at outOfBounds Init.GetElem:11:2: index out of bounds
PANIC at outOfBounds Init.GetElem:11:2: index out of bounds
PANIC at Lean.Elab.InfoTree.visitM.go Lean.Server.InfoUtils:56:21: unexpected context-free info tree node
PANIC at Lean.Elab.InfoTree.visitM.go Lean.Server.InfoUtils:56:21: unexpected context-free info tree node
PANIC at Lean.Elab.InfoTree.visitM.go Lean.Server.InfoUtils:56:21: unexpected context-free info tree node
PANIC at Lean.Elab.InfoTree.visitM.go Lean.Server.InfoUtils:56:21: unexpected context-free info tree node
error: Lean exited with code 1
Some required builds logged failures:
- Proofs.SHA512.SHA512Prelude
error: build failed
real 17.04
user 16.36
sys 0.46
make: *** [proofs] Error 1

@alexkeizer I think we should add an option into sym_aggregate that controls whether it tries to simplify memory as well, and to maybe gradually unroll this across the codebase?

Aha, let me try and just disable all linters...


chore(deps): upgrade compiler dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-compiler-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2119

Questions ?
Please refer to the Backport tool documentation


Bug fixes and slight QoL changes for API Users

Description

?rxx now displays the Table ID, used for the API
?TableID, displays the Table ID in plain text, so it is easy to copy on mobile.
Fixed bug where table bot crashes when you remove all races (Basically I just didnt let them remove all races)

Checklist

[X] If code changes were made, they have been tested
[X] This PR fixes an issue
[ ] This PR is not a code change (ie. documentation, typehinting, comments, etc.)

I am going to merge it with a patch branch and I will issue the patches myself since I only have time tonight to do this. I would advise going back though and looking at my comments, then trying to do the minor patch yourself.


Wait for orchestration result for marking success on minions

We are marking success depending on highstates, what makes a bit misleading
for the overall orchestration process. At this moment, orchestration will wait
for some tasks to have been completed (like some kubectl apply commands, which
apply immediately). We aren't waiting for the global orchestration result, and
this means that all minions might be marked as successful when we haven't really
waited for the overall orchestration to have finished.
This can have important implications, like not waiting for Dex to be completely
ready while the orchestration is waiting for it.
We just mark failed highstates as an early failure, but wait for the orchestration
result to finish and be succesful in order to mark pending nodes as successful.
This will also align with the current restritions in the UI to enable the kubectl config
button, since it will wait for the kubernetes master to be ready in order to be
enabled.
Fixes: bsc#1062542

Given Flavio +A'd, and the only diff between the last revision and this is the addition of a bug number to the commit message, we should go ahead and merge this.