Type check doesn't work for constants

I have an issue with a flow check on a prop type:
// ButtonInputs.js

export const ButtonTypes = {
  PRIMARY: 'primary',
  PRIMARY_SPECIAL: 'primary-special',
}

export type Button =
  | ButtonTypes.PRIMARY
  | ButtonTypes.PRIMARY_SPECIAL;

// MyCustomButton.js

import type { Button } from 'ButtonInputs';

type Props = {
  type: Button;
}

<MyCustomButton type="test" /> // WORKS! (shouldn't work)

However, when changing the constants back to normal strings, the flow check works as expected.
export type Button =
  | 'primary'
  | 'primary-special';

Any idea why this is the case? Is this a known bug?

You can't do this
export type Button =
  | ButtonTypes.PRIMARY
  | ButtonTypes.PRIMARY_SPECIAL;

Flow raises
src/index.js:11
 11:   | ButtonTypes.PRIMARY
         ^^^^^^^^^^^^^^^^^^^ string. Ineligible value used in/as type annotation (did you forget 'typeof'?)
 11:   | ButtonTypes.PRIMARY
         ^^^^^^^^^^^^^^^^^^^ PRIMARY

src/index.js:12
 12:   | ButtonTypes.PRIMARY_SPECIAL;
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ string. Ineligible value used in/as type annotation (did you forget 'typeof'?)
 12:   | ButtonTypes.PRIMARY_SPECIAL;
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ PRIMARY_SPECIAL

Even adding typeof
export type Button =
  | typeof ButtonTypes.PRIMARY
  | typeof ButtonTypes.PRIMARY_SPECIAL;

is not what you want, since typeof ButtonTypes.PRIMARY is string, thus <MyCustomButton type="test" /> still type checks

I have the same question. Is this by design and I shouldn't have Enums anymore as long as my magic strings are type checked? Or there's a special way to type check enum values w/ flow?

I guess it supposed to work like this: in the type definitions only actual strings must be used and in the checked code we can use variables / Enums.

Would be very interesting to be able to do this!

The same problem with
const KIND_OBJECT = 1;
const KIND_FIELD = 2;

type FieldKindsT = KIND_OBJECT | KIND_FIELD;

returns error
number
Ineligible value used in/as type annotation (did you forget 'typeof'?)
KIND_OBJECT: app/_components/Form/schema/formSchema.js:8

But such record works perfectly
type FormSchemaFieldTypesT = 'String' | 'Float' | 'Int' | 'Boolean' | 'Date';
const a: FormSchemaFieldTypesT = 'String'; // no error
const b: FormSchemaFieldTypesT = 'String123'; // expected error "This type is incompatible with string enum"

Also converting kinds to string does not work:
const KIND_OBJECT = '1';
const KIND_FIELD = '2';

type FieldKindsT = KIND_OBJECT | KIND_FIELD;

Finally using now such not perfect, but working solution:
const KIND_OBJECT = 1;
const KIND_FIELD = 2;

type FieldKindsT = 1 | 2;

const a: FieldKindsT = 1; // no error
const b: FieldKindsT = 15; // expected error "This type is incompatible with number enum"

Slightly better:
const KIND_OBJECT: 1 = 1;
const KIND_FIELD: 2 = 2;

type FieldKindsT = typeof KIND_OBJECT | typeof KIND_FIELD;

@vkurchatkin thanks!

I ran into this same issue trying to use imported constants to compute object/type property names.
const Constants = {
	A: "asdf",
	B: "other"
}

type TwoLiteral = {
  asdf: Array<string>,
  other: string
}

type TwoCompLiteral = {
  [Constants.A]: Array<string>,
  [Constants.B]: string
}

const testLiteral: TwoLiteral = {
  [Constants.A]: ["hello", "world"],
  other: "hello"
};

const testComputed: TwoCompLiteral = {
  asdf: ["hello", "world"],
  [Constants.B]: "hello"
};

12:   [Constants.A]: Array<string>,
       ^ string. Ineligible value used in/as type annotation (did you forget 'typeof'?)
12:   [Constants.A]: Array<string>,
       ^ A
13:   [Constants.B]: string      ^ multiple indexers are not supported
23:   [Constants.B]: "hello"                     ^ string. This type is incompatible with
12:   [Constants.A]: Array<string>,
                     ^ array type

Try Flow

any update on the fix?

There is no real bug here. Look at @vkurchatkin's comment for the current best way to do this.
You can also use $Keys to make this easier when you always have the same values for the keys and values in your object.
export const ButtonTypes = {
  PRIMARY: 'PRIMARY',
  PRIMARY_SPECIAL: 'PRIMARY_SPECIAL',
}

export type Button = $Keys<typeof ButtonTypes>

I'm trying out Flow and am trying to use it with Redux.  I'd like to setup my action creators in a way that flow can verify I've supplied the right type attribute?  For example, if I've setup my flow type as export type SetNotificationAction = TypedAction<'notification:setNotification', string> I want to only be allowed to return {type: 'notification:setNotification', ...}
export function setNotification(message: string): SetNotificationAction {
  return {
    type: 'would be nice if any string didn't pass here',
    payload: message
  };
}

I obviously can't do const SET_NOTIFICATION = 'notification:setNotification' and export type SetNotificationAction = TypedAction<SET_NOTIFICATION, string>, but it would be nice if there was a $String<>.

For example, it'd be great if Flow could catch this bug (in the reducer CLEAR_NOTIFICATION returns a payload that's undefined and message should always be a string.  CLEAR_NOTIFICATION should be SET_NOTIFICATION HERE) :
/* @flow */
export const actionTypes = {
  SET_NOTIFICATION: 'notification:setNotification',
  CLEAR_NOTIFICATION: 'notification:clearNotification'
};

type TypedAction<T, P> = {
  type: T,
  payload: P
};

export type SetNotificationAction = TypedAction<'notification:setNotification', string>;
export type ClearNotificationAction = TypedAction<'notification:clearNotification', void>;

export type Action =
  | SetNotificationAction
  | ClearNotificationAction;

export function clearNotification(): ClearNotificationAction {
  return {
    type: actionTypes.CLEAR_NOTIFICATION,
    payload: undefined
  };
}

export function setNotification(message: string): SetNotificationAction {
  return {
    type: actionTypes.SET_NOTIFICATION,
    payload: message
  };
}

export type State = { message: string };

const initialState: State = { message: ''};

export default function reducer(state: State = initialState, action: Action): State {
  switch (action.type) {
    case actionTypes.CLEAR_NOTIFICATION:
      return { message: action.payload };

    case actionTypes.CLEAR_NOTIFICATION:
      return initialState;

    default:
      return state;
  }
}

@nmn That's not really helpful, is it?
Quoting the flowtype docs:

Because Flow understands JavaScript so well, it doesn’t need many of these types. You should only ever have to do a minimal amount of work to describe your code to Flow and it will infer the rest. A lot of the time, Flow can understand your code without any types at all.

minimal amount of work.
I use flowtype because it's helping me write readable code.
This:
export const ButtonTypes = {
  PRIMARY: 'PRIMARY',
  PRIMARY_SPECIAL: 'PRIMARY_SPECIAL',
}

export type Button = $Keys<typeof ButtonTypes>

Is inferior in every way to this:
const PRIMARY = 1;
const PRIMARY_SPECIAL = 2;
export type Button = PRIMARY | PRIMARY_SPECIAL

or something like this:
const PRIMARY = 1;
const PRIMARY_SPECIAL = 2;
const TYPES = [PRIMARY, PRIMARY_SPECIAL]
export type Button = <unionof TYPES>;

How are people addressing this issue in their code?

What I am currently using (workaround?) is something like this:
// @flow
export const PRIMARY: string & 'primary' = 'primary';
export const SECONDARY: string & 'secondary' = 'secondary';
export type Button = typeof PRIMARY | typeof SECONDARY;

@geraldyeo Thanks, useful trick! It seems to me it can be simplified further:
// @flow
export const PRIMARY: 'primary' = 'primary';
export const SECONDARY: 'secondary' = 'secondary';
export type Button = typeof PRIMARY | typeof SECONDARY;

If you ask me, the official syntax makes more sense:
export const ButtonTypes = {
  PRIMARY: 'PRIMARY',
  SECONDARY: 'SECONDARY',
  PRIMARY_SPECIAL: 'PRIMARY_SPECIAL',
};

type Props = {
  type?: $Keys<typeof ButtonTypes>,
};

export default ({ type = ButtonTypes.SECONDARY, ...otherProps }: Props) => (
  <button type={type} {...otherProps} />
);

This way in an external file you can do the following:
import Button, { ButtonTypes } from 'components/Button';

export default() => (
  <Button type={ButtonTypes.PRIMARY)>
    Button label
  </Button>
);

PS: If you only ever communicate through ButtonTypes.CONST_NAME, the values don't really matter at all.
By using $Values you can create Swift style enums:
export const ButtonTypes = {
  PRIMARY: 0,
  SECONDARY: 1,
  PRIMARY_SPECIAL: 2,
};

type Props = {
  type?: $Values<typeof ButtonTypes>,
};

This prevents someone from accidentally typing type="PRIMARY" as well.

@nmn there are really common use cases that would benefit from allowing this kind of syntax in a compact way. typing actions and reducers inside redux applications would become a lot nicer and safer for instance

Thanks to @fagerbua , I improved the code just like this
// @flow

const ButtonTypes:
{
    PRIMARY: 0,
    SECONDARY: 1,
    PRIMARY_SPECIAL: 2,
} = {
    PRIMARY: 0,
    SECONDARY: 1,
    PRIMARY_SPECIAL: 2,
}

type Props = $Values<typeof ButtonTypes>;

function show(buttonType: Props) {
    console.log(buttonType);
}

show(ButtonTypes.PRIMARY); // No Error
show(3); // This type is incompatible with the expected param type of number enum

@Naoto-Ida, @ckitterl: Using $Keys gives much simpler error messages, see https://flow.org/try/#0MYewdgzgLgBAQgVylcAVAngBwKYRgXhgG8AoGGABQCUBJAWQEEqBNALhgHJr6nmOAaMjADKAUQDCAeQByAEV7sOYqXN4Ch3RiwD6wihJoMAMos29d+8YaPqAvgG4SJKFmyUATiEx5CAEgDS2OgQADwuOCAAZvBIKGAYOBAAfI4koJCwULhQAIzaOewUnt4EMchorhAAdGYsjunQMFnQeQBMhcU+nLV89jAA9P0wEAAWIAgANgAmMJEAhgCWE1UraeCNzbnaAMwdXl0cqKLCqBx9g7OLExD8MOhz6E4NsIjl8ZWtpaTkPewADIJyMoZPIWOwcoDKLQtMwLAZjOxWoIHE5wm4ivtPn4AGpzCYIXBhVxRMpxBK4VopJ7rTLZVr5PbeLGkiqJVo1aG8eo0pp07TtDyY0p-c5DUbjaaXJYrKprDK86D03aCpmlAAsopgUxAuDAHFg8yWtyYAHEABIWs3U+WvMmVbZfDScsEwAAUXGdfFMno4AEpIcDVC73YHQV7OKG1P6nTwdHp4SY3R7Y7D41ZjBxvSm4embNGUc5XCqIA6cXiCaE0STbazcNsqXKNtltgzi6WWe9EtsOSnufLNi2BRjvO3kzCzgMxWNJjNDctVs8FVAW8rhyXSodjqdNXObncHkA

@guidobouman You may misunderstand the $keys usage。 The $Keys just retrun T type's key set. See the example below
// @flow
const countries = {
  US: "United States",
  IT: "Italy",
  FR: "France"
};

type Country = $Keys<typeof countries>;

const italy: Country = 'IT';
const nope: Country = 'nope'; // 'nope' is not a Country

Country type is the union of US,ITANDFR 。My last example  show how to get a Country type that combine United States， Italy AND France
The ButtonTypes of Your example by coincidence have same key and value。 see https://flow.org/try/#0MYewdgzgLgBAQgVylcAVAngBwKYRgXhgG8AoGGABQCUBJAWQEEqBNALhgHJr6nmBGDgBoyMAMoBRAMIB5AHIARXuw4SZC3kJHdGLAPqiKUmgwAyy7b32HJxk5oC+AbhIkoWbJQBOITHkIASAGlsdAgAHjccEAAzeCQUMAwcCAA+ZxJQSFgoXCg+XT52Cm9fAjjkNHcIADoLFmdM6Bgc6HyAJiKSv0465g5HGAB6QZgIAAsQBAAbABMYaIBDAEsp6rWM8CaWvN0AZk6fbo5UcVFUfqGRxZWIQRh0BfQXIA

@ckitterl I'm well aware of that fact. To me duplication of the whole list of types really feels like a no go. I'd much rather use keys with the same values. But this is just personal preference.
What would actually improve this situation would be an $ExactValues helper. This would allow using the exact values instead of value types.
// @flow
const countries = {
  US: "United States",
  IT: "Italy",
  FR: "France"
};

type Country = $ExactValues<typeof countries>;

const italy: Country = countries.IT; // This would work
const italy: Country = 'Italy'; // Ideally this would fail, but that's out of scope I guess.
const nope: Country = 'nope'; // 'nope' is not a Country

@guidobouman It works actually. You just need to freeze the object (or pretend you freeze it)
https://flow.org/try/#0PTAEAEDMBsHsHcBQiDGsB2BnALqNBXdbAJwEsBTTUAXlGACoAuRgeQCMArclbAOkmLlyAL3IAKesADeiUKACqAZUagARPPSls5ACahF2AIbbMqgDSzQASQAqK1VaPQAnucsAxAEr33xQ+hRyVUQAXwZmAEpJAG5kbGcAB3JQAGFYQhJnGlAAEgA1Q2h8SgAeeKTYSDx0ojJKAD5Y1AwcUC1C5wBGFTSM4izaAlqKTF5baLowGwALUip4dOg9BeIAa2asXHaXACYemszsgHJHDqOJkGsdckKXUGxZ+cW9SENSaDNQNnxcB+MjqjpXCVUCYNBJDatdCwJL7PoDUBHaFJc6TRHI8hHNpUaG4QypA79IA

@TrySound It's work under version of 0.6x.y but not 0.5x.y. I run my script by 0.59.0, but, thank you all the samle ,I will td my flow


Separate settings for Test and Compile?

I'd like to start dynamodb not only for tests but for "sbt run" as well, so that I don't need to start it separately every time.
I was able to setup the starting of dynamodb with no problems, but I'd like to use in-memory mode only for tests.
I tried several ways of overriding the settings, but with no luck. For example:
dynamoDBLocalInMemory in Compile := false
dynamoDBLocalDBPath in Test := None
dynamoDBLocalPort in Test := 8001
This will still use the default settings.
I will deeply appreciate any guidance on that. Thanks!

Hi @bleshik, I believe you are correct that the plugin does not respect configuration scopes for the settings. I think I understand how to correct this based on http://www.scala-sbt.org/0.13/docs/Plugins-Best-Practices.html#Provide+raw+settings+and+configured+settings. Let me see if I can get to this over the next few days.

@bleshik should be good to go, let me know if you run into any issues.


Added Fn call when month change

When I was implementing this component, I missed this function to reflect month transitions in others parts of my state.

Coverage decreased (-0.06%) to 86.296% when pulling 6ace1ac836424496a31090704181f65bb1d26618 on phsantiago:patch-1 into 0f6ccccc4e1da55f766a09c48147eb6adcc1b45c on airbnb:master.

Coverage decreased (-0.06%) to 86.296% when pulling f769ef08d95afb38a7790fdf86579ed78ced3e28 on phsantiago:patch-1 into 0f6ccccc4e1da55f766a09c48147eb6adcc1b45c on airbnb:master.

Coverage decreased (-0.06%) to 86.296% when pulling 91b7daea9476e8bad268a7886e73b74d879ed33c on phsantiago:patch-1 into 0f6ccccc4e1da55f766a09c48147eb6adcc1b45c on airbnb:master.

I'm confused on why we would need the onMonthChange callback when we already have the onPrevMonthClick and onNextMonthClick methods?

@majapw with onPrevMonthClick and onNextMonthClick we need to calculate outside the Calendar component how many months has passed, with sums and subtractions. It's easier has this props telling us in what month we are.

Coverage decreased (-0.06%) to 86.296% when pulling 171e7f673b106307a5ae9f92dc3b6198a4096371 on phsantiago:patch-1 into 0f6ccccc4e1da55f766a09c48147eb6adcc1b45c on airbnb:master.

Coverage decreased (-0.06%) to 86.296% when pulling 171e7f673b106307a5ae9f92dc3b6198a4096371 on phsantiago:patch-1 into 0f6ccccc4e1da55f766a09c48147eb6adcc1b45c on airbnb:master.

@ljharb Thank you for the feedback. I've made some tweaks, can you review please?

@phsantiago If you look at https://github.com/airbnb/react-dates/blob/master/src/components/DayPickerRangeController.jsx#L521 and https://github.com/airbnb/react-dates/blob/master/src/components/DayPickerRangeController.jsx#L545, we actually do pass the current month back to the props pass through the DateRangePicker. Something similar happens for the SingleDatePicker.
Are you using the DayPicker component directly?

@majapw Wow sorry, you are sure! I'm using DayPicker directly, didn't knew about those lines.

@phsantiago unless you are doing something dramatically different from picking a range or picking a single date, I would recommend using one of those directly. :) In any case, I don't think that this is necessarily the right strategy to add this prop.


nanopb error at Xcode 11.4 beta

Step 1: Describe your environment

Xcode version: 11.4 beta
Firebase SDK version: 6.16.0
Firebase Component: nanopb
Component version: 0.3.9011
Installation method: CocoaPods

Step 2: Describe the problem
Steps to reproduce:
It throws an error at Xcode 11.4 beta, here's the error:
ld: -sectalign and -bitcode_bundle (Xcode setting ENABLE_BITCODE=YES) cannot be used together

@nebiros Thanks for the report.
I'm not able to reproduce in a sample app with Version 11.4 beta (11N111s)
Where does the -sectalign option get set?

This isn't specific to nanopb: https://twitter.com/search?q=sectalign. It seems like a bug in the Xcode release that sectalign is now on by default.
That discussion seems to indicate that the best workaround right now is to disable bitcode.

FYI, I'm encountering the same problem.

Encountering the same issue as well.

Going to close since it seems to be an Xcode beta issue


IOT

I would like to contribute by putting out drawbacks of IOT.
We can add applications of IOT in everyday life with examples in the form of photos , videos ,gif or illustrations.

Sure.


typoadd udf doc and optimize udf regression test

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.91 seconds
load time: 457 seconds
storage size:<PHONE_NUMBER>4 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221107035451_clickbench_pr_40759.html


The sliding panel opens till the height of keyboard when the keyboard is not closed.

It happened to me too.. From what I saw it happens on Samsung devices.
If you use android:windowSoftInputMode="adjustPan" in your activity in the manifest it should solve the problem.


add new collaborator

add new collaborator

Codecov Report

Merging #204 into 2.0 will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            2.0   #204   +/-   ##
===================================
  Coverage   100%   100%
===================================
  Files        16     16
  Lines       359    359
===================================
  Hits        359    359

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f18925f...210e9c7. Read the comment docs.


Test icon on first line is unexpected

Testing #119545
I'm guessing this runs the whole file, but it looks weird and probably isn't worth having imo:

Also it shows up on non-test files 😕

This is one of the known issues I mentioned, but I don't have an issue for this so I'll keep it open

Oh yeah, I have a habit of starting to test before I read the whole thing so I'm going in more blind 🙂

Moving into this iteration after feedback from Joh


Use TLS for communication with Eirini endpoint

This PR adds the ability to talk to Eirini via TLS after removal of HTTP support on the Eirini side. Additional certs are mounted in the staging containers, similar to the CC certificates.
Thanks,
@gdankov @schaefm-ibm

looks good.
can you rebase on master please and fix the linter issues. you can run the linter by doing ./scripts/lint.sh.

@nimakaviani We've fixed all the linter issues and rebased the commits on master.


x509Name not converting embedded commas correctly

I am attempting to generate a Certificate Signing Request where one of the Organizational Unit values that must go in the subject contains an embedded comma:
OU=BANCO BILBAO VIZCAYA ARGENTARIA, S.A
If this is written verbatim in the dirName, BouncyCastle will correctly throw a "badly formated directory string" ArgumentException. Following the advice from this link, this OU value must be written delimited by quotes, which I have attempted in two different ways:
string subjectTest1 = "OU=\"BANCO BILBAO VIZCAYA ARGENTARIA, S.A\"";      // OPTION 1 - Using a string escape sequence
string subjectTest2 = @"OU=""BANCO BILBAO VIZCAYA ARGENTARIA, S.A""";     // OPTION 2 - Using a verbatim string literal
However, when checking the resulting subject name, an additional backslash is being added before the comma:

¿Has someone encountered this problem before? If so, ¿how were you able to solve it?

If you try adding other values to the subject, you will see that comma is used as a separator between RDNs in X509Name.ToString(), so we have to include the escape character to avoid confusion.
However you shouldn't be using ToString for anything other than simple presentation scenarios; there is an API for enumerating RDNs. e.g.:
string subjectTest = "OU=\"BANCO BILBAO VIZCAYA ARGENTARIA, S.A\"";
var x509Name = new X509Name(subjectTest);
foreach (var v in x509Name.GetValueList(X509Name.OU))
{
    Console.WriteLine(v);
}

which prints:

BANCO BILBAO VIZCAYA ARGENTARIA, S.A


Building senders-io

Great work! I am trying to experiment with the file_handle API in this library. I added stdexec dependency using CPM but couldn't get the library to compile. What version of the compiler and stdexec do I need to build this library?
Also, what is the use of passing multiple buffers to the read API? From what I can see, the read happens from a single offset, and the buffers are filled one after another. It would be nice to have a batched read that takes a span of buffers and a span of offsets in one-to-one correspondence.

I also want to use stdexec along with the capabilities presented in this library to form a backend for my Graph Neural Network training framework for huge graphs that don't fit into the RAM. What is important to me is to be able to use the full capacity of the SSD while using senders for everything. I am open to collaborating so that the missing pieces I might need in the future are available sooner :).

Great work! I am trying to experiment with the file_handle API in this library. I added stdexec dependency using CPM but couldn't get the library to compile. What version of the compiler and stdexec do I need to build this library?

The best reference is currently the github action. I've build on top of the member cpo branch that ville has originally started.

Also, what is the use of passing multiple buffers to the read API? From what I can see, the read happens from a single offset, and the buffers are filled one after another. It would be nice to have a batched read that takes a span of buffers and a span of offsets in one-to-one correspondence.

If the vectorizes api allows that, then it is an oversight on my sight. There is still some usage with the current api since you each buffer could contain a different header, such as ETH, IP, Tcp etc and you don't need to copy those header structs in a single contiguous buffer

The API could look like read_batched(std::span<buffer_type> buffers, std::span<offset_type> offsets) with buffers.size() == offsets.size() and when awaited upon the sender returned by read_batched, the buffers would have the read items, specifically buffers[i][j] == file_data[offsets[i] + j], forall 0 <= j < buffers[i].size(), 0 <= i < buffers.size(). The buffers could be offsets into a huge buffer, which can be registered into io_uring so that the copy can be performed without any extra buffers.

I also want to use stdexec along with the capabilities presented in this library to form a backend for my Graph Neural Network training framework for huge graphs that don't fit into the RAM. What is important to me is to be able to use the full capacity of the SSD with batched random accesses while using senders for everything. I am open to collaborating so that the missing pieces I might need in the future are available sooner :).

I'm happy to help and being helped. I think I must focus on documentation and tests at this point. I'm still unhappy with some things around sequence senders but those might not be necessary for you

I was able to get it to compile after looking into github actions as you suggested. Thanks! Closing this issue but I would like to keep in touch in the future.

The API could look like read_batched(std::span<buffer_type> buffers, std::span<offset_type> offsets) with buffers.size() == offsets.size() and when awaited upon the sender returned by read_batched, the buffers would have the read items, specifically buffers[i][j] == file_data[offsets[i] + j], forall 0 <= j < buffers[i].size(), 0 <= i < buffers.size(). The buffers could be offsets into a huge buffer, which can be registered into io_uring so that the copies can be performed without any extra buffers.

This doesn't directly map to calls of a single async preadv function. Read batched is a composed algorithm. I think, I can provide you with a simple implementation using sio::iterate and sio::async::read. Would this help?

It certainly would so long as the overhead of the abstractions used to issue the reads into the queue is small and we can get full performance. I am talking about a lot of small reads, on average 400 bytes per buffer and thousands of batched reads.
What is the exact difference between read and read_some? I am not used to the sender abstractions fully yet so it is a bit hard to decode what the code is doing. From what I understand, read_some returns when buffers are full or the file is exhausted. Read seems to always exhaust the file. However, if buffers get full, does read return multiple times and give the control back to the user with full buffers?

It certainly would so long as the overhead of the abstractions used to issue the reads into the queue is small and we can get full performance. I am talking about a lot of small reads, on average 400 bytes per buffer and thousands of batched reads.

There is some freedom in the algorithm. Each offset needs a separate read operation being submitted to io urings queue. Then it's a question how many active operations you allow at once. Each active operation need some storage. I have implemented an async memory pool to naturally limit the number of active ops dynamically at run time.

What is the exact difference between read and read_some? I am not used to the sender abstractions fully yet so it is a bit hard to decode what the code is doing. From what I understand, read_some returns when buffers are full or the file is exhausted. Read seems to always exhaust the file. However, if buffers get full, does read return multiple times and give the control back to the user with full buffers?

One submitted read operation can complete with less than requested bytes. That's how the syscall works. Read some submits exactly one read op an returns the number of bytes that have been read. The read algorithm submits a consecutive read until all bytes have been read

Cool, I am excited to see how much performance we can extract with a simple implementation. I will be benchmarking it as soon as I can get my hands on it. If it is really simple to implement with what already exists in the library, any hint on how to implement it so I can start experimenting?

There is some freedom in the algorithm. Each offset needs a separate read operation being submitted to io urings queue. Then it's a question how many active operations you allow at once. Each active operation need some storage. I have implemented an async memory pool to naturally limit the number of active ops dynamically at run time.

SSDs can be quite fast and they are capable of a lot of random reads at once. From what I know, NVMe queue depth can be as large as 65k. Thus, we might need thousands of read operations in flight to extract full performance especially when each individual read operation in a batch reads a few hundred bytes.

It's really just a combination of iterate, fork, let value each and async read. I will push a test later.


resolve EpicsMotor stalls sometimes at end of move

fixes #782

Much of this logic is already in https://github.com/bluesky/ophyd/blob/3cbf73b8f71b9c2494ffb097ac1a5e9b5c0f1e23/ophyd/epics_motor.py#L224-L271
I suspect that this is going to interact badly with that logic.

It is subscribed a bit differently on the 1.3.x branch
https://github.com/bluesky/ophyd/blob/9f21ca2690a4a8a1db86d2eeb9a5628e9fc03123/ophyd/epics_motor.py#L81 and https://github.com/bluesky/ophyd/blob/9f21ca2690a4a8a1db86d2eeb9a5628e9fc03123/ophyd/epics_motor.py#L222-L267

Haha, I see three of us pounced in parallel.Thanks for the contribution, @prjemian, and good luck sifting through our feedback. :upside_down_face:

Much of this logic is already in
https://github.com/bluesky/ophyd/blob/3cbf73b8f71b9c2494ffb097ac1a5e9b5c0f1e23/ophyd/epics_motor.py#L224-L271
I suspect that this is going to interact badly with that logic.
It is subscribed a bit differently on the 1.3.x branch
https://github.com/bluesky/ophyd/blob/9f21ca2690a4a8a1db86d2eeb9a5628e9fc03123/ophyd/epics_motor.py#L81
and
https://github.com/bluesky/ophyd/blob/9f21ca2690a4a8a1db86d2eeb9a5628e9fc03123/ophyd/epics_motor.py#L222-L267

This might be the better place for the logic in the dmov_callback().  This logic:
        was_moving = self._moving
        self._moving = (value != 1)

should change to:
        was_moving = self._moving
        self._moving = not self.motor_is_done.value

This logic is problematic:
        if was_moving and not self._moving:

since it requires the transition to declare the move complete.  Suggest relocating the done_moving()` call thus:
        if not self._started_moving and not self._moving:
            self._done_moving(success=success, timestamp=timestamp,
                              value=value)

So, removing the dmov_callback() from move() and adding to the _move_changed() method as described results in the motor stall re-appearing.  Where is the status message declared done?  It's not directly in positioner._done_moving().  Very tangly code.  Is it one of the st._finished() lines in signal.py?

In the end, I restored the dmov_callback() to ensure the status message is finished.  There is no problem with calling this more than once, the code has an early bailout for
        if self.done:
            return

Is there a better way to be certain that st._finished() gets called?

since it requires the transition to declare the move complete

My understanding is that the motor record will always flash DMOV low and then high to indicate that it is moving (even if it already at it's target destination).
I am still :-1: on this as-is because it is short-circuiting a whole bunch logic in _move_changed which I assume is there for a reason.  If there are cases where that logic is currently correctly not reporting the motion done, this extra callback will flip the status and erroneously report that motion is done when it is not.
Do we have a clear understanding of the source of the problem?  @prjemian do you have any timing diagrams of what the various PVs are doing when it does and does not work correctly?
My current guess is that we are hitting race-conditions on some of the internal state of EpicsMotor between the code running on the monitor thread and the code running on the main thread that is causing the next m.move() execution to overlap with the previous _move_changed execution.  Thus, we miss the falling edge of DMOV to indicate that we started moving for the move the user requested and then ignore the rising edge because we think that does not belong to us.

In https://github.com/bluesky/ophyd/blob/3cbf73b8f71b9c2494ffb097ac1a5e9b5c0f1e23/ophyd/positioner.py#L195-L198
we subscribe the status object to self._SUB_REQ_DONE on the ophyd object and then in https://github.com/bluesky/ophyd/blob/3cbf73b8f71b9c2494ffb097ac1a5e9b5c0f1e23/ophyd/positioner.py#L200-L208 process those callbacks which is in turn called from https://github.com/bluesky/ophyd/blob/3cbf73b8f71b9c2494ffb097ac1a5e9b5c0f1e23/ophyd/epics_motor.py#L270-L271

@tacaswell : You have described the actions of the .MOVN field of the motor record.  The .DMOV transitions from 1 to 0 at the start of a move and transitions from 0 to 1 at the end, after the completion of the primary move plus any additional move complexities (such as backlash corrections or retries) controlled by the motor record.  See this documentation for the details:  https://epics.anl.gov/bcda/synApps/motor/motorRecord.html#Fields_status
About the .DMOV field, the documentation states:

This field is set to 0 when the motor record begins a motion, and remains 0 through any retries and backlash corrections that may be required until the motor record has completely finished that motion, whereupon the field is set to 1. DMOV is guaranteed to execute and post a 1/0/1 pulse when the motor is commanded to move--even if no motion actually occurs because the motor was commanded to move to its current position.

It is clear from the structure of the plan used to test this problem (when executed with logging level set to DEBUG):
def move(motor, label, dest, delay_s):
    yield from bps.checkpoint()
    yield from bps.mv(m1, dest)
    print(f"{label}:   {dest} {motor.position}")
    yield from bps.sleep(delay_s)

that the next move has not yet begun.  If the next move command had been issued, the RunEngine logging would indicate a checkpoint message had been processed since the most recent move activity.  What makes this obvious is that no checkpoint message is logged at the time the motor stalls.  The logging indicates the motor has finished its most recent move yet the RunEngine is waiting.

Is there a better way to be certain that st._finished() gets called?

I agree that this change has implications of change for additional methods such as _move_changed() and/or _done_moving().  What tools are there to diagnose further the handling of the status objects?

What is the behavior of DMOV is the motor is already moving and then we instruct it to move again?
The monitor subscriptions are run on a background thread (one sourced via libca and then trampolined to python).
The conflict is between the current move and the previous move's clean up code.

If the .VAL field is changed while the motor is moving (.DMOV = 0), the .DMOV field will remain at zero until the new move is finished.

The monitor subscriptions are run on a background thread (one sourced via libca and then trampolined to python).

What is trampolined?

The conflict is between the current move and the previous move's clean up code.

How can I diagnose the code in the current master at this level?

Here's an example of the timing of changes in motor VAL, MOVN, and DMOV fields using this command: camonitor sky:m1.{VAL,MOVN,DMOV}
before the move
sky:m1.VAL                     2019-12-14 06:23:54.200602 -0.1
sky:m1.MOVN                    2019-12-14 06:23:54.200602 0
sky:m1.DMOV                    2019-12-14 06:23:54.200602 1

step by 1.0
sky:m1.DMOV                    2019-12-14 06:23:54.200602 0
sky:m1.VAL                     2019-12-16 17:07:04.776139 0.9
sky:m1.MOVN                    2019-12-16 17:07:04.776439 1
sky:m1.MOVN                    2019-12-16 17:07:06.048334 0
sky:m1.DMOV                    2019-12-16 17:07:06.048334 1

step by 1.0, then step by 1.0 during the first move
sky:m1.DMOV                    2019-12-16 17:07:06.048334 0
sky:m1.VAL                     2019-12-16 17:07:23.618395 1.9
sky:m1.MOVN                    2019-12-16 17:07:23.620621 1
sky:m1.VAL                     2019-12-16 17:07:24.163468 2.9
sky:m1.VAL                     2019-12-16 17:07:24.840445 2.9
sky:m1.MOVN                    2019-12-16 17:07:24.840445 0
sky:m1.MOVN                    2019-12-16 17:07:24.840492 1
sky:m1.MOVN                    2019-12-16 17:07:26.143724 0
sky:m1.DMOV                    2019-12-16 17:07:26.143724 1

step by -1.0 (with backlash correction)
sky:m1.DMOV                    2019-12-16 17:11:47.487712 0
sky:m1.VAL                     2019-12-16 17:12:13.615191 1.9
sky:m1.MOVN                    2019-12-16 17:12:13.615351 1
sky:m1.MOVN                    2019-12-16 17:12:14.883530 0
sky:m1.MOVN                    2019-12-16 17:12:14.883580 1
sky:m1.MOVN                    2019-12-16 17:12:15.184805 0
sky:m1.DMOV                    2019-12-16 17:12:15.184805 1

step by -1.0 (with backlash correction), then step by -1.0 during the first move
sky:m1.DMOV                    2019-12-16 17:12:15.184805 0
sky:m1.VAL                     2019-12-16 17:12:26.397074 0.9
sky:m1.MOVN                    2019-12-16 17:12:26.397250 1
sky:m1.VAL                     2019-12-16 17:12:26.997775 -0.1
sky:m1.VAL                     2019-12-16 17:12:27.622810 -0.1
sky:m1.MOVN                    2019-12-16 17:12:27.622810 0
sky:m1.DMOV                    2019-12-16 17:12:27.622810 0
sky:m1.MOVN                    2019-12-16 17:12:27.622865 1
sky:m1.MOVN                    2019-12-16 17:12:28.925954 0
sky:m1.MOVN                    2019-12-16 17:12:28.926168 1
sky:m1.MOVN                    2019-12-16 17:12:29.226441 0
sky:m1.DMOV                    2019-12-16 17:12:29.226441 1

What is trampolined?

The code for this now lives in https://github.com/bluesky/ophyd/blob/master/ophyd/_dispatch.py .  Due to how contexts work in libca/pyepics (this is the c-level structure that holds the various sockets / threads etc required to handle the asynchronous part of the epics protocol and manages the socket <-> virtual circuit <-> channel mapping) running python code in response to a monitor that does further caput/caget will fail.  I do not remember exactly why this is off the top of my head (maybe @klauer can remind me ;) ).  Instead the function we actually register with pyepics just "bounces" the values to a second queue that we process in a python thread which gets around this problem.

I think we just have to start putting in logging statements and sort out the timing between the things happening on different threads and at the IOC level.  I don't know any shortcut to tracking down race conditions, but at least we have a way to reliably reproduce this one!

Thanks for the explanation, @tacaswell !  The next thing to do is to return to the master branch and begin diagnosis with that code, to determine what  needs to be changed so the motor stall condition does not recur.  I'll pause further work on this branch until that diagnosis is fruitful.

Will make a VM image available to the DAMA team.

Do we have a clear understanding of the source of the problem? @prjemian do you have any timing diagrams of what the various PVs are doing when it does and does not work correctly?

Virtual Circuit Unresponsive from EPICS libca: See the three adjacent comments starting with: https://github.com/bluesky/ophyd/pull/787#issuecomment-568296988

Possibly related to #788?  Will test new ophyd release 1.4.0 to see if this remains a problem.

Need to stress test this with current release to see if still a problem.


feat: change ordinals content url

Try out this version of the Hiro Wallet - download extension builds.

See title

I QA'd this locally and I see my ordinals as expected...


implement email service timeouts. fixes #1051

ugh. not sure what's up with the formatting changes in the Email test. I really just added two tests.

Coverage decreased (-0.01%) to 26.703% when pulling e4d12c73a7b588367a8eedc0c5a16e7f233339ac on justinedelson:bug/email-service-timeout into 76529de1b568a742c3fca0ea23bd483ce4e4cd03 on Adobe-Consulting-Services:master.

Coverage decreased (-0.01%) to 26.703% when pulling e4d12c73a7b588367a8eedc0c5a16e7f233339ac on justinedelson:bug/email-service-timeout into 76529de1b568a742c3fca0ea23bd483ce4e4cd03 on Adobe-Consulting-Services:master.

Coverage decreased (-0.01%) to 26.703% when pulling 426c779889d01f937f419084c076cdaf2e9eeaba on justinedelson:bug/email-service-timeout into 76529de1b568a742c3fca0ea23bd483ce4e4cd03 on Adobe-Consulting-Services:master.

Coverage decreased (-0.01%) to 26.703% when pulling 426c779889d01f937f419084c076cdaf2e9eeaba on justinedelson:bug/email-service-timeout into 76529de1b568a742c3fca0ea23bd483ce4e4cd03 on Adobe-Consulting-Services:master.

Changes Unknown when pulling aab53676cdfa1593e6da5de7b27395b39de24826 on justinedelson:bug/email-service-timeout into ** on Adobe-Consulting-Services:master**.

Changes Unknown when pulling aab53676cdfa1593e6da5de7b27395b39de24826 on justinedelson:bug/email-service-timeout into ** on Adobe-Consulting-Services:master**.

Changes Unknown when pulling aab53676cdfa1593e6da5de7b27395b39de24826 on justinedelson:bug/email-service-timeout into ** on Adobe-Consulting-Services:master**.

Changes Unknown when pulling aab53676cdfa1593e6da5de7b27395b39de24826 on justinedelson:bug/email-service-timeout into ** on Adobe-Consulting-Services:master**.

giving up on getting coveralls to recognize that EmailServiceImpl is tested (at least for now)

Coverage decreased (-0.01%) to 26.703% when pulling aab53676cdfa1593e6da5de7b27395b39de24826 on justinedelson:bug/email-service-timeout into 7ebb64acef749c23a9d369d6a0476ef436a362f9 on Adobe-Consulting-Services:master.

Coverage decreased (-0.01%) to 26.703% when pulling aab53676cdfa1593e6da5de7b27395b39de24826 on justinedelson:bug/email-service-timeout into 7ebb64acef749c23a9d369d6a0476ef436a362f9 on Adobe-Consulting-Services:master.


RegexNotFoundError: Unable to extract Initial JS player signature function name

Error downloading the following URL: https://www.youtube.com/watch?v=3eIXGMRLqXM
WARNING: Warning: Falling back to static signature algorithm
[youtube] encrypted signature length 84 (40.43), itag 135, html5 player new-en_US-vflo_te46/html5player-new
[youtube] 3eIXGMRLqXM: Downloading js player new
WARNING: Automatic signature extraction failed: Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 957, in _decrypt_signature
video_id, player_url, len(s)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 356, in _extract_signature_function
res = self._parse_sig_js(code)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 424, in _parse_sig_js
u'Initial JS player signature function name')
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 356, in _search_regex
raise RegexNotFoundError(u'Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract Initial JS player signature function name; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.

You are using an outdated version of youtube-dl. Read our FAQ if you have troubles updating.


@conda-forge-admin,please add bot automerge

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/createrepo_c-feedstock#4.


Enable caching on azure pipelines

Checklist

[x] User relevant changes are recorded in CHANGES.txt
[x] Touched code is covered by tests
[x] Documentation has been updated if necessary
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

This is still Beta functionality (and compiling is only a small fraction of the overall test duration), so not sure if we should enable it.

Do you have any numbers on how much this will improve the duration?

Do you have any numbers on how much this will improve the duration?

Looks like it is 1min max, if at all. I'll close it for now.


Clarified use of reinforcement learning

Clarified that Personalizer is using Reinforcement Learning instead of machine learning.

@bahree : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Road to mainnet: logging and error handling improvements

While generating stats for mainnet I noticed a few places for improvements.

This has been running for the past two weeks. Looks Ok for now.


Contextual backlinks

Is your feature request related to a problem? Please describe.
A plain list of pages that have backlinks is relatively low utility as compared to contextual backlinks, which show why that page is linking to your present page. It's sort of like reading the list of citations of a paper on its own vs. seeing the list of citations in the context of paragraphs within the intro section.
Describe the solution you'd like

A contextual backlink displays not only a reference from another location, but the specific context around that reference—for instance, the page of a book or the referencing paragraph. See Andy Matuschak's notes on the subject.

Specifically, I would like it to show the paragraph that the link is within.
Describe alternatives you've considered
None, this is a requirement for me. Think about the difference between the way your search works (great) and just displaying a list of pages that satisfy the search.

Concur on this one. Maybe a start could be to have a preview when hovering over the backlink links as well.

@jackyzha0 Any plans to work on this? It would make a big difference for my notebook, I'm excited to publish soon.

@jackyzha0 Any plans to work on this? It would make a big difference for my notebook, I'm excited to publish soon.

Will work on this later today. It will be similar to search in that it will return surrounding context, splitting by paragraph is rather hard :)

Hi! I'm not sure if this is working? It still displays as a list of pages.

Seems to be the case in yours too, despite them being turned on in your config.yaml file.

hey @classicrob, right now the contextual backlinks show up in the popover when you hover over the link just so the backlinks list is shorter when there are a larger number of backlinks. Is this sufficient? You could edit the backlinks partial to include the text itself as well but that is not default behaviour

Yes, my intention was to remove the graph view from my own layout and display the text. I don't really care about whether the list is long or not, my ideal would be that the backlinks are displayed in two columns for information density purposes.
How would I edit the partial to include the text as well?

Maybe I did something wrong? Doesn't seem to be working.
https://github.com/classicrob/quartz/blob/hugo/assets/js/popover.js

ah sorry had a typo in my code snippet!
try
const popoverElement = `<p class="backlink-context">
${highlight(removeMarkdown(linkDest.content), li.dataset.ctx)}
</p>`

you may also need to do some additional styling on this element to make it the right size/padding but it should look like this

Brilliant, that worked. Thank you!

Hi! You might need to remove the extra graph rendering code in head.html https://github.com/classicrob/quartz/blob/hugo/layouts/partials/head.html#L72-L85

this is great!
is there a way we can adjust the amount of content shared within the backlink on our end?

hey @balOS, you can edit it https://github.com/jackyzha0/quartz/blob/ed9a8efd1ff4ee569fa4256e044151670abaea82/assets/js/search.js#L60 (sorry the code for this function is pretty messy right now but that should be the main variable to change if you want to change the number of words of context in the window)

thank you @jackyzha0!
for context, i also adjusted popover.js. that seemed to do it.
https://github.com/classicrob/quartz/blob/c77bd54c5d8f9220ac0879620f5e82139c479fa3/assets/js/popover.js#L27

This is beyond fantastic. Absolutely essential feature. Thanks for doing this so swiftly!


fixed dates/calendar data [from 1975 to 2100]

Hello,
I've updated dates in calendar.csv, as i found they're important in date validation.
Dates are scraped from nepalipatro.
The javascript file to scrape data is also uploaded there for further use.

@manish404 I am following nepcal, I did check nepalpatro and seems like there is contradiction in number of days in months for different years as you have pointed. Can you please check other sources as well to validate which one is actually correct? Let me know the links you checked other than nepalpatro, I will verify and move forward with the correct one.

calendar-nepcal.txt
I found differences in every year from 2082 to 2100 in both nepali patro and nepcal, and some differences in hamropatro too.
Do they pick randomly?

@manish404 can you be more specific on the differences you spotted on the sites other than nepcal and nepalipatro?

Sorry to jump-in , but my issue is related to this too .

here you can see the calendar of jestha where 32 date is not present . which is creating an issue in my project .
if you want to test i will include my test code too .. please find it and test it yourself too.

import nepali_datetime

def test_date(bill_date_bs):
    if bill_date_bs is not None and bill_date_bs != "":
        try:
            bill_date_bs = nepali_datetime.datetime.strptime(bill_date_bs, '%Y-%m-%d')
            if bill_date_bs > nepali_datetime.datetime.now():
                print("1. Bill date in B.S should be a valid date")
            bill_date_bs = bill_date_bs.strftime('%Y-%m-%d')
        except ValueError as e:
            print(f"2. Bill date in B.S should be a valid date: {e}")
    else:
        bill_date_bs = nepali_datetime.datetime.now().strftime('%Y-%m-%d')

test_date("2081-02-32")
nepali_datetime.date(2081, 2, 1).calendar()

I think people mostly use hamropatro or nepalipatro, so in my project i used nepali-patro's data, i can't say mine is correct as i found different sites have different future data. I needed future dates verification too, so i have to go with nepali patro's data.
Your approach is good cause there're no issues till now. Nice package, nice work, Thank you.

Hello @amitgaru2 , I also found difference in year 2082 and forked to resolve, And i think this PR should be merged as we also use HamroPatro for reference.

@manish404 @dibashbitskraft ok I think we should follow hamropatro for reference as it is the most popular one. @manish404 can you check your PR again and align the dates with hamropatro only?

@manish404 please remove scraper.js from your PR as it is not needed in the source code.

@manish404 then seems like there is no trustable source for future dates.

2062 - baisakh is wrong, why?

we can merge now!

@manish404 I meant create a new PR not update this one. I have just found discrepancy for 2062 B.S. not others. We are still using nepcal.com as our source of date.

ohh, update in nepcal and package too.
2062,31,31,31,32,31,31,29,30,29,30,29,31

@manish404 I am telling you to do that so that your name gets listed in contributors list as you found it.

Fixed 2062 B.S year calendar with the release <IP_ADDRESS>.
Other concerns with future years will be handled when we have concrete source for the dates.

Hello @manish404 @amitgaru2 ,
It's great work from your side on digitizing Nepali calendar !
I'm trying to source the origin of number of days in each month and wondering what is the source of truth from the number of days in a month !
Basically starting from spring equinox every 30 degrees the sun moves marks the start of the new month, and hence this logic can be used to scientifically calculate the number of days in each month.
I did this but my calculation isn't aligning with existing data !
Basically almost all calendar apps in Nepal seem to be using this limited range hard coded table !
Is it possible to find the source where this data originated ?!

@deepyes02 I don't have any idea on this. But it seems like a good start. You can reach out other people from different community to get the help from. If you don't mind, can you share your calculation in details, so that others including me can also have a look.

@deepyes02  what a noble reason , it will be really great contribution to the Nepali Calendar . You have hinted me a great field of research , i will also give a look at it in my free time , if i find something interesting i will share with you . If possible please drop your email or any contact links. Thanks a lot for bringing this up.

@amitgaru2
I'm still in research mode so I can share my work once it is ready.
The Nepal Panchang Samiti seems to be the authoritative department in defining these numbers but I couldn't get much info on their website.
@manish404 you are welcome to add me on linkedin: https://www.linkedin.com/in/deepyes02/


No video and audio: Ignoring empty DtlsFingerprint extension

jvb log:
Ignoring empty DtlsFingerprint extension:
Same error when using Docker gst-meet.
Probably not WSS or WS. Looks like stun or turn didn't work;
My Jitsi is not a Docker version, it is a properly installed version and it works fine.

Ignoring empty DtlsFingerprint extension is not related to the lack of audio/video.
The error in your image was already reported by you in a separate issue, and is a duplicate of #2.
Please stop opening frivolous issues, we do not have time to triage vague and badly-reported issues.


Feature Request: Highlight all found search terms and selected occurrences

Hi! Love the plugin! Thanks!
When I search my code for 'foo' and find 8 instances, it would be awesome to see those 8 instances highlighted in the codeglance.
Similar, but separate; also when I select multiple occurrences of 'bar' throughout my code it would be awesome to see all those occurrences highlighted as well (the way it works in Sublime's minimap).
Thanks!

+1

+1

Added in 1.5.0

@Vektah I was looking for a feature of CodeGlance that highlights all occurrences of the selected code, something like Atom's (minimap-hightlight-selected)[https://atom.io/packages/minimap-highlight-selected]. Is this the same as this feature request? I have CodeGlance 1.5.2 (PyCharm 2017.1.1, masOS 10.12.14) and it currently doesn't do this, it just highlights the selection, not all occurrences.

Would be very helpful if they can deliver this feature.
I have used Visual Studio with a plugin called "RockMargin"
whenever i clicked on a word, it will highlight all occurrences in the right pane as well. it is so easy to navigate.


Fixup module source info output

@DougGregor @artemcm
Pulled from #144

@swift-ci test

Can someone kick off CI again. Thanks!

@swift-ci test

@cltnschlosser, the CI is currently broken due to a potential bug in SwiftPM exposed by the newest available toolchain snapshot, we're investigating the break. Will ping once it is cleared.

@swift-ci please test

@swift-ci please test


rspec Sha1 issue

Error with ruby v3 upgrade. Currently this is set to ruby v2.
Running will pass the test
make run-image-tests FILE=./spec/metadata/saml_spec.rb:486

However when the ruby version is switched to version 3
rbenv local 3.2.2
make build-image
make run-image-tests FILE=./spec/metadata/saml_spec.rb:486

This fails the test
Metadata::Saml
  ds:Signature Root EntityDescriptor
    has a <Signature> element, c14n method, reference element, signed, and transforms
    with a signed document
      using sha256
        uses the correct signature method
        includes the digest value
        includes the signature value
        specifies the digest algorithm
        is schema-valid
      using sha1
        is schema-valid (FAILED - 1)
        includes the digest value (FAILED - 2)
        uses the correct signature method (FAILED - 3)
        specifies the digest algorithm (FAILED - 4)
        includes the signature value (FAILED - 5)

Failures:

  1) Metadata::Saml ds:Signature Root EntityDescriptor with a signed document using sha1 is schema-valid
     Failure/Error: Xmldsig::SignedDocument.new(builder.doc.to_xml(indent: 2)).sign(key)

     OpenSSL::PKey::PKeyError:
       EVP_DigestSignInit: invalid digest
     Shared Example Group: "ds:Signature xml" called from ./spec/metadata/saml_spec.rb:486
     # ./lib/metadata/saml.rb:49:in `sign'
     # ./spec/support/metadata/signature.rb:77:in `block (3 levels) in <top (required)>'
     # ./spec/rails_helper.rb:27:in `block (3 levels) in <top (required)>'
     # ./spec/rails_helper.rb:26:in `block (2 levels) in <top (required)>'

The error seems to be caused by  Xmldsig::SignedDocument tried upgrading that gem didn't work.
Might have something to do with changes in ruby v3 SSL library can't be sure for now. Having said that this works in my local M1 machine with no issues. There is some incompatibitilty issue with centOS in docker...

@bo-aaf this current pr is still running ruby 2.X and fails though ?

passed for me on 3.0.5

trying 3.2.2 now

this is the only difference intems of the base image besides whatever is installed during ruby-build

@phyzical Did have a conversation with Waldo on this. Apparantly we are still using sha1 in production. adding this variable here https://github.com/ausaccessfed/saml-service/pull/369/commits/0214cb108386a53d071ce1d491376cdf2341487e
fix the issue.

refer to https://github.com/ausaccessfed/saml-service/pull/369


Fixed #32273 -- Doc'd AdminSite.unregister().

https://code.djangoproject.com/ticket/32273

@hramezani Thanks :+1:


body parameter ignored with GitLab merge requests

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
body parameter is ignored in the created merge request
Expected Behavior
body parameter should override default body of merge request
Steps To Reproduce
No response
Environment
- updatecli: 0.57.0

Anything else?
No response

🤔  It should be working https://github.com/updatecli/updatecli/blob/6293758fb602fc06dcfa665017267bb4c87eeff8/pkg/plugins/resources/gitlab/mergerequest/create.go#L30

Yeah, I also checked the code and saw that snippet. But I had no luck setting it to my custom body. It always put the default body in the MR

It seems like all spec definitions of the gitlab merge request are ignored

I had a look at the code, and I spot an few things.
This line is wrong https://github.com/updatecli/updatecli/blob/6293758fb602fc06dcfa665017267bb4c87eeff8/pkg/plugins/resources/gitlab/mergerequest/create.go#L24
And it should be utils.GeneratePullRequestBody(g.spec.Body, report.ToActionsString())
I need to setup my gitlab environment to reproduce the issue, because running go build -o bin/updatecli . &&  ./bin/updatecli apply --config e2e/updatecli.d/success.d/gitlab/scm.yaml --push=false --clean=true  won't execute the part of the code that interest us

I think found the root cause of the problem.
I am using the library drone/go-scm to handle the GitLab interaction and it appears that the mergequest uses URL value https://github.com/drone/go-scm/blob/1579795501b0ae415d6f75594751ffe3ddcaeb76/scm/driver/gitlab/pr.go#L63 to configure the pullrequest which has a limit on the number of character  as explained on https://docs.gitlab.com/ee/api/rest/#request-payload
That library was great to bootstrap the GitLab plugin but I think, I'll need to refactor the plugin.

For info to validate that the body is working for me, I used
manifest.yaml
name: Test GitLab scm

scms:
  gitlab:
    kind: gitlab
    spec:
      owner: "olblak"
      repository: "updatecli"
      branch: main
      username: '{{ requiredEnv "UPDATECLI_GITLAB_ACTOR" }}'
      token: '{{ requiredEnv "UPDATECLI_GITLAB_TOKEN" }}'

sources:
  license:
    name: Retrieve license file content
    kind: file
    scmid: gitlab
    spec:
      file: LICENSE
  readme:
    name: Retrieve readme file content
    kind: file
    scmid: gitlab
    spec:
      file: README.adoc

targets:
  readme:
    name: Update README license file content
    kind: file
    sourceid: readme
    transformers:
      - addprefix: "xx"
    scmid: gitlab
    spec:
      file: README.adoc

actions:
  default:
    title: Bump xxx
    kind: gitlab/mergerequest
    scmid: gitlab
    spec:
      body: My awesome custom body

which created this mergerequest with the correct description https://gitlab.com/olblak/updatecli/-/merge_requests/1224
But if I remove body: My awesome custom body then I face the problem mentioned in my previous comment, the description become too big to be passed by url value

Very strange, it seems to work now, after I recreated my config... Nevertheless, thanks for your support 👍

If you use an IDE that support jsonschema store such as Intellij/NeoVim (with the right plugin), or Vscode then you can leverage schema validation for your manifest(s) if they live under the directory updatecli.d
While debugging this issue, I noticed that the schema mentioned some fields as required even though they were not such as owner/repository, I opened  https://github.com/updatecli/updatecli/pull/1537 to fix that
Once the PR is merge we'll need to wait +-10min for the new schema to be generate and automatically published on https://www.updatecli.io/schema/latest/config.json

This helps to debug typos in params

I am closing this issue as we couldn't reproduce the problem and it seems to be resolved now.
I open https://github.com/updatecli/updatecli/issues/1540 to track the mergrequest too large problem


Why pylance can't resolve my django code.

In my django project, pylance can't resovle th class name after line 157, you can see line 157 and line 159 used the same class, bu line 159 can't be resovled, before version 2020.9.5, all is right, now I update to 2020.10.2, the problem alse exist. my vscode version is 1.50.1

@stolenzc, Thanks for the report. How is AdminTeacherDetailApi defined as opposed to AdminTecherCourseListApi?
Also, when you type teacher., do you see AdminTeacherCourseListApi as a completion?

@stolenzc, Thanks for the report. How is AdminTeacherDetailApi defined as opposed to AdminTecherCourseListApi?
Also, when you type teacher., do you see AdminTeacherCourseListApi as a completion?

@judej Thank you for reply
AdminTeacherDetailApi and AdminTecherCourseListApi used the same way to define.

when I type teacher before AdminTeacherDetailApi, I can see auto prompt for AdminTecherCourseListApi by pylance,

but if that, AdminTeacherDetailApi become can't be resolve.

When I type teacher after AdminTeacherDetailApi, I just can see type remember.


good indea please maintain it :+1:

I honestly think FrankenPHP is not "ready" yet ..


SCL-242 Fix package version

Coverage remained the same at 0.0% when pulling e04a47daf01e315935165a2966b5d2c4f17eb7c3 on SCL-242 into 800c89df71dd25d34f5ea95baa7b1b92636d082e on master.

Coverage remained the same at 0.0% when pulling e04a47daf01e315935165a2966b5d2c4f17eb7c3 on SCL-242 into 800c89df71dd25d34f5ea95baa7b1b92636d082e on master.


[Tensorflow Executor Dialect]

MLIR operation format is :
operation            ::= op-result-list? (generic-operation | custom-operation)
trailing-location?
generic-operation    ::= string-literal ( value-use-list? )  successor-list?
region-list? dictionary-attribute? : function-type
custom-operation     ::= bare-id custom-operation-format
op-result-list       ::= op-result (, op-result)* =
op-result            ::= value-id (: integer-literal)
successor-list       ::= [ successor (, successor)* ]
successor            ::= caret-id (: bb-arg-list)?
region-list          ::= ( region (, region)* )
dictionary-attribute ::= { (attribute-entry (, attribute-entry)*)? }
trailing-location    ::= (loc ( location ))?
here is tf_executor.graph operation :
%fetches = tf_executor.graph : tensor<*xf32> {
// Operations in the current block execute when their inputs are ready,
// possibly concurrently.
// Only operations in the tf_executor dialect are expected here.
// Ops can return multiple outputs and a control token for control
// dependencies.
// We don’t mention the control token in the return type here, it is implicit.
%0, %ctl0 = tf_executor.opA %feed#0, %feed#1 : tensor<*xf32>
%1, %ctl1 = tf_executor.opB : tensor<*xf32>
%2, %ctl2 = tf_executor.opC %1, %ctl0 : tensor<*xf32>
%3, %ctl3 = tf_executor.opD %2 : tensor<*xf32>
tf_executor.fetch %3 : tensor<*xf32>
} // end of the “tf_executor.graph" operation/region
According to Operation format,   {} stands for dictionary-attribute
obviously, tf_executor.graph operation looks like abnormal case
the {} of tf_executor consists of several operations
could anyone explain and point out how to understand tf_executor.graph operation
many thanks

@FullZing Could you please have a look at the link1, link2 and let us know if it helps ?

Hi @sushreebarsa
thank you for replying
but my problem still exists

i checked the Region defination in MLIR from
https://mlir.llvm.org/docs/LangRef/#regions
and it shows a sample with region
"any_op"(%a) ({ // if %a is in-scope in the containing region...
// then %a is in-scope here too.
%new_value = "another_op"(%a) : (i64) -> (i64)
}) : (i64) -> (i64)

check tf_executor.graph Operation description from https://github.com/tensorflow/community/blob/master/rfcs/20190612-mlir-dialect.md
and it shows a sample with region
%fetches = tf_executor.graph : tensor<*xf32> {
// Operations in the current block execute when their inputs are ready,
// possibly concurrently.
// Only operations in the tf_executor dialect are expected here.
// Ops can return multiple outputs and a control token for control
// dependencies.
// We don’t mention the control token in the return type here, it is implicit.
%0, %ctl0 = tf_executor.opA %feed#0, %feed#1 : tensor<*xf32>
%1, %ctl1 = tf_executor.opB : tensor<*xf32>
%2, %ctl2 = tf_executor.opC %1, %ctl0 : tensor<*xf32>
%3, %ctl3 = tf_executor.opD %2 : tensor<*xf32>
tf_executor.fetch %3 : tensor<*xf32>
} // end of the “tf_executor.graph" operation/region

compared tf_executor.graph with any_op,   you can find parentheses for region is missing in tf_executor
so i wonder what is his grammar ？

from  https://mlir.llvm.org/docs/LangRef/,   failed to find any same usage

please check again

@FullZing
In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here. Thanks!


nltk.corpus.wordnet.morphy

Good morning,
It seems to me that the method cited is wrong in some cases.
from nltk.corpus import words, wordnet
wordnet.morphy("numbers")
gives: 'numbers'
Thanks very much

Thanks very much


test: invalid cache plan with prepare stmt

[x] Do only one thing
[x] Non breaking API changes
[x] Tested

What did this pull request do?

related to https://github.com/go-gorm/postgres/pull/137
User Case Description

Hello @a631807682
I think we might need to provide a Reset func for *PreparedStmtDB, after migrated columns we need to reset prepared statements.

@jinzhu  Reset is unnecessary, it will create prepared stmt for the same query.
https://github.com/go-gorm/postgres/pull/137/files#diff-a5ca21254ced8196f81a4c4e926af32db03cb0ea78a1f853835300f6dda3f0c6R552
However, we can provide a method in PreparedStmtDB to remove a prepared stmt or support skipping prepare when the current query is executed

@jinzhu Reset is unnecessary, it will create prepared stmt for the same query. https://github.com/go-gorm/postgres/pull/137/files#diff-a5ca21254ced8196f81a4c4e926af32db03cb0ea78a1f853835300f6dda3f0c6R552 However, we can provide a method in PreparedStmtDB to remove a prepared stmt or support skipping prepare when the current query is executed

The Reset func from my opinion can just remove all cached statements, replace .Stmts with a empty map.
Only remove the select limit 1 SQL seems can't completely avoid the issue.

@jinzhu  I created a pr for it https://github.com/go-gorm/gorm/pull/5782
The current failure is because there is only one place in postgres driver that queries the actual table data, to completely avoid the issue, we need to perform Reset after the table changed.


Calculations return 'None' value

Hey!
During certain calculations, the results are showing 'None' return.
xf.find_coefficients(airfoil = 'naca0012', alpha = 25, Reynolds = 1e6, iteration = 100)
{'alpha': None, 'CL': None, 'CD': None, 'CDp': None, 'CM': None, 'Top_Xtr': None, 'Bot_Xtr': None}
Is this because of solving issues or seperation domain?
Thanks!

Did the issue get resolved? I am having the same issue.
The package installed correctly, however using the test case from the documentation I get "None"!
from aeropy.xfoil_module import find_coefficients
x = find_coefficients(airfoil='naca0012', alpha=12)
print(x)

Same problem here. Any updates on this one?


Modify Update episode API - validate service request

Modify Update episode according to spec

[x] add referral requests attribute
[x] add validation (Validate referral requests))

https://github.com/edenlabllc/medical_events/pull/311


inherent mutability -> interior mutability

It's called "interior" mutability not "inherent" mutability.
Old PR of mine that already fixed this once 😄 https://github.com/rayon-rs/rayon/pull/458
Section in the book https://doc.rust-lang.org/book/second-edition/ch15-05-interior-mutability.html

Doh. Thanks again! 😅
bors r+


[BEAM-3695] Fix failing validates container test

Fix failing validates container test. The failure is during cleanup of the images, and not critical to the test.The gcloud version appears old, failing with:
gcloud container images delete $CONTAINER:$TAG --quiet
Usage: gcloud container [optional flags] <group | command>
group may be           clusters | node-pools | operations
command may be         get-server-config
This fix ignores the failure. Updating gcloud versions is ideal and will be investigated.
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand:

[ ] What the pull request does
[ ] Why it does it
[ ] How it does it
[ ] Why this approach

[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run Python Dataflow ValidatesContainer

@kennknowles PTAL

What is the plan to synchronous gcloud version with the version of the script?

Run Python Dataflow ValidatesContainer

Run Python Dataflow ValidatesContainer

The script now only installs gcloud if it is older than 186. I will look into getting the puppet infrastructure scripts to update gcloud to the latest version.

Run Python Dataflow ValidatesContainer


support ruby 3.x syntax by using ** descoping in new with hash inputs

Description
I was trying to run ruby 3 in a project, which uses minipack.
unfortunately it seems that current way as the Commands::Base call the initialize method does not respect the new syntax.
This PR should fix it and still be compliant with recent versions of ruby.

@five510 i think we should fork this, the repo has gone without update for a while


--no-stdout-logs is not working, but -n is

This seems to be a quirk of how yargs deals with the --no prefix.

https://www.npmjs.com/package/yargs#negate-fields; probably easiest to just rename the option since I don't see some option to turn it off mentioned.

I'm fine with that. Since it's pre-1.0, we can do whatever we want.
How about --silent and -s?

Sounds good.

Well, since we released 1.0.0 and forgot to fix this, I guess we should try to fix it so it actually works?

Absolutely. Fixing issues is more important than keeping semver versions low. PR: #126.

This is still broken (-n silences successfully, but --no-stdout-logs does not), looks like we didn't fix it for some reason. I believe it was discussed but can't recall the resolution.


[Popper, Submenus]feat: add safe polygon feature

enhancement: add safe polygon feature for better UX and accessibility:
Reference
https://github.com/floating-ui/floating-ui/blob/073da89da80577565a69cebd786430e11ea9e3bc/packages/react/src/safePolygon.ts
https://floating-ui.com/docs/useHover#safepolygon
https://height.app/blog/guide-to-build-context-menus
https://github.com/radix-ui/primitives/pull/688 #214

@zernonia do you think this can be done with floating ui? they have that feature supported in react.
ref:
https://github.com/radix-ui/primitives/pull/688
https://floating-ui.com/docs/useHover#safepolygon

I think that's possible. I'm thinking to create a package floating-ui/vue-composable to have all the build in feature similar to React. That way we could benefit Vue community with that feature, and not limited to Radix-Vue.
But yeah I can implement this 😁

I think that's possible. I'm thinking to create a package floating-ui/vue-composable to have all the build in feature similar to React. That way we could benefit Vue community with that feature, and not limited to Radix-Vue.
But yeah I can implement this here to test it out 😁

yeah thats a huge task, I think floating-ui team wouldnt mind if you lead the official floating-ui/vue package. but yeah, huge task 😂


Update website name instructions

Oooh, good spot! I think these instructions need to be updated a bit more than suggested here, and mention the other options that can be changed within the Eleventy Plugin options (within the .eleventy.js file. I also notice that the instructions on this page about the footer are now incorrect also.

See #4. Hopefully that covers this and fixes the related instructions around updating the footer, too.


fix: register regions during procedure recovery

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Ensures all operating regions are registered during procedure recovery.
Checklist

[x]  I have written the necessary rustdoc comments.
[x]  I have added the necessary unit tests and integration tests.
[x]  This PR does not require documentation updates.

@fengjiachun @MichaelScofield PTAL


Create Installer Form

Create an installer form to collect information on settings that writes the config file and tests the database, creates objects, and initializes the admin. It should also test whether or not it can send mail, and write to the disk for file uploads.

this is not going to happen by me


Release 0.1.0

Add changes from release branch 0.1.0 back to dev.
don't forget: no squishing

I can't merge this because my approval doesn't count since I'm the last pusher...

Me neither, because I am the creator of this 🤷♂
@SimeonEhrig @steindev would some of you be so kind and hit the approve button.
IMPORTANT: in the case of merging, please do not squash the commits. This would destroy the sync of main and dev, which causes some trouble for the next release.

@szabo137 Which merge should I do? Create a merge commit or rebase and merge?

@szabo137 Which merge should I do? Create a merge commit or rebase and merge?

@SimeonEhrig best is create a merge commit, thanks 🙏


Another attempt to fix the windows path formatting in a string

@ppannuto added two bug fixes and a little refactoring to the pull request

Whoa, looks like nearly every line changed, could you split the code/logic changes and the formatting changes into separate PRs - it's pretty hard to review in its current form.
(Also, what's the motivation for the whitespace change? I thought everything was internally consistent before?)

I think this has been abandoned. Feel free to re-open if I am wrong.


Add new operations to create a subset of DataFrame

Introducing new methods to create a subset of DataFrame.

pick : pick up some variables and create a subset of self

select by keys
by arguments or block

drop : drop some variables and create a subset of self

select by keys
by arguments or block

Introduce to select observation (row) subset.

slice : select some observations and create a subset of self

select by Array[Integer], Array[booleans], Vector, Arrow::BooleanArray
by arguments or block


AZ blob 0.5.1

Changing the azblob SDK for version 0.5.1

when will this PR got merged? thanks!

We will merge this PR very soon, but we will wait until everything here is close until we release a new version.
Meanwhile - you can refer to this in your project.

This PR is closed now, since the main branch has breaking changes, but this branch will remain.


Porting portalocker to use msvcrt instead of win32con

If you compare http://code.activestate.com/recipes/65203-portalocker-cross-platform-posixnt-api-for-flock-s/ with file in this repo, you will notice a lot of meaningless changes. I'd revert the quotes back to original, because there are a lot of portalocker copies out there that needs to be synced.

@techtonik just letting you know, I haven't forgotten about this issue, I guess you're right that merging to a single file can be convenient for people to integrate into their own projects, for maintenance however I prefer to keep the files separate as it improves readability. So I'll see if I can make Travis automatically merge the separate modules to a single module.
I'll also merge the msvcrt code (assuming I can still find it since Google code is down now), since apparently the code is currently already broken on windows :(


font updates

What kind of PR is this?:

/kind chore
What this PR does / why we need it:

Use IBMPlexSans as global font
Created Text component to be used with new font

Tested them on Android and iOS
Which issue(s) does this PR fixes?:

Fixes #296
Additional comments?:

@fuxingloh  I have created a new branch. Please use this link for the new PR - https://github.com/DeFiCh/wallet/pull/325


Fixes Modal.show property

The show property wasn't computed at the creation of the component, so Modal.show was always treated as false.

Thanks


is there 2fa moddleware ?

Is there a way to configure 2fa for user?

Not yet. Would you please contribute one?


UI - Container name readability problem on container dropdown

Although I can guarantee all names will fit I added a fix in pr https://github.com/rancher/ui/pull/449

thanks :)

I think what this guy would like is if the name doesn't fit, if you hover over it.. it will pop up the whole name like a tooltip on top of the name in the drop-down.  I've seen this before in other application. But I think this is a bigger code change that would have to be done all drop-downs and not something simple.  Vince?

@lvuch Maybe we can restyle these so that they don't look as much like a dropdown, and the main part can be inline-block however much space it needs instead of being a fixed width.  I don't like how it was too short and cut off names before, but I don't like how it's now too long and empty space for short names, but still can be cut off for long ones.

@vincent99
I would very much be in favour of not having the dropdown. I haven't find it so useful/needed to jump from one container to another in the same host. Never use it...it shows containers from disperate stacks..
What instead I find often needed at that level is to see the other containers that belong to same service. The ability to jump fron one container to another within the same Stack. The main context from a devop point of you is the Stack, not the Host #3275

@vincent99 I added your recommendation in https://github.com/rancher/ui/pull/455

The drop-down still does not show the whole name.  So this is not fixed.

Please have the drop-down actually resize to the largest size need to view text.

@lvuch the box on the page being auto is fine but when you click on it the popup should be whatever width it needs to to fit the content, not match the size of the clicked control. (that might require JS changes in ember-power-select)

Didn't we do this already?

Version - master 3/7
Verified fixed - yes, yes we did do this already


Showcase: Add 4c.rocks To Showcase

The 4c website ( A NEXTJS project) uses Million in automatic mode and isn't on the showcase section of the website. I'd like to add the 4c website to the showcase section of the website.
Can you assign me this issue under the hacktoberfest label?

https://www.4c.rocks/
That is the link to the project, thank you.

Ok, thanks for this. It's yours, go ahead!


Pressing cancel to file download leaves modal rendering box displayed

If you try and download and rtf and then press cancel to the fiel save dialog then the modal rendering box isn't cleared

I think I am not able to replicate this on my computer (on clicking the button no dialog appears, the file is just downloaded). What browser do you use?

Chrome, go to settings search for downloads and set the Ask where to save each file before downloading settings to on

This appears to have been fixed, original problem may be related to incorrect version of pandoc installed on one of the servers we are deploying to.

Closing as can not reproduce.


Fix broken link regression

Pull Request Test Coverage Report for Build acf428bbb3b9639bd53cfdb09f774493caf4c6bd-PR-1449

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.468%

Totals

Change from base Build a44e5498189e45ed57831a7269226d971f97856f:
0.0%

Covered Lines:
1673

Relevant Lines:
2517

💛  - Coveralls


about load s3dg pretrained model error

when I use s3dg extract features, and load s3dg pretrained model, it has a error:
2021-01-10 17:34:50.791160: W tensorflow/core/framework/op_kernel.cc:1651] OP_REQUIRES failed at save_restore_v2_ops.cc:184 : Not found: Key InceptionV1/Conv2d_1a_7x7/biases not found in checkpoint
Traceback (most recent call last):
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 1365, in _do_call
return fn(*args)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 1350, in _run_fn
target_list, run_metadata)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 1443, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.NotFoundError: Key InceptionV1/Conv2d_1a_7x7/biases not found in checkpoint
[[{{node save/RestoreV2}}]]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 1290, in restore
{self.saver_def.filename_tensor_name: save_path})
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 956, in run
run_metadata_ptr)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 1180, in _run
feed_dict_tensor, options, run_metadata)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 1359, in _do_run
run_metadata)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 1384, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.NotFoundError: Key InceptionV1/Conv2d_1a_7x7/biases not found in checkpoint
[[node save/RestoreV2 (defined at /home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/ops.py:1748) ]]
Original stack trace for 'save/RestoreV2':
File "s3dg_feature_extract.py", line 97, in
main()
File "s3dg_feature_extract.py", line 52, in main
saver = tf.compat.v1.train.Saver()
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 828, in init
self.build()
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 840, in build
self._build(self._filename, build_save=True, build_restore=True)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 878, in _build
build_restore=build_restore)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 508, in _build_internal
restore_sequentially, reshape)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 328, in _AddRestoreOps
restore_sequentially)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 575, in bulk_restore
return io_ops.restore_v2(filename_tensor, names, slices, dtypes)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/ops/gen_io_ops.py", line 1696, in restore_v2
name=name)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/op_def_library.py", line 794, in _apply_op_helper
op_def=op_def)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/util/deprecation.py", line 507, in new_func
return func(*args, **kwargs)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/ops.py", line 3357, in create_op
attrs, op_def, compute_device)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/ops.py", line 3426, in _create_op_internal
op_def=op_def)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/ops.py", line 1748, in init
self._traceback = tf_stack.extract_stack()
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 1300, in restore
names_to_keys = object_graph_key_mapping(save_path)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 1618, in object_graph_key_mapping
object_graph_string = reader.get_tensor(trackable.OBJECT_GRAPH_PROTO_KEY)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/pywrap_tensorflow_internal.py", line 915, in get_tensor
return CheckpointReader_GetTensor(self, compat.as_bytes(tensor_str))
tensorflow.python.framework.errors_impl.NotFoundError: Key _CHECKPOINTABLE_OBJECT_GRAPH not found in checkpoint
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "s3dg_feature_extract.py", line 97, in
main()
File "s3dg_feature_extract.py", line 66, in main
'/home/hhq/Project/Text-Video-Retieval-Project/Features_extract/d3dhelper/'
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 1306, in restore
err, "a Variable name or other graph key that is missing")
tensorflow.python.framework.errors_impl.NotFoundError: Restoring from checkpoint failed. This is most likely due to a Variable name or other graph key that is missing from the checkpoint. Please ensure th
at you have not altered the graph expected based on the checkpoint. Original error:
Key InceptionV1/Conv2d_1a_7x7/biases not found in checkpoint
[[node save/RestoreV2 (defined at /home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/ops.py:1748) ]]
Original stack trace for 'save/RestoreV2':
File "s3dg_feature_extract.py", line 97, in
main()
File "s3dg_feature_extract.py", line 52, in main
saver = tf.compat.v1.train.Saver()
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 828, in init
self.build()
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 840, in build
self._build(self._filename, build_save=True, build_restore=True)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 878, in _build
build_restore=build_restore)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 508, in _build_internal
restore_sequentially, reshape)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 328, in _AddRestoreOps
restore_sequentially)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/training/saver.py", line 575, in bulk_restore
return io_ops.restore_v2(filename_tensor, names, slices, dtypes)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/ops/gen_io_ops.py", line 1696, in restore_v2
name=name)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/op_def_library.py", line 794, in _apply_op_helper
op_def=op_def)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/util/deprecation.py", line 507, in new_func
return func(*args, **kwargs)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/ops.py", line 3357, in create_op
attrs, op_def, compute_device)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/ops.py", line 3426, in _create_op_internal
op_def=op_def)
File "/home/hhq/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/ops.py", line 1748, in init
self._traceback = tf_stack.extract_stack()
Looking forward to your answer thank you！

same error here

@Han-Huaqiao @lininglouis
I was able to load the weights by using old s3dg.py.
I hope you will find it helpful.


New pull-request benchmarks dotnet tool

Not yet configured as a dotnet tool
Try to implement SSH keys support for posting comments


Bundle non-prod dependencies with esbuild

This closes #3176, by always bundling dev dependencies using esbuild. Supersedes #6301.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

It's probably worth adding something to the adapter-node readme saying that devDependencies will be bundled and dependencies will not so that people know what to put where

It's probably worth adding something to the adapter-node readme saying that devDependencies will be bundled and dependencies will not so that people know what to put where

Also maybe a general note explaining the difference since it's less obvious than a common node project, like the Sapper docs did.

What about minification of the entire server part and bundling of prod dependencies?

There's really nothing to be gained from minifying server-side code except making it harder to debug. As the README says, if you want a dependency to be bundled, move it to devDependencies

My build weighs 120 MB, which is 3 times more than node 16 alpine. It's sad. You can make minification optional.


[Event Parameter change] codeunit 22 "Item Jnl.-Post Line" - OnPostConsumptionOnBeforeCalcRemainingQuantity

We would like to add parameter RemQtyToPost in event OnPostConsumptionOnBeforeCalcRemainingQuantity
                IsHandled := false;
                //OnPostConsumptionOnBeforeCalcRemainingQuantity(ProdOrderComp, ItemJnlLine, NewRemainingQty, QtyToPost, IsHandled); //A200F0000.Event.o
                OnPostConsumptionOnBeforeCalcRemainingQuantity(ProdOrderComp, ItemJnlLine, NewRemainingQty, QtyToPost, RemQtyToPost, IsHandled); //A200F0000.Event.n
                if not IsHandled then
                    "Remaining Quantity" := Round("Remaining Qty. (Base)" / "Qty. per Unit of Measure", UOMMgt.QtyRndPrecision);

Event Signature:
[IntegrationEvent(false, false)]
local procedure OnPostConsumptionOnBeforeCalcRemainingQuantity(var ProdOrderComp: Record "Prod. Order Component"; var ItemJnlLine: Record "Item Journal Line"; var NewRemainingQty: Decimal; var QtyToPost: Decimal; var RemQtyToPost: Decimal; var IsHandled: Boolean)
begin
    //A200F0000.Event Parameter RemQtyToPost
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


postMessage demo not working

http://html5demos.com/postmessage2
Upon page load, this error appears in the console:
Refused to display 'http://output.jsbin.com/uderi/7' in a frame because it set 'X-Frame-Options' to 'SAMEORIGIN'.

and attempting to post a message results in:
Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('http://jsbin.com') does not match the recipient window's origin ('null').

Same - demo no longer works


Normal exit not working.  Having to use Emergency Exit

After updating to version 3.7.3 I'm not able to use the normal "Exit" from the File menu.   It will only close if I use "Emergency Exit".
Windows 7 Enterprise 64-bit
Service Pack1

Please check logs for any related errors (https://github.com/serge-rider/dbeaver/wiki/Log-files)

I checked my C:\Users<user>.dbeaver.metadata.log and C:\Users<user>.dbeaver.metadata\dbeaver-debug.log log files.  They do not update with any new information when I click "Exit".

Umm, any idea how can I reproduce that?
What's your OS?
Is there anything special about your project?
BTW you could try to reset workspace (https://github.com/serge-rider/dbeaver/wiki/Reset-workspace) - sometimes it become broken after version update.

I'll try the reset.  If that doesn't work, I'll see what info I can gather
for you.
On Thu, Sep 8, 2016, 3:12 PM Serge Rider<EMAIL_ADDRESS>wrote:

Umm, any idea how can I reproduce that?
What's your OS?
Is there anything special about your project?
BTW you could try to reset workspace (
https://github.com/serge-rider/dbeaver/wiki/Reset-workspace) - sometimes
it become broken after version update.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/serge-rider/dbeaver/issues/703#issuecomment-245724900,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEoIwwEAVlnzHX6Fhg1kksJjdMDWqcyWks5qoGw5gaJpZM4J29VD
.

K, I tried the reset but no luck.  I'm running Windows 7 Enterprise 64-bit with Service Pack1.  I have multiple db2 connections.  Attached is my configuration...
dbeaverconfig.txt

Hey,
Well it is fixed now.  I changed my Theme and SQL Editor preferences and clicked apply.  After that normal "Exit" started working again.
Thanks!
David

Great.
I've added extra error handling in shutdown hooks, just in case.

Hi,
I experience the same behaviour as morridm - exit not working.
I'm running dbeaver 3.7.4 on RHEL6, JDK is a 1.8.0_25
Resetting workspace did not help, nothing to be seen in debug-log.

Forgot to mention:  changing  Theme and SQL Editor preferences did not help.
Thanks,
Marc

Same here..
DBeaver 3.7.4 on Fedora 24 with JDK 1.8.0_101
The error apparently start ocorring after update from 3.7.2 to 3.7.3 and persists on 3.7.4

How do you perform version update?
What installer do you use (rpm, deb, zip archive)?
In any case - try to remove previous version completely (but don't touch workspace in ~/.dbeaver) and reinstall new one.

I'm removing the prev. directory completely, and unpack dbeaver-ce-$VERSION-linux.gtk.x86_64.tar.gz, that's it.

RPM package.
I had forgotten, after quit it shows this message:

JVM terminated. Exit code=1
/usr/bin/java
-jar /usr/share/dbeaver//plugins/org.eclipse.equinox.launcher_1.3.100.v20150511-1540.jar
-os linux
-ws gtk
-arch x86_64
-showsplash
-launcher /usr/share/dbeaver/dbeaver
-name Dbeaver
--launcher.library /usr/share/dbeaver//plugins/org.eclipse.equinox.launcher.gtk.linux.x86_64_1.1.300.v20150602-1417/eclipse_1612.so
-startup /usr/share/dbeaver//plugins/org.eclipse.equinox.launcher_1.3.100.v20150511-1540.jar
--launcher.overrideVmargs
-exitdata 3178017
-vm /usr/bin/java
-vmargs
-jar /usr/share/dbeaver//plugins/org.eclipse.equinox.launcher_1.3.100.v20150511-1540.jar

"but don't touch workspace in ~/.dbeaver"
No success after remove/reinstall, but ironically after deleting ~/.dbeaver and configure connections "exit" and close button works again! :open_mouth: :grimacing:

Yeah, I was pretty sure that removing ~/.dbeaver will resolve the problem. But dropping workspace usually isn't an option (because you have lots of artifacts there).
Deleting ~/.dbeaver/.metadata should also help and it is less destructive. Although it contains all downloaded drivers and all UI preferences.
There should be less bloody way top resolve this problem..

I believe I have discovered the cause ..
In "Preferences-> General-> Confirmation" has an option "Exit DBeaver," and I understood it was about "confirm exit DBeaver". So I put as "never" to, I thought, quit the application instantly without confirmation prompt "Are you sure?". In this scenario, the error described above occurred.
Checking "always" it worked as expected; both the close button and the "exit" are now usually worked :smile:
Thank you for your attention and the software, and please excuse any inconvenience :sweat_smile:

Well, this is almost the same as #619.
I'll fix it so setting "Exit DBeaver" to "Never" will be the same as "Always" (means "do not ask").


Several parameters for Set-VM are missing documentation

Prerequisites

[X] Existing Issue: Search the existing issues for this repository. If there is an issue that fits your needs do not file a new one. Subscribe, react, or comment on that issue instead.
[X] Descriptive Title: Write the title for this issue as a short synopsis. If possible, provide context. For example, "Typo in Get-Foo cmdlet" instead of "Typo."
[X] Verify Version: If there is a mismatch between documentation and the behavior on your system, ensure that the version you are using is the same as the documentation. Check this box if they match or the issue you are reporting is not version specific.

Links
https://learn.microsoft.com/en-us/powershell/module/hyper-v/set-vm?view=windowsserver2022-ps
Summary
The following parameters are missing completely:

HighMemoryMappedIoBaseAddress
BatteryPassthroughEnabled
EnhancedSessionTransportType

The following parameters are missing a text description:

LowMemoryMappedIoSpace
HighMemoryMappedIoSpace

Details
No response
Suggested Fix
No response

No Updates?


Use int64_t for nanosecond calculation

In src/profiler.c, profie_setlimit() assign multiplied nanosecond to (long)fsec.
For 32-bit cpu (ac_cv_sizeof_long=4), this cause many testdir/test_FEATNAME.vim fails:
runtest.vim -> RunTheTest() -> timer_start(30000,'TestTimeout') -> profile_setlimit(30000,tm)
-> (long)fsec = 30*10^9  ( > 2^35). Overflowed fsec is negative, assume time has passed.
Same as MSWIN (LONGLONG, double), use int64_t for nanosecond.

@brammool

Using int64_t is not portable, not all compilers support it.
How about using varnumber_T instead?  It already has the #ifdefs to make
it a 64 bit type whenever possible.

Yes I agree.
Changing use varnumber_T, my local pc build & test result fine.