Can't build wasm

Tried to build the WASM file following the instructions but got a bunch of errors like:canny.cpp.o: machine type must be wasm32 from the OpenCV lib included in the download.
So I tried to build opencv @ 4.0.1 with emscripten and it almost works except I can't get it to output the imgcodecs.a file.
Was just trying to do a build with exception catching so I can see why I've got a problem using the wasm directly in a project I'm working on.
Thanks for this project btw, it's great!

Hi Jonathan,
Thank you for the kind words :)
I always try to reproduce bugs with CSTest as an executable as I feel it
gives me much better debug tools (Visual Studio in my case). Any chance you
could do that?
Not sure about your compile issue, it has been a good while since i built
opencv. I'm also unfamiliar with the wasm32 issue as well but I can give
them a try this weekend.
Cheers
Jonas
On Tue., Feb. 4, 2020, 17:00 Jonathan<EMAIL_ADDRESS>wrote:

Tried to build the WASM file following the instructions but got a bunch of
errors like:canny.cpp.o: machine type must be wasm32
so I tried to build opencv @ 4.0.1 with emscripten and it almost works
except I can't get it to output the imgcodecs.a file.
Was just trying to do a build with exception catching so I can see why
I've got a problem using the wasm directly in a project I'm working on.
Thanks for this project btw, it's great!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/relgin/cardspotter/issues/5?email_source=notifications&email_token=AFU3SPCT5BSJYYOJAHA3QHLRBGGKDA5CNFSM4KPZOIR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IK6DNWA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFU3SPEX2JSBI6HXWQUCWX3RBGGKDANCNFSM4KPZOIRQ
.

The bug i'm running into is WASM finishing loading the magic.db database in the browser, so  I don't think CSTest will help there.
It's weird because it loads fine in the extension and it loads fine on my PC when run locally, but on my mac and when deployed, there's an exception after the XHR from emscripten_fetch returns. I'm thinking maybe it's getting the wrong charset or something, but I can't see the actual exception.
But I'd love to be able to build so I could make a more modularized version of the wasm. My use case is that I'm building a peer-to-peer webcam app where we can play magic using our webcams and click on each other's feeds. Cardspotter only works on the first video it sees, so I'm having to merge all the video streams together and that's a bit intense and limits layout possibilities.
Thanks for your reply!

Very cool! Love to see something more come of this. When you say all do you
mean more than one opponent then I guess?
A more modular version is something that I've wanted to do but I have very
little time nowadays (which is why I spent some this summer to make it open
source).
How do you mean deployed? Not sure I understand the setup. Wasm loaded
directly from a webpage (with multiple webcams?). Should be able to
replicate the mouse grab (after some js code cleanup) and send it to the
wasm for detection. And you might be able to modify the extension to work
on that part until you've figured out that annoying bug?
Now about your issue(s). Have you tried an empty file? (Not sure it works
on any version but feels like it should)
Not outputting the img*.a sounds like a config thing but I'm not sure what
it would be. I know I had issues with PNG defines at some point but that
just meant it failed to load images.
Cheers
Jonas Gillberg
On Wed., Feb. 5, 2020, 17:12 Jonathan<EMAIL_ADDRESS>wrote:

The bug i'm running into is WASM finishing loading the magic.db database
in the browser, so I don't think CSTest will help there.
It's weird because it loads fine in the extension and it loads fine on my
PC when run locally, but on my mac and when deployed, there's an exception
after the XHR from emscripten_fetch returns. I'm thinking maybe it's
getting the wrong charset or something, but I can't see the actual
exception.
But I'd love to be able to build so I could make a more modularized
version of the wasm. My use case is that I'm building a peer-to-peer webcam
app where we can play magic using our webcams and click on each other's
feeds. Cardspotter only works on the first video it sees, so I'm having to
merge all the video streams together and that's a bit intense and limits
layout possibilities.
Thanks for your reply!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/relgin/cardspotter/issues/5?email_source=notifications&email_token=AFU3SPAA7R5M4I4OPULLP5TRBLQOBA5CNFSM4KPZOIR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK376CQ#issuecomment-582483722,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFU3SPCGC357LIJ22QRIPODRBLQOBANCNFSM4KPZOIRQ
.

So I finally got it to build. I couldn't get opencv 4.0.1 building so I just buit from opencv master. Here's what I had to do:

Use latest emscripten
Use latest (master) opencv
Modify platforms/js/build_js.py in opencv to change DBUILD_opencv_imgcodecs=ON
run  python ./platforms/js/build_js.py build_wasm --build_wasm --emscripten_dir ../emsdk/upstream/emscripten (or wherever you put your emsdk)
this is the part I was missing, cd into build_wasm and run make
modify buildwasm.sh in cardspotter so that OPENCV= points to your opencv directory
modify buildwasm.sh to include -I$OPENCV/modules/flann/include/ and $OPENCV/build_wasm/lib/libopencv_flann.a because I guess they moved to their own modules now

finally, buildwasm.sh should run just fine. Haven't' actually tested the build yet, just wanted to write that down before I forgot it and in case anyone else runs into trouble building.

Well, after enabling debugging I figured out the actual issue, the generated magic.db file has CRLF line endings, but OSX uses LF line endings. I guess I don't understand why it works in the extension, maybe the extension distribution process auto-converts the file, but git preserves it.
Anyway, I got it working now with LF endings, but in general, I think it might be safer to switch the magic.db to magic.json.
I'll close this issue for now. Let me know if you want a PR with a debug build option and latest openCV instructions.

Of course! >< and fantastic that you got both things to work. A PR would be
great -debug support sounds quite helpful :)
Cheers
Jonas
On Sat., Feb. 8, 2020, 06:59 Jonathan<EMAIL_ADDRESS>wrote:

Well, after enabling debugging I figured out the actual issue, the
generated magic.db file has CRLF line endings, but OSX uses LF line
endings. I guess I don't understand why it works in the extension, maybe
the extension distribution process auto-converts the file, but git
preserves it.
Anyway, I got it working now with LF endings, but in general, I think it
might be safer to switch the magic.db to magic.json.
I'll close this issue for now. Let me know if you want a PR with a debug
build option and latest openCV instructions.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/relgin/cardspotter/issues/5?email_source=notifications&email_token=AFU3SPH3A2GJOEGWHTDUIY3RBZC35A5CNFSM4KPZOIR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFKPOA#issuecomment-583706552,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFU3SPDS5KP4LZIZDLHADOLRBZC35ANCNFSM4KPZOIRQ
.

Hi Jonathan, how is it going?
If there is anything I can do to help please let me know. Also, I'd
appreciate anything you can share in whichever way is most convenient for
you - no need for a polished PR.
Cheers
Jonas
On Sat., Feb. 8, 2020, 07:05 Jonas Gillberg<EMAIL_ADDRESS>wrote:

Of course! >< and fantastic that you got both things to work. A PR would
be great -debug support sounds quite helpful :)
Cheers
Jonas
On Sat., Feb. 8, 2020, 06:59 Jonathan<EMAIL_ADDRESS>wrote:

Well, after enabling debugging I figured out the actual issue, the
generated magic.db file has CRLF line endings, but OSX uses LF line
endings. I guess I don't understand why it works in the extension, maybe
the extension distribution process auto-converts the file, but git
preserves it.
Anyway, I got it working now with LF endings, but in general, I think it
might be safer to switch the magic.db to magic.json.
I'll close this issue for now. Let me know if you want a PR with a debug
build option and latest openCV instructions.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/relgin/cardspotter/issues/5?email_source=notifications&email_token=AFU3SPH3A2GJOEGWHTDUIY3RBZC35A5CNFSM4KPZOIR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFKPOA#issuecomment-583706552,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFU3SPDS5KP4LZIZDLHADOLRBZC35ANCNFSM4KPZOIRQ
.

Hi Jonathan!
Could you share the work you did to add multivideo support? It would
really help people set up remote EDH sessions.
(if not I will start working on it tonight and I would much rather base
anything I do on your work)
Cheers
Jonas
On Sat., Feb. 22, 2020, 09:34 Jonas Gillberg<EMAIL_ADDRESS>wrote:

Hi Jonathan, how is it going?
If there is anything I can do to help please let me know. Also, I'd
appreciate anything you can share in whichever way is most convenient for
you - no need for a polished PR.
Cheers
Jonas
On Sat., Feb. 8, 2020, 07:05 Jonas Gillberg<EMAIL_ADDRESS>wrote:

Of course! >< and fantastic that you got both things to work. A PR would
be great -debug support sounds quite helpful :)
Cheers
Jonas
On Sat., Feb. 8, 2020, 06:59 Jonathan<EMAIL_ADDRESS>wrote:

Well, after enabling debugging I figured out the actual issue, the
generated magic.db file has CRLF line endings, but OSX uses LF line
endings. I guess I don't understand why it works in the extension, maybe
the extension distribution process auto-converts the file, but git
preserves it.
Anyway, I got it working now with LF endings, but in general, I think it
might be safer to switch the magic.db to magic.json.
I'll close this issue for now. Let me know if you want a PR with a debug
build option and latest openCV instructions.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/relgin/cardspotter/issues/5?email_source=notifications&email_token=AFU3SPH3A2GJOEGWHTDUIY3RBZC35A5CNFSM4KPZOIR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFKPOA#issuecomment-583706552,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFU3SPDS5KP4LZIZDLHADOLRBZC35ANCNFSM4KPZOIRQ
.

I just posted a PR, the changes don't help the extension as much, unfortunately, they just make it more modular so other software can incorporate it by passing any image data in an easy to use way.


Fix removeRetiredJob action import for JobMonitor

 Issue by landonreed
Friday Nov 16, 2018 at 17:23 GMT
Originally opened as https://github.com/catalogueglobal/datatools-ui/pull/259

fixes #254

landonreed included the following code: https://github.com/catalogueglobal/datatools-ui/pull/259/commits

 Comment by codecov-io
Friday Nov 16, 2018 at 17:40 GMT

Codecov Report

Merging #259 into dev will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff          @@
##             dev    #259   +/-   ##
=====================================
  Coverage   4.92%   4.92%
=====================================
  Files        324     324
  Lines      15361   15361
  Branches    4636    4636
=====================================
  Hits         756     756
  Misses     12445   12445
  Partials    2160    2160

Impacted Files
Coverage Δ

lib/common/components/Sidebar.js
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f288254...aae754e. Read the comment docs.


Use the package log for Go instead of Printf for internal/debug messages.

didn't use log INSTEAD of fmt.print but rather as an addition, ok like that?

integrated logrus in pr


Ignore/remove IntelliJ files

Same as for the other modules. I ignored/removed intelliJ files from version control.

Updated the pull request to adapt to deletion of .yml  configuration.


Request question

Hi, i'm working on french translation. I would like to implant french translation into updated english dat to work with any version of the game. I use Xi tinkerer to get english dat as YAML file.
Does it would be hard to implant a fonction to generate txt file with the text from dialog dat, from all french zone?

This really isn't a POLUtils issue or question.
Recommend you either come chat with us directly in the Windower Discord: https://discord.gg/aUrHCvk
And/Or possibly chat with the FFXI Modding community: https://discord.gg/cNJA8vZ


Resolve MUWM-3414 - correct the add fund url.

Coverage increased (+0.003%) to 84.395% when pulling 7d546c4815b234097ee9eec2acfc98577d5dc444 on hotfix/MUWM-3414-husky-link into 8988a99cd9ee66dbfc582d5e8e1e714f8d6633e0 on develop.


com.df.notify label ignores false

Description
we defined labels for our service in yml file:
version: "3.4"
services:
my-service:
...
labels:
- com.df.notify=false
- com.df.notifyAcc=true
- com.df.distribute=true
....
For listener environment we defined:
my-proxy-swarm-listener:
image: dockerflow/docker-flow-swarm-listener:18.06.03-26
...
environment:
- DF_NOTIFY_LABEL=com.df.notifyAcc
...
This listener works ok.
But another listener without DF_NOTIFY_LABEL defined also takes com.df.notify as if it was set to true
We expected this another listener will ignore it as if it wasn't defined at all

hi @vfarcic , when do you plan to release new version with this fix?

This should be fixed. Please try the latest release: dockerflow/docker-flow-swarm-listener:19.01.12-20


Display the error message properly.

This change will show the error message properly.
When the response is json or python3 byte string or python string which could be encoded to to json.
We have connection problem with twitter REST API right now :(
Error 215: Bad Authentication data.

When we don't know the type.
We have connection problem with twitter REST API right now :(
Error: {u'errors': [{u'message': u'Bad Authentication data.', u'code': 215}]}

ping!


Frontend react

Description 📜
Topics covered
- What is react icon
- Why to use it
- How to use it
- Different method of styling icons
Fixes #8124

Type of change 📝

[x] Doc#umentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Frontend Dev #React/Angular/Vue

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@anandhu720 Please review this PR sir

@its-me-Harsh-Anand Also please dont create issue by yourself.We are taking this one because you already created this pr.Check our milestone to see open issues which you can work on


[BEAM-4496] Fix #2 for branch fetch failure on job_PostCommit_Website_Publish

Failures in job_PostCommit_Website_Publish  still,
Like https://builds.apache.org/job/beam_PostCommit_Website_Publish/42
05:01:04 FAILURE: Build failed with an exception.
05:01:04
05:01:04 * Where:
05:01:04 Build file '/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Website_Publish/src/website/build.gradle' line: 129
05:01:04
05:01:04 * What went wrong:
05:01:04 Execution failed for task ':beam-website:commitWebsite'.
05:01:04 > org.eclipse.jgit.api.errors.RefNotFoundException: Ref asf-site cannot be resolved
05:01:04
And (to test this) fix up failures because 2.6.0 is in archives.

Generally looks good; I submitted a patch to make the variable read from a property from the command-line: https://github.com/alanmyrvold/beam/pull/3


Creating transportRequestTimeline in diagnostics in case of rntbd exception

Describe the bug
During com.azure.cosmos.implementation.directconnectivity.rntbd.RntbdClientChannelPool$StacklessIllegalStateException
we are having null transportRequestTimeline. Instead it should be not null and the stages which are not reached , it should show null in their start time and duration
Sample below
Current -  >
"supplementalResponseStatisticsList": [{
	"storeResult": {
		"storePhysicalAddress": null,
		"lsn": 0,
		"globalCommittedLsn": -1,
		"partitionKeyRangeId": null,
		"isValid": true,
		"statusCode": 410,
		"subStatusCode": 0,
		"isGone": true,
		"isNotFound": false,
		"isInvalidPartition": false,
		"requestCharge": 0.0,
		"itemLSN": -1,
		"sessionToken": null,
		"exception": "failed to establish connection to cdb-ms-prod-centralus1-fd28.documents.azure.com:14399 due to com.azure.cosmos.implementation.directconnectivity.rntbd.RntbdClientChannelPool$StacklessIllegalStateException: service endpoint was closed while acquiring a channel",
		"transportRequestTimeline": null
	},

Expected ->
"supplementalResponseStatisticsList": [{
	"storeResult": {
		"storePhysicalAddress": null,
		"lsn": 0,
		"globalCommittedLsn": -1,
		"partitionKeyRangeId": null,
		"isValid": true,
		"statusCode": 410,
		"subStatusCode": 0,
		"isGone": true,
		"isNotFound": false,
		"isInvalidPartition": false,
		"requestCharge": 0.0,
		"itemLSN": -1,
		"sessionToken": null,
		"exception": "failed to establish connection to cdb-ms-prod-centralus1-fd28.documents.azure.com:14399 due to com.azure.cosmos.implementation.directconnectivity.rntbd.RntbdClientChannelPool$StacklessIllegalStateException: service endpoint was closed while acquiring a channel",
		"transportRequestTimeline": [{
			"eventName": "created",
			"durationInMicroSec": "3",
			"startTime": "2020-07-27T23:11:26.673125Z"
		}, {
			"eventName": "queued",
			"durationInMicroSec": "165",
			"startTime": "2020-07-27T23:11:26.673128Z"
		}, {
			"eventName": "pipelined",
			"durationInMicroSec": "175",
			"startTime": "2020-07-27T23:11:26.673293Z"
		}, {
			"eventName": "transitTime",
			"durationInMicroSec": null,
			"startTime": null
		}, {
			"eventName": "received",
			"durationInMicroSec": null,
			"startTime": null
		}, {
			"eventName": "completed",
			"durationInMicroSec": null,
			"startTime": null
		}]
	},

Setup (please complete the following information):

V4 4.3.0

Completed , it is there in latest sdk 4.9.0


docs refactor 3/n

The rest of the docs refactor which involves:

organization
content changes
still some to dos in follow on PRs to continue cleaning up / simplifying the docs.

cc @borda @rohitgr7 @justusschock @awaelchli @tchaton

@ananthsub this PR merges structural changes and some clean up.
Maybe let's leave the comments there so we can address in future PRs? we need to spread the doc pages to review across the team, so maybe you can take the GPU section?
cc @Borda


ccache: fix download hash

It came from commit 11870cb (PR #162139).
It's unclear what went wrong; at some moment the hash did match,
so it might be modification of the tag upstream
or some imperfection in the way we canonicalize.

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/hash-mismatch-error-for-ccache-when-updating/18103/2


Localized file check-in by OneLocBuild Task: Build definition ID 21368: Build ID 65085801

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/ceLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

Codecov Report

Merging #1500 (f21098f) into main (e1f00d9) will decrease coverage by 11.98%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1500       +/-   ##
===========================================
- Coverage   87.57%   75.58%   -11.99%
===========================================
  Files         110       10      -100
  Lines        5093      258     -4835
===========================================
- Hits         4460      195     -4265
+ Misses        633       63      -570

Flag
Coverage Δ

unittests
75.58% <ø> (-11.99%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...onsibleai/responsibleai/serialization_utilities.py

...ranalysis/erroranalysis/_internal/cohort_filter.py

...erroranalysis/_internal/error_analyzer/__init__.py

.../responsibleai/_managers/counterfactual_manager.py

raiwidgets/raiwidgets/__init__.py

raiwidgets/raiwidgets/explanation_dashboard.py

...bleai/responsibleai/_tools/causal/causal_config.py

.../responsibleai/_managers/error_analysis_manager.py

responsibleai/responsibleai/_config/__init__.py

...ponsibleai/responsibleai/_tools/shared/__init__.py

... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f00d9...f21098f. Read the comment docs.

Some of these are actually erasing the existing translation in favor of the original English string in localized files. Is it fair to assume that they will be localized again at a later point?

Some of these are actually erasing the existing translation in favor of the original English string in localized files. Is it fair to assume that they will be localized again at a later point?

Let me ask

"Some of these are actually erasing the existing translation in favor of the original English" yes that is strange, huh


comrade gpt-comrade: command not found

gpt-comrade: command not found
On termux

Have you checked that your GOPATH env variable is set correctly? It should by default set to your user folder.
Next, you need add the GOPATH to your PATH. i.e
export PATH=$PATH:$(go env GOPATH)/bin

More details on how to setup the GO env can be found here: https://go.dev/doc/gopath_code#GOPATH

Same issue for me, and your answer solved it.

I don’t use it because I don’t have a ChatGPT api key


feat: add blockstore in block executor initialisations

Description
Adds block store in block executor initialisations

Why is this needed? How was this PR tested? Is there a unit test we can add to prevent regressions?

Because TxStatus adds block store to block executor so we can index status codes.  ref https://github.com/celestiaorg/celestia-core/pull/1399
I just missed this file.


Is sphinx_gallery needed for docs?

Is sphinx_gallery needed for building the docs? Found in requirements_docs.txt, but may be actually not using. See also geopandas/geopandas#1731.

The current template is not using it. I remember we were considering using it to showcase the application examples, but did not use it in the end. I think you can safely delete it. The submodule_template does not include it as a requirement. https://github.com/pysal/submodule_template/blob/master/requirements_docs.txt

#565


Project documentation

Hey,
This project seems very interesting, I would like to know if there is any documentation for
functions usage?

See the readme? there is a short snippet for usage.
As this is C# the auto complete in your editor should help you along 😄

Ok, I will give a try. good luck for all hehe


As the Designer, I want to use Tmux so that I can multiplex terminal shells to increase my productivity.

[x] Setup tmux repo
[ ] Setup tmux config
[x] Enable tmux plugins.

This issue was completed with git-commit c85e103.


feat: support for --remote-debugging-pipe transport

Closes #381
@cyrus-and I see the conversation in #381 where you expressed that you don't believe pipe support is necessary. IMO, using --remote-debugging-pipe is simpler since you don't need to establish a TCP connection or implement network error handling, so here is a patch that enables a user to pass a process option to use stdio instead of websockets.
Passing process also sets local to true since there may not be a TCP port listening.
Thoughts?
Pre-merge checklist:

[ ] need to add tests - holding off to see if the approach here needs to change. I've manually tested this changeset and it works.
[ ] re-write StdioWrapper to not use puppeteer code?

P.S. this provides some motivation for #439 - since there is no default target when using the stdio transport

IMO, using --remote-debugging-pipe is simpler since you don't need to establish a TCP connection or implement network error handling, so here is a patch that enables a user to pass a process option to use stdio instead of websockets.

Yeah, I still don't see why we should need this. The argument that it is simpler is a weak one IMHO since the WebSocket approach is already implemented and well tested, and on the consumer side is just regular exception handling, which BTW you can't never avoid.
What is the real advantage here? The only thing I can think of is that by using the pipe transport you can provide isolation from other users, meaning that only the user that started Chrome can access the CDP, while with the WebSocket approach anyone reaching the endpoint can do that. But this something that can be easily worked around, if really needed, with containerisation.

What is the real advantage here? The only thing I can think of is that by using the pipe transport you can provide isolation from other users, meaning that only the user that started Chrome can access the CDP, while with the WebSocket approach anyone reaching the endpoint can do that. But this something that can be easily worked around, if really needed, with containerisation.

Well, for one, using stdio lets you isolate CDP without containerization.
It also avoids the need for either (1) detecting the port with --remote-debugging-port=0 or (2) praying that the random port you chose for --remote-debugging-port is free.
Additionally, I believe Playwright only exposes the CDP implementation in WebKit via stdio, not via port. So this PR is required to use this library with Playwright.
I think stdio transport merits adding, even if you don't think it's the best way to do things, because it's part of CDP as implemented in Chrome. IMO, chrome-remote-interface should support the full extent of CDP's capabilities, including stdio transport.
But if you feel differently, that chrome-remote-interface's goal is not to 100% support CDP in all forms, that's totally your choice. In which case, I'll either just use my fork or use some other library that supports stdio transport, so no worries.

What is the real advantage here? The only thing I can think of is that by using the pipe transport you can provide isolation from other users, meaning that only the user that started Chrome can access the CDP, while with the WebSocket approach anyone reaching the endpoint can do that. But this something that can be easily worked around, if really needed, with containerisation.

Well, for one, using stdio lets you isolate CDP without containerization.
It also avoids the need for either (1) detecting the port with --remote-debugging-port=0 or (2) praying that the random port you chose for --remote-debugging-port is free.
Additionally, I believe Playwright only exposes the CDP implementation in WebKit via stdio, not via port. So this PR is required to use this library with Playwright.
I think stdio transport merits adding, even if you don't think it's the best way to do things, because it's part of CDP as implemented in Chrome. IMO, chrome-remote-interface should support the full extent of CDP's capabilities, including stdio transport.
But if you feel differently, that chrome-remote-interface's goal is not to 100% support CDP in all forms, that's totally your choice. In which case, I'll either just use my fork or use some other library that supports stdio transport, so no worries.

Is this PR still alive?

@Kle0s the changes in this PR work correctly if you'd like to use my fork, but my impression is that @cyrus-and doesn't wish to merge them upstream due to a perceived lack of benefit.

@flotwig That's why I also raised another reason to support it - the extension installation in runtime seems to require it according to https://peter.sh/experiments/chromium-command-line-switches/#enable-unsafe-extension-debugging


Fix fragment shader output variable in DerivedCommand

Fixes #11339.
When deriving a pick shader, we do the following:

Bundle the main shader code into a czm_non_pick_main function
Call it from a new main function
Check the value of the fragment alpha channel to decide whether to pick or discard the current fragment.

Step 3 requires us to know the name of the output fragment variable: it could be either out_FragColor or out_FragData_0, depending on the structure of czm_non_pick_main.
This PR checks the name of the output variable, and uses the appropriate name in the pick shader, instead of assuming out_FragColor.

Failing Sandcastle in CesiumJS 1.106
Hosted Sandcastle with this fix

Great, thanks @jjhembd! Can you update CHANGES.md?

Thanks again!


feat: Python course lesson about saving data

TODO

[x] intro etc.
[x] export to CSV
[x] export to JSON
[x] fix CI errors
[x] exercises
[x] polish the texts
[x] lesson closing

What do you mean by Crawlee extension? Similar to the JS course, I want to tackle crawling now and then show how this all can be simplified using Crawlee. Not sure yet at which point I'll introduce Crawlee exactly, in the JS course it takes 5 more lessons before Crawlee is mentioned. I'd like to keep the code simple enough so it's easy to follow and once it isn't, I'd bring Crawlee in.

More TODO:

[ ] fix filename= in code examples, should be title=
[ ] fix order of imports, keep them in subsequent order as they're added throughout the course (now Decimal is suddenly first... could be alphabetically, but imho that just adds unnecessary cognitive load)

@honzajavorek is this mergeable? The "TODO" in the original post scared me a bit. All the TODOs are checked, but still not sure if we can merge. Thanks!

@mnmkng yup, it is! I would keep it as a draft otherwise.

Regarding reviews, is it okay to merge now? I assign all four of you, taking Ondra and Lukas as optional. But now I have Vlada approving and Ondra approving, so...
Would it make sense if I always wait for @vdusek (or other pythonistas willing to step in) to check Python, and then perhaps approval from any of you three (Ondra / Lukas / Michał) would then mean it's good to go?

Certainly good to merge 👍🏻 but I agree that waiting for @vdusek to check the Python makes sense 😅


<EMAIL_ADDRESS>issues running (local project)

Describe the bug
Rnv does not install app on iOS real device - iPhone 7 Plus, iOS 15.7.2
To Reproduce

Make sure that real ios device is connected
Do npx rnv run -p ios -d

Expected behavior
App is built and installed to device
Screenshots or copy&paste
 $ rnv run -p ios -d                                                         │
├──────────────────────────────────────────────────────────────────────────────┤
│  ReNative Version: 0.37.0-rc.9                                               │
│  Project Name ($package.name): @rnv/template-starter                         │
│  Project Version ($package.version): 0.37.0-rc.9                             │
│  Workspace ($.workspaceID): rnv                                              │
│  Platform (-p): ios                                                          │
│  Engine ($.platforms.ios.engine): engine-rn                                  │
│  App Config (-c): template                                                   │
│  Build Scheme (-s): debug                                                    │
│  Target (-t): iPhone 14                                                      │
│  Supported Platforms: ios                                                    │
│  Env Info: darwin | x64 | node v16.14.2                                      │
│  Executed Time: 0h:0m:14s:174ms                                              │
│                                                                              │
│ [ success ] [run] Found one device connected! device name: iPhone (2) (15.7.2) udid: c1f91ab2e60ad3d1e25b3d70ec1272a173fa9488
│                                                                              │
│  Project location:                                                           │
│  ./platformBuilds/template_ios/RNVApp.xcworkspace                            │
└────────────────────────

Desktop (please complete the following information):

OS: macOS Monterey 12.6
Node Version: 16.4.2
RNV Version: 0.37.0-rc.9

On iPad (14.7.1) I am getting:
✖ FAILED: node /Users/pauliusguzas/Desktop/rnv14/node_modules/react-native/local-cli/cli.js run-ios --project-path platformBuilds/app_ios --scheme RNVApp --configuration Debug --udid<PHONE_NUMBER>04a06ec4a7ce4fc091c84bdcd76442 --allowProvisioningUpdates
┌──────────────────────────────────────────────────────────────────────────────┐
│  🚀  SUMMARY | 7/14/2023, 2:40:55 PM                                         │
│  $ rnv run -p ios -d -r                                                      │
├──────────────────────────────────────────────────────────────────────────────┤
│  ReNative Version: 0.37.0-rc.14                                              │
│  Project Name ($package.name): rnv14                                         │
│  Project Version ($package.version): 0.1.0                                   │
│  Workspace ($.workspaceID): rnv                                              │
│  Platform (-p): ios                                                          │
│  Engine ($.platforms.ios.engine): engine-rn                                  │
│  Template<EMAIL_ADDRESS>                              │
│  App Config (-c): app                                                        │
│  Build Scheme (-s): debug                                                    │
│  Target (-t): iPhone 14                                                      │
│  Reset Project (-r): true                                                    │
│  Supported Platforms: ios                                                    │
│  Env Info: darwin | x64 | node v16.14.2                                      │
│  Executed Time: 0h:1m:8s:204ms                                               │
│                                                                              │
│ [ success ] [run] Found one device connected! device name: iPad (14.7.1) udid:<PHONE_NUMBER>04a06ec4a7ce4fc091c84bdcd76442
│ [ error ] [run] COMMAND:

node /Users/pauliusguzas/Desktop/rnv14/node_modules/react-native/local-cli/cli.js run-ios --project-path platformBuilds/app_ios --scheme RNVApp --configuration Debug --udid<PHONE_NUMBER>04a06ec4a7ce4fc091c84bdcd76442 --allowProvisioningUpdates

FAILED with ERROR:

error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening RNVApp.xcworkspace.
Command line invocation:
 /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -workspace RNVApp.xcworkspace -configuration Debug -scheme RNVApp -destination id=591253557404a06ec4a7ce4fc091c84bdcd76442 -derivedDataPath build/RNVApp -allowProvisioningUpdates
User defaults from command line:
 IDEDerivedDataPathOverride = /Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/build/RNVApp
 IDEPackageSupportUseBuiltinSCM = YES
/Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/Pods/Pods.xcodeproj: error: Signing for "React-Core-AccessibilityResources" requires a development team. Select a development team in the Signing & Capabilities editor. (in target 'React-Core-AccessibilityResources' from project 'Pods')
2023-07-14 14:40:44.787 xcodebuild[46307:1294662] DVTAssertions: Warning in /System/Volumes/Data/SWE/Apps/DT/BuildRoots/BuildRoot2/ActiveBuildRoot/Library/Caches/com.apple.xbs/Sources/DVTiOSFrameworks/DVTiOSFrameworks-21506/DTDeviceKitBase/DTDKRemoteDeviceData.m:382
Details: (null) deviceType from<PHONE_NUMBER>04a06ec4a7ce4fc091c84bdcd76442 was NULL when -platform called.
Object: <DTDKMobileDeviceToken: 0x7fb170f24de0>
Method: -platform
Thread: <NSThread: 0x600002d307c0>{number = 7, name = (null)}

Command failed with exit code 1: node /Users/pauliusguzas/Desktop/rnv14/node_modules/react-native/local-cli/cli.js run-ios --project-path platformBuilds/app_ios --scheme RNVApp --configuration Debug --udid<PHONE_NUMBER>04a06ec4a7ce4fc091c84bdcd76442 --allowProvisioningUpdates
error React Native CLI uses autolinking for native dependencies, but the following modules are linked manually:
  - react-native-gesture-handler (to unlink run: "react-native unlink react-native-gesture-handler")
This is likely happening when upgrading React Native from below 0.60 to 0.60 or above. Going forward, you can unlink this dependency via "react-native unlink <dependency>" and it will be included in your app automatically. If a library isn't compatible with autolinking, disregard this message and notify the library maintainers.
Read more about autolinking: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md
- Building the app.........
- Building the app.........
- Building the app......
- Building the app.......
- Building the app.....
- Building the app......
- Building the app.
- Building the app...
- Building the app...
- Building the app....
- Building the app.......
- Building the app.
- Building the app...
- Building the app...
- Building the app..
- Building the app.......
- Building the app..
error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening RNVApp.xcworkspace.
info Found Xcode workspace "RNVApp.xcworkspace"
info Building (using "xcodebuild -workspace RNVApp.xcworkspace -configuration Debug -scheme RNVApp -destination id=591253557404a06ec4a7ce4fc091c84bdcd76442 -derivedDataPath build/RNVApp -allowProvisioningUpdates")
Command line invocation:
    /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -workspace RNVApp.xcworkspace -configuration Debug -scheme RNVApp -destination id=591253557404a06ec4a7ce4fc091c84bdcd76442 -derivedDataPath build/RNVApp -allowProvisioningUpdates

User defaults from command line:
    IDEDerivedDataPathOverride = /Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/build/RNVApp
    IDEPackageSupportUseBuiltinSCM = YES

Prepare packages

Computing target dependency graph and provisioning inputs

Create build description
Build description signature: d60f2ed4e39c707bd0a2b51b5ed53af2
Build description path: /Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/build/RNVApp/Build/Intermediates.noindex/XCBuildData/d60f2ed4e39c707bd0a2b51b5ed53af2-desc.xcbuild

note: Building targets in dependency order
/Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/Pods/Pods.xcodeproj: error: Signing for "React-Core-AccessibilityResources" requires a development team. Select a development team in the Signing & Capabilities editor. (in target 'React-Core-AccessibilityResources' from project 'Pods')
/Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/Pods/Pods.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 11.0 to 16.2.99. (in target 'RNGestureHandler' from project 'Pods')
/Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/Pods/Pods.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 10.0, but the range of supported deployment target versions is 11.0 to 16.2.99. (in target 'fmt' from project 'Pods')
warning: Run script build phase 'Create Symlinks to Header Folders' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'fmt' from project 'Pods')
/Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/Pods/Pods.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 11.0 to 16.2.99. (in target 'RCT-Folly' from project 'Pods')
warning: Run script build phase 'Create Symlinks to Header Folders' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'RCT-Folly' from project 'Pods')

2023-07-14 14:40:44.787 xcodebuild[46307:1294662]  DVTAssertions: Warning in /System/Volumes/Data/SWE/Apps/DT/BuildRoots/BuildRoot2/ActiveBuildRoot/Library/Caches/com.apple.xbs/Sources/DVTiOSFrameworks/DVTiOSFrameworks-21506/DTDeviceKitBase/DTDKRemoteDeviceData.m:382
Details:  (null) deviceType from<PHONE_NUMBER>04a06ec4a7ce4fc091c84bdcd76442 was NULL when -platform called.
Object:   <DTDKMobileDeviceToken: 0x7fb170f24de0>
Method:   -platform
Thread:   <NSThread: 0x600002d307c0>{number = 7, name = (null)}
Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
** BUILD FAILED **

info Run CLI with --verbose flag for more details.

error React Native CLI uses autolinking for native dependencies, but the following modules are linked manually:
  - react-native-gesture-handler (to unlink run: "react-native unlink react-native-gesture-handler")
This is likely happening when upgrading React Native from below 0.60 to 0.60 or above. Going forward, you can unlink this dependency via "react-native unlink <dependency>" and it will be included in your app automatically. If a library isn't compatible with autolinking, disregard this message and notify the library maintainers.
Read more about autolinking: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md
- Building the app.........
- Building the app.........
- Building the app......
- Building the app.......
- Building the app.....
- Building the app......
- Building the app.
- Building the app...
- Building the app...
- Building the app....
- Building the app.......
- Building the app.
- Building the app...
- Building the app...
- Building the app..
- Building the app.......
- Building the app..
error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening RNVApp.xcworkspace.

Error: Command failed with exit code 1: node /Users/pauliusguzas/Desktop/rnv14/node_modules/react-native/local-cli/cli.js run-ios --project-path platformBuilds/app_ios --scheme RNVApp --configuration Debug --udid<PHONE_NUMBER>04a06ec4a7ce4fc091c84bdcd76442 --allowProvisioningUpdates
error React Native CLI uses autolinking for native dependencies, but the following modules are linked manually:
  - react-native-gesture-handler (to unlink run: "react-native unlink react-native-gesture-handler")
This is likely happening when upgrading React Native from below 0.60 to 0.60 or above. Going forward, you can unlink this dependency via "react-native unlink <dependency>" and it will be included in your app automatically. If a library isn't compatible with autolinking, disregard this message and notify the library maintainers.
Read more about autolinking: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md
- Building the app.........
- Building the app.........
- Building the app......
- Building the app.......
- Building the app.....
- Building the app......
- Building the app.
- Building the app...
- Building the app...
- Building the app....
- Building the app.......
- Building the app.
- Building the app...
- Building the app...
- Building the app..
- Building the app.......
- Building the app..
error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening RNVApp.xcworkspace.
info Found Xcode workspace "RNVApp.xcworkspace"
info Building (using "xcodebuild -workspace RNVApp.xcworkspace -configuration Debug -scheme RNVApp -destination id=591253557404a06ec4a7ce4fc091c84bdcd76442 -derivedDataPath build/RNVApp -allowProvisioningUpdates")
Command line invocation:
    /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -workspace RNVApp.xcworkspace -configuration Debug -scheme RNVApp -destination id=591253557404a06ec4a7ce4fc091c84bdcd76442 -derivedDataPath build/RNVApp -allowProvisioningUpdates

User defaults from command line:
    IDEDerivedDataPathOverride = /Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/build/RNVApp
    IDEPackageSupportUseBuiltinSCM = YES

Prepare packages

Computing target dependency graph and provisioning inputs

Create build description
Build description signature: d60f2ed4e39c707bd0a2b51b5ed53af2
Build description path: /Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/build/RNVApp/Build/Intermediates.noindex/XCBuildData/d60f2ed4e39c707bd0a2b51b5ed53af2-desc.xcbuild

note: Building targets in dependency order
/Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/Pods/Pods.xcodeproj: error: Signing for "React-Core-AccessibilityResources" requires a development team. Select a development team in the Signing & Capabilities editor. (in target 'React-Core-AccessibilityResources' from project 'Pods')
/Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/Pods/Pods.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 11.0 to 16.2.99. (in target 'RNGestureHandler' from project 'Pods')
/Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/Pods/Pods.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 10.0, but the range of supported deployment target versions is 11.0 to 16.2.99. (in target 'fmt' from project 'Pods')
warning: Run script build phase 'Create Symlinks to Header Folders' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'fmt' from project 'Pods')
/Users/pauliusguzas/Desktop/rnv14/platformBuilds/app_ios/Pods/Pods.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 11.0 to 16.2.99. (in target 'RCT-Folly' from project 'Pods')
warning: Run script build phase 'Create Symlinks to Header Folders' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'RCT-Folly' from project 'Pods')

2023-07-14 14:40:44.787 xcodebuild[46307:1294662]  DVTAssertions: Warning in /System/Volumes/Data/SWE/Apps/DT/BuildRoots/BuildRoot2/ActiveBuildRoot/Library/Caches/com.apple.xbs/Sources/DVTiOSFrameworks/DVTiOSFrameworks-21506/DTDeviceKitBase/DTDKRemoteDeviceData.m:382
Details:  (null) deviceType from<PHONE_NUMBER>04a06ec4a7ce4fc091c84bdcd76442 was NULL when -platform called.
Object:   <DTDKMobileDeviceToken: 0x7fb170f24de0>
Method:   -platform
Thread:   <NSThread: 0x600002d307c0>{number = 7, name = (null)}
Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
** BUILD FAILED **

info Run CLI with --verbose flag for more details.
    at makeError (/Users/pauliusguzas/Desktop/rnv14/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/Users/pauliusguzas/Desktop/rnv14/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

│                                                                              │
│  Project location:                                                           │
│  ./platformBuilds/app_ios/RNVApp.xcworkspace                                 │
└──────────────────────────────────────────────────────────────────────────────┘

getting the same, cant run TVOS, ios

okay I got it working. here are a few things I had to do.

Make sure everything was installed and running with node v 16.
cd platformBuilds/app_tvos and then pod install
open platformBuilds/app_tvos in xcode and when you run the application you will see the annoying bitwise Yoga error. xcode suggested the quick fix.
clean the build and then when you run rnv run and pick tvos it worked for me. Hopefully it works for you too.

not reproduced on 1.0.0-canary.8


fix(worker): Fix import error when using pkg with node v20

Fixes: #143

A test would be highly welcomed, if you can give it a shot. You might want to use spawn to execute pkg.

I've created a test inside test/pkg which packages a tap test into an executable.
My reasoning behind this is that the test should run when packaged into an executable. And then I run each executable and test if there were no errors in stderr.
This is done for node 14, 16, 18 and 20, because I saw that these were used by github actions.
(I tested it on linux, but I'll fix the windows and macos tests as well)


warning: Using the last argument as keyword parameters is deprecated

Trying to run the theme lately repeatedly throws the following warnings:
/home/abhijeet/gems/gems/pathutil-0.16.2/lib/pathutil.rb:502: warning: Using the last argument as keyword parameters is deprecated

This issue is well known and exists in Jekyll 3.x
https://github.com/jekyll/jekyll/issues/7947
A simple way to make the warning go away is to upgrade Jekyll to 4.x
But it seems this theme is dependant on the github-pages gem which has been stuck on Jekyll 3.x since a long time
https://github.com/github/pages-gem/issues/577
So I understand that there is no simple way to make the warning go away by upgrading to Jekyll 4 if we want to use the github-pages gem. But since github-pages isn't showing great support, is there a way to remove that dependency altogether? Then we might be able to update to Jekyll 4. That would require manually setting up some CI to publish to gh-pages branch but that's fine.
Environment

Minimal Mistakes version: Using remote theme
Ruby gem or remote theme version: How do I find out?
Jekyll version: Stuck at 3.7
Git repository URL: https://github.com/cseas/cseas.github.io
GitHub Pages hosted (if yes provide URL to site): www.absingh.com
Operating system: Ubuntu 20.04 LTS

Expected behavior
We should be able to update to Jekyll 4+ to avoid the deprecation warnings.
Steps to reproduce the behavior
bundle exec jekyll serve

Why this is not #2458:
The discussion in that Issue suggests that upgrading to Jekyll 4.1 will solve the issue.
But that's exactly what I'm trying to do. The github-pages dependency is stuck at Jekyll 3.x and stops the upgrade.
So it would be great if there were some steps in the documentation to explain how to use this theme with Jekyll 4.

If you want to use 4.1, replace gitHub-pages with jekyll, run bundle update.
Then you’ll need to look into using a GitHub workflow/action to build your site and push it up to GH Pages since you won’t be using the GH Pages gem anymore.
https://jekyllrb.com/docs/continuous-integration/github-actions/


maybe bug found in DCRNN_cell.py

In function _gconv of model/DCRNN_cell.py, from line 151-168
x = inputs_and_state
x0 = tf.transpose(x, perm=[1, 2, 0])
x0 = tf.reshape(x0, shape=[self._num_nodes, input_size * batch_size])
x = tf.expand_dims(x0, axis=0)

scope = tf.get_variable_scope()
with tf.variable_scope(scope):
    if self._max_diffusion_step == 0:
        pass
    else:
        for support in self._supports:
            x1 = tf.sparse_tensor_dense_matmul(support, x0) # for self._supports[1], x0 is no more the original x0
            x = self._concat(x, x1)

            for k in range(2, self._max_diffusion_step + 1):
                x2 = 2 * tf.sparse_tensor_dense_matmul(support, x1) - x0
                x = self._concat(x, x2)
                x1, x0 = x2, x1 # x0 overwritten here

Here, x0 is the input feature, but overwritten in the last line. So, where dual with the second  support matrix, x0 is no more the original input feature.
So I thought it may be a bug, and to fix it:
x = inputs_and_state
x_in = tf.transpose(x, perm=[1, 2, 0])
x_in = tf.reshape(x_in, shape=[self._num_nodes, input_size * batch_size])
x = tf.expand_dims(x_in, axis=0)

scope = tf.get_variable_scope()
with tf.variable_scope(scope):
    if self._max_diffusion_step == 0:
        pass
    else:
        for support in self._supports:
            x0 = x_in
            x1 = tf.sparse_tensor_dense_matmul(support, x0)
            x = self._concat(x, x1)

            for k in range(2, self._max_diffusion_step + 1):
                x2 = 2 * tf.sparse_tensor_dense_matmul(support, x1) - x0
                x = self._concat(x, x2)
                x1, x0 = x2, x1

Am I right?

Hi @ChangoLin, thanks for your interest in the work. The last line perform the calculation in an iterative manner. You may see the Appendix C of the paper for more information.


[DOCFIX] Update tuning docs

What changes are proposed in this pull request?
Doc update for tuning
Why are the changes needed?
Help users to maximize Alluxio benefit
Does this PR introduce any user facing changes?
Doc fix

@jiacheliu3 @sg-c PTAL, I tried to update some sections of the tuning guide.

Codecov Report

Merging #13870 (2f7c61c) into master (8121a3e) will decrease coverage by 26.11%.
The diff coverage is 0.00%.

:exclamation: Current head 2f7c61c differs from pull request most recent head 877226e. Consider uploading reports for the commit 877226e to get more accurate results

@@              Coverage Diff              @@
##             master   #13870       +/-   ##
=============================================
- Coverage     43.63%   17.52%   -26.12%
+ Complexity     9101     2676     -6425
=============================================
  Files          1386     1386
  Lines         80672    80673        +1
  Branches       9817     9817
=============================================
- Hits          35204    14134    -21070
- Misses        42517    65291    +22774
+ Partials       2951     1248     -1703

Impacted Files
Coverage Δ

...main/java/alluxio/master/AlluxioMasterProcess.java
67.40% <ø> (-6.08%)
:arrow_down:

...main/java/alluxio/master/file/meta/MountTable.java
21.83% <0.00%> (-50.98%)
:arrow_down:

...mon/src/main/java/alluxio/shell/CommandReturn.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/util/ExceptionUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/wire/AlluxioProxyInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/alluxio/wire/AlluxioMasterInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/job/meta/JobIdGenerator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/stress/BaseParameters.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/client/UnderStorageType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...main/java/alluxio/underfs/options/ListOptions.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 658 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8121a3e...877226e. Read the comment docs.

any update on this PR?

@jiacheliu3 @madanadit PTAL

alluxio-bot, merge this please


Add experimental option for HTTP/3 in transparent mode

With these changes I can get (static-curl, macOS, local mode) to work. 🎉
Does that help with any of the other entries on our matrix?

refs #7025


V19 - ConnectionManager spam invalid streams

The Issue
After upgrading to v19 RC35, connection manager keeps trying to recover invalid streams:
2018-02-15 10:15:57,802 INFO     lbrynet.daemon.Daemon:525: Starting the file manager
2018-02-15 10:15:57,835 INFO     lbrynet.file_manager.EncryptedFileManager:105: Trying to start 811 files
2018-02-15 10:15:57,835 INFO     lbrynet.file_manager.EncryptedFileManager:108: Started 0/811 files
2018-02-15 10:15:57,937 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager Titanfall_2_Theme.themepack does not have a head blob
2018-02-15 10:15:59,907 WARNING  lbrynet.core.client.StreamProgressManager:158: Error outputting blob 2f87112c765f32baf8ec99b8379e850387a4596df832a7897377f998cf6f98f80413460a6a46766ba0081cf1a547cde6: Invalid padding bytes.
2018-02-15 10:16:04,707 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:16:17,170 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:16:18,131 INFO     lbrynet.file_manager.EncryptedFileManager:108: Started 500/811 files
2018-02-15 10:16:19,187 WARNING  lbrynet.core.client.StreamProgressManager:158: Error outputting blob bfe5f644d0af2c4a4bc3ec04a9b5260e2625a64b608bfef2819df6e81268567e0c2b35f52e710088db9d211ef8094328: Invalid padding bytes.
2018-02-15 10:16:19,585 WARNING  lbrynet.core.client.StreamProgressManager:158: Error outputting blob<PHONE_NUMBER>5750692d877580a1aabfcf757e71a26c65e62e907bc05ddbaaa404fe968062e5133191d32d3d0f1973b61c: Invalid padding bytes.
2018-02-15 10:16:21,701 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager m0000005.mts does not have a head blob
2018-02-15 10:16:22,180 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:16:26,132 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:16:27,193 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:16:28,342 INFO     lbrynet.file_manager.EncryptedFileManager:123: Started 811 lbry files
2018-02-15 10:16:28,348 INFO     lbrynet.file_manager.EncryptedFileManager:48: Started file manager
2018-02-15 10:16:28,348 INFO     lbrynet.daemon.Daemon:529: Done setting up file manager
2018-02-15 10:16:28,348 INFO     lbrynet.daemon.Daemon:324: Daemon bound to port: 3333
2018-02-15 10:16:28,400 INFO     lbrynet.daemon.Daemon:258: Starting balance: 6.28581605
2018-02-15 10:16:28,400 INFO     lbrynet.daemon.Daemon:261: Started lbrynet-daemon

......reflections.....
2018-02-15 10:18:56,292 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:18:57,308 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:19:01,295 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:19:02,309 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:19:06,296 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:19:07,311 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:19:11,022 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager m0000005.mts does not have a head blob
2018-02-15 10:19:11,296 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:19:11,440 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager Titanfall_2_Theme.themepack does not have a head blob
2018-02-15 10:19:12,312 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:19:16,298 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:19:17,312 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:19:21,299 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:19:22,313 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:19:26,299 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:19:27,315 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:19:31,301 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:19:32,315 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:19:36,302 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:19:37,316 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:19:41,302 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:19:42,318 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:19:44,114 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager Titanfall_2_Theme.themepack does not have a head blob
2018-02-15 10:19:46,303 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:19:47,319 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:19:51,305 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:19:52,319 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:19:56,306 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:19:57,321 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:20:01,308 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:20:02,322 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:20:03,183 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager m0000005.mts does not have a head blob
2018-02-15 10:20:06,309 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:20:07,322 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:20:11,309 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:20:12,323 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:20:16,311 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:20:17,325 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:20:21,312 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:20:22,325 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:20:23,276 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager Titanfall_2_Theme.themepack does not have a head blob
2018-02-15 10:20:26,312 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:20:27,326 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:20:31,313 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:20:32,328 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:20:36,315 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:20:37,328 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:20:41,315 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:20:42,329 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:20:46,316 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:20:47,331 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:20:51,318 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:20:52,332 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:20:56,319 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:20:57,332 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:21:01,319 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:21:02,334 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:21:02,993 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager m0000005.mts does not have a head blob
2018-02-15 10:21:06,321 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:21:07,335 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:21:08,242 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager Titanfall_2_Theme.themepack does not have a head blob
2018-02-15 10:21:11,322 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:21:12,335 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:21:16,322 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:21:17,336 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:21:21,323 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:21:22,338 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:21:26,325 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:21:27,338 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:21:31,325 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:21:32,338 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:21:36,326 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:21:37,339 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:21:41,328 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:21:42,341 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:21:46,328 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:21:47,342 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob
2018-02-15 10:21:50,904 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager Titanfall_2_Theme.themepack does not have a head blob
2018-02-15 10:21:51,329 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager 1 - 'Fear the Boom and Bust' - Keynes vs. Hayek Rap Battle.mp4 does not have a head blob
2018-02-15 10:21:52,342 WARNING  lbrynet.core.client.ConnectionManager:186: Connection Manager lizard-vs-spider.mp4 does not have a head blob

Expected behaviour
Fail to start once, notify user
Actual behaviour
Spams over and over
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

i believe  this is fixed

I'm not sure if @jackrobison tried to fix this particular issue, but he did attempt to clean up invalid streams in RC37. When I ran it, I got the below. He said he's looking into it.
2018-02-22 11:39:06,578 INFO     lbrynet.file_manager.EncryptedFileManager:105: Trying to start 799 files
2018-02-22 11:39:06,579 INFO     lbrynet.file_manager.EncryptedFileManager:108: Started 0/799 files
2018-02-22 11:39:07,627 WARNING  lbrynet.file_manager.EncryptedFileManager:123: Stream for descriptor 59edac42451abeabc06ee734d8b26a60e02a299afeae1e3fe1d8e2ceaf381ac41a915bee74bb687444a9979823b5316c is invalid (Does not end with a zero-length blob.), cleaning it up
2018-02-22 11:39:10,318 WARNING  lbrynet.file_manager.EncryptedFileManager:123: Stream for descriptor 6c17493a0ff3cda2159cb512c4703808c23427351810690b1829304a6264b2e52a21a5f085d83b7122035d509f791caf is invalid (Does not end with a zero-length blob.), cleaning it up
2018-02-22 11:39:34,812 WARNING  lbrynet.database.storage:79: database was locked. rerunning <function runInteraction at 0x03711C30> with args (<lbrynet.database.storage.SqliteConnection instance at 0x04B27CB0>, <function get_and_update at 0x09AE5A70>), kwargs {}
2018-02-22 11:39:39,868 WARNING  lbrynet.database.storage:79: database was locked. rerunning <function runInteraction at 0x03711C30> with args (<lbrynet.database.storage.SqliteConnection instance at 0x04B27CB0>, <function get_and_update at 0x09AE5A70>), kwargs {}
2018-02-22 11:39:44,924 WARNING  lbrynet.database.storage:79: database was locked. rerunning <function runInteraction at 0x03711C30> with args (<lbrynet.database.storage.SqliteConnection instance at 0x04B27CB0>, <function get_and_update at 0x09AE5A70>), kwargs {}
2018-02-22 11:39:49,979 WARNING  lbrynet.database.storage:79: database was locked. rerunning <function runInteraction at 0x03711C30> with args (<lbrynet.database.storage.SqliteConnection instance at 0x04B27CB0>, <function get_and_update at 0x09AE5A70>), kwargs {}
2018-02-22 11:39:49,980 CRITICAL twisted:154: Unhandled error in Deferred:
2018-02-22 11:39:49,980 CRITICAL twisted:154:
Traceback (most recent call last):
  File "site-packages\twisted\python\threadpool.py", line 246, in inContext
  File "site-packages\twisted\python\threadpool.py", line 262, in <lambda>
  File "site-packages\twisted\python\context.py", line 118, in callWithContext
  File "site-packages\twisted\python\context.py", line 81, in callWithContext
  File "site-packages\twisted\enterprise\adbapi.py", line 477, in _runInteraction
  File "site-packages\twisted\enterprise\adbapi.py", line 467, in _runInteraction
  File "site-packages\lbrynet\database\storage.py", line 268, in get_and_update
OperationalError: database is locked
2018-02-22 11:39:55,091 WARNING  lbrynet.file_manager.EncryptedFileManager:123: Stream for descriptor 57fdb5dbc26e84a6458bbd7990412c7b6895a909666c41dedfd25cbb38f3426e3ed66b82d2201be36e239324b0d01d94 is invalid (Does not end with a zero-length blob.), cleaning it up
2018-02-22 11:39:55,108 WARNING  lbrynet.file_manager.EncryptedFileManager:123: Stream for descriptor 285c351beb4f98264da44e02e70ef1b2112722513604ccde823918a81827d80aecc8b6157c694647d62edd41b9af2fa8 is invalid (Does not end with a zero-length blob.), cleaning it up
2018-02-22 11:40:01,471 WARNING  lbrynet.file_manager.EncryptedFileManager:123: Stream for descriptor 224aa1ef6446168de9fdf1a9fabc15cefbbea75c1d01ff9831a1b58aba6ad793795556d94b98e97a3cc8475df702e1b1 is invalid (Does not end with a zero-length blob.), cleaning it up
2018-02-22 11:40:03,102 WARNING  lbrynet.file_manager.EncryptedFileManager:123: Stream for descriptor 54b86ab68614d0aa014f18dbdd190b5a70c9b60fccc50c25cbdfe5422f18156dbd5693d31903c3782c8c7e4875028816 is invalid (Does not end with a zero-length blob.), cleaning it up
2018-02-22 11:40:04,049 WARNING  lbrynet.core.client.StreamProgressManager:158: Error outputting blob 2f87112c765f32baf8ec99b8379e850387a4596df832a7897377f998cf6f98f80413460a6a46766ba0081cf1a547cde6: Invalid padding bytes.
2018-02-22 11:40:34,769 WARNING  lbrynet.database.storage:79: database was locked. rerunning <function runInteraction at 0x03711C30> with args (<lbrynet.database.storage.SqliteConnection instance at 0x04B27CB0>, <function get_and_update at 0x048CC670>), kwargs {}
2018-02-22 11:40:39,825 WARNING  lbrynet.database.storage:79: database was locked. rerunning <function runInteraction at 0x03711C30> with args (<lbrynet.database.storage.SqliteConnection instance at 0x04B27CB0>, <function get_and_update at 0x048CC670>), kwargs {}
2018-02-22 11:40:44,069 WARNING  lbrynet.file_manager.EncryptedFileManager:123: Stream for descriptor 9b42adab4f9154e10ef2ec610f730c3a0d9e6d0be1bec772ac5334f345bc3d08467beb254fe9b2ac2965fc819341aa51 is invalid (Does not end with a zero-length blob.), cleaning it up
2018-02-22 11:41:27,500 WARNING  lbrynet.file_manager.EncryptedFileManager:123: Stream for descriptor 8445ccf3283acac0ff963b82fe310c03f3b257b65418944576f323644c2de6ff0f3d83afd10e707054bcd956d7a9dde9 is invalid (Does not end with a zero-length blob.), cleaning it up
2018-02-22 11:41:28,315 ERROR    lbrynet.daemon.DaemonControl:113: Failed to start lbrynet-daemon
Traceback (most recent call last):
  File "site-packages\lbrynet\daemon\DaemonControl.py", line 110, in start_server_and_listen
  File "site-packages\twisted\internet\defer.py", line 1297, in _inlineCallbacks
  File "site-packages\twisted\python\failure.py", line 389, in throwExceptionIntoGenerator
  File "site-packages\lbrynet\daemon\DaemonServer.py", line 51, in start
  File "site-packages\twisted\internet\defer.py", line 1297, in _inlineCallbacks
  File "site-packages\twisted\python\failure.py", line 389, in throwExceptionIntoGenerator
  File "site-packages\lbrynet\daemon\Daemon.py", line 256, in setup
  File "site-packages\twisted\internet\defer.py", line 1297, in _inlineCallbacks
  File "site-packages\twisted\python\failure.py", line 389, in throwExceptionIntoGenerator
  File "site-packages\lbrynet\daemon\Daemon.py", line 529, in _setup_lbry_file_manager
  File "site-packages\twisted\internet\defer.py", line 1297, in _inlineCallbacks
  File "site-packages\twisted\python\failure.py", line 389, in throwExceptionIntoGenerator
  File "site-packages\lbrynet\file_manager\EncryptedFileManager.py", line 47, in setup
  File "site-packages\twisted\internet\defer.py", line 1297, in _inlineCallbacks
  File "site-packages\twisted\python\failure.py", line 389, in throwExceptionIntoGenerator
  File "site-packages\lbrynet\file_manager\EncryptedFileManager.py", line 125, in _start_lbry_files
  File "site-packages\twisted\internet\defer.py", line 1297, in _inlineCallbacks
  File "site-packages\twisted\python\failure.py", line 389, in throwExceptionIntoGenerator
  File "site-packages\lbrynet\database\storage.py", line 343, in delete_stream
  File "site-packages\twisted\python\threadpool.py", line 246, in inContext
  File "site-packages\twisted\python\threadpool.py", line 262, in <lambda>
  File "site-packages\twisted\python\context.py", line 118, in callWithContext
  File "site-packages\twisted\python\context.py", line 81, in callWithContext
  File "site-packages\twisted\enterprise\adbapi.py", line 477, in _runInteraction
  File "site-packages\twisted\enterprise\adbapi.py", line 467, in _runInteraction
  File "site-packages\lbrynet\database\storage.py", line 342, in _delete_stream
InterfaceError: Error binding parameter 0 - probably unsupported type.
2018-02-22 11:41:28,319 INFO     lbrynet.daemon.DaemonServer:55: Stopping the reactor
2018-02-22 11:41:28,319 INFO     lbrynet.daemon.Daemon:419: Closing lbrynet session
2018-02-22 11:41:28,325 INFO     lbrynet.daemon.Daemon:420: Status at time of shutdown: loading_file_manager
2018-02-22 11:41:28,336 INFO     lbrynet.file_manager.EncryptedFileManager:154: Stopping 117 lbry files
2018-02-22 11:41:28,371 INFO     lbrynet.core.Session:174: Stopping session.
2018-02-22 11:41:28,371 INFO     lbrynet.core.BlobAvailability:35: Stopping blob availability tracker.
2018-02-22 11:41:28,375 INFO     lbrynet.core.RateLimiter:83: Stopping rate limiter.
2018-02-22 11:41:28,377 INFO     lbrynet.core.client.DHTPeerFinder:32: Stopping DHT peer finder.
2018-02-22 11:41:28,407 INFO     lbrynet.core.server.DHTHashAnnouncer:31: Stopping DHT hash announcer.
2018-02-22 11:41:28,407 INFO     lbrynet.core.Wallet:103: Stopping wallet.
2018-02-22 11:41:28,473 INFO     lbrynet.core.Wallet:889: Stopped wallet
2018-02-22 11:41:28,474 INFO     lbrynet.core.Wallet:892: Stopped connection to lbryum server
2018-02-22 11:41:28,474 INFO     lbrynet.core.Session:340: Unsetting upnp for session
2018-02-22 11:41:28,480 INFO     lbrynet.dht.protocol:445: Stopping DHT
2018-02-22 11:41:28,480 INFO     lbrynet.dht.protocol:461: DHT stopped

This was fixed in RC1/RC2 (which have startup issues), but still broken in 0.19.0. Jack will be releasing an updated daemon with the fix for "InterfaceError: Error binding parameter 0 - probably unsupported type."

Closing, PC which had stream cleanup issues is now working great on RC7.


Investigate leftover artifact in /etc/hosts for OCI builds

It appears that Wardroom (when used to build images) leaves behind a leftover hostname artifact in /etc/hosts when building OCI images. We need to investigate and correct whatever may be creating this leftover artifact.

PR #109 fixes this issue.

Closed via PR #109.


Add module with Http4s Blaze server

on top of https://github.com/47deg/TBD/pull/42 as we need the Async instance.
an initial attempt to add the http4s backend server, currently blocked while waiting to see if we can make Async.uncancelable work and use it.

The comment have been addressed in 62cfea3 but as said this won't work until we have the Async instance


[META] Resolve TODOs in code prior to release

The following TODO comments should be resolved prior to release by one or more of:

doing the thing that needs to be done (if quick, write a PR, if it will take more than a day, write an issue)
deciding that the TODO can be handled in a future release and documenting it in an issue
disabling a functionality that is incomplete (and write an issue)

TODOs:

[ ] Workflow steps that create resources but don't have a corresponding deletion should be disabled until fully implemented.  This includes register model group, create ingest pipeline, and create index. (lines 32, 36, 38)
[ ] FlowFrameworkIndicesHandler has comments on updating/concurrency/retry (lines 443, 473, 477)
[ ] Provisioning progress detail (line 14 and WorkflowState line 54)
[ ] WorkflowState access control error line 111
[ ] Get Workflow State get the full template?
[x] Provision Workflow error message improvement https://github.com/opensearch-project/flow-framework/pull/298
[ ] Search Workflow access controller question
[ ] EncryptorUtils improve handling of which fields are encrypted
[ ] RestHandlerUtils special handling for UI Metadata
[ ] Create Connector Step comment on retrying
[ ] Create Index Step and Create Ingest Pipeline Steps, same refactoring of input data already done for most other steps
[x] ProcessNode better getCause handling https://github.com/opensearch-project/flow-framework/pull/327
[ ] ProcessNode still using generic thread pool executor
[ ] FlowFrameworkPlugin executorBuilder thread pool settings

The following TODO are probably done, should be confirmed:

[x] ResourceCreated enum called out in line 33
[ ] Template writeable comment called out on line 245

Get Workflow State get the full template?

This doesnt seem like a priority to me, @amitgalitz wdyt?

EncryptorUtils improve handling of which fields are encrypted

Currently the only field we need to encrypt is the credential field of the Create Connector Step. I think we can hold off on this item until we have a new field that requires encryption

Template writeable comment called out on line 245

Perhaps we can just write the Template json string to the output stream and then parse the Template when reading it in. We can avoid having to write a complex writeTo method

Get Workflow State get the full template?

This doesnt seem like a priority to me, @amitgalitz wdyt?

Yeah don't think its a must even for GA, I also made an issue for this earlier so can probably be removed from the TODO list as its tracked there. https://github.com/opensearch-project/flow-framework/issues/171

EncryptorUtils improve handling of which fields are encrypted

Currently the only field we need to encrypt is the credential field of the Create Connector Step. I think we can hold off on this item until we have a new field that requires encryption

agree on this, this is the only field that currently needs to be encrypted for us.

Perhaps we can just write the Template json string to the output stream and then parse the Template when reading it in.

I think we actually do this, in which case we should remove the TODO. Can you confirm?
We could get fancy and use a byte array with CBOR or SMILE 😁

FlowFrameworkIndicesHandler has comments on updating/concurrency/retry (lines 443, 473, 477)

I believe we can address this in a future release, as we are not heavily relying on the update template operation currently. We can resolve this issue after thoroughly discussing the type of retry strategy we want to implement later.

FlowFrameworkIndicesHandler has comments on updating/concurrency/retry (lines 443, 473, 477)

Right now this is has been fixed by updating the state index correctly and adding retries. Some improvements could be made but okay to not have in GA in my opinion. I will write an issue for all these TODOs


Setting handshake timeout Websocket client

i create a stresstest tool for websocket, somehow from server did not send any handshake ,
from 10 connection i only receive 8 handshake
is possible to setting client handshake timeout with websocket server from springboot
thank you so much !

To clarify, you are using this library as a client and spring boot as a server?

yes, this library for clien and springboot as a server

No example and no real str provided.
Closing as cannot reproduce


devtools docs

Doc site updates
Change Type (required)
Indicate the type of change your pull request is:

[x] patch
[ ] minor
[ ] major

Does your PR have any documentation updates?

[x] Updated docs
[ ] No Update needed
[ ] Unable to update docs

A couple broad comments

Devtools vs dev tools usage should be standardized
Capitalization for titles should be standardized


JS Engine : Memory leaks after 2 songs

Describe your bug here. If you are modding, try testing your bug in a clean version of the engine instead. Also, if you're using an older version of JSE, please try the latest version/action build. Also, be sure to check the pinned 'JS Engine: Known Issues' issue, to check if your issue hasn't already been found!
I was just debugging my mod and randomly it started leaking memory, Same on latest versions of the Engine
Command Prompt/Terminal/Crash logs (if existing)
No response
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
tutorial for da thing!!111!1!!!1111
steoep oen
loadsa a song
stwesrp twoe
sloasd antoeher song
boomhgo
mermeoy lekasks11!!11
Understandable version
Step 1,
Load a song
Step 2,
Load another song
boom
memory leaks
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
working on mod
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.


MergeTree: Organize and Deprecated Collections

Description
The merge tree package exports a number of collection classes that it should export. A number should be internal to merge tree itself and not exported at all, some are used across packages, and some are unused in merge tree, but used in sequence.
Note: I am intentionally not including a breaking note here. These classes are not fundamental to the merge tree api surfaces, and are only exported for erroneous legacy reasons. Since they are not on the api surface, i do not expect any outside usage

Where/when will collections.ts be removed?

Where/when will collections.ts be removed?

collections.ts is remove in this pr already, git is seeing it as the move to the rbTree.ts file


Version 1.0.9 mop-up

Note that I already pushed the version-history.html changes from github.

Updated README.md to point to latest releases rather than version-history.md.
Keeping version-history.md for now but updated it with a deprecation notice and a link to the latest release page.


Move template files from templates to templates/sqladmin

Closes #747
I ran the test suite, looking good 🚀.
I "visually" tested it with the example code from Working with Custom Views - SQLAlchemy Admin, works fine ☮.

First, thanks all. I appreciate you.
I understand why it may be desirable to move templates to a 'templates/sqladmin' folder, but am curious why you just don't initialize the package loader with the 'templates/sqladmin' like so:
def init_templating_engine(self) -> Jinja2Templates:
        templates = Jinja2Templates("templates")
        loaders = [
            FileSystemLoader(self.templates_dir),
            PackageLoader("sqladmin", "templates/sqladmin"),
        ]

then you wouldn't have to add the 'sqladmin' to the extends. For instance in index.html:
{% extends "sqladmin/layout.html" %}
My point being, that if I have a custom 'layout.html', or other html file, that I want shared between sqladmin and another application (a directory that doesn't start with 'sqladmin') I can't do that then without overriding every other template file in the package that references 'sqladmin/layout.html'. But when the index.html file extends is as such:
{% extends "layout.html" %}
the package loader would still be able to find  'templates/sqladmin/layout.html' but other loaders (in priority of choice before the package loader) would also be able to load a custom version of the file in whatever directories are in the loader's searchpath (ie 'templates/something_else/layout.html') without having to modify all of the other core template files accessed by the package loader.
I feel the way this is implemented actually hinders customization, and reusability, of templates because if you want to use a single custom template that is not in a 'sqladmin' directory (possible because it's shared with other applications), you have to then modify/override every other template in the package that references it - and then manually edit each one of those every time changes are made to the sqladmin codebase or default templates when you could just be using the default package templates instead.
I think this should be re-opened for discussion. Please let me know if this makes sense or if there is anything else I can do or provide to clarify my point.
Thanks again.

but am curious why you just don't initialize the package loader with the 'templates/sqladmin'

If you check out the problem at #747, you'll understand why we went in that direction.

I can't do that then without overriding every other template file in the package that references 'sqladmin/layout.html'.

Here is a solution recommendation for your scenario: https://github.com/aminalaee/sqladmin/discussions/762#discussioncomment-9427086
I also want to point out that this idea comes from Flask Admin, which has proved it's reusability end extendibility.

Thanks for the reply!
I love this project because it stays as true to flask-admin as it can.
After 'correctly' updating my custom admin code, directory structure, and templates, I have come to conclusion that I no longer have issues, and have made my peace, with this change.

Thanks for the reply!

You're welcome 🙏.

I love this project because it stays as true to flask-admin as it can.

I totally agree, I'm working on a Starlette adoption of Flask Admin, let me know if you are interested in, I'll share a link.

After 'correctly' updating my custom admin code, directory structure, and templates, I have come to conclusion that I no longer have issues, and have made my peace, with this change.

😂, happy to hear that. @flask-admin people did a lot of good design decisions, years of experience right?. Even though I don't understand some parts of its source code, I left them as is. They might know better! 🚀🚀🚀.

Thanks for your project, first of all!
I've faced an issue using a 0.19 version after 0.16.1. I could not just create templates folder, move there original package files and customize them a bit. Using templates_dir parameter doesn't help.
Is there any way to achieve such goals like localisation and customisation?
Thanks in advance.

I think I didn't fully get your question.
Why would you move original package files there? You should override them in your templates directory.

Because I'd like to use them with minimal changes)
BTW, I found a solution, not sure if it's right but it works.

admin = Admin(app, templates_dir="templates")
Created templates folder with subfolder sqladmin
Moved all the original html files from package to templates/sqladmin
Changed all the paths to html files inside html files by adding "sqladmin/" to the left of the file name.

This works fine for me, and now I successfully override base files.

Yes that is correct. This was the intention of this PR to need sqladmin inside the templates. Feel free to update the docs if you feel like there's missing information.

I hope this clarifies what you said: https://github.com/aminalaee/sqladmin/pull/817