add preset for nail salon

Here's a pull request that adds nail salons (where people have their fingernails lacquered and/or manicured) to the generic preset.
The common tags for tagging these are shop=beauty and beauty=nails. taginfo and wiki
I wasn't sure on the correct file location for this preset but I created a new folder within the shop folder, and
named it after its parent tag, beauty.
This structure is based the practice of presets whose meaning are not defined so much by their first tag but rather by their second tag. This occurs with a mosque which has amenity=place_of_worship and religion=muslim)[https://github.com/openstreetmap/iD/tree/master/data/presets/presets/amenity/place_of_worship].
Bryan, would you like iD continue with this precendence?

My other question regarding this PR is that after adding this preset, rebuilding the presets, and testing it locally, there's an additional box of 'beauty' as indicated in the image below. Is there a way to hide this?

Thanks for this @skorasaurus!  You are right that this preset works a lot like the religion one, so adding a subfolder under shop makes sense (just like for religion, there is a subfolder under amenity).
To answer your question, that extra "type" field was because you added the shop field.  I removed it, so it won't show anymore for the Nail Salon preset.   The reason we have generic fields like this is in case someone creates a shop with a type that we don't recognize as a preset.  For example, somebody could tag a business as shop=halloween and even though we don't have a preset for that specific kind of shop, it will show the "generic" shop, and that type field will say "halloween".  We can leave it off from the specific presets.
A few other points:

I added a Tanning Salon preset for beauty=tanning also, it is the next most common preset after beauty=nails.
You don't need to list "Nail Salon" or "Nails" in the terms list for beauty=nails because it's in the value already.  I replaced those with "manicure" and "pedicure" which are related words that people might search for.

Again, thanks so much for your contribution!

I added a Tanning Salon preset for beauty=tanning also, it is the next most common preset after beauty=nails.

leisure=tanning_salon is documented on the wiki and used almost five times as much.

leisure=tanning_salon is documented on the wiki and used almost five times as much.

Yes, but the wiki page for leisure=tanning_salon is pretty thin, and the talk page is just one comment saying "what is this doing here?".  That tag looks like a mistake to me..


Escape throws an error when drawing area with only one point

[Error] TypeError: undefined is not an object (evaluating 'entity.id')
	isInvalidGeometry (iD.js:60348)
	checkGeometry (iD.js:60313)
	finish (iD.js:60522)
	call (iD.js:786)
	ret (iD.js:30157)
	testBindings (iD.js:28419)
	bubble (iD.js:28477)
	(anonymous function) (iD.js:1527)

Possibly related: #5911

hmmm... seems to be a scenario where graph.childNodes does not return all nodes in the way...

Is there reason why we could not just use the parent's node property? I will keep digging into childNodes function too

I think those are changes I made some time last year to check if an area self intersects.
It probably just needs an if() statement to avoid the instance when there is only 1 node (i.e. nodes.length-2 resolves to -1 and hence entity gets set to undefined)

#4860

@maxgrossman what happens if you inspect the node immediately after graph.getChildNodes(parent)  is called?
All the nodes should probably be there in that case, but in your screenshot, nodes.splice() has already been called, which will remove a node.

@quincylvania Out of interest, graph.childNodes(way) might actually be slightly dangerous, in that modifying a variable that was set to graph.childNodes(way) will change the underlying childNodes value.

Presumeably, the underlying childNodes data should always remain constant, regardless of what the user does with any assigned variables, unless its meant to be like this?

Presumeably, the underlying childNodes data should always remain constant, regardless of what the user does with any assigned variables, unless its meant to be like this?

Yes you should always _clone() the result of childNodes if you intend to modify it.

Is it worth forcing it through in the childNodes method and _clone-ing it before returning?

Is it worth forcing it through in the childNodes method and _clone-ing it before returning?

I don't understand what you're asking.

As in:
https://github.com/openstreetmap/iD/blob/c09171d0e2c597c4d8b51accfb3b4642f64d7094/modules/core/graph.js#L107
return this._childNodes[entity.id] could be return _clone(this._childNodes[entity.id])

return this._childNodes[entity.id] could be return _clone(this._childNodes[entity.id])

It's extremely hot code, so I'd rather not introduce an extra _clone when it's usually not needed.


Problem With Demo 1 Real-time Web In VMware's Docker container of Mac

I woking on Mac(macOS Sierra Version 10.12.6) and set up with docker.
But I using VMware create Ubuntu VM(ubuntu-14.04.5-server-amd64.iso) instead of Docker-for-Mac
In the Ubuntu VM, following https://docs.docker.com/engine/installation/linux/docker-ce/ubuntu set up Docker.
And using SSH connect to Ubuntu VM and download OpenFace from https://github.com/cmusatyalab/openface.
Following Steps

cd <OpenFace>

docker build . -t openface

docker run -p 9000:9000 -p 8000:8000 -t -id openface /bin/bash -l -c '/root/openface/demos/web/start-servers.sh'

curl test, and error.

root@david:~/openface# curl <IP_ADDRESS>:8000 -v
* Rebuilt URL to: <IP_ADDRESS>:8000/
* Hostname was NOT found in DNS cache
*   Trying <IP_ADDRESS>...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 8000 (#0)
> GET / HTTP/1.1
> User-Agent: curl/7.35.0
> Host: <IP_ADDRESS>:8000
> Accept: */*
>
* Empty reply from server
* Connection #0 to host <IP_ADDRESS> left intact
curl: (52) Empty reply from server

When I Into the container check process, seem is like fine.
root@2000b6581e1e:/# ps -eaf
UID         PID   PPID  C STIME TTY          TIME CMD
root          1      0  0 09:03 pts/0    00:00:00 /bin/bash /root/openface/demos/web/start-servers.sh
root          8      1  0 09:03 pts/0    00:00:00 python2 simpleSSLServer.py 8000
root          9      1  0 09:03 pts/0    00:00:02 python2 ./demos/web/websocket-server.py --port 9000
root         10      1  0 09:03 pts/0    00:00:00 tee /tmp/openface.websocket.log
root         19      9  0 09:03 pts/0    00:00:00 /root/torch/install/bin/luajit -e package.path="/root/.luarocks/share/lua/5.1/?.lua;/root/.luarocks/share/lua/5.1/
root         30      0  0 09:34 pts/1    00:00:00 /bin/bash
root         44     30  0 09:34 pts/1    00:00:00 ps -eaf

root@2000b6581e1e:/# netstat -an
Active Internet connections (servers and established)
Proto Recv-Q Send-Q Local Address           Foreign Address         State
tcp        0      0 <IP_ADDRESS>:8000            <IP_ADDRESS>:*               LISTEN
tcp        0      0 <IP_ADDRESS>:9000            <IP_ADDRESS>:*               LISTEN
Active UNIX domain sockets (servers and established)
Proto RefCnt Flags       Type       State         I-Node   Path

That Demo 2: Comparing two images is working.
For the Demo1, where I am wrong?

I sovled.
https --> http
ws --> wss
modify ./demos/web/websocket-server.py
def main(port):
    httpd = BaseHTTPServer.HTTPServer(('<IP_ADDRESS>', port), SimpleHTTPServer.SimpleHTTPRequestHandler)
    '''httpd.socket = ssl.wrap_socket(httpd.socket, certfile='tls/server.pem', server_side=True)'''
    print('now serving tls http on port:', port)
    httpd.serve_forever()

modify ./demos/web/websocket-server.py
/demos/web/index.html
<!--  createSocket("wss://" + window.location.hostname + ":9000", "Local");-->
 createSocket("ws://" + window.location.hostname + ":9000", "Local");


support for opt in training

What's here
Fixes support for training with OPT models. The problem was that hugging face's implementation of OPT does not support the Fast Tokenizer. However our training code was making use of the .sequence_ids() method of the Fast Tokenizer. So this fix uses the token_type_ids instead.
Results
python -m catwalk.train --model opt-125m --task piqa
100%|██████████| 3/3 [00:00<00:00, 528.43it/s]
Downloading pytorch_model.bin: 100%|██████████| 239M/239M [00:04<00:00, 52.4MB/s]
Downloading tokenizer_config.json: 100%|██████████| 685/685 [00:00<00:00, 417kB/s]
Downloading vocab.json: 100%|██████████| 878k/878k [00:00<00:00, 959kB/s]
Downloading merges.txt: 100%|██████████| 446k/446k [00:00<00:00, 824kB/s]
Downloading special_tokens_map.json: 100%|██████████| 441/441 [00:00<00:00, 183kB/s]
Training:   0%|          | 0/10000 [00:00<?, ?it/s]Asking to truncate to max_length but no maximum length is provided and the model has no predefined maximum length. Default to no truncation.
 Disabling parallelism to avoid deadlocks...
To disable this warning, you can either:
        - Avoid using `tokenizers` before the fork if possible
        - Explicitly set the environment variable TOKENIZERS_PARALLELISM=(true | false)
Running log-likelihood queries: 100%|##########| 3676/3676 [00:01<00:00, 3171.73it/s]
huggingface/tokenizers: The current process just got forked, after parallelism has already been used. Disabling parallelism to avoid deadlocks...
To disable this warning, you can either:
        - Avoid using `tokenizers` before the fork if possible
        - Explicitly set the environment variable TOKENIZERS_PARALLELISM=(true | false)
Calculating metrics: 100%|##########| 1838/1838 [00:02<00:00, 896.49it/s]
huggingface/tokenizers: The current process just got forked, after parallelism has already been used. Disabling parallelism to avoid deadlocks...
To disable this warning, you can either:
        - Avoid using `tokenizers` before the fork if possible
        - Explicitly set the environment variable TOKENIZERS_PARALLELISM=(true | false)
piqa    acc     0.5146898627281189

After the change
python -m catwalk.train --model rc::tiny-gpt2 --task piqa
100%|███████████████████████████████████████████████████████████████████████████████████████| 3/3 [00:00<00:00, 195.40it/s]
Running log-likelihood queries: 100%|##########| 2000/2000 [00:00<00:00, 3606.52it/s]
Calculating metrics: 100%|##########| 1000/1000 [00:00<00:00, 2176.67it/s]681.13it/s]
Metrics for piqa: acc: 0.523#######1| 916/1000 [00:00<00:00, 2130.61it/s]
Running log-likelihood queries: 100%|##########| 2000/2000 [00:00<00:00, 3474.72it/s]val_loss=10.8, val_loss=10.8]
Calculating metrics: 100%|##########| 1000/1000 [00:00<00:00, 2334.60it/s]519.14it/s]
Metrics for piqa: acc: 0.525#######4| 947/1000 [00:00<00:00, 2349.31it/s]
Running log-likelihood queries: 100%|##########| 2000/2000 [00:00<00:00, 3312.09it/s]val_loss=10.8, val_loss=10.8]
Calculating metrics: 100%|##########| 1000/1000 [00:00<00:00, 2201.08it/s]331.68it/s]
Metrics for piqa: acc: 0.526######9 | 898/1000 [00:00<00:00, 2239.81it/s]
Running log-likelihood queries: 100%|##########| 2000/2000 [00:00<00:00, 3642.60it/s]val_loss=10.7, val_loss=10.7]
Calculating metrics: 100%|##########| 1000/1000 [00:00<00:00, 2345.68it/s]694.84it/s]
Metrics for piqa: acc: 0.525#######6| 963/1000 [00:00<00:00, 2362.52it/s]
Running log-likelihood queries: 100%|##########| 2000/2000 [00:00<00:00, 3053.03it/s]val_loss=10.7, val_loss=10.7]
Calculating metrics: 100%|##########| 1000/1000 [00:00<00:00, 2091.29it/s]171.27it/s]
Metrics for piqa: acc: 0.525######4 | 841/1000 [00:00<00:00, 2078.75it/s]
Running log-likelihood queries: 100%|##########| 2000/2000 [00:00<00:00, 3318.18it/s]val_loss=10.7, val_loss=10.7]
Calculating metrics: 100%|##########| 1000/1000 [00:00<00:00, 1988.78it/s]343.78it/s]
Metrics for piqa: acc: 0.527######5 | 853/1000 [00:00<00:00, 2010.85it/s]
Running log-likelihood queries: 100%|##########| 2000/2000 [00:00<00:00, 2954.01it/s]val_loss=10.7, val_loss=10.7]
Calculating metrics: 100%|##########| 1000/1000 [00:00<00:00, 2042.67it/s]924.83it/s]
Metrics for piqa: acc: 0.526######2 | 823/1000 [00:00<00:00, 2072.04it/s]
Running log-likelihood queries: 100%|##########| 2000/2000 [00:00<00:00, 3315.21it/s]val_loss=10.7, val_loss=10.7]
Calculating metrics: 100%|##########| 1000/1000 [00:00<00:00, 1517.85it/s]382.11it/s]
Metrics for piqa: acc: 0.528####### | 902/1000 [00:00<00:00, 1610.19it/s]
Running log-likelihood queries: 100%|##########| 2000/2000 [00:00<00:00, 3376.56it/s]val_loss=10.7, val_loss=10.7]
Calculating metrics: 100%|##########| 1000/1000 [00:00<00:00, 1880.12it/s]470.43it/s]
Metrics for piqa: acc: 0.528######6 | 867/1000 [00:00<00:00, 1832.94it/s]
Running log-likelihood queries: 100%|##########| 2000/2000 [00:00<00:00, 3098.81it/s]val_loss=10.7, val_loss=10.7]
Calculating metrics: 100%|##########| 1000/1000 [00:00<00:00, 1932.04it/s]156.69it/s]
Metrics for piqa: acc: 0.528#######7| 972/1000 [00:00<00:00, 1941.23it/s]
Training: 100%|##########| 10000/10000 [09:03<00:00, 18.39it/s, batch_loss=10.7, best_loss=10.7, val_loss=10.7]
Running log-likelihood queries: 100%|##########| 3676/3676 [00:01<00:00, 2740.37it/s]
Calculating metrics: 100%|##########| 1838/1838 [00:03<00:00, 529.14it/s]
piqa    acc     0.5146898627281189

I made the requested changes. I tested with the latest release of HF which includes their tokenizer fix here, but unfortunately this does not resolve the issue with token_type_ids and input_ids having different sequence lengths when special tokens are added. As such I improved the work around as we discussed.


Fix grpc_sockaddr_to_uri to handle embedded nulls for unix_abstract resolved addresses

Currently when an embedded null is present, it is left as is. This causes an issue when grpc_sockaddr_to_uri is followed by any c style operations like copy, as the string is truncated at the non-encoded null character. For example this is triggered when channel args containing a string channel arg is copied.
To prevent this properly encode the URI with %00.
@markdroth

Before merging, please test to see if there will be any internal changes needed for this PR.  If there are, we should do this as a cherry-pick import.

Before merging, please test to see if there will be any internal changes needed for this PR. If there are, we should do this as a cherry-pick import.

Looks like there are multiple internal changes required for this PR. I am going to work on the internal changes, but to unblock the TCP connect handshaker I am reverting the changes to grpc_sockaddr_uri and keeping only the changes needed for UDS.
I'll create a separate PR once I have the internal changes ready.

Going to just suggest adding a fuzzer that checks that this function either
returns an error or a string that our uri parser accepts as valid.
On Fri, Apr 15, 2022, 6:46 AM Anirudh Ramachandra @.***>
wrote:

Before merging, please test to see if there will be any internal changes
needed for this PR. If there are, we should do this as a cherry-pick import.
Looks like there are multiple internal changes required for this PR. I am
going to work on the internal changes, but to unblock the TCP connect
handshaker I am reverting the changes to grpc_sockaddr_uri and keeping only
the changes needed for UDS.
I'll create a separate PR once I have the internal changes ready.
—
Reply to this email directly, view it on GitHub
https://github.com/grpc/grpc/pull/29323#issuecomment-1100221184, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACNG45K3B3ITWYBDU3MSX6LVFGMPNANCNFSM5SUOX5OQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


:seedling: Bundle: samba-operator

How to create a bundle: https://kairos.io/docs/advanced/bundles/#create-bundles
Examples: https://github.com/kairos-io/community-bundles/
Relevant project: https://github.com/samba-in-kubernetes/samba-operator

Please assign me this issue. I would love to contribute.


Data tables V1

Summary
Data tables are a key component for displaying large, complex data sets. The first version of this component focusses on simply displaying the data, whilst later iterations will include functionality to allow greater interaction with the table's data.
💰 User value
Many complex applications require the ability to display large amounts of data, and a table provides a key means of visualizing it, as well as allowing comparisons of interrelated data fields.
📚 User Stories
If relevant, describe the high-level functionality as user stories.
Visual
Density
As an ICDS user
I need to be able to specify data density
So that I can see more or less data within the same size viewport.
Emphasis
As an ICDS user
I need to be able to set different emphasis on cells
So that important information can be highlighted.
Alignment
As an ICDS user
I need to be able to horizontally align cell data
So that I can make the information scannable.
As an ICDS user
I need to be able to vertically align cell data
So that I can control the appearance of the data.
Zebra stripes
As an ICDS user
I need to see every other row coloured differently,
So that it is easy to scan data across the columns in a row without confusing it with rows above and below
Line divisions
As an ICDS user
I need to be able to visually understand the separation between rows of data
So that it is clear which row I am looking at.
Truncation on large values
As an ICDS user
I need to be able to specify when cell data should truncate vs. wrap
So that long data won't cause cells to grow too big.
As an ICDS user
I need to be able to view the full data in a cell when it is truncated
So that I can understand all table data.
Interactivity
Progression/loading behaviour
As an ICDS user
I need to see an indication of data loading when the data in the table changes
So that I know how long to wait to see the new data.
Row hover
As an ICDS user
I need to see a row highlighted when hovering (or focusing on a cell)
So that I can easily see the other column values associated with that row,
And it needs to be clearly distinctive from other row highlighting such as row selection.
Navigation
Pagination
As an ICDS user
I need to be able to see data split across multiple pages
So that large data tables don't force excessive scrolling.
As an ICDS user
I need to be able to specify how many items of data can be viewed per page
So that I can control the way I look at the data.
As an ICDS user
I need to be able to switch between any page of the data table
So that I can navigate easily through the data.
As an ICDS user
I need to be able see how many pages of data exist in the table
So that I have an awareness of the size of the data set.
Accessibility
Responsiveness
As an ICDS user
I need a way to view all table data regardless of the screen size or viewport that i'm using,
So that I am equally able to access all data.
Accessibility support
As any ICDS user,
I need to be able to understand all data and perform all actions regardless of my input method and my interaction method,
So that I can equally access data.
Keyboard focus
As an ICDS user,
I need to view a focus indicator for any element that can be interacted with,
So that I know where my keyboard actions will target.
Keyboard Navigation
As a ICDS user
I need to be able to navigate through data in a table using a keyboard
So that I have equal access to its content.
📝 Acceptance Criteria
If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.
Given
When
Then
✏ Designs
If there's a Figma design file (or other mock-up), include it here.
## 🧾 Guidance
If there's written guidance or documentation, include it here.

Removing truncation functionality to be included in later user story.
Truncation on large values
As an ICDS user
I need to be able to specify when cell data should truncate vs. wrap
So that long data won't cause cells to grow too big.
As an ICDS user
I need to be able to view the full data in a cell when it is truncated
So that I can understand all table data.


[FLINK-23902][connectors/hive] Make flink support Hive 3.1.3 version

What is the purpose of the change
I modified the flink-connectors module to support hive 3.1.3 version.
Brief change log
I added a new class and modified HiveShimLoader.java .
Verifying this change
I ran the corresponding test class and didn't see any failures.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Hi, @wuchong @gaoyunhaii   Please take a look in your free time ,thank you.

@flinkbot run azure

Hi @gaoyunhaii ,Thanks for your review,I will keep trying!

Thanks @yangjf2019! Merged~


Refraction effect for diamond material?

Description
I have been trying to achieve refraction effect on the material for my diamond model and would like your expertise to help me achieve the effect as shown in the following. I would like to stick to modelviewer itself rather than using other libraries.


Create a GIF for the README

It would be nice to have a GIF showing the effect of introducing a simple command to an Arduino (e.g. the pin 13 -H - pin 13 -L explained on the README). This way, the Readme would be more visual.
The GIF must contain:

[ ] Beautiful Arduino board (e.g. from Fritzing)
[ ] Beautiful console (e.g. Arduino IDE Serial Monitor) showing:

[ ] help -> available commands
[ ] pin 13 -H -> the inboard LED turns on
[ ] pin 13 -L -> the inboard LED turns off

The GIF must be animated.

It would be nice if we could add a square box inside the gif showing the current state of the arduino board when you introduce the command. This will be even better.

@sophiekovalevsky Thank you for your comment ^.^
I don't fully understand you... What is your proposal exactly? Could you elaborate? Maybe a drawing or an example will help ;)

@guyikcgg having the screen with the shell and in some region, the real board showing what is happening :D very similar like this one: https://i.ytimg.com/vi/3EJBA5gi-xU/maxresdefault.jpg
I will work on this. So, if you can assign me this issue it would be awesome.

Great! I like it! I was thinking of an animation, but a video is cool as well :)
I assign you the issue.


Cassandra collection tests refactor

This PR refactors all Cassandra collection tests to have multiple elements in each collection for testing.
Removed boolean because sets require unique values and it's adequately covered by the other types. Not worth handling the edge case.

Now we dont test boolean types at all, that seems unfortunate.
It should be straightforward to change insert and friends to work on an arbitrarily long elements instead of hardcoding to 3.
Then we can just have boolean contain 2 values (true and false).

I pushed a commit to fix the boolean issue.
Should be good to go now.


Cannot start the Compositor

I want to use Azure Kinect to film hololens2. all is build and no erro, but cannot start the compositor. this is the window of compositor

I cannot Select the Video Source from the dropdown list . where can show the dropdown list?

You need to be running a scene containing the SpectatorView.Compositor prefab in the Editor (such as SpectatorViewCompositor) for these menus to become enabled.

Thank you, it work.


[explore] Prevent duplicated query by data table

SUMMARY
In Explore view, right now we have chart section and data table. Chart and results table are from different API response, but they actually have same query and same data frame.
In airbnb Presto queries are limited. If query engine detects same user running the same query in the multiple requests, query engine will drop the duplicated query. This will impact the explore view user: when chart is loading, if user open data table, it will send another request to query engine, but this request is actually the same query. As the result, one of query will be dropped and error returned.
This PR will try to fix this issue by delay the results table request:

When chart is still loading, if user clicks on data, Explore will show a spinner, but won't trigger new request
When chart is done loading and results panel is open, Explore will trigger 2nd request (with results=true parameter). At this moment, query's results data is cached, so the 2nd request won't reach query engine, and return cached results data to frontend. it should only take ~1 second.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: when user open results table while chart loading, Explore view sends 2 queries at the same time:

After: when user open results table while chart loading, Explore view will show spinner but not sending another request:

TEST PLAN

open explore view with a slow query
when chart is loading, open data table, just see results tab
check browser console, check how many requests running at the same time

cc @ktmud @zuzana-vej @junlincc @zhaoyongjie
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12404 (3550c21) into master (c327cb9) will increase coverage by 0.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12404      +/-   ##
==========================================
+ Coverage   62.83%   63.57%   +0.73%
==========================================
  Files        1014      485     -529
  Lines       49491    29873   -19618
  Branches     5074        0    -5074
==========================================
- Hits        31097    18991   -12106
+ Misses      18184    10882    -7302
+ Partials      210        0     -210

Flag
Coverage Δ

javascript
?

python
63.57% <ø> (-0.65%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-12.78%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/utils/celery.py
96.42% <0.00%> (-3.58%)
:arrow_down:

superset/db_engine_specs/postgres.py
82.45% <0.00%> (-3.51%)
:arrow_down:

superset/examples/world_bank.py
97.10% <0.00%> (-2.90%)
:arrow_down:

superset/examples/birth_names.py
96.51% <0.00%> (-2.33%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

... and 539 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c327cb9...3550c21. Read the comment docs.

Codecov Report

Merging #12404 (3550c21) into master (c327cb9) will increase coverage by 0.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12404      +/-   ##
==========================================
+ Coverage   62.83%   63.57%   +0.73%
==========================================
  Files        1014      485     -529
  Lines       49491    29873   -19618
  Branches     5074        0    -5074
==========================================
- Hits        31097    18991   -12106
+ Misses      18184    10882    -7302
+ Partials      210        0     -210

Flag
Coverage Δ

javascript
?

python
63.57% <ø> (-0.65%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-12.78%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/utils/celery.py
96.42% <0.00%> (-3.58%)
:arrow_down:

superset/db_engine_specs/postgres.py
82.45% <0.00%> (-3.51%)
:arrow_down:

superset/examples/world_bank.py
97.10% <0.00%> (-2.90%)
:arrow_down:

superset/examples/birth_names.py
96.51% <0.00%> (-2.33%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

... and 539 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c327cb9...3550c21. Read the comment docs.

thanks @etr2460 I think typing refactor is good idea. I will create another PR to take care it.

thanks @etr2460 I think typing refactor is good idea. I will create another PR to take care it.


Build fails with 403 Forbidden after clearing Gradle cache due to Datadog bintray dependencies

Could not GET 'https://dl.bintray.com/datadog/datadog-maven/io/realm/realm-android-library/6.0.2/realm-android-library-6.0.2.pom'. Received status code 403 from server: Forbidden
Looks like the Datadog SDK is still using jcenter() which is at end of life. Many artifacts have already been removed from bintray and moved over to Maven Central.
While I understand that Datadog itself has migrated to maven central with artifact 1.8.1 and later, that isn't the case for your dependencies. Is the migration from bintray/jcenter going to be included in the next release?

I see this commit:
https://github.com/DataDog/dd-sdk-android/commit/3d7f050d6c87178c5ba4978729aa9404a92134c2
Is it possible to get a new version of the SDK with this change?

Looks like the commit https://github.com/DataDog/dd-sdk-android/commit/3d7f050d6c87178c5ba4978729aa9404a92134c2 to fix this is in the 1.9.1 artifact. There's no indication anywhere in the repository that it's been fixed or that others will need to update if they encounter this issue.
Might be useful to put the latest version in the Readme.


Implement remaining resource CRUD methods

Methods:

create()
destroy()
index()
show()
update()

Resources:

[ ] Architecture
[ ] ComputeResource
[ ] Domain
[ ] Environment
[ ] Location
[ ] Medium
[ ] OperatingSystem
[ ] Organization
[ ] Ptable
[ ] Puppetclass
[ ] Smart_proxy

/cc @daniel-alt

requires #14


Cannot read Artist name in song/Album view in Light mode

The Artist name is in white when in light mode, white on white making it almost impossible to read it.

LOL, I keep missing stuff in light mode

I don't blame ya lol Cider was made for dark mode so converting it to Light modes gonna be tough :)


Fix some edge cases with the SecretsStore

This fixes a couple of small edge cases in the new secrets stuff. See commit messages for more details.
Fixes #98.

🐟


Avoid manual memory management

Prefer std::vector over malloc and free. This will allow removing goto
statements by leveraging RAII.
Use appropriate type (bool) to store overflow predicates and allocate
std::vector of appropriate sizes: before this change the
allocation was unnecessary bigger than required.
No longer attempt to catch "out of host memory" issues, given that in
such situation it is generally not possible to cleanly report an error.
Rely on std::bad_alloc exception to report such issues.
Introduce a new header for common code in the math_brute_force
component. It is currently complementary to utility.h and is expected to
hold cleaned up content extracted from future refactoring operations.
List all headers as source in CMake for better compatibility with IDEs.
In order to use non-POD types as fields of TestInfo, memset must be
replaced with a compatible zero-initialisation.
Remove an unnecessary memset in MakeKernels.

While this covers many points, they relates to the same code. Hence why one PR.

Check code format failed with:
git-clang-format: error: argument --binary: expected one argument

With #1261 merged, I was able to retrigger the failed checker. It looks healthy.


Fix FixedRingBuffer.removeAt

There is a problem when removing from the start index

Sounds like this might have been responsible for some obscure bugs!

I just squashed the PR.

Just discovered that GitHub now also offers this as an option for how to merge the PR, which is pretty nice for avoiding to bother the PR authors with this!


Fix the crash problem in debugDescription

I hope that debugDescription of Request with an invalid URL do not crash.
I added the guard statement so as not to crash even when the URL was invalid.

Thanks for putting this together @tokorom...much appreciated! I merged a slightly modified variation of your changes in 08cf2695 while still giving you attribution. Thanks again for putting this together! 🍻


submit(): make sure method is an str

In Python2, the method obtained from BeautifulSoup is a Unicode string,
and passing it to requests causes encoding issues when used together
with the files argument:
  File "/usr/local/lib/python2.7/dist-packages/requests-2.3.0-py2.7.egg/requests/sessions.py", line 559, in send
    r = adapter.send(request, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/requests-2.3.0-py2.7.egg/requests/adapters.py", line 327, in send
    timeout=timeout
  File "/usr/local/lib/python2.7/dist-packages/requests-2.3.0-py2.7.egg/requests/packages/urllib3/connectionpool.py", line 493, in urlopen
    body=body, headers=headers)
  File "/usr/local/lib/python2.7/dist-packages/requests-2.3.0-py2.7.egg/requests/packages/urllib3/connectionpool.py", line 291, in _make_request
    conn.request(method, url, **httplib_request_kw)
  File "/usr/lib/python2.7/httplib.py", line 1001, in request
    self._send_request(method, url, body, headers)
  File "/usr/lib/python2.7/httplib.py", line 1035, in _send_request
    self.endheaders(body)
  File "/usr/lib/python2.7/httplib.py", line 997, in endheaders
    self._send_output(message_body)
  File "/usr/lib/python2.7/httplib.py", line 848, in _send_output
    msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 842: ordinal not in range(128)

Thanks, good fix


armstrong-numbers practice exercise

I think we probably need to omit the last 2 tests (commented out for now), which use integers of 108 and 127 bits respectively: far beyond R's int32 default. Nothing I've seen on StackOverflow is encouraging, and the suggested workarounds are probably unsuitable for Exercism testing servers.
We may need @ErikSchierboom to reopen this PR.

Thanks for these PRs @colinleach! I will try and review sometime tomorrow or otherwise as soon as I find a gap 👍

The examplar solution fails on R v3.6.3 because the |> operator was only introduced in R v4.1.0, but happy to ignore this for now and maybe we should stop testing on older versions of R at some point?

Oops! I've been using |> in various exercises (after doing a bunch of F# in Functional February!), so we'll see this problem again.


Support fine-grained IAM roles for service accounts

Please support IAM roles for service accounts. Use case:
background:

jaeger running in AWS EKS with AWS ES as backend.
AWS ES domain is configured with a VPC endpoint.
To control access to AWS ES there are the following options: AWS Security Group (IP address restriction), AWS ES access policy (IAM based access control), AWS Cognito, and/or fine-grained ES access control with ES users, groups, ...

desire:

I wish to allow certain federated users (Cognito integrated with Azure AD) to connect to AWS ES from any private ip, and allow systems from a given IP range (currently VPC CIDR) to connect as well.

current problem:

Jaeger can connect to AWS ES as anonymous (AWS ES access policy set to allow all principals), but I am unable to restrict this type of access to certain IP addresses. If I update the Security Group then I stop normal users from connecting.
If I configure Jaeger to use a Service Account with the usual Irsa annotation then collector breaks.

I am aware of other previous issues that are similar, but they seemed to not take into account that only certain users/systems should be able to access AWS ES and not all that can connect via a VPC. I am unaware of how I can in an easy way configure AWS ES to support a use case where Jaeger uses certificates to connect to a AWS ES with a VPC endpoint.

In another issue it was stated that is possible to use AWS Elasticsearch as a backend but all my tests were unsuccessful (indeed on k8s with irsa).
Is there some clear documentation with the requirements to do so? Or even something that states which auth methods are supported/suggested to avoid wasting time on the others...

Hello, I am currently having issue with this also. I have jaeger deployed on EKS with Elasticsearch (OpenSearch on AWS) as backend. I configured an admission controller to use sigv4. The issue is that Jaeger won't work unless I used a username and password and pass them as secrets. (the config on OpenSearch should also have the master user type as "Internal user database" or Jaeger won't work)

having the same issue, I am guessing that the Go client they are using does not support ( naturally ) pulling the keys that aws plant when configuring service account and so the request goes out unsigned and we get a 403 response.
one way to fix it is to add support to cloud sdks but i think that will introduce some complexities that i am unsure that they will want to take.


[erc20-manifest] adding erc20 token to manifest

Adding support for Firefly-Tokens-ERC20 in manifest.json and manifestgen.sh. This is needed for ERC20 support in Firefly-CLI

Codecov Report

Merging #418 (e64d0b0) into main (f56d701) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head e64d0b0 differs from pull request most recent head e7573bb. Consider uploading reports for the commit e7573bb to get more accurate results

@@            Coverage Diff            @@
##              main      #418   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          277       277
  Lines        14858     14860    +2
=========================================
+ Hits         14858     14860    +2

Impacted Files
Coverage Δ

internal/database/sqlcommon/tokenbalance_sql.go
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f56d701...e7573bb. Read the comment docs.

Postponing until migrations in main are figured out


Dev test: molecule-shapes-basics 1.4.0-dev.1

@arouinfar, @kathy-phet, molecule-shapes-basics/1.4.0-dev.1 is ready for dev testing. Document issues in https://github.com/phetsims/molecule-shapes/issues and link to this
issue.
Assigning @kathy-phet and @KatieWoe for prioritization.

General Dev Test

What to Test

Click every single button.
If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Try to include browser version numbers
If there is a console available, check for errors and include them in the Problem Description.
Run through the string tests on at least one platform, especially if it is about to go to rc.
Check the Game Up harness on one platform.

Focus and Special Instructions
[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested,
list them here. Any behaviors you want QA to pay special attention to should be listed here.]

General Dev Test Platforms

[x] Latest macOS, Safari (Time = 1 hr)
[x] Windows 10, Chrome (Time = 1.25 hr)
[ ] Windows 10, Firefox (Time = )
[x] Latest iOS, Safari (Time = 0.75 hr )

Light testing, or optionally skip if time crunch:

[ ] Latest macOS, Chrome (Time = )
[ ] Latest Chrome OS, Chrome (Time = )

Issues to Verify

[x] webgl warning obscured by navbar

These issues should have either use the labels "status:ready-for-qa" or "status:ready-for-review." If it is ready for
QA then close the issue if fixed. If ready for review then leave open and assign back to the developer.

Link(s)

Simulation

PhET-iO Dev Test

What to Test

Make sure that public files do not have password protection. Use a private browser for this.
Make sure that private files do have password protection. Use a private browser for this.
Make sure standalone sim is working properly.
Make sure the wrapper index is working properly.
Make sure each wrapper is working properly.
Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
sure the simulation loads without crashing or throwing errors.

General Dev Test Platforms

[x] Latest macOS, Safari (Time = 2.5 hr)
[x] Latest iOS, Safari (Time = .75 hr)
[x] Windows 10 or 11, Chrome (Time = .75)
[ ] Windows 10, Firefox (Time = )
[ ] Latest Chrome OS, Chrome (Time = )

Link(s)

Wrapper Index

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

Calling QA here. https://github.com/phetsims/qa/issues/715 was more thorough, so I feel good about this as well.

Thanks!


Fix dash deployment on OpenShift, learn how to do so in the future.

Currently, a baby version of Dash Overview page is supposed to be deployed to OpenShift, with the help of Misc, but it's broken. Next steps are to fix this deployment and learn how to deploy on OpenShift in the future.

Update for today-
Misc and I had a conversation today. One of the problems that we were facing was that DockerHub was unable to serve our request for the docker image python 3.8.12-bullseye. However, we are able to use an open shift mirror of this image to circumvent this problem.
Next step: when running the Docker container locally we mount the current directory as the project directory in the container. We need to switch this because OpenShift doesn't use the scripts that we are using to run the container locally. Therefore we actually need to copy the files into the working directory.
Additionally, since our goal is for this to be pseudo-prod we ought to remove the debug settings for the Dash instance when it's up which can be done with local/deployment  environment variables

TODO:

[ ] Add augur login info as secrets


[Bug] Authorization error when signing into sites using a Google account.

Describe the bug
I'm getting an authorization error anytime I try to sign into sites using a Google account. The image shows eBay, but any site has the same problem.

How to Reproduce

Go to a site requiring a Google account to sign in (ex. ebay.com)
Put details in
Observe error

Expected behavior
It should sign in. I haven't been able to sign into things for months.
Environment
- DDG App Version: 5.164.2
- Device: Moto G7 Play
- OS: Android 10

@J0n-b0 Hi there, I can reproduce this issue if I disable privacy protection on accounts.google.com, can you check if privacy protection is enabled in the overflow menu?

UPDATE: I am now getting the same error now, regardless of whether privacy protection is enabled. I'm not sure what I'm doing wrong if it's my end.

Hey @joshliebe please double check if privacy protection is enabled. It should be the major reason for authentication error while signing using google.
Google sign in basically requires "Secure browsers policy" which can be met on DuckDuckGo browser by enabling Privacy Protection.
If the issue still persists , A detailed screenrecording or address of the site that you are trying to sign in would be of much help to reproduce the issue.
PS: I have tried signing in to ebay using google ,and i have encountered no error.


Any example working game using this template system?

Do you have any repository demonstrating a game in some working form using the layout pattern proposed by this generator - would be a nice example guide for n00bs.

Nope. At least, not an up-to-date example, I'm afraid.
Perhaps my frustrated attempt at porting Heart Star, but I modified it in so many ways, it's not the best one.

I loved the Heart Star game concept. Had a look at your version on GitHub before posting but it didn't seem to follow your generator pattern for laying out the game so much.
Gotta eat your own dog food as they say! 😄

Like I said before, it's not best or most up-to-date example. Actually, I'm cheating a little here, because this game project began months before slush-phaser-plus, but I extracted the template game project (that became phaser-plus-template) a few days later.
Meanwhile, the game project was updated several times, for improvements on the game as well the project structure, sharing code from the master template, but stopped eventually. That project and all stuff that came after this are somehow related. Many ideas, good and bad, came from this project (and also from several other scrapped game projects too).
I have a few ideas for a demo game, but there is no priority for such a project at the moment, not before I finish some more demanding tasks at least.


DaynaPORT Issues With MacTCP

Info

Which version of Pi are you using: Pi 4 Model B
Which github revision of software: v23.04.01
Which board version: akuker 2.5
Which computer is the PiSCSI connected to: Mac Quadra 700

Describe the issue
I'd like to start by saying that the PiSCSI is absolutely awesome! By far the best SCSI drive replacement that I've ever had, so great job to everyone who has helped make this possible!
Unfortunately, I've been having some problems with getting the DaynaPORT emulation to work with MacTCP. I'm using a Quadra 700, so I can run Open Transport (with DHCP) as well and that works perfectly, but MacTCP just doesn't. I've configured everything according to the steps on the DaynaPORT wiki page, but I always just get timeout errors in MacTCP Ping whenever I try to ping <IP_ADDRESS>. Running "ip addr show" and "brctl show" on the Pi gives the same results shown on the wiki page too, so I'm pretty sure I have everything configured properly on the PiSCSI end of things. I've tried MacTCP with the PiSCSI on several different machines (including an SE) and encounter this same problem every time, so it doesn't seem to have anything to do with the specific computer either. What could be going on here?
The reason why I need MacTCP instead of just using Open Transport is because the eventual goal is to get this thing working with MacWorks Plus on the Apple Lisa, which can't run Open Transport thanks to its 68000 processor. I'm just trying to get a proof of concept working on the Quadra 700 before trying anything on the Lisa itself since the Quadra is WAY faster and easier to transfer files to than the Lisa.
Thanks for the help!
Alex

@alexthecat123 Thank you for the kind words! We're doing our best to deliver a useful tool for old SCSI equipped computers.
So yes, it is notoriously tricky to get MacTCP to play ball with a modern network. It's a moody beast. From the network configuration, it seems like you're trying to connect to a LAN where a DHCP server controls the IP assignments, correct? Can you please share how you have configured MacTCP on the Quadra?
Also, if you haven't done so already, please read through all the steps and troubleshooting advice on our wiki: https://github.com/PiSCSI/piscsi/wiki/Dayna-Port-SCSI-Link

Thanks for the response! Yeah, MacTCP can be a real pain to deal with sometimes!
Yep, that's exactly right about my network; it's a LAN with a DHCP server for IP address assignment. It just sucks that DHCP doesn't work in MacTCP because that would probably make things way easier!
I've read that wiki page probably at least 25 times now and I've tried everything that it suggests. MacTCP is configured exactly the way that it specifies with an IP of <IP_ADDRESS>, the router IP of <IP_ADDRESS>, a subnet mask of <IP_ADDRESS>, and the Google DNS server. But I still get the timeout error in MacTCP Ping.
And I apologize in advance if the problem ends up being something really stupid that I've overlooked; networking is BY FAR my weakest area of knowledge in computing and I know very little about it!
Here are some photos showing the exact network configuration that's being used on the Quadra!

@alexthecat123 I can see the problem here immediately. You need to configure MacTCP with IP / subnet / router addresses that align with the address ranges of your router. Looking at your wired network interface, that means in the <IP_ADDRESS>~254 range (netmask of 24).
The pitfalls here are that 1) assigning static IPs in a DHCP managed network can lead to duplicate assignment of IP addresses, and 2) the router may reject connections from MacTCP altogether. I've had mixed results myself. You may want to consider putting up a separate router just for your vintage network that is lenient with this kind of configuration.
An alternative is to set up NAT for your bridge, which isolates it from the rest of your LAN and enable you to use whatever status IP address ranges that you want. But with the drawback that you can't reach the rest of your LAN from MacTCP.
I suggest you try the former approach first! You may be lucky and have it just work for you.

Thanks so much for the help! That makes a lot of sense; I was wondering why the wiki listed those 10.10.20.X IP addresses, but I guess those were specific to the author's router!
Unfortunately, the first approach didn't work for me. I changed the gateway to <IP_ADDRESS> and the Quadra's IP to <IP_ADDRESS> and then went into the router and reserved that IP for the DaynaPORT's MAC address, but no luck. So I guess I just have one of those routers that doesn't like MacTCP?
Although this does seem a little strange because MacTCP works fine with my router when I use a NuBus ethernet card, but not with the PiSCSI. Could that offer any clues as to what's going on?
This means that I'm probably stuck with the NAT option for now. Sorry if this is a dumb question, but could you tell me how to set up NAT for the bridge? Like I said, I know very little about networking stuff!
Thanks again for all of the help!

Thanks so much for the help! That makes a lot of sense; I was wondering why the wiki listed those 10.10.20.X IP addresses, but I guess those were specific to the author's router!

No, the 10.10.20.X range is just what I arbitrarily chose as the default for the NATed network configuration... I thought I was explicit about those being example IPs that have to be adjusted for your environment! Earlier today I made a few edits that hopefully reduce the chance of misunderstanding, but please help pointing me to any ambiguous statements in the wiki. I most certainly have blind spots!

Unfortunately, the first approach didn't work for me. I changed the gateway to <IP_ADDRESS> and the Quadra's IP to <IP_ADDRESS> and then went into the router and reserved that IP for the DaynaPORT's MAC address, but no luck. So I guess I just have one of those routers that doesn't like MacTCP?
Although this does seem a little strange because MacTCP works fine with my router when I use a NuBus ethernet card, but not with the PiSCSI. Could that offer any clues as to what's going on?

Have you run the Dayna diagnostics apps to make sure that the hardware and drivers are working correctly on your system?

This means that I'm probably stuck with the NAT option for now. Sorry if this is a dumb question, but could you tell me how to set up NAT for the bridge? Like I said, I know very little about networking stuff!
Thanks again for all of the help!

Sure! It should just be a matter of following the wiki instructions.
First revert the "wired" network bridge settings, i.e. deleting piscsi_bridge and removing the line in dhcpcd.conf as described in https://github.com/PiSCSI/piscsi/wiki/Dayna-Port-SCSI-Link#wired-raspberry-pi-setup
Then, follow the steps for the NAT configuration, but substitute wlan0 with whatever your wired network interface is called: https://github.com/PiSCSI/piscsi/wiki/Dayna-Port-SCSI-Link#wireless-raspberry-pi-setup

Have you run the Dayna diagnostics apps to make sure that the hardware and drivers are working correctly on your system?

I have and the hardware seems to be working properly!
Thanks for the NAT instructions! Unfortunately, after following your instructions I now get the error message "Configure the network bridge for eth0 first: /etc/dhcpcd.conf, /etc/network/interfaces.d/piscsi_bridge" whenever I try to attach an ethernet adapter. What should I do to get around this?

@rdmark What is going to happen with this ticket? Is this actually something the requires changes/fixes in PiSCSI?

@alexthecat123 Sorry for leaving you hanging there! The workaround there is to use the scsictl command line tool to attach the DP device. We have validation on the Web UI side to prevent incomplete network bridge configuration. But looking at your case, I think I will change that validation to a warning instead of error.
Please let me know if you are still available to keep troubleshooting this, and I can give you a few commands to try!

This PR will make the Web UI more lenient about attaching networking devices when it can't detect the "normal" bridge settings. https://github.com/PiSCSI/piscsi/pull/1319

@rdmark I'm pretty busy with college right now, but I'll try to make time for troubleshooting soon. You can go ahead and send me the commands and I'll try them out next time I get the chance!

@benjamink I haven't tried that yet, but I'll give it a shot as soon as I can!

Hi! I'm silvano from italy. I have an issue with my Powerbook 520c which runs system 7.5. I've been able to run the BlueSCSI pico wifi model but I can't have an internet connection. From OpenTrasnport 1.3 menu I've been selected Alternate ethernet and DHCP server. When I try to use an internet browser such as icab, an error appears.There's no Internet connection. this is the log file:
Platform: BlueSCSI Pico
FW Version: 2023.11.16-release Nov 17 2023 03:26:27
Flash chip size: 2048 kB
=== SD Card Info ===
SD card detected, FAT32 volume size: 30436 MB
SD Name: SD32G, MID: 0x03, OID: 0x53 0x44
=== Global Config ===
Reading configuration from bluescsi.ini
Active configuration:
=== Finding images in / ===
== Opening /NE4.hda for ID: 4 LUN: 0
---- Configuring as network based on image name
---- Image ready
== Opening /HD10_512 PowerBook 520c 240MB.hda for ID: 1 LUN: 0
---- Image ready
=== ROM Drive ===
Platform supports ROM drive up to 1692 kB
---- Activating ROM drive, SCSI id 0 size 1692 kB
---- WARNING: This image does not appear to be a valid Macintosh Device image. See: https://github.com/BlueSCSI/BlueSCSI-v2/wiki/Disk-Images
---- Activated ROM drive, SCSI id 0 size 1692 kB
=== Configured SCSI Devices ===

ID: 0, BlockSize: 512, Type: Fixed, Quirks: Apple, Size: 1692kB
ID: 1, BlockSize: 512, Type: Fixed, Quirks: Apple, Size: 245824kB
ID: 4, Type: Network, Quirks: Apple

=== Network Initialization ===
Wi-Fi MAC: 00:80:19:07:E3:38
Connecting to Wi-Fi SSID "" with no authentication
Wi-Fi connection failed: -4
Initialization complete!
INFO: Pico Voltage: 3.276V.
Someone can help me please???
thankyou!


Android Basics: LiveData

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-livedata?authuser=1&continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-3-pathway-3%3Fauthuser%3D1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-livedata#9
In which task and step of the codelab can this issue be found?
Use LiveData with ViewModel - setp 10 Test Unscramble app with Talkback enabled - substep 7
Describe the problem
No scrambled words were displayed after the change in substep 7
I think getter was missing and I fixed it by adding "get()" in the instruction:
val currentScrambledWord: LiveData get()= Transformations.map(_currentScrambledWord) {
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

@cScocco
Thank you for reaching out to us.
get() in the above code snippet is optional. In both cases, the code behaves the same way.


Use appropriate option set for FBSimulatorAllocationOptionsEraseOnFree

This was previously using the wrong option set.

@facebook-github-bot shipit


Dependency error for simple app

First of all, react-presents is cool.
I am trying with simple presentation (code below), and getting func of undefined error.
Could you share any suggestion? Thanks.
TypeError: Cannot read property 'func' of undefined
./node_modules/react-codemirror/lib/Codemirror.js
node_modules/react-codemirror/lib/Codemirror.js:11
   8 | displayName: 'CodeMirror',
   9 |
  10 | propTypes: {
> 11 | 	onChange: React.PropTypes.func,
  12 | 	onFocusChange: React.PropTypes.func,
  13 | 	options: React.PropTypes.object,
  14 | 	path: React.PropTypes.string,

import React from 'react'
import { Presentation, Slide, DropDownNav } from 'react-presents'
import MySlide from './MySlide'

const slides = [MySlide, MySlide];

const options = slides
  .map((slide, index) => ({
    label: slide.title,
    value: index
  }))
  .filter((option) => option.label)

export default () => (
  <Presentation>
    {slides.map((Component, index) => (
      <Slide
        component={Component}
        key={index}
      />
    )).concat(
      <DropDownNav
        key='DropDownNav'
        options={options}
      />
    )}
  </Presentation>
)

The error you're seeing is because react deprecated React.PropTypes in version 15.5 and removed them entirely in version 16.0. There is now a new, standalone prop-types module. You can read more about that decision here.
The error you've reported is coming from a dependency of react-presents (and not react-presents itself). The dependency in question is react-codemirror (as your error message shows):

TypeError: Cannot read property 'func' of undefined
./node_modules/react-codemirror/lib/Codemirror.js
node_modules/react-codemirror/lib/Codemirror.js

Currently, react-presents depends on react-codemirror version ^0.2.6. It looks like there's a version 1.0.0 release. Based on the peer dependency it declares, it will warn about not being react@16 compatible (see the warning below) but it does use the prop-types package so it would fix the specific issue you reported.

warning<EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS><16".
warning<EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS><16".
warning<EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^15.0.0-0".

Based on issue JedWatson/react-codemirror/issues/126, it looks like scniro/react-codemirror2 might be a drop-in replacement that's 16 compatible. I'm hesitant to make that switch though.
I've release an update to react-presents, version 0.7.10, that bumps the react-codemirror dependency to version 1.0.0. Based on my own quick testing with<EMAIL_ADDRESS>it should resolve your issue. 👍

Many thanks @bvaughn for releasing new update very quickly 👍

@bvaughn @isuhendro I'd encourage you to migrate to react-codemirror2. Jes'd react-codemirror seems long abandoned with a plethora of issues and many users frustrated. I wrote react-codemirror2 as a successor and plan to actively maintain it moving forward.

@scniro if you'd like to create a PR that does the upgrade, and it seems to be a drop-in replacement, I'll review and consider. I don't think react-presents currently suffers from any of the unresolved react-codemirror issues though (other than lack of official v16 support).


Add rule group priority and support

Ref

https://nanopay.atlassian.net/browse/NP-2648
https://nanopay.atlassian.net/browse/NP-3382

Changes

Add rule group priority and support
Configure spidCapability rule group priority
Cleanup rule SPID enforcement as it was replaced by permissioned rule

@nick-prat @nanoMichal @penzital @jlhughes @kgrgreer please review when you have a chance, thanks.


Prompt to continue build after viewing PKGBUILD

:: View vim-pathogen PKGBUILD? [Y/n]
:: vim-pathogen PKGBUILD viewed
:: Checking vim-pathogen integrity...

pacaur doesn't prompt whether I want to continue with the build after reading the PKGBUILD. It continues with the build process as soon as you view the PKGBUILD.
Shouldn't the default behavior be prompting you as to whether to continue with the installation  since the PKGBUILD could be bad?
What I think should actually happen
Unpacking objects: 100% (4/4), done.
:: View vim-pathogen PKGBUILD? [Y/n]
:: Continue? [Y/n]
:: vim-pathogen PKGBUILD viewed
:: Checking vim-pathogen integrity...

Am I missing something? I mean, yes you can ^C but I think this should be default behavior? Not sure how everyone else thinks about this.

See #472.


Upgrade to crossterm 0.25.0 w/ breaking changes

Upgrade to crossterm 0.25.0 https://docs.rs/crossterm/0.25.0/src/crossterm/event.rs.html which changes KeyEvent and a lot of other things.

Once fixed, cut a new breaking release of

r3bl_rs_utils (public, macro, and core)
and r3bl-cmdr
Also start creating git tags for each release on each repo from now on.

The following commits fix this:

c778bac653cacb9e1405425ece23f5edbd2a558b
r3bl-org/r3bl-cmdr@8f1d00a7583f279eb9efbf2b43f622bcdc7cedb3


Implemented Kaomoji menu

Hello! So I saw this plugin after installing Powercord and I really liked using this. I thought that it would be cool if you could choose which Kaomoji you would like to send based on the category so I forked the repo and implemented it, though the code might be a bit messy because I don't have much experience with the API and IntelliSense isn't working properly for some reason haha.
Heres a demo of it in action:

Thank you for adding this!
Code looks clean to me 😄


Add more use cases

Codecov Report

Merging #292 (7515f7d) into master (6821cdc) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master     #292      +/-   ##
============================================
- Coverage     52.76%   52.75%   -0.02%
- Complexity      757      758       +1
============================================
  Files           141      141
  Lines          3487     3490       +3
  Branches        499      500       +1
============================================
+ Hits           1840     1841       +1
- Misses         1500     1501       +1
- Partials        147      148       +1

Impacted Files
Coverage Δ

...s/logic/commands/schedule/ViewScheduleCommand.java
76.47% <0.00%> (-10.20%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
77.31% <100.00%> (+0.19%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[API]: auth api may use inline user id.

https://twittercommunity.com/t/why-the-api-which-need-oauth-1-0a-user-context-still-need-provide-the-id-for-auth-user/153159

When do authorize or initial by access token, we can get user id.  So we can keep user id with a private variable.


Js cli

Base deku-cli programs for Deku-P and Deku-C. Unfortunately it took me a while to have Deku-C version running so it's very incomplete right now, but I'll update it in parallel of testing Deku-C.

FYI, when the file already exists, I get this:
npx deku-cli generate-identity -o wallet.json
node:internal/process/promises:279
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "File already exists".] {
  code: 'ERR_UNHANDLED_REJECTION'


HTML Output is not well displayed: outline_alignment_miss, outline_jaggy_segments, outline_short_segments

Observed behaviour
HTML Output is not well displayed:
FontBakeryCheck:com.google.fonts/check/outline_alignment_miss
FontBakeryCheck:com.google.fonts/check/outline_jaggy_segments
FontBakeryCheck:com.google.fonts/check/outline_short_segments
Expected behaviour
It should look like:
FontBakeryCheck:com.google.fonts/check/outline_semi_vertical
Resources and exact process needed to replicate
Here a screenshot for reference:

The screenshot above is the result of the changes at PR #3692


feat: ✨ Angular: Allow two way data binding component wrappers

Pull Request
📖 Description
This PR provides a change for the angular wrappers that make form values work with two way data binding.
🎫 Issues
Closes #397
👩💻 Reviewer Notes

I updated the current angular (dev) dependencies on @synergy-design-system/angular and the angular demo to the latest version.
I opted to move parts of the vue and angular build scripts that where copied over to the shared.js build utilities to lessen code duplication.
After talking to the stakeholder it came apperant that we only need this for the input value fields and not for all attributes.

📑 Test Plan

Check out this branch and build world.
Move to packages/_private/angular-demo and exchange the code for the home component to the snippets defined below.
Start the angular demo and type text into the input field or change the checkbox or select values. You should see immediate updates appearing.

Code for home/home.component.ts:
import { Component } from '@angular/core';

@Component({
  selector: 'home',
  styleUrls: ['./home.styles.css'],
  templateUrl: './home.component.html',
})
export class Home {
  inputValue: string = 'Type something';
  checkboxValue: boolean = false;
  selectValue: string = 'option1';

  setInputValue(value: string) {
    this.inputValue = value;
  }

  log(...args: unknown[]) {
    console.log(...args);
  }
}

Code for home/home.component.html:
<h1>
  Welcome to the Synergy Angular Demo!
</h1>

<syn-input [(value)]="inputValue" placeholder="Type something"></syn-input>
<syn-checkbox [(checked)]="checkboxValue">Check me!</syn-checkbox>

<syn-button (click)="setInputValue('Something')">Click me!</syn-button>

<syn-select [(value)]="selectValue">
  <syn-option value="option1">Here</syn-option>
  <syn-option value="option2">there</syn-option>
</syn-select>

<syn-divider></syn-divider>

{{ inputValue }}

{{ checkboxValue }}

{{ selectValue }}

<syn-divider></syn-divider>

✅ DoD

[x] I have tested my changes manually.
[ ] I have added automatic tests for my changes (unit- and visual regression tests).
[x] I have updated the project documentation to reflect my changes (e.g. CHANGELOG, Storybook, ...).
[x] I have made sure to follow the projects coding and contribution guides.
[x] I have made sure that the bundle size has changed appropriately.
[x] I have validated that there are no accessibility errors.
[ ] I have used design tokens instead of fix css values

Wrong branch naming :(. Reopend at https://github.com/synergy-design-system/synergy-design-system/pull/420


Consistently avoid pulling on the source return type when the target return type is any

Fixes #47108

@typescript-bot perf test this

@typescript-bot perf test this

As you note in the issue discussion, this is a breaking change.

Looking at it more, I don’t quite understand where the circularity is or why either of those signatures should have different widening behavior from
declare function f<S>(fn: () => S): S;
f(() => 0); // S -> number

Maybe it’s worth investigating the additional change you mentioned, or if that too is very breaky, maybe this isn’t worth fixing right now?

So, as far as the additional change goes, It's technically breaky because we no longer return literal types in some locations, but it's not that breaky, because those are locations where other information isn't present to indicate that we need to return literal types. As to weather to take it or just this - we should take one or both, because that'll make us consistent; weather we take the additional change or not is just weather we'd prefer to return base types in the affected cases (as with the additional change linked in the issue)  or literal types (as in this PR).

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt


token limit exceeded but have 10M tokens

Describe the bug
I keep running into an issue where the token limit exceeds 199999 but the project just started and only completed a few prompts. Also it persists even when writing a very short prompt. I purchased the $20/month subscription so I should have 10M tokens.
Link to the Bolt URL that caused the error
https://bolt.new/~/bolt-nextjs-shadcn-bu9p8p
Steps to reproduce
Write any prompt
Expected behavior
To do something
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 76204603,
  "usedJSHeapSize": 74962007,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = Ego4sho
Chat ID = b0de7e5ddb44

Additional context
No response

@Ego4sho thanks for the report! We are tracking this (and the temp workarounds) in #1322


self_managed_node_group /etc/eks/bootstrap.sh eks  script giving error that --b64-cluster-ca: command not found

Description
I am trying to deploy an EKS self_managed_node_group cluster and install some services using pre_bootstrap_user_data but some pre-defined commands are causing the installation to fail.
This is my self managed node group config:
provider "aws" {
  region = local.region
}

provider "kubernetes" {
  host                   = module.eks.cluster_endpoint
  cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data)

  exec {
    api_version = "client.authentication.k8s.io/v1beta1"
    command     = "aws"
    # This requires the awscli to be installed locally where Terraform is executed
    args = ["eks", "get-token", "--cluster-name", module.eks.cluster_name]
  }
}

data "aws_caller_identity" "current" {}
data "aws_availability_zones" "available" {}

locals {
  name            = "eks"
  cluster_version = "1.26"
  region          = "eu-west-1" # NEEDS TO BE CHANGED

  app-node-group = "app"

  vpc_id = "vpc-XXXX"   # NEEDS TO BE CHANGED
  existing_k8s_route_table = "rtb-XXXX"  # NEEDS TO BE CHANGED

  tags = {
    cluster-name    = local.name

    "k8s.io/cluster-autoscaler/${local.name}" = "owned"
    "k8s.io/cluster-autoscaler/enabled" = true
  }
}

################################################################################
# EKS Module
################################################################################

module "eks" {
  source = "../.."

  cluster_name                   = local.name
  cluster_version                = local.cluster_version
  cluster_endpoint_public_access = true
  cluster_endpoint_private_access = true

  cluster_addons = {
    coredns = {
      resolve_conflicts = "OVERWRITE"
    }
    kube-proxy = {
      most_recent = true
    }
    vpc-cni = {
      resolve_conflicts = "OVERWRITE"
    }
  }

  cluster_encryption_policy_name = "eks-secret"
  cluster_encryption_config = {  # NEEDS TO BE CHANGED
    resources        = ["secrets"]
  }

  vpc_id                   = local.vpc_id
  subnet_ids = ["subnet-XXXX", "subnet-XXXXX"]

  # Self managed node groups will not automatically create the aws-auth configmap so we need to
  create_aws_auth_configmap = true
  manage_aws_auth_configmap = true

  self_managed_node_group_defaults = {
    # enable discovery of autoscaling groups by cluster-autoscaler
    autoscaling_group_tags = {
      "k8s.io/cluster-autoscaler/enabled" : true,
      "k8s.io/cluster-autoscaler/${local.name}" : "owned",
    }
  }

  self_managed_node_groups = {

  "${local.app-node-group}-node" = {

      ###########
      ### EC2 ###
      ###########
      name                          = local.app-node-group
      ami_id                        = "ami-0608033dd04759ae5"  # NEEDS TO BE CHANGED
      instance_type                 = "t3.medium" # NEEDS TO BE CHANGED
      block_device_mappings = {
        xvda = {
          device_name = "/dev/xvda"
          ebs = {
            delete_on_termination = true
            encrypted             = true
            volume_size           = 50
            volume_type           = "gp3"
            kms_key_id            = aws_kms_key.ebs.arn
          }

        }
      }

      use_name_prefix               = false
      enable_monitoring             = true
      metadata_options = {
        http_endpoint               = "enabled"
        http_tokens                 = "required"
        http_put_response_hop_limit = 2
        instance_metadata_tags      = "disabled"
      }

      ####################
      ### SSH Key Pair ###
      ####################
      key_name              = "XXXXXXXX"  # NEEDS TO BE CHANGED

      #####################
      #### BOOTSTRAPING ###
      #####################
      bootstrap_extra_args = <<-EOT
      --kubelet-extra-args '--max-pods=50 --node-labels=apps=true'
      EOT

      pre_bootstrap_user_data = <<-EOT
      export CONTAINER_RUNTIME="containerd"
      export USE_MAX_PODS=true
      EOT

      post_bootstrap_user_data = <<-EOT
      sudo yum install -y htop
      wget https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.26.0/crictl-v1.26.0-linux-amd64.tar.gz
      tar zxvf crictl-v1.26.0-linux-amd64.tar.gz -C /usr/bin/

      EOT

      #################################
      ### AUTO SCALING GROUP CONFIG ###
      #################################
      min_size     = 1
      max_size     = 4
      desired_size = 1

      ##############################################
      ### LAUNCH TEMPLATE FOR AUTO SCALING GROUP ###
      ##############################################
      launch_template_name            = "${local.app-node-group}-lt"
      launch_template_use_name_prefix = true
      launch_template_description     = "${local.app-node-group} self managed node group launch template"

      ebs_optimized          = true
      vpc_security_group_ids = ["sg-XXXXX"]   # NEEDS TO BE CHANGED

      #############
      ###  IAM  ###
      #############
      create_iam_role          = true   # NEEDS TO BE CHANGED
      iam_role_name            = "${local.app-node-group}-eu-west-1"
      iam_role_use_name_prefix = false
      iam_role_description     = "${local.app-node-group} self managed node group role"
      iam_role_tags = {
        Purpose = "${local.app-node-group} protector of the kubelet"
      }
      iam_role_additional_policies = {
        AmazonEC2ContainerRegistryReadOnly = "arn:aws:iam::aws:policy/AmazonEC2ContainerRegistryReadOnly",
        AmazonSSMManagedInstanceCore = "arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore",
        AmazonSSMPatchAssociation = "arn:aws:iam::aws:policy/AmazonSSMPatchAssociation",
        additional = aws_iam_policy.additional.arn
      }

      #################
      ###  NETWORK  ###
      #################
      subnet_ids = ["subnet-XXXXX"]
      create_security_group          = true
      security_group_name            = "${local.app-node-group}-sg"
      security_group_use_name_prefix = false
      security_group_description     = "${local.app-node-group} security group"
      security_group_rules = {

        nginx_ingress_port_1 = {
          description = "nginx ingress port. allow api server to call nginx ingress"
          protocol    = "tcp"
          from_port   = 8443
          to_port     = 8443
          type        = "ingress"
          source_cluster_security_group = true # it will add master sg as source
        }
        nginx_ingress_port_2 = {
          description = "nginx ingress port. allow api server to call nginx ingress"
          protocol    = "tcp"
          from_port   = 10254
          to_port     = 10254
          type        = "ingress"
          source_cluster_security_group = true # it will add master sg as source
        }
        additonal = {
          from_port = 22
          to_port   = 22
          protocol  = "tcp"
          type        = "ingress"
          cidr_blocks = [
            "<IP_ADDRESS>/8",
            "<IP_ADDRESS>/12",
            "<IP_ADDRESS>/16",
          ]
        }
      }
      security_group_tags = {
        Purpose = "${local.app-node-group} protector of the kubelet"
      }

      #################
      ### TIMEOUTS ####
      #################
      timeouts = {
        create = "80m"
        update = "80m"
        delete = "80m"
      }

      #############
      ### TAGS ####
      #############
      tags = {
        type = "production"
        node-type = local.app-node-group
      }
    }
  }
}

################################################################################
# Supporting Resources
################################################################################

resource "tls_private_key" "this" {
  algorithm = "RSA"
}

resource "aws_key_pair" "this" {
  key_name   = local.name
  public_key = tls_private_key.this.public_key_openssh
}

resource "aws_kms_key" "ebs" {
  description             = "Customer managed key to encrypt self managed node group volumes"
  deletion_window_in_days = 30
  policy                  = data.aws_iam_policy_document.ebs.json
  enable_key_rotation     = false
}

resource "aws_kms_alias" "cluster_nodegroup_ebs_volume_ecncryption" {
  name          = "alias/${local.name}-cluster-nodegroup-ebs-volume-ecncryption"
  target_key_id = aws_kms_key.ebs.arn
}

# This policy is required for the KMS key used for EKS root volumes, so the cluster is allowed to enc/dec/attach encrypted EBS volumes
data "aws_iam_policy_document" "ebs" {
  # Copy of default KMS policy that lets you manage it
  statement {
    sid       = "Enable IAM User Permissions"
    actions   = ["kms:*"]
    resources = ["*"]

    principals {
      type        = "AWS"
      identifiers = ["arn:aws:iam::${data.aws_caller_identity.current.account_id}:root"]
    }
  }

  # Required for EKS
  statement {
    sid = "Allow service-linked role use of the CMK"
    actions = [
      "kms:Encrypt",
      "kms:Decrypt",
      "kms:ReEncrypt*",
      "kms:GenerateDataKey*",
      "kms:DescribeKey"
    ]
    resources = ["*"]

    principals {
      type = "AWS"
      identifiers = [
        "arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/aws-service-role/autoscaling.amazonaws.com/AWSServiceRoleForAutoScaling", # required for the ASG to manage encrypted volumes for nodes
        module.eks.cluster_iam_role_arn,                                                                                # required for the cluster / persistentvolume-controller to create encrypted PVCs
      ]
    }
  }

  statement {
    sid       = "Allow attachment of persistent resources"
    actions   = ["kms:CreateGrant"]
    resources = ["*"]

    principals {
      type = "AWS"
      identifiers = [
        "arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/aws-service-role/autoscaling.amazonaws.com/AWSServiceRoleForAutoScaling", # required for the ASG to manage encrypted volumes for nodes
        module.eks.cluster_iam_role_arn,                                                                                # required for the cluster / persistentvolume-controller to create encrypted PVCs
      ]
    }

    condition {
      test     = "Bool"
      variable = "kms:GrantIsForAWSResource"
      values   = ["true"]
    }
  }
}

resource "aws_iam_policy" "additional" {
  name        = "${local.name}-additional"
  description = "Example usage of node additional policy"

  policy = jsonencode({
    Version = "2012-10-17"
    Statement = [
      {
        Action = [
          "ec2:Describe*",
        ]
        Effect   = "Allow"
        Resource = "*"
      },
    ]
  })

  tags = local.tags
}

I used the above manifest to provision the cluster. Once the cluster was provisioned, I checked the nodes to see if the utilities were installed. I found out they were not.
I checked the cloud init logs and found out this
# cloud init logs
/var/log/cloud-init-output.log

Logs:
Slice=runtime.slice
‘/etc/eks/containerd/containerd-config.toml’ -> ‘/etc/containerd/config.toml’
‘/etc/eks/containerd/sandbox-image.service’ -> ‘/etc/systemd/system/sandbox-image.service’
‘/etc/eks/containerd/kubelet-containerd.service’ -> ‘/etc/systemd/system/kubelet.service’
Created symlink from /etc/systemd/system/multi-user.target.wants/kubelet.service to /etc/systemd/system/kubelet.service.
2023-05-29T12:29:51+0000 [eks-bootstrap] INFO: complete!
/var/lib/cloud/instance/scripts/part-001: line 23: --b64-cluster-ca: command not found
May 29 12:29:51 cloud-init[2415]: util.py[WARNING]: Failed running /var/lib/cloud/instance/scripts/part-001 [127]
May 29 12:29:51 cloud-init[2415]: cc_scripts_user.py[WARNING]: Failed to run module scripts-user (scripts in /var/lib/cloud/instance/scripts)
May 29 12:29:51 cloud-init[2415]: util.py[WARNING]: Running module scripts-user (<module 'cloudinit.config.cc_scripts_user' from '/usr/lib/python2.7/site-packages/cloudinit/config/cc_scripts_user.pyc'>) failed
Cloud-init v. 19.3-46.amzn2 finished at Mon, 29 May 2023 12:29:51 +0000. Datasource DataSourceEc2.  Up 47.47 seconds

The content of the /var/lib/cloud/instance/scripts/part-001
#!/bin/bash
set -e
export CONTAINER_RUNTIME="containerd"
export USE_MAX_PODS=true

B64_CLUSTER_CA=XXXXXXXXX
API_SERVER_URL=XXXXXXXXX
/etc/eks/bootstrap.sh eks --kubelet-extra-args '--max-pods=50 --node-labels=apps=true'
 --b64-cluster-ca $B64_CLUSTER_CA --apiserver-endpoint $API_SERVER_URL

sudo yum install -y htop
wget https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.26.0/crictl-v1.26.0-linux-amd64.tar.gz
tar zxvf crictl-v1.26.0-linux-amd64.tar.gz -C /usr/bin/

[x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]:
v19.15.0
Terraform version:
Terraform v1.4.6

Provider version(s):

provider registry.terraform.io/hashicorp/aws v4.67.0
provider registry.terraform.io/hashicorp/cloudinit v2.3.2
provider registry.terraform.io/hashicorp/kubernetes v2.20.0
provider registry.terraform.io/hashicorp/time v0.9.1
provider registry.terraform.io/hashicorp/tls v4.0.4
Reproduction Code [Required]

Using the manifests given above provision an EKS Cluster. Once the nodes are available check the nodes if the utilities are installed.
Steps to reproduce the behavior:

Expected behavior
A user should be able to install services using the user data script.

Actual behavior
The user data scripts fail due to the following reason:
/var/lib/cloud/instance/scripts/part-001: line 23: --b64-cluster-ca: command not found

Because of the above issues the rest of the commands don't run.

Terminal Output Screenshot(s)
Already provided

Additional context

Your bootstrap_extra_args setting is inserting a newline at the end due to the use of the Heredoc String:
bootstrap_extra_args = <<-EOT
--kubelet-extra-args '--max-pods=50 --node-labels=apps=true'
EOT

You can see the use of this setting in the template file here: https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/templates/linux_user_data.tpl#L12
To fix this, I'd recommend using a simple string. i.e.:
bootstrap_extra_args = "--kubelet-extra-args '--max-pods=50 --node-labels=apps=true'"

Alternately, you could use trimspace or chomp functions to remove the offending newline character. e.g.:
bootstrap_extra_args = chomp(
<<-EOT
--kubelet-extra-args '--max-pods=50 --node-labels=apps=true'
EOT
)

see comments above; we also have examples that demonstrate how to pass in custom/additional user data - this does not appear to be a module issue so I am closing it out for now

thank you @bdalpe and @bryantbiggs


chore: deprecate vulnerable dependencies for surfer

Removes dependencies on unmaintained react-scripts package. Replaces react-scripts with vite/vitest.

Hello @marcinwysocki -- this Pull Request is being directed to you as a Contentful Marketplace App owner
This PR removes your apps dependence on react-scripts in favor of vite (and vitest). This is done in service of removing security vulnerabilities. You may see other nested dependencies updated as well, like typescript or emotion/css, as these libraries were required for react-scripts and often pinned to stale or deprecated versions. While the PR is complete, we’d like your help as the owner of the app, to confirm that no bugs or regressions have been introduced with these updates.
Required Action:
Please review this PR, and QA your app with these changes. If all functionality remains safely intact, please just reply with a "LGTM" (or more) and we’ll merge the PR and release these changes.
If you do discover issues as a result of these changes, please open a new PR against this branch with fixes once identified.
Please plan to complete this action within 30 days.
Sincerely,
The Contentful Ecosystem Team

thank you for taking a look @marcinwysocki !


Bug: after creating a new issue, window is not closed and whole app needs to be closed

Expected Behavior
After creating a new task, the new task window should disappear.
Actual Behavior
The new task window stays there and is not closable. The whole Chronos app needs to be restarted after that, which makes new issue creation unusable. Fully reproducable.
Steps to Reproduce the Problem

Create new issue
Window keeps displayed and is not closable

Specifications

Chronos-timetracker version: 2.5.11
OS: Windows 10

@feldifux Could you confirm that it works now?

Works perfect now, thanks!


fix: Not here page displayed in the background after a refresh

Details

Fixed Issues

$  https://github.com/Expensify/App/issues/46774
PROPOSAL:  https://github.com/Expensify/App/issues/46774#issuecomment-2268326185
Tests

Click on FAB
Click on submit expense
Refresh the page
Verify that: everything works as normal

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Click on FAB
Click on submit expense
Refresh the page
Verify that: everything works as normal

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/c11b2f9d-c1f2-41fe-9418-fdb4e35129d5

Android: mWeb Chrome

https://github.com/user-attachments/assets/2d2d6976-7f4d-4b01-93a3-2d7eecbf15f8

iOS: Native

https://github.com/user-attachments/assets/fecacd29-a97d-48f7-96e5-e8cba868eb09

iOS: mWeb Safari

https://github.com/user-attachments/assets/66837352-924f-44c7-b827-8a02e9626226

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/7b8793d5-7947-435b-a727-769bcf968450

MacOS: Desktop

https://github.com/user-attachments/assets/7ee6a62f-285a-412c-8084-ae30a87ca09d

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.21-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
failure ❌

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Enhancements to apache and php-fpm

Please see the commit below for the following enhancements to the LAMP stack:

Moved mod_proxy_fcgi to be managed by puppet.
Configured php-fpm to use unix socket, since apache and php-fpm are running on the same box.
Added combined log format.
Changed MPM module to event
Moved custom config mod_ssl_fix to a new apache class parameter ssl_file.
Added other generally used used apache modules.
Added directories and pool config to support the use of php-fpm socket.
Fixed syntax found by puppet-lint.

Please let me know your thoughts and if you have and questions or recommendations!
Respectfully,
Jake

Nice work and thank you!

@thespain - take a look at the extras between this PR and the new release when you get a chance. Some things in there that did not show up in your test that you might want to remember.


Add Resizing functionality

Resizing interpolation should be configurable.

Closing issue, merged "resizing" branch. Feature is now implemented.


Typo in publish function: PUBLISH_PRE_SCRIPTS

https://github.com/BigRoy/launch_scripts/blob/main/launch_scripts/module.py#L136
PUBLISH_PRE_SCRIPTS need to replace with PUBLISH_POST_SCRIPTS

Thanks, fixed the typo.


Support nested templates to create nested routes

It seems like we are currently not supporting to have nested directories in the templates themselves. This should be supported. It's a blocker for @craigsdennis' PR in the function-templates repository.
This command should work but is currently failing because both the functions and assets directory include an admin/ directory
TWILIO_SERVERLESS_TEMPLATE_REPO="craigsdennis/function-templates" twilio serverless:init craig-voice --template="voice-client-javascript"

@dkundel Do you have any feedback I can work through while we wait for the bug fix?


even better defaults

Codecov Report

Merging #442 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   97.12%   97.12%
=======================================
  Files          33       33
  Lines        2054     2054
  Branches      151      151
=======================================
  Hits         1995     1995
  Misses         37       37
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 064bf47...9c8eede. Read the comment docs.


[incubator/selenium] first stab at a selenium chart

There's some documentation missing, from the readme and values. I'm interested to learn if anything else is missing.

This is an great addition @flah00!


make dropdown required

the empty dropdown option doesn't trigger the required flag/prompt

I can't follow. Can you please elaborate a little bit? A code snippet would be helpful as well.

@jelhan I believe he's saying that @required is not supported like it is in the base ember-bootstrap form elements. I just encountered the same in a project of my own

@required argument of <form.element> has been deprecated in Ember Bootstrap v3 and is removed in v4. It was only used to set the required HTML attribute on an <input> or <textarea> form control.
Ember Power Select does not support something similar. It does not have a @required argument nor uses a HTML tag, which supports required attribute. So I wouldn't be sure what this should do at all.


Bug: Cannot start service curl: network services:gluetun not found

Cannot use the gluetun service in same docker file according to the documents.

Is this urgent?

[x] Yes
[ ] No

What VPN service provider are you using?

[x] PIA
[ ] Mullvad
[ ] Windscribe
[ ] Surfshark
[ ] Cyberghost

What's the version of the program?
See the line at the top of your logs
gluetun    | Running version latest built on 2020-07-17T01:17:21Z (commit fab9939)

What are you using to run the container?

[ ] Docker run
[x] Docker Compose
[ ] Kubernetes
[ ] Docker stack
[ ] Docker swarm
[ ] Podman
[ ] Other:

Extra information

✅ docker run with network works
docker run --rm --network=container:gluetun alpine:3.12 wget -qO- "https://ifconfig.co/ip"
XX.XXX.XXX.XX

✅ container:gluetun works from another file
# save as curl.yml and run using this command
# docker-compose -f curl.yml up

version: "3.7"
services:
  curl:
    image: byrnedo/alpine-curl
    command: /usr/bin/curl -s "http://ifconfig.co/ip"
    network_mode: container:gluetun

❌ using same compose file fails.
version: "3.7"
services:

  gluetun:
    image: qmcgaw/private-internet-access
    container_name: gluetun
    cap_add:
      - NET_ADMIN
    devices:
      - "/dev/net/tun"
    ports:
      - 8000:8000/tcp
    environment:
      - VPNSP=private internet access
      - USER=${USER}
      - PASSWORD=${PASSWORD}
      - REGION=Singapore
    restart: always

  curl:
    image: byrnedo/alpine-curl
    command: /usr/bin/curl -s "http://ifconfig.co/ip"
    network_mode: services:gluetun

Log:
➜  docker-compose up
ERROR: for curl  Cannot start service curl: network services:gluetun not found
ERROR: Encountered errors while bringing up the project.

❌ Setting network_mode on gluetun service does not work
    network_mode: bridge

Host OS:  Ubuntu 20.04 LTS

Doesn't this look like a typo? 🤦
service:gluetun

It happens to the best of us 😄  Glad you figured it out though, I would probably spent quite some time to find it as well haha