chore(enable sonarlint deprecation rule + fixes)

This enables several eslint rules (listed below) along with their fixes.
Notably, we replace the json() method with either a raw object, or the data() helper, as recommended by Remix, in preparation for Single Fetch.

enable deprecation, no-alphabetical-sort sonarjs eslint rules, replace waitForNavigation with waitForURL
replace all instances of json() with data() where applicable, plain objects otherwise

it seems that there are issues with appending the accepted/refused cookie's header... from what I can tell, this seems to be some issue with remix's implementation of the data() helper.


Moved management console snapshot into a separate table in release notes

Created a distinct snapshot table per request from @vikafed. @vikafed is this OK?

Looks good, @stuclem. Thanks.


Add persistent notification for failed login attempts (http)

Description:
This PR adds a persistent notification if a login attempt with an invalid password happens. The failed attempts are logged as warnings in the log file and displayed on the "About" page but users may miss that. In a normal use case the notification may only show up very rarely but if an attack is taking place the notification will show up right after the user dismiss it.
Related issue (if applicable): fixes https://community.home-assistant.io/t/ip-security-logs/4277
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for configuration.yaml (if applicable):
http:
  api_password: YOUR_PASSWORD

Checklist:
If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] Tests have been added to verify that the new code works.

🐬  -> let's bring it into 0.30

Can you add an option to disable these notifications. (enabled by default)

Actually, it's fine without.

Is there a way to see this as an event that we can use to trigger an automation (for mobile notifications)?

Nevermind.  Didn't realize there was an entity created.

Since 0.38.2, this is not logged anymore. Is this on purpose?
Can I somehow enable it? I was using the persistant notifications in an automation

Please do not use old pull requests to report issues.


Decorate code in html report

fixes #402

Codecov Report
Patch coverage has no change and project coverage change: -0.06% :warning:

Comparison is base (0325ec1) 87.28% compared to head (c6eceb7) 87.22%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
- Coverage   87.28%   87.22%   -0.06%
==========================================
  Files         141      141
  Lines        1526     1527       +1
  Branches      252      254       +2
==========================================
  Hits         1332     1332
- Misses        194      195       +1

Files Changed
Coverage Δ

...a/com/sksamuel/scapegoat/io/HtmlReportWriter.scala
0.00% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

The check failure doesn't seem related. I guess we have some kind of infra regression.

The check failure doesn't seem related. I guess we have some kind of infra regression.

 [error]  import scala.xml.{Elem, Unparsed, XML}
[error] +
[error]  import com.sksamuel.scapegoat.{Feedback, Levels}

I think it is complaining about a missing whiteline?

@Johnnei thanks for pointing that out!


[otbn] Evaluate performing blanking calculation on negative edge

One solution to https://github.com/lowRISC/opentitan/issues/7883 is to use negative edge clocking. Pre-decode would occur in the first half of a cycle and the rest of execution in the second half of the cycle.
Run some synthesis trials to determine the feasibility of this. E.g. try synthesizing the current OTBN core to run at 250 MHz

estimate 2

Thanks to @msfschaffner for running the synthesis. As expected we cannot come close to meeting timing at 250 MHz however I do note that for the worst path, which goes through the base register file, the enable signal for the read it generated roughly half way through. Looking at the top few paths they all go through the read enable for the base RF, so presumably the address for the base RF is appearing earlier (otherwise it would also be in the top few paths).
There is significant logic to generate the enable/address: imem read delay -> scrambling -> decode -> some controller stuff -> enable/address, perhaps it is possible to clock the result here on the negative edge with the actual calculation side (i.e. from address to register file onwards through the ALU/MAC to register write) occurring in the second half of the clock cycle.
I also note the longest paths all involve indirect register access, as you might expect, read from base to determine bignum address, then read from bignum. To implement blanking here I think we'd end up adding in a stall cycle anyway (as you'd need to flop the output of the base register file to use as a read address for bignum the following cycle) so those paths wouldn't exist any more giving us some more timing slack to play with.
Some further experiments here may be warranted. An easy one would be to remove the indirect register address functionality and see what we get. A more involved one would be to do a mock-up of the clock decode signals on negative edge and run a synthesis trial on that. I'll put together something former as it's quick and easy RTL wise then @msfschaffner can rerun the 250 MHz trial on it when he has time to do so.

btw @GregAC , given the results you see here, do you still think this path is worth pursuing vs the prefetch idea you originally had?
It sounds like you see some light at the end of the tunnel? or am I misunderstanding?

With the light potentially being a train :-)

very possible :)
On Thu, Sep 30, 2021 at 10:12 AM Philipp Wagner @.***>
wrote:

With the light potentially being a train :-)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/7889#issuecomment-931510095,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSXEBTJVPZTDBIFCZLLUESLA5ANCNFSM5CUVPJWA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Follow up work to be covered by #8500


Adds events/batch/singular

Adds Singular Batcher which treat all events as the same event key. Subscribers provide a function when subscribing which will be executed once the batch triggers.
Used by https://github.com/dapr/components-contrib/pull/3363

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.95%. Comparing base (9e733a3) to head (fa869e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   79.76%   79.95%   +0.18%
==========================================
  Files          55       56       +1
  Lines        4339     4365      +26
==========================================
+ Hits         3461     3490      +29
+ Misses        732      730       -2
+ Partials      146      145       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


HIVE-26341: Replication logs & metrics shows last repl id as 0 when number of events is zero

Prior to this patch, whenever there are no events to load, lastReplId in RM is shown as 0 which is not corresponding to repl.last.id of the target database.

Post this patch, lastReplId is in sync with repl.last.id of target db. Below is the sample run for same scenario where lastReplId is correctly updated.

LGTM +1 pending tests.


Problem with connecting to port when using Steam connection?

Hey there!
I have a problem with the plugin. When I'm using the steam connection with the Create Advanced Session, and then in-game start 'Host', it loads the map only for a split second and then it kicks me out back to menu. It seems like I have some problem with SteamSocket? Do not really know how to fix that although was searching all over internet and could not found solution. I tried enabling SteamSocket plugin in unreal but it throws similiar error.

Not an issue with the plugin itself, you are running into an engine misconfiguration likely, also chances are good it is this fairly common mistake in setting up your configs.
https://answers.unrealengine.com/questions/305216/steamsockets-binding-to-port-7777-failed.html


Mac OS 10.10: does not work with Docker Toolbox 1.8.1.c

mvn docker:build results in error 'Exception caught: java.nio.file.NoSuchFileException: /Users//.boot2docker/certs/boot2docker-vm/ca.pem'. Tested on 0.3.3 build.

Sorry for the late reply @EvgeniGordeev but are you still having this issue? What does the DOCKER_CERT_PATH environment variable look like?

@mattnworb Tested on latest 1.9.0d docker-toolbox and it works successfully.
I identified two issues that are related to docker toolbox that seem to be helpful or even useful to add to README:

after uninstalling boot2docker remove DOCKER_ variables from ~/.bash_profile
execute eval "$(docker-machine env default)" before working with the docker plugin


Improving object detection colab

fixing the 4th example by removing the count and the parsing that was depending on Gemini's output
Adding a comment about lowering the safety features (to be discussed if it works without lowering the safety features)
Simplifying the Open vocabulary object detection part

Left some review feedback - mostly little nits but there are a couple of licensing questions we need to answer too.

Done for the references to Gemini. I will think of structured output, it's a good idea.

View entire conversation on ReviewNB

Do you have an example for that? I haven't changed this part of the code but I agree we should do it right...

View entire conversation on ReviewNB

Fixed

View entire conversation on ReviewNB

I have absolutely no idea who it is, so I guess I'll have to change the pictures.

View entire conversation on ReviewNB

Fixed

View entire conversation on ReviewNB

Not sure what it entails to be honest. I'll talk to you directly about that.

View entire conversation on ReviewNB

Fixed

View entire conversation on ReviewNB

For the structured output, since this PR is already complicated, I propose to do it in a second one if that's ok with you.

View entire conversation on ReviewNB

Replaced with a new picture from wikipedia.

View entire conversation on ReviewNB

do it in a second one if that's ok with you. yeah for sure - sorry, I was just thinking out loud!

View entire conversation on ReviewNB

It may be sufficient to just include the copyright line from that Drive URL at the top of our file but I'll send an email to people who can  answer with authority. I'll CC you.

View entire conversation on ReviewNB

I updated the outputs. It should be better now.

View entire conversation on ReviewNB


Issue - Installing CF CLI on Ubuntu as windows subsystem For Linux

Hi All,
I am using a windows 10 operating system. I have recently installed ubuntu 20.04.1 Linux Distribution as s Windows system for Linux. After this I am trying to install cf cli to push apps into SAP Cloud platform. I am facing the below list of issues.
To install the cf CLI on Debian and Ubuntu-based Linux distributions:

Add the Cloud Foundry Foundation public key and package repository to your system by running:
wget --no-check-certificate -v -O - https://packages.cloudfoundry.org/debian/cli.cloudfoundry.org.key | sudo apt-key add - echo "deb https://packages.cloudfoundry.org/debian stable main" | sudo tee /etc/apt/sources.list.d/cloudfoundry-cli.list

Results from console:
trinity@L-156205032:~$ wget --no-check-certificate -v -O - https://packages.cloudfoundry.org/debian/cli.cloudfoundry.org.key | sudo apt-key add - echo "deb https://packages.cloudfoundry.org/debian stable main" | sudo tee /etc/apt/sources.list.d/cloudfoundry-cli.list
--2020-12-16 17:21:32--  https://packages.cloudfoundry.org/debian/cli.cloudfoundry.org.key
Resolving packages.cloudfoundry.org (packages.cloudfoundry.org)... [sudo] password for trinity: [sudo] password for trinity: <IP_ADDRESS>, <IP_ADDRESS>
Connecting to packages.cloudfoundry.org (packages.cloudfoundry.org)|<IP_ADDRESS>|:443... connected.
WARNING: cannot verify packages.cloudfoundry.org's certificate, issued by ‘CN=proxy.wipro.com (t)\ ,OU=CIO,O=Wipro Ltd,ST=Karnataka,L=Bangalore,C=IN’:
Unable to locally verify the issuer's authority.
HTTP request sent, awaiting response... 200 OK
Length: 3963 (3.9K) [text/plain]
Saving to: ‘STDOUT’

                                    100%[=====================================================================================>]   3.87K  --.-KB/s    in 0s

2020-12-16 17:21:35 (78.6 MB/s) - written to stdout [3963/3963]

Update your local package index by running:

sudo apt-get update
Results from console:
trinity@L-156205032:~$ sudo apt-get update
Hit:1 http://archive.ubuntu.com/ubuntu focal InRelease
Get:2 http://archive.ubuntu.com/ubuntu focal-updates InRelease [114 kB]
Get:3 http://security.ubuntu.com/ubuntu focal-security InRelease [109 kB]
Get:4 http://archive.ubuntu.com/ubuntu focal-backports InRelease [101 kB]
Fetched 324 kB in 23s (14.0 kB/s)
Reading package lists... Done

To install cf CLI v7, run:

sudo apt-get install cf7-cli
Results from console:
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package cf7-cli
Need help here.

There are two commands that you need to use to 1.) make ubutntu trust the key for the repo and 2.) save the repo details into a file so that ubuntu knows to check in there for packages.
The output from the commands in your case makes it appear that it has only run the first of the commands and ignored the second one.
The wget and the echo should be pasted into your terminal as separate lines.. not a single one.
1.) wget -q -O - https://packages.cloudfoundry.org/debian/cli.cloudfoundry.org.key | sudo apt-key add -
2.) echo "deb https://packages.cloudfoundry.org/debian stable main" | sudo tee /etc/apt/sources.list.d/cloudfoundry-cli.list
After you've done that, you should find that an 'apt-get update' will list the CF package source in addition to the ubuntu ones.

Thank you for your submission. If you still run into this issue with the latest CLI v8, please open a new ticket with the necessary information mentioned in our issue template.


Text search whitespace

Trying to click a button can lead to somewhat unpredictable behavior;
Example 1:

    click here to proceed

Example 2
click here to proceed

click (text "click here to proceed")

The above F# will error out for example 1, but work fine for example 2; I assume because of the whitespace around the text within the anchor tag.

Yes this is a problem.
There are a few ways around it but first let me point out that you can do
click "click here to proceed"
instead of
click (text "click here to proceed")
The second one may be marginally faster if the website you are testing is VERY fast.  Use whichever is your preference =).
To get around it you can:
Have the website you are testing minimize the html, this will make html written as Example 1 one be sent to the client as Example 2
You can format your HTML like Example 2
You can add a finder like this
https://github.com/lefthandedgoat/canopy/blob/master/tests/basictests/Program.fs#L736-L742
Please note that you will need to write click "click here to proceed" for that to work.
This code should work but is untested.
let findByWhiteSpaceFriendlyText text f =
    try
        f(By.XPath(sprintf """.//*[normalize-space() = "%s"]""" text)) |> List.ofSeq
    with | _ -> []

addFinder findByWhiteSpaceFriendlyText

Hope this helps.


Broken 9.0.4

I tired the new executable on mybinder:
https://github.com/jan-janssen/abinit-example
jovyan@jupyter-jan-2djanssen-2dabinit-2dexample-2dhfi8h2ns:~$ abinit < Al.files
  ABINIT 9.0.4

 DeprecationWarning:

     The files file has been deprecated in Abinit9 and will be removed in Abinit10.
     Use the syntax `abinit t01.abi` where t01.abi is an input with pseudopotenials.

            pseudos = "al.psp8, as.psp8"

  Give name for formatted input file:
Al.in
  Give name for formatted output file:
Al.txt
  Give root name for generic input files:
Ali
  Give root name for generic output files:
Alo
  Give root name for generic temporary files:
Al.abinit

--- !COMMENT
src_file: m_dtfil.F90
src_line: 1454
message: |
    Output file: Al.txt already exists.
...

--- !COMMENT
src_file: m_dtfil.F90
src_line: 1478
message: |
    Renaming old: Al.txt to: Al.txt0001
...

.Version 9.0.4 of ABINIT
.(MPI version, prepared for a x86_64_linux_gnu7.5 computer)

.Copyright (C) 1998-2020 ABINIT group .
 ABINIT comes with ABSOLUTELY NO WARRANTY.
 It is free software, and you are welcome to redistribute it
 under certain conditions (GNU General Public License,
 see ~abinit/COPYING or http://www.gnu.org/copyleft/gpl.txt).

 ABINIT is a project of the Universite Catholique de Louvain,
 Corning Inc. and other collaborators, see ~abinit/doc/developers/contributors.txt .
 Please read https://docs.abinit.org/theory/acknowledgments for suggested
 acknowledgments of the ABINIT effort.
 For more information, see https://www.abinit.org .

.Starting date : Fri  5 Jun 2020.
- ( at 08h48 )

 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

 === Build Information ===
  Version       : 9.0.4
  Build target  : x86_64_linux_gnu7.5
  Build date    : 20200605

 === Compiler Suite ===
  C compiler       : gnu
  C++ compiler     : gnu7.5
  Fortran compiler : gnu7.5
  CFLAGS           : -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protect ...
  CXXFLAGS         : -fvisibility-inlines-hidden -std=c++17 -fmessage-length=0 -march=no ...
  FCFLAGS          : -g -ffree-line-length-none
  FC_LDFLAGS       :

 === Optimizations ===
  Debug level        : @abi_debug_flavor@
  Optimization level : @abi_optim_flavor@
  Architecture       : intel_xeon

 === Multicore ===
  Parallel build : yes
  Parallel I/O   : yes
  openMP support :
  GPU support    :

 === Connectors / Fallbacks ===
  LINALG flavor  : netlib
  FFT flavor     : goedecker
  HDF5           : yes
  NetCDF         : yes
  NetCDF Fortran : yes
  LibXC          : yes
  Wannier90      : no

 === Experimental features ===
  Exports             :
  GW double-precision :

 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 Default optimizations:
   -O2 -mtune=native -march=native

 Optimizations for 43_ptgroups:
   -O0

 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 CPP options activated during the build:

Program received signal SIGILL: Illegal instruction.

Backtrace for this error:
#0  0x7f9c83c6ff1f in ???
#1  0x5612bc16dc59 in __m_cppopts_dumper_MOD_dump_cpp_options
        at /home/conda/feedstock_root/build_artifacts/abinit_1591339120750/work/shared/common/src/14_hidewrite/m_cppopts_dumper.F90:79
#2  0x5612bae47e9e in abinit
        at /home/conda/feedstock_root/build_artifacts/abinit_1591339120750/work/src/98_main/abinit.F90:255
#3  0x5612bae50b69 in main
        at /home/conda/feedstock_root/build_artifacts/abinit_1591339120750/work/src/98_main/abinit.F90:89
Illegal instruction (core dumped)

same observation... under ubuntu 18.04
fresh miniconda3 ( 4.8.2 )
abinit -b

 DATA TYPE INFORMATION:
 REAL:      Data type name: REAL(DP)
            Kind value:      8
            Precision:      15
            Smallest nonnegligible quantity relative to 1: 0.22204460E-015
            Smallest positive number:                      0.22250739E-307
            Largest representable number:                  0.17976931E+309
 INTEGER:   Data type name: INTEGER(default)
            Kind value: 4
            Bit size:   32
            Largest representable number:<PHONE_NUMBER>
 LOGICAL:   Data type name: LOGICAL
            Kind value: 4
 CHARACTER: Data type name: CHARACTER             Kind value: 1
  ==== Using MPI-2 specifications ====
  MPI-IO support is ON
  xmpi_tag_ub ................    268435455
  xmpi_bsize_ch ..............            1
  xmpi_bsize_int .............            4
  xmpi_bsize_sp ..............            4
  xmpi_bsize_dp ..............            8
  xmpi_bsize_spc .............            8
  xmpi_bsize_dpc .............           16
  xmpio_bsize_frm ............            4
  xmpi_address_kind ..........            8
  xmpi_offset_kind ...........            8

Program received signal SIGILL: Illegal instruction.

Backtrace for this error:
#0  0x7f816f1dbf1f in ???
#1  0x55ccca53eb9f in __m_xmpi_MOD_xmpi_show_info
	at /home/conda/feedstock_root/build_artifacts/abinit_1591339120750/work/shared/common/src/12_hide_mpi/m_xmpi.F90:985
#2  0x55ccc91f84be in __m_argparse_MOD_args_parser
	at /home/conda/feedstock_root/build_artifacts/abinit_1591339120750/work/src/95_drive/m_argparse.F90:168
#3  0x55ccc91ebb66 in abinit
	at /home/conda/feedstock_root/build_artifacts/abinit_1591339120750/work/src/98_main/abinit.F90:207
#4  0x55ccc91f4b69 in main
	at /home/conda/feedstock_root/build_artifacts/abinit_1591339120750/work/src/98_main/abinit.F90:89
Illegal instruction (core dumped)

Do you think it is related to:
 Default optimizations:
   -O2 -mtune=native -march=native

Which should be:
 Default optimizations:
   -O2 -march=nocona -mtune=haswell

Or is it something related to the CPP options?

by defaut :

CFLAGS  : -g -O2 -mtune=native -march=native
FCFLAGS :-g -O2 -ffree-line-length-none -mtune=native -march=native

but some bots have, there are some extra options :

FCFLAGS_EXTRA="-O3 -finit-real=nan"
FCFLAGS_EXTRA="-O2 -g -Wall -Wno-maybe-uninitialized -ffpe-trap=invalid,zero,overflow -fbacktrace -pedantic -fcheck=all"
FCFLAGS_EXTRA="-g -ffree-line-length-none -fno-frontend-optimize -O2 -g -Wall -Wno-maybe-uninitialized -fbacktrace -pedantic -fcheck=all"

If I understand the conda build system correctly, they achieve the transferability of the binaries by enforcing -march=nocona -mtune=haswell that is why I try to overwrite it in the build script. Still I am confused that the executable reports -mtune=native -march=native

but default, optimization is "standard" :
--with-optim-flavor="standard"
and you can find  the settings in   config/optim/fc_gnu_default-optim.conf

I see in the report of   "abinit -b" in "pipelines" :
CFLAGS           : -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protect ...
CXXFLAGS       : -fvisibility-inlines-hidden -std=c++17 -fmessage-length=0 -march=no ...
FCFLAGS          : -g -ffree-line-length-none
FC_LDFLAGS    :

nothing in FCFLAGS because you use FFLAGS : right ?

The new build works fine for me:
conda install abinit=9.0.4=hb9875ca_2
By default conda should choose this latest version.

👍


I have some questions about training

I'm very sorry to bother you.If the provided training code is suitable for training the reconstruction of a class of objects rather than a single shape fitting?Because when I train with single object data,dataset.py doesn't work（Perhaps 500w sampling points per model is too much？）.In addition,There are also some small questions I hope can be answered.Thank you!
1.When I use dataset.py to train a single shape object, I find that batch_size 512 mentioned in the supplementray does not work very well.Is this the optimal training batch_size?
2.In addition,Can I ask the reconstructed CD distance for a single object?Because the average CD distance of the model I trained is about 0.0x.That's orders of magnitude less than the 3.55 in the paper.
I look forward to hearing from you.Thank you!

Thank you very much for your answer！But,I'm sorry to bother you again.Can I ask about the code for training a single object?If so,I would really appreciate it!

We only sorted and archived the code and results on shapenet. #5
Currently, you need to modify codes based on this repo for singgle shape fitting. Referring to the description in the paper, I expect it will not be very complicated.
I plan to release the code and results on Thingi32 when it is convenient in the future. But unfortunately, I am busy with other projects now...

Ok, Thank you for your reply！


CardHeader API docs missing children prop

The CardHeader API docs seem to be missing the children prop.

That's probably because the CardHeader doesn't have a children prop. 😄
(PS. Please use the issue template. Thanks!)

Ok, then the confusing part to me is the disableTypography docs which refers to the "children". In light of your response, I guess that refers to avatar, title, and subheader?
Thanks, I'll use the template the next time.

Hmm, yes, that is a little confusing. It does indeed refer to to the title and subheader, which are children of the root element (a div by default), but not supplied by the children prop.
Feel free to submit a PR to improve the wording.


Only able to open 1 channel without re-starting program

Can open a new channel just fine (slick new interface, btw), but when trying to open ANOTHER channel, the "next" button at the bottom of the "open a channel" window is greyed out. After exiting the program and re-starting, it works fine and is able to establish another channel, but again, only 1.

Zap version: 0.4.0-beta
Operating System and version: up to date windows 10, connecting to an LND instance running on ubuntu 12

Thanks for reporting. I was able to reproduce this one too.


Tradebot crashes on Poloniex - JSON parsing

Note: this is the technical bug tracker, please use other platforms for getting support and starting a (non technical) discussion. See the getting help page for details.
I'm submitting a ...
[x ] bug report
[ ] question about the decisions made in the repository
Action taken (what you did)

Set a trading against Poloniex (BTC-VTC) with basic strategy and warming period .
Run a trading bot from UI.

Expected result (what you hoped would happen)
The trading should have started after warming period.
Actual result (unexpected outcome)
Gekko crashes immidieatelly or after short time period with the error:
Poloniex Unexpected end of JSON input
uncaughtException SyntaxError: Unexpected end of JSON input
at JSON.parse ()
at IncomingMessage. (/gekko/exchange/node_modules/gekko-broker-poloniex/poloniex.js:106:23)
at IncomingMessage.emit (events.js:185:15)
at endReadableNT (_stream_readable.js:1106:12)
at process._tickCallback (internal/process/next_tick.js:178:19)
RECEIVED ERROR IN GEKKO INSTANCE 2018-10-09-18-42-tradebot-0126835764625013
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)

watcher or paper trading works well

Tested on:

Gekko v0.6.6 and Gekko UI v0.2.3.
 Could you manually click this link (from the same IP) and let me know if you get a cloudflare screen:
https://poloniex.com/public?command=returnTicker
I'm quite sure this is your problem, as such I am closing as a dup of #1106. As to a fix: run Gekko from another IP or contact Poloniex to lift the ban. Do let me know if that's not your problem and I'll reopen.

Ok, I clicked on the hyperlink and as the result I got this page:

Gekko paper trader or the importer of data works fine.

Strange, that's a different issue than.

Did your error happen once? Or is it happening constantly? If you can reproduce it, how long does it take to show up again?

No. I tried to run tradebot several times. It failed three times immediately after start and after the fourth attempt it started work. Here is the log from last run (I deleted portfolio and balace values) :
2018-10-09-18-42-tradebot-0126835764625013.log

Would you mind replacing the file
"gekko/exchange/node_modules/gekko-broker-poloniex/poloniex.js" with this
one: https://gist.github.com/askmike/73f114e716d959dd3b40d55e9d23cba1
The only thing I changed is I added this logging so we can see what output
polo is sending you:
https://gist.github.com/askmike/73f114e716d959dd3b40d55e9d23cba1#file-poloniex-js-L108
And let me know the response.
On Wed, Oct 10, 2018 at 3:14 PM Barrin<EMAIL_ADDRESS>wrote:

No. I tried to run tradebot several times. It failed three times
immediately after start and after the fourth attempt it started work. Here
is the log from last run (I deleted portfolio and balace values) :
2018-10-09-18-42-tradebot-0126835764625013.log
https://github.com/askmike/gekko/files/2463502/2018-10-09-18-42-tradebot-0126835764625013.log
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/askmike/gekko/issues/2587#issuecomment-428463617, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA7MD6u-16Zl1vkyrZwM98R-MbPvatciks5ujZ5tgaJpZM4XT7ZS
.

--
PGP key at keybase.io/mikevanrossum
https://keybase.io/mikevanrossum/key.asc

OK, it's really strange.  I started the tradebot 3 hours ago and it looks, that it is running well. I'll give it more time, but it seems, that I am not only one, who have this kind of problem: #2588

I replaced the file "gekko/exchange/node_modules/gekko-broker-poloniex/poloniex.js" with this one: https://gist.github.com/askmike/73f114e716d959dd3b40d55e9d23cba1
I have gotten a new error.
2018-10-10 17:20:49 (INFO):	Starting to watch the market: Poloniex XRP/BTC
ERROR: Failed to tick in time, see https://github.com/askmike/gekko/issues/514 for details

So the tradebot is still running, but there is another problem. Trades in UI are doubled, and points in the graph do not match trend line.

Are you running the latest version?
On Thu, 11 Oct 2018, 14:56 Barrin<EMAIL_ADDRESS>wrote:

So the tradebot is still running, but there is another problem. Trades in
UI are doubled, and points in the graph do not match trend line.
[image: screen]
https://user-images.githubusercontent.com/2727775/46785902-7d0f9700-cd33-11e8-90a8-627717132b0f.png
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/askmike/gekko/issues/2587#issuecomment-428842416, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA7MD-U81ydHNHO845n2NGKqlO0wBmmHks5ujuuagaJpZM4XT7ZS
.

Gekko v0.6.6
It is clone from stable branch made 3 days ago.

I have caught the error, and I have a log.
Please, see the attached file. I hope this information will help you to understand what is wrong.
gekko.log

Re: this error - Trades in UI are doubled -
I see this all the time using Chrome. I eventually worked out to just re-load the page and that gets rid of all the duplicate entries! :)

New error. Last deal had an issue.

/      \ /        |/  |  /  |/  |  /  | /
/$$$$$$  |$$$$$$$$/ $$ | /$$/ $$ | /$$/ /$$$$$$  |
$$ | $$/ $$ |_    $$ |/$$/  $$ |/$$/  $$ |  $$ |
$$ |/    |$$    |   $$  $$<   $$  $$<   $$ |  $$ |
$$ |$$$$ |$$$$$/    $$$$$  \  $$$$$  \  $$ |  $$ |
$$ _$$ |$$ |_____ $$ |$$  \ $$ |$$  \ $$ _$$ |
$$    $$/ $$       |$$ | $$  |$$ | $$  |$$    $$/
$$$$$$/  $$$$$$$$/ $$/   $$/ $$/   $$/  $$$$$$/
Gekko v0.6.6
I'm gonna make you rich, Bud Fox.

2018-10-20 04:55:22 (INFO):	Setting up Gekko in realtime mode
2018-10-20 04:55:22 (INFO):
2018-10-20 04:55:22 (INFO):	Setting up:
2018-10-20 04:55:22 (INFO):		 Candle writer
2018-10-20 04:55:22 (INFO):		 Store candles in a database
2018-10-20 04:55:22 (INFO):
2018-10-20 04:55:22 (INFO):	Setting up:
2018-10-20 04:55:22 (INFO):		 Trading Advisor
2018-10-20 04:55:22 (INFO):		 Calculate trading advice
2018-10-20 04:55:22 (INFO):		 Using the strategy: neuralnet_v2
2018-10-20 04:55:23 (INFO):		The trading method requests 1000 minutes of historic data. Checking availablity..
2018-10-20 04:55:23 (INFO):
2018-10-20 04:55:23 (INFO):		Usable local data available, trying to match with exchange data..
2018-10-20 04:55:23 (INFO):		Preventing Gekko from requesting 752 minutes of history.
2018-10-20 04:55:24 (INFO):		Not seeding locally available data to the trading method.
2018-10-20 04:55:24 (INFO):		The exchange does not return enough data. 0 minutes are still missing.
2018-10-20 04:55:24 (INFO):	Setting up:
2018-10-20 04:55:24 (INFO):		 Trader
2018-10-20 04:55:24 (INFO):		 Follows the advice and create real orders.
2018-10-20 04:55:24 (INFO):
2018-10-20 04:55:30 (INFO):		 Portfolio:
2018-10-20 04:55:30 (INFO):			 0.00031776 BTC
2018-10-20 04:55:30 (INFO):			 0 XRP
2018-10-20 04:55:30 (INFO):		 Balance:
2018-10-20 04:55:30 (INFO):			 0.00031776 BTC
2018-10-20 04:55:30 (INFO):		 Exposed:
2018-10-20 04:55:30 (INFO):			 no (0.00%)
2018-10-20 04:55:30 (INFO):	Setting up:
2018-10-20 04:55:30 (INFO):		 Performance Analyzer
2018-10-20 04:55:30 (INFO):		 Analyzes performances of trades
2018-10-20 04:55:30 (INFO):
2018-10-20 04:55:30 (INFO):	Starting to watch the market: Poloniex XRP/BTC
2018-10-23 10:04:31 (INFO):	Trader Received advice to go long. Buying  XRP
2018-10-23 10:05:19 (INFO):	[ORDER] partial buy fill, total filled: 4.37559066
2018-10-23 10:05:21 (INFO):	[ORDER] summary: { price: 0.00006891,
amount: 4.37559066,
date: moment("2018-10-23T10:05:19.000"),
side: 'buy',
orders: 1,
fees: { XRP: 0.00437559066 },
feePercent: 0.1 }
2018-10-23 10:05:31 (ERROR):	Cannot calculate a profit report without having received portfolio data.
2018-10-23 10:05:31 (ERROR):	Skipping performanceReport..
2018-10-23 20:44:16 (INFO):	Trader Received advice to go short. Selling  XRP
2018-10-23 20:44:38 (INFO):	[ORDER] partial sell fill, total filled: 4.37121507
2018-10-23 20:44:41 (INFO):	[ORDER] summary: { price: 0.00006982,
amount: 4.37121507,
date: moment("2018-10-23T20:44:38.000"),
side: 'sell',
orders: 1,
fees: { BTC: 3.051982361874e-7 },
feePercent: 0.1 }
2018-10-23 20:45:16 (INFO):	(ROUNDTRIP) entry date (UTC)  	exit date (UTC)  	exposed duration	P&L 	profit
2018-10-23 20:45:16 (INFO):	(ROUNDTRIP) 2018-10-23 10:05	2018-10-23 20:4411 hours        	0.00	1.16
2018-10-23 20:45:16 (INFO):	(PROFIT REPORT) original balance:		 0.00031746 BTC
2018-10-23 20:45:16 (INFO):	(PROFIT REPORT) current balance:		 0.00032113 BTC
2018-10-23 20:45:16 (INFO):	(PROFIT REPORT) profit:				 0.00000367 BTC (1.15591399%)
2018-10-24 23:24:17 (INFO):	Trader Received advice to go long. Buying  XRP
2018-10-24 23:24:26 (INFO):	[ORDER] partial buy fill, total filled: 0.9861862699999997
2018-10-24T23:25:26.678Z 'cancelOrder invalid order'
2018-10-24 23:25:26 (INFO):	[ORDER] partial buy fill, total filled: 4.34515738
2018-10-24 23:25:30 (INFO):	[ORDER] summary: { price: 0.00007030503416327351,
amount: 4.34515738,
date: moment("2018-10-24T23:25:27.000"),
side: 'buy',
orders: 2,
fees: { XRP: 0.00434515738 },
feePercent: 0.10000000000000002 }
2018-10-24 23:26:17 (INFO):	(PROFIT REPORT) original balance:		 0.00031746 BTC
2018-10-24 23:26:17 (INFO):	(PROFIT REPORT) current balance:		 0.00032081 BTC
2018-10-24 23:26:17 (INFO):	(PROFIT REPORT) profit:				 0.00000335 BTC (1.05483045%)
[TEMP DEBUG] Polo response was: [{"globalTradeID":394840179,"tradeID":23391995,"date":"2018-10-25 12:15:24","type":"buy","rate":"0.00007056","amount":"0.00015738","total":"0.00000001"},{"globalTradeID":394840168,"tradeID":23391994,"date":"2018-10-25 12:15:14","type":"sell","rate":"0.00007056","amount":"24.59653381","total":"0.00173553"},{"globalTradeID":394840167,"tradeID":23391993,"date":"2018-10-25 12:15:14","type":"sell","rate":"0.00007056","amount":"24.21329612","total":"0.00170849"},{"globalTradeID":394840166,"tradeID":23391992,"date":"2018-10-25 12:15:08","type":"buy","rate":"0.00007057","amount":"134.86483423","total":"0.00951741"},{"globalTradeID":394840157,"tradeID":23391991,"date":"2018-10-25 12:14:53","type":"sell","rate":"0.00007056","amount":"0.14427437","total":"0.00001017"},{"globalTradeID":394840141,"tradeID":23391990,"date":"2018-10-25 12:14:40","type":"buy","rate":"0.00
2018-10-25 12:17:16 (WARN):	Poloniex returned an error while fetching trades: SyntaxError: Unexpected end of JSON input
at JSON.parse ()
at IncomingMessage. (/home/ytigiev/gekko/exchange/node_modules/gekko-broker-poloniex/poloniex.js:106:23)
at emitNone (events.js:111:20)
at IncomingMessage.emit (events.js:208:7)
at endReadableNT (_stream_readable.js:1064:12)
at _combinedTickCallback (internal/process/next_tick.js:139:11)
at process._tickCallback (internal/process/next_tick.js:181:9)

Thanks for those logs, they definitely make it easier to fix. Will dive
into this asap.
On Fri, Oct 26, 2018 at 12:20 AM YuriyTigiev<EMAIL_ADDRESS>wrote:

New error. Last deal had an issue.
/ \ / |/ | / |/ | / | /
/$$$$$$ |$$$$$$$$/ $$ | /$$/ $$ | /$$/ /$$$$$$ |
$$ | $$/ $$ |_ $$ |/$$/ $$ |/$$/ $$ | $$ |
$$ |/ |$$ | $$ $$< $$ $$< $$ | $$ |
$$ |$$$$ |$$$$$/ $$$$$ \ $$$$$ \ $$ | $$ |
$$ *$$ |$$ |____ $$ |$$ \ $$ |$$ \ $$ _*$$ |
$$ $$/ $$ |$$ | $$ |$$ | $$ |$$ $$/
$$$$$$/ $$$$$$$$/ $$/ $$/ $$/ $$/ $$$$$$/
Gekko v0.6.6
I'm gonna make you rich, Bud Fox.
2018-10-20 04:55:22 (INFO): Setting up Gekko in realtime mode
2018-10-20 04:55:22 (INFO):
2018-10-20 04:55:22 (INFO): Setting up:
2018-10-20 04:55:22 (INFO): Candle writer
2018-10-20 04:55:22 (INFO): Store candles in a database
2018-10-20 04:55:22 (INFO):
2018-10-20 04:55:22 (INFO): Setting up:
2018-10-20 04:55:22 (INFO): Trading Advisor
2018-10-20 04:55:22 (INFO): Calculate trading advice
2018-10-20 04:55:22 (INFO): Using the strategy: neuralnet_v2
2018-10-20 04:55:23 (INFO): The trading method requests 1000 minutes of
historic data. Checking availablity..
2018-10-20 04:55:23 (INFO):
2018-10-20 04:55:23 (INFO): Usable local data available, trying to match
with exchange data..
2018-10-20 04:55:23 (INFO): Preventing Gekko from requesting 752 minutes
of history.
2018-10-20 04:55:24 (INFO): Not seeding locally available data to the
trading method.
2018-10-20 04:55:24 (INFO): The exchange does not return enough data. 0
minutes are still missing.
2018-10-20 04:55:24 (INFO): Setting up:
2018-10-20 04:55:24 (INFO): Trader
2018-10-20 04:55:24 (INFO): Follows the advice and create real orders.
2018-10-20 04:55:24 (INFO):
2018-10-20 04:55:30 (INFO): Portfolio:
2018-10-20 04:55:30 (INFO): 0.00031776 BTC
2018-10-20 04:55:30 (INFO): 0 XRP
2018-10-20 04:55:30 (INFO): Balance:
2018-10-20 04:55:30 (INFO): 0.00031776 BTC
2018-10-20 04:55:30 (INFO): Exposed:
2018-10-20 04:55:30 (INFO): no (0.00%)
2018-10-20 04:55:30 (INFO): Setting up:
2018-10-20 04:55:30 (INFO): Performance Analyzer
2018-10-20 04:55:30 (INFO): Analyzes performances of trades
2018-10-20 04:55:30 (INFO):
2018-10-20 04:55:30 (INFO): Starting to watch the market: Poloniex XRP/BTC
2018-10-23 10:04:31 (INFO): Trader Received advice to go long. Buying XRP
2018-10-23 10:05:19 (INFO): [ORDER] partial buy fill, total filled:
4.37559066
2018-10-23 10:05:21 (INFO): [ORDER] summary: { price: 0.00006891,
amount: 4.37559066,
date: moment("2018-10-23T10:05:19.000"),
side: 'buy',
orders: 1,
fees: { XRP: 0.00437559066 },
feePercent: 0.1 }
2018-10-23 10:05:31 (ERROR): Cannot calculate a profit report without
having received portfolio data.
2018-10-23 10:05:31 (ERROR): Skipping performanceReport..
2018-10-23 20:44:16 (INFO): Trader Received advice to go short. Selling XRP
2018-10-23 20:44:38 (INFO): [ORDER] partial sell fill, total filled:
4.37121507
2018-10-23 20:44:41 (INFO): [ORDER] summary: { price: 0.00006982,
amount: 4.37121507,
date: moment("2018-10-23T20:44:38.000"),
side: 'sell',
orders: 1,
fees: { BTC: 3.051982361874e-7 },
feePercent: 0.1 }
2018-10-23 20:45:16 (INFO): (ROUNDTRIP) entry date (UTC) exit date (UTC)
exposed duration P&L profit
2018-10-23 20:45:16 (INFO): (ROUNDTRIP) 2018-10-23 10:05 2018-10-23
20:4411 hours 0.00 1.16
2018-10-23 20:45:16 (INFO): (PROFIT REPORT) original balance: 0.00031746
BTC
2018-10-23 20:45:16 (INFO): (PROFIT REPORT) current balance: 0.00032113 BTC
2018-10-23 20:45:16 (INFO): (PROFIT REPORT) profit: 0.00000367 BTC
(1.15591399%)
2018-10-24 23:24:17 (INFO): Trader Received advice to go long. Buying XRP
2018-10-24 23:24:26 (INFO): [ORDER] partial buy fill, total filled:
0.9861862699999997
2018-10-24T23:25:26.678Z 'cancelOrder invalid order'
2018-10-24 23:25:26 (INFO): [ORDER] partial buy fill, total filled:
4.34515738
2018-10-24 23:25:30 (INFO): [ORDER] summary: { price:
0.00007030503416327351,
amount: 4.34515738,
date: moment("2018-10-24T23:25:27.000"),
side: 'buy',
orders: 2,
fees: { XRP: 0.00434515738 },
feePercent: 0.10000000000000002 }
2018-10-24 23:26:17 (INFO): (PROFIT REPORT) original balance: 0.00031746
BTC
2018-10-24 23:26:17 (INFO): (PROFIT REPORT) current balance: 0.00032081 BTC
2018-10-24 23:26:17 (INFO): (PROFIT REPORT) profit: 0.00000335 BTC
(1.05483045%)
[TEMP DEBUG] Polo response was:
[{"globalTradeID":394840179,"tradeID":23391995,"date":"2018-10-25
12:15:24","type":"buy","rate":"0.00007056","amount":"0.00015738","total":"0.00000001"},{"globalTradeID":394840168,"tradeID":23391994,"date":"2018-10-25
12:15:14","type":"sell","rate":"0.00007056","amount":"24.59653381","total":"0.00173553"},{"globalTradeID":394840167,"tradeID":23391993,"date":"2018-10-25
12:15:14","type":"sell","rate":"0.00007056","amount":"24.21329612","total":"0.00170849"},{"globalTradeID":394840166,"tradeID":23391992,"date":"2018-10-25
12:15:08","type":"buy","rate":"0.00007057","amount":"134.86483423","total":"0.00951741"},{"globalTradeID":394840157,"tradeID":23391991,"date":"2018-10-25
12:14:53","type":"sell","rate":"0.00007056","amount":"0.14427437","total":"0.00001017"},{"globalTradeID":394840141,"tradeID":23391990,"date":"2018-10-25
12:14:40","type":"buy","rate":"0.00
2018-10-25 12:17:16 (WARN): Poloniex returned an error while fetching
trades: SyntaxError: Unexpected end of JSON input
at JSON.parse ()
at IncomingMessage.
(/home/ytigiev/gekko/exchange/node_modules/gekko-broker-poloniex/poloniex.js:106:23)
at emitNone (events.js:111:20)
at IncomingMessage.emit (events.js:208:7)
at endReadableNT (_stream_readable.js:1064:12)
at _combinedTickCallback (internal/process/next_tick.js:139:11)
at process._tickCallback (internal/process/next_tick.js:181:9)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/askmike/gekko/issues/2587#issuecomment-433115596, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA7MDzEV-7C91v0P0ygJCbPJWy3xTdiFks5uoeTWgaJpZM4XT7ZS
.

--
PGP key at keybase.io/mikevanrossum
https://keybase.io/mikevanrossum/key.asc

Happen to me 3 times in a row after a buy order is executed then crash the strat runner.
Am using branch release/0.6.7


Suggest versioning the code and docs

The doc does not always correspond to the current backend, I suggest adding the date or version of the last update for the doc at the beginning of the page, this will allow to understand which current version is, we can add the current version of the node/sui-client and documentation
for e.g. current node version is 0.5.0 current doc vesion for 0.4.0 version what does it mean there may be a discrepancy

Thanks, Roman. The issue is we build docs.sui.io from the main upstream branch yet release the downstream devnet branch to the public. So the docs are ahead of the code in many ways.
See this issue for our proposed solution, namely to allow users to toggle between the two branches in the docs. What do you think? Thanks for the report!

yes, this is a great solution, it will solve all the issues

Thanks for confirming.


i.glass failing to execute for afik

<State>
{
  "lastMessageText": "",
  "numMessages": 1
}
</State>

// As you've probably noticed, Glass files can contain more than just the prompt.
// We can store data in the Glass file as well!

// This works just like `useState` in React
const [lastMessageText, setLastMessageText] = useState('')
const [numMessages, setNumMessages] = useState(0)

// First, let's increment the numMessages by 1 when we execute the file
setNumMessages(numMessages + 1)

<Transcript>
<User>
tell me a joke
</User>

<Assistant model="gpt-3.5-turbo" temperature="1">
█
</Assistant>
</Transcript>

<System>
You are FunnyGPT. Respond to the user with a message that's maximally likely to make them laugh.
</System>

// The `onResponse` attribute lets you execute code with the response from the LLM.

<User>
${input}
</User>

<Request model="gpt-3.5-turbo" onResponse={response => setLastMessageText(response.message)} />

ERROR: Error: Process exited with code 1: /Users/afik_cohen/repos/glass/packages/glasslib/dist/index.js:1 (()=>{var e={6919:(e,a,t)=>{"use strict";const p=t(2489),i=/^[\da-fA-F]+$/,r=/^\d+$/,n= blah blah blah

ERROR: Error: Process exited with code 1: node:internal/modules/cjs/loader:1073 throw err; ^ Error: Cannot find module '@glass-lang/glasslib' Require stack: - /Users/afik_cohen/repos/repoGPT/.glasslog/glass-bundle.js at Module._resolveFilename (node:internal/modules/cjs/loader:1070:15) at Module._load (node:internal/modules/cjs/loader:923:27) at Module.require (node:internal/modules/cjs/loader:1137:19) at require (node:internal/modules/helpers:121:18) at Object. (/Users/afik_cohen/repos/repoGPT/.glasslog/glass-bundle.js:26:23) at Module._compile (node:internal/modules/cjs/loader:1255:14) at Module._extensions..js (node:internal/modules/cjs/loader:1309:10) at Module.load (node:internal/modules/cjs/loader:1113:32) at Module._load (node:internal/modules/cjs/loader:960:12) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12) { code: 'MODULE_NOT_FOUND', requireStack: [ '/Users/afik_cohen/repos/repoG...

Fixed


continueCode(s) are now fetched from server instead of cookies

Description
On saving the progress using the 'Backup' option on score-board page, the continueCode, continueCodeFixIt and continueCodeFindIt are not saved to the JSON File in some scenarios.
Minimal Reproduction

Start a new JuiceShop instance.
Solve a task for each of the category (challenge, FindIt, FixIt), the corresponding cookies and values are updated in the browser accordingly.
Reconnect to the same instance using a different browser, and check the cookies. The three continueCode(s) are not reflected anymore.

Since the JSON file backup is configured to fetch the codes from browser cookies, the same won't be reflected in the JSON backup, until a new challenge is solved - which indirectly calculates the codes again and stores it as a cookie.
https://github.com/juice-shop/juice-shop/blob/9cfa32a4125f1498805728b93a4df4f33ffdcccf/routes/continueCode.ts#L14-L26
Motivation Scenario (Problem):
Following the above 3 steps, if the user saves the file while assuming all codes are saved by default, and later loses access to the instance, the progress cannot be restored on a new instance using the backup file, thereby making the backup option futile.
Environment

Node: v16.17.0
npm: v8.18.0
Suggested Fix
As part of this PR, the continueCode(s) for challenge, FindIt and FixIt are fetched from the server itself by sending a GET request. File format generated follows the existing valid format available at validLocalBackup.json.
Affirmation

[x] My code follows the CONTRIBUTING.md guidelines

Sounds good, @bkimminich! I'll update the code to use cookies as a fallback.

Chrome Headless 108.0.5359.98 (Linux x86_64) LocalBackupService should save language to file FAILED
	TypeError: this.challengeService.continueCode is not a function
	    at LocalBackupService.save (src/app/Services/local-backup.service.ts:38:27)
	    at UserContext.apply (src/app/Services/local-backup.service.spec.ts:55:13)
	    at TestBedImpl.execute (node_modules/@angular/core/fesm2015/testing.mjs:26223:19)
	    at UserContext.apply (node_modules/@angular/core/fesm2015/testing.mjs:26439:24)
	    at _ZoneDelegate.invoke (node_modules/zone.js/fesm2015/zone.js:372:26)
	    at ProxyZoneSpec.onInvoke (node_modules/zone.js/fesm2015/zone-testing.js:287:39)
	    at _ZoneDelegate.invoke (node_modules/zone.js/fesm2015/zone.js:371:52)
	    at Zone.run (node_modules/zone.js/fesm2015/zone.js:134:43)
	    at runInTestZone (node_modules/zone.js/fesm2015/zone-testing.js:582:34)
	    at UserContext.<anonymous> (node_modules/zone.js/fesm2015/zone-testing.js:597:20)
Chrome Headless 108.0.5359.98 (Linux x86_64): Executed 434 of 638 (1 FAILED) (skipped 3) (0 secs / 7.646 secs)
Chrome Headless 108.0.5359.98 (Linux x86_64) LocalBackupService should save language to file FAILED
	TypeError: this.challengeService.continueCode is not a function
	    at LocalBackupService.save (src/app/Services/local-backup.service.ts:38:27)
	    at UserContext.apply (src/app/Services/local-backup.service.spec.ts:55:13)
	    at TestBedImpl.execute (node_modules/@angular/core/fesm2015/testing.mjs:26223:19)
	    at UserContext.apply (node_modules/@angular/core/fesm2015/testing.mjs:26439:24)
	    at _ZoneDelegate.invoke (node_modules/zone.js/fesm2015/zone.js:372:26)
	    at ProxyZoneSpec.onInvoke (node_modules/zone.js/fesm2015/zone-testing.js:287:39)
	    at _ZoneDelegate.invoke (node_modules/zone.js/fesm2015/zone.js:371:52)
	    at Zone.run (node_modules/zone.js/fesm2015/zone.js:134:43)
	    at runInTestZone (node_modules/zone.js/fesm2015/zone-testing.js:582:34)
	    at UserContext.<anonymous> (node_modules/zone.js/fesm2015/zone-testing.js:597:20)

It seems the unit test for the local backup is failing after this change. The reason seems to be a new funtion that is not mocked in the test. But even when mocking it, the PR would still need a few changes in the test code as it now works differently. We should probably test that the result from the service call is used, unless it's an error, then the cookie backup should be used.

Your nested service calls are problematic. The backup file only gets created if either all server-side calls work fine or none of them do. In any mixed case, there's no backup written. You would have to parallelize instead of nest the server-side calls and then when they all resolved (with success or error) write the backup file once.

@nitishdewan, thanks again for this nice QoL improvement for our users! Please feel free to send me your post address via email, Slack or Gitter DM and I'll send you a little sticker pack in January!

@bkimminich Thank you so much for helping with the test scenarios and the modified service calls. Glad I could contribute to improving the project!


[SPARK-18067] Avoid shuffling child if join keys are superset of child's partitioning keys

Jira : https://issues.apache.org/jira/browse/SPARK-18067
What problem is being addressed in this PR ?
Currently shuffle based joins require its children to be shuffled over all the columns in the join condition. In case the child node is already distributed over a subset of columns in the join condition, this shuffle is not needed (eg. if the input is bucketed, if the input is output of a subquery). Avoiding the shuffle makes the join run faster and more stably as its single stage.
To dive deeper, lets look at this example. Both input tables table1 and table2 are bucketed on columns i and j and have 8 buckets. The query is joining the 2 tables over i,j,k. With bucketing, all the rows with the same values of i and j should reside in the same bucket of both the inputs. So, if we simply sort the corresponding buckets over the join columns and perform the join, that would suffice the requirements.

partitions
table1 (i,j,k) values
table2 (i,j,k) values

bucket 0
(0,0,1)  (0,0,2)  (1,0,4)
(0,0,1)  (0,0,3)

bucket 1
(1,0,2) (1,1,1)
(1,0,1) (1,0,2) (1,1,2)

bucket 2
(0,1,8) (0,1,6)
(0,1,1)

What changes were proposed in this pull request?
Both shuffled hash join and sort merge join would not keep track of which keys should the children be distributed on ?. To start off, this is same as the join keys. The rule ReorderJoinPredicates is modified to detect if the child's output partitioning is over a subset of join keys and based on that the distribution keys for the join operator are revised.
How was this patch tested?

Added unit test.
manual test:

Query:
SELECT * FROM table1 a JOIN table2 b ON a.i = b.i AND a.j = b.j AND a.k = b.k

BEFORE
SortMergeJoin [i#5, j#6, k#7], [i#8, j#9, k#10], Inner
:- *Sort [i#5 ASC NULLS FIRST, j#6 ASC NULLS FIRST, k#7 ASC NULLS FIRST], false, 0
:  +- Exchange hashpartitioning(i#5, j#6, k#7, 200)
:     +- *FileScan orc default.table1[i#5,j#6,k#7] Batched: false, Format: ORC, Location: InMemoryFileIndex[file:warehouse/table1], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<i:int,j:int,k:string>
+- *Sort [i#8 ASC NULLS FIRST, j#9 ASC NULLS FIRST, k#10 ASC NULLS FIRST], false, 0
   +- Exchange hashpartitioning(i#8, j#9, k#10, 200)
      +- *FileScan orc default.table2[i#8,j#9,k#10] Batched: false, Format: ORC, Location: InMemoryFileIndex[file:warehouse/table2], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<i:int,j:int,k:string>

AFTER
SortMergeJoin [i#5, j#6, k#7], [i#8, j#9, k#10], [i#5, j#6], [i#8, j#9], Inner
:- *Sort [i#5 ASC NULLS FIRST, j#6 ASC NULLS FIRST, k#7 ASC NULLS FIRST], false, 0
:  +- *FileScan orc default.table1[i#5,j#6,k#7] Batched: false, Format: ORC, Location: InMemoryFileIndex[file:warehouse/table1], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<i:int,j:int,k:string>
+- *Sort [i#8 ASC NULLS FIRST, j#9 ASC NULLS FIRST, k#10 ASC NULLS FIRST], false, 0
   +- *FileScan orc default.table2[i#8,j#9,k#10] Batched: false, Format: ORC, Location: InMemoryFileIndex[file:warehouse/table2], PartitionFilters: [], PushedFilters: [], ReadSchema: struct<i:int,j:int,k:string>

Test build #81131 has started for PR 19054 at commit 9ba8add.

Test build #81131 has finished for PR 19054 at commit 9ba8add.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81131/
Test PASSed.

cc @hvanhovell @cloud-fan for review

Test build #81562 has started for PR 19054 at commit ec8bd80.

Test build #81562 has finished for PR 19054 at commit ec8bd80.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81562/
Test PASSed.

Test build #84366 has started for PR 19054 at commit b0db6aa.

Test build #84366 has finished for PR 19054 at commit b0db6aa.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84366/
Test FAILed.

Test build #84368 has started for PR 19054 at commit 69e288e.

Test build #84368 has finished for PR 19054 at commit 69e288e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84368/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4229/
Test PASSed.

Build finished. Test PASSed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15792/
Test PASSed.


not_authed when starting RTM connection [SLACK]

Hi,
I have a slack bot that i wrote in Jan-Mar 2017. However, when I make a new bot with the same code and start it, i get the error "not_authed".
I've debugged the issue and my token is good (ie, if i make a https://slack.com/api/rtm.connect POST call with my token as a body parameter, it works fine and i get a result back). It just seems to be the bot.startRTM  method that doesn't seem to be working.
My code is at the bottom:
this.controller = botkit.slackbot({
            debug: false,
            stats_optout: true
});
this.bot = this.controller.spawn({
            token: my_bot_access_token_is_here
});

 this.bot.startRTM(function(err, bot, payload) {
        if (err) {
                console.log(err); //I GET THE ERROR "not_authed"
        }
});

Any Ideas?

I see that you are talking on the developer slack community, we will continue the discussion there.

FYI it was resolved here: https://dev4slack.slack.com/archives/C0AV5N8NA/p1505833922000482
The OP was supplying an empty token to "this.controller.spawn"


Allow removal and updating of the FileMap's inside CodeMap's

For language servers the sources will be frequently modified and old sources (FileMaps) will be thrown out eventually. As CodeMap works now though, it is not possible to remove a source once it is added which means that memory use will grow for each modification to a file.
If removal of FileMaps are possible we could maybe run into fragmentation issues for Span allocation but I think that in practice this can largely be ignored (or we could use some simple memory allocator approach to remedy memory fragmentation).

Has there been any progress on this?

You can use https://docs.rs/codespan/0.2.0/codespan/struct.CodeMap.html#method.update for a naive approach (it uses first-fit to find a gap in the spans to fit the new source into)

Ah, I just realised that I made a dupe of this here: #83.
Which of these do you think is better for the current state of codespan @Marwes?

I guess we can close this since there is an implementation now, even if it is naive.


New version: uazo.cromite version 127.0.6533.89

Created by 🥟 Dumplings in workflow run #3227.
Logs
Updated: 127.0.6533.73 → 127.0.6533.89
Cannot validate argument on parameter 'ChatID'. The argument is null, empty, or consists of only white-space characters. Provide an argument that contains non white-space characters, and then try the command again.
Submitting WinGet manifests
Cannot validate argument on parameter 'ChatID'. The argument is null, empty, or consists of only white-space characters. Provide an argument that contains non white-space characters, and then try the command again.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:
(Automated response - build 887.)


Add MSIDStorageManager.h + stub impl for Mac.

Shows a proposed low-level storage API, intended to be potentially usable by both MSAL/C++ and MSAL/Obj-C for Mac keychain-based storage. The implementation is just a stub.

Will use the MSIDTokenCacheDataSource protocol, closing


YPGPM and CanaryMod: monster config not working as advertised

These three need updating. If I find the solution, I'll be back with a pull request.
/js self.location.world.allowMonsters
/js self.location.world.allowMonsters = true
/js self.location.world.setSpawnFlags(false, true)
(spawn-monsters=true mentioned in the CanaryMod config docs)

Changed this section to use world.raining instead.


OCPBUGS-39249: fix Sort all resources list

Sorting method to sort matchLabels pod selector in network policies
specify an ingress method for hosts
fix small things for routes and service

fine by me , just rename Phillip suggestion please

renamed @pcbailey @metalice

/cherry-pick release-4.17


updated documentation; add details on provisioning openstack environment

Btw, we can also give user information about external access to the cluster. To be able to use kubectl from a localhost user can copy kubectl.kubeconfig file located at /etc/kubernetes/ and place in ~/.kube/config. kubectl looks for config in that location by default, but this behaviour can be overridden by --kubeconfig=/file/location/path directive. Also kubeconfig uses cert auth and TLS-ecncryption, so all operations with kubectl is using secure channel. Thoughts?

If not covered within kubernetes or even if it is, either add the some notes and then a link to the kubernetes docs as anything that helps others start using this faster the better

Ok, will do this. Moreover here is the first thing why: #45


Ternary results consider both branches even when boolean literal values make one impossible

TypeScript Version:  2.3.0-dev.20170217
Code
const aOrB = true ? 'a' : 'B';
const a: 'a' = aOrB;

Expected behavior:
Compiles without error.
Actual behavior:

Type '"a" | "B"' is not assignable to type '"a"'.
Type '"B"' is not assignable to type '"a"'.

Currently reachability analysis in compiler works on the statement level which has a good rationale: it is pretty common to have code like while(true) <block> where control flow inside the loop can be abrupted via return, break, continue or throw statements. However having it on the expression level add a very little value to the real world use-cases, i.e. what is the purpose of writing  code like true ? <do-something> : <do-something-else> other than making synthetic example?

I generally feel like the compiler should be as aware of types as possible. This is obvious using true itself, but when using a function that returns true, or particularly an overload the returns true with a particular input, would be less obvious, and thus something like this could result in improved error-checking in the face of refactoring.
For example:
const foobar = passesSomePredicate(foo) ? new Foo() : new Bar();
if (isFoo(foobar)) {
    doSomethingWithFoo(foobar);
}
else {
    doSomethingWithBar(foobar);
}

When originally written, presumably this code was meaningful. But suppose some refactoring happened that caused bar to be narrower, or an overload for passesSomePredicate was written, and either way, now we have passesSomePredicate(typeof foo): true. This means that foobar must be a Foo (and not a Bar), which means isFoo (a typeguard) is redundant and the else block is unreachable. If the compiler knew that foobar had to be a Foo and that else block is unreachable and the value of foobar in doSomethingWithBar(foo) is never. It improves the compile-time understanding of the system, and can help find redundant or unreachable code.


Choice of minimap version when running yacrd for chimeric read removal

Dear Developers
I see that you have requested to use an older version of minimap2 for Yacrd given some changes in minimap that doesn't sit well with Yacrd. I did a small exploration using prescribed version 2.18 and newest version 2.28-r1209 on Dengue Samples sequenced on Minion as follows:
minimap2 -x ava-ont $p $p -t 120 > overlap.paf;
n=$(basename $p | cut -f 1 -d '.');
yacrd -t 120 -i overlap.paf -o ${n}_oldminimap.yacrd

And I see the following:

Test_case.xlsx
Using old minimap2 version i.e. 2.18 , yacrd detects marginally more chimeric reads as compared to the new one (see figure above).
Just to make sure if the chimeric reads detected by minimap2_old+Yacrd and minimap2_new+Yacrd are totally different or borderline different, I check the overlap of the read headers that Yacrd output as Chimeric.
When I take the read headers and check the overlap of the reads detected to be chimeric between the two, most of the read headers of chimeric read from new minimap overlaps with the results from the old minimap hence informing that the chimeric reads detected by newer minimap2+yacrd are not that different relatively except few reads. We choose 3 samples that had highest no. of chimeric reads here to see which reads were not being tagged by Yacrd when using it with new minimap2 (see file attached Reads_unique.txt). Reads_unique.txt
To see if the reads detected chimeric in both cases can be distinguished on some grounds such as MAPQ, we viewed their alignments in IGV with DENV2 and saw that reads from both cases have a portion (~500 bp) that maps to DENV2 and rest is soft clipped and the MAPQ ranges from 13 to 60. Soft clipping of major portion of reads (~50% or greater) tempts us to believe they are chimeric. But this still didn't answer why some reads escape chimera detection when using new minimap2+Yacrd and some reads are only tagged to be chimeric when using old minimap2_yacrd.
Did you test Yacrd with the new version and try to see if the seed related issue has been resolved or still persist? Also, should I use -c option in minimap2 as suggested by one user here

Hi thank again for your interest.
After rereading, my Readme I think I'm too dramatic.
With your results it seems to me that you can use the latest version of minimap2 without any problem.

About the -c parameter for minimap2, it actually improves the mapping quality but also drastically increase the computation time. In order to generate the CIGAR string, exact mapping (dynamic programming stuff) must be performed, without it there's only the search and chainings of seeds.
I don't think the benefit is worth it. It should only modify a little bit the limit of the poor quality regions.


Update documentation and style of interactives

Resolves #953
Resolves #766
Resolves #945
The focus was on interactives that have already been published, but unintentionally in some cases those that have not been were changed also.
Packet Attack must remain left-aligned for the alignment of elements on the canvas.
License file in the pixel viewer directory is needed by the interactive itself
Reviewers, if you are sure of any authors I listed 'Unknown' on, let me know

Can you please go through and make sure all of the whole page interactives have titles? I think we could probably do it in the base template and then we wouldn't have to add it to each individual html file. But this means we would have to go through and remove the titles from html templates that do have titles set. Happy to discuss in technical channel.

Can you please go through and make sure all of the whole page interactives have titles?

I think most if not all the ones that don't have titles shouldn't have them. Especially since it's usually the primarily in-page ones that don't have one

Can you please go through and make sure all of the whole page interactives have titles?

I think most if not all the ones that don't have titles shouldn't have them. Especially since it's usually the primarily in-page ones that don't have one

In regards to the in-page part we can just add titles to the whole-page base template so it won't pop up when displayed in-page. But yeah some might look strange with titles.


schema_generated.h checked into source instead of generated

Issue type
Build/Install
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
master
Custom code
No
OS platform and distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
The schema_generated.h file is checked into the source tree, as opposed to being generated by flatc. This in turn induces a dependency on a very specific version of flatc:
static_assert(FLATBUFFERS_VERSION_MAJOR == 23 &&
              FLATBUFFERS_VERSION_MINOR == 5 &&
              FLATBUFFERS_VERSION_REVISION == 26,
             "Non-compatible flatbuffers version included");

There are other files that are generated by flatc in the BUILD. What is special about this file that requires it to be checked into the source tree? There are some references to schema_generated.h.oss that suggest that there's some Google specific stuff that's being omitted, but that's just a guess.
Standalone code to reproduce the issue
N/A

Relevant log output
No response

This issue originally reported by @aws-taylor has been moved to this dedicated repository for LiteRT to enhance issue tracking and prioritization. To ensure continuity, we have created this new issue on your behalf.
We appreciate your understanding and look forward to your continued involvement.


Add pre-commit configuration

pre-commit is a framework for easy set-up of pre-commit hooks.
This adds configuration for it to run:

ts compilation
ts linting
pr-checks synchronization

The latter required the sync.py to be callable from the project root.
pre-commit can be enabled with
python3 -m pip install pre-commit
pre-commit install

Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.
[x] Confirm the changelog has been updated if necessary.

This looks good. It isn't for me, as it makes committing take too long, but I'm happy to approve it.

yeah, it's true I was a bit hesitant about the linting check (the other two are pretty much instant if compilation was already done). On the other hand for me that I don't work so often here, I was already bitten by committing something not passing all three of the checks :sweat_smile:
FYI there is a way to tweak the configuration locally.


Add TLS 1.2 ECDSA ciphersuites to gRPC defaults

More and more PKI frameworks are generating certificates using
ECDSA keypairs, enabling the ciphersuites in gRPC avoids having
to define the environment variable.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for the Pull Request. Could you please add a test with test ecdsa certs?

Thanks for the test. Unfortunately, it does not cover the gRPC implementation of TLS which is done in the ssl_transport_security.c file. Sorry I should have been more specific :(.
For testing, you have 2 choices.

do another end to end test with ecdsa certs (like test/core/end2end/fixtures/h2_ssl.c).
wait for a PR by @yihuazhang that will import some TSI (transport security) level unit tests which will make things much easier to test.

If you're not in a hurry for this feature, I would recommend option 2.

this is ok to test.

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Some of the failures are due to the fact the boringssl in third_party is not up to date with master and lacks an OpenSSL TLS compatibility sumbol as describe here:  https://boringssl.googlesource.com/boringssl/+/48e1d180a46b8caaf6b4619db07d078fb7cbcc60.
The symbol was dropped and then reintroduced, the version used by grpc master is in between, making some tests fail.

My recollection is that we are tracking the chromium branch of boringssl and it looks like the latest one has the fix: https://boringssl.googlesource.com/boringssl/+/chromium-stable/include/openssl/ssl.h#3851
@nicolasnoble, can we update?

Feel free to update the submodules in this pull request.

[microbenchmarks] No significant performance differences

Sorry for the complicated flow but a few things here;

We want to upgrade boring to the latest chromium-stable branch and master.
Looks like the sanity tests are not happy. At least you should clang-format your code.
The new boringssl does not seem to compile (maybe you'll have better luck with the chromium-stable branch): https://grpc-testing.appspot.com/job/gRPC_pull_requests_linux/6817/testReport/junit/(root)/aggregate_tests/run_tests_c_linux_dbg_native/

[trickle] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[trickle] No significant performance differences

[trickle] No significant performance differences

Well this is more painful than expected ... bumping boringssl also included commits that changes the way they do tests. For instance: https://github.com/google/boringssl/commit/b228541129167901a682f302d2dc052546e380f8 switched the asn1_test.cc to be included in the crypto_test Gtest that isn't run by grpc anyway.
Can I just remove the boringssl_asn1_test target from the Makefile within grpc to make jenkins happy?

[microbenchmarks] No significant performance differences

[trickle] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

On the security side, things look good to me, except maybe for a missing call in ssl_transport_security.c.
@nicolasnoble can you please have a look at the tweaks in the build system?

Anything missing on my side for this?

If you are changing the boringssl submodule on purpose, you have to update the associated test to validate you haven't changed it by mistake. Sanity is not happy as a result: https://grpc-testing.appspot.com/job/gRPC_pull_requests_linux_opt/378/

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Any update on this PR?

@calderonth Do you still want to move on this PR. If so, could you please rebase and resolve the conflict. Thanks much for your contribution.

I'll try to rebase the whole lot this week.
On Wed, Mar 21, 2018 at 7:46 PM, Jiangtao Li<EMAIL_ADDRESS>wrote:

@calderonth https://github.com/calderonth Do you still want to move on
this PR. If so, could you please rebase and resolve the conflict. Thanks
much for your contribution.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/grpc/grpc/pull/11699#issuecomment-375072180, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAux1kTR9QcADL-c6TcPyw4mKH7v1_1sks5tgq4AgaJpZM4OP0Jw
.

This is a massive mess, lots of the files in conflict have changed dramatically, I'll give it another go after Easter.

Is this PR going to be revived? We are going to mark this obsolete if there is no activity for another month. A new PR can be created at that time.

Since we already support ESDSA cipher suites now in gRPC. We can close this one.


grid footer style on first detail open

Closes softlayer/sl-ember-components#949, softlayer/sl-ember-components#795

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

addon/components/sl-grid.js, line 204 [r1] (raw file):

Add a blank line after this one
Capitalize the "e" in "Ember"

addon/components/sl-grid.js, line 205 [r1] (raw file):
Actually there is a drawback.  Why perform unnecessary calculations when don't need to?  Based on the line following this one, indicating that it's really needed for the details pane, is there any way to narrow the scope of this event to the specific scenario it is only really needed for?

addon/components/sl-grid.js, line 207 [r1] (raw file):
Would the footer be empty every time when a detail row is expanded, to then later be filled with data?  Seems this would only occur when the grid is first rendered.
The sum of these comments has me question whether the approach employed is the one that should be.

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

addon/components/sl-grid.js, line 205 [r1] (raw file):
I could not find a way to narrow it down like that.  Perhaps there's some way to hook up event firing between templates so that the details template will catch the event, then fire a special action up to the parent?
I think that's doable, but I need some pointing in the right direction on how that can be achieved.

addon/components/sl-grid.js, line 207 [r1] (raw file):
yes, it's emptied by Ember, then repopulated

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io


File produces 3GB file

Hi Team,
The following file: 1185fa967aa989d5e072577e493d2b307c48181480129d4c45337da64d5bfd25
When running goresym.exe (hash: 6d8c532702bd33adae0bf25e1717a441531369e86350dbb0db2d5d717a0c926a) with the following params:
 GoReSym.exe -t -d -p .\1185fa967aa989d5e072577e493d2b307c48181480129d4c45337da64d5bfd25 > 1185fa_goresym

The symbol recovery appears to be correct. Your binary contains function names that are intentionally huge and obfuscated. Example of the name of the first function in the ftab:

the moduledata pointing to the ftab:

GoReSym can only recover what is present and someone has stomped your symbols with huge names which is why the output is so large.


linux debian / styles.css / not working

howdy i would love to use the nordtheme for SP (which is absolutly awesome btw ;) )
i copied it straight into my ~/.config/superProductivity/styles.css
but its not loading, is this only for mac?
i run SP via AppImage or is this maybe the problem?
thanks in advanced and keep it up!
Hardy

No it should work on any system. Is there some output if you start the app from the commandline?

stupid me, I used the wrong files (i picked the css under source, not dist)....
thanks for reaching out
now it works!

can be closed ;)


Release edgelb 1.2.1 (automated commit)

Release edgelb 1.2.1 (automated commit)
Description:
Source URL: https://downloads.mesosphere.com/edgelb/v1.2.1/assets/stub-universe-edgelb.json
Changes between revisions -1 => 0:
4 files added: [config.json, resource.json, marathon.json.mustache, package.json]
0 files removed: []
0 files changed:

using this for CI purposes


fix ondemand cluster release tests fails

#1623  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Kvg inspect improvements

Improvements to inspect (and subsequently, the annotation model)
Inspect:

Fixed the text drawing such that all rows have a fixed width.
Color random model states grey, but suppress the label for better aesthetics.
Add the read length to the plot title.
Draw y-axis labels to denote each 150 bp in the read, and the final number
of bases seen (useful to verify that the entire read has indeed been annotated).
Draw small marks 10, 20, 30, and 40 bp after the 10x adapter (useful for
guiding the eye when looking for CBC/UMI/TSO adapters).
Improve the color palette.

Annotation model:

Let all adapter ends transition to the model end state.  This resolves
an issue where if the ends of reads did not terminate in the random state,
they wouldn't be annotated properly.

Re: the annotation model, while fixing up the visualizer and thinking about the end of the reads, I realized that the final transcript in the read is delimited, but the annmas v2 model wasn't picking it up.  This was because the model had no edges connecting the ends of adapter states to the model termination state.  Adding in that edge corrects the problem and should allow for this transcript to be recovered.

(This branch branches off jts_segmenting_reads and should probably be merged after that branch.)


Create a JobTicket by ID

This would allow a GUI to present a list of jobs, and then manage those jobs by id without needing to keep a handle on the JobTicket or Batcher instance.  Data Hub Quick Start requested this feature.

We should perhaps at the same time implement #648

The API could be:
/**
 * Gets the JobTicket for an active job (one that has not been stopped by calling stopJob).
 */
DataMovementManager {
  JobTicket getActiveJob(String jobId)
}

JobTicket DataMovementManager.getActiveJob(String jobId)

 - This would allow the user to get the JobTicket for the job whose jobId is known.


Add missing DescribeTable permission now needed for deployments

Fixed

Add missing DescribeTable permission now needed for deployments

This probably became a requirement because I added tags to the resources managed by the serverless.yml file.

There might be other permissions needed as well (such as for adding tags to new resources?), but if so I'll add those when I discover the need.


Impl input

Fixes #1586
This a possible implementation of input. I've moved the rustyline repl into the vm. I would like feedback on improvements or whether input should be tackled differently.
A few differences currently from cpython is that:
The interrupted signal is handled differently for cpython and rustpython.
Cpython treats the signal as a character and rustpython exits execution
When in interactive mode in rustpython and exit() is called in the repl, it seems the program immediately exits. This makes it difficult to save the history to a file. When Cpython has exit() called in its repl, the history is still saved.
For reference:
I use windows 10 and python 3.8

I was thinking that you could move shell.rs into vm/src, and just create a new repl for builtin_input rather than store it in the VM.

I had forgotten to rebase my repository. I plan on doing it over again on a new branch.

Okay I will try as you suggested.


create-react-app css local scope

How to set css local scope for create-react-app

Use any of css-in-js.

CSS Module support will be out in 2.x, or you can use a solution such as styled-components.


feat(789): whitelist img-src for andi logo

Ticket Link #789

I seem to be having some caching issues, changing my env still has the same content policy as before. Not sure how, since I'm restarting everything locally and doing a Clear cache and hard reload. Anyone have any ideas as to why / how it's happening?

Approved with the blocking comment that the mix version is updated.
We have to up the version with a patch, even for adjustments like this, to make sure images are built and pushed correctly when changes are merged.

Ty, totally forgot about the version bump

Due to recent merging, you'll need to update the mix version again


Incompatibility with Docutils smart quotes (elision)

Consider this source eau1.md
# Markdown

l'eau

Inserting this in a Sphinx project with language='fr' and  in conf.py
extensions = [
    'recommonmark',
]

# The suffix(es) of source filenames.
# You can specify multiple suffix as a list of string:
#
source_suffix = {
    '.rst': 'restructuredtext',
    '.txt': 'markdown',
    '.md': 'markdown',
}

and executing for example make pseudoxml one obtains
<document source="/Users/xxxxxxxxx/sphinxtests/6282markdownsmartquotes/eau1.md">

        <title>
            Markdown
        <paragraph>
            l
            ”
            eau

whereas a similar .rst document is transformed into
<document source="/Users/xxxxxxxxx/sphinxtests/6282markdownsmartquotes/eau2.rst">

        <title>
            reST
        <paragraph>
            l’eau

In the former case l'eau gives three text elements and the Docutils smart quotes transforme acted erroneously, not recognizing  a case of elision. In the latter case there is only on text element, and Docutils smart quotes acted correctly.
Notice that smart quotes is default for Sphinx html builder.
For a better description see this comment to Sphinx issue #6282. I am thus raising the issue here :)

Did you find any workaround ?

Does escaping the apostrophe like l\'eau help?
The Docutils recommonmark wrapper merges adjoining Text nodes:
            for node in document.traverse(nodes.TextElement):
                children = node.children
                i = 0
                while i+1 < len(children):
                    if (isinstance(children[i], nodes.Text)
                        and isinstance(children[i+1], nodes.Text)):
                        children[i] = nodes.Text(children[i]+children.pop(i+1))
                        children[i].parent = node
                    else:
                        i += 1

Maybe this would solve the issue.
Otherwise, disable SmartQuotes. Typographical quotes in the source are passed unchanged.


Cleanup units

To improve readability.

Codecov Report
Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.35%. Comparing base (8b48f4f) to head (8339ae2).

Files
Patch %
Lines

src/crs/projected.jl
0.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   95.35%   95.35%
=======================================
  Files          27       27
  Lines        1206     1206
=======================================
  Hits         1150     1150
  Misses         56       56

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


forks: Implement fork operators, remove is_fork

🗒 Description
Implements the following operators for the fork objects:

Greater than (>): Fork is newer than other fork
Greater than or equal to (>=): Fork is at least as newer than other fork
Less than (<): Fork is older than other fork
Less than or equal to (<=): Fork is at least as old than other fork

is_fork is now removed.
🔗 Related Issues
None
✅ Checklist

[x] All: Set appropriate labels for the changes.
[x] All: Considered squashing commits to improve commit history.
[x] All: Added an entry to CHANGELOG.md.
[x] All: Considered updating the online docs in the ./docs/ directory.
[x] Tests: Included the type and version of evm t8n tool used to locally execute test cases:  e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
[x] Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Very nice :smile:

Oh, that’s a nice PR! 🙂👍


Add batching and batched effects to solve the interoperability / multi-actor problem with batches

One common feature request seems to be not just built-in effects, but some kind of synchronous effect, or at least the ability to build one. The reasons both not including built-in effects and not allowing synchronous access to signals during notification are both well-intentioned and defensible. Userland utilities can generally cover those features and make decisions that might not be appropriate for the core proposal.
And one thing that might not be clear in a lot of the discussion around scheduling synchronous signal access in notifications, is that it is possible to build a userland utility for synchronous effect, as long as there is cooperation between the mutation-side and the effect-side. If mutations are performed in a synchronous batch, then tracked effects can be run before the batch returns.
I added such a batched-effect utility to signal-utils a while.
Normally, I think this would be great to leave to a library, except for the multi-actor problem.
In order for this utility to work, all the signal mutators and effect creators must be using the same library (and the same copy of the library). This is a problem for decoupled use cases where the signal consumers and producers are not in the same library, or maintained by the same team, and do not already use a centralized framework instance.
Example
Usage of the batched-effect utility I wrote looks like this:
const a = new Signal.State(0);
const b = new Signal.State(0);

batchedEffect(() => {
  console.log("a + b =", a.get() + b.get());
});

// Logs: a + b = 0

batch(() => {
  a.set(1);
  b.set(1);
});

// Logs: a + b = 2

The callback passed to batchedEffect() running synchronously when the effect is created, and at the end of any batch() modifies a signal used in the callback.
Mechanism
Batches work by sharing global state: a list of callbacks that were notified. This is the core of the multi-actor problem.
A batchedEffect() creates a watcher that doesn't access any signals, but only adds callbacks into the global list synchronously.
batch() then checks this list after calling its batch callback, then runs any effect callbacks in the global list. There is some handling of exceptions and nested batched. In the case of nested batches, effects are only called at the end of the outermost batch() call.
Possible paths to inclusion
There are a few ways the proposal could address this type of feature:

Not at all, and consider it out of scope. I do think that the motivations for including batching match the motivations for creating a signal standard in the first place, which is largely centered around interoperability.
Include batch() and batchedEffect() very similarly to what's in signal-utils. They could live under .subtle as Signal.subtle.batch() and Signal.subtle.batchedEffect().
Try to include only the global state that causes the interoperability issue. Maybe this looks like a Signal.subtle.notifiedSignals that batching effect utilities should write to and batch utilities should read from. This might be very subtle as there are responsibilities on the batch side, like clearing the list after the signals have been accessed. Maybe it'd be better as Signal.subtle.addNotifiedSignal() and Signal.subtle.runNotifiedSignals().

Related Issues

https://github.com/tc39/proposal-signals/issues/136
https://github.com/tc39/proposal-signals/issues/184

Just noting that this is related to https://github.com/tc39/proposal-signals/issues/73


Closed Tasks Page Not Found Bug

Reproduced on my own board and the Demo board aswell.
Issue: Get page not found when I click this link http://demo.kanboard.net/?controller=project&action=tasks&project_id=1
How to reproduce:
Go to http://demo.kanboard.net/project/1
Click on the link for 1 closed tasks.
It will bring you to the page mentioned in the issue.
Not sure what I should see here.
Secondly the docs state (http://kanboard.net/documentation/closing-tasks)
that "When a task is closed, they are hidden from the board. However, you can always access to the list of closed tasks from the board menu Board > Actions > Completed tasks."
I cannot see this particular option anywhere in the current stable release build.
Hope that helps
Conor

The link was wrong and the documentation not updated. It's now fixed in the development branch.
To see closed tasks, just use the filter dropdown next to a search form and choose "closed tasks".
Thanks to report this issue.


Azure - Authenticator

Which version of MSAL Go are you using?
Note that to get help, you need to run the latest version.

Where is the issue?

Public client

[ ] Device code flow
[ ] Username/Password (ROPC grant)
[ ] Authorization code flow

Confidential client

[ ] Authorization code flow
[ ] Client credentials:

[ ] client secret
[ ] client certificate

Token cache serialization

[ ] In-memory cache

Other (please describe)

Is this a new or an existing app?

Actual behavior
A clear and concise description of what happens, e.g. an exception is thrown, UI freezes.
Possible solution

Additional context / logs / screenshots
Add any other context about the problem here, such as logs and screenshots.
Documentation related to component

Please check all that apply

[ ] typo
[ ] documentation doesn't exist
[ ] documentation needs clarification
[ ] error(s) in the example
[ ] needs an example

Description of the issue

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...].
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...].
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@Jyliew94 I'm not seeing any content outside of the issue template, going to close, but please reopen with necessary info. Thanks!


Lower minimum Python version

Checklist

[X] I added a descriptive title
[X] I searched open requests and couldn't find a duplicate

What is the idea?
To prepare for life as a conda-build dependency, we may need to support Python 3.7 or 3.8 minimum, by removing a handful of Python 3.9+ features used in the code.
Although conda-build does not necessarily have to run on the same version of Python the package is compiled for.
Also check that sqlite is compiled appropriately in conda's version of Python 3.7+
Why is this needed?
No response
What should happen?
No response
Additional Context
No response

Tested in 3.7