Also check for shortLivedToken when signing in with shortLivedAuthToken

cc @NikkiWines
Fixed Issues
$ https://github.com/Expensify/App/issues/13894
PROPOSAL: N/a
Tests
I couldn't directly test this flow locally, as I cannot build the old app locally. I tested that the flow still works by updating the parameter name in the url of an old app transition, and the following steps to confirm that existing transitions still work.
Desktop web

Signed into OldDot
Made a new workspace
verified I was transitioned with no issues

MWeb

Signed into OldDot
Selected Set up my company for free
Verified I was transitioned with no issue

[x] Verify that no errors appear in the JS console

Offline tests
N/a, can only transition online as it logs you in
QA Steps

Open the OldDot mobile app and log in with an account that has a existing workspace policy
Verify the Use Staging Server switch is on
Navigate to "Settings" and tap on "View all" on the policies section
Tap on the "Group" tab
Tap on the "Edit" button next to a Workspace
Tap on the "Current Plan" option inside the workspace settings
Verify that the workspace loads on NewDot with no issue

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/22447860/210904334-8d0c1c36-adb0-41de-ad08-42c41167e85a.mp4

Mobile Web - Chrome
https://user-images.githubusercontent.com/22447860/210905325-46bb1907-d99d-40e3-82af-6134d1d5661b.mp4

Mobile Web - Safari
https://user-images.githubusercontent.com/22447860/210904072-0ae0424e-59b8-4224-9031-4cb06d71aa5f.mp4

Desktop
N/A We do not transition into the desktop

iOS
N/A We do not transition into the mobile apps

Android
N/A We do not transition into the mobile apps

Updated to fix the lint error.

@alex-mechler since we're doing an oldApp release fairly soon, how do you feel about updating this in Mobile-Expensify so that we can eventually only have to check on value, not both?

Is the new mobile release going to force people to update? If it does not, people still might be using the old version of the app, in which case we will still have to support both

Fair... eventually yes they will be forced to update because we will move to passwordless authentication across the board.

Fair enough, we can update it there, since we are releasing anyways. Might have to keep an eye on adoption numbers before we pull the plug on checking both, as people still signed in to the app won't have to update. It wouldn't hurt to update there, I'll get a PR up

Nevertheless, this PR should be merged to support current version of OldDot mobile app, right?

Correct, this needs to be merged so that the oldApp transitions are fixed for now, as we're not quite sure yet when the next update for oldApp will be

Yup, we still do want this to support old versions of the mobile app. Added proptypes

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Discussion here. We are safe to remove the deploy blocker label since these are meaningless changes and were likely introduced here

🚀 Deployed to staging by @stitesExpensify in version: 1.2.52-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.2.52-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


webapp:Get-AzResource lookup on Azure App Service does not return accurate NetFrameworkVersion

When assigning a variable to this:
$enumAppService = Get-AzResource -ResourceGroupName $resName -ResourceType Microsoft.Web/sites/config -ResourceName $website.Name -ApiVersion 2018-02-01
And then writing to screen like this:
Write-host $enumAppService.Properties.NetFrameworkVersion
The output is always v4.0 (this may align to what is seen via resource.azure.com). However, this is inaccurate as a view of the resource on Azure Portal reflects the right version (e.g. v4.5). Also, when using the more recent "-ApiVersion 2019-04-01" as part of the variable the issue is not resolved.
Please advise and correct this as appropriate.

Get-Module
ModuleType Version    Name                                ExportedCommands

Script     1.6.0      Az.Accounts                         {Add-AzEnvironment, Clear-AzContext, Clear-AzDefault, Connect-AzAccount...}
Script     1.6.0      Az.Resources                        {Add-AzADGroupMember, Export-AzResourceGroup, Get-AzADAppCredential, Get-AzADApplication...}
Script     1.3.0      Az.Websites                         {Edit-AzWebAppBackupConfiguration, Enter-AzWebAppContainerPSSession, Get-AzAppServicePlan, Get-AzAppServicePlanMetric...}
Script     <IP_ADDRESS>    ISE                                 {Get-IseSnippet, Import-IseSnippet, New-IseSnippet}
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Management     {Add-Computer, Add-Content, Checkpoint-Computer, Clear-Content...}
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Security       {ConvertFrom-SecureString, ConvertTo-SecureString, Get-Acl, Get-AuthenticodeSignature...}
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Utility        {Add-Member, Add-Type, Clear-Variable, Compare-Object...}
Manifest   <IP_ADDRESS>    Microsoft.WSMan.Management          {Connect-WSMan, Disable-WSManCredSSP, Disconnect-WSMan, Enable-WSManCredSSP...}

@panchagnula , Can we know what change need in swagger? if no and it is only need change in service side. suggest to move this issue back to Azure/azure-powershell , if yes. can you specify something more detail? Thanks


Implement diplotype clustering and refactor haplotype clustering

In this PR, we implement a plot_diplotype_clustering() function, which works exactly like plot_haplotype_clustering(), except it works on diplotypes rather than haplotypes.
This PR works towards #361, we aim to make an 'advanced' version of this plotting function which plots amino acid mutation heatmap below it, as well as sample heterozygosity and possibly CNV copy number and diplotype cluster assignments. For now, we start with the simple dendrogram itself.
I have added (Alistairs) functions into util.py which calculate pairwise distances for diplotypes. As far as I can tell, these functions were marginally different to the existing biallelic diplotype functions, so i have added new multiallelic ones. It might be that this is not quite necessary, please check @alimanfoo :)

CodeCov is failing because I have only made a notebook and not tests. This is the way plot_haplotype_clustering() works.
Should i write tests...? I guess we only started using codecov after the haplotype clustering functions were implemented.

hey guys @ahernank @leehart @alimanfoo , I just saw the discussion in #506 around the problem in random_region_str() with regions that exceed the max contig size. I had the same issue, so just to say that I have already fixed it in this PR.
Changing title of PR accordingly.

Cool, thanks @sanjaynagi 👍
Resolves #509

Beautiful, thanks @sanjaynagi :) Merging...


New drop-down selection is appended, but it should replace the old one

New drop-down selection is appended, but it should replace the old one (DP-610).

The code commend about the test for the change looks redundant to me. Otherwise everything is fine.


[x] website builds and runs in production - for information on how to test locally go here.

Description

Reviewed and improved the Appsody Environment Variables webpage to make it more accurate and easily consumable.
Related Issues
Fixes: #448

The CSS seems fine to me, while it does change all the tables on the site, the sizing is fine and works well on both tables we have currently (as the first columns tend to be pretty narrow content wise).

Another issue with this PR, is that to get a newline within a table cell in markdown, I am having to use

I have been trialling different table format/columns. Please let me know which one you think is best.

This one is the "original" where we show requirements using * and **

This one is when we merge the examples and descriptions columns (I quickly gave up on this as the description table cells were huge)

This one is when we merge the default and description columns and show requirements through another column

These are mockups, done up by @KyeMaloy97, to show requirements as badges (I have not tried implementing this yet)
a.
b.

Personally, I like merging the default and descriptions columns (like in 3- keeping the examples column separate) but with showing requirements in the format in 4a, with the badge designs in 4b.

Without too much thought:

3 columns definitely better than 4
I'm a little cautious over the use of the labels for accessibility reasons
The colours for the labels are, I guess, taken from the logo rather than introducing new colours to the site?
Tables are good for conveying information in some circumstances. When you start to struggle to include all the information you need in a readable format, you sometimes have to ask yourself if there is a better way of conveying the information. I'm not suggesting a table is wrong in this case, but you are possibly on the limits.

I agree with 3 columns, as 4 isn't easy to read in any of the examples.
Personally, I agree with Sandy and like the merging of the default and descriptions columns (like in 3 - keeping the examples column separate).
IF we go with that it leaves us one column to represent the Environment Variable (with/without its format definition) AND an indicator of whether it's mandatory, optional or recommended...

@skoh7645 / @helenmasters
Esther and I just discussed the table format.

3 columns much better than 2
Using italics for mandatory, optional underneath the variable name seems sensible
We both think that the full format of the variable should be shown in the first column so that users are clear on the syntax. VARIABLE=[true|false] or VARIABLE=<option>

@skoh7645 - when you view the file, there are a few entries that have gone bad.


fix: add workaround for itemspanelroot changes

replaced by #1288

⚠⚠ The build 147905 has failed on Uno Toolkit - CI.


iOS didReceiveRemoteNotification

Hi there!
Open event is not fired. After debugging a little while i figured out that
- (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)notification

not fired, while getting remote notification but

- (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)notification
fetchCompletionHandler:(void (^)(UIBackgroundFetchResult))completionHandler

fired, but i cannot call [RCTOneSignal didReceiveRemoteNotification:notification] in this method to pass notification object further to js thread.

iOS 10. React Native 0.44.

@hose314 any progress on this?

@zakster12 yeap but with hacks and patchs
In order to handle push notifications i'm using this one but it causes an issue with android and i've made a patch on it
yeap, i know, not a best practice so waiting for some suggestion


Ported to new consistency policies API from C client 4.6.

Also removes AEROSPIKE_ERR_LARGE_ITEM_NOT_FOUND  which was removed from C client library 4.6.

Hello,
This can be merged if you are willing to provide the appropriate documentation changes in doc/phpdoc/aerospike.doc, and tests that exercise your new changes in src/tests.
Thanks again for the contribution.

Thanks.
I'll add new commits, the I'll get to it.

Added docs and updated test files.


Added quick input action to toggle between preferred color themes

This PR fixes #151466
This PR adds a new quick input action that allows to select from the list of the four preferred color themes (Light, High-Contrast Light, Dark and High-Contrast Dark).
Themes are read from a new function WorkbenchThemeService.getPreferredColorThemes.

Thank you for the feedback!
You're right, I went a little bit out of scope but since there are actually four preferred themes I though it would make sense to let you quickly switch between all of them.
However, this adds an extra step for the user (selecting the theme).
If you think it would be more beneficial to just toggle between dark and light with the first command I can easily convert the current code to get that behavior.

Let's ask @AllanDaemon who filed the original issue (I just realised it's not you)
@AllanDaemon from reading your issue I was thinking of a command that doesn't need to show a quick pick dialog, but just toggles the theme to the opposite color scheme. So if the current theme is a light theme, it would switch to the preferred dark theme. If it's a dark high contrast theme, it would go to the preferred light high contrast theme.
What do you think of that?

I was thinking of a command that doesn't need to show a quick pick dialog, but just toggles the theme to the opposite color scheme. So if the current theme is a light theme, it would switch to the preferred dark theme. If it's a dark high contrast theme, it would go to the preferred light high contrast theme.

Exactly. So I can assign a keybind and switch it as fast as a shortcut, just like other implementations.
While this PR doesn't implement this, it's an advancement regarding this issue, improving the today's main reason of pain, and I see it filling up others user cases gaps.

I can rename the implemented feature to something like Switch preferred theme and add a new proper Toggle preferred theme which toggles between light and dark, by keeping whether it's hc or not.
Does it make sense?

I'm ok with adding the toggle light/dark theme command, but I don't want add the one with the quick pick.


Feature - SonarQube HTML report parser

DefectDojo can import HTML report scan from SonarQube.
SonarQube Website
SonarQube Github

Thanks for the PR @AdrienGuillerme. Would you mind submitting this to the dev branch instead? Also, would you be able to submit a sample file for testing purposes? The repo for that is here.

Ok, I will do that.


Vendors, set nano skill command + serverside command issues fixed

Added basic shopkeeper functions, a player can buy the preset 3 items (cannonbolt set), all shopkeepers have the same items atm (need to check the shopkeeper tabledata), setting itemprice is something I didn't figure out.
Added set nano skill command
Implemented a switch for certain commands like health/taros/fusionmatter etc to be handled on the serverside aswell

As an initial implementation for vendors, LGTM.
Making P_CL2FE_GM_REQ_PC_SET_VALUE take effect serverside is a nice add as well.


Successful writes increment write error statistics incorrectly, fail to increment write success statistics. [BACKPORT 1.8]

Backport
https://github.com/influxdata/influxdb/issues/20098
to 1.8

PR approved and merged


Enable aging of the bufferpool

This is the final step to enable increasing the asset cache sizes. The asset cache is bufferpool backed which meant we needed to prune out entries that haven't been used in a while.
Also includes a change to LRUCache to drive the maintenance of LRU from outside of the class so we don't have to make it IDisposable.

Passes my review.

Merged.


Autocomplete when cursor is in table doesn't give properties

Consider the following situation:
type Properties = {
    TextScaled: boolean,
    Text: string
}

local function create(props: Properties)
end

create({
    |
})

If autocompletion is triggered, it is treated as a general expression and properties are not included.
If autocompletion is triggered after typing starts, then it is correct
create({
    T|
})

Is there any chance this can be added? Auto-completion in table literals without prior typing is super helpful. This works in LuaLS, but I would prefer Luau types because in most other aspects the Luau type system seems to be way more elaborate.
@JohnnyMorganz Is this a missing feature in Luau or in Luau Language Server?

Is this a missing feature in Luau or in Luau Language Server?

The former, we rely on Luau Analysis's autocomplete support directly in the language server


Sister Module

This really isn't a issue, but I wanted to let you know that this module was the inspiration for https://github.com/arineng/file_header.  The major difference is that we do not require the ripienaar/puppet-module-data dependency module.

@smbambling Cool.  I'll check out the other project.  I'm still a unsure if using the ripienaar/puppet-module-data was a "best practice" or not.  After some testing at work, it seems that it doesn't work very well with some older puppet masters.  In fact I'm not convinced that heira is worth the trouble in general.
I may be reworking the it to remove the module data stuff.
Anyway, I'm glad you found it useful.  Thanks for the note.

Yeah module-data is a really neat idea...but seems like its still young.  Your more then welcome to fork what we have it doesn't require hiera but can leverage it if needed.


[v2] Explain that it is live-reloadable

Woohoo!

Hello @chcokr, except for the mixins pattern for which I have some doubts, the other one, relying on proper props techniques etc. are and were already live-reloadable through react-transform. I am running tests currently to see if there are some rough edges remaining.


Cannot (easily) build huge images.

My Docker images are huge, and I keep getting out of space errors when I try to build with the basic docker2singularity commandline.
I know I can probably (on my own machine anyway) allocate more space for my Docker VM so it would have a larger /tmp slice, but that's not always possible.
This has lead me to write a bash script to setup various mountpoints  for docker2singularity.
It would be nice if some of these things could be better documented, it would also be nice if the docker2singularity.sh script had more control over where its temporary directories go.
Here is the most important part of what I have so far, but it still doesn't work.
docker run -v /var/run/docker.sock:/var/run/docker.sock \
-v ${OUTPUT_DIRECTORY}:/output \
-v ${TMP_FOR_BUILD}:/tmp -e SINGULARITY_TMPDIR=/tmp/buildtmp \
-v ${TMP_FOR_BUILD}/singcache:/tmp/singcache -e SINGULARITY_CACHEDIR=/tmp/singcache \
-v ${TMP_FOR_BUILD}/tmpother:/tmp/tmpother -e TMP=/tmp/tmpother -e TEMP=/tmp/tmpother -e TEMPDIR=/tmp/tmpother \
--privileged -t --rm \
quay.io/singularity/docker2singularity \
${BUILD_IMAGE}

It’s generated via /tmp in the image you have total control of binding that somewhere on your host, as you do with the output folder. I’m not sure what you are asking or suggesting but if you test a new variable in the script that you think would be useful happy to discuss.
And generally I’d recommend these days pulling Docker images directly with Singularity - this script was made before that was supported.

I'll see if I can build the image on the machine I actually want to run on.

Sure thing! And please try singularity pull docker://<docker-uri> it really is intended for this use case.

Looks like my sysadmins have not included mksquashfs for us.
While making image from oci registry: error fetching image to cache: while building SIF from layers: unable to create new build: while searching for mksquashfs: exec: "mksquashfs": executable file not found in $PATH

I know I can run singularity images on the cluster, but I have trouble building them there. A reason I had wanted to build them from within a Docker container is to make it easier for future TAs (Teaching Assistants) to deploy newer containers without forcing them to do much installation on their local machines.

Could I build a singularity image from inside a Singularity image?

Ug, I'm sorry about that! I would reach out to them and report the error and have a conversation about Singularity. This is a conversation people were having years ago (2016 / 2017) and I'm sorry that your cluster doesn't seem to have real support for it. If they say that it's installed, then perhaps ask them how you can pull an image from Docker Hub without that? Perhaps they expect you to pull locally, and then scp onto the cluster to use? It's annoying but it could possibly work.

Could I build a Singularity image from inside a Singularity image?

You could try it, but at least when I tried a few years back, it won't work because of the permissions required.
If the sysadmins aren't supportive of Singularity then you can ask them about Podman, which is another rootless container technology (more like docker) that is being better embraced at national labs. If they are dismissive to both then you probably need to escalate to someone in management there or a higher up in a department because not being able to run containers on a cluster in 2022 is really not acceptable.

Well, it looks like one of the older singularity installations on the cluster can build, so I've got my issues sorted.
Thank you.


possibilty for max parallelism

importing many files at the same time results in having them all imported at the same time. Having only a few imported at the same time would make the progress easier to track (and maybe some performance improvements?).

Max Parallelism has been implemented as part of #12. See the --parallelism option.


Tabs not working

Hey, great work so far!
I'm able to use the fun tab and the misc tab however the scripts, fuse and custom tabs don't seem to be working. Is that intentional or a bug? Hope to see them working soon! :)

Hey can you fix this for the latest version @Juanru9


Add YJS collaboration plugin

Background
This PR adds YJS collaboration plugin that is used in the react version. Using the YJS server this allows multiple editors to collaborate on a document.
Added the example editor that can be used to run and test the feature in docs.
Demo
https://github.com/wobsoriano/lexical-vue/assets/10382614/5bddb31d-a0c8-457b-a96b-26273cce01a0

Resolves #7

Reviewing this tonight. Should probably be done this weekend. I'll let you guys know if I encounter any issues :)

Awesome, thanks! We'll be around!


How to use Nuxt with Zeit.co's pkg

Greetings,
This is mainly a question to see if anyone or if there is a plan to support pkg.
https://github.com/zeit/pkg

No in our plan, should talk about that on gitter ;)

Understandable , thank you
On Thu, Jun 29, 2017, 4:54 AM Alexandre Chopin<EMAIL_ADDRESS>wrote:

No in our plan, should talk about that on gitter ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nuxt/nuxt.js/issues/927#issuecomment-311944450, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFFsSX_a12e9s-hAXQP80Gc9cc5Pj02Qks5sI5BvgaJpZM4N-6C3
.

--
-V/R
Ryan Watts

@rwatts3 I can help you working on integration after 1.0 release :) Ping me please to remind.

Will do thank you .
On Thu, Jun 29, 2017, 8:48 AM Pooya Parsa<EMAIL_ADDRESS>wrote:

@rwatts3 https://github.com/rwatts3 I can help you working on
integration after 1.0 release :) Ping me please to remind.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nuxt/nuxt.js/issues/927#issuecomment-312008743, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFFsSRWrJapDsuELoN8Ll49HiRsFFVslks5sI8dXgaJpZM4N-6C3
.

--
-V/R
Ryan Watts

Good news! PKG is now working fine with nuxt-start This screenshot is just an experimental one
but it will be available to be used without no need to configuration!

this is great thank you for the update.

what directory are you pointing your bin file to ?

I point it to a simple custom script using nuxt-start indeed. Will publish at when was more stable.

@pi0 is this something that ever got published anywhere? I'm curious to give pkg a shot but don't now how to use it with nuxt build.


docs: setting up local environment

Related: https://github.com/customerio/amiapp-reactnative/pull/42, https://github.com/customerio/mobile/pull/6
Changes:

Added docs for testing SDK locally (Linked with Ami App for complete details)
Updated README to align with other repositories

NOTE: I'll update any branch specific links to default just before merging

Merging this, if more changes are needed, we can cover in a separate PR.


fix CI flkake with upterm [DO NOT MERGE]

Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata

Fixes #[Link to Issue]

addressed in #1280


glTF MaterialX Converter integration

Summary

Adds the external converter to allows support for bidirectional transfer between glTF and MaterialX for materials. This is embedded as part of MaterialXRender instead of a separate module.
Adds Python a wrapper and a Python utility script mxgltf.py
Adds save / load to / from glTF in MaterialX Viewer and MaterialX Graph Editor.

Caveats

Does not include any tools to perform shader translation nor baking . This can be done as a separate pre-process using the MaterialX Viewer or other means.

@emackey , This is the PR to add glTF<->MTLX converter support into the Khronos main branch.
This is sync'ed against the release of 1.38.8. If this is agreed to be merged after review, I will add a Khronos 1.38.8 tag from which a downloadable release can be created.

What aspects of this require work? What is blocking this?

Hi @fire . I need to work out some logistics for this.
I will need to close this PR until this is resolved.


Swap the POC for TRA in PowerToys

I think this swaps the POC for TRA in PowerToys.
I don't think I have enough disk space left on this machine currently to actually build PowerToys all up (🙃) so I'm gonna see what CI comes up with.

there it is. Fixed. Tested. Ready to merge


Rust api

This PR addresses part of the public Bertie API as part of issue #6.
Type of change

[x] New feature

Motivation and Context
This PR introduces a stream module into Bertie that allows using the Bertie client and server from Rust with a blocking Read/Write API. See the tests for examples.

closing in favour of #77


Suggestion: User Blacklist

Maintain a local list of users that are not allowed to use the bot. Alternatively check for a configurable role that disallows use of  the bot.
DJ and Admin status should override this blacklist.

You can effectively blacklist users on a per-server basis by setting a text or voice channel (settc/setvc), and then preventing that user (or a role) from sending messages or joining the channel, respectively.


DISCUSSION: Effects during Template Creation

Hi Martin,
during Template Creation (modifying your "Martin Template.pptx" to my templates)
I have some questions that I do not understand.
If you have a quick idea its fine, but I will investigate the other stuff anyway.

[ ] Font Overwrite: The font sometimes ignores the defined settings in the master-slide
[ ] Text Position Overwrite in Heading Slide (Level ##): The textbox will be moved to your template position even if it takes my settings
[ ] Table-Seperator still showing in pptx

Zum Table-Seperator: Commandozeile meldet    5     Percentile Goal Transaction Ending Buckets             --> 16 x 4 table without heading

Let me just comment on the separator line. It looks like it’s not being recognised as the second line so not being used to align things or set widths.
Can you send me a snippet showing what the beginning of the table looks like?
Note: The width thing is not standard Markdown Tables semantic. (It’s fine syntax-wise.)

yep. I will send it from my windows machine once that is running again

Is your Windows machine running again? ... :-)

Closing for now. Reopen if needed.


can I call function and pass selected date in my .ts file

(dateTimePickerChange)="setMoment($event)"

It works!!!!
Thanks alot :) Cheers


fixed issues in README.md

Changed the structure of two sentences to avoid a passive voice to make it easier for readers to understand.

I agree with the second change, but with the first change, I think the previous sentence is better. Avoiding a passive voice in that case kind of breaks contingency with the previous sentence. The reader immediately understands that you're talking about Godot. But with this change, you're talking about Godot, then you're talking about the foundation----wait, no you're talking about Godot.


✨ dropdown filters for post type, author, and tag

refs https://github.com/TryGhost/Ghost/issues/7860

removes post type filter links
adds dropdown filters for post type, author, and tag
replaces custom refresh on query params change with Ember's standard refreshModel config

TODO:

[x] update loading screen state to match new filters
[x] update + add filter tests

This should be GTG now. The tests could do with being improved/extended but the basics are tested.

Coverage increased (+0.2%) to 75.131% when pulling 96737dc841b2e2f509d9f31640a1b2906d81fbf0 on kevinansfield:dropdown-filters into c2a69ca32cfe8b59c6ef4d38463670136b84887e on TryGhost:master.

Travis is 💚 now. I'd missed some test updates 🙈

👍 will review asap


NVIDIA Kepler results (GTX 760M, driver version 419.67)

PerfTest
To select adapter, use: PerfTest.exe [ADAPTER_INDEX]
Adapters found:
0: NVIDIA GeForce GTX 760M
1: Intel(R) HD Graphics 4600
2: Microsoft Basic Render Driver
Using adapter 0
Running 30 warm-up frames and 30 benchmark frames:
.............................XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
Performance compared to Buffer.Load random
Buffer.Load uniform: 3.073ms 62.440x
Buffer.Load linear: 195.662ms 0.981x
Buffer.Load random: 197.022ms 0.974x
Buffer.Load uniform: 3.227ms 59.465x
Buffer.Load linear: 195.179ms 0.983x
Buffer.Load random: 196.785ms 0.975x
Buffer.Load uniform: 3.598ms 53.329x
Buffer.Load linear: 193.676ms 0.991x
Buffer.Load random: 191.866ms 1.000x
Buffer.Load uniform: 3.031ms 63.308x
Buffer.Load linear: 195.622ms 0.981x
Buffer.Load random: 197.009ms 0.974x
Buffer.Load uniform: 3.025ms 63.434x
Buffer.Load linear: 195.135ms 0.983x
Buffer.Load random: 196.860ms 0.975x
Buffer.Load uniform: 3.443ms 55.728x
Buffer.Load linear: 193.744ms 0.990x
Buffer.Load random: 191.929ms 1.000x
Buffer.Load uniform: 2.970ms 64.605x
Buffer.Load linear: 195.751ms 0.980x
Buffer.Load random: 197.141ms 0.973x
Buffer.Load uniform: 3.175ms 60.425x
Buffer.Load linear: 195.351ms 0.982x
Buffer.Load random: 196.911ms 0.974x
Buffer.Load uniform: 3.621ms 52.985x
Buffer.Load linear: 350.658ms 0.547x
Buffer.Load random: 350.633ms 0.547x
ByteAddressBuffer.Load uniform: 3.758ms 51.055x
ByteAddressBuffer.Load linear: 191.898ms 1.000x
ByteAddressBuffer.Load random: 216.928ms 0.884x
ByteAddressBuffer.Load2 uniform: 4.682ms 40.977x
ByteAddressBuffer.Load2 linear: 390.852ms 0.491x
ByteAddressBuffer.Load2 random: 442.053ms 0.434x
ByteAddressBuffer.Load3 uniform: 572.822ms 0.335x
ByteAddressBuffer.Load3 linear: 568.316ms 0.338x
ByteAddressBuffer.Load3 random: 570.361ms 0.336x
ByteAddressBuffer.Load4 uniform: 752.691ms 0.255x
ByteAddressBuffer.Load4 linear: 758.795ms 0.253x
ByteAddressBuffer.Load4 random: 763.638ms 0.251x
ByteAddressBuffer.Load2 unaligned uniform: 4.199ms 45.692x
ByteAddressBuffer.Load2 unaligned linear: 391.542ms 0.490x
ByteAddressBuffer.Load2 unaligned random: 442.574ms 0.434x
ByteAddressBuffer.Load4 unaligned uniform: 752.793ms 0.255x
ByteAddressBuffer.Load4 unaligned linear: 758.698ms 0.253x
ByteAddressBuffer.Load4 unaligned random: 763.679ms 0.251x
StructuredBuffer.Load uniform: 3.103ms 61.827x
StructuredBuffer.Load linear: 195.674ms 0.981x
StructuredBuffer.Load random: 196.991ms 0.974x
StructuredBuffer.Load uniform: 3.301ms 58.120x
StructuredBuffer.Load linear: 195.167ms 0.983x
StructuredBuffer.Load random: 196.749ms 0.975x
StructuredBuffer.Load uniform: 3.846ms 49.882x
StructuredBuffer.Load linear: 350.461ms 0.547x
StructuredBuffer.Load random: 350.494ms 0.547x
cbuffer{float4} load uniform: 4.478ms 42.844x
cbuffer{float4} load linear: 9217.404ms 0.021x
cbuffer{float4} load random: 3333.476ms 0.058x
Texture2D.Load uniform: 3.384ms 56.695x
Texture2D.Load linear: 202.197ms 0.949x
Texture2D.Load random: 204.327ms 0.939x
Texture2D.Load uniform: 3.731ms 51.424x
Texture2D.Load linear: 198.542ms 0.966x
Texture2D.Load random: 211.881ms 0.906x
Texture2D.Load uniform: 4.306ms 44.558x
Texture2D.Load linear: 196.088ms 0.978x
Texture2D.Load random: 195.847ms 0.980x
Texture2D.Load uniform: 3.419ms 56.118x
Texture2D.Load linear: 202.264ms 0.949x
Texture2D.Load random: 204.311ms 0.939x
Texture2D.Load uniform: 3.673ms 52.243x
Texture2D.Load linear: 198.553ms 0.966x
Texture2D.Load random: 211.917ms 0.905x
Texture2D.Load uniform: 4.115ms 46.626x
Texture2D.Load linear: 196.084ms 0.978x
Texture2D.Load random: 350.561ms 0.547x
Texture2D.Load uniform: 3.517ms 54.547x
Texture2D.Load linear: 202.339ms 0.948x
Texture2D.Load random: 204.392ms 0.939x
Texture2D.Load uniform: 3.705ms 51.783x
Texture2D.Load linear: 198.537ms 0.966x
Texture2D.Load random: 350.591ms 0.547x
Texture2D.Load uniform: 4.028ms 47.637x
Texture2D.Load linear: 350.589ms 0.547x
Texture2D.Load random: 350.519ms 0.547x

Some thoughts and comparison with newer NVIDIA architectures

Results shows that Volta and Turing uses read-write LSU pipeline (which is typically used for UAV and shared mem) for untyped loads (both raw and structured buffers) which is beneficial due to more LSU count compared with TMU and shorter latency. LSUs now backed by R/W L1$ (similar to Fermi), so read-only TMU pipeline has no advantages anymore.
Typed loads seems to still uses TMU despite Maxwell introduced format conversion hardware for UAV loads. Probably not all formats supported by LSU (e.g. sRGB or shared exp), so driver has to stick with TMU for typed loads since it can't know upfront which format will be used and whether it is supported by LSU. On the other hand it can be beneficial to use TMUs in some situations: since NVIDIA GPUs has separated LSU and TMU pipelines it can presumably be utilized simultaneously, so in UAV or shared memory intensive workloads using dormant TMU for read-only SRV access can be free.

Maxwell and Pascal doesn't have RW L1$ so tex L1$ offers advantages for TMU over LSU. Apparently TMU used for structured buffer loads while LSU now used for raw buffers (results from previous test version with older drivers suggested TMU for raw buffers too). Maybe this discrepancy is due to inability of NVIDIA hardware to perform fullspeed 64-bit unaligned fetches (alignment in not guaranteed for raw buffers). On the other hand accesses to structured buffers are aligned and 64-bit loads runs at full speed so driver decided to take advantage of texture L1$. It seems that decision to use LSU without L1$ for raw buffers results in better performance that can be expected from TMU based on unit count except for random Load4 which is slower than expected TMU theoretical rate of 1/4 (apparently lack of L1$ comes out in this case).

Kepler uses TMU for all SRV loads. Maybe NVIDIA driver team decided that read-only tex L1$ gives more advantages for this architecture but another explanation of this difference compared with Maxwell and Pascal which has similar cache hierarchy is that Kepler has fixed 64 slots for UAVs (it supports unlimited descriptor tables for SRVs only). Maxwell expanded descriptor table approach for UAVs so it can use LSU for untyped SRV access if desired.
My own experiments showed that UAV loads can be faster then SRV on Kepler in some cases (it strongly depends on various factors including driver version) but generally SRV offers more predictable and consistent performance.
It's notable that uniform load optimization works for 1d and 2d raw buffer loads but disabled for 3d and 4d ones. Maybe due to GPR pressure?

RGB32 loads
I've also tried RGB32 (float3) format for typed buffer loads and textures. Results was different from my previous experiments. Current test configuration shows 2/3 rate (somewhat strange) for buffers and linear texture access and 1/3 for random texture reads. My previous experiments provided 1/3 rate for linear buffer load (similar to raw buffer Load3) and somewhat slower for random load. 1/3 rate seemed reasonable - it is consistent with assumption than NVIDIA TMU hardware falls back to 32-bit fetches on unaligned access (otherwise it would be expected 1/2 rate as with RGBA32). I played with test configuration a little - tune thread group size and loop iteration count, and got different results - near 1/3 or much slower in some cases. Maybe cache bank conflicts start to appear.
Such dependence on test configuration prompted the idea of driver optimizations (maybe similar to uniform load optimization) - 64 or 128 bit fetches combined to assemble 96 bit result while sharing data with other threads or loop iteration. It's remarkable that 2/3 rate achieved when both thread group size and loop iteration count is 256. But this assumption can be wrong and TMU hardware able to offer 2/3 rate for RGGB32 format and its drop to 1/3 or slower in some conditions is because of cache bank conflicts or other reasons.

Thanks! Added Kepler results. This confirms that Nvidia's uniform load driver optimization affects kepler too.


Webrtc push stream minimum bit rate

Webrtc dynamically calculates the bit rate of the push stream according to the bandwidth. At the beginning of the push stream, the picture will be blurred, and as the real-time bit rate increases, the picture will become clearer. But I still hope webrTC will have good video resolution in the first few seconds after the stream is pushed. Could you please set SDP to set the minimum bit rate?
Device: pc
OS: windows11
Browser：Google Chrome 96.0.4664.45
OvenMediaEngine Version: v0.12.7
push tool：OvenLiveKit-Web v1.0.2

https://github.com/AirenSoft/OvenMediaEngine/issues/627


AWS: Add context to the ENI metadata call

Hi,
Following this pull-request https://github.com/cilium/cilium/pull/15828 and thanks to @christarazi's review, we may want to add context when the AWS metadata API is called .At least that would be wise to add a timeout in order to avoid hanging while waiting for an answer.
Currently we just have
func newClient() (*imds.Client, error) {
	cfg, err := config.LoadDefaultConfig(context.TODO())

This issue hasn't seen any comment for over 3 years, closing for lack of interest.


Roll Flutter Engine from 78f9c6897118 to 3287e2b362fc (2 revisions)

https://github.com/flutter/engine/compare/78f9c6897118...3287e2b362fc
2023-03-28<EMAIL_ADDRESS>[Impeller] support half precision uniforms and half precision samplers (flutter/engine#40590)
2023-03-28<EMAIL_ADDRESS>[Impeller] Allow metal shaders to compile through SPIR-V with openGL semantics. (flutter/engine#40616)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Feature/mock-login

OPH-77

This landing page is something we talked about with Dieter, I'm not sure whether he already implemented it into his "design overhaul" but it's certainly still in discussion which page unauthenticated users should first see.
For now, I've added a ticket to the jira backlog


Add news and coming soon section

can i get assign to it?

@theSumeetGithub go ahead.
But are you sure this section will look good at the bottom?
Also, follow the theme of the website use red and black color.

ohk  i wll be making them as per the website theme

@theSumeetGithub are you working on this?

Please assign me this issue under LGMSOC 21

Can I work on this issue? I think it will be really nice by addding news and coming soon section under the movie specifications @QAZIMAAZARSHAD

Can I work on this issue? I think it will be really nice by addding news and coming soon section under the movie specifications @QAZIMAAZARSHAD

Other issues are already assigned to you first resolve them.

Can I work on this issue under LGMSOC? @QAZIMAAZARSHAD


"Mădăras, Homorog, Ianoșda, Marțihaz" are villages in "Mădăras" commune, "BIHOR" county

Description
When an user search a location, this appear in the drop-down menu
according to the law

Precondition
The website is up an running.
Empty the search bar after every step

Steps 1
Write "Mădăras"
Expected result
In the drop down menu you find "Mădăras, BIHOR(Mădăras)"
Test Data
Mădăras

Steps 2
Write "Homorog"
Expected result
In the drop down menu you find "Homorog, BIHOR(Mădăras)"
Test Data
Homorog

Steps 3
Write "Ianoșda"
Expected result
In the drop down menu you find "Ianoșda, BIHOR(Mădăras)"
Test Data
Ianoșda

Steps 4
Write "Marțihaz"
Expected result
In the drop down menu you find "Marțihaz, BIHOR(Mădăras)"
Test Data
Marțihaz


Question: is generating API spec from fastapi code intentional?

Question
Is generating API spec from fastapi code intentional?
Further Information
TL;DR
Based on my experience, having a spec and then generating data structures for a fairly complex protocol is a good way to go, because

In multi-language environment (or multi-service environment for that matter) you won't worry about API compatibility when deploying things
You can have different implementations of client/server

Why do I think those might be applicable

At some point of scaling you will need backend to be multiple services handling different workflows, written in different languages
At some point you will most probably will have multiple server instances be it the ones you host, vs the ones which want to be a part of your network, but deployed by another entity and those might be written in different languages.

I'm talking way far into the future. Why on Earth would I suggest it right now?
Based on my experience, the more mature the system is, the harder is to flip that, there are a lot of unknown unknowns out there and the requirements you have right now, will most probably change in the future and programming language is one of those things :)
The use-case I had in mind (the reason I though about it in the first place)
Really nice idea with apis and using file-system as an abstraction over the whole concept. Let's say I have an idea of integrating this into a project, which would gather some data, would have some fixed set of commands to operate over the data and send it to an aggregating server. I do have couple of problems:

I want this to be my private server (think private segment of the Internet, SyftBox in a nutshell a toolkit which allows me to build "Federated Networks", not sure if that's the right term, but basically I mean set of compute nodes with storage on which I can execute some commands)
I want this client to be part of the system, not an arbitrary binary with python running there (interpreter, plus all the libraries will be a costly thing, plus wrapping it around in a docker image...)

I know that in theory I can do a Rust client with fixed set of those APIs under a MB or two. I have no problem looking at the server OpenAPI and implementing client following that, I know that with my forked server it'll continue working, but might become painful if I want to connect to a public net and/or sync my fork. I'll have to update those things manually.
That's why I wanted to ask this question, before getting into implementation myself. After all, I think that the main value of a system software is a spec or API, there could be multiple implementations, but it's about capabilities and how to use it.
I hope that I'm not way to off from the whole concept and would love to hear your thoughts on this :)

Hey @uncleDecart,
We're still at a pretty early phase and we'll probably have many API changes that are not backwards compatible for the coming months. I think this is a great idea to add, once we are in a less experimental stage


core: fix broken stateroot storage

Store stateroot by DataMPTAux prefix instead of storing it by index only.
Costs me a lot...

Will be helpful for #2431.


Feature Request: Support for SwitchBot Blind Tilt

Problem
The current plugin don't have support for the SwitchBot Blind Tilt
Solution
Support of the product
Alternatives
No response
Additional context
No response

Duplicate of #649


Error (a bytes-like object is required, not 'str')

Hello, I'm having a problem with aes, every time I start debugging, I have an error saying that the key needs to be byte:

I followed all the steps in the example, but to no avail

why did you close it, I have the same question~


Next location not being persistent

The current next location for the mines isn't being persistently saved so its overlapping with restarts. The data needs to be stored in a file within private mines and then load it back up upon server start within a field in the main class or something and then save the current location back into the file for the next startup

Hopefully fixed with this patch  please report if it persists.


[ALLUXIO-1814] Don't cache to a worker which already has the block

https://alluxio.atlassian.net/browse/ALLUXIO-1814

Thanks for this fix. Could you add a unit test to cover it?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8911/
Test PASSed.

LGTM. Feel free to merge this, as I realized the test is not so straightforward to add, and therefore can be patched in a later PR.

LGTM


Resolutions in Ubi.ini must be specific

Right now, selecting a resolution from the list will set the same resolution in ubi.ini. However, Glide is limited to a strict set of resolutions, and setting it otherwise will cause the window to remain white.
The allowed resolutions are 320x200, 400x300, 512x384, 640x480, 800x600, 1024x768, 1280x1024, 1600x1200.
Obviously the dgVoodoo resolution can be set to whatever and it will output. I would check the width of the set resolution the ubi.ini resolution to the smallest one that is larger than that width (except maybe 1600x1200 as the loading bars look a little weird with that).

Fixed in 00b87e1f96ef8e1f2b04cab7b5ea0096b6f5c43f .


Fix documentation

Fix problems in the documentation related to the Erlang 19 migration.

What problems specifically? Also, we support Erlang 20 now.


Oracle does not support "REPLACE" query

I'm using CI 3.1.10 and when I run a db->replace I get a ORA-00900: invalid SQL statement.
I think that Oracle does not support "REPLACE" query

... and? We can't make Oracle have a REPLACE statement.

The driver doesn't raise an error like it does with ->last_id()

The driver doesn't do anything for last_id() either, the method simply doesn't exist.
You'll get a PHP error for last_id() because the method doesn't exist at all, while replace() exists in the Query Builder, which all drivers extend, so code executes and you get an SQL error instead. This is an implementation detail.

The oci8_driver.php has on line 439:
public function insert_id()
	{
		// not supported in oracle
		return $this->display_error('db_unsupported_function');
	}


Serialization property selection strategy

Currently the serializer only selects properties based on the generic type parameter supplied to the .Serialize<T>() method.
There should be an option to make this property selection more greedy by basing it on the type of object actually passed.  This would support subclass scenarios.

see branch feature/issue-84-greedy-serialization

To support this, the #type key will have to be included in serialization, just like during abstract/interface serialization.

A new serialization option is added for TypeNameSerializationBehavior: OnlyForAbstractions.  This will prevent the type name from being included if the generic parameter is not abstract, but the object being serialized is still of a derived type.

Added new serialization option OnlyExplicitProperties.  If true, only the properties defined by the type in the generic parameter will be serialized.  Otherwise all properties from the passed object will be serialized.


JSON-Syntax-Error when compiling "faq_de.json" and "faq.json"

In the above mentioned files a few closing parentheses are missing, which cause "gulp build" to fail.
[christopher@ArchDesktop cwa-website]$ gulp build
[11:41:39] Using gulpfile ~/Schreibtisch/cwa-website/gulpfile.js
[11:41:39] Starting 'build'...
[11:41:39] Starting 'pages'...
[11:41:39] Starting 'javascript'...
[11:41:39] Starting 'images'...
[11:41:39] Starting 'copy'...
[11:41:40] 'pages' errored after 89 ms
[11:41:40] SyntaxError: /home/christopher/Schreibtisch/cwa-website/src/data/faq_de.json: Unexpected token
 in JSON at position 21610
    at parse (<anonymous>)
    at Object.Module._extensions..json (internal/modules/cjs/loader.js:1234:22)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Module.require (internal/modules/cjs/loader.js:1089:19)
    at require (internal/modules/cjs/helpers.js:73:18)
    at Panini.module.exports [as loadData] (/home/christopher/Schreibtisch/cwa-website/node_modules/panini/lib/loadData.js:21:14)
    at Panini.module.exports [as refresh] (/home/christopher/Schreibtisch/cwa-website/node_modules/panini/lib/refresh.js:10:8)
    at module.exports (/home/christopher/Schreibtisch/cwa-website/node_modules/panini/index.js:41:12)
    at pages (/home/christopher/Schreibtisch/cwa-website/gulpfile.js:60:7)
[11:41:40] 'build' errored after 91 ms
[11:41:40] The following tasks did not complete: javascript, images, copy
[11:41:40] Did you forget to signal async completion?
[christopher@ArchDesktop cwa-website]$

I have the files with the fix ready, but I don't know how to commit the changes.

@c-mahn Thanks! There's a related pull request: https://github.com/corona-warn-app/cwa-website/pull/66. It hasn't been merged yet, so feel free to take a look and comment.

Issue solved by merge request #66 .


If this class has been scanned once, skip it and no longer register

Because Fully Qualified Name is used, it is safe. If this class has been scanned once, skip it and no longer register。
I don’t want to set spring.main.allow-bean-definition-overriding=true, because it is possible that the bean will be overridden

@xiejx618 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@xiejx618 Thank you for signing the Contributor License Agreement!

@xiejx618 Will you be completing this PR after review?


JsonArrayFixingInputStream produces broken output on certain repositories

Describe the bug
JsonArrayFixingInputStream produces broken output on certain repositories.
Version of dependency-check used
The problem occurs using version 6.1.3 of the cli. The older release 6.1.2 is working.
Log file
2021-03-26 18:19:35,948 org.owasp.dependencycheck.App:208
ERROR - Unexpected exit code from go process; exit code: 141
2021-03-26 18:19:35,949 org.owasp.dependencycheck.App:209
DEBUG - unexpected error
org.owasp.dependencycheck.analyzer.exception.AnalysisException: Unexpected exit code from go process; exit code: 141
        at org.owasp.dependencycheck.analyzer.GolangModAnalyzer.analyzeDependency(GolangModAnalyzer.java:295)
        at org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze(AbstractAnalyzer.java:131)
        at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:88)
        at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:37)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
        at java.base/java.lang.Thread.run(Thread.java:832)
        Suppressed: org.owasp.dependencycheck.analyzer.exception.AnalysisException: Error parsing stream
                at org.owasp.dependencycheck.data.golang.GoModJsonParser.process(GoModJsonParser.java:86)
                at org.owasp.dependencycheck.processing.GoModProcessor.run(GoModProcessor.java:62)
                ... 1 common frames omitted
        Caused by: javax.json.stream.JsonParsingException: Invalid token=COLON at (line no=979, column no=8, offset=36995). Expected tokens are: [COMMA]
                at org.glassfish.json.JsonParserImpl.parsingException(JsonParserImpl.java:450)
                at org.glassfish.json.JsonParserImpl.access$1100(JsonParserImpl.java:79)
                at org.glassfish.json.JsonParserImpl$ArrayContext.getNextEvent(JsonParserImpl.java:557)
                at org.glassfish.json.JsonParserImpl.next(JsonParserImpl.java:376)
                at org.glassfish.json.JsonParserImpl.getArray(JsonParserImpl.java:324)
                at org.glassfish.json.JsonParserImpl.getArray(JsonParserImpl.java:164)
                at org.glassfish.json.JsonReaderImpl.readArray(JsonReaderImpl.java:129)
                at org.owasp.dependencycheck.data.golang.GoModJsonParser.process(GoModJsonParser.java:71)
                ... 2 common frames omitted

To Reproduce
Steps to reproduce the behavior:

dependency-check -l scan.log --scan go.mod
See error in log

Expected behavior
Successful execution.
Additional context
As a quick fix I increased the buffer size and I'm able to execute the scanner succesfully (based on git commit b1bbc4469):
diff --git a/utils/src/main/java/org/owasp/dependencycheck/utils/JsonArrayFixingInputStream.java b/utils/src/main/java/org/owasp/dependencycheck/utils/JsonArrayFixingInputStream.java
index c0b253a69..b2a367a48 100644
--- a/utils/src/main/java/org/owasp/dependencycheck/utils/JsonArrayFixingInputStream.java
+++ b/utils/src/main/java/org/owasp/dependencycheck/utils/JsonArrayFixingInputStream.java
@@ -49,7 +49,7 @@ public class JsonArrayFixingInputStream extends InputStream {
     /**
      * The buffer length.
      */
-    private static final int BUFFER_SIZE = 2048;
+    private static final int BUFFER_SIZE = 8192;
     /**
      * The input stream to be filtered.
      */

You can find a sample and test case I'm using here: https://gist.github.com/rofafor/e3858789caecb7c5fbb92efd1fb2989b
This one fails on both default 2k and 8k buffer sizes, but works with 16k :)

It would be so nice if go actually output correctly formatted JSON... It shouldn't be that hard for them to add commas appropriately....

Yes, I'm seeing the same problem. Any way to do this without modifying dependency-check source code?

I guess this would just be because there happens to be a delimiter right on the border/end/beginning of the buffer and that confuses the JSON parser. Ugh that's a tricky one.

Having the same issue here too:
Unexpected exit code from go process; exit code: 141 exception: org.owasp.dependencycheck.analyzer.exception.AnalysisException: Unexpected exit code from go process; exit code: 141 org.owasp.dependencycheck.analyzer.GolangModAnalyzer.analyzeDependency(GolangModAnalyzer.java:297) org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze(AbstractAnalyzer.java:131) org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:88) org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:37) java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) java.base/java.lang.Thread.run(Thread.java:831)
If I reduce the number of dependencies it eventually runs successfully. I know go is currently in experimental mode but it's mostly unusable.

What would likely help the most is if someone could open a ticket with GoLang asking that the command below would produces valid JSON:
go list -json -m -mod=readonly all

It currently does not correctly output parsable json:
{
	"Path": "golang.org/x/net",
	"Version": "v0.0.0-20190404232315-eb5bcb51f2a3",
	"Time": "2019-04-04T23:23:15Z",
	"Indirect": true,
	"GoMod"<EMAIL_ADDRESS>}
{
	"Path": "golang.org/x/sys",
	"Version": "v0.0.0-20190412213103-97732733099d",
	"Time": "2019-04-12T21:31:03Z",
	"Indirect": true,
	"GoMod"<EMAIL_ADDRESS>	"GoVersion": "1.12"
}
{
	"Path": "golang.org/x/text",
	"Version": "v0.3.0",
	"Time": "2017-12-14T13:08:43Z",
	"Indirect": true,
	"GoMod"<EMAIL_ADDRESS>}

Note that this does not have commas nor does it have brackets indicating it is an array. Maybe I'm missing something - but this isn't valid json.

HI @jeremylong, thanks for the reply!
I believe someone pointed this a few years ago, but I don't think they'll change it tbh:
https://github.com/golang/go/issues/27655
It's intended to be a stream of JSON objects instead of a valid json array.

Pretty sure I found the issue. When I tested against https://github.com/kubernetes/kubernetes. What I found is that there are several go.mod files in the vendor, staging, and cluster directories. As dependency-check currently scans the entire directory structure for dependencies - it ends up trying to run go list -json -m -mod=readonly all against all of the various go.mod files:
~/Projects/kubernetes/vendor/github.com/russross/blackfriday/v2
$ go list -json -m -mod=readonly all
go: updates to go.mod needed, disabled by -mod=readonly

I'm guessing we should skip running this against go.mod files in the vendor directory?
BTW - I was able to succesfully run ODC against the go.mod file by running:
$ dependency-check.sh -o . -s ./go.mod --enableExperimental

In this case it only runs against the single go.mod file.

The repository I'm testing only has one go.mod with about 18 dependencies, so I don't think it has something to do with vendor folders or multiple go.mod files (at least in my case - it can be a different issue).
Tried
dependency-check -o . -s ./go.mod --enableExperimental

and errors with
Unexpected exit code from go process; exit code: 141
exception: org.owasp.dependencycheck.analyzer.exception.AnalysisException: Unexpected exit code from go process; exit code: 141
org.owasp.dependencycheck.analyzer.GolangModAnalyzer.analyzeDependency(GolangModAnalyzer.java:297)
org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze(AbstractAnalyzer.java:131)
org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:88)
org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:37)
java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
java.base/java.lang.Thread.run(Thread.java:831)

I'm running 6.2.2 (latest by the time of writing).


Support domain ID as well as domain name

Issue #, if available:
Description of changes:
When a sub-domain and its account is used in CloudStackCluster.spec.domain and account capc fails to get a domain ID for the input domain name because GetDomainID doesn't look up the sub-domains. To make capc work with sub-domain listDomains with listall=true should be used.
Testing performed:
Manually created a cluster using eks-a and clusterctl
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jweite-amazon

Do we need to implement Mikhail's suggestion of supporting domain specification by ID?

I think we should do both by ID and or full domain path if possible. So in this case it would be something like root/blah/blah.
I'm not entirely certain that's possible though. Still researching.

Why would we only allow specifying one or the other. It's fine if the user specifies both, they just need to match against the relationship in CloudStack.

I thought name and id are mutually exclusive because eks-a says that.
              template:
                description: Template refers to a VM image template which has been
                  previously registered in CloudStack. It can either be specified
                  as a UUID or name
                properties:
                  id:
                    description: Id of a resource in the CloudStack environment. Mutually
                      exclusive with Name
                    type: string
                  name:
                    description: Name of a resource in the CloudStack environment.
                      Mutually exclusive with Id
                    type: string

https://github.com/aws/eks-anywhere/blob/53edfec5399344dc1eadc0b88f661cb068517631/config/crd/bases/anywhere.eks.amazonaws.com_cloudstackmachineconfigs.yaml#L79

/hold


10,000 commits

Type: Bug
Hey I am new to the deleoper world. my VS seems to have over 10,000 commits waiting and my VS keeps crashing. I feel like its trying to commit every file in my computer or something. how do I get it to stop? I keep having to close out of VS. I need to use it for my class. I am stuck. I'm a newb.
I have tried to cancel all the commits and it crashed.
I have also tried to uninstall VS code and it's still there, how can I get rid of this?
VS Code version: Code 1.72.2 (d045a5eda657f4d7b676dedbfa7aab8207f8a075, 2022-10-12T22:15:18.074Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
31.86GB (20.63GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
2144e591:30553903
pyindex848cf:30577861
nodejswelcome1:30587005
fc301958:30573243

I think you are talking about the source control feature of VS code, This is helpful to keep track the changes of the file. It will come very handy if  you are working in big file, to learn more about this there is great documentation by vscode it self Source control.
If you want to turn off this feature then type "git.enabled": false . This will turn off the git so source control will not work without git.

@AshlingnLog, could you please provide a screenshot of VS Code with the message?
Do you by any chance have a git repository in your home directory?

Yes I do use source control, git repository in my home directory? I don't know what you mean by that although this is a screenshot of setting and my working directory.

This should be off if you want to turn off git/source control.

And yes i know this is not vscode in my linux system i use vscodium but it is same for offician vs-code also.

Hey @lszomoru, this issue might need further attention.
@AshlingnLog, you can help us out by closing this issue if the problem no longer exists, or adding more information.

I think it was a newb mistake. I will open a new ticket if I encounter it again.  I will close it for now.


Add functions to JavaScript

Add function to .js file; show operational code in console.

Merged too soon after creating conditions in lesson 3. Created separate commit for functions in lesson 4.


Server crashes when the main branch changes

We have a case where the developers were using the dev branch and the main branch on Github because they were using a Gitflow approach
But now they are doing Continuous Deployment so their main branch has changed to master.
This has caused the server to crash every time that tries to go through that repository
We use detect-secrets-server as a cronjob on Kubernetes using a Persistent volume claim for the folder /repositories/
Scanning: git@github.com:my-company/my-app.git
Traceback (most recent call last):
  File "/usr/bin/detect-secrets-server", line 11, in <module>
    sys.exit(main())
  File "/usr/lib/python2.7/site-packages/detect_secrets_server/__main__.py", line 39, in main
    return actions.scan_repo(args)
  File "/usr/lib/python2.7/site-packages/detect_secrets_server/actions/scan.py", line 37, in scan_repo
    scan_head=args.scan_head,
  File "/usr/lib/python2.7/site-packages/detect_secrets_server/repos/base_tracked_repo.py", line 133, in scan
    self.storage.fetch_new_changes()
  File "/usr/lib/python2.7/site-packages/detect_secrets_server/storage/base.py", line 84, in fetch_new_changes
    git.fetch_new_changes(self._repo_location)
  File "/usr/lib/python2.7/site-packages/detect_secrets_server/storage/core/git.py", line 71, in fetch_new_changes
    '--force',
  File "/usr/lib/python2.7/site-packages/detect_secrets_server/storage/core/git.py", line 213, in _git
    stderr=subprocess.STDOUT
  File "/usr/lib/python2.7/subprocess.py", line 223, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['git', '--git-dir', '/repositories/repos/179222fd2291a1a104c7750b95f5c3df3ae7f9c6325d25e5047059ffd25e47369c080091f58dd06007cc905ed31b60da447f7c2fd9f0fa1eded4740f3bf43760', 'fetch', '--quiet', 'origin', 'dev:dev', '--force']' returned non-zero exit status 128

Hi @carlosjgp,
detect-secrets-server gets the "main" branch through this command: git rev-parse --abbrev-ref HEAD for the locally cloned bare repo.
Based on the subprocess traceback, it tried to fetch changes from dev branch.
Not sure how you changed the main branch to master, but you might have to change the master branch for the local git repo too. If you changed the master branch upstream, probably easier to rm -rf /repositories/repos/179222fd2291a1a104c7750b95f5c3df3ae7f9c6325d25e5047059ffd25e47369c080091f58dd06007cc905ed31b60da447f7c2fd9f0fa1eded4740f3bf43760, and track it again.

I just did that

Hi @carlosjgp,
detect-secrets-server gets the "main" branch through this command: git rev-parse --abbrev-ref HEAD for the locally cloned bare repo.
Based on the subprocess traceback, it tried to fetch changes from dev branch.
Not sure how you changed the main branch to master, but you might have to change the master branch for the local git repo too. If you changed the master branch upstream, probably easier to rm -rf /repositories/repos/179222fd2291a1a104c7750b95f5c3df3ae7f9c6325d25e5047059ffd25e47369c080091f58dd06007cc905ed31b60da447f7c2fd9f0fa1eded4740f3bf43760, and track it again.

I just did that and also realised that I had to delete the same entry 179222....f3bf43760 from AWS S3... maybe too late because detect-secrets was running already and I got this...
Scanning: git@github.com:my-company/my-app.git
Traceback (most recent call last):
  File "/usr/bin/detect-secrets-server", line 11, in <module>
    sys.exit(main())
  File "/usr/lib/python2.7/site-packages/detect_secrets_server/__main__.py", line 39, in main
    return actions.scan_repo(args)
  File "/usr/lib/python2.7/site-packages/detect_secrets_server/actions/scan.py", line 24, in scan_repo
    s3_config=getattr(args, 's3_config', None),
  File "/usr/lib/python2.7/site-packages/detect_secrets_server/repos/s3_tracked_repo.py", line 90, in load_from_file
    base_directory,
  File "/usr/lib/python2.7/site-packages/detect_secrets_server/repos/base_tracked_repo.py", line 100, in load_from_file
    data = cls.get_tracked_repo_data(storage, repo_name)
  File "/usr/lib/python2.7/site-packages/detect_secrets_server/repos/s3_tracked_repo.py", line 95, in get_tracked_repo_data
    output = super(S3TrackedRepo, cls).get_tracked_repo_data(storage, repo_name)
  File "/usr/lib/python2.7/site-packages/detect_secrets_server/repos/base_tracked_repo.py", line 112, in get_tracked_repo_data
    return storage.get(storage.hash_filename(repo_name))
  File "/usr/lib/python2.7/site-packages/detect_secrets_server/storage/s3.py", line 38, in get
    Filename=file_on_disk,
  File "/usr/lib/python2.7/site-packages/boto3/s3/inject.py", line 172, in download_file
    extra_args=ExtraArgs, callback=Callback)
  File "/usr/lib/python2.7/site-packages/boto3/s3/transfer.py", line 307, in download_file
    future.result()
  File "/usr/lib/python2.7/site-packages/s3transfer/futures.py", line 106, in result
    return self._coordinator.result()
  File "/usr/lib/python2.7/site-packages/s3transfer/futures.py", line 265, in result
    raise self._exception
botocore.exceptions.ClientError: An error occurred (404) when calling the HeadObject operation: Not Found

running again now...

This is where you can change the default branch on GitHub by the way

It did work this time.
Is this something that is worth consider managing better?

what do you think @domanchi?

@carlosjgp : it might be possible to pass in the master branch name as a CLI argument, but it seems pretty edge case to me (only speaking from the workflows that I've been exposed to) :shrug:
If you think this is a larger issue that's worth the time to address, PRs are definitely welcome!


Game crash when trying to play with Josharias Survival

What you were trying to do
Trying to load into/create a Josharias Survival world
What actually happened
Game crash with "NoSuchMethodError" relating to customOreGen
How to reproduce

Download Nightly Build 1102
Try to load into or create a new Josharias Survival world

Log details and game version
https://drive.google.com/uc?id=14WiHJAOM79VDOxVQqBQ0hNafay5I7bOT&export=download
Nightly build 1102
Computer details
i5-8600k
GTX 1660ti
16GB ram
Windows 10 Pro

I have same problem when i try to play on nightly build 1102, and create survival on josharias survival world it crashes,
it says nosuchmethoderror
https://drive.google.com/uc?id=1zBoL1TrkVYLe9B4fnpf_9Vwc2jC7-iqg&export=download
my computer specs are
windows 8.1
amd fx 6300  (graphics card )
six core prosessor 3,50 ghz
16 gb ram
64 bits os

@Gizmordo @harunamiya Thanks for reporting this :+1:
Should be fixed with Nightly 1103, feel free to check :slightly_smiling_face:


sdk/resourcemanager/cognitiveservices/armcognitiveservices live test

0.57(24/42)

@Alancere cognitive service is important. Could you increase the coverage for it?


Check and document the way to use the AF@UNL (without using a notebook): from AF terminal and remotly from user PC

[ ] Check and document how user should run analysis on AF from AF terminal
[ ] Check and document how user should run analysis on AF from user's PC terminal

Linked issues: https://github.com/CoffeaTeam/coffea-casa/issues/169
Reported by @kenbloom

I think some people are just using python scripts rather than a notebook.  Should figure out how to support them.

@mat-adamec  we need to add a section about using AF from terminal in both cases: from AF and from user's laptop terminal

It's been a while since I've seen this topic. Last I remember, there were some issues with how to handle the secrets on a terminal. Were there breakthroughs on this and is using coffea-casa from a terminal currently possible, or does that still need to be investigated?


[BUG] IgnoredHeaders are not excluded from result comparison

Library name and version
Azure.Core.TestFramework
Describe the bug
According to the guide, adding headers through IgnoredHeaders.Add("XXX") should exclude those headers from result comparison.
However, I have a PR which will add repeatable request headers in some SDKs. Those headers should be excluded, because their value is automatically set by SDK and its value will change each time. So I add those headers as ignored headers. But the test still fails.
Here is a failed case:

RevokeTest failed because extra header is found. Here is the error log in pipeline (can be reproduced on local).
The original test case is here.
The invoked API client method is https://github.com/Azure/azure-sdk-for-net/blob/8ff2023034367ab4936bf285372a0c8aae625baf/sdk/purview/Azure.Analytics.Purview.Share/src/Generated/AcceptedSentSharesClient.cs#L293
In the PR, the repeatabilityRequestId parameter is removed from the API client method. That value is automatically set in the SDK at runtime.
Previously in the test case, null value is set for repeatabilityRequestId. So in existing test recording, there is no repeatabilityRequestId.
I've added those headers into IgnoredHeaders (see here), and the error still exist.

Expected behavior
IgnoredHeaders should be excluded from result comparison.
Actual behavior
IgnoredHeaders is not excluded from result comparison.
Reproduction Steps
See the description.
Environment
No response

Looks like IgnoredHeaders will still be checked the existence: https://github.com/Azure/azure-sdk-for-net/blob/8ff2023034367ab4936bf285372a0c8aae625baf/sdk/core/Azure.Core.TestFramework/src/RecordedTestBase.cs#L152-L156
Can we change to exclude ignored headers totally from any comparison? That will bring huge benefit in forward compatibility of test recordings. Besides repeatable request IDs, in the near future there will be request ID which will be added to all SDKs.

@m-nash FYI

//cc: @JoshLove-msft, @annelo-msft

@archerzz it feels to me like validating the presence is a good thing since we want to make sure we don't change header behavior between runs unless it is "expected".
If I understand correctly your current recording does not include a header but the new code does so there is a mismatch?  Don't we typically re-record when there is an expected difference like this?
Adding a header is a safe behavioral change removing one is not.  If we got rid of the presence checking wouldn't we miss the removal case in regression?

There is a back compat property that has the behavior that is being requested here - https://github.com/Azure/azure-sdk-for-net/blob/8ff2023034367ab4936bf285372a0c8aae625baf/sdk/core/Azure.Core.TestFramework/src/RecordedTestBase.cs#L173
We intentionally hid this property for all the reasons that @m-nash mentioned.

@archerzz it feels to me like validating the presence is a good thing since we want to make sure we don't change header behavior between runs unless it is "expected".
If I understand correctly your current recording does not include a header but the new code does so there is a mismatch? Don't we typically re-record when there is an expected difference like this?
Adding a header is a safe behavioral change removing one is not. If we got rid of the presence checking wouldn't we miss the removal case in regression?

@m-nash Generally I agree that we should re-record the tests and checking header presence is better. However, there are special cases. As far as I met:

Some test cases are tightly coupled with service team's own testing environment. It's hard for us to re-record or modify the test cases since we don't know the details of the service.
Some test cases require special privilege. For example, the Azure.Communication.CallingServer requires a phone number. None of the service instance in our SDK environment can activate a phone number.
Sometimes we might need to re-record all test cases for all SDKs. I've talked with @chunyu3 and I believe the request ID feature might be this case. It would be too much effort if we have to re-record all.

Lets address bullet 3 independently as that is separate from the repeatability use case here.
I do understand the challenges with bullet 1 and 2, how many tests would we need to re-record here?
One of the reasons I would push for re-recording here is that we can't rely on live testing for the same reasons you list.  There is some regression danger in relying on the same recordings for too long since the service can change its behavior over time and we wouldn't necessarily know.
Periodically re-recording is a necessary thing until we have the time to get our live testing solution in place.

Lets address bullet 3 independently as that is separate from the repeatability use case here.
I do understand the challenges with bullet 1 and 2, how many tests would we need to re-record here?
In dataplane where we have reliable live test I would be fine with simply modifying the recordings to have a new header and no need to re-record.
In mgmtplane one of the reasons I would push for re-recording here is that we can't rely on live testing for the same reasons you list. There is some regression danger in relying on the same recordings for too long since the service can change its behavior over time and we wouldn't necessarily know.
Periodically re-recording is a necessary thing until we have the time to get our live testing solution in place.

@m-nash for the repeatability request header changes, 8 SDKs are impacted. And 4 of them require re-recording. 2 of 4 have good test cases so that re-recording is done easily. The remaining 2 SDKs have their test cases tightly bound to service teams' own testing environments.

Azure.Communication.CallingServer: 18 of 155 test cases failed
Azure.Analytics.Purview.Share: 6 of 36 test cases failed

I've modified the test recordings to make the tests pass. I agree that for such number of impacted test cases, modifying test recordings is a better option.
Closing this issue.


[PE-D][Tester D] Incorrect JavaFX version

JavaFX keeps throwing warnings in the console

Labels: severity.VeryLow type.FeatureFlaw
original: XenonShawn/ped#16

Check JavaFX FXML file versions.


docs: Updates to README

fixes #16

@mpous - first attempt of improving the README. In particular, improving the documentation around wiring things up. https://github.com/hferentschik/balena-weather/blob/0adb3b8d896baacaff6edfffa2f2b2a6334f3e6b/README.md
WDYT?

Sorry for my delay! last week was very busy @hferentschik
i'm going to check this tomorrow :)

Sorry for my delay! last week was very busy

no worries. I already merged the PR since I think it is already a big improvement. Please let me know any further suggestions of yours. It would also be great, if you could double-check the wiring with your setup.


Add Deployer recipe

Could also link to Deployer directly, as it contains the magento2 recipe by default. Not sure what's better.

Thanks Barry! Let's merge it 👍


Cannot wrap up a task WTXXXXXXX in workspace WSXXXXXX for account ACXXXXXX because it's not currently assigned

hi lehel and other developers,
I have this issue right here if you can have time to have a look at it and it's for the route /call-outbound-join

Hey @KhangNg92, I believe this is a duplicate of issue https://github.com/lehel-twilio/plugin-dialpad/issues/26 that I opened up.

hey @patrickappelman , if you have sometimes we can communicate and talk about it, my email is<EMAIL_ADDRESS>

@KhangNg92 , check my answer at #26 this is due to a recent update in Flex.


not working with latest monaco

i upgraded monaco-editor from 0.34 to 0.45 and got this error

my mistake, this isn't related to monaco-vim


add copy/cut/paste to Edit menu dropdown

Currently copy/cut/paste is only available via Ctrl+C/Ctrl+X/Ctrl+V keyboard shortcuts. Add it to the Edit menu.

@dave-doty I don't believe Ctrl+X is an available option yet.

Oh, right, that's not implemented. Actually I forgot that it's not really needed, because move is implemented via select, then click and drag.


Update CheckStyle

Move to updated google-checks.xml (remove the old one)
Tell check style to use v8.1 (instead of 6.11.2)
remove versions-rules
comment out our amendments for now in google_checks.xml
Fix AppTest for new check style rules.
update a few versions
prep for two new releases

@tswast @jabubake Still would appreciate comments, or I'm also happy to say this is an FYI.
I've Already found an issue in jds where compute samples weren't always setup to test correctly on this.

I think we had the extra filters for the IT convention in integration test class names. Is the new config happy with those names?

I got about half way through checking jds.  But it seems so.  I ran into a problem for an app that doesn't follow the rules, so I didn't follow on.


sind API added to @stdlib/math/base/special/sind and closes issue

Resolves #844 .
sind API added to @stdlib/math/base/special/sind and closes issue.

@piff-saad Thanks for this initial implementation. Would you be able to add the associated tests, benchmarks, documentation, and other files in order to make this a package? As it stands now, this file is not readily consumable by other packages within the project.

For reference, here is the project dev guide for packages: https://github.com/stdlib-js/stdlib/blob/develop/docs/packages.md.

@pooriyasafaei Checking in to see if you are interested in moving forward with this PR. Let us know when you have a chance! Thanks!

Closing this PR, as proposed changes are incomplete.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_5eddbxgksr/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_5eddbxgksr/clone/recipe/meta.yaml:30: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_5eddbxgksr/clone/recipe/meta.yaml:41: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_5eddbxgksr/clone/recipe/meta.yaml:41: http_url: http://aws.amazon.com/cli/ is not https
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_8bu97_rz2b/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_8bu97_rz2b/clone/recipe/meta.yaml:30: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_8bu97_rz2b/clone/recipe/meta.yaml:41: http_url: http://aws.amazon.com/cli/ is not https
ERROR: /tmp/abs_8bu97_rz2b/clone/recipe/meta.yaml:41: missing_dev_url: The recipe is missing a dev_url
Errors were found


Float not supported

Sample code:
extern "C"
{
#include "lua.h"
#include "lauxlib.h"
#include "lualib.h"
}

struct SimpleVec2
{
	float x, y;
};

#include <Selene/selene.h>

int main()
{
	sel::State state{ true };
	state["vec2"].SetClass<SimpleVec2>("x", &SimpleVec2::x);

  return 0;
}

Can you paste the entire error please? Thanks

https://gist.github.com/bagobor/c97ddf32cc1ae1213c76

It looks like 'float' not supported. :boom::boom:
changing 'float' -> 'int' removes compile errors.

Ok, I found previous issue
https://github.com/jeremyong/Selene/issues/52

Do I need only provide implementation of:
inline float _check_get(_id<float>, lua_State *l, const int index) {
	return luaL_checknumber(l, index);
}

or also add:
template <>
struct is_primitive<float> {
	static constexpr bool value = true;
};

The problem is that the internal representation of a floating point number in lua is lua_Number which is a double.

got it ... but it looks weird for luabind switcher. ))

Lua internally doesn't have more than one floating point representation. If you are ok with float precision, either cast it yourself via an accessor or change the internal representation of lua_Number. The library shouldn't implicitly lose precision for the user IMO.


Make sure /command names and the like match a validation regex

TODO: What regex to actually use?
See: https://canary.discord.com/channels/486311607400529931/486311631081570326/843139604323237908

From the docs:
CHAT_INPUT commands and options must match ^[\w-]{1,32}$ with the unicode flag set, and must be lowercased. USER and MESSAGE commands do not follow this restriction.