Problem with Version 0.31.0

I run BookStack on Ubuntu Container, i want to update to new Version 0.31.0, but after upgrade Bookstack dont work anymore.
I go to /var/www/html/Bookstack and run
git pull origin release && composer install --no-dev && php artisan migrate
After update Bookstack dont work anymore?
Can somebody help me pleas?

When you say "container" do you mean a VM or in Docker?

When you say "container" do you mean a VM or in Docker?

In addition to the above, what do you mean by it doesn't work? What error or result are you seeing?

In addition to the above, what do you mean by it doesn't work? What error or result are you seeing?

In addition to the above, what do you mean by it doesn't work? What error or result are you
ii cant open any more my book stack

In addition to the above, what do you mean by it doesn't work? What error or result are you
ii cant open any more my book stack

@dugs951 Sure, But what do you visually see when attempting to access?  A blank white screen? An error message?

@dugs951 Sure, But what do you visually see when attempting to access?  A blank white screen? An error message?

I open /var/www/html/Bookstack then i make Update:
git pull origin release && composer install --no-dev && php artisan migrate
Then i can not more open my BookStack
When i go to bookstack.mydomain.com i can not open my bookstack
Know somebody whats the problem?

I open /var/www/html/Bookstack then i make Update:
git pull origin release && composer install --no-dev && php artisan migrate
Then i can not more open my BookStack
When i go to bookstack.mydomain.com i can not open my bookstack
Know somebody whats the problem?

Diese Seite funktioniert nicht
bookstack.mydomain.com kann diese Anfrage momentan nicht verarbeiten.
HTTP ERROR 500

@dugs951 Sure, But what do you visually see when attempting to access? A blank white screen? An error message?

Diese Seite funktioniert nicht
bookstack.mydomain.com kann diese Anfrage momentan nicht verarbeiten.
HTTP ERROR 500

@dugs951 Sure, But what do you visually see when attempting to access? A blank white screen? An error message?

@dugs951

In regards to the " HTTP ERROR 500". Where are you seeing that? When accessing the homepage URL?
What operating system are you using?
How did you originally install BookStack?

@dugs951

In regards to the " HTTP ERROR 500". Where are you seeing that? When accessing the homepage URL?
What operating system are you using?
How did you originally install BookStack?

I ended up with a HTTP ERROR 500 when trying to load the bookstack homepage when upgrading to 0.31.0 as well. Mine was an an error with migration tables, I dropped the tables from the SQL database and was able to continue the migration.

I ended up with a HTTP ERROR 500 when trying to load the bookstack homepage when upgrading to 0.31.0 as well. Mine was an an error with migration tables, I dropped the tables from the SQL database and was able to continue the migration.

I ended up with a HTTP ERROR 500 when trying to load the bookstack homepage when upgrading to 0.31.0 as well. Mine was an an error with migration tables, I dropped the tables from the SQL database and was able to continue the migration.

Was the error you were getting the same one I detailed in #2473?

I ended up with a HTTP ERROR 500 when trying to load the bookstack homepage when upgrading to 0.31.0 as well. Mine was an an error with migration tables, I dropped the tables from the SQL database and was able to continue the migration.

Was the error you were getting the same one I detailed in #2473?

Somebody can help with this problem?

Somebody can help with this problem?

@dugs951 I can do but you'd need to provide some additional details, such as those requested in https://github.com/BookStackApp/BookStack/issues/2455#issuecomment-757473542.

@dugs951 I can do but you'd need to provide some additional details, such as those requested in https://github.com/BookStackApp/BookStack/issues/2455#issuecomment-757473542.

@dugs951 I can do but you'd need to provide some additional details, such as those requested in #2455 (comment).

Which table i need to drop?
I go to mysql i show my tables but i dont know which table i need to drop?

@dugs951 I can do but you'd need to provide some additional details, such as those requested in #2455 (comment).

Which table i need to drop?
I go to mysql i show my tables but i dont know which table i need to drop?

[Wed Jan 27 00:33:32.145816 2021] [php7:error] [pid 561] [client <IP_ADDRESS>:43646] PHP Fatal error:  Declaration of Symfony\Component\Translation\TranslatorInterface::setLocale($locale) must be compatible with Symfony\Contracts\Translation\LocaleAwareInterface::setLocale(string $locale) in /var/www/html/BookStack/vendor/symfony/translation/TranslatorInterface.php on line 24
[Wed Jan 27 00:33:32.230338 2021] [php7:error] [pid 561] [client <IP_ADDRESS>:43646] PHP Fatal error:  Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Call to undefined method Illuminate\Support\Carbon::now() in /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Support/InteractsWithTime.php:37\nStack trace:\n#0 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(269): Illuminate\Cache\FileStore->availableAt(0)\n#1 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(74): Illuminate\Cache\FileStore->expiration(0)\n#2 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(152): Illuminate\Cache\FileStore->put('setting-app-nam...', 'Book dD22', 0)\n#3 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/Repository.php(355): Illuminate\Cache\FileStore->forever('setting-app-nam...', 'Book dD22')\n#4 /var/www/html/BookStack/app/Settings/SettingService.php(112): Illuminate\Cache\Repository->forever('setting-app-nam...', 'Book dD22')\n#5 /var/www/html/BookStack/app/Settings/SettingService in /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Support/InteractsWithTime.php on line 37

[Wed Jan 27 00:33:32.145816 2021] [php7:error] [pid 561] [client <IP_ADDRESS>:43646] PHP Fatal error:  Declaration of Symfony\Component\Translation\TranslatorInterface::setLocale($locale) must be compatible with Symfony\Contracts\Translation\LocaleAwareInterface::setLocale(string $locale) in /var/www/html/BookStack/vendor/symfony/translation/TranslatorInterface.php on line 24
[Wed Jan 27 00:33:32.230338 2021] [php7:error] [pid 561] [client <IP_ADDRESS>:43646] PHP Fatal error:  Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Call to undefined method Illuminate\Support\Carbon::now() in /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Support/InteractsWithTime.php:37\nStack trace:\n#0 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(269): Illuminate\Cache\FileStore->availableAt(0)\n#1 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(74): Illuminate\Cache\FileStore->expiration(0)\n#2 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(152): Illuminate\Cache\FileStore->put('setting-app-nam...', 'Book dD22', 0)\n#3 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/Repository.php(355): Illuminate\Cache\FileStore->forever('setting-app-nam...', 'Book dD22')\n#4 /var/www/html/BookStack/app/Settings/SettingService.php(112): Illuminate\Cache\Repository->forever('setting-app-nam...', 'Book dD22')\n#5 /var/www/html/BookStack/app/Settings/SettingService in /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Support/InteractsWithTime.php on line 37

PHP 7.4.12 (cli) (built: Oct 31 2020 17:04:09) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Zend OPcache v7.4.12, Copyright (c), by Zend Technologies

PHP 7.4.12 (cli) (built: Oct 31 2020 17:04:09) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Zend OPcache v7.4.12, Copyright (c), by Zend Technologies

Which table i need to drop?

@dugs951 Please don't drop any tables.
It looks to me like your php dependencies are not up-to-date.
Can you retry re-running composer install --no-dev?
Let me know if there are any errors in the output. Also, If there are files ending in .php within the bootstrap/cache folder, Please delete those.

Which table i need to drop?

@dugs951 Please don't drop any tables.
It looks to me like your php dependencies are not up-to-date.
Can you retry re-running composer install --no-dev?
Let me know if there are any errors in the output. Also, If there are files ending in .php within the bootstrap/cache folder, Please delete those.

Welchen Tisch muss ich fallen lassen?

@ dugs951 Bitte keine Tabellen löschen .
Es sieht für mich so aus, als ob Ihre PHP-Abhängigkeiten nicht auf dem neuesten Stand sind.
Können Sie es erneut versuchen composer install --no-dev?
 Wenn es auch, sind Dateien mit der Endung .phpinnerhalb des bootstrap/cacheOrdners, Bitte löschen Sie diese.

@php -r "!file_exists('bootstrap/cache/services.php') || @unlink('bootstrap/cache/services.php');"oot@BookStack:/var/www/html/BookStack# sudo tail -100 /etc/httpd/logs/error_log

Welchen Tisch muss ich fallen lassen?

@ dugs951 Bitte keine Tabellen löschen .
Es sieht für mich so aus, als ob Ihre PHP-Abhängigkeiten nicht auf dem neuesten Stand sind.
Können Sie es erneut versuchen composer install --no-dev?
 Wenn es auch, sind Dateien mit der Endung .phpinnerhalb des bootstrap/cacheOrdners, Bitte löschen Sie diese.

@php -r "!file_exists('bootstrap/cache/services.php') || @unlink('bootstrap/cache/services.php');"oot@BookStack:/var/www/html/BookStack# sudo tail -100 /etc/httpd/logs/error_log

@php -r "!file_exists('bootstrap/cache/services.php') || @unlink('bootstrap/cache/services.php');

@php -r "!file_exists('bootstrap/cache/services.php') || @unlink('bootstrap/cache/services.php');

I deleted files with php but problem is still same

I deleted files with php but problem is still same

Just to confirm, Did you see any errors when running composer install --no-dev?

Just to confirm, Did you see any errors when running composer install --no-dev?

Do not run Composer as root/super user! See https://getcomposer.org/root for details
Composer could not find a composer.json file in /root
To initialize a project, please create a composer.json file as described in the https://getcomposer.org/ "Getting Started" section
root@BookStack:~# cd /var/www/html/BookStack
root@BookStack:/var/www/html/BookStack# composer install --no-dev
Do not run Composer as root/super user! See https://getcomposer.org/root for details

@php -r "!file_exists('bootstrap/cache/services.php') || @unlink('bootstrap/cache/services.php');"
@php -r "!file_exists('bootstrap/cache/compiled.php') || @unlink('bootstrap/cache/compiled.php');"
Loading composer repositories with package information
Installing dependencies from lock file
Nothing to install or update
Package jakub-onderka/php-console-color is abandoned, you should avoid using it. Use php-parallel-lint/php-console-color instead.
Package jakub-onderka/php-console-highlighter is abandoned, you should avoid using it. Use php-parallel-lint/php-console-highlighter instead.
Generating optimized autoload files
Illuminate\Foundation\ComposerScripts::postAutoloadDump
@php artisan package:discover --ansi
Discovered Package: barryvdh/laravel-dompdf
Discovered Package: barryvdh/laravel-snappy
Discovered Package: facade/ignition
Discovered Package: fideloper/proxy
Discovered Package: intervention/image
Discovered Package: laravel/socialite
Discovered Package: nesbot/carbon
Discovered Package: nunomaduro/collision
Discovered Package: socialiteproviders/manager
Package manifest generated successfully.
40 packages you are using are looking for funding.
Use the composer fund command to find out more!
@php artisan cache:clear
Application cache cleared!
@php artisan view:clear
Compiled views cleared!

Do not run Composer as root/super user! See https://getcomposer.org/root for details
Composer could not find a composer.json file in /root
To initialize a project, please create a composer.json file as described in the https://getcomposer.org/ "Getting Started" section
root@BookStack:~# cd /var/www/html/BookStack
root@BookStack:/var/www/html/BookStack# composer install --no-dev
Do not run Composer as root/super user! See https://getcomposer.org/root for details

@php -r "!file_exists('bootstrap/cache/services.php') || @unlink('bootstrap/cache/services.php');"
@php -r "!file_exists('bootstrap/cache/compiled.php') || @unlink('bootstrap/cache/compiled.php');"
Loading composer repositories with package information
Installing dependencies from lock file
Nothing to install or update
Package jakub-onderka/php-console-color is abandoned, you should avoid using it. Use php-parallel-lint/php-console-color instead.
Package jakub-onderka/php-console-highlighter is abandoned, you should avoid using it. Use php-parallel-lint/php-console-highlighter instead.
Generating optimized autoload files
Illuminate\Foundation\ComposerScripts::postAutoloadDump
@php artisan package:discover --ansi
Discovered Package: barryvdh/laravel-dompdf
Discovered Package: barryvdh/laravel-snappy
Discovered Package: facade/ignition
Discovered Package: fideloper/proxy
Discovered Package: intervention/image
Discovered Package: laravel/socialite
Discovered Package: nesbot/carbon
Discovered Package: nunomaduro/collision
Discovered Package: socialiteproviders/manager
Package manifest generated successfully.
40 packages you are using are looking for funding.
Use the composer fund command to find out more!
@php artisan cache:clear
Application cache cleared!
@php artisan view:clear
Compiled views cleared!

Okay, Looks like that ran, any change in error now compared to your log example in https://github.com/BookStackApp/BookStack/issues/2455#issuecomment-767925910?

Okay, Looks like that ran, any change in error now compared to your log example in https://github.com/BookStackApp/BookStack/issues/2455#issuecomment-767925910?

Okay, Looks like that ran, any change in error now compared to your log example in #2455 (comment)?

This is the Error now
PHP Fatal error:  Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Call to undefined method Illuminate\Support\Carbon::now() in /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Support/InteractsWithTime.php:37\nStack trace:\n#0 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(269): Illuminate\Cache\FileStore->availableAt(0)\n#1 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(74): Illuminate\Cache\FileStore->expiration(0)\n#2 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(152): Illuminate\Cache\FileStore->put('setting-app-nam...', 'Book dD22', 0)\n#3 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/Repository.php(355): Illuminate\Cache\FileStore->forever('setting-app-nam...', 'Book dD22')\n#4 /var/www/html/BookStack/app/Settings/SettingService.php(112): Illuminate\Cache\Repository->forever('setting-app-nam...', 'Book dD22')\n#5 /var/www/html/BookStack/app/Settings/SettingService in /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Support/InteractsWithTime.php on line 37

Okay, Looks like that ran, any change in error now compared to your log example in #2455 (comment)?

This is the Error now
PHP Fatal error:  Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Call to undefined method Illuminate\Support\Carbon::now() in /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Support/InteractsWithTime.php:37\nStack trace:\n#0 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(269): Illuminate\Cache\FileStore->availableAt(0)\n#1 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(74): Illuminate\Cache\FileStore->expiration(0)\n#2 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(152): Illuminate\Cache\FileStore->put('setting-app-nam...', 'Book dD22', 0)\n#3 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/Repository.php(355): Illuminate\Cache\FileStore->forever('setting-app-nam...', 'Book dD22')\n#4 /var/www/html/BookStack/app/Settings/SettingService.php(112): Illuminate\Cache\Repository->forever('setting-app-nam...', 'Book dD22')\n#5 /var/www/html/BookStack/app/Settings/SettingService in /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Support/InteractsWithTime.php on line 37

PHP Fatal error:  Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Call to undefined method Illuminate\Support\Carbon::now() in /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Support/InteractsWithTime.php:37\nStack trace:\n#0 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(269): Illuminate\Cache\FileStore->availableAt(0)\n#1 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(74): Illuminate\Cache\FileStore->expiration(0)\n#2 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(152): Illuminate\Cache\FileStore->put('setting-app-nam...', 'Book dD22', 0)\n#3 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/Repository.php(355): Illuminate\Cache\FileStore->forever('setting-app-nam...', 'Book dD22')\n#4 /var/www/html/BookStack/app/Settings/SettingService.php(112): Illuminate\Cache\Repository->forever('setting-app-nam...', 'Book dD22')\n#5 /var/www/html/BookStack/app/Settings/SettingService in /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Support/InteractsWithTime.php on line 37

PHP Fatal error:  Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Call to undefined method Illuminate\Support\Carbon::now() in /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Support/InteractsWithTime.php:37\nStack trace:\n#0 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(269): Illuminate\Cache\FileStore->availableAt(0)\n#1 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(74): Illuminate\Cache\FileStore->expiration(0)\n#2 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/FileStore.php(152): Illuminate\Cache\FileStore->put('setting-app-nam...', 'Book dD22', 0)\n#3 /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Cache/Repository.php(355): Illuminate\Cache\FileStore->forever('setting-app-nam...', 'Book dD22')\n#4 /var/www/html/BookStack/app/Settings/SettingService.php(112): Illuminate\Cache\Repository->forever('setting-app-nam...', 'Book dD22')\n#5 /var/www/html/BookStack/app/Settings/SettingService in /var/www/html/BookStack/vendor/laravel/framework/src/Illuminate/Support/InteractsWithTime.php on line 37

@dugs951 Okay, I think there's something else going on here. You could try deleting the vendor/ folder within the bookstack install and re-run composer install --no-dev just as a test.
Otherwise, This could be cause by your webserver running a different PHP version than that used on the command line.
What version of Ubuntu are you using and have you installed multiple versions of PHP at any time?

@dugs951 Okay, I think there's something else going on here. You could try deleting the vendor/ folder within the bookstack install and re-run composer install --no-dev just as a test.
Otherwise, This could be cause by your webserver running a different PHP version than that used on the command line.
What version of Ubuntu are you using and have you installed multiple versions of PHP at any time?

@dugs951 Okay, I think there's something else going on here. You could try deleting the vendor/ folder within the bookstack install and re-run composer install --no-dev just as a test.
Otherwise, This could be cause by your webserver running a different PHP  version than that used on the command line.
What version of Ubuntu are you using and have you installed multiple versions of PHP at any time?

I try it but dont work.
When i look under /etc/php i have Version 7.1 and 7.4
When i make php -v then i have this version
PHP 7.4.12 (cli) (built: Oct 31 2020 17:04:09) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Zend OPcache v7.4.12, Copyright (c), by Zend Technologies
I dont know what is the Problem, i make always upgrade without Problem.

@dugs951 Okay, I think there's something else going on here. You could try deleting the vendor/ folder within the bookstack install and re-run composer install --no-dev just as a test.
Otherwise, This could be cause by your webserver running a different PHP  version than that used on the command line.
What version of Ubuntu are you using and have you installed multiple versions of PHP at any time?

I try it but dont work.
When i look under /etc/php i have Version 7.1 and 7.4
When i make php -v then i have this version
PHP 7.4.12 (cli) (built: Oct 31 2020 17:04:09) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Zend OPcache v7.4.12, Copyright (c), by Zend Technologies
I dont know what is the Problem, i make always upgrade without Problem.

And i have Ubuntu 20.04

And i have Ubuntu 20.04

When i look under /etc/php i have Version 7.1 and 7.4

Then there's a chance that Apache/Nginx is using PHP 7.1. Running php -v will only tell you the command line version of PHP in active use.

What webserver do you use?
Do you know why you might have 7.1 on your system? Did you upgrade from an older Ubuntu version or manually choose to install 7.1?

When i look under /etc/php i have Version 7.1 and 7.4

Then there's a chance that Apache/Nginx is using PHP 7.1. Running php -v will only tell you the command line version of PHP in active use.

What webserver do you use?
Do you know why you might have 7.1 on your system? Did you upgrade from an older Ubuntu version or manually choose to install 7.1?

I use Apache2
And i think Apache2 use 7.1
When i look /etc/php/7.1 i have apache and php.ini
And 7.4 i dont have apache Order
How i can change php Version for Apache2?

You could try:
sudo a2dismod php7.1
sudo a2enmod php7.4

Alternatively, You may want to look to completely remove php7.1 from the system if you're sure it's not needed by anything else and re-install php7.4 to get to a clean php setup.

Yes, i removed completely php then i install 7.4 and now is going.
Thank you so much.

Great news! Glad to hear the cause was found.


python-wapiti to conda-forge

hi @adsva
I work with tools in the open source community through the Anaconda package manager under the conda-forge channel and I recently run into libwapiti, which I'm suspecting that the way it was added has no direct link to the work you have here on github. It seems that another person packaged and distributed the repo on pypi.org but there is no information about the license under which it was released.
If you're interested in sharing your work to the Anaconda community, I would like to correct the errors others made by linking the package directly to your github account as well as with your permission and licensing. On your end, this w'd require adding a license type of your choice and creating a release version of your work on github.
Thank you for contributing the wrapper and, hopefully, people will at least start to show some level appreciation when they depend on your work.
Regards,
-Eddie

@adsva any movement on this? Would be very useful, as this package could be used as an upstream dependency for many packages in conda-forge.
Thanks!

@adbeda Sorry, missed your message for some reason. This is a pretty old repo, and I'm not sure everything still works as it should, no Python 3 support, etc. But in case anyone still finds it useful, I have followed your instructions and added a license and a release, is that enough to help you woth the packaging situation?

@adsva would you be able to do the same for https://github.com/adsva/libwapiti

@agcopenhaver I suppose, but I think the separate libwapiti repo is a bit outdated, since there have been changes in the version bundles in this repo. Perhaps the cleaner solution is to update the old repo, remove the libwapiti directory here and add it as a submodule instead, just like cwapiti. Would you agree?

Yeah, that probably makes more sense based on the age of libwapiti


Fix certificate_extensions test

Description of changes:
Don't reuse connections in certificate_extensions test.
Testing:
Unit tests passing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2131 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2131      +/-   ##
==========================================
- Coverage   81.07%   81.05%   -0.02%
==========================================
  Files         247      247
  Lines       18390    18390
==========================================
- Hits        14909    14906       -3
- Misses       3481     3484       +3


Add component gridHelper

I'm filling the pull request but there are actually 3 things I'm missing:

Cannot complete documentation. I modified the internalComponentCategories but gridHelper.js does not create after runnig gulp doc
I don't know what tests should I write :/
The component does not work, ups :sweat_smile:. When I try to mount it I get

2(index):1 [.CommandBufferContext]RENDER WARNING: Render count or primcount is 0.

I hope you can give me some orientation on these and I'll fix the request

Hi, thanks a lot for opening up the PR :D I'll help with the issues you're having :)

Okay after taking a look, the changes on staging/2.0 make gulp doc work now!
git checkout -b pepjo-components/grid-helper/add staging/2.0
git pull https://github.com/pepjo/react-three-renderer.git components/grid-helper/add
gulp doc

Looking at tests, I would start by checking if the current tests are not broken ( they should not be ).
I'm looking at the error you mentioned above now :)

Ok! Thanks, I'll look into it this next week :)

I'm sorting these out now that I have more time :D

/!\ Since Three.js r79,  step property is now divisions (See r79 release changelog).
I don't know if r3r 2.3.2 should support only r79 and higher versions ?


[Request] File Statistics

It would be nice to list the file views as a statistic when you click your file in /files
i.e. here: http://dash.lunardev.group/u/0NrXRK.png
Also maybe an addition to statistics to see accumulated views per user based on all uploads? (something like a leaderboard)
Making admins not be able to delete other admin accounts
Under /invites when an invite is used and marked as "(Used)" maybe add some text to say who it was used by?
Another suggestion; allow configuration for using SMTP email servers, per say I have my own email servers and I'd like to use it here for notifications, registrations, etc

Unfortunately, emails and other things like that are probably out of the scope for what Zipline can and should do so I do not have any plans on adding any sort of functionality with it.
Invites already say (Used) next to the code if they are used, although I won't be adding a field that says who used it as used invites get cleared out by a background task (defaults to 30m).


Simplify/consolidate our various Text Input components

When doing https://github.com/Expensify/App/issues/3133 and https://github.com/Expensify/eslint-config-expensify/pull/38 I noticed that we have many different Text Input components. We have:

ExpensiTextInput
TextInputAutoWidth
TextInputFocusable
TextInputWithFocusStyles
TextInputWithLabel

I don't think it's necessarily very obvious which of these should be used at a given time. Perhaps we can simplify these into one component and use props to differentiate things like whether they have a label or whether they are focusable.
cc @marcaaron since we were chatting about this in https://github.com/Expensify/eslint-config-expensify/pull/38.

Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Yeah, I agree we should do this. Maybe use composition of higher degree.

Any interest in taking it on?

Yeah, I am interested. I will look into it more to prepare a plan and submit here. It sounds complicated but I like complex things.

[ ] TextInput
I will merge everything in this component.

[ ]  TextInputAutoWidthWithoutKeyboard This can be easily merged.
Purpose of component

hide the main keyboard. We can have this functionality behind a prop.
Auto shrink and expand based on text enter text. This will be added as another prop. Although, currently it exist as a single component I feel this behaviour is completely different from point 1.

[ ] TextInputFocusable
Purpose of component

Parse Mardown and Rich text formatting.
I don't think we should merge this. This is dedicated to the composer. But I will rename it to something else to better reflect it. I

[ ] TextInputWithFocusStyles
Purpose of component

This is just used to change some styles when input is in a focused state and vice-versa.

Currently, I feel its usage is unnecessary and this can be refactored to use TextInput. Otherwise, I will add used props to TextInput to reflect the same behavior.

[ ] TextInputWithLabel
Not Found

[ ] TextInputWithName
Purpose of component

Support name attribute on Web brower.

The same behavior can be easily moved to TextInput.

[ ] TextInputWithPrefix
Purpose of component

Add a prefix Text to the input field.
Same this can be moved too behind a prop.

This is great thank you @parasharrajat. Would you mind posting this in #expensify-open-source in slack so that we get a little bit more visibility on this? I think it will be a non-controversial change, but given that we didn't go through the normal process here I think it'd be good to get a little more visibility and also to have that as an example to point to in the future. Thanks!

Here is the slack link for reference https://expensify.slack.com/archives/C01GTK53T8Q/p1642437182067200

Ok, thanks for posting that Rajat. It seems that there is general agreement on moving forward. My recommendation is that we break this up into several PRs in order to make it easier to manage. Let's do one PR for each component that is being merged into TextInput or updated. And then one PR for adding to storybook. We can do one Upwork job with each milestone being $250. Does that sound like a good/fair approach to you?

Yeah, I am in favor of doing that. Thanks @puneetlath .

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

Ok invited you to a job with 6 milestones. One for each of the 5 TextInput components that need to be refactored. And one for storybook.

Thanks, Puneet. I will start submitting PR as soon as possible. This is not much of a priority.

@rushatgabhane would you want to help out with reviewing these PRs. You weren't involved in the proposal, but given the scope, I'd love to have a C+ helping out this.

Yeah sure, I have time and would love to help here!

Awesome! I assigned you to the issue as well and to the first PR.

Thanks, I'm on it asap.

And then one PR for adding to storybook.

Whilst I agree with the proposal, I'm thinking it'll take too much time to figure out which combination of props to use for getting the desired look. This isn't a problem right now because we can find the text input being used somewhere else, and use it.
@parasharrajat do you think it's a good idea to document - the common types of text inputs being used in EXFY and the combination of props needed to achieve that in storybook? I hope I make sense

Hmm. I think there can be many combinations of TextInput usages. It would be extra effort to dig in the code and list down all at this time.
I would take a note on each PR and add stories for added new props in the last PR and a couple of more which can be possible. This is not a high priority issue thus I don't feel brainstorming those at this time, would help in achieve anything.
But you can take the proposal for your reference and each purpose will be converted to a story.

Also, @rushatgabhane

https://expensify.slack.com/archives/C01GTK53T8Q/p1642634857222800

I would suggest discussing that earlier is better.

Okay, that sounds fine.

I would suggest discussing that earlier is better.

Thanks! will do

If C+ team member is hired to fix an issue, no other C+ should be assigned and no one should be compensated for C+.

Hi @puneetlath, just wanted to clear this up :)

Yep, I basically decided to bypass that and hire you anyways as C+ on this because I think it will be helpful to have.

Cool! Where is that discussion happening?

That's what I am trying to find.... wait..

@puneetlath Here it is https://github.com/Expensify/App/issues/7308.

https://github.com/Expensify/App/pull/7937#issuecomment-1054872491
This comment suggests that the payout for rajat should go from $250 -> $500 for this GH fix.
(note - this fix will also address https://github.com/Expensify/App/issues/7308, where rajat will be paid an additional $250 for reporting said bug)

Thanks, @michaelhaxhiu. Got it.

Current assignees @parasharrajat and @rushatgabhane are eligible for the Exported assigner, not assigning anyone new.

Triggered auto assignment to @iwiznia (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@michaelhaxhiu @iwiznia I'm handing this over to y'all since I'm going on my two month sabbatical now.
@michaelhaxhiu  Contract for the fix: https://www.upwork.com/ab/c/8577561/contracts/29258288#milestones%2F20220131%2F20220301. There are separate milestones for each input that is being refactored/merged as well as one for the update to storybook.
Looks like there isn't a C+ contract so we'll need to create one for Rushat for that as well.
Thanks y'all!

Bye @puneetlath, see you after 2 months!

All PR merged. Waiting for issues to popup :stuck_out_tongue_winking_eye:

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.43-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/7984

If no regressions arise, payment will be issued on 2022-03-24. :confetti_ball:

Ping for

@michaelhaxhiu Requesting complete remaining payment.

@michaelhaxhiu  Could you please hold C+ payment for me on this issue until I request/ping you. I would like to wait for a week. Please put this on weekly so that you don't get notifications from MelvinBot. Thanks.

Sure, I think we can just delay 1 week if you prefer? The daily label will get re-applied the day before the payout, so it'll remind us that way.

@michaelhaxhiu sorry to bother you, but if it isn't too much trouble, I'd prefer C+ payout to be anytime before March 31st.
(0 tax for me then 😁)

Totally - I intend to pay you today :)

List of PRs that @rushatgabhane should be compensated for as a C+ on this milestone, which I would really appreciate a buddy check on:

$125 - https://github.com/Expensify/App/pull/7318 - Rushat wasn't paid for C+ one this yet, and there was 1 regression
$125 - https://github.com/Expensify/App/pull/7721 - there was 1 sneaky regression only.
$250 - https://github.com/Expensify/App/pull/7722 - no regressions
$500 - https://github.com/Expensify/App/pull/7937 - no regressions
$1000 - https://github.com/Expensify/App/pull/7984  - no regressions

Total payment for C+ reviews should be $2000? Let me know if this sounds correct @rushatgabhane?
Would mind your eyes on this too @iwiznia or @NikkiWines (esp for #5 - I feel unclear on that more than anything because it's a huge PR. I just can't tell what exactly it's solving to allocate prices properly).

@rushatgabhane I'm afraid this won't be paid today, I don't feel confident in the final answer yet. Going to look at what @parasharrajat shared here and hopefully get input from another teammate to ensure this is accurate

Sounds good!

@parasharrajat for the 5th milestone, aren't these additional issues fixed in same PR? So total is 1k including the issue itself
Please correct me if I'm missing something
MaxLength Counter is not incrementing automatically when a user types the value in the Story - https://github.com/Expensify/App/pull/7984#issuecomment-1059792552
When the label is forced to be active. Placeholder text is not visible until you focus the input - https://github.com/Expensify/App/pull/7984#issuecomment-1061063655
Autogrow does not work for unbound inputs- https://github.com/Expensify/App/pull/7984#issuecomment-1061193110

I was not paid other than the base milestone price to solve all of those issues. That PR refers to two milestones. So 500.

[x] TextInputFocusable
Purpose of component

Parse Mardown and Rich text formatting.
I don't think we should merge this. This is dedicated to the composer. But I will rename it to something else to better reflect it.

[x] Add Stories for all modes of the TextInput

I was not paid other than the base milestone price to solve all of those issues. That PR refers to two milestones. So 500.

Thanks, it makes sense now.
@parasharrajat @michaelhaxhiu so if we all agree that there are 3 new milestones, payment for #7984 should be :
$500 base + $750 for three new milestones = $1250

MaxLength Counter is not incrementing automatically when a user types the value in the Story - https://github.com/Expensify/App/pull/7984#issuecomment-1059792552

When the label is forced to be active. Placeholder text is not visible until you focus the input - https://github.com/Expensify/App/pull/7984#issuecomment-1061063655

Autogrow does not work for unbound inputs- https://github.com/Expensify/App/pull/7984#issuecomment-1061193110

Thanks for pitching in (both of you!!), I realize this isn't a fun exercise and think the milestone got a little confusing - but that's ok. I just want to make sure you are both fairly compensated.
So do we agree that @rushatgabhane is owed $1250 for all C+ work captured in this GH?

Here's what I'm understanding based on the latest points:

$125 - https://github.com/Expensify/App/pull/7318 - Rushat wasn't paid for C+ one this yet, and there was 1 regression
$250 - https://github.com/Expensify/App/pull/7721 - no regressions
$250 - https://github.com/Expensify/App/pull/7722 - no regressions
$500 - https://github.com/Expensify/App/pull/7937 - no regressions
$1250 - https://github.com/Expensify/App/pull/7984  - no regressions

So the total C+ payout is $2375? And that's because we added a few jobs to this contract that weren't initially a part of it?

My main question right now is about #2 - is https://github.com/Expensify/App/pull/7782 a legit regression to consider?

Yes it's a legit regression. #2 broke payments page which used to work before.

Based on this I will also need to be paid more $750 for the three new milestones that Rushat is proposing.

Yep, I agree with that. So we have the following payout for this milestone in order to close it out:
@parasharrajat - $2750
@rushatgabhane - $2250 (C+)
Can I get a 👍 from you both if this is good. Note to self - in future milestones, let's try to highlight payments as each GH deploys so it's easier to sum up in the end.

Reminder: Please release the payment after tomorrow for me.

All payments sent, closing.


Proto support for mesos 1.1.0

Hi @jdef , mesos 1.1.0 comes with the LaunchGroup feature.
It's there any plan on update proto files to mesos 1.1.x?
How do you think about LaunchGroup, is it production ready?
Thanks.

Hi --
I updated the next branch against the v1 protobufs in Mesos 1.1.x albeit somewhat painstakingly..
All the tests pass and I am able to get it to work some trivial scheduler code however the code in cmd/example-* still needs to be updated.
Would appreciate any feedback on the changes. @jdef
Next my intention is to begin adding functionality for the HTTP Operator.
Thanks!

/cc @cinchurge with respect to operator changes (I think you've already started, yes?)
@athlum w/ respect to production readiness, I think mesos 1.2 will have a more "hardened" implementation of LaunchGroup features. It's marked "experimental" in the 1.1 release for a reason.
@kevinschoon I'll make an effort to review your changes over the next week or so. FWIW there's a PR in flight for the 1.0 API already but it doesn't look like you built off any of those changes? (at least from the commit stream on your branch)

@jdef I had not noticed your changes for 1.0.1 before. I committed new branch based on those changes and did not need to modify any of your implementation. Please disregard the previous branch I had posted.

i'm in the process of merging changes for the maintenance apis from our internal branch over to github so we can make the push request here, i'll try to get it out asap

support for 1.1 has landed on master


Add PATCH HTTP method

Some API needs PATCHHTTP method.
This pull request implements it

Sorry, but as stated in the docs, you can do it with the map method :
qwest.map('PATCH', 'example.com')
     .then(function() {
        // Blah blah
     });

get~thanks~


change link color with respect to background color

PULL REQUEST TEMPLATE
My PR closes #51
👨💻 What did you do ?
made it so that the link becomes purple when the background blends with the link color
Note to reviewers
tried different ways llike chroma.js, colors.ja, but found this to work best
📷 Screenshots

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title and description of the PR is clear and explains the approach.
[x] I have read the contribution guideline properly and following the criteria.

impressive
merged


leadchange fix

sorry fella, this miss today's emergency fix release by like 4 minutes :(

ahhh, bit to slow there


Remove limit for number of chunks that a collection can contain

Is your feature request related to a problem? Please describe.
It's problematic for my usecase to have a limit on the number of chunks that can be uploaded to a collection.
Describe the solution you'd like
It would be great to be able to not have a limit on the number of chunks that can be uploaded to a collection. A collection can and should be able to exponentially grow over time.
Describe alternatives you've considered
OpenAI doesn't have a limit on the number of docs that can be uploaded to a collection.
(Is there any particular reason as to why that limit exists?)

@racso-dev thanks for your suggestion. Different chunk limits correspond to different vector index configurations. We'll soon add more capacity options in the next release. Stay tuned :-)


buildGoModule: vendoring doesn't copy C sources

Describe the bug
Some modules-based packages build fine when using modSha256, but break when using vendorSha256 because go mod vendor does not copy C files from the source.
To Reproduce
Attempt to build this package:
{ buildGoModule, fetchFromGitHub, lib }:

buildGoModule rec {
  pname   = "sqlc";
  version = "1.3.0";

  src = fetchFromGitHub {
    owner  = "kyleconroy";
    repo   = pname;
    rev    = "v${version}";
    sha256 = "1cj73zjbb1clc8c0dk8gzhzfycch5c6qfgzixc19kcpcq16sifyl";
  };

  vendorSha256 = "0y4n6w3dhplmkcd5lym7cngfn0h017sdzs2rw5bcabfyiyzm6dfa";

  subPackages = [ "cmd/${pname}" ];

  meta = with lib; {
    description = "Generate type-safe Go from SQL";
    homepage    = https://sqlc.dev;
    license     = licenses.mit;
    platforms   = platforms.linux ++ platforms.darwin;
  };

Expected behavior
It should build the sqlc binary with no errors.
Notify maintainers
@kalbasit
Metadata
I personally ran into this problem using nixpkgs @ 571212eb839d482992adb05479b86eeb6a9c7b2f, but it should be the same on master.

cc @c00w

I am surprised that go mod vendor does not handle that.
I think you can call modvendor manually in https://github.com/NixOS/nixpkgs/pull/86376/files#diff-e52a12f0ff2d93a44ea65f92f17aaac7R18 to copy the C code over.

If we get more of these case we might extend our buildGoModule abstraction.

Honestly this is never going to work. The upstream go issue is
https://github.com/golang/go/issues/26366
but in short, go is stripping the c code semi intentionally and you really shouldn't be distributing c via go :)
If you look in the tree there are multiple cases where c code had to manually be copied into the vendor folder.
@betawaffle The simplest solution if you're using your own source code is to make a vendor folder with the correct source, then set vendorSha256 = null; in your nix derivation. Alternatively, manually constructing the vendor directory within nix may also solve your problem.

I figured out a workaround, so this isn't causing a problem for me anymore. Also, I think I agree that this isn't really reasonable to fix, though it's disturbing that it works in the non-vendored case, but not in the vendored case.

Someone at https://github.com/golang/go/issues/26366 mentioned they wrote a tool: https://github.com/nomad-software/vend .

@doronbehar Nice - Let me see if I can make that an option :)

@doronbehar Done :D

thanks @c00w !

Upstream support for go tools modvendor seems at least planned in some way → https://github.com/NixOS/nixpkgs/pull/102426

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/trouble-packaging-sqlc/18261/3

@betawaffle would you mind sharing your workaround? I'm quite new to NixOS and I'm also trying to get sqlc

@betawaffle would you mind sharing your workaround? I'm quite new to NixOS and I'm also trying to get sqlc

I actually don't remember what the workaround was. Maybe @euank or @brhoades can re-discover it from the source?

Thank you for your answer. I found a workaround that works for me I posted over on discourse https://discourse.nixos.org/t/trouble-packaging-sqlc/18261/11
Is that workaround worth mentioning on the wiki for people running into similar problems or is it just an odd use case?

@eblechschmidt I checked the commit log for @betawaffle original workaround, and it was:
overrideModAttrs = (_: {
  postBuild = ''
   ${modvendor}/bin/modvendor -copy="**/*.c **/*.h **/*.proto" -v
  '';
});

(the full derivation was the following)

Original sqlc derivation
{ buildGoModule, fetchFromGitHub, lib, modvendor }:

buildGoModule rec {
  pname = "sqlc";
  version = "1.3.0";

  src = fetchFromGitHub {
    owner = "kyleconroy";
    repo = pname;
    rev = "v${version}";
    sha256 = "1cj73zjbb1clc8c0dk8gzhzfycch5c6qfgzixc19kcpcq16sifyl";
  };

  vendorSha256 = "1l0kshmml2qjfggfknadqwp991xfrhg1h569rblabccpni6y3l9x";

  subPackages = [ "cmd/${pname}" ];

  overrideModAttrs = (_: {
    postBuild = ''
      ${modvendor}/bin/modvendor -copy="**/*.c **/*.h **/*.proto" -v
    '';
  });

  meta = with lib; {
    description = "Generate type-safe Go from SQL";
    homepage = https://sqlc.dev;
    license = licenses.mit;
    platforms = platforms.linux ++ platforms.darwin;
  };
}

This was for an older version of sqlc, and also I think an older version of buildGoModule, so I kinda suspect it won't work anymore.
What we've got now is to just use runVend = true, which got everything to work.

Current derivation
{ buildGoModule, fetchFromGitHub, lib }:

buildGoModule rec {
  pname = "sqlc";
  version = "1.12.0";

  src = fetchFromGitHub {
    owner = "kyleconroy";
    repo = pname;
    rev = "v${version}";
    sha256 = "sha256-YlOkjqkhN+4hL1+KJ0TuqcbQXJad/bHZclgpgFPr4to=";
  };

  runVend = true;
  vendorSha256 = "sha256-DUYuTvI7vErXMXJiIKB371v/uyZwjrImKyXXooB43GQ=";

  subPackages = [ "cmd/${pname}" ];

  meta = with lib; {
    description = "Generate type-safe Go from SQL";
    homepage = https://sqlc.dev;
    license = licenses.mit;
    platforms = platforms.linux ++ platforms.darwin;
  };
}

I think the runVend = true; solution to this is recommended way to deal with this problem nowadays, and has some documentation indicating that, it just didn't exist yet when this issue was first filed.
Hopefully that helps, @eblechschmidt

@euank I found a (more complex) workaround before but your solution works as good. I think my problem was that I was running into caching "problems" that came from my lack of knowledge how nix works.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/trouble-packaging-sqlc/18261/14


Master Farmer Loot

expensive master farmer herb seeds should be reduced if under 71 farming like it does on osrs

Would halving the drop rate of Ranarr, Snapdragon and Torstol seeds below 71 farming suffice?

Some notes for this, the scaling/drop rates in game aren't actually known. The only like numerical info on the wiki is that level 71 number, so anything we do on OSB to try and replicate it would be inaccurate to however it works in game.


Qdldl cannot be properly installed on a mac m1 chip with latest poetry version (1.2.1)

Python version: pyenv local 3.10.0
OS version and name: Mac OS 12.6 (Apple M1 Pro)

[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] I have consulted the FAQ and blog for any relevant entries or release notes.

Issue
qdldl cannot be properly installed on a mac m1 chip with latest poetry version (1.2.1)
I have got an issue with the qdldl package when installing with poetry. I ran the issue in the poetry github but it is apparently an upstream issue for qdldl. See the issue on poetry : https://github.com/python-poetry/poetry/issues/6712
and the apparent solution: https://github.com/python-poetry/poetry/issues/6712#issuecomment-1269497542
in order for poetry to be able to properly install qdldl.

https://github.com/python-poetry/poetry/issues/6712#issuecomment-1290402594

I believe the culprit here is this: https://github.com/osqp/qdldl-python/blob/master/setup.py#L24-L28
I left a comment here: https://github.com/python-poetry/poetry/issues/6712#issuecomment-1290402594

Echoing that this issue is affecting users of the scikit-survival. We have folks with M1 chips that require sk-surv, and hence qdld (via osqp). Would greatly appreciate this being fixed!

Echoing that this issue is affecting users of the SyntheticControlMethods. Would greatly appreciate this being fixed!
Python version: pyenv local 3.11.2
OS version and name: Mac OS 13.0 (Apple M2 Max)

Hello @bstellato -- it appears the above is fixed in the repo but has not yet been propagated to PyPi. Can you make a new release? Thanks!

Dear Maintainers, I confirm that pip3 install --use-pep517 --no-binary qdldl qdldl runs without errors on mac aarch64. Thank you! (I suspect all other related issues are solved as well.)


Determine if we want to keep master branch protected to force Changelog update

I added branch protection on master to force the changelogs being updated during build it day in August. Let's discuss if this is something we should keep.

Honestly, I really like it. Low overhead and will enforce that we're not missing changelog entries.

Keeping the check, I like it ;)


Not working?

All of a sudden, it doesn't work. I double-click on it, and nothing.

Can you answer the following questions please:

what version of Foundry are you using?
what system and system version are you using?
what version of Tokenizer are you using?
can you open the developer console (F12) and see if any error messages appear when you try to open tokenizer

Thank you, I found the issue with the help of discord. I was missing a folder in data folder. Thanks!


Not able to start loading via Adapter

Hi,
I am not able to start loading my vehicle via the adapter.
I have RFID auth enabled, dip-switch 1.1 is set to off, so RFID OR X1 should enable loading.
But when I set enableUser = true, CurrentUser =16000 mA and output=true, nothing happens.
Dip-Sw1 has value 0x22,plug is 7 and state is 1.
How can I start loading without using the RFID-Token??
Thanks in advance & have a happy new year!
Martin

How did you close X1?

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi Volker,
I thought that setting output=true does that.
Is this just driven by hardware?
Thanks,
Martin
Von: Volker Sengler @.>
Gesendet: Sonntag, 2. Januar 2022 12:25
An: iobroker-community-adapters/ioBroker.kecontact @.>
Cc: Martin-Stein @.>; Author @.>
Betreff: Re: [iobroker-community-adapters/ioBroker.kecontact] Not able to start loading via Adapter (Issue #68)
How did you close X1?
—
Reply to this email directly, view it on GitHub https://github.com/iobroker-community-adapters/ioBroker.kecontact/issues/68#issuecomment-1003700736 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AHUVMC2CAB4LCY7IE6ZCWILUUAY2JANCNFSM5LCTSGLQ .
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 &mt=8&pt=524675>  or Android <https://play.google.com/store/apps/details?id=com.github.android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub &referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> .
You are receiving this because you authored the thread. https://github.com/notifications/beacon/AHUVMC7Y2ZRUF7U3GA7NJBTUUAY2JA5CNFSM5LCTSGL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHPJUEAA.gif Message ID: @.*** @.***> >
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEe6W66Je6rKAErnssm/KDvG9XEY4FAmHSv/YACgkQm/KDvG9X
EY6G2wf/Z3L4PqQA9IV23Pzh3hpeddcvy+spcaSKJ9MApKOGwi9HtsIHpVlAkqB7
BYJDTvre9aLjvzL52H2Lamxd1WRArl4N/K9M36etNd1r1CuinG8deasg+ByL91vQ
gT7oRv5LtZEhdfIbmDYfjfqCrWaLn2C6irIsi3eju1r60cXXOAnnZNiiVOtiDENj
e5PKHSp3dE3SHq97SA+g6LMDxQ7RyOUOLSNM93koks6HxxuVOHZ2FAqVIrOg9iag
zQnRxfL73/67BZ+EG1/KbKHG9kF8yZx14ZtCN7FJaP6CV9E6wSbj4D7fyw1N0NEh
eoj8aIZ+dzcIn+uZKDsZFJ5lodaQgA==
=4ATp
-----END PGP SIGNATURE-----

You can see state of X1 by state "input". This is a hardware switch (see installation manual of Keba). It cannot be switched by software.
But as long as DIP SW 1.1 is off, X1 is ignored.
If you have a c-series then you can only start charging without RFID-Token if the whitelist für RFIDs is empty. See UDP/installation manual of Keba.

Thank you for your explanations.
There are two commands Start /stop that take the RFID Tag as parameter.
I assume, that this could start & stop the loadingprocess if the whitelist has values?
Do you plans to implement this commands?
Kind regards,
Martin Stein

I can do, if I know what to do. How would you provide RFID data (id and key)? In settings of adapter? Or separate state in which both values would have to be written?
Since I only have a charging station without RFID I cannot test it, just implement it and you or some outher would have to test.

Hi,
I will try to implement it on my own,so I can test it directly with my box. When I am ready I will start a pull request.
Thank you for your time.
Martin


Adding an option to allow automatic shebang even when current dir is not in $PATH

Hi, Nogueras. First of all, great plugin you have created. Works like a charm.
I would like the addition of an option with which even if current directory is not in $PATH, automatic shebang is applied.
Maybe something like modifying already existing variable automatic to have an extra value ignore_path would be possible I think.
I see that there is already a PR i.e. #1 by @mgabs but it only adds a new variable and nothing more as far as I can see.
I would love to contribute in adding this feature if you would like that and if the scope of this plugin allows such a feature. If not, then no problem at all.
Thanks for reading through my essay. Hoping to hear from you.

Hi @shreyas-a-s , thanks you for your nice words.
If I understand the issue correctly, you would like to automatically add shebang to ALL new files?

@Susensio Yes, Exactly. Irrespective of whether the file is in $PATH or not.

@Susensio Yes, Exactly. Irrespective of whether the file is in $PATH or not.
EDIT: That's because I usually create bash, python, etc. scripts in non-PATH directories. For example in /home/shreyas/test. I would like the shebang to be automatically applied when creating new files in that directory.
I know it is ppssible with autocommands. But an inbuilt option would be much simpler.

I find it interesting that this feature is being proposed twice already. I would like understand the use case better to get proper implementation.
What if you are working in a large python project? By large I mean multiple modules. Everytime you edit a .py file, a shebang would be inserted and the file would be made executable. I think that behavior would be unintended.
Maybe an interesting solution would be to add custom paths as an option, maybe using glob patterns.
That way you could define additional paths beside PATH.
What do you think? Would it work for you?
BTW: you could always use the :Bang command, maybe keymaping it to a shorter combination.

The 'adding shebang' part only works for new (python) files, right? If so I don't think it would be that problematic.
But I really forgot about the 'making it executable' part. Thanks for letting me know. That might bring some issues.
Hence I think the custom paths option that takes in a table of globs would be the desired solution.
Because for my use case, currently I only need this new feature to work on .sh files in a specific directory (for example ~/test) hence I think the glob that I might use would be ~/test/*.sh.
I don't know much about the programming implications of adding such a feature. I'm still learning. But I would love to help in any manner in making this feature possible.

Sorry for the late replay. If you like to, you can implement it and send a PR. I was thinking in an extra_paths config that accepts simple globs.

It's absolutely fine for the late reply. We all have other things to do right! The fact that you have replied is the important part.
extra_paths seems good to me too. Since I am still a beginner when it comes to programming, I don't know how good my coding would be nor would it work. But with a bit of help from your side, I think I can do it. I will implement it and send the PR. Then we can discuss and modify it accordingly. Is that ok with you?

That's perfect. If you need any help understanding my code, just ask.

For sure.

Hey Shreyas, thanks for your work.
Your implementation seems good.
Regarding your concern about globs, I think globs are more user friendly than lua patterns, and I would rather use them. But the implementation may be simpler! Autocmd patterns [:h autocmd-pattern] are close enough to shell globs. Then, check_against_globs would not be needed. Only the autocmd.
I haven't tested it but I think it should work.
What do you think?

Now that I think about it, are globs even needed here?
I mean, if extra paths is a list of directories, that would be more consistent with system PATH.
e.g.
extra_paths = {
  "~/bin",
  "~/coolproject/scripts/"
}

That should get translated into
vim.api.nvim_create_autocmd(
  "BufNewFile",
  {
    pattern = {
      "~/bin/*",
      "~/coolproject/scripts/*"
    }
    ...
  }
)

Hey Shreyas, thanks for your work. Your implementation seems good.
Regarding your concern about globs, I think globs are more user friendly than lua patterns, and I would rather use them. But the implementation may be simpler! Autocmd patterns [:h autocmd-pattern] are close enough to shell globs. Then, check_against_globs would not be needed. Only the autocmd.
I haven't tested it but I think it should work. What do you think?

Thanks for the good words, man. It truly motivates me.
Regarding globs-or-patterns, I agree that globs are more user-friendly and generally better. And about the autocmd pattern matching, thank you so much for letting me remember. It had totally gone through the top of my head that there is a pattern = '*' in even in the code I have written and that it accepts a table like pattern = {}. So definitely we can leverage that and it will allow us to remove the check_against_globs function and thereby making the code a lot simpler. I'll implement that change.

Now that I think about it, are globs even needed here? I mean, if extra paths is a list of directories, that would be more consistent with system PATH. e.g.
extra_paths = {
  "~/bin",
  "~/coolproject/scripts/"
}

That should get translated into
vim.api.nvim_create_autocmd(
  "BufNewFile",
  {
    pattern = {
      "~/bin/*",
      "~/coolproject/scripts/*"
    }
    ...
  }
)

That's totally true. If extra_paths is a table of directories then we just need to code the addition of * to the end of them and we can directly use the table something like pattern = M.config.extra_paths.
The reason I brought up the use of globs was so that the application of shebang can be made a bit more granular. What I mean by that is, if we allow only directories to be placed inside extra_paths table, then a user can choose a folder and shebang will be applied to all new files in it. But if we allow globs, the user can explicitly choose whether to apply shebang to all files i.e extra_paths = { "~/newfolder/*" } or just for one particular type of file extra_paths = { "~/newfolder/*.extension" }.
But now that I think more, this scenario is a bit too niche to even think about it. So I am also getting to a point where I think we should just roll with 'allowing only directory paths' in the extra_paths table. Right? I would greatly appreciate your point of view on this.

But now that I think more, this scenario is a bit too niche to even think about it. So I am also getting to a point where I think we should just roll with 'allowing only directory paths' in the extra_paths table. Right? I would greatly appreciate your point of view on this.

What is your personal use case? Would you use globs per filetype?

Two scenarios I see here:
only directories

Prevent errors: ensure no glob * is in extra_paths, error and warn otherwise
Normalization: for each extra paths (on saving config) remove last forward slash / if present.
Make pattern: on creating autocmd, add /* to each extra_path to make the pattern work

This seems doable and easy
allow globs

Detect when should each extra_path be modified or left as is. This is not trivial. And can lead to unexpected behaviour.
-- Maybe search for * in the string? But * could be in a parent path such as */bin and that should be converted into */bin/*
-- Only search * in the last component of path? /foo/bar* could mean a script /foo/bar_64 or a folder /foo/bar_64/*

If the above can be accomplished, normalize and make pattern when needed

If you don't think you would use globs, I would rather keep it simple and only allow directory paths. The other option is... too magic I think

To be honest, now I really don't know where the thought of globs came from. I don't think I would need globs. Because my use case is that I have a directory that is ~/tests and I want the new shell/python scripts I create inside that directory to have shebang applied automatically. That's all I wanted in the first place.
So at the moment there is not really a good reason to opt for globs, especially since it requires more work.
Hence let's go with allowing only directories in the table.
Now when it comes to implementation part

Prevent errors: ensure no glob * is in extra_paths, error and warn otherwise
Normalization: for each extra paths (on saving config) remove last forward slash / if present.
Make pattern: on creating autocmd, add /* to each extra_path to make the pattern work

How are you thinking of implementing that? Detecting * in the table items and doing a print() is what comes to my mind. Is there any other way of doing that?
This means creating a function (maybe even named normalise_paths) and removing all the trailing slashes, right?
For adding /* to end of each item in extra_paths, do another function or is it any better alternatives to doing so?

Also, I think it would also be necessary to convert '~' in items to actual HOME path using something like the code below so that users don't need to write the full path to home directory.
  local home = os.getenv("HOME")
  modified_path = path:gsub("^~", home)

To be honest, now I really don't know where the thought of globs came from. I don't think I would need globs. Because my use case is that I have a directory that is ~/tests and I want the new shell/python scripts I create inside that directory to have shebang applied automatically. That's all I wanted in the first place.
So at the moment there is not really a good reason to opt for globs, especially since it requires more work.
Hence let's go with allowing only directories in the table.
Now when it comes to implementation part

Prevent errors: ensure no glob * is in extra_paths, error and warn otherwise
Normalization: for each extra paths (on saving config) remove last forward slash / if present.
Make pattern: on creating autocmd, add /* to each extra_path to make the pattern work

How are you thinking of implementing that? Detecting * in the table items and doing a print() or vim.notify() is what comes to my mind. Is there any other way of doing that?
This means creating a function (maybe even named normalise_paths) and removing all the trailing slashes, right?
For adding /* to end of each item in extra_paths, create another function or is there any better alternatives to doing so?

Also, I think it would also be necessary to convert '~' in items to actual HOME path using something like the code below so that users don't need to write the full path to home directory.
  local home = os.getenv("HOME")
  modified_path = path:gsub("^~", home)

Hi @shreyas-a-s, and sorry again for the delay.
About your points:

vim notify seems a good idea. I would use a low level logging level and let the user know that glob usage is discouraged. I think we don't need to fail, just warn.
sounds good
maybe just string concatenation som_var .. "/"

I think that ~ is handled already in  autocmd pattern, but I could be wrong.

Again, it's absolutely no problem, mate :)

I might need a bit help in that.
Cool
Yeah, that'll work
From my testing ~ is not handled by autocmd, but I'll look into it a bit more.

At this point, I feel we've touched all the important points. I think It'd be best if I create a PR and we discuss and modify that. You ok with that?

I might need a bit help in that.
something like vim.notify("Our message...", vim.log.levels.DEBUG) should do it

From my testing ~ is not handled by autocmd, but I'll look into it a bit more.
I've read in :h autocmd-pattern that ~ should be expanded, but right now i'm having a problem in my config with this same issue and I think you may be right, idk... I'll take a look as well
And ~ can be used for the home directory (if $HOME is defined): >
:autocmd BufWritePost ~/.config/nvim/init.vim   so
:autocmd BufRead ~archive/*      set readonly
The environment variable is expanded when the autocommand is defined, not when
the autocommand is executed.  This is different from the command!

At this point, I feel we've touched all the important points. I think It'd be best if I create a PR and we discuss and modify that. You ok with that?

perfect, give it a go!

:h nvim_create_autocmd
You were right, thanks for pointing that out, I've just solved a bug in my config =)

Note: pattern is NOT automatically expanded (unlike with :autocmd), thus names like "$HOME" and "~" must be expanded explicitly:
pattern = vim.fn.expand("~") .. "/some/path/*.py"


Change returned -2 to 0 in EVP_Digest{Sign,Verify}Init()

The returned -2 was to mark when these operations are unsupported.
However, that breaks away from the previous API and expectations, and
there's not enough justification for that not being zero.

@romen, thanks for your input in #10805...  here's the other way to deal with this issue :smile:

I believe that excluding the change to crypto/evp/m_sigver.c this PR should be backported to 1.1.1 as well.
Do we need a separate PR for that in this case?

Do we need a separate PR for that in this case?

I don't think so.  You've essentially approved a selective backport, and it should be clean.

LGTM !
What could we do to put this on the path for revision for a release after 3.0?
I share the wish of uniformity across the board for the family of EVP_<someop>_init() and it seems reasonable to dedicate a return value (-2 is somewhat our default for this in many places) for the "op not supported with this obscure key you gave me".

I'd really like to be able to do this as well, but having reflected about the broader topic a lot over the past several months, I'm coming around to think that the only reliable way to effect this kind of change is to define completely new APIs with the "proper semantics", and go through the full (5-year) deprecation cycle for the old APIs.  The risk of silently breaking applications seems to outweigh the marginal consistency gains, otherwise.


[Feature Request] mouse drag support

It would be very useful if we want to hide arrows when the browser page width is low, so the client can scroll using the mouse instead.

You are right, this feature could improve the user feeling,  I’ll look closer to the solution in a free time. 😊

Thank you for your effort. 😄


Yarn workspaces: look inside package.json files for package names to ignore

Example repo: https://github.com/tunnckoCore/elmaz
Cc @charlike
It produces server-side warnings like this:
    "repository": "tunnckoCore/elmaz",
    "packageFile": "packages/create-actor/package.json",
    "depType": "dependencies",
    "dependency": "@elmaz/emitter",
    "msg": "Failed to look up dependency",

This "missing" package can actually be found here: https://github.com/tunnckoCore/elmaz/blob/master/packages/emitter/package.json#L2
It looks like the only way to know to ignore this dependency is:

Trigger behaviour based on "workspaces" field in root package.json (we already do this)
For each package.json inside the workspaces packages directory, read the package.json (we already do this too)
Add each module name to our ignored list and do not attempt to renovate (we do not do this. currently we just use the directory name)

Don't know. It's not a problem. I will publish it soon, just trying the workspaces for the first time and playing with some Elm-like ideas/implementations..
I don't you need a fix. In most cases packages will be published.

Yeah, it's not really a big issue.

If packages are published then usually they should always be up to the latest anyway. i.e. Renovate's lookup will never return upgrades available

Unpublished packages will fail the lookup and generate this warning, but they won't cause any lock file generation to fail, because yarn will figure that part out

If the directory name is the same as the package name, this problem won't happen at all


Generate Release Notes (Crossplatform) not generating output file when using a release pipeline

Hello,
when trying to use the "Generate Release Notes (Crossplatform)" task in a build pipeline, the output file is generated accordingly.
But when using the task in a release pipeline, the task itself is running fine but no output file is generated on the disk.
The task itself is placed in a task group for reuse in multiple pipelines. Using the task directly in the pipeline makes no difference to the missing output file. The task config is as following:

Here is the output of the task in the build pipeline (working and generating the file):

2021-07-23T13:27:22.9373292Z ##[section]Starting: Generate Release Notes based on Release Comparison API
2021-07-23T13:27:22.9487336Z ==============================================================================
2021-07-23T13:27:22.9487671Z Task         : Generate Release Notes (Crossplatform)
2021-07-23T13:27:22.9487979Z Description  : Generates a release notes file in a format of your choice from the build or release history
2021-07-23T13:27:22.9488232Z Version      : 3.57.2
2021-07-23T13:27:22.9488418Z Author       : Black Marble
2021-07-23T13:27:22.9488773Z Help         : Version: 3.57.2. More Information
2021-07-23T13:27:22.9489156Z ==============================================================================
2021-07-23T13:27:23.3171245Z (node:6120) Warning: Use Cipheriv for counter mode of aes-256-ctr
2021-07-23T13:27:23.3171814Z Creating Azure DevOps API connections for https://dev.azure.com/*********/ with 'allowRetries' set to 'true' and 'maxRetries' count to '20'
2021-07-23T13:27:23.3236611Z Creating the credential handler from the OAUTH token
2021-07-23T13:27:23.5491914Z Getting the current build details
2021-07-23T13:27:23.7208311Z Getting items associated with only the current build
2021-07-23T13:27:23.9758803Z Get the artifacts consumed by the build
2021-07-23T13:27:24.0524213Z Get the file details associated with the commits
2021-07-23T13:27:24.0528686Z Enriched change C32657 of type TfsVersionControl
2021-07-23T13:27:24.1839173Z Enriched with details of 1 files
2021-07-23T13:27:24.1839860Z Get any test details associated with the build
2021-07-23T13:27:24.3238112Z Get any manual test run details associated with the build
2021-07-23T13:27:24.4028019Z Removing duplicate Commits from master list
2021-07-23T13:27:24.4036926Z Expanding the truncated commit messages...
2021-07-23T13:27:24.4037226Z Expanded truncated commit messages 0
2021-07-23T13:27:24.4040100Z Find any WorkItems linked from GitHub using the AB#123 format
2021-07-23T13:27:24.4043298Z Adding 0 found using AB#123 links in GitHub comments
2021-07-23T13:27:24.4043614Z Removing duplicate WorkItems from master list
2021-07-23T13:27:24.4045252Z Get details of [1] WIs
2021-07-23T13:27:24.4045517Z Getting full details of WI batch from index: [0] to [1]
2021-07-23T13:27:24.6462628Z Adding [1] items
2021-07-23T13:27:24.6463300Z Leaving WI in default order as returned by API
2021-07-23T13:27:24.7187508Z The default artifact for the release was not linked to an Azure DevOps Git Repo Pull Request
2021-07-23T13:27:24.7214746Z Getting all completed Azure DevOps Git Repo PRs in the Team Project BI
2021-07-23T13:27:24.8514691Z Enriching known Pull Requests
2021-07-23T13:27:24.8519460Z Total Builds: [0]
2021-07-23T13:27:24.8519783Z Total Commits: [1]
2021-07-23T13:27:24.8520064Z Total Workitems: [1]
2021-07-23T13:27:24.8520498Z Total Related Workitems (Parent/Children): [0]
2021-07-23T13:27:24.8520845Z Total Release Tests: [0]
2021-07-23T13:27:24.8521149Z Total Tests: [0]
2021-07-23T13:27:24.8521461Z Total Manual Test Runs: [0]
2021-07-23T13:27:24.8521793Z Total Manual Test Configurations: [0]
2021-07-23T13:27:24.8522152Z Total Pull Requests: [0]
2021-07-23T13:27:24.8522472Z Total Indirect Pull Requests: [0]
2021-07-23T13:27:24.8522796Z Total Consumed Artifacts: [0]
2021-07-23T13:27:24.8559215Z Using in-line template
2021-07-23T13:27:24.9026130Z Loading handlebars-helpers extension
2021-07-23T13:27:25.2639684Z Completed processing template
2021-07-23T13:27:25.2640197Z Appending output to file D:\ADOSAgent_work\24\s\notes.md
2021-07-23T13:27:25.2717214Z Finished writing output file D:\ADOSAgent_work\24\s\notes.md
2021-07-23T13:27:25.2779674Z ##[section]Finishing: Generate Release Notes based on Release Comparison API

Here is the output of the task in the release pipeline (working but no file generated):

2021-07-23T13:23:11.0310711Z ##[section]Starting: Generate Release Notes based on Release Comparison API
2021-07-23T13:23:11.0733897Z ==============================================================================
2021-07-23T13:23:11.0734471Z Task         : Generate Release Notes (Crossplatform)
2021-07-23T13:23:11.0735091Z Description  : Generates a release notes file in a format of your choice from the build or release history
2021-07-23T13:23:11.0735596Z Version      : 3.57.2
2021-07-23T13:23:11.0736403Z Author       : Black Marble
2021-07-23T13:23:11.0737911Z Help         : Version: 3.57.2. More Information
2021-07-23T13:23:11.0739609Z ==============================================================================
2021-07-23T13:23:11.8457340Z Creating Azure DevOps API connections for https://dev.azure.com/*********/ with 'allowRetries' set to 'true' and 'maxRetries' count to '20'
2021-07-23T13:23:11.8468918Z Creating the credential handler from the OAUTH token
2021-07-23T13:23:12.1004847Z Getting the current release details
2021-07-23T13:23:12.2323341Z Show associated items for primary artifact only is set to false
2021-07-23T13:23:12.2326912Z Getting the Environment Id
2021-07-23T13:23:12.2333243Z Identified [releasenotes] as having id [18]
2021-07-23T13:23:12.2981059Z Found 1 successful releases
2021-07-23T13:23:12.2982939Z Finding the last successful release HR_Release_2021-07-23_14-56
2021-07-23T13:23:12.2984341Z Getting all artifacts in the current release...
2021-07-23T13:23:12.2992961Z Found 1 artifacts for current release
2021-07-23T13:23:12.5131811Z Getting all artifacts in the most recent successful release [HR_Release_2021-07-23_14-56]...
2021-07-23T13:23:12.5156723Z Found 1 artifacts for most recent successful release
2021-07-23T13:23:12.5266127Z Looking at artifact [_HR-RELEASE]
2021-07-23T13:23:12.5273341Z Artifact type [Build]
2021-07-23T13:23:12.5274669Z Build Definition ID [213]
2021-07-23T13:23:12.5278159Z Build Number: [HR-RELEASE_20210723.1]
2021-07-23T13:23:12.5281571Z Is Primary: [true]
2021-07-23T13:23:12.5282847Z Looking for the [_HR-RELEASE] in the most recent successful release [HR_Release_2021-07-23_14-56]
2021-07-23T13:23:12.5284145Z Found artifact [_HR-RELEASE] with build number [HR-RELEASE_20210723.1] in release [HR_Release_2021-07-23_14-56]
2021-07-23T13:23:12.5285382Z Build for artifact [_HR-RELEASE] has not changed.  Nothing to do
2021-07-23T13:23:12.5286332Z Getting test associated with the latest build [14413]
2021-07-23T13:23:12.6536533Z Found 0 test associated with the build [14413] adding any not already in the global test list to the list
2021-07-23T13:23:12.7621297Z Adding the build [14413] and its association to the unified results object
2021-07-23T13:23:12.7625193Z Get details of [0] WIs
2021-07-23T13:23:12.7626685Z Detected 0 commits/changesets and 0 workitems between the current build and the last successful one
2021-07-23T13:23:12.7628193Z Detected 0 automated tests associated within the current build.
2021-07-23T13:23:13.1736593Z Detected 0 test plans associated within the current build.
2021-07-23T13:23:13.1800839Z
2021-07-23T13:23:13.8535690Z Removing duplicate Commits from master list
2021-07-23T13:23:13.8544207Z Expanding the truncated commit messages...
2021-07-23T13:23:13.8545566Z Expanded truncated commit messages 0
2021-07-23T13:23:13.8546491Z Find any WorkItems linked from GitHub using the AB#123 format
2021-07-23T13:23:13.8551066Z Adding 0 found using AB#123 links in GitHub comments
2021-07-23T13:23:13.8563633Z Removing duplicate WorkItems from master list
2021-07-23T13:23:13.8564309Z Get details of [0] WIs
2021-07-23T13:23:13.8564879Z Leaving WI in default order as returned by API
2021-07-23T13:23:13.9201469Z The default artifact for the release was not linked to an Azure DevOps Git Repo Pull Request
2021-07-23T13:23:13.9203974Z Getting all completed Azure DevOps Git Repo PRs in the Team Project BI
2021-07-23T13:23:14.0300209Z Enriching known Pull Requests
2021-07-23T13:23:14.0305895Z Total Builds: [1]
2021-07-23T13:23:14.0306432Z Total Commits: [0]
2021-07-23T13:23:14.0306898Z Total Workitems: [0]
2021-07-23T13:23:14.0307438Z Total Related Workitems (Parent/Children): [0]
2021-07-23T13:23:14.0308107Z Total Release Tests: [0]
2021-07-23T13:23:14.0309454Z Total Tests: [0]
2021-07-23T13:23:14.0310178Z Total Manual Test Runs: [0]
2021-07-23T13:23:14.0310845Z Total Manual Test Configurations: [0]
2021-07-23T13:23:14.0311570Z Total Pull Requests: [0]
2021-07-23T13:23:14.0312229Z Total Indirect Pull Requests: [0]
2021-07-23T13:23:14.0312930Z Total Consumed Artifacts: [0]
2021-07-23T13:23:14.0340949Z Using in-line template
2021-07-23T13:23:14.0875290Z Loading handlebars-helpers extension
2021-07-23T13:23:14.6888691Z Completed processing template
2021-07-23T13:23:14.6890554Z Appending output to file D:\a\r1\a\notes.md
2021-07-23T13:23:14.6895496Z Finished writing output file D:\a\r1\a\notes.md
2021-07-23T13:23:14.7165980Z ##[section]Finishing: Generate Release Notes based on Release Comparison API

The task in the release pipeline does not throw an error, but the file can nowhere be found on disk. The path looks a little sketchy, because it should be "D:\ADOSAgent_work\r1\a", but every variable with path infos in the release pipeline is starting with "D:\a*", as can e.g. be seen in the following screen taken from the "Initialize Job" step.

The artifacts download to this physically non existing directory fine too:

We are using a self hosted agent.
Thank you for any tips and best Regards

The path  D:\a\r1\a\ would suggest a Microsoft Hosted agent, check what agent is being used for the release stage/job.

The new stage to the release tricked me really good. You are right, a MS hosted agent was selected :( Thank you for taking your time to help!


Fix #214 "Cannot" with association hash conditions : accessible_by generates incorrect SQL (Postgres / ActiveRecord)

Fixed issue of NULL values being filtered out by cannot definitions.

can you please give me a practical example of when this happens? I never saw using IS NULL this way.

I close due to lack of feedback. Feel free to reopen with a detailed explanation of the error


add summary option

Hi ,
I have tested MapCaller, it is cool. Could you add a summary option such as --summary-file so that user can read alignment summary in a file.  I want to use MapCaller in my own pipeline, so i can check the summary file anytime.
I try use > mapcaller.log 2>&1, but the log file would save something like below
^M0 paired-end reads have been processed in 0 seconds...

What user really need are:
All the<PHONE_NUMBER> paired-end reads have been processed in 44220 seconds.
<PHONE_NUMBER> ( 91.22%) reads are mapped properly.
<PHONE_NUMBER> ( 81.42%) reads are mapped in pairs.
        Estimated AvgCoverage = 88
        Duplication rate=69.41%
        Estimated fragment size = 333, insert size = 33
Identify all variants (min_alt_allele_depth=5)...
        Write all the predicted sample variations to file [4sample_mapcaller_raw.vcf]...
        34635289(snp); 1497902(ins); 1344402(del); 6008(trans); 269(inversion)
variant calling has been done in 264 seconds.
All done! It took 44751 seconds to complete the data analysis.

Thankyou!

Hello, I've updated MapCaller with logging the summary report. Please update your MapCaller. The argument is "-log job.log", default filename is "job.log". Thank you!

@hsinnan75 Thank you ! I will try it tomorrow.

Hello, I've updated MapCaller with logging the summary report. Please update your MapCaller. The argument is "-log job.log", default filename is "job.log". Thank you!

Hi, the log file is work well now.


typo fix and description review (#31)

(git cherry-pick b8d1b0bff9ef3d4a8c568069b93410a3b4917afe)

typo fix and description review

Signed-off-by: Nathan Weatherly<EMAIL_ADDRESS>
forgot to ran manifests

Signed-off-by: Nathan Weatherly<EMAIL_ADDRESS>

/assign @hanqiuzh @tphee

/lgtm


Use different penalty scores for two ends of the DNA sequence

Hi,
I'd like to ask for a feature request if it is feasible to do. I'd like to align a ~23 bp sequence to genome and find all similar sequences upto a certain mm/gap level. I already use glsearch36 for this type of search and parse the results of -m BB to look like:
CATTGCTAGACTTGACCCACNRG	CATTGCTAGACTTGACCCACAGG	||||||||||||||||||||||| 0	0	0	0	0	0
CATTGCTAGACTTGACCCACNRG	CATTGCCAGACTTGACCCACAA-	||||||.|||||||||||||||~	1	1	0	1	0	1
CATTGCTAGACTTGACCCACNRG	CATTGCCAGACTTGACCC-CGGG	||||||.|||||||||||~||||	2	1	1	0	0	0
I'd like to have the option to have "NRG" or another selected sequence at the 3' or 5' end of the aligned query sequence to have a different penalty for mismatches and gaps. Currently I modified the mm penalty matrix and I use "NRK" and assign different penalties for R and K, but this may have some side effects if K is used for other sequences in the query. Is it possible to have two separate penalty matrices for the two parts of the sequence or any other way to implement this?
Thank you,
Meltem

I will be away so I will not be able to answer your question completely, but one strategy you might try is using a PSSM with different weights at the ends.
Bill Pearson
On Aug 30, 2021, at 12:29 PM, Meltem Isik @.***> wrote:

Hi,
I'd like to ask for a feature request if it is feasible to do. I'd like to align a ~23 bp sequence to genome and find all similar sequences upto a certain mm/gap level. I already use glsearch36 for this type of search and parse the results of -m BB to look like:
CATTGCTAGACTTGACCCACNRG CATTGCTAGACTTGACCCACAGG ||||||||||||||||||||||| 0 0 0 0 0 0
CATTGCTAGACTTGACCCACNRG CATTGCCAGACTTGACCCACAA- ||||||.|||||||||||||||~ 1 1 0 1 0 1
CATTGCTAGACTTGACCCACNRG CATTGCCAGACTTGACCC-CGGG ||||||.|||||||||||~|||| 2 1 1 0 0 0
I'd like to have the option to have "NRG" or another selected sequence at the 3' or 5' end of the aligned query sequence to have a different penalty for mismatches and gaps. Currently I modified the mm penalty matrix and I use "NRK" and assign different penalties for R and K, but this may have some side effects if K is used for other sequences in the query. Is it possible to have two separate penalty matrices for the two parts of the sequence or any other way to implement this?
Thank you,
Meltem
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/wrpearson/fasta36/issues/33, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABQYNPZAYZDAKSINVVMYFQLT7PEZ5ANCNFSM5DCN3CMQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Update CircleCI configuration for pushing to container registries

Towards https://github.com/giantswarm/roadmap/issues/2979
This PR was created through automation by Team Honeybadger, to make sure that the container images built for this repository are available in the right registries.
For that, the CircleCI configuration is modified to use the new push-to-registries job instead of the old push-to-docker. This means that there is only one job for all registry pushes, and it simplifies the configuration by removing many parameters that are now set automatically or as defaults.
Notes

Since the PR is also changing the CircleCI job name to push-to-registries, the branch protection rules in this repository will likely require updating before the required checks can be green.
Dev images are sent to ACR (gsoci.azurecr.io) and Quay currently. If you need dev images elsewhere, you can add the according configuration as described in the documentation to the step configuration.

To the responsible team
Please,

Double-check the job dependecies (requires).
Double-check the job filters. Especially if this PR replaces several jobs with one, and the previous jobs had different filters, make sure that the filter includes all cases.
Update the changelog if you think this deserves a mention.
Approve and merge this PR once it's ready. No need to wait for the author in this case.
Get this done until 1st of December, so that we can move on with follow-up steps.

@piontec Can you please take a look here?
Circular job dependency detected: "run-tests" -> "push-to-registries" -> "augment-circleci-dockerfile" -> "push-to-registries"

@piontec Could you take a look here please?


contact issues

Floating point issues can occur for small minority carrier densities at contacts.  Even though it is not used to calculate a result, the code will still attempt to take a log of a very small number.

    #contact_model = "Potential -{0} + ifelse(NetDoping > 0, \
    #-V_t*log({1}/n_i), \
    #V_t*log({2}/n_i))".format(GetContactBiasName(contact), celec_model, chole_model)
    # TODO: fix error
    contact_model = "Potential -{0} + ifelse(NetDoping > 0, \
    -V_t*log(1 + {1}/n_i), \
    V_t*log(1+{2}/n_i))".format(GetContactBiasName(contact), celec_model, chole_model)

TODO in def simple_physics.CreateSiliconPotentialOnlyContact:

def CreateSiliconDriftDiffusionAtContact(device, region, contact, is_circuit=False):
    '''
      Restrict electrons and holes to their equilibrium values
      Integrates current into circuit
    '''
    # TODO: fix this
    contact_electrons_model = "Electrons - ifelse(NetDoping > 0, {0}, n_i^2/(1+{1}))".format(celec_model, chole_model)
    # TODO: fix this
    contact_holes_model = "Holes - ifelse(NetDoping < 0, +{1}, +n_i^2/(1+{0}))".format(celec_model, chole_model)
    contact_electrons_name = "{0}nodeelectrons".format(contact)
    contact_holes_name = "{0}nodeholes".format(contact)

note that the 1 placed in the log function and the denominator of the other function may interfere in extended precision.

also remove 1e-10
celec_model = "(1e-10 + 0.5*abs(NetDoping+(NetDoping^2 + 4 * n_i^2)^(0.5)))"
chole_model = "(1e-10 + 0.5*abs(-NetDoping+(NetDoping^2 + 4 * n_i^2)^(0.5)))"


feat: add basic struct generation for Go

Description
This PR adds the very first steps for generating models in Go.  It is only supported the generation of struct type with simple field types:

number => int
integer => int
boolean => bool
string => string
object => struct
array => Either []<type> or []interface{}

Most of the code has been developed during a pairing session videocall that has been recorded:
Link: https://postman.zoom.us/rec/share/IqPkCzFU1LrVod8DtN5XqhRUnRjdlbrPgrMEfaqwyBop8Z6v3AThlhFSC8BAJyU1.D4Q1cSZUYcveTZbJ
Pass: 86?8XEFM
Next steps
From here, after review happens, this can be merged.
After, we should keep improving the support for generating go code. The most difficult part is generating union types such as enum or array of multiple types. We could use https://app.quicktype.io/ as guideline for this development.
Related issue(s)
https://github.com/asyncapi/modelina/issues/47

@smoya you have a few issues with some tests 🙂

@smoya you have a few issues with some tests 🙂

Yeah, also fixing linting issues.

Pull Request Test Coverage Report for Build 961109520

57 of 63 (90.48%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 94.263%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/generators/go/GoGenerator.ts
15
16
93.75%

src/generators/go/GoRenderer.ts
27
29
93.1%

src/generators/go/renderers/StructRenderer.ts
10
13
76.92%

Totals

Change from base Build 960306879:
-0.3%

Covered Lines:
1371

Relevant Lines:
1404

💛  - Coveralls

Sonarcloud fails because we are mainly introducing a new generator, which forced me to do some copy paste for the scaffolding of it. We could perhaps reunify or abstract some logic into shared one but this will also introduces complexity at this moment.
I definitely believe we can improve code reusability and/or make less contact points when creating new generators. However there is work to do on modelina side.
At this point, shall we make an exception on the Sonarcloud code duplication detector?
cc @magicmatatjahu @jonaslagoni @derberg @fmvilas

At this point, shall we make an exception on the Sonarcloud code duplication detector?

Accept it for now, but create a new issue to correctly solve this as there are pro/cons for both decisions, and not an easy solution 🙂

Good! But you also should write simple tests for presets like here https://github.com/asyncapi/modelina/blob/master/test/generators/typescript/TypeScriptGenerator.spec.ts#L111 :)

It's done !

Please update all relevant docs.

https://github.com/asyncapi/modelina/blob/master/docs/generators.md#supported-languages
Readme file.

We do not support Go language yet. It is not even exported so I would not include it in that list.

We do not support Go language yet. It is not even exported so I would not include it in that list.

Ahh did not see you had a discussion about not exporting the generator 🧐

Please add a blackbox test along the rest of the languages here: https://github.com/asyncapi/modelina/blob/master/test/blackbox/Dummy.spec.ts. It is to ensure that everything runs smoothly and can be "compiled" or what ever the language does 😄

I'm also asking myself if makes sense to do that at this moment since the generator is not exported. I mean, I can totally do it but I'm not sure if makes sense. The generator has it's own unit tests. Blackbox test would make more sense once we export it since we will be testing the end-to-end scenario.
But open to add the test here if you consider it should be there.

@magicmatatjahu @smoya added a comment to your discussion, feel like it is better to release it as a working generator and export it to be used (even though it is missing accessors/constructor)

@smoya do you mind creating follow-up issues with the changes to the go generator?

@all-contributors please add @smoya for code, test


Right-clicking on the test names in Unity's Test Runner and clicking "Open source code" doesn't work

Describe the bug

Looks like Unity's Input System tests suffer from this too, so it's not just us 😅

On further investigation, it looks like this feature might just be bugged for [UnityTest]s. It seems to work for [Test]s

This has literally always been the case for me since I can remember. Has never worked properly for me (I believe also in MRTK v2)

Ah dang, okay! I'll go ahead and close this out as External


[Removal]:

Hotspot Name
Icy Latte Ant
Hotspot b58 Address
11AoseC61muFgSizg2bj6Z86NK7pg276m2PaDE2nMaCAxZ6xRBs
Discord Handle
No response
Hotspot Manufacturer
PantherX
Removal Reason
I bought a used hotspot
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
No response

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


Serialize/deserialized chat content references

This got included in https://github.com/microsoft/vscode/pull/195030 anyway


Fix subscribe extension to return subscription

you forgot to return subscription in this extension.

whoops. Thanks for the fix!


emitUIInteraction is not defined, ue 5.3.2

Component your question relates to

[x] Signalling server
[x] Frontend library
[x] Frontend UI library

hi, i'm trying to recreate this: https://youtu.be/LKpDNmHO1Hk - in my case showcase.html includes a slider code and a custom slider.js with a function from his lesson, so browser's console shows both - category and item values like Object { Category: 1, Item: "84" } + i managed everything in bp in my app (bind event to on input & etc) but console says: "emitUIInteraction is not defined". please help me to figure out, is there some new restriction for this kind of interaction or i just need some extra setup for the newest javascript code? thanks in advance

if i play and change value on the slider there is no print string message

Hi,
That tutorial appears to be out of date.
Please download the Pixel Streaming showcase from the Epic Games launcher and follow these steps to set it up fully:
PS Showcase 5.3 docs
Once you have it set up you can modify the showcase.html and showcase.ts to add a slider and call emitUIIteraction, as shown here:
https://github.com/EpicGamesExt/PixelStreamingInfrastructure/blob/24890856667ef69d572481fe1b74ec5201d1bb27/Frontend/implementations/typescript/src/showcase.ts#L82
Regards, Luke.

hi Luke, thanks for the hint, i'll try this method. so i'll need to rebuild the ui-library after making changes, like this, right?
ui-library>npm run build
platform_scripts\cmd>build.bat --build

Yeah exactly, you can also do run_local.bat --build if you prefer to do it all one go.

I'm going to close this one out.


Create stored credentials factory type

This type should accept a string and create an instance of stored credentials.
The intention is that stored credentials are held in the database as a simple string value. This string would indicate:

The assembly qualified type name off the concrete credentials type
Any parameters specific to the credentials type, such as initialisation parameters, salt, key etc

Then, this factory type is responsible for creating the appropriate credentials instance from the string.

public interface IStoredCredentialsFactory
{
  object GetCredentials (string serialisedCredentials);

  TCredentials GetCredentials<TCredentials>(string serialisedCredentials);
}

Each stored credentials instance to be supported by this type must expose a constructor which accepts a single string parameter.
The generic version of the method constructs the credentials and then casts it. It raises an exception if the cast is not valid.

Actually, rather than using a naked string array, it's better to use a type which contains that array.
ICredentialsInitialisationInfo
Right now, this interface would only contain that array, but it could be extended later.


'import tensorbuilder as tb' does not work

Hi,
how can i import tensorbuilder from another directory or project? right now,  seems need copy all the tensorbuilder project into my project folder.

Hi,
There are several points here:

You need to have the dependencies, obviously tensorflow but also the decorator module you can get by pip install decorator
You need to be aware of your Python path. If you put the tensorbuilder folder on the root of your project as suggested but the script you are running is in a subfolder in your project it will not work. An alternative to this would be to move the tensorbuilder folder to where all your pip modules get installed.

@cgarciae Can we move the dependencies to a requirements.txt file and add a setup.py? This way the project follows standard python conventions.

@npezolano Sure. If you have experience with making proper python modules that would be of great help! I was planning to look into this in #2 .

@lfwin @npezolano I think this is fixed. Check out the new installation instructions
https://github.com/cgarciae/tensorbuilder#installation