React-semantic-ui not working on codepen

return (

<Grid.Column>
Individual Total Without Tip:
</Grid.Column>
<Grid.Column>
{individualTotalWithOutTip}
</Grid.Column>

  <Grid columns={2}>
          <Grid.Column>
            Individual Total With Tip:
        </Grid.Column>
        <Grid.Column>
          {individualTotalWithTip}
        </Grid.Column>
      </Grid>

  <Grid columns={2}>
          <Grid.Column>
            Total Tip Amount:
        </Grid.Column>
        <Grid.Column>
          {Math.floor((individualTotalWithTip-individualTotalWithOutTip) * props.numOfPeople * 100)/100}
        </Grid.Column>
      </Grid>

  <Grid columns={2}>
          <Grid.Column>
            Tip Per Person:
        </Grid.Column>
        <Grid.Column>
          {Math.floor((individualTotalWithTip-individualTotalWithOutTip) * 100)/100}
        </Grid.Column>
      </Grid>

    </Segment>
  );

I am beginner developer trying to use react-semantic-ui on codepen and it is not working. I don't really what I am doing wrong but I have the cdn linked. Please help me resolve this. I am stuck. Thanks.
here is the  codepen project: https://codepen.io/mohamudolow/pen/oRLewe

Consider to use CodeSandbox, it supports required syntax.
Codepen has no proper support of import/require, used destruction: https://codepen.io/anon/pen/PveXxm
-import { Button, Divider, Form, Grid, Segment } from 'semantic-ui-react';
+const { Button, Divider, Form, Grid, Segment } = semanticUIReact


New version: Microsoft.WindowsTerminal.Preview version 1.13.10734.0

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Support type: "closestDescendantMerkleValue" for chainHead_v1_storage

We recently released<EMAIL_ADDRESS>introducing a new feature: storage.watchEntries.
This feature uses the JSON-RPC spec for storage with the closestDescendantMerkleValue type. This provides the Merkle value for a partial key, allowing us to avoid re-requesting the entire list of entries on every block. Instead, it can compare the Merkle value (essentially a hash of all the nodes below that storage entry in the Merkle tree), and recompute the entries only if it changes.
Currently, Chopsticks' chainHead_v1_storage supports value and descendantValues but doesn't support closestDescendantMerkleValue yet.
I attempted to start implementing this, but I couldn't find any reference to the merkle tree data structure of the chain. I'm interested in contributing to this feature, but I would appreciate some guidance, or if it would need too big of a refactor.
Any pointers or suggestions on how to approach this would be greatly appreciated.

Chopsticks keeps storage diff for each block and doesn't have merkle tree and I don't see how we can implement it.

Presumably smoldot implements this RPC so we should be able to reuse its implementation. We should check smoldot's implementation to see the tree details. However, because Chopsticks isn't actually using merkle tree to store the states, the implementation won't be efficient.

I'm just thinking out loud, but in case it might makes thing substantially easier - polkadot-api doesn't need the actual "correct" merkle value, it just needs the property that it has to change if any of the nodes below have changed.
It wouldn't be spec-compliant, but if chopsticks only has diffs per block, maybe it could make it easier to increment an id.
If it's still complex, or if it still has to go through all the storage entries under that key, then maybe it's better to go the spec-compliant route of calculating the actual hash.

we can easily return a mock value. eg the block hash


Updated Deps

This commit updates the libStorage dependencies to remove the dependency on semver, update the one on Gofig, and update the Golang X deps.

[Current coverage][cc-pull] is 34.24%

Merging [#148][cc-pull] into [master][cc-base-branch] will decrease coverage by <.01%

File ...ypes_localdevices.go (not in diff) was modified. more

Misses +1
Partials 0
Hits -1

@@             master       #148   diff @@
==========================================
  Files            36         36
  Lines          1919       1919
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            658        657     -1
- Misses         1195       1196     +1
  Partials         66         66

Powered by Codecov. Last updated by [f500383...0e6a87f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/emccode/libstorage/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/emccode/libstorage/compare/f500383c3b10fb1d9e51033a6f5322ec678f4b35...0e6a87f52010158fcc2ed201c5498528fa9d66fc
[cc-pull]: https://codecov.io/gh/emccode/libstorage/pull/148?src=pr


Light color for inactive tabs

The text color of the inactive tabs is too light.

These should now be brighter:


[#1505] isCaughtUp() always returns true for pushing-"Event Streams"

This pull request introduce a minute change in the TrackingEventProcessor#processBatch(Segment, BlockingStream<TrackedEventMessage<?>>) method, namely moving the private checkSegmentCaughtUp method until after the first eventAvailabilityTimeout has been triggered.
Prior to this change, there was a window of opportunity within which an opened BlockingStream was referred to as empty whilst in actuality events were present. This can only occur of the underlying implementation of the  BlockingStream gets the events pushed (e.g. Axon Server), instead of pulling them itself (e.g. the EmbeddedEventStore). Further more, the checkSegmentCaughtUp validates whether the end of the BlockingStream has been reached and if this was true, the caughtUp flag was set to true. As an empty stream automatically means the end of the stream has been reached, caughtUp was set to true immediately.
Next to the aforementioned change, a test case has been added which uses some new AssertUtils methods.
This pull request resolves issue #1505.

SonarCloud doesn't take test cases into account which span distinct modules. As the tests for the TrackingEventProcessor are contained in the integration-test module, they "don't count". As such, SonarCloud's analysis will be ignored.


How to download files

I didn't find a place where I could download files.

@jieweili currently we don't have a streamlined way to download files. If they are files and not folders, clicking on them will most likely work as they'll open in the web browser.
If it's a folder, you'll need to download them one by one.
It will change soon as we approach the release of the new WebUI version. We'll then work on IPFS Desktop to make it more IPFS-y and much better!


"Băjești" is listed in the drop-down menu

Description:
"Băjești" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Băjești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Băjești, Argeș (Bălilești)".


Add more fully defined types for GridConfig.onXXXClicked() options

Currently our GridConfig interface defines the click-based interaction handlers like:
    /**
     * Callback when a row is clicked - will receive an event with a data node containing
     * the row's data. (Note that this may be null - e.g. for clicks on full-width group rows.)
     */
    onRowClicked?: (e: any) => void;

Can we provide a better function signature here using an event type from AG?

https://www.ag-grid.com/javascript-data-grid/grid-events/#reference-selection

@leogretz2 I thought this might be a good ticket for you to knock off in Hoist world while you're in the NY office - give me a shout if any questions - or better yet ask one of the Grid/TS experts onsite there 😉
It might be that I am glossing over some complexity and there is a reason why we don't have specific event types in place, but my guess is that we just didn't loop back and add them once we made the call to include the AG community library as a dep in hoist-react (precisely so we could use their types and interfaces in our Hoist code)


Initialize Doxygen Documentation

Wasn't sure if you were interested in this or not? Didn't know if you had prior experience with Doxygen. There are some nice things about it. We could start marking up code if you would like.

Not very interested in mantaining the doygen html files in the projext, but
doxyfile ia fine.  For most engine doc, godot uses classes.xml
On Jun 21, 2015 5:10 PM, "PeaceSells50"<EMAIL_ADDRESS>wrote:

Wasn't sure if you were interested in this or not? Didn't know if you had
prior experience with Doxygen. There are some nice things about it. We
could start marking up code if you would like.


docs pages not loading

So far VCF and data_exclusion aren't loading
@pdimens

Solved with commit https://github.com/pdimens/PopGen.jl/commit/0fd886aecb6f3bdcc77d2078e11bfe1947511db7


[cli][outputs] the cli will handle instances of the secrets bucket not existing better

to @jacknagz
cc @airbnb/streamalert-maintainers
size: small
changes

The cli will handle instances of the secrets bucket not existing better.
Also updating docs to include a note about terraforming on first run to get the streamalert.secrets bucket.

@mime-frame PTAL - tweaked a bit. also removed old secrets.rst file


JerryScript api improvemts accordign to jerry_api_value_t struct.

JerryScript-DCO-1.0-Signed-off-by: István Kádár<EMAIL_ADDRESS>

Please, fix missing comments and incorrect * formatting in this patch.

I've added missing comments in jerry.cpp and fixed pointer formatting.

Please merge commits into single one and LGTM.

I've fixed void parameters, added comments on parameters and function endings and merged commits into a single one.

lgtm

Merged (636ded489f8ea896763dc91ad91c045ff2918957)


35 4.3 email lists for mailing to participants

Coverage remained the same at 100.0% when pulling 87ba61918ea402aaeba618f8a56b234d4fa6f579 on 35_4.3_EmailListsForMailingToParticipants into d7e2099e8e0bb1c17907000140050284f1d7db97 on dev.

Coverage remained the same at 100.0% when pulling 17d1c512d3773d8b058609c8693e1d3a2bde48d4 on 35_4.3_EmailListsForMailingToParticipants into d7e2099e8e0bb1c17907000140050284f1d7db97 on dev.

Coverage remained the same at 100.0% when pulling 71546561bdbde41c58dc5adaccb9e9d6fd227b12 on 35_4.3_EmailListsForMailingToParticipants into d7e2099e8e0bb1c17907000140050284f1d7db97 on dev.

Coverage remained the same at 100.0% when pulling 05a7c012e3a8bb9c36f270f9780071ef19981416 on 35_4.3_EmailListsForMailingToParticipants into 28c8e8a3ae308d845db7f77898446d7bc1a20a46 on dev.

Obsolete.


k3s can't work well with coredns / kubedns , built by official website script

Environmental Info:
K3s Version:

k3s version v1.20.7+k3s1
go version go1.15.12
Node(s) CPU architecture, OS, and Version:

centos 7
ubuntu 18/20
Cluster Configuration:

single server / 1 server 1 agent
Describe the bug:

after i installed k3s by the offical website script
curl -sfL https://get.k3s.io | sh -
i found that coredns is installed and ran well too ,
`root@mt510:/home/mt510# kubectl get pods -n kube-system -o wide|grep coredns
coredns-854c77959c-n5mpf                  1/1     Running     16         69d   <IP_ADDRESS>   mt510
`
but actually , after i deployed a service like nginx,  i can't access it by using curl (or nslookup / dig) nginx.nginx.svc.cluster.local ,
same to whatever pod i used, but i can nslookup / dig kubernetes.default.svc.cluster.local !!!
so i assume that coredns work well but some settings is wrong , maybe k3s or kubelet ?
Steps To Reproduce:

Installed K3s:
curl -sfL https://get.k3s.io | sh -

Expected behavior:

create a nginx deployment and svc in nginx namespace, create annoter pod which with a curl / nslookup /dig util ,
and use the pod with the network utils to request the nginx by access nginx-xxxx.nginx.svc.cluster.local
Actual behavior:

it can't access the svc by request by the url nginx-xxxx.nginx.svc.cluster.local
Additional context / logs:

Backporting

[ ] Needs backporting to older releases

You are not expected to be able to resolve cluster addresses from outside containers running in the cluster. You'd normally expose things via LoadBalancer services, externaldns, etc.


chore: release 1.1.1

:robot: I have created a release beep boop
1.1.1 (2024-12-03)
Bug Fixes

publish build assets (#23) (31d0d8a)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.1.1
:sunflower:


Emergency compliments failing in CI intermittently

In this run, observe that test_emergency_compliment fails on Python 3.6 but not on 3.9. In a earlier run, it failed on 3.9. It's passing for me locally. Interestingly, the error is 404:
self = <Response [404]>

    def raise_for_status(self):
        """Raises :class:`HTTPError`, if one occurred."""

        http_error_msg = ''
        if isinstance(self.reason, bytes):
            # We attempt to decode utf-8 first because some servers
            # choose to localize their reason strings. If the string
            # isn't utf-8, we fall back to iso-8859-1 for all other
            # encodings. (See PR #3538)
            try:
                reason = self.reason.decode('utf-8')
            except UnicodeDecodeError:
                reason = self.reason.decode('iso-8859-1')
        else:
            reason = self.reason

        if 400 <= self.status_code < 500:
            http_error_msg = u'%s Client Error: %s for url: %s' % (self.status_code, reason, self.url)

        elif 500 <= self.status_code < 600:
            http_error_msg = u'%s Server Error: %s for url: %s' % (self.status_code, reason, self.url)

        if http_error_msg:
>           raise HTTPError(http_error_msg, response=self)
E           requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://spreadsheets.google.com/feeds/list/1eEa2ra2yHBXVZ_ctH4J15tFSGEu-VTSunsrvaCAV598/od6/public/values?alt=json

.tox/python/lib/python3.6/site-packages/requests/models.py:953: HTTPError

So it must be an issue with spreadsheets occasionally returning not found... maybe a bug in the spreadsheet.
For now, I'll just hobble the test.

That spreadsheet appears not to be available for me at all now. I'm now guessing that Google rolled out a change incrementally. I can see that the spreadsheet form of loading emergency compliments was added by me in b1c3b0e3fd3774b6153542aa734310829e858333.

I tried to replicate the technique that was used and found that even this published technique no longer works, so it does appear as if Google has turned down this feature.

I don't even recall where that spreadsheet came from. It seems I don't currently have access to it.

Ooh. It looks like others have had the same problem, with a possible solution.

It's annoying that this new technique requires a Google API key and requires that key to be configured with access to the Google Sheets API, so even though I already have a pmxbot testing and pmxbot API, they weren't authorized to use the API without a couple of steps. Now they're configured and I've confirmed that a technique does work, but it's probably more trouble than anyone will bother to use.
Also, I'd lost access to the compliments that were in the sheet, so I've created a new sheet. Internet is hard.


DictionarySciFi spelling correction: 'wihtout' should be 'without'

Hi,
Small item.  There's a spelling mistake on line 96: "4 wihtout 2, and we won’t 3 a 1.", of DictionarySciFi.java
Like the plugin,
Joe

finally fixed. thanks for reporting :-1:


Generate connection IDs

It will be useful if SDX Controller can generate connection IDs when a POST /connection request is made, perhaps in the form of UUIDs.  This way we can keep a better record of all the connection requests (including failed ones and successful ones) and perhaps more details like reason for failure.  So the response to POST /connection should be in the form of (just an example; we can figure out what useful information we can send eventually):
{
    "connection_id": "99f04453-fca1-4a5c-8454-ec5bb70fb04f",
    "status": "OK",
    "details": "Connection requests have been published"
}

Why UUIDs?  We currently assume that connection IDs are integers (in GET /connection/:connection_id and DELETE /connection/:connection_id), but it would be difficult to maintain unique connection IDs that way across restarts.  Using UUIDs as connection IDs should solve that problem.
Corresponding changes would be:

GET /connection/:connection_id would need to handle the UUID generated above.
DELETE /connection/:connection_id would pass the UUID to PCE so that PCE can tear down the internal states it made during connection setup.  This obviously calls for corresponding changes in PCE.

It will be useful if SDX Controller can generate connection IDs when a POST /connection request is made, perhaps in the form of UUIDs. This way we can keep a better record of all the connection requests (including failed ones and successful ones) and perhaps more details like reason for failure. So the response to POST /connection should be in the form of (just an example; we can figure out what useful information we can send eventually):
{
    "connection_id": "99f04453-fca1-4a5c-8454-ec5bb70fb04f",
    "status": "OK",
    "details": "Connection requests have been published"
}

Why UUIDs? We currently assume that connection IDs are integers (in GET /connection/:connection_id and DELETE /connection/:connection_id), but it would be difficult to maintain unique connection IDs that way across restarts. Using UUIDs as connection IDs should solve that problem.
Corresponding changes would be:

GET /connection/:connection_id would need to handle the UUID generated above.
DELETE /connection/:connection_id would pass the UUID to PCE so that PCE can tear down the internal states it made during connection setup.  This obviously calls for corresponding changes in PCE.

Hi @sajith great point! I totally agree with you that it would be much better if the SDX-Controller generates the connection_id and using the UUID seems to be the best option.

Hi @sajith great point! I totally agree with you that it would be much better if the SDX-Controller generates the connection_id and using the UUID seems to be the best option.

There's been a change of heart since this issue was written up though... :-)
My understanding now is that it should be SDX Controller's clients (namely Meican or some other API client) that should generate a unique connection IDs for each connection request.  Connection requests already carry a id field, and it is required.
SDX Controller should simply reject connection requests with duplicate IDs.  The IDs can be UUIDs or some other unique strings (formed from submitter + their domain + timestamp, or a hash of it, for example).  The actual ID should not matter as long as it is unique.

Hi @YufengXin , @congwang09 and @sajith since the idea now is that SDX-Controller clients should be the ones generating the connection ID, I have a few comments/doubts that I would like to hear your opinion:

When two different clients request different circuits but with the same connection ID, will SDX-Controller provide a API response that can differentiate that particular situation? This way the client will know that only the connection ID was duplicated and generate a new connection ID and try again.
Once we clarify the doubt above, should we have any number of maximum reretries a SDX-Controller client have to keep trying to create a new connection ID?
When a connection gets deleted, can the connection ID be reused ?

Finally, just out of curiosity, what would be the advantage of delegating the responsibility of generating unique connection identifiers for the Client (in a multi-client platform) instead of the SDX-Controller taking care of this?

@italovalcy Very good points. Thanks. @congwang09 knows better about the details: 1, 2, and 3 are necessary.
The last: the original logic was: if connection.id exists, take it, else: the server generates an uuid to assign. (1) the specification has the id attribute as a required; (2) (in our internal discussion, we said in general web application, the server side generates the resource id.) Now I think the 'else' statement is skipped.
We can finalize the decision after the first round of test passes since the Meican generates the id already.

@italovalcy If I understand correctly, the requirement for connection IDs is to be globally unique, and nothing much else.  Connection requests are required to carry an ID right now, or they will be rejected by validation step, even before they get to the methods that handle them.  To answer your questions:

SDX Controller should reject duplicates. (It doesn't do that right now AFAIK, but it should.)
Clients could use UUIDs, so that they don't have to re-try until they find a valid ID.
SDX Controller would be doing a DB lookup to detect duplicates.  Since SDX Controller keeps records of past connections, IDs should not be reused.

Finally, just out of curiosity, what would be the advantage of delegating the responsibility of generating unique connection identifiers for the Client (in a multi-client platform) instead of the SDX-Controller taking care of this?

There is no particular advantage to one party or the other generating connection IDs.  There simply should be an agreement that IDs are required to be globally unique (as far as one SDX Controller instance is concerned), and who should generate it.
Clients generating an ID would be the path of least resistance though, because that was the assumption when connection request format was initially made, and that is the assumption SDX Controller, PCE, and datamodel are operating with.


limiting api requests

I was wondering is there is a limited to restrict api requests to a certain ip address and deny any api calls from all other addresses?
I'm asking because even though we were using the admins api key we were got a rate limit error/
thanks

Not implemented right now but this isn't too hard to add via configuration and using a black- and whitelist.
The check has to be done early to ensure no code is executed prior to doing IP checks.

Also admin keys can't be whitelisted right now, but as you mentioned you want something for IPs instead. This should be easier to add.
Agreed that it has to be added to the Rate Limiting section too. Maybe the entire white and blacklist can be placed there.

thank you - for my own custom code I was just considering some additional code at the beginning of api.class.php to deny requests from any ip's other than my own IP's which will be issuing api calls.
sound reasonable?
ps: we were able to modify the code to return a list of all workers in the pool who had network hash rates - thanks for your help.

I would check the rate limiter and add it to that. Since the API class probably will not have any influence on the rate limiter, you'd still get blocked if you call the API too often.
PS: Excellent, it's not too hard to add but as mentioned in the other ticket that call is really expensive and not recommended for most pools ;-)

Thanks we have special needs for the pools (40) of them interfacing with Smarterhash.com. I've also made extensive use of symbolic links to eliminate redundancy across directories. We can create accounts and workers remotely from Smarterhash.com and do 'lots' of other things I'll be able to disclose soon.
Where exactly can I find the rate limiter?
thanks in advance.

It's probably done here: https://github.com/MPOS/php-mpos/blob/f996118d17c75e151db549afe1c5f7be0cf096f2/include/classes/memcache_ad.class.php

Closing for now.


Contributing to wiki

It's  no a real there is no an easy way to contribute to wiki
here is my initial proposal
https://github.com/KINGSABRI/packetgen-wiki/tree/master

That's a great start!
As for me, I was thinking about Getting started, which is in your proposal.
About wiki contribution, there seems to be only one solution: patches by email 😢

no problem for me, give me your email I'll send you my work once I've some

Ok another idea instead of the email is, great a new repository name it PacketGen-Wiki
and we can contribute to it, then you can copy these changes by yourself to the main wiki

Yes, I saw that yesterday while i'm googling. I think this repo will ease contribution to wiki. I'll do that this evening.

Here it is: https://github.com/sdaubert/packetgen-wiki


Command to get the service connection string

hi,
Can someone advice how do I get to see the underlying "Service Connection String" associated with the IoT hub, under which a particular device has been provisioned through IoT central?
I am able to create the "device connection string" fine, but need to know the above please.
Thanks and regards,

The connection string you got is the connection string to iothub.

Pardon me, but aren't there two types of connection strings related to an IoT hub?
Can you please let us know how to view both of these.
I'd like to use this string at the cloud to send  message to the device.
In short I need to accomplish C2D and would like to extract the suitable connection string for this purpose.

What type of C2D message do you need to send ? IoT Central supports Commands and Settings that are essentially the patterns to do C2D messages (documentation here)

Currently we don't expose IoT hub connection string, the only way to send C2D message is using Commands and Setting.

Thank you very much for your replies.
Would you know if there is any plans to do that in the near future, i.e. being able to trigger C2D device-methods?
Or is there anyone we can reach out to know if this feature is in the pipeline? We have some interesting usecases, and this Saas should be a very good fit

We already support C2D device-methods (Commands). Here is the documentation for how to use Commands - https://docs.microsoft.com/en-us/azure/iot-central/tutorial-define-device-type#use-commands.
We would love to help you with your scenarios, please don;t hesitate to reach out.

Thank you Sandeep, I am aware of commands and settings being a way to execute C2D.
But we need this programmatically done, i.e., send a C2D via Azure function or any backend application. Which is currently not possible for devices provisioned through IoT-central.
Thanks again.

Got it, just to confirm, would it work if you define a command or a setting in IoTCentral for a device and then potentially use an IoTCentral API to trigger this command/setting ?.
We have API/Programmatic access in our road map.

That's great! It would be a sufficiently good solution for what we would need, although with manual mapping of APIs of each device.
More elegantly, it would also help to have an API exposed at Device-set level too. With possibility of passing device-id as parameter.
Being optimistic here, how early could it be available?

Got it, let me get back to you on the timeline.
If you haven't already I suggest you post this on our user voice. That will help us bump up the priority :).

Thank you Sandeep!
I had it up on uservoice/feedback couple of days ago. Just bumped it up now with additional data.
https://feedback.azure.com/forums/911455-azure-iot-central/suggestions/36305668-allow-to-send-c2d-messages-from-function-and-ui

Looks like we got this issue is answered. Closing for now


[BugFix] fix mv with count distinct rewrite bug

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #16558
Problem Summary(Required) ：

fix mv with count distinct rewrite bug. the bug is that mv rewrite conflicts with TF_REWRITE_GROUP_BY_COUNT_DISTINCT rule which generates agg-agg-scan pattern plan.
mv rewriter does not support this pattern. fix it by adding new agg-agg-scan pattern rewrite rule.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

[FE PR Coverage Check]
:heart_eyes: pass : 16 / 17 (94.12%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/rule/AggregateAggregateScanRule.java
8
9
88.89%
[48]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/RuleSet.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/AggregatedMaterializedViewRewriter.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java
5
5
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test

@Mergifyio backport branch-2.5


Make login/registration using GitHub authentication more seamless

My steps:

I went to https://wikimedia.zulipchat.com for the first time as a new user who hadn't registered for that instance yet.
I clicked the "log in with GitHub" button.
I confirmed that I wanted to allow the GitHub auth.
The next page was https://zulipchat.com/find_my_team/ , which was confusing since I had come through the wikimedia team.
I was a little confused (#3128) but entered my own email address and got the "find my team" confirmation page.
I went back to https://wikimedia.zulipchat.com and clicked the "Log in with GitHub" button, and got directed to an error on https://wikimedia.zulipchat.com/accounts/login/?subdomain=1 : "Your Zulip account is not a member of the organization associated with this subdomain. Please contact<EMAIL_ADDRESS>with any questions!."
I realized I might need to register as its own step, instead of Zulip just auto-registering me via the GitHub login. I went to https://wikimedia.zulipchat.com/register/ and saw that there was a "Sign Up with Google" button but not a "Sign Up with GitHub" button.

So I have a few requests and figured I'd mention them here and we could decide which were worth splitting out into their own bugs:

Let users register & create accounts via GitHub auth, as we do with Google auth.
If the user tries to log in with GitHub but doesn't yet have an account, and it has open registration, tell them "hey it sounds like you want to register an account for this instance since you don't have one yet?" and lead them through registration.
Fix the extra punctuation in "any questions!."

Thanks for the great bug report!  We should probably turn GitHub auth off by default on zulipchat.com, since it's not fully baked.
@umairwaheed is working on fixing that.  @brockwhittaker FYI since some of this feedback in relevant to the login form work you're doing.
We should prioritize these issues.

@brainwane, working on the resolution here: https://github.com/zulip/zulip/pull/4503.

This was resolved through #4503.  Thanks for the report @brainwane!


Recommended Source Image?

Has anyone tested to see what the optimal resolution/format is for src image?
Is 256x256 png best to start with?

@shaekuronen  I'm using http://realfavicongenerator.net/ recommendation to use at least 260x260px, that's what I'm using


docs: point zipkin config at non-deprecated spawn_upstream_span

Commit Message: The property on Router is deprecated and points at spawn_upstream_span.  Use that instead.
Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes: Yes
Release Notes: N/A
Platform Specific Features: N/A

https://storage.googleapis.com/envoy-pr/4630c4c/docs/api-v3/config/trace/v3/zipkin.proto.html

I think the split_spans_for_request should also be deprecated and use the spawn_upstream_span  as the unique option to control the tracing.
But I still have no time to do that for now.

Thanks for you contribution to make it more clear. But I am now inclined to deprecate this zipkin field directly in favor of spawm_upstream_span in the zipkin.

Are you going to do that?

Nope. I am going to do that but haven't started it now. It would be very apprecated if you are interest it and want to take over it.

It’s not clear to me why you think my change in this PR, which exists and is mergable now, is mutually exclusive with your proposed change, which is not.
I agree that your proposed change makes sense and should be done. But I am not going to do it, because it will take more time and effort than I am willing to spend.
In light of this, please either merge this PR or close it.

Thanks and sorry for your time and effort that have paid.

It’s not clear to me why you think my change in this PR, which exists and is mergable now, is mutually exclusive with your proposed change, which is not.

Because in the design of these APIs, split_spans_for_request is designed to work with start_child_span in the router. And the spawn_upstream_span is designed to replace both of split_spans_for_reqest (or similar requirement in other tracers, like open telemetry) and start_child_span at same time.
I hope the comment of the API could clearly show the design intension. But the new patch may indicate that the split_spans_for_request will works together with the spawn_upstream_span but it isn't what we want finally.
Thanks again, and sorry again.

https://github.com/envoyproxy/envoy/pull/32672


update readme

@all-contributors add @slapointe for question, content

@all-contributors please add @rbrayb for question and content

@all-contributors please add @ZaidZaim for questions and content


[Request for global] Codeunit 5600 "FA Insert Ledger Entry" - InsertRegister

Hello,
We would need to have the function InsertRegister global, to be able to call it from other places that need this function.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Not accept lucene syntax

The elastic search allow use lucene syntax, where is base from elastic search. But this library not allow use lucene syntax. I got error.

This is an interesting point...the current default query generated here uses this syntax:
'query' => "*{$builder->query}*"
Dropping the *{ and *} in there seems to enable me to search using common Lucene syntax to search various fields/facets...I'm not an expert here...but wonder if perhaps that were altered in performSearch that it would at least allow one to create a proper Lucene query and submit it?

I had the same question, I deleted the * in the performSearch function, it work well

Create a new class App\Libraries\EsEngine
<?php

namespace App\Libraries;

use Laravel\Scout\Builder;
use ScoutEngines\Elasticsearch\ElasticsearchEngine;

class EsEngine extends ElasticsearchEngine
{
    public function search(Builder $builder)
    {
        $result =  $this->performSearch($builder, array_filter([
            'numericFilters' => $this->filters($builder),
            'size' => $builder->limit,
        ]));
        return $result;
    }

    /**
     * Perform the given search on the engine.
     *
     * @param  Builder  $builder
     * @param  array    $options
     *
     * @return mixed
     */
    protected function performSearch(Builder $builder, array $options = [])
    {
        $params = [
            'index' => $this->index,
            'type' => $builder->index ?: $builder->model->searchableAs(),
            'body' => [
                'query' => [
                    'bool' => [
                        // Just change here
                        'must' => [['query_string' => [ 'query' => "{$builder->query}"]]]
                    ]
                ]
            ]
        ];

        if ($sort = $this->sort($builder)) {
            $params['body']['sort'] = $sort;
        }

        if (isset($options['from'])) {
            $params['body']['from'] = $options['from'];
        }

        if (isset($options['size'])) {
            $params['body']['size'] = $options['size'];
        }

        if (isset($options['numericFilters']) && count($options['numericFilters'])) {
            $params['body']['query']['bool']['must'] = array_merge($params['body']['query']['bool']['must'],
                $options['numericFilters']);
        }

        if ($builder->callback) {
            return call_user_func(
                $builder->callback,
                $this->elastic,
                $builder->query,
                $params
            );
        }

        return $this->elastic->search($params);
    }

}

Then edit the AppServiceProvider
use App\Libraries\EsEngine;
use Laravel\Scout\EngineManager;
use Elasticsearch\ClientBuilder as ElasticBuilder;

    public function boot()
    {
        resolve(EngineManager::class)->extend('elasticsearch', function($app) {
            return new EsEngine(ElasticBuilder::create()
                ->setHosts(config('scout.elasticsearch.hosts'))
                ->build(),
                config('scout.elasticsearch.index')
            );
        });
    }

So you can rewrite the function instead of modifying it directly


[production] [ui] [comments] Enter key does not submit abuse report

Minor UI bug in the comment pane:
Steps

Click the Report Abuse icon on another user's comment
Enter some text in the description field
Press the Enter key.

Expected

The abuse report was submitted

Actual

The page refreshes

@nanchen47, why was this issue closed? It's still a problem on staging & production.

Yeah -- this is still pending w/ @huangginny 's fix -- I reopened -- TY

This is fixed on production now


slots: slot lenience must take into account block proposal portion

The slot lenience calculation was being done on the original slot duration without accounting for the block proposal portion. This PR fixes that and additionally adds a max_block_proposal_slot_portion so that the block proposal duration is never exceeded regardless of the slot lenience.
polkadot companion: https://github.com/paritytech/polkadot/pull/3294

bot merge


ESP_ERR_FLASH_BASE' undeclared  (IDFGH-2010)

Dear all,
I have a issue when i 'make flash' for ESP32:
Esp/esp-idf/components/spi_flash/include/esp_spi_flash.h:28:35: error: 'ESP_ERR_FLASH_BASE' undeclared (first use in this function); did you mean 'ESP_ERR_MESH_BASE'?  **#define ESP_ERR_FLASH_OP_FAIL    (ESP_ERR_FLASH_BASE + 1)**
I can compile the source with idf.py build or idf.py app flash but when i try to 'Make' , it pops up the error like above.
Do let me know if you need more info.

Thanks for reporting the issue. Would you please help provide more details as suggested in the issue template? Information like elf, sdk configuration, backtrace, log outputs, commit ID, hardware and etc. would help us debug further. Thanks.

Thanks for reporting, feel free to reopen with more details. Thanks.


HADOOP-18237. Upgraded Apache Xerces Java to 2.12.2

Description of PR
Upgraded Apache Xerces Java to 2.12.2 due to handle vulnerability CVE-2022-23437

JIRA: HADOOP-18237

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 40s

trunk passed

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 49s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 41s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
shadedclient
60m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 22s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 24s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
shadedclient
21m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 31s

hadoop-project in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

87m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4318/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4318

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml

uname
Linux 719bdf0eb143 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fbf919ef5e2c3a2261c367f9f0d97935bdf8f20f

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4318/1/testReport/

Max. process+thread count
549 (vs. ulimit of 5500)

modules
C: hadoop-project U: hadoop-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4318/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


GitHub runner updates

This includes several quality-of-life and deprecation runner updates and addresses #387.

MacOS runners are oversubscribed and 10x more expensive, and rarely break due to OS specific issues not caught by Linux tests. Therefore, MacOS tests are now only run on beta and master.
Bugfix/feature branches now only test the lowest and highest supported Python versions - this should be sufficient to flag any deprecation or missing language feature problems and cuts down the runtime on these branches by 2x. (Combined with no MacOS tests, this takes the number of runners needed from 12 to 4).
The runner versions were updated to -latest, bumping our testing environment to Ubuntu 22.04 from 20.04, Windows 2022 from 2019, and MacOS 12 from 11, and will now track updated environments.
The GitHub-provided actions were updated from v2 to v4 (or v3 in the case of cache) for node16 updates, which should remove the node12 deprecation warning we've been getting.

As an example, this cuts the current runtime from nearly 2 hours (with the MacOS oversubscription problem) to 13 minutes on this feature branch.

Question for you before I approve this. If I understand everything here correctly the new workflow structure is such that:

main-minimal gets run upon pushes to any branch.
main, which includes python 3.9 and 3.10 on linux and windows, gets run only upon pushes to develop and master (and external PRs).
main-mac which includes python 3.8 through 3.11 on macOS only gets run upon pushes to beta and master (and external PRs).

Is splitting off main and main-mac necessary? In principle beta should track develop in which case there is little difference and these workflows could be merged. In practice this is only true when test_extras passes, though, so I wasn't sure if this was the reason behind that difference.

Thanks for taking a look Corey - you understand the proposed workflow correctly.
The reason I split main and main-mac was to avoid the Mac runners stuffing up tests on develop, which I thought was the original intent of #387. Although rereading now, I think you may have just wanted main-minimal and main. The Mac tests rarely catch bugs that the linux tests do not, but we do have cases where develop fails and does not push to beta - in these cases, I thought having the more streamlined no Mac tests would be worthwhile. We do want to test the Mac environment eventually, thus we have main-mac which runs on beta and master just so we have the full complement of tests on those branches.
I don't feel too strongly about this. If you think it is cleaner to merge the workflows and don't mind waiting for the Mac tests when we push to develop, I will change that and remerge those.


Uncaught TypeError: Calendar is not a constructor

Version
latest version on master
Development Environment
Vivalid Browser, Ubuntu 18.04
Current Behavior
I am getting this error in the console Uncaught TypeError: Calendar is not a constructor and no calendar.
I am trying to use the calendar in my Django project, I downloaded tui-calendar.css and tui-calendar.js and included them in my page.
var Calendar = tui.Calendar;

var calendar = new Calendar('#calendar', {
});

Expected Behavior
No error should appear in the console

Solved by following instructions here

If using Jquery-
This solved the problem
$('#calendar').tuiCalendar({
defaultView: 'month',
taskView: true,
template: {
monthGridHeader: function(model) {
var date = new Date(model.date);
var template = '' + date.getDate() + '';
return template;
}
}
});

Problem is not solved, i also get this error. also with this instructions

Solved by following instructions here

import Calendar from 'tui-calendar'; /* ES6 */
import "tui-calendar/dist/tui-calendar.css";
const calendar = new Calendar('#calendar', {
defaultView: 'month',
});

Problem is not solved, i also get this error even with this instructions

Solved by following instructions here

import "tui-calendar/dist/tui-calendar.css";

const calendar = new Calendar('#calendar', {
  defaultView: 'month',
});```

me too, how to solve it?

same issue , any ideas?
tried all of the previous solutions ...


MIME types beyond pictures and PDF

I wonder how a non-pdf and non-picture file is to upload. The paperless ngx-API does it:
resp = httpx.post(host + "/api/documents/post_document/",
                  headers={"Authorization": "Token " + token, "Accept": "application/json; version=3"},
                  files={'document': (
                      'test.ods', open('./test.ods', 'rb'), 'application/vnd.oasis.opendocument.spreadsheet')},
                  data={"title": "My first upload", "created": "2023-12-21"},
                  verify='./cacert.pem')

With pypaperless I do the following:
        with open(file_path, "rb") as doc_file:
            data = doc_file.read()
        new_document = DocumentPost(
            document=data,
            title=title,
            created=doc_date,
            correspondent=None,
            document_type=None,
            tags=[],
            archive_serial_number=None
        )

I cannot see the chance to set the Mime type or the document original name. Can you help me?

PS: The task result in Paperless - when I upload bytes of an ods file is:
document: Error occurred while consuming document document: Error while converting document to PDF: Client error '400 Bad Request' for url 'http://gotenberg:3000/forms/libreoffice/convert'

I have to add that the above mentioned httpx-Post does work without a MIME type argument, too. Paperless checks the type with inspecting the content.
The Gotenberg error seems to happen often in the users installation. But for me the pdf conversion of ods, xlsx and so on works with httpx as well via paperless ui. I don't have any idea what the problem could be.

That will be refactored in v3 (which is a breaking change). v3 has the possibility to apply a filename to the uploaded document, I am currently implementing that.


--stopOnUpdateErrors behaves inconsitently

Based on the README I would expect that simply specifying --stopOnUpdateErrors would enable this feature and produce <stopOnUpdateErrors>true</stopOnUpdateErrors> in the app.xml manifest. Based on the behavior of other boolean options, I would expect that I need to specify either --stopOnUpdateErrors=true or --stopOnUpdateErrors=false to enable or disable it, respectively. However, the actual behavior is that specifying no value does not enable the feature and specifying any value, including false or an empty value, will enable the feature (e.g. --stopOnUpdateErrors=anything, --stopOnUpdateErrors=false, and --stopOnUpdateErrors= all produce <stopOnUpdateErrors>true/<stopOnUpdateErrors> in app.xml).
In addition, this option will be included in the parameters because it is not skipped here:
https://github.com/edvin/fxlauncher/blob/9537c329a5bd42191f69055b9dbe9805b210887b/src/main/java/fxlauncher/CreateManifest.java#L81-L90
And lastly, this option is named differently than all others, which are named-like-this.

I can submit a pull request for this, but I'd like to confirm that this is in fact behaving incorrectly and to verify what the desired behavior is before I start working on it.
My preference would be to make it consistent with the other boolean parameters, which means:

Rename to stop-on-update-errors.
Require a value of true or false.
Do not include in parameters.

However, I understand if something closer to the documented behavior is desired.

You're right, this should be made consistent. I think we should deprecate the old keyword and introduce the new. Also, it should not be included in parameters.
A PR would be most welcome. Sorry for not replying to this issue earlier, I've been insanely busy as of late :)

When you say "deprecate" do you mean that the old keyword should still exist alongside the new keyword or should it be removed?

Yes, it should exist, but emit a warning. Then we'll remove it completely in the coming release.

It should be fixed, it's clearly a bug if it doesn't have as documented IMO :)

Sure, that makes perfect sense. I just wasn't sure if you considered backwards compatibility to be an issue in this case. For example, it is possible that someone is relying on the current behavior, even if it is not behaving as documented.
I think that's all the questions I have for now. I'll begin working on this when I get a chance, but that probably won't be until some time next week.

I think if you're relying on behavior caused by a bug, that user has to fix his code, even if we caused him to do it this way. It's a bit unfortunate, but not unexpected.
Great, really looking forward to this fix :)


Playhistory View

Currently you can view the history via this button in the settings. Better ideas are welcome.

View:

Please make it as a service like the songsourcceprovider or shuffleprovider

Fair point. Will do


Fix logo link and remove broken image.

This is to fix #338.
@MohammedElsayyed the broken logo link can be seen via clicking the OpenWayback logo here: http://web.archive.bibalex.org/web/20050915000000*/http://google.com

@MohammedElsayyed since the image is not used in Toolbar, it makes sense to move it as you suggest. Moved in a7048ad2721890a52892515970a5eecdaa7ecdb7. Thanks!

Sorry for not being quite clear, but it is also used in Toolbar. I thought it would be better to place only images used by Toolbar into '/images/toolbar' and move other images used by more than .jsp file one level up.


Update cs.json: Add info about doubleclick subfolder selection

Thanks, could you please update it here as well?
https://github.com/skaut/shared-drive-mover/blob/master/src/frontend/locales/en.json

Updated.

Deployed.


Sample for fetchContent

fixes: #1387

From the issue:

Once the app is ready, use it from CI to test that the SDK can be consumed by end users by this approach without any issues.

Should we wait to close the issue until this part is done too? Are you planning to add the CI update to this PR as well?

From the issue:

Once the app is ready, use it from CI to test that the SDK can be consumed by end users by this approach without any issues.

Should we wait to close the issue until this part is done too? Are you planning to add the CI update to this PR as well?

Sharing results from trying this sample app with the latest Azure SDK releases:
Linux
Release Storage 12.0 beta.6.0
CMake Generate: Ok
Building: Ok
Running: Ok
Release Storage 12.0 beta.5.0
CMake Generate: Failed, then OK with Workaround
unknown Azure::azure-storage-blobs for linking. Need to use azure-storage-blobs
CMake Error at /home/vivazqu/workspace/vcpkg/scripts/buildsystems/vcpkg.cmake:418 (_add_executable):
  Target "application" links to target "Azure::azure-storage-blobs" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?

Building: Failed.
Fail during app build/link
Scanning dependencies of target application
[ 97%] Building CXX object CMakeFiles/application.dir/src/main.cpp.o
In file included from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/credentials.hpp:12:0,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/identity/azure-identity/inc/azure/identity/client_secret_credential.hpp:11,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/append_blob_client.hpp:6,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs.hpp:6,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/src/main.cpp:12:
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/http/policy.hpp:122:84: error: ‘CurlTransport’ is not a member of ‘Azure::Core::Http’
     std::shared_ptr<HttpTransport> Transport = std::make_shared<Azure::Core::Http::CurlTransport>();
                                                                                ^~~~~~~~~~~~~
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/http/policy.hpp:122:84: note: suggested alternative: ‘HttpTransport’
     std::shared_ptr<HttpTransport> Transport = std::make_shared<Azure::Core::Http::CurlTransport>();
                                                                                ^~~~~~~~~~~~~
                                                                                HttpTransport
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/http/policy.hpp:122:84: error: ‘CurlTransport’ is not a member of ‘Azure::Core::Http’
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/http/policy.hpp:122:84: note: suggested alternative: ‘HttpTransport’
     std::shared_ptr<HttpTransport> Transport = std::make_shared<Azure::Core::Http::CurlTransport>();
                                                                                ^~~~~~~~~~~~~
                                                                                HttpTransport
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/http/policy.hpp:122:99: error: no matching function for call to ‘make_shared<<expression error> >()’
     std::shared_ptr<HttpTransport> Transport = std::make_shared<Azure::Core::Http::CurlTransport>();
                                                                                ^
In file included from /usr/include/c++/7/memory:81:0,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/context.hpp:13,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/credentials.hpp:11,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/identity/azure-identity/inc/azure/identity/client_secret_credential.hpp:11,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/append_blob_client.hpp:6,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs.hpp:6,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/src/main.cpp:12:
/usr/include/c++/7/bits/shared_ptr.h:703:5: note: candidate: template<class _Tp, class ... _Args> std::shared_ptr<_Tp> std::make_shared(_Args&& ...)
     make_shared(_Args&&... __args)
     ^~~~~~~~~~~
/usr/include/c++/7/bits/shared_ptr.h:703:5: note:   template argument deduction/substitution failed:
In file included from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/credentials.hpp:12:0,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/identity/azure-identity/inc/azure/identity/client_secret_credential.hpp:11,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/append_blob_client.hpp:6,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs.hpp:6,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/src/main.cpp:12:
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/http/policy.hpp:122:99: error: template argument 1 is invalid
     std::shared_ptr<HttpTransport> Transport = std::make_shared<Azure::Core::Http::CurlTransport>();
                                                                                ^
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/src/main.cpp: In function ‘int main(int, char**)’:
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/src/main.cpp:31:21: error: ‘class Azure::Storage::Blobs::BlobContainerClient’ has no member named ‘CreateIfNotExists’
     containerClient.CreateIfNotExists();
                     ^~~~~~~~~~~~~~~~~
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/src/main.cpp:35:37: error: ‘class Azure::Storage::Blobs::BlobContainerClient’ has no member named ‘ListBlobsSinglePage’; did you mean ‘ListBlobsFlatSegment’?
     auto response = containerClient.ListBlobsSinglePage();
                                     ^~~~~~~~~~~~~~~~~~~
                                     ListBlobsFlatSegment
CMakeFiles/application.dir/build.make:62: recipe for target 'CMakeFiles/application.dir/src/main.cpp.o' failed
make[2]: *** [CMakeFiles/application.dir/src/main.cpp.o] Error 1
CMakeFiles/Makefile2:80: recipe for target 'CMakeFiles/application.dir/all' failed
make[1]: *** [CMakeFiles/application.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

Running: Not possible
Release Storage 1.0 beta.4.0
CMake Generate: Ok (Need to use version 1.0 instead of 12, expected)
Building: Failed
The Application contains expected breaking changes:

#include "azure/storage/blobs/blob.hpp"
containerClient.CreateIfNotExists();
ListBlobsSinglePage()

It can build and run after fixing the breaking changes.
Running: Ok after fixing breaking changes

Sharing results from trying this sample app with the latest Azure SDK releases:
Linux
Release Storage 12.0 beta.6.0
CMake Generate: Ok
Building: Ok
Running: Ok
Release Storage 12.0 beta.5.0
CMake Generate: Failed, then OK with Workaround
unknown Azure::azure-storage-blobs for linking. Need to use azure-storage-blobs
CMake Error at /home/vivazqu/workspace/vcpkg/scripts/buildsystems/vcpkg.cmake:418 (_add_executable):
  Target "application" links to target "Azure::azure-storage-blobs" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?

Building: Failed.
Fail during app build/link
Scanning dependencies of target application
[ 97%] Building CXX object CMakeFiles/application.dir/src/main.cpp.o
In file included from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/credentials.hpp:12:0,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/identity/azure-identity/inc/azure/identity/client_secret_credential.hpp:11,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/append_blob_client.hpp:6,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs.hpp:6,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/src/main.cpp:12:
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/http/policy.hpp:122:84: error: ‘CurlTransport’ is not a member of ‘Azure::Core::Http’
     std::shared_ptr<HttpTransport> Transport = std::make_shared<Azure::Core::Http::CurlTransport>();
                                                                                ^~~~~~~~~~~~~
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/http/policy.hpp:122:84: note: suggested alternative: ‘HttpTransport’
     std::shared_ptr<HttpTransport> Transport = std::make_shared<Azure::Core::Http::CurlTransport>();
                                                                                ^~~~~~~~~~~~~
                                                                                HttpTransport
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/http/policy.hpp:122:84: error: ‘CurlTransport’ is not a member of ‘Azure::Core::Http’
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/http/policy.hpp:122:84: note: suggested alternative: ‘HttpTransport’
     std::shared_ptr<HttpTransport> Transport = std::make_shared<Azure::Core::Http::CurlTransport>();
                                                                                ^~~~~~~~~~~~~
                                                                                HttpTransport
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/http/policy.hpp:122:99: error: no matching function for call to ‘make_shared<<expression error> >()’
     std::shared_ptr<HttpTransport> Transport = std::make_shared<Azure::Core::Http::CurlTransport>();
                                                                                ^
In file included from /usr/include/c++/7/memory:81:0,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/context.hpp:13,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/credentials.hpp:11,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/identity/azure-identity/inc/azure/identity/client_secret_credential.hpp:11,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/append_blob_client.hpp:6,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs.hpp:6,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/src/main.cpp:12:
/usr/include/c++/7/bits/shared_ptr.h:703:5: note: candidate: template<class _Tp, class ... _Args> std::shared_ptr<_Tp> std::make_shared(_Args&& ...)
     make_shared(_Args&&... __args)
     ^~~~~~~~~~~
/usr/include/c++/7/bits/shared_ptr.h:703:5: note:   template argument deduction/substitution failed:
In file included from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/credentials.hpp:12:0,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/identity/azure-identity/inc/azure/identity/client_secret_credential.hpp:11,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/append_blob_client.hpp:6,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs.hpp:6,
                 from /home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/src/main.cpp:12:
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/build/_deps/azuresdkforcpp-src/sdk/core/azure-core/inc/azure/core/http/policy.hpp:122:99: error: template argument 1 is invalid
     std::shared_ptr<HttpTransport> Transport = std::make_shared<Azure::Core::Http::CurlTransport>();
                                                                                ^
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/src/main.cpp: In function ‘int main(int, char**)’:
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/src/main.cpp:31:21: error: ‘class Azure::Storage::Blobs::BlobContainerClient’ has no member named ‘CreateIfNotExists’
     containerClient.CreateIfNotExists();
                     ^~~~~~~~~~~~~~~~~
/home/vivazqu/workspace/azure-sdk-for-cpp/samples/Integration/CMake-fetch-content-app/src/main.cpp:35:37: error: ‘class Azure::Storage::Blobs::BlobContainerClient’ has no member named ‘ListBlobsSinglePage’; did you mean ‘ListBlobsFlatSegment’?
     auto response = containerClient.ListBlobsSinglePage();
                                     ^~~~~~~~~~~~~~~~~~~
                                     ListBlobsFlatSegment
CMakeFiles/application.dir/build.make:62: recipe for target 'CMakeFiles/application.dir/src/main.cpp.o' failed
make[2]: *** [CMakeFiles/application.dir/src/main.cpp.o] Error 1
CMakeFiles/Makefile2:80: recipe for target 'CMakeFiles/application.dir/all' failed
make[1]: *** [CMakeFiles/application.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

Running: Not possible
Release Storage 1.0 beta.4.0
CMake Generate: Ok (Need to use version 1.0 instead of 12, expected)
Building: Failed
The Application contains expected breaking changes:

#include "azure/storage/blobs/blob.hpp"
containerClient.CreateIfNotExists();
ListBlobsSinglePage()

It can build and run after fixing the breaking changes.
Running: Ok after fixing breaking changes

/check-enforcer  override

/check-enforcer  override

From the issue:

Once the app is ready, use it from CI to test that the SDK can be consumed by end users by this approach without any issues.

Should we wait to close the issue until this part is done too? Are you planning to add the CI update to this PR as well?

Talked to @danieljurek .  For this type of tests we need to define how devOps would handle it.  For now, I will merge this and follow up with engSys for the CI/Pipelines integration

From the issue:

Once the app is ready, use it from CI to test that the SDK can be consumed by end users by this approach without any issues.

Should we wait to close the issue until this part is done too? Are you planning to add the CI update to this PR as well?

Talked to @danieljurek .  For this type of tests we need to define how devOps would handle it.  For now, I will merge this and follow up with engSys for the CI/Pipelines integration

/check-enforcer override

/check-enforcer override


feat: add wsl open cmd command

wslview is a fake web browser that allows opening urls in your default browser in windows.

Thank you


Application::share() not found in OctoberCMS L5.5 (edge = true)

When updating to the latest edge build the debug bar throws an exception.
Call to undefined method October\Rain\Foundation\Application::share()
C:\xampp\htdocs\www\plugins\bedard\debugbar\vendor\barryvdh\laravel-debugbar\src\ServiceProvider.php line 42
This is the affected line.
$this->app['command.debugbar.clear'] = $this->app->share(
function ($app) {
return new Console\ClearCommand($app['debugbar']);
}
);

Thanks for the heads up, I've just upgraded to be compatible with 5.5!
https://github.com/scottbedard/oc-debugbar-plugin/commit/4fb0b661c2fe59a03c17712dd02b5bb1cb0f481a


regression in server mode 0.9.13a0 compared to 0.9.12

By trying to solve #101 I noticed a bug with the taxi example in 13_Deploying_Bokeh_Apps.ipynb in server mode.
The app is launched with bokeh serve --show 13_Deploying_Bokeh_Apps.ipynb
With PyViz 0.9.12, it is working just fine and you can choose pickup then dropoff again and everything updates.
With PyViz 0.9.13a0 you can choose pickup and it updates. But it does not update anymore if you choose dropoff again.
Here is a small part of the error message ; panel and/or param are involved.
  File "/anaconda3/envs/pyviz0913/lib/python3.6/site-packages/param/parameterized.py", line 1055, in _call_watcher
    watcher.fn(self_._update_event_type(watcher, event, self_.self_or_cls.param._TRIGGER))
  File "/anaconda3/envs/pyviz0913/lib/python3.6/site-packages/panel/param.py", line 386, in update_pane
    index = parent.children.index(old_model)
ValueError: Figure(id='8ae97421-026b-47d9-ba14-337452b14043', ...) is not in list

The problem does not occur within the notebook.

Should be fixed by the panel PR referenced above, we'll release a new pyviz release shortly.

Thanks @philippjfr , it is indeed fixed by PyViz 0.9.13a2 that uses panel 0.1.2.
I close the issue.


Heavy synchronization activity

Hi there,
I've been trying different approaches to speed up my nasty N^2 algorithm in the core of my engine/server. Without any threading: ~44ms, with OpenMP: ~14.5ms, IntelTBB: ~8ms, FiberTaskingLib: ~14ms.
I did a bit of profiling of this with VTune, and found that a significant portion of time was spent in  synchronization.

What are your thoughts on this?

Sorry, I was using a version of the repo from before you made some of the recent changes to the queueing/job stealing.
These are the new results for the same code and time/test conditions (mostly):

Currently hitting around 12-12.5ms, but am getting some weird hitching occasionally. Not sure if it's just the 8 threads hammering the CPU so hard the OS is having trouble printing the console seamlessly (I doubt that, because OpenMP thrashed it as well and the console had no problems). I'll keep an eye on it.

Oops, realized I had the work only divided down to something dumb like 1 task per thread, which explains the above results in terms of spending time stealing work. Here's 500 tasks instead of 8 ;)

Memory:

This is really really cool info! Thanks for sharing.
I'd be really interested to see a capture with something like microprofile:
https://github.com/jonasmr/microprofile
(Note: If you use WaitForCounter(), you will need to break the profile scope into "before wait" and "after wait", since Microprofile won't be able to handle a fiber being migrated between threads).
void MyFunction(....) {
    MICROPROFILE_ENTERI("root", "MyFunctionBeforeWait", MP_YELLOW);
    // Do stuffz
    // ....
    MICROPROFILE_LEAVE();

    taskScheduler->WaitForCounter(counter);

    MICROPROFILE_ENTERI("root", "MyFunctionAfterWait", MP_YELLOW);
    // Do more stuffz
    // ...
    MICROPROFILE_LEAVE();
}

I'm wondering if the tasks are completing faster than you can feed the scheduler new ones. Though, from your last two screenshots, it looks like all your work is scheduled in the beginning. In this case, the worker threads will have nothing in their queues, and they will have to Steal() everything. Hence, why Steal() is so hot. Could you share a pseudo code of how you are scheduling your tasks? For example is it something like:
// Create 500 tasks
// ....

auto counter = taskScheduler->AddTasks(...);

taskScheuler->WaitForCounter(counter);

// Repeat

This would help me in understanding the task flow.
One solution I can think of, would to be track the last successfully stolen queue per thread. So, when a thread tries to Steal() a task, it starts from the last queue it successfully stole from. Currently, it always starts at 1, and loops around. This would remove unnecessary Steal() calls, in the case of heavy imbalance in the queues between threads.
As for using TBB concurrent containers, I have contemplated it. That said, I would have to heavily investigate their implementation, to make sure that it would be compatible with fibers. Currently, only the VC++ compiler has fiber-safe TLS optimizations; GCC and Clang do not. So if TBB containers use TLS, they can't be used in the library.

I'll have a go at getting that profiler working soon - I've not used something like that before (with the manually-specified timing points), but I'm not sure of its use in this case - my flow is extremely simplistic. It's this simplicity that made me want to try fibers, actually, since I don't yet need the incredible flexibility of IntelTBB's graph system (but didn't want to cook something up, myself - looking into this stuff is already self-indulgent enough right now, heh).
Your pseudocode is correct - I have an algorithm that is, at present, iterating over 1000 objects, with each of those loops then iterating n-1 objects (each other minus themselves), then while-looping over a collection of related data for between 0 and 3 iterations, starting from a point in said data that the CPU can't predict. It's pretty gnarly, but I create the tasks for the outer loop up-front since the work is 100% independent. I feel like fibers should destroy TBB eventually on something like this ;) One problem is that the work isn't completely balanced - there are calculations within the innermost loop that determine how much work there is to do, but overall I don't think it's too bad.
I've tried that commit of yours, and in my ~4am brain, I can't see much difference, but I'll have to dig into the profiler and compare some better numbers to give you more than just a hunch, but definitely no dramatic changes as far as I can see.
Anyway, I'm looking forward to seeing this library grow. Talk soon.

Yea, if your code flow is that simple, then Microprofile won't show much. It is kind of nice to visualize it though. Maybe I'm just a visual person. lol
Thanks for trying out the new commit. To be honest, I haven't done very much profiling myself of the library code. Having some "real world" examples like this is very helpful. I'm going to bust out VerySleepy and VTune and see how they look on some of my test examples.

So, if we can assume a strong memory model CPU, we can change the memory fence in Steal() to a compiler barrier, ie. change std::atomic_thread_fence() to std::atomic_signal_fence(). Testing on x86_64, this makes Steal much much faster.
Memory Barrier:
http://i.imgur.com/xJ5pkWm.png
Compiler Barrier:
http://i.imgur.com/l60GoX0.png
However, atm, I don't know of a good cross-platform way to do this.

That commit should lessen the memory synchronization time a little bit. That said, memory synchronization is still a large part of the overhead of the library. More work can be done on optimizations.
This is a project that launches 65000 empty tasks and then waits for them to complete:

Steal and Pop both suffer heavily from the fence and the atomic load

That said, I currently don't know how I could optimize that any further.
One potential area of optimization is the waitingFibers checking:

It's also suffering from memory synchronization. I'm probably thrashing the cache. Perhaps we can put in a fast-out path, so we don't have to loop through the whole list of potential waiting fibers, and test their atomics.
Or another option would be to replace the current wait queue with something like the task queue.

@RichieSams I'll have a crack at testing these latest changes when I get the chance - I'm in the middle of some heavy refactoring and don't want to over-complicate, but I do want to give you some better feedback. I think I might try to provide you with a slimmed-down version of what I'm doing (or, hell, just link you a branch of the repo at some point) so you can see what's going on, if you'd like.
I forgot to mention on one of the other issues; did you want to connect on another medium to talk about the library further? No worries if not, but it'd be good to have that potential contact if I end up using it in my project for reals.

Awesome! No worries about not testing the new changes yet. I did a RFC on reddit, and as a result of their feedback, I may change the API a bit.
I would love to see your use of the code. Like I said above, all my current tests are semi-contrived, so it would be great to put the library through its paces.
You can email me at: ad as tl ey {a t} gm ail  com
Alternatively, if you use Discord, I have a small coding server, where we can message / talk: https://discord.gg/ZWAHSwH

I dug up those posts of yours, but didn't see much in the way of drastic feedback/changes. Did I miss something?
It's very simple at the moment - not far off of what I mentioned previously. I'm currently very framework-y and early-on, so there's not much like the complexity of parallel gameplay code or anything just yet.
I am aboard the Discord :) Thanks for the invite.

Nothing too big. I'm probably going to remove the FTL_TASK_ENTRY_FUNCTION macro, so it will be up to the user to make the right function signature. (The compiler error should make it pretty obvious)
Next, I'm going to be looking into if I can get rid of the "mainTask". AKA, you can call TaskScheduler functions directly from the main thread. The reason I had gone the "mainTask" route, was that it makes it much much easier to detect when everything is done and clean up the resources afterwards. In addition, the old implementation of the fiber switching didn't like it if threads ended on different stacks than what they started on. I believe the new fiber asm file implementations fixes this. But I need to do some tests.
Those are the only changes.


Make apertures data visible as string not tuple

Fixes #ISSUE
Instructions to reviewer on how to test:
??
Checks for reviewer

[ ] Would the PR title make sense to a scientist on a set of release notes
[ ] If a new device has been added does it follow the standards

working through the failing tests.setters at lines 112 and 133 are troublesome


[FEAT] Flexible number of rounds per game

https://discord.com/channels/758443244387303435/792739542058532865/816424488471494676

I see issues with his request.
With more rounds, games will not have the same maximum score (5000). History sorting will become complex.

I see issues with his request.
With more rounds, games will not have the same maximum score (5000). History sorting will become complex.

Sad story... For me it would be more interesting to have flexible number of rounds, than to have a history with max score... :/

If you think, it should be appreciated by players. You can implement it.
It's not complicated.
You have nbRound variable in StreetView.vue
https://github.com/GeoGuess/Geoguess/blob/dc36c681e42eec76e5ee880546a2fea6b8603f79/src/pages/StreetView.vue#L186
For the game settings (menu,...), you can follow work made it #118

I'm not very good at programming, but i found this website


HADOOP-18493: upgrade jackson-databind to <IP_ADDRESS> (3.3 branch)

Description of PR
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.3.5 Compile Tests _

+0 :ok:
mvndep
15m 53s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m 18s

branch-3.3.5 passed

+1 :green_heart:
compile
18m 14s

branch-3.3.5 passed

+1 :green_heart:
mvnsite
20m 56s

branch-3.3.5 passed

+1 :green_heart:
javadoc
7m 38s

branch-3.3.5 passed

+1 :green_heart:
shadedclient
31m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
22m 16s

the patch passed

+1 :green_heart:
compile
17m 42s

the patch passed

+1 :green_heart:
javac
17m 42s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
20m 15s

the patch passed

+1 :green_heart:
shellcheck
0m  1s

No new issues.

+1 :green_heart:
javadoc
7m  2s

the patch passed

+1 :green_heart:
shadedclient
31m 55s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
694m  7s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
2m 25s

The patch does not generate ASF License warnings.

903m 12s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestFileCreation

hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5018/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5018

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux a8c7d6746ae5 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3.5 / af49c300c920b2a29fefbe2d5fc8d2b0d19226fa

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5018/2/testReport/

Max. process+thread count
3372 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5018/2/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Are additional 'step' nodes, especially neolithic, a welcome addition?

At the moment, there's only a couple steps added in the neolithic area. Do you want to keep this mod very 'slim', and basically only restrict what's already restricted, or would you accept PRs that add 'weight'?
In particular, while addressing #2, there's:

A lot of Vanilla Furniture Expanded - Art content, and simply branching it all off of 'Crafting facilities' feels a little silly. I'm tempted to add an additional stepping-stone of 'Artistry', lock the vanilla Art Bench behind that, and then use that stone to also lock all the modded artistic/neolithic/medieval content. Similarly, maybe an 'Protective clothing' node, move some of the vanilla neolithic armor into it, then lock some of the Factions Expanded: Classical content behind that.

In a slightly different vein, some of the mods avoid adding any tech at all - for instance, all the absurd variety of Vanilla Cooking Expanded foods are available in the neolithic era (I'm sorry? Gourmet chocolate desserts? When you can't even build a campfire? Uhhhhhh,). I'm planning to add separate 'Luxurious food' (locking fine/lavish meals) node, which is fine because there's some vanilla content to lock behind that ... but I'm also tempted to add a 'Desserts' technology, which would have no content if I added it to Stepping Stones instead of to my patch-mod. I could add it to my patch-mod, but then others patching Stepping Stones might not use the same tech ... not sure which approach is best.

Would you accept such changes in a PR? Is that within scope for your vision of this mod?

Further node additions:

'Fire' or similar, for torches, campfires, and prereq for prepared food, smithing

Also, I'd like to lock additional vanilla things behind techs that already exist:

Some ideology structures behind, well, 'Structures'
Ditto for vanilla's wooden bridges (I can then add VFE: Architect's bridges behind the same thing)
pen markers, egg boxes, plant pots go in, idk, 'Agriculture'?
spike traps and sandbags probably belong in 'Structure' although i'm a little less sure of that one

Oh, I meant to reply to this.
I'd rather keep things lean. There are other mods that aim for adding an entire neolithic research tree - the ones I added mostly exist for the purposes of the main mod generating ancestor research opportunities. As a rule, Id like to only add research projects if code can be written to automatically assign relevant defs to it (though Ive personally broken that rule a bit already, so a compelling argument otherwise would convince me).
Similarly, Id like to avoid potentially empty nodes. The main mod deals poorly with them, anyway. Possibly I could come up with some checker that would autoremove them when empty? The issue with that would be that unless I hardcode it (which I try to avoid), it would also end up removing modded empty techs that might be empty intentionally as unlock triggers for mod functionality. Its something to consider.


Single File Components & Partials

Is there any way to define partials in a single file component(loading with rvc/requre) such that they're available to any other components that component uses?  If so, how do I look these partials up?
I've made svapreddy/ractive-widgets-virtual-scroll compatible with ractive 0.8.1(commit fd141daa) and it takes a formatter partial to lay out each block of scroll.  I'd like to define the formatter partial within the component that uses the ractive-widgets-vscroll component but the vscroll component can't find it.  The way it currently looks up partials is with:
partials: {
  formatter: function(parser) {
   return parser.fromId(this.get('formatter'));
  }
}

but it never finds any partial.  I'm currently working around this with a really ugly hack where I just reference my app's ractive instance as a global and pulling it straight out of ractive.partials within the vscroll component but I'd like to fix this if possible because even with this method, I can't define partials within components that other components used in that component can see, I have to define them in my app's main template.
p.s. I'm sorry for posting a question in Issues but it seems acceptable here and the Google group doesn't appear to get any traction anymore.

I think the easiest thing to do would be to use a content partial on the component. If you need more dynamism, you can also use a partial expression with a template object.
A content partial would be used as:
<vScroll list="{{items}}" blockCount="100">

... current item will be {{.}} ...

</vScroll>

{{>content list[i]}}

Any content in the component's body is bundled up into a partial named content. You can specify additional templates with {{#partial someName}}...{{/partial}} in the component's body too.
With edge, you can event {{yield content with . as item}} and use {{item}} in the content partial rather that . so that events and other refs resolve in the parent instance context.
With a partial expression with template object, you could use:
<vScroll list="{{items}}" ... formatter="'
 ... {{.}} ...
'" />

{{>{ template: formatter } list[i]}}


Using vulnerable version of axios

Version 0.19.2 of axios is vulnerable to both of the attached high-severity CVEs. It's also preventing me from updating follow-redirects, which also contain vulnerabilities we'd like to mitigate. Could we prioritize updating the axios version to >= 0.21.1?

Thanks!


CLI broken on unix machine

https://github.com/npm/npm/issues/2097

Thanks for reporting.
I have changed line endings of cli/index.js to LF. Please let me know if v1.5.2 is working for you.

Cool.
It works.


Replace "PERSON" to "PER" in the dimensions

Proposed changes:

Change "PERSON" to "PER" in the dimensions parameter of the SpacyEntityExtractor component. This is how the component is identifying this entity in Rasa.

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for submitting a pull request 🚀 @akelad will take a look at it as soon as possible ✨

Hey @brunohjs, are you sure about this? As far as I'm aware the spacy entity is PERSON and not PER?

Hey @brunohjs, are you sure about this? As far as I'm aware the spacy entity is PERSON and not PER?

Yes, I'm sure. I know Spacy considers "PERSON", but Rasa appears as "PER". Look at this print:

Now it's clear. When using the en_core_web_md model, the entity is PERSON. When using the pt_core_news_lg model (my case), the entity is PER.

So, there is no need to change the documentation. Maybe add a note for this case.

oh, that's strange on spacy's part! i think given that the example in the docs is just an example, there's no need to add a note. By default rasa will extract all spacy entities anyways. but let me know if you think there's a better place to make a note of this

I found in the spaCy documentation the reason for this problem. I found out that the Portuguese models are based on Wikipedia corpus and, because of that, have different entity tags.

English models are based on OneNote 5 corpus.

Link: https://spacy.io/api/annotation#ner-wikipedia-scheme
Maybe create a forum thread to make a note of that?


Add option to enable/disable double quotes as literals

This could be a solution for https://github.com/simolus3/sqlite3.dart/issues/171
It exposes the sqlite_db_config function that we can use to configure the double quotes for a particular database connection.
I added a test for the setting but docs are missing.
Let me know if the implementation and code organization seems ok to you and I'll complete it with documentation if you want to go forward with this solution.

Great, thanks Simon!
One question from the changes. Wasn't setting 3 or 0 based on the boolean correct?
I based it on the table from https://www.sqlite.org/compile.html#dqs

The 2-bit value from the compile-time option is used to control the value for both the DDL and the DQL. In the config interface, we have two different keys which take boolean values.
It works with 3 as well since sqlite3 takes any non-zero value as true, but I think using 0/1 captures the type better.

The 2-bit value from the compile-time option is used to control the value for both the DDL and the DQL. In the config interface, we have two different keys which take boolean values. It works with 3 as well since sqlite3 takes any non-zero value as true, but I think using 0/1 captures the type better.

Oh yes, you are right. Here we are setting them individually, so that's not needed.


Prevention against replay attacks

Hello,
So this is the workflow I have at this moment for using JWT:

User logs in, sends usr/pwd.
Node validates it against an old .NET DB, if the usr/pwd matches, I issue a JWT with 5min expiration and send it back to client.
I store the token using mozilla's localforage.
Everytime I do a new request, I invalidate the current token (adding it to a blacklist), and add issue a new token in response.

So far so good, everything works like a charm, but I have a reaaaaally big concern... what happens if someone grabs that token that I have saved on localstorage? and then creates the same request trhu, let's say, POSTMAN? That's going to:

Invalidate my token and kick me out of the session where I'm using the current token (already blacklisted because it was used by the evil genious with POSTMAN)
Return new tokens to evil genious.

So how possible is that someone is able to hack my localstorage/indexedDB/WebSQL?
Are my steps wrong?
What's the right way to implement a "nonce"? (I think I don't need this since I'm doing like a heartbeat, everytime I do a request with my token, I return a new one and the previous one gets blacklisted)
Thanks in advance

Super old thread, but in case someone else hops along here, SameOrigin HTTP-Only cookies over HSTS / HTTPS are useful when working with an API on the same domain


Remove redundant nullable operator

Removed redundant nullable operator for reference type. String is a reference type and always nullable,
Summary
Removed redundant nullable operator for reference type. String is a reference type and always nullable,
Fixes #27021

Fixes issur: Remove nullable operator for string #27021 (https://github.com/dotnet/docs/issues/27021)

Hi @ArtyProf, I'm not so sure that this change is accurate. The way you define your variables provide hints to the compiler as to your intent and expectation. For example, within a nullable context:

string: is a way of me telling the compiler, I expect this to be non-null.
string?: is a way of me telling the compiler, I expect this to be maybe null.

This will change the behavior of how C# reasons about your code. Tagging @BillWagner here - is my understanding of this correct?

I can see where there's confusion from the existing sample. I suggested a different update to the code sample. What do you think of this instead @ArtyProf ?

@BillWagner Agree with you

closing and reopening for a fresh build.

@BillWagner, @IEvangelist
Seems I do not have write access permissions.


Session-lost error not triggered in processWayf

EB has a dedicated error for "Session lost" (/authentication/feedback/session-lost) which describes that the session has been lost and list possible causes, such as disabled cookies.
This error page is not triggered when the corresponding exception happens in process-wayf. This is however a very likely place for it to occur. If you completely block cookies (for EB or at all), this is the first point where this exception happens.
Steps to reproduce:

Disable cookies in browser
Go to any SP; be redirected to WAYF.
Select an IdP in WAYF.
EB says: "Error - An error occurred". Logs reveal that EngineBlock_Corto_Module_Services_SessionLostException was thrown with message "Session lost after WAYF", but this was not caught.

I'm having trouble reproducing this with the steps given. I get the correct error page.
This has been possibly fixed by an earlier PR.

I cannot reproduce this anymore in EB 5.0. We were running 4.7 at the time this issue was reported. Likely it has been fixed in 5.0.


Segfault when using iree-eliminate-empty-tensors pass on a IR with linalg ops

Here is an example gist https://gist.github.com/nirvedhmeshram/f37ac36a855e56e7836585982638a6a7
To reproduce copy the IR in the gist to a file and do
iree-opt --pass-pipeline="builtin.module(func.func(iree-eliminate-empty-tensors))" single_test.mlir

cc @MaheshRavishankar

Resolved by https://github.com/openxla/iree/pull/17095