Make data.h header-only

The computations in data.h are used in a lot of places very often. These functions are extremely small, and so the function call itself cost just as much (if not more) than the actual computations. So, we want to force them to be inlined. To do this, we need is to move the implementation in data.cpp into data.h and have every function be preceded by the inline keyword.

[ ] All const values should be moved over as a constexpr
[ ] For each function declaration (a) precede it with an inline and (b) the replace the ; with the { ... } part of its implementation.

Skal jeg flytte alting fra data.cpp over i data.h eller kun de ting der i forvejen findes i data.h?
Altså, skal jeg kunne slette data.cpp når jeg er færdig?

Ideally everything is moved and data.cpp is deleted. I'm not sure whether the lambda functions for the bool_op can be moved, so they may possibly have to stay as is.

Correction: Yes one can make lambdas into a constexpr.
https://docs.microsoft.com/en-us/cpp/cpp/lambda-expressions-constexpr


[Request]  Add Tutanota mail desktop client

Package Request
Criteria
For a package to be acceptable in the Extras bucket, it should be:

[x] a well-known and widely used tool (e.g. if it's a GitHub project, it should have at least 100 stars and 50 forks)
[x] the latest stable version of the program

Information
Name: Tutanota Client
Description: Desktop client for Tutanota mail service
Homepage: https://tutanota.com/
Download link(s): https://tutanota.com/#download
Some indication of popularity/repute: Cannot say for the built application, but source code repository has over 482 forks and 4.9k stars
Official source code repo: https://github.com/tutao/tutanota

@Zliced13  Thank you, also should i close the issues that are completed or not?

@anderlli0053 don't close it, keep it open until the PR is merged into ScoopInstaller:master

@anderlli0053 don't close it, keep it open until the PR is merged into ScoopInstaller:master

OK


[Bug]: CLI returns code 0 when in fact there was an error

What happened?
When any command given to the DAB CLI results in an error, the error is output however the returned code is a code 0, indicating success. It would be more helpful if this was more indicative of an issue in the command, as it makes it far more difficult to automate anything if we can't easily tell the success or failure of a command.
For an example, try running a dab add command, whilst specifying --config and pointing it to a non existent file.
Version
0.9.7+e560142426d1c080b9fd7b7fabff51a276f6bf61
What database are you using?
Azure SQL
What hosting model are you using?
Local (including CLI), Static Web Apps (SWA)
Which API approach are you accessing DAB through?
GraphQL
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for reporting. Tracked via #1777 and fix is being reviewed in PR #2084

Closing as fixed.


Fixed #34645 -- Restored alignment for admin date/time timezone warnings.

Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.
ticket-34645
Before:

After:

@sarahboyce Thanks for checking :+1:

I think you stumbled across another accessibility improvement/bug. Looks like the "Today" and "Now" in the datetime widget is too small, and should be enlarged (along with the icons) to be the same as above with the date/time widgets (maybe)

Yes I saw this. It's a separate bug, not a regression, so I didn't want to change it here.


Hue Light entity_namespace not working

Home Assistant release (hass --version):
0.60
Python release (python3 --version):
hass.io
Component/platform:
light.hue
Description of problem:
Since 0.60 the entity_namespace attribute is not working for hue lights anymore.
Lights show up in HA like this:
light.livingroom
Expected:
light.hue_livingroom
Problem-relevant configuration.yaml entries and steps to reproduce:
##### Bridge Configuration
hue:
  bridges:
    - host: !secret hue_bridge_ip
      filename: phue.conf

##### Light
light:
  - platform: hue
    entity_namespace: hue

Additional:
Other components like cast working fine. Entity namespace shows up.

The light entry is redundant.
I don't use entity_namespace but would it not be something like:
hue:
  entity_namespace: hue
  bridges:
    - host: !secret hue_bridge_ip
      filename: phue.conf

Why is light entry redundant?
media_player:
  - platform: cast
    entity_namespace: cast

works like a charm....expected the same for hue like it was before 0.60.
Your suggestion don't work either. It crashes the config.
2017-12-23 10:37:07 ERROR (MainThread) [homeassistant.config] Invalid config for [hue]: [entity_namespace] is an invalid option for [hue]. Check: hue->hue->entity_namespace. (See ?, line ?). Please check the docs at https://home-assistant.io/components/hue/

Because hue is its own component now, not a subset of the light component.
Maybe :
hue:
  bridges:
    - host: !secret hue_bridge_ip
      filename: phue.conf
      entity_namespace: hue

?

It had nothing to do with the new "hue" component. Light component supports entity_namespace. It works with other light platforms (e.g. flux_led). But it won't work with hue since 0.60 update!

Yes, the light component supports entity_namespace, but hue lights are no longer a part of the light component, they are part of the new hue component.
Did you try my second suggestion? If that doesn't work then I don't have any further suggestions and it probably is a bug.

Don't know what you mean...
Look at the docs, hue lights still part of the light component.

This is a platform for the Lights component.

https://home-assistant.io/components/light.hue/
Simply the BRIDGE configuration is split out of the light component to support sensors in the future. So there are TWO compontents! LIGHT for the LIGHTS and HUE for the BRIDGE CONFIG.
This is even mentioned at the change log

Refactor hue to split bridge support from light platform
https://home-assistant.io/blog/2017/12/17/release-60/#

I do use hue lights, mine are working perfectly in the way I have attempted to describe to you 3 times. Good  luck sorting your issue 👍

Mine working fine, too. But the entity_namespace attribute is not working anymore. Therefore I opened this issue. Thanks for your response but your suggestions are not working.
Merry X-Mas...

^ Ha, stop apologising, breaking changes can be confusing 😉
Yeah, if it doesn't work like either of those examples then I don't know, as I say I haven't used entity_namespace myself.
@andreacampi - is this something you can look at whilst you're looking at the multiple bridge problem?

Howdy, I'm having a similar problem- I had the scan_interval set for my hue lights which is another option similar to the entity_namespace attribute. I've tried the same configuration trials that @sti0 has tried with entity_namespace and no dice. It either crashes the configuration (when validating) or is ignored (when put under light: platform: hue
If this is something that could please be added into the refactored hue component that would be amazing. Thanks!

Yeah sorry, I had a couple more severe bugs to work through first. With those out of the way (well, mostly--PRs haven't been merged yet) I can now focus on this.
First of all, sorry for the breakage; these are options I haven't used before and I guess I forgot about them because they were implicit before.

Hmm interesting, I know what's happening: _async_setup_platform in homeassistant/helpers/entity_component.py is actually called twice.
The first sets up the light platform (I'm showing some extra debugging I added):
INFO:homeassistant.setup:Setting up light
INFO:homeassistant.setup:Setup of domain light took 0.0 seconds.
INFO:homeassistant.core:Bus:Handling <Event component_loaded[L]: component=light>
WARNING:homeassistant.components.light:domain=light platform_type=hue scan_interval=0:00:10, platform_config={'platform': 'hue', 'scan_interval': datetime.timedelta(0, 10), 'allow_hue_groups': True}

This first pass reflects the config (or I found out I can do other hacks).
Then on a second pass:
INFO:homeassistant.core:Bus:Handling <Event platform_discovered[L]: service=load_platform.light, platform=hue, discovered=bridge_id=<IP_ADDRESS>>
INFO:homeassistant.components.light:Setting up light.hue
WARNING:homeassistant.components.light:domain=light platform_type=hue scan_interval=0:00:30, platform_config={}

This is invoked implicitly via component_platform_discovered and that passed an empty config:
            self.hass.async_add_job(
                self._async_setup_platform(platform, {}, info))

which means we have nowhere to read scan_interval from if we use auto discovery :(
@MartinHjelmare what do you think?

Just to add to this I am also having issues not being able to specify a scan interval. I've got auto discovery for hue disabled - it seems to be hard coded to 10 seconds, scan_interval in configuration.yaml either directly under the hue or bridge entity causes errors. Thanks.

@MartinHjelmare yeah I spent a bunch of time trying to figure this out and I just have to idea how to work around this: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/helpers/entity_component.py#L84
No matter what I try, homeassistant/components/light/hue.py won't get a useful config; nor can I pass it as the hass_config argument to load_platform.
The only way I could get this to work is by changing homeassistant/helpers/entity_component.py. This might be a legit bug given that not many components support both discovery and a hub -> components setup.
See https://github.com/andreacampi/home-assistant/commit/893a229877ff78b5cb18bbff6ac128e6fb6225ca for how far I got and let me know what you think.

Yeah, it's not common to setup platform both via discovery from component and from platform config. It's even more uncommon to disallow platform setup from platform config, but still need the config for the platform when doing setup via discovery, as is the case here. I don't see a general problem with your change, although it could come across as weird, due to the conflicting approaches. I added a comment.
Open a PR to get a review from another member that's experienced in the core.

Use the entity registry to rename entity IDs related to Hue. Entity namespace will not come back.


UI consistency with beast/characters

Should the Level of your character be highlighted yellow to match the beast level?

We will take it into account and see if anyone else thinks the same, it's a very easy fix


Setup puts the files in to ProgramFiles no matter the destination was selected

Greeting.
The MSI installs the files into C:\Program Files\Wireshark
No matter if the different path was selected during setup.

Fixed in Release v1.1.0.
Thanks!


node group vm free mru checks

it should have failed and reported the error from the beginning

can you specify what is the error
if the problem is in free mru the limit is 262144 which is more than 200048, so it's safe, but we need to add limits to the node group values

validated in https://github.com/threefoldtech/tfgrid-sdk-go/issues/710#issuecomment-1921749327


master operator-sdk version lists scorecard tag instead

Bug Report
The Makefile is assigning the version using the latest tag which happens to be scorecard-kuttl.
export SIMPLE_VERSION = $(shell (test "$(shell git describe)" = "$(shell git describe --abbrev=0)" && echo $(shell git describe)) || echo $(shell git describe --abbrev=0)+git)

What did you do?
git fetch upstream
git rebase upstream/master
git push origin master
make build/operator-sdk

What did you expect to see?
$ build/operator-sdk version
operator-sdk version: "v1.5.0-2-g39febf1f", commit: "39febf1f4c769944ae11f700e82b30d422b647f8", kubernetes version: "v1.19.4", go version: "go1.15.8", GOOS: "linux", GOARCH: "amd64"

What did you see instead? Under which circumstances?
$ build/operator-sdk  version
operator-sdk version: "scorecard-kuttl/v2.0.0-1-gc6796de9", commit: "c6796de9b29ace4f4c737325c9037f6f715ce6d1", kubernetes version: "v1.19.4", go version: "go1.15.8", GOOS: "linux", GOARCH: "amd64"

Environment
Operator type:

Kubernetes cluster type:

$ operator-sdk version

$ go version (if language is Go)

$ kubectl version

Possible Solution

Additional context

Honestly I'd rather see operator-sdk version: "master-dirty" than `version: "scorecard-kuttl/v2.0.0-1-gc6796de9"


Newest Safari removes the extension entirely

Running Safari 13.0, the Favicon is uninstalled at launch

Yes, as of Safari 13 this extension is effectively dead. :(
The older extension interface is no longer supported, and the new interface does not allow toolbars.


Hi. I love your minimap :)

Im using it currently for a dark souls world map website.
http://e3.netne.net/darksoulsmap/
But for some reason, well, I know the reason but I'm unware how to fix them.
Im using multiple images and get small white lines in the mini-map like this, https://snag.gy/1GDsaU.jpg
If you know how to fix it then it be nice =)

Your link to the site doesn't seem to work. If you can provide a working example that does the same thing I may be able to help.

stephaniie.com/_testlab/beta1/

As far as I can tell this isn't an issue with this library but rather an issue with the browser itself. It seems to only happen on images that have css scale property applied to them.  Using this module I don't think there is a way around this however what you could do is create and save the rendered element.  After that you could edit the css and images to have height and width values rather that using scale.  If that doesn't work you can try adding a negative margin-top value to see if it will close the tiny gap.  Sorry I can't be of any more help but that's all I was able to figure out.


[Bug] [ dolphinscheduler-alert] Fix send http request error

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
send http request should add port and setMsgInUrl should add URLEncoder.encode for msg
What you expected to happen
send http request should add port and setMsgInUrl should add URLEncoder.encode for msg
How to reproduce
send http request should add port and setMsgInUrl should add URLEncoder.encode for msg
Anything else
No response
Version
3.1.x
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

closed by https://github.com/apache/dolphinscheduler/pull/14793


Cannot add new Test Run to a Test Plan

Hi,
Inside a milestone, I am doing the following:

Create a new Test Plan.
Create a new Test Run
Configure the new Run with a Suite ID, a Milestone ID, an Assigned To ID, and a Plan ID (the one from the created plan)
I log the pre-created Run object (using log4j2) and see it has the expected Plan ID
I create the run.
I log the Run object (post-creation), and see it now has a 'null' Plan ID
Looking in TestRail, I see the Plan and Run side-by-side, rather than the Test Run being found inside the Test Plan.

Code:
    int milestoneId = 131;
    Plan plan = new Plan();
    UI_TEST_PLAN = "HTML_UI";
    plan.setName(UI_TEST_PLAN);
    plan.setMilestoneId(milestoneId);
    Plan responsePlan = TR.plans().add(projectId, plan).execute();
    LOGGER.info("Created new plan: {}. Full: {}", responsePlan.getId(), responsePlan);
    List<Suite> suites = TR.suites().list(projectId).execute();
    for (Suite suite : suites) {
        if (suite.getName().startsWith("UI")) { // expected one is named UI-Suite in this testrail sandbox
            Run run = new Run();
            run.setSuiteId(suite.getId());
            run.setPlanId(responsePlan.getId());
            run.setMilestoneId(milestoneId);
            run.setAssignedtoId(ROBOT_USER_ID);
            LOGGER.info("Pre-created run: {}", run);
            Run createdRun = TR.runs().add(projectId, run).execute();
            LOGGER.info("Created run: {}", createdRun);
            //TODO the test run is created but it's not getting into the test plan
        }
    }

Log4j2 logging, where you can see the  Plan ID goes from 4355 pre-creation (which is correct) to null post-creation.
2017-11-13 09:11:25,130  INFO [main] [TestRailAPI] : Created new plan: 4355. Full: Plan(id=4355, name=HTML UI, description=null, url=https://vmturbo.testrail.com/index.php?/plans/view/4355, projectId=2, milestoneId=131, assignedtoId=null, createdOn=Mon Nov 13 09:11:22 EST 2017, createdBy=87, isCompleted=false, completedOn=null, passedCount=0, blockedCount=0, untestedCount=0, retestCount=0, failedCount=0, customStatus1Count=0, customStatus2Count=0, customStatus3Count=0, customStatus4Count=0, customStatus5Count=0, customStatus6Count=0, customStatus7Count=0, entries=[])
2017-11-13 09:11:46,657  INFO [main] [TestRailAPI] : Pre-created run: Run(id=0, name=null, description=null, url=null, projectId=0, planId=4355, suiteId=298, milestoneId=131, assignedtoId=87, includeAll=null, caseIds=null, createdOn=null, createdBy=0, isCompleted=false, completedOn=null, config=null, configIds=null, passedCount=0, blockedCount=0, untestedCount=0, retestCount=0, failedCount=0, customStatus1Count=0, customStatus2Count=0, customStatus3Count=0, customStatus4Count=0, customStatus5Count=0, customStatus6Count=0, customStatus7Count=0)
2017-11-13 09:12:34,200  INFO [main] [TestRailAPI] : Created run: Run(id=4356, name=UI-Suite, description=null, url=https://vmturbo.testrail.com/index.php?/runs/view/4356, projectId=2, planId=null, suiteId=298, milestoneId=131, assignedtoId=87, includeAll=true, caseIds=null, createdOn=Mon Nov 13 09:12:22 EST 2017, createdBy=87, isCompleted=false, completedOn=null, config=null, configIds=[], passedCount=0, blockedCount=0, untestedCount=1, retestCount=0, failedCount=0, customStatus1Count=0, customStatus2Count=0, customStatus3Count=0, customStatus4Count=0, customStatus5Count=0, customStatus6Count=0, customStatus7Count=0)

Screenshot showing correct milestoneId in URL bar (131), correct plan ID at the bottom left from hovering over the Plan link (4355), and showing the Test Run created outside the plan anyway.

Lastly, we're using a hosted TestRail version. Checking for updates says we're using the latest version, which is:
TestRail version | <IP_ADDRESS>60 (check for update)

I have faced the same issue.
Entry, not Run should be added to Test Plan.
This code works for me:
        Plan.Entry.Run run = new Plan.Entry.Run();
        run.setName("AQA test");
        Plan.Entry entry = new Plan.Entry()
                .setRuns(Arrays.asList(run));
        entry.setSuiteId(suiteId);
        testRail.plans().addEntry(testPlanId, entry).execute();

how do you give this new entry a name!?


chore: dummy changes to trigger codecov

Issue #, if available:
N/A
Description of changes:
Changes for CodeCov demo purposes.
Checklist:

[ ] Have you successfully deployed to an AWS account with your changes?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully tested with your changes locally?
[ ] Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
[ ] If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?

AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #464 (7885a46) into develop (9b30e4e) will decrease coverage by 16.90%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop     #464       +/-   ##
============================================
- Coverage    49.81%   32.90%   -16.91%
============================================
  Files          242       32      -210
  Lines        10297     1240     -9057
  Branches      1438      238     -1200
============================================
- Hits          5129      408     -4721
+ Misses        4351      652     -3699
+ Partials       817      180      -637

Impacted Files
Coverage Δ

lib/user/user-authz-service.js
29.26% <0.00%> (-39.39%)
:arrow_down:

lib/helpers/utils.js
24.00% <0.00%> (-16.33%)
:arrow_down:

src/models/users/UsersStore.js
40.35% <0.00%> (-5.40%)
:arrow_down:

src/helpers/settings.js
100.00% <0.00%> (ø)

lib/compute/compute-price-service.js

src/models/studies/StudyPermissions.js

...els/environments/EnvironmentConfigurationsStore.js

lib/utils/attribute-value.js

src/models/environment-types/EnvType.js

src/models/forms/EnvTypeConfigForm.js

... and 207 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b30e4e...7885a46. Read the comment docs.


Upgradle to nightly with native Linux watching

Sorry, I didn't see this or I would have just merged it.  I bumped the wrapper on release: https://github.com/gradle/gradle/commit/1d5d45f4d1a709da146b51ac7d0b5b957cfed141

A newer nightly is already used on release and master. Closing.


SystemRescueCD 5.0.3 ISO problem

When loading the SystemRescueCD ISO file, Etcher warns that the file is not bootable.
So, I have to use the Manual Method for making a bootable USB drive.
Etcher Version: etcher-1.1.2-x86_64.AppImage
Operating System: Ubuntu 16.04.2

Sounds like this issue is very similar to https://github.com/resin-io/etcher/issues/1644 i.e. the problem isn't  with Etcher, but with the image file being a 'real' ISO.
@jviotti Should we close?

I will try that suggestion and report back.
Paul

Awesome. I'll close it, but please re-open if you find something else :)


DYNAMIC_SERVER_USAGE - some routes need dynamic serving

While running bun run build  I am getting few warnings referencing: https://nextjs.org/docs/messages/dynamic-server-error

/zh/dashboard/billing
/ja/dashboard/billing
/ko/dashboard/billing

What is strange is that there is nothing about the english version?
While the impact is likely small, it is something you may want to fix.

Thanks @shuther , we will check and fix it.


Reactivate ModifiedCard to warn users about exporting the Phyx file

We used to have a ModifiedCard component that displayed a "This phyloreference has changed! Please remember to save it." box above any modified phyloreference (and ditto for phylogenies), but it appears to have been broken by a previous update. It would be nice to have it back so people know that they have to export their Phyx file regularly.
Related to #69.

Yes!!

This seems to be working now. I'll close this for now and reopen if it stops working again (of course, automated tests via #224 would help ensure that this problem is permanently fixed).


Functional test for generate command

Codecov Report

Merging #52 into master will increase coverage by 10.94%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #52       +/-   ##
===========================================
+ Coverage   25.54%   36.49%   +10.94%
===========================================
  Files          14       14
  Lines         274      274
===========================================
+ Hits           70      100       +30
+ Misses        204      174       -30

Impacted Files
Coverage Δ

lib/kite/core.rb
92.85% <0%> (+14.28%)
:arrow_up:

lib/kite/base.rb
100% <0%> (+25%)
:arrow_up:

lib/kite/helpers.rb
78.37% <0%> (+27.02%)
:arrow_up:

lib/kite/cloud.rb
100% <0%> (+30.76%)
:arrow_up:

lib/kite/generate.rb
91.66% <0%> (+54.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d761b...bee6796. Read the comment docs.


Converting scale array in adjoint computation fails for some arrays

The code convert(typeof(x), scale) fails when x is a subarray, e.g. in line
https://github.com/JuliaMath/AbstractFFTs.jl/blob/1cc9ca01f9f1968face7557c372f7a90ca26f693/src/definitions.jl#L641

It also fails when x is a Zygote.OneElement, causing test failures in Zygote: see https://github.com/FluxML/Zygote.jl/actions/runs/5787572971/job/15684783986 and discussion in https://github.com/FluxML/Zygote.jl/pull/1444.


Migrate More Options & Add card interactions

Migrate the more options function to show the delete/edit/report option.
As part of the screen reader accessibility the one element card reading was added, with the only other element for the screen reader being the view more. Therefore it will need the View Owner, View Post, Like, and similar actions, added to the more options menu where/when applicable.

All Options: Share, Add Calendar, Report, Edit, Delete, Show Profile, View Post, Like/Likes, View Group, Reply.
Current Data: Owner, GUID, Type.
Adding more data to enable the new options.
Owner: authour's guid.
Guid: Post's guid.
Type: Post's guid.
Container: authour or group guid.
Context: card vs post.


add http proxy support for<EMAIL_ADDRESS>

fixed #7
internal method changed
http.Agent#addRequest(req, host, port, localAddress)  -->  http.Agent#addRequest(req, options)

I have been running with this patch on both node 0.12.0 and 0.10.33 through an http proxy and it works perfectly. Without this patch, node 0.12.0 failed.

Can we merge this pls?

@stash Can we get this merged?

I don't think it actually works with node 0.12 or the new 4.0 implementation. I've been working on a better solution, but I have not had time to finish it yet. Sorry, but can't promise an ETA just yet.

@stash-sfdc it's working great for me too with node v5.1.0, looking forward to your change though. Thanks @zincli anyway. :+1:

@christian-bromann well that's some unexpected good news! what's your use-case of global-tunnel?

@stash-sfdc proxying protractor requests through a transparent proxy

@christian-bromann thanks for the response, but I think I asked that question the wrong way. Which one of these variations are you using to configure global-tunnel?

the auto-config one:
var globalTunnel = require('global-tunnel');
process.env.http_proxy = process.env.HTTP_PROXY;
globalTunnel.initialize();

Would be nice if global-tunnel wouldn't care about capitalization though

To make Node LTS 4.2.x work, all I needed to do was update tunnel to 0.0.4. My corporate proxy is https over http and I'm using auto-config via env like @christian-bromann . https://github.com/zincli/global-tunnel/commit/97910e76b9d2b01f2bc4abf57f80cc1afa75cd82 was not needed for my use case, it works with or without those changes. I can submit a PR to bump the dependency version, let me know. Thanks!


Simplify updating configuration

Currently updating configuration in git (external configurations) requires deleting/creating container manually. Add button "Recreate" to the UI for simplifying this common operation.
see:
 post /ui/api/containers/recreate

UI part done.


Housing Laws

Requirement
The website should adhere to fair housing laws to prevent discrimination (REA-001 and REA-002).
Tasks

[ ] Follow fair housing guidelines for displaying property information
[ ] Provide fair housing training for real estate agents using the website
[ ] Regularly review and update fair housing policies and practices.

From Use Cases: REA-001, REA-002
https://github.com/RequirementsProject/RealtorWebsiteProject/blob/main/Use Cases.pdf


From Milestone2 feedback - Update how can other packages contribute from R to this package

There ins't a paragraph describing where your package fit into the R ecosystem. Are there any other R packages that have the same/similar functionality? Provide links to any that do. If none exist, then clearly state this as well). Although a paragraph exists, it fails to complete the requirements. In particular how can other packages contribute from R to this package? - mechanics -2.

There ins't a paragraph describing where your package fit into the R ecosystem. Are there any other R packages that have the same/similar functionality? Provide links to any that do. If none exist, then clearly state this as well). Although a paragraph exists, it fails to complete the requirements. In particular how can other packages contribute from R to this package? - mechanics -2.

Added in R repo


[labs/react] createComponent React component style property typescript problem

Description
Overriding the style property on a wrapped component (using createComponent) results in a typescript error.
The error expects all style properties to be set.
Steps to Reproduce
WrappedWebComponent.ts
import { Slider } from<EMAIL_ADDRESS>import { createComponent } from "@lit-labs/react";
import React from "react";

const Component = createComponent(React, "mwc-slider", Slider, {
  oninput: "input",
});

export default Component;

Using component in App.tsx
<WrappedWebComponent
  style={{
    background: "red",
  }}
/>

Typescript Error:
(property) style?: (CSSStyleDeclaration & React.CSSProperties) | undefined
Type '{ background: string; }' is not assignable to type 'CSSStyleDeclaration & CSSProperties'.
  Type '{ background: string; }' is missing the following properties from type 'CSSStyleDeclaration': accentColor, alignContent, alignItems, alignSelf, and 450 more.ts(2322)

Expected Results
Allow overriding of style property
Actual Results
Typescript error, expecting all css properties to be set

Vscode
Create React App

This issue should be resolved with #3072
:) curious if that can be confirmed


Updated syntax for multinode usage

Hi, I'm working on Google Colab and trying to setup minimal example of multi-core pytorch training with webdataset using data on GCP Buckets. Specifically I've got a bucket with my training shards and another bucket with test shards.
For colab setup, I'm using the suggested wheels from the pytorch XLA notebook for multi-core and adding webdataset to the pip installs. I see I've got webdataset 0.2.31 from pip show webdataset in the console.
I tried to start from (https://webdataset.github.io/webdataset/multinode/) with this code in the map function:
urls = list(braceexpand.braceexpand(FLAGS['train_urls']))
dataset = (wds.WebDataset(urls)
             .to_tuple('x_data.npy', 'y_data.npy')
             .map(preprocess)
             .batched(50))

but I'm seeing some strange behavior that I don't understand. Specifically, the docs indicates that a default nodesplitter and split_by_worker should be in effect:
urls = list(braceexpand.braceexpand("dataset-{000000..000999}.tar"))
dataset = wds.ShardList(urls, splitter=wds.split_by_worker, nodesplitter=wds.split_by_node, shuffle=False)
dataset = wds.Processor(dataset, wds.url_opener)
dataset = wds.Processor(dataset, wds.tar_file_expander)
dataset = wds.Processor(dataset, wds.group_by_keys)

What I see from the following however is that every core processes every file with the following in my map function. (Next step would be to investigate worker splitting once we've got shards distributed across cores)
loader = DataLoader(dataset, num_workers=FLAGS['num_workers'])
for batch, (x,y) in enumerate(loader):
  print(f'core:{rank} batch:{batch}: x_min: {torch.min(x)} x_max: {torch.max(x)} len:{x.size()}')

I saw a related post with a suggestion to use v2 branch (#https://github.com/webdataset/webdataset/issues/138) but (if possible) I'd like to have my dependency be the main release that's going to come in under webdataset with pip.
I also attempted to expand on the wds.Processor approach but that doesn't seem to be available in this version maybe? High level just looking for best advice on implementing a pretty vanilla version of this with shard shuffling and sample shuffling. I'm not sure how shard shuffling across cores is coordinated (do you use a parallel loader?) so thoughts on that would be great too. If a minimum working example notebook would improve/clarify this question that's also something I'm happy to provide.

Just in case you are still trying to fix this, I was able to get the right split behavior by using what was suggested. A simple visual test:
import os
import webdataset as wds
import torch
import torch.distributed as dist

if __name__ == "__main__":
    try:
        rank = int(os.environ["RANK"])
        world_size = int(os.environ["WORLD_SIZE"])
        local_rank = int(os.environ["LOCAL_RANK"])
        dist.init_process_group("nccl")
    except KeyError:
        rank = 0
        world_size = 1
        local_rank = 0
        dist.init_process_group(
            backend="nccl",
            init_method="tcp://<IP_ADDRESS>:12584",
            rank=rank,
            world_size=world_size,
        )

    dataset = wds.DataPipeline(
        wds.SimpleShardList("source-{000000..000999}.tar"),
        wds.split_by_node,
        wds.split_by_worker,
    )

    for idx, i in enumerate(iter(dataset)):
        if idx == 2:
            break

        print(f"rank: {rank}, world_size: {world_size}, {i}")

--> torchrun --nproc-per-node 8 test-webdataset-dist.py
WARNING:torch.distributed.run:
*****************************************
Setting OMP_NUM_THREADS environment variable for each process to be 1 in default, to avoid your system being overloaded, please further tune the variable for optimal performance in your application as needed.
*****************************************
rank: 3, world_size: 8, {'url': 'source-000003.tar'}
rank: 3, world_size: 8, {'url': 'source-000011.tar'}
rank: 1, world_size: 8, {'url': 'source-000001.tar'}
rank: 1, world_size: 8, {'url': 'source-000009.tar'}
rank: 6, world_size: 8, {'url': 'source-000006.tar'}
rank: 6, world_size: 8, {'url': 'source-000014.tar'}
rank: 5, world_size: 8, {'url': 'source-000005.tar'}
rank: 5, world_size: 8, {'url': 'source-000013.tar'}
rank: 0, world_size: 8, {'url': 'source-000000.tar'}
rank: 0, world_size: 8, {'url': 'source-000008.tar'}
rank: 4, world_size: 8, {'url': 'source-000004.tar'}
rank: 4, world_size: 8, {'url': 'source-000012.tar'}
rank: 7, world_size: 8, {'url': 'source-000007.tar'}
rank: 7, world_size: 8, {'url': 'source-000015.tar'}
rank: 2, world_size: 8, {'url': 'source-000002.tar'}
rank: 2, world_size: 8, {'url': 'source-000010.tar'}

And if you do shuffle, use detshuffle,
    dataset = wds.DataPipeline(
        wds.SimpleShardList("source-{000000..000016}.tar"),
        wds.shuffle(),
        wds.split_by_node,
        wds.split_by_worker,
    )

rank: 7, world_size: 8, {'url': 'source-000015.tar'}
rank: 7, world_size: 8, {'url': 'source-000014.tar'}
rank: 4, world_size: 8, {'url': 'source-000008.tar'}
rank: 4, world_size: 8, {'url': 'source-000010.tar'}
rank: 5, world_size: 8, {'url': 'source-000007.tar'}
rank: 2, world_size: 8, {'url': 'source-000000.tar'}
rank: 5, world_size: 8, {'url': 'source-000016.tar'}
rank: 2, world_size: 8, {'url': 'source-000009.tar'}
rank: 0, world_size: 8, {'url': 'source-000012.tar'}
rank: 0, world_size: 8, {'url': 'source-000011.tar'}
rank: 1, world_size: 8, {'url': 'source-000013.tar'}
rank: 1, world_size: 8, {'url': 'source-000005.tar'}
rank: 6, world_size: 8, {'url': 'source-000006.tar'}
rank: 6, world_size: 8, {'url': 'source-000003.tar'}
rank: 3, world_size: 8, {'url': 'source-000004.tar'}
rank: 3, world_size: 8, {'url': 'source-000001.tar'}

If you use shuffle() there, each rank/dataloader worker would get different random seed and shuffle non-deterministically.

With regard to the WebDataset API I was able to get the correct splitting,
    dataset = (
        wds.WebDataset("source-{000000..00007}.tar", shardshuffle=True, detshuffle=True, nodesplitter=wds.split_by_node)
    )
    dataset.pipeline.pop()

    for idx, i in enumerate(iter(dataset)):
        print(f"rank: {rank}, world_size: {world_size}, {i}")

rank: 0, world_size: 8, {'url': 'source-000000.tar'}
rank: 1, world_size: 8, {'url': 'source-000001.tar'}
rank: 2, world_size: 8, {'url': 'source-000002.tar'}
rank: 3, world_size: 8, {'url': 'source-000003.tar'}
rank: 4, world_size: 8, {'url': 'source-000004.tar'}
rank: 5, world_size: 8, {'url': 'source-000005.tar'}
rank: 6, world_size: 8, {'url': 'source-000006.tar'}
rank: 7, world_size: 8, {'url': 'source-000007.tar'}

I'm testing using version 0.2.57.

WebDataset does not perform node splitting by default, just splitting by workers. It is supposed to output an error when it discovers that it is running multinode, but doesn't seem to be doing it here.
I'll see whether I can improve the error detection and docs.


Adding all_reduce facility to collectives module

flyby: minor fixes to all_to_all

@msimberg this is good to go now. Would you have the time to review?


Incorrect log display

The new version stopped displaying the log correctly
https://i.imgur.com/X7kTlxt.jpg
/lp log userhistory DarkFort

You need to update your language file from the English one.

Same in the English translation https://i.imgur.com/YJvbD3C.jpg

But when I delete en_US locale.yml everything is fine

Yep - seems I haven't updated the lang file yet.

Locale files now live here. I've updated the en_US one with the latest changes.
https://github.com/LuckPerms/locale


Extract kernel compile from buildAotSnapshot

Moves the kernel compile step to the beginning of the AOT build in a
separate method. This is pre-factoring for iOS universal builds where
the kernel build happens once, but we then snapshot twice: once for
armv7 and once for arm64.
This also writes dependencies to build/kernel_compile.d rather than
build/aot/snapshot.d, since that is immediately overwritten by
gen_snapshot.

cc @aam @tvolkert

Related #2089

The class '_FakeKernelCompiler' isn't used. (packages/flutter_tools/test/base/build_test.dart, line 73, col 7)

Done.


Bug: body is used without checking the existense of body_path.

Contrary to what is written in the readme:
When providing a body and body_path at the same time, body_path will be attempted first, then falling back on body if the path can not be read from.

The actual javascript code for extracting releaseBody checks if body is provided and ignores reading the body_path outright.

Thanks for the bug report. If I don't get to this sooner I'll happily accept a pull request


chore: tickets-service to 0.0.3

chore: Promote tickets-service to version 0.0.3

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@salaboy: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

promotion-build
e0173b3b7956af20a35ebf48da43db0b809483ac
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[Feature request] Add keybind option to open screenshot gui

There's already a keybind in the controls menu.


Support synchronized selection of fields that share a name, across several surfaces

It'd be nice to provide the option (though probably not the requirement) for the user to change the selected field on multiple surfaces at the same time. Need to think about what the UI for this would look like.

Per conversation 1/7/22, we should provide a toggle at the top.

When the toggle is on, we present scalar/vector field selection whose options are the union of the [scalar|vector] fields on all the surfaces, and the selected field is reset on all of them.
When the toggle is off, we just use the current functionality.

This will require some tweaks to the reducer as well as some new UI components.


Can't connect to Superhero Meet using an extension

After accepting 2 pop-ups, no connection was established. The same behaviour on develop branch:

Fixed by #1389. This issue can be closed.


Outdated cask: aquamacs

Outdated cask: aquamacs.
Info:

version: 3.2.
appcast url: https://github.com/davidswelt/aquamacs-emacs/releases.atom.

Closing in favour of #19039.


One or more build-args [site_root] were not consumed, failing build

Using the sample Dockerfile, I am getting the following error during build:
PS C:\containers\ASP5> docker build -t aspnet-site --build-arg site_root=/ .
Sending build context to Docker daemon 7.946 MB
Step 1/2 : FROM microsoft/iis
---> 211fecef1e6b
Step 2/2 : RUN powershell -Command Add-WindowsFeature NET-Framework-45-ASPNET;     powershell -Command Add-WindowsFeature Web-Asp-Net45;     powershell -Command Remove-Item -Recurse C:\inetpub\wwwroot*
---> Running in 9d45db46a8a9
Success
Restart Needed Exit Code      Feature Result

True    No             Success        {ASP.NET 4.6}
Success Restart Needed Exit Code      Feature Result

True    No             Success        {Application Development, ASP.NET 4.6,...
---> 1530caa06fad
Removing intermediate container 9d45db46a8a9
One or more build-args [site_root] were not consumed, failing build.
Any idea what is causing this? Appreciate any feedback.
Thanks,
Ron

This because the wrong dockerfile is linked in the documentation. The correct dockerfile is here - https://github.com/Microsoft/aspnet-docker/blob/master/4.6.2/sample/Dockerfile
Contents of Dockerfile:
FROM microsoft/aspnet
ARG site_root=.
ADD ${site_root} /inetpub/wwwroot

You can see that now we make use of the build args to add the site root to IIS root.


Avoid error when AllowedIps is not defined

This should fix #9

@all-contributors please add @tonjo for code


nixos/nginx: run nginx-config-reload as the nginx user and group

This unit currently runs ${execCommand} -t as root, which will cause
nginx to create files in /var/spool/nginx as the "nobody" user (which is
the default if no user/group is specified in the nginx config itself
(which is true in our case, as we run nginx as an unprivileged user and
don't give it a chance to create/chown files and folders for the nginx
unit at least.
Reported-By: @tazjin
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Error reload:
systemd[1]: Starting nginx-config-reload.service...
sb398bf2mimvcnxn629wsc92v9a9h41v-unit-script-nginx-config-reload-start[5737]: nginx: the configuration file /etc/nginx/nginx.conf syntax is ok
sb398bf2mimvcnxn629wsc92v9a9h41v-unit-script-nginx-config-reload-start[5737]: 2020/04/23 10:40:39 [emerg] 5745#5745: bind() to <IP_ADDRESS>:80 failed (13: Permission denied)
sb398bf2mimvcnxn629wsc92v9a9h41v-unit-script-nginx-config-reload-start[5737]: nginx: configuration file /etc/nginx/nginx.conf test failed
systemd[1]: nginx-config-reload.service: Main process exited, code=exited, status=1/FAILURE
systemd[1]: nginx-config-reload.service: Failed with result 'exit-code'.
systemd[1]: Failed to start nginx-config-reload.service.

If add:
        # Capabilities
        AmbientCapabilities = [ "CAP_NET_BIND_SERVICE" ];

Error:
systemd[1]: Starting nginx-config-reload.service...
kfxsv78ji9cjjkjn0kflbhf5hlz336kq-unit-script-nginx-config-reload-start[6831]: nginx: the configuration file /etc/nginx/nginx.conf syntax is ok
kfxsv78ji9cjjkjn0kflbhf5hlz336kq-unit-script-nginx-config-reload-start[6831]: nginx: configuration file /etc/nginx/nginx.conf test is successful
kfxsv78ji9cjjkjn0kflbhf5hlz336kq-unit-script-nginx-config-reload-start[6831]: Failed to reload nginx.service: Interactive authentication required.
kfxsv78ji9cjjkjn0kflbhf5hlz336kq-unit-script-nginx-config-reload-start[6831]: See system logs and 'systemctl status nginx.service' for details.
systemd[1]: nginx-config-reload.service: Main process exited, code=exited, status=1/FAILURE
systemd[1]: nginx-config-reload.service: Failed with result 'exit-code'.
systemd[1]: Failed to start nginx-config-reload.service.

I updated the unit. We now invoke systemctl reload nginx.service as root, and the check command (which creates the state files) as cfg.user. TBH, this is a scary unit in first place, and the nginx unit will be fixed to just handle proper reload on its own for master in a follow-up PR, but this is something also for backporting.

apparently, it seems like nginx -t also tries to bind to ports, which is a stupid thing to do while running as a separate user:
webserver # Apr 23 10:20:33 webserver nginx[1094]: 2020/04/23 10:20:33 [emerg] 1094#1094: bind() to <IP_ADDRESS>:80 failed (13: Permission denied)

I don't really think it should do this, especially not while "the previous" nginx is still running. @Izorkin agreed to open a bugreport upstream.

@flokli would AmbientCapabilities = [ "CAP_NET_BIND_SERVICE" ]; fix the issue in mean time, as @Izorkin proposed?

@flokli check this variant:
diff --git a/nixos/modules/services/web-servers/nginx/default.nix b/nixos/modules/services/web-servers/nginx/default.nix
index 8d49dc66eb1..21bedc93df8 100644
--- a/nixos/modules/services/web-servers/nginx/default.nix
+++ b/nixos/modules/services/web-servers/nginx/default.nix
@@ -729,7 +729,12 @@ in
       script = ''
         if ${pkgs.systemd}/bin/systemctl -q is-active nginx.service ; then
           ${execCommand} -t && \
-            ${pkgs.systemd}/bin/systemctl reload nginx.service
+            ${pkgs.systemd}/bin/systemctl reload nginx.service && \
+            chown ${cfg.user}:${cfg.group} '${cfg.stateDir}/client_body_temp' && \
+            chown ${cfg.user}:${cfg.group} '${cfg.stateDir}/fastcgi_temp' && \
+            chown ${cfg.user}:${cfg.group} '${cfg.stateDir}/proxy_temp' && \
+            chown ${cfg.user}:${cfg.group} '${cfg.stateDir}/scgi_temp' && \
+            chown ${cfg.user}:${cfg.group} '${cfg.stateDir}/uwsgi_temp'
         fi
       '';
       serviceConfig.RemainAfterExit = true;

Ticket closed :( - https://trac.nginx.org/nginx/ticket/1960
Manual add custom patch?

@flokli would AmbientCapabilities = [ "CAP_NET_BIND_SERVICE" ]; fix the issue in mean time, as @Izorkin proposed?

This won't help. The nginx-config-reload unit runs nginx -t if the real nginx is already running. So even if it'd have CAP_NET_BIND_SERVICE, it still couldn't bind, as the socket is already in use by the real nginx process.
Also, on @Izorkin 's proposed alternative: This will still chown state files around, while the real nginx is still running.
I'm more in favor of not executing nginx -t at all, and just handling nginx reloads via the original systemctl reload nginx.service. What was the reason for this separate unit in first place?

Variant - add this patch:
diff --git a/src/core/ngx_connection.c b/src/core/ngx_connection.c
index 3368253..1cbfe46 100644
--- a/src/core/ngx_connection.c
+++ b/src/core/ngx_connection.c
@@ -601,21 +601,12 @@ ngx_open_listening_sockets(ngx_cycle_t *cycle)
             if (bind(s, ls[i].sockaddr, ls[i].socklen) == -1) {
                 err = ngx_socket_errno;

-                if (err != NGX_EADDRINUSE || !ngx_test_config) {
-                    ngx_log_error(NGX_LOG_EMERG, log, err,
-                                  "bind() to %V failed", &ls[i].addr_text);
-                }
-
                 if (ngx_close_socket(s) == -1) {
                     ngx_log_error(NGX_LOG_EMERG, log, ngx_socket_errno,
                                   ngx_close_socket_n " %V failed",
                                   &ls[i].addr_text);
                 }

-                if (err != NGX_EADDRINUSE) {
-                    return NGX_ERROR;
-                }
-
                 if (!ngx_test_config) {
                     failed = 1;
                 }

Variant - add this patch:

nginx would still chown state files around (which we could fix by setting user and group in the nginx config file as well), but this patch will also just prevent nginx from doing error reporting if it legitimately tries to bind to a socket.
What about just using systemctl reload nginx.service to reload nginx, and skip the check, which is more than a check anyways?

I don't think we should be shipping an nginx with strange patches to accommodate new features done of our developers would like to see upstream, but upstream has rejected. It's one thing to patch software for nix specific quirks, but this is entirely different.

I pushed a new commit that handles the reload differently:

nixos/nginx: run nginx-config-reload as the nginx user and group
The "nginx-config-reload" script previously ran nginx -t as root,
causing nginx to create files in /var/spool/nginx as the "nobody" user
(which is the default if no user/group is specified in the nginx config
itself).
As further investigation showed 1, nginx -t does not only create
files, but also tries to bind to sockets - which is a terrible thing to
do to while just checking the configuration, which is why we removed the
-t command from the nginx-config-reload command entirely, effectively
aliasing it to systemctl reload nginx.service.
Instead of all that, we now invoke nginx -s reload in the ExecReload
command of nginx.service, which will move the unit into a failed
state (but not stop the webserver).
These failures are currently not properly propagated to the
switch-to-configuration script, but systemctl is-failed nginx will
return 0, and monitoring should detect this.

@danbst, @aanderse, can you take a look?

Worked in test server.

Thanks for looking into this!

Fixing the reload behaviour needs a bit more work - I wrote down something in https://github.com/NixOS/nixpkgs/issues/49528#issuecomment-622196884.

it still couldn't bind, as the socket is already in use by the real nginx process

This isn't true if you've enabled SO_REUSEPORT, which is sort of recommended for efficiency, etc. Although it being able to bind probably only makes things worse.
Thanks for looking into this, though!

I have this alternative: https://github.com/NixOS/nixpkgs/pull/95249

Closing in favor of #95249.


sqlfluff: 2.1.0 -> 2.1.1

Diff: https://github.com/sqlfluff/sqlfluff/compare/refs/tags/2.1.0...2.1.1
Changelog: https://github.com/sqlfluff/sqlfluff/blob/2.1.1/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 234579 run on x86_64-darwin 1

2 packages built:

sqlfluff
sqlfluff.dist

Result of nixpkgs-review pr 234579 run on x86_64-linux 1

2 packages built:

sqlfluff
sqlfluff.dist


RHEL-09-231065 is causing / file system to be changed from xfs to nfs

Describe the Issue
RHEL-09-231065 is causing / file system to be changed from xfs to nfs
Expected Behavior
Add "nodev" to nfs mounts and do not change anything else
Actual Behavior
changes / mountpoint from xfs to nfs
Control(s) Affected
RHEL-09-231065
Possibly also:
RHEL-09-231070
RHEL-09-231075
Environment (please complete the following information):

branch being used: devel
Ansible Version: 2.15.1
Host Python Version: Python 3.11
Ansible Server Python Version: Python 3.9
Additional Details:

Additional Notes
This i causing the systems the run this control to not boot up properly.
Possible Solution
Only loop through mount points with the nfs fstype attribute

hi @layluke
Thank you for taking the time to raise these Issues and PRs. Looking through this the selectattr is set on the conditional, although the solution you have is much tidier.
Also you have stated XFS to nfs, i will try and setup another system to test as this should never change to xfs, it should have kept it to the filesystem type it is set for.
Many thanks as always
uk-bolly


WIP to update openresty

Description
WIP; This isn't building, because apparently CI isn't able to download the source uri
Do not commit until the omnibus-software def is merged and the omnibus/Gemfile change pointing to the ma/update_openresty branch is removed.
Update openresty definition to <IP_ADDRESS>
Signed-off-by: Mark Anderson<EMAIL_ADDRESS>[Please describe what this change achieves]
Issues Resolved
This should replace and close #1330 and the parallel change to omnibus-software should close https://github.com/chef/omnibus-software/pull/863
Check List

[ ] New functionality includes tests
[ ] All tests pass
[ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco
[ ] PR title is a worthy inclusion in the CHANGELOG

https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/284#698c0ec0-f29c-460d-8ded-d9ec0de5a856

Passes in https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/305
Need to merge omnibus-software change, then change this back to point to master omnibus-software.

Can be merged after getting the omnibus-software change merged in for openresty. (https://github.com/chef/omnibus-software/pull/1080)


Miscellaneous frontend fixes

These were not worth a separate PR each in my opinion:

Fix #93
Fix #91

This should function correctly now.


[BACKEND] Use LL to simplify redundant elements check and fix related issues

Not sure if it will cause any perf gain/drop. Please help me run a perf regression test when you're available.

running tests


[install] [1.14.0] Cannot install via Gradle

Have you read and followed the installation tutorial at http://www.nokogiri.org/tutorials/installing_nokogiri.html?

[x] Yes!

Sorry I'm not using the rest of the issue template but it doesn't fit my case. Reproduction:
plugins {
	id 'com.github.jruby-gradle.base' version '2.0.2'
}

repositories {
	mavenCentral()
	ruby.gems()
}

dependencies {
	gems 'rubygems:nokogiri:1.14.0'
}

If you put that in build.gradle and run gradle jrubyPrepare, it will fail:
exception thrown for request to /rubygems/nokogiri/1.14.0/ivy.xml
com.github.jrubygradle.api.gems.GemVersionException: 'isorelax' does not look like a GEM version requirement

And a big stack-trace. Using Gradle 7.6, Java 19.0.1 on Linux.
Downgrading to 1.13.0 fixes the issue. I've got no idea what that error is, probably some issue in nokogiri or in Gradle's JRuby plugin. Let me know what you think. Thanks!

Thanks for reporting. I'll take a look after the weekend. I'm not familiar with Gradle but maybe someone from the JRuby team can lend a hand.

@mkristian @headius Do either of you understand what's going on here? I'm inclined to close this and ask for an upstream issue to be created.

This is for sure a gradle-jruby-plugin problem. At least nothing we can solve from nokogiri, especially as the version of isorelax is not controlled by us.

Opened an issue there. Thanks for the support!

Thanks, all!


HSTS is enabled by default

Actual behaviour
When installing Miniflux and connecting via HTTPS, it sends this header:
Strict-Transport-Security: max-age=31536000
This prevents access via HTTP to Miniflux, but also to anything else on my domain.
Expected behaviour
This should be left up to the web server. There is no documentation stating this gets turned on by default, and can be unexpected.
Steps to reproduce

curl -I https://domain/miniflux/

Configuration

Miniflux version: master, 5d1c5697ce77deecac289928595052b1391eef35
Database type and version: SQLite 3.7.13
PHP version: 5.4.45-0+deb7u4
OS: Debian
Browser: Firefox

You can disable this HTTP header by changing the config parameter ENABLE_HSTS to false in your config.php.


Add Ace Cassidy's dotfiles

I've taken a lot of care in putting together my dotfiles (which can be easily installed with stow). I hope that you will consider adding my repo to your collection. Thank you.

Thanks for the contribution!


Optimize code style.

The ExchangeChannel will be used in a inner class.
Optimize it to final.

Codecov Report

Merging #2086 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2086      +/-   ##
============================================
- Coverage     53.12%   53.01%   -0.11%
+ Complexity     4959     4951       -8
============================================
  Files           559      559
  Lines         24894    24894
  Branches       4432     4432
============================================
- Hits          13225    13198      -27
- Misses         9650     9672      +22
- Partials       2019     2024       +5

Impacted Files
Coverage Δ
Complexity Δ

...exchange/support/header/HeaderExchangeHandler.java
30.15% <100%> (ø)
10 <0> (ø)
:arrow_down:

...onfig/spring/extension/SpringExtensionFactory.java
75% <0%> (-10.72%)
10% <0%> (ø)

...he/dubbo/remoting/transport/netty/NettyClient.java
72.88% <0%> (-10.17%)
12% <0%> (-1%)

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
41.66% <0%> (-8.34%)
3% <0%> (ø)

...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java
58.06% <0%> (-6.46%)
3% <0%> (ø)

...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java
51.89% <0%> (-3.8%)
11% <0%> (-2%)

...he/dubbo/remoting/transport/netty/NettyServer.java
67.85% <0%> (-3.58%)
8% <0%> (-1%)

...he/dubbo/registry/multicast/MulticastRegistry.java
56.06% <0%> (-1.68%)
38% <0%> (-3%)

...ache/dubbo/remoting/transport/mina/MinaClient.java
56.92% <0%> (-1.54%)
8% <0%> (-1%)

...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java
77.2% <0%> (-1.48%)
29% <0%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd68437...70db07f. Read the comment docs.

LGTM! Thanks for the pull request!


Device list ••• menu closes abruptly while trying to use it

This is on Safari 16 on macOS 12.6. The device list extends below the bounds of the browser window. When I use the ••• menu and try to delete an entry, the menu abruptly closes as I get close to the "Delete" menu item. I have to extend the window size to get it to work.

Reproduces in Chrome as well.

This was previously addressed by rolling back a react component


Policy location

I dont quite understand why the location of the policies is different, for example:
err_disabled_recovery resides under fabric_policies:
apic:
  fabric_policies:
    err_disabled_recovery:
      interval: 360
      mcp_loop: true
      ep_move: true
      bpdu_guard: true

and mcp resides under access_policies:
apic:
access_policies:
 mcp:
   action: false
   admin_state: true
   key: cisco
   frequency_sec: 5
   initial_delay: 300
   loop_detection: 5
   per_vlan: false

even though both have the same path in the gui:
Location in GUI: Fabric » Access Policies » Policies » Global » Error Disabled Recovery Policy

Location in GUI: Fabric » Access Policies » Policies » Global » MCP Instance Policy default

This was probably different in earlier versions of ACI.

Question answered.


Vulnerability: "request" dependency

I noticed that we're using the request dependency and after running a dependency checker it alarmed me about the fact that there is a vulnerability (medium severity) in the request dependency version that tmi.js is using.
More info here: https://snyk.io/vuln/npm:request:20160119
It's supposed to be fixed in version 2.68.0 or higher.
I don't think the library is really affected in a big way as the attacker needs to somehow control the body type of the request and most of the time the developer is in control himself, but still it might be wise to upgrade the dependency 😁

Correct, we are not affected but it still important to keep the dependencies updated, thank you :smile:

@Schmoopiie It might be worth looking into https://snyk.io for such vulnerability alerts in the future. Free for open source. 😄


Platform: add URL Monikers to the WinSDK overlay

Add a module definition for importing the URL Monikers interfaces.  This is in service of DocC.

@swift-ci please test


Mutli Version Data Load on the Same Record Load Date

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
What is a Multi-Version Load?
The typical load patterns in Data Vault assume periodic incremental loads. In every load job, the current state of the source data is compared with the newest version in the target satellite. If there are changes, a new version is loaded into the satellite table.
But there are situations where we need a different loading strategy. Example are:
Initial load of a new satellite with historical data from a historized source system, a Data Lake or a Persistent Staging Area (PSA)
Initial load of a complete Data Vault schema with historical data from a historized source system, a Data Lake or a Persistent Staging Area (PSA)
Reload of derived satellites in a Business Data Vault, e.g. when business rules were changed
Incremental loads of multiple versions in one batch, e.g. in combination with CDC (change data capture)
In all these cases, it is possible that multiple changes for the same business key must be loaded in one step. To explain the difference, let’s have a look at a very simple example: Once a day , the current beer inventory of a microbrewery is written to a satellite table. For an Instance the data is loaded from a PSA table into the satellite table in the Data Vault schema on a specific day having multiple versions. How to load this data into Satellite in any automated way.
Sample Data
PartID	Units	Source_record_date	Source_System
1	10	8/1/2023	Source A
1	11	8/1/2023	Source A
1	12	8/1/2023	Source A
1	13	8/1/2023	Source A
1	14	8/1/2023	Source A
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi! Thanks for taking the time to fill this out. Can you expand on what specific features you're looking for and how you image they should work?
If I understand correctly, what you're looking for is already supported by AutomateDV, dbt itself, or the Data Vault 2.0 standards that we follow and should all be possible within the existing functionality.

Closing as we believe this is now possible in v0.10.0 onwards. Please reopen if you believe this is not the case. Thanks!


append to existing table

What would be the preferred way to append a data.frame to an existing spark table.
I see that sparklyr depends on DBI > 0.4 which has dropped the append argument of dbWriteTable
This doesn't seem to work. Is there another way?
sc <- spark_connect(master = "local")
x <- Lahman::Batting
batting_tbl <- copy_to(sc, x, "batting", memory = FALSE, overwrite = TRUE)
dbWriteTable(sc, "batting", x, append = TRUE)
sqlAppendTable(sc, "batting", x, row.names = FALSE)

You should be able to use rbind for this currently:
batting_tbl <- copy_to(sc, x, "batting", memory = FALSE, overwrite = TRUE)
doubled <- rbind(batting_tbl, batting_tbl, name = "double")

We can also look into implementing a method for sqlAppendTable.

@jwijffels I believe Kevins suggestion addresses this, but feel free to reactivate if this is not sufficient.


webView: Improve hand shake mechanism with app.

Implement a two way hand shake. Send a ping from app to webView till a
ping is received from webView.
Refer #3080 for more details.
Fixes: #3080

Latest findings point to this likely being related to Chrome 70 and not likely to be Android 9
If so, that is even more urgent issue as the Chrome browser will update for most users in 1-2 weeks (I suspect they are doing some staged rollouts thus not everyone is getting the update immediately)

After testing the actual PR on an actual phone... :)
It seems to be working OK, but there is some weird delay when rendering the ChatScreen itself.

Thanks @jainkuniya for the diagnosis and fix, and @borisyankov for the reviews! This looks generally great, apart from some small edits I'll make. (I'll include Boris's latest suggested changes.)
Just one thing in the behavior: 100ms feels to me like a long time to wait -- it's a very noticeable amount of delay for a UI. Let's go for 30ms. (Still kind of a while, but on trying 10ms and playing with it, we have plenty of other delay involved. :-/ )

(Confirmed the length values with Chrome 70 and Chrome 61, as I had the latter lying around in an Android 8.1 virtual device.)

And merged -- thanks again!
I'm going to go make a release from this, and push it to beta after a quick smoketest -- I'd like it to go to prod before the end of today. This is a pretty killer issue for anyone with the Chrome 70 update, which I think may be over half of users now :open_mouth: -- glad to have it fixed :tada:


Chromium: link labels background incorrect sized when embedded in hidden iframe

Preflight Checklist

[x ] I agree to follow the Code of Conduct that this project adheres to.
[ x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
I embed my own drawio instance into another page with an iframe. When the style of this iframe is set to "diplay: none", so that it is not visible to the user, the rendered diagram has an error at the background for link labels (Not regular labels). The svg rect used for this is sized 2px by 1px, not the size of the text. So it is effectively no visible.
This is a problem, because I export this diagram to an svg via the JS messaging API and the same error is then in the exorted svg. The problem does not occur in firefox.
To Reproduce
Steps to reproduce the behavior:

Embed drawio with the url parameters 'offline=1&https=0&math=0&embed=1&proto=json&spin=0&stealth=1&chrome=0&drive=0' through an iframe into another website. Use 'style="display: none"' to hide it.
Load a diagram with labelled links with the JS messaging API
Use dev tools to inspect the content of the iframe. The rectangles belonging to the link labels will have width=2 and height=1. It will also be the same in the exported svg file (Also done with the JS API)

Expected behavior
At least in the exported file the sizing of the link label background rectangles should be according the the text size of the label.
Screenshots
If applicable, add screenshots to help explain your problem.
draw.io version (In the Help->About menu of the draw.io editor):

20.5.3

Desktop (please complete the following information):

OS: Linux and Windows 10
Browser: Windows: Edge, Chrome; Linux: Chromium
Version: Edge 108.0.1462.46, Chrome: 108.0.5359.125, Chromium: 108.0.5359.98

Additional context
A workaround for now is to hide the iframe with 'style="visibility: hidden; height: 0px; width: 0px"'

This is a known issue as we're using element.clientWidth to measure text. Try using visibility=hidden or width=0 instead of display=none.

Closing, workaround provided.


Document undocumented features of AsBindGroup derive

Objective

https://github.com/bevyengine/bevy/pull/5364 Added a few features to the AsBindGroup derive, but if you don't know they exist they aren't documented anywhere.

Solution

Document the new arguments in the doc block for the derive.

bors r+


v2.67.0

Is this how we create publish new versions to NPM?

It's not -- to publish check out the main branch locally, pull to get latest, run yarn run publish and then choose a minor version bump (we're not being good semver'ers right now, so mainly just doing minor bumps).

Doing the above will push up the right tags etc., and trigger https://github.com/alwaysmeticulous/meticulous-sdk/blob/main/.github/workflows/publish.yaml#L53

Thanks! Looks like it worked now


Upgrade react router and getting rid of redux

React router after v6 upgrades give a possibility to use routes and along with it there come other important features:

Relative  and
Nested Routes and Layouts
Object-based Routes
Suspense-ready Navigation
more...
Use of react routers remove the complexity of handling the navigation on the component level and makes the things go
smooth with a page wich go under multiple redirects like ours.

Also, the project was using multiple ways of storing data

Graphql client
React context
Redux
and was getting harder and harder to maintain the
state. And the scope of the app can be achieved
easily with react context and Graphql so we want
to get rid of redux in order to make a state
maintenance bit simpler.

It's also impossible to check all the details with such a large PR, but overall I think it's good refactoring and we have 500+ lines of code less now, which is always nice to see 👍


Read coverage cut-off for SV calling

Hi, may I know what is the default read coverage cut-off parameter for SV calling? And if I am able to adjust it?
Thanks
cy

Sorry for the late reply. Somehow I cannot receive email notification.
There is a k-mer cut-off, controlled by option '-k'. By default, it is 3. You can adjust that to reflect read coverage in a way.
Thanks,
Zechen


fix ulimit

recommended values https://www.mongodb.com/docs/manual/reference/ulimit/

As mentioned on the matrix channel, I tried this patch applied to the "5" track (the one that I'm running) and confirmed that /proc//limits shows 64000 for both the soft and the hard limits now - previously the hard limits were much higher, but not sure if that's really a concern - probably more of a concern that the soft limit was previously only 1024 I would guess.
I was wondering when we might expect something like this to roll out to the snaps so that we can update and see if it fixes our problems in production?

@MiaAltieri  it does not seem like it (from their respective docs) - those ulimits are usually relevant for the DB itself


Windows Launch on Startup Not Working

Windows 10
System Bridge v1.6.0 (planning to try v1.7.0 but don't think it will be any different)
When turning on auto launch in settings, the registry key is generated but the app isn't started at boot. I believe it is because of the UAC elevation system-bridge.exe needs for before executing.
This can be worked around by using Windows Task Scheduler to run the executable or using Windows service. I tried the latter by wrapping execution using WinSW but had no luck yet. The system-bridge.exe starts but terminates 5 seconds later. Might be because the service runs using Local System account but I have no logs other than this entry in Event Log: "Child process 'system-bridge (10996)' finished with code 0.". Task Scheduler method works OK. Attached is the auto run task exported to XML from Task Scheduler if it helps. Thanks for looking.
Autorun for SilentException.zip

having the same issue in 1.7.2

same here

same here


Update smoke.test.ts

This PR reproduces the error thrown in #112537 (cf #112713). It is intended to fail, with the error thrown Should never happen.

This PR is intended to be the control group of #113364, where only the corresponding test exists that should fail in integration tests.

Don’t know why, but the Should never happen error is only sometimes thrown when it should fail.

This came in via https://github.com/microsoft/vscode/pull/113364

This came in via https://github.com/microsoft/vscode/pull/113364


SEER model weights?

Hi,
Where can I find the latest SEER model weights? https://arxiv.org/abs/2103.01988
Thanks

Hi Rohit, thank you for reaching out. We will not release the model weights or images. :) closing this issue!


404 error message

I am getting 404 error message after entering URL http://localhost:3000/auth/github
initializer.rb
Rails.application.config.middleware.use OmniAuth::Builder do
  provider :github, ENV['GITHUB_CLIENT_ID'], ENV['GITHUB_CLIENT_SECRET']
end

routes.rb
get '/auth/:provider/callback', to: 'sessions#create'

GitHub configuration:
Homepage URL
http://localhost:3000
Authorization callback URL
http://localhost:3000/auth/github/callback

Nevermind, it appears that I had to wait like half a day for GitHub to start authorizing and responding to my requests after I registered a new app

👍


Update definition of NCEP Grids

MET's definitions of NCEP grids have become outdated.  The NCEP grids are currently defined in the file find_grid_by_name.h.

This task is to do the following:

(1) Rather than defining grids in the compiled code, consider reading them from a data file at runtime.  This is not required... just think about a better solution.

(2) Refer to grids defined here:

   http://www.nco.ncep.noaa.gov/pmb/docs/on388/tableb.html

(3) Rather than getting info from that website, consider the following method:

 - Run copygb to regrid data to these NCEP grids.

 - Use wgrib to dump the grid definitions.

 - Write a script to convert those grid definitions the formats used in find_grid_by_name.h.

(4) Add a new block of grid definitions for gaussian grids.

See attached script and output file for a starting point.
[MET-893] created by johnhg

Original JIRA attachment location:
https://sdg.rap.ucar.edu/jira/browse/MET-893?filter=12903
Remove .txt once this is downloaded.  github can't save .ksh extensions.
gen_ncep_grids.ksh.txt
NCEP_GRIDS.txt

As discussed on 11/04/2019, be sure to add grids 132, 227, and 148 (but check them all).

Began work on this issue on 02/10/2020.  I updated the gen_ncep_grids.ksh script to run copygb from UPPV4.0.1, figuring it'd have the most recent grid updates.  I found the following:
SKIP 28 UNSUPPORTED GRID DEFINITIONS:

SKIP G008: Not supported because the range of longitude is 363.104.
SKIP 18 thinned Lat/Lon grids that are not supported which result in a segfault in MET:
G021, G022, G023, G024, G025, G026, G037, G038, G039, G040, G041, G042, G043, G044, G061, G062, G063, G064
SKIP 9 Arakawa grids that are not supported in MET:
G083, G093, G094, G095, G096, G097, G099, G190, G192
+++++++++++++++++++++++++++++++++++++++++++++++++++++
ADD 51 NEW GRID DEFINITIONS
Add 22 Lat/Lon grid definitions:
G010, G011, G012, G013, G014, G015, G016, G017, G018, G150, G161, G174, G176, G180, G181, G182, G183, G235, G238, G239, G244, G253
Add 11 Polar Stereographic grid definitions:
G091, G092, G151, G160, G171, G172, G179, G189, G198, G219, G220
Add 11 Lambert Conformal grid deifinitions:
G132, G138, G139, G140, G147, G148, G184, G187, G188, G197, G200
Add 6 Gaussian grid definitions:
G098, G126, G127, G128, G129, G170
Add 1 Mercator grid definition:
G194

Added 51 NCEP grids that were missing.  Double-checked these additions by regridding using copygb and regrid_data_plane and then running pcp_combine to check that the grids match.


new Error: Permission Denied in line 1 or 4 of apps/cli

Hey I noticed a little while ago that the gh commands didn't find anything in Alfred and finally decided to investigate. I seem to be getting this strange new permission error.  Thanks for reporting. What version do you have installed? Can you retry installing it from here?

Fixed it, looks like I removed the packal updater workflow at some point. updating yours fixed it and added the updater one again so should keep it up to date. Thanks!!


[Feature] Files Pytest Conversion [OSF-8077]

Purpose
Conversion of API tests to Pytest
Increase in performance
Changes
Pytest conversion for all test files in Files folder
Grouping of tests for all test files in Files folder
Fix some styling issue
Side effects
Not Known
Ticket
https://openscience.atlassian.net/browse/OSF-8077

Closed, further detail can be found https://github.com/CenterForOpenScience/osf.io/pull/7348


fix(scripts): also check for package.json

when doing yarn build and git checkout for old versions
getPackages returns false positives, where the package folder exists, but package.json is missing

Out of curiosity, what's that folder with no package.json in it? I wonder why there's a "package" with no package.json

to reproduce
git clone https://github.com/facebook/jest
cd jest
yarn install
yarn build
git checkout 26.6.2
yarn build # throws "blabla no package.json"

the folders without package.json contain build/ folders created by the first yarn build


Show all flavors when using testport

Right now, tesport shows something like:
[00:00:02] Warning: Only testing first flavor 'php72', use 'bulk -t' to test all flavors

It would be nice if it said something more verbose like:
[00:00:02] Warning: Only testing first flavor 'php72' out of 'php56 php70 php71 php72', use 'bulk -t' to test all flavors

Oh, I did not know this was only printed if FLAVOR_DEFAULT_ALL was enabled. I think this warning should always be printed, this is testport, people need to be made aware that there are other flavors to test.


Project Completion QA Checklist: HPSI human cerebral organoids

Project UUID: 005d611a-14d5-4fbf-846e-571a1f874f70
Project Title: Assessing the relevance of organoids to model inter-individual variation
Project Short Name: HPSI human cerebral organoids
Submission UUID: fce97270-fce0-4744-8a4e-a93d95521852
Environment: Production

[ ] Process QA of bundles
[ ] Metadata tsv validation: Run metadatatsv_validator.py

Process QA found the following issue:

There is no collection protocol for the specimen.
There are 3 cell suspensions (that have been pooled from 12 organoids). However, there are 6 process_core.process_id (and therefore 6 bundles). Should there be 3 or 6 process_ids? This may require rebundling.

Is this the expected experimental graph?


implement copy constructor for Question

Maybe this isn't necessary, but it may be useful/necessary to get a seprate copy of a question. For example, if we want to create a question by copying another question and changing some parts (like the values used, or the thing being asked for).
Perhaps this could be implemented in a genaric way with the Assignment.Element class, or maybe it isn't nececssary and we can just use copy.copy.

This isn't necessary. copy.deepcopy works.


Z3 "incomplete quantifiers" error

On the qalpha branch, z3 raises an error when running
env RUST_LOG=info cargo run -- infer qalpha examples/fol/hybrid_reliable_broadcast_cisa.fly --quantifier "F node 1" --quantifier "E node 1" --qf-body pdnf --cubes 2 --cube-size 1 --non-unit 0 --smt
The error message is thread '<unnamed>' panicked at 'sat solver returned unknown: |(incomplete quantifiers)|', src/inference/basics.rs:160:45, and an example SMT file can be found here.
The same command appears to work when using cvc5, although this takes a long time to run.

This is probably due to the Z3 configuration. This example should work in mypyvy - can you figure out what options it's using (probably the SMT file is the easiest way)? I tried to check myself but I'm running into some issues with the python z3 bindings.


Dark mode on PopOS

Hello,
the wrapper is working great except the dark mode, the website is in light mode even though I have dark mode enabled in the OS Settings.

Hey, I managed to fix it by adding this line:
  if(nativeTheme.shouldUseDarkColors) nativeTheme.themeSource = 'dark';

You can check the pull request I made #8

Thanks! I was wondering why dark mode wasn't working for me lol. Also thanks for getting rid of the Open in iTunes button I didn't realize you could do that.


Have a pending, active and inactive status on Common Issues

This was meant for a different repo. Please remove.

Can you help me bug apps


Fix broken thumbnail images

[ ] Network diagram
[ ] Connecting lines border
[ ] Donut
[ ] Guage

Browser
No response
Description
It should have a transparent background like the others.
Steps to reproduce
See examples below.

[ ]

fixes.zip


Revert tasksmax workaround to avoid unsupported bins

This PR reverts PR #21628 and does no longer modify the git source tree for any OS until we come up with a better solution setting tasksmax differently for specific OS.
The modification of 21628 while building the binaries for each DEB package result in binaries with the "unsupported" tag if checked with docker --version or docker version.
- What I did
I compiled all DEB packages with make deb for v1.12.0-rc2 and found out that some OS have unsupported binaries. So I reverted that commit that introduced the code change.
- How I did it
git clone https://github.com/docker/docker
cd docker
git checkout v1.12.0-rc2
make deb

- How to verify it
You can reproduce this problem by installing eg. the 1.12.0-rc2 DEB package on eg. ubuntu:xenial or debian:stretch with curl -fsSL https://test.docker.com/ | sh.
+ sh -c docker version
Client:
 Version:      1.12.0-rc2
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   906eacd-unsupported
 Built:        Fri Jun 17 21:21:56 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0-rc2
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   906eacd-unsupported
 Built:        Fri Jun 17 21:21:56 2016
 OS/Arch:      linux/amd64

root@ubuntu-xenial:/home/ubuntu#

The same steps with a debian/jessie64 Vagrant box shows clean binaries.
- Description for the changelog
Revert tasksmax hack to avoid unsupported binaries in DEB packages.
- A picture of a cute animal (not mandatory but encouraged)

(mirrored image of 21628 :-) )
PS: You can't take a shortcut and remove some directories in the contrib/builder/deb/amd64 directory as this also leeds to a git code change and unsupported binaries.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "revert-tasksmax-workaround-21628" git@github.com:hypriot/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Tagging this as P1 since it effects release.
I agree we should revert.
Ping @tiborvass

I still wonder if the reason we removed the option was needed; IIRC it was only a warning that the option was not supported, but I wonder if it really affected running docker if the systemd version didn't know about that option

@thaJeztah -- Systemd doesn't handle the situation where there's an option it doesn't recognize, so docker won't start. It's probably best to revert and figure out a better approach (like the one @tianon suggested).

@StefanScherer nice hedgehog :purple_heart: and thanks for the deeper investigation. It's crazy that this doesn't affect all the rpm builds.

Thanks @clnperez, that's very unfortunate indeed. So, yes, I agree we should revert, but we need a different solution, as a lot of people get hit by the limit otherwise.

LGTM 🐸 then :wink:

Yes, package names look good, but the binaries inside have problems.
BTW: What about adding some tests testing the DEB packages in a Docker container like this docker version serverspec test? 👼
And probably running such tests in CI if a PR affects the make-deb/make-rpm build steps would also help.

@mlaventure I know you worked on some things for testing debs ^^

Uh, this shouldn't cause the build to be marked unsupported. The file being modified is generated by the `build-deb' script and as such shouldn't be part of the git repository.
LMTAL.

@StefanScherer can you open a separate issue for the CI suggestion? I like the idea, and think we can definitely improve in that area

ok, my bad, I read it wrong, we change the docker.service file inline.
LGTM (IANAM).
Quick question though, aren't all the systemd distros concerned? In which case, why aren't we commiting this change to contrib/init/systemd/docker.service once and for all?

@mlaventure Only distros using systemd versions after (including) 228. You can read docker/docker/pull/21297.

@thaJeztah Just recognized that there also is a make test-deb-install which is a good starting point for further tests. I'll open an issue with the suggestion.

LGTM

merging for now but lets find a better solution before GA (if possible)

@thaJeztah I'm looking into it since (although this area is not my expertise really, so it's been a lot of googling and manpage reading today!) Testing something out now...

Thanks so much @clnperez! I also asked @tianon to comment if he could come up with a solution.
Let me open a tracking issue for this, so that we don't forget

opened https://github.com/docker/docker/issues/24197


Enchantments, vines, particles 11a

Fixes #1084 as well
@SuperCoder7979 that level generator is left for you

@SuperCoder7979 seriously you need to read the code


Show inheritance in Documentation

List of Changes

In the reference manual, classes now display where they are inherited from.
#514 introduced some warnings during documentation build (due to a misformatted testoutput block). This is also fixed here.

Further Comments
The doctest in configuration.rst is currently not run as part of the pipeline... maybe we should enable this. (Which would require calling make doctest from the docs directory.)
Acknowledgement

[x] I have read the Contributing Guidelines

I agree we should show inheritance. However, what is the change that required updating configuration.rst?

make doctest from docs/ currently fails on master, this fixes it.
Compare the formatting of https://manimce.readthedocs.io/en/latest/tutorials/configuration.html to https://manimce--537.org.readthedocs.build/en/537/tutorials/configuration.html

TBH I kinda hate the way that configuration.rst looks like right now - when I made it it was just a lazy way of automatically documenting all the available flags, though we might want to do something better in the future. Thanks for fixing it for now tho.

TBH I kinda hate the way that configuration.rst looks like right now - when I made it it was just a lazy way of automatically documenting all the available flags, though we might want to do something better in the future. Thanks for fixing it for now tho.

Same here. Agreed. Do you maybe want to open an issue for it? Reformatting configuration.rst is a good "first issue"-issue. :-)

Looks good, thanks!
I just tried some inheritance links, very useful.
Still one question:
https://manimce--537.org.readthedocs.build/en/537/reference/manim.container.Container.html#manim.container.Container
It saies:
Bases: abc.ABC
Do we want to add to the Container docstring what abc means?

It kind of already does in that the first three words in the second sentence are precisely "Abstract base class".


Signals changes

Signals should be modified to be easily implemented into other components the library provides.
This includes scoreboards
val foo = signal("something")

scoreboard(!"&cTest Signal") {
    +!"&fValue: &e${foo()}"
}

val fooArg by stringArgument()
("setFoo" / fooArg).runs<Player> {
    foo setTo fooArg()
}

Additionally the RefreshBlock should be abstracted to be used in other components.
val ping by refresh { player.ping }

scoreboard(!"&fYour ping") {
    +!"&fPing: &7${ping}"
    +!"&cThis line won't update since we don't change"
}

By this I mean that the Signal class should not have a singular owner object, and should instead be available anywhere in the program.
When used in a block that implements the SignalListener interface, we should then mark this as a dependency for this Signal instance.
We also will need a way to remove these dependencies when they are no longer required otherwise we'll have a memory leak 😱


replace-promoted-replica-with-candidate: relocate replicas

Upon a 2-step recovery (a candidate replica is promoted on top of the immediate promoted replica), we also relocate-up the remaining replicas. Better illustrated below:
Assume
m
+- r1
+- r2
+- r3
+- cand

master crashes and the immediate suggestion is to promote r2:
r2
+- r1
+- r3
+- cand

but cand is found to be a candiate, that we promote it on top of r2:
cand
+ r2
   +- r1
   +- r3

thus far -- the existing logic in master branch.
This PR adds moving r1, r3 upwards, to replicate from cand, as follows:
cand
+ r1
+ r2
+ r3

The relocation of sub-replicas respects PostponedFunctionsContainer, and as such the operation may run asynchronously to the actual promotion of cand, and we can speed the availability of the writer while still rewiring the topology.

@shlomi-noach, I've tested that. I think it will work fine for the case you've described here.
But for my test it was not perfect still.
I had:
M1 -> R1
   -> Cand2
↕
M2 -> R2

In the middle:
M2 -> R1
   -> Cand2
   -> R2

At the end:
Cand2 -> R1
      -> M2
      -> R2

While the correct result will be:
Cand2 -> R1
      -> M2 -> R2

This can also happen in case of single master. When promoted most up-to-date replica has slaves behind it. At the end these slaves become slaves of Cand.

@pasha167 that would be too complex to implement for now, because it involves recording the list of replicas of any intermediate master in the topology prior to beginning the recovery, such that after the 2-step promotion we would extract all replicas of 1-step promoted server that were not on that original list.
I'm going to not work on that, and will leave some work to the human DBA who gets notified that a failover took place. The resulting topology before this PR is valid; it is valid with this PR; it would be valid if I were to implement your requested topology change. And while your request makes absolute sense, my experience suggests that some other user would want the opposite. Seeing that this would be overly complicated, I prefer to let it be.

Yes, I perfectly understand. If there is no easy way then, let's cancel this change.
Anyway thank you for trying.

let's cancel this change.

I'm not sure if you're referring to the the change in this Pr or the additional suggested one.
The change in this PR is good to go as far as I'm concerned and makes sense.

I was talking about this PR in general, thinking that changing the hierarchy of slaves may be dangerous.
For example in the following case:
m
+- r1
+- r2
      +- r3
+- cand

If r2 has local writes, then the moving r3 to cand is not good.
But thinking a bit more, I understand that in that case r2 should be filter out from promotion completely. So it is more responsibility of DBA to configure properly.
Yes, this PR is good.


Collation

Do you guys have any plans around an Intl.Collator equivalent? It has been punted on in the past. Most browsers have it already with Ecma 402, but not Safari for example.

We are open to include Collation support as a new module. Every help implementing it is very much appreciated. Useful links:

http://www.unicode.org/reports/tr35/tr35-collation.html#Contents
http://www.ecma-international.org/ecma-402/1.0/#sec-10
http://unicode.org/repos/cldr/trunk/common/collation/ --- Currently, the JSON bindings don't include collation. We may want to talk with Unicode folks to include it when we have a more clear picture of the implementation.


bug: slow explorer start

Overview
Explorer is currently being run with yarn serve at runtime. This takes some time to spinup but consumes alot of memory and cpu. Explorer pod can not be smaller than 1CPU and 2GB ram. Which is alot just for the CPU.
Proposal

Figure out a way to pass configs to the explorer at runtime, instead of building it everytime
Fork ping-pub and make the configs overrideable with environment variables

Maybe fix the ports for each of the chains. Then we can build the exposer before hand itself

Look into supporting other explorers as well: Big Dipper

Newer versions of ping-pub seems to be faster. Lets close this for now, and revisit when needed.


"ddev start" when webcache-enabled is already running corrupts permissions on container

Describe the bug

Assuming a UID > 65000
If you're working away on a project that has webcache_enabled: true and you run ddev start, the container does not get recreated, but the docker cp runs (with the high uid user's ownership). But the chown that should normally follow that doesn't happen. So you end up with unworkable permissions inside the container.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Version and configuration information (please complete the following information):

Host computer OS and Version: [e.g. Windows 10, macOS High Sierra]
Docker version information (use docker version) and insert it here.
ddev version information (use ddev version)
config.yaml contents for the misbehaving project
Do you have any custom configuration (nginx, php, mysql) in the .ddev folder? If so, have you tried without them?

Additional context
Add any other context about the problem here. Thanks!

Closing as webcache is now deprecated.


[SPARK-14412.2] [ML] rename *RDDStorageLevel to *StorageLevel in ml.ALS

What changes were proposed in this pull request?
As discussed in #12660, this PR renames

intermediateRDDStorageLevel -> intermediateStorageLevel
finalRDDStorageLevel -> finalStorageLevel

The argument name in ALS.train will be addressed in SPARK-15027.
How was this patch tested?
Existing unit tests.

Test build #57412 has started for PR 12803 at commit 55721c5.

Test build #57412 has finished for PR 12803 at commit 55721c5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57412/
Test FAILed.

Merged build finished. Test FAILed.

Test build #57419 has started for PR 12803 at commit 1bea557.

Thanks for this @mengxr - LGTM pending latest test run.

Test build #57419 has finished for PR 12803 at commit 1bea557.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57419/
Test PASSed.

Merged into master.


Thoughts for Presentation 2

1. Use of Continuous Integration (CI): describe how you have done it, which tools you have used, and what benefits you have experienced.
We're using githubs actions and workflows. We use a CI framework called GameCI for testing and building the project. We also run a linter called super linter provided by github.
2. Use of Pull Requests and Code Review: describe how you have done it, how it has helped you to improve the quality of the code, and how it has helped you to collaborate with your team members.
We started out all using different feature branches. This workflow quickly ran into integration and merging problems because of the unity project files being complex. We've since been striving to use shortlived branches and pullrequests in our development process. This has led to a general improvement in our development process and has especially made integration less of a problem.
4. Versioning, Releases and Continuous Delivery (CD): describe how you have done it, which tools you have used, and what benefits you have experienced. You should also describe how you have generated the release artifact using CI and how you have deployed it (if applicable).
5. Agile Methods: describe which techniques you have used and how they have helped you to manage your project.
6. DevOps: describe which practices you have used and how they have helped you to streamline your development process.
7. Automated Testing: describe which types of tests you have used (e.g., unit tests, integration tests, non-functional tests) and how they have increased your code coverage (or some other metric you prefer and can motivate).
8. Software Licensing: describe which license you have chosen and why you have chosen it. You should also describe whether you have made your project public or kept it private.

Introduce and demo the project.
Provide a brief description of the project
The technologies used
The scope of the project.


[Enhancement]: Drop use of fd

Current Implementation and Limitations
The current use of fd in the package.json is very redundant.
This command:
https://github.com/DouglasNeuroInformatics/DouglasDataCapturePlatform/blob/b5aa381d52f634d4fb880f042b5f090486b22c2a/package.json#L17C76-L17C76
"clean": "fd -H -I --prune \".turbo|dist|node_modules\" --exec rm -rf",
Is equivalent to
rm -rf .turbo dist node_modules
Associated Application Components
Client, Server
Proposed Solution
Use rm -rf .turbo dist node_modules
Estimated Difficulty
Low
Priority
Low

No it is not. This finds the directories in subdirectories (e.g., ./dist and `./api/dist).

This command needs to be properly documented.
What is it supposed to do.


Updates for intranet

Updated custom forms to use the appropriate email addresses for live, and a few other minor fixes.  Updated Gruntfile to copy tech-request-form.php to intranet/inc/dest, and replace imageweb-test with imageweb.  All of this is in prep for switchover from legacy Drupal-based intranet to new WP-based intranet.

Looks great on dev! Merging now that we're in the between-semesters downtime.


SignalR now uses System.Text.Json

Starting in 3.0, SignalR no longer defaults to using Newtonsoft.Json
https://docs.microsoft.com/en-us/aspnet/core/migration/22-to-30?view=aspnetcore-3.0&tabs=visual-studio#systemtextjson-is-the-default-protocol

⬆📅

@halter73  see my changes in #14958 and tell me what to change before I merge into this branch.

I was just about to add the "Switch to Newtonsoft.Json" section myself. Thanks for doing it. LGTM!

Should I merge?


Proof term breaks highlighting and indenting

Proofs of the form
Goal True.
Proof I.

confuse the highlighting and indenting because they expect a Qed.

See also https://github.com/coq/coq/pull/827#issuecomment-333349523


Release with polkadot-v1.7.0

I see that polkadot-v1.7.0 has been merged to master since a while now. Is it possible to get a crates.io release? We are switching from git deps to crates.io and this repo is the last thing remaining

Sorry for the delay. It is released.

Wow, this was quick, thanks for the swift action!