Stack translations missing

Affected Version of Concrete CMS
9.x
Description
Hi guys,
we noticed after updating from v8.5.7 to v9.0.2 and enabling multi-site for a multi-language page the stack translations gone missing in the dashboard overview /index.php/dashboard/blocks/stacks/view_details/.
Stack translation missing, selected de_DE in dropdown menu. But it should exist.

Good thing is, they are not actually lost.
They are only missing when accessing the view via the multi-site sub.domain.com/index.php/dashboard/blocks/stacks/view_details/.
When accessing the view via the primary-domain domain.com/index.php/dashboard/blocks/stacks/view_details/ it works.
Good, stack translation exists. Same pageID in URL.

So the problem is somehow related to the multi-site-tree / sitemap system pages I guess.
How to reproduce

Install v9.0.2 with domain domain.tld
Enable multi-language
Add two languages, de & en
Add a stack with custom content for each language
Enable multi-site
Add second site with subdomain sub.domain.tld
Try to edit existing translated stack via primary-domain. Works.
Try to edit existing translated stack via sub-domain. Does not work.

Possible Solution
Temporary workaround: Right now we force a redirect to the primary domain when a user tries to access the stack dashboard view.
Additional Context
No response

Additional Context
https://github.com/concrete5/concrete5/blob/4c7eaced0033dab833312d6ac083c89e46dc786b/concrete/controllers/single_page/dashboard/blocks/stacks.php#L76
$stackToEdit seems to be NULL when accessing the view via subdomain / multi-site domain.

This is actually a bit tricky, because Stacks themselves are not site-specific. That's why it says "Global" at the top of the page when you're viewing stacks.
Unfortunately, the locale list is derived from the currently active site. We could make it so you could switch sites at the top of the page, but that might be confusing because switching sites will actually do nothing to change the list of stacks in the page, it'll only change what locales show up as available in the multilingual stack variations list.
For the meantime, I recommend using the editing URL for the site whose localized stacks you want to work with, since that ensures you'll always see the locales you're looking for.

Okay, I see!
Maybe a solution could be to list all available languages of all sites in the dropdown for now?

I can see that the language is attached as part of the URL @en_EN, when selecting an dropdown option.
We could extend this and also attach the desired MultilingualSection.
This is perhaps the easiest way.
Although I think that the appended URL parameter is not the best solution. Better would probably be to use the correct StackPageID or similar.
I came up with this while finding out that the sitemap system-pages stack-listing shows all stacks.

Yeah that makes sense - that's probably the easiest way to deal with it for the time being.


Expand documentation for Entry data type

Took me longer than a second to recognize the utility of 'Entry' so I decided to extend its documentation a bit.

Thanks. I may just switch Heap to having the 2-argument form as the Entry case is vastly more common.

Good idea. If you really want a pure heap, you can just store () in it then.


[wip] fill in all the missing fields of status rpc

Fill in all the missing fields of Status() rpc for compatibility with Tendermint RPC.
Fixes https://github.com/celestiaorg/rollmint/issues/241

Codecov Report

Merging #599 (b51f37a) into main (7745ae8) will decrease coverage by 0.09%.
The diff coverage is 11.76%.

@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
- Coverage   55.75%   55.65%   -0.10%
==========================================
  Files          50       50
  Lines        9542     9576      +34
==========================================
+ Hits         5320     5330      +10
- Misses       3428     3452      +24
  Partials      794      794

Impacted Files
Coverage Δ

p2p/client.go
62.32% <0.00%> (-0.59%)
:arrow_down:

rpc/client/client.go
43.92% <0.00%> (-1.54%)
:arrow_down:

config/config.go
80.64% <62.50%> (-6.32%)
:arrow_down:

conv/config.go
50.00% <100.00%> (+2.94%)
:arrow_up:

block/manager.go
66.23% <0.00%> (+1.03%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sample output from the manual testing, queried using http://<IP_ADDRESS>:26657/status:
{
  "jsonrpc": "2.0",
  "result": {
    "node_info": {
      "protocol_version": {
        "p2p": "8",
        "block": "11",
        "app": "0"
      },
      "id": "12D3KooWQuDYj9sUzzfwAhtvuKZ2xh5aTAoAQNjEMpd7LkwZBop3",
      "listen_addr": "/ip4/<IP_ADDRESS>/tcp/26656",
      "network": "gm",
      "version": "0.4.0",
      "channels": "",
      "moniker": "Ganeshas-MacBook-Pro-2.local",
      "other": {
        "tx_index": "on",
        "rpc_address": "tcp://<IP_ADDRESS>:26657"
      }
    },
    "sync_info": {
      "latest_block_hash": "0000000000000000000000000000000000000000000000000000000000000000",
      "latest_app_hash": "0000000000000000000000000000000000000000000000000000000000000000",
      "latest_block_height": "34",
      "latest_block_time": "1970-01-01T00:00:01.668591409Z",
      "earliest_block_hash": "0000000000000000000000000000000000000000000000000000000000000000",
      "earliest_app_hash": "E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855",
      "earliest_block_height": "1",
      "earliest_block_time": "1970-01-01T00:00:01.668586886Z",
      "catching_up": true
    },
    "validator_info": {
      "address": "09B70D95B518CDDE51AD97E4F94DD12EEA673138",
      "pub_key": {
        "type": "tendermint/PubKeyEd25519",
        "value": "RLIM+4TzmjVX8X7W2RGhJgoVNvzQJGQfBd0fabIuIlg="
      },
      "voting_power": "100"
    }
  },
  "id": -1
}

Oh, and you should add a simple test to rpc/client/client_test.go, asserting that we're returning reasonable values.

@tzdybal added tests.


Connection problem Ile_de_france

Hello,
Unfortunately I can't connect with an ENT ile_de_france.
I have the following error.
parse_html     raise PronoteAPIError( pronotepy.exceptions.PronoteAPIError: Page html is different than expected. Be sure that pronote_url is the direct url to your pronote page.

Help if you please
`import pronotepy
from pronotepy.ent import ile_de_france
client = pronotepy.Client('https://0932783v.index-education.net/pronote/eleve.html',
username='',
password='',
ent=ile_de_france)
if client.logged_in:
print("log")
else:
print('no login')`

I use the ENT Ile de france every day and it works very well. But I can try to help you. Maybe your id or your password are wrong or maybe you're not using the right Pronote link.


Fix tests

Please provide description of the purpose of this pull request, as well as its
motivation and context.
Some tests are failing and they need to be fixed.
Set the juju channel to 2.9/stable.
Set a longer timeout in the tests.
How was the code tested?
Please describe the conditions under which the code has been tested.
Final checklist

[x] I am the author of these changes, or I have the rights to submit them.
[ ] I added the relevant changed to the README and/or documentation.
[x] I self reviewed my own code.
[ ] I updated the CHANGELOG according to the contributing
guide

+1


USER STORY: Enhanced auth flow

As a: User
I can: Stay logged into the app on a long term basis, without having to do any additional work after I initially grant permission.
So that: I don't have keep logging in.
Acceptance Criteria:

[ ] The app uses Spotify's Authorization Code with PKCE flow.
[ ] The app successfully uses the refresh token to obtain new auth tokens with no additional input from the user.

Service layer task


add elasticsearch creation as an option

pull request for issue #29

Thanks for this change. LGTM.
This work duplicates some recent (unmerged) work on the templates in #32 in which @hosungsmsft has been updating the conditional execution to use the logic expressions in ARM (which didn't exist when the original templates were written).
I'm merging this and @hosungsmsft will update his PR to accommodate these changes.

Hi @rgardler - the commit b358c71 was the latest commit for this pull request. Please make sure this commit is merged too.
Thanks.

It was merged: 2 parents f029f04 + b358c71 commit [f7fa6ebf7aa82f98959435f82a42015f58c30b04](https://github.com/Azure/Moodle/commit/f7fa6ebf7aa82f98959435f82a42015f58c30b04) which includes nested/{elastic.json → elastic1.json}
However, #32 which was an merged immediately afterwards replaced most of this with a different implementation which removed the need for the elastic0 and elastic1 files. Hence the current master brings the file back again in its original name.

Hello @CatalystAUInf - Thanks for your contribution again, and sorry to overwrite your PR almost immediately. @rgardler made me make O365 plugins optional in #32, and I made the elastic search optional as well, with ARM "command" that removes all the *config[01].json hack. It was concurrently/independently done by both of us, so hopefully you understand this quick overwrite. Thanks again for your contribution!

Hi @hosungsmsft and @rgardler - yes, it is all making sense now. Thank you for the update.


Make it possible to specify root path to load balanced service resolved from ZooKeeper

Hi,
We are integrating Spring Cloud Gateway with our own ZooKeeper-based service registry framework, so it can read load balanced service instances published by our existing services. Our framework supports publishing services running on a certain path on a host, e.g. "http://foo.com/example-service/", then on the client side, we only specify the request path relative to the root URI published in ZooKeeper.
I wrote an org.apache.curator.x.discovery.details.InstanceSerializer implementation to convert our service instance nodes on ZooKeeper to org.apache.curator.x.discovery.ServiceInstance<org.springframework.cloud.zookeeper.discovery.ZookeeperInstance> which can be picked up by the LoadBalancer in Spring Cloud Gateway, but no matter how I build the ServiceInstance, the path is ignored.
In other words, if I have a service instance published as "http://farmhost12345.foo.com:12345/path/to/foobar/service" in ZooKeeper under the service ID "foobar", I'd like to specify a gateway route to it as
builder.routes()
    .route("foobar", p -> p
            .path("/foobar/**")
            .filters(r -> r.rewritePath("/foobar/(?<remaining>.*)", "/${remaining}"))
            .uri("lb://foobar"))
    .build();

, but currently the second argument of the rewritePath() call has to be "/path/to/foobar/service/${remaining}" instead.
My proposed fix is to replace all uses of org.springframework.cloud.client.ServiceInstance#getHost() (and #getPort()) with #getUri() and use all components of the URI to construct the new one.
For Spring Cloud LoadBalancer this appears to only require a change in org.springframework.cloud.client.loadbalancer.LoadBalancerUriTools#doReconstructURI(ServiceInstance, URI). For Ribbon it looks more complicated, but if my information is correct, that is deprecated now, so perhaps it could be left alone.
In addition to this, the construction of org.springframework.cloud.zookeeper.discovery.ZookeeperServiceInstance from an org.apache.curator.x.discovery.ServiceInstance should be improved as well - when constructing the uri field from serviceInstance.buildUriSpec(), care should be taken that the serviceInstance actually specifies a sane UriSpec, and at that point the host and port fields become redundant and could be removed as they can be obtained from the uri. This would also fix the NullPointerException if the port in the Curator ServiceInstance is null (perhaps 0 should be returned from getPort() when it's unspecified).
I'd be happy to make a contribution of this if you agree with my proposed changes, or can propose a different set.
Thanks,
Gergely

This would be a solution for #1547 as well

We've never taken path into account via service discovery. You then have to assume support everywhere in spring cloud. That's something I'm not keen to add right now. There's a possibility to use metadata for that in a custom way. I think there's an open PR for that somewhere.

By supporting it everywhere in Spring Cloud, do you mean other service discovery providers?
Other than that, I'm not sure what other support would be needed - I think the path is an extension to the host:port, so if it's taken into account everywhere they are used, then it should just work.

Everywhere else in the portfolio where service discovery is used. It is not something I am willing to support right now.


Create Domain Entities and Repositories for work with that entities (13 Story Points).

Role, User and UserService done


[TACHYON-759] create a thread pool to handle master removeBlock command

https://tachyon.atlassian.net/browse/TACHYON-759

@zhljen Thanks for the patch, I left a few minor comments, also could you resolve the conflicts with master?

Made changes to address the comments..

@zhljen Thanks for fixing the format, one last comment

+1 LGTM

1 LGTM

+1 LGTM


MRG, FIX: More accurate and stable progress bar

Much smoother MB/s updates (by scaling the exponential filter coefficent to target a 1 sec time constant), speed verified by monitoring network activity with gnome system monitor. Now will say unknown instead of 100.0% when the file size is wacky.
You can test locally with (which will re-download 1.5GB):
python -uic "import mne; mne.datasets.sample.data_path(force_update=True, verbose=True)"

Closes #5948.

thx @larsoner


fix broken link in readme.md for membership.md

Currently, the link for membership.md is broken in readme.md
Anyone who thinks can solve this easily, please comment here.
The issue will be assigned to you!
PS : ONLY beginners can take this issue up

I'm getting starting with open source, I'd like to fix this issue

@deadbeatfour Would've loved to hand this issue over to you but it looks like you've already made some contributions here on Github.
You could perhaps take up other issues that we put up throughout this month. Let this stay for someone who's actually making their first contibution or something.

@rahulkumaran Of course. Cheers!

Can I ?

@rahulkumaran only beginners to this repo or github?

It'd be better for the members who are new to GitHub and are learning about Open Source to work on this issue.


[MS] FE2

The FE2 method needs to be implemented (@isaar/multiscale)

This needs to be closed. The only new feature that needs to be introduced to deal with heterogeneous materials is homogenization. FE2 is just using homogenization to analyze a structure.


JTCalendar problems with translation to swift 3

Translating the library JTCalendar to swift 3 i get 3 errors which i cannot seam to resolve. One is "Redundant conformance of 'Date' to protocol 'Comparable'". The second one is "Cannot convert value of type 'qos_class_t' to expected argument type 'DispatchQos.QosClass'". The third is "Binary operator '===' cannot be applied to two 'Date' operands"
Thanks

Translating the library JTCalendar to swift 3 i get 3 errors which i cannot seam to resolve. One is "Redundant conformance of 'Date' to protocol 'Comparable'". The second one is "Cannot convert value of type 'qos_class_t' to expected argument type 'DispatchQos.QosClass'". The third is "Binary operator '===' cannot be applied to two 'Date' operands"
Thanks

@thintank what version of This library are you using?
The version should be 6.1.0
?

Also, this is JTAppleCalendar not JTCalendar. possible wrong repository?

Yes, it's JTAppleCalendar, my mistake. The version should be automatically the latest installing the pods.

From what i know. I could be wrong

What do you have in your Podfile?
Paste it here

source 'https://github.com/CocoaPods/Specs.git'
pod 'JTAppleCalendar'
these are the two lines I added to the podfile, reguarding JTAppleCalendar

Can you try ?
pod 'JTAppleCalendar', '~> 6.1'

then do a pod install and tell me what happens

If you are still getting errors. Then delete the JTAppleCalendar pod folder.
and reinstall

ok thank you i'll try that now

if it works, you owe me a github star rating for being up at 3:12 AM helping ya 😁

Ah ah ah ah ah ah I'm in Italy and here it's a more resonable noon

ok well let me know how it goes. Im heading to sleep.
laters man.

will do! thanks

so umm... did it work?

Still working on it. Somehow the pods got all messed up and I'm working on updating the cocoapod repo

cool.

ok it seems to be working now. i have to implement it correctly and if i have any problems i'll let you know. thank you so much


Test Data defined in a parent class is not visible in child classes when using DynamicData

Description
When attempting to use the [DynamicData] attribute, in a derived class, properties and methods in the parent class are not visible to tests. They are reported as null at test run time.
Steps to reproduce
Create a test class that inherits from any parent class. In the parent class, include some test data. In the child class, attempt to use that test data in a [DynamicData] attribute. The test will fail, as the test data will be null. I've attached a test project that demonstrates this behavior.
Expected behavior
Test data defined in a parent class can be used in child classes.
Actual behavior
Tests fail, and the test data appears as null at test run time.
Environment
Windows 10, April 2018 update, using Visual Studio 2017 15.7.2, and MSTest TestAdapter 1.2.1, and MSTest TestFramework 1.2.1.
Sample project that demonstrates this: https://github.com/Microsoft/testfx/files/2053285/ExampleDynamicDataTest.zip

@pingzing : In case, the property or method exists in a class other than the test class, an additional Type argument should be passed to DynamicData constructor. Refer this RFC : https://github.com/Microsoft/testfx-docs/blob/master/RFCs/006-DynamicData-Attribute.md
So, if you modify your DynamicDataAttribute like below, things should just work fine for you :

 [DataTestMethod]
 [DynamicData(nameof(ParentTestData), typeof(ParentClass))]
 public void TestParentTestData(int first, int second, int third)
 {
      Assert.AreEqual(third, first + second);
 }

A-ha! Didn't spot that in the intellisense, and various bits of Googling didn't bring it up. Thanks!

@pingzing : Glad to hear this helped.
Closing the issue on our end. Please feel free to re-open if you hit any more blockers.


Enable rubberband library

Would you be so kind to make builds with rubberband enabled, please?

You mean https://breakfastquay.com/rubberband/ ?
That library appears to have quite a few dependencies, so adding it is far from trivial.
I'll see if I find time for it, but no promises.

Yes, thank you. Other, weekly only win builds from gyan.dev contain this, so you might get some inspiration from here as well: https://www.gyan.dev/ffmpeg/builds/
Also, official documentation has some hints: http://ffmpeg.org/ffmpeg-all.html#rubberband

It's that librubberband depends on libsamplerate and fftw3 at the very least.
So I'll have to package those as well and make sure they find each other properly while linking fully statically.


Adds screenshots to examples

Rendered version:
https://github.com/mahulst/belly/blob/main/examples/README.md
fixes #36

Pardon the editor settings, I needed a few retries to get the paths for the images correct.
All you mentioned is fixed, let me know if there's anything else.


TypeError: The compressed data passed is corrupted

On DigitalOcean Ubuntu  VPS with node v14.6.0
when I use play attention
TypeError: The compressed data passed is corrupted
at Decoder._decode (/home/ubuntu/discord-bot/node_modules/prism-media/src/opus/Opus.js:64:25)
at Decoder._transform (/home/ubuntu/discord-bot/node_modules/prism-media/src/opus/Opus.js:204:22)
at Decoder.Transform._read (_stream_transform.js:205:10)
at Decoder.Transform._write (_stream_transform.js:193:12)
at writeOrBuffer (_stream_writable.js:352:12)
at Decoder.Writable.write (_stream_writable.js:303:10)
at PassThrough.ondata (_stream_readable.js:713:22)
at PassThrough.emit (events.js:314:20)
at PassThrough.EventEmitter.emit (domain.js:486:12)
at addChunk (_stream_readable.js:303:12)
at readableAddChunk (_stream_readable.js:279:9)
at PassThrough.Readable.push (_stream_readable.js:218:10)
at PassThrough.Transform.push (_stream_transform.js:166:32)
at PassThrough.afterTransform (_stream_transform.js:101:10)
at PassThrough._transform (_stream_passthrough.js:46:3)
at PassThrough.Transform._read (_stream_transform.js:205:10)
at PassThrough.Transform._write (_stream_transform.js:193:12)
at writeOrBuffer (_stream_writable.js:352:12)
at PassThrough.Writable.write (_stream_writable.js:303:10)
at PassThrough.ondata (_stream_readable.js:713:22)
at PassThrough.emit (events.js:326:22)
at PassThrough.EventEmitter.emit (domain.js:486:12)
at addChunk (_stream_readable.js:303:12)
at readableAddChunk (_stream_readable.js:279:9)
at PassThrough.Readable.push (_stream_readable.js:218:10)
at PassThrough.Transform.push (_stream_transform.js:166:32)
at PassThrough.afterTransform (_stream_transform.js:101:10)
at PassThrough._transform (_stream_passthrough.js:46:3)
at PassThrough.Transform._read (_stream_transform.js:205:10)
at PassThrough.Transform._write (_stream_transform.js:193:12)
at writeOrBuffer (_stream_writable.js:352:12)
at PassThrough.Writable.write (_stream_writable.js:303:10)
at IncomingMessage.ondata (_stream_readable.js:713:22)
at IncomingMessage.emit (events.js:326:22)
at IncomingMessage.EventEmitter.emit (domain.js:486:12)
at addChunk (_stream_readable.js:303:12)
at readableAddChunk (_stream_readable.js:279:9)
at IncomingMessage.Readable.push (_stream_readable.js:218:10)
at HTTPParser.parserOnBody (_http_common.js:132:24)
at TLSSocket.socketOnData (_http_client.js:509:22)
at TLSSocket.emit (events.js:314:20)
at TLSSocket.EventEmitter.emit (domain.js:486:12)
at addChunk (_stream_readable.js:303:12)
at readableAddChunk (_stream_readable.js:279:9)
at TLSSocket.Readable.push (_stream_readable.js:218:10)
at TLSWrap.onStreamRead (internal/stream_base_commons.js:188:23)

you can try updating the packages (ytdl-core, dsicord.js, @discordjs/opus, etc)
it will be fixed in next update (98% stuff is going to get fixed in update)

yes I have the latest versions of these packages

Any idea when the new update is coming out?

its going to take alot of time and not sure


amdvlk does not work with DXVK

I wanted to test the performance of amdvlk with multiple games, so I installed it, as I knew it was supposedly able to live with RADV and able to be called with VK_ICD_FILENAMES=/usr/share/vulkan/icd.d/amd_icd64.json. I tried to test it out, and it seems no game will launch with it. Doom using Proton (Steam and GE/Tk-Glitch builds) doesn't launch, no information why, even when running in a terminal. So I tried out launching my Titanfall 2 instance of Origin with VK_ICD_FILENAMES=/usr/share/vulkan/icd.d/amd_icd64.json, and I get this:
info:  Required Vulkan extension VK_KHR_get_physical_device_properties2 not supported
info:  Required Vulkan extension VK_KHR_surface not supported

I know under common issues that that seems to be an issue with conflicting drivers with dedicated and integrated gpus, however I don't have an integrated GPU, just the RX 580. I also have seen someone suggest not having the icd loaders installed. I have vulkan-icd-loader and lib32-vulkan-icd-loader installed already. I was running mesa-aco-git from the valveaur repo, so I uninstalled it and installed all the individual components having it removes. Namely lib32-libva-mesa-driver lib32-vulkan-radeon lib32-mesa lib32-mesa-vdpau libva-mesa-driver mesa mesa-vdpau opencl-mesa vulkan-mesa-layer vulkan-radeon. My graphics card should absolutely be supported, and i checked to make sure that the amd_icd64.json and amd_icd32.json files were indeed in /usr/share/vulkan/icd.d, and they are. Every resource I've been able to find says that my card should be supported, I can have amdvlk and radv both and just dictate when I want to use amdvlk, and that it works with dxvk. However I can't get a single thing to even launch with it.
At this point it seems to be either a bug with amdvlk or dxvk, and I don't know if this helps any, but when I tried to change amd_icd64.json to radeon_icd64.json, I still get the exact same logs with the exact same error. So that would suggest it's something about setting the environment variable, right? I've seen people say to do it with and without quotes around the path to the file, I tried both. And of course when i don't dictate anything, it loads radv and everything works fine. I've tried this with dxvk versions 1.4.5, 1.4.6, 1.5, and a custom aur build of dxvk with the async patch, dxvk-mingw. With 1.4.5 and 1.4.6 Origin will still launch, but I still get all the same errors, plus the DxvkInstance: Failed to create instance errors, so obviously the games itself still won't work. With 1.5 and up it doesn't launch at all.
System information

GPU: XFX GTS XXX RX 580 4GB
Driver:Mesa 19.3 and Mesa-aco-git 20.0
Wine version: lutris-nofshack-4.19, proton-tkg-5.0, proton-GE-4.20, tkg-protonified-3.21, staging 4.21
DXVK version: 1.4.5, 1.4.6, 1.5

Origin_d3d9.log
Origin_d3d11.log
Origin_dxgi.log

This is not a bug, and DOOM uses Vulkan directly so this clearly isn't the right place to report this.
Anyway, if you set VK_ICD_FILENAMES=/usr/share/vulkan/icd.d/amd_icd64.json, then you can only launch 64-bit applications since this is a 64-bit driver. Origin is a 32-bit app, so you additionally need to specify a path to a 32-bit driver (this could be RADV):
VK_ICD_FILENAMES=/usr/share/vulkan/icd.d/amd_icd64.json:/usr/share/vulkan/icd.d/radeon_icd.i686.json

Yes, thank you. I had tried it with some other games too, but they all ran Origin (I forgot about Doom being native vulkan, it's been a long night). I had tried to do exactly what you suggested, BUT I had used a comma instead of a colon. I just tried it with a colon, and Origin did start, however my card was still reported in the logs as AMD RADV POLARIS10, but I'm not sure if that means anything. I couldn't see anything on Resident Evil 2, by the time I got it to launch with any dxvk hud at all, I only had it set to 1, and it didn't show whether it was amdvlk or radv, and the next time I tried to boot, stupid drm told me I'd logged on from too many computers so now I have to wait until tomorrow. But it somewhat appears to be working, aside from still reporting the card as AMD RADV

If it reports cards as RADV then you're still using RADV.

I figured it out. I tested it out with a non-dxvk/windows application, I ran ./Geekbench-5.0.4-Linux/geekbench5 --compute-list, which shows available rendering devices, both with the environment variable and without, and I got two different results (strangely enough when I run it without the variable, it lists 3 devices under Vulkan, AMD Radeon RX 580, RADV POLARIS10, and then AMD RADEON RX 580 again, but I think geekbench is just buggy with that). I went back into Lutris and changed the line you suggested, specifying both 32 and 64 bit, but made the second one amd_icd32.json. Now in Lutris where it used to say RADV, it now says AMD RX 580. I imagine if I had actually launched the game before, since it is a 64 bit game, it would have reported the RADV for Origin and the RX 580 for the actual game in the logs, but I'm not sure. Thanks for your help, I wouldn't have figured it out otherwise, every single thing I could find just said to export the one variable. I'll close this issue.


Added Unit Test for MapStateRepository

Fixes #2526

40% -> 58% Code Coverage

@sufyanAbbasi @shobhitagarwal1612  PTAL?
Should we write test for the delegate property as well? I think the variables setter and getter are already tested and the remaining can be skip, but would like to know your thoughts on this.

/gcbrun

Should we write test for the delegate property as well?  I think the variables setter and getter are already tested and the remaining can be skip

I think your analysis is correct here, we don't need to unit test those since they are Kotlin features we can assume to just work.
Thank you so much!

/gcbrun

@anandwana001 Can you please ensure that the checks are passing locally as well?
* What went wrong:
Execution failed for task ':workspace:ground:ktfmtCheckTest'.
> [ktfmt] Found 1 files that are not properly formatted:
  src/test/java/com/google/android/ground/repository/MapStateRepositoryTest.kt

/gcbrun

/gcbrun

Passing locally, running again now

/gcbrun


change to some headers

I updated to have headers but its not finished

im doing the merging of my own pull


New Node: Connection

Sub-type of Node

Semantics:

Intra/inter application to application relationship

This issue was moved to CoastalHacking/semiotics-main#13


hitnet problem of dilated convolution

The author of hitnet used dilated convolution in the last three propagations of the paper, but the model you provided did not use dilated convolution. Why? Is it because this works better ?

Can you clarify this statement? The exported models match the architecture defined in the paper and do contain dilated convolutions.


use em instead of pt

@rultor release, tag is 0.9.2

@rultor release, tag is 0.9.2

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.9.2

@yegor256 Done! FYI, the full log is here (took me 8min)


Add support for CJS imports

See issue: https://github.com/planetscale/database-js/issues/100
Specifically, my comment here: https://github.com/planetscale/database-js/issues/100#issuecomment-1627750733
For many typescript users, especially those using ts-node in their environment, a CJS export of this package would be a huge improvement to the DX.
Here is a great article from a maintainer who solved the same problem within his package (supporting both ESM and CJS since most users are still using CJS). He includes specifics of how to implement this setup: https://evertpot.com/universal-commonjs-esm-typescript-packages/
TLDR: Within package.json, you can specify both a CJS export and an ESM export so that users automatically get the right version of this library for their environment when they import it.
E.g.
{
  "type": "module",
  "exports": {
    "require": "./cjs/index.js",
    "import": "./esm/index.js"
  },
  "main": "cjs/index.js"
}

When specifying your package.json this way, Node will automatically load the correct (cjs/esm) directory depending on what the user needs. This all happens automatically. Neat!

Created PR #123

for the love of god yes. Im categorically blocked with my app until this is sorted. I have a barely instantiated nrwl/nx monorepo with a nestjs application and a nodejs library that builds a drizzle schema and exports a planetscale connection. Everything i do to fix it leads back to this ->
F:\...\product-suite\node_modules\.pnpm\@nx+js@16.5.2_@swc-node+register@1.4.2_@swc+core@1.3.69_nx@16.5.2_typescript@5.1.6\node_modules\@nx\js\src\executors\node\node-with-require-overrides.js:18
        return originalLoader.apply(this, arguments);
                              ^
Error [ERR_REQUIRE_ESM]: require() of ES Module F:\...\product-suite\node_modules\.pnpm\@planetscale+database<EMAIL_ADDRESS>from F:\...\haven-world-tours\product-suite\dist\apps\web-server\main.js not supported.
Instead change the require of index.js in F:\client-projects\haven-world-tours\product-suite\dist\apps\web-server\main.js to a dynamic import() which is available in all CommonJS modules.

@binaryartifex For now, the temporary solution I'm using is to build the package locally and store it in my codebase. You can do the same by cloning this fork (https://github.com/miketromba/database-js-cjs/tree/main) and running npm install && npm build Then, grab the built dist folder, rename it to e.g. planetscale-database-js, add it to your codebase, and import the library from there.

Hey y'all! Sorry for the delay in replying to this one. I'm hoping to get some time this week to review and come to a decision on CommonJS.
For my own understanding, what's preventing the use of ESM in certain projects? Looking at ts-node, I see they have support (although it's marked as experimental) for ESM modules, so I don't know why our driver won't work as-is today. I would love some additional context here about how it's being used to better understand, thanks!

@miketromba is there any reason why #123 came to a grinding halt? seems like a no brainer merge?

so are we merging #123? i think there's plenty enough argument to support it

Hey y'all, as a heads up, a new release has been cut!


Instructions to target previous version break the extension

These instructions on how to modify a Visual Studio 2022 extension so that it can target an earlier version actually break the extension. After completing these instructions the extension can no longer be installed for Visual Studio 2022.
The article makes no mention on this, nor of how to handle this.
This repo contains a trival extension that if the instructions are followed will no longer install for VS2022.
https://github.com/Neutrino-Sunset/HideOutliningMargin

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 012a4f35-f086-feac-46bf-db42e743d2d7
Version Independent ID: ef5795f5-d5ba-50fa-af9a-f46d6a37af94
Content: Target Visual Studio 2019 when creating an extension in Visual Studio 2022 - Visual Studio (Windows)
Content Source: docs/extensibility/migration/target-previous-versions.md
Product: visual-studio-windows
Technology: vs-ide-sdk
GitHub Login: @leslierichardson95
Microsoft Alias: lerich

@Neutrino-Sunset -- Neutrino, thank you for your feedback.  Please consider these resources:

Visual Studio on Microsoft Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

@leslierichardson95 -- Leslie, please look into this issue.


Add a with_simple_protocol_upgrade alternative to with_upgrade

Simplifies the echo dialer and listener, and will probably also be useful later when Kademlia is implemented.
(Note: I suggest to merge the other PRs first, because they conflict with this one and are more important)

Can we implement ConnectionUpgrade for (B, F) where B: Into<Bytes>, F: FnOnce(Self::RawConn) -> impl Future<...>?


Feature Request: Field Types

This library strips out any meta information you add to a field using the add method.
This biggest downfall with this is you can't replicate the key value pairs found in the apple specification for;

Date Style Keys
Number Style Keys

Example
  pass.auxiliaryFields.add({
          key: "claim_expiryDate",
          label: "Expires",
          value: moment(offer.claim.expiryDate),
          dateStyle: 'PKDateStyleMedium'
        });

Implemented in version 6.0 released today.


Tomorrow Working on project

Since we all going to be working on project I vote we order pizza so we arent hungry.

agreed


Subdomain routing

Its possible subdomain routing using next-routes ?

Yes.

Can you give me tutorial or any reference to implement that ?


Content change - wording of important message on declaration page

Changed: 'The number of scheme members has changed and is now over 100' to 'The number of scheme members has changed and is now 99 or more'

replaced with other PR


classification using facenet

I've tried to read your code. but I didn't get how you can classify an image.
Consider that you want to classify one image with this network. is there any simple way to feed the network with that picture and retrieve the class of that image?

When the network is trained with the triplet loss loss function it is easy to compare two images and tell if the images are of the same person or not. The performance can then be evaluated on the LFW dataset which can be of classes that is previously unseen.
But if you want to do image classification this is not as straight forward. The best way is to replace the top layer of the model (i.e. the linear mapping to the 128-dimensional embedding) with a linear mapping to a vector with the same dimension as there are classes, and then calculate a loss using soft max.
I have recently started to work on this, mainly in order to get better filters, but it is far(!) from finished. But you can have a look at it on the branch classifier_pretrain. The facenet_train module can be found here.
The code seems to be running and learning something but that's all i can say...


Issue with Opening New Pages in Version 18.4.0

Hi Team,
We encountered an issue when attempting to open a new page. It appears to be non-functional in version 18.4.0, whereas it operates correctly in version 18.3.0. Do you have any insights into this problem? Thanks.

After upgrading the Pythons package, did you also run the rfbrowser clean-node and rfbrowser init commands to update the node dependencies?

Hi @aaltat,
Yes, I added the rfbrowser clean-node and rfbrowser init commands before running the test, but it still failed when attempting to open a new page.
By the way, I'm using GitHub Actions for robot testing. I believe it's a completely new container without any cache issues.
Thank you!

Hi @aaltat
I cannot display rfbrowser's version using --version or --verison commands, but the version should be the latest one, 18.4.0. Also, here is the debug log of playwright: playwright-log.txt. Please kindly review it. Thank you.

Basically log is telling that page doesn’t load in 10 seconds:
at async PlaywrightServer.newPage (/usr/local/lib/python3.10/dist-packages/Browser/wrapper/index.js:10708:28) {
  name: 'TimeoutError'

Why the page doesn’t open is not revealed from the log and is an matter where I can’t help because I am not unfamiliar with your environment.
The code in Browser library which controls opening pages has not changed between 18.3 and 18.4 releases. What has changed is the Playwright version, from 1.42.1 to 1.43.1 and with that the browser binaries have also been updated by Playwright, more details in https://playwright.dev/docs/release-notes I would guess that this might be reason for your problems.

Closing because we in the Browser library are not able to fix this problem.


Is @agm/core still maintained?

Issue description
I´m currently working on two Angular projects (first v9, second v10) both require Google-APIs for Places as well as Maps.
When updating a project to Angular 9 or Angular 10 I get following error:
Package "@agm/core" has an incompatible peer dependency to "@angular/core" (requires "^6.0.0 || ^7.0.0 || ^8.0.0" (extended), would install "10.0.0").
Since the "Getting Started" page also seems to be down for some time now, I wanted to make sure I´m not building upon an unmaintained package. Don´t want to be rude, I know how much time it takes to keep a repo updated, but it is important for me nevertheless.
Steps to reproduce and a minimal demo of the problem
npm install @agm/core
ng update @angular/cli @angular/core
Current behavior
Package "@agm/core" has an incompatible peer dependency to "@angular/core" (requires "^6.0.0 || ^7.0.0 || ^8.0.0" (extended), would install "10.0.0").
Expected/desired behavior
Packages install without errors and warnings

+1

+1

Hi,
There is a PR waiting for a code review to solve this problem ( #1830  )

That´s true, but the Google-Maps Component from Angular only provides support for Maps, but not for Routes and Places as far as I can tell. So there is still a fairly big demand for packages like this one.

And if you force install it anyway, it does not work on Angular 10.

Yea, there is a problem finding active maintainers. I am planning to at least publish an NG-9/10 compatible version.

I started looking into the one from Google but (at least at a first glance) it looks like it can not be compared to agm. You have to edit the index.html to load the api, I want to load different keys for different environments.
Hope agm continues to be developed. Any timeplan for angular 10 compatibility?

@semla #1833

@semla you can actually use the implementation described here https://github.com/angular/components/blob/master/src/google-maps/README.md
tl;dr
you can actually have different keys for diff envs using google's own implementation
constructor(httpClient: HttpClient) {
this.apiLoaded = httpClient.jsonp('https://maps.googleapis.com/maps/api/js?key=YOUR_KEY_HERE', 'callback')
.pipe(
map(() => true),
catchError(() => of(false)),
);
}
You'll have to add "HttpClientJsonpModule" to your imports.


Correction for raw affiliation Laboratoire des technologies innovantes - UR UPJV 3899

Correction needed for raw affiliation Laboratoire des technologies innovantes - UR UPJV 3899
raw_affiliation_name: Laboratoire des technologies innovantes - UR UPJV 3899
new_rors: 01gyxrk03
previous_rors: 012hpz460
works_examples: W4388883785;W4387722505
contact: cf694ad7c3938328039ee7c7da0c56e2:30ff93ccdd096bf69413fac07f348662 @ u-picardie.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


Proper null handling in SELECT, ORDER BY, DISTINCT, and GROUP BY

Proper NULL handling in:

SELECT with and without ORDER BY
DISTINCT
GROUP BY
DISTINCT

For Single-valued columns of all data types with:

Raw encoding
Dictionary encoding

Unit tests:
Updated BigDecimalQueriesTest to work with null values.
Added BooleanNullEnabledNoDictQueriesTest.
Added AllNullQueriesTest where all values are null.
Added NullEnabledQueriesTest where some values are nulls.

Codecov Report

Merging #8927 (574f6f0) into master (09fcdd5) will increase coverage by 37.63%.
The diff coverage is 84.58%.

@@              Coverage Diff              @@
##             master    #8927       +/-   ##
=============================================
+ Coverage     28.81%   66.45%   +37.63%
- Complexity       47     4691     +4644
=============================================
  Files          1801     1360      -441
  Lines         94168    69062    -25106
  Branches      14078    10906     -3172
=============================================
+ Hits          27138    45895    +18757
+ Misses        64479    19846    -44633
- Partials       2551     3321      +770

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
66.45% <84.58%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../java/org/apache/pinot/common/utils/DataTable.java
95.12% <ø> (ø)

...ator/transform/function/BaseTransformFunction.java
41.01% <0.00%> (+30.62%)
:arrow_up:

...r/transform/function/LiteralTransformFunction.java
68.26% <0.00%> (+31.37%)
:arrow_up:

.../transform/function/MapValueTransformFunction.java
0.00% <0.00%> (-85.30%)
:arrow_down:

...e/pinot/core/query/reduce/RowBasedBlockValSet.java
15.94% <0.00%> (+15.94%)
:arrow_up:

...main/java/org/apache/pinot/spi/data/FieldSpec.java
82.52% <ø> (+82.52%)
:arrow_up:

.../raw/RawBytesSingleColumnDistinctOnlyExecutor.java
69.23% <33.33%> (+69.23%)
:arrow_up:

...w/RawBytesSingleColumnDistinctOrderByExecutor.java
79.16% <33.33%> (+79.16%)
:arrow_up:

.../RawStringSingleColumnDistinctOrderByExecutor.java
70.96% <33.33%> (+70.96%)
:arrow_up:

...t/core/query/distinct/DistinctExecutorFactory.java
87.35% <40.00%> (+33.78%)
:arrow_up:

... and 1621 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09fcdd5...574f6f0. Read the comment docs.

Related to #8697


Add: CTS

Channel Name
CTS
Alternative Names (optional)
No response
Network (optional)
No response
Owners (optional)
No response
Country
KR
Subdivision (optional)
No response
City (optional)
Mokdong
Broadcast Area
c/KR;c/US
Languages
kor
Categories (optional)
religious
NSFW
FALSE
Launched (optional)
1995-12-01
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://cts.tv/
Logo
https://photos.live-tv-channels.org/tv-logo/kr-cts.jpg
Notes
No response

Already in the database: https://iptv-org.github.io/channel?id=CTSTV.kr


[cinder-csi-plugin] custom StorageClass in Helm Chart

What this PR does / why we need it:
The pre-defined StorageClasses won't fit for every use case. Give the user the possibility to define their own StorageClasses or VolumeSnapShotClass
Which issue this PR fixes(if applicable):
none
Special notes for reviewers:
none
Release note:
[cinder-csi-plugin] Custom StorageClass in Helm Chart

/ok-to-test

guess this change don't need relesae notes.

@eumel8 you still would need to bump chart version , lint charts seem to fail

Maybe you did an incorrect rebase, which caused your commits contain many others from the master.

@lingxiankong Yes, this rebase was completly wrong, sorry. Hopefuly push --force is doing the right thing now

@eumel8 Thanks.
/lgtm

/approve


[Mobile] Feed | Create post "+" button is too small

Device/OS/Browser/Env: OnePlus 7 Pro / OS10 / Chrome 83 / Staging
Steps to Reproduce:

Log in and go to "Help Board"

This is a duplicate of #1107, and it is not MVP - Critical. Please add more info to the mentioned issue. Thanks.


Improve coordinate system choice for 2-layer case

Enable to provide +np.infty
Expand coordinate-system example

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 4 (75.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 99.9%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

empymod/utils.py
3
4
75.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
2985

Relevant Lines:
2988

💛  - Coveralls


new changes in shwetaagrahari

I am doing this for learning open source

I am doing this for learning open source


Problem with installation

Hi
I filled out the form on Astra-sim's website to join the mailing list about a week ago. I'm having problems with the installation process. More specifically, I have tried to build and work with ASTRA-sim but when I try the following command:
git clone --recurse-submodules git@github.com:astra-sim/astra-sim.git
I get the error below:
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
I believe I need access to some files for this command to work.
Can you please help me resolve this and also add me to the mailing list?
Thanks.

I had to manually replace the urls in .submodule to https://.../... to make it work.

@sepehrabdous: Maybe you will find some help from this closed (solved) issue 179 and hopefully you will be able to resolve it.


No play on WebSocket plain files

I'm trying to stream a TS file through websocket, following the instructions in the README.
I've installed http-server and ws, run http-server and run node websocket-relay.js password 8081 8082 and I've put my files in a samples directory.
In the HTML file I have:

Div with filename, no websocket!

but, even if the file is played, through this I see no connection on the WS relay (Disconnected WebSocket (0 total)).
Then I've tried with

Div with ws, no play

and in this case the connection is there (New WebSocket Connection:  ::1 Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.119 Safari/537.36 (1 total)) but the file is not played due to an update on browsers security (does not work neither with Google Chrome nor with Microsoft Edge).
Chrome develoer tools show me this warning message: jsmpeg.min.js:5 The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page. https://goo.gl/7K7WLu but I'm not an expert of JavaScript and looking at the link does not help me too much. Even adding data-autoplay="false" does not work. Is there something that I miss?
Going to chrome://flags/#autoplay-policy on Chrome and setting no user gesture is required., the warning above disappears, but I still see the warning WebGL: INVALID_OPERATION: texImage2D: type UNSIGNED_BYTE but ArrayBufferView not Uint8Array in developer tools and no canvas at all appears in the page.
By formatting the minified JS, the warning seems related to this method
  WebGLRenderer.prototype.allowsClampedTextureData = function () {
    var gl = this.gl;
    var texture = gl.createTexture();
    gl.bindTexture(gl.TEXTURE_2D, texture);
    gl.texImage2D(gl.TEXTURE_2D, 0, gl.LUMINANCE, 1, 1, 0, gl.LUMINANCE, gl.UNSIGNED_BYTE, new Uint8ClampedArray([0]));
    return gl.getError() === 0
  };

and, specifically to the gl.textImage2D call.
I saw on #186 that you suggest to ignore the warning. Ok. But why it does not play through WS?
Thank you,
Marco

Going to chrome://flags/#autoplay-policy on Chrome and setting no user gesture is required., the warning above disappears, but I still see WebGL: INVALID_OPERATION: texImage2D: type UNSIGNED_BYTE but ArrayBufferView not Uint8Array in developer tools and no canvas at all appears in the page.

Websocket streaming requires another process that feeds the stream to the websocket-relay.js. Hence the name - it just relays an incoming http stream via websockets.
If all you want to do is serve a static .ts file, you just need to serve it as a static file, like you did in your first example. Which seemed to work just fine!?
So the question is, why do you want to do stream this file through WebSockets instead?
If you really want to stream a static file through websocket, you can instruct ffmpeg to read the .ts file and send it to the websocket-relay. Something like ffmpeg -i video.ts -vcodec copy -acodec copy http://localhost:8081 (untested, please see the ffmpeg docs for exact usage).

Hello @phoboslab and thanks for the answer.

So the question is, why do you want to do stream this file through WebSockets instead?

Order from above. Anyway I've found how that something else will stream me the file, so I can get back to ffmpeg as a test support.

If you really want to stream a static file through websocket, you can instruct ffmpeg to read the .ts file and send it to the websocket-relay. Something like ffmpeg -i video.ts -vcodec copy -acodec copy http://localhost:8081 (untested, please see the ffmpeg docs for exact usage).

This works. I only had to add -f mpegts after the -i video.ts part.
<canvas style="width: 640px; height: 480px" id="video-canvas"></canvas>

The strangest part is that the file is very fast, with only parts visible and strange audio (something similar to a videotape fast forward, if you remember videotapes). Codecs should've been copied, so I'm expecting to see the same things as if I play the file through VLC. Am I wrong?
Also how to have video controls? Buttons, slider, volume, ... is is possible?

The strangest part is that the file is very fast, with only parts visible and strange audio (something similar to a videotape fast forward, if you remember videotapes).

Try ffmpeg -re -i file.ts ... (see https://ffmpeg.org/ffmpeg.html#Advanced-options)

Also how to have video controls? Buttons, slider, volume, ... is is possible?

You have to build those yourself. The player just comes with a simple play/pause button (ex: https://jsmpeg.com/), but it's disabled for streaming video. Searching through the video (i.e. a position bar) will not be possible at all with the streaming setup.

Ok, thank you.


Same dependencies with different classifiers are not consumed correctly from Gradle Module Metadata

I think the .module file produced by maven-publish plugin (next to POM) bring Gradle to ignore redundant dependencies artifacts (for example if we want in compileClasspath two archives of one artifact, using classifiers to select them) in each dependencies section of each variants in the JSON-like module file when "consuming" a maven artifact.
Expected Behavior
For example if I've a project A, a library and I want it to depend on (btw I'm using Kotlin DSL) :

api("com.example:foo:1.0.0")
runtimeOnly("com.example:foo:1.0.0:natives-windows") (inspired by lwjgl 3 libs if you know)
Then I publish this library A on a maven repo (or local maven repo, same behavior) and with same group and version 1.0.0.

Next I create a project B that depends on A :

implementation("com.example:A:1.0.0")

Finally, I expected Gradle to "apply transitivity"  (I don't really know if it's the real name of this behavior), that is, Gradle to append in the project B compileClasspath the com.example:foo:1.0.0 artifact, and in the runtimeClasspath the natives' artifact com.example:foo:1.0.0:natives-windows.
Current Behavior
But in reality Gradle does only one of them, adding natives artifact to runtimeClasspath, or default artifact to compileClasspath. It's the same with more artifacts or more classifiers.
Context
I'm making a 3D engine helper onto LWJGL 3, and wanted to include to this library all three natives in addition to each needed default artifacts of LWJGL, all that published on Maven Central for use in my Minecraft clone.
Steps to Reproduce
I think I've described how to reproduce in top sections, but if you want to test with my projects :

msengine, just by launching task publishToMavenLocal
proc-gen, by trying showConf tasks that display runtimeClasspath (which I'm interested in for natives) configuration artifacts archives.

Finally, I solved this problem by deleting the module file from my local maven repo, and showConf task worked as expected. For now the only way I can get rid of this issue is to use only maven POM file.
Your Environment
Build scan URL: scan (page not found for me...)

I found a cleaner way to solve this issue using the metadataSources blocks of MavenArtifactRepository class, for example here I configure this for the mavenLocal repository :
repositories {
    mavenLocal {
        metadataSources {
            mavenPom()
            ignoreGradleMetadataRedirection()
        }
    }
}

Thanks for the report, this is indeed a bug that will need to be fixed.
I managed to reproduce it in isolation.
First of all, the produced Gradle Module Metadata is correct. However, the consumption is not.
So the workaround of ignoring Gradle module metadata redirection is the correct one for now.
What is currently not working is resolving a single variant in Gradle Module Metadata that declares a dependency on the same module, once with a classifier, once normal. Gradle loses the one without classifier information.

Thanks for information, that is what I thought about the resolving.

Fixed for Gradle 6.3

We will do another 6.3 release candidate. We already have a nightly with the fix. Would you care to confirm that it solves the issue for your @mindstorm38?
./gradlew wrapper --gradle-version=6.3-20200318000026+0000

It works

We just released 6.3 RC3 with this fix included.


SDL client - Multimonitor Launches 2 monitors on top of each other

Describe the bug
When Running SDL-freerdp on Raspberry Pi 4 Debian, the multimonitor command launches 2 windows on top of each other with one being black.
To Reproduce
Steps to reproduce the behavior:

Write a Debian image for raspberry pi
Build sdl client
attempt to connect to host with /multimon
2 windows overlap each other

Expected behavior
a full screen (borderless) window on each of the available monitors
I checked the latest prebuild on windows and it does something similar but both windows launch in windowed mode and can't swap to Fullscreen.
Is this a bug or is SDL multimon simply not fully implemented??

@rogtheotech needs some investigation, multimonitor is still work in progress (the whole SDL client as we´re waiting for SDL3 due to some limitations we can not work around with SDL2)

This seems to be related to the remaining issues i have with sdl and wayland - just that it worked exactly once for me.
@rogtheotech is this on wayland or X?

I have exact same problem. Please let me know if I can provide any logs or anything that might help to get this fixed.
Many many thanks :)


Set value of URIHost as Host in outgoing HTTP request

This pull request changes behavior of crosscoap so that value of option coap.URIHost gets assigned to outgoing *http.Request. This change allows to run crosscoap as a single instance while being able to forward requests to multiple backends.

Thank you @besedad for your contribution.
Can you please add a test for this new functionality? In translate_test.go for sure, and ideally also in crosscoap_test.go to verify end-to-end.

Thank you @dubek for such prompt response. I've added the tests.

Merged. Thanks @besedad for your contribution.


Contact form shortcode, widget or page?

It would be nice to have a built-in contact form that could be enabled somehow. Perhaps one under the author page is enough.
I can't seem to find it if there is any.

Not implemented yet, will create a module for this, no ETA guarantee.

If it helps, a self-hosted alternative I use is formailer.

FYI @Rubonnek, there is a bug of the form validations (error messages not showing) on production env, fixed since github.com/hbstack/form v0.1.1, it may affect the Staticman comments and contact modules.
hugo mod get -u<EMAIL_ADDRESS>
The fixed contact form as below.

Thanks for letting me know!


Supporting Tomcat 8.5 and Java 10?

As of last night, I had a setup of jOAI on Ubuntu 16.04 LTS which had been working fine all the way from Java 8 to Java 9 to Java 10 with Tomcat 8.0, but once I upgraded to Ubuntu 18.04 LTS, with Tomcat 8.5, jOAI no longer worked. I tried a fresh install from scratch, dropping in the oai.war file into the right place with sudo cp joai_v3.2/oai.war /var/lib/tomcat8/webapps/ but the resulting Web page was empty. I can investigate other environmental factors, but I wonder if jOAI 3.2 has been tested with Tomcat 8.5 and Java 10.
More generally, I am curious what the plans are for further maintenance or development of jOAI. Since we are an OAI provider at http://oai.talkbank.org/oai (no longer working because of the "upgrade"), we need to know how to continue being so.
Note that Tomcat 8.0 is going end of life this summer: https://bugs.launchpad.net/ubuntu/+source/tomcat8/+bug/1712645

I just installed Tomcat 9.0.7 manually on Ubuntu 18.04 LTS and jOAI works fine with it and Oracle Java 10. So now I am suspecting there is nothing wrong with jOAI. I will try a fresh installation of Tomcat 8.5.

I did a fresh install of Tomcat 8.5.30 on Ubuntu 18.04 LTS and jOAI fails to work there. I guess I will consider this a bug in Tomcat 8.5.30!
You may want to make a note of this in the documentation.

I verified that jOAI works with Tomcat 8.5.30 and the default Java (default-jdk) java-11-openjdk-amd64. The combination that did not work was when I used oracle-java10-installer.

I suspect that the oracle-java-10-installer installed in a way that Tomcat/jOAI could not see all the libraries that it needs. That's one of the most common problems I've encountered. Glad you were able to get it working with the default jdk and Tomcat 8.5.30.


Relative paths in tscn files work but godot substitutes with absolute ones on save.

Godot version:
11d77386
Issue description:
For the purpose of code/asset reusage, having relative paths is absolutely great (as mentioned in #22019).
Godot's ability to read relative paths for tscn files(at least in the editor) is present, so why not making it as a default for resources that are in the same folder/subfolders? And if not a default, at least Godot should not edit it back to an absolute path.
I think it is generally likely for tscn files for being moved together with the folder where they live in.
If i recall correctly, it was present on 2.1
Minimal reproduction project:
Before opening with godot, open a text editor.
The scene called Node2D in the sub1 folder has a relative path inside.
Open godot, open the scene, save, close
Open the tscn again with the text editor and you will see that the path has changed to absolute.
RelativePath.zip

Bumping @reduz based on the blame of https://github.com/godotengine/godot/blob/4a0f7837324801f405e5c87619219b8cd03c86c2/scene/resources/scene_format_text.cpp#L1474

Relevant past issues of note: #1694, #3244, #3842.
Relative path caused some trouble back then, so they were removed.

Closing in favor of https://github.com/godotengine/godot-proposals/issues/2327, as feature proposals are now tracked on the Godot proposals repository.


feat(docs): recommend users to use a lock file and npm ci when running in CI

Is your feature request related to a problem? Please describe.
Related to https://github.com/netlify/cli/issues/2202
When users run npm install netlify-cli -g they always get the latest minor/patch versions of CLI dependencies. This usually works ok and helps users get the latest security updates, but can cause issues when packages don't follow semver.
When running in CI it is recommended to use a lock file and npm ci or yarn install --frozen-lockfile to ensure reproducible builds.
Important npm install netlify-cli -g also means users opt in to any CLI major (breaking) version change. Those are less frequent but still happen.
Describe the solution you'd like
Update the docs to recommend using a lock file when using the CLI in CI environments
Describe alternatives you've considered
https://github.com/netlify/cli/issues/2223
https://github.com/netlify/cli/issues/1597
Can you submit a pull request?
Yes

Related to https://github.com/netlify/engineering/issues/318.


Duplicate code (part 2)

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L493-L499
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L507-L516
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L550-L556
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L564-L573
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L607-L613
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L621-L630
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L664-L670
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L678-L687
==========================================
2.
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/helpers/fmt.rs#L201-L206
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/helpers/fmt.rs#L277-L282
===========================================
3.
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/format.rs#L255-L263
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/format.rs#L269-L277
===========================================
4.
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/function_call.rs#L75-L85
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/function_call.rs#L134-L144
===========================================
5.
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/function_call.rs#L420-L440
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/function_call.rs#L1759-L1779
==============================================
6.
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/functions.rs#L137-L146
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/functions.rs#L695-L704
==============================================
7.
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/functions.rs#L191-L212
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/variables.rs#L170-L192
==============================================

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/instructions.rs#L441-L452
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/instructions.rs#L516-L527
==============================================
9.
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/instructions.rs#L492-L500
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/instructions.rs#L566-L573
=============================================
10.
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/instructions.rs#L1022-L1026
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/instructions.rs#L1028-L1032

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L630-L636
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L674-L680
=============================================
12.
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L1037-L1043
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L1089-L1095
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L1101-L1106
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L1119-L1124
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L1144-L1150
=============================================
13.
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/literals.rs#L46-L55
https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/literals.rs#L112-L121

Hello sir, Can I work on this ? It would be better if this could be assigned to me .

Hey @mihir1739, we have not heard from you for more than a month. Please, let us know if you are still interested in working on this issue. If not, we'll deassign you from it so others can contribute.

Is anyone working on this ?

Hi @seanyoung  so anyone can pick it. I am new to the repository can you guide how can i begin from this issue


Two javascript tags in search page

Description
On the search page, there are two javascript tags with different spellings. When either one is clicked, both gets selected. Are the two tags intentional or is this some bug?
I have attached the screenshot below.
Screenshots

Additional information
No response

This issue seems to be a duplicate of #4676

Closing as a duplicate.  Please remember to search issues before creating a new one.


Do not translate injections in booster SMT

Fixes #3917
We should not be translating any injections because Z3 doesn't support subtyping, which causes issues when we try to e.g. assert that VarX:SortA{} and inj(SortB{}, SortA{})(VarY:SortB{}) are equal.

If the integration test times out loading the definition again, we should probably make a small K definition that illustrates the problem without all payload from kontrol

If the integration test times out loading the definition again, we should probably make a small K definition that illustrates the problem without all payload from kontrol

I was trying to come up with a smaller example, but I have no idea how we got the backend to send the substitution in just the way to cause an error. I've tried to instead just run with booster-dev, as this test does not depend on kore anyway and I think it's the kore internalisation that's causing the timeout...

I've tried to instead just run with booster-dev, as this test does not depend on kore anyway and I think it's the kore internalisation that's causing the timeout...

That's fine. It is indeed the definition internalisation ( including some simplifications) in kore-rpc that times out.


Imported class is not recognized in the root build.gradle.kts

root build.gradle.kts:
import com.example.buildsrc.Depends
.
.
.
plugins {
    id("org.sonarqube") version com.example.buildsrc.Depends.Versions.sonarqubeVersion //OK
    id("org.sonarqube") version Depends.Versions.sonarqubeVersion //NOT OK

e: .../build.gradle.kts:6:49: Unresolved reference: Depends

That is expected. The plugins block is evaluated in isolation so the code it has access to is very limited.
Pls. see here: https://docs.gradle.org/current/userguide/plugins.html#plugins_dsl_limitations


_adminClient.GetMetadata().Topics will automatically create the just deleted topic

Description
confluent-kafka version: 2.0.2
kafka version: kafka_2.13-2.8.2
How to reproduce
// delete topic
_adminClient.DeleteTopicsAsync(new List<string> {topic}, new DeleteTopicsOptions {RequestTimeout = TimeSpan.FromSeconds(30)}).Wait();

// get all topic first time
Metadata metadata = _adminClient.GetMetadata(TimeSpan.FromSeconds(10));
List<TopicMetadata> topics = metadata.Topics;

// get all topic second time
Metadata metadata = _adminClient.GetMetadata(TimeSpan.FromSeconds(10));
List<TopicMetadata> topics = metadata.Topics;

kafka log
Create a topic
[2023-02-14 11:03:58,953] INFO Creating topic my-topic with configuration {} and initial partition assignment HashMap(0 -> ArrayBuffer(0)) (kafka.zk.AdminZkClient)
[2023-02-14 11:03:58,970] INFO [ReplicaFetcherManager on broker 0] Removed fetcher for partitions Set(my-topic-0) (kafka.server.ReplicaFetcherManager)
[2023-02-14 11:03:58,972] INFO [Log partition=my-topic-0, dir=/root/start_kafka/kafka_data] Loading producer state till offset 0 with message format version 2 (kafka.log.Log)
[2023-02-14 11:03:58,972] INFO Created log for partition my-topic-0 in /root/start_kafka/kafka_data/my-topic-0 with properties {} (kafka.log.LogManager)
[2023-02-14 11:03:58,972] INFO [Partition my-topic-0 broker=0] No checkpointed highwatermark is found for partition my-topic-0 (kafka.cluster.Partition)
[2023-02-14 11:03:58,972] INFO [Partition my-topic-0 broker=0] Log loaded for partition my-topic-0 with initial high watermark 0 (kafka.cluster.Partition)
delete topic
[2023-02-14 11:04:07,741] INFO [GroupCoordinator 0]: Removed 0 offsets associated with deleted partitions: my-topic-0. (kafka.coordinator.group.GroupCoordinator)
[2023-02-14 11:04:07,743] INFO [ReplicaFetcherManager on broker 0] Removed fetcher for partitions Set(my-topic-0) (kafka.server.ReplicaFetcherManager)
[2023-02-14 11:04:07,743] INFO [ReplicaAlterLogDirsManager on broker 0] Removed fetcher for partitions Set(my-topic-0) (kafka.server.ReplicaAlterLogDirsManager)
[2023-02-14 11:04:07,744] INFO [ReplicaFetcherManager on broker 0] Removed fetcher for partitions Set(my-topic-0) (kafka.server.ReplicaFetcherManager)
[2023-02-14 11:04:07,744] INFO [ReplicaAlterLogDirsManager on broker 0] Removed fetcher for partitions Set(my-topic-0) (kafka.server.ReplicaAlterLogDirsManager)
[2023-02-14 11:04:07,745] INFO Log for partition my-topic-0 is renamed to /root/start_kafka/kafka_data/my-topic-0.c4e8faa781c24c6db91a5bbf423a87e1-delete and is scheduled for deletion (kafka.log.LogManager)
automatically create the just deleted topic
[2023-02-14 11:04:15,779] INFO Creating topic my-topic with configuration {} and initial partition assignment HashMap(0 -> ArrayBuffer(0)) (kafka.zk.AdminZkClient)
[2023-02-14 11:04:15,786] INFO [ReplicaFetcherManager on broker 0] Removed fetcher for partitions Set(my-topic-0) (kafka.server.ReplicaFetcherManager)
[2023-02-14 11:04:15,788] INFO [Log partition=my-topic-0, dir=/root/start_kafka/kafka_data] Loading producer state till offset 0 with message format version 2 (kafka.log.Log)
[2023-02-14 11:04:15,789] INFO Created log for partition my-topic-0 in /root/start_kafka/kafka_data/my-topic-0 with properties {} (kafka.log.LogManager)
[2023-02-14 11:04:15,789] INFO [Partition my-topic-0 broker=0] No checkpointed highwatermark is found for partition my-topic-0 (kafka.cluster.Partition)
[2023-02-14 11:04:15,789] INFO [Partition my-topic-0 broker=0] Log loaded for partition my-topic-0 with initial high watermark 0 (kafka.cluster.Partition)
Checklist
Please provide the following information:

[x] A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
[x] Confluent.Kafka nuget version.
[x] Apache Kafka version.
[ ] Client configuration.
[ ] Operating system.
[ ] Provide logs (with "debug" : "..." as necessary in configuration).
[ ] Provide broker log excerpts.
[ ] Critical issue.

You should use: AllowAutoCreateTopics = false
When configuring the AdminClient.

@chenjing1294 did the previous comment fix your issue or are you still experiencing it?


Issue: Update "deleted" all Groupskill marks

This one is a bit annoying for me, because it costs much time. One of the last updates deleted all the groupskill marks on minion sheets. In the actor tab as well ans in compendiums.

The good news is, nothing has been deleted so your stuff will be restored as soon as I push an update.
The bad news is I missed this bug when I merged in some pull requests from contributors, so it slipped by me! Gotta be more careful! 😄
To fix manually before I roll out the next update, lines 172, 202, and 230 in the minionsheet.html template need to be changed from:
<input class="careerskill-toggle" type="checkbox" name="data.skills.{{id}}.careerskill" data-dtype="Boolean" {{checked skill.careerskill}} />
To:
<input class="careerskill-toggle" type="checkbox" name="data.skills.{{id}}.groupskill" data-dtype="Boolean" {{checked skill.groupskill}} />

Rolled out a hotfix. Might need to force an update to get it as the version number has not changed.


[SPARK-41834][CONNECT] Implement SparkSession.conf

What changes were proposed in this pull request?
Implements SparkSession.conf.
Took #39995 over.
Why are the changes needed?
SparkSession.conf is a missing feature.
Does this PR introduce any user-facing change?
Yes, SparkSession.conf will be available.
How was this patch tested?
Added/enabled related tests.

Merged to master and branch-3.4.


link to latest version results in 404

Documentation feedback

Page title: CrateDB Clients and Tools
Page URL: https://crate.io/docs/crate/client-tools/en/latest/index.html
Source: https://github.com/crate/crate-clients-tools/blob/master/docs/index.rst

when clicking on latest, href points to
https://crate.io/docs/crate/client-tools/en/latest/
instead of
https://crate.io/docs/crate/clients-tools/en/latest/

@msbt thanks for the issue report!
can you give me the URL of the page with the broken link, please? I can't seem to find it

it is actually on that page: https://crate.io/docs/crate/clients-tools/en/latest/ - if you click on latest there, you get forwarded to 404 (probably a similar issue as with admin-ui the other day)

aha, thanks @msbt

Fixed


Ability to change font & button size, and add Repeat button (and maybe add the option to remove Album Art)

If possible, please add the ability to change the font & button size to make it smaller and maybe add the repeat (all and once) button from Spotify too? The fact that the font and the buttons are so big that the song title cannot be read when the spot-thing window is resized to a smaller size kinda defeats the purpose of the "mini-player" vibe. Also, maybe add the option to remove the album art as well?
Basically, I want to reduce the total size of the app to something like the size of the bottom button bar but currently it is not possible. But it is still a great small app that suits my needs, so thanks a lot! :)

Thanks for the feedback! Glad you're enjoying spot-thing <3
I finally got around to wrapping up some pending changes I had to add the option to like a song that's playing so I added in the repeat functionality you requested as well. You can try it out by downloading the latest release.
Thanks again!


Update package.json to exports itself

This change is needed to access the package.json for external bundlers as documented here and discussed here. I also did the same for another npm package here.

Pull Request Test Coverage Report for Build c3376bc867091fe01ae7fb2d14ee9f9738d633a0-PR-243

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 9799734dcf2b04c1216818f8b74cba92b6de4f76:
0.0%

Covered Lines:
236

Relevant Lines:
236

💛  - Coveralls

Why would you like to import Stylis' package.json though?

It's not for my usage but for bundlers, for example with rollup and svelte, the bundler want to access the package.json to check for a custom property named svelte. There is also the same for React Native as discussed here.

Oh, gotcha. I don't think this is a scalable solution though - they should switch to fs APIs.

I agree, this current situation is not ideal and that's why the node.js team is thinking about auto-exporting the package.json for all packages as discussed here.

Btw. from what I remember Svelte's compiler is Rollup-based and it seems that @rollup/plugin-node-resolve is using FS APIs to access package.json: https://github.com/rollup/plugins/blob/3d60158f21e0b6a5a8a53d9977928e2e148cb885/packages/node-resolve/src/resolveImportSpecifiers.js#L133-L134

You're right this should work with the @rollup/plugin-node-resolve but svelte is using rollup-plugin-svelte to compile svelte via rollup and here is where they access the package.json.

package.json to check for a custom property named svelte

Is this specific to svelte only? Because stylis doesn't export a svelte pkg.json field making this issue moot?

Stylis don't need to modify its package.json file, it just need to exports it because it was a default behavior in the past and now it needs to be manual.

@thysultan the problem is only that Svelte's compiler is trying to require the stylis/package.json because it wants to check if there is a custom svelte key there but node rejects their request because we have exports map defined and we do not allow for stylis/package.json to be accessed within it. This is a problem with their approach to read package.json - they really should FS APIs to read this file (which wouldn't be rejected) instead of a plain require

I'd imagine many other packages would have this same issue, @Graphmaxer can you file this issue with the svelte compiler.
Thanks.

@thysultan any other package using “exports” but not explicitly including package.json does have this issue, and the fix in this PR is the only solution available. The svelte compiler has no reliable way to do this otherwise.

@ljharb Why using FS APIs is not a possible solution for the Svelte compiler? @rollup/plugin-node-resolve does exactly this and it doesn't suffer from this issue:
https://github.com/rollup/plugins/blob/3d60158f21e0b6a5a8a53d9977928e2e148cb885/packages/node-resolve/src/resolveImportSpecifiers.js#L133-L134

It’s impossible to reliably know where package.json lives on the filesystem. That plugin is using heuristics to figure out the package name, which does not reliably locate the proper package.json in every case.
As a member of the node modules team and the maintainer of https://npmjs.com/resolve, i can assure you that the only fix (prior to node itself adding an api for locating a package directory) is for every individual package using “exports” to also add package.json to it.

I know about your involvement in those projects but I would also like to understand the issue at hand (so for example I could explain it to others in the future). I fail to see when this heuristic could fail.
According to the https://nodejs.org/api/esm.html#esm_resolver_algorithm and the PACKAGE_RESOLVE algorithm .exports is always read from pjson that is a result of READ_PACKAGE_JSON (step 10.5). So if I understand this correctly that READ_PACKAGE_JSON algorithm would have to return something that doesn't fit that simple heuristic. That algorithm mentions this:

Let pjsonURL be the resolution of "package.json" within packageURL.

But I can't find anything beyond that and this statement doesn't seem to tell me on its own how this is resolved.
Also, the call to READ_PACKAGE_JSON looks like this: READ_PACKAGE_JSON(packageURL) (step 10.4) so either way this is resolved from the "root" of the package so how this could return anything beyond lib/package.json?

The issue is exactly that - when an exports dot points to a file in a dir, that in turn has a package.json.
Certainly tools could reimplement node’s own require algorithm, as resolve itself has, but this is far more complicated than packages adding a single line to their own exports object.

The issue is exactly that - when an exports dot points to a file in a dir, that in turn has a package.json.

I don't follow. Could you illustrate this with a simple example?

Certainly tools could reimplement node’s own require algorithm, as resolve itself has, but this is far more complicated than packages adding a single line to their own exports object.

Well, at least if tools do this then this complexity lies just in a couple of tools whereas if the community will be forced to add package.json to the exports map the "complexity" gets spread across the ecosystem. I strongly believe that this solution just doesn't scale at all and adding this to packages is just counter-productive.

The longer term solution is to add an api to node itself to expose the package dir, which tools can then use. That solution is not yet ready, and in the interim, a package’s choices are “don’t use exports”, or “add package.json”, or “screw over users by breaking the majority of tools that don’t yet use fs APIs or resolve”.

I find it hard to blame package authors for "screwing over users" if this has not been accounted for by the node team... If anything I feel like this should be prioritized there so we wouldn't have to do anything for a short period of time in which this stays "bugged" on the node's side.
That being said I still have no idea how a package can be structured right now that would be incorrectly handled by the @rollup/plugin-node-resolve 😕

That is a reasonable reaction, and i don’t dispute it - but that doesn’t change the reality now.
I’d have to take a look at its logic to locate bugs, but i don’t pay much attention to the rollup ecosystem, so I’m not sure when I’d find time.

@thysultan Thanks for reopening this. I just merged master to resolve conflicts.


Hi there!

Hey :)

Very cool idea!
I have just updated it to 1.3.4.
Is it possible for you to send me Qonsole.ahk updated (to v1.3.4) with your fork's changes?
I will then merge it. :)
I actually have a github account, I thought of moving it to github. However, I just havent brought myself to do it yet. :P

From: https://sourceforge.net/p/qonsole-ahk/discussion/general/thread/c344cb20/#1a17

Merged :+1:
https://github.com/joedf/Qonsole/releases/tag/v1.4.0


"declare global" affects all compiled modules even when the source file is in "module" mode

TypeScript Version:  2.8.0-dev.20180314

Search Terms: global declarations, ambient context.
Code
a.ts
declare global {
    interface Window {
        someGlobalVar: number;
    }
}
window.someGlobalVar = 10;
// to turn on "module"-mode for this file
export const unusedExport = 100500;

entry.ts
import './a';
console.log(window.someGlobalVar); // 10 as expected

entry2.ts
console.log(window.someGlobalVar); // `undefined`, but type is `number`

tsconfig.json
{
  "compilerOptions": { "strict": true },
  "files": ["entry.ts", "entry2.ts"]
}

Expected behavior:
Error in entry2.ts about undeclared member.
Actual behavior:
No errors.
If we comment out the import './a'; in entry.ts, compilation fails with the following errors in BOTH modules (as expected):
entry.ts(2,20): error TS2339: Property 'someGlobalVar' does not exist on type 'Window'.
entry2.ts(1,20): error TS2339: Property 'someGlobalVar' does not exist on type 'Window'.

But if we import a.ts in the first entry file, both errors disappear, so, using the import in the first entry module produces side effects on the second one. This is a bit surprising that declare global produces such side effects even when source file is in "module" mode. It leads to the mismatch between declared types and the other side effects like window.someGlobalVar = 10.

A global variable is accessible in every scope. You don't have to import global variables. If you want a variable to only be available when you import a module, use export instead of declare global.
The reason at least one import of the module is required is that if the module isn't included in compilation at all, the global never gets declared. But once the global is declared it can be accessed from anywhere.

If you want a variable to only be available when you import a module, use export instead of declare global.

@andy-ms but what if you want to extend some interface/class/namespace (from global scope or from some other module)? For example like in rxjs.
Seems that declare module works very similar to declare global.

@timocov That example is a module augmentation.  It modifies a different module than the current one, so you're right that it's global in effect, i.e. you don't have to import the augmenter to see the effect in the augmented module.

i.e. you don't have to import the augmenter to see the effect in the augmented module.

In the example of "Module Augmentation" augmenter is imported explicitly:
// consumer.ts
import { Observable } from "./observable";
import "./map";

and I believe this is correct if we want do not have ReferenceError in run-time. But currently seems that TypeScript does not check that you import it before use in current module and it may be a reason of runtime errors.

@andy-ms Consider this import clause: import "./map". The language handbook and MDN says that we should use such import to ensure that side effects of the module are applied. Obviously, we can not rely on this if we do not import the module (because the module system does not guarantee that this module is already loaded and executed).
But the type system behavior is different. Compiler assumes that if the module was ever built (and the "declare global" or "declare module" statement in this module is parsed and applied during build), then the side effects are applied too, without any alignment with the module loading in runtime.
So, we end up relying on side effects in all the modules even if we do not explicitly import the module producing that side effects.

@Nipheris That's unfortunate, but the compiler doesn't always analyze the order things are executed in anyway:
f();
function f() {
    console.log(x);
}
const x = 0;

This code will type-check but fail at runtime (assuming you target --esnext; in es5 we emit a var which is undefined if not initialized). In general, we check for the existence of a value but not for the time when it's actually set. We're smarter about local variables (can't write console.log(y); const y = 0;), but that's about as far as it goes.


Add missing link to glm imported target

I noticed this while debugging https://github.com/ami-iit/yarp-device-openxrheadset/issues/35 . Everything was working fine as glm is an header-only library, but anyhow it is correct to link glm as the library is using glm-related headers.

The failures are related to https://github.com/ami-iit/yarp-device-openxrheadset/issues/35
Merging anyway


Update macos version for github actions

See https://github.com/cython/cython/issues/4913

Can we stick to 11? I'd rather make sure that we don't break anything on older macOS installations.

Can we stick to 11? I'd rather make sure that we don't break anything on older macOS installations.

Done. I picked 12 because it seemed like it would give us longer before we need to update it again, but checking older installations seems like a good idea


(d&d5e_shaped) Add tooltips for skill checks (copied from basic rules)

There is probably some need to adjust stylings to fit in and rename the css-classes to fit a more general scheme

Hey Rouby,
It would be easier to merge these changes into my fork instead of putting it directly into roll20's base branch.
https://github.com/mlenser/roll20-character-sheets/tree/master/D%26D_5e_Shaped is my fork.
Helping add some documentation as tooltips is a great idea! Though I'm curious why we need a new class "sheet-row-relative". Did you make that to have the content be wider? We can do that by adding some widths on the tooltip class instead.
If you'd like to discuss this please pm me on Roll20 as Github does not have private messaging. We can chat on changes over roll20 or I can give you my skype/gchat. https://app.roll20.net/users/277007/mark
Thanks again for contributing. Please follow up. :)

Hi,
Just forked your repo, I will issue a pull request as soon as I solved the conflicts ;).
I looked to contact you but since Github has removed the private messages I didnt know exactly where to messasge you.
I created the class 'sheet-row-relative' because the tooltip-button needs to be in a relative-container (because the absolute positioning). I am not that familiar with all the other classes and maybe there is a better way to position the tooltip-button (I am sure there is, because right now it looks kinda squashed).
Also I would like to translate this sheet to german. What do you think would be the best approach to this?

Message me on roll20 so I can give you my info and we can discuss. I have already setup some tooltip examples for checks and skills that you can follow.
Translating: I would like to do this too. Roll20 doesn't support it very well, but we can do some css and html to show certain text. See https://app.roll20.net/forum/post/1837912/d-and-d-5e-slash-slash-spanish-character-sheet-hojas-de-personaje-en-espanol
I'd happily set an example up if you want to translate all the text into German.


<EMAIL_ADDRESS>flagged

Please help me fix my account privacy

❤💱

This is a placeholder repo for a project that has not yet begun and has no active users. I'm not sure if this is spam or just posting to the wrong place, but it's definitely not a relevant issue.


[PostGIS] Do not linearize curved geometries in the data grid

Description
As discussed here https://github.com/dbeaver/dbeaver/issues/19608#issuecomment-1662002883 with @ShadelessFox, the curved geometries are linearized in the data grid and in the viewer for display purposes. But it should be only linearized for the viewer, not in the data grid because we want to see the original data there.
DBeaver Version
23.1.3
Operating System
No response
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Thank you for bug report.

Thanks, it's working fine!


Try out Whisper-X

Deploy and run WhisperX

UPDATE:

batch_size = 24 works the best (91% GPU memory usage, fastest overall)
batch_size = 26 was <1s faster for 1 hr audio file and consumed around 97% GPU memory. Overall it was still slower by <1s than size 24. Very close to running OOM => NOT SUITABLE

Next step: Run WhisperX evaluation using batch_size = 24