proposal: x/net/http2: Add support for client-side H2C upgrade flow

What version of Go are you using (go version)?

$ go version
go version go1.16.4 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/pivotal/.cache/go-build"
GOENV="/home/pivotal/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/pivotal/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/pivotal/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.16"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.16/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.4"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1134153495=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Issue a request to a to a h2c server (examples in #45785) with the appropriate headers to trigger a h2c upgrade:
package main

import (
        "fmt"
        "log"
        "net/http"
)

func main() {
        transport := &http.Transport{}
        client := http.Client{Transport: transport}

        req, err := http.NewRequest("GET", "http://localhost:8080", nil)
        if err != nil {
                log.Fatalf("Error making new request: %+v\n", err)
        }

        req.Header.Set("Connection", "Upgrade, HTTP2-Settings")
        req.Header.Set("Upgrade", "h2c")
        req.Header.Set("HTTP2-Settings", "AAMAAABkAARAAAAAAAIAAAAA")

        resp, err := client.Do(req)
        if err != nil {
                log.Fatalf("Error sending request: %+v\n", err)
        }

        fmt.Printf("Response:\n\t%+v\n\n", resp)
}

What did you expect to see?
The HTTP/2 response to my request.
What did you see instead?
The 101 Switching Protocols response from the h2c upgrade process.
Response:
        &{Status:101 Switching Protocols StatusCode:101 Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Connection:[Upgrade] Upgrade:[h2c]] Body:0xc00000e150 ContentLength:0 TransferEncoding:[] Close:false Uncompressed:false Trailer:map[] Request:0xc000142000 TLS:<nil>}

It's fine to receive the 101 response, but it does not seem possible for the caller to recover the HTTP/2 response for the original request.
Calling http2.Transport's NewClientConn with the underlying net.Conn will not work because the resulting ClientConn will not have a clientStream with id=1. According to RFC 7540, Section 3.2, Stream 1 will be used for the response:

The HTTP/1.1 request that is sent prior to upgrade is assigned a stream identifier of 1 (see Section 5.1.1) with default priority values (Section 5.3.5).  Stream 1 is implicitly "half-closed" from the client toward the server (see Section 5.1), since the request is completed as an HTTP/1.1 request.  After commencing the HTTP/2 connection, stream 1 is used for the response.

Stream 1 would typically be created as part of the http2.Transport roundTrip, however we do not go though a http2 round trip in the upgrade case. Since the client does not have Stream 1, the response will be dropped by the ClientConn once we send the HTTP/2 connection prefix and start the ClientConn's read loop (https://github.com/golang/go/issues/25230 takes the stream id offset into account for future http2 round trips).
Even if Stream 1 were in place, we still do not have access to the response, since it appears the logic for draining the stream's response channel is only available as part of a round trip.
We are happy to submit a change that either implements the h2c client upgrade flow or provides hooks for it to be implemented externally (possibly in x/net/http2/h2c?). Any implementation guidance you can provide would be appreciated. We will include possible implementation details in a follow-up comment.

Implementation Option
Based on our understanding, the ideal end state would be:

The original caller is able to recover the HTTP/2 response to the upgrade request (Stream 1)
The http.Transport has an idle persistConn for the h2c backend with a http2.Transport set in it's alt field that can be re-used for future requests to that backend
The http2.Transport has a ClientConn for the backend in its clientConnPool that can be re-used for future requests to that backend

If we were to implement this as part of the net/http package, one option would be to mirror the ALPN upgrade flow established in http2.ConfigureTransports and triggered when dialing the connection. The lifecycle of this upgrade would be different, since it would take place during a http.Transport RoundTrip instead of when the connection is first established.
As described above, we would need seed the created http2.ClientConn with Stream 1. This could replace the logic implemented in https://github.com/golang/go/issues/25230, or happen through other means.
The http2.Transport could also have a method for recovering the response from Stream 1, which can then be returned from the original round trip.
Proof of Concept
Based on the above ideas, we produced a proof of concept that implements the h2c upgrade flow within net/http: https://github.com/Gerg/net.
The core logic is:
if pconn.alt != nil {
  // HTTP/2 path.
  t.setReqCanceler(req, nil) // not cancelable with CancelRequest
  resp, err = pconn.alt.RoundTrip(req)
} else {
  resp, err = pconn.roundTrip(treq)
  if err == nil && resp.isProtocolSwitch() {
    upgradeProto := resp.Header.Get("Upgrade")
    if upgradeFn, ok := t.upgradeNextProto[upgradeProto]; ok {
      t2 := upgradeFn(cm.targetAddr, pconn.conn)
      pconn.alt = t2
      resp, err = t2.completeUpgrade(req)
    }
  }
}

Source: https://github.com/Gerg/net/blob/c49a8dd603d5276e2ce2f026762f3bb5443b9f5a/http/transport.go#L538-L545
We are happy to build out alternative implementations based on y'alls feedback and knowledge.

cc @bradfitz @tombergan @empijei

cc @fraenkel

Hey @neild - would any recent golang changes (since the issue was filed years ago) now allow clients to perform the h2c upgrade flow?

A quick investigation an I have something sorta working - though something is wrong below and I'm getting connection error: PROTOCOL_ERROR - oddly the response always returns
// You can edit this code!
// Click here and start typing.
package main

import (
	"bufio"
	"context"
	"fmt"
	"net"
	"net/http"
	"net/http/httputil"
	"time"

	"golang.org/x/net/http2"
	"golang.org/x/net/http2/h2c"
)

func main() {
	go runH2CServer()
	time.Sleep(1)
	doClient()

}

func runH2CServer() {
	handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		if r.ProtoMajor != 2 && r.Header.Get("Upgrade") != "h2c" {
			w.WriteHeader(http.StatusBadRequest)
			fmt.Fprint(w, "Expected h2c request")
			return
		}

		w.Write([]byte("hi"))
	})
	h2c := &http.Server{
		Addr:    ":3001",
		Handler: h2c.NewHandler(handler, &http2.Server{}),
	}
	fmt.Printf("Starting server, listening on port %s (h2c)\n", h2c.Addr)
	h2c.ListenAndServe()
}

func doClient() {
	dialer := &net.Dialer{}

	conn, err := dialer.DialContext(context.Background(), "tcp", "localhost:3001")
	if err != nil {
		panic(err)
	}
	defer conn.Close()
	bw := bufio.NewWriter(conn)
	br := bufio.NewReader(conn)

	req, _ := http.NewRequest("GET", "http://localhost:3001", nil)
	req.Header.Set("Connection", "Upgrade, HTTP2-Settings")
	req.Header.Set("Upgrade", "h2c")
	req.Header.Set("HTTP2-Settings", "AAMAAABkAARAAAAAAAIAAAAA")

	if err := req.Write(bw); err != nil {
		panic(err)
	}
	if err := bw.Flush(); err != nil {
		panic(err)
	}

	resp, err := http.ReadResponse(br, req)
	if err != nil {
		panic(err)
	}
	defer resp.Body.Close()

	bytes, err := httputil.DumpResponse(resp, false)
	if err != nil {
		panic(err)
	}
	fmt.Printf("Response:\n%v\n", string(bytes))

	transport := &http2.Transport{}
	h2cConn, err := transport.NewClientConn(conn)
	if err != nil {
		panic(err)
	}

	req, _ = http.NewRequest("GET", "http://localhost:3001", nil)
	resp, err = h2cConn.RoundTrip(req)
	if err != nil {
		panic(err)
	}
	defer resp.Body.Close()
	bytes, err = httputil.DumpResponse(resp, true)
	if err != nil {
		panic(err)
	}
	fmt.Printf("Response:\n%v\n", string(bytes))
}

I updated the above example (https://go.dev/play/p/vPEfkUEXolM) - I wasn't closing the h2c connection prior to closing the tcp connection.

Just a note that the hc2 upgrade mechanism that this proposal relies on has since been deprecated https://datatracker.ietf.org/doc/html/rfc9113#:~:text=The "h2c" string,¶


school information

A file containing school information has been inserted

@John1226 lpunetwork.txt I am sorry, I have to close the request without merging, because you made a mistake in a request and did not specify any filepath. Please ensure that you are familiar with this repository rules located at the bottom of this page and make a new correct request. Thank you for your understanding!


Create a password generator

Create a password generator, with copy and regenerate buttons
Summary by Sourcery
New Features:

Introduce a password generator web page with options to customize password length and character types, including uppercase, lowercase, numbers, symbols, and spaces.

@sourcery-ai review


fix: sls@3 compatibility

https://www.serverless.com/framework/docs/guides/upgrading-v3

codeowners still points to luna


sw_engine: fixing masking behavior

Masking with the opacity shouldn't change the target itself.
The mask's opacity < 255 causes the masked part to appear.
before (left - Mask, right - invMask):

after (left - Mask, right - invMask):

It works, but I'd like to think about the variables/functions names.
Is this way of solving this problem is the best one?

@mgrudzinska  i will review this soon.

@mgrudzinska I'm not sure what are you trying to fix. "before version" looks correct to me. what brought you "Masking with the opacity shouldn't change the target itself." ?

@hermet, let me think about that.
Could you please tell me, how do you know how the inverse masking with opacity should work?

@hermet I think that you are right and masking works as it should, but I'm not sure about inverse mask.
Please check #209 - there are 3 red plots. I thought that the correct result is the 3 one. now I think that it should be the second one, but I can't find any precise info to verify this.

just checked, it's still valid issue.


fix: create AWS client on demand to avoid side effects in constructor

AWSSecretsManagerClient prints debug logs when it's initialised which
may be triggered before logging preferences are processed in a static
context.
Fixes #8

Thanks, @jahed - going to merge and release this.


Create ghc.txt

@Arqsz Pull request merged. Please notice that free educational license for JetBrains tools is for high and higher schools students, i.e. those who are over 13 of age. Thank you!

@philipto It doesn't work, my school e-mail does like @leerling.ghc.nl. Could you help me?


NSwag CLI for WebAPI project issues

Hi all,
I have a WebAPI project on .NET 4.8. I have created a simple .swag config file using NSwagStudio for the project App.api.nswag.txt
I'm also using NSwag.MSBuild v13.15.9 into the project to generate the api.json file at build time.
<Target Name="NSwag" AfterTargets="Build">
    <Message Text=" MSBuild target: NSwag" Importance="high"/>
    <PropertyGroup>
      <DocDescription>API for the Appplatform. Updated $([System.DateTime]::Now.ToString(yyyyMMdd))</DocDescription>
      <DocVersion>2.0</DocVersion>
    </PropertyGroup>
    <Exec Command="$(NSwagExe) run $(SolutionDir)\App.api.nswag /InfoDescription:"$(DocDescription)" /InfoVersion:$(DocVersion)" />
    <Message Text=" App API was regenerated" Importance="high"/>
  </Target>

Unfortunately, the json file still contains the description and version from the .swag file. Is this scenario not supported by CLI?
Is it possible to define multiple serviceHosts? In the swagger UI html page that field is displayed in a Servers dropdown

Thank you.

I think if you use an .nswag file you cannot use these params, you need to change the description/version in the .nswag document (you can inject the param to the nswag document and use it there:
https://github.com/RicoSuter/NSwag/blob/master/samples/WithMiddleware/Sample.AspNetCore31/Sample.AspNetCore31.csproj#L18
https://github.com/RicoSuter/NSwag/blob/master/samples/WithMiddleware/Sample.AspNetCore31/nswag.json#L8


fix Coloured Lights light through block

Before Fix

After Fix

some problem
if the light source is at the corner of block , it still light through the block
its minecraft's self problem

how to fix
similar to the origin function color_light
add a function called color_light_uv , which need a extra argument called UV2
which represent the block light
the vertex_color  will become vec4(vertex_color.rgb + lcolor_2 * normalized_light.x, 1.0)
some vertex shader doesn't has a attribute in called UV2,so only some shader is applied this fix

Oh my man. It did a really good idea to fix lighting according to the skylight UV. Have you intention to dev shimmer?  Shimmer probably adds more interesting effects, I hope to get your help.

maybe some. Has shimmer or you had a platform for specialized discussion like discord ?

Haven't yet. This team and its projects were both founded and made public recently. I'll set up discord later. I'm glad if you'd like to join in.

ty, i will add you credit. if you would, i could also add your cf acount.


CSS Implementation for Textboxes

This is a feature request v2.0 (Sprint 02). This project needs all possible CSS Properties and here we have a feature request to implement text boxes. We need to implement this feature as shown below.

[x] Textboxes
[x] Textareas

Refer to this document for detailed info.
Also, Let's work together, Join our discord server: https://discord.gg/8JVG5rwW

These features are being implemented with other form elements.
Please take a look at the issue (#144 ) - Form elements are not linked with the new CSS updates.

The issue has been resolved at the docs site.
Please refer to the URL below, everything is working now.
Docs URL: https://designsystemsoss.github.io/eccentrictouch.docs/#/?id=introduction


Typo in 7.1.3

7.1.3 "Of the two kinds of theorems, soundness and completeness, the former is typically easier to show than the letter. "
--> 'latter'

Uff, that's a weird typo ;) Thanks @Bvrheenen !


HOS : Bucket Tiering policy Development:

Issue/Feature Description:
Support Bucket Tiering policy:
a. API to configure Tier
b. Object can be uploaded based on tier class
c. switching of tiers for already configured object
Why this issue to fixed / feature is needed(give scenarios or use cases):
How to reproduce, in case of a bug:
Other Notes /  Environment Information: (Please give the env information, log link or any useful information for this issue)

Tracked in
Bucket Tier[PUT]: API to update created tier policy
#1262
Bucket Tier[GET]: API to list all created tier policy
#1261
Bucket Tier[DELETE]: API to delete created tier policy
#1260
Bucket Tier[POST]: API to Create tier policy
#1259


Cottontail blocks indefinitely on creating and batch inserting entity within same transaction

When creating an entity and performing a batch insert on it within the same transaction, Cottontail DB blocks indefinitely.
The CLI may still be responsive after this, but calling system locks causes the CLI to stop responding as well.
A minimal example for reproducibility using the Cottontail DB Python Client:
from cottontaildb_client import CottontailDBClient, Type, Literal, column_def

schema = 'test_schema'
entity = 'test_entity'

with CottontailDBClient('localhost', 1865) as client:
    client.create_schema(schema)
    columns = [column_def('id', Type.STRING, nullable=False)]
    client.start_transaction()
    client.create_entity(schema, entity, columns)
    batch = [
        (schema, entity, {'id': Literal(stringData='test_1')}),
        (schema, entity, {'id': Literal(stringData='test_2')})
    ]
    client.insert_batch(batch)
    client.commit_transaction()

This was only an issue with Cottontail DB version 0.12.7 (with proto version 0.12.0) and has since been fixed.


Add deprecation notice

Summary
Adds deprecation warning to be included in the last release of qiskit-transpiler-service and to be removed in first release of qiskit-ibm-transpiler

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Migrating Physical Oceanography content to Pythia Cookbooks

One of the Pangeo Gallery items listed on #8 is http://gallery.pangeo.io/repos/pangeo-gallery/physical-oceanography/
I will be working on migrating this content to Pythia during the hackathon.

New repo now exists at https://github.com/ProjectPythiaTutorials/physical-oceanography-cookbook


[W5][W16-4]Charlotte Nixon

Started helloCommand

No conflicts with our code,  a good addition to our project

Could use some more functionality, but we can add that next version


Neato component fails with two robots

**Home Assistant release (hass --version): 0.49.1
**Python release (python3 --version):   Python 3.5.2
**Component/platform: Neato
**Description of problem:
I have two robots one upstairs called Spick, the other downstairs called span.  I can never get both robots to register their details, one (not always the same one) always fails to registerer its details.
Expected:
Both robots should be shown.
Problem-relevant configuration.yaml entries and steps to reproduce:
neato:
  username<EMAIL_ADDRESS>  password: !secret neato_passwd

Traceback (if applicable):
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 182, in _step
    result = coro.throw(exc)
  File "/usr/src/app/homeassistant/helpers/entity_component.py", line 381, in async_process_entity
    new_entity, self, update_before_add=update_before_add
  File "/usr/src/app/homeassistant/helpers/entity_component.py", line 212, in async_add_entity
    yield from self.hass.async_add_job(entity.update)
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 332, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 250, in _wakeup
    future.result()
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 245, in result
    raise self._exception
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/util/__init__.py", line 303, in wrapper
    result = method(*args, **kwargs)
  File "/usr/src/app/homeassistant/components/camera/neato.py", line 54, in update
    image_url = map_data[self._robot_serial]['maps'][0]['url']
KeyError: 'OPS02117-985DAD84C71F'

Additional info:
I have installed pybotvac to see if that has the same issue.  I get thiss result
´´´
Robots:
Name: Span, Serial: OPS14617-38D2696F54DA, Secret: A6BC950BD7923096DDEF9B62D0xxxxxx Traits: ['maps']
State:
{'reqId': '1', 'action': 0, 'details': {'charge': 95, 'dockHasBeenSeen': False, 'isScheduleEnabled': False, 'isDocked': True, 'isCharging': False}, 'availableCommands': {'start': True, 'stop': False, 'resume': False, 'goToBase': False, 'pause': False}, 'result': 'ok', 'cleaning': {'mode': 2, 'spotWidth': 0, 'category': 0, 'spotHeight': 0, 'modifier': 1}, 'meta': {'firmware': '2.2.0', 'modelName': 'BotVacConnected'}, 'availableServices': {'spotCleaning': 'basic-1', 'houseCleaning': 'basic-1', 'manualCleaning': 'basic-1', 'maps': 'basic-1', 'schedule': 'basic-1'}, 'error': 'ui_alert_invalid', 'data': {}, 'version': 1, 'state': 1}
Schedule enabled: False
Disabling schedule
Schedule enabled: False
Enabling schedule
Schedule enabled: True
Name: Spick, Serial: OPS02117-985DAD84C71F, Secret: C2163AB5CEC6F4C6C5AFDDDF59xxxxxx Traits: ['maps']
State:
{'reqId': '1', 'action': 0, 'details': {'charge': 97, 'dockHasBeenSeen': False, 'isScheduleEnabled': False, 'isDocked': True, 'isCharging': False}, 'availableCommands': {'start': True, 'stop': False, 'resume': False, 'goToBase': False, 'pause': False}, 'result': 'ok', 'cleaning': {'mode': 2, 'spotWidth': 0, 'category': 0, 'spotHeight': 0, 'modifier': 1}, 'meta': {'firmware': '2.2.0', 'modelName': 'BotVacConnected'}, 'availableServices': {'spotCleaning': 'basic-1', 'houseCleaning': 'basic-1', 'manualCleaning': 'basic-1', 'maps': 'basic-1', 'schedule': 'basic-1'}, 'error': 'ui_alert_invalid', 'data': {}, 'version': 1, 'state': 1}
Schedule enabled: False
Disabling schedule
Schedule enabled: False
Enabling schedule
Schedule enabled: True
´´´

Can you also paste the map info from pybotvac? According to your error,
that is where it fails. Is that error the only error you get?
On Sat, Jul 29, 2017 at 9:07 AM, raymccarthy<EMAIL_ADDRESS>wrote:

**Home Assistant release (hass --version): 0.49.1
**Python release (python3 --version): Python 3.5.2
**Component/platform: Neato
**Description of problem:
I have two robots one upstairs called Spick, the other downstairs called
span. I can never get both robots to register their details, one (not
always the same one) always fails to registerer its details.
Expected:
Both robots should be shown.
Problem-relevant configuration.yaml entries and steps to reproduce:
neato:
username<EMAIL_ADDRESS>password: !secret neato_passwd
Traceback (if applicable):
Traceback (most recent call last):
File "/usr/local/lib/python3.6/asyncio/tasks.py", line 182, in _step
result = coro.throw(exc)
File "/usr/src/app/homeassistant/helpers/entity_component.py", line 381, in async_process_entity
new_entity, self, update_before_add=update_before_add
File "/usr/src/app/homeassistant/helpers/entity_component.py", line 212, in async_add_entity
yield from self.hass.async_add_job(entity.update)
File "/usr/local/lib/python3.6/asyncio/futures.py", line 332, in iter
yield self  # This tells Task to wait for completion.
File "/usr/local/lib/python3.6/asyncio/tasks.py", line 250, in _wakeup
future.result()
File "/usr/local/lib/python3.6/asyncio/futures.py", line 245, in result
raise self._exception
File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 55, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/src/app/homeassistant/util/init.py", line 303, in wrapper
result = method(*args, **kwargs)
File "/usr/src/app/homeassistant/components/camera/neato.py", line 54, in update
image_url = map_data[self._robot_serial]['maps'][0]['url']
KeyError: 'OPS02117-985DAD84C71F'
Additional info:
I have installed pybotvac to see if that has the same issue.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/8694, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AP2koFilkvcLjGFIMZsBCKwB2Btuc0O9ks5sStopgaJpZM4OnR--
.

You are perfectly correct.  When I run this code
´´´bash
print("Printing Maps")
for map_info in account.maps:
print(map_info)
´´´
It only shows a map object for OPS02117-985DAD84C71F (spick).  There does not appear to be an account map for the other robot.  This must be an issue with the Neato API, they obviously only support one latest map at account level.  This explains the random nature of the problem, the robot that finishes last loads correctly in hass.
Is it possible to put a NULL check in the code, or retrieve the map from the robot endpoint rather than the account endpoint?

Almost everything is fetched from the beehive endpoint, both robots and maps. Only control of the robots are sent through the nucleo endpoint. This is where the map data is fetched:https://github.com/stianaske/pybotvac/blob/master/pybotvac/account.py#L94-L99
You could try altering the code to see if it will return two robots. In theory it should, at least if both robots are available in the phone app home screen.

@turbokongen I think the bug comes from this line:
https://github.com/jabesq/pybotvac/blob/master/pybotvac/account.py#L89
The map dict should be updated not overwritten for each robot:
self._maps.update({robot.serial: resp2.json()})

That is brilliant!  I have been staring at that code for days but didn't see the error. I'll change it tonight and see what happens.

Just patched my homeassistant setup with the change suggested by @turbokongen and it worked perfectly.  Both robots now showing correctly.
Not really sure how to propagate this change through to hass via official channels?
Thanks for the support!

Sorry @MartinHjelmare obviously it was your suggestion....

@raymccarthy make a PR to https://github.com/jabesq/pybotvac.

@raymccarthy I'm the one to blame for that line. I made the map support, but only have one robot, so I have made that mistake in the code. Like @MartinHjelmare says, make a PR to https://github.com/jabesq/pybotvac and then a PR to homeassistant pinning the new version. :+1


Bluetooth udev script regex breaking logic

This refers to /usr/local/bin/bluetooth-udev.
With the regex device name check if [[ ! $NAME =~ ^\"([0-9A-F]{2}[:-]){5}([0-9A-F]{2})\"$ ]]; then exit 0; fi enabled, devices that connect to Debian 11 do not match a mac address naming scheme -- or at the very least, a Windows device doesn't. The device connects with its hostname.
This breaks the logic flow the script intends as it doesn't disable discovery upon connection, doesn't disable wifi for those that have issues with it (wifi doesn't cause an issue on my end), and doesn't play a device connection sound upon add/remove.
My solution for this was to comment out the name check, which allowed the script to run as intended. Given we're filtering for input devices. I suppose that'd possibly catch other input devices, like a keyboard/mouse, but as this is an audio sink, other devices will likely never be connected to it.

Hm, yes that check is a bit odd. None of my phones or computers that connected have a NAME that was hexadecimal, they all had their set device name (sometimes with a parenthesis after).
@elderlabs a device connection sound? I never heard one, and didn't see anything in the scripts, what did I miss...

I also doubt my udev triggers the script. I got:
udevadm monitor --environment --udev
monitor will print the received events for:
UDEV - the event which udev sends out after rule processing

UDEV  [958.788558] remove   /devices/platform/soc/3f980000.usb/usb1/1-1/1-1.4/1-1.4:1.0/bluetooth/hci0/hci0:70 (bluetooth)
ACTION=remove
DEVPATH=/devices/platform/soc/3f980000.usb/usb1/1-1/1-1.4/1-1.4:1.0/bluetooth/hci0/hci0:70
SUBSYSTEM=bluetooth
DEVTYPE=link
SEQNUM=2338
USEC_INITIALIZED=593747535
SYSTEMD_ALIAS=/sys/subsystem/bluetooth/devices/hci0:70
SYSTEMD_WANTS=bluetooth.target
SYSTEMD_USER_WANTS=bluetooth.target
TAGS=:systemd:
CURRENT_TAGS=:systemd:

UDEV  [1039.414210] add      /devices/platform/soc/3f980000.usb/usb1/1-1/1-1.4/1-1.4:1.0/bluetooth/hci0/hci0:70 (bluetooth)
ACTION=add
DEVPATH=/devices/platform/soc/3f980000.usb/usb1/1-1/1-1.4/1-1.4:1.0/bluetooth/hci0/hci0:70
SUBSYSTEM=bluetooth
DEVTYPE=link
SEQNUM=2339
USEC_INITIALIZED=1039412512
SYSTEMD_ALIAS=/sys/subsystem/bluetooth/devices/hci0:70
SYSTEMD_WANTS=bluetooth.target
SYSTEMD_USER_WANTS=bluetooth.target
TAGS=:systemd:
CURRENT_TAGS=:systemd:

I would expect to hear a sound, but I do not:
cat /usr/local/bin/bluetooth-udev
#!/bin/bash
# if [[ ! $NAME =~ ^\"([0-9A-F]{2}[:-]){5}([0-9A-F]{2})\"$ ]]; then exit 0; fi

action=$(expr "$ACTION" : "\([a-zA-Z]\+\).*")

if [ "$action" = "add" ]; then
    aplay -q /usr/local/share/sounds/__custom/device-added-LN.wav
    bluetoothctl discoverable off
    # disconnect wifi to prevent dropouts
    #ifconfig wlan0 down &
fi

if [ "$action" = "remove" ]; then
    aplay -q /usr/local/share/sounds/__custom/device-removed-LN.wav
    # reenable wifi
    #ifconfig wlan0 up &
    bluetoothctl discoverable on
fi


Correcting the LEFT() example return

Correcting the LEFT example because the first example returns the wrong number of characters

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@jmarbutt : Thanks for your contribution to the Azure documentation! The author, @mimig1, has been notified to review your proposed change.

#sign-off @joelmartinez - Thank you for the fix! @arramac - FYI

looks good, thanks @jmarbutt @mimig1


Generic infrastructure

I was about to ask about having graph datasets. They are mostly matrices but the edges might be ordered and have other metadata on them. What part of the infrastructure in this project is reusable and can be shared between RDatasets and MatrixDepot and a hypothetical GraphsDepot? You have a some capacity for making personal collections, labeling, indexing, querying, and IO. Also there are features for generators and static matrices.

Hi @jpfairbanks,
MatrixDepot use Dict to store and display matrix information. I think RDatasets use DataFrame to do similar tasks, but I am not sure about that.
I guess the way to download data from web is reusable?
https://github.com/weijianzhang/MatrixDepot.jl/blob/master/src/download.jl
Just for reference, graph matrices from Stanford Large Network Dataset Collection are also available from UF sparse matrix collection (http://www.cise.ufl.edu/research/sparse/matrices/SNAP/) so you can download them to MatrixDepot with MatrixDepot.get.
Best,
Weijian


[Tooltip] component

As a product developer, I want to use tooltips in my product that follow the guidelines set by the CA Style Guide so that I can provide contextual help to my users.
AC

follows styling spec
same placement options as popover
content limited to a string (or function returns string)
A tooltip is a popup that displays information related to an element when the element receives keyboard focus or the mouse hovers over it. It typically appears after a small delay and disappears when Escape is pressed or on mouse out.
Tooltip widgets do not receive focus. A hover that contains focusable elements can be made using a non-modal dialog.
The element that serves as the tooltip container has role tooltip.
The element that triggers the tooltip references the tooltip element with aria-describedby.
controlled & uncontrolled

Considerations

just doing with CSS may not be accessible
what is the cost of styling the Popover like a tooltip?
trigger on hover/focus (and onClick?, multiple simultaneous)
long press on mobile (1500ms)
rtl affects placement?
should not need to stay open for interactions - use popover
render placement portal/sibling

Other tooltips

https://atlassian.design/guidelines/product/components/tooltips
http://blueprintjs.com/docs/#core/components/tooltip
https://material.io/guidelines/components/tooltips.html
https://material-ui-next.com/demos/tooltips/
https://developer.microsoft.com/en-us/fabric#/components/tooltip
https://vmware.github.io/clarity/documentation/tooltips
http://carbondesignsystem.com/components/tooltip/code
https://www.lightningdesignsystem.com/components/tooltips
https://polaris.shopify.com/components/overlays/tooltip#navigation
https://www.predix-ui.com/#/elements/px-tooltip

http://356-tooltip--mineral-ui.netlify.com/components/tooltip/


Question: Why should we use container?

In https://github.com/aliyun/plugsched#quick-start, some operation is done in container?
Why is it?

I' so sorry.
I haven't read README.md.


[Website] Coverage percentage seems incorrect

Summary
It's not clear how the coverage is computed:

When I set the depth to 1, I end up with 142 boxes covered and 224 boxes not covered. I would expect to see a coverage percentage of 142/(142+224)~= 38.8% (instead of 63.39%). Same for depth=2, ...
The page should indicate the formula used to compute the coverage.
Steps to reproduce

Open the Website
Go to coverage report
select a depth and compare the box numbers with the given percentage

You are right. I think that just went over my head. The design of coverage page header needs some work for sure.
https://github.com/MPEGGroup/FileFormatConformance/blob/62936f54e42c78d719a94d226185795cbb45eb30/conformance-search/src/pages/CoveragePage.tsx#L97-L101


Cleveland dot plot styles

Need style guidelines

Also tagging @amfeldman to this issue since I can't properly assign it to her for some reason


Tag stable releases more frequently

The most recent tagged release is not up to date with what is included in the current Docker for Mac Stable release. It'd be great if releases could be tagged when commits are considered stable. Without tagged releases the Homebrew version gets out of date. It also makes it hard to figure out a reasonably stable, but up to date, point at which to build the source from.

A new release is out

Could make a new release please ?
I wanted to create a Port in Macports, but it requires a release and cannot build with head as in Homebrew.


rive-js - Cannot set property '_updateLayout' of undefined

Hi, I am trying to use rive-js into my vue component.
I added rive-js ad dependency

I imported Rive class from module

Then when the Vue component is mounted I'm doing this

And this happens

Am I doing something wrong?

Thanks for letting us know; we'll take a look and respond shortly.

I'm not very familiar with Vue; how ever I created a simple Vue app to test things out.
This is in this PR: #74
From your code snippet I see that you're not new-ing Rive. Can you try changing to the following:
this.rive = new Rive({
  src: 'https://cdn.rive.app/animations/off_road_car_v7.riv',
  canvas: document.getElementById('my-canvas'),
  autoplay: false
});

Well, I'm a little embarassed now!
I forgot how to instantiate a class, LOL.
Thank you very much, I'll try in the proper mode :)
Sorry for the unappropriate issue.

No worries; happy to help.


Remove toolchain

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.

you can remove the "if toolchain" block too in meta.yaml

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

LGTM


建立全新的前端介面

目標作出更簡潔的前端

可參考的Theme

XPoet/hexo-theme-keep: A simple and elegant theme for Hexo. It makes you more focused on writing.
LouisBarranqueiro/hexo-theme-tranquilpeak: A gorgeous responsive theme for Hexo blog framework
ppoffice/hexo-theme-icarus: A simple, delicate, and modern theme for the static site generator Hexo.
fluid-dev/hexo-theme-fluid: 一款 Material Design 风格的 Hexo 主题 / An elegant Material-Design theme for Hexo
hexojs/hexo-theme-landscape: A brand new default theme for Hexo.


New static interfaces for Configure(HttpChain) & Configure(IChain) & Configure(HandlerChain)

Wasn't possible before, now is. Just a convenience.

Doesn't work the way I was envisioning, nobody cares anyway:)


BUG-7236 Fixes typo leading to less-sensitive Centralite multi-sensors

Original DTH was setting this value at 0x02 whereas the driver was configuring it to 20, leading to an order of magnitude-higher acceleration threshold.

Original line from DTH that was duplicated incorrectly and led to this error:
https://github.com/SmartThingsCommunity/SmartThingsPublic/blob/master/devicetypes/smartthings/smartsense-multi-sensor.src/smartsense-multi-sensor.groovy#L415

Is this one of those typos that has been copy pasted from another place? IIRC we have some user reports of acceleration/multi-sensors not reporting any events for a few different models.

Is this one of those typos that has been copy pasted from another place? IIRC we have some user reports of acceleration/multi-sensors not reporting any events for a few different models.

I just checked the other models and the configs seem correct. They all have a different config flow.


toolchain: add nonnull attribute macro

Add a new macro to declare that certain parameters should be non-null. When NULL is passed to these non-null declared parameters a warning is generated.
Starting using this macro in k_heap_free and k_heap_aligned_alloc.
Inspired in https://github.com/zephyrproject-rtos/zephyr/pull/64159

I had no idea this attribute existed--very cool! However, I have two comments about the proposed change.

Inconsistency in naming--unlike the other attribute macros (such as __weak or __unused for example), this one contains the string attribute.
I suspect that this documentation build error would be a recurring issue unless we are able to find some way to resolve it. I am guessing that that build error stems from the documentation tool misinterpreting the macro parameters.

I had no idea this attribute existed--very cool! However, I have two comments about the proposed change.

Inconsistency in naming--unlike the other attribute macros (such as __weak or __unused for example), this one contains the string attribute.

Yep, initially I have used __nonnull, but that conflicted with something defined in picolibc :/

I suspect that this documentation build error would be a recurring issue unless we are able to find some way to resolve it. I am guessing that that build error stems from the documentation tool misinterpreting the macro parameters.

I will check the error, I just sent it out to get some early feedback whether or not that was interesting. I have more functions using it. Will fix the documentation issue and move this to a pr.


Example App Broken?

It doesn't seem to work like before, nothing updated when input.
https://github.com/rodydavis/preact_signals.dart/assets/25608913/cdee61f3-92d5-4660-a881-3b8a856a38b3

Error:
main.dart.js:2722
 Uncaught RangeError: Maximum call stack size exceeded
    at aj.N (main.dart.js:2722:1)
    at aj.N (main.dart.js:2724:6)
    at aj.N (main.dart.js:2724:6)
    at aj.N (main.dart.js:2724:6)
    at aj.N (main.dart.js:2724:6)
    at aj.N (main.dart.js:2724:6)
    at aj.N (main.dart.js:2724:6)
    at aj.N (main.dart.js:2724:6)
    at aj.N (main.dart.js:2724:6)
    at aj.N (main.dart.js:2724:6)

Gotcha, need to update the web one, was updating the flutter one and didn't go back.
Thanks for the issue!

Web example fixed!


Can't connect to ap

As in topic can't connect to my ap ecu-r:
https://share.merce.com/files/XgQpEtm1oo.png
Sunno what means the err msg.

have you tried this? https://github.com/ksheumaker/homeassistant-apsystems_ecur/discussions/55

I understand that. I've got configured all. My ip is set https://share.merce.com/files/YcCxRhXzzv.png and online. but ports are closed :(
(☸ |prod:kids51015) b-code@bcode-XPS  ~/workspace/amba/ratelimit   main  nmap <IP_ADDRESS> Starting Nmap 7.80 ( https://nmap.org ) at 2022-03-09 17:13 CET Nmap scan report for <IP_ADDRESS> Host is up (0.0022s latency). All 1000 scanned ports on <IP_ADDRESS> are closed
Maybe it's becouse I've got model with zigbee?
https://thepowerstore.com/apsystem-ecu-residential-monitoring-gateway-zigbee-comm-wifi-no-cts-no-rgm-yc600-sku-part-number-ecu-r-gateway.html

No, Zigbee is not the issue - the ECU communication with inverters is zigbee (in mesh network if you've got multible inverters). You only scanned the first 1000 ports? The apps use port 8899 to communicate with the ECU-R. Try: nmap <IP_ADDRESS> -p 8899

tried also port:
(☸ |prod:partnertele) b-code@bcode-XPS  ~/workspace/amba/ratelimit   main  nc -zv <IP_ADDRESS> 8899
nc: connect to <IP_ADDRESS> port 8899 (tcp) failed: Connection refused
:(

Does Packet Sender work for you or are you on MAC?

Tried it already, no luck :(
https://share.merce.com/files/fIwDgz6avZ.png
PS. Restarted router so there is now ip from dhcp ;]

And using ubuntu 21.10.

So your ECU now got <IP_ADDRESS> due to DHCP instead of <IP_ADDRESS> - it's weird you're not able to connect. Not even with Packet Sender. I wonder if there's something in your network preventing a connection, are you able to ping the ECU? Did you allready powercycle the ECU? What is your firmware version (visible when using the ECUapp).
I'm able to connect:

ping is fine:
(☸ |prod:partnertele) b-code@bcode-XPS  ~/workspace/amba/ratelimit   main  ping <IP_ADDRESS> PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data. 64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=255 time=3.87 ms 64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=255 time=1.60 ms 64 bytes from <IP_ADDRESS>: icmp_seq=3 ttl=255 time=3.70 ms 64 bytes from <IP_ADDRESS>: icmp_seq=4 ttl=255 time=1.38 ms 64 bytes from <IP_ADDRESS>: icmp_seq=5 ttl=255 time=0.996 ms ^C --- <IP_ADDRESS> ping statistics --- 5 packets transmitted, 5 received, 0% packet loss, time 4007ms rtt min/avg/max/mdev = 0.996/2.306/3.865/1.219 ms (☸ |prod:partnertele) b-code@bcode-XPS  ~/workspace/amba/ratelimit   main  nc -zv <IP_ADDRESS> 8899 nc: connect to <IP_ADDRESS> port 8899 (tcp) failed: Connection refused
What do u mean "powercycle the ECI?"
Hmm I cant find that workspace on my app.
All i've got is:

You have firmware 1.2.20 also (like I have). The IP <IP_ADDRESS> is bound to you LAN (ethernet/cabled) connection. Using this connection is not possible, port 8899 is not open on the ethernet NIC. What is the WiFi IP-address on the ECU? Configure and use that.

Gr8 its working now!, thans a lot. Wlan has other mc address so other ip was given. Need to scan all ips and find one with 8899 port open. Now it working. Thanks again! ;]

No problem, glad I could help. Please mark the post as answered so this issue can be closed.

Yes correct, wireless only will do as well.

Yes correct, wireless only will do as well. But keep in mind that both interfaces each use a different IP-address. So make sure you enter the correct one in the integration's settings.

Ok, thank you. I have to wait for some info from my supplier, before I can login with the app, etc. I will wait for that info and connect the AP to my WiFi network.


fix: ADO pushes to correct branch & BB create PR link update

Why does this PR exist?
Closes #3067
Users were unable to push changes to ADO when not using their main branch
What does this pull request do?

Fetches the last commit ID based on the ADO branch selected in the plugin
Fixes BitBucket PR creation URL
Adds safety rel tag on create URL CTA

Testing this change

Set up an Azure DevOps repository
Select another branch that's not main
Make some changes
Push the changes
See the changes in the remote!

🔨 ⏳ Fixing unit tests...

🔨 ⏳ Fixing unit tests...

Unit tests updated ✨

🤕 ⚠ TODOs

Broken test due to extra calls made to check for existence of branches. Implementation needs to be mocked 2 more times

Added check here: https://github.com/tokens-studio/figma-plugin/pull/3071/files#diff-9c09f6f6166ed1dbb988bae2c8ea686addd480a634e5ed523b29e3504b8df005R436
Broken test here: https://github.com/tokens-studio/figma-plugin/pull/3071/files#diff-8e1abeb5ecae0505e33870d1545e63135ef5b2396ed197fa6217eb7bd542c62aR303

Testing that other providers are not affected by the ADO changes, specifically:

Pushing to different branches
Changing for single to multifile


Fix Mixed-content issue when on cart page with SSL

This PR fixes an issue when we enable the SSL partially on PrestaShop and we try to modify our cart before checkout.

Thank you @Quetzacoalt91


Add node_modules/ to .gitignore

Also create a .gitignore file, if one does not already exist.

cat "node_modules/" >> ".git_ignore"

FWIW ignore lines like this should be within a global gitignore, rather than a project level.

@jbrooksuk Agreed. But is there a problem with having it on a project level as well? Just in case users don't have it defined on a global level.


Some remote connections are non-removable

Note how two out of three connections in the Remote section have delete icon disabled. When hovering over it, the tooltip gives the usual message about auto-detected R etc.
These connections were created on an earlier build, however.

They might not had IsUserCreated flag set in settings in earlier builds. There is an issue that we just serialize class into settings so when it changes new fields are not populated.

No longer applies since we changed connection storage.


please add Browser usage documentation

Hi
Thanks for your hard work. Not really an issue, but since the project is targeted (among others) at browser usage, could you please add even just some small browser code sample to get us started?
Thanks!

Great suggestion! I’ll do that — hopefully this week.In the meantime you can look at the code in the [index.html][1] demo which links in demo/web_v4][2] [1]: https://github.com/shanewholloway/js-u8-mqtt/blob/master/index.html[2]: https://github.com/shanewholloway/js-u8-mqtt/blob/master/demo/web_v4.mjsOn Jan 2, 2023, at 4:33 AM, ilgrank @.***> wrote:
Hi
Thanks for your hard work. Not really an issue, but since the project is targeted (among others) at browser usage, could you please add even just some small browser code sample to get us started?
Thanks!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Added Use heading to README in v0.3.0.
Also add copyable web-cdn, web bundler, NodeJS, and deno examples.


Support of "virtual" components in Power Pages portals

I believe "virtual" components with "React controls & platform libraries" ARE supported in Power Pages portals.
I've been using it so far with no issues.
The section "Q: Can I use React controls & platform libraries with portals?" seems to say otherwise.
https://learn.microsoft.com/en-us/power-apps/developer/component-framework/react-controls-platform-libraries#q-can-i-use-react-controls--platform-libraries-with-portals
Is this page up-to-date?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e32fb155-ff17-ca62-1aae-e58b5101a155
Version Independent ID: e32fb155-ff17-ca62-1aae-e58b5101a155
Content: React controls & platform libraries (Preview) - Power Apps
Content Source: powerapps-docs/developer/component-framework/react-controls-platform-libraries.md
Service: powerapps
Sub-service: pcf
GitHub Login: @HemantGaur
Microsoft Alias: hemantg

Thanks for your comment, @jsnl85. This issue has been assigned to the doc author for review.

@HemantGaur
Any comment about this?
Q: Can I use React controls & platform libraries with portals?

A: No. React controls & platform libraries are currently only available for canvas and model-driven apps.

The article hasn't been updated since last February.

@jsnl85
I checked with the dev team and updated the page. It now says this:

Q: Can I use React controls & platform libraries with Power Pages?
A: No. React controls & platform libraries are currently only supported for canvas and model-driven apps. In Power Pages, React controls don't update based on changes in other fields.

While they are 'available', they aren't supported.


Bug: Doesn't work with flatpak obsidian :(

Describe the bug
After manual installation, the plugin is displayed in the list of community plugins, but when it is enabled, an error occurs.

Step to reproduce
I moved the main.ts, styles.css, manifest.json files to /.obsidian/plugins/obsidian-canvas-view, tried renaming main.ts to main.js and transfer all cloned files but still doesn't work.
Expected behavivor
Work after enabling plugin in community plugins tab
Additional information
Flatpack obsidian is maintained by the flatpack community, so it's possible that the problem is only with my version of the program and maybe I should just wait until your plugin appears in the community plugin list, but I decided to leave this report anyway. Xubuntu 22.04.2 LTS
Sorry for any mistakes in creating an issue, this is my first time using github...

Hi @alexivlao
I think the problem is due to some of your wrong step
you should download the main.js(not main.ts from the source code), styles.css, manifest.json from the latest release, then put them into /.obsidian/plugins/obsidian-canvas-view.
If you prefer to install manually, you can git clone the source code into /.obsidian/plugins/obsidian-canvas-view and run npm install, npm run dev in the same dir.
Have a try :)

Renaming the main.ts to main.js is not work, the javascript file should generate from typescript file by npm


Add techtree method in init, that return a dictionary with technology…

…, supply and facility necessary to obtain it.
Sorry for bad camelcase and variable'names...

Done, if it's good....

End of bugfixes and abandon of treetech...

End of bugfixes and abandon of treetech...

thx. for your work. im starting to i tegrate your techtree into the lib

thx. for your work. im starting to i tegrate your techtree into the lib

Thx for you ^^

Tests are all passing
test_Constants (ogame.test.UnittestOgame) ... ok
test_Events (ogame.test.UnittestOgame) ... ok
test_Vars (ogame.test.UnittestOgame) ... ok
test_ally (ogame.test.UnittestOgame) ... ok
test_build (ogame.test.UnittestOgame) ... ok
test_celestial (ogame.test.UnittestOgame) ... ok
test_celestial_coordinates (ogame.test.UnittestOgame) ... ok
test_defences (ogame.test.UnittestOgame) ... ok
test_facilities (ogame.test.UnittestOgame) ... ok
test_fleet (ogame.test.UnittestOgame) ... ok
test_galaxy (ogame.test.UnittestOgame) ... ok
test_moon_facilities (ogame.test.UnittestOgame) ... ok
test_phalanx (ogame.test.UnittestOgame) ... ok
test_research (ogame.test.UnittestOgame) ... ok
test_resources (ogame.test.UnittestOgame) ... ok
test_send_fleet (ogame.test.UnittestOgame) ... ok
test_send_message (ogame.test.UnittestOgame) ... ok
test_ships (ogame.test.UnittestOgame) ... ok
test_spyreports (ogame.test.UnittestOgame) ... ok
test_supply (ogame.test.UnittestOgame) ... ok

----------------------------------------------------------------------
Ran 20 tests in 35.679s

OK

Process finished with exit code 0


python3 -m venv venv returns error

Problem Description
I get the error message after this command:
python3 -m venv venv
If be honest, I don't know exactly the reason for that, but maybe the first answer to this can be the reason?
Steps to reproduce the behavior:
./dev.sh
+ echo 'Creating dev environment in ./venv...'
Creating dev environment in ./venv...
+ python3 -m venv venv
Error: Command '['/home/user/Documents/github/mitmproxy/venv/bin/python3', '-Im', 'ensurepip', '--upgrade', '--default-pip']' returned non-zero exit status 1.

System Information
Python 3.7.4
x86_64 GNU/Linux 5.3.12-1-MANJARO

What's the output of the following commands on your system?
python3 --version
python3 -m pip --help
python3 -m venv --help

[user@thinkPad ~]$ python3 --version
Python 3.7.4
[user@thinkPad ~]$ python3 -m pip --help

Usage:
  /usr/bin/python3 -m pip <command> [options]
...

[user@thinkPad ~]$ python3 -m venv --help
usage: venv [-h] [--system-site-packages] [--symlinks | --copies] [--clear]
            [--upgrade] [--without-pip] [--prompt PROMPT]
            ENV_DIR [ENV_DIR ...]

Creates virtual Python environments in one or more target directories.
...

Thanks. This looks like a problem with your Python installation and not mitmproxy. I'm sorry, but I'm afraid we can't be of much help here!


[Bug] Failed to parse Markdown file, mdast-util-definitions expected node

Please provide the environment you discovered this bug in.

Node: v18.19.0
@analogjs/astro-angular: 0.2.29
@angular/compiler: 17.0.9
@astrojs/starlight: 0.15.3
astro: 4.0.1

Repo: https://github.com/runyasak/my-analog-starlight
Which area/package is the issue in?
astro-angular
Description
Hello analog contributors!
First, I want to say that this project is very amazing and I've followed for long time.
Thank you for your great work. 😁
Overview
I initiated Astro Starlight theme project, installed with astro-angular, and ran dev.
Then, the error appeared on the screen:

After that, my web crashed and could not work.
I've tried to install with Astro CLI and manual installation, the results are the same.
Expected Result
My web should be worked fine with astro-angular.

If you have any feedback or suggestions, please let me know.
Please provide the exception or error you saw
[ERROR] Cannot read properties of undefined (reading 'hidden')
  Stack trace:
    at /my-starlight/node_modules/.pnpm/@astrojs+starlight@0.15.3_astro@4.1.1/node_modules/@astrojs/starlight/utils/navigation.ts:176:44
    [...] See full stack trace in the browser, or rerun with --verbose.
[WARN] [router] A `getStaticPaths()` route pattern was matched, but no matching static path was found for requested path `/favicon.ico`.

Possible dynamic routes being matched: node_modules/.pnpm/@astrojs+starlight@0.15.3_astro<EMAIL_ADDRESS>[ERROR] Failed to parse Markdown file "/my-starlight/node_modules/.pnpm/@astrojs+starlight@0.15.3_astro<EMAIL_ADDRESS>mdast-util-definitions expected node
  Stack trace:
    at definitions (file:///my-starlight/node_modules/.pnpm/mdast-util-definitions@6.0.0/node_modules/mdast-util-definitions/lib/index.js:33:11)
    [...] See full stack trace in the browser, or rerun with --verbose.

### Other information

I need to change `typescript` version to `5.2.2` because Angular does not support `5.3.3` or the latest version for now.

### I would be willing to submit a PR to fix this issue

- [ ] Yes
- [X] No

This is due to a known incompatibility between Astro's Remark Shiki plugin and Zone.js. Unless another solution or workaround comes along, we'd have to wait for zoneless.
https://github.com/withastro/astro/issues/8611

Thanks @rlmestre. I thought the Astro plugin automatically warned about this?

Yes, but the current check only considers the configuration of the markdown plugin. This example is using Starlight, and it seems that handles its own markdown config internally. I can look into improving detection to show the warning.

Hi @rlmestre @brandonroberts,
Thank you for taking care of my issue.
I am looking forward to using Angular with Astro by analog. 😁

I opened an issue in the repo for the dependency that's causing the issue. Unfortunately, I think it's a long shot, but we'll see.
The good news is we finally have a root cause and it doesn't seem to be as big of a deal as native async/await conflicts with Zone. The bad news is we'll continue to run into packages that use async plugins or transformers causing these issues. In this case it's Starlight's expressive code.
You can disable expressive code by passing false to the property in starlight's astro.config:
import { defineConfig } from 'astro/config';
import starlight from '@astrojs/starlight';
import angular from '@analogjs/astro-angular';

export default defineConfig({
  integrations: [starlight({
     expressiveCode: false,
     ...
  })],
});

@brandonroberts do we want to add a warning and/or override for this particular one as well?

My issue/PR were accepted, so the issue has been fixed upstream! To fix it "the right way", we need to wait for the dependency to be updated in unified and then Astro. If you want to try it now, you can override the package:
  "pnpm": {
    "overrides": {
      "trough": "2.2.0"
    }
  }


Apple sign in support?

Feature request
Will gotrue-dart add apple provider support? I noticed that https://github.com/supabase/gotrue/pull/102 is merged into the supabase/gotrue repo.
Is it just a matter of updating the Provider enum to include apple? (Sorry this is my first few hours using supabase) If so, I can make PR for it.

@talmr-k I solved with #24

Thanks @HarryET


sleep state - run idle scripts and allow to control the backlight

The idle scripts are not executed when the sleep state changes based on the system timer. Make things consistent.
EDIT: Added second patch to allow set the dimming values per idle states using web server.

As you like, but I think that this is really common settings, so it belongs to the http config ui. Removed the second patch, let me know, if you like to do a separate PR.


Multi-Dimensional Fourier Series Dataset

This PR extends the existing Cosine Dataset by allowing an arbitrary shape of input data defined by the shape of the frequencies specified in parameters_preprocessing.yml.
In case of two dimensions, the framework treats the data as image.

[x] implement proof of concept
[x] validate that nothing brakes with n_dim>2
[ ] remove padded additional dimension in image dataset and cosine dataset

Hello @stroblme! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/quantum_siren/pipelines/training/nodes.py:

Line 301:89: E501 line too long (103 > 88 characters)

At this point, it's really just for showing off..


Various fixes for idempotency, error messages and concurrency

fix(grpc/snapshot): snapshot grpc should use replica svc

We should not allow concurrent snapshot and replica operations as they might clash.
todo: allow per-resource locking
Furthermore it was observed that holding a bdev ptr whilst it's being deleted might
cause a crash, we need to determine if this was to do with it being held over an
async point, or a more general problem.

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

ci(test/wipe/replicas): allow list and wipe replicas

System test is using wipe replicas, which can block list calls from the control-plane
and thus confusing it thinking the node is not responding.
Let's allow concurrent wipe with lists, since wiping doesn't destroy or modify
replica metadata anyway.

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

fix(io-engine/client): fix cli args

Some args were not setup correctly since clap update.

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

fix: bad error message

ChildNotFound error had an invalid error message.
Don't output NotFound messages for ptpl.

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

fix(lvs/status): fixup missing bdev errors

Allows the control-plane to determine what the inner error was.

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

bors merge

bors cancel

bors merge

bors merge


doc: document PackManifestOptions to make PackManifest reproducible

Resolves #748

BTW, the PR title should start with docs (end with s) as per the conventional commit guidance. 😀

We also need to rephrase the related comment a bit for ExamplePackManifest_imageV10 and ExamplePackManifest_imageV11 in example_pack_test.go.

updated the comments  in example_pack_test.go.


Front end fixes

Coverage remained the same at 28.851% when pulling 06e9d8682a2bcd217a28bb504597cf037bcf4d54 on alioso:front-end-fixes into ed6222841e17caed61b8494b3b1aee6203337c8f on linode:develop.


[Flink AI Flow] CeleryExecutor may run task instance multiple times

Describe the bug

Your environment
Operating system

Database

Python version

To Reproduce
Steps to reproduce the behavior (if you can):

Submit a '...'
Click on '....'
See error

Expected behavior

Actual behavior

Screenshots

Additional context

Fixed in https://github.com/alibaba/flink-ai-extended/pull/598


JSON Enabled function returns Error when Empty value is passed

After the adding JSON support for Java Fn function, if the function is passed an empty value, Fn returns:
{"message":"container exit code 2"}

Fn: Error calling function: status 502

The function does work with JSON data. If you pass:
{"name":"Bob"}

or even
{"name":""}

the function works fine. Tried modifying the function to test for null and isEmpty. Nothing like that worked. I'm guessing the function is throwing an uncaught exception.
May be related to 392 or 1192
Mike W.

The error is pretty clear that an attempt to convert null to an an object failed.  Null input should result in a null object passed to the function handler.
{ "message":"Unhandled internal error in FDK", "detail":"An exception was thrown during Input Coercion: Failed to coerce event to user function parameter type class com.example.fn.HelloFunction$Input"}

What is the status on this issue?


Correction in browser command for linux system.

Opening google chrome command has been corrected as well README.md file
has been updated with a new entry in requirements section. To scale
future dependencies requirements.txt file is added.

Thanks for your contribution.
May  I know what you change you have done in browser command?

Thanks for your contribution.
May I know what change you have done in browser command?

The google-chrome needed a space for it to be a valid command. Also there was no need for the start chrome statement in the end of the first if condition. Also it for proper user input all the extra spaces and tabs were to be removed.

Oke Thanks


az webapp log download ssl error

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az webapp log download
Errors:
The command failed with an unexpected error. Here is the traceback:
HTTPSConnectionPool(host='pace-prd-eastasia-api-app.scm.ase1-int-hkhk-cbre-prod.cbrecloudapps.com', port=443): Max retries exceeded with url: /dump (Caused by SSLError(SSLError("bad handshake: Error([('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')])")))
Traceback (most recent call last):
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/contrib/pyopenssl.py", line 498, in wrap_socket
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\OpenSSL/SSL.py", line 1915, in do_handshake
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\OpenSSL/SSL.py", line 1647, in _raise_ssl_error
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\OpenSSL/_util.py", line 54, in exception_from_error_queue
OpenSSL.SSL.Error: [('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 699, in urlopen
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 382, in _make_request
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 1010, in _validate_conn
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connection.py", line 416, in connect
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl_.py", line 449, in ssl_wrap_socket
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl_.py", line 493, in _ssl_wrap_socket_impl
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/contrib/pyopenssl.py", line 504, in wrap_socket
ssl.SSLError: ("bad handshake: Error([('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')])",)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 231, in invoke
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 663, in execute
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 726, in _run_jobs_serially
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 697, in _run_job
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 333, in __call__
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 121, in handler
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2574, in download_historical_logs
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/appservice/custom.py", line 2594, in _get_log
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/request.py", line 74, in request
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/request.py", line 96, in request_encode_url
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/poolmanager.py", line 375, in urlopen
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 783, in urlopen
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 783, in urlopen
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 783, in urlopen
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 755, in urlopen
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/retry.py", line 574, in increment
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='pace-prd-eastasia-api-app.scm.ase1-int-hkhk-cbre-prod.cbrecloudapps.com', port=443): Max retries exceeded with url: /dump (Caused by SSLError(SSLError("bad handshake: Error([('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')])")))

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az webapp log download --name {} --resource-group {}

Expected Behavior
Environment Summary
Windows-10-10.0.19042-SP0
Python 3.10.5
Installer: MSI

azure-cli 2.38.0 *

Additional Context

route to CXP team

Hi @kkantedi,
Looks like I was not able to reproduce from my end.
Environment

azure-cli 2.39.0
core 2.39.0
OS: Windows 11
Windows Terminal: Powershell

After running az webapp log download --name MyWebApp --resource-group MyResourceGroup, it created a zip file containing the web app logs.
https://user-images.githubusercontent.com/38049078/184916131-92904035-4466-4106-9270-bf1c26557b0c.mp4
Steps I took:

Created an azure app service
In my local environment, I ran az webapp log download --name MyWebApp --resource-group MyResourceGroup

This error looks interesting:
Max retries exceeded with url: /dump (Caused by SSLError(SSLError("bad handshake: Error([('SSL routines',
Were you able to run the command before or are you facing this issue suddenly?

Here is the screenshot,

@kkantedi Thanks for reaching out to us and reporting this issue. Could you please confirm if you have any proxy / firewall within your network ? If Yes, could you please try the same command from a different network and test ?
Alternatively, Could you also test the same command by running it from the Cloud shell and isolate this issue to be with your network ?

@kkantedi I wanted to do quick follow-up to check if you had a chance to look at my above comment. Please let us know if you  had any update on this. Awaiting your reply.

@kkantedi The action is currently pending on you to try the above action plan and get back to us with an update. If you need any further assistance on this issue in future, please feel free to reopen this thread. We would be happy to help.


Fix typo in examples of registry config

[plugin. -> [plugins.
Signed-off-by: shouhei<EMAIL_ADDRESS>

I reopen at https://github.com/containerd/containerd/pull/4620 .


Layers do not renderer

When a map has a layer something like this:
<Layer type="symbol" id="marker" layout={{ 'icon-image': 'school-15' }}>
        <Feature coordinates={[-98.978340, 42.539770]} />
</Layer>
The layer does not render, this is because commit 4926e492cef3a77e57a8cdf7594e9340d499392e changed layer.ts's UNSAFE_componentWillMount to componentDidMount.  With that change, render is called before initialize.  Since on the initial render, the source is not defined, source.setData(...) is not called.
If something else triggers a render, like calling setState({}), the layer will pop in.
Suggested Fix
I think creating a constructor for the Layer class and calling this.initialize() in the constructor (rather than in componentDidMount will fix this issue.

This seems like a pretty big issue. Does that mean you currently can't use this lib to show data?

I got around this by adding setState({}) on a short timer as I mentioned in the issue.  Not ideal, but it works.  I just wanted to document the issue.


make pepr controller (Watch()) scalable and fault tolerant

###problem
Right now, the pepr controller handles all the Watch() actions, which is a single pod, so depending on the user's implementation of their callbacks could cause a slow down and unbalanced pod resource usage.
Describe alternatives you've considered

have the controller not actually execute the callbacks but call the pepr callback in the deployment (advantage: better distribution of load, disadvantage: an extra network hop). Keep the controller in typescript or rewrite the controller in golang (doesn't actually solve a problem unless there are scaling issues with the IO in typescript monitoring kubernetes object modifications)
build a fault tolerant model for the controller which would require some sort of leader election (this is heavy weight, and not necessarily helpful since kubernetes will always send the current state of the object as the first message of a watch).
read from the audit log, which shouldn't lose any intermediate events persisted to etcd. (this is cumbersome, but keep the idea alive in case we need it for potential customers)

Completed in https://github.com/defenseunicorns/pepr/pull/453


enhancement remove unnecessary decimal cast

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.22 seconds
load time: 571 seconds
storage size:<PHONE_NUMBER>2 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221028014226_clickbench_pr_34965.html


Calling adapty.activate in a simulator triggers the login request

Description
Hey!
I just updated from v1 to v2.4.2 and I see the login screen pop up as soon as I call adapty.activate(config.ADAPTY_PUBLIC_KEY).
As in a simulator I would never be logged in, it's very annoying. Not sure about real users, but it's worrying. Never had this problem with v1.

Version
v2.4.2
What platforms are you seeing the problem on?
iOS
System info
IDEs:
    Xcode: 14.2/14C18 - /usr/bin/xcodebuild

npmPackages:
    react: 18.1.0 => 18.1.0
    react-native: 0.70.3 => 0.70.3

Hey, @amberv0! SDK v2 works a lot way differently under the hood. To keep user info fresh it scans his/hers receipts on activation, meaning checking whether user has purchased a product from within the AppStore or cancelled his active subscription.
This check requires SDK to authorize request to App Store APIs, thus this authorization modal.
While we do not plan on changing this logic in v2, we have noticed how irritating the appearing of this modal in simulator is. There soon would be an update that would provide you a had for to disable this check for emulators
Thank you for pointing out this problem 💪

Hey @divanc! Thanks for the very fast response!
Good to know this is going to be handled soon :)
I still think this is a problem though, since not having an appleId is a valid scenario (though maybe rare). Isn't there a way for you to check whether there is a logged in user on a device, and if not, well, there is definitely no user info to refresh?

I'm not sure, that there could be no App Store user if that is what you mean.
In order to download an app you need an account, and that very same account would be used for this app regardless, whether you log out or not.
While debugging on a simulator, Apple chooses to drop your session every time (in case you want to check different accounts), that is the only way, I believe, to be accountless
@amberv0

True, I think you are right. While it's possible to use iphone without apple id, I think it's indeed impossible to install an app without logging in.

I'll keep this issue open and inform, when native team will be ready to release this thing. Still, marked as in progress...

+1 this is very frustrating while developing locally. Every time the app reloads, I need to dismiss this popup.

Just upgraded, and now it says a person must sign in even though they are already signed in? This is done on an iPad.

@dragonfire1119
On a real device? You can add your sandbox account in App Store settings. This way it shouldn't ask you every time.
On a simulator it is a different story...
For everyone, I'm currently holding rounds of discussions with native developers. For now we haven't decided how we can approach this problem without raising some occasional unexpected behavior.
I'll let you guys know when we decide something ASAP, pinging them today

@divanc
Thank you for responding. Confirming that this is a user. They receive a prompt to sign in even though they are already signed in. This issue seems to be occurring only on an iPad, not an iPhone, but I am investigating further. I am unable to update at the moment as it may cause inconvenience to non-testers. What's peculiar about this issue is that it is not consistently replicable on a physical device. The previous version of this library did not have this problem.

In v2.6.0 (with breaking changes) I've added __debugDeferActivation as a workaround for this problem. In the new docs, I've also written why it is currently the picked solution.
We were unable to arrange any viable solution on a native side. Authentication flow is triggered by Apple and we cannot control, when it is shown or what data is inside it...
Considering real-device auth, it should also not be due to any Adapty SDK functionality. Apple might choose to prompt user if he has authenticated with different account, than what he/she had used when downloading app. We spent a lot of time discussing this and testing with native team...
I'll close this issue for now, please re-open if you believe, there is a better way to resolve this issue


White screen

Unable to use the app:

App starts, but goes white after displaying logo.
It started to bahave this way week ago? like after Safari 12.0 and Chrome 69 - where they (at least Safari) changed plugins policy (not sure it is related).
Installing from scratch does not help.
Dev console does not show anything.
If logged out, app opens FB window to login - after successful login, it goes white.
Messages indicator works (shows number on the icon correctly).

OS: 10.13.3
Goofy: 3.3.1

Unfortunately it does not, I already tried it.

I use appClean to completely remove goofy then reinstall.It works for me.

what's appClean?

http://freemacsoft.net/appcleaner/

it worked with it, thank you


Health -> Graph View -- Stats not refreshing

Under Health-->Graph View, the current bandwidth and connections should update every 30 seconds.  This is not happening.

whoa, number 1000!


no simmetry in eigenvectors from tridiagonal matrix

When computing eigenpairs from tridiagonal matrices, the outcoming  eigenvectors from opposite eigenvalues show no symmetry unlike in Wolfram Mathematica. This does not occur if the non-zero bands have all the same elements.
Reproducing code example:
import numpy as np
from scipy.linalg import eig, eigh, eigh_tridiagonal, eigvalsh_tridiagonal, eigvalsh
d = np.zeros(6) # diagonal filled with zeros
e = np.array([1.   , 2., 1.   , 1.   , 2.]) # off-diagonal hopping matrix elements
#e = np.ones(5)
A = np.diag(d) + np.diag(e, k=1) + np.diag(e, k=-1)
#w, v = eigh_tridiagonal(d, e)
w, v = eigh(A)
w # eigenvalues
array([-2.53646696, -2.10377251, -0.3748021 ,  0.3748021 ,  2.10377251,
2.53646696])
v[0] # first eigenvector
array([ 0.20436012, -0.1973713 ,  0.64751951,  0.64751951, -0.1973713 ,
0.20436012])
v[5] # symmetric of first eigenvector
array([-0.30536004, -0.55980393, -0.30557292,  0.30557292,  0.55980393,
0.30536004])
Scipy/Numpy/Python version information:
import sys, scipy, numpy; print(scipy.version, numpy.version, sys.version_info)
1.3.1 1.16.2 sys.version_info(major=3, minor=7, micro=3, releaselevel='final', serial=0)

Hi @jalfonsi Thank you for taking the time to report it. In numpy arrays you have to use a different indexing to look at the columns
If you instead type for the first and the last columns
>>> v[:, [0, -1]]  # v[:, [0, 5]] is also fine, -1 means the last one
array([[ 0.20436012,  0.20436012],
       [-0.5183527 ,  0.5183527 ],
       [ 0.55521219,  0.55521219],
       [-0.37157197,  0.37157197],
       [ 0.38726783,  0.38726783],
       [-0.30536004,  0.30536004]])

you will get the corresponding eigenvectors.


VDW Radius Lookup Values?

Description:

RDKit Version: 2017.09.3
Platform: MacOS; python3.6

I am wondering why the PeriodicTable.GetRvdw() (vdw radius) lookup produces values that differ so much from other sources. The values for C, N & O are compiled here:
atom:  | rdkit | wikipedia
C: | 1.95 | 1.70
N: | 1.85 | 1.55
O: | 1.70 | 1.52
The wikipedia values can be confirmed elsewhere on the web including in rdkit's own FreeSASA module where the radii agree with wikipedia (https://github.com/mittinatten/freesasa/blob/master/src/classifier.c)

PeriodicTable.GetRvdw(rdkit.Chem.GetPeriodicTable(),6)
PeriodicTable.GetRvdw(rdkit.Chem.GetPeriodicTable(),7)
PeriodicTable.GetRvdw(rdkit.Chem.GetPeriodicTable(),8)

The title of this entry should be "VDW Radius Lookup Values?" not "DSW...."
I'm still learning how to type apparently.

The origin of the RDKit values is, unfortunately, "lost in antiquity".
Updating these values to something that has a reference would be a nice enhancement for a future RDKit version.

For your information, in 3d descriptors dragon, i have to include new versions based on Dragon.
Envoyé de mon iPhone

Le 20 avr. 2018 à 06:54, Greg Landrum<EMAIL_ADDRESS>a écrit :
The origin of the RDKit values is, unfortunately, "lost in antiquity".
Updating these values to something that has a reference would be a nice enhancement for a future RDKit version.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Interesting. I've been looking around to see where that vdw radius of 1.95 for carbon may have come from. RDKit is the only place I have found a value that big. My best guess is that RDKit is mixing up the atomic number index when looking up atoms. For example, the vdwR for carbon gives the value expected for bromine; the vdwR for oxygen gives the expected value for carbon, and so on.

Previous similar discussion
https://github.com/rdkit/rdkit/issues/1037

By the way, where is the actual periodic table stored?
Is this in Data/rddata.sql?
I was looking for a csv file or some hardcoded values in a header file without success.

Probably it's here:
rdkit/Chem/PeriodicTable.py

It's defined here: https://github.com/rdkit/rdkit/blob/master/Code/GraphMol/atomic_data.cpp

and, yes, that python file should be removed

Thanks for the info, I will look into it.

Can this issue be assigned to me?

I would take the reference values from the blue obelisk data repository, then we have something convenient to reference: https://www.re3data.org/repository/r3d100000013

The Blue Obelisk Data Repository has no VdW radii for those:
Ds Rg Cn Uut Uup Fl Uus Uuo

I’d suggest taking 2.0 for those (for consistency with the others) and commenting it. It’s not like there is ever likely to be an experimental determination of these values! :-)

Ok, done.
Note that atomic number 113 appears two times in the very long string I updated.

I would like to step in and add another issue. I was also looking for a reference of van der waals radius of atoms, but also I found some differences in implementation of calculation of P_VSA from original Labute paper (2000). It seems to me that RDkit doesn't rely on the paper values for bond calculation, but on rB0 column of periodic table,  and  I don't find any reference for that column.
Moreover It seems that in original publication there is a difference for acid and oxide Oxygen (it's very unclear to me how to classify oxygen to me though). This difference is lost in RDkit implementation. I don't know if it's the same in the original Moe software, because I don't have it.

here the reference I cited, table 1 has some van der waals radius:
https://eurekamag.com/pdf/010/010106729.pdf

@marcabrus maybe this should be a separate issue: you want that P_VSA uses specific VdW radii from the corresponding publication

@UnixJunkie actually I brought the values from publication as an example. I've been diggin up and it seems that rb0 values are the ideal bond lenght reported in Mmff94 optimization data. Actually also labute extract ed the same values, but for the radii used another technique. Of course it's all explained in the publication. What is difficult to me is to understand the method underlying the vsa calculation for Rdkit.

Hi all, posting here because it's related: covalent radius of phosphorous (0.75) is too small, should be similar to that of sulfur (~1)
https://github.com/rdkit/rdkit/blob/f8c78eaeb928b2707ced0dea329c5eff94126098/Code/GraphMol/atomic_data.cpp#L54

@diogomart those values come from the blue obelisk project. You can double check. If there is indeed a problem, maybe they would first have to update this radius value. Then, we might reflect the change in rdkit. And, you should really open a specific issue, if you are confident about it.

Hi @UnixJunkie, thank you for your reply. I'm very confident the covalent radius for P should be closer to 1, but I won't be opening further issues.

Hello everyone,
Can it be that this ticket is resolved?

This issue should be closed.
The current values come from the blue obelisk project.


how to screencap in command

adb exec-out screencap -p > test.png
it is slow ,it need 2 sec
thank

Still working on a solution to achive a fast screenshot

Ref: #684 (I'm closing this one)


[Utility] Utility Spec Overhaul & Gateway Actor Introduction

This PR is an iteration of the existing specifications that aims to make the spec more accessible to others, easier to update/maintain, and introduce a few new concepts to the protocol.
Notes to the reviewers:

This PR does update sections 5 & 6 in detail
This PR does not contain new concepts related to the governance protocol
This PR is not meant to be "perfect", but rather an iteration that makes it easier to read & maintain relative to the previous version.
The diff can be viewed under utility/README.md here but a more accessible markdown rendered version of the file can be seen here

Formatting Changes

Added a table of contents
Reducing the amount of large text blocks -> easier to read
Convert diagrams to use mermaid -> easier to maintain
Creating smaller sections -> easier to update & navigate

General Changes

Added context on requirements and state of the documents
Added an RPC Trilemma visual

Protocol Changes
Fisherman / Application

Provided additional details on Probabilistic Volume Computation
Remove the need for NTP (Network Time Protocol)
Slightly modified the commit-and-reveal mechanism for TestScores
Use Ring Signatures in place of the App/Fish handshake to enable incognito sampling

Servicer / Application

Added rate limiting using Token Bucket algorithm
Added example of GeoZones algorithms

Gateway / Application

Added base specification for the Gateway Actor

@jacklaing @jessicadaugherty @mokn This is a significant change, so please see the description (changes & notes in the PR description) before reviewing.
I also invite others who have looked and thought about the specification in depth in the past (cc @moatus @DragonDmoney). This update will likely make it easier to build upon to incorporate the issues/suggestions you have brought up in the past.

Small updates: going to hold off on @jacklaing's feedback/review, and will then tend all the comments at once.

https://docs.google.com/document/d/1z5vKqt0ARq6wovjiHmG2vPAhX4ODLNd_FexcP_7TODY/edit
Posted some of my questions / comments here since I couldn't comment.

https://docs.google.com/document/d/1z5vKqt0ARq6wovjiHmG2vPAhX4ODLNd_FexcP_7TODY/edit leaving this doc for anyone to read with my comments/questions. Will go back and comment on the actual spec since it seems i can actually comment on this account

@deblasis @PoktBlade @jessicadaugherty Appreciate the review, questions and comments.
I resolved the "easy ones" and left comments/replies on the more difficult questions, sometimes updating the spec and sometimes updating the ideas section. PTAL and Resolve the comments where you're content with the answer or lmk if I should make further updates/changes/clarifications.
If all looks good, let's merge it in :)


Allow to configure Kourier gateway service-type

When deploying Kourier, the gateway is always LoadBalancer.
It should be supported other service type such as ClusterIP and
NodePort.
e.g. You can configure ClusterIP with following CR.
cat <<-EOF | kubectl apply -f -
apiVersion: operator.knative.dev/v1alpha1
kind: KnativeServing
metadata:
  name: ks
  namespace: knative-serving
spec:
  config:
    network:
      ingress.class: kourier.ingress.networking.knative.dev
  ingress:
    istio:
      enabled: false
    kourier:
      enabled: true
      service-type: "ClusterIP"
EOF

Release Note
New configuration `spec.ingress.kourier.service-type` is available.

/cc @houshengbo  @markusthoemmes

/lgtm
/approve


New version: v2.4.6

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.25%. Comparing base (fec9de9) to head (f916244).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   94.00%   95.25%   +1.25%
==========================================
  Files           2        2
  Lines         250      232      -18
==========================================
- Hits          235      221      -14
+ Misses         15       11       -4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Radarr DOA

Linking this to Gooby issue as well, but experiencing the same thing on Omni. https://github.com/TechPerplexed/Gooby/issues/209#issue-1302482512
Chatted on discord, they are thinking its a variable in the YAML the new version doesn't like, but one that's not even causing it to see the config. It is not the health check as I disabled and still had the issue.
If I run with blank config and newest version, it's fine:
docker run -d --rm --name=radarr --tmpfs /config -p 7878:7878 lscr.io/linuxserver/radarr:latest
But running in the Omni yaml with latest, fails to start.
Dropping back to <IP_ADDRESS>75-ls145 works fine, starts up no issues.
https://github.com/TechPerplexed/Gooby/issues/209#issue-1302482512

For me, Radarr (latest) doesn't work even with a blank config.  Clearly a problem on Radarr's side.  I'll keep an eye out for an update from them but yes, in the meantime, you may want/need to force it to a specific version that works.

@bdschuster try to update your Omni - @kelinger just pushed an update. I also asked the Gooby user to comment out one line to see if it solves their issue :)

@TechPerplexed I'm having a long day moment..lol...how do I fix this again?
Updating a222658..a4737f8 error: Your local changes to the following files would be overwritten by merge:         components/301-radarr.yaml         healthchecks/radarrcheck Please commit your changes or stash them before you merge. Aborting

This is because you modified those files.  Just delete them entirely and the next "omni update" will redownload them.

Working now! Thank you!


Add Javadoc to model

Closes #433

LGTM, just some small code style nits

That should be all those comments addressed.

Awesome, thanks!


[Release v2.019] Qihoo-360 VirusTotal report

Thoughts on what this is picking up @texhex? 1/50 in the red:
HEUR/QVM06.1.0000.Malware.Gen
https://www.virustotal.com/en/file/a084365bb213c8dec8b402c60a6191db427696a16a41e08aaa792c5ada5bdf5f/analysis/1461433821/

Unfortunately, there is nothing I can do about this. For whatever reason, Qihoo will detect all InnoSetup-based setups I have tried on Virustotal as "Malware.Gen(eric)". I assume this comes from the fact that InnoSetup is also often used for installing Malware.
As I have written the setup, and can ensure that it's not adware, and given that 54 other AV vendors agree with me on this, this is clearly a false positive.

thanks


a sequence of the same event for the same file could be triggered once

Assume that the handling of a modified event takes some significant amount of time and that during that time there might be multiple writes to that file occurring while handling an event. This is likely if a monitored file becomes large and the process of submitting changes to s3 takes non-trivial time.
event queue = [modify file A, modify file A, modify file A, modify file B, modify file C, modify file A]
In handling the modified event for file A, we will get the state of file A after the 4rd modify event and so the work of handling all the modification of file A events at the head of the queue would all produce the same content for file A. The front 3 events 'could' be treated as one event performing the work of that event once instead of 3 times.
Potentially all modify events for file A could be consumed at once, but that is probably more complex given the per event handling of the watchdog module.
In either case, handling each repeated event can result in a lot of memory work to create a binary file contents and and a lot of network traffic when uploading to s3 that is all handling the same file contents.
This heavy processing may be interfering with the producers ability to update the file and the more redundant work that occurs here, the more likely there may be some unforeseen negative interaction.
Unfortunately the watchdog module may not have the visibility to support this change in it's current design. The ability to group events lies in the implementation of the inotify* classes.

Hmm so we could just debounce events, would require us to introduce threading though


status on install_requires / pyproject.toml [build-system]

What's the status on these?
I could have sworn this had been working,
but for some manually buildPythonPackages I find that they are completely ignored.

And if that's not working,
how do I get rust into the build inputs of a buildPythonPackages derivation that I pass to packagesExtra?


Revert "deps: update arrow.version to v16 (major)"

Reverts googleapis/java-bigquerystorage#2468

Sample integration tests are failing since upgrading apache arrow version to v16. Reverting to last known passing version and investigating further.


Fix json-server path location.

Summary
Currently the dev script in the client folder is pointing to the incorrect json file. We need to fix that by pointing back to the correct test json-server file and remove the z-code tutorial json file.
Tasks
Step 1

Delete client/src/services/events.json.
Update the client package.json file dev script path pointing to src/test/events.json.
Test that the script work as expected.

Step 2

Add new scripts to the root package.json file.
Note: You want to add it under start-client script.

"start-mockServer": "npm --prefix client run dev",
"dev-concurrent-mockServer": "concurrently \"npm:start-client\" \"npm:start-mockServer\"",

Test that the script work as expected.

I will like to work on this issue.

Fixed by @code2244


first cut at llama.cpp encoding

NOTE: This is not ready to be merged but I wanted to share in case anyone wants to help with this
SeaGOAT is pretty cool but I've been disappointed by the results.. so I thought I'd try using codellama for embeddings, using llama_cpp_python
It works reasonably well with a few caveats:

embedding without GPU is slow - initially it was like 7-10s per chunk on my M2 mac, but once you turn on GPU support it is more like 300ms. I haven't tried on an Intel machine or with a non-metal GPU
you need to download a llama model an set up your .seagoat.yml to point to the model:

server:
  model_path: "/path/to/codellama-7b-instruct.Q5_K_M.gguf"

I think the chunking could also be improved by doing some kind of syntactic/hierarchical chunking, but that is pretty slow too... however I wonder if bigger chunks might actually be better here. (because I think embedding fragments of source probably loses a lot of semantic information)

If you are interested, we can jump on a video call and discuss about certain ways to improve the efficiency as well as benchmarking

note, now it should be possible to measure the accuracy against other models using these tools: https://github.com/kantord/SeaGOAT/blob/main/benchmark/benchmark.ipynb

Did anyone run benchmarks on embeddings, available in ChromaDB?
I've run several and they give me identical Average position of result which doesn't feel correct.
Sorry for hijacking the issue, I may open a different one to discuss this.

Did anyone run benchmarks on embeddings, available in ChromaDB? I've run several and they give me identical Average position of result which doesn't feel correct.
Sorry for hijacking the issue, I may open a different one to discuss this.

that definitely doesn't sound correct, but are also the other metrics identical? Or just the average position of result? If it's just the latter, it might suggest a different bug :thinking:

that definitely doesn't sound correct, but are also the other metrics identical? Or just the average position of result? If it's just the latter, it might suggest a different bug 🤔

All other metrics are also the same.  Just this one was the easiest to check.
Embedding definitely were regenerated and servers served from a fresh db.

that is weird. It could mean that actually you are not successfully changing the model. I think if you change the model, you should observe other differences. For example different models might be a lot slower when initially analyzing the files. At least I think most models are slower than the one that is being used by default. If they seem just as fast that would mean that probably you are still using the same model

Yes, of course, embedding processing is definitely slower with all-mpnet-base-v2 than with all-MiniLM-L6-v2. But benchmark results are the same. I may attach here my run of benchmark.ipynb if that helps.

that is very unusual, it might be a huge bug

@akhavr what happens if you disable the regex based results here:

It's enough to comment out the ripgrep source before you run the benchmark. This would mean that all results come from chromadb, so the results should change heavily if the model changes. But I suspect that the problem might be with they the benchmarks are being run, or maybe there is something confusing, as the benchmark part is not really documented (yet)

@akhavr what happens if you disable the regex based results here:
https://github.com/kantord/SeaGOAT/blob/bb1086ced94bb83f6e63cbc613016625d3e15883/seagoat/engine.py](https://github.com/kantord/SeaGOAT/blob/bb1086ced94bb83f6e63cbc613016625d3e15883/seagoat/engine.py](https://github.com/kantord/SeaGOAT/blob/bb1086ced94bb83f6e63cbc613016625d3e15883/seagoat/engine.py#L64-L71))
It's enough to comment out the ripgrep source before you run the benchmark. This would mean that all results come from chromadb, so the results should change heavily if the model changes. But I suspect that the problem might be with they the benchmarks are being run, or maybe there is something confusing, as the benchmark part is not really documented (yet)

Only now could return to the topic.
Trying to run it with the change you've suggested, but while doing that, noticed that seagoat/repository.py:Repository.get_file_object_id tries to run git-ls-tree with option --object-only which is absent in my git 2.34.1
Guess, I'd better open a separate issue/pull request for that.