Cleanup NetBeans license header for module html.editor

Review and cleanup the license header in html.editor
Oracle donated NetBeans to the Apache Software Foundation.
Your task now is to replace the old license header that has Oracle (and/or Sun Microsystems
and/or NetBeans) in it with the standard Apache Software Foundation license header.
For an empty file that supports headers you must add the Apache license header.
Note that you have to use the proper license header for Java, .properties or HTML files.
Look at the nearby files for templates and copy-paste the license header.
When done commit the changes with a commit message that starts with first line
"[NETBEANS-54] Module Review " and a message body describing your review.
See a longer explanation about what we are doing here: https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
Please announce in a comment when you have started work.
Files that need to be looked at in html.editor:
html.editor/src/org/netbeans/modules/html/editor/Bundle.properties
html.editor/src/org/netbeans/modules/html/editor/hints/Bundle.properties
html.editor/src/org/netbeans/modules/html/editor/hints/css/Bundle.properties
html.editor/src/org/netbeans/modules/html/editor/options/ui/formatSample.html
html.editor/src/org/netbeans/modules/html/editor/resources/DTDs/3_2/catalog
html.editor/src/org/netbeans/modules/html/editor/resources/DTDs/4_0/catalog
html.editor/src/org/netbeans/modules/html/editor/resources/DTDs/4_01/catalog
html.editor/src/org/netbeans/modules/html/editor/resources/DTDs/xhtml/catalog
html.editor/src/org/netbeans/modules/html/editor/resources/HTMLExample
html.editor/src/org/netbeans/modules/html/editor/resources/XHTMLExample
html.editor/src/org/netbeans/modules/html/editor/todo.txt
html.editor/test/unit/data/testfiles/completion/index.html
html.editor/test/unit/data/testfiles/completion/issue193268.html
html.editor/test/unit/data/testfiles/completion/netbeans.org.html
html.editor/test/unit/data/testfiles/embedding/issue189999.html
html.editor/test/unit/data/testfiles/embedding/issue215267.html
html.editor/test/unit/data/testfiles/embedding/issue215267.html.virtual
html.editor/test/unit/data/testfiles/embedding/test1.html
html.editor/test/unit/data/testfiles/embedding/test1.html.virtual
html.editor/test/unit/data/testfiles/embedding/testIssue174241.html
html.editor/test/unit/data/testfiles/embedding/testIssue174241.html.virtual
html.editor/test/unit/data/testfiles/embedding/testIssue174241_1.html
html.editor/test/unit/data/testfiles/embedding/testIssue174241_1.html.virtual
html.editor/test/unit/data/testfiles/model/test1.html
html.editor/test/unit/data/testfiles/model/test2.html
html.editor/test/unit/data/testfiles/model/test3.html
html.editor/test/unit/data/testfiles/simple01.html
html.editor/test/unit/data/testfiles/simple01.html.formatted
html.editor/test/unit/data/testfiles/simple02.html
html.editor/test/unit/data/testfiles/simple02.html.formatted
html.editor/test/unit/data/testfiles/simple03.html
html.editor/test/unit/data/testfiles/simple03.html.formatted
html.editor/test/unit/data/testfiles/simple04.html
html.editor/test/unit/data/testfiles/simple04.html.formatted
html.editor/test/unit/data/testfiles/simple04_html5.html
html.editor/test/unit/data/testfiles/simple04_html5.html.formatted
html.editor/test/unit/data/testfiles/simple05.html
html.editor/test/unit/data/testfiles/simple05.html.formatted
html.editor/test/unit/data/testfiles/simple06.html
html.editor/test/unit/data/testfiles/simple06.html.formatted
html.editor/test/unit/data/testfiles/simple07.html
html.editor/test/unit/data/testfiles/simple07.html.formatted

Hi! Can I work on this?

All yours. Updated https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review

@suvreial any update? You have some others reserved with no news.

@suvreial is no longer on this issue. Issue available for anybody.

Hacktoberfest over


Possible bug of code

https://github.com/ultraq/thymeleaf-layout-dialect/blob/9e1d3b9b0d1b26840d906444e5d96c3455342fd9/source/nz/net/ultraq/thymeleaf/decorators/strategies/GroupingStrategy.groovy#L71
Where is the definition of the variable positions?

Looks like a copy/paste error on my part.  That's supposed to be headModel.size().

Fixed in 2.4.1-SNAPSHOT.


unset command added

Hi
I have added another yommand called unset to your lib.
Can you merge it into your master ?
Regards
Sven

@schoes Thanks! Now published as v1.3.0


Test script fails due to path separator // in registry/directory on windows platform

/kind bug

What versions of software are you using?

Ran make test-e2e-images on windows.
Actual behavior
> make test-e2e-images
[...]
SSSSSSSCreated dir: C:\Users\Admin\AppData\Local\Temp\108651876
Creating a new project: asigcqzcof
Running odo.exe with args [odo project create asigcqzcof -w -v4]
[odo]  -  Waiting for project to come up  ...
[odo] I0619 06:50:12.739836    3816 occlient.go:543] Status of creation of project asigcqzcof is Active
[odo] I0619 06:50:12.788612    3816 occlient.go:548] Project asigcqzcof now exists
[odo] I0619 06:50:12.827575    3816 occlient.go:583] Status of creation of service account &ServiceAccount{ObjectMeta:{default  asigcqzcof /api/v1/namespaces/asigcqzcof/serviceaccounts/default 10fa5fca-0585-4a1b-b823-a84cdc72fbf3 103419 0 2020-06-19 06:50:13 +0000 GMT <nil> <nil> map[] map[] [] []  []},Secrets:[]ObjectReference{ObjectReference{Kind:,Namespace:,Name:default-token-6289w,UID:,APIVersion:,ResourceVersion:,FieldPath:,},ObjectReference{Kind:,Namespace:,Name:default-dockercfg-qmhhx,UID:,APIVersion:,ResourceVersion:,FieldPath:,},},ImagePullSecrets:[]LocalObjectReference{LocalObjectReference{Name:default-dockercfg-qmhhx,},},AutomountServiceAccountToken:nil,} is ready
 V  Waiting for project to come up [808ms]
[odo]  V  Project 'asigcqzcof' is ready for use
[odo]  V  New project created and now using project: asigcqzcof
[odo] I0619 06:50:12.852064    3816 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)
Running oc.exe with args [oc --request-timeout 5m import-image nodejs:latest --namespace=asigcqzcof --from=registry.access.redhat.com\rhscl\nodejs-8-rhel7:latest --confirm]
[oc] The ImageStreamImport "nodejs" is invalid: spec.images[0].from.name: Invalid value: "registry.access.redhat.com\\rhscl\\nodejs-8-rhel7:latest": invalid reference format
Deleting project: asigcqzcof
Running odo.exe with args [odo project delete asigcqzcof -f]
[odo] I0619 06:50:13.864599   10320 application.go:49] Unable to list Service Catalog instances: unable to list ServiceInstances: the server could not find
the requested resource (get serviceinstances.servicecatalog.k8s.io)
[odo]  V  Deleted project : asigcqzcof
[odo]  !  Warning! Projects are deleted from the cluster asynchronously. Odo does its best to delete the project. Due to multi-tenant clusters, the project
may still exist on a different node.
[odo] I0619 06:50:13.989486   10320 odo.go:72] Could not get the latest release information in time.   Bailing out early after 0.378s.
    Running oc.exe with args [oc --request-timeout 5m import-image nodejs:latest --namespace=asigcqzcof --from=registry.access.redhat.com\rhscl\nodejs-8-rhel7:latest --confirm]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0
    C:/Users/Admin/go/src/github.com/openshift/odo/tests/helper/helper_run.go:34
------------------------------
[...]
SSS
Summarizing 8 Failures:
[Fail] odo supported images e2e tests odo supported images deployment [It] Should be able to verify the nodejs-8-rhel7 image
C:/Users/Admin/go/src/github.com/openshift/odo/tests/helper/helper_run.go:34
[...]
Ran 8 of 23 Specs in 20.037 seconds
FAIL! -- 0 Passed | 8 Failed | 0 Pending | 15 Skipped
--- FAIL: TestE2eScenarios (20.52s)
FAIL

Failure : The ImageStreamImport "nodejs" is invalid: spec.images[0].from.name: Invalid value: "registry.access.redhat.com\rhscl\nodejs-8-rhel7:latest": invalid reference format
Expected behavior
Image import path should be registry.access.redhat.com\rhscl\nodejs-8-rhel7:latest
Any logs, error output, etc?

/kind test

I have changes the priority to high because we have already set up our periodic job on PSI for fedora, windows and macOS. However the platform specific issues are acting as hindrance for the test run, so IMO its high time we fix these bugs or test script issues.
Assigning @anandrkskd for this.

The test for e2e test creates image names and uses filepath.Join("redhat-openjdk-18", "openjdk18-openshift:latest") , which creates an issue in case of tests running on Windows platform, as in case of Winodws filepath.Join("redhat-openjdk-18", "openjdk18-openshift:latest") uses "" to join the two strings and thus the correct image name is not generated.
https://github.com/openshift/odo/blob/aa28203096dd7c3b189734181494c1207fcb77c4/tests/e2escenarios/e2e_images_test.go#L109
To resolve this issue we will require tests to uses a custom function that uses "/" to join and create the expected image name.


UglifyJS cannot be used with ES6 output from typescript in current config

Per https://github.com/webpack/webpack/issues/2972
I have had to comment out these lines in the prod.js webpack config.
    // new webpack.optimize.UglifyJsPlugin({
    //   compress: {
    //     warnings: false
    //   }
    // }),

Any advice/ideas/thoughts about this would be appreciated.
Thanks,
Ben

Its worth noting that Uglify appears to be fine with "const", and seems to just not like "let" for some reason.
As a result if you're not truly using all ES6 syntax/format; its not a heavy lift to get this working with Uglify.

Should the ES6 output from tsc be converted to ES5 using Babel?

I get no error when settings:
"target": "es5", in tsconfig.json
and running:
$ npm run build:prod
$ npm run start:prod

I've encountered errors with UglifyJsPlugin and ES6 + babel before... better to have TS do the heavy lifting than playing games with wepback and babel...

I solve this issue adding uglifyjs-webpack-plugin and not using the uglifyJsPlugin` chipped with webpack.
// webpack.config.js

const UglifyJSPlugin = require('uglifyjs-webpack-plugin');

module.exports = {
	// ...
	plugins: [
		new UglifyJSPlugin({/* options */}),
		// ...
	]
}

hope this helps! :)


parse laser profile images and smooth the 2D histogram

Please write Python code to parse two *.bmp files found here, https://github.com/radiasoft/rslaser/tree/master/rslaser/package_data/
The data should be smoothed to remove all small-scale artifacts.  Executable code should live here, https://github.com/radiasoft/rslaser/tree/master/examples
Any code encapsulated into libraries should live here, https://github.com/radiasoft/rslaser/tree/master/rslaser/utils
Time spent should be charged to 'silas' in GHG/clockwise.

I've pushed a couple of scripts into the examples/smoothing directory.

I renamed the scripts and modified the README
I added some notebooks using the smoothers and supergaussian fits.  I added a couple of notebooks that do explicitly Gaussian fits, so these can be compared to the supergaussian results.

@kevin-bruhwiler -- please add code that parses the following file, so the images can be plotted with correct spatial dimensions on the horizontal and vertical axes, instead of pixel number
https://github.com/radiasoft/rslaser/blob/master/rslaser/package_data/camera_sensor_info.txt


Fix #87: Support for scaling containers

@drBosse what is the problem that we are trying to address here?

To enable scaling the number of slaves
if you do that the review will crash when it get multiple answers in the docker ps call in get_binds

@drBosse we can merge this one, however we never intended to have more than one utility slave. If users need more slaves like that then they should update docker compose file to make a copy and name it differently. That copy could be scaled as much as they like

@drBosse i think there is no need in this one any longer. Closing it now. Please feel free to reopen if it is needed


Exported images get recorded

Bug:
Exporting the sprite to an image causes the recorder to output the same image. This is mildly annoying when the exported image is resized because the resized image gets dumped by the recorder.
This might be an unworkable limitation for the time being. I will investigate. Workaround for now is to manually delete these frames after recording and then fix up the file names to close numeric gaps. (I have an external tool for this, but want to try getting it into this project first-class)

I swore at one point I had done something like this where I checked if the sprite changed at all - will make sure to investigate this at some point.

why the action delay doesn't work for me, no matter what number I set to it always save every action.


[Android] 1.12.2: If more than one conversation is present in notification panel, can no longer click into a conversation or expand each conversations

https://user-images.githubusercontent.com/107290291/234148710-f24595e9-4284-48b4-8423-7316b2a33ca7.mp4

This has to be an OS issue

will close, until i can confirm is specific to bluebubbles


TypeError: dynamic css on dynamically imported component

Vue version
3.3.4
Link to minimal reproduction
https://github.com/Disservin/vue-dynamic-import-css
Vue Playground Link

simplified

Steps to reproduce
npm install
npm run dev

What is expected?
I'd expect no TypeError's and that the component is properly mounted and has my dynamic class.
What is actually happening?
Open your browser console and you should be greeted by a TypeError.
TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.

System Info
No response
Any additional comments?
If you comment out the following part in the Foo Component, you get no error.
.hover-link {
    padding: v-bind("bindings.padding") px;
}

or if you remove the class from the component
:class="loading ? 'classA' : 'classB'"
    <component
        :is="getComponent()"
        :id="component.id"
        :settings="component.settings"
        :class="loading ? 'classA' : 'classB'"
    />

It seems to me that for some reason asynccomponents are missing the parentNode and thus the error?

When looking at the created instances, there are actually two, I guess that makes sense ?
{uid: 6, vnode: {…}, type: {…}, parent: {…}, appContext: {…}, …}
{uid: 4, vnode: {…}, type: {…}, parent: {…}, appContext: {…}, …}

From what I can tell they are for classB and classA, respectively, but uid: 4 has no subTree.el.parentNode while uid: 6 has it?

I think someone reported the same bug in Pinia but with a boiled down repro so I added it here simplified

Ah nice, seems to be related, thanks for the smaller reproduction! I initially encountered this also with my pinia store, but then I figured out that it isnt related to pinia.
Weirdly enough you can get rid of the error in my reproduction if you do these changes
-    <component
-        :is="getComponent()"
-        :id="component.id"
-        :settings="component.settings"
-        :class="loading ? 'classA' : 'classB'"
-    />
+    <MyComp
+        :id="component.id"
+        :settings="component.settings"
+        :class="loading ? 'classA' : 'classB'"
+    />

-const getComponent = () => {
-    return defineAsyncComponent(() => Promise.resolve(VFoo));
-};

+const MyComp = defineAsyncComponent(() => Promise.resolve(VFoo));

Do we have any updates on this? I reported a bug (#9617) a while ago that was then mentioned as a possible duplicate of this.

Note that with
const getComponent = () => {
    return defineAsyncComponent(() => Promise.resolve(VFoo));
};

and
<component :is="getComponent()">

You are defining a new component on every update. To the parent component, it is rendering a different child component every time. So every time the parent component updates, Foo will be unmounted and re-mounted. You should definitely avoid that.
That said the error is still something that is relevant.

Note that with
const getComponent = () => {
    return defineAsyncComponent(() => Promise.resolve(VFoo));
};

and
<component :is="getComponent()">

You are defining a new component on every update. To the parent component, it is rendering a different child component every time. So every time the parent component updates, Foo will be unmounted and re-mounted. You should definitely avoid that.
That said the error is still something that is relevant.

Ah thanks for pointing that out! I anyway now have something which looks like this
const UiComponent = (() => {
    return defineAsyncComponent(
        () => import(`./VFoo.vue`),
    );
})();

<ui-component>
</ui-component>

Why not just
const UiComponent = defineAsyncComponent(() => import(`./VFoo.vue`))

What's the point of wrapping it in another function?

I had some additional logic in the first arrow function to build the import path, but yea that is functionally the same anyway


Revert "Turn on recovery as collisions only for floor snapping"

Reverts https://github.com/godotengine/godot/pull/64728.
Fixes https://github.com/godotengine/godot/issues/66704
Reopens https://github.com/godotengine/godot/issues/64726
The dependence on the size of the floor shape in https://github.com/godotengine/godot/issues/66704 seems to indicate a deeper underlying issue, which should be investigated in the future. In the short term we choose the lesser evil.

Note that even if this was not originally intended, we can also leave #64726 closed and consider it the new default behavior. As long as it is consistent.


Proposal: customize ignore button classes

Excelente package!
Would you be interested in a PR to allow user customizing other options to ignore other than the ones you established? (links, inputs, etc)
The reason is that I had to integrate https://github.com/dillingham/nova-button and this package does not use either <button> or <a> but a simple <span> with a class nova-button.
I made a version of your packet where I parse the span class and ignore the click listener to, but is hardcoded in my project.
I was thinking about the best way for the user to indicate that other items to ignore:
Option 1: using dotenv (https://www.npmjs.com/package/dotenv) we could give the user the option to include. in his .env
CLICKABLE_ROW_IGNORE_CLASES = nova-button, other-class
CLICKABLE_ROW_IGNORE_IDS = some-id, other-id

Option 2: Have the tool inject some meta element into the header, and can the file too.js read it from there?
Option 3: any better ideas?

Hi @emilianotisato, PR is always welcome!
I think the Option 1 is a bit strange given that this package does something so simple, I think a better and easy option to solve this problem would be following the default convention for setting up a tool in Nova, for example, we could do something like this:
In NovaServiceProvider.php
/**
 * Get the tools that should be listed in the Nova sidebar.
 *
 * @return array
 */
public function tools()
{

    return [
        new ClickableTableRow([
            'ignoreElements' => [
                '.nova-button',
                '.other-class',
                '#some-id .some-class'
            ]
        ])
    ];

}

And from within the ClickableTableRow we can pass any arbitrary data to the tool.js by calling:
Nova::provideToScript([
    'clickableTableRow' => $data
]);

and then we can retrieve this info back in tool.js by calling Nova.config.clickableTableRow
I believe this would be a cleaner solution to accept config options, and also this would open doors for a future feature I am planning to do soon where I need this package not to be applied to certain table resources
So it would be just a matter of including another option on the options array:
new ClickableTableRow([
    'ignoreResources' => [
        \App\Nova\User::class
    ],
    'ignoreElements' => [...]
]),


"Uncaught Error: plugin "record" does not exist"

Description
I see that this error has came up a few times in the past, however I am unable to get past it. Any version above 7.8.4 of video.js causes the error for me.
Would appreciate any help troubleshooting. Not super familiar with videojs inner working.
Steps to reproduce
Import video.js > 7.8.4 and the error shows up.
Results
Expected
Expect it to work.
Actual
VideoJs does not initialize
Error output
video.es.js:21517 Uncaught Error: plugin "record" does not exist
    at video.es.js:21517
    at Array.forEach (<anonymous>)
    at new Player (video.es.js:21515)
    at videojs$1 (video.es.js:27013)
    at initializeVideoJs (player.js:90)
    at setupPlayer (player.js:138)
    at Object.setup (player.js:146)
    at create (create.js:9)
    at loadVideoAction (index.js:17)
    at HTMLDocument.<anonymous> (index.js:35)

Additional Information
Relevant Code:
import Record from 'videojs-record/dist/videojs.record.js';
import videojs from 'video.js'
import RecordRTC from 'recordrtc';

const ASPECT_RATIO_16_10_STRING = '16:10';
const ASPECT_RATIO_16_9_STRING = '16:9';
const RATIO_16_10 = 16/10;

const getDeviceAspectRatio = function() {
  return window.screen.width / window.screen.height;
}

const videoPlayerAspectRatio = function() {
  getDeviceAspectRatio() == RATIO_16_10 ? ASPECT_RATIO_16_10_STRING : ASPECT_RATIO_16_9_STRING;
}

const playerOptions = function(){
  return {
    controls: true,
    bigPlayButton: false,
    aspectRatio: videoPlayerAspectRatio(),
    fluid: true,
    frameWidth: 1280,
    frameHeight: 720
  };
}

const recordOptions = function(){
  const videoRecordOptions = {
    width: 1280,
    height: 720,
    deviceId: localStorage.getItem('videoSource') || 'default'
  };

  const audioRecordOptions = {
    deviceId: localStorage.getItem('audioSource') || 'default'
  }

  return {
    record: {
      audio: audioRecordOptions,
      video: isScreenRecord ? false : videoRecordOptions,
      screen: isScreenRecord ? true : false,
      maxLength: 600,
      debug: true,
      displayMilliseconds: true,
    }
  }

}

const initializeVideoJs = function(video){
  const videoOptions = playerOptions();
  videoOptions.plugins = recordOptions()
  return videojs(video, videoOptions);
}

initializeVideoJs(videoElement);

versions
what version of videojs does this occur with?

7.8.4

browsers
Can replicate on Safari, Chrome, Firefox
OSes
Only tried MacOS

@tylerrowsell what version of videojs-record? and can you reproduce it with the webpack tutorial? https://collab-project.github.io/videojs-record/#/frameworks/webpack

Also, you have the imports wrong way around:
import Record from 'videojs-record/dist/videojs.record.js';
import videojs from 'video.js'

should be
import videojs from 'video.js'
import Record from 'videojs-record/dist/videojs.record.js';

no feedback, closing.

From other similar issues, the error get solved by changing from
import Record from 'videojs-record/dist/videojs.record.js';

to

import 'videojs-record/dist/videojs.record.js';


Add history feature

Problem Statement

Evidence or User Insights

Proposal

Goals

Non-Goals

Low-Fidelity Concept

Requested Assignment

If possible, I would like to implement this.
I'm just suggesting this idea.  I don't want to implement it.

Please add a persistent history feature, even if it's its just the most recent 'result' - or perhaps, an option to copy it to the clipboard on exit.

I'm working on this since I don't think anyone else will. May take me 2-3 weeks as I am quite busy. I'm going with the route of serializing and deserializing to json file to save history upon exit and to restore on reopen.

This issue is very confusing. Most fields on the template got skipped, the description is ambiguous, and then there's a comment suggesting another feature. @nonentity1001, I would propose you rewrite the main issue and its title with the full description of what you are suggestting and what you would like to see implemented.


[suggestion] Consider Opening up the Wiki for contributions?

Is your feature request related to a problem? Please describe.
Getting started with this project is effing hard - the readme.md is uweildly for a noob and contains getting started, development, and other topics all over the place - for example the docker instructions are spread out.  (i only found the zwave database comments on like my 10th past, and i had to use some random google article to tell me what to edit in the UI (like what the heck should one put for setting in ZWAVE etc).
Describe the solution you'd like
Open up the wiki page to allow others to contribute documents that can reduce the burden on the readme.md
Describe alternatives you've considered
keep as is and no one helps ;-)
Additional context
I am happy to consolidate the current docker info onto a docker page and bring it together with some basics of what to do once running,

given i only just got the memo on zwavejs2mqtt i just switched to that (was easy as i only one device included, lol).
offer still stands on the docker / wiki docs.  For example this works, i have no idea if it is right / ideal / best..... but happy to learn and document for others :-)

I have an open pr on zwavejs to move docs to GitHub docs :) stay tuned

I have an open pr on zwavejs to move docs to GitHub docs :) stay tuned

Cool, awesome project by the way!
Get Outlook for iOShttps://aka.ms/o0ukef

From: Daniel Lando<EMAIL_ADDRESS>Sent: Saturday, January 2, 2021 2:22:02 AM
To: OpenZWave/Zwave2Mqtt<EMAIL_ADDRESS>Cc: scyto<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [OpenZWave/Zwave2Mqtt] [suggestion] Consider Opening up the Wiki for contributions? (#862)
Closed #862https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOpenZWave%2FZwave2Mqtt%2Fissues%2F862&data=04|01||0d22d9a4a9ee4f7b520408d8af083f84|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637451797240953726|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=B4Wo5udk%2FKWtoXlrq30kp%2BsMb5kZvekicB7AP%2FJn7oU%3D&reserved=0.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOpenZWave%2FZwave2Mqtt%2Fissues%2F862%23event-4161610075&data=04|01||0d22d9a4a9ee4f7b520408d8af083f84|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637451797240953726|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=d3fiwrpHSV5w1hLsZ1G35NP0CMv8%2FVTUW0VKJ0xa86A%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACWXVXGXEVVZ3LM65E62GALSX3XUVANCNFSM4VO4QZWQ&data=04|01||0d22d9a4a9ee4f7b520408d8af083f84|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637451797240963715|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=FR2VnJdYT37g0ge07ur688l4SsVYHp%2FKqyPPvJZhutU%3D&reserved=0.

Cool, awesome project by the way!
Get Outlook for iOShttps://aka.ms/o0ukef

From: Daniel Lando<EMAIL_ADDRESS>Sent: Saturday, January 2, 2021 2:22:02 AM
To: OpenZWave/Zwave2Mqtt<EMAIL_ADDRESS>Cc: scyto<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [OpenZWave/Zwave2Mqtt] [suggestion] Consider Opening up the Wiki for contributions? (#862)
Closed #862https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOpenZWave%2FZwave2Mqtt%2Fissues%2F862&data=04|01||0d22d9a4a9ee4f7b520408d8af083f84|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637451797240953726|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=B4Wo5udk%2FKWtoXlrq30kp%2BsMb5kZvekicB7AP%2FJn7oU%3D&reserved=0.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOpenZWave%2FZwave2Mqtt%2Fissues%2F862%23event-4161610075&data=04|01||0d22d9a4a9ee4f7b520408d8af083f84|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637451797240953726|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=d3fiwrpHSV5w1hLsZ1G35NP0CMv8%2FVTUW0VKJ0xa86A%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACWXVXGXEVVZ3LM65E62GALSX3XUVANCNFSM4VO4QZWQ&data=04|01||0d22d9a4a9ee4f7b520408d8af083f84|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637451797240963715|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=FR2VnJdYT37g0ge07ur688l4SsVYHp%2FKqyPPvJZhutU%3D&reserved=0.

@scyto DOcs available to https://zwave-js.github.io/zwavejs2mqtt/

@scyto DOcs available to https://zwave-js.github.io/zwavejs2mqtt/


Cannot upload files using wp-extra-file-types

Hi Davide,
Apologies for logging an issue here in github, but I don't seem able to log a support request via WordPress.
I've installed your plugin to my WordPress site (hosted by WP) but I'm still unable to upload the file types that I want.
I want to add a .exe to my site for my users to download. I've installed your plugin, checked the "Skip WordPress checks" and selected the .exe file type. I've also added a few custom file types of type .exe with different MIME types. But when I try and upload the file into a page, I still get a WP error:"Sorry, this file type is not permitted for security reasons".
I also tried a .docx too, but that has the same error message.
I'd really appreciate your assistance to be able to upload the file. Thanks!

In Settings – Extra File Types:
– have you checked “Check only file extensions” ?
– have you checked “Skip WordPress checks” ?

Hi Davide,
Yes, in the plug-in settings I've checked both of these.
Thanks!

Hi Davide,
For future reference, I resolved this.
I was browsing to the page, adding a file block, and trying to upload the file directly. This was always generating the error.
If instead you upload the file to the media library, and then add the link to the page (still using the file block) it works fine.


add npm run dev

Hey dood,
We don't want to check-in any npm modules to this repo (I see opener checked-in).  I'm a little bit concerned about managing a package.json and a bower.json too.  I'm going to look into how other projects deal with this.  Would it be possible to just add package.json to the gitignore, then you can keep it on your machine to streamline your development?

Here's a package that does something similar, but it's a front-end tool and a node module https://github.com/Polymer/hydrolysis

Bah! Of course, I need to keep that local. Keeping packages clean is something I'd love to get very good at. Learned importance of keeping bower things bower, and npm things npm


merge package from arlac77/npm-package-template

package.json

chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(engines<EMAIL_ADDRESS>chore(package): add xo from template
chore(package): add nyc from template
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

.travis.yml

chore(travis): remove node versions 10.14
chore(travis): add node versions 10.14.1

Codecov Report

Merging #326 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   95.23%   95.23%
=======================================
  Files           1        1
  Lines          84       84
=======================================
  Hits           80       80
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d67d1...9c1cf08. Read the comment docs.

Coverage remained the same at 94.0% when pulling 9c1cf083b5f8c575681c3b81a5a696aec83fc802 on template-sync-1 into 27d67d1618501f3b643b4b01c8e86ebbfc39c8d9 on master.


Made views into a package.

Summary Change Description
Deleted

DataRepo/views.py

Modified

DataRepo/urls.py

Added

DataRepo/views/init.py
DataRepo/views/loading/submission.py
DataRepo/views/loading/validation.py
DataRepo/views/models/init.py
DataRepo/views/models/animal.py
DataRepo/views/models/compound.py
DataRepo/views/models/msrun.py
DataRepo/views/models/peakdata.py
DataRepo/views/models/peakgroup.py
DataRepo/views/models/peakgroupset.py
DataRepo/views/models/protocol.py
DataRepo/views/models/sample.py
DataRepo/views/models/study.py
DataRepo/views/models/tissue.py
DataRepo/views/nav.py
DataRepo/views/search/advanced/download.py
DataRepo/views/search/advanced/view.py
DataRepo/views/search/basic.py
DataRepo/views/search/results.py
DataRepo/views/utils.py

Affected Issue Numbers

Resolves #414

Code Review Notes
I changed the example advanced results view name due to prior stated confusion over its purpose.
Views tightly bound to models are in a models subdirectory.
I debated where and how to house the function-based views.  I decided to mix them in and separate things categorically.  So there are no class files like I did with the compositeviews package.
One file name I'm not satisfied with is DataRepo/views/search/advanced/view.py.  It's generic, but I did that to not have it be redundant with the parent dir name.
I wanted to pull in some of the data retrieval methods, but I didn't want to create conflicts, so I didn't expand outside of views other than to modify that one view function name.
Checklist

[x] All issue requirements satisfied (or no linked issues)
[x] Linting passes.
[x] Migrations created & committed (or no model changes)
[x] Tests implemented (or no code changes)
[x] All tests pass

The tests seemed to be stuck.  I manually canceled them at 25 minutes in. I can run them locally in somewhere under 8 minutes.  Going to see if I can restart them manually.

Well, now the job (started) is just sitting and waiting for a runner.  I suspect something is going on on the github side...

Huh.  Wow.  That was fast...

Seem fine to me. The questions I have are less to do with this specific PR, but perhaps the longterm project implications/maintenance/rules.

For "nested" packages (which include __init__.py content like views/ and views/models/ ), if one were to to add a new model view, do you have to touch both __init__.py files? or perhaps this will be decided as we go?

I had the same exact question yesterday when I was using the models example as a guide.  I'd googled it and found this.  I'd thought to comment on the answer that says that - all imports must always be explicit and that, yes, you have to touch __init__.py every time - to ask if there existed an analog to perl's EXPORT and EXPORT_OK variables.  I decided I already knew the pythonic answer, so I didn't ask.
So the answer, if we stick to python conventions, is that we do have to touch both __init__.py files.

Some of these new directories don't appear to have __init__.py files (/views/loading/ /views/search/, /views/search/advanced [at least looking at the left panel GitHub tree]).  Is that by design? Is there a rule for when to include a __init__.py file, and when not?

That's a valid question.  I think I was just trying to make imports more straightforward for files that import the contained methods/classes.  But I'm open to discussing alternatives.

Seem fine to me. The questions I have are less to do with this specific PR, but perhaps the longterm project implications/maintenance/rules.

For "nested" packages (which include __init__.py content like views/ and views/models/ ), if one were to to add a new model view, do you have to touch both __init__.py files? or perhaps this will be decided as we go?

I had the same exact question yesterday when I was using the models example as a guide. I'd googled it and found this. I'd thought to comment on the answer that says that - all imports must always be explicit and that, yes, you have to touch __init__.py every time - to ask if there existed an analog to perl's EXPORT and EXPORT_OK variables. I decided I already knew the pythonic answer, so I didn't ask.
So the answer, if we stick to python conventions, is that we do have to touch both __init__.py files.

In my experience, including such imports in __init__.py is rare. The only time I'd ever done it was in the models.py refactor mostly as a proof of concept. It had the side effect that we didn't have to make changes to imports, but given the maintenance headaces, that is a tradeoff.

Some of these new directories don't appear to have __init__.py files (/views/loading/ /views/search/, /views/search/advanced [at least looking at the left panel GitHub tree]).  Is that by design? Is there a rule for when to include a __init__.py file, and when not?

That's a valid question. I think I was just trying to make imports more straightforward for files that import the contained methods/classes. But I'm open to discussing alternatives.

Good catch John. I believe that all directories should have an __init__.py file (all directories that are intended to be packages). See Python Package docs.

Should have mentioned in the log that I also added the requested init files.


Failed to Clone nvm

=> Downloading nvm from git to '/c/Users/Job/.nvm'
=> Cloning into 'C:/Users/Job/.nvm'...
remote: Enumerating objects: 290, done.
remote: Counting objects: 100% (290/290), done.
remote: Compressing objects: 100% (257/257), done.
remote: Total 290 (delta 35), reused 97 (delta 20), pack-reused 0ReceivingReceiving objects:  91% (264/290)
Receiving objects: 100% (290/290), 163.27 KiB | 472.00 KiB/s, done.
Resolving deltas: 100% (35/35), done.
error: invalid path 'test/fast/Aliases/"nvm alias" should not accept aliases with slashes'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'
Failed to clone nvm repo. Please report this!

On windows, only WSL is supported - git bash and friends are not posix-compliant.
Also, duplicate of #1643.


There isn't a pkl file generated after training

Why ？When I finished training， the runs dir have no pkl file generated？Just a events file， a yml file， a log file。

@heiheiya , have you fixed this issue? I got the same problem.
Could anyone share the solution? I will appreciate.

maybe you can search the pkl named in train.py the line of "save_path",to print the pkl path;or just search in the "runs" file the name of the pkl file name ,for exmple like "fcn8s_ciyscapes_best_model.pkl","fcn8s":is the model_arch you use;"cityscapes“：is the datasets;hope it works for you

maybe you can search the pkl named in train.py the line of "save_path",to print the pkl path;or just search in the "runs" file the name of the pkl file name ,for exmple like "fcn8s_ciyscapes_best_model.pkl","fcn8s":is the model_arch you use;"cityscapes“：is the datasets;hope it works for you


proto3 hazzers always generated

I'm not sure whether this is an issue or intended. In the generated dart code the has.. method is always generated for a corresponding message field regardless of being labeled as optional or not. Does it make sense to generate those methods for none-optional fields?

Yes. We have a TODO about this in the code: https://github.com/google/protobuf.dart/blob/ba29983968de5b54196c6c2a5cff1afbdda24ae2/protoc_plugin/lib/src/protobuf_field.dart#L129-L140 this was added in 13198471df7f0bbe60b264f061cfe011cf29e89b which implemented proto3 optional syntax.

oh I see. I didn't check the generator's code


fix 'unable to convert unpermitted parameters to hash' when guest use…

When guest user to checkout, raise those error:
ActionController::UnfilteredParameters (unable to convert unpermitted parameters to hash):
actionpack (5.1.2) lib/action_controller/metal/strong_parameters.rb:258:in to_h' actionpack (5.1.2) lib/action_controller/metal/strong_parameters.rb:302:in to_query'
actionpack (5.1.2) lib/action_dispatch/routing/route_set.rb:646:in block in <class:Generator>' actionpack (5.1.2) lib/action_dispatch/journey/formatter.rb:77:in block in extract_parameterized_parts'
actionpack (5.1.2) lib/action_dispatch/journey/formatter.rb:76:in each' actionpack (5.1.2) lib/action_dispatch/journey/formatter.rb:76:in extract_parameterized_parts'
actionpack (5.1.2) lib/action_dispatch/journey/formatter.rb:21:in block in generate' actionpack (5.1.2) lib/action_dispatch/journey/formatter.rb:91:in match_route'
actionpack (5.1.2) lib/action_dispatch/journey/formatter.rb:20:in generate' actionpack (5.1.2) lib/action_dispatch/routing/route_set.rb:736:in generate'
actionpack (5.1.2) lib/action_dispatch/routing/route_set.rb:767:in generate' routing-filter (0.6.1) lib/routing_filter/adapters/rails.rb:30:in block in generate'
routing-filter (0.6.1) lib/routing_filter/filters/locale.rb:70:in around_generate' routing-filter (0.6.1) lib/routing_filter/filter.rb:11:in run'
routing-filter (0.6.1) lib/routing_filter/chain.rb:15:in run' routing-filter (0.6.1) lib/routing_filter/adapters/rails.rb:29:in generate'
actionpack (5.1.2) lib/action_dispatch/routing/route_set.rb:814:in url_for' actionpack (5.1.2) lib/action_dispatch/routing/route_set.rb:267:in call'
actionpack (5.1.2) lib/action_dispatch/routing/route_set.rb:208:in call' actionpack (5.1.2) lib/action_dispatch/routing/route_set.rb:323:in block (2 levels) in define_url_helper'
actionpack (5.1.2) lib/action_dispatch/routing/routes_proxy.rb:32:in checkout_registration_path' ~/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/spree_braintree_vzero-0ccaae363837/app/controllers/spree/checkout_controller_decorator.rb:16:in check_registration'
activesupport (5.1.2) lib/active_support/callbacks.rb:413:in block in make_lambda' activesupport (5.1.2) lib/active_support/callbacks.rb:178:in block (2 levels) in halting_and_conditional'
actionpack (5.1.2) lib/abstract_controller/callbacks.rb:12:in block (2 levels) in <module:Callbacks>' activesupport (5.1.2) lib/active_support/callbacks.rb:179:in block in halting_and_conditional'
activesupport (5.1.2) lib/active_support/callbacks.rb:507:in block in invoke_before' activesupport (5.1.2) lib/active_support/callbacks.rb:507:in each'
activesupport (5.1.2) lib/active_support/callbacks.rb:507:in invoke_before' activesupport (5.1.2) lib/active_support/callbacks.rb:130:in run_callbacks'
actionpack (5.1.2) lib/abstract_controller/callbacks.rb:19:in process_action' actionpack (5.1.2) lib/action_controller/metal/rescue.rb:20:in process_action'
actionpack (5.1.2) lib/action_controller/metal/instrumentation.rb:32:in block in process_action' activesupport (5.1.2) lib/active_support/notifications.rb:166:in block in instrument'
activesupport (5.1.2) lib/active_support/notifications/instrumenter.rb:21:in instrument' activesupport (5.1.2) lib/active_support/notifications.rb:166:in instrument'
actionpack (5.1.2) lib/action_controller/metal/instrumentation.rb:30:in process_action' actionpack (5.1.2) lib/action_controller/metal/params_wrapper.rb:252:in process_action'
activerecord (5.1.2) lib/active_record/railties/controller_runtime.rb:22:in process_action' actionpack (5.1.2) lib/abstract_controller/base.rb:124:in process'
actionview (5.1.2) lib/action_view/rendering.rb:30:in process' actionpack (5.1.2) lib/action_controller/metal.rb:189:in dispatch'
actionpack (5.1.2) lib/action_controller/metal.rb:253:in dispatch' actionpack (5.1.2) lib/action_dispatch/routing/route_set.rb:49:in dispatch'
actionpack (5.1.2) lib/action_dispatch/routing/route_set.rb:31:in serve' actionpack (5.1.2) lib/action_dispatch/journey/router.rb:46:in block in serve'
actionpack (5.1.2) lib/action_dispatch/journey/router.rb:33:in each' actionpack (5.1.2) lib/action_dispatch/journey/router.rb:33:in serve'
actionpack (5.1.2) lib/action_dispatch/routing/route_set.rb:832:in call' railties (5.1.2) lib/rails/engine.rb:522:in call'
railties (5.1.2) lib/rails/railtie.rb:185:in public_send' railties (5.1.2) lib/rails/railtie.rb:185:in method_missing'
actionpack (5.1.2) lib/action_dispatch/routing/mapper.rb:17:in block in <class:Constraints>' actionpack (5.1.2) lib/action_dispatch/routing/mapper.rb:46:in serve'
actionpack (5.1.2) lib/action_dispatch/journey/router.rb:46:in block in serve' actionpack (5.1.2) lib/action_dispatch/journey/router.rb:33:in each'
actionpack (5.1.2) lib/action_dispatch/journey/router.rb:33:in serve' actionpack (5.1.2) lib/action_dispatch/routing/route_set.rb:832:in call'
versioncake (3.3.0) lib/versioncake/rack/middleware.rb:17:in call' warden (1.2.7) lib/warden/manager.rb:36:in block in call'
warden (1.2.7) lib/warden/manager.rb:35:in catch' warden (1.2.7) lib/warden/manager.rb:35:in call'
rack (2.0.3) lib/rack/etag.rb:25:in call' rack (2.0.3) lib/rack/conditional_get.rb:25:in call'
rack (2.0.3) lib/rack/head.rb:12:in call' rack (2.0.3) lib/rack/session/abstract/id.rb:232:in context'
rack (2.0.3) lib/rack/session/abstract/id.rb:226:in call' actionpack (5.1.2) lib/action_dispatch/middleware/cookies.rb:613:in call'
activerecord (5.1.2) lib/active_record/migration.rb:556:in call' actionpack (5.1.2) lib/action_dispatch/middleware/callbacks.rb:26:in block in call'
activesupport (5.1.2) lib/active_support/callbacks.rb:97:in run_callbacks' actionpack (5.1.2) lib/action_dispatch/middleware/callbacks.rb:24:in call'
actionpack (5.1.2) lib/action_dispatch/middleware/executor.rb:12:in call' actionpack (5.1.2) lib/action_dispatch/middleware/debug_exceptions.rb:59:in call'
web-console (3.5.1) lib/web_console/middleware.rb:135:in call_app' web-console (3.5.1) lib/web_console/middleware.rb:28:in block in call'
web-console (3.5.1) lib/web_console/middleware.rb:18:in catch' web-console (3.5.1) lib/web_console/middleware.rb:18:in call'
actionpack (5.1.2) lib/action_dispatch/middleware/show_exceptions.rb:31:in call' railties (5.1.2) lib/rails/rack/logger.rb:36:in call_app'
railties (5.1.2) lib/rails/rack/logger.rb:24:in block in call' activesupport (5.1.2) lib/active_support/tagged_logging.rb:69:in block in tagged'
activesupport (5.1.2) lib/active_support/tagged_logging.rb:26:in tagged' activesupport (5.1.2) lib/active_support/tagged_logging.rb:69:in tagged'
railties (5.1.2) lib/rails/rack/logger.rb:24:in call' sprockets-rails (3.2.0) lib/sprockets/rails/quiet_assets.rb:13:in call'
actionpack (5.1.2) lib/action_dispatch/middleware/remote_ip.rb:79:in call' actionpack (5.1.2) lib/action_dispatch/middleware/request_id.rb:25:in call'
rack (2.0.3) lib/rack/method_override.rb:22:in call' rack (2.0.3) lib/rack/runtime.rb:22:in call'
activesupport (5.1.2) lib/active_support/cache/strategy/local_cache_middleware.rb:27:in call' actionpack (5.1.2) lib/action_dispatch/middleware/executor.rb:12:in call'
actionpack (5.1.2) lib/action_dispatch/middleware/static.rb:125:in call' rack (2.0.3) lib/rack/sendfile.rb:111:in call'
railties (5.1.2) lib/rails/engine.rb:522:in call' puma (3.9.1) lib/puma/configuration.rb:224:in call'
puma (3.9.1) lib/puma/server.rb:602:in handle_request' puma (3.9.1) lib/puma/server.rb:435:in process_client'
puma (3.9.1) lib/puma/server.rb:299:in block in run' puma (3.9.1) lib/puma/thread_pool.rb:120:in block in spawn_thread'
Started GET "/" for <IP_ADDRESS> at 2017-07-17 12:05:10 -0700

Thanks @chonglou 👍


Auto start new game

When game is end:
GameStatus all time is "PLAYING"
Dont start new game
Chrome version - Version 59.0.3071.109 (Official Build) (64-bit)
OS - Ubuntu 16.04
Screen Width - 928px

You need to change the gameOverOffset to [190, -82].

I was able to restart the game by using runner instance api :
setInterval(function(){ if(Runner.instance_.playing === false){ Runner.instance_.restart() } },1000)
There is one problem, I don't think the Dino is learning, might need some code change.


observablearray splice performance issue

Make sure to check the demo app(s) for sample usage
Make sure to check the existing issues in this repository
If the demo apps cannot help and there is no issue for your problem, tell us about it
Please, ensure your title is less than 63 characters long and starts with a capital
letter.
We try to replace all RadListViews by CollectionViews but we notice one performance issue only on iOS.
In our app the user should be able to select items in the list and delete them and we notice that deleting an item takes much more time with the CollectionView than using a RadListView.
When deleting a single item like this
export function deleteItem(args) {
  const bindingContext = args.object.bindingContext;

  console.time();
  vm.get("items").splice(vm.get("items").indexOf(bindingContext), 1);
  console.timeEnd();
}

we see the following results:
CollectionView: 169 ms
RadListView:  8 ms
In our real app, we have a lot more items in the list with much more complex layouts, there we see the following results:
CollectionView: 2253 ms
RadListView:  78 ms
On Android, I get the following results for both apps, no matter how many items are in the list and no matter how complex the layout is:
CollectionView: 0.2 ms
RadListView:  0.2 ms
Do you have any idea, what is causing the performance difference on iOS?
Which platform(s) does your issue occur on?

iOS
16.2
emulator and device

Please, provide the following version numbers that your issue occurs with:

CLI: 8.4.0
Cross-platform modules: 8.4.7
Runtime(s): 8.4.1
Plugin(s): collectionview 4.0.71, nativescript-ui-listview 15.2.0

Please, tell us how to recreate the issue in as much detail as possible.
Just open the sample app provided below, navigate to the CollectionView page and delete an item.
Then navigate to the page with RadListView (or ListView), do the same and compare the results.
Is there any code involved?
ns-collectionview.zip

@felixkrautschuk thanks for the details.
First i should mention that in your example you should always use the rowHeight. If you dont the collectionview has to assume each cell has its own size and thus has to measure for all items. It gets real slow when you have a lot of items.
I know what s happening. I am not 100% sure how RLV works but i think there 2 things:

collectionview can be improved
not sure if RLV really supports dynamic cells size and i think it is off by default. which in this case can make a big difference if you dont use rowHeight

Now i published 4.0.72 which should already improve things quite a lot. But i feel i am still behind RLV in your example. I think have a way to make it faster but i need time to implement it.

@farfromrefug thanks for your feedback and for publishing the new version.
It still takes a while to delete an item on iOS (having a lot items in the list with complex layouts and different cell sizes), but it is already a lot better, so thank you very much!
Yeah, having different cell sizes does not work with RLV anymore since iOS 16+, that's is actually the main reason why we switch from RLV to collectionview (although we need features like header- and footer templates, item selection etc from RLV, that we have to manage manually now with CV).

@felixkrautschuk in this case with the latest version the complexity of your layouts should not make a difference. Only the number of items. Any idea on the number of items in your collection?

@felixkrautschuk i made a 5.0.0 release which should be even faster. Though it requires testing as a lot of things changed. Let me know if it works for you


Added proof for s2n_stuffer_rewind_read

Added a CBMC proof for s2n_stuffer_skip_read_harness
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request head (s2n_stuffer_rewind_harness@ed71a56). Click here to learn what that means.
The diff coverage is n/a.

PR #1978 overrides this one.


(Request) Could it be possible to fetch categories data from coingecko API and display it on cointop?

See for example https://www.coingecko.com/en/categories .
Could it be possible to have cointop to fetch and display this useful data?
Thank you very much for developing this great project

We currently use the following API call to retrieve market data which does not appear to include any category information.
https://api.coingecko.com/api/v3/coins/markets?vs_currency=usd&order=market_cap_desc&per_page=100&page=1&sparkline=false
See https://www.coingecko.com/en/api/documentation

Alright, hopefully they will implement that in the API in the future.
Tthank you for your reply.

No need to close it just because it's not already there. Maybe you can look through the API docs, and see how we might retrieve and use this information?  How it would be displayed etc?  The more prep-work you can do, the easier it will be for a developer to implement.

Sorry for my late reply, I missed the notification about your message.
I'll try to take a look at coingecko APIs as soon as I'll have some spare time and in case I'll report back.
Thank you guys for the great work you are doing

do I have a chance to put the api data of any token in a file and watch it, thank you, I wish you continued success


Update ios-app-signer to 1.9

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 9e7ae7efffdd21b2ff689bf4a0e6e85ce4e17aa2. Your contribution is still credited to you.


Field mask and per-beam clean masks

Curious how easy it would be to implement a process roughly outlined below:

Image each beam individually
linmos the beams together into the field image
create a signal image of the entire field, i.e. (image - background) / rms
create a mask from the signal image, i.e. signal > 5
extract per beam clean masks using images from step 1
self-calibrate
go to 1

The thinking being that once a clean mask from all over lapping beams has been formed, it would be relatively safe to clean deep quickly. Hopefully this represents the best case where any type of masking is more robust to artefacts / sidelobes.
This issue is tracking how this is implemented. I am currently working under the masker branch.
An unanswered question is how to extract the appropriate region from the field clean mask. The WCS could be extracts from the previous imaging round, but this would mean all images need to have the same image and pixel sizes. Alternatives could be:

generate a 'best guess' WCS header on the fly that is compatible with the current WSClean
run the imager in as close to a dry mode as possible that would simple create a dirty map, read the WCS from this, and then use that as the template

The masker branch has been merged into main under #25
This requires a consistent image size and cell size between all images.


Multiple Repository Endpoints For Registry Integration

Right now, one endpoint (repository-endpoint) is written to the descriptors (shell and submodel) when they are registered by the aas-environment during aasx-file deployment (external URL).
It would be nice to be able to register multiple endpoints here. For example, an internal HTTP endpoint that is docker-container name related and an HTTPS endpoint for external access (for example via DNS name and through nginx). An application/client could choose which endpoint to use based on the docker configuration.
I will come up with an implementation for that.

It is merged and the issue can be closed now


Helper methods for database script execution

Is your feature request related to a problem? Please describe.
If I need to run scripts to prepare the database before running tests against it, then I must code all the steps:

by using the database API to execute the script
or by copying the file inside the container and executing the command line tool (sqlcmd, mysql, ...)

Describe the solution you'd like
A good way to make my test code smaller is creating a helper method in the database modules:
var results = await dbTestContainer.ExecScript("CREATE DATABASE xzy; ...");

This ExecScript method can encapsulate the task of creating the script file, copying it inside the container and running the command line tool to execute it.

to prepare the database before running tests

Shouldn't that be part of the Docker image?

This ExecScript method can encapsulate the task of creating the script file, copying it inside the container and running the command line tool to execute it.

Sounds good as long as it covers Windows containers (PowerShell scripts, etc.) too.

Shouldn't that be part of the Docker image?]

This is an approach, but I'm looking for scenarios where it's easier to prepare the content of the container instead building a new image for each test case. Let's say we're building a data access component and we want to validate the behavior when the component uses an invalid user, user with wrong permissions, access a table that doesn't exists in the MySQL database. Instead of having an image for each case, it's easier to run a script to give wrong permissions to the user before the test.

Sounds good as long as it covers Windows containers (PowerShell scripts, etc.) too.

Hm, I was thinking in having this feature only for specific databases modules (at least for now), not for generic images: running SQL scripts against MS SQL, MySQL, Oracle, Postgre; Lua scripts for Redis; N1QL for Couchbase. I've created a pull request #401 so we can easily discuss about this feature

Hm, I was thinking in having this feature only for specific databases modules (at least for now), not for generic images: running SQL scripts against MS SQL, MySQL, Oracle, Postgre; Lua scripts for Redis; N1QL for Couchbase. I've created a pull request #401 so we can easily discuss about this feature

Ah I see. I was thinking about a "more" generic implementation like IDockerContainer.ExecAsync. Where you pass the content of the script and the executable to the function.


Rename the examples directory

I'm considering renaming the examples directory to something else, perhaps demos. I find two things about the current setup inconvenient:

It's hard to add new examples because we need to add an [[example]] section per example to examples/Cargo.toml. I find this inconvenient because sometimes it's nice to add a quick temporary example for testing.

You need to be in the examples directory to run examples.

A possible solution to this would be to:

rename examples to demo
delete autoexamples = false
add demo to default-members list in the [workspace] section
perhaps change examples to bins

In that case, we could do cargo run --bin ctrl-c from the root of the repository.

I can do this if you want... looks like easy way to contribute

@tshepang Go ahead! :)


fix(kl-factory): base token ether tests

What ❔
Adapt ethers tests so they work when usyng any token as base (using kl-factory base token implementation).
Why ❔
Improve test coverage.
Fixes: EVM-555
Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[x] Tests for the changes have been added / updated.
[x] Documentation comments have been added / updated.
[x] Code has been formatted via zk fmt and zk lint.

Also external_node tests seem to be failing:
ETH token checks › Can perform a deposit

    TypeError: Cannot read properties of undefined (reading 'toLowerCase')

      41 |             // This prevents the deposit fee from being miscalculated.
      42 |             const l1MaxBaseTokenBalance = await alice.getBalanceL1(process.env.CONTRACTS_BASE_TOKEN_ADDR!);
    > 43 |             await (await alice.approveERC20(process.env.CONTRACTS_BASE_TOKEN_ADDR!, l1MaxBaseTokenBalance)).wait();
         |                                ^
      44 |         }
      45 |         const amount = 1; // 1 wei is enough.
      46 |         const gasPrice = scaledGasPrice(alice);

      at isAddressEq (../../../node_modules/zksync-ethers/build/src/utils.js:474:14)
      at isETH (../../../node_modules/zksync-ethers/build/src/utils.js:68:12)
      at Wallet.approveERC20 (../../../node_modules/zksync-ethers/build/src/adapters.js:71:35)
      at Object.<anonymous> (tests/ether.test.ts:43:32)
      ```

and:
● ETH token checks › Can perform a withdrawal

    expect(received).toBeAccepted(expected)

    Transaction was expected to pass, but it failed. Details:
     [Error: cannot estimate gas; transaction may fail or may require manual gas limit [ See: https://links.ethers.org/v5-errors-UNPREDICTABLE_GAS_LIMIT ] (error={"reason":"execution reverted: ERC20: burn amount exceeds balance","code":"UNPREDICTABLE_GAS_LIMIT","method":"estimateGas","transaction":{"from":"0xCd37FAa91a68E56e62AB7f9819a641A4b2fc9869","gasPrice":{"type":"BigNumber","hex":"0x05f5e100"},"to":"0x3E24D1c62647A62a5E8f76BbF1cA75f0795ab4d3","data":"0xd9caed12000000000000000000000000cd37faa91a68e56e62ab7f9819a641a4b2fc9869000000000000000000000000db8bf375f18e41afc41addbedd1e4cf053553df80000000000000000000000000000000000000000000000000000000000000001","type":0,"accessList":null},"error":{"reason":"processing response error","code":"SERVER_ERROR","body":"{\"jsonrpc\":\"2.0\",\"error\":{\"code\":3,\"message\":\"execution reverted: ERC20: burn amount exceeds balance\",\"data\":\"0x08c379a00000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000002245524332303a206275726e20616d6f756e7420657863656564732062616c616e6365000000000000000000000000000000000000000000000000000000000000\"},\"id\":311}","error":{"code":3,"data":"0x08c379a00000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000002245524332303a206275726e20616d6f756e7420657863656564732062616c616e6365000000000000000000000000000000000000000000000000000000000000"},"requestBody":"{\"method\":\"eth_estimateGas\",\"params\":[{\"gasPrice\":\"0x5f5e100\",\"type\":\"0x0\",\"from\":\"0xcd37faa91a68e56e62ab7f9819a641a4b2fc9869\",\"to\":\"0x3e24d1c62647a62a5e8f76bbf1ca75f0795ab4d3\",\"data\":\"0xd9caed12000000000000000000000000cd37faa91a68e56e62ab7f9819a641a4b2fc9869000000000000000000000000db8bf375f18e41afc41addbedd1e4cf053553df80000000000000000000000000000000000000000000000000000000000000001\"}],\"id\":311,\"jsonrpc\":\"2.0\"}","requestMethod":"POST","url":"http://<IP_ADDRESS>:3060/"}}, tx={"data":"0xd9caed12000000000000000000000000cd37faa91a68e56e62ab7f9819a641a4b2fc9869000000000000000000000000db8bf375f18e41afc41addbedd1e4cf053553df80000000000000000000000000000000000000000000000000000000000000001","to":{},"from":"0xCd37FAa91a68E56e62AB7f9819a641A4b2fc9869","type":0,"gasPrice":{},"nonce":{},"gasLimit":{},"chainId":{}}, code=UNPREDICTABLE_GAS_LIMIT, version=abstract-signer/5.7.0)]

      256 |             amount
      257 |         });
    > 258 |         await expect(withdrawalPromise).toBeAccepted([l2ethBalanceChange]);
          |                                         ^
      259 |         const withdrawalTx = await withdrawalPromise;
      260 |         await withdrawalTx.waitFinalize();
      261 |

      at Object.<anonymous> (tests/ether.test.ts:258:41)

  ● ETH token checks › Can perform a deposit with precalculated max value

    TypeError: Cannot read properties of undefined (reading 'toLowerCase')

      271 |             const baseTokenDetails = testMaster.environment().baseToken;
      272 |             const baseTokenMaxAmount = await alice.getBalanceL1(baseTokenDetails.l1Address);
    > 273 |             await (await alice.approveERC20(process.env.CONTRACTS_BASE_TOKEN_ADDR!, baseTokenMaxAmount)).wait();
          |                                ^
      274 |         }
      275 |
      276 |         const depositFee = await alice.getFullRequiredDepositFee({

      at isAddressEq (../../../node_modules/zksync-ethers/build/src/utils.js:474:14)
      at isETH (../../../node_modules/zksync-ethers/build/src/utils.js:68:12)
      at Wallet.approveERC20 (../../../node_modules/zksync-ethers/build/src/adapters.js:71:35)
      at Object.<anonymous> (tests/ether.test.ts:273:32)
      ```

Will check functionality on external node and check if I have the same issues.

@mm-zk external node integration tests should now be working.

@juan518munoz - it is still failing:
  ● ERC20 contract checks › Should claim failed deposit

    expect(received).toBeAccepted(expected)

    Transaction was expected to pass, but it failed. Details:
     [Error: invalid address (argument="address", value="0x87fa08e257bdc0f1f8bd6504467ce5c0df9bc1", code=INVALID_ARGUMENT, version=address/5.7.0)]

      197 |         await waitUntilBlockFinalized(alice, l2TxReceipt.blockNumber);
      198 |         // Claim failed deposit.
    > 199 |         await expect(alice.claimFailedDeposit(l2Hash)).toBeAccepted();
          |                                                        ^
      200 |         await expect(alice.getBalanceL1(tokenDetails.l1Address)).resolves.bnToBeEq(initialBalance);
      201 |     });
      202 |

      at Object.<anonymous> (tests/erc20.test.ts:199:56)
      ```

@mm-zk what are the steps to reproduce, I'm currently testing this way:
Terminal 1
Start base token implementation and server:
rm -rf volumes && zk && zk clean --all && zk env dev && zk config compile dev --diff 0 && zk init --base-token-name BAT && zk server

Terminal 2
Start external node:
zk env ext-node && ZKSYNC_ENV=ext-node zk db reset && zk external-node

Terminal 3
Run tests with ext-node environment:
zk env ext-node && zk test i server

output:
 PASS  tests/base-token.test.ts
 PASS  tests/erc20.test.ts
 PASS  tests/system.test.ts
 PASS  tests/l1.test.ts
 PASS  tests/self-unit.test.ts
 PASS  tests/api/debug.test.ts
 PASS  tests/api/contract-verification.test.ts
 PASS  tests/paymaster.test.ts
 PASS  tests/contracts.test.ts
 PASS  tests/mempool.test.ts
 PASS  tests/api/web3.test.ts
 PASS  tests/custom-account.test.ts

Test Suites: 1 skipped, 13 passed, 13 of 14 total
Tests:       3 skipped, 132 passed, 135 total


How about expanding it to cover other problems on Wayland Gnome?

I installed this using AUR and it has been working well. But sadly, sleeping was not the only problem I am having with MPV on Wayland Gnome. Since this plug-in already deals with Wayland Gnome, I wonder if you could add more fixes for other problems on Wayland Gnome, to make this plugin more like a one-stop "Wayland Gnome fix". If that does not fit the purpose of this plug-in, then maybe as separate plug-ins.
For example, "stay on top (shift +T)" does not work. I have to press alt+space and click "Always on Top" each time, and it has been a pain in the lower back.
Also, it does not work to drag-and-drop a video file on a Samba network share from Gnome Files (nautilus) to MPV. If I know it correctly, Gnome maps network Samba file (e.g., smb://server/file.mkv) into a local virtual file (e.g.,  /run/user/1000/gvfs/smb-share:server=server,share=file.mkv) using GVFS, but Gnome Files passes the raw Samba address when drag-and-dropping and MPV developers seem to have no intention to support GVFS. If a plug-in could convert that Samba address into its locally mapped GVFS path, and tell MPV to play that local file path, MPV will be able to play it.

Thank you for your suggestion.
At the moment I'm not too interested in solving those problems, but I would create a plugin for each of these issues, as some of those could be useful outside of GNOME.

Thanks for your consideration.
But for some reason, D&D an SMB file to MPV somehow started working since I posted this. I don't know why. I think there was some large software update that included a lot of packages, so it could be the reason, but I am not sure.

For me D&D from an sftp mount works in nautilus but not in nemo. Didn't test nautilus before tho.


[Feature] detailed error handling

When an event can't fire, there's no way to find out why not; I have to manually debug the code by commenting out parts of the state machine until it starts working again.
It'd be nice if state_machine could provide some sort of .errors method that would detail whether the state transition failed because:

No such transition is defined, period
The transition has a before_transition callback that failed (and the name of the method that was called back, if any)
Validations failed in the save action

Ideally, this would show up in the exception when event! is fired, or in an ActiveRecord .errors integration if plain event is fired.

+1

Hey guys -
Thanks for taking the time to make this suggestion!  state_machine actually already integrates with ActiveRecord for reporting errors when transitions can't occur.  See below:
class User < ActiveRecord::Base
  state_machine :state, :initial => :pending do
    before_transition :pending => :active, :do => lambda {|user| user.name != 'invalid'}

    event :activate do
      transition :pending => :active
    end

    event :deactivate do
      transition :active => :pending
    end

    state :active do
      validates_presence_of :name
    end
  end
end

u = User.new                # => #<User id: nil, name: nil, state: "pending">
u.save                      # => true
u                           # => #<User id: 1, name: nil, state: "pending">

# Invalid transitions set error on "state"
u.deactivate                # => false
u.errors                    # => #<OrderedHash {:state=>["Can't change state from pending via deactivate"]}>

# Validation errors show up as normal if transition is allowed
u.activate                  # => false
u.errors                    # => #<OrderedHash {:name=>["can't be blank"]}>

# before_transition failures / rollbacks don't change anything -- they instead
# rely on you adding errors in the callback
u.name = "invalid"          # => "invalid"
u.activate                  # => false
u.errors                    # => #<OrderedHash {}>

# If everything passes, true is returned
u.name = "valid"            # => "valid"
u.activate                  # => true

# Attribute-driven event transitions behave similarly
u.state_event = "activate"  # => "activate"
u.save                      # => false
u.errors                    # => #<OrderedHash {:state_event=>["cannot transition when active"]}>

In this example you'll notice a few things.  First, if a transition isn't allowed, it is always reported in the errors hash.  Second, if a validation fails, only those attributes that failed will have an error reported -- the state / state_event fields will not have any errors.  The lack of an error on the state / state_event field indicates that the transition was allowed.
Third, any failures in a before_transition callback or rollbacks won't cause an error to be reported (other than the event returning false).  This behavior mirrors ActiveRecord's behavior in that if a before_save callback returns false or a before_save / after_save callback rolls back, then save just returns false without reporting which callback failed.  If there are callbacks that you have which utilize this technique of canceling a transition, then the responsibility is placed on the callback to add an error to the errors collection (or somehow track the failure elsewhere).
If the problem you're seeing is that nothing is getting added to the errors collection when an invalid event is attempted, then that's probably a separate issue and I'd be happy to dig into that.  Feel free to re-open the issue if you think this is still unresolved.
Hope this helps!


Fixed pt-BR language

Fixed error in the Brazilian portuguese translation.
Fixed:

minor spelling error.

Obrigado


Update README with a note about heightForAutoCompletionView

Update README with a note about heightForAutoCompletionView. It took me a really long time to figure out why the autocomplete wasn't showing up.

Ah never mind, it's already there under the Layout header. I just didn't realize it was important to override that function!


[testing before updating branch] 0.24.x hotfix

running in buildkite as it's more reliable than locally

pipeline is no longer compatible with 0.24.x apparently 😶
oh well.  99% of it worked locally, onward to canary environments.


Assignment 4 tracking issue

Meeting with the customer

[x] Arrange the meeting with the customer
[x] Prepare the plan of the meeting
[x] Arrange the meeting with the team before meeting with the customer

Report

[ ] #54
[ ] #55
[ ] #53

Technical part
Must do (by my perception)

[x] #51
[x] #47
[x] #7
[x] #9

Must do, but only then (by my perception)

[x] #48
[ ] #49
[ ] #50
[ ] #57

#49 and #57 are moved to the next sprint


mnist preload data reader example fails

I am using tensorflow version 12, following the documentation at
https://www.tensorflow.org/how_tos/reading_data/
which points to the example:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/how_tos/reading_data/fully_connected_preloaded_var.py
however, when I run that example, I get errors about un-initialized variables. Here is the output:
python tf_mnist_preload.py
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcublas.so locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcudnn.so locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcufft.so locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcuda.so.1 locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcurand.so locally
Successfully downloaded train-images-idx3-ubyte.gz 9912422 bytes.
Extracting /tmp/data/train-images-idx3-ubyte.gz
Successfully downloaded train-labels-idx1-ubyte.gz 28881 bytes.
Extracting /tmp/data/train-labels-idx1-ubyte.gz
Successfully downloaded t10k-images-idx3-ubyte.gz 1648877 bytes.
Extracting /tmp/data/t10k-images-idx3-ubyte.gz
Successfully downloaded t10k-labels-idx1-ubyte.gz 4542 bytes.
Extracting /tmp/data/t10k-labels-idx1-ubyte.gz
I tensorflow/core/common_runtime/gpu/gpu_device.cc:885] Found device 0 with properties:
name: Tesla K80
major: 3 minor: 7 memoryClockRate (GHz) 0.8235
pciBusID 0000:87:00.0
Total memory: 11.17GiB
Free memory: 11.11GiB
I tensorflow/core/common_runtime/gpu/gpu_device.cc:906] DMA: 0
I tensorflow/core/common_runtime/gpu/gpu_device.cc:916] 0:   Y
I tensorflow/core/common_runtime/gpu/gpu_device.cc:975] Creating TensorFlow device (/gpu:0) -> (device: 0, name: Tesla K80, pci bus id: 0000:87:00.0)
W tensorflow/core/framework/op_kernel.cc:975] Failed precondition: Attempting to use uninitialized value input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs
	 [[Node: input/input_producer/input_producer/fraction_of_32_full/limit_epochs/CountUpTo = CountUpTo[T=DT_INT64, _class=["loc:@input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs"], limit=2, _device="/job:localhost/replica:0/task:0/cpu:0"](input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs)]]
W tensorflow/core/framework/op_kernel.cc:975] Out of range: FIFOQueue '_1_input/batch/fifo_queue' is closed and has insufficient elements (requested 100, current size 0)
	 [[Node: input/batch = QueueDequeueMany[_class=["loc:@input/batch/fifo_queue"], component_types=[DT_FLOAT, DT_INT32], timeout_ms=-1, _device="/job:localhost/replica:0/task:0/cpu:0"](input/batch/fifo_queue, input/batch/n)]]
Saving
Done training for 2 epochs, 0 steps.
Traceback (most recent call last):
  File "tf_mnist_preload.py", line 195, in <module>
    tf.app.run(main=main, argv=[sys.argv[0]] + unparsed)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 43, in run
    sys.exit(main(sys.argv[:1] + flags_passthrough))
  File "tf_mnist_preload.py", line 147, in main
    run_training()
  File "tf_mnist_preload.py", line 142, in run_training
    coord.join(threads)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/training/coordinator.py", line 386, in join
    six.reraise(*self._exc_info_to_raise)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/training/queue_runner_impl.py", line 234, in _run
    sess.run(enqueue_op)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 766, in run
    run_metadata_ptr)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 964, in _run
    feed_dict_string, options, run_metadata)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1014, in _do_run
    target_list, options, run_metadata)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1034, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.FailedPreconditionError: Attempting to use uninitialized value input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs
	 [[Node: input/input_producer/input_producer/fraction_of_32_full/limit_epochs/CountUpTo = CountUpTo[T=DT_INT64, _class=["loc:@input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs"], limit=2, _device="/job:localhost/replica:0/task:0/cpu:0"](input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs)]]
	 [[Node: input/input_producer/input_producer/fraction_of_32_full/limit_epochs/CountUpTo/_12 = _Recv[client_terminated=false, recv_device="/job:localhost/replica:0/task:0/gpu:0", send_device="/job:localhost/replica:0/task:0/cpu:0", send_device_incarnation=1, tensor_name="edge_13_input/input_producer/input_producer/fraction_of_32_full/limit_epochs/CountUpTo", tensor_type=DT_FLOAT, _device="/job:localhost/replica:0/task:0/gpu:0"]()]]

Caused by op u'input/input_producer/input_producer/fraction_of_32_full/limit_epochs/CountUpTo', defined at:
  File "tf_mnist_preload.py", line 195, in <module>
    tf.app.run(main=main, argv=[sys.argv[0]] + unparsed)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 43, in run
    sys.exit(main(sys.argv[:1] + flags_passthrough))
  File "tf_mnist_preload.py", line 147, in main
    run_training()
  File "tf_mnist_preload.py", line 63, in run_training
    [input_images, input_labels], num_epochs=FLAGS.num_epochs)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/training/input.py", line 305, in slice_input_producer
    shared_name=shared_name)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/training/input.py", line 262, in range_input_producer
    shared_name, name, "fraction_of_%d_full" % capacity)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/training/input.py", line 156, in input_producer
    input_tensor = limit_epochs(input_tensor, num_epochs)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/training/input.py", line 96, in limit_epochs
    counter = epochs.count_up_to(num_epochs)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/ops/variables.py", line 652, in count_up_to
    return state_ops.count_up_to(self._variable, limit=limit)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/ops/gen_state_ops.py", line 126, in count_up_to
    result = _op_def_lib.apply_op("CountUpTo", ref=ref, limit=limit, name=name)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 759, in apply_op
    op_def=op_def)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 2240, in create_op
    original_op=self._default_original_op, op_def=op_def)
  File "/home/davidsch/miniconda2/envs/mlearn/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 1128, in __init__
    self._traceback = _extract_stack()

FailedPreconditionError (see above for traceback): Attempting to use uninitialized value input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs
	 [[Node: input/input_producer/input_producer/fraction_of_32_full/limit_epochs/CountUpTo = CountUpTo[T=DT_INT64, _class=["loc:@input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs"], limit=2, _device="/job:localhost/replica:0/task:0/cpu:0"](input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs)]]
	 [[Node: input/input_producer/input_producer/fraction_of_32_full/limit_epochs/CountUpTo/_12 = _Recv[client_terminated=false, recv_device="/job:localhost/replica:0/task:0/gpu:0", send_device="/job:localhost/replica:0/task:0/cpu:0", send_device_incarnation=1, tensor_name="edge_13_input/input_producer/input_producer/fraction_of_32_full/limit_epochs/CountUpTo", tensor_type=DT_FLOAT, _device="/job:localhost/replica:0/task:0/gpu:0"]()]]

@mrry I'm noticing two recent issues about "attempting to use uninitialized value" in the past couple days. Mind taking a look?
See also: https://github.com/tensorflow/tensorflow/issues/6785

I suspect this has been broken since 4c85a95925a68fec324f70cd0d7f3d4548f97a38, which made the internal variable in a tf.train.slice_input_producer() a local variable, but didn't add any code to initialize the local variables in this example.
Assigning to @ilblackdragon, who made that change.

This is working in both r1.2 and master.


Add: Feature flag service backend integration

Date: 27/11/2024

Developer Name: @MehulKChaudhari

Description
This PR will add APIs to interact with feature-flag-service
Documentation Updated?

[ ] Yes
[x] No

Under Feature Flag

[ ] Yes
[x] No

Database Changes

[ ] Yes
[x] No

Breaking Changes

[ ] Yes
[ ] No

Development Tested?

[x] Yes
[ ] No

Test Coverage

Additional Notes
We will need to set env variables for staging and prod.
baseUrl: "FEATURE_FLAG_SERVICE_BASE_URL",
apiKey: "FEATURE_FLAG_SERVICE_API_KEY",

Closing this PR. We have implmented the authentication and integration of the feature-flag backend with feature flag dashboard without keeping website-backend in middle.


Add a service account and a role to configure the AWS access

Added a service account and a role to configure what is allowed to be collected by resoto

Nice! I think the fact that a service account will be created should also be documented in the CDK deployment guide, so that there are no surprises to the user. What do you think?


Get document ID of the newly inserted document

Hi Tom,
Using a similar structure or logic as the links I added in #13 now when I create an entity on the datastore I also created it on the document for the search. It is all working and it was simpler than I could have imagined. The only caveat is to match schema at the field name for both the search and the data store.
      // Save post
      $this->post->writeData($data);

      // Save tag name instead of tag ID on the search document
      $tag = $this->tag->getEntityByID($data['tag']);
      $data['tag'] = $tag['name'];

      $doc = $this->search->createDocument($data);

The problem now is that if I change or edit my entity and save it, a new document will be created. It will make more sense to update the existing document or to at least delete it and create a new one.

I had the same problem as you, I mean, that after inserting | updating an entity, it's key dissapeared, I've discovered by accident that you actually need to allocated the ID through allocateId method of the DatastoreClient class. From this point on, the fresh entity PHP object will allow you to do further updates at will, and the id doesn't vanish anymore. I hope this helps.

Thank you for posting an answer. Can you share some code?

For sure.
For example, I expected that the $newUser object (which is an entity) after upserting it would maintain or at least retrieve the alphanumerical automatic key name, but after that update I could not work directly on that entity for further property modifying.
This code won't work as I expected ($this->ds_client contains the DatastoreClient instance):
(Method createNewEntityButDontSave will create an entity with auto id by just defining a kind)
$newUser = $this->createNewEntityButDontSave();
$newUser->name = 'Bob';
$this->ds_client->upsert($newUser); //Here it saves the entity, no problem here
//I wanted to add other properties after saving
$newUser->money_spent = 10;
$this->ds_client->upsert($newUser); //This will throw an exception because the key doesn't exist inside the object
But if I do this (before the first upsert)
if(!is_null($newUser->key()->pathEndIdentifier())){
$this->ds_client->allocateId($newUser->key());
}
Now after the upsert the entity will be ready for reuse as many times you want, and if you want to know what was the id assigned you can get i through
$newUser->key()->pathEndIdentifier()
Now the new simplified whole thing:
$newUser = $this->createNewEntityButDontSave();
$newUser->name = 'Bob';
if(!is_null($newUser->key()->pathEndIdentifier())){
$this->ds_client->allocateId($newUser->key());
}
$this->ds_client->upsert($newUser); //Here it saves the entity, no problem here
//I can add or modify attributes
$newUser->money_spent = 10;
$this->ds_client->upsert($newUser); //This will work

Thank you for sharing the code. If it is not to much trouble can you format it with the markup? That will make it easier to read.
Like:
print 'code here';

Thank you

Of course, just didn't know how to use the embedded marking tool, I've updated the example.

Thank you very much that helps a lot.


Add disable a session recording rendition to api

all renditions should be enbaled by default on the session

Is this complete?


Update how-to-configure-firewall.md

Adding warning about losing IP when changing public network access settings. linked to ICM https://portal.microsofticm.com/imp/v3/incidents/incident/449710368/summary

@seesharprun

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

#sign-off


Ev orgideext present recommended

implementation of a lint to check mandatory presence of CAB/F OI extension if subject:OI is present

Closing this pull request because this is already implemented in lint lint_ev_organization_id_missing.go.


Paula sst reservoir

Added two scripts:

cds_era5_daily_averages.py Script gets daily averages from hourly ERA5 data through CDS api
era_process.py: Processes downloaded ERA5 data, by regridding to cubed sphere, coarsening and applying a land/sea mask

In the top level of fv3net, you can do make setup-hooks to install our precommit hooks to take care of linting issues before pushing to the remote repo.

The pull request title is used as the commit message when it is merged to master, so could you make it more specific to what this PR is doing? ex. 'add ERA5 data regrid script`


does godef-jump work since the go1.14 update?

Since the go 1.14 update, i have a very strange behavior : when i call godef-jump on a function, the file open is like : "/currentpath/2020/02/28 09" because of the day date (09 is the hour, i guess).
The installed version is 20200112.2140
Is it a bug or do I have a problem on my side?
Otherwise, thank you for this package, I use it every day!
Have a nice day,

That doesn't sound like a go-mode issue. Maybe its an issue with the version of godef you have installed. I have two suggestions for you:

Switch to using gopls and lsp-mode. Tools like godef/gocode/guru are deprecated and will probably stop working all together at some point in the future. gopls is now the best option for code navigation/code completion/type inspection. There's a good example starting config here: https://github.com/golang/tools/blob/master/gopls/doc/emacs.md

If you absolutely refuse to use gopls try recompiling godef with 1.14. If it still doesn't work try running godef from the command line and see if that work. But really you will be much better off in the long run to switch over to using gopls and lsp-mode.

Thank's you very much, i will try to use gopls - which I'm already using in part. I think my configuration is not very consistent :)

All worked perfectly. Thank's you again, and sorry for the inconvenience.


Entry fields and Escape key

User reports hitting escape key at any point in the new asset modal closes the modal unexpectedly. They are hitting the escape key out of habit for things like drop down menus when they don't want to enter a value. I suggested they try the tab/shift-tab key.
@laholstege I figure this would be a key press capture and display a confirm dialog for escape key press. Is there a way to do this one place and attach to all the new asset modals?

That is sort of default behavior, not sure if that should be changed.

I think closing the modal with escape key is something we want to keep, perhaps we should add a confirm close to the modal if any data has been entered (if possible).
this article https://simplyaccessible.com/article/closing-modals/ confirms that closing modals via escape is common and should be maintained

I agree. I didn't say get rid of the escape key function. Just add a confirm to it.

@NabilFurmoli opened new issue for same topic. Assigned both to PR #651


Allowing custom invite messages when having two different Devise User-like models

Scambra, I realised you may be quite busy but would really appreciate your help since I haven't been able to figure out how to make this work.
I have 2 user-like models in my app: 'Participant' and 'Member'. I'm trying to allow them to include a custom message when they invite other members/participants.
I'm following your  tutorial and trying to override invitation_controller.rb as suggested so I've created two sets of controllers: one on controllers/participants/invitations_controller.rb and the other in controllers/members/invitations_controller.rb.
Unfortunately, I don't seem to be able to override devise invitations controller. When using pry inside my create method seems that these custom controllers go untouched when sending an invite. What am I doing wrong?
PS.
I've also included a mailer at mailers/notification_mailer.rb as suggested, but when sending an invitation devise_invitable-1.7.1/app/views/devise/mailer/invitation_instructions.html.erb is still used to send the email and not the new custom mailer.
Below an example of the code I've used in the controller for participants.
controllers/participants/invitations_controller.rb
class Participants::InvitationsController < Devise::InvitationsController
      before_action :update_sanitized_params, only: :update

  def create
    binding.pry
    @from    = params[:from]
    @subject = params[:invite_subject]
    @content = params[:invite_content]

    @participant = Participant.invite!(params[:user], current_member) do |u| #XXX Check if :user should be changed
      u.skip_invitation = true
    end

    ParticipantInvitationNotificationMailer.invite_message(@participant, @from, @subject, @content).deliver if @participant.errors.empty?
    @participant.invitation_sent_at = Time.now.utc # mark invitation as delivered

    if @participant.errors.empty?
      flash[:notice] = "successfully sent invite to<EMAIL_ADDRESS>      respond_with @participant, :location => root_path
    else
      render :new
    end
  end
end

Controller looks right, have you changed your routes?
https://github.com/scambra/devise_invitable#configuring-controllers

Yes I've modified my routes as specified in the documentation.

Or perhaps I'm not getting it right. I'm assuming that the 'Create' method will be called when creating an invitation via something like...
Participant.invite!({:email => @invitation_draft.email}, current_member)
Am I correct? Again your help would be highly appreciated.

create controller method is called when user loads new and send form, create method in controller call Participant.invite! which create participant record.
When sending form, you should see in log create request:
Started POST "/participants/invitation" ...
Processing by Participants::InvitationsController#create as HTML

I see, I was quite confused then as calling Participant.invite! triggered the Mailer as well. Anyway it make sense now. I'll adapt my code accordingly. Thanks a lot for your help!


Aggregate bonded - partial transactions disappear

Steps:

Announce a few aggregates bonded from multisig account (one cosigner)
Go to the second cosigner and sign the first transaction.

Results:
All partial transactions disappear. You have log out/log in or switch accounts to be able to see unsaigned transactions.

Looks ok on branch gh1487-partial-transactions-disappears

Fixed in integration branch.


Is Memory supported as return type in dotnet?

I tried to use Memory<byte> as return type of a method on dotnet side and call the method from Javascript.
However, although the generated .d.ts file contains the method signature, the Javascript code is not able to call that method. The error message says the object does not have such method/property/function. I tried to change the return type to string or byte[] then the method could be called from Javascript.
Is Memory<byte> supported?
BTW, I suspected marshaller code needs to be generated and utlised, however, I couldn't find any generated file. I've created another issue for that: #207

A .NET Memory<byte> should get converted to JS UInt8Array, in both typedefs and runtime.
But there might be some other reason you're unable to call the method.

Can you check what properties are defined on the JS object? Object.keys(obj)
Do you see other expected methods/properties on the object?
How are you getting the JS instance of the class?

Can you check what properties are defined on the JS object? Object.keys(obj)

If you mean the JS object returned from the .NET method I want to call, because the method can't be called (the JS class instance does not have such function on it) there is no way to get the returned value.

Do you see other expected methods/properties on the object?

Other methods exist on the class instance as long as their return types are not Memory<T>. I tried changing the return type from Memory<byte> to string or byte[], both made that method available to Node.js.

How are you getting the JS instance of the class?

The type definition was generated through MSBuild.
I believe the class instance was created through reflection becaue I suspect the code generate didn't work (as described in #207 )
I hope there is a way to tell whether refection is used or generated code is used.
I suspect the missing of that method is caused by the missing of generated code.

BTW, currently I use base64 encoded string to pass binary data from .NET to Node.js as a workaround.

I confirmed in #220 with more testing that Memory<byte> is working as expected. So there is likely some other problem here.

the JS class instance does not have such function on it

This sounds like there was some other problem with the method that is unrelated to the fact that it returns Memory<byte>. If you want to troubleshoot further, it might help to share relevant snippets of the code.

I'm closing this for now since the originally reported problem is not reproducible. But feel free to re-open with more information if you're still having this problem.