Status not changing after leaving a call (sometimes)

I have noticed that my schoolmates' statuses and my status remains as "In a call" or "In a meeting" even after leaving the call but that doesn't happen everytime.
This leads to misconceptions many times.
Look at the top right corner
This is what happens and I am not in a call at all.
Please fix it

Thanks

@Niru2169 , We have forwarded your query to right channel. Will get back to you in sometime. Thanks for your patience

@Niru2169 , "In a meeting" probably still holds as the person left the call, because effectively the meeting is likely still going on from a calendar perspective. That's why the person likely transitioned from "In a call" to "In a meeting". When the meeting ends in calendar that's when we expect the status to change to something else (Available busy etc. based on user context). Could you please provide the logs for further investigation?


Infura

Infura RPC call

Please update /contrib/docker/docker-compose.yml with new image and we're good.


Fixed tabbing issue

Linked Issue
Fixed #1602
Description
Added tabindex="-1" to autocomplete element containers to ensure users on firefox do not tab onto the container itself. This basically removes the tab-ability from an element and make it un-tab-able.
Changsets
Changesets automate our changelog. If you modify files in /package/skeleton, run pnpm changeset, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.
Checklist
Please read and apply all contribution requirements.

[x] This PR targets the dev branch (NEVER master)
[ ] Documentation reflects all relevant changes
[ ] Branch is prefixed with: docs/, feat/, chore/, bugfix/
[ ] Ensure code linting is current - run pnpm format
[ ] All test cases are passing - run pnpm test
[ ] Includes a changeset (if relevant; see above)

A problem I'm facing with applying the fix is that the tabindex="-1" needs to be applied to the container that gets focus, and although the <ul> in the autocomplete holds the elements this is actually not the container that gets focused on, I will investigate this but it really appears that the  tabindex="-1" needs to be applied outside the Autocomplete component which could cause trouble because not every end-developer will think of that. Not sure what to do here really.

@Hugos68 so you've definitely found a tough issue here. I'm able to replicate the issue via the steps provided in your ticket.
That said, testing your updated in this PR does not resolve the issue and actually makes it somewhat worse - Instead of focusing into the search results, tabbing instead jumps to the background elements in the App Bar (explore, theme, etc).
I'm going to ping @Mahmoud-zino to review this as well since he recently made some modifications to the focus trap which should prevent this from ever occurring. So essentially we have two issues at play here:

In Firefox, focus is not being set to the search list result lists (list of anchors) as expected
In Firefox, the focus trap is not working as expecting, allowing you to escape the active modal

Unfortunately I have no guidance on this yet. It's honestly very frustrating to learn that Firefox is not operating as Chrome, which works exactly as expected.

@Hugos68 given the short time remaining this week I'm going to go ahead and merge this. If you do note any issues let me know and we can patch. Thanks.


mac os vantura support

far as i know , script isn't working with Mac OS Vantura.

Can you provide more detail? It seems to be working for my users on Ventura, but there's always a chance I'm missing something.

im not sure about it right now it was a call from HD team about it, ill try check it out


Add info filter

I'm currently using insta_cmd where my command takes an absolute path as an argument. The problem is that when snapshots are taken, the info includes my username and other specific path info:
---
source: tests/test_view.rs
info:
  program: my_program
  args:
    - info
    - /Users/my_username/Documents/my_image.jpg
---

I'd like to avoid exposing my username and local filesystem structure and keep the info more general. For now I'll hide all of the info, but it'd be better if it can be filtered. This issue is applicable to both insta and insta_cmd because of how it records the info.
Edit: It seems using Settings::set_raw_info or Settings::remove_info or Settings::remove_description doesn't actually hide the info, so I'm not sure if  a workaround exists for this issue?

This is a known issue with insta-cmd at the moment. Right now I recommend to use inline snapshots which will omit this.


[Type checker] Stop (ab)using TypeChecker::Diags to suppress diagnostics.

Take away the type checker constructor that allows one to provide a
diagnostic engine different from the one associated with the ASTContext. It
doesn’t actually work to suppress diagnostics. Switch all clients over to
the constructor that takes only an ASTContext.
Introduce the DiagnosticSuppression RAII class so clients that want to
suppress diagnostics can suppress all diagnostics. Use it where we
were previously suppressing diagnostics.

@swift-ci please smoke test and merge


WIP: added nonfunctioning select all btn to scene browser

Overview
This PR implements a currently non-functioning select all button in the scene browser.
I need dev support in making the button work. It should function exactly the same way as the select all button in the editor.
Checklist
~- [ ] Styleguide updated, if necessary~
~- [ ] Swagger specification updated, if necessary~
Demo

Notes
The button does not yet function. Developer support needed.
Testing Instructions

Go the scene browser
Select all button should appear in the footer of the sidebar next to selected scenes button.

Connects #836

I think we should do all viewable scenes at this point

You could disable the select all button when there are more scenes than a certain threshold.

do we have a limit to the number of scenes a project can have?

No, I don't think we can -- e.g. if someone is making a world basemap. Adding scenes to projects doesn't cost us anything, but figuring out how to handle UX may be difficult.
For bulk adding, we could add an endpoint later specifically for this. In this case, rather than send an API with all the scenes to add, we send the filters and the backend handles this.
The UX could be something similar to how gmail handles selecting all emails vs visible emails then.

For now, there's a practical limit in how many scenes we can show at once in the project editor because each scene is displayed as a separate leaflet basemap - above 10, it starts to get laggy since you need a request per tile per basemap.  This should be optimized out once are able to use the mosaic tiler, as that will only use a single basemap.

That's true about the practical limit, yeah.

Using gmail as an example, when you search and then select all theres a message that says "Selected the first 50 results,  to select all results that match this search". It's about the most reasonable way to handle that situation.

@designmatty can you pull this down and verify functionality is what we talked about?

if some scenes in the current view aren't selected, the select all button adds all visible scenes to selected scenes
if all scenes in the current view are selected, select all deselects all scenes in the current view (unclear whether this should deselect all scenes everywhere?)
if we load more scenes by scrolling off the end of the infinite scroll, we set allSelected to false and the behavior of the button is as above
if we change query parameters and load different scenes we check whether all of them are selected and respond accordingly (you can have all scenes selected with changing query params by zooming in, e.g.)

Here's a gif:

Created an issue to add the bulk select all endpoint


Refine Tech Radar Plugin Code Quality & Style

In Issue 661 the Tech Radar component files were updated to use TypeScript & React Hooks.
This transition was done while keeping the code changes to a minimum. As a result, there are a number of code style concerns and somewhat strange typings that have resulted.
The goal of this issue would be to clean those up.
Feature Suggestion
Review the Tech Radar files to address these style concerns:

Inconsistent function naming
Functions that are unnecessarily prefixed with _
Bloated functional components
Other formatting/stylistic inconsistencies, etc.

Review the Tech Radar files to address these code quality concerns:

Removing type safety hacks or excessive null checks
Adding unit tests, where possible

Possible Implementation
The Props type definitions likely need to be narrowed to remove null/undefined union types. Many of the child components treated these values as always-present prior to the TypeScript migration, so it will be necessary to update the callsites to provide all of the required Props.
Removing the presence checks for many of the Props will likely go a long way to cleaning up these components.
Context
Original Issue for the TypeScript migration
TypeScript Migration PR

Can I take this one ? 👍

@ayshiff absolutely, assigning you!


Remove unneeded packages which are getting added in all generated operators

Currently operator sdk has indirect package dependency on bou.ke/monkey v1.0.1/go.mod
This package license says to not to use it.
https://github.com/bouk/monkey/blob/master/LICENSE.md
This will make all the operators generated from operator sdk have reference to the same package.

Related issue https://github.com/operator-framework/operator-registry/issues/190

Closing as duplicate to #3170.


Added Image in node still appears on creating new (empty) node

Creating node
Adding Image
Save
Creating new node
=> the image which was added before is still display in the Image media field

Seems to be fixed by https://github.com/sulu-cmf/sulu/pull/806


Include a separate script for processing single data files

This would be used for troubleshooting and checking for issues. Ideally, this script would plot cycle-by-cycle data for each of the m/z beams (for ref and samp), little deltas, big deltas, and d13C/d18O (not sure how you would calculate D47/d13C/d18O without ETH data, so if you can't just skip that part). The output could be 2-3 multipanel plots. If you can plot D47, it may also be useful to illustrate bad cycles on this plot, like your 'data vetting' script current does.

Could be improved but is in there.


Backdoc-generated documentation is used in a commercial product

Hi Gennady,
I'm happy to inform you that Backdoc is used for generating documentation for Showerma Drupal module.
Congrats with having early commercial adopters! ;)
Best,
Konstantin

Cool! But I can't see any docs there. Are they bundled in module?

Yes, they are. I've not yet decided whether I want to open them or not.
However, if you're interested to take a look at the docs I can send you them through email.


modules: Updated Tracerecorder to version 4.8.1

This updates the tracerecorder part of the Percepio module to version 4.8.1.

This PR seems to be outdated, closing


include the response body in log.Errorf messages

Before:
INFO[2023-02-11T23:44:43+01:00] Sending 50 market offers to ingest
ERRO[2023-02-11T23:44:50+01:00] HTTP Error while prooving pow. returned: 999

After:
INFO[2023-02-11T23:44:43+01:00] Sending 50 market offers to ingest
ERRO[2023-02-11T23:44:50+01:00] HTTP Error while prooving pow. returned: 999 (TEST TEST TEST)

It will print whatever aodgate returns as body.

replaced with https://github.com/ao-data/albiondata-client/pull/28 because of merge conflicts


Infrastructure-agent pipeline

Just cross-mentioning here that from https://github.com/newrelic/infrastructure-bundle/pull/61 we found out alpine does not seem to be pushing updates very often to their minor branches (e.g. alpine:3.13), so snyk yells about vulnerable versions of openssl and the likes.
I patched this by adding a RUN apk --no-cache upgrade step, but that really doesn't fit in the bundle image, but rather here. This might be a good opportunity to add it, or at least discuss about the approach.

Just cross-mentioning here that from https://github.com/newrelic/infrastructure-bundle/pull/61 we found out alpine does not seem to be pushing updates very often to their minor branches (e.g. alpine:3.13), so snyk yells about vulnerable versions of openssl and the likes.
I patched this by adding a RUN apk --no-cache upgrade step, but that really doesn't fit in the bundle image, but rather here. This might be a good opportunity to add it, or at least discuss about the approach.


Use 1001 Going-Away code in websocket shutdown example

The current example (with 999 code) will result in exception: WebSocketError: Invalid close code: 999

Current coverage is 98.34% (diff: 100%)

Merging #1215 into 1.0 will not change coverage

@@                1.0      #1215   diff @@
==========================================
  Files            29         29
  Lines          6530       6530
  Methods           0          0
  Messages          0          0
  Branches       1094       1094
==========================================
  Hits           6422       6422
  Misses           56         56
  Partials         52         52

Powered by Codecov. Last update a6e39f2...7bb229a

Thanks!


puffer finance registration

Name
Puffer regristration
Description
I accidently sign up and approve a transaction on a scam from this website  https://registration-puffer.com/ which drain all my chainlink from one of my wallet. please be careful and check the username carefully. I should of knew better. this is the transaction id 0xe12e1e23567936a55eb5884638e3a31ba33c4e6dcec75c54324f3f14b6efafd4. and the wallet of the scammer is 0x514910771AF9Ca656af840dff83E8264EcF986CA. im so mad right now but what can i do.
Addresses
my affected address is 0x73CE4B49C6abf940E53663b4542EB9f19D0092b7, the tranasction id is 0xe12e1e23567936a55eb5884638e3a31ba33c4e6dcec75c54324f3f14b6efafd4
Meta Article URLs
https://registration-puffer.com/

As mentioned in the issue template, this repository is not for reporting individual losses, only for large scale smart contract exploits. If you need support, please join the Revoke.cash Discord (see website footer for a link).


Allow create for staff, update for staff or owner

I'm adding a user resource to an API.
I want the following permission logic:

Staff may do anything
Users may read and update themselves

So I start out with this:
@staticmethod
def has_write_permission(request):
    return request.user.is_staff

Now staff users can create other users, but regular users can't.
Next, I want to allow users to update themselves, so I add the following:
def has_object_write_permission(self, request):
    return request.user.is_staff or request.user == self

However, the method is never called because the write permission is already denied globally.
So I update the code as follows:
@staticmethod
def has_write_permission(request):
    return True

def has_object_write_permission(self, request):
    return request.user.is_staff or request.user == self

Now the code first calls has_write_permission, then has_object_write_permission. This is fine.
But now any user has the create permission. I want to limit creation to staff. So I add the following method:
@staticmethod
def has_create_permission(request):
    return request.user.is_staff

However, this method is never queried by dry-rest-permissions. Only has_write_permission is called, which already grants the permission.
Am I mis-understanding the concept of dry-rest-permissions?

Oh, I think I found the problem. I'm not using viewsets.
What do you think about offering has_<httpmethod>_permission for non viewset based views? Would you accept a PR?

Actually something like this helped already:
class ActionMixin:
    """
    This mixin adds an ``.action`` attribute to the view based on the
    ``action_map`` attribute, similar to the way a ``ViewSet`` does it.

    Example::

        class UserDetail(ActionMixin, generics.RetrieveUpdateAPIView):
            queryset = models.User.objects.all()
            serializer_class = serializers.UserSerializer
            action_map = {
                'GET': 'detail',
                'PUT': 'update',
                'PATCH': 'partial_update',
            }

    """
    def initialize_request(self, request, *args, **kwargs):
        """
        Set the `.action` attribute on the view,
        depending on the request method.
        """
        request = super().initialize_request(request, *args, **kwargs)
        method = request.method.lower()
        if method == 'options':
            # This is a special case as we always provide handling for the
            # options method in the base `View` class.
            # Unlike the other explicitly defined actions, 'metadata' is implicit.
            self.action = 'metadata'
        else:
            self.action = self.action_map.get(method)
        return request

class DocumentActionMixin(ActionMixin):
    """
    Add an ``.action`` attribute to a document type view.
    """
    action_map = {
        'get': 'detail',
        'put': 'update',
        'patch': 'partial_update',
        'delete': 'destroy',
    }

class CollectionActionMixin(ActionMixin):
    """
    Add an ``.action`` attribute to a collection type view.
    """
    action_map = {
        'get': 'list',
        'post': 'create',
    }

But a clear note in the documentation would probably help.

Hey Danilo,
What I would do to get the desired result would be to not use the has_write_permission function at all. Since your use case is more nuanced I would use:
has_create_permission (only allow staff)
has_update_permission (allow anyone)
has_object_write_permission (As you had it with the or statement)

@dbkaplan the thing is that apparently when using the DRF browseable API without having has_write_permission and has_read_permission defined, I get exceptions for a page view, because the API checks for available permissions even for methods that I don't even support. Maybe that's related to #40.

That is true. Sorry I didn't realize that was the problem you were having.
I usually get around that by creating the generic has_<write/read>_permission functions and having them return False, but decorating them with @allow_staff_or_superuser. This will only open them up for those situations. I would then still use the other functions as I specified above.

I was using GenericAPIView's and also had the problem of exceptions when I didn't include has_write_permission, nor was the precedence of has_object_update_permission over the global has_write_permission being followed.
Using the mixin that @dbrgn provided with slight modification to super()  (I'm using Python 2.7), I was able to get it to work properly with/using APIViews instead of ViewSets.
Here's my modified mixin in case anyone needs it:
from rest_framework import (
    generics,
)

class ActionMixin:
    """
    This mixin adds an ``.action`` attribute to the view based on the
    ``action_map`` attribute, similar to the way a ``ViewSet`` does it.

    Example::

        class UserDetail(ActionMixin, generics.RetrieveUpdateAPIView):
            queryset = models.User.objects.all()
            serializer_class = serializers.UserSerializer
            action_map = {
                'get': 'retrieve',
                'put': 'update',
                'patch': 'partial_update',
            }

    """
    def initialize_request(self, request, *args, **kwargs):
        """
        Set the `.action` attribute on the view,
        depending on the request method.
        """
        request = super(generics.GenericAPIView, self).initialize_request(request, *args, **kwargs)
        method = request.method.lower()
        if method == 'options':
            # This is a special case as we always provide handling for the
            # options method in the base `View` class.
            # Unlike the other explicitly defined actions, 'metadata' is implicit.
            self.action = 'metadata'
        else:
            self.action = self.action_map.get(method)
        return request


Support Inline Completions

The Inline Completions API has been finalized in VS Code, so support should be added to the LSP.

This is in the backlog, are you open to PRs for this? The public VSCode API provides a clear path, in my opinion. Happy to send PRs here for the spec and https://github.com/microsoft/vscode-languageserver-node

Meta is also interested in helping push this forward! How can we help?

@dbaeumer In implementing this in our LSP, we are finding the need to throttle these events, wait to see if a cancellation is sent, etc. As such, it would be helpful to formalize the LSP request so it takes a VersionedTextDocumentIdentifier (or perhaps to be more flexible, an OptionalVersionedTextDocumentIdentifier) rather than a plain TextDocumentIdentifier so that by the time the inline completions request is handled, it can verify that the version of the document it has in memory matches the one that was specified in the inline completions request (as text document update events may have been processed inbetween).

PRs are welcome. But they have to be made for vscode-languageserver-node (or another implementation) as well.

@bolinfest IMO this is not necessary since the ordering in which requests and notifications are sent to the server guarantees that a request is always on the latest updated document state the client has sent. If a server reorders these (which he is allowed to do) then the server needs to keep track of the versions the reordering has happened.

@dbaeumer Another request (which is perhaps strictly spec-related) is that I see that ErrorCodes.ServerCancelled has the following caveat:
/**
 * The server cancelled the request. This error code should
 * only be used for requests that explicitly support being
 * server cancellable.
 *
 * @since 3.17.0
 */

Could we formally declare that inline completions are server cancellable?

No, we can't since this is client specific. There is a serverCancelSupport capability for those requests that support this. To my knowledge VS Code doesn't have cancel support (that retriggers the request) for inline completion. It does for semantic tokens.

This got added as proposed for 3.18.


Licence change?

Now that there is support for postgres under MIT licence, I'm wondering if you are considering a change of licence.
I'm don't know how to really intrepid the licence it seems like it's permissive in some parts and really restrictive in other parts, to the point where all the forks are illegal. I'm not a lawyer just a developer so I couldn't say. But it just means I'm not going to touch the source code as is.

@olafura we're tracking this request in https://github.com/Microsoft/azuredatastudio/issues/102.  I'll close as a duplicate.  (I'm not a lawyer either so I don't really have anything substantive to add. 😄)

@kburtam thank you so much I tried searching but couldn't find the issue.


CI: unstable Codecov Report

[x] I have checked the discussions
[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Describe the bug
Sometimes in Codecov Report, coverage will decrease even change non .java file.
To Reproduce
Change an index.html like https://github.com/apolloconfig/apollo/pull/4908
Expected behavior
Coverage of project should be same as previous commit.
Screenshots
https://github.com/apolloconfig/apollo/pull/4908#issuecomment-1599772570

https://github.com/apolloconfig/apollo/pull/4908/checks?check_run_id=14705443703

I think it's because it also includes the html code to the coverage?

See Unexpected Coverage Changes.


move to using released appinsights version

appinsights 0.2 was released, enabling rustls by default.  As such, we
can now track the released versions rather than a specific git hash.

A bunch of integration tests are breaking (beyond the known issues with windows libfuzzer).  I will dig into this to see if it's this PR or a wider issue.

not functional as is, more investigation on this needed, potentially moving to tracing pipeline as discussed offline.


Remove failing functional tests

Goal
Removes some functional test cases that have started failing. This seems to be infrastructure related in some respect as I retried a passing job from 2 days ago & it fails now.
The test code that asserts a failed request is stored on disk seems somewhat brittle, so I've decided to try removing those test cases as they're still covered by unit tests elsewhere.

I will add a KTLO task to the backlog to restore these


Release tag?

Could you tag a commit you are particularly happy with to make a release?

I'll make a release in the coming week!


Only depend on rspec-core.

The things we need are all in rspec-core, so we don't need to depend
on the rspec meta-package. Many people use the rspec-rails meta-package
and causing the other to be added as a dependency is a bit unfriendly.

I agree! Seems to work everywhere.


fix(terraform): skip formatting check

👍 for this change.
It's annoying to not be able to quickly deploy a hotfix to an environment because the formatting check fails...
terraform fmt -check should be part of your linter workflow instead (e.g. using our super-linter.yml workflow).


feat: upgrade to Elm 0.19

closes #1

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: YetAnotherMinion sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

I just published 2.0.0 which supports Elm 0.19. Thanks for your contribution.

@klazuka Woops, I did not see that you already had a branch. Thank you for your fast turnaround.


Add measure tool

For #7

Bug on chrome: the tooltip 'on last point' does not refresh, while FF does

Bugs are fixed (update of help tooltip messages on last/first point)
It works now on chrome, FF and IE
I saw that div 'Measure' / 'Cancel measure mode' no longer update if a language is changed during a drawing. I am setting that now.

@oterral ,

In my last commit I removed an useless (in my opinion) call of the updateHelpLabel function at the beginning of the 'drawstart' event.
I initialize the help message in the activate function

I'd say now it is bug-free

2 minor comments, fixes it and squash !!!  awesome work @kandre !!

Found other things:

add z-index:900 to the map , add z-index:1000 to the catalog
Fix translation of measure link and help start tooltip

Pushed !

Squashed

Thanks !!


Cawllec/update rake version

Goal
Allow new versions of Rake to be used with testing and later Ruby versions, while retaining
Changeset
Changed

Added conditional to Rake to ensure compatibility across Ruby versions

Tests
Locally tested the correct Rake versions are loaded on 1.9.3 vs newer Ruby versions

We still need it for 1.9.3 unfortunately


Add Remark command

Add Remark command to allow users to add an optional remark to their contacts

Codecov Report

Merging #2 (3ff0a90) into master (4c141e5) will decrease coverage by 0.80%.
The diff coverage is 55.71%.

@@             Coverage Diff              @@
##             master       #2      +/-   ##
============================================
- Coverage     72.15%   71.35%   -0.81%
- Complexity      399      409      +10
============================================
  Files            70       73       +3
  Lines          1232     1288      +56
  Branches        125      132       +7
============================================
+ Hits            889      919      +30
- Misses          311      331      +20
- Partials         32       38       +6

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/AddressBookParser.java
88.88% <0.00%> (-11.12%)
:arrow_down:

...eedu/address/logic/parser/RemarkCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
25.00% <14.28%> (+5.00%)
:arrow_up:

...va/seedu/address/logic/commands/RemarkCommand.java
56.52% <56.52%> (ø)

...c/main/java/seedu/address/model/person/Remark.java
62.50% <62.50%> (ø)

...c/main/java/seedu/address/model/person/Person.java
95.74% <88.88%> (-1.88%)
:arrow_down:

...java/seedu/address/logic/commands/EditCommand.java
97.05% <100.00%> (+0.04%)
:arrow_up:

...a/seedu/address/logic/parser/AddCommandParser.java
100.00% <100.00%> (ø)

...ain/java/seedu/address/logic/parser/CliSyntax.java
85.71% <100.00%> (+2.38%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c141e5...3ff0a90. Read the comment docs.


"bx iam org-users" returns blank lines

As with cf org-users, bx iam org-users also returns blank lines.
I have access to this information for the org in question (I can see it in the Bluemix dashboard), so this seems strange, as I'd expect a dedicated Bluemix CLI to send back the correct information.
The same problem is encountered for space-users.
cf version 6.15.0+fa1bfe2-2016-01-13
bx version 0.3.0-4b6b71d-2016-02-19T09:07:14+00:00

Asked on stackoverflow https://stackoverflow.com/questions/35516835/bluemix-cli-lists-blank-lines-for-org-users-and-space-users


Add flatpak-builder-tools submodule

I was hoping it was possible to make a cargo subcommand? Or maybe even automatically run it when cargo run or cargo build is being ran.

Doesn't that defeat the purpose of reproducible builds? If we run the Python command everytime we try to build it, it will fetch all latest versions, which would make it irreproducible. In that case we can enable network support during build time if you wish.

Ok so maybe not by default, but a separate cargo subcommand would still be nice (if possible) to ease generation of the right stuff.

@PureTryOut is this what you were talking about? https://github.com/TheEvilSkeleton/Leafish/commit/1ebd1e7fb3841a9d7fb65892dff983a11d3b1a36

Not quite, although this is getting close. The script looks good, nice work so far.
I meant it'd be great if I could just run a cargo update-dependencies (for example).
However this scripts works well enough for me already that I'll merge it as is. We can do a cargo subcommand later.

I meant it'd be great if I could just run a cargo update-dependencies (for example).

Hmm... I don't know much about cargo so sadly I cannot really help.

Thanks @TheEvilSkeleton this project really needed this PR.
But why aren't you using 21.08 freedesktop: https://github.com/bilelmoussaoui/flatpak-github-actions/commit/47e4de41f760530ebad88296894877f2d2cab0aa
?

But why aren't you using 21.08 freedesktop: bilelmoussaoui/flatpak-github-actions@47e4de4
?

It's because there isn't a tagged released with 21.08 included. Perhaps there's a way to include commits?

Hmm... I just tried using commits, but that didn't seem to work: https://github.com/TheEvilSkeleton/Leafish/pull/2/checks?check_run_id=3567089753

Hmm... I just tried using commits, but that didn't seem to work: https://github.com/TheEvilSkeleton/Leafish/pull/2/checks?check_run_id=3567089753

Yeah, they have removed rust as you can see in the link, and they explained how you can use rust in the latest version.
What's actually the current problems before releasing it as a flatpak?

I actually don't know.


feat: AD-158 Add ELBv2 target groups

Adds ELBv2 target groups

Replaced by https://github.com/plerionhq/plerion-asset-counter/pull/10


Add RPC API endpoint table

Signed-off-by: Nana-EC<EMAIL_ADDRESS>Description:
The Relay currently doesn't have a quick reference of support endpoints and request steps.
An Open RPC spec will be added for greater detail but a simple table with basic information may be useful
Add an rpc-api.md to highlight

types of methods
basic request and response structure
endpoint table

Related issue(s):
Fixes #137
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2f697fe). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage        ?   62.35%
=======================================
  Files           ?        9
  Lines           ?      874
  Branches        ?      143
=======================================
  Hits            ?      545
  Misses          ?      291
  Partials        ?       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f697fe...df4dd7a. Read the comment docs.


Add filter spec option for background color

Cleaned up photos are often extracted from a background. For example product beauty shots.  It would be nice if these images could be uploaded to wagtail as transparent png files and then templates could specify the background matte to apply to the image for the rendition.  This way the images appear to be transparent but jpeg compression can be used.  Right now one must either use transparent PNG and accept the large file size or apply the jpeg background matte before uploading the image.  If you go with the jpeg option when the page css changes all images on the site have to be replace and reuploaded which is a time consuming and difficult process (also error prone when the images can be displayed on different background colors)
Would it be feasible to add background matte into the filter spec options?  And perhaps rendition format?  So jpeg could be forced using a specific background color?

I'm working on the first part of the request (add background matte into the filter spec options) but I don't understand enough of Willow/Wagtailimages internals to manipulate the output format just yet.

https://github.com/torchbox/wagtail/pull/2474 Implements an outformat filter so I think we just need something to fill in the background color now.

So it doesn't appear that this ever gained any traction and I'd like to pick it up. I've implemented the background matte operation as a 3rd party app using the willow/wagtail hooks.  Is this filter something that would be integrated into wagtail? If so I am happy to post it to github for review and I would be happy to refactor it for inclusion to willow/wagtail proper if it would be merged

Just implemented a set_background_color_rgb operation in Willow: https://github.com/wagtail/Willow/pull/61


add multi_pass_weld-0.1.0.yaml

Changes
Describe changes in this PR
Related Issues
Closes # (add issue numbers)
Checks

[ ] updated CHANGELOG.rst
[ ] updated tests
[ ] updated doc/
[ ] update example/tutorial notebooks
[ ] update manifest file

As already mentioned yesterday, the references in the definitions do not work.  In contrast to the a members, the aas don't get validated by the schema and everything passes. As soon as you enable one of the other members, the following error gets raised:
jsonschema.exceptions.RefResolutionError: Unresolvable JSON pointer: 'definitions/C'

Seems like nested $ref calls are not supported by either JSON schema or the yaml-ized version asdf is using. The question is how we want to solve this. We can simply introduce tagged objects to circumvent the problem. What we can also do is just copy-pasting everything into the first referenced object but this results in a very unpleasant definition. I did it to test serializing our experimental data against the schema. So it works (why shouldn't it?), but it is really ugly.
 This should also be resolved by tagged objects since there will be at least a separating tag (IIRC) and probably another property name to store the next array.

thank you for the report @vhirtham :)
One possible issue I could see with the nested references is that it might break when using a "relative" reference (that is not resolvable within a nesting)
So we might try to use absolute schema references here like
$ref: "asdf://weldx.bam.de/weldx/schemas/datamodels/multi_pass_weld-0.1.0#/definitions/weld_bead"
or maybe it works on the file level with $ref: "./multi_pass_weld-0.1.0#/definitions/weld_bead"
if the absolute reference doesn't work we should probably check in with the asdf devs

Okay, got the $ref stuff sorted out. The problem is, that the schema has no $id. If one adds
id: "asdf://weldx.bam.de/weldx/schemas/datamodels/test_schema-0.1.0"

and actually puts the schema in the corresponding directory, the relative references work without further problems. So I have to  create a dev kernel on the server and use a working branch to further develop the schema and apply it to the experimental data using the already existing jupyter notebook. However, I think I will draft it locally with dummy data before trying it on the real data. Should save some time by avoiding huge data chunks.

Okay, got the $ref stuff sorted out. The problem is, that the schema has no $id. If one adds
id: "asdf://weldx.bam.de/weldx/schemas/datamodels/test_schema-0.1.0"

and actually puts the schema in the corresponding directory, the relative references work without further problems. So I have to create a dev kernel on the server and use a working branch to further develop the schema and apply it to the experimental data using the already existing jupyter notebook. However, I think I will draft it locally with dummy data before trying it on the real data. Should save some time by avoiding huge data chunks.

can you please update the schema on this branch (it is already tagged with an id) to a working state? @vhirtham
for a simple dev kernel on JupyterHub, this should work:
mamba create -n weldx_test python=3.9
mamba activate weldx
mamba install weldx --only-deps

then register the kernel in this environment, clone this repository/branch and local pip install

The schema works with the experimental data, but we should still discuss this:

Another thing I wanted to mention: The way nested arrays are stored is also not very nice:
my_array
- - - v: a
    - v: b
  - - v: c
  - - v: d
- - - v: e
    - v: f

The schema works with the experimental data, but we should still discuss this:

Another thing I wanted to mention: The way nested arrays are stored is also not very nice:
my_array
- - - v: a
    - v: b
  - - v: c
  - - v: d
- - - v: e
    - v: f

It's not pretty but I still think this is the most 'natural' way to define the schema
how does it look in our WeldxFile.info or WeldxFile.show_asdf_header outputs?


Website appears to be broken

I get the following error:

ReferenceError: Navigo is not defined app.js:10:5

Opening in recent Firefox, no ad blockers enabled. Clicking a link, such as documentation, results in nothing happening.
The following URL, loaded by the showdown site, is a 404:

<EMAIL_ADDRESS>

Appears to be due to unpkg being broken.


Add glue for pouchdb-find methods: query, createIndex, deleteIndex, and getIndexes.

Just started experimenting with ember-pouch and had a need for the query functionality... So I thought I'd  take a quick first pass at getting pouchdb-find methods integrated into this project (as described in #3 and #7 on ember-pouch). I haven't tested this extensively beyond the few unit tests I added and any feedback is welcomed.

Looks like the travis-ci build failed because of Error: Cannot find module 'pouchdb'. I experienced this locally when I first setup the project as well. Had to run npm install pouchdb to get up and running locally.

Thanks for this PR, looks great! :) The issue with pouchdb is because the pouchdb module structure changed, so that "pouchdb": "pouchdb/pouchdb" in the package.json will no longer work. Instead, it should just use the latest version from npm.
I will give this a closer look, but it seems to be going in the right direction, and if the tests pass I'll be +1.

I'm sorry for taking so long to get around to this. I'm taking a second look at it.

closing in favor of #49


Polygon2D Antialiasing doesn't antialias.

Godot version:

3.2.4.rc3
OS/device including version:

Windows 10 PC with RTX 2060, using the most recent NVidia Game Ready drivers and the GLES3 backend.
Issue description:

When I enable the "Antialias" property on a Polygon2D node, it does no antialiasing. I expect that option to enable antialiasing on that polygon.
Steps to reproduce:
Add a Polygon2D in your scene and enable Antialiasing. Presumably MSAA needs to be enabled in the project settings, which it is on my project.
Minimal reproduction project:

Polygon2DAntialiasing.zip

Turning anti-aliasing on in the polygon doesn't actually turn anti-aliasing on, this is correct, this should probably be changed in the class reference.
Turning anti-aliasing on draws lines around the poly using GL_HINT_SMOOTH (but only on GLES_OVER_GL devices, such as desktop). However this is only a hint, so this setting is basically a vague request for anti-aliasing, it doesn't guarantee anti-aliasing.
It doesn't use MSAA or anything full screen.

Try disabling HDR in the Project Settings.

@Calinou Disabling HDR doesn't seem to change anything. After further testing today, it seems that some behaviors have changed since last night. Antialiasing happens in-game for all non-skinned polygons with antialiasing enabled, whether or not HDR and Batching are enabled. However, there is no in-editor antialiasing. Also, for whatever reason, my AnimationTree Add2 is now acting like a Blend2.

not only polygon2d. all 2d lines and polygons

This is now documented by https://github.com/godotengine/godot-docs/pull/5746, closing.


Fiat currency; fixes for running on Apple Silicon

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation).  For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author

[x] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[x] Does the code abide by the Coding Guidelines?
[ ] Automated tests: Did you add appropriate automated tests for any code changes?
[ ] Code coverage: Did you check the code coverage report for the automated tests?  While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
[ ] Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
[x] Run the app: Did you run the app and try the changes?
[ ] Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
[x] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

[ ] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
[ ] Ad hoc review: Did you perform an ad hoc review?  In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[ ] Automated tests: Did you review the automated tests?
[ ] Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
[ ] How is Code Coverage affected by this PR? We encourage you to compare coverage before and after your changes and when possible, leave it in a better place. Learn More...
[ ] Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
[ ] Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

Great PR! awesome feature!.
I have left blocking and non-blocking comments that might be resolved with code, clarifying comments or TODOs with future issues to be resolved later.

Thank you, @pacu, for your invaluable and timely code reviews, especially as we approach Nighthawk's public release.
However, it's important to note that the 2023 grants committee has unanimously voted to reject the wallet maintenance proposal, following an already partially approved budget for our team. This decision poses challenges for Nighthawk developers ability to meeting user needs. We encourage you to contribute by opening a pull request to the project if you have ideas or solutions.

Great PR! awesome feature!.
I have left blocking and non-blocking comments that might be resolved with code, clarifying comments or TODOs with future issues to be resolved later.

Thank you, @pacu, for your invaluable and timely code reviews, especially as we approach Nighthawk's public release.
However, it's important to note that the 2023 grants committee has unanimously voted to reject the wallet maintenance proposal, following an already partially approved budget for our team. This decision poses challenges for Nighthawk developers ability to meeting user needs. We encourage you to contribute by opening a pull request to the project if you have ideas or solutions.
https://forum.zcashcommunity.com/t/nighthawk-wallet-maintenance-and-self-funding-improvements/45048/16

I'm sorry that you folks didn't get that grant :(. I will continue contributing to NH's codebase for sure!


Re-enable assertion in TreeElements

In CL 11307008 I had to disable an assertion because it isn't always true. This indicates that we resolve the same tree nodes twice, and we shouldn't do that.

This is obsolete or will soon be.


caseExpression in Decision System Task - Example

I have Issues using the caseExpression of the Decision Task,  can someone provide an Example of how to use it in Combination with the workflow input value?  I want to express something like this: ${workflow.input.value} >10 ? 1 : 0

In case anyone stumbled across this.
inputParameters: {'isOkay': '${workflow.input.isOkay}'},
caseExpression: `function scriptFn(){if($.isOkay == false){ return 'not_okay';} else if($.isOkay == true){ return 'okay'; }else{ return 'okay_but_not_okay'}};scriptFn()`,


Ensure pod-autoscaler docs contain instructions to work with HorizontalPodAutoscaler

Is this a BUG REPORT or FEATURE REQUEST?
Choose one: BUG REPORT or FEATURE REQUEST

What happened:
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

it can be pointed to Kubernetes HPA Officials docs if anyone want to implement HPA before they use


Is there any part related pre-training process here

I have reviewed the code, but I haven't found any code for the pre-training process or the processing of the pre-training dataset. Is this part not provided or did I miss it ..

It is not on the repo yet. We are iterating to optimize the process.


Added webpack for browser support

I think something as simple as iban-to-bic would benefit greatly from the ability to be imported directly in the browser without the explicit need to clone the package.
This enables websites to provide bank-style autocomplete for BIC codes that are known by the system. Making it incredibly convenient for website users.

Note: I included the dist folder, removing it from the .gitignore. This seems to be a common practice among packages that use webpack to generate a built version. I hope I didn't overstep any project policy by doing so.


How to enable icons and hyperlinks in the context menu?

In v3.0.2 there is no menu entry for icons or hyperlinks. How to configure the menu properly?

Use this https://github.com/ssshooter/node-menu


Add basic support for native Hue sensors

Description:
This PR adds support for Hue motion sensors and their integrated light-level & temperature sensors.
In future, this could be expanded to include support for Hue switches and artificial sensors.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9084
Example entry for configuration.yaml (if applicable):
unchanged
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New files were added to .coveragerc.

I'll address these shortly, thanks for the feedback. Some of these corrections are an upshot of me copying code from the light module and not understanding broader codebase guidelines.

Updated to resolve some comments, queried a few others. Tests to follow...

FYI this PR will require tests to be written. The last Hue PR I had to close because the person refused to write tests and thought we would just accept without, which we don't.

Will pick this up again this evening.

"hammer" is a bit strong, but yes. A compromise to avoid overcomplicating
the code and to meet the requirement of having the binary sensors and
regular sensors as separate component modules.
On Mon, 8 Apr 2019, 19:45 Robert Svensson<EMAIL_ADDRESS>wrote:

@Kane610 commented on this pull request.
In homeassistant/components/hue/sensor_base.py
https://github.com/home-assistant/home-assistant/pull/22598#discussion_r273187779
:

   aiohue.sensors.TYPE_ZLL_TEMPERATURE: {

       "binary": False,

       "name_format": TEMPERATURE_NAME_FORMAT,

       "class": HueTemperature,

   },

   aiohue.sensors.TYPE_ZLL_PRESENCE: {

       "binary": True,

       "name_format": PRESENCE_NAME_FORMAT,

       "class": HuePresence,

   },

})

bridge = hass.data[hue.DOMAIN][config_entry.data['host']]
hass.data[hue.DOMAIN][CURRENT_SENSORS] = {}

async def async_update_bridge(now):

Wouldn't this hammer the sensor endpoint twice?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/22598#pullrequestreview-224021959,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAI-fkTQktC7Orqz7cVPnNlwBXSU97qpks5ve444gaJpZM4cUgHQ
.

This will require tests to be written.

Tests now added. Ready for another big review. 😅

Pushed a rebase to trigger tests again - last run failed due to an unstable test in another component.
@balloob, how do you feel about this now? Personally, I think it's in pretty good shape and much better than the original request thanks to people's feedback. @MartinHjelmare makes a good point about handling updates for newly added sensors, but I hope my response makes sense and that others agree with that.

Hi, Is there a particular reason the motion sensor binary_sensors have device_class "presence" rather than "motion"?
Cheers,
James

This is fixed in another PR, #23193.
On Thu, 18 Apr 2019, 18:24 James<EMAIL_ADDRESS>wrote:

Hi, Is there a particular reason the motion sensor binary_sensors have
device_class "presence" rather than "motion"?
Cheers,
James
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/22598#issuecomment-484600684,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABD47XT5UMOJVZ2XI4MPM3PRCVFDANCNFSM4HCSAHIA
.

#23208 for actual naming

I was looking through the code to see how it compared to my personal hacks to get the Hue sensors work and noticed 2 small issues.
According to https://www.home-assistant.io/components/sensor/ the light unit should be lx (for lux) or lm (for lumen), however current implementation seems to use 'Lux'
Light level in the Hue API is not in lux it is in another unit.
Quote from the Hue developer documentation:

Light level in 10000 log10 (lux) +1 measured by sensor. Logarithm scale used because the human eye adjusts to light levels and small changes at low lux levels are more noticeable than at high lux levels.

So in my custom code I had the following to convert to lux. It seemed right, but I had some issues getting it working.
return round(10 ** ((int(self.sensor.state['lightlevel'])-1)/10000.0))

Excellent info, thanks @mvdwetering! I'll get this updated right away.

@mvdwetering #23309

not really being sure, so please forgive me if this is an unnecessary question, but it would really be very nice if we got these values with the native sensors, since they are all part of templates being used throughtout the setup:

about the lux setting: in the current custom component, lx is calculated from light level as follows:
            lx = round(float(10 ** ((lightlevel - 1) / 10000)), 2)

Some of these additional attributes are exposed as attributes on the sensor
entities, for example battery level. For the initial implementation I opted
not to include some of them, but that doesn't mean they cannot be included
in the future.
On Mon, 22 Apr 2019, 21:20 Marius<EMAIL_ADDRESS>wrote:

not really being sure, so please forgive me if this is an unnecessary
question, but it would really be very nice if we got these values with the
native sensors, since they are all part of templates being used throughtout
the setup:
[image: Schermafbeelding 2019-04-22 om 22 15 30]
https://user-images.githubusercontent.com/33354141/56526322-7072c380-654c-11e9-8f8c-3e4e67b9491b.jpg
about the lux setting: in the current custom component, lx is calculated
from light level as follows:
        lx = round(float(10 ** ((lightlevel - 1) / 10000)), 2)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/22598#issuecomment-485538629,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABD47TWSVJBNP4WICHVPY3PRYM2DANCNFSM4HCSAHIA
.

ok thanks, please do. Some of them are simply there for the taking. adding them is a matter of adding a line (at least it was like that in the CC...)
Hope you can add them like that too?
def parse_sml(response):
    """Parse the json for a SML Hue motion sensor and return the data."""
    if response["type"] == "ZLLLightLevel":
        lightlevel = response["state"].get("lightlevel")
        tholddark = response["config"].get("tholddark")
        if lightlevel is not None:
            lx = round(float(10 ** ((lightlevel - 1) / 10000)), 2)
            dark = response["state"]["dark"]
            daylight = response["state"]["daylight"]
            data = {
                "light_level": lightlevel,
                "lx": lx,
                "dark": dark,
                "daylight": daylight,
                "threshold": tholddark,

Please open an issue if you suspect a bug.
Merged PRs should not be used for enhancement discussion or bug reports. If you've found a bug it's ok to make a review with inline comments and link to an issue that reports the bug.
Thanks!


Rule E703, W293 fails to fix file

Ruff https://github.com/charliermarsh/ruff/commit/f5be3d8e5b2e3f3a0c5890075b552371f4061023
Command - ruff --fix with config with all rules enabled
File
if True:
    x = 1; \

shows error
error: Autofix introduced a syntax error. Reverting all changes.

This indicates a bug in `ruff`. If you could open an issue at:

    https://github.com/charliermarsh/ruff/issues/new?title=%5BAutofix%20error%5D

...quoting the contents of `Desktop/RunEveryCommand/ruff/Broken/PY_FILE_TEST_11381303964.py`, the rule codes E703, W293, along with the `pyproject.toml` settings and executed command, we'd be very appreciative!

Desktop/RunEveryCommand/ruff/Broken/PY_FILE_TEST_11381303964.py:1:1: D100 Missing docstring in public module
Desktop/RunEveryCommand/ruff/Broken/PY_FILE_TEST_11381303964.py:1:1: INP001 File `Desktop/RunEveryCommand/ruff/Broken/PY_FILE_TEST_11381303964.py` is part of an implicit namespace package. Add an `__init__.py`.
Desktop/RunEveryCommand/ruff/Broken/PY_FILE_TEST_11381303964.py:2:10: E703 Statement ends with an unnecessary semicolon
Desktop/RunEveryCommand/ruff/Broken/PY_FILE_TEST_11381303964.py:3:1: W293 Blank line contains whitespace
Desktop/RunEveryCommand/ruff/Broken/PY_FILE_TEST_11381303964.py:3:4: W292 No newline at end of file

EDIT - file - aa.py.zip

Feel free to assign this to me, I can take a look!

Hmm, I can't seem to replicate this. I copied the Markdown file from the description and ran ruff test.py --fix, which seemed to successfully fix the problem. Are there any other examples of this that you've come across?

Me neither -- gonna close for now...

I added reproduction file in comment.
Looks that pasting code to github changes some bytes, so proably I should always provide example file
Real content
0000000 6669 5420 7572 3a65 200a 2020 7820 3d20
0000010 3120 203b 0a5c 2020 0020
0000019

After copying from github
0000000 6669 5420 7572 3a65 200a 2020 7820 3d20
0000010 3120 203b 0a5c 2020 0a20
000001a

Hmm. Even with the new file, it seems to work properly...
ruff/crates/ruff on  4404_fix_e703_w293 [ ?1 *2 ] via Python v3.11.3 via 🦀 v1.69.0
❯ ruff ~/Downloads/aa.py --fix
Found 1 error (1 fixed, 0 remaining).

ruff aa.py --fix --select ALL

have still problem(W293 is not enabled by default)
strange that
ruff aa.py --fix --select E703,W293

not have any problems

Sorry for the delay - work has been insane and have had to step back from the project for a bit. Just now getting to this.
I think I've isolated the problem.  Ignoring `one-blank-line-before-class`.
warning: `multi-line-summary-first-line` (D212) and `multi-line-summary-second-line` (D213) are incompatible. Ignoring `multi-line-summary-second-line`.
error: Autofix introduced a syntax error in `aa.py` with rule codes E703, W293: unexpected EOF while parsing at byte offset 21
---
if True:
    x = 1 \

---
aa.py:1:1: D100 Missing docstring in public module
aa.py:2:10: E703 Statement ends with an unnecessary semicolon
aa.py:3:1: W293 Blank line contains whitespace
aa.py:3:4: W292 No newline at end of file
Found 4 errors.

I tested permutations of the various errors; it looks like the problem isn't with E703 at all, but rather with D100. Some logs:
ruff on  4404_fix_e703_w293 via Python v3.11.3 via 🦀 v1.70.0
❯ cargo run -p ruff_cli ./aa.py --fix --select E703,D100 --no-cache
    Finished dev [unoptimized + debuginfo] target(s) in 0.10s
     Running `target/debug/ruff ./aa.py --fix --select E703,D100 --no-cache`
aa.py:1:1: D100 Missing docstring in public module
Found 2 errors (1 fixed, 1 remaining).

ruff on  4404_fix_e703_w293 [ !1 ] via Python v3.11.3 via 🦀 v1.70.0
❮ cargo run -p ruff_cli ./aa.py --fix --select W292,D100 --no-cache
    Finished dev [unoptimized + debuginfo] target(s) in 0.10s
     Running `target/debug/ruff ./aa.py --fix --select W292,D100 --no-cache`
aa.py:1:1: D100 Missing docstring in public module
Found 2 errors (1 fixed, 1 remaining).

ruff on  4404_fix_e703_w293 via Python v3.11.3 via 🦀 v1.70.0
❮ cargo run -p ruff_cli ./aa.py --fix --select W293,D100 --no-cache
    Finished dev [unoptimized + debuginfo] target(s) in 0.10s
     Running `target/debug/ruff ./aa.py --fix --select W293,D100 --no-cache`
error: Autofix introduced a syntax error in `aa.py` with rule codes W293: unexpected EOF while parsing at byte offset 22
---
if True:
    x = 1; \

---
aa.py:1:1: D100 Missing docstring in public module
aa.py:3:1: W293 Blank line contains whitespace
Found 2 errors.

So I think what's happening is that the interaction between W293 and D100 is actually the root cause. I'll work on a follow-up for now. Not at all sure why that's happening though since

Relatedly, @charliermarsh I wonder if we should look into our error reporting to see why the correct pair wasn't outputted. From what I can tell, in this case we only output what rules we've already fixed

Looks like the actual content of the file ends up being:
'if True:\n'
'    x = 1; \\\n'
'   '

I was able to replicate the issue by attempting to run (in a separate file):
if True:
    x = 1; \

Note the missing newline after the \.
I think that's the root cause of the issue here - stripping the blank line strips all whitespace, leaving the last \ which throws the syntax error. It looks like this ends up throwing when W293 is paired with another LintSource::Ast rule. It throws with D212, D205, SIM103, T100, A001, TID251 (all AST-based, picked from random linters) but not with TD002, T001 (both token-based).
Just posting my updates here for future reference - sorry if that's bad form or if that's supposed to go in the PR or something. Regardless, I'll take a look at why the AST rules fail with W293 tomorrow.

This is very likely related/duplicated by #4828.

@charliermarsh Would actually like your thoughts on this, since it may require some deeper fixes.
I've been hacking around to see what's going on. Basically, we take the initial file (note that the last line is 3 spaces):
if True:
    x = 1; \

We then, according to the fix of W293, strip out the last line since it's all whitespace. This then leads to a SyntaxError due to the file ending with x = 1; \ (essentially trying to continue the line with nothing to continue).
I was originally looking at including ; and \ in the existing code's whitespace detection as "effective whitespace". Basically, if a \ terminates the line and the next non-whitespace character is a ;, we know that we're attempting to split lines on an empty statement.
I then realized that the issue is due to the way that we perform autofixes. We fix a line, then loop over the new AST and attempt to re-parse it. This second parse introduces the error due to the RCA above. The issue here is that the fix actually spans fixing the two lines simultaneously (e.g., removing ; \\n<space><space><space> all in one go - removing the three spaces first won't work, as outlined above.
I'd like your input on how to fix this. It seems like we have two options:

Decouple the rule from the concept of Line - seems hacky since it's just this edge case. This would make the rule's implementation unique against other rules, which doesn't seem good.
Move it to a different linter (maybe LintSource::Token?) since those rules don't seem to throw. I'm not sure if we'd like to do that or even if it would work, just an initial solution I thought about.

If you have a cleaner solution in mind, or can offer any advice, that'd be much appreciated. Thanks!


Release Google.Cloud.CloudQuotas.V1 version 1.0.0

Changes in this release:
No API surface changes; just dependency updates and promotion to GA.

Created release for Google.Cloud.CloudQuotas.V1-1.0.0

This was released: https://www.nuget.org/packages/Google.Cloud.CloudQuotas.V1


Release notes for TypeScript 1.1?

Are there release notes for 1.1 somewhere that show what changed? I read on the roadmap and official blog post that it's a drop-in replacement and is faster, but is there more details than that?
Thanks,
Sam

We have been keeping detailed release notes since then. Closing.


fix bug in AzureML Endpoint

Description:
fix bug in azureml_endpoint.py
Issue:
when using the AzureMLOnlineEndpoint class without passing the content_formatter parameter, an AttributeError will occur. similarly, with classAzureMLChatOnlineEndpoint.
Details:

update ContentFormatterBase to inherit from BaseModel for Pydantic validation support.
add validators to AzureMLOnlineEndpoint and AzureMLChatOnlineEndpoint with informative error messages for enhanced usability.

Dependencies:
no dependencies required

@prakharg-msft , please review this once again, thanks a lot!

hi @prakharg-msft , thank you for your feedback on my PR. if you're busy and unavailable for a follow-up review, would it be possible for @matthewdeguzman  or @baskaryan  to take a look? your input has been invaluable, and I appreciate any help. thanks!

out of curiosity, if we just typed the content_formatter in L228 as ContentFormatterBase, would that not solve it? can't instantiate an abstract class and pydantic would validate the type

pydantic can check the data type, but it doesn't automatically verify whether a custom class actually implements the abstract methods of its base class.

@prakharg-msft @matthewdeguzman @baskaryan
Thanks for the input, everyone! I'm going to put this PR on hold for a bit as a draft, make the changes, and then we can continue with the review process.

hey @matthewdeguzman @prakharg-msft , I've made the changes based on the suggested earlier. could you please give it another review? thanks for your time!

hi @matthewdeguzman @prakharg-msft @baskaryan , I've made the changes based on the suggested earlier. could you please give it another review? thanks for your time!

hello @hwchase17 , it's been a while since I submitted this PR. Would you mind taking a look when you have a moment? thanks for your time!

@baskaryan FYI

@baskaryan Could you, please, review it?

@baskaryan  It's been a while, I need your review on this ASAP.  Thank you very much.

Apologies for the slow review! Pr has a number of merge conflicts, happy to re-review if you'd like to resolve

@baskaryan @prakharg-msft @leo-gan @matthewdeguzman
Hey everyone, just wanted to say I'm bummed my PR got delayed for so long and that the issue it tackled got fixed in the latest project version. Still keen to contribute though, so let's keep the collaboration going!

@baskaryan @prakharg-msft @leo-gan @matthewdeguzman Hey everyone, just wanted to say I'm bummed my PR got delayed for so long and that the issue it tackled got fixed in the latest project version. Still keen to contribute though, so let's keep the collaboration going!

@hwchase17 FYI


Faq

CI's broken. Blame @JoeyZwicker

Travis doesn't have support for FAQs...

Pretty sure that's it. Travis saw we added FAQ.md and was like "omg guys, I can't handle frequently asked questions, I can hardly handle infrequently asked questions."
@sjezewski do you think it's worth reaching out to the travis guys to see if they can make it more tolerant?

Totes.
Got 'em on the phone right now and I'm reading our FAQ to them line by line to see what's causing the error.
They're based in Germany so this is a long distance call (3$/minute). Don't worry, I'll expense it.


Keep eslintbot in all_authors.json

We have added eslintbot into all_authors.json because it will be the default author for release blog posts.
But our data update script overwrites all_authors.json with the list of authors from existing blog posts, so it will always remove eslintbot. This just happened in https://github.com/eslint/new.eslint.org/commit/db3b33b1f32db74219118b95359926f4f2ec856a

This is happening in fetch-team-data.js. We should just merge data into the file instead of overwriting.

I would like give a try. Can I pick this?

@amareshsm sure, feel free.


[KYUUBI #5756] Introduce specified initialized SQL  to every engine

:mag: Description
Issue References 🔗

This pull request fixes #5756
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklists
📝 Author Self Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

[ ] Pull request title is okay.
[ ] No license issues.
[ ] Milestone correctly set?
[ ] Test coverage is ok
[ ] Assignees are selected.
[ ] Minimum number of approvals
[ ] No changes are requested

Be nice. Be informative.

cc @YesOrNo828

@hadoopkandy Thanks, I left some minor comments, please take a look.

Thanks, I committed it again


#2480

https://github.com/bitshares/bitshares-ui/issues/2480

@sschiessl-bcp
So far, I have been unable to reproduce this issue, tried on different builds, mainnet and tesnet.

Are you running a dev setup? What is your console output when the asset select is visible? Got a screen?

@sschiessl-bcp
I have tried on dev and prod versions. The console is clear http://joxi.ru/Rmz1ERgS08Q54r

Ok thank you!


[iOS, Google Maps] Issues with  panning with controlled region

When trying to work around the issues with initialRegion outlined in #1613, I tried using the MapView region prop.
I've noticed that panning doesn't work. Sometimes the map ends up of moving but it's unpredictable and choppy. Is anyone else seeing these issue?
Removing either provider={PROVIDER_GOOGLE} or region={this.state.region} fixes the panning issue.

I'm seeing the map reset it's position after I zoom/pan/tilt, not sure if that's the same thing you're reporting here?

I can't pan, zoom, or interact with any regularity. Occasionally I am able to pan but it's only after randomly clicking and dragging all over the map. When using MapKit, there are different issues. It appears like the region is reset when the map is ready. I haven't tried Android yet.
There appear to be several major regressions in the latest version (I've upgraded from 0.13.0).

I've seen this issue for quite some time. It's very annoying. The best thing I've seen to help what you are describing is to patch the MapView.js file in the _onMapReady function. Add this to the beginning of that function:
if ( this.state.isReady ) return;

Thanks for the tip. I've actually patched onMapReady to fix the original issue I had with initialRegion.
Unfortunatley I don't have the time now to try to fix these issues but I wonder if there's a way for the community to fund the work to resolve these critical issues. My projects have had issues with MapView's props and callbacks and their behaviour across each platform and maps provider.

Can confirm this fix worked on my fork


Implement CRUD functionality to store contact data using the browser's IndexedDB database

Acceptance criteria:
It is done when the application can read and output data stored in the IndexedDB database.
It is done when the application can write, or POST, to the IndexedDB database.
It is done when the application can create and store data in the IndexedDB database.


Removal/1.5 lightning module datamodule property

What does this PR do?
Removal of datamodule property from LightningModule as scheduled for 1.5
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

maybe @Tshimanga wants to make a PR to flash as well smiley

@awaelchli @ethanwharris  yeah I can take care of that. Probably won't be able to get around to it till Tues (9/7)


a few corrections from summer class

Hi Richard, thanks for this book! I and my students caught a few mistakes. (I'm somewhat new to github, so forgive if I didn't do everything quite right. One of two of the changes were just from me trying to get the files to compile, so you will probably want to ignore those.)

Thanks! I've added your changes (except the typeface stuff) in commit 3ac2ac792de6fb4441626c5a494adaa7eb702eb6


Spectabis crashes when I try to Add Game Path

Spectabis crashes when I try to Add Game Path on my Garuda Linux system with the latest release as of now. I tried building the package using .Net 6.0 and using the official releases but both crashed upon clicking the Add Directory Button.

Hey, thanks for the issue!
Could you please provide log output? https://github.com/valters-tomsons/spectabis-next/blob/master/docs/sharing-logs.md

This is the output when running a Spectabis-next built from source code on my machine using Dotnet 6.0 SDK:
 otega@CHIBUDOM in repo: spectabis-next/src/SpectabisNext/bin/Debug/net6.0 on  master
 λ ./SpectabisNext
[ConfigurationManager.cs] Getting default config for 'SpectabisLib.Configuration.UIConfig'
[ConfigurationManager.cs] Loading '/home/otega/.config/spectabis//spectabis.json
[ConfigurationManager.cs] Loading '/home/otega/.config/spectabis//directory.json
[ConfigurationManager.cs] Getting default config for 'SpectabisLib.Configuration.TextConfig'
[PagePreloader.cs] PagePreloader: 774306
[PagePreloader.cs] Preloading page: SpectabisUI.Pages.GameLibrary
[ServiceLib] Creating client to service at 'http://localhost:7071/api/'
[DiscordService.cs] Creating DiscordRPC client
[DiscordService.cs] Updating status to: 'Library'
[PageFactory.cs] Creating new SpectabisUI.Pages.GameLibrary
[PagePreloader.cs] Preloading page: SpectabisUI.Pages.Settings
[PageFactory.cs] Creating new SpectabisUI.Pages.Settings
[PagePreloader.cs] Preloading page: SpectabisUI.Pages.CreateProfile
[LocalDatabaseProvider.cs] Building game database
[LocalDatabaseProvider.cs] GameDatabaseProvider: Reading PCSX2 game database from 'Resources/gamedatabase.csv'
[LocalDatabaseProvider.cs] Building game index
[PageFactory.cs] Creating new SpectabisUI.Pages.CreateProfile
[PageNavigator.cs] Generating navigation icon for SpectabisUI.Pages.GameLibrary
[PageNavigator.cs] Generating navigation icon for SpectabisUI.Pages.Settings
[PageNavigator.cs] Generating navigation icon for SpectabisUI.Pages.CreateProfile
[Program.cs] Starting Spectabis 'develop'
Unhandled exception. System.InvalidOperationException: Cannot show window with non-visible parent.
   at Avalonia.Controls.Window.ShowDialog[TResult](Window owner) in /_/src/Avalonia.Controls/Window.cs:line 750
   at Avalonia.Dialogs.ManagedFileDialogExtensions.ManagedSystemDialogImpl`1.Show(SystemDialog d, Window parent, ManagedFileDialogOptions options) in /_/src/Avalonia.Dialogs/ManagedFileDialogExtensions.cs:line 36
   at Avalonia.Dialogs.ManagedFileDialogExtensions.ManagedSystemDialogImpl`1.ShowFolderDialogAsync(OpenFolderDialog dialog, Window parent) in /_/src/Avalonia.Dialogs/ManagedFileDialogExtensions.cs:line 47
   at SpectabisNext.Services.FileBrowser.BeginGetDirectoryPath(String title, String path) in /home/otega/spectabis-next/src/SpectabisNext/Services/FileBrowser.cs:line 28
   at SpectabisUI.Pages.Settings.AddScanClick(Object sender, RoutedEventArgs e) in /home/otega/spectabis-next/src/SpectabisUI/Pages/Settings.xaml.cs:line 70
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__127_0(Object state)
   at Avalonia.Threading.AvaloniaSynchronizationContext.<>c__DisplayClass5_0.<Post>b__0() in /_/src/Avalonia.Base/Threading/AvaloniaSynchronizationContext.cs:line 33
   at Avalonia.Threading.JobRunner.RunJobs(Nullable`1 priority) in /_/src/Avalonia.Base/Threading/JobRunner.cs:line 37
   at Avalonia.X11.X11PlatformThreading.HandleX11(CancellationToken cancellationToken) in /_/src/Avalonia.X11/X11PlatformThreading.cs:line 169
   at Avalonia.X11.X11PlatformThreading.RunLoop(CancellationToken cancellationToken) in /_/src/Avalonia.X11/X11PlatformThreading.cs:line 245
   at Avalonia.Threading.Dispatcher.MainLoop(CancellationToken cancellationToken) in /_/src/Avalonia.Base/Threading/Dispatcher.cs:line 61
   at Avalonia.Controls.DesktopApplicationExtensions.Run(Application app, CancellationToken token) in /_/src/Avalonia.Controls/DesktopApplicationExtensions.cs:line 57
   at Avalonia.Controls.DesktopApplicationExtensions.Run(Application app, Window mainWindow) in /_/src/Avalonia.Controls/DesktopApplicationExtensions.cs:line 46
   at SpectabisNext.Spectabis.Start() in /home/otega/spectabis-next/src/SpectabisNext/Spectabis.cs:line 21
   at SpectabisNext.Program.StartSpectabis(IContainer container, String[] arguments) in /home/otega/spectabis-next/src/SpectabisNext/Program.cs:line 38
   at SpectabisNext.Program.Main(String[] args) in /home/otega/spectabis-next/src/SpectabisNext/Program.cs:line 15
   at SpectabisNext.Program.<Main>(String[] args)
fish: Job 1, './SpectabisNext' terminated by signal SIGABRT (Abort)

Is it a problem with Avalonia?

Can reproduce after updating Avalonia, so I must've broken this at some point. Will investigate. :+1:

Fixed with https://github.com/valters-tomsons/spectabis-next/commit/ae217dfff350a6b3ad7e9a9e6ed4746e39588909, but don't bother. Game scanning itself is not implemented yet


Add documentation for Combobox

🙋 Documentation Request
Add react-spectrum/aria/stately docs for combobox
🧢 Your Company/Team

This would be awesome, waiting for this feature!


Stone Paper Scissor Game

I want to add a Stone Paper Scissor game to this website
You can assign me this task with gssoc-extd and hacktoberfest labels

Sorry, someone is already working on this. Do not be demotivated and raise a new issue.


MRG, DOC: Fix class docstring errors

Let's see the error in CIs, then fix. Locally I see 636 errors (!).

Should be ready for review/merge now


Config server session cleanup [run-systemtest]

@hmusum  Is this still ongoing, or should it be closed ?

Closing


Number of motifs (N) for distribution learning

Hi, thanks for the great work!
I've read from the paper that N=300 was used for property optimization and N=500 for constrained property optimization.
However, I could not find the same information for the distribution learning benchmark (Table 1).
I've also taken a look at the repository, but it was unclear for me which values of N were used.
Would you mind sharing the values of N for the distribution learning benchmark on QM9 and ZINC250K, respectively?
Thanks in advance!

Hi, for distribution learning benchmark on QM9 and ZINC250K, we set N=101 and N=500, respectively. The checkpoints and vocabularies are also available on Google Drive.

Thanks for the answer!


Incorrect examples about IncludeScopes in appsettings.json

Dear maintainers,
I had some problems with getting Asp.Net Core 2.1 to include scopes when logging. I added "IncludeScopes: true, just as some examples here https://docs.microsoft.com/en-us/aspnet/core/fundamentals/logging/?view=aspnetcore-2.1&tabs=aspnetcore2x.
But I found out via https://github.com/aspnet/Logging/issues/835 that this line should be added in the "Console" scope of appsettings.json.
Thanks in advance.
Regards,
NiekGr

Yes, @NiekGr ... that's correct. We just haven't reached this topic and sample yet with the 2.1 updates.
https://github.com/aspnet/Docs/issues/5495
We'll get to it asap. Thanks for commenting.

Let's go ahead and patch it for now. A quick update to the appsettings files should be enough.


[BUG]CMS component - sidebar blocks are on the wrong side to each other

Describe the bug
If you choose a page layout containing a sidebar the block putted in left column sometimes is shown on the right side on the website
How to reproduce
Initial conditions: the category 'Movies & Toys' is active
Steps to reproduce the behavior:

Go to 'Shopping experiences' from Shopware
Choose layout called 'Test Shop page'
Scroll down and click 'add-section' button
Click 'Sidebar'
Click 'Settings' icon
Add any block to the left section and any different block to the right section
Click 'Save' button in the upper right corner
Click 'Navigator' button on the right side
Go to Layout section - Sidebar
Click 'delete' button next to each block you just added
Click 'Save' button in the upper right corner
Add again any block to the left section and any different block to the right section
Click 'Save' button in the upper right corner
Got to the website and See the error
If the components are on the right place repeat steps 10-13 until you see the error

Expected behavior
Block putted in left column is always shown on the left side on the website and block putted in the right column is always shown on the right side. The sidebar blocks are on the correct side.
Actual behavior
Sometimes sidebar blocks are putted on the wrong side to each other on the website.
Screenshots
Sidebar blocks in Shopware 'Shopping Experiences' layout:

The same sidebar blocks on the website:

Devices (please complete the following information):
All devices

@Michal-Dziedzinski please check it

It is already working correctly.


Use venv to run tests in github workflow

Here's my attempt at fixing the pip failure.

If we're going to use a venv we should use the one natively from github actions instead of hard coding it ourselves:
I got it working here:
https://github.com/ros-infrastructure/rosdoc2/pull/96/commits/e4ab62a55b5d04444e3303d6173a321b972cb3b1 in my tirals in #96
However I was really hoping to keep using the system version as that's what the users will experience unless we change the instructions to explicitly use a venv.

OK we're not going to do it this way, so I will close this.


BrowserSync split doesn't work

At the moment I am using a browserSync configuration that's directly written in the main gulpfile.js

:+1:


Docker Desktop exe not displayed

I Installed Docker Desktop for Windows.
However the starter shortcut does not get indexed. It's located at C:\ProgramData\Microsoft\Windows\Start Menu
It seems like only C:\ProgramData\Microsoft\Windows\Start Menu\Programs is indexed. Maybe the indexing should be changed to also include the parent?

Yeah I ran into that in the past as well, maybe we should index that level instead, although I don't quite get why there is 'Start Menu' and then there is 'Start Menu\Programs', what's the difference?
Until the fix, you should be able to move it to Programs or add that location in and unchecked start menu.

Just going to close this as this repo is no longer maintained, feel free to open the issue in Flow if this is still a problem


No module named 'apps'

Hi, I have used fixtures that come with the sandbox in my project.
When I attempt to add an Item to cart I get this exception
django.core.exceptions.ImproperlyConfigured: Error importing module apps.offers: No module named 'apps'
and this is the exception location
/venv/lib/python3.6/site-packages/oscar/apps/offer/utils.py in load_proxy, line 30
I am using django 2.2.7 and django-oscar 2.0.3

The fixtures that come with the sandbox are meant only for use with the sandbox - they will not work in another project. In this case the error you're getting is because the sandbox has defined a custom benefit, and since this doesn't exist in your project, the fixtures do not load.


Send public key kind and encoding when sending a message

Is your feature request related to a problem? Please describe.
Mailchain v0.0.44 will require that public_key_encoding and public_key_kind are specified when sending a message. This is required for https://github.com/mailchain/mailchain/issues/52
Describe the solution you'd like
From version v0.0.43 additional fields public_key_encoding and public_key_kind are returned when getting a public key. e.g.
{
    "public_key":"0xbdf6fb97c97c126b492186a4d5b28f34f0671a5aacc974da3bde0be93e45a1c50f89ceff72bd04ac9e25a04a1a6cb010aedaf65f91cec8ebe75901c49b63355d",
    "public_key_encoding":"hex/0x-prefix",
    "supported_encryption_types":["aes256cbc","noop"],
    "public_key_kind":"secp256k1"
}

public_key_encoding and public_key_kind  should be added e.g.
{
	"message": {
		"body": "test",
		"headers": {
			"from": "0xd5ab4ce3605cd590db609b6b5c8901fdb2ef7fe6",
			"to": "0x92d8f10248c6a3953cc3692a894655ad05d61efb"
		},
		"public-key": "0xbdf6fb97c97c126b492186a4d5b28f34f0671a5aacc974da3bde0be93e45a1c50f89ceff72bd04ac9e25a04a1a6cb010aedaf65f91cec8ebe75901c49b63355d",
                "public_key_encoding":"hex/0x-prefix", // NEW
                "public_key_kind":"secp256k1", // NEW
		"subject": "test"
	},
	"envelope": "0x01",
	"encryption-method-name": "aes256cbc",
	"content-type": "text/plain; charset=\"UTF-8\""
}

@robdefeo
I'd prefer not to use underscores (snake_case) for consistency. Better with hyphens?
{
	"message": {
		"body": "test",
		"headers": {
			"from": "0xd5ab4ce3605cd590db609b6b5c8901fdb2ef7fe6",
			"to": "0x92d8f10248c6a3953cc3692a894655ad05d61efb"
		},
		"public-key": "0xbdf6fb97c97c126b492186a4d5b28f34f0671a5aacc974da3bde0be93e45a1c50f89ceff72bd04ac9e25a04a1a6cb010aedaf65f91cec8ebe75901c49b63355d",
                "public-key-encoding":"hex/0x-prefix", // NEW
                "public-key-kind":"secp256k1", // NEW
		"subject": "test"
	},
	"envelope": "0x01",
	"encryption-method-name": "aes256cbc",
	"content-type": "text/plain; charset=\"UTF-8\""
}

Good spot  👀 @tboeckmann you are absolutely correct, I will get that amended. Thanks.


GH-487: Support payload conversion for batches

Resolves https://github.com/spring-projects/spring-kafka/issues/487
Support adding, for example, the StringJsonMessageConverter to the
batch converter to perform conversion of individual batch members.

Merged as https://github.com/spring-projects/spring-kafka/commit/1b0c315fa80079518a625c9775857d66bce4155b and cherry-picked to 2.0.x.
Back-ported to 1.3.x as https://github.com/spring-projects/spring-kafka/commit/00c8ee8180e1e5da54c4cd8a50472fd9adf251d9 after resolving conflicts.


Key names wrong after migrate to 1.0

After migrating yesterday something in the keymanagement is broken:
in the gitolite config the keys ar named with redmine_[username] the old<EMAIL_ADDRESS>keys partly sill exists, but new keys get added as redmine_[username][userid ]/redmine[keyname]/redmine_[username]_[userid].pub so there is an additional userid witch should be in the gitolite config file

after some manual repository renaming, and delete/create of repository the re-sync all projects/keys suddenly did it's work and renamed the key name entrys in the conf


pls create google form!!!! I have 1 acc

how did you define me as a sybil? i bought only one share and sat all the time in it, performed rallies only in it! please if you want to keep active users on your platform, review all members again!

Sir I invest in account creation 25 dollar but your team banned my account I mentioned my account full datial in screen shot my Twitter handle @jhoshsono99851 please sir solve my issue and give me my earnd gem's


Add support for Fedora 37

This issue is created to track progress for the work to enable Fedora 37 support for .NET Core 3.1 and .NET 6.0
Product and Test updates

[ ] [All teams] Do a compatibility check for the product with the new OS
[ ] [CoreCLR/CoreFX] Runtime / RID Support update
[ ]  [Infra] Ensure that the correct Docker images used by teams are built in the dotnet-buildtools-prereqs (if applicable)
[ ] [Infra] Replace docker tags used in builds across repos and branches
[ ]  [CLI team] Update CI legs to latest updated Dockerfile
[ ]  [All teams] Update test infrastructure to support the new version
[ ] [Acquisition] Add support within nightly repos
[ ] [Acquisition] Deploy to master (GA) during next patch release cycle

Release team:

[ ]  Notify .NET Core teams regarding new OS release
[ ]  Follow up with infra and add feed for new OS release to packages.microsoft.com
[ ]  Update release manifest files
[ ] Create new Docker files to test the new OS
[ ] Update the supported OS content on GitHub and marketing sites.

Document updates:

[ ] Add OS prerequisites to the dependencies document
[ ] Update distro install page

Fedora 37 was released earlier this week: https://fedoramagazine.org/announcing-fedora-37/

Are there any updates on this? Fedora is a widely used distro. It would be great to have official support

As a workaround, the following gets you going on Fedora 37
sudo ./dotnet-install.sh --channel 7.0 --install-dir /usr/lib64/dotnet
``

As a workaround, the following gets you going on Fedora 37
sudo ./dotnet-install.sh --channel 7.0 --install-dir /usr/lib64/dotnet

Thank you @danielmarbach. If anyone else is like me, I like a "fire and forget" installation, where it keeps being updated with the rest of packages in the system. Does this script do that? Or is it a binary installation that we need to remember to update and/or replace with proper dnf installation when that is available?
Thanks

@AlirezaHaghshenas it is unfortunately a binary installation that requires updates. The good thing though is that it pulls latest 7 binaries and since versions can live side by side you kind of get latest everytime you execute it. So as long as it is not available on dnf having this executed periodically might keep you reasonably up to date

Are there any updates on this? Fedora is a widely used distro. It would be great to have official support

Fedora 37 itself is "supported" in the sense that .NET packages are available for it. Speaking as one of the Fedora .NET maintainers, we spend quite a bit of time making sure .NET works well on it (in collaboration with the upstream .NET maintainers here on GitHub).
If you are asking about .NET 7 in particular, we are trying to add it to Fedora (36 and later). It's stuck in Package Review blocked on a number of currently unresolved licensing questions. I don't think there are any technical issues here, though. Just some licensing/legal issues that need to be sorted out. And it's all blocked on Fedora's side :(

Thank you @omajid I found that thread. I wish there was a way for us to help accelerate that.

By the way, given how awesome VsCode is in working with a container, I was able to just run the .net 7 SDK image with a folder mapped to my project, and boom!! I have build, debug, intellisense.
docker run -it -v /path-to-my-project:/project mcr.microsoft.com/dotnet/sdk:7.0

Is this issue still current @rbhanda?

Fedora 37 reached EOL on 2023-12-05

Fedora Linux 37 reached end-of-life (EOL) on December 5, 2023. Resolving.


suggestion: add .stylua.toml and end_of_buffer disabled change for transparent background

Did you read the docs?

[X] I have read the docs.

What would you like to change?
Firstly, thank you for the plugin; I have been really enjoying it. My first suggestion is to add a .stylua.toml to the repo and the second is to change the setting for end_of_buffer being disabled as
-- Set the End-of-Buffer (EOB) character to an empty space for a cleaner appearance
vim.opt.fillchars:append({ eob = ' ' })

Why do you think this will improve lackluster?
When the .stylua.toml file is included in the repository, it ensures that formatting is enforced according to its settings when users fork and make changes, overriding default formatting applied by plugins like conform.nvim.
The second suggestion ensures that when the end of the buffer is disabled, the end of the buffer character is a space, addressing the issue where users with a transparent background can still see the end of the buffer (screenshots in additional context).
Additional context
Default configuration for end of buffer with transparent background:

With changes suggested above:

I have tried setting the fg for the EndOfBuffer highlight to none but results in EndOfBuffer character having a white fg

These are great suggestions! I think they should both be added to lackluster :)
Currently I'm moving house, and it will take me anywhere from a few days to a week or so to get to this. Are you interested in contributing a PR?
:) glad your enjoying lackluster!

Feel free to open a pr if that's something your interested in working on :)

I've opened PR #53 for adding the .stylua.toml and formatting Lua files. Should I create a separate PR for the transparent background refactor?

Finnally settled in at my new place and back on the computer :), I'm on working on getting  #50 fixed up and merged right now and will get to this next, should be this afternood or tomorrow morning :)
Sorry its taken me so long to get to this!


RTL Support!

Realy like this plugin,
Please add rtl support for the calendar or
give the the css classes I need to add the rtl support for.
thanks.

Can you give an example, how do you think calendario should look like when rtl is being used.


Memory ballooning in certain transformers

Some Transformers that call the Dataset method columnsByType() suffer from a memory ballooning issue when dealing with large datasets. The issue is caused by the fact that the columnsByType() method returns a copy of the data in the dataset. The issue can be resolved by determining the column datatype inside the main loop, thereby keeping only one column in memory at a time.
The Transformers effected are Z Scale Standardizer, Robust Standardizer, One Hot Encoder, Interval Discretizer, and Variance Threshold Filter.

Fixed in commit https://github.com/RubixML/RubixML/commit/af58ed35ef53c7e7b92ec4f972cef38f9be3d020


I propose removing the following labels from hackclub/hackclub

hackclub/hackclub
I propose removing the following labels from the hackclub repository:

enhancement

it is completely unclear what this means and there are definitely lots of issues that have been created and will continue to be that are enhancements that are not labeled as such because it is unclear to the creator that they should label it enhancement.

beginner-friendly

perhaps we should use first-timers-only instead? I think having both of these tags are redundant.

help-wanted

this tag doesn't seem to be used. I'm down for trying to make this work though.

meeting and meta having these labels seem unnecessary because being able to visually identify an issue is meta or meeting doesn't have any benefit

/cc @hackclub/hackclub

I just cleared out the blocking label.

and deleted all labels that didn't have any issues ever attatched

<3

Any thoughts on the original comment?

@jonleung: I'm down for closing those tags

These tags have all been removed.

👍
--
Zach Latta
Hack Club |<EMAIL_ADDRESS>On Jan 11, 2016, 6:21 AM -0800, Max<EMAIL_ADDRESS>wrote:

Closed#367(https://github.com/hackclub/meta/issues/367).
—
Reply to this email directly orview it on GitHub(https://github.com/hackclub/meta/issues/367#event-511146102).

<3


How to use wp-cli with this configuration?

Please add an example showing how to use wp-cli with this configuration. It seems it is setup to run from outside the container like this:
docker-compose run -rm wp-cli plugin install jetpack
However, this is returning the following notification:
Run a one-off command on a service.

Hi,
That's exactly how I would like it to run but the WP CLI is still a work in progress and I haven't been able to put much extra time into this since it was created. I should be able too soon so I'll try to update soon

Ah no worries. Thanks for putting this together. It's the simplest configuration for containerizing WordPress so far. Very helpful in understanding how to use Docker with WP. I'll keep my eye on it and post a fix if I find one.

Closing old question.


Doc: ES6 flag in editor

Seems like you need the top-line comment of /*jshint esnext: true */ to use let & perhaps more ES2015/ES6 commands, though (in FxDev) others like endsWith don't need the flag.
Fine by me, though this flag is not mentioned in the WiKi for the JS editor.

We are planning to switch to ESLint with babel-eslint in the future.

Adding that flag does not automatically add ES2015, it just tells jshint to add the lint features. ES2015 features depend on the browser at the moment.


Cleanup go module and fix linting timeouts

Some cleanup to make repo pass CI. Tested locally but we should see the presubmits run now as well.

@krishchow mind if I go ahead and merge this and let you follow up with the linter fixes?


Add new physics elements for Nvidia PhysX

Desired behavior

I hope SDFormat would support the PhysX(Nvidia) as a physic engine so that I can utilize the standard format for robot simulation.
Since Nvidia PhysX introduced a new articulation body for robotics, and I think it's enough and possible to present the robot s in the world what we imagine.
refer to example here.
TGS is provided for solver in PhysX.
I guess many developers already know these feature in PhysX 4.0 but current SDFormat(even latest version) does not support that type in official. :(
Anyone have the plan to introduce a new physics engine type?
Implementation suggestion

     describe any parameters related to PhysX
Additional context

Actually I'm working on open project which called CLOiSim to simulate the robotics simulation using SDFormat.
I couldn't find reasonable SDFormat parsing library for C#, so I've created the parser by my self.
And it implements the physics things like joint, inertial and whatever.. using the parameters in ODE type.

Adding specific elements for every physics engine hasn't been scaling well. I believe the direction we're planning to take is to use generic elements instead of engine-specific ones, see https://github.com/osrf/sdformat/issues/508.