Decide and document on pod scaling of GKE's clusters calico-typha pods

On GKE clusters, we may very well end up with more core nodes than we need just because calico-typha, a pod that can only be scheduled once per node, is by an associated HorisontalPodAutoscaler run with two or more replicas in k8s clusters with two or more nodes. This was observed in https://github.com/2i2c-org/infrastructure/issues/2199.
This can incurr additional significant additional cloud costs. I expect us to not require more than one replica, and the reason that they provide more when more nodes are available is because they want to make it highly available and allow one node to crash at any time. Its likeley so that if this pod goes down, internal networking may go down. So, its an important pod, like the ingress-nginx pods that also route network traffic. At the same time, if a core node pool goes down, we expect things to break until another is up anyhow right?
I think it makes sense to reconfigure how many replicas should be used, but since its quite critical from both a cost perspective and could break a lot of things if done wrong, I've opened this dedicated issue for discussing it.
My proposal
We look to manually change the calico-typha HPA configuration so that it only creates another pod if more 10 or more nodes are running in the k8s cluster. I think it would be fine to let this number be more than 100 as well, but its feels impossible to say. We may could bottleneck on network traffic capacity as well, and then multiple replicas could help - I don't know.
To avoid risking causing issues by having to few replicas and bottlenecking, I suggest we go for allowing it to scale up to two replicas if there is 10 or more nodes for now. Any cluster having 10 or more nodes is probably a quite expensive cluster anyhow.
Actionable discussion

[ ] Is there agreement on making reconfiguring the HPA, from scaling to two replicas when there are 2 cluster nodes to doing it when there are 10?
Practically, what is described in https://github.com/2i2c-org/infrastructure/issues/2199#issuecomment-1428857110.
[ ] Is there agreement that its acceptable to start out by doing this manually, updating existing clusters, and writing docs for doing it in new clusters?

Action points on agreement

[x] Update all existing GKE cluster's calico-typha HPA config
[ ] Write docs on how to make the change, and reference it from docs on setting up new GKE clusters
[ ] Update the cluster-design.md to be more concrete and link to relevant docs. As of #2488, it vaguely sais:

On GKE clusters with network policy enforcement, we look to edit the
calico-typha-horizontal-autoscaler ConfigMap in kube-system to avoid scaling
up to two replicas unless there are very many nodes in the k8s cluster.

# command used to inspect all clusters's calico-typha-horizontal-autoscaler configmaps value
ls config/clusters | xargs -I {} deployer use-cluster-credentials {} 'echo {} && kubectl get cm -n kube-system -o yaml calico-typha-horizontal-autoscaler | yq eval ".data.ladder" - | yq eval ".nodesToReplicas[1]" -'

There is also the konnectivity-agent pods that are scaled with an autoscaler respecting a configmap just like the one for calico-typha, named konnectivity-agent-autoscaler-config. The policy for these pods are that they can run in multiple replicas on the same node and same zone, but prefers to avoid running more than one replica per hostname / zone. Due to that, the cluster will add another node if there are three replicas.

On cluster creation, Konnectivity agent pods establish and maintain a connection to the control plane on port 8132. When one of the kubectl commands is run (kubectl logs, attach, exec, and port-forward), the API server uses this connection to communicate with the cluster.
It's worth noting that these features are not required for the correct functioning of the cluster. If you prefer to keep your cluster's network locked down from all outside access, be aware that features like these won't work.

I think we should be fine to just have 2 of these pods, and due to that, shouldn't scale to three pods.

Here is a summary of configurations. I'll go and systematically change these right now to [[1, 1], [2, 2], [10, 3], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]] as that should help us reduce cost notably for clusters not using 10 or more nodes by not needing more than one core node pool in many situations.
(base) ➜  infrastructure git:(pr/upgrade-qcl-awi-ciroh) ls config/clusters | xargs -I {} deployer use-cluster-credentials {} 'echo {} && kubectl get cm -n kube-system konnectivity-agent-autoscaler-config -o yaml | yq eval ".data.ladder" - | yq eval ".nodesToReplicas" -'
2i2c, [[1, 1], [2, 2], [10, 3], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]]
2i2c-uk, [[1, 1], [2, 2], [3, 3], [4, 4], [5, 5], [6, 6], [10, 8], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]]
awi-ciroh, [[1, 1], [2, 2], [3, 3], [4, 4], [5, 5], [6, 6], [10, 8], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]]
callysto, [[1, 1], [2, 2], [3, 3], [4, 4], [5, 5], [6, 6], [10, 8], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]]
catalystproject-latam, [[1, 1], [2, 2], [3, 3], [4, 4], [5, 5], [6, 6], [10, 8], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]]
cloudbank, [[1, 1], [2, 2], [3, 3], [4, 4], [5, 5], [6, 6], [10, 8], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]]
hhmi, [[1, 1], [2, 2], [3, 3], [4, 4], [5, 5], [6, 6], [10, 8], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]]
leap, [[1, 1], [2, 2], [10, 3], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]]
linked-earth, [[1, 1], [2, 2], [3, 3], [4, 4], [5, 5], [6, 6], [10, 8], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]]
m2lines, [[1, 1], [2, 2], [3, 3], [4, 4], [5, 5], [6, 6], [10, 8], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]]
meom-ige, [[1, 1], [2, 2], [3, 3], [4, 4], [5, 5], [6, 6], [10, 8], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]]
pangeo-hubs, [[1, 1], [2, 2], [10, 3], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]]
qcl, [[1, 1], [2, 2], [3, 3], [4, 4], [5, 5], [6, 6], [10, 8], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]]

All our GKE hubs are now updated to be configured like [[1, 1], [2, 2], [10, 3], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]] instead of the default [[1, 1], [2, 2], [3, 3], [4, 4], [5, 5], [6, 6], [10, 8], [100, 12], [250, 18], [500, 25], [2000, 50], [5000, 100]].
This makes these clusters not need more than 1 core node as long as the cluster has less than 10 nodes in it due to konnectivity-agent pods.

This is relevant to handle to avoid cloud costs for communities, where the typical outcome is that an additional core node is used even though its not needed.


Fix issue adding back hidden status bar widget

The 2023.2 platform requires statusBarWidgetFactory to have an id attribute in plugin.xml. This must be set to the same value returned by StatusBarWidgetFactory.getId(). If this value is missing, then hiding the status bar widget through the right click menu and then trying to show it again will fail.

Thank you!


swagger-ui does not remove java string escape char "" from @ApiModelProperty example

Using version 2.7.0 of springfox-swagger2 and springfox-swagger-ui with spring-boot 1.5.4.RELEASE
I have defined some example value in @ApiModelProperty like this
@ApiModelProperty(example = "{\"name\": \"foo\", \"age\": 42}")

as part of a model for a body param.
The escape chars \ are kept in swagger-ui's Example Value, so that when clicking on it to paste the Example Value into body param value for testing the REST endpoint, the escape chars \ are still included - thus transmitting invalid JSON to the endpoint.

I think this might be a Swagger-ui issue

@dilipkrish swagger-ui team says, it's a springfox issue:
https://github.com/swagger-api/swagger-ui/issues/3465#issuecomment-318174407
The example string from
@ApiModelProperty(example = "{\"name\": \"foo\", \"age\": 42}")

is indeed passed as is to springfox.documentation.schema.ModelProperty and then to io.swagger.models.properties.Property.
In my case, I am trying to provide an example for a property, which is a Map<String, AnotherObject>.
Maybe there is some other way to achieve this than by  using @ApiModelProperty's example?

@dilipkrish I was looking into springfox code and to workaround my problem I think I could register a custom JSON serializer via MixIn, like it is done in springfox.documentation.swagger2.configuration.Swagger2JacksonModule.
The springfox documentation says I could do that by implementing ApplicationListener<ObjectMapperConfigured>.
I tried that and called
event.getObjectMapper().addMixIn(Property.class, CustomPropertySerializer.class);

on it.
But unfortunately, my CustomPropertySerializer's serialize method is never called ...
Any idea what I might be doing wrong?
I verified, that when I add the CustomPropertySerializer in springfox.documentation.swagger2.configuration.Swagger2JacksonModule itself and then build my own springfox-swagger2 jar, the serialize method gets called and output looks like I want it to be.
However, doing that does not seem to be very flexible if I or someone else wants to change the serializer later on.

I finally ended up with providing my own JacksonModuleRegistrar bean, annotated with @Primary.
The bean is a custom Swagger2JacksonModule, which overrides setupModule method with:
@Override
public void setupModule(SetupContext context) {
    super.setupModule(context);
    context.setMixInAnnotations(Property.class, CustomPropertySerializer.class);
}

I'm not sure if that is the "correct" way to do it (it does not feel quite right), but was the only way to get it working.
BTW, is there a reason why Swagger2JacksonModule's maybeRegisterModule calls
objectMapper.registerModule(new Swagger2JacksonModule());

instead of
objectMapper.registerModule(this);

?
If it had used the latter, I wouldn't have had to copy the method to my custom Swagger2JacksonModule

@heapifyman would be of great help if you could help fixing this issue in the library. Seems like a real issue regardless of what swagger team says. Any chance you might be able to help?

@dilipkrish I can try to help, yes

I am using using springfox-boot-starter:3.0.0 and see the same bug while using ApiParam annotation. Was the bug fixed only for @ ApiModelProperty ?

@heapifyman @dilipkrish any help or direction on the same would be great!

I am using using springfox-boot-starter:3.0.0 and see the same bug while using ApiParam annotation. Was the bug fixed only for @ ApiModelProperty ?

I am facing same issue with version 3.0.0 and @ ApiModelProperty  :(


Add cascading when deleting company

Fixes #133
Background
Persons/events cannot exist without a company and must be tied to a specific company, so it makes sense that they should be edited/deleted when their company gets edited/deleted as well. This PR implements the deletion part of this cascading functionality.
It should be noted that this and cascading editing is implemented by adding two functions to the Entry class: hasCompanyName() and updateCompanyName(). These commands should only be called for Persons and Events; they have no functionality for Companies. Despite adding unnecessary functions to the Company class, this method for implementing it was chosen because it requires the least amount of changes to the existing framework.
An alternative design solution would be to use the Observer pattern and then have a Company store all the Persons and Events with a matching companyName as observers. When the company has its name edited or when the company gets deleted, it can simply notify all its observers. However, this is tremendously difficult to implement as one would need to create Observer classes for the UniqueEntryList as well in order to do cascading deletion. There would also be some added complexity in following typing rules between the two kinds of Observer. Overall, the first design decision is much simpler and easier to implement.
Let's

implement cascading when deleting a company

Codecov Report

Merging #149 (69e5f13) into master (9f6b1eb) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #149      +/-   ##
============================================
- Coverage     42.80%   42.65%   -0.15%
  Complexity      463      463
============================================
  Files           121      121
  Lines          2570     2579       +9
  Branches        363      363
============================================
  Hits           1100     1100
- Misses         1384     1393       +9
  Partials         86       86

Impacted Files
Coverage Δ

src/main/java/seedu/address/model/AddressBook.java
50.00% <0.00%> (-2.00%)
:arrow_down:

...rc/main/java/seedu/address/model/ModelManager.java
49.36% <0.00%> (-0.32%)
:arrow_down:

...c/main/java/seedu/address/model/entry/Company.java
60.46% <0.00%> (-1.44%)
:arrow_down:

src/main/java/seedu/address/model/entry/Entry.java
83.33% <ø> (ø)

src/main/java/seedu/address/model/entry/Event.java
0.00% <0.00%> (ø)

...rc/main/java/seedu/address/model/entry/Person.java
88.63% <0.00%> (-2.07%)
:arrow_down:

...ava/seedu/address/model/entry/UniqueEntryList.java
60.31% <0.00%> (-1.98%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6b1eb...69e5f13. Read the comment docs.


How to implement PocketSphinx 5prealpha in Jasper

I installed PocketSphinx 5prealpha on Rpi 2 B hoping for a better speach recognition. But after starting Jasper I get this error:
shell

        JASPER - THE TALKING COMPUTER           *

(c) 2015 Shubhro Saha, Charlie Marsh & Jan Holthuis *

ERROR:root:Error occured!
Traceback (most recent call last):
File "/home/pi/jasper/jasper.py", line 143, in
app = Jasper()
File "/home/pi/jasper/jasper.py", line 106, in init
stt_passive_engine_class.get_passive_instance(),
File "/home/pi/jasper/client/stt.py", line 48, in get_passive_instance
return cls.get_instance('keyword', phrases)
File "/home/pi/jasper/client/stt.py", line 42, in get_instance
instance = cls(**config)
File "/home/pi/jasper/client/stt.py", line 126, in init
**vocabulary.decoder_kwargs)
TypeError: init() got an unexpected keyword argument 'hmm'

Hi I got the same error with you, and my jasper works good with google stt, but get this error with sphinx. did you figure that out?

Jasper only supports PocketSphinx 0.8, but I think there is a fork working on implementing 5prealpha support.

@aish9r is your branch working with 5prealpha?

@brad999 It works with 5prealpha. I am running @aish9r 's fork on Arch Linux with pocketsphinx 5prealpha-1 and phonetisaurus g014b2b.

Awesome, I will have to give it a try.

Yes, Jasper works with PocketSphinx-5prealpha. I am using it for a while.
check the below link for an installation
https://wolfpaulus.com/journal/embedded/raspberrypi2-sr/

Pocketsphinx 5 prealpha support was added in commit f02a61e6c6b5853bcf232cc0c19879c9edd3fa3c. It currently resided in the experimental jasper-dev branch.

Seems to be resolved.

Thanks, this finally got me on a solid track.
I have documented my journey of required fixes here:
https://github.com/GeoBeBee/mySystem/blob/master/Jasper-dev_onPocketPhinx_5preAlpha.txt


Release 0.0.1

Releases in the 0.0.x sequence are for debugging our automated release process.

Using close/reopen PR to get Travis to recreate the build, including using new things that are part of Autorelease that I need to test here. See https://travis-ci.community/t/restart-build-with-updated-config-imports/7210.

This works, but I'm going to hold off on merging until I get the updates to Autorelease into a release over there (probably tomorrow). That way we can use Travis configs from a release tag, instead of a feature branch.


Migrate bot to Python 3.8

I have upgraded the Python version we use for the bot to Python 3.8. One of the major upgrades this offers for us is that we can now use the utilities for testing asynchronous code instead of having to define our own Async-helper for every asyncio-aspect we'd like to test.
This means that this PR also removes those helpers and introduced the proper equivalents that now ship with Python where needed. Another major change that impacts the run time of the test suite significantly is that the CustomMockMixin now adapts the new "lazy" way of detecting which attributes of objects should be mocked using an AsyncMock.
A list of changes:

Wherever we needed the async_test decorator to be able to run a coroutine test method I've now used the new IsolatedAsyncioTestCase that allows the direct use of async def test methods.

Our custom mock types no longer specifically need an __init__ if they don't define custom behavior; instead, you can use class attributes to set the spec_set it should use and the CustomMockMixin will pick it up. As some discord objects have synchronously defined methods that actually return a coroutine object, there's an additional class attribute that can be set with an iterable of method names that should be mocked with AsyncMocks.

The custom AsyncMock and AsyncIterator classes have been removed as well as the async_test decorator; they've become obsolete

I've made sure that all current tests nicely use the proper unittest utilities.

I've fixed one hidden bug in test_time causing a test method to not actually test something.

I've removed a pytest file that was left behind during the unittest migration

I've upped the coverage of the test suite part of the bot to 100% by adding a few tests and praga: no cover parts that don't require testing.

I've changed the approach to adding additional logging assert methods: We're now using mixin-composition instead of inheritance so we can add that functionality to every type of TestCase unittest offers instead of having to define separate child classes for every single one of them.

This PR closes #758

Is it out of scope to change assertions to use the new await assertions?

We could declare that within the scope of the PR, but it will delay it quite some while, I think. I haven't looked into it too deeply yet, but if we go that route, it basically means reevaluating each test method that uses coroutines to see if we can modernize the assert strategy.
Such a modernization would be a good (and probably sets the right examples to people writing new tests), but I could also argue that the upgraded test suite runs and provides the same level of "testing" as it did before the migration meaning that such a modernization would not be a pure migration but rather an enhancement now that new tools have become available.
I think we should carry out such a modernization, but I'm a bit on the fence on if it should be part of this PR. It will delay it by quite a bit (it's probably more work than the migration itself has been as all the test methods have to be actually looked at in detail) and make the review much more involved as well. We could also go with "the current migration provides the same level of testing as we had before so we'll do the modernization in a future PR".
What do you think?

What do you think?

Let's get this merged and take care of the await assertions in another PR. The 3.8 upgrade hasn't caused a regression regarding assertions - they are at least as effective as they were before. The await assertions are merely an improvement so they don't block anything. I'd rather have this merged first in case anyone else needs to write tests in their PRs.

Stalled by #755

This should no longer be stalled. The PR mentioned by Mark has been merged, which means we don't suffer from that changed behavior of the CancelledError anymore.


Add Formik Example

Howdy!
This PR adds an example illustrating how to build a simple contact form with Formik, Chakra, and the useMutation hook.

For simplicity's sake, form submissions go to FormCarry, a freemium product for handling form submissions. Users can sign up for a free account and specify their form ID via the following environment variable.
REACT_APP_FORMCARRY_ID=""

I hope this example helps demystify how one might leverage your wonderful library to build form(s)!

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   99.59%   99.59%
=======================================
  Files          16       16
  Lines         244      244
  Branches       45       45
=======================================
  Hits          243      243
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb1a672...8472def. Read the comment docs.

Thank you


Add a vdc fact to our test runs to make them pass

When testing under the future parser we see issues in
icinga/manifests/client.pp under
if ($::vdc == 'licensify') or ($::vdc == 'efg') or ($::vdc =~ /^*_dr$/) {
if the vdc is undefined.
Adding this fact doesn't fix the tests but it does move the problem along from
'Left match operand must result in a String value. Got an Undef Value.'
to Could not find template '' which is an issue from an upstream module we'll
deal with in isolation.

What's the significance of the cache and whitehall_backend machines with relation to icinga/manifests/client.pp? Are other nodes also affected?

Those issues will come up in integration testing. This is just for the unit testing phase.

@deanwilson: I meant that you made changes to the spec tests for those machines but not the other machines. Why are those machines affected but not others?

Those are the only two machines that had failing tests. Either the other machines define their environments differently or they have less test coverage.


Leave a Review Pop-Up

Modal Title

The modal window should have a title that displays “LEAVE A REVIEW ABOUT OUR PUMPKINS” prominently at the top.

Form Elements

Include a form within the modal that contains the following <input> elements:

Name: A text input for the user's name, with validation to ensure at least two characters using the pattern attribute.
Email: An email input for the user's email address, ensuring proper email formatting with the pattern attribute.
Phone Number: A text input for the user's phone number, using a pattern to validate valid phone number formats.
Message: A text area for users to leave their review or feedback.

Implement minimum validation for each input field using the pattern attribute to ensure users provide valid data:

For the name, the pattern could require at least two characters.
For the email, use a standard email format pattern.
For the phone number, implement a pattern that allows only valid phone number formats (e.g., 10 digits).

Submit Button

Include a “Submit” button of type submit that processes the form data.
When the button is clicked, the modal should close, indicating to the user that their review has been submitted.

I would like to work on this issue . can you assign this issue to me ?

@Mayuphapale hi, yes you can. Please read carefully documentation, also you can watch video of how to contribute as well as read Contributing.md file. You assigned for this task, I'm waiting for your PR's. Thank you

@Mayuphapale any updates on your task?

@a-woodworth Amy, do you want to put your hands on this task and finish it?

@Alexandrbig1 I can do it, but can't get to it until this weekend.

@a-woodworth that's ok, if no one is start till that, we still have a week to finish our project.

@a-woodworth great work Amy!


Docker 1.10 API docs on exec inspect seem wrong

Output of docker version:
Client version: 1.7.1
Client API version: 1.19
Go version (client): go1.6
Git commit (client): 786b29d
OS/Arch (client): darwin/amd64
Server version: 1.10.3
Server API version: 1.22
Go version (server): go1.5.3
Git commit (server): 20f81dd
OS/Arch (server): linux/amd64

Output of docker info:
Containers: 6
Images: 1
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 14
 Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 4.1.19-boot2docker
Operating System: Boot2Docker 1.10.3 (TCL 6.4.1); master : 625117e - Thu Mar 10 22:09:02 UTC 2016
CPUs: 2
Total Memory: 1.955 GiB
Name: 1.10.3-vmware
ID: NYFA:XWPO:HDL2:SDNL:LWHQ:WPS2:SU2X:IHRA:K5F3:5XJ2:RGZJ:HWTK
Debug mode (server): true
File Descriptors: 25
Goroutines: 38
System Time: 2016-03-29T19:59:33.113353448Z
EventsListeners: 0
Init SHA1:
Init Path: /usr/local/bin/docker
Docker Root Dir: /mnt/sda1/var/lib/docker
Username: dxia
Registry: https://index.docker.io/v1/
Labels:
 provider=vmwarefusion

Additional environment details (AWS, VirtualBox, physical, etc.):
Steps to reproduce the issue:

do a docker exec create
do docker exec start
docker exec inspect

curl --insecure --cert ~/.docker/machine/machines/1.10.3-vmware/b2d-client-side.p12 --pass tcuser 'https://<IP_ADDRESS>:2376/exec/f33bbfb39f5b142420f4759b2348913bd4a8d1a6d7fd56499cb41a1bb91d7b3b/json' -vvv

*   Trying <IP_ADDRESS>...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 2376 (#0)
* WARNING: SSL: Certificate type not set, assuming PKCS#12 format.
* Client certificate: dxia
* TLS 1.2 connection using TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
* Server certificate: dxia.1.10.3-vmware
* Server certificate: dxia
> GET /exec/f33bbfb39f5b142420f4759b2348913bd4a8d1a6d7fd56499cb41a1bb91d7b3b/json HTTP/1.1
> Host: <IP_ADDRESS>:2376
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Content-Type: application/json
< Server: Docker/1.10.3 (linux)
< Date: Tue, 29 Mar 2016 19:47:24 GMT
< Content-Length: 379
<
{"ID":"f33bbfb39f5b142420f4759b2348913bd4a8d1a6d7fd56499cb41a1bb91d7b3b","Running":false,"ExitCode":2,"ProcessConfig":{"tty":true,"entrypoint":"sh","arguments":["-c","exit 2"],"privileged":false,"user":"1000"},"OpenStdin":true,"OpenStderr":true,"OpenStdout":true,"CanRemove":false,"ContainerID":"b53ee82b53a40c7dca428523e34f741f3abc51d9f297a14ff874bf761b995126","DetachKeys":""}

Describe the results you received:
There's only a ContainerID instead of the entire Container object as stated in the docs here https://github.com/docker/docker/blob/master/docs/reference/api/docker_remote_api_v1.22.md#exec-inspect.
Describe the results you expected:
The docs should correspond to the behavior.
Additional information you deem important (e.g. issue happens only occasionally):

Thank you, i will look into that #dibs

Can confirm this issue and some more differences between example responses in docs and actual responses to api calls

@senk, thanks.


Markdown link incorrectly formatted in documentation

Version
2.1.2
Reproduction

Visit: https://www.styled-components.com/docs/api#withcomponent
See that (Extending Styles)[/docs/basics#extending-styles] is not rendered as a link.

Good spot! Thanks for reporting :smile:
In the future btw, there's a separate repo for the website where you can report these: https://github.com/styled-components/styled-components-website

I've got a fix in place for it: https://github.com/styled-components/styled-components-website/pull/98


tests, bond: check bond takes the mac from the new port

Due to commit [1], NetworkManager is not keeping the bond mac address
when replacing ports. This change affects NM 1.30 and greater.
[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/190fd9aa9f3fbf5705c2b80b9fc64c89d22b7593
Signed-off-by: Fernando Fernandez Mancera<EMAIL_ADDRESS>

works for me


Improve design

The design is very simple and bland. Can we spruce it up and make it look more modern?

This is totally the kind of thing we could do in small iterations rather than one big PR :sparkles:
Some changes might just require styling, more ambitious ones might take some structural change. And I guess we should be aware we're potentially setting up patterns for others to follow, so might want a bit of thought before committing.
It would be super-helpful to pull together some kind of mood board of little screen grabs of the kind of styles you have in mind. Or even just link out to some sites that have the kind of look/feel you'd like for NDIT!


[17.10] re-vndr libnetwork to 6c51292 and swarmkit to 872861d

Re-vndr and cherry-pick a commit https://github.com/moby/moby/pull/35103/commits/7e6b216 (cherry-pick went in clean) to update the DockerSwarmSuite.TestSwarmNetworkIPAMOptions test:
$ cd components/engine
$ vi vendor.conf
$ make BIND_DIR=. shell
$ vndr github.com/docker/libnetwork
$ vndr github.com/docker/swarmkit
$ exit
$ cd ../..
$ git cherry-pick -s -x -Xsubtree=components/engine 7e6b216

Brings in the following libnetwork changes:

https://github.com/docker/libnetwork/pull/1788 Serializing bitseq alloc
https://github.com/docker/libnetwork/pull/1935 Overlay fix for transient IP reuse
https://github.com/docker/libnetwork/pull/1936 NetworkDB create NodeID for cluster nodes
https://github.com/docker/libnetwork/pull/1958 Repair (*Broadcaster).run goroutine leak
https://github.com/docker/libnetwork/pull/1960 Fix comparison against wrong constant
https://github.com/docker/libnetwork/pull/1968 Fix IPMask marshalling
https://github.com/docker/libnetwork/pull/1973 Fix typo in overlay log message
https://github.com/docker/libnetwork/pull/1974 Disable hostname lookup on chain exists check

Comparison of changes in libnetwork upstream: https://github.com/docker/libnetwork/compare/0f08d31...6c51292
Brings in the following swarmkit changes:

https://github.com/docker/swarmkit/pull/2324 Adding ipam options to ipam driver requests
https://github.com/docker/swarmkit/pull/2362 More comments and logging fixes.
https://github.com/docker/swarmkit/pull/2389 More logging for raft/processInternalRaftRequest

Comparison of changes in swarmkit upstream: https://github.com/docker/swarmkit/compare/941a018...872861d

I think there is a compilation error due to something in swarmkit missing...

looks like https://github.com/docker/libnetwork/commit/a2bcac00122a43d771af77ff060794dd02bb4a00 is missing

@vieux i think the original failure in compilation was because i did not also update the vendor to swarmkit. i've now updated the PR to vendor swarmkit up to the point similar to this PR to moby/moby https://github.com/moby/moby/pull/35103


GPQ Feature:

Ability to track reactions to a GPQ attendance post on google sheets

Done in #7 and #8

Done in #7 and #8


"compare with current" throws

System: windows 7 x64
vscode-gitstash: 1.0.1
vscode: 1.29.0 (system setup)
When clicking on the compare with current on a stashed file, it throws:
Unable to open '#0: items.js - Modified (server/)': A system error occurred (UNKNOWN: unknown error, stat '\\c:\repos\test\server\items.js').

Hi @dwelle, thanks for the report! I'll fix it as soon as I get some time

Hi @dwelle, sorry for the delay. Would you mind to confirm if its working for you with the new version?

it does, good job :+1:


rhoas service-registry create missing description flag

Description
rhoas service-registry describe/rhoas service-registry create - missing description field?

Example of the issue that were reported by PM

I have moved that issue to jira

Moved to jira.


Make friend finder permissions an opt-in

I tried to login with G+ and found out that it now requires way to much private info from my account. It is good I have Bitbucket option, otherwise I may consider closing the account and moving somewhere else. I really think that any extended access to private user data should come as an opt-in.
I haven't got into OAuth stuff yet, but maybe request additional permissions when user is trying to use Friend Finder tool, not when the user is logged in?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/11029948-make-friend-finder-permissions-an-opt-in?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

Closing in favor of #2854, which you've assigned to yourself .


✨ Add Urdu language support

I have added the translations, although I noticed the RTL support doesn't exist in the app yet.
For RTL languages, Ideally, the direction of most UI components should be reversed.

@MBM1607 rtl support has been added https://github.com/ImLunaHey/bsky-client/commit/770fcfc622f95c98ec8346a5e15b6ae20f20313b


no glTexImage2DMultisample

There does not seem to be a glow equivalent of glTexImage2DMultisample.

I just made a pull request to add glTexImage2DMultisample: #160

Fixed by #160


Failure of room update shouldn't unload room

Title says it all. An exception while updating room shouldn't mean that room gets unloaded. Also take this opportunity to refactor things appropriately with getRaces()

This was resolved in #102


Add readme for ic-verifiable-credentials and bump library

Motivation
The library is published in crates.io but there is no readme for developers to understand what this library is about.
Changes

Edit main README to introduce the new library.
Add new README for ic-verifiable-credentials which will be fetched by crates.io.

Tests
Only doc changes.
Todos

[ ] Add entry to changelog (if necessary). NOT necessary.

@frederikrothenberger @LXIF please review


Steps until 1.2 (or 1.1.2?)

What do you think has to be done? Did you find any bugs?

Bugs to fix:

Game crashes when rewards are optional but cages are not and Nemesis in the fields challenges the mc when other cages are still active (she walks to a door and tries to take it while the next room rewards have not yet been chosen), I fixed this locally already
Icarus rewards are not copied
Boon rewards from steering wheels on boats in the rift are not copied

All fixed


port over netrunner's HTTP cat command because it's way better

floppy made this not me

closing becasue floppy opened another one, 2 fast 4 u 😔

smh this PR was way better than the other one, and you were faster

i am speed


Deprecation warning when installing iterm2-version in a clean project

After installing iterm2-version in a clean project, I get the following deprecation warning:
npm WARN deprecated<EMAIL_ADDRESS>cross-spawn no longer requires a build toolchain, use it instead

This warning is coming from<EMAIL_ADDRESS>dependency execa dependency.
I've added a similar issue upstream, which is already fixed.
Can the app-path dependency be updated please?
Thanks for all your great work @sindresorhus! 🙂

@sindresorhus I fixed this myself in #6 🙂


[release-4.12] OCPBUGS-13943: fix double machine creation on stale cache

This is a manual cherry-pick of https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/208
Superseedes https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/209

/retest

/jira refresh

/retest

This test is currently broken and the etcd team is working on making it compatible with the cpms.
Given the above, and the fact the operator task completed successfully, (which covers the etcd scaling mechanism through testing CPMS), I'm going to override this to continue
/override ci/prow/e2e-aws-ovn-etcd-scaling

/hold
/jira refresh

/jira refresh

/label qe-approved

/label cherry-pick-approved

/unhold


Allowing regular expressions as arguments in the "depends" function for load functions

Describe the problem
I have to use regular expressions in depends to invalidate certain load functions by calling the invalidate(urlWithPattern => condition(urlWithPattern)) function. Sometimes urls passed to depends have parameters and I don't want to specify the whole url, or cannot write the full pathname, because it's dynamic. However, I have to decode them each time from the string urlWithPattern which is automatically encoded when passing them to depends. Could there be an option to pass regular expressions to the depends function? It seems logical given that there are dynamic urls everywhere.
Describe the proposed solution
Allow instances of the class RegExp as arguments to depends instead of just strings.
Alternatives considered
Using decodeURI, see my hack below.
Importance
nice to have
Additional Information
My current hack is
export const smartInvalidate = async (absoluteOrRelativeUrl: string): Promise<void> => {
    const fullUrl = urlForSvelteFetch(absoluteOrRelativeUrl);
    await invalidate((loadUrlPattern: URL) => {
        const decoded = urlForSvelteFetch(
            decodeURI(loadUrlPattern.toString())
        );
        const regex = new RegExp(`${escapeUrl(decoded)}$`);
        const matches = fullUrl.match(regex);
        const condition = (matches && matches.length > 0) ?? false;
        return condition;
    });
}

What would this give you that the current way of passing a function wouldn't give you? What you describe as a hack is a valid way of doing things to me (I think you can simplify this to just using .href for getting the string btw), and from looking at your function body it sounds like you need more capabilities than a simple regex either way.
How would your current solution look like if you had the regex capability?

It would save me the decodeURI call, but I can also just do it with this current function.
Do you mean I could change decodeURI(loadUrlPattern.toString()) to loadUrlPattern.href? I am afraid that that is undefined for me. I also have to decode the regex if it would be defined.

Can you give a concrete example where the decodeURI/href things is necessary? Like "depends('x:y') followed by smartInvalidate('z')"

strings passed to depends must be valid URL strings as its converted to an URL object. Passing regexes would make all this more complicated, and we would need to ship additional code in the client for everybody when only a fraction of people would use this. I'm therefore closing this issue - creating helper functions building upon depends and invalidate is the way to go.
For SvelteKit 2 we might in general rethink whether or not really makes sense for depends/invalidate to deal with URLs instead of just plain strings.


New Version: Astronomer.Astro version 1.18.1

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/115251&drop=dogfoodAlpha

@wingetbot run


Find in Folder need escaping when filling "files to include" search option

Issue Type: Bug

have a folder named "some[folder]"  in the workspace
right click the "some[folder]" in explorer pane
select "Find in Folder..."

the search pane is shown and files to include will be ./some[folder]
no file is shown because brakets are interpreted as special characters
instead it shoud be escaped to ./some[[]folder[]]
in this way it work as expected and folder content is shown

In the same way it needs to be escaped other characters e.g. '[', ']', '(', ')', '{', '}'.
Other features requests are asking to support folder names with parhentesis; they are already supported indeed but need to be correctly escaped. And this should be done when auto-filling the search options.
VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-10T23:34:32.027Z)
OS version: Windows_NT x64 10.0.19042

https://github.com/microsoft/vscode/issues/82415


JSDoc:  overwritable renderer methods missing @protected?

According to the documentation topic "Extending Input Rendering", some control renderers allow their methods to be overwritten.

The following code snippet creates a control type that inherits from sap.m.Input. The new control has all features from the Input control, but the rendering is changed [...].
The control API and the render method can be inherited as it is and the renderInnerAttributes method of the InputRenderer is overwritten:
{ // ...
  renderer: {
    // note that no render() function is given here. The Input's render() function is used.
    // But one function is overwritten:
    writeInnerAttributes : function(oRm, oInput) {
      // ...
    }
  }
}

It is not clear from the API contract perspective, which APIs are allowed to be overwritten exactly, although their descriptions usually say:

This method is reserved for derived classes to add extra attributes for the input element.

Shouldn't those methods be marked with at least @protected?
AFAIK, APIs without @protected or @public are private by default.
Yesterday, I posted an answer suggesting to overwrite the addOuterStyles method accordingly: https://stackoverflow.com/a/67919830/5846045. But because there is no @protected, I'm not sure if it's a reliable solution.
If it's applicable, it would be nice if overwritable methods from all renderer modules could be enhanced with the visibility info (@public or @protected) so that control developers can confidently overwrite the methods.

Hi @boghyon
This is a good question.  I've created an internal incident<PHONE_NUMBER> to check with my colleagues. The status of the issue will be updated here.
Regards,
Georgi

@niyap @gmkv Thank you for the improvement at https://github.com/SAP/openui5/commit/982242cc6300f5c059c410f113c3722b14b0a88e. 👍
Now the next obvious question is: what about other renderers?
This issue was mentioning only the methods from the Input(Base)Renderer as an example. But as the title suggests, it's actually referring to all renderers. Would be nice if this issue could be reopened to clarify the visibility also for other renderer methods; which one can be overwritten and which not.


[Cyclonus] add support for external traffic (where peer is outside of the cluster)

Do we want to support this?
https://github.com/mattfenwick/cyclonus/issues/25

/remove-lifecycle stale

/remove-lifecycle rotten

/remove-lifecycle rotten


Fixed for  cairo 2.2.0 for the tutorialv2 branch

Fixes done:

Replace Serde calls with StorageSize
Replaced pedersen function with pedersen::pedersen function call
Fixed tests

lgtm


Training/running on custom speaker?

Hi! Thanks for your amazing work! I'm curious to know, if I want the best performance possible (on a new speaker), do I need to train this model on their audio recordings? If so, I'm curious with the 4x V100 you mentioned, how long would I need to fine-tune the existing model on the files I have?
Also how big of a dataset do I need of a single speaker?

The model is not intended to work on unseen speaker, so it should be trained on target speaker.
If you mean 'training from scratch' vs 'fine-tuning' for new speaker, I expect fine-tuning works better on < 10k samples.
I just used available V100 x4 gpu and trained about a week on LJSpeech, so wouldn't it be enough within half week for fine-tuning?
Sorry I don't have various experience such as minimal dataset size.

Oh sorry I didn't know that! So in the case of training from scratch then would it need around 10K examples? How many examples did you use?

Sorry for late reply.
Because I have limited experience, i can say for sure only what i've done.
The experiment I've done was conducted on LJSpeech dataset which has 13,100 samples and 6.5s mean duration as you can check.
Although I downsampled to 22.05kHz if 44.1kHz, I expect 44.1kHz also work. And model performance may depend on various factor (dataset, model size, hyper-parameters, ...)
Since JETS is also implemented on ESPnet, if you want quick experiment, you can follow the recipe using configuration of JETS: https://github.com/espnet/espnet/blob/master/egs2/ljspeech/tts1/conf/tuning/train_jets.yaml


Replace std::optional with internal one, fix container codegen

std::optional has too much problems. It doesn’t actually use pointers, so it allocates stack memory that’s either “valid” or not based on a Boolean. This breaks nesting containers as C++ can’t size nested structures. std::unique_ptr is also a pain without copy construction and shared_ptr is inappropriate, so we make our own Optional type.
Also fix an issue with containers contents not having code generated.

/makerelease


[Bug]: When using AzureOpenAI for embedding azure_deployment needs to be provided as well

What happened?
As a chromadb user, when I use Azure Open AI, I want to be able to use my embedding funciton with collection creation but currently it does not let me specify azure_deployment so it throws DeploymentNotFound exception (see logs):
my_azure_openai_ef= embedding_functions.OpenAIEmbeddingFunction(
            api_key=OPEN_AI_API_KEY,
            model_name="text-embedding-ada-002",
            api_base="https://my_azure_open_ai_endpoint.openai.azure.com",
            api_type="azure",
            api_version="2023-05-15",
            )
`client.get_or_create_collection("my_collection", embedding_function=my_azure_openai_ef)`

In embedding_functions.py there is a code execution path that gets triggered when api_type="azure"
        self._client = openai.AzureOpenAI(
            api_key=api_key,
            api_version=api_version,
            azure_endpoint=api_base,
            default_headers=default_headers,
        ).embeddings

The issue is that it is missing azure_deployment="your_deployment_name_here"
Whithout it my azure deployment cannot be reached.
See attached log for more details
To test it I have this setup:
client = AzureOpenAI(
    api_key=OPEN_AI_API_KEY,
    azure_endpoint="https://my_azure_open_ai_endpoint.openai.azure.com",
    azure_deployment="my_azure_open_ai_deployment",
    api_version="2023-05-15")

def text_embedding(text):
    response = client.embeddings.create(model="text-embedding-ada-002", input=[text])
    return response.data[0].embedding

When I skip azure_deployment="my_azure_open_ai_deployment",  my text embedding function throws not found exception. Azure Open AI endpoints need the deployment name in order for it to work.
See https://github.com/openai/openai-python?tab=readme-ov-file#microsoft-azure-openai for more details
Also can you update docs to include link to api versioning in Azure:
https://learn.microsoft.com/en-us/azure/ai-services/openai/reference#rest-api-versioning
Versions
ChromaDB 0.4.21, Python 3.11.5
Relevant log output
Cell In[2], line 14
     13 def text_embedding(text):
---> 14     response = client.embeddings.create(model="text-embedding-ada-002", input=[text])
     15     return response.data[0].embedding

File c:\Python\Lib\site-packages\openai\resources\embeddings.py:113, in Embeddings.create(self, input, model, dimensions, encoding_format, user, extra_headers, extra_query, extra_body, timeout)
    107         embedding.embedding = np.frombuffer(  # type: ignore[no-untyped-call]
    108             base64.b64decode(data), dtype="float32"
    109         ).tolist()
    111     return obj
--> 113 return self._post(
    114     "/embeddings",
    115     body=maybe_transform(params, embedding_create_params.EmbeddingCreateParams),
    116     options=make_request_options(
...
   (...)
    987     stream_cls=stream_cls,
    988 )

Error code: 404 - {'error': {'code': 'DeploymentNotFound', 'message': 'The API deployment for this resource does not exist. If you created the deployment within the last 5 minutes, please wait a moment and try again.'}}

hey @pavlovmilen this got dropped!
This should be a very easy change to make. I'd be happy to review a PR if you want to add this to the embedding function (https://github.com/chroma-core/chroma/blob/main/chromadb/utils/embedding_functions.py#L103-L180) or I may be able to get to it next week.

I have a PR ready for review


Folders with spaces in their name appear empty if navigated into

To reproduce

Open https://prose.io/#Tc-001/Prose-bug-repro/tree/main
Navigate to ./Folder_no_spaces
Notice markdown file text.md
Go back
Navigate to ./Folder with spaces
Notice the absence markdown file text.md
Reload page
Notice markdown file text.md

This could likely be because when navigating, Folder with spaces becomes Folder%20with%20spaces (as seen in the breadcumb element), but after a reload it changes back to the correct (url unescaped) form

I would love to help with this

Hey there @Tc-001. I've resolved this issue with #1144. If you can give that a thumbs up hopefully the maintainers will see and merge.
In the meantime, I'm currently hosting my own fork with some bugfixes (including this one) and features I've worked on @ joebabbitt.com/prosa. Since I want to avoid standing up my own gatekeeper instance and am keeping everything client-side, I've enabled login via github PAR token. (You'll need to create a token with the repo and user scopes to login).

I've confirmed that merging #1144 fixed this at https://prose.io//#Tc-001/Prose-bug-repro. :tada:


Remove redundant array assignments

Hello! Thanks for writing this package.
I noticed that the code for push assigned to this.ids and this.values twice, both before and after the sift loop.
This PR removes the extra assignments and passes tests.

<3 no worries – thanks for everything!


Add possibility to copy text from hover tooltip

Check for existing issues

[X] Completed

Describe the feature
It would be nice to add a possibility to select and copy a text from the hover tooltip. Currently, the hover tooltip is closed when it is clicked. For example in some cases in Typescript, it is faster to copy the type than to write it manually.
If applicable, add mockups / screenshots to help present your vision of the feature
Zod:

VSCode - selected text which is possible to copy:

Error message - copy error message and paste into the browser

Eslint message - copy eslint rule

+1 for the useful feature.


Fix adonis being bricked for a long time (fixes crosserver issue)

Fixes #1234
Fixes \/

Loading order before issue:

Loading order after removal of crossserver plugin:

Loading order with fix applied:

thank you scel (totally scel's doing)

thank you scel (totally scel's doing)

Probably stems from a Roblox bug tho


WindowsHostSettings.CanHandlePowerEvent is not exposed for setting

To use the new power event code, you have to be able to set WindowsHostSettings.CanHandlePowerEvent to true. However HostConfigurator (and the Impl) is missing an EnablePowerEvent method to turn this on.

I am closing all issues that haven't seen any activity. You're welcome to submit a PR to resolve the issue or provide more information.


502 Bad Gateway

I am trying to create a test class for other class and when I press the Test class button after selecting the class I get a 502 Bad Gateway Issue.

@GastonLopezz I have deployed a fix, it should be up and running in next 10 mins.
There were too many users that were trying at the same time caused the app to crash

It keeps happening to me, looks like it's a problem related to that apex class since last Friday happened to me too. Maybe because of the implements Callable it has?

@GastonLopezz does it keeps happening for a single apex class ?
Also can you let me know how many apex class do you have in this org ?

Yes, for a single apex class. The org has 39 classes.

This should be fixed, Please reopen if it isn't


Programmatic page, issue ingest

General goal

Provide 60% of the needed pieces (under the hood) for implementation of #8.
Ability to programmatically attach a work in Ruby, without upload through browser, to works in Hyrax, specifically:

Single source file ingest of (image) file representation for NewspaperPage objects.
Single source file ingest of (image/document) file representation for
Agnostic to source format, provided it is supported by Hyrax (and hydra-derivatives and/or MiniMagick) out of the box.
Ability to run ingest on existing work repeatedly for multiple files (appending each) is assumed, but may be optional scope for initial testing.

Have a reasonable degree of re-use for above, such that it can be used:

By later code we write to intercept upload in Hyrax (actor, job(s));
In a rails console session;
In one-off scripts;
In more complex future ingestion pipelines (e.g. a future REST API, or something that pulls assets from cloud storage, etc).

Work on and manipulate persisted model objects, but not have this ingest implemented on model classes.

Deliverables

Work will be done in pdfingest branch.
Create module NewspaperWorks::Ingest, see here.
Create series of adapter classes which act upon a work context.

BaseIngest class implementing common IO and filename wrangling, and a standard way to provide subclasses file stream and file name.
A NewspaperPageIngest class providing for the attachment of an image file to a NewspaperPage work (and subsequent creation of derivatives).

Ensure that default Hyrax behaviors for new works (jobs usually run by actor stack) are eventually run for this attachment.

e.g. Create derivatives and thumbnails.

A NewspaperIssueIngest class providing for:

The creation of split page master images from multi-page PDF via MiniMagick (but we need a directory to write this to, TBD).
Code to instantiate, attach, and persist new NewspaperPage for each of above.

We need to pick a reasonable way to create titles for these works?
Ensure that default Hyrax behaviors for new works (jobs usually run by actor stack) are eventually run for each page.

A sample script to create page works from one or more paths.
If User.current_user is unavailable, use User.batch_user as depositor for work.   Need to determine most sensible place to put this.

Hyrax::AttachFilesToWorkJob assumes work.depositor is set.
We likely want to set depositor if it is not already set when performing an upload, but only if we plan to re-use existing Hyrax code that requires it.

RSpec tests for BaseIngest with coverage of all methods, simulating both accepted and error conditions.
RSpec tests for NewspaperPageIngest verifying everything we can verify on non-async results.
RSpec tests for NewspaperPageIngest verifying everything we can verify on non-async results.

Quality assumptions

All tests, including new pass.
All rubocop checks pass.

A few additional notes in the wiki.

Resolved by #30.


[KYUUBI #2624] Support isExtended for FilteredShowTablesCommand in AuthZ module.

Why are the changes needed?

to close #2624.
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #2625 (645ca97) into master (ce56d70) will increase coverage by 0.28%.
The diff coverage is 100.00%.

:exclamation: Current head 645ca97 differs from pull request most recent head 6e8053a. Consider uploading reports for the commit 6e8053a to get more accurate results

@@             Coverage Diff              @@
##             master    #2625      +/-   ##
============================================
+ Coverage     63.32%   63.61%   +0.28%
+ Complexity      205       79     -126
============================================
  Files           485      380     -105
  Lines         21692    18518    -3174
  Branches       2859     2508     -351
============================================
- Hits          13737    11780    -1957
+ Misses         6655     5625    -1030
+ Partials       1300     1113     -187

Impacted Files
Coverage Δ

...k/authz/ranger/RuleReplaceShowObjectCommands.scala
76.19% <100.00%> (+16.19%)
:arrow_up:

...c/main/java/org/apache/kyuubi/jdbc/hive/Utils.java
2.34% <0.00%> (-34.25%)
:arrow_down:

...kyuubi/engine/trino/operation/TrinoOperation.scala
53.06% <0.00%> (-16.33%)
:arrow_down:

...he/kyuubi/spark/connector/tpcds/TPCDSCatalog.scala
42.10% <0.00%> (-15.04%)
:arrow_down:

...org/apache/kyuubi/engine/flink/schema/RowSet.scala
54.86% <0.00%> (-10.96%)
:arrow_down:

...authentication/AuthenticationProviderFactory.scala
63.33% <0.00%> (-10.36%)
:arrow_down:

...ache/kyuubi/jdbc/hive/KyuubiPreparedStatement.java
27.58% <0.00%> (-9.12%)
:arrow_down:

...rg/apache/kyuubi/engine/trino/TrinoStatement.scala
68.96% <0.00%> (-9.01%)
:arrow_down:

...thentication/KyuubiHttpAuthenticationFactory.scala
80.00% <0.00%> (-8.00%)
:arrow_down:

...ver/http/authentication/AuthenticationFilter.scala
84.21% <0.00%> (-7.46%)
:arrow_down:

... and 224 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce56d70...6e8053a. Read the comment docs.

please help。resolve conflicts

PLEASE REVIEW AGAIN.

thanks, merged to master


Support node 19

Motivation
Support node 19 now that it has been officially released by node, see:

https://nodejs.org/en/download/current/
https://github.com/nodejs/Release#release-schedule

Current behavior
When trying to install dependencies yarn fails with the following error:
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18". Got "19.0.0"

Desired behavior
Installing @es-joy/jsdoccomment when using node 19 should work.
Alternatives considered
We could use something like yarn install --ignore-engines as a workaround but that opens us up to compatibility errors that will only show up at runtime.

Released as v0.33.0 . Hope to get to eslint-plugin-jsdoc today as well.


Amazon Drive: rclone won't timeout idle transfer

What is your rclone version (eg output from rclone -V)
rclone v1.34-71-g4482e75β

Which OS you are using and how many bits (eg Windows 7, 64 bit)
Ubuntu 16.04.1

Which cloud storage system are you using? (eg Google Drive)
Amazon Drive

The command you were trying to run (eg rclone copy /tmp remote:tmp)
rclone move adrive:"blah/blah/" encrytped:"enc/blah/blah/" --verbose --stats=10s

A log from the command with the -v flag (eg output from rclone -v copy /tmp remote:tmp)

2016/12/16 08:26:55
Transferred:   56.539 GBytes (1.240 MBytes/s)
Errors:                 0
Checks:                90
Transferred:           90
Elapsed time:  12h58m23.8s
Transferring:
 * ...aaaaaa.mp4:  0% done. avg:    0.3, cur:    0.0 kByte/s. ETA: 0s
 * ...bbbbb.mp4:  1% done. avg:    0.1, cur:    0.0 kByte/s. ETA: 0s
 * ...ccccc.mp4:  1% done. avg:    0.1, cur:    0.0 kByte/s. ETA: 0s
 * ...ddddd.mp4:  0% done. avg:    0.2, cur:    0.0 kByte/s. ETA: 0s

2016/12/16 08:27:05
Transferred:   56.539 GBytes (1.239 MBytes/s)
Errors:                 0
Checks:                90
Transferred:           90
Elapsed time:  12h58m33.8s
Transferring:
 * ... aaaaaa.mp4:  0% done. avg:    0.3, cur:    0.0 kByte/s. ETA: 0s
 * ...bbbbb.mp4:  1% done. avg:    0.1, cur:    0.0 kByte/s. ETA: 0s
 * ...ccccc.mp4:  1% done. avg:    0.1, cur:    0.0 kByte/s. ETA: 0s
 * ...ddddd.mp4:  0% done. avg:    0.2, cur:    0.0 kByte/s. ETA: 0s

At this point of time, the files was stuck/idled for more than ten hours. rclone jsut won't timeout these files and retry. I also tried with different --timeout settings but to no avail.

Can you run with the -v flag and post the log please?
Have you set  --acd-upload-wait-per-gb to a very large value?

I already ran with verbose, and there was no errors of any kind. It simply would not transfer anymore. And no, I did not change the --acd-upload-wait-per-gb flag.
Both of the paths are on the same ACD account, so I think this was a problem with ACD itself. After that, I just download everything first, then upload later instead of copying directly. That way things are faster and more reliable.

OK - glad you've sorted it.  I'll close this now.


Consider to treat null argument as a clear marker for some search query methods

Following examples should do the same:
query.clearAggs()

query.aggs(null)

Closed due to #58


Handle cancel events when waiting for swaps

This change handles the grpc CANCELLED error, which is emitted when calling .cancel() on a readable stream.

 Unhandled CANCELLED error if swap is expired


Fatal: Access is denied; did you install phantomjs? - firewall / virus scanner

Tried another sample code on windows 10:
import tagui as t
t.init()
t.url('https://www.google.com')
t.type('//input[@class="gLFyf gsfi"]', 'weather singapore[enter]')
temp = t.read('wob_tm')
print("temp = " + temp)
t.close()

Error message
[TAGUI][ERROR] - following happens when starting TagUI...

Fatal: Access is denied; did you install phantomjs?

[TAGUI][ERROR] - use init() before using url()
[TAGUI][ERROR] - use init() before using type()
[TAGUI][ERROR] - use init() before using read()
temp =
[TAGUI][ERROR] - use init() before using close()

Should have phantomjs installed. I'm running TagUI on this machine.

Thanks CK for trying out TagUI for Python and sharing detailed replications steps!
I've tested on Windows 10 before and can't get something like above. Have borrowed a Windows 10 laptop just now and tested again, can't replicate the error that you are seeing. I also tried including into path a local TagUI installation but still, can't replicate the error message above (from CasperJS).
Can you try running the following in command prompt to see if there is any clue on the error message? Change username to your username. That error happens when CasperJS cannot find PhantomJS, but it should be there and detected.
cd C:\Users\username\AppData\Roaming/tagui/src/samples
C:\Users\username\AppData\Roaming/tagui/src/tagui 1_yahoo chrome

If running above gives the same error as you had, can you try doing the following from Python? It will try to download TagUI Windows zip again and unzip. My best guess is somehow the download is corrupted and some folders missing after unzip.
import tagui as t
t.setup()

If you can, upgrade to v1.4 before doing t.setup(). I've just released this version today which fixes issues (eg in #14) with reading text that has special characters from websites. Some computers have their own text encoding, which gives error when trying to read the UTF-8 encoding from TagUI.
pip install tagui --upgrade

Can you try running the following in command prompt to see if there is any clue on the error message? Change username to your username. That error happens when CasperJS cannot find PhantomJS, but it should be there and detected.
cd C:\Users\username\AppData\Roaming/tagui/src/samples
C:\Users\username\AppData\Roaming/tagui/src/tagui 1_yahoo chrome

No errors. My TagUI is good.

can you try doing the following from Python? It will try to download TagUI Windows zip again and unzip. My best guess is somehow the download is corrupted and some folders missing after unzip.
import tagui as t
t.setup()

The command prompt shows the following and stops there forever:
[TAGUI][INFO] - setting up TagUI for use in your Python environment
[TAGUI][INFO] - downloading TagUI (~200MB) and unzipping to below folder...
[TAGUI][INFO] - C:\Users\user\AppData\Roaming

If you can, upgrade to v1.4 before doing t.setup(). I've just released this version today which fixes issues (eg in #14) with reading text that has special characters from websites. Some computers have their own text encoding, which gives error when trying to read the UTF-8 encoding from TagUI.

Yes, have upgraded to v1.4.  Still the same - shows the 3 lines and stops forever

Reply 1/2 - for the downloading hangs issue can you try below (need to use your username)
Then see if it still downloading / hang after 10 minutes -
# if using Python 2
import urllib; urllib.urlretrieve('https://github.com/tebelorg/Tump/releases/download/v1.0.0/TagUI_Windows.zip', 'C:\Users\user\AppData\Roaming/TagUI_Windows.zip')

# if using Python 3
import urllib.request; urllib.request.urlretrieve(urllib.urlretrieve('https://github.com/tebelorg/Tump/releases/download/v1.0.0/TagUI_Windows.zip', 'C:\Users\user\AppData\Roaming/TagUI_Windows.zip')

If it completes, then check that the zip file below is there, and run below (your username)
import tagui as t
t.unzip('C:\Users\user\AppData\Roaming/TagUI_Windows.zip', 'C:\Users\user\AppData\Roaming')

The above debugging steps will find out where the hang happens and hopefully why.

Reply 2/2 - for the fatal access is denied error, first create a tagui_python file with just 1 line
live

Then, launch Python and type the following to if the error happens or works
import os
os.system('C:\Users\username\AppData\Roaming/tagui/src/tagui tagui_python chrome')

The above tries to isolate further by running the individual Python statement that triggered the error to check for clues why the error is showing when run from t.init() but works when you type manually from command prompt.
Appreciate your patience!! This is hard to debug for me because it is not replicable on the Windows 10 laptop I borrowed. But I'm definitely very keen to figure out what could be going wrong here.

# if using Python 3
import urllib.request; urllib.request.urlretrieve(urllib.urlretrieve('https://github.com/tebelorg/Tump/releases/download/v1.0.0/TagUI_Windows.zip', 'C:\Users\user\AppData\Roaming/TagUI_Windows.zip')

Run the above
import urllib.request; urllib.request.urlretrieve(urllib.urlretrieve('https://github.com/tebelorg/Tump/releases/download/v1.0.0/TagUI_Windows.zip', 'C:\Users\user\AppData\Roaming\TagUI_Windows.zip'))

Get the following error message:
  File "test.py", line 1
    import urllib.request; urllib.request.urlretrieve(urllib.urlretrieve('https://github.com/tebelorg/Tump/releases/download/v1.0.0/TagUI_Windows.zip', 'C:\Users\user\AppData\Roaming\TagUI_Windows.zip'))
                                                                                ^
SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes in position 2-3: truncated \UXXXXXXXX escape

SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes in position 2-3: truncated \UXXXXXXXX escape

Did some googling. The above error is due to the backslash.
So change to the following:
import urllib.request; urllib.request.urlretrieve(urllib.urlretrieve('https://github.com/tebelorg/Tump/releases/download/v1.0.0/TagUI_Windows.zip', 'C:/Users/user/AppData/Roaming/TagUI_Windows.zip'))

Error message:
Traceback (most recent call last):
  File "test31.py", line 1, in <module>
    import urllib.request; urllib.request.urlretrieve(urllib.urlretrieve('https://github.com/tebelorg/Tump/releases/download/v1.0.0/TagUI_Windows.zip', 'C:/Users/user/AppData/Roaming/TagUI_Windows.zip'))
AttributeError: module 'urllib' has no attribute 'urlretrieve'

Tried escaping the backslash:
import urllib.request; urllib.request.urlretrieve(urllib.urlretrieve('https://github.com/tebelorg/Tump/releases/download/v1.0.0/TagUI_Windows.zip', 'C:\\Users\\user\\AppData\\Roaming\\TagUI_Windows.zip'))

Same error message:
Traceback (most recent call last):
  File "test33.py", line 1, in <module>
    import urllib.request; urllib.request.urlretrieve(urllib.urlretrieve('https://github.com/tebelorg/Tump/releases/download/v1.0.0/TagUI_Windows.zip', 'C:\\Users\\user\\AppData\\Roaming\\TagUI_Windows.zip'))
AttributeError: module 'urllib' has no attribute 'urlretrieve'

Reply 2/2 - for the fatal access is denied error, first create a tagui_python file with just 1 line
live

Then, launch Python and type the following to see if the error happens or works
import os
os.system('C:\Users\username\AppData\Roaming/tagui/src/tagui tagui_python chrome')

Running the above give me the following error message:
Fatal: Access is denied; did you install phantomjs?

Hi CK, I'm sorry I missed out the double backslash \\ in my example above. Don't have a Windows laptop, trying to trace mentally from the code the response from os.environ['APPDATA'].
It looks like you are using Python 3, to make sure Python 3 is launched instead of Python 2, type python3 from command prompt (it should should Python version). After that -
# if using Python 3
import urllib.request; urllib.request.urlretrieve(urllib.urlretrieve('https://github.com/tebelorg/Tump/releases/download/v1.0.0/TagUI_Windows.zip', 'C:\\Users\\user\\AppData\\Roaming/TagUI_Windows.zip')

If it completes, then check that the zip file below is there, and run below (your username)
import tagui as t
t.unzip('C:\\Users\\user\\AppData\\Roaming/TagUI_Windows.zip', 'C:\\Users\\user\\AppData\\Roaming')

Above mix of \\ and / is intentional to mash the retrieved path and the filename.

For the runtime fatal error, after trying to resolve the download error then try again. I can't think of why the download fails and can't replicate on a Windows 10 laptop I borrowed previously.
A remote possibility may be the network access? I've encountered situations where the network in institutions blocks certain URLs from being accessed. Maybe the redirect programmatically fails.
In the meantime, keeping issue open for clues from other Windows users who may have this problem.

Solution found when you drop by my place just now. Firewall / virus scanner issue!
No wonder can't replicate on the Windows laptop I borrowed. After you exclude the 'C:\Users\user\AppData\Roaming\tagui\src\phantomjs' folder from the scanner, it works. The downloading may or may not be related to this firewall. Closing the issue for now, but do post here if you can replicate the download issue with firewall / scanner turned off!

I meet a similar issue with win10 1903
import tagui as t
t.init()
t.url('https://www.google.com')
t.type('//*[@name="q"]', 'decentralization[enter]')
print(t.read('resultStats'))
t.snap('page', 'results.png')
t.close()

when i install c++ dependency by install flow
  phantomjs://code/bootstrap.js:113 in __die

[TAGUI][ERROR] - use init() before using url()
[TAGUI][ERROR] - use init() before using type()
[TAGUI][ERROR] - use init() before using read()

[TAGUI][ERROR] - use init() before using snap()
[TAGUI][ERROR] - use init() before using close()

Hi @zengzhengrong can you tell me how you install the package, is it pip install tagui?
Can you run following script to see where TagUI has been installed? I googled and found that this error could be the folder of installation has a space in the folder name.
import os
print(os.environ['APPDATA'] + '/' + 'tagui' + '/' + 'src' + '/' + 'tagui')

After you find the folder, can you try go to the directory tagui\\src in your command prompt, after that run tagui samples\1_yahoo to see if there are other useful error messages on screen?

Hi, @kensoh I was looking to use Rpa for Python but I'm facing the same issue.
The following code:
import tagui as t
t.init()
t.url('https://www.google.com')
t.type('//*[@name="q"]', 'decentralization[enter]')
print(t.read('resultStats'))
t.snap('page', 'results.png')
t.close()
returns:
[RPA][INFO] - to use RPA for Python on Windows, avoid space in folder path name
[RPA][ERROR] - use init() before using url()
[RPA][ERROR] - use init() before using type()
[RPA][ERROR] - use init() before using read()
[RPA][ERROR] - use init() before using snap() [RPA][ERROR] - use init() before using close()
I already did the above steps of looking for "tagui samples\1_yahoo" (it worked fine and returned no error) and running with the Firewall/virus scanner disabled.
I will keep looking for a solution and try to help in any way possible.

Update
If the path has some spaces in it the error will appear.
I don't know if this is some kind of bug, or expected.

Hi @Lmac99 yes this is expected behaviour, and will show above error message [RPA][INFO] - to use RPA for Python on Windows, avoid space in folder path name. If the folder user uses to run the package has a space it will have this error, have to choose another folder without space.
However, if a username for Windows has space, then no matter what folder there will be a space on the full path to the Desktop folder. In that case, a workaround is having a dummy user account name with no space.
Unfortunately, this is a limitation (space in file path name) of the CasperJS / PhantomJS engine used by the package which I could not override this limitation from my side.

Hi @kensoh sorry by doing a dummy question, I've already run thes sugested code to detect the cause of the error "[RPA][INFO] - to use RPA for Python on Windows, avoid space in folder path name", an it returned:
C:\Users\josue\AppData\Roaming/tagui/src/tagui
So no visible spaces. Do You have any ideas, how to avoid this error?


segfault when applying backpressure to osmium read stream

@joto @springmeyer I'm using node-osmium to parse changefiles and seeing:
[  401.635084] node[8012]: segfault at 7f4785440818 ip 00007f478e55a815 sp 00007ffe400830a0 error 4 in osmium.node[7f478e4d2000+10f000]
Setup is like:

read stream from file on s3
gunzip
write to tmp file
create osmium read stream from tmp file with new osmium.Stream(new osmium.Reader(new osmium.File(filepath)));
pipe through transform stream to extract some information from each feature (id, type, version)
batch features and send off messages about each batch

In that final step, I'm exerting a lot of backpressure on the stream - via setting a highwatermark and implementing a 1-second pause for each batch -- so... reading from the osmium stream very slowly.
For a given file, it seems to segfault at roughly the same place each time (but this place is different for different changefiles). Here's the file I've been testing with, although I've had different changefiles cause this as well. http://planet.osm.org/replication/changesets/000/022/999.osm.gz
Any idea what's going on?
cc @rclark

This is unlikely to have anything to do with the backpressure. The files are so small that they will be completely read into memory anyway. I'll need the code you are using to reproduce this and debug it any further.
btw: Osmium can do the uncompress itself (will do this automatically if the file ends in .gz) and it can also directly read from http, just give it a URL instead of a filename.

bump: node-osmium v0.5.0 is now out with node v4/5 support and using libosmium 2.6.1. @emilymcafee - I would be interested to know if you can still replicate with this new version?

@springmeyer @joto I ended up reverting to a sax based parser, and afaik we don't need the speed gains from using node-osmium anymore. I'll re-open if we circle back to this implementation and still have problems, though. Thanks!


v-bind:key behavior

Version
2.4.2
Reproduction link
https://jsfiddle.net/worzuz0c/1/
Steps to reproduce
make a v-for loop with bind:key
add input with model of the key, start typing, after initial type cursor move out of the field.
What is expected?
Normal typing without cursor moving out
What is actually happening?
After first letter was typed cursor move out. As if there is "on-key-up = return false" set up.

For my it's normal behavior. Change of permission.key fire v-for and input is re-created. :key should be uniq and in this case isn't

Oh, wow, my bad, I thought the key was bound to the index, thanks @wszerad !
The input changing the value that is used for the key attribute, the input is re-rendered and therefore gets out of focus. A solution would be to manually focus it when the key changes by using a watcher

Or you can use .lazy modifier.


https://duo.com/ 2FA support?

Have created an account with Oasis and will try to configure, would be nice if Duo support could be added also.

Oliver (Oasis) and I made it so that any MFA could be implemented (Duo or other), with this interface


Garbled / white noise picture on some SiS (Unknown model)

[http://www.freeallegiance.org/forums/index.php?showtopic=54128 Relevant thread]
When the user first starts the client he is presented with white noise:  [http://i307.photobucket.com/albums/nn306/xix36/wtf.jpg Picture 1]
After the user changes some [unknown] settings he can at least see where he's flying: [http://i307.photobucket.com/albums/nn306/xix36/wtf2.jpg Picture 2]
The user in windowed mode at the "Free Games" screen:  [http://i307.photobucket.com/albums/nn306/xix36/alleg3.jpg Picture 3]
Imported from trac ticket #40,  created by fuzzylunkin1 on 01-06-2010 at 11:05, last modified: 01-09-2011 at 19:57

There isn't much to say about this problem.  We need a '''LOT''' more information.
Trac comment by fuzzylunkin1 on 01-06-2010 at 11:06

This should be closed (WONTFIX) if there is no DX9 support from the mfg.
Trac comment by anonymous on 07-19-2010 at 03:27

There is now support for the following SiS products:
SiS661FX, SiS661GX, SiS662, SiS671, SiS671FX, SiS672, SiS672FX, SiS760, SiS760GX, SiS761GL, SiS761GX, SiSM661FX, SiSM661GX, SiSM661MX, SiSM662, SiSM662MX, SiSM671, SiSM671MX, SiSM672, SiSM672MX on '''Windows XP''' - Vista/Win7 Is '''NOT SUPPORTED'''
SiS671, SiS671FX, SiS672, SiS672FX, SiSM671, SiSM671MX, SiSM672, SiSM672MX on '''Win7''' is also supported.
See http://www.sis.com/download/
Trac comment by Imago on 07-19-2010 at 06:30

Milestone R5.1 deleted
Trac comment by pkk on 01-09-2011 at 19:57


Saga asynchronous event loss

I configured saga asynchronous processing in this way. In the production environment, many saga events are lost and there is no exception information. May I ask the reason?

axon version 2.4.5

to really understand what's happening, we'd need more information about your deployment. Do you have multiple instances deployed?
Also note that in Axon 2, this form of async processing uses an in-memory buffer. If you restart your application without waiting for the buffer to be cleared, you may lose events. That's because, unlike in Axon 3 and 4, events are delivered in-process only.
Finally, there is the possibility that the associationProperty values don't match with the Saga instances, causing events to be ignored.

Two nodes, the halfway service is not restarted, and only part of the same event is lost, the lost event is concentrated in a certain period of time

If you have two instances, it is very much possible that the events they process are generated across both instances, and as a result, that the association properties aren't updated in order, causing these events to be ignored.
Note that the current major version of Axon is at 4. We very heavily recommend upgrading, because a lot of work has been done to improve how Axon works in distributed environments.

Closing this issue due to inactivity, assuming the problem has been resolved locally @Qurite. Feel free to keep commenting under here if the problem persists.


Updated addReaction template

Added small explanation and link to https://unicode.org/Public/emoji/11.0/emoji-test.txt

I'm pretty sure that if there is a fully-qualified and non-fully-qualified variant, it must be the non-fully-qualified variant. Feel tree to test and let me know if I'm wrong. (I was mostly testing with keycaps which perhaps behave differently?)
Also, I should just fix it to strip FEOF if found.
And add named emoji. :smile:

https://github.com/jonas747/discordgo/pull/2

Might be worth updating the template documentation to state that global emoji (Nitro) are not supported.

So whats the status on this?

Can be closed due to gitbook


Cluster-Autoscaler: fix delete taint value format

Fix a bug, where non-compliant value format prevented CA deletetaint from being created (which in turn caused CA node drain to fail).

This change is

/lgtm
/approve

/lgtm


Determine design and implementation methods for asynchronous events

Consider this:
Two serial ports are open in the same process and the select function is being called on both FID for the two serial ports from one thread.
What if two reads are requested with different timeouts?
What if a read for serial port 1 is called with a timeout of 20 secs and 2 secs later a read with a timeout of 10 secs is called on the second serial port?
Major decisions:
One select "server" using libev style event handling (how does this work anyways?) OR using a separate thread and select call for each serial port.
Do either of these methods effect a future implementation in kqueue or epoll or Windows?
Other considerations:

Support for handshaking line events.
Canceling timed events.

I think this is a mute point now, since we are just relying on the OS to handle these things for us.


Selector support

I've just switched from jQuery UI where I was using .selected:not(.disabled) as the selector for draggable items. But it seems Sortable only supports class names in the selector. Is there a reason for using a custom matches function instead of Element.matches()?

i wrap mine in a .each which seems to work. (but im very new to the library so might not be best
$(".selected:not(.disabled)").each(function(){
    new Sortable(this, {


Buttons - Disabled state

No a big deal. Documentation says to use disabled button you need class ".btn-disabled". However, it's just ".disabled"

Dupe to #1651


ci: switch to dtolnay/rust-toolchain action

actions-rs/toolchain is deprecated and has been archived

utACK 2c4b488a10befbc46a6595c5867dd6bd0a095022


fixed date past rendering issue

There was an issue in the isPast property which was responsible for displaying a box with the text "Event already passed". We figured out that the property was returning True or False only based on current time comparison with start time of the event. To fix this, we compared current time with end date of the event.

For the property eventPast, it was defined by being greater than the start date and time. Logically, the event has only already pasted when the current time is greater than the end date and time.

We noticed a build error after changing the logic of the isPast Event property. To fix the issue, we added a new property with the new logic.

There were 4 variables with very identical names, which made understanding the code harder. We refactored the whole codebase and only used 2 variables to make the event time more intuitive. Specifically, we are using isPastStart and isPastEnd to refer to the start and end of an event in the past.


sensor: Add NTC thermistor sensor for TDK Robokit1 board

The TDK Robokit1 board has an epcos,b57861s0103a039 NTC thermistor.
This exists on the SPI bus and is read via the ti,ads7052 ADC

The NTC thermistor has a lookup table to translate the resistance to a temperature value.  Do we want this table to exist in c code or in the device tree?

I was working on a similar feature based on the linux kernel driver for thermal-generic-adc, until I saw this PR. I've created a draft PR of my progress here: #56045
But it might be too simplistic so I'll close it if this PR gets merged.
I do wonder if the Epcos b57861s driver can't be more generic to support multiple types?

I was working on a similar feature based on the linux kernel driver for thermal-generic-adc, until I saw

Yeah, this looks to be the right way to do it.
In the DT, it you want to be overly specific, you csn have something like
compatible = "ellpcos,b57861s0103a039", "zephyr,general-adc-thermistor";

In that case, we would intentionally not have an actual binding for ellpcos,b... because we would want to to match the generic compatible.
That level of specificity probably isn't required in all cases though, so the generic compatible (and the instance-specific table) should be enough.

For devicetree.
@asemjonovs @MaureenHelm I'm assuming here that the zephyr,thermistor compatible is chosen for future extension into other types of thermistor. (Otherwise, zephyr,ntc-thermistor might be a better choice.)

You're right, I'll rename the files to reflect but I'll leave the directory as zephyr_thermistor for a future PTC thermistor driver

I believe so, for PTC I think the table still needs to be organized in decreasing resistance for the algorithm to be the same. To be honest, I went from knowing nothing about NTC thermistors a month ago to being able to write this driver. I'm still learning :-)

It might be worth renaming to avoid confusion, like zephyr,adc-thermistor instead of zephyr,ntc-thermistor.
But does would affect a lot of parts of this PR, and I'm no expert either.

It might be worth renaming to avoid confusion, like zephyr,adc-thermistor instead of zephyr,ntc-thermistor.

IMO having a more specific compatible is better. You can always use include in the bindings to share properties as needed.

Looks good, but need to address the twister fail:
INFO    - The following issues were found (showing the top 10 items):
INFO    - 1) samples/sensor/thermometer/sample.sensor.thermometer on beagleconnect_freedom error (Build failure)

@MaureenHelm
I don't think my changes affect this.  I'm able to reproduce this error on main branch as well.
../../../../../../include/zephyr/device.h:83:41: error: '__device_dts_ord_DT_N_S_sensor_switch_S_hdc2010_humidity_41_BUS_ORD' undeclared here (not in a function); did you mean 'DT_N_S_sensor_switch_S_hdc2010_humidity_41_ORD'?

Looks good, but need to address the twister fail:
INFO    - The following issues were found (showing the top 10 items):
INFO    - 1) samples/sensor/thermometer/sample.sensor.thermometer on beagleconnect_freedom error (Build failure)

@MaureenHelm
I don't think my changes affect this. I'm able to reproduce this error on main branch as well.
../../../../../../include/zephyr/device.h:83:41: error: '__device_dts_ord_DT_N_S_sensor_switch_S_hdc2010_humidity_41_BUS_ORD' undeclared here (not in a function); did you mean 'DT_N_S_sensor_switch_S_hdc2010_humidity_41_ORD'?

This has been fixed in main. Please rebase


patch release with compat bump

Codecov Report

Merging #94 (612cc71) into master (3408cd3) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   95.61%   95.43%   -0.19%
==========================================
  Files          21       21
  Lines         799      789      -10
==========================================
- Hits          764      753      -11
- Misses         35       36       +1

Impacted Files
Coverage Δ

src/mlj/interface.jl
84.90% <0.00%> (-1.89%)
:arrow_down:

src/loss-penalty/generic.jl
86.58% <0.00%> (-0.32%)
:arrow_down:

src/loss-penalty/robust.jl
100.00% <0.00%> (ø)

src/loss-penalty/standard.jl
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3408cd3...612cc71. Read the comment docs.

Codecov Report

Merging #94 (612cc71) into master (3408cd3) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   95.61%   95.43%   -0.19%
==========================================
  Files          21       21
  Lines         799      789      -10
==========================================
- Hits          764      753      -11
- Misses         35       36       +1

Impacted Files
Coverage Δ

src/mlj/interface.jl
84.90% <0.00%> (-1.89%)
:arrow_down:

src/loss-penalty/generic.jl
86.58% <0.00%> (-0.32%)
:arrow_down:

src/loss-penalty/robust.jl
100.00% <0.00%> (ø)

src/loss-penalty/standard.jl
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3408cd3...612cc71. Read the comment docs.


Optimize delegation

For _void_element we can directly use alias_method and then use __callee__.name to know which tag to generate.
This way it saves a method call, with ... delegation which isn't that fast.
Unfortunately _standard_element can't be delegated this way because of the template method. However we can enable frozen_string_literal: true in class_eval to save a string allocation per call.

Thanks @byroot! 🎉  I wonder if we should switch back to inlining the the standard_element method definitions, like it was before #37.

I dunno, it depends on how big Tag::StandardElement::ELEMENTS is. If it's really large it means a lot of identical code, so more cache misses etc.
That's why the alias_method + __calle__ combo usually gives the best result both in perf and in code size. But it's a bit more constrained.
It also depends on whether that template conflict could be resolved differently, but I don't know your gem much, I was just skimming the code and saw this.

@byroot I was able to get your technique to work with _standard_element in #52.


Broken links in docs website

After building the new docs, I found several problems:

WARNING -  Doc file 'contribute.md' contains a relative link 'CODE_OF_CONDUCT.md', but the target is not found among documentation files.
WARNING -  Doc file 'contribute.md' contains a relative link 'pyproject.toml', but the target is not found among documentation files.
the new combined 00_getting_started_flexible tutorial is not shown on the website, only the old one 00_getting_started is shown.
WARNING -  Doc file 'tutorial/01_gaussian_amortized.md' contains a relative link '00_getting_started_flexible.ipynb', but the target 'tutorial/00_getting_started_flexible.ipynb' is not found among documentation         files.

At least the new API reference looks great 🎉

fix for 3) change
https://github.com/sbi-dev/sbi/blob/a2ab10016fed6fc7b96810854c61b7de3ffc51db/docs/mkdocs.yml#L9
to link to tutorial/getting_started_flexible.md

Great use of @famura's CD changes would be to fail if a PR uses incorrect links. But let's open a new issue/PR for that to not bloat #1063 even further.

I don't know how to do this (yet). But pytest has a flag that turns warnings into errors. Maybe mkdocs has sth similar. However, there are usually a few warnings in almost every doc build that can be happily ignored :)


Cleaned up OBAApplicationDelegate + OBAStopIconFactory

Removed OBAApplicationDelegate from being handed-off to every view controller, as many didn't need it. Made OBAStopIconFactory 100% class methods since the class carried no state.

nice!


FAQ entry for how to use a custom prior

It would be great to have a short FAQ entry about how to create and pass to sbi a custom prior.
See the closed issue #581 for reference. In the FAQ one could explain the problem and the solution with a link to the tests (as linked in the issue) that show to build such a custom prior class.

great, thanks! I assigned you. Assigning yourself did not work?

Thanks! No it does not unfortunately.

@janfb made a pull request in #595 for you to review.


Enhance Lint/SelfAssignment to check attribute assignment and key assignment

This is an implementation of #12410 for Lint/SelfAssignment.
# bad
foo.bar = foo.bar
foo["bar"] = foo["bar"]

Updated.

Updated.

Separated tests.

Thanks!


Make error msg for updating resource version more clear

The error message for conflicts in the resource versions is not clear.

@smarterclayton thoughts ?

I'm a RedHat employee

LGTM

Came up in usability from a wide range of operators - this is the most common cause of update failures on pods and nodes, so it's important to communicate clearly why the error failed.

@lavalamp how about:
the resource version has been incremented to %v since you read it; re-read it and try your change again


docs: Update docs and examples

Closes #2

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines          37     37
  Branches       11     11
=====================================
  Hits           37     37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a8c58...54b757b. Read the comment docs.


Circleci project setup

Summary of changes

Closes
Pull Request Checklist

[ ] Changes have tests
[ ] News fragment added in changelog.d/.
(See documentation for details)

Hi @samkenxADO thank you very much for your PR!
Would it be possible to provide a bit more of context regarding the motivation for this change?
(Sorry, I am having some trouble on how to interpret the idea of your PR 😅)

I did a little investigation and it seems that similar PRs were open under other open source projects, without a clear description.
For the sake of security, the best course of action here would be closing this PR, since it tries to run an arbitrary container (in a CI system that setuptools does not use), and that might be dangerous.
If my interpretation is wrong here, please let me know by providing a description with the use case motivating change and an overall rationale.


Bluetooth: Audio: Add helpers for broadcast name

Added helper functions to set and get broadcast name for codec capabilities and codec configs.
Fixes https://github.com/zephyrproject-rtos/zephyr/issues/68596

Looking for some Bluetooth Audio experts to review this PR before approving it.
cc @Emil-Gydesen-Bose @fredrikdanebjer


Add ability to take/drop "n" or "*" items and add C::ALL_COMMAND

The following should be valid:

drop 5 sticks
drop * sticks
drop all sticks
... into chest
... onto table

drop * and drop all should be not implemented; a player should not be able to accidentally empty their inventory.

Backend partially implemented with 9ea01f1.

Dropping n items implemented with e5bea35.

Placing n or all items into a chest implemented with e5bea35.

Improvements in 703216a.

Fully implemented with 1f99b93.


change background-color to background

This will allow css overrides to include gradients, etc

Fixed in v1.0.0-beta.20


Fix progress flashing in setprogress:animated:YES.

fixes #6: progress flashing in setprogress:animated:YES.
Animation did reset on to initial value on finish and created a blink.
See the discussion about this:
http://stackoverflow.com/questions/6059054/cabasicanimation-resets-to-initial-value-after-animation-completes

Thanks!


JMutRepair tested and revised

JMutRepair tested against the ground-truth tests and also on android-async-http. Some parts of the implementation are revised.

Hi @khaes-kth
Thanks, ready to merge?

Hi @martinezmatias ,
Do you know how I can avoid that all the commits that have been merged before be repeated in every new PR that I create? For example, this PR is only based on the last three commits listed here but as you can see the list contains 45 commits (the number of changed files is mentioned correctly, though).
(BTW, I think this PR is ready to be merged)

Hi @khaes-kth

(BTW, I think this PR is ready to be merged)

Thanks. BTW, one new feature you can use is "Draft" pull request:
https://github.blog/2019-02-14-introducing-draft-pull-requests/
Thus, that allows to only merge when the PR is ready (not draft)

Do you know how I can avoid that all the commits that have been merged before be repeated in every new PR that I create? For example, this PR is only based on the last three commits listed here but as you can see the list contains 45 commits (the number of changed files is mentioned correctly, though).

It seems that your folk has not the latest version from the upstream (which should be SpoonLabs/Coming):
The master branch of your folk is This branch is 42 commits ahead, 1 commit behind SpoonLabs:master.  I imagine that those 42 commits you are ahead correspond to those from PR https://github.com/SpoonLabs/coming/pull/190, and since the merge of that PR, integrated in the master in the commit (this one) you are behind.
Thus, when you branched from that master and added 3 more commits, it has in total 45 commits.

To continue the previous comment:
Which maybe you missed after the PR was merged was:

To do git pull upstream master (supposing that you have upstream pointing to SpoonLabs/Coming)

To update your master (i.e., in the folk) git push origin master

It seems that your folk has not the latest version from the upstream

You were right @martinezmatias . It's fixed now. Thanks a lot.

BTW, one new feature you can use is "Draft" pull request

Yeah. I used it once before. I'll use it more often.
A problem that I have now is that I cannot run all the tests on my PC (windows) so I have to create a pull request to make sure that all the tests are passed (I know this is the worst option to do this :-) ) That's because one of the libraries used in Coming creates a temporary file with a name that includes "->" character and cannot be saved on windows. I'll fix it in the problem in the library soon.

Hi @khaes-kth

That's because one of the libraries used in Coming creates a temporary file with a name that includes "->" character and cannot be saved on windows.

Could you create an Issue describing that problem? Which is the library you found the problem?
Regards
Matias


jest-puppeteer.config.js ignores headless settings in launch section

I would like to deactivate headless but my config is ignored.
jest-puppeteer.config.js:
module.exports = {
  launch: {
    //dumpio: true,
    headless: false, //process.env.HEADLESS !== 'false',
    devtools: true
  }
};

Directory structure:
/application

package.json
jest-puppeteer.config.js
.babelrc
/src

tests

registration.js

package.json:
{
  "name": "tests",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "dependencies": {
    "babel-core": "^6.26.0",
    "babel-jest": "^22.4.3",
    "babel-preset-env": "^1.6.1",
    "jest": "^22.4.3",
    "jest-puppeteer": "^2.4.0",
    "puppeteer": "^1.3.0"
  },
  "scripts": {
    "start": "jest",
    "test": "jest"
  },
  "jest": {
    "preset": "jest-puppeteer"
  }
}

jest-puppeteer.config.js must be at the root of your project, you can also set a custom path using an environment variable. https://github.com/smooth-code/jest-puppeteer/blob/master/packages/jest-environment-puppeteer/src/readConfig.js#L25-L27

Thank You :-) same result with - also tried with a absolute path:
JEST_PUPPETEER_CONFIG=jest-puppeteer.config.js yarn start
How can I debug this problem?

I did a check with this config:
´´´javascript
module.exports = {
server: {
command: 'touch /tmp/test.txt'
},
launch: {
headless: false,
devtools: false

}
};
the config is included and the command is executed  - @neoziro what makes it ignore the headless settings?

I found the problem - running jest in the VS CODE terminal window will block showing the browser window. To be clear - all test are done fine but you will never see any browser window.
Running the same setup in a normal terminal will show the browser window.

jest-puppeteer.config.js must be at the root of your project, you can also set a custom path using an environment variable. https://github.com/smooth-code/jest-puppeteer/blob/master/packages/jest-environment-puppeteer/src/readConfig.js#L25-L27

@neoziro
it also looks like jest-puppeteer.config.js will used only if you run "jest" in the homepage of the testsuite,
but if you have a test, e.g. homepage.test.js in a test folder, e.g. test/homepage.test.js , and you run jest homepage.test.js (inside the test folder), jest-puppeteer.config.js will not be used.
i'm right?
thanks.