Github Actions build failure after enabling gisqus support

Checklist

[x] I have read the tutorials and know the correct effect of the functional design.
[x] There are no similar reports on existing issues (including closed ones).
[x] I found the bug on the latest code of the master branch.

Describe the bug
Build fails after enabling gisqus with comments/gisqus.html not found error
To Reproduce
Steps to reproduce the behavior:

Check for eligibility for gisqus integration and configured the same from https://giscus.app
Configured the giscus repo, repoId, category & categoryId from _config.yml
Push changes to branch
See error in Github actions
Checked jekyll-theme-chirpy-5.1.0 package and it has the comments/gisqus.html
Works fine after reverting to disqus

Configuration file: /home/runner/work/allenphilip93.github.io/allenphilip93.github.io/_config.yml
 Theme Config file: /home/runner/work/allenphilip93.github.io/allenphilip93.github.io/vendor/bundle/ruby/2.7.0/gems/jekyll-theme-chirpy-[5](https://github.com/allenphilip93/allenphilip93.github.io/runs/5845078697?check_suite_focus=true#step:4:5).1.0/_config.yml
            Source: /home/runner/work/allenphilip93.github.io/allenphilip93.github.io
       Destination: /home/runner/work/allenphilip93.github.io/allenphilip93.github.io/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
  Liquid Exception: Could not locate the included file 'comments/gisqus.html' in any of ["/home/runner/work/allenphilip93.github.io/allenphilip93.github.io/_includes", "/home/runner/work/allenphilip93.github.io/allenphilip93.github.io/vendor/bundle/ruby/2.[7](https://github.com/allenphilip93/allenphilip93.github.io/runs/5845078697?check_suite_focus=true#step:4:7).0/gems/jekyll-theme-chirpy-5.1.0/_includes"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outside your site source. in /home/runner/work/allenphilip[9](https://github.com/allenphilip93/allenphilip93.github.io/runs/5845078697?check_suite_focus=true#step:4:9)3.github.io/allenphilip93.github.io/vendor/bundle/ruby/2.7.0/gems/jekyll-theme-chirpy-5.1.0/_layouts/page.html
                    ------------------------------------------------
      Jekyll 4.2.2   Please append `--trace` to the `build` command
                     for any additional information or backtrace.
                    ------------------------------------------------
/home/runner/work/allenphilip93.github.io/allenphilip93.github.io/vendor/bundle/ruby/2.7.0/gems/jekyll-4.2.2/lib/jekyll/tags/include.rb:219:in `locate_include_file': Could not locate the included file 'comments/gisqus.html' in any of ["/home/runner/work/allenphilip93.github.io/allenphilip93.github.io/_includes", "/home/runner/work/allenphilip93.github.io/allenphilip93.github.io/vendor/bundle/ruby/2.7.0/gems/jekyll-theme-chirpy-5.1.0/_includes"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outside your site source. (IOError)

Expected behavior
No error
Screenshots

Environment
Repo: https://github.com/allenphilip93/allenphilip93.github.io

Command
Version

ruby -v

gem -v

bundle -v

bundle exec jekyll -v
4.2.2

bundle info jekyll-theme-chirpy
5.1.0

Desktop

Smartphone

Additional context

Not gisqus, it is giscus. Please check it.


Board.IsWhiteToMove is the opposite

When testing, after white has just played, Board.IsWhiteToMove says it's white's turn. Vice-versa for black

If this is a misunderstanding on how this variable works, please let me know!

This was a mistake, I was wrong


Test for WCAG technique SCR31: Using script to change the background color or border of the element with focus

Fixed Tickets #115

After many months of refactoring, we've finally got a system that can test this! Running this test in Chrome
_BROWSER=Chrome node ./test/assessmentSpecs/testRunner.js -I scriptOnFocusChangeBackgroundOrBorder

Merged in https://github.com/quailjs/quail/pull/325


Add support to migrate from gogs

followup of  #7181

f8635eb is a refactor and can be moved into next pull if it makes this pull hard to review or block it ...

f8635eb is a refactor and can be moved into next pull if it makes this pull hard to review or block it ...

After waiting for a year and a half, our gogs still haven't migrated to gitea. Is there any hope this time?

After waiting for a year and a half, our gogs still haven't migrated to gitea. Is there any hope this time?

@Cat7373 well gogs migration only support: Issues, Labels, Milestone, Code ... (because of non existing APIs)
If you need more you have to look into custom migration tools/scripts (link1, link2)

@Cat7373 well gogs migration only support: Issues, Labels, Milestone, Code ... (because of non existing APIs)
If you need more you have to look into custom migration tools/scripts (link1, link2)

Codecov Report

Merging #14342 (41be205) into master (bfd0c47) will decrease coverage by 0.07%.
The diff coverage is 14.18%.

@@            Coverage Diff             @@
##           master   #14342      +/-   ##
==========================================
- Coverage   41.86%   41.79%   -0.08%
==========================================
  Files         744      747       +3
  Lines       79638    79871     +233
==========================================
+ Hits        33342    33379      +37
- Misses      40808    41002     +194
- Partials     5488     5490       +2

Impacted Files
Coverage Δ

modules/migrations/base/error.go
0.00% <0.00%> (ø)

modules/migrations/error.go
100.00% <ø> (ø)

modules/migrations/git.go
91.66% <ø> (+45.23%)
:arrow_up:

modules/migrations/gitea_downloader.go
0.91% <ø> (ø)

modules/migrations/github.go
80.39% <ø> (ø)

modules/migrations/gitlab.go
0.98% <ø> (ø)

modules/migrations/migrate.go
29.05% <0.00%> (-3.48%)
:arrow_down:

modules/migrations/restore.go
0.00% <ø> (ø)

modules/structs/repo.go
70.00% <ø> (+10.00%)
:arrow_up:

modules/migrations/gogs.go
2.83% <2.83%> (ø)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db4733...41be205. Read the comment docs.

Codecov Report

Merging #14342 (41be205) into master (bfd0c47) will decrease coverage by 0.07%.
The diff coverage is 14.18%.

@@            Coverage Diff             @@
##           master   #14342      +/-   ##
==========================================
- Coverage   41.86%   41.79%   -0.08%
==========================================
  Files         744      747       +3
  Lines       79638    79871     +233
==========================================
+ Hits        33342    33379      +37
- Misses      40808    41002     +194
- Partials     5488     5490       +2

Impacted Files
Coverage Δ

modules/migrations/base/error.go
0.00% <0.00%> (ø)

modules/migrations/error.go
100.00% <ø> (ø)

modules/migrations/git.go
91.66% <ø> (+45.23%)
:arrow_up:

modules/migrations/gitea_downloader.go
0.91% <ø> (ø)

modules/migrations/github.go
80.39% <ø> (ø)

modules/migrations/gitlab.go
0.98% <ø> (ø)

modules/migrations/migrate.go
29.05% <0.00%> (-3.48%)
:arrow_down:

modules/migrations/restore.go
0.00% <ø> (ø)

modules/structs/repo.go
70.00% <ø> (+10.00%)
:arrow_up:

modules/migrations/gogs.go
2.83% <2.83%> (ø)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db4733...41be205. Read the comment docs.

closed issue migration blocked by https://github.com/gogs/go-gogs-client/pull/122

closed issue migration blocked by https://github.com/gogs/go-gogs-client/pull/122

and it final can migrate closed issues too ...

and it final can migrate closed issues too ...

OK 2 thoughts:

Without PR migration this is somewhat limited - Gogs users will immediately complain about this lack.
We're adding a load of gogs specific code here - are we happy with the safety of this library? We should look carefully at this.

It may be that we should add a build tag to build this in or not.

OK 2 thoughts:

Without PR migration this is somewhat limited - Gogs users will immediately complain about this lack.
We're adding a load of gogs specific code here - are we happy with the safety of this library? We should look carefully at this.

It may be that we should add a build tag to build this in or not.

OK 2 thoughts:
1. Without PR migration this is somewhat limited - Gogs users will immediately complain about this lack.

2. We're adding a load of gogs specific code here - are we happy with the safety of this library? We should look carefully at this.

It may be that we should add a build tag to build this in or not.

We do not have mouch of a chance since ther is no api, and so gogs user should complain on the gogs issue tracker about it .... this could potentialy create one issue here too but i cam live with it ... (and i have a follow up pull with an hack to somehow get some more bits ;) )
This is the same code as our go-sdk just not that enhanced & maintained ... if there are more concerns I'll create a fork specific for our migrator ... and strip down functions ...

OK 2 thoughts:
1. Without PR migration this is somewhat limited - Gogs users will immediately complain about this lack.

2. We're adding a load of gogs specific code here - are we happy with the safety of this library? We should look carefully at this.

It may be that we should add a build tag to build this in or not.

We do not have mouch of a chance since ther is no api, and so gogs user should complain on the gogs issue tracker about it .... this could potentialy create one issue here too but i cam live with it ... (and i have a follow up pull with an hack to somehow get some more bits ;) )
This is the same code as our go-sdk just not that enhanced & maintained ... if there are more concerns I'll create a fork specific for our migrator ... and strip down functions ...


add test: render 3D array

good job！

I don't think this adds anything in terms of test-coverage?
There are already tests demonstrating updates of child nodes, and there's no difference between rendering something 2 or 3 or 1000 levels deep.

The nesting of arrays is very special. The previous implementation does not support the nesting of arrays. Now it works well and should also add the test cases.
However, we have to admit that the new implementation performance has lost, but it may be optimized.

I modified it, and now the array will generate a flattened array in the H function phase.
{Array(2).fill().map((x, i) =>
      Array(2).fill().map((z, j) => (

            {i},{j}

        )
    )
  )}

It will be equal to
{Array(2).fill().map((x, i) =>

            {i}

    )
  )}

This seems to be the normal way. It can reduce the hydration of vdom tree. The disadvantage is that they cannot have the same key.

now the array will generate a flattened array in the H function phase

Yeah, that makes more sense to me. 🙂👍

The disadvantage is that they cannot have the same key.

That's also the advantage - if you're building a set of keyed nodes from multiple function-calls, each returning a range of nodes, you don't need to worry about manually unwrapping and combining them into one array.
I think the support for arrays as node-values exists in other frameworks mostly as a convenience - typically, the parent node is what keys relate to; a "parent array" in the input doesn't usually have any real meaning in itself.


Remove pin on ocurrent to use latest release

OCurrent just released a new version, along with a lot of changes that were necessary for us.
This fixes #418, on top of alleviating the need to update a pin SHA every so often.

For context on solving #418, the issue was related to the new version of tls: https://github.com/mirleft/ocaml-tls/releases/tag/v0.16.0, specifically the breaking part.

Danke schön!


Remove unused custom excertion handling in all KeyVault

It feels KeyVault has a custom exception handling that is:

Incorrect Typing. Mypy yells if I improve azure-core typing (it's how I ended up here in the first place)
Useless. It's mapping to type in Azure-Core, which is already the behavior of azure-core.
Masking features. The way it was done, would prevent customers to pass error_map. I believe we wanted error_map to be accessible to customers (to be verified, I'm not sure on this point)

I remove all that code, didn't change any tests ........ and everything is green :). The file was not even plugged in the a-kv-admin package.
So either this file was indeed useless, or we miss some tests on error scenarios ;)

API change check
API changes are not detected in this pull request.

More context after discussion with @johanste :

We believe this code was to solve https://github.com/Azure/azure-sdk-for-python/issues/9690
The problem solved by this issue, has been removed by recent codegen: we don't generate custom exception anymore
You can check for instance that this link do not mention a KeyVaultErrorException anymore

@johanste @annatisch Are there any concerns from either of you about the exception handling in Key Vault? Laurent's fix looks good to me (and is tremendously appreciated) 🙂

I think all the concerns I had have been addressed.


403 error posting a checkout request

I really cannot figure out how to create a checkout request
`
try {
$sumup = new \SumUp\SumUp([
'app_id'                   =>  $app_config['app_id'],
'app_secret'               =>  $app_config['app_secret'],
'grant_type'               =>  'client_credentials',
'scopes'                   =>  ['payments', 'transactions.history', 'user.app-settings', 'user.profile_readonly'],
'use_guzzlehttp_over_curl' =>  $app_config['force_guzzle'],
]);
$accessToken = $sumup->getAccessToken();
$value = $accessToken->getValue();

$checkoutsService = $sumup->getCheckoutService();

$response = $checkoutsService->create(10, 'EUR', 'CO746453'<EMAIL_ADDRESS>'Sample one-time payment');

$checkoutId = $response->getBody()->id;
stampa_info('CHECKOUT ID: '.$checkoutId);

} catch (\SumUp\Exceptions\SumUpValidationException $e) {
die(stampa_errore('Validation error: ' . $e->getMessage() . ' - Code: '.$e->getCode()));
} catch (\SumUp\Exceptions\SumUpArgumentException $e) {
die(stampa_errore('Argument error: ' . $e->getMessage() . ' - Code: '.$e->getCode()));
}  catch (\SumUp\Exceptions\SumUpAuthenticationException $e) {
die(stampa_errore('Authentication error: ' . $e->getMessage() . ' - Code: '.$e->getCode()));
} catch (\SumUp\Exceptions\SumUpResponseException $e) {
die(stampa_errore('Response error: ' . $e->getMessage() . ' - Code: '.$e->getCode()));
} catch(\SumUp\Exceptions\SumUpSDKException $e) {
die(stampa_errore('SumUp SDK error message: ' . $e->getMessage() . ' - Code: '.$e->getCode()));
} catch(\SumUp\Exceptions\SumUpServerException $e) {
die(stampa_errore('SumUp server error message: ' . $e->getMessage() . ' - Code: '.$e->getCode()));
} catch (Exception $e){
die(stampa_errore('Si è verificato un problema: ' . $e->getMessage() . ' - Code: '.$e->getCode()));
}
`
I get a "Response error: request_not_allowed - Code: 403" exception.
I am sure that $accessToken has a value. So I cannot figure why it's not working.

Hi @rleo79,
There is nothing wrong with your code. You are missing the payments scope. You can read more about the restricted scopes here. You should write to<EMAIL_ADDRESS>to be properly onboarded for this functionality.

Hello everyone,
I got the same issue, and i have added payments scope in my code.
Please check and give me suggestion, how to fix this issue.
$sumup = new \SumUp\SumUp([
'app_id' => 'SUM_UP_APP_ID',
'app_secret' => 'SUM_UP_APP_SECRET',
'grant_type' => 'client_credentials',
'scopes' => ['payments', 'transactions.history', 'user.app-settings', 'user.profile_readonly'],
]);
$checkoutService = $sumup->getCheckoutService();
$checkoutResponse = $checkoutService->create($amount, $currency, $checkoutRef, $payToEmail);
$checkoutId = $checkoutResponse->getBody()->id;
Thanks in Advance.

you fill sumup contact form and enabling payment scope. then checkout API
works.
On Tue, Jan 4, 2022 at 11:25 AM shahsagar1998 @.***>
wrote:

Hello everyone,
I got the same issue, and i have added payments scope in my code.
Please check and give me suggestion, how to fix this issue.
$sumup = new \SumUp\SumUp([
'app_id' => 'SUM_UP_APP_ID',
'app_secret' => 'SUM_UP_APP_SECRET',
'grant_type' => 'client_credentials',
'scopes' => ['payments', 'transactions.history', 'user.app-settings',
'user.profile_readonly'],
]);
$checkoutService = $sumup->getCheckoutService();
$checkoutResponse = $checkoutService->create($amount, $currency,
$checkoutRef, $payToEmail);
$checkoutId = $checkoutResponse->getBody()->id;
Thanks in Advance.
—
Reply to this email directly, view it on GitHub
https://github.com/sumup/sumup-ecom-php-sdk/issues/19#issuecomment-1004546526,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWAIQYT6663TAUBTTROPCCDUUKDVVANCNFSM4J3BAPMQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>


[SEDONA-231] Redundant Serde Elimination

Did you read the Contributor Guide?

Yes, I have read Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?

Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-231.

What changes were proposed in this PR?
To avoid redundant serde during Spark execution, I propose the following changes:

Create a SerdeAware trait that has a single abstract method called evalWithoutSerialization. This method acts the normal eval methods except that it will not attempt to serialize its results into a Spark internal type.
Apply this trait to the null safe expression classes as well as whichever other function classes that it will work with. Implement the evalWithoutSerialization for those classes such that they do not attempt to serialize any Geometry object they return (and returning the actual Geometry object instead).
When a sedona function goes to extract the values from its input, it first checks to see if the input expression is SerdeAware. If the input expression is SerdeAware then the evalWithoutSerialization method is called and an actual Geometry object is returned, skipping the serialization and deserialization that would normally happen.

To facilitate this, some changes had to be made to a few functions. Specifically, any function that could return LinearRing objects had to be changed such that they guarantee not doing that. This allows for compliance with OGC to be maintained.
I have three points of concern, which is why I marked this PR as draft:

I'm not sure if my approach is the most succinct or performant. If there are better ways to eliminate the redundant serde then I am open to comment. I can either implement the suggestions myself or I can close this PR and would be happy to see another implementation come out.
I don't know how to test this. At one point I had print statements in the serializer (which you can see in the issue) that helped show that I had in fact eliminated the redundant serde, but I'm not sure how to write a test to automate that. Is there a way to mock the geometry serializer? Or maybe add debug logging that runs for the test but is disabled in some kind of release mode? I'm not sure what the convention is here.
By enforcing LineStrings for certain functions, I have subtly changed a public API in flink. I'm not sure if that needs to be documented and, if so, where. Spark should not be affected since the serializer already does not allow for LinearRings.

How was this patch tested?
Unit tests pass. A few in flink had to be updated since certain functions no longer return LinearRing objects.
As for ensuring the redundant serde is eliminated, please see point # 2 above.
Did this PR include necessary documentation updates?

No, see above.

@douglasdennis To check the number of serialization called in each query, you can probably consider using SparkListener. Sedona already has a test listener for RDD join (https://github.com/apache/sedona/blob/master/core/src/main/scala/org/apache/sedona/core/monitoring/Listener.scala). It will accumulate Sedona Metric (https://github.com/apache/sedona/blob/master/core/src/main/scala/org/apache/sedona/core/monitoring/Metric.scala). You can probably refactor it a bit to incorporate this test.

@Kontinuation Hi Kristin, any comments?

We can mock the static methods in GeometrySerializer and count the number of invocations. I've tried out Mockito and found it quite suitable for this case.
To verify that serialization calls were actually eliminated, we can construct a simple catalyst expression and eval it instead of running a full-fledged Spark job. We mock GeometrySerializer when evaluating the expression, then verify invocation counts after eval.
Here is an example of using org.mockito:mockito-core:5.1.1 to test the SerdeAware mechanism:
class SerdeAwareFunctionSpec extends AnyFunSpec {

  describe("SerdeAwareFunction") {
    it("should save us some serialize and deserialize cost") {
      // Mock GeometrySerializer
      val factory = new GeometryFactory
      val stubGeom = factory.createPoint(new Coordinate(1, 2))
      val mocked = mockStatic(classOf[GeometrySerializer])
      mocked.when(() => GeometrySerializer.deserialize(any(classOf[Array[Byte]]))).thenReturn(stubGeom)
      mocked.when(() => GeometrySerializer.serialize(any(classOf[Geometry]))).thenReturn(Array[Byte](1, 2, 3))

      val expr = ST_Union(Seq(
        ST_Buffer(Seq(ST_GeomFromText(Seq(Literal("POINT (1 2)"), Literal(0))), Literal(1.0))),
        ST_Point(Seq(Literal(1.0), Literal(2.0), Literal(null)))
      ))

      try {
        // Evaluate an expression
        expr.eval(null)

        // Verify number of invocations
        mocked.verify(
          () => GeometrySerializer.deserialize(any(classOf[Array[Byte]])),
          atMost(0))
        mocked.verify(
          () => GeometrySerializer.serialize(any(classOf[Geometry])),
          atMost(1))
      } finally {
        // Undo the mock
        mocked.close()
      }
    }
  }
}

This test will pass on this branch, and will fail on the master branch:
Wanted at most 0 times but was 3
org.mockito.exceptions.verification.MoreThanAllowedActualInvocations:
Wanted at most 0 times but was 3
	at org.apache.sedona.common.geometrySerde.GeometrySerializer.deserialize(GeometrySerializer.java:64)
	at org.apache.sedona.sql.functions.SerdeAwareFunctionSpec.$anonfun$new$5(SerdeAwareFunctionSpec.scala:52)
	at org.apache.sedona.sql.functions.SerdeAwareFunctionSpec.$anonfun$new$2(SerdeAwareFunctionSpec.scala:53)
...

Note that we've mocked the GeometrySerializer to give constant results, so the result of eval is incorrect. It does not matter since the purpose of this test is to collect information on the code path that actually got executed. Any stub values that make it go through should be fine.

Thank you, @Kontinuation ! I tried looking at a similar path but I wasn't sure how to get mockito to work. I'll get this added to the PR.

@Kontinuation Thank you again for the test. I wasn't able to use 5.1.1 of mockito, though. It didn't seem compatible with Java 8. I went with version 4.11.0 instead.
@jiayuasu This PR adds mockito as a testing dependency. I think this is also ready to go if everyone agrees.

@douglasdennis The Mockito dependency looks good to me. If @Kontinuation has no problem with this, I think we are good to go.

@douglasdennis The Mockito dependency looks good to me. If @Kontinuation has no problem with this, I think we are good to go.

LGTM.


Implement standard release procedure for exporters + add version cli flag

Solves #18.
Also exports version as a metric.
Commit messages should be self explanatory enough.
I've based the changes on official exporters from the prometheus org.
If you intend to merge, will be necessary to:

make an additional commit to update git, docker, quay repo urls.
Setup Quay/Docker hub accounts.
Setup CircleCI account, add Github/Quay/Docker credentials to release new versions.

Let me know if I can help any further

Hi Pedro! Your changes look good, thank you!
Unfortunately, I don't know much about this standard release procedure, and don't have time to dive into it. Are you motivated enough to take over maintenance of the exporter completely? I'm not using it myself now and don't have enough time to do it properly.

I started recently with Prometheus and been digging their exporters, mostly haproxy and memcached to see how they do it.
I will be glad to help with the exporter. :)

Great, thank you!
I've sent a pull request to update documentation: https://github.com/prometheus/docs/pull/846
If you comment there, they will know that you don't mind. :-)


nfft: init at 3.5.3

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build nfft

Result of nixpkgs-review pr 257443 run on x86_64-linux 1

1 package built:

nfft

@donovanglover Thanks for your helpful review!


Cactus won't serve files

Hi. Cactus updated itself this morning, now it seems broken.
Reports this error when trying to serve files:
Traceback (most recent call last):
File "/Users/cjjr/Applications/Cactus.app/Contents/Resources/python/run.py", line 32, in <module>
from cactus import cli
File "/Users/cjjr/Applications/Cactus.app/Contents/Resources/python/CactusSource/cactus/cli.py", line 9, in <module>
import colorama
ImportError: No module named colorama

Should say, I'm on Yosemite 10.10.5, running cactus 1.1.18 (the mac GUI, not the naked CLI).

Hi, me too. ImportError: No module named colorama.
With OSX 10.11 El Capitan

Hi, I am on Yosemite 10.10.5 and updated cactus as well and getting the "ImportError: No module named colorama.

On El Capitain, Cactus updated to 1.1.18 (436) and I had these problems. I fixed it by doing this...
$ pip install colorama
$ pip install django-markwhat

If these commands both error due to "Permission denied" just type sudo !! to tell the captain you really mean it.
And it now Cactus serves locally. There is still an issue of projects disappearing from the list, #191 mentions this.

For sake of completeness I tried @danthorpe's solution on 10.10.5 but it doesn't work :)

In case you wanna go back to previous version this link is still available: http://update.cactusformac.com/static/downloads/Cactus-1.1.15.zip

@funkyboy I went back to the previous version but now getting a CertificateError. Have you seen this before?

@mhefferon sorry no, I don't use the deploy functionality :(

I am getting the same error :(

@mhefferon @dilbertoid This is Boto failing because it is now too (?) strict on certificate checks – any bucket with a period in its name fails. Boto is the library Cactus uses to manage its communication with S3.
To solve this ,create a .boto file in your home (~) directory. It's your local Boto configuration file. It needs these two lines:
[s3]
calling_format = boto.s3.connection.OrdinaryCallingFormat

Afterwards, deployment from Cactus.app should work as expected. Hopefully, this is temporary.
Gist for reference: https://gist.github.com/L-A/480a1e8b46fdb4fd6537


HistoricalDemandData file link doesn't work

The link for the template for HistoricalDemandData import doesn't work, I'm getting a runtime error https://mbs.microsoft.com/customersource/northamerica/AX/learning/documentation/how-to-articles/365OperationsDemandForecast

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d3f17fae-150d-e5c8-77bb-f3c8e142272f
Version Independent ID: d49c5d4c-ae4d-8ad2-6e96-255cfe88f978
Content: Import historical data for demand forecasts - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/supply-chain/master-planning/import-historical-data.md
Service: dynamics-ax-applications
Product: ****
Technology: ****
GitHub Login: @roxanadiaconu
Microsoft Alias: roxanad

Hi @mparra2695. I tested the link and it is working for me. Can you please try again? Thank you!

Hi @josaw1, I apologize, the actual link that downloads the file is https://mbs.microsoft.com/Files/customer/365/BusinessEdition/HistoricalDemandData.csv does that one work for you?


KAFKA-14570: Add missing closing parenthesis symbol

KAFKA-14570 There should add missing closing parenthesis symbol for problem description.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ijuma please take a look.

@iamazy Thanks for fixing this. For small issues like this you don't need to open a Jira, you can just open a PR and put MINOR in the title, for example https://github.com/apache/kafka/commit/6b5e9e989b7a1f8c387a79dea0117e52401853e1

@iamazy Thanks for fixing this. For small issues like this you don't need to open a Jira, you can just open a PR and put MINOR in the title, for example 6b5e9e9

@mimaison Got it, Thanks you!


🐞 - Input element masked with date range mask fires InputEvent twice first time

Which package(s) are the source of the bug?
@maskito/core, @maskito/kit
Playground Link
https://stackblitz.com/edit/xd2ihb?file=index.ts&hideExplorer=1
Description
When using date range mask and typing first symbol in input - it emits InputEvent twice, check out stackblitz, type for ex. 1 in input and check console logs. I guess assigning placeholder firstly and actual 1D/MM/YYYY - DD/MM/YYYY after causing this issue. Can maskito handle this?
Maskito version
1.9.0
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

User types the first digit => 1st input event.
Maskito add placeholder => Maskito programatically update textfield' value => 2nd input event.
It is important to dispatch input-event for programatic updates of textfield (the such popular frameworks like React and Angular require it to update internal states of their components).

I did not use any framework-specific packages in my example, with plain TS and HTML it fires twice too. You can't catch keypress event, validate it and patch control with masked value?

I did not use any framework-specific packages in my example, with plain TS and HTML event fires twice too. You can't catch keypress event, validate it and patch control with masked value?

We use only beforeinput & input events for Maskito.

My mistake, I think i have idea how to remove some excess dispatchings of input-event

Thank you very much for deciding to work on this case!

@ko1ebayev
This bugfix will be released in Maskito 2.0.0 (the expected release date is the second half of January)


Replace the tree view with a tree table view

Fixes #160

Thanks - the screenshot looks much improved.


Error: Post "hponeview/rest/login-sessions": unsupported protocol scheme ""

Hi...
I have the following beginner issue with "oneview" provider:
Terraform 1.0.11
terraform-provider-oneview_v6.3.1-13
HP OneView appliance firmware  6.30.00-0447630
test.tf
# Create terraform OneView client
provider "oneview" {
        ov_username  = "my-user"
        ov_password  = "my-pass"
        ov_endpoint  = "my-url-to-hponeview"
        ov_sslverify = "false"
        ov_domain    = "my-domain"
        ov_apiversion = 3200
        ov_ifmatch = "*"
}

data "oneview_server_hardware" "server_hardware" {
  name = "my-server-name-to-investigate"
}

output "oneview_server_hardware_value" {
  value = data.oneview_server_hardware.server_hardware.uri

results in
# terraform init
# terraform plan

Error: Post "my-url-to-hponeview/rest/login-sessions": unsupported protocol scheme ""

  on test.tf line 12, in provider "oneview":
  12: provider "oneview" {

Have I missed something ?
Regards and thanks in advance.

Solved by myself:
ov_endpoint  = "my-url-to-hponeview" has to be prefixed with http://


[d3d9] Much lower performance in Halo PC when run purely with DXVK compared to running dgVoodoo2+DXVK on the same system

Halo PC (2003) runs about ~50% slower on DXVK alone compared with using the d3d9 wrapper dgVoodoo2 to translate the game to d3d11, and then DXVK to translate that d3d11 to Vulkan. (also applies to the demo)
There must be a major bottleneck in the d3d9 code as using two wrappers and going through another API should not be faster than only one translation.
Software information
Halo PC, max settings with unlocked framerate.
Chimera mod to fix a whole bunch of game issues, this has no effect on the performance difference.
System information

GPU: AMD RX 580
Driver:Mesa/radv 20.1.2
Wine version: wine-staging 5.11
DXVK version: v1.7-2e37825

Log files
-- no log as there is nothing to log --

Still applies to c4f37d3981e027fcb8d759a92293d6ddbc80fdc3

Are you CPU-bound or GPU-bound? What settings? Apitrace?

Please provide an apitrace.

This game has issues with apitrace. It can only be traced if you use the fallback fixed function video mode, one that hides this issue somewhat, is completely broken and also one I can't even run the game in currently anyway.
I know that's extremely unhelpful but the only reliable way to reproduce this game is to run the demo version.

This is still an issue.
According to the DXVK HUD, pure DXVK does not max out the GPU.
Pure DXVK:

DXVK with dgVoodoo2 d3d9>d3d11 translation stacked on top:

Please provide an apitrace so someone actually has the ability to look into this.

As already stated apitrace does not work properly with this game.

Here is a working trace. This was made on Windows with an nvidia GPU however. Hopefully this helps.
http://vaporeon.io/hosted/halo/misc/halo_trace.7z

Game doesn't even work with dgvoodoo here:

I also can't repro any performance issues. I get like 1000+ fps everywhere in this game.

Out of curiosity, can you tell me how this one performs on your end?
d3d9.zip

This build seems to perform worse than the 1.7.3 release.

As for dgvoodoo, my Halo install is using the 1.10 update with the chimera mod, I have not tried it in any other configuration.

I'll try with that mod.

This dgVoodoo.conf is also known to work.

@Vaporeon Friendly ping. Could i get you to retest this with latest dxvk? :slightly_smiling_face:

Not sure why I've pinged Vaporeon here 🤔
@Aerocatia Are you able to retest this?

Yeah I did a cheeky username switcharoo.
I will retest this very soon, I have the correct Linux setup again to do this.

I have retested this on the exact same hardware however using whatever the current Mesa on Arch is and the latest release of DXVK.
Performance is the same, wine3d is performing much faster than DXVK on this setup.
I can't get dgVoodoo to work on WINE anymore, but retesting both on Windows shows dgVoodoo is running much faster.
DXVK d3d9 seems to be held up by something.

Dang. Well thank you very much for the retest 👍

I tried the game and performance matches what I get on Windows. Both run at 800-1200 fps at 4k max settings.

So I have noticed a game setting directly related to this issue.
It is related to the setting DisableBuffering (described as "Forces a video card to render each scene - used to prevent mouse lag")
This setting is more of less free on native d3d9 drivers, however it completely murders performance on DXVK, especially on AMD.
I forgot I had this setting on when making the original report.
This may possibly be related to https://github.com/doitsujin/dxvk/issues/3906


update xml document (batch 6 "S")

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Gas linter b0rken in latest release

It seems gas no longer works, at least with the latest gometalinter release for Linux.

If I run gas ./... using the binary installed with gometalinter --install ~a while ago, it works fine~ it fails the same way, as the binary shipped with the latest release (see: below)
If I run gas ./... using the binary installed with go get -u github.com/GoASTScanner/gas/cmd/gas, it works fine
If I run gas ./... using the binary from the latest gometalinter release, I get a screenful of errors of the form

Processing "<file>"...
Error during type checking: "<file>:<line>:<col> could not import <import> (can't find import: "<import>")"

If I run gometalinter --disable-all -E gas ./... using the latest gometalinter release (regardless of whether gas comes from the gometalinter release package, or is installed using go get), there is no output at all and the exit code is 0

For information - I install the release using:
curl -sLo- https://github.com/alecthomas/gometalinter/releases/download/v2.0.5/gometalinter-2.0.5-linux-amd64.tar.gz|tar -xzC "$GOPATH/bin" --exclude COPYING --exclude README.md --strip-components 1 -f-

This is a pretty major issue IMO.
I was hoping to switch to official releases finally (after using a frozen clone of the official repo as a workaround for a few months), but when the number of warnings suddenly dropped with the new release, I looked deeper and there it is.
(one issue that might be related is #445, but I think this goes beyond that, because gas just doesn't work with gometalinter anymore, no matter how you install it)

This was tested on Linux, with go 1.8.3 and 1.10.

Can you try setting GOROOT and trying again?

GOROOT was already explicitly set.

I just tested this with go 1.8.7, 1.9.4 and 1.10.0 (both on my host system and using the official golang docker containers) - the only gas binary that works is the one installed via go get -u github.com/GoASTScanner/gas/cmd/gas. Binaries installed via gometalinter --install, or shipped with the latest gometalinter release all have the same issues - not finding imports.

To be clear, gas does work with gometalinter --install, but it appears it does not work for you for some reason. There are regression tests that verify that each linter works. These are run in CI. ie. This is not a general problem.
Are you sure that the gas being installed with --install is the one being used by gometalinter? ie. $GOPATH/bin is first in your $PATH?
eg.
[aat@cavern:~/Projects/kingpin]gometalinter --disable-all -E gas .
guesswidth_unix.go:31::warning: Use of unsafe calls should be audited,LOW,HIGH (gas)

The regression tests can be run with go test -v ./regressiontests from the root of the source.
Also try running with --debug (as the CONTRIBUTING file suggests).

To be clear, gas does work with gometalinter --install, but it appears it does not work for you for some reason. There are regression tests that verify that each linter works. These are run in CI. ie. This is not a general problem.

Well, I for one, am glad we cleared that up.

Are you sure that the gas being installed with --install is the one being used by gometalinter?

$GOPATH/bin is the first path in my $PATH and there is no executable called gas in any of the other paths.

Also try running with --debug (as the CONTRIBUTING file suggests).

Will do.
This may very well be an issue on my end, but if so, it's nothing obvious. If I get to the bottom of it, I'll post an update. Feel free to resolve this, if you like.

I'd be very interested in finding out what the problem is if you get to the bottom of it, thanks.

I just saw this happen today.


Prepare for the bors.

bors try

bors r+

bors try

bors r+

bors r+

bors r+

Will test it on my own repo first.


Different stderr output in stable and nightly rust

TIL about Attribute::parse_args method and make usage of it in my crate. However, CI failed on beta and stable. Meanwhile nightly build is fine.
Look the at line number (4:10 and 4:9). Expected output for trybuild was generated on rustc 1.45.0-nightly (5fd2f06e9 2020-05-31) and also matches with lastest
EXPECTED:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error: unexpected end of input, expected identifier

 --> $DIR/04-excepted-endian-identifier.rs:4:10

  |

4 | #[endian()]

  |          ^
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈

ACTUAL OUTPUT:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error: unexpected end of input, expected identifier

 --> $DIR/04-excepted-endian-identifier.rs:4:9

  |

4 | #[endian()]

  |         ^^
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈

Link to CI

In general different compilers are free to produce different diagnostics. One can generally expect compiler diagnostics to improve over time.
Usually I run trybuild tests on a single toolchain only:
https://github.com/serde-rs/json/blob/4354fc3eb2232ee0ba9a9a23acce107a980a6dc0/tests/compiletest.rs#L1-L6
It would also be reasonable for a project to keep different expected output files for different toolchains but I have not found this valuable.


Histogram matching for model-level ERA5 data

Changes
Features

Add HistogramMatching humidity scaling calibrated for model-level ERA5 data.

Creating an instance of HistogramMatching without explicitly selecting the model- or pressure-level calibration will use the pressure-level calibration by default (which preserves current behavior) but warn users that a future release will default to the model-level calibration.
Tests

[ ] QC test passes locally (make test)
[ ] CI tests pass

Reviewer

@trdean1
@mlshapiro

Looks great to me as well!


influence weighting in contextual classification

If the classification is executed using fields with a small number of words (1-3) then the weight of single words can throw off the classification by a lot. While one word might be way more significant in a big corpus this does not have to be true for a small corpus.
It would be nice if the weights applied to the classification could be influenced. To set them either uniformaly to the same value or to boost or throttle specific terms.
E.g. matching different meta fields:
{
  dataType: "string"
  variableName: "license plate"
}

We might want to throttle string since it is important but not too much so and boost plate since it might get matched with the wrong license otherwise.

I think we still need to agree on what we call the above in the API. Since it can now be both replace and boost, I think a very neutral vectorWeights might do the trick. So here's an example for a full thing object:
POST /v1/things/
Class: CarPart
schema:
  partName: "license plate holder"
vectorWeights:
  license: "12 * w - 48.22" # with w being the original weight
  plate: "7"

In case it's not obvious, in the above we would:

for license take 12 times the original weight, then substract 48.22

for plate regardless of the original weight always use 7

for holder nothing is changed, would be exactly as before

Everyone happy with the API?

Everyone happy with vectorWeights? Alternative Ideas?

I am happy with this. For completeness would a later post with:
Class: CarPart
schema:
  partName: "license plate holder"
vectorWeights:
  license: "w"
  plate: "w"

reset the weights to the original value or will it keep the weights set before?

Yes, also just removing the vectorWeights object alltogether should do the trick. The planned process is on every vectorization (which happens on create or update) ask the contextionary for the original weights first, then apply the modification as outlined.

All good from my side, we will determine the documentation based on the release docs.

Awesome, thanks both. Closing this API Design issue, the implementation is happening in #1074.


Remove Unused Import and disable no-unused-vars for corePlugin

This pull request implements the following changes:

Removed unused import: The isNumber import from the utils module has been removed, as it was not being utilized in the code, thereby improving clarity and maintainability.

Disabled no-unused-vars rule: The ESLint rule no-unused-vars has been disabled for the variable corePlugin in the loader tests. This change helps avoid unnecessary warnings during development, considering that the variable may be used in ways not detected by ESLint.

These changes aim to enhance code prettier and adjustment unnecessary eslint in test file escope .
Commits

Disable no-unused-vars in corePlugin
Remove unused isNumber import from utils

@jhonatangcavalcanti pode dar uma olhada nesse pull request e verificar se está tudo certo ou se há algo que precisa ser ajustado para dar continuidade? Fiz algumas alterações, como a remoção do import não utilizado do isNumber e a desativação da regra no-unused-vars no teste do corePlugin. Essas mudanças foram feitas para melhorar a clareza do código e evitar warnings desnecessários durante o desenvolvimento.

Hi @lucasferreiralimax!
After rebasing with the main branch, I noticed that the issues you mentioned in your request have already been resolved.
Anyway, thank you very much for your contribution ❤


[Doc Improvement][Update anonymous user know issues]

Removed ide panel tabs and content bubbles aren't available for anonymous users.
Updated Channel meeting isn't supported for anonymous users.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/build-apps-for-anonymous-user.md
92
10
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


[Bug] realtimesort bar always move label although their order is  not changed

Version
5.3
Link to Minimal Reproduction
No response
Steps to Reproduce
https://user-images.githubusercontent.com/3700498/156586562-1b9fb695-a1f9-4ff2-9e8a-1505b816cdbb.mp4
Current Behavior
label always move even not change order
Expected Behavior
do not move if orders not changed
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

not sure if this issue is related to current: https://github.com/apache/echarts/pull/13817
but I use the latest vue echarts version and still has problem

The video seems to be broken

The video seems to be broken

please download to play this video, I don't know why it's not works in page

@coader Do you mind providing a reproducible demo?


[FEATURE] Add more ways to customize stateful testing

Is your feature request related to a problem? Please describe.
The current implementation of stateful testing via state machines always adds a random data source, but it may not be desired.
Describe the solution you'd like
Extend the as_state_machine() method so the end-user can disable the random data source at all.
Additional context
Comes from a gitter thread.

I would like to customize stateful testing to only report 500 errors, and focus on specific endpoints ^/weekly-supply. Is this possible?
What I tried:
To focus on ^/weekly-supply, I switched from TestAPI = APIWorkflow.TestCase to
@pytest.fixture
def state_machine():
    return schema.as_state_machine()

@schema.parametrize(endpoint="^/weekly-supply")
@settings(deadline=2000, max_examples=10)
def test_statefully(state_machine):
    run_state_machine_as_test(
        state_machine,
    )

which ran but did not lead to more focused testing in schemathesis < 3.7.0.
With schemathesis 3.7.0, I get
E           InvalidSchema: test_statefully() got an unexpected keyword argument 'case', from `case=get_case_strategy(operation=APIOperation(path='/weekly-supply', method='put', schema=OpenApi30 for Foo Scheduling Server (1.0.0), verbose_name='PUT /weekly-supply', app=None, base_url='http://<IP_ADDRESS>:8088', path_parameters=ParameterSet(items=[]), headers=ParameterSet(items=[]), cookies=ParameterSet(items=[]), query=ParameterSet(items=[]), body=PayloadAlternatives(items=[OpenAPI30Body(definition={'schema': {'type': 'object', 'additionalProperties': False, 'properties': {'week': {'type': 'string', 'pattern': '\\A2021\\-W[0-5][0-9]\\Z'}, 'material': {'type': 'array', 'items': {'type': 'object', 'additionalProperties': False, 'properties': {'id': {'type': 'integer'}, 'quantity': {'type': 'integer'}, 'company_key': {'type': 'string'}}, 'required': ['id', 'quantity']}}}, 'required': ['week', 'material']}}, media_type='application/json', required=True)]), case_cls=<class 'schemathesis.models.Case'>), hooks=HookDispatcher(scope=<HookScope.TEST: 3>, _hooks=defaultdict(<class 'list'>, {})))` in @given

Thanks for reporting!
indeed, it should work the way you tried. I’ll check it deeper today

Btw, what Hypothesis version do you use?

I used
>>> hypothesis.__version__
'6.10.1'

Switching to
>>> hypothesis.__version__
'6.13.4'

did not help.

Here are some corrections to your example above:
@pytest.fixture
def state_machine():
    return schema.clone(endpoint="^/weekly-supply").as_state_machine()

def test_statefully(state_machine):
    run_state_machine_as_test(
        state_machine,
        settings(deadline=2000, max_examples=10),
    )

I would like to customize stateful testing to only report 500 errors, and focus on specific endpoints ^/weekly-supply. Is this possible?

Sure :)
... # other imports are edited for brevity
from schemathesis.checks import not_a_server_error

@pytest.fixture
def state_machine():

    class APIWorkflow(schema.clone(endpoint="^/weekly-supply").as_state_machine()):
        def validate_response(self, response, case):
            case.validate_response(response, checks=(not_a_server_error,))

    return APIWorkflow

def test_statefully(state_machine):
    run_state_machine_as_test(
        state_machine,
        settings(deadline=2000, max_examples=10),
    )

Let me know if it solves your case :)

Yes it did, thank you very much.

Very helpfull example.

@juk80x
Could you, please, elaborate on what kind of benefits you have in mind?
I am going to close this issue as the original problem was addressed in #1669 (which I think makes a lot of sense to have)


[stable/kube-downscaler] Enable the addition of pod annotations

Description
Allow the user to add pod annotations as per the incubator/kube-downscaler chart
Checklist

[x] Title of the PR starts with chart name (e.g. [stable/mychartname])
[ ] I have read the contribution instructions, bumped chart version and regenerated the docs
[ ] Github actions are passing

@doncraig please review the second checkbox 🙂

@max-rocket-internet I'm confused as to why this is failing. I did regenerate the docs and stable/kube-downscaler/README.md is included in the PR

@doncraig

I'm confused as to why this is failing.

I think you didn't commit all the changes after running the command? For example, the chart version is not updated in the README. Check this PR for example: https://github.com/deliveryhero/helm-charts/pull/204/files#diff-5fc4e99aeb536607a094704cacc7a1ac1b2c4c02d073fc6ad2e23b976da7406e

I'll close this but feel free to reopen when you're ready to work on it again.


Correct attribution?

Hello @c-h-david - sorry to tag you on a project you probably know nothing about.
We recently updated our code of conduct available here to include some elements that a colleague of ours heard you present in a meeting.
I have tried to acknowledge your contribution here.
Two question:

is it ok for us to use this formulation from you?
is the acknowledgment enough?

Thanks a lot!

@fmaussion, this message made my day! I think you might be the first group to actually include this in your repo. I'm glad you found this concept helpful. It's still very much a nascent idea that could benefit from more community input and brainstorming. The fact that you saw some value in this reassures me that perhaps we're onto something haha.
We have two existing GitHub issues on this topic as part of ongoing NASA efforts:
https://github.com/NASA-AMMOS/slim/issues/173
https://github.com/nasa/Transform-to-Open-Science/issues/894
I appreciate your effort to reference our work on this! Perhaps link to these issues to help spread the word? I don't know if my presentation on the topic was ever made publicly available. Also, w'd welcome your input on either of the above issues!


Allow to use comments for json and json-ld

Currently comments work for javascript, but not for json and json-ld.
I understand that in many implementations of json comments aren't allowed, but because it is opt-in (disabled by default in codemirror) then it should be assumed that we know what we are doing by enabling it:
    continueComments: "Enter",
    extraKeys: {"Ctrl-Q": "toggleComment"}

Comments aren't opt-in in JSON, they simply don't exist, as far as I'm aware, and as such would be a bit of a strange thing to support in a language mode.

This is one of implementations of json with comments: jsonc
https://stackoverflow.com/a/55708553/8896457


Map Updates 🗺

Map Updates 🗺
This pull request adds the latest https://reemr.se/shoreline/ shoreline map to the site (3D)
resolves: https://github.com/the-hideout/tarkov-dev/issues/152

This PR also updates the main readme

.deploy to development

.deploy


Infinity Scans not loading

Source information
InfinityScans 1.4.4
Source language
English
Steps to reproduce
Click browse or latest for the source
Expected behavior
It shows all the series the source has
Actual behavior
Blank screen that's loading
Mihon/Tachiyomi version
0.16.5
Android version
Android 13
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Closing in favor of #5561


Cannot redeclare let variable in Safari

After upgrading to babili 0.1.2 following error appears in Safari 10.1 (running ES6 native): SyntaxError: Cannot declare a let variable twice: 'e'.. It happens on fragments like this (after minify I have a lot of this):
function a(e) {
  let e = 1;
  console.log(e);
}
a(2);

// Real life minify result:

  function Ge(e, t) {
    const n = e.toLowerCase(),
          a = n.split(/\s+/),
          r = [];

    for (let e = 0, n = 0; n < t && e < a.length; n += a[e].length, e++) r.push(a[e].split('').map((e) => e.normalize('NFKD').charAt(0)).filter((e) => /[A-z]/.test(e)).join(''));
    return r.join('-');
  }

and it seems for me that Safari counts function parameters as declared by let. Neither Chrome, Firefox or Edge have such problem. Is there any workaround apart of switching off minify (as I'm forced to do now)?

Thanks. This looks like is a bug. It shouldn't be reused with fn param in the same scope.
Can you give the source code that produces this output ?
I'm not able to reproduce with a simple function.
function foo(bar) {
  let baz = 1;
  console.log(bar, baz);
}

gives
function foo(a) {
  let b = 1;
  console.log(b);
}

The source code is huge (I pass babili over rollup bundle with mixed es6 / es3 content), and it produces a lot of that results, but all times with e letter, not sure if it make sense.
Config is below:
 // we will pass bundled file via babili
          ({ code, map } = transform(code, {
            babelrc: false,
            sourceMaps: true,
            presets: [
              [
  'env',
  {
    targets: {
      safari: '10.1',
      firefox: 53,
      chrome: 57,
      edge: 15,
    },
    modules: false,
    loose: true,
    useBuiltIns: true,
    preferBuiltins: true,
    debug: false,
  },
],
              [
                'babili',
                {
                  keepFnName: false,
                  keepClassName: false,
                  removeConsole: true,
                  removeDebugger: true,
                },
              ],
            ],
            compact: true,
            minified: true,
            comments: false,
            plugins: [
              [
                'transform-define',
                {
                  'tino.env': 'production',
                  'tino.es6': true,
                  'typeof window': 'object',
                },
              ],
            ],
          }));

the first function is just an example, the second function is output of this:
function createStub(str, maxLen) {
  const lc = str.toLowerCase();
  const stubsArray = lc.split(/\s+/);
  const res = [];
  for (
    let i = 0, currentLen = 0;
    currentLen < maxLen && i < stubsArray.length;
    (currentLen += stubsArray[i].length), i++
  ) {
    res.push(
      stubsArray[i]
        .split('')
        .map(a => a.normalize('NFKD').charAt(0))
        .filter(a => /[A-z]/.test(a))
        .join('')
    );
  }
  return res.join('-');
}

I think it is a safari bug.
function foo(a = 1) {
  for (let a = 2;;) {
    console.log("loop", a); // 2
    break;
  }
  console.log("fn param", a); // 1
}
foo();

is valid ES6. The let binds to the for loop and not the function. I'm really not sure how to work around this bug.

https://bugs.webkit.org/show_bug.cgi?id=171041

Nobody will write such code in real life, why minify should? Just take next letter if this is used for function param already?

as per https://kangax.github.io/compat-table/es6/ Safari 10.1 is the browser with most complete ES6 support. If it has a bug, it's better to adopt for it, instead of fighting with a bleeding edge browser.

Safari's block scoping implementation is by far the buggiest. There is a lot of valid code that crashes in safari, both at parse and run time.
The only reason I haven't reported is because I haven't been able to get it to reproduce in non-proprietary code (or with bundles smaller than "entire work website codebase"), but hopefully this bug gets Safari to look better into their block scoping implementation.

FYI, https://webkit.org/blog/7622/release-notes-for-safari-technology-preview-31/ under JavaScript this bug is fixed in Safari.

@boopathi That's great, but the bug is already in several shipped versions, so, I think it must be avoided for a next couple of years... No fix?

We hit this bug at work. I've put together what I hope is a successful workaround and filed a PR: #567.


Small fix types in main.ts

Thanks for the pull request, but mainWindow is no longer a global variable in main.ts, so this is no longer necessary.


Cleanup rfam go term import

This changes much of the Rfam import process to work by querying the Rfam database, writing a file of the results and then parsing that result. This differs from the previous approach where the FTP export would be fetched and parsed. The FTP export was never saved to disk. The new import is an improvement in that we don't have to wait until another FTP export to do things like update GO terms. Additionally, it is really useful to have the source data files saved for debugging.
This does not change all parts of Rfam import, notably the sequence import is still uses the JSON files provided by Rfam. This change also effects Ensembl import as Ensembl import uses data from Rfam to determine what sequences to suppress (fragments of lncRNA's) and what the correct RNA type of a sequence is.

This appears to be functional and doesn't appear to prevent Ensembl data from being parsed.


generalized pareto

Summary
Generalizes pareto distribution related functions to accept Eigen expressions.
Tests
Tested using expression testing framework
Side Effects
None.
Release notes
Generalized pareto distribution related functions to accept Eigen expressions.
Checklist

[x] Math issue #1470

[x] Copyright holder: Tadej Ciglarič
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

Actually there are merge conflicts :(


docs(README): add CodeFund sponsor

What:

Why:
Requested by @kentcdodds

How:

Checklist:

[ ] Documentation
[ ] Tests
[ ] Ready to be merged

@all-contributors please add @jdorfman for fundingFinding

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Junit Part is hard to configure.

I have added a method to access the startup parameters.

In one of my project with achilles i need to access/set the cql port. I didn't find any easy solution to solve this problem.
@Rule
public AchillesTestResource<ManagerFactory> resource =
            AchillesTestResourceBuilder2.forJunit()
                                       .tablesToTruncate("foobar")
                                       .changeStartupParameter(c ->
                                           c.put(CASSANDRA_CQL_PORT, 9042)
                                       )
                                       .truncateAfterTest()
                                       .createAndUseKeyspace("test")
                                       .withScript("data_model.cql")
                                       .build((cluster, statementsCache) ->
                                           ManagerFactoryBuilder.builder(cluster)
                                                                    .doForceSchemaCreation(true)
                                                                    .withStatementsCache(statementsCache)
                                                                    .withDefaultKeyspaceName("test")
                                                                    .build());

A getter for the ports in info.archinnov.achilles.embedded.ServerStarter could do the trick too.

I know the random port system and i like it. Sadly i can't use it in this project.
Like i said if there was a getter for the port i could solve the problem.
You are right a Consumer is a bit weird.
What do you think about this snippet:
public AchillesTestResourceBuilder changeStartupParameter(Map<? extends String, ? extends Object> config) {
        cassandraParams.putAll(config);
        return this;
}

leads to:
@Rule
public AchillesTestResource<ManagerFactory> resource =
            AchillesTestResourceBuilder.forJunit()
                        .changeStartupParameter(Collections.singletonMap(CASSANDRA_CQL_PORT, 9042))

I have changed the method signature and name. I also added an example in java doc.

Excellent job! Thank you for your contribution


Update image_filter_test and color_filter_test.dart for Material 3

Updated unit tests for ColorFiltered and ImageFiltered to have M2 and M3 versions.
More info in #139076
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

When this landed it caused skia gold to begin reporting untriaged goldens. I went ahead and accepted them, so things should green up.
The problem I believe was the force push will cause the skia gold check to not fire correctly. Just an FYI to try avoid force pushes if you're updating goldens.

@jonahwilliams
Thanks for the update! I usually push empty commit when this happens and golden testing fails. I'll remember to avoid force push when updating Goldens.

Looks like there are more web changes. I'm unsure if these are expected: https://flutter-gold.skia.org/detail?grouping=name%3Dwidgets.image_filter_matrix_offset_m3%26source_type%3Dflutter&digest=725f13536274b8ee715e64df3f2d6ddc

Looks like there are more web changes. I'm unsure if these are expected: https://flutter-gold.skia.org/detail?grouping=name%3Dwidgets.image_filter_matrix_offset_m3%26source_type%3Dflutter&digest=725f13536274b8ee715e64df3f2d6ddc

Could it be due to different web renderer?

Should we revert this for now to unblock the tree?


Enable SA1514 rule

Change the action for SA1514 on the ruleset file to Error, and make the solution build

Hello @kblok ! Could you please review the pull request I opened and see if we can close this one by merging the PR?


Migration Angular 11

@jerome-benoit
Let me know your feedback.
Migration from Angular 9 to 11
Refactored module dependencies
Fixed errors appearing in console
Cut cross module dependencies in table action: moved them back in shared folder
Use of relative path in import of modules
-> Now the UI is much more responsive in dev, Search field is working again !!!
-> We gained also size at first load
-> We have now the size of each modules after compilation so we can enhance loading time
Still actions to do like to remove the usage of form 'disabled' in templates (issue opened already)
I'll merge tomorrow after few other tests.
Let me know.

Prod:

@jerome-benoit
Let me know your feedback.
Migration from Angular 9 to 11
Refactored module dependencies
Fixed errors appearing in console
Cut cross module dependencies in table action: moved them back in shared folder
Use of relative path in import of modules
-> Now the UI is much more responsive in dev, Search field is working again !!!
-> We gained also size at first load
-> We have now the size of each modules after compilation so we can enhance loading time
Still actions to do like to remove the usage of form 'disabled' in templates (issue opened already)
I'll merge tomorrow after few other tests.
Let me know.

Just tell me how you've made the update:

commands used;
documentation used;

Just tell me how you've made the update:

commands used;
documentation used;

I simply created an Angular 11 project (ng new) and moved the src from the old dashboard to the new one.
Material has been installed with the ng command also.

Just tell me how you've made the update:

commands used;
documentation used;

I simply created an Angular 11 project (ng new) and moved the src from the old dashboard to the new one.
Material has been installed with the ng command also.

Have a look at the official guide then: https://update.angular.io/?v=9.1-11.0 (check 'I use Angular Material').
And run the commands I've listed in the review (it's the same as in the guide but adapted to run in a project).
You probably have to add a script for the material 10 intermediate upgrade and then run again the material update to go to the 11.
You can run the upgrade commands several times, it's harmless. The order is important and you have to commit any changes made in between.
Otherwise, it looks good. The angular process is a bit trickier when you go up 2 majors release.

You can run the upgrade commands several times, it's harmless. The order is important and you have to commit any changes made in between.

I can also do it on that branch if you agree but I prefer to not be the one that knows how to make an angular major update. So it's better to document it and let other do it.

Have a look at the official guide then: https://update.angular.io/?v=9.1-11.0 (check 'I use Angular Material').
And run the commands I've listed in the review (it's the same as in the guide but adapted to run in a project).
You probably have to add a script for the material 10 intermediate upgrade and then run again the material update to go to the 11.
You can run the upgrade commands several times, it's harmless. The order is important and you have to commit any changes made in between.
Otherwise, it looks good. The angular process is a bit trickier when you go up 2 majors release.

It's not an upgrade, I created a new project from scratch and redo everything.
So after creating the Angular 11 project:

ng new ev-dashboard

I added the material components:

ng add @angular/material

Then I didn't have to take car of a migration at all :)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: LucasBrazi06:white_check_mark: jerome-benoit:x: gochaxYou have signed the CLA already but the status is still pending? Let us recheck it.


What about Error reading file, file should be a text file containing packages conda create --help for details?

What about Error reading file, file should be a text file containing packages conda create --help for details?

What should I do?

Thank you for trying out our code! I've updated the usage and environment setup instructions with additional details, hoping to improve your experience.


⚠ Bofrost.at has degraded performance

In d84c2e0, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1604 ms

Resolved: Bofrost.at performance has improved in e513a7f.


Basket Controls

Right now you rightclick to lay down your basket which is not good since you rightclick really often with an empty hand in normal gameplay. It should change to shift-rightclick, just like picking it up. Accessing it could be a custom keybind or even more cool, you look up and rightclick it. Accessing it in world would just be rightclick.

It is working as intended.
Interacting with any tile entity won't place it back down. Same with placing blocks - won't trigger the shipping basket to be placed either :)


added vps

Add vps code to develop branch

Merge vps code to develop branch.
/cc @mattcui  @jianqiu


ranges < 1

Hi,
I just wanted to try your package, but I need the ellipsis radius between 0 and 1.
Is it possible to modify it to a very low value like 0.001 for example ?
Thanks, and great work

(if I have time today, I'll try to upload a pull request)


Inconsistency of the host for the green lines

Overall the UI makes sense, but I'm confused about how the hosts are chosen.
On FireFox on Windows it might ping gstatic.com
On Brave on the same machine it chose <IP_ADDRESS> (which is the wrong subnet for the LAN) and Atlanta, US. Both show as solid red bars.
On Safari on macOS it chose a gateway IP on the correct LAN subnet
On Safari on iOS it chose the same LAN gateway IP and then Brussels, BE

I spend some time hacking on blip over the holidays and the host selection should now be much improved. Let me know if it's better for you now!


Update runtime

What

Updates lambda runtime to node 14
Updates dependencies@semantic-release/release-notes-generator    ~9.0.1  →    ~9.0.2
aws-sdk                                    ~2.858.0  →  ~2.863.0
eslint                                      ~7.21.0  →   ~7.22.0
semantic-release                            ^17.4.1  →   ^17.4.2

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Switching back and forth in WebView View with retainContextWhenHidden causes ghost renders

Issue Type: Bug
With retainContextWhenHidden=true, there appears to be a rendering issue causing ghost/overlapping renders when the webview view changes when it is hidden.
https://user-images.githubusercontent.com/7714968/102715393-2599e800-42fb-11eb-8a1a-9406415dd270.mp4
Steps to reproduce

Have an extension using webview view, and retainContextWhenHidden=true. This extension renders something that changes whenever the active editor changes.
Navigate to a file that renders something on to the webview view,
Naviagte to Explorer view, such that the folders list replaces the webview view.
Open a file from the folders list, this makes the extension to bring the webview view to focus and render something else.
However, the previous render remains ( only render, not the HTML/DOM ) and overlaps with the new render.  Resizing the view fixes this. ( See attached video )

Just to make it clear, ( I think ) this is not a DOM/ programming error - i.e. there is no duplicate HTML being rendered - the ghost render does not exist in the DOM, but it can still be seen. I've verified from the inspect tool.

This bug does not happen if the webview view never gets hidden, for example, simply changing between files from the top taps.
This issue does not  occur if retainContextWhenHidden=false.

I'll be happy to provide more details/code.

Item
Value

CPUs
Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 3448)

GPU Status
2d_canvas: unavailable_softwareflash_3d: disabled_softwareflash_stage3d: disabled_softwareflash_stage3d_baseline: disabled_softwaregpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: disabled_offprotected_video_decode: disabled_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
1, 1, 1

Memory (System)
15.52GB (7.43GB free)

Process Argv
. --no-sandbox --crash-reporter-id 26ab88de-1047-4753-becf-ad5aa2f24ccc

Screen Reader
no

VM
0%

DESKTOP_SESSION
xubuntu

XDG_CURRENT_DESKTOP
XFCE

XDG_SESSION_DESKTOP
xubuntu

XDG_SESSION_TYPE
x11

Extensions (18)

Extension
Author (truncated)
Version

better-toml
bun
0.3.2

gitignore
cod
0.6.0

vscode-eslint
dba
2.1.14

competitive-programming-helper
Div
4.5.6

prettier-vscode
esb
5.8.0

flow-for-vscode
flo
1.5.0

code-runner
for
0.11.1

shell-format
fox
7.0.1

mips
kda
0.0.6

Kotlin
mat
1.7.1

rainbow-csv
mec
1.8.0

python
ms-
2020.12.424452561

jupyter
ms-
2020.12.414227025

language-liquid
nei
0.1.1

LiveServer
rit
5.6.1

rust
rus
0.7.8

vscode-choosealicense
ult
0.4.0

clang-format
xav
1.9.0

(4 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
openlogontheside:30221877
python763:30178808
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
python504:30227505
vswsl492:30211401
wsl2prompt:30224612
pythonvsdeb440:30237827
unusedpromptcf:30224611
folderexplorercf:30224615
openfilemenucf:30224648
pythonvsded773:30236629

Duplicate of #110450

@mjbvz #110450 appears to be a bug with the positioning of the webview. This bug is about a rendering issue where the newly rendered content is painted over previous render, causing  'overlapping' appearance. I do not think this is related to positioning.

Are you sure these are the same issues?


Fluent text columns with 1-1 relationships don't save correctly

Bug report
What I did
I tried to add a text column with a 1-1 relation:
CRUD::column('user.full_name')->type('text')->label('User');
What I expected to happen
The column would display with the 'User' label.
What happened
The column displayed with the 'User.full name' label.
What I've already tried to fix it
CrudColumns@save() calls $this->crud()->hasColumnWhere('key', $key) which always returns false.
I think this is because the column key is user.full_name, however, backpack stores it as user__full_name.
"user__full_name" => array:8 [▼
    "name" => "user.full_name"
    "label" => "User.full name"
    "type" => "text"
    "key" => "user__full_name"
    "tableColumn" => false
    "orderable" => false
    "searchLogic" => false
    "priority" => 1
  ]

Backpack, Laravel, PHP, DB version
PHP VERSION:
PHP 7.2.27-6+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Feb  5 2020 16:52:29) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
with Zend OPcache v7.2.27-6+ubuntu18.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies
LARAVEL VERSION:
v7.10.3@6e927e78aafd578d59c99608e7f0e23a5f7bfc5a
BACKPACK VERSION:
4.1.2@7084182b38bff6b19624788ff143bb249ecdc758

Thank you @rmarshall9n - excellent bug report.
Indeed the problem was the one you identified. I've put together PR #2805 which fixes this, and I'll be merging and tagging it later today, so I'll close this issue.
Cheers!

Merged and tagged. A composer update backpack/crud will fix it. Thanks again!


Fixing a Rails 4.1 bug

When an unsharded model has_and_belongs_to_many another model, the join model would incorrectly be defined as sharded.
I have not written a failing test for this case, and I had to disable a test that was failing for Rails 4.2
cc @osheroff

These are the commits introducing the HABTM_ class names in Rails 4.1: https://github.com/rails/rails/compare/18ca3cbe12...d15165196c.
cc @jacobat

Cc @osheroff too

so we're already patching the spot where we're generating the HABTM class, see default_slave_patches.rb line 74.  maybe turning off sharded-ness is more elegantly done there-ish?

But we want to keep sharding enabled for HABTM relations on sharded models, right?

yeah; I'd say that when we generate the join model it should inherit the sharded-ness of the left-hand model, same as you've got here... just shove the code in a different place.

Closing in favor of #35.


[DBCP-567] Use abort rather than close to clean up abandoned connections.

[DBCP-567] Use abort rather than close to clean up abandoned
connections.
Further clean ups post merge of the main PR and secondary PR.

@rmannibucau and/or @psteitz
Please have a look.

I will update tonight unless @psteitz chimes in...

Sorry for late response.  Changes look good.  Better and safer than what I initially proposed.  Thanks.

Sorry for late response.  Changes look good.  Better and safer than what I initially proposed.  Thanks.


Allow scope() to be used for operations

I want to scope() records through hooks.  I use scopes frequently in my API to allow users with certain roles access to mutate objects.  I know I can just where={}, but scopes are way more convenient and centralized to the model.
Would be nice to:
hook => {
  hook.params.sequelize.scope = 'approved'
  return Promise.resolve(hook)
}

Right now, this setting is ignored because you have to scope records like:
Model.scope('approved').findAll()...

I can do a PR for this, just let me know!
let Model = this.Model
if (params.scope) {
  Model = this.Model.scope(params.scope)
}

@bparise - If you want to submit a PR. I will endorse it. This would be a great feature! If you don't have time I will try and squeeze it in - let me know. If you want to do it, make sure to write tests and update the docs. You go to a particular page at https://docs.feathersjs.com/, then click the "Edit this page" link in the top.

Done!  I'll update the documentation once the PR is officially accepted.

Closed via #142


Missing strans comparison function?

One of my colleagues is trying to create an index on a column operated on with a PL/pgsql function that we have that uses various pgsphere types and operators and received this error....
> create index xgeom_s_region on sometable ((xgeom_intext(s_region)))
ERROR: could not identify a comparison function for type strans

Should pgsphere provide a comparison function for strans objects? Does that even make sense?
In the meantime, if anyone has even a quick and dirty solution or advice to help my colleague get beyond this error, please reply.

@esabol I would propose to share some information about xgeom_intext function and s_region type.

I'm getting a different error here:
create table s (s strans);
create index on s(s);
ERROR:  42704: data type strans has no default operator class for access method "btree"
HINT:  You must specify an operator class for the index or define a default operator class for the data type.

Looking up strans by actual value in a btree doesn't seem to make much sense to me. Wouldn't you rather look up the transformation by some other means and then apply it?

I would propose to share some information about xgeom_intext function and s_region type.

s_region isn't a type. It's a text column in the table that contains strings like "CIRCLE('ICRS',0,0,1)".
xgeom_intext is a complicated PLpgsql function that basically takes strings like that and converts them into pgsphere objects.

What operation inside the xgeom_intext function is triggering that error?

What operation inside the xgeom_intext function is triggering that error?

Beats me.

Does select xgeom_intext(s_region) from xgeom_s_region; throw the same error, perhaps with more detail?

xgeom_s_region is the name of the index.select xgeom_intext(s_region) from sometable does not throw any errors. This error only occurs when you try to create an index on it.

esabol wrote in #101:

I wonder if the error in issue #93 would be helped if there was a hash opclass for strans?

Could be, but more likely a btree opclass since you are building a btree index.
What datatype does xgeom_intext return?

@df7cb asked:

Could be, but more likely a btree opclass since you are building a btree index.

Ah, yeah, that makes sense.

What datatype does xgeom_intext return?

A user-defined type we call "xgeom". strans is a component, but also spoint and scircle and possibly spoly (but not really in practice). It's kind of a generic spherical geometry polymorphic type.

The strans error message might go away when we implement a btree opclass, but what would strans < strans even mean? If you only want equality lookups, a hash opclass would make more sense.


Permit LGS/CUE to handle desktop lighting

Desktop lighting? what does that entail?

The desktop lighting means that brand utilities like Logitech Gaming Software or Corsair Utility Engine will be able to provide lighting effects when Aurora is on the desktop profile, allowing more customization and only provide gaming profiles.
The reason why there's no Corsair demo on http://aurora.lastbullet.net/ is because Razer and Logitech use a transparent image of a keyboard with changing colors behind them. So I could easily swap my own color effects behind the transparent keyboard images. But Corsair shows off their keyboard lighting via a gif, without transparency. So I decided not to spend time making my own transparent image, and focus on Aurora.

So has this been implemented or is this a plan to incorporate? I think this option would be FANTASTIC for my set up and only let Aurora take over for game profiles. Thanks!

@TBrozovich This is going to be a feature in the next version.

Is this feature coming soon? I love Aurora, but would really prefer to use the LGS lighting on my desktop, specifically for the star effect (unless it is already in and I am completely missing it). Keep up the great work!

See https://github.com/antonpup/Aurora/issues/241#issuecomment-265612108 https://github.com/antonpup/Aurora/issues/280#issuecomment-269521061 https://github.com/antonpup/Aurora/issues/226#issuecomment-264584363


Add NT-Destroyer Shuttle

Adds a specialized shuttle for NT Deathsquad Admeme event.
Features:

Advanced Armory with extra pulse weaponry, advanced laser pistols, liberation vendor, secfab with preloaded materials, and a security vending machine.
Medbay with full cryo, chemistry, and surgery setup. comes with extra damage kits, combat kits, and a bluespace beaker. Comes with a medfab with preloaded materials.
Engineering bay with EngiVend, Atmospheric setup, and four (4) 15kW generators.
Full Cloning setup
Lounge area with Soda and Booze dispenser, Getmore Chocolate Vendor, Microwave, and a Complimentary Pizza for joining the NT Deathsquad taskforceas as stated by contract.
Bridge comes with a IFF Console to toggle stealth capabilities, and has Nuke codes.

Images:

this looks super cool. not sure how often itll get used but it looks cool!

Should probably put a extra door between the external airlock and the weapons out in the armoury because anyone could connect to that side and get instant access to death squad weapons, apart from that it looks great

Should probably put a extra door between the external airlock and the weapons out in the armoury because anyone could connect to that side and get instant access to death squad weapons, apart from that it looks great

I tried adding blast doors on the inside of the docking hatches but whenever I load the grid the wall buttons don't seem to open them.

Please consider merging #29320 first.
(Also it would be nice to get some roles standardized by #28098 but I'm waiting on the aforementioned PR to flesh it out. 28098 has about 20 shuttles associated with it, but they got removed in an attempt to break the PR up... and then the half of the PR that was left got merged in a day by someone else, so... just please tell me what I need to do to get these damn shuttles organized in a way thats acceptable so we stop getting 3 PRs a week that exacerbate the problem and make my life worse trying to work on it.)

My apologies. I just reading comprehended and realized this is not for shuttle events, but for admin events. I also have one of these, but uh, admin upload go brrrr. I almost want to say we probably shouldn't add a deathsquad shuttle because
a) It will inspire admins to use deathsquad which we do not want.
b) It should never get enough play time to catch any issues it has

a) It will inspire admins to use deathsquad which we do not want.

I see. It doesn't have to be used by the deathsquad solely it can be used as transport for VIP CentComm personnel and have some guards as export.

The test fail seems to be real. Are you still working on this? If yes, I will bring it up for maintainer discussion.


Add BWA global Auto approach

Fixes #30002
Addresses #28161
@hishamco ... I have another 🙈 RexHacks!™ 🦖 approach here. It SEEMS to work, but IDK if there are some 🐉🐉🐉 with what I did or some lurking 😈😈😈 in here.
Because of the complexity of this, I thought you might want to pull it down and run it locally, so I placed my test app at ...
https://github.com/guardrex/BlazorCulturePerComponentInteractivity
Question 1
There is one thing here that I don't understand. When changing the culture from a CSR component (in the sample app, changing it from the CultureClient component), it does seem to update the localization cookie and carryover to the server-rendered component (in the sample app if you then navigate to the CultureServer component). It's not clear to me where/how the localization cookie is being updated when that happens. The controller action in the server app isn't called when the culture is changed client-side, and I didn't think that Localization Middleware was reading the updated value from local storage. However, it seems to work. If you can see where/how the culture is being carried over to SSR, I'll add an explanation on it to the article text.
Question 2
... and another ❓on the delta between the Chilean Spanish date format SSR vs. CSR.
SSR it's in the format ... 23-02-2024
CSR it's in the format ... 23/2/2024
Any idea on why that format is changing in an odd way? It's another odd behavioral difference that I'll explain in the article if it's known why it happens.

Internal previews

📄 File
🔗 Preview link

aspnetcore/blazor/globalization-localization.md
ASP.NET Core Blazor globalization and localization

It's a long time from doing localization in Blazor :) but seems everything LGTM

Thanks @hishamco ... and that last commit was to update the client-only section earlier in the article where it also appears.
What about my ❓ in the opening comment :point_up:? ... any ideas on what I can say about those in the article?

What about my ❓ in the opening comment ☝? ... any ideas on what I can say about those in the article?

I need to check, but how I can produce the two formats?

Run the sample app, set the culture to Chilean Spanish, and flip back and forth between the CultureClient and CultureServer components.

It can definitely wait. I wasn't going to merge it until Monday at the earliest because it needs to be edited again.

Yes! 🎉
If I switch to Mexican Spanish, I get a stable date format. I'll do that ... I'll go with Mexico 🇲🇽  for the code example. That eliminates "Question 2" from being a major concern.

Well ... I'm actually not too keen on Mexican Spanish because the number format (dot separator) is the same that we use in English ...
1999.69

Chilean Spanish uses a comma separator ...
1999,69

OK ... I have one ......
🇨🇷  Costa Rica (es-CR)
The number and date formats change, and it's stable across WASM and server rendering.
I'll go with that.

Frankly, I was busy with Orchard Core and something else in my home :)
I hope to find time this weekend, if you didn't merge this yet

@guardrex I did a quick look for what you did, I'm asking why you didn't rely on the cookie that send by ASP.NET Core, this SHOULD work correctly in both Server & Client
FYI we already did something similar long time back in Oqtane Framework

Only because traditionally we didn't take that approach for WASM (standalone or hosted). We always pushed local storage for WASM; so I just assumed that after the Blazor bundle comes down and Auto components go with CSR, they would switch over to local storage. I get the impression from you now that Auto components reaching CSR should just navigate to the server controller and then be redirected back, which is how we've always managed the cookie for Blazor Server <8.0.
I'll try again only adopting our Blazor Server approach (cookie) in a BWA, but I'm buried in call web API work right now and probably won't be able to get back to this until the middle of next week. I'll ping you back here then when I complete a new round of testing with a new test app.

I think both read from JS , right?

I think only on the client (CSR) is when the culture is read from local storage via JS interop.
I think for SSR that the Loc Middleware is reading the culture from the cookie.
When the user changes the culture from an SSR component, the local storage is updated and they're thrown to the controller to update the cookie.
The part that I'm not 100% clear on is what's happening when the culture selector is activated.
If the component (and thus culture selector) are in SSR mode, it seems like it sets the culture in local storage and redirects to the controller and back ... which is updating the cookie.
However ... For CSR with the culture selector, I have it set the new culture in local storage ... ok, that's fine ... and I still have the code there for the controller redirect. I guess that works, but I'm not sure on the mechanics of is the component being rerendered completely (on WASM) after it rendered the first time on WASM. I'm not sure if that's the correct way to go for CSR. It seems like the code should update the cookie, but perhaps it should just be calling a backend endpoint to update it without the redirect.

🤔 ... I guess that's ok for CSR ... it sets the culture into local storage and redirects (for the cookie to be set correctly) ... and then on reload after coming back it sucks the changed culture in from local storage and rerenders the component CSR.
AFAICT, this whole approach is just a bit hacky because there isn't a nice built-in way of managing things.
I guess an alternative to local storage is to deal directly with the loc cookie in JS on the client. Idk if that's any better than this current approach. It would require as much or more code than this, and it would be perhaps equally inelegant as this approach.

I'll place the bits here in one spot to make it simpler to see the overall setup ...
Server project of the BWA
Set up loc in the Program file ...
var supportedCultures = new[] { "en-US", "es-CR" };
var localizationOptions = new RequestLocalizationOptions()
    .SetDefaultCulture(supportedCultures[0])
    .AddSupportedCultures(supportedCultures)
    .AddSupportedUICultures(supportedCultures);

app.UseRequestLocalization(localizationOptions);

Controller that can set the culture to the loc cookie and redirect back ...
[Route("[controller]/[action]")]
public class CultureController : Controller
{
    public IActionResult Set(string culture, string redirectUri)
    {
        if (culture != null)
        {
            HttpContext.Response.Cookies.Append(
                CookieRequestCultureProvider.DefaultCookieName,
                CookieRequestCultureProvider.MakeCookieValue(
                    new RequestCulture(culture, culture)));
        }

        return LocalRedirect(redirectUri);
    }
}

The App component has a script to get/set the culture for local storage ...
window.blazorCulture = {
  get: () => window.localStorage['BlazorCulture'],
  set: (value) => window.localStorage['BlazorCulture'] = value
};

Client project of the BWA
In the Program file, set a default or read an existing culture and set the culture for the app running CSR ...
CultureInfo culture;
var js = host.Services.GetRequiredService<IJSRuntime>();
var result = await js.InvokeAsync<string>("blazorCulture.get");

if (result != null)
{
    culture = new CultureInfo(result);
}
else
{
    culture = new CultureInfo("en-US");
    await js.InvokeVoidAsync("blazorCulture.set", "en-US");
}

CultureInfo.DefaultThreadCurrentCulture = culture;
CultureInfo.DefaultThreadCurrentUICulture = culture;

... and here's the meat 🍖 ... the CultureSelector component that appears throughout the app via the MainLayout component and given an Interactive Auto render mode (<CultureSelector @rendermode="InteractiveAuto" />).
@using System.Globalization
@using System.Runtime.InteropServices
@inject IJSRuntime JS
@inject NavigationManager Navigation

<p>
    <label>
        Select your locale:
        <select @bind="Culture">
            @foreach (var culture in supportedCultures)
            {
                <option value="<EMAIL_ADDRESS>            }
        </select>
    </label>
</p>

@code
{
    private Dictionary<string, string> cultureDict =
        new()
        {
            { "en-US", "English (United States)" },
            { "es-CR", "Spanish (Costa Rica)" }
        };

    private CultureInfo[] supportedCultures = new[]
    {
        new CultureInfo("en-US"),
        new CultureInfo("es-CR"),
    };

    private CultureInfo Culture
    {
        get => CultureInfo.CurrentCulture;
        set
        {
            if (CultureInfo.CurrentCulture != value)
            {
                JS.InvokeVoidAsync("blazorCulture.set", value.Name);

                var uri = new Uri(Navigation.Uri)
                    .GetComponents(UriComponents.PathAndQuery, UriFormat.Unescaped);
                var cultureEscaped = Uri.EscapeDataString(value.Name);
                var uriEscaped = Uri.EscapeDataString(uri);

                Navigation.NavigateTo(
                    $"Culture/Set?culture={cultureEscaped}&redirectUri={uriEscaped}",
                    forceLoad: true);
            }
        }
    }
}

The basic idea is that regardless of rendering location, the culture is kept up-to-date in local storage, and the loc cookie is kept up-to-date via the controller. When going into CSR, local storage is read. When in SSR, the loc cookie is used. In order to avoid deltas on naming of the cultures between SSR and CSR for the dropdown list, the component uses a custom dictionary for the text displayed to the user.
AFAICT, this is how this approach should work. The only other alternatives that I could think of would be trying to deal with the loc cookie directly for CSR without a redirect, but it seems like it would be no better than this in terms of the amount of code and complexity of code (but it would potentially save the need for a redirect) ... IF it could be make to work cleanly. I tested a bit, and that approach had some 🐉 that didn't even let me get it running correctly. Another idea would be to maintain loc outside of the ASP.NET Core loc bits ... try to use some kind of service-based loc management. I didn't investigate it tho.

@hishamco ... I'm going to go ahead with this. It's fairly close to what we had here before, merging the server and client approaches in a BWA for components rendering either way, server or client. It seems stable 🤞🍀. I propose to take reader feedback on it. I'm sure if devs run into trouble that I'll receive the normal threats of 🦖 dismemberment 😨😆.

If you look closely
 HttpContext.Response.Cookies.Append(
                CookieRequestCultureProvider.DefaultCookieName,
                CookieRequestCultureProvider.MakeCookieValue(
                    new RequestCulture(culture, culture)));

you set the cookie in the server, but you are using the local storage on the client, that's why I prefer to use the cookies everywhere

Yes, but I don't understand how it would work for CSR without using JS interop to interact directly with the cookie. Even then when I tried that approach, it didn't fully work for me. I'll let Dan know that we need a PU engineer to build out the approach in a sample app for me. I'll ping you on the new issue that I open later with a cross-link to whatever they provide.

I can create a demo if you want

Yes, please do.
BTW ... I don't know why you aren't on the article with a byline ("By Hisham Bin Ateya" ... cross-linked to your blog, X account, or company), but would you like a byline on the article with a cross-link? If so, what do you want it linked to?

Let's pick up with discussion on the issue.