Network Action not being executed although App is Online

I'm newer to redux-offline, and so may be missing something, though I have implemented a standard request and network actions are not being executed, despite being online.  The following is my code alongside a screenshot of the debugging console showing online to be 'true' while retry efforts are made.  Any guidance would be appreciated!
  type: actionTypes.POST_NEW_USER_SIGNUP,
  payload: { userEmail },
  meta: {
    offline: {
      // the network action to execute:
      effect: {
        url: "https://damp-tor-16286.herokuapp.com/users/create-user",
        method: "POST",
        body: { userEmail }
      },
      // action to dispatch when effect succeeds:
      commit: {
        type: actionTypes.NEW_USER_SIGNUP_SUCEEDED,
        meta: { userEmail }
      },
      // action to dispatch if network action fails permanently:
      rollback: {
        type: actionTypes.NEW_USER_SIGNUP_FAILED,
        meta: { userEmail }
      }
    }
  }
});

Try stringifying the body of the effect.

This works for me by supplying a commit and rollback meta to the action

Thanks for the feedback!... though not yet having any luck unfortunately.  I tried stringifying the body of the effect, though this did not change things.  @jansel369 , I'm a little unsure about what you mean by 'supplying a commit and rollback meta to the action' since I believe this is what I've already done in the above code.  Would you be able to elaborate upon this?  Perhaps I am missing something?  Thanks!

Check this out https://github.com/redux-offline/redux-offline/issues/16

Ok!... So checked this out, and have tried multiple solutions related to what is presented here with regards to the middleware configuration, though still not having much luck.  Actually, I've tried now without any other middleware and I'm still getting the same result, so this makes me wonder if it is a middleware issue or something else.  Any other suggestions?  Thanks!

The other thing I can think of is that you have a javascript error in the commit reducer. This is an existing issue that has been fixed in https://github.com/redux-offline/redux-offline/pull/3

Ok!  Checked this out, though quite sure the reducer code is not the issue here.  I've tried different variations now including a variation of the one from the docs with no luck yet.  At the moment I am using React-Native 0.49, and I noticed in their docs that both the .fetch() method has been deprecated for the getConnectionInfo() method while the 'change'  event has been deprecated for the 'connectionChange' event.  I suspected earlier that these updates may have resulted in this circumstance, though upon modifying the code in detectNetwork.native.js and even replacing the NetInfo.js file with one from a previous version of RN, I didn't make progress.  Could this be related here?  Regardless, as an aside, it seems that the detectNetwork.native.js file may need to be modified in the repository to account for these NetInfo updates in the latest versions of RN.  Thanks!

Hey! The detectNetwork deprecated notices have been handled in the parallel repo. We'll be merging them soon. I'm pretty sure this is not the cause of you're problems.
Could you provide the effect's response that ends up retrying your action? The issue you're facing is caused because the effect gets a response that is not accepted by the discard.js so a retry is dispatched. Could you please debug the response of the effect and what is being received by the dicard? That would help narrow it down.

Having same problem here :(

Could you provide more details? Or a code example? We have this https://codesandbox.io/s/8xml9l1r0j you can use it to create an example

Hi guys, I met the same problem after updated from v2.0.0.

The action in output queue doesn't even get fired while the network status is offline. But after I do a hot reload(command + r on os x), the action(promise) on the queue gets sent automatically.

Confirmed that same codes work with v2.0.0 but not v2.2.1.

I am having the same issue. All my dispatched actions immediately go to outbox even though online is true. I also tried purging my redux store and my offline outbox still persists

There's not much we can do without code samples.

@wacii Thanks for the quick response.
Cos some of the codes in my project may be irrelevant so I extracted the following code snippet and hopefully this could help:
// In my comment component, the action is dispatched by clicking send comment button

this.props.dispatch({ type: Type.SEND_COMMENT, buzzId });

// In my redux-saga config file, I have the following codes:

function* sendCommentOfflineFirst(payload) {
  const { buzzId } = payload;
  const comment = yield select(getCurrentComment, buzzId);
  yield put({
      type: Type.ADD_TEXT_COMMENT,
      payload: { comment },
      meta: {
        offline: {
          effect: EffectTypes.ADD_TEXT_COMMENT_REQUEST,
          commit: { type: EffectTypes.ADD_TEXT_COMMENT_COMMIT, payload: { comment }, meta: { comment } },
          rollback: { type: EffectTypes.ADD_TEXT_COMMENT_ROLLBACK, payload: { comment }, meta: { comment } }
        }
      }
    });
  }

export function* watchSendCommentFlow() {
  yield takeEvery(Type.SEND_COMMENT, sendCommentOfflineFirst);
}

// Here are the settings on my redux-offline config file:

const reduxOfflineConfig = {
    ...defaultConfig,
    detectNetwork: (callback) => NetInfo.isConnected.addEventListener('connectionChange', (isInternetConnected) => {
        console.log('REDUX OFFLINE detectNetwork', "isInternetConnected", isInternetConnected);
        if (isInternetConnected) {
            return callback(true);
        } else {
            return callback(false);
        }
    }),
    persistOptions: {
        storage: AsyncStorage,
        debounce: 1000,
        blacklist: ['meteorReduxReducers.ready', 'meteorReduxReducers.reactNativeMeteorOfflineRecentlyAdded', 'meteorReduxReducers.isInvokeRecentlyAdded', 'navReducer'],
    },
    persistCallback: () => {
        MeteorStore.store.loaded();
    },
    effect: (effect, action) => {
        switch (effect) {
            case EffectTypes.ADD_TEXT_COMMENT_REQUEST:
                {
                    return addComment(action.payload.comment);
                    break;
                }
            }
    },
    retry: (action, retries) => action.meta.urgent ? 100 : 1000 * (retries + 1)
};

// The functions are:

const addComment = (comment, status = null) => {
  return new Promise((resolve, reject) => {
    checkIsLogined().then(
      (value) => {
        Meteor.call('addComment', comment, comment.resourceParentID, comment.message.substring(0, 20), comment.message.substring(0, 20), comment.extraContent, null, comment._id, null, status, function(err, res) {
          if (err) {
            console.log('CommentActions', 'addComment - Internet Connected err', err);
            reject(err);
          }
          else {
            console.log('CommentActions', 'addComment - Internet Connected res', res);
            resolve(res);
          }
        });
      }
    ).catch((err) => {
      console.log('User is not logined, err', err);
    });
  });
}

const checkIsLogined = () => {
  return new Promise((resolve, reject) => {
    const isLogined = MeteorStore.store.getState().meteorReduxReducers.isLogined;
    if (isLogined) {
      resolve(true);
    }
    else {
      Accounts.onLogin((data) => {
        resolve(data);
      })
      Accounts.onLoginFailure((err) => {
        if (err) reject(err);
      })
    }
  })
}

Any comments or suggestions are welcome :)

@Diwei-Chen I'm not sure how this code produces the results you suggested. While the initial request is triggered by an offline action ({ type: "...", meta: { offline: { effect: {} }), the retries are triggered by a complete retry action ({ type: 'Offline/COMPLETE_RETRY', payload: offlineAction }). Your code would need to 'listen' for both sorts of events.
That said, I'm not super familiar with redux saga, and I know others have had some difficulties integrating the two libraries.

Solved in #229


addnodes

Hello, any addnodes to connect the wallet to the network?
Ty

I just got an NPS, I'm still figuring out how to set it up.


Why does NavigationView not support menu groups without head page

Describe the bug
When adding a Menu that includes sub level menus, a page must also be provided for the Top level menu. Otherwise, the top level menu's name will not be displayed.
To Reproduce
var topLevelMenu = new NavigationMenuItem() { Name = "Top"  };
topLevelMenu .MenuItems.Add(new ...);
Expected behavior
Can add a top-level menu item that is only used to expand submenus, not for navigation.
Screenshots
No response
OS version
Win11
.NET version
.NET 8.0
WPF-UI NuGet version
3.0.4
Additional context
No response

Is it setting Content? I feel like this is a strange logic


Using localhost:5006 is not working

Same issue running though docker.

There might be more relevant info about your setup, but based on the screenshot you've included this section of the readme seems important

Since Actual doesn't know what server to use, the first thing it does is asks you for the server URL. If you are running this project, simply click "Use this domain" and it will automatically fill it in with the current domain. This works because we are serving the app and server in the same place.

@PartyLich - I've just tried to spin up a server and have been met with the same issue and same log lines that were in the first screenshot. I've tried using a few variations of the URL including http://localhost:5006 as well as the server's IP address.
If I use localhost as previously mentioned, that page reports back with an "unable to find server". But if I use the server's IP address (which is what is filled out when clicking "Use this domain"), the OK button just turns into a forever spinning loading button and never progresses. There's no notable errors in either the browser console or the server's logs other than what's already been shared. Happy to provide any additional information that might help with debugging.

As a quick follow up, I spun up a Docker container on my localhost to see if I could replicate this same bug (previously was hosting on a kubernetes cluster). Experienced the same behavior as before. I've included the full logs from the start of the container up to and including the request that seems to be stalling or erroring.
https://gist.github.com/gradiuscypher/33962aeada25261781b8eb11a21ae953

I'll have another look and see if I can garner some insight as soon as time allows. At the moment I can't reproduce the problem.

Not a problem, I'll see if I can take a look at the code sometime in the next few days and potentially narrow down what might be going on. I'm less experienced with JS, so I'm not overly confident in my abilities, but I'm willing to give it a shot :)

This is caused by the change to util/error-middleware.js in this commit
See https://expressjs.com/en/api.html

Error-handling middleware always takes four arguments. You must provide four arguments to identify it as an error-handling middleware function. Even if you don’t need to use the next object, you must specify it to maintain the signature. Otherwise, the next object will be interpreted as regular middleware and will fail to handle errors.


fail to install brew on Debian 8

Dependencies installed.
`$ ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Linuxbrew/linuxbrew/go/install)"`
==> This script will install:
/home/rahn/.linuxbrew/bin/brew
/home/rahn/.linuxbrew/Library/...
/home/rahn/.linuxbrew/share/man/man1/brew.1

Press RETURN to continue or any other key to abort
==> Downloading and installing Homebrew...
git-remote-https: symbol lookup error: /usr/lib/x86_64-linux-gnu/libhogweed.so.2: undefined symbol: __gmpn_cnd_add_n
Failed during: git fetch origin master:refs/remotes/origin/master -n

`$ ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Linuxbrew/linuxbrew/go/install)"`
It appears Homebrew is already installed. If your intent is to reinstall you
should do the following before running this installer again:
    rm -rf /home/rahn/.linuxbrew/Cellar /home/rahn/.linuxbrew/.git && brew cleanup

`$ brew`
bash: brew: command not found

Debian 8.4 on Parallels Desktop 11 of MacBook Pro (Retina, late 2013)

This appears to be a bug in your installation of Debian. See for example http://ubuntuforums.org/showthread.php?t=2258760
Please report:
which -a which git-remote-https
ldd `which git-remote-https`
ldd /usr/lib/x86_64-linux-gnu/libhogweed.so.2

Yep, something wrong with my git. After fixing the bug:
$ ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Linuxbrew/linuxbrew/go/install)"
==> This script will install:
/home/rahn/.linuxbrew/bin/brew
/home/rahn/.linuxbrew/Library/...
/home/rahn/.linuxbrew/share/man/man1/brew.1
Press RETURN to continue or any other key to abort
==> Downloading and installing Homebrew...
remote: Counting objects: 353111, done.
remote: Total 353111 (delta 1), reused 1 (delta 1), pack-reused 353109
Receiving objects: 100% (353111/353111), 68.22 MiB | 330.00 KiB/s, done.
Resolving deltas: 100% (267095/267095), done.
From https://github.com/Homebrew/linuxbrew

[new branch]      master     -> origin/master
HEAD is now at dc1c2b5 JavaRequirement: Linuxbrew default_formula "jdk"
Warning: /home/rahn/.linuxbrew/bin is not in your PATH.
==> Installation successful!
==> Next steps
Install the Linuxbrew dependencies:

Debian, Ubuntu, etc.:
sudo apt-get install build-essential
Fedora, Red Hat, CentOS, etc.:
sudo yum groupinstall 'Development Tools'
See http://brew.sh/linuxbrew/#dependencies for more information.
Run brew doctor before you install anything
Run brew help to get started
$ apt-get install build-essential
Reading package lists... Done
Building dependency tree
Reading state information... Done
build-essential is already the newest version.
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
$ brew
bash: brew: command not found
How do I do for this?

Maybe you need /home/rahn/.linuxbrew/bin/ in your path? If it's already in your path, can you try either hash -r (Bash) or rehash (Zsh) and then try again?

I get zsh: command not found: brew even I'm at directory  /home/rahn/.linuxbrew/bin/
I don't know why.
I'm new to Linux, still google on path editing.

@tseemann pointed out that this warning gets buried.
Warning: /home/rahn/.linuxbrew/bin is not in your PATH.

It needs to be improved with these instructions:
http://linuxbrew.sh/#installation

Add to your .bashrc or .zshrc:

export PATH="$HOME/.linuxbrew/bin:$PATH"

I append export PATH="$HOME/.linuxbrew/bin:$HOME/.linuxbrew/sbin:$PATH" to the end of ~/.bashrc and terminal prompt:
** (gedit:2990): WARNING **: Set document metadata failed: Setting attribute metadata::gedit-spell-language not supported
** (gedit:2990): WARNING **: Set document metadata failed: Setting attribute metadata::gedit-encoding not supported
After saving:
$ which brew
brew not found

Open a new terminal window with a new shell. It should work.

No, it doesn't...
The line has been appended to ~/.bashrc
But $PATH remain unchanged.
$ echo $PATH
/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games

Try instead appending the line to ~/.bash_profile
Also try running in the new terminal:
PATH="$HOME/.linuxbrew/bin:$HOME/.linuxbrew/sbin:$PATH"
which brew
brew env

I don't have a .bash_profile in ~ so gedit create a new one for me.
Still:
`$ which brew~
brew not found

Please try:
PATH="$HOME/.linuxbrew/bin:$HOME/.linuxbrew/sbin:$PATH"
which brew
brew doctor

It works this time but not after starting a new terminal.
So there is something wrong with .bashrc?

Found it, It's about zsh.
I edit .zshrc and everything goes.
I thought zsh would inherit config from bash

Thanks, @sjackman @rwhogg

@sjackman @rwhogg We should probably check $SHELL to tell people which dotfile to add the PATH stuff to ?

@tseemann @sjackman @rwhogg I think you should.

~/.`basename $SHELL`rc

?

@sjackman pretty much, maybe
$HOME/.$(basename ${SHELL:-bash})`rc

for safety in case $SHELL was undefined...

Yep, ~ expands to $HOME on pretty much ever shell that I know of. Only at the start of a word though, not in the middle, so the above $HOME can't be replaced by ~.
❯❯❯ echo ~
/Users/sjackman
❯❯❯ echo PATH=~
PATH=~


Hero Carousel- Mouse cursor swipe control Issue

Hi Team,
I have noticed that the Mouse cursor swipe control is not working in the EDS. Please compare this in the below-provided URLs
https://main--aldevron--hlxsites.hlx.page/qe-test/hero-carousel
https://www.aldevron.com/

Hi Kumaresan - As discussed with Client, they are ok with this. It can be taken as an enhancement in Phase 2.

As per the above thread, the Clients are okay with this in this Phase. It can be taken as an enhancement in Phase 2. Hence closing the the ticket,


feat(chat-e2e): implemented e2e tests chat switches

Description:
feat(chat-e2e): implemented e2e tests chat switches
Issues:
EPMRTC-598, EPMRTC-599, EPMRTC-600, EPMRTC-601, EPMRTC-602
Checklist:

[ ] the pull request name complies with Conventional Commits
[ ] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[ ] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[ ] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review

/deploy-review

/deploy-review


kv: remove useless grpc pool

What problem does this PR solve?

Issue Number: ref #10879
What is changed and how it works?
As title.
Check List
Tests

No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/retest

/retest


Failed to install pyrosm on Python3.7 OSX

$ sudo python3.7 -m pip install pyrosm
WARNING: The directory '/home/fippo/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Collecting pyrosm
  Downloading pyrosm-0.5.3.tar.gz (2.0 MB)
     |████████████████████████████████| 2.0 MB 1.7 MB/s
  Installing build dependencies ... error
  ERROR: Command errored out with exit status 1:
   command: /usr/bin/python3.7 /usr/local/lib/python3.7/dist-packages/pip install --ignore-installed --no-user --prefix /tmp/pip-build-env-pa39_a85/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i https://pypi.org/simple -- setuptools wheel Cython cykhash pyrobuf
       cwd: None
  Complete output (58 lines):
  WARNING: The directory '/home/fippo/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
  Collecting setuptools
    Downloading setuptools-50.3.2-py3-none-any.whl (785 kB)
  Collecting wheel
    Downloading wheel-0.35.1-py2.py3-none-any.whl (33 kB)
  Collecting Cython
    Downloading Cython-0.29.21-cp37-cp37m-manylinux1_x86_64.whl (2.0 MB)
  Collecting cykhash
    Downloading cykhash-1.0.2.tar.gz (26 kB)
    Installing build dependencies: started
    Installing build dependencies: finished with status 'done'
    Getting requirements to build wheel: started
    Getting requirements to build wheel: finished with status 'done'
      Preparing wheel metadata: started
      Preparing wheel metadata: finished with status 'done'
  Collecting pyrobuf
    Downloading pyrobuf-0.9.3.tar.gz (258 kB)
      ERROR: Command errored out with exit status 1:
       command: /usr/bin/python3.7 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-4yhaa6ai/pyrobuf/setup.py'"'"'; __file__='"'"'/tmp/pip-install-4yhaa6ai/pyrobuf/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-4yhaa6ai/pyrobuf/pip-egg-info
           cwd: /tmp/pip-install-4yhaa6ai/pyrobuf/
      Complete output (33 lines):
      WARNING: The directory '/home/fippo/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
      rendering 'pyrobuf_list.pyx' from '/tmp/pip-install-4yhaa6ai/pyrobuf/pyrobuf/protobuf/templates/pyrobuf_list_pyx.tmpl'
      rendering 'pyrobuf_list.pxd' from '/tmp/pip-install-4yhaa6ai/pyrobuf/pyrobuf/protobuf/templates/pyrobuf_list_pxd.tmpl'
      Traceback (most recent call last):
        File "<string>", line 1, in <module>
        File "/tmp/pip-install-4yhaa6ai/pyrobuf/setup.py", line 158, in <module>
          zip_safe=False,
        File "/usr/local/lib/python3.7/dist-packages/setuptools/__init__.py", line 144, in setup
          return distutils.core.setup(**attrs)
        File "/usr/lib/python3.7/distutils/core.py", line 148, in setup
          dist.run_commands()
        File "/tmp/pip-install-4yhaa6ai/pyrobuf/setup.py", line 72, in run_commands
          self.ext_modules.extend(self.pyrobufize_builtins())
        File "/tmp/pip-install-4yhaa6ai/pyrobuf/setup.py", line 135, in pyrobufize_builtins
          include_path=['pyrobuf/src'])
        File "/usr/lib/python3/dist-packages/Cython/Build/Dependencies.py", line 749, in cythonize
          ctx = c_options.create_context()
        File "/usr/lib/python3/dist-packages/Cython/Compiler/Main.py", line 577, in create_context
          self.cplus, self.language_level, options=self)
        File "/usr/lib/python3/dist-packages/Cython/Compiler/Main.py", line 75, in __init__
          from . import Builtin, CythonScope
        File "/usr/lib/python3/dist-packages/Cython/Compiler/CythonScope.py", line 5, in <module>
          from .UtilityCode import CythonUtilityCode
        File "/usr/lib/python3/dist-packages/Cython/Compiler/UtilityCode.py", line 3, in <module>
          from .TreeFragment import parse_from_strings, StringParseContext
        File "/usr/lib/python3/dist-packages/Cython/Compiler/TreeFragment.py", line 17, in <module>
          from .Visitor import VisitorTransform
        File "/usr/lib/python3/dist-packages/Cython/Compiler/Visitor.py", line 15, in <module>
          from . import ExprNodes
        File "/usr/lib/python3/dist-packages/Cython/Compiler/ExprNodes.py", line 2713
          await = None
                ^
      SyntaxError: invalid syntax
      ----------------------------------------
  ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
  WARNING: You are using pip version 20.0.2; however, version 20.2.4 is available.
  You should consider upgrading via the '/usr/bin/python3.7 -m pip install --upgrade pip' command.
  ----------------------------------------
ERROR: Command errored out with exit status 1: /usr/bin/python3.7 /usr/local/lib/python3.7/dist-packages/pip install --ignore-installed --no-user --prefix /tmp/pip-build-env-pa39_a85/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i https://pypi.org/simple -- setuptools wheel Cython cykhash pyrobuf Check the logs for full command output.
WARNING: You are using pip version 20.0.2; however, version 20.2.4 is available.
You should consider upgrading via the '/usr/bin/python3.7 -m pip install --upgrade pip' command.

I was using old version of cython. Upgrading cythin helped:
sudo python3.7 -m pip install cython --upgrade --ignore-installed


Edit Orchestration Getting Started Guide

Description
The Getting Started Guide for Observabillity needs to be edited:

Needs a better intro
Some flawed syntax, punctuation
Needs to conform to style guidelines we have defined
Needs better xrefs to other docs for more information

Getting started guides should provide a bridge into the main documentation
Propose that links throughout the content could be distracting for some new users so, for Getting started guides only, propose that we deviate from our standard practice and instead add a "To learn more" subsection to each major section and add appropriate xrefs there.

DoD

Intro makes sense for someone who comes to this page without much prior knowledge
Syntax is good
Conforms to style guidelines for capitalization of terms, links to k8s docs for major items
Contains appropriate links to the Guides and reference pages and possibly Kubernetes docs

I would like to work on it. Please assign me .

This ticket is not refined yet. We will refine it on wednesday in the community meeting. Then I'll gladly assign you :)


DNA Exists!

I always get DNA exists after the code generates 1 image, i have set all weights to random weights, nothing is the same, everything adds up to 100... still doesn't help. I have saved it after this, doesn't work

The code:
`const fs = require("fs");
const width = 512;
const height = 512;
const dir = __dirname;
const description = "This is an NFT made by the coolest generative code.";
const baseImageUri = "https://hashlips/nft";
const startEditionFrom = 1;
const endEditionAt = 100;
const editionSize = 100;
const raceWeights = [
{
value: "skull",
from: 1,
to: editionSize,
},
];
const races = {
skull: {
name: "Skull",
layers: [
{
name: "Suit",
elements: [
{
id: 0,
name: "Regular",
path: ${dir}/2-suit/Pig_Main_body_white.png,
weight: 100,
},
],
position: { x: 0, y: 0 },
size: { width: width, height: height },
},
{
name: "Facial hair",
elements: [
{
id: 0,
name: "No facial hair",
path: ${dir}/6-facial-hair/NoFacialHair.png,
weight: 31,
},
{
id: 0,
name: "Beard",
path: ${dir}/6-facial-hair/Pig_beard.png,
weight: 32,
},
{
id: 0,
name: "Moustache",
path: ${dir}/6-facial-hair/Pig_moustache.png,
weight: 34,
},
],
position: { x: 0, y: 0 },
size: { width: width, height: height },
},
{
name: "Accessories",
elements: [
{
id: 0,
name: "No accessories",
path: ${dir}/9-accessories/NoAcc.png,
weight: 18,
},
{
id: 0,
name: "Phone",
path: ${dir}/9-accessories/Pig_phone.png,
weight: 19,
},
{
id: 0,
name: "Flower_red",
path: ${dir}/9-accessories/Pig_flower_red.png,
weight: 20,
},
{
id: 0,
name: "Flower_yellow",
path: ${dir}/9-accessories/Pig_flower_yellow.png,
weight: 21,
},
{
id: 0,
name: "Sigaret",
path: ${dir}/9-accessories/Pig_sigaret.png,
weight: 22,
},
],
position: { x: 0, y: 0 },
size: { width: width, height: height },
},
{
name: "Headwear",
elements: [
{
id: 0,
name: "Bandana",
path: ${dir}/10-headwear/Pig_bandana_main.png,
weight: 7,
},
{
id: 0,
name: "Hat",
path: ${dir}/10-headwear/Pig_hat_main.png,
weight: 8,
},
{
id: 0,
name: "Hat_Dollar",
path: ${dir}/10-headwear/Pig_hat_dollar.png,
weight: 9,
},
{
id: 0,
name: "Hat_pig_sign",
path: ${dir}/10-headwear/Pig_hat_pig_sign.png,
weight: 10,
},
{
id: 0,
name: "Hat2_Dollar",
path: ${dir}/10-headwear/Pig_hat2_dollar.png,
weight: 11,
},
{
id: 0,
name: "Hat2_red_Dollar",
path: ${dir}/10-headwear/Pig_hat2_red_dollar.png,
weight: 12,
},
{
id: 0,
name: "Hat2",
path: ${dir}/10-headwear/Pig_hat2.png,
weight: 13,
},
{
id: 0,
name: "Hat2_red",
path: ${dir}/10-headwear/Pig_hat2_red.png,
weight: 14,
},
{
id: 0,
name: "Witch_hat",
path: ${dir}/10-headwear/Pig_witch_hat_main.png,
weight: 16,
},
],
position: { x: 0, y: 0 },
size: { width: width, height: height },
},
],
},
};
module.exports = {
width,
height,
description,
baseImageUri,
editionSize,
startEditionFrom,
endEditionAt,
races,
raceWeights,
};
`
@HashLips sorry for mention, but i really need help

Hello,
if I understoo well the code from hashlips -  you get it all wrong with the Weight but until he replies maybe you can work like this:
you need to think from 0 to 100.
imagine you have 5 image and you want them to be ranked by rarity (1 the lowest and 5 the highest)
imagine you want image 5 to be at 3% then the weight of this image shall be -> weight : 3
now imagine you want image 4 to be at 4% so weight of image 4 shall be -> weight : 7 (weight from image 5 + 4)
now image 3 at 15% then the weight shall be -> weight 22 (weight from image 4 +15)
now image 2 at 30% then the weight shall be -> weight 52
Now image 1 shall be 100-3-4-15-30= 48% then the weight is obvisously 100 (weight image 2 +48)
:)
you better also change the ID from 0 to max_image

Did you fix this i am having same issue?


removed duplicate blog posts

Thanks! How about we handle all queries in one go? At least the query for blog tags and the one for chapters also needs a locale filter.

Okay, sure, feel free to change that. I do not know how to insert a filter before a query (except when implementing it in a query that filters all assets but this seems to be less clear code) which is why I just inserted it in both queries.

Yes, adding a filter to each query individually is exactly how to do it. There's no way to apply a filter to all queries at once.

Ah okay, now I understand that you just want me to add the filter also to the standorte.js page. There is already a filter in place in that file as you can see here: https://github.com/StudentenBildenSchueler/sbs-homepage/blob/master/src/pages/standorte.js.
I think we should thus first go ahead merging this PR to resolve the issue with the blog posts and later I will provide another one that takes care of the language selection in the anmeldung.

Oops, I forgot about that. Sorry for the noise. I'll merge now.


Help me to implement https://github.com/tc39/proposal-type-annotations

i would love to create a fork and maybe even make a PR if you want to also adopt that and it algins also with your goals.
https://github.com/tc39/proposal-type-annotations i want to implement that porposal on top of graaljs so that typescript would work untranspiled directly inside graaljs
Questions
as this needs to parse general all function arrguments and all object assignments what would be the related files should i create new files or should i implement that in the current set of files?
my guessed entrypoint is: https://github.com/oracle/graaljs/blob/master/graal-js/src/com.oracle.truffle.js.parser/src/com/oracle/truffle/js/parser/JSParser.java is that the full scope?

Hi, maybe @iamstolis could assist on this?

The mentioned proposal is in a very early stage (Stage 1). The goal of Stage 1 is to examine the problem and possible solutions. Nothing is fixed at this stage. It may even happen that there is no specification at all. We usually implement proposals that reach Stage 3. This particular proposal contains some tentative grammar already, but considering how much push-back the current form of the proposal received on the last standardization meeting, it is unlikely that the grammar would not be changed significantly when/if the proposal moves into higher stages. In other words, it is too early to implement this proposal.

@iamstolis that is correct thats why i would even implement it my self in a fork i see clear that it solves a lot of issues to simple handle type annotations as comments and it saves me from transpiling. It directly Enables loading .ts files.
i also think it is relativ easy to implement and would teach me some good stuff in general out of my mind it would only mean to adjust the Parser so it ignores the annotations in a later version it could create comment nodes out of it.
you are correct that there will change stuff but it will happen anyway for my Own lang which is designed as superset of JS it is already needed.
https://babeljs.io/docs/en/babel-plugin-transform-typescript shows most of the current issues but i also investigate on the Typescript Project it self to get it all algined
at chromium we already also implemented and tested it and took the learnings a graaljs fork with that proposal would even speed up the proposal to land as it would help me to demo and define the edgecases with realworld code.

proposal strong mode https://docs.google.com/document/d/1Qk0qC4s_XNCLemj42FqfsRLp49nDQMZ1y7fwf5YjaI4/view
STRONG MODE FEATURES IMPLEMENTED IN V8.4.9 https://groups.google.com/g/strengthen-js/c/ojj3TDxbHpQ/m/5ENNAiUzEgAJ

Conclusion

as this needs to parse general all function arrguments and all object assignments what would be the related files should i create new files or should i implement that in the current set of files?

You're welcome to experiment with the Parser (and related classes). Probably easiest to modify it directly, with the type annotation specific parts guarded by a feature flag.

@woess how would i implement or pass such a feature flag on what level should i do that. I did never release a Java Project with any flags i avoid such stuff i also did google about the term and i could not find anything i guess you mean a compiler flag?
so that it does not get compiled or do you mean something like a runtime flag on context create if so where do such flags get implemented?

@frank-dspeed Yes, I mean a context option. Those are defined in the class JSContextOptions and JSParserOptions. You can follow the examples there.

Landed in NodeJS

[ ] https://github.com/nodejs/node/pull/53725

You might want to read my blog post Run TypeScript Directly in Java. In brief, swc4j can help transpile TypeScript to JavaScript with exactly the same logic that Deno uses.

@caoccao sure it can do that i also got success simple transpiling tsc and replacing the filesystem with the graaljs one

@caoccao but the final goal would be that the parser strips the type without any other additions.

@caoccao but the final goal would be that the parser strips the type without any other additions.

I've been reviewing Deno, Swc source code for years, and I'm the maintainer of swc4j. I'm afraid that's not an easy work if you want to start from scratch. Node.js offloading the work to Swc is a sign. In order to identify what is a valid TS type annotation, there will be tens of various TS types to be well implemented in the parser. That's also one of the reasons I worked out swc4j so that there's single source of truth (Swc) that Deno, Node.js and swc4j all follows.
Here is a list of level 1 TS types to parse for your reference.

TsArrayType
TsConditionalType
TsFnOrConstructorType
TsImportType
TsIndexedAccessType
TsInferType
TsKeywordType
TsLitType
TsMappedType
TsOptionalType
TsParenthesizedType
TsRestType
TsThisType
TsTupleType
TsTypeLit
TsTypeOperator
TsTypePredicate
TsTypeQuery
TsTypeRef
TsUnionOrIntersectionType

@caoccao i am at present trying to create a llm based compiler and got good results i guess we can soon throw all the languages away at last thats my final goal

Good luck!


Remove unnecessary references from Option types

Option<T> impl's Copy when T is Copy, so &Option<i32> and &Option<&str> gain you nothing except extra lifetime annotations.

I had Option<T> initially, and ended up changing it becuase I thought &Option<T> would be more flexible. I think maybe the client should allow for any Borrow<Option<T>> for ultimate flexibility, but that might be an overkill.
I also want to hold off on changing the version to 0.4.0 for now, until I am more sure that the client API won't change. Also, most of the changes have been internal, so I don't think there is a huge need to publish a new version just yet.

I don't... really see the purpose.  Option<&T> and &Option<T> are essentially indistinguishable as far as I understand.  &Option<&T> is just unnecessary.
It's pre-coffee for me this morning, so I may not be thinking clearly.

Yeah, I think you are right. I remember changing it to &Option<T>, but I may have not been thinking when I did. I can merge this, but it looks like there are some conflicts.


Screen cheese in settings editor

re  #55791

open setting editor
search for 'title'
two entries show, they overlap

This comes from estimating the description height which I have to do as an optimization. This is still not perfect but it's better now.
Verification:

Look at different settings, resize the window horizontally, and make sure they are layed out correctly and don't overlap
Try this while searching, not searching, and with the TOC visible and hidden (when the settings editor is narrow)


Index: compare interface types of potential witnesses to make sure we handle overloads properly.

@swift-ci please smoke test and merge


add live data integration

Pull Request
Description
Building on #47 and integrating it with the Enphase code, this PR successfully follows the auth grant flow and fetches the last 30min data from an enphase system(you should know the system ID of the system and the HO should give you access to the system)
The following images are a comparison along with the curve(the fake data is almost linear and 0 since it was past 6PM IST when it was tested):

Fixes #
Replaced all occurences of power_wh with power_kw
How Has This Been Tested?
Tested this with @peterdudfield 's enphase system and compared the live generation with the fake data
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

[x] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

Great work @aryanbhosale very cool to see the forecast working and taking in actual PV generation data!
I think this is almost there just a few small things to check given my comments and for me this feels like it's missing a test, either at the highest level a test that the forecast runs when you have some inverter data (could add some mock/fake data that is returned when calling the get_enphase_data function to test that everything works) or a test on the make_pv_data function with again some fake data returned when calling the get_enphase_data function

Great work @aryanbhosale very cool to see the forecast working and taking in actual PV generation data!
I think this is almost there just a few small things to check given my comments and for me this feels like it's missing a test, either at the highest level a test that the forecast runs when you have some inverter data (could add some mock/fake data that is returned when calling the get_enphase_data function to test that everything works) or a test on the make_pv_data function with again some fake data returned when calling the get_enphase_data function

Yeah that sounds good, I think adding it to the make_pv_data function makes more sense since it's more specific and we'd know where to look when something's wrong


Inactive IAM Collaborator Deletion Required - Username: edward.kirwin

The Collaborator-Inactivity-Monitoring workflow has detected that the username edward.kirwin is inactive for more than 180 days.
Consult this documentation which describes the process for deleting the collaborator user.

Removed in PR https://github.com/ministryofjustice/modernisation-platform/pull/6935


Electron-414 (Add a logic not to close the notifications on mouse hover)

Description
Add a logic not to close the notifications on mouse hover ELECTRON-414
Approach
How does this change address the problem?
Problem with the code:

Non-sticky notification where being closed after a timeout of 5sec even on mouse hover

Fix:

Restart the timer on mouseleave event to close the notification

Spectron test results
Electron-414 — Spectron.pdf
Unit test results
Electron-414 — Unit Tests.pdf
Open Questions if any and Todos

[X] Unit-Tests (No changes)
[X] Documentation
[X] Automation-Tests
When solved, check the box and explain the answer.

@VikasShashidhar @VishwasShashidhar Please review. Thanks 😄

@lneir Kindly review this.

@kiranniranjan Can you resolve the merge conflict?

@VishwasShashidhar Done. Resolved conflicts 👍


Triton inference protocol support for Seldon Core

We should add Triton inference as an option through the Seldon Core prediction platform.

Added with https://github.com/fuseml/extensions/pull/73


Top Menu Bar has contrast issues

Dark Gray on light Gray does not contrast enough

Make the text darker by default.  Change the highlight color.  Double check site-improve to make sure this is fixed.


Update: CABS.SalesPrix version 6.17.3

- [X] Have you signed the Contributor License Agreement?

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.5 schema?

Microsoft Reviewers: Open in CodeFlow

Hi @Trenly,
This manifest adds Apps and Features entries that aren't present in previous PR versions. Should these entries be added to the previous versions also?
(Automated response - build 513.)


config: flipping v2-config-only to disable v1 support by default

Turning v1 support down by default.  The V1 API will still function until October, and can be used by flipping --v2-config-only=false on the command line.
For help migrating to the v2 API, please see the envoy-announce email:
https://groups.google.com/forum/#!topic/envoy-announce/oPnYMZw8H4U
Risk Level: risk of binary problems: low.  risk of user dismay: not low
Testing: existing unit tests
Docs Changes: pending v1 removal
Release Notes: yes.
Deprecated: v1 API

@envoyproxy/maintainers

I don't think this works the way you intended. --v2-config-only=false is not a valid command-line flag since this is a SwitchFlag that can't take a value. Now, running with --v2-config-only actually disables the requirement that the config be v2. That is, the only way to use a v1 config (which is deprecated) is to set the flag --v2-config-only, which is just mind-bending.

@akonradi can you file an issue on this please?

+1 that seems bad. we need to fix.

Looks like someone beat me to it: #3846.


Accessibility: Unable to access the table header sort control using keyboard navigation

How to reproduce the bug

Create a table chart type
Add the table chart to a dashboard
Using keyboard navigation, tab through the dashboard elements

Expected results
User is able to navigate to and use the sort controls in table chart types using keyboard navigation
https://www.w3.org/TR/WCAG22/#keyboard
Actual results
Keyboard navigation skips the table chart headers
Screenshots

Environment
(please complete the following information):

browser type and version:
superset version: master
python version: python --version
node.js version: node -v
any feature flags active:

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

@yousoph @eschutho
As per my analysis,
1)we need to add tabIndex attribute to  in TableChart.tsx
2)we need a keyboard event handler to trigger column sorting when 'Enter' key is pressed on column
can you please assign this to me?  I want to fix this issue.

Thanks for picking up this ticket @arunthirumani! I have a draft PR of an accessible keyboard event trigger in dashboards if you want it for reference.

@eschutho
Thank you for the reference, it was helpful.
Here is my draft PR
please let me know comments/suggestions


[FEATURE] Freeze score if habit archived

[x] refactor code
[ ] implement feature
[ ] add comment for score calculator at root/lib/model/_score/calculator.dart
[ ] test cases

 Freeze score if habit archived


Calendar and scheduler components

I want to know if there are plans to create a calendar and/or scheduler components like http://fullcalendar.io/ and http://fullcalendar.io/scheduler/?

Negative, due to the level of complexity and our team's limited manpower.
But there are a few third-party Bootstrap-based widgets for this, such as https://github.com/eternicode/bootstrap-datepicker
See also https://github.com/twbs/bootstrap/issues/445#issuecomment-13169107

Thanks for your fast response, but I don't speak about a "date-picker", I'm talking about a "calendar of events" component.

But, I understood that all of you are to busy.

Yeah, no plans for that either.


[feat]: support for sparse accumulator type in sync mode

add support for sparse accumulator in sync train  mode.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.杨熙 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Use bundle-collapser to minify paths in module requires

Saves like 50 bytes after gzip, laugh

How do these affect the generated sourcemaps? Like, depending on where this step happens in the pipeline, it might generate incorrect tokens, etc.

I thought the source maps are generated against the Browserify output – not the original code.


git-branch icon missing

This seems to be missing, right? Any other place where I can find it?

This should be the same as source-control. Does that work for you?

Ah thanks, that's it! I should have looked at that to figure out the aliases: https://github.com/microsoft/vscode-codicons/blob/f0caa623812a8ed5059516277675b4158d4c4867/src/template/mapping.json#L32-L35


drack

This is a Bug Report

Problem:
Proposed Solution:
Page to Update:
https://kubernetes.io/...

Closing as this is missing any kind of description or information. Looks like maybe an accidental submission? Please file an issue with more details if there is something you are trying to report.
/close


Integrate VC Data Model Spec Test Suite Into SSI

Should incorporate into GHA for automated testing, along with DIDs

Link to our fork - https://github.com/knox-networks/vc-test-suite

I've filed https://github.com/w3c/vc-test-suite/issues/135 to deal with the proof-related issues we were having due to us expecting certain properties to be part of any proof object

When you exclude the features, we don't support yet we've got 6 failures currently I've attached the report below/Users/luisosta/vc-test-suite/implementations/index.html

One spec test remains failing and its the one that requires the verifiableCredential field to be optional, which to me is weird in concept but there's more information here - https://github.com/w3c/vc-test-suite/pull/113. Should we file an issue with the VC spec to clarify the language

Here's an updated report /Users/luisosta/vc-test-suite/implementations/KnoxNetworks-report.json

I've fixed the last issue, the verifiableCredential issue is completely correct. Here's a link to the 1.1 spec - https://www.w3.org/TR/vc-data-model/#presentations-0. What remains is the proof-related issues - https://github.com/w3c/vc-test-suite/issues/135

Our repo - https://github.com/knox-networks/vc-test-suite has updated the examples to not be malformed and added the Knox Networks report

Thanks- updated results can be found here https://knox-networks.github.io/vc-test-suite/implementations/
some comments
2.3 Credential Status - why do we show no support?
Credential Schema- I think we should be able to address this in the upcoming sprints as we add VC schema
ZKP- Would be interesting to see how the other providers with support passed the tests.

results here https://knox-networks.github.io/vc-test-suite/implementations/


pkg/vmextension: cut dependency to executil pkg

Removing dependency to azure-docker-extension/pkg/executil in the
pkg/vmextension so that other extension handlers do not have to
vendor package executil.
Also other minor refactorings.
cc: @boumenot

Skipping PR and merging this, but PTAL and let me know.


Improve validation and error messaging

Problem
Most error messages in Autohook are generic; they don't explain in detail what's going on, and don't offer pointers to a solution. Furthermore, errors coming as a result of a non-successful API response are not relayed to the user.
Some of these errors can be avoided by adding client side validation and parsing (for example, to ensure a webhook URL is formally correct before registering it with Twitter).
Solution

Add client side validation for URL, so that an invalid URL will cause Autohook to fail before issuing an API request
Trim whitespace from configuration variables, so that leading and/or trailing whitespaces will not cause an API request to fail
The Autohook constructor ensures that all the required variables are set
Add new error types so Autohook can throw separate exceptions for client side and server side errors

@tonyv and/or @aureliaspecker mind taking a look?


Use consistent data attributes

data-toolbox should be data-react-toolbox to be consistent with the rest of the components.

Agree with you. Maybe in this PR we can add other data attributes that are missing for some components before merging. What do you think?

ya good call, i'll add to this PR.

should be good to go unless you see something missing, or have a reason to prefer data-role over data-react-toolbox.

Nice! I see it ok :) thanks!


Improve structure of How To section

The Use Signing Keys topic is a mixture of how to store, and how to configure access to signing keys.  It's grown over time as more options for doing these things have been added and would benefit from being broken up at this point.

Fixed by #240


Add taker http basic auth

Resolves #609
This is the first step to have authentication for the taker.
For our current use of running the taker on umbrel this is sufficient. Eventually we might want to allow the user to change the password from inside of the application.

Note: we should backport this to 0.3.x because it is mostly needed for https://github.com/getumbrel/umbrel/pull/1149

Closed in favor of https://github.com/itchysats/itchysats/pull/982.


feat: create a slide switching directive #1162

This is a draft where I propose to implement only one directive with entry param which sets the direction of switching between slides (next or privious). @kirjs what do you think?

Turned switchSlide directive into 2 separate directives.


typedoc fails on github action

For some reason typedoc keeps failing when I run it in a github action, while it works on my local enviroment.
This is the action failing: https://github.com/wrnrlr/prelude/actions/runs/11505262647/job/32026581306
I don't know how to reproduce the error on my machine.

I blame deno. TypeDoc does not support runtimes other than Node. It looks like there are no lib files being included, which could happen due to not having node_modules or something... I don't use deno, so am not sure what the package system actually looks like there.

It is probably a combination of Github Actions, Deno and Typedoc. Deno + Typedoc work ok on my local machine, although it is a bit slow and hard to organise the documentation of complex types.

I don't have time to investigate issues which are definitely external to TypeDoc and especially ones that cannot be reproduced locally.
TypeDoc works just fine with a simple node based setup: https://github.com/Gerrit0/typedoc-packages-example/actions/runs/11632367251/job/32395312243


Edits

updates

Docs Build status updates of commit 2a436ba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Community/TOC.md
:white_check_mark:Succeeded
View

Community/adding-content.md
:white_check_mark:Succeeded
View

Community/auto-apply-retention-labels-in-office-365-using-content-types-and-metadata.md
:white_check_mark:Succeeded
View

Community/benefits-of-using-powershell-with-sharepoint.md
:white_check_mark:Succeeded
View

Community/changing-microsoft-teams-from-private-to-public-what-to-expect-in-sharepoint.md
:white_check_mark:Succeeded
View

Community/designing-solution-for-scale.md
:white_check_mark:Succeeded
View

Community/empowering-your-SharePoint-champions.md
:white_check_mark:Succeeded
View

Community/getting-started.md
:white_check_mark:Succeeded
View

Community/glossary.md
:white_check_mark:Succeeded
View

Community/identifying-your-sharepoint-champions.md
:white_check_mark:Succeeded
View

Community/importing-data.md
:white_check_mark:Succeeded
View

Community/includes/content-disclaimer.md
:white_check_mark:Succeeded
View

Community/index.yml
:white_check_mark:Succeeded
View

Community/information-architecture-managed-metadata-vs-lookup-column.md
:white_check_mark:Succeeded
View

Community/information-architecture-site-topology.md
:white_check_mark:Succeeded
View

Community/known-folder-move-benefits-for-enduser.md
:white_check_mark:Succeeded
View

Community/library-scenarios.md
:white_check_mark:Succeeded
View

Community/list-column-or-site-column-which-one-to-choose.md
:white_check_mark:Succeeded
View

Community/machine-learning-and-managed-metadata.md
:white_check_mark:Succeeded
View

Community/managing-external-guest-in-SharePoint-vs-Teams.md
:white_check_mark:Succeeded
View

Community/new-site-checklist.md
:white_check_mark:Succeeded
View

Community/permission-model-differences.md
:white_check_mark:Succeeded
View

Community/powerplatformlicensingforcitizendeveloper.md
:white_check_mark:Succeeded
View

Community/select-an-effective-navigation-strategy.md
:white_check_mark:Succeeded
View

Community/site-design-life-cycle.md
:white_check_mark:Succeeded
View

Community/team-site-or-communication-site.md
:white_check_mark:Succeeded
View

Community/versioning-basics-best-practices.md
:white_check_mark:Succeeded
View

Community/what-is-content-type.md
:white_check_mark:Succeeded
View

Community/what-is-site-column.md
:white_check_mark:Succeeded
View

Community/working-with-modern-clientside-pages-using-pnp-powershell.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Define project structure

This is a basic architecture I'd like to propose
./src
  ./components <-- shared and reusable components
  ./pages <-- bigger components that, eventually, handle some state
  index.js <-- entry point
  App.js <-- outer component that handles the routing
  ...

Thinking about the architecture is a crucial point in this phase. We have to do our best to keep the complexity at the minimum keeping it highly scalable.

I am not familiar with React to know the best practice conventions. I will go with your recommendations 🤓

@rossanodan that folder structure seems good to me 👍. I like the idea of then inside /pages doing Feature-based structuring, but I'm not quite sure it fits this application yet, since we don't have much planned.
I'd also like to know if we'll use just CSS or something like SCSS. I prefer SCSS but I'd like to know everyone's opinion.

@BOLT04 and @eddiejaoude SCSS already setup ;)


deps: update hermes to v1.9.0

Description

Hermes v1.9.0 with support for channel upgradability! 🥳
Running compatibility tests here...
closes: #5773

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

Summary by CodeRabbit

Chores

Updated internal test configuration to use the latest version tag "v1.9.0".

Moving to draft, since there are some errors that might require changes in interchaintest.


Scala Common Enrich: add adapter to pre-process Typeform webhooks

http://docs.typeform.io/docs/results-introduction

Migrated to https://github.com/snowplow/enrich/issues/103


Add Dockerfile and docker-compose.yml

Add a Dockerfile using nginx:alpine as base to host the static assets to ease development.

If you use VS Code, it might be easier for you to use something like the LiveServer extension.
I'm also working on a v3 which uses React instead of vanilla JS. In v3, development will be handled by npm instead of VS Code extensions or Docker.
If you strongly believe that there should be a Docker option for v2, could you please update the README with instructions on how to use what you're adding in this PR. Thanks!


when knowhosts directory doesn't exist. it will keep throwing FileNotFoundError regardless we set hostkeys=None

Currently using 1.1.2 version.
I have been using this way to set the hostkeys to None
cnopts.hostkeys = None

Apparently it doesnt matter because from the line 99 in __init__.py file, it will load from knownhosts.
Currently having an issue when using the client in a container that doesn't have knownhosts directory.
Even though I set hostkeys to None as above, it will try to resolve the default knownhosts which will raise FileNotFoundError.
So the workaround is to set the knownhosts to None, which will automatically set hotkeys to None as well. The only issue for this one is the type, it expects a string so it complains if it's None.
line 99
        if knownhosts is not None:
            try:
                self.hostkeys.load(Path(knownhosts).resolve().as_posix())
            except FileNotFoundError:
                # no known_hosts in the default unix location
                raise UserWarning(
                    f'No file or host key found in [{knownhosts}]. '
                    'You will need to explicitly load host keys '
                    '(cnopts.hostkeys.load(filename)) or disable host '
                    'key verification (cnopts.hostkeys = None).'
                )
            else:
                if len(self.hostkeys.items()) == 0:
                    raise HostKeysException('No host keys found!')
        else:
            self.hostkeys = None

So,

Can we set setting the hostkeys to None taking priority. It will not try to load the default knownhosts directory.
Or if not, I think making the knownhosts type to Optional[str] is okay for now.

Thank  you!

There are some conflations going on here. I'm not sure what you're trying to achieve exactly but I'm assuming the disabling of host key checking? Is this behavior happening when you pass the CnOpts() object like so:
python
import CnOpts, Connection from sftpretty

cnopts = CnOpts(knownhosts=None)
cnopts.hostkeys = None
with Connection('host', username='me', password='pass', cnopts=cnopts):

The behavior you describe is similar to what occurs if you try passing or setting CnOpts() on an existing Connection instead of prior too. In my testing I couldn't replicate the behavior could you post a code example? This is perhaps another opportunity to improve documentation as well.

yes, I was trying to disable host key checking. Almost like the code that you gave above, but I did not put CnOpts knownhosts as None
import CnOpts, Connection from sftpretty

cnopts = CnOpts()
cnopts.hostkeys = None
with Connection('host', username='me', password='pass', cnopts=cnopts):


Dragonflight version

I've been using this version locally and it seems to work fine. So I'm sharing it.

There was an error in the first pull request, so I'm resending it (as #4 ).


Refactor CheckCreate, CheckCancel, and CheckCash transactions to use new transaction scheme

Update CheckCreate, CheckCancel, and CheckCash transactions to use scheme defined in https://github.com/ripple/explorer/tree/staging/src/containers/shared/components/Transaction.
Also we need to update components to use hooks, tsx, flesh out tests, and leverage the <Amount> and <SimpleRow> components.

I would recommend doing this in three PRs


download file with token

What problem does this feature solve?
I am using Upload component  Upload and Download file
is there any sample  demo
how to download file  with Authorize (JWT)
and web api
thanks
What does the proposed API look like?
thanks

仔细读了一下 API  使用  nzPreview 属性可以拦截下载事件
Preview 有些误导性


Request: Deleting user messages

Can we have an option to clear out user messages for !volumes or !skips? Like !clear volume clears all commands with volume.

{Command_prefix}clean
Will remove all bot messages, and user messages containing bot commands.


Jessica/8862 default sender transform

This PR adds a default sender transform.
If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.
Test Steps:

Run the integration tests to make sure these still pass. you will need to run quickRun or run and then testIntegration.
Change the organizations.yml file jurisdictionFilter to match the state that you are sending data from (the example I use is IG) Also, change the translation schemaName to CA as well as the receivingApplicationName and the receivingFacilityName
Start up master and run reloadSettings.
Send a report like the IG Send HCA HL7 Full ELR sample in this Postman collection  ReportStream.postman_collection.json.zip
Find the file that this created in the SFTP folder and note this for later. You can do this by calling the Submissions by report ID call in the Postman collection and seeing which file name is returned.
Switch to the PR's branch
Hit the same endpoint.
View the file created in the sftp folder and make sure that it matches the file created earlier.

Changes
Created a default sender transform
Left the pieces for California in the CA transform
Updated the integration test to be able to use sender transforms
Updated the tests to use sender transforms for California
Checklist
Testing

[x] Tested locally?

[x] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?

[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?

[x] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Linked Issues

Fixes #8862

To Be Done
Create GitHub issues to track the work remaining, if any
N/A
Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints? No

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints? No
Does this change introduce new dependencies that need vetting? No
Does this change require changes to our infrastructure? No
Does logging contain sensitive data? No
Does this PR include or remove any sensitive information itself? No

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

@JessicaWNava Did we create a ticket to migrate the CA configuration? If not, can you do that and link it in this ticket?

@JessicaWNava Did we create a ticket to migrate the CA configuration? If not, can you do that and link it in this ticket?

Done, created here https://github.com/CDCgov/prime-reportstream/issues/9115 and linked in the ticket


TbActiveForm incorrect handling of clientValidation.

Code snippet from CActiveForm::error()
    $validators=isset($htmlOptions['clientValidation']) ? array($htmlOptions['clientValidation']) : array();
    unset($htmlOptions['clientValidation']);

TbActiveForm replaces this with:
    $validators = TbArray::getValue('clientValidation', $htmlOptions, array());

This is wrong for several reasons:

The clientValidation key is not removed from the options array.
CActiveForm expects a string value, TbActiveForm expects an array.

Currently this means that you cannot pass in a custom clientValidation key; if you pass a string TbActiveForm tries to implode it which will fail. If you pass an array it gets passed to TbHtml which will attempt to render it as a normal attribute (thus calling htmlspecialchars on an array).
Issue 1 can be solved by using TbArray::popValue.
Issue 2 can be solved by checking the type of the "clientValidation" key.

Fix was merged.


Support TypeScript 2.0

I am using new TypeScript 2.0 syntax like readonly and typedoc fails when processing those files. I wonder if there is setting I have found that allows me configure the version of TS being used or if this needs an adoption?

Duplicate of #234

Thanks.


Replace document with partition key

Package Name: @azure/cosmos
Package Version: 3.5.0
Operating system:
[X] nodejs

version: 12

[ ] browser

name/version:

[ ] typescript

version:

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
When I try to replace a document with a new value of the partition key, I have this error :
PartitionKey extracted from document doesn't match the one specified in the header
Is it forbidden to replace the value of a partition key ?
To Reproduce
Steps to reproduce the behavior:

Have a container with a partition key specified.
I used this model:

{
  id: "1234568",
  name: "testName",
  displayName: "Test Name",
  value: 32,
  description: "The test name",
  type: "String"
}

The partiton key for my example is /name.

Use the cosmos SDK to replace the name and value of this record:

const { body } = await client.database(databaseId).container(containerId).item(itemBody.id, itemBody.Country).read();
const newModel = Object.assign({}, body, newItem);
newItem.name = "newTestName";
newItem.value = 42;

const { item } = await client.database(databaseId).container(containerId).item(body.id, body.name).replace(newItem);

Expected behavior
Replace the document in the container.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I don't know if it's a limitation of Cosmos DB, or something else, but the API is clearly checking if the retrieved item have the same partition key value of the new item, which means that a partition key value is non mutable on a document.

That is correct. The partition key value cannot be updated. You must delete the document and then create it again with the new partition key value. If you want to force creation of a new document you can use upsert but your old document will still exist.

@southpolesteve thanks for the quick answer, is it mentioned in the docs ? I can't find where

I thought it was, but I cannot find it either.

I just got bit by this one too. Upsert was working while replace was not, but I didn't realize I was creating a new document.
Two suggestions here...

We update this doc... https://docs.microsoft.com/en-us/azure/cosmos-db/partitioning-overview

We change the error so that it says that the partition key cannot be changed. Right now it says that the ID does not exist, which is misleading.


Current protobuf==3.19.6 is not supported by TensorFlow 2.12

The current release for OpenFL requires protobuf=3.19.6
TensorFlow 2.12 requires protobuf!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5,<5.0.0dev,>=3.20.3
Because OpenFL will try to import TensorFlow if it is installed, importing OpenFL will result in an error:
[/usr/local/lib/python3.10/dist-packages/openfl/federated/task/__init__.py](https://localhost:8080/#) in <module>
     12     if pkgutil.find_loader('tensorflow'):
     13         # ignore deprecation warnings in command-line interface
---> 14         import tensorflow  # NOQA
     15
     16 from .runner import TaskRunner  # NOQA

[/usr/local/lib/python3.10/dist-packages/tensorflow/__init__.py](https://localhost:8080/#) in <module>
     35 import typing as _typing
     36
---> 37 from tensorflow.python.tools import module_util as _module_util
     38 from tensorflow.python.util.lazy_loader import LazyLoader as _LazyLoader
     39

[/usr/local/lib/python3.10/dist-packages/tensorflow/python/__init__.py](https://localhost:8080/#) in <module>
     35
     36 from tensorflow.python import pywrap_tensorflow as _pywrap_tensorflow
---> 37 from tensorflow.python.eager import context
     38
     39 # pylint: enable=wildcard-import

[/usr/local/lib/python3.10/dist-packages/tensorflow/python/eager/context.py](https://localhost:8080/#) in <module>
     26 import numpy as np
     27
---> 28 from tensorflow.core.framework import function_pb2
     29 from tensorflow.core.protobuf import config_pb2
     30 from tensorflow.core.protobuf import rewriter_config_pb2

[/usr/local/lib/python3.10/dist-packages/tensorflow/core/framework/function_pb2.py](https://localhost:8080/#) in <module>
      3 # source: tensorflow/core/framework/function.proto
      4 """Generated protocol buffer code."""
----> 5 from google.protobuf.internal import builder as _builder
      6 from google.protobuf import descriptor as _descriptor
      7 from google.protobuf import descriptor_pool as _descriptor_pool

ImportError: cannot import name 'builder' from 'google.protobuf.internal' (/usr/local/lib/python3.10/dist-packages/google/protobuf/internal/__init__.py)

This is problematic as Google Colab comes installed with TF 2.12 by default, causing a lot of our tutorials to break when run in colab. However, a user may downgrade it to TF 2.11 to workaround any issues as a quick fix, but it's worth investigating a more robust solution
To Reproduce
Steps to reproduce the behavior:

Install tensorflow==2.12
Install and import openfl

Alternatively

start a Google Colab notebook
install and import openfl

I tried upgrading to protobuf==3.20.3, though, I do get warnings that it is incompatible with openfl, but I have yet to encounter said problems when running the tutorials and such. I haven't played much with the business logic end of things. Any insights into why openfl was setup explicitly with version 3.19.6 in the setup.py script?


Remove redux in favor of a small recoil-inspired "atom" library

This is an experiment in replacing redux entirely with a tiny library I wrote for global application state management.
Redux has been okay, but all of the redux actions in speedscope are setters, which always made me think there must be a simpler way. This is an attempt to find that simpler way.

Coverage decreased (-7.7%) to 40.939% when pulling 390ca53f8875ba1bbb5a0dacebdf1675f6e8bdf8 on jlfwong/atom-experiment into d6f5efa06c06209fce4d78a0a6896b443853c2a0 on main.


End to end testing of CLI init flows

We have quite a lot of different paths through prisma2 init now, which should work on all kinds of environments. Sometimes some of them break unfortunately.
I think it might be beneficial to have a e2e tests (so simulating actual user activity) on these flows, to avoid regressions in that area.
It might make sense to set this up as a new project that has its own CI (maybe not even Buildkite but Circle, AppVeyor, Azure Pipelines, Travis - whatever can serve all our platforms easily and quickly).

This now partially exists under https://github.com/janpio/prisma2-cli-e2e-tests - as it is unclear how we will proceed with the CLI, it is also unclear how to proceed with the tests.


1.16.0

Need update, Thank you very much
[16:36:50] [Server thread/ERROR]: Could not load plugin 'VanishV2': Incompatible network protocol version (plugin requires one of: 390)

already fixed, download dev build here: https://poggit.pmmp.io/ci/superbobby2000/VanishV2/VanishV2


Data in MakeUDPArray not seen in UDP packet

Sole Rebel Soul, whom I am working with, contacted you in YouTube, and I wrote this message there as well, but I later saw your comment that it's better to treat as an actual issue, so I'm doing that now (sorry).
Sole is building the game using Blueprint.  I'm a C++ programmer, but he is in London and I am in Los Angeles.  This version is sending data on every event tick to the correct port - I can see it in Wireshark (the diagnostic app), but the correct data does not seem to be in the packet.   We're tried to create fixed data that we can recognize (1,2,3,4 etc.). Somehow either the UDPSender() is not correctly stuffing the values Sole is putting in the structure in MakeUDPArray into the array and so what's being sent is not correct, or Sole is doing it wrong, which from his screenshots, seems pretty straight-forward.  We would appreciate any help you are willing to give.  This plugin is EXACTLY what we need!!!  THANK YOU.  A reminder that this is UE5.1

If possible, please share screenshots. They just need to depict the initialization and data sending parts.
It might be a firewall issue somewhere along the route. So I need more information on the route. Are you using long-distance communication? And besides that, what are you unpacking the data with (besides sniffing packets with wireshark)?

I will ask Sole to post screenshots.  I'm waiting for him to respond to my message.  His initialization seems right though - the port is correct, the IP is loopback (<IP_ADDRESS>).  He sends me versions of his game.  I run Wireshark on my system and then run his game and immediately start getting packets in Wireshark on that port.  I was initially writing a SimTools plugin to receive the packets but I stopped when I realized that the packets didn't have the right data in them.  UDP packets can certainly leave the transmitter and be received by anything so Wireshark should be a valid way to do that - I'm just looking at the data.  Regarding a firewall, I'm getting the packets when the game runs and don't get the packets when the game stops running- and I've never heard of a firewall modifying packets only blocking them.
Hope this helps (prior to screenshots).  I sincerely appreciate your assistance with this and your quick response is awesome!
I do understand why the screenshots are valuable! THANKS!

I have a question.  The structure is set up for 20 floats and 3 uints.  If he "assigns" 2 floats (roll and pitch) and nothing else, will that be ok?  The rest is empty (zero) or random data?  I just want to make sure that only sending 2 floats would work.    Sorry, my BP knowledge lacks - this question may be lame but I'm just trying to understand.

Hello! I'm Sole Rebel Soul on Youtube. Thanks for sorting the plugin for 5.1 so quickly.
Attached is the level blueprint I've setup.

Extall would you mind giving us a Blueprint screenshot of sending maybe some static float values so that I can confirm the data is going through in Wireshark, and I can certainly make a Python or C++ receiver if you like, but just seeing 1.0, 2.0, 3.0, 40. and so on going through the UDP (and maybe 1,2,3 going through the Uints) that would be fantastic.
Honestly if you can help us get the data to work for UDP (most critically to send UDP data out of UE5.1, but later on to receive values from UDP being sent from me to the game) I can send you some $.

@extall Thank you in all cases.  I will ask Sole to try sending just 3 floats (again), but having them come in as zero might not be that useful for testing.  I apologize if I offended anyone by suggesting a financial contribution.  I won't bring it up again. If we indeed get to where we look for outsourcing in a more substantial way, I'll contact you separately.  Thank you very much for assigning someone to assist us.  I am excited, as this working will be huge for us in this project and new ones!  My daughter's in a PhD program.  I didn't make it as far myself.  Thanks again!

We got a crash on startup when the input is a static float. Is that expected behaviour?

Crash? No, not really. This plugin is known to be quite stable which is the reason why it became popular.
Saleh promised to have a look. He will get back to you.

@trevorhill77  @DrychronRed
I can confirm that the plugin works with UE5.1, I have created a sample project with a UDP sender and receiver as follows:

Did you try to receive the data with something other than Wireshark?
If you are trying to capture the data on a Windows local machine using Wireshark, make sure you are using the "Adapter for loopback traffic capture" https://stackoverflow.com/questions/5847168/wireshark-localhost-traffic-capture
You can use this python script tp recive and parse the data:
Source:https://pythontic.com/modules/socket/udp-client-server-example
I have modifed the script to decode the recived meassge as well.
import socket
import struct

localIP = "<IP_ADDRESS>"

localPort = 4123

bufferSize = 1024

# Create a datagram socket

UDPServerSocket = socket.socket(family=socket.AF_INET, type=socket.SOCK_DGRAM)

# Bind to address and ip

UDPServerSocket.bind((localIP, localPort))

print("UDP server up and listening")

# Listen for incoming datagrams

while (True):
    bytesAddressPair = UDPServerSocket.recvfrom(bufferSize)

    message = bytesAddressPair[0]

    address = bytesAddressPair[1]

    clientIP = "Client IP Address:{}".format(address)

    data = struct.unpack_from('f' * 20 + 'B' * 3, message, offset=0)

    print(data)

Saleh9292,
Thank you very much for your efforts.  Although I have Wireshark using the loopback address adapter and Wireshark is working fine, I am also using your python script.   Sole (Trevor) is pursuing the game Blueprints and was able to get around the crash and he's in the UK so he's done for the day and we'll try again tomorrow.  Hopefully we can confirm it's working tomorrow.
Cheers,
@DrychronRed

@trevorhill77  @DrychronRed  I can confirm that the plugin works with UE5.1, I have created a sample project with a UDP sender and receiver as follows:

Did you try to receive the data with something other than Wireshark? If you are trying to capture the data on a Windows local machine using Wireshark, make sure you are using the "Adapter for loopback traffic capture" https://stackoverflow.com/questions/5847168/wireshark-localhost-traffic-capture
You can use this python script tp recive and parse the data:
Source:https://pythontic.com/modules/socket/udp-client-server-example I have modifed the script to decode the recived meassge as well.
import socket
import struct

localIP = "<IP_ADDRESS>"

localPort = 4123

bufferSize = 1024

# Create a datagram socket

UDPServerSocket = socket.socket(family=socket.AF_INET, type=socket.SOCK_DGRAM)

# Bind to address and ip

UDPServerSocket.bind((localIP, localPort))

print("UDP server up and listening")

# Listen for incoming datagrams

while (True):
    bytesAddressPair = UDPServerSocket.recvfrom(bufferSize)

    message = bytesAddressPair[0]

    address = bytesAddressPair[1]

    clientIP = "Client IP Address:{}".format(address)

    data = struct.unpack_from('f' * 20 + 'B' * 3, message, offset=0)

    print(data)

@saleh9292 We have this working now - however I have a question or two - first let me say that Trevor isn't sure why his game was crashing.  He went through and made the Blueprint look like how you had it and it didn't crash anymore - however we both think he had set it up the same - so we don't know, which isn't the best but it seems to be solid now - we're getting both static floats and dynamic floats - the actual roll and pitch we need..  I knew when I saw 0x3F and 0x80 and 0x40 in the Wireshark data that it contained 1.0 and 2.0 float - in hex and was so happy.
So my remaining question is that I'm getting a packet of 95 bytes. Each float takes up 4 bytes - so 20 x 4 = 8 bytes.  That makes sense. Your python script uses the unpack function, and you're using "f" for floats (makes sense) but "B" for UINTS which doesn't make sense to me - "B" should be unsigned char, which is 8 bits - after the 80 bytes I have 15 bytes, which doesn't make sense. Even if you would have used "I"or "L" instead of "B" which would be UINTS, which I would have thought is correct, that would take up 4 bytes each or 12, but 80 plus 12 is 93 not 95.  So I'm a bit confused.  Can you set me straight?

@DrychronRed I am glad that it worked for you.
Using the default data structure of "20 floats plus 3 unit8" we get a message size of 83.
print(len(message)) returns 83 in my case.
I am not sure where the 95 size is coming from. Are you including the UDP header size?
We're using the unit8 data type for the last three integers, unit8 is an 8-bit unsigned integer, which is why I used the "B" in Python.
If you intend to communicate between Unreal and Python, I recommend that you modify the data structure .To make things easier, change the types to ones that are similar in size to those used in Pyton.i.e. to use the "I" or "L" instead of "B" by switching the unit 8 to
to unit 64 or int 64. We have given an example of how to change the data structure in the Readme file.

Overall, I think the issue has been resolved, as the plugin is functioning as it should. One issue that remains is that of documentation for the plugin, however, it will be a different issue. For the moment, I will close this one.

We solved most of the issue, but we're still getting a crash under certain circumstances.

This setup works fine.

However, we get a crash with this setup. Note the final float is in slot 20.
The crash message is as follows:
Assertion failed: Result
[file:D:\build++UE5\Sync\Engine\Source\Runtime\CoreUObject\Public\UObject\Stack.h] [Line:361]
For our purposes, I think we are OK, for now at least, but just want to make you aware of the crash.


Bug in Chrome for iOS widget with iOS 10

@scottjenson
We had several issues with the onboarding message in the Chrome for iOS widget with iOS 10 or 10.1 (we're not sure).
If the physical web has not been enabled on yet, the onboarding message fails to render correctly and the OK button does not apear for the users only after taping on "show more" / "show less" several times.

Looking into it...

We've filed a bug to get more info. Hopefully know more tomorrow.

Found the problem, testing a solution on Chrome Canary on Monday. Thanks for pointing this out!

Hi, great, isn't Canary exclusive to Mac OS, Windows and Android?

Of course, sorry. Just letting you know we found the problem and it's in the pipeline...

OK, just confirmed that the bug is fixed but it missed Chrome 55, will hopefully go into 56

My mistake, the fix is completed but it just missed the 'every-6-week' window of Chrome releases. No worries, assuming no issues with final testing, it'll just be in the next release, 57.


CRD Changes

Reason for Change:

Issue Fixed:

Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] relevant PR labels added

Notes:

@sharifnasser Is this still an issue?


pgplot: add mirrors/modernise

Combination of two commits.

snid failure is unrelated. It's a Homebrew/science formula which needs bumping after the gcc update. They're aware but I've dropped them a notification. Since this isn't a bump and won't force an immediate rebuild for anyone, merging.


No Secure Boot support

We don't have secure boot either on the ISO or the running system, would be nice to figure that out.

Universal Blue implements this through a layer called kernel-cache. They seem to:

generate openssl certificates for the private keys
install them into /etc/pki/kernel/{public,private}
sbsign the kernel image and kernel modules (and sbverify them too)
then rebuild the kernel RPMs with the modifications they made.

We can make this into like a COPR RPM instead, but I feel like the container-based approach is better for this considering we can use GitHub secrets for the official :tm: secure boot secrets.
We also need to keep in mind this issue and how it will be implemented in ublue-os. https://github.com/ublue-os/main/issues/691


Iss538

Bump timeout for unit tests to post the coverage report to istanbul.
Helps slower machines run unit tests.
Closes #538

@gghai ok to merge?

Please go ahead with the checkin . Thanks


Bundles not sent to the GW

Hey!
I set buffer to TRUE and start sending datasets. After 10 datasets (the value by default) Keepy returns:
All messages added with Channel ID: Malformed json - use iot2tangle json format
The database has the bundles but no channel id is associated. This is how one of the many row created look like:
{"bundle":[{"iot2tangle":[{"sensor":"Environmental","data":[{"Pressure":"102033"},{"Temp":"26160"},{"Humidity":"33"}]},{"sensor":"Accel","data":[{"x":"9"},{"y":"12"},{"z":"1009"}]},{"sensor":"Gyroscope","data":[{"x":"122"},{"y":"1708"},{"z":"5246"}]},{"sensor":"Inertial","data":[{"x":"183"},{"y":"122"},{"z":"-915"}]},{"sensor":"Light","data":[{"milliLux":"192960"}]},{"sensor":"Magnetometer","data":[{"x":"-59"},{"y":"3"},{"z":"7"}]},{"sensor":"Acoustic","data":[{"mp":"0.004649"}]}],"device":"carpi","timestamp":"1601653408"},{"iot2tangle":[{"sensor":"Environmental","data":[{"Pressure":"102033"},{"Temp":"26160"},{"Humidity":"33"}]},{"sensor":"Accel","data":[{"x":"9"},{"y":"12"},{"z":"1009"}]},{"sensor":"Gyroscope","data":[{"x":"122"},{"y":"1708"},{"z":"5246"}]},{"sensor":"Inertial","data":[{"x":"183"},{"y":"122"},{"z":"-915"}]},{"sensor":"Light","data":[{"milliLux":"192960"}]},{"sensor":"Magnetometer","data":[{"x":"-59"},{"y":"3"},{"z":"7"}]},{"sensor":"Acoustic","data":[{"mp":"0.004649"}]}],"device":"carpi","timestamp":"1601653408"},{"iot2tangle":[{"sensor":"Environmental","data":[{"Pressure":"102033"},{"Temp":"26160"},{"Humidity":"33"}]},{"sensor":"Accel","data":[{"x":"9"},{"y":"12"},{"z":"1009"}]},{"sensor":"Gyroscope","data":[{"x":"122"},{"y":"1708"},{"z":"5246"}]},{"sensor":"Inertial","data":[{"x":"183"},{"y":"122"},{"z":"-915"}]},{"sensor":"Light","data":[{"milliLux":"192960"}]},{"sensor":"Magnetometer","data":[{"x":"-59"},{"y":"3"},{"z":"7"}]},{"sensor":"Acoustic","data":[{"mp":"0.004649"}]}],"device":"carpi","timestamp":"1601653408"},{"iot2tangle":[{"sensor":"Environmental","data":[{"Pressure":"102033"},{"Temp":"26160"},{"Humidity":"33"}]},{"sensor":"Accel","data":[{"x":"9"},{"y":"12"},{"z":"1009"}]},{"sensor":"Gyroscope","data":[{"x":"122"},{"y":"1708"},{"z":"5246"}]},{"sensor":"Inertial","data":[{"x":"183"},{"y":"122"},{"z":"-915"}]},{"sensor":"Light","data":[{"milliLux":"192960"}]},{"sensor":"Magnetometer","data":[{"x":"-59"},{"y":"3"},{"z":"7"}]},{"sensor":"Acoustic","data":[{"mp":"0.004649"}]}],"device":"carpi","timestamp":"1601653408"},{"iot2tangle":[{"sensor":"Environmental","data":[{"Pressure":"102033"},{"Temp":"26160"},{"Humidity":"33"}]},{"sensor":"Accel","data":[{"x":"9"},{"y":"12"},{"z":"1009"}]},{"sensor":"Gyroscope","data":[{"x":"122"},{"y":"1708"},{"z":"5246"}]},{"sensor":"Inertial","data":[{"x":"183"},{"y":"122"},{"z":"-915"}]},{"sensor":"Light","data":[{"milliLux":"192960"}]},{"sensor":"Magnetometer","data":[{"x":"-59"},{"y":"3"},{"z":"7"}]},{"sensor":"Acoustic","data":[{"mp":"0.004649"}]}],"device":"carpi","timestamp":"1601653408"}]} | Malformed json - use iot2tangle json format

If I get the complete bundle object from the database and send it to HTTP://GW_IP:8080/bundle_data it gets published to the Tangle.

Thanks for reporting! I will address the issue in the open PR #6

This should be fixed in 5d376c4


Add second SSH key for paulhayes

Add a second key for a second machine.

For reference, the way @alext used multiple keys: https://github.com/alphagov/govuk-puppet/commit/e940cf687e405470b12567a4da0c286d22df5e01


Add GitLab Auth

Waiting for #366

does it mean this is solved through http://www.passportjs.org/packages/passport-gitlab/ ?

@ldemailly GitLab is not solved yet, but we have indeed built our auth around Passport. Hopefully it should be easy enough to add new auth providers by following the existing Google and GitHub auth examples that we have implemented.
Some documentation can be found here: https://github.com/spotify/backstage/tree/master/docs/auth
Let us know if you would be interested in giving GitLab auth a go 😄 🚀

Thanks @freben . This is looking good. But gitlab auth seems to have a broken part for the URI
I don't think this is complete yet, I merged from master and the redirect URI seems return part seems broken:
I pulled from master in commit: b92e1533d1930511e0dba2a753db3821d873aafc
after Merge pull request #1494 from daviddyball/master
I got the GItlab id, client secret and host.
I used the localhost backend locally to test the URI
this was generated from the popup
https://gitlab.eng.roku.com/oauth/authorize?response_type=code&redirect_uri=http%3A%2F%2Flocalhost%3A7000%2Fauth%2Fgitlab%2Fhandler%2Fframe%3Fenv%3Ddevelopment&scope=read_user&state=XXX%3D%3D&client_id=XXX

decoded reference:

But this seems wrong. Our gitlab page loads, but the uri response return this:
The redirect URI included is not valid. from the iframe popup for gitlab.

@danztran  any idea about the above?

@timurista What redirect URI did you configure? Usually you need to include the ?env=development bit too

http://localhost:7000?env=development <--- configured for gitlab.
Still getting redirect issue

@timurista it should be http://localhost:7000/auth/gitlab/handler/frame?env=development

Ok yes thanks @Rugvip that works.
However it doesn't appear to change guest status.

Seems like the username information hardcoded to github =>
  const api = useApi(gitOpsApiRef);
  const githubAuth = useApi(githubAuthApiRef);
  const [githubAccessToken, setGithubAccessToken] = useState(String);
  const [githubUsername, setGithubUsername] = useState(String);

I was expecting the word guest to update with details from auth provider.
maybe profile info isn't mapping for gitlab. Checking now. https://github.com/spotify/backstage/blob/c1806a0e2d479615def038ffccb546a140a71f3f/plugins/auth-backend/src/providers/gitlab/provider.ts#L69-L71

OK no that looks good on backend.
getting correct adapted info:
PROFILE ADAPTED {
  email: '...',
  picture: 'https://gitlab...avatar/955/avatar.png',
  displayName: 'Tim Urista'
}

Problem is the email is only id you get from gitlab.
Here's PR working on https://github.com/spotify/backstage/pull/1500

Fixed by #1478 and #1500

The problem was the backstageIdentity wasn't propagating from the backend. We fixed it by parsing the id from the email. Check the MR for the fix

Finally what is the Callback URL. I am finding hard to get this as everything I try leads to The redirect URI included is not valid.


react-router 3.0.0 render bugs.

更具 #4183 和 https://github.com/amazeui/amazeui-touch/issues/114 的反馈信息，我们做了测试，初步确定是react-router 3.0.0的bug.

react-router 3.0.0 push/replace state -> pop

https://github.com/mjackson/history/blob/v3.2.1/modules/HashProtocol.js#L66

@timdorr why？

There is no question here.

push and pop in one time?


Comments on default method declarations

Original reporter: david.waern@
suggested by Satnam.

Motivating example (copied from #567):
{-# LANGUAGE DefaultSignatures #-}
-- | Documentation for Bug
module Bug where

-- | Documentation for Foo
class Foo a where
  -- | Documentation for bar
  bar :: a -> String
  -- | Documentation for bar's default implementation
  default bar :: Show a => a -> String
  bar = show

This currently gets rendered as

It would be nice if we also displayed the Documentation for bar's default implementation docstring somewhere (the logical place seems to be below default bar :: Show a => a -> String).


An error is flooding my console

Hello,
An error is flooding my console, can you fix this ?

What do you mean by wither skull typed NPC ? A wither skeleton sentinel ? A wither sentinel ?
A normal sentinel with a wither skeleton skull equipped ?
Anyway, in all of theses case the answer is yes : we have such sentinels, since we imported them from Sentry. I suppose they are in conlict with a feature you're developping ? How can we fix this ?

None of those. Specifically a Wither Skull NPC. https://hub.spigotmc.org/javadocs/spigot/org/bukkit/entity/EntityType.html#WITHER_SKULL
You somehow (accidentally?) typed an NPC to that and Sentinel doesn't know how to make a skull entity do combat, Sentinel only functions with living typed NPCs currently. (EG player, cow, pig, skeleton, yadda yadda... things that move and do stuff on their own if they are spawned outside of Citizens)

I can't see how we could have made such an NPC, even accidentally, especially since we didn't create any new NPC in the last two months (and the error only appeared recently). Furtheremore, we noticed that the error was only present when we had the new "protected" option set to true in the configuration (the one we asked for in another post). If it is set to false, no error anymore. So I really don't think it's related to a wither skull NPC.

The update from 1.10 to 1.11 in some cases caused entity types to be read wrong - perhaps that happened to you?
That error message is fairly clear that there exists a WitherSkull NPC Sentinel...

Well, there doesn't seem to be this kind of NPC in our Citizens saves.yml (we searched via ctrl+f). Also, the error doesn't happen we set the protected option to false in the config file, even if we're on 1.11...

Mmh, I dug a little deeper and, just to try out some things, and I deleted the only WitherBoss NPC we had. Turns out it was it, but that's weird, it's just a regular witherboss NPC. Since this NPC wasn't so important to us, we juste removed it. If you want to have a look at its configuration for bug-fixing purposes, here it is :
http://pastebin.com/HJRMCHzq

Are you sure it was accurately spawning in-game as a wither boss?

It was before, but in game it indeed didn't appear. Again, I can't really understand why.

Correct entitytype is WITHER. 1.10 saved some entities under wrong names that aren't compatible with the 1.11 name set.

Oh, got it. Thanks !


kubernetes.io/basic-auth: The Kubernetes API does not verify that the…

fix: https://github.com/kubernetes/website/issues/46622

/retitle Fix incorrect statement about Basic auth Secrets
/lgtm
/approve
/sig auth


Remove tsconfig.build.tsbuildinfo from publish

It was published in dist/tsconfig.build.tsbuildinfo but not needed. It's used by TypeScript to cache in-between builds only.

Indeed! Thank you! ❤

Published in v3.0.1 🚀


Get reference build and coverage data according to the configuration.

The following is a test job log for different cases of reference build configuration considered in this implementation.
[Coverage] Using default reference build 'lastSuccessfulBuild' for quality gate 'Modified code lines - Line Coverage - UNSTABLE: 0.000000' since user defined reference build is not set
[Coverage] Obtaining action of reference build '1'
[Coverage] -> Using reference build 'DemoProject #1'
[Coverage] -> Found no reference result in reference build 'DemoProject #1'
[Coverage] Obtaining action of reference build '34'
[Coverage] -> Using reference build 'DemoProject #34'
[Coverage] -> Found reference result in build 'DemoProject #34'
[Coverage] Obtaining action of reference build '${BUILD_NUMBER}'
[Coverage] -> Expanding reference build '${BUILD_NUMBER}' to '43'
[Coverage] -> Can not use current build '43' as reference build
[Coverage] -> No reference build defined for '${BUILD_NUMBER}'
[Coverage] Obtaining action of reference build 'lastSuccessfulBuild'
[Coverage] -> Using reference build 'DemoProject #42'
[Coverage] -> Found reference result in build 'DemoProject #42'
[Coverage] Obtaining action of reference build '${REF_5}'
[Coverage] -> Expanding reference build '${REF_5}' to '42'
[Coverage] -> Using reference build 'DemoProject #42'
[Coverage] -> Found reference result in build 'DemoProject #42'
[Coverage] Obtaining action of reference build '${REF_6}'
[Coverage] -> Expanding reference build '${REF_6}' to '-'
[Coverage] -> No such build '-'
[Coverage] -> No reference build defined for '${REF_6}'
[Coverage] Obtaining action of reference build '${REF_1}'
[Coverage] -> Expanding reference build '${REF_1}' to '1'
[Coverage] -> Using reference build 'DemoProject #1'
[Coverage] -> Found no reference result in reference build 'DemoProject #1'
[Coverage] Obtaining action of reference build '${REF_2}'
[Coverage] -> Expanding reference build '${REF_2}' to '9999999999999999999999999'
[Coverage] -> Invalid build number '9999999999999999999999999'
[Coverage] -> No such build '9999999999999999999999999'
[Coverage] -> No reference build defined for '${REF_2}'
[Coverage] Obtaining action of reference build '${REF_3}'
[Coverage] -> Expanding reference build '${REF_3}' to 'asdfghjkl'
[Coverage] -> No such build 'asdfghjkl'
[Coverage] -> No reference build defined for '${REF_3}'
[Coverage] Obtaining action of reference build '${REF_4}'
[Coverage] -> Expanding reference build '${REF_4}' to ''
[Coverage] -> No such build ''
[Coverage] -> No reference build defined for '${REF_4}'

Close because the requirement changed to support only one reference build.