Relax Codable Router type requirements

Description
Resolves IBM-Swift/Kitura#1235 by relaxing the type requirements on the Codable Router to Decodable for input types, and Encodable for output types.
This enables a corresponding Pull Request in Kitura: IBM-Swift/Kitura#1242
Motivation and Context

See IBM-Swift/Kitura#1235.
The Codable Router was designed with a symmetry in mind for types to be shared between the client and server side (KituraKit <-> Kitura), which requires those types to be both Encodable and Decodable.
In addition, for types that contain purely Codable attributes, conformance to Codable can be synthesized by the compiler.  However, there are cases where conformance must be implemented manually.
For cases where the user only wants to use type safety in a single direction (such as Decodable for a type that will only be received), we currently require them to implement conformance to Encodable (at least dummy conformance to satisfy the type requirement).
How Has This Been Tested?

Checklist:

[ ] If applicable, I have updated the documentation accordingly.
[ ] If applicable, I have added tests to cover my changes.

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   65.63%   65.63%
=======================================
  Files           6        6
  Lines         486      486
=======================================
  Hits          319      319
  Misses        167      167

Flag
Coverage Δ

#KituraContracts
65.63% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b326bf6...8642ede. Read the comment docs.

https://github.com/IBM-Swift/Kitura/pull/1242/commits/d8ebc698f685540aa3002be6bfdd76d21c32f47d relaxes the requirements for the Codable router result handler to permit a (nil, nil) return type.
If this is deemed acceptable, then this PR is ready to go.

https://github.com/IBM-Swift/evolution/pull/11 has been reviewed and approved.


Fix fuse docs and script

Remove the solid requirement for setting of JAVA_HOME in alluxio-fuse script

@madanadit PTAL, thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4428/
Test PASSed.

alluxio-bot, merge this please.

alluxio-bot, cherry-pick this to branch-2.0 please.


Fix handling of user set on the task level

fix #192
Currently support of user set on the task level is partial and confusing. The user is set on the playbook level, but forced to the top-level (playbook's) user if not defined. This is not a good idea, as this way we can't properly use it because it doesn't handle inventory-level user. In fact, the code didn't even use it to pick the user for remote session, but rather used it for SPOT_REMOTE_USER resolution.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

6 of 9 (66.67%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 83.875%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/runner/runner.go
6
9
66.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
2710

Relevant Lines:
3231

💛  - Coveralls


Implement \TextOrMath, @secondoftwo

Partially addressing #1003.

Parser now tells MacroExpander about mode switching.  (This seems preferable to a circular reference between Parser and MacroExpander.)
Implement \TextOrMath
Improve when we switch modes so that this actually works, in all cases except single-symbol arguments.
Add \@secondoftwo to match \@firstoftwo.
Add comments documenting all the conditional macros

Code changes look good to me, but there's something causing the Colorbox and DashesAndQuotes screenshot tests to fail.
ColorBox:

The x should be in typewriter.
DashesAndQuotes:

Three dashes in a row should be an em dash.

Wow, the power of tests. DashesAndQuotes was a nice easy fix pointing out incorrect mode detection for the ligatures (obvious in hindsight).  Unfortunately, the Colorbox issue is exactly the missing part of this PR, switching to text mode for a single-symbol argument (here, x).  So maybe I should try to do that before this PR gets merged; otherwise, this PR would regress behavior a bit.

@edemaine the following seems to be sufficient to fix the ColorBox screenshot test:
        } else {
            // Otherwise, just return a nucleus, or nothing for an optional group
            if (mode) {
                this.switchMode(mode);
            }
            const result = optional ? null : this.parseSymbol();
            if (mode) {
                this.switchMode(outerMode);
            }
            return result;
        }

There may still be other places where we need to switch modes before calling parseSymbol, but we can deal with them in a separate PR as necessary.

@kevinbarabash Thanks for investigating!  This partially fixes the single-symbol support, basically whenever the single symbol is not a macro (not expanded by the MacroExpander).  I'm glad this makes it mergable (backwards-compatible); now I'll open an issue for the remaining challenge of single-symbol macro.


Change user agent

Would it be possible to change the user agent to a standard Windows+Chrome user agent?
Otherwise, it might be possible for Office365 administrators to tell I'm using destreamer.

You could change our user agent but ffmpeg would still use theirs so you'd have to change that one also for it to be ""stealth"".
I'm using that because a willing admin could easily see that you are using destreamer from the unusual requests that miss stuff like tracking cookies and whatnot.
I wouldn't stress about this because I can't believe that someone would be there looking for people downloading videos from the platform to reprimand them.
TLDR: don't worry, very very unlikely that someone cares enough about some downloads


Multiple issues while building with winit backend

I tried to build Neovide using the winit backend, because I can't build sdl2-sys on my system.
While I tried to build it using the winit backend, I encountered multiple issues:

the skulpin/sdl2 feature is enabled, even if the winit feature is chosen, because default-features = true, and skulpin/sdl2 is enabled by default
skulpin currently fails to build with every winit feature they provide. This has to be fixed in skulpin directly

Interesting. Do the skulpin upstream examples fail with the winit features?

Interesting. Do the skulpin upstream examples fail with the winit features?

Yes. I also changed the version and used 0.11 instead of the commit that is provided

Yes. I also changed the version and used 0.11 instead of the commit that is provided

Thats very strange because I just ran winit locally (and discovered a build error with the feature enabled which I fixed and pushed).
I have to run using cargo run --features=winit --no-default-features for the reasons you highlighted. Could you pull from main and try building again? If it fails, could you give me the failure message?

Thats very strange because I just ran winit locally (and discovered a build error with the feature enabled which I fixed and pushed).
I have to run using cargo run --features=winit --no-default-features for the reasons you highlighted. Could you pull from main and try building again? If it fails, could you give me the failure message?

Oh wait. Nevermind. It is not caused by skulpin directly, but neovide fails to build with winit

Oh wait. Nevermind. It is not caused by skulpin directly, but neovide fails to build with winit

Also note: the winit builds are somewhat more buggy than the sdl2 ones currently. I think keyboard handling is somewhat shaky as well as closing is not very smooth currently. I believe the existing bugs should be pretty easy to fix, but you should be aware of them.

Also note: the winit builds are somewhat more buggy than the sdl2 ones currently. I think keyboard handling is somewhat shaky as well as closing is not very smooth currently. I believe the existing bugs should be pretty easy to fix, but you should be aware of them.

Awesome. I just fixed that issue. Should build now

Awesome. I just fixed that issue. Should build now

Closing as I think these the default features problem is expected, and the build error is now fixed.

Closing as I think these the default features problem is expected, and the build error is now fixed.

Yea seems to build now. Just the fix for the features is missing.
But it's an easy fix too, by just disabling default features, and enabling the winit feature:
[features]
winit = ["skulpin/skulpin_winit", "skulpin/winit-23"]

[dependencies]
skulpin = { git = "https://github.com/aclysma/skulpin", branch = "master", default-features = false }

Yea seems to build now. Just the fix for the features is missing.
But it's an easy fix too, by just disabling default features, and enabling the winit feature:
[features]
winit = ["skulpin/skulpin_winit", "skulpin/winit-23"]

[dependencies]
skulpin = { git = "https://github.com/aclysma/skulpin", branch = "master", default-features = false }

No its a good point! I thought it was required, but looking back at it, you're right

No its a good point! I thought it was required, but looking back at it, you're right

let me try it and push a change real quick

let me try it and push a change real quick

hrmmm. I can't seem to figure out what combination of features lets me build sdl2 by default, but not require the no-default-features when building winit. Its very possible that I'm too tired to figure it out tonight.
If you've got an idea for it, I'd love to review and take a PR though!

hrmmm. I can't seem to figure out what combination of features lets me build sdl2 by default, but not require the no-default-features when building winit. Its very possible that I'm too tired to figure it out tonight.
If you've got an idea for it, I'd love to review and take a PR though!


Tab title should indicate the opened document

Instead, it's hard-coded to something like "cosmos-document.json" or "cosmos-stored-procedure.js"

Hi @Microsoft/vscodeazuretools , it seems pretty straightforward once I realized that we can have Regexes in the "when" of Command bindings. So we don't need any more to write "when": "resourceFilename==cosmos-document.json, we can write something in the likes of "when": "resourceFilename=~/(.*cosmosDoc.json)/ and name the tabs (treeItemName)cosmosDoc.json.
There are other, harder solutions (like defining a custom language for cosmos documents and cosmos stored procedures), but, unless you already want to go for them for other reasons, I will start tomorrow working on the solution based on the proposal above. It was much fun even exploring all the alternatives.

Fixed in https://github.com/Microsoft/vscode-cosmosdb/pull/903


Hyperion - OpenElec - LightBerry - TV problem

Hi everyone,
I've recently install my LightBerry on my TV with a OpenElec + Hyperion on my rasp.
I use the HDMI Premium Kit from Lightberry official website.
When I watch a video from my rasp, no problem, leds are good.
When I test a screenshot with the following command :
LD_LIBRARY_PATH=/storage/hyperion/bin /storage/hyperion/bin/hyperion-v4l2 --screenshot
I've this result :
V4L2 width=360 height=288
V4L2 pixel format=UYVY
V4L2 grabber signal threshold set to: {0,0,0}
V4L2 grabber started
V4L2 grabber stopped
So I can found my screenshot,

I've 2 problems, is that screenshot is correct?
And my leds don't do anything when I'm watching my TV.
Thank's for your help.

Which chipset your grabber? STK1160 or UTV007 ?

Hi,
It's STK1160.
Thx

@keo95000 still need help or can be closed?

Yes, can be closed.
Thanks.

Could you close it please? I have no rights. Thanks
Von meinem iPhone gesendet

Am 03.03.2016 um 08:13 schrieb keo95000<EMAIL_ADDRESS>Yes, can be closed.
Thanks.
—
Reply to this email directly or view it on GitHub.


Calculation of next year research is wrong

updating planetary production doesn't update research estimates. Updating research amount calculates leftover resources, but updating production doesn't re-calculate leftover resources for the player.


⚠ Bofrost.at has degraded performance

In 4d7e2cb, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1524 ms

Resolved: Bofrost.at performance has improved in 3ae75dc.


Building sys crates with internal cc builder and bindgen

Do setup from docs.
Generate esp-idf template.
Compile successfully.
Add a crate with generated Rust bindings for a wrapped C library such as ring or littlefs2.
Observe a build failure (fish and bash have the same result).

Is there a mechanism to forward the environment that is compiling the esp-idf to these other sys dependencies?
Template generate config:
cargo generate esp-rs/esp-idf-template cargo
⚠   Favorite `esp-rs/esp-idf-template` not found in config, using it as a git repository: https://github.com/esp-rs/esp-idf-template.git
🤷   Project Name: buildnative-espidf
🔧   Destination: /home/nyrmburk/documents/dev/buildnative-espidf ...
🔧   project-name: buildnative-espidf ...
🔧   Generating template ...
✔ 🤷   Which MCU to target? · esp32c3
✔ 🤷   Configure advanced template options? · true
✔ 🤷   Enable STD support? · true
✔ 🤷   ESP-IDF version (master = UNSTABLE) · v5.2
✔ 🤷   Configure project to use Dev Containers (VS Code and GitHub Codespaces)? · false
✔ 🤷   Configure project to support Wokwi simulation with Wokwi VS Code extension? · false
✔ 🤷   Add CI files for GitHub Action? · false
🔧   Moving generated files into: `/home/nyrmburk/documents/dev/buildnative-espidf`...
🔧   Initializing a fresh Git repository
✨   Done! New project created /home/nyrmburk/documents/dev/buildnative-espid

Build failure with littlefs2:
Crate: https://docs.rs/littlefs2/latest/littlefs2/
Repo: https://github.com/trussed-dev/littlefs2
This crate generates bindings and builds the C littlefs library with the littlefs2-sys crate:
Crate: https://docs.rs/littlefs2-sys/latest/littlefs2_sys/
Repo: https://github.com/trussed-dev/littlefs2-sys
The build.rs file is very simple:
https://github.com/trussed-dev/littlefs2-sys/blob/main/build.rs
use std::env;
use std::path::PathBuf;

fn main() -> Result<(), Box<dyn std::error::Error>> {
    let mut builder = cc::Build::new();
    let target = env::var("TARGET")?;
    let builder = builder
        .flag("-std=c11")
        .flag("-DLFS_NO_DEBUG")
        .flag("-DLFS_NO_WARN")
        .flag("-DLFS_NO_ERROR")
        .file("littlefs/lfs.c")
        .file("littlefs/lfs_util.c")
        .file("string.c");

    #[cfg(feature = "software-intrinsics")]
    let builder = builder.flag("-DLFS_NO_INTRINSICS");

    #[cfg(not(feature = "assertions"))]
    let builder = builder.flag("-DLFS_NO_ASSERT");

    #[cfg(feature = "trace")]
    let builder = builder.flag("-DLFS_YES_TRACE");

    #[cfg(not(feature = "malloc"))]
    builder.flag("-DLFS_NO_MALLOC");

    builder.compile("lfs-sys");

    let bindings = bindgen::Builder::default()
        .header("littlefs/lfs.h")
        .clang_arg(format!("--target={}", target))
        .use_core()
        .allowlist_item("lfs_.*")
        .allowlist_item("LFS_.*")
        .generate()
        .expect("Unable to generate bindings");

    let out_path = PathBuf::from(env::var("OUT_DIR").unwrap());
    bindings
        .write_to_file(out_path.join("bindings.rs"))
        .expect("Couldn't write bindings!");

    Ok(())
}

cargo build results:
$ cargo add littlefs2
...
$ cargo build
...
The following warnings were emitted during compilation:

warning<EMAIL_ADDRESS>Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `riscv32-esp-elf-gcc` installed?

error: failed to run custom build command for `littlefs2-sys v0.1.7`

Caused by:
 process didn't exit successfully: `/home/nyrmburk/documents/dev/buildnative-espidf/target/debug/build/littlefs2-sys-78b36b8617a86ec1/build-script-build` (exit status: 1)
 --- stdout
 OUT_DIR = Some(/home/nyrmburk/documents/dev/buildnative-espidf/target/riscv32imc-esp-espidf/debug/build/littlefs2-sys-0283119dc2df45e7/out)
 TARGET = Some(riscv32imc-esp-espidf)
 OPT_LEVEL = Some(z)
 HOST = Some(x86_64-unknown-linux-gnu)
 cargo:rerun-if-env-changed=CC_riscv32imc-esp-espidf
 CC_riscv32imc-esp-espidf = None
 cargo:rerun-if-env-changed=CC_riscv32imc_esp_espidf
 CC_riscv32imc_esp_espidf = None
 cargo:rerun-if-env-changed=TARGET_CC
 TARGET_CC = None
 cargo:rerun-if-env-changed=CC
 CC = None
 cargo:rerun-if-env-changed=CROSS_COMPILE
 CROSS_COMPILE = None
 RUSTC_LINKER = Some(ldproxy)
 cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
 cargo:warning=Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `riscv32-esp-elf-gcc` installed?
 RUSTC_WRAPPER = None
 cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
 CRATE_CC_NO_DEFAULTS = Some(1)
 cargo:rerun-if-env-changed=CFLAGS_riscv32imc-esp-espidf
 CFLAGS_riscv32imc-esp-espidf = None
 cargo:rerun-if-env-changed=CFLAGS_riscv32imc_esp_espidf
 CFLAGS_riscv32imc_esp_espidf = None
 cargo:rerun-if-env-changed=TARGET_CFLAGS
 TARGET_CFLAGS = None
 cargo:rerun-if-env-changed=CFLAGS
 CFLAGS = None

 --- stderr

 error occurred: Failed to find tool. Is `riscv32-esp-elf-gcc` installed?

warning: build failed, waiting for other jobs to finish...

Adding the compiler bins to my path manually (fish shell):
$ export PATH="$(pwd)/.embuild/espressif/tools/riscv32-esp-elf/esp-13.2.0_20230928/riscv32-esp-elf/bin:$PATH"
$ cargo build
...
error: failed to run custom build command for `littlefs2-sys v0.1.7`

Caused by:
 process didn't exit successfully: `/home/nyrmburk/documents/dev/buildnative-espidf/target/debug/build/littlefs2-sys-78b36b8617a86ec1/build-script-build` (exit status: 101)
 --- stdout
 OUT_DIR = Some(/home/nyrmburk/documents/dev/buildnative-espidf/target/riscv32imc-esp-espidf/debug/build/littlefs2-sys-0283119dc2df45e7/out)
 TARGET = Some(riscv32imc-esp-espidf)
 OPT_LEVEL = Some(z)
 HOST = Some(x86_64-unknown-linux-gnu)
 cargo:rerun-if-env-changed=CC_riscv32imc-esp-espidf
 CC_riscv32imc-esp-espidf = None
 cargo:rerun-if-env-changed=CC_riscv32imc_esp_espidf
 CC_riscv32imc_esp_espidf = None
 cargo:rerun-if-env-changed=TARGET_CC
 TARGET_CC = None
 cargo:rerun-if-env-changed=CC
 CC = None
 cargo:rerun-if-env-changed=CROSS_COMPILE
 CROSS_COMPILE = None
 RUSTC_LINKER = Some(ldproxy)
 cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
 RUSTC_WRAPPER = None
 cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
 CRATE_CC_NO_DEFAULTS = Some(1)
 cargo:rerun-if-env-changed=CFLAGS_riscv32imc-esp-espidf
 CFLAGS_riscv32imc-esp-espidf = None
 cargo:rerun-if-env-changed=CFLAGS_riscv32imc_esp_espidf
 CFLAGS_riscv32imc_esp_espidf = None
 cargo:rerun-if-env-changed=TARGET_CFLAGS
 TARGET_CFLAGS = None
 cargo:rerun-if-env-changed=CFLAGS
 CFLAGS = None
 cargo:rerun-if-env-changed=AR_riscv32imc-esp-espidf
 AR_riscv32imc-esp-espidf = None
 cargo:rerun-if-env-changed=AR_riscv32imc_esp_espidf
 AR_riscv32imc_esp_espidf = None
 cargo:rerun-if-env-changed=TARGET_AR
 TARGET_AR = None
 cargo:rerun-if-env-changed=AR
 AR = None
 cargo:rerun-if-env-changed=ARFLAGS_riscv32imc-esp-espidf
 ARFLAGS_riscv32imc-esp-espidf = None
 cargo:rerun-if-env-changed=ARFLAGS_riscv32imc_esp_espidf
 ARFLAGS_riscv32imc_esp_espidf = None
 cargo:rerun-if-env-changed=TARGET_ARFLAGS
 TARGET_ARFLAGS = None
 cargo:rerun-if-env-changed=ARFLAGS
 ARFLAGS = None
 cargo:rustc-link-lib=static=lfs-sys
 cargo:rustc-link-search=native=/home/nyrmburk/documents/dev/buildnative-espidf/target/riscv32imc-esp-espidf/debug/build/littlefs2-sys-0283119dc2df45e7/out

 --- stderr
 error: unknown target triple 'riscv32imc-esp-espidf'
 thread 'main' panicked at /home/nyrmburk/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bindgen-0.56.0/src/ir/context.rs:531:15:
 libclang error; possible causes include:
 - Invalid flag syntax
 - Unrecognized flags
 - Invalid flag arguments
 - File I/O errors
 - Host vs. target architecture mismatch
 If you encounter an error missing from this list, please file an issue or a PR!
 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

From some other bugs I read here, it seems like bindgen might be trying to use some host resources instead of the cross compile ones?
Trying the same for the ring crate is extremely siimilar:
Crate: https://lib.rs/crates/ring
Repo:https://github.com/briansmith/ring
*new terminal with default env variables*
$ cargo remove littlefs2
...
$ cargo add ring
...
$ cargo build
The following warnings were emitted during compilation:

warning<EMAIL_ADDRESS>Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `riscv32-esp-elf-gcc` installed?
warning<EMAIL_ADDRESS>Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `riscv32-esp-elf-gcc` installed?

error: failed to run custom build command for `ring v0.17.8`

Caused by:
  process didn't exit successfully: `/home/nyrmburk/documents/dev/buildnative-espidf/target/debug/build/ring-6ae3434f56ff74da/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=RING_PREGENERATE_ASM
  cargo:rustc-env=RING_CORE_PREFIX=ring_core_0_17_8_
  OPT_LEVEL = Some(z)
  TARGET = Some(riscv32imc-esp-espidf)
  OUT_DIR = Some(/home/nyrmburk/documents/dev/buildnative-espidf/target/riscv32imc-esp-espidf/debug/build/ring-513392959b65266a/out)
  HOST = Some(x86_64-unknown-linux-gnu)
  cargo:rerun-if-env-changed=CC_riscv32imc-esp-espidf
  CC_riscv32imc-esp-espidf = None
  cargo:rerun-if-env-changed=CC_riscv32imc_esp_espidf
  CC_riscv32imc_esp_espidf = None
  cargo:rerun-if-env-changed=TARGET_CC
  TARGET_CC = None
  cargo:rerun-if-env-changed=CC
  CC = None
  cargo:rerun-if-env-changed=CROSS_COMPILE
  CROSS_COMPILE = None
  RUSTC_LINKER = Some(ldproxy)
  cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
  cargo:warning=Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `riscv32-esp-elf-gcc` installed?
  RUSTC_WRAPPER = None
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = Some(1)
  cargo:rerun-if-env-changed=CFLAGS_riscv32imc-esp-espidf
  CFLAGS_riscv32imc-esp-espidf = None
  cargo:rerun-if-env-changed=CFLAGS_riscv32imc_esp_espidf
  CFLAGS_riscv32imc_esp_espidf = None
  cargo:rerun-if-env-changed=TARGET_CFLAGS
  TARGET_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  cargo:warning=Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `riscv32-esp-elf-gcc` installed?

  --- stderr

  error occurred: Failed to find tool. Is `riscv32-esp-elf-gcc` installed?

warning: build failed, waiting for other jobs to finish...

Adding the compiler path for ring hit some compilation failures that are outside the scope of this issue. However if it succeeded, I think the following bindgen would fail for the same reason as littlefs2.

In most situation the "simplest" way is let esp-idf-sys handle the bindgen creation for you. In case of your littlefs example, its probably also good to use a forked version that is known to work on esp-idf. It already exist on the esp-idf component registry, so you could add it to the build process described  here. That could give you a little-fs sys module inside the esp-idf-sys. You would than go and instead of using the -sys module from littlefs2, directly use the generated bindgens from us. In other words the littlefs2 crate would not use its own -sys module but the one you now build.
Other than that we propagate a bunch of information in the build script inside esp-idf-sys that gets produced by the embuild crate for consumption in downstream crates. This can be found here and you see it used in esp-idf-hal/svc buildscript.
Overall the creation of FFI bindings and the building of a C library into a static lib and including it are two separate things.
While not exactly the same but a similar case can be made about the rust bindings for the lvgl crate. I didn't look recently into it but i know that it can work with our system, without even knowing that we exist by essentially doing the heavy lifting by itself. They also generate a static C library and generate bindings off of that.

The same issue occurs with wamr-rust-sdk.
I'm not sure if this is related, but overriding LIBCLANG_PATH by sourcing export-esp.sh seems to interfere with the compilation of the regular x86_64-unknown-linux-gnu target when bindgen is used by crates:
  thread 'main' panicked at /home/alix_anneraud/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bindgen-0.69.4/lib.rs:899:13:
  assertion `left == right` failed: "x86_64-unknown-linux-gnu" "x86_64-unknown-linux-gnu"
    left: 4
   right: 8

This issue did not occur before I updated to version 1.79.0 of the esp Rust toolchain.


Remove association overrides

@bkroeker Do you remember why specifying the primary key was needed like this? There's no tests that are failing, and the current implementation is causing issues for me in Rails 7.1

@bkroeker what scares me is that the change was made 11 years ago, so I'm afraid of what it might break:
https://github.com/bkroeker/temporal_tables/commit/9d9ad8e7627274a614b5bb3426754bca3c10a187


Salesforce Data Cloud connector

Description
The data Cloud connector is not working as expected - I followed the tutorial here
https://help.salesforce.com/s/articleView?id=sf.c360_a_set_up_dbeaver_connected_app.htm&type=5
I added the clientId and ClientSecret in the driver properties - added the user and passwort and it gives me authentication failure. Which is not correct I tested extra the login details and they work.
DBeaver Version
Cummunity Edition <IP_ADDRESS>407071610
Operating System
Macos 14.5 M1
Database and driver
Salesforce Data Cloud, CDP driver https://github.com/forcedotcom/Salesforce-CDP-jdbc/releases/tag/v1.19.7
The latest driver wa not automatically downloaded
Steps to reproduce
No response
Additional context
No response

Driver properties

We would kindly ask you to reproduce the issue once again. After you reproduce the issue, please send us the DBeaver log files.
The log files are generated automatically and called .log and .dbeaver-debug.log exactly. Hhere is our wiki page on this matter: dbeaver.com/docs/wiki/Log-files/#log-files

Also could you tell me your server version? You can get this information by clicking Test connection... button in the Connection configuration dialog.

The test connection does not give my any of those - just user authentication failure

debug.tgz
I didn't have a .log only a debug log file - this is attached.

Thank you.

Just as a note you have to add dataspace property from your dataspace and also change from login.salesforce.com to your domain then it is working. No bug on Dbeaver side

Thank you for update!


Draft: Add better error handling to Page.add_child() and Page.add_sibling()

What's the problem?
When using Page.add_child(), django-treebeard increments the numchild value of the parent page and saves it before attempting save the new page. If saving the new page results in an error, the parent page is left with a numchild value higher than it should be. If you then (later or immediately) try to call Page.add_child() again, this will result in the following error, which is hard to reason about:
File "/app/.global/lib/python3.8/site-packages/treebeard/mp_tree.py", line 1091, in add_child
    return MP_AddChildHandler(self, **kwargs).process()
  File "/app/.global/lib/python3.8/site-packages/treebeard/mp_tree.py", line 386, in process
    newobj.path = self.node.get_last_child()._inc_path()
AttributeError: 'NoneType' object has no attribute '_inc_path'

Wrapping the parent.add_child() in a transaction can help in these situations. However, this information doesn't appear to be provided anywhere in the Wagtail or django-treebeard documentation.
To add to the confusion, if you have ever wrote code that attempts to add a series of pages as children to the same page, you'll notice that even if you wrap each attempt in a transaction and catch any exceptions as you go, the old AttributeError: 'NoneType' object has no attribute '_inc_path' will soon raise it's ugly head should any problems occur. The cause? Even though the numchild change is not commited to the database, the attribute value is still updated in memory, meaning it is still one ahead than it should be. You can get around this by calling parent.refresh_from_db() whenever an exception it raised, but again... this doesn't appear to be clearly documented anywhere, and it feels a little bit wasteful... especially if the number of pages to be added is large.
What's the solution
Firstly, I thought it'd be good for add_child() to take care of in-memory numchild tidy-up when something goes wrong. Ultimately, I think having the attribute value always reflect the database value will cause less confusion overall.
I also thought it would be good to wrap the behaviour in a transaction by default, protecting devs from an add-related page tree issues. However, doing that by default appears to wreak havok with the test suite (no doubt something to do with the extra transactions that Django wraps around most tests), so I have made it opt-in for now.
In making these changes to add_child(), it felt like an obvious win to update add_sibling() too, for consistency, despite not having witnessed issues with that first-hand.
The PR will remain in a draft state until I have added tests and have confirmed that everything works as expected. I'd also like to investigate what can be done about using the transactions by default.
Some side-benefits

Type hints and other improvements to method signatures
Improved/more relevant docstrings.
Methods added to reference docs, making them easier for developers to find.

[x] Do the tests still pass?[^1]
[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ ] For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.
[^1]: Development Testing

Thanks @ababic!
I'm unsure if we should add separate methods for this, it's unlikely most developers will know about them and remember which version to use at which times. I'd really like us to keep these core interfaces as simple as possible.
Is this something that should be fixed in the standard add_page and add_sibling? Or maybe this would be better as a parameter to those methods instead of separate methods?

Thanks for the feedback @kaedroho!

I'm unsure if we should add separate methods for this, it's unlikely most developers will know about them and remember which version to use at which times. I'd really like us to keep these core interfaces as simple as possible.

I share your concerns here too, @kaedroho. Ultimately, I felt it best to leave the existing method alone, because Wagtail isn't yet overriding either, and I didn't want to unintentionally impose any restrictions there, should we want to do something more custom in future. We definitely don't want to force this behaviour either, things can get weird when there are multiple levels of transaction wrapping.
I see these methods something you'd knowingly choose to use, under the right circumstances. And I'd be happy to add documentation around this to help with making that choice.

I see these methods as something you'd knowingly choose to use, under the right circumstances. And I'd be happy to add documentation around this to help with making that choice.

Adding more core methods and documentation increases the learning curve for new users. This API needs to be as simple as possible I think and adding new variants of existing methods adds some extra nuances that developers need to understand to use these APIs effectively.
I think if there's a bug with the existing API, we should fix that existing API instead of creating a new one. If there must be two variants, I'd prefer always doing the safest, most secure thing by default, and have a switch for those that know what they are doing. (the _atomic suffix implies the variant is the safer option in this case?)

@kaedroho thanks again for the reply. This kind of early feedback is really useful. Sounds like doing this with the existing methods is the way to go then. I can do that :)

Okay, good news! Looks like the test issues I was originally seeing when forcing transactions are no longer happening :) I can only surmise that those issues were down to something else that I was doing wrong. I should be able to focus on test writing now.


Helm CLI completely ignores SemVer2 metadata when using --version for install and upgrade commands

Hi,
I am experiencing weird behavior with helm install/upgrade --version. Looks like it does not support completely exact match on versions with provided metadata, example: chart-0.1.2+v1
If there will be any other chart with the same major.minor.patch version one of them will be picked randomly.
This is really weird and inconsistent behavior.
With the following versions of chart in the repo:
chart-0.1.2
chart-0.1.2+v1
chart-0.1.2+v2

when I execute helm search --versions chart couple times in a row, then I see that list is ordered randomly, and ordering differs between the calls.
Also if I supply version with metadata I would expect this exact one to be picked for installation and error about missing version if not exists, however:

I could pass anything after + sign (even non-existing one), then helm will pick randomly one of the X.Y.Z(|\+.*) version for upgrade/install. This is weird.
When I pass X.Y.Z version to --version it will also pick randomly one of the X.Y.Z(|\+.*). This also is not normal.

Would it be possible to:
a) get constant ordering (alphabetical or whatever) on helm search --versions which will at least guarantee that using helm upgrade chart repo/chart command will not randomly pick some chart version.
b) if not --version maybe some other parameter --strict-version or whatever which will take into consideration +metadata part too.
Output of helm version:
Client: &version.Version{SemVer:"v2.16.10", GitCommit:"bceca24a91639f045f22ab0f41e47589a932cf5e", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.16.10", GitCommit:"bceca24a91639f045f22ab0f41e47589a932cf5e", GitTreeState:"clean"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.0+d4cacc0", GitCommit:"d4cacc0", GitTreeState:"clean", BuildDate:"2020-08-18T05:38:34Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.0+d4cacc0", GitCommit:"d4cacc0", GitTreeState:"clean", BuildDate:"2020-08-18T05:38:34Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
OpenShift 3.11

I noticed that you’re using helm 2. At this point, we are no longer fixing bug reports for helm 2; only security fixes are accepted at this time.
That being said, if you can reproduce this issue with helm 3, we can start investigating further.
Thanks!

On another note, this appears to make some sense. As per the Semver v2 specification on build metadata:

Build metadata MUST be ignored when determining version precedence. Thus two versions that differ only in the build metadata, have the same precedence. Examples: 1.0.0-alpha+001, 1.0.0+20130313144700, 1.0.0-beta+exp.sha.5114f85, 1.0.0+21AF26D3—-117B344092BD.

From https://semver.org/#spec-item-10.
So this appears to be correct behaviour. Neither version has precedence over the other.
That being said, I do know that there have been patches provided in the past for Helm to compare the version identifier exactly if no semver range is provided (like in your case with helm install/upgrade --version chart-0.1.2+v1).
However, because this is a duplicate of https://github.com/helm/helm/issues/7563, I'm going ahead and closing this as we've already got another ticket in the queue describing this bug, and we want to keep related discussions in one ticket.
Thank you for your report.


in-line representation

I'm expert of README.md file :)
ping @Ocramius

Please keep the same format as https://raw.githubusercontent.com/zendframework/zf2/master/README.md

Fixed.. Can you think to use the same format in your PRs in other zf-components?
Thanks

Merged, thanks!
master: zendframework/zend-diactoros@8f8d3e2f5be97e92aa7caf262b2624db5e61521c
develop: zendframework/zend-diactoros@3450fc1ae5936347816324e8c625b1558d534d16

When develop branch exists README should updated


Hashing is inconsistent

Sometimes mixLast is used and sometimes it isn't.

Also, both class org.clulab.odin.Mention has argumentsHashCode() and org.clulab.odin.serialization.json has argsHash() which probably shouldn't be duplicated.

These aren't being changed just now because that would complicate regression testing.


User associatable API keys

For service applications using the Lemur API we should allow API keys to be created and allow for multiple API keys to be in use at any one time. This will help with the rotation of keys as required by the service application.
cc @andrewachen

Where is this along? Would it be possible for me to take a look at this? This is something we'd love to have, but I don't want to step on anyone's toes if it's already being actively worked on.

@SecurityInsanity I haven't started work on this just yet, but would love to see it included as well. Let me know if you have any questions.

Hey @kevgliss ,
Finally starting to take a look into this. It looks like we're already generating JWTs for the users. I'm thinking just re-using this logic for API Keys. Does this sound alright to you? Or were you thinking of something else when filing this ticket?

I think JWT would work fine. Would we just make them very long lived? I think we would also need another table/column containing the list of tokens that were issued/revoked, adding in the necessary checks beyond simple signature validation.

Sorry for the delay on response for this. I thought I had responded, but noticed today I actually never had.
I was thinking of having a configurable timeout. Then for tracking when certain issues where issued/revoked we could simply store an id field inside the JWT, that we can use for determining if it's been revoked, etc.

Sounds good to me.

Figured I'd post an update. I've got the backend for API Keys working + Tested. I'm now digging into the angular side of things, and should hopefully have a PR up this week.


Memory leak

The CPU memory goes larger continuously as training until it explode.

Hi, are you training on CPU or GPU? How long did you train? Can you give more details of your environment (os, tensorflow version, ...). I trained for multiple days on different machines and it didn't crash due to a leak.

Training with GPU, GTX Titan 1080. Ubuntu 16.04, tensorflow 1.2. During training, the GPU memory didn't explode, but the CPU memory increase continuously until 100%

I noticed that if I set the " tf.app.flags.DEFINE_boolean('debug', True)", the memory consumption will increase fast.

It enables recording and writing images to tensorboard, but i don't really know why it should cause a memory leak. On what timescale does the memory increase?

Is the 30GB with or without the debug Flag? The flag isn't meant to be used during full training. Could you maybe share your complete config.ini file with me?

The 30GB with the debug Flag, this is the config.ini.
config.ini.txt

As I was not able to reproduce, I am closing this for now.


Tutorial    Step 5: The View Functions

@app.route('/add', methods=['POST'])
def add_entry():
if not session.get('logged_in'):
abort(401)
g.db.execute('insert into entries (title, text) values (?, ?)',
[request.form['title'], request.form['text']])
g.db.commit()
flash('New entry was successfully posted')
return redirect(url_for('show_entries'))
g.db.execute('insert into entries (title, text) values (?, ?)',
[request.form['title'], request.form['text']])
The second argv should be a tuple
g.db.execute('INSERT INTO entries(title,text) VALUES(?,?)',(request.form["title"],request.form["text"]))

I suppose either is fine.

btw, you can fence code blocks in triple backticks to format them as code. see https://guides.github.com/features/mastering-markdown/

There's nothing wrong with using a list here.  Using a tuple, while possibly "nicer" in this situation, doesn't change its behavior.  New developers tend to misplace the parentheses, especially when it's a 1-tuple, which is easier to spot with list brackets.


Question: Turndown vs Showdown

I just want to ask you for tip.
I have a blog app that supports only storing of html files on server side but I want to make an editor with Markdown syntax.
One option is to find an editor with already implemented button in editor Switch to Markdown/Visual editing. Maybe you can recommend any?
Another option is to do the conversion myself. So I found Turndown and Showdown and now confused what is a difference between them. As far I understood the Showdown is bidirectional. Maybe you can explain pros/cons of them?
Thank you.
P.S. just found Dillinger editor that looks like feet my needs

If you want to convert markdown to HTML, use Marked.js
If you want to convert HTML to markdown, use Showdown (it has more Github stars lol)


(WIP) Myst parser: .md + {eval-rst} support

re: #30
Naïve eval-rst directive support.

Support .md
Adds testdata/using_the_shapereader.md
Tests using_the_shapereader.md in test_cartopy
Support for {eval-rst} and tests
_DIRECTIVE_RE improvements - Use verbose, named expression for readability (cherry-picked and rebased in via #33, #34)

@thisch I will ping you when this is ready to look at
Have not hand tested yet.  I will build a very robust testsuite for it

Awesome! Thx a lot.

@thisch feel free to let tests run

@tony  thx a lot for all your PRs. I've just enabled the CI pipeline.

@thisch I suppose if you want you could cut a 0.4.1 release with the latest regex changes
I assume this PR, if merged (I still need to test it by hand and QA it more intensively) will be a bigger version bump, e.g. 0.5.0/0.6.0

@thisch I may take a fresh stab at this non-docutils PR now that I am familiarized with doctest 👍
This approach, if pulled it off, would be easier to merge, preserve existing features, and have 0 extra dependencies.


Error on change focus when there are no windows on the monitor

The error message below appears when the focus is on a monitor without windows and you try to change window using the command Miguru.FocusWindow("next")

Thanks 🙂


Remove the KeyCode.Unknown

I propose to remove the KeyCode.Unknown which aren't used by the drivers now, since they return KeyCode.Null if KeyChar is '\0'. Thus avoids using the prior to check if a key is valid or not and only compare if it's KeyCode.Null.

I agree.

Note that Key already doesn't have Unknown.

I think it should also been removed from the KeyCode enum.
Originally posted by @BDisp in https://github.com/gui-cs/Terminal.Gui/issues/2927#issuecomment-1858909499

@tig I also have another suggestion that could be done in this issue or open a new issue if you want. Key.IsValid is actually relying => KeyCode is not (KeyCode.Null or KeyCode.Unknown); After removing the KeyCode.Unknown which I enterally agree, it will only relying on => KeyCode is not KeyCode.Null; which could be only be a KeyCode.ShiftMask, KeyCode.AltMask or KeyCode.CtrlMask. These modifiers keys alone or combined without a non modifier key shouldn't be used because I think don't make no sense, but I could be wrong. So my suggestion is change to IsValid => KeyCode != KeyCode.Null && new Key (KeyCode & ~KeyCode.AltMask & KeyCode & ~KeyCode.CtrlMask & KeyCode & ~KeyCode.ShiftMask) != KeyCode.Null;
What do you think?

@tig I also have another suggestion that could be done in this issue or open a new issue if you want. Key.IsValid is actually relying => KeyCode is not (KeyCode.Null or KeyCode.Unknown); After removing the KeyCode.Unknown which I enterally agree, it will only relying on => KeyCode is not KeyCode.Null; which could be only be a KeyCode.ShiftMask, KeyCode.AltMask or KeyCode.CtrlMask. These modifiers keys alone or combined without a non modifier key shouldn't be used because I think don't make no sense, but I could be wrong. So my suggestion is change to IsValid => KeyCode != KeyCode.Null && new Key (KeyCode & ~KeyCode.AltMask & KeyCode & ~KeyCode.CtrlMask & KeyCode & ~KeyCode.ShiftMask) != KeyCode.Null; What do you think?

On Windows (and maybe other platforms in the future) it is possible to detect a "Shift Key" (Shift, Ctrl, or Alt) press. We should not arbitrarily prevent devs from doing so.
So, as long as the driver doesn't include the CtrlShift mask with the "Ctrl" key event, I agree.
Here I

Pressed and released "Ctrl"
Pressed and released "Ctrl"
Pressed and released "Enter"
Pressed "Ctrl", Pressed "U", Released both

Also, in the new world, this is better syntax for what you suggest:
	/// <summary>
	/// Indicates whether the <see cref="Key"/> is valid or not. Invalid keys are <see cref="Key.Empty"/>,
	/// and keys with only shift modifiers.
	/// </summary>
	public bool IsValid => this != Empty && (NoAlt.NoShift.NoCtrl != Empty);

Unit tests:
	// IsValid
	[Theory]
	[InlineData (KeyCode.A, true)]
	[InlineData (KeyCode.B, true)]
	[InlineData (KeyCode.F1 | KeyCode.ShiftMask, true)]
	[InlineData (KeyCode.Null, false)]
	[InlineData (KeyCode.ShiftMask, false)]
	[InlineData (KeyCode.CtrlMask, false)]
	[InlineData (KeyCode.AltMask, false)]
	[InlineData (KeyCode.ShiftMask | KeyCode.AltMask, false)]
	public void IsValid (Key key, bool expected) => Assert.Equal (expected, key.IsValid);

I can have a PR ready for this in a few min. Unless you already have one ready.

I can have a PR ready for this in a few min. Unless you already have one ready.

I'm trying to fix the VkeyPacketSimulator and if you have your ready please submit it, thanks. May help me fix this better.

Almost ready.


Replace PyYAML by ruamel.yaml

Wouldn't it be a good idea to drop PyYAML and replace it by the actively developed ruamel.yaml? It support YAML 1.2 and is a fork of the original PyYAML. It looks like it is a drop-in replacement (at least it was in my personal project :smile: ).
I'll be happy to submit a pull request.

Do you have the history behind ruaemel.yaml, reasons for forking etc? Has there been any effort to merge back features into pyyaml?

I think this thread sums it up pretty well: https://bitbucket.org/xi/pyyaml/issues/59/has-this-project-been-abandoned. The original author of PyYAML does not actively maintain the project anymore, doesn't respond to emails etc., which makes it impossible for others to contribute.

@Roysten I will Not just drop pyyaml to replace it with anything else. But what i can do is to add a import test/check if ruamel is installed as a dependency and use that over pyyaml but allways default back to pyyaml becuase pyyaml is still so common in the wild and i have never seen a project that has ruamel.yaml as either supported or default implementation for loading yaml files.

@Roysten This branch implmenets this behaviour https://github.com/Grokzen/pykwalify/tree/feature/ruamel.yaml, Look it through.

@Grokzen Wow, I was not expecting it implemented this quicky! Looks great!

@Roysten The change was very small and easy to implement :D

#59 Is the MR that will add this feature

@Roysten Feature will be part of next release.


Divide two numbers

Title of article
Write a C# programme to divide two numbers.
Additional information
Input  : 4 2
Output : 2

Input  : 2 4
Output : 0.5

Code of Conduct

[X] I have read and agree to the Codinasion project's Code of Conduct

@harshraj8843  could you please assign this task to me i would love to contribute to this issue.

Hey @piyush-sri
Thanks for showing your interest in this open source project 😃


Adding localhost to the list of alt_names

When attempting to connect to the docker api from the machine itself,
the TLS verification of the certificate checked against the public
IP address of the primary interface.  This is undesirable on hosts
which have NAT rules that block access to that address by default.
Adding "localhost" to the list of alt_names allows the cert to be
verified and connections to localhost (either <IP_ADDRESS> or [::1]) to
the port to pass verification. Otherwise one would need to disable
verification just to connect to the local docker instance.

+1

@cthulhuology can you rebase?
@docker/machine-maintainers wdyt?

Seems reasonable and is a needed step to any sort of NAT-only mode for VirtualBox - given a rebase I'm happy to merge.

@docker/machine-maintainers Here's a rebased PR https://github.com/docker/machine/pull/2065

#2065 has been merged.


Open an issue in a tab

A pull request can be opened in a local tab. It would be great if the same was supported for issues.
Apologies if this is a duplicate, I did a search but haven't found anything related.

duplicate of https://github.com/microsoft/vscode-pull-request-github/issues/2229


Change MaskPattern.Patterns to a list

This code changes MaskPattern.Patterns to a list instead of a dictionary to hopefully make some code easier to understand.
Existing code
The index is stored zero-based within the QR code, and I was confused by this code here:
https://github.com/codebude/QRCoder/blob/14a83f2e1c2d946e54db72cd91f3e420630e1f71/QRCoder/QRCodeGenerator.ModulePlacer.cs#L130
followed by
https://github.com/codebude/QRCoder/blob/14a83f2e1c2d946e54db72cd91f3e420630e1f71/QRCoder/QRCodeGenerator.ModulePlacer.cs#L163
and
https://github.com/codebude/QRCoder/blob/14a83f2e1c2d946e54db72cd91f3e420630e1f71/QRCoder/QRCodeGenerator.ModulePlacer.cs#L175-L176
which is actually correct because of
https://github.com/codebude/QRCoder/blob/14a83f2e1c2d946e54db72cd91f3e420630e1f71/QRCoder/QRCodeGenerator.ModulePlacer.cs#L185
So since the dictionary is unnecessary, I converted it to a list.  It should be faster too but I didn't check.
New code
Now we start with this:
https://github.com/codebude/QRCoder/blob/d48a2fb2d2b95fce2cdd35dfacdff68544e60c61/QRCoder/QRCodeGenerator.ModulePlacer.cs#L118-L120
and uses are simple:
https://github.com/codebude/QRCoder/blob/d48a2fb2d2b95fce2cdd35dfacdff68544e60c61/QRCoder/QRCodeGenerator.ModulePlacer.cs#L132
https://github.com/codebude/QRCoder/blob/d48a2fb2d2b95fce2cdd35dfacdff68544e60c61/QRCoder/QRCodeGenerator.ModulePlacer.cs#L165
https://github.com/codebude/QRCoder/blob/d48a2fb2d2b95fce2cdd35dfacdff68544e60c61/QRCoder/QRCodeGenerator.ModulePlacer.cs#L187

I'll need to fix conflicts here

Can you also have a look on the merge conflicts?


rstats is causing a full document layout on each update

On your example pages (as well as my own experiments), I'm seeing a full document layout in Chrome:

It's only taking around 0.5ms, but I still find it strange that rstats is forcing the entire document to relayout. And in terms of a single frame, that's almost 3% of the total time allotted for 60fps. Obviously rendering rstats is not free, but it should ideally use as little time as possible.
Thanks for making rstats, it's been really cool to use!

@spite So... nearly 10 years later! Today I discovered what was causing the layout thrashing, after recently including rstats in a new project.
text-align: right!!
The Chrome devtools > Rendering have a Layout Shift Regions checkbox.

It seems that whenever a number changes digits, whether it's 0 -> 0.0 or 0 -> 10, etc, text-align: right causes a layout shift! The fix is text-align: left.
Hope you're well!


It does not work on KDE Neon

Hi
I tried to install it with cargo install ludusavi. But it does not worked.

Hi! As the error message says, you're using Rust 1.57.0, but you need Rust 1.59 or higher. Ludusavi generally requires a pretty new version of Rust.


Zoom in/out with scroll wheel has no effect on Linux/Firefox

With Firefox 86.0.1 (and probably older versions, the issue is here since a while) on Linux (X11), the Ctrl+scroll wheel up/down has no effect (unless the focus is on the zoom bar, which then applies the native Firefox zoom).
No idea if that's related, but this can be observed in the errors:

Probably duplicate of https://github.com/excalidraw/excalidraw/issues/3042. We'll need to normalize the scroll delta since Firefox uses really tiny steps which end up being rounded to 0 in our case it seems.

Probably duplicate of #3042. We'll need to normalize the scroll delta since Firefox uses really tiny steps which end up being rounded to 0 in our case it seems.

I was actually initially going to reply there but AFAICT the reporter observe an unusual behaviour, while I can't make any change at all. (Note: Ctrl++ and Ctrl+- work as expected, and the Ctrl+Scrollwheel works on chromium)

The scrolling on Firefox should work normally. I've tested on Firefox 93 on Fedora and Firefox 94 Windows 10. If the issues persist, let us know!


Increment version for billing releases

Increment package version after release of Azure.ResourceManager.Billing

API change check
API changes are not detected in this pull request.


Exceptions

This is going to be weird question, but is there a way for me to simply exclude 2 groups?
I have 2 groups that are teams groups and as soon as people get removed, it dings everyone in my company.
I have the object ID of the 2 groups, is there a simple line of code i could add to exclude them?
Really appreciate your help.  I've been trying for hours. lol

Which script are we talking about here, the Remove_User_All_Groups.ps1 one? You can add an exception within the foreach loop (line 130), something like:
foreach ($Group in $Groups) {
if ($Group.DisplayName -eq "Team1") { continue }
...
}
It's better to use a unique-valued identifier, such as the ExternalDirectoryObjectId, but DisplayName should also do. Here's example with the former:
foreach ($Group in $Groups) {
if ($Group.ExternalDirectoryObjectId -eq "GUID") { continue }
...
}

I can't believe how fast you got back to me.  Literally spent the last 2 hours pulling people in who know a little about the code.  LOL.  That fixed it!!!!!  Thank you so much!!!!  This is going to make my life a lot easier!


Implement guild role subscriptions

Checklist

[x] I have run nox and all the pipelines have passed.
[ ] I have made unittests according to the code I have added/modified/deleted.

Related issues
Closes #1452

Tests need fixes proposed by #1551. Will rebase and push the tests when that one is merged


Liana's Maze Game :)

Your checklist for this pull request
Author name
Author: I.K.

About your game
What is your game about? This is a maze game where two aliens play hide and seek in a maze. You are the purple alien and your objective is to run through the maze playing hide and seek with John, a green alien. Have fun!

How do you play your game? Press WASD to move.

Code
Check off the items that are true.

[ x] The game was made using the Sprig editor.
[x ] The game is placed in the in the /games directory.
[x ] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x ] The game runs without errors.
[x ] The name of the file/game contains only alphanumeric characters, -s, or _s.
[ x] The game name is not the same as the others from gallery

Image (If an image is used)

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

Hi,
Thanks for your checking out my game!
I saw your feedback. Sorry about that, I thought maze games were
acceptable.
I’m just wondering what would I have to do? Is my game fully rejected or is
it still fine if I make some adjustments and add new features to the game?
For example, an enemy sprite that chases the player through the maze,
adding a time limit.
Would this be acceptable? Or would I have to completely start over?
Thank you for your time!
On Tue, Aug 20, 2024 at 7:12 PM Marios Mitsios @.***>
wrote:

@.**** requested changes on this pull request.
Cool game so far but in order to be on par with the quality standards we
expect in order to publish your game to the gallery and get the sprig
hardware grant, it would be really great for you to introduce new game
mechanics to differentiate it from other mazes
—
Reply to this email directly, view it on GitHub
https://github.com/hackclub/sprig/pull/2192#pullrequestreview-2249259850,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKLZZYY7VBDH74JLBAAHX3TZSPEPDAVCNFSM6AAAAABMYS5U4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBZGI2TSOBVGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi yeah! That is totally acceptable, I just want a new feature or two to make it more unique!


[REQUEST] Real Debrid Support

Real Debrid or other Debrid providers may be a great security addition.

This is in development. Can't say when, but I'll try to comment here to update you when we release a version with Debrid support

Great to know, will keep an eye on it. Thanks

Closing this since Real Debrid has been implemented on the main branch.


docs: add basic remix documentation

This closes https://github.com/better-auth/better-auth/issues/9#issuecomment-2380416415
I saw that there was no documentation available for Remix. Since it's the framework I primarily use, and after playing around for a while, I thought it would be helpful to contribute by adding some basic examples showcasing its usage.
Let me know if I need to improve something or there's something else I can help with!

Sorry about that import, I didn't saw it.

Sorry about that import, I didn't saw it.

no worries this looks good. If you can please add remix section on the integration section. See the other framework docs as an example.

Sure, working on it right now!

@Kinfe123 @Bekacru Let me know what you think!

Saw the error in the CI pipeline and synced my branch with the repo branch, let me know if it works now.

Saw the error in the CI pipeline and synced my branch with the repo branch, let me know if it works now.

thanks! good job. please run pnpm lint:fix and I'll merge it.

Saw the error in the CI pipeline and synced my branch with the repo branch, let me know if it works now.

thanks! good job. please run pnpm lint:fix and I'll merge it.

Done!


{{!< default}} syntax

Hey there, this is more of a question than an issue
I'm pretty new to handle bar, I'm curious where does this {{!< default}} syntax come from? (I didn't find it in the official handlebar site. How was it supported?
E.g.
https://github.com/TryGhost/Casper/blob/7e3e891338b3541ca5cc10e320e9fac15838532f/page.hbs#L1-L3
Thanks!

Hey @dingran, Ghost uses express-hbs as the template engine, and {{!< LAYOUT}} is a special syntax of the library for layouts. You can read more about this here.


Use correct image to calculate tracks in sample space

Fixes #38

Looks good overall, with a couple of suggestions. Is there a unit test of analyse_track_anatomy that can be added to make sure this doesn't break in the future?

A unit test wouldn't have caught this unfortunately. The wrong data was passed into it from initialisation of the widget. I've added a specific test for this function anyway.

@dstansby the only test I can think of to prevent something like this is a full end-to-end test of the entire users workflow (in both atlas and sample space). Curious as to your thoughts, but I'm not sure adding this is helpful as it's likely to be very sensitive to any changes we make to any part of the code.


Canonical URL is logged instead of actual URL

Segment should not temper with the URL and replace it with Canonical tag value.
Note that Canonical is for SEO hinting, it has nothing to do with the actual page load.
Segment logs have nothing to do with SEO.
Also, it's broken as it's not recognizing relative Canonical URL's.
Please change this or at least give an option on Source level whether this should be enabled.
No, I don't want workaround in a form of passing {url: } in .page() - all event tracking is affected, I don't want to override everywhere and keep track of that.

Same problem here at www.cliengo.com?utm_plan=test
Any solution?

@mkukawski Yes, segment is Canonical URL. We recently released a feature called middleware that allow changing the payload. You can probably write a source middleware ( a JS function ) that changes the way URL is tracked. More info on Middleware:
https://segment.com/docs/connections/sources/catalog/libraries/website/javascript/#middleware


Handle stray LoadExprs in RawRepresentable fix-its

When there are multiple possible overloads for a call, the partially-type-checked argument expression might end up with a LoadExpr outside of the call ParenExpr instead of inside it. Account for this in a one- off way for the rawValue / init(rawValue:) fix-its.
Yet more SR-8150 / rdar://problem/41725207. (Follow-up to #17714.)

@swift-ci Please smoke test

@swift-ci Please test source compatibility

@xedin said he might have a more general fix, so I'll hold off for now.

Yes! I'm about to create a PR for that which changes CSApply/ASTVerifier to make sure that immediate paren/force-value expressions are always outside of load.

We're going to use this as a definite fix for 4.2 and continue investigating the rest of it on master.


HV-1039 Making EL usable in OSGi

Hey @hferentschik, this is based on @benson-basis 's work, polishing a bit and adding one more commit for moving the dreaded "Is EL present"  check to a more suitable place.

@gunnarmorling looking good. Going to merge it ...

Merged


netsurf.buildsystem: 1.9 -> 1.10

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/netsurf-buildsystem/versions.
meta.description for netsurf.buildsystem is: NetSurf browser shared build system
meta.homepage for netsurf.buildsystem is: https://www.netsurf-browser.org/
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.10 in filename of file in /nix/store/rqs0anjc7fmaibz79jvhgf6j0hbypzv2-netsurf-buildsystem-1.10

Rebuild report (if merged into master) (click to expand)

36 total rebuild path(s)

36 package rebuild(s)

First fifty rebuilds by attrpath
gegl
gimp
gimp-with-plugins
gimpPlugins.bimp
gimpPlugins.exposureBlend
gimpPlugins.farbfeld
gimpPlugins.fourier
gimpPlugins.gap
gimpPlugins.gimp
gimpPlugins.gimplensfun
gimpPlugins.gmic
gimpPlugins.lightning
gimpPlugins.lqrPlugin
gimpPlugins.resynthesizer
gimpPlugins.texturize
gimpPlugins.waveletSharpen
gnome-photos
imv
netsurf-browser
netsurf.browser
netsurf.buildsystem
netsurf.libcss
netsurf.libdom
netsurf.libhubbub
netsurf.libnsbmp
netsurf.libnsfb
netsurf.libnsgif
netsurf.libnslog
netsurf.libnspsl
netsurf.libnsutils
netsurf.libparserutils
netsurf.libsvgtiny
netsurf.libutf8proc
netsurf.libwapcaplet
netsurf.nsgenbind
toppler

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rqs0anjc7fmaibz79jvhgf6j0hbypzv2-netsurf-buildsystem-1.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A netsurf.buildsystem https://github.com/r-ryantm/nixpkgs/archive/680fc7eeed766ad3da6bb2803139c68528d65e38.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/680fc7eeed766ad3da6bb2803139c68528d65e38#netsurf.buildsystem

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rqs0anjc7fmaibz79jvhgf6j0hbypzv2-netsurf-buildsystem-1.10
ls -la /nix/store/rqs0anjc7fmaibz79jvhgf6j0hbypzv2-netsurf-buildsystem-1.10/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:

gimpPlugins.exposureBlend
gimpPlugins.resynthesizer

32 packages built:

gegl
gimp
gimp-with-plugins
gimpPlugins.bimp
gimpPlugins.farbfeld
gimpPlugins.fourier
gimpPlugins.gap
gimpPlugins.gimplensfun
gimpPlugins.gmic
gimpPlugins.lightning
gimpPlugins.lqrPlugin
gimpPlugins.texturize
gimpPlugins.waveletSharpen
gnome-photos
imv
netsurf.browser
netsurf.buildsystem
netsurf.libcss
netsurf.libdom
netsurf.libhubbub
netsurf.libnsbmp
netsurf.libnsfb
netsurf.libnsgif
netsurf.libnslog
netsurf.libnspsl
netsurf.libnsutils
netsurf.libparserutils
netsurf.libsvgtiny
netsurf.libutf8proc
netsurf.libwapcaplet
netsurf.nsgenbind
toppler

Maintainer pings
cc @vrthra @AndersonTorres for testing.

@ofborg build netsurf.browser

Result of nixpkgs-review pr 277664 run on x86_64-linux 1

2 packages marked as broken and skipped:

gimpPlugins.exposureBlend
gimpPlugins.resynthesizer

1 package failed to build:

toppler

36 packages built:

gegl
gegl.dev
gegl.devdoc
gimp (gimpPlugins.gimp)
gimp-with-plugins
gimp.dev (gimpPlugins.gimp.dev)
gimpPlugins.bimp
gimpPlugins.farbfeld
gimpPlugins.fourier
gimpPlugins.gap
gimpPlugins.gimplensfun
gimpPlugins.gmic
gimpPlugins.lightning
gimpPlugins.lqrPlugin
gimpPlugins.texturize
gimpPlugins.waveletSharpen
gnome-photos
gnome-photos.installedTests
imv
imv.man
netsurf-browser (netsurf.browser)
netsurf.buildsystem
netsurf.libcss
netsurf.libdom
netsurf.libhubbub
netsurf.libnsbmp
netsurf.libnsfb
netsurf.libnsgif
netsurf.libnslog
netsurf.libnspsl
netsurf.libnsutils
netsurf.libparserutils
netsurf.libsvgtiny
netsurf.libutf8proc
netsurf.libwapcaplet
netsurf.nsgenbind


How to evaluate huge models like LLAMA-65b?

I tried this on 8 A100 GPUs (40GB) and it OOMed. Any pointer on how to run inference with very big models?
python main.py --model hf-causal-experimental --model_args pretrained=huggyllama/llama-65b,use_accelerate=True --tasks wikitext --batch_size 1 --no_cache

accelerate currently supports inference with large models but I'm not sure if this could be used under the hood.
Best,
Rui

I tried to run an inference job with large models (llama-30b).
python main.py --model hf-causal-experimental --model_args pretrained=huggyllama/llama-30b,use_accelerate=True,max_memory_per_gpu=40gb --tasks wikitext --batch_size 1 --no_cache --write_out --output_path sf_results/llama-30b/wikitext --device auto
But I ran into this error.
Running loglikelihood_rolling requests
  0%|                                                    | 0/62 [00:00<?, ?it/s]Token indices sequence length is longer than the specified maximum sequence length for this model (8987 > 2048). Running this sequence through the model will result in indexing errors
python-BaseException
  0%|                                                    | 0/62 [02:08<?, ?it/s]
Traceback (most recent call last):
  File "/root/.pycharm_helpers/pydev/pydevd.py", line 1496, in _exec
    pydev_imports.execfile(file, globals, locals)  # execute the script
  File "/root/.pycharm_helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "main.py", line 89, in <module>
    main()
  File "main.py", line 57, in main
    results = evaluator.simple_evaluate(
  File "/export/home/project/llm/lm-evaluation-harness/lm_eval/utils.py", line 242, in _wrapper
    return fn(*args, **kwargs)
  File "/export/home/project/llm/lm-evaluation-harness/lm_eval/evaluator.py", line 91, in simple_evaluate
    results = evaluate(
  File "/export/home/project/llm/lm-evaluation-harness/lm_eval/utils.py", line 242, in _wrapper
    return fn(*args, **kwargs)
  File "/export/home/project/llm/lm-evaluation-harness/lm_eval/evaluator.py", line 285, in evaluate
    resps = getattr(lm, reqtype)([req.args for req in reqs])
  File "/export/home/project/llm/lm-evaluation-harness/lm_eval/base.py", line 239, in loglikelihood_rolling
    string_nll = self._loglikelihood_tokens(
  File "/export/home/project/llm/lm-evaluation-harness/lm_eval/base.py", line 323, in _loglikelihood_tokens
    inp = torch.tensor(
RuntimeError: Expected one of cpu, cuda, ipu, xpu, mkldnn, opengl, opencl, ideep, hip, ve, fpga, ort, xla, lazy, vulkan, mps, meta, hpu, mtia, privateuseone device type at start of device string: disk

I think it's because of the offloading to disk, so I set offload_folder=None and another error is raised.
python-BaseException
Traceback (most recent call last):
  File "/root/.pycharm_helpers/pydev/pydevd.py", line 1496, in _exec
    pydev_imports.execfile(file, globals, locals)  # execute the script
  File "/root/.pycharm_helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "main.py", line 89, in <module>
    main()
  File "main.py", line 57, in main
    results = evaluator.simple_evaluate(
  File "/export/home/project/llm/lm-evaluation-harness/lm_eval/utils.py", line 242, in _wrapper
    return fn(*args, **kwargs)
  File "/export/home/project/llm/lm-evaluation-harness/lm_eval/evaluator.py", line 69, in simple_evaluate
    lm = lm_eval.models.get_model(model).create_from_arg_string(
  File "/export/home/project/llm/lm-evaluation-harness/lm_eval/base.py", line 115, in create_from_arg_string
    return cls(**args, **args2)
  File "/export/home/project/llm/lm-evaluation-harness/lm_eval/models/huggingface.py", line 205, in __init__
    self.model = self._create_auto_model(
  File "/export/home/project/llm/lm-evaluation-harness/lm_eval/models/huggingface.py", line 261, in _create_auto_model
    model = self.AUTO_MODEL_CLASS.from_pretrained(
  File "/export/home/project/llm/transformers/src/transformers/models/auto/auto_factory.py", line 484, in from_pretrained
    return model_class.from_pretrained(
  File "/export/home/project/llm/transformers/src/transformers/modeling_utils.py", line 2937, in from_pretrained
    dispatch_model(model, **kwargs)
  File "/export/home/project/llm/accelerate/src/accelerate/big_modeling.py", line 366, in dispatch_model
    weights_map = OffloadedWeightsLoader(
  File "/export/home/project/llm/accelerate/src/accelerate/utils/offload.py", line 154, in __init__
    raise ValueError("Need either a `state_dict` or a `save_folder` containing offloaded weights.")
ValueError: Need either a `state_dict` or a `save_folder` containing offloaded weights.

FYI, this worked for me (use --device auto):
python main.py --model hf-causal-experimental --model_args pretrained=huggyllama/llama-65b,use_accelerate=True --tasks wikitext --batch_size 1 --no_cache --write_out --output_path sf_results/llama-65b/wikitext.json --device auto

For large model you should be using auto as your device. You can also pass a device map if you’re a super-user, but there’s almost no reason to do that if you just want to evaluate a LLM.


[CCAP-408] Fixing error handling and styling for dates

Issue tracking number 🔗

Description of change ✍

Priority 🥇

Effect on other applications using FFB 🌊

Testing

✅ Checklist before requesting a review

[ ] Does the new code follow our preferred coding
style?
[ ] Does the code include javadocs, where necessary?
[ ] Have tests for this feature been added / updated?
[ ] Has the readme been updated?

@spokenbird I just cut & pasted my date.html from the other PR into this one, plus the small CSS tweak.


Getting Started Updates for SIG-Windows

Remove the implicit recommendation to compile node binaries
Clarify the TOR example configuration file
Updates to sample yaml files and explain the OS tag usage of 1709
Add to known issues list
Remove mentioned required PR that has been merged
Add next steps footer

This change is

/approve

@rjmorse please resolve the conflicts and check your CLA status :)

/ping @zacharysarah  and @a-mccarthy
can we get this reviewed please?

@rjmorse 👋 Two things:

Please replace this PR with a new one and cherry-pick the relevant commits.

It looks like a previous merge imported a larger commit history. Please reference this PR in the OP so we can shorten the review process. If you /assign @zacharysarah in a comment, I'll catch it more quickly. 👍

Please resolve any CLA issues.

It looks like you're authorized as an individual user; are you part of an org with its own CLA permissions?

Thanks @zacharysarah I'll see if I can get these items squared away today.
I have an individual CLA and I've initiated a org CLA, but since that hasn't been approved it seems like the pending org CLA is blocking me

@rjmorse 👋 Any updates?

I finally created a new PR at https://github.com/kubernetes/website/pull/7535 and the CLA issue, merge conflicts, and improper merge issues have been resolved. PTAL

closing this PR since the replacement #7535 was created and merged.


Refactor CustomDimensions in analytics to be type safe

Add a new class CustomDimensions to handle the parameters for analytics, replacing the previous Map<String, String>.

Jonah, can you tell me what you think about the class CustomDimensions in usage.dart?
It's not pretty, and it might be difficult to maintain, but the alternatives I can think of would be either codegen or reflection, and I think neither of these are currently used in flutter_tools. Let me know if you think you would prefer an alternative implementation instead, thanks!

Thanks Jonah! I have moved class CustomDimensions and enum CustomDimensionsEnum to a separate file for easier maintenance, and I hope it is obvious from the repeating pattern that those are multiple places that need to be updated whenever a new field is added.
Also I kept everything in a single line to make it easier to use the multiple cursor feature in editors when we need to do batch edits.


Request to Add Paper

Hi：
Thanks for your contributions. We now have a SOTA MSDA paper that was published in TPAMI:
[Graphical Modeling for Multi-Source Domain Adaptation] [pytorch]. This paper is the extension of our ECCV2020 paper, Learning to Combine: Knowledge Aggregation for Multi-Source Domain Adaptation.
We wish the work could be added to MSDA.
Thanks very much!

Very impressive work! I have added it to the list!


Give indication of status in report preview

When a report is submitted and awaiting approval, the report preview in the workspace chat doesn't give any indication of the current "status" of the report. It just looks like this:

If you click into the report, you see a "next steps" banner which tells you what you are waiting on, but ideally, the report preview itself would give some indication.

Some ideas that were discussed in this thread:

showing the next steps on the report preview
show the report status on the report preview (e.g. draft/submitted/paid/etc)
show a progress bar on the report preview

We'd love to do a design exploration to explore these options (or any other ideas).

I've started generating some ideas for this. I will share something early next week.

Super looking forward to this. Thanks @dannymcclain!

Posted some options/threads in Slack!

Lots of good stuff in Slack, but I don't know that a firm decision/direction has been decided. Seems like a lot of us are liking the "bottom state bar" idea.
I'm about to be OOO for winter break, so I'm going to drop the Figma link here in case anyone wants it while I'm out.
https://www.figma.com/file/IxQBCHBtgQJss52s54LyLq/Wave-6%3A-Workspace-Expense-Chats?type=design&node-id=173-43247&mode=design&t=KDfSHFjBKo9lFhI3-11

Going to try to get a firm direction on this early this week.

Posted in Slack with some updated ideas.

Tons of conversation in Slack. I've made my recommendation to the channel to hopefully establish a clear path forward for this 🤞

Ok we're doing it! This will be the V1 option we move forward with. Figma file is here. Let me know if anything else is needed from me throughout the implementation.

Not overdue Melvin.
@puneetlath We've reached a decision for this design, but I'm honestly not sure what the next steps are for this effort.

@JmillsExpensify I would love to simplify the next steps in the process of accomplishing this because it makes a lot of sense for them to be harmonious.
We may also want to consider what impacts that has on our scanning, pending, hold pattern since they're all currently using the same styles as the current "Next Steps" implementation, but I suppose we could tackle that as a separate effort.

Great point, I like considering those at the very least.

Not really overdue Melvin. I'm working on a #whatsnext post for this so we can roll this, as well as the simplified next steps work, into a proper design doc/workflow.

WN Post here.
Based on the reactions, I think we should keep moving this one forward. @JmillsExpensify do you think we should close this issue in favor of a proper design doc tracking issue?

Not overdue Melvin.

It's alright Melvin. I've been really busy with wave work.

Same as above Melv.

We're going to get to it Melvin. It is OK!

Helping out with this one, so I'm going to assign myself as well.

We're letting search shake out before making any big changes to the preview component.
I'm going to leave this open for now just in case we have any brilliant ideas as we implement search, but I also think it would be acceptable to close this since we have a pretty jam packed roadmap of releases scheduled.

I think we should close it. If it's a priority, we can come back to it.


[Feat]: Filter the projects using search query params.

What feature?
We are filtering the tools with the help of useState hook. Suppose, if a user applies some filtering on the tools and then he/ she wants to share those filtered tools to his/her friends. With the current approach that is implemented in the codebase it is not possible. Instead of this if we filter based on query params the user will be able to share the filtered tools with others as well. And the filter will be still available even when the user refreshes the page.
Add screenshots
Add screenshots
Code of Conduct

[X] I agree to follow this project's Code of Conduct

What do you mean by sharing the website??

What do you mean by sharing the website??

Sharing the link of live site of course

Hey @JasonDsouza212 Can you share your discord username? Also have you joined the channel related to this project in the GSSoc Server?f

Do you want to work on this issue @kailashchoudhary11

Do you want to work on this issue @kailashchoudhary11

Yeah I would love to.

Are you working under GSSOC23

Are you working under GSSOC23

Yeah, We talked on discord.

Yes I remember now

Yes I remember now

There's a bug in the Navbar 🥲 Someone changed the conditions I guess. The search bar is only visible on the about us page and it's hidden on other pages

It has been resolved, and now you can work on it. @kailashchoudhary11


VSCode "Error processing launch options at field: program" popup when debugging an xunit test

Steps to Reproduce:

Setup a project with xunit:

    using System;
    using System.Reflection;
    using Xunit;

    public class Fact2Attribute : FactAttribute
    {
        public Fact2Attribute()
        {
            Type thisType = GetType();
             MethodInfo theMethod = thisType.GetMethod("MyOtherMethod");
             var result = theMethod.Invoke(this, null);
        }

            public void MyOtherMethod(string singleParam){}
    }
        [Fact2]
        public void ATestMethod()
        {
            Assert.True(false);
        }

Compile and using Code lens press Debug Test

Expected behavior
It should fail before the test runs as we are invoking MyOtherMethod without a param. An appropriate message should be shown.
Actual behavior
I get this window popup:

I don't get any error messages in console. If I try and run test rather than debug test it seems to completely bypass the test so I end up with:
Total tests: 0. Passed: 0. Failed: 0. Skipped: 0

If I run dotnet test I get the same result as run test in code lens.
Versions:
dotnet 2.1.105
VS code 1.22.2
Omisharp 1.14.0
Ubuntu 16.04.4 LTS

Also experiencing this on windows using NUnit tests:
dotnet 2.2.103
VS code 1.35.0
Omnisharp: 1.19.1
Windows: 10.0.17134 Build 17134
NUnit3TestAdapter: 3.8.0
Microsoft.NET.Test.Sdk: 15.0.0
NUnit: 3.6.1