Clarify if P0V3 is supported or not

According to existing documentation on this page, it indicates that this feature is available for Pv2 and Pv3 pricing tiers. When attempting to perform the instructions for P0V3 tier, I get an error in both Portal and via CLI.
Looking into AZ Cli help, it appears that only the following tiers are supported for elastic-scale

--elastic-scale               [Preview] : Enable or disable automatic scaling. Set to
                                          "true" to enable elastic scale for this plan, or
                                          "false" to disable elastic scale for this plan. The
                                          SKU must be a Premium V2 SKU (P1V2, P2V2, P3V2) or a
                                          Premium V3 SKU (P1V3, P2V3, P3V3).  Allowed values:
                                          false, true.

Could it be clarified, which set of documentation is in fact true and what is intended?
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bc866a75-b0a3-d2cb-22bd-71906d173f53
Version Independent ID: bd5d7447-8a16-47e8-1967-809fbf6150ab
Content: How to enable automatic scaling - Azure App Service
Content Source: articles/app-service/manage-automatic-scaling.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: msangapu

@wahyuen
Thanks for your feedback! We will investigate and update as appropriate.

wahyuen,  According to the referenced doc Automatic scaling in Azure App Service
, automatic scaling is available for Premium Pv2 and Pv3 pricing tiers.
"Automatic scaling is in preview. It's available for Premium Pv2 and Pv3 pricing tiers, and supported for all app types: Windows, Linux, and Windows container."
The Azure CLI cmd o/p is also consistent with this info.

SKU must be a Premium V2 SKU (P1V2, P2V2, P3V2) or a Premium V3 SKU (P1V3, P2V3, P3V3).
Allowed values: false, true.

To clarify, you can only enable or disable automatic scaling for Premium V2 and Premium V3 pricing tiers using the --elastic-scale parameter in the Azure CLI. The P0V3 tier is not supported for elastic-scale. Kindly let us know if this info helps clarify or I misunderstood your question.  Thanks, again.

@AjayKumar-MSFT Thanks. Could I please suggest that the referenced doc be updated to call out that P0V3 is not supported? Given that it technically is a Premium V3 SKU

wahyuen, Thanks for the follow-up and additional info.  Your feedback has been shared with the content owner (@msangapu-msft ) for further review.

@wahyuen Thank you for the feedback. The CLI is correct and the doc is being updated.


Add decimal type.

This adds the decimal type which is exact fixed point representation of a decimal number.
Add atod: ascii to decimal.
Add dtoi: decimal to int.
Add parseSIPrefix.

Thinking about it maybe it would be better to have dtoi have the signature
func dtoi(d decimal, scale) (int, error)

rather than being a method?

Codecov Report

Merging #309 into master will increase coverage by 0.45%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #309      +/-   ##
=========================================
+ Coverage   68.64%   69.1%   +0.45%
=========================================
  Files          99      99
  Lines        8539    8664     +125
=========================================
+ Hits         5862    5987     +125
  Misses       2523    2523
  Partials      154     154

Impacted Files
Coverage Δ

conn/physic/units.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19f9a0...265c264. Read the comment docs.

changed dtoi signature, I like it more, as it is closer to std lib form.

glad you like it. :)

gohci

.. style nits and the ++ and -- ones should be fixed. I think it's preferable to deny both.

gohci

Seriously an amazing change, thanks a lot! I don't think I could have written something as good.

:) Np, thank you for all your help.


There is no available connector for azure synapse workspace pool while importing the data onto azure search. Understood that it is not documented for the same. Would be great to change the documentation

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3653fb10-b136-c1b3-7726-34fa8504f132
Version Independent ID: 121d86ff-93d2-ef73-ce18-96f6502a415c
Content: Azure SQL indexer - Azure Cognitive Search
Content Source: articles/search/search-howto-connecting-azure-sql-database-to-azure-search-using-indexers.md
Service: cognitive-search
GitHub Login: @HeidiSteen
Microsoft Alias: heidist

@vvamaraju Thanks for the feedback! We are currently investigating and will update you shortly.

@vvamaraju All of the supported indexer data sources are documented -- we just don't have one for Azure Synapse.  There is a non-indexer approach to indexing however, in the form of SynapseML.  It's covered in this tutorial:  https://learn.microsoft.com/en-us/azure/search/search-synapseml-cognitive-services
Does that help??

I believe this issue is closed, so I'm going to close the ticket.  If you disagree, please feel free to reopen it.
#please-close


(googlechrome) Fixed the detection logic for 32bit installs

The registry key we previously used for detecting an already installed 32bit installation have changed.
This PR fixes that, while also providing a fallback to check if the nacl_irt_x86_32.nexe do exist (this only exists on 32bit installations).
The check for the currently installed version had also broken, so this is also fixed.
fixes #667
MERGE with [AU googlechrome] in the title
/cc @majkinetor @mattheyan

@majkinetor underpaded version?
I'm sorry, I think I understand what you're talking about.

Sorry, paddedUnderVersion ? When does it kick ?

ah, I see.
The $paddedUnderVersion variable is just passed to the Get-Padded-Version script, basically telling it to just add additional zeroes to the revision part of the version when the version is less than the version specified in $paddedUnderVersion

Yeah, I know how to read param descriptions, I just wonder when does it happen in nature for new versions ?

Yeah, I'm wondering the same thing. Isn't the padding optional? I could see it being useful if the vendor's download URL or version recorded in installed programs (or something else) used zero padding and you had to deal with that. Does it need to be added for some other reason in this case? And why the change to stop using the chocolateyPackageVersion environment variable? Also, does the  -ChecksumFor none bit have something to do with the fact that Chrome doesn't provide historical downloads (just a wild guess)? Sorry for so many questions, but I'd love to learn more about this stuff so I can improve my own package authoring skills.  ;)

Yeah, I'm wondering the same thing. Isn't the padding optional? I could see it being useful if the vendor's download URL or version recorded in installed programs (or something else) used zero padding and you had to deal with that

The reason for adding a zero padding is to allow adding fix versions of the currently available version on chocolatey.
Since we can't update an already approved version of a package we'll need to add padding to the revision part of the version.
I.e.
Version 57.0.2987.133 exist on chocolatey, We pad the revision when we need to release a fix for the package so we end up with the version: 57.0.2987.13301. If then Google updates only the revision on their next software release (although unlikely) to: 57.0.2987.134. Then this version would be considered lower than the padded fix version, so we also needs to pad that version to 57.0.2987.13400 so it would be considered the latest version. But when Google updates the patch part of the version so the version ends up being 57.0.2988.140, we don't need to pad the revision part of the version number as it would still be considered newer than the fixed version.

And why the change to stop using the chocolateyPackageVersion environment variable?

this is done because we compare it to the installed version of chrome, so if we publish a fix version of the package ie 57.0.2987.13301 it wouldn't be the same version as the version gotten from the registry, hence why we can't continue to use chocolateyPackageVersion environment variable.

Also, does the -ChecksumFor none bit have something to do with the fact that Chrome doesn't provide historical downloads (just a wild guess)?

No it doesn't have anything to do with that, it is done in case of the same version that we are trying to update to exist already on appveyor, or it exist on the computer of whoever tries to debug the update script. We still acquire the checksum in the au_BeforeUpdate function instead of running the chocolatey install script.

@AdmiringWorm Excellent! Thanks for that info. I wondered how you would handle an update to the package when the software version used all 4 components and hadn't been updated, and now I know. Do you know if this is documented somewhere, or written up in a blog post (not necessarily the -paddedUnderVersion param, just the general approach of padding the version)? I see mention of the problem in the Contributing Guidelines, but no mention of the way to "fix" it - at least nothing specific.
In terms of @majkinetor's question, I'm guessing the padding hasn't kicked in because you're going to update the paddedUnderVersion when the changes are reviewed and ready to go?
Thanks again for the explanation. :-)

I'm guessing the padding hasn't kicked in because you're going to update the paddedUnderVersion when the changes are reviewed and ready to go?

The padding actually will already kick in (it won't get changed though, unless [AU googlechrome] is used as the same version is already available on chocolatey).
With the current paddedUnderVersion value, everything less than version 57.0.2988 will get padded


Improve loading indicator.

Follow https://github.com/webaverse-studios/CharacterCreator/pull/232

Remove indicator's background, add shadow.
Found there's existing loading state, use it to show/hide indicator, remove newly add isLoading.
There's also existing LoadingOverlay page, but tried that looks not well with current UI, so keep using new loading indicator.
Add effecting state. We don't want see indicator when playing VFX, but still can't allow user change traits when playing VFX, so have to add effecting state.

https://user-images.githubusercontent.com/10785634/215502684-e380ba7d-2230-4370-b162-4df8512a1a02.mp4

Added fixes, merging


Stop rfkill from blocking all radio devices

This fixes a bug introduced in af0115e and closes #174
After creating a uinput device with switches support, all radio devices were blocked. This was due to rfkill reacting to the uinput creation.
We disable rfkill-input (the module reacting to new device creation) to avoid blocking all radio devices. When a new device (virtual or physical) with the SW_RFKILL_ALL switch capability bit set appears, rfkill reacts immediately depending on the value bit. This value bit defaults to unset, which causes rfkill to use its default eop mode (emergency power off). The uinput API does not give any way to set the corresponding value bit before creating the device, and we have no way to avoid rfkill acting upon the device creation or to change its default mode. Thus, we disable rfkill-input temporarily, hopefully fast enough that it won't impact anyone. rfkill-input gets enabled automatically after uinput device creation (actually, when the file gets closed).

It works for me! Thx

@ajanon LGTM! Go for the merge!


Make it a real "app"

Cuurrently the "app" is a django project. It would be nice to make it easier to install, remove some name clashes and make it reusable. That would require a lot of refactoring but i think that the base is there.
I could help with the refactoring if you want, but add a license file to the repository first.

@cdvv7788 What you have suggested is good, but unfortunately, I'm not actively maintaining this repo anymore. It was a project done long back, anyway I'll add the license file.


Support for file descriptors on Linux

Hi, in a project I'm a contributor of we need to call an external binary, which uses an extra file descriptor (FD 3) for output, in addition to stdout and stderr. Currently we are using std::process together with the command-fds crate (https://github.com/google/command-fds), but we are looking forwards to migrating to the subprocess crate (to make use of the timeout and non-blocking I/O features).
Is it possible to use custom file descriptors together with rust-subprocess? Ideally custom FDs would support all the features which standard streams (stdin, stdout, stderr) support, like reading/writing to Vecs or files and using pipes - after all on Linux the standard streams are just file descriptors.

Custom file descriptors are currently not supported. The library is currently not very actively maintained, since std::process now has many more features compared to when I started writing subprocess.


fix: implementation a findAll method in mongodb repository template

Fixes #73
Readiness Checklist
Author/Contributor

[ ] If documentation is needed for this change, has that been included in this pull request
[ ] Remember to check if code coverage decrease, if so, please implement the necessary tests

Reviewing Maintainer

[x] Label as breaking if this is a large fundamental change
[x] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

:tada: This PR is included in version 1.6.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Bluetooth: audio: Available contexts fixes

This fixes few issues related to available audio contexts.

@szymon-czapracki FYI


Add Enabled Flag

what

Add a flag to enable/disable resources for this module

why

We use this pattern to enable/disable accounts as necessary to simplify the coldstart

For a sample use-case, see: https://github.com/cloudposse/terraform-root-modules/pull/61/files#diff-c978e614f253550f23f792b793f237e1R2


Bump Dependencies #3912422934

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/3912422934

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


fix(loader): ensuring a cross-platform path

This PR addresses a critical issue with the path resolution system within the loader module, specifically rectifying an issue exclusive to Windows. Previously, pathnames were being incorrectly constructed with an extraneous leading slash (e.g., /D:/path_to_module), which resulted in Chokidar's watch function failing to recognize the paths correctly.

Super cool dude, we were just fixing that issue in live-sharing with @RomainLanz and saw your PR coming 😅
thanks a lot, we just tried it live and it works perfectly


Compile a single file for debugging

Hello,
I'm wondering how to compile a single js or ts file with Babel, respecting CRA configuration? I only need this for debugging.

Relates to #5306


Duplicate podCIDR ranges assigned to cluster nodes.

Environmental Info:
K3s Version:
k3s version v1.20.4+k3s1 (838a906a)
go version go1.15.8

Also on version v1.20.2+k3s1

Node(s) CPU architecture, OS, and Version:
Running in Azure.  Ubuntu 18.04
Linux k3s-ingress-zone-2000000 5.4.0-1043-azure #45~18.04.1-Ubuntu SMP Sat Mar 20 16:16:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Cluster Configuration:

Control-Plane

PostgreSQL Database (4 core)
VMSS with 2 control-plane (4 core)
Control-pane nodes are behind a private load-balancer. Worker (agent) nodes connect to load-balancer.

Workers

3  VMSS with 12 total workers (4 and 8 core in various zones)

Describe the bug:
Worker nodes are being assigned duplicate podCIDR ranges.  As you can imagine, this is causing quite a networking nightmare.
In this example k3s-general-zone-2000001 and k3s-general-zone-2000000 were assigned duplicate podCIDR ranges.
➜ kubectl get nodes -o custom-columns=Name:.metadata.name,CIDR:.spec.podCIDR --sort-by='{.spec.podCIDR}'
Name                          CIDR
k3s-control000000             <IP_ADDRESS>/24
k3s-control000001             <IP_ADDRESS>/24
k3s-ingress-zone-1000000      <IP_ADDRESS>/24
k3s-worker-zone-1000000          <IP_ADDRESS>/24
k3s-monitoring-zone-1000000   <IP_ADDRESS>/24
k3s-general-zone-1000000      <IP_ADDRESS>/24
k3s-ingress-zone-2000000      <IP_ADDRESS>/24
k3s-worker-zone-1000001          <IP_ADDRESS>/24
k3s-monitoring-zone-1000001   <IP_ADDRESS>/24
k3s-general-zone-1000001      <IP_ADDRESS>/24
k3s-worker-zone-2000000          <IP_ADDRESS>/24
k3s-worker-zone-2000001          <IP_ADDRESS>/24
k3s-general-zone-2000001      <IP_ADDRESS>/24
k3s-general-zone-2000000      <IP_ADDRESS>/24

My guess is that there is a race condition where both of the k3s-general-zone-2 nodes in the azure vmss come up at the same time and end up getting assigned the same range?
Steps To Reproduce:

Launch Nodes in parallel with multiple Virtual Machine Scale Sets. Nodes install k3s in cloud-init.
control plane config.yaml
agent-token: Redacted
datastore-endpoint: "postgres://Redacted"
disable-cloud-controller: true
disable:
- servicelb
- local-storage
- traefik
kube-apiserver-arg:
- "cloud-provider=external"
kubelet-arg:
- "cloud-provider=external"
- "cloud-config=/etc/kubernetes/azure.json"
tls-san:
- <IP_ADDRESS>
token: redacted
node-taint:
- "node-role.kubernetes.io/master=true:NoSchedule"
write-kubeconfig-mode: 644

client k3s config.yaml
server: "https://<IP_ADDRESS>:6443"
token: "redacted"
kubelet-arg:
- "cloud-provider=external"
- "cloud-config=/etc/kubernetes/azure.json"
"node-taint": []

"node-label":
- "node.kubernetes.io/exclude-from-external-load-balancers=true"

Expected behavior:
Nodes to be assigned unique podCIDR IP spaces.
Let me know if you need any other data to troubleshoot.

We're just using the default upstream Kubernetes node IPAM that's embedded in the kube-controller-manager: https://github.com/kubernetes/kubernetes/blob/release-1.20/pkg/controller/nodeipam/ipam/range_allocator.go


Added ability to set colors of bubbles, text, date, underline, & cursor programmatically, & attachment menu has white background with dropshadow

…rView.
Previously, we could only set these colors with the XML file, but in my app, the colors need to be dynamically set at runtime (the color might vary). The other way to do this from the existing app would have been to pass in an AttributeSet to AtlasMessagesRecyclerView.parseStyle, but I couldn't find a good way to generate an AttributeSet instance, so I think this is the best solution.
Also in my app, the attachment menu was transparent (and not white with the dropshadow like in the Atlas Messenger sample app), so I added a fix to that too.

Hi,
If you know the colors before the view has to be instantiated, you can create the view programmatically using a ContextThemeWrapper object and pass that in as the context when creating the RecyclerViews. You'd create the ContextThemeWrapper with a new theme with the appropriate colors. Unfortunately, Android does not let you change the theme/style of a view after it has been instantiated. If you need to change the colors dynamically after the view is instantiated then we would need to expose setters for most if not all of the colors in that view.
The attachment window should be using the android:popupBackground attribute in the active theme. Check to make sure that is not set to transparent in your theme or your parent theme. If you have a specific background you'd like to use for that PopupWindow then you can set the drawable or color for android:popupBackground in your Theme.

Thank you! That was very helpful information, and I am able to get it working without this pull request.


Compiling with RAD Studio 12,1 patch 1 not possible

Compiling with RAD Studio 12,1 patch 1 not possible
Error in [dcc32 Fatal Error] unaMsAcmClasses.pas(764): F2063 Could not compile used unit 'unaWave.pas'
The error is
[dcc32 Error] unaWave.pas(543): E2251 Ambiguous overloaded call to 'Min'
System.Math.pas(5065): Related method: function Min(const Cardinal; const Cardinal): Cardinal;
unaUtils.pas(2339): Related method: function min(unsigned; unsigned): Cardinal;
the same in line 1383 and 1418

DCC32.EXE is the 32-Bit Delphi Compiler.
The Fatal Error Message signs a Compiler Error from DCC32.EXE and NOT doxygen.
unaWave.pas seems to be LakeOfSoft Voice Software - like my Miracle sounds me in my ears.
So, check the source of Pascal.
Or show us the relevant part of Source.
At the current time, Delphi is not supported by doxygen directly.
You can try pas2dox.exe which is a free Tool that will be shipped with Free Pascal Compiler, and Lazarus so far I know...

woops, this should be into the doxygen issues - sorry.


sqlparse dependency not documented

You might want to mention in README.md that sqlparse must be installed in order for the code to work. Or create requirements.txt.

thanks. just added sqlparse and nltk as the dependency requirements to the README.


getregistrationreceipt working in Non-Accountable mode

compile project using
cargo build --features notAccountable
Now add the plugin to CLN by installing it, to do this run:
cargo install --locked --path watchtower-plugin --features notAccountable
then run the tower using
teosd
now you can use client endpoints that are customised to run in this mode

A couple more things:
This doesn't really compile "as is". I had to fix watchtower-plugin/src/net/http.rs.
Also, regarding the PR description, explain what the PR is doing and what, and add how to test it in the end if you feel it's necessary. The current description is not really helpful beyond how to compile this.

will reverse changes so that, nonAccountable mode is the default one, and other necessary changes demanded, on it now.

I've pushed a commit to properly fix the formatting so the diff can be smaller, given that it was impossible to review otherwise. However, this still needs a lot of cleaning. Are you using any linter? There are a lot of unused variables, attributes, imports. Also imports that are repeated for accountable and non-accoutable.
You really need to go over all the modified files and check properly (both manually but also use a linter to make your life easier). Only the minimal things should go between a conditional compilation flag, so, for instance, if we are importing dependencies A, B, C, and D, and A, B are common, C is only used for accountable, and D only for non-accountable, only C and D need to be conditional, you cannot do
#[cfg(feature = "accountable")]
use A,B,C
#[cfg(not(feature = "accountable"))]
use A,B,D

Hey @sr-gi I have been asking for these detailed reviews from you for a long time, and now since you have given it I will do the required changes starting now.
Thank You

Hey @sr-gi I have been asking for these detailed reviews from you for a long time, and now since you have given it I will do the required changes starting now. Thank You

Sorry, but I couldn't give you a review like this with the code format being all over the place. I sent you several patches for the code formatting over the weeks but you never applied them, so I had to end up doing it myself, hence why the review couldn't come earlier.

Hey I have tried to resolve most issues
Now only two problems are remaining with the code:

You told me not to replicate functions and write code logic to optionally compile specific parts within the same function, I have written my code so as to minimize complete function replication wherever possible, the function where I have replicated the complete code is because I was not able to do it within the single function due to syntax error of using #cfg[()], it does not combine multiple lines of code the way you are telling, I tried many times, let's have a meet to discuss how we can resolve this issue, I will explain it clearly in the meet itself.

Some tests need to be rewritten for non-accountable mode.

Hey I have seen the provided examples for fixing the code, implementing it now.

Closing due to inactivity. This was attempted but never fully implemented.

Closing due to inactivity. This was attempted but never fully implemented.

Could it be useful for future trials? maybe draft it instead?
@sr-gi

I'll reference it in the original issue in case someone wants to pick up where this was left


Elevated access doc

I'm merging and publishing this one. But let me know if we should make some edits to that last section @wli3.


[KeyVault] Update data plane SDK to 0.3.1

Closes #2505.

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[x] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

[x] Each command and parameter has a meaningful description.
[x] Each new command has a test.

(see Authoring Command Modules)

@schaabs,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@tjprescott This change is to update the cli command modules to use the recent azure-keyvault sdk changes, from this pull request:  https://github.com/Azure/azure-sdk-for-python/pull/1137
This change shouldn't be merged until the corresponding sdk changes are merged and packages available.
There is no added commands or functionality just some updates to consume a backwards breaking change in the azure-keyvault sdk.  The only affected command modules are azure-cli-keyvault and azure-cli-vm.  I don't have access to add reviewers so please add as relevant.

Codecov Report

Merging #3251 into master will increase coverage by <.01%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
+ Coverage   70.27%   70.28%   +<.01%
==========================================
  Files         391      391
  Lines       25067    25081      +14
  Branches     3811     3811
==========================================
+ Hits        17616    17627      +11
- Misses       6342     6344       +2
- Partials     1109     1110       +1

Impacted Files
Coverage Δ

...vm/azure/cli/command_modules/vm/disk_encryption.py
52.31% <0%> (ø)
:arrow_up:

...ult/azure/cli/command_modules/keyvault/commands.py
100% <100%> (ø)
:arrow_up:

...vault/azure/cli/command_modules/keyvault/custom.py
67.37% <100%> (ø)
:arrow_up:

...ault/azure/cli/command_modules/keyvault/_params.py
86.15% <100%> (ø)
:arrow_up:

.../azure/cli/command_modules/keyvault/_validators.py
72.84% <100%> (ø)
:arrow_up:

...zure/cli/command_modules/keyvault/_command_type.py
77.46% <100%> (-0.92%)
:arrow_down:

...zure-cli-vm/azure/cli/command_modules/vm/custom.py
73.13% <100%> (ø)
:arrow_up:

...-storage/azure/cli/command_modules/storage/blob.py
14.28% <0%> (ø)
:arrow_up:

...re-cli-dla/azure/cli/command_modules/dla/custom.py
52.8% <0%> (ø)
:arrow_up:

... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8141973...f9750d7. Read the comment docs.

@tjprescott azure-keyvault 0.3.1 introduces a bug in keyvault authentication.  Moving to 0.3.0 until the issue is fixed.


Django 11 compat

Fix broken admin due to Django incompatibility. Fix cherry-picked from upstream.
Bump package version for releasing.

If there is development upstream, I think we should rather just merge them instead of cherry-picking. That'll make it easier to manage our fork.


implemented low memory option for fid.py

See #14
I implemented behaviour to load and un-load each batch of images during evaluation of the activations instead of loading all images to RAM at the beginning of evaluation.
This reduces memory requirements by a significant amount.
Specifically, it reduced the memory footprint from >16GB to <4GB when using 10.000 images of size 256x256.
The new behaviour is triggered by enabling the --lowprofile flag in the command line args of fid.py
I made this the non-default behaviour since it might increase execution time slightly in non-memory-constrained environments.
The results should be near-identical.
I have observed small differences between scores, at non-significant digits (5th place after comma), but those are probably explained by floating-point rounding errors.

LGTM, thanks for the contribution :+1: :)


Not generating a master.template

I am trying to follow along from this video to automate my deployment using swagger files, however when I run the creator tool I only get the following template json files and not the master file described in the video.

My config file is
version: 0.0.1 apimServiceName: myAPIMService apiVersionSets:     - id: myAPIVersionSetID       displayName: swaggerPetstoreVersionSetLinked       description: a description       versioningScheme: Query       versionQueryName: versionQuery       versionHeaderName: versionHeader apis:     - name: myAPI       openApiSpec: C:/Work/Apim/azure-api-management-devops-resource-kit/example/demo/Input/swaggerPetstore.json       policy: C:/Work/Apim/azure-api-management-devops-resource-kit/example/demo/Input/apiPolicyHeaders.xml       suffix: conf       subscriptionRequired: true       apiVersion: v1       apiVersionDescription: My first version       apiVersionSetId: myAPIVersionSetID       revision: 1       revisionDescription: My first revision       operations:         addPet:           policy: C:/Work/Apim/azure-api-management-devops-resource-kit/example/demo/Input/operationRateLimit.xml         deletePet:           policy: C:/Work/Apim/azure-api-management-devops-resource-kit/example/demo/Input/operationRateLimit.xml       products: starter, platinum outputLocation: C:\Work\Apim\azure-api-management-devops-resource-kit\example\templates\demo
Am I missing something here? Also is the demo used in this video available anywhere? The current demo files in this project seem to be outdated and I cannot find any examples of how to link up my generated templates like is done in the video.

Closing as I didn't realize the config needs linked: true to generate the master file.


Added upload image functionality

Description
Added upload image functionality
Fixes #912
Screenshots

Checklist

[x] Tests have been added or updated to cover the changes
[ ] Documentation has been updated to reflect the changes
[x] Code follows the established coding style guidelines
[x] All tests are passing

@thestarsahil check


No handlers could be found for logger "elasticsearch.trace"

can any one help me with this ? I just started:
mongo-connector -m serverIP:27017 -t localhost:9200 -d elastic2_doc_manager -v
what I get  :
Logging to mongo-connector.log.
No handlers could be found for logger "elasticsearch.trace"

stderr  :
2016-05-20 19:16:25,486 [ERROR] mongo_connector.oplog_manager:634 - OplogThread: Failed during dump collection cannot recover! Collection(Database(MongoClient(host=['myServerIP:27017'], document_class=dict, tz_aware=False, connect=True, replicaset=u'rs0'), u'local'), u'oplog.rs')
2016-05-20 19:16:25,486 [DEBUG] mongo_connector.oplog_manager:208 - OplogThread: Last entry is the one we already processed.  Up to date.  Sleeping.
2016-05-20 19:16:25,620 [ERROR] mongo_connector.connector:303 - MongoConnector: OplogThread <OplogThread(Thread-2, started<PHONE_NUMBER>08768)> unexpectedly stopped! Shutting down
2016-05-20 19:16:25,621 [INFO] mongo_connector.connector:360 - MongoConnector: Stopping all OplogThreads
2016-05-20 19:16:25,621 [DEBUG] mongo_connector.oplog_manager:371 - OplogThread: exiting due to join call.

"No handlers could be found for logger" means that there isn't anything receiving any of the log messages from the Elastic Python driver's logger called elasticsearch.trace. This isn't a problem in itself, it just makes it more difficult to see log messages from the Elastic Python driver.
mongo-connector should still be capable of logging messages into its own log file, despite the above.

I am facing this same issue


Allow us to receive Slayer tasks while your minion is doing an activity

🚀 Feature Proposal
Currently need to be free to obtain a slayer task. It would be great QoL if we could get a new task while doing something, like say a clue scroll so the player would know what task they are doing next.
Of course, wouldn't be allowed to autoslay or anything right after. It would just give you a new task to do when you're free, thats all.

This may have potential to be abused.  There were other examples of abuse, but not worth the troubles for a minor QOL feature.


TensorFlow.Net 0.100.1 referring to TensorFlow.Keras 0.10.0 AND TensorFlow.Keras 0.10.1 ?

Using TensorFlow.Net 0.100.1 and either TensorFlow.Keras 0.10.0 OR TensorFlow.Keras 0.10.1 (there is no version <IP_ADDRESS>),
I get this message:
System.TypeLoadException
HResult=0x80131522
Message=Method 'get_initializers' in type 'Tensorflow.Keras.KerasInterface' from assembly 'Tensorflow.Keras, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' does not have an implementation.
Source=TensorFlowNet-Updated-GAN
StackTrace:
at TensorFlowNet_Updated_GAN.MnistGAN.PrepareData() in C:\Users\darla\Downloads\TensorFlowNetUpdatedGAN-main\TensorFlowNetUpdatedGAN-main\TensorFlowNet-Updated-GAN\TensorFlowNet-Updated-GAN\MnistGAN.cs:line 57
at TensorFlowNet_Updated_GAN.MnistGAN.Run() in C:\Users\darla\Downloads\TensorFlowNetUpdatedGAN-main\TensorFlowNetUpdatedGAN-main\TensorFlowNet-Updated-GAN\TensorFlowNet-Updated-GAN\MnistGAN.cs:line 40
at TensorFlowNet_Updated_GAN.Program.Main(String[] args) in C:\Users\darla\Downloads\TensorFlowNetUpdatedGAN-main\TensorFlowNetUpdatedGAN-main\TensorFlowNet-Updated-GAN\TensorFlowNet-Updated-GAN\Program.cs:line 15
GitHub repo showing the error:
https://github.com/Darlanio/TensorFlowNetUpdatedGAN

Tried using the SciSharp/SciSharp-Stack-Examples-repository and adding the NuGet-Package TensorFlow.Net 0.100.1,
but this also gave the error above.
It did work when I added the SciSharp/TensorFlow.Net-repository, removed the dependency to TensorFlow.Keras 0.10.1 from the example and instead added two project references two TensorFlow.Net and TensorFlow.Keras.
I also saw you had replaced the MnistGAN.cs code with my Dense-version... I do not mind it being in the project, but the original one is more efficient when running on a GPU that has enough memory. You can decide which one to use.

Right, I also noticed the original version has better result.
You can only install Tensorflow.Keras v0.10.1. It will include the correct version of Tensorflow accordingly.
I tested the GAN example in our examples repo, no any error found.

Tested with my repo only using Tensorflow.Keras 0.10.1 and got the error:
System.TypeInitializationException
HResult=0x80131534
Message=The type initializer for 'Tensorflow.KerasApi' threw an exception.
Source=Tensorflow.Keras
StackTrace:
at Tensorflow.KerasApi.get_keras()
at TensorFlowNet_Updated_GAN.MnistGAN.PrepareData() in C:\Users\darla\Downloads\TensorFlowNetUpdatedGAN-main (1)\TensorFlowNetUpdatedGAN-main\TensorFlowNet-Updated-GAN\TensorFlowNet-Updated-GAN\MnistGAN.cs:line 49
at TensorFlowNet_Updated_GAN.MnistGAN.Run() in C:\Users\darla\Downloads\TensorFlowNetUpdatedGAN-main (1)\TensorFlowNetUpdatedGAN-main\TensorFlowNet-Updated-GAN\TensorFlowNet-Updated-GAN\MnistGAN.cs:line 40
at TensorFlowNet_Updated_GAN.Program.Main(String[] args) in C:\Users\darla\Downloads\TensorFlowNetUpdatedGAN-main (1)\TensorFlowNetUpdatedGAN-main\TensorFlowNet-Updated-GAN\TensorFlowNet-Updated-GAN\Program.cs:line 15
This exception was originally thrown at this call stack:
Tensorflow.KerasApi.KerasApi()
Inner Exception 1:
TypeLoadException: Method 'SimpleRNN' in type 'Tensorflow.Keras.Layers.LayersApi' from assembly 'Tensorflow.Keras, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' does not have an implementation.
I also tested the old version without installing Tensorflow.Net and you are right, Tensorflow.Keras will install what it needs on its own. However, with 0.10.0 it will still find 0 Trainable Variables for the generator.
I will test with the SciSharp repository tonight.

Added a GitHub Repo that shows this error in a simple form:
https://github.com/Darlanio/TensorFlowNetGAN20230131
I also tried using the SciSharp-repositories instead of NuGet-Packages - and that works:
https://github.com/Darlanio/SciSharp-MNISTGAN-Example
I hope this gives a clue about what is wrong.


New version: Kiraku.Mindbox version 2.1.0-360

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.4 schema?


Update Calculator[GUI] script.py

Description
Fixes #170
This PR fixes the issue of subtraction error in the Calculator [GUI] script. I've increased the font size of the buttons and the entry widget and added comments wherever needed to explain the code. Does not require any new dependencies.
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

@all-contributors please add @adviksinghania  for bug and code

@all-contributors please add @adviksinghania  for bug and code


Support to post batch session/operation event

Why are the changes needed?

Support to post batch session/operation event.
Besides, make some improvements.

wrap session.open with handleSessionException
add sessionType for KyuubiOperationEvent

How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #3975 (806be6d) into master (eb98f1e) will increase coverage by 0.07%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #3975      +/-   ##
============================================
+ Coverage     51.96%   52.04%   +0.07%
  Complexity       13       13
============================================
  Files           522      541      +19
  Lines         29042    29480     +438
  Branches       3887     3939      +52
============================================
+ Hits          15093    15343     +250
- Misses        12575    12729     +154
- Partials       1374     1408      +34

Impacted Files
Coverage Δ

.../org/apache/kyuubi/session/KyuubiSessionImpl.scala
78.83% <ø> (+0.87%)
:arrow_up:

...g/apache/kyuubi/operation/BatchJobSubmission.scala
75.75% <66.66%> (-0.98%)
:arrow_down:

...apache/kyuubi/session/KyuubiBatchSessionImpl.scala
88.37% <100.00%> (+1.78%)
:arrow_up:

...cala/org/apache/kyuubi/session/KyuubiSession.scala
100.00% <100.00%> (ø)

...client/exception/RetryableKyuubiRestException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../org/apache/kyuubi/client/RetryableRestClient.java
48.78% <0.00%> (-24.40%)
:arrow_down:

...ubi/plugin/spark/authz/serde/tableExtractors.scala
82.00% <0.00%> (-11.03%)
:arrow_down:

.../kyuubi/server/mysql/constant/MySQLErrorCode.scala
13.84% <0.00%> (-6.16%)
:arrow_down:

...uubi/engine/spark/events/SparkOperationEvent.scala
88.88% <0.00%> (-5.56%)
:arrow_down:

...ache/kyuubi/server/mysql/MySQLCommandHandler.scala
77.77% <0.00%> (-4.05%)
:arrow_down:

... and 37 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

cc @ulysses-you  @wForget

By the way, I think the SessionType.SQL type is confusing, because the SessionType.SQL type of Session can also execute scala, python, etc.

By the way, I think the SessionType.SQL type is confusing, because the SessionType.SQL type of Session can also execute scala, python, etc.

Yes, maybe INTERACTIVE is better.

thanks, merged to master


docs(protocol-definitions): Update and fill in documentation on Client-related types

This PR is an early work in progress. Any recommendations for how to fill in TODOs / expand on what I've already added would be greatly appreciated 🙂

I split out some of the settled details into a separate PR while other details are being worked out here.
#15284


Fixes EqualWeightingPortfolioConstructionModel not flattening expired insights

Description

When there are or aren't new insights, the EqualWeightingPortfolioConstructionModel will creates a target to flatten delisted securities from the universe of expired insights.
Helper methods were added to deal with removing expired insights and getting active ones and used in EqualWeightingPortfolioConstructionModel
Adds unit test
Updates framework algorithms

Related Issue
Closes #2380
Motivation and Context
Fixes bugs in EqualWeightingPortfolioConstructionModel.
Requires Documentation Change
Yes. We should state in documentation that this model will remove expired insights.
How Has This Been Tested?
Unit and regression tests.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description or feature-<issue#>-<description>

Please consider the impact of this PR on these changes: https://github.com/QuantConnect/Lean/pull/2385

One of the more complex refactors to date despite being a fairly simple model. The EWPCM considers a number of points in this refactor:

When an asset is delisted from the universe; we should remove it from the insights collection and send a signal to the execution model to trigger a position flattening.

When there are multiple signals for different periods we should allocate accordingly to the one which is expiring soonest. E.g. 1-day downtrend combined with a 1-minute uptrend. This allows people to manually trigger short-term insights for scalping style models while also being compatible with long-term rebalancing strategies.

Even when there are no insight changes; the weighting of the assets can change significantly over a few days as the prices move. We needed a rebalancing period in addition to the simple rebalancing on insight expirations.

When insights expire; only flatten the position when there are no other active insights in the collection. Be smarter about handing those expirations to minimize fees.

Thanks to @AlexCatarino @mchandschuh


update taquito plugin e2e tests

🌮 Taqueria PR
🪁 Description
Convert the e2e tests for Taquito plugin to use a safe testing library and make tests atomic.
🪂 Pre-Merge Checklist (Definition of Done)
🚦 Required to merge:

[ ] ⛱ I have completed this PR template in full and updated the title appropriately
[ ] ⛵ My code builds cleanly, and I have manually tested the changes
[ ] 🏄♂ Another team member has built this branch and done manual testing on the change
[ ] 🏖 New and existing unit tests pass locally and in CI
[ ] 🔱 The test plan has been implemented and verified by an SDET
[ ] 🦀 Automated tests have been written and added to this PR
[ ] 🐬 I have commented my code, particularly in hard-to-understand areas
[ ] 🤿 Corresponding changes have been made to all documentation
[ ] 🐚 Required changes to the VScE have been made
[ ] 🪸 Required updates to scaffolds have been made
[ ] 🚢 The release checklist has been completed

🛩 Summary of Changes
Please include a summary of the changes to the codebase. Please also include relevant motivation and context for the change
(e.g. what was the existing behaviour, why did it break, etc.)
🎢 Test Plan
Please describe the testing strategy and plan for this PR. Keep this lightweight and anticipate any testing challenges
🛸 Type of Change

[ ] 🧽 Chore ➾
[ ] 🛠 Fix ➾
[ ] ✨ Feature ➾
[ ] 👷 Refactor ➾
[ ] 🧪 Pre-Release ➾
[ ] 🚀 Release ➾

   const { execute, spawn, cleanup } = await prepareEnvironment(); // should this go in beforeAll instead? Not sure
    afterAll(cleanup);

Yes, I plan to do these refactorings after having worked through the essential elements and made sure they work. Thanks.


Replace Giraffe.ViewEngine with Feliz.Engine for a new Html & Css DSL

Make the Html & Css DSL typesafe and user friendly by leveraging the great work done by the F# community in
https://github.com/alfonsogarciacaro/Feliz.Engine
Extends the HTML attributes with additional Dash specific attributes like n_click etc..
Addresses #8 partially (for Html components)
Addresses #4 (" Inline CSS Style DSL")

Thank you! On a side note, we now have to adapt the docs to reflect this change before releasing this.


Update README

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

@achandmsft can you please review when you get a chance. Thanks.

Published a more comprehensive Readme.


Add typesync to Types section

https://github.com/jeffijoe/typesync
Dont have to manually install types, it will look for what packages you have in your package.json file and automatically add the types

Merged. Thank you @cogoo


Taker checks balance before taking an offer

I think it is more resilient to check this before we start.
At the moment even if we know that we can't open the CFD we will create it in the database and then hope to add a failed event and eventually clean it up and move it to failed. Quite a lot of work if we already know it won't work out in the first place.
This might impact usability, because we get feedback on the wallet having a problem early - which might be annoying at times, but I think in the long run this is better because we can react to the problem rather than pushing this out by "failing the setup".
Opening this for the taker only for now, I think the maker could also do a balance check and reject in case the balance is not available of insufficient.

Please let me know what you think considering adding a check on the maker as well!

bors r+

Let's see what testnet says :)


Gi-plan Nuget-package

Changes are for Gi-plan.

Updated files to get sample from nuget file-path
Updated message types for expected responses, responses and requests.

should coincide with https://github.com/ks-no/gi-plan/pull/3


Add an AsthmaControlCalendar component.

Overview
This will be the first of several asthma related component PRs I'll be submitting over the coming days.  I decided to split them up to both make my "final polish" exercises a bit easier and to keep the file count down to a reasonable level for each review.
This branch adds a new AsthmaControlCalendar component that I will be using in a number of places to expose asthma control feedback to participants.  It has two modes, compact and verbose.  Compact is just the calendar.  Verbose includes a list of days below it with further information about logged symptoms, impacts, and triggers for each day.

I also had to make a couple of small tweaks to the CalendarDay component to get it to render more reasonably in dark mode.
Security
REMINDER: All file contents are public.

[x] I have ensured no secure credentials or sensitive information remain in code, metadata, comments, etc.

[x] Please verify that you double checked that .storybook/preview.js does not contain your participant access key details.
[x] There are no temporary testing changes committed such as API base URLs, access tokens, print/log statements, etc.

[x] These changes do not introduce any security risks, or any such risks have been properly mitigated.

Describe briefly what security risks you considered, why they don't apply, or how they've been mitigated.
Checklist
Testing

[x] MyDataHelps iOS app
[x] MyDataHelps Android app
[x] MyDataHelps website

Documentation

[x] I have added relevant Storybook updates to this PR as well.

Closing.  This change is included in https://github.com/CareEvolution/MyDataHelpsUI/pull/203.


Settings Screen

Create Settings Screen containing:

[ ] Your Orders Screen
[ ] Change User Name/Password
[ ] FAQs Screen: @ritvij14
[ ] Log Out Button
[ ] Manage Address
[ ] Notification(enable or disable)
[ ] T&C
[ ] GitHub Repo Link Button

@himanshusharma89 I would like to work on this issue. Also, do these tasks need to be completed in multiple PRs or in a single PR?

@ritvij14 Are you participating in GSSOC? If so, I'll assign it to you.
For this issue, you need a settings icon on the top right corner of the profile screen which will then navigate to the settings screen.
The settings screen will contain the list of the above-mentioned tasks, some of them will have a new page some of them don't. You can start with one task at a time.

@himanshusharma89 yes I am participating in GSSOC '21 as a mentee.
Ok got it. So for now to get an idea of the project I would like to go ahead with the Logout button and FAQs section. Does FAQ have a button that leads to a webpage with FAQs or are we showing them in the app itself?

@ritvij14 You can start with the FAQs section, you can get the free FAQs content online and use PDF Viewer to display it

@ritvij14 The settings icon on the profile will be taken care of by someone else.

I would like to work on setting icon under Gssoc'21

@ritvij14 You can start with the FAQs section, you can get the free FAQs content online and use PDF Viewer to display it

@himanshusharma89 sorry but I am a bit confused 😅, like how many questions and what material/questions should be answered in them etc.
And should I go ahead with this for showing the pdf? https://pub.dev/packages/native_pdf_view

@DevilAj, you can comment on any other issue, these are assigned to others.
@ritvij14 You can refer to this: https://github.com/himanshusharma89/flutterx100/blob/master/lib/helpers/constants.dart
You'll get an idea of FAQs. And yes you can use this package. Make sure to make it not scrollable.

Create Settings Screen containing:

[ ]  Your Orders Screen
[ ]  Change User Name/Password
[ ]  FAQs Screen: @ritvij14
[ ]  Log Out Button
[ ]  Manage Address
[ ]  Notification(enable or disable)
[ ]  T&C
[ ]  GitHub Repo Link Button

can i create work on the setting screen creating all those buttons ?
plz assign me this issue @himanshusharma89

@anotherwebguy You can select a single button from the issue and wait for this PR to be merged: #108

@anotherwebguy You can select a single button from the issue and wait for this PR to be merged: #108

Actually i've designed the layout of the settings screen
https://user-images.githubusercontent.com/66346161/110945858-37bc7d00-8364-11eb-8a49-6ef14b36ad67.mp4

@anotherwebguy You can select a single button from the issue and wait for this PR to be merged: #108

Actually i've designed the layout of the settings screen
WhatsApp.Video.2021-03-12.at.6.52.29.PM.mp4

does this looks good?

Yeah, this looks good, @ritvij14 you can follow this design. And also, the Settings screen might be integrated by tonight, so you can integrate your work into it. Also, @anotherwebguy I'll assign you some part of this issue as soon as the profile fix is merged.

Yeah, this looks good, @ritvij14 you can follow this design. And also, the Settings screen might be integrated by tonight, so you can integrate your work into it. Also, @anotherwebguy I'll assign you some part of this issue as soon as the profile fix is merged.

so after the profile fix is merged i should integrate the settings layout into it right?

@anotherwebguy Not the whole screen and buttons, but the layout only.

@anotherwebguy Not the whole screen and buttons, but the layout only.

yeah only this layout i mean bcoz the functionality of the buttons will be designed by others right?

Yes @anotherwebguy

@himanshusharma89 can I work on change username and password screen?

@himanshusharma89 I would like to work on the github repo link button

@himanshusharma89 can I work on change username and password screen?

Sure, but follow the current layout

@himanshusharma89 I would like to work on the github repo link button

Sure but the button is already linked, can you add the in-app web view on pressing the button?

Yes, I would like to try that

Yes, I would like to try that

You are assigned, follow the current theme to create the in-app web view

Hey @himanshusharma89  i would like to work on the change addressed screen. Plz assign me this issue. Thanks:)

@himanshusharma89 sorry about late updates but because of some reasons I will be unable to contribute to this issue. Please give my task to someone else.

Well i can work on the the faqs screen with pdf viewer after i'am done with manage address screen

Sure @anotherwebguy

hello @himanshusharma89 sir i've created the manage address screen plz take a look
should i  make a pr now?
https://user-images.githubusercontent.com/66346161/111302184-15cf3d00-8679-11eb-96a8-529cbbd93ad7.mp4

So now can i work on faq's screen @himanshusharma89

https://user-images.githubusercontent.com/66346161/111579552-349a1480-87dc-11eb-88c7-661703a41162.mp4
Sir i've designed the faqs screen plz take a look @himanshusharma89
Shoul i make a pr now?

@ShrutiJ-01 Any update on your part?

@himanshusharma89 Almost there, will be making PR soon

@ShrutiJ-01 Facing any issue?

@himanshusharma89 I want to work on the T&C Screen.

@ShrutiJ-01 Any update?

@ShrutiJ-01 Any update?

Should i do it ?

@himanshusharma89 Extremely sorry! couldn't finish it on time because of exams.I Will make a PR today itself

@himanshusharma89 I would like to work on the Logout button.

Create Settings Screen containing:

[x]  Your Orders Screen
[x]  Change User Name/Password Screen
[x]  FAQs Screen
[ ]  Log Out Button: @SapinderSingh
[x]  Manage Address
[ ]  Notification(enable or disable)
[x]  T&C
[x]  GitHub Repo Link Button: Open the in-app web view

i have already added the notification toggle button in the settings screen is there anything else related to it that needs to be done? i can work on it then?

@anotherwebguy We'll have a particular screen for this also, where user can choose to enable disable the notification

@anotherwebguy Yes you can but do follow the lining rules and resolve the problems(don't ignore them) also don't use Extra widgets for anything unnecessary. I have to clean the code letter. The screen will consist of some text on top which will tell user what does this do and below it, we will have a ListTile for toggle as trailing

@anotherwebguy Yes you can but do follow the lining rules and resolve the problems(don't ignore them) also don't use Extra widgets for anything unnecessary. I have to clean the code letter. The screen will consist of some text on top which will tell user what does this do and below it, we will have a ListTile for toggle as trailing

Okay i'll keep that in mind i can work on this plz assign it to me

@himanshusharma89 i'm not able to signup in relic bazar it says invalid request

@himanshusharma89 i'm not able to signup in relic bazar it says invalid request

Are your trying Google Auth? If so, you need to add your SHA-1 key into the firebase console for that.

@himanshusharma89 i'm not able to signup in relic bazar it says invalid request

Are your trying Google Auth? If so, you need to add your SHA-1 key into the firebase console for that.

No iwas trying email auth but it isn't working for me can u plz add my sha keys on firebase so atleast i can login through google auth and work on the issue if yes then i'll share my sha keys over discord dm to you?

Sure @anotherwebguy

should i  make a pr now @himanshusharma89 ?

@anotherwebguy Just make sure that you use already created Widget for the stacked view

@anotherwebguy Just make sure that you use already created Widget for the stacked view

Yes i've used that only @himanshusharma89
So i am making the pr tomorrow the


Artemis wasn't able to display the points accumulated by the drag and drop function in text exercises

Describe the bug
When you want to assess text exercises from the students, and use the drag and drop function with the assessment templates which are located under "Assessment of the Definition", the points are not counted and accumulated directly. The students points count stays by "0/2"
At first you have to manually click on the points (Increase or Decrease) and just then the points get counted and accumulated correctly and displayed (e.g "2/2").
To Reproduce

Go to 'Tutor Course Dashboard'
Click on "Exercise Dashboard' of a Test Exercise
Click on 'Start new assessment'
Drag and Drop the assessment templates provided by the instructors which are located under "Assessment of the Definition" on the right side
Now you can see no change in the points the student would have at the moment. The Counter stays at "0/2"

Expected behavior
After dragging and dropping the assessment templates, the points for the student should directly match the points given by the used assessment templates
Screenshots

Environment

 - OS: macOS Catalina
 - Browser safari
 - Version 13.1

Additional context

Output in Web Console

  [REPLACE THIS WITH YOUR INFORMATION]

Thanks for the bug report, I think this is a duplicate
@HanyaElhashemy can you confirm?


Nested menues rh

Provide a description of what has been changed
Checklist

[ ] Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

Can you elaborate on what this change is please?

Looks like perhaps a change is also needed to navbar.html


Serenity.CoreLib.js.map is missing running under VS 2015

Hi,
when I run the example, all comes good but I have this issue in the VS output logs. "failed to read sourceMap ... / ... Serenity.CoreLib.js.map is missing .
Is that a problem ?
Many thank's for your amazing job 👍

There is no such file, VS searches for it anyway


feat: csp nonce support

Description
This PR adds CSP nonce support for dev and build.

In dev

CSS imports in JS: If any script tag or style/link[rel=stylesheet] tag has a nonce attribute, @vite/client will inject the style tag with that nonce value.
Injected script/style/link[rel=stylesheet] tags by transformIndexHtml: normal/post hook now can have access to ctx.nonce that contains a nonce attribute extracted from the HTML. Each plugins has the responsibility to inject the nonce tag if needed.

In build

preload function: If any script tag or style/link[rel=stylesheet] tag has a nonce attribute, it will add the link tag with that nonce value.
nonce values in HTML: the value would be preserved for usecases like replacing the value in the middleware (e.g. nginx)

close #9719
close #11862

Difference from

#11864: read the value from meta[property=csp-nonce] and use that when injecting style tag generated by CSS imports in JS

Requires a custom tag for declaring the nonce value. In my PR, Vite uses the nonce value that is already declared.
Works with different nonce value for script-src and style-src. In my PR, that is not supported unless there's a style tag in the HTML. If we add a fallback to obtain the value from meta[property=csp-nonce-style], we can support this case as well.
Doesn't handle injected tags by transformIndexHtml. My PR handles that.
Doesn't handle preload function. My PR handles that.
Works with backend integration. My PR also works.

#11958: adds a new option noncePlaceholder and inject that value in HTML when bundling

Adds a new option. In my PR, Vite uses the nonce value that is already declared.

Things to consider

nonce should be generated for each request. Preserving the nonce value of the input HTML might provoke a misusage of using a static value for nonce.

TODO

[ ] Add a test case
[ ] Warn if there's multiple nonce values
[ ] Add docs

Additional context
This table (https://github.com/vitejs/vite/pull/11864#issuecomment-1716852907) was really helpful to think about the way to support CSP nonce. Thank you @justin-tay.

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

Hi,thanks for this PR,i really need this feature,
does this fix for vite react too?
my project is using CSR with vite react,am urgent need this.

Great PR! I hope this is considered by the Vite team. Looking forward to some sort of dev-side CSP for style sheets landing, this would get us one step closer in having our dev & production CSP files identical.

I think this is the most complete solution.  What do you think about requiring the meta tag(s)?  Essentially adding the meta tags is the configuration to inject the nonces.  This prevents having to copy paste a bunch of nonces or placeholders in the .html file.  Instead just editing 1 (or 2) meta tags updates everything accordingly.
Default can be the specific nonce type, with fallback to unspecified version if the user does not want to separate them.

that would be really awesome to get this ready before the upcoming 5.0 official release 😉

@q7314568 Without a non-static server, this PR won't be useful because you need to generate a nonce for each request.

@gregtwallace I think most of the case, there'll be only one script tag and one style tag. But I'll include this point in the team discussion. 👍

@ghiscoding This PR won't land in 5.0 as we're in the final phase of the release (kind a RC phase).

Thanks for the update @sapphi-red. As this does encourage better application security practices, I hope it is prioritized post 5.0 release. While it just applies to dev mode, being able to align our development CSP closer to production one encourages our team to be more thoughtful along with catch CSP errors earlier on the process. I know we have already been bit by a change which worked in dev, but our stricter production CSP caused an error.
As a rails user, add my vote for making use of the meta csp-nonce tag as it is standard in those installs. See rails docs here: https://api.rubyonrails.org/classes/ActionView/Helpers/CspHelper.html

Now that v5 is released, is there any updates on this security related improvement @sapphi-red ?
We continue to see folks running into this issue as building stricter CSPs becomes more common. Not being able to setup Vite development mode with the same nonce settings as production is the only blocker for folks to do so in many cases. I would hope a security related issue like this gets prioritized accordingly as we all try to build more secure web software together.
https://github.com/vitejs/vite/pull/11864#issuecomment-1857567464
https://github.com/vitejs/vite/discussions/5218#discussioncomment-7865651

I have been monitoring this thread and I'm curious about Vite's support for CSP headers. While there is a workaround provided by @schamberg97 in this issue [https://github.com/vitejs/vite/issues/11862](Issue setting strict CSP in dev), I'd like to know if official support will be added in the near future before implementing the workaround.

superseded by #16052


Header not sticking properly to the top with more then one cell on the section.

Each section has a header and two items with variable sizes.
The header has a fixed size of the x= width of the screen and y = 48
The image cell has the size x =  width of the screen and y = width of the screen or less
And the text cell has a size x =  width of the screen and y bigger than 112.
For some reason when first scrolling the section header is losing his place and then going back, but after I scrolled through at least one time this doesn't occur anymore.
Could this be a problem on your end or am I doing something wrong.
Great project and I hope this is on my end so that this is not a bug for more people.

I discovered that the problem was on my end, when loading the image from the database I was reloading the cell to change the size for the image however that was creating a bug in the app. I fixed that by using in swift:
collectionView.collectionViewLayout.invalidateLayout()
which makes the collection view re-calculate the size for the sections
Great api.

thanks for the info Matheus! Great job and let me know when your app releases, we can add it to the wiki page if you like :D


Private view methods

The purpose of this issue is to follow up the conversation from #890 and #1025 on private view methods. I quote here the comments to make it easier to overview. Related issue: https://github.com/near/near-sdk-rs/issues/937.
In #890 @itegulov asked:

Should view functions be allowed to be private? Wouldn't such a function only be callable from a transaction?

In #890 @austinabell replied:

No, even calling env::predecessor_account_id fails in view contexts at runtime. This should be restricted at compile time. Good callout!

In #1025 @agostbiro wrote:

A reviewer in https://github.com/near/near-sdk-rs/pull/890 commented that private view functions shouldn't be allowed. This wasn't implemented in https://github.com/near/near-sdk-rs/pull/890 and when I made the change several tests failed, because methods that take &self as argument are considered ~private~ view. Example failing test case:
#[private] pub fn method(&self, #[callback_unwrap] x: &mut u64, y: String, #[callback_unwrap] z: Vec<u8>) { }

On a related note, at first I was surprised that methods that take self by value are view, but I guess that it makes sense since they cannot mutate the object. As I haven't found a test case for this I added one to make sure that method(self) isn't payable in https://github.com/near/near-sdk-rs/commit/56394ec234587b8195005b8b601c9b80c24b2247.

In #1025 @itegulov replied:

I think you meant that methods that take &self argument are considered view, right? So, as @austinabell mentioned in the original PR, view methods can never be private. That being said, the current near_bindgen API is flawed in that it does not provide clear control of which methods are view or call. There are a couple of ways we could resolve this that we have discussed in the past but never :

Make private, payable and other such modifiers automatically mean that this method is call
Create #[call] and #[view] modifiers and slowly phase out the old self-based deduction system
Just leave everything as is, it has been working so far

In any case, probably out of scope for this PR, just though I would share this here since its related to the work you are doing. I propose we do not prohibit private view functions for now and move this conversation to a separate issue.

I did a bit a of testing now with this contract:
#[near_bindgen]
#[derive(BorshDeserialize, BorshSerialize)]
pub struct Contract {
    message: String,
}

#[near_bindgen]
impl Contract {
    pub fn get_greeting(&self) -> String {
        return self.private_get_greeting();
    }

    #[private] pub fn private_get_greeting(&self) -> String {
        return self.message.clone();
    }
}

And I found that I can call get_greeting both with an Account::call and a Contract::view, so maybe it's fine as it is and we don't have to disallow private view methods?

And I found that I can call get_greeting both with an Account::call and a Contract::view, so maybe it's fine as it is and we don't have to disallow private view methods?

This is because you're not using the #[private] annotation for what it's intended for. The use case is making a cross-contract call from the current contract (commonly used for callbacks).
The pattern that I believe we were referring to disallowing at compile time is
#[private] fn private_get_greeting(&self) -> String {

Since you wouldn't be able to make a cross-contract call to this since it is a view (non pub) function

And I found that I can call get_greeting both with an Account::call and a Contract::view, so maybe it's fine as it is and we don't have to disallow private view methods?

This is because you're not using the #[private] annotation for what it's intended for. The use case is making a cross-contract call from the current contract (commonly used for callbacks). If you call private_get_greeting as a view call (scheduled through this proxy or calling directly), you'll see it will fail with handler error: [Function call returned an error: wasm execution failed with error: HostError(ProhibitedInView { method_name: "predecessor_account_id" })].

Thanks for clarifying @austinabell ! I managed to reproduce the error with my code when calling private_get_greeting directly as view, and with the code that you provided by calling get_greeting as view.
I'm still not 100% clear on why the error doesn't occur when calling get_greeting as view in my code. Is the code executed different or is the runtime environment different? Is there anywhere I can read more about this?
Btw while testing this I ran some circles, because I didn't realize that the test:integration command doesn't rebuild the contract, so I'm submitting a PR for that in create-near-app.

I'm still not 100% clear on why the error doesn't occur when calling get_greeting as view in my code. Is the code executed different or is the runtime environment different?

@agostbiro self.private_get_greeting() just calls the function on the struct, but calling view function from RPC, it goes through an onramp created by near_bindgen:

Is there anywhere I can read more about this?

I only trust the source code:
https://github.com/near/near-sdk-rs/blob/e4cb471631c55fb8831403ffea12afc71030abc1/near-sdk-macros/src/core_impl/code_generator/item_impl_info.rs#L36-L52

Ah got it, thanks @frol !
So the conclusion seems to me that there are no changes needed regarding private view functions. Did I understand that correctly?

@agostbiro Well, given that there is no use for private view functions (they will just fail), it would be great to forbid them at compilation time (#private + &self should be forbidden). Would it be hard to implement? (sounds like a trivial assert after the refactoring, but I don't have the full context in my head at the moment)

@frol the main issue here is that a lot of contracts in the wild have methods that are view according to their self usage, but not view semantically and are always called in transaction context (@agostbiro provided some examples above). Making this change will break the existing code for them which is why this would have to be a multistep process where we have to decide whether we want to bother with enforcing the view/call unambiguity first.


Add math constant math.tau

Tau is the mathematical constant which is equal to 2 * math.pi.
This number is special because it represents a full turn in radians.
I believe this would be beneficial because when dealing with angles in radians, it looks cleaner to write math.tau (a built in library constant) instead of math.pi * 2 or defining it yourself in a variable.
This is also a feature in python.
https://en.wikipedia.org/wiki/Turn_(angle)#Tau_proposals

This would need an RFC.

Tau is the mathematical constant which is equal to 2 * math.pi.

I don't believe this is needed enough. math.pi * 2 serves the need.

This is also a feature in python.

Be careful with this, python is by no means a perfect language and there's no reason to borrow from it without other legitimate reason.

I'm going to close this since this isn't actionable by itself - there either needs to be an RFC for this with good justification as to why we need to do this, or we shouldn't do this.


[Feature Request]: Move SEO meta definition  to Analog RouterMeta

Relevant Scope
angular application
Description
The application currently uses the Title and Meta to update the application metadata for SEO purposes.
Describe the solution you'd like
Use Analog RouterMeta API instead: https://analogjs.org/docs/features/routing/metadata#route-meta-tags
It affects components in the pages folder.
Describe alternatives you've considered
No response

Completed


gd everytime crash when i open

i just paste xinput9_1_0.dll to GD Folder and create adaf-dll folder and paste replay-mod.dll and when i open gd, its just crash

Same here, except it crashes when I try to play a level


Pdfized rendering doesn't linkify adjacent reference callouts

What happened?
When two reference callouts are adjacent to each other (e.g., [RFC1111][RFC2222] ) with no space between them, the second one is not converted to a link in the PDF rendering. It is correctly linkified in the HTML rendering.
Example: draft-ietf-ipwave-vehicular-networking-27, Section 6, paragraph 3:
[RFC4301][RFC4302] [RFC4303][RFC4308] [RFC7206]
RFC4302 and RFC4308 are not linkified because they aren't separated by spaces; the others are.
What browser(s) are you seeing the problem on?
Firefox
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

This will be fixed as part of #4082.

I checked the doc above, and this is fixed now.


URL parameters aren’t documented

Endpoint, key and diagram parameters should be mentioned in the install or user guide.

Added documentation here: https://github.com/awslabs/aws-media-services-application-mapper/blob/master/INSTALL.md#optional-parameters
Three parameters are shown: diagram, endpoint, and key.


updated meshmentors image

Signed-off-by: Atinuke Bami Kayode<EMAIL_ADDRESS>Description
This PR updates the MeshMentors image in the README file
This PR fixes #70
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

@navendu-pottekkat @Zain-Muiz @warunicorn19 this PR has been opened for 3 days waiting to be reviewed. Can anyone review it, please?


Like button

Adding a like button with likes showing.

please don't open multiple issues for the same thing.


Weird behaviour of a styled.View inside a react-native ListView

Version
1.4.3
Reproduction
https://github.com/dbertella/RNstyledPlayground
Steps to reproduce
Using a styled.View inside a ListView will may cause issues.
I have a component declared in this way:
const Row = styled.View`
    flex: 1;
    flex-direction: row;
    justify-content: space-between;
`;

It should render two different texts one on the left and one on the right inside a View inside a List.
Expected Behavior
It will render correctly without any part of it being hidden by other components.
Actual Behavior
It will loose its height causing to be hidden or partially hidden.
If you look at the code in the repository, I put a the exact component but not a styled one so:
<View style={{ flex: 1, flexDirection: 'row', justifyContent: 'space-between' }}>...</View>

and it renders correctly.
Just below this line I have my <Row>...</Row> component and it ends up cut as you can see in the image preview in the repository.
The exact structure of my code example is this:
  <View style={{ borderBottomWidth: 1 }}>
    <View style={{ flex: 1, flexDirection: 'row', justifyContent: 'space-between' }}>
      <Text>{rowData.name}</Text>
      <Text>{rowData.date}</Text>
    </View>
    <Row>
      <Text>{rowData.name}</Text>
      <Text>{rowData.date}</Text>
    </Row>
    <Text>{rowData.body}</Text>
  </View>

What's the difference between my Row component and a View with the same style then?

Further information about that. If I set flex: 0 the Row component seems to render well.
I even have a weirder behaviour in my real app.
As you can see in the gif every line of the list should be the same, but in the first 10 lines the Row component disappear after the initial render, in the last two or three it stays there. In this case the Row contains the word POP and the time ago.

Follow up, I tried to make a snapshot test and this is what I get from the two components:
This is the "normal" View with style:
<View
    style={
      Object {
        "flex": 1,
        "flexDirection": "row",
        "justifyContent": "space-between",
      }
    } />

This is the styled Row component
  <View
    style={
      Array [
        Object {
          "flexBasis": 0,
          "flexDirection": "row",
          "flexGrow": 1,
          "flexShrink": 1,
          "justifyContent": "space-between",
        },
        undefined,
      ]
    } />

Basically I've found out that flexShrink is what it's causing the bug. Could it be a wrong wrap between styled component style and the rn-style then?

Could it be a wrong wrap between styled component style and the rn-style then?

@jacobp100?

flex is a shorthand for flex-grow, flex-shrink and flex-basis.
You either want flex: 1 0 or flex-grow: 1.

Is it suppose to be like that then? I think in this case for the RN side it's not a shorthand, it suppose to stay as it is.
You can see it yourself from the snapshot test.
From the RN documentation:

... and the flex parameter only supporting a single number.

I see your point in trying to stick with the css for the web, but in this case it will lead to unexpected behaviours in my opinion.

I didn't realise the flex value was so different from CSS.

In React Native flex does not work the same way that it does in CSS. flex is a number rather than a string, and it works according to the css-layout library at https://github.com/facebook/css-layout.
When flex is a positive number, it makes the component flexible and it will be sized proportional to its flex value. So a component with flex set to 2 will take twice the space as a component with flex set to 1.
When flex is 0, the component is sized according to width and height and it is inflexible.
When flex is -1, the component is normally sized according width and height. However, if there's not enough space, the component will shrink to its minWidth and minHeight.
flexGrow, flexShrink, and flexBasis work the same as in CSS.

You're right that this will confuse people. This may have caused breakages when we introduced it, but reverting it may also cause breakages (@mxstbr). I'm slightly hesitant about reverting, because this is the first bug report on this. Whatever we choose, this needs to be documented.
When they added the -grow, -shrink and -basis properties, they did not mention intent to deprecate the flex property. However, while Yoga (formerly css-layout) supports this flex property, it does not document it. It seems like this is not a property you'd want to use in new code.
In v2, I feel like the right direction to go is to move away from this property and use the shorthand for flex. But I'd like to find out more about the intended future and use-cases of the current property before deciding on this.
Possibly beside the point now, but I looked at your example in more detail. Do you actually want flex defined at all? You didn't specify a flex-direction on the parent, so this defaults to column, meaning the child view is resized vertically. I think this is what you're seeing.

Thanks for looking into it! I think you are right and this library should be as possible as close to the web css so it might just needed a bit of documentation. In my specific case I solved using flex={0} but I wanted to understand what was the difference between the two components.
My use case it's more large then the example because I use always the same component and I pass props to use it in different part of the app.
So sometimes I don't really need to specify the flex property as this time apparently but it will fallback to flex: 1 where is not specified.
Something like this:
const Container = styled.View`
    flex: ${({ flex }) => flex || 1};
    flex-direction: ${({ direction }) => direction || 'column'};
    justify-content: ${({ justify }) => justify || 'flex-start'};
    align-items: ${({ align }) => align || 'stretch'};
    margin: ${({ m }) => m || 0};
    padding: ${({ p }) => p || 0};
`;

I have actually another question, but it's not related to the specific issue.
Using a styled-component as mention above in RN can lead to some performance problem in your opinion?
I know the stylesheet Object is heavily cached, and I think styled-component will use it at some point, am I right?
What about passing props at runtime? What's going to happen?
Because I'm really happy using this component it's really fast to prototype, but if it can be a problem I will find another solution.
Thanks again anyway!

On Topic (for Max)
We still need to,

Decide if the flex shorthand should be reverted to RN's flex property

I think we should keep the shorthand

Document the decision we make

Perf Question
I'll answer the question here, but if you want to continue, please open up another issue!
I'm don't think anything has been benchmarked, but it's something I'd like to see. Most of the time spent in styled-components will be parsing, but I don't think we know how much time is spent here.
In RN, every time your props change in a way that changes the CSS text, it gets re-parsed. This is probably negligible for a single component. However, when you load the app, you'll have to parse CSS for every component that gets mounted. If you have a global theme and change a value, that'll trigger a large re-parse for every component that depends on the theme.
If you're concerned about perf, you can set the default styles with styled-components, and override the styles in the style property.
const ContainerDefaults = styled.View`
    flex: 1;
    flex-direction: column;
    ...
`;

const Container = ({ flex, direction ... }) => (
    <ContainerDefaults style={{ flex, direction ... }} />
);

This will only require one parse, no matter what styles you pass in.
If you want to eliminate the parse time, you can look at my almost identical project. It's more limited in what you can do, but I think the limitations are a good thing!

Wow, thank you very much for the complete answer, do you think it will be worthy to open a discussion about it in another issue or something? We can maybe add some benchmark, that should be very interesting from my point of view.

Please do!

I think we should keep the shorthand

Why? Won't that be confusing for everybody picking up styled-components coming from ReactNative?

I think if we say we support shorthands, and flex is a shorthand, then not using the shorthand would be equally confusing—hence we need to document the decision we make.
I think that in most cases, people won't notice we use the shorthand instead. This is the first bug report on this, but in this case, using RN's flex property instead of the shorthand was not the solution.

+1 for documenting this, regardless of the decision on what the proper behavior is.
I am new to both React Native and Styled-Components, and the flex: 1 property tripped me up because it is clearly documented on the RN side as being a major difference between React and RN. I never expected that this:
const StyledView = styled.View`
    flex: 1;
`;

would result in this:
style={
  flexGrow: 1,
  flexShrink: 1,
  flexBasis: 0, // shouldn't this default to `auto`?
}

My expectation was that flex: 1 was going to transfer directly with no translation.
My plan is to drop the use of flex altogether and stick to explicitly setting the other 3 parameters.

It looks like we never got a conclusion on whether to continue to use the flex shorthand. I think it is the right thing to do, but we should have documentation on this (any takers?)
In terms of flexBasis, if you use the flex shorthand and omit the flex-basis, it defaults to zero (relevant part in spec).

@jacobp100 I propose we just add some notes to the React Native section of the website. We had that issue on border as well, and while there's no definitive solution on either, an entry to the docs would clarify this issue

I agree! I'll try and find some time to do this!

This seems to apply to use of the styled primitives stuff we have too, which was fun to run into and debug.  Reading this issue helped me understand what was happening

Closing in favor of https://github.com/styled-components/styled-components-website/issues/182, would love if somebody could add that note to the docs!

HOLY I WAS STUCK ON THIS BUG FOR 4 HOURS!!!

Someone needs to make a warning that React Native Flex: 1 Does not convert to Styled Components as Flex: 1 but rather Flex: 1 0 (Styled) == Flex: 1 (React Native). :'(

Sorry about that! I’m not really sure what the best approach is. RN has the CSS defaults for flex grow, shrink, and basis. It’s just that the RN flex prop sets all of these values in a way different from CSS’s flex prop.
I’m not sure we can really warn about this, but we could definitely document it more obviously!

Would https://github.com/styled-components/styled-components-website/pull/291 have helped you?

Hi @jacobp100,
Wow, thanks for the prompt response that's amazing. So yeah as I was searching for the mistake I checked the React Native section of Styled. But I would suggest implementing this for RN -> Styled Inconsistencies.
React Native
-> Flex Section
-> Pixels Section
-> A Section for Each error that the community has come across.
Have sections or at least an appendix can make finding the correct issue much quicker than scrolling through the whole page for a small warning tag. Also maybe citing the CSS official rules as Styled is referencing it might also teach developers WHY it's happening like this and that it's a standard rather than a custom implementation detail by the Styled Components Community.

@jacobp100
Is there any way to opt out of this translation for specific styles like flex in this case. (I sifted through some code but couldn't find it. Thought I'd ask to be sure.)
css-to-react-native's transform api has a second argument that can be used to opt-out.
Is there anyway to trigger/access this during creation of a Styled Component, for example
styled(View, {transformOptout: ['flex']})`
   flex: 1
`


Burrower Tremor

About the PR

Added Tremor ability
Cost 100 plasma
Delay 60
Fixed Burrower Construction Component
Why / Balance
Contribute to making burrower playable soon by Lordin
Technical details

Media
Requirements

[x] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
Changelog
:cl:

add: Added Burrower Tremor Ability
fix: Fixed Burrower Construction Component

The not-passed check failed because test map contains RPED, seems not my fault

burrower  !!sweep!!??!