fix(explore): adhoc metric label and control value not consistent

SUMMARY
fix  #12367
Closes #12367

adhoc metric control must reset state when close Popover

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN
add e2e in future
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12381 (aadc60e) into master (1250426) will decrease coverage by 3.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12381      +/-   ##
==========================================
- Coverage   66.87%   63.29%   -3.59%
==========================================
  Files        1014      485     -529
  Lines       49508    29873   -19635
  Branches     5063        0    -5063
==========================================
- Hits        33110    18907   -14203
+ Misses      16268    10966    -5302
+ Partials      130        0     -130

Flag
Coverage Δ

cypress
?

javascript
?

python
63.29% <ø> (-0.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-12.78%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/databases/api.py
86.49% <0.00%> (-5.49%)
:arrow_down:

... and 550 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1250426...8aa0f4a. Read the comment docs.

Codecov Report

Merging #12381 (aadc60e) into master (1250426) will decrease coverage by 3.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12381      +/-   ##
==========================================
- Coverage   66.87%   63.29%   -3.59%
==========================================
  Files        1014      485     -529
  Lines       49508    29873   -19635
  Branches     5063        0    -5063
==========================================
- Hits        33110    18907   -14203
+ Misses      16268    10966    -5302
+ Partials      130        0     -130

Flag
Coverage Δ

cypress
?

javascript
?

python
63.29% <ø> (-0.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-12.78%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/databases/api.py
86.49% <0.00%> (-5.49%)
:arrow_down:

... and 550 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1250426...8aa0f4a. Read the comment docs.

confirm this has been an issue for a looong time, not introduce by any recent refactoring work
@zhaoyongjie let's not worry about the mouse away for now
cc: @ktmud @kgabryje @villebro

confirm this has been an issue for a looong time, not introduce by any recent refactoring work
@zhaoyongjie let's not worry about the mouse away for now
cc: @ktmud @kgabryje @villebro

@junlincc
The Popover hide when the mouse leaves and click, Unable to change the state of a child component, this is old behavior.
refactor the adhoc metrics in the future, fix it again

@junlincc
The Popover hide when the mouse leaves and click, Unable to change the state of a child component, this is old behavior.
refactor the adhoc metrics in the future, fix it again

nooooo we need code review for this one @villebro need your help reverting. sorry about this 🤦🏾♀

nooooo we need code review for this one @villebro need your help reverting. sorry about this 🤦🏾♀

sorry.....I was too eager. I can revert this commit If needed

sorry.....I was too eager. I can revert this commit If needed

Let's rather open a new fix PR if possible @zhaoyongjie

Let's rather open a new fix PR if possible @zhaoyongjie


version 3.1.1 isn't accessible on npm

Command:
npm install<EMAIL_ADDRESS>
Result:
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>
Expected behavior:
install version 3.1.1
3.1.1 is missing from: https://www.npmjs.com/package/react-plaid-link

hi @boertel not quite sure what happened here but you are correct... it is not on there. Maybe our publishing script errored out. Either way, try installing 3.2.0 which was just published with much improved TypeScript types :)


[FEATURE] Add-PnPSiteCollectionAdmin should accept a SiteUrl parameter when connected to the tenant admin site

Is your feature request related to a problem? Please describe.
As a SharePoint administrator, I have to add site admins via the tenant admin site.
Describe the solution you'd like
SharePoint administrators have access to add site admins via the tenant admin site. They should also be able to do so via powershell if they connect to the admin site and specify the SiteUrl of the target site.
Describe alternatives you've considered
I cannot find a way to add a site collection admin to a site unless I'm already a site owner or admin, even if I have the SharePoint Administrator role.
Additional context
Add any other context or screenshots about the feature request here.

@rslavey - Isn't that what you're looking for?
https://pnp.github.io/powershell/cmdlets/Add-PnPSiteCollectionAdmin.html

hi @rslavey , as mentioned above, please use Set-PnPTenantSite cmdlet for this.


Migrate from Terragrunt to Terraform

Overview
Migrate Incubator from Terragrunt to Terraform.
Terragrunt was an important contribution to reusable Terraform at one point, but since its introduction Terraform has added features that make Terragrunt mostly irrelevant. In the meantime, it adds concepts and syntax to the infrastructure code that act as obstacles to newcomers (to ops in general, and Hack for LA in particular) to onboarding and becoming productive.
Action Items
[ ] Investigate translating Terragrunt to Terraform automatically. (The terragrunt tool does this when it runs anyway, so if the intermediate Terraform isn't too bad, maybe we can use/start with that.)
Proposed:
[ ] Migrate the existing Terragrunt code to Terraform.
This should be a straightforward change, despite touching much of the repo. It's going to be much better to complete this task all at once than to do incrementally. It's probably better to refactor Terraform later if there's a choice between a perfect, partial Terraform translation vs. a complete, imperfect one.
Resources/Instructions
https://terragrunt.gruntwork.io/docs/#reference
https://developer.hashicorp.com/terraform/language

Translation/refactoring may result in renaming resources (e.g. as that move between modules.) I've recently had a lot of success with https://github.com/padok-team/tfautomv to generate moved blocks to handle this.

@nyarly how is this process going?  Are there any updates?

This issue has been open since April and has created a blocker to our deployment process and getting the Access the Data test site up and running.  Not deploying the test site runs a risk of putting the Access the Data project on hold as well as any other project that needs deployment.
I have reached out to Jason (@JasonEb)  to set up a meeting with Judson (@nyarly) so that Judson can get the AWS credentials he needs to get this process up and running.

@nyarly Please give us an update on this issue.
Progress: “What is the current status of your project? What have you completed and what is left to do?”
Blockers: “Difficulties or errors encountered.”
Availability: “How much time will you have this week to work on this issue?”
ETA: “When do you expect this issue to be completed?”
Pictures: “Add any pictures of the visual changes made to the site so far.

As of last week, I have the accesses I need to work with Terragrunt, and I've found a translation path for one of the projects there. I intend this week to clean up the automatic translation to Terraform and issue a pull request.
I also want to build out Access the Data on the Terraform code, as well as adding some functionality to support that in a mature DevOps way. Maybe that properly should be a separate Issue? Opinions solicited, @JasonEb @merlinsmagic @mxajPrice
I think I can get as far as delivering working Terraform for PeopleDepot, as well as documentation as to how that translation was accomplished. I would expect that to serve as a template for other projects, which will need to be followed up by folks who have access to the root configurations for them. Ops as a CoP will need to start driving that process

Hi @nyarly do we have any new updates on this?
Progress: “What is the current status of your project? What have you completed and what is left to do?”
Blockers: “Difficulties or errors encountered.”
Availability: “How much time will you have this week to work on this issue?”
ETA: “When do you expect this issue to be completed?”
Pictures: “Add any pictures of the visual changes made to the site so far.

Situation here is that Terragrunt does not appeared to have stored a full state of the shared_resources modules to S3 - maybe that's because they don't all get used, or maybe because it stores them somewhere else. I'm going to reassess the Terragrunt process and see if I can discern anything else out of that. I suspect I'll have something useful on that front soon.
I want to elaborate a little on what "Done" is going to mean for this Issue:
I have access to the people-depot development config. I'm going to try to complete that deploy process, and then write up the process of translating from Terragrunt so that folks responsible for other projects can complete that process.
Once I'm done there, I'll want to pick up the Access The Data configuration, including a deployment that avoids distributing secrets to Ops personnel, and thus will be reliable and resilient to rotating volunteer staff.


Tutorial: how to not create kata with code restrictions

Create a tutorial explaining to authors why restrictions related to code are a bad idea. Point out possible pitfalls:

dynamic evaluation
reflection
macros and preprocessor
equivalent functionalities in libraries
fetching answer from outside: network, separate process
untestable requirements: "use recursion", etc.
updates to languages, libraries, runner
... anything else?

Think about a series of language specific articles explaining how to enforce things which are possible to be realized more or less reliably:

module forbidder for Python
DasBrain's kumite for detecting class references in Java
hobovsky's kumite on parsing java source files
IIRC there's something about blocking modules for Haskell?

IIRC there's something about blocking modules for Haskell?

https://github.com/codewars/hspec-codewars#hidden

IIRC there's something about blocking modules for Haskell?

https://github.com/codewars/hspec-codewars#hidden

fetching answer from outside: network

I wouldn't want this possibility documented. It's well known, but still.

fetching answer from outside: network

I wouldn't want this possibility documented. It's well known, but still.

JS Specific, suggested by @XRFXLP: https://github.com/codewars/docs/issues/214#issuecomment-755304491

Suggestion:
Freeze the Object which are being as method for validation for solutions:
(For example: Math, Array, Function, String....)
For example there are many katas in which validation process uses String.prototype.split, but the translators or author usually forget to freeze or constantify the handler function, which led user to modify the prototype itself to pass the tests.
And I think this is not detected my anti-cheat system, because I've recently seen couple of such solution for few 1 kyu katas.

JS Specific, suggested by @XRFXLP: https://github.com/codewars/docs/issues/214#issuecomment-755304491

Suggestion:
Freeze the Object which are being as method for validation for solutions:
(For example: Math, Array, Function, String....)
For example there are many katas in which validation process uses String.prototype.split, but the translators or author usually forget to freeze or constantify the handler function, which led user to modify the prototype itself to pass the tests.
And I think this is not detected my anti-cheat system, because I've recently seen couple of such solution for few 1 kyu katas.


Register

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/11194
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 8dcf7ed809d95c48891e49dd7257e325455bc1f7
git push origin v0.1.0


Proxy: Fall back to using DNS when Destination service can't find service.

Fixes #155.

This PR is based on the branch for PR #674. Once #674 is merged, I will rebase this onto master.

@klingerf Could you please review the changes under test/, specifically egress_test.go and the associated YAML file?
I elected not to run the entire combination or protocol/method/hostname for the "less than three labels" case, as that's not the main point of that sub-test.

@olix0r Yup, the absence of a dst_* label will work. We may want to consider an explicit dns="foo.com" label, if we want to differentiate between a valid external DNS metric, and a malformed internal metric that's just missing its dst_* labels.

#725 should be merged before this is merged.


FSLeyes does not recognize fmriprep melodic directory

fmriprep creates a "melodic" directory. However, FSLeyes's melodic mode (for displaying spatial patterns, timeseries, and power spectrum for each component) seems to require that that directory be specifically named melodic.ica in order for this to work correctly.
I'm not sure whether fmriprep should name that directory with an .ica extension or whether FSLeyes should not require that extension. (Or whether I and the researchers I support have misunderstood something!)

cc @pauldmccarthy for advice

The FSLeyes expectations are outlined here:  https://users.fmrib.ox.ac.uk/~paulmc/fsleyes/userdoc/latest/ic_classification.html
although as mentioned in pauldmccarthy/fsleyes#48, I don't see any problem in allowing melodic directories with any suffix..

Oh, I'm sorry, I'm on an app that apparently doesn't show cross links.

No worries; I have vague aims to get a new version of FSLeyes out within the next week or two, but am continually interrupted with other work; but I'll add this to the list.

I'm going to close this in favor of FSLeyes being more flexible, since BIDS derivatives is going to constrain which naming conventions we can support. Please reopen if there's more to discuss, though.


NVTabular Docker is Out of Date [BUG]

Describe the bug
The newest NVTabular docker on NGC (nvcr.io/nvidia/nvtabular:0.3) is out of date (at least CuDF and NVTabular are) by at least a few versions. Enough that it doesn't work with the tutorials/documentation found online. It is also made more difficult because versioneer is broken. This makes it so you can't see what version you have (either with PIP or through other means).
Steps/Code to reproduce bug

Download the newest docker
Try and follow along with the tutorials on the Github/Documentation (not what's included with the Docker)
Find errors due to old versioning

Expected behavior
I expect the docker to be updated regularly when changes are pushed to Github (especially breaking ones)
Environment details (please complete the following information):

Environment Location: Docker on GCP VM
Method of NVTabular install: Docker

docker pull nvcr.io/nvidia/nvtabular:0.3

Thanks for the bug report!
The versioneer tags on the container are wrong, and we've fixed so that they will be set appropriately for the next release.  This was a problem with our CI process for creating the container - it didn't pull in the git tags from the repo (just the source)  - which messed up versioneer.
The container should have both NVTabular 0.3 and cudf 0.16 installed on it though (despite what the __version__ strings indicate). This corresponds to the last release of NVTabular we did (0.3).
Our documentation is versioned - are you following along with the 0.3 documentation https://nvidia.github.io/NVTabular/v0.3.0/Introduction.html or the docs for the main branch ?  If so can you point out what errors you are seeing?
The next version of nvtabular (0.4) is scheduled for release on Feb 22nd - and the current unstable version of this is up on the 'main' branch. This version contains some breaking api changes, so if you try to run the notebooks/examples from the main branch on the 0.3 container you will get all sorts of different errors.
If you want to run the main branch, the easiest way right now is to use the 0.3 container and then go pip install --upgrade git+https://github.com/NVIDIA/NVTabular.git to grab the latest version of NVT from source.  If you hit any problems with this - please let me know!

Thanks for the response benfred.
Is there any reason you wouldn't want to update the NVTabular docker to contain the most recent release of CuDF?
I'm using NVTabular as part of the Merlin workflow so having up-to-date utilities in that workflow is pivotal.
It seems counterintuitive that the CuDF version is 2 versions behind the currently released one.

Is there something that breaks when the CuDF version is updated to the current version? If not then why wouldn't you want to update the NGC docker accordingly?

And no I did not know the documentation is versioned. I went to the main documentation page called out from Google. It is the newest as far as I can see.  However it does this...
cat_features = CATEGORICAL_COLUMNS >> Categorify(freq_threshold=15, out_path=OUTPUT_DATA_DIR)
cont_features = CONTINUOUS_COLUMNS >> FillMissing() >> Clip(min_value=0) >> LogOp() >> Normalize()
features = cat_features + cont_features + LABEL_COLUMNS

... which does not work in the provided version of NVTabular in the most recent docker.

Is it not a problem that your most up-to-date docker (the one you recommend on your Github) does not work with your most up-to-date documentation? Please at least call this out somewhere on the documentation (i.e. In bold-red-text, this documentation does not work with the NGC NVTabular docker, please click here for the older versioned documentation that will work with that particular docker image)

For now, I will continue to patch this by building my own docker off the base rapids docker and adding in the NVTabular and HugeCTR functionality separately.

Also, on your main README it tells you how to launch the docker and then provides this link to go to the documentation to see examples.
https://nvidia.github.io/NVTabular/main/examples/index.html
This clearly isn't the v0.3 version of the documentation. So the current ReadME is telling people to use a docker that is not compatible with the examples/notebooks/documentation they then refer them to. Please fix this ASAP.

Thanks for the feedback!
It sounds like there are two issues here:

You want containers for a nightly/unstable version of merlin - instead of the stable released version that we have right now.
We should update the README between releases to indicate this is an unstable/dev version and give links to the stable versions

For the first issue -  we're looking at shipping nightly merlin containers as part of the 0.5 release - I've created an issue here to track https://github.com/NVIDIA/NVTabular/issues/551 .   There is some process involved in shipping to NGC (qa/security scans/perf testing/notifications etc) that we need to fully automate which makes this out of scope for this release

It seems counterintuitive that the CuDF version is 2 versions behind the currently released one.

We're not two versions behind the currently released version of cudf. The nvtabular 0.4 release will use the most up to date version of cudf when it's released,  just like the nvtabular 0.3 release used the most up to date version of cudf when it was released.
cudf 0.16 was the most recent version when we released nvtabular 0.3 - cudf 0.17 came out a couple weeks after the nvtabular 0.3 release and cudf 0.18 isn't released yet.  Cudf 0.18 is scheduled for release on Feb 17th - and we will be releasing the next version of NVTabular that uses cudf 0.18 a week after.

Is there something that breaks when the CuDF version is updated to the current version? If not then why wouldn't you want to update the NGC docker accordingly?

Yes - there have been multiple issues found when upgrading cudf =(  For cudf 0.17 we had https://github.com/NVIDIA/NVTabular/pull/494 (which should be fixed now) and we are still tracking some issues with cudf 0.18 https://github.com/NVIDIA/NVTabular/issues/539 and https://github.com/NVIDIA/NVTabular/issues/538 . These issues should be fixed by the NVTabular 0.4 release
We do stable releases  - including new containers on NGC, releases on github, packages on conda/pypi etc - to provide a stable environment for customers.  I totally agree we should make it easier to get the unstable versions for people to try out, and we should push out nightly containers as part of that though.

Hello @darien-schettler I wanted to take a second and relay that we are working on producing nightly containers that will have the latest releases of all packages including cudf and nvtabular. We have not completed this work yet and it is not live but you can track progress here: https://github.com/NVIDIA/NVTabular/issues/551


ImportError: ImportError: cannot import name 'IGNORE_GIT_FOLDER_PATTERNS' from 'huggingface_hub.utils' ....

Awesome Work! Diffusion-policy is very inspired!
However, could you help me to fix this problem? I try to run state-based ipynb file in colab. I met such error:
ImportError: cannot import name 'IGNORE_GIT_FOLDER_PATTERNS' from 'huggingface_hub.utils' (/usr/local/lib/python3.10/dist-packages/huggingface_hub/utils/__init__.py)
Looking forward to your reply.

Hi, I guess this is because "IGNORE_GIT_FOLDER_PATTERNS" is a constant variable in hugginface utils repo and it has been removed/ renamed by the latest version. I found there is a "DEFAULT_IGNORE_PATTERNS" varaible from here: ("https://github.com/huggingface/huggingface_hub/blob/0c98fbd5840ce9dc2ac59745afe079babeb9f353/src/huggingface_hub/utils/_paths.py#L24"). It seems this variable has similar meaning of the previous one. Replace the old "IGNORE_GIT_FOLDER_PATTERNS" with this new one works for me now.


[Net] Split Unix/Windows IP implementation

Continuation of #98969 , as mentioned in this comment together they may allow us to exclude the drivers folder depending on the platform.

Thanks!


Revert "Update tornado version"

Reverts spotify/luigi#2490

That looks weird.

Thanks for being on top of these things!


train.py

I had to vary this code here in the Train.py to get it to work on my system
LoRA and DORA modules
sys.path.append("./scripts")
from scripts.lora import LORA
from scripts.dora import BNBDORA, HQQDORA, DORALayer, MagnitudeLayer
probably because i already had a module called dora and lora in the pip.

this fixed the problem for me too, you probably saved me a week of mindless scanning and screaming at AIs


Docs Issue: Typo under OnUserAfterOauth2Register

I believe this should say OnUserAfterOauth2Register

Actually OnUserBeforeOauth2Register and OnUserAfterOauth2Register will be removed in the next v0.6.0 release (sometime this week or the week following it) because of some internal changes related to https://github.com/pocketbase/pocketbase/issues/276 (this day I'll try to submit the changes at least in the develop branch, but I want to finalize the integration tests before that).
If you are planning to use them, my advice would be to wait until I finalize the API to avoid changes in your code.

ah, alright


Add new fields and sections to the Program detail page

Add effort, duration, price, team, objectives and other optional fields.
Purpose
As described in https://github.com/openfun/richie/issues/2556, this PR adds new fields to the programs page and information disposition, much closer to the course detail template.
This allows for a better grasp on all the information related to the program.

Hi @jbpenrath, can you give me some feedback on this or assign someone to help me review this and improve it?

Just an overall question. Instead of adding pace, effort, duration, instructors, etc. what do you think to aggregate those information for the related courses ?

So your idea is to aggregate this information via courses without creating new manual fields. Do you think it would make sense to be able to manually override? I'm just trying to cover all the bases, due to the different typologies of programs we can have.

Just an overall question. Instead of adding pace, effort, duration, instructors, etc. what do you think to aggregate those information for the related courses ?

So your idea is to aggregate this information via courses without creating new manual fields. Do you think it would make sense to be able to manually override? I'm just trying to cover all the bases, due to the different typologies of programs we can have.

In depends to your need. Concerning Editor UX and data consistency, It looks great to aggregate those data from related courses but if you know that those information will need to be overridden, I think your current implementation fullfil the need, is simpler so that's the best.


Analyzer treats required named parameters in superclasses as non-optional from legacy libraries

Given this legacy library:
// @dart=2.8
import 'null_safe.dart';

class Legacy extends NullSafe {}

main() {
  Legacy();
}

// And this null-safe one:
class NullSafe {
  NullSafe({required String s});
}

I would expect this code to be OK. The implicit super() call in Legacy to call NullSafe() should be allowed because NullSafe's required named parameter should be treated as optional from the context of a legacy library.
Instead, I get:
Analyzing /Users/rnystrom/Documents/legacy.dart...
  error • The superclass 'NullSafe' doesn't have a zero argument constructor. • /Users/rnystrom/Documents/legacy.dart:4:7 • no_default_super_constructor
1 error found.

And a reference to required parameters being optional in the definition of LEGACY_SUBTYPE(S, T) https://github.com/dart-lang/language/blob/master/accepted/future-releases/nnbd/feature-specification.md#subtyping.

@munificent we evidently don't have a test for this, any chance you could add one?

How did I know you were going to say that? :) @scheglov, would you like me to write a test for this or will you in the process of fixing it? I won't get to it until Monday, but I'm happy to then.

This should fix the issue in the analyzer.
https://dart-review.googlesource.com/c/sdk/+/162584

Language test: https://dart-review.googlesource.com/c/sdk/+/163740


Adding Project Management Section to README

Added Kanban SS to the README along with a description about the PM used in the project, with a focus on the Agile Methodology.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.


Error: babel-preset-react-app forces to use only specific NODE_ENV or BABEL_ENV i.e 'development' / 'production' / 'test'

Can you reproduce the problem with latest npm?
Yes
Can you still reproduce it?
Yes
Description
babel-preset-react-app forces to use only specific NODE_ENV or BABEL_ENV i.e development / production / test.
And when i am trying to use any another environment then it is showing the below error:
Module build failed: Error: Using babel-preset-react-app requires that you specify NODE_ENV or BABEL_ENV environment variables. Valid values are "development", "test", and "production". Instead, received: "staging"
But what to do if we need to use it with some another environment like for UAT environment etc. ?
Expected behavior
It should support any environment or environment other than specific should be treat like production.

This is intentional because this is how we decide which plugins to apply. However a cleaner way to do so would be by adding options to the preset, and reading target environment from options.
Would you like to send a PR for that?


Broken iframe of Google Calendar

https://opendal.apache.org/community/

The following is the calendar of the community events:

<iframe src="https://calendar.google.com/calendar/embed?src=d32a8b1c08fc40d4230e3ce89145fd0e9a1ea4a374893a23ec7bd28ca646db45%40group.calendar.google.com&ctz=Asia%2FShanghai" style={{border: 0, width: "100%", maxWidth: "500px", height: "500px", aspectRatio: 1}} frameBorder="0"></iframe>

Browser: Arc Version 1.40.1 (49250), Chromium Engine Version 124.0.6367.92
cc @Xuanwo @suyanhanx

I'll take a look. Thank you for report this.

Hi, @suyanhanx, this issue still exists. Do we have alternaive solutions like a plugin instead iframe?

It's wired. It still exists. I'm considering removing it for now. Replace it with a link to the Google Calendar.

It's wired. It still exists. I'm considering removing it for now. Replace it with a link to the Google Calendar.

Looks good to me.

I noticed that the server's configuration overrides the one within our page.
This may be related to something that Infra recently updated the configuration of the website deployment server.
After all, there was no problem with our page before.

Let's just replace the frame with a link.

Let's just replace the frame with a link.

LGTM, let's do this.

Fixed by #4620


[Feature Request]  support?

As of now, html content containing <blockquote> tags seems to be omitted in the generated docx file.

@jagzmz Would you like to contribute that feature to html-to-docx?

@jagzmz I have added support for blockquote using text justification and indentation, it would be great if you could checkout the PR and give review on it.

@jagzmz I have added support for blockquote using text justification and indentation, it would be great if you could checkout the PR and give review on it.

@jagzmz Would you like to contribute that feature to html-to-docx?

Hi, sorry i just saw this, i did went through the code at the time of creating this feature request. Didn't quite get the idea about how should i implement blockquote feature as I haven't worked with openxml things. So I didnt further looked into it.

@jagzmz I have added support for blockquote using text justification and indentation, it would be great if you could checkout the PR and give review on it.

Thanks a lot for this! Would give a review on this soon.

@jagzmz Would you like to contribute that feature to html-to-docx?

Hi, sorry i just saw this, i did went through the code at the time of creating this feature request. Didn't quite get the idea about how should i implement blockquote feature as I haven't worked with openxml things. So I didnt further looked into it.

@jagzmz I have added support for blockquote using text justification and indentation, it would be great if you could checkout the PR and give review on it.

Thanks a lot for this! Would give a review on this soon.

Will release this feature soon along with row span, hence closing this issue.

Will release this feature soon along with row span, hence closing this issue.


Error: unknown class hash

Trying to generate account.json, which contain open configuration file
with the command
starkli account fetch <YOUR WALLET ADDRESS> --rpc https://starknet-testnet.public.blastapi.io/rpc/v0_6  --output account.json

Getting the error

0x029927c8af6bccf3f6fda035981e765a7bdbf18a2dc0d630494f8758aa908e2b is not a known account class hash. If you believe this is a bug, submit a PR to:
https://github.com/xJonathanLEI/starkli
Error: unknown class hash: 0x029927c8af6bccf3f6fda035981e765a7bdbf18a2dc0d630494f8758aa908e2b

Meanwhile the wallect address is correct
Terminal screenshort

up I got this error too

This is because Argent updated the account contract. Support for it has actually been added in https://github.com/xJonathanLEI/starkli/commit/98a9009f18ade55297b5d3b6bae2aacb843b8819 but not released yet. I'm working on also adding the new Cairo 1 Braavos class hash support before making a release.

That commit has now been released. Upgrade to the latest Starkli version and it should work.
Btw I see you're using the Blash public RPC. You can actually use the free RPC vendor feature like so:
starkli account fetch 0x0484bb449013d98a0f1b900767a53ce6f4335dff8723d5ba0b3ea1f3e7e7c57a --network goerli --output stackie_account.json


gopass: 1.8.2 -> 1.8.3

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

https://github.com/gopasspw/gopass/releases/tag/v1.8.3 is the closest I can find to release notes, this looks like a candidate for backporting. #52474


Certificate error connecting to Cloudant with requests 2.32.3

Describe the bug

With cloudant-python-sdk and requests 2.32.3 connections to Cloudant fail with a certifcate error e.g.
[2024-05-29T18:13:25.703Z] urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='~mytestaccount~.cloudant.com', port=443): Max retries exceeded with url: /gauge-4f703d00-99c9-4ec0-b039-2eed7d05048d?partitioned=true (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1000)')))

requests.exceptions.SSLError: HTTPSConnectionPool(host='~myuuuid-bluemix~.cloudantnosqldb.appdomain.cloud', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1006)')))

To Reproduce

from ibmcloudant.cloudant_v1 import CloudantV1

service = CloudantV1.new_instance()
print(service.get_server_information().get_result())

Expected behavior

No error.
Screenshots

Must gather (please complete the following information):

SDK Version [e.g. 1.2.1]: 0.8.1
Python Version [e.g. Python 3.8]: 3.11.9
Name of service that you're trying to use (if applicable): Cloudant
Name of operation that you're trying to invoke (if applicable): any

Additional context

It is possible to workaround the issue by continuing to use requests 2.32.2.
See also https://github.com/psf/requests/issues/6730

Fixed in https://github.com/IBM/cloudant-python-sdk/releases/tag/v0.8.2 by narrowing the requests dependency version range.

Release 0.9.0 was supposed to get a fix for this problem via https://github.com/IBM/python-sdk-core/releases/tag/v3.20.2, but it might not be working, so if you see this problem with version 0.9.0 and requests==2.32.3 then to workaround either:

downgrade to requests==2.32.2
stay on version 0.8.2

Version 0.9.1 depends on https://github.com/IBM/python-sdk-core/releases/tag/v3.20.3 that works around this problem and allows requests==2.32.3 to work.


Cannot run fl training on Femnist in distribute mode

Please check the code in federatedscope/core/auxiliaries/model_builder.py.
When running femnist in distributed mode, the server will load data_representative in  federatedscope/core/auxiliaries/model_builder.py as
{'train': <torch.utils.data.dataloader.DataLoader object at 0x7f3a10d7b950>, 'test': <torch.utils.data.dataloader.DataLoader object at 0x7f3a10d68dd0>, 'val': <torch.utils.data.dataloader.DataLoader object at 0x7f3a10d87810>}

and no input_shape will be returned.

You might need to specify distribute.data_idx to indicate which part of the data is owned by the server/client, or the whole femnist dataset would be returned.
An example is provided in https://github.com/alibaba/FederatedScope/blob/master/scripts/distributed_scripts/run_distributed_conv_femnist.sh


Docked Drawer hides content and Appbar, and does not wrap them

Problem description
I think that a docked drawer should be wrapping main content, and not hiding it. For example, with a docked and opened drawer, my navbar button is hidden, and i can't close it.
I use react-bootstrap for its grid system.
Link to minimally-working code that reproduces the issue
App.js
import React from 'react';
import 'bootstrap/dist/css/bootstrap.css';
import '../style/style.css';
import {muiTheme} from '../style/styles.js';
import AppBar from "material-ui/AppBar";
import MuiThemeProvider from 'material-ui/styles/MuiThemeProvider';
import JumboHeader from './JumboHeader'
import SideDrawer from './SideDrawer'
import MenuItem from 'material-ui/MenuItem';
import {Grid, Row, Col} from 'react-bootstrap'

class App extends React.Component {
    constructor(props) {
        super(props);
        this.state = {
            drawerOpen: true
        };

        this.switchDrawer = this.switchDrawer.bind(this);
    }

    switchDrawer() {
        this.setState({
            drawerOpen: !this.state.drawerOpen
        })
    }

    render() {
        return (
            <MuiThemeProvider muiTheme={muiTheme}>

                    <AppBar
                        onLeftIconButtonTouchTap={this.switchDrawer}
                        title="Menu"
                    />
                    <SideDrawer drawerOpen={this.state.drawerOpen} switchDrawer={this.switchDrawer} />
                    <Grid fluid={true}>
                        <Row>
                            <JumboHeader />
                        </Row>
                    </Grid>
                    <Grid>
                        <Row>

Lorem ipsum

                        </Row>
                    </Grid>

            </MuiThemeProvider>
        )
    }
}

export default App;

SideDrawer.js
import React from 'react'
import Drawer from 'material-ui/Drawer'
import List from 'material-ui/List'
import Subheader from 'material-ui/Subheader'
import ListItem from 'material-ui/List'
import ContentInbox from 'material-ui/svg-icons/content/inbox';
import ActionGrade from 'material-ui/svg-icons/action/grade';
import ContentSend from 'material-ui/svg-icons/content/send';
import ContentDrafts from 'material-ui/svg-icons/content/drafts';

class SideDrawer extends React.Component {
    constructor(props) {
        super(props);
        this.state = {
            drawerOpen: true
        };

        this.switchDrawer = this.switchDrawer.bind(this);
    }

    switchDrawer() {
        this.setState({
            drawerOpen: !this.state.drawerOpen
        })
    }

    render() {
        return (
            <Drawer
                docked={true}
                open={this.props.drawerOpen}
                onRequestChange={this.props.switchDrawer}
            >
                <List>
                    <Subheader>The MENU</Subheader>
                </List>
            </Drawer>
        );
    }
}

export default SideDrawer;

Versions

Material-UI: 0.17.1
React: "16.0.0-alpha.6
Browser: google-chrome Windows 56.0.2924.87

This far, I only found a little hack to "squeeze" the main container, but it's just a hack, thanks to Jeff McCloud : https://stackoverflow.com/questions/40620302/how-to-get-material-ui-drawer-to-squeeze-other-content-when-open

had trouble with this as well

Makes me wonder how the guys from admin on rest did that behavior...


Do not rely on the Activity object when this plugin is instantiated.

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix
:arrow_heading_down: What is the current behavior?
Plugin is incompatible with background isolates which  may be held by a service on Android
:new: What is the new behavior (if this is a feature change)?
Plugin will depend on the generic Context class and cast to activity (if available) to show the google play services warning fragment.
:boom: Does this PR introduce a breaking change?
No
:bug: Recommendations for testing
Setup a background isolate holder Service
:memo: Links to relevant issues/docs
:thinking: Checklist before submitting

[ ] All projects build
[x] Follows style guide lines (code style guide)
[ ] Relevant documentation was updated
[x] Rebased onto current develop

The permission handler plugin seems to rely on the “activeContext” function instead of “context”. Perhaps something this PR should do as well.

I am interested to have this pull request merged. Can anybody tell me the reason it's not? I looked through logs of failed build and it seems to me that this patch is not reason, there is something else.

@ened first of all thanks for the PR, we really appreciate it!
Just to reply on your last question, since I recently figured this out for the geolocator and location_permission plugins (see https://github.com/BaseflowIT/flutter-permission-plugins/pull/1#discussion_r277670153).
I think it would be best to keep using the context method here since it will return the ApplicationContext instead of the current Activity or ServiceContext. For more information please have a look at this article.

@robotsrulz, I have just release version 2.0.1 of this plugin which includes this PR

@mvanbeusekom thx.


Mocking contract at specific address

Some EIPs define that contracts must be deployed at specific addresses. How can I call deployMockContract while specifying the address to deploy the mocked contract at? (I can't find a way using the current API.)
Relatedly, how can I determine if there is already a contract deployed at a given address (to avoid re-deployment)?
(Related, for another mocking framework: https://github.com/defi-wonderland/smock/issues/47)

Interesting, we'll look into it and see if we can implement it.
External contributions are welcome as well.

I need that too to simulate an Optimism bridge. I would settle for a way to impersonate an account on ganache too.

External contributions are welcome as well.

happy to help if you point me in the right direction


feat: update demo to include Avro data

Event Processing now supports processing Avro messages, so this commit updates the demo environment to include some topics with binary-encoded Avro messages.
The EEM seed script has also been updated to work with the new admin API introduced with 11.1.1.

@dalelane FYI, I have created the PR to publish the docs with your updates to the tutorials and it's ready to merge when you're ready to merge this one. Thanks

@meechiekitten - great, thanks - I'll merge it now


apply pylint testing

What this PR does / why we need it:
Apply pylint testing for the kubeflow fairing since this is python project and pylint is very useful tool for python code standardization.
Which issue(s) this PR fixes:
Fixes #298 #82

This change is

From the testing, there are so many lint errors. We need to big effort to fix this.  :-(
ERROR|2019-06-24T13:55:09|test_py_lint.py:76| 111 files had lint errors:

/cc @karthikv2k

/retest

/assign @karthikv2k @abhi-g
I fixed some pylint errors, and disabled some ones. Could you please help to review? As you can see, the code changes are huge, but I think the risk is lower. we should invole pylint tests for python porject at the begining, but it's not late :-) The presubmit passed now.  Thanks a lot!

kindly ping @karthikv2k @abhi-g Any comments for the pylint testing.
I suggest merging this as ealier as possiable to ensure following PR python code without pylint errors. Thanks.

Thanks @jinchihe for the cleanup across the code base and really sorry for the delay in the review. This is looking good. you'll probably need to merge from master and update a few more places..
/lgtm

@abhi-g OK, I will resove the confilcts once get chance. Thanks.

/retest

/test kubeflow-fairing-presubmit
trying to understand why is the  test taking so long. This used to be ~15-20min.

/test kubeflow-fairing-presubmit
trying to understand why is the test taking so long. This used to be ~15-20min.

I guess that's caused by test env problem, I noticed some problems in another PR, but just going to confirm the reasons, thanks.

/retest

/retest

@abhi-g Could you please take a look again? Thanks a lot!
I resolved all conficts. Once have any check-in files, need to take big effort to resolve conficts and handle the new files and code pylint problem :-) After the PR, the code owner should ensure that.

/lgtm
/approve


Remove deprecated Request class from pinot-java-client

also delete related methods.
partially fix: #11582

Codecov Report

Merging #11614 (0b19657) into master (4292356) will decrease coverage by 48.40%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #11614       +/-   ##
=============================================
- Coverage     62.92%   14.52%   -48.40%
+ Complexity     1103      201      -902
=============================================
  Files          2326     2323        -3
  Lines        124984   124512      -472
  Branches      19080    18994       -86
=============================================
- Hits          78641    18089    -60552
- Misses        40730   104901    +64171
+ Partials       5613     1522     -4091

Flag
Coverage Δ

integration
?

integration1
?

integration2
?

java-11
?

java-17
?

java-20
14.52% <ø> (-48.38%)
:arrow_down:

temurin
14.52% <ø> (-48.40%)
:arrow_down:

unittests
14.52% <ø> (-48.39%)
:arrow_down:

unittests1
?

unittests2
14.52% <ø> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

.../main/java/org/apache/pinot/client/Connection.java
77.50% <ø> (+7.04%)
:arrow_up:

...inot/client/JsonAsyncHttpPinotClientTransport.java
29.82% <ø> (+1.95%)
:arrow_up:

.../org/apache/pinot/client/PinotClientTransport.java
0.00% <ø> (ø)

...ava/org/apache/pinot/client/PreparedStatement.java
100.00% <ø> (+6.89%)
:arrow_up:

... and 1520 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


"Buleta " , "Arsanca " , "Bârsești " , "Govora " , "Gurișoara " , "Măgura " , "Mihăești " , "Munteni " , "Negreni " , "Rugetu" , "Scărișoara " , "Stupărei " , "Vulpuești" are listed in the drop-down menu

The villages are listed in the drop-down menu alongside its corresponding county and city, according to the law
Preconditions : the  website is up and runing. After every step delete the text you typed from the search bar.

Step 1
Write in the search bar "Buleta"

Expected results
The location appears in the drop-down menu as "Sat Buleta, VÂLCEA (Mihăești )"

Step 2
Write in the search bar "Arsanca "

Expected results
The location appears in the drop-down menu as "Sat Arsanca , VÂLCEA (Mihăești )"

Step 3
Write in the search bar "Bârsești "

Expected results
The location appears in the drop-down menu as "Sat Bârsești , VÂLCEA (Mihăești )"

Step 4
Write in the search bar "Govora "

Expected results
The location appears in the drop-down menu as "Sat Govora , VÂLCEA (Mihăești )"

Step 5
Write in the search bar "Gurișoara "

Expected results
The location appears in the drop-down menu as "Sat Gurișoara , VÂLCEA (Mihăești )"

Step 6
Write in the search bar "Măgura "

Expected results
The location appears in the drop-down menu as "Sat Măgura , VÂLCEA (Mihăești )"

Step 7
Write in the search bar "Mihăești "

Expected results
The location appears in the drop-down menu as "Sat Mihăești , VÂLCEA (Mihăești )"

Step 8
Write in the search bar "Munteni "

Expected results
The location appears in the drop-down menu as "Sat Munteni , VÂLCEA (Mihăești )"

Step 9
Write in the search bar "Negreni "

Expected results
The location appears in the drop-down menu as "Sat Negreni , VÂLCEA (Mihăești )"

Step 10
Write in the search bar "Rugetu"

Expected results
The location appears in the drop-down menu as "Sat Rugetu, VÂLCEA (Mihăești )"

Step 11
Write in the search bar "Scărișoara "

Expected results
The location appears in the drop-down menu as "Sat Scărișoara , VÂLCEA (Mihăești )"

Step 12
Write in the search bar "Stupărei "

Expected results
The location appears in the drop-down menu as "Sat Stupărei , VÂLCEA (Mihăești )"

Step 13
Write in the search bar "Vulpuești"

Expected results
The location appears in the drop-down menu as "Sat Vulpuești, VÂLCEA (Mihăești )"


Remove all required packages and make them optional

The required vendor section should be moved to optional https://github.com/ThaDafinser/UserAgentParser/blob/master/composer.json#L51

[ ] move them to suggested
[ ] throw a new exception when the package is not included

removed 2 packages: https://github.com/ThaDafinser/UserAgentParser/commit/34acee410f05213e59f9eccc6c5fe8ebf4060676


Add heading level to "Your rights" section

This was supposed to be an h2

You can preview this change here:
Built with commit b335ab7300428b31c3283e91669291065f6e6554
https://deploy-preview-249--govuk-design-system-preview.netlify.com

Thanks, merged


Allow to turn of managing apt class.

The module already has manage_package which accomplishes the same thing for the RHEL line, I think rather than add a new param this would be better reusing that one, but expanding it's scope to not just deal with the relationship but the whole repo.

thx for the quick reply, fixed.


Auth

Resource Owner Password Credentials Grant + facebook

Possibilities:
Doorkeeper Resource Owner Password Credentials Grant flow
Doorkeeper extension to integrate with FB


urlutils: hashlib and md5

BETTER Uses md5 from hashlib when available. (closes #3382)

Signed-off-by: Tibor Simko<EMAIL_ADDRESS>

LGTM


hi dear

dear can you please guide me how to use these gpu..sss. not understanding anything<EMAIL_ADDRESS>how to proceed after opening "https://cloud.vast.ai/"
'

Hello,
You can follow similar video on Youtube
Thanks.

hey thanks for reply but in this video, the guy did not tell about how to include gpu for ssh. and where to put commands.

Hello,
The first 10 minutes of the Youtube video show what you need to do. Then you can follow the commands in the README.md file.

ok dear.


Issue 194 add camera popover

Added camera preview when user wants to add a new camera source
Refined CI-CD workflow to cancel previous run when there is new commit

Looks good, except the microphone/camera toggle button not working in the popover.


[restc-cpp] use modern cmake helpers

Needed for #26981 because this port is special because it needs msbuild on windows

Thanks!


sm8250 edk2 support

Prerequisites

[x] Have you read the wiki?
[ ] Is your device in the supported list?
[ ] Does the device have a Snapdragon SOC which is supported in this repo?

Description
support sm8250 device for edk2，just run linux.

@dabao1955 Does your device have mainlined kernel?

@dabao1955 Does your device have mainlined kernel?

What do you mean?

In fact, the Sm8250 SOC has already been supported, and now only EDk2 needs to be ported and tested for the device. Additionally, I don't think it makes much sense

In fact, the Sm8250 SOC has already been supported, and now only EDk2 needs to be ported and tested for the device. Additionally, I don't think it makes much sense

I don't think so.Although sm8250 devices can not run windows.

It is supported. Look in the Silicon and Platform folder. You can boot Android and Linux with it.
SM8250 device can boot very minimal WinPE but it's not really useful. If you want to add support for an unsupported device you can follow this commit

In fact, the Sm8250 SOC has already been supported, and now only EDk2 needs to be ported and tested for the device. Additionally, I don't think it makes much sense

I don't think so.Although sm8250 devices can not run windows.

It is supported. Look in the Silicon and Platform folder. You can boot Android and Linux with it.
SM8250 device can boot very minimal WinPE but it's not really useful. If you want to add support for an unsupported device you can follow this commit

This submission only has one Lenovo device, my device is Xiaomi Mi 10pro, I was hoping to try to boot Linux via UEFI on this device, but I didn't find a channel to download and a way to build.

As I said, you can follow this commit as an example to add support for your Mi 10 Pro. You can pretty much copy the j716f port and replace the values that are device specific (like memory map)


Cant Launch Bot From start.py, 'module' object is not callable

Traceback (most recent call last):   File "G:\New Downloads\HotWired-Bot\start.py", line 5, in <module>     main() TypeError: 'module' object is not callable

We are aware of this issue, the start.py file is a remnant of an old start system and it will be removed soon, the bot should be started with pipenv run start or directly by py -m bot, but with the direct approach you'll need to be in the pipenv enviroment (pipenv shell)


added results description in json

Hey there,
i've added a json based description of the needed ajax data results.
I hope you find that usefull.
If you need some changes, just ping me here please

There appear to be multiple PRs addressing this section:
#5002
#4863
#4861
#4814
#4662
We should pick one of these, or integrate several to provide the most comprehensive answer.

Thanks!  I am merging some other PRs which cover this same content.

Thanks for your reply :+1:


Add plugin to elasticsearch container

How can install plugins (analysis-phonetic, analysis-icu, ...) on the Elasticsearch container in order to use the SmileElastic Suite on Magento 2?
Thank you for your support.

The ES containers built and used by default by this project include (and always have) both the analysis-phonetic and analysis-icu plugins with the express purpose being projects which include the SmileElastic suite. Reference this 7.9 build file for example: https://github.com/davidalger/warden/blob/develop/images/elasticsearch/7.9/Dockerfile
There is no mechanism currently for arbitrarily adding additional plugins apart from building and using a custom image on the project.


feat(vitest)!: add "vitest list" API to print collected tests without running them

Description
Fixes https://github.com/vitest-dev/vitest/issues/2901

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
[ ] Ideally, include a test that fails without this PR but passes with it.
[ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

[ ] Run the tests with pnpm test:ci.

Documentation

[ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

[ ] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Should this new API be added to custom pool docs, docs/advanced/pool.md?

Any thoughts about that?

I missed that! Good catch

Should this new API be added to custom pool docs, docs/advanced/pool.md?

Any thoughts about that?

Added a small paragraph


Fix dependencies with new package versions

Looks like conda has had some package updates which made ORT reveal a (sort of) bad test case in Spox. There's also a problem with pandoc seemingly?

Pandoc installed by conda needs to be pinned to 2.19.2 as that's the upper bound from the Python package by the same name (which is in turn at 2.3). There is a warning now but pandoc 3.1.1 dropped very recently so we didn't upper-bound before. Maybe there is a cleaner solution here, but it would probably involve having the Python package actually on conda.


xidlehook: 0.5.0 -> 0.6.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/xidlehook/versions.
meta.description for xidlehook is: '"xautolock rewrite in Rust, with a few extra features"'.

Checks done (click to expand)

built on NixOS
/nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0/bin/xidlehook passed the binary check.
1 of 1 passed binary check by having a zero exit code.
1 of 1 passed binary check by having the new version present in output.
found 0.6.0 with grep in /nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0
directory tree listing: https://gist.github.com/42461c0815767d4c37ad9920b84311e3
du listing: https://gist.github.com/8e7763f5c2535831efc416a5eb1adefa

Outpath report (click to expand)

Outpath difference report
4 total rebuild paths
1 package rebuilds
1 x86_64-linux rebuilds
1 i686-linux rebuilds
1 x86_64-darwin rebuilds
1 aarch64-linux rebuilds
First ten rebuilds by attrpath
xidlehook

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A xidlehook https://github.com/r-ryantm/nixpkgs/archive/400a40b8c999af6815fe3de32e00a770b6981139.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0
ls -la /nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0/bin

cc @jD91mZM2 for testing.

Success on x86_64-linux (full log)
Attempted: xidlehook
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0
shrinking /nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0/bin/xidlehook
shrinking RPATHs of ELF executables and libraries in /nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0
shrinking /nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0/bin/xidlehook
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0/bin
patching script interpreter paths in /nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0
checking for references to /build in /nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0...
warning: working around a Linux kernel bug by creating a hole of 1822720 bytes in ‘/nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0/bin/xidlehook’
/nix/store/n8f7c9j63mv3zd8hliy5vp6sskzmp802-xidlehook-0.6.0

Failure on x86_64-darwin (full log)
Attempted: xidlehook
Partial log (click to expand)
          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)

error: aborting due to previous error

error: Could not compile `failure_derive`.

To learn more, run the command again with --verbose.
builder for '/nix/store/i4jpnsk9ww2i5c18pw11sr5kj7q1gsnc-xidlehook-0.6.0.drv' failed with exit code 101
error: build of '/nix/store/i4jpnsk9ww2i5c18pw11sr5kj7q1gsnc-xidlehook-0.6.0.drv' failed

Thanks! The darwin error can probably be fixed in a similar way to #40840. I have no idea what causes it.
The binary works fine for me :)

Success on aarch64-linux (full log)
Attempted: xidlehook
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/z1wav3ay5dfvqpjym2skldfivcsdzhzx-xidlehook-0.6.0
shrinking /nix/store/z1wav3ay5dfvqpjym2skldfivcsdzhzx-xidlehook-0.6.0/bin/xidlehook
shrinking RPATHs of ELF executables and libraries in /nix/store/z1wav3ay5dfvqpjym2skldfivcsdzhzx-xidlehook-0.6.0
shrinking /nix/store/z1wav3ay5dfvqpjym2skldfivcsdzhzx-xidlehook-0.6.0/bin/xidlehook
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z1wav3ay5dfvqpjym2skldfivcsdzhzx-xidlehook-0.6.0/bin
patching script interpreter paths in /nix/store/z1wav3ay5dfvqpjym2skldfivcsdzhzx-xidlehook-0.6.0
checking for references to /build in /nix/store/z1wav3ay5dfvqpjym2skldfivcsdzhzx-xidlehook-0.6.0...
/nix/store/z1wav3ay5dfvqpjym2skldfivcsdzhzx-xidlehook-0.6.0


GenericArguments.choices is case sensitive.

GenericArguments.choices is currently case sensitive. any chance of getting either a case insensitive version, or modifying choices to be case insensitive by default?
Maybe it should select the choice if there is no other casing, but bail if there are 2 choices with the same case.

 Maybe a uncasedChoices would make more sense.

It should just be case insensitive by default IMO if we want to match the behavior of bash which seems to be the trend within the command API.

Choices is used in a few places besides flags IIRC, I think a few of those uses would be best to remain case sensitive. Additionally command line programs often use multiple cases in flags, which I think is a sane default.

Yeah, I think both case-sensitive and -insensitive variants are needed for choices -- there are valid use cases for case-sensitive but case-insensitive is a reasonable default.

8976964c1038066d3555ac6fb613ed3839037090


Someone can help me to o add error handling code manually to every request in latest rx version?

Sometimes you don't want to add error handling code manually to every
request. Here is extension for Observable to add simple error handling:
extension Observable {
    func showErrorHUD() -> Observable<Element> {
        return self.doOn { event in
            switch event {
            case .error(let e):
                // Unwrap underlying error
                guard let error = e as? Moya.Error else { throw e }
                guard case .statusCode(let response) = error else { throw e }

                // Check statusCode and handle desired errors
                if response.statusCode == 401 {
                    SVProgressHUD.showErrorWithStatus("Please log in again")

                    UserInfo.sharedInstance.invalidate()
                    Router.sharedInstance.popToLoginScreen()
                } else {
                    SVProgressHUD.showErrorWithStatus("Error \(response.statusCode)")
                }

            default: break
            }
        }
    }
}

Above is older, how to use in the latest version

Have you tried replacing doOn with do(onError:)?

 Let us know it doesn't :)

Closing this for now, feel free to reopen when you are still running into this issue!


Image Path

The folder "images" is provided to contain images common on native and react.
Webpack files doesn't consider images inside.
Even if I include images inside webpack, the output path is related below "web" and it cannot use common image folder.
Help us reproduce - tell us about your environment

Standar git cloned repository
Steps to reproduce

Try to include an imagen on any file from the directory src/images in the web version.
Expected result
Image appears
Actual result
Image not found.

Try this:
npm install url-loader
and in web.pack config (dev and prod) add the following under module->loaders
{
test: /.(png|jpg)$/,
loader: 'url-loader'
},
Then in your file you can load those images as

even for me the same issue and resolved like this. It works fine for me.

Try this:
npm install url-loader
then add this url-loader that helps to load images within app
like
{
test: /.(png|jpg)$/,
loader: 'url-loader'
},
restart the npm and now you can access the images folder as:

Try this:

try this:

let me know if that works

It works fine

@brainahdev the solution is working. Thanks !


⚠ Bofrost.es has degraded performance

In ceb36bd, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1433 ms

Resolved: Bofrost.es performance has improved in 3c54f68 after 13 minutes.


⚠ ClamAV has degraded performance

In 877e909, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 594 ms

Resolved: ClamAV performance has improved in 226c303.


Myanimelist tracker is not connecting to aniyomi

Steps to reproduce

In more/setying/tracking
Click myanimelist it opens browser
After login and clicking allow

Expected behavior
Mal tracker should connect to aniyomi successfully after clicking allow in browser
Actual behavior
it just return back to app withput connecting to aniyomi and it didn't even give any error .
Crash logs
No response
Aniyomi version
<IP_ADDRESS>-7493
Android version
Android 12
Device
Samsung M31
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] If this is an issue with an official manga extension and this issue can be replicated in the Tachiyomi app, that I should be opening an issue in Tachiyomi's extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Hello, a thread about it is already opened : https://github.com/aniyomiorg/aniyomi/issues/1381.

Hello, a thread about it is already opened : https://github.com/aniyomiorg/aniyomi/issues/1381.

In my case it didn't even give error and not connect too

Can you send me the invite link aniyomi discord server

https://github.com/aniyomiorg/aniyomi/issues/1381#issuecomment-1937225516
This fix my problem.
Change my user agent

To anyone still here: this issue can be potentially fixed by changing the user agent.

Now log in the MAL tracker again and it'll hopefully work


A problem about Depth Weighting by Graph Matching (DWGM)

Thanks for your great work.
I have a question about the DWGM. I guess that the 2D-3D keypoints are paired, so why do we need to adopt the Sinkhorn to match pairs? How about directly adopting the E to supervise the similarity matrix?

Great question! We tried to directly supervise the similarity matrix before, but it didn't perform well. The main reason is that the Sinkhorn layer extracts global information from the similarities of all keypoints.  If you directly adapt the E to supervise the similarity matrix, one keypoint doesn't know its similarity with the other keypoints.

Thanks for your quick reply. It makes sense. I guess this reason before raising this issue, but seeing " It is worth mentioning that Context Normalization extracts the global information of all edges. (below Eq.9)" in your paper, I think that it could be solved with the CN layer. Thanks for your explanation! :D


removed clinvar from dbNSFP to avoid confusion

Hi Brad,
I've removed the clinvar related fields from dbNSFP. My reasoning behind this is the following:

we already have clinvar annotation through VEP/gemini/vcfanno-gemini
the existing clinvar annotations are more recent than those in dbNSFP
having a multitude of clinvar related fields with similar names causes confusion about which is which.

Hope you agree, if not, feel free to close this PR.
Cheers
M

Matthias -- thanks for this. This makes good sense and I agree with having the clinvar fields directly from the VCFs.


Shorten mills username_pattern

This allows everyone with a 2i2c address to login into the mills hub instead of listing the entire tech team one by one in an effort to de-uglify a bit the username_pattern and make it more understandable.

but for now, it is OK.

I think so too!
Thanks @consideRatio and @damianavila :blossom:


Add collaborators to this repo

Comment below to be added as a collaborator
We will all be using this repository today. Even though it's public right now, you will not be able to make changes until you're given the correct permissions. We've automated this process via the GitHub API. Once you comment, we will add you as a collaborator.
You'll start to receive a lot of emails. (❗) You can slow these down immediately by clicking the Unwatch button at the top of the page and selecting either the Participating and @mentions or Ignore option.

hii

vinod

hi

Tarini

Ranjana

hi

hi

Adding a comment

hai

Hi

Mousima

hi

HI

akash

vineeta

hii

hi

Hi

Hi test comment


Lume 2

This is a Pull Request to track all changes for Lume 2.0

All changes are documented in MIGRATION.md.
The release of Lume 2 is planned for when Deno v2 comes out

May I suggest to rename the core plugin search to query? It could be useful in if people want to searching for help. I've posted about this case in discord bot ai

May I suggest to rename the core plugin search to query? It could be useful in if people want to searching for help. I've posted about this case in discord bot ai.

Speaking of array value, the other properties could use it as well...
// 1. string query
`genre=comedy`

// 1.a value prefix
`genre=!comedy` // (!) is prefix of negative not
`genre=^c` // (^) is prefix of beginning
`genre=*c` // (*) is prefix of middle
`genre=$y` // ($) is prefix of ending

// 2. array array
`genre=[comedy]`
`genre=[comedy,romantic]` // (,) means and
`genre=[comedy|romantic]` // (|) means or

// 2.a array item prefix
`genre=[!comedy,romantic]` // (!) is prefix of negative not
`genre=[^c,romantic]` // (^) is prefix of beginning
`genre=[$y,romantic]` // ($) is prefix of ending

// 3. math query
`genre=comedy` // is

// 3.a for number type only
`episode==69` // equal
`episode>69` // greater
`episode<69` // lesser
`episode>=69` // greater or equal
`episode<=69` // lesser or equal

// 3.b for array type only
`genre==[69]` // array length has 69 items
`genre>[69]` // length is greater
`genre<[69]` // length is lesser

// 4. combination query
`genre=[comedy,romantic]&theme=superhero` // (&) means and
`genre=[comedy,romantic]|theme=superhero` // (|) means or
`genre=[comedy,romantic]|(theme=superhero&episode=2)` // (parenthesis) group

Basically, we have 6 operators in total (relation between key & value):
(all num only can be called math operators as well)

= is : () if num is used, it will be treat like string
== equal : (compare op)
> greater : (compare op)
< lesser : (compare op)
>= greater or equal : (compare op)
<= lesser or equal : (compare op)

The syntax also uses 5 prefixes (patterns) (value trait):

`` no pattern, looking for the value
! negative pattern, anything but the value
^ beginning pattern of looking for str starts from the value
$ ending pattern of looking for str finishes with the value
* include pattern of looking for str contains the value

There are 2 types of wrappers:

[] array value has multiple combination

with = and 5 patterns, it looks for pages with those patterns (values' relation depend on dividers, see below)
with compare op and 1 numeric value only, it looks for pages has the valid array length. genre==[69] genre property must have 69 items, for ex.

() group is high priority (no nesting, it's too complicated)

And 3 dividers of wrapper (relation in wrapper):

, and (for array)
& and (for group)
| or (for all)

Even though I'm the culprit did this proposal.  But at least, it doesn't as confuse as OR condition in the doc right?

I my opinion, your proposal is too complex, and currently, there's an or operator (for example genre=comedy|romantic).
For now, I won't make changes because the current API is enough for the 99% cases and anyone needs something more powerful, it's possible to create a tailored solution.


update the publish directory

The Dockerfile does not match the Visual Studio solution publish directory.
/cc @spboyer

Open Publishing Build Service: The pull request content has been published and here are some changed files links of this time:

Docset 1 - core-docs
No file of this docset changes.

Status: Succeeded.
Open Publishing Report.

@spboyer can you review this one?


Side panel not rendered correctly in light mode high contrast

Is the bug present when using the default Obsidian theme?
No
Is the bug present when snippets and plugins are disabled?
Yes
Minimal theme version
7.3.1
Describe the bug
Hi,
I am not sure where to post as I can identify who's the culprit. I am using the Minimal Theme, light, high contrast.

The first picture is how it is supposed to look, and the second is how it sometimes looks.
The error is not constant, and switching theme back and forth resolves it.
However, when loading a workspace, it always displays that grey colour for a fraction of a second before turning it dark, if it does.
The error seem to always happen the first time after loading Obsidian, and much less often afterwards (after having loaded another theme and back to Minimal).
I have a snippet that changes the right side panel colour, but the error happens also without or if I change its colour.

Debug info
SYSTEM INFO:
Obsidian version: v1.5.3
Installer version: v1.4.16
Operating system: Windows 10 Home 10.0.22631
Login status: logged in
Catalyst license: none
Insider build toggle: off
Live preview: on
Base theme: light
Community theme: Minimal v7.3.5
Snippets enabled: 1
Restricted mode: off
Plugins installed: 35
Plugins enabled: 30
1: Zotero Integration v3.1.7
2: Auto Link Title v1.5.3
3: Better Word Count v0.10.1
4: Callout Manager v1.0.1
5: Commander v0.5.1
6: Convert url to preview (iframe) v0.5.0
7: DataLoom v8.15.11
8: File Color v1.1.0
9: Highlightr v1.2.2
10: Kanban v1.5.3
11: List Callouts v1.2.0
12: Mind Map v1.1.0
13: Minimal Theme Settings v7.3.1
14: Note Refactor v1.8.2
15: Outliner v4.8.0
16: Projects v1.17.1
17: Recent Files v1.3.10
18: Reference Map v1.8.1
19: Style Settings v1.0.7
20: Tag Wrangler v0.6.1
21: Workspaces Plus v0.3.3
22: TickTick v1.0.4
23: Tasks v6.0.0
24: Hover Editor v0.11.16
25: Dataview v0.5.64
26: BRAT v0.8.3
27: Query Control v0.6.0
28: Metadata Menu v0.7.7
29: Git v2.23.1
30: Advanced Tables v0.21.0
RECOMMENDATIONS:
Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Does this occur when snippets are disabled?

Yes it does.

I can't reproduce this. It's unlikely to be related to Minimal. I would suspect it's somehow related to one or your plugins or snippets.


super messy warnet commit

Run pip install -e . to install.
If you want to clean the venv you can first:
pip uninstall warnet
pip freeze | xargs pip uninstall -y
pip install -e .

Going to squash and merge this one


Hotfix/copier

Description
Fix some mistakes when configuring copier.

Good - I saw the latest pr didn't pass all tests in main, but you are already working on that. Nice!

I'll go ahead and try this!


VS2015 Support and MSBuild 14

Hi,
In order to get MSBuild 14 (shipped with VS2015) the MSBuildVersion is semantically incorrect ie:(VS14 which doesn't exist).
.Do(msb =>
    {
        msb.ToolsVersion = "14.0";
        msb.MSBuildVersion = "VS14"; //Hack for MSBuild VS2015

        msb.Solution = Projects.SolutionFile.ToString();
        msb.Properties = new
            {
                Configuration = "Release",
                //OutDir = Folders.CompileOutput
            };
        msb.Targets = new[] {"Rebuild"};
    })

@bchavez thanks for raising this.

I can submit a pull request if you prefer. It should be an easy fix.

Sure, please go ahead!
For reference - https://github.com/bau-build/bau-msbuild/blob/master/CONTRIBUTING.md

@bchavez I've released 0.1.0-beta02 which contains this change.

awesome. thank you! :+1:


Provide benchmarks against rusttype

As this is a direct descendant of rusttype, and a continuation of that project aimed at solving, in part, performance it would be nice to see some common cases where performance will have increased (or decreased!!).
These might not be perfect since the API changed, but they should be an indication of common operations like rendering some text.
EDIT: I didnt look closely enough, but maybe put the benchmarks in the repo readme.md as well, thats where people will often look for them.
Anyway, looks like a nice performance bump you got from doing the revamp!

Yep a simple comparison is provided in the ab_glyph nested readme.
Maybe it'll be worth just hoisting this readme to the root level and having a link to a nested one just for ab_glyph_rasterizer? The nested readme is used on crates.io/crates/ab_glyph, so maybe it isn't a big deal.
I don't expect ab_glyph to be slower that rusttype at anything really. They're fairly similar abstractions on ttf-parser, but ab_glyph does less implicitly, so no font-ref cloning or pixel bounding box calculating unless asked for explicitly. The latter particularly matters for otf fonts.

I'll assume it isn't a huge deal having ab_glyph readme top level.


Getting started guide

Yo!
I see there are contributing docs from the OG project and docs on how to quickstart from source
Gonna play around with trying to get this built using those but let me know if I should be headed in another direction?
I like writing docs so if I get this figured out / if someone can show me the right way I'll be happy to write something up 😛
cc @Andykmcc @hcourt @abhumbla

Picking this up as part of our documentation push. The plan is to make a repository with markdown files, and then use gh-pages or something similar to serve them as a Wiki.

I created a repo for general project docs and planning. It's bikehopper/bikehopper.

Oh oops, let me just make a wiki folder in there instead. No need for a separate repository in this case.

Let me know if you need access permissions or whatever. I think I'm the only one who uses that repo at the moment.


⚠ ClamAV has degraded performance

In 33a46aa, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in 0c12b76.


Sub Component (2)

Test case working: combine 2020, tables and title not working

fixed instance of, need test for role integration


Auto-size table columns

All tables should be "auto-sized", except for description fields which should be default max XX chars.
This also covers the issues

[x] equinor/cc-components#269
[x] equinor/cc-components#266

@MagnusGjosund are all columns now behaving similarly, auto-sizing appropriately? I would appreciate linking PRs to the issue it closes. That way you don't have to close the issue manually - and we have an audit trail ;)
So - I ask if this one can be closed?


SMS Backup+ needs a new logo/app icon!

I received an email from the Google Play Store team, telling me they decided to take down the app:

We reviewed SMS Backup +, for package ID com.zegoggles.smssync, and found that it violates our intellectual property policy. The application has been removed from Google Play and won’t be available to users until you submit a compliant update. You can read more about intellectual property and our other policy guidelines in our help center.

While not explicitly stated it is very likely because of the fact that the current icon reuses graphics from Google's Gmail / Messages apps. However the same icon has been in use four more than four years so it's a mystery to me why they decided to take down the app now.
It'd like to use this issue as a call for proposals / discussion to decide on the next logo.
To start things off, here are two concepts by the designer of the current icon, Shimon Simon:

I like the second one better then the first, but would personally like a more slimmed down Material Design inspired icon more.

Material design icon style guidelines

Product icon design is inspired by the tactile and physical quality of material. Each icon is cut, folded, and lit as paper would be, but represented by simple graphic elements. The quality of the material is sturdy, with clean folds and crisp edges. The matte-like finish interacts with light through subtle highlights and consistent shadows.

Yep. That's it.
Problem I see with these two Icons is, that they look cluttered. There's too much in them.
When you scale them down to the size they will occupy on a smartphone screen they just don't look that good.

Hi, I really like your app, and I'm sorry for this problem with Google. I would be very pleased to submit an alternative icon for the app, if you like... here's a sample :)
Bye, and thanks for this great piece of software!

That's not right at all! Jan, all the best with getting it back on Play Store!

shimon's updates based on feedback:

I Like the first one, remidns me fo the old icon :)

The second one is good!
The first one wouldn't look good when placed on a dark background.

Signed up just to thank you for your work on this app. This response from Google is very disappointing - they could have easily requested that you change it by a certain date rather than just pulling you from the store.

I think you should quickly resubmit your apk with any plain icon to make sure it is the icon that is the problem.  If they accept it then go for fancy icon.  Plus SB+ will be back up while new icon is in progress.

Thank you jberkel for your great job here. ImI subscribed to GitHub to show support to jberkel. I also couldn't find SMS Backup+ on Google Play, but I could download it from F-Droid. In fact I'm going to stick to F-Droid much more than in the past.

I went crazy when I searched the google play store for "SMS backup +", after installing a new ROM, and saw a bunch of  other sms backup apps but yours was not in the list. I agree with others that you resubmit the app asap. Thank for posting the apk file.

Agreed, being in the store with any icon is better than finding perfection.
Jan does this for free so he probably has other priorities :)

Looking forward to your re-submit of the app. I too freaked out when installing other ROMS and didn't see you app in the store. Lucky I had a backup still.
I like the second icon in your first post.

First of all - thanks for creating this app. I've tried many out there (including the other most popular ones), and they don't compare to yours.
I'd like to suggest the logo be more representative of the distinguishing feature of your app.
That is, SMS to email chain. As you know, others are inferior in that they simply allow an PDF of SMS to be backed up, or send and email with texts from everyone in one email, etc. Your's allows one to use the power of Gmail to search for specific threads. It's fare more useful when searching through backed-up SMS.
The proposed logos you displayed don't represent anything distinguishing about your excellent app, and they look generic. I suggest a logo that represents SMS 2 Email Chain, with "email" and "chain" represented graphically. I'm sure now many people are searching for your app on Play, as I was when I switched phones, and their search might be hampered a bit by a name change. However, changing the name to SMS 2 Email Chain would allow people to more easily understand the core strength of the app. Further, a name change would allow for your avid online following to virally announce a name change and the reappearance of your app on Play - and that could boost the app's popularity.
If you are interested, I am available to discuss any of these ideas.
Thanks again, your app has been of great use.

I also signed up just to comment. I love you app and was stunned to find it missing! I'm very grateful you are working to get it available again. https://cloud.githubusercontent.com/assets/18891/9132431/6b57e67e-3ceb-11e5-85e5-932d5a9dad7f.png  <That's the icon I like the best so far.
But might I suggest making the blue message block into a green one, to harken back to your original icon? When I went looking for it, the green message in an envelope was what I hunted for first, and only after I didn't see it did I go looking for the exact name of the app. That and the + sign were what I remembered most.
I needed this to backup my broken phone, and now that I know you are working on it I will wait so I can use this again. Thank you so much for keeping it going! It's an awesome app!

I prefer the first icon of your last post @jberkel . But I would put a little bit more details around the flap where it fold. Maybe have the flap just a little bit folded forward with a bit of shadow effect. Go material design for sure :)
Thanks for having maintained this app all those years!

Same as x61, I was losing my mind trying to find your app after installing a new rom. It's absurd that they would entirely pull you off Google Play. At least leave a placeholder telling everyone it is temporarily not available. Thank you so much for the app and all your work. It is seriously appreciated. As for the icon, I would choose the second icon in Shimon's second redesign.

Downloaded and installed, nice job!
I hope that Google people give up kicking up a fuss.

app is back in play store, with this icon


Add assertions when implicitly returning from a function

Currently if a function implicitly returns undefined (by leaving the function without an explicit return  statement) we won't generate a check for it, e.g:
function foo (): string {
  // no return
}

currently compiles to:
function foo () {
  const _returnType = t.return(t.string());
  // no return
}

We should insert a call to _returnType.assert(undefined) at these points.

marking as low priority because Flow already catches this.


syntax=python: smartindent: line folding into tw inserts udesired whitespace

Steps to reproduce
22:11 -!- Irssi: Join to #vim was synced in 12 secs
22:12 < stenur> Hello!  I use vim for over twenty years, but unfortunately have forgotten almost anything on the configuration ;}
22:13 < stenur> I see a bug, but dunno what it belongs to.
22:14 < stenur> The thing is, if i have an overlong line that exceeds "tw", and i add another character, the line is split automatically into several that adhere to "tw".
22:15 < stenur> The new problem i see in 9.0.2130 (likely: compared to 9.0.2095, but i cannot swear),
22:16 < stenur> is that if that superlong line shows some whitespace in column 0 of a "visual followup line",
22:17 < stenur> then vim will add superficial whitespace ("masses of tabulators beyond any logic") for that line, after the auto-split.
22:17 < stenur> Can anyone make any sense out of that?
22:18 < stenur> Thank you.
Expected behaviour
Simply break that single line to fit in tw, leaving the embedded whitespace intact.
Version of Vim
9.0.2130
Environment
CRUX Linux (rolling release, updated once a week).
Logs and stack traces
No response

What is this? Are you reporting an issue, that you think is not seriously enough that you cannot write a clean and reproducible bug description? Sorry, but then I won't even try to understand what this is all about. Please give precise clean and reproducible bug descriptions.

Hah.  Funnily i remembered.
I copied via firefox-bin as compiled by Mozilla itself a paragraph from
https://en.wikipedia.org/wiki/Deterministic_acyclic_finite_state_automaton.
The one which starts "A DAFSA",  but the one starting with "In computer science" also works.
So with my vim, if i ":read!cat" and paste the paragraph, then go at the end of the line and type a character, vim does it.

Hello dkearns!  Thank you!
Bad bug report, i apologise.
Yes, you are absolutely correct, i do have smartindent, and i can reproduce the problem with "vim --clean FILE.py" plus "set tw=78 smartindent" ('hope i have forgotten nothing) and adding another character.  A follow line gets folded-inserted to match an open parenthesis on a former line.
I have never seen such smartindent "mess" before?
Btw the line as such is as follows (as a single long line in a file).
A DAFSA is a special case of a finite state recognizer that takes the form of a directed acyclic graph with a single source vertex (a vertex with no incoming edges), in which each edge of the graph is labeled by a letter or symbol, and in which each vertex has at most one outgoing edge for each possible letter or symbol. The strings represented by the DAFSA are formed by the symbols on paths in the graph from the source vertex to any sink vertex (a vertex with no outgoing edges). In fact, a deterministic finite state automaton is acyclic if and only if it recognizes
a finite set of strings.[1]

(I have smartindent in "forever" (that could be the 22 or 23 years i use vim), on the global level.  And use vim daily for C, C++, perl, awk, sh, roff, email, earlier quite some other languages.)


fix multus-config no pointer address panic

I did not check the pointer variable and just use it and it caused panic.
Signed-off-by: Icarus9913<EMAIL_ADDRESS>What this PR does / why we need it:
fix bug
Which issue(s) this PR fixes:
close #1990

done by https://github.com/spidernet-io/spiderpool/pull/1996


Sales team not responding

The sales team does not respond to emails or phone calls. What to do now to purchase or to get support. I know this is not relevant to technology, but need support from the sales  IMMEDIATELY! Please support.

Hi,
The best way to reach support is to email<EMAIL_ADDRESS>Support has a free tier, so you don't need to purchase it. If you want to reach sales, you can email<EMAIL_ADDRESS>Cheers,
Alex


Intermittently hit with validator errors

This appears randomly from Vite, with no error thrown in the actual console on the app side:

Are you using released package? Or are you working in the dwn-sdk-js itself? If the former, then I don't know why vite would randomly not find the file, the file is there, unless it is failing to copy it before starting the server.

Closing as stale. Haven't heard complains similar to this in months. Feel free to reopen or open new issues.


Use better logos

Use better logo that look asthetic. Refer to WeMakeDevs's Readme for reference

hey there i would like to contrib on this issue can you assign me.


Show accounts list on request connection

Today when a DApp requests a connection, the Wallet only allows authorizing the current active wallet. For this, we need to implement a new step in the flow;

On request connection: Open the wallet starting with the Account List with a selector action enabling users to select which wallets will be allowed for the current DApp.
After this, the flow continues to the authorization screen: On this screen, the dropdown of the account today shown should be removed, and implement a component that shows all the accounts have been approved for the connection.

close in favor of #387


C/C++ Integration

Are there any plans for supporting anything related to C/C++ and GDB?

Closing as we track desired language plugins at https://github.com/LightTable/LightTable/wiki/Feature-wishlist#language-plugins


Xaml editor shows member functions not properties when trying to use path statement.  Project Reunion 0.8.1 Windows 10 21H1

Xaml Editor shows member functions not properties in xaml editor
Project Reunion 0.8.1
Windows 10 21H1

@RealTommyKlein FYI


Enable Connection support for BQ Pushdown plugins

Testing
Locally on sandbox : enabled transformation pushdown and ran the pipeline.
Issue
https://cdap.atlassian.net/browse/PLUGIN-1001

This PR is correctly replicated here
: https://github.com/data-integrations/google-cloud/pull/860
This was a test branch.


GUI... messes up? Too many files displayed?

I think it might be because too many files...

Same here, in Branches and Log tabs

Happens on Atom 1.0.  Possibly related to #86 with no scrolling capabilities.
Whether Atom isn't sending the scroll messages or atomatigit not handling them, I can't say now...

In case it may be useful to someone else, until it gets fixed upstream, I managed to fix this adding this code to my style.less (should fix #88 and #86 as well, that seem duplicates):
.atomatigit {
  overflow: auto;
  display: -webkit-flex;
  -webkit-flex-direction: column;
  height: 100vh;

  .hidden {
    .current-branch-view {
      -webkit-flex: 0 0 auto;
    }
  }

  .lists {
    -webkit-flex: 1 1 auto;
    overflow: auto;
    position: relative;

    .list-view {
      display: block;
      position: absolute;
      top: 0;
      right: 0;
      left: 0;
      bottom: 0;
      height: 100%;
      overflow-x: hidden;
      overflow-y: auto;
    }
  }

  .tab-bar {
    -webkit-flex: 0 0 auto;
    margin-bottom: auto;
  }
}

maybe you should fork & pull request ^ xD

There is a pull open already (#107) to fix the same issue – most of this code comes from there – but hasn't been merged yet (~20 days) and I see from the commit history that the repo hasn't been updated for a while.. so, until @diiq updates the official package (or the project gets forked), I thought a quick & dirty local patch might come handy to the people using the package on a daily basis like me.


[INFRA] Fix linkchecker

The problem with our linkchecker failing for weeks is the following:

Mkdocs inserts an HTML header into each HTML site that it builds.
That header contains a "canonical" URL
For us, this canonical URL points to the "stable" website, see also: https://www.mkdocs.org/user-guide/configuration/#site_url
This can be customized here: https://github.com/bids-standard/bids-specification/blob/4bf68b9d0bc09e61879e9196e2e48e1471e0fa2a/mkdocs.yml#L2

This is how it looks:
<!doctype html>
<html lang="en" class="no-js">
  <head>

      <meta charset="utf-8">
      <meta name="viewport" content="width=device-width,initial-scale=1">

        <link rel="canonical" href="https://bids-specification.readthedocs.io/en/stable/01-introduction.html">
...

Whenever we add a new HTML page to the spec, like the glossary, or microscopy - but haven't done a release yet, linkchecker will fail because those HTML pages are not available in the stable (canonical) URL.
I think we can fix this by temporarily adding these files to the ignore list of the linkchecker, and then "cleaning up" that ignore list at release time.
WDYT?
EDIT: cc @tsalo who figured this out in the first place

I also tend to start ignoring doi.org links here, see https://github.com/bids-standard/bids-website/pull/223


appengine.Context is now context.Context

minimal changes to get changed tree of Context that affect oauth2 fork
working. Fixed the tests as well.
Signed-off-by: Prasanna Santhanam<EMAIL_ADDRESS>

Tested and working. Thanks!

Thank you for the fast turnaround on this!


s3-backer 1.4.3

Seems fine, although I'll like you more if we don't start adding spaces between various dependency types 😄.

Good, I like that rule.

Thanks for changing that.


Env var or setting to disable some modal dialogs

Since there's already a confirmation that pops up before deleting, this extra popup seems unnecessary and just makes it a bit cumbersome. A way to disable them would be awesome!

(same for the Successfully created your link popup...)

Hmm best way would probably be adding a per device site settings page, and "Show confirmation popups" could be a setting on that, would that work for you?

Per device, or per user account? Not sure I understand the logic in it being a per-device setting—but honestly whatever you think makes the most sense logically. I appreciate the response and happy new year!

I was thinking just per device, as there are plans to add custom colour themes in the future and it'd probably fit in well in the settings next to the above mentioned feature.
Also means that if a user would like the pop-ups enabled on their phone when it's easier to miss-click something, they can.
And yeah, happy new year to you too!

In the mentioned commit I've added a toggle for this feature, it disables all of the "Successfully...." popups.
It'll be added in 1.8.0 which I'm hoping to release soon, I wouldn't recommend running it just yet but you're welcome to give it a go with :1.8.0-beta in a test docker container.

Sounds great, I'm on the road now but will give that a test pretty soon. Thanks for considering this!

I just had a chance to try that 1.8.0 beta
Looking very nice!
The feature to reduce the popups is working great.
Just 2 little things I noticed:

The switch looks reversed, or upside down or whatever. Off is on and on is off... screenshot:

The little (account switcher?) popup has my account and then a "blank" account checked off, seems like an index is off by one or something

Glad it works well for you.

I wasn't completely sure of the best way to orient the toggle, but right, towards the text it's turning on probably makes the most sense.

Ahh yeah that filters links by user, I'll look into fixing it and maybe making its use a bit more clear

Only other thing I noticed so far is the Add Link button could use some more padding along the right edge of the view.

I've fixed both of the above issues.
The user filter was a bit unclear, that top one filters by all available users. It now says "All users" - UX isn't quite my speciality 😆

Just pulled a fresh 1.8.0-beta, looking good!