[Enhancement] print sql when throw exception

What type of PR is this：

[x] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[x] 2.4
[x] 2.3
[x] 2.2

[FE PR Coverage Check]
:disappointed: fail : 1 / 2 (50.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ConnectProcessor.java
1
2
50.00%
[364]

run starrocks_admit_test

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4

@Mergifyio backport branch-2.3

@Mergifyio backport branch-2.2


Install librealsense in podman

Required Info

Camera Model
D400

Firmware Version
<IP_ADDRESS>)

Operating System & Version
Ubuntu 22

Kernel Version (Linux Only)
5.15.0-107-generic

Platform
PC

SDK Version
5.16 }

Language
C++

Segment
{Robot }

Issue Description
I want to install librealsense in a docker container, but there is no very clear instructions how to configure host and container.
Understand that if we install the pre-build package following https://github.com/IntelRealSense/librealsense/blob/master/doc/distribution_linux.md. We need to install librealsense2-dkms. However, if we build from source following https://github.com/IntelRealSense/librealsense/blob/master/doc/installation.md, there is not mention that we need to install librealsense2-dkms. Instead, there is a script ./scripts/patch-realsense-ubuntu-lts-hwe.sh need to patch the kernel when build from source.
In the dockerfile here https://github.com/2b-t/realsense-ros2-docker?tab=readme-ov-file#12-installation-from-source and https://github.com/IntelRealSense/librealsense/blob/master/scripts/Docker/Dockerfile. There are not requirement to install the dkms or patch the kernel.
I also saw adding -DFORCE_RSUSB_BACKEND=TRUE https://github.com/IntelRealSense/librealsense/issues/12158#issuecomment-1702787288 then no need to install dkms?
I have some questions:

Do we need to install librealsense2-dkms or run  ./scripts/patch-realsense-ubuntu-lts-hwe.sh in the host or containe and why.
How does '99-realsense-libusb.rules ' in the container affect the host, is it necessary to copy it to the container?
Do we need -DFORCE_RSUSB_BACKEND=TRUE while I saw both dockerfile do not set it
What exactly we need to configure for the host and container?

There are not many references available for installing only librealsense in a Docker container.  The Intel guide that you linked to is one of the best available,
https://github.com/IntelRealSense/librealsense/blob/master/scripts/Docker/Dockerfile
Guides to Docker container installation that are shared by RealSense users are usually for librealsense + ROS, like the one at https://github.com/IntelRealSense/realsense-ros/issues/388#issuecomment-410672421

Packages such as librealsense2-dkms are not used when building the librealsense SDK from source code with CMake with the installation.md instructions.  This includes source code builds that use the flag -DFORCE_RSUSB_BACKEND=TRUE
The SDK should be built either from packages or source code but not both installation methods on the same computer, otherwise there could be more than one librealsense installation on the same computer that conflict with each other.
Installing with both packages and source code on the same computer can also result in two different sets of udev device handling rules being installed, which can cause an error called Multiple realsense udev-rules were found!
The two rules are named /etc/udev/rules.d/99-realsense-libusb.rules and /lib/udev/rules.d/60-librealsense2-udev-rules.rules.  The /lib '60' rule is created by a dkms package installation and the /etc '99' rule is created by a source code installation.
If you have both types of rules on your computer then the /etc one is the one that should be deleted, as deleting the /lib rule can result in dkms packages becoming broken.

Do you require further assistance with this case, please?  Thanks!

Thanks for your replied, I have done the experiment that, 99-realsense-libusb.rules has to be installed in the host to setup the permission.

I have another question. How to determine whether the camera is D435IF or D435I from the SDK? We can get device name from RS2_CAMERA_INFO_NAME but both  D435IF or D435I displayed as D435I

Cameras with a filter on their sensors do not have 'f' in their name, so a D435f will be D435 and D435if will be D435i.  The camera's firmware driver works out the name of the product based on the components that it can detect, such as RGB sensor and IMU.  A filter is not a component that the firmware can detect.

Case closed due to no further comments received.


Add support for context nodes

DOMXPath->query() has a second parameter, $contextNode, that supports querying in the context of a specific node rather than relative to the document root. It would be nice if Zend\Dom\Query->queryXPath() provided equivalent support.
If the maintainers agree that it's reasonable to add this feature, I'd be happy to submit a PR that implements it. If so, any specifics on preferences regarding that implementation would be appreciated.

@elazar GO FOR EEEETTTTT! :)


Bug: Non-authenticated user logged out on public page

Describe the bug
When on the public side of the RS website and not logged in, after ~15 min get sent back to the homepage.
Impact on ReportStream
This is poor user experience for non-authenticated users.
Steps to reproduce
Steps to reproduce the behavior:

Go to a non-authenticated page (like https://reportstream.cdc.gov/product/release-notes)
Navigate to a different tab
Wait about 15 min
Return to the tab to see that you have been automatically navigated to the RS homepage (https://reportstream.cdc.gov)

Expected behavior
When not logged into the site, I should not be navigated away from a public page to the homepage after any amount of time.
Resources
Logs
Device info
Desktop (please complete the following information)

OS: MacOS
Browser Chrome
Version 111.0.5563.64

Smartphone (please complete the following information)
Additional context

@chris-kuryak is this still happening?

It appears this is no longer happening to me. I will close it.


Put links at top of page to sections further down on page

For the Data Download page-- I think it makes sense to keep it all as one page, but there are a few sections identified. I think it would be helpful to identify these sections at the top (identify all the bits that need to be completed during this stage), and then have links to those sections up at the top. This is similar to how you did it on the google drive, but I'm not (yet) sure how to do this here, so making this an issue for one of us to resolve!

On the left side of the page it has the section headers linked (under 'On this page'). Is this good or do you still want me to link the sections in a different way?

Oh! You mean on the 'right-hand side', correct?
I never saw that before! Yes, that should be fine (as long as others see what I missed!)
:)
Will close this issue. Thanks!

Oh yes right hand side!
Something about me is I ALWAYS mess up my right and left, people always call me out for it. Sorry about that!

We all have our things... no worries. I have a LOT of little things
:)


Feature/math 1586

Coverage decreased (-0.09%) to 90.614% when pulling b7f3f57f89c792284dd8ff017ae659ba159f6519 on samyBadjoudj:feature/MATH-1586 into d080f0d8251d58728024955764a5c0c75acf8277 on apache:master.


Performance issues with tracer reportError in high concurrency scenarios

1、堆栈过大
2、数组拷贝

In fact, we need to pay attention to is why we get the errors.


Issue with k8s.io/docs/reference/command-line-tools-reference/kube-apiserver/

This is a...

[ ] Feature Request
[x ] Bug Report

Problem:
I'm not sure if the page [1] is autogenerated, since it doesn't match the list of kube-apiserver flags in the latest Kubernetes release. Some are there, others don't, different names, different type, different description.
For example, the source code says there is a --addmission-control flag. There is no such flag on page [1].
Flag --alsologtostderr is not mentioned on [1].
I don't see flags --audit-log-batch* in the source code or kube-apiserver --flags output, but page [1] says they are there, and so on.
Proposed Solution:
Don't include output of such menus in docs. It requires extra time and effort to maintain it. If it's not autogenerated from the source code, it can be outdated any moment.
Page to Update:
[1] https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/

v1.9.9

@tengqm Hi, maybe I don't follow smth but I compare website V1.11 and the source code of release 1.11. For example, option: https://github.com/kubernetes/kubernetes/blob/release-1.11/pkg/kubeapiserver/options/admission.go#L68 is not mentioned on https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/ which is V1.11

@alexxa Thanks for the reference. Investigating ... The case is not straightforward because there have been some struggling on whether "deprecated" flags should be shown, AND where "hidden" flags should be shown. Some time ago, the recommended practice was to HIDE the "hidden" flags, but that practice has received many complaints. Will look into this and see if we need to regenerate all the reference docs again.

Thanks @tengqm


feat(agents): address killswitch usability issues

Motivation
Killswitch is functional but takes too long to configure. Configuration should be handled automatically and require only local AWS credentials to run.
Solution

AWS credentials are sourced locally from a well known location
All secrets are fetched from an S3 bucket
Adds an --environment flag to select deployment to target (e.g., production)
The kill process now runs in parallel to be faster
Has a required --force flag (the opposite of a --dry-run flag)
Output is human-readable and more descriptive (no longer json)

PR Checklist

[x] Added Tests
[x] Updated Documentation
[x] Updated CHANGELOG.md for the appropriate package
[x] Ran PR in local/dev/staging

I've already changed that unnecessary clone let me push it.


included stl libraries in some .cpp files

Feel free to reject it if it is not necessary.

added libraries "algorithm" to hllc and hlle; "limit" to gas_drag_on_dust


[Solved] write_epsresso_files not working

**Edit: ** Solved. Apparently pip install was downloading a lower version. Creating a new conda environment and updating to the latest snb version solved the issue.

I'm following the Defects Generation tutorial for doped which uses shakenbreak. I want to generate espresso files.
Steps to Reproduce
from pymatgen.core.structure import Structure
from doped.generation import DefectsGenerator
from ase.calculators.espresso import EspressoProfile
from shakenbreak.input import Distortions

struct = Structure.from_file('../../_data/cif/CsPbBr3.cif')
defect_gen = DefectsGenerator(struct)

Dist = Distortions(defect_entries = defect_gen)

defects_dict, distortion_metadata = Dist.write_espresso_files(#pseudopotentials = {"Br": "Br.UPF", "Cs": "Cs.UPF", "Pb": "Pb.UPF"},
                                                              output_path = '../../_out/distort/',
                                                              # profile = EspressoProfile(command="pw.x", pseudo_dir="."),
                                                              #write_structures_only = True
                                                             )

snb passes this to ase. As per the documentation, pseudopotentials are optional. But this as it is led to:

File ~/anaconda3/envs/py38mats/lib/python3.8/site-packages/ase/io/espresso.py:1292, in write_espresso_in(fd, atoms, input_data, pseudopotentials, kspacing, kpts, koffset, crystal_coordinates, additional_cards, **kwargs)
   1288 species_info = {}
   1289 for species in set(atoms.get_chemical_symbols()):
   1290     # Look in all possible locations for the pseudos and try to figure
   1291     # out the number of valence electrons
-> 1292     pseudo = pseudopotentials[species]
   1293     species_info[species] = {'pseudo': pseudo}
   1295 # Convert atoms into species.
   1296 # Each different magnetic moment needs to be a separate type even with
   1297 # the same pseudopotential (e.g. an up and a down for AFM).
   1298 # if any magmom are > 0 or nspin == 2 then use species labels.
   1299 # Rememeber: magnetisation uses 1 based indexes

Attempts at Solution
I managed to bypass that by giving a dictionary of pseudopotentials but then ran into a profile error:
File ~/anaconda3/envs/py38mats/lib/python3.8/site-packages/ase/calculators/genericfileio.py:274, in GenericFileIOCalculator.__init__(self, template, profile, directory, parameters)
    272 if profile is None:
    273     if template.name not in self.cfg.parser:
--> 274         raise BadConfiguration(f'No configuration of {template.name}')
    275     try:
    276         profile = template.load_profile(self.cfg)

BadConfiguration: No configuration of espresso

Apparently this is a newer ase issue. However the source code for snb shows that write_espresso_files does try to check whether the ase version is old_ase or not.
Nevertheless I passed  profile but this time got: TypeError: write_espresso_files() got an unexpected keyword argument 'profile'
The documentation has a profile argument for write_espresso_files but it is not there when I do ?Dist.write_espresso_files:

I checked if there was an issue with version. It turned out that the version conda lists is 3.2.3 but the version in shakenbreak/__init__.py which is given by __version__ is 1.0.2.
Other info
ase version: 3.23.0
doped version: 2.1.0
shakenbreak version: 3.2.3

Great, thanks for posting the solution!


Disable toggle play key event option

I need a way to disable toggle event.

Sorry, found core.mediaControl.unbindKeyEvents();


Link to install.sh returns a 404

This link https://coder.com/docs/code-server/v3.10.2/install.sh contained in this page https://coder.com/docs/code-server/v3.10.2/install#installsh returns a 404 error.

Thanks for the heads-up! @b-trav - we'll get this fixed.


How to use command line in Windows?

Great tool. But I want command line instead of web edition.
So, I download Windows version from http://tabula.technology/ what's the command to process pdf?
It should be something like:
java -jar tabula.jar -a 71.0,71.0,100.07,539.945 --out test.pdf
But what exactly? Given example
java -jar ./target/tabula-0.9.0-jar-with-dependencies.jar -p all -a $y1,$x1,$y2,$x2 -o $csvfile $filename
Dos not work. There is no tabula-0.9.0-jar-with-dependencies.jar file there....

There is an tabula.exe in there, I think it should do the job. Try tabula --help in extracted directory.

Seems like the exe is only a local web-based thingy.
There is no with-dependencies JAR because you didn't built from source (that's okay :D), in your ZIP the tabula. jar is the with-dependencies :)
So, try that:
 java -jar tabula.jar -p all -a $y1,$x1,$y2,$x2 -o $csvfile $filename

The ZIPs from tabula.technology do not contain the CLI interface.
You have to download the Release from GitHub, there also is the with-dependencies.jar: https://github.com/tabulapdf/tabula-java/releases/latest

Thank you.

You should close the issue if it does the job :)


test: add missing test. mainly for serial

Signed-off-by: Nobuhiro MIKI<EMAIL_ADDRESS>

Coverage increased (+17.08%) to 75.238% when pulling 1917ed771dbe93d72b4cbb56c42ed4d6fda59bd0 on add_test2 into 3abfc5367f00a50c8bf64f91c52a4d1abdc2ea8a on main.


Handle error events correctly

The onerror and ontimeout handler are not calling back with errors but with error events (without any messages). Therefore the errorFunc is wrapping them as Error: [ProgressEvent object].
Here's my quick proposal on how to fix this. Just pass generic error messages to the errorFunc, then there will be no case where the error needs to be constructed there.
The spec can be quite helpful here: https://xhr.spec.whatwg.org/

You might also want to call e.preventDefault() there, so the error events will not bubble.

It's not a surprise. The check for error type was there for the case when the function is called with an error. The split between error and timeout could be useful though.
It's a breaking change, so I'll schedule merging this for 3.0

+1 for a fix for this.

Closing this one in favor of #164 - the same thing but rebased on top of current development.


how to calculate elevation_thresholds and flatness_thresholds

Hello,
Thanks for your open source!
I  would like to ask what function  elevation_thresholds and flatness_thresholds are calculated according to

Oops, sorry for the late response due to the ICRA'22..haha.
I'll upload it ASAP

Hello, ralphoon
I added additional explanations about elevation_thresholds.
Since the original parameters are for KITTI, but you can change them depending on your own environment.
[elevation_thresholds]

If your env is strictly flat, then set the elevation_thresholds to be similar to the sensor height.
[flatness_thresholds]
The surface variable is usually set to 0.02 in many papers to estimate whether the target unit cloud is flat or not.
But I recommend setting flatness_thresholds in a more strict way

The best way is to check the printed command line in your command window and then set proper parameters.
If the verbose is true, you can show the below commands:

Like this


Feature Request: Toggle virtual text

Hello, I want to request a feature to toggle the virtual text. But of course as long as you also want to add this feature.

By configurable keybinding do you mean something like this:
require('nvim-biscuits').setup({
  keys = "<Leader>tb"
})

Ok, I have something that I think will work for everyone. The option for setting a binding via the config is there. But the function is exposed for you to bind manually instead.
Go ahead over to the PR and let me know what you think.
#18

Ahhh sorry for the late reply. I will try it


drop last and take first batch  to train

Hi @eriche2016 ,
Thanks for your pull request!
The original "drop last batch" feature is actually a fatal error. Thanks for pointing out.
Also the valid/ test dataset need no shuffle as you noticed.
According to your advice, the bugs are fixed in this commit.
Thank you!
Yu-Hsiang


Fix JNI local ref issues

While fixing all the possible JNI issues would require to go through all JNI local refs used in the project, we can at least fix the most frequent issues:

when using the custom Duktape Data parser (e.g.:  for (var i = 0; i < 1000; ++i) { new Date(i).toString(); })
when pushing large object arrays

Fixes #120


Inconsistent error message on Duplicate Detection while using ExecuteWebRequest

Hello!
We've ran into and inconsistency when it comes to error messages returned by ExecuteWebRequest, especially in the case of the request failing because of Duplicate detection via Alternate Key.
Here's an example of fail message using .Create()

Here's an example of the same request using .ExecuteWebRequest()

One thing to note is that this request actually falls into the Exception ex instead of HttpOperationException httpex branch.
I suspect the issue is here:
https://github.com/microsoft/PowerPlatform-DataverseServiceClient/blob/d78a53d4afbe72e924f09ddfda2a848d6528f0e3/src/GeneralTools/DataverseClient/Client/ConnectionService.cs#L2628
Using Fiddler to see the request that's being send, we can actually see that the request actually returns the correct error message

.. but the abstraction above works with LastError which is of type Exception, which is the reason we lose HttpOperationException.Response which is why we lose the metadata of the actual error.
Thank you.

@MattB-msft Any news on this issue? It's holding us back a bit.


Fully document Python API

I'm currently using the Python API to create a viewer state that I can easily convert to a URL - very handy, but I'm finding it very hard to understand what I can do with the various classes and properties. It would be very helpful if there was comprehensive API reference docs explaining what classes are available, and what properties they have.

It isn't comprehensive but there is now https://neuroglancer-docs.web.app


Readme section for undo/redo, proposed addToHistory command

Adds a readme section on undos
Proposes a way to prevent some changes from being undone per discussion in https://github.com/yjs/y-prosemirror/issues/110

The proposed API mirrors prosemirror-history, for more info see https://github.com/ProseMirror/prosemirror-history/blob/master/src/history.js#L380

Thanks :+1:
I implemented the API and will release it in a bit.

Hey @dmonad , thanks so much for pushing this change. I've been testing it locally though and I'm still not seeing the intended behavior. It looks like when ProseMirror sends multiple transactions in a row, y-prosemirror is batching them together and only checking this meta key for the last one. This means that the whole batch is still actually getting captured.

Is there any way to prevent this?

I think this is fixed in v1.1.1, can you please verify?

Hey @dmonad unfortunately not. I think the issue remains that when multiple prosemirror transactions happen in short sequence, and Yjs batches them together into its own transaction, only the last prosemirror transaction's addToHistory value is used:

I haven't tested this code, but I suspect a solution would look something like:

@thatsjonsense I think the next release should fix this issue.

If not, please write a test case so I can reproduce it better.


Entering through Fire Exit pushes me outside of the map

Hi,
Love the new interior.  Only issue i've had is entering through fire exit pushes me to the side of the door that's outside of the map.
Thanks for all the great content

tried .0.0.2.  this version makes my game crash most of the time

i'll fix it when i have time


NPM involment

I know we are also focused on Node core involvement, but we should possibly also take a look at npm and its issues. https://github.com/npm/npm/issues
considering this is "the" way to interact with node modules.
My tweet asking npmjs were to start:  https://twitter.com/sienaluke/status/758330112047779840
This was also a good primer on npm and some of its usage, https://youtu.be/hopWbVKmiVQ?list=PLfMzBWSH11xZWvE3iuTw6tdzp90gnODdp

Currently have an open PR for an issue regarding docs for the npm-init interviewer,
https://github.com/npm/npm/issues/13005

@lholmquist
npm/npm

Commits

Comments

Open PRs

Closed PRs

npm/docs

Commits

Comments

Open PRs

Closed PRs

Link to the commit from the PR i had for this issue, https://github.com/npm/npm/commit/bf3bd1e4347ee2c5de08d23558c4444749178c8b

The docs update PR that is above, is now merged and scheduled for the next release!

@helio-frota
npm/npm

Commits
Comments
Open PRs
Closed PRs

npm/nopt

Commits
Comments
Open PRs
Closed PRs

npm/fs-vacuum

Commits
Comments
Open PRs
Closed PRs

Closing - out of date


Fix links to quickstart and api reference

Thanks Toby. I was beginning to wonder when I saw them other places as well.
On Fri, 13 Dec 2019, 19:14 Toby Kurien<EMAIL_ADDRESS>wrote:

@tobykurien commented on this pull request.
Thanks Hans! The reason for the weird links is that these docs are
rendered on the browser if you check out and run the project, and view the
docs there. I will look into makng it play nice on github too, perviously
using a regex caused other problems.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/IBM/browser-functions/pull/7?email_source=notifications&email_token=AAA2BL7DL2JFISV4TZE3DJLQYO7HTA5CNFSM4J2MOBHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPE6B6Q#pullrequestreview-331997434,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA2BLY67Q2G6FSV7IMGIJ3QYO7HTANCNFSM4J2MOBHA
.

Fixed in https://github.com/IBM/browser-functions/commit/f7c5365f5efbedf888b101f1320524bf0836cd86


[Add Package] AboutThisApp

Adds https://github.com/hexedbits/AboutThisApp to the directory

Thanks!


WIP: Add linkout to source's interaction claim pages

Closes #304
I checked on some of the other online updaters but I couldn't find any source pages there that we could link out to (most times the interactions are just in a table on a gene/drug page instead of having individual pages).
Side note: With the API rate limiting of CIViC we will almost certainly run into problems with the CIViC importer. I'll make a separate issue to address that.

For other sources we should link to e.g. the page that has the table we import (so the link would be the same for all interaction claims from that source).

For the following sources I was unable to identify where the linkout should point to:

[ ] Cancer Commons
[ ] Clearity Foundation Biomarker
[ ] Clearity Foundation Clinical Trial
[ ] DoCM
[ ] Guide To Pharmacology Interactions

For the importers/updaters I was able to update, I would also appreciate a closer look at the linkout URLs used to confirm that they are correct.

Cancer Commons: the site has changed quite a bit since the 2013 dataset we downloaded. I think we should just link out to the .tsv we collected this data from.
Clearity Foundation Biomarker: same as above. If we have the .tsv, we should point to it.
Clearity Foundation Clinical Trial: same as above.
DoCM: just the homepage
Guide to Pharmacology Interactions: link to the ligand page for the interaction. If we have the ligand id as an attribute for the corresponding interaction claim, we can link directly to the ligand page, e.g. for PAZOPANIB (id 5698):
https://www.guidetopharmacology.org/GRAC/LigandDisplayForward?ligandId=5698
Otherwise, we can hijack the search URL with the drug name:
https://www.guidetopharmacology.org/GRAC/LigandTextSearchForward?searchString=PAZOPANIB&searchCategories=all&order=rank&submitName=Search+the+database

For Cancer Commons and the two Clarity Foundation ones, we do have the TSVs in the data subrepo but that's not really publicly accessible, right? I haven't been able to find the originals on the sources' websites.

This PR is ready for final review.


add fancyhdr compatibility

Lists fancyhdr as "compatible" and adds a test. My assumption is headers and footers should not be tagged and that's what happens here.

With rules being often the case in improper tagging, I think we should verify that this is ok with the rules potentially added by fancyhdr, quite likely they are but ...


Convert to Array

How do I convert array created to a JS Array?
thanks.

See NdArray#tolist() method

It's not in the documentation at http://nicolaspanel.github.io/numjs/global.html . Is the page generated by a tool or manually? If manually, maybe add that to the repo so we can contribute to it.

See it on the NdArray page. That link was on obvious on the global.html, so added it to README in pull #36


Issue template & pull request template

Description
Create issue & pull request template so I can structure them once I create them
Why
I want these because I always try to give some structure to these... I want this structure pls

PR template is done here: https://github.com/isabelcosta/isabelcosta.github.io/commit/fcc5f8d364ec9603db6958fd8c5c68175e2ba94c

issue template added here 13f4324c558396131b14e9137dc1d9c233f2bcf5


Java gRPC client for Armada

Is your feature request related to a problem? Please describe.
There is a need to support Jenkins Agents as Armada jobs. To do so Armada Jenkins plugin will be created. Since Jenkins is written in Java it is only natural to have Java client for Armada.

Describe the solution you'd like
Autogenerated Java sources from Armada API .proto files.
Unit and integration tests.

Describe alternatives you've considered

Additional context

this is the repo of java grpc client for armada https://github.com/mladjan-gadzic/armada-grpc-java-client
todo:

add tests
include java grpc client for armada in armada clients


Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits)

git@github.com:flutter/engine.git/compare/31cd2dfca22a...63e8c6275e4e
git log 31cd2dfca22a..63e8c6275e4e --no-merges --oneline
2019-11-12<EMAIL_ADDRESS>Add ImageFilter and BackdropFilter to CanvasKit backend (flutter/engine#13768)
2019-11-12<EMAIL_ADDRESS>Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13759)" (flutter/engine#13788)
2019-11-12<EMAIL_ADDRESS>Add Helvetica and sans-serif as fallback font families (flutter/engine#13784)
2019-11-12<EMAIL_ADDRESS>Roll src/third_party/skia 0fd4f01b9b83..3de645cbca78 (1 commits) (flutter/engine#13776)
2019-11-12<EMAIL_ADDRESS>Add line boundary information to LineMetrics. (flutter/engine#13727)
2019-11-11<EMAIL_ADDRESS>Fix RendererContextSwitch result check in Rasterizer::MakeRasterSnapshot (flutter/engine#13785)
2019-11-11<EMAIL_ADDRESS>[web] Fix path to svg for drrect (flutter/engine#13779)
2019-11-11<EMAIL_ADDRESS>Roll src/third_party/dart d45c3d15cb..7408ed4730 (20 commits) (flutter/engine#13778)
2019-11-11<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from RrTFI... to TnTbF... (flutter/engine#13775)
2019-11-10<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from 4JJNo... to RrTFI... (flutter/engine#13774)
2019-11-10<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from xC_an... to 4JJNo... (flutter/engine#13773)
2019-11-09<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from eq_Rz... to xC_an... (flutter/engine#13771)
2019-11-09<EMAIL_ADDRESS>Roll src/third_party/skia 4135cf0b57c2..0fd4f01b9b83 (1 commits) (flutter/engine#13770)
2019-11-09<EMAIL_ADDRESS>Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13759)
2019-11-09<EMAIL_ADDRESS>Point old plugin registry accessors to new embedding plugin accessors.  (#44225) (flutter/engine#13739)
2019-11-09<EMAIL_ADDRESS>Revert "[fuchsia] Temporarily disable intl provider (#13696)" (flutter/engine#13721)
2019-11-09<EMAIL_ADDRESS>Turn on RasterCache based on view hierarchy (flutter/engine#13762)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6638885173460992

Commit queue failed; closing this roll.


fix(io): add epoch-settings api and tests

Codecov Report
Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 51.23%. Comparing base (0333c1b) to head (56555ea).

Files
Patch %
Lines

src/common/io.ts
0.00%
9 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha     #143      +/-   ##
==========================================
- Coverage   51.66%   51.23%   -0.43%
==========================================
  Files          29       29
  Lines        1084     1093       +9
  Branches      209      211       +2
==========================================
  Hits          560      560
- Misses        505      514       +9
  Partials       19       19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:tada: This PR is included in version 1.2.0-alpha.20 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Rust seems to be making more stat64 calls on MacOS than is necessary

MacOS appears to be making more stat64 syscalls than is strictly necessary.  My understanding is that uutils 'ls' relies upon std::fs::metadata to make metadata requests which in turn relies upon this crate to make its raw syscalls, but I know this request may be better addressed to the stdlib folks or someone else.  So I am pleased to take it elsewhere if needed.
An API reference:

https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/stat.2.html
https://opensource.apple.com/source/xnu/xnu-3789.41.3/bsd/vfs/vfs_syscalls.c

This is uutils 'ls' master running on MacOS benched against to GNU 'ls' on APFS:
hyperfine -w 3 -i "./ls --color=never -laRL ../" "gls --color=never -laRL ../"
Benchmark 1: ./ls --color=never -laRL ../
  Time (mean ± σ):     292.6 ms ±   6.3 ms    [User: 217.9 ms, System: 70.5 ms]
  Range (min … max):   284.9 ms … 300.7 ms    10 runs

  Warning: Ignoring non-zero exit code.

Benchmark 2: gls --color=never -laRL ../
  Time (mean ± σ):     170.6 ms ±   2.8 ms    [User: 72.0 ms, System: 94.4 ms]
  Range (min … max):   167.1 ms … 178.2 ms    17 runs

  Warning: Ignoring non-zero exit code.

Summary
  'gls --color=never -laRL ../' ran
    1.71 ± 0.05 times faster than './ls --color=never -laRL ../'

As compared to Linux in a container on ZFS:
hyperfine -w 3 -i "./ls --color=never -laRL ../" "ls --color=never -laRL ../"
Benchmark 1: ./ls --color=never -laRL ../
  Time (mean ± σ):     433.9 ms ±   1.7 ms    [User: 229.1 ms, System: 203.2 ms]
  Range (min … max):   430.8 ms … 436.0 ms    10 runs

  Warning: Ignoring non-zero exit code.

Benchmark 2: ls --color=never -laRL ../
  Time (mean ± σ):     503.1 ms ±   4.8 ms    [User: 149.3 ms, System: 352.0 ms]
  Range (min … max):   493.4 ms … 510.9 ms    10 runs

  Warning: Ignoring non-zero exit code.

Summary
  './ls --color=never -laRL ../' ran
    1.16 ± 0.01 times faster than 'ls --color=never -laRL ../'

So the question is -- why is same code slower on the Mac?  GNU 'ls' appears to be making a different syscall and fewer of them, whereas the number of stat syscalls on Linux is the same for both GNU and uutils 'ls'.  From dtrace on the Mac, uutils 'ls':
 CALL                                        COUNT
__mac_syscall                                   1
bsdthread_register                              1
csops                                           1
csrctl                                          1
fgetattrlist                                    1
getattrlist                                     1
getpid                                          1
getrlimit                                       1
openat                                          1
close                                           2
csops_audittoken                                2
open                                            2
shm_open                                        2
sigaltstack                                     2
sysctl                                          2
sysctlbyname                                    2
access                                          3
getentropy                                      3
proc_info                                       3
fcntl                                           4
ioctl                                           4
mmap                                            4
read_nocancel                                   4
madvise                                         5
sigaction                                       5
fstat64                                         6
issetugid                                       7
mprotect                                       22
write                                          23
fstatfs64                                     236
getdirentries64                               237
close_nocancel                                241
open_nocancel                                 241
stat64                                       1643

Compared to GNU ls:
CALL                                        COUNT
__mac_syscall                                   1
bsdthread_register                              1
csrctl                                          1
fcntl                                           1
fgetattrlist                                    1
getattrlist                                     1
getgid                                          1
getpid                                          1
getrlimit                                       1
openat                                          1
close                                           2
csops                                           2
csops_audittoken                                2
fcntl_nocancel                                  2
getentropy                                      2
gettid                                          2
getuid                                          2
lseek                                           2
mmap                                            2
shm_open                                        2
sysctl                                          2
sysctlbyname                                    2
access                                          3
getegid                                         3
ioctl                                           3
madvise                                         3
proc_info                                       3
geteuid                                         4
issetugid                                       5
open                                           14
read_nocancel                                  15
mprotect                                       20
fstatfs64                                      50
sigaltstack                                    50
sigprocmask                                    50
getdirentries64                                51
close_nocancel                                 58
open_nocancel                                  59
fstat64                                        62
stat64_extended                               592
stat64                                        593
write_nocancel                                736

Thanks.  Appreciate your attention to this and any help you can provide.

The more I learn about this, the more this seems that my issue is possibly an API request?  If stat64_extended is similar to statx on Linux?

libc just defines these functions; it doesn't control how they get called. You should report this issue on the rust-lang/rust repository.


⚠ Jellyfin has degraded performance

In 83f0778, Jellyfin (https://jellyfin.underthere.xyz) experienced degraded performance:

HTTP code: 502
Response time: 3198 ms

Resolved: Jellyfin performance has improved in 32eb0c4 after 1 minute.


Do not require password and url when compileonly

When trying to use --compile-only, mark complained about missing password and URL. So this PR will set a password of "none" and a URL of "http://localhost" if they are not given but --compile-only was requested.

Is this actually correct thing to do when there is --compile-only flag specified? It feels like the program should not check password/url when it is running in "compile only" mode.

When in --compile-only it currently does check and I didn't want to mess too much with the code. So in case no url or password is given, and only then, I set the defaults.

Thanks


Updating System?

Hello!
Do you plan to update this system to last Foundry VTT version?
Because now it's showing "Compatibility Risk" badge ;(

Hi,
A new update is not planned in the near future. But afaik this system is
still completely compatible.
But your question got me thinking I should just update the version, so that
it shows it is compatible. I'll look into this.
Thanks.
Menno
On Mon, Apr 26, 2021 at 7:46 AM Const @.***> wrote:

Hello!
Do you plan to update this system to last Foundry VTT version?
Because now it's showing "Compatibility Risk" badge ;(
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mvdleden/electric-bastionland-FoundryVTT/issues/1,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGDA4EDVLBOXDKARXQSLEX3TKT43HANCNFSM43SESRFA
.

Hi,
Just to let you know. I created a new version that is compatible with the upcoming 0.8.5 release.

thx


Retry if Cloudwatch Log Insights quota reached.

We are using some graphs with cloudwatch insights logs datasources in our dashboards. Many times we hit the default quota of 4 parallel Insight queries, which leads to broken graphs.
This queries can be easy retried, but the AWS SDK don't do this yet out of the box:
https://github.com/aws/aws-sdk-go/issues/3252
Because of this, the PR contains a local configuration which extends the default AWS SDK retry implementation, to fix the issue.
The used extension point in the AWS SDK is not available in the currently used version,  therefore a AW SDK version update is included in this PR as well.

Thanks for contribution!


resize function that can backpropagate gradient

Dear clean-fid group,
Thank you for sharing this great work, I really like it.
You mention in the paper that the PIL implementation is anti alias. But the PIL library could not back backpropagate gradient. Do you have plan to implement a way resize function that support anti alias and backpropagation? Or could you inform me the right way to do this?
I believe this will be very usefull for the community. For example, we invert a real image to the latent space of GAN, usually we dont use the full resolution image. The generated image must downsampling then compare to real image (LPIPS), and then backpropagate gradient. This is the implementation in Stylegan-ada (https://github.com/NVlabs/stylegan2-ada-pytorch/blob/main/projector.py#L97), it uses the torch resize function which could not anti alias as you mentioned in the paper.
Thank you for your help.
Best Wishes,
Alex

If I understand correctly, I need to blur the image first. The codes are not very easy from PIL (https://pillow.readthedocs.io/en/stable/_modules/PIL/Image.html#Image.resize).

We have not implemented resizing which can propagate gradient in this repository.
There are some related libraries that might be of interest ResizeRight, kornia.
Although we have not fully evaluated these for computing FID.


Updating wrong control code

Signed-off-by: Mary Anthony<EMAIL_ADDRESS>

Typing exit also works. However, there's this PR: https://github.com/docker/docker/pull/18546 that is working on this, and a different proposal. Let me know if you're in a hurry getting this in, or if we work on the other PR

@thaJeztah No hurry.  It can wait.

I feel like there is still a couple different PRs floating about with conflicting changes.  Carry? :-(

I'll close this one, if needed, we can carry the other PR


PHP Snippets are slow (Mac), since the last March update

I have even removed all extensions, and also just disabling extension one after another,  however after a "reload" it is fast,  but that only lasts a minute or so.  The snippet can take up to infinity sometimes it seems. I get tired of waiting.
I have rolled back to the February release which does not seem to have any problem at all.

Please use this guide to provide more information: https://github.com/Microsoft/vscode/wiki/Performance-Issues. Thanks.

Buddy I'll try,  I don't have that much time at the moment but I will try. I have never done those things so i'l have to follow the instructions.
There seem to be lots of bug posts recently about slowness and maybe it's all connected I don't know.
Since I rolled back I'll have to roll back forward again, but I'm in the middle of some development that has to get done.   But I will try asap but it might take me a day or so,
if you want to mark or delete the submitted bug that is cool,
As long as you are aware that I really think something has changed since last release.    BTW I also run multiple instances .. up to 5 at a time.
But as I stated .. February release does not have this issue at all.  I have been using it for the last 3 hours and the snippets are lightning fast.

On May 16, 2019, at 3:00 PM, Johannes Rieken<EMAIL_ADDRESS>wrote:
Please use this guide to provide more information: https://github.com/Microsoft/vscode/wiki/Performance-Issues https://github.com/Microsoft/vscode/wiki/Performance-Issues. Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode/issues/73831?email_source=notifications&email_token=ACV3T4LKG6HIXE6SI5KC25DPVW4PLA5CNFSM4HNOXRD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVS4Y7Q#issuecomment-493210750, or mute the thread https://github.com/notifications/unsubscribe-auth/ACV3T4LWCKYTJVMFZE6SR3LPVW4PLANCNFSM4HNOXRDQ.

K - closing as duplicate in that case


could you share the code of random transformer mentioned in the paper

really interested about the implemention of it

Thanks for your feedback. To use random_transformer, you can pass transformer_random as an argument to --model. This will automatically set the trainable argument of the transformer to False in the initialize_model function.

Thanks for rapdly relpy. Also, I wanna consult that if all the parameters in attention layer are frozen when use random_transformer since self.attention_layer.trainable = trainable (which is false in random_transformer) in the code I found.


MSVC Error C2220: p hides prev. local declaration

MSVC build output (with /W4 and TreatWarningsAsErrors=Yes)
2>http_parser.c
2>c:\dev\...\http_parser\http_parser.c(2389,18): error C2220:  warning treated as error - no 'object' file generated
2>c:\dev\...\http_parser\http_parser.c(2389,18): error C2220:     const char* p;
2>c:\dev\...\http_parser\http_parser.c(2389,18): error C2220:                  ^
2>c:\dev\...\http_parser\http_parser.c(2389,18): warning C4456:  declaration of 'p' hides previous local declaration
2>c:\dev\...\http_parser\http_parser.c(2389,18): warning C4456:     const char* p;
2>c:\dev\...\http_parser\http_parser.c(2389,18): warning C4456:                  ^
2>c:\dev\...\http_parser\http_parser.c(2302,15): message :  see declaration of 'p'
2>c:\dev\...\http_parser\http_parser.c(2302,15): message :   const char *p;
2>c:\dev\...\http_parser\http_parser.c(2302,15): message :

(Line numbers don't match with current master since I've noticed the build-error when using 2.8.1)
To fix this build-error I removed const char* p;-declaration as it is already declared right at
http_parser_parse_url(const char *buf, size_t buflen, int is_connect,
                      struct http_parser_url *u)
{
  enum state s;
  const char *p; // <-----

Since the removed const char* p within the if-statement is first used in line 2420 for (p= buf + off where it gets immediately assigned a new value, the removal should be completely harmless.

Would be great to have this merged. I ran into the same problem using gcc with -Wshadow.


Feature: Curve25519 support

This pull request introduces support for encryption/decryption with cv25519 keys. Encrypt+sign is also possible with ed25519+cv25519 keys. tweetnacl's scalarMult function is used for encryption, and tweetnacl's sign is used for signing - this functionality should probably by exposed in keybase-nacl, so it could be used instead of directly calling into tweetnacl.
There is also key generation included for cv25519, but it is not tested. EDDSA key generation is still missing, but I plan to work on it as well. Encryption/signatures were tested by exchanging various payloads between gpg2 (gpg (GnuPG) 2.1.15, libgcrypt 1.7.3) and KBPGP. There is also test file tests/cv25519.iced that does exactly that, but in unit testing fashion.
Code details:
There is now a Curve25519 class that extends Curve. It reads points in 0x40 format which encodes just X coordinate (regular Curve class expects format 0x4 and X, Y coordinates). The curve point here is just a Buffer - we do not deal with BigNumbers for points and scalars, it's all just buffers for us that we pass to tweetnacl. Because of that, the point operations were moved into the curve classes. ECDH can no longer, for example, do the encryption by getting G point from the curve and multiply it by scalar v - now it calls curve.encrypt instead, which for Curve is implemented using point multiplication, but for Curve25519 it calls tweetnacl.scalarMult
Why not create a separate ECDH key classes, like ECDH25519 and have the scalarMults there, and leave Curve and ECDH alone? The issue is that cv25519 is the same public key algorithm type (ECDH = 18), and the 25519 only has its own curve OID. So to separate ECDH classes we would have to make either Parser.parse_public_key_mpis more complicated, or somewhere in ECDH key parsing suddenly return 25519 variants of the classes, which ruins the abstraction a little bit (calling Pair.parse should return instances of that Pair, not something different).
Let me know if it should be architected differently - the change itself is not very big, so I might as well apply it in a different way. Most of the work was figuring out how to make nacl pretend it's pgp.
Known issues:

Curve.encrypt/decrypt method names are misleading, figure out better naming.
Some code duplication, e.g. in Curve25519.mpi_from_buffer, (eddsa) Pair.pad_and_sign.

Related issues: #92 https://github.com/keybase/keybase-issues/issues/1738 https://github.com/keybase/keybase-issues/issues/2213

This looks great overall --- the one request I had would be to try to abstract multiplication in Curve25519 so that it can be done natively if there's a compiled version of sodium around.  I believe the function crypto_scalarmult_curve25519 should do the trick, and wrappers can be introduced in keybase-nacl to expose scalar multiplication. What do you think?

OK, I'll look into keybase-nacl and try to export needed functions there. Thank you for going through my code :)

I made EDDSA Priv key use keybase-nacl - everything was already there, I just didn't look hard enough before. I'll work on scalarmult now.

Tell me if I understand this correctly - when I have keybase-nacl installed and built (I've witnessed it building sodium), and running make test-server in kbpgp, it should be using the compiled sodium. When I run make test-browser and run the script in browser, it will be running TweetNaCl.
So theoretically, doing both (test-server, and then using the browser script) tests should test both crypto code paths there?
I wonder if CI can somehow run different browsers and test there.

Yes you are correct and also that there isn't a good way to test this
automatically, yet....
On Tuesday, November 1, 2016, Michał Zochniak<EMAIL_ADDRESS>wrote:

Tell me if I understand this correctly - when I have keybase-nacl
installed and built (I've witnessed it building sodium), and running make
test-server in kbpgp, it should be using the compiled sodium. When I run make
test-browser and run the script in browser, it will be running TweetNaCl.
So theoretically, doing both (test-server, and then using the browser
script) tests should test both crypto code paths there?
I wonder if CI can somehow run different browsers and test there.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/keybase/kbpgp/pull/121#issuecomment-257539079, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA05_9WtJYonZZcs2v6gm10X3HIJYlg1ks5q5xsYgaJpZM4KiROr
.

Looks like sodium is not built when just npm install kbpgp is done. Is this by design?
(env) zapu@weakfox ~/sodium_test » npm install kbpgp                                                                                12:14:41
/home/zapu/sodium_test
└─┬<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ ├──<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>
npm WARN enoent ENOENT: no such file or directory, open '/home/zapu/sodium_test/package.json'
npm WARN sodium_test No description
npm WARN sodium_test No repository field.
npm WARN sodium_test No README data
npm WARN sodium_test No license field.
(env) zapu@weakfox ~/sodium_test » ls                                                                                12:14:48
total 8,2k
drwxrwxr-x  8 zapu zapu 4,1k lis  1 12:14 env/
drwxrwxr-x 19 zapu zapu 4,1k lis  1 12:14 node_modules/
(env) zapu@weakfox ~/sodium_test » node                                                                                12:14:50
> require('keybase-nacl')
{ sign:
   { publicKeyLength: 32,
     secretKeyLength: 64,
     signatureLength: 64,
     seedLength: 32 },
  alloc: [Function] }
> require('keybase-nacl').alloc({})
TweetNaCl { ...

(with sodium built alloc returns Sodium object)

Yes this is by design. It has a lot of dependencies (like libtool) and
won't run via browserify.  But if you have it installed in your system it
will be picked up.
On Tuesday, November 1, 2016, Michał Zochniak<EMAIL_ADDRESS>wrote:

Looks like sodium is not built when just npm install kbpgp is done. Is
this by design?
(env) zapu@weakfox ~/sodium_test » npm install kbpgp                                                                                12:14:41
/home/zapu/sodium_test
└─┬<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>npm WARN enoent ENOENT: no such file or directory, open '/home/zapu/sodium_test/package.json'
npm WARN sodium_test No description
npm WARN sodium_test No repository field.
npm WARN sodium_test No README data
npm WARN sodium_test No license field.
(env) zapu@weakfox ~/sodium_test » ls                                                                                12:14:48
total 8,2k
drwxrwxr-x  8 zapu zapu 4,1k lis  1 12:14 env/
drwxrwxr-x 19 zapu zapu 4,1k lis  1 12:14 node_modules/
(env) zapu@weakfox ~/sodium_test » node                                                                                12:14:50

require('keybase-nacl')
{ sign:
{ publicKeyLength: 32,
secretKeyLength: 64,
signatureLength: 64,
seedLength: 32 },
alloc: [Function] }
require('keybase-nacl').alloc({})
TweetNaCl { ...

(with sodium built alloc returns Sodium object)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/keybase/kbpgp/pull/121#issuecomment-257542541, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA05_1shlqAUQmg2nz77XHgShSHWoVqAks5q5x_jgaJpZM4KiROr
.

I see, thank you. Just trying making sure I'm actually running the code that I'm changing there.
I have the keybase-nacl and ecdh changes almost ready, I'll probably finish it and make the commits later in the day or tomorrow.

Still passes CI even though the test fails with In reading /home/travis/build/keybase/kbpgp/test/files/cv25519.iced: TypeError: nacl.scalarmult is not a function. I'm going to fix that.

Ok, I just pushed<EMAIL_ADDRESS>to NPM

Looks like a bug in iced-test - when an exception occurs in unit test code, it propagates back to somewhere (didn't check exactly) and ends the script normally, instead of triggering an error. This line: https://github.com/maxtaco/iced-test/blob/master/index.iced#L144 should be in try-catch block. Should I make a fix?

Hmm, but the problem if that test is awaited, and the exception happens after the await, then the try-catch won't work.

If an exception happens after await, then it's an uncaught exception and this ends the node process with an error. But this does not seem to be the case in this log https://travis-ci.org/keybase/kbpgp/jobs/172594752
However, I could confirm the iced-test problem by adding some intentional error in one of the sync tests. When an exception happens in test, it propagates back to https://github.com/maxtaco/iced-test/blob/master/index.iced#L218 and it does not mark the failure.
Looks like this is what happened in the CI as well, you can see the "In reading" string there (In reading /home/travis/build/keybase/kbpgp/test/files/cv25519.iced: TypeError: nacl.scalarmult is not a function). So somehow the decryption code runs all in one node tick, at least until the nacl call?

ah ok.  i wonder why the test process doesn't exit with status 1 if it crashes. let me look into that.

Sorry, I was wrong about the iced-test after all - the exception will trigger
✖ Failure due to test configuration issues
Tests: 233/234 passed
Makefile:94: recipe for target 'test-server' failed

at the end of testing, but it will skip entire file if a sync exception happens in one of the tests.

Also, could you try to refresh the build in CI? There should be a "Restart build" button on the right, if you are have rights to the repo. Thanks

Let me fix iced-test

Tell me if I'm wrong, but I don't see a way to currently generate cv25519 ECDH keys from the API. From what I've seen, the only way to specify the curve is by passing number of bits to generate. How should we approach this?

I think you're right, but check out generate_ecc, it calls into generate with suitable parameters.  I'm pretty sure this pattern will work here.

Still working on this. I've improved EDDSA, added key generation and serialization routines there. Key generation seems to work, with something like
primary = {
    flags: C.sign_data | C.certify_keys
    algo: kbpgp.ecc.EDDSA
}
subkeys = [{
    flags: C.encrypt_storage | C.encrypt_conn
    algo: kbpgp.ecc.ECDH
}]

await KeyManager.generate { userid: "Mr Robot", primary, subkeys }, defer err, alice

but the KeyManager is not able to encrypt and sign the message, because for some reason it chooses to use subkey for signing (or so I think: fails with TypeError: _this.key.pad_and_sign is not a function   at /home/zapu/pgp/kbpgp/lib/openpgp/packet/signature.js:278:21).
I also tested cv25519 a bit more with a script that would:

Use gpg2 to generate Ed25519/Curve25519 keys.
Export the secret keys and import in kbpgp.
Encrypt and sign a message (it signs just fine with keys from gpg2).
Give the armored cipher to gpg2 to decrypt.
Decrypt with kbpgp for more verification.

And I've ran it a number of times and it looks like it's working.

Hmm... Looks like I could have just looked at nacl/eddsa.iced to see how to implement private key. Why there are two EDDSA implementations? Should I have not implemented the nacl eddsa stuff in ecc/eddsa.iced ?

Great work as always. A few things. With these parameters:
subkeys = [{
    flags: C.encrypt_storage | C.encrypt_conn
    algo: kbpgp.ecc.ECDH
}]

You're likely getting the NIST curves.  I'm guessing you wanted Curve25519, so likely something else has to be done here.
As to the two implementations, what's in nacl/eddsa.iced and nacl/dh.iced is for "Keybase-style" signatures, which are entirely separate from GPG-style.  Keybase-style signatures are base64-encodings of msgpack structures.

Yes, I was getting the default p384 curve (I think - I don't have this open right now). What was weird, though, is that setting flags param to 0 was making something else confused, and kbpgp was trying to encrypt using the primary key (which was EDDSA), instead of the subkey. Calling generate with incorrect flags should fail (or should it?), but the manner in which it did was not obvious. I still haven't debugged this behavior, maybe I'm missing something and it's entirely something else.
I also started working on something that would allow people to use curve name instead of nbits, similarly to what gnupg allows in batch mode (e.g. Subkey-Curve: Curve25519 in gpg2). I'll commit it once it's finished and we will see if it fits into KBPGP, because it would expand the API.

You're right it might very well be garbage-in, garbage-out.
Do you want to add these features and bugfixes in another PR and get this one merged?

Let me finish the curves and eddsa changes I'm doing and do tests for them and then we will see. Thanks!

ok great, thanks
On Mon, Nov 7, 2016 at 1:19 PM, Michał Zochniak<EMAIL_ADDRESS>wrote:

Let me finish the curves and eddsa changes I'm doing and do tests for them
and then we will see. Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/keybase/kbpgp/pull/121#issuecomment-258917234, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA05__6QYWaQKZaTHKFmehtOlY1d5CaMks5q72vKgaJpZM4KiROr
.

Looks like the test fails because make does not build src/ecc/eddsa.iced and I haven't committed eddsa.js.

Let me know if generating keys with curve_name looks fine, I was trying to mimic gnupg a bit, but maybe there is a better solution.

Looks great to me, thanks for the great work here.
What would you like to do about the test.  Do you want me to merge your branch into a branch of mine, and then fix the tests?

I'm not sure what I did wrong there. When you look into the build log, it does not recompile the eddsa.iced or curves.iced.
...
node_modules/.bin/iced -I browserify -c -o `dirname lib/dsa.js` src/dsa.iced
node_modules/.bin/iced -I browserify -c -o `dirname lib/ecc/ecdsa.js` src/ecc/ecdsa.iced
node_modules/.bin/iced -I browserify -c -o `dirname lib/ecc/main.js` src/ecc/main.iced
node_modules/.bin/iced -I browserify -c -o `dirname lib/elgamal.js` src/elgamal.iced
...

Do all files pulled by git end up with the same date of modification, and that's why Makefile would skip some of them?

I was able to get it to build with touch src/ecc/eddsa.iced && make

Oh, it builds and passes the tests for me just fine, it's just a bit not deterministic on the CI side.
Or am I doing it wrong by not committing compiled files with every commit?

I would commit the built files too

OK - I'm a fan of small commits when working on a feature branch and only committing built assets on release, but it's not a problem to commit every time. Thanks!

Thank you @zapu, job well done!

Thank you for the merge :)
So, there is one issue relating to flags with key generation, should I look into that?

What was that issue?

As described in the issue https://github.com/keybase/kbpgp/pull/121#issuecomment-258877045 - basically, passing flags: 0 to key generation will create a weird KeyManager which (in my case) tried to encrypt using primary key which was for signing only.

Ah, ok, thanks for reminding me.  Sure it makes sense to handle that bad input better...


185452243 Sparrow Infrastructure

PT Story: https://www.pivotaltracker.com/story/show/185452243
This PR lays the groundwork for student proportional arrows (sparrows), and potentially other annotations in the future. It is not a complete implementation, and many features remain undeveloped. That said, there is enough developed to allow users to create and view arrows with text annotations that connect objects in drawing tiles, including between different tiles.
Please use the example unit to test this work.
Features implemented in this PR:

Adds two new document toolbar buttons.

The sparrow button allows the user to add new sparrows by clicking on two different objects (currently just in drawing tiles) to connect them with a sparrow, or to modify the text associated with an existing sparrow.
The hide adornment button allows the user to hide or view sparrows.

A new DocumentContentModelWithAnnotations model has been added to DocumentContentModel which includes annotations (currently just sparrows).
Adds new models for ArrowAnnotations and ClueObjectModel. A ClueObjectModel represents an arbitrary object in any clue tile, and is defined by a tileId, an objectId, and optionally an objectType. It's up to individual tiles to interpret the objectId and objectType.
Adds the annotatableObjects view to the tile content model, which allows tiles to specify which of their objects can be annotated. This is currently only implemented for the drawing tile.
Adds getObjectBoundingBox to the ITileApi, which allows tiles to specify where their objects are located. This is currently only implemented for the drawing tile but will be expanded in the near future. This information is required for objects to be annotated.
Adds the AnnotationLayer to the Canvas. This component covers the whole document and is in charge of displaying and allowing the user to modify sparrows and other annotations. It determines where objects are located using a combination of getObjectBoundingBox, looking at the dom to determine where the canvas and tiles are, and accommodating document and tile scroll (tile scroll has not yet been tested).
Adds the ArrowAnnotationComponent, which renders a sparrow to the AnnotationLayer.

Currently, the arrows are straight lines between the centers of objects, but they will be curved with the end positions controllable in the future.
The text annotation is displayed in the center of the arrow and can be modified via a text input by clicking on the text while in sparrow editing mode.

Features not yet implemented and potential bugs:

Handle hiding objects based on tile size, plus tile and document scroll.
Make sure the AnnotationLayer svg for displaying annotations is an acceptable size.
Correctly handle scaled canvases.
There's currently no way to delete sparrows. Should there be?
Sparrows with an object that can't be found (like if it's deleted) are currently not rendered but not deleted. Should they be deleted?
Make sure annotations render properly in read only mode on the left side.
Include annotations in exported json. This should be straight forward for document level json, but how should individual tile json incorporate annotations?
Make sure annotations can be included and rendered in curriculum.
Include annotations when copying tiles from one document to another and duplicating tiles (do we want to copy annotations in the latter case?).

I think the above features and potential bugs should all be pushed off into other PRs, but please let me know if you think any of them are essential for this initial implementation.

Interesting article about anchoring: https://developer.chrome.com/blog/tether-elements-to-each-other-with-css-anchor-positioning/

For what it's worth, my initial implementation did use the DOM to access object location. This is why there are a bunch of drawing files with trivial indentation changes in this PR--there were slightly more substantial changes before. I guess there are two factors in deciding how to approach this. The first is performance, and it sounds like you think using elements would be more efficient. The other is how easy it will be to access the information from different tiles. I'm not sure which would be easier, and maybe it will be different for different tiles. What are your thoughts on this after looking into it a bit today?


chore(master): release 2.6.0

:robot: I have created a release beep boop
2.6.0 (2023-05-18)
Features

added development documentation (db7170f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/dworac/cli/releases/tag/v2.6.0 :sunflower:


add dart support

rua!
Tested on macos 15 (m3)  ubuntu2310  windows11 (23h2).

Thanks for your contribution !


Client sent an HTTP request to an HTTPS server

I am getting this error when running curl against the service which is running on EKS:
Client sent an HTTP request to an HTTPS server.
I have a valid SSL certificate installed on a load balancer.

What does your curl request look like? Can you post it?
This error sounds like your curl is specifying http://my-eks.instance.com:443
So the scheme is http but the port is https.

Actually I fixed my issue. The ingress proxy was sending the traffic to the https port 9443 but using a http call since we are offloading SSL onto the load balancer. Reconfigured the ingress to forward https traffic to port 9000 instead.

/close


Embedded resources do not load from bindings

If I use
Source="resource://myapp.Images.mainimage.jpg"
The image loads and displays great
If I use
Source="{Binding Image}"
Where image equals the exact same string as above the image fails to load.

Have you used MvvM-bindings? What can happen is that the image is loading but the visual representation is not updating to reflect the update. FodyWeaver can help with this, or you can write your own.

Yeah. Im have this problem too. Version 2.2.10-pre-413

IMO the cause is a problem with ViewModel
s INotifyPropertyChanged implementation. Are you sure you have everything correctly implemented?
There is really no-difference (from FFImageLoading side) between loading as a hardcoded string vs binding. Here's the code responsible: https://github.com/luberda-molinet/FFImageLoading/blob/master/source/FFImageLoading.Forms/ImageSourceConverter.cs#L25-L30

Sorry I had to abandon this as was close to release so I am now looking at it with the latest release.
As before if I do
Source="resource://myapp.Images.mainimage.jpg"
The image loads and displays great
If I use
Source="{Binding Image}"
Where image equals the exact same string as above the image fails to load.
I confirmed with a label field that the exact same string is being passed :
Here are the errors , why is it even going through http ?
FFImageLoading.DownloadAggregateException: One or more errors occurred. ---> System.ArgumentException: Only http or https scheme is allowed
at System.Net.Http.HttpRequestMessage.set_RequestUri (System.Uri value) [0x0002b] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/mono/mcs/class/System.Net.Http/System.Net.Http/HttpRequestMessage.cs:96
at System.Net.Http.HttpRequestMessage..ctor (System.Net.Http.HttpMethod method, System.Uri requestUri) [0x0000d] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/mono/mcs/class/System.Net.Http/System.Net.Http/HttpRequestMessage.cs:58
at System.Net.Http.HttpRequestMessage..ctor (System.Net.Http.HttpMethod method, System.String requestUri) [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/mono/mcs/class/System.Net.Http/System.Net.Http/HttpRequestMessage.cs:51
at System.Net.Http.HttpClient.GetAsync (System.String requestUri, System.Net.Http.HttpCompletionOption completionOption, System.Threading.CancellationToken cancellationToken) [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/mono/mcs/class/System.Net.Http/System.Net.Http/HttpClient.cs:161
at FFImageLoading.Cache.DownloadCache+d__17.MoveNext () [0x0006c] in C:\projects\ffimageloading\source\FFImageLoading.Common\Cache\DownloadCache.cs:100


Insufficient dependency on parsec 0.1.3

When installing gsettings from MELPA Stable, I find that, e.g., (gsettings-get "org.gnome.desktop.interface" "document-font-name") gives the following error:
   gvariant--string: Invalid function: #<subr prog1>

This is cured by replacing the latest parsec in MELPA Stable, 0.1.3, with the latest in MELPA, 20180730.16.

hmm, good catch
… but the Package-Requires field should not point to melpa versions, as i understand it 😕

I've requested that they consider making a newer release.  https://github.com/cute-jumper/parsec.el/issues/11

thanks!

Thanks to this small modification, installing the package no longer works.
The upstream parsec (in every public repo) is still 0.1.3.
The user is simply greeted with a broken dependency and no way of installing the proper release.

I've asked the developer of parsec to bump the versions in the main repo. This should fix both that and Melpa. If you could re-open the issue, that'd help.
Allow the package to be useable with the older parsec, but allow for newer features.

Number 2 isn't exactly a viable solution, but given that parsec really does have some genuine changes and they're not reflected in the version (and I think it does semver wrong), then it's also an option.

i can't edit/reopen issues on the parsec repo, only on my own repos (which i did)

In that case, let’s wait.


KeyError: u'void--unlabeled

Hi, all,
I test the evaluation.py to get first impression. I use MVD validation labels as the predictions. All the process goes well except that I got "KeyError: u'void--unlabeled", here is the details log.
Any suggestions?
THX!

Hi @amiltonwong
Thanks for reporting the issue. It seems that you used the (8bit) label ground truth files.
I will fix the script to handle that case, but in meantime please try again and specify the (16bit) instance specific ground truth files with the -g switch.
Thanks

Should be fixed in f1270a199ed2a534ba7eec1922132e1866ac0ba9


Clarify the possibility for GitLab SSO

This page states that GitLab SSO is available in all tiers as it was previously with MM Versions <6.0
However the page also states that the GitLab SSO Auth is using OAuth2 which is deprecated and should be replaced by OpenID Connect. I updated a MM Instance from 5.39 to 6.0 and GitLab SSO is still working (and even has a dedicated place in the system console sidebar).
This page, which links from the GitLab SSO documentation, states that OpenID Connect requires the Enterprise or Professional Tier.
To me as the reader of the documentation it's not clear if

GitLab SSO stays "first class citizen" and is available for every tier including the free tier
If not: At which point in time GitLab SSO will be available with a paid tier only

I think this should be clarified on the GitLab SSO page (https://docs.mattermost.com/onboard/sso-gitlab.html)
:v:

Documentation updated via https://github.com/mattermost/docs/pull/5317.

Documentation updated via https://github.com/mattermost/docs/pull/5317.


Queries Are Not Being Distributed Over The Replicas

Hello,
I've set up ClickHouse with 3 replicas for each table. I wrote an API for test purposes which queries the CH. CH is supposed to distribute all the queries but it did not work as expected. It is only querying the CH node which the API is connected. I checked users.xml, changed load balancing to 'in_order' from 'random', it still did not work. By the way data is being replicated accurately, there is no problem with that.
I can see the replicas when I query 'select * from system.clusters', it looks okay as well.
Here is my create table queries :
CREATE TABLE t1 on cluster 'c1' (custUInt32,tt UInt32) ENGINE = ReplicatedMergeTree('/clickhouse/tables/{layer}-{shard}/t1', '{replica}')  ORDER BY cust
CREATE TABLE t1_dist on cluster 'c1' as t1 ENGINE = Distributed(c1, default, t1, rand());
Here is my select query :
select cust, count() as cnt from t1_dist where tt = 100 group by cust
Do I have to make any specific configuration for CH to distribute the queries?

did you try set prefer_localhost_replica = 0 ?

did you try set prefer_localhost_replica = 0 ?

I set prefer_localhost_replica to 0 as you suggested but still no luck. Tried setting 'load_balancing' in users.xml to 'random' again, but it did not work as well.

Okay, so I've set prefer_localhost_replica to 0 on CLI, but it seems to not saving the setting. I closed the CLI and re-opened it to double check, I saw that 'prefer_localhost_replica' is re-set to 0.
I have solved the issue by adding <prefer_localhost_replica>0</prefer_localhost_replica> line to users.xml. I will open a new issue about set prefer_localhost_replica = 0 is only being executed for the current session. If it is not the expected behaviour

it's a bad idea to send all queries through one server.  Try ha-proxy or ch-proxy (https://github.com/Vertamedia/chproxy).
It's bad for high availability.
It's bad for performance because you entrance node re-send a query to another node and download a query result and re-send the result -- double network overhead.
It's bad for performance because you entrance node -- initiator does all final aggregations for shards results -- so your initiator overloaded by CPU/RAM in comparison with all other nodes.

it's a bad idea to send all queries through one server.  Try ha-proxy or ch-proxy (https://github.com/Vertamedia/chproxy).
It's bad for high availability.
It's bad for performance because you entrance node re-send a query to another node and download a query result and re-send the result -- double network overhead.
It's bad for performance because you entrance node -- initiator does all final aggregations for shards results -- so your initiator overloaded by CPU/RAM in comparison with all other nodes.
(Though sometimes it has sense if one node has more RAM than others).

Yes, we are thinking about using ha-proxy but I don't want to get to that stage without making sure of the cluster&replica setup. Thanks for the warning though. By the way round-robin is 'in_order' attribute in the settings right?

By the way round-robin is 'in_order' attribute in the settings right?

No. https://clickhouse.yandex/docs/en/operations/settings/settings/#load_balancing-in_order
the same order as they are specified in configuration
            <replica>
                <host>first</host><port>9000</port>
            </replica>
            <replica>
                <host>second</host><port>9000</port>
            </replica>

By the way round-robin is 'in_order' attribute in the settings right?

No. https://clickhouse.yandex/docs/en/operations/settings/settings/#load_balancing-in_order
the same order as they are specified in configuration

So you mean I should not let CH to distribute queries and query the nodes raund-robin with using ha-proxy or ch-proxy. So I will be querying the local tables instead of distributed ones, did I get you right?
By the way at the moment I am having another issue, when I restart a CH replica under load it does not resume to get queries and act like a cold replica. It resumes to get queries if I restart the CH on the server which my API is connected. Weird.

By the way at the moment I am having another issue, when I restart a CH replica under load it does not resume to get queries and act like a cold replica. It resumes to get queries if I restart the CH on the server which my API is connected. Weird.

I think this one is related to #5317. Looks like it just takes some time to get up again

So you mean I should not let CH to distribute queries and query the nodes raund-robin with using ha-proxy or ch-proxy. So I will be querying the local tables instead of distributed ones, did I get you right?

Right.

By the way at the moment I am having another issue, when I restart a CH replica under load it does not resume to get queries and act like a cold replica. It resumes to get queries if I restart the CH on the server which my API is connected. Weird.

Yes, this is expected behavior. You can execute [touch cluster_config.xml ] to reset error counters until  #5317 is not implemented

Yes, this is expected behavior. You can execute [touch cluster_config.xml ] to reset error counters until #5317 is not implemented

I see, so when I restart the clickhouse cluster on the leader node, it resets error counters as well, because it gets fixed with that way too. Thanks a lot for your time man, I appreciate it!

So you mean I should not let CH to distribute queries and query the nodes raund-robin with using ha-proxy or ch-proxy. So I will be querying the local tables instead of distributed ones, did I get you right?

Right.

By the way about this one, I won't have replicas only, I will have shards too. So not letting CH to distribute the queries and querying the local tables manually, I will have to query all the shards and merge the data when I have more than 1 shards. So looks like it is not a good way to go with if you have shards along with the replicas right?

How to set load_balancing it depends of your cluster design.
I use load_balancing = nearest_hostname because I have a geo-cluster (replica are far from each over (high latency/low bandwidth).
Shards have similar host-names inside DC.
And nearest_hostname allows to query (preferably) local (in current DC) shards-nodes.
In case of local shard/replica fail distributed table requests replica from another DC.


Finish committing leftover changes in working directory

including renaming files in outputs from .js to .json extensions.

done.


fix(release): Update VPC service to use API version 2021-01-12

:tada: This PR is included in version 0.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


new release v1.9.4 (2)

Superscedes #1

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Supersceded by #3


Refactor metatlas_objects into separate files

@blink1073: I just noticed this issue.  I see you did a bunch of coding over the weekend.
I was actually thinking last week that it might be nice to have each of the classes in metatlas_objects.py in its own file as well.  In fact, that's what I thought this case was about reading the name.

My intent was to separate MetatlasObject and its subclasses from the utilties built up around it.  I am generally :-1: on having one class per file.


IotaContainer interface for iota-containing iotas

adds an IotaContainer interface for iota-containing iotas. This interface is used by getTrueNameFromDatum, allowing for addons to implement this interface on iotas to allow for true-name write protection.

Actually... is there some reason we can't just use Iota#subIotas for this?
https://github.com/FallingColors/HexMod/blob/c065e205109b3d4683e3d84ecdaedcb8306ac824/Common/src/main/java/at/petrak/hexcasting/api/casting/iota/Iota.java#L77-L86


convert ':' to '-' in imagestream and imagestream tag names

CLOUDBLD-746

Signed-off-by: Robert Cerven<EMAIL_ADDRESS>Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request has a link to an osbs-docs PR for user documentation updates

not updating rn, fix for unreleased feature


Fix: Cleanup old cinder services

Somehow the services are not being captured with the volume service list while grepping for the "down" services.
One possibility is that the services were in "up" state when we migrated the DB from 17.1 -> 18 and it takes time to update the DB to report them as "down" meanwhile we are attempting the removal.
The straightforward way would be to cleanup all old cinder-scheduler and cinder-backup service entries since we haven't deployed the RHOSO services for cinder yet.
+------------------+------------------------+------+---------+-------+----------------------------+
| Binary           | Host                   | Zone | Status  | State | Updated At                 |
+------------------+------------------------+------+---------+-------+----------------------------+
| cinder-scheduler | standalone.localdomain | nova | enabled | down  | 2024-11-13T14:21:59.000000 |
| cinder-backup    | standalone.localdomain | nova | enabled | down  | 2024-11-13T14:21:59.000000 |
| cinder-volume    | hostgroup@tripleo_ceph | nova | enabled | up    | 2024-11-13T15:34:40.000000 |
| cinder-scheduler | cinder-scheduler-0     | nova | enabled | up    | 2024-11-13T15:34:45.000000 |
| cinder-backup    | cinder-backup-0        | nova | enabled | up    | 2024-11-13T15:34:48.000000 |
+------------------+------------------------+------+---------+-------+----------------------------+

It's unfortunate to go with the brute force route but at least it works
TASK [cinder_adoption : Get cinder-backup down services] ***********************
changed: [localhost] => {"changed": true, "cmd": "\nset -eux\noc exec -t openstackclient -- openstack volume service list --service cinder-backup -c Host -f value\n", "delta": "0:00:02.704676", "end": "2024-11-14 06:21:40.090419", "msg": "", "rc": 0, "start": "2024-11-14 06:21:37.385743", "stderr": "+ oc exec -t openstackclient -- openstack volume service list --service cinder-backup -c Host -f value", "stderr_lines": ["+ oc exec -t openstackclient -- openstack volume service list --service cinder-backup -c Host -f value"], "stdout": "standalone.localdomain", "stdout_lines": ["standalone.localdomain"]}
TASK [cinder_adoption : Remove old cinder-backup service] **********************
changed: [localhost] => (item=standalone.localdomain) => {"ansible_loop_var": "item", "changed": true, "cmd": "set -euxo pipefail\n\n\noc exec -t cinder-api-0 -c cinder-api -- cinder-manage service remove cinder-backup "standalone.localdomain"\n", "delta": "0:00:02.145773", "end": "2024-11-14 06:21:42.476277", "item": "standalone.localdomain", "msg": "", "rc": 0, "start": "2024-11-14 06:21:40.330504", "stderr": "+ oc exec -t cinder-api-0 -c cinder-api -- cinder-manage service remove cinder-backup standalone.localdomain", "stderr_lines": ["+ oc exec -t cinder-api-0 -c cinder-api -- cinder-manage service remove cinder-backup standalone.localdomain"], "stdout": "Service cinder-backup on host standalone.localdomain removed.", "stdout_lines": ["Service cinder-backup on host standalone.localdomain removed."]}
TASK [cinder_adoption : Get cinder-scheduler down services] ********************
changed: [localhost] => {"changed": true, "cmd": "\nset -eux\noc exec -t openstackclient -- openstack volume service list --service cinder-scheduler -c Host -f value\n", "delta": "0:00:01.941889", "end": "2024-11-14 06:21:44.739273", "msg": "", "rc": 0, "start": "2024-11-14 06:21:42.797384", "stderr": "+ oc exec -t openstackclient -- openstack volume service list --service cinder-scheduler -c Host -f value", "stderr_lines": ["+ oc exec -t openstackclient -- openstack volume service list --service cinder-scheduler -c Host -f value"], "stdout": "standalone.localdomain", "stdout_lines": ["standalone.localdomain"]}
TASK [cinder_adoption : Remove old cinder-scheduler service] *******************
changed: [localhost] => (item=standalone.localdomain) => {"ansible_loop_var": "item", "changed": true, "cmd": "set -euxo pipefail\n\n\noc exec -t cinder-api-0 -c cinder-api -- cinder-manage service remove cinder-scheduler "standalone.localdomain"\n", "delta": "0:00:02.254775", "end": "2024-11-14 06:21:47.264976", "item": "standalone.localdomain", "msg": "", "rc": 0, "start": "2024-11-14 06:21:45.010201", "stderr": "+ oc exec -t cinder-api-0 -c cinder-api -- cinder-manage service remove cinder-scheduler standalone.localdomain", "stderr_lines": ["+ oc exec -t cinder-api-0 -c cinder-api -- cinder-manage service remove cinder-scheduler standalone.localdomain"], "stdout": "Service cinder-scheduler on host standalone.localdomain removed.", "stdout_lines": ["Service cinder-scheduler on host standalone.localdomain removed."]}

do we need to test it downstream for the rollback job?

do we need to test it in testproject for the periodic-adoption-multinode-to-crc-no-ceph-rollback job?

Hey,
If the concern is about this working in a no-ceph environment, we will just skip the cleanup if no old service exists.
So if no cinder-backup was enabled in 17.1 environment, we will skip cinder-backup cleanup from old env.

lgtm

CI job passed. It's ready for merge

/lgtm


Where to add custom_pipeline

I try to add a pipeline that does some custom augmentation following this tutorial
https://mmdetection.readthedocs.io/en/latest/tutorials/data_pipeline.html#extend-and-use-custom-pipelines
I wonder where and how i should import MyTransform? When i run my training code it removes my MyTransform from the train_pipeline.
Adding from .my_pipeline import MyTransform in tools/train.py didnt do the trick
Does my_pipeline.py need to be placed in some specific directory?
Also, i did install mmdetection using pip. Is it at all possible to run a custom pipeline when installing via pip?

I tried setting it in my cfg
Now i does import the module, but it still doesnt allow me to add it as part of my train pipeline
custom_imports = dict(imports=['my_pipeline'], allow_failed_imports=False)
train_pipeline = [
    dict(type='MyTransform', p=.2)
]

I think i found the problem. For future reference:
data = dict(
    train=dict(
        pipeline=train_pipeline
     )
 )

In my cfg i needed to add the train_pipeline explicitly as part of data.train.pipeline
Now it runs my MyTransform as part of the training pipeline

Hi, I got same issue. Could you plz tell me how to solve it in detail? where i should import My_transform, and how to use it in cfg. it would be great if you can share an example.

I tried to rephrase the docs to make it a bit more clear. Have you seen the associated PR?

COOL. It's very kind of you!XD


netstandard11?

Hi I tried installing LibLog into a netstandard11 library today and it seems that the Logging code is not copied in. I do not see an App_Packages folder or the .cs file. ILog and LogProvider not available. :(

Update. Maybe related to DNX issues discussed in https://github.com/damianh/LibLog/issues/35
Update2. Maybe this is helpful:
http://blog.nuget.org/20160126/nuget-contentFiles-demystified.html
Update3. Or this
http://stackoverflow.com/questions/35985232/nuget-3-3-contentfiles-not-added-to-project
I tried it the following
		<contentFiles>
			<files include="cs\any\LibLog.cs.pp" buildAction="Compile" />
		</contentFiles>
    </metadata>
    <files>
        <file src="LibLog.cs.pp" target="contentFiles\cs\any\" />
    </files>

but it did not work. Also this did not work
		<contentFiles>
			<files include="cs\**\*.*" buildAction="Compile" />
		</contentFiles>
    </metadata>
    <files>
        <file src="LibLog.cs.pp" target="contentFiles\cs\any" />
    </files>

nothing gets copied to net46, netstd or pcl.

Great scotts, this works for netstandard11:
		<contentFiles>
			<files include="contentFiles\cs\**\*.*" buildAction="Compile" />
		</contentFiles>
    </metadata>
    <files>
        <file src="LibLog.cs.pp" target="contentFiles\cs\any" />
        <file src="LibLog.cs.pp" target="contentFiles\cs\netstandard1.1" />
    </files>

Doesn't work for net46 or PCL, but maybe this with the old method will work just fine.

Hi, as I mentioned in the PR, I'm not going to do the netstandard work until tooks have settled down. I know that the csproj format has changed again in the upcoming RC release.
For now, copying the class file into your netstandard project and using the LIBLOG_PORTABLE directive will work, pending a future release of liblog.
Btw, I want it too for netstandard, so we'll get this done :)

Discussion for this is continuing over at #125


Redirect /towerfall/ to open tournament

Right now we're hardly coded to go to moon/.

Opted to do a clean redirect to /towerfall/ instead, as well as styling the tournament lists differently to highlight the current tournament more.
See 474f4af


ensure! shown in the docs is different than actual definition

The ensure! macro has a completely different definition in the documentation, and what is actually used in the library.
https://docs.rs/anyhow/latest/src/anyhow/macros.rs.html#120-143

The documentation macro definition is
macro_rules! [ensure](https://docs.rs/anyhow/latest/anyhow/macro.ensure.html) {
    ($cond:expr $(,)?) => {
        if !$cond {
            return $crate::__private::Err($crate::Error::msg(
                $crate::__private::concat!("Condition failed: `", $crate::__private::stringify!($cond), "`")
            ));
        }
    };
    ($cond:expr, $msg:literal $(,)?) => {
        if !$cond {
            return $crate::__private::Err($crate::__anyhow!($msg));
        }
    };
    ($cond:expr, $err:expr $(,)?) => {
        if !$cond {
            return $crate::__private::Err($crate::__anyhow!($err));
        }
    };
    ($cond:expr, $fmt:expr, $($arg:tt)*) => {
        if !$cond {
            return $crate::__private::Err($crate::__anyhow!($fmt, $($arg)*));
        }
    };
}

(A pretty good implementation, generally what a rustacean would expect!)
But the macro which is actually used while compiling code is completely different
macro_rules! ensure {
    ($($tt:tt)*) => {
        $crate::__parse_ensure!(
            /* state */ 0
            /* stack */ ()
            /* bail */ ($($tt)*)
            /* fuel */ (~~~~~~~~~~ ~~~~~~~~~~ ~~~~~~~~~~ ~~~~~~~~~~ ~~~~~~~~~~ ~~~~~~~~~~ ~~~~~~~~~~ ~~~~~~~~~~ ~~~~~~~~~~ ~~~~~~~~~~ ~~~~~~~~~~ ~~~~~~~~~~)
            /* parse */ {()}
            /* dup */ ($($tt)*)
            /* rest */ $($tt)*
        )
    };
}

The problems with this

The docs are completely misleading on what the macro actually is
The macro shown in the documentation is not what the macro used in code is
The __parse_ensure! macro is nearly 800 lines of code
Was the parse_ensure macro necessary here? Rather, is it necessary at all? It is completely undocumented as far as I can find, and it looks far more than what is required.
Were the compile time influence not considered during this at all?
Evaluating that macro would take a lot of time. It's massive

Why even have different implementations in the docs and in the implementation? The documentation implementation doesn't even look wrong, and should do the same thing (while being a much simpler, faster to compile macro).
Other crates such as eyre also have a similar, simpler implementation of the ensure macro https://docs.rs/eyre/latest/src/eyre/macros.rs.html#109-125

The __parse_ensure macro is used to allow the following error messages:
let (x, y) = (5, 6);
anyhow::ensure!(x == y);

into
Error: Condition failed: `x == y` (5 vs 6)

An example output of the macro
match (&x, &y) {
    (lhs, rhs) => {
        if !(lhs == rhs) {
            #[allow(unused_imports)]
            use ::anyhow::__private::{BothDebug, NotBothDebug};
            return Err((lhs, rhs).__dispatch_ensure("Condition failed: `x == y`"));
        }
    }
}

It is complicated but necessary for these nicer error messages.

Sure, this is valid. But the documentation is still misleading. (Especially since clicking source leads to the wrong definition) and could the implementation of this not have been simpler?

It's not really misleading, it's documentation on how to use the macro. The actual implementation would generate very useless documentation that would not serve the job of documentation- describing on the macro can be used.

Sure, that can be in the docs itself though, rather than pointing to a completely different macro entirely.

The current solution is not very accurate either, look at the expansion of this:
use anyhow::ensure;

ensure!(true == true || false == true);

use anyhow::ensure;

if !(true == true || false == true) {
    return ::anyhow::__private::Err(::anyhow::Error::msg(
        "Condition failed: `true == true || false == true`",
    ));
};

It doesn't detect the == operation occurring and add the specialized diagnostic. (The condition is parsed as true == (true || (false == true)))
A proc macro for this should be much better, imo. It would both more accurately perform this and should hopefully be faster than the decl macro implementation right now. 🤷🏽♀

https://github.com/dtolnay/anyhow/issues/325#issuecomment-1782882042 is accurate about why it's set up this way. The input patterns shown are indeed the 4 patterns that the macro accepts. The real macro implementation just parses the same things token-by-token instead of through macro_rules's built-in $:expr parser.

Sure. But the "source" of the macro according to the docs is still completely misleading.
When I click "source" on the docs, there's no comment or no indication at all (neither in the docs themselves nor in any comment in the source code) to the actual implementation of the macro. It just points to a pseudo-macro.
If I hadn't noticed the tiny cfgs, I would've been completely oblivious to this too.
This is still ignoring

The compile time affect of this
The accuracy of this (https://github.com/dtolnay/anyhow/issues/325#issuecomment-1783039224)

Hacking together a semi-parser of Rust code in a declarative macro seems unnecessary and a misuse of them. A proc-macro seems much better suited here?

If the point of the cfg(docs) macro is to simply be a place holder for the docs, why implement at all?


Simulator doesn't ignore 'tableau.submit' in gatherData phase

In Tableau, this is a valid code snippet:
myConnector.init = function(initCallback) {
  initCallback();
  tableau.submit();
}

This auto submits a connector so no interactive phase is required.  In the data gathering phase, this submit call is ignored.  However in the simulator this causes the simulator to get into an infinite loop.

Fixed with #88