DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_2557f299-faf3-4791-b7e6-bf39347f618d/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_2557f299-faf3-4791-b7e6-bf39347f618d.git

Docs Build status updates of commit 9bbec4a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-BuildPermissionInsufficientError] Your repository https://github.com/VSC-Service-Account/docs-archive-test-source has enabled Docs Build service account. It seems that at least one of the account, e2ebd2, does not have Read permission to the repo. Please ask your repo admin to grant correct permission to service accounts (refer to this document: https://review.docs.microsoft.com/en-us/engineering/projects/ops/engdocs/how-to-grant-service-account-permission-in-your-repository?branch=master) and then retry the build.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


cmd/doc: -all flag misses exported variables of unexported types

Using go1.12
Consider the following snippet:
package foo
var X x
type x struct{}

Invoking go doc -all prints:
package foo // import "."

Notice how X is missing? It should be shown. The problem is that the logic probably files the value under the x type, but since x is not shown, it gets swallowed.

Does X show up in godoc under ?m=all ?

I think this is a reasonable issue regardless of the answer to @agnivade's question.

Looked into it. The difference lies in the code paths between (*Package).packageDoc and (*Package).allDoc. You will notice that it correctly gives the output if you give go doc, but fails to show the variable on go doc -all.
On an unrelated note, I noticed that 1.13 has a regression where the -all flag does not even print the package clause.
$cat kk.go
package foo
var X x
type x struct{}

19:57:30-agniva-~/play/go/src/playtest$go doc -all

19:57:32-agniva-~/play/go/src/playtest$

But simply go doc does show the var X x.
$go doc

package foo // import "playtest"

var X x

Offtopic: https://github.com/golang/go/commit/f736de04aa52d4889760ecfe4380da01aaf4758f introduced the regression. (@robpike). This happens because now the package clause gets printed on the first write to pkg.buf. That means nothing gets printed, if no writes happen. Not a big deal, but I guess it is technically a bug because if a file contains just the package clause, nothing gets printed. Whereas it should. I have a fix for this. Will send it shortly.


Fix getSerialOfFirstCamera() function

Fixes the issue described in https://github.com/ensenso/ros_driver/pull/99


Adding minimum support version check for pyranges

Description
Checking pyranges's current version and raising warning if the version is lower than 0.0.96
Fixes #58
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Unit Tests
[x] PEP 8 Formatting Validation

@srgothi92 okay so should I remove that as I thinking for warning the user

Yes please, just change pyranges dependency version number in setup.py.


Add new endpoint to verify password reset confirm token

Hello,
For web clients it's essential to have an endpoint to verify password reset confirm token, so it can easily and securely routed to the password reset confirm form page and render it for a user to interact with.

url(r'^password-reset/confirm/(?P<uidb64>[0-9A-Za-z_\-]+)/(?P<token>[0-9A-Za-z]{1,13}-[0-9A-Za-z]{1,20})/$',
    TemplateView.as_view(template_name="password_reset_confirm.html"),
    name='password_reset_confirm')

That seemed to work for me, following the same pattern you helped me with, in the custom email the reset link goes to the react client and then the React client sends the new password along with uuid and token to the endpoint above

Hi @aaronamelgar, thank you for your help
The URL mentioned in your comment is only used for Django itself internally at the reset email generation process as a reverse URL, it doesn't validate anything.
This was mentioned in the FAQ section at docs, question no.2.
I had a similar idea before about this URL regarding its regex pattern, despite I was asking about token regex but this answer made it more clear for me that this URL is only used for reverse, the regex doesn't matter.
I had checked all the views and serializers here to make sure before opening this issue and there is nothing verifies the password reset token separately, it's only done when submitting the new password .

@iMerica  I have done it for my project but I thought it's better to open an issue here to discuss it before working on a PR.

For web clients it's essential to have an endpoint to verify password reset confirm token

Can you explain why this is essential? I'm not arguing that it isn't – I just don't understand the rationale and what the current problem that solves.

You have a password reset form that should be accessible only on a valid reset request through the user's email, now without verifying the reset token first from the server, you can't protect this page from being accessed by anyone else as it's a public page, even if you relies on the page defined URL regex, without verifying, you can easily open it with any similar regex.


shader: Alpha value not being respected in fragment shader

Ebitengine Version
2.6
Operating System

[X] Windows
[X] macOS
[ ] Linux
[ ] FreeBSD
[ ] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] PlayStation 5
[ ] Xbox
[ ] Web Browsers

Go Version (go version)
1.22
What steps will reproduce the problem?
Created reproduction repo
What is the expected result?
Expected result is for the white square rendered with the shader to be blended with the blue background, making the shader seem semi-transparent.

(Simulated image created using drawing program) The white in this screenshot is 255,255,255,25.5 which is equivalent to 1,1,1,.1 in shader language
What happens instead?
The white square is at full alpha no matter what value is returned in the 4th position of the vec4. Even setting alpha to 0 still draws the full white square

Anything else you feel useful to add?
Shader code
package main

// kage:unit pixels

func Fragment(pos vec4, tex vec2, _ vec4) vec4 {
    return vec4(1, 1, 1, .1)
}

Draw code
func (g *Game) Draw(screen *ebiten.Image) {
	screen.Fill(color.RGBA{0, 0, 255, 255})
	options := &ebiten.DrawRectShaderOptions{}
	options.GeoM.Translate(100, 100)
	screen.DrawRectShader(100, 100, Shader, options)
}

There may be some misunderstanding with how shaders work in ebiten + kage. If there is a different solution or setting that i've missed, please let me know.

The result has to be a premultiplied alpha color value.
https://github.com/tinne26/kage-desk/blob/main/docs/tutorials/premult.md

Confirmed fixed when switching to NRGBA for colors with lower alpha values. Thank you for your response.


[Future Req] Add VIN based car details to the app

You can find free vin decoder (https://decoder.bvzine.com/) on the net, so maybe it would be nice to implement possibility to read such date and cache them in the app.
My proposal would be:

MVP: read from web (manually triggered by user, captcha on user site) and present in the app all vin related information

Store them in cached data in app
option to change car (e.g. remember 2, 3, 5 cars date with possibility to change that manually).

Next step: integrate VIN related info with actual car stats tab  based on the connected car vin. (possibility to change car manually to view different car's data). Combination of this 2 sets would give very detailed info about the car.

What do you think about it ?
Please share your though and possible use cases you'd like to see in future.
Please vote if you'd like such future.

I personally don't see the usage of that as the app is mainly to have enhanced in-car entertainment to use apps and other features. And if anyone wants to know his equipment list can do that on various trusted websites, even on official BMW Equipment, Accessoires and Parts retailers. But that would be a one time thing I mean who wants/needs to know their cars equipment daily?
Didn't want to be negative on your idea as it is gererally useful if someone wants to buy a BMW or once see what options the owned car has but I feel like it is kinda off the pace what hufman intended to make possible with this artwork sent from heaven. :)

As I said it can be some side-future for the app. Idea came from a friend of my friend who I was helping with the app. He has couple of BMWs (from really old to new once) and sometime he doesn't know details of the cars and also would like a option to gather stats about e.g. odometer, fuel consumption of the compatible cars with option to export in future.
That's why I asked the community if You also see some similar use cases that we can be added in future to the app.
I agree that for now we have more important future to get working.

I mean there are many website to get all the details via the VIN, I don't think this App needs it especially since it is compatible with BMW 2014+.
About the other Information, when the App is Connected with the cars is does readout various values RPM, Oil Temps, Engine Temp and whatnot :)
Maybe this helps your friend already :)

I think this feature would not fit in the core Android Auto for IDrive concept, but could be built as a separate Companion App idea that integrates information from the CDS. It could perhaps be combined with the more performance-oriented gauge display app idea that you had.

Moved this idea to the Addons ideas list


Sysstats Panorama Broken

Has version 19 and up broken Sysstats Panorama General for anyone else? Only the CPU graph opens at first, then about 30 seconds later, all graphs open.  Downgrading to Authentic 18.49 fixes it back. Latest version of all software installed, including Webmin itself. Thank you in advance.

Could you provide the screenshot?

Version 18.49 Working excerpt:

Version 19 and up Non-Working:

Thank you again for taking a look.

Are you opening it in the separate window?

No. Same window. All browsers. Also refresh of page loses left menu. Thank you.

From: Ilia Rostovtsev<EMAIL_ADDRESS>Sent: Tuesday, December 5, 2017 12:06:41 PM
To: qooob/authentic-theme
Cc: imfineru; Author
Subject: Re: [qooob/authentic-theme] Sysstats Panorama Broken (#919)
Are you opening it in the separate window?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/qooob/authentic-theme/issues/919#issuecomment-349371552, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANqwiTzD9IwcG29hFGXFeOe4enNyKxmnks5s9XgVgaJpZM4Q2ko9.

Refresh is part of upcoming Webmin patch. I remember fixing Panorama General. I'll double check.

The rest of the graphs eventually populate, but it takes close to 90 seconds. Yhis is on a i7 2.7 Ghz laptop client.

What theme version do you have?

18.49. Anything above 19 breaks Sysstats.
From: Ilia Rostovtsev<EMAIL_ADDRESS>Sent: Tuesday, December 05, 2017 12:49 PM
To: qooob/authentic-theme<EMAIL_ADDRESS>Cc: imfineru<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [qooob/authentic-theme] Sysstats Panorama Broken (#919)
What theme version do you have?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/qooob/authentic-theme/issues/919#issuecomment-349384220, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANqwiZr5z6OCWe5xpcbIbF8i73B_X5hQks5s9YHvgaJpZM4Q2ko9.

I will take a look tomorrow morning.

Okay, I have provided a fix but it's better to update Sysstat module after the official release of the next Webmin, with the latest 19.04 theme.

Noob at Git, and updating one file, could you give me quick instructions on how to update?
From: Ilia Rostovtsev<EMAIL_ADDRESS>Sent: Wednesday, December 06, 2017 7:19 AM
To: qooob/authentic-theme<EMAIL_ADDRESS>Cc: imfineru<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [qooob/authentic-theme] Sysstats Panorama Broken (#919)
Okay, I have provided a fix but it's better to update Sysstat module after the official release of the next Webmin, with the latest 19.04 theme.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/qooob/authentic-theme/issues/919#issuecomment-349623035, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANqwiQpzxOb2glBavRCDQ0-RaXSGJFa7ks5s9oZCgaJpZM4Q2ko9.

Sure, go to the theme settings and use the button Force Upgrade/Install latest development version.

Thank you. The "fix" just opens a new window, but all graphs show. Thanks for working on that, and EXCELLENT work on this theme. Been using for quite some time.

Thank you for your kind words. 😊


Implement Default for WeakPtr?

In the code I'm writing, it would be useful to have Default on WeakPtr so I don't need to wrap it in an extra layer of Option. This would make it more like std::rc::Weak and I think presents no problem because the null pointer is valid.
Happy to send a PR, I'm filing as an issue first to verify that it would be wanted, and in case there's a problem with the idea I'm missing.

alloc::rc::Weak is actually core::ptr::NonNull internally - they use dangling pointers to create a Default implementation.
But yeah, WeakPtr could probably have a Default impl of WeakPtr::new(core::ptr::null_mut()), but I don't think we want this, since load would now return null in two cases: If the object was deallocated or if it was created from a null pointer - that is, you can't distinguish these two cases, which makes for a bad API IMO.


Send incoming events by batch of 500 records max

Issue #50
Description of changes:
Chunk the incoming events into batch of 500 events max in order to not fail the API_PutRecordBatch call
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for the contribution, will  be included in the next release.


nm bond: workaround on miimon=100 option

The NM will ignore the miimon=100(the default option) when
wired/ethernet setting not included due to bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1806549
This cause verification error when user try to set miimon=100 on
existing bond.
To workaround that, always include miimon option when querying bond
options.
Integration test case included.

This patch does not need to be in master branch as upstream of NetworkManager fixed their problem(not tested yet).

This patch does not need to be in master branch as upstream of NetworkManager fixed their problem(not tested yet).

You mean on NM master or NM 1.22 stable branch head?
Bypassing master is dangerous, if it is not needed there now, we can at least add the test and on the backport add the workaround.

This patch does not need to be in master branch as upstream of NetworkManager fixed their problem(not tested yet).

You mean on NM master or NM 1.22 stable branch head?
Bypassing master is dangerous, if it is not needed there now, we can at least add the test and on the backport add the workaround.

I agree that  the test should be added to master.

@tyll @EdDev PR #922 created for master branch with the same patch.

BTW. The master branch of NetworkManager does not fix this problem yet: https://bugzilla.redhat.com/show_bug.cgi?id=1806549#c5


Overriding stop

Hi,
Thank you for providing such a lightweight MVC framework, its really cool. I've question related to stop.
This is my requirement i.e. I've an embedded Redis server which I would like to start when the app starts and I also would like to stop when the app gets stopped. Hows can I that? I saw that that stop method is available, but its static and there are no hooks/callbacks I could see to change it.
Can someone help to answer this? Thanks.
Leena

Hmm... good question, I cant see a way of doing this without creating a class that extends Spark and one that extends Service and then overriding the methods needed.
Maybe this is feasible to look at adding a very light weight call back system.
any thoughts @tipsy @perwendel ?

@perwendel was looking into life-cycle events at one time, but I'm not sure what happened.

@tipsy I could make a proposal for an events system.
event(Priority.NORMAL, Event.STOP, (some parameters) -> {
    insertLogicHere();
});

That looks pretty cool. @perwendel has final say on what goes into Spark, but I know he was looking into this some time ago, so I think he would like it. Could you create a new issue?

@tipsy Sure I'm on it.

Thank you for taking this up. I could find a way to shutdown using the Runtime class. I added the following code snippet in my Application class :
            Runtime.getRuntime().addShutdownHook(new Thread() {
                public void run() {
                    try {
                        redisServer.stop();
                        mainThread.join();
                    } catch (InterruptedException e) {

                    }
                }
            });

I assume this is a good workaround until Spark introduces lifecycle event hooks.


Export static backend files for web app

Export static backend files for the UI

can you update the documenting-a-bloq directions in https://github.com/quantumlib/Qualtran/blob/main/qualtran/Autodoc.ipynb ?
And please provide a meaningful PR title. It'll be used as the commit title in the squash-and-merge.
Another process thing: can you please clear outputs from your notebook before committing to avoid churn in the git history
We'll have to be really careful merging this as the list of bloqdocspecs changes quite frequently. I understand you need to move it to the subdirector so it becomes importable, yes?

can you update the documenting-a-bloq directions in https://github.com/quantumlib/Qualtran/blob/main/qualtran/Autodoc.ipynb ?

Done.

And please provide a meaningful PR title. It'll be used as the commit title in the squash-and-merge.

Done.

Another process thing: can you please clear outputs from your notebook before committing to avoid churn in the git history

Done.

We'll have to be really careful merging this as the list of bloqdocspecs changes quite frequently. I understand you need to move it to the subdirector so it becomes importable, yes?

Correct, I need to make it importable. I just pulled in the latest, so hopefully there won't be anything missing. Unfortunately, I rebased when I probably should have merged. Hopefully it's not too hard to review. Let me know if you need me to fix it.

I think there's some merge issues where changes that have been committed to main are getting pulled in here

I think there's some merge issues where changes that have been committed to main are getting pulled in here

Yep, sorry. Should be in better shape now.


Some typo of your paper

Our QueryDet achieves the performance with 43.2 AP. Specifically, with the aid of high-resolution features and our query supervision, our approach achieves 26.9 AP on small objects, which demonstrate the superiority of our method. Here, we use GIoU loss [44] and the modified Batch Normalization, as described in FCOS experiments, for further accuracy improvement.

The numbers 43.2 AP and 26.9 AP cannot be found in the Table 8.

Also, in Figure 2, the QueryDet part is Query"N"et.
Just in case.

Thanks for reminds, we will correct it in the next version ~~ :-)


Node deletion error - 'Parentheses are required to identify nodes in pattern'

Deleting a node with the delete(id, force=true, ..) function results in this error:
{ code: 'Neo.ClientError.Statement.SyntaxError',
  message: 'Parentheses are required to identify nodes in patterns, i.e. (node) (line 1, column 40 (offset: 39))
"START node=node({root}) OPTIONAL MATCH node-[rel]-() DELETE node, rel"
                                        ^' }

This message seems to indicate that node-[rel]-() should be (node)-[rel]-() in node.js:198
Using neo4j 3.0.1 community and Seraph 0.14.3.

Thanks! Haven't quite had the time to sit down and make everything neo4j 3 compatible yet, so if you find any other problems don't hesitate to post them here.

No problem :)


Fixed anchors for sub-items in TOC

This template fix links each sub-item to the appropriate anchor. See the TOC box on http://creativecommons.github.io/contributing-code/, and you'll notice all the sub-item anchor links are currently not right.
Before this update:

After:

Closes #XX

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of creativecommons.github.io-source.
[x] I tried building the site using Lektor locally and verified that there are no build errors.

Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Thanks for fixing!


Add a way to get pprof stats from a running node

One option is to create a CLI command to dump a pprof heap and goroutine dump -- pretty much the same as we do when our max memory detector is invoked in recovery.go.
Another option is to expose pprof over the HTTP API (but this may be subject to abuse, rate-limiting may be enough though)

I think we already exposed pprof by default
https://github.com/perlin-network/wavelet/blob/master/cmd/wavelet/main.go#L51

Excellent -- I didn't realize that had the side-effect of adding handlers to the HTTP object... Now we should restrict access to that API ! 😄


wgpu 0.17

Currently blocked on an upstream bug that causes crashes when minimizing/resizing on dx12 https://github.com/gfx-rs/wgpu/issues/3967
Objective
Keep wgpu up to date.
Solution
Update wgpu and naga_oil.
Currently this depends on an unreleased (and unmerged) branch of naga_oil, and hasn't been properly tested yet.
The wgpu side of this seems to have been an extremely trivial upgrade (all the upgrade work seems to be in naga_oil). This also lets us remove the workarounds for pack/unpack4x8unorm in the SSAO shaders.
Lets us close the dx12 part of https://github.com/bevyengine/bevy/issues/8888
related: https://github.com/bevyengine/bevy/issues/9304

Changelog
Update to wgpu 0.17 and naga_oil 0.9
Migration Guide
TODO

Looks like wasm basically needs a rewrite of the renderer...

I'm not sure if we should add a panic somewhere in the renderer in case someone compiles for wasm with -Ctarget-feature=+atomics to warn users that it isn't currently supported, or just leave it for now until bevy supports wasm threading.

Looks like minimising is broken on dx12 for w/e reason, just panics immediately when I minimise a window.

https://github.com/gfx-rs/wgpu/pull/4106 is the upstream PR that fixes the crash, once that lands and there's a patch release this should be good?

@Elabajaba status update on this PR?

Still waiting on a patch release for wgpu.

wgpu 0.17.1 was just released 🎉

I can't reproduce the windows CI failure for the minimising example locally both on a dedicated GPU and forcing it to use WARP.

can't reproduce on my laptop
AdapterInfo { name: "NVIDIA GeForce RTX 3070 Ti Laptop GPU", vendor: 4318, device: 9376, device_type: DiscreteGpu, driver: "", driver_info: "", backend: Dx12 }

Can't reproduce either
2023-10-01T20:09:55.009018Z  INFO bevy_render::renderer: AdapterInfo { name: "NVIDIA GeForce RTX 3080", vendor: 4318, device: 8710, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "536.67", backend: Vulkan }
2023-10-01T20:09:55.953721Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Windows 11 Home", kernel: "22621", cpu: "AMD Ryzen 5 2600 Six-Core Processor", core_count: "6", memory: "15.9 GiB" }

re triggered CI, it's still failing with the same error:
2023-10-01T20:33:12.009607Z ERROR wgpu_hal::auxil::dxgi::exception: ID3D12CommandAllocator::Reset: A command allocator 0x000002ACC79B7860:'Unnamed ID3D12CommandAllocator Object' is being reset before previous executions associated with the allocator have completed. [ EXECUTION ERROR #552: COMMAND_ALLOCATOR_SYNC]
2023-10-01T20:33:12.009841Z ERROR wgpu_hal::auxil::dxgi::exception: ID3D12Resource2::<final-release>: CORRUPTION: An ID3D12Resource object (0x000002ACC607F6E0:'(wgpu internal) Staging') is referenced by GPU operations in-flight on Command Queue (0x000002ACA6BA6CD0:'Unnamed ID3D12CommandQueue Object').  It is not safe to final-release objects that may have GPU operations pending.  This can result in application instability. [ EXECUTION ERROR #921: OBJECT_DELETED_WHILE_STILL_IN_USE]

Just to let you know, wgpu-hal v0.17.1 is currently affected by another resize-related issue which prevents on X11 + Vulkan.
It will be hopefully resolved soon in 0.17.2 as the fix PR is already there though

Fixed in v0.17.2

Oof, the resizing example also works fine for me locally on a my gpu and on WARP. ($env:WGPU_ADAPTER_NAME="Microsoft Basic Render Driver", and changing https://github.com/bevyengine/bevy/blob/f9e50e767b76382527bff93385247829461758a0/crates/bevy_render/src/renderer/mod.rs#L134 to use wgpu::util::initialize_adapter_from_env to test out warp locally)


Check loaded bindings not only on Windows

Perhaps we should only additionally show this help when the error message mentions a symbol-related problem?
if (process.platform === 'win32' || /symbol/.test(err.message)) { ...

I rebased and amended the commit with your suggestion, therefore I force-pushed to have a single commit as specified in the CONTRIBUTING.md

Coverage remained the same at 100.0% when pulling 9fc492f885e1cb9e03af340837f987851c03363d on marvinroger:version-sync-not-only-on-windows into ac883c52155df1410b5929414f1be3f9ec972370 on lovell:main.

C'est super, merci Marvin.

Merci à toi !


tikv backend

https://github.com/opensibyl/sibyl2/issues/4

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 8.68263% with 305 lines in your changes missing coverage. Please review.

Project coverage is 42.67%. Comparing base (58feb48) to head (1b310d5).
Report is 220 commits behind head on master.

Files
Patch %
Lines

pkg/server/binding/binding_tikv.go
1.72%
285 Missing :warning:

pkg/server/binding/binding.go
0.00%
6 Missing :warning:

pkg/server/app.go
0.00%
5 Missing :warning:

pkg/server/binding/binding_badger.go
50.00%
5 Missing :warning:

pkg/server/binding/binding_kv_base.go
81.81%
4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   43.39%   42.67%   -0.73%
==========================================
  Files          39       40       +1
  Lines        3030     3105      +75
==========================================
+ Hits         1315     1325      +10
- Misses       1559     1625      +66
+ Partials      156      155       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Most used facets by user should be displayed at the beginning/top

How can i know the most used facets?

Solution:
First sorting criteria should be sort.
The second, if the sort is equal the facets will in alphabetic order.
Every facet will have a default sort = 0.
E.g:
{
	type: "string",
	name: "simple",
	label: "Simple",
	sort: 23
}

Solution:
Every Facet can have a attribute sort that is default 0.
A higher sort will push the facet up the list (+n) > 0 > (-n).
If the sort of 2 facets are equal they will be sorted in alphabetic order from A > Z.
It's possible to change the direction by setting the option dir:"desc". The default dir is asc.
var facets = [ ... ];
var iggy = newIggy( facets, "#selector", { dir: "desc" } );


Add AppVeyor, Travis build status

Actually I just looked at this and the AppVeyor badge URL is wrong. All these build status updates are using the same image URL for AppVeyor. You need to use the yyivj6uwu3uj2x40 token for this one.

@Eilon that what I notice too, please give me the correct token for each repo

I put the correct token in each PR. As I add more repos I'll mention the token.

thanks @Eilon

A new PR has been created to fix incorrect token


Add background parameter to overline and underline

Adds a background parameter to overline and underline, resolves #1771.

Should strike also support this?

Thank you!


Best Practice: Avoid too many Blank Lines

Just a draft-pr on how this Best Practice (https://github.com/microsoft/alguidelines/discussions/153) could look like.

You are modifying the template!
Please move this to it's own folder.


Empty snapshot instead of error when offline and no cache

Xcode version: 11.2.1
Firebase SDK version: 6.11
Firebase Component: Firestore
Component version: 1.6.1

I interpret the below documentation section that I should get an error if I'm offline and no cache exists. Instead I get a success call with an empty snapshot. This makes it hard to differentiate  between empty state and error state.

If you get a document while the device is offline, Cloud Firestore returns data from the cache. If the cache does not contain data for that document, or the document does not exist, the get call returns an error.

https://firebase.google.com/docs/firestore/manage-data/enable-offline
Steps to reproduce:

Delete app from device (to make sure no cache exists)
Turn off internet (I'm using Network Link Conditioner, 100% loss setting in simulator)
Run app and query a random collection on start up
Wait about a minute for call to return
I get a snapshot result with 0 documents when I expect an error

Sample code used where I get the 0 documents result
    Firestore.firestore()
        .collection("randomCollection")
        .limit(to: 10)
        .getDocuments(source: .default) { snap, error in
            if let snap = snap {
                print("SUCCESS \(snap.documents.count)")
            } else {
                print("ERROR \(error!.localizedDescription)")
            }
        }

Thanks for reporting, @simonbengtsson. I was able to get the same behavior which returns 0 document result upon getting data when the simulator is offline. I'll clarify with the team if what specific error does the doc refers to.

@simonbengtsson The behavior you are seeing is as designed (but maybe not as documented).

If you issue a Collection Query against an empty cache, we will raise an empty snapshot.
If you fetch a document via DocumentReference.get(), we will raise an error if we do not have a cached copy and the device is offline.

The document snippet you provided attempts to convey this information, but it does not explicitly call out that it targets single document fetches. I will ping our documentation team and ask them to rewrite this section.
Thank you for your report!

Thanks for reply! Just to make sure, that means there is no way to detect difference between no internet vs no documents when persistence is enabled with firestore? This would mean we could never show empty state screens?

You can use Query.get(Source.SERVER), which will return an error if we are not able to connect to the backend within 10 seconds.

We very much enjoy using the cache. But wanted to show an error state when there is no cache and no internet instead of a empty state that would worry users who actually might have content.
Knowing that this is how it is designed we will ignore it and show empty state anyway. We might explore double querying with server and cache in the future.

@simonbengtsson You should be able to use snap.metadata.fromCache to determine if the resulting snapshot came from our cache (which would indicate that the client is offline / has no internet).

True! A better experience for our users would probably be to display error state instead of empty state when we get an empty snapshot back from a cache query which we can detect with fromCache. This since it's relatively uncommon for users to be offline after all.
That said, when we get a empty snapshot from cache we could still not differentiate between:

Collection never fetched so we have no idea if it has documents
Collection was fetched from server before and we can assume it has no documents

@simonbengtsson Yes, you are exactly right.  We discussed this a bit yesterday and it would be feasible for us to detect case 1 and surface an error instead of an empty snapshot, but since this would be a breaking change I'm not sure when we'd be able to make this change.
FWIW- What we typically recommend folks do is use a snapshot listener instead of a single getDocuments() call to populate their UI and keep it up-to-date.  Then while snapshot.metadata.fromCache is true, you can show a spinner or "waiting for network..." indicator or similar so that the user understands that the data may be empty / incomplete because it is still syncing.

Good point! The reason we went with getDocuments() is that we have a lot of infinite scrolling lists in our apps. After brief examination it felt like a hassle to work with snapshot listeners for this since we thought we needed to juggle removing listeners etc. But now that I give it second thought it would probably not be so bad. We could simply remove the listener for previous page whenever we fetch the next one. We'll explore it further! Thanks again!

Will explore this UX:
When we get results with fromCache = true from a snapshot listener:

Keep showing loading indicator with "connecting..." message
Show the user potentially cached results, but never show empty state

When fromCache = false:

Hide loading indicator
Show results or empty state
Show error state if no snapshot returned or error

This would also mean we could get rid of our hacky "no connection" warning bar.

@simonbengtsson Sounds very reasonable!  One minor thing to be aware of is if that you'll likely want to pass includeMetadataChanges: true when you create your listener.  This will ensure you get an event even if the only thing that changed was metadata (so you can e.g. hide the loading indicator when fromCache goes from true to false).


DNS > list records is blank

Hi,
There seems to be an issue displaying data under the "l-unit__stats" element which prevents the data from being visible on the page.

Same issue


Maybe wrong offset values when zoomLevel different than 1.0

Hey guys, so im trying to create a screen where the user can "highlight" parts of an image .
To do that, the user can move the highlight "mark" with a PanResponder, and i save the relative position of this mark to the image (ZoomableView)...
All is good when im saving this position with a zoomLevel of 1.0 in the ZoomableView, but things start to get a bit weird when i try to increase the zoomLevel value.
For example:
I have an image with 100% of the screen width (lets say 375) and a zoomLevel of 1.0.
If i drag this image out of the screen (bindToBorders: false) i get an OffsetX of 375. Great, working properly.
If i try to do that with a zoomLevel different than 1.0, i get a value different than 375.
My first thought is that this random value is scaled based on the new zoomLevel, but i already tried to multiply and divide it by the zoomLevel and i didnt get the original offset value (375).
Is that an expected behavior?

This is expected. It's because of this code in ReactNativeZoomableView
 {
  transform: [
    { scale: this.zoomAnim },
    ...this.panAnim.getTranslateTransform(),
  ],
},

As you can see the offset is appended after the scale, so all the offsets need to be calculated based on the scale. This is not ideal, and we're gonna revert this order in the next major release.


options.uri error POST request

Trying to post a simple object through nodejs using request http module, every time I try to send my data to my API it showing this options.uri is a required argument yet I provided a URL end point where to POST the data.
var url = 'http://omcloud.azurewebsite.net/api/Test';
 request.post(url,
             { json: { "Definition": "Test"} },
             function (error, response, body) {
                 if (!error && response.statusCode == 200) {
                     console.log(body)
                 }
             }
         );

Can someone shed a light what's wrong with the code above?

Try this: https://runkit.com/58aa1aa57ba62e0014b4752d/58acce671ddfde00130bedec/branches/master
var url = 'http://omcloud.azurewebsite.net/api/Test';
 request.post(url,
             { json: { "Definition": "Test"} },
             function (err, response, body) {
                     console.log(err, response, body);
             }
         );

We should make the README code snippet more flexible, right now it only logs anything if the response is successful and is silent otherwise.

Sorry don't quite get it,  an error says on that link getaddrinfo ENOTFOUND yet even with the correct URL still showing the same stuff.

tried putting the right URL and still showing the same error.
Tried no luck
request.post({
                url: url,
                json: { "Definition": "Test" }
            }

Issue is with the website and not request
$ curl -X POST http://omcloud.azurewebsite.net/api/Test
curl: (6) Could not resolve host: omcloud.azurewebsite.net

yeah thanks, looks like the endpoint is broken.


Bump flutter_map version, remove deprecated CustomPoint, add mouse pointer on marker for web version

Hey @slawekkrol, thanks for the contribution! I have a bunch of changes that were waiting for a FlutterMap v6 release which I need to get around to. When I do I will be sure to include your fixes.


Code for figure4c & 4d

Hi~
Thanks for your detailed code , it's really friendly and powerful !
Could you please share the code to make the figure 4c and 4d~? ( which compute the Accuracy Score for dataset 10 and dataset 4 )~ And now I see the code for dataset 10 , if possible ~ could you share the code for dataset 4 as well ?  :  )
Greatly appreciate your help !
Best wishes!

Hi~
Thank you very much for your patience！
The STARmap_AS.ipynb file is our code from the prediction results to the final accuracy score. You can use it to implement the plot of Figure4c.
At the same time, we provided the simulated spatial expression matrix of the dataset in the FigureData/Figure4/Dataset4_seqFISH+/Simulated_seqFISH+ file, which can be input into different tools for prediction. And You can compute the accuracy score for dataset 4 （Figure4d）by using the calculation method in STARmap_AS.ipyn
STARmap_AS.ipynb.zip
b

Hi~ I am sorry for for not being able to reply you in time due to holiday. Thank you very much for your patience！ The STARmap_AS.ipynb file is our code from the prediction results to the final accuracy score. You can use it to implement the plot of Figure4c. At the same time, we provided the simulated spatial expression matrix of the dataset in the FigureData/Figure4/Dataset4_seqFISH+/Simulated_seqFISH+ file, which can be input into different tools for prediction. And You can compute the accuracy score for dataset 4 （Figure4d）by using the calculation method in STARmap_AS.ipyn STARmap_AS.ipynb.zip b

Thank you very much ！It's really helpful ~! wish you all the best~


BE AS CLEAR AND CONCISE AS POSSIBLE.
describe the bug
what is the bug - what happens?
Only the "dracula" plugin was selected.
When using "/", the selected "BASIC BLOCKS" cannot be displayed or seen. This problem caused me not to know which block to choose.
expected behaviour
why is this a bug - what should be happening?
When I press "/", I can see which "BASIC BLOCKS" is selected.
screenshots
if applicable, add screenshots of your problem.

platform
what OS are you using? e.g. windows 7, windows 10, WSL, ubuntu, arch linux, macOS
windows 10

hi @EagerD, does this only happen with the dracula theme or with others too?

Among the plug-ins I have used, "dark+" and "material ocean" also have this problem. This situation may be caused by the "BASIC BLOCKS" color setting in the corresponding plug-in being too dark.
EagerD
From: Tom
Date: 2020-11-02 16:33
To: dragonwocky/notion-enhancer
CC: EagerD; Mention
Subject: Re: [dragonwocky/notion-enhancer] Using "/", the selected "BASIC BLOCKS" cannot be displayed (#187)
hi @EagerD, does this only happen with the dracula theme or with others too?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

This is an issue with --theme_dark--interactive_hover not being visible enough. I'm implementing fixes now for dracula and dark+ 👍


Generating new images with ImageDataGenerator

https://blog.keras.io/building-powerful-image-classification-models-using-very-little-data.html

We found big dataset with images of fruits and vegetables, so we wont creating new images, because of time

VegFru of 160k images


Just a word about incessant confusion

I read this article recently and found that it mirrors my own experiences, yes I know it's a year old.
It hit home so well that I emailed the blog author, here's a copy of my email to him - a cry for help I guess!
I'm a very experienced developer and just beginning to open the Pandora's box of the whole "ASP.NET Core" thing, I found your article after I became disillusioned.
 It is almost impossible to follow any of the examples or tutorials, just a glance at the comments at the bottom of any documentation page tells me right away that others are struggling - and many of them know more than I about this area!
Then I read about how ASP.NET Core will no longer be able to use .Net Framework and then I read about how actually it will and frankly I have no idea what to believe anymore!
Almost every article I dig up on the subject of ASP.NET Core emphasizes something different, points out different "issues" contains different advice, suggest different updates, workarounds.
The entire eco-system is full of ifs and buts and updates and versions of this or that and service packs, cryptic just-type-what-I-say command lines and so on.
I have truly struggled for several days to actually find a solid example of how to create a new ASP.NET Core web application using VS 2017, every one I find has either numerous comments posted about issues or is so out of date that I know I'll have problems.
I'd really love to see a follow up to your original article, its almost a year later now so an "anniversary update" would be fascinating!
Documentation never used to be interactive like it is now, every week something documented changes and the documentation no longer applies or contains incorrect version of this or that and so on.
Only a few months ago I began to follow some Microsoft tutorial, the app would not build, I had to check version info for umpteen different things, ensure I had the "latest" .Net Core or VS 2017 update and so on.
I'm looking at a pretty simple private project, the issues are far more daunting when it comes to trying to adopt these technologies at work, right now there's no way we can even consider this.
UPDATE:
By way of an example, I just stumbled upon this while I was exploring Angular and ASP.NET Core.
I can see the callout "This documentation is about the release candidate of the Angular template." yet I am not (it seems or am I ?) using a RC but a released template (VS 2017 15.5.6). So right away I am asking myself "which parts of the walkthru are required and which parts are purely associated with the fact that it's describing the RC?".
I created a new app using the Angular template, it built and ran fine but is that correct? does the RC documentation contain any steps that I must perform? For example the RC documentation shows several command line examples but it is far from obvious which are specific to the RC template and which are naturally associated with this kind if project in general.
Has nobody at MS considered that documentation be considered a deliverable? a deliverable to be included with the released item? rather than an afterthought to be hastily tweaked when people "have time"?
Why not house RC documentation in a distinct docs.draft.documentation.com site and then move and update documents to docs.microsoft.com site at a time that coincides with the item being officially released?
This could be a huge help to developers who are trying to keep up with the changes.
UPDATE:
See also:
https://github.com/aspnet/JavaScriptServices/issues/1527

The code is open source, it is the best documentation there is.

I think what he mean is to make documentation and user guide as part of the release cycle. It's best to update all docs,  user guide, and example before doing major release so any code example in the docs can be reproduce without error.
Also some suggestion, maybe at each (or each 2~3) minor release there will be community review&discussion about state of art of the current web technology. I'm bit surprised there is no Use Webpack section in here.

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


Fix for rendering issues with Keras Layers API Documentation (Convolution and Pooling layers)

This change adds an extra newline character after the Input shape: and Output shape: sections for docstrings with nested bullet points. This ensures the correct markdown translation on the keras.io website for the convolution and pooling layers which have these bullet points right after these section headings.
Screeenshot of issue for MaxPooling2D from the keras.io website:

The markdown translation logic in the keras-io repo for docstrings requires an additional \n character. Some layers such as the ConvLSTM and GlobalAveragePooling already do this correctly in their docstrings. This change replicates the correct structure for the docstrings of the pooling and conv layers which have this rendering issue
Screenshot of MaxPooling2D after the fix:

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.41%. Comparing base (7a81739) to head (6144aca).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19679       +/-   ##
===========================================
- Coverage   78.40%   56.41%   -22.00%
===========================================
  Files         498      498
  Lines       45499    45507        +8
  Branches     8377     8379        +2
===========================================
- Hits        35675    25671    -10004
- Misses       8093    18257    +10164
+ Partials     1731     1579      -152

Flag
Coverage Δ

keras
56.41% <ø> (-21.85%)
:arrow_down:

keras-jax
?

keras-numpy
56.41% <ø> (+0.01%)
:arrow_up:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


can't pull docker image on mounted filesystems

Hello,
please also check:
https://forum.openmediavault.org/index.php?thread/51529-problem-with-docker-client-on-nfs-mounted-filesystem/
I am experiencing persistent issues with Docker on systems where the Docker data directory is located on an NFS-mounted filesystem (netbooted Raspi 4b from a OpenMediaVault NAS)
I'm not able to pull frooodle/s-pdf:latest:
failed to register layer: lsetxattr security.capability /usr/libexec/gstreamer-1.0/gst-ptp-helper: operation not supported
I'm able to pull the image on an Raspi with USB-boot (both Rasp OS and Ubuntu)
I'm able to pull other images on the netbooted Raspi
Efforts to resolve this included:

Migrating NFS Version: Moving from NFSv3 to NFSv4.2 to leverage better support for extended attributes, yet the problem persisted.
Changing Storage Drivers: changed from vfs to fuse-overlayfs, which did not resolve the issue. (I'm getting errors using overlay2)

Given these challenges with NFS, I moved Docker's storage (data-root) to a CIFS mount as a test. However, I encountered similar symlink-related errors:
failed to register layer: symlink ../1c2838626712591e06e028c1166d6d6f973f33677e49323cd4b58f314830bb16/diff /z_volumesCIFS/dockertest05/fuse-overlayfs/l/H5MC2XABMHL2F3IDR3PRZZTLOT: operation not supported
Any advice how to pull your image would be greatly appreciated. ;)
Thank you for your assistance!
Update:
after hours of tests, this is the only working solution so far: mounting an image-file with xfs-filesystem
(like here: https://www.redhat.com/sysadmin/rootless-podman-nfs)

as suggest solution is "mounting an image-file with xfs-filesystem"
closing issue unless other can also not solve


Fix descriptive note on Savage Attacks (or add an Active Effect to the feature instead)

The SRD Savage Attacks feature currently says to "Enable this feature in the Special Traits section of the character sheet", but there is no longer a named "Savage Attacks" feature in there.
This should either be changed to read "Add 1 to the Melee Critical Damage Dice field in the Special Traits section of the character sheet", or an Active Effect should be added to this feature item that targets flags.dnd5e.meleeCriticalDamageDice (and adds 1).

Insert witty comment here.


Error in rpio.Open()

Hi!
I catch this when I try to open memory range for GPIO access in /dev/mem:
open /dev/mem: permission deniedpanic: runtime error: index out of range.
I try this script and add my user to group "gpio", but nothing changed.
How can I solve this problem?

I solved this problem with root privileges.

I solved this problem with root privileges.


Fix issue creating extra apikeys.

No apikeys created for users and admins by default.
Address rancher/rancher#2103

@hibooboo2 There are test failures


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v4.8 to before v4.14.265",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=4d4e9907ff572bb1d1c0f6913ad6e3d6d4525077",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=909d3ec1bf9f0ec534bfc081b77c0836fea7b0e2"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "4d4e9907ff572bb1d1c0f6913ad6e3d6d4525077",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "909d3ec1bf9f0ec534bfc081b77c0836fea7b0e2",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "drm/nouveau: fix off by one in BIOS boundary checking\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.14.265 by commit 909d3ec1bf9f0ec534bfc081b77c0836fea7b0e2, it was introduced in version v4.8 by commit 4d4e9907ff572bb1d1c0f6913ad6e3d6d4525077. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000112


Fix drag notifications across windows.

Fixes #44390.

This is an alternative approach to #67531.
From what I can tell, this PR solves a single problem (highlighting ValidDrop locations of child Windows and SubViewports) of the many problems related to Drag and Drop with Windows and SubViewports, while the other PR intends to solve all of them.
Since the other PR no longer makes use of _propagate_viewport_notification it could be considered as superseding this PR.
Here is a MRP for stress-testing Drag and Drop with Windows and SubViewports BugDragNDrop.zip

@Sauermann This fixes sub-viewports too (although i realized a problem in this PR that needs to be further fixed). The proper handling of the drag preview needs to be done by moving it to a transparent window with passthrough, but that should be implemented in a separate PR.

I wrote #71509 as a far simpler way to solve this. I believe It fixes drags/drops accross viewports more elegantly.

After investigating this topic more deeply, one problem area, that I was able to identify is, that the Viewport, that the mouse is over, is identified in the following code section:
https://github.com/godotengine/godot/blob/23e10d1dfff00eb1ea932b0d3e89ca444b5c0a51/scene/main/viewport.cpp#L1830-L1845
And this code section doesn't account for SubViewports and embedded Windows.
My conclusion is, that in order to fix Drag and Drop for Viewports, it is necessary make this code-section aware of SubViewports and embedded Windows. This conclusion aligns with my tests of this PR with the previously linked MRP, which show that Drag and Drop with Viewports is not yet solved completely.

Needs some consensus and conclusion. We can pick it for 4.0.x though, so bumping for now.

Superseded by #67531.


Create dashboard

Create dashboard page where a user can see all of their posted reviews

We have no way of going to this page (doh) I'll add it in the main.handlebar


Choose Checkpoint

Hi, how do I choose which checkpoint this is using? As in CoTracker2 vs TAPIR, etc?

Nevermind, found it in the base_options.py file.
But while we're here, are there any settings I should be looking for that might give even more accurate results, even at the cost of processing time?

Hi, after the choice of the model other important factors for speed performance trade-off are the number of initial tracks --num_tracks (the higher the better but also the slower) and the resolution used for inference (same).


Fix issue #3324 to add donation source details

This PR changes the donations page and the CSV export on said page to do the following:

The "Source" column will indicate Product Drive, Donation Site, Misc Donation or Manufacturer, corresponding to the "Source" dropdown on the new Donations page.
The "Donation Site" Column will be renamed to "Details", and will contain the following, dependent on the source.
For Product Drive, the details will be the product drive name
For Donation Site, the details will be the donation site name
For Manufacturer, the details will be the manufacturer name
For Misc Donations, the details will be the first 25 characters of the comment

Resolves #3324
Note: know that it might look like there were a lot of changes in the views, but that was just my linter doing its thing.
Screenshots
Before:

After:

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Added request tests in spec/requests/donations_requests_spec.rb
Added model tests in spec/models/donation_spec.rb
Added service tests in spec/services/exports/export_donations_csv_service_spec.rb
Small Question:
I found the column names to be a bit confusing. What exactly is "In Kind Value"? Does it refer to the total value of the items that got donated? Would it make sense to reorder the columns to reflect that?
Before:

After:

@elasticspoon question - when you say "your linter", do you mean the regular rubocop gem included in the Gemfile? I'm a little confused as to why that gem would be making changes when the linter was already passing on main previously.

It's an html linter that doing it. Not sure it prettier, or eslint, or whichever lsp I have. I hope its not an issue? I usually let it do its thing because it does a good job catching unclosed html tags.

Could you just run that linter against the entire codebase and put that up as a separate PR? And maybe we can look into adding it to our linting process in general. I'd rather keep this PR as just the change requested.


Clarify token uniqueness properties

Reading the docs it wasn't totally clear that tokens need to be unique per connection. It was implied from the aside about the official drivers implementation, but I think it would be good to make this explicit.
I'm not totally happy with the way I've worded this, I'd welcome any feedback or thoughts on ways to make this less awkward.

Also pinging @chipotle for review of the wording.

@danielcompton one more thing: We require a CLA for legal reasons before we can merge pull requests. Would you mind signing at http://rethinkdb.com/community/cla/ ?
Thanks by the way for your patch!

Done

Okay, thanks! I've added a note about the counter being unsigned and fixed the "this an" -> "this as an" typo.


mu: 1.8.7 -> 1.8.8

Description of changes
https://github.com/djcb/mu/releases/tag/v1.8.8
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 185525 run on aarch64-darwin 1

1 package marked as broken and skipped:

lbdb

1 package built:

mu


ResourceWarning: Object of type XXX is not untracked before destruction

While investigating https://github.com/pydantic/pydantic-core/issues/451 I noticed that when running on a debug build of Python, the SchemaSerializer pyclass with gc protocol support raised a warning
ResourceWarning: Object of type pydantic_core._pydantic_core.SchemaSerializer is not untracked before destruction

and caused a segfault on debug build of Python only:
collected 3134 items / 3133 deselected / 1 selected

tests/validators/test_datetime.py
Program received signal SIGABRT, Aborted.
__pthread_kill_implementation (no_tid=0, signo=6, threadid=140737350287360) at ./nptl/pthread_kill.c:44
Download failed: Invalid argument.  Continuing without source file ./nptl/./nptl/pthread_kill.c.
44	./nptl/pthread_kill.c: No such file or directory.
(gdb) bt
#0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=140737350287360) at ./nptl/pthread_kill.c:44
#1  __pthread_kill_internal (signo=6, threadid=140737350287360) at ./nptl/pthread_kill.c:78
#2  __GI___pthread_kill (threadid=140737350287360, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
#3  0x00007ffff7c97476 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#4  0x00007ffff7c7d7f3 in __GI_abort () at ./stdlib/abort.c:79
#5  0x00007ffff7c7d71b in __assert_fail_base (fmt=0x7ffff7e32150 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x77bda9 "!_PyErr_Occurred(tstate)", file=0x78fc93 "../Objects/typeobject.c", line=1068, function=<optimized out>)
    at ./assert/assert.c:92
#6  0x00007ffff7c8ee96 in __GI___assert_fail (assertion=assertion@entry=0x77bda9 "!_PyErr_Occurred(tstate)", file=file@entry=0x78fc93 "../Objects/typeobject.c", line=line@entry=1068,
    function=function@entry=0x790510 <__PRETTY_FUNCTION__.30> "type_call") at ./assert/assert.c:101
#7  0x000000000052a1c8 in type_call (type=0xa21640 <_PyExc_ResourceWarning>, args=('Object of type pydantic_core._pydantic_core.SchemaValidator is not untracked before destruction',), kwds=0x0) at ../Objects/typeobject.c:1068
#8  0x00000000004b8b15 in _PyObject_MakeTpCall (tstate=tstate@entry=0xb46058 <_PyRuntime+166328>, callable=callable@entry=<type at remote 0xa21640>, args=args@entry=0x7fffffffbba8, nargs=<optimized out>, keywords=keywords@entry=0x0)
    at ../Objects/call.c:214
#9  0x00000000004b8e91 in _PyObject_VectorcallTstate (tstate=0xb46058 <_PyRuntime+166328>, callable=<type at remote 0xa21640>, args=args@entry=0x7fffffffbba8, nargsf=<optimized out>, nargsf@entry=9223372036854775809,
    kwnames=kwnames@entry=0x0) at ../Include/internal/pycore_call.h:90
#10 0x00000000004b8f4e in PyObject_CallOneArg (func=<optimized out>, arg=<optimized out>) at ../Objects/call.c:376

#11 0x000000000058e1fd in warn_explicit (tstate=0xb46058 <_PyRuntime+166328>, category=<type at remote 0xa21640>,
    category@entry=<error reading variable: Dwarf Error: Cannot find DIE at 0x1c9 referenced from DIE at 0x3de638 [in module /root/code/pydantic-core/pydantic_core/_pydantic_core.cpython-311-x86_64-linux-gnu.so]>,
    message=message@entry='Object of type pydantic_core._pydantic_core.SchemaValidator is not untracked before destruction', filename=filename@entry='gc', lineno=lineno@entry=0, module=module@entry='gc', registry=0x0, sourceline=0x0,
    source=0x0) at ../Python/_warnings.c:671
#12 0x000000000058fe92 in PyErr_WarnExplicitFormat (category=<type at remote 0xa21640>, filename_str=<optimized out>, lineno=0, module_str=<optimized out>, registry=0x0, format=<optimized out>) at ../Python/_warnings.c:1286

Googling it leads us to https://github.com/apache/arrow/issues/33765#issuecomment-1406325427 which mentions PyObject_GC_UnTrack. According to its documentation

Remove the object op from the set of container objects tracked by the collector. Note that PyObject_GC_Track() can be called again on this object to add it back to the set of tracked objects. The deallocator (tp_dealloc handler) should call this for the object before any of the fields used by the tp_traverse handler become invalid.

It seems that we should call it in our generated tp_dealloc handler for pyclasses that use the gc protocol?

For example, here's how cython handles it:
https://github.com/cython/cython/blob/b8b378712bc74627f266f3ba6c13751af8e1991f/Cython/Compiler/ModuleNode.py#L1723-L1727

Also worth noting that according to https://github.com/apache/arrow/issues/33765#issuecomment-1406325427 the warning is new in 3.11, so you need 3.11-dbg to see it.

I took a look at this briefly today and agree with @messense that the solution is to call PyObject_GC_Untrack at the right time in tp_dealloc.
It's not immediately obvious to me how to get it right in all cases. I also think that while we're revisiting this code we can resume looking at #2479. Rather than try to rush a fix for 0.19 I think we should release without fixing this, and make this a priority fix for 0.20.


mongoconnector taking too long to sync

while performing a sync from mongodb to elasticsearch , mongo connector takes too long . there are approximately 100000 docs in mongodb . what could be the reason or is it normal to take that much time.

The elastic-doc-manager uses the streaming bulk api for the initial collection dump. The default chunk_size is 1000 but increasing that via the batchSize configuration option may improve the performance.
Are there any errors in the log?

Can you post some more details about the size of the documents and how long it's taking mongo-connector to sync?


test fs::read_link surface function

The shim got implemented a while ago but we never ensured that that is actually what std uses.

@bors r+

:pushpin: Commit b4520e459159781966d678cc0f65c8d295f523e4 has been approved by RalfJung

:hourglass: Testing commit b4520e459159781966d678cc0f65c8d295f523e4 with merge f76ebd6feb9f59be993336f84ecfdc441ad33d81...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing f76ebd6feb9f59be993336f84ecfdc441ad33d81 to master...


Catch async exceptions

Previously we weren't actually catching the top-level async exceptions. We were doing this:
try {
    cli()
} catch (err) {
    if (err instanceof Error) setFailed(err)
    else throw err
}

But instead needed this:
cli().catch(err => {
    if (err instanceof Error) setFailed(err)
    else throw err
})

Nothing has functionally changed here we just catch the errors in a cleaner manner.

GHA builds cannot push to forks, so this is superseded by #20


No icons on directory load

When opening a directory, the icons are not showing up until you select a file.

Fixed v0.8.0


Crash when using KeepAliveClientMixin with Ink as child in TabBarView

After upgrade v1.17.1, following sample cause crash.
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: TabBarDemo(),
    );
  }
}

class TabBarDemo extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: DefaultTabController(
        length: 3,
        child: Scaffold(
          appBar: AppBar(
            bottom: TabBar(
              tabs: [
                Tab(text: 'Page 1'),
                Tab(text: 'Page 2'),
                Tab(text: 'Page 3'),
              ],
            ),
          ),
          body: TabBarView(
            children: [
              Page1(),
              Page2(),
              Page3(),
            ],
          ),
        ),
      ),
    );
  }
}

class Page1 extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Text("Page 1");
  }
}

class Page2 extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Text("Page 2");
  }
}

class Page3 extends StatefulWidget {
  @override
  State<StatefulWidget> createState() {
    return _Page3State();
  }
}

class _Page3State extends State<Page3> with AutomaticKeepAliveClientMixin {
  @override
  Widget build(BuildContext context) {
    super.build(context);
    return Ink(
      child: Text("Page3"),
    );
  }

  @override
  bool get wantKeepAlive => true;
}

Steps to Reproduce

Tap the tab of page 3
Then tap the tab of Page1 to crash

Not reproduced if wantKeepAlive => false.
Not reproduce if it is not an Ink Widget.

Logs
════════ Exception caught by rendering library ═════════════════════════════════════════════════════
The following NoSuchMethodError was thrown during paint():
The method '-' was called on null.
Receiver: null
Tried calling: -(0.0)

The relevant error-causing widget was:
  Scaffold file:///Users/rls01031792/Desktop/keepAliveInTab/lib/main.dart:21:16
When the exception was thrown, this was the stack:
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:53:5)
#1      RenderSliverMultiBoxAdaptor.childMainAxisPosition (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:573:37)
#2      RenderSliverHelpers.applyPaintTransformForBoxChild (package:flutter/src/rendering/sliver.dart:1695:20)
#3      RenderSliverMultiBoxAdaptor.applyPaintTransform (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:586:5)
#4      InkFeature._paint (package:flutter/src/material/material.dart:623:26)
...

D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 0
D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 1
D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 0
D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 1
D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 0
D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 1
D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 0
D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 1
D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 0
D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 1
Reloaded 1 of 502 libraries in 722ms.
D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 0
D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 1
D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 0
D/ViewRootImpl@f66f5b1[MainActivity](22799): ViewPostIme pointer 1

════════ Exception caught by rendering library ═════════════════════════════════
The following NoSuchMethodError was thrown during paint():
The method '-' was called on null.
Receiver: null
Tried calling: -(0.0)

The relevant error-causing widget was
    Scaffold
When the exception was thrown, this was the stack
#0      Object.noSuchMethod  (dart:core-patch/object_patch.dart:51:5)
#1      RenderSliverMultiBoxAdaptor.childMainAxisPosition
#2      RenderSliverHelpers.applyPaintTransformForBoxChild
#3      RenderSliverMultiBoxAdaptor.applyPaintTransform
#4      InkFeature._paint
...
The following RenderObject was being processed when the exception was fired: _RenderInkFeatures#2772d
RenderObject: _RenderInkFeatures#2772d
    needs compositing
    parentData: <none> (can use size)
    constraints: BoxConstraints(w=411.4, h=876.6)
    size: Size(411.4, 876.6)
    child: RenderCustomMultiChildLayoutBox#0d9b2 NEEDS-PAINT
        needs compositing
        parentData: <none> (can use size)
        constraints: BoxConstraints(w=411.4, h=876.6)
        size: Size(411.4, 876.6)
        child 1: RenderRepaintBoundary#98e4a relayoutBoundary=up1
            needs compositing
            parentData: offset=Offset(0.0, 135.6); id=_ScaffoldSlot.body (can use size)
            constraints: BoxConstraints(0.0<=w<=411.4, 0.0<=h<=741.0)
            layer: OffsetLayer#c6a9d DETACHED
                engine layer: OffsetEngineLayer#9341f
                offset: Offset(0.0, 135.6)
            size: Size(411.4, 741.0)
            metrics: 98.9% useful (1 bad vs 89 good)
            diagnosis: this is an outstandingly useful repaint boundary and should definitely be kept
            child: RenderCustomPaint#d64b2 relayoutBoundary=up2
                needs compositing
                parentData: <none> (can use size)
                constraints: BoxConstraints(0.0<=w<=411.4, 0.0<=h<=741.0)
                size: Size(411.4, 741.0)
                child: RenderRepaintBoundary#787d9 relayoutBoundary=up3
                    needs compositing
                    parentData: <none> (can use size)
                    constraints: BoxConstraints(0.0<=w<=411.4, 0.0<=h<=741.0)
                    layer: OffsetLayer#1f032 DETACHED
                        engine layer: OffsetEngineLayer#f507b
                        offset: Offset(0.0, 0.0)
                    size: Size(411.4, 741.0)
                    metrics: 66.7% useful (1 bad vs 2 good)
                    diagnosis: insufficient data to draw conclusion (less than five repaints)
        child 2: RenderConstrainedBox#2521e relayoutBoundary=up1 NEEDS-PAINT
            needs compositing
            parentData: offset=Offset(0.0, 0.0); id=_ScaffoldSlot.appBar (can use size)
            constraints: BoxConstraints(w=411.4, 0.0<=h<=876.6)
            size: Size(411.4, 135.6)
            additionalConstraints: BoxConstraints(0.0<=w<=Infinity, 0.0<=h<=135.6)
            child: RenderSemanticsAnnotations#fa259 relayoutBoundary=up2 NEEDS-PAINT
                needs compositing
                parentData: <none> (can use size)
                constraints: BoxConstraints(w=411.4, 0.0<=h<=135.6)
                semantic boundary
                size: Size(411.4, 135.6)
                child: RenderAnnotatedRegion<SystemUiOverlayStyle>#127bc relayoutBoundary=up3 NEEDS-PAINT
                    needs compositing
                    parentData: <none> (can use size)
                    constraints: BoxConstraints(w=411.4, 0.0<=h<=135.6)
                    size: Size(411.4, 135.6)
        child 3: RenderStack#68fff relayoutBoundary=up1
            parentData: offset=Offset(395.4, 860.6); id=_ScaffoldSlot.floatingActionButton (can use size)
            constraints: BoxConstraints(0.0<=w<=411.4, 0.0<=h<=876.6)
            size: Size(0.0, 0.0)
            alignment: centerRight
            textDirection: ltr
            fit: loose
            overflow: clip
            child 1: RenderTransform#0a404 relayoutBoundary=up2
                parentData: not positioned; offset=Offset(0.0, 0.0) (can use size)
                constraints: BoxConstraints(0.0<=w<=411.4, 0.0<=h<=876.6)
                size: Size(0.0, 0.0)
                transform matrix: [0] 0.0,0.0,0.0,0.0
[1] 0.0,0.0,0.0,0.0
[2] 0.0,0.0,1.0,0.0
[3] 0.0,0.0,0.0,1.0
                origin: null
                alignment: center
                textDirection: ltr
                transformHitTests: true
                child: RenderTransform#06553 relayoutBoundary=up3
                    parentData: <none> (can use size)
                    constraints: BoxConstraints(0.0<=w<=411.4, 0.0<=h<=876.6)
                    size: Size(0.0, 0.0)
                    transform matrix: [0] 0.7,0.7,0.0,0.0
[1] -0.7,0.7,0.0,0.0
[2] 0.0,0.0,1.0,0.0
[3] 0.0,0.0,0.0,1.0
                    origin: null
                    alignment: center
                    textDirection: ltr
                    transformHitTests: true
════════════════════════════════════════════════════════════════════════════════

flutter doctor -v
[✓] Flutter (Channel dev, 1.19.0-1.0.pre, on Mac OS X 10.15.4 19E287, locale en-GB)
    • Flutter version 1.19.0-1.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision 456d80b9dd (9 days ago), 2020-05-11 11:45:03 -0400
    • Engine revision d96f962ca2
    • Dart version 2.9.0 (build 2.9.0-7.0.dev 092ed38a87)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/tahatesser/Code/SDK
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/tahatesser/Code/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.45.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.10.2

[✓] Connected device (5 available)
    • SM M305F      • 32003c30dc19668f          • android-arm64  • Android 10 (API 29)
    • Taha’s iPhone • 00008020-001059882212002E • ios            • iOS 13.4.1
    • macOS         • macOS                     • darwin-x64     • Mac OS X 10.15.4 19E287
    • Web Server    • web-server                • web-javascript • Flutter Tools
    • Chrome        • chrome                    • web-javascript • Google Chrome 81.0.4044.138

• No issues found!

Looks like someone beat me to it.  My stack trace is slightly different but I'm convinced it is the same issue:
flutter: ══╡ EXCEPTION CAUGHT BY SCHEDULER LIBRARY ╞═════════════════════════════════════════════════════════
flutter: The following NoSuchMethodError was thrown during a scheduler callback:
flutter: The method '-' was called on null.
flutter: Receiver: null
flutter: Tried calling: -(0.0)
flutter:
flutter: When the exception was thrown, this was the stack:
flutter: #0      Object.noSuchMethod (dart:core-patch/object_patch.dart:53:5)
flutter: #1      RenderSliverMultiBoxAdaptor.childMainAxisPosition (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:573:37)
flutter: #2      RenderSliverHelpers.applyPaintTransformForBoxChild (package:flutter/src/rendering/sliver.dart:1695:20)
flutter: #3      RenderSliverMultiBoxAdaptor.applyPaintTransform (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:586:5)
flutter: #4      RenderObject.getTransformTo (package:flutter/src/rendering/object.dart:2345:24)
flutter: #5      EditableTextState._updateSizeAndTransform (package:flutter/src/widgets/editable_text.dart:1815:48)
flutter: #6      EditableTextState._updateSizeAndTransform.<anonymous closure> (package:flutter/src/widgets/editable_text.dart:1818:49)
flutter: #7      SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1113:15)
flutter: #8      SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1060:9)
flutter: #9      SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:968:5)
flutter: #13     _invoke (dart:ui/hooks.dart:261:10)
flutter: #14     _drawFrame (dart:ui/hooks.dart:219:3)
flutter: (elided 3 frames from dart:async)
flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════
flutter: Another exception was thrown: NoSuchMethodError: The method '-' was called on null.

My flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.17.1, on Mac OS X 10.15.4 19E287, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
[✓] Android Studio (version 3.6)
[✓] VS Code (version 1.45.1)
[✓] Connected device (1 available)

• No issues found!

I have the same exact error when I pass from tab 3 to tab 1 and I have the focus on a TextField.
I don't have any Ink or KeepAliveClientMixin

I spent some time trying to bisect this and it looks like the regression was introduced in:
https://github.com/flutter/flutter/commit/13fa5734f8df9c8b2e9b81c8228cee51f2fa783d
@chunhtai can you take a look?

Finished investigation, it is due to the material in scaffold tries to paint all the ink features in its subtree. The ink widget was kept alive and does not get destroy, so the material widget still try to paint it even if it is not visible. Usually that is fine, but the tab view will rearrange its children when switching more than two tab. This cause the layout offset of the children to become null.
It won't crash prior to my change because the child keeps the wrong layout offset after the rearrange. This maybe problematic as well because that might cause the ink feature paints itself with incorrect transformation.


The Duplicate action for Current Session in Sessions Pane doesn't work

@luisvasq @connor-makowski Caused by flickering bug so the form for creating the duplicate session wouldn't be visible and you couldn't scroll down to it. Scroll bar would also not show up in some scenarios. Resolved in https://github.com/MIT-CAVE/cave_static/pull/579.

Thanks, @brianzheng205! Those bugs were annoying.


Update admin-organization-new page to new template

Resolves #867 mostly :) I am not very familiar with Bootstrap (or design in general) so the form fields may need some additional love.
I broke out the organization form into a partial to follow what appears to be a convention for the app.

:+1:

Looks like Travis choked -- restarting the build!

@armahillo what does that mean? 😮

@tomrossi7 "Travis" is our continuous integration service -- it runs our tests in a neutral and consistent environment and ensures that PRs pass green before we merge them. Sometimes it can get overwhelmed and just weirdly fail. We hammered it pretty hard today so I think that's what happened.
Looks like it blew up a second time -- I'm not sure why, but I restarted it again.

We're going to have broken tests until the entire site has been ported over. Thanks so much for this!


The total amount of cart items should be correct.

Bagisto Version: Master
Steps To reproduce--
1. Visit the shop
2. Add any bundle product into the cart.
3.  Again add the same item into the cart.
4. View the shopping cart
Expected result: The Subtotal of cart items should be correct.
Actual result: The total amount of cart items is not correct. Please find the screen recording Here.

@jitendra-webkul
Not fixed. please check with the velocity theme.
Please find the screen recording Here.

@jitendra-webkul
Thanks, now this issue is fixed. so I am closing this issue.
And i have attached a screenshot [Here].for future reference.


Use production Intercom ID for Desktop App

It seems like we are using the ID for the Test Intercom Workspace in the Desktop App currently. We should change it to use the production ID.

This has been recently updated in the repo settings.


#35: angus activation does not provide its services in an OSGi environment

fixes #35

Thanks for testing this. I'll apply the same change to other projects in the next few days. Thanks!

Thanks for testing this. I'll apply the same change to other projects in the next few days. Thanks!

BTW I'm pondering about this since yesterday: why did you add these osgi.service;objectClass=... "statements"?

Do you think it can go away?

Yes, see https://github.com/eclipse-ee4j/angus-activation/pull/37. Going to test for angus mail as well.


Auction banner

This is work towards #974. The infrastructure is acceptable for now until we get https://github.com/artsy/mobile/issues/65 figured out, but I've tried to keep things as loose as possible so we don't get locked in or anything.
The following view controllers:

ARArtistViewController
ARFairArtistViewController
ARShowViewController

Had common code in them that I needed, so I abstracted it into a new UIViewController extension. Spacecommander went to town on those files, so the PR is smaller than it appears.

Realistically, this could be merged as-is, since the current master behaviour is just a blank page. Orta square seems like ... an improvement? ¯\(ツ)/¯

Not sure if I understand the CI failure: https://circleci.com/gh/artsy/eigen/1228

/Users/distiller/eigen/vendor/bundle/ruby/2.0.0/bundler/gems/danger-4a55d52b76c4/lib/danger/environment_manager.rb:24:in `initialize': Could not find a CI source (RuntimeError)

Hrm, any thoughts on how to deal with this? https://github.com/artsy/eigen/issues/585#issuecomment-170892244
Ah no, in Swift this is fine, they have the same module name - whahaha HAX

This is :green_apple:

shipped it


AnyHttpUrl failing validation with Postgresql

Checks

[X ] I added a descriptive title to this issue
[ X] I have searched (google, github) for similar issues and couldn't find anything
[ X] I have read and followed the docs and still think this is a bug

Bug
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
             pydantic version: 1.6.1
            pydantic compiled: True
                 install path: /Users/Shawn/project/.venv/lib/python3.8/site-packages/pydantic
               python version: 3.8.2 (default, Sep 24 2020, 19:37:08)  [Clang 12.0.0 (clang-1<IP_ADDRESS>)]
                     platform: macOS-10.15.7-x86_64-i386-64bit
     optional deps. installed: ['typing-extensions', 'email-validator']

I'm having a strange issue with validating a Pydantic BaseModel, sending the data as a Body parameter with FastAPI. I have setup a Joined Table inheritance in my SqlAlchemy models (against Postgresql 12) as shown below (following the docs:

class Employee(Base):
    __tablename__ = "employee"
    __mapper_args__ = {"polymorphic_identity": "employee", "polymorphic_on": "employee_type"}
    id = Column(Integer, primary_key=True, index=True)
    ...
    employee_type = Column(String, nullable=False)

class Manager(Employee):
    __tablename__ = "manager"
    __mapper_args__ = {"polymorphic_identity": "manager_employee"}
    id = Column(Integer, ForeignKey("employee.id"), primary_key=True, index=True)
    text = Column(String, nullable=False)

class Engineer(Employee):
    __tablename__ = "engineer"
    __mapper_args__ = {"polymorphic_identity": "engineer_employee"}
    id = Column(Integer, ForeignKey("employee.id"), primary_key=True, index=True)
    link_url = Column(String, nullable=False)

I then have setup Pydantic BaseModel Create schemas as shown below. The EmployeeCreate schema is designed to take either text, in the case of a Manager being submitted, or link_url if an Engineer is submitted.
class EmployeeBase(BaseModel):
    title: str

    class Config:
        arbitrary_types_allowed = True
        orm_mode = True

class EmployeeCreate(EmployeeBase):
    text: Optional[str]
    link_url = Optional[AnyHttpUrl]

My route, to handle creating a new Manager or Engineer:
async def create_employee(division_id: int, emp_create: EmployeeCreate):
    ...

Everything works fine when I submit my body parameters with a text key, like so:
{"title":"Manager", "text":"some text"}
If I submit a url, though, with the link_url key, like so:
{"title":"Engineer", "link_url":"https://www.google.com/"}
I get 422 Unprocessable Entity. When I step through the code, I see that I'm failing validation (Pydantic.fields.py, line 725, _apply_validators, for some reason I can't step into that code), and the error I'm getting back from fastapi is:
{
    "detail": [
        {
            "loc": [
                "body",
                "link_url"
            ],
            "msg": "instance of _GenericAlias expected",
            "type": "type_error.arbitrary_type",
            "ctx": {
                "expected_arbitrary_type": "_GenericAlias"
            }
        }
    ]
}

I'm also seeing problems returning from Postgresql, shown below:
sqlalchemy.exc.ProgrammingError: (psycopg2.ProgrammingError) can't adapt type '_GenericAlias'
[SQL: INSERT INTO engineer (id, link_url) VALUES (%(id)s, %(link_url)s)]
[parameters: {'id': 9, 'link_url': typing.Union[pydantic.networks.HttpUrl, NoneType]}]

Is this a Pydantic bug, or am I missing something really simply here. Thank you!

You have an equals sign instead of a colon:
link_url = Optional[AnyHttpUrl]

This should be:
link_url: Optional[AnyHttpUrl]

Well, I'm embarrassed. Thank you for your kind response.


Incorrect link in the first Zipline challenge description

http://www.freecodecamp.com/challenges/zipline-use-the-twitch.tv-json-api
In the 13th checkbox item, the link is pointing to JQuery.each() rather than the getJSON()

This was fixed in #937 and should be in production soon, please close this issue in the mean time.


Prisma2 and Docker

Hello,
I search for this but not  found.
I see the tutorial from Code Mochi and I clearly don’t understand some docker configurations. So I ask if there will be an official docker image for running prisma2 ? thanks

Hi,
We are releasing Prisma 2 as a library rather than a server. So you will use it as just another dependency for your application. So will create a docker image just like for another node app(or any other language we will support in the future).

But usually we exclude node_modules folder, here we have to find a nice way to include the generated photon, etc

You can configure the output property.
generator js {
	provider = "photonjs"
	output = "./generated/photon"
}

That way you can generate photon anywhere you want

I am trying to dockerize a Nest application with Prisma2 and I used your tip @harri121 and prisma2 generate works but is showing the following errors:
> prisma2 generate

Generating Photon.js Client to /usr/src/app/node_modules/@generated/photon
Done in 5.09s

npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

The repo is available here https://github.com/marcjulian/nest-prisma2

These warnings are normal.
I think our watcher depends upon the chokidar npm library which depends on fs-events which is mac specific package. npm will just skip its installation.
Read more here: https://github.com/fsevents/fsevents

Okay good to know, so I can just ignore the warnings.

@yovanoc thanks for checking out code mochi and sorry that I didn't notice this issue earlier- definitely let me know over on the site if you have any issues with running prisma 2 in the docker environment. The idea is to exclude copying the node_modules from your computer and instead running npm install as a line in the Dockerfile so that you install everything using a linux operating system instead of your native OS. By the same logic, generating the @generated folder in the docker environment instead of your native os is definitely a good best practice.
@harri121 's Dockerfile looks great as well- thaks for including that!

Can we have an example with a monorepo (yarn workspaces) ?

@yovanoc Can you please open a separate issue for that?

https://github.com/prisma/prisma2/issues/400 , done :)

@divyenduz Please create a example for this.

Example PR: https://github.com/prisma/prisma-examples/pull/746

An example of docker exists here: https://github.com/prisma/prisma-examples/tree/prisma2/deployment-platforms/docker
I am closing this issue, please re-open a new issue if there is anything more specific that you are interested in.
Thanks 🙌

https://github.com/prisma/prisma-examples

Hi @divyenduz
The example doesn't seem to exist on GitHub anymore. Is it possible for you to have a look and resend the correct link for it?
Thanks

The PR still exists @Muntasir2001 and shows the code that was used back then: https://github.com/prisma/prisma-examples/pull/746/files You can see that it does not actually do anything Prisma specific - as Prisma is just a library, all you need to do is to make your applicaiton run in Docker, and then make your application use Prisma as it would in any deployment situation.

The PR still exists @Muntasir2001 and shows the code that was used back then: https://github.com/prisma/prisma-examples/pull/746/files You can see that it does not actually do anything Prisma specific - as Prisma is just a library, all you need to do is to make your applicaiton run in Docker, and then make your application use Prisma as it would in any other deployment situation.

Just like what I thought, thanks @janpio