[Step 3] Remove CARD_LIST key from NewDot

Details

Now that Web is sending user card info to fundList, we can remove the cardList key entirely from App.
App PR that added dual support for cardList and fundList - https://github.com/Expensify/App/pull/23242
Web PR to send data to fundList- https://github.com/Expensify/Web-Expensify/pull/38226
Fixed Issues

$ https://github.com/Expensify/App/issues/23559
Tests

[ ] Verify that no errors appear in the JS console
[ ] Verify that we no longer reference ONYXKEYS.CARD_LIST
[ ] Verified that I updated all the temporary changes in https://github.com/Expensify/App/pull/23242/files

WEB:
For each of the following cases:

[ ] Open the console and past these blocks
[ ] Go to settings/payments page
[ ] Ensure that the correct card is listed.

[ ] Case 1: card Test cardList card ending in 4242 appears

Case 1: user has fundList data
Onyx.merge('fundList',
{
  "4": {
    "title": "Test fundlist card",
    "description": "Card ending in 0000",
    "methodID": 4,
    "key": "card-4",
    "accountType": "debitCard",
    "accountData": {
      "additionalData": {
        "isBillingCard": false,
        "isP2PDebitCard": true
      },
      "addressName": "Test fundlist card",
      "addressState": "US",
      "addressStreet": "Street",
      "addressZip": 75092,
      "cardMonth": 12,
      "cardNumber": "424242XXXXXX0000",
      "cardYear": 2026,
      "created": "2023-01-13 22:27:23",
      "currency": "USD",
      "fundID": 4
    },
    "isDefault": true
  }
}
);

Onyx.set('cardList', null);

Case 2: user has fundList data with errors set
Onyx.merge('fundList',
{
  "4": {
    "errors": {"test": "example error"},
    "title": "Test fundlist card",
    "description": "Card ending in 0000",
    "methodID": 4,
    "key": "card-4",
    "accountType": "debitCard",
    "accountData": {
      "additionalData": {
        "isBillingCard": false,
        "isP2PDebitCard": true
      },
      "addressName": "Test fundlist card",
      "addressState": "US",
      "addressStreet": "Street",
      "addressZip": 75092,
      "cardMonth": 12,
      "cardNumber": "424242XXXXXX0000",
      "cardYear": 2026,
      "created": "2023-01-13 22:27:23",
      "currency": "USD",
      "fundID": 4
    },
    "isDefault": true
  }
}
);

Onyx.set('cardList', null);

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console
[ ] Add a debit card, ensure that card is listed on the payments page
[ ] Add a second debit card, ensure that card is listed on the payments page
[ ] Make the second card the default payment card, ensure that card is set as default card without error
[ ] Remove a debit card, ensure that card is removed without error

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Cleared cache, logged in and out. Note ONLY fundList key:

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Emulator not working :(

Tested this in Web, works fine. I am not added to the betas to add the Debit card, but I've manually set the data and checked. I've also forced adding cardList to test if we see any double records, etc.  Will finish other platforms in a few hours..

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I am kind of stuck on Android build, as it's taking ages to complete. I'll upload the screenshot as soon as it is ready.

@grgia This is complete from my end.
🎀 👀 🎀 C+ reviewed.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.56-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Gonna check this one off I'm able to see my debit card in NewDot so the migration to fundList worked great.

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Copying from Azure Files (SAS) -> Azure Blob (SAS)

Which version of the AzCopy was used?
AzCopy 10.8.0
Which platform are you using? (ex: Windows, Mac, Linux)
Windows
What command did you run?
azcopy copy {file} {gen 2 blob} --recursive --from-to FileBlobFS
What problem was encountered?
failed to parse user input due to error: invalid --from-to value specified: "Fil
eBlobFS". Valid values are two-word phases of the form BlobLocal, LocalBlob etc.
  Use the word 'Blob' for Blob Storage, 'Local' for the local file system, 'File
' for Azure Files, and 'BlobFS' for ADLS Gen2. If you need a combination that is
 not supported yet, please log an issue on the AzCopy GitHub issues list.

How can we reproduce the problem in the simplest way?
Try copy command with --from-to FileBlobFS
Have you found a mitigation/solution?
No

Hi, please try FileBlob, since {gen 2 blob} is the same as {blob}=just a regular blob endpoint.


Typed Data

Currently the parser returns arrays and stdClass objects, and the serializer expects the same.
It would probably be helpful to have Item, List, InnerList, Dictionary, Parameters classes.  I don't think classes for bare items are necessary (other than the existing Bytes and Token, which are needed to differentiate from strings).
Providing array / property access should be able to retain compatibility with existing code that expects un-typed data.

Item and InnerList are tuples that contain a value and parameters fields, which should remain accessible by index (0 and 1) to be compatible with the current array format.
List is a numerically indexed array
Dictionary, and Parameters are ordered maps

The Go implementation offers some typed functionality (https://dunglas.fr/2020/08/a-structured-http-fields-parser-and-serializer-for-the-go-programming-language/)
d := sfv.NewDictionary()
d.Add("b", sfv.NewItem(false))

bar := sfv.NewItem(sfv.Token("bar"))
bar.Params.Add("baz", 42)
d.Add("a", bar)


An addition to the curated list on your website

Hi, great project!
Not sure where to contribute this, so I am choosing the easy route here: Thought you might want to include this python package to your curated list: https://github.com/django-json-api/django-rest-framework-json-api
It is a very nice python implementation wrapping Django APIs. I am using it and it seems to have some tracktion.

Thanks a lot for your suggestion. The library has been added to the list in the meantime. I think this issue could be closed.


Docker build should not remove heron-core.tar.gz

The file /usr/local/heron/dist/heron-core.tar.gz is used during heron submit command. This file should not be removed during docker build, otherwise heron submit will not succeed.

KK. Make sense. It was removed to reduce image size, but "docker run" was used for testing instead of "heron submit". This change makes sense. We will find another way to reduce size later.
Thanks.


RS and ES algorithms doesn't work in nodejs

Only HS256, HS348 and HS512 works in node js.(i'm using node js 6.x)
and RS256, RS348, RS512, ES256, ES348 and ES512 doesn't work.
the following code is right:
return jwt.sign({ foo : "bar"}, "MY_SECRET", { algorithm: 'HS512'}, function(err, token) {
console.log(token);
});
but this code logs "undefined" and  return an empty object (for all RS and ES algorithms):
return jwt.sign({ foo : "bar"}, "MY_SECRET", { algorithm: 'RS512'}, function(err, token) {
console.log(token);
});

It does work but MY_SECRET is not a valid certificate.
The callback is returning an error and not a token.

@jfromaniello
MY_SECRET is an example, i will change it with a variable from database later.
according to docs The callback returning an error and a token
// sign asynchronously
jwt.sign({ foo: 'bar' }, cert, { algorithm: 'RS256' }, function(err, token) {
console.log(token);
});
but this isn't my problem. please see the picture...

@jfromaniello
this error is returning:
error:0906D06C:PEM routines:PEM_read_bio:no start line
at Error (native)
at Sign.sign (crypto.js:276:26)
at Object.sign (C:\Apps\node_modules\jwa\index.js:54:45)
at jwsSign (C:\Apps\node_modules\jws\lib\sign-stream.js:23:24)
at SignStream.sign (C:\Apps\node_modules\jws\lib\sign-stream.js:49:21)
at SignStream. (C:\Apps\node_modules\jws\lib\sign-stream.js:37:12)
at DataStream.g (events.js:286:16)
at emitNone (events.js:86:13)
at DataStream.emit (events.js:185:7)
at DataStream. (C:\Apps\node_modules\jws\lib\data-stream.js:32:12)
at _combinedTickCallback (internal/process/next_tick.js:67:7)
at process._tickCallback (internal/process/next_tick.js:98:9)

Thats expected. It will not work with an opaque secret. For asymmetric
signatures you need a valid certificate, the secret is a cert.
You can check the test folder for more examples.
El El sáb, 16 de jul de 2016 a las 4:43 a.m., davidtt80 <
<EMAIL_ADDRESS>escribió:

@jfromaniello https://github.com/jfromaniello
this error is returning:
error:0906D06C:PEM routines:PEM_read_bio:no start line
at Error (native)
at Sign.sign (crypto.js:276:26)
at Object.sign (C:\Apps\node_modules\jwa\index.js:54:45)
at jwsSign (C:\Apps\node_modules\jws\lib\sign-stream.js:23:24)
at SignStream.sign (C:\Apps\node_modules\jws\lib\sign-stream.js:49:21)
at SignStream. (C:\Apps\node_modules\jws\lib\sign-stream.js:37:12)
at DataStream.g (events.js:286:16)
at emitNone (events.js:86:13)
at DataStream.emit (events.js:185:7)
at DataStream. (C:\Apps\node_modules\jws\lib\data-stream.js:32:12)
at _combinedTickCallback (internal/process/next_tick.js:67:7)
at process._tickCallback (internal/process/next_tick.js:98:9)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/auth0/node-jsonwebtoken/issues/229#issuecomment-233118121,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAK5UB0EN0e1uTsmr56ohhItGBKbQtJ_ks5qWIuHgaJpZM4JNXYX
.


Installation instructions and tests should be improved

Here's what I did.

Checked out the project: worked (duh)
Ran ./gradlew sync: worked
Ran ./gradlew check: failed

Some tests failed because external executables such as hg could not be found; should skip these tests.
Some tests failed because internal dependencies such as /scanner/src/funTest/assets/scanners/scancode-toolkit/ could not be found; should just work.

Turns out that for that last issue, pulling git submodules gets one step further, so that should be added to the instructions.
But the test case still fails; the subsequent step that looks for configure in the same directory now works. I'm wondering why you're looking for configure if not to build binaries in that directory, and if so, why they're not built.
Lastly, gradlew check at some point just hangs, or seems to hang, with no indication what's going on. I killed it after about 15 minutes run-time.
At this point I'd abandon the project unless I had immediate need for it. I'm not sure how non-technical folk just interested in a compliance tool would react :)

Thanks for the report, we'll improve the README.md. While working on that, out of curiosity, what is ./gradlew sync supposed to do? We do not define a sync task in our project, so it should fail, and so it does for me, but you say it worked for you?

README.md improvements are at https://github.com/heremaps/oss-review-toolkit/pull/400.

All linked improvements from my previous comment have been merged. If you encounter more hurdles, please file them as new specific issues. Thanks!


WebApp front-end

Implement a bootstrap-like front-end for Maracas REST letting users analyze whatever PR/artifact they want.

GPT-4 somehow implemented that for us: https://github.com/alien-tools/maracas-webapp


Remember GUI parameters after restarting like in 0.9.1

Hi,
I highly appreciate that dev on SplitShow is continued. I'm using it over years in version 0.9.1 and it served very well. :-)
In 0.9.6, I immediately missed the behaviour that once closed, it opens again with the same file loaded previously. Especially since it doesn't auto-reload (see #25) a changed pdf when recompiling LaTeX, it has been very useful to just close SplitShow and then re-open it.
Also I noticed that:

Window size is reset after restart. In 0.9.1, it remembered the size (I resize it to maximal screen width at ratio-specific optimal height).
"Open recent" dialog is always empty.
Dragging a PDF onto the dock icon which is also very useful worked in 0.9.1, but not anymore in 0.9.6.

Good points. Should not be too hard to add these features. I will have a look when I have some spare time.

The "Open recent" dialog should be working with the changes in 0a0b6304c2dc376431bea6c848fa58e8fc06332a and dec25b6f605de669b7df75bf0257fae3ef4d6ceb respectively. I have not created a new release yet but I will do after I looked into the other things.

"Open recent" and dropping PDFs on the item should work now.
I will have a look at the window size and the other ideas later.

Should all work now in version 0.9.8.


[Feature] Pyqtorch - First Order Adjoint Differentiation

Fixes https://github.com/pasqal-io/qadence/issues/97
This MR adds a "adjoint" differentiation mode to qadence which is a implementation of Algorithm 1 of https://arxiv.org/pdf/2009.02823.pdf.
Limitations:

The adjoint method is only available in the pyqtorch backend
Parametric observables are not supported
Multiple observables are not supported
Higher order derivatives are not natively supported by the adjoint method but torch.autograd can be used on the gradients returned by the adjoint method.
Only expectation values can be differentiated, not wave functions

Additional, non-adjoint-related changes:

Removal of gradient checkpointing (raising a UserWarning if requested)
Utility methods for the pyqtorch backends to convert/validate qadence/ pyqtorch states
Many new tests comparing gradients between ad, adjoint and gpsr
Rework of _set_backend_config

Remaining todos:

[ ] Optimize HamEvo derivatives for time_evo and generators (currently done via finite differencing)

Are we moving adjoint diff from pyqtorch to qadence?

@nmheim, cant reply to your comment directly. we need our own qadence adjoint because we need to handle custom backward passes for nested circuits, and scaleblocks

@nmheim
`def test_niklas() -> None:
theta_param = VariationalParameter('theta')
theta_val = torch.rand(1, requires_grad=True)
block = chain(RX(0, theta_param2), RY(0, -theta_param2))
exp_adjoint = expectation(block, Z(0), values={'theta': theta_val}, diff_mode='adjoint')
exp_ad = expectation(block, Z(0), values={'theta': theta_val}, diff_mode='ad')
grad_adjoint = torch.autograd.grad(exp_adjoint, theta_val, torch.ones_like(exp_adjoint))[0]
grad_ad = torch.autograd.grad(exp_ad, theta_val, torch.ones_like(exp_ad))[0]

assert torch.allclose(grad_ad,grad_adjoint)`

passes (ofc)
is there something unclear about what happening when parameters are reused?

@nmheim
`def test_niklas() -> None: theta_param = VariationalParameter('theta') theta_val = torch.rand(1, requires_grad=True) block = chain(RX(0, theta_param2), RY(0, -theta_param2))
exp_adjoint = expectation(block, Z(0), values={'theta': theta_val}, diff_mode='adjoint')
exp_ad = expectation(block, Z(0), values={'theta': theta_val}, diff_mode='ad')
grad_adjoint = torch.autograd.grad(exp_adjoint, theta_val, torch.ones_like(exp_adjoint))[0]
grad_ad = torch.autograd.grad(exp_ad, theta_val, torch.ones_like(exp_ad))[0]

assert torch.allclose(grad_ad,grad_adjoint)`

passes (ofc) is there something unclear about what happening when parameters are reused?

I was just wondering if we have a test somewhere that checks this with a non-trivial parameter expression to make sure that the pytorch's native autodiff is taking over correctly

are we preventing user-level parameters somehow? I remember us talking about concerns about correctness in that case?

what are "user-facing" parameters to you? expression level? if yes, then yes, we need gate-level parameters.

just wondering how the gate-level params are enforced, is that done automatically when choosing the diff_mode?

are we preventing user-level parameters somehow? I remember us talking about concerns about correctness in that case?

what are "user-facing" parameters to you? expression level? if yes, then yes, we need gate-level parameters.

just wondering how the gate-level params are enforced, is that done automatically when choosing the diff_mode?

@nmheim here https://github.com/pasqal-io/qadence/blob/ds/adjoint/qadence/extensions.py#L97


source of the miniimagenet dataset

hi, very nice work.
where could I download the MiniImageNet dataset ? or should I download the whole imagenet instead?

Hi,
We use the split and images reorganized by Sachin Ravi, please email him to obtain the link of the dataset.
This repo also provides the pickle form of the dataset.

Hi,
We use the split and images reorganized by Sachin Ravi, please email him to obtain the link of the dataset.
This repo also provides the pickle form of the dataset.

Thanks a lot


Implement delete for all core plugin entries except the volume package

The volume package will be a bit more involved, so that work will be done separately.

Any activity that'd be useful to log here? The implementations seem simple enough that I figured there was no need.

Updated to address the feedback. Also filed https://github.com/puppetlabs/wash/issues/561 to track versioned buckets.

Supports #479.


fix(tabs): re-align ink bar on direction change

Re-aligns the ink bar if the user's layout direction changed.
Fixes #3615.

Addressed the feedback @jelbourn.


Must append Out-Host to command line on some machines to get piped objects to print as they are produced.

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
I have a function that outputs objects on a loop (parsed data from a log file).  As new data is written to the log, the script parses it and outputs it.
On some machines, the output is not printed unless I append Out-Host to the command line.  For example, with the following function:
function foo {
  param([switch]$Wait,[int]$For = 150, [int]$Count = 10)

  while($Wait -or $Count--) {
    Write-Debug "Producing object..."
    Start-Sleep -Milliseconds $For
    [PSCustomObject]@{
      A = 123
      B = 456
      C = Get-Random
    }
  }
}

On most machines, this command foo -Wait -For 500 |Select A,C will start outputting tabular data as expected.  As new items are added, they will be appended to the table.
However, on some machines, this prints nothing to output.  You can use the debug messages to confirm it's still procesning regularly (an on a working machine they will be interleaved with to table output), so I know it's not actually blocked.
However if I run foo -Wait -For 500 | Select A,C | Out-Host then it prints data as expected.
This bug resulted from the discussion that occurred from this Stack Overflow question
Expected behavior
Objects piped to the output should be printed as they are produced:

foo -Wait -For 500 | Select A,C

Actual behavior
No output is printed until the function exits unless Out-Host is appended to the command line

foo -Wait -For 500 | Select A,C | Out-Host # This prints data as it's produced
foo -For 500 | Select A,C # This waits until all data has been produced (10 items by default) and then prints.

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      7.3.5
PSEdition                      Core
GitCommitId                    7.3.5
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

Aaaaaaaaaaah shooot...
Okay, this is my fault.  A few years ago I was doing something in Powershell and ended up overriding Out-Default in my powershell profile.
I've been dragging this profile around for quite some time (since the Windows Powershell only days I think?) and totally forgot about this.
function Out-Default {
  $input | Tee-Object -var global:last | Microsoft.PowerShell.Core\out-default
}

Since this isn't a pipeline function, it blocks as it gathers everything into $input before passing it onto Tee-Object which is causing the default formatting to break.
Yes, I've been trying to figure this out for days and FINALLY only moments after submitting a bug about it I uncovered the problem!


Update site UI, left nav menus, home page. …

Switch to bootstrap framework, Less.js, and Font Awesome. This CL introduces a new and, perhaps, temporary logo. If we don't want to use the logo, we need an alternate plan, perhaps a text logo.

Wow lots of stuff, thanks Andy! LGTM :)


R3.5

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

Using toolchain directly in this manner is deprecated.  Consider using the compilers outlined here.

The missing dependency for R 3.5 is there now.


add isFeedType, isMsgType, isBlobType

generalise some of the type checkers such that e.g.

isFeed behaves the same
isFeedType checks for things which follow the general pattern for a string encoded feed

published

isFeedType(string), isMsgType (string), isBlobType(string)

Hey @mixmix, this is a decent addition and I don't have any objections to it. It's great you have @chereseeriepa in the same locality and can get timely code reviews.
This PR is fine, nothing needs to be done about it, but I have some feedback on how to structure a PR in general, as we are cooperating on PRs this week it seems. I'm using this one just as an example because it's an easier one to comment on.
Small PRs are generally the best to review, because they are easier to review, nothing is out of context, it's easier to predict how the new code will behave, it's easier to see in the future with a git blame why something was changed. I noticed you tend to make rather large PRs, or at least you bundle a couple of extra decisions into the same PR or even the same commit.
For instance in this case, the PR title is add isFeedType, isMsgType, is BlobType. That sets up the expectation that this is the only change this the PR does, but in reality it also did some shuffling around and refactoring of isMultiServerAddress and other things. In this case it's easy to see that it's unrelated to the addition of the new APIs, but it's not always easy to spot an extra refactor and separate it from the primary changes.
So I would recommend splitting these changes, at least put them in different commits, so the reviewer can click on a commit and look at only one "context" at a time. The ideal scenario is 1 commit per PR (unless you're doing 1st test, 2nd fix), so sometimes I "work on several aspects at once" and then I split those several changes into many commits, and for each commit I make a new branch that'll become a PR. For example, instead of this:
| * a844dcf4 - (9 weeks ago) refactor that thing — staltz (my-pr)
| * 6797d6bd - (9 weeks ago) refactor this thing — staltz
| * f788f80f - (10 weeks ago) add a feature — staltz
|/
* cde4e2f6 - (4 days ago) release 1.2.0 — staltz (main, origin/main)

I would do this:
| * a844dcf4 - (9 weeks ago) refactor that thing — staltz (my-third-pr)
| * 6797d6bd - (9 weeks ago) refactor this thing — staltz (my-second-pr)
| * f788f80f - (10 weeks ago) add a feature — staltz (my-first-pr)
|/
* cde4e2f6 - (4 days ago) release 1.2.0 — staltz (main, origin/main)

And then I submit one PR at a time, in order. When the 1st is merged, I submit the 2nd, and so forth. This is great, because if one PR is rejected, it doesn't block the other PRs. For instance, if you really need a feature shipped, just make a small PR for that feature. If it would be a big PR containing many changes, you could get stuck on back and forth code reviews on an unrelated refactor that just happens to be attached to the feature PR. So small PRs reduce disappointment too, because the stakes are lower with each PR.
How to know that a PR is "sufficiently small"? In my opinion it's not about actual diff size, it's more about how many "change decisions" a PR contains. For instance the decision to add standard may create a lot of diffs, but it's just one decision. Here's an example PR: https://github.com/ssb-ngi-pointer/ssb-meta-feeds/pull/9/files I added "prettier" and nothing else, so the reviewer knows for sure that all diffs they are looking at are caused by the application of only one decision.
I hope this is useful feedback :pray:

Yep, I am in total agreement with you @staltz
I would atu this is the role I follow too, and also that I treat that rule as a guide.
In the case of this PR I see what you mean about splitting it into commits making it easier.
I also consciously did not change any logic, I just grouped and labeled things clearly.
There's a balance for me between the cognitive load of splitting things into different PRs nicely. With this PR, I was mildly annoyed to be over here adding this (I just wanted to merge some ssb-bfe changes so I can work on the primary goal of subgroups).
This felt like a yak I didn't really want to be shaving. But I don't want to leave the yak messy, so I left the yak tidier than when I found it. If you asked me to do more work, I would probably just leave the yak messy.
Maybe that would have been fine. Maybe I need to be less worried about messy yaks
I feel like we're aligned on everything but when to bend our rules.
I'll definitely add a filter to try and split off yak tidying into different commits.


hotfix: remove DB constraints in Discord OAuth

The migration sometimes fails on certain environments because of this constraint

What happens if someone already applied the migration successfully ? The foreign key binding will remain live on those installs.
Any solutions to remove it too, like with some conditional checks on the table and proceeding if true etc.

Fair point, I considered that if it had worked it wasn't a problem because it worked... I don't know how to do it but we must be able to find something to do that yeah


[ufo] when reverse_direction is True, we always want to modify the input glyphs

Sorry, I introduced this bug with https://github.com/googlei18n/cu2qu/pull/45
We want to reverse the contour direction of all the glyphs in the font, even if they are just made of straight lines.
Currently, the direction is only flipped if the glyph contains at least one cubic curve.

... pong ;)


Tighter webhook config

https://github.com/rancher/externalip-webhook/blob/master/chart/templates/admissionregistration.yaml#L19
Has failurePolicy: Ignore
It would be good if this was made a helm values so it could be be overridden to "Fail" so no requests go through if there is a problem with the webhook.
Also, when set to Fail, we would need a way to set restrictions on which namespaces the admission monitored. For example, we need to exclude the webhook's own service. Could the namespaceSelector property of the validatingwebhook be optionally set in the values file and toYaml'ed in so that it can be restricted to certain namespaces?

Hello @kfox1111 , thanks for your input, those would be good additions. But due to the new additions in k8s, this chart is now deprecated: https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#denyserviceexternalips


ListView shouldn't be scrollable when there isn't any scroll extent

Previously, a ListView would always accept user input, even if it wasn't
actually scrollable. Now, by default, we don't accept user input if there's no
scroll range. You can override this behavior using the ScrollPhysics.
Fixes #8276
Fixes #8278
Fixes #8271

@HansMuller @Hixie

LGTM

I think this was a bit over-aggressive. Lists should be able to overscroll even if they have no content, it's only things like dialog box bodies that only overscroll in "emergencies" that should turn off scrolling entirely like this.

This fixed a lot of interaction bugs in apps.  If we loosen up here, we probably need to implement scroll chaining to prevent "dead" areas of non-scrolling.

This will make problem when set physics: const BouncingScrollPhysics() in the ListView ,the pull refresh will not work if the ListView has no content ,because it is unscrollable.

We at least should keep the bounce switch

You can override the physics on your list view to bounce even when it's empty. Just provide an AlwaysScrollableScrollPhysics instance as your physics object.


Mobile/Android tests is extremely flakey

This is pretty much permafailing on main (and PRs) - afaict its not actually permafailing as i have seen instances where it appears to pass on /retest
Either way this fails in the vast majority of runs (currently all on main) so i think needs to be addressed

cc @abeyad @fredyw

Error is:
 E
Time: 1.314
There was 1 failure:
1) successful sending of trailers(test.kotlin.integration.ReceiveTrailersTest)
expected: 0
but was : 1
	at test.kotlin.integration.ReceiveTrailersTest.successful sending of trailers(ReceiveTrailersTest.kt:96)

FAILURES!!!
Tests run: 1,  Failures: 1

BazelTestRunner exiting with a return value of 1
JVM shutdown hooks (if any) will run now.
The JVM will exit once they complete.

-- JVM shutdown starting at 2024-04-10 00:35:09 --

https://github.com/envoyproxy/envoy/actions/runs/8624059511/job/23638413480#step:8:768

I'll take a look.


Implement rolling().count() in Series and Frame

This PR implements rolling().count():
>>> import databricks.koalas as ks
>>> s = ks.Series([2, 3, float("nan"), 10])
>>> s.rolling(1).count()
0    1.0
1    1.0
2    0.0
3    1.0
Name: 0, dtype: float64

>>> s.to_frame().rolling(1).count()
     0
0  1.0
1  1.0
2  0.0
3  1.0

Relates to #977

Codecov Report

Merging #990 into master will decrease coverage by 2.48%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #990      +/-   ##
==========================================
- Coverage   94.84%   92.36%   -2.49%
==========================================
  Files          34       34
  Lines        6519     6547      +28
==========================================
- Hits         6183     6047     -136
- Misses        336      500     +164

Impacted Files
Coverage Δ

databricks/koalas/missing/window.py
100% <ø> (ø)
:arrow_up:

databricks/koalas/generic.py
96.17% <100%> (ø)
:arrow_up:

databricks/koalas/groupby.py
89.34% <100%> (-2.05%)
:arrow_down:

databricks/koalas/window.py
91% <87.5%> (-1.86%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
24.54% <0%> (-72.73%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
78.04% <0%> (-7.32%)
:arrow_down:

databricks/conftest.py
91.48% <0%> (-6.39%)
:arrow_down:

databricks/koalas/frame.py
93.84% <0%> (-2.42%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b161428...a69b453. Read the comment docs.

Let's fix expanding ones first, and them get those in.


FetchError with reason: socket hang up

FetchError: request to ***/api/v1/instance failed, reason: socket hang up

Example

Hey probably it's way to late for my response. I'm about to release v2 of this acton probably today which will probably resolve this issue.

@boozook ah, and sorry for the short answer here. Thanks for reporting this issue! 😄

Thank you so much! I updated.


Basic request metrics collection and a magic word for precached

We should have basic logging that counts (1) the number of scores requested per amount of time, (2) the proportion of requests that are returned from the cache, generated or errored, and (3) the response time of
Statsd seems like a good option.
We'll need a magic word to flag requests coming from precached to be logged differently so that we don't count those as real scores used.
This will also need to be abstracted in some way so that such logging can be optional.

Fixed by https://github.com/wiki-ai/ores/pull/96


Project no longer maintained?

there hasn't been a new commit to this project in over a year, and has pull requests dating back to 2013.
I'm guessing this project is no longer maintained. If so, can you add a notice to the README.md?

@goodwill @divineforest @machisuji is any of you guys still maintaining this project? Are you looking for someone to join or help out?

Reply to this email directly, view it on GitHub
https://github.com/goodwill/capybara-select2/issues/50#issuecomment-276431114,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABII7hhYXqiNSdMQkpk59fB7H6Xac3Xks5rX25lgaJpZM4KIE3l
.

--
Regards,
William Yeung
Tofugear Limited
✉ E<EMAIL_ADDRESS>T: +852 21519830
M: +852 92538475
W: http://tofugear.com

@goodwill I'd definitely help out to get some of the open issues resolved and PRs merged. My GH handle is @AxelTheGerman

Hello Guys,
I've just released a new capybara-select-2 gem which supports Select2 version 2/3/4
You can try it if you want https://rubygems.org/gems/capybara-select-2


TypeScript support (.d.ts)

Hi,
thank you for the best and hassle-free signature system in the vue but do you support TypeScript? I can not find any files with the extension .d.ts or @types/vue-signature-pad package.

Thank you for your help and best regards :)

Hi, @Cross77
Not currently support ts yet. I don't have any experience on TypeScript, so I need more time to learn and try, but PRs welcome. 😀

@rojobo Cool! I will try this.

@rojobo Can you use Augmenting-Types-for-Use-with-Plugins to try the defined index.d.ts?

@neighborhood999 yes that's what that file does just put it under an index.d.tx file and it will work when you install. I can do a pull request if you want
Im using it in production

@rojobo Cool! I'm not familiar typescript and defined for Vue library, feel free to create the pull request, thank you.


Add an option of selecting initial migration time.

It's an option to configure a time for "skipping" migrations which occurred  before this time. It helps , in my case, when you want to start using this pack and you want to integrate to old migrations.
Thanks

great feature, I need it too

Thanks for this

Published in https://www.npmjs.com/package/sql-migrations/v/1.0.5


new version display

requires updated OXRS_LCD library
Please update the OXRS_LCD lib from my repro. Wanted to wait for getting access to the lib on SuperHouse before changing my local workflow.
This PR together with the updated OXRS_LCD lib should address the version display issue together with the TFT_eSPI configuration.
I generated a proportional font that allows to print much more character into one line while keeping the hight of the font the same.

I also would like to show the mqtt topic but the function to get this is private. If you like the idea to show the (conf ?)topic please help.
Rack Temp. shall be filled in and updated periodically by readings from the onboard sensor. Only a test placeholder for now.

Nice one Moin - I was thinking about this lying in bed last night. I don't think we need the full SKU code for the firmware, I was thinking we could add icons to the LCD library for each known maker code registered with OXRS. Then when initialising the screen the firmware passes the FW_NAME, FW_MAKER and FW_VERSION. E.g. State Monitor ESP32, SHA, 1.2.3.
Then we could maybe lay things out as below. If someone uses a maker code that isn't registered we just hide the icon and shift all the text left.
Thoughts?

Could you add issues to the OXRS-MQTT library repo with details of what you need me to expose for the display?

Interesting idea and could be done of course. This would result in that we show the maker of the I/O board , right? So SuperHouse as organisation would show up with Jon's I/O boards only.

The maker of the firmware really, which is likely to be the same as the board.

I think I should create examples to share and discuss with the team

Yeah good idea. Did you get the invitation to join the OXRS organisation?
On Mon, 6 Sep 2021, 19:08 moinmoin-sh, @.***> wrote:

I think I should create examples to share and discuss with the team
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SuperHouse/OXRS-SHA-StateMonitor-ESP32-FW/pull/6#issuecomment-913399373,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGTR2WVHYE5J3GHBPIN3LDUARSHXANCNFSM5DO6PX7A
.

Yes, and found the new place fort he libraries !
From: Ben Jones @.>
Sent: Montag, 6. September 2021 09:10
To: SuperHouse/OXRS-SHA-StateMonitor-ESP32-FW @.>
Cc: moinmoin-sh @.>; Author @.>
Subject: Re: [SuperHouse/OXRS-SHA-StateMonitor-ESP32-FW] new version display (#6)
Yeah good idea. Did you get the invitation to join the OXRS organisation?
On Mon, 6 Sep 2021, 19:08 moinmoin-sh, @.***<EMAIL_ADDRESS>> wrote:

I think I should create examples to share and discuss with the team
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SuperHouse/OXRS-SHA-StateMonitor-ESP32-FW/pull/6#issuecomment-913399373,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGTR2WVHYE5J3GHBPIN3LDUARSHXANCNFSM5DO6PX7A
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/SuperHouse/OXRS-SHA-StateMonitor-ESP32-FW/pull/6#issuecomment-913400027 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AM3P53NXZYP5IV6GXPLTTLDUARSLLANCNFSM5DO6PX7A .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .   https://github.com/notifications/beacon/AM3P53NAWOI7SZQ5SS6SMO3UARSLLA5CNFSM5DO6PX7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGZYWBWY.gif

Great so you should be able to make PR directly onto the OXRS repos and
merge them yourself etc.
Welcome to the team!
On Mon, 6 Sep 2021, 19:51 moinmoin-sh, @.***> wrote:

Yes, and found the new place fort he libraries !
From: Ben Jones @.>
Sent: Montag, 6. September 2021 09:10
To: SuperHouse/OXRS-SHA-StateMonitor-ESP32-FW @.>
Cc: moinmoin-sh @.>; Author @.>
Subject: Re: [SuperHouse/OXRS-SHA-StateMonitor-ESP32-FW] new version
display (#6)
Yeah good idea. Did you get the invitation to join the OXRS organisation?
On Mon, 6 Sep 2021, 19:08 moinmoin-sh, @.***<EMAIL_ADDRESS>>
wrote:

I think I should create examples to share and discuss with the team
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/SuperHouse/OXRS-SHA-StateMonitor-ESP32-FW/pull/6#issuecomment-913399373
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ABGTR2WVHYE5J3GHBPIN3LDUARSHXANCNFSM5DO6PX7A
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <
https://github.com/SuperHouse/OXRS-SHA-StateMonitor-ESP32-FW/pull/6#issuecomment-913400027>
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AM3P53NXZYP5IV6GXPLTTLDUARSLLANCNFSM5DO6PX7A>
.
Triage notifications on the go with GitHub Mobile for iOS <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>
. <
https://github.com/notifications/beacon/AM3P53NAWOI7SZQ5SS6SMO3UARSLLA5CNFSM5DO6PX7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGZYWBWY.gif>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SuperHouse/OXRS-SHA-StateMonitor-ESP32-FW/pull/6#issuecomment-913427452,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGTR2UUZU52SSLNFT6DSYLUARXGNANCNFSM5DO6PX7A
.

This PR has become obsolete and can be closed without merge

I think you should have permissions to close PRs going forward, if not let me know. I will close this one.


fix syntax error in switch operator

When I typed "gvp [command]" I got this error
/usr/local/bin/gvp: line 104: syntax error near unexpected token ;' /usr/local/bin/gvp: line 104:     "") ;& # This was sourced, no command was provided'

@Neyaz This is actually not a syntax error! You might have an old version of Bash. This syntax was introduced in version 4.0. Can you post the output of bash --version?

@siddharthist
3.2.57(1)-release (x86_64-apple-darwin14)
Yes, I have old version.
But i think that's better because it's only one error when working with the old version. Doesn't need to update something or fix code.

@Neyaz I see what you're saying. In that case, please revise your code so that the case fallthrough is accurately represented, and I'll happily merge.

@siddharthist  What do you mean?

@Neyaz I mean that the syntax ;& represents a case fall through, where the next case's code is also executed. It is distinct from the ;; syntax. If you're still not sure how to do this, I'm happy to help.

@siddharthist
Done.

@Neyaz Thank you! I'll test this soon.


Receiving java.lang.IllegalArgumentException: protocol = http host = null With Some Pages

The home page of the domain "minecraft-server-list.com" is successfully fetched but the child pages in the domain fail with the error "java.lang.IllegalArgumentException: protocol = http host = null" on the .get() call.
Some pages tested:
 http://minecraft-server-list.com/server/108375
 http://minecraft-server-list.com/server/306576/vote
 https://minecraft-server-list.com/sort/Vanilla

This is occurring in release 1.10.3

@adxBRudolph could you show the full stacktrace and the testcase?

Found using Jsoup 1.10.1, 1.10.2 and 1.10.3 running on both Java 7 & 8
Code snippet in Fetcher class that fetches the page at the provided URL. The User Agent header is set and a timeout is set in the Jsoup connection. The exception is thrown by the "connect.get()" call. Example URLs in the origin post.
Connection connect = Jsoup.connect(asciiUrl).userAgent(_doc.getUserAgent()).timeout(timeout.intValue()).validateTLSCertificates(false);
Document document = connect.get();

Exception caught in code with Java 7 and Jsoup 1.10.3 (removed part of stack trace that is irrelevant - shown as ":")
java.lang.IllegalArgumentException: protocol = http host = null
	at sun.net.spi.DefaultProxySelector.select(DefaultProxySelector.java:170)
	at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:927)
	at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:851)
	at org.jsoup.helper.HttpConnection$Response.execute(HttpConnection.java:652)
	at org.jsoup.helper.HttpConnection$Response.execute(HttpConnection.java:679)
	at org.jsoup.helper.HttpConnection$Response.execute(HttpConnection.java:629)
	at org.jsoup.helper.HttpConnection.execute(HttpConnection.java:261)
	at org.jsoup.helper.HttpConnection.get(HttpConnection.java:250)
	at Fetcher.process(Fetcher.java:318)
	at ws.Service.executeSequence(Service.java:137)
	at ws.Service.process(Service.java:89)
	at HttpHandler.channelRead(HttpHandler.java:173)
	              :
	              :
	at java.lang.Thread.run(Thread.java:745)

Exception caught in code with Java 8 and Jsoup 1.10.3 (removed part of stack trace that is irrelevant - shown as ":")
java.lang.IllegalArgumentException: protocol = http host = null
	at sun.net.spi.DefaultProxySelector.select(DefaultProxySelector.java:176)
	at sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1099)
	at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:999)
	at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:933)
	at org.jsoup.helper.HttpConnection$Response.execute(HttpConnection.java:652)
	at org.jsoup.helper.HttpConnection$Response.execute(HttpConnection.java:679)
	at org.jsoup.helper.HttpConnection$Response.execute(HttpConnection.java:629)
	at org.jsoup.helper.HttpConnection.execute(HttpConnection.java:261)
	at org.jsoup.helper.HttpConnection.get(HttpConnection.java:250)
	at Fetcher.process(Fetcher.java:318)
	at ws.Service.executeSequence(Service.java:137)
	at ws.Service.process(Service.java:89)
	at HttpHandler.channelRead(HttpHandler.java:173)
	              :
	              :
	at java.lang.Thread.run(Thread.java:745)

jsoup use pure HttpURLConnection for http request. maybe you should check URL#getHost() == null?
req.url().getHost() == null?

req is the first param of method HttpConnection$Response.execute.

Can you provide a test case that demonstrates this? I.e. a Junit test we can cut&paste and see the problem. Haven't been able to replicate. And did you check per @mccxj suggestion?

I've encountered this same problem.
In the following test, if you comment the Jsoup line OkHttp works fine, except with the last one, which has an empty host, resulting in an exception when building the request.
@Test
public void illegalArgumentSearch() {
    OkHttpClient client = new OkHttpClient();

    for (String url : new String[]{
            "https://ctt.ec/0fPmC+", "https://clicktotweet.com/0fPmC+",
            "https:%20//thespiritledlife.com/831047284/reporthotmail.php"
    }) {
        try {
            URL u = new URL(url);
            log.info("host = '{}'", u.getHost());
            Jsoup.connect(url).get();
            client.newCall(new Request.Builder().url(u).build()).execute().body().string();
        } catch (Exception e) {
            log.info("Url: {}, Exception: <{}> {}", url, e.getClass(), e.getMessage());
            if (!(e instanceof IOException)) {
                log.error("Stack: ", e);
            }
        }
    }
}

Extra bits:
private static final org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger(YourTest.class);

implementation 'com.squareup.okhttp3:okhttp:3.14.7'
compile 'org.jsoup:jsoup:1.13.1'

Thank you for your time and this great project of yours :)


Cart&checkout

Merge cart&checkout

MEGA UPDATE LETS GOOO!

Skål!

Everyone is too scared too pull the trigger


Installation hangs the PC trying to execute test-sha suite

My PC hangs completely trying when to install test-sha on version <IP_ADDRESS>

Hi! Thanks for the bug report. Can you tell me exactly what the command was that you ran, and on what platform you ran it? I'm having trouble replicating this bug on OS/X.

I'm on Ubuntu 17.10. I build with ghcjs. I use SHA as dependency for web-frontend app
that is build with nix package manager.
When I turn off the tests for SHA it builds fine. But when it tries to compile test-suite and run it my computer hangs.

OK, that's helpful. I can look into it, but let me suggest that you just turn off the test suite. I don't use ghcjs and know nothing about it, so it might be awhile until I can replicate the error and understand how to fix it. (That being said, if you want to take a look yourself, you might have some more luck, and I'm happy to review and help with merge requests.)


Dimension automatically set to 100 when the input field is empty.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when I set the dimension of the drawing. It automatically set to 100 as I clear the input field. This makes the process tedious as I need to make sure the input field to not evaluate to 0, like append a random non-zero number at the end of the dimension before I change the digit in front.
Describe the solution you'd like
It is better to raise some sort of error below the input field when it is evaluated to 0. Such as:
Dimension cannot be 0px. It will default to 100px.

And then only when the input form is closed, it will default to 100px when the user input evaluate to 0.
Keep up the great work! This plugin is very likely to save my academic life! You are my saviour now.

Thank you for reporting this!
Here's what's happening internally:

When the size input changes, the size of the background is updated immediately.
The background refuses to have its size set to zero and instead sets its size to 100x100.
The changed background size causes the input to update.

2ab8246632e048fbe169ab160f0c6709e12616fa should improve this by selecting changed digits at the beginning of the input.
For example, if trying to change width from 200 to 300, I might start by backspacing the 2. This still replaces the input's value with 100, but selects the 1 rather than allowing the selection to move to the end:


blank page: class app-active not set

Hi,
At bootstrap, function onBeforeTransition stop at :
if(!started) phonon.dispatchGlobalReady();

Indeed, callback is undefined in onReady :
phonon.onReady = function(callback) {
	    if (callback == null) {
	        console.error('phonon::onReady callback is null');
	        return;
	    } else if(typeof this.callback == "undefined") {
	        console.error('phonon::onReady callback is undefined'); // <-------- this case
	        return;
	    }
	    console.debug('phonon::onReady callback=',JSON.stringify(callback));
		readyCallbacks.push(callback);
	};

... and app-active class is never set on the main page...
My env

Linux
Firefox
Vue 2.2.6
Phonon 1.4.5
Webpack

Error comes from side panels. See modified pizza-app-with-vue in attachment.
pizza-app-with-vue-src.zip

Hi,
Did you reproduce this issue ?
I'm blocked on this problem and hope that my example would help to find a solution.
Regards
Benjamin

Can you show your Phonon config?
At this moment I have access only by phone, so can't see your example file.

I just took the Phonon-Framework-master/examples/pizza-app-with-vue and changed some src files to show the issue.

Hello @bdedardel,
Thank you for opening this issue.
I updated the example with VueJS2.
With Angular and Vue, you need to add the attribute data-alias="page-name" because Phonon reads the tag name which can not be used with virtual DOM.
Instead of doing this:
html
<home data-page="true">...

You need to do the following:
html

...

In VueJS, there is a simpler way by getting the component name:
html

...

Hope it helps! Please, reopen this issue if it does not work for you.


BRENDA file not available anymore

https://www.brenda-enzymes.org/brenda_download/file_download.php does not exist anymore, leading to FileNotFoundError: [Errno 2] No such file or directory: './data/brenda_2023_1.txt
I assume what is the correct file can now be found under https://www.brenda-enzymes.org/download.php

You are correct in assuming that the correct file can now likely be found on the new download page at https://www.brenda-enzymes.org/download.php.


Instruction on how to use SAS token

I've used above method to generate a SAS in order to upload content to Azure storage. for example using the generated SAS in a URI:  PUT https://mystorageaccount.blob.core.windows.net/my-container/test.mp4?sv=GENERATED_SAS
I tried both PUT and POST. but keeps getting error:
<?xml version="1.0" encoding="utf-8"?>
<Error>
  MissingRequiredHeader
  <Message>An HTTP header that's mandatory for this request is not specified.
RequestId:fca2f993-401e-003f-54aa-2797a6000000
Time:2020-05-11T15:38:42.1337480Z</Message>
  <HeaderName>x-ms-blob-type</HeaderName>
</Error>

Do we need to add any header to the upload request? If so, the doc needs update
Thanks
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 436ced8b-728a-8b1d-833b-0c71e1b8c777
Version Independent ID: a86c8133-f78b-b8b4-5d44-8820a6dc7a65
Content: Use PowerShell to create a user delegation SAS for a container or blob - Azure Storage
Content Source: articles/storage/blobs/storage-blob-user-delegation-sas-create-powershell.md
Service: storage
Sub-service: blobs
GitHub Login: @tamram
Microsoft Alias: tamram

@joedevgee Thanks for the comment! We will investigate on this issue and get back to you soon.

@SadiqhAhmed-MSFT Just found out the problem. I am using the NodeJS SDK. but there are some confusions around generate the SAS token according to this doc: https://docs.microsoft.com/en-us/javascript/api/%40azure/storage-blob/generateblobsasqueryparameters?view=azure-node-latest
It would be better if we can have this content be updated and more clear.
Thanks, you can close the issue now

@joedevgee We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Visual Stuttering when pushing against table

Description
If you push against the edge of a table it can make your screen stutter up and down.
Screenshots

Additional context

this is due to physics being funky currently, should be fixed by the physics rewrite coming soon:tm:

this is due to physics being funky currently, should be fixed by the physics rewrite coming soon:tm:


systemd unit fails at start up but can be started manually after(Ubuntu 15.10).

I followed the systemd instruction in the wiki on Ubuntu 15.10 server(mostly: corrected cups-connector.config.json to gcp-cups-connector.config.json).
This is what I get out of systemctl status gcp after a reboot:
● gcp.service - Google Cloud Print CUPS Connector
   Loaded: loaded (/etc/systemd/system/gcp.service; enabled; vendor preset: enabled)
   Active: failed (Result: exit-code) since Mon 2015-11-16 11:05:03 CST; 36s ago
  Process: 602 ExecStart=/opt/gcp_cups_connector/gcp-cups-connector -config-filename /etc/gcp_cups_connector/gcp-cups-connector.config.json (code=exited, status=255)
 Main PID: 602 (code=exited, status=255)

Nov 16 11:05:02 gray-server gcp-cups-connector[602]: /home/user/go/src/github.com/golang/glog/glog.go:646 +0x1b8
Nov 16 11:05:02 gray-server gcp-cups-connector[602]: github.com/golang/glog.(*loggingT).print(0xcfdbe0, 0xc800000003, 0xc8200bfe30, 0x1, 0x1)
Nov 16 11:05:02 gray-server gcp-cups-connector[602]: /home/user/go/src/github.com/golang/glog/glog.go:637 +0x50
Nov 16 11:05:02 gray-server gcp-cups-connector[602]: github.com/golang/glog.Fatal(0xc8200bfe30, 0x1, 0x1)
Nov 16 11:05:02 gray-server gcp-cups-connector[602]: /home/user/go/src/github.com/golang/glog/glog.go:1128 +0x49
Nov 16 11:05:02 gray-server gcp-cups-connector[602]: main.main()
Nov 16 11:05:02 gray-server gcp-cups-connector[602]: /home/user/go/src/github.com/google/cups-connector/gcp-cups-connector/gcp-cups-connector.go:89 +0xe80
Nov 16 11:05:03 gray-server systemd[1]: gcp.service: Main process exited, code=exited, status=255/n/a
Nov 16 11:05:03 gray-server systemd[1]: gcp.service: Unit entered failed state.
Nov 16 11:05:03 gray-server systemd[1]: gcp.service: Failed with result 'exit-code'.

After systemctl start gcp and systemctl status gcp  without rebooting all is well:
● gcp.service - Google Cloud Print CUPS Connector
   Loaded: loaded (/etc/systemd/system/gcp.service; enabled; vendor preset: enabled)
   Active: active (running) since Mon 2015-11-16 11:06:16 CST; 10s ago
 Main PID: 1549 (gcp-cups-connec)
   CGroup: /system.slice/gcp.service
           └─1549 /opt/gcp_cups_connector/gcp-cups-connector -config-filename /etc/gcp_cups_connector/gcp-cups-connector.config.json

Nov 16 11:06:16 gray-server systemd[1]: Started Google Cloud Print CUPS Connector.
Nov 16 11:06:16 gray-server gcp-cups-connector[1549]: E1116 11:06:16.808102    1549 gcp-cups-connector.go:34] Google Cloud Print CUPS Connector version 2015.10.05-linux
Nov 16 11:06:16 gray-server gcp-cups-connector[1549]: Google Cloud Print CUPS Connector version 2015.10.05-linux
Nov 16 11:06:18 gray-server gcp-cups-connector[1549]: E1116 11:06:18.133121    1549 gcp-cups-connector.go:141] Ready to rock as proxy 'HP_PRINTER' and in local mode
Nov 16 11:06:18 gray-server gcp-cups-connector[1549]: Ready to rock as proxy 'HP_PRINTER' and in local mode

@hubertbanas can you comment here? He wrote the wiki page.

@JasonLG1979 what does the log say after reboot? Should be only a few lines if it fails quickly.

To be clear, what does the connector log say?

/tmp/connector.INFO is not created. My guess is because the connector never starts.

Yep. replacing:
After=printer.target
With:
After=printer.target network.target multi-user.target
Did the trick.

Good to know.
I haven't taken the time to learn systemd yet; would you mind updating the wiki?

would you mind updating the wiki?

Just did ;)

Thanks for doing that.

I'll update the wiki further with step by step instructions later as far as making the dirs and moving the files around and setting proper file permissions and such.

Still failing on Raspbian 2, even after setting. Could it be that it needs to come even later in startup?:
After=printer.target network.target multi-user.target

Hi
Just had a similar issue. For me the following works:
[Unit]
Description=Google Cloud Print CUPS Connector
Wants=network-online.target time-sync.target
After=network.target network-online.target time-sync.target

On my system the problem was not being online yet at the time the service was being started, and therefore the need for network-online.target.

I still had problems even with network-online.target on Arch Linux. Adding Restart=on-failure to the [Service] section seems to have done it.
It's worth considering if it's better to have it bail out on failure to connect (and require the system to retry it) or better to have the connector do the retries. Given that the service is useful on the local broadcast domain even when it cannot connect, I'd rather have the connector do the retries.
It would also be bad if the connector bailed out when losing a connection. Not sure if it does that.

Having the same problem (connector fails to start on boot, but will start from command line). I have the network-online.target modification. The Restart=on-failure modification did not work for me, so I've removed it.
I do get an error message in /tmp/gcp-cups-connector.FATAL:

Log line format: [IWEF]mmdd hh:mm:ss.uuuuuu threadid file:line] msg
F1229 23:15:23.882132     490 gcp-cups-connector.go:89] While starting XMPP, failed to get access token (password): Post https://accounts.google.com/o/oauth2/token: dial tcp: lookup accounts.google.com on [::1]:53: read udp [::1]:33719->[::1]:53: read: connection refused
goroutine 1 [running]:

Hello all,
I found a workaround until #160 gets fixed.
I experienced the same difficulties with failed auth because of no-network on RaspberryPI 2 with Raspbian Jessie and managed to work around it by setting
Restart=always
RestartSec=10

in the gcm.service file
The 10 second delay between restarts probably can be fiddled with but it worked for me.
Cheers!

Hi all,
the last worked around works for me, too. Thanks
Cheers

I can not even do:
systemctl status gcp
I receive the following error:
Failed to get D-Bus connection: Unknown error -1
Thanks for help

Me too - any news on this?

@Joehc @tryandbuy are you still getting the dbus errors? This is likely not a cloud print issue.

Take another look at https://github.com/google/cups-connector/wiki/Run-Connector-Automatically-on-Boot. I updated the service file there to try to be more robust.
Specifically, these lines:
[Unit]
After=printer.target network-online.target
Wants=network-online.target

and
[Service]
Restart=on-failure

So until #160 is fixed, I think the systemd file in the wiki provides the most robust workarounds available.

I tweaked the systemd file on the wiki again. Disregard the lines in my comment above, they are out of date.

Using the latest service file on my Raspberry Pi it still wouldn't start properly on boot. Looking in journalctl it said that the cloud-print-connector was trying to restart too fast and stopped trying to start it.
Adding RestartSec=10 seems to have fixed it for me.

Take a look at #355 which should provide the correct systemd config to restart indefinitely. Sorry I did not catch this before.

adding
Environment=CUPS_ENCRYPTION="NEVER connector"
before the ExecStart worked for me

Apr 23 01:05:32 iwf1115175 systemd[1]: omni@4632-<IP_ADDRESS>:5590-<IP_ADDRESS>:46388.service: Unit entered failed state.
Apr 23 01:05:32 iwf1115175 systemd[1]: omni@4632-<IP_ADDRESS>:5590-<IP_ADDRESS>:46388.service: Failed with result 'exit-code'.
Thanks it gets resolved  with:
Restart=on-failure


Handle applications that focus another window

Eg, if I click a link in my email application that launches in my browser, then currently workspacer eats the "focus browser" action and it flashes for a split second then doesn't do anything.
It should indicate somehow that another application was attempted to be focused.
This could be focusing the workspace that application belongs to or it could be just flashing that workspace in the title bar or something else. As long as there is some obvious indication

this should be fixed now, the behavior is that a window is focused that isn't in a visible workspace, we will force the workspace onto the desired monitor. I tested this with firefox via:
 "C:\Program Files (x86)\Mozilla Firefox\firefox.exe" -new-tab https://google.com

with firefox in another workspace it seems to work well


Correcting four setting ranges

Fix setting ranges for these:
SetHeaterStopDelta
SetHeaterStartDelta
Heater_Delay_Time
Heat Outside Low, in J-series can set to -20

Hello, thanks for your contribution. Could you show me the source for those values? I'm not sure to find them in heishamon source code (for SetHeaterStopDelta, SetHeaterStartDelta and Heater_Delay_Time).

Panasonic J-series monoblock service manual page 32 and 33
https://www.panasonicproclub.com/uploads/ES/catalogues/manual-instalacion/Service Manual Mini Monobloc R32 Serie J.pdf


 But it can be string with multiple lines.
Solution: textwrap package provides indent method which adds indentation for multiline string.
Ref:

https://docs.python.org/3/library/textwrap.html#textwrap.indent
https://stackoverflow.com/questions/8234274/how-to-indent-the-contents-of-a-multi-line-string

Created https://github.com/echo724/notion2md/pull/63 to fix the issue.
@echo724 please review and merge


[XR] First version of Space Warp support

This PR contains the XR feature that enables space warp, a feature available in the oculus browser (behind a flag). The feature was suggested as an official WebXR feature - https://pr-preview.s3.amazonaws.com/cabanier/layers/pull/303.html#feature-descriptor-space-warp as part of the XR Layers spec.
Note Code based on the initial version made by @dannysu
Closes #13945

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Thank you @RaananW! FYI, Meta Quest Browser v26.2+ has WebXR Space Warp on by default and doesn't require the flag to be toggled.


Hierarchical bottom-up clustering with complete linkage

I use a custom implementation of hierarchical bottom-up clustering with complete linkage in a private project and I would like to move it to a public external crate for obvious reasons, i.e., help others, get help, thin my code base and focus on my main idea.
Well, I found your crate and I was wondering if it is the right place. It should be fairly simple to incorporate even more hierarchical linkage criterias.
cc @huonw (added by @huonw to give me an email about this issue)

I think cogset is a reasonable place to put more clusterings, including this one.

I just opened a PR (#2) to exchange possible ideas how to model the problem best.


How to customize the lattice types?

Hi, besides the listed lattice types, how can users customize a new lattice type? Thanks a lot.

Thanks for your suggestion. We will work on the updates so that users can customize the lattice types:
Essentially, we need the following information:

The shape of the unit cell (e.g., square, hexagonal)
Fractional coordinates
The number of atoms per unit cell (for constrained and unconstrained atoms)

@PenghuDu
Please check the current version of the repository, to which I added the custom structural constraint.

Thanks a lot. I would like to have a try.


[Bug]: Port 5006 is forced within docker

Verified issue does not already exist?

[X] I have searched and found no existing issue

What happened?
Hello,
If I give my Actual docker its own IP address,  the docker forces me to use port 5006, instead of 443 or 80.
Example:
services:
  actual_server:
    image: docker.io/actualbudget/actual-server:latest
    ports:
      - '443:5006'
    environment:
      - ACTUAL_HTTPS_KEY=/data/selfhost.key
      - ACTUAL_HTTPS_CERT=/data/selfhost.crt
    volumes:
      - ./actual-data:/data
    restart: unless-stopped
    networks:
      my-network:
        ipv4_address: <IP_ADDRESS>

networks:
  my-network:
    external: true
    name: my-network

What error did you receive?
No error, but I think we should edit the Dockerbuild to not force port 5006, or allow an environment variable for when you are not using "bridge" network within docker.
Where are you hosting Actual?
Docker
What browsers are you seeing the problem on?
Firefox
Operating System
Linux

Can't test this as my docker instalation in armv6 is busted, but from your docker compose file, you're missing port environment variables https://actualbudget.org/docs/config/#port

I don't think this is a problem.  You need to set the ACTUAL_PORT environment variable to change the port Actual binds to.  Then you can map that port to any port you want outside of the container.
See #333 for an example.

I think this issue could be closed, as #333 should fix the problem of discoverability on setting custom ports in Docker.

Can't test this as my docker instalation in armv6 is busted, but from your docker compose file, you're missing port environment variables https://actualbudget.org/docs/config/#port

Correct, by using the ACTUAL_PORT fixed the docker compose issue.
Thanks.


restored AWS VolumeID is missing availability zone

What steps did you take and what happened:
Take a backup

kubectl config use-context cluster1
Deployed the nginx-app-with-pv.yaml example to the velero-restore-example namespace.
 The StorageClass was able to be restored because I'm using an image off of the latest master, gcr.io/heptio-images/velero@sha256:be5b270fb102e5b77307a37b6557f846baa2f8bd3dc9be0e8cb5c84475c90452.
What did you expect to happen:
The restore to create a volume with VolumeID aws://<availability-zone>/<vol-xxxxx>.  If I deploy nginx-app-with-pv.yaml directly to cluster2, I get the correct VolumeID.
The output of the following commands will help us better understand what's going on:

velero backup describe <backupname> or kubectl get backup/<backupname> -n velero -o yaml

Name:         nginx
Namespace:    velero
Labels:       velero.io/storage-location=default
Annotations:  <none>

Phase:  Completed

Namespaces:
  Included:  velero-restore-example
  Excluded:  <none>

Resources:
  Included:        *
  Excluded:        <none>
  Cluster-scoped:  auto

Label selector:  <none>

Storage Location:  default

Snapshot PVs:  auto

TTL:  720h0m0s

Hooks:  <none>

Backup Format Version:  1

Started:    2019-03-01 10:57:32 -0500 EST
Completed:  2019-03-01 10:57:42 -0500 EST

Expiration:  2019-03-31 11:57:32 -0400 EDT

Validation errors:  <none>

Persistent Volumes:
  pvc-4cab9c94-3c2b-11e9-b93c-02d86058a9bc:
    Snapshot ID:        snap-06f9da638cfd291a6
    Type:               gp2
    Availability Zone:  us-east-1a
    IOPS:               <N/A>

velero restore describe <restorename> or kubectl get restore/<restorename> -n velero -o yaml

Name:         nginx-20190301105833
Namespace:    velero
Labels:       <none>
Annotations:  <none>

Backup:  nginx

Namespaces:
  Included:  *
  Excluded:  <none>

Resources:
  Included:        *
  Excluded:        nodes, events, events.events.k8s.io, backups.ark.heptio.com, backups.velero.io, restores.ark.heptio.com, restores.velero.io
  Cluster-scoped:  auto

Namespace mappings:  <none>

Label selector:  <none>

Restore PVs:  auto

Phase:  Completed

Validation errors:  <none>

Warnings:  <none>
Errors:    <none>

Anything else you would like to add:
I'm trying to backup a namespace from a kops-provisioned 1.10.11 cluster and restore it to a CloudFormation-provisioned EKS 1.11.5 cluster. I'm using the same version of velero in both clusters but in cluster2 it's running with --restore-only. If the VolumeID isn't created correctly, our autoscaler (we're using Spotinst) fails to validate the volume and can't schedule the pod on a new node. We receive PV Volume Id: vol-123456789 doesn't match volume pattern.
Environment:

Velero version (use velero version): v0.11.0
Kubernetes version (use kubectl version): cluster1=1.10.11, cluster2=1.11.5
Kubernetes installer & version: cluster1=kops 1.11.0, cluster2=EKS
Cloud provider or hardware configuration: cluster1=AWS+kops, cluster2=AWS+EKS

@morganwalker so it sounds like everything's being restored OK, the volume comes up, etc. - but the only issue is that the PV's VolumeID is vol-0959c4b96db0052b1 whereas you expect it to be aws://us-east-1a/vol-0959c4b96db0052b1? Am i reading that correctly?

Looking at the Kubernetes code, it looks like either form is valid, though the dynamic provisioner uses the aws://<AZ>/<volume-id> form.

The nginx-app-with-pv.yaml deployment and PVC were able to be successfully restored because the k8s node in cluster2 just happened to be in the same availability zone as the PVC that was restored, us-east-1a. If the k8s node in cluster2 was in us-east-1b, the nginx deployment and corresponding PVC would have been put into a pending state, which will trigger our autoscaler that a pod needs to be scheduled. The autoscaler performs validations and this particular one is failing with PV Volume Id: vol-123456789 doesn't match volume pattern because it's looking for aws://<AZ>/<volume-id>. Is there any reason why the dynamic provisioning form is being removed?

So two things - first, we don't natively support changing the AZ during a restore - the snapshot will always be restored to a volume in the same AZ as it came from. You might be able to write a plugin to do the remapping - not sure off the top of my head if it would work or not.
Second - I don't see any reason why we couldn't use the aws://<AZ>/<volume-id> form since from a Kubernetes perspective both are equally valid. Interested in contributing a patch?

the snapshot will always be restored to a volume in the same AZ as it came from

Makes sense. When the snapshot is restored to a volume in us-east-1a and I don't currently have a node in us-east-1a, it should, and is, the job of the autoscaler to create a node in us-east-1a to accommodate the pending pod with a PVC in us-east-1a.
I'm willing to give a contribution a go! Any chance you could point me in the right direction of where I'd make the change?

Sure! It could be implemented in one of two places, but I'd probably modify this function: https://github.com/heptio/velero/blob/master/pkg/cloudprovider/aws/block_store.go#L275
The volumeID that's passed in is directly from AWS, so will look like vol-xxxxx.  You can grab the AZ of the volume from a label on the persistent volume -- similarly to how we do here: https://github.com/heptio/velero/blob/master/pkg/backup/item_backupper.go#L401.  Then you can use that to construct the aws://<AZ>/<volume-id>-formatted volume id.
Let me know if need any other input!

Closed by #1274


Release of the dataset/code

Hi,
This is a very interesting paper, and I would love to use its results in our research project.
Is there a timeline on the release of the resulting dataset, or the processing scripts?
Thank you.

Hi there!
I'm glad you're interested in our work! :)
Yes, the paper will be officially presented at NAACL in two weeks and the source code will be released by the end of next week so it is ready before NAACL. I'll let you know as soon as it is released, don't worry 💪 (and sorry for the delay in the response, I'm not yet added as a project member of this repo so I wasn't notified).
Thank you for your interest! 😃😃😄

Thank you for your reply!
We are working to submit our paper by June 15th, and it would be great if we could use and cite the results of your paper there.
Even just the calculated reliability scores for news sources (without the source code) would be really helpful.

I see, if it is only the computed reliability scores shouldn't be a problem! we're glad you find our resource useful. Shall I send it to your e-mail<EMAIL_ADDRESS>right?) or you prefer different method for sharing it?

I see, if it is only the computed reliability scores shouldn't be a problem! we're glad you find our resource useful. Shall I send it to your e-mail<EMAIL_ADDRESS>right?) or you prefer different method for sharing it?

Yes, that would be wonderful, thank you very much!

(the repo content is now available)


Segmentation fault while syncing testnet on rc5

This issue tracker is only for technical issues related to Dash Core.
General Dash questions and/or support requests and are best directed to the Dashpay Reddit.
To report critical security issues, email<EMAIL_ADDRESS>instead of creating Github issues.
Describe the issue
Can you reliably reproduce the issue?
If so, please list the steps to reproduce below:

get binary dash v<IP_ADDRESS>-rc5
start sync testnet from scratch

Expected behaviour
sync all dash-testnet blockchain
Actual behaviour
Segmentation fault (core dumped) at block 263999
What version of Dash Core are you using?
v<IP_ADDRESS>-rc5
Machine specs:

OS: ubuntu linux 18.04
RAM: 2GB
Disk size: 30 GB
Disk Type (HD/SDD): SSD

Any extra information that might be useful in the debugging process.
start command
dashd -datadir=/home/ubuntu/.dash -conf=/home/ubuntu/dash.conf

last three blocks in log (debug=1) here
dash.conf
dbcache=2048
disablewallet=1
listen=1
maxconnections=25
printtoconsole=1
rpcallowip=<IP_ADDRESS>
rpcallowip=<IP_ADDRESS>/12
rpcallowip=<IP_ADDRESS>/8
rpcauth=bcnode:<hash>
rpcport=19998
server=1
testnet=1
txindex=1
rpcthreads=4
rpcworkqueue=32

After downgrade to v<IP_ADDRESS>-rc4 sync continue without errors

Do you have the IP:port of the peer that you were connected to?

https://github.com/dashpay/dash/pull/2508 should fix this


(PUP-7068) Resolve Hiera version 3 datadir against current working dir

This commit ensures that a relative path in a Hiera version 3 config is
resolved using the current working directory.

CLA signed by all contributors.


Direct relation between a process and an independent continuant in which it occurs.

From<EMAIL_ADDRESS>on July 08, 2012 12:51:21
Problem:
One of the most common inference patterns regarding biological processes:
proc1 occurs in biostruct1
biostruc1 is located in biostruct2 at all times
->
proc1 occurs in biostruct2
Example:
Every Appendicitis_process occurs in some Appendix(in situ)
Every Appendix(in situ) is located in some Intestine
->
Every Appendicitis_process occurs in some Intestine
The shape of the spatiotemporal region occupied by the process as well as its time-dependent spatial projections are pointless.
What matters is that each of these spatial projections is a part of the spatial region at which the appendix(in situ) is located.
Due to the transitivity of 'continuant part of at all times' each of these spatial projections is also a part of the spatial region at which the intestine is located.
Maybe we can express this via complicated role chains, but I think a new relation is required.
This kind of 'localization of a process in an independent continuant' is different from the a process having an independent continuant as participant.
Original issue: http://code.google.com/p/bfo/issues/detail?id=98

From<EMAIL_ADDRESS>on July 10, 2012 09:42:32
Status: Duplicate
Owner<EMAIL_ADDRESS>Mergedinto: 78


GH-32954: [Java] Let OS assign port in tests while creating Flight server

Rationale for this change
Sometimes tests are flaky because the current port selection algorithm selects a random port between the ranges 49152-54152. This change makes it such that the OS will assign the next free port without us searching for a port in this range.
What changes are included in this PR?
This PR makes use of  java.net.ServerSocket's ability to assign the next free port if 0 is passed as the port number.
Are these changes tested?
If existing tests pass, there's confirmation that the Flight server is able to come up successfully, thereby no new tests should be needed.
Are there any user-facing changes?
No, there are no user facing changes.

Closes: #32954

Thank you! That said, the issue is actually about getting rid of this antipattern entirely - we can and should bind to port 0 directly, and create the client by reading the assigned port off of the server. (That's why the issue is about getting rid of the antipattern-using test utilities).
This is an improvement though, so we can just file a new issue for this?

Yeah I was thinking that this is somewhat of a dumb fix to what you mentioned in the ticket. Sure, I can file a new ticket for this.

I have created: https://github.com/apache/arrow/issues/33993
Will amend my commit to include the new issue number.

@lidavidm I'd like to work on the original ticket as well. Hopefully I'll have something up soon. Sorry about the confusion here.

No worries, as mentioned this is still better than it was before.


User Set in room returns nil

PCCurrentUser PCRooms have empty Sets for userIds. Is this the expected SDK behavior?
public internal(set) var userIDs: Set<String>
Is nil on PCRoom init function.
Xcode 10
Swift 4.2
ChatKit 1.0.0

The list of users that are members of a room will now only be populated once you've subscribed to the room that you're attempting to get the list of members for.


Adjusting api version by -1 for e2e tests

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


A2DP Sink Demo - IDF4.4.1 (IDFGH-7639)

ESP-IDF v4.4.1
im so confused.... i see other issues mentioning the audio packet loss during AVRC commands received
mostly volume controls
i set up latest release 4.4.1 and used the example A2DP.sink
all i did was, comment out the simulated volume changes (why is that even in the demo)
and build the project, and send it to my dev board
it works... then you change volume on host (iPhone) and boom audio gets choppy
i see posts dating over year ago with issues like this...
it looks like some commits make to IDF v4.1, which i would assume are there in IDF v4.4.1
is the ESP32 not up to the ability to do a simple A2DP Sink?
oddly it works for few seconds of playback... then all bad
I (130768) RC_TG: Volume is set by remote controller to: 50%
**W (130778) BT_APPL: Pkt dropped**
I (130778) RC_TG: AVRC set absolute volume: 46%
I (130778) RC_TG: Volume is set by remote controller to: 46%
**W (130788) BT_APPL: Pkt dropped**

ringbuffer problem, that has never been solved? is this a deeper issue at the controller level?
mitch

Hi @mitchjs ,
Sorry, I didn't reproduce the issue. Several questions to know.

Are you just running the sink demo?
What is the phone model used? Can this issue be reproduced with other phones?

Thanks

yes, just the sink demo,. I commented out the simulated volume control change task
in bt_app_av.c
testing in ESP32_WROOM-32
with iPhone 11, with latest iOS
i just got out a Samsung TAB A  (2019) SM-T290
and its playing smooth!!!! NO PKT drops when change volume...
i got a iPad i can try too
and retry (for sanity sakes the iPhone 11)
ok that works too...
i  know i had pks dropped, i show it in the logging... but not now...
thank you for looking at my issue, which is none issue now
prob can close this... ill reopen if it happens again and i can provide more info

i went to sleep, woke up and just tested again... it happens
once it starts... then any volume control causes it to happen
(using iPhone)
then i reset the ESP32, reconnect the ESP-SPEAKER
and no pkt dropped messages
and move the onscreen slider fast, up.... down
and suddenly pkt dropped messages
it seems rapid changes in volume
so rapid incoming AVRCP messages?
once i get them to drop, even the slower volume changes
by the physical side button on iPhone gets a log of pkt dropped
(and of course audio cuts out)
so it doesnt recover
i can reproduce this at will on the iPhone
BUT NOT on the android tablet... i move the slider back and forth fast
and no issues
do you have an iphone to test with? and use the ON SCREEN touch slider in the MUSIC app
and once it starts, then any volume change will start showing these messages
i now try the youtube app, and move the slider on screen (which is tricky to show)
and its good, then go to the ios control panel volume and move its slider
and pkt dropped
and i have to disconnect to clear it up
I (18837494) RC_TG: AVRC set absolute volume: 30%
I (18837504) RC_TG: Volume is set by remote controller to: 30%
I (18837504) RC_TG: AVRC set absolute volume: 31%
I (18837514) RC_TG: Volume is set by remote controller to: 31%
W (18837524) BT_APPL: Pkt dropped

W (18837534) BT_APPL: Pkt dropped

I (18837534) RC_TG: AVRC set absolute volume: 32%
I (18837534) RC_TG: Volume is set by remote controller to: 32%
I (18837544) RC_TG: AVRC set absolute volume: 33%
I (18837544) RC_TG: Volume is set by remote controller to: 33%
W (18837554) BT_APPL: Pkt dropped

I (18837554) RC_TG: AVRC set absolute volume: 33%
I (18837564) RC_TG: Volume is set by remote controller to: 33%
W (18837574) BT_APPL: Pkt dropped

I (18837574) RC_TG: AVRC set absolute volume: 33%
I (18837574) RC_TG: Volume is set by remote controller to: 33%
I (18837584) RC_TG: AVRC set absolute volume: 33%
I (18837584) RC_TG: Volume is set by remote controller to: 33%
W (18837594) BT_APPL: Pkt dropped

I (18837604) RC_TG: AVRC set absolute volume: 52%
I (18837604) RC_TG: Volume is set by remote controller to: 52%
I (18837614) RC_TG: AVRC set absolute volume: 53%
I (18837614) RC_TG: Volume is set by remote controller to: 53%
W (18837624) BT_APPL: Pkt dropped

I (18837634) RC_TG: AVRC set absolute volume: 54%
I (18837634) RC_TG: Volume is set by remote controller to: 54%
W (18837644) BT_APPL: Pkt dropped

I (18837644) RC_TG: AVRC set absolute volume: 54%
I (18837644) RC_TG: Volume is set by remote controller to: 54%
I (18837654) RC_TG: AVRC set absolute volume: 55%
I (18837664) RC_TG: Volume is set by remote controller to: 55%
W (18837664) BT_APPL: Pkt dropped

I (18837674) RC_TG: AVRC set absolute volume: 55%
I (18837674) RC_TG: Volume is set by remote controller to: 55%
I (18837684) RC_TG: AVRC set absolute volume: 55%
I (18837684) RC_TG: Volume is set by remote controller to: 55%
W (18837694) BT_APPL: Pkt dropped

I (18837704) RC_TG: AVRC set absolute volume: 55%
I (18837704) RC_TG: Volume is set by remote controller to: 55%
W (18837714) BT_APPL: Pkt dropped

I (18837714) RC_TG: AVRC set absolute volume: 55%
I (18837724) RC_TG: Volume is set by remote controller to: 55%
I (18837734) RC_TG: AVRC set absolute volume: 55%
I (18837734) RC_TG: Volume is set by remote controller to: 55%
W (18837744) BT_APPL: Pkt dropped

@xiongweichao , just in case you dont see that i reopend... as i found a way to make it happen consistently

@BetterJincheng ,
my inital tests, it WORKED! no more audio breakup, no PKT Dropps
I want to test it some more... i need to wait till i have full access to my development area
tonight.
could you explain the simple change? I'm guessing making the task a lower priority?
i see "BtI2STask" task had/has same -3 priority, so now the "btAppTask" has a lower priority than the I2S task
(makes sense that the I2S Task is high)
thanks
mitch

@mitchjs Our Bluetooth Stack handles the incoming audio packet in BTC_task which has the priority of max-3. We log Volume is set by remote controller in btAppTask. When we receive lots of AVRC command, the log will always be printed and the BTC_Task can be starved as it has lower priority than btAppTask. BtI2STask should have high priority because I2S is responsible for playing audio, which requires high real-time performance.
Turn to us anytime. Thanks!

@mitchjs Yes, you are right. ESP_LOGx will block the task.


About datasets

dear author:
I have a question that training on gopro, have 2 blur folder, that blur and blur_gamma, I want to know you used is blur or blur_gamma? thankyou

We use the "blur" folder.