SRDB import: detect and deal with instances where site-level measurements are repeated multiple times for different plots and years

I've noticed that our current import script produces instances where site-level measurements are repeated multiple times for different plots and years. This occurs when SRDB records the same value for supplementary C stocks and fluxes (e.g., NPP, biomass, soil) in association with multiple soil respiration measurements. This appears to occur when these measurements are made at a coarser spatial resolution than soil respiration, stay relatively constant across years (e.g., soil, biomass).
For example, records 24928-24948 (site = Kurth_2014_isrr research site in Minnesota USA) are all variable.name=soil, mean =66.41. These will be deleted anyway (see issue #190), but provides one example. Another example (that will not be deleted under issue #190) is soil values in Bond-Lamberty_2004_corr.
[I need to stop for now and return to this issue. Need to figure out how best to deal with these.]

The code does catch that at the plot level but not at the site level:
For the 2 example you gave, all records are for different plots.
I'll change the code to look at the site level only.
Should this apply to all variables?

For the 2 example you gave, all records are for different plots.

In fact first example should be considered as only one plot (see this issue)
But all 7 records in second example (soil values in Bond-Lamberty_2004_corr) are for different site.names... so I don't know how to fix that.

Thanks!
At the site level, for spatial replication, there are two options: (1) delete or (2) create a different plot name.
For temporal replication, what happens at the plot level when repeated across years?

For the Kurth example, its true that the the 60 year old plots should be considered one plot, but the same measurement is also assigned to other, legitimately different plots. (Of course, Kurth will end up being deleted completely, so no value discussing that one except as an example of what the code should do.)

currently the code does not enter the data if it is:

same sites.sitename
same plot.name
same stand.age
same variable.name
same mean

Actually, the soil values in Bond-Lamberty_2004_corr present a bigger problem. They are repeated across different SITES and studies (Wang study for same set of sites, but I'm not seeing those records in our import).

Should this apply to all variables?

It would apply to all variables but soil respiration variables (columns GPP - soil in SRDB).

the soil values in Bond-Lamberty_2004_corr present a bigger problem. They are repeated across different SITES and studies

To get at this, we'll need to search for repeats both within sites and within studies.

Hopefully this resolves the DETECTION issue. Next question is how to deal with them...

Temporal repeats are easy: keep only one instance and put "NAC" for date.

For spatial repeats, if values reported by a single study are repeated across multiple sites (e.g., soil values in Bond-Lamberty_2004_corr), I see now option but to delete. Let's keep a file with deleted records, though, in case someone wants to come back later and review/ add those.

The remaining challenge is how to deal with values repeated across multiple plots at the same site.
Examples:

[still looking for one!]

False example:

Harwood forest has the same Litter_flux for stands aged 12 and 20 (but not 3 other ages in the chronosequence). This appears to be just a coincidence.

It would be nice if we could avoid removing false apparent repeats, which could be done by applying a rule that values must be repeated across all plots at a site to count as repeats.

Spatial repeats:
I think I can Identify cases where values are repeated across all plots of one site (147 sites/variable combinations involved).
example:
- site = UnterluSs, variable.name = soil_C2N
- site = Skogaryd, variable.name = ANPP_litterfall_0_C

Your solution is to delete those records ? (save them apart), correct?

temporal repeats
I think I can Identify cases where values are repeated for different ages of one same plot (471 plots/variable combinations involved).
example:

site = Acadia Research Forest, variable.name = LAI
site = Balmoral Forest plantation, variable.name = ANPP_litterfall_0_C

Your solution is to keep only one of the records (the earliest), replace age and dates by "NAC" and delete all others, correct ?

Seeing you earlier comment now...
let me edit above according to it

hmmm...

Plots differ in experimental treatment. In this case, please keep the one associated with no experimental treatment. The logic is that these measurements were probably made on the stand as a whole, not on manipulated sub-plots.

not sure how to deal with that.
This will get into the problems we have with plot.name (unmanaged vs treatment etc...)

In theory, plots could also differ in vegetative composition (e.g., deciduous/ evergreen). In this case, they'd also need to be deleted and kept in a file of deleted records.

here,

if the vegetative composition made it into the plot name, those records will be handled by the "spatial repeat" solution above (at the site level). Only cases where they would not be handled well is if there are other plots in the corresponding sites, that have different measurements.

if the vegetative composition did not make it into the plot name, I think the data will be entered only once for that plot. because the code does not enter the data if sites.sitename, plot.name, stand.age, variable.name, and mean already exist in the data base.

not sure how to deal with that.
This will get into the problems we have with plot.name (unmanaged vs treatment etc...)

That's okay. I'm making the assumption that these ecosystem-level measurements are made on the stand as a whole, and experimental treatments were applied to smaller subplots. Hence, these should not be associated with experimental treatments. @bpbond, does that make sense ?

not sure how to deal with that.
This will get into the problems we have with plot.name (unmanaged vs treatment etc...)

That's okay. I'm making the assumption that these ecosystem-level measurements are made on the stand as a whole, and experimental treatments were applied to smaller subplots. Hence, these should not be associated with experimental treatments. @bpbond, does that make sense ?

That's also okay.

for temporal repeats you are saying that, for examples, the following 2 records:

measurement.ID
sites.sitename
plot.name
stand.age
dominant.life.form
dominant.veg
scientific.name
veg.notes
variable.name
date
date.loc
start.date
start.date.loc
end.date
end.date.loc
mean
n
stat.name
stat
area.sampled
notes
method.ID
allometry_1
allometry_2
min.dbh
depth
covariate_1
coV_1.value
covariate_2
coV_2.value
conflicts
R.group
S.group
D.group
D.precedence
conflict.type
D.precedence.measurement.ID
conflicts.notes
citation.ID
loaded.from
source.notes
measurement.ID.v1
loaded.by
checked.ori.pub
ForC.investigator
required.citations
flag.suspicious

20558
BOREAS NSA-D1930
Boreal Evergreen Forest. Stand established around 1928
73
Forest
2TEN
NA
Picea mariana
NPP_0_C
2001.5
8
2000.75
7.5
2002.25
7.5
3.62
NAC
NAC
NAC
NAC
NA
NA
NAC
NA
NA
NA
NA
NA
NA
NA
NA
NA
NA
NA
NA
NA
NA
NA
Bond-Lamberty_2004_corr
Bond-Lamberty_2004_corr
SRDB Record_number:6.stand.age was fixed based on Study_midyear. Non-soil   respiration data may come from another study.
NA
Ben Bond-Lamberty; R script: Bond-Lamberty
0
Ben Bond-Lamberty
Bond-Lamberty_2004_corr, Anderson-Teixeira_2018_fagd
0

20785
BOREAS NSA-D1930
Boreal Evergreen Forest. Stand established around 1928
71
Forest
2TEN
NA
Picea mariana
NPP_0_C
1999.5
8
1998.75
7.5
2000.25
7.5
3.62
NAC
NAC
NAC
NAC
NA
NA
NAC
NA
NA
NA
NA
NA
NA
NA
NA
NA
NA
NA
NA
NA
NA
NA
Wang_2002_sscf
Bond-Lamberty_2004_corr
SRDB Record_number:20.stand.age was fixed based on Study_midyear.   Non-soil respiration data may come from another study.
NA
Ben Bond-Lamberty; R script: Bond-Lamberty
0
Ben Bond-Lamberty
Bond-Lamberty_2004_corr, Anderson-Teixeira_2018_fagd
0

will become this:

measurement.ID
sites.sitename
plot.name
stand.age
dominant.life.form
dominant.veg
scientific.name
veg.notes
variable.name
date
date.loc
start.date
start.date.loc
end.date
end.date.loc
mean
citation.ID
loaded.from
source.notes
measurement.ID.v1
loaded.by
checked.ori.pub
ForC.investigator
required.citations
flag.suspicious

20558
BOREAS NSA-D1930
Boreal Evergreen Forest. Stand established around 1928
NAC
Forest
2TEN
NA
Picea mariana
NPP_0_C
NAC
9
NAC
9
NAC
9
3.62
Bond-Lamberty_2004_corr
Bond-Lamberty_2004_corr
SRDB Record_number:6.stand.age was fixed based on Study_midyear. Non-soil   respiration data may come from another study.
NA
Ben Bond-Lamberty; R script: Bond-Lamberty
0
Ben Bond-Lamberty
Bond-Lamberty_2004_corr, Anderson-Teixeira_2018_fagd
0

sorry, I didn't meant to close and send that comment, that was an old draft

No problem. I got an email with an example, but don't see it anymore. It looked correct.

Just to confirm, can you look at https://github.com/forc-db/ForC/issues/191#issuecomment-499931557

* temporal repeats
  I think I can Identify cases where values are repeated for different ages of one same plot (471 plots/variable combinations involved).
  example:

  * site = Acadia Research Forest, variable.name = LAI
  * site = Balmoral Forest plantation, variable.name = ANPP_litterfall_0_C

Your solution is to delete ALL those records? (save them apart), correct? Before I saw your previous comment I thought I would keep only the earlier record and put "NAC" for age and date

We do want to keep only one record and put "NAC" for age and date. The example you put up (and then deleted?) was correct.

* - site = UnterluSs, variable.name = soil_C2N

In this case, looking at SRDB records 467-468 and 471-472, I'd keep one value for the no-treatment plot, with date =NAC. This is an example of spatial and temporal replicate. The spatial replicate falls into this category (From comment above): "Plots differ in experimental treatment. In this case, please keep the one associated with no experimental treatment. The logic is that these measurements were probably made on the stand as a whole, not on manipulated sub-plots."

in https://github.com/forc-db/ForC/issues/191#issuecomment-499973701
should I also overwrite age and date of the record I keep?

Only when it is repeated temporally.
On Jun 7, 2019, at 11:55 AM, Valentine Herrmann <notifications<EMAIL_ADDRESS>wrote:
in #191 (comment)https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fforc-db%2FForC%2Fissues%2F191%23issuecomment-499973701&data=02|01|teixeirak%40si.edu|08c6486538a041d9cc5f08d6eb79b66c|989b5e2a14e44efe93b78cdd5fc5d11c|1|0|636955305317269813&sdata=0lz03oSrXSg%2BDAFq0uF4FhZkx7krfyj8kpKJX6GIw3s%3D&reserved=0
should I also overwrite age and date of the record I keep?

if fact, for

site = UnterluSs, variable.name = soil_C2N

only records with manipulation = "None" make it in the database, "Compost" (record 468 and 472) is not marked for inclusion in the manipulation file.
That means that I am only dealing with 467 and 471.
See what they look like in ForC format here:

It shows me that the plot.name is not assigned correctly (age and date discrepancy). The site name does appear in ForC_issue_183_sites_legitimately_complicated.csv.
When looking at one variable at a time like in this screenshot, it does not look that complicated but the plot.names are assigned before we parse things in ForC format and it would be very complicated to do it some other time...
I could keep the earlier record (467) and change the date but I'll be deleting the data for the  other plot... but this particular case should be fixed when we manually deal with the sites in ForC_issue_183_sites_legitimately_complicated.csv.
In General:
There is no cases where looking at manipulation helps. It is always "None" or all of the same kind.
That makes me think that we might be OK if we just always take the earliest record (replacing date and age by "NAC") and deleting other(s). If all records have the same date, we just pick one and delete the other(s).
that will delete the records for most of the plots of a site.... but maybe I could add "Measurement collected at the site level" in the notes of the record we do keep?

That means that I am only dealing with 467 and 471.

In the case of this specific example, the only reason it shows up here is because of the age/date discrepancy; if plot names were assigned correctly, your code would remove this duplicate. Records such as this should / would be fixed when these "legitimately_complicated" sites are reviewed, but it will be easier if you keep just one. Definitely for these sites, your approach works (always take the earliest record (replacing date and age by "NAC") and deleting other(s)).

There is no cases where looking at manipulation helps. It is always "None" or all of the same kind.

I am surprised about this; it would seem to be just by chance and not because of how the data and code are structured. But if that's the case, we don't need to deal with these.

If all records have the same date, we just pick one and delete the other(s).
that will delete the records for most of the plots of a site.... but maybe I could add "Measurement collected at the site level" in the notes of the record we do keep?

I'm not sure I understand what type of records these are. I would have thought differences in treatment would be one of the lead factors. Do they all differ in age (legitimately or just apparently?) For instances where there are real differences in stand age, I unfortunately don't see any way to retain these in the scripted import. Unlike treatments applied to small subplots within a stand, age differences would exist at the stand level, and be real. Without knowing which plot was measured, we can't accurately assign a plot name. Those will just have to be deleted and manually reviewed if they are to be included.
But, keep in mind the possibility of false repeats:
False example:  Harwood forest has the same Litter_flux for stands aged 12 and 20 (but not 3 other ages in the chronosequence).
We want to avoid removing false apparent repeats, which could be done by applying a rule that values must be repeated across all plots at a site to count as repeats.

Final handling after in person dicussion:

Repeats in a same plot --> keep only one record and replace:
 - stand.age <- "NAC"
 - date <- "NAC"
 - date.loc <- 9
 - start.date <- "NAC"
 - start.date.loc <- 9
 - end.date <- "NAC"
 - end.date.loc <- 9

Repeats  for all plots of one site --> keep only record(s) where SRDB Manipulation is "None":
If more than one record:

if site is in ForC_issue_183_sites_legitimately_complicated.csv or in ForC_issue_183_sites_with_NAC_and_at_least_one_other_age.csv --> keep all "none" records but:
- flag.suspicious <- 1
- notes <- "see ForC GitHub issue 191."

if site is not the 2 files, --> keep only one record and replace:
  - stand.age <- "NAC"
  - date <- "NAC"
  - date.loc <- 9
  - start.date <- "NAC"
  - start.date.loc <- 9
  - end.date <- "NAC"
  - end.date.loc <- 9


[3.x] Fix infinite loop on EOF in the command line debugger

Backport of #78111 which is not easily cherry-pickable :P

Thanks!

Cherry-picked for 3.5.3.


we can do it Double time faster.

Hello,
This is a wonderful job, I was wondering why did you use the url https://www.google.com/search instead of https://www.google.com/maps/preview/entity? which looks to be almost twice faster.
I am working on a package for PHP Laravel and It looks like google expose the population time in both urls, but I was confused about which one to use.

hey,
the /search endpoint seemed more stable and less contextual for the user session. do you have an /entity request with formatted address as input?
the main reason for /search was the ability to submit a formatted address and get the data.

Hey,
Thank you for the answer. Yes the google map url also take the q param q=somePlace%someAddress%someState. I was just wondering if there was any security reason or if they might block my requests form one or another url.
here is the result after I parse it.

Can you send an example request with the full URL?

I am using PHP for my package. Here there is an example. I am pretty sure that the position are the same than the response that you are getting with your code since I also had to deal with json_decode(str_replace(")]}'", "",$googleResponse));
https://www.google.com/maps/preview/entity?authuser=0&hl=en&gl=us&pb=!1m19!1s0x88d901b7eb380cb1%3A0xc72cbc93549edbc5!3m12!1m3!1d81920.38965449497!2d-80.19856063874508!3d26.156989096290584!2m3!1f0!2f0!3f0!3m2!1i1680!2i549!4f13.1!4m2!3d26.137109!4d-80.12179499999999!5e0!9e0!12m3!2m2!1i392!2i106!13m57!2m2!1i203!2i100!3m2!2i4!5b1!6m6!1m2!1i86!2i86!1m2!1i408!2i200!7m42!1m3!1e1!2b0!3e3!1m3!1e2!2b1!3e2!1m3!1e2!2b0!3e3!1m3!1e3!2b0!3e3!1m3!1e8!2b0!3e3!1m3!1e3!2b1!3e2!1m3!1e9!2b1!3e2!1m3!1e10!2b0!3e3!1m3!1e10!2b1!3e2!1m3!1e10!2b0!3e4!2b1!4b1!9b0!14m5!1sKGvTW-KFMYGm_Qas5JbgCw!4m1!2i6986!7e81!12e3!15m18!2b1!5m4!2b1!3b1!5b1!6b1!10m1!8e3!14m1!3b1!17b1!24b1!25b1!26b1!30m1!2b1!36b1!52b1!21m28!1m6!1m2!1i0!2i0!2m2!1i458!2i549!1m6!1m2!1i1630!2i0!2m2!1i1680!2i549!1m6!1m2!1i0!2i0!2m2!1i1680!2i20!1m6!1m2!1i0!2i529!2m2!1i1680!2i549!22m1!1e81!29m0!30m1!3b1&q=Il Mulino Cucina Italiana%2C East Sunrise Boulevard%2C Fort Lauderdale%2C FL

Hey, sry for the delay.
the /entity request looks indeed significantly faster and the response is generally similar, thx for bringing it up. Using the example you posted above and only adapting the query q parameter i can't get location specific results.
Did you also adapt the pb string for each request, or what am i missing here?

Hey man, I am sorry for the delay. I was so busy working on different projects that I did not have the time to investigate that part, so I am not working on that now. I was trying to build a package for Laravel so the community could use it since it looks like we have nothing for php yet.


[Core] General Fixes to make LocalNet more reliable

Description
I was hitting issues running LocalNet off of main, so these are just a few "bandaids" to get main to a more stable state, with some debugging improvements & validations until we handle everything properly.
Issue
NA
Type of change
Please mark the relevant option(s):

[ ] New feature, functionality or library
[X] Bug fix
[X] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other

List of changes
General

Fix a few typos & added some TODOs
Automatic edits compiled by my editor

Makefile

Added docker_wipe_nodes to clear the DB and nodes without rebuilding everything

Consensus

Make logs less noisy by avoiding returning an error when it does not need to log an actual error
Panic if the validator configurations is incorrect
Release the utility context when starting a new view

P2P

Improve logging of targets at a certain height

Persistence

Do not use the KV store when loading the genesis state
Fix how the state is cleared

Testing

[X] make develop_test
[X] LocalNet w/ all of the steps outlined in the README

Required Checklist

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have tested my changes using the available tooling
[ ] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

Codecov Report
Base: 0.00% // Head: 38.56% // Increases project coverage by +38.56% :tada:

Coverage data is based on head (3d86e23) compared to base (9da5055).
Patch coverage: 80.00% of modified lines in pull request are covered.

:exclamation: Current head 3d86e23 differs from pull request most recent head 878501c. Consider uploading reports for the commit 878501c to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           main     #337       +/-   ##
=========================================
+ Coverage      0   38.56%   +38.56%
=========================================
  Files         0       33       +33
  Lines         0     2629     +2629
=========================================
+ Hits          0     1014     +1014
- Misses        0     1556     +1556
- Partials      0       59       +59

Impacted Files
Coverage Δ

p2p/raintree/network.go
20.40% <0.00%> (ø)

p2p/raintree/peers_manager.go
89.62% <ø> (ø)

p2p/raintree/target.go
89.47% <81.81%> (ø)

p2p/raintree/addrbook_utils.go
86.66% <100.00%> (ø)

persistence/types/shared_sql.go
0.00% <0.00%> (ø)

p2p/utils.go
65.38% <0.00%> (ø)

consensus/leader_election/sortition/sortition.go
85.71% <0.00%> (ø)

persistence/types/block.go
0.00% <0.00%> (ø)

shared/codec/codec.go
30.76% <0.00%> (ø)

app/client/cli/utils.go
18.40% <0.00%> (ø)

... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Because it's stored as 4 bytes anyway, so just use an int.


Bug: Cutadapt 3.5+galaxy1 parameter --strip-suffix

Message for end-users:

How to notice if you hit the bug?

The "submit" button for CutAdapt redirects to the top of the tool form. Does not actually submit.
No confirmation messages in the center panel, no new dataset(s) in the history.

How to workaround the bug?

Click on "Read Modification Options" to expand the section.
Scroll down to the "Strip suffix" section (will be highlighted by a light blue box).
Type one or more characters (any!) into that parameter, then remove those characters until empty again.
Scroll down and click on the "submit" button again.
The tool will now execute!

Developers:
The option --strip-suffix is for some reason flagged as required upon job submission (blocks the submission, and shouldn't). But if the user "touches" that parameter's free text input (adds then removes any content, even a single character), the requirement is satisfied, and the job submits.

That shouldn't be needed
It isn't obvious what is going wrong because that section is collapsed at the default and the rerun tool form view (I had help from a person that submitted a bug report who noticed/described the exact problem!)
Only happens at usegalaxy.org -- could this be related to 22.01??
Another odd workaround -- load up the tool form from a prior version of this tool using "rerun", switch to the 3.5+galaxy1 version, adjust the inputs/settings (doesn't need to include this param) -- and submit works.
This tool is included in tutorials.
Introduced in this version of the tool added to org in Dec 2021 https://github.com/galaxyproject/usegalaxy-tools/pull/447

Test histories:

org (requires workaround - single or paired) https://usegalaxy.org/u/jen/h/test-cutadapt-35galaxy1
eu (does not need any workaround) https://usegalaxy.eu/u/jenj/h/test-cutadapt-35galaxy1

Tests (those failures are due to a metadata issue, but the tests that never ran might be due to this)

https://github.com/mvdbeek/usegalaxy-tests/issues/22

ping @dannon @davebx @mvdbeek @natefoo

Screenshots
Before submit

After submit AND expanding that section

Fiddle with the parameter, and the job submits

This isn't needed anymore, the fix is deployed on usegalaxy.org

Fixed in https://github.com/galaxyproject/galaxy/pull/13523
Will be live at usegalaxy.org before Monday, March 24, 2022


Feature Request: Support for Termux Android, similar to ani-cli

https://github.com/pystardust/ani-cli
https://f-droid.org/packages/com.termux/
https://f-droid.org/packages/is.xyz.mpv/

Thank you for the feature request! We appreciate your suggestion and are currently working on implementing support for Termux on Android, similar to ani-cli. Our team is dedicated to ensuring it is done in the best possible way. Stay tuned for updates!


refactor

@phated / @doowb, how's this? It uses fewer libraries and only iterates over the value once. If you're good with this I'll merge and publish as 1.0.0.

I like this better since you have the option of getting the key and value in the function if you need it.
There was one line I made a comment on that I think was just left in by mistake, but it looks good.

I'm going to go ahead and merge this, it makes more sense than the current code, but I can make changes if necessary.


consider adding

https://github.com/weareblahs/epg the Maylasian and astro.xml EPG info
https://raw.githubusercontent.com/DAZoneK/iptv/master/iptvDE.xml    for German channels

Okay, I'll check them later.

Done. The TV guides for Malaysia and Germany have been added to the list.


Feature Request: Highly-Available Timer Actions

Thought I'd put a placeholder feature request out here for further discussions.
I'd like to execute Cron Timer jobs in a highly-available, fault-tolerant manner. I've discussed this with @Kami, @manasdk and others pretty extensively in slack in the past.
Option 1. Concurrency Policy should support Fail option in addition to Queue/Postpone
It seems to me that the simplest solution is to add a second behavior to the existing concurrency policy framework (rather than pyraft over rabbitmq). Currently the behavior of the Concurrency Policy is to postpone additional requested executions above a threshold; if we add a configurable option to fail/drop them instead of postponing them, I think this would satisfy this criteria.
Would this result in multiple executions showing in the execution history still though? I've just finished implementing a simple solution using ZooKeeper non_blocking_lock (minimal zookeeper pack forthcoming). But this results in 2x actions showing in the execution history. I hope this wouldn't occur with a more native StackStorm solution.

Thanks for opening this issue.
I do agree that something like this would be very useful. As you have pointed out, there are multiple possible solutions / approaches so it's something we still need to discuss quite a bit (feedback is welcome of course).
Ideally, the approach would be generic (e.g. something with the policies like you have mentioned), but like it or not, timers are a but special so this might not work the best in real life and we might need some timer specific thing.

StackStorm v1.6 added a cancel feature which should get us a lot of the way there.

Allow user to specify an action which is performed on an execution (delay, cancel) when a concurrency policy is used and a defined threshold is reached. For backward compatibility, delay is a default behavior, but now user can also specify cancel and an execution will be canceled instead of delayed when a threshold is reached.

One thing that we'd need special for timers is the concept of a "frequency" cap here. In other words, with a timer, multiple nodes might trigger the same rule at roughly the same time, but the latency might be such that the first instance of the job has already completed before the next instances are started. Without a concept of "lease time" or "frequency", the other jobs would also be allowed to run. Instead, I would like to say that "this job cannot run twice within a 30s period" or something similar. We can apply this to a job with a minute granularity (not scheduled to the second) without a problem and be guaranteed that our jobs will not run multiple times. Make sense?
/cc @lakshmi-kannan

Any update on whether we'll support for a frequency cap on the concurrency policy is on the roadmap? People aren't really internalizing why/what 4 of every action appearing on the dashboard means.


Patch #4 and #15: frontrunning via _transfer_in()

closes #4 and #15
cc @partylikeits1983

This resolves #4 & #15


Animated text

From #412:
Quick idea: Animate the event text and use elements like {play:openDoor} when the text animation reaches the position. Like: "You open the door{play:openDoor} and hear a sharp click.{play:click} You must have activated a mechanism inside. For a moment all seem to be silent{wait:2000}, then sharp blades snap out of the frame at you.{play:blades}". The user can skip the animation with a mouseclick.

This one looks suspicious like the ticket: "Event delay (nr 804)". I didn't make a hard reference to the ticket because I am not sure. @NPBruce @scrubbless  can either one of you confirm (and make a proper link to the ticket if that is the case)?

Those are similar, but different. This is a request to have animated text after an event triggers, while the other request is for a wait function, before an event triggers.


Full unit test suite up to V's. Merged with latest

Contains unit tests up through V's. Main unit test suite complete with test results separated into groups with comment describing what each group is.
Also included a couple simple fixes that snuck into this PR by mistake to bring a couple commands to the format in ARMv7 ref manual.

getting close!

thanks @redheadedrod !


Error handling in validating flist url

Description
Devnet, e2580a5.
When I tried to use another flist in the FullVM, I received the error Could not find flist with the provided url. due to a slow connection or network problems, rather than a message telling me that a network connection error occurred and to try again.
Steps to reproduce

Navigate to https://dashboard.dev.grid.tf/.
Connect your wallet.
Navigate to Solutions from the sidebar.
Select FullVM.
From configuration, change flist to others.

Logs/Alerts

Also the error message sounds to be improper and needing some rephrasing too.

Couldn't reproduce it with slow internet connection

please add more steps to reproduce @A-Harby

Also the error message sounds to be improper and needing some rephrasing too.

After discussions, we decidec that the current error message is the best for now

can't reproduce


logo center issue

Description
we should centered these logos respective to their text at https://docs.meshery.io/
Expected Behavior
logo should be centered
Screenshots

Enviroment:

OS: Mac Linux Windows
Browser: Chrome Safari Firefox
Version:
Device: Desktop Mobile

Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Duplicate of #7979


[release-1.8] Pulled the latest serving manifests

Fixes: #1306
Proposed Changes

Updated the serving manifests for 1.8.

Release Note

/lgtm
/approve


Buttons not getting displayed on UI

Rasa Core version: 0.10.3
Python version:  2.7
Operating system (windows, osx, ...): Ubuntu 16.04
Issue:
I am new to rasa and trying to run first example with image and buttons.  I tried given code with buttons but in my UI nothing is displayed except text
Content of domain file (if used & relevant): domain.yml
templates:
  utter_greet:
  - text: "Hey! How are you?"
    buttons:
    - title: "great"
      payload: "great"
    - title: "super sad"
      payload: "super sad"

 utter_happy:
  - text: "Great carry on!"

 utter_cheer_up:
  - text: "Here is something to cheer you up"

stories.md
##story_greet

greet

utter_greet

mood_great

utter_happy

sad path

greet

utter_greet

mood_unhappy

utter_cheer_up

nlu.md
intent:greet

hey
hallo
hey!
helloe
heyyy
helloo
hey
hallo
hiey!
hellloe
heiyyy
helloo!
ola
hilo
heyya
hiiiiiii
heyyyyyyyy
hi

intent:mood_great

perfect
very good
great
amazing
wonderful
I am feeling very good
I am great
I'm good

intent:mood_unhappy

sad
very sad
unhappy
bad
very bad
awful
terrible
not very good
extremly sad
so sad

Also I tried the same thing with image:
domain.yml
utter_greet:

text: "Hey! How are you?"
image: "https://i.imgur.com/nGF1K8f.jpg"

even now only text is getting displayed. Kindly help if it is need to defined anywhere else as well

Could you please provide more details. What UI do you use?

Using html n javascript as UI

have you built your own UI components to render the messages? In that case you will also have to create buttons from the json payload. Are you seeing the buttons in the response payload?

yes i have created my own UI but am looking a way to directly get buttons on UI when I give buttons with title and payload in yml. Is it possible.

if you have created your own UI, you will need to write some logic in the frontend to convert the json sent by rasa into html buttons

I use BotUI ( https://github.com/botui/botui ) as the UI, and there it was very easy to display the buttons of the bot's message.

very cool @zoltan-fedor ! I'm sure more people would be interested in that.

@Priya-ch do you need any more help or can we close this issue?


Enhancement to Mouse Highlighter

Description of the new feature / enhancement
In addition of highlighting the mouse on clicks, it would be nice to have the possibility to also highlight it all the time with a third color.  Not something like "find my mouse".  More like a third color that could be picked.  Ex: Cursor is Blue all the time, except on clicks, yellow on main clicks and green on alternative click.
Scenario when this would be used?
Convenient when performing tutorial recordings.  Something to clearly highlight the mouse.
Supporting information
Many tutorials in YouTube depict such functionality with other apps.  But I don't need other apps as everything (almost) is in PowerToys, and it is an official safe to install app.

/dup #14137


add custom emoji

Added a  custom thugpepe emoji with size 28 x 28 with the required data in Emotedata.ts.

pls resolve conflicts

I will fix it

I will fix it

Thanks I cannot find the conflict can you help me please?

no

you have a problem

add the { to the CryptoBTC

Yeah I did that

Is it fixed now?

yes

Okay!


add new devices and tests

Pull Request Test Coverage Report for Build 1960

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1944:
0.0%

Covered Lines:
1102

Relevant Lines:
1102

💛  - Coveralls


Issue with UI

While running UI , I am getting this error after some time.
can anyone help me to resolve this ?
[BS] Serving files from: dist/
_http_outgoing.js:491
throw new Error('Can't set headers after they are sent.');
^
Error: Can't set headers after they are sent.
at validateHeader (_http_outgoing.js:491:11)
at ServerResponse.setHeader (_http_outgoing.js:498:3)
at ServerResponse.writeHead (_http_server.js:215:21)
at ProxyServer. (C:\Users\C57920\Hygieia-master\UI\gulpfile.js:11
0:15)
at ProxyServer.emit (C:\Users\C57920\Hygieia-master\UI\node_modules\eventemi
tter3\index.js:100:27)
at ClientRequest.proxyError (C:\Users\C57920\Hygieia-master\UI\node_modules
http-proxy\lib\http-proxy\passes\web-incoming.js:139:16)
at emitOne (events.js:116:13)
at ClientRequest.emit (events.js:211:7)
at Socket.socketOnData (_http_client.js:445:9)
at emitOne (events.js:116:13)

can anyone help ?

Yes,locally

@Sbrenthughes  any update ?

Are you seeing any error in the API logs?

No , error in api logs .

@monikanaagar : Just need information on ldap integration. Is LDAP stepup is working for you ? Sorry this thread is not for ldap, but i am not getting support on ldap issue thought of asking some one who active recently. Please share if you have any

@monikanaagar did you get this resolved ?

Not able to resolve

This error causes you to not be able to use the UI? I cannot recreate this error.

yes, I am not able to use UI

I will message you directly in gitter

@monikanaagar did you ever resolve this? From our last talk it seemed to be a proxy issue.


Utilize max CPUs instead of min

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

What is the current behavior? (You can also link to an open issue here)

Always uses 1  thread

What is the new behavior (if this is a feature change)?

Use cpuCount - 1 threads.
This is preferable to using up all of a users cores in case they are trying to do anything else with their computer while running the recording.

Other information:

Wow.  So basically this plugin doesn't yet support multi-threaded rendering.
Could it be useful to make threads a configurable option? e.g. In case you really wanted to use all 4 cores instead of 3.

Thanks, @samouri for your PR.
Sorry I was busy with personal work and didn't get a chance to review the PR.  Please accept my apology

No worries, thanks for merging :)


added shopee company

@evansusu please modify the List.md file also accordingly.

@all-contributors please add @evansusu for documentation


21 login

Assuming we want to continue with bcryptjs, we should ignore the broken build tests for now. The error is well-known (see here for an explanation and here for a hack to fix it inside of /node_modules
I've had little luck with finding another popular hashing library for the client. I'm going to keep looking but this does work as intended, e.g. hashing passwords.


[Feature] Add Kibana security roles

Closes #406

❌ Author of the following commits did not sign a Contributor Agreement:
5e4ed503ed9bca2f8fb458cb221859692b569abd, 26141bdad5bb651d877167528455a7fcefde8483
Please, read and sign the above mentioned agreement if you want to contribute to this project

Signed.

Thanks for this, added some comments inline.
Can we also add an entry to the changelog for this PR.

Thanks for the reply, I updated the reviews mentioned.


Create a list of download links for each assets used in the project

for example of something was used in the project and can be downloaded (e.g. from the unity asset store) get this link.
Then create a list in the Readme.MD with all these linkts. Later, if one wants to check out our repo, they should be able to retreive all these assets via this link.

https://github.com/ValveSoftware/steamvr_unity_plugin


Add TLSConfigFromCertPath

Docker TLS info is usually laid out in a specific way by docker.
TLSConfigFromCertPath makes it easy to construct a tls.Config in that case.
For example on OS X TLSConfigFromCertPath(os.Getenv("DOCKER_CERT_PATH")) will
give us a TLS Config to speak to the docker daemon.

ping @vieux

what do you think @ehazlett

I end up writing this sort of boilerplate code whenever I'm interacting with the Docker daemon. In fact, I'm just about to write some now, which is why I decided to comment on the issue.
I could even see taking this one step further and creating a function that returns a new DockerClient based on the standard DOCKER_HOST, DOCKER_CERT_PATH and DOCKER_TLS_VERIFY environment variables:
func NewDockerClientEnv() (*DockerClient, error)

The benefit is that we now have a reusable, canonical implementation for creating a docker client from the standard environment variables. Just my 2 cents though :smile:

Ya +1 to @bradrydzewski idea. This looks like a good start. LGTM


Cool white support?

My controller is 6pin. It supports RGB + WW + CW. Sending the command: color IP 0 0 0 255 enabled only WW. Will there be CW support?

Currently not yet in the published stable version (see also #2) but I have theoretically implemented it in the planned v2 version. I still don't have a test device, so if you have one and can test it from source, it would help me a lot in the development.
If you clone the repo and check out the v2 branch you can use go run ./cmd/main.go -h to get the list of currently available commands. Otherwise ask if you have any questions.

@MoonLiightz when do you plan to release v2?

@MoonLiightz it's work!


Fixing ForeignKey fields update on Django 1.6

In Django 1.6, _meta.get_all_field_names does not return ForeignKey fields
including _id suffix, which makes the current version skip updates

Thanks a lot for the PR. This was serious bug, so sorry for the late response.


syncdata for synchronizing reservations

A common pattern in the platform code is to the need to compute a new subnet/IP to use. The way it does this is to call an infra API to see what subnets/IPs are currently in use, decide on a new free one, and then use it by writing it as part of another infra API call. This may happen in parallel in different threads. This is a common write-after-read pattern. Any easy fix to avoid two threads trying to use the same value is wrap this work with a mutex.
In cases like Openstack, the "writing" part is part of a Heat stack that is doing everything - creating VMs, networks, security groups, etc. It takes a long time (minutes), and any failure would cause the whole thing to be rolled back. So obviously we don't want to wrap the whole thing with a mutex. The fix then is to only wrap the calculation of the free value under a mutex and store it in memory. Release the lock, let the long-running write to infra happen, and after it has finished, grab the mutex again and release the reservation. All threads must check both the reservations in memory along with the state of the infra to determine a new free value.
The above works fine in the context of the CRM, because it is the single and only process that is interacting with the infra. However, we want to be able to allow the CCRM, a set of horizontally scaled services, to run the same type of code (for HA among other reasons). So we cannot use a simple mutex.
The solution is to follow the same procedure, but rather than using a mutex and an in-memory table, we use a transactional database (like Etcd) to store the reserved values. There are two deviations from the mutex based approach:

we track an object ownerID with each reserved value. If the CCRM crashes in the middle of work, the Controller will still have the owner object (i.e. AppInst/ClusterInst) in it's database. We can either retry the work, or if the object is deleted by the user, we can clean up the reservation in Etcd via the ownerID. This avoids the issue of a stale reservation.
we do not drop the reservation after the work is done (we could actually, as the source of truth is really what is stored in the infra). But we would still need to clean up any entries when the owner object is deleted to avoid stale entries, so it's redundant to do both.

This code introduces a "syncdata" package which defines a SyncFactory interface. A SyncFactory instance allows the platform code to create new SyncReservation objects which provides for doing the patterns above. The platform doesn't actually know the storage backing of the Factory and its SyncReservation objects. In the context of the CRM, it will be mutex based, in the context of the CCRM, it will Etcd based (note that CRM doesn't have access to Etcd).
The "syncdata" package provides the generic interfaces, and the mutex-based implementation. The "regiondata" package provides the etcd-backed implementation.

Yup, we'll use etcd as the kvstore, since unfortunately redis isn't stable storage, and if it gets shutdown we could potentially leak stale reservations. I don't think it will be an undue burden on etcd's storage (it was disk, not memory if I recall), as the rate of these transactions is based on changes to ClusterInsts/AppInsts, which should be low compared to things like Alerts (which we still store in etcd, btw). But it's a good thing to keep an eye on.


`expand_path': no implicit conversion of nil into String (TypeError)

Today I use the command and meet the problem. How can I do?
Slathering... /Users/song/.bundler/ruby/2.0.0/slather-6a19585ca31b/lib/slather/project.rb:270:in expand_path': no implicit conversion of nil into String (TypeError)
from /Users/song/.bundler/ruby/2.0.0/slather-6a19585ca31b/lib/slather/project.rb:270:in configure_binary_file' 	from /Users/song/.bundler/ruby/2.0.0/slather-6a19585ca31b/lib/slather/project.rb:188:in configure'
from /Users/song/.bundler/ruby/2.0.0/slather-6a19585ca31b/bin/slather:50:in execute' 	from /Library/Ruby/Gems/2.0.0/gems/clamp-0.6.5/lib/clamp/command.rb:67:in run'
from /Library/Ruby/Gems/2.0.0/gems/clamp-0.6.5/lib/clamp/subcommand/execution.rb:11:in execute' 	from /Library/Ruby/Gems/2.0.0/gems/clamp-0.6.5/lib/clamp/command.rb:67:in run'
from /Library/Ruby/Gems/2.0.0/gems/clamp-0.6.5/lib/clamp/command.rb:132:in run' 	from /Library/Ruby/Gems/2.0.0/gems/clamp-0.6.5/lib/clamp.rb:6:in Clamp'
from /Users/song/.bundler/ruby/2.0.0/slather-6a19585ca31b/bin/slather:6:in <top (required)>' 	from /Library/Ruby/Gems/2.0.0/bin/slather:23:in load'
from /Library/Ruby/Gems/2.0.0/bin/slather:23:in <main>'

I clear the ~/Library/Developer/XCode/DerivedData content, then run program. This problem had gone.


feat(model/interactions)!: add min_value and max_value on slash command options

This PR adds min_value and max_value to the NUMBER and INTEGER slash command options. The builder for Command has been updated accordingly.
Breaking changes : The CommandOption::Integer and CommandOption::Number variants now have a NumberCommandOptionData field.
Closes #1226

BREAKING CHANGE: This breaks model, but does not break util.


Wrong name on quote for poem

Hm. Well not sure if it's an 'issue' as such, but it's actually Mibo no Tadamine.
https://en.wikipedia.org/wiki/Mibu_no_Tadamine

@j4cobgarby Thanks, I didn't realize his last name should be separated in English. I'll update it in the next patch release as such.

@j4cobgarby Thank you for letting me know. I updated the poet's name.
Please feel free to reopen this issue.


DOC:  adds docstring examples for these functions: qmf, berp_zeros, b…

…and_stop_obj  Issue #7168

Reference issue

What does this implement/fix?

Additional information

Thanks @elleem! It would be great if you could add some context/motivation in these examples to aid understanding in addition to the execution of the code. Also, I would recommend only touching one module per pr as there isn't much overlap between signal and special maintainers, for example.
Finally, as these are documentation only changes we don't need to run the whole test suite so in future please could you add [skip actions] [skip cirrus] to the end of your commit as per https://docs.scipy.org/doc/scipy/dev/contributor/continuous_integration.html#skipping

Thank you so much for helping a beginner! I have tried to improve based on your feedback. :) Thanks again.

@elleem : friendly ping, are you still interested in finishing this PR?

Yes, I would really love to finish this PR. I got a new job and I have been underwater on my work. If possible, I would really appreciate a little extension and will prioritize getting this done.

Yes, I would really love to finish this PR. I got a new job and I have been underwater on my work. If possible, I would really appreciate a little extension and will prioritize getting this done.

Awesome, more time is of course possible. I would recommend to split the PR into one PR per documented function though. That will make review much easier.

@elleem Thanks for submitting this. Were you still interested in finishing? I can go ahead and make the requested changes so this makes it into the next version of SciPy, if you'd prefer.


Feature Request: 7-day incidence of hospitalizations

As I have seen the RKI API should also allow fetching the 7-day incidence of hospitalizations. This would be pretty nice to know, as this number currently gets more important than the incidence itself.
Otherwise: Thank you for your integration!

This will be part of the official integration when it got merged into home assistent


fix: fix execution of REST API query when dynamic binding is present in the URL

Description

Earlier the client would by default set a URL in REST API query config in datasource.url path if it could not parse the URL properly. This made sure that datasource.url path was non-empty as long as user entered some value in the URL input box on the REST API query config page. However, this was changed recently to fix an issue related to showing the evaluated value of dynamic binding on the client. As per the current logic, the default path for the URL has been updated to actionConfiguration.path. Hence, for newer REST API queries where datasource.url is emtpy, a validation error shows up.  This PR includes changes to stop the empty URL validation check for embedded datasources on REST API datasource URL as it can be empty now for embedded datasource.

PR fixes following issue(s)
Fixes partly #24218

Another fix required on client side for a different issue (Ade is working on it)

Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

[x] Cypress
[x] JUnit
[x] Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/build-deploy-preview


chore: deps update

Update all possible deps
Minimum supported Node.js version for development is 14, webpack is still supported v10
Update CI to ignore engines
Update CI - add valdiate-legacy-node - we are trying to install dependecies on node v10 to catch problems with installation
Update examples and fix a problem with typescript example
Regenerate types
Update assemblyscript to working latest version

Bug report - https://github.com/AssemblyScript/assemblyscript/issues/2682
Summary

🤖 Generated by Copilot at 978cc9d
This pull request upgrades some development tools and fixes spell checking and testing problems. It also enhances the code and documentation quality and performance.
Details

🤖 Generated by Copilot at 978cc9d

Update spelling and file system dependencies in package.json (link, link, link, link)

Awesome work. 🚢


procedure onError triggers when the action throws instead of the action onError

I have a authenticated procedure.
export const authenticatedAction = createServerActionProcedure()
  .onError((err) => {
    console.error("Authenticated action error...", err);
    return redirect(Routes.Login);
  })
  .handler(async () => {
    const { session, user } = await validateRequest(); // lucia auth stuff

    if (!session || !user)
      throw new ZSAError("NOT_AUTHORIZED", "Not authorized");

    return { session, user };
  });

Which I use on my server actions. Simple example below.
export const squareNumberAction = authenticatedAction
  .createServerAction()
  .onError((err) => {
    console.error("squareNumberAction error...", err);
  })
  .input(z.number())
  .handler(async ({ input }) => {
    return input * input;
  });

I if now call my server action
const { execute } = useServerAction(squareNumberAction);

async function onSubmit() {
  await execute("invalid input");
}

// or just call the server action directly

I expect to get a INPUT_PARSE_ERROR and my console should log squareNumberAction error... {err} but instead the onError of the procedure triggers and I get redirected (the auth is valid).
Also I tested it with just throw new ZSAError(.....) in the handler of the action, same result.
Am I mixing up a order of chaining here or is it something else?

Hi! Thank you for sharing code example. Apologies if the API is misleading but this is to be expected: Callbacks defined on a procedure will run for all actions that utilize that procedure. The reason it is like this is you may want to define onError once to handle all errors in child actions.
In your situation, I would recommend just redirecting inside of the handler.

Okay awesome, thanks for the quick response and explanation :rocket: I'll start redirecting inside the handler!


quick fix for rule keyword_case

right now it can be fixed by running the pretty printer
but the command line --fix and fix via annotations does not work currently

ref https://github.com/abaplint/abaplint/issues/790, the pretty printer should just apply a set of quick fixes

starting this


[duoplay] Add Duoplay extractor

Description of your pull request and other information

Adds extractor for duoplay.ee site
Example:

https://duoplay.ee/4312/siberi-vomm?ep=24

Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[x] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Copilot Summary

🤖 Generated by Copilot at 61a6bcc
Summary
🚚📄🛠

Added a new extractor class DuoplayIE to handle videos from the duoplay.ee website. Created a new module duoplay.py to define the class and its extraction logic.

DuoplayIE class
extracts video formats
from winter website

Walkthrough

Create and register a new extractor class for duoplay.ee videos (link, link)

Import helper modules and define DuoplayIE class in duoplay.py (link)
Implement _real_extract method to parse video webpage and extract info and formats (link)
Define _VALID_URL pattern to match duoplay.ee URLs and _TESTS cases to verify extraction (link)
Use custom logic to obtain and update session token from sts.postimees.ee API (link)
Leave some debugging code and unfinished parts for further development (link)
Import DuoplayIE class in _extractors.py and register it with gen_extractor_classes (link)

downloads the example url. need to update test next

added more metadata, so you can use this output format to save file with show and episode info:
 -o "%(series)s S%(season_number)02dE%(episode_number)02d - %(title)s.%(ext)s"

🤖 Generated by Copilot at https://github.com/yt-dlp/yt-dlp/commit/61a6bcce79873bf55f036b3d5ed353a50a7e372a

Can copilot be refreshed to use HEAD commit?

Can copilot be refreshed to use HEAD commit?

Don't worry about it. Copilot is pretty useless and will be removed soon.

so. this is ready from my side (changed pr to non-draft). can this be reviewed now?

@seproDev thanks for the feedback! addressed the issues. CI should pass as well.

yay. thanks @seproDev, @bashonly!


chore: Revert "feat: Machine Migration (#176)"

This reverts commit db6d9e12f944c1c47b506eb5d91f0682aa71505c.

Fixes #
Description
Reverting the PR #176 to give more time for testing and to unblock other changes and release. This PR #176 will be re-opened and will go in at a later date.
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

768 of 929 (82.67%)  changed or added relevant lines in 47 files are covered.
66 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-0.002%) to 80.926%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/machine/registration.go
3
4
75.0%

pkg/metrics/metrics.go
0
1
0.0%

pkg/operator/injection/injection.go
8
9
88.89%

pkg/controllers/node/finalizer.go
11
13
84.62%

pkg/apis/v1alpha5/zz_generated.deepcopy.go
2
5
40.0%

pkg/controllers/deprovisioning/expiration.go
21
25
84.0%

pkg/controllers/machine/terminator/terminator.go
14
18
77.78%

pkg/controllers/termination/controller.go
6
10
60.0%

pkg/controllers/node/initialization.go
48
53
90.57%

pkg/controllers/deprovisioning/drift.go
14
20
70.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/deprovisioning/consolidation.go
1
62.24%

pkg/controllers/deprovisioning/drift.go
1
69.49%

pkg/controllers/inflightchecks/nodeshape.go
1
71.43%

pkg/controllers/machine/launch.go
1
82.22%

pkg/controllers/machine/liveness.go
1
90.0%

pkg/controllers/provisioning/provisioner.go
2
78.9%

pkg/controllers/termination/controller.go
2
44.44%

pkg/test/environment.go
3
91.94%

pkg/controllers/node/controller.go
4
73.53%

pkg/controllers/state/informer/machine.go
5
59.26%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
6394

Relevant Lines:
7901

💛  - Coveralls


More robust check for _soundfile_data package

Rather than trying to create the location for _soundfile_data/ manually, simply import it and use its reported __path__
The existing method fails if using macos lib packaged with py2app because:

starting path for soundfile is /lib/python38.zip/soundfile.py
desired path fro soundfile_data  is /lib/python3.8/_soundfile_data
the previous method of stepping back from the starting path never reaches this desired path (it tries /lib/_soundfile_data and fails)

Note that the other annoying thing (that I haven't improved here) is that there isn't good information coming back to the user about what paths were checked and which failed (e.g. at least in the case of an ultimate failure). I wonder if, for each attempted path, it would be worth storing the path that was tried and the reason it failed (didn't exist, wrong arch...) and then printing that list out if all methods fail?

Thank you for your contribution. At the moment, this is failing the tests on Windows.

Sorry, yes, I'll look into it further. Looks like __path__ might not be very reliable in other ways. I'll see what I can do with it.
Another idea might be that the ctype loading is done in _soundfile_data/__init__.py at which point the dll will be in the same folder and no need to worry about paths at all

Looks like __path__ might not be very reliable in other ways.

You can try what I did here: https://github.com/spatialaudio/python-sounddevice/blob/89f124b20f994b29a3f37fe21455604d7579cd49/sounddevice.py#L81-L82
This seems to work reliably, at least I haven't heard any complaints.

OK, so what I did in the end was to insert an empty __init__.py into the _soundfile_data. That's the key to _soundfile_data having a __file__ property and __file__ is a pretty well-behaved attribute. As long as the dylib is always next to the _soundfile_data/init.py then its easy just to import and now have to worry about where it is. Again this is all to get around the issue that soundfile and _soundfile_data might not be in the same locations. Since both have been placed on the python path then it's easier not to try and find them manually, just let the import infrastructure do that and then query where they came from after
It looks like just one of the pypy test suites failed due to a recursion error on the GIL but I'm guessing that isn't related to what I've done with the paths

Oh, I haven't checked by the way that this also works using cx_freeze which was the original use of the previous code. Maybe @Timtam can check that this is still fine in his setup

@peircej I've been summoned?
Hm, I cannot remember working with this lib lately. Can you give me an issue or something where I mentioned soundfile somewhere so that I can remember my use case again, or how did you come to the idea that I might be able to help here? :).

No worries @Timtam
Your involvement is described at #192 but that is 5 years ago
Basically, you were packaging soundfile inside an app packaged with cx_freeze which identified a problem in the way that libsndfile.dylib was being detected. Don't worry though - if you aren't doing that anymore then I don't think it's worth digging back up. I'm relatively confident the new method I propose will be fine packaged with cx_freeze as well as in py2app (which is my own use case)

Thank you very much for your efforts! This looks much simpler and more robust indeed.
I'll merge it when you say it's ready.

This will be included in https://github.com/bastibe/python-soundfile/pull/364


How to force no lyrics?

Tried to use None and "" as lyrics, as actually not incluting property in dict. All variants produces text from time to time.
Adding "instrumental" into prompt doesn't help since being associated with orchestral instruments. Seems the word "no" is not getting into the account at all.
Same prompt on web site makes tracks with no lyrics with ease.

Actually, the problem is solved in generate_song(). lyricInput was set to None if "" detected.

I don't know what that  mean and  your tips  how forced  no  lyrics,can  you explain this?

Sorry  became lm
From china  your  say  some  world  l don't understand  sorry  about that


checklist and tabs

Looks great - thanks!  :woman_dancing:
Thanks @rpanai and @Coding-with-Adam

Hi Ann,Can you please revert this merge. Roberto had not finished making all the changes/updates I asked him to make prior to merging.Thank you,Adam SchroederOwnerCharming Data LLC 118 E 124th ST #1808, New York, New York 10035   My Pronouns: He, him, his ¡Hablo español!
      On Apr 23 2022, at 9:01 pm, Ann Marie Ward<EMAIL_ADDRESS>wrote:

Looks great - thanks!  💃
Thanks @rpanai and @Coding-with-Adam
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Hi Adam - No problem - but it’s probably easier to do a new PR for the changes and I’ll merge those when it’s ready

You mean instaed of waiting for him to make the changes, do a PR and have him approve it before merging?
Adam Schroeder
Owner
Charming Data LLC
118 E 124th ST #1808, New York, New York 10035

My Pronouns: He, him, his
¡Hablo español!
On Mon, Apr 25, 2022, 12:32 am Ann Marie Ward<EMAIL_ADDRESS>wrote:

Hi Adam - No problem - but it’s probably easier to do a new PR for the changes and I’ll merge those when it’s ready
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
[
{
@.***": "http://schema.org",
@.***": "EmailMessage",
"potentialAction": {
@.***": "ViewAction",
"target": "https://github.com/AnnMarieW/dash-app-gallery/pull/11#issuecomment-1108068416",
"url": "https://github.com/AnnMarieW/dash-app-gallery/pull/11#issuecomment-1108068416",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
@.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]


When using PickPhotoAsync with PhotoSize option - photo is overwritten inside the gallery.

Bug Information
Version Number of Plugin: <IP_ADDRESS>-beta, 3.0.1
Device Tested On: Xiaomi Redmi 4, Redmi 4 Pro
Simulator Tested On: -
Version of VS: Community 15.4.4
Version of Xamarin: <IP_ADDRESS> (Xamarin Forms <IP_ADDRESS>635)
Steps to reproduce the Behavior
Use PickPhotoAsync with PickMediaOptions PhotoSize.
Expected Behavior
Returned image has reduced size, initial image in gallery is not changed.
Actual Behavior
Initial image in gallery has reduced size.
Code snippet
await CrossMedia.Current.PickPhotoAsync(new PickMediaOptions             {                 CompressionQuality = 50,                 PhotoSize = PhotoSize.Medium,             });
It seems to be a device specific thing, as Sumsung device works as expected.

@jamesmontemagno any thoughts on how this should work?

it shouldn't override the existing, and pretty sure that is impossible as it has copied it locally by then.

Since it is device specific there is really nothing that I can fix or do about it. So closing this. But feel free to investigate and send a pr


[question] Is it possible to obtain a wasm function address by name using C API?

WASM function pointers are just indexes in indirect function table.
We can build binary  with this table enabled, and we can even access this table
using wasmtime C API.
What we see there is:

0  type1
1  type2
.....
We can also browse exports and  we see there exported function names.
We can use the wasmtime API to get named export and call it normally (using API)
The problem is that looking at function table there is no way to determine which function has which name,
and thus  it is not clear what index do I need for some named function.
The use case is very simple:
having a function name (provided by user), pass a pointer to it to another function in wasm module.

Not every exported function is guaranteed to be present in the table used for indirect calls. In fact you will likely only find the functions that the wasm module itself turns into function pointers.

ok, since we have a way to call function from wasmtime, is it somehow possible to pass some information into wasm to call the  function there? I mean, extract some address of function from found extern? (yes, extern is just index inside engine/store, but somewhere inside there should be information about function real addres).

If the goal is to translate any name into a function pointer that needs to be done in the guest itself. As a host you can lookup exports by name but that doesn't include all functions. You can also lookup functions by their index in a table but as @bjorn3 not all tables are guaranteed to be in the function. There's currently no way for the host to invoke arbitrary functions in the guest, it's only those that are exported or a table.

Of course, we are talking about explicitly exported functions.
I have a function on a target that accepts function pointer and want to call it from host.
(and pass the function I found by name on the host)
The problem is that I cannot get pointer to function (usable for wasm function) on the host.

If the goal is to translate any name into a function pointer that needs to be done in the guest itself.
Is this possible in the guest at all? Any hints are welcome. Does wasm provides some metadata inside the guest by standard means?

Is your goal to get a literal native function pointer? If that's the case that's not possible. You can only invoke WebAssembly through the wasmtime_func_call* APIs. You can acquire a wasmtime_func_t which is sort of equivalent to a function pointer as it's passed to wasmtime_func_call* but you won't be able to acquire a literal native function pointer.

I believe the question here has been answered so I'm going to close this, but if there's any follow-ups or else feel free to comment and/or open a new issue.


[v2] Code Runner and Redhat Java extensions cannot run code in EC2 when Chrome or Safari are used

code-server version:

info  2.1665-vsc1.39.2
info  3d5db8313a91f80dfc402450fd117b4e63f7711e
info  x64

N.B. I am not sure that this issue is strictly related to the specific version of code-server. I had a similar experience with just running Java code from within the IDE on an EC2 VM even before. Now I can confirm that code snippets also misbehave.

OS Version: Ubuntu VM hosted by Amazon EC2, client machine is macOS Catalina with latest Firefox, Chrome, and Safari installed.

Description
I have built a Docker image with Java support (https://github.com/redhat-developer/vscode-java) which is also able to execute code snippets from many other languages (https://github.com/formulahendry/vscode-code-runner). Containers based on this image work equally well when run on my local macOS machine with latest versions of Firefox, Chrome, and Safari.
I run a container based on this same image on a VM in Amazon EC2. Using Firefox I am able to run code snippets supported by the code-runner extension and use vscode-java to execute Java applications or tests from within the VS Code.
Using the Chrome or Safari web browsers to connect to the same container, none of those worked. I see that extensions are being activated but nothing really happens when trying to execute code snippets or Java code.
Maybe there is something to be configured. I am not sure. Any recommendation how to get Chrome (and potentially Safari) working against a Docker container run on an EC2 VM would be highly appreciated.
Steps to Reproduce

Launch a t2.large Ubuntu VM in EC2.
Run a docker container which supports Java (vscode-java) and/or running code snippets (code-runner) on top of this VM.
Use Firefox to execute code snippets or Java code from within the IDE. Should work.
Use Chrome or Safari to execute code snippets or Java code from within the IDE. Most likely without success.

I'll try this out as soon as I can but in the meantime here's a wild shot in the dark: is the URL somehow HTTP for Chrome/Safari but not Firefox? I've seen issues running tasks when service workers aren't available (which happens on HTTP).

Negative. The URL is always a http://... for all browsers. Currently, it's not secured in any way as I am running a multi-stage MVP and SSL would be a bit too much for the current stage. I also just spin up the container. There is no load balancer/reverse proxy whatsoever in between.
By the way, I can share a Dockerfile that may save few minutes on your side and just give you the opportunity to play around and observe. Would that help?

Yeah, that sounds great.

So here is the content of the Dockerfile. Few things to keep in mind:

The Redhat Java language support extension fails to activate (something which I don't face as an issue). Might be related to the archtetype used for project creation.
[EC2] Right click on the org.example.App Java file and select Run Code. This will use the code-runner extension or create a groovy file and do the same. This will work well in Firefox (at least you will see that some class is not found). Nothing will happen once you try it in Chrome, Chromium or Safari.
[local machine] The same flow will work with all browsers.

FROM codercom/code-server:latest

ENV PASSWORD=init1234

RUN sudo apt-get update && \
    sudo apt-get install unzip zip curl openjdk-8-jdk maven -y

ENV JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64

RUN curl -s get.sdkman.io | bash && \
    /bin/bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && sdk install groovy"

# Set up maven project
WORKDIR /home/coder
RUN mvn -B archetype:generate \
        -DarchetypeGroupId=org.apache.maven.archetypes \
        -DarchetypeArtifactId=maven-archetype-simple \
        -DarchetypeVersion=1.4 \
        -DgroupId=org.example \
        -DartifactId=my-project \
        -Dversion=1.0-SNAPSHOT

# Install extensions
RUN code-server --install-extension marlon407.code-groovy && \
    code-server --install-extension formulahendry.code-runner && \
    code-server --install-extension vscjava.vscode-java-pack

WORKDIR /home/coder/my-project

RUN mvn test

ENTRYPOINT ["dumb-init", "code-server", "--host", "<IP_ADDRESS>", "/home/coder/my-project"]

I haven't ran this in EC2 yet but it seems like our Java extension is missing files. If I go into the extension and run (after installing npm):
npm install
./node_modules/.bin/gulp download_server

Then it activates properly. It remains to be seen whether this is the cause of the Chrome/Safari issues but I'm pretty confused because those files seemed to exist before. We really need to tackle improving our extension marketplace next I think.

I haven't ran this on EC2 yet but it seems like our Java extension is missing files. If I go into the extension and run (after installing npm):
npm install
./node_modules/.bin/gulp download_server

Then it activates properly. It remains to be seen whether this is the cause of the Chrome/Safari issues but I'm pretty confused because those files seemed to exist before. We really need to tackle improving our extension marketplace next I think.

On my side, running npm install --production in the folder of the Java Support extension from RedHat did not help. It looked like all of the npm packages had already been installed. On a side note, any update on what might be wrong in regards to hosted code-server, e.g. containers running on top of EC2 VMs?

On my side, going through the steps outlined above helped with getting the Java language support extension activated. However, the reported issue is still there, i.e. I cannot run Java code and code snippets through code-server hosted by a EC2 VM. After 30 min. the VSCode running in a Chrome browser still says "Activating Extensions..."
I opened the Developer tools in Chrome. There are errors and warnings. The warnings are still there with Firefox, there are no errors. I guess these would should be some hints as to what might be wrong.

Ahh that's interesting! The undefined error there happens on insecure domains but I don't know exactly why yet. The fact that Firefox doesn't have that error but Chrome does seems to be a pretty big clue in the right direction.
It turns out I was able to replicate this locally using just the Dockerfile. On an insecure domain (I'm just using my hosts files to point to localhost since localhost itself is considered secure) Chromium doesn't work but Firefox does, and I see the same difference in errors you described.
I could have sworn I tested an insecure domain last Friday but I'm testing it now and it definitely isn't working so I must have imagined it. It just spins with "activation extensions".

Now, code-server works great on top of EC2 VMs even without a LB in front. Thank you so much, team! Highly appreciated.


graph in 'Live raw' mode in the GUI doesn't seem to display correctly

When running processing and activating the 'Live raw' button, the left-side plots disappear after a couple of images and never come back.

can no longer reproduce this.


Are you interested in merging my changes?

I've added the following things:

You can start an About Page with only an Intent (with an IntentBuilder)
Some enhancements to your code
Some premade Items wich you can simply add with the ConvenienceBuilder class

I would tidy up my code a little bit and would then open a pull request.
You can take a look at my changes here: https://github.com/ueman/material-about-library/

Your code looks interesting! If I'm honest, I wouldn't want to merge all of it but I've just spent some time looking through your code and it looks great.
I'm not sure about starting the about page with only an intent, I decided to go for extending an abstract class as it allows for more functionality and because it's not possible (as far as I'm aware) to pass in the MaterialAboutList - I've tried parceling but obviously that didn't work out.
I however, love the idea of the ConvenienceBuilder class. I would like to merge that but don't think bundling icons with the library is a good idea. Maybe you could make the builders less specific (eg remove the facebook one but leave the website one).
I'm sorry if I'm being a bit picky and I hope you're not offended or anything! I really do appreciate the work you've done on the library.
You could open a pull request and then I can refactor the code to only include the things I would like to implement?

The IntentBuilder for the AboutPage was intended as an addon for even simpler creation of an AboutPage.
Yeah, I'm not offended or anything.
I'm doing a Pull Request then and you can do whatever you want with it.

I'm going to be slightly busy over the next couple days, so will merge this weekend. Thanks again!

You could also look into this commit on how to simplify you code a little bit and on how to remove those instanceof if-else things. Unfortunatly that code isn't in the pull request because I messed up. Sorry about that.


Syslinux

Adds the PXE/SYSLINUX module that will generate pxelinux.cfg files for configuring the bootloader of the client machines.

Pending changes the OS Files Download PR this PR may need several changes. Delaying merge until more input from sponsor.


Changing the prompt in the Titan Adapter doesn't actually change the prompt.

The custom prompt defined in the Titan Adapter isn't actually being used by the model, cloudwatch logs still show that the model is using the default langchain prompt Use the following pieces of context to answer the users question. If you don't know the answer, just say that you don't know, don't try to make up an answer.

Nevermind, realized that you cannot actually specify a custom prompt to ConversationRetreivalChain unless you specify certain kwargs. Closing this issue but if you need to do this you can find a similar question here https://github.com/langchain-ai/langchain/issues/6530#issuecomment-1613535813


added studio to overviews and checkboxes

Closes #42
Converted grid of committees into 3x3 grid, maintained responsiveness.
Made committee names and boxes slightly bigger to account for bigger box size.
Added studio to checkboxes.js so it shows up as an option for source in search results.

Made changes: Added Studio resources in categories, technologies and resources.


Improve efficiency, multi-implementation support, and future proofing

Optimises the none RTB data model to reduce the number of bytes needed when performing crypto graphic operations thus improving overall performance and efficiency of the solution. Additional changes address future proofing issues or multi-implementation complexity with the current design.
The changes here fully address issues #264, #194, #193, #184, #179.
These changes relate to #139.
The changes to reduce the bytes needed for signing are:

Version is a single byte not a string or double. One byte rather than minimum of four bytes.
Identifier’s ID type is an enum of “rid” or “sid”. These now require four bytes.
Require base 64 representations of byte arrays to be converted to byte arrays before being used in data for signing. The length of the byte array is written as a 4 byte unsigned integer, followed by the array of bytes. Therefore a 64 byte UUID will consume 68 bytes.
Removed the Unicode separator used to concatenate data for signing saving two bytes.
The source domain as a null terminated string saving one byte.
The source timestamp is a four byte unsigned integer representing the number of minutes since the epoch of 1/1/2020 are used for the source data when signing. See comments add to the timestamp entity for the reasons for storing the timestamp in minutes and not seconds. This saves four bytes.
Remove the relationship between the identifier and the preference data entities. They are signed and changed independently of one another.

Other changes are:

Source includes a version field to support changes to the cryptographic algorithm.
Identifier and preferences both contain a persisted field.
Added the RID, SID (Signed in Identifier not currently used in the MVP), and preferences to the Seed. This ensures the seed contains all the necessary information to support the transmission requests and responses in a single location reducing complexity.
Removed the type field from the identity response as we do not need to know the role of the signer in the eco-system, and in any case some signers will have multiple roles.
Removed the “end” timestamp from the identity response public key as this is not relevant.
Changed the name of the timestamp in the identity response public key to “created” as this is the information that is needed.
Changed the “type” field name to “id_type” to avoid name space conflicts in languages where “type” is a reserved word.
Add the type terms-url together with the rules associated with the HTML response provided including the addition of a  element to make the response machine readable and to learn the version of the Model Terms being used by the signer.

Considerations:

This PR does not resulting in an operational project as the changes are breaking changes. Once reviewed the dependent code will need to be refactored by the mantainers. This includes the simple task of renaming or removing fields (created not start), using new value types (byte instead of string), and then modifying the signing definitions logic to use byte arrays rather than strings.
This commit/pull request does not yet apply the same direction of efficiency improvements to the transmission OpenRTB data entities. The reviewer’s opinion on these changes is sought before a further modification is submitted.

A concrete implementation of these changes can be found on the SWAN go repository - https://github.com/SWAN-community/swan-go/tree/feature/ok-refact which is currently being refactored to support a hybrid addressability framework that would include these efficiency and future proofing improvements ahead of live deployments.

@OlivierChirouze @RomainLofaso @broggeri @BasileLeparmentier - I see other PRs are being approved which over time will impact this one and make integration harder. Is there any chance of initial review this week?

@OlivierChirouze @broggeri @RomainLofaso @BasileLeparmentier To update you on progress we have now made the entities needed to support this direction available on the SWAN-Community organization. We'd like to progress this PR here to ensure efficiency, performance, and consistency of approach across multiple implementations.
I believe the classes will fit neatly into the OneKey implementation should others wish to use them. Specifically, the tight coupling of the signing and verification logic, and the different entities. The approach also aligns very well to other programming languages include Go, C#, and Java.
These classes are the basis of the code used in https://preference.express which is progressing to trials.
Adding @bwschmidt in case there is additional interest in reviewing/commenting.


minimumizing spacing between cells...

hey Jesse et al, is there something in the library is that is creating spacing between cells? I am trying to remove ALL space between cells to allow a contiguous block of cells with a particular background to look unbroken.
I added the following to overrides but there is a faint spacing that i cannot seem to remove. I will replace the graphic i am using, but i doubt that is the issue. I have fiddled with the bounds of the rect of the image even extending it too far but the faint empty space remains. It looks like it is about a height of 1.
This space is at the bottom of the cell as the next bubble is butted up against the top of the space.

are you returning zero height for all the cell labels? on the collectionViewFlowLayout, you can also set a minimumItemSpacing

no, as i am using them as per my requirements, but that part is working properly, or so it seems. The logic in the setting of the data is exactly paralleling the logic of the returned heights, but i will double check. Perhaps there is an issue with the bottom label's background not being set. As far i can tell at this point, this is not the case, but i have been wrong before.
I also have the following in place:
- (CGFloat)collectionView:(UICollectionView *)collectionView layout:(UICollectionView *)collectionViewLayout minimumInteritemSpacingForSectionAtIndex:(NSInteger)section
    {return 0.0f; // This is the minimum inter item spacing, can be more}

- (CGFloat)collectionView:(UICollectionView *)collectionView layout:(UICollectionView *)collectionViewLayout minimumLineSpacingForSectionAtIndex:(NSInteger)section
    {return 0.0f; // This is the minimum inter item spacing, can be more}

I have yet to see a reasonable explanation as to why Apple pushed us to write separate methods to handle the content and the height, as the two are seldom NOT connected. It is a pain of design.

kind of perplexing, as i have tweaked just about everything, I may re-examine the background setting process, but i removed all sizing and just pushed it through, just in case, with no change.
I will adapt the latest demo to see if this exists there. {when time permits as this is not a critical sprint}

Thanks @wdcurry !
Going to close. Please post here if/when you can repro in the demo!


User Agent is: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
\ file:
var difference = 45 - 0;

var difference = 45 - 0;

\ file:
var difference = 45 - 33;

var difference = 45 - 33;

Please describe how to reproduce this issue, and include links to screenshots if possible.

Due to the high amount of noise due to the new release, I'm closing for now. Please provide details for this issue to be re-opened.
Happy Coding


[libsecret] add new port with version 0.20.4

Describe the pull request

What does your PR fix?
Adds libsecret so it can be used by the qtkeychain port

Which triplets are supported/not supported? Have you updated the CI baseline?
 It does appear to be installed correctly by the glib package, so I don't know why Meson is failing to find it...
vcpkg on  libsecret [$] took 2m28s
❯ find . -name gdbus-codegen
./buildtrees/glib/x64-linux-dbg/gio/gdbus-2.0/codegen/gdbus-codegen
./buildtrees/glib/x64-linux-rel/gio/gdbus-2.0/codegen/gdbus-codegen
./installed/x64-linux/tools/glib/gdbus-codegen
./packages/glib_x64-linux/tools/glib/gdbus-codegen

vcpkg on  libsecret [$]
❯ ./installed/x64-linux/tools/glib/gdbus-codegen
usage: gdbus-codegen [-h] [--interface-prefix PREFIX] [--c-namespace NAMESPACE] [--c-generate-object-manager]
                     [--c-generate-autocleanup {none,objects,all}] [--generate-docbook OUTFILES] [--pragma-once]
                     [--annotate WHAT KEY VALUE WHAT KEY VALUE WHAT KEY VALUE] [--glib-min-required VERSION] [--glib-max-allowed VERSION]
                     [--symbol-decorator SYMBOL_DECORATOR] [--symbol-decorator-header SYMBOL_DECORATOR_HEADER]
                     [--symbol-decorator-define SYMBOL_DECORATOR_DEFINE]
                     [--generate-c-code OUTFILES | --header | --body | --interface-info-header | --interface-info-body]
                     [--output FILE | --output-directory OUTDIR]
                     FILE [FILE ...]
gdbus-codegen: error: the following arguments are required: FILE

You probably need to explicitly pass the progran. See e.g. how the gtk port does it for other stuff

You probably need to explicitly pass the progran. See e.g. how the gtk port does it for other stuff

That works, but I don't understand why that is needed and it is not documented.
vcpkg_configure_meson(
    SOURCE_PATH "${SOURCE_PATH}"
    OPTIONS
        -Dintrospection=false
        -Dgtk_doc=false
        -Dmanpage=false
        -Dvapi=false
    ADDITIONAL_NATIVE_BINARIES
         gdbus-codegen='${CURRENT_HOST_INSTALLED_DIR}/tools/glib/gdbus-codegen'
         glib-mkenums='${CURRENT_HOST_INSTALLED_DIR}/tools/glib/glib-mkenums'
)

This is working now. I cherry picked this to #20185 to confirm it works with qtkeychain which was why I added this port.


Index spam status

Add spam attribute to several indices of models can that can be spam, and added suspended to the user index. Closes #1735

I added some preloading to save queries when bulk indexing. Otherwise looks good to me


Automated cherry pick of #4636: fix: 加强密码校验

Cherry pick of #4636 on release/2.14.
#4636: fix: 加强密码校验

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.14@1e25efc). Click here to learn what that means.
The diff coverage is 50%.

@@              Coverage Diff               @@
##             release/2.14   #4638   +/-   ##
==============================================
  Coverage                ?   6.88%
==============================================
  Files                   ?     523
  Lines                   ?   88971
  Branches                ?       0
==============================================
  Hits                    ?    6123
  Misses                  ?   82341
  Partials                ?     507

Flag
Coverage Δ

#aFlag
6.88% <50%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/dbinstances.go
1.01% <0%> (ø)

pkg/util/seclib2/seclib.go
88.88% <71.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e25efc...6ebed3b. Read the comment docs.

/lgtm

/approve


Tests with and without simplejson for every existing testenv

changes configuration for tox and travis. Assist from @davidism

LGTM


It looks like the attestation ignore rule is basically covered by gossip cache now, because attestations are all compressed the same and so give the same signature.
I've been doing some testing in Teku on this, and some duplicates do seem to come through, but they're outside of the gossip cache timeout, and they'd be missed by any cache we keep unless we're keeping all seen attestations for more than 6 minutes
2021-09-09 12:35:40.300+10:00 | SeenAttestationAtSlot{slot=2027576, committeeIndex=45, committeePosition=68}; Attestation{aggregation_bits=SszBitlist{size=129,<PHONE_NUMBER>00000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000}, data=AttestationData{slot=2027576, index=45, beacon_block_root=0x89b76c7a52f05210e7d9bb16db2a3e1fc3d006ca587bab1aba5bc8b4d417b94e, source=Checkpoint{epoch=63360, root=0xd2e31a4d650340bbcebfd92aa3830cb8d596a77e1acab35255df6c3a43a19259}, target=Checkpoint{epoch=63361, root=0x9632cade23ba087a60e165a703587d6da1289f33dd0832ec5c359e92235cd9bd}}, signature=SszByteVector{0xb26fd4ad81451c374b48bfe32fb6a3ce5c2d783a04fcb4031dcb0eb7c549193d0de468372b6946de99998a226248f7cf073f435df139f781d1c678d4de70d81a7dd02f4f6002c740b705c6585e45b0985b00f593b4b88c517ce2bccf9a3a61cc}}
...
2021-09-09 12:42:06.614+10:00 | SeenAttestationAtSlot{slot=2027576, committeeIndex=45, committeePosition=68}; Attestation{aggregation_bits=SszBitlist{size=129,<PHONE_NUMBER>00000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000}, data=AttestationData{slot=2027576, index=45, beacon_block_root=0x89b76c7a52f05210e7d9bb16db2a3e1fc3d006ca587bab1aba5bc8b4d417b94e, source=Checkpoint{epoch=63360, root=0xd2e31a4d650340bbcebfd92aa3830cb8d596a77e1acab35255df6c3a43a19259}, target=Checkpoint{epoch=63361, root=0x9632cade23ba087a60e165a703587d6da1289f33dd0832ec5c359e92235cd9bd}}, signature=SszByteVector{0xb26fd4ad81451c374b48bfe32fb6a3ce5c2d783a04fcb4031dcb0eb7c549193d0de468372b6946de99998a226248f7cf073f435df139f781d1c678d4de70d81a7dd02f4f6002c740b705c6585e45b0985b00f593b4b88c517ce2bccf9a3a61cc}}

I'm not sure why these super late attestations seem to be getting gossiped, but the ignore rule misses them due to how late they are (cache has well and truly moved on by then) and gossip seems to be de-dup'ing the rest...
When I was discussing our Teku attestation seen cache sizings with @protolambda we decided to raise a ticket so that there could be a discussion on anything that we might not have considered.

Happy to close this if we're keeping the rule...


Analyzer fails to recognize static function calling a non-static function inside an anonymous function.

import 'package:test/test.dart';

void main() {
  test('static bug', () {
    expect(Foo().baz, 3);
  });
}

class FooBase {
  final int baz;

  FooBase(this.baz);
}

class Foo extends FooBase {
  Foo() : super(_bar());

  static int _bar() {
    return () {
      // Analyzer should show an error here
      return _foo();
    }();
  }

  int _foo() {
    return 3;
  }
}

Expected Behavior:
Analyzer showing that foo() can't be called from _bar();
Actual Behavior:
Compilation Error "Method not found: foo()"
The weird thing is that the analyzer in dartpad works correctly: https://dartpad.dev/b35639b80e1af9750dd00b97142131ef
although I have Dart 2.9.0 and Dartpad says "Based on Dart SDK 2.8.4".
Dart Version:
Dart VM version: 2.9.0-5.0.dev.flutter-4da5b40fb6 (be) (Wed May 6 16:59:45 2020 +0000) on "macos_x64"

@scheglov might this be addressed by the scoping work you are doing now? Just a thought.

My expectation (and hope :-)) is that the answer is "no". The analyzer is correctly resolving the reference to _foo to the instance member. This is necessary for the IDE experience. The only thing wrong is that it isn't producing the necessary diagnostic (which should use the error code is CompileTimeErrorCode.INSTANCE_MEMBER_ACCESS_FROM_STATIC). I don't know why the diagnostic isn't being produced, but it isn't likely to be a result of the structure of the name scopes.

Brian is right, it is not related to name scopes, but I think I know when I might have broken it, or failed to fix at least.
We have a single "enclosing executable", and "the most enclosing" here is not a static method.
So, we probably should just chain them and check if we are inside of a chain that has a static member.

https://dart-review.googlesource.com/c/sdk/+/155144

Ah, I understand the difference; that's super interesting. Thanks!


Add platforms, architectures, and amd64 container build to goreleaser

this enhances goreleaser with additional platforms and architectures, as well as an amd64 container build.
closes #40

Sorry I should have been more helpful! I think ARG values are only active/relevant for the stage they are defined in.

Did you mean to close? Are you going to open another one?

closed in favor of https://github.com/uor-framework/uor-client-go/pull/49