Migrate from docker buildx to docker build

Seems like using buildkit works very differently between Mac and Linux. Giving up here. #93 contains at least some basic cleanup.

Not sure why you want to remove buildx. Without it, we would need an Intel and Mac machine to build both images.
Perhaps your idea is to run these builds automatically in the CI? We can still do that with buildx, and a couple Intel and Mac (arch64) machines in the CI.

Because most of the functionality was moved to the default docker build command in the meantime, making it much simpler to archieve the same. See --platform in https://docs.docker.com/engine/reference/commandline/build/#options.
For the faucet, I now do cross-building for Intel on M1 like that:
$ docker build --pull --platform linux/amd64 -t "confio/faucet:$NEW_COSMJS_VERSION" -f packages/faucet/Dockerfile .


refactor(compiler): use esbuild as compiler

Codecov Report

Merging #38 (dd916f4) into master (c53f630) will decrease coverage by 1.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   91.66%   90.27%   -1.40%
==========================================
  Files          37       38       +1
  Lines         960      946      -14
  Branches      226      229       +3
==========================================
- Hits          880      854      -26
- Misses         76       88      +12
  Partials        4        4

Impacted Files
Coverage Δ

packages/nugrpc-rules-parser/src/index.ts
100.00% <ø> (ø)

packages/nugrpc-utils/src/name.ts
100.00% <100.00%> (ø)

packages/nugrpc-validator/src/index.ts
100.00% <100.00%> (ø)

packages/nugrpc-validator/src/rule.ts
100.00% <100.00%> (ø)

packages/nugrpc-validator/src/rules/each.ts
100.00% <100.00%> (ø)

packages/nugrpc-validator/src/rules/equal-to.ts
100.00% <100.00%> (ø)

packages/nugrpc-validator/src/rules/is.ts
100.00% <100.00%> (ø)

packages/nugrpc-validator/src/rules/length.ts
100.00% <100.00%> (ø)

packages/nugrpc-validator/src/rules/match.ts
100.00% <100.00%> (ø)

packages/nugrpc-validator/src/rules/must-be-in.ts
100.00% <100.00%> (ø)

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53f630...dd916f4. Read the comment docs.


[Q] How to reproduce values sampled by Bayesian method?

Hello,
I am using W&B Sweeps to optimize hyperparameters for my neural network. I noticed that when I run my code several times with random seed fixed, I get different results, and this seems to be caused by different hyperparameter values sampled by the Bayesian method.
optim_method = "bayes"
metric = {"name": "best_acc", "goal": "maximize"}

I was wondering if there is any way to seed the Bayesian sampler provided by W&B. Or is there any other way encouraged by Sweeps for reproducing the run?
Thank you.

Hi Leslie,
Thank you for your reply. Your suggestions make sense. I'll look into them.
All the best,
SungJun


Leadership governance consult

Worked with Eddie who is on loan as a PM for the Leadership curator Category... work tbc in the new year.


feat: Adding somatic neoepitope preparation workflow

Adding a draft workflow for somatic neoepitope preparation for using pvactool later

coverage: 85.857% (+0.1%) from 85.742%
when pulling b4b36ba5678bd019bbff4cf5895855fe9d909721 on 472-adding-neoepitope-prediction-pipeline
into af961cca3ef4d8c7a5a4a2ec08c3161260ce9f5e on main.


Update SAX version to handle BOM

Hi there. Enjoying Element Tree so far, but ran into an issue when trying to parse XML files starting with BOM characters :disappointed: Turns out that SAX has already been updated to handle these appropriately, but you're running on an older version. My PR simply bumps to the latest... from what minimal testing I did locally, it seems to work fine.

Thanks.
I'm +1 for this change as long as all tests pass (it looks like they do). On a related note - can you please also add a test case for a file with BOM?

I'm not really sure if there's a good way to show that the file I added has BOM characters, but I generated it with Sublime and used Save with Encoding -> UTF 8 with BOM. Doesn't work with SAX < 1.1.3, works fine with current.

Hi there, any update on pulling this in?

Poke once more. I'm probably going to delete my copy of the repo pretty soon... not actually even using this in projects I'm working on anymore. Still interested in taking this update?

+1

🎉 🎉 🎉


LOG_LEVEL env variable is not showing trace logs for tf providers

LOG_LEVEL for terraform provider is not working as expected

Seems like it's a bug with the writer that logrus return and that we pass to the plugin_client logger.

Seems like it's a bug with the writer that logrus return and that we pass to the plugin_client logger.


Run bot with Docker

Summary
Currently the bot can be run directly in your machine. That forces you to install all dependencies including Python 3.5. To run tests though, you can run them in Docker.
Expectation
Run the bot via Docker using a dedicated image with no test dependencies.

Closed by #11


[Bug]Image Widget inside the tab widget flickers in both edit and deploy mode upon binding an api with default tab

Description
It is observed that the image widget which is placed inside tab widget flickers in both edit and deploy mode when an api is binded to the default tab
Expected Result:
Image widget placed inside tab widget should not flicker
Actual Result:
Image widget placed inside tab widget flickers upon binding an api to the default tab
Steps to reproduce the behaviour:
1.Launch App Smith app in the deploy environment -
2.Expand API and click on new api
3.Choose the method as GET
4.Pass the following header url - https://enmbt55ts7rbb96.m.pipedream.net/
5. Click on Run button and name the API
6. Expand Widget and Drag and drop tab widget
7. Drag and Drop image widget inside tab widget
8. Click edit on the tab
9. On the Property pane of Tab widget bind the existing API to the Default tab and observe
VideoLink:
https://www.loom.com/share/6eecc3cab2df42b4a2d824d4b78d3b0e
Important Details

Version: [14.0.3 (166<IP_ADDRESS>.7)]
OS: [MacOS Big Sur 11.2.3]
Browser [safari]

@YogeshJayaseelan this does not seem to be a valid use case since the default selected tab expects a string(that should also match one of the tabs) while you are binding an object.


dont focus searchbar permanently

Steps to reproduce

click in the map
type: "+"
Map is zooming (good)
type "+" again
"+" is in the searchbox, no zoom (bad)

Thanks for your feedback!
It would indeed improve accessibility.
If you or anyone else want to propose us a patch about this, the Qwant Maps component that need to be updated is erdapfel, and this javascript function may be a good starting point ;)

you can now use the keyboard to zoom and pan the map  :arrow_right: :arrow_right:


[FLINK-35475][runtime] Introduce isInternalSorterSupport to OperatorAttributes

What is the purpose of the change
Introduce isInternalSorterSupport to OperatorAttributes to notify Flink whether the operator will sort the data internally in batch mode or during backlog.
Brief change log

Introduce isInternalSorterSupport to OperatorAttributes.
Update transformation translator to check the isInternalSorterSupport

Verifying this change
This change added tests and can be verified as follows:

org.apache.flink.streaming.api.graph.StreamingJobGraphGeneratorWithOperatorAttributesTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? docs

@jeyhunkarimov Thanks for the review! I updated the PR. Please take another look.

Thanks @Sxnan LGTM!


⚠ Bofrost.lu has degraded performance

In 40262fd, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1360 ms

Resolved: Bofrost.lu performance has improved in a239c61 after 13 minutes.


API Simplification : Limit / Skip should be available on ReactiveSeq and Stream subclasses only

Prefer take / drop on all other types.
Remove overloads such as limitWhile / limitUntil (takeWhile etc. is prefered within the Stream API)

Released.


[Feature request] Showing raw addresses in Correspondents column

Hello,
Could you please add an option (column) to show raw addresses in the Correspondents column?

I'm not quite sure how to determine whether message is inbound or outbound from TB API, as original Correspondents column does - especially for folders containing both outgoing and incoming messages, for instance gmail's "All Mail" folder.

Oh, ok, I didn't know it's complicated.
Unfortunately, I have no idea how to help because I mainly work with PHP 😞

I'm not quite sure how to determine whether message is inbound or outbound from TB API, as original Correspondents column does - especially for folders containing both outgoing and incoming messages, for instance gmail's "All Mail" folder.

Hi,
I'm not java (or else) programmer, so I'm not sure if U can code it, but my idea is:

read address twice

first from 'Corespondents' column,
second from 'recipient' column for example.

compare those 2 addresses

if they are the same - it is incoming message,
else it is outcoming message.

Display proper icon followed  by address from  'Corespondents' column,

If icon is to complicated then maybe it is enough to display:
'> ' or '>>  ' for out- and
'< ' or '<<  ' for incoming nessage
Anyway, thank You for this 'must have' ext.

The problem is I don't know how or if it is even possible to fetch content of "Corespondents" column programmatically.

Well, I understand.
I guess U read addresses direct from particular message headers, right?

More or less - yes. The addon uses nsIMsgDBHdr as defined in https://hg.mozilla.org/comm-central/file/tip/mailnews/base/public/nsIMsgHdr.idl

I see nsIMsgDBHdr reads only few headers. It is not able to check (for example) presence of header 'Delivered-To:' or 'Received:'?

I don't think so. There are getProperty and getStringProperty methods, but they don't seem to have access to arbitrary MIME header - most likely because they operate on Thunderbird's internal message database, not a raw e-mail content.

OK, I give up.
Just promise me you will leave the note here if u discover a solution in the future.
PS. Mówisz po polsku, nie? :)

Sure will. I'll leave this issue open as long as it is relevant.
PS. Tak :-)


Unable to Load Mask from RLE in LabelStudio despite it showing there is a prediction

I am using cv2 to perform adaptivethreshold and take the mask outputs from there and utilize the brush library encode_rle and the example function image2annotation. I load that into predictions but when I click on the image in labelstudio it says there is a prediction but doesn't render the mask overlay.
To Reproduce
Steps to reproduce the behavior:

CV2 --> Adaptive Threshold to generate mask
Convert numpy --> RLE
Format RLE using image2annotation
Load json into labelstudio

Expected behavior
Says there is a mask annotation on labelstudio, but will not load it. I attached screenshots of my code and outputs below.

Hello shantanudev,
Is it possible to show the json and how that prediction compare to the task source of any annotation? I think you should load it under "prediction" rather than "annotations"

I tried both but had no luck with either. {"id": 483445, "annotations": [{"result": [{"id": "65893112-2__9", "type": "brushlabels", "value": {"rle": [], "format": "rle", "brushlabels": ["Mask"]}, "origin": "manual", "to_name": "image", "from_name": "tag", "image_rotation": 0, "original_width": 1024, "original_height": 1024}]}], "drafts": [], "predictions": [], "data": {"image": "/data/local-files/?d=label-studio/angio_slices/00005391-b__12.jpg"}, "meta": {}, "created_at": "2023-04-23T06:01:22.687474Z", "updated_at": "2023-04-23T06:01:22.687520Z", "inner_id": 5, "total_annotations": 0, "cancelled_annotations": 0, "total_predictions": 0, "comment_count": 0, "unresolved_comment_count": 0, "last_comment_updated_at": null, "project": 13, "updated_by": null, "comment_authors": []}]

project.create_prediction(
task_id=483444,
model_version=None,
result=[
{
"from_name": "tag",
"to_name": "image",
"type": "brushlabels",
'value': {"format": "rle", "rle": rle, "brushlabels": ['Mask']},
}
],
)
tried this way as well but fail

I think the issue is that "rle": [] is empty. There isn't a mask to show. Is it possible to make sure the object has values before loading in LS? Can you also paste the output of that method here?

Thank you for the reply. I did finally solve it! This is for everyone else that couldn't figure it out. Just use the SDK Library to help you load this. It is much faster this way. Here is my code snippet:
`import label_studio_converter.brush as brush
from label_studio_sdk import Client
def mask2labelstudio(task_id):
project.create_prediction(task_id=task_id, model_version=None, result = [{
"from_name": "tag",
"to_name": "image",
"type": "brushlabels",
'value': {
"format": "rle",
"rle": rle,
"brushlabels": ['Mask']
}
}])
for task in tqdm(project_tasks):
mask=np.load(os.path.join(mask_path,task['storage_filename'].split('/')[-1].split('.jpg')[0]+'.npy'))
mask = np.array(mask > 0) * 255
rle=brush.mask2rle(mask)
mask2labelstudio(task['id'])
`


Images convert($imageType) is not destination file type

From https://forum.codeigniter.com/showthread.php?tid=81803
https://codeigniter4.github.io/CodeIgniter4/libraries/images.html#converting-images
ErrorException

imagecreatefrompng(): "/Users/kenji/work/codeigniter/CodeIgniter4/writable/img.jpg" is not a valid PNG file [search →](https://www.duckduckgo.com/?q=ErrorException+imagecreatefrompng%28%29%3A+%26quot%3B%2FUsers%2Fkenji%2Fwork%2Fcodeigniter%2FCodeIgniter4%2Fwritable%2Fimg.jpg%26quot%3B+is+not+a+valid+PNG+file)

SYSTEMPATH/Images/Handlers/GDHandler.php at line 351

<?php
namespace App\Controllers;
class Home extends BaseController
{
    public function index()
    {
        \Config\Services::image('gd')
            ->withFile(WRITEPATH . 'img.jpg')
            ->convert(IMAGETYPE_PNG)
            ->save(WRITEPATH . 'img2.png');
    }
}

Correct code:
        \Config\Services::image('gd')
            ->withFile(WRITEPATH . 'img.jpg')
            ->convert(IMAGETYPE_JPEG)
            ->save(WRITEPATH . 'img2.png');

Ref #2113


Extend and apply linearized Coproduct encoding

I'm relatively certain that a significant chunk of our current compilation inefficiencies comes from the binarized nature of the Coproduct encoding.  This is something that I feel could be fixed upstream (i.e. in cats) with a nicer Coproduct in the style of FreeK which is both easier to use and faster to compile.
For context, symmetric binarized type constructors (like Coproduct) necessitate extremely problematic implicit derivations (such as this one), which increase the k factor in the compiler's O(k^n) implicit resolution algorithm.  Linearized data constructors (such as CoM) work a lot more effectively, since the compiler only has to falsify a single tree branch, rather than two.
Additionally, construction can be made more amenable to nominative falsification, which is to say a situation where the compiler has only a single candidate solution for free type variables, and can validate that solution by nominative type tests, rather than having to attempt various shape instantiations (potentially spanning multiple levels of the implicit search hierarchy).  This is effectively how backtracking is encoded in implicit search, and it is easier to more aggressively avoid it with linear encodings.

I think the best answer to this as it stands now is https://github.com/frees-io/iota, which has zero dependencies and provides a nominally-right-associated performant coproduct. This should speed up compilation and runtime performance of code that touches coproducts quite a bit, especially QScript.

I think Iota is a sufficiently promising solution that this is worth devoting a few developer days to in the near future.  I'll see if I can squeeze it in.

Note: since v0.3.1 iota has scalaz support https://github.com/frees-io/iota/releases/tag/v0.3.1


Further enhancements for #199: Support using the camel component names l...

...ike 'camel-mqtt' to specify which components to import into the deployment classpath.

Can one of the admins verify this patch?

ok to test

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/209/
Test PASSed.


Wrong quantized_dimension (axis) when "per-channel" quantization

1. System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Microsoft Windows 11 Home 10.0.22631 version 22631 compilation
TensorFlow installation (pip package or built from source): pip install tensorflow==2.15.0
TensorFlow library (version, if pip package or github SHA, if built from source): 2.15.0

2. Code
# Create callib data
input_op_name = 'input'
numpy_file_path = 'calibration_data.npy'
calib_data = np.load(numpy_file_path)
data_count = calib_data.shape[0]
mean = [[[[0, 0, 0]]]]
std = [[[[1, 1, 1]]]]
calib_data_dict = {}
calib_data_dict[input_op_name] = \
    [
    calib_data.copy(),
    mean,
    std,
    ]

# representative_dataset_gen
def representative_dataset_gen():
    for idx in range(data_count):
        yield_data_dict = {}
        for model_input_name in [input_op_name]:
            calib_data, mean, std = calib_data_dict[model_input_name]
            normalized_calib_data: np.ndarray = (calib_data[idx] - mean) / std
            yield_data_dict[model_input_name] = tf.cast(tf.convert_to_tensor(normalized_calib_data), tf.float32)
        yield yield_data_dict

###### CONVERT
converter.optimizations = [tf.lite.Optimize.DEFAULT]
converter.target_spec.supported_ops = [
    tf.lite.OpsSet.TFLITE_BUILTINS_INT8,
    tf.lite.OpsSet.SELECT_TF_OPS,
]
converter._experimental_disable_per_channel = False # to perform "per-channel" (it's the default value though)
converter.representative_dataset = representative_dataset_gen
converter.inference_input_type = "int8"
converter.inference_output_type = "int8"

TFLITE_FILEPATH = "model_full_int.tflite"
with open(TFLITE_FILEPATH , 'wb') as w:
    w.write(tflite_model)

##### INFER
# Initialize the interpreter
interpreter = tf.lite.Interpreter(
    model_path=str(TFLITE_FILEPATH"),
    # experimental_preserve_all_tensors=True
    )
interpreter.allocate_tensors()

input_details = interpreter.get_input_details()[0]
output_details = interpreter.get_output_details()[0]

test_image = pre_processed_input.copy() # One image I have loaded (shape 1, 1024, 608, 3)

# Check if the input type is quantized, then rescale input data to int8
if input_details['dtype'] in [np.int8, np.uint8, np.int16]:
    input_scale, input_zero_point = input_details["quantization"]
    test_image = test_image / input_scale + input_zero_point
test_image = np.expand_dims(test_image, axis=0).astype(input_details["dtype"])

interpreter.set_tensor(input_details["index"], test_image)
interpreter.invoke()
tflite_inference = interpreter.get_tensor(output_details["index"])[0]

if output_details["dtype"] in [np.int8, np.uint8, np.int16]:
    output_scale, output_zero_point = output_details['quantization']
    print("Output scale:", output_scale)
    print("Output zero point:", output_zero_point)
    print()
    tflite_inference = output_scale * (tflite_inference.astype(np.float32) - output_zero_point)

3. Failure after conversion
The conversion is successful, but the generated model is wrong: the inferred output (tflite_inference) is all the same value in the fully int8 quantized model and I think it could be because quantization per-channel is performing per-batchaxis instead:
If I inspect the .tflite model, I found that in each operation (for example convolution) the number of scale and zero_point values are the same as number of axis=0 (batch i.e 256) not the number of channels (axis=-1 i.e 512)

...

I miss one quantized_dimension parameter, as stated in docs: https://www.tensorflow.org/lite/performance/quantization_spec#per-axis_vs_per-tensor

Hi @CarlosNacher ,
Can you give me the full code to replicate this issue. The library imports and some other things are not clear . I will be able to debug quicker if you provide me the above details.

Hey @sawantkumar ,
For sure! I have uploaded the code to a Colab file so that you can fully reproduce it. I have also written some comments in the notebook explaining the actual behaviour and the expected one.
The link to the data you will need to fully reproduce (the SavedModel and calibration data) is here: https://we.tl/t-MUNhBovDZr
Thank you so much for your response and for taking the time to help me!

Hi @CarlosNacher ,
Sorry for the late response, but the link for your savedModel seems to have expired. can you please provide another link to the model and data.

Hi @sawantkumar ,
For sure, here: https://we.tl/t-iUsgchLLL7
Thank you.

Hi @sawantkumar , could you please give me some feedback aboout this? The links only last 7 days. If you need it, I can send it in a different format.
Thanks!

Hi @CarlosNacher
I replicated your issue and got the tflite model file , and after inspecting it on netron and  I also used the below script to confirm which axis is getting quantized and it came out to be the "0th" axis .
The below script is
`interpreter = tf.lite.Interpreter(model_path='model_full_int.tflite')
interpreter.allocate_tensors()
Get the details of all tensors
tensor_details = interpreter.get_tensor_details()
for tensor in tensor_details:
print(f"Tensor Name: {tensor['name']}")
print(f"Quantization Parameters: {tensor['quantization_parameters']}")`

Hi @CarlosNacher ,
I replicated your script and i got the tflite and i inspected it and confirmed that its quantizing the 0th dimension.
dtype=float32),` 'zero_points': array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
      0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
      0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
      0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
      0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
      0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]), 'quantized_dimension': 0}
Tensor Name: tfl.pseudo_qconst5``
```

Hi @CarlosNacher ,
I will raise a PR to fix your issue and I will update you. Thank you

Hi @CarlosNacher ,
Sure thing. However can you please confirm if this bug can be reproduced in tf 2.16.0 or tf-nightly .

Hey @sawantkumar ! I confirm it, I have replicated using tf 2.16 and tf-nightly (2.17.0.dev20240528), the output trace of the code execution is in the Colab I attached. Thank you.

Hello @sawantkumar ,
Any update on this? If there is a PR, could I havee the link to keep updated?
Thank you in advance!

Hi @CarlosNacher, this issue may be resolved by following a different work flow.
Have you tried using AI-Edge-Torch?, you can find more information here: googleblog.
I have actually created a simple script for converting an CV model here:
import torch
import torchvision
import ai_edge_torch

mobilenet_model = torchvision.models.mobilenet_v3_small()
sample_inputs = (torch.randn(1, 3, 224, 224),)

edge_model = ai_edge_torch.convert(mobilenet_model.eval(), sample_inputs)
edge_model.export("mobilenet_v3_small.tflite")

If you want to, you can actually try visualizing the result in model-explorer as well.
Please try them out and let us know if this resolves your issue. If you still need further help, feel free to open a new issue at the respective repo.

Hi @pkgoogle
I didn’t know that library, thank you so much for the information! I’ll check it out and let you know, however my final application of interest is to run the model in coral TPU USB accelerator, do you know if with the tool you comment it is achievable?
On the Readme, CPU and GPU support is mentioned but not TPU. As far I know, the only thing you need to run your .tflite on TPU is that it is FULLY INT8, so I suppose that it’ll work, but the no mention of TPU confuses me.
Can you give me feedback about that? Anyway, again, it’ll try, and many thanks!

Hi @CarlosNacher, I would say, go ahead and try it... if it's not fully int8, you should be able to quantize at least in the same way as before by passing in tfl_converter_flags: quantization. Additionally some PT2E quantization may work better for your use case. Does that help?

wip


Add MultiQC

Hi,
just to keep track of what needs to be done.
We want to integrate MultiQC.
Need to wait for

merges of https://github.com/ewels/MultiQC_TestData/pull/178 and https://github.com/ewels/MultiQC/pull/1340
a new MultiQC release

Is the version of MultiQC in the fork https://github.com/Imipenem/MultiQC in the upstream Dockerfile via https://github.com/nf-core/pangenome/pull/35 sufficient?

Is the version of MultiQC in the fork https://github.com/Imipenem/MultiQC in the upstream Dockerfile via https://github.com/nf-core/pangenome/pull/35 sufficient?

Yes. It implements everything that we need.
But we'll keep this issue open as long as @ewels did not get to review/merge it yet.

Yes. It implements everything that we need.
But we'll keep this issue open as long as @ewels did not get to review/merge it yet.

I'll get there one day! I merged a PR this morning, slow and steady 😅

I'll get there one day! I merged a PR this morning, slow and steady 😅

@ewels no worries. Open-source development is time consuming and stressful. I don't mind it taking longer.

@ewels no worries. Open-source development is time consuming and stressful. I don't mind it taking longer.

fixed via #71


Content position differ opening from panGesture or buttonAction

Hi,
I'm using the lib (2.4.8) on an iOS8 app and facing a strange behavior : the content position is fine when  I'm opening the menu with a panGesture. But as soon I use a button action (button as left item in the navigationBar), there is a strange margin on the left side.
You can see that on the images below :

Thx for your help.
Regards

+1

+1


error message when load limix in R

I was trying to use scLVM but I got an error message. I was following the instruction at https://github.com/PMBio/scLVM/blob/master/R/tutorials/scLVMr_demo_nospikeins.Rmd. Below is what I did and the error message I got:

I installed LIMIX by downloading the limix-master from github. I used the setup.py to install it: python setup.py install --user
I installed scLVM R package, by downloading the file from (https://github.com/PMBio/scLVM/tree/master/R). I installed it in the terminal: R CMD INSTALL scLVM_0.99.2.tar.gz -l ../R/x86_64-pc-linux-gnu-library/2.10/
I then opened R, and was able to load scLVM by library(scLVM). However, I was not able to run configLimix(limix_path). I found two possible limix_path:
./src/interfaces/python or ./build/temp.linux-x86_64-2.7/src/interfaces/python, but both of these paths gave me the same error message:

configLimix(limix_path)
File "", line 3
except Exception as e:_r_error = e.str()
^
IndentationError: expected an indented block
Warning message:
In file(con, "r") :
file("") only supports open = "w+" and open = "w+b": using the former

Please let me know how I would be able to use scLVM. Thanks.

Hi xiandzhou,
I found that this issue was due to a file path problem in the configLimix() function. I worked around by using this configLimix2() function instead of configLimix():
configLimix2 <- function (limix_path) {
  python.assign("limix_path", limix_path)
  python.exec("sys.path.append(limix_path)")
  python.load(system.file("pysrc", "init_data.py", package = "scLVM"))
  # in the original configLimix it says "py" instead of "pysrc"
}

Hope this helps,
-- Alex

fixed, thanks Alex!


Install in windows giving version mismatch error.

Hi,
Thanks for your work on this plugin.  Just new to lite-xl and am trying to install your plugin on a windblows box under data/plugins with a git clone, but when I start lite-xl its giving me a version error on your plugin (although as far as I can see, the init.lua has the same version as the other plugins directly in the plugins directory that seem to work.
Am I doing something wrong?
Ta  Peter.

Well, it would help if you could provide

lite-xl version
top lines from lite-xl-vibe/init.lua
names and top lines from some other plugins
in windows it's usually better to install plugins into C:\Users\<user>\.config\lite-xl\plugins

OK, fair comment.
Version: not a clue, can't find it anywhere, but, downloaded today from releases an the win x86-64.zip file.
Header from vibe: -- mod-version:1 -- lite-xl 2.0
Header from minimap -- mod-version:2
Header from rainbowparen -- mod-version:2 -- lite-xl 2.0
I tried moving the lite-xl-vibe folder to .config\lite-xl\plugins. Exactly the same error.
Error Message: Some plugins are not loaded due to version mismatch.
Plugins from directory "-\Documents\lite-xl\data":lite-xl-vibe.
Please download a recent version from https://github.com/franko/lite-plugins.

Oh, yeah, as you can see version is wrong ) wait a sec, I did not see the 2.01 version)

Now?

That fixed it :)
All good.  Thanks.

Thanks for the issue!


Read out single and summary coverage(without Regex)

I have the issue that I need to read out the coverage results from coverlet. Is it possible to get the values of single and summary coverage of the results in a practical way (without using string or regex operations)?
Example:

Write-Host hashtable["Project.UnitTest.dll"]
>> "41.89", "74.54", "70.87"

Write-Host hashtable["Total"]
>> "41.89", "74.54", "70.87"

Write-Host hashtable["Average"]
>> "41.89", "74.54", "70.87"

dup https://github.com/tonerdo/coverlet/issues/148 https://github.com/tonerdo/coverlet/issues/284
At the moment we don't have a way to extract that values.

Question...why do you need to extract that values?

@MarcoRossignoli Thanks a lot for your response. We want to extract the values to generate a historical view for the code coverage over all commits. Coverlet should run inside a buildpipeline on a Azure DevOps Server and should make a warning when the coverage get lower the the historical results registrated before. There fore I need to extract for example the single coverage of a Test-Assembly and compare this particular Assembly over time with future commits. As a service for the developer team I want to point on these particular test assembly when something change in to the "negative" way. Repeat this procedure to >100 Test Assemblies.

@MarcoRossignoli found a solution thats works for me. I found out that all these information can easily extract from the report. Thanks for all.

Great!


Bugfix: Zwave Print_node to logfile instead of console

Description:
The output of the print_node service printed directly to console. In a lot of cases, this is not viewable to the user unless they access systemlogs.
This PR moves the output to homeassistant.log
Related issue (if applicable): fixes #10945
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

This printout is huge and I think the log has a limit, so the data would be truncated.

Yes the printout is huge. but with none of my nodes I get a truncated output. My biggest line is a node that generates 57957 characters.
This is not a service being run for automations etc. but for informational purposes, so I think it would be fine.

We could add an api for that that would return the text and display it in a window. Not sure if that is more convenient.

An api would be for the future then. 👍


0.4.1

Coverage decreased (-0.5%) to 98.285% when pulling 4785f1981632d1cd38ddc23c58f4ec892e385baa on 0.4.1 into b7998f04493e2d4d63b8a8888c4216ccd900f9d0 on master.


use paper-toolbar in air client

This replaces the current placeholder titlebar with Polymer's paper-toolbar element:
https://elements.polymer-project.org/elements/paper-toolbar?view=demo:demo/index.html&active=paper-toolbar
I checked with UX and, background colour excepted, they're okay with the default height, etc., stylings.

This change is

BTW, this one small part of https://github.com/uProxy/uproxy/issues/2815, to get me used to working on this UX stuff.

one tiny comment but this looks great, merge away!

What goes in the menu?

Judging from the mocks, it will be the settings panel. I was also using this as an exercise to become familiar with the web components.


MakeCode docs are missing the print icon and the hamburger icon for the side menu

It seems that all the docs under makecode.com are missing the side menu icon and the print icon.

compare to the docs under arcade.makecode.com:

Other icons are also missed.
semantic.js CDN URL in makecode.com is different from that in editors page.

@kimprice
Could you let me know how I can serve MakeCode docs? I guess I can't by pxt serve.

@riknoll
If you know how I can serve MakeCode docs, could you let me know?


Change Redis trigger to use new authentication approach

The Redis trigger should be changed so that it uses the new authentication approach documented in the spec.
This includes:

Changing the scaler to retrieve the authentication information from the configured TriggerAuthentication CRD
Update the trigger spec to list what parameters should be configured in the TriggerAuthentication CRD.

The KEDA core runtime provides access to the deployed TriggerAuthentication CRDs via #331
This is a follow-up action for #307

Im interested in taking this up, if we have some samples or getting started guide, that will be great.

This can now be closed after merging #441 .

I think we can close this one.  Tom has aligned the docs already in this merged pr.
https://github.com/kedacore/keda-docs/commit/f37cc0b273e3ae7a45b1f3ca66beaf2baba9f700

You are correct, thanks!


Added more install-function variations to epm

Added:

epm:is-installed $pkg to check if a package is already installed
epm:install-if-needed @pkgs to install packages only if they are not
already installed, be silent otherwise. This function makes it easier
to install packages directly from the config file, but without
printing noise if the packages are already there.
epm:install-or-upgrade @pkgs to install packages if they are not
installed, try to upgrade them otherwise.

Codecov Report

Merging #547 into master will decrease coverage by 1.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   51.17%   49.42%   -1.75%
==========================================
  Files         190      164      -26
  Lines       12894    12220     -674
==========================================
- Hits         6598     6040     -558
+ Misses       5961     5907      -54
+ Partials      335      273      -62

Impacted Files
Coverage Δ

edit/action.go
0% <0%> (-87.5%)
:arrow_down:

edit/editor.go
0% <0%> (-41.67%)
:arrow_down:

edit/abbr.go
0% <0%> (-41.18%)
:arrow_down:

edit/hooks.go
0% <0%> (-37.5%)
:arrow_down:

edit/binding_table.go
0% <0%> (-32.15%)
:arrow_down:

edit/highlight.go
0% <0%> (-31.43%)
:arrow_down:

edit/complete_arg.go
40% <0%> (-30.67%)
:arrow_down:

edit/api.go
11.71% <0%> (-28.91%)
:arrow_down:

edit/registry.go
50% <0%> (-28.79%)
:arrow_down:

edit/render.go
0% <0%> (-22.4%)
:arrow_down:

... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5034914...4395433. Read the comment docs.

@xiaq I'm thinking these should probably be options to epm:install instead of separate functions - what do you think?

Hi, thanks for the PR!
The concept of "installed" is a bit complicated now. A package can be

Completely absent.

Present in the filesystem (the lib directory), but not in the database(the installed file). This
arises when the user has some local packages before starting to use epm.

Present in the database, but not in the filesystem. This arises when the user attempts to remove the package by removing the package without using epm:uninstall.

Present in both.

State 4 is definitely "installed", and it is a state that the install command should bring a package to. The implementation of the installed command admits 3 as installed but not 2; the is-installed you added admits 2 as installed but not 3.
To deal with the different states, we can

Rename the installed command to list-all-in-db;

Rename the is-installed command you are adding to in-fs;

Add an in-db command. For completeness there should also be a list-all-in-fs command; however, it is a bit tricky to implement for a reason I'll come back to, so let's not worry about this;

The install and upgrade commands can work as follows:

The install command should be able to take a package that is in any of state 1, 2 or 3, and bring it into state 4. It is actually simpler than it may sound, it is just
if (not (in-fs $pkg)) {
    info "cloning git repo"
    # clone git repo
}
if (not (in-db)) {
    info "recording in db"
    # record in db
}

We can add a &quiet option to install to suppress these messages.

In a similar spirit, we can implement upgrade simply as "install and update repo"; that is, it can take a package in any of state 1-4 and upgrade it.

@xiaq thanks for the detailed analysis. Is there a reason to keep the database and not just use the filesystem as the source of truth? I think this would simplify the state checking and allow direct manipulation. The listing of installed modules would be as simple as cd ~/.elvish/lib; ls -d */*/*.

Sorry, I intended to explain the problem in my last post but forgot.
The idea of just using the directory as the database is a good one. The problem is that neither Elvish's module system nor epm cares about which directory level is the "package level". Let's say that the lib directory is level 0, then packages hosted on Github happen to be in level 3; this is because Github repo URLs look like github.com/$user/$pkg. If you host a package on your own website, the URL can look like zzamboni.org/$pkg, and then your package lives in level 2. It all depends on the setup of the Git server; you can even set up your server to serve a Git repo at the root level of subdomains, and your package URL can be just $pkg.zzamboni.org.
Hence, a naive directory-level-based system cannot work if we want to keep the URL <-> directory mapping (which I see as one of the major features of epm).
There are other ways to make it work though. One idea is to require packages to have some kind of metadata file. When listing packages, we recurse into the directory tree until we have found a metadata file; this has a drawback, however, if the user has a deeply nested directory tree without metadata files; then we'll be wasting time looking for metadata files in this tree.
One possible way to remedy this would be to create special markers in the parent directories of packages. For instance, when the user first installs github.com/elves/sample-pkg, we can create special marker files in github.com and github.com/elves. Yet another alternative is to create a metadata file only in github.com, which contains, possibly among other things, how many more levels you need to go to reach packages (for github.com, it is 2).

Hmm, keeping a metadata file in the github.com level makes more sense. It can record not just the package level, but also e.g. the version control system this domain uses (right now epm assumes git). Making the level explicit also makes the package metadata file optional. It has the slight drawback that, when configuring your own server, you have to serve packages at a fixed level, but that is good for consistency anyway.
My preferred design now looks like this:

Each domain has a domain config file called, say, epm-domain.cfg. For github.com, this file is ~/.elvish/lib/github.com/epm-domain.cfg. It specifies the VCS this domain uses and the level packages are to be found. epm is bundled with domain configs for popular code hosting websites like GitHub, and populate the domain config automatically when the user first installs a package hosted there. The user can, of course, create a domain config manually.
The domain config opens up many possibilities. For instance, when specifying the VCS, we can not only let the user choose from a predefined set (git, hg, ...), but also give the user complete control and specify the command to install and update packages; enabling the use of arbitrary VCS.

When listing packages, epm looks at each directory in ~/.elvish/lib; if a directory contains a domain config, it retrieves the package level number $l (for github.com, 2) and recurses exactly $l levels.

Interesting idea - indeed opens up a lot of possibilities. One idea: make the domain file be in Elvish, e.g. ~/.elvish/lib/github.com/epm-domain.elv, then we can use familiar syntax in it, and it can be loaded with use github.com:epm-domain both by epm and by the user, getting parsing for free.


Feature Freeze for Software Paper

In anticipation of the software paper write-up, we shall do a feature freeze and a release soon. This issue will collect the list of features that we advertise with the release. As a reminder, each feature must have an appropriate test.

BE-DMRG PR open.


bug fix: broken MIT license link

I added a link to the MIT license on Github.

@BnayaKahalani
Thanks a lot. much appreciated.


Add social data

Added twitter, facebook or instagram IDs to the social data associated with these bioguide IDs:
A000367, C001049, C001075, C001108, P000603, K000367
Added legislators, and twitter or facebook IDs for:
G000584, H001078, N000190, P000258

Hi. Per the README, we "include accounts that are paid for with public funds and which represent official communications of their office." We don't include accounts managed by their campaigns. Could you review your additions and check whether the accounts are associated with their official office or their campaign? Official accounts should be linked from their official website and when they're not we call up their congressional office and ask.

Reverted, for now it looks like only updates for N000190 are backed by an official site.


strange behavior on pkger.Open api

it seems pkger.Open() can't pass string variable
it takes me a while to debug template not load issue in my issue, so i started it with simple.
steps to reproduce:
https://github.com/markbates/pkger/tree/master/examples/open/pkger
change run method in main.go
before:
func run() error {
	f, err := pkger.Open("/public/index.html")
        ....
}

after:
func run() error {
	t := "/public/index.html"
	fmt.Println(t)
	f, err := pkger.Open(t)
        ....
}

$ pkger
$ go build -v -o example
$ ./example
/public/index.html
2020/11/24 18:04:50 file does not exist

pkger cannot parse string variables because if it should, it needs to run your code when pkging to determine what the sting variable t contains.
But whereas if you have pkger.Open("/public/index.html") i.e. defined as a string, it needs to just parse your code and not run it to know that it needs to embed /public/index.html.
So you can either use the before way you mentioned
or
before you open any file or directory include it
pkger.Include("/public/index.html")

make sense


spelling nitpicks in comments

sorry, could not resist :)

Hi @srenatus, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Hi @srenatus, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

:+1: trivial change, I'd agree with MSBOT there.

@srenatus parts of the typos got already fixed. I merged in the rest by hand. Thanks for pointing this out.


chore: prepare for v1.42.1 release

This change is

I am going to ignore the failures due to stale triggers.


Add feature to store UUID as binary

Is your feature request related to a problem? Please describe.
Currently an UUID is always stored as a VARCHAR(36), but since UUIDs are just hex values with seperators, they could be stored in a BINARY(16).
Describe the solution you'd like

An option in the Column annotation like preferBinary
A setting in the ORMConfig like preferBinaryUuids

@JanHolger The actual use case would be to save disk space, because a BINARY(16) is smaller than a VARCHAR(36). See https://stackoverflow.com/questions/28251144/inserting-and-selecting-uuids-as-binary16 for reference.

Sure I definitely understand that but would anyone every do this? It makes the data pretty unreadable for humans so searching for an id in the database isn't trivial anymore.


Update pde2e-runner image to pull latest npm tests-playwright package version when running extension's tests

Npm dependency does not have the latest version required.
 On CI, skipping before All tests/output cleanup, see https://github.com/containers/podman-desktop/issues/5460
 ❯ src/bootc-extension.spec.ts  (0 test)

⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  src/bootc-extension.spec.ts [ src/bootc-extension.spec.ts ]
TypeError: Cannot read properties of undefined (reading 'ARM64')
 ❯ src/bootc-extension.spec.ts:103:35
    101|   );
    102|
    103|   describe.each([ArchitectureType.ARM64, ArchitectureType.AMD64])(
       |                                   ^
    104|     'Bootc images for architecture: %s',
    105|     async architecture => {

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

Ref workflow: https://github.com/containers/podman-desktop-extension-bootc/actions/runs/9249031918/job/25440223794

Fixed by: https://github.com/odockal/pde2e-runner/commit/65e5b859238d92db22fc601392ac4fc61a041ca7


Adding review widget at the end screens

Started doing it to make sure that the GithubFeedbackForm documentation PR was correct, but it's worth considering making it permanent. We've been talking about doing it for a bit: is the Affidavit a good place to add it?
The screens that I added the feedback too should only show up in the Standalone interview, not in other interviews (how we store the feedback doesn't have a way to distinguish "I'm on a screen from the Affidavit interview, being run from the SP6A interview", etc).

Going to test and confirm that it doesn't show up on included interviews, only on the standalone, and that I can access the feedback from the standalone on submitted. After that, I'll merge.

Confirmed that it works as expected. There were a few hiccups, but they were mostly the newest version of GithubFeedbackForm not being on pypi yet, and trying to find another interview that would install and work easily. Not a ton of those yet, but gonna have to ignore those issues for now.


No Godot 4 support (ported version attached)

I ported the whole thing to Godot 4 (beta 10)
Not sure if it is 100% bugfree, but it seems to work.
Needs some tidyup!
MaxSizeContainer.zip

Thanks @whiteshampoo ! It wasn't quite working for the current version of Godot (4.2-dev2) so I modified it further and published it here: https://github.com/brombres/Godot-MaxSizeContainer

If this repository is no long active, we should make the @brombres solution the "official" one in the Asset Library.


CI: rerun release drafter

Give the possibility to rerun release drafter by adding the workflow dispatch

see https://github.com/jhipster/jhipster-lite/blob/main/.github/workflows/github-actions.yml#L6
need to add it there too: https://github.com/jhipster/jhipster-lite/blob/main/.github/workflows/release-drafter.yml#L2

@pascalgrimaud Is it just enough to add the contents of release-drafter.yml  into the github-actions file?

Adding ' workflow_dispatch:' in release-drafter.yml is enough. No need to merge both file

@pascalgrimaud Sure, I would like take up this issue. Can you assign it on me?


added gpu_type and device count

Adding gpu_type to report as a tag on every metric and also reporting device count.

Hi, before I review and merge this, can you please sign and send the CLA and signoff the commits.
Thanks

Closing for no response. Please re-open when you can sign-off the commits. Thanks.

@guptaNswati I will help file a PR to this issue.


event is in wrong cell if min-max date specified

Do you want to request a feature or report a bug?
BUG
What's the current behavior?
If I specify min/max date, event is located in wrong cell, (usually 1-3 hours more, than it should be)
<BigCalendar
        localizer={localizer}
        min={new Date(0,0,0,8,0,0)}
        max={new Date(0,0,0,18,0,0)}
    events={[{title: 'sdf', start: new Date(), end: new Date()}]}s/>

https://codesandbox.io/s/7z95lom9qq

What's the expected behavior?
Event is located in right cell, like it does w/o min/max date

Duplicated issue #999


vc-git--clone-internal: lower git version requirement; refactor

git's init -b switch requires git version >= 2.28.
We can replicate this by renaming the master, which will work on older
git versions, too.
Use straight--process-run instead of straight--process-output, as we're
not doing anything with the process output.
See: https://github.com/raxod502/straight.el/issues/768

Tested this with ensime (which has a default branch of "2.0") and chess (which defaults to "master"):

Test Case
(straight-bug-report
  :pre-bootstrap
  (setq straight-repository-user "progfolio" straight-repository-branch "fix/git-initial-branch")
  :post-bootstrap
  (defun message-branch nil
    (message "initial branch: %S"
             (straight--process-output "git" "branch")))
  (straight-use-package
   '(chess :post-build
           (message-branch)))
  (straight-use-package
   '(ensime :post-build
            (message-branch))))

Test run at: 2021-06-01 13:57:53
system-type: gnu/linux
straight-version: prerelease (HEAD -> fix/git-initial-branch, fork/fix/git-initial-branch) f91c013 2021-06-01
emacs-version: GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.17.4, Xaw3d scroll bars) of 2021-05-25

Output
Bootstrapping straight.el...
Bootstrapping straight.el...done
Rebuilding all packages due to build cache schema change
Looking for gnu-elpa-mirror recipe → Cloning melpa...
Looking for gnu-elpa-mirror recipe → Cloning melpa...done
Looking for emacsmirror-mirror recipe → Cloning gnu-elpa-mirror...
Looking for emacsmirror-mirror recipe → Cloning gnu-elpa-mirror...done
Looking for emacsmirror-mirror recipe → Cloning el-get...
Looking for emacsmirror-mirror recipe → Cloning el-get...done
Looking for straight recipe → Cloning emacsmirror-mirror...
Looking for straight recipe → Cloning emacsmirror-mirror...done
Building straight...
Building straight...done

Test run with version: prerelease (HEAD -> fix/git-initial-branch, origin/fix/git-initial-branch) f91c013 2021-06-01
Cloning chess...
Cloning chess...done
Building chess...

initial branch: "* master"
Building chess...done
Cloning ensime-emacs (for ensime)...
Cloning ensime-emacs (for ensime)...done
Building ensime...
Building ensime → Cloning emacs-scala-mode...
Building ensime → Cloning emacs-scala-mode...done
Building ensime → Building scala-mode...
Building ensime → Building scala-mode...done
Building ensime → Cloning emacs-sbt-mode...
Building ensime → Cloning emacs-sbt-mode...done
Building ensime → Building sbt-mode...
Building ensime → Building sbt-mode...done
Building ensime → Cloning yasnippet...
Building ensime → Cloning yasnippet...done
Building ensime → Building yasnippet...
Building ensime → Building yasnippet...done
Building ensime → Cloning company-mode (for company)...
Building ensime → Cloning company-mode (for company)...done
Building ensime → Building company...
Building ensime → Building company...done
Building ensime → Cloning dash.el...
Building ensime → Cloning dash.el...done
Building ensime → Building dash...
Building ensime → Building dash...done
Building ensime → Cloning s.el...
Building ensime → Cloning s.el...done
Building ensime → Building s...
Building ensime → Building s...done
Building ensime → Cloning popup-el (for popup)...
Building ensime → Cloning popup-el (for popup)...done
Building ensime → Building popup...
 If the command fails, then straight--process-output throws an error while straight--process-run just prints a warning.

Which behavior do you think we should go with?

In this case, I think an error is appropriate, since if that command fails then the clone wasn't successful.


bug: Exchange rate not working

Describe the bug
Exchange rate doesn't appear to be working.
To Reproduce
Steps to reproduce the behavior:

Install OpenCost with any image or helm chart version on AWS.

Check the Opencost UI dashboard.
In this instance i am selecting TTD

When i switch to THB

The price is the same.
I now compare that to the AWS Cost Explorer and i don't get a selection for currency.

Is AWS plugged into the exchange. Profound right?

As I understand default currency, not changeable, is USD and opencost team is avoiding adding any thirdparty dependency on currency conversion api.
But on changing currency, a simple input box asking the currency conversion rate from user,(with basic validation of input) and use it to calculate cost. This way no hard dependency on thirdparty conversion rate api and easy fix for a critical issue.

Would support a PR for conversion on the frontend!


Getting Error while Training neural net

Getthing this while running the train_neural_net.py
WARNING:tensorflow:Error encountered when serializing data_augmentation.
Type is unsupported, or the types of the items don't match field type in CollectionDef.
'NoneType' object has no attribute 'name'
WARNING:tensorflow:Error encountered when serializing summary_tags.
Type is unsupported, or the types of the items don't match field type in CollectionDef.
'dict' object has no attribute 'name'
WARNING:tensorflow:Error encountered when serializing data_preprocessing.
Type is unsupported, or the types of the items don't match field type in CollectionDef.
'NoneType' object has no attribute 'name'

Is this an error or just a warning?
And is this when running using a GPU or without a GPU?

After this the training stopped, so I'll take that as error.
This while running without the GPU on MacBook pro with macOS Sierra.

Maybe just need to update tflearn?  This looks fixed upstream: https://github.com/tflearn/tflearn/issues/523

@jmontrose @andrewljohnson  can you explain a bit more ?
because the in the docker version of the tensorflow is 0.8

@sahil210695 are you pointing out that the issue in tflearn#523 seems to be coming from tf 0.12.0 compatibility?  That's a good point.  I found that issue trying to track down the source of the message itself (meaning to dump a stack trace)
I'll keep looking, and if you have any ideas I can help test, send them over!
Oh, and although I do get the same error reported by @andrewljohnson , I do see that I have model pickles, so it might not be completely fatal:
root@d6578b22ecc5:/DeepOSM# ls -lha data/generated/
total 8.2M
drwxr-xr-x    11 root root  374 Feb 20 00:08 .
drwxr-xr-x     5 root root  170 Feb 19 22:37 ..
-rw-r--r--     1 root root  129 Feb 20 00:08 checkpoint
-rw-r--r--     1 root root 8.1M Feb 20 00:08 model.pickle
-rw-r--r--     1 root root 178K Feb 20 00:08 model.pickle.meta
-rw-r--r--     1 root root  105 Feb 20 00:08 model_metadata.pickle
-rw-r--r--     1 root root  384 Feb 19 22:44 raster_data_paths.pickle
drwxr-xr-x 55252 root root 1.8M Feb 19 22:55 training_images
drwxr-xr-x 55252 root root 1.8M Feb 19 22:55 training_labels
-rw-r--r--     1 root root   88 Feb 19 22:55 training_metadata.pickle
drwxr-xr-x     4 root root  136 Feb 19 22:37 way_bitmaps

But I'm not getting it.
I'm stuck there only and results are not also generated after that also.

@andrewljohnson I'm not getting the output except these warnings. could you please tell me how to check for output ???

Here is my data/way_bitmaps dir.  Looks like it's failing before it renders the jpegs?
bash-3.2$ find way_bitmaps/
way_bitmaps/
way_bitmaps//38075
way_bitmaps//38075/m_3807503_ne_18_1_20130907.tif-ways.bitmap.npy
way_bitmaps//38075/m_3807503_nw_18_1_20130907.tif-ways.bitmap.npy
way_bitmaps//38075/m_3807503_se_18_1_20130907.tif-ways.bitmap.npy
way_bitmaps//38075/m_3807503_sw_18_1_20130907.tif-ways.bitmap.npy
way_bitmaps//38075/m_3807504_ne_18_1_20130907.tif-ways.bitmap.npy
way_bitmaps//38075/m_3807504_nw_18_1_20130907.tif-ways.bitmap.npy
way_bitmaps//39075

@jmontrose
Here is my data/way_bitmaps dir.
root@4881763ee755:/DeepOSM/data/generated# find way_bitmaps/
way_bitmaps/
way_bitmaps/.DS_Store
way_bitmaps/38075
way_bitmaps/38075/m_3807503_ne_18_1_20130907.tif-ways.bitmap.npy
way_bitmaps/38075/m_3807503_nw_18_1_20130907.tif-ways.bitmap.npy
way_bitmaps/38075/m_3807503_se_18_1_20130907.tif-ways.bitmap.npy
way_bitmaps/38075/m_3807503_sw_18_1_20130907.tif-ways.bitmap.npy
way_bitmaps/38075/m_3807504_ne_18_1_20130907.tif-ways.bitmap.npy
way_bitmaps/38075/m_3807504_nw_18_1_20130907.tif-ways.bitmap.npy
way_bitmaps/39075

I met this issue also, ran the container on Linux CentOS 7, no GPU.
Since I'm new to tflearn and tensorFlow, so I have no clue about this, so any process for you guys?
I'm looking into python code here for more information myself, it seems like some data format and library version compatiblity issue to me, but no not quite sure if this is the right direction.

@andrewjavao No success till now.
I am also looking into the python code and let's see where we can get.
It's issue with TFLearn with tensorflow.

@andrewljohnson We've been stuck in this issue for weeks, have u somehow figure it out?


doctor: Check for missing tidy

[x] It targets the develop branch
[x] I've searched for similar pull requests and found nothing
[x] This change is NOT in Doom's do-not-PR list: https://doomemacs.org/d/do-not-pr
[x] If I've bumped any packages, I've done so according to https://doomemacs.org/d/how2bump
[x] I've linked any relevant issues and PRs below
[x] All my commit messages are descriptive and distinct

This quick PR adds a check for the tidy executable in doom doctor. The new output looks like:

Thanks!


filetransfer: reject file uploads if they're not whitelisted

This change adds functionality into paygate to reject uploads if they don't match an optional IP/CIDR whitelist.
Docs: https://docs.moov.io/paygate/ach/#ip-whitelisting
Fixes: https://github.com/moov-io/paygate/issues/330

Codecov Report

Merging #333 into master will decrease coverage by 4.47%.
The diff coverage is 46.87%.

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   61.26%   56.79%   -4.48%
==========================================
  Files          54       54
  Lines        5703     5733      +30
==========================================
- Hits         3494     3256     -238
- Misses       1523     1826     +303
+ Partials      686      651      -35

Impacted Files
Coverage Δ

internal/database/mysql.go
10.66% <ø> (-50.67%)
:arrow_down:

internal/database/sqlite.go
56.86% <ø> (ø)
:arrow_up:

internal/filetransfer/file_transfer.go
71.62% <ø> (ø)
:arrow_up:

internal/filetransfer/ftp.go
65.11% <0%> (-3.18%)
:arrow_down:

internal/filetransfer/sftp.go
29.62% <0%> (-42.81%)
:arrow_down:

internal/filetransfer/config.go
70.98% <50%> (-0.42%)
:arrow_down:

internal/filetransfer/outgoing.go
57.49% <70%> (+0.93%)
:arrow_up:

internal/accounts.go
10.25% <0%> (-67.95%)
:arrow_down:

internal/customers/client.go
13.91% <0%> (-63.48%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95cc124...637a08e. Read the comment docs.


Changing the track URL

Hi @arielfaur
Thanks for your efforts in creating this nice module, i was working on it and i had a requirement to change the track url based on some conditions then play sound from the new URL, i was building this with cordova so i am using the cdvfile://localhost/ file system
I was able to achieve this by adding a new listener to track url as below in ionAudioTrackCtrl
let me if this sound correct and can be a nice enhancement for this module
   $scope.$watch('track.url', function () {
        if (!MediaManager) return;

        // Stop playing the current track
        MediaManager.stop();

        // Update elements & add as new track
        init();

        // attach play funtion
        $scope.track.play = function () {

            MediaManager.play($scope.track.id);

            // notify global progress bar if detached from track
            if (!controller.hasOwnProgressBar) notifyProgressBar();

            return $scope.track.id;
        };
    });

Hi @sherifdarwish That is already available in the latest version of this module.

This is  great and thanks for adding this, i was not aware of this new version but i will start using it
Regards,
Sherif


@rollup/plugin-eslint and vue compat issue

Is your feature request related to a problem? Please describe.
@rollup/plugin-eslint correctly lints .vue files but also generates linting errors for virtual css files generated from SFCs.
Here is a repro starting from @vitejs/app vue
https://github.com/matias-capeletto/vite-rollup-plugin-eslint
Errors during build
C:\vite-rollup-plugin-eslint\index.html
  13:8  error  clear  vue/comment-directive

C:\vite-rollup-plugin-eslint\vite\dynamic-import-polyfill
  37:3  error  '__VITE_IS_MODERN__' is not defined  no-undef

C:\vite-rollup-plugin-eslint\src\App.vue?vue&type=style&index=0&lang.css
  2:1  error  Parsing error: Unexpected character '#'

C:\vite-rollup-plugin-eslint\src\components\HelloWorld.vue?vue&type=style&index=0&scoped=true&lang.css
  2:3  error  Parsing error: Unexpected token {

During dev, only the last two are reported.
I tried using { ...eslint(), enforce: 'pre' } but it didn't help. From the reported error, eslint may be interpreting that HelloWorld.vue?vue&type=style&index=0&scoped=true&lang.css is a .vue file instead of a .css
Additional context
vite version: 2.0.0-beta.29
Operating System: Windows 10 Home, 10.0.18363 N/A Build 18363
Node version: v15.5.0
Package manager and version: yarn v1.22.10

Have you tried adding exclude: /vue&type=/ to the eslint plugin options?

Have you tried adding exclude: /vue&type=/ to the eslint plugin options?

Good idea. Using exclude: /vue&type=/ fixes dev. During build the first two errors remains:
C:\vite-rollup-plugin-eslint\index.html
  13:8  error  clear  vue/comment-directive

C:\vite-rollup-plugin-eslint\vite\dynamic-import-polyfill
  37:3  error  '__VITE_IS_MODERN__' is not defined  no-undef

I think it could be documented that this kind of plugins needs to use the exclude pattern if there is no way to solve this from Vite's side. In this case, the best would be to recommend users to use a vite-plugin-eslint, that wraps the rollup one.

Good idea. Using exclude: /vue&type=/ fixes dev. During build the first two errors remains:
C:\vite-rollup-plugin-eslint\index.html
  13:8  error  clear  vue/comment-directive

C:\vite-rollup-plugin-eslint\vite\dynamic-import-polyfill
  37:3  error  '__VITE_IS_MODERN__' is not defined  no-undef

I think it could be documented that this kind of plugins needs to use the exclude pattern if there is no way to solve this from Vite's side. In this case, the best would be to recommend users to use a vite-plugin-eslint, that wraps the rollup one.

I think the index.html should also be excluded, which is expected. Actually, an explicit include of js(x), ts(x) + vue is probably necessary anyway, otherwise it's also going to complain on plain CSS files etc.
Then the only problem left should be the vite internal flag.

I think the index.html should also be excluded, which is expected. Actually, an explicit include of js(x), ts(x) + vue is probably necessary anyway, otherwise it's also going to complain on plain CSS files etc.
Then the only problem left should be the vite internal flag.

The explicit include with a minimatch set pattern worked, and the internal flag error is also gone because there is no extension in dynamic-import-polyfill
This is the vite.config.js file
export default {
  plugins: [
    eslint({
      include: '**/*.+(vue|js|jsx|ts|tsx)'
    }),
    vue()
  ]
}

I also removed the enforce: pre, looks like it is not needed. I also wonder if these include patterns are better placed in the eslint config file

The explicit include with a minimatch set pattern worked, and the internal flag error is also gone because there is no extension in dynamic-import-polyfill
This is the vite.config.js file
export default {
  plugins: [
    eslint({
      include: '**/*.+(vue|js|jsx|ts|tsx)'
    }),
    vue()
  ]
}

I also removed the enforce: pre, looks like it is not needed. I also wonder if these include patterns are better placed in the eslint config file

Cool, closing then. Might also be a good idea to exclude node_modules in the recommended setup.

Cool, closing then. Might also be a good idea to exclude node_modules in the recommended setup.

Note: updated the compatibility list with include in the instructions. In the end, exclude default value was 'node_modules/**' already, as suggested

Note: updated the compatibility list with include in the instructions. In the end, exclude default value was 'node_modules/**' already, as suggested

Btw we should link to your site in the rollup plugin compat section!

Btw we should link to your site in the rollup plugin compat section!

That would be great! 🙌
I am thinking that we could also list some of the community plugins in the future.

That would be great! 🙌
I am thinking that we could also list some of the community plugins in the future.

I just tried using @rollup/plugin-eslint with the react-ts template, and it was linting the compiled files instead of the source files. Adding enforce: 'pre' fixed it.