fix RPC Failed with a Port backend

I have been able to fix the issue with these changes (Fixes #91)

Hey, first of all thank you for taking the time and reviewing this pr
I realized that when I wrap main thread setup in a setTimeout like so everything works fine
import { configure, Port, fs } from "@zenfs/core";
import FooWorker from "./foo.worker?worker";
export class GitWorkerIPC {
  constructor() {
    this.init();
  }
  private async init() {
    setTimeout(async () => {
      try {
        await configure({
          mounts: {
            "/port": {
              backend: Port,
              port: new FooWorker(),
            },
          },
        });
          console.log({ result: fs.readdirSync("/") });
      } catch (error) {
          console.error(error);
      }
    }, 1000);
  }
}

One concern I have is that the "remote" thread will call attachFS before the "main" thread calls configure. This creates a race condition,

There already is a race condition because in order to attachFs, you need to await resolveMountConfig or configureSingle etc on worker thread. This is why the code above works with a worker  setup like this
import { attachFS, resolveMountConfig, fs } from "@zenfs/core";
import { IndexedDB } from "@zenfs/dom";

//it works without an async function declaration but vite wants me to use esnext as target
async function init() {
  try {
    const myFS = await resolveMountConfig({ backend: IndexedDB });
    attachFS(self, myFS);
    myFS.mkdirSync("/mnt", 1, {});
  } catch (error) {
    console.error(error);
  }
}
init();

Once i realized this i said to myself why not await a promise that is resolved by a ready indication from worker (boot signal) then do the required things because otherwise,with a bit of uncertainty, I think we need to implement resolveMountConfigSync or  configureSingleSync

This is one case where the code now depends on a platform. This is something I'd like to avoid. This library should work the same regardless of the platform used..

You are absolutely right on this one but i have not changed any core functionality just added an additional step for Web Workers also this pr could be used as a hotfix

is this something that could be fixed by changing FileSystem.ready() ?..

When i checked the FileSystem.ready seems to be an empty function that is just async I did not get what i could implement there

Please make sure anything you add or change has tests. https://github.com/zen-fs/core/issues/66 Really shows how much we need more tests.

Since i made a fix for Web Workers i can add a test for Web Workers , i will update tests accordingly as well
If you thing you have a better approach as to fix this issue I'd be more than happy to update my code accordingly

@james-pre check this reproduction with setTimeout it works

I realized that when I wrap main thread setup in a setTimeout like so everything works fine

We need to figure out why, and then fix the underlying issue. This is unfortunately very difficult.

There already is a race condition because in order to attachFS, you need to await resolveMountConfig or configureSingle etc on worker thread. This is why the code above works with a worker setup like this

Not necessarily. await makes it so the worker will not parse incoming requests until the underlying FS is ready. If we can do this in a way that catches any messages sent before attachFS, and replays them afterward, I think the issue will be fixed. I think a new function could do that nicely, maybe something like RPC.catchMessages. We can wrap the new function, attachFS, and the configuration all into another function (configureRemote?) to make users' lives easier.

This is one case where the code now depends on a platform. This is something I'd like to avoid. This library should work the same regardless of the platform used.

You are absolutely right on this one but i have not changed any core functionality just added an additional step for Web Workers also this pr could be used as a hotfix

Still, this means that behavior is inconsistent between browsers and Node, which is a problem.

When i checked the FileSystem.ready seems to be an empty function that is just async I did not get what i could implement there

FileSystem.ready is empty, but many subclasses use it for initialization logic.

Since i made a fix for Web Workers i can add a test for Web Workers , i will update tests accordingly as well

Thanks!

To sum up the potential solutions I mentioned earlier with code:
backends/port/rpc.ts
export function catchMessages(port: Port): () => void {
	const events: _MessageEvent[];
	const handler = events.push.bind(events);

	attach(port, handler);

	return function () {
		// Now I'm not sure if `detach` works correctly because of function identity equality
		detach(port, handler);
		for (const event of events) {
			const data = 'data' in event ? event.data : event;
			if (isMessage(data)) {
				// emit/dispatch the event. Note we need to check for the right method to trigger handlers.
				port.emit('message', data);
			}
		}
	};
}

backends/port/fs.ts
async function configureRemoteMount<T extends MountConfiguration>(port: RPC.Port, config: T): Promise<void> {
	const stopAndReplay = RPC.catchMessages(port);
	const fs = await resolveMountConfig(config);
	attachFS(port, fs);
	stopAndReplay();
}

Please note: This is rough code I came up with quickly, it probably needs a lot of review and maybe some bug fixing.


App crashes when i receive a VOIP notification when a call is cancelled.

The example code is used to reportNewIncomingCalls but in my case I am sending VOIP notifications when a call is not answered by the user for X seconds. When i receive this VOIP notification I do not want to reportIncomingCall using CallKit. What options do I have? I also read in iOS Documentation that it is necessary to registerNewIncoming call when i receive VOIP notification because if i don't then it will stop sending VOIP notifications of my app.

Hey @mayur-bhandari did you get any solution for it?

I'm facing this issue too. Whenever my app receives a VoIP Push Notification, it crashes

I'm also facing this issue. Did you guys ever resolve it?


[FLINK-17407] Introduce external resource framework

What is the purpose of the change
Introduce external resource framework
Brief change log

6edb419: Introduce interfaces for external resource framework
92e6fe1: Introduce config options and constants for external resource framework
0cdf6f1: Add utility class, which include helper functions for external resource framework
c820a6e: Forward extended resource request to YARN. Try to add it as ResourceInformation.
7b726bc: Forward extended resource request to Kubernetes. Add the request to TM pod.
495ac34: Add extended resource drivers to TaskExecutor.
40801ca: Enable operator and function to get the information of external resource from RuntimeContext
6f27933: Enable operator and function to get the information of external resource from FunctionContext

Verifying this change
Add relevant UT test.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? configuration doc.

Resolve the conflict with current master.

Thanks for the review @xintongsong . PR updated.

I can only speak to the added methods in RuntimeContext and the added interface ExternalResourceInfo. Those look good to merge!

@tillrohrmann Thanks a lot for your review. I've updated the PR and left comments.

Thanks a lot for the review @tillrohrmann ! I've addressed most of your new comments. Please also take a look at my comments.

Rebase to the latest master and resolve conflict.


fix(spring): fix method javadoc missing @param and @return

Adds @param and @return to method javadoc comments in generated autoconfiguration classes.
Also adding a change to JavaDocComment to enable @return in comment. (this change in 537e33c2cdaf5e79d29f12fe12d372e1f75a525d can be copied to main branch of gapic-generator-java if useful.)

@zhumin8 : Shouldn't this cause a very large scale change in the golden files?


proposal: Flags/args passing in exec.Command affected/package: os/exec

Problem:

When executing Go programs from other Go programs, the flags need to be passed before arguments. This can cause developer errors.
There are examples of Go code creating slices of strings or functions that return arguments for a given command based on some config. This could be as easy as creating and configuring an exec.Cmd with the right flags and arguments.

I haven't thought about this API too much - just leaving this here for everyone's thoughts and suggestions.
Possible solution:

cmd := exec.Command("path/to/program")
cmd.SetFlag("flag", "value")
cmd.SetBoolFlag("boolflag")

if someconfig {
    cmd.SetFlag("optional", "value")
}

cmd.Args("arg1", "arg2")

err := cmd.Run()

we're not going to social case some go programs with a particular convention of flag/argument passing in os/exec


Proxy config doc

Draft for building changes related to new proxy configs. (Based on #779 )

Removing Disable SSL option
Accepting only X-Forwarded-For as source of real ip using remote_ip library
Only accepting X-* headers that we need

Will take my changes manually to a new branch, easier than solving the commit/conflicts.

Closing in favor of #795


[Bug]: One activity per command in the logs

batch name and line
The parsing of the log files in FSL seems to be broken. In practice we should have an Activity created for each command in the logs.
For examples, in https://github.com/bids-standard/BEP028_BIDSprov/blob/master/results/fsl/nidmresults-examples_fsl_con_f_multiple_report_log.jsonld#L2870-L2872 , pngappend is an Entity,
But in the log we have:
/usr/local/packages/fsl-5.0.8/bin/pngappend sla.png + slb.png + slc.png + sld.png + sle.png + slf.png + slg.png + slh.png + sli.png + slj.png + slk.png + sll.png example_func2highres1.png ; /usr/local/packages/fsl-5.0.8/bin/slicer highres example_func2highres -s 2 -x 0.35 sla.png -x 0.45 slb.png -x 0.55 slc.png -x 0.65 sld.png -y 0.35 sle.png -y 0.45 slf.png -y 0.55 slg.png -y 0.65 slh.png -z 0.35 sli.png -z 0.45 slj.png -z 0.55 slk.png -z 0.65 sll.png ;

which means that pngappend is a Command and should instead be defined as an Activity.
This problem is likely to impact other Activities as well. I think that the main logic of the parsing of the log files might be in question here.
What soft is concerned
FSL

I'm not sure if this bug is still present. I checked the jsonld obtained for fsl_conf_f_multiple and pngappend always appears (9 times in registration section) as an activity. Can you confirm @cmaumet that this bug is no longer present?

@thomasbtnfr yes I think this is good now. Thanks!


Minute precision raises influxDB error

Steps to reproduce:
@conn = InfluxDB::Client.new(
          database: ENV['DB_NAME'],
          host: ENV['INFLUX_HOSTNAME'],
          port: ENV['INFLUX_PORT']
        )
data = {
  values: { value: 0 },
  timestamp: Time.now.to_i
}
name = 'foobar'
precision = 'm'
@conn.write_point(name, data, precision)

Result:
InfluxDB::Error: {"error":"unable to parse 'foobar value=0i<PHONE_NUMBER>': time outside range -9223372036854775806 -<PHONE_NUMBER>854775806"}

	from /usr/local/bundle/gems/influxdb-0.3.14/lib/influxdb/client/http.rb:85:in `resolve_error'
	from /usr/local/bundle/gems/influxdb-0.3.14/lib/influxdb/client/http.rb:35:in `block in post'
	from /usr/local/bundle/gems/influxdb-0.3.14/lib/influxdb/client/http.rb:53:in `connect_with_retry'
	from /usr/local/bundle/gems/influxdb-0.3.14/lib/influxdb/client/http.rb:26:in `post'
	from /usr/local/bundle/gems/influxdb-0.3.14/lib/influxdb/query/core.rb:78:in `write'
	from /usr/local/bundle/gems/influxdb-0.3.14/lib/influxdb/query/core.rb:57:in `write_points'
	from /usr/local/bundle/gems/influxdb-0.3.14/lib/influxdb/query/core.rb:67:in `write_point'
	from (irb):16
	from bin/console:14:in `<main>')

Expected result:
=> #<Net::HTTPNoContent 204 No Content readbody=true>

Hm, interesting. Which server version are you running?
Time.now.to_i is a time representation in seconds, you might need to divide it by 60. Internally, the server converts timestamps it back to nano seconds; yet<PHONE_NUMBER>m * 60s/m * 10**9ns/s = ~1.5 * 10**18ns is still in range...

Server version is 1.2
I tried<PHONE_NUMBER> as well for a timestamp and it still failed

1492056063/60 = 24867600 ;-)

1492056063m * 60s/m * 10**9ns/s = ~1.5 * 10**18ns

Oops. This is actually ~9 * 10**19ns (which is about twice as much as 2**63, the max. value for timestamps in Go).
So, if you want to use minute precision, you'll need to provide timestamps reflecting this (Time.now.to_i/60).

Some documentation about this would be nice

I agree. I'd also like something like this to work out of the box:
data = { values: { value: 0 }, timestamp: Time.now }
@conn.write_point("foobar", data, "m")
#=> POST /write
#   foobar value=0i 24867600

FYI, this should make things a bit more clear: https://github.com/influxdata/influxdb-ruby/compare/6d4ab99...c2b418b
—Dominik


test: Move l1 tests to foundry Part-1

added foundry to the ethereum dir
created the solpp hardhat task that runs the preprocessing (it is required before running the forge tests)
added the test:foundry command to the package.json, it runs the:

preprocessing (hardhat solpp) that generates the /cache/solpp-generated-contracts dir
foundry tests (forge test) that uses the generated files as source files and runs the tests in the /test/foundry dir

migrated hardhat tests to foundry:

allow_list_test.spec.ts
diamond_cut_test.spec.ts
unsafe_bytes_test.spec.ts
executor_test.spec.ts

added foundry testing to the GitHub pipeline

@benceharomi Please make PR in boojum-integration branch instead


Upgrade BetterTouchTool.app to v1.25

Thank you for the contribution. It was merged directly as cf48932ae331105e12e59e3ac89f7355211910fb to keep commit history cleaner. Your contribution is still credited to you.


How to deal with srcset being converted to array

Dear @florianeckerstorfer,
I'm slightly worried that by now you're rather tired of my input, but there's something I'd like to find a solution for.
It's about the srcset attribute.
I'll use an example to illustrate my problem:
Your plugin adds a srcset attribute that is (correctly) set to:
srcset="/mdx_files/basting-1000.jpg, /mdx_files/basting-2000.jpg 2x"

I'm using MDX, which takes the remark output and parses it for use in React.
That srcset attribute above ends up like a prop:
{
  srcset: [
    "/mdx_files/basting-1000.jpg",
    /mdx_files/basting-2000.jpg 2x"
  ]
}

MDX then feeds that to React.CreateElement which will concat the array and render this:
srcset="/mdx_files/basting-1000.jpg,/mdx_files/basting-2000.jpg 2x"

The problem is that it's dropping the space, and as a comma is a valid character in a URL, the browser reads this as a single entry in the srcset: /mdx_files/basting-1000.jpg,/mdx_files/basting-2000.jpg
To be clear: Your code is not at fault here. But I did find that one can avoid this problem by explicitly setting the resolution, even if it's one:
srcset="/mdx_files/basting-1000.jpg 1x, /mdx_files/basting-2000.jpg 2x"

Now, even if the space after the comma is swallowed by MDX, the browser understands there's two values here.
I will open an issue with MDX to address this, but I wanted to inform you in case other users (or you) bump into a similar issue, and to see if you'd be open to add this to the code.

https://github.com/mdx-js/mdx/issues/1607

After a little detour via https://github.com/mdx-js/mdx/issues/1607 I'm back to this as it seems the root cause is that the plugin is injecting HTML rather than update the syntax tree.
Do you feel like this is something you would be willing to work on? I'm happy to wait, just would rather not wait in vain 🙂

@joostdecock I feared that this issue is due to the fact that this plugin is still generated HTML, instead of the more abstract constructs newer versions of remark expects. The issue arose since I started with the code from the gatsby-image plugin which uses the same HTML-based method. So yes, the plan is to at some point rewrite the plugin to use the more modern syntax. However, I can't give you an ETA on that.

Thanks for the update, no pressure 👍


v4.0 Dashboard UI issue on Firefox

Describe The Problem
Creating a schedule job on a peer doesn't work well in Firefox, specifically when selecting the date option.
To Reproduce
Use Firefox web browser and try to schedule a job on a peer using the date option. Note that it works great on Google Chrome with no issues.
Here's how it looks like when using Firefox:

Here's how it looks like when using Google Chrome:

You can see that Google Chrome allows you to select the time whereas Firefox does not. Which prevents the user from saving the schedule job. However, you can easily overcome this by manually typing out the time in the textbox.

Hi, thank you for letting me know. Just tested on Safari and it has the same issue too. I will add this to the road map #293 😄

and it got me thinking... we are in 2024 and still browsers are not adapting standards, and datetime picker is not even a new feature 😭


Admin account UI page

Shouldn't the admin user have access to my team page as well.
I can only find it in the normal user

Work Completed:
The My Team page was initially designed to be visible only to normal users. The following updates have been implemented:

Permission Adjustment:

Removed the restriction on the My Team page view, enabling access for admins and supervisors.

Filter Removal:

Eliminated the "filter as user" feature in the team section.

Table Resizing and Alerts:

Adjusted table sizes for a more user-friendly display.
Introduced alerts to notify users when there are no team members or when no users are assigned as "reporting to."

Department Field Addition:

Enhanced the Department tables by adding an extra field, providing users with Department information directly on the screen.


macOS Sonoma Beta 2, always show sharing screen icon on menubar

[ ] Mac model: MacBook Air M1
[ ] macOS version: 14.0 (beta 2)
[ ] Monitor setup: 1 ext monitor

Description of issue / Feature request
every time I open Microsoft Edge, the Sharing Screen icon always appears in the menubar. Even though I'm not doing a share screen on the Microsoft Edge application or other applications. "Microsoft Edge is sharing your screen" Even though I closed the application, the icon still appears.

Hi @termaulmaul
Did you mean to post this somewhere else ? This is for issues with Aerial screen saver only.


Installation error

Verification stage results in "... access to federation metadata could not be verified" for both internal and external options. My DC is an Azure VM with all network traffic allowed, both by means of Azure NSG as well as server firewall. External DNS is Azure-managed, internal one is located on the same VM server.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d414782-ca68-6008-2e3d-063b2e965be1
Version Independent ID: 2471d59d-0a3e-43a0-4d7e-9bb09dc7bc2d
Content: Tutorial: Federate a single AD forest environment to Azure
Content Source: articles/active-directory/hybrid/tutorial-federation.md
Service: active-directory
GitHub Login: @billmath
Microsoft Alias: billmath

You need to use your cloud administrator .onmicrosoft.com account in the first step of the wizard. Then you need to use your local admin account in the second place where the wizard prompts for credentials. See the settings in my blog post and see if it helps. (Blog post is for PTA but the credential steps will be the same<EMAIL_ADDRESS>

You need to use your cloud administrator .onmicrosoft.com account in the first step of the wizard. Then you need to use your local admin account in the second place where the wizard prompts for credentials. See the settings in my blog post and see if it helps. (Blog post is for PTA but the credential steps will be the same<EMAIL_ADDRESS>
Thats exactly what I did. I note that before dealing with federation I have successfully configured password sync and PTA, and they both worked fine.

It might be a misleading error. Is it working now then or are you still getting an error?

Yes it's working.

From: Marilee Turscak - MSFT<EMAIL_ADDRESS>Sent: Tuesday, October 23, 2018 6:45:58 PM
To: MicrosoftDocs/azure-docs
Cc: Marko Čurko; Mention
Subject: Re: [MicrosoftDocs/azure-docs] Installation error (#17333)
It might be a misleading error. Is it working now then or are you still getting an error?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/17333#issuecomment-432325401, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APNII-IW_94JLa8-rnxsYY_4T3lexpQrks5un0fGgaJpZM4XzW0w.

Thank you. In that case we will proceed to close this thread. If you have further questions, please leave a comment and I will gladly continue the discussion.


Fix the newest ESP-HAL's Alarm's method

Fix the newest ESP-HAL's Alarm's method: interrupt_enable

Thanks a lot for your contribution!
Unfortunately, those latest esp-hal changes also cause compile errors for ESP32-S2 and ESP32-S3. I guess you can't test that on hardware but if you could fix those, I can double check on the target hardware.
Seems like just one trait is not in scope for these target

Thanks for the tip, but I only have ESP32-C3, so only tested ESP32-C3. Now I've tried fixing ESP32-S2 and ESP32-S3 and the compilation is successful, but I don't have the hardware to test them


new user can't create new file ( when specified scope doesn't exist )

3. What are you trying to do?
Create user, with user's scope( say user1 ), and create a new file.
4. What did you expect to see?
I expect it can create user without the need to manual create the folder path on the terminal.
5. What did you see instead (give full error messages and/or log)?

user1's folder on the os has not been created
the user's UI homepage shows "This location can't be reached."
it can't create new file on the user's UI.

6. How can someone who is starting from scratch reproduce this behaviour as minimally as possible?
start as
filemanager -s users -p 5000 &> f.log &

login as admin, and then create user user1, assign the scope users/user1
login as user1, see the homepage text (should not says can't reached), try if it can create new file.
version:
filemanager version 1.1.1

It's the correct behavior. File Manager isn't supposed to create a folder for you when you set the user's scope. The user's scope should be an already existent folder.
I'll think about this. I don't whether or not implementing this is a great idea though.

It's the correct behavior.

We may have different scenery for the situation of creating user, I think it's inconvenient for the extra step to create the scope at the terminal.
Good to know you'll thought about this.

This will be out in the next release 😄

Good to hear that !   :+1:


Support multiple versions of the GraphQL spec, including breaking changes

As the GraphQL spec evolves, breaking changes are introduced. This includes:

Changes to directive locations
Doc strings
Validity of Introspection queries

To work properly across spec versions, the plugin and associated language service need to ship with a number of supported spec versions, and allow the developer to pick the one that their endpoint supports.

@asiandrummer, @leebyron: I'm mentioning you guys here to get your thoughts on any established solutions for this.
I'm currently considering bundling a version of graphql-js for each published version of the GraphQL spec. Based on a configuration, the language service will then require the appropriate version for compatibility with the endpoint in use.

@jimkyndemeyer Have you condered doing it like the tslint plugin? They have a config option to select the location of the tslint js files which they load

any news on that @jimkyndemeyer ?

@waterfoul configuration is only a small part of this issue. Breaking changes can affect core functionalities such as the lexer, parser, completion, validation, introspection etc.
I'm currently experimenting with an approach that is similar to how the JavaScript tooling in IntelliJ works, namely by supporting multiple dialects (they have ES5, ES2015 etc.). This would also remove the need for a Node.js process handler and the reliance on the reference graphql-js implementation.
I'll update as things progress, but note that the time spent on this is carved out of my spare time.

Thanks for the update @jimkyndemeyer

Closing this in favor of #164.
v2 of the plugin will take the samme approach of the JavaScript tooling in IntelliJ, with the parser and lexer supporting the latest specs, and validation etc. built on top of that.
See the alpha release for current status: https://github.com/jimkyndemeyer/js-graphql-intellij-plugin/releases/tag/2.0.0-alpha-2


[SPARK-39529][CI] Combine two configure jobs, centralize logic

What changes were proposed in this pull request?
CI jobs configure-jobs and precondition can be combined into a single job, skip logic can be moved into one place.
Why are the changes needed?
This simplifies the workflow file and puts logic into a single place.
Does this PR introduce any user-facing change?
No
How was this patch tested?
In CI.

@HyukjinKwon here is some simplification.

Thanks for taking a look, @EnricoMi . Mind rebasing this please? I think it conflicted with https://github.com/apache/spark/pull/36922

and .. seems like actually what this PR does is similar with https://github.com/apache/spark/pull/36922 in fact :-).

Not quite, #36922 moves configure-jobs together with on.schedule and on.push out of build_and_test.yml while this PR combines preconditions with configure-jobs and moves logic from across the workflow into configure-jobs". So that can still be done, but now moving it into preconditions`.
I can rebase this and move the logic into preconditions. Are there any other reworks going on right now? Visibility of concurrent work is poor.

@HyukjinKwon rebased. The conflicts weren't too bad, and the diff looks still useful.

Can one of the admins verify this patch?

The approach seems pretty fine to put the logics into precondition. I have another idea on the top of this PR. Let me create a PR - let's co-author my PR.

Fixed by #36940.


#773 Jakarta compatible version of ews-java-api

See https://github.com/OfficeDev/ews-java-api/issues/773
Basically this change does the following:

Change two import statements from javax to jakarta
Add required dependencies to
-- jakarta.xml.bind:jakarta.xml.bind-api (3.0.1)
-- jakarta.xml.ws:jakarta.xml.ws-api (3.0.1)

Unfortunately I did not find out how the existing code manages the above dependencies to include the required modules.

@microsoft-github-policy-service agree [company="BSI Business Systems Integration AG"]

@microsoft-github-policy-service agree company="BSI Business Systems Integration AG"

@microsoft-github-policy-service agree company="BSI Business Systems Integration AG"

Is there an ETA when this fix will be available on Maven Central?


Autogenerated entries: allow image override per entry

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Description
In the current state, Docusaurus' autogenerated entries generates tiles looking like this:

Auto-generating entries is a great feature, and in my case, I'd like to use it to get scalable docs, such as listing many partners that my company integrates with.
For this, I would suggest to add the ability to customize the image that we add to the tile. Currently it's either the file or folder icon.
For example, adding this to the sidebar to specify a new image:
  {
          type: 'category',
          label: 'Essentials',
          link: {
            type: 'generated-index',
            title: 'Essentials',
            image: 'somelogopath.png'  <------- new
            description: 'my description',
            slug: 'dev/tutorials/essentials',
          },
          items: [
            'some link',
}

Or when generating tiles from a doc page with:
<DocCardList items={useCurrentSidebarCategory().items}/>

We could perhaps define the image in each entry in the sidebar.js file as well, using longhand notation:
   {
              type: 'category',
              label: 'My page',
              link: {
                type: 'doc',
                id: 'dev/...', <------- contains the DocCardList component
              },
              items: [
               {
                  type: 'doc',
                  id: 'myDoc',
                  image: 'somelogopath.png'  <------- new
                },
              ],
            }

Has this been requested on Canny?
No response
Motivation
I need this feature for scalability reasons so this feature will happen either on my own repo, but it should ideally be a core feature as it might help other users. I can possibly get a developer to submit a PR to your repo if you can share some pointers on how to do this 'the right way'.
API design
No response
Have you tried building it?
No response
Self-service

[X] I'd be willing to contribute this feature to Docusaurus myself.

By "image", you mean the "icon"?
You can already do so by swizzling and passing the source through customProps. It's very, very hard to design a generalizable API in this case, because most icons aren't images—they are either SVGs, React components, font awesome, or emojis.

that's what i meant. yes. Ok brilliant, i'll take a look at this, thanks Josh.

By "image", you mean the "icon"?
You can already do so by swizzling and passing the source through customProps. It's very, very hard to design a generalizable API in this case, because most icons aren't images—they are either SVGs, React components, font awesome, or emojis.

Just saying "swizzle" it doesn't give enough information how to actually do so. Without adding any API changes, it would still be helpful to put some actual code examples in the docs how to achieve custom Link icons on autogenerated category cards.

Hi @Josh-Cena
If you could provide an example for this use case it would really help. Unfortunately I cannot find anything regarding this generation in the docs so far and how I can customize those predefined card icons/unicode configurations.

For everyone coming here. The component you have to swizzle is the DocCard component. I recommend to swizzle it with --eject in order to not modify too much of the original component.
That way in case of potential breaking changes (upcoming v3) the diff and migration effort is hopefully rather small and you can compare newer versions to your old code.
Command used: npm run swizzle @docusaurus/theme-classic DocCard -- --eject

Hope that this can be revisted with proper official way rather than having a workaround/hack that leads to this:
[WARNING]
Swizzle action eject is unsafe to perform on DocCard.
It is more likely to be affected by breaking changes in the future

@undergroundwires this is not a workaround/hack, this is the official way
You can override whatever we provide, we just want to warn you that we might have to refactor things and you'd need to adjust your code accordingly.
Unsafe might feel a bit too scary but it's perfectly fine to eject it

For anyone interested, I explained how to do this here: https://github.com/facebook/docusaurus/discussions/10476#discussioncomment-10545432


consent disabled on ci environments

I've tried 3 times now on machines that have Node installed without Nuxt and not once have I seen the prompt that allows you to opt out of telemetry. I know I can disable it and I have - but I also know there is supposed to be a prompt in the CLI and I haven't seen it once when creating a new project.

Can you check if there's a .nuxtrc file in your user directory?
The telemetry can be enabled or disabled globally with a flag, which saves the choice in that file in the user directory.
Maaybe that happened for you for some reason

Yep it's there with a telemetry.seed and yes, as I've been told now (repeatedly) I know there are ways to disable telemetry. This issue is here because there's supposed to be an opt-in prompt in the CLI and it seems to be disabled.

Hi dear @robconery thanks for making the issue.
Actually it is finally team decision to make a change or not but technically it isintended that we skip prompt on headless environments (src) since making a prompt basically breaks CIs and not doing so we would miss almost all telemetry data of CodeSandbox, Vercel, netlify, etc. We had an alternative choice to enforce consent per-project but after initial version many reported it is frustrating prompt so we made it one-time per machine.
Also consider that telemetry is not only package that sends metrics. Basically any npm dependency installed in CI environment can use postinstall script to send a network request (like dependencies using OpenCollective hook so please beware to also disable each!). So if privacy is really a matter, it is your job (DevOps and Firewall) to set proper roles to prohibit external access from Container and Production servers. If there was not a error on CI, perhaps you would never notice this one. Other dependencies may actually leak source-code with a silent hook...
Also comparing to similar frameworks, we at least make a one time prompt on machine instead of completely making it silent, also stats are not only hashed, but hashed with a (machine+project) seed we cannot ever even track user activity. We really did our best to respect privacy as much as possible without losing DX or possibility to have proper stats.

If I understand your reply - you're saying you have a prompt but you disable it because it was... breaking things so you opt-in everyone automatically, even in a production environment. And you're contending that automatically opting in my application is OK because other projects are doing it.
The only telemetry that was emanating from my app was from Nuxt and I didn't opt-in to that and now it appears I was never given the chance. We can argue whether this is a good idea or not - however this issue is about the CLI not prompting me for opt-in. Am I understanding you to say that there is a prompt and it's disabled and you don't intend to fix it?

So if privacy is really a matter, it is your job (DevOps and Firewall) to set proper roles to prohibit external access from Container and Production servers

YIKES. I think you should rethink this before posting it in a public forum.

pure misunderstanding a bit. He's saying after users complaining about the opt-in being asked over and over, they only ask for it once per machine (but they did not "disable" it).
That's a choice that happened because of user feedback, and one that can be discussed and reverted if need be.

The only telemetry that was emanating from my app was from Nuxt

Then I think you didn't even get real security issue of your environment and trying to balme nuxt because could see that request :) (please read more about postinstall. at least i'm sure we have opencollective hook but you never mentioned)

so you opt-in everyone automatically

You might say. But then you might be better start a general protest against telemetry concept itself when Gatsby and NextJS do opt-in by default with zero consent too. At least we make CLI consent when possible (local system)

YIKES. I think you should rethink this before posting it in a public forum. Privacy is ALWAYS a concern.

However i disagree this is a security issue,  there is<EMAIL_ADDRESS>you could use instead of tweet or making issue!! So i think you are to blame right now
Afterall I fully respect and understand frustration.  We spent weeks discussing about cons-pros and trying different setup. One project cannot make everyone happy but we are open to constructive feedbacks. Like i mentioned above, possibly also doing consent in last step of create-nuxt-app.

So... is it my fault that this prompt is disabled as well? That's the issue here - you can keep attacking me or you can acknowledge that there's a problem with your CLI. I make a fine target I guess.

Also consider that telemetry is not only package that sends metrics. Basically any npm dependency installed in CI environment can use postinstall script to send a network request (like dependencies using OpenCollective hook so please beware to also disable each!)

Then I think you didn't even get real security issue of your environment and trying to balme nuxt because could see that request :) (please read more about postinstall. at least i'm sure we have opencollective hook but you never mentioned or noticed)

Just because someone can do something doesn't justify someone else doing something similar, especially when it's a potential risk to end-users data. This is an incredibly weak point.

However i disagree this is a security issue, there is<EMAIL_ADDRESS>you could use instead of tweet or making issue!! So i think you are to blame right now

You think leaking production information from end-users isn't a security issue?

This isn't the intended title of this issue. I think it's fair to wont-fix this if that's your response - we can move the opt-in discussion to another thread.

If a particular metric is risking leaking information, please report and we will directly address (also wip-out from DB)
If you think there is a way to respect privacy even more by consenting per-project and opt-in, kindly please create a proposal. We will make a poll and based on that finally respect user's choice and make change
Again please please re-consider infrastructure security by your team. nuxt is not evil but if you care about leaking information and at the same time allowing container to make a remote request, something is wrong
I can understand frustration and honestly we had most of this concerns before published telemetry. It is not possible by just trying to blame nuxt team

It is not possible by just trying to blame nuxt team

where did someone blame the Nuxt team? Reading through every comment in this issue, there's been no blame assigned outside of you blaming an end-user.

where did someone blame the Nuxt team? Reading through every comment in this issue, there's been no blame assigned outside of you blaming an end-user.

I truly apologize if by any means implied a blame on you <3 But I consider Just because someone can do something doesn't justify someone else doing something similar, especially when it's a potential risk to end-users data as a blame directly about decision that made by nuxt team.
TBH I see no point to continue this discussion. By any means tried to clarify reasons of current behavior and openness to respect user choices and changing CLI. You just discovered something and have a strong opinion against it and it is respected and tracked here :)

This is discouraging. I wish you could understand that just the appearance of a framework sending data to a 3rd party server in production without the developer's consent could get someone fired. I'm urging you to respect the developers that use your product and make the opt-in clear and stop collecting production data.

@robconery Actually we can directly make a release to disable sending events on CI, but we have to first confirm it internally (it is not my personal decision). You asked for a change, and it is being discussed, nothing is discouraging :)

So... the issue title is again misleading and not at all what I intended. The issue isn't CI environment - it's production and moreover the CLI prompt has been disabled.
I'm feeling like this entire thread has gone far, far off the rails and my best course of action right now is to remove Nuxt entirely and go with plain old Vue. I'm sure you and your team will come up with a good solution in the future and best of luck to you all. I need to focus on something else for now.

If you checked source line i referred it affects both production and CI (basically a check any environment we can't consent) so title is still relevant to what you intended...
Still your issue is under discussion since reopened whilst you can unfolow. So thanks for bringing it up and best luck ❤

One solution we could do is:

Set telemetry consent per project
If telemetry is not explicitly enabled (.nuxtrc or nuxt.config) and we cannot prompt (CI): disable it with message how to configure it (npx nuxt telemetry enable/disable)

If you want to enable or disable Nuxt telemetry in your machine (for all projects), you can use the npx nuxt telemetry enable/disable --global command to not be annoyed by prompt everytime you create a project on your machine.

@robconery,  measurements took via #35 (please check rollout-strategy) and best wishes again :)

You think leaking production information from end-users isn't a security issue?

@bnb go tell this to Bill Gates


MudFileUpload: fix AppendMultipleFiles keeping stale file references (#9586)

Description
Resolves #9586
Resolves #9795
Fixed an issue where uploading files multiple times with AppendMultipleFiles and attempting to read the file contents would throw an exception indicating that those files no longer exist.
Problem explained in https://github.com/MudBlazor/MudBlazor/issues/9586#issuecomment-2278812116.
Whats it boils down to is that when using AppendMultipleFiles in MudFileUpload we append "new" files to our list of "old" files. The references to old files however no longer exist in the HTML input, causing an error when trying to read those files.
Currently users have to disable AppendMultipleFiles and make use of the file references with every upload.
The fix proposed here consists creating new InputFile instances with every upload, so that the previous file references are retained. This implementation implies the following:

there are multiple file input controls in HTML, each with their unique id
only one input is "active" at a time
all but the newest inputs are destroyed after ClearAsync is called
users can no longer provide their own input ids since we now have multiple inputs at once (⚠ could be considered a breaking change)

This also fixes an issue where the FilesChanged callback would not be triggered when uploading the same file twice (despite the file contents having changed) (#9795).
How Has This Been Tested?
Visually with test components and with some basic unit tests.
Type of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

It could be possible to test against this by playing around with IBrowserFiles, will try to look into that soon.

Can't test against the actual bug with bUnit since it's a browser error (in JS). Will do more manual regression testing before publishing the PR.

Ready for review. I will do some more some manual testing on all browsers today to make sure I didn't miss any edge cases.

@henon should be this moved to v8 or this breaking change is fine?

Let's play this safe and release it with v8. This is not urgent is it? And we have decided to start the v8 process now anyway, so it won't be long.

Nope not urgent, I prefer playing it safe too, thanks!

Do we merge this in v8? @henon

Yes! Thanks @igotinfected

@igotinfected What would you say we should write in the migration guide about this?

@igotinfected What would you say we should write in the migration guide about this?

(The fix description)
Fixed an issue where uploading files multiple times with AppendMultipleFiles and attempting to read the file contents would throw an exception indicating that those files no longer exist.
(The breaking change description)
The component now generates a new input with every file change to be able to retain references to previous files. As such, it is no longer possible to supply your own id to the underlying input.
... or something similar!

So what should people do who rely on that id? What workaround can we propose to them?

Hmm I can't think of a scenario where you would absolutely need the id of the underlying input other than for automated UI testing purposes. You could use a different selector instead, for example by adding your own custom attribute like data-test-id that would be applied to all inputs though with the current implementation, so you'd have to do something like:
@* razor code *@
<MudFileUpload data-test-id="my-test-id" ...

// UI test code
var inputs = document.querySelectorAll('[data-test-id="my-test-id"]');
var activeInput = inputs[inputs.length - 1];
...

We can probably mess around with the @attributes if needed to only apply it to the active input if it causes issues for people down the line but I don't think it will be necessary.

Thanks, I think this explanation is enough. Peope can find it when they follow the link to this issue.

Added to the v8 migration guide at #9953


Does commands auto-registered?

Hi, quick question, I use php artisan module:make-command to generate command files.
Does these commands auto-registered in the app?
Or I should manually register them in app/Console/Kernel.php?
Thanks!

Hello,
it won't no sadly because laravel itself doesn't want it, I asked them about it a while ago.
So you have to register them yourself. It doesn't have to be in the kernel.php file though, it can be in a service provider.

Hi, according to the official doc here:
https://laravel.com/docs/5.6/artisan#registering-commands

Because of the load method call in your console kernel's commands method, all commands within the app/Console/Commands directory will automatically be registered with Artisan.

So the default assumptions is like 'command files under Command folder will be auto-registered'.
Maybe in the service provider generated from your package, load the commands files, too?
    $this->registerTranslations();

    $this->registerConfig();

    $this->registerViews();

    $this->registerFactories();

    $this->registerCommands(); // maybe add this?

    $this->loadMigrationsFrom(__DIR__ . '/../Database/Migrations');

What do you think?
And what does 'laravel itself doesn't want it' mean?
Thanks!

And what does 'laravel itself doesn't want it' mean?
It means I asked on twitter if they wanted to have it work for more than just the app/ folder but they don't.


Updated mongoose to 5.3 (issue #747)

I have updated mongoose to version 5.3 in order to support mongo v 3.6 and higher.
The API is still compatible with the older version of mongodb (3.4).
Fixes #747

Merged.


Various Pattern nodes for AEC and MFG

Collection of Pattern nodes for Circles, Hexagons, Cloverleafs, Grecian and Squares
Cloverleafs

Grecian

Hexagon

Squares

Circles

This is great, super awesome! Have you considered per-tile variation/randomization? That was the trickiest part of the shape nodes we were working to contribute, hehe, but is pretty important for artists. It's hard to "tack-on" because it's tied to how the tiles/shapes are generated, especially for randomizing individual shape features.
I'll link to a gist with our nodes, so they can be inspected for comparison.

@crydalch I like this suggestion, and perhaps random variation would make a great future contribution, building upon the core nodes defined here?  For example, one could imagine a future circlesrandom that builds upon the circle node in this changelist, with additional controls for random colors and placement, and this seems independent of the more structured circles node defined here.

A modular approach to patterns is an interesting topic. Might require a bit of planning before throwing nodes at the problem. I'm all for proceduralism having worked on Substance in the past and knocked my head on other procedural node-based tools. But then we should have a plan for a "prclib" where changes can be more accepted than stdlib, and where a series of well planned foundational nodes can be used to build up a library of patterns.
There might be a feature or two missing now that would prevent full procedurals, but we can learn from existing solutions.

Procedural patterns is interesting, but is far beyond where my original comment about randomizing tiles was intended.
See our original PR for what I meant by per-tile randomization: https://github.com/AcademySoftwareFoundation/MaterialX/pull/1329#issue-1671811895
Apologies if my comment about randomization implied sophisticated procedural patterns/textures.

In the past, the number of individual node primitives in MaterialX has been raised as a big concern. So I think if we assume that we'll have N shape nodes, then N random-shape nodes, it's going to fly in the face of that guidance.
Even setting that aside, it makes sense that tiling and randomization should really be built-into tiling shape nodes...

@crydalch There's definitely a balance to strike between providing "ubernodes" that can accomplish everything, and providing very granular functionality that promotes reuse and recombination.  In this case, I think the circle node is a great low-level primitive that will find reuse in many contexts, and I can imagine a wider set of "tiling shape" nodes that would be built on top of it.  I like the idea of the current circles node as a very minimalistic member of that "tiling shape" set, but of course I'm open to ideas on other structures as well.

To clarify the difference between regular and random "tiling shape" nodes, what would you think of a naming convention such as circlesregular versus circlesrandom?  The circlesregular node would map to the current circles proposal, and the circlesrandom node would allow for a much more complex artistic interface with color ranges, offset ranges, and so forth.

I still think that this PR is a set of basic nodes for common patterns, and it could fit as part of stdlib, but if we want to expand and create more complex basic nodes, with multiple parameters for tweaking and randomizing things, then it's better to separate them into a prclib where thing will grow and change frequently.
Note that the ten or so nodes I posted are a quarter of the size of the whole stdlib_ng.mtlx file. These things tends to get big quickly.

I'm curious about the periodic aliasing in the Grecian and Squares samples. Is that a consequence of upload to github, or would it make sense to examine anti-aliasing? I imagine the same question applies to all the shapes, but for those two it's visible to my eye.

I'm curious about the periodic aliasing in the Grecian and Squares samples. Is that a consequence of upload to github, or would it make sense to examine anti-aliasing? I imagine the same question applies to all the shapes, but for those two it's visible to my eye.

Yes it appears to be so.
I had run MaterialXView.exe --material TestSuite\stdlib\procedural\squares.mtlx --captureFilename squares.png --screenWidth 800 --screenHeight 600 --mesh resources\Geometry\plane.obj
In the viewer it appears to be ok.

grecian.zip

Thanks for uploading that, seeing the good pixels makes me happy :)

Adding some hero images of the patterns in Maya/LookdevX

One general question for all of these nodes is what nodecategory these should be in, and thus how/where would they appear in the Specification.  Currently they are authored as "procedural2d" nodes, but I think it would be good to create an entirely new node category for these procedural shape/pattern generation nodes, and thus a new section in the Specification.  I would propose "shape" as the new nodecategory, with a corresponding Shape Nodes section in the Spec.  Thoughts?

I'm ok with the changes you suggest.
I also experimented with returning a distance rather than a 0 or 1 value (actual SDF shapes), but could be a separate set of base nodes, as the output then needs further processing that for simple shapes is not necessary.
I haven't looked at @crydalch randomizations. I think I missed them. Where are they?
I did play with randomizing Size/Center with noises on my nodes. You can get some interesting patterns.
I was instead thinking if a rotation option would be useful, and if it should be a base feature of a shape, or if we can just rotate the shape output somehow at the pattern level.

@zicher3d I've updated the node names to align with tiledimage, and I'm thinking that we can add uvtiling and uvoffset as a second step if this approach looks promising.
Let me know your thoughts, and of course I'm interested in ideas from others in the community as well.

@zicher3d I've now made the second proposed change as well, aligning the inputs of the tiling shape nodes with those of tiledimage.  In my local tests, this approach seems more artist-friendly and consistent with MaterialX conventions, but let me know how the new proposed interface looks to you.

Checked the current status. I'm not in favor of the uvtiling change. We are losing the Spacing functionality.
I would think we could use both if we wire them properly. See the video.
https://github.com/AcademySoftwareFoundation/MaterialX/assets/7254958/625bf3a1-a8d6-46b6-a4eb-cae73e1811fd

@jstone-lucasfilm I went back to my original graph to do this proof of concept. I could not figure out the graphs changes after all the optimizations and new uvtiling and offset.
Check the video to see the desired behavior, and then we can discuss how to implement it.
https://github.com/AcademySoftwareFoundation/MaterialX/assets/7254958/fef4450b-a016-4841-b1df-1e26d2814673

Following up on a discussion with @ashwinbhat and @zicher3d, I've split the original grecian node into two simpler line primitives, grid and crosshatch, allowing artists to recombine them in a wider variety of ways.
Here are a few renders from the latest set of example materials, giving a sense of how these line patterns look in practice:
Grid node:

Crosshatch node:

Union of grid and crosshatch (just one of many possible combinations):


Map empty in app view

Describe the bug
After the first load, the car's location on the map is correct. After the first TriggerChange hook event the map card is empty.
To Reproduce
Steps to reproduce the behavior:
Load the app page and wait 10 seconds or if the car is moving it's instant.
Expected behavior
Car's position should be plotted on the map
Relevant entries from the logs
When the map is visible:
class="map leaflet-container leaflet-safari leaflet-fade-anim"
When the map is empty:
class="map"
So it seems that the new rendered page is missing the proper styling.
If I manually insert the styling back in the browser the map becomes visible again.
Screenshots

Operating environment (please complete the following information):
Manual install Debian buster/sid

Fixed on master. Thanks!


[FLINK-29940] ExecutionGraph logs job state change at WARN level when job fails

What is the purpose of the change
When job switched to FAILED state, the log is very useful to understand why it failed along with the root cause exception stack. However, the current log level is INFO - a bit inconvenient for users to search from logging with so many surrounding log lines.
Brief change log
We can log at WARN level when the job switched to FAILED state. I firstly proposed ERROR level which is only for the cases when system can not proceed normally.
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Per discussion in the JIRA, I closed the non-merged old PR #21266. Later we think we can make it WARN level to make it more visible. CC: @rmetzger


Adding stronger url regex validation to address issue #106

Added the url regex suggested by @dperini in issue #106 that allows for optional protocol validation, returns true for url's containing parameter strings, returns false for url's containing spaces, etc.

+1

this also fixes the issue mentioned in #121

Thanks for the PR @fslone

Glad to help. Let me know if there are any other things you'd like help adding or fixing, really like this project a lot.

Appreciate it @fslone


Added an option to the implings plugin that allows for notifications …

…to only be shown when the level requirement is met for the selected catching method.
Close #14693

Not too proud of the namings in the config class, but couldn't come up with something better. Feel free to suggest more fitting variable / config names and descriptions.


Refine Map API

Since the map fd over UDS API is here to stay, we want to make sure we get a new fd to send to userspace.
That new fd should only allow map operations that we want... and kernel support for that in unvpriv bpf is landing soon.
Would require some work in Aya to:

Call bpf(BPF_OBJ_GET_INFO_BY_FD) to populate the map info the Map struct
Add an API to call Map::new_fd(flags), which would do bpf(BPF_MAP_GET_FD_BY_ID) where flags should be an enum that supports ReadOnly and ReadWrite where the former propagates BPF_F_RDONLY and the latter, none.

+1 - We should start forming a hierarchy under var including bpfs

Yes, the more I think about it, the more pinning all maps to bpffs and using unix acls for permissions is definitely the right choice.
Since #8, we now have authentication for clients - the expectation being that the certificate CN maps to a unix user. I'll be adding code to make that user-id available shortly.
Therefore, the work required to implement this would be as follows:

Either mount our own bpf fs in /var/run/bpfd OR use /sys/fs/bpf/bpfd.
Extend the Load API to include map permissions - umask or unix permissions.
Come up with a sensible scheme e.g maps have uid: $user and gid:bpfd
Implement the necessary code to pin maps on creation, and remove pins on deletion
Update the docs to state "if you want to access a map from userspace, set the pinning mode to 1 in your BPF map definition"

Also just had a thought. Removing pinned maps on program unload should be optional.
This would be to enable a use-case like migrating data from one map to another.
e.g

Unload program which uses /var/run/bpfd/UUID/MAP_A - don't remove pinned map.
Run migration program that reads data from MAP_A and writes data to MAP_B (outside of bpfd).
rm MAP_A; mv MAP_B MAP_A
Load program again, but using the existing var/run/bpfd/UUID/MAP_A

The evolved GetMap API could be called before unload of program A, so the program run outside of bpfd for migration could operate on it.
We might need an additional API to support with_maps_from: UUID... but that can be added later.
The main reason I brought this up was to ensure we don't make decisions re: dir heirarchy now that we come to regret later

Just a clarification - when you say Unix ACLs I assume you mean basic perms. bpfs does not support any fine grain ACLs - those ops are not defined in the file_ops struct.

This was completed in https://github.com/redhat-et/bpfd/pull/42 I believe
Closing for now feel free to re-open @dave-tucker


TST: Test that all content enums are represented in AnyData

PR to add a test to check

the number of models in AnyData match the number of enums in Content
all models in AnyData have a content attribute
the annotation of the content attribute is a Literal with one enum.Content value
all enums in Content is represented by a pydantic model in AnyData.

relevant problem encountered recently ref #833
This PR is based on #834,  which is awaiting #835 to be solved.
Will rebase this one when ☝ is solved. 😄

This is rebased and ready for review now @mferrera 🙂


Failing in dependency

I am not able to build cqerl, it crashes with issue in "snappy"
My OTP verion is 19.
make[1]: Entering directory `/home/shobhit/twine/car/multiscreen-server/twine2.0/erl/tls/deps/cqerl'
DEP    snappy
{"init terminating in do_boot",{{badmatch,{ok,{{"HTTP/1.1",403,"Forbidden"},[{"date","Fri, 23 Aug 2019 03:18:35 GMT"},{"server","AmazonS3"},{"content-length","243"},{"content-type","application/xml"},{"x-amz-request-id","47CE5E3423D60A40"},{"x-amz-id-2","5CC5k3bO6/UQXohH2/vBjyhVgfQ2XSRk/GakIJ6dl+6+CNqR/HFii61m40WEarOx5+HhtVg3Jzc="}],<<60,63,120,109,108,32,118,101,114,115,105,111,110,61,34,49,46,48,34,32,101,110,99,111,100,105,110,103,61,34,85,84,70,45,56,34,63,62,10,60,69,114,114,111,114,62,60,67,111,100,101,62,65,99,99,101,115,115,68,101,110,105,101,100,60,47,67,111,100,101,62,60,77,101,115,115,97,103,101,62,65,99,99,101,115,115,32,68,101,110,105,101,100,60,47,77,101,115,115,97,103,101,62,60,82,101,113,117,101,115,116,73,100,62,52,55,67,69,53,69,51,52,50,51,68,54,48,65,52,48,60,47,82,101,113,117,101,115,116,73,100,62,60,72,111,115,116,73,100,62,53,67,67,53,107,51,98,79,54,47,85,81,88,111,104,72,50,47,118,66,106,121,104,86,103,102,81,50,88,83,82,107,47,71,97,107,73,74,54,100,108,43,54,43,67,78,113,82,47,72,70,105,105,54,49,109,52,48,87,69,97,114,79,120,53,43,72,104,116,86,103,51,74,122,99,61,60,47,72,111,115,116,73,100,62,60,47,69,114,114,111,114,62>>}}},[{erl_eval,expr,3,[]}]}}
Crash dump is being written to: erl_crash.dump...done
init terminating in do_boot ()
Any help would be highly appreciated.

Should be fixed now that we replaced with snappyer


Extended sap.ui.core.TooltipBase renders twice

URL (minimal example if possible)
https://embed.plnkr.co/khqeNhTfPQNflUb6?show=control%2FCustomTooltipRenderer.js,preview
Steps to reproduce the problem

Open the above sample
Move the mouse to the control to trigger rendering the custom Tooltip

What is the expected result?
The tooltip should be rendering once.
What happens instead?
The render function is called twice.
Any other information? (attach screenshot if possible)
In the 1st call, tooltip._getPopup().getOpenState() is "CLOSED".
In the 2nd call, tooltip._getPopup().getOpenState() is "OPENING".
... which would be the only way I could distinguish when to really manipulate the DOM.
But _getPopup() is a private method.
Regardless, I believe the render function shouldn't be triggered twice in the first place.

Hello boghyon,
I could reproduce the issue and forwarded it to the responsible development team. They will contact you directly for further processing. You can refer to the internal incident<PHONE_NUMBER>in case of questions.
Regards Sebastian

Hi @boghyon,
the fix for the issue is merged to the master branch. In case you need the fix in other versions, please reopen the bug report.
Best regards,
Jiawei


Unable to see sign in/sign uppage in my local ?

I have installed Langflow in my local set up and I want to use username and password, so i followed this documentation https://docs.langflow.org/guidelines/login
installtion method : pip install langflow
can you help me how to run this in local with username and password?

not sure i tried docker as well but could able to enable the login screen, not sure if i am missing anything here even
`langflow run --env-file .env this is not working, when i tried in my console to see langflow run --help

`

resolved in local

resolved in local

how man can you help me please, i am also facing the same issue


Section subtitle is too repetitive

This is because the design, but we can ask to Edwin for a posible solution


feat(dasboard): adding totp in dashboard

I tried out this PR locally, I tried scanning the QR code but I get format unsupported error. Until the issue is resolved I don't think 2FA should be merged.


docs(messaging): add gcp_pubsub as a messaging system

Changes
Adds gcp_pubsub as a messaging system value
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist

[x] CONTRIBUTING.md guidelines followed.

Waiting to sign the CLA until the PR is created.
Also I ran make fix, but it generated some diffs in CONTRIBUTING.md (* -> -) and CHANGELOG.md (whitespace), so I left those out.

[ ] CHANGELOG.md updated for non-trivial changes.

Skipped, since it is a trivial change

[ ] schema-next.yaml updated with changes to existing conventions.

Skipped since it only affects the docs

Disclaimer: I'm not familiar with Otel Semantic Conventions.
Is there a place to specify a semantic convention for a value (not a key). This value (gcp_pubsub) will be used in multiple languages. Is there a place we can define it upstream so it appears in a file like opentelemetry/trace/semantic_conventions.h(for C++)?

Hi @alevenberg . I'd recommend you introduce a dedicated document for GCP PubSub, as it exists for Kafka or RabbitMQ. There you define additional requirements for GCP PubSub instrumentation, like it's done here: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/messaging/rocketmq.md?plain=1#L13
You might just start out with defining the value for messaging.system, you can then add definitions for more system-specific attributes there if needed. Ideally you (or somebody else with domain knowledge) would then be willing to own and maintain this document specific to GCP PubSub.

Is there a place we can define it upstream so it appears in a file like opentelemetry/trace/semantic_conventions.h(for C++)?

No, that's still a manual process and requires changes for each supported language.

Hi @alevenberg . I'd recommend you introduce a dedicated document for GCP PubSub, as it exists for Kafka or RabbitMQ. There you define additional requirements for GCP PubSub instrumentation, like it's done here: main/docs/messaging/rocketmq.md?plain=1#L13
You might just start out with defining the value for messaging.system, you can then add definitions for more system-specific attributes there if needed. Ideally you (or somebody else with domain knowledge) would then be willing to own and maintain this document specific to GCP PubSub.

Sounds good! I added it, and I will add more information about tracing semantic conventions in GCP Pub/Sub. I can own this document for now.

Is there a place we can define it upstream so it appears in a file like opentelemetry/trace/semantic_conventions.h(for C++)?

No, that's still a manual process and requires changes for each supported language.

Ack, thanks for answering!

cc @dbolduc

Should we link to gcp-pubsub.md in /docs/messaging/README.md ?
https://github.com/open-telemetry/semantic-conventions/blob/6a9acefdbf73b96070d97c4398ab3227d834a992/docs/messaging/README.md?plain=1#L18-L22

Done

Can one of the maintainers explain how to update the markdown tables with the .yaml changes?
I ran
make table-generation

docker run --rm -v /usr/local/google/home/alevenb/google/semantic-conventions/model:/source -v /usr/local/google/home/alevenb/google/semantic-conventions/docs:/spec \
        otel/semconvgen:0.23.0 -f /source markdown -md /spec

But it didn't make any changes
So I tried
❯ docker run --rm otel/semconvgen --yaml-root model/registry/messaging.yaml markdown -md docs/attributes-registry
usage: gen-semconv [-h] [--debug] [--only ONLY] [--yaml-root folder]
                   [--exclude EXCLUDE]
                   [YAML_FILE ...] {code,markdown} ...
gen-semconv: error: No semantic convention model found!

But I got an error while using the tool


Add Configuration/Parameters tab

We should allow the user of the app to configure things - this can be setting up limits for the alarms as well as other start up information. This will give us the option of also starting the ventilation.
For now, we will just be focusing on creating the interface for it, and it will need to be plugged in later.

Here is an example for reference from the TV-100 Simulator

For now, we will be doing #19 and this will be fleshed out in the future.


checks if view is defined and if not, sets the default opensea view

closes #1501

Strange. I was fixing this and thought it had to be more complicated. Let me check this out.


Binary Size issue in lind-wasm

Our compiled wasm binary size is almost 10 times larger than the binary size compiled from same c program in wasi-libc/wasix-libc. This becomes obvious after we start to use Binaryen’s Asyncify for multi-processing calls as it will further expand the binary size by 3-4 times, which would start to cause some noticeable delay when running the wasm module. (wasix-libc also used Asyncify for multi-processing and therefore expanded the binary size by 3-4 times, but since their base binary size is small, so no obvious delay can be observed)
For example, for fork.c:

wasmer:

before asyncify: 16795 lines in compiled WAT file
after asyncify: 57064 lines in compiled WAT file

lind-wasm:

before asyncify: 133369 lines in compiled WAT file
after asyncify: 451485 lines in compiled WAT file

Another thing I've noticed is that the binary size in lind-wasm increases dramatically when we use some of the functions. For example, there are two c program, write.c and printf.c, and both of them are printing a message to stdout and the only difference is that one is using write syscall directly and another is using printf. And below is the number of lines in the compiled WAT file:
printf.wat: 450604 lines
write.wat: 9782 lines
My current thinking is that our binary size is too large because we included too many unnecessary stuff in glibc, like there are a lot of functions that are not working in lind-wasm, but we still included that into the binary and let user to call them.

Can you expand upon where you're seeing performance degradation?

So when I run wasmtime run fork.wasm, there will be a 5-6 seconds delay before the module is actually executing. The delay comes from wasmtime calling "compiling module" method, whose performance I think is directly related to the size of the binary.
btw, wasmtime has a cache feature for this, so if I run the module for the second time, it will start execute immediately without compiling the module again

I'd like us to explore if we can do this ahead of time and not pay this cost at load time.

yeah, I think it should be possible to do some pre-compile to the wasm module, since I just took a look into wasmtime and I noticed that they are actually detecting if the passed module is pre-compiled or not. And it will go to the compile module path only if it is not pre-compiled, otherwise it will just deserialize the object. I currently still didn't find how to pre-compile the module in wasmtime, but if this stuff exists in the code, then I think there must be a way to do it

I just figured out how to do pre-compile to wasm module. We can just run wasmtime compile to further compile the wasm file into cwasm file. And running the cwasm file will skip the compilation and started to execute immediately, so I guess the delay issue could be considered as resolved?
However, I still think the binary size is still an issue but I am not sure if we care about this

Great! I think your could close and open a new issue.   Or, if you want, just revise this issue perhaps by crossing out parts in the description that don't matter to make it clear what part you've fixed.


No video when streaming in a background service and app is minimized

My app can stream from a service when it is in the foreground. However if I turn off the screen or switch to another app the video will be blank but audio still streams.  Any ideas on how to troubleshoot that?

Hello,
Did you test using background example of my app sample?

Yes I was previously able to compile the sample app and it does send video when the app is not in the foreground. However I'm confused about ActivityBackgroundBinding in BackgroundActivity.kt. I can't find where that comes from.

Hello,
I'm glad you solved this.

Yes I was previously able to compile the sample app and it does send video when the app is not in the foreground. However I'm confused about ActivityBackgroundBinding in BackgroundActivity.kt. I can't find where that comes from.

ActivityBackgroundBinding is a link to the layout generated using viewbinding. Maybe I should remove viewbinding from the app and use a more recent way to do it or the classic one.


Update mods in a non-standard location?

Firstly, thank you for this mod! Works wonderfully.
Would it be possible to add in functionality for updating mods outside of the typical /mods/ directory? My specific use case is on a server, using automodpack to easily provide a modpack to my friends (at a directory like /automodpack/host-modpack/main/mods/).
To update those mods currently, I'd have to download that directory to a local client, add the DURW mod, launch the game, do /durw-client update all, and then re-upload. So, the ability to do a command like /durw-server update all "automodpack/host-modpack/main/mods/" would be a nice time-saver.

I will think about best practice to make that, but can't give deadlines. Currently I need todo little bit more important project. I recommend to join discord for not miss update

@wMarciano as a temporarily solution, maybe could be achived with SymLinks:
https://www.howtogeek.com/16226/complete-guide-to-symbolic-links-symlinks-on-windows-or-linux/

@wMarciano as a temporarily solution, maybe could be achived with SymLinks: https://www.howtogeek.com/16226/complete-guide-to-symbolic-links-symlinks-on-windows-or-linux/

I'm not sure if that possible, at least for files - not, because they change own names, but maybe for folder🤔 And what if he use Windows 🤔🤔🤔

Looking at the link without clicking it, that should tell you, that it's both for Windows and Linux.

I thought of something like this, but it would get so messy...all of the server mods would get mixed with the client mods, which would be potentially game breaking (for example—if the client modpack was targeting a different game version than the server is running)

I will just notify that that will be in next update. But when it gonna come out not sure yet. This year at least 😉

https://modrinth.com/mod/ducky-updater-rework/version/2024.11.1
Feature exist in new version


Enhancement carying about array index writter

name: 🎉 Insertion care about key index
about: Here is an implementation that supports inserting rows with an auto-generated field. In case you want to add a row and the array that you pass does not have indexes that follow each other strictly, it happens if a column of the row has no value, we do not put a key/value to this index.

submitting a new feature: target the master branch.

New Feature
(Fill in the relevant information below to help triage your issue.)

Q
A

New Feature
yes

BC Break
no

Proposal
(Please explain in plain english the feature you would like to see implemented.)
Checks before submitting

[x] Be sure that there isn't already a pull request about this. See: Pull requests
[x] This pull request is about 1 new feature and nothing more.
[x] Be sure to always target the lowest supported PHP version.
[x] Be sure to include tests.
[x] Be sure to have run composer test before submitting the fix.
[x] Be sure to update the CHANGELOG.md
[x] Be sure to update the documentation.

@LeoDevSecOps thanks for the proposed addition. Can you tell me the added value of this new feature versus relying on the currently existing Writer::addFormatter feature ?


Overview pie chart

What feature do you want to see added?
Add the possibility to define some limits for each columns.
Then in overview, I would be nice to have a pie chart like this :

For example in the example, if target of incorrect column is 20000, then we can view the percent of the limit reached.
I don't know if limit target can be defined in pipeline option, or as an attribute in json file
Upstream changes
No response

@totocaca123
Hi, i worked a lot on the new api and finally everthings works now. Maybe you can check out the master branch and try to use the new api and features to find some bugs before i release a new version? You can find some examples in the etc folder. I will adapt the documentation tomorrow. That would be great! I really appreciate your help 🙂


New Module: HiveMQ

This brings HiveMQ's official Testcontainer to testcontainers-java.
Features:

Testing MQTT 3 and MQTT 5 client applications
Integration Testing of HiveMQ Extensions
HiveMQ specific WaitStrategy

@YannickWeber
CI is currently failing with
/home/runner/work/testcontainers-java/testcontainers-java/modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQExtension.java:27: error: cannot access com.hivemq.extension.sdk.api.ExtensionMain
import com.hivemq.extension.sdk.api.ExtensionMain;
                                   ^
  bad class file: /home/runner/.gradle/caches/modules-2/files-2.1/com.hivemq/hivemq-extension-sdk/4.4.4/f0c556c64f5ae71249381038f0f86e5ba7b9c4e9/hivemq-extension-sdk-4.4.4.jar(com/hivemq/extension/sdk/api/ExtensionMain.class)
    class file has wrong version 55.0, should be 52.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.

Do you have specific Java requirements? Then we should check out using Gradle's Java Toolchain feature for the HiveMQ module. We currently use JDK8.

@YannickWeber CI is currently failing with
/home/runner/work/testcontainers-java/testcontainers-java/modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQExtension.java:27: error: cannot access com.hivemq.extension.sdk.api.ExtensionMain
import com.hivemq.extension.sdk.api.ExtensionMain;
                                   ^
  bad class file: /home/runner/.gradle/caches/modules-2/files-2.1/com.hivemq/hivemq-extension-sdk/4.4.4/f0c556c64f5ae71249381038f0f86e5ba7b9c4e9/hivemq-extension-sdk-4.4.4.jar(com/hivemq/extension/sdk/api/ExtensionMain.class)
    class file has wrong version 55.0, should be 52.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.

Do you have specific Java requirements? Then we should check out using Gradle's Java Toolchain feature for the HiveMQ module. We currently use JDK8.

The problem is that the hivemq-extension-sdk requires Java 11. We solved the problem in the following way:

removed the compileOnly dependency on the hivemq-extension-sdk
configured gradle to execute the test with Java 11

What this achieves:

User that just want to use the HiveMQ Container can use Java 8.
Users that want to build HiveMQ Extensions on the fly are required to include the hivemq-extension-sdk as usual and are required to use Java 11 anyway

CI is currently failing in the Javadoc task for the HiveMQ module (https://github.com/testcontainers/testcontainers-java/runs/4609274189?check_suite_focus=true#step:7:70):
/home/runner/work/testcontainers-java/testcontainers-java/modules/hivemq/build/delombok/org/testcontainers/hivemq/HiveMQExtension.java:185: error: reference not found

         * This class MUST implement {@link com.hivemq.extension.sdk.api.ExtensionMain}.
> Task :hivemq:javadoc FAILED
                                            ^
/home/runner/work/testcontainers-java/testcontainers-java/modules/hivemq/build/delombok/org/testcontainers/hivemq/HiveMQExtension.java:189: error: reference not found
         * @throws IllegalArgumentException if the provides class does not implement {@link com.hivemq.extension.sdk.api.ExtensionMain}
                                                                                ^
/home/runner/work/testcontainers-java/testcontainers-java/modules/hivemq/build/delombok/org/testcontainers/hivemq/HiveMQExtension.java:190: error: reference not found
         * @throws IllegalStateException if {@link com.hivemq.extension.sdk.api.ExtensionMain} is not found in the classpath
                                                   ^
3 errors

Thanks to everyone involved and especially @YannickWeber for your patience. This was indeed a massive PR, but I am very happy we reworked it together and that we get a great new module into Testcontainers. Thanks!


Typo in ReadMe

dependancies -> dependencies

Coverage remained the same at 99.61% when pulling ead1660e7726fdb141dcc394e4eecae653437569 on romanzubenko:patch-1 into dee9fbbbda2f2483c657cf912f68db1a5ba1fcac on strongloop:master.

Thanks!


Implement isLatest for Dependency BOM Upload API

The Bom upload parameter isLatestProjectVersion was recently introduced. This pull request makes the parameter usable during Maven execution.
I noticed that during the project update the flag was reset, possibly a bug in DependencyTrack, so it is necessary to add this flag during the project update.

Merged with https://github.com/pmckeown/dependency-track-maven-plugin/commit/152ea762f048697664488467a6b279efb0ba2e40
Closing


Fix 'Trailing newlines' issue in todoist-progressbar.py

CodeFactor found an issue: Trailing newlines
It's currently on:
todoist-progressbar.py:202

fixed in next release/featurebranch


failing test (on jruby): css search problem involving whitespace and …

…node removal
The problem seems to occur only when due to removal of a node surrounded by whitespace two consecutive text nodes are left behind. In that case a css search for the remaining element ends up in a DTM exception:
Java::JavaLang::RuntimeException: Could not resolve the node to a handle
   org.apache.xml.dtm.ref.DTMManagerDefault.getDTMHandleFromNode(DTMManagerDefault.java:576)
    org.apache.xpath.XPathContext.getDTMHandleFromNode(XPathContext.java:184)
    org.apache.xpath.XPath.execute(XPath.java:303)
    nokogiri.XmlXpathContext.tryGetNodeSet(XmlXpathContext.java:198)
...

Since it might have been related I already tried replacing all uses of internal com.sun API with the official Xalan API, adding the 2.7.2 Xalan jars as per #1212, but it didn't help with this problem (and still caused the same errors mentioned there).

What is status? https://github.com/flavorjones/loofah/issues/88#issuecomment-122747924 says this is Rails 4.2 with JRuby.

As I wrote at https://github.com/flavorjones/loofah/pull/94#issuecomment-165411456, I cannot understand loofah and nokogiri support policy.

Looking at this now.

@kares If you are looking for important JRuby work, this issue is currently blocking Loofah and Rails on JRuby.
I've pushed the branch 1320_jkraemer_jruby-css-search-crash with the above failing test.

seems like a xalan bug to me - not sure about the 'best' work-around (since Xalan is no longer maintained).
might take me quite some time to get right - no promises that a fix will land (although do believe its fixable)


RuntimeError: shape '[2, 12288, 8, 3]' is invalid for input of size 7372800

When running the train of my custom data, this happens. I'm investing on what is it causing it. Still can't find the cause.
Any help would be apreciated. Thank you
Traceback (most recent call last):
  File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/pytorch/PVN3D/pvn3d/train/train_blm_pvn3d.py", line 547, in <module>
    best_loss=best_loss
  File "/home/pytorch/PVN3D/pvn3d/train/train_blm_pvn3d.py", line 376, in train
    _, loss, res = self.model_fn(self.model, batch)
  File "/home/pytorch/PVN3D/pvn3d/train/train_blm_pvn3d.py", line 196, in model_fn
    pred_kp_of, kp_targ_ofst, labels,
  File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 550, in __call__
    result = self.forward(*input, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/torch/nn/parallel/data_parallel.py", line 153, in forward
    return self.module(*inputs[0], **kwargs[0])
  File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 550, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/pytorch/PVN3D/pvn3d/lib/loss.py", line 86, in forward
    sigma=1.0, normalize=True, reduce=False
  File "/home/pytorch/PVN3D/pvn3d/lib/loss.py", line 58, in of_l1_loss
    kp_targ_ofst = kp_targ_ofst.view(bs, n_pts, n_kpts, 3)
RuntimeError: shape '[2, 12288, 8, 3]' is invalid for input of size 7372800

I put different keypoints for better visualization of my data. By setting them back to self.n_keypoints = 8 in common.py  I was able to solve the problem


[BUG] 2.7.0 hides/clips part of chart

Note: Maybe similar to #4759, but that problem might have to do with total chart padding and this doesn't. Here, specifically the top of a <Line> chart is getting clipped/cut off early.
Expected Behavior

Should be able to see items on all sides of the chart, as it was working in v2.6:

Current Behavior

Once updating to v2.7, the top of the chart gets cut off:

Possible Solution

Edit: So far, the padding I've been able to add is to the outside of the whole chart, not to just an axis itself. I'll keep looking for a way to do that.
I think you can add extra padding to make it work, but is this the indended behavior to start with? Is that the intended solution? Is the chart being created incorrectly (see below)? If so, it's not a bug, but then a note about padding could be added to the docs because it seems non-obvious. To be fair, maybe it's there and I didn't see it.
Steps to Reproduce (for bugs)

A link to the gh-pages live example would be useless because that code is going to change, but here's a pastebin of the current code:

https://pastebin.com/yeBLmXiU
Context

I'm not sure if it's relevant, but it's meant to be a graph showing effects of income on various other factors.
Environment

Chart.js version: 2.7
Browser name and version: Chrome 61.0.3163.100
Link to your project: Again, the project code is not going to stay the same

I've managed to create a sort-of solution. The tops of the lines of the chart still get cut off, but I at least get my own whole line to appear (code here: https://pastebin.com/Q7C7gas8):

It's a bit more space than I want above my top line, though.

I am having the same issue on a line chart that is percentage based therefore I often have data points at 100%.  Setting max to >100% makes it look quite odd so  another fix I have found is to disable the title in the canvas and provide my own title above the canvas.

not a solution but the clipping also goes away if positioning the title to bottom

Someone have solution for that ? Or how long have we wait for fixing it ?

The proposed fix #4688 for this bug doesn't work for charts without 0, as can be seen in the attached chart.
Problems
v2.7

doesn't correctly render: horizontal with min:0 (regular and reversed)
in case the significand digit of minNotZero is 1 or 2;
however the value itself has more significand digits,
the first tick is displayed outside the chart area or on top of the 0-tick.

Pull request #4688

doesn't correctly display charts without zero values
adds space for all log-lines up to 1, which the generators.logarithmic doesn't create.

Proposed fix
fix_for_logarithmic_scale_tick_bug_for_values_of_0.patch
.patch files aren't allowed in upload, so it's renamed as .txt
Example
Test for all bar plot possibilities (vertical/horizontal, with/without min: 0, default/reversed)
https://codepen.io/anon/pen/zPYMWz

The bug is caused by the introduction of the lineHeight (defaults=1.2) parameter for the title. This causes the title box to have a decimal height (default: 34.4px), which due to not rounding values clips the top line of the graph.
Workaround
Set title lineHeight option to 1.
Proposed fix
fix_#4790_BUG_2-7-0_hides_clips_part_of_chart.patch.txt

@jcopperfield I'm surprised that the lineheight is the cause of the problem directly but the comment about decimal heights made me go and look at the code in detail. It looks like we round line values but chart.chartArea is not rounded. Rounding that in the layout system does improve things but it's still not perfect.

I think this may be related to #4202

Does this bug fixed now? And how to fix it...

@tenznhok Looks like the bug still isn't fixed. I still have to use @jcopperfield's lineHeight: 1 workaround to avoid this problem.

This is not directly caused by the lineHight of the title box. In fact, hiding a title, changing lineHeightor adding padding may fix the problem, but not always. I believe the root cause is decimal round-off errors when checking if points are in the chart.chartArea. This explains why those changes can sometimes fix the problem.
I created a new PR #5790 to fix it.


Minecart GB doesn't get collected when player doesn't clear text upon completion

https://www.twitch.tv/videos/1496597849 timestamp at 59:28

Squawks->paad->0x2C = 0x5A upon success cutscene

Disable text-skip-skip for non lobbies and shops


Add deprecation warning to documentation

The canonical docs location is actually https://docs.pyfilesystem.org

@willmcgugan Fixed!

Thanks.


I can't build golang

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
The version on my pc is go version go1.7.1 darwin/amd64, but i downloaded a fresh version from git.
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/voxsim/Projects/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.7.1/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.7.1/libexec/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/bt/fmr6z5wx2b9b2x9w51y2m_300000gn/T/go-build667588921=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"

What did you do?
After I checkout the project in ~/Projects/go e I read here.
I setted GOROOT_BOOTSTRAP to /usr/local because my go installation is in /usr/local/bin/go:
export GOROOT_BOOTSTRAP=/usr/local
./all.bash

First result:
##### Building Go bootstrap tool.
cmd/dist
cmd/dist/build.go:8:2: cannot find package "bytes" in any of:
   /usr/local/src/bytes (from $GOROOT)
   /Users/voxsim/gopath/src/bytes (from $GOPATH)
cmd/dist/build.go:9:2: cannot find package "encoding/json" in any of:
   /usr/local/src/encoding/json (from $GOROOT)
   /Users/voxsim/gopath/src/encoding/json (from $GOPATH)
cmd/dist/test.go:9:2: cannot find package "errors" in any of:
   /usr/local/src/errors (from $GOROOT)
   /Users/voxsim/gopath/src/errors (from $GOPATH)
cmd/dist/build.go:10:2: cannot find package "flag" in any of:
   /usr/local/src/flag (from $GOROOT)
   /Users/voxsim/gopath/src/flag (from $GOPATH)
cmd/dist/build.go:11:2: cannot find package "fmt" in any of:
   /usr/local/src/fmt (from $GOROOT)
   /Users/voxsim/gopath/src/fmt (from $GOPATH)
cmd/dist/util.go:10:2: cannot find package "io" in any of:
   /usr/local/src/io (from $GOROOT)
   /Users/voxsim/gopath/src/io (from $GOPATH)
cmd/dist/test.go:12:2: cannot find package "io/ioutil" in any of:
   /usr/local/src/io/ioutil (from $GOROOT)
   /Users/voxsim/gopath/src/io/ioutil (from $GOPATH)
cmd/dist/test.go:13:2: cannot find package "log" in any of:
   /usr/local/src/log (from $GOROOT)
   /Users/voxsim/gopath/src/log (from $GOPATH)
cmd/dist/build.go:12:2: cannot find package "os" in any of:
   /usr/local/src/os (from $GOROOT)
   /Users/voxsim/gopath/src/os (from $GOPATH)
cmd/dist/build.go:13:2: cannot find package "os/exec" in any of:
   /usr/local/src/os/exec (from $GOROOT)
   /Users/voxsim/gopath/src/os/exec (from $GOPATH)
cmd/dist/build.go:14:2: cannot find package "path/filepath" in any of:
   /usr/local/src/path/filepath (from $GOROOT)
   /Users/voxsim/gopath/src/path/filepath (from $GOPATH)
cmd/dist/test.go:17:2: cannot find package "regexp" in any of:
   /usr/local/src/regexp (from $GOROOT)
   /Users/voxsim/gopath/src/regexp (from $GOPATH)
cmd/dist/util.go:15:2: cannot find package "runtime" in any of:
   /usr/local/src/runtime (from $GOROOT)
   /Users/voxsim/gopath/src/runtime (from $GOPATH)
cmd/dist/build.go:15:2: cannot find package "sort" in any of:
   /usr/local/src/sort (from $GOROOT)
   /Users/voxsim/gopath/src/sort (from $GOPATH)
cmd/dist/main.go:11:2: cannot find package "strconv" in any of:
   /usr/local/src/strconv (from $GOROOT)
   /Users/voxsim/gopath/src/strconv (from $GOPATH)
cmd/dist/build.go:16:2: cannot find package "strings" in any of:
   /usr/local/src/strings (from $GOROOT)
   /Users/voxsim/gopath/src/strings (from $GOPATH)
cmd/dist/build.go:17:2: cannot find package "sync" in any of:
   /usr/local/src/sync (from $GOROOT)
   /Users/voxsim/gopath/src/sync (from $GOPATH)
cmd/dist/test.go:21:2: cannot find package "time" in any of:
   /usr/local/src/time (from $GOROOT)
   /Users/voxsim/gopath/src/time (from $GOPATH)

I setted the GOPATH to the project:
export GOPATH=~/Projects/go
./all.bash

second result:
cmd/dist
import cycle not allowed
package cmd/dist
   imports bytes
   imports errors
   imports runtime
   imports runtime/internal/atomic
   imports unsafe
   imports runtime

Did i do something wrong?
What did you expect to see?
All.bash that builds go.
What did you see instead?
See above.
Thanks,
voxsim

Please ask questions on https://golang.org/wiki/Questions .  Thanks.
Don't set GOROOT in the environment.

Ok @ianlancetaylor, I don't set any GOROOT in my environment, go env show some env variables that I don't set. Btw I will try to look in questions.
thanks,
Simon


error: This video is unavailable.

https://www.youtube.com/shared?ci=eS9FbhOaci4

Please support for the issue.

Maybe I'm wrong, but I think you're getting this error because you are using a share url id and not the actual video id.
See the bit in your url which shows : shared?ci=eS9FbhOaci4
If I manually go to the link and click on the name of the video, it takes me to the native youtube url which is:
https://www.youtube.com/watch?v=nClAiN9MXyc
So try using the video id nClAiN9MXyc and it should work for this video.

yes, you are right man do you have an idea how to deal with this ?

No sorry. I don't know how to translate share urls into canonical urls. Try asking around on StackOverflow. That's a better platform to discuss this imho considering it isn't an issue related to this specific library.

@BharatAgarSoftTech maybe try a regex expression.

Thank you @alankarmisra for handling this issue perfectly.
@SoneeJohn: I don't see how a regular expression could help translating a share URL into a canonical URL.

@0xced apparently, I didn't fully comprehend the issue. I thought it was just an issue of getting the video identifier from the URL (https://www.youtube.com/shared?ci=eS9FbhOaci4). I thought everything after ci was the video identifier.

@SoneeJohn  The video identifier is different in both Urls.
Original video URL : https://www.youtube.com/watch?v=nClAiN9MXyc
Shared video URL :  https://www.youtube.com/shared?ci=eS9FbhOaci4

Hi Team, Can we expect any support for share url in this library?


Add missing implicit annotations.

There are very many implicit arguments in shapeless without @implicitNotFound annotations. Adding them would make compiler errors more readable.

What would be a good template for the error messages? I'm thinking something like this:

Implicit not found: TypeClass[A, B, C].
Could not prove / compute / infer whatever type lever operation with A, B and C.

Then the question is whether to keep it short (a 2-lliner) or try to elaborate possible causes / solutions e.g: "Try to use the Aux pattern", "Make sure your Poly has the right arity", etc.

I think the messages should be specific to the particular type class in question ... I'm not sure that replacing the existing default message with a similarly non-specific template would be all that much of an improvement.


Display CPT label in title instead of default

Given a CPT "Pets"
Instead of "Archives: Pets", show "Pets"

How to test
the usual install
git clone git@github.com:roots/sage.git && cd sage
composer require roots/acorn
composer install
yarn && yarn build
wp theme activate sage

add ui for post types
wp plugin install --activate custom-post-type-ui
add pet cpt

add a dog and a cat
navigate to archive
example:
http://wp.localhost/pet/

Take a look at using the get_the_archive_title filter instead