create.py fails for .TS video files.

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Manifest creation script fails for videos (.ts files).
Expected Behaviour
Manifest creation script should run without error.
Current Behaviour
utils/dataset_manifest/create.py fails with 'NoneType' object cannot be interpreted as an integer on video files.
Possible Solution
Change [https://github.com/openvinotoolkit/cvat/blob/develop/utils/dataset_manifest/core.py#L490](dataset_manifest/core.py line 490)
from if not len(self._reader): to if not self._reader.__len__():
Steps to Reproduce (for bugs)

Grab any .ts video file and try to run create.py

Your Environment

Docker version: 20.10.12
Image: openvino/cvat_server
Operating System: Ubuntu 20.04

Edit:
changing if not len(self._reader): to if not self._reader.__len__(): everywhere in core.py (not just line 490) seems to fix the issue.


Fix ErrorActionPreference not being respected from throw site when reset in finally block

PR Summary
Fixes https://github.com/PowerShell/PowerShell/issues/15726.
When an error is thrown due to $ErrorActionPreference = 'Stop', we now mark it at the first opportunity to prevent having the action preference re-interpreted at a later stage (so that a finally block changing the value won't cause the error to be quietly downgraded).
Labelled as a breaking change because the existing behaviour is observable, but I think is a bucket-3 corner case behaviour that users would experience as a bug. Of note is that ordinary errors written with the WriteError() API will exhibit the correct behaviour, and this change just ensures that all other errors behave the same way.
PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[ ] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

So looking through the behaviour here, it looks like something deeper is still happening in an unexpected way. Compare:
> get-process -banana; write-host 'hello'
Get-Process: A parameter cannot be found that matches parameter name 'banana'.
hello

> try { get-process -banana; write-host 'hello' } catch { }
# No output here

Going to mark this for Working Group review again


refactor: 💡 update how configurations are created

Created the Configurable abstract class since it seems there is some repeat code when it comes to defining configuration

TODO in a followup --
remove the getFullConfig method from the root class and figure out how not to pass a mutable config to everything (I tried having getFullConfig return a shallow copy of this.config but everything broke)
Right now everything in the root Orchestration config is mutable, and is being changed in tests and other plugins, which we probably do not want

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@qhanam @adebayor123
Can you review this?

Looks longer than what it is...
a lot of it was replacing things like PartialConfigN with Partial<ConfigN>

@qhanam I rebased and responded to all comments

ping @qhanam


Running deterministic from Flash

Just saw your awesome talk on 33C3. There you claim running from Flash isn't clock cycle deterministic, because there's a prefetcher and one would never know when this kicks in.
When implementing an interruptible delay loop for Teacup Firmware I ran into a similar problem. Depending on where the compiler placed the code, the loop would take a longer or shorter execution time. The solution I found is to align code to a 16 byte boundary. This removes the prefetcher from the picture or at least makes it deterministic. Gcc/binutils even features an instruction to enforce such alignment, .balign.
The implementation taking advantage of .balign can be found here: https://github.com/Traumflug/Teacup_Firmware/blob/master/delay-arm.c

Hi!  Thank you for your comment.
My experiences with "non-deterministic flash" consisted of the MCU spending a variable number of cycles in the main loop -- anywhere from 24 to 28 cycles per loop.  That is, I managed to eliminate four instructions, and it would work sometimes but not others.
I suspect it has to do with bit stuffing, where the codepath is not constant, and instead depends on the data streams.


Treat quoted empty string as an empty string

In #566 , I forgot that when cargo semver-checks is not invoked via a shell (as in, say, cargo-semver-checks-action), it is our job to treat empty quoted strings like empty strings.

Interesting, I missed this as well. Would you mind adding a test case that exercises this new code path? Otherwise, I worry that we might miss it again in the future and break it without noticing.

I modified the unit test that I added last time to test both configurations.

Queued up a release with this in #572. Thanks!


Throw this error when use is only a function

./~/css-loader!./~/stylus-loader!./src/xxxx/index.styl
Module build failed: TypeError: use.forEach is not a function
    at Object.module.exports (F:\xxxx\node_modules\stylus-loader\index.js:117:7)
 @ ./src/xxxx/index.styl 4:14-124 13:2-17:4 14:20-130

happen on
  //...
  stylus: {
    include: paths,
    use: function(render) { //... }
  }

Thanks for the change @yuffiy. I think its a fair assumption other users will make and them not running into that error will be nice.


S139 alias

Addresses #792

The additional alias is fine.
But I would have left lines 14-15 that you deleted. (In particular because it makes clear that we mean a wedge sum of countably many things, versus a (wedge sum of things) where the whole thing happens to be countable.)  We could even add to that sentence something like See {{wikipedia:Wedge_sum}}.

It's fine with me; I left it out as it felt redundant with the canonical name we're using, but it at least does no harm if you think it's best left in the description as well.


Only use one version of mysten-infra and tonic-build

This enables the cargo vendor command to work properly.
Changes

Added the following to Cargo.toml:

[patch.crates-io]
tonic-build = { git = "https://github.com/hyperium/tonic.git", rev = "de2e4ac077c076736dc451f3415ea7da1a61a560" }

Updated to mysten-infra 9deac015fbf66e24b6da9699630e06750eaa094a.

This should be obsolete by now.


libvirt: 6.6.0 -> 6.8.0

Motivation for this change
This PR carries forward #103309 with the same motivation (fixes a bug in libvirt that causes it to fail to start on non-btrfs setups).
Extra notes
There's a few odd things about this package still. The meson build patch is pretty intrusive, but I'm overall okay with that one I think.
The fact that it uses /var/lib instead of /etc for sysconfdir is also a little abnormal. The reason I'm leaving it like that is because the nixos module expects it, and I think it may be better to update the module separately from this meson-build-system change.
I've only done minimal testing of this, specifically the following:

ran libvirtd using the nixos module + this package
Used 'virt-manager' to run a nixos-minimal ISO, and verify it booted with the default nat networking

Of course, that's still better than 6.6.0 for me since 6.6.0 couldn't even get to the point of creating a disk image due to a bug, let alone booting something.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test podman

@GrahamcOfBorg test podman

failures are broken on master
https://github.com/NixOS/nixpkgs/pull/109332

1 package failed to build:
libvmi

30 packages built:
collectd collectd-data docker-machine-kvm docker-machine-kvm2 gnome3.gnome-boxes haskellPackages.libvirt-hs libguestfs libvirt libvirt-glib minikube minishift perl530Packages.SysVirt perl532Packages.SysVirt python37Packages.guestfs python37Packages.libvirt python38Packages.guestfs python38Packages.libvirt python39Packages.guestfs python39Packages.libvirt rubyPackages.ruby-libvirt rubyPackages_2_5.ruby-libvirt rubyPackages_2_7.ruby-libvirt terraform-full terraform-providers.libvirt vagrant virt-manager virt-manager-qt virt-top virt-viewer virtlyst

failures are broken on master
https://github.com/NixOS/nixpkgs/pull/109332

1 package failed to build:
libvmi

30 packages built:
collectd collectd-data docker-machine-kvm docker-machine-kvm2 gnome3.gnome-boxes haskellPackages.libvirt-hs libguestfs libvirt libvirt-glib minikube minishift perl530Packages.SysVirt perl532Packages.SysVirt python37Packages.guestfs python37Packages.libvirt python38Packages.guestfs python38Packages.libvirt python39Packages.guestfs python39Packages.libvirt rubyPackages.ruby-libvirt rubyPackages_2_5.ruby-libvirt rubyPackages_2_7.ruby-libvirt terraform-full terraform-providers.libvirt vagrant virt-manager virt-manager-qt virt-top virt-viewer virtlyst

I think the libvirtd firewall rules are broken after this change.  My VMs cannot access Internet.  iptables is replaced with iptables-nftables-compat in this patch, so libvirtd firewall rules are automatically converted into nftables rules.    My VMs cannot access Internet.  iptables is replaced with iptables-nftables-compat in this patch, so libvirtd firewall rules are automatically converted into nftables rules.   I've reverted that bit over here: #109722
Can you check if that PR fixes the networking issue you're running into so we can make sure that it's due to that change, and not some other change in libvirt 6.8.0?

Hey @pmeiyu thanks for the heads up it caused an issue. I've reverted that bit over here: #109722
Can you check if that PR fixes the networking issue you're running into so we can make sure that it's due to that change, and not some other change in libvirt 6.8.0?

Hi @euank, Look at the comment in nftables ruleset:
	chain LIBVIRT_PRT {
		ip saddr <IP_ADDRESS>/24 ip daddr <IP_ADDRESS>/24 counter packets 3 bytes 186 return
		ip saddr <IP_ADDRESS>/24 ip daddr <IP_ADDRESS> counter packets 0 bytes 0 return
		meta l4proto tcp ip saddr <IP_ADDRESS>/24 ip daddr != <IP_ADDRESS>/24 counter packets 0 bytes 0 # xt_MASQUERADE
		meta l4proto udp ip saddr <IP_ADDRESS>/24 ip daddr != <IP_ADDRESS>/24 counter packets 2 bytes 390 # xt_MASQUERADE
		ip saddr <IP_ADDRESS>/24 ip daddr != <IP_ADDRESS>/24 counter packets 0 bytes 0 # xt_MASQUERADE
	}

# xt_MASQUERADE is commented out, so it's not a real nftables command.  After searching online, I find out setting nftables package's withXtables to true should solve some problem.  But I don't know if it will make libvirt work well.

Hi @euank, Look at the comment in nftables ruleset:
	chain LIBVIRT_PRT {
		ip saddr <IP_ADDRESS>/24 ip daddr <IP_ADDRESS>/24 counter packets 3 bytes 186 return
		ip saddr <IP_ADDRESS>/24 ip daddr <IP_ADDRESS> counter packets 0 bytes 0 return
		meta l4proto tcp ip saddr <IP_ADDRESS>/24 ip daddr != <IP_ADDRESS>/24 counter packets 0 bytes 0 # xt_MASQUERADE
		meta l4proto udp ip saddr <IP_ADDRESS>/24 ip daddr != <IP_ADDRESS>/24 counter packets 2 bytes 390 # xt_MASQUERADE
		ip saddr <IP_ADDRESS>/24 ip daddr != <IP_ADDRESS>/24 counter packets 0 bytes 0 # xt_MASQUERADE
	}

# xt_MASQUERADE is commented out, so it's not a real nftables command.  After searching online, I find out setting nftables package's withXtables to true should solve some problem.  But I don't know if it will make libvirt work well.

I override nftables package's withXtables to true. Now the output of sudo nft list ruleset is normal.
And I find out VM's internet connection problem is caused by conflicts between iptables and nftables. iptables DROPs forwarded packets and it can override nftables rules.   Now the output of sudo nft list ruleset is normal.
And I find out VM's internet connection problem is caused by conflicts between iptables and nftables. iptables DROPs forwarded packets and it can override nftables rules.    It conflicts with nftables, so nftables is not working well.
According to 1, mixing iptables and nftables is problematic.  The default firewall in NixOS is still iptables so I think other people will also be affected by problem.  We should either warn people about the problem or revert back to iptables for now.

My iptables' forward policy is DROP.  It conflicts with nftables, so nftables is not working well.
According to 1, mixing iptables and nftables is problematic.  The default firewall in NixOS is still iptables so I think other people will also be affected by problem.  We should either warn people about the problem or revert back to iptables for now.


Test verifying there are no unmigrated model changes

This PR is related to #1098 and adds the test as discussed with @aaronweaver.
Testing explicitly if migrations apply cleanly is not required, as the Django test runner applies them automatically before running the tests and hence would reveal problems itself.

I'm running this now on travis to see if it works as intended, afterwards i'll revert the commit which added the Product_Type.someweirdfield field again.

@aaronweaver  Ok, ready for review now.
The travis build is going to fail, but that's because the hash_code field was changed some time ago and has no migration yet. This just shows the test is working.

Thanks @efficiosoft this is a much needed test. I've added the hash_code migration as well.

Thanks @efficiosoft this is a much needed test. I've added the hash_code migration as well.

You're welcome. Thanks as well.


ERROR in ...app.bundle.js from UglifyJs - Unexpected token: punc ())

Do you want to request a feature, report a bug or ask a question?
Question/potential bug?
What is the current behavior?
Getting a build error on production mode during the build on CircleCI, this does not happen when I run the same task on MacOS, from what I can see they're using a node:10.15 docker container, it returns as follows:
ERROR in resources/javascript/app.bundle.js from UglifyJs
Unexpected token: punc ()) [./node_modules/svg-sprite-loader/lib/loader.js??ref--7-0!./node_modules/svgo-loader??ref--7-1!./frontend/svg-sprites/base-triangle.svg:7,6][resources/javascript/app.bundle.js:577,6]

It is as if UglifyJs is trying to parse my SVG files even though it specifically is not set to do that in my webpack common file (shown further down).
What is the expected behavior?
No build errors
If the current behavior is a bug, please provide the steps to reproduce, at least part of webpack config with loader configuration and piece of your code.
I know you want a test repo, though I cannot actually reproduce this locally, I can of course set one up if nothing comes to mind though I am not sure if my test repo will even break in this scenario...
The best way is to create repo with minimal setup to demonstrate a problem (package.json, webpack config and your code).
It you don't want to create a repository - create a gist with multiple files
Please tell us about your environment:

Node.js version: ? 10.15
webpack version: ? 4.28.3
svg-sprite-loader version: 4.13
OS type & version: MacOS Mojave 10.14.2

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
In my app entry point I have:
const svgFiles = require.context('../svg-sprites', false, /\.svg$/);
svgFiles.keys().forEach(svgFiles);

in the webpack config:
/*
      * SVG Sprite
      */
      {
        test: /\.svg$/,
        include: path.resolve('./frontend/svg-sprites'),
        use: [
          {
            loader: 'svg-sprite-loader',
            options: {
              extract: true,
              spriteFilename: '../templates/_sprites/sprite.svg',
              symbolId: 'sprite-[name]',
            },
          },
          {
            loader: 'svgo-loader',
            options: svgoOptions,
          },
        ],
      },

I appreciate you may not want to fix this if you are working on the newer svg extraction tool though if anything comes to mind I would be very grateful.
Thanks for your hard work.

I have the same issue

A bit late to testing this, but, it looks like esModule:false worked!


Feature request: Additional sorting functions

I would like to suggest some new features for the sorter:

[ ] add an option to put the extended class + interfaces at the top (or top of the group)
[ ] create a special group name _annotations which groups annotations (is that possible with the current implementation/in general?)
[x] allow to combine groups like:

use-sort:
    group:
        - Symfony
        - _main
        - App
        - ['Sensio\Bundle\FrameworkExtraBundle\Configuration', 'JMS\DiExtraBundle\Annotation']
    group-type: each
    sort-type: alph
    sort-direction: asc

[x] and ideally allow additional sorting within a group (like Symfony HttpKernel before Symfony Form e.g.)

Wdyt @mmoreram ?

@mmoreram What do you think of 1. and 2.?

Closing as 1. and 2. would require parsing the php code which isn’t part of the tool yet and I think makes everything too complicated.


feat: upgrade add command behavior

Add the possibility of providing inline details when creating a  task.
The details prompt is still available when providing the "-" character as details.
The idea behind this pull request is to mimic the behaviour of git-commit -F command.
Example:
hyf add "Task name" -d "details"
# equivalent to
hyf add "Task name" -d -
>>> ? Task details: details

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.918%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1212

Relevant Lines:
1213

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.918%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1212

Relevant Lines:
1213

💛  - Coveralls

I have tried to have the prompt keep taking inputs while the EOF (Ctrl+D) signal has not been received.
This is the behavior I wanted, and with it, it would make sense to keep the prompt option in my opinion. It would allow details content with several lines.
Unfortunately, click filters this EOF exception and interprets it as an abort. So it would make a heavier change to implement this.
If you don't think it's worth implementing it, I would agree to remove the prompt option.
What do you think ?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.918%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1212

Relevant Lines:
1213

💛  - Coveralls

Sorry, I didn't mean to go so far in the conception. IMO the inline vs prompt are pretty much the same, the only difference is the use of quotes. It's why I was wondering of the utility to keep both versions. But I agree, I like the possibility to write details content with multiple lines (maybe with the edit function from click) and as it is, it would be a good base to allow this improvement.
I'll validate the PR! Thank you again for your contribution!


Remix Test

The issue with tests randomly failing in CI/CD was related Remix tests, there were some logic waiting for a fetch of a spin up of a Remix server in a spawn (ChildProcess).

Refactored the waitUntilReady with Promise and setTimeout resolving fetch.
Added a Promise flush since the function is used in a unique environment that is bleeding into Parent or Child process.
Additionally added a cleanup of the child process at the end of the tests, should make sure port 8789 is opened back up.

Well... that's 30 seconds. Back to the drawing board.

Well... that's 30 seconds. Back to the drawing board.
Could be the async nature of spawn that is at the root of this problem. I am also open to other theories or if anyone just knows the cause.

Closed due to #670


OperationStatusResult.Error has inconsistent definitions

tsp: https://github.com/Azure/typespec-azure/blob/main/packages/typespec-azure-resource-manager/lib/common-types/types.tsp#L232

Repro steps?


item stored in secure storage is returning null after a period of time

Probably not a bug or a true issue, but may need help to understand:
I'm storing in my app a token using secure_storage.
From cycles of 2 hours after the last time the app was open/run when we read the key associated with the token, it returns null.
how could I prevent this from happening?

Conflicting implementation causing memory to be flushed

Hey @GusRodrigues86 you closed this without further explanation, did you found what the problem is? I have this problem also, and is being hard to find the cause of it

Hey @GusRodrigues86 you closed this without further explanation, did you found what the problem is? I have this problem also, and is being hard to find the cause of it

@TMSantos, ensure that you are calling the readAll() on initialization of your app.
Future<void> main() async {
  // Allow device information capturing
  WidgetsFlutterBinding.ensureInitialized();
  await SecureStorage().init();

and the init() is
await _storage.readAll();

just remember to follow some good practices of what and what you are storing as a DS for later use after reading from secure store.

@TMSantos, ensure that you are calling the readAll() on initialization of your app.
Future<void> main() async {
  // Allow device information capturing
  WidgetsFlutterBinding.ensureInitialized();
  await SecureStorage().init();

and the init() is
await _storage.readAll();

just remember to follow some good practices of what and what you are storing as a DS for later use after reading from secure store.

@GusRodrigues86 thanks for your reply, do you know the reason behind that? it doesn't sound that readAll and read is that much different in the native methods

@GusRodrigues86 thanks for your reply, do you know the reason behind that? it doesn't sound that readAll and read is that much different in the native methods

My understanding is that without a initial readAll, you secure storage will never look into the keychain/keystore for values at all. So the initial condition for the reference is always {}.
but you need this call once the app is initialized. if you put on main, it will always work

My understanding is that without a initial readAll, you secure storage will never look into the keychain/keystore for values at all. So the initial condition for the reference is always {}.
but you need this call once the app is initialized. if you put on main, it will always work

@GusRodrigues86 Did adding the await _storage.readAll(); line fix the issue for you? We are having the same issue on both platforms. Using 3.3.5.

@GusRodrigues86 Did adding the await _storage.readAll(); line fix the issue for you? We are having the same issue on both platforms. Using 3.3.5.

@GusRodrigues86 Did adding the await _storage.readAll(); line fix the issue for you? We are having the same issue on both platforms. Using 3.3.5.

Yes. After getting the instance, readAll(), then check if it contains the desired key

@GusRodrigues86 Did adding the await _storage.readAll(); line fix the issue for you? We are having the same issue on both platforms. Using 3.3.5.

Yes. After getting the instance, readAll(), then check if it contains the desired key

I'm still have this problem. after a period of time (for me, like next day), open the app and data will be null. and after restart the app. the data can read. i need to open the app twice at first time of the day, every day.
Don't know how to fix. already add await _storage.readAll(); in main()

I'm still have this problem. after a period of time (for me, like next day), open the app and data will be null. and after restart the app. the data can read. i need to open the app twice at first time of the day, every day.
Don't know how to fix. already add await _storage.readAll(); in main()

Fixed by this https://github.com/mogol/flutter_secure_storage/issues/245


acquire exclusive lock on spaces, areas, iterations and work_item_number_sequences table to avoid deadlock during migration

In order to avoid the following deadlock situation, the 106 migration now acquires an exclusive lock on the spaces, iterations, areas and work_item_number_sequences tables.
Legend:

relation 36029 = spaces
relation 36042 = iterations

2018-09-26 07:55:25 UTC:<IP_ADDRESS>(37984):dbadmin@postgres:[875]:ERROR:  deadlock detected
2018-09-26 07:55:25 UTC:<IP_ADDRESS>(37984):dbadmin@postgres:[875]:DETAIL:  Process 875 waits for AccessExclusiveLock on relation 36029 of database 13322; blocked by process 5634.
    Process 5634 waits for AccessShareLock on relation 36042 of database 13322; blocked by process 875.
    Process 875: -- Create the number sequences table
    CREATE TABLE number_sequences (
        space_id uuid REFERENCES spaces(id) ON DELETE CASCADE,
        table_name text CHECK (trim(table_name::text) <> ''),
        current_val INTEGER NOT NULL,
        PRIMARY KEY (space_id, table_name)
    );

    -- Update existing iterations and areas with new "number" column and fill in the
    -- numbers in the order iterations and areas have been created.

It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin.

/ok-without-tests


Refs 2425: trim error on update

Summary
When setting a limit on the error field, trim existing contents.
Testing steps
tests pass

https://issues.redhat.com/browse/HMS-2425

⚠ This task currently requires qe-approval, but this PR does not fully resolve the task.  Please contact QE to determine appropriate testing required.

this isn't a qe visible change other than stage being up! merging


missing 'throws' section

throws AmbiguoudMatchException, and I guess NRE too if name is null

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 82f5859f-bf16-d3dd-5844-0ff0ac944ab2
Version Independent ID: 8facbdf6-d0d2-b504-eb38-a0fb9d6a3c5a
Content: RuntimeReflectionExtensions.GetRuntimeProperty(Type, String) Method (System.Reflection)
Content Source: xml/System.Reflection/RuntimeReflectionExtensions.xml
Product: dotnet-api
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Thanks for pointing out the missing exception information, @StephaneDelcroix. In looking at the source, it appears that the method throws:

An ArgumentNullException if t is null.
An ArgumentException if t is not a RuntimeType.
An AmbiguousMatchException, if more than one property named name is found.
We've added this issue to our backlog and will address it in an upcoming sprint. In the meantime, if you'd like to submit a PR to add the missing exception information, we'd welcome your contribution.

@rpetrusha thanks. don't forget to review the other ones in RuntimeReflectionExtensions while you're at it.


String being parsed where it shouldn't

While using external libraries with JS, like jQuery and Handlebars, I realized that somethings don't work as expected, possibly by an error on parser.
Imagine the following situation:
template = Handlebars.compile($ "#group-template" .html!)

What would you expect to be your output? Probably:
template = Handlebars.compile($("#group-template").html());

But what you get?
template = Handlebars.compile($(groupTemplate + "").html())

This wasn't supposet to happen, as much as "group-template" is a string and nothing else.

I don't understand the confusion, that's how interpolation works.

That's a new language feature, no? I need to re-re-re-read the docs again. :cry:

Interpolation can either use # or '#{'  }

New as in, different from coffeescript? yes.
New as in "new in LS"? It's been here before LS existed, in coco 0.6.0

Solution is to use single quotes when you don't want string interpolation.

On 6.4.2015, at 15.32, Marcelo Camargo<EMAIL_ADDRESS>wrote:
That's a new language feature, no? I need to re-re-re-read the docs again.
—
Reply to this email directly or view it on GitHub.

or escape the hash "\#foo"

@igl :+1: !

I should make this clear in the docs, but the general style is to always use single quotes unless you want to use interpolation, or you want to use single quotes in your string. Using this guideline avoids most issues.

Commonly, I use single quotes for chars and double quotes for lists of chars, like several programming languages do. A good concept to think about is string-interpolation, as much as it might cause problems in bad-designed languages, such as PHP. Swift has a nice way to work with interpolations.


Replace difference with another crate

Issue summary

Task summary

Part of this issue  https://github.com/ChainSafe/forest/issues/2252
Acceptance Criteria

Other information and links

Could you elaborate a bit on this issue?

As found out in https://github.com/ChainSafe/forest/issues/2252 difference is not maintained, there we have to replace it


Fix broken links, misspellings, and minor formatting

Was looking through the repo and noticed some broken links and misspellings, so thought I might be able to help! Let me know if there is anything you'd like me to change.

If you like the changes, I can try to update the wiki to match it too.


Not working on iPhone 6

I used Cydia impactor to get the ipa working on my iphone 6. I have ios version 12.0.1 and A8 CPU. When I go to install, the button says "unsupported". I will supply diagnostics in a bit.

I have an iphone 6 running 12.1, same issue;  shows up as "Unsupported".
diagnostics Plist file link for my phone can be found here: https://mega.nz/#!1LQBWApb!Tj5fo4Y2Z7KzfNOp1pZkxjZh2DJDmBA5rm9y8DoN3jU

As of right now only A8X-A11 are supported.  but they are working on support for the others

Does anyone have any clue when support for A8 processors will be implemented?


Bug report: Configurable Tab has no context in Config page

Description
I've setup a simple tab (in short: nearly everything set to No)
When I directly start this via ngrok
The Config page shows a disabled "Save"
Quickly debugging shows that useTeams returns context, inTeams as undefined
Steps to reproduce
setup a simple configurable tab
Start with ngrok directly (no code modification necessary)
Add Tab to a channel
Enter config page
Detect disabled "Save" button
Expected results
"Save" button should be enabled
In fact the hook on "context" should be successfully enter if (context) {...}
Actual results
if (context) {...} is not entered cause of undefined only
"Save" stays disabled
Project you experience issues with
generator-teams
generator version
4.0.0
build tools version
1.7.0
nodejs version
v14.17.5
npm version
6.14.14
Operating system (environment)
Windows
Additional Info
No response

Thanks for reporting this Markus, we'll look into it.
If you like you can also do a PR to fix it as contributions are more than welcome 😊

Hi @stephanbisser,
I am already trying but currently quite limited due to health issues...
And never handled a tool "inside" like this ...
I was extracting the useTeams.ts from Wictor's repo and directly inserting in my project for better debugging and it turns out that this function does not detect the microsoftTeams lib for whatever reasons (I am not yet behind the scenes...)
const isTeamsLibraryLoaded = (): boolean => {
// eslint-disable-next-line dot-notation
const microsoftTeamsLib = window["microsoftTeams"];
if (!microsoftTeamsLib) {
    return false; // the Microsoft Teams library is for some reason not loaded
}
return true;

};

@mmsharepoint - sometimes things goes sideways when you're merging, and you rely on unit testing...that check should no longer be there in that library. An updated version of msteams-react-base-component will be out in an hour or so...

@mmsharepoint - there's a new version in town, or actually two. The<EMAIL_ADDRESS>fixes the issue with the missing context and<EMAIL_ADDRESS>contains a small update to the tab config dialog page that fixes the success notification (another missed merge issue). You can easily fix your existing project by scaffolding out a new empty test project and copy paste the save function.
Thanks for reporting and keep on whacking out great Teams apps!

Thanks @wictorwilen  for the immediate fix now.
Configuration works like a charm now.
Still facing issues in my more complex sample after that while rendering the tab which seem to show quite similar effect.
But let me dive deeper into into it before coming back with the issue or fix report.


Unable to find type [System.Switch] and multiple URLs

The Save-LatestUpdate function uses the -ForceWebRequest switch, but it's incorrectly defined.

The correct usage would be [System.Management.Automation.SwitchParameter] or simply [Switch] :)

Next to the switch, I found out that Microsoft thinks it's funny to add multiple URLs in an update:

In the PR I've put the downloading part into a foreach which will make the function download every single url.

OS: [Windows 10]
PowerShell version [5.1]

Have pushed 3.0.119 to fix this


Use main, not master

This makes it clear that we use main, not master, for the default
branch name.
This is open as a draft while I seek feedback on ways to make the migration easier.

It's very specific to GOV.UK, but we've created some documentation to help with the transition https://docs.publishing.service.gov.uk/manual/howto-switch-default-branch.html that could be a helpful template or resource?


Unable to open user interface preferences

Fresh Eclipse 2022-06 (4.24.0) installation
DBeaver feature <IP_ADDRESS>206261508
openjdk version "17.0.3" 2022-04-19 (bundled with Eclipse)
Linux Mint 20.3 x86_64

All org.jkiss settings were removed from ${WORKSPACE}/.metadata/.plugins/ folder prior DBeaver installation.
Attempt to navigate to Preferences -> Database -> User Interface (or any settings below) results in The currently displayed page contains invalid values error message. The NPE is logged to the workspace ${WORKSPACE}/.metadata/.log:
!ENTRY org.eclipse.jface 4 2 2022-07-07 13:12:48.436
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.jface".
!STACK 0
java.lang.NullPointerException: Cannot invoke "org.eclipse.swt.widgets.Combo.setText(String)" because "this.clientTimezone" is null
        at org.jkiss.dbeaver.ui.preferences.PrefPageDatabaseUserInterface.performDefaults(PrefPageDatabaseUserInterface.java:197)
        at org.jkiss.dbeaver.ui.preferences.PrefPageDatabaseUserInterface.createPreferenceContent(PrefPageDatabaseUserInterface.java:179)
        at org.jkiss.dbeaver.ui.preferences.AbstractPrefPage.createContents(AbstractPrefPage.java:32)
        at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:244)
        at org.eclipse.jface.preference.PreferenceDialog.createPageControl(PreferenceDialog.java:1433)
        at org.eclipse.jface.preference.PreferenceDialog$8.run(PreferenceDialog.java:1196)
        at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)
        at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:174)
        at org.eclipse.jface.preference.PreferenceDialog.showPage(PreferenceDialog.java:1188)

Connected to https://github.com/dbeaver/dbeaver/issues/16912

This bug has reappeared under Eclipse 2023-06 but only for the settings under Preferences -> Database -> User Interface. Expanding the User Interface tree first allows for access to the other sections under it. Any attempt to navigate away from the User Interface section is met with the same error message as originally posted
Issue needs to be reopened.

@MerlinYoda thank you for letting us know. Please create a new issue.

Issue #20902 opened as a new issue for this error.


cholerically, bucculae

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[b,c]

/trunk merge


Compute decision tree improvement

Hello,
I think we can have an improvement on the flow chart.
On the left after Lift and shift -> Can it be containerized, if you choose yes you go immediately to Need full-fleged orchestration?.
I think it's still an option to go for App services or Container instances.
Suggestion. If we reverse the order of Azure App Service and Azure functions the yes from Can it be containerized? could go to the decision Microservice architecture?
Like the following edited flow diagram:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 510808e8-db5d-6b07-9a04-6edb743a2dfc
Version Independent ID: 20d098aa-ef31-cb26-d677-765cfc9a7164
Content: Choose an Azure compute service - Azure Architecture Center
Content Source: docs/guide/technology-choices/compute-decision-tree.yml
Service: architecture-center
Sub-service: azure-guide
GitHub Login: @EdPrice-MSFT
Microsoft Alias: edprice

Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

The diagram has changed since your suggestion was made.  If you are still experiencing issues, please re-open with additional information.


BigchainDB support for Django

bigchaindb-driver version:
Python version: 3.6
Operating System: Ubuntu 16.04

Description
Is it possible to link bigchain-DB to various python backends, such as django or flask? Since it is built on top of mongoDB I thought it may be possible, but I had some trouble figuring this out. Please let me know if there is a solution in the docs about this

We do not have a specific streamlined way to do this right now, but you can definitely use the Python driverr from your django project to connect and interact with a BigchainDB cluster. The docs for the Python driver are are at https://bigchaindb.readthedocs.io/projects/py-driver/, whereas the docs for the server are at https://bigchaindb.readthedocs.io/en/latest/index.html
We can provide you with much more guidance on that matter if you need. Rather than flooding you with information I'll wait for your questions and will do my best to help you.

I'd like to see if a couple starting points make sense: (1) Within a project, create an django app with models having methods that can make CRAB calls to BigchainDB cluster via the driver - in short a wrapper. I'm making the assumption that the db specified in django settings (e.g. postgres) is not used (even though it could be) to store asset or transaction-based info; that's all stored in the BigChainDB cluster.  (2) Create a django model that is used to represent the asset (or a python dictionary [json or xml object from an api call] can suffice at a minimum). However, the asset(s) and transactions related to the same all reside in BigchainDB; Django's primary function is simply a well-defined framework (a) to define/create assets through it's interface, (b) to perform operations on attributes of assets within the app outside of official BigChainDB transactions (e.g., advanced analytics, ML), (b) facilitate usual interactions within views and UI displays within Dango templates, and (c) allow permissioned or permissionless api calls from 3rd parties to leverage the Django + BigchainDB capabilities using django rest framework.  Let me know if my thinking is off or if I have some blind spots on a general strategy,  I am relatively new to this and have been thinking about BigChainDB for the AI work that I do but I wanna make sure this is a reasonable approach.

As of BigchainDB 2.0, every BigchainDB node has its own independent, local MongoDB database. The node operator can choose how to expose the information to external applications. It's totally possible that they could use Django to create a web app for querying their node's MongoDB database, or they could let some external partner do that (by giving them, and only them, the necessary MongoDB auth credentials).
There are many tools to use MongoDB with Django. Google can help you find them.

I'm familiar with the Django MongoDB engine and am pursuing this path.  Thanks, Trent!

Troy


update version of cwltool we test with / use in docs

Feature Request
Desired behaviour
Update cwltool, may want to check-in with https://gitter.im/common-workflow-language/common-workflow-language to see if they recommend a particularly stable recent version
Note that this may affect docs and https://dockstore.org/api/metadata/runner_dependencies?client_version=1.8.0&python_version=3
┆Issue is synchronized with this Jira Story
┆Fix Versions: Dockstore 2.X
┆Issue Number: DOCK-1189
┆Sprint: Sprint 46- Unicorn Fish
┆Issue Type: Story

Pasting my comments from SEAB-1499 since this appears to be the relevant ticket:
Upgrades for Python 3.8

The following versions were tested on the latest default Ubuntu 20.04 Python (3.8.2) with remaining Python packages in requirements.txt unchanged:
Minimal upgrades:
ruamel.yaml should be bumped to 0.15.100 (last 0.15.x release) https://pypi.org/project/ruamel.yaml/.
cwltool must be bumped to at least 1.0.20191022103248 (or last 1.0.x release 1.0.20191225192155) for Python 3.8 & higher ruamel.yaml support.
schema_salad should be bumped to 4.5.20191204060541 (latest release) for Python 3.8 & higher ruamel.yaml support

Maximal upgrades:
We can upgrade all python packages except for ruamel.yaml to their latest versions without any code changes on our end.
Newer versions of ruamel.yaml break for dockstore-cli integration tests due to:
[INFO] Running io.dockstore.client.cli.LaunchTestIT
Starting test: cwlMissingIdParameters
problems running command: cwltool --non-strict --validate /home/ghogue/repos/dockstore-cli/dockstore-client/target/test-classes/missingIdParameters.cwl
stderr for command:
        INFO /home/ghogue/miniconda/envs/seab1499/bin/cwltool 3.0.20200724003302
        INFO Resolved '/home/ghogue/repos/dockstore-cli/dockstore-client/target/test-classes/missingIdParameters.cwl' to 'file:///home/ghogue/repos/dockstore-cli/dockstore-client/target/testclasses/missingIdParameters.cwl'
        ERROR Tool definition failed validation:
        target/test-classes/missingIdParameters.cwl:10:5: while parsing a block collection
        target/test-classes/missingIdParameters.cwl:11:5:   expected <block end>, but found '?'

ruamel.yaml breaks for dockstore integration tests starting at version 0.15.91 where we get the following error (explained in https://stackoverflow.com/questions/55540686/configuring-ruamel-yaml-to-allow-duplicate-keys)
[INFO] Running io.dockstore.client.cli.GA4GHV2BetaIT
INFO /home/ghogue/miniconda/envs/seab1499/bin/cwl-runner 3.0.20200724003302
ERROR I'm sorry, I couldn't load this CWL file, try again with --debug for more information.
The error was: while constructing a mapping
  in "http://localhost:8080/api/ga4gh/v2/tools/%23workflow%2Fgithub.com%2Fgaryluu%2FtestWorkflow/versions/master/plain-CWL/descriptor/cwl/arguments.cwl", line 1, column 1
found duplicate key "baseCommand" with value "javac" (original value: "javac")
  in "http://localhost:8080/api/ga4gh/v2/tools/%23workflow%2Fgithub.com%2Fgaryluu%2FtestWorkflow/versions/master/plain-CWL/descriptor/cwl/arguments.cwl", line 7, column 1
To suppress this check see:
    http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys
Duplicate keys will become an error in future releases, and are errors
by default when using the new API.

To get the latest requirements.txt for whatever ruamel.yaml we end up using, run the following:
pip install cwl_runner==1.0 cwltool==3.0.20200724003302 ruamel.yaml==0.15.90
pip freeze > requirements.txt
bagit==1.7.0
CacheControl==0.11.7
certifi==2020.6.20
chardet==3.0.4
coloredlogs==14.0
cwl-runner==1.0
cwltool==3.0.20200724003302
decorator==4.4.2
humanfriendly==8.2
idna==2.10
isodate==0.6.0
lockfile==0.12.2
lxml==4.5.2
mistune==0.8.4
mypy-extensions==0.4.3
networkx==2.4
prov==1.5.1
psutil==5.7.2
pydot==1.4.1
pyparsing==2.4.7
python-dateutil==2.8.1
rdflib==4.2.2
rdflib-jsonld==0.5.0
requests==2.24.0
ruamel.yaml==0.15.90
schema-salad==7.0.20200612160654
shellescape==3.4.1
six==1.15.0
typing-extensions==<IP_ADDRESS>
urllib3==1.25.10

In general, would prefer the "maximal" upgrade. Upgrading cwltool makes us retest all verified workflows anyway, so we might as well make it a big one. But would defer to asking to cwl community what would be the most recent, stable, recommended release.

Hello! We don't have a concept of a stable release as we are a reference runner. Perhaps toil-cwl-runner would be better to recommend?
Or you could track the cwltool version they depend on.

I would recommend at least version 3.0.20200807132242 of cwltool to get CWL v1.2 compatibility. This is also the version that the latest release of Tool depends on.

to confirm, from context, this is the version that the latest release of cwltool depends on?

@denis-yuen , yes :+1:

https://dockstore.org/api/static/swagger-ui/index.html#/metadata/getRunnerDependencies does return the version mentioned above and following the quickstart CLI instructions does download that cwltool version as well.

https://dockstore.org/api/static/swagger-ui/index.html#/metadata/getRunnerDependencies does return the version mentioned above and following the quickstart CLI instructions does download that cwltool version as well.


New Primary Heat Transfer systems model

In GitLab by @hlux on Dec 12, 2016, 15:31
As provided by Chris Harrington to be implemented in PROCESS. All relevant files are on the K:drive under Power Plant Physics and Technology/Eurofusion Sys 2016/ PHTS Model.

The files are here:   PHTS Model for anyone who doesn't have access to the K drive.


Cannot install buster

I am on Arch (Manjaro) and running sudo pip install buster causes the following.
[yuki@Skarmory-Manjaro ghost]$ sudo pip install buster
[sudo] password for yuki: ------------
Collecting buster
  Using cached buster-0.1.3.tar.gz
Collecting GitPython==0.3.2.RC1 (from buster)
  Using cached GitPython-0.3.2.RC1.tar.gz
Collecting async==0.6.1 (from buster)
  Using cached async-0.6.1.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-vl71r_nq/async/setup.py", line 24
        print "Ignored failure when building extensions, pure python modules will be used instead"
                                                                                ^
    SyntaxError: Missing parentheses in call to 'print'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-vl71r_nq/async/

you need to use python2. trypip2 install buster

Is there any way it can be installed with python3?

I have the same problem. Solution?


Add documentation to the Github repo

Document how to run things etc, make sure people know that they needs all the dependencies listed in import_hedgehogs.py

Updated the README with more concise instructions about how to setup everything and download the dependencies. Also removed the deprecated instructions.


define cli functionality

build files from cli
flip presets
use arithmetics
show help
build configs
parse configs
auto detect configs

Build boilerplates React etc...

Migration informations

lots of community members expressed that we shall keep fuse simple with no CLI, so I think we will close this :)


Wrap custom attributes in a hash

The documentation is inconsistent but this works whereas adding the custom attributes directly to the top-level hash fails, as documented in issue #105.
The documentation for users/bulk doesn't mention custom attributes, but the documentation for "Create or Update User" shows the custom attributes wrapped under the key custom_attributes (here: https://doc.intercom.io/api/#create-or-update-user)

I'm closing this again, because it only worked for me in one scenario – when I tried to do the same thing with my production app, I had to use the official master branch. Not sure what gives. Seems like the API is inconsistent. I suspect that it's relevant whether one first tries to do the bulk import before pushing the integration to the live server and in that way get a couple of page loads with Intercom activated, or if (as I did) one tries to just do the bulk import first. If anyone else is interested in resolving the issue I'd be happy to contribute, but for now I'll just close this.


Make it easy to bump the version and tag the repo

currently tagging is done manually
also versioning of the agent would be nice

the agent version numbers could be synchronized with dalton
perhaps better to keep the agent version different than the dalton version

Nice to show the dalton version on the "about dalton" page if possible

Closing with #212


Link back to Advanced URI link is not clickable/properly formatted

@muness There is an issue with the Advanced URI link that is saved in the Note on the Marvin Task.
This is what it is showing as:
[🏷](obsidian://advanced-uri?filePath=Periodic Notes/Daily Notes/2023-12-27.md&vault=MyVault)

But that is the wrong format for Advanced URI. When I copy the Advanced URI from Obsidian, it's this:
obsidian://advanced-uri?vault=MyVault&filepath=Periodic%2520Notes%252FDaily%2520Notes%252F2023-12-27.md

It also doesn't need the [ ]( ) Markdown. It is only clickable for me if it's just the file link.

Ah, I should url encode the link as it has spaces. I didn't notice as I don't have spaces in filenames.
The markdown link worked for me. I'll check that too or switch to just the link.

@judisohn , can you check that the link works as of https://github.com/cloud-atlas-ai/obsidian-am/releases/tag/0.5.2 ? Thanks!

@muness I have 0.5.2 but no difference in the URL generated from the previous version. Did I miss something?

My apologies, @judisohn  I made a mistake in the 0.5.2 release 🤦  https://github.com/cloud-atlas-ai/obsidian-am/releases/tag/0.5.3 is actually right.

There's no strategy that includes "Markdown." I'd love it. Other Markdown is fine... such as [Page Name](https://...) but somehow for me, it doesn't resolve when it's a file link. I'll grab 0.5.3 now and see if it improves the situation.

It worked! As I thought, when the link was fixed it resolved as Markdown...

But, it would be great if we could edit this... that tiny tag icon is a pain to target with the mouse and I'd prefer something like "Obsidian Link" rather than just an icon. Or frankly, the full link because when in full view, it's much harder to see the full path and you're clicking that little tag on trust alone.
Ugh, but sadly... clicking to mark the task as done is once again not working and failing silently. :-( The only thing I changed between this time and last is that I used BRAT rather than manually downloading the files. It's showing the right 0.5.3 version so not sure if that would make a difference?

Maybe we should make the link configurable.
I'll also double check that my messed up merge didn't mess up mark as done.

No luck reproducing the Mark As Done issue, @judisohn . I have the Tasks Plugin enabled and it's adding the done date on checking them off. Can you start a new issue with any details you have about your setup : which task plugins you're using and how they're configured.

@muness Good news is that with 0.5.4b it's trying to mark the task as done. Bad news is that it won't due to the all-too-familiar status 429 error.

Hopefully we'll hear back about how to best proceed re the 429s soon. I could add a caching layer, but that will likely cause all kinds of unexpected behavior.


[Bug] TGIS container fails to run on a FIPS cluster

When deploying a LLM model using the new Caikit+TGIS architecture introduced with #107 , the TGIS container (i.e., transformer-container) fails to start if the cluster has FIPS cryptography enabled.
These are the 2 errors I got in the container logs
There was a problem when trying to write in your cache folder (/.cache/huggingface/hub). You should set the environment variable TRANSFORMERS_CACHE to a writable directory. fips.c(145): OpenSSL internal error, assertion failed: FATAL FIPS SELFTEST FAILURE
Note: the TRANSFORMERS_CACHE is actually set in the ServinRuntime
This was found on a OpenShift 4.13.18 cluster with RHODS 2.1.2 (aka 1.32.2) and KServe 0.11 installed

What needs to be done (more like notes to self):

Create a FIPS enabled cluster
Check each python library for FIPS as shown here

As another data point, I have hit this issue with FIPS enabled OpenShift 4.13.12 cluster and Red Hat OpenShift Data Science operator 2.5.0
It appears it is the tokenizer Python module that is causing the crash.  From a debug container I see the same issue as noted here  from huggingface.
Unfortunately, I have to redeploy my entire cluster now to make progress since FIPS cannot be disabled after OpenShift is fully deployed and running.

As another data point, I have hit this issue with FIPS enabled OpenShift 4.13.12 cluster and Red Hat OpenShift Data Science operator 2.5.0
It appears it is the tokenizer Python module that is causing the crash. From a debug container I see the same issue as noted here  from huggingface.
Unfortunately, I have to redeploy my entire cluster now to make progress since FIPS cannot be disabled after OpenShift is fully deployed and running.

@bmcfeeters thanks for sharing your case. This issue should be solved on the latest image versions of the runtime which is going to be shipped with operator 2.6.0

Fixed in #171, due to this change, this was due to the way the virtualenv was being prepared in the Dockerfile


fix: Clear input after adding a repository to insight page #2474

Description
I just passed the value prop to Search component
This PR fixes the #2474
What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings
https://github.com/open-sauced/app/assets/106425076/4e1a914c-63c1-49ab-849e-d3f9a35b5e35

Steps to QA

Navigate to insight page -> click New Insight button
Add repo
Now Input field is empty

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

@nickytonline can you please help me here, I am new to this process

Hey @shubhamchasing! Thanks for the PR. Take a look at the directions for how you need to format your PR to get the tests to run.
Another note: You'll need to update your branch with the latest from beta before this can be merged.

Hey @BekahHW
To find this bug  I checked alot of things and I think it occured
after feat: flow for creating a new workspace PR link for  (preview)
in the feat: search suggestions can be JSX or a string now PR link for  (preview)
I also noticed some random behaviour, like I am able to add some repo and some not and it also changes everytime

Hey @BekahHW To find this bug I checked alot of things and I think it occured after feat: flow for creating a new workspace PR, link for (preview) in the feat: search suggestions can be JSX or a string now PR, link for (preview)
I also noticed some random behaviour, like I am able to add some repo and some not and it also changes everytime

Let me take a peek at this @shubhamchasing as the issues you mention are some recent work I did. It's very possible I introduced this issue. 😅

When I try to select from the combobox, it doesn't work on Chrome.
Screen.Recording.2024-01-22.at.10.15.08.AM.mov

This issue was newly introduced which I mentioned earlier in the comment.

And now the issue has been resolved in the #2502 by using currentTarget

const { suggestion } = (event.currentTarget as HTMLElement).dataset;

Screencast from 29-01-24 10:05:21 PM IST.webm

Hey guys @BekahHW @nickytonline @jpmcb, please look into this PR when you have time :)


feat: plugin can have its own RESTful api

Summary
In order to support plugin configuration through API, it's necessary for devlake to allow plugin exposing its own api.
For more detail, check issue #449
Key Points

[x] This is a breaking change
[ ] New or existing documentation is updated

Description
This PR added a Plugin Api mechanism connecting Api Handlers from plugin to Devlake Api Server.
How it work:

Client request to /plugins/:plugin/:*resource will be forwarded to corresponding api handler from plugin
api handler would process the request and return output, error
Devlake Api module would convert the returned result to client

How to verify:

An echo api handler is added to jira plugin which just return posted request body as output
A testing script sending dummy request to that endpoint is added to scripts/pm.sh

Steps to verify:
Note: you may need to install jq for json processing first in order to run pm.sh script.
# fire up database
docker-compose up -d mysql
# compile plugins and fire up devlake
scripts/pm.sh run
# send dummy request to see if request got processed as execpted
scripts/pm.sh jira_echo

Does this close any open issues?
Infrastructure needed for issue #449
Screenshots

@hezyin

Plugin framework doesn't need to do that, because each plugin will have its own API for configuration. A plugin should be able to load its own configuration inside its Execute function.
Like I commented on issue #449, plugin may have arbitrary functions, for example, we discussed a feature in config-ui  that to provide customfield picking function to aid user setup jira with ease, features like that require plugin to be able to expose its own APIs, on the other hand, some plugin may not need configuration at all, like compound plugin and domain entity conversion plugins.


Remove vagrant from tests

Current coverage is 77.96% (diff: 100%)

Merging #493 into master will increase coverage by 0.17%

@@             master       #493   diff @@
==========================================
  Files            25         25
  Lines          2314       2428   +114
  Methods         396        396
  Messages          0          0
  Branches        197        197
==========================================
+ Hits           1800       1893    +93
- Misses          514        535    +21
  Partials          0          0

Powered by Codecov. Last update d06bff7...da78795

test this


[RFC] a11y scrolling, iOS, non-lazy lists

This is WIP, next: making this work for lazy lists.
Engine change (to be cleaned up): https://github.com/goderbauer/engine/tree/ios-scroll

@goderbauer I'm closing this PR since it's not awaiting review and isn't ready for checkin. Hope that's ok.


Improve avg/sum Aggregator performance

Which issue does this PR close?

Closes #5858 #5859.
Rationale for this change
Improve avg(decimal) and sum(decimal) performance, avoid type cast in the inner loop, improve the TPCH-q17 performance

What changes are included in this PR?

Are these changes tested?
I had test this on my local Mac, for TPCH-q17, there is at least 10% improvement
Before this PR:
Query 17 iteration 0 took 3249.9 ms and returned 1 rows
Query 17 iteration 1 took 3430.5 ms and returned 1 rows
Query 17 iteration 2 took 3413.1 ms and returned 1 rows
Query 17 avg time: 3364.49 ms
After this PR:
Query 17 iteration 0 took 3019.4 ms and returned 1 rows
Query 17 iteration 1 took 2979.6 ms and returned 1 rows
Query 17 iteration 2 took 2963.0 ms and returned 1 rows
Query 17 avg time: 2987.34 ms
I need someone else who can run the benchmark and verify this on a spare machine.

Are there any user-facing changes?

@liukun4515 @yahoNanJing

Great work, I can take a look tomorrow and rerun the benchmarks on my machine.

@mingmwang query 18 also is affected by this (although should be less of a difference than query 17)

I tried testing the changes in this PR and ran into some errors when running query 1 using the code in https://github.com/sql-benchmarks/sqlbench-runners/tree/main/datafusion
thread 'tokio-runtime-worker' panicked at 'Unexpected accumulator state in hash aggregate: Internal("Arithmetic Overflow in AvgAccumulator")', /home/andy/.cargo/git/checkouts/arrow-datafusion-bfd9a8de51c58474/4e6eac5/datafusion/core/src/physical_plan/aggregates/row_hash.rs:642:81
thread 'tokio-runtime-worker' panicked at 'Unexpected accumulator state in hash aggregate: Internal("Arithmetic Overflow in AvgAccumulator")', /home/andy/.cargo/git/checkouts/arrow-datafusion-bfd9a8de51c58474/4e6eac5/datafusion/core/src/physical_plan/aggregates/row_hash.rs:642:81
thread 'tokio-runtime-worker' panicked at 'Unexpected accumulator state in hash aggregate: Internal("Arithmetic Overflow in AvgAccumulator")', /home/andy/.cargo/git/checkouts/arrow-datafusion-bfd9a8de51c58474/4e6eac5/datafusion/core/src/physical_plan/aggregates/row_hash.rs:642:81

I don't see these errors when running against the latest in the main branch.

Here are the results on my desktop (24 core) for queries 17 and 18.
This PR
Executing query 17 from /home/andy/git/sql-benchmarks/sqlbench-h/queries/sf=10//q17.sql
Query 17 executed in: 25.076557605s
Query 17 executed in: 14.468542149s
Query 17 executed in: 13.238961128s
Executing query 18 from /home/andy/git/sql-benchmarks/sqlbench-h/queries/sf=10//q18.sql
Query 18 executed in: 8.197590942s
Query 18 executed in: 7.883707736s
Query 18 executed in: 7.936216688s

Main branch
Executing query 17 from /home/andy/git/sql-benchmarks/sqlbench-h/queries/sf=10//q17.sql
Query 17 executed in: 20.10441009s
Query 17 executed in: 14.731355792s
Query 17 executed in: 13.869329179s
Executing query 18 from /home/andy/git/sql-benchmarks/sqlbench-h/queries/sf=10//q18.sql
Query 18 executed in: 8.900509355s
Query 18 executed in: 8.695394752s
Query 18 executed in: 8.541570444s
Executing query 19 from /home/andy/git

When running in memory (SF=1)
cargo run --release --bin tpch benchmark datafusion --path ./data/ --format parquet --partitions 16 -q 17 --iterations 10 -m

main
Query 17 iteration 0 took 725.6 ms and returned 1 rows
Query 17 iteration 1 took 675.3 ms and returned 1 rows
Query 17 iteration 2 took 635.1 ms and returned 1 rows
Query 17 iteration 3 took 702.1 ms and returned 1 rows
Query 17 iteration 4 took 624.7 ms and returned 1 rows
Query 17 iteration 5 took 692.2 ms and returned 1 rows
Query 17 iteration 6 took 681.0 ms and returned 1 rows
Query 17 iteration 7 took 668.9 ms and returned 1 rows
Query 17 iteration 8 took 675.6 ms and returned 1 rows
Query 17 iteration 9 took 660.6 ms and returned 1 rows
Query 17 avg time: 674.12 ms

Query 18 iteration 0 took 377.6 ms and returned 57 rows
Query 18 iteration 1 took 361.1 ms and returned 57 rows
Query 18 iteration 2 took 353.7 ms and returned 57 rows
Query 18 iteration 3 took 362.2 ms and returned 57 rows
Query 18 iteration 4 took 359.8 ms and returned 57 rows
Query 18 iteration 5 took 356.8 ms and returned 57 rows
Query 18 iteration 6 took 350.8 ms and returned 57 rows
Query 18 iteration 7 took 360.6 ms and returned 57 rows
Query 18 iteration 8 took 351.6 ms and returned 57 rows
Query 18 iteration 9 took 352.2 ms and returned 57 rows
Query 18 avg time: 358.65 ms

PR
Query 17 iteration 0 took 640.5 ms and returned 1 rows
Query 17 iteration 1 took 649.0 ms and returned 1 rows
Query 17 iteration 2 took 597.3 ms and returned 1 rows
Query 17 iteration 3 took 639.3 ms and returned 1 rows
Query 17 iteration 4 took 645.2 ms and returned 1 rows
Query 17 iteration 5 took 653.8 ms and returned 1 rows
Query 17 iteration 6 took 628.6 ms and returned 1 rows
Query 17 iteration 7 took 643.7 ms and returned 1 rows
Query 17 iteration 8 took 600.0 ms and returned 1 rows
Query 17 iteration 9 took 591.8 ms and returned 1 rows
Query 17 avg time: 628.91 ms

Query 18 iteration 0 took 355.8 ms and returned 57 rows
Query 18 iteration 1 took 333.5 ms and returned 57 rows
Query 18 iteration 2 took 317.5 ms and returned 57 rows
Query 18 iteration 3 took 327.6 ms and returned 57 rows
Query 18 iteration 4 took 318.2 ms and returned 57 rows
Query 18 iteration 5 took 324.2 ms and returned 57 rows
Query 18 iteration 6 took 315.0 ms and returned 57 rows
Query 18 iteration 7 took 323.1 ms and returned 57 rows
Query 18 iteration 8 took 314.8 ms and returned 57 rows
Query 18 iteration 9 took 322.0 ms and returned 57 rows
Query 18 avg time: 325.17 ms

Although PR shows an improvement, ~15% of the CPU samples still end up in cast.

I run the test with sf=1 and partition = 1.  I will do more test with sf= 10 tomorrow.

@Dandandan, how did you generate the flame graph? At my side, there're many unknowns. Could you teach me how to avoid them.

cargo run --release --bin tpch -- benchmark datafusion --iterations 10 --path ./data-parquet --format parquet --partitions 1 --query 17
sudo perf record -F 99 -g -p 917304
sudo perf script | ./stackcollapse-perf.pl | ./flamegraph.pl > perf.svg

I tried testing the changes in this PR and ran into some errors when running query 1 using the code in https://github.com/sql-benchmarks/sqlbench-runners/tree/main/datafusion
thread 'tokio-runtime-worker' panicked at 'Unexpected accumulator state in hash aggregate: Internal("Arithmetic Overflow in AvgAccumulator")', /home/andy/.cargo/git/checkouts/arrow-datafusion-bfd9a8de51c58474/4e6eac5/datafusion/core/src/physical_plan/aggregates/row_hash.rs:642:81
thread 'tokio-runtime-worker' panicked at 'Unexpected accumulator state in hash aggregate: Internal("Arithmetic Overflow in AvgAccumulator")', /home/andy/.cargo/git/checkouts/arrow-datafusion-bfd9a8de51c58474/4e6eac5/datafusion/core/src/physical_plan/aggregates/row_hash.rs:642:81
thread 'tokio-runtime-worker' panicked at 'Unexpected accumulator state in hash aggregate: Internal("Arithmetic Overflow in AvgAccumulator")', /home/andy/.cargo/git/checkouts/arrow-datafusion-bfd9a8de51c58474/4e6eac5/datafusion/core/src/physical_plan/aggregates/row_hash.rs:642:81

I don't see these errors when running against the latest in the main branch.

I can not reproduce the issue using DataFusion's own benchmark data(sf=10),  but I'm able to reproduce the issue using Spark generated benchmark data. I guess Spark's tpch data schema is different with DataFusion's.

Hi @Dandandan, for the latest code, the cast is almost avoided. The related flame graphs are as follows:

With single partition benchmark, the latency is reduced from 11s to 9s for q17.

I tried testing the changes in this PR and ran into some errors when running query 1 using the code in https://github.com/sql-benchmarks/sqlbench-runners/tree/main/datafusion
thread 'tokio-runtime-worker' panicked at 'Unexpected accumulator state in hash aggregate: Internal("Arithmetic Overflow in AvgAccumulator")', /home/andy/.cargo/git/checkouts/arrow-datafusion-bfd9a8de51c58474/4e6eac5/datafusion/core/src/physical_plan/aggregates/row_hash.rs:642:81
thread 'tokio-runtime-worker' panicked at 'Unexpected accumulator state in hash aggregate: Internal("Arithmetic Overflow in AvgAccumulator")', /home/andy/.cargo/git/checkouts/arrow-datafusion-bfd9a8de51c58474/4e6eac5/datafusion/core/src/physical_plan/aggregates/row_hash.rs:642:81
thread 'tokio-runtime-worker' panicked at 'Unexpected accumulator state in hash aggregate: Internal("Arithmetic Overflow in AvgAccumulator")', /home/andy/.cargo/git/checkouts/arrow-datafusion-bfd9a8de51c58474/4e6eac5/datafusion/core/src/physical_plan/aggregates/row_hash.rs:642:81

I don't see these errors when running against the latest in the main branch.

I added the overflow check when converting the internal sum type to the result type, there was bug it is fixed now.

Here are the results on my desktop (24 core) for queries 17 and 18 (sf=10)
This PR
Executing query 17 from /home/andy/git/sql-benchmarks/sqlbench-h/queries/sf=10//q17.sql
Query 17 executed in: 25.076557605s
Query 17 executed in: 14.468542149s
Query 17 executed in: 13.238961128s
Executing query 18 from /home/andy/git/sql-benchmarks/sqlbench-h/queries/sf=10//q18.sql
Query 18 executed in: 8.197590942s
Query 18 executed in: 7.883707736s
Query 18 executed in: 7.936216688s

Main branch
Executing query 17 from /home/andy/git/sql-benchmarks/sqlbench-h/queries/sf=10//q17.sql
Query 17 executed in: 20.10441009s
Query 17 executed in: 14.731355792s
Query 17 executed in: 13.869329179s
Executing query 18 from /home/andy/git/sql-benchmarks/sqlbench-h/queries/sf=10//q18.sql
Query 18 executed in: 8.900509355s
Query 18 executed in: 8.695394752s
Query 18 executed in: 8.541570444s
Executing query 19 from /home/andy/git

Could you please rerun the benchmark with partition = 1 or partition = 2 ?

I tried testing the changes in this PR and ran into some errors when running query 1 using the code in https://github.com/sql-benchmarks/sqlbench-runners/tree/main/datafusion
thread 'tokio-runtime-worker' panicked at 'Unexpected accumulator state in hash aggregate: Internal("Arithmetic Overflow in AvgAccumulator")', /home/andy/.cargo/git/checkouts/arrow-datafusion-bfd9a8de51c58474/4e6eac5/datafusion/core/src/physical_plan/aggregates/row_hash.rs:642:81
thread 'tokio-runtime-worker' panicked at 'Unexpected accumulator state in hash aggregate: Internal("Arithmetic Overflow in AvgAccumulator")', /home/andy/.cargo/git/checkouts/arrow-datafusion-bfd9a8de51c58474/4e6eac5/datafusion/core/src/physical_plan/aggregates/row_hash.rs:642:81
thread 'tokio-runtime-worker' panicked at 'Unexpected accumulator state in hash aggregate: Internal("Arithmetic Overflow in AvgAccumulator")', /home/andy/.cargo/git/checkouts/arrow-datafusion-bfd9a8de51c58474/4e6eac5/datafusion/core/src/physical_plan/aggregates/row_hash.rs:642:81

I don't see these errors when running against the latest in the main branch.

I can not reproduce the issue using DataFusion's own benchmark data(sf=10), but I'm able to reproduce the issue using Spark generated benchmark data. I guess Spark's tpch data schema is different with DataFusion's.

Maybe decimals vs floats? Official TPC-H uses decimals.

Hi @mingmwang , for generating the flamegraphs I currently use cargo flamegraph from https://github.com/flamegraph-rs/flamegraph .
I use the following command:
CARGO_PROFILE_RELEASE_DEBUG=true cargo flamegraph --freq 5000 --bin tpch -- benchmark datafusion --path ./data/ --format parquet --partitions 16 -q 17 -d --iterations 10

But in general, we can have a more general decimal precision change and overflow check logic for Decimal. And the Aggregators can reuse the logic.

@Dandandan @andygrove @andygrove @yahoNanJing
Would you please help to review and approve this PR ?

LGTM.

Hi @Dandandan, @andygrove, @alamb, do you still have any concerns for this PR? At my side, this PR can achieve around 20% performance improvement for q17 with single partition. It would be better to merge this PR first and then continue other bottleneck refining :)


Request: separate-compilation option

Would it be possible to add an option that separately compiles the parser and some of the other detail code that callers don't need?  That would speed up compilation quite a bit.  Thanks for considering this request!
Example of how this is done in another library: https://github.com/gulrak/filesystem#using-it-as-forwarding-implementation-header

As an interim step, I was able to write a forwarding header and function using the default template arguments.  Here it is in case it helps anyone else:
toml-wrapper.hpp
#include <unordered_map>
#include <vector>

#include "toml/get.hpp"

toml::basic_value<toml::preserve_comments, std::unordered_map, std::vector>
parseTomlFile(std::string fname);

toml-wrapper.cpp
#include "toml.hpp"
#include "toml-wrapper.hpp"

toml::basic_value<toml::preserve_comments, std::unordered_map, std::vector>
parseTomlFile(std::string fname)
{
    return toml::parse(fname);
}

I have just released v4.0.0 and now this feature is implemented.
By setting cmake -DTOML11_PRECOMPILE=ON or #define TOML11_COMPILE_SOURCES, you can compile src/*.cpp and it makes compilation ~2x faster.

Much appreciated!  I can see the difference in my compile times!


Removed code duplication

Checklist

[x] I have followed the Contributor Guidelines.
[x] I have added the relevant documentation.
[x] My branch is up-to-date with the Upstream master branch.

Changes proposed in this pull request
Issue : #135
There were a few code duplication in lib/http_fuzzer/engine.py, thus violating the DRY principle. This PR deals with those issues.
timeout_sec is by default set to None. We need not need to create a separate if-else regarding this. We can pass timeout=timeout_sec provided timeout=None is a valid parameter.
We can generate the request statement dynamically by using eval function, this will reduce chances of repeating ourselves.
Your development environment

OS: Kali Linux
OS Version: 2
Python Version: 3.6.6

eval function here is used only after the called request method matches with those specified in the list. Hence, it is safer to use here.
Any suggestions?

Hi, thanks for your PR.
please give me a few time to review this PR, meanwhile @shaddygarg @pradeepjairamani please if you have time, feel free to send your reviews.
Regards.

@Ali-Razmjoo, Looks fine to me!! I think it can be merged!!

@shaddygarg thanks for reviewing
@abhisharma404 thanks for your PR
looking forward to see more contribution from you, once again thanks. merged.


Reduce the size of our CI build matrix

#108 implements CI jobs for every supported major version of our critical dependencies, on every OS and PHP version we support. That's a lot of damn jobs (about 40) and greatly increases the time our test runs take. More coverage is good, but maybe we should find ways to optimize it so we're not waiting aeons for tests.

We're down to like 9 jobs, after dropping support for some ancient PHP and Symfony versions. With our CI matrix now quite reasonably sized, I think we can close this.


Reset focus when scrolling to top of page?

So because the page is scrolling to the top (and emulating a new page render), would it make sense to reset the focus to the top of the page?
The kicker here is that I could attempt to do this myself, but here's some sample code:
const history = withScroll(createHistory(), (prevLocation, location) => {
    // scroll to top when visiting a new page
    // except for month section on the calendar page
    const prevPath = prevLocation ? prevLocation.pathname : null;
    const path = location.pathname;
    return !prevPath
    || !(prevPath.includes('/random-page/') && path.includes('/random-page/'))
        ? [0, 0] : false;
});

Basically this is just the scroll logic, but in some instances we don't want to scroll to the top. So it would make sense for this piece of functionality to be bundled with withScroll as some sort of boolean we would pass. Thoughts?
(side note: I am using this version, and I'll eventually want to use the react specific version of this package, but this is what I'm using now)

Seems reasonable. Care to send a PR?


DX-61454 Add cloud tests for Arctic sources.

You'll need to install python-dotenv as a dependency, so your build doesn't fail:
python -m pip install python-dotenv


Small: approxUniform

approxUniform doesn't work like the other discrete approximators in HARKutilities, as it only returns values rather than probabilities. It's also not a natural way to specify a uniform distribution (most people would expect approxUniform(N,bot,top)) and should be rewritten.  This is easy to fix, but then cstwMPC needs a small repair.

Done in new commit to comments-and-cleanup.


Command to change the debug serial baudrate

It would be nice to have a command that could be used in a mapping to update the default debug serial baudrate.

Do you mean a command to manually specify the baud rate? Because that's done by simply setting let g:arduino_serial_baud = 9600
https://github.com/stevearc/vim-arduino/blob/1a4fd1576550b1b6fd1d90ea7515ca209f09fe67/doc/arduino.txt#L104-L106
Or do you mean a command to do the automatic baud rate detection on the current file? There's no command for that currently but you could easily map the function call
https://github.com/stevearc/vim-arduino/blob/1a4fd1576550b1b6fd1d90ea7515ca209f09fe67/ftplugin/arduino.vim#L16-L18

Mmm... I mean a command of this type:
The main commands you will want to use are:

:ArduinoChooseBoard - Select the type of board from a list.
:ArduinoChooseProgrammer - Select the programmer from a list.
:ArduinoChoosePort - Select the serial port from a list.
:ArduinoVerify - Build the sketch.
:ArduinoUpload - Build and upload the sketch.
:ArduinoSerial - Connect to the board for debugging over a serial port.
:ArduinoUploadAndSerial - Build, upload, and connect for debugging.
:ArduinoInfo - Display internal information. Useful for debugging issues with vim-arduino.

So that I can invoke it with a key binding for convenience.

It's still not clear to me if what you want to do with your keybinding is set the baud rate to a value or perform the auto detection.
Assuming it's the auto detection, you can already do that by calling the function arduino#SetAutoBaud()
nnoremap <buffer> <leader>b :call arduino#SetAutoBaud()<CR>

I would like to have a mapping that has the exact same functionality as let g:arduino_serial_baud = 9600. I usually have several sketches open that use different debug serial baudrates, so it would be great to (1) be able to configure them with a mapping (and not having to look for my .vimrc, edit it, and source it) and 2. make this variable buffer specific, so that I could for example use 9600 with one sketch, and 115200 with another one.

Gotcha! That's a pretty easy add


[WIP] Update openvino examples

Related issue #21
Changes

[x] Use the official release files to install WasmEdge and plugins in the GitHub Actions CI. Do not build from the source.
[x] Create two CI workflows for OpenVINO examples: build_openvino_mobilenet.yml and build_openvino_road_seg_adas.
[ ] Update the wasi-nn crate in all examples to the latest (no more unsafe)
[ ] Update the README for each example to be consistent with the successful CI.

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!

@juntao @q82419 Could you please help review this PR? Thanks a lot!

I'm refactor the docs for the new installer for plug-in.
Will review this after refactoring.

@q82419 Ok, thanks!

@q82419 Thanks for the review!


Change WaitTime argument from milliseconds to seconds

Pull request corresponding to issue https://github.com/raysan5/raylib/issues/2505 .

@flashback-fx thanks for the improvement!


[FLINK-18590][json] Support json array explode to multi messages

What is the purpose of the change
Support JSON deserializes json array to multi records.
Brief change log
Support JSON deserializes json array to multi records.
Verifying this change
This change added tests and can be verified as follows:

JsonRowDataSerDeSchemaTest#testJsonArrayToMultiRecords

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

the ci failure is not relevant with this pr, it's passing on my private ci: https://dev.azure.com/libenchao/flink.benchao/_build/results?buildId=32&view=results

@wuchong Sorry for the lateness. I've addressed most of your comments, could you have another look?

Hi @libenchao are you still interested in working on this issue? Can you rebase?

@slinkydeveloper Thanks for your interest, I'll rebase this pr and let's move forward.

Perfect! Once you're done, let me know and I'll review it. Thank you!

Hi ,we also have this kind issue ,when can done it ? Is there some plan ?

@poan0508 this PR is looking for someone to finalize it. Wanna take a crack at it?

@leeoo Thanks for your interest, I'll rebase the PR the latest master branch lately, would you please help to review it?

@libenchao Okay, but I don't have experience in improving Flink framework, it's better to review it by Flink framework contributors. I will keep an eye on it and test it with my kafka JSON array message data.

@leeoo I've rebased the PR to the latest master. It would be great if you can help to verify that this solves your problem.

@wuchong Do you have time to have a look for this PR?


GraphQL Subscription not support connectionParams.

In subscriptions-transport-ws, the client allow to send connectionParams when connect_init, which is a core function to support JWT or other token for the subscription.
Can we offer something that can send this, and if it is possible, can also expose the socket object too so we can manual reconnect to server when refresh the token.

Right now I just copy the WebSocketSubscriptionTransport code and change the send() method to handle OperationClientMessage.Init with another logic.


Avoid sending the same question from frontend

Is your feature request related to a problem? Please describe.
Not sure if it's intended or not, but I found that someone sending the same question to different person.
In another case, to the same person.
Describe the solution you'd like
My idea is saving the last sent question to the session storage/local storage. Before sending it, validate in frontend. Make sure it's not the same with the previous one.

Mas Irfan, I would like to handle this issue.
From your solution, i guess the implementation would be:

Store sent question to the session storage
When another question asked, validated the question with the one in the session storage

Another issue to tackle is maybe to disable the send question button when question asked to prevent the double question

Just finish the implementation mas @mazipan
Had busy at work so I can only do it right now


RFC5545 only allows datetime resolution to seconds, not milliseconds

resolves #2
I tried running tests locally but ran into some issues install dependencies.  I had to locally upgrade ssl_verify_fun with mix deps.update ssl_verify_fun and then I was able to successfully run tests.

I added some tests to the commit.

Thank you @tisdall! Looks good.


[Torch] Miscellaneous fix, enable some VM GPU tests

Fix https://github.com/apache/incubator-tvm/issues/6414 (a bug in converting stride argument of aten::slice op). Relay strided_slice needs strides specified for all axes.
Fix https://discuss.tvm.apache.org/t/pytorch-torch-nn-functional-avg-pool-stride-defalut-none-cause-error-in-infer-type/5878/2 (Just applying the fix in https://github.com/apache/incubator-tvm/pull/4984 to other pooling op)
Enable some VM GPU tests (controw flow related tests). Dynamic NMS also uses VM, but it can only run on CPU.

please review @siju-samuel @t-vi

@masahi Thank you!


My profile UI alignment

Describe the task
When we go to my profile page after clicking on avatar icon. The image, name and email are misaligned with the edit button. We would want the profile content to be lifted up a bit, to be in the same line with edit button.

This issue is completed. Closing it.