[Bug] screen freezes on death frame when trying to play death audio

hey there,
updated to the most recent version 2.1.0, and getting the bug in the title.  Game will continue normally, with the dead player stuck on the frame immediately before death until the day ends and they get respawned.  Observed reproducibly on the WesleyMoon Asteroid-13 (all types of death, inside and outside... not sure what other maps can reproduce)
Falling back to 1.3.0 fixes it
An example of a stuck death frame with 2.1.0

thrown error
[13:13:11.2495478] [Error  : Unity Log] NullReferenceException
Stack trace:
UnityEngine.GameObject.GetComponent[T] () (at <e27997765c1848b09d8073e5d642717a>:IL_0021)
CustomDeathAudio.PlayerControllerBPatch.KillPlayerPatch (GameNetcodeStuff.PlayerControllerB __instance) (at <168e27b3941d4a38bb6ff84a2d75c2d2>:IL_0046)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::KillPlayerClientRpc>(GameNetcodeStuff.PlayerControllerB,int,bool,UnityEngine.Vector3,int,int)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::KillPlayerServerRpc>(GameNetcodeStuff.PlayerControllerB,int,bool,UnityEngine.Vector3,int,int)
GameNetcodeStuff.PlayerControllerB.__rpc_handler_1346025125 (Unity.Netcode.NetworkBehaviour target, Unity.Netcode.FastBufferReader reader, Unity.Netcode.__RpcParams rpcParams) (at <255c0877f9414c3aa6f1fe5079ac13f3>:IL_00CA)
Unity.Netcode.RpcMessageHelpers.Handle (Unity.Netcode.NetworkContext& context, Unity.Netcode.RpcMetadata& metadata, Unity.Netcode.FastBufferReader& payload, Unity.Netcode.__RpcParams& rpcParams) (at <895801699cfc4b4ab52267f31e2a4998>:IL_004E)
Rethrow as Exception: Unhandled RPC exception!
UnityEngine.Logger:LogException(Exception, Object)
AsyncLoggers.Wrappers.Unity.<>c__DisplayClass4_0:<LogException>b__0() (at ./src/Wrappers/Unity/AsyncLoggerWrapper.cs:36)
AsyncLoggers.Wrappers.Unity.<>c__DisplayClass28_0:<wrapCallback>b__0() (at ./src/Wrappers/Unity/AsyncLoggerWrapper.cs:136)
AsyncLoggers.Wrappers.JobWrapper:LogWorker() (at ./src/Wrappers/JobWrapper.cs:84)
AsyncLoggers.Wrappers.LogJob:Execute() (at ./src/Wrappers/JobWrapper.cs:68)
Unity.Jobs.JobStruct`1:Execute(LogJob&, IntPtr, IntPtr, JobRanges&, Int32)

[13:13:11.2495478] [Error  : Unity Log] NullReferenceException
Stack trace:
UnityEngine.GameObject.GetComponent[T] () (at <e27997765c1848b09d8073e5d642717a>:IL_0021)
CustomDeathAudio.PlayerControllerBPatch.KillPlayerPatch (GameNetcodeStuff.PlayerControllerB __instance) (at <168e27b3941d4a38bb6ff84a2d75c2d2>:IL_0046)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::KillPlayerClientRpc>(GameNetcodeStuff.PlayerControllerB,int,bool,UnityEngine.Vector3,int,int)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::KillPlayerServerRpc>(GameNetcodeStuff.PlayerControllerB,int,bool,UnityEngine.Vector3,int,int)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::KillPlayer>(GameNetcodeStuff.PlayerControllerB,UnityEngine.Vector3,bool,CauseOfDeath,int)
KillLocalPlayer.KillPlayer (GameNetcodeStuff.PlayerControllerB playerWhoTriggered) (at <255c0877f9414c3aa6f1fe5079ac13f3>:IL_0091)
UnityEngine.Events.InvokableCall`1[T1].Invoke (T1 args0) (at <e27997765c1848b09d8073e5d642717a>:IL_0010)
UnityEngine.Events.UnityEvent`1[T0].Invoke (T0 arg0) (at <e27997765c1848b09d8073e5d642717a>:IL_0025)
InteractTrigger.Interact (UnityEngine.Transform playerTransform) (at <255c0877f9414c3aa6f1fe5079ac13f3>:IL_00AF)
(wrapper dynamic-method) InteractTrigger.DMD<InteractTrigger::OnTriggerEnter>(InteractTrigger,UnityEngine.Collider)

[13:13:11.2495478] [Error  : Unity Log] NullReferenceException
Stack trace:
UnityEngine.GameObject.GetComponent[T] () (at <e27997765c1848b09d8073e5d642717a>:IL_0021)
CustomDeathAudio.PlayerControllerBPatch.KillPlayerPatch (GameNetcodeStuff.PlayerControllerB __instance) (at <168e27b3941d4a38bb6ff84a2d75c2d2>:IL_0046)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::KillPlayerClientRpc>(GameNetcodeStuff.PlayerControllerB,int,bool,UnityEngine.Vector3,int,int)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::KillPlayerServerRpc>(GameNetcodeStuff.PlayerControllerB,int,bool,UnityEngine.Vector3,int,int)
(wrapper dynamic-method) GameNetcodeStuff.PlayerControllerB.DMD<GameNetcodeStuff.PlayerControllerB::KillPlayer>(GameNetcodeStuff.PlayerControllerB,UnityEngine.Vector3,bool,CauseOfDeath,int)
KillLocalPlayer.KillPlayer (GameNetcodeStuff.PlayerControllerB playerWhoTriggered) (at <255c0877f9414c3aa6f1fe5079ac13f3>:IL_0091)
UnityEngine.Events.InvokableCall`1[T1].Invoke (T1 args0) (at <e27997765c1848b09d8073e5d642717a>:IL_0010)
UnityEngine.Events.UnityEvent`1[T0].Invoke (T0 arg0) (at <e27997765c1848b09d8073e5d642717a>:IL_0025)
InteractTrigger.Interact (UnityEngine.Transform playerTransform) (at <255c0877f9414c3aa6f1fe5079ac13f3>:IL_00AF)
(wrapper dynamic-method) InteractTrigger.DMD<InteractTrigger::OnTriggerEnter>(InteractTrigger,UnityEngine.Collider)

Hi ajsglist, thanks for your feedback!
I can't reproduce this error in my game.
Please provide a share code or a mod list.

I released a new update, which could fix the problem I think.

Apologies for not having a modlist code available.  This modlist should reproduce the issue if you update CustomDeathAudio to the reported version (I reverted to an earlier release for the stable release of the modlist) 01903b46-9c8c-0008-2427-da32741a7894
I see there was an update pushed, I will try it out when I have some time later.  Thanks!

I just tested the most-recent version (2.1.1) and I'm happy to report that the death lockup appears to have been fixed.
Thanks so much for pushing an update

Thank you for testing this : )


Aslak’s testable-architecture-devlin-2017 ppt link in testable-architecture.md is Invalid

Aslak’s testable-architecture-devlin-2017 ppt link in testable-architecture.md is Invalid

Would this https://speakerdeck.com/aslakhellesoy/testable-architecture-devlin-2017 do?

Would you like to offer a PR with a change to make the documentation usable?

Would this https://speakerdeck.com/aslakhellesoy/testable-architecture-devlin-2017 do?

Yes, is this URL working ?i can't access this URL, maybe my network has some problem?

It works for me, it's a presentation to page through by click/tap on the right side of the presentation slide.

Current link works for me (both slides and talk).
Could you provide more information about what's wrong @missley ?

Closing this issue. Feel free to comment with more information and it can be reopened


ycmd: 2018-09-20 -> 2019-09-19; add optional golang completion

Motivation for this change
Needed golang support for ycmd.
Things done

Fix ycmd build (see dfc7bdb)
Update ycmd to 2019-09-19 (see 7d21d6a)
Add golang completer support (see dee0cb7)

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions : ubuntu-18.04

[ n/a ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)/nix/store/5xbbjfriyy7kmfkpwklls3418h9i7spx-ycmd-2019-09-19<PHONE_NUMBER>
/nix/store/njw3hsp4pgm78nvx6m65avrvy416yma9-ycmd-2018-09-20<PHONE_NUMBER>

[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Awesome work @siriobalmelli, thanks!


[ECS] speed up sniff,fixer processing

What is happening
seem like ecs are too slow for me, for instance i tested it on shopsys/shopsys
./vendor/bin/ecs check --clear-cache ./packages/*/src ./packages/*/tests ./packages/*/*.md ./*.md ./docs

it lasted for 1 minute, and the process seemed to me too slow so i tried to speed it it by pcntl_fork so it lasted just 20 seconds but i wasn't able to get the correct output from forked processes.
What should be the result
maybe some docs how to speed up some configuration of sniffs, fixers or some speed improvement.
THX.....

That's expected time in big projects like Shopsys.
Also it might be caused by using big amount of rules.

If there is some stuck fixer/sniff, try running it with --debug.
What is the time for code sniffer or PHP CS Fixer with same setup?

It takes 10-15 second to process Symplify monorepo with 350 files and with ecs.yml setup just to give you an idea.
Also, in practice you should always use cached result, unless you debug sniff/fixer.

This is too vague kind of issue to do anything meaningful. Concrete ideas for improvements are much better. This one seems like support post.
As an example, I was thinking to contribute some async stuff to ECS since I have some experience with it. So in that case issue for integrating amphp might be on point. That's example concrete idea for performance improvement.

@ostrolucky I have the same feeling.
Performance ideas are nice, but the implementation is often problematic. It requires Blackfire research with specific place before/after change to proove the change has effect - @boris-brtan take it as recipe for next performance issues.
I tried async runs before - it required dozens of extra files making code very confusing. In the end cache that skips unchanged files solves it much better way with minimal added complexity.

Closing as too vague.


Merge Develop to main for release v1.1.0

These commits are well tested.
Time to release.

Rejected because the test failed.


How to change the locale or accept language?

I don't find in documentation how to change the locale or accept language, is it possible?

did you find an answer to your question? Would you be able to share it?


Node.js 16 prebuilds for Macs with the M1 processor (arm64 architecture)

Consider replacing Node.js 14 prebuild for Mac OS X with a Node.js 16 prebuild for arm64 (M1), to to avoid adding 300kb to the npm package.

What confuses me is the Travis CI build not picking up the existing Node.js 16 prebuild. According to the log, it is an x86_64-apple-darwin17.7.0 and should do that. Will investigate this. 🤔


renovate: Switch to update-lockfile strategy

Support for this strategy was added in:
https://github.com/renovatebot/renovate/pull/25983
The behavior of the replace strategy seems to have changed (I'm guessing due to the above PR) such that we're getting a lot of PRs updating Cargo.toml that we don't want. Hopefully changing the stategy to update-lockfile will fix that.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (70d7068) 95.66% compared to head (74cec20) 95.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   95.66%   95.66%
=======================================
  Files          10       10
  Lines         761      761
=======================================
  Hits          728      728
  Misses         33       33

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Two users, two tokens, same result sets

I've got Spotipy running on a localhost. I've authenticated two different users and have confirmed their tokens are unique. When I run the following code to get currently playing information, I get the same results in spite of having different Spotify sessions running (different devices) for each of the users.
Testing further, this looks like a "current user" definition issue. Using the Spotipy "current_user()" method, I get the same username regardless of the token returned. Assuming log in / log out is even the right solution in this case not sure how I would implement log in this environment (running everything from command line). Shouldn't the authentication token be the basis for the results returned?
playback.py:
import sys
import spotipy
import spotipy.util as util

scope = 'user-library-read user-read-currently-playing user-read-playback-state'

if len(sys.argv) > 1:
    username = sys.argv[1]
    print username + ': '
else:
    print "Usage: %s username" % (sys.argv[0],)
    sys.exit()

token = util.prompt_for_user_token(username, scope)

if token:
    print "Token: "+ token + " // "
    sp = spotipy.Spotify(auth=token)
    results = sp.current_playback()
    isplaying = results['is_playing']
    print isplaying
    if isplaying:
        track = results['item']['name']
        artist = results['item']['artists'][0]['name']
        trackid = results['item']['id']
        device = results['device']['name']
        print track + " - " + trackid + " - " + artist + " - on " + device
else:
    print "Can't get token for", username

Scope issue? I had a few different test scripts for my app with different scopes. I've updated them all to be consistent and now the issue seems to be resolved.


Add tomiis4/hypersonic.nvim

Repo URL:
https://github.com/tomiis4/hypersonic.nvim
Checklist:

[x] The plugin is specifically built for Neovim, or if it's a colorscheme, it supports treesitter syntax.
[x] The lines end with a .. This is to conform to awesome-list linting and requirements.
[x] The title of the pull request is Add/Update/Remove `username/repo`  (notice the backticks around `username/repo`) when adding a new plugin.
[ ] The description doesn't mention that it's a Neovim plugin, it's obvious from the rest of the document. No mentions of the word plugin unless it's related to something else.
[x] The description doesn't contain emojis.
[x] Neovim is spelled as Neovim (not nvim, NeoVim or neovim), Vim is spelled as Vim (capitalized), Lua is spelled as Lua (capitalized), Tree-sitter is spelled as Tree-sitter.
[x] Acronyms should be fully capitalized, for example LSP, TS, YAML, etc.

Thanks for the PR!

Hi, I have just updated it


Use the system date format by default

The current date format was ISO8601 (which is great!), but it's honestly a matter of preference. Use the system's default date format if none is specified, since it seems saner to respect the user's system settings that impose out own preference.

I don't know what that is on my machine. Having system-dependent default makes it harder to write tutorials that everybody can copy-paste from.

I don't know what that is on my machine.

Probably related to your language settings? Or the default? I don't honestly see this as a downside.

If you've never changed it, it'll be whatever distros use as a default.
If it's something else, it's probably what you see elsewhere.
Users who know what this value is will be glad to see it being respected.

Having system-dependent default makes it harder to write tutorials that everybody can copy-paste from.

We don't seem to use these formats for parsing, so it should not break any commands/input*. Users which see different outputs should not really be confused (I hope).

I actually noticed the UI is stricter with datetime formatting than the CLI, that really needs some love.

As an alternative, I single config flag like user_system_locale might cover it.

We do use those formats for parsing when creating new tasks. The UI is using the same code as the CLI as far as I recall.

Any veredict on close/merge here?

I don't think I care, I override it anyway :)


Access to validator instance properties when using property validators in a rule

Hello,
When I define an AbstractValidator for a class, I want to be able to access my class properties as parameters for the property validators the same way I can pick the property to validate when calling RuleFor()
Example:
public class TextFieldValidator : AbstractValidator<TextField>
    {
        public TextFieldValidator()
        {
            When(t => !string.IsNullOrEmpty(t.Regex), () =>
            {
                // This doesn't work
                RuleFor(t => t.Value).Matches(t => t.Regex);
            });
        }
    }

There is a workaround to do something like that?
Is it planned to add that feature in a future version?

Some of the built in validators do support this (Equal for example). For
those that don't, you can use "Must" instead - the second overload of Must
gives you access to the instance being validated.
Hope that helps
On Thursday, July 9, 2015, Emiliano Sandler<EMAIL_ADDRESS>wrote:

Hello,
When I define an AbstractValidator for a class, I want to be able to
access my class properties as parameters for the property validators the
same way I can pick the property to validate when calling RuleFor()
Example:
public class TextFieldValidator : AbstractValidator
{
public TextFieldValidator()
{
When(t => !string.IsNullOrEmpty(t.Regex), () =>
{
// This doesn't work
RuleFor(t => t.Value).Matches(t => t.Regex);
});
}
}
There is a workaround to do something like that?
Is it planned to add that feature in a future version?
—
Reply to this email directly or view it on GitHub
https://github.com/JeremySkinner/FluentValidation/issues/92.

How to preserve the default error messages when using the Regex property validator inside the Must validator?

You'd need to call WithLocalizedMessage and point it to the Regex
validator's default message (I think it's called regex_error off the top of
my head - I'm not at my laptop at the moment to check).
On Thursday, July 9, 2015, Emiliano Sandler<EMAIL_ADDRESS>wrote:

How to preserve the default error messages when using the Regex property
validator inside the Must validator?
—
Reply to this email directly or view it on GitHub
https://github.com/JeremySkinner/FluentValidation/issues/92#issuecomment-120100692
.

The problem I have, is that I need to be able to access this properties for almost all the property validators, because I am builing a Dynamic Forms module where the form fields, and its validation settings are stored in a database, and then I dynamically render those forms.
My form field entity has properties for Regex, Min/Max Length, Min/Max Value, etc and I don't think rewriting all validators I need is the most straightforward option for this.

Well, ok, but that's the only workaround I can think of at the moment. I'll
have a look tomorrow to see if I can find a better workaround.
Alternatively, If you want to submit a pull request to add support for
this, please feel free.
On Thursday, July 9, 2015, Emiliano Sandler<EMAIL_ADDRESS>wrote:

The problem I have, is that I need to be able to access this properties
for almost all the property validators, because I am builing a Dynamic
Forms module where the form fields, and its validation settings are stored
in a database, and then I dynamically render those forms.
My form field entity has properties for Regex, Min/Max Length, Min/Max
Value, etc and I don't think rewriting all validators I need is the most
straightforward option for this.
—
Reply to this email directly or view it on GitHub
https://github.com/JeremySkinner/FluentValidation/issues/92#issuecomment-120107030
.

I've added the lambdas for the Length and the Regex validators following the same workaround made for the Equal validator.
Please check the pull request.
Thank you!

Thanks - I'll try and get this reviewed tomorrow.
On Thursday, July 9, 2015, Emiliano Sandler<EMAIL_ADDRESS>wrote:

I've added the lambdas for the Length and the Regex validators following
the same workaround made for the Equal validator.
Please check the pull request.
Thank you!
—
Reply to this email directly or view it on GitHub
https://github.com/JeremySkinner/FluentValidation/issues/92#issuecomment-120140224
.

I've added some comments on the pull request about changes that need to be made - let's carry on the conversation over there: https://github.com/JeremySkinner/FluentValidation/pull/93


Add elexon forecast to graph

Detailed Description
Add elexon forecast to forecast graph
Context

forecast code is in here - https://github.com/openclimatefix/analysis-dashboard/blob/main/src/forecast.py
need to set DB_URL inorder to run this locally

Possible Implementation

Add elexonpy to requirements
show 3 different forecast - process type = "Day Ahead", "Intraday Process", "Intraday Total"

Hey  @peterdudfield , i can work on this.


Discussion about this cool library!

Hi Ryan,
@jhamman pointed me to this project, and it definitely seems like something that would be useful for the neural network + xarray community. Thanks for making it publicly available.
Since I have been working in this space the last year, I have found it very difficult to find the right abstraction level for this kind of batch generation. For my part, I have been using PyTorch instead of the keras+tensorflow, and have been plugging in with their Dataset and DataLoader framework: https://pytorch.org/tutorials/beginner/data_loading_tutorial.html. In this framework, you write a Dataset object with a __getitem__ method that returns a single "sample" (e.g. a pair of points, a patch of an image) etc, than the built in DataLoader handles all the work of combining these samples into batches. The advantage of this compared to plain iterators is that it allows an easy way to randomly shuffle the samples before combining them into batches. In my experience, this shuffling is basically required for a NN to train properly. FWIW, here is the Dataset object I have written for my work: https://github.com/nbren12/uwnet/blob/master/uwnet/datasets.py.
Overall, I think this is a challenging problem because the random access patterns we us in NN training may have nothing to do with how the data are laid out in memory or on disk.

Noah -- thanks for your message and your suggestions.  I know you've been at it for a long time and have come very far. I am very new to it all. This project is a really rough sketch which I threw together quite quickly. We are just experimenting at this point.
If it turns out there is actually a need for a package like this, would love to collaborate with people like you who have already come up with their own solutions on specific datasets.

Hey no problem! I think there is definitely a need for this sort of thing. Let me know if you ever want chat.

Hi @rabernat and @nbren12
I’ve been having discussions with @jhamman about this problem of loading data into pytorch/tensorflow from xarray. I’ll focus on Pytorch for now. My current process is to preprocess data from xarray into sample data files that can be easily loaded by pytorch’s Dataset. At scale this is a problem, I’m consistently way over data quotas on the HPC system I use. Often I can only use a subset of the total available dataset. Like you point out Noah, random access of this data is a requirement for training.
There are a few ideas I’ve been thinking about here. Pytorch’s Dataloader already tries to preload the data onto the GPU so it seems that speeding up random sampling memory access should help. I’m wondering if there are some interesting ways to setup data chunks and sampling. Can chunks be defined as sets of training samples? It’s possible that generating intermediate training files is good enough and in that case an xarray to standard pytorch data format could be very helpful. I’m beginning to work with many different satellite/climate datasets so I’d be interested in thinking about this problem more.

Hi @tjvandal. I really enjoyed your talk at the NOAA AI workshop last spring, btw.
We really have developed some best practices around this that I think works pretty well. Kudos go mostly to Stepan Rasp who figured out most of these tricks.

However, you define "sample", munge your data to have "sample" as its first dimension
Save the data as a zarr file chunked along a "sample" dimension with a fairly large chunk size. I would aim for 1 chunk to fill up about 75% of RAM.
True random data access is not necessary. It is usually good enough to shuffle within these chunks (not between them) provided they are large enough.

@nbren12  Thanks, I enjoyed your talk as well! The NOAA AI workshop was really interesting, looking forward to next years meeting.
I can definitely see how using zarr would speed up access, I'll give that a try. For now, this doesn't solve the problem of making a second copy of the data but that may not be worth dealing with.

Hey. I haven't decided to go again, but we should definitely meet in person if I do.
Unfortunately, I think copying the data in some way (either in memory or on disk) is necessary to ensure data locality and good performance since neural network training has a pretty unique access pattern.

We can probably close this issue. Not sure I had many actionable thoughts above...


Fix wheels release

Use latest cibuildwheel and fix all errors.

@doublethefish this builds all the wheels successfully on my fork :) would appreciate if you could take a look!

Thanks @doublethefish !
Sorry, I wasn't very diligent with the commit messages and history, I was expecting that you'd squash the whole PR 😌
Regarding clang change: it is to fix this error:
        /Users/runner/work/tmap/tmap/src/_tmap/cereal/types/tuple.hpp:119:85: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
          119 |     tuple_detail::serialize<std::tuple_size<std::tuple<Types...>>::value>::template apply( ar, tuple );
              |

which is a relatively recent addition to clang: https://github.com/llvm/llvm-project/pull/80801
Regarding 32 mins: that number is end-to-end but depends on available parallelism (in GitHub free tier?) at the moment. Each job takes about 5 mins (10 mins for macos x86_64) so best case you'd see 10 mins end-to-end, worst case ~2 hours (if everything is sequential).
Thanks again! I believe some of the long-standing issues can be closed now :)

Sorry, I wasn't very diligent with the commit messages and history, I was expecting that you'd squash the whole PR 😌

No worries, thanks for the PR. We are very grateful.

Regarding clang change: it is to fix this error:

Thanks for that it's useful to the specific warning, and edifying to know that I guessed right about the type of warning it was 🤓. As you probably know, -Wmissing-template-arg-list-after-template-kw is a warning that only errors because we have warning-as-errors on for that bit of code. Similar template-specific warnings have been around for a while, and problematic; for instance, at one point fixing this exact issue in one compiler, but leaving spaces between the angle-brackets, on another compiler would cause less-than symbol errors 🤦🏻♂.

Sounds great @doublethefish ! Would you be willing to release the wheels to PyPI?

Yes, of course. But it will have to be sometime over the next few days.


Fixed CollectiblesController tests to be a bit less duplicated

less duped code
As part of upgrading to V2 base controller for NetworkController, we need to be able to add clean up code to the end of each test easily. This PR makes the CollectiblesController make use of a beforeEach, and thus reduces the duplication both in this test, as well as minimizes the scope of change for other PRs

CHANGED:

Test refactoring for CollectiblesController.

Checklist

[x] Tests are included if applicable
[x] Any added code is fully documented

closing for the commented above reasons


Does autoencoder use values of target (y)

I saw that y is optional in the fit(X, y=None) of autoencoder.
What if I give y as input? Does algorithm use the values of y?
Actually I have a dataset with labels for some but not all data points (labels include 0, 1, and None).
Does the algorithm perform a semi-supervised approach if I set y to the labels and give it as input to the fit function?

no...it is just a placeholder for consistency across unsupervised and supervised models, y will not be used in any form for autoencoder.


Add wait for on assert table

For https://github.com/Medology/stdcheck.com/issues/8085
Added waitFor to assert table contain values.

!force code review

Testing file changes were not found.
Paging @manuerumx to review the back-end work in this pull request!
Paging @smijo149 to review the testing work in this pull request!


Search is unsupported/broken

I really love the theme, but the search seems broken. Anyone willing to help me out with this?

Is it fixed when reloading Atom? I have seen this issue when switching between light and dark themes without reloading.

Works afterwards, thanks!! So this is an Atom bug?

So this is an Atom bug?

Yeah, it has something to do with not all colors getting updated everywhere when switching themes.


Support subqueries in order_by, group_by, distinct, and windows

So this seems to work without too much change required, but I do have one main misgiving: This requires a modification to Ecto.QueryExpr, which AFAIK is used in other places that won't be anticipate having subqueries in them.
I've got a test that shows this working as-is with ecto_sql: https://github.com/elixir-ecto/ecto_sql/pull/607

So this seems to work without too much change required, but I do have one main misgiving: This requires a modification to Ecto.QueryExpr, which AFAIK is used in other places that won't be anticipate having subqueries in them.

Let's create a new struct called ByExpr and use the opportunity to support subqueries in both group by and order by?

Happy to do that, only concern with doing that will be anywhere that was explicitly matching on QueryExpr, but we can suss those out as necessary. Let me give it a try and see if anything breaks :)

Alright, made some adjustments. There are two outstanding issues:

now this does require changes in ecto_sql. I'm working on those changes. They will have to be updated in tandem for this to work.
I might need some guidance on what to do with the subqueries/aliases present when building windows. I can't say for sure, but it seems like it might just need more updates in ecto_sql.

Working on wrapping this up today. I'm ending up doing windows support because windows uses the same code that group_by uses, so adding subquery support to that naturally flows on to adding it for windows (w/ some extra bits required to make that work).
The big thing I'm realizing based on your comment about testing non-dynamic cases is that I definitely haven't handled the compile time builder side of things. I'm going to try to do that as well, but I'm not sure if I'll be able to pull it off w/o some tips. The primary issue is that the accumulator for compile time expressions appears to support gathering up subqueries but not aliases? I'll follow up and we can see how far I get 👍

Still have some equivalent tests to write in ecto_sql. I'm curious if the non-dynamic/dynamic split is important to test in ecto_sql considering that it's tested here? Regardless, still need to test each query building scenario.

Just commenting to point out that this should be ready to review. I can't see (for some reason) how or why the integration tests failed, but I'm assuming that it is because there are required changes in ecto_sql for this to work. Can we ship them simultaneously to address that? Do I need to find a way to make them compatible?

@greg-rychlewski like I'd update the mix.exs to use this branch as a dependency?

yeah exactly

Done :) its building now.

looks good to me :)

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


test-branch/execute-job/wrong-commit-sha-on-pr/49e6e096-67d1-4fce-9afa-e155b0a81c63

PR for testing 69a081c869db6a42f1559b33c48e286ed9250001

/canonical/self-hosted-runners/run-workflows dd681039aa42ab32c8f29d991bb08cd5a2a164db


Fixed BBD loading issue at startup

Thanks to people like square, intrnl, and some others for coming up w/ this fix.

This hurts to look at which means it was probably done by square. I'll accept now and make a proper fix when I have the time.


Invitation not in invited persons language.

When inviting a person to become a user, the mail sent should be in the primary language of the person's country.

Missing country data when fetching the user from the database.


#49 - Simple method to check if a project exists

Add exists_project method and corresponding test

Codecov Report

Merging #50 (5a33111) into dev (5b2bbef) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev      #50      +/-   ##
==========================================
+ Coverage   89.21%   89.31%   +0.09%
==========================================
  Files          15       15
  Lines        1298     1310      +12
==========================================
+ Hits         1158     1170      +12
  Misses        140      140

Impacted Files
Coverage Δ

averbis/core/_rest_client.py
82.71% <100.00%> (+0.10%)
:arrow_up:

tests/test_client.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2bbef...5a33111. Read the comment docs.


Turning off query planning is difficult

I mentioned this in #11067, but maybe this deserves its own issue: I find it difficult to turn off query planning using the Python API. Using dask.config.set only works if dask.dataframe hasn't been imported up until that point.
This works (query planner is turned off):
import dask
import pandas as pd

with dask.config.set({"dataframe.query-planning": False}):
    import dask.dataframe as dd  # delayed import
    ddf = dd.from_pandas(pd.DataFrame({"x": [1, 2, 3]}), chunksize=1)
    out = ddf.mean()
    print(hasattr(out, "_expr"))  # False

This doesn't work (query planner is turned on):
import dask
import pandas as pd
import dask.dataframe as dd  # I moved this import up

with dask.config.set({"dataframe.query-planning": False}):
    ddf = dd.from_pandas(pd.DataFrame({"x": [1, 2, 3]}), chunksize=1)
    out = ddf.mean()
    print(hasattr(out, "_expr"))  # True

When I write library code, I typically can't control what users already imported.
Yes, adding dd = importlib.reload(dd) inside the context also fixes the issue in this example, but that doesn't work in all settings.
E.g., imagine that I write a library with a function that some user can call with a dask dataframe:
# my library code
import dask

def my_func(ddf):
    with dask.config.set({"dataframe.query-planning": False}):
        # reloading dask.dataframe here of course doesn't make a difference
        out = ddf.mean()
        print(hasattr(out, "_expr"))  # True

# user code
import dask.dataframe as dd
import pandas as pd

from my_library import my_func

ddf = dd.from_pandas(pd.DataFrame({"x": [1, 2, 3]}), chunksize=1)
my_func(ddf)

Is there a clever way around this? I have drastic ideas like building a conda package that sets the DASK_DATAFRAME__QUERY_PLANNING environment variable, but that might be a bit much. I would much rather turn the query planner off selectively.
As an aside: maybe all of this is moot once #11067 is fixed.

Here's another example, where I struggle to turn off query planning: I'm using plateau to load a dask dataframe from disk:
import dask
import pandas as pd
from tempfile import TemporaryDirectory
from plateau.io.dask.dataframe import read_dataset_as_ddf
from plateau.io.eager import store_dataframes_as_dataset

dataset_dir = TemporaryDirectory()
store_url = f"hfs://{dataset_dir.name}"

def create_plateau_dataset():
    store_dataframes_as_dataset(
        dfs=[pd.DataFrame({"x": [1, 2, 3], "y": [3, 4, 5]})],
        dataset_uuid="abc123",
        store=store_url,
    )

if __name__ == "__main__":

    create_plateau_dataset()

    with dask.config.set({"dataframe.query-planning": False}):
        ddf = read_dataset_as_ddf(dataset_uuid="abc123", store=store_url)
        print(hasattr(ddf, "_expr"))  # True

Here, I wouldn't know which modules to reload to get the desired behavior.

We're experiencing the same issue, we cannot disable the query planning by doing:
dask.config.set({"dataframe.query-planning": False})

We've deprecated the legacy implementation and will soon remove it, so closing this issue since the option will be removed in that process as well

@phofl
One question,
On pip install dask, dask-expr is not installed
nanny@jupyter-326108df-3f38-4770-9791-88b69319658a-6c55bcb9c9-cqmf4:/projeto/326108df-3f38-4770-9791-88b69319658a/workdir$ pip install dask
Defaulting to user installation because normal site-packages is not writeable
Looking in indexes: http://binarios.intranet.bb.com.br/artifactory/api/pypi/pypi/simple, http://atf.intranet.bb.com.br/artifactory/api/pypi/bb-python-local/simple
Collecting dask
  Using cached https://binarios.intranet.bb.com.br/artifactory/api/pypi/pypi/packages/packages/a5/85/419e2914c17cf7128205784bf8dc802e754eda5b5799d21898f284f15242/dask-2024.11.1-py3-none-any.whl (1.3 MB)
Requirement already satisfied: click>=8.1 in /usr/local/lib/python3.11/site-packages (from dask) (8.1.3)
Requirement already satisfied: cloudpickle>=3.0.0 in /projeto/libs/lib/python3.11/site-packages (from dask) (3.1.0)
Requirement already satisfied: fsspec>=2021.09.0 in /projeto/libs/lib/python3.11/site-packages (from dask) (2024.10.0)
Requirement already satisfied: packaging>=20.0 in /projeto/libs/lib/python3.11/site-packages (from dask) (24.1)
Requirement already satisfied: partd>=1.4.0 in /projeto/libs/lib/python3.11/site-packages (from dask) (1.4.2)
Requirement already satisfied: pyyaml>=5.3.1 in /usr/local/lib/python3.11/site-packages (from dask) (6.0)
Requirement already satisfied: toolz>=0.10.0 in /projeto/libs/lib/python3.11/site-packages (from dask) (1.0.0)
Requirement already satisfied: importlib-metadata>=4.13.0 in /projeto/libs/lib/python3.11/site-packages (from dask) (8.5.0)
Requirement already satisfied: zipp>=3.20 in /projeto/libs/lib/python3.11/site-packages (from importlib-metadata>=4.13.0->dask) (3.20.2)
Requirement already satisfied: locket in /projeto/libs/lib/python3.11/site-packages (from partd>=1.4.0->dask) (1.0.0)
Installing collected packages: dask
Successfully installed dask-2024.11.1

If I try importing dask.dataframe, it shows the warning.
import dask.dataframe as dd
/projeto/libs/lib/python3.11/site-packages/dask/dataframe/__init__.py:49: FutureWarning:
Dask dataframe query planning is disabled because dask-expr is not installed.

You can install it with `pip install dask[dataframe]` or `conda install dask`.
This will raise in a future version.

But if I install dask[dataframe], dask-expr is installed. Is that expected?
nanny@jupyter-326108df-3f38-4770-9791-88b69319658a-6c55bcb9c9-cqmf4:/projeto/326108df-3f38-4770-9791-88b69319658a/workdir$ pip install dask[dataframe]
Defaulting to user installation because normal site-packages is not writeable
Looking in indexes: http://binarios.intranet.bb.com.br/artifactory/api/pypi/pypi/simple, http://atf.intranet.bb.com.br/artifactory/api/pypi/bb-python-local/simple
Requirement already satisfied: dask[dataframe] in /projeto/libs/lib/python3.11/site-packages (2024.11.1)
Requirement already satisfied: click>=8.1 in /usr/local/lib/python3.11/site-packages (from dask[dataframe]) (8.1.3)
Requirement already satisfied: cloudpickle>=3.0.0 in /projeto/libs/lib/python3.11/site-packages (from dask[dataframe]) (3.1.0)
Requirement already satisfied: fsspec>=2021.09.0 in /projeto/libs/lib/python3.11/site-packages (from dask[dataframe]) (2024.10.0)
Requirement already satisfied: packaging>=20.0 in /projeto/libs/lib/python3.11/site-packages (from dask[dataframe]) (24.1)
Requirement already satisfied: partd>=1.4.0 in /projeto/libs/lib/python3.11/site-packages (from dask[dataframe]) (1.4.2)
Requirement already satisfied: pyyaml>=5.3.1 in /usr/local/lib/python3.11/site-packages (from dask[dataframe]) (6.0)
Requirement already satisfied: toolz>=0.10.0 in /projeto/libs/lib/python3.11/site-packages (from dask[dataframe]) (1.0.0)
Requirement already satisfied: importlib-metadata>=4.13.0 in /projeto/libs/lib/python3.11/site-packages (from dask[dataframe]) (8.5.0)
Requirement already satisfied: pandas>=2.0 in /projeto/libs/lib/python3.11/site-packages (from dask[dataframe]) (2.2.3)
Collecting dask-expr<1.2,>=1.1 (from dask[dataframe])
  Using cached https://binarios.intranet.bb.com.br/artifactory/api/pypi/pypi/packages/packages/96/79/0f5c68663c10b3f400625efb0e544e0279639a0ea31997dda71e9bb65815/dask_expr-1.1.18-py3-none-any.whl (244 kB)
Requirement already satisfied: pyarrow>=14.0.1 in /projeto/libs/lib/python3.11/site-packages (from dask-expr<1.2,>=1.1->dask[dataframe]) (17.0.0)
Requirement already satisfied: zipp>=3.20 in /projeto/libs/lib/python3.11/site-packages (from importlib-metadata>=4.13.0->dask[dataframe]) (3.20.2)
Requirement already satisfied: numpy>=1.23.2 in /usr/local/lib/python3.11/site-packages (from pandas>=2.0->dask[dataframe]) (1.24.2)
Requirement already satisfied: python-dateutil>=2.8.2 in /usr/local/lib/python3.11/site-packages (from pandas>=2.0->dask[dataframe]) (2.8.2)
Requirement already satisfied: pytz>=2020.1 in /usr/local/lib/python3.11/site-packages (from pandas>=2.0->dask[dataframe]) (2022.7.1)
Requirement already satisfied: tzdata>=2022.7 in /projeto/libs/lib/python3.11/site-packages (from pandas>=2.0->dask[dataframe]) (2024.2)
Requirement already satisfied: locket in /projeto/libs/lib/python3.11/site-packages (from partd>=1.4.0->dask[dataframe]) (1.0.0)
Requirement already satisfied: six>=1.5 in /usr/local/lib/python3.11/site-packages (from python-dateutil>=2.8.2->pandas>=2.0->dask[dataframe]) (1.16.0)
Installing collected packages: dask-expr
Successfully installed dask-expr-1.1.18

I am worried because my requirements.txt contains "dask", not "dask[dataframe]"

The legacy (non dask-expr dependent) version will be removed soon. The difference is expected, yes. You should add dask[dataframe] to your requirements.txt file


Add schema and writer for 2.0 Core data

part of #6129

Add YAML schema for the 2.0 YAML Core data
Add a Core writer (will be used to convert MD to the 2.0 YAML)

related: https://github.com/RasaHQ/rasa/issues/6378

@degiz is it looking like we're going to make it into 2.0.0a2? how can we help you?


Adapter vercel split option breaks form action

Not sure if it might be related or not but I encounter another issue that happens in the exact same conditions.
Sadly I've been unable to find the time to create and deploy on Vercel a reproduction. Sorry if this is useless noise 🙏
Issue:
In a form action, I trigger an internal fetch call to a +server.ts route handler.
This route handler returns json data (return json({ ... })).
The route handler crashes with TypeError: immutable (full error below), and the action receives { message: 'Internal Error' }. Despite what the error message implies, I'm not trying to either set cookies or headers anywhere.
Conditions:

Only happens when deployed on Vercel
Only happens if the route handler is deployed separately (marked with split: true)

Error details
TypeError: immutable
    at _Headers.append (node:internal/deps/undici/undici:2105:17)
    at add_cookies_to_headers (file:///var/task/vercel/path0/apps/client/.svelte-kit/output/server/index.js:2320:13)
    at file:///var/task/vercel/path0/apps/client/.svelte-kit/output/server/index.js:2649:9
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async helpersHandle (file:///var/task/vercel/path0/apps/client/.svelte-kit/output/server/chunks/hooks.server.js:1181:18)
    at async respond (file:///var/task/vercel/path0/apps/client/.svelte-kit/output/server/index.js:2638:22)
    at async fetch (file:///var/task/vercel/path0/apps/client/.svelte-kit/output/server/index.js:2388:26)

Environment
    "@sveltejs/adapter-vercel": "3.1.0",
    "@sveltejs/kit": "1.30.4",
    "svelte": "4.2.12",

And Node.js 20.x on Vercel.
Originally posted by @benjaminwaterlot in https://github.com/sveltejs/kit/issues/11879#issuecomment-1971480386

@benjaminwaterlot please provide a downloadable minimal reproduction

I'm closing this until a minimal reproduction is made available.


[BUG]-GlsOccupancySensorBase (Type: glsOdtCcn) or one of it's variants has a null CommunicationMonitor object

Describe the bug
CommunicationMonitor object is null on instances of type glsOdcCcn which throws a null reference exception in the Fusion base SetUpError() method that set's up the Fusion error monitorin.

I'm pretty sure this is happening because of the changes made to device activation for the occupancy sensors. The Communication Monitor for those devices isn't created until the PreActivation phase, but the SetUpError method is currently called when the Fusion device is constructed. We can move those construction actions in the Fusion setup to a PostActivation step, which should prevent the error from happening.

I'm pretty sure this is happening because of the changes made to device activation for the occupancy sensors. The Communication Monitor for those devices isn't created until the PreActivation phase, but the SetUpError method is currently called when the Fusion device is constructed. We can move those construction actions in the Fusion setup to a PostActivation step, which should prevent the error from happening.

I was coming in here to post the same thing - I didn't think about that part of it when I made the changes to activation, but it makes perfect sense.  It probably affects any cresnet devices.
I think this probably would have been a problem regardless because if the fusion device is created for some reason before the cresnet device (or really any other device it's supposed to monitor) you're probably going to have this same issue.

I have already inadvertently solved this in another branch when I was working on my DualDisplay stuff. There is a collection of methods that got moved to be a PostActivation action for just this reason. It also affects any classes that inherit from the Fusion Base class, as many of the methods are virtual, and the correct methods may not be called when the construction of the object happens.


Unit tests for feedable / structural kwargs

Make a unit test that constructs every attack in the library.
Then use inspect.getfullargspec to get the argument list for the generate_function and check that:

all argument names appear in either structural_kwargs or feedable_kwargs
all structural_kwargs and feedable_kwargs appear in the list of argument names
no name is in both structural_kwargs and feedable_kwargs

or just drop the generate_np caching system.

Rather than a unit test, we just do the checks inside the call that reroutes generate_np to generate now.


Tweak Kubernetes pattern to handle Helm variables

Description:
This is a follow-up to #1462.
A comment left by @brampat made me realize that I hadn't covered all possible syntax for Helm variables.
Checklist:

[ ] Does your PR pass tests?
[ ] Have you written new tests for your changes?
[ ] Have you lint your code locally prior to submission?

v nice, thank you!

When can we expect this fix to be released in the gitleaks version? I'm currently on the latest (8.21.2) and I stall get false positives on the kubernetes Helm templates

This was included in v8.19.3. Mind sharing an example of the false positives you're seeing?

Okay, I see what went wrong. I exported the first version of the rule as a toml file. Those still triggered, which I didn't realise was causing the issue. I did a full clean checkout which didn't give any false positives, so that's where I was completely baffled. Then I saw the toml file and thought... wait a minute. I renamed them to filename.toml___ to disable them and that confirmed those caused the issue.


changes made for custom translation, dnt phrases

Support for custom translation and "Do Not Translate" (DNT) phrases is added for nmt.
Custom translations: Users can specify word or phrase pairs separated by double hash (##) in a line for custom translation handling.
DNT phrases: Words or phrases that should remain untranslated can be listed in the same file in separate lines.

LGTM, will wait for CI testing to complete


Enhacements

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

[x] Switch github/actions.
[x] Add config complete mailer.
[x] Update README.md.

tests pass in: https://github.com/terabytesoftw/mailer-swiftmailer/actions

👍


Reviews aren't showing up on the submission page, have to hit view all to see them

Going to close, this not seeing this anymore either.


Package to NPM + write some documentation

I found your repo on https://github.com/serverless-stack/sst/issues/2314
I don't know anything about Nuxt but I would be happy to help to publish the SST construct on NPM.
I think it would also need a bit of documentation about the changes that have to be made in the Nuxt config when someone uses the construct (I can't to this part 😅)

Hi Pierre,
The issue has to do with nuxt.
The package is suppose to be an adapter transforms a cloudfront request into something that nuxt can understand.
Nuxt expected the providers to be in typescript with a specific name however rollup was not accepting typescript in node_modules.


WIP: Change docker image to set a non-root user

Description of the change:
Change the docker image for not use root image in the scaffolded images.
Motivation for the change:

https://github.com/kubernetes-sigs/kubebuilder/issues/883
https://jira.coreos.com/browse/OSDK-473

Hond on for now


Can't detect/add Mellanox ConnectX-6 VFs via the plugin on my Openshift(on Openstack installation)

What happened?
I have configured the plugin look for my Mellanox ConnectX-6 VFs on my nodes - they are there and appear to be detected on the node but they are never added to the Resource Pools for some reason
What did you expect to happen?
VFs pulled into the respective pools so they can be used in my pods
What are the minimal steps needed to reproduce the bug?
Mellanox ConnectX-6 VFs made available on one or more of your Openshift nodes and configured plugin to try and find them
Anything else we need to know?
lspci output from node
05:00.0 Ethernet controller [0200]: Mellanox Technologies ConnectX Family mlx5Gen Virtual Function [15b3:101e]
Subsystem: Mellanox Technologies Device [15b3:0012]
Physical Slot: 0-4
Flags: bus master, fast devsel, latency 0
Memory at fba00000 (64-bit, prefetchable) [size=1M]
Capabilities: [60] Express Endpoint, MSI 00
Capabilities: [9c] MSI-X: Enable+ Count=12 Masked-
Capabilities: [100] Vendor Specific Information: ID=0000 Rev=0 Len=00c <?>
Kernel driver in use: mlx5_core
Kernel modules: mlx5_core
06:00.0 Ethernet controller [0200]: Mellanox Technologies ConnectX Family mlx5Gen Virtual Function [15b3:101e]
Subsystem: Mellanox Technologies Device [15b3:0012]
Physical Slot: 0-5
Flags: bus master, fast devsel, latency 0
Memory at fb800000 (64-bit, prefetchable) [size=1M]
Capabilities: [60] Express Endpoint, MSI 00
Capabilities: [9c] MSI-X: Enable+ Count=12 Masked-
Capabilities: [100] Vendor Specific Information: ID=0000 Rev=0 Len=00c <?>
Kernel driver in use: mlx5_core
Kernel modules: mlx5_core
Component Versions
Please fill in the below table with the version numbers of components used.

Component
Version

SR-IOV Network Device Plugin
3.7.0

SR-IOV CNI Plugin
Openshift 4.12.42

Multus
Openshift 4.12.42

Kubernetes
1.25

OS
Openshift 4.12/RHCOS 8.6

Config Files
ConfigMap
apiVersion: v1
kind: ConfigMap
metadata:
name: sriovdp-config
namespace: kube-system
data:
config.json: |
{
"resourceList": [
{
"resourceName": "sriov_client_side",
"resourcePrefix": "mellanox",
"selectors": {
"vendors": ["15b3"],
"devices": ["101e"],
"drivers": ["netdevice"],
"pciAddresses": ["0000:00:05.0"]
}
},
{
"resourceName": "sriov_server_side",
"resourcePrefix": "mellanox",
"selectors": {
"vendors": ["15b3"],
"devices": ["101e"],
"drivers": ["netdevice"],
"pciAddresses": ["0000:00:06.0"]
}
}
]
}
Device pool config file location (Try '/etc/pcidp/config.json')
Multus config (Try '/etc/cni/multus/net.d')
{"cniVersion":"0.4.0","name":"ovn-kubernetes","type":"ovn-k8s-cni-overlay","ipam":{},"dns":{},"logFile":"/var/log/ovn-kubernetes/ovn-k8s-cni-overlay.log","logLevel":"4","logfile-maxsize":100,"logfile-maxbackups":5,"logfile-maxage":5}sh-4.4#
CNI config (Try '/etc/cni/net.d/')
{ "cniVersion": "0.3.1", "name": "multus-cni-network", "type": "multus", "namespaceIsolation": true, "globalNamespaces": "default,openshift-multus,openshift-sriov-network-operator", "logLevel": "verbose", "binDir": "/opt/multus/bin", "readinessindicatorfile": "/var/run/multus/cni/net.d/10-ovn-kubernetes.conf", "kubeconfig": "/etc/kubernetes/cni/net.d/multus.d/multus.kubeconfig", "delegates": [ {"cniVersion":"0.4.0","name":"ovn-kubernetes","type":"ovn-k8s-cni-overlay","ipam":{},"dns":{},"logFile":"/var/log/ovn-kubernetes/ovn-k8s-cni-overlay.log","logLevel":"4","logfile-maxsize":100,"logfile-maxbackups":5,"logfile-maxage":5} ] }
Kubernetes deployment type ( Bare Metal, Kubeadm etc.)
Openshift 4.12.42
Kubeconfig file
SR-IOV Network Custom Resource Definition
Logs
SR-IOV Network Device Plugin Logs (use kubectl logs $PODNAME)
I0710 11:28:06.727499 1 manager.go:57] Using Kubelet Plugin Registry Mode
I0710 11:28:06.727846 1 main.go:46] resource manager reading configs
I0710 11:28:06.727909 1 manager.go:86] raw ResourceList: {
"resourceList": [
{
"resourceName": "sriov_client_side",
"resourcePrefix": "mellanox",
"selectors": {
"vendors": ["15b3"],
"devices": ["101e"],
"drivers": ["netdevice"],
"pciAddresses": ["0000:00:05.0"]
}
},
{
"resourceName": "sriov_server_side",
"resourcePrefix": "mellanox",
"selectors": {
"vendors": ["15b3"],
"devices": ["101e"],
"drivers": ["netdevice"],
"pciAddresses": ["0000:00:06.0"]
}
}
]
}
I0710 11:28:06.728042 1 factory.go:211] *types.NetDeviceSelectors for resource sriov_client_side is [0xc00042a900]
I0710 11:28:06.728085 1 factory.go:211] *types.NetDeviceSelectors for resource sriov_server_side is [0xc00042ac60]
I0710 11:28:06.728092 1 manager.go:106] unmarshalled ResourceList: [{ResourcePrefix:mellanox ResourceName:sriov_client_side DeviceType:netDevice ExcludeTopology:false Selectors:0xc000400eb8 AdditionalInfo:map[] SelectorObjs:[0xc00042a900]} {ResourcePrefix:mellanox ResourceName:sriov_server_side DeviceType:netDevice ExcludeTopology:false Selectors:0xc000400ed0 AdditionalInfo:map[] SelectorObjs:[0xc00042ac60]}]
I0710 11:28:06.728152 1 manager.go:217] validating resource name "mellanox/sriov_client_side"
I0710 11:28:06.728203 1 manager.go:217] validating resource name "mellanox/sriov_server_side"
I0710 11:28:06.728210 1 main.go:62] Discovering host devices
I0710 11:28:06.845790 1 auxNetDeviceProvider.go:84] auxnetdevice AddTargetDevices(): device found: 0000:03:00.0 02 Red Hat, Inc. Virtio 1.0 network device
I0710 11:28:06.845883 1 auxNetDeviceProvider.go:84] auxnetdevice AddTargetDevices(): device found: 0000:05:00.0 02 Mellanox Technolo... ConnectX Family mlx5Gen Virtual Function
I0710 11:28:06.845894 1 auxNetDeviceProvider.go:84] auxnetdevice AddTargetDevices(): device found: 0000:06:00.0 02 Mellanox Technolo... ConnectX Family mlx5Gen Virtual Function
I0710 11:28:06.845901 1 netDeviceProvider.go:67] netdevice AddTargetDevices(): device found: 0000:03:00.0 02 Red Hat, Inc. Virtio 1.0 network device
I0710 11:28:06.845942 1 netDeviceProvider.go:67] netdevice AddTargetDevices(): device found: 0000:05:00.0 02 Mellanox Technolo... ConnectX Family mlx5Gen Virtual Function
I0710 11:28:06.846313 1 netDeviceProvider.go:67] netdevice AddTargetDevices(): device found: 0000:06:00.0 02 Mellanox Technolo... ConnectX Family mlx5Gen Virtual Function
I0710 11:28:06.846510 1 main.go:68] Initializing resource servers
I0710 11:28:06.846526 1 manager.go:117] number of config: 2
I0710 11:28:06.846544 1 manager.go:121] Creating new ResourcePool: sriov_client_side
I0710 11:28:06.846548 1 manager.go:122] DeviceType: netDevice
I0710 11:28:06.847037 1 manager.go:138] initServers(): selector index 0 will register 0 devices
I0710 11:28:06.847055 1 manager.go:142] no devices in device pool, skipping creating resource server for sriov_client_side
I0710 11:28:06.847061 1 manager.go:121] Creating new ResourcePool: sriov_server_side
I0710 11:28:06.847066 1 manager.go:122] DeviceType: netDevice
I0710 11:28:06.847495 1 manager.go:138] initServers(): selector index 0 will register 0 devices
I0710 11:28:06.847512 1 manager.go:142] no devices in device pool, skipping creating resource server for sriov_server_side
I0710 11:28:06.847518 1 main.go:74] Starting all servers...
I0710 11:28:06.847523 1 main.go:79] All servers started.
I0710 11:28:06.847529 1 main.go:80] Listening for term signals
Multus logs (If enabled. Try '/var/log/multus.log' )
2024-07-10T11:04:25+00:00 [cnibincopy] Successfully moved files in /host/opt/cni/bin/upgrade_f3bb1262-de44-46c1-8d11-2b04b60ac649 to /host/opt/cni/bin/
2024-07-10T11:04:25+00:00 WARN: {unknown parameter "-"}
2024-07-10T11:04:25+00:00 Entrypoint skipped copying Multus binary.
2024-07-10T11:04:25+00:00 Generating Multus configuration file using files in /host/var/run/multus/cni/net.d...
2024-07-10T11:04:25+00:00 Attempting to find master plugin configuration, attempt 0
2024-07-10T11:04:29+00:00 Using MASTER_PLUGIN: 10-ovn-kubernetes.conf
2024-07-10T11:04:29+00:00 Nested capabilities string:
2024-07-10T11:04:29+00:00 Using /host/var/run/multus/cni/net.d/10-ovn-kubernetes.conf as a source to generate the Multus configuration
2024-07-10T11:04:29+00:00 Config file created @ /host/etc/cni/net.d/00-multus.conf
{ "cniVersion": "0.3.1", "name": "multus-cni-network", "type": "multus", "namespaceIsolation": true, "globalNamespaces": "default,openshift-multus,openshift-sriov-network-operator", "logLevel": "verbose", "binDir": "/opt/multus/bin", "readinessindicatorfile": "/var/run/multus/cni/net.d/10-ovn-kubernetes.conf", "kubeconfig": "/etc/kubernetes/cni/net.d/multus.d/multus.kubeconfig", "delegates": [ {"cniVersion":"0.4.0","name":"ovn-kubernetes","type":"ovn-k8s-cni-overlay","ipam":{},"dns":{},"logFile":"/var/log/ovn-kubernetes/ovn-k8s-cni-overlay.log","logLevel":"4","logfile-maxsize":100,"logfile-maxbackups":5,"logfile-maxage":5} ] }
2024-07-10T11:04:29+00:00 Entering watch loop...
Kubelet logs (journalctl -u kubelet)

The PCI address in the config  is not right.
your config: "pciAddresses": ["0000:00:06.0"]
the device discovered by the device plugin 0000:06:00.0

Hi - I corrected that error in the ConfigMap - but it was still the same end result of 0 devices being added
See updated output log below
I0715 12:48:59.624977       1 manager.go:57] Using Kubelet Plugin Registry Mode
I0715 12:48:59.626222       1 main.go:46] resource manager reading configs
I0715 12:48:59.626341       1 manager.go:86] raw ResourceList: {
"resourceList": [
    {
        "resourceName": "sriov_client_side",
        "resourcePrefix": "mellanox",
        "selectors": {
            "vendors": ["15b3"],
            "devices": ["101e"],
            "drivers": ["netdevice"],
            "pciAddresses": ["0000:05:00.0"]
        }
    },
    {
        "resourceName": "sriov_server_side",
        "resourcePrefix": "mellanox",
        "selectors": {
            "vendors": ["15b3"],
            "devices": ["101e"],
            "drivers": ["netdevice"],
            "pciAddresses": ["0000:06:00.0"]
        }
    }
  ]
}
I0715 12:48:59.626637       1 factory.go:211] *types.NetDeviceSelectors for resource sriov_client_side is [0xc00017c240]
I0715 12:48:59.626668       1 factory.go:211] *types.NetDeviceSelectors for resource sriov_server_side is [0xc00017c5a0]
I0715 12:48:59.626675       1 manager.go:106] unmarshalled ResourceList: [{ResourcePrefix:mellanox ResourceName:sriov_client_side DeviceType:netDevice ExcludeTopology:false Selectors:0xc00012c330 AdditionalInfo:map[] SelectorObjs:[0xc00017c240]} {ResourcePrefix:mellanox ResourceName:sriov_server_side DeviceType:netDevice ExcludeTopology:false Selectors:0xc00012c348 AdditionalInfo:map[] SelectorObjs:[0xc00017c5a0]}]
I0715 12:48:59.626862       1 manager.go:217] validating resource name "mellanox/sriov_client_side"
I0715 12:48:59.626893       1 manager.go:217] validating resource name "mellanox/sriov_server_side"
I0715 12:48:59.627022       1 main.go:62] Discovering host devices
I0715 12:48:59.726479       1 netDeviceProvider.go:67] netdevice AddTargetDevices(): device found: 0000:03:00.0	02          	Red Hat, Inc.       	Virtio 1.0 network device
I0715 12:48:59.726578       1 netDeviceProvider.go:67] netdevice AddTargetDevices(): device found: 0000:05:00.0	02          	Mellanox Technolo...	ConnectX Family mlx5Gen Virtual Function
I0715 12:48:59.727010       1 netDeviceProvider.go:67] netdevice AddTargetDevices(): device found: 0000:06:00.0	02          	Mellanox Technolo...	ConnectX Family mlx5Gen Virtual Function
I0715 12:48:59.727205       1 auxNetDeviceProvider.go:84] auxnetdevice AddTargetDevices(): device found: 0000:03:00.0	02          	Red Hat, Inc.       	Virtio 1.0 network device
I0715 12:48:59.727231       1 auxNetDeviceProvider.go:84] auxnetdevice AddTargetDevices(): device found: 0000:05:00.0	02          	Mellanox Technolo...	ConnectX Family mlx5Gen Virtual Function
I0715 12:48:59.727237       1 auxNetDeviceProvider.go:84] auxnetdevice AddTargetDevices(): device found: 0000:06:00.0	02          	Mellanox Technolo...	ConnectX Family mlx5Gen Virtual Function
I0715 12:48:59.727250       1 main.go:68] Initializing resource servers
I0715 12:48:59.727256       1 manager.go:117] number of config: 2
I0715 12:48:59.727267       1 manager.go:121] Creating new ResourcePool: sriov_client_side
I0715 12:48:59.727273       1 manager.go:122] DeviceType: netDevice
I0715 12:48:59.727797       1 manager.go:138] initServers(): selector index 0 will register 0 devices
I0715 12:48:59.727813       1 manager.go:142] no devices in device pool, skipping creating resource server for sriov_client_side
I0715 12:48:59.727819       1 manager.go:121] Creating new ResourcePool: sriov_server_side
I0715 12:48:59.727824       1 manager.go:122] DeviceType: netDevice
I0715 12:48:59.756721       1 manager.go:138] initServers(): selector index 0 will register 0 devices
I0715 12:48:59.756744       1 manager.go:142] no devices in device pool, skipping creating resource server for sriov_server_side
I0715 12:48:59.756750       1 main.go:74] Starting all servers...
I0715 12:48:59.756757       1 main.go:79] All servers started.
I0715 12:48:59.756762       1 main.go:80] Listening for term signals

one more step for virtual env can you remove
"vendors": ["15b3"],
            "devices": ["101e"],
            "drivers": ["netdevice"],

from the configmap please leave only the pciAddress

Noticed below line so brought the interface down before restarting device plugin pod
I0717 13:12:36.877186 1 utils.go:494] excluding interface enp5s0: default route found: {Ifindex: 3 Dst: <nil> Src: <IP_ADDRESS> Gw: <IP_ADDRESS> Flags: [] Table: 254 Realm: 0}
That seems to allow it to discover them OK.
I0717 14:14:23.049116 1 manager.go:57] Using Kubelet Plugin Registry Mode
I0717 14:14:23.050546 1 main.go:46] resource manager reading configs
I0717 14:14:23.050650 1 manager.go:86] raw ResourceList: {
"resourceList": [
{
"resourceName": "sriov_client_side",
"resourcePrefix": "mellanox",
"selectors": {
"pciAddresses": ["0000:05:00.0"]
}
},
{
"resourceName": "sriov_internet_side",
"resourcePrefix": "mellanox",
"selectors": {
"pciAddresses": ["0000:06:00.0"]
}
}
]
}
I0717 14:14:23.051034 1 factory.go:211] *types.NetDeviceSelectors for resource sriov_client_side is [0xc0001d8240]
I0717 14:14:23.051117 1 factory.go:211] *types.NetDeviceSelectors for resource sriov_internet_side is [0xc0000df440]
I0717 14:14:23.051970 1 manager.go:106] unmarshalled ResourceList: [{ResourcePrefix:mellanox ResourceName:sriov_client_side DeviceType:netDevice ExcludeTopology:false Selectors:0xc00019a330 AdditionalInfo:map[] SelectorObjs:[0xc0001d8240]} {ResourcePrefix:mellanox ResourceName:sriov_internet_side DeviceType:netDevice ExcludeTopology:false Selectors:0xc00019a348 AdditionalInfo:map[] SelectorObjs:[0xc0000df440]}]
I0717 14:14:23.052090 1 manager.go:217] validating resource name "mellanox/sriov_client_side"
I0717 14:14:23.052128 1 manager.go:217] validating resource name "mellanox/sriov_internet_side"
I0717 14:14:23.052139 1 main.go:62] Discovering host devices
I0717 14:14:23.136162 1 netDeviceProvider.go:67] netdevice AddTargetDevices(): device found: 0000:03:00.0 02 Red Hat, Inc. Virtio 1.0 network device
I0717 14:14:23.136287 1 netDeviceProvider.go:67] netdevice AddTargetDevices(): device found: 0000:05:00.0 02 Mellanox Technolo... ConnectX Family mlx5Gen Virtual Function
I0717 14:14:23.136791 1 netDeviceProvider.go:67] netdevice AddTargetDevices(): device found: 0000:06:00.0 02 Mellanox Technolo... ConnectX Family mlx5Gen Virtual Function
I0717 14:14:23.137021 1 auxNetDeviceProvider.go:84] auxnetdevice AddTargetDevices(): device found: 0000:03:00.0 02 Red Hat, Inc. Virtio 1.0 network device
I0717 14:14:23.137054 1 auxNetDeviceProvider.go:84] auxnetdevice AddTargetDevices(): device found: 0000:05:00.0 02 Mellanox Technolo... ConnectX Family mlx5Gen Virtual Function
I0717 14:14:23.137062 1 auxNetDeviceProvider.go:84] auxnetdevice AddTargetDevices(): device found: 0000:06:00.0 02 Mellanox Technolo... ConnectX Family mlx5Gen Virtual Function
I0717 14:14:23.137081 1 main.go:68] Initializing resource servers
I0717 14:14:23.137088 1 manager.go:117] number of config: 2
I0717 14:14:23.137101 1 manager.go:121] Creating new ResourcePool: sriov_client_side
I0717 14:14:23.137106 1 manager.go:122] DeviceType: netDevice
I0717 14:14:23.137648 1 manager.go:138] initServers(): selector index 0 will register 1 devices
I0717 14:14:23.137683 1 factory.go:124] device added: [identifier: 0000:05:00.0, vendor: 15b3, device: 101e, driver: mlx5_core]
I0717 14:14:23.137722 1 manager.go:156] New resource server is created for sriov_client_side ResourcePool
I0717 14:14:23.137731 1 manager.go:121] Creating new ResourcePool: sriov_internet_side
I0717 14:14:23.137736 1 manager.go:122] DeviceType: netDevice
I0717 14:14:23.138214 1 manager.go:138] initServers(): selector index 0 will register 1 devices
I0717 14:14:23.138237 1 factory.go:124] device added: [identifier: 0000:06:00.0, vendor: 15b3, device: 101e, driver: mlx5_core]
I0717 14:14:23.138253 1 manager.go:156] New resource server is created for sriov_internet_side ResourcePool
I0717 14:14:23.138260 1 main.go:74] Starting all servers...
I0717 14:14:23.138492 1 server.go:255] starting sriov_client_side device plugin endpoint at: mellanox_sriov_client_side.sock
I0717 14:14:23.139287 1 server.go:297] sriov_client_side device plugin endpoint started serving
I0717 14:14:23.139413 1 server.go:255] starting sriov_internet_side device plugin endpoint at: mellanox_sriov_internet_side.sock
I0717 14:14:23.139732 1 server.go:297] sriov_internet_side device plugin endpoint started serving
I0717 14:14:23.139752 1 main.go:79] All servers started.
I0717 14:14:23.139759 1 main.go:80] Listening for term signals

Any idea why it didn't like the more specific filters?  We were able to use these with our Intel based cards.

Added back in the vendors and devices attributes and that worked also - so it seemed it didn't like the netdevice driver
We use vfio-pci for our Intel cards and Openshift documentation had pointed us at setting netdevice for Mellanox cards -  just for background on why we had used that
I0717 16:42:30.242700 1 manager.go:86] raw ResourceList: {
"resourceList": [
{
"resourceName": "sriov_client_side",
"resourcePrefix": "mellanox",
"selectors": {
"vendors": ["15b3"],
"devices": ["101e"],
"pciAddresses": ["0000:05:00.0"]
}
},
{
"resourceName": "sriov_internet_side",
"resourcePrefix": "mellanox",
"selectors": {
"vendors": ["15b3"],
"devices": ["101e"],
"pciAddresses": ["0000:06:00.0"]
}
}
]
}
I0717 16:42:30.242817 1 factory.go:211] *types.NetDeviceSelectors for resource sriov_client_side is [0xc00052a900]
I0717 16:42:30.242846 1 factory.go:211] *types.NetDeviceSelectors for resource sriov_internet_side is [0xc00052ac60]
I0717 16:42:30.242852 1 manager.go:106] unmarshalled ResourceList: [{ResourcePrefix:mellanox ResourceName:sriov_client_side DeviceType:netDevice ExcludeTopology:false Selectors:0xc000500e88 AdditionalInfo:map[] SelectorObjs:[0xc00052a900]} {ResourcePrefix:mellanox ResourceName:sriov_internet_side DeviceType:netDevice ExcludeTopology:false Selectors:0xc000500ea0 AdditionalInfo:map[] SelectorObjs:[0xc00052ac60]}]
I0717 16:42:30.242942 1 manager.go:217] validating resource name "mellanox/sriov_client_side"
I0717 16:42:30.242967 1 manager.go:217] validating resource name "mellanox/sriov_internet_side"
I0717 16:42:30.242973 1 main.go:62] Discovering host devices
I0717 16:42:30.320299 1 auxNetDeviceProvider.go:84] auxnetdevice AddTargetDevices(): device found: 0000:03:00.0 02 Red Hat, Inc. Virtio 1.0 network device
I0717 16:42:30.320385 1 auxNetDeviceProvider.go:84] auxnetdevice AddTargetDevices(): device found: 0000:05:00.0 02 Mellanox Technolo... ConnectX Family mlx5Gen Virtual Function
I0717 16:42:30.320394 1 auxNetDeviceProvider.go:84] auxnetdevice AddTargetDevices(): device found: 0000:06:00.0 02 Mellanox Technolo... ConnectX Family mlx5Gen Virtual Function
I0717 16:42:30.320403 1 netDeviceProvider.go:67] netdevice AddTargetDevices(): device found: 0000:03:00.0 02 Red Hat, Inc. Virtio 1.0 network device
I0717 16:42:30.320463 1 netDeviceProvider.go:67] netdevice AddTargetDevices(): device found: 0000:05:00.0 02 Mellanox Technolo... ConnectX Family mlx5Gen Virtual Function
I0717 16:42:30.320866 1 netDeviceProvider.go:67] netdevice AddTargetDevices(): device found: 0000:06:00.0 02 Mellanox Technolo... ConnectX Family mlx5Gen Virtual Function
I0717 16:42:30.321290 1 main.go:68] Initializing resource servers
I0717 16:42:30.321316 1 manager.go:117] number of config: 2
I0717 16:42:30.321338 1 manager.go:121] Creating new ResourcePool: sriov_client_side
I0717 16:42:30.321347 1 manager.go:122] DeviceType: netDevice
I0717 16:42:30.322346 1 manager.go:138] initServers(): selector index 0 will register 1 devices
I0717 16:42:30.322390 1 factory.go:124] device added: [identifier: 0000:05:00.0, vendor: 15b3, device: 101e, driver: mlx5_core]
I0717 16:42:30.322444 1 manager.go:156] New resource server is created for sriov_client_side ResourcePool
I0717 16:42:30.322460 1 manager.go:121] Creating new ResourcePool: sriov_internet_side
I0717 16:42:30.322464 1 manager.go:122] DeviceType: netDevice
I0717 16:42:30.322978 1 manager.go:138] initServers(): selector index 0 will register 1 devices
I0717 16:42:30.323000 1 factory.go:124] device added: [identifier: 0000:06:00.0, vendor: 15b3, device: 101e, driver: mlx5_core]
I0717 16:42:30.323027 1 manager.go:156] New resource server is created for sriov_internet_side ResourcePool
I0717 16:42:30.323035 1 main.go:74] Starting all servers...
I0717 16:42:30.323324 1 server.go:255] starting sriov_client_side device plugin endpoint at: mellanox_sriov_client_side.sock
I0717 16:42:30.324284 1 server.go:297] sriov_client_side device plugin endpoint started serving
I0717 16:42:30.324699 1 server.go:255] starting sriov_internet_side device plugin endpoint at: mellanox_sriov_internet_side.sock
I0717 16:42:30.325092 1 server.go:297] sriov_internet_side device plugin endpoint started serving
I0717 16:42:30.325115 1 main.go:79] All servers started.
I0717 16:42:30.325123 1 main.go:80] Listening for term signals
I0717 16:42:30.780189 1 server.go:117] Plugin: mellanox_sriov_client_side.sock gets registered successfully at Kubelet
I0717 16:42:30.780439 1 server.go:117] Plugin: mellanox_sriov_internet_side.sock gets registered successfully at Kubelet
I0717 16:42:30.780571 1 server.go:158] ListAndWatch(sriov_client_side) invoked
I0717 16:42:30.780621 1 server.go:171] ListAndWatch(sriov_client_side): send devices &ListAndWatchResponse{Devices:[]*Device{&Device{ID:0000:05:00.0,Health:Healthy,Topology:nil,},},}
I0717 16:42:30.780561 1 server.go:158] ListAndWatch(sriov_internet_side) invoked
I0717 16:42:30.780719 1 server.go:171] ListAndWatch(sriov_internet_side): send devices &ListAndWatchResponse{Devices:[]*Device{&Device{ID:0000:06:00.0,Health:Healthy,Topology:nil,},},}

Yes please go ahead and close.
Thanks for the help


Bcloutier/reogranize json output

Sorry I haven't been able to be more active, work went crazy. Hoping to be back at it this weekend.

Sorry I haven't been able to be more active, work went crazy. Hoping to be back at it this weekend.

I understand. As for my plans, I think the next version of the mod will be for the 1.21 release, and I will also publish it to CurseForge and Modrinth. If you want, you can also help with this. So it's better to finish this pull before the release.

I would be happy to help with that. I will wrap up that PR quickly and then
whatever else you need me to do to help for the 121 release let me know.
On Sun, May 19, 2024 at 5:45 PM Illia Diadenchuk @.***>
wrote:

Sorry I haven't been able to be more active, work went crazy. Hoping to be
back at it this weekend.
I understand. As for my plans, I think the next version of the mod will be
for the 1.21 release, and I will also publish it to CurseForge and
Modrinth. If you want, you can also help with this. So it's better to
finish this pull before the release.
—
Reply to this email directly, view it on GitHub
https://github.com/dadencukillia/httpInfoServer-mod/pull/2#issuecomment-2119368867,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABK6K2HCUYQR6HZ7K2G2J33ZDEMOLAVCNFSM6AAAAABGX5ID6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGM3DQOBWG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Great. Since the release is already out, we can update to 1.21 in this PR.

Sounds good, planning to work on this tomorrow morning.

Sounds good, planning to work on this tomorrow morning.

Updated to 1.20.6 support. Looking at the fabric dev site the only 1.21 support is for the last snapshot. I am playing around with that.

Oh, sorry, I didn't see the comment. Well, I see the changes have been made for the better and now it does support minecraft 1.20.6. There will be no problems with the update for Minecraft version 1.21. Thank you for your help, maybe if you want to support this project with another Pull Request, I will be happy to work with you again. I will now add the project to the CurseForge and Modrinth platforms.
Translated with DeepL.com (free version)

@dadencukillia I would like to continue to work on the project. Do you have anything you need done currently? If not, I will open a PR with some ideas I have to adding information to the output.

Perfectly. You can open a new pull request


Redirect with error "Location" header will broke the ZIO action.

https://github.com/softwaremill/sttp/blob/b365f2cf6edd8669480a21732ca44076fc9bd35d/core/src/main/scala/sttp/client3/FollowRedirectsBackend.scala#L60
Following the code in line 58 & 60. If the Location is not start with /, http nor https, the ZIO Async Backend will broke the whole ZIO action and can not catch any Exception.
Like the code:
for {
  uri1        <- ZIO.effect(Uri.unsafeParse(ac.baseUrl))
  response1   <- ZIO.effect(sendRequestUri(uri1))
  response    <- response1.mapError(new UriRequestError(_)) // Can not catch with the Response's Location Header is oldnews_html.asp?newsid=3278
} yield response

I think there's two way to fix.
One is catch the exception.
The other is catch the exception and resolve the url to the real path. Because this url write in Location(oldnews_html.asp?newsid=3278) works fine in firefox.

Do I understand correctly that the problem is with a redirect which points to a relative address, e.g. Location: xyz.html?
The fix than would be to patch the isRelative function to properly determine if the request is relative?

Do I understand correctly that the problem is with a redirect which points to a relative address, e.g. Location: xyz.html?

Yes.

The fix than would be to patch the isRelative function to properly determine if the request is relative?

Now my problem is ZIO cannot catch the exception when code is outside ZIO.effect and so on. Like
val action = for {
  i1 <- ZIO.effect(action1)
  i2 = throw new Exception()
  i3 <- ZIO.effect(action2)
} yield i3

action.mapError((e: Throwable) => UriParseError(e))

In this code, action can not route to UriParseError bacause i2 is not catch. But I need to do something when the request is failed.
i2 in sttp is the code
uri"${url}"

this function will throw error when parse is fail.

See the linked PR, this should fix relative detection.
I don't understand however why you cannot handle the exceptions coming from the uri parsing.This is an ordinary IllegalArgumentException, so it should be possible to handle it like any other.

Yes, this can slove my problem. The problem that handle exceptions is more better to ask in zio. If I have some examples of a production environment, I will ask this question in zio/zio.


Bump 2.13 to 2.13.0-M5, use scalatest 3.0.6-SNAP5 unconditionally

Fix for the sbt nightly (1.2.x branch)

To validate this pull request against other sbt modules, please visit this link.

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4471/head
sbt/sbt@9e4e16b7f09ae978518a9e5d1d53705e7e4b7c2c

zinc
1.2.x
sbt/zinc@95be1e1beacd983b29d59e2626fc91198c55f65b

io
pull/205/head
sbt/io@dfa2b3cc46e3434e72b15587b05ec5b5873b9f52

librarymanagement
1.2.x
sbt/librarymanagement@a56242036e1c3463bcf90744fa8cb392fdce6d09

util
1.2.x
sbt/util@016858ddd8601f9d55224d2b6ec9b046cf8e29d9

:white_check_mark: The result is: SUCCESS
(restart)

Closing this in favor of https://github.com/sbt/io/pull/206


FindMatch() not working if pattern contains box bracket characters

Please check our current Issues to see if someone already reported this https://github.com/Microsoft/azure-pipelines-task-lib/issues
Environment
azure-pipelines-task-lib version: 2.8.0
Issue Description
FindMatch() is unable to find matching pattern if input pattern contains box bracket ('[' or ']') characters.
Logs
Logs are attached with this issue.

We use minimatch to find things. I believe [ and ] are special characters, so escaping should fix the problem

@damccorm
Tried modifying the task and found out that in case of special characters, escaping is working with Ubuntu agents but not with Windows. Seems something related to back or forward slashes in file paths.
I can see a related issue https://github.com/NuGet/Home/issues/3584 with Glob pattern.

Could you share your repro? Minimatch should be able to handle that I believe, if I'm understanding the issue correctly.

@vinodkumar3 any update?

PFA logs with updated ARM task (added modification of escaping special characters in file path, '[' & ']' in this example) where Ubuntu is correctly finding the path but Windows doesn't.
ububtu-escape.zip
windows-escape.zip

It looks to me like you're escaping incorrectly on windows.
On Ubuntu, the pattern is: /home/vsts/work/1/s/a \[abc\] Subscription Deploy/resourcegroup.json
On windows, its: d:\a\1\s\a \[abc\] Subscription Deploy\resourcegroup.json
Note that in the windows version, the way you currently have it escaped there's no way to distinguish between a path seperator (\) and the escaping backslash.
With that said, escaping minimatch on Windows is weird, see - https://github.com/isaacs/node-glob/issues/212. We have docs on how to do this here.

@damccorm
Thanks for pointing me to the right documentation. This is something I was missing. You may close the issue now.


Twilio integration

@kyle-rosenbluth do you want me to review?

Not yet, I'll ping you later tonight when it's ready
On Wed, Nov 11, 2015 at 11:02 PM Ben Sandler<EMAIL_ADDRESS>wrote:

@kyle-rosenbluth https://github.com/kyle-rosenbluth do you want me to
review?
—
Reply to this email directly or view it on GitHub
https://github.com/hack4impact/clean-air-council/pull/29#issuecomment-155992055
.

r @nancywong @kyle-rosenbluth @kongsally

also lol these temp commits are killing me. if you feel inclined / comfortable enough with rebasing or cherry-picking, i'd make a local copy of this branch and rebase it to clean up the commit history :) rebase + squashing commits would probably be easier than cherry-picking, but that could work also.

@nancywong I made a noble attempt to clean up the git history and failed. It turns out that when you rewrite the git history with git rebase -i you have to re-resolve EVERY merge conflict that occurred (which is insane). I actually attempted to do this, but things got pretty screwed up so I reset back.
Interesting article on how to use the git rerere feature so git remembers how you solve merge conflicts

@nancywong look good now?

This might be just what we're looking for http://stackoverflow.com/questions/15915430/what-exactly-does-gits-rebase-preserve-merges-do-and-why


Fix non-standard pseudo-instructions of RISC-V

Fixes #41100.

CC: @soburi

@nandojve

CC: @soburi

I verified this change works fine with #34970, and no need for an additional patch.
(No jalr instruction in this #34970)

@henry-hsieh
CI is cancelled... Please try again to rebase and push.

@henry-hsieh
Thanks!
@cfriedt
I think this PR is ready to merge. Would you check and merge if no problem?


[QSRs] Simultaneous computation of multiple QSRs does not allow for individual dynamic_args

The new feature of computing multiple QSRs with one service call does not allow to pass individual parameters. E.g. quantisation_factor for qtcbs and mos are forced to use the same. These keys need to be uniquely renamed. In fact, all parameters belonging to a QSR should have a namespace. Easiest way to do this is to prefix with their short unique name.

Regarding the actual name space, so we both implement the same, should it be:
{"qtc": {"quantisation_factor": 0.01, ...}}

or just
"qtc_quantisation_factor"

I do like the first one better as it appears more pythonic to me and prevents me from prefixing 5 parameters for every qtc variant.

+1 on first also without doubt, more "effort" but more dynamic. String prefix less effort but less dynamic.

While altering all this, I think it would make sense to also change the names of the QSRs in the example client to the new short versions, i.e. qtcb to qtcbs. I can quickly do that while implementing the namespaces because then I can just take that string as the namespace as well.

+1


Fix _LocIndexerLike and align_diff_series.

DataFrame (DataFrame.loc) should be able to handle a Series from index as well:

before

>>> import databricks.koalas as ks
>>> kdf = ks.DataFrame({('x','a'):[1,2,3], ('y','b'):[4,5,6]})
>>> kser = kdf.index.to_series()
>>> kser
0    0
1    1
2    2
Name: 0, dtype: int64
>>> kdf[[kser]]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/ueshin/workspace/databricks-koalas/master/databricks/koalas/frame.py", line 9306, in __getitem__
    return self.loc[:, key]
  File "/Users/ueshin/workspace/databricks-koalas/master/databricks/koalas/indexing.py", line 286, in __getitem__
    column_label_names=column_label_names,
  File "/Users/ueshin/workspace/databricks-koalas/master/databricks/koalas/internal.py", line 523, in __init__
    len(self._column_scols),
AssertionError: (1, 0)

after

>>> kdf[[kser]]
   0
0  0
1  1
2  2

Resolves #1305.

also cc @itholic

Codecov Report

Merging #1315 into master will decrease coverage by 2.34%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
- Coverage   95.23%   92.89%   -2.35%
==========================================
  Files          34       34
  Lines        7331     7342      +11
==========================================
- Hits         6982     6820     -162
- Misses        349      522     +173

Impacted Files
Coverage Δ

databricks/koalas/utils.py
94.94% <100%> (-0.03%)
:arrow_down:

databricks/koalas/indexing.py
95.83% <93.75%> (-0.15%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
24.32% <0%> (-71.18%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
78.72% <0%> (-14.9%)
:arrow_down:

databricks/conftest.py
88.67% <0%> (-7.55%)
:arrow_down:

databricks/koalas/frame.py
93.54% <0%> (-3.18%)
:arrow_down:

databricks/koalas/namespace.py
86.3% <0%> (-1.49%)
:arrow_down:

databricks/koalas/plot.py
93.33% <0%> (-0.96%)
:arrow_down:

databricks/koalas/testing/utils.py
78.26% <0%> (-0.73%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65716a3...4b7d392. Read the comment docs.

Ah, that's what i want 😸

LGTM

Thanks! merging.


feat/CIV-2649

LRvLR: 1v2 different sol - Camunda changes
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-2649
Change description
LRvLR: 1v2 different sol - Camunda changes
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x ] No

closing it


Update dependencies

Addresses:
https://security.snyk.io/vuln/SNYK-GOLANG-GOLANGORGXTEXTINTERNALLANGUAGE-2400718

Thanks for contribution !


support pydantic v2

Hi! great to see this useful tool!
Cross posting from FastAPI discussions :wink:
I just tried it, but unfortunately it doesn't work with pydantic v2.
It crashes because it can't find pydantic.fields.ModelField, that is removed in facor of a cls.model_fields, which is a dict[str, FieldInfo].
Obviously there will be other error, but I couldn't find the time to investigate it further.

Almost finished work :)
But need to wait for it - https://github.com/tiangolo/fastapi/pull/9925

I made a fork with support for version 2 -
https://github.com/AezaGroup/pyfa-converter-v2


Best Parameters For Transformer Model on WMT 2014?

Hello,
I am a research assistant who is part of a team that is profiling machine learning frameworks across different applications. Among other applications, I am studying the transformer model applied to translation tasks. I would like to know if there is a listing of the best settings to use with this framework to reproduce the results in the "Attention Is All You Need" paper.
Thank you

Hi,
sorry for taking a little bit to respond to this.
Exactly reproducing the results of the "Attention Is all You Need" paper may be tricky, as there are some small differences in the toolkits you may not be able to remove completely (batching & bucketing and how data is organized in general).
However, you should be able to train a transformer model that is parameterized almost exactly like the Attention Is All You Need paper by using the existing commandline flags that start with --transformer (model size, number of attention heads, feed-forward-size etc.)
Training-specific flags like --batch-type word --batch-size 4096, or transformer-specific dropout settings and methods like label smoothing are also available.

Closing this for now, feel free to reopen if you have further questions.


DBZ-2592 Minor improvements on the release contributors script

https://issues.redhat.com/browse/DBZ-2592
Re https://github.com/r-ballard[unknown], this contributor has a username but no Author name in his GitHub profile, hence it returns unknown.

Great job, thanks a lot, @ani-sha!


[Event Request] table 5406 "Prod. Order Line" - OnValidateItemNoOnBeforeValidateUnitOfMeasureCode

We would like to add a new event OnValidateItemNoOnBeforeValidateUnitOfMeasureCode in the following trigger:
                OnValidateItemNoOnAfterAssignItemValues(Rec, Item);
                if "Item No." <> xRec."Item No." then begin
                    Validate("Production BOM No.", Item."Production BOM No.");
                    Validate("Routing No.", Item."Routing No.");
                    //A108F0000.Event18.03.ns
                    IsHandled := false;
                    OnValidateItemNoOnBeforeValidateUnitOfMeasureCode(ProdOrder, Rec, xRec, Item, IsHandled);
                    If not IsHandled then
                        //A108F0000.Event18.03.ns
                        Validate("Unit of Measure Code", Item."Base Unit of Measure");
                end;
                OnAfterCopyFromItem(Rec, Item, xRec);

Event Signature:
[IntegrationEvent(false, false)]
local procedure OnValidateItemNoOnBeforeValidateUnitOfMeasureCode(var ProductionOrder: Record "Production Order"; var ProdOrderLine: Record "Prod. Order Line"; xProdOrderLine: Record "Prod. Order Line"; var Item: Record Item; var IsHandled: Boolean)
begin
    //A108F0000.Event18.03
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


changedSince runs specs related to files with no diff

🐛 Bug Report
Using the --changedSince flag, Jest will run specs related to files with no current code changes (no diff) but which were previously committed.
The description of this flag is: Runs tests related to the changes since the provided branch. I would expect changes in this context to mean code changes between the current and specified revision, not each individual commit.

To Reproduce
Steps to reproduce the behavior:

Check out a new branch from master
Commit a change to any file (example.js) which has a related spec (example.test.js). Adding a comment will do.
Remove the change to this file & commit again.
Check that there are no current changes with git diff origin/master. There should be none.
Run jest --changedSince origin/master
Output will show that example.test.js was run, even though example.js has no changes.

Expected behavior
example.test.js does not run

Link to repl or repo (highly encouraged)
https://github.com/finn-orsini/jest-changed-since-bug-poc

Run yarn
Check out branch changed_since_no_changes (See PR showing no code changes here)
Run yarn test

Output will show that sum.test.js was run:
$ jest --changedSince origin/master
 PASS  src/__tests__/sum.test.js
  ✓ adds 1 + 2 to equal 3 (4ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        1.119s

Note that running git log --name-only --pretty=format: HEAD ^origin/master (the command run by jest-changed-files) on this branch will include sum.js since a comment was added and removed in previous commits.

envinfo

  System:
    OS: macOS Mojave 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
  Binaries:
    Node: 8.16.2 - ~/.nvm/versions/node/v8.16.2/bin/node
    Yarn: 1.21.1 - ~/.nvm/versions/node/v8.16.2/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v8.16.2/bin/npm
  npmPackages:
    jest: ^24.9.0 => 24.9.0

This is because we use git log rather than git diff, see https://github.com/facebook/jest/blob/56565cc04c7261c5a3222a0547bea58c024ec0b8/packages/jest-changed-files/src/git.ts#L53-L74
I do agree this is not expected, though. @alsuren do you remember why you went with log rather than diff?
/cc @thymikee @jeysal do you agree it's not expected behavior?

Yea, seems like diff makes more sense here. I wouldn't expect running tests for files that were changed+unchanged in the meantime.

The reason I use log is quite subtle when you're looking at the code, but it's also crucial to my workflow.
I use jest --watch --changedSince=origin/master as my go-to command for testing my work. If I fetch master, and don't rebase my local branch, I don't want to suddenly start testing all of the files for changes that other people have added to master.
I searched for quite a long time for a "please tell me which files would change if I merged my current branch into master" git invocation, but I couldn't work out how to express it.
Does anyone know of a good way to express this in git?

hrm...
       git diff [<options>] <commit>...<commit> [--] [<path>...]
           This form is to view the changes on the branch containing and up to the second <commit>,
           starting at a common ancestor of both <commit>. "git diff A...B" is equivalent to "git diff
           $(git merge-base A B) B". You can omit any one of <commit>, which has the same effect as using
           HEAD instead.

maybe ... would do what we want?
@finn-orsini do you want to try making a fix for this, or should I pick it up? (I probably won't time until Tuesday though)

@alsuren yeah I can give it a shot this afternoon! Thanks!

One other thing that we should be aware of when fixing this is that some people abuse the "resolve conflicts" button on github ( https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github ) rather than rebasing when there are conflicts. (this is a behaviour that I only observed in the last few months)
These people might end up with quite a lot of spurious tests being run under a diff-based changeSince implementation.
master HEAD
     | x <- conflict resolution 2
     |/|
C -> x |
     | x <- conflict resolution 1
     |/|
B -> x |
     | x <- A
     |/
     |
common ancestor

If someone is sitting at HEAD, will changedSince see changes related to A and any conflicts that happened, or will it also see unrelated changes from B and C?
What happens if people are merging master into their branch purely to fix CI issues, and there aren't even any conflicts? (I think I might be seeing this behaviour on my current project too, because our CI is set up to test branch-tips without merging with master first :-( ).

Great point!
The current project I'm working on is extremely merge-heavy, so, unfortunately, that is something I would like to account for (and I'm fairly sure is why we noticed issues in --changedSince).
I'm going to experiment with the diff only approach as well as comparing the output of log and diff - If neither of these are satisfactory for --changedSince, would adding a different option (maybe --diffAgainst) be a decent compromise?

@finn-orsini
Is there an update on this one? Do you need any assistance?

Yeah, can we keep this moving? I'm also happy to help if needed @finn-orsini @alsuren @SimenB

Sorry for the delay here, no excuse other than just totally dropped this from my radar.
I have a fork with what I think was a working fix from when this was originally posted, will double-check it tomorrow morning & post an update here.
Thanks for bearing with me!

:wave: Hi @matthew-hallsworth, I believe @SimenB was waiting to see if anyone else wanted to weigh in on the PR. It has been approved, but I do not have access to merge 👍

#10155

Fix released in 26.2.0

I don't know where to ask this question so I'm putting it here, Is there any flag in jest that I can use to check all the test files where my small change might have an impact? Or this is impossible?