Cluster creation gets stuck while provisioning

What steps did you take and what happened:
Following the quickstart guide. Once I install the OS and reboot, I see the elemental-system-agent (ESA) get preemepted by the rancher-system-agent (RSA) but then the RSA sits there and doesn't install k3s.
At this point, I can see that everything is set up correctly in the upstream CRDs but the MachineInventory is stuck waiting for the plan to be applied. The discrepancy between the applied and plan checksum in the status field shows this to be the case.
When I log into the host and view the journal for ESA, I see that the plan was indeed applied and that the MachineInventory status is not correct. Since I've seen this before, I guessed that it was because the status didn't get synced before the RSA started and stopped the ESA from running.
A workaround to get my cluster up and running is to run these commands:

systemctl stop rancher-system-agent
mv rancher-system-agent.service rancher-system-agent.service.back
systemctl start elemental-system-agent
sleep 5
systemctl stop elemental-system-agent
mv rancher-system-agent.service.back rancher-system-agent.service
systemctl start rancher-system-agent

The cluster should start being provisioned after this.
What did you expect to happen:
I expect the cluster to be created without manual intervention.
Anything else you would like to add:
I'll be demoing to the community in a master class next Wednesday and would prefer to not need a manual workaround for this.
Environment:

Elemental release version (use cat /etc/os-release): 0.6.0
Rancher version: 2.6.7
Kubernetes version (use kubectl version): upstream  1.24.10+k3s1 -- downstream v1.23.7+k3s1
Cloud provider or hardware configuration: digital ocean upstream -- Intel NUCs downstream

rancher-system-agent (RSA)  tears down the elemental-system-agent (ESA) before moving on to the cluster provisioning plan.
In this case as stated above it does it a bit too early, likely before the ESA is able to communicate that the rancher-system-agent deployment plan was successful.
Proper solution is to rework the handover from ESA to RSA.
In the meanwhile, one trick that would help is to wait stopping the elemental-system-agent when the stop command is received.
Adding a section like ExecStop=sleep 10 to the elemental-system-agent.service in the ISO should make the trick.
I tested adding a long delay (5  minutes) before tearing down the elemental-system-agent. That required to change also the default stop timeout in systemd for the ESA service:
ExecStop=sleep 300
TimeoutStopSec=6min
While this worked, the issue with a long timeout is that no other plans will be executed till elemental-system-agent stop one is completed, so the cluster installation had to wait quite a bit (5 minutes).

Opened a PR, yep looks really low risk.
Another work around (shared by @davidcassany ) could be to just avoid disabling the elemental-system-agent at all. This would require a change in the operator.
Would leave the proper fix for later as would require surely more time (and would be more invasive).

A good follow up for this issue could be a two step action point:

Further experiment with sharing elemental-system-agent and rancher-system-agent configuration options. Is there a chance that one replace the other or one handles the plans of the other? This on early days miserably failed, but at that point we were not familiar or properly knowing with the full cycle.
With all the gathered knowledge get in contact with system-agent and provisioning team so we can eventually evaluate the chances of adapting the pieces for our use case.


revert script name for now

Pull Request Test Coverage Report for Build 17b40f4c062d4cfaa639c0d40adb8749e79cc569-PR-988

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.826%

Totals

Change from base Build dd67baf6294b0b84dcb4825da51a00b8ca97f681:
0.0%

Covered Lines:
1092

Relevant Lines:
1610

💛  - Coveralls


Failure to Bypass Imperva / Incapsula WAF: Receiving Error Code 15

Issue Description:
I have been attempting to bypass a website that utilizes Incapsula WAF using the provided extension. However, it appears that the extension is not functioning as expected, despite following the installation instructions delineated in the ReadMe file.
Environment:
Extension Version: v.0.9
Jython Version: 2.7.3
Burp Suite Version: v2<IP_ADDRESS>
Browsers: Firefox / Chromium (Burp's Browser)
Steps to Reproduce:

Installed Jython and configured it with Burp Suite according to the instructions in the ReadMe file.
Installed the extension successfully.
Selected all the intercept options (Proxy, Scanner, Repeater)
Attempted to intercept links that are protected by Incapsula WAF.

Expected Behavior:
The extension should allow the interception of links behind Incapsula WAF without errors.
Observed Behavior:
Upon trying to intercept the links, an error with code 15 is consistently presented, the page won't open until I remove the Burp Local Proxy <IP_ADDRESS>:8080 from the browser.
Screenshots:

Additional Information:
If there are any additional configurations or settings that need to be adjusted to address this issue, please advise. Furthermore, any insights or suggestions to resolve this problem would be highly appreciated.
Request:
Could the maintainers or the community provide any assistance or insights into resolving this issue? Is there any known workaround or upcoming fix to address this issue?
Thanks in advance for your time and consideration.

Hi. First of all, you shouldn't be able to bypass a properly configured WAF. This extension is intented do be used on firewalls that don't scan the full payload, but just the first bytes.
Also, keep in mind that it only modifies the body of POST requests.


OIOUBL Busniess Central SAAS

In Business Central 14 saas the description field in sales invoice line (sales line)) has been extended to 100 characters. When you try to create OIOUBL invoice file after the sales order has been posted it comes with this error:
The length of the string is 100, but it must be less than or equal to 50 characters.

It seems to be because of two procedures in Codeunit 13648 CommonLogic. The text variable PartyName only have 50 characters.
Local procedure InsertCustomerParty(var AccountingCustomerParty: XmlElement; GLN: Code[13]; VATRegNo: Text[20]; PartyName: Text[50]; PostalAddress: Record "Standard Address"; PartyContact: Record Contact);
procedure InsertAccountingCustomerParty(var InvoiceElement: XmlElement; GLN: Code[13]; VATRegNo: Text[20]; PartyName: Text[50]; PostalAddress: Record "Standard Address"; PartyContact: Record Contact);

Closing issue since it's not about the docs.


feat: add a tool that will allow Minerva create and send an ics file with the calendar events to the user

We can try experimenting with two approaches.
Option 1
Add a tool that lets Minerva respond with a file containing any text content. To use the tool, Minerva should call:
send_text_file(filename, content)

Pros: very flexible
Cons: increases the probability of it hallucinating incorrect info in the ics file (-:
Option 2
Add a tool that lets Minerva respond with a file containing events extracted from the real calendar (we should let it reference the events somehow).
I would start with Option 1 to see how it will perform.

would love to contribute to this issue

@harshsennnn, sounds good. Thank you for reaching out! Assigned.

@harshsennnn, I have unassigned you from the issue. Let me know if you still want to work on it.


Typo in public static void ModerateText method

in public static void ModerateText(ContentModeratorClient client, string inputFile, string outputFile) method:
Console.WriteLine("Screening {0}...", outputFile); // This should be inputFile instead of outputFile.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ecae7b1e-c329-36b5-a034-55f84c8af361
Version Independent ID: 038f38c3-d0d0-9a26-cdd8-e9bd1aef745b
Content: Quickstart: Content Moderator client library for .NET - Azure Cognitive Services
Content Source: articles/cognitive-services/Content-Moderator/dotnet-sdk-quickstart.md
Service: cognitive-services
Sub-service: content-moderator
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@maple10001 Thanks for the feedback. We will update the doc shortly.

@maple10001 We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


some more changes. almost ready

almost ready to push the official npm package. can you take a look @irustm ?

please note<EMAIL_ADDRESS>is not live yet so you won't be able to build this. i was using my own private npm server


Implemented MDC Card Components

@e111077  Continuation of previous PR #254
Implemented:
implement in typescript
mwc-card
    change stroke to outlined to match MDC
    add border-radius css properties
    add `fullBleed` for single button
    add slot for buttons
    add slot for icons
    add readme
mwc-card-primary-action
    add `label` for aria-label
    add slot for content
    add readme
mwc-card-meda
    add `aspectRatio`
        square
        16-9
    add slot for content over image
    add background-image as a css-property
    add border-radius css properties
    add readme
update card demo
update card test
upgrade to mdc card 3.0.0

Currently blocked by #442

Thank you, I am happy the PR will be of use.


Handling complex news stories in ninjs - also known as a package

This have been discussed now and then and also been compared with the other type of packages where a bunch of "unrelated" ninjs objects are being handled in a group.
It is mainly Heather from AP who have been interested in this. But it has led up to the construction of associations in ninjs cover most of this use case.
The suggestion from AP is to add role and/or relationship in the association object.
The association objects should also have a sequence/order property to securly indicate in wich order the objects should be treated. Even in 2.0 when associations is an array it is a bit uncertain if that array gets rearranged i various processing steps along the distribution chain and on the receiving end.

Today's discussion:

arguments for and against adding sequence to associations, we can understand that users (implementers) might re-arrange items and might need to go back to the order given by the provider
would we therefore need to add sequence to all arrays in ninjs? objects, people, events?
maybe we add it to all of them and allow users to decide whether to use them or not?
but in general the default should be that the array order is the sequence of items - if someone re-orders the document then they are manipulating the content and they shouldn't be doing that.

Heather / AP said they will be working on this (and partmeta) during the summer so we will defer this work until the Autumn Meeting.


znc.service.in: add datadir & instructions

Closes #1165

It seems that AppVeyor fixed itself after git pull --rebase upstream master. It was broken before even if this PR doesn't touch anything Windows uses as far as I am aware.


Improve workflow to rely on local imports rather than web calls

e.g., robot.jar reason --catalog catalog.xml --input $file --reasoner HermiT
Place a catalog file in the cco-modules directory

See https://github.com/CommonCoreOntology/CommonCoreOntologies/pull/569


Purview Management SDK for 2023-05-01-preview

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.Purview


added a name to the forkjoin request item

It's good to use the forkJoin api to combine the http requests, but there still has one insufficient, the forkJoin api need a  array of requests or multiple requests as parameters and return a array of response, if we want to get the correct response we must order the index of the request item in the requests to accept it, it's too trouble when we delete one of requests, the other responses' index shoud be update or it will be wrong.

You can use array destructuring instead of indices. For example:
forkJoin(obsA, obsB, obsC).pipe(
  tap(([valA, valB, valC]) => { /* ... */ })
);

Closing as question's answered.


Implememtation

How can I implement this in my android studio application?

Did you know how to implement it in android studio app ?

Did you know how to implement it in android studio app ?

Not yet @karmac2015

i have updated to version 2. now you can add the library as gradle dependency. check the new documentation.


missing ovn-sim or something to allow helper commands in ovn sandbox

Prior to split, I could do commands from ovs-sim as shown below 1.
Trouble is that now ovs-sim no longer has ovn related functions such as ovn-nbctl
and there is no ovs-sim (nor ovn-sim) in ovg-org/ovn. I wonder if we could re-instate
ovs-sim inside ovn repo, or have a way of importing helper functions in ovn sandbox,
such as net_add and as.
Ref commit https://github.com/openvswitch/ovs/commit/f3e24610ea18eb873dc860f1710432e9aacd27fd that removes ovn related
helpers from utilities/ovs-sim (for the right reasons!)
Also, I see that there are some left over ovs-sim "stuff" in ovn-org/ovn, so it was not
completely expunged:
$ grep -ilr 'ovs-sim' *
Documentation/automake.mk
Documentation/ref/index.rst
Documentation/ref/ovs-sim.1.rst
Documentation/conf.py
NEWS

[1]

cd ./utilities && rm -rf ./sandbox && ./ovs-sim

ovn_start

# Create a bridge do simulate connection between hypervisors
net_add n1
for i in 1 2; do
    sim_add hv$i
    as hv$i
    ovs-vsctl add-br br-phys
    ovn_attach n1 br-phys 192.168.0.$i
done

# Add port inside hv1's context
as hv1
ovs-vsctl -- add-port br-int hv1-vif1 -- \
    set interface hv1-vif1 mac="00\:11\:22\:33\:44\:55" \
    external-ids:iface-id=foo ofport-request=1
fooMac=$(ovs-ofctl show br-int | grep -E hv.-vif1 | grep -oP "(?<=addr:).*")

# Add port inside hv2's context
as hv2
ovs-vsctl -- add-port br-int hv2-vif1 -- \
    set interface hv2-vif1 external-ids:iface-id=bar ofport-request=1
barMac=$(ovs-ofctl show br-int | grep -E hv.-vif1 | grep -oP "(?<=addr:).*")

ovn-nbctl ls-add sw0
ovn-nbctl lsp-add sw0 foo
ovn-nbctl lsp-add sw0 bar
ovn-nbctl lsp-set-addresses foo $fooMac
ovn-nbctl lsp-set-addresses bar $barMac

I wonder if it would be possible to create an ovn-sim script in the OVN repo that exports the proper OVN functions (ovn_start, ovn_attach, etc.), adds local directories to the $PATH, and then calls ovs-sim directly. I think it might work. By doing that, you'd have the same environment on startup that you do with ovs-sim, plus the ability to call ovn-specific functions.
How does this sound?

I wonder if it would be possible to create an ovn-sim script in the OVN repo that exports the proper OVN functions (ovn_start, ovn_attach, etc.), adds local directories to the $PATH, and then calls ovs-sim directly. I think it might work. By doing that, you'd have the same environment on startup that you do with ovs-sim, plus the ability to call ovn-specific functions.
How does this sound?

sounds awesome! I love the idea of using ovs primitives from ovs to avoid duplication


How to record video and audio simultaneously via intel realsense camera D415 and external microphone

Required Info

Camera Model
D415

Firmware Version
<IP_ADDRESS>

Operating System & Version
{Win 10 / Linux (Ubuntu 18) / MacOS

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC

SDK Version
{ legacy / 2.0 }

Language
C/python/

Segment
others

Issue Description
Is there any way to record video and audio simultaneously via intel realsense camera D415 and external microphone? If I use python to control both of them, It seems cannot record in the same time.

There is no mechanism in the current RealSense SDK to record audio, as the 400 Series cameras do not have microphones.  The last time that a similar question was asked, I recommended trying to do the audio and video capture with Windows via Microsoft's DirectShow API.
https://github.com/IntelRealSense/librealsense/issues/5350#issuecomment-559947283
There was someone who created a tutorial article for accessing DirectShow with Python.
https://www.codeproject.com/Articles/1274094/Capturing-Images-from-Camera-using-Python-and-Dire

Thanks. I will try another way.


When joining a lobby and fails mods tab will show up on every menu tab

To add onto this when this does occurr the in game hud will be on the ceiling of the in song scene

Hey!

Could you explain what you mean by "fails", what goes wrong exactly?
Do you maybe have a screenshot of this issue you could share?

What i mean by fails is when i try to join a lobby it fades to black (? cant remember exactly, will repo and get video when possible) then gives me a message saying that that lobby does not exist, when this happens any multiplayer lobby i attempt to join will say lobby does not exist, aswell after that if i go into solo and play a song, my combo and multiplier will be moved to the roof, along with the UI pillar things and my timer(?) from counters plus will be in the center of the lanes on the floor

Hmm, it's a bit tricky to pinpoint because of all the mods doing different things.
The in-game counters and UI getting weird is probably related to MpEx, as it has settings that change your game HUD.
Your exact issue sounds rather strange though, haven't quite heard that one before, so a video would be very helpful to paint a picture. 👍

alrighty, ill get back to this issue with a video and log when i can, it seems pretty common for me afaik

Alrighty, here is a video of the bug occuring and a log of the incident
Had to drop the file size really small to upload but you can see i try to join a lobby, it fails, then my solo hud breaks
Beat Saber 2020.11.30 - <IP_ADDRESS>.DVR_Trim_Trim_Trim.zip
_latest.log

Ive realized that this issue is not a problem with beat saber server browser but possibly MPEX, im going to forward this issue over to that repo


More 'Run command' commands available

There are now more Available commands than documented according to the interface.  Such as
EnableWindowsUpdate
DisableWindowsUpdate
EnableEMS
DisableNLA

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b3ff94e6-3c1f-b9e1-1a46-b75fe2ffca1b
Version Independent ID: 8f3ca735-ddd4-f4a9-4ee0-189604018784
Content: Run PowerShell scripts in a Windows VM in Azure - Azure Virtual Machines
Content Source: articles/virtual-machines/windows/run-command.md
Service: virtual-machines
GitHub Login: @bobbytreed
Microsoft Alias: robreed

@bobbytreed Can you let me know if you are still the owner of the Run commad or who it has been handed off to? Thanks :)

#reassign @cynthn

@tlourey Thanks for the feedback! And, I'm sorry it has taken a while. I've filed a pull request to update the list of available commands. It should be live later today.
#please-close


chore(ci): update GitHub Actions workflow

Adding the translations in English to all other translations will remove the (valid) warning of the items being untranslated, I'm not sure we should do that

Adding the translations in English to all other translations will remove the (valid) warning of the items being untranslated, I'm not sure we should do that

Fair point (although there were already some English translations in these other files to begin with).
@Requinard wanted to set --max-warnings=0 on all linting tasks, so its either this or accepting that at least the translation linter will have warnings. If we do not set that parameter on the translation linter, I'd simply remove all English translations from all language files (there were some in there before).

Cleanest would be to remove the English translations that are not in .en, because we're pulling those from fallback English anyways, and if we have them in both we will likely forget to change them if we change the originals. So overall I'd like no max warnings on the translations until we all speak every translated language

Cleanest would be to remove the English translations that are not in .en, because we're pulling those from fallback English anyways, and if we have them in both we will likely forget to change them if we change the originals. So overall I'd like no max warnings on the translations until we all speak every translated language

Works fine for me, then I'll just remove that parameter from the translation linter entirely and strip all English translations from non-English translation files. (=


Support Generalize Version Bits (BIP135)

Supporting BIP135 will allow the flexibility needed to use the version bits mechanism to safely deploy both soft and hard forking changes.

Fixed by #477.


ci: Lint Markdown files

Implementation ideas
celestia-node contains ADRs in docs/adr that could benefit from consistent styling in Markdown files. One idea is to use Markdownlint.
Originally motivated by: https://github.com/celestiaorg/celestia-node/pull/922#discussion_r930044696

https://github.com/FuelLabs/fuel-indexer/blob/a96f8ec9e9b3edd35d564f4d079a2739a3bb0a7c/.github/workflows/ci.yml#L217-L227


onedrive: 2.3.13 -> 2.4.0

Motivation for this change
Upgrade
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/best-practice-for-handling-a-breaking-update-to-a-derivation/6365/4

we can start a convention to put some keyword to commit message, which can warrant users about incoming breaking changes. Candidate words: BREAKING, CAVEAT, !!!, (breaking). Commit message should also describe details.
cc @worldofpeace about idea to add such keyword to commit message, for future benefit of unstable users.

@worldofpeace sorry, I'm not aware of that. Which tooling?

we can start a convention to put some keyword to commit message, which can warrant users about incoming breaking changes.

I feel that this PR doesn't contain breaking changes in the traditional sense. It's more like, users need to be aware that action will be required.
It might have been good if the PR's description had a "Reviewer's Note: ..." or similar, just to double make sure they are aware of the need to re-auth, and maybe mention that it's easy to reset back to previous auth with another --logout once back on the current version.
However, I don't think there's any way of letting true end users know about the requirement to re-auth other than in the release notes is there?

@danbst do you want to approve this?

Probably too casual, sorry :)
If you can approve this, its better than these changes go in than the automated changes in https://github.com/NixOS/nixpkgs/pull/86707


Add Code of Conduct

We recommend that every repo has a code of conduct. If you don’t feel comfortable creating your own Code of Conduct from scratch we highly recommend using one of the templates provided by GitHub. If you do use a template, please read through the template and ensure that you can and will abide by the Code of Conduct.
Please follow these instructions on how to add a Code of Conduct.
Sample: https://github.com/Recode-Hive/Stackoverflow-Analysis/blob/main/CODE_OF_CONDUCT.md

Its already present https://github.com/HITK-TECH-Community/Community-Website/blob/main/code_of_conduct.md , do check the repo once before opening the issue


Should we have our own illustrations?

In the exercise we used images from the Noun Project. As I see it that has some advantages:

saved time by reusing images,
nice being a reuser as well.

However, there are some advantages by doing our own illustrations:

more coherent style,
style can fit better with our brand and other assets,
we provide the community with more free resources.

The only downside with custom illustrations is that it will take us some time and money to get them. Based on this, we should evaluate if it makes sense switching to custom illustrations.

I'd definetely support extending our illustrations library with the concepts you need, many I think are already in there.


Build / Publish Container to GCP/GCR

As part of our efforts to build out a supported Forseti on GKE https://github.com/forseti-security/forseti-security/issues/2084 we want to also build and publish Real-Time-Enforcer to Google Container Registry.
Having the container also published on GCR enables customers who are using GCP with Private IP Access only to still deploy via Forseti Terraform getting containers via Private IP / GCR.

I think this is satisfied

I think this is addressed

@kevensen Do you know the GCR repo it's pushed to?  The terraform module still points to docker hub - see https://github.com/forseti-security/terraform-google-forseti/blob/f964e0cf8181107c2c18b2a69438177bac19e32c/modules/real_time_enforcer/templates/cloud-init.yml#L74

@rvandegrift I apologize, this isn't addressed at all.  I am going to take a look at this in the next couple of sprints.

No worries - thanks for taking a look!


feat: define DilationEquiv

[ ] depends on: #5753

This PR/issue depends on:

leanprover-community/mathlib4#5753
By Dependent Issues (🤖). Happy coding!


Fix attaching to C# func process

Fix #3748
The doc string on this property states:

Which is sorta confusing because it makes it sound like they set it to true when http is used. But turns out it just defaults to false.
It would help me a lot if you could reproing #3748 and then make sure this fixes it for you. It does for me 😄

I can reproduce this on our main branch and confirmed that this fixes it.
Just to clarify, the project still debugs, but never attaches. So the func host is running and the trigger will be execute, but your debugger never attaches and therefore cannot hit breakpoints.
However, listing local triggers isn't fixed due to the same error. We make this request separately for local tree items, so I'd just add it to 'LocalFunctionsTreeItem.getChildrenForHostedProjects as well. Or maybe we could extract it out as a util function? There are a few places that use the rejectedUnauthorized property, though I didn't confirm exactly how they are used 🤷

Shouldn't we do that instead of merging this then?

Shouldn't we do that instead of merging this then?

Yeah I'll do it


Failure to load org list should stop spinner

Steps:

launch portal when the '/api/Organisation/?method=get_tops' endpoint on bman cannot be reached (mangle the URL in the code if you have to)

Expected:
The portal spinner will disappear and some sort of notification is given to the user that we failed and we aren't still trying to load data.
Actual:
The spinner goes forever, even once the HTTP failure has happened.

Done and pushed to dev branch.


"could not build go file"

....."cannot find source files"

Please don't use the issue tracker to ask questions.  See https://golang.org/wiki/Questions .  Thanks.
If there is a bug here, please feel free to reopen.  We will need a lot more information.  You need to tell us precisely what you did, precisely what happened, and what you expected to happen instead.  Think about what it would take us to recreate the problem ourselves.


Initial IoT Config Service

This PR implements the initial IoT Config oracle service that will be used by helium network users for organization and routing management as well as supply hotspots with region information upon request, all via grpc apis. It implements:

Basic oracle server structure, run loop, config management and packaging requirements
Implementations of the grpc traits defined in the proto repo for the Org and Route services (minus the route disable api)

This is the first of several PRs to break up the review and development of the config service. The following changes are not yet implemented and will follow in subsequent PRs:

Refactor service backends behind org/route traits for easier testing and separation of database access from data manipulation
Authentication and authorization checks against registered admin and org management keys
Additional validations of devaddr range constraints, nonce incrementation, and timestamp replay prevention
Session Key Filter management
Gateway region lookup

One note is some of the sql queries look intensive, are any indexes required ? i suspect the volume of data is very low so perhaps not important at this point

Good point; it took a while to load up a suitable sample of data in a test db but after playing with the queries, particularly the route-related ones, I've added a few indexes https://github.com/helium/oracles/blob/272de7e98718f0c276f6fc6b44d66dbc5b318515/iot_config/migrations/3_routes.sql that really improved performance on all but the insert and delete operations on the route_devaddr_ranges table and those only increased by 0.4-0.5ms


Adding PageTransformer does not work as intended

Hi,
I needed to add custom animation with MultiViewPager but failed the animation doesn't work properly.

Can you try using your animation in a conventional ViewPager first?
If the problem is specifically related to MultiViewPager, please provide a
more detailed description of what you expect to happen, what happens, and
steps to reproduce. A code snippet with your PageTransform would be very
useful in troubleshooting this.
On Wed, Mar 23, 2016, 12:54 akslive<EMAIL_ADDRESS>wrote:

Hi,
I needed to add custom animation with MultiViewPager but failed the
animation doesn't work properly.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/Pixplicity/MultiViewPager/issues/16


[pre-ll] Fix travis linux build

Add missing glfw dependencies for the newer trusty images.
Same as #1422

error: Could not compile gfx_app.

hmm

It actually passed in the travis run on my fork. I hope it was just a sporadic failure.
https://travis-ci.org/msiglreith/gfx/builds/273096073?utm_source=github_status&utm_medium=notification

thank you! let's see
bors r+

Blocked by Travis CI OS X issues, all jobs are stopped. (https://www.traviscistatus.com/)


gatsby/feat: situation measure list desktop

What changes have you made and what's the motivation behind them?

added better support of displaying situations and measures on desktop resolutions
now displaying the related list (as designed in figma) on the left side
the detail itself will definitely need some refinements, but thats not a part of this PR
for a deeper PR review, i recommend going commit by commit to get the thoughts behind it :)

How should this be Tested?

mobile design should remain very same as it used to be
scaling up from mobile resolutions to desktop should behave as one would expect and eventually end as what the figma design shows

Screenshots:
Related figma screens:

Code ready for review, however fruitful discussion happening over here https://cesko-digital.slack.com/archives/C01D8E49C1M/p1604865269220900 so this PR might receive some changes if theres some conclusion out of that thread.


Move build to rattler-build

Follow https://prefix.dev/blog/rattler_build_on_conda_forge to use rattler-build.
Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found some lint.
Here's what I've got...
For recipe/recipe.yaml:

The top level meta key schema_version is unexpected

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub actions workflow below for more details. You can also ping conda-forge/core for further assistance or you can try rerendering locally.
The following suggestions might help debug any issues:

Is the recipe/{meta.yaml,recipe.yaml} file valid?
If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11281636715.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub actions workflow below for more details. You can also ping conda-forge/core for further assistance or you can try rerendering locally.
The following suggestions might help debug any issues:

Is the recipe/{meta.yaml,recipe.yaml} file valid?
If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11281760262.

I pushed the fix which was just not to skip over all variants :)
The problem in your case was that the skip condition was wrong (<py310 always evaluated to true, but you wanted to use match(python, "<3.10")).

Hi @luizirber thank you for testing and I am super excited!
It looks like we're hitting two problems now, one of those looks like a rattler-build problem: when testing linux-aarch64 and linux-ppc64le we are trying to find sourmash for the linux-64 platform (which is not the target-platform). I'll have a look and will try to fix this today!
For the Windows failure, I am not sure exactly what's going on yet. The next release also adds @echo on to Windows scripts so it might be easier to understand going forward.

OK, fix for linux-aarch64 and linux-ppc64le tests is done :)
Let's check Windows again once we have the latest release. Sorry for the hiccups :)

Hi @luizirber thank you for testing and I am super excited!

me too =]

It looks like we're hitting two problems now, one of those looks like a rattler-build problem: when testing linux-aarch64 and linux-ppc64le we are trying to find sourmash for the linux-64 platform (which is not the target-platform). I'll have a look and will try to fix this today!

:tada:

For the Windows failure, I am not sure exactly what's going on yet. The next release also adds @echo on to Windows scripts so it might be easier to understand going forward.

the windows build is overly complicated, I was looking into the polars feedstock and wondering if using
  build:
    - posix                               # [build_platform == "win-64"]

and reusing build.sh is simpler going forward

I think you can rerun the build now and the two linux ones should work :)

@luizirber - sorry for not noticing earlier, but we renamed bld.bat to build.bat.
I think there are three things we could improve:

automatically rename bld.bat to build.bat with conda-recipe-manager
warn when there is no script in rattler-build
continue to support bld.bat but show a deprecation warning or something like that

Would love to hear your opinion!

@luizirber - sorry for not noticing earlier, but we renamed bld.bat to build.bat.

Oh! That was an easy fix :sweat_smile:

I think there are three things we could improve:
* automatically rename `bld.bat` to `build.bat` with conda-recipe-manager
* warn when there is no script in rattler-build
* continue to support `bld.bat` but show a deprecation warning or something like that

I like both 1 and 2, and maybe a mix of 2 and 3 where it warns it found a bld.bat and it should be renamed to build.bat, and then fails.


update the Rebel v0.1.3.

Description
This PR update the Rebel version v0.1.3.#
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

we will merge this after we fixed the Ci issue. @jinronga


Host Name

Dear eng.
I hope you are fine.
I just have small question which is String_host
Value what do mean with it as i assigned "https://test.oppwa.com/"
To it but it is false as in the run in terminal it says sting-host value is 4 hex digits.
So i need your help.
Besy regards.

Hello, please provide a code snippet explaining which value are you referring to.
I'm assuming you mean the server host, which indicates your own host, all requests will fail until you implement the required endpoints on your server and provide it on initialization as in the example.

Have you implemented your own endpoints on your own server as shown clearly in this guide?
The call to test.oppwa.com shouldn't be the host in your client app, it must happen server-to-server.

String _host = 'test.oppwa.com';
Uri _checkoutEndpoint = Uri(
scheme: 'https',
host: _host,
path: '',
);
Uri _statusEndpoint = Uri(
scheme: 'https',
host: _host,
path: '',
);
/// Initialize HyperPay session
Future initPaymentSession(
BrandType brandType,
double amount,
) async {
CheckoutSettings _checkoutSettings = CheckoutSettings(
brand: brandType,
amount: amount,
headers: {
'Authorization':
'Bearer $token'
},
additionalParams: {
'merchantTransactionId': '#123456',
},
);
hyperpay.initSession(checkoutSetting: _checkoutSettings);
sessionCheckoutID = await hyperpay.getCheckoutID;

}
When I did that  I got this response :
FormatException: Unexpected character (at character 1)

 ^

Do you mean that the host name should be my own ? even on test Mode? @pr-Mais

Yes even on test mode .You will need to set your backend either ways to accept both testing and production environments.

Ok thanks a lot , Is this the reason why I get this response :
==> FormatException: Unexpected character (at character 1)
==> <html></html>
==> ^

Most probably yes. It's not the response the plugin is expecting.

String _host = 'karaj-payment.cc';

Uri _checkoutEndpoint = Uri(
  scheme: 'https',
  host: _host,
  path: '/shopper/redirect',
);

Uri _statusEndpoint = Uri(
  scheme: 'https',
  host: _host,
  path: '',
);

Is this Right ?

Now I am getting this error :
HandshakeException: Handshake error in client (OS Error:
	CERTIFICATE_VERIFY_FAILED: certificate has expired(handshake.cc:393))

@pr-Mais


Enable environmental authentication for Azure Key Vault var provider

This PR is related to #2566 in that it provides similar authentication behaviors for Azure Key Vault var provider. This change should be additive and not cause any breakage to existing applications.
It would probably be wise to follow on with some integration tests to guard against future breakage. I'm not clear on the project stance on spinning up cloud resources for testing, but if help is wanted, I'd be delighted to lend a hand.
To create the infra and test this, simply follow https://developer.fermyon.com/spin/v2/dynamic-configuration#azure-key-vault-application-variable-provider-example. You can skip over creating the service principal and instead use your current identity provided through Azure CLI to authenticate.
Runtime config should look like the following with ${your_vault_name] replaced:
[[config_provider]]
type = "azure_key_vault"
vault_url = "https://${your_vault_name}.vault.azure.net/"

On a side note, fetching secrets from Key Vault upon each request is pretty slow. Might want to consider some form of memoization / caching for a period of time.

@itowlson is this waiting on anything else to merge?

someone's vacation, I imagine. :-P

@squillace UNCANNY


Create PolicyStore and default impl

A PolicyStore interface must be implemented with the following API:
public interface PolicyStore {
    // returns null if not found
    Policy findById(String policyId);
    Stream<Policy> findAll(QuerySpec spec);
    void save(Policy policy);
    // returns null if not found, returns the deleted item otherwise.
    Policy delete(String policyId);
}

If any exception occurs, a EdcPersistenceException should be thrown.
In addition, an in-memory implementation should be provided.

Linking this to #855 since we will need the policy store to handle rule bindings as well.


no build

I can't compile, I add (https://github.com/gSpotx2f/luci-app-temp-status.git) to feeds.conf, then (./scripts/feeds update -a)

in the console output

(/home/ctos/openwrt/feeds/luciapptemp.tmp/info/.files-packageinfo.mk:1: *** target image does not contain “%”.  Stop.)
p.s.
ruantiblock_openwrt builds normally

I was able to create the ipk. It installs, but LuCI doesn't show anything. In terminal (lua /usr/libexec/rpcd/luci.temp-status call getTempStatus) it shows the temperature.
p.s. I am building based on the latest OWRT snapshot.
If I put a ready ipk from your repository, everything is displayed correctly in LuCI. I compared the ready packages, the internals are almost identical. I don't know what to do.

There were changes in the last snapshots, the Makefile needs to be fixed. I'll do this when 24.x-rc1 is released.

can't install last snapshot Banana working with apk

can't install last snapshot Banana working with apk

APK is not accepted yet in 24.10. Snapshot is a branch for developers, they usually know how to build packages from sources.


All IDEA tests lost their display names, DX gone

Current Behavior

Additional problem, which might be a separate issue, but very likely related: failing tests never complete (on UI), Gradle build completed.

Expected Behavior

Context (optional)
https://docs.gradle.org/8.8-rc-1/release-notes.html#ide-integration-improvements
It's great, but it shouldn't break all existing IDEs.
Steps to Reproduce
Bog standard @TestFactory with dynamicContainer and dynamicTest in a Kotlin JVM project.
@Nested inner class and @ParameterizedTest are also affected.
I assume you have repros for this, because it's mentioned in the release notes, let me know if you need an example.
The very simple act of changing the wrapper version from 8.7 to 8.8-rc-1 and re-running the tests breaks the existing (good) behavior, therefore I raised it as regression.
Gradle version
Gradle 8.8-rc-1
Gradle version that used to work
Gradle 8.7
Build scan URL (optional)
No response
Your Environment (optional)
IntelliJ IDEA 2024.1 (Ultimate Edition)
Build #IU-241.14494.240, built on March 28, 2024
Runtime version: 17.0.10+8-b1207.12 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 6144M
Cores: 28
Registry:
  ide.windowSystem.autoShowProcessPopup=true
  ide.tooltip.initialDelay=105
  debugger.valueTooltipAutoShowOnSelection=true
  debugger.click.disable.breakpoints=true
  terminal.use.conpty.on.windows=false
  external.system.auto.import.disabled=true
  android.gradle.project.startup.activity.disabled=true
  android.sdk.local.properties.update.disabled=true
  unknown.sdk.auto=false
  maven.create.dummy.module.on.first.import=false
Non-Bundled Plugins:
  detekt (2.4.0)
  com.karateca.jasmineDescriber (3.5)
  com.jetbrains.colorful.toolwindow.icons (1.0)
  CMD Support (1.0.5)
  org.intellij.productivity-log (0.1.1)
  com.afcastano.intellij.autovalue (1.0.5)
  com.github.droibit.plugin.rxjava.postfix (0.1.0)
  com.intellij.mermaid (0.0.21+IJ.232)
  GrepConsole (12.25.0-IJ2023.3)
  com.github.adrienpessu.sarifviewer (1.2.3)
  com.github.copilot (<IP_ADDRESS>45)
  com.intellij.lang.jsgraphql (241.14494.150)
  MetricsReloaded (1.12)
  org.jetbrains.debugger.streams.kotlin (0.0.3)
  org.jetbrains.android (241.14494.240)
  com.android.tools.design (241.14494.158)
  com.dmarcotte.handlebars (241.14494.150)
  mobi.hsz.idea.gitignore (4.5.3)
  com.intellij.plugins.html.instantEditing (241.14494.140)
  com.jetbrains.php (241.14494.240)
  org.exbin.deltahex.intellij (0.2.10)
Kotlin: 241.14494.240-IJ

Sorry for that.
This is a known issue that is supposed to be fixed in 8.8-RC2 by

#28975

As for "failing tests never complete", see this issue:

https://youtrack.jetbrains.com/issue/IDEA-352379/BeforeMethod-AfterMethod-remain-spinning-for-ignored-tests

@TWiStErRob PTAL at 8.8 RC2

Thanks @ov7a, I was just thinking about this issue today. Updated a project to try, all good!

@TWiStErRob Thank you for testing this!


Better error handling in csv table name

You can create a new db from CSV:
turso db create --from-csv test12_sanitized.csv --csv-table-name some_table

If someone sends an invalid character for csv-table-name param, it just prints an error as something went wrong:

Error: could not load csv into new database file: exit status 1: 4572726f723a206e65617220222d223a2073796e746178206572726f720a

We should display the proper error

We update our CLI to not to accept any special characters in csv-table-name param

reported here: https://discord.com/channels/933071162680958986/1215308443217563668/1215308443217563668

@avinassh database is created even when csv-table-name has special character. but sql give error. I dont understand what your issue is.
What i am seeing is, we should not allow Special characters in table name because later sql is going to give error.


MinerInfo [Suggestion]

Would there be a way to make the mod compatible with kremnev8's AdvancedMiner? link
If we're using Mk II miners, the output shows less than what the miners real output is.

Currently one miner has a 99/min throughput, so it should show 891/min instead of 396/min.


Updating dependencies for angular 13 and adding imports to public_api.ts

Update library and app to Angular13
Exporting classes exposed by module but not by entry point.

Thank you for your contribution! I am wondering what use case you are running into that requires exporting the ValidationMessageComponent, FormDirective, and ValidationMessagesComponent types?

During npm run build:lib
× Compiling with Angular sources in Ivy partial compilation mode.
angular-reactive-validation/src/validation-message/validation-message.component.ts:18:14 - error NG3001: Unsupported private class ValidationMessageComponent. This class is visible to consumers via ReactiveValidationModule -> ValidationMessageComponent, but is not exported from the top-level library entrypoint.
18 export class ValidationMessageComponent implements OnInit {
~~~~~~~~~~~~~~~~~~~~~~~~~~~
angular-reactive-validation/src/form/form.directive.ts:12:14 - error NG3001: Unsupported private class FormDirective. This class is visible to consumers via ReactiveValidationModule -> FormDirective, but is not exported from the top-level library entrypoint.
12 export class FormDirective {
~~~~~~~~~~~~~~
angular-reactive-validation/src/validation-messages/validation-messages.component.ts:24:14 - error NG3001: Unsupported private class ValidationMessagesComponent. This class is visible to consumers via ReactiveValidationModule -> ValidationMessagesComponent, but is not exported from the top-level library entrypoint.
24 export class ValidationMessagesComponent implements AfterContentInit, OnDestroy, OnInit {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Interesting. It's a shame exposing these is now necessary, as users of this library shouldn't care about those internals, just about using them inside HTML. Angular will be Angular I guess 😀.

Yeah indeed.


Feature/integrate viewer

These are  the RViz plugin to display

detection result (object detection, ranging, tracking and points image)
traffic light recognition  result

and alternatives to existing viewers in Autoware.

Sweet!
2016-07-27 23:20 GMT+09:00 Manato Hirabayashi<EMAIL_ADDRESS>
These are the RViz plugin to display

detection result (object detection, ranging, tracking and points
image)
traffic light recognition and alternatives to existing viewers in
Autoware.

Reply to this email directly, view it on GitHub
https://github.com/CPFL/Autoware/pull/402, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAToC2vEuDFwOKNLe5pTS3K-TWqaxoTxks5qZ2kSgaJpZM4JWPWS
.

I have merged feature/integrated_viewer branch to the master.
Please let me know if you have any trouble by this merge.
@amc-nu , @h-ohta
Thank you very much for your cooperation!
New RViz plugin is available by:
RViz menu -> "Panels" -> "Add New Panel" -> select "ImageViewerPlugin" or "TrafficLightPlugin" in "integrated_viewer" section.


Add the grade keyword

Need to figure out what it is about and add it to the codelabs

This is now fixed in the source spreadsheet codelab.


Resync rewrite

Addresses https://github.com/dcrdata/dcrdata/issues/17
This addresses the insane memory usage of rebuilddb.  Maybe also resync from arbitrary height instead of 0.

Seems to work as intended.  However, it's complicated and a big change.
Now requires an on-disk ticket database (leveldb) to be able to get live tickets at the last recorded height before dcrdata exited.

Also note that glide install is required before build as depends changed.


Add dnf history error for the sudo rule

$ dnf history
You don't have access to the history DB.

Thanks!


fixed a bug in json_run_localhost scenario generation

The current scenario_gen.py for json_run_localhost was using the same scenarios as qps_json_driver, this is to fix the bug

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,955,026      Total (=)      1,955,026

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,843,748      Total (<)     10,843,756

 No significant differences in binary sizes

@billfeng327  please apply the "release notes: yes" or "release notes: no" (probably the right choice for this PR) label to make the "Mergeable" check pass.


Master

i want to modify index.html for header issue

Fine, but the branch I want your work to appear on is gh-pages, because this is the page that is hosted at www.wicklowcam.com and is the default branch for this repository.
You should be able to make a PR with your work to the gh-pages repo


AsyncProps _loadAsyncProps without any loadProps() components never calls its callback

_loadAsyncProps never calls its callback if the current set of components being rendered doesn't contain any with a static loadProps() property.
There's a .length check in componentWillMount which ultimately skips calling it, but there are other ways to end up calling it and get into this situation (e.g. using AsyncProps.hydrate() when performing an initial render on the server).

+1

its just experimental, sorry I have to just close issues on AsyncProps until we actually work on it (after rr 1.0)


Member Survey and Introductory Session

Discussion 🗣

To increase our understanding of community members' motivations and needs, we propose to conduct a short online survey.
Furthermore, we agree to host an introductory meeting to increase engagement with new members. This could take the form of a Show and Tell session or Office Hours for example
Context

Detailed Description

@mttrbrts @DianaLease @tbrooke @niallroche @dselman  - I have created a short TypeForm survey.  Please take a look and let me know your feedback.  (Note: You can submit test answers. We can clear out dummy responses before publishing.)
https://form.typeform.com/to/BHgzoqZG

@martinhalford  to update questions as per discussion on today's TSC call.
@tbrooke to review AP privacy policy https://accordproject.org/privacy

In-scope systems for privacy policy:

Wordpress.com
TypeForm
Google Workspaces


Add support for pnpm (#117)

This solves the issue I reported in #117
I have another branch where I am testing an updated test action.
Some of the tests are failing with pnpm and yarn because they don't have the exact feature set of npm. I'm out of steam to dig deeper tonight, but if I get the test suite running fully with appropriate tests disabled, I will open a second PR (or, if you haven't had time to review this yet, I'll add to this PR).

Current status of the tests:
✅  NPM: passing
⚠ PNPM: same results on everything but macos-latest for some reason, where this particular test case doesn't fail
  210 passing (12m)
  17 pending
  1 failing

  1) [fail] it should fail
       if tasks exited via a signal:
         with correct exit code:

      AssertionError [ERR_ASSERTION]: should have correct exit code
      + expected - actual

      -false
      +true

      at /home/runner/work/npm-run-all2/npm-run-all2/test/fail.js:112:7
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

❌ YARN w/ windows or ubuntu:
  216 passing (11m)
  1 pending
  23 failing

A lot of the yarn failures are things like Error: ERROR: Task not found: "test-task:package-config" or AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:. Chances are most will be easy to fix. I bet yarn might need an extra command for the nested workspace.
macos yarn has 1 additional failure

Cool thanks for looking into this. I'll do my best to take a look by this weekend.

Cool thanks for looking into this. I'll do my best to take a look by this weekend. Approving CI in the meantime. My main target is supporting npm since its what ships with node. Yarn and pnpm support is definitely best effort. If this works for the most part, but a few random tests fail in yarn/pnpm mode, I don't mind adding skips in those cases, so long as the npm side doesn't loose coverage. Sometimes its just not worth someones time to figure out edge cases like that unless they are important.

I figured as much, but I wanted to stave off possible issues in new versions not being detected :)
My current approach is to confirm that a given functionality is not available in either pnpm or yarn when it fails. If the functionality is not present, then skip the tests on that package manager. Unfortunately, it's kinda tricky to confirm that; I couldn't find a good table/resource that showed which commands are different or what functionality was not present, (and the pnpm docs don't really say "we don't do this thing that npm does" for the most part... notable exception being running arbitrary 'pre' scripts, which there's a config override for) so I'm mostly having to try and reverse engineer the tests into terminal commands that I can run.
I noticed with yarn that if I did stuff like yarn run --random=other scriptname it didn't give an error, which is why I suspect that the config override tests need to be skipped on yarn. I didn't realize you could even do that in npm until I started trying to dissect what was being executed, and I was having a hard time finding npm docs describing this behavior. If you could confirm that, that would be appreciated. Otherwise, if I can't conclusively say "this doesn't exist in yarn, even with a different syntax", we could just skip the tests anyway, but generally I'd prefer not to do that

@kinland I made a small modification in https://github.com/kinland/npm-run-all2/pull/1


Collection Landing page Mobile Optimizations

Added media-query stylesheets for page breaks at 480 and 768.
Reduce branding size, expand title height to accommodate long titles on small screens (<768).
Change modals to cover more of the screen, with less margin/padding and use a smaller font on small screens.

:+1:
I'm okay with this.  I'd like to avoid uses of !important if possible, but some of that can wait until we settle on our design a little more.

I've managed to remove most of the !importants, but the ones that remain are over-riding css that is computed within react components.

:+1:


EfficientNet implementation compatible to keras and tf.keras (resolves #39)

As requested in #39.

Thanks a lot!


Enhance LSP for multi-editor support

[x] Support for Editor/IDE with file system access
[ ] Support for Monaco and other browser-based editors

To use the LSP with other editors, refer to tact-extracted-ls.
Resolves #35

Thank you for your contribution! I'll check it next weekend.

This PR also resolves #29, as it enables formatting capabilities in the LS :rocket:


Future of State in FOREST

Document motivation behind State objects and the roadmap for the future of application state

State is intended to be serialisable dict with a collection of selector functions do state parsing is not a concern of a View/Loader pair

UI not currently conforming to the redux pattern should be refactored to make it consistent across the code base. Consistency is a important factor for new developers to do the "right" thing in the grand scheme of the overall architecture. Architectural dead ends need to be removed or cleaned up

@eardkdw @LaurenceBeard the State object in it's current form is poorly documented and a bit clunky. My vision for it is to become a miniature database that views interact with indirectly via selectors.
from forest import selectors

class View:
    def render(self, state):
          valid_time = selectors.valid_time(state, self.label)
          ...

The State itself can be represented as a "normalised" no-SQL database. Or in Python-land a nested dict structure.
{
   "labels": [
     {"value": "UM", "uid": 0},
     {"value": "RDT", "uid": 1}
   ],
   "dimensions": {
    "valid_time": {
      0: ["2019-01-01 00:00", "2019-01-01 03:00"],
      1: ["2019-01-01 00:00", "2019-01-01 00:15", "2019-01-01 00:30", ...]
       }
   }
}

You can imagine incorporating colorbar settings in a leaf-node,
{
   ...
   "presets": {
          "selected": 3,
          "settings": [
               ...
               {"uid": 3, "palette": "Accent", "levels": 5,
                "min": -5, "max", 100,
                "name": "Temperature"}
               ...
          ]
   }

If we continue in this manner, Views choose the parts of the State they're interested in but FOREST can then be serialised and re-hydrated easily. It also opens the door for an undo/redo feature.

It might even be possible to save a list of states into a file
with open(f"state-{user_id}.json", "w") as stream:
     json.dump(stream, states)

Or to load from a file containing all states a user has generated...
with open(state_file, "r") as stream:
   states = json.load(stream)
   latest_state = states[-1]

Alternatively, we can use functional reactive programming streams  to map AppState to ViewSpecificState and filter if no view-relevant state has been updated. E.g. this is already done in main.py to map new state to old state
    # Line 276 of forest.main
    old_states = (db.Stream()
                    .listen_to(store)
                    .map(lambda x: db.State(**x)))
    old_states.subscribe(artist.on_state)

Or in pseudo-code to illustrate a point
view_specific_states = (db.Stream()
                            .listen_to(store)
                            .map(selector)
                            .unique())
view_specific_states.subscribe(view.render)

This way views only receive unique updates relevant to them.

An improved State representation can also help with #181


Fixing incorrect code in readme

"store" does not exist. Changed it to use the Store object that the user created earlier.

did you have a chance to look at this?

@Magicjarvis

Thanks!

@Magicjarvis can you please merge this with the master branch? (got accepted but not merged) Thanks!


conversation.say doesn't output until you end the convo

I'm not sure if this is a bug or expected behavior, but it makes conversations much less useful.
Could we add a conversation.flush() method to output queued messages without ending the conversation?
I guess I can use bot.say() in these cases, but the conversation methods don't get a passed a reference to the bot (?) so I'd have to store/pass that around.
Use case:
If I have a conversation and in the middle I want to add a response, eg to a 'hint' or clarification if the user doesn't give an expected answer, there's no way to use bot.say without ending the whole conversation.
consider the snippet below
in this case if the user enters hint
I can try to convo.say("Rhymes with foo!");
but this will NOT output until I fire a convo.next()
doing that will however end the conversation.
I also tried with convo.repeat() and silentRepeat() but these seem to not behave as expected.
ConvoTest.start = function (bot, message) {
debug("message", message);
bot.startConversation(message, function (err, convo) {
if (err) {
console.log("err", err);
return;
}
convo.say("Start single player game");
// convo.ask("What color is the sky?", ConvoTest.quizQuestion);
convo.ask("What color is the sky?", ConvoTest.multiResponse);
    convo.on('end', function (convo) {
        bot.say({
            text: "Game Over",
            channel: message.user
        });
        // convo.say("Done!");
        // convo.next();
        if(convo.status === 'completed') {
            console.log("end convo");
        }
    });

});

};
ConvoTest.multiResponse = [
{
pattern: /hint/,
callback: function (response, convo) {
convo.say("Rhymes with foo!");
// FIXME - this will exit the conversation
// but without it, nothing is output
convo.next();
}
},
{
    pattern: /what/,
    callback: function (response, convo) {
        convo.say("Say what?");
        convo.repeat();
        convo.next();
    }
},
{
    pattern: /blue/,
    callback: function (response, convo) {
        convo.say("yes, you win!");
        convo.next();
    }
},
{
    default: true,
    callback: function(response, convo) {
        convo.say("no, try again");
        // convo.repeat();
        convo.silentRepeat();
        convo.next();
    }
}

];

@Yulgana33 I'm not sure what you are attempting to do here - this is (once again) a duplicate of an existing issue that already has a lot of helpful discussion attached to it.
Please DO NOT create duplicate issues, it is a big drain on our limited resources.

https://github.com/howdyai/botkit/issues/318


Support Python 3

What does this PR do?
This moves teamcity to python 3.
I tried to ensure that the hosts element was unicode instead of bytes, but could not. For some reason the way that the aggregator stub works makes this impossible to do. (I didn't dig into it all the way, but it seems to treat some events differently and only decodes them sometimes.)
Motivation
Python 3 is on its way
Review checklist

[x] PR has a meaningful title or PR has the no-changelog label attached
[x] Feature or bugfix has tests
[x] Git history is clean
[ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
[ ] If PR adds a configuration option, it has been added to the configuration file.

Additional Notes
Anything else we should know when reviewing?

Codecov Report

Merging #2829 into master will decrease coverage by 6.32%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2829      +/-   ##
==========================================
- Coverage   84.65%   78.32%   -6.33%
==========================================
  Files         660        5     -655
  Lines       37759      143   -37616
  Branches     4535       16    -4519
==========================================
- Hits        31963      112   -31851
+ Misses       4462       23    -4439
+ Partials     1334        8    -1326

@gzussa no I've posted this for review a few times


c4test segfaults with e.g. basic1.c4m

Running c4test sometimes works:
$ build/c4test tests/basic1.c4m
info: Compiling from: tests/basic1.c4m
Processing module tests/basic1.c4m

[...]

Heap Usage: 27932 kb of 131072 kb (103139 kb free)
 Copied 7960 allocation records. Trashed 32380 records.
New Usage: 6304 kb (21627 kb collected)

and sometimes segfaults:
$ build/c4test tests/basic1.c4m
info: Compiling from: tests/basic1.c4m
zsh: segmentation fault (core dumped)  build/c4test tests/basic1.c4m

It looks like this was introduced by 1e6a017302e4438034a300f5a21e0eb2aeb723c8 (the codegen PR, https://github.com/crashappsec/libcon4m/pull/31). The commit before that seems OK.
The segfaults still occur with https://github.com/crashappsec/libcon4m/pull/36.

I cannot reproduce locally; please provide a stack trace.

Well, there is no free handler being set anywhere via con4m, so that branch shouldn't be running, period. That means the underlying object is somehow getting corrupted somehow (scribbling over the free_hander field). I say that because, even if not using calloc(), hatrack_dict_init is explicit about zeroing out fields. Unfortunately, when I add a watchpoint in a debugger, I see no corruption whatsoever.
So if you can track down any more info, that would be very helpful.

Okay, I found a candidate for the culprit.
Can you try, in c4m_collect_arena (gc.c), change from this:
    if (r == NULL) {
        r = c4m_rc_ref(global_roots);
    }

to this:
    if (r == NULL) {
        r = global_roots;
    }

    c4m_rc_ref(r);

It's definitely wrong and have made the change locally; even though I can't reproduce directly, I feel pretty good about it being the issue.


[FEATURES] Add an option to skip loading metadata

What feature you'd like to add:
Add an option to skip loading metadata after the dataset is initialized.
Why is this feature needed:
We may have too many small files to load, which makes loadMetadata in alluxio significantly slow and very likely to crash(due to OOM issues). So, in that case, fliud forcing the runtime to load metadata before use seems not a wise action.
Alluxio could serve requests if alluxio.user.file.metadata.load.type is ONCE

What about introducing a new attribute in the alluxioRuntime such as
metadataManagementPolicy{
    sync: (Never, Once, Always)
    syncPeriod:  1h
}

What about introducing a new attribute in the alluxioRuntime such as
metadataManagementPolicy{
    sync: (Never, Once, Always, Cron)
    syncPeriod:  1h
}

That would work in my case.

@framlog This feature is now supported in #2591 . Feel free to have a try following the guide doc here


Ended Zippers

I had code that was going to reduce a series of transformations over a zipper, written something like this:
transformations
|> Enum.reduce(Zipper.zip(ast), fn transformation, zipper ->
  zipper
  |> Zipper.traverse(&transformation.(&1))
  |> Zipper.top()
end)
|> Zipper.root()

but only the first transformation is ever run, because Zipper.top and all other functions essentially noop on {_tree, :end}.
I realize now that when traverse is done, the node is always the top of the tree so there's no need to be calling top afterwards regardless, and that really the issue you can't chain-traverse is the :end atom itself.
It seems like the :end atom is an implementation detail of traverse that has leaked its way to the rest of the functions. would it be incorrect to change the implementation of do_traverse like so?
-  defp do_traverse({tree, :end}, _), do: {tree, :end}
+  defp do_traverse({tree, :end}, _), do: {tree, nil}

this would allow a tree to be repeatedly traversed, and remove the need to handle :end as an equivalent to nil in so many functions as added in 35c8714b918b2bea9d836c0163024eda5ea50248
the only other function that can result in an end tuple are next_up and prev_up helpers
  defp next_up(zipper) do
    parent = up(zipper)

    if parent do
      right(parent) || next_up(parent)
    else
      {node(zipper), :end}
    end
  end

  defp prev_up(zipper) do
    parent = up(zipper)

    if parent do
      left(parent) || prev_up(parent)
    else
      {node(zipper), :end}
    end
  end

each of which could return an error (or nil) instead of the :end tuple, removing the special case of :end from the (exposed) type entirely - and letting me run traversals without having to wrap/unwrap or dig into the data ;)
if the idea seems solid to you i'd be happy to PR. thanks as always for the great library and all the fun things you've taught me.

I think that's actually intentional, as you don't want to endlessly recurse a zipper with next, the concept of an ended zipper serves this purpose so other functions need to be aware of this. However I agree that there should be a way to let you re-traverse a zipper.
I consider the zipper meta to be an opaque data structure so while you could in theory just replace :end with nil in your zipper to continue traversing, I think it would be Sourceror's responsibility to do that.
So instead of removing the idea of an ended zipper, I'd instead introduce something like reset/1:
def reset({tree, :end}), do: {tree, nil}
def reset(zipper), do: zipper

So your code would instead be:
transformations
|> Enum.reduce(Zipper.zip(ast), fn transformation, zipper ->
  zipper
  |> Zipper.traverse(&transformation.(&1))
  |> Zipper.reset()
end)
|> Zipper.root()

What do you think?

I consider the zipper meta to be an opaque data structure so while you could in theory just replace :end with nil in your zipper to continue traversing, I think it would be Sourceror's responsibility to do that.

agreed, that's how i like handling it as well =) it would indeed be trivial to just swap that second element and loop again, but it feels like going too deep under the hood

as you don't want to endlessly recurse a zipper with next

if next returned nil (or another error) when there was no next you'd still be safe from endlessly recursing:
# def next_up
    ...
    if parent do
      right(parent) || next_up(parent)
-    else
-    {node(zipper), :end}
    end

essentially, nil could be used to encode illegal moves (like it is in some places, like right/1), rather than returning {where_you_were, :end} for illegal moves
all that said, i realize i'm talking breaking changes so no stress

So instead of removing the idea of an ended zipper, I'd instead introduce something like reset/1:

that would solve the problem, but rather than expanding the api, what about changing top/1 to have the behavior you're proposing so that the original code works? semantically "go to the top" to mean means you've reset the tree anyways, and are no longer at the "end" =)
but if reset is the way to go for ease of introduction, what do you think of this definition?
def reset({tree, :end}), do: {tree, nil}
def reset(zipper), do: top(zipper)

thanks for the discussion!

essentially, nil could be used to encode illegal moves (like it is in some places, like right/1), rather than returning {where_you_were, :end} for illegal moves

admittedly, this'll result in a lot of if next = next(zipper), do: recurse(next), else: zipper style clauses, but we can see that the :end tuple similarly results in lots of def recurse({_, :end} = zipper), do: zipper clauses so it'd probably have about the same footprint
(sorry, this extra message is me thinking out loud ^.^)

Yeaah now that it's the weekend and i've looked more closely, sure seems like removing the concept of :end is a very big api change :) So I'd go for adding reset or changing how top works as a solution to the re-traversal problem. Thanks doorgan

and just for kicks (there's a blizzard here this weekend, so nothing else to do), here's what endless zippers would look like:
https://github.com/novaugust/sourceror/commit/d7a0a6d462ec77262b07f86cdeeba64937d4ff4e

After looking at how the projects using sourceror are using zippers, I'm not that concerned about this being a breaking change, I was more concerned about the semantics of the zipper itself. This module is largely based on the clojure/zip implementation of zippers, so the "ended zipper" part came from there.
Your solution to remove ended zippers seems to work, so a PR would be welcome!
I'd like to give a heads up to @NickNeck before going this route though, because the zipper_ex if memory serves is based on Sourceror's implementation of zippers.

Closed in #68


Test passes for objects that are not equal

The deepequal function  has some flaws in it that allows unequal objects to pass a test operation.
I am using jsonpatch.js in my tool jpt and came upon this a few weeks ago. The first tip off was when minifying with Google's Closure Compiler I was getting a warning about unreachable code with the for loop on line 393 and indeed the i++ is never reached because the next line is return on line 340
I went ahead and made my changes to get my tool working as expected, I'll just paste in here, vs. doing a pull request and thanks again @almost for your code it is very helpful for rounding out the features in my JSON power tool! 🙏  :]
function deepEqual(a,b) {
	var key;
	if (a === b) {
		return true;
	}
	else if(typeof a !== typeof b) {
		return false;
	}
	else if ('object' === typeof(a)) {
		var aIsArray = isArray(a),
		bIsArray = isArray(b);
		if (aIsArray !== bIsArray) {
			return false;
		}
		else if (aIsArray) {
			// Both are arrays
			if (a.length != b.length) {
				return false;
			}
			else {
				for (var i = 0; i < a.length; i++) {
					//original code lacked any conditional for return
					if(! deepEqual(a[i], b[i])){
						return false
					}
				}
				return true
			}
		}
		//Object - the original code was broken
		else {
			//quickly see if they have the same number of objects
			if (Object.keys(a).length !== Object.keys(b).length) { return false }

			// Check each key of the object recursively
			for(key in a) {
				if (!b.hasOwnProperty(key) || ! deepEqual(a[key], b[key])) {
					return false;
				}
			}
			return true;
		}
	}
	else {
		return false;
	}
}

Thanks! Wow that's quite a bug to have been hanging around this long. I'll make the fix


Death by Hamster

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #2168

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Demo vedio:
https://github.com/kunjgit/GameZone/assets/98798977/71476643-8b79-4293-8eaa-0f65ee43f78d

Thank you soo much for contributing to our repository 💗

Thank you @Durgesh4993 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@gurjeetsinghvirdee @kunjgit Please review and if you like that game so merge it

Thank you  @Durgesh4993 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Testing Tools

Determine best direction and tools for testing

For the FE, we will be using Jest and React Testing Library, that usually comes pre-configured with React installations, however we will probably have to do a manual install for this project.


Can't alt-tab out of fullscreen window fix

This prevented alt-tabbing out of fullscreen window with fullscreen resolution. I moved the code to the else clause because of the comment "If we are windowed fullscreen". It also says "ensures that window does not minimize when focus is lost" but it doesn't happen even without this code ( at least on Win10 ). Maybe it's needed on other OS, not sure.

@veins1 Thanks for the review. Fullscreen mode has been problematic in the past, maybe it should be reviewed again in the future...


feat: add modal and text input interactions

Please describe the changes this PR makes and why it should be merged:
Reference Discord API Docs PRs or commits:

https://github.com/discord/discord-api-docs/pull/4143

Upstream commit documentation landed

"landed"

"landed"

I can't read

New upstream PR: discord/discord-api-docs#4459 🎉

upstream pr was merged :tada:


refactor(cli.js): run on separate thread

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[x] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[ ] No

Checklist

[ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information

This is a fix for the Vue CLI plugin, see https://github.com/tauri-apps/vue-cli-plugin-tauri/issues/61


Update job tutorial

Update TensorFlow Dockerfile in job tutorial.
Fixes #932.

Coverage decreased (-12.8%) to 51.347% when pulling 41f802b44b67b0d44f4a25ce49870c206cc53008 on xiongyf/update-job-tutorial into bab0081b567caec29c59ced6ab7d9c1f209f411d on master.


[DOCS] Installing PHP on Linux guide not available

Description
There's no link for any guides to install PHP on linux

Screenshots
No response
Additional information
No response

Please reviews this and assign it to me under GSsoc

@iamvbenz49 Sure, Work on this. If you done with the steps then do same steps that you will write in readme in your laptop and share the screen record!

@iamvbenz49 update?

@iamvbenz49 ?

@apoorvaron Assign me I will complete it

Unassigning @iamvbenz49 because of inactivity and not replying
Assigned @Nishitbaria

@apoorvaron I have test in Linux and I should update readme or make video ? and I didnt change anything in .htaccess because i dont have any idea about it in linux but its ok

@Nishitbaria Create a PR by updating readme

and should show by gitclone or downloading zip ?

@Nishitbaria by gitclone


Package Request: linx-server

Project description
Self-hosted file/code/media sharing website.
Metadata

homepage URL: https://put.icu
source URL: https://github.com/ZizzyDizzyMC/linx-server
license: GPLv3
platforms: Linux

to confirm you are keen on getting the fork, not original tool packaged: https://github.com/andreimarcu/linx-server

to confirm you are keen on getting the fork, not original tool packaged: https://github.com/andreimarcu/linx-server

Yes.


Officially support Carthage for Maps SDK for iOS

This is an issue to track community input and feedback on officially supporting Carthage as a dependency manager for the Maps SDK for iOS library. Note that this issue does not pertain to this utility library as Carthage is already supported.
Is your feature request related to a problem? Please describe.
The Maps SDK for iOS currently supports CocoaPods and installing the SDK manually by downloading the binaries. This feature request is for the SDK to officially support Carthage and appropriately reflected on the documentation page under Get Started - Install the SDK.
Describe the solution you'd like
Developers should be able to include the Maps SDK for iOS binaries by including the following in their Cartfile:
e.g.
binary "https://path/to/GoogleMapsSDK-iOS.json" ~> 3.8.0

Describe alternatives you've considered
N/A
Additional context
See #99 #201 #249 #296

This would definitely be a huge deal for our team and would make it easier and faster for us to update to the latest version. We know that the Carthage project is a kind of abandoned, but for us, it's way too soon to migrate to SPM (binaries are not yet supported though we can expect that for the next Xcode release in June).
So, thanks for considering it and keep up the good work! 👍

This would definitely be a huge deal for our team and would make it easier and faster for us to update to the latest version. We know that the Carthage project is kind of abandoned, but for us, it's way too soon to migrate to SPM (binaries are not yet supported though we can expect that for the next Xcode release in June).
So, thanks for considering it and keep up the good work! 👍

Ah, yeah I was looking into SPM support and was a bit disappointed to see that binaries are not yet supported. I'll be keenly waiting for that.

Carthage is officially supported starting version 3.9.0. See: https://developers.google.com/maps/documentation/ios-sdk/start#use-carthage

Great work @arriolac! 💯 👏


Updated Yandex.Disk and Yandex.Mail doc url

The current url has redirect to the new url.

In the future, it might be better if you created a new branch for each PR. It helps avoid a ton of merge conflicts.

Ok, I'll keep it on mind :) Thanks!


Add codeownership for runtime lib.rs's files

This PR update CODEOWNERS file by assigning code ownership of runtime's lib.rs files to @paritytech/substrateteamleads according to this issue
Whether submitted PR touches one of above mentioned files it will require at least one approval from  @paritytech/substrateteamleads

As a team lead that never touches anything related to the runtime whatsoever (I don't think I was concerned by this issue), can I somehow exclude myself/disable these notifications?
Hi @tomaka
I'm afraid it is quite problematic. Other solution would be to use persons list instead of paritytech/substrateteamleads group. But this will require manual update on every group change.

I could also remove myself from that GitHub team. I don't really see what it brings to be in there.

I kinda feel like it is 100x more important to have this in polkadot repo. The substrate-node is not deployed anywhere and is essentially a kitchen sink of all pallets.

@kianenigma don't worry, CODEOWNERS will be everywhere at some point.

@tomaka  I could also remove myself from that GitHub team. I don't really see what it brings to be in there.

I agree with this. I think we should re-consider using that team and/or Github team structure for that in general. This team was initially created to allow for some release-based shortcuts and overwrites, but hasn't been maintained nor given any other special privileges or responsibilities since. I doubt that it is (as it currently exists) up to date in terms of the members, nor is it maintained and – in this area – shoots further than what is applicable. I and @tomaka (as current members of that team) shouldn't even have these privileges. I think using a newly created runtime-owners-github-team makes a lot more sense...

Well, actually this change is not needed for how we decided to implement this check. It will be a separate CI job and all this logic including mentioning the reviewers groups.
@gnunicorn you're right, this should be a separate group. In my opinion, all these groups assignments should be maintained by security team and be a part of on-/offboarding processes.


merge from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 -x 'tests/**/*' --temp-directory build/tmp ava && c8 report -r lcov -o build/coverage --temp-directory build/tmp
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/*-test.mjs' as in template
chore(package): set $.ava.extensions='mjs' as in template

Coverage decreased (-0.4%) to 33.653% when pulling c14027728df38c839fbd5ee30db10aafac75be9d on npm-template-sync/1 into e583641c857a26618f08b802e9970bf69820b824 on master.

:tada: This PR is included in version 8.5.55 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Make sure to reset commit count in the cache on mirror syncing

Fixes #4715

Codecov Report

Merging #4720 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4720      +/-   ##
==========================================
- Coverage   20.71%   20.71%   -0.01%
==========================================
  Files         167      167
  Lines       32355    32357       +2
==========================================
  Hits         6702     6702
- Misses      24672    24674       +2
  Partials      981      981

Impacted Files
Coverage Δ

models/repo_mirror.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24ba27...180a21d. Read the comment docs.

@adelowo please send a back port PR to release/v1.5

Done @lunny


Add support for System.Text.Json JsonPropertyName mapping

This PR contains change supporting JsonPropertyNameAttribute from the System.Text.Json package. In the unit test, I purposely fully qualified the attribute instead of adding a using statement so that it was clear this was from the System.Text.Json package.  I wanted to add a test for the JsonIgnoreAttribute however, I was not able to find the tests.  Since the attribute name is the same between System.Text.Json and Newtonsoft.Json I would assume it will work without changes.

Thanks for the PR. Looking good.


[AR Numbers] Add Arabic Numbers

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: AmmariJawher sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[FEATURE] Feedback on Javascript documentation

Is your feature request related to a problem?
We've gotten feedback on this topic: /docs/2.4/clients/javascript/index/
What solution would you like?
Feedback was "Missing descriptions on how to use bulk indexing"
What alternatives have you considered?
We got a similar request on /docs/latest/clients/java-rest-high-level/: "I am looking for bulk api"
Do you have any additional context?
Are there docs we can link to? Thanks.
Add any other context or screenshots about the feature request here.

In your opinion, does the content in helpers.md address the user's concern for examples? The page they commented on (https://opensearch.org/docs/latest/clients/javascript/index/) does link to that helpers.md page. If the content is sufficient, maybe we can move the link to the page up to the top of the page so it's more findable?

I think it does address what the user is looking for. And I agree, visibility is the issue here. We should either mention that bulk in in the helper article or merge the helper article into the index one since it's not that big.

Ok, thanks for taking a look! I'll get this addressed and comment back in this issue once we've resolved it.

We've added a series of guides. This is is about Bulk: https://github.com/opensearch-project/opensearch-js/blob/main/guides/bulk.md


Provide Support for form_post response_mode

Core Library
MSAL.js v2 (@azure/msal-browser)
Wrapper Library
MSAL React (@azure/msal-react)
Public or Confidential Client?
Public
Description
Recently Azure AD has increased the size of various tokens. See https://techcommunity.microsoft.com/t5/microsoft-entra-azure-ad/azure-ad-b2c-authorization-code-and-refresh-token-size-increase/m-p/3770890
As a result the size of URLS returned to the client app after auth can become very long. In our case that then triggered firewall rules that rejected the calls. :-(
Microsoft now recommed using a response_mode of form_post to remove the issue.
Our React SPA aap is using
"@azure/msal-browser": "^2.37.0",
"@azure/msal-react": "^1.5.7",
Source
External (Customer)

form_post is not possible for SPA apps unfortunately, as they run completely client-side.


Cannot pass entries from type JWTPayloadSpec into jwt.sign()

Problem: The argument morePayload of jwt.sign() is of type Record<string, string> & JWTPayloadSpec. This typing does not allow the field exp to be defined, among others, since JWTPayloadSpec defines their values as numbers, violating the Record<string, string> definition.

Closing, as I overlooked some of the options of use(jwt()), including the schema field.


gcc 4.9.2 - armv7 neon - simde_mm_unpacklo_epi64 give error about wrong argument type for vget_low_s64

I tryed to compile some code that uses SSE2 instructions for ARMv7 using gcc 4.9.2 (linaro-1.13.1-4.9-2014.09) and SIMDE release amalgamed-0.7.2.
The compiler gave me an error inside the simde_mm_unpacklo_epi64 function, saying that the wrong type of argument was passed to vget_low_s64 (line 21624 of x86/sse2.h) :
C:/XXX/include/simde/x86/sse2.h: In function 'simde__m128i simde_mm_unpacklo_epi64(simde__m128i, simde__m128i)':
C:/XXX/include/simde/x86/sse2.h:21624:42: note: use -flax-vector-conversions to permit conversions between vectors with differing element types or numbers of subparts
       int64x1_t a_l = vget_low_s64(a_.i64);
                                          ^
C:/XXX/include/simde/x86/sse2.h:21624:42: error: cannot convert '__vector(2) long long int' to 'int64x2_t {aka __vector(2) __builtin_neon_di}' for argument '1' to 'int64x1_t vget_low_s64(int64x2_t)'

After looking at the code :
#if defined(SIMDE_ARM_NEON_A32V7_NATIVE)
  int64x1_t a_l = vget_low_s64(a_.i64);
  int64x1_t b_l = vget_low_s64(b_.i64);
  r_.neon_i64 = vcombine_s64(a_l, b_l);

it seems that both vget_low_s64 should take a_.neon_i64 and b_.neon_i64 instead of a_.i64 and b_.i64 respectively

Thanks for the report.  This has been fixed (by b5fbe398a87b0138f1d636c3e69c9325689772b0) in git for quite a while (along with numerous other fixes and improvements) and will be part of the next release, so the easiest solution would probably be to upgrade.
The amalgamated headers are automatically built and deployed for each commit, so you can always download a copy of the latest version:

neon
sve
msa
relaxed-simd
simd128
avx2
avx512
avx
clmul
f16c
fma
gfni
mmx
sse2
sse3
sse4.1
sse4.2
sse
ssse3
svml
xop


Added optimal travis config

We're still intending to run on node 0.10, so I want to keep that as a target.

Fixed

Thanks. Merged as 9d06ec7


Add filepath to action variables

Currently, action templates support the following variables: {{filetype}} (neovim filetype), {{input}} (the selected text) and an {{argument}} (provided on the command line).
During an exploration in writing tests with LLMs, I found that providing the path to the file relative to the root of my project allowed my LLM to properly import the file to write the tests for it.
So I contributed {{filepath}}, a new variable which gets the relative path to the file being operated on.
This was done by adding a new method get_filepath to BaseAction and adding the filepath variable to render_template.
I tested this by writing a template with {{filepath}} and observing the path getting put into the prompt with this OpenAI compatible API https://gist.github.com/Berkodev/77000c57ec49f41ce73b754d684f10f9#file-openai_compatible_api_example-py

great, thanks for your contribution!


Should piston projects closely follow the rust style guide?

The rust team strongly encourages following style conventions as set out in the lints in the compiler and those in rust-guidelines. Do we want to make a best effort attempt to abide by these style guidelines? This would make it easier to contribute to projects under the piston banner without introducing style inconsistences among projects.
I ask because the code in wavefront-obj uses 2 space for indents while the rust convention is to use 4 spaces. Personally I perfer 2 space indents, but having uniform style is better than having your favourite style.
Thoughts?

I created https://github.com/PistonDevelopers/piston/issues/844
Closing.


Conjunctive rules with arbitrary number of features included

Describe the solution you'd like
Currently conjunctive rules are limited to two combining two feature rules. The suggestion is to add a depth parameter to allow more complex rules.
A solution could be to make the add_conjunctive-functions recursive, adding new features to already existing conjunctions for each iteration.

With version 0.0.18 (97a45ffeded8ac2c22a8209aee806358adb781cd), add_conjunctions allow creation of conjunctive rules with 2 or 3 rules. Tests have been made with larger conjunctions but these are disabled for now due to the following reasons:

the time taken to generate explanations combining more than 3 rules is simply too long
it is not possible to plot more than at most combinations of 3 features at present


[docs] project configuration -> tsconfig.json link is duplicated

TypeScript Version:  3.4.0-dev.201xxxxx

Search Terms:
site, duplicated link, docs, tsconfig.json duplicated link
Page to replicate:
https://www.typescriptlang.org/docs/home.html and then expand Project Configuration dropdown.
Actual behavior:

Can't confirm. Did you mess around with the docs to somehow trigger this bug?

I did not at the time, but I cannot replicate it anymore either - closing the issue. @garritfra


Read signed message through io.Reader in HashSign/HashVerify

When signed message is large, passing it through a byte array would cost memory; this switches to using io.Reader to avoid that.
Using io.Reader in the function signatures could also help diversify those HashSign/HashVerify from Sign/Verify, through a separate interface, alongside the crypto.Signer interface.

The idea behind this is to allow one-shot signature interface to be defined alongside crypto.Signer, something like:
type HashSigner interface {
  HashSign(rand, message io.Reader, opts SignerOpts) (signature []byte, err error)
}

and can be used like:
if hs, ok := priv.(crypto.HashSigner); ok {
  sig, err = hs.HashSign(config.rand(), bytes.NewReader(msg), signOpts)
  ...
}
sig, err := priv.Sign(config.rand(), signed, signOpts)
...

as suggested in https://go.dev/blog/module-compatibility

The idea behind this is to allow one-shot signature interface to be defined alongside crypto.Signer, something like:

FYI, here is a proposal for this; I'll try to see how well the HashSign/HashVerify could align with it.

@ueno - Assuming this is still valid, are you able to rebase?


Remove ingress.class filtering for consumer credential secrets

Consumer credentials secrets
These secrets should not have any concept of ingress.class. The annotation being present or absent should make no difference because the filtering is performed on the KongConsumer level.
Currently, when a custom ingress class annotation is used, a create/update/delete event for secret that doesn’t contain the custom ingress class annotation is ignored by the resource handler and this should be fixed.
For more background, please see the doc in #690.

This is similar to #735 #736

Handled in #767 by removing ResourceEventHandler filters.


send_email: Add setting to control max connection lifetime.

Fixes #21900.
I have not tested the code with a real SMTP connection, should the testing code here be sufficient or is there a need of me to test it out in a real world scenario?
Changes from the original plan:

The default for the setting is set to None, in order to avoid disruption to installs used to the existing behaviour.
When the setting is set to 0, we do not actively close the connection when the email is sent, but we open a new connection everytime we need to send a new one.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

The default for the setting is set to None, in order to avoid disruption to installs used to the existing behaviour.

Essentially all install that are not Zulip Cloud do not need this performance optimization, and we certainly do get big reports about how the current behaviour breaks things for users -- please do change this PR to make the default be non-persistent connections.  Backwards compatibility is not a concern here.

It looks like you addressed some of the review comments (the detault) but not others (using time_machine in tests, moving logic into the TimeAwareSMTPEmailBackend class instead of using isinstance).  Please ping me when this is ready for another review.
Two quick notes -- first, remember to update your commit message for the new defaults, etc.  Second, PersistentSMTPEmailBackend seems like a more precise name -- while it is true that it is time aware, that doesn't help me understand the greater purpose of the class.

@alexmv the previous push wasn't ready for review, I've addressed the requested changes and it's ready for review now.
Modifying the tests also led me to discover that my initial logic of setting opened_at at init was wrong, since the connection is not opened on init for SMTPBackend, I have moved that logic to open now.


Prototype strategy to enrich OpenAlex data with institutional information from Global Research Identifier (GRID)

Answer: yes