Make GlobalTracer uses more threadsafe

As discussed in #186 replace void register(Tracer) with a more
atomic boolean registerIfAbsent(Tracer) method.

Coverage increased (+0.3%) to 73.711% when pulling e148a76e890f43d557883e28ffbf1b9dcd48747b on sjoerdtalsma:globaltracer-concurrency into e385f73f6967583181c89e3d119ea717a2180ec3 on opentracing:master.

Callable sgtm

@pavolloffay Have your comments been addressed?

@pavolloffay @yurishkuro Are there any remaining concerns regarding this PR?
Otherwise it may be a good idea to merge this soon, to allow people to adapt to the deprecation as soon as possible.

lgtm, 🚢

The last activity on this PR is almost a month ago with three approvals given already.
@pavolloffay do you have any remaining concerns regarding this PR?
Otherwise I suggest we merge this soon, so people can get used to the deprecated method and its replacement.

@sjoerdtalsma sorry for long delay, thanks for the PR!

I think we could/should still keep GlobalTracer.register(tracer) or registerIfAbsent(Tracer) for simpler use cases. Integrations in runtimes usually controls tracer initialization.

@sjoerdtalsma do you want to tackle it in this PR? If not let's merge this and do it sepratetely.

I am also a bit concerned about callable. Maybe a separate interface would be better. Callable somehow indicates use of executors which is not the case here.

@pavolloffay

I think we could/should still keep GlobalTracer.register(tracer) or registerIfAbsent(Tracer) for simpler use cases. Integrations in runtimes usually controls tracer initialization.

I'm not sure I understand what you mean here. registerIfAbsent is a replacement of register. Do you know of a use-case for register that isn't possible with registerIfAbsent? It is entirely possible that I misunderstood your comment.

I am also a bit concerned about callable. Maybe a separate interface would be better. Callable somehow indicates use of executors which is not the case here.

My ideal would be to use a Supplier<Tracer> but that doesn't exist in our java version yet.
I actually started with a separate TracerSupplier interface but you asked whether it was necessary. Discussion and agreement amounted to just using Callable and wrap the checked exceptions as the most simple solution and not worthy of a separate interface just for this purpose.
I'm not against re-introducing the separate interface again, but maybe we're running in circles on this one?

Maybe someone should just merge this in and if there are many questions re: Callable, replace it by TracerSupplier at that time?

@sjoerdtalsma I mean we should also keep simple registerIfAbsent(Tracer tracer) without callable. Usually, runtimes control tracer initialization so there is no need for callable!

@pavolloffay

This can go in registerIfAbsent(Tracer tracer) can be added in a separate PR

It may be good to discuss the Tracer variant in a separate PR indeed, re: @yurishkuro's comment here: https://github.com/opentracing/opentracing-java/pull/269#discussion_r181815569
Thanks everyone for their review, could someone with merge rights merge this then? :wink:

@sjoerdtalsma think does not work for me, I will merge this now


ARROW-10610: [C++] Updated vendored fast_float version to latest

This should fix the big endian (s390x) CI failures.

s390x CI passed at https://travis-ci.org/github/pitrou/arrow/builds/745452694

LGTM, thanks


progression: add item IsActionBlocked exception mechanism

In vanilla, it is possible to find Poison Arrows in Sunken Crypts in the Swamp, even though they cannot be crafted until finding Obsidian in the mountain.
This change adds an exception similar to the existing exceptions for Entrails, allowing Poison Arrows to be used as soon as the right biome is accessible, bypassing the recipe check.

Please merge this @OrianaVenture

Let me know if I can do anything to get this merged 😄

It is not my intention to be able to use poison arrows until defeating bonemass. They are the same damage level as obsidian and frost arrows, and I think they need to be treated as such. To get around this people are free to use other mods to alter the recipe of poison arrows to use different ingredients, and make other adjustments like the mod Wacky's Database.
Eventually I want to allow full customization of the locking system. When that feature is implemented there will be ways to reassign items and the keys required to unlock their usage. This will include checking just for prefab names rather than their recipes.

It is not my intention to be able to use poison arrows until defeating bonemass. They are the same damage level as obsidian and frost arrows, and I think they need to be treated as such.

The thing is they're a vanilla item found in vanilla Sunken Crypts before defeating Bonemass, so as it stands the mod is creating a frustrating situation for players because they find an item in a legitimate way, not bypassing the regular progression, and they can't use it (in particular this is very annoying for first time players discovering the game).
Also the mod already has a similar situation with Entrails since they can be found in Meadows, and there's already an exception for that one, so it felt consistent to me to fix it 😄

(FWIW, I had so many users complain about this that I actually implemented this PR as a separate patch in our modpack, without having to wait for a decision to be taken here 😅)

If your external patch is working for you and your players I encourage it. If it is something that can be shared to thunderstore as an external module I can then even recommend it to other players who feel the same way. Another issue with hard coding an exception for poison arrows would be if they were already changed to alter the progression in another way - the exception now needs to be optional which falls into the customization feature I still need to implement. So this is out of scope currently and will not be merged in.

Another issue with hard coding an exception for poison arrows would be if they were already changed to alter the progression in another way - the exception now needs to be optional which falls into the customization feature I still need to implement.

If the issue was addressed independently, of course that needs to be changed once the bug fix is merged, but that's just expected and "business as usual" 😅
I really think we're in a "perfect is the enemy of good" situation right now: by itself, the mod actively creates a quirky situation which feels like a bug to users, hence why I think this is to be considered a bug fix and not a feature, and also why I think it does not need to be optional at all: this is bug w.r.t. to vanilla, and the mod already hardcodes all keys w.r.t. to vanilla, so it does not change anything w.r.t. to the status quo that mod users / modpack authors should except when using the mod.
Of course it would be better to have full blown configurability, but that's IMO a different thing that should be tackled independently.

So this is out of scope currently and will not be merged in.

That is of course your call to make, I don't think I can add any more arguments that what I already stated, so please do close the PR if you still don't think it is sensible 😉

This is hilarious, mutiple people are asking you to change this and you won't
I get continual bug reports from my players when the gods reject them from an item the can "legally" obtain from crypts
You should be allowed to use poison arrows just not craft them, you're literally deviating from vanilla progression

@Jonny-Havoc I don't think using such a tone is productive... You can state your opinion without acting entitled. The mod author is ultimately the sole person that decides if something belongs to the mod or not, and we should always respect that.


cup all fails to update Python 2.7 due to custom path

If you use the ‘cup all’ command to update the packages it doesn’t work as expected for Python2.7. Unfortunately, the Chocolatey Python2.7 package is configured to install to C:\Python27 instead of where FLAREVM has it installed under C:\Program Files. So when someone uses ‘cup all’ it will automatically update/install into C:\Python27 instead of updating the existing Python installation, which of course interferes with all the awesome Python scripts your team included in C:\Program Files\Python27\scripts.

Is this related to https://github.com/fireeye/flare-vm/issues/40? I experienced the same issue after an update.

Likely related. I'll close this one and keep #40


corrected misleading documentation

Change Description

Example suggests RicardianContractFactory comes as a default export when it doesn't.
API Changes

[ ] API Changes

Documentation Additions

[X] Documentation Additions

Thanks for the PR, glad you caught that! One thing though, our process is that development and PRs should happen based on the develop branch. PRs to master only occur prior to a new release which will roll up all changes since the last release. I have updated your PR appropriately, but please take a look at the CONTRIBUTION.MD doc, in particular Feature Branches.
Unfortunately this now needs a git rebase and you'll need to do that locally in your branch and push again.
Thanks again!


Add GraphQL world index types and query (alternative, other take)

Trello card
This is a more stripped-down-version of #2930, which added a few extra fields to the EditionType. As there's a fair bit more thought required for adding those fields, I felt it would help us get things unblocked slightly if we leave those extra fields for now and add them in future branches.
These new types will allow us to get the data the frontend Collections app needs to render the gov.uk/world page using the GraphQL endpoint.
As mentioned, the EditionType here is very minimal, to make this change as small as possible. We'll be adding additional fields to this in upcoming branches, but these extra fields aren't really necessary for the majority of the /world page in of itself, and there's a fair bit of complexity involved in some of the Edition fields e.g. Links that needs further thought.
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.

When you do merge this, could you remove the "(alternative, other take)" from the PR title first, just so it doesn't end up in the commit history and cause confusion in the future!


Throw error. Missing template

Environment

Operating System: Linux
Node Version:     v18.18.0
Nuxt Version:     3.8.2
CLI Version:      3.10.0
Nitro Version:    2.8.1
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
Here's Stackblitz
npm run build
npm run start
go to /user/dsdsd
Describe the bug
When start production server with node .output/server/index.js  and in error page is throwed i get [Vue warn]: Component  is missing template or render function.
What is going on? How to remove this warn?
Additional context
No response
Logs
No response

Did you mean to have your user.vue file named index.vue ?

Did you mean to have your user.vue file named index.vue ?

hi, no.  user.vue - parent route. user folder - children. I improved the example for clarity on StackBlitz

For now, you can run NODE_ENV=production node .output/server/index.mjs instead.
cc: @pi0 It seems we have a regression with tracing export conditions as the Vue dev build is also getting picked.

Let's track in https://github.com/nuxt/nuxt/issues/23402.

This is now resolved (for vue) in the latest release of @vue/runtime-core! 🎉
See bundle size diff in https://github.com/nuxt/nuxt/pull/25036/files#diff-04a7585c5d6ddd5cf80321c69bc6e07cd85e9e86ae35fa5f9c036651f137c312.


missing-x-ms-identifiers linter false alert with @encodedName

See example.
Seems playground does not show the lint warning.
Local compile will report this warning:

Thanks. BTW, linter rule can be enabled in playground via settings (the cog icon)

here we could update the linting rule to be aware of the @encodedName setting


reconnection for publishers

I've seen examples here on how to implement better reconnection when consuming. Does anyone now a good way or how would you handle reconnections with publishers?

Largely the same way. The only difference is that you need to pay attention to the attempted publishes and the what delivery tags were confirmed. Note that when you open a new channel, delivery tag counter will be reset.

It will be wonderful feature if connector can recover itself. @michaelklishin


NIFI-11940 Add SSLContextService to GetSplunk processor

Summary
NIFI-11940
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[ ] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

Thanks for the improvement @nandorsoma.
Unfortunately, the design of the Splunk SDK Service class is not suited for a configurable SSLSocketFactory based on the static configuration approach. Calling the Service.setSSLSocketFactory method changes the Socket Factory for all instances of the Splunk Service, which would impact all instances of the Processor, and other Processors that use the Splunk SDK.
One option might be to use instance class-loading, as used in several Hadoop-based Processors. Another more involved option would be the replace the Splunk SDK client with custom network client libraries that support configurable TLS properties.

Thanks for the quick review @exceptionfactory! You are right about the issue regarding static configuration. Thank you for bringing that to my attention!

Thanks @nandorsoma for the contribution. I tested the SSLContextService with the GetSplunk processor and it works well.
It's important to note that as there isn't an explicit option for configuring SSL modes, using the "https" scheme requires the obligatory use of an SSLContextService. Consequently, the necessity for the new property hinges on the specified scheme value.
Regarding the proposed solution by @exceptionfactory can we move forward with @RequiredInstanceClassloading? I am open to testing it should an update be made.

@Lehel44 I don't think we should move forward with the RequiresInstanceClassloading change here unless we do it all for the Splunk Processors, and that raises some other questions. For now, it is still possible to work around this issue by updating the JVM cacerts trust store instead.

@exceptionfactory What is the hesitation to use the instance classloader solution here?  It seems that is what it was made for.  It probably makes sense to ensure that is done on each splunk processor as you note but why avoid it?

@exceptionfactory What is the hesitation to use the instance classloader solution here? It seems that is what it was made for. It probably makes sense to ensure that is done on each splunk processor as you note but why avoid it?

The optimal solution would involve replacing the Splunk SDK with lower-level HTTP request and response handling. However, that would be a lot more work, so going forward with instance ClassLoader approach is probably the best solution under the circumstances. I withdraw my comment on avoiding that approach.

@nandorsoma @Lehel44 Do you plan to complete the change then to move to instance classloading so we can work past the poor usage of statics for security settings in the splunk libs?

@nandorsoma @Lehel44 Do you plan to complete the change then to move to instance classloading so we can work past the problematic usage of statics for security settings in the splunk libs?

Thanks for bumping it, @joewitt! We were about to close this PR, but as @exceptionfactory withdrew his previous comment, we will push the PR over the finish line.

@nandorsoma do you still plan to complete this?

@nandorsoma do you still plan to complete this?

Yep, @joewitt, I intended to do this on the week starting tomorrow.

Thanks @joewitt and @exceptionfactory for the patience. I've added the isolation functionalty and rebased the branch as it was a bit old. Tested it with splunk enterprise edition, works as intended.

Do we have plans to do the same for the other Splunk processors (sinks)?


Empty local variables + (theme) contexts like dark & saturated

The intent of local variables is that they remain empty, so they always work at the :root level. However in some components, such as pfe-tabs, we use these variables to reset colors in dark or saturated contexts, for example, currently in pfe-tab.scss we have:
 :host([on="dark"][pfe-variant="earth"]) {
  --pfe-tabs--Color: #{pfe-var(text--on-dark)};
}

whereas if we instead redefined the original CSS properties such as border and color, and then set the value using the pfe-local function with the $fallback argument, this would preserve the empty local variable as a theming hook, while still setting the correct color for that context.
:host([on="dark"][pfe-variant="earth"]) {
  .pfe-tab * {
    color: pfe-local(Color, $fallback: pfe-var(text--muted--on-dark));
  }
}

The downside of this approach is that it makes theming the component a bit more tedious, because you have to redefine complex selectors, especially when state or light DOM is involved.
However if we leave it as-is, folks wanting to redefine the text color of tabs in a dark context would be forced to figure out that they must use the pfe-tab selector (note that the component is pfe-tabs, so this is not intuitive). Even !important doesn't work with :root.
pfe-tab{
--pfe-tabs--Color: pink;
}

Note that currently the pfe-cta component prints the following CSS  (which redefines all local vars)for each instance of the priority attributes, variant attributes, theme context attributes, states, and color attributes.
:host([pfe-priority="secondary"][pfe-variant="wind"]) {
  --pfe-cta--BackgroundColor: transparent;
  --pfe-cta--BorderColor: var(--pfe-theme--color--surface--border, #d2d2d2);
  --pfe-cta--Color: var(--pfe-broadcasted--link, #06c);
  --pfe-cta--FontWeight: var(--pfe-theme--font-weight--normal, 500);
  --pfe-cta--BackgroundColor--hover: var(--pfe-theme--color--surface--border--lightest, #f5f5f5);
  --pfe-cta--BorderColor--hover: var(--pfe-theme--color--surface--border, #d2d2d2);
  --pfe-cta--Color--hover: var(--pfe-theme--color--link--hover, #004080);
  --pfe-cta--TextDecoration--hover: var(--pfe-theme--link-decoration--hover, underline);
  --pfe-cta--Color--focus: var(--pfe-theme--color--link--hover, #004080);
  --pfe-cta--BorderColor--focus: var(--pfe-theme--color--surface--border, #d2d2d2);
  --pfe-cta__inner--BorderColor--focus: var(--pfe-cta--BorderColor--focus, transparent);
}

this means that redefined local vars on the :root` have little effect,

but if you change the selector to pfe-cta then you can override all instances of the CTA.

Whatever we decide, I'd like to make sure it's documented, and consistent across components.

Okay let's say we have <pfe-cta pfe-priority="secondary" pfe-color="accent" on="dark">;

[pfe-priority="secondary"][pfe-color="accent"] -- these are both added by the author
[on="dark"] -- this is added by the base class (pfelement) automatically

In the stylesheet for pfe-cta, I have this map:
$secondary-accent-dark: (
    BackgroundColor: transparent,
    BorderColor: pfe-var(ui-accent--on-dark),
    Color: pfe-var(ui-accent--on-dark),

    BackgroundColor--hover: pfe-var(ui-accent--on-dark),
    BorderColor--hover: pfe-var(ui-accent--on-dark),
    Color--hover: pfe-var(ui-accent--text),

    BackgroundColor--focus: pfe-var(surface--lighter),
    BorderColor--focus: pfe-var(ui-accent--on-dark),
    Color--focus: pfe-var(ui-accent--on-dark),

    inner: (BorderColor--focus: pfe-var(ui-accent--on-dark)),
  );

And it is being invoked here:
:host([pfe-priority="secondary"][pfe-color="accent"][on="dark"]) {
  @include pfe-print-local($secondary-accent-dark);
}

This is the compiled output:
:host([pfe-priority="secondary"][pfe-color="accent"][on="dark"]) {
  --pfe-cta--BackgroundColor: transparent;
  --pfe-cta--BorderColor: var(--pfe-theme--color--ui-accent--on-dark, #7dc3e8);
  --pfe-cta--Color: var(--pfe-theme--color--ui-accent--on-dark, #7dc3e8);
  --pfe-cta--BackgroundColor--hover: var(--pfe-theme--color--ui-accent--on-dark, #7dc3e8);
  --pfe-cta--BorderColor--hover: var(--pfe-theme--color--ui-accent--on-dark, #7dc3e8);
  --pfe-cta--Color--hover: var(--pfe-theme--color--ui-accent--text, #fff);
  --pfe-cta--BackgroundColor--focus: var(--pfe-theme--color--surface--lighter, #f0f0f0);
  --pfe-cta--BorderColor--focus: var(--pfe-theme--color--ui-accent--on-dark, #7dc3e8);
  --pfe-cta--Color--focus: var(--pfe-theme--color--ui-accent--on-dark, #7dc3e8);
  --pfe-cta__inner--BorderColor--focus: var(--pfe-theme--color--ui-accent--on-dark, #7dc3e8);
}

^ This means it's harder for me as an author be create global customizations on my page.
For an author to be able to customize this component, we would need to use this approach instead:
$hold: $LOCAL-VARIABLES;
$LOCAL-VARIABLES: $secondary-accent-dark;

:host([pfe-priority="secondary"][pfe-color="accent"][on="dark"]) {
  background-color: pfe-local(BackgroundColor);
  border-color: pfe-local(BorderColor);
  ::slotted(*) {
    color: pfe-local(Color);
  }
}

:host([pfe-priority="secondary"][pfe-color="accent"][on="dark"]:hover) {
  --pfe-cta--BackgroundColor: pfe-local(BackgroundColor--hover);
  --pfe-cta--BorderColor: pfe-local(BorderColor--hover);
  --pfe-cta--Color: pfe-local(Color--hover);
}

:host([pfe-priority="secondary"][pfe-color="accent"][on="dark"]:focus) {
  --pfe-cta--BackgroundColor: pfe-local(BackgroundColor--focus);
  --pfe-cta--BorderColor: pfe-local(BorderColor--focus);
  --pfe-cta--Color: pfe-local(Color--focus);
}

$LOCAL-VARIABLES: $hold;

Now this means that --pfe-cta--BackgroundColor set on root will influence CTAs of every variation.  Is this desirable?  I can't speak to that.  I kind of think it's not because I don't want a primary and a secondary CTA to get the same global style changes.
I know it's verbose and a bit kuku-bananas but wouldn't I need something like --pfe-cta--BackgroundColor--secondary--accent--on-dark for that kind of granular styling?

Another way to approach this conceptually:
//-- Contextual update - this sets the color to be featured
:host([pfe-color="accent"]) {
  --pfe-cta--accent: pfe-var(ui-accent);
  --pfe-cta--accent-text: pfe-var(ui-accent--text);
}

:host([pfe-color="accent"][on="dark"]) {
  --pfe-cta--accent: pfe-var(ui-accent--on-dark);
  --pfe-cta--accent-text: pfe-var(ui-accent--text--on-dark);
}

:host([pfe-color="accent"][on="saturated"]) {
  --pfe-cta--accent: pfe-var(ui-accent--on-saturated);
  --pfe-cta--accent-text: pfe-var(ui-accent--text--on-saturated);
}

//-- The variant determines to which properties the values are applied
:host([pfe-priority="secondary"]) {
  background-color: transparent;
  border-color: pfe-local(accent);
  ::slotted(*) {
    color: pfe-local(accent);
  }
}

//-- State, update the properties that change
:host([pfe-priority="secondary"]:hover) {
  background-color: pfe-local(accent);
  ::slotted(*) {
    color: pfe-local(accent-text);
  }
}

:host([pfe-priority="secondary"]:focus) {
  background-color: pfe-var(surface--lighter);
  .pfe-cta__inner {
    border-color: pfe-local(accent);
  }
}

Now this means that --pfe-cta--BackgroundColor set on root will influence CTAs of every variation. Is this desirable? I can't speak to that. I kind of think it's not because I don't want a primary and a secondary CTA to get the same global style changes.

I would agree that it's undesirable; since the styles are so different (button vs non-button).

For the user, this would mean if you use pfe-priority="secondary" and you don't add pfe-color="accent", you can set --pfe-cta--accent on :root and it will influence your secondary and primary CTAs in different but perhaps more obvious ways.

I'm slightly confused on this one; it seems like the user would have to put the attribute pfe-color="accent" on the CTA for it to invoke usage of the variables   --pfe-cta--accent or --pfe-cta--accent-text. But after they did, it sounds like your point is that they could change the value of those accent vars and it would only impact the CTAs with that attribute

Can we break variables down into 2 groups?
State

State interactions are triggered by the site visitor
Page-builder-devs should be able to control state-vars AND  original variables, independently
Create separate vars for these, that show up in the debug mixin print-out and in the console
In this instance, it would be ok to redefine the value of a local variable, because its value is another local variable which we expect page-builder-devs to use.

:host(:hover){
  --pfe-tabs--Color: var(--pfe-tabs--Color--hover);

Everything else
These items are choices made by the dev building the page

Context (on) attribute, i.e.  <pfe-cta on="dark">

Page-builder-dev  should be able to override vars even if component is in a dark context

Color attribute, i.e.  <pfe-cta pfe-color="accent">

Affects color-specifically, but its not clear where or how

These could have their own set of variables, like

--pfe-cta--accent
--pfe-cta--complement

But, Page-builder-devs should still be able to override vars like margin or padding, even if they are leveraging an attribute that changes colors

Variant attribute, i.e.  <pfe-tabs pfe-variant="earth">

Affects multiple properties such as padding, border, color, etc.
Support local var overrides
Page-builder-dev  should be able to override vars like color, even if they are leveraging an attribute like pfe-variant=earth on tabs, because that alters padding, borders, margins, etc

Priority attribute  i.e.  <pfe-cta pfe-priority="primary">

Affects multiple properties such as padding, border, color, etc.
Page-builder-dev  should be able to override vars like color, but may need to do so per priority type

Ways to tackle the implementation
Option 1, build selector once, list all possible vars that control color, then you only need to build the host+attributes selector further on down in the file?
:host(){
    pfe-tab > *
    color: pfe-local(Color);
    --pfe-tabs--Color--on-dark: pfe-local(Color, $fallback: lt-blue);
    --pfe-tabs--Color--on-saturated: pfe-local(Color, $fallback: white);

:host([on="dark"]){
    color: pfe-local(Color--on-dark)

:host([on="saturated"]){
    color: pfe-local(Color--on-saturated)

Option 2, build selector again & again, redefine property each time, leverage $fallback
:host(){
     pfe-tab > *
        color: pfe-local(Color)

:host([on="dark"]){
    pfe-tab > *
        color: pfe-local(Color, $fallback: #760

Option 3 for pfe-color (not mutually exclusive to the other two options)
Per Cassondra's suggestion, add an abstract variable with the name of the color (accent or complement)
:host([pfe-color="accent"]) {
  --pfe-cta--accent: pfe-var(ui-accent);
  --pfe-cta--accent-text: pfe-var(ui-accent--text);
  --pfe-cta--accent--hover: pfe-var(ui-accent--hover);
  --pfe-cta--accent-text--hover: pfe-var(ui-accent--text--hover);
}

@starryeyez024 Do we know if this issue is resolved at this stage or if there's still more work to do?  Maybe documentation needs?


Remove deprecated url field from product

I want to merge this change because...

Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] Changes are mentioned in the changelog.

Task linked: CU-66mv37 Remove url field from product


Bootstrap disables Chrome default validation error tooltip when input field is out of window (scrolled away)

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
Adding bootstrap to site disables chrome default validation error message when input field is out of window (scrolled away)
Reduced test cases
Here is an example: https://dcygt4.stackblitz.io/
Open in chrome or edge, scroll down and click submit, no error message is shown.
Remove bootstrap from source here https://stackblitz.com/edit/dcygt4?file=index.html
And message is shown.
Note, the message will be shown in the embedded stackblitz and codepen viewers. Also works in Firefox
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome, Microsoft Edge
What version of Bootstrap are you using?
5.3.0

Duplicate of #33757?


Possible bug in send_seen

Hi team,
I'm not sure if the send seen functionality was implemented correctly. Maybe this is a possible bug. The send seen is implemented currently as follows:
var chat = window.WAPI.getChat(id);     if (chat !== undefined) {         if (done !== undefined) {             Store.SendSeen(Store.Chat.models[0], false).then(function () {                 done(true);             });             return true;         } else {             Store.SendSeen(Store.Chat.models[0], false);             return true;         }     }     if (done !== undefined) done();     return false;
Should it not be like the following where 'Store.Chat.models[0]' is replaced by 'chat':
var chat = window.WAPI.getChat(id);     if (chat !== undefined) {         if (done !== undefined) {             Store.SendSeen(chat, false).then(function () {                 done(true);             });             return true;         } else {             Store.SendSeen(chat, false);             return true;         }     }     if (done !== undefined) done();     return false;
Could this be a possible bug? I've made the replacement and it allows me to mark the chat as read even if was received a while back while the current implementation seems to only work when the chat is the latest one. Otherwise I don't understand why we had to get the chat object in the first place?

@blackchineykh  Hi, I'm testing with about 385 groups of whatsapp to see the behavior

@blackchineykh Excellent, your solution has worked correctly, it has been added in my repository and also in this repository.
https://github.com/Theblood/Wapi_NEW/blob/master/wapi.js

Great. I'm seeing the changes applied. Will close this


Connect with Calligraphy

Hi, is there any way to connect calendar with Calligraphy font? It seems not working as default ;(

No solution?

Same problem, Im trying to apply fonts on DayView but isn't working.

https://github.com/prolificinteractive/material-calendarview/issues/382


Can parameters pass multiple nested objects？

When I pass in the parameter foo:{a:1}, it works normally. When I pass in foo:{a:{i:1,j:2}}, it does not work properly and an error is reported:
{
"message": "Invalid or incomplete introspection result. Ensure that you are passing "data" property of introspection response and no "errors" was returned alongside: null.",
"stack": "Error: Invalid or incomplete introspection result. Ensure that you are passing "data" property of introspection response and no "errors" was returned alongside: null.\n    at r (http://localhost:8000/src/scripts/graphiql.min.js:1:24582)\n    at lr (http://localhost:8000/src/scripts/graphiql.min.js:1:327086)\n    at http://localhost:8000/src/scripts/graphiql.min.js:7:45108"
}
I have implemented the background logic.  I can get these parameters through api access, the error only occurs in the debug page of graphiql

seems that your provided fetcher is not fetching the introspection schema properly?

Came here with same error but different problem.
Django users, make sure you have this in your settings middleware:
"corsheaders.middleware.CorsMiddleware"


Add "buildx" and "compose" CLI plugins (for supported architectures of each)

Closes #303
Closes #355
Closes https://github.com/docker/roadmap/issues/322

(I don't actually have permission for this to auto-close https://github.com/docker/roadmap/issues/322, so maybe someone like @thaJeztah or @chris-crone can do the honors once we get this in.)
Refs:

#18
#30
#42
#156
#243
#313
https://github.com/docker/compose/issues/8871
https://github.com/docker/roadmap/issues/256
https://github.com/docker/docker-ce-packaging/pull/309

As a warning, this does very severely bloat the size of the Docker images (something like 100MiB more), but given these are part of the "Docker Experience" I think it makes sense. :see_no_evil:

👍 great!
By the way, can we provide a tag like non-plugin, which means that plugin is not included.
Because in our actual scenario, DinD is heavily used in CI without the need to use plugins.  It would be nice to not increase the size of the image. Thanks

:see_no_evil: that's exactly the type of request I've been hoping to avoid all this time :sweat_smile:
If anything, I'd love to maintain less variations of this image than more. :innocent:
I've also been very strongly considering moving from Alpine to Debian or Ubuntu for the next (22.xx) release, since the experience of using Docker-Inc-provided Docker builds on both of those platforms is much more well-supported than Alpine is. :disappointed:

I've also been very strongly considering moving from Alpine to Debian or Ubuntu for the next (22.xx) release

As a drive by comment, I too will say that I've hit rough edged working with the Alpine-derived Docker images. If you don't need to do any changes they work well, but the moment you want to add some scripts or anything else to image Alpine is harder to use.
Also big ❤ for getting Compose v2 into an official image.

With the implementation currently in this PR, new versions of Compose will be integrated as they're released (so you'd have to pin to an image digest if you want something that doesn't change).

I am used to Alpine from the times when there was no great slim alternative and I have been sticking to it to copy and paste proven recipes. Now that we have, for example, an Ubuntu image with a footprint below 30 MB, I think that in principle it would be fine to switch. However, please keep in mind how many people use these images. Making the switch will easily require thousands of developer hours in downstream projects and Pipelines. So it would be nice if you kept it as long as it doesn't become a major drain on your time.

Once merged this would allow to finally resolve https://github.com/docker-library/docker/issues/156.

Just to record this somewhere, I did some testing on combining layers here to see if we get some compression efficiencies on transport (h/t @chris-crone), and the answer is a big resounding "no" -- building this as-is, the total "compressed size" of all layers is 89.47MB.  If I combine both plugins layers into a single one, it's the same.  Even if I combine the full Docker/containerd binaries layer as well, it's still exactly the same. :grimacing:
(So my preference is to continue to leave them separate.)

I guess this is also a good place to note that the comparison to "current" from that is ~66.99MB, so for transport, this is not a huge increase.

Just to record this somewhere, I did some testing on combining layers here to see if we get some compression efficiencies on transport (h/t @chris-crone), and the answer is a big resounding "no" -- building this as-is, the total "compressed size" of all layers is 89.47MB. If I combine both plugins layers into a single one, it's the same. Even if I combine the full Docker/containerd binaries layer as well, it's still exactly the same. 😬
(So my preference is to continue to leave them separate.)

I was so sure that gzip would make the duplicated Go runtime go away but alas 😢

Now that Compose v2 is included in the docker image, should docker/compose (v1) be updated with a notice that it deprecated?

@tianon I don't know if it's moving up to Compose v2 or buildx or some combination, but when we moved our CI that runs docker/compose:1.29.2/docker-compose build --parallel -> docker/docker compose build our compose project (multiple multi-stage Dockerfiles) built twice as fast. ❤
Thanks!


PR: Update old things and remove unnecessary stuff

Fixes #51

@steff456, before merging this one, please solve issue #54.


Services list on Wiki

List those on the Wiki and then link from the About page.

[x] Add to OHM Wiki page
[ ] Link to that page on About on OHM website

See https://wiki.openstreetmap.org/wiki/Open_Historical_Map#OHM_Web_Services


[qt5-webglplugin] qwebgl.dll is not included in the installation file

Host Environment

OS: Windows10
Compiler: visual studio 2022 17.4.2

To Reproduce
Steps to reproduce the behavior:
branch: https://github.com/microsoft/vcpkg/pull/24683
.\vcpkg install qt5[activeqt,core,declarative,essentials,imageformats,multimedia,networkauth,quickcontrols2,svg,tools,webglplugin,websockets,xmlpatterns,webview]:x64-windows
Failure logs
qwebgl.dll is not included in the installation file, but qwebgl.dll is included in the file installed directly using the QT online installer.
vcpkg:

QT installer

I just tried the main branch and the result is the same

seems like it needs more dependencies. Otherwise it won't build anything


Agent: add protocol documentation

Previously, we didn't have any clearly written high-level overview of the Cody Agent protocol. As we are increasingly relying on this protocol for different use-cases (JetBrains plugin, ML evaluations, testing), it's worth investing time into documenting the protocol.
Test plan
Green CI

This is still a work-in-progress, but I want to merge it so I can send a PR with smaller fixes for the Kotlin codegen. It's a low-risk PR to merge because this code is off the critical path.


gcp cloud run app

module "application_cloud_run" {
  source          = "github.com/massdriver-cloud/terraform-modules//gcp-application-cloud-run"
  location        = var.location
  container_image = "${var.container.repository}/${var.container.image}:${var.container.tag}"
  endpoint        = var.endpoint
}

What is the second module in here?

It's for making the load balancer, cert, network endpoint group for cloud run or cloud functions. It makes the cloud-run module even simpler and can be used in our existing bundles as well.

Nice. The endpoint is a general purpose that we can reuse, yeah?

Nice. The endpoint is a general purpose that we can reuse, yeah?

Yes, for cloud run or cloud functions it's a reusable non-MD-dependent bag of Terraform. It essentially makes a pretty DNS name for a cloud run or function dead-simple.

Going to reopen after validating access to private database services


Number of generated items does not match input

Describe the bug
I ran a ilab generate using the merlinite-7b-lab-Q4_K_M_2024 model.  I used the following command:
ilab generate --num-instructions 10
And it was completed successfully.
To Reproduce
Expected behavior
I expected the generated_merlinite-7b-lab-Q4_K_M_2024-06-04T15_44_20.json and the train_merlinite-7b-lab-Q4_K_M_2024-06-04T15_44_20.jsonl files to each have 10 output entries.  However, I got 11 for each.
Screenshots

Additional context

num-instructions is actually the least number of instructions to generate.
Until it generate satisfied num-instructions  instructions, it will keep generate a set of instructions and keep the ones satisfied. e.g. it already generate 9 satisfied instructions( < 10), it still need generate a set. It generate 2 this time and the 2 are all satisfied. 9+2=11 instructions are kept.

I do not know the exact design, but from the code (the default prompt), I think it's supposed to generate 2. But actually it may generate kinds of number instructions(up to how the llm work based on the prompt).

Thanks - I think we can close this.


Fix to reuse ValueClassUnboxConverter

Initialization performance is improved because the process of getting unbox-impl is cached.
Also, throughput will be improved because the method obtained once will be used instead of acquiring unbox-impl every time serialization has been performed so far.

Comparison between 2.15.2-beta2 and dc51a9ebcc using kogera-benchmark.
This is not a strict comparison as it includes other improvements, but it can be seen that the value class serialization performance has been greatly improved relative to the data class.
This is not a strict comparison as it includes other improvements, but it can be seen that the value class serialization performance has been greatly improved relative to the data class.
before

after

https://github.com/ProjectMapK/kogera-benchmark


Docs.MS Release Updates for azure-communication-common

Update docs metadata and targeting for release of azure-communication-common

Docs Build status updates of commit e484432:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/preview/communication-common-readme.md
:warning:Warning
View (azure-java-preview)
Details

package.json
:white_check_mark:Succeeded

docs-ref-services/preview/communication-common-readme.md

Line 2, Column 1: [Warning-ms-prod-and-service] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 11, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'communication'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 25, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Separate fsrx functionality into a lib

Add default feature to build bin
Update cli to use fsrx_lib
Bump dependencies

What:
Migrated the functionality of FSRX into a library that the CLI app uses to mark-up the text.
Why:
Moving fsrx functionality into a library would allow it to be used as a dependency as well to offer the  flow state reading conversion of any text. I was looking to add fsrx into my own fork of the himalaya command line webmail client and, instead of just piping the output to fsrx, I wanted to implement it as an output mode.
Another application would be to quickly make a wasm based browser extension to manipulate <p> tags on a website

How:
I changed clap and atty to be feature dependent, added the cli feature and made it default.
I then added a lib that provides the FSRXStyler struct that maintains contrast, fixation, saccade mode and regex snippet states.
it provides publicly the style_line function which accepts a &str and returns a FSRX styled String

Checklist:

[x] Allow edits from maintainers option checked
[x] Branch name is prefixed with [your_username]/ (ex. thatvegandev/featureX)
[ ] Documentation added
[ ] Tests added
[x] No failing actions
[x] Merge ready

future plans: Adding a "rich-text" mode to the lib so I can introduce "falloff" in the browser plugin whereby characters get less and less strong providing a less jarring shift from emphasized to normal characters. Having this in a lib allows the cli application to not experience any changes.


Update binding.gyp

This updates the mac condition in binding.gyp as discussed in https://github.com/alexhultman/uWebSockets/commit/d4e56bd1bef6939781d91121832601d5eaba0b24.
This is the list of generated flags:
-O3 -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=c++11 -stdlib=libc++

Thanks I will check this later, seems solved now


glib: don't build docs on darwin

Motivation for this change
Checking if this fixes the darwin build on staging next: https://hydra.nixos.org/build/103356655
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

See https://github.com/NixOS/nixpkgs/pull/71299


Additional G2Command functionality

Pretty print

Colour pretty print

New processResponse() function and associated helper functions

Update docstrings with examples

Copy to file and/or clipboard capabilities

Auto completers

Should be an issue in https://github.com/Senzing/g2command rather than this repository.

Moved to https://github.com/Senzing/g2command/issues/35


Warn on close with unsaved changes

This is discussed a bit more here: https://github.com/google/xi-editor/pull/172#issuecomment-283775673 but regardless of implementation details, this is a glaring hole in the UI at the moment. Related to #173, we could also show save status in the status bar.

@raphlinus played around with this a bit by adding a new command in the backend, but I'm not sure how to determine wether or not the buffer has unsaved changes. I would expect Editor.text_dirty to be what I'm looking for, but afaict it only reflects whether the Rope contains any text. It also doesn't seem to track undo state. Am I missing anything?

Yeah, thinking about this, tracking whether the buffer contains unsaved changes is something the core needs to track. It's actually pretty nontrivial, as edits can come from a variety of sources (including plugins), each of which has potentially different undo state. I think the right way to do this is to have a method in the CRDT engine which tells you whether two revisions are the same (ie the set of deleted characters relative to the union_str are the same). Then that should get reported to the front-end as a boolean "dirty" (maybe I'll just add that to the update method).

my feeling here (as well as with the the word segmentation) is that a quick implementation with a good API is a very acceptable stop gab. I think some heuristic ASCII wordbreak algo is a very reasonable place to start, and then better unicode support can be swapped in further down the list.
I was implementing this as a blocking 'debug_info' edit method, (edit because it's always directed to a given tab, although it does feel like it should maybe be more like 'new_tab') which I imagine could also be used to return things like word/byte/line counts and other metadata. Although I guess then you wouldn't want it blocking. Anyway, my thought was just to throw this call out when you're notified of a user close action, and then act appropriately based on that info.

I am looking into working on this. I am still very new to this codebase so my understanding of how Revisions work may be off. To compare two revisions a and b to determine if they are the same, can I just directly compare their from_union subset? Or do I need to look at all the edits between a and b and see if there is a net gain of zero?

@cbrewster Actually that's an interesting question.
Short answer, I think revision equality based on from_union is useful and would support using it. That said, there are other choices.
To understand the subtle distinctions, consider an initially empty buffer, followed by "A" then backspace. The initial and final revisions have the same from_union subset (indicating that the "A" is deleted).
Most editors that I've tested use a stricter notion of equality, so "A" backspace would not be considered equal to initial. On the other hand, "A" undo would be. In xi, this notion of equality would be represented by comparing the set of undo groups. After "A" backspace, there are two undo groups in a "done" state: the insertion and the deletion.
I personally like the first. I think it usefully indicates whether saving the buffer will have any effect. It's fairly common to accidentally type into a buffer.
In both cases, when the pristine revision drops off the end of the undo queue, then it should be considered impossible to reach it (as a consequence, after an extended sequence of "A"+backspace pairs  it would not be possible to return to a pristine state).
A looser notion of equality is simply the buffer contents, so from an initial value of "A", backspace+"A" would also be considered equal. But I don't know of any editor that does this, and I don't think we should.
Best of luck implementing this and let me know if you have any questions.

How should I go about sending the unsaved/saved state to the frontend? Should it be grouped in with the normal update or should it be separate? If we do group it with the current update, we have to send an update after the save completes to update the frontend that the save was completed.

Should be grouped with the update. There a few things that need to be added there, including line numbers (#184). Sending an update after save completes sounds right to me (it is a change to visible state).

Should the update sent after a save send any lines?

No. But you shouldn't have to generate it manually, it should be enough to let the dirty logic handle it. Today that's going to resend content, but that will be fixed.

A looser notion of equality is simply the buffer contents, so from an initial value of "A", backspace+"A" would also be considered equal. But I don't know of any editor that does this, and I don't think we should.

Atom does this and I really like it. I think we should try to find the best solution for every problem instead of just doing things a certain way just because most editors do it that way and unsaved changes indication based on buffer equality makes a lot more sense to me than anything else.

@cbrewster if you feel like you're ready for client integration I can put together a branch with statusbar support this morning. I have it mostly implemented and I have a good idea of what is left to do; it's a bit particular because we want to support having plugins add & update status bar items. In the meantime I'd implement in core and just log changes in the client.
I agree with @eyelash here as well: I don't think existing editor behaviour is the best rubric, here. The ground truth of "changedness" to a document should be whether or not the bytes in the buffer are the same as the bytes on disk. I think the behaviour of a lot of editors is a product of their implementation details, e.g. they're often using data structures where using the undo stack as a proxy for dirtiness is their best option. It seems to me like this is a place where persistent ropes give us the opportunity to do better?

Efficient equality testing for ropes is a great starter project for someone who wants to dive into the rope code. High level overview, if lengths mismatch or there's pointer equality, you're done. Otherwise, recurse and iterate through both sets of children, maintaining an offset. Compare the shorter child (the one ending first) with the corresponding substring of the other. If you're at leaves, compare bytes. It's not trivial; among other things, the trees may be different height.
For added fun, make an equality trait for generic ropes, not just strings. I think this would need a fun "compare with slice" trait to avoid doing allocations for the subsequence operation.
I'm also happy to improve on existing editor behavior; I just want to understand it first (Chesterton's fence).

this is closed by #203


'Show Answer' leads to error

Describe the bug
When I press 'Show Answer' on an imported or extracted card, Anki shows an error and no scheduling choices are displayed.
To Reproduce
Steps to reproduce the behavior:

Import a webpage using alt+3
Go into review mode on my Imports Deck
Optionally make highlights, extractions etc. This seems to succeed.
Click on 'Show Answer' - the card now says "When do you want to see this card again?", but the 'Show Error' dialogue is not replaced with interval buttons, and Anki displays a pop up stating that an error occurred (debug info pasted below).

The same behavior occurs when reviewing a card that I extracted from the original import.
Expected behavior
I expect the 'Show Answer' button to be replaced with other buttons with options for when I will see the card again.
Screenshots

Specs (please complete the following information):

OS: Mac 10.15.7
Anki Version 2.1.46 (94913ec2)
Incremental Reading Version 4.10.3

Debug info printed by Anki error pop-up
Debug info:
Anki 2.1.46 (94913ec2) Python 3.8.6 Qt 5.14.2 PyQt 5.14.2
Platform: Mac 10.15.7
Flags: frz=True ao=True sv=2
Add-ons, last update check: 2021-08-11 20:30:31
Caught exception:
Traceback (most recent call last):
File "aqt/webview.py", line 538, in handler
File "aqt/reviewer.py", line 705, in _onTypedAnswer
File "aqt/reviewer.py", line 386, in _showAnswer
File "aqt/reviewer.py", line 760, in _showEaseButtons
File "aqt/reviewer.py", line 847, in _answerButtons
File "aqt/reviewer.py", line 833, in but
File "decorator.py", line 232, in fun
File "anki/hooks.py", line 89, in decorator_wrapper
File "anki/hooks.py", line 86, in repl
TypeError: buttonTime() got multiple values for argument '_old'
Additional Context
I have other add-ons installed:
Auto Ease Factor
Reset Ease Automatically
Image Occlusion Enhanced for Anki 21 alpha
I suspected that interference from one of these add-ons could be contributing to the error. However, disabling these add-ons does not change the unexpected behavior.

Update
I ascertained that this behavior occurs in all cards and decks, including ones I created before installing IR.

I have the same behavior. I have tried on a complete new profile, on which I have never used the add-on (besides installing it), and it still breaks.

I have had the same problem.   The description provided by lukenormile accurately describes what's happening on my machine. I have only one other add-on installed.
Here's the error message I received:
Debug info:
Anki 2.1.46 (94913ec2) Python 3.8.6 Qt 5.14.2 PyQt 5.14.2
Platform: Windows 10
Flags: frz=True ao=True sv=2
Add-ons, last update check: 2021-08-22 09:02:16
Caught exception:
Traceback (most recent call last):
File "aqt\webview.py", line 538, in handler
File "aqt\reviewer.py", line 705, in _onTypedAnswer
File "decorator.py", line 232, in fun
File "anki\hooks.py", line 89, in decorator_wrapper
File "anki\hooks.py", line 86, in repl
File "C:\Users\Bob\AppData\Roaming\Anki2\addons21\1374772155\main.py", line 233, in onShowAnswer
return _old(self)
File "aqt\reviewer.py", line 386, in _showAnswer
File "aqt\reviewer.py", line 760, in _showEaseButtons
File "aqt\reviewer.py", line 847, in _answerButtons
File "aqt\reviewer.py", line 833, in but
File "decorator.py", line 232, in fun
File "anki\hooks.py", line 89, in decorator_wrapper
File "anki\hooks.py", line 86, in repl
TypeError: buttonTime() got multiple values for argument '_old'

this error is still present in version 2.1.49
Error
An error occurred. Please start Anki while holding down the shift key, which will temporarily disable the add-ons you have installed.
If the issue only occurs when add-ons are enabled, please use the Tools > Add-ons menu item to disable some add-ons and restart Anki, repeating until you discover the add-on that is causing the problem.
When you've discovered the add-on that is causing the problem, please report the issue on the add-on support site.
Debug info:
Anki 2.1.49 (dc80804a) Python 3.8.6 Qt 5.14.2 PyQt 5.14.2
Platform: Windows 10
Flags: frz=True ao=True sv=2
Add-ons, last update check: 2022-08-11 10:34:07
Caught exception:
Traceback (most recent call last):
File "aqt\webview.py", line 541, in handler
File "aqt\reviewer.py", line 704, in _onTypedAnswer
File "aqt\reviewer.py", line 383, in _showAnswer
File "aqt\reviewer.py", line 759, in _showEaseButtons
File "aqt\reviewer.py", line 846, in _answerButtons
File "aqt\reviewer.py", line 832, in but
File "decorator.py", line 232, in fun
File "anki\hooks.py", line 89, in decorator_wrapper
File "anki\hooks.py", line 86, in repl
TypeError: buttonTime() got multiple values for argument '_old'

Hi,
This error should be fixed in https://github.com/luoliyan/incremental-reading/commit/4be88a5ad116ca9ce412f7989013167f7448db6c .
A new release of the IR add-on will address this issue.


using nccl ops from TRT-LLM namespace

This PR illustrates the use of nccl ops from TRT-LLM for the example examples/distributed_inference/tensor_parallel_simple_example.py

Yes @narendasan , the numerical results come out to be correct for this example and the llama3 within 0.01 error threshold

Overall I think this is close to be ready to be merged. The next step after merge is to move the converters into the converter registry and conditionally enable them similar to how we do model opt. There we need to start thinking about the install workflow since I think TRT-LLM only supports 3.10.

Ok @narendasan , I will add the error check. Currently in the Llama3 example, in the apply_rotary_emb the complex tensors are distributed and is an input to the torchTRT backend. Wrapping it in aot_autograd gets over the trace input error, but TorchTRT does not currently support torch.complex input tensors. I am working on filtering out the above.
Since this PR shows the use of simple example (which is working) and LLama3, I will push in the above change. Also need to try with strict=False
ep = torch.export._trace._export(
                model,
                (inputs,),
                dynamic_shapes=({1: seq_len},),
                strict=False,
                allow_complex_guards_as_runtime_asserts=True,
            )

@apbose run the linter


Asterisks in Remarks section cause unintentional emphasis.

There are a few instances where there are double-asterisks in the Remarks paragraph.  Two of them seem like typos, as they are invalid as SQL code, and unhelpful as markup for bold-text.
On a separate note, it might be helpful to indicate that this is an output formatting feature:
"Returns (right-justified | decimal-aligned) character data converted from numeric data."
or
"Renders a numeric value into a right-justified string of a specified length and decimal precision.  Useful for aligning numeric values across multiple rows."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 247290ac-9dcd-4647-05f0-d35d93aa1d21
Version Independent ID: dc6acad9-85a3-366d-6f58-f432a5ca2376
Content: STR (Transact-SQL) - SQL Server
Content Source: docs/t-sql/functions/str-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@marked23 -- thank you for your feedback.  I am looking into this document.

@MikeRayMSFT -- please review the above-mentioned PR 14092.


New Direct links from vimeo is not working

Vimeo changed the direct links from the api now returns like it
https://player.vimeo.com/progressive_redirect/playback/675622290/rendition/360p?loc=external&oauth2_token_id=1406393538&signature=1545279f8150f119095ae76eb3326158500e1a9f3b2df1ed271917f4e3d0af2d
this links works fine in a  tag html, but not works in this library..

I'm seeing the same issue. React player is using the Vimeo API to fetch the video; it is returning a 404 with the new format.  This could be an issue on Vimeo's API side...

Same issue here!

Yes, me too, I am using the embed link, but is not the solution for me, maybe we need use other lib.

Let me know if you find one

This is only broken because Vimeo have decided not to include .mp4 or some other sensible extension in their links to external video files. Very annoying. Publishing a fix shortly.

Any updates on this?

I’m publishing a new version soon that includes a fix for this (plus loads of other recent fixes).

@cookpete Do you have an estimate as to the release to the master branch?

I already removed this component as I cannot afford for this to happen again.

Same issue, waiting for update...

I receive following error on Vimeo videos, is that related? Vimeo videos are not loading at all while Youtube works.
next-dev.js?3515:32 TypeError: t.replace is not a function
    at u (player.js:2:1049)
    at player.js:2:10858
    at new Promise (<anonymous>)
    at new Player (player.js:2:10370)

I receive following error on Vimeo videos, is that related? Vimeo videos are not loading at all while Youtube works.
next-dev.js?3515:32 TypeError: t.replace is not a function
    at u (player.js:2:1049)
    at player.js:2:10858
    at new Promise (<anonymous>)
    at new Player (player.js:2:10370)

Yes

@cookpete Any chance to solve this issue ?

is there a workaround at the moment?

Workaround is to manually add video like so
<video
     width="100%" height="100%"
     controls={true}
     autoPlay
     src={videoUrl} />

@dohomi I posted one above

is it url right @Fyb3roptik  ?

Fixed in 2.10.0. Sorry for the delay all.

thank you for your hard work @cookpete !

Facing this issue again. However vimeo videos work locally but not in any environments. Any suggestions?


创建首页V2 代码脚手架

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

请 @rovinglight  审核。任务背景：https://github.com/zingzeu/yngdieng/issues/1520

Thanks，其他部分看起来没问题。抱歉 review 拖得有点久~


Question on performance gap

Hi, Thank you for your code and paper. I've already tried your code, but I cannot achieve the same performance as the paper. Would you please help me figure out where the problem is?
I retrained DeepLabV2 with your shared refined pseudo segmentation labels. But the performance on val only achieves 64.8 and 65.7(after crf). All hyper-parameters follow your provided code. Could you please point out the possible mistake?
Thank you!

Before we uploaded the code, we already reproduced the performance.
We recommend checking the DeepLab-V2 init weight check it here
If you have the same issue after try that, we will reproduce our code again.
Also, for the training recipe of DeepLabV2, we strictly followed the DeepLab-V2-pytorch code.
Please check the environmental settings in README.

@qjadud1994 Thanks for your reply! I have trained the DeepLabV2 with the provided pseudo labels again following the provided script. The performance on val set is 66.5(67.6 after crf) and 67.0(68.2 after crf) with 2 gpu setting and 4 gpu setting, respectively.  The script is as follows:
DATASET:
NAME: vocaug
ROOT: ../PascalVOC2012/VOCdevkit
LABELS: ./data/datasets/voc12/labels.txt
N_CLASSES: 21
IGNORE_LABEL: 255
SCALES: [0.5, 0.75, 1.0, 1.25, 1.5]
SPLIT:
TRAIN: train_cls
VAL: val_cls
TEST: test
IMAGE:
MEAN:
R: 122.675
G: 116.669
B: 104.008
SIZE:
BASE: # None
TRAIN: 321
TEST: 513
SOLVER:
BATCH_SIZE:
TRAIN: 10(20 for 4 gpu setting)
TEST: 1
ITER_MAX: 10000
ITER_SIZE: 2
ITER_SAVE: 2000
ITER_TB: 50
LR_DECAY: 10
LR: 2.5e-4
MOMENTUM: 0.9
OPTIMIZER: sgd
POLY_POWER: 0.9
WEIGHT_DECAY: 5.0e-4
AVERAGE_LOSS: 20
CRF:
ITER_MAX: 10
POS_W: 3
POS_XY_STD: 1
BI_W: 4
BI_XY_STD: 67
BI_RGB_STD: 3
could you please point out the mistake of the script? Thanks a lot!

We guess the initial (COCO pretrained) weight is the matter.
When we reproduce our implementation, we got 70.1% mIoU with CRF.
However, DeepLab-V2 without COCO-pretrained weight cannot reproduce their official performance even in the fully supervised setting because of the small batch size issue.
Currently, we newly upload the DeepLab-V3 network which does not require COCO-pretrained weight. please check the details in here


Update Redux DevTools integration

Issue Summary
The Redux DevTools are logging a deprecation warning in the browser console on Wagtail’s admin:
VM23:1 `window.devToolsExtension` is deprecated in favor of `window.__REDUX_DEVTOOLS_EXTENSION__`, and will be removed in next version of Redux DevTools: https://git.io/fpEJZ

Steps to Reproduce

Install the Redux DevTools Chrome extension
Open the browser console on the admin of any Wagtail site

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Fixing this should just be a matter of replacing the existing function call with the new one. Here is the relevant code:
https://github.com/wagtail/wagtail/blob/d8b2d087ca12840013e72d1ab1e8edc62518b5c2/client/src/components/Explorer/index.js#L31-L35

I was just about to open this 😂

@jjanssen I saw it on @BertrandBordage's screen sharing and couldn't resist any longer!


Do you have a verison for serial connection

lis connect to instrument with serial connection .

Suddenly, no. We abandon serial connection in favor of tcp one - it was much more easy  to implement. If you'd like contribute such, feel free to open PR (:


Tokens tab looks gray and blank if user has no tokens

Might be a good place to integrate into the Add Graphics epic (#17152) @alexpaxton

dupe of https://github.com/influxdata/influxdb/issues/17635


mosh: remove boost dependency

Motivation for this change
boost was removed from the mosh dependency requirements in 2012.
(It was only used from February and April 2012.)
Things done

[ ] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

LGTM


Fix CI failure due to conflicting merges

There were two pending PRs with package level
changes but no source level conflicts. This got
merged because git cannot detect this.
Signed-off-by: Jana Radhakrishnan<EMAIL_ADDRESS>

Thanks @mrjana LGTM


Make it Global

The project will run fine for local directories, but need to make it global so that anyone can use this.

For that,  need to change the if else statement(Where you checked for directory exist or not) and add some more functionalities.

i think this project is currently inactive

@N-Saipraveen
have you run it locally?, If yes, make sure your pc has nodejs.

Yes, ofcourse


[STORM-3526]: Always override Login Config from System Property

Pacemaker calls ConfigUtils.overrideLoginConfigWithSystemProperty(ConfigUtils.readStormConfig()), basically duplicating the code.  Can you fix this?

Worker calls ConfigUtils.overrideLoginConfigWithSystemProperty(ConfigUtils.readSupervisorStormConf(conf, topologyId)).  Seems like we should add this to readSupervisorStormConf() as well?

I understand the general idea of it. But curious what are we trying to fix here?  Also there is a similar function https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/utils/Utils.java#L299 . It can be confusing if Utils.readStormConfig and  ConfigUitls. readStormConfig return different values

@Ethanlm , The Utils.readStormConfig is used by ConfigUtils.readStormConfig in variably. The Utils.readStormConfig is used at many other places, while ConfigUtils.readStormConfig  is used by daemons. Many a times, daemons should be able to read system property passed as argument to JVM  to override default config file setting for login config. The daemons need to stick to single configuration defined in the yaml file. You may have more than one daemon running using their individual jvm arguments ( system. properties)  to customize login config.
Without this change, we can not override the login config using jvm argument.

The one in Worker.java mentioned by @agresch  should be fixed too


url must be in quotes

in order to work

The most recent update eliminated the need to enclose the argument URL in quotations.


PROGRAMMES-6507 Adding Gallery Content Block

https://jira.dev.bbc.co.uk/browse/PROGRAMMES-6507

Code looks okay but not tested it


Drop Python 2.x support

Just floating this idea. It seems most users will run this through a containerized environment anyways, so it should be a big deal to drop Python 2.x support.

Fine with me. I didn't even realize we were supporting 2. :)

Me neither until I saw import six


How can I filter on a field in a one-to-one relationship?

I want to filter on Tag.owner, but I get the following exception:
 Exception: Invalid field Tag.owner: does not contains any columns.

How can I filter on a field of a one-to-one relationship?
View:
class SubsetModelView(PhraseSearchModelView):
column_filters = ('book', 'abbr', 'kind', 'corpus', 'text', 'notes', 'tags', Tag.owner)
column_searchable_list = ('abbr', 'text',)
column_list = ('book', 'kind', 'text', 'tags', 'notes')

Models: (indenting got messed up)
class Tag(db.Model):
__tablename__ = 'tags'
__table_args__ = {'extend_existing': True}

id = db.Column(db.Integer, primary_key=True)
name = db.Column(db.String(80), nullable=False)

subset = db.relationship('Subset', secondary=subset_tags, backref=db.backref('tags'))
# one to one relationship:
owner_id = db.Column(db.Integer, db.ForeignKey('user.id'))
owner = db.relationship("User", backref=db.backref("tags", uselist=False))

def __init__(self, name='', owner=None):
    self.name = name
    self.owner = owner

def __repr__(self):
    # return 'Tag: ' + str(self.name) + '>'
    if self.owner:
        output = str(self.owner.name) + '-' + self.name
        return output
    return self.name

class User(db.Model, UserMixin):
__table_args__ = {'extend_existing': True}

id = db.Column(db.Integer, primary_key=True)
name = db.Column(db.String(35), unique=True)
email = db.Column(db.String(255), unique=True)
password = db.Column(db.String(255))
active = db.Column(db.Boolean())
confirmed_at = db.Column(db.DateTime())

You can't filter on a relationship, but you can filter on related model column.
Try filtering on tags.name. It should detect that tags is a relationship and will create inner join between models, etc.

I can't believe I did not spot that. So for others like me: you can use 'tags.owner.name', in my example, to add a filter on a related model column. I tried that but I did not spot I needed the quotation marks.
Thanks Serge!


[BUG] Newly loaded cog commands are not appearing in discord, despite cog showing being loaded

After successfully loading a cog, and showing that it is loaded. The commands are not present in discord, despite also triggering a sync command.

2024-11-12 18:31:17,459:INFO:quantumly_confused_bot_log: Command sync initiated by .slurmsmackenzie...
2024-11-12 18:31:17,893:INFO:quantumly_confused_bot_log: Synced 5 commands.
2024-11-12 18:32:03,273:INFO:quantumly_confused_bot_log: Command sync initiated by padraignix...
2024-11-12 18:32:03,847:INFO:quantumly_confused_bot_log: Synced 5 commands.

The cog is actually doing too much syncing, which could be cause for rate limiting and then nothing gets synced at all, but I dont think that is the issue. I spotted some inconsistency in my Interactions object creation by using lowercase i in Interaction: discord Interaction. This would be an interaction object in interactions.py NOT discord.py/interactions.
Fix: make sure all command parameters expect 'Interaction: discord.Interaction' and when the interaction is called, await Interaction.response etc.
Syncing: The bot sync is triggering in the event listener on_ready() and theres potential that if the bot has to reconnect to the discord api several times it will be resyncing and we are becoming rate limited.
Fix: Move the await bot.tree.sync() to the main() function so it only syncs once when the bot starts.

New class method for QCAdmin to take care of the class instance calls to bot.tree.sync:
QCAdmin.sync_commands()
async def sync_commands(self):
"""Syncs the bot's commands with Discord on startup."""
print("Bot Startup Command Sync initiated...")
self.logger.info("Bot Startup Command Sync initiated...")
try:
synced = await self.bot.tree.sync()
print(f"Command Sync Completed: Synced {len(synced)} commands.")
self.logger.info(f"Command Sync Completed: Synced {len(synced)} commands.")
except Exception as e:
print(e)
self.logger.error(f"Error syncing commands: {e}")

PR Submitted to address issues

Issue was resolved by kicking the bot and rejoining, clearing the registered app commands for the bot


FIx the conflict on p->rxmsg.

Tested on alvin/nng-mqtt mqtt_async client, the thread sanitizer does not complain anymore.


BUG: console log errors on every keystroke: Uncaught Error: Unexpected usage... at EditorSimpleWorker.loadForeignModule

Every keystroke causes these console log errors. They continue to flood the console logs every time I type a character in any file opened in the vscode editor from this plugin.

Any update on this or questions?

Anyone know if this plugin is still under active development? thanks


add zulip metrics

we should be able to get # of users and store it over time to track growth: https://zulip.com/api/get-users

closed in #40


Do you have the timeline widgets available in the 1.0.04 version ?

Do you have the timeline widgets available in the <IP_ADDRESS> version ?

No. Its not written yet.
On Thursday, April 21, 2016, sempervivo<EMAIL_ADDRESS>wrote:

Do you have the timeline widgets available in the 1.0.04 version ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/sameeraroshan/visjs/issues/20


Basic usage questions

How do I remove the virtualenv? I ended up doing it manually.
How do I change the python version if I want to upgrade that? I tried editing pyproject.toml to python = "3.7" (from 3.6) and running poetry install but it didn't do the upgrade.
Is there a way to get the path of the virtualenv in one command?
What is the cache?

please read the doc et issues. almost everything is there.
I can also find help in the discuss group

Is there a way to get the path of the virtualenv in one command?

Has an open issue here. https://github.com/sdispater/poetry/issues/401 Sorry I didn't look there before asking.
The other ones I was not able to figure out. What's the discuss group?

* How do I remove the virtualenv? I ended up doing it manually.

Yes for now you have to. You can create .venv dir in your folder if you want : https://poetry.eustace.io/docs/configuration/

* How do I change the python version if I want to upgrade that? I tried editing pyproject.toml to `python = "3.7"` (from 3.6) and running `poetry install` but it didn't do the upgrade.

https://poetry.eustace.io/docs/basic-usage/#poetry-and-virtualenvs  and #82

* Is there a way to get the path of the virtualenv in one command?

#401

* What is the cache?

I'm not sure. I would the the already downloaded packages

@jgirardet Terrific, thank you for all the references! All extremely helpful.


Tests should use chrome headless instead of phantomjs

See https://chromium.googlesource.com/chromium/src/+/master/headless/README.md

Also firefox headless would be good to include
https://developer.mozilla.org/en-US/Firefox/Headless_mode

See https://github.com/iancoleman/bip39/commit/0460b53f3aff1745fd2727c094d12f90cfbe1d10


Two challenges about Objects missing content

Describe your problem and how to reproduce it:
Iterate with for in and Generate Array with Object.keys() lessons not maintaining state; generating 404 on my profile. See https://github.com/freeCodeCamp/freeCodeCamp/issues/36096#issue-446200317
Add a Link to the page with the problem:
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-data-structures/generate-an-array-of-all-object-keys-with-object.keys
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-data-structures/-iterate-through-the-keys-of-an-object-with-a-for...in-statement
Tell us about your browser and operating system:

Browser Name: Chrome
Browser Version: 74.0.3729.157 (64-bit)
Operating System: macOS 10.14.5

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):

@twhite96 Could you please advise what browse did you us to open these resources?
I have tried to get access to these pages and found them working, but with a difference in the URI.
Here is the working one which I could open from Chrome
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-data-structures/generate-an-array-of-all-object-keys-with-object-keys/
and I can see -keys/ instead of .keys
Same for the second resource
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-data-structures/-iterate-through-the-keys-of-an-object-with-a-for---in-statement/
The difference is seen is ... instead of ---

Updated browser to 74.0.3729.169 (Official Build) (64-bit) and results hasn't changed.

@sergeyradov Thank you for reporting this issue, but it has been fixed on our master branch.  The reason you do not see it fixed is because the master branch has not been deployed since October 2108 after a major repo restructuring.  When it is deployed, the issue will no longer be present in production.

@RandellDawson actually it works fine in Production
https://learn.freecodecamp.org/
thank you for update.


feature: explore approaches for wildcard DNS

Feature Description
Currently we support mainly two scenarios.

Dev scenario - one kind cluster running KubeFlex/KubeStellar core and one or more kind clusters as WECs, all in the same docker network.

"Production" scenario - one OpenShift cluster in a cloud (e.g. IBM Cloud, AWS) running KubeFlex/KubeStellar and multiple WECs clusters. The latter can be different distributions of Kubernetes, OpenShift or microShift.

There are few more scenarios of interest between 1 and 2, for example a developer running on environments with limited resources such as a rPI may not be able to run more then one kind cluster (or microShift) on his/her environment, and therefore would need to run a variation of scenario 1 where one rPI runs KubeFlex/KubeStellar core and one other rPI runs a kind or microShift cluster as a WEC.
Yet another scenario is where a user wants to run a Kubernetes cluster created with kubeadm or other installers on a VM or a set of VMs for KubeFlex/KubeStellar and runs the WECs on other VMs.
What the latter two scenarios have in common is the requirement for a wildcard DNS that resolves to the IP of the VM where the ingress is running. KubeFlex uses nginx ingress with hostname-based routing, therefore routing a request for a specific control plane with name "foo" requires a wildcard DNS that resolves foo. to the IP of the machine running the NGINX ingress. A wildcard dns is required because any control plane with name  with an address .  needs to be resolved to the same IP of the ingress.
Proposed Solution
KubeFlex as an option to set the DNS domain to use at install time. At this time we use the as default public wildcard DNS service for developers localtest.me that always resolves <IP_ADDRESS> . We should investigate what is the simplest approach to set up other wildcard DNSs that can resolve to an actual IP of a machine that other machines can use to communicate to. For example, if the Ip of the host running KubeFlex and the ingress is <IP_ADDRESS>, we need to have a wildcard DNS that can be used by all machines that are part of the Multi-Cluster ensemble and that resolves to <IP_ADDRESS>.
Possible solution to explore:

Simplest solution: edit /etc/hosts and add the entries for wds1 and imbs1 on the WECs. Verify that address resolution works for containers running in Kube clusters in the WECs so that it is possible to register those clusters with OCM hub running in imbs1 control plane. Note that this approach is quite inflexible and only works for pre-defined control plane names that need to be updated in all WEC clusters.
Explore using dnsmasq for wildcard DNS. How this could be used on a subset of VMs or rPIs to resolve the IP of the core machine.
Explore the use of microShift and its route. In a regular OpenShift in a Cloud, Routes provide a simple approach for wildcard DNS, as multiple hostnames using the route domain all resolve to the same OpenShift endpoint and can be routed to different OpenShift applications on the same cluster. It is not clear how this would work for a microShift cluster and if there is some out-of-the-box integration with a wildcard DNS service.

Want to contribute?

[ ] I would like to work on this issue.

Additional Context
No response

@KPRoche this is relevant for your use case.

@pdettori I think it is critical to making kubestellar a really functional solution for distributed workloads, and I think that in the inventory management component there should be a reliable way to specify the hostname/ip address  of each WEC, for cases where it is localhost and for those where it is not, but well defined as far as the external hosting network is concerned.


Look at volumeattachment resource to determine pvc in-use

previously looked at pod mounts - updated code  no longer need
to query pods
rbac updated to remove access to pods and add for
volumeattachments
index still used on volumeattachment as it is a cluster scoped
resource and we would need to iterate through them all to find
a match where the spec had the PV in question referenced. This
way provides a very simple lookup by pvname

Signed-off-by: Tesshu Flower<EMAIL_ADDRESS>

volumeattachment objects are not always created of all the PVC. it's based on the csidriver.spec.attachRequired field in csidriver object. if this field is set to false no VA will be created.

volumeattachment objects are not always created of all the PVC. it's based on the csidriver.spec.attachRequired field in csidriver object. if this field is set to false no VA will be created.

Thanks @Madhu-1 this is great information.  Based on this, I'm not sure we should go with this PR at all, and rather keep the current method of looking at pods.  @ShyamsundarR and @BenamarMk what do you think?

/hold

volumeattachment objects are not always created of all the PVC. it's based on the csidriver.spec.attachRequired field in csidriver object. if this field is set to false no VA will be created.

Thanks @Madhu-1 this is great information. Based on this, I'm not sure we should go with this PR at all, and rather keep the current method of looking at pods. @ShyamsundarR and @BenamarMk what do you think?

@tesshuflower, if VolumeAttachement is not always there, then we shouldn't depend on it and we should go back to our old solution.

VolumeAttachement objects afict are created by default. These are then picked up by the external attacher side car to decide if the CSI driver supports additional Controller{Publish|Unpublish}Volume calls, and calls into the same before proceeding with updating the attachment resource.
@Madhu-1 is there a reference where VolumeAttachement is not created?

@ShyamsundarR here it is
when ATTACHREQUIRED is true
kuberc get csidrivers
NAME                            ATTACHREQUIRED   PODINFOONMOUNT   STORAGECAPACITY   TOKENREQUESTS   REQUIRESREPUBLISH   MODES        AGE
rook-ceph.cephfs.csi.ceph.com   true             false            false             <unset>         false               Persistent   7m44s
[🎩]mrajanna@fedora rook $]cd deploy/examples/csi/cephfs/
[🎩]mrajanna@fedora cephfs $]kubectl create -f storageclass.yaml
storageclass.storage.k8s.io/rook-cephfs created
[🎩]mrajanna@fedora cephfs $]kubectl create -f pvc.yaml
persistentvolumeclaim/cephfs-pvc created
[🎩]mrajanna@fedora cephfs $]kubectl get pvc
NAME         STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
cephfs-pvc   Bound    pvc-cf8d1fca-de86-48be-93d0-1847c4064be9   1Gi        RWO            rook-cephfs    3s
[🎩]mrajanna@fedora cephfs $]kubectl create -f pod.yaml
pod/csicephfs-demo-pod created
[🎩]mrajanna@fedora cephfs $]kubectl get volumeattachment
NAME                                                                   ATTACHER                        PV                                         NODE       ATTACHED   AGE
csi-9159645e074ed10b81be3b598d4a191abcce9fb45b5e21e29093120b5adcb491   rook-ceph.cephfs.csi.ceph.com   pvc-cf8d1fca-de86-48be-93d0-1847c4064be9   minikube   true       8s
[🎩]mrajanna@fedora cephfs $]kubectl get po
NAME                 READY   STATUS              RESTARTS   AGE
csicephfs-demo-pod   0/1     ContainerCreating   0          13s

when ATTACHREQUIRED is false
[🎩]mrajanna@fedora cephfs $]kubectl get csidrivers
NAME                            ATTACHREQUIRED   PODINFOONMOUNT   STORAGECAPACITY   TOKENREQUESTS   REQUIRESREPUBLISH   MODES        AGE
rook-ceph.cephfs.csi.ceph.com   false            false            false             <unset>         false               Persistent   19s
[🎩]mrajanna@fedora cephfs $]kubectl create -f pvc.yaml
persistentvolumeclaim/cephfs-pvc created
[🎩]mrajanna@fedora cephfs $]kubectl get pvc
NAME         STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
cephfs-pvc   Bound    pvc-d4a9ec84-6372-476a-851b-99395d18aac6   1Gi        RWO            rook-cephfs    3s
[🎩]mrajanna@fedora cephfs $]kubectl create -f pod.yaml
pod/csicephfs-demo-pod created
[🎩]mrajanna@fedora cephfs $]kubectl get volumeattachment
No resources found
[🎩]mrajanna@fedora cephfs $]kubectl get po
NAME                 READY   STATUS    RESTARTS   AGE
csicephfs-demo-pod   1/1     Running   0          20s

@ShyamsundarR here it is

Do you have a code reference for when this is created, as the docs are unclear (I did look at the code a bit before posting, but want to understand this for sure).
Also, as ceph-csi does not support ControllerPublishVolume why is it declaring attachRequired as true by default?

@ShyamsundarR here it is

Do you have a code reference for when this is created, as the docs are unclear (I did look at the code a bit before posting, but want to understand this for sure).
Also, as ceph-csi does not support ControllerPublishVolume why is it declaring attachRequired as true by default?

We did this to fix RWO problem (i remember you reverted the Rook PR where we removed attached and set attachRequired to false.

Current discussion update:

Check to see if we can use volumeAttachement for CSI drivers that do support the same, else fall back to pod listing
If the code gets too messy with a fall back option, regroup and check what can be done

Replaced by #474


Improve compatible with PHP7 Errors

expressive itself was fixed #295 in 1.0, but until whoops 2 whoops couldn't handle it either.

There's a bit of a problem with just blindly upgrading to whoops 2.0: there are some incompatibilities in the new version with the API we were exercising in Expressive; if you look at the build details, you'll see the errors.
I'll see if I can use this as a starting point, however; thanks, @basz.

#384 accomplishes this comprehensively; closing this in favor of that patch.


Make lxc version --verbose expose build timestamp/hash

It is useful for testing if lxc --version exposed build timestamp and hash. Maybe with --verbose.
>lxc --version
2.12

>lxc --version --verbose
2.12 699f8fc 2017-03-23T20:18:06Z

We can't include the git commit because our builds are made from the release tarball which doesn't include any git information (on purpose). The build time should be possible but I really fail to see the point.

The point is 1. automated testing, 2. manual debug runs.

Closing this issue. As mentioned, the Go build system doesn't let us include the result of arbitrary commands, so we can't include the git commit. The build timestamp may be extractable (though I don't know how) but wouldn't be very useful without the git commit information.
The other problem with this whole thing is that it'd by definition make the build non-reproducible since every build even of the exact same thing would contain a different string built into the code. This would cause problems for distributions which use reproducible builds mechanisms.

This would cause problems for distributions which use reproducible builds mechanisms.

Which distributions exactly? Hash builds are reproducible.

Debian has been doing reproducible builds, Ubuntu has been looking at following suit. I don't know for the RPM based distros. If there was an easy way to include the git hash, I wouldn't be opposed to doing that, but there isn't. Go doesn't use autotools or a similar build system which allows to expose such things easily. Not that the hash would be particularly useful either as it wouldn't tell you anything about all the imported code that's more often than not, the cause of the actual problems.


ft--Hero background image aligned

This PR fixes this
Reference:
Before

After

@BatoolMM, kindly review this PR, would love your feedback on this. This website can be improved further, by making the social links in the footer section point to the right social handles, I can also work on the website accessibility to meet WCAG standards

@BatoolMM  this PR fixes responsiveness for Ipad screens
Reference
Before :

After :

@BatoolMM, kindly review, anticipate your feedback

This is wonderful, can you reflect the same change in the Arabic CSS, please?


Merge upstream improvements into fork

this fork will be going away since upstream merged the bug fixes / features


Undermanned project

At this writing there are 350 issues open, a clear indicator that this project need more pull requests from more people to keep the project stable.

[mylabel:help wanted](https://github.com/search?utf8=✓&q=commenter%3Adavidhedlund+"mylabel%3Ahelp wanted%22+in%3Acomments&type=Issues&ref=searchresults)

Welcome to the world of open source.

@cketti mylabel:open

Spamming the issue tracker is not helping. If you wish to contribute please do so by sending pull requests.

@cketti Ok.


Delete image request

Hi currently using your app it good, but i need so somehow secure it and have some problem with delete button.
I use upgraded lib nginx_okta_proxy written on ruby ( saml auth ) and all work fine until i try delete image.
When push delete button it sends POST request with url like
/registries/docker-registry443/repositories/main/tags/latest/delete and proxy try redirect to this url and i get error 404, ( but only via this simple proxy )  but as i see request path should be
registries/docker-registry:443/repositories/main/tags ( as i understand ) and it would be cool fi you can help me resolve this problem, or maybe navigate me where i can find solution.
Best regards
Anton

Hi ruanton29,
I have a few questions to help me debug:

Are you on the latest version of the app?
Are you adding the registry via the interface or registries.yml?
Could you provide me with your configuration (removing identifying information)?
Are you receiving the 404 from the proxy itself, or from the docker-registry-manager app?
Could you provide the relevant nginx log lines in addition to the registry logs (run with debug)?

I've not been able to recreate the missing colon in the delete request in my dev environment. You can try and inspect the href in the browser on the tag name and verify that the registry name is correct there (I would expect it to be for the rest of the app to work).
I've pasted the below snippet of how the delete URL is formed (the :registryName portion is the same through that view, so it should reflect the rest of the page:
      // Handle form submission event
      $('#delete-tags').on('submit', function (e) {
        var form = this;

        var x = document.getElementsByClassName("selected");
        $(x).each(function (index) {
          var tagName = $(this).data("tag-name");
          $.ajax({
            type: "POST",
            url: "/registries/{{.registryName}}/repositories/{{.repositoryNameEncode}}/tags/" + tagName + "/delete",
            statusCode: {
            ...

Hi
I hope you don't think that something not working, all working fine =). So before answer all question i just give more info about setup. Currently i need add some auth for docker-ui so scheme look like,
nginx -> okta_proxy ( https://github.com/dalehamel/okta-auth-proxy i can't find better alternative ) -> docker-registry-manager. If check deeply it's look like this :

Request go through nginx, nginx by default redirect it to  okta_proxy.
Okta proxy authenticate me and add header

          headers "X-Reproxy-URL" => File.join(url, request.path)
          headers "X-Accel-Redirect" => "/reproxy"
          redirect to('http://localhost')

and made redirect to localhost ( aka nginx ) with url (request.path) /registries/dockerregistry/repositories/main/somethin/tags. It's ok work fine.
3. When in ui i go to delete image i get at page 404 ( but image deleted if i refresh page a few moment later)  with message Failure! We were unable to delete latest from the registry. For more details view the
So i don't blame anyone just try to understand if i can somehow make it more workable =(
And about your question

Latest
Registry.yml
https://github.com/dalehamel/okta-auth-proxy ( nginx and okta proxy)

registries:
  myegistry:
    url: https://docker-registry.example.com
    username: user
    password: pass
    port: 443
    refresh-rate: "5m"
    skip-tls-validation: true

Looks like proxy

2018/02/12 09:13:59 [debug] 10#10: *101 http request line: "POST /registries/doc
ker-registry.example.com:443/repositories/main/something/tags/l
atest/delete HTTP/1.1"
POST /registries/docker-registry.example.com:443/repositories/main/something/tags/latest/delete HTTP/1.1" 404 905 "https://docker-ui.vidible.aolcloud.net/registries/docker-registry.example.com:443/repositories/main/something/tags

And chrome debug show me
Request URL:https://docker-ui.example.com/registries/docker-registry.example.com:443/repositories/main/something/tags/latest/delete
404
Content-Length:0

And docker-manager show only in log info about Failed to retrieve an updated list of tags for
I don't like saml2 but somehow i need to put it before service =(
Best regards
Anton


Update PPB

Update PPB to 0.10
Scheduled for September 22
cc @pathunstrom

FWIW: The test failure doesn't appear to be your fault - it looks like Github may have deprecated their Py3.5 environment...

This should be ready to be merged.


Added Google Clone

🛠 Fixes Issue (Number)
#522
👨💻 Changes proposed

✅ Check List (Check all the applicable boxes)

[x] My code doesn't break any part of the project (Zero Octave-Javascript-Projects).
[x] This PR does not contain plagiarized content.
[x] My Addition/Changes works properly and matches the overall repo pattern.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Squash all commits into one and solve conflicts. Update no. 86 on README