set up end-to-end testing with authorization

Can someone remind me why I am assigned on this issue?  Am I supposed to be designing or documenting something?

We have introduced ACLs into the test environment pending documentation to be written (#594). These schema ACLs can be used in conjunction with a mocked session instead of integrating globus into our tests.

ok. I am closing this issue then.


Rancher Azure AD Integration not able to find User

Rancher Server Setup

Rancher version: 2.6.0
Installation option (Docker install/Helm Chart): Docker install on single node.
Proxy/Cert Details: Secured to official CA issued certificate.

Information about the Cluster
We manage multiple Clusters with this Rancher instance, RKE as well as AKS imported.

Kubernetes version: 1.20.5
Cluster Type: Imported AKS Cluster

Describe the bug
Rancher Auth is integrated with Azure AD since many Rancher versions ago (2.1 or so). This was done via separate Azure AD Service Principal according to rancher docs. After that were able to add AD users to rancher projects / clusters and so forth. Since some time ago (even before updating to Rancher 2.6) while trying to add users to resources, we are not able to find/select any kind of user anymore.
I know the search user functionality is limited when connected with Azure AD, but I tried many possible IDs:

Azure AD User Principal Name
Azure AD User Object ID
Rancher internal principal syntax:

azuread_user://"azure-ad-user-object-id"
local://"rancher-user-id"

Nothing seems to work. Rancher always claims it could not find any user.
To Reproduce
Difficult to say since it worked and stopped working along the way.
Expected Result
While the Azure AD integration seems to be set up fine (and already added users can login and authenticate as usual) I expect the add user panel to find the AD user I am entering.
Result

Even more strange is that the dropdown (which by documentation only shows the AD groups I am member of) works correctly.

Screenshots

Additional context
The Azure AD we integrate to is managed by our customer. They tend to continuously harden the security of the whole azure setup (activating PIM for example). While the (needed) API permissions were all consented by admin and the service principal client secret is still active, is it possible that some new security measures hinder the principal from reading the AD?

Side note: We still use https://graph.windows.net/ instead of https://graph.microsoft.com Graph Endpoint bus as far as I can tell this is still correct to use in Rancher.
Would appreciate any pointers.

Upon further investigation, it appears that the issue is caused by my own personal login not having the correct AzureAD permissions. I presume Rancher is performing a Directory.AccessAsUser and upon this not being allowed ("insufficient permissions") doesn't know what to do.
It'd be great if Rancher displayed a more useful error message in this case.


Fixed the python modules to check XREF IDs to make sure their formats are right before inserting them into DB

also fixed bug/typos in the PMID and RGD ID patterns  (in the reference.yml file)

Thanks @azurebrd


Add Custom Relationship Documentation

Fixes: #47

Add documentation for the new custom Relationship feature.

This is a great start to documenting this, and I'm happy to merge this as-is, but IMO this is not verbose enough and would be better with screenshots and examples. This is a pretty advanced feature, and the source/destination filters are easy to get wrong. I think the Device to VLANs example we've been using to describe this would be perfect use-case for how to implement and expand the documentation.

I am absolutely willing to put more time in to expand it, just wanted to have something in place since there isn't any mention of the feature its self. More documentation on the filters would be very helpful as well as as the screenshots.  Let me know if I should add it here or how to proceed.

Let's go ahead and do it in chunks vs. as a monolithic PR. To your point, this at least gets something other there that we can expand upon.


Log analytics Information

Please add Log analytics structure to get to FD data and / or sample queries to point us in the right direction.  Any Gitub repo of saved queries or shared dashboard code that meat best practices would be awesome

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 62f7409d-5cbe-20d0-e37a-891981ecac97
Version Independent ID: ad725093-ebd3-ecfc-84c8-e7c19a715979
Content: Monitoring metrics and logs in Azure Front Door Service
Content Source: articles/frontdoor/front-door-diagnostics.md
Service: frontdoor
GitHub Login: @sharad4u
Microsoft Alias: sharadag

@sharad4u is there any update on this? currently front door log analytics has very little guidance on what entities within log analytics should be queried or how to find useful information.  There are hundreds of data entities in log analytics and it is not obvious where to start.

I need this too, my Front Door WAF policy blocks something in Prevention mode (know this as Detection mode is fine) and I've no idea how to see which rule(s) was being triggered

@ChrisSommers we figured it out - once you have turned on diagnostics and configured log analytics as a destination, run this in the query section of log analytics....
AzureDiagnostics
| where ResourceType == "FRONTDOORS" and Category == "FrontdoorWebApplicationFirewallLog"
| where action_s == "Block"

we found entries revealing that DefaultRuleSet-1.0-SQLI-942200 was being triggered by a http header.

@GuyHarwood - thanks, I just found that same query and found what was triggering the block.

#reassign: amitsriva

#reassign: gunjanj

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary. #please-close


Publish blog post on workflows security

edit
public draft

Make sure that you have enabled TLS encryption, which is the default in recent versions. This prevent MITM attacks.

Do you need to be able to submit or change workflows via the UI? If not, remove any write permissions from therole/argo-server-role . This is the principle of least privilege.

Determine your multi-tenancy model. If you use SSO, use the SSO+RBAC feature to limit users by groups to just their own namespace.

Do we have docs we can link to?

Limit outbound requests from the server using egress and security groups.

We can link to https://kubernetes.io/docs/concepts/services-networking/network-policies/

The image argoproj/argocli is a scratch image that runs as non-root.

Incomplete thought?


pass the user not the api_user to the subject selector

this should fix the no method errors introduced from #1682 & #1676

Belated LGTM :p


post requests w/ sanic

hello,
I'm looking at the docs and can't figure out how to make a post request with data and headers..
from sanic import Sanic
from sanic.response import json as sanic_json
import json

app = Sanic()

TOKEN_URL = 'https://discordapp.com/api/oauth2/token'

def load_config():
    with open('./config.json', 'r') as config:
        return json.load(config)

async def exchange_code(code):
    config = load_config()
    config['code'] = code
    headers = {
        'Content-Type' : 'application/x-www-form-urlencoded'
    }
    resp = await app.post(uri=TOKEN_URL, data=config, headers=headers)
    print(resp)

@app.route("/auth/callback")
async def discord_auth(request):
    DISCORD_CODE = request.query_args[0][1] # Get the code
    # Call TOKEN_URL via POST Request.
    await exchange_code(DISCORD_CODE)
    return sanic_json({"hello" : "world"})

if __name__ == "__main__":
    app.run(host='<IP_ADDRESS>', port=3001, debug=True)```

it keeps saying data and headers are not valid params or something. I looked at the docs but the docs mention nothing about headers/data.

app.post would add a route for your sanic API, it does not post to an external URI.
I don't think this accomplishes what you're trying to do - it looks like you're trying to post data to a discord uri.

@ansonfoong What you need is requests-async

Closing. Sanic does not make outbound requests and advice has been given to use a package that does.


Why cant i successfully make my own mssql-server-windows-express image with the supplied docker files & .ps1 script?

I cannot successfully build and run this image on win 10 enterprise 1803. I can successfully run the already built image, and i can build the image myself but when i try to run the image i just built myself , the container stops after about a minute because of:

docker logs 8fd
VERBOSE: Starting SQL Server
start-service : Failed to start service 'SQL Server (SQLEXPRESS)
(MSSQL$SQLEXPRESS)'.
At C:\start.ps1:27 char:1

start-service MSSQL`$SQLEXPRESS

  + CategoryInfo          : OpenError: (System.ServiceProcess.ServiceControl
 ler:ServiceController) [Start-Service], ServiceCommandException
  + FullyQualifiedErrorId : StartServiceFailed,Microsoft.PowerShell.Commands
 .StartServiceCommand

Is there any reason this will not build on win 10 1803 ?  I cannot use this image successfully as a parent image for another build (i have given up trying to troubleshoot it) so Im back to basics to see if i can at least get it to build with the  default supplied ms docker file & ps1 script.
host os: win 10 enterprise 1803
docker: 18.03.1-ce
using dockerfile and ps1 from here:
https://github.com/Microsoft/mssql-docker/tree/master/windows/mssql-server-windows-express

Can you please share the output from the docker build command?

Hello again :->. Please see build output below. I am using files from github (https://github.com/Microsoft/mssql-docker/blob/master/windows/mssql-server-windows-express/dockerfile) . I had a query about the param() keyword not being within a function in the start.ps1, but the script is failing at the first attempt to start the SQL service. (line 27), so i dont think param() is relevant here
Build output:
PS E:\spikecontainerstaging\microsoftsqlservercontainer> docker build  -t mssqlexpresscontainer .
Sending build context to Docker daemon  6.656kB
Step 1/10 : FROM microsoft/windowsservercore
---> 9dbf7f740334
Step 2/10 : LABEL maintainer "Perry Skountrianos"
---> Running in b6c503d1a09c
Removing intermediate container b6c503d1a09c
---> 4c16f935f0cf
Step 3/10 : ENV sql_express_download_url "https://go.microsoft.com/fwlink/?linkid=829176"
---> Running in c1d74ad98892
Removing intermediate container c1d74ad98892
---> e8144a02ca33
Step 4/10 : ENV sa_password=""     attach_dbs="[]"     ACCEPT_EULA=""     sa_password_path="C:\ProgramData\Docker\secrets\sa-password"
---> Running in 4c2d534d6389
Removing intermediate container 4c2d534d6389
---> ef539c31c003
Step 5/10 : SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
---> Running in 59b212174c86
Removing intermediate container 59b212174c86
---> ffab15ca5d2a
Step 6/10 : COPY start.ps1 /
---> 7e67ce242435
Step 7/10 : WORKDIR /
Removing intermediate container b0a04b875c05
---> 48a4439a6bc0
Step 8/10 : RUN Invoke-WebRequest -Uri $env:sql_express_download_url -OutFile sqlexpress.exe ;         Start-Process -Wait -FilePath .\sqlexpress.exe -ArgumentList /qs, /x:setup ;         .\setup\setup.exe /q /ACTION=Install /INSTANCENAME=SQLEXPRESS /FEATURES=SQLEngine /UPDATEENABLED=0 /SQLSVCACCOUNT='NT AUTHORITY\System' /SQLSYSADMINACCOUNTS='BUILTIN\ADMINISTRATORS' /TCPENABLED=1 /NPENABLED=0 /IACCEPTSQLSERVERLICENSETERMS ;         Remove-Item -Recurse -Force sqlexpress.exe, setup
---> Running in 23157c9d5871
Microsoft .NET Framework CasPol 4.6.1586.0
for Microsoft .NET Framework version 4.6.1586.0
Copyright (C) Microsoft Corporation.  All rights reserved.
WARNING: The .NET Framework does not apply CAS policy by default. Any settings
shown or modified by CasPol will only affect applications that opt into using
CAS policy.
Please see http://go.microsoft.com/fwlink/?LinkId=131738 for more information.
Success
Microsoft .NET Framework CasPol 4.6.1586.0
for Microsoft .NET Framework version 4.6.1586.0
Copyright (C) Microsoft Corporation.  All rights reserved.
WARNING: The .NET Framework does not apply CAS policy by default. Any settings
shown or modified by CasPol will only affect applications that opt into using
CAS policy.
Please see http://go.microsoft.com/fwlink/?LinkId=131738 for more information.
Success
SQL Server 2017 transmits information about your installation experience, as well as other usage and performance data, to Microsoft to help improve the product. To learn more about SQL Server 2017 data processing and privacy controls, please see the Privacy Statement.
Microsoft (R) SQL Server 2017 14.00.1000.169
Copyright (c) 2017 Microsoft.  All rights reserved.
Removing intermediate container 23157c9d5871
---> 48f0cee53bc9
Step 9/10 : RUN stop-service MSSQL`$SQLEXPRESS ;         set-itemproperty -path 'HKLM:\software\microsoft\microsoft sql server\mssql14.SQLEXPRESS\mssqlserver\supersocketnetlib\tcp\ipall' -name tcpdynamicports -value '' ;         set-itemproperty -path 'HKLM:\software\microsoft\microsoft sql server\mssql14.SQLEXPRESS\mssqlserver\supersocketnetlib\tcp\ipall' -name tcpport -value 1433 ;         set-itemproperty -path 'HKLM:\software\microsoft\microsoft sql server\mssql14.SQLEXPRESS\mssqlserver' -name LoginMode -value 2 ;
---> Running in 2d55841ec435
Removing intermediate container 2d55841ec435
---> 05c6eb97ff0f
Step 10/10 : CMD .\start -sa_password $env:sa_password -ACCEPT_EULA $env:ACCEPT_EULA -attach_dbs "$env:attach_dbs" -Verbose
---> Running in ae9979aaf3f4
Removing intermediate container ae9979aaf3f4
---> 1aef8a9a097e
Successfully built 1aef8a9a097e
Successfully tagged mssqlexpresscontainer:latest
PS E:\spikecontainerstaging\microsoftsqlservercontainer>

Im closing this as the microsoft windows & SQL image docker files and scripts are out of sync with the latest windows server core image (ie tagged as latest) and do not build .  Be warned!!! Solution provided here: https://github.com/Microsoft/mssql-docker/issues/279 (Basically use a specific window server core image, and dont rely on latest. There is no way however to know which tagged image to use.)
There was some chatter about getting docker files in sync with windows 1803 image.


About the MALIDUP_ns dataset

Dear Shintaro Minami,
Very grateful for your wonderful works and great contribution to the community. MALIDUP_ns dataset now has become a benchmark dataset for the assessment of non-sequential structural protein alignment algorithms, but it seems that there may be no official availability of this important dataset. Could you please share the MALIDUP_ns dataset in the MICAN homepage?
Many thanks for your generous help and great contributions.
Looking forwards to your reply.

Dear Dr. Shintaro Minami,
I have sent an email to Professor. George Chikenji and he has kindly sent me the MALIDUP_ns dataset.
Many thanks again for your great NS tool and datasets!

I'm happy to heard that you've gotten the dataset from Chikenji-san. But I'm so sorry for the late reply. I added MALIDUP_ns dataset to the repo for someone facing the problem in some future. Thank you so much for catching the issue. And lastly, thank you so much for using MICAN algorithm and dataset!


how to add pyqtwebengine in yocto image

pyqtwebengine is not available in python3-pyqt5 how can i add pyqtwebengine in image.
i am using respberry pi4 Machine and using Yocto dunfell branch

@Martin' JaMa' Jansa kindly look in this issue

I'm sorry, I don't have much time/motivation for meta-qt5

@kraj kindly look in this issue and suggest something i am stuck at that point.


feat: opentelemetry integration, removed self designed tracing

[x] integrated with rest
[x] integrated with zrpc
[x] integrated with logx
[x] write trace id back in http header with name X-Trace-Id
[x] support jaeger exporter
[x] support zipkin exporter
[x] support logx without exporter configured

+lgtm


[Bug] Progress indicator does not work with large files

Is there an existing issue for this?

[X] I have searched the existing issues

Have you updated FilePond and its plugins?

[X] I have updated FilePond and its plugins

Describe the bug
I am trying to upload large files (~.5 GB) and the percentage progress indicator does not seem to work when doing so. It works just fine for smaller files. I have not been able to figure out exactly how large the file needs to be in order to trigger this. Below is an example of uploading a small image file and then a large installer file.

Reproduction
Upload any large file. I have been using files around .5 GB
Environment
- Device: Microsoft Windows PC
- OS: Windows 11
- Browser: Chrome

I am facing the same issue on production server.
Percentage progress shows on local development but not showing on production server if file size bigger than 1MB.

I am having the same issue as well....any update on this?

I'm not sure, handling of small and large files is the same, is it perhaps possible the server is not returning progress updates?

Hmmm….i see. But would it be possible for the server to have 2 different modes? i.e. set updates for smaller files and
not sending updates for larger ones? To be honest i have not checked at which file size we do have this behavior switch.
I might test it and get back to you…Thanks Rik

On 7 Nov 2022, at 9:50 AM, Rik @.***> wrote:
I'm not sure, handling of small and large files is the same, is it perhaps possible the server is not returning progress updates?
—
Reply to this email directly, view it on GitHub https://github.com/pqina/filepond/issues/842#issuecomment-1305208476, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3P3QPXPOHSEFS5SDPWBTDWHCYGDANCNFSM5W5JJEIA.
You are receiving this because you commented.


How to forward form submission to email and don't store it on netlify

Title says it all. How does that work? This seems to be the best option for gdpr compliance.

Hi, you can't bypass storing form submissions in our database. If all you want to do is have them sent to your e-mail then your best bet is to make a lambda function that just takes submissions and mails them to you directly.


controller inputs

three only provides handlers for trigger and squeeze events. need to get:

[x] thumbstick (x, -x, y, -y)
[x] thumbstick press
[x] A
[x] B
[ ] controller position
[ ] controller orientation

the first four use CustomEvent emitters written in Loop.js and listened for in World.js. pos and ori could do the same, but holding off until we need them (seems like they might only need to be done in the controller output synth module, in which case we might get away with using a tick() method and polling the controller pos and ori right there.

4.x abandoned. archived in mischmaschWeb


Provide maps in other languages

If you have a map layer that you would like in your language, please comment and I'll try to support.

If there is a need for any of these, please reach out to me. I'll leave this open for comments.


Validation, beautiful validation

Features

Added validation for product limits (127177411)

@srleach

@sped2773 Can you review this?

Don't go to 2dp just whole numbers
No max length limit set use max length 2 (once dp removed)

@sped2773 Ready for review again

Values not updating

@sped2773 ready again


Response type normalization makes harder to define custom decorators

Response type normalization makes harder to define custom decorators for request handlers.
The example presented here: https://www.neoteroi.dev/blacksheep/middlewares/#wrapping-request-handlers
doesn't work when response type normalization is used.
TODO: check and find a solution; a custom @wraps decorator might be acceptable

The issue has been resolved, but documentation must be updated.

Documented here https://www.neoteroi.dev/blacksheep/middlewares/#wrapping-request-handlers


Fix issue with maven reflections

Fix issue with maven reflections caused by commit https://github.com/meltmedia/cadmium/commit/66a270a3acec9209a770717ea74f95f2f5f31439
This was causing sites using development version of cadmium to fail
Since the plugin is deprecated, I have replaced it via gmaven-plus as per recommendation by the author: https://github.com/ronmamo/reflections-maven.
The bamboo build is activated and is passing.
Verified fix using Gazyva site (cadmium-test branch).

@FunnyGopher @jacobheun   Ready for review.


Rescan networks does not always list all network if you have about 8 ssid's

Just minor report: I needed to rescan 3 times to get my newly created ssid out of a list of 8 ssid's.

@V4A001 We were unable to repro this. We tested it on the latest firmware v0.5330. There is no such limitation of 8 SSID's.
Which firmware version are you using?

Seems to be oke, was on version v0.5280_Perf

@V4A001 Since this is no longer a repro, we are closing this issue.


Update lang pack extension strings from previous refresh

Lang pack version bumped to 1.26 and lang pack strings have been refreshed. Not sure if contributes translations need to be updated or not. Currently following what was done in previous refresh.

@kburtram From my understanding the last PR was for updating the localization resource files/strings in the i18n folders, e.g. "deu" and not for updating the lang packs. These resource strings were generated using the built in tools in the gulpfile (vscode-translations-import) using the available translated XLF files that we have in resources/xlf folder.
The PR I'm doing here is updating the lang packs using the same XLF files  (hence the similarity). These files use the built in command (update-localization-extension) to update the JSON files in lang packs.


Disableable microphone

The script currently records your microphone as well.
It would be nice to have a variable to disable/enable it as parameter as described in #4.

I added it to my fork. I would like to point out here that it would be nice to have those modes I implemented boilerplate code for (none,system,mic,both)


Replace 'partial' ts interface implementation with built-in Partial utility type

This is very minor refactor that removes redundant partial interface implementation with built-in typescript utility Partial types.

Duplicate of #839


Add support for handling JS confirm, alert and prompt in Selenium

JS window.alert, window.confirm and window.prompt were handled by Chromedriver and PhantomJS, but for Selenium functions for accept and dismiss them were not implemented.
This PR adds code that allows to use the following functions:
accept_alert/2,
accept_confirm/2,
accept_prompt/2,
accept_prompt/3,
dismiss_confirm/2
dismiss_prompt/2,
dismiss_alert/2.

To make it work with Firefox as well as Chrome, the dismiss_prompt/2 endpoint was switched to the one specified by Selenium WebDriver JSON Wire Protocol (instead of the endpoint specified in the W3C WebDriver specification), which is the same as dismiss_confirm/2. This change also affects the Chromedriver backend (since it uses the same WebDriver module as Selenium) but should not cause any regressions.
Since all dialog tests should be now passing on all platforms, integration_test/cases/browser/dialog_test.exs was moved to the set of default tests for all drivers.
edit: force-pushed to rebase on current upstream master

Conflict resolved

Can I get a thumbs up again please? Couldn't merge earlier because of a conflict

@michallepicki Done :)


unbound variable: REINSTALL_PACKAGES_FROM

Operating system and version: Arch Linux 4.10.9-1-ARCH / nvm 0.33.1

nvm debug output:

nvm --version: v0.33.1
$SHELL: /bin/bash
$HOME: /home/username
$NVM_DIR: '$HOME/.nvm'
$PREFIX: ''
$NPM_CONFIG_PREFIX: ''
$NVM_NODEJS_ORG_MIRROR: 'https://nodejs.org/dist'
$NVM_IOJS_ORG_MIRROR: 'https://iojs.org/dist'
nvm current: system
which node: /usr/bin/node
which iojs: which: no iojs in (/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl)
which npm: /usr/bin/npm
npm config get prefix: /usr
npm root -g: /usr/lib/node_modules

nvm ls output:

How did you install nvm? (e.g. install script in readme, homebrew):
install script from cloned repo

What steps did you perform?
installed nvm, ran nvm.sh manually to set up the environment, through a script

What happened?
nvm.sh throws an unbound variable error on line 2474: $REINSTALL_PACKAGES_FROM - confirmed this isn't because of settings in the parent script

What did you expect to happen?
nvm.sh to complete successfully

Is there anything in any of your profile files (.bashrc, .bash_profile, .zshrc, etc) that modifies the PATH?
/etc/profile sets PATH="/usr/local/sbin:/usr/local/bin:/usr/bin"

I've managed to work around this by changing nvm.sh before execution:
sed -i '2474,2476s/$REINSTALL_PACKAGES_FROM/${REINSTALL_PACKAGES_FROM:-}/' /home/username/.nvm/nvm.sh
this seems similar to #1413 , which I also worked around by setting MANPATH="" and then unsetting it after nvm.sh but that issue is resolved in the master branch.

I have run into this too. The problem appears to be when running in a shell with set -u specified. There are a few similar bugs, another one I ran into is nvm.sh: line 3103: ALIAS: unbound variable.
These issues prevent using nvm from scripts with set -u specified, which sucks :(

@alexjurkiewicz @MechaLynx do you still see REINSTALL_PACKAGES_FROM appearing with the latest nvm?
@alexjurkiewicz if you'd mind filing a new issue for ALIAS, that'd be appreciated.

Unfortunately I'm seeing the error on a shared CI server, so I can't go and change the nvm version. For the record I saw the ALIAS error with 0.33.2. I'll file a new issue.

I still see REINSTALL_PACKAGES_FROM appearing with nvm 0.33.2 when used in conjunction with set -u.

@ljharb I tested nvm.sh using set -u in bash and also made a test script that ran nvm.sh using set -eu as well, in neither case does it complain about any unset variable.
I did a git reset --hard and pull on the repo before testing, so I'm using commit 4f626eac, the one with the fix.
I originally encountered this through a bigger script, which I can't test right now because I'm in the process of heavily refactoring it. I will try installing nvm on a fresh VM though (since the system I tried already had it installed), to make sure it's fixed.

FWIW, I was able to trigger this (while set-u was enabled) by doing an nvm install 7.8.0and then immediately followed by annvm use 7.8.0`.

@joshdick Yeah I can reproduce that. The original unbound variable from nvm.sh is gone (tried it again on a fresh Manjaro install, without node installed - original report was with Arch) but requesting a valid version from nvm install results in the unbound error you reported. With invalid versions nvm exits before it gets to that point.
@joshdick @ljharb Running nvm use just quits for me, it doesn't cause the unbound variable error, it just gives up since there is no node installed. Even after installing nodejs from pacman, nvm use doesn't give me any errors and nvm use system works ok (I'm assuming that's not a meaningful test though). However, nvm ls says STABLE and UNSTABLE are unbound variables, but otherwise produces the rest of its output as normal.
All of this is with just set -u in bash running interactively, with the exception of the repeated tests from before.

Thanks, I'll see what I can do.

@MechaLynx i'm not sure what pacman is, and afaik only apt calls it "nodejs".
I can't reproduce any set -u errors with STABLE or UNSTABLE on latest master from nvm ls, and #1516 seems to have fixed REINSTALL_PACKAGES_FROM.
I'm going to close this for now, but please do file a new issue if you see any new instances of this problem. (Please wait until the next release before re-reporting REINSTALL_PACKAGES_FROM)

@ljharb Sure thing dude, I'll be putting it to the test with the original script soon anyway.
For future reference, pacman is the package manager for Arch Linux, and they do call it nodejs :P. The reason I tested with Manjaro is because it's based on Arch and shares the same packages and basic setup. Their user repository of packages (those made by users) has nvm but I didn't use that version in either case - both times it was the repo, just so nobody wonders if they read this issue in the future.


docs: add documents and postinstallation scripts for Cli.js deprecation

Description

Add a migration guide markdown to transition from cli.js and ag to AsyncAPI CLI
Add a postinstall.js to generate post-installation script after installing the generator package.
update the homepage ReadMe to notify this change.

Related issue(s)

Resolves #1229

Looking Good @lmgyuan

@lmgyuan hey, any updates

@derberg I just updated the PR. We can discuss this on Wednesday.


releaseStage not change [react-native]

I try to configure the Bugsnag with different releaseStage for each environment and it's don't change (always report with develipment)
Bugsnag.start({ releaseStage: 'staging' })

same in Android and Ios

@bugsnag/react-native 7.6.0v
react-native 61.5v

Hey @idanlevi1, in @bugsnag/react-native, it'll use the native configuration always. This is the design intent, to ensure that the configuration is set as early as possible so native errors get caught with the correct configuration including releaseStage. Please do let us know if this behaviour is different from that which I've described here.
It is possible to set these values at build time, as discussed in the reply here: https://github.com/bugsnag/bugsnag-js/issues/1264#issuecomment-767191963

Hey @idanlevi1, in @bugsnag/react-native, it'll use the native configuration always. This is the design intent, to ensure that the configuration is set as early as possible so native errors get caught with the correct configuration including releaseStage. Please do let us know if this behaviour is different from that which I've described here.
It is possible to set these values at build time, as discussed in the reply here: https://github.com/bugsnag/bugsnag-js/issues/1264#issuecomment-767191963


Use Js2Py as a fallback

When no native JS VM is available, it's better than nothing to use a pure Python implementation: https://github.com/PiotrDabkowski/Js2Py

I do not think that falling back to Js2Py is inconsistent with the use cases of PyExecJS.
One use case of PyExecJS is to execute JS with NodeJS.
There, falling back to Js2Py is useless.
The other use case of PyExecJS is to execute JS program without platform specific problems.
It is not important for me whether VM is native or non-native.
So, if Js2Py worked well as a fallback, I am able to use Js2Py as a primary.
So, I would not to use Js2Py as a fallback now.

The idea is: in places you cannot (or don't want to) installed a compiled dependancy, you will be happy to be using PyExecJS and see it working anyway. But then if you move your code to a place you can install say, nodeJS, then you can enjoy the speed boost without any changes to your code. PyExecJS is the abstraction.
It's the same than using an ORM, and having it capable of running SQLite and Postgres. Yes, if you can have PostGres installed, it's better.

I do not have enough time to implement Js2Py runtime. I am awaiting for your pull request.


ERROR in EPERM: operation not permitted, stat 'D:\System Volume Information'

Hello,
I have updated my project from Angular 5.2 to new version Angular 6. I have used Angular Update Guide - 5.2 -> 6.0 for Medium Apps.  Everything went well. But I have an error if I try to use ng build, ng build --prod or ng s. The error message is ERROR in EPERM: operation not permitted, stat 'D:\System Volume Information'
Versions
Angular CLI: 6.0.0
Node: 8.9.1
OS: win32 x64
Angular: 6.0.0
... animations, cli, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router
Package                           Version
@angular-devkit/architect         0.6.0
@angular-devkit/build-angular     0.6.0
@angular-devkit/build-optimizer   0.6.0
@angular-devkit/core              0.6.0
@angular-devkit/schematics        0.6.0
@ngtools/webpack                  6.0.0
@schematics/angular               0.6.0
@schematics/update                0.6.0
rxjs                              6.1.0
typescript                        2.7.2
webpack                           4.6.0
Repro steps

Step 1
execute command ng build or ng build --prod or ng s

Observed behavior
ng s
** Angular Live Development Server is listening on localhost: 4200, open your browser on http://localhost:4200/ **
Date: 2018-05-10T08:50:54.287Z
Hash: f2a2a12ef36617e0d5cc
Time: 22694ms
chunk {0} 0.js, 0.js.map () 1.53 MB  [rendered]
chunk {main} main.js, main.js.map (main) 1.37 MB [initial] [rendered]
chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 417 kB [initial] [rendered]
chunk {runtime} runtime.js, runtime.js.map (runtime) 7.96 kB [entry] [rendered]
chunk {scripts} scripts.js, scripts.js.map (scripts) 381 kB  [rendered]
chunk {styles} styles.js, styles.js.map (styles) 360 kB [initial] [rendered]
chunk {vendor} vendor.js, vendor.js.map (vendor) 7.72 MB [initial] [rendered]
ERROR in EPERM: operation not permitted, stat 'D:\System Volume Information'
i ｢wdm｣: Failed to compile.

Stack:
"ReferenceError: error is not defined
at eval (eval at errors (http://localhost:4200/vendor.js:173286:5), :1:1)
at Object.errors (http://localhost:4200/vendor.js:173286:5)
at SockJS.onmessage (http://localhost:4200/vendor.js:173568:25)
at SockJS.EventTarget.dispatchEvent (http://localhost:4200/vendor.js:162610:20)
at http://localhost:4200/vendor.js:163323:16
at Array.forEach ()
at SockJS._transportMessage (http://localhost:4200/vendor.js:163321:17)
at WebSocketTransport.EventEmitter.emit (http://localhost:4200/vendor.js:162526:18)
at WebSocketTransport.ws.onmessage [as __zone_symbol__ON_PROPERTYmessage] (http://localhost:4200/vendor.js:165397:10)
at WebSocket.wrapFn (http://localhost:4200/polyfills.js:7940:39)"
Desired behavior
successful compile and build
Mention any other details that might be useful (optional)
I have not uninstalled rxjs-compat, because I have some third party dependencies that use the old version of rxjs.

This appears to be a bug but we will need to look at a reproduction to find and fix the problem. Can you setup a minimal reproduction please?
You can read here why this is needed. A good way to make a minimal reproduction is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.

HI,
I have had created repo-app but unfortunately, I don't get the same error. As I said earlier this is a medium application intend to be large very soon. I will try to roll back the application and try everything from begin, again. The major problem is error message: ERROR in EPERM: operation not permitted, stat 'D:\System Volume Information'  - it does not mean anything to me, is not descriptive.

I'm sorry, but we can't reproduce the problem following the instructions you provided.
Remember that we have a large number of issues to resolve, and have only a limited amount of time to reproduce your issue.
Short, explicit instructions make it much more likely we'll be able to reproduce the problem so we can fix it.
If the problem persists, please open a new issue following our submission guidelines.
A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.


Cookie path is truncated

I noticed that  https://github.com/brynary/rack-test/blob/master/lib/rack/test/cookie_jar.rb#L25  causes the URI path to be truncated.
irb(main):001:0> "/cookies/test".sub(/\/[^\/]*\Z/, "")
=> "/cookies"

I can have a go at fixing this (and related tests that may be broken) but I'm wondering if I'm missing something.  What was the motivation behind the regexp?

Hi,
The regexp in question came from Merb's MockRequest code, which Rack-Test is an extraction of, so unfortunately I did not write it originally.
To help understand further -- how did you run across this issue? If we can define an external behavior of Rack-Test that is undesirable, we can turn that into a test.
-Bryan

I believe the referenced regex does not comply to the cookie spec regarding what "Set-Cookie" should do if no path is specified.
According to RFC 2109: Section 4.3.1, the path "Defaults to the path of the request URL that generated the Set-Cookie response, up to, but not including, the right-most /." The regex above strips the last component of the URI (more than just the right-most "/").
For example, if the Set-Cookie header was issed in the response to the URI "/foo/bar" but without a path for the cookie, rack-test sets the path for the cookie to "/foo" instead of RFC compliant "/foo/bar".
Here's a commit demonstrating the broken behavior: https://github.com/noahd1/rack-test/commit/86e4cd0c82a4834121761fcdf6367dcc0c5c9ca0
Here's a link to the full RFC: http://www.ietf.org/rfc/rfc2109.txt

I bumped into this because I was using CookieJar#[]= to modify a cookie as part of a web app test (that users should not be able to tamper with their cookies).  Going through the []= -> merge() the uri is nil, leading to a default_uri being used which results in a path of "/".  That gets trimmed by the regexp to the empty string.
I'll have a crack at fixing up the regexp and related tests ... please yell if you're already doing this so we don't double up.

Ok so I misunderstood the RFC (BTW, rfc2109 is obsoleted, latest applicable RFC is http://tools.ietf.org/html/rfc6265).
To clarify what's supposed to happen:

when a Set-Cookie: header contains a Path attribute, use it, so "/cookies/blah" stays untouched
when the Path attribute is missing pick the directory out of the request URI, so "/foo/bar" becomes "/foo"

In short, the regexp is correct and the existing behaviour was mostly correct except when it was being applied to '/' and truncated it to the empty string.
I added a test that triggers the bug in Cookie.initialize and changed it so it exactly implements rfc6265 which hopefully makes it easier to understand as well.

Closing for lack of feedback. If anyone wants to give this a new try, the @v2e4lisp attempt in #100 is likely a good start!


Rust services fail to startup

Hello, i have been playing around with the setup of the project, I generated my poe and new relic credentials, but when i do make up the  all the rust services return the following error:
Error: Io(Custom { kind: Uncategorized, error: "failed to lookup address information: Name or service not known" })
[Finished running. Exit status: 1]

Any ideas what might be the problem?
My .env.development looks like this:
# General env info
ENV=development
RUST_LOG=info,ureq=warn,sqlx=warn
METRICS_PORT=4000

# Reverse Proxy
HOST=localhost
HOST_PUBLIC=localhost:8888
HTPASSWD='poe:poe'

# indexer
# DATABASE_URL=postgres://poe:poe@db:5432/poe
DATABASE_URL=postgres://poe:poe@db:5432/poe
TRADE_API_DATABASE_URL=postgres://poe:poe@db:5432/poe
RABBITMQ_SINK_ENABLED=true
RABBITMQ_URL=amqp://poe:poe@rabbitmq
RABBITMQ_PRODUCER_ROUTING_KEY=stash-record-stream
POE_CLIENT_ID=...
POE_CLIENT_SECRET=...

# trade
AMQP_ADDR=amqp://poe:poe@rabbitmq

# Postgres
POSTGRES_PASSWORD=poe
POSTGRES_USER=poe
POSTGRES_DB=poe
PG_DATA=/pg-data

# RabbitMQ
RABBITMQ_USER=poe
RABBITMQ_PASSWORD=poe

# Service Communication
RABBITMQ_HOST=rabbitmq
INDEXER_HOST=indexer
TRADE_API_HOST=trade-api
TRADE_INGEST_HOST=trade-ingest

# OTEL & New Relic
OTLP_ENDPOINT=https://otlp.eu01.nr-data.net:4318
OTLP_LICENSE_KEY=...

otel-collector-config.yaml:
receivers:
  otlp:
    protocols:
      grpc:
      http:

processors:
  batch:

exporters:
  otlp:
    endpoint: https://otlp.eu01.nr-data.net:4318
    headers:
      api-key:...

service:
  pipelines:
    traces:
      receivers: [otlp]
      processors: [batch]
      exporters: [otlp]
    metrics:
      receivers: [otlp]
      processors: [batch]
      exporters: [otlp]
    logs:
      receivers: [otlp]
      processors: [batch]
      exporters: [otlp]

Few things want to point out. I noticed that env variable TRADE_API_DATABASE_URL is referenced two times in the code but its not present in the template i assume it should be renamed to DATABASE_URL in the rust code. Also It would really helpfull to add some extra documentation for the project setup, it was not imediatly obvious that i have to copy the template, fill in the secrets and run instantiate.sh and how to do otlp setup.  Also why do we send otlp data in local dev enviroment to new relic? I would understand for a production setup, but for local development seems like bit overkill, would be nice to make it as an optional service for local development.
Best regards

Hey there, thank you for your feedback! You're absolutely right, the documentation is lacking and not user-friendly.
I just pushed a commit that should at least clean-up and fix .env.template a bit: https://github.com/maximumstock/poe-stash-indexer/blob/master/configuration/environments/.env.template.
In your specific case, the value for TRADE_API_DATABASE_URL is incorrect, it should point to trade-store as host (see latest .env.template). Reason being that the DATABASE_URL under #indexer refers to the database for the indexer service itself, which I haven't used in a while and might not even work out of the box. TRADE_API_DATABASE_URL refers to the PostgreSQL instance that the trade-ingest service writes to and trade-api reads from. Not saying this is the most practical, but that's what I ended up with while exploring.
I also made everything around OpenTelemetry optional, so looking at .env.template you'll see that the default is to not configure any OTLP or NewRelic stuff at all. Even with the old commit, you didn't need any New Relic credentials as the telemetrized services (indexer, trade-api, trade-ingest) were set-up to send traces to otel-collector (see docker-compose.yml) and the New Relic credentials were just necessary to send it from otel-collector to New Relic. Anyway, if you comment out the OTLP stuff as in .env.template, then no OTLP setup will be configured anymore.
As to why sending traces for an development environment - I just like having dev & prod as close as possible and New Relic's free tier is very generous :).

Generally the workflow for running this project is:

Create an .env.development from .env.template
make config to instantiate all service configurations based on .env.development
make build to build Docker images, as currently still necessary for some parts
make up, starting everything as declared in docker-compose.yml

For a separate production setup, change the following steps:

Create .env.production as you want
Run ENV=production make config

^ I've added this to the README.md. If you have any feedback, feel free to submit a PR or post here.
A couple of things that might change:

If you want to pipe indexer data directly into a database, then indexer in part can do that, but you might not like my database schema. Since most people have their own ideas on how to design and store the indexer data to use for their projects, I ended up using RabbitMQ as a middleman to stream stash tab data to the actual consumers. In my case this is a trade service, which lets you query who is selling what currency/map/stackable item at a given time.
I'm in the process of changing the dev environment to not user Docker images as its a bit too slow and cumbersome.
I'm also going to remove RabbitMQ from my personal projects, but will keep it as a sink that indexer can write to. I want to extend indexer to write directly to S3 and support a couple of sinks in parallel with a suitable configuration API, not sure if config file, environment variables or CLI args, probably environment variables though. My consumer projects will probably use stash-api directly to stream their own stash tab data.

Thank you for quick response and explaination now it makes more sense. I managed to get the app up and running. Aha great that OTLP is optional, will definetly explore it in the future for sure.
Actually I quite like the usage of RabbitMQ as a middleman for streaming stash tab data, i think its more robust service arhitecture than sending data directly to postgres. Actually I was wondering about rust development experiance in docker, I was playing around with the code and whenever I change few lines it takes more than minute to compile and reload. Is this normal? I come form a python django background and this really suprised me. Hm maybe i didnt understand right but you want to replace RabbitMQ with AWS S3?  Would this introduce some latency? also how you plan to store the data on s3 as json files or?

Actually I quite like the usage of RabbitMQ as a middleman for streaming stash tab data, i think its more robust service arhitecture than sending data directly to postgres.

Yes, I agree. I don't want to remove it fully in the sense of drop support from indexer for RabbitMQ, but at least I don't want to use it in my own running deployments. Having a message queue decouples things nicely, but it is a lot of extra effort infrastructure-wise. I want to be able to deploy this onto AWS (or any other cloud provider) to gain more experience there and try things out, but the current setup with RabbitMQ does not map nicely to AWS, unless you want to pay for a RabbitMQ cluster (or extra EC2 nodes).
Instead of having one producer that listens to the stash tab stream and makes it available via RabbitMQ, any consumer/consuming project can just listen to the stream itself. You download GGG's data multiple times, sure, but that part is dirt cheap and results in actually separated services, instead of managing a distributed monolith like it would be right now. So trade-ingest would just use stash-api itself and stream the data directly and I can have indexer to write to RabbitMQ and/or S3 to support whatever use-case I have.
Anyways, having indexer stream to RabbitMQ will still be available as an option, so you could plug in any consumer written in any language you desire.

Actually I was wondering about rust development experiance in docker, I was playing around with the code and whenever I change few lines it takes more than minute to compile and reload. Is this normal? I come form a python django background and this really suprised me.

Yeah, this is certainly setup-related. I remember it being faster in the past, not sure what is going on there. I'm fairly certain it is fine on my Linux desktop and just slow on the MacBook, probably due to filesystem differences with native/non-native Docker. What are you running?

Ahaa okey i kinda understand now why you want to move away from RabbitMQ if you building non monolithic app, but how do you intend to store the data in S3 as raw json?
Im running M1 max, and its really painfully slow. It looks like its recompling everytime i make a code change, are there any possibilities to use a cache for compling?

Im running M1 max, and its really painfully slow. It looks like its recompling everytime i make a code change, are there any possibilities to use a cache for compling?

If you start all the containers up with make up they already only recompile what is absolutely necessary, but it does take an awfully long time. I'll investigate a bit, but we can also pivot to running the services locally and only starting the infra services via docker-compose.

Ahaa okey i kinda understand now why you want to move away from RabbitMQ if you building non monolithic app, but how do you intend to store the data in S3 as raw json?

I'm experimenting with plain .json files right now, where one file contains all stash updates of one minute, so you have 2023/08/04/11/{49,50,51..}.json in S3. I wanted to look into how to model this as a data lake as a default S3 sink format, but I don't really know yet how to design that in a useful way. Ultimately, the S3 file design depends on your querying patterns and I don't think there will be one universal design, but I think going for compressed parquet files and having one per minute (or a longer period) should be useful.
With an increasing time bucket, eg. 5 minutes, it might also make sense to use something like AWS Kinesis Firehose to automatically bundle single chunks without having to do it yourself. I'll try to have something ready before the new league so I can start collecting a dataset.

Yes i did it like that but yeah 2 min for recompile is a bit to much, i will try tweaking the resources for the docker engine if that helps.
Just curious do you have an estimate how much data you generate of one day of processing the public stashes? Also let me know if you need any help with any other tasks otherwise we can close this issue.

Yes i did it like that but yeah 2 min for recompile is a bit to much, i will try tweaking the resources for the docker engine if that helps.

I don't have an exact idea of what it is, but I'd experiment with changing the docker volumes in docker-compose.yaml and also change the base image that the crate-specific Dockerfiles (ie. indexer) are using. I switched to rust:bullseye a while ago and think it was faster before.

Just curious do you have an estimate how much data you generate of one day of processing the public stashes? Also let me know if you need any help with any other tasks otherwise we can close this issue.

Depends on how and when you store it. My first attempt was dumping everything into a database with a couple indices to query for account names, stash ids, etc. but the main stash info was just a JSONB dump in PostgreSQL and the database ended up being roughly 500 GB for 1-2 seasons (note: purely the respective challenge leagues as SC & HC, without the two standard leagues and private league shenanigans). If you plan to pipe the data into any database for analytical queries, I think it heavily depends on the type of queries and required indices.
If you have any feature requests or ideas, feel free to open tickets :). The other existing issues are merely a way for me to note down some ideas, but nothing worthy to actually donate your time to. I heavily appreciate it though!


Adding FlightPHP

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Happy to help out @deniseyu!

hey @spekulatius, do you mind hitting the button to merge master into this branch and tagging me when you've done it? For reasons that I don't quite understand, the "merge" button has disappeared for me 😂  I'll merge this once it's even with the base branch!

No worries @deniseyu. I've rebased the branch - it should be merge-able now.  👍

Thanks for merging @deniseyu :)


loginWithPassword and other mutations return null

My setup: https://github.com/janikvonrotz/meteor-apollo-accounts-example/tree/bug/nullreturn
Now when I try:
mutation{
  loginWithPassword(email<EMAIL_ADDRESS>plainPassword: "password")	{
    id
    token
    tokenExpires
  }
}

it returns
{
  "data": {
    "loginWithPassword": null
  }
}

The user exist and no other errors are thrown.
Of course I tried to debug it, but was not successful.

Is "passsword" a typo ?
I'll try to reproduce this case.
Do you think that we'll be able soon to do something like :
  loginWithPassword(email<EMAIL_ADDRESS>plainPassword: "passsword")	{
    id
    token
    tokenExpires
    profile
  }

?

Hmm very strange @janikvonrotz... It's ok in my app. It's the password with 3 s?

Password with 3 s was a typo, but didn't solve the error.

Forgot to turn the resolver spread into a function.
This ...Resolvers into ...Resolvers().


TitleState Tweens

i just stole the tweens from horizon engine lol

question: should i change the newgrounds sprite tween to fly out from the left or should i leave it as is?


Cannot see the diff anymore in the Light Modern theme

Type: Feature Request
I've setup the new Light Modern theme and wanted to see the changes I've made via a diff. But since I'm colorblind, I cannot see the difference anymore between the old (reds) and new (greens). Can you maybe adjust the colors a bit so I - and other people that are colorblind - are able again to see the diffs. Thanks! :)
VS Code version: Code 1.78.1 (6a995c4f4cc2ced6e3237749973982e751cb0bf9, 2023-05-04T09:48:08.683Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: Yes

Thanks for reporting! We'll get this fixed. Is there any particular type of colorblindness I should be aware of here?
Did the old themes (Light+, Dark+) work out ok for you for reviewing diffs?

Hi David, I'm color blind for reds and greens (Deuteranomaly). I've used the Light+ theme before and with that theme I can easily distinguish reds and greens in the diff. I've tried it on several displays with the new theme, but of none of these displays I could see the difference between both colors.

Maybe in addition, the same applies for the dark themes. For the old Dark+ theme I could see the difference, for the new Dark Modern I couldn't.

Thanks, that's helpful. I'll explore a few options and will report back here for your feedback 👍

Hi @shirleydejong 👋
I've tweaked the theme slightly: pulled the reds slightly towards magenta, and the greens towards blue. Using a colourblindness simulator I can see more contrast between the added/removed lines.
Here's a screenshot with the old theme on the left, and the updated theme on the right:

Simulated:

Let me know if this is a step in the right direction.

Hi @hbons, for this Light theme it's easier to see the differences. But for the Dark theme it's still a bit hard (for me). Thanks for looking into this!

@hbons one thing we could do in the meantime is to fall back to the colors used in Dark+ until we're confident about a solution here. That would just mean we remove the overrides from the Dark/Light modern theme files.

Created #188668 to revert the colours for now until we find better options. We can leave this issue open. #188668


cargo ignores rust-toolchain.toml on macOS

Problem
cargo ignores toolchain specified in rust-toolchain.toml on macOS 10.15.7.
At the same time rust-toolchain works as expected and overrides default toolchain.
Steps

cargo init foobar && cd foobar
printf '[toolchain]\nchannel = "nightly"\n' > rust-toolchain.toml
rustc --version

Expected nightly version (as on linux), but I've got system-wide default stable channel.
Possible Solution(s)
No response
Notes
No response
Version
cargo 1.63.0 (fd9c4297c 2022-07-01)
release: 1.63.0
commit-hash: fd9c4297ccbee36d39e9a79067edab0b614edb5a
commit-date: 2022-07-01
host: x86_64-apple-darwin
libgit2: 1.4.2 (sys:0.14.2 vendored)
libcurl: 7.64.1 (sys:0.4.55+curl-7.83.1 system ssl:(SecureTransport) LibreSSL/2.8.3)
os: Mac OS 10.15.7 [64-bit]

Can you post the output of rustup show?  It should be working, and it may be possible there are other overrides in place. I would check for a directory override (rustup override list) or check if the RUSTUP_TOOLCHAIN environment variable is set.

Default host: x86_64-apple-darwin
rustup home:  /Users/hrls/.rustup

installed toolchains
--------------------

stable-x86_64-apple-darwin (default)
nightly-x86_64-apple-darwin
bpf
sbf

installed targets for active toolchain
--------------------------------------

wasm32-unknown-unknown
x86_64-apple-darwin
x86_64-unknown-linux-gnu

active toolchain
----------------

stable-x86_64-apple-darwin (default)
rustc 1.63.0 (4b91a6ea7 2022-08-08)

I think ehuss was talking about rustup toolchain overriding rules. Could you check if any of the followings overrides your toolchain setup?

A toolchain override shorthand used on the command-line, such as cargo +beta.
The RUSTUP_TOOLCHAIN environment variable.
A directory override, set with the rustup override command.
The rust-toolchain.toml file.
The default toolchain.

Ref: https://rust-lang.github.io/rustup/overrides.html#overrides
I would also look into which rustc or which cargo to check if we really invoke cargo/rustc under rustup controls.

It's really strange that the output of rustup toolchain list shows nightly (override), but rustup show and rustc --version still not on nightly. What's the version of rustup you've got?
Really sorry I have no enough knowledge to help you debug rustup. Cargo here is wrapped by a rustup proxy, which  controls the real overridden logic. If you are still stuck in this, I'd recommend to post an issue in rust-lang/rustup.
(Sorry I don't have the permission to transfer issue to there)

I asked on Zulip to get this transferred.  I'm also at a loss as to what could cause this.
Another thing to try is to run rustup which rustc just to double-check which binary it is pointing at.


Ignore command not executed in a slack buffer

Commands query, join, part, leave, topic are not specific to slack.
Using them in an irc context is valid and should not trigger errors
or messages.
Fixes #191 and #137

Thanks for the PR!
This change means that we lose the error message for the commands which are specific to slack, though.  Can you split the functionality so that we keep that for those which are specific to slack, but adds your functionality to query, join, part, etc?

I'm not sure I understand, I only added @slack_buffer_required to the handlers of the commands that are not specific to slack.

No, you also changed the implementation of @slack_buffer_required so that it no longer gives an error message.
This means that if you do /slack upload in a non-slack buffer today, you'd get an error. With your patch, it silently fails.

I ended up redoing this, so closing this PR. Thanks for the inspiration, though. :-)


The release does not have the LOCK enumerated value in the Endpoints enum

Endpoints.LOCK does not exist although it should and is in the gen folder of the repo

I see Endpoints.LOCK right here. Do you mean that an implementation for /api/lock does not exist?

Endpoints.LOCK was added after the release of v0.8.0.

I decompiled the Endpoints.class from v0.8.0 and confirmed that it does not have Enpoints.LOCK
http://pastebin.com/ckuRcWZs

@bolt2strike This is correct. LOCK was added after the release of v0.8.0. That means that LOCK is not available in v0.8.0. This also means that LOCK will be available in the next release.

Ah, sorry I now realize you said after v0.8.0, so this begs the question. When is the next release? I had to compile from source myself so I could use Enpoints.LOCK.

I would like to fix some of the open issues before making a new release. That being said, it will probably be a few days before v0.9.0. Thanks for your interest in JRAW!


Can Beaker Notepad host ECMAScript 6?

I'd really love to use arrow functions, among other things.

agreed it would be great but not at the top of the queue yet.... PRs welcome :)
https://github.com/twosigma/beaker-notebook/issues/1625


spotify isn't being installed.

🧐 Have you read the FAQ and viewed similar issues?

[X] I have read the FAQ
[X] I have checked older issues, open and closed
[X] I did a clean install of SpotX as described in the FAQ

Сountry of your account
India
What is your Spotify Plan?
Free
Do you have Spicetify installed?
No
ℹ Computer information
- Spotify: isn't being installed.
- Windows: 11 Pro.
- PowerShell: 5.1.22621.963

📝 Description

I tried using normal setup, doesn't work.
I tired using spot-x auto.bat and powershell too doesn't work.
I tried installing using normal spotify installer, and that doesn't install either.

attached screenshot of the issue.

📸 Screenshots

Try running this tool even if you don't have an existing spotify installed, then run Spot X again.

Try running this tool even if you don't have an existing spotify installed, then run Spot X again.

same error bruv.

maybe there are characters in your username that the script could not process, try changing your username or just manually download the spotify client and run the spotx installation again


perf: Use jemallocator by default for taso

Also enables thin LTO on release builds.
Tested on barenco_tof_10, 10s timeout, single threaded, on my laptop.
Before / after:

I think defaulting to jemalloc when possible (so, outside windows) is generally better.
Note that this is only used for the taso-optimiser binary target, crate users are free to chose their own allocator.


Can you add the selection of Zephyr version on the GUI

Can you add the selection of Zephyr version on the GUI，For example, the current default installation of Zephyr is the latest version 3.6, but I want to use LTS version 2.7.6, and during development, I also want to switch and verify before these two versions

I dont really know the best way of implementing this. I could add a 2.7.6 template and call west init again after the user has deleted the .west folder.

I dont really know the best way of implementing this. I could add a 2.7.6 template and call west init again after the user has deleted the .west folder.

Allow users to choose the desired zephyr version during the west init phase. and add a button to switch the Zephyr version after the Reset extension button？

You can also refer to the ESP-IDF extension

I added the ability to select a version during west init. So if you want to change the version just run west init and west update again. The change is in v1.0.14.

https://github.com/mylonics/zephyr-ide/assets/169084509/5b1e6e86-03c7-43c5-85c3-d9856ef46a2b
2024-05-14 19:16:00.592 [error] Error: Cannot find module 'js-yaml'
Require stack:

c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\setup_utilities\west_selector.js
c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\setup_utilities\setup.js
c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\utilities\utils.js
c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\extension.js
d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js
d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\bootstrap-amd.js
d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\bootstrap-fork.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1084:15)
at i._resolveFilename (node:electron/js2c/utility_init:2:13405)
at Module._load (node:internal/modules/cjs/loader:929:27)
at c._load (node:electron/js2c/node_init:2:13672)
at v._load (d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:176:5607)
at i._load (d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:173:29719)
at t._load (d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:138:35317)
at Module.require (node:internal/modules/cjs/loader:1150:19)
at Module.require (c:\Users\yangfan.vscode\extensions\nordic-semiconductor.nrf-devicetree-2024.3.78\dist\extension.js:27:42010)
at h (d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:647)
at pickWestYml (c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\setup_utilities\west_selector.js:127:26)
at async MultiStepInput.stepThrough (c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\utilities\multistepQuickPick.js:26:24)
at async collectInputs (c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\setup_utilities\west_selector.js:209:9)
at async westSelector (c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\setup_utilities\west_selector.js:212:19)
at async westInit (c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\setup_utilities\setup.js:529:25)
at async c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\extension.js:119:13
at async r.h (d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:153:189457) zephyr-ide.west-init {"value":"mylonics.zephyr-ide","_lower":"mylonics.zephyr-ide"}
2024-05-14 19:16:01.599 [error] Error: Cannot find module 'js-yaml'
Require stack:
c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\setup_utilities\west_selector.js
c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\setup_utilities\setup.js
c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\utilities\utils.js
c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\extension.js
d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js
d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\bootstrap-amd.js
d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\bootstrap-fork.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1084:15)
at i._resolveFilename (node:electron/js2c/utility_init:2:13405)
at Module._load (node:internal/modules/cjs/loader:929:27)
at c._load (node:electron/js2c/node_init:2:13672)
at v._load (d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:176:5607)
at i._load (d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:173:29719)
at t._load (d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:138:35317)
at Module.require (node:internal/modules/cjs/loader:1150:19)
at Module.require (c:\Users\yangfan.vscode\extensions\nordic-semiconductor.nrf-devicetree-2024.3.78\dist\extension.js:27:42010)
at h (d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:647)
at pickWestYml (c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\setup_utilities\west_selector.js:127:26)
at async MultiStepInput.stepThrough (c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\utilities\multistepQuickPick.js:26:24)
at async collectInputs (c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\setup_utilities\west_selector.js:209:9)
at async westSelector (c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\setup_utilities\west_selector.js:212:19)
at async westInit (c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\setup_utilities\setup.js:529:25)
at async c:\Users\yangfan.vscode\extensions\mylonics.zephyr-ide-1.0.15\out\extension.js:119:13
at async r.h (d:\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:153:189457)

I forgot to package it properly. I have issued a fix on 1.0.17.

I forgot to package it properly. I have issued a fix on 1.0.17.

I forgot to package it properly. I have issued a fix on 1.0.17.

error here still

Ok. I think I have added it correctly now in 1.0.18

Ok. I think I have added it correctly now in 1.0.18. It should be up in a few minutes.

1.0.18，can start,but error here still

Thanks for the issue and testing the code. I will close this issue. If you would like this new feature please make a new issue and include a list of what would be user selectable. Also feel free to make PRs as well.

click west init , select nrf connect config, the error here

I pushed an update just now to remove the
self:
    path:

completely


⚠ ClamAV has degraded performance

In b730648, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 194 ms

Resolved: ClamAV performance has improved in bab6d0a.


sqlfluff: 0.6.0a2 -> 0.6.0

Motivation for this change
Update to latest upstream release 0.6.0
Change log: https://github.com/sqlfluff/sqlfluff/releases/tag/0.6.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 128677 run on x86_64-linux 1

1 package built:

sqlfluff


CLOUDSTACK-9833: Move configuration parameters from Config.java to use configdepot

Following parameters are moved from config.java to configdepot.
This will make the management of configuration parameter easy during upgrade and avoid inconsistency of values of parameters for fresh setup and upgraded setup.
snapshot.max.hourly
snapshot.max.daily
snapshot.max.weekly
snapshot.max.monthly
enable.secure.session.cookie
json.content.type

Code LGTM

Thanks @jayapalu I have also added some content security policy in HTTP servlet response to detect and mitigate certain type of attacks.
Restricted image source, style sheets, java scripts, URLs to be loaded only from self.

Verified the dynamic configuration of the below parameters. LGTM.
snapshot.max.hourly
snapshot.max.daily
snapshot.max.weekly
snapshot.max.monthly
enable.secure.session.cookie
json.content.type

tag:mergeready

@harikrishna-patnala Can you make two separate commits? one for configdepo related changes and the other for security policy in HTTP servlet response

Hi @karuturi , I have updated the PR with two commits. Please review.

@karuturi why was this merged without any regression testing?

I saw the manual testing results, mergeready label and merged. Didn't see missing BVTs. will take care next time

@karuturi okay, I'll kick a round of tests on master branch with #1836 by eod today.


Test coverage for adding context to headers

We already have other tests guaranteeing the formatting of the headers. This just ensures that code path is exercised and the api is called correctly.

@ofrobots PTAL.

LGTM.


fix: duplicate name issue in partial import for queries and jsobjects

Description
When the queries and js objects are imported in the same page, the names were not updated properly which ended up with duplicate names for queries and jsobjects. This PR adds a fix which will append the number in the increasing order to avoid the duplicate entries for the above scenario.
Example - jsObject will be jsObject1
PR fixes following issue(s)
Fixes #30291
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing
How Has This Been Tested?

[ ] Manual
[ ] JUnit

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/build-deploy-preview

/ok-to-test<EMAIL_ADDRESS>

@AnaghHegde Are we in the process of adding JUnit tests in this PR?

I exported JSObjects, Queries, Widgets and datasources. Some points that I noticed in the DP:

When I import it for the first time(on a blank page), it is appending 1 to the name.
a. I expect it to be of the same name, if there is no collision.
b. Only in the case of collision, it should choose to update the name
Say I already had the same jsobject (utils1) on the page, it went on to update the name of imported JSObject to utils3
a. Wonder why 2 was not taken up? 🤔
Lets ensure our renaming strategy is consistent with the product.

/build-deploy-preview

/build-deploy-preview

/ok-to-test<EMAIL_ADDRESS>


Vk texture separation

Separated out GL and Vulkan versions of Material, Textures, RenderData and UniformBlock in the C++ layer. The Renderer now has routines to instantiate these in a device-specific way.
Moved updating bone matrices and view transforms into common code (moving the data to the GPU still device-specific).
Removed GVRPostEffect from Java - GVRShaderData can be used here instead. Also removed other post effect classes that are now meaningless.
GearVRF DCO signed off by: Nola Donato<EMAIL_ADDRESS>and Roshan Chaudhari<EMAIL_ADDRESS>

I think it is highly desirable to break out changes from this branch and create review-able and testable pull requests for the trunk. Things like the removal of the post effect, GVRImage, GVRJavaComponent, all shaders using GVRShaderTemplate, etc.

Should we merge?

AS is getting confused by this addition to Android.mk: $(call import-module, third_party/shaderc). I have no fix for it but after adding explictly the symbols path breakpoints in renderCamera and getInstance are hit. Add to Edit Configuration->Debugger->Symbol Directories this path:
<your path to>/GearVRf/GVRf/Framework/framework/build/intermediates/ndkBuild/debug/obj/local/armeabi-v7a/.

@liaxim Thanks a lot. Its working now.


Multiple workflows being created when the default approver is changed to a non-admin

cc @aldo-expensify
Note: I was unable to reproduce this on staging, I could only reproduce it locally.
Action Performed:

Create a workspace as User A
Invite User B and User C to the workspace
Go to more settings
Turn on workflows
Go to workflows
Turn on Add Approvals
Select the first workflow and change the approver from User A to User B

Expected Result:
There should only be a single workflow with User B as the approver
Actual Result:
There are two workflows. One with User B as the approver and one with User A as the approver.
Screenshots/Videos

Add any screenshot/video evidence
https://github.com/user-attachments/assets/51acef0d-1acc-4eb8-aed4-f2ca272083b4

Daily Update

I created an Auth PR to fix this
I had to create a bedrock PR as well to add some logging params

Next Steps

Get both PRs reviewed and merged

ETA

Finished by tomorrow, Dec 5

Daily Update

The Bedrock PR was merged
The Auth PR is still under review and the tests are passing

Next Steps

@aldo-expensify Review and merge https://github.com/Expensify/Auth/pull/13426

ETA

Monday, Dec 9

Daily Update

The Auth PR is in final stages of review

Next Steps

@aldo-expensify and @youssef-lr review and merge https://github.com/Expensify/Auth/pull/13426

ETA

Today, Dec 9

Daily Update

https://github.com/Expensify/Auth/pull/13426 was merged and deployed to production


Resolve crash when process exits during tls connection

resolves #650.

I've had a discussion with @michalbiesek...  and have agreed to see if I can create a test that fails reliably before the fix is in place...  This was spurred by his inability to recreate a failure when following the QA INSTRUCTIONS without the fix in place.


workspace list view

"To access lineage view, go to the workspace list view."
Where is the workspace list view?  Despite having Admin role on a workspace, and a Pro licence, I cannot find it.  How do I reach it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e43c8665-8c3a-3ece-c2cc-593ade6ce37f
Version Independent ID: 8cffbebb-8e7c-5eae-d9e4-d1789abac390
Content: Data lineage (preview) - Power BI
Content Source: powerbi-docs/service-data-lineage.md
Service: powerbi
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Hi, @gavinsinclair -- it's the view of a workspace that lists the dashboards, reports, etc. Can you see this image? I can't tell if it's going to show:

A minute ago, I couldn't see the List view icon either. Try opening Power BI in a new browser. That worked for me.


Change Text color of selected word

I use high contrast to show the select highlight. I am overriding the selected-text background color in my styles.less to achive that. I am not able to find a way to change the color of the selected text.
See example.

I want to do something like:

Yea that's a tricky one.
So, this package uses the decorations which are applied to a different layer. Inspect the elements and you'll see that the box is under highlights and then the text is within the line.
I'm not sure if it will be possible. A thought I have would be to add text to the decoration and then colour with CSS but again, don't know if it's possible.
I will have a think.

Why is that closed? I am trying to do the same thing and found this closed issue. Is there something I do not see?

I moved on to vscode and closed this issue. 🤷🏻♂

But its still an issue for us who stuck with atom.


Improved logs for deep comparisons in equalities.go

The issue resolved by this Pull Request:
Resolves https://github.com/opendatahub-io/data-science-pipelines-operator/issues/318
Description of your changes:

Improved logs for deep comparisons in equalities.go. With these changes, deep comparison errors will look like:
selector is not equal:
  MatchLabels.map[dspa]: whaaaat? != testdsp0
  MatchLabels.map[app]: weird value != ds-pipeline-testdsp0
  MatchLabels.map[component]: another weird value != data-science-pipelines

Testing instructions

Change any of the expected CRs in https://github.com/opendatahub-io/data-science-pipelines-operator/tree/main/controllers/testdata/declarative and check the failures.
Checklist

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-364
An OCP cluster where you are logged in as cluster admin is required.
To use this image run the following:
cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/364/head
git checkout -b pullrequest b305b52656be5659ba4293eddf4041f648c3da75
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-364"

More instructions here on how to deploy and test a Data Science Pipelines Application.


Release on npm

Hey,
this library looks stunning and the demonstration looks awesome. What a bummer it only has 2 stars.
I think you should really publish this as a package on NPM and make it usable with bundlers and imports etc. This would benefit for the ecosystem and your libraries popularity.

Hello Hirbod!
Good idea, thank you for the advise, i’ll figure out how it works!

Done


Fixing a few grammatical errors

Hi @SwRaw @randyh62 we are in the process of upgrading our documentation. Can you please review #211 and provide your feedbacks against that branch? There are a large amount of changes because we've updated the API and many functionalities.


Can't downcast by self-assignment

TypeScript Version:  nightly (2.2.0-dev.20161220)
Code
function f(x: {}): number {
    x = x as number;
    return x;
}

function g(x: {}): number {
    const y = x as number;
    return y;
}

function h(x: string | number): number {
    x = x as number;
    return x;
}

Expected behavior:
No error.
Actual behavior:
a.ts(3,12): error TS2322: Type '{}' is not assignable to type 'number'.
Funny that it works with union "downcasting", but not for supertype->subtype downcasting.

assignment is not a form of casting. what is going on here is narrowing. and narrowing only works on unions. that is why x: {} was not narrowed to number, where as it was narrowed in x: string | number


🚀 Feature Request: Wrangler should link to the "choose issue type" page on errors

Describe the solution
Currently, when an error occurs, wrangler says:

If you think this is a bug then please create an issue at https://github.com/cloudflare/wrangler2/issues/new.

probably from https://github.com/cloudflare/wrangler2/blob/52c0bf0469635b76d9717b7113c98572de02d196/packages/wrangler/src/index.tsx#L2773-L2784
but that means we don't get the benefits of the issue selector and templates at https://github.com/cloudflare/wrangler2/issues/new/choose. If that type selector is considered mature and stable maybe the code could link to that instead?

Good call! Thanks.


Question: could we store the tilesource(dzi file and images folder) on 3rd party server?

I am trying to use  OpenSeaDragon to show some big images. The idea is to store the dzi file and images served by another server. I am trying to provide the url for tileSource which is "http://localhost: 8001/dzi/xxx.dzi"(this url is good and I can use any browser to download the dzi file manually) instead of the relative path shown in the examples (like 'dzi/xxx.dzi' which means the local server which openseadragon is served and which is on localhost:8080 in my case.
The fetching data quietly failed (no complaints/errors) but only show the buttons and navigator frame, without giving the images itself. It seems I am not able to make the images to display cross domains/servers.
I am very new to the OpenSeadragon, and my question is: how to make the data fetching from different server/place?

Discussed on Gitter, but adding here for posterity: Sounds like you need to set up CORS, but there are techniques to work around that if you'd rather, such as:
https://codepen.io/iangilman/pen/gpejpJ
More discussion here:
https://gitter.im/openseadragon/openseadragon?at=5d93757f47de0a719d440790


Create strings.xml

Turkish language file added.

Task/Issue URL:
Tech Design URL:
CC:
Description:
Turkish language file added.
Steps to test this PR:
1.
1.

Internal references:
Software Engineering Expectations
Technical Design Template

Hi, thanks for this PR. However, we are unable to accept contributions of additional languages at this time as noted in the translations guide https://github.com/duckduckgo/Android/blob/develop/TRANSLATIONS.md
I appreciate the effort you've went to here and while we might translate the app to Turkish in future, it isn't something we're looking to maintain right now.


map::OccupiedEntryRef::key should return &K rather than &Q

returning Q unnecessarily throws away the key type, which may have extra information needed by the user, e.g. the Rc you want to clone.
example where returning K is useful:
struct Interner<T: Eq + Hash> {
    values: HashMap<Rc<T>, ()>,
}

impl<T: Eq + Hash> Interner<T>
where
    Rc<T>: for<'a> From<&'a T>,
{
    fn intern(&mut self, v: &T) -> Rc<T> {
        match self.values.entry_ref(v) {
            EntryRef::Occupied(entry) => Rc::clone(entry.key()), // getting `&Rc<T>` instead of `&T` avoids allocating a new `Rc<T>`
            EntryRef::Vacant(entry) => Rc::clone(entry.insert_entry(()).key())
        }
    }
}

I think this is a good change and would be happy to accept a PR for it (since EntryRef is still unstable).


GNU Radio Companion crashing on Mac

I am using GNU Radio Companion in a class I run, where students are creating a clean Python 3.9 conda environment, and installing the latest stable GNU radio build from this conda channel.
A few of my students are using Macs (I believe mostly older Intel Macs), and all except 1 of them reported that Gnu Radio companion crashes on startup (as a workaround they are using shared Windows PCs, which have no problems). One of them was able to provide the following error message.
Please advise if there is any additional information I can gather to help resolve this issue (I do not have a Mac myself, so this may take some time).

Thanks for the report. I've heard mention of possible crashes on macOS, but this is the best sample size yet. I'm also not a mac user, so I don't have any means to do direct testing.
You say it works for one person. Is there anything notably different about their system? Maybe a particular OS version, or they're the only one that does/doesn't have a high-DPI display?
Another data point the would definitely be helpful, if any of the students are willing, is to see if any other versions work. Try gnuradio 3.8, 3.9, and 3.10, but also older builds within those series (going back in time as much as possible, e.g <IP_ADDRESS>). If they find a version that works, that could help pinpoint a change in the recipe or a dependency that causes this problem.
Similarly, they could try installing GNU Radio via other methods (Homebrew, MacPorts) and see if those crash as well. This is probably less important, because I suspect that they will find that they do not crash and that this is therefore specific to the conda build.

One student managed to install via homebrew, and found that this version did not crash.
I will ask them to install earlier versions of the conda package, and report back.

Correcting my previous statement, all students with Macs found that GNU Radio Companion crashed when installed from conda (at least 5 of them).
Students have used conda to install versions <IP_ADDRESS> and <IP_ADDRESS>, but the crash still occurs.

Thanks David. I think we can assume that it's not GRC itself that is the problem on macOS, but something different about the gtk3 stack on conda-forge results in the crash. Perusing the GTK3 Gitlab repository, it seems like support for macOS with the Quartz backend is something that tends to break because not many developers are using it or testing it, so I suppose this is not surprising.
I will try to do some comparisons with Homebrew to see if they patch anything or use a particular version that makes it work.
I think I'll also plan on doing a build of gnuradio that is compatible with all of the versions of gtk3 available on conda-forge, so that I can ask people to test with the different versions of gtk3 and see if any of the older ones work.

I have uploaded a build for GNU Radio <IP_ADDRESS> on macOS that allows for using different GTK versions. The students can install it with different gtk3 packages using
conda install -c ryanvolz -c conda-forge --no-channel-priority gnuradio=<IP_ADDRESS>.dev0 gtk3=VER

where VER is a gtk3 version from the following list:

3.24.14
3.24.18
3.24.20
3.24.21
3.24.22
3.24.23
3.24.24
3.24.25
3.24.26
3.24.27
3.24.28
3.24.29
3.24.31 (most recent, which we know causes crashes)

Maybe one of those gtk3 versions will allow it to work.
If not gtk3, then maybe different versions of pygobject, or glib would be worth trying.

A patch for cairo was just merged that fixes a known crash on macOS 11.6+. Maybe that accounts for the crashes reported here?

I'm going to assume this was either the GRC cairo issues fixed by https://github.com/gnuradio/gnuradio/pull/6352 or the Python block crashing fixed by https://github.com/gnuradio/gnuradio/issues/6283. Probably the latter?

Thanks for looking into this. Unfortunately I have not been able to get feedback from Mac users to confirm whether or not the issue has been resolved. I will comment on this issue if I get any further information on this issue, but I agree it makes sense to close at this point.


Max recursion limit exceeded when running cut-finder on deep circuits

For circuits with ~5000 non-local gates, such as those that appear in use cases of the QAOA, the default max recursion limit in python (3000) is exceeded. This is understandable because 5000 non-local gates involve around 6*5000 = 30000 recursive calls to the greedy BFS algorithm.
Replace recursive calls to greedy_best_first_search() with a  different data structure, possibly a heapq.

One option would be to rewrite greedy_best_first_search to use a list as a stack.  One existing example of this style is the following three lists that are (mostly) used as stacks introduced before a loop that could instead conceptually be a recursive function:
https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/blob/6db5cbd527adcd9c0973f8269c8b33925d5efa58/circuit_knitting/cutting/qpd/weights.py#L109-L112
However, there is a bit more flexibility because the in this function is actually a tail call.  Python itself does not optimize tail-recursion, but it would be possible to use something like https://github.com/baruchel/tco.  I can't rule out that it might ding performance a bit, though, which wouldn't be very helpful here.

I got excited about using tco for a moment, but I actually think rewriting this as a loop is going to be pretty straightforward, and allows us to refrain from adding a package to our dependency chain.


Sendfile detect mimetype

Try to auto-detect mime-type based on filename.

What do you think about this?
Browsers are complaining if we send eg. css files without the correct content type. This auto-detect is particularly useful if serving static files like this:
@app.route('/webfiles-static/<fn>')
async def images(req, resp, fn):
    await resp.send_file('webfiles-static/{}'.format(fn))

Hey @metachris
Sorry for late reply - got some Christmas related mess last weeks.. ))
I was considering adding this before - the problem was increased footprint, and, as I remember it would work for esp8266, but leaving only feeew of RAM free..
Since it is not widely used I decided not to implement it.
P.S. For the same reason I've omitted adding response status codes like (200 OK, 404 Not Found).

I understand. Didn't know tinyweb code itself already pushes the limit so far :)

the code length memory issue is (thankfully) likely to soon be a thing of the past: https://github.com/micropython/micropython/pull/8191  perhaps we can revisit this then?


docs: update architecture diagram

Maybe this is just be, but I still old the file for some reason.

https://llmariner.ai/images/architecture_diagram.png shows the new one.

The architecture diagram looks great. Thanks for doing that!

I guess Chrome is caching the old version, as my browser displays the most recent one.

Thanks for checking. I see. Maybe it's because of caching in CDN. I'll check later.


chore(dev_requirements): update tblib to v1.3.1

See https://github.com/ionelmc/python-tblib/compare/v1.3.0...v1.3.1

Codecov Report

Merging #1273 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1273   +/-   ##
=======================================
  Coverage   87.26%   87.26%
=======================================
  Files          44       44
  Lines        3887     3887
  Branches      675      675
=======================================
  Hits         3392     3392
  Misses        327      327
  Partials      168      168

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e99f4...2ea44b9. Read the comment docs.


Emulator controls (cursor, touch buttons, external controls) stop responding occasionally

In some cases, input stops working.

When pulling out side menu/opening keyboard, cursor may stop working
On certain actions (depends on the program/game), external controls stop responding. Might also be applicable to touch controls. Not consistent (might be a result of heavy load)

I just wanted to write about it, I hope it gets fixed


Feature/soliddb support

Fix #885 by providing support for the SolidDB database engine

Thanks! Merged! :-)


Expose denoiser and diagnostic aov controls

Add final frame denoiser render controls
Add diagnostic aov (shading overrides) render controls
Add Cache Size setting render control
Reorganize render settings UI (add Postprocessing Panel, add new Lighting Panel to allow    addition of more render engine modes, rename old Lighting Panel to Path Tracer Panel)

Incorporated all suggestions from the review with the latest commit.


Fix enumerated options in "Test Your Understanding"

Changes indent level to properly render as a nested enumerated list of code blocks

Thank you!


[Feature Request] Custom footer for multiple rows

Existing Component
Yes
Component Name
Table
Description
We weren't able to create a custom footer using the Table component
neither the use of custom summary-method nor scope="append" helped.
the problem is that :

it's hard to add multiple rows - summary-method allow only 1 row
using append and custom layout make it hard to respect features such as fixed columns.

Moved to product backlog.

+1


Refactor sub-component stories to use correct style

Refactor the remaining stories we have with sub-components to use "story-style" we agreed upon.
"Story style":

Don't deconstruct sub-component, use it directly in jsx. Example -> <Table.Cell>
Use generic "wrapper" name on positioning components we make in story

Todo:

[ ] Identify remaining stories that does not follow the correct story style
[ ] Refactor stories to correct style

Known stories that needs to be updated:

Table

Nearly all of the sub components were already updated. But the stories had a lot of other issues with inconsistency.
So I added some more tasks to the issue.


Revise the logic of changing the authority in the URL

What is the purpose of the change
According to rfc3986, Revise the logic of changing the authority in the URL
Fix https://github.com/apache/dubbo/issues/5202
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #9170 (d6fd56f) into 3.0 (2841c9d) will decrease coverage by 0.18%.
The diff coverage is 64.70%.

@@             Coverage Diff              @@
##                3.0    #9170      +/-   ##
============================================
- Coverage     64.91%   64.72%   -0.19%
+ Complexity      312      311       -1
============================================
  Files          1177     1177
  Lines         50940    50932       -8
  Branches       7579     7560      -19
============================================
- Hits          33069    32968     -101
- Misses        14275    14365      +90
- Partials       3596     3599       +3

Impacted Files
Coverage Δ

...le/src/main/java/com/alibaba/dubbo/common/URL.java
9.27% <0.00%> (ø)

...ng/zookeeper/curator5/Curator5ZookeeperClient.java
63.28% <66.66%> (-1.94%)
:arrow_down:

...ting/zookeeper/curator/CuratorZookeeperClient.java
69.71% <66.66%> (-1.93%)
:arrow_down:

...mon/src/main/java/org/apache/dubbo/common/URL.java
44.76% <69.23%> (+0.98%)
:arrow_up:

...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java
24.35% <0.00%> (-44.88%)
:arrow_down:

...va/org/apache/dubbo/rpc/support/AccessLogData.java
53.16% <0.00%> (-37.98%)
:arrow_down:

.../remoting/api/SingleProtocolConnectionManager.java
61.53% <0.00%> (-23.08%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
46.15% <0.00%> (-15.39%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

.../apache/dubbo/remoting/transport/AbstractPeer.java
67.39% <0.00%> (-4.35%)
:arrow_down:

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2841c9d...d6fd56f. Read the comment docs.


MinIO pod isn't able to start as it's missing PodSecurityPolicy

By using examples/minio/componentplan.yaml, statefulset controller failed to create pod and get the error below:

We can add an option to add an existing podsecuritypolicy to role/clusterrole, and let the user configure the name of podsecuritypolicy in values.yaml?


failing assertion when doing implicit conversion for ==

def main() -> int:
    x: byte = 'x'
    lol = (x==1)
    return 0

Expected result: no errors, no output
Actual result:
jou: src/types.c:34: create_integer_type: Assertion `0' failed.
Aborted

After #58, this segfaults the compiler instead of failing an assertion.

No longer errors.