performance

Is there any way we can improve the performance when using a Python function for an ODEProblem?
I know that I can use something like:
jul_f = de.eval("""
function f(du,u,p,t)
  x, y, z = u
  sigma, rho, beta = p
  du[1] = sigma * (y - x)
  du[2] = x * (rho - z) - y
  du[3] = x * y - beta * z
end""")

u0 = [1.0,0.0,0.0]
tspan = (0., 100.)
p = [10.0,28.0,2.66]
prob = de.ODEProblem(jul_f, u0, tspan, p)
sol = de.solve(prob,saveat=t,abstol=1e-8,reltol=1e-8)

instead of
def f(du,u,p,t):
    x, y, z = u
    sigma, rho, beta = p
    du[0] = sigma * (y - x)
    du[1] = x * (rho - z) - y
    du[2] = x * y - beta * z

u0 = [1.0,0.0,0.0]
tspan = (0., 100.)
p = [10.0,28.0,2.66]
prob = de.ODEProblem(f, u0, tspan, p)
sol = de.solve(prob,saveat=t,abstol=1e-8,reltol=1e-8)

but I cannot translate my function to Julia code (it is way more complicated than this example and it relies in many Python objects and auxiliary functions).
Maybe what is making the code run slow is that PyCall.jl needs to convert python objects to julia objects and vice versa. So... is there any way I can let Julia or Python know the types of du, u and t.
Thanks! If there is no easy way to hack this it is fine, but I just wanted to know if I could make my code run faster.

If you have a sympy expression, it should be easy to compile a Julia function from it.  Here is an example that is useful for low-dimensional system https://github.com/JuliaDiffEq/diffeqpy/issues/32.  This example also contains a way to "trace" simple Python functions like you quoted using sympy (see if __name__ == "__main__": of #32).

Hi, thanks for your reply!
Yeah, I saw that issue some days ago and it is great for simple examples. However, for more complicated cases it is not. For example, imagine your f function depends on the evaluation at time t of interpolators that are instantiated in Python (such as SciPy's interp1d or interp2d objects). In this case, your jl_lambdify won't work, because you will end with a Julia function that depend on object that does not exist.
On the other hand, if the f expression depend on a functional such as a Derivative I would have to compute it first on Python and then migrate the resulting expression, but if the argument of the Derivative has interpolated data I would have to use a finite difference scheme with a predefined step h.
Lastly and more important, if the f expression depend on an Integral of interpolated data, I won't be able to solve it.
Any thoughts?

If your function calls complex functions in SciPy, wouldn't they be the dominating factor in the performance?
If your problem size is somewhat intermediate so that using sympy does not make sense while Python/Julia interface still is not negligible, maybe you can warp your Python function with something like this (untested):
fjl = Main.eval("f -> (args...) -> pycall(f, Nothing, args...)")(f)

This would eliminate the dynamic conversion of the returned value (which is not used as you are using the in-place version).

I see, thanks for the tip! I will work on that and show you some performance results.
On the other hand, is it necessary (and, in that case, possible) to specify the type of args? I believe that it is not necessary because when f is evaluated from Julia, we already know the arguments types and dynamic conversion is not needed. But I want to be sure.
Thanks!

Yeah, in Julia, argument types are specialized automatically. So, you don't have to do anything for performance. Argument types are specified mainly for dispatching.

Use the new fast_prob = de.jit(prob)


operator gitlab-operator-kubernetes (0.17.2)

Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want to use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description of the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

 Unable to connect to the server: dial tcp: lookup api.ci-op-222m5vds-ab5cb.origin-ci-int-aws.dev.rhcloud.com on <IP_ADDRESS>:53: no such host

/retest

/merge possible

/merge possible


Defeated NPCs should not apply aura effects

Steps:

Add a living creature to the scene.
Add a mummy guardian to the scene.
Move the mummy guardian so that its aura effects the creature.

Note how the Effect: Despair is applied to the creature.

Mark the mummy defeated or reduce its hp to 0.

Note how the  Effect: Despair remains on the creature.

It's not that simple, but we can probably figure out a rough rule to follow (whether it's from a spell effect, etc.).

I'm new to working with Foundry, so sorry if it doesn't make sense in the system but would it be possible to tie it somehow to the Dead condition? like "when the Dead condition is applied disable the aura and check all tokens in the aura radius for effect removal"?

The problem isn't what to tie it to but which auras should continue emitting.


Little fix to do on the README.md

Hi guys,
A letter is missing ;)
minireset.sass instead of minireet.sass
✌

hey @KevinDeAzevedo I can solve this issue can you please assign it to me..


missing step in the docs

Hi.
I struggled building the GainPlugin example.
(I must say I'm quite new to cmake)
After searching, I finally realized that I had to run the "cmake -B" command from the react-juce folder.
I suggest you add that step, maybe in the "Getting started" doc page.

Hey, what is this missing step? I tried to run cmake -B but it didn't work. What is the rest of that command?

Hey @mepc36,
I came across this too – the cmake -B needs to be followed by the name of whichever folder you want to create
I finally got it to demo plugin to run after I ran 'cmake -B {name-of-folder}' followed up by cd-ing into that newly created and running 'make'
There should be a folder in the file tree called "GainPlugin_artefacts", and thats where that standalone version of the plugin lives.
After ALL that, then you can start messing around in the React/JS files & see the changes happen after closing & reopening the created ReactJUCEGainPlugin.app
Hope this helps!


Update message in case search account no result when derive account

Describe the task
Actual:

Expect:

Version test: v1.0.3(162)
Devices test: IP 11
Validation passed.


Heartbeat base_mode reports MAV_MODE_FLAG_HIL_ENABLED

Pixracer
Version: Stable 1.8.1
When the UAV is in Manual mode disarmed, the base_mode field of Heartbeat message is:
"113" or "0111 0001" binary, that indicates that the following flags are true:

MAV_MODE_FLAG_CUSTOM_MODE_ENABLED
MAV_MODE_FLAG_STABILIZE_ENABLED
MAV_MODE_FLAG_HIL_ENABLED
MAV_MODE_FLAG_MANUAL_INPUT_ENABLED

I think it's an error that the HIL flag is enabled, since it's the real autopilot and not some hardware in the loop.

Closing, please re-open if this is still an issue.


Remove unnecessary vertical scrollbar from inside table widget

Description
Remove unnecessary scrollbar from inside table widget
Fixes #2895 #3249
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@vicky-primathon Let's make the scrollbar a virtual scrollbar, which will not take up space in the table itself.

@vicky-primathon

Horizontal scrollbar never shows, it should always show for users with mouse
Vertical scrollbar should show when scrolling
Header scrollbar should also be virtual scrollbar

@vicky-primathon The horizontal scrollbar isn't showing. I'm on Mac, Chrome, external mouse and keyboard.

@vicky-primathon @somangshu When can this PR be closed?

@vicky-primathon @somangshu When can this PR be closed?

@areyabhishek we are now testing the deploy preview and should get merged max by mid next week.

#4006 is created on top of this.

@somangshu @vicky-primathon Can we close this in favour of #4006 then?

Closing in favour of #4006


[kokoro] Fix usage of ERRORLEVEL in Windows script.

is CI-windows-VS2017-debug supposed to be failing ?


apolloStore.writeAndPublish(fragment writes to previously written-to fragment of the same type

I have a Fragment
data class ConversationFragment(
  val __typename: String = "Conversation",
  val id: String,
  val author: Author,
  val read: Boolean
) : GraphqlFragment {

for which I update some property (the value of read) this way:
client.apolloStore.writeAndPublish(
    fragment.copy(
      author = fragment.author.copy(fullName = author.unwrap(fragment.author.fullName)),
      read = read.unwrap(fragment.read),
    ),
    CacheKey.from(fragment.id),
    Operation.EMPTY_VARIABLES
  ).execute()

Then I perform the same thing for a different fragment with another author.
Apollo updates the previously updated fragment's author using the author of the second fragment.
This breaks the same way if I use Apollo 3.1.0
I am currently working around it by replacing nodes in the connection instead.
However, it makes me nervous as I have other situations in the codebase where I use fragment-based cache updates whose values' changing isn't that obvious (this one here changes the value of the author in a list) and I don't know what to expect.
This is the cache configuration, if it helps:
    val cacheFactory = LruNormalizedCacheFactory(EvictionPolicy.NO_EVICTION)
    val cacheKeyResolver = object : CacheKeyResolver() {
      override fun fromFieldArguments(field: ResponseField, variables: Operation.Variables) =
        cacheKey(field.resolveArgument("id", variables) as String?)
      override fun fromFieldRecordSet(field: ResponseField, recordSet: Map<String, Any>) =
        cacheKey(recordSet["id"] as String?)
      private fun cacheKey(value: String?) =
        when (value) {
          null, "" -> CacheKey.NO_KEY
          else     -> CacheKey.from(value)
        }
    }

Hi! Could the issue be that the author's fullName is updated when you write the fragment, but since the cache works by referencing ids, that would also impact any other data referencing that particular author?
So for instance, before writing you had something like:
Author:A -> {id=A, fullName="John"}
Conversation:2 -> {id=2, read=false, author=CacheKey(Author:A)}
Conversation:1 -> {id=1, read=false, author=CacheKey(Author:A)}

and after,
Author:A -> {id=A, fullName="NEW FULL NAME"}
Conversation:2 -> {id=2, read=false, author=CacheKey(Author:A)}
Conversation:1 -> {id=1, read=false, author=CacheKey(Author:A)}

Conversations 1 and 2 are impacted.
Sorry if I completely miss the mark here (I'm a bit new to the cache!) 😅

You are right
I changed
author { fullName }
to
author { id fullName }
and the problem went away!
What confused me is

Why don't all of the fragments get updated and only ones I've previously written to for another reason even though all fragments are present in the cache
Didn't know we needed to include id in objects that we update manually and not automatically

Thanks

Hi 👋  Sorry for the delay there.
We have this optimization to remove QUERY_ROOT from the cache keys to save a few bytes.
Unfortunately, this optimization is not checking for QUERY_ROOT and is also applied to your fragment root key here ("1" and "2"). Meaning that both authors are stored under cache key "author" while it should have been "1.author" and "2.author".
It's working when you're adding "id" in your query because it's using the author id instead of the field path for the cache key. This is certainly what you want to avoid data duplication so I'd recommend you keep "id" in as much as possible in your queries. Nevertheless, for cases where the path must be used as cache key this is a bug.
I'll make a fix for this. I think I'll just remove the optimization altogether and replace QUERY_ROOT with something simpler like $ (TBC).
Thans for bringing this to our attention 🙏


contrib/scripts: Remove false positives from check-go-testdata.sh

The check-go-testdata.sh script would fail on any changes in the whole repo not just the target directory.

/test


Albums from NAS not shown and full log of error messages

What version of Music Assistant has the issue?
2022.12.1
The problem
I do not see any albums in list .. the log is filled with these error messages:
Dec 15 22:24:40 homeassistant e636ad006825[642]: 2022-12-15 22:24:40.016 ERROR (MainThread) [music_assistant.music.file] Error processing /media/vuplususb/mp3/Grateful Dead/71Skulls&Roses-2tr/3Big Railroad Blues.mp3 - no such column: provider_ids
Dec 15 22:24:40 homeassistant e636ad006825[642]: Traceback (most recent call last):
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/music_providers/filesystem/filesystem.py", line 256, in sync_library
Dec 15 22:24:40 homeassistant e636ad006825[642]:     await self.mass.music.tracks.add_db_item(
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/tracks.py", line 221, in add_db_item
Dec 15 22:24:40 homeassistant e636ad006825[642]:     track_artists = await self._get_track_artists(item)
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/tracks.py", line 301, in _get_track_artists
Dec 15 22:24:40 homeassistant e636ad006825[642]:     {await self._get_artist_mapping(x, overwrite) for x in track_artists}
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/tracks.py", line 301, in
Dec 15 22:24:40 homeassistant e636ad006825[642]:     {await self._get_artist_mapping(x, overwrite) for x in track_artists}
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/tracks.py", line 390, in _get_artist_mapping
Dec 15 22:24:40 homeassistant e636ad006825[642]:     if db_artist := await self.mass.music.artists.get_db_item_by_prov_id(
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/base.py", line 349, in get_db_item_by_prov_id
Dec 15 22:24:40 homeassistant e636ad006825[642]:     for item in await self.get_db_items_by_prov_id(
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/base.py", line 385, in get_db_items_by_prov_id
Dec 15 22:24:40 homeassistant e636ad006825[642]:     return await self.get_db_items_by_query(query, limit=limit, offset=offset)
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/base.py", line 325, in get_db_items_by_query
Dec 15 22:24:40 homeassistant e636ad006825[642]:     for db_row in await self.mass.database.get_rows_from_query(
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/database.py", line 90, in get_rows_from_query
Dec 15 22:24:40 homeassistant e636ad006825[642]:     return await self._db.fetch_all(query, params)
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/databases/core.py", line 142, in fetch_all
Dec 15 22:24:40 homeassistant e636ad006825[642]:     return await connection.fetch_all(query, values)
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/databases/core.py", line 250, in fetch_all
Dec 15 22:24:40 homeassistant e636ad006825[642]:     return await self._connection.fetch_all(built_query)
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/databases/backends/sqlite.py", line 98, in fetch_all
Dec 15 22:24:40 homeassistant e636ad006825[642]:     async with self._connection.execute(query_str, args) as cursor:
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/aiosqlite/context.py", line 41, in aenter
Dec 15 22:24:40 homeassistant e636ad006825[642]:     self._obj = await self._coro
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/aiosqlite/core.py", line 184, in execute
Dec 15 22:24:40 homeassistant e636ad006825[642]:     cursor = await self._execute(self._conn.execute, sql, parameters)
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/aiosqlite/core.py", line 129, in _execute
Dec 15 22:24:40 homeassistant e636ad006825[642]:     return await future
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/aiosqlite/core.py", line 102, in run
Dec 15 22:24:40 homeassistant e636ad006825[642]:     result = function()
Dec 15 22:24:40 homeassistant e636ad006825[642]: sqlite3.OperationalError: no such column: provider_ids
How to reproduce
Run HA MA and try to get content of data library
Relevant log output
Dec 15 22:24:40 homeassistant e636ad006825[642]: 2022-12-15 22:24:40.016 ERROR (MainThread) [music_assistant.music.file] Error processing /media/vuplususb/mp3/Grateful Dead/71Skulls&Roses-2tr/3Big Railroad Blues.mp3 - no such column: provider_ids
Dec 15 22:24:40 homeassistant e636ad006825[642]: Traceback (most recent call last):
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/music_providers/filesystem/filesystem.py", line 256, in sync_library
Dec 15 22:24:40 homeassistant e636ad006825[642]:     await self.mass.music.tracks.add_db_item(
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/tracks.py", line 221, in add_db_item
Dec 15 22:24:40 homeassistant e636ad006825[642]:     track_artists = await self._get_track_artists(item)
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/tracks.py", line 301, in _get_track_artists
Dec 15 22:24:40 homeassistant e636ad006825[642]:     {await self._get_artist_mapping(x, overwrite) for x in track_artists}
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/tracks.py", line 301, in
Dec 15 22:24:40 homeassistant e636ad006825[642]:     {await self._get_artist_mapping(x, overwrite) for x in track_artists}
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/tracks.py", line 390, in _get_artist_mapping
Dec 15 22:24:40 homeassistant e636ad006825[642]:     if db_artist := await self.mass.music.artists.get_db_item_by_prov_id(
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/base.py", line 349, in get_db_item_by_prov_id
Dec 15 22:24:40 homeassistant e636ad006825[642]:     for item in await self.get_db_items_by_prov_id(
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/base.py", line 385, in get_db_items_by_prov_id
Dec 15 22:24:40 homeassistant e636ad006825[642]:     return await self.get_db_items_by_query(query, limit=limit, offset=offset)
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/media/base.py", line 325, in get_db_items_by_query
Dec 15 22:24:40 homeassistant e636ad006825[642]:     for db_row in await self.mass.database.get_rows_from_query(
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/music_assistant/controllers/database.py", line 90, in get_rows_from_query
Dec 15 22:24:40 homeassistant e636ad006825[642]:     return await self._db.fetch_all(query, params)
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/databases/core.py", line 142, in fetch_all
Dec 15 22:24:40 homeassistant e636ad006825[642]:     return await connection.fetch_all(query, values)
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/databases/core.py", line 250, in fetch_all
Dec 15 22:24:40 homeassistant e636ad006825[642]:     return await self._connection.fetch_all(built_query)
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/databases/backends/sqlite.py", line 98, in fetch_all
Dec 15 22:24:40 homeassistant e636ad006825[642]:     async with self._connection.execute(query_str, args) as cursor:
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/aiosqlite/context.py", line 41, in aenter
Dec 15 22:24:40 homeassistant e636ad006825[642]:     self._obj = await self._coro
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/aiosqlite/core.py", line 184, in execute
Dec 15 22:24:40 homeassistant e636ad006825[642]:     cursor = await self._execute(self._conn.execute, sql, parameters)
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/aiosqlite/core.py", line 129, in _execute
Dec 15 22:24:40 homeassistant e636ad006825[642]:     return await future
Dec 15 22:24:40 homeassistant e636ad006825[642]:   File "/usr/local/lib/python3.10/site-packages/aiosqlite/core.py", line 102, in run
Dec 15 22:24:40 homeassistant e636ad006825[642]:     result = function()
Dec 15 22:24:40 homeassistant e636ad006825[642]: sqlite3.OperationalError: no such column: provider_ids
Additional information
No response
What version of Home Assistant Core are your running
2022.12.6
What type of installation are you running?
Home Assistant Supervised
On what type of hardware are you running?
Raspberry Pi

Solved by myself... Just deleted .db and restarted the plugin. It is now reading album and showing in menus whatever it foud..

👍👍

Solved by myself... Just deleted music_assistant.db and restarted the plugin. It is now reading album and showing in menus whatever it found..

Well you broke it yourself (by manually editing the manifest file) so good thing you fixed it yourself :-)
Great to hear its fixed now.

Solved by myself... Just deleted music_assistant.db and restarted the plugin. It is now reading album and showing in menus whatever it found..

Well you broke it yourself (by manually editing the manifest file) so good thing you fixed it yourself :-) Great to hear its fixed now.

Exactly as you said .. Many thanks :) ..


bugfix and noise estimate

i didn't mean to open a pull request to h2020charisma yet.
i am sorry for the inconvenience.


Allow passing comparators to flamegraph.sort

I've added a third overload for sort to the type definitions.  This definition allows passing in a comparator function.
You can see an example of this in the existing examples.  While this works fine, the TypeScript definitions only allowed for passing no args or a boolean in.
You will notice this is a simple comparator function, similar to those used by d3 array in its type definitions.  Notice that I've bound the generic variable T here to StackFrame.  I'm not 100% sure that's correct.  If other things besides StackFrames could be passed as arguments to sort, we can modify it or keep it generic.

Thank you @nickgirardo! Good catch! A generic variable would be preferable here I believe. I have a few cases where a modified string is passed.


Workflow Errors not displaying Error Notification on save

Describe the Bug
When you save with invalid workflow / action settings or parameters, the workflow is not saved (working properly), but there is no Azure notification given as feedback currently.  Errors are thrown from within designer but nothing is shown on the Portal side of things.
Steps to Reproduce the Bug or Issue

Make / open a workflow
Give an action invalid parameters
Try to save
It won't save, but it doesn't say anything in response

Workflow JSON
No response
Expected behavior
When you try to save with an invalid workflow, prevent the save but also say what's happening.
Give an error notification saying the save failed and why / where.
Screenshots or Videos

Platform And Browser

OS: Windows
Browser: Chrome / Edge

Additional context
No response
AB#17530776

Issue was solved with this PR. Save button is disabled when connectors have errors in parameters


[es] Unrecognized special rule

See: https://github.com/home-assistant/core/issues/109300

Fixed in 1.1


Cannot run sample app

I am following steps in the repo and getting build error:
/Users/andrey/Projects/react-native-stripe/StripeNative/PaymentViewController.m:11:9: fatal error: 'Stripe/Stripe.h' file not found
import <Stripe/Stripe.h>
    ^

1 error generated.
Please advise.

Hi @AndreyNikiforov so sorry for the slow response. Can you please confirm whether you've followed all of the steps at https://github.com/lrettig/react-native-stripe#installation exactly? Thanks
Let me know if you already worked this out

Let me know if still an issue


Add a dev build

We needed to add the URL to the production site so it could be served, but also needed to overwrite the URL field with localhost when we're local. Thus, Jekyll configs come into play.
This changes the URL to be correct and updates the README to indicate how to utilize it.

Apologies; wrong target repo for this change,


Individual MO residential address displayed to the user

JIRA link
https://companieshouse.atlassian.net/browse/UAR-619
Change description
Individual MO residential address displayed to the user

needs an interceptor config rule too. Please see other PR


How to play Audible, Pandora, SiriusXM, Kindle Books？

Hello @avs_team,
I want to verify third party audio service. How to trigger them?

Hi @wonderjason, you should be able to initiate any of those services with your voice. Just say "Alexa, play Radiohead on Pandora", as an example.


az bicep upgrade ignores --only-show-errors

Describe the bug
az bicep upgrade --only-show-errors shows output other than errors.

Related command
az bicep upgrade --only-show-errors
Errors
None
Issue script & Debug output
az bicep upgrade --only-show-errors
Expected behavior
Should respect --only-show-errors
Environment Summary
2.61.0
Additional context
No response

Thank you for opening this issue, we will look into it.


[FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports

…with "Address already in use"
What is the purpose of the change
Fixed the issue that FlinkKafkaProducerMigrationTest fails with "Address already in use".
Brief change log

flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no

@flinkbot run azure

The build fails because of
[ERROR] src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java:[1] (sizes) FileLength: File length is 3,003 lines (max allowed is 3,000).

The real solution is to split the test but it doesn't make sense for you to do it since you barely touch the test. @dmvk could you please find someone to refactor the test into smaller chunks?
For now, we can just try to get rid of 3 lines to make the test pass.

    @Rule public final TestName testName = new TestName();

Is unused and saves 2 lines. Maybe you can find one more line in your added code...

One more thing: could you please update PR title, PR description, and commit message to reflect that you are actually stabilizing NetUtils#getAvailablePort?

@AHeise These tests seem reasonable on the first look, I don't personally see much of a value in splitting-up the file. We already suppress this check-style rule for different tests [1], so I'd suggest we do the same here.
I'll bring it up as a discussion topic with the team to decide whether we want to follow up on this.
[1] https://github.com/apache/flink/blob/master/tools/maven/suppressions-runtime.xml#L33

@AHeise These tests seem reasonable on the first look, I don't personally see much of a value in splitting-up the file. We already suppress this check-style rule for different tests [1], so I'd suggest we do the same here.
I'll bring it up as a discussion topic with the team to decide whether we want to follow up on this.
[1] https://github.com/apache/flink/blob/master/tools/maven/suppressions-runtime.xml#L33

That's fine by me. I just want to ensure that we are not pushing it onto an external contributor for obvious reasons :)

Hi @AHeise ,
I don't know the file length limit is 3000. To avoid this, before every commit what I should run are spoltless:apply and checkstyle:check. Is there anything else I should run?
If there are more things I need to do, please comment below. Thanks.

Hi @AHeise , I don't know the file length limit is 3000. To avoid this, before every commit what I should run are spoltless:apply and checkstyle:check. Is there anything else I should run?
If there are more things I need to do, please comment below. Thanks.

Please add
	<suppress files="TaskExecutorTest.java" checks="FileLength"/>

to /tools/maven/suppressions-runtime.xml

Btw you also need to rebase onto master, to resolve the conflict in KafkaTestEnvironmentImpl.

@flinkbot run azure

Thank you @fapaul . I will do it.


#17 Added Cocoapods support

#17  Added Cocoapods support by including podfile

Hi! After merging, please create a new tag, 0.3.3 and make pod repo push so it is available, ping me when you are done;)

thx for you contributing!

Remember to do pod repo push and create new tag! :)

@agruchala check this out


Update README.md

add Ukrainian Language

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Hello @West0ne
thank you very much for your contribution, unfortunately your commit does not include the README.uk-UA.md translated file you've linked in the README file.
Please create a the README.uk-UA.md file in the docs folder so I can possibly merge the your Pull Request.
Please also make sure you link the new translated file into the other versions of the README file and make sure you update the package.json version and track your changes in the CHANGELOG file


I somehow get "Failed to paginate projects" just by curling my grafeas Projects

Expected Behavior
listing of projects
Actual Behavior
{
"error": "Failed to paginate projects",
"message": "Failed to paginate projects",
"code": 13,
"details": []
}
Steps to Reproduce the Problem
curling the projects.
Odd is that somehow if I'm curling a specific project the error is gone and i can look up notes of the project. When i want to have the occurrences of given project, the error occurs again.
I'm running grafeas with Pgsql on Kubernetes

just a simple curl to grafeas .../projects

Additional info
I didn't do anything special. Just testing out a bit and creating notes and occurrences in a example project just using curl.
I'm pretty sure it is a DB-Issue, but don't know how to fix this without resetting the DB.

A way around this error is to specify the value for paginationkey in the config.yaml file. For example:
paginationkey: "nhdR6G9RQ3bf5K28Rd5HFq2Qz4RJVuvbqQDLQjs75dA="


Remove default issue & PR titles

I would vote to use labels rather than strings here -- it clutters the names
(but no strong view, feel free to close if ppl disagree)

I like it. It's less likely the title will just be [BUG]:  (because users will be forced to write their own).


Dependency problem which breaks the project

Description
When taking a clean checkout of the repo and doing 'yarn install && ng serve', you get the following error: ERROR in Cannot read property 'getSymbolByModule' of undefined.
What's included?
This can be fixed by upgrading the @angular/compiler-cli to 4.0.2 which is done in the yarn.lock and package.json file.

Updated :)

Thanks for the PR!

My pleasure. Thx to you guys for open sourcing this! It makes angular material usable at this moment.


Update manga link

Fix cubari.moe link so it directly references the git path rather than using now broken git.io link

Ah, sorry, I saw the issue and already did exactly this, should've checked first, my bad.
Thanks anyway though!


Lack of clarity in step 5 of flutter_firebase codelab

In 'Configure Firebase for iOS', step 5 I can read
'Firebase generates an Info.plist file that contains configuration details for iOS apps to connect to the Firebase service you created.'
but, for what I have seen, Firebase does not generate a file Info.plist, only a file GoogleService-Info.plist and this file should be downloaded and placed into the directory.
What am I expected to do, rename the file after downloading? If not, where do I get the Info.plist from?

Sorry, step 5 of what? Can you link to where you are seeing this?

I apologize for not adding all the references.
The URL is
https://codelabs.developers.google.com/codelabs/flutter-firebase/#4
5. Set up Firebase integration > Configure Firebase for iOS >
"Firebase generates an Info.plist file that contains configuration details for iOS apps to connect to the Firebase service you created. Download this file to your development machine. (You do not need to complete the other steps in the wizard.)"

Looks like the file name may have changed; I also see GoogleService-Info.plist , cc @mjohnsullivan

@gmalagutti is it working correctly if you ignore the incorrectly stated filename?

If I copy the downloaded file beside the one distributed in the codelab I still get an error of type 'The default Firebase app has not yet been configured. Add...'
I edited the standard Info.plist to add the portion of xml to activate the google sign-in, but that has not addressed the issue. The app does not start on my Mac - I am using Android Studio based on IntelliJ.

I'm having the same issue

The full error I'm seeing is:
4.10.1 - [Firebase/Core][I-COR000003] The default Firebase app has not yet been configured. Add `[FIRApp configure];` (`FirebaseApp.configure()` in Swift) to your application initialization. Read more: https://goo.gl/ctyzm8.

@smkhalsa As far as I know this is not an error message, merely an hint that you are not using the new feature described in the line contained in the message.
The feature is explained in the Firebase docs.

@zoechi Yes, you are correct. It's now working for me. It wasn't displaying the data before, and I assumed it was because of this, but it turns out it was another issue.

Although I failed to get it to work following the instructions, the other steps of the tutorial, downloaded inside the sam zip do work, so I was able to move on

I have the same message about Firebase not configured that @smkhalsa quoted, even with the repo friendlychat-steps used by the tutorial. Is a false positive or not?

This codelab has been obsoleted and replaced (at the same URL) with an entirely new codelab.
Closing.


Some froala options not visible within 2 bootstrap modals

When using bootstrap 3 modal it seems to stop working when opening a modal on top of a other modal.
Tested on MacOs with latest safari and latest chrome versions.
The following don't seem to work. color, table, hyperlink. However headers seem to be working fine
It works fine within a single modal. Example:

The problem is a inline styling being set when the option toolbarInline is set to true, It sets a z-index 5 with inline styling. this also makes it impossible to override our selves !

@RHinderiks when using the bootstrap modal, please make sure you set the editor zIndex option to a higher value. There is a demo here: https://github.com/froala/wysiwyg-editor/blob/master/html/3rd-party/bootstrap/modal.html.


Add descriptions for properties.

This PR adds descriptions for @propertyfields. Most are quite dull as I used a regex to create them from the name.

I don't see why this test fails:
Chrome Headless 88.0.4298.0 (Linux x86_64) ol.TileQueue #loadMoreTiles() works when tile queues share tiles FAILED
	Error: Uncaught Error: expected 5 to equal 0 (/home/runner/work/openlayers/openlayers/node_modules/expect.js/index.js:102)
Chrome Headless 88.0.4298.0 (Linux x86_64) ol.TileQueue #loadMoreTiles() works when tile queues share tiles FAILED
	Error: Uncaught Error: expected 5 to equal 0 (/home/runner/work/openlayers/openlayers/node_modules/expect.js/index.js:102)

Seems like a weird racing condition.

That happens occasionally. I have restarted the tests.

Thanks, @simonseyock.


docs: update README

Codecov Report
Patch and project coverage have no change.

Comparison is base (77104b0) 100.00% compared to head (e8f3b24) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           38        38
  Branches         8         8
=========================================
  Hits            38        38

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


module 'fmoe_cuda' has no attribute 'ensure_nccl'

fmoe_cuda.ensure_nccl
module 'fmoe_cuda' has no attribute 'ensure_nccl'

I don't think this can happen with current version of FastMoE. Please provide more details, e.g. your version of FastMoE and a detailed call stack, so that we can look into this issue.

hi, i also meet the problem, it's because building without USE_NCCL=1. however, when i add it and rebuild, some error like "error: ‘c10d’ has not been declared“ happend, i found c10d in torch/lib and it's linked when building, how can i sovle this problem

@jinggaizi again, please provide us with your version of FastMoE and PyTorch.

sorry, it's my fault, i built fmoe in https://github.com/tencent-ailab/3m-asr/tree/main/fastmoe, it's version 0.1.2 and made some modifications, when in build v1.0.0, it's work, i will check the different by 3m-asr


[ValueCard] Enhancements for card

What package is this for?

[x] React
[ ] Angular

Summary
We need the ValueCard component to support:

Link under text
Icon next to the main text
If possible extra section depending on card size

Specific timeline issues / requests
Do you want this work within a specific time period? Yes, we need this before end of May.
Is it related to an upcoming release? Yes, MAS Core 8.8
Available extra resources
What resources do you have to assist this effort? Yes, I can work on it.

@cgirani I think it should be pretty easy to perhaps leverage the existing trend text prop to achieve the links. For the combination of value card and list card in the bottom example, I think this is a perfect example of the need to have these different card types as composable pieces. If we had a value component, we could compose it easily with a custom card with a list component.

@cgirani  This seems like a trivial list variation which makes me wonder if design should be validating the need for the change to existing list. @dianatran18 Do you have any input on this?

Hey @davidicus what is shown in the original screenshot aligns with the read-only value we have, which is a label + value pairing. We've seen teams with various padding and alignment, so we created this component documentation to create that consistency.
If we can create that as a standalone component that can be used inside varying components and use cases, then that would be great. The contribution issue we opened for that is #3124

@davidicus/ @dianatran18 thanks guys for the response. I can work on the component for issue #3124 any specific name we want for that component?

ReadOnlyValue would match the design site. I am ok with that I suppose.


nixos: kubernetes fixes

Fix reference CNI plugins

The plugins were split out of the upstream cni repo around version
0.6.0

Fix RBAC and DNS tests

Fix broken apiVersion fields
Change plugin linking to look in ${package}/bin rather than
${package.plugins}

Initial work towards a working e2e test

Test still fails, but at least the expression evaluates now

Continues @srhb's work in #37199
Fixes #37199
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg test kubernetes.dns kubernetes.rbac

Success on x86_64-linux (full log)
Attempted: tests.kubernetes.dns, tests.kubernetes.rbac
No log is available.

Success on aarch64-linux (full log)
Attempted: tests.kubernetes.dns, tests.kubernetes.rbac
No log is available.

@grahamc Any idea why OfBorg is reporting success, while the logs show a 404 served up by nginx?

...yikes... this is ugly!

The problem is these evaluate to nothing:
[nix-shell:~/projects/nixpkgs]$ HOME=/homeless-shelter NIX_PATH=nixpkgs=$(pwd) nix-instantiate ./nixos/release.nix -A tests.kubernetes.rbac --option restrict-eval true --option build-timeout 1800 --arg supportedSystem '["x86_64-linux"]' --show-trace

[nix-shell:~/projects/nixpkgs]$ HOME=/homeless-shelter NIX_PATH=nixpkgs=$(pwd) nix-instantiate ./nixos/release.nix -A tests.kubernetes.dns --option restrict-eval true --option build-timeout 1800 --arg supportedSystem '["x86_64-linux"]' --show-trace

so evaluation "Succeeds" but then there is nothing to do. I'll write a test and fix this!

@GrahamcOfBorg test kubernetes.dns.multinode kubernetes.dns.singlenode kubernetes.rbac.multinode kubernetes.rbac.singlenode

Failure on x86_64-linux (full log)
Partial log (click to expand)
Merge failed

Failure on aarch64-linux (full log)
Partial log (click to expand)
Merge failed

@GrahamcOfBorg test kubernetes.dns.multinode kubernetes.dns.singlenode kubernetes.rbac.multinode kubernetes.rbac.singlenode

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: tests.kubernetes.dns.multinode, tests.kubernetes.dns.singlenode, tests.kubernetes.rbac.multinode, tests.kubernetes.rbac.singlenode
Partial log (click to expand)

Cannot nix-instantiate `tests.kubernetes.dns.singlenode' because:
error: undefined variable 'callSubTestsOnTheseSystems' at /var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/nixos/release.nix:299:26

Cannot nix-instantiate `tests.kubernetes.rbac.multinode' because:
error: undefined variable 'callSubTestsOnTheseSystems' at /var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/nixos/release.nix:302:27

Cannot nix-instantiate `tests.kubernetes.rbac.singlenode' because:
error: undefined variable 'callSubTestsOnTheseSystems' at /var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/nixos/release.nix:302:27

No attempt on x86_64-linux (full log)
The following builds were skipped because they don't evaluate on x86_64-linux: tests.kubernetes.dns.multinode, tests.kubernetes.dns.singlenode, tests.kubernetes.rbac.multinode, tests.kubernetes.rbac.singlenode
Partial log (click to expand)

Cannot nix-instantiate `tests.kubernetes.dns.singlenode' because:
error: undefined variable 'callSubTestsOnTheseSystems' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/nixos/release.nix:299:26

Cannot nix-instantiate `tests.kubernetes.rbac.multinode' because:
error: undefined variable 'callSubTestsOnTheseSystems' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/nixos/release.nix:302:27

Cannot nix-instantiate `tests.kubernetes.rbac.singlenode' because:
error: undefined variable 'callSubTestsOnTheseSystems' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/nixos/release.nix:302:27

@GrahamcOfBorg test kubernetes.dns.multinode kubernetes.dns.singlenode kubernetes.rbac.multinode kubernetes.rbac.singlenode

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: tests.kubernetes.dns.multinode, tests.kubernetes.dns.singlenode, tests.kubernetes.rbac.multinode, tests.kubernetes.rbac.singlenode
Partial log (click to expand)

Cannot nix-instantiate `tests.kubernetes.dns.singlenode' because:
error: attribute 'singlenode' in selection path 'tests.kubernetes.dns.singlenode' not found

Cannot nix-instantiate `tests.kubernetes.rbac.multinode' because:
error: attribute 'multinode' in selection path 'tests.kubernetes.rbac.multinode' not found

Cannot nix-instantiate `tests.kubernetes.rbac.singlenode' because:
error: attribute 'singlenode' in selection path 'tests.kubernetes.rbac.singlenode' not found

Failure on x86_64-linux (full log)
Attempted: tests.kubernetes.dns.multinode, tests.kubernetes.dns.singlenode, tests.kubernetes.rbac.multinode, tests.kubernetes.rbac.singlenode
Partial log (click to expand)
cannot build derivation '/nix/store/pkm7dq6b6qnsb8k46iywxqsjs7xcidgp-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/aawf1ly7j262rrlrxidrwvxh0p9mj283-nixos-test-driver-kubernetes-dns-multinode.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/jx3kc668x3ydr120k48c4w3d46yj09sx-nixos-test-driver-kubernetes-dns-singlenode.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wgv64py0y1rwclvv0jg3qcyfkbbyfsc2-nixos-test-driver-kubernetes-rbac-multinode.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/wj6qhqrqxy20lbbgfw2pcrdxdwjs61l3-nixos-test-driver-kubernetes-rbac-singlenode.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/dc8zhjfjqylhmhqwkm7klnq5dhq33nzr-vm-test-run-kubernetes-dns-multinode.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9k0ckg7fchcp0lscja73lamrpnprqr4m-vm-test-run-kubernetes-dns-singlenode.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ykzh4p0ax100cm4clx77w563jzcsfq0r-vm-test-run-kubernetes-rbac-multinode.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kdbwqf3ynzlbrb6vqc9h39sywii6cbaz-vm-test-run-kubernetes-rbac-singlenode.drv': 1 dependencies couldn't be built
error: build of '/nix/store/9k0ckg7fchcp0lscja73lamrpnprqr4m-vm-test-run-kubernetes-dns-singlenode.drv', '/nix/store/dc8zhjfjqylhmhqwkm7klnq5dhq33nzr-vm-test-run-kubernetes-dns-multinode.drv', '/nix/store/kdbwqf3ynzlbrb6vqc9h39sywii6cbaz-vm-test-run-kubernetes-rbac-singlenode.drv', '/nix/store/ykzh4p0ax100cm4clx77w563jzcsfq0r-vm-test-run-kubernetes-rbac-multinode.drv' failed

@grahamc Do you know why OfBorg is failing here?

qemu-system-x86_64: failed to initialize KVM: Permission denied

Ooops, I am stupid, sorry.
I granted /dev/kvm to ofborg instead of nixbld


Inconsistent use of manageHoverState

I spent a bit of time puzzling through how popups were triggered when hovering on a line layer, but my opacity wasn't changing:
          <LineLayer
            paint={{
              "line-width": 5,
              "line-color": "red",
              "line-opacity": hoverStateFilter(1.0, 0.5),
            }}
          >
            <Popup openOn="hover" let:features>
              ...
            </Popup>
          </LineLayer>

I needed to pass manageHoverState. FillLayer and others don't override this, or even let it be set, AFAICT.
https://github.com/dimfeld/svelte-maplibre/blob/ad6bb3eafaccfa53ca13e3e099c8743383da9f7b/src/lib/LineLayer.svelte#L26
https://github.com/dimfeld/svelte-maplibre/blob/ad6bb3eafaccfa53ca13e3e099c8743383da9f7b/src/lib/Layer.svelte#L32
Any reason for line layer to disable it by default? For consistency, what if all the layers did export let manageHoverState = false; to let it be overridable? Happy to send a PR if that's the desired behavior.

And thanks by the way for this library! I've been using MapLibre and Svelte for a few months in different projects, and by far this library is looking extremely promising for simplifying some of them. I'll open a few other issues, and I'm happy to send PRs.

IIRC it was to improve the behavior when you have both a LineLayer and a FillLayer for the same GeoJSON polygons, since otherwise they start to conflict as they are both trying to manage the same polygons. But I agree the current implementation feels inconsistent and is definitely not helpful for other uses of LineLayer.
Allowing any layer to override manageHoverState and defaulting to false feels like the right change here.


Support add username, password to repo in HelmChart

What would you like to be added:
Support add username, password to repo in HelmChart
Why is this needed:
apiVersion: apps.clusternet.io/v1alpha1
kind: HelmChart
metadata:
  name: example
  namespace: default
spec:
  repo: https://private-repo.com/test
  username: xxx
  password: xxx
  chart: example
  version: 0.0.1
  targetNamespace: abc

/assign @silenceper
I can contribute this feature.

apiVersion: apps.clusternet.io/v1alpha1
kind: HelmChart
metadata:
  name: example
  namespace: default
spec:
  repo: https://private-repo.com/test
  username: xxx
  password: xxx
  chart: example
  version: 0.0.1
  targetNamespace: abc

@silenceper This is not secure. The credentials here are visible to anyone with get/list roles of HelmChart.

I agree.
maybe can chagne to this:
apiVersion: apps.clusternet.io/v1alpha1
kind: HelmChart
metadata:
  name: example
  namespace: default
spec:
  repo: https://private-repo.com/test
  authSecretName: my-private-repo-auth
  authSecretNamespace: kube-system
  chart: example
  version: 0.0.1
  targetNamespace: abc

apiVersion: v1
data:
  username: xxx
  password: xxxx
kind: Secret
metadata:
  name: my-private-repo-auth
  namespace: kube-system

Another thing you need to take into consideration is if the sync mode is Pull, how to pass down those credentials.

Another thing you need to take into consideration is how to pass down those credentials when the sync mode is Pull.

My idea is to add get secret permission for serviceAccount when CRR approve.
The namespace of this secret can be configured in the hub like --helm-repo-secret-namespace, and all secrets involving the helm chart repo are placed under this namespace.
apiVersion: apps.clusternet.io/v1alpha1
kind: HelmChart
metadata:
  name: example
  namespace: default
spec:
  repo: https://private-repo.com/test
  authSecretName: my-private-repo-auth # Under the `--helm-repo-secret-namespace` namespace
  chart: example
  version: 0.0.1
  targetNamespace: abc

As discussed, we could refer ImagePullSecrets in kubelet.


[INLONG-8443][Manager] Add ClickHouse field type mapping strategy to improve usability

[INLONG-8443][Manager] Add ClickHouse field type mapping strategy to improve usability

Fixes #8443

Motivation
Inlong ClickHouse ExtractNode or LoadNode currently does not support some special field types, add ClickHouse field type mapping strategy to mapping to the corresponding type to run correctly

@chestnut-c We lost supporting of nullable type(For example Nullable(Int8)).

@chestnut-c We lost supporting of nullable type(For example Nullable(Int8)).

The next PR will add CK's nullable modifier


Change volume during idle/play

Sorry for my confusing first pull request. I'm starting to learn how to use GitHub.
My son often presses the volume buttons while the Phoniebox is not playing any file. After starting a new file the box is often very load.
To prevent this. I created a new File “Change_Volume_Idle”.
There you can select between following options:
TRUE=Change Volume during all Time (Default)
FALSE=Change Volume only during "Play"
OnlyDown=It is possible to decrease Volume during Idle
OnlyUp=It is possible to increase Volume during Idle
Please Test it – This is my first commit on Github and I hope I have done everything wright. Also I hope my commit does not affect other change that happened in the meantime.

Hi @MiczFlor,
Is anything wrong with my pull-request? Do you want me to change anything?
If you don't like this feature I will close my request.

Hi @Franzformator
simply didn't find the time to test it :)
It's a great addition.
Adding it to develop now, please test it and possibly find another person, to test it, too.
Sorry for the lack of appreciation. I am happy to receive your thought and code!
All the best, micz


Not working: Failed to execute 'observe' on 'MutationObserver'

Didn't use the script for a week, during that time the YouTube interface did change.
I saw that a new version of the plugin was issued, but today I noticed that the script do not hide the watched videos.
I got this error from the Chrome console.
Error running script: YouTube: Hide Watched Videos
TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.
Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.

Hmm. Not sure why that error would come up. In any case -- I pushed some updates in 2.3 that might help resolve the problem. Try again now.

The error do not appear anymore, but the watched videos are still not hidden. No any errors in the logs.
I noticed some strange behavior of the button on the top bar.
When you hover over it, it disappears while the mouse is over it instead to highlight or pop-up or something else. Also, when you click on it it disappears again, but it will appear only if you click somewhere else on the page. The state is switched between hide and show but with no effect.
Not sure how I can debug this further.

What version of Chrome are you using?

Fixed in 2.4


Support live applying nested packages

Describe your problem
I have a directory setup representing my entire cluster like:
Kptfile
|__ grafana
      |__ Kptfile
|__ prometheus
      |__ Kptfile
... many more packages, many namespaces, etc ...

I want to apply all of these to the cluster. Currently, the best way to do that seems to be:
find . -maxdepth 1 -mindepth 1 -type d | xargs -I{} kpt live apply --inventory-policy=adopt {} --output table
This has a few issues:

Not super easy, especially compared to simple kpt live apply
Now we wait for each subpackage linearly, instead of doing everything at once

It would be great to be able to just pass my entire desired cluster state, consisting of many namespaces, object inventories, etc to kpt live apply at once and let it figure out the right way to apply and wait for completion

@seans3 PTAL


Mapview goes to white if view is tilted, scaled or both with high resolution devices

Please note: issues related to or caused by osmbonuspack will be closed with a
suggestion to open an issue at https://github.com/MKergall/osmbonuspack
(feel free to delete whatever doesn't apply)
Issue Type
[ ] Question
[x ] Bug
[ ] Improvement
[ ] Build system related
[ ] Performance
[ ] Documentation
Mapview is goes to white when it's tilted and scaled. Error can be reproduce example with Honor 8 (Android 7.0) devices and OnePlus 5 with lates Android release.
Environment
If it's a bug, version(s) of android this affects:
At least 6.0, 7.0 and 8.0 Android version affected
Version of osmdroid the issue relates to:

that's strange to say the least. what version of osmdroid?


SAKIII-4292 - Inconsistent display of World assets in My Library

https://jira.sakaiproject.org/browse/SAKIII-4292

Merged via squash picking the first commit


fix: grab values from open_channel message using stash

To add more content on this, @Psycho-Pirate and I are working on a ldk integration when the node specifies different messages, so we need a way to get from the stash the information that the node sends to us.
The change added in this PR make lnprototest tests cross-compatible between different implementations


question.

I will only ask one question.
Did you use blackbone "mapdriver.sys"?

no, I'm not using any driver

The foundation of your program is https://github.com/jussihi/PUBG-map-hack
But do not you use "kerneldriver", "USERMODEAPP"?

Yes,  I use a edited usermodeapp, that doesn't need kerneldriver.

I know what I'm worried about.
I do not disclose it to anyone.
If you do not mind, would you give me a chance to try it?
I know this is not easy to ask.
God bless you.

Sorry , no.

Yes I do. Thanks for the answer.
Good luck.


monitoring: add PostgreSQL datasource for pg12 in Grafana

Create a grafana certificate and use it to connect to the metrics database on the pg12 server.  Had to repeat the same init container workaround for https://github.com/kubernetes/kubernetes/issues/57923 as used in #63.
Still working on the database setup and it will be documented in apps/database/README.md (or automated) later.  For now, using:
-- base privileges
\c postgres
revoke connect on database postgres from PUBLIC;

-- metrics database privileges
create database metrics owner postgres;
\c metrics
revoke connect on database postgres from PUBLIC;
revoke create on schema public from PUBLIC;

create role metrics_readonly with password null nologin inherit;
grant connect on database metrics to metrics_readonly;

create role grafana password null login inherit;
grant metrics_readonly to grafana;
commit;

bors r+


Rewritev2/typescript

This pull request is related to #7

W mans

@dependabot

Not biased at all, but everything seems to check out properly. Though you need to tell users how to make a DB in the README.md

Yeah you're right, will update the readme asap


Update IP Address for Application Insights Ingestion

Added UK West.

@anubhavkale : Thanks for your contribution! The author(s) have been notified to review your proposed change.

While there were no merge conflicts between this and the public repo, there was going to be a merge conflict at 3PM when the repos synced so I incorporated this change into a PR against the private repo. That PR is merged internally and will go-live between 3-4 PM.

#please-close


mod_source not modifying correctly

In C, this:
struct event a = amy_default_event();
a.osc = 1;
a.wave = SINE;
a.freq_coefs[COEF_CONST] = .25;
a.amp_coefs[COEF_CONST] = 1;
amy_add_event(a);

struct event e = amy_default_event();
e.osc = 0;
e.wave = PULSE;
e.freq_coefs[COEF_CONST] = 440;
e.mod_source = 1;
e.duty_coefs[COEF_MOD] = 1;
e.velocity = 1;
amy_add_event(e);

Should make a 0.25Hz duty cycle LFO on a 440Hz pulse wave. But it plays a constant pulse wave instead.
Written in Python, it "just works":
amy.reset()
amy.send(osc=1,wave=amy.SINE,freq=0.25,amp=1)
amy.send(osc=0,wave=amy.PULSE,mod_source=1, freq=440, duty="0,0,0,0,0,1",vel=1)

Something is up with how we fill in X_coefs in Python that makes assumptions we're not getting in C, I think

A clue: explicitly setting x_coefs to 0 makes it equivalent:
struct event a = amy_default_event();
  a.osc = 1;
  a.wave = SINE;
  a.freq_coefs[0] = 0.25;
  a.freq_coefs[1] = 0;
  a.freq_coefs[2] = 0;
  a.freq_coefs[3] = 0;
  a.freq_coefs[4] = 0;
  a.freq_coefs[5] = 0;
  a.freq_coefs[6] = 0;

  a.amp_coefs[0] = 1;
  a.amp_coefs[1] = 0;
  a.amp_coefs[2] = 0;
  a.amp_coefs[3] = 0;
  a.amp_coefs[4] = 0;
  a.amp_coefs[5] = 0;
  a.amp_coefs[6] = 0;

  amy_add_event(a);

  struct event e = amy_default_event();
  e.osc = 0;
  e.wave = PULSE;
  e.freq_coefs[0] = 440;
  e.freq_coefs[1] = 0;
  e.freq_coefs[2] = 0;
  e.freq_coefs[3] = 0;
  e.freq_coefs[4] = 0;
  e.freq_coefs[5] = 0;
  e.freq_coefs[6] = 0;

  e.mod_source = 1;

  e.duty_coefs[0] = 0;
  e.duty_coefs[1] = 0;
  e.duty_coefs[2] = 0;
  e.duty_coefs[3] = 0;
  e.duty_coefs[4] = 0;
  e.duty_coefs[5] = 1;
  e.duty_coefs[6] = 0;
  e.velocity = 1;
  amy_add_event(e);

But I'm not sure why.

(Unfortunately just making that fix, i.e. setting every coef to 0 on amy_default_event(), causes the AMY event queue to overload during make test. This is because it's creating an AMY delta for 7*5 = 35 parameters per event, even if that CtrlCoef isn't being used. The reason the Python parser doesn't do this is we only set the parameters to 0 when you set a single CtrlCoef. I think it may be a better use of our time to seamlessly handle UNSET CtrlCoefs when they are evaluated.

In order to have sane default behavior, the various ControlCoef vectors are initialized with some nonzero values: See the setup in reset_osc() around line 581 of amy.c (also described briefly in the paragraph beginning "Actually" in README.md).
Specifically, amp_coefs is initialized to {0, 0, 1, 1, 0, 0, 0} (COEF_VEL and COEF_EG0, so the amplitude follows the note-on velocity modulated by envelope generator 0), and logfreq_coefs is initialized to {0, 1, 0, 0, 0, 0, 1} (COEF_NOTE and COEF_BEND, so the oscillator frequency follows the note-on pitch and the global pitch bend).  In addition the COEF_CONST fields of duty_coefs and pan_coefs are 0.5, since these are the default, central, values.
If you're setting the _coefs vectors by hand and you don't want the defaults, you'll have to clear these values to zero, but that's normally not a problem.  The most common exception is an LFO, which you typically don't want to depend on the note velocity (since you want it to free-run without a note-on event).  I think that's why the original code doesn't achieve any LFO modulation.  All it needs is a.amp_coefs[COEF_VEL] = 0 added when setting up osc 1.  The other coefs being set to zero in the fixed code above are redundant with reset_osc() defaults.
Of course, another common gotcha with direct manipulation of oscs from C is not resetting the osc, and so inheriting possibly non-default settings from the previous use of the osc.  It's probably good practice to call amy_reset_oscs() or send e.reset_osc = osc events before setting up oscs.  This appears is several forms in src/examples.c.

In general, I'm OK with the Python interface having semi-magical behavior ("Oh look! Setting amp=4 automatically clears the COEF_VEL parameter"), but having the C-interface be much more explicit and literal ("I really just wanted to set amp_coefs[COEF_CONST] to 4 without changing the value of amp_coefs[COEF_VEL]").

But sending any message with a CtrlCoef via Python or an AMY wire string will set the coefs to 0, not the defaults you specified. Is this a bug?
void parse_coef_message(char *message, float *coefs) {
    int num_coefs = parse_float_list_message(message, coefs, NUM_COMBO_COEFS);
    // Clear the unspecified coefs to zero.
    for (int i = num_coefs; i < NUM_COMBO_COEFS; ++i)
        coefs[i] = 0;
}

Of course, another common gotcha with direct manipulation of oscs from C is not resetting the osc,

I don't see any difference here C vs Python -- we're not directly manipulating the oscillators (we're not changing synth[osc], we're doing precisely what you'd do in Python/wire messages, creating an struct event which is parsed by amy_add_event and turned into deltas. There's no special reason to call for a reset in C that you wouldn't also want in Python.

I agree. Resetting Amy is important in both Python and C.

But sending any message with a CtrlCoef via Python or an AMY wire string will set the unspecified coefs to 0, not the defaults you specified. Is this a bug? This is the behavior I'm attempting to ape in #166 . If that's wrong, we should fix it here too.

It's intended behavior because the "magic" clearing of defaults is (sometimes) beneficial: if you're manually setting the CONST coefficient of a control vector via Python, you may well be doing some interactive exploration and you just want that value to take on an unmodulated constant value. I don't want to force you to type "freq=440,0,0,0,0,0,0" every time.
The "interactive investigation" scenario doesn't really apply to the C API.
One thing I haven't yet raised is the treatment of bare commas in coef strings (e.g. amp=",,,,,1"). In float lists, they result in the missing value being treated as zero, but in int lists (only algo_source) they result in UNSET (or some other passed-in special value). We could make bare commas mean UNSET for float lists too, and remove the implicit trailing zeros, so you could pick out individual values to set via the wire interface too. That might be the best solution.

The specific problem of mod_osc's being silenced because of the default dependence of amplitude on note velocity is fixed by e9f5fc82cc70914b2c882eb48f74c4ad28a06411 which clears the amplitude-velocity link for the special case of oscillators designated modulators.
The larger problem of inconsistency between the Python API (ControlCoefficients set as entire vectors at once) and the C API (elements in ControlCoefficients set individually) remains to be resolved, the WIP is in branch pythons_coef_unset.

The inconsistency between C API setting individual coefficients, and Python API setting whole vectors at once, was resolved in #172 by making the Python API also set individual coefficients.


android_alarm_manager_plus example update for supporting "null safety"

Changes have been done to support null safety.
Tested in  Flutter (Channel stable, 2.8.1, on Microsoft Windows [Version 10.0.19042.630], locale en-IN)
Description
*Current example is throwing error in latest Flutter. So I have converted this example for supporting null safety. There is no functionality change. Tested on Flutter 2.8.1 on windows and it worked as expected. *
Related Issues
NA
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

[x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[ ] I updated the version in pubspec.yaml and CHANGELOG.md.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Thanks for your contribution. Please resolve analyzer issues, which were reported by the CI.

@manishkumar-dsi Ping in case you missed previous comment.

Hi @vbuberen ,
Could not get time during weekdays. I will be working on this from today.
Thanks for your review.

Hi @vbuberen ,
Please review.


Remove feature rust-1_28

Rust 1.28 is wayyyyyy below our MSRV so this feature is effectively useless.

bors r+