Make send string parameter as unicode impact set/update null

fix issue #437

Codecov Report

Merging #445 into dev will decrease coverage by 0.14%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##                dev     #445      +/-   ##
============================================
- Coverage     46.37%   46.22%   -0.15%
+ Complexity     2200     2194       -6
============================================
  Files           108      108
  Lines         25212    25212
  Branches       4165     4165
============================================
- Hits          11692    11655      -37
- Misses        11493    11533      +40
+ Partials       2027     2024       -3

Flag
Coverage Δ
Complexity Δ

#JDBC41
46.02% <0%> (-0.09%)
2186 <0> (ø)

#JDBC42
46.12% <0%> (-0.08%)
2192 <0> (ø)

Impacted Files
Coverage Δ
Complexity Δ

...main/java/com/microsoft/sqlserver/jdbc/Column.java
34.54% <ø> (ø)
34 <0> (ø)
:arrow_down:

...n/java/com/microsoft/sqlserver/jdbc/Parameter.java
62.44% <0%> (-1.29%)
63 <0> (+1)

...va/com/microsoft/sqlserver/jdbc/StreamColumns.java
87.83% <0%> (-1.36%)
21% <0%> (-1%)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
32.41% <0%> (-0.73%)
238% <0%> (-5%)

...m/microsoft/sqlserver/jdbc/SQLServerStatement.java
59.06% <0%> (-0.31%)
129% <0%> (-1%)

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
54.01% <0%> (-0.24%)
0% <0%> (ø)

...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java
42.2% <0%> (-0.22%)
46% <0%> (ø)

...c/main/java/com/microsoft/sqlserver/jdbc/Util.java
59.61% <0%> (-0.22%)
89% <0%> (ø)

...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java
77.62% <0%> (-0.17%)
4% <0%> (-1%)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ab207...cce8eac. Read the comment docs.


Proxy not working

Proxy not working:
https://stackoverflow.com/questions/48973288/how-to-use-proxy-in-npms-request-package

Just encountered the same issue. The HTTP_PROXY environment variable seems to be ignored too.


Restore excluded tests

Try restoring excluded tests (RESTEASY-1446, RESTEASY-1778), after having fixed RESTEASY-1800.

12/12 passing runs, I'm merging


language modeling --distributed-no-spawn

❓ Questions and Help
What is your question?
I try to run the language modeling task (wikitext-103) follow the example on 8 gpus. However, I found the issue when I using distributed_no_spawn or not.

If I didn't use --distributed-no-spawn, the training will fill and comes out with this error:

Traceback (most recent call last):
  File "/opt/miniconda/bin/fairseq-train", line 8, in <module>
    sys.exit(cli_main())
  File "/opt/miniconda/lib/python3.7/site-packages/fairseq_cli/train.py", line 352, in cli_main
    distributed_utils.call_main(args, main)
  File "/opt/miniconda/lib/python3.7/site-packages/fairseq/distributed_utils.py", line 286, in call_main
    nprocs=args.distributed_num_procs,
  File "/opt/miniconda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 200, in spawn
    return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
  File "/opt/miniconda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 158, in start_processes
    while not context.join():
  File "/opt/miniconda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 119, in join
    raise Exception(msg)
Exception:

-- Process 5 terminated with the following error:
Traceback (most recent call last):
  File "/opt/miniconda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 20, in _wrap
    fn(i, *args)
  File "/opt/miniconda/lib/python3.7/site-packages/fairseq/distributed_utils.py", line 270, in distributed_main
    main(args, **kwargs)
  File "/opt/miniconda/lib/python3.7/site-packages/fairseq_cli/train.py", line 114, in main
    disable_iterator_cache=task.has_sharded_data("train"),
  File "/opt/miniconda/lib/python3.7/site-packages/fairseq/checkpoint_utils.py", line 213, in load_checkpoint
    epoch=1, load_dataset=True, **passthrough_args
  File "/opt/miniconda/lib/python3.7/site-packages/fairseq/trainer.py", line 382, in get_train_iterator
    self.reset_dummy_batch(batch_iterator.first_batch)
  File "/opt/miniconda/lib/python3.7/site-packages/fairseq/data/iterators.py", line 279, in first_batch
    return self.collate_fn([self.dataset[i] for i in self.frozen_batches[0]])
  File "/opt/miniconda/lib/python3.7/site-packages/fairseq/data/iterators.py", line 279, in <listcomp>
    return self.collate_fn([self.dataset[i] for i in self.frozen_batches[0]])
  File "/opt/miniconda/lib/python3.7/site-packages/fairseq/data/monolingual_dataset.py", line 104, in __getitem__
    source, future_target, past_target = self.dataset[index]
  File "/opt/miniconda/lib/python3.7/site-packages/fairseq/data/token_block_dataset.py", line 125, in __getitem__
    [self.dataset[idx] for idx in range(start_ds_idx, end_ds_idx + 1)]
  File "/opt/miniconda/lib/python3.7/site-packages/fairseq/data/token_block_dataset.py", line 125, in <listcomp>
    [self.dataset[idx] for idx in range(start_ds_idx, end_ds_idx + 1)]
  File "/opt/miniconda/lib/python3.7/site-packages/fairseq/data/indexed_dataset.py", line 234, in __getitem__
    ptx = self.cache_index[i]
KeyError: 1801347

It seems like the spawn or dataset problem.

Therefore, when I add the --distributed-no-spawn option, it seems the job will only run on one gpu, and the process stucks,

+ fairseq-train /blob2/v-lijuwu/data/lm_data/wikitext-103_bin --task language_modeling --arch transformer_lm --share-decoder-input-output-embed --save-dir /blob2/v-lijuwu/models/lm_transformer_lm_wikitext-103 --dropout 0.1 --optimizer adam --adam-betas '(0.9, 0.98)' --weight-decay 0.01 --clip-norm 0.0 --lr 0.0005 --lr-scheduler inverse_sqrt --warmup-updates 4000 --warmup-init-lr 1e-07 --tokens-per-sample 512 --sample-break-mode none --max-tokens 2048 --update-freq 16 --fp16 --ddp-backend=no_c10d --distributed-no-spawn --max-update 80000 --skip-invalid-size-inputs-valid-test --tensorboard-logdir /blob2/v-lijuwu/models/lm_transformer_lm_wikitext-103/tensorboard
2021-05-06 03:34:59 | INFO | fairseq.distributed_utils | distributed init (rank 0): tcp://localhost:15868

Could anyone help with the multi-gpu training language modeling?
Code
The training script is like this:
export CUDA_VISIBLE_DEVICES=0,1,2,3,4,5,6,7

fairseq-train $DATA_PATH \
  --task language_modeling \
  --arch $ARCH --share-decoder-input-output-embed \
  --save-dir $MODEL_PATH \
  --dropout 0.1 \
  --optimizer adam --adam-betas '(0.9, 0.98)' --weight-decay 0.01 --clip-norm 0.0 \
  --lr 0.0005 --lr-scheduler inverse_sqrt --warmup-updates 4000 --warmup-init-lr 1e-07 \
  --tokens-per-sample 512 --sample-break-mode none \
  --max-tokens 2048 --update-freq 16 \
  --fp16 --ddp-backend=no_c10d --distributed-no-spawn \
  --max-update 80000 --skip-invalid-size-inputs-valid-test \
  --tensorboard-logdir $MODEL_PATH/tensorboard

with or without --distributed-no-spawn
What's your environment?

fairseq Version = 0.10.0:
PyTorch Version: 1.6
OS (e.g., Linux): Linux
How you installed fairseq (pip, source): pip install
Python version: 3.7
CUDA/cuDNN version: 10.0
GPU models and configuration: v100

The problem comes from the different data process, I have an old version of processed wikitext-103 dataset. But it can not be compiled with the latest fairseq....
Therefore, I reprocess the data and it can run now.


Avoid parenthesizing unsplittable because of comments

Summary
This PR implements a fix for https://github.com/astral-sh/ruff/issues/8041 where Ruff parenthesized unsplittable values in assignments if it has a trailing end-of-line comment that makes the assignment go over the line length.
____aaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbvvvvvvvvvvvv  # c

# Formatted
____aaa = (
    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbvvvvvvvvvvvv
)  # c

The way black solves this is by moving the trailing end-of-line comment into the assignment so that it only parenthesizes the value (and comment) if formatting it on a new line makes both fit.
# 88 characters unparenthesized, fits on a single line
____aaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbvvvvv  # c

# 88 characters parenthesized
____aaa = (
    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbvvvvvvvvvv  # c
)

# 89 characters parenthesized. Collapse to avoid unnecessary parentheses
____aaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbvvvvvvvvvvvv  # c

Closes https://github.com/astral-sh/ruff/issues/8041
Notes
There's one downside to this approach. It violates our principle of never collapsing an expression if it has trailing line comments. Let's take this example:
a = (
	short  # comment
)

It is now formatted as
a = short  # comment

To ensure the new comment style is reversible.
Non-Fluent attribute chains
Non-fluent attribute chains aren't splittable. However, Black formats the comments after the closing parentheses as ruff used to before this change (related https://github.com/astral-sh/ruff/issues/8182). I decided to favour Black compatibility over consistence because it introduces about 30 file regressions in the similarity index check. Which is more than this PR fixes.
Test Plan
I added extensive tests and reviewed the ecosystem changes. They all seem to capture better the user's intent (and e.g. avoid moving pragma comments.
Main

project
similarity index
total files
changed files

cpython
0.75804
1799
1648

django
0.99984
2772
34

home-assistant
0.99963
10596
148

poetry
0.99925
317
12

transformers
0.99967
2657
328

twine
1.00000
33
0

typeshed
0.99980
3669
18

warehouse
0.99977
654
13

zulip
0.99970
1459
22

PR

project
similarity index
total files
changed files

cpython
0.75804
1799
1648

django
0.99984
2772
34

home-assistant
0.99963
10596
143

poetry
0.99925
317
12

transformers
0.99967
2657
322

twine
1.00000
33
0

typeshed
0.99980
3669
18

warehouse
0.99977
654
13

zulip
0.99970
1459
21

Current dependencies on/for this PR:

main

PR #8431   👈

This stack of pull requests is managed by Graphite.

I like the new style


Weird thing happening on beta

can you please check that this is fixed on canary.kodadot? Currently its working fine, just to be sure

this is beta - latest sales

Wfm on beta, sometimes carousel break (see unknow animated media)


Is there a way to check when Magic Url has triggered? A callback?

I want to automatically add the protocol (https) to the text (not the href! That already works), but to the actual text. Is there a way to already do this or is there a callback so I can do this myself? Thanx for all the help!

Not at the moment, but I would be happy to receive a PR for this feature.

Sry, nothing new here? May I donate to anybody to have it sorted?


Excludes own issues and PRs from triage list

Hi.
This pull request attempts to fix issue #304. I'm not sure if this is the best way to do this (or even if this is the desired behavior), so please review at your convenience and let me know how you'd like it changed.
Before these commits, the behavior was to exclude the following from a given user's triage list:

issues (and pull requests) the user has commented on
closed issues
pull requests when the user's skip_issues_with_pr? flag is set to true

However, a user's triage list would include one's own uncommented issues (and PRs if skip_issues_with_pr? is false). For example, if I subscribe to codetriage/codetriage and submit a pull request to which no one else responds, I could very well end up getting an email asking me to triage my own issue.
When an issue is created in the database, the user who created the issue isn't being stored anywhere. And the comments don't include any information on the user who originally filed the issue. So, I added a creator attribute to the issues table that stores the Github username of the person who filed the issue and used that to exclude one's own issues from a user's triage list.
Assuming this is an acceptable implementation, is this the behavior users want? I think it's reasonable to not want to see your own issues and PRs in your triage list, but I don't know — maybe it makes sense to some to have a skip_my_own_issues? setting.
Let me know your thoughts when you have time and I'd be happy to fix my fix however you'd like.
Cheers,
O-I

@O-I This looks good. I just think rather than creator, we can say created_by. Also we should provide setting for skip_my_own_issues_and_prs in the UI.

@prathamesh-sonpatki You're right — created_by is a better name than created here. :smiley:
As for adding a skip_my_own_issues_and_prs flag, do you want the default to be true or false? I think true makes more sense to me as a default, but I can see an argument for keeping the behavior of the app the same now that users will have a choice.
Let me know and I'll make the necessary changes.

@O-I I think keeping the flag false by default makes sense. This is just to keep the original behavior intact.

Yeah, I quite like the behaviour of seeing my own issues!

@prathamesh-sonpatki Before I push, this is how I have it locally:
def valid_for_user?(user, skip_update = Rails.env.test?)
    unless skip_update
      update_issue!
      return false if commenting_users.include?(user.github)
    end
    valid_for?(user)
  end

# snip

private

# snip

def valid_for?(user)
    !closed? && !(created_by?(user) && user.skip_my_own_issues_and_prs?) &&
                !(pr_attached?      && user.skip_issues_with_pr?)
end

Do you have a suggestion for a better name than valid_for?? Also, is that boolean expression too confusing? Is this clearer?
def valid_for?(user)
  return false if closed?
  return false if created_by?(user) && user.skip_my_own_issues_and_prs?
  return false if pr_attached? && user.skip_issues_with_pr?
  true
end

@O-I I think it can be something like this
def valid_for_user?(user, skip_update = Rails.env.test?)
   update_issue!  unless skip_update
   still_valid_for?(user)
end

...

def still_valid_for?(user)
  return false if closed?
  return false if created_by?(user) && user.skip_my_own_issues_and_prs?
  return false if pr_attached? && user.skip_issues_with_pr?
  return false if commenting_users.include?(user.github)
  true
end

What do you think?

@prathamesh-sonpatki I'd be really happy if we could get valid_for_user? to be what you have. If I take return false if commenting_users.include?(user.github) out of the unless statement, though, I get 4 VCR::Errors::UnhandledHTTPRequestError that look like:
  1) Error:
ReposControllerTest#test_do_not_send_email_for_repo_without_issues:
VCR::Errors::UnhandledHTTPRequestError:

================================================================================
An HTTP request has been made that VCR does not know how to handle:
  GET https://api.github.com/repos/refinery/refinerycms/issues/2272/comments

VCR is currently using the following cassette:
  - /Users/Raevynheart/Code/forks/codetriage/test/vcr_cassettes/create_repo_refinery.yml
  - :record => :once
  - :match_requests_on => [:method, :uri]

Under the current configuration VCR can not find a suitable HTTP interaction
to replay and is prevented from recording new requests. There are a few ways
you can deal with this:

  * If you're surprised VCR is raising this error
    and want insight about how VCR attempted to handle the request,
    you can use the debug_logger configuration option to log more details [1].
  * You can use the :new_episodes record mode to allow VCR to
    record this new request to the existing cassette [2].
  * If you want VCR to ignore this request (and others like it), you can
    set an `ignore_request` callback [3].
  * The current record mode (:once) does not allow new requests to be recorded
    to a previously recorded cassette. You can delete the cassette file and re-run
    your tests to allow the cassette to be recorded with this request [4].

[1] https://www.relishapp.com/vcr/vcr/v/2-5-0/docs/configuration/debug-logging
[2] https://www.relishapp.com/vcr/vcr/v/2-5-0/docs/record-modes/new-episodes
[3] https://www.relishapp.com/vcr/vcr/v/2-5-0/docs/configuration/ignore-request
[4] https://www.relishapp.com/vcr/vcr/v/2-5-0/docs/record-modes/once
================================================================================

    app/models/issue.rb:72:in `commenting_users'
    app/models/issue.rb:118:in `still_valid_for?'
    app/models/issue.rb:20:in `valid_for_user?'
    app/models/issue_assigner.rb:44:in `assign_issue_for_sub'
    app/models/issue_assigner.rb:13:in `block (2 levels) in assign'
    app/models/issue_assigner.rb:12:in `times'
    app/models/issue_assigner.rb:12:in `each'
    app/models/issue_assigner.rb:12:in `map'
    app/models/issue_assigner.rb:12:in `block in assign'
    app/models/issue_assigner.rb:11:in `each'
    app/models/issue_assigner.rb:11:in `assign'
    app/models/repo_subscription.rb:20:in `block in <class:RepoSubscription>'
    app/controllers/repos_controller.rb:46:in `create'
    test/functional/repos_controller_test.rb:26:in `block (2 levels) in <class:ReposControllerTest>'
    test/functional/repos_controller_test.rb:25:in `block in <class:ReposControllerTest>'

Any advice on that?

@O-I I checked it locally. We are pulling the issues in after_create callback after creating repo. I am not sure why its not getting recorded in vcr cassets.
In your stack trace also, the issue is getting pulled dynamically
https://api.github.com/repos/refinery/refinerycms/issues/2272/comments
The issue with 2272 is not present in fixtures. Need to debug more :smile:

Stale, feel free to reopen.


Explore CRTP for basic_parser

This gives access to members like depth and could have performance gains

Peter doesn't like it


Add OCaml 4.10.0

I've added the new version to the image repo in https://github.com/mattgodbolt/compiler-explorer-image/commit/8be836890d5b21aace57b33af51c159ee6a9f009 - And along with this PR, the new versions should hit the live site shortly
Thanks for taking the time to keep the compilers up-to-date :)

Thank you!


feat: Add back calibrateToBottom in current releases

Overview
This is related to the now-closed #9674 which I believe was closed in error.
It is extremely difficult to precisely calibrate (within 100um) of the bottom of a labware well without physically moving the tip there during the stock calibration step.  For many non-conventional protocols, this is a very important feature; for example:

if one wishes to remove the last 50 uL or more or liquid from the well bottom,
depositing by spotting onto a plate,
avoiding bugs where the z-axis of the pipette will go too far into the labware in z, ram the tip into the labware, and fail to pick up liquid.

Fortunately, a user requested a feature in 3.x and 4.x releases - a bool flag that would change the labware calibration position to the well bottom rather than the top.  Specifically, the calibration flow would start at the well top and then expect the user to move the tip to the bottom using z-axis jog before saving position.  By precisely doing this calibration the user was essentially guaranteed to have a precise well bottom position within 0.1 mm.  As described by @mcous in #9674 this feature didn't make it into 5.x but was considered for re-implementation based on another user's use case there.  However, it appears that this never happened.
Could this be added back?  It is critical to my OT2 workflow.
Implementation details
An acceptable workaround would be some explicit documentation of the current calibration flow; i.e, "you are at what I think is the top; the nominal height of this labware well is x mm" so that the user can manually jog down x mm, fix the position, and then jog back up x mm to save.
From a UI perspective, a hidden button that simply saved the current position as well bottom rather than top would be a nice, simple tweak.  Internally this could just do the (calibration_location) = (current_location) + (labware_height) math before saving and thus this feature might be very quick to implement.
Design
No response
Acceptance criteria
No response

This is a really good point!
It's a different feature, but I wonder if a visual or other warning would be warranted it the labware calibration offset goes over a certain magnitude.  (conceptually, the offset between the computed minimum safe travel height and the actual traversed height).
In some sense this is just a question of how precise the calibration is and how precise the original definition is.  If it's off by 500 um that matters a ton for point 3 above, but probably doesn't create much risk of a travel height crash.  There's also a bit of a challenge with the underlying labware data; macroscopic labware height is fairly easy to measure, but I pretty much treat any user measurement of well depth as being ± 1 mm -- including my own.

Thanks for the feedback @pbeaucage! Unfortunately, after internal discussion, we ended up choosing not to focus on getting "calibrate to well bottom" back into the app. However, we have much better workarounds available these days that I would suggest you look into!
In the latest version of the app, the labware check UI will show you what the applied offset will be as you're jogging:

This information, combined with the known depth of the well, might be able to get you to where you need to be. A couple ideas (that both probably require some careful trial and error):

Use the app UI to jog to the bottom center of the well, then manually jog back up by the known well depth, and save that offset
Use the app UI to jog to the bottom center of the well, write down that vector, and then hardcode the offset with the well height taken into account into your protocol directly via Labware.set_offset

Note: as of API level 2.13, using Labware.set_offset is mutually exclusive with using Labware Position Check to set offsets for the same run. We do not guarantee behavior if both are used on the same run
TL;DR: if you use Labware.set_offset, you should skip LPC if running protocols through the app

i'll just leave this here...

@jerader
Just opening this one back up with people who seem to be working on the repository

Hi @Koeng101 , thank you for reopening this issue. We’d like to learn more about how you’re using calibrateToBottom in your lab. Could you email us at<EMAIL_ADDRESS>to schedule a 30-minute call?
Our team made the decision to remove calibrateToBottom because it proved to be less accurate compared to calibrating to the top of the well, for several key reasons:

It’s harder to determine when the tip is touching the bottom of the well than when it’s aligned with the top.
The elasticity of the tip can cause overjogging, leading to the tip being pressed too far, which reduces accuracy for that check and any subsequent ones.
In V- or U-bottom wells, the tip may bend or rotate, complicating X and Y-axis calibration and further affecting precision.
Manual adjustments to check if the tip is pressed into the bottom can cause the tip to come off the nozzle, diminishing the accuracy of following checks.

While the feature had benefits for experienced users, these challenges ultimately led to its removal. Our goal is to continually improve our tools to better serve scientists like you, and we’d appreciate your insights to help us do that. We look forward to hearing from you.


Make initiate/edit/delete frontend for course grouping creation requests.

Make initiate/edit/delete frontend for course grouping creation requests. The grouping can contain courses that are either
1: Accepted and not in a deletion request in the current dossier, or
2: in a course creation request in the current dossier. The grouping can contain any subgroupings that are either 1: accepted and not in a deletion request in the current dossier, or 2: In a course grouping creation request in the current dossier.

in the grouping page:

add courses: get all courses, filter by accepted and not in the current dossier deletion request. (can be null)
add subgroups: get all groups, filter by accepted and not in current dossier deletion request nor creation request. (can be null if lowest level)
grouping name
required credits
isTopLevel
school
description
notes


Specified key was too long

When running the setup, I am getting an error that the specified key was too long

I notice that it is placing a key on 2 VARCHAR(255) columns. Why is this? Is this a bug?

It's not in fact a primary key, it's an index. What database do you use? And have you tried this with a clean database, seeing you already ran into the problem of the tables being present (and as such the indices as well).

Hi,
I did try it with a clean database, it had the same issue. I had to change the collation to 'latin1_general_ci' to utf8 wouldn't accept it.
I have a few other questions which I'll query in a little while. So far I'm very impressed with the framework!
Thank you


bump CSS for new duckplayer

Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL:
iOS PR:
macOS PR:
What kind of version bump will this require?: Major/Minor/Patch
Optional:
Tech Design URL:
CC:
Description:

Steps to test this PR:
1.
1.

OS Testing:

[ ] iOS 14
[ ] iOS 15
[ ] iOS 16
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12

Internal references:
Software Engineering Expectations
Technical Design Template

#920  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on  Graphite


Add [Company vella-peter-paul-oak, product name: VPPOR] #exchange GAWO5U…VGO7E3

Address: GAWO5ULNI3D5ILTGKONRGVTUXSDPFQG75LNUO7LHZHONUPQFEMVGO7E3
Tags: exchange
Title: Company vella-peter-paul-oak, product name: VPPOR
Requested by @vppor

.

Hello @VPPOR,
I am not sure what you are reporting in this issue report. Prior to my reply, this token and minter had already been labeled in our database. This token is one of the many connected to the serial scam minter GC6LTPV4HM4IGAVXQFUVW2SZR6VRUFPB7WTWFPEL2NM7D7G2OPNPNN34
Can you please give more detail and links to what your concerns are about this token and minter?
Looking Towards The Future With You,
Rob TheCryptoHobbyist


Migrate to radiuss-docker

@davidbeckingsale when https://github.com/LLNL/radiuss-docker is complete could you please archive this repository (turn off actions, etc.) and direct folks over there? Thanks!

Absolutely!

Thank you!
Last night I disabled building here and added a note to the README, so when you are ready we can simply just archive or similar. Thanks again @davidbeckingsale !


Add "Vary: Origin" to response when the server specifies an origin host rather than "*"

Accoding to https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#The_HTTP_response_headers:

If the server specifies an origin host rather than "*", then it must also include Origin in the Vary response header to indicate to clients that server responses will differ based on the value of the Origin request header.

Currently, the middleware does not set the Vary header.

According to http://www.w3.org/TR/cors/#resource-implementation:

Resources that wish to enable themselves to be shared with multiple Origins but do not respond uniformly with "*" must in practice generate the Access-Control-Allow-Origin header dynamically in response to every request they wish to allow. As a consequence, authors of such resources should send a Vary: Origin HTTP header or provide other appropriate control directives to prevent caching of such responses, which may be inaccurate if re-used across-origins.

So this should only when options.origin === true and * is not used as Access-Control-Allow-Origin.

+1


Browserify error: Error: Can't walk dependency graph: Cannot find module './formatter' from

In /lib/index.js pls change line
from: define('formatter', () => require('./formatter'));
to: define('formatter', () => require('./format/formatter'));
Thx!

I use the mysql2 2.2.5 version which does not have cardinal but the helper.js requires for the cardinal as below. How to solve this?

Error: Can't walk dependency graph: Cannot find module 'cardinal' from '\node_modules\mysql2\lib'
required by node_modules\mysql2\lib\helpers.js

I use the mysql2 2.2.5 version which does not have cardinal but the helper.js requires for the cardinal as below. How to solve this?

Error: Can't walk dependency graph: Cannot find module 'cardinal' from '\node_modules\mysql2\lib'
required by node_modules\mysql2\lib\helpers.js


CAMEL-19298 Snmp: version 3 is not supported for several actions for …

backported ba0f1910674454f51d7d7d918116f0434167880e and 0b26cafa9485248cd4eb1427b88e57f55c1530a5
Description

Target

[ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[ ] I checked that each commit in the pull request has a meaningful subject line and body.

[ ] I formatted the code using mvn -Pformat,fastinstall install && mvn -Psourcecheck

We need to cherry pick to 3.20.x and 3.x branch also

Missing PRs:
https://github.com/apache/camel/pull/10109
https://github.com/apache/camel/pull/10108


[network] refactor NetworkBuilder

Motivation
Partially Addresses #3342
Refactored away NetworkBuilder, in favor of a NodeNetwork struct that maintains fewer states.
Now that NetworkBuilder is no longer being used, let's discuss how to change the unit/integration tests.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
TBD
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

:umbrella: The latest upstream changes (presumably 97c458e54545e01a7f04ee28ea27164368ea20ce) made this pull request unmergeable. Please resolve the merge conflicts.

Closing this out as it overlaps a lot with ongoing work, might be worth exploring some time in the future depending on where we land with the current ongoing refactor.
Thanks for exploring this space!


tests: improve and add mixerclient tests

upgrade to v2 xDS
use gogo/proto, not golang/proto
use proper envoy hot restart
exit envoy gracefully, check for error code
remove v1 tests
enable TCP tests back, relax some conditions for less flakiness
speed up stats checking
add route directive test
add destination uid override test
add LDS change test for mixerfilter
use stats for envoy readiness instead of pinging

/assign @lei-tang @JimmyCYJ @douglas-reid @hklai
fixes https://github.com/istio/proxy/issues/1802
fixes https://github.com/istio/istio/issues/5696
fixes https://github.com/istio/istio/issues/6617
fixes https://github.com/istio/istio/issues/6265

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/test/client/OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3e3cc14ce4fef2b0f181e378aa6a99f9252ef577
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/test/client/OWNERS [kyessenov]
pilot/OWNERS [kyessenov]
tests/OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
7721b101feef08c5c357696433a934c43ede1009
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
7721b101feef08c5c357696433a934c43ede1009
link
/test istio-unit-tests

prow/istio-presubmit.sh
7721b101feef08c5c357696433a934c43ede1009
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
887a490b9955952d46993c04e2367eb3d4286ff2
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
887a490b9955952d46993c04e2367eb3d4286ff2
link
/test e2e-simple

prow/e2e-dashboard.sh
887a490b9955952d46993c04e2367eb3d4286ff2
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
887a490b9955952d46993c04e2367eb3d4286ff2
link
/test e2e-simple

prow/e2e-dashboard.sh
314e2ca54b05b4ffb65617b724e8e9a1c51c8ac0
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Hey @yangminzhu , can you take a look here since you're familiar with envoy. Don't want this to become stale and run into merge conflicts.

@kyessenov , I'm not familiar with envoy actually, maybe you mean @lizan ?

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
314e2ca54b05b4ffb65617b724e8e9a1c51c8ac0
link
/test e2e-dashboard

prow/istio-unit-tests.sh
a62e962c3a58bcecd59b0b85e14d35e484951c05
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JimmyCYJ, kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test istio-unit-tests

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
a62e962c3a58bcecd59b0b85e14d35e484951c05
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks! I've noticed that I missed one tab. I'll patch it up later, the tests are very flaky lately for some reason.

New changes are detected. LGTM label has been removed.

Need re-lgtm. Connection may get refused on circle even when envoy reports readiness... Forced 1s delay to deal with this.

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
94e5daec213fc98e69c4adc33ca6045067a0e786
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks. Once again, vendor change created a merge conflict...

/lgtm
to unblock this. but please work with the CF test only to see what it takes to restore "--v2-config-only" (assuming that is necessary).

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: douglas-reid, hklai, JimmyCYJ, kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [douglas-reid,hklai,kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai the flag is not necessary but cannot be specified twice. The original test was not meant for v2 or pilot at all, so it's a bit surprising why CF test got affected.


Add mypy and black badges

Codecov Report

Merging #58 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   88.65%   88.58%   -0.07%
==========================================
  Files          11       11
  Lines         705      701       -4
  Branches       80       80
==========================================
- Hits          625      621       -4
  Misses         72       72
  Partials        8        8


Different stylus packages, different results?

So I was using this package and i noticed that one of my buttons didnt render the same as when using a different stylus package.
Code:
jade:
a.visit-button(href="{{pathFor 'visit'}}") Visit

stylus:
.visit-button
	font-weight 800
	border white 4px solid
	display block
	box-sizing border-box
	margin 15px auto
	padding 8px
	width 150px
	max-width 200px
	background none //rgba(240, 0, 255, .4)
	color white
	text-align center
	text-decoration none
	letter-spacing 1px
	transition all 0.3s ease-out
	&:hover
		background white
		color #101828
		transition all 0.5s ease-in

With other packages, the button renders as a ghost button (white border with transparent background, background opacity increases when hovered)
Basically this:

becomes this:

With this package, the border isnt there. The other packages i used were meteor add stylus and meteor add juliancwirko:s-grid <- which includes stylus.
Was just wondering if anyone had any idea why this would happen?

I created a clonable reproduction: https://github.com/mquandalle/meteor-stylus-issue-11.
The issue is with the order of arguments of the border property. You have to write border 4px solid white instead of border white 4px solid. The different in packages behaviour is probably related to the fact that we are using a more recent version of stylus.

Do you have any links that go into why they have to be in a certain order?


Render issues when Windows Display scaling is not 100%

Whenever a new sciview window is launched, the rendered region does not take the GUI scaling from Windows into account, meaning it may render a smaller region:

Once you rescale the window, it will adjust to the actual bounds.
The width of the empty area is exactly 25% larger than that of the rendered area. This corresponds perfectly to my 125% system scale setting.
This issue is likely related to #475 and #469, which are also caused by incorrect handling of HiDPI and Windows display scaling.
This is on Windows, but it would be interesting to know if this also affects Linux/Mac or if these systems handle display scaling differently (I believe so).

See also this Zulip thread


Proposal: regular expression package

We need a simple and compact regular expression package that supports the POSIX’s Extended Regular Expressions syntax (Maybe extend to PCRE syntax in the future). This package needs to be able to compile a regular expression and use it to match or replace given strings.
Consideration:
Which style of the regular expression engine should we implement? There are two main styles: backtracking and automata. The backtracking style is used by popular languages like Java, Python, and JavaScript. This style allows for more features but can result in bad performance in some cases. The automata style is used by Rust's regex crate and Go's regex std. While it may not allow for certain features that rely on backtracking, it can match regex in linear time.
References:

Regular Expression Matching Can Be Simple And Fast
Regular Expression Matching: the Virtual Machine Approach
POSIX Extended Regular Expressions
Rust's regex crate
Go's regex lib

Related: https://github.com/yj-qin/regexp


Update case-study-afternows-process-envisioning,-prototyping,-buildin…

…g.md
Fixed About the author spacing

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/case-study-afternows-process-envisioning,-prototyping,-building.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add missing params.opengraph locale for fr_FR, nl_NL

Add missing "params.opengraph" > "locale" for fr_FR, nl_NL instead of the default en_US: <meta property="og:locale" content="en_US" /

Yes, I had problems if I switch between my notebook with git. Have to fix
it immediately.
Found also another config behavior - my lasted GitHub discussion.
Mark Dumay @.***> schrieb am Mo., 22. Juli 2024, 11:11:

@.**** commented on this pull request.
In exampleSite/config/_default/languages.toml
https://github.com/gethinode/hinode/pull/1043#discussion_r1686229780:

@@ -39,6 +41,8 @@ reference = "Meer projecten"
languageName = "Français"
contentDir = "content/fr"
weight = 2
+[nl.params.opengraph]

Currently, the Netlify build fails, likely related to the above comment:
11:02:23 AM: Error: failed to load config: failed to unmarshal config for path "/opt/build/repo/exampleSite/config/_default/languages.toml": "_stream.toml:1:1": unmarshal failed: toml: table opengraph already exists
—
Reply to this email directly, view it on GitHub
https://github.com/gethinode/hinode/pull/1043#discussion_r1686229780,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABUIHMDOL3JHZLRRHDNGA3LZNTEDBAVCNFSM6AAAAABLGUPAKWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOJRGA2DSMRRGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Should I create a new patch for the whole config that I found out?
Dominik Oswald @.***> schrieb am Mo., 22. Juli 2024, 11:50:

Yes, I had problems if I switch between my notebook with git. Have to fix
it immediately.
Found also another config behavior - my lasted GitHub discussion.
Mark Dumay @.***> schrieb am Mo., 22. Juli 2024,
11:11:

@.**** commented on this pull request.
In exampleSite/config/_default/languages.toml
https://github.com/gethinode/hinode/pull/1043#discussion_r1686229780:

@@ -39,6 +41,8 @@ reference = "Meer projecten"
languageName = "Français"
contentDir = "content/fr"
weight = 2
+[nl.params.opengraph]

Currently, the Netlify build fails, likely related to the above comment:
11:02:23 AM: Error: failed to load config: failed to unmarshal config for path "/opt/build/repo/exampleSite/config/_default/languages.toml": "_stream.toml:1:1": unmarshal failed: toml: table opengraph already exists
—
Reply to this email directly, view it on GitHub
https://github.com/gethinode/hinode/pull/1043#discussion_r1686229780,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABUIHMDOL3JHZLRRHDNGA3LZNTEDBAVCNFSM6AAAAABLGUPAKWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOJRGA2DSMRRGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Should I create a new patch for the whole config that I found out?

If it's related to open graph, you could push it to this PR. Otherwise, I'd suggest to fix this patch and open a new PR for the other issue.


CLI is ignoring defaults.styleExt

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.4.1
Repro steps.

Run "ng set defaults.styleExt scss"
Run "ng g c my/component"
Also had previously altered .angular-cli.json with defaults.styleExt = scss
The log given by the failure.

C:\git\nps_portal>ng set defaults.styleExt scss

C:\git\nps_portal>ng g c hub/narwhal
  create src/app/hub/narwhal/narwhal.component.html (26 bytes)
  create src/app/hub/narwhal/narwhal.component.spec.ts (635 bytes)
  create src/app/hub/narwhal/narwhal.component.ts (273 bytes)
  create src/app/hub/narwhal/narwhal.component.css (0 bytes)
  update src/app/hub/hub.module.ts (1041 bytes)

Desired functionality.

CLI should generate stylesheets with the extension found in defaults.styleExt
Mention any other details that might be useful.

Was previously using version 1.2.6 and did not have this issue.

I can confirm this is also happening to me with version 1.4.1.

Duplicate of #7624, #7644 & #7647,& #7522


How to enable motion correction?

Required Info

Camera Model
{ D435i }

Firmware Version
(<IP_ADDRESS>)

Operating System & Version
{Linux (Ubuntu 14/16/17)

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC/

Language
{python }

Issue Description
How do i enable motion correction in my code?
Here is how i went on so far
context = rs.context()
pipeline = rs.pipeline(context)
config = rs.config()
rs.option.enable_motion_correction, 1 # How do i "actually enable this" or verify that it is enabled properly?
config.enable_stream(rs.stream.gyro, rs.format.motion_xyz32f, 200)
config.enable_stream(rs.stream.accel, rs.format.motion_xyz32f, 250)
profile = pipeline.start(config)

Hi @MyOtherNamesWereTaken  Is this case a continuation of the earlier question at https://github.com/IntelRealSense/librealsense/issues/10371#issuecomment-1094894224 where you asked about setting rs.option.enable_motion_correction to a value of '1', please?
The RealSense SDK's Python IMU calibration tool provides an example of using rs.option.enable_motion_correction by associating it with a sensor definition called 'imu_sensor'.
if self.imu_sensor.supports(rs.option.enable_motion_correction):
self.imu_sensor.set_option(rs.option.enable_motion_correction, 0)
return True

https://github.com/IntelRealSense/librealsense/blob/master/tools/rs-imu-calibration/rs-imu-calibration.py#L265-L267
You should be able to check the status of a particular rs.option instruction (0 or 1) by storing the value in a variable using get_option, like the Python script at https://github.com/IntelRealSense/librealsense/issues/10065#issuecomment-995038951
More information about the motion correction instruction can be found at https://github.com/IntelRealSense/librealsense/pull/2964
If motion correction is enabled then the 'y' Accel value should be able to approach the ideal target value of 9.80, otherwise it will be more likely to be in the range of 9.4 to 9.6 if motion correction is disabled and raw IMU values are being used.

Hi @MyOtherNamesWereTaken  Do you require further assistance with this case, please?  Thanks!


Added Responsive grid

Added Responsive grid
please merge my PR with hacktoberfest label

We will not be accepting PRs without good reason, and hacktoberfest alone isn't a good reason to merge a PR we do not want.


Select menu V2

Checklist

[x] I have run nox and all the pipelines have passed.
[ ] I have made unittests according to the code I have added/modified/deleted.

Related issues
Closes #1451

CI Stuck


[Thinkit] Add sFlow gNMI config in sFlow test. Increase sFlow tolerance rate. Add a test to verify sampling size works. Fix sample size issue. Adds sFlow gNMI config constants.

Key_word Check:
~/pins_upstream/sonic-buildimage/src/sonic-p4rt/sonic-pins/tests/sflow$ ~/tools/keyword_checks.sh .
Keyword check Passed.

Build result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 621 targets (0 packages loaded, 0 targets configured).
INFO: Found 621 targets...
INFO: Elapsed time: 0.457s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

Test result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 625 targets (0 packages loaded, 2 targets configured).
INFO: Found 418 targets and 208 test targets...
INFO: Elapsed time: 157.848s, Critical Path: 112.22s
INFO: 261 processes: 315 linux-sandbox, 18 local.
INFO: Build completed successfully, 261 total actions
//dvaas:port_id_map_test                                                 PASSED in 2.0s
//dvaas:test_run_validation_golden_test                                  PASSED in 0.1s
//dvaas:test_run_validation_test                                         PASSED in 1.0s
//dvaas:test_run_validation_test_runner                                  PASSED in 0.1s
//dvaas:test_vector_stats_diff_test                                      PASSED in 0.1s
//dvaas:test_vector_stats_test                                           PASSED in 0.2s
//dvaas:test_vector_test                                                 PASSED in 1.5s
//dvaas:user_provided_packet_test_vector_diff_test                       PASSED in 0.2s
//thinkit:mock_control_device_test                                       PASSED in 0.8s
//thinkit:mock_generic_testbed_test                                      PASSED in 0.7s
//thinkit:mock_mirror_testbed_test                                       PASSED in 1.0s
//thinkit:mock_ssh_client_test                                           PASSED in 0.1s
//thinkit:mock_switch_test                                               PASSED in 1.0s
//thinkit:mock_test_environment_test                                     PASSED in 0.1s
//thinkit:switch_test                                                    PASSED in 1.1s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test     PASSED in 1.5s
  Stats over 5 runs: max = 1.5s, min = 1.0s, avg = 1.3s, dev = 0.2s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test     PASSED in 44.1s
  Stats over 50 runs: max = 44.1s, min = 1.2s, avg = 3.5s, dev = 8.3s

Executed 208 out of 208 tests: 208 tests pass.
INFO: Build completed successfully, 261 total actions

/azp run

/azp run

@VSuryaprasad-HCL Pls resolve conflicts

/azp run


popovers: Add "Rename topic" option in topic sidebar popover.

First commit is to add buffer for disabling the topic and stream inputs in "Move topic" and "Move message" modal.

Third commit is to add "Rename topic" option in topic sidebar popover.
Fourth commit is to fix showing resolve option as per topic edit setting.

Fixes:  #19886

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Looks good to me in manual testing!
I'm not sure what the changes are for "resolve topic". I'm seeing "resolve/unresolve topic" shown for topics past the message editing time limit; nothing happens when I click one of those options. We're probably addressing this elsewhere?
I do see that "resolve/unresolve topic" is not shown when the user doesn't have topic editing permissions at all, which is good.

This is great, merged, thanks @sahil839!


WindowsAppRuntimeInstaller.exe fails if newer version present

Discussion #2708: WindowsAppRuntime installation error: The package could not be installed because a higher version of this package is already installed

Microsoft.WindowsAppRuntime.1.1_1000.516.2156.0_x64__8wekyb3d8bbwe Package deployment result : 0x80073d06 The package could not be installed because a higher version of this package is already installed. One or more install operations failed. Result: 0x80073d06

That's a bug - it should be OK, not an error.
If v1.1.3 is installed and you run the installer for v1.1.2 we call packageManager.AddPackageAsync(...v1.1.2...) which returns 0x80073d06 == ERROR_INSTALL_PACKAGE_DOWNGRADE which is technically an error but functionally it's OK. If you build with 1.1.2 we don't require the runtime packages exactly match 1.1.2, but rather that there needs to be a package equal-or-higher than 1.1.2 (i.e. >=1.1.2 not ==1.1.2). If 1.1.3 is installed then all is well.
Problem is we should be trapping ERROR_INSTALL_PACKAGE_DOWNGRADE and treating it as success. That's a bug on our part.
https://task.ms/40411617
FYI: servicing-consider-1.1 = https://task.ms/40411679

/azp run

I think this has regressed.
I get this error when trying to install 1.1.4 on a system with 1.1.5
Installing license: MSIX_MAINPACKAGE_LICENSE
Install result : 0x0
Installing license: MSIX_SINGLETONPACKAGE_LICENSE
Install result : 0x0
Deploying package: Microsoft.WindowsAppRuntime.1.1_1004.584.2120.0_x64__8wekyb3d8bbwe
Package deployment result : 0x80073d06 The package could not be installed because a higher version of this package is already installed.
ErrorMessage: Windows cannot install package Microsoft.WindowsAppRuntime.1.1_1004.584.2120.0_x64__8wekyb3d8bbwe because it has version 1004.584.2120.0. A higher version 1005.616.1651.0 of this package is already installed.One or more install operations failed. Result: 0x80073d06

I'll open an issue.


[iOS native] Check doesn't do anything

Describe the bug
Checking username or password doesn't seem to be responding
To Reproduce
Steps to reproduce the behavior:

Open the native app via TestFlight (v1.0 build 6)
Provide with a username OR password
Press ENTER or tap on Check (top right button)
See error

Expected behavior
The success or fail view is shown
Observed
Nothing happens on screen

Looks like an issue with the old version of ionic-vue. Closing


Adding new mjml container for mjml builds.

Hi @statik @laurencaitlan ! Was this what you guys were thinking for this new mjml container?
With this PR we can now run docker-compose run mjml to build all template files in the template folder. They will be output to the dist folder.
Issue #HAV-191
Signed-off-by: Christopher Mundus<EMAIL_ADDRESS>

@crashGoBoom awesome work! this is exactly what I was looking for.


replaced outdated cmdlet

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/8821
source: https://devblogs.microsoft.com/scripting/should-i-use-cim-or-wmi-with-windows-powershell/

Dear @JohanFreelancer9,
kindly do the copy editor review for this PR.
Dear @nam31, for your information
Thank you

#sign-off


Does this app support Github enterprise yet?

Hi there,
I'm about to setup the JIRA on cloud/Github enterprise integration using this app as per the link: https://support.atlassian.com/jira-cloud-administration/docs/integrate-with-github/.
Wondering is the github enterprise integration is supported yet?
Thanks

It works with Enterprise Cloud (hosted on github.com) but doesn't work with Enterprise Server (self-hosted) :)

Does this answer your question?  If so, I'll close this issue.  Thanks

Yes, that response answers to the question.. Will raise any new issues if we find any issues on integrating with JIRA/Github, however happy to close this issue, as it is an initial clarification.


Fedora vmi console got stuck at "[  OK  ] Started Login Service."

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug

What happened:
# oc get pod
virt-launcher-vmi-fedora-27znw         2/2       Running   0          5m        <IP_ADDRESS>
# oc get vmi
NAME         AGE
vmi-fedora   5m
# oc describe vmi vmi-fedora
Name:         vmi-fedora
Namespace:    kubevirt
Labels:       kubevirt.io/nodeName=dev-test
              special=vmi-fedora
Annotations:  <none>
API Version:  kubevirt.io/v1alpha2
Kind:         VirtualMachineInstance
Metadata:
  Creation Timestamp:  2018-12-15T05:03:25Z
  Generation:          1
  Resource Version:    178612
  Self Link:           /apis/kubevirt.io/v1alpha2/namespaces/kubevirt/virtualmachineinstances/vmi-fedora
  UID:                 c0917da1-0026-11e9-9a46-80c16e6c5154
Spec:
  Domain:
    Devices:
      Disks:
        Disk:
          Bus:        virtio
        Name:         containerdisk
        Volume Name:  registryvolume
        Disk:
          Bus:        virtio
        Name:         cloudinitdisk
        Volume Name:  cloudinitvolume
    Machine:
      Type:
    Resources:
      Requests:
        Memory:                      1024M
  Termination Grace Period Seconds:  0
  Volumes:
    Container Disk:
      Image:  kubevirt/fedora-cloud-container-disk-demo:latest
    Name:     registryvolume
    Cloud Init No Cloud:
      User Data:  #cloud-config
password: fedora
chpasswd: { expire: False }
    Name:  cloudinitvolume
Status:
  Node Name:  dev-17.rhev.lab.eng.brq.redhat.com
  Phase:      Running
Events:
  Type    Reason            Age              From                                              Message
  ----    ------            ----             ----                                              -------
  Normal  SuccessfulCreate  6m               virtualmachine-controller                         Created virtual machine pod virt-launcher-vmi-fedora-27znw

  Normal  Created           5m (x2 over 5m)  virt-handler, dev-test  VirtualMachineInstance defined.

  Normal  Started           5m               virt-handler, dev-test  VirtualMachineInstanced started.
# virtctl console vmi-fedora
Successfully connected to vmi-fedora console. The escape sequence is ^]
                                                                       [    0.000000] Linux version 4.18.16-300.fc29.x86_64<EMAIL_ADDRESS>(gcc version 8.2.1 20180801 (Red Hat 8.2.1-2) (GCC)) #1 SMP Sat Oct 20 23:24:08 UTC 2018
[    0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-4.18.16-300.fc29.x86_64 root=UUID=01043a6a-fca2-4a1d-af0c-3463a132e851 ro no_timer_check net.ifnames=0 console=tty1 console=ttyS0,115200n8 LANG=en_US.UTF-8
----------------------------------8<-----------------------------------
[  OK  ] Started NTP client/server.
[    9.103485] [drm] Initialized bochs-drm 1.0.0 20130925 for 0000:00:01.0 on minor 0
[  OK  ] Started System Security Services Daemon.
[  OK  ] Reached target User and Group Name Lookups.
         Starting Login Service...
[  OK  ] Started Login Service.

What you expected to happen:
console works normally
How to reproduce it (as minimally and precisely as possible):
Create a fedora vmi with kubevirt/fedora-cloud-container-disk-demo:latest
Anything else we need to know?:

cluster: deploy openshift 3.11 on a centos physical host by openshift-ansible
Can not reproduce the issue with fedora image kubevirt/fedora-cloud-container-disk-demo:v0.11.0 and cirros image.
Can not reproduce the issue on openshift cluster setup on openstack

Environment:

KubeVirt version (use virtctl version): v0.12.0-alpha.1
Kubernetes version (use kubectl version): v1.11.0+d4cacc0
VM or VMI specifications: https://github.com/kubevirt/kubevirt/blob/master/cluster/examples/vmi-fedora.yaml
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release): centos
Kernel (e.g. uname -a): Linux 3.10.0-862.el7.x86_64 #1 SMP Fri Apr 20 16:44:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Install tools:
Others:

I deployed a new openshift+kubevirt+sriov env on another sriov capable machine and I can't reproduce the issue any more. So I think it may relate to the hardware. Let's close the issue. Feel free to reopen it when meet the issue again. Thanks

I've hit this issue on my new SR-IOV hardware. This happens with Fedora, whether it's attached to SR-IOV or not; but Cirros boots fine and I can log into the console. I'll investigate more.

I finally have an explanation of what's going on here.
It turns out that with newer guest kernels, boot process may get stuck if the guest doesn't have enough entropy generated for it. This happens all the time during Fedora boot process. A workaround is connecting to the guest via VNC and moving your mouse a bit, which gives enough pseudo-entropy for RNG to produce output and unlock boot process.
It seems that it started happening in recent kernels: https://marc.info/?l=linux-kernel&m=152471887030737&w=2
There are several Red Hat bug reports for this, some closed for public:
https://bugzilla.redhat.com/show_bug.cgi?id=1639840
https://bugzilla.redhat.com/show_bug.cgi?id=1593843
A solution is to add rng device to VMI manifest:
spec:
  domain:
    devices:
      rng: {}

At the very least, we should probably add rng to all Fedora examples. Also, user-guide should be updated to describe this behavior in the section about rng. Finally, we may want to consider adding the device by default to all VMIs to avoid similar bug reports in the future: while the issue can not be easily reproduced with Cirros or Alpine due to different services started as part of their boot process, there may be in-guest payloads that would still require entropy, at which point they could also be stuck. And since this behavior will be seen in all fresh kernels, it may be a sensible default for Linux guests.

adding rng to fedora examples: https://github.com/kubevirt/kubevirt/pull/2429


How to see a preprocessed image (from translator)?

I want to take a peek on how an image looks like after being preprocessed from a translator
eg:
val translator: Translator<Image, Classifications> = ImageClassificationTranslator.builder()
		.addTransform(Crop(933, 439, 1593, 843))
		.addTransform(CenterCrop(124, 124))
		.addTransform(ToTensor())
		.addTransform(Normalize(floatArrayOf(0.485f, 0.456f, 0.406f), floatArrayOf(0.229f, 0.224f, 0.225f)))
		.optApplySoftmax(true)
		.build()

https://stackoverflow.com/questions/53623472/how-do-i-display-a-single-image-in-pytorch/55196345

@rebelate
DJL uses Image class to represent a image object, it wraps BufferedImage or Bitmap (for Android). Using DJL's built-in pre-processing pipeline, you can convert the image into a NDArray object. You can convert NDArray back to Image if want to display the processed image:
        Path imageFile = Paths.get("my_image.jpg");
        ImageFactory factory = ImageFactory.getInstance();
        Image img = factory.fromFile(imageFile);

        try (NDManager manager = NDManager.newBaseManager()) {
            NDArray array = img.toNDArray(manager);
            Pipeline pipeline = new Pipeline();
            pipeline.add(new Crop(1, 1, 300, 300))
                    .add(new CenterCrop(224, 224))
                    .add(new ToTensor())
                    .add(new Normalize(new float[]{0.485f, 0.456f, 0.406f), new float[]{
                            0.229f, 0.224f, 0.225f
                    });
            NDArray output = pipeline.transform(new NDList(array)).head();
            Image result = factory.fromNDArray(output);

            // You can save your processed image into a file:
            result.save(Files.newOutputStream(Paths.get("output.png")), "png");

            // You can extract Java BufferedImage and display it Jupyter notebook or using AWT
            BufferedImage bufferedImage = (BufferedImage)result.getWrappedImage();
        }


New Rule: disallow passing class methods as callbacks

Every time you directly pass a class method as an argument to some function, you're probably doing it wrong. You want to bind using fat arrow instead.
// bad
someExternalLibrary.onClick(this.onClick)

// good
someExternalLibrary.onClick(() => this.onClick());

dup of #259

Good call, thanks @markelliot.


Validate pipe names to prevent staging database creation failures

The user-provided pipe name is used internally to create a staging database. There are limitations as to what a database can be named. For example, a name may not include a comma, as in "Hello, world".

From the cloudant help: ... must start with a letter and can only contain lowercase letters (a-z), digits (0-9) and the following characters _, $, (, ), +, -, and /.


Indoor model weight

Thanks for your amazing works! Will you provide indoor weight?

Thanks for your reply!


selecting an marker in iOS simulator direcly after search leads to unexpected results

Could you be a little bit more specific or provide a screenshot? I did not encounter any problems when testing on my iPhone.


⚠ Bofrost.at has degraded performance

In e3a8037, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1746 ms

Resolved: Bofrost.at performance has improved in 9951fbd after 13 minutes.


Update jupyter-js-services and associated APIs

Awesome, it's good that we have generic session API names since we have multiple types of sessions now.
👍


Unrecognized option "pretty" under "swagger"

Application Coniguration section of README.md shows an invalid option pretty, which should be pretty_json.
This:
swagger:
    # ...
    pretty: true

should be updated to:
swagger:
    # ...
    pretty_json: true

Thanks @codeaid! Will be fixed with #20!


Support for mingw-w64 in gnu mode

I have submitted the patches from this PR to the llvm-commits mailing list :)

Woah, great job, Martell!

Can you rebase and put this on http://reviews.llvm.org/ so it can be reviewed?

Hi @ismail,
I already sent it into llvm.
Along with 30 or so other patches.
They were in the middle of creating new section based linkers "COFF" and "ELF2" so this patch was not merged.
We apply it locally to msys2.
We will have to wait until ELF2 is finialised before redoing this work on the newer linkers.
This patch would not be allowed on the official 3.7.x repos as patches are only back ported from HEAD.
So locally applying is the only option

lld2 is stable, in fact it's now lld. Feel free to submit patches upstream and/or report bugs instead of using github.


Cannot run sonar on mono-repo lib, tsquery_1.ast error

Which area/package is the issue in?
@koliveira15/nx-sonarqube
Description

Next.js monorepo on<EMAIL_ADDRESS>version: ^4.2.1

Trying to configure this lib in a monorepo apps + libs.
Took an 1st try on i18n lib. Configured everything based on docs.
Trying local first so:

used npx nx g @koliveira15/nx-sonarqube:config i18n
ran test with coverage
then trying to run npx nx sonar i18n , it runs successfully tests
but then getting an error:

seems like all config are correct.
What can be the issue or a fix?
The SonarQube scan failed for project 'i18n'
TypeError: (0 , tsquery_1.ast) is not a function
    at /Users/user/dev/projectx/node_modules/@koliveira15/nx-sonarqube/src/executors/scan/utils/utils.js:106:57
    at Array.forEach (<anonymous>)
    at /Users/user/dev/projectx/node_modules/@koliveira15/nx-sonarqube/src/executors/scan/utils/utils.js:83:14
    at Generator.next (<anonymous>)
    at fulfilled (/Users/user/dev/projectx/node_modules/tslib/tslib.js:167:62)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

when trying to downgrade the package to "4.1.1" then getting another one
resolved package json from libs/i18n, package version:0.9.0
The SonarQube scan failed for project 'i18n'
TypeError: sonarQubeScanner.async is not a function
    at /Users/user/dev/projectx/node_modules/@koliveira15/nx-sonarqube/src/executors/scan/utils/utils.js:154:48
    at Generator.next (<anonymous>)
    at fulfilled (/Users/user/dev/projectx/node_modules/tslib/tslib.js:167:62)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

Also experiencing this issue. You can get it to work by downgrading the package to 4.1.1, and installing the package sonarqube-scanner and pinning it's version to 3.1.0

that's nice @mkalpha  thanks for pointing it here :)

@bisfrim tried to cleanup whole workspace and node_modules with reinstall?


Library usability improvements

X25519SecretKey and X25519PublicKey from_str is not compatible with ? because it doesn't implement the trait FromResidual, using thiserror or anyhow should solve it.
Config preshared_key requires a [u8; 32] which can only easily be done at compile time not run time, switching to a Vec<u8> should solve it.
Config endpoint_addr requires an ip address but wireguard configs often provide domain names for dynamic dns purposes, adding a ping step should solve it.

@SheaFoxx Your example Config is not providing any port-forwards:
            port_forwards: Default::default(),

You would need to specify at least one for onetun to do something. This is the equivalent configuration passed in the command-line like onetun <IP_ADDRESS>:8080:<IP_ADDRESS>:8080.


Ensure crc dnsmasq server entries are not duplicated

Replace the blockinline by lineinfile to avoid injecting multiple times the same server in the dnsmasq config.

/lgtm

/lgtm

recheck


GestureDetector with empty Container as a child is not tappable

onTapDown responds in
GestureDetector(
  onTapDown: (tdd) => print('TD2'),
),

but not in
GestureDetector(
  onTapDown: (tdd) => print('TD2'),
  child: Container(),
),

Responds again in
GestureDetector(
  onTapDown: (tdd) => print('TD2'),
  child: Container(decoration: BoxDecoration(),),
),

[✓] Flutter (Channel unknown, v1.14.7-pre.78, on Linux, locale en_US.UTF-8)
[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[✓] Android Studio (version 3.2)
[✓] Android Studio (version 3.5)
[✓] Android Studio (version 3.5)
[!] Android Studio (version 3.4)
✗ Unable to find bundled Java version.
[!] IntelliJ IDEA Community Edition (version 2018.3)
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
[!] IntelliJ IDEA Community Edition (version 2019.1)
✗ Flutter plugin not installed; this adds Flutter specific functionality.
[✓] VS Code (version 1.40.2)
[✓] Connected device (1 available)
! Doctor found issues in 4 categories.

I think you should set height and width for Container!

@tarobins
if the container doesn't have a child it will not render anything.
so you can pass some height and width arguments.
GestureDetector(   onTapDown: (tdd) => print('TD2'),   child: Container(             height:100,              width:100), ),

I'm not sure size is an issue here.  In this example, I set up each of the above gesture detectors to each take up 1/3rd of the screen.  Two of them respond to clicks and one does not.  Even if the empty container does not render, I would expect its parent GestureDetector to still be clickable as it is still on screen and taking up space.

This is an expected behavior. Containers can only be hit if they have any color or decoration (this is a little badly documented), and GestureDetector with the default option will only be hit if it doesn't have a child or its child is hit. If you would like to make sure the entire GestureDetector to be hittable, the best way would be to set GestureDetector.behavior to translucent or opaque, depending on whether you want the widgets behind it (on the screen) to be hit or not.

Hi @dkwingsmt
I see the pr has landed adding in the doc
/// By default, containers return false for all hit tests. If the [color]
/// property is specified, the hit testing is handled by [ColoredBox], which
/// always returns true. If the [decoration] or [foregroundDecoration] properties
/// are specified, hit testing is handled by [Decoration.hitTest].
///

is this issue meant to be open?
Thank you

Yes, that doc was added for this issue.
Feel free to reopen if there are anything else unclear.


[T4A2][W15-B1] Jazlyn Ang

Ready for review

Declare all the Parser methods as static (not just a single method of the Parser class.
Note that it doesn't really make sense for nextSequenceNumber to start from 0 (even though it works), as it is used to indicate the "next" sequence number as we discussed in the tutorial.
When method declarations in Parser class are set as static, do remember that the Parser class won't need to be instantiated anymore, just call directly using the Parser.methodName().


Picker loop

Motivation
I needed a styleable time picker for my app, and DatePicker was not a good choice. So I tried to create my own by using the PickerIOS component.
But there were two small inconveniences that didn't give me the needed result:

bigger font size makes the text clip at the top and bottom -  Screenshot
there is no way to make the items wrap around like in the native DatePicker

This patch adds these features.
Test Plan
Tested in my own app.
Example code:
<Picker
  loop
  style={{ width: 100 }}
  itemStyle={{ color: 'white', fontFamily: 'Montserrat-Regular', fontSize: 50 }}
  selectedValue={this.state.minuteValue}
  onValueChange={this.state.onMinuteChange}>
  {[...Array(60)].map((_, i) => (
   <Picker.Item
     key={i}
     label={i < 10 ? `0${i.toString()}` : i.toString()}
     value={i} />
   ))}
</Picker>

Yields the following result: Screenshot
Final result: Screenshot

By analyzing the blame information on this pull request, we identified @spicyj and @mkonicek to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@alin23 updated the pull request.

I don't really like the approach with these arbitrary numbers (*50, *100). Are there any alternatives?

@alin23 updated the pull request.

@alin23 updated the pull request.

@alin23 updated the pull request.

I removed the rowHeightForComponent commit and tried another approach instead of using the arbitrary values.
Instead of doing _items.count * 100 for repeating the items, I compute the multiplier using the number of items. This way, the more items are in the picker, the less times they are repeated.

@alin23 updated the pull request.

@alin23 updated the pull request.

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @spicyj as a potential reviewer. Could you take a look please or cc someone with more context?

@alin23 do you still intend to ship this? See review feedback above.


High latency on first readStream of a series.

Environment details

OS: Windows 7
Node.js version: 10.11.0
yarn version: v1.9.4
@google-cloud/storage version: 2.0.3

Steps to reproduce

Define storage and bucket when node starts:
const storage = new Storage({
    projectId: projectID,
});

// See: https://github.com/googleapis/nodejs-storage/issues/101
storage.interceptors.push({
    request: reqOpts => {
        reqOpts.forever = true
        return reqOpts
    }
});

const hotBucketName = 'sampleName';
const hotBucket = storage.bucket(hotBucketName);

function getHotBucket() {
    return hotBucket;
}

At a later time (when petitions are handled) use the bucket, get the File, create a readStream and read:
const bucket = getHotBucket();

let name: string = "sampleFile"; // Existing file.

const file = bucket.file(name);

const rdStrm = file.createReadStream({ validation: "crc32c" });

let once = true;
console.log("start");
rdStrm.on('data', (chunk) => {
    if (once) {
        console.log("First on('data')");
        once = false;
    }
    // Do stuff, like passing the data to the client, saving a file, etc...
});
reader.on('end', () => {
    console.log("End");
    // Do other stuff
})

So, I usually do this in sequence for multiple files as requests come in (the code shown is a simplified version). And the first of a series takes unusually long to fire the first .on('data'). Even up to 10 seconds. After that the next files that are requested take only a few ms.

Hey @JAciv, I just ran a quick test to see if I could reproduce, and I'm not seeing the same speed delays you are. Here is the script I am using:
'use strict'

const {Storage} = require('@google-cloud/storage')
const storage = new Storage()

storage.interceptors.push({
  request: reqOpts => {
    reqOpts.forever = true
    return reqOpts
  }
})

const bucket = storage.bucket('stephen-has-a-new-bucket')
const file = bucket.file('daw.jpg')

const rdStrm = file.createReadStream({ validation: 'crc32c' })

console.time('First data event')

rdStrm
  .once('data', () => console.timeEnd('First data event'))
  .on('end', () => console.log('End'))

I'm on a slow, public wifi connection, and seeing between 800ms and 1600ms.
I wonder if the slowdown has to do with the environment your code is running in, and/or the authentication token fetching step that is performed at the time of the first API request. For the first request, one of our dependencies tries to resolve where your credentials will come from, starting with an environment variable pointing to a file. It could be worth trying to provide a service account JSON key file directly to see if it improves the speed:
- const storage = new Storage()
+ const storage = new Storage({
+   keyFilename: '/path/to/keyfile.json'
+ })

Thanks for the swift response @stephenplusplus
It seems that passing building the storage with the JSON key file does improve the response time. Up until now I've been using the environment variable to handle the authentication.  Any ideas on how to debug this?

I believe the library that would need the most debugging is google-auth-library. Maybe an easier way forward is to see if you can produce the slow speeds when using only that library. Something like:
const {auth} = require('google-auth-library')

// @TODO: replace with a path to your key file
const KEY_FILENAME = '/Users/stephen/dev/key.json'

function getAutoClient() {
  return auth.getClient({
    scopes: 'https://www.googleapis.com/auth/cloud-platform'
  })
}

function getKeyFileClient() {
  return auth.getClient({
    KEY_FILENAME,
    scopes: 'https://www.googleapis.com/auth/cloud-platform'
  })
}

async function getTimeDifference() {
  const run1StartTime = Date.now()
  await getAutoClient()
  const autoClientRunTime = Date.now() - run1StartTime

  const run2StartTime = Date.now()
  await getKeyFileClient()
  const keyFileClientRunTime = Date.now() - run2StartTime

  if (keyFileClientRunTime > autoClientRunTime) {
    console.log(`Fetching the key file client took ${keyFileClientRunTime - autoClientRunTime}ms longer`)
  } else {
    console.log(`Fetching the auto client took ${autoClientRunTime - keyFileClientRunTime}ms longer`)
  }
}

getTimeDifference().catch(console.error)

For me, the auto client always take 5-7ms longer. It would be interesting if something about Windows 7 could be causing a larger time difference here.
Let me know what you find!

Welp, after running your code snippet on two machines (local and server) I get the same results you get.
5-6ms on average, sometimes a 30+ms spike but nothing notable.


All CSS is missing in the "Essential" download of Foundation

I don't know if this should be reported here on Github or elsewhere, but the "Essential" download of Foundation for Sites (at http://foundation.zurb.com/sites/download/assets/essential-f6.zip) is missing all CSS right now.
The css folder used to have a foundation.css, a foundation.css.map and a foundation.min.css. But now there's only the empty app.css.

Thanks for the report! We're looking into it. It will likely be Monday for a patch on this. The full download seems to right.

https://twitter.com/Aetles/status/682148984203403264

Rolling this into #7033


Dalaran's Arcane Well says it has Charge Mana but it doesn't, and Exodar's says it doesn't but it does

There is also no limit on Wells for Dalaran.


Error during setup and running demo

Hi, I was having trouble with the original requirements.txt due to opencv-contrib-python. so I modified it and tried to run the demo. Take a look at the screenshots below. Do you know why it's not working?

torch>=1.4.0
torchvision>=0.5.0
numpy>=1.18.1
scipy>=1.2.1
scenedetect==0.5.1
opencv-python==<IP_ADDRESS>
python_speech_features
ffmpeg
This worked for me


Add-on to create HTPasswdIdentityProvider

With the new minishift feature allowing the users to connect to the Cloud instances, it would be worth allowing the user to change the default all password identity provider to something bit secured like the HTPasswdIdentityProvider.
This requires the minishift to have httpd-tools or similar package to be installed and persisted with the minishift instance.

@minishift/minishift-dev WDYT? this is something I would to see, but we have to be cautious not to become a new way to install a production-like cluster.

https://medium.com/@kamesh_sampath/identify-yourself-on-minishift-c85f5bf8ba7d

IMO we should make it a default add-on.

Optionally we should throw this option out to the user when connecting the could instance via minishift, which can be of better developer experience cautioning the user that he is with default AllowAllPasswordIdentityProvider and need to change to  something secured identity provider.

https://github.com/minishift/minishift-centos-iso/issues/256

WIP

Resolved via https://github.com/minishift/minishift-addons/pull/134

Let's evaluate this after some manuak tests on our end to make/move this to
the minishift repo. WDYT?


Ask : Inception v3

Have you test SSD with other NN for feature extraction like Inception v3 / Resnet ?

Not yet, though I'm planning to. Recently I'm stuck with other stuffs.
You are welcome to submit PR if you like

Just a question, do you prefer a PR on this repos or on the official mxnet/example/ssd ?

Either one is good. I'm rewriting the framework, so later I'll submit PR to official one, don't worry about it.

ok I start from mxnet/example/ssd.
until now, I just

copy/past inception from classification
use the pretrained model from mxnet gallery
made some naive connection between inception and ssd.
and it seem to begin to converge :

INFO:root:Epoch[14] Train-Acc=0.840990
INFO:root:Epoch[14] Train-ObjectAcc=0.464270
INFO:root:Epoch[14] Train-SmoothL1=14.017799
INFO:root:Epoch[14] Time cost=399.309

I use this command to train :
export MXNET_CUDNN_AUTOTUNE_DEFAULT=0 && python2 train.py --gpus 0 --batch-size 16 --network inception_v3 --pretrained model/Inception-7 --lr 0.002

I train with a 1070. I'll try to tune a bit parameters. I accidentally remove the 2 convolutions layer between VGG16 and SSD layer. I need to retest with them. I will update.

I got this result on Pascal VOC after 720 epoch :

inception_v3 after 720 epoch
vgg16_reduced your pretrained version

AP for aeroplane = 0.6638
AP for aeroplane = 0.7215

AP for bicycle = 0.7589
AP for bicycle = 0.7969

AP for bird = 0.6429
AP for bird = 0.7020

AP for boat = 0.5778
AP for boat = 0.6523

AP for bottle = 0.3163
AP for bottle = 0.4272

AP for bus = 0.7721
AP for bus = 0.7791

AP for car = 0.7475
AP for car = 0.8176

AP for cat = 0.8105
AP for cat = 0.8579

AP for chair = 0.4798
AP for chair = 0.5231

AP for cow = 0.6568
AP for cow = 0.7472

AP for diningtable = 0.6972
AP for diningtable = 0.7044

AP for dog = 0.7795
AP for dog = 0.8346

AP for horse = 0.8008
AP for horse = 0.8026

AP for motorbike = 0.7677
AP for motorbike = 0.7706

AP for person = 0.6867
AP for person = 0.7441

AP for pottedplant = 0.4370
AP for pottedplant = 0.4651

AP for sheep = 0.6546
AP for sheep = 0.7340

AP for sofa = 0.7062
AP for sofa = 0.7148

AP for train = 0.8344
AP for train = 0.8400

AP for tvmonitor = 0.6523
AP for tvmonitor = 0.6798

Mean AP = 0.6721
Mean AP = 0.7157

Both are train on trainval data.
evaluation with this command :
export MXNET_CUDNN_AUTOTUNE_DEFAULT=0 && python3 evaluate.py --network vgg16_reduced --batch-size 16 --epoch 0
export MXNET_CUDNN_AUTOTUNE_DEFAULT=0 && python3 evaluate.py --network inception_v3 --batch-size 16 --epoch 720

I cannot say if it's network structure or training hyper-parameters that affected the performance. But this is definitely not optimal. I will join you later.

I'm agree with you it's definitely not optimal
Until now, I test 2 structures :

Inception layer + SSD layer : this network give the previous results
Inception layer + 2 conv layer + SSD layer : this network don't converge

I didn't have the ressource to test lot's of hyper-parameters. So I just search the convergence, I don't optimize them.
In my memory, your repos converge easier and faster than mxnet/example/ssd. I'll try with it soon.

with the ssd version on your repos I got almost the same result :

inception_v3
vgg16_reduced

AP for aeroplane = 0.6528
AP for aeroplane = 0.7215

AP for bicycle = 0.7551
AP for bicycle = 0.7969

AP for bird = 0.6382
AP for bird = 0.7020

AP for boat = 0.5647
AP for boat = 0.6523

AP for bottle = 0.3018
AP for bottle = 0.4272

AP for bus = 0.7858
AP for bus = 0.7791

AP for car = 0.7162
AP for car = 0.8176

AP for cat = 0.8032
AP for cat = 0.8579

AP for chair = 0.4547
AP for chair = 0.5231

AP for cow = 0.6860
AP for cow = 0.7472

AP for diningtable = 0.6667
AP for diningtable = 0.7044

AP for dog = 0.7877
AP for dog = 0.8346

AP for horse = 0.8004
AP for horse = 0.8026

AP for motorbike = 0.7471
AP for motorbike = 0.7706

AP for person = 0.6670
AP for person = 0.7441

AP for pottedplant = 0.4014
AP for pottedplant = 0.4651

AP for sheep = 0.6334
AP for sheep = 0.7340

AP for sofa = 0.6768
AP for sofa = 0.7148

AP for train = 0.8216
AP for train = 0.8400

AP for tvmonitor = 0.6665
AP for tvmonitor = 0.6798

Mean AP = 0.6614
Mean AP = 0.7157

This time I try to finetune and adjust some hyperparameters. But I don't have better result.
Next, I will try to adjust layers in inception structure. Like conv layer between ssd and inception etc ...

Okay, thanks for the updates

I train inception v3 with 2 intermediate layer between inception and ssd part.

class
inception_v3 with intermediate conv layer
inception_v3
vgg16_reduced

AP for aeroplane
0.6580
0.6638
0.7215

AP for bicycle
0.7630
0.7589
0.7969

AP for bird
0.6454
0.6429
0.7020

AP for boat
0.5489
0.5778
0.6523

AP for bottle
0.2983
0.3163
0.4272

AP for bus
0.7682
0.7721
0.7791

AP for car
0.7437
0.7475
0.8176

AP for cat
0.7973
0.8105
0.8579

AP for chair
0.4805
0.4798
0.5231

AP for cow
0.6664
0.6568
0.7472

AP for diningtable
0.6840
0.6972
0.7044

AP for dog
0.7780
0.7795
0.8346

AP for horse
0.8008
0.8008
0.8026

AP for motorbike
0.7704
0.7677
0.7706

AP for person
0.6708
0.6867
0.7441

AP for pottedplant
0.4142
0.4370
0.4651

AP for sheep
0.6536
0.6546
0.7340

AP for sofa
0.6866
0.7062
0.7148

AP for train
0.8338
0.8344
0.8400

AP for tvmonitor
0.6778
0.6523
0.6798

Mean AP
0.6670
0.6721
0.7157

I try to adjust hyper parameters, finetuning but I don't got better result than vgg16.

I am debugging into very finer details these days, and a new release is on the way after that. Let's see if it helps.

Do you think training can be better with larger batch size ?
I still continue to adjust some hyperparameters.

I guess not, during my earlier test, I found larger batch size is not even better. But I cannot assure that.

I've updated the master branch, would you like to try out? It is improving the mAP by 5-6% on the vgg model.

Cool I'll test it as soon as possible maybe tomorrow.

@edmBernard,
Can you share your github where you implemented SSD with inception-v3? Would like to try it as well.

My version of SSD with inception v3 is here : https://github.com/edmBernard/mxnet/tree/master/example/ssd
I don't have time to work on it recently and the results are not so good.

@zhreshold I close the issue. You just add Inception and Resnet in your code
Thanks for your help


matrix multiplication test imes out

mbpro 2019 intel
launch matrix multiplication test (HEAD was 5c73293c8bd6adfaffc44aa6b2a1df11c0b8c78f at the moment)
test fails with timeout in 30 seconds.
reducing matrix size to 800 allows test to be finished in time, but gives inconsistent results (multiplication w/o executor could faster)

interesting, what if u call matrix multiplication 5 times with random numbers for example with 800 size?

with size 100 synchronous multiplication tends to be faster (so the test would fail)
with 800 - it's like 50/50 success rate

It works as expected, with small numbers, 5, 10, sometimes it fails, with large numbers, 50, 100, 1000, the test passes, this is the test:
 Future<void> main() async {
 await workerManager.init(); // I think starting like this improves performance.
 test("_fibonacci calculation", () async {
   final time1 = DateTime.now();
   final _ = [_fib(40), _fib(40), _fib(40), _fib(40)];
   final timeSpend1 = DateTime.now().difference(time1).inMilliseconds;

   final time2 = DateTime.now();
   final results = [
     workerManager.execute(() => _fib(40)),
     workerManager.execute(() => _fib(40)),
     workerManager.execute(() => _fib(40)),
     workerManager.execute(() => _fib(40)),
   ];
   await Future.wait(results);
   final timeSpend2 = DateTime.now().difference(time2).inMilliseconds;
   expect(timeSpend1 > timeSpend2, true);
 });

 test("_matrix multiplication", () async {
   final time1 = DateTime.now();
   _multiplyMatrix();
   _multiplyMatrix();
   final timeSpend1 = DateTime.now().difference(time1).inMilliseconds;

   final time2 = DateTime.now();
   final results = [
     workerManager.execute(() => _multiplyMatrix()),
     workerManager.execute(() => _multiplyMatrix()),
   ];

   await Future.wait(results);
   final timeSpend2 = DateTime.now().difference(time2).inMilliseconds;
   print('timeSpend1-->${timeSpend1}');
   print('timeSpend2-->${timeSpend2}');

   expect(timeSpend1 > timeSpend2, true);
 });
}

int _fib(int n) {
 if (n < 2) {
   return n;
 }
 return _fib(n - 2) + _fib(n - 1);
}

List<List<double>> _multiplyMatrix() {
 int size = 1000;
 final random = Random();

 List<List<double>> matrix1 = List.generate(
   size,
   (_) => List.generate(size, (_) => random.nextDouble()),
 );
 List<List<double>> matrix2 = List.generate(
   size,
   (_) => List.generate(size, (_) => random.nextDouble()),
 );

 final result = List.generate(size, (_) => List.filled(size, 0.0));
 for (int i = 0; i < size; i++) {
   for (int j = 0; j < size; j++) {
     double sum = 0.0;
     for (int k = 0; k < size; k++) {
       sum += matrix1[i][k] * matrix2[k][j];
     }
     result[i][j] = sum;
   }
 }
 return result;
}


fix(observable): ensure the subscriber chain is complete before calling this._subscribe

Description:
If an operator subscriber completed (or unsubscribed) early after receiving values from a synchronous source, the subscribers upstream weren't disposed until after returning from the source's subscribe function. When any downstream subscriber unsubscribes, the upstream subscribers should be notified immediately and unsubscribe all the way to the source subscription.
Related issue (if exists):
@zenparsing pointed this out in #1513
cc: @blesh

once that one small change to the tests is in, LGTM.

merged with e66b2d8, thanks @trxcllnt

SHA seems 1631224 .


Better README

Hey, your library is really interesting.
The only problem I found was the README.md, which lacks information.
I created this iOS Open source Readme Template so you can take a look on how to better organize.
If you want, I can help you to do it.
What are your thoughts?

@lfarah - Thanks for the suggestion. I've added the necessary details to the README.md

Everything is perfect now! 👏


Add missing python kernel to regression notebooks.

https://github.com/awslabs/aws-orbit-workbench/pull/813


licenseing?

There's no LICENSE and no mention of licensing terms in the README. Since there's no setup.py, it's not there either :)
What terms is this code under?

Awesome, thank you, @dasevilla !


Add note about Node version in CONTRIBUTING

While following the CONTRIBUTING guide I found I was unable to run the build or test scripts on Node v12 LTS. Installing Node v14 allowed the scripts to run.

🎩 Thank you, @arempe93!


drive Md5 update issue

 First off, awesome work.  This program gets better every time I check in on it.  I was on 0.1.0 so I've been playing with some of the new features.
 So the md5 checksum is a great idea.  I was going through the main page and saw the difference example

diff -y <(drive md5sum) <(md5sum *)
So I ran this, saw the differences and then did
drive push -ignore-conflict
Then I go back to
diff -y <(drive md5sum) <(md5sum *)
and Its reporting the same differences.  So back to
drive push -ignore-conflict
Resolving...
Everything is up-to-date.
Hopefully I am using this correctly and not just having a big brain fart.  If so I'm sure its a small bug but could cause somebody some undue head scratching if they are setting up scripts etc.  Thanks again for the great app and keep up the good work.

Hello @DenomZero, welcome to drive. Thank you for the kind words.
So with --ignore-conflict you are actually ignoring conflicts that might exist, would you mind repeating the example without --ignore-conflict?

Id like to apologize in advance for the text formatting.  Its a direct copy from the terminal.
diff <(drive md5sum) <(md5sum *)
md5sum: Work: Is a directory
2,3c2,3
< 08b77fe2cc80d31727fa6e719fab30ab  Notes.ctb
< 124f8844cf54b83960c5d7e4ac99c809  Notes.ctb~

a24202bb90760bac887cb3b4052ebf90  Notes.ctb
ba51065dcf4a07a152940f1e35904135  Notes.ctb~

drive push
Resolving...
M /Documents/Notes.ctb~
M /Documents/Notes.ctb
Modification count 2 src: 230.00KB dest: 230.00KB
Proceed with the changes? [Y/n]:y
235520 / 235520 [===============================================================================================] 100.00 % 1s

diff <(drive md5sum) <(md5sum *)
md5sum: Work: Is a directory
2,3c2,3
< 08b77fe2cc80d31727fa6e719fab30ab  Notes.ctb
< 124f8844cf54b83960c5d7e4ac99c809  Notes.ctb~

a24202bb90760bac887cb3b4052ebf90  Notes.ctb
ba51065dcf4a07a152940f1e35904135  Notes.ctb~

I can't seem to reproduce this issue, sure that swap file isn't being modifed quite a bit. Also since after the second push you no longer have changes, makes me think that it might just be the noise from different depth traversals and encountering directories by md5sum.
Here might be something to cut down the noise:
Okay, so md5sum works on files and not directories. However drive md5sum will traverse folders present remotely as deep as the default ie 1. You can control the traversal depth like this
drive diff --depth <n> where n is an integer
As you can see from your warnings md5sum tries to traverse a dir. You can cut out all this noise by level traversals and comparisons of something wild like
$ function differ() { if [[ $# -lt 2 ]]; then echo "<dir> <depth>";return;fi;dir=$1;depth=$2;diff <(drive md5sum --depth $depth $dir) <(md5sum $(find $dir -maxdepth $depth -type f));}
$ differ . 2 # Now you can use this differ function

In the future I plan on making drive self contained because right now the diff with md5sum example's right hand only works on Linux, on OS X md5 behaves differently. Also that would cut out all the fiddling and error prone typing.

@DenomZero are you certain that the push works? If you push twice in a row, does the second push report "Everything is up to date"?

Ping @DenomZero

Closing this issue as it seems more like a usage problem. Re-open if persists.

Ok this isnt really an md5 issue so much as it is an update issue.  I use CherryTree to make notes so it's modified regularly.
To recreate the issue with cherry tree first create a new doc and put some test data into it.  Save it as sqlite unprotected file, push it, great.  I leave cherry tree open this whole time.  Modify the document with more test data example Tree->Insert todays node and then more test data, then save.  Push the data.  Looks good, because it says it worked.  Close cherry tree and force pull the data.  Open your test document and the modifications are gone.  Im sure this is why the md5 checksum isnt jiving but I am unable to get the push to work on this file a 2nd time, I always just assumed it was working.
Sorry for the long delay I dont have the most free time.  It might be worth moving this to a new issue as the md5 helped me find this issue.