How can I make a bootstrap panel in reactstrap?

I have this old code which I now want to use in react. However there doesn't seem to be support anymore for headers. Does reactstrap have a solution for this?

Title

Body

Cards replaced panels and more in Bootstrap 4.

If you’re familiar with Bootstrap 3, cards replace our old panels, wells, and thumbnails. Similar functionality to those components is available as modifier classes for cards.

Card Header and Footer is how cards are used in a similar way to panels.
In reactstrap, there are similar examples, here is how it would be done:
    <Col sm={6}>
      <Card>
        <CardHeader>Title</CardHeader>
        <CardBlock>
          <CardText>Body</CardText>
        </CardBlock>
      </Card>
    </Col>

I've used the card and collapse component to get accordion flavor - check out (https://github.com/yasharma/reactstrap-card-accordion)
<Card style={{ marginBottom: '1rem' }} key={index}>
      <CardHeader onClick={this.toggle} data-event={index}>Header</CardHeader>
      <Collapse isOpen={collapse === index}>
            <CardBody>
            Anim pariatur cliche reprehenderit,
             enim eiusmod high life accusamus terry richardson ad squid. Nihil
             anim keffiyeh helvetica, craft beer labore wes anderson cred
             nesciunt sapiente ea proident.
            </CardBody>
      </Collapse>
</Card>

use toggle as like
toggle(e) {
      let event = e.target.dataset.event;
      this.setState({ collapse: this.state.collapse === Number(event) ? 0 : Number(event) });
}

Hope this helps


Warning for signal group mode.

#712

Hello @samuelgarcia! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file neo/io/basefromrawio.py:

Line 111:100: E501 line too long (104 > 99 characters)


Creatability

For viewing and discussion in class today!
https://experiments.withgoogle.com/collection/creatability

#8


Usage instructions

What are the exact steps to create a cluster in aws? I mean which variables I should change to run a cluster? I could not be sure that about this. Should I change io.tf file? Because I have seen some variables on makefile too. What is the proper way to bootstrap a cluster?

at a minimum, you can clone this repo and run
make all
this will use default variables. you can over ride them in the root Makefile like this.
make AWS_REGION=eu-west-1 CLUSTER_NAME=my-k8s-cluster all

What about the variables such as account-id, azs?  I can see some variables empty. What should I do for them?

ignore everything outside of the Makefile. That will take care of the other variables.

I have just seen necessary configurations. Thanks.


Not compatible with latest 9.0 EAP

Says incompatible version :(
https://confluence.jetbrains.com/display/PhpStorm/PhpStorm+Early+Access+Program

Same here :(
I really like your plugin and i don't want to downgrade :(

Fixed in 0.4.2


You must have bower installed to continue.

I would like to try the the new beta8, so I cloned the ionic-conference-app and I did a npm install and I tried to add the ionic-platform-web-client but I've got this message:
PS C:\Projects\ionic-conference-app> ionic add ionic-platform-web-client
(node:12000) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please u
pdate it to a more recent version.

You must have bower installed to continue.
Type `npm install -g bower` (CLI v2.0.0-beta.30)

Your system information:

Cordova CLI: 6.2.0
Ionic Framework Version: 2.0.0-beta.8
Ionic CLI Version: 2.0.0-beta.30
Ionic App Lib Version: 2.0.0-beta.16
OS:
Node Version: v6.2.0

Sadly bower is already installed :(

PS C:\Projects\ionic-conference-app> npm install -g bower
C:\Users\Matteo Spreafico\AppData\Roaming\npm\bower -> C:\Users\Matteo Spreafico\AppData\Roaming\npm\node_modules\bower\
bin\bower
C:\Users\Matteo Spreafico\AppData\Roaming\npm
`--<EMAIL_ADDRESS>
PS C:\Projects\ionic-conference-app> ionic add ionic-platform-web-client
(node:13460) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please u
pdate it to a more recent version.

You must have bower installed to continue.
Type `npm install -g bower` (CLI v2.0.0-beta.30)

Your system information:

Cordova CLI: 6.2.0
Ionic Framework Version: 2.0.0-beta.8
Ionic CLI Version: 2.0.0-beta.30
Ionic App Lib Version: 2.0.0-beta.16
OS:
Node Version: v6.2.0

The same here:
ionic add platform android --verbose
Task: title=add, name=add, summary=Add an Ion, bower component, or addon to the project, [name]=The name of the ion, bower component, or addon you wish to install, isProjectTask=true, run=function run(ionic, argv) {
if (!bower.checkForBower()) {
appLibUtils.fail(bower.installMessage, 'add');
return;
}
var componentName = argv._[1];
var ioSet = false;
try {
ioSet = true;
installBowerComponent(componentName);
} catch (error) {
var errorMessage = error.message ? error.message : error;
appLibUtils.fail(errorMessage, 'service');
}
// Inject the component into our index.html, if necessary, and save the app_id
ioLib.injectIoComponent(ioSet, componentName);
ioLib.warnMissingData();
}
Looking up Ionic root, cwd: /Users/dudu/Documents/Desenvolvimento/IonicApps/MyFirstApp
Ionic root directory:  /Users/dudu/Documents/Desenvolvimento/IonicApps/MyFirstApp
Gulpfile found
Utils.fail You must have bower installed to continue.
Type npm install -g bower add
Utils.fail stack undefined
Utils.errorHandler is set, calling that now
Cli.Utils.errorHandler msg You must have bower installed to continue.
Type npm install -g bower string
You must have bower installed to continue.
Type npm install -g bower (CLI v2.0.0-beta.30)
Your system information:
Cordova CLI: You have been opted out of telemetry. To change this, run: cordova telemetry on.
6.2.0
Ionic Framework Version: 2.0.0-beta.8
Ionic CLI Version: 2.0.0-beta.30
Ionic App Lib Version: 2.0.0-beta.16
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v4.3.1
Xcode version: Xcode 7.3.1 Build version 7D1014
bower --version
1.7.9

Same issue for me!

@duduBaiao you're using a wrong command by the way...
It should be ionic platform add android and NOT ionic add platform android (platform is before add)

@matsprea: when you find this issue you can simply add that library using normal bower commands:
bower install --save ionic-platform-web-client

Hi guys! The solution is simple.
I have just typed:
cordova telemetry on
After that, Ionic was able to detect Cordova version.

commit 9de215758874c856d3220c924e908c10b94e322e.
Thank you for helping identify this issue!  I have resolved the problem and it will be fixed in the next CLI release which should be pushed in the next day or two.  Thanks for being patient, and I apologize for any inconvenience this might have caused.

I just published beta.31.  Please update. Thanks!

I've got a different error, but it's not working for me (on the vanilla ionic-conference-app)
PS D:\Progetti\ionic-conference-app>  ionic add ionic-platform-web-client --verbose
Task: title=add, name=add, summary=Add an Ion, bower component, or addon to the project, [name]=The name of the ion, bow
er component, or addon you wish to install, isProjectTask=true, run=function run(ionic, argv) {

  // This command will be deprecated in the future.
  var deprecationMsg = 'This command has been ' + 'deprecate'.red + '.  All ' +
   'resources are currently available in NPM and we recommend that you use NPM to manage these.\n' +
   'More information is available here: https://github.com/driftyco/ionic-cli/wiki/Migrating-to-NPM-from-bower\n';
  log.info(deprecationMsg.bold);

  if (!bower.checkForBower()) {
    appLibUtils.fail(bower.installMessage, 'add');
    return;
  }

  var componentName = argv._[1];
  var ioSet = false;

  try {
    ioSet = true;
    installBowerComponent(componentName);
  } catch (error) {
    var errorMessage = error.message ? error.message : error;
    appLibUtils.fail(errorMessage, 'service');
  }

  // Inject the component into our index.html, if necessary, and save the app_id
  ioLib.injectIoComponent(ioSet, componentName);
  ioLib.warnMissingData();
}
Looking up Ionic root, cwd: D:\Progetti\ionic-conference-app
Ionic root directory:  D:\Progetti\ionic-conference-app
(node:7240) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please up
date it to a more recent version.
Gulpfile found
This command has been deprecate.  All resources are currently available in NPM and we recommend that you use NPM to mana
ge these.
More information is available here: https://github.com/driftyco/ionic-cli/wiki/Migrating-to-NPM-from-bower

Utils.fail Bower error, check that "undefined" exists,
or try running "undefined" for more info. add
Utils.fail stack undefined
Utils.errorHandler is set, calling that now
Cli.appLibUtils.errorHandler msg Bower error, check that "undefined" exists,
or try running "undefined" for more info. string

Bower error, check that "undefined" exists,
or try running "undefined" for more info. (CLI v2.0.0-beta.31)

Your system information:

Cordova CLI: 6.2.0
Ionic Framework Version: 2.0.0-beta.9
Ionic CLI Version: 2.0.0-beta.31
Ionic App Lib Version: 2.0.0-beta.17
OS:
Node Version: v6.2.0

Thanks @Zorgatone your workaroud works!

hi all,
@Zorgatone you are right-
I have used wrong command as-
- ionic platform add android
-  ionic add platform android
it work for me.
thanks


Multi-Click Selection: Triple-Click Settings + Viewport Selection

Summary of the Pull Request
Introduces "viewport selection" which creates a selection of the entire viewport. Also, adds per-profile settings to decide whether a triple-click performs a line selection or viewport selection (disabling it is also an option).

References
Builds on #1197. Similar to #1273.
Closes #1084.

PR Checklist

[ ] Closes #1084
[ ] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.

Detailed Description of the Pull Request / Additional comments

TerminalSettings:

add property to winrt TerminalSettings

Terminal App:

read/write JSON for this new property
default set to line selection

TerminalCore:

import/use selection mode from ICoreSettings
perform proper action

UnitTests_TerminalCore:

Added setting to MockTermSettings

Validation Steps Performed

modified profiles.json. Then performed triple click in an instance of that profile

I mean I'm not totally convinced that triple click needs a settable behavior. The linked thread isn't super relevant to making this a preference that customers are actually looking for.

Honestly, it'd probably just be better to have this functionality come in after we do pointer bindings (#1553 ). Then you could just set the behavior you want on a triple click. Should we just back this out then?

I also don't know why you just didn't go for broke at this point and put viewport on quadruple click and the entire buffer on quintuple click and the entire known universe of data on sextuple click or something.

We can doesn't mean we should. I don't think I've ever actually seen anything have 4+ click functionality.

Abandoning this PR so that it can be done right/better with pointer bindings.


[WIP] Add a withdrawn field to all document types

This will allow us to include withdrawn documents when we do content audits.
https://trello.com/c/RkrlGszq/473-keep-items-in-search-index-when-withdrawn-but-not-redirected
If is_withdrawn is set on a content item, it is not returned by searches, except if a debug flag is passed in.
When we do a basic search, the elasticsearch query is built up in parts. I've refactored the Filter component so that it delegates to a UserFilter and a VisibilityFilter, where VisibilityFilter contains a query to exclude the withdrawn content.
UserFilter is responsible for building up filters from the search params. There was a bunch of reusable code here that used to be private methods of this component. They all manipulate hashes that are serialised into JSON for the elasticsearch request. I've moved them out into a mixin in the elasticsearch module so I can reuse them in Filter and VisibilityFilter. If there is a better place for this let me know. I suspect there might be some duplication with the advanced search logic, which has its own builder class.
#filter_hash is slightly different, because this operates on another class object representing a filter that is created in the search parameter parser. I've left this as a private method of the UserFilter for now but it may make sense to move this method to the filter object itself.
I still need to have a look at advanced searches as they are handled differently.

:+1: very nice!
It might be worth it to add a integration test. That could be something like:
def test_withdrawn_content
  reset_content_indexes

  commit_document("mainstream_test",
    title: "I am the result",
    description: "This is a test search result",
    link: "/some-nice-link",
    withdrawn: true
  )

  get "/unified_search?q=test"
  assert_equal 0, parsed_response.fetch("total")
end

def test_withdrawn_content_with_flag
  reset_content_indexes

  commit_document("mainstream_test",
    title: "I am the result",
    description: "This is a test search result",
    link: "/some-nice-link",
    withdrawn: true
  )

  get "/unified_search?q=test&debug=include_withdrawn"
  assert_equal 1, parsed_response.fetch("total")
end


feature: Disable UI / Non-interactive mode

Did you check the docs?

[X] I have read all the lazy.nvim docs

Is your feature request related to a problem? Please describe.
Is is possible to disable all UI / put lazy.nvim in non-interactive mode? This is particularly useful for some cases like using neovim in vscode (VSCode-Neovim).
Describe the solution you'd like
Set ui = false or ui = {} disables UI.
Describe alternatives you've considered
Set interactive = false disables UI.
Additional context
No response

I don't get why you'd want this. If you do :Lazy then the ui should always start. Do you mean the install missing? You can configure that setting differently when running inside vscode.

I don't get why you'd want this. If you do :Lazy then the ui should always start. Do you mean the install missing? You can configure that setting differently when running inside vscode.

packer.nvim has a display.non_interactive option to turn off all UIs (basically the popup window). I'm planning to switch to lazy.nvim and wonder if we can also add this option if possible?
The reason of adding this option is to allowing disable TUIs (popup / floating windows, etc) from showing up, which can stuck the cursor in vscode if you use it with neovim because vscode don't render TUI and your cursor will be stuck in the floating window opened by lazy.nvim in the neovim client running in the background which is not visible to the you.

I second this feature request. The primary reason is because I don't want to wait for 20 seconds before all git fetch  commands have completed before I can use Neovim. There are consistently one or two tasks that take > 20s to complete on every run of :Lazy update (which seems to be a Git issue).


dependabot doesn't update quay images

Package ecosystem
docker
Package manager version
brew (but is irrelevant)
Language version
Irrelevant
Manifest location and content prior to update
Irrelevant
dependabot.yml content
# https://docs.github.com/en/github/administering-a-repository/configuration-options-for-dependency-updates
version: 2
updates:
//- directory: "/"
//  labels:
//  - "dependency"
//  package-ecosystem: "github-actions"
//  schedule:
//    interval: "daily"
- directory: "/"
  labels:
  - "dependency"
  package-ecosystem: "docker"
  schedule:
    interval: "daily"

Updated dependency
Irrelevant
What you expected to see, versus what you actually saw
I expect that quay.io version updates will create a PR that will bump the version
Native package manager behavior
Irrelevant
Images of the diff or a link to the PR, issue or logs
no link to PR because none were made
🕹 Bonus points: Smallest manifest that reproduces the issue
# Dockerfile
FROM: quay.io/app-sre/ubi8-ubi-minimal:8.3-201
# it should update to 8.5-204 at the least

# dependabot file
version: 2
updates:
- directory: "/"
  labels:
  - "dependency"
  package-ecosystem: "docker"
  schedule:
    interval: "daily"

I think this is caused by quay not correctly implementing pagination according to the docker spec, which causes the library we use for interacting with the registry to not paginate quay responses correctly, it's covered in https://github.com/dependabot/dependabot-core/issues/3989. Will likely need to be fixed upstream, preferably by Quay themselves (but seems unlikely), and otherwise in https://github.com/deitch/docker_registry2/issues/56#issuecomment-869496320.
I'm going to close this issue as I've reopened https://github.com/dependabot/dependabot-core/issues/3989, and that has more context.


ref: SfSelect to be native

Related issue

Closes #1334
Scope of work
Change all current SfSelect appearances to SfComponentSelect.
Screenshots of visual changes
Checklist

[x] No commented blocks of code left
[x] Run tests and docs
[x] Self code-reviewed

Removed props: size, persistent, valid, errorMessage. Added: placehloder. Styling is not completely adjusted to current desgin.

Can you also posts creenshots on desktop/mobile?


Allow changing description string in Interfaces > Assignments

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
As my OPNsense configuration evolves, the original description given in Interface assignments may no longer be correct. However, I cannot change it without removing the assignment and recreating it (which I am reluctant to do, because I don’t know if any references to that interface will still be correct after that).
Describe the solution you like
I would like an edit button in the list of assigned interfaces, which lets me change the description without removing/recreating the assignment.
Describe alternatives you considered
So far, the hackish workaround is to download the configuration, doctor it in a text editor (altering the strings as needed) and reimport it – not very elegant.
Additional context
The description is widely used throughout the GUI, therefore it is desirable to keep it up to date. On the other hand, internal references are by interface name (optXX), therefore the string would need to be changed in only one place. Issues may occur only if parts of the UI cache the string – this would need to be investigated if (and where) that happens, and the cache invalidated if the string changes.

I think this https://github.com/opnsense/core/issues/7522 ticket is quite similar, assuming you don't mean the description (which can be changed from the interface), but the technical name.

I mean the string that appears in Interfaces > Assignments, in the Interface column (LAN or the like, not opt1). Thanks to your comment, I just found it can be changed by navigating to Interfaces > [LAN] (replace with the interface description), but the Assignments list suggest that this cannot be changed.
Good to know the functionality is there, but UX could be improved. How about an edit button for every entry in Interfaces > Assignments, next to the delete button, which then takes you straight to Interfaces > []?

I'm not too enthusiastic about changing things in these legacy pages if the functionality is already available, risk of regressions usually doesn't outweigh the gain in usability.

Legacy? What is the recommended replacement for Interfaces > Assignments?

there is no replacement, but if we will probably replace it someday, as we did for a most of the legacy pages (in the browser ending at .php).


include_directory fix for manifest and setup.py

extracted explicit root_path in order to fill manifest and setup.py only with relative paths according to package structure

see comments on #127 (which is already closed)

Coverage decreased (-2.1%) to 70.319% when pulling 8c02ea4d410d2aebad40edf84f59fcc289fe4928 on cowst:master into a6bcbd6ceac90a8dcb48524f6c00d0770a6e285f on pybuilder:master.

Thank you @cowst , I'm merging this as it looks good. Sorry it took a while.

Could someone please post an example, or a link to one, for how this is supposed to work?
I'm using project.include_directory('mosaicsmartdata/configuration', ['*.csv']) in my build.py, where the path is relative to dir_source_main_python, and the files are copied over to target/dist/..../mosaicsmartdata/configuration, but not installed.
Using pybuilder 0.11.10
Thanks a lot!

+1
The directory is included but not installed.

Install "pybuilder" using "-U -pre" ?


Theme: .NET is recognized as a compelling framework for building cloud native apps

Today, .NET is seen as a stack for enterprises building LOB applications. “.NET is for people who work at banks” is not uncommon feedback in our customer interviews. We plan to change that by building great fundamentals and investing in OSS ecosystems that give us a platform to reach new customer bases. At the same time our existing enterprise customers want to become more Cloud Native, and we need to flatten the learning curve and barriers to adoption.
Scenario Areas

[ ] Improve development experience for multi-app solutions
[ ] .NET Apps can depend on containers in Dev
[x] microsoft/reverse-proxy#480
[x] dotnet/aspnetcore#27724
[ ] Libraries to interop with common cloud native components/services
[x] dotnet/core#5443
[x] dotnet/core#5424
[x] dotnet/core#5434
[ ] dotnet/core#5929
[ ] dotnet/efcore#24110

Related Epics

[ ] dotnet/aspnetcore#27226

@glennc I added the Metrics story.

I would like to suggest adding a distroless distribution also. See:

https://github.com/GoogleContainerTools/distroless/issues/512
https://michaeldimoudis.medium.com/hardening-asp-net-core-3-1-docker-images-f0c2ede1667f

I am thinking specifically a hardened image, but size and performance are likely improved also.

I would like to suggest adding a distroless distribution also. See:

https://github.com/GoogleContainerTools/distroless/issues/512
https://michaeldimoudis.medium.com/hardening-asp-net-core-3-1-docker-images-f0c2ede1667f

I am thinking specifically a hardened image, but size and performance are likely improved also.

Feature Request: Drop-in component for ASP Identity Administration, Portals, UI, SSO, Claims, AD-Sync, Token, Multi.Tenant Management so that the Visual Studio templates don't require commercial licensed 3rd party components.
I have been watching/waiting few yrs. patiently, however some recent changes have forced me to request -- Microsoft revisit this for their developer community, keeping in mind some of the pricing out there compares to the salaries of 10 to 15 developers in Bangladesh, Vietnam, India, Philippines etc.
Its a Core & Basic need, yet very complex and critical for the developer, with security risks.
There's a void in .NET native drop-in solution, unlike the Java, PHP Stacks etc, where there are many native drop in Identity Administration & Management Frameworks options that are leveraged across all their platforms seamlessly by developers, for e.g. the J2EE Pluggable Identity Management Framework or JSR 168 or JSR 286 or JSR-351 or JSR-375.
Why is this important? because using Java or PHP, it has allowed easy, clear, core and basic functionalities in those native stacks. As a result if you look JSR 168 or JSR 286 or JSR-351 or JSR-375 Multi-tenants, Group to roles, or to claims vice versa is so easy vs. NET , mobile devices, portals, they all work seamlessly and cohesively with security fixes managed by either IBM or SalesForce or Oracle or Red Hat etc. This is enables developer to be productive right out of the gate.
In .Net there is void/very limited support, always requiring a combination of 3rd parties as a barrier to entry & adoption of ASP app. This is non-trivial for developers and security vulnerability that requires the attention of Microsoft Experts.
Example: We have private information sharing site non OSS for the community almost free (pay if you want), and when we started with web forms, then Simple Membership, the Identity, Identity 2 ASP MVC we had implement much of it on top of these from scratch, when we moved to .NET Core it was another effort. Besides the development there was a lot of confusion on the internal concepts and how they now meant new things. Roles, Claims, Federation, SAML then SAML 2.0 and then Open ID 2.
Describe the solution you'd like

In-house (Microsoft made) -- A drop-in is extensible solution that supports ASP MVC Identity eco-system, Administration, GUI, SSO, Token, Multi-tenant Management, independent of 3rd party companies and Identity Servers

A configuration section to turn on-off the various features.

Embedded into VS Templates (remove Identity Server, use native MS option etc.)

Allow-Easy AD Active Directory Integration

 User Defined/Created Fields UDF - dynamic fields in web apps from the Admin level Support.

The current options and the pricing eliminate many of the existing applications from continuing usage on the .NET stack without extensive retooling or completely abandoning the MS framework.

SAML2/CAS per @tbonham

Allow template option Configuration.MultiTenancy.IsEnabled = true; [Global DataFilter for Tenant entities](https://github.com/zzzprojects/EntityFramework.DynamicFilters)

Streaming events or video Support for e.g. from Kafka

Dashboard platform with Widgets and settings
Dynamically creating and adding components. Angular ComponentFactoryResolver alternative.
Provide a built-in or otherwise framework supplied mechanism for View Components, when rendered via a tag helper, to render user-supplied child content that can be injected into the View Component's view template in pre-defined locations

Its high time MS address this core gate-keeping feature!!

Bulk closing .NET 6 epics and user stories. If you think this issue was closed in error, please reopen the issue and update it accordingly.


Enable Binned LC Plots

Working with datasets that have many integrations makes it difficult to see what's going on in the light curve plots.  So, when meta.nbin_plot is given, the light curves in all figures are now binned to the desired time resolution.  Before, only some plots were binned.
I also updated the jwst version to 1.8.2.  Version 1.9 appears to still be buggy.

Codecov Report

Merging #512 (c0ca3fb) into main (a3ca120) will increase coverage by 0.03%.
The diff coverage is 90.90%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
+ Coverage   58.18%   58.22%   +0.03%
==========================================
  Files          91       91
  Lines       10899    10913      +14
==========================================
+ Hits         6342     6354      +12
- Misses       4557     4559       +2

Impacted Files
Coverage Δ

src/eureka/S5_lightcurve_fitting/likelihood.py
68.68% <ø> (ø)

src/eureka/S5_lightcurve_fitting/lightcurve.py
87.85% <87.50%> (-0.27%)
:arrow_down:

src/eureka/S5_lightcurve_fitting/plots_s5.py
79.88% <91.66%> (+0.17%)
:arrow_up:

...c/eureka/S5_lightcurve_fitting/gradient_fitters.py
85.40% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I'm going on vacation until April 12th, so you're welcome to make changes to this PR while I'm gone.
I support having Figures 5104 and 5304 as separate plots.

Can you clarify what you mean by "I support having Figures 5104 and 5304 as separate plots."? To clarify my question, I had meant do we want to:

have fig5104 (just binned data) and fig5304 (binned data with unbinned data in the background) equivalents for all the figures you've changed, or
just have the fig5014 (just binned data) equivalents that you've made

Ok, now I see what you're asking.
For the 3 panel plot (raw, normalized, residuals), I would prefer using only the binned data so that the default ylim range gives meaningful information.
I'm ok with plotting both for the single-panel light curve.

Okay, I'll try to make both for the single-panel lightcurve if I find the time before you get back.


tidy up all those channels by using a context instead

this is what I was thinking

resolved conflicts

good to go?


mssql container doesn't work anymore.

i'm on mac.
round about two weeks my mssql docker container doesn't start.
if I start the container, i get this error:
Error: The evaluation period has expired.
This program has encountered a fatal error and cannot continue running.
The following diagnostic information is available:
2018-02-09T14:50:24.040679190Z
       Reason: 0x00000001
       Signal: SIGSEGV - Segmentation fault (11)
   Stacktrace:<PHONE_NUMBER>fa8ce7 00007f2816ace390<PHONE_NUMBER>fb7f52
<PHONE_NUMBER>fa16db<PHONE_NUMBER>fa0e59
      Process: 8 - sqlservr
       Thread: 25 (application thread 0x1040)
  Instance Id: 12906028-a25c-411f-8da3-02b3d350401b
     Crash Id:
  Build stamp: a37664e45e4156e76a53fa282fd694cb49f70c2037515f5684e3ce6dfa7549bc
Aborted

image: microsoft/mssql-server-linux
tag: latest
Can anybody help me?

Try deleting your image and pulling latest again.
From phone. Please excuse brevity.

From: wa3bo<EMAIL_ADDRESS>Sent: Friday, February 9, 2018 6:52:23 AM
To: Microsoft/mssql-docker
Cc: Subscribed
Subject: [Microsoft/mssql-docker] mssql docker images doesn't work anymore. (#257)
round about two weeks my mssql docker container doesn't start.
if I start the contaier, i get this error:
Error: The evaluation period has expired.
This program has encountered a fatal error and cannot continue running.
The following diagnostic information is available:
2018-02-09T14:50:24.040679190Z
Reason: 0x00000001
Signal: SIGSEGV - Segmentation fault (11)
Stacktrace:<PHONE_NUMBER>fa8ce7 00007f2816ace390<PHONE_NUMBER>fb7f52
0000557307fa16db<PHONE_NUMBER>fa0e59
Process: 8 - sqlservr
Thread: 25 (application thread 0x1040)
Instance Id: 12906028-a25c-411f-8da3-02b3d350401b
Crash Id:
Build stamp: a37664e45e4156e76a53fa282fd694cb49f70c2037515f5684e3ce6dfa7549bc
Aborted
image: microsoft/mssql-server-linux
tag: latest
Can anybody help me?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fmssql-docker%2Fissues%2F257&data=04|01|twright%40microsoft.com|63e2ded95fea4360f6ef08d56fccbacc|ee3303d7fb734b0c8589bcd847f1c277|1|0|636537847455173344|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=unKFgWg%2B7kiXf8raIR5dPMaTQGQ5Jip5A3agSRytV48%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOSzJmITsimRF2NeASMwwLDaLu14OJjjks5tTFungaJpZM4SACID&data=04|01|twright%40microsoft.com|63e2ded95fea4360f6ef08d56fccbacc|ee3303d7fb734b0c8589bcd847f1c277|1|0|636537847455173344|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=NyZ88t2B8FMBNBujxvt8ay3MI64AQwCZJc2WfxpHKiQ%3D&reserved=0.

Thank you. now it's work again.


[BACKLOG-6753] Change MDI behavior for non-exist steps, fields and key to don't fail transformation

@bmorrise Merge it, please


Browserified bundle generates a client-side error

I am attempting to Browserify livereload-js like so;
var lr = require('livereload-js');

When I include the resulting bundle in a webpage I get the following error in Chrome
Uncaught TypeError: Cannot read property 'addPlugin' of undefined

The error originates from https://github.com/livereload/livereload-js/blob/master/src/livereload.coffee#L133
I'm using Chrome 40.0.2214.93, Browserify 8.1.3, and node v0.10.28
Also on IE 11

Hey, I think I've fixed this — please try version 2.2.2.
You do need to add a bit of extra stuff to your bundle, please see the updated Browserify section in README.


Get order by id does not work for all exchanges (e.g. Kucoin)

Dear Catalyst Maintainers,
Description of Issue

What did you expect to happen?
API method TradingAlgorithm::get_order to work for exchanges that require the order direction as a parameter (SELL or BUY) (e.g. Kucoin)

What happened instead?
The get_order method fails when getting order from kucoin.

Here is how you can reproduce this issue on your machine:
Just place any order on Kucoin and try to get it by id
What steps have you taken to resolve this already?
Add additional argument params to the get_order method signature:
def get_order(self, order_id, exchange_name, symbol=None, params={})
This allows the client to optionally specify additional parameters required by the exchange (similiar to the cancel_order signature)
Cheers,
Red Eagle

Thanks @red-eagle-eye for reporting.
What catalyst version and CCXT version are you using?

Thanks for reporting and suggesting the workaround. It was added to our develop branch and will be included in our next release.
An example of using get_order with KuCoin, for future reference:
get_order('1234567890' , 'xlm_btc', params={'type': 'BUY'})
thanks again,
Embar

Added to release 0.5.19


Bounds out of range while parsing ASRock A520M HVS 1.31 firmware

as discussed @orangecms
panic: runtime error: slice bounds out of range [:8796093022208] with capacity 9821616
wasm_exec.js?5580:56
wasm_exec.js?5580:56 goroutine 6 [running]:
wasm_exec.js?5580:56 github.com/linuxboot/fiano/pkg/uefi.NewFirmwareVolume({0x12a2250, 0x95ddb0, 0x95ddb0}, 0x6a2250, 0x0)
wasm_exec.js?5580:56 	/Users/cwerling/Git/fiedka/pkg/mod/github.com/linuxboot/fiano@v5.0.0+incompatible/pkg/uefi/firmwarevolume.go:257 +0x7b
wasm_exec.js?5580:56 github.com/linuxboot/fiano/pkg/uefi.NewBIOSRegion({0xc00000, 0x1000000, 0x1000000}, 0x0, 0x0)
wasm_exec.js?5580:56 	/Users/cwerling/Git/fiedka/pkg/mod/github.com/linuxboot/fiano@v5.0.0+incompatible/pkg/uefi/biosregion.go:115 +0x35
wasm_exec.js?5580:56 github.com/linuxboot/fiano/pkg/uefi.Parse({0xc00000, 0x1000000, 0x1000000})
wasm_exec.js?5580:56 	/Users/cwerling/Git/fiedka/pkg/mod/github.com/linuxboot/fiano@v5.0.0+incompatible/pkg/uefi/uefi.go:153 +0x4
wasm_exec.js?5580:56 main.utka({{}, 0x0, 0x0}, {0x4244e0, 0x2, 0x3})
wasm_exec.js?5580:56 	/Users/cwerling/Git/fiedka/src/main.go:55 +0x10
wasm_exec.js?5580:56 github.com/happybeing/webpack-golang-wasm-async-loader/gobridge.registrationWrapper.func1({{}, 0x0, 0x0}, {0x4244e0, 0x3, 0x3})
wasm_exec.js?5580:56 	/Users/cwerling/Git/fiedka/pkg/mod/github.com/happybeing/webpack-golang-wasm-async-loader/gobridge@v0.0.0-20201126150039-3d18007626dd/gobridge.go:19 +0x5
wasm_exec.js?5580:56 syscall/js.handleEvent()
wasm_exec.js?5580:56 	/usr/local/Cellar/go/1.17.2/libexec/src/syscall/js/func.go:96 +0x27

macOS 11.3, npm 8.10, fiedka 5520b99680641f1127e4ed49f9e277bf1625b7ea

NB: Exception only occurs when an image is taken from a live system. The original file from ASRock is parsed just fine.

It looks like due to Go tooling shenanigans we had pulled a somewhat old version into Fiedka back then.
All should be okay now. I couldn't see this issue anywhere.


Fix auto cursor placement for keyboard input for datepicker

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #181
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
When the user has a valid date in the datepicker input and then exclusively uses the keyboard to change the date, the cursor placed by the user now stays in place, rather than automatically moving to the end of the date input string.
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 2.9.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Figure out why build_site is recompiling old posts

https://bookdown.org/yihui/blogdown/local-preview.html#local-preview


Sync/to upstream

This pull requests represents ongoing changes to go-toggl
Currently added functionality:

GetProject
GetProjects
GetTimeEntries

@jason0x43 Not sure why it would add GetClients, etc as this is already merged

That happened on the last PR, too. Have you fetched from this repo lately (so that your upstream/master points to this repo's master)?


Update google-auth-library-credentials to 1.24.0

About this PR
📦 Updates com.google.auth:google-auth-library-credentials from 1.8.1 to 1.24.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.auth", artifactId = "google-auth-library-credentials" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.auth", artifactId = "google-auth-library-credentials" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #378.


iOS Build error with Cordova 6.0.0

Just started a new Cordova project to test Ace and had issues building the project for iOS.

cordova create hello
cordova platform add ios
cordova plugin add cordova-plugin-ace
cordova build ios

Error: Error code 65 for command: xcodebuild...

Then I tried to run the project directly from xcode and noticed the following error.

I then changed the import from:
#import "../../../CordovaLib/Classes/CDVViewController.h"

to:
#import "../../../CordovaLib/Classes/Public/CDVViewController.h"

This fixed the build.

I get the same error on 6.0.0
CompileC build/HelloWorld.build/Debug-iphonesimulator/HelloWorld.build/Objects-normal/i386/AcePluginManager.o HelloWorld/Plugins/cordova-plugin-ace/AcePluginManager.mm normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
...
...
/some/path/cordova/hello/platforms/ios/HelloWorld/Plugins/cordova-plugin-ace/AcePluginManager.mm:6:9: fatal error: '../../../CordovaLib/Classes/CDVViewController.h' file not found
#import "../../../CordovaLib/Classes/CDVViewController.h"
        ^
1 error generated.

Thanks for the report! I believe I have fixed it with the referenced commit just now.


Modify account api endpoints to return excludable data in the response header

Definition of Ready

[x] Does this meet the INVEST criteria?
[x] Does this have a clearly defined user?
[x] Does this have an estimate?
[x] Does this have acceptance criteria?
[x] Does this have sufficient context for the specific functionality being developed (design, business rules, etc.)
[x] Does this have a dev link been provided in the design?
[x] Is this traceable to a feature, epic, or PI?

User Story
As a Custom data download user I want the account api endpoints to to return a list of excludable data in the response header So that I receive the list to enable removing/ adding data elements from the cdd data table
Acceptance Criteria
Given that a user has made a GET request to an account api endpoint
When the response header is displayed
Then the system displays a list of fields that can be excluded  (see: custom data download key column  )
Given that a user has made a GET request to a compliance api endpoint
When the response header is displayed
Then the system displays a list of fields that can be excluded  (see: custom data download key column  )
Development Notes

the scope of this ticket does not include the streaming endpoints

Does this Story require 508 Testing?

[ ] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[ ] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
(User journeys, design mockups, architectural diagrams, business rules, data element definitions)
(see: custom data download key column  )
Testing
Test Case: TC671
Tester: @JanellC
Definition of Done

[ ] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[ ] Has the code been unit tested and peer reviewed?
[ ] Have the functional tests been executed?
[ ] Have all defects been reviewed and dispositioned, resolved, or deferred?
[ ] Is the user story ready to be deployed to the test/staging environments?

Allowance Holdings


Use Unpublishing#slug in Unpublishing#document_path

This partially reverts https://github.com/alphagov/whitehall/pull/3840/commits/7ea19016cd9c1366d1e6a306e4355c8d92b15a0d (PR #3840).
After deploying PR #3840 we saw a failure in the "Whitehall assets are served" scenario of the Whitehall feature in Smokey. The test was getting a 404 instead of a 200. This is because we redirect to the Unpublishing#document_path and the removal of the id option meant that this was now redirecting to a page that didn't exist. This is demonstrated in the curl requests below:
# Before PR #3840
$ curl -v \
  https://www.gov.uk/government/uploads/system/uploads/attachment_data/file/32409/11-944-higher-education-students-at-heart-of-system.pdf \
  > /dev/null
<snipped>
< HTTP/2 302
< location: https://www.gov.uk/government/publications/higher-education-students-at-the-heart-of-the-system--2

$ curl -v \
  https://www.gov.uk/government/publications/higher-education-students-at-the-heart-of-the-system--2 \
  > /dev/null
<snipped>
< HTTP/2 301
< location: /government/consultations/higher-education-white-paper-students-at-the-heart-of-the-system

$ curl -v \
  https://www.gov.uk/government/consultations/higher-education-white-paper-students-at-the-heart-of-the-system \
  > /dev/null
<snipped>
< HTTP/2 200

---

# After PR #3840
$ curl -v \
  https://www.gov.uk/government/uploads/system/uploads/attachment_data/file/32409/11-944-higher-education-students-at-heart-of-system.pdf \
  > /dev/null
<snipped>
< HTTP/1.1 302 Found
< Location: https://www.gov.uk/government/publications/higher-education-students-at-the-heart-of-the-system

$ curl -v \
  https://www.gov.uk/government/publications/higher-education-students-at-the-heart-of-the-system \
  > /dev/null
<snipped>
< HTTP/1.1 404 Not Found

I've checked the Unpublishing data in integration and can see that there are 4617 Unpublishing instances that are associated with an Edition with attachments where the Unpublishing has a different slug to the slug of its parent Document.
> Unpublishing.count
=> 28083

> mismatch_slug_count = 0; Unpublishing.all.each { |u|
    mismatch_slug_count += 1 if (u.slug != u.edition.document.slug)
  }; mismatch_slug_count
=> 5930

> mismatch_slug_count = 0; Unpublishing.all.each { |u|
    mismatch_slug_count += 1 if (
      u.edition.respond_to?(:attachments) &&
      u.edition.attachments.any? &&
      u.slug != u.edition.document.slug
    )
  }; mismatch_slug_count
=> 4617

I think the change highlighted by the Smokey failure might also apply to these 4617 documents which is we I've chosen to revert the behaviour for now.
As an aside: the test failure in Smokey highlighted that it was previously returning a false positive response. Smokey PR 345 attempts to avoid such false positives in future.

I'm still puzzled as to how Unpublishing#slug ends up not matching the Document#slug. Is it actually possible to change this via the UI?

I had a bit of a click around the interface and can't see that it's possible to change the slug. I wonder whether it was possible at some point in the past, though.

Thanks for reviewing, @floehopper.

I'm still puzzled as to how Unpublishing#slug ends up not matching the Document#slug. Is it actually possible to change this via the UI?

I encountered this recently and the following workflow is possible:

create a doc with a slug & publish it
create a new edition and change the title & publish it
unpublish that edition which resets it to a draft
publish that reset draft

At this point you'll have a document with editions and an unpublishing that have different slugs.
The intention here is that it allows you to correct an error where you published something too early or to the incorrect slug.  As far as I can tell slug is only hardened on first publish and I think resetting to a draft after an unpublishing effectively resets you to that "hasn't been first published" state and lets you change the slug again.  At least I think so, I didn't try this on a document with many editions.

@h-lame:
Hmm. Interesting. Doesn't the Unpublishing get destroyed in step 4 on this line?

Oh, well, I'm not sure I checked the unpublishing was still present after step 4 in my example.  But certainly on step 3 you can have a draft with a different slug to the unpublishing.

But certainly on step 3 you can have a draft with a different slug to the unpublishing.

👍


Recreate former benchmarks from core

In https://github.com/elastic/elasticsearch/pull/15356, we have removed some benchmarks from ES core as they are outdated and have also some conceptual problems. We should go through these benchmarks, check which of these would make sense as macrobenchmarks and add them to Rally.

This is not really a topic for Rally but rather how we use Rally. Thus I'm closing this issue.


Added @wordpress/core-data to allowedPackageJsonDependencies.txt

Needed for other wordpress type packages

Hi, how often does this get updated in the main repo? Do I now need to wait a ~month to finish my PRs in DefinitelyTyped (they might actually get auto closed by then since the CI is failing...) or can I do something to use them right away?
Thanks!

Oh, that's great, I was waiting for it to be updated in package.json


ErrorException in Service.php line 186: Array to string conversion

Hi artisaniweb,
I saw that you fixed some issues which caused the same error. Unfortunately I still get this error.
ErrorException in Service.php line 186: Array to string conversion
 in Service.php line 186
at HandleExceptions->handleError('8', 'Array to string conversion', 'C:\xampp\htdocs\cam\laravel\vendor\artisaninweb\laravel-soap\src\Artisaninweb\SoapWrapper\Service.php', '186', array('function' => 'GetSystems', 'params' => array(array('Server' => 'World'))))
at SoapClient->__call('GetSystems', array(array('Server' => 'World')))
at SoapClient->GetSystems(array('Server' => 'World'))
at call_user_func_array(array(object(SoapClient), 'GetSystems'), array(array('Server' => 'World'))) in Service.php line 186
at Service->call('GetSystems', array(array('Server' => 'World'))) in SoapGetSystemsController.php line 31
at SoapGetSystemsController->App\Http\Controllers\{closure}(object(Service)) in Wrapper.php line 57
at Wrapper->service('getsystems', object(Closure)) in Facade.php line 213
...

I implemented the code exactly in the way you described.
class SoapGetSystemsController extends Controller{

    public function demo()
    {
        // Add a new service to the wrapper
        SoapWrapper::add(function ($service) {
            $service
                ->name('getsystems')
                ->wsdl('xxxxxxxxxxxxxxxx')
                ->trace(true)                                                   // Optional: (parameter: true/false)
                ->cache(WSDL_CACHE_NONE)                                        // Optional: Set the WSDL cache
                ->options(['login' => 'xxxxxxxxxxxxxx', 'password' => 'xxxxxxxxxxxxxx']);   // Optional: Set some extra options
        });

        $data = [
            'Server' => 'World'
        ];

        // Using the added service
        SoapWrapper::service('getsystems', function ($service) use ($data) {
            var_dump($service->getFunctions());
            var_dump($service->call('GetSystems', [$data])->GetSystemsResult);
        });

        return view('systemaccess.getsystems')->with('data', $data);
    }

}

Only if I store a string for $data, I get an other result, but this could be not the way as I have to pass some (XML) data with the SOAP request. I would be very happy, if you could help me with this issue.
Best regards
Jakob

This is very strange, can you please tell me which version your using?

"laravel/framework": "5.0.*",
5.0.20
"artisaninweb/laravel-soap": "0.2.*"
<IP_ADDRESS>

I will take a look at this when i get home tonight.
In the meantime can you check if this works:
var_dump($service->call('GetSystems', $data)->GetSystemsResult);

Thank you! It seems to work better now. I get an other error back "looks like we got no XML document" which seems to point out that the Webservice interface is not working. I think it's about the authentication, we will try to get the Webservice working in SOAPUI first.
But can you tell me how I can check the SOAP request which was sent, even though the request was not succesful. The following doesn't work:
        SoapWrapper::service('getsystems', function ($service) use ($data) {
            var_dump($service->getFunctions());
            var_dump($service->call('GetSystems', $data)->GetSystemsResult);
            var_dump($service->getLastRequest());
        });

If i'm correct you need to enable the trace option.
You can do that like so:
SoapWrapper::add(function ($service) {
    $service->trace(true);
});

It didn't change anything....

Jakob- did you set your authentication values in the header variable?  Here's my call in case it's useful
 $service
                ->name('RetrieveMember')
                ->wsdl('http://domain.com/Members.asmx?WSDL')
                ->trace(true)                                                   // Optional: (parameter: true/false)
                ->header('http://domain.com/webservice/','AuthHeader',array('Username' => 'Username', 'Password' => 'pa55w0rd','AppName'=>'AppName'))
                ->cache(WSDL_CACHE_NONE)                                        // Optional: Set the WSDL cache
                ->options([]);   // Optional: Set some extra options

My web service required an 'AppName' but yours may not, of course.


Compression Codec enum not implemented yet?

Has compression codec been implemented? Not able to find the enum in the source code and was not sure.

use the compression.codec config parameter (refer to: https://github.com/edenhill/librdkafka/blob/master/CONFIGURATION.md)
I believe they're all available in the nuget librdkafka.redist.

The type is an Enum, what is the enum used? Are there any examples of the compression being set through the producers config?

no examples in the dotnet repo.
specify the value as a string, not an enum type.
the API is done this way to allow for easy specification via a text file
and also consistency with other clients.
in the future we may provide a strongly typed .net configuration class
(together with specific enum for compression and other enum types), but we
don't do that presently.
On Wed, Jun 14, 2017 at 3:06 PM, TeaLeafReader199<EMAIL_ADDRESS>wrote:

The type is an Enum, what is the enum used? Are there any examples of the
compression being set through the producers config?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/confluentinc/confluent-kafka-dotnet/issues/227#issuecomment-308571818,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABK5m2UIfyH62mEIi8uyjZ4xmY78luSks5sEFlMgaJpZM4N6dLj
.


Additional safeguards against printing Secret content

What are you trying to accomplish with this PR?
Further reduce the likelihood that we'll accidentally print the content of sensitive resources (i.e. Secrets) when something goes wrong. Now that we officially support the Secret resource and push our EJSON secrets through that code path, this is super important.
How is this accomplished?
These are the ways I thought of that secrets could get logged:

They come from a regular template, and rendering it fails
They are missing critical data, and we raise during resource instance instantiation
They fail validation (i.e. dry run)
The apply they are part of fails, whether because of them or not

I added tests for the three additional cases (test_apply_failure_with_sensitive_resources_hides_raw_output covers the last one already) and tried to fix them as solidly as I could think to. record_invalid_template is a bit of a choke point for these problems, so in addition to fixing the specific cases, I made that method do a blunt scan of the content it is about to log and replace it if it contains kind: Secret.
I also made the ejson secret provisioner proactively validate the resulting resources and raise its own error if it isn't valid. This is duplicated effort, but it gives us stronger guarantees that nothing will go wrong further down the path.
~Note that this is based on https://github.com/Shopify/kubernetes-deploy/pull/473 to avoid linter noise.~
What could go wrong?
It's still possible there's a code path that I haven't thought of that will still log secret content on error. It is also possible someone will add a new way for this to go wrong in the future, and nothing will stand in their way (note that our contributor's guide does warn about this: We handle Kubernetes secrets, so it is critical that changes do not cause the contents of any secrets in the template set to be logged.).
An alternative / additional safeguard could be to have our logger class scan every single string we give it for kind: Secret. However, that is very heavy-handed and arguably not effective, since not all strings with that text contain sensitive data, and not all secrets have that string (e.g. they could be invalid, or the string could be a partial resource).
If we don't think we can get to Good Enough here, we could revert Secret support. I would rather not though--the community asked for it, and deploying them always actually worked even before we made it official. Even if we took it a step further and prevented Secrets from being deployed with this gem, that still doesn't prevent this gem from handling them.
Another thing that occurred to me is that CRs could contain sensitive data for all we know. We should consider letting administrators tell us this in our CRD annotations. I'll open an issue about this.
@Shopify/cloudx

I think we should continue our best effort support, emphasise that it's just that, and commit to handling leaks in our logs as high priority issues.

How does this sound as an addition to the README? I'm thinking it could go at the end of the Usage section.

NOTICE: Deploy Secret resources at your own risk. Although we will make every effort not to log their contents and will fix any reported leak vectors with urgency, we cannot guarantee that sensitive information will never be logged.


Randomize update interval of merchants

This the update interval should be uniform distributed, we could create parameters like min_interval and max_interval.


Updated to version 0.79.3

Thanks for the PR. Because of this PR, I added a test which should prevent forgetting to update the latest-version.txt. I also updated the latest-version.txt, so this PR is done.
See #22


French translation

Proposed changes
French translation basic strucuture
Types of changes

[ ] Proofreading (fix spelling, grammar, punctuation, accuracy) Proofreading
[x] New content (new section, new readme, etc.)
[x] Modifications (modifying existing content)
[ ] Other (please describe)

Checklist

[ ] Tested any code that was added/modified in this PR
[ ] Added external links
[x] Added internal links
[ ] Added images
[ ] Added videos
[ ] Added code snippets

@all-contributors add @exrol for content

Hi ! I would love to help you translating in french ! Is it possible ?


Clojure and ClojureScript

The current icon for Clojure seems to be an old one and it isn't associated with the file extensions .clj, .cljs, .cljc, or .edn which are used for Clojure.

Done in d2b89be0e72ce38a68076a041644baad7caa240b
I will release it in 1.5

Already released

Wow, you're really fast @robertohuertasm :+1:


remove device-specifc 'isEnabled' checks

Reviewer:
Asana:
Description
Steps to test

#523  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on  Graphite


Update boba network info

Boba Network has completed an Anchorage upgrade at block 1149019. Boba Network is running the Op stack using Erigon as the sequencer node.

Resolved here https://github.com/l2beat/l2beat/pull/3438


sink(cdc): fix "dead dmlSink" error in sink workers

What problem does this PR solve?
Issue Number: close #9685 .
What is changed and how it works?
Call defer func() { handleSpecialSinkInternalErrors() } before fetchFromCache.
Check List
Tests

Unit test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/test cdc-integration-mysql-test

/retest-required


Better Navbar with color clarity and positioning of the contact us button at a better position

Description
This PR fixes #
1.THE COLOR OF CONTACT US USE TO GET HIDDEN DUE TO THE SAME COLOR {now fixed}
2.CONTACT US BUTTON WAS IN A WEIRD POSITON {now fixed}
Notes for Reviewers

Hey @shramanpaul , can u pleasee add the required screenshot, so it will be easy for us to review..

yes

positioning of the contact us button done in the same row in the navbar

2. color of the contact us when it is active in the region fixed

I have resolved the conflicts now you can review and merge

Hey @shramanpaul , actually now the navbar is changed a bit, pls check out. We prefer the existing one.
If there is any other improvements u would like to make , pls go ahead!
Thank you!!


Where is the 'ImageNet pretrained models' ?

Hello,
Thank you for your work.
Where is the 'ImageNet pretrained models' in this repository? I couldn't find it. how to use?

https://drive.google.com/file/d/1CAO_Ypyeg_-b3BkShPi1BN-5kUqfKt2g/view?usp=sharing

thanks


Archive and redirect ethnic groups patterns

Part of https://github.com/alphagov/govuk-design-system/issues/1544
What
Archive the ethnic groups pattern so it no longer displays in the design system navigation.
If a user does land on that page (e.g: via a bookmark), they are told to look at the new equality information pattern instead.

You can preview this change here:
Built with commit bf05ec1b548f73cbc66d4b47a22362a76bdd926e
https://deploy-preview-1582--govuk-design-system-preview.netlify.app


Improve validation for machine types, images, and volumes in the Shoot

How to categorize this PR?

/area ops-productivity usability
/kind bug
What this PR does / why we need it:
See https://github.com/gardener/gardener/issues/7595 for detailed description of the issue.

Which issue(s) this PR fixes:
Fixes #7595
Special notes for your reviewer:
Release note:

NONE

/test pull-gardener-e2e-kind-ha-multi-zone-upgrade

/assign

/hold

/unhold
@acumino PTAL!

/retest

This PR does a lot more now from your initial review, Could you PTAL @ScheererJ ?

/test pull-gardener-e2e-kind-ha-single-zone-upgrade

/hold
for some discussion with @acumino

/unhold
/cc @acumino

/retest

/milestone v1.71

/test pull-gardener-e2e-kind-ha-single-zone-upgrade


Build Go Packages as Non-Root User

Description
Builds of hyperledger docker images generate files under build/docker/pkg owned as root. These files should be owned by the user running make to ensure they can be properly cleaned up using make clean
Describe How to Reproduce
make unit-test -> produces build/docker/pkg owned by root.

This looks promising: http://man7.org/linux/man-pages/man7/user_namespaces.7.html

Worst case, we can revert this commit https://github.com/hyperledger/fabric/commit/85837442c2dfb92cf0be0455581387bfbe0c2f48
There will be a performance penalty at build time, but that is better than what we have today.

@ghaskins : Could you please revert the above commit# (https://github.com/hyperledger/fabric/commit/85837442c2dfb92cf0be0455581387bfbe0c2f48) for the short term fix and also to continue with builds on Z and X86. As discussed yesterday in slack channel, we will work on running docker containers in non-root mode for the long term fix.


spiders: Set error status for exceptions generated by spider.

This PR is address the failure to detect errors by spider as in #11719.
Spider  would raise exceptions for erros like FileNotFound. These did not set error state before exiting causing spider to fail silently.This patch sets the status before exiting.
Failed Silently

Fix

Tested with exceptions observed in #11719.

@timabbott FYI :)

Nice find, merged, thanks @sumanthvrao!


[Question] Deprecation warning for wrapper space attributes?

Question
The latest gymnasium version warns that wrappers reward spec won't be accessible in the same way in v1.0
I'm not sure how to interpret this:
rl/lib/python3.9/site-packages/gymnasium/core.py:311: UserWarning: WARN: env.reward_space to get variables from other wrappers is deprecated and will be removed in v1.0, to get this variable you can do `env.unwrapped.reward_space` for environment variables or `env.get_wrapper_attr('reward_space')` that will search the reminding wrappers.

My questions are:

Why this deprecation? I saw somewhere that vectorized envs will now be a separated class. I seems from here that wrapped env will distanciate themselves from regular envs. Why are all these classes which were interchangeable become more different? If anything one would expect them to become closer to each other with time.
Specifically for reward spaces: what does this mean in practice? In torchrl, we have a series of wrappers for gymnasium envs, what do we have to do to anticipate these changes?
Is there a way big "customers" of gymnasium would be asked for feedback before deciding these bc-breaking changes in the future? Is there a list of people we can subscribe to that would make us aware of these changes before they are enacted?

Thanks

Hey, thanks for the questions, I'm separating out the top question from 1.

In short, Gym / Gymnasium has a "hack" that override the Wrapper.__getattr__ function. This function is called anytime python fails to find a variable in a class. This was important as most of the time users are interacting with the top level wrapper but may want to interact with the base environment or other wrappers. Therefore, the Wrapper.__getattr__ was used recursively down the environment stack to get variable not in the top wrapper. The problem is that this causes issues with setting attributes as the sister function, __setattribute__ was never implemented. Also, a more minor problem in our opinion is that users don't realise this is happening or what class they are interacting with.
In summary, despite accessing gravity, the user can't modify it likewise.

env = gym.make("CartPole-v1")
print(env)
# <TimeLimit<OrderEnforcing<PassiveEnvChecker<CartPoleEnv<CartPole-v1>>>>>
env.reset()
print(env.gravity)
# 9.8
env.gravity = 1
print(env.gravity, env.env.gravity, env.unwrapped.gravity)
# 1 9.8 9.8

See https://github.com/Farama-Foundation/Gymnasium/issues/357 for the full issue
The large problem with this is in async and sync vector environment where you can't modify the base environment's variables which is why we realised this bug in the hack existed. Finally, a rare but weird error exists if you try to access a variable that doesn't exist in a wrapper before super().__init__(env) is called as env doesn't exist so __getattr__ will be called infinitely. We have found this a particularly large problem in shimmy for deepmind projects.
Therefore, we decided rather than implement __setattribute__ it would be simpler and easier for users to understand what is happening through implementing get_wrapper_attr and set_wrapper_attr functions to recursively get or set variables otherwise the user will only interact with the object that they are actually interacting with.

Part of the discussion is given in https://github.com/Farama-Foundation/Gymnasium/issues/32, in short, while Env and VectorEnv, we believe that there are subtle but important changes, particularly with step and for wrappers. Our aim was to simplify the difference between Env and VectorEnv such that users can easily swap between the two. Importantly, this should allow users to clearly differentiate between the vector and non-vector code along with promoting vector-only projects that while previously would work with Gymnasium, we believe could be incorrectly used due to several details
Following the answer to question 0, if you are accessing a variable that you know if not in the top level object, then you need to change to env.unwrapped.variable_name for accessing for a variable in the base environment, otherwise, env.get_wrapper_attr(variable_name)
A lot of the time, we use issues to discuss variables but we also have an internal team of developers who develop and work on problems. @jkterry1 Do you have any thoughts on this?


Use pre-built jars in a specific version in kogito-runtimes pipelines

We need to be able to use jars that are already built (in some version) in our kogito-runtimes tests and scans. There is automation for that here: https://github.com/kiegroup/run-tests-with-build
Acceptance criteria:

Automation doesn't build kogito-runtimes jars.
Already built jars are downloaded and extracted to individual "target" (target as a name of the directory) directories of appropriate modules in the kogito-runtimes source code repository that is used in the pipeline.

PR submitted upstream. When merged, this can be executed in the test step of the kogiro-runtimes pipeline. https://github.com/kiegroup/kogito-runtimes/pull/3006


next: Collected changes for the v2015.09 release

This Pull Request contains the changes that are being tested for inclusion in the v2015.09 branch.

Looks like the test failure here is an operational issue (hugepage availability on the CI host). That is no biggie: the next merge will trigger a rerun anyway.
Does raise a couple of interesting thoughts though:

How come the hugepage is failing to allocate? In the log we see that Snabb Switch makes three attempts to provision a new huge page in the kernel and then allocate that. I wonder why those attempts are all failing and whether we could improve that algorithm to make it more robust.
I see that it would be valuable to run the CI on multiple hosts so that CI operational issues are easier to distinguish. If the CI result were that tests passed on 4/5 CI servers then it would be easier to estimate confidence in the code before digging into the root cause. Once more I see docker (Issue #588) as the great hope to make it easy to operate a CI fleet.

@lukego I take it we're ready for release here? If so, I will go ahead and do the routine.

Roger!

Humble request: Could you put the release name in the first line of the commit message when you merge onto master? Just so that it is immediately visible in one-line summaries e.g. git log --oneline.
For example
Merged PR #593 (v2015.09 release) onto master


Add more detailed instruction for global search

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Add more detailed instruction for global search.
Which issue(s) this PR fixes:
Fixes https://github.com/karmada-io/karmada/issues/4678
Special notes for your reviewer:

/cc @wengyao04 @windsonsea @RainbowMango

/lgtm


[Feature Request] Pinned notes

I'd like to be able to pin notes, i.e. prevent them from moving down in the menu and in the list in the search window.

Hmm, interesting idea, I will look into it.
Thanks
Davo

OK, thinking out loud.
Mark a Pinned note with a tag, eg in the  section, put system:pinned.  Will be ignored by older versions of -ng and its cousin applications.
When the notes menu is redrawn, it relies on the fact that we keep the in memory notes sorted by most recently used. So, for the first sweep we look for pinned notes. Then, space permitting, unpinned. That way, we see the Pinned notes in the correct order and then the unpinned, also in correct order. This will be a bit time consuming, bypassing some of the optimizations I have done. So, maybe keep a record in memory as to how many pinned notes the user has, that way, pinned notes, probably more used, will be found first and when they are all found, stop that sweep ? If the user has one  pinned note that has not been touched for years, then a full sweep will be necessary. OK if notes in memory but possibly slow for users who choose not to do that.
Another problem will be how to handle that for Sync users. When doing GitHub sync, we will always defer to an existing note's pinned status ?  The Index page is generated locally so thats easy. For file sync the xml will tell us all we need. However, if the user is using Github to sync two different machines then the Pinned status will NOT be passed to other machine. Hmm....
A dodgy hidden markdown tag ?  Sigh ....
Anyway, does sound like it can be made useful for most users.


Section 1.2, REPL Command Line Interface typo

It can can be downloaded directly from: https://julialang.org/downloads/.

Sorry for another message.  This typo still appears in the current version of the PDF.  Perhaps a screenshot would be helpful for spotting out the error.

Thanks Vincent, it should now be fixed for future draft releases.


command [ionic platform add ios ] run wrong

From @aqnaruto on November 10, 2016 13:9
i flowed the offical start document,and rebuild sever time s but  it is still not work

TypeError: Cannot read property 'hasOwnProperty' of undefined
    at Object.runr (/usr/local/lib/node_modules/ionic/lib/cli.js:191:19)
    at /usr/local/lib/node_modules/ionic/lib/cli.js:54:9
    at _fulfilled (/usr/local/lib/node_modules/ionic/node_modules/q/q.js:787:54)
    at self.promiseDispatch.done (/usr/local/lib/node_modules/ionic/node_modules/q/q.js:816:30)
    at Promise.promise.promiseDispatch (/usr/local/lib/node_modules/ionic/node_modules/q/q.js:749:13)
    at /usr/local/lib/node_modules/ionic/node_modules/q/q.js:557:44
    at flush (/usr/local/lib/node_modules/ionic/node_modules/q/q.js:108:17)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Cannot read property 'hasOwnProperty' of undefined (CLI v2.1.7)

Your system information:

Cordova CLI: 6.4.0
Ionic CLI Version: 2.1.7
Ionic App Lib Version: 2.1.4
ios-deploy version: 1.9.0
ios-sim version: 5.0.11
OS: OS X El Capitan
Node Version: v7.0.0
Xcode version: Xcode 8.0 Build version 8A218a

Copied from original issue: driftyco/ionic#9109

From @aqnaruto on November 10, 2016 14:26
it also do not work on windows ,android .

From @aqnaruto on November 10, 2016 14:55
i figure it out by adding--v2 , but i think the offical document should update! it is really confused the document do not mentioned it

when u init a project , u should add  version --v2 such as ionic start myapp tabs --v2 , if u still not work ,u can contract me in skype<EMAIL_ADDRESS>

oh,thanks .

Thanks,You solved my problem


VM Metadata API: Adds an option to disable VM metadata API call

Description
As part of this PR, adding capability to stop instance metadata API call

Introduce COSMOS_DISABLE_VM_METADATA_ACCESS env variable, to stop calling Instance Metadata API call, if set as true.

and 2 minor variable name change (spelling correction)
Type of change

[] New feature (non-breaking change which adds functionality)

Closing issues
To automatically close an issue: closes #4187

Please refresh the description with new ENV naming.


libmamba Could not create proc dir: "/home/mambauser/.mamba/proc"

Using 0.26.0 I see this when using micromamba run
libmamba Could not create proc dir: "/home/mambauser/.mamba/proc"

Hi @shughes-uk - thank you for reporting this problem.
I am able to reproduce this on macOS without using docker:
$ ./micromamba run /bin/bash
warning  libmamba Could not create proc dir: "/Users/MyUserID/.mamba/proc"
$

Please repost to the mamba-org/mamba repo issue tracker, as that is where issues with the micromamba program are handled.


Thermostat hold control from Homebridge

Is your feature request related to a problem? Please describe:

If the omni stats are not kept on hold, the default thermostat schedule will take over - instead of the OMNI controller being the master.  Homekit doesn’t seem to support a hold switch for thermostats.  If the temperature is changed in homekit while the thermostat is in hold, it will jump back to the previous temp.  To work around this I’ve implemented a button to toggle the hold of each thermostat, but it’s rather clunky.
Describe the solution you'd like:

Is there a “thermostat change event” that can be caught in homebridge to remove the hold, in order to modify the temp and then activate hold once the temp has changed?
Describe alternatives you've considered:

Additional context:

Hi @btgh,
I wasn't too sure what is the best way to implement the "Hold" mode in HomeKit. As I don't have any thermostats connected to my Omni I don't know what its purpose is or how it functions.
From what you've describe I gather you want it to work like this:

User changes the SetPoint (or target) temperature in the HomeKit thermostat
If the Omni thermostat is in Hold mode then turn it off
Set the Omni thermostat's SetPoint to the one selected by the user (in step 1)
If the Omni thermostat was previously in the Hold mode (step 2) then turn it back on

So there is no need for a seperate switch in HomeKit to turn the Hold mode on and off, is that correct?

You’ve capture it correctly On Apr 16, 2023, at 3:42 AM, mantorok1 @.***> wrote:
Hi @btgh,
I wasn't too sure what is the best way to implement the "Hold" mode in HomeKit. As I don't have any thermostats connected to my Omni I don't know what its purpose is or how it functions.
From what you've describe I gather you want it to work like this:
User changes the SetPoint (or target) temperature in the HomeKit thermostat
If the Omni thermostat is in Hold mode then turn it off
Set the Omni thermostat's SetPoint to the one selected by the user (in step 1)
If the Omni thermostat was previously in the Hold mode (step 2) then turn it back on
So there is no need for a seperate switch in HomeKit to turn the Hold mode on and off, is that correct?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Hi @btgh,
I've released version 1.5.11 of the plugin which should resolve this issue (but I'm not able to test it on my own system). Please try it out and let me know how it goes.

Works great!  Thanks for the enhancement.


Add new module contribution guide for extended library modules

Purpose
$subject.
Fixes https://github.com/ballerina-platform/ballerina-extended-library/issues/506
Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email<EMAIL_ADDRESS>to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to<EMAIL_ADDRESS>and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@NipunaRanasinghe - I read through LGTM. However a few points,

Did we decided not to have samples folder? I remember we had issues maintaining those samples making sure they work across version upgrades.
It will be great if we can mention a specific format for package.md and module.md files
It will be great to link to our keyword system. We have a doc maintained mentioning all keywords. Lib developers better select appropriate keywords from that list rather introduce their own. Maybe we can make it a wiki. https://docs.google.com/spreadsheets/d/1BZtaCARF_mIJiRcvw6jdzIeNEK0dNuwxZlpSjRb68IA/edit#gid=1033521037

@abeykoon Thanks for your suggestions and please find my responses below.

Did we decided not to have samples folder? I remember we had issues maintaining those samples making sure they work across version upgrades.

IIRC we decided to make it optional, as we cannot generalize this rule for the generated connectors. And I was thinking of enforcing to add all the samples under the examples/ directory in repo root, to make it consistent with the standard library structure (even though we some differences between standard and extended libraries module structures, IMO we better stick to common conventions wherever possible). WDYT?

It will be great if we can mention a specific format for package.md and module.md files

Yes that's already in the roadmap. One question I came up while creating templates for the above two files was, whether we can have a common template (i.e. defined in https://docs.google.com/document/d/1WZg1ix9MpKDTQ_OOm3NVqhQ5L0VGNaUQ1LRmjp-SMO4/edit?usp=sharing) for both handwritten and generated connector modules or, whether we need two separate templates. Appreciate your thought on this.

It will be great to link to our keyword system. We have a doc maintained mentioning all keywords. Lib developers better select appropriate keywords from that list rather introduce their own. Maybe we can make it a wiki. https://docs.google.com/spreadsheets/d/1BZtaCARF_mIJiRcvw6jdzIeNEK0dNuwxZlpSjRb68IA/edit#gid=1033521037

+1 to document this information and mention in the module contribution guide.

@NipunaRanasinghe

+1 to have a similar structure with std libs repository.
We do not need separate templates. It can be same. Only thing is, generated connectors/triggers might have a sub-set of information.
Yes. We can address in a separate PR. Pls track.

@abeykoon I've udpated the guide with the Package.md and Module.md templates as suggested. I'll create a separate PR on keyword recommendations, as the doc we are having seems to be outdated.
Appreciate your review on the new changes.


Skip transfer progress test until it's fixed

Currently the transfer progress test is breaking on windows
randomly. @tbranyen and I have been looking into it and it seems
like a libuv issue. I'm going to skip this now so that other
potential PR's aren't held up by it until we can get a good
resolution and fix it in another PR

:+1: No point in getting held up by a random Windows segfault not related to our code.


Restart refresh timers during cluster-switch

The timers which are responsible for refreshing
osd-viz, pools, iops and hosts will be restarted
if the cluster is changed.
Signed-off-by: Kanagaraj M<EMAIL_ADDRESS>

@GregMeno @karnan4ever

Fixes #10442


Add markewaite as an implied-labels-plugin developer

Description
Add @markewaite as a developer of the implied labels plugin.  Requesting approval from @olivergondza (not yet confirmed separately)
I specifically want to merge and release the "Prepare for icon removal" pull request so that the plugin will continue to work well with current weekly releases and with the next LTS baseline.
I am a regular user of the plugin and need the functionality that it provides.

Repository: https://github.com/jenkinsci/implied-labels-plugin
My pull requests: https://github.com/jenkinsci/implied-labels-plugin/pulls?q=is%3Apr+author%3AMarkEWaite
My reviews: https://github.com/jenkinsci/implied-labels-plugin/pull/8

Submitter checklist for adding or changing permissions
Always

[x] Add link to plugin/component Git repository in description above

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[x] All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@MarkEWaite, thanks for stepping in. I approve this request.


When could python client for rocketMQ

The python client is currently developing and is expected to be available in December.Are you interested in joining us?

ping @ShannonDing @wlliqipeng Could we plan to announce the plan to support here? I don't catch any sounds in the community.


Support for fallback values

If a browser doesn’t recognize a property or its corresponding value, the browser will ignore the property altogether. When this happens, the browser uses (or falls back) to the previous value it finds.
This is the easiest way to provide a fallback. Here’s an example:
.layout {
  display: block;
  display: grid;
}

In this example, browsers that support CSS Grid will use display: grid. Browser doesn’t support CSS Grid will fall back to display: block.

https://zellwk.com/blog/older-browsers-css/

As we use objects to declare styles we can't simply do:
// ⚠ this is not real code, this does not work
makeStyles({
  root: {
    color: "red",
    color: "rgba(0, 0, 0, 0.5)"
  }
});

We can use the similar approach as fela-plugin-fallback-value with arrays or something else.
The approach to fallback values should be tested and documented.

Maybe not a big deal with evergreen browsers as it used to be with IE 11 which we do not support.
But there are still cases, like overflow-overlay where the fallback values still make sense.


waitUntil networkidle0 not working (nginx + php-fpm)

Steps to reproduce

Run puppeteer using https://github.com/spatie/browsershot package
(PHP - command line - node - puppeteer.js)

Wait...

Timeout!

Any other waitUntil events works...
But only networkidle0 never fires.
Tell us about your environment:

Puppeteer version: 1.2.0
Platform / OS version: Docker Alpine linux
URLs (if applicable):
Node.js version: 8.9.3
Chromium version: 64.0.3282.168

What steps will reproduce the problem?
Please include code that reproduces the issue.

On php

        $imageData = Browsershot::html($html)
            // puppeteer 설정
            ->setChromePath('/usr/bin/chromium-browser')
            ->setNodeModulePath(base_path('node_modules'))
            ->noSandbox()
            ->setOption('args', ['--lang=ko-KR'])
            ->setOption('waitUntil', 'networkidle0')
            ->timeout(600)
            ->evaluate('JSON.stringify(window.results)');

On JS

        const requestOptions = {};

        requestOptions.waitUntil = request.options.waitUntil;

        // Whenever run this, it emits timeout error
        await page.goto(request.url, requestOptions);

What is the expected result?
Run without timeout error
What happens instead?
Navigation timeout error (Never fires networkidle)

Docker's Extremely slow was the reason...
Sorry


it works locally, but on prod it gives me a "No Auth Provider Found" error

I don't quite understand how Netlify plays in this anymore besides providing the CMS. Do I still have to make a Netlify app? Since I'm using Cloudflare to host it.

I figured it out. I needed to do this: auth_endpoint: /api/auth in my /static/admin/config.yml file under the backend kety.


Mistranslations of Korean/Japanese data

hello @steveash!
I'm very interested in your project, so I checked your datasets of Korean/Japanese.
(I'm native speaker of Korean, and I'm doing research about Japanese transliteration in master course.)
and I found that your datasets include the following type of mistranslations.
{(first name) (last name) <-> (last name) (first name)}
I refined your datasets in my own methods and I'd like to introduce my method.

First, I created the first model using only data with more than 2 frequency.
by using the first model, I inferenced all the data and measured the edit distance between the correct name and top-1 inferenced name. I regarded the data with editing distance above threshold as an mistranslation and excluded it.
I created the second model using the data except the mistranslation data.

By this method, I was able to reduce some mistranslation data. I think you can also use this method if you want to refine the data.
this is my project using your dataset of Korean. check it out!
https://github.com/noowad/korean-person-name-transliterator

Very cool! Yes since we only tackled token alignment via simple heuristics, there is some noise as you see. Do you have the word error rates after excluding the filtered examples-- how much improvement do you see? Also which neural architecture did you use Transformer or seq2seq?

@steveash
I only measured top-k accuracy.
the first model's result is:
top1 Accuracy:705/2000=0.3525
top2 Accuracy:929/2000=0.4645
top3 Accuracy:1032/2000=0.516
top4 Accuracy:1085/2000=0.5425
top5 Accuracy:1138/2000=0.569
the second model's result is:
top1 Accuracy:969/2000=0.4845
top2 Accuracy:1231/2000=0.6155
top3 Accuracy:1351/2000=0.6755
top4 Accuracy:1414/2000=0.707
top5 Accuracy:1451/2000=0.7255
and I used different seq2seq model which applied the architecture of Tacotron (google's text-to-synthesis model) since both text-to-speech synthesis and machine transliteration deal with pronunciation.

What edit distance threshold did you use for filtering? And just to clarify you only filtered the training data, right? The test data used in the above is the exact same set in both?
Did you do any error analysis to determine how many of the mistranslations by edit distance we're due to flips or just due to the task being difficult?

I set threshold quite roughly. As word length becomes longer, the editing distance naturally becomes longer too, so I excluded data that word length - edit distance <= 2 (2 is threshold).
I only filtered training data and validate data/test data were same. Test data is in https://github.com/noowad/korean-person-name-transliterator/blob/master/datas/korean_test.txt.
and I did not analyze the errors, but I think that the performance difference between the first model and the second model is due to gap of the amount of training data. In order to measure the effect of noise data reduction, it would be necessary to compare the second model with the data without removing the noise data.

Hi there,
Can anybody explain how do you get frequency? I want to create a dataset for Ukranian and get rid of translations. I guess frequency will help me somehow. Am I ?

Hello @steveash,
I am an MS in Machine Learning student writing a thesis on NLP (Transliteration for translation of named entities). I want to extend the dataset of named entities (human and company names from wikidata, places from geonames.org) up to 10 languages, i.e. build a little bit larger multilingual dataset. I want to remove named entities that are actually translations. I understand that it's hard to do perfectly in a fully automated way, but I hope there are some strategies that would work 99% of the time. Could you please give me some advice?


⚠ Fortnite has degraded performance

In a14b197, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1590 ms

Resolved: Fortnite performance has improved in c5d8e9e.


Add 99th and 999th percentile produce delay metrics

@smccauliff Could you review this patch? Thanks!

Thanks for the review @sutambe

Thanks for the review @smccauliff