Issue with Asset Share Commons - Dynamic Facet Filter

We at Microsoft have a Facet Filter component which displays multiple items as checkbox to filter Assets on Asset Share page. When selection of any filter item results in reducing the number of filter items (as per the filtered result set), we lose the state of selected facet items on any further action on Search page. Attached document has the detailed explanation of the problem and a proposed solution to fix it in Asset Share Commons.
Issue with Asset Share Commons Dynamic Filters.docx
@kaushalmall @reenakumarii

@vinaykhurana yeh - this is a tricky situation  ..  have you tried calling reset() as suggested? Are there any other side effects?
Ill have to revisit the code - but the general approach is that the DOM is the canonical source for search state, vs trying to maintain that over "time" in JS, so on paper this seems reasonable -- ie. events should always go back to the DOM anyhow -- that being said, there might be caveats I'm forgetting.

@davidjgonzalez  using reset() worked. But we found some other way to fix the issue. In the facet component we are using, instead of assigning the index based on the list index, we moved the item index assigning logic to model side. What that means is, if an item had index 1 before applying any filter, we keep the same index of selected item after filters are applied. In the example which i mentioned in the problem statement, we assign the index 1 to 'prh-campaign' facet item even though this is the only item left after applying filters.
I din't like this approach of assigning index this way but this was the only option at that moment to fix it without a change in asset-share-commons. Ideally asset-share-commons should be handling dynamic filters like this where applying of a filter item results in reduced set of filter items.
CC : @kaushalmall @reenakumarii


[ZEPPELIN-3478] Download Data as CSV downloads data as a single line

What is this PR for?
All data is in one single line - lines separated with backslash and "n" sequence and not actual newline characters "\n".
What type of PR is it?
[Bug Fix]
What is the Jira issue?

ZEPPELIN-3478

How should this be tested?
All the exports should work in all browsers

Export this notebook
Export as CVS
Export as TSV

Questions:

Does the licenses files need update? N/A
Is there breaking changes for older versions? N/A
Does this needs documentation? N/A

@Tagar @r-kamath  can you help review this.

thanks for prompt response @prabhjyotsingh
I will give this a try today.

LGTM
Verified manually - this patch fixes the issue.
Thanks a lot @prabhjyotsingh

LGTM

Thanks for the review will merge this to master and branch-0.8 if no more discussion.


fix(validateAccessToken): improve error message

Released: v0.2.2 🎉
This has been released in v0.2.2!

📄 Release notes
📦 npm package

Make sure to always update to the latest version (npm i @ossjs/release@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.


Support for Swift Package Manager

Please provide a Package.swift
import PackageDescription
let package = Package(
   /// plist files ...
    exclude: ["....."],
    dependencies: []
)

done :-)


influxdb write connection refused

I'm on windows 10 using doker-compose and everything seems to be working except for the unifi-poller write to influxdb
# This is for unifi-poller v2.
version: '3'
services:
  influxdb:
    container_name: up_influxdb
    restart: always
    image: influxdb:latest
    ports:
      - '8086:8086'
    volumes:
      - /docker/influxdb:/var/lib/influxdb
    environment:
      - INFLUXDB_DB=unifi
      - INFLUXDB_ADMIN_USER=unifipoller
      - INFLUXDB_ADMIN_PASSWORD=unifipoller
      - INFLUXDB_HTTP_AUTH_ENABLED=true
  grafana:
    container_name: up_grafana
    image: grafana/grafana:latest
    user: "0"
    restart: unless-stopped
    ports:
      - '3000:3000'
    volumes:
      - /docker/grafana:/var/lib/grafana
    depends_on:
      - influxdb
    environment:
      - GF_SECURITY_ADMIN_USER=admin
      - GF_INSTALL_PLUGINS=grafana-clock-panel,natel-discrete-panel,grafana-piechart-panel
  unifi-poller:
    container_name: unifi-poller
    restart: always
    image: golift/unifi-poller:2
    depends_on:
      - influxdb
      - grafana
    environment:
      - UP_UNIFI_URL=https://<IP_ADDRESS>:443
      - UP_UNIFI_USER=unifipoller
      - UP_UNIFI_PASS=***************
      - UP_UNIFI_DEFAULT_URL=https://<IP_ADDRESS>:443
      - UP_UNIFI_DEFAULT_USER=unifipoller
      - UP_UNIFI_DEFAULT_PASS=**************
      - UP_INFLUXDB_USER=unifipoller
      - UP_INFLUXDB_PASS=unifipoller
      - UP_INFLUXDB_DB=unifi
      - UP_INFLUX_URL=http://<IP_ADDRESS>:8086
      - UP_INFLUXDB_URL=http://<IP_ADDRESS>:8086
    volumes:
      - /docker/unifi-poller:/config

logs for unifi-poller
2020/06/15 21:01:20 [INFO] Loading Configuration File: /etc/unifi-poller/up.conf
2020/06/15 21:01:20 [INFO] UniFi Poller v2.0.1-787 Starting Up! PID: 1
2020/06/15 21:01:20 [INFO] Found 1 site(s) on controller https://<IP_ADDRESS>:443: default (Home)
2020/06/15 21:01:20 [INFO] Configured UniFi Controller 1:
2020/06/15 21:01:20 [INFO] => URL: https://<IP_ADDRESS>:443
2020/06/15 21:01:20 [INFO] => Version: 5.13.30
2020/06/15 21:01:20 [INFO] => Username: unifipoller (has password: true)
2020/06/15 21:01:20 [INFO] => Hash PII: false
2020/06/15 21:01:20 [INFO] => Verify SSL: false
2020/06/15 21:01:20 [INFO] => Save DPI: false
2020/06/15 21:01:20 [INFO] => Save IDS: false
2020/06/15 21:01:20 [INFO] => Save Sites: true
2020/06/15 21:01:20 [INFO] Everything checks out! Poller started, InfluxDB interval: 30s
2020/06/15 21:01:20 [INFO] Prometheus exported at https://<IP_ADDRESS>:9130/ - namespace: unifipoller
2020/06/15 21:01:50 [ERROR] influxdb.Write(points): Post "http://<IP_ADDRESS>:8086/write?consistency=&db=unifi&precision=ns&rp=": dial tcp <IP_ADDRESS>:8086: connect: connection refused

UP_INFLUXDB_URL=http://<IP_ADDRESS>:8086

Instead of <IP_ADDRESS>, you should change that to the IP or hostname of your container running influxdb. If you have a custom bridge you can change it to influxdb (http://influxdb:8086).

That was it, thanks for the help.


feat: Define dependent version of Fin.foldl

This PR defines the dependent versions of Fin.fold{l/r}{M}. This is 4 functions in total, Fin.dfold{l/r}{M}, and we give similar theorems as the non-dependent versions, plus theorems that relate the dependent to the non-dependent version.
Two theorems are currently missing: dfold{l/r}_rev. Even stating these theorems is a pain due to casting, so I'd prefer to add them later.

Can you write the theorem relating it to the usual Fin.fold, with \alpha := \Sigma i, \alpha i?

Other directions that would be good:

just as we have Fin.fold and Nat.fold and a theorem relating them, we should have the "unbundled" version of this for Nat, and the theorem
we should have the monadic version as well.

Can you write the theorem relating it to the usual Fin.fold, with \alpha := \Sigma i, \alpha i?

Actually, I don't know how to state the theorem. A natural attempt is:
theorem fold_eq_foldl_sigma {α : Fin (n+1) → Sort _} (f : ∀ (i : Fin n), α i.castSucc → α i.succ)
    (x : α 0) :
    fold n α f x = foldl n (α := (i : Fin (n + 1)) × α i) (fun x i => f x.1 x.2) ⟨0, x⟩ := sorry

but we run into the problem of Lean not knowing that x.1 is supposed to be the same as i.castSucc during execution.

@kim-em could you protect Fin.cast in Lean 4 when you have time? The few _root_.cast uses here are annoying.

Looks good. Make sure to add specialize on the inner loops. If you have time, expand the docstrings using Init.Data.Fin.Fold as a model. I'll have another pass tomorrow after a good night of sleep!

Avoid code duplication by defininig:
@[inline] def dfoldrM [Monad m] (n : Nat) (α : Fin (n + 1) → Type _)
    (f : ∀ (i : Fin n), α i.succ → m (α i.castSucc)) (init : α (last n)) : m (α 0) :=
  dfoldr n (fun i => m (α i)) (fun i x => x >>= f i) (pure init)

Same for dfoldlM.

Avoid code duplication by defininig:
@[inline] def dfoldrM [Monad m] (n : Nat) (α : Fin (n + 1) → Type _)
    (f : ∀ (i : Fin n), α i.succ → m (α i.castSucc)) (init : α (last n)) : m (α 0) :=
  dfoldr n (fun i => m (α i)) (fun i x => x >>= f i) (pure init)

I'm not sure the same works for dfoldlM.

When I tried to do this, the theorems can't seem to infer the type of α and x.

The loop lemmas are no longer relevant after this change. The other lemmas are immediate consequences of the dfoldr lemmas.

I completed the last few changes for you. Let me know if you would like to revert something.

I just approved but I then noticed that the docstrings should not only refer to other functions. Please expand them and mention the relation with non-dependent functions as an additional note.

I filled out the docstrings. Thanks for all the help!

@kim-em could you protect Fin.cast in Lean 4 when you have time? The few _root_.cast uses here are annoying.

Done in https://github.com/leanprover/lean4/pull/6315


Deserialization Error in case of Collections

Hi Ruediger,
How are you !!
I am getting the same issue again, while deserializing arraylist object. I am using FST 2.40 version.
Please see below testcase,
public class EntitySuperClass implements Serializable{
private List tags;
}
public class Entity implements Serializable{
private String name;
private int id;
}
If i add new instance variable to Entity class(Forward compatibility),
public class Entity implements Serializable{
private String name;
private int id;
// New instance variable
private String address;
}
After deserialzing EntitySuperClass object, I am getting below exception
: class java.util.ArrayList deserialization problem
java.io.IOException: java.lang.RuntimeException:
To handle this issue , i have added version check in super class like,
public class EntitySuperClass implements Serializable{
@org.nustaq.serialization.annotations.Version(2)
private List tags;
}
public class Entity implements Serializable{
private String name;
private int id;
@org.nustaq.serialization.annotations.Version(2)
private String address
}
I am getting below exception
FSTSerializer : Deserialization error: java.lang.RuntimeException: read version tag -1 fieldInfo has 2
Deserialization error: java.lang.RuntimeException: read version tag 1 fieldInfo has 2
Please check, If u can help me out here.
Thanks

versioning support is shaky (severe logical restrictions I cannot workaround).
Will have a look into as i find time

Hello there,
org.nustaq.serialization.annotations.Version(), this also doesnot support backward compatibility.Is there any other work around.


Ignore Rancher metadata to avoid cluttering of terraform plan & terraform apply

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?
Rancher adds tags in namespace resource that make terraform consider those as changes and therefore add extra clutter to the terraform plan/apply commands.
In a big environment that can become quite distracting. For example:
 # module.eks_kubernetes_addons.module.aws_for_fluent_bit[0].module.helm_addon.module.irsa[0].kubernetes_namespace_v1.irsa[0] will be updated in-place
  ~ resource "kubernetes_namespace_v1" "irsa" {
        id = "aws-for-fluent-bit"

      ~ metadata {
          ~ annotations      = {
              - "cattle.io/status"                          = jsonencode(
                    {
                      - Conditions = [
                          - {
                              - LastUpdateTime = "2022-11-09T15:05:34Z"
                              - Message        = ""
                              - Status         = "True"
                              - Type           = "ResourceQuotaInit"
                            },
                          - {
                              - LastUpdateTime = "2022-11-09T15:05:34Z"
                              - Message        = ""
                              - Status         = "True"
                              - Type           = "InitialRolesPopulated"
                            },
                        ]
                    }
                ) -> null
              - "lifecycle.cattle.io/create.namespace-auth" = "true" -> null
            }
            name             = "aws-for-fluent-bit"

We get the above during every terraform plan/apply we do although we have not changed anything regarding the module.
This affects all clusters that are connected with rancher.
Describe the solution you would like
I am making a PR for the solution because I already use it as I create several namespaces using the k8s terraform provider in another project and I ended up having close to 100 of those entries as clutter, one for each namespace. Solution is to add to the namespace resource a lifecycle block as:
  lifecycle {
    ignore_changes = [
      metadata[0].annotations["cattle.io/status"],
      metadata[0].annotations["lifecycle.cattle.io/create.namespace-auth"]
    ]
  }

I have successfully used it with resource kubernetes_namespace I don't know if this works as expected with kubernetes_namespace_v1 you are using, but I see no reason that it should not. However I edited this locally to my environment, and it looks working without issues.
Describe alternatives you have considered
n/a
Additional context
n/a

Hello @askulkarni2 and thanks. After further searching (that I missed yesterday) that has been added as an option on the kubernetes provider level, which is better https://github.com/hashicorp/terraform-provider-kubernetes/releases/tag/v2.12.0
Let's close this and thanks a lot.


Update to MTK9

Recreation of the @sumiya11  's PR regarding MTK9

Now waiting for the discrete-time systems come back to MTK (may happen next week)


Shell command work with "ZEROCONF" but not "USER_PASS"

Shell commands work with "ZEROCONF" but not "USER_PASS" on v1.6.1.
Yeah weird, toke me some time to catch this critter.

Can you attach a log with trace verbosity and try toggling the volume for example?

I did this and nothing concerning shell commands was logged. No "Failed executing command" and no "Executed shell command" message.

Hello, i'm using 1.6.2, and shell commands does not work regardless of the authentication method used.
The configuration:
[shell] 	onTrackSeeked = "" 	onStartedLoading = "" 	onConnectionDropped = "rm -rf /opt/hifi/spocon-connected" 	onMetadataAvailable = "" 	onTrackChanged = "" 	onPanicState = "" 	onFinishedLoading = "" 	# Shell events enabled 	enabled = true 	onPlaybackResumed = "" 	onConnectionEstablished = "touch /opt/hifi/spocon-connected"


Added IOB/COB options to display, updated to v2 API

Added ability to view Insulin on Board or Carbs on Board in place of Clock.
Updated to use the v2 API.
Updated to call properties endpoint for iob/cob/direction/current/delta, and only call entries when graph is shown to help minimize calls.

I have reviewed these updates with Jim and we've both thoroughly tested. This has my blessing.


P3: Clicking anywhere outside of the expanded sort menu dropdown should close the dropdown

At the moment, the only way to close the sort menu is to click on the Sort By tab again. It would be a minor UX improvement to allow for the dropdown to close by clicking anywhere outside of it.

That's a great point! I'd definitely recommend for the users sake to have an “x” or “close” button on that drop down along with the ability to close by clicking outside of it. If central was ever being used on different devices in the future, sometimes certain viewports can make it difficult to click outside of a menu. Ie: the menu could take up a lot of the screen on a small screen


minor copy editing of comments

Thanks. I'll admit English is not my first language and I overlook a lot of grammatical aspects.

Very glad to help out - and quite thankful I don't have to dust off my French to get started!


Add limit on the file size that can be opened with Open XEL feature

This PR works on fixing https://github.com/microsoft/azuredatastudio/issues/23806.
For files within 100MB, no notification is posted.
For files from 100MB-1GB, a notification is posted:

For files more than 1GB, an error is thrown and file is not loaded:

Just to add context here, here are the numbers from testing the open XEL feature:
Immediately opens for 200KB file.
~ 2secs for 8MB file.
~ 15-18secs for a 250MB file.
~ 36-38secs for a 600MB file.
~ 1min for a 900MB file.
~ 3mins for 0.99GB file.

Created following work items as discussed:
https://github.com/microsoft/azuredatastudio/issues/23883
https://github.com/microsoft/azuredatastudio/issues/23885


Fix vars leaking into global scope

Using this package with mocha's check-leaks flag was throwing an error for global leak detected. I traced it back to these two vars in this lib. Seems like they don't need to be global, so I scoped them.

Thanks! I'll merge and bump this evening

Sweet, thanks!

bump: is this going to be merged? node is currently throwing up errors in strict mode due to this.


Coursera Code of Conduct

Isn't publishing exercise solution against coursera's honor code ?

Yes jcanelhas. Only if we copy it. Its knowledge and deserve to be shared otherwise.

https://learner.coursera.help/hc/en-us/articles/209818863
Check the 3rd bullet point.

This repo goes against the code-of-conduct. There's a reason why discussion forums exist for this course.

[ ] test

https://imagebin.ca/v/3h0QSUXeZhBt


Scrolling causes selection in vim-startify

Scrolling using mousewheel causes selection in vim-startify
init.vim:
if empty(glob('~/.config/nvim/autoload/plug.vim'))
	silent !curl -fLo ~/.config/nvim/autoload/plug.vim --create-dirs
	\ https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim
	autocmd VimEnter * PlugInstall --sync | source $MYVIMRC
endif
let g:ale_completion_enabled = 1
call plug#begin('~/.config/nvim/plugged')
Plug 'tpope/vim-fugitive'
Plug 'tpope/vim-surround'
Plug 'ctrlpvim/ctrlp.vim'
Plug 'dracula/vim', { 'as': 'dracula' }
Plug 'dense-analysis/ale'
Plug 'scrooloose/nerdTree'
Plug 'ryanoasis/vim-devicons'
Plug 'vim-airline/vim-airline'
Plug 'vim-airline/vim-airline-themes'
Plug 'mhinz/vim-startify'
Plug 'justinmk/vim-gtfo'
Plug 'akiyosi/gonvim-fuzzy'
Plug 'psliwka/vim-smoothie'
call plug#end()

set mouse=a

set number
set guifont=Iosevka\ SS05:h12
highlight LineNr term=bold cterm=NONE ctermfg=DarkGrey ctermbg=NONE gui=NONE guifg=DarkGrey guibg=NONE
highlight Comment cterm=italic gui=italic

set runtimepath^=~/.config/nvim runtimepath+=~/.config/nvim/after
let &packpath = &runtimepath
set clipboard+=unnamedplus
let g:airline_theme='murmur'

let g:airline#extensions#ale#enabled = 1
let g:airline#extensions#statusline#enabled = 1
let g:airline#extensions#tabline#enabled = 1
let g:airline#extensions#wordcount#filetypes = '\vasciidoc|help|mail|markdown|markdown.pandoc|org|rst|tex|text'

nmap <C-n> :NERDTreeToggle<CR>
source /home/chinmay/.config/nvim/devicons.vim

let g:ale_fixers = {
\   '*': ['remove_trailing_lines', 'trim_whitespace'],
\   'bash': ['language_server'],
\   'java': ['eclipselsp'],
\}

let g:ale_sign_error = '×'
let g:ale_sign_warning = '!'
let g:ale_java_eclipselsp_config_path='$HOME/.jdtls'

setting.toml:
[Editor]
# Editor minimum window width (>= 400)
Width = 800
# Editor minimum window height (>= 300)
Height = 600

# Start maximized window
StartMaximizedWindow = false

# Start fullscreen
StartFullscreen = false

# Editor external font-family, font-size, and linespace.
# This is the font and linespace settings of the graphical UI as an nvim front end.
# For example, linespace affects the margins of the external completion popup menu UI.
# Font settings in nvim are set with well-known options, such as `:set guifont = hoge:h10`, `:set linespace=4`.
FontFamily = "Iosevka SS05"
FontSize = 12

Linespace = 0

# Neovim external UI features
# The following is the default value of goneovim.
# You can change the behavior of the GUI by changing the following boolean values.
# If you prefer the traditional Vim UI, set it to false for all.
# Also, `ExtMessages` is still experimental at this time and we don't recommend setting it to true if you want stability.
ExtCmdline = true
ExtPopupmenu = true
ExtTabline = true
ExtMessages = true

# Drawing window border instead of vertical split, statusline
# Draw borders on the GUI side instead of the vertical border and status line that nvim draws.
# This option assumes that you use an external status line.
#DrawBorder = true

# Copy yanked text to clipboard
Clipboard = true

# Disable IME in Normal mode
# This option disables the input method editor(IME) in normal mode.
# For example, it may be useful for East Asian users who use the input method editor.
DisableImeInNormal = false

# Transparent window alpha
# Note: This setting also implicitly enables the Drawborder setting
# This option makes the whole GUI window in semi-transparent.
#Transparent =1

# Draw indent guide
# Enable this option to draw a simple indent guide.
# Indentation width is calculated based on the value of `tabstop` set in nvim.
IndentGuide = true

# Desktop Notifications
# Enable desktop notification settings for nvim messages.
# This option works only if `ExtMessages` is enabled.
DesktopNotifications = false

# Pattern that fills the diff background
# Change the background pattern used for diff display.
# This option allows you to use a visual effect pattern such as Dense, Diagonal Stripe instead of a regular solid pattern.
# The available patterns are all Qt brush styles. For more information, See: https://doc.qt.io/qt-5/qbrush.html#details
# // -- diffpattern enum --
# // SolidPattern             1
# // Dense1Pattern            2
# // Dense2Pattern            3
# // Dense3Pattern            4
# // Dense4Pattern            5
# // Dense5Pattern            6
# // Dense6Pattern            7
# // Dense7Pattern            8
# // HorPattern               9
# // VerPattern               10
# // CrossPattern             11
# // BDiagPattern             12
# // FDiagPattern             13
# // DiagCrossPattern         14
# // LinearGradientPattern    15
# // RadialGradientPattern    16
# // ConicalGradientPattern   17
# // TexturePattern           24
Diffdeletepattern = 12
Diffchangepattern = 12
Diffaddpattern = 1

[Statusline]
Visible = false

# Options: “textLabel” / “icon” / “background” / “none”
ModeIndicatorType = "textLabel"

# Optional setting colors per Neovim editing modes
NormalModeColor = "#3cabeb"
CommandModeColor = "#5285b8"
InsertModeColor = "#2abcb4"
ReplaceModeColor = "#ff8c0a"
VisualModeColor = "#9932cc"
TerminalModeColor = "#778899"

# Statusline components
Left = [ "mode", "filepath", "filename" ]
Right = [ "message", "git", "filetype", "fileformat", "fileencoding", "curpos", "lint" ]

[Palette]
Transparent = 0.8

[Message]
Transparent = 0.8

[Popupmenu]
# show detail column
ShowDetail = true
# total number to display item
Total = 20
# width of `menu` column
MenuWidth = 400
# width of `info` column
InfoWidth = 1
# width of `detail` column
DetailWidth = 250

[Tabline]
Visible = true

[Lint]
Visible = true

[ScrollBar]
Visible = true

[MiniMap]
Visible = false

[SideBar]
Visible = false
DropShadow = false
Width = 200
AccentColor = "#5596ea"

[Workspace]
# This setting sets the format of the path string of CWD in the sidebar.
#  name: directoryname
#  full: /path/to/directoryname
#  minimum: /p/t/directoryname
PathStyle = "minimum"

# Restore session — information that was ended without being saved
RestoreSession = false

Screencast gif

Since the second file is selected, it looks like 1 is pressed

I thought it was like #109 but i tried pressing shift too

Hi
Thanks for the report this issue.
Goneovim will scroll by inputing n or n where n is a number of scroll amount.
This is actually equivalent to call function such that
call nvim_input("2<C-e>")

The problem you reported seems to be that vim-startify is responding to the scroll amount number specified in the function argument above.
I'm trying to figure out how to fix it. Umm...

This is actually equivalent to call function such that
call nvim_input("2<C-e>")

Thanks for this info. For the time being, I think I can patch the vim-startify plugin


Ensure to use .env port or given port

Fixes https://github.com/hanami/hanami/issues/1264
Ref https://github.com/hanami/hanami/pull/1266
Ref https://github.com/hanami/cli/pull/70

Confirmed by @kucho https://github.com/hanami/hanami/issues/1264#issuecomment-1334445899


rafthttp: support sending v3 snapshot message

Use pipelineSnapshot to send v3 snapshot message. It puts v3 snapshot
message bytes into request body, then sends it to the target peer.
When it receives http.StatusNoContent, it knows the message has been
sent successfully.
As receiver, snapHandler receives full v3 snapshot message, saves snapshot
, processes the raft snapshot message, then respond with
http.StatusNoContent.
I have manually tested it.
follow #3648
for #3549

I cannot understand the design you made here. Why do we call the snapshot sender a pipeline? If I understand the code correctly, after it sends out one snapshot request the other side will close the HTTP request. I cannot understand why it is a pipeline at all. :(

I thought making it align with pipeline could make code easier to read. It
does send http request for each message, and close it after sending. Based
on your description, it doesnt match its name. I will rename it back to
snapshotSender.
On Mon, Oct 12, 2015 at 18:53 Xiang Li<EMAIL_ADDRESS>wrote:

I cannot understand the design you made here. Why do we call the snapshot
sender a pipeline? If I understand the code correctly, after it sends out
one snapshot request the other side will close the HTTP request. I cannot
understand why it is a pipeline at all. :(
—
Reply to this email directly or view it on GitHub
https://github.com/coreos/etcd/pull/3666#issuecomment-147571714.

@yichengq The logic also does not make sense to me. I do not understand why do we need a dedicated go routine to wait for the snapMsg.

@xiang90 Updated with no dedicated goroutine to wait for the snapMsg. Originally I wanted to use an long-time entity to manage snapMsg send, but it became heavy. Remove it to make the logic simple.

Can you explain to me what will happen when:

the snapshot sender dies without closing underlying TCP connection?

the snapshot receiver dies without closing underlying TCP connection?

If the snapshot is large and takes a long time, is there anything will be affected?

If one snapshot sending fails, how the does retry mechanism work?

what happens if a leader wants to send 2 snapshot concurrently to 2 followers?

I am asking since I cannot find out the handling logic from code or any related timeout setting or comments.

the snapshot sender dies without closing underlying TCP connection?

I think the receiver keeps waiting for the request body, and stops the handler when it detects TCP connection is down due to TCP keepalive mechanism. If another leader is elected in this period, and send it the snapshot with the same index, it still could save it to disk and recover from there. So I think it is fine.

the snapshot receiver dies without closing underlying TCP connection?

If receiver dies when it is sending request body, receiver should be notified soon because TCP connection cannot write anything out.
If receiver dies when it is waiting for response, receiver needs to wait for TCP keepalive to notice it about the connection down. This is something missing now, I will improve.

If the snapshot is large and takes a long time, is there anything will be affected?

It could occupy all resources and even affect heartbeat between leader and followers. My plan for this is to test and fix it after this PR.

If one snapshot sending fails, how the does retry mechanism work?

If one snapshot fails, rafthttp.snapshotSender will report SnapshotFailure to raft state machine. raft state machine change its progress to probe and pause a while. Then raft state machines makes a new snapshot and send it to the follower again.

what happens if a leader wants to send 2 snapshot concurrently to 2 followers?

The first snapshot will be made successfully, and send out. The second snapshot will be blocked because snapshot cannot be made due to ErrSnapshotTemporarilyUnavailable. After the first snapshot is sent out, the second snapshot could be made and sent out.
I would try to address these questions through more comments.

If receiver dies when it is waiting for response, receiver needs to wait for TCP keepalive to notice it about the connection down. This is something missing now, I will improve.

What is your plan? The affects my 5 question a lot.

It could occupy all resources and even affect heartbeat between leader and followers. My plan for this is to test and fix it after this PR.

What is the plan?

The second snapshot will be blocked

What do you mean by blocking? From the code, I think the snapshot sending will be canceled rather than blocked.

My draft plan for receiver dies when sender is waiting for response is to let snapshotSender cancel the request if it has waited for a long time(~5s) after it has write out the full request body.
My plan for large snapshot sent is to send the snapshot block by block, and rest some time between each block sent to let main loop work.

What do you mean by blocking? From the code, I think the snapshot sending will be canceled rather than blocked.

When raft state machine wants to send snapshot message to the second member at that time, it will receive ErrSnapshotTemporarilyUnavailable and cancel the snapshot sending. After some time, it would try to send snapshot message again. blocking is inaccurate, it is keep retrying.

@yichengq Can you please add TODOs into the current code? So that I can properly review the code without worrying about these issues?

TODO added. I am adding comments to address the above 5 questions now.

comments for questions added. Ready for the review.

Addressed all comments. PTAL.

Addressed comments about function names. Hope they look better this time.

Refine the names. PTAL

Address previous round of comments. Check it to see whether it is good.

 There is basically no test. Do we have a plan to add more tests?

Haven't yet. It still misses one PR to make snapshot send work, another PR to make large snapshot send work. When I manually tested it about normal situation, I added some hack to make it work. I would like to test failure cases after the missing one is added.
BTW, list some possible failure cases that come into my head now: snapshot sender dies when sending, snapshot receiver dies when receiving, sending to two followers.

Do we have a plan to add more tests?

Definitely. You will see me send PR after getting all these done. I have added one TODO in https://github.com/coreos/etcd/issues/3550, and it would need integration tests.

Can you please squash all the commits into one? Then I will take a final look. It is pretty close.

squash done.

Is the commit message correct?
Use pipelineSnapshot to send v3 snapshot message. It puts v3 snapshot
message bytes into request body, then sends it to the target peer.
When it receives http.StatusNoContent, it knows the message has been
sent successfully.

LGTM

Is the commit message correct?

No. Have updated to match the current situation.

LGTM again.

waiting for CI pass.


ci(tests): tests for providers are rate-limited and failing

Zora and Infura provider's tests are failing with the Rate limited errors.

The issue is solved for now, monitoring it before confirming and closing.

Still failing, reopening for the fix.


Revert "Make query rate growth measurement less sensitive to sudden bursts"

Reverts vespa-engine/vespa#31866
Broke ControllerMaintainer.

@mpolden


tests: Remove workaround for RegisterAddress assertion

Description of proposed changes:
Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

Codecov Report

Merging #169 (fcc56ba) into dev (6bae64c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #169   +/-   ##
=======================================
  Coverage   58.02%   58.02%
=======================================
  Files          33       33
  Lines        5673     5673
=======================================
  Hits         3292     3292
  Misses       2381     2381

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Properly shutdown endpoints in h2_http_proxy

Shutdown the endpoint only if both read and write failures are observed on that endpoint.
Addresses the issue: https://github.com/grpc/grpc/issues/13124

This change is

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

This looks pretty good.  My comments are fairly minor.

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

test/core/end2end/fixtures/http_proxy_fixture.cc, line 165 at r3 (raw file):

  if (ep_state != new_ep_state) {
    conn->ep_state = new_ep_state;

Nit: Please remove unnecessary blank lines within functions.

test/core/end2end/fixtures/http_proxy_fixture.cc, line 249 at r3 (raw file):

  proxy_connection* conn = (proxy_connection*)arg;
  if (error != GRPC_ERROR_NONE) {
    // Report a read failure on the client endpoint. If there is no pending

It seems a bit messy to handle this here, because we're basically lying to proxy_connection_failed() by telling it that there was a server endpoint failure when there really wasn't any.  Instead, how about having proxy_connection_failed() directly check server_is_writing to decide whether or not to shut down the server endpoint when it sees a client endpoint failure?

test/core/end2end/fixtures/http_proxy_fixture.cc, line 287 at r3 (raw file):

  proxy_connection* conn = (proxy_connection*)arg;
  if (error != GRPC_ERROR_NONE) {
    // Report a read failure on the server end point. If there is no pending

Same here.

test/core/end2end/fixtures/http_proxy_fixture.cc, line 494 at r3 (raw file):

  conn->proxy = proxy;
  gpr_ref_init(&conn->refcount, 1);
  conn->ep_state = 0;

Not necessary, since we allocate the struct via gpr_zalloc() a few lines above this.

Comments from Reviewable

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.

test/core/end2end/fixtures/http_proxy_fixture.cc, line 165 at r3 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
Nit: Please remove unnecessary blank lines within functions.

Done.

test/core/end2end/fixtures/http_proxy_fixture.cc, line 249 at r3 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
It seems a bit messy to handle this here, because we're basically lying to proxy_connection_failed() by telling it that there was a server endpoint failure when there really wasn't any.  Instead, how about having proxy_connection_failed() directly check server_is_writing to decide whether or not to shut down the server endpoint when it sees a client endpoint failure?

Actually this is messy no matter where we do it. I felt it is better to keep proxy_connection_failed to be dumb. The callers just "report" client/server read/write endpoint failures to it.  If it notices both read and write failures in a particular endpoint, it shuts it down.
Also, proxy_connection_failed is also called by the other callbacks used during initial connection establishments - and any failure during that time must be considered a failure in both endpoints. So that requires another special-case in proxy_connection_failed.
Considering this, it felt like its  a (relatively) cleaner way to keep proxy_connection_failed's logic simple

test/core/end2end/fixtures/http_proxy_fixture.cc, line 287 at r3 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
Same here.

(See previous comment)

test/core/end2end/fixtures/http_proxy_fixture.cc, line 494 at r3 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
Not necessary, since we allocate the struct via gpr_zalloc() a few lines above this.

Done

Comments from Reviewable

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Failures are known:
Asan C++ (internal CI) : https://github.com/grpc/grpc/issues/13122
Basic Tests C++ Linux [dbg] (internal CI): https://github.com/grpc/grpc/issues/13330
Tsan C++ (internal CI): https://github.com/grpc/grpc/issues/13122

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

test/core/end2end/fixtures/http_proxy_fixture.cc, line 249 at r3 (raw file):
Previously, sreecha (Sree Kuchibhotla) wrote…
Actually this is messy no matter where we do it. I felt it is better to keep proxy_connection_failed to be dumb. The callers just "report" client/server read/write endpoint failures to it.  If it notices both read and write failures in a particular endpoint, it shuts it down.
Also, proxy_connection_failed is also called by the other callbacks used during initial connection establishments - and any failure during that time must be considered a failure in both endpoints. So that requires another special-case in proxy_connection_failed.
Considering this, it felt like its  a (relatively) cleaner way to keep proxy_connection_failed's logic simple

I can deal with this being messy, as long as the messiness is hidden behind an API with clear semantics.  Right now, we don't have a clean API for proxy_connection_failed(): the function says that the caller should tell it the types of failure has occurred, but what we are actually giving it is a separate set of flags that tells it what to actually do, and the state controlling that decision is split between proxy_connection_failed() and its callers rather than being centralized in one place.
Please see the following PR for my suggested approach:
https://github.com/sreecha/grpc/pull/10

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

test/core/end2end/fixtures/http_proxy_fixture.cc, line 249 at r3 (raw file):
Previously, markdroth (Mark D. Roth) wrote…
I can deal with this being messy, as long as the messiness is hidden behind an API with clear semantics.  Right now, we don't have a clean API for proxy_connection_failed(): the function says that the caller should tell it the types of failure has occurred, but what we are actually giving it is a separate set of flags that tells it what to actually do, and the state controlling that decision is split between proxy_connection_failed() and its callers rather than being centralized in one place.
Please see the following PR for my suggested approach:
https://github.com/sreecha/grpc/pull/10

Thanks for the PR. I see your point. I merged your commit and send the updated PR with your changes.

Comments from Reviewable

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[trickle] No significant performance differences

Thanks for fixing this!

Reviewed 1 of 1 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

ProxyEnd2end/ProxyEnd2endTest.RpcDeadlineExpires failed. Known issue (
https://github.com/grpc/grpc/issues/11008 and https://github.com/grpc/grpc/issues/12917)


Make delimited_by take parsers as arguments

Closes #52

Thanks for the PR! There's just one thing I'd like to see changed before merging.

Thanks for the PR! There's just one thing I'd like to see changed before merging.


channel_ready_future().result() should return the channel, not None

What version of gRPC and what language are you using?
The Google internal version (which I believe tracks the latest release here).
What operating system (Linux, Windows, …) and version?
Linux
What runtime / compiler are you using (e.g. python version or version of gcc)
Python 2.7
What did you do?
def NewChannel(self):
    channel_credentials = self._FetchCredentials()
    channel = grpc.secure_channel(
        'localhost:{}'.format(self._port), channel_credentials)
    return grpc.channel_ready_future(channel).result()

What did you expect to see?
I was expecting the result of "NewChannel" to be the channel, itself.
What did you see instead?
Apparently, channel_ready_future's "result" is always None. Apparently the correct code (with the gRPC code as it is right now) is:
def NewChannel(self):
    channel_credentials = self._FetchCredentials()
    channel = grpc.secure_channel(
        'localhost:{}'.format(self._port), channel_credentials)
    grpc.channel_ready_future(channel).result()
    return channel

However, this is because the behavior of ChannelReadyFuture violates the principle of least surprise; a future whose name is described with the name of some other noun should be returning an object of that noun type on completion; a "channel ... future" should be returning a channel.

This is something we considered and deliberately decided against, because we (1) don't like APIs that give to the user something they already have (the channel, in this case) and (2) your ellipsis captures too much; it's not the channel that the Future is "computing" but rather the "readiness of the channel" (which is more of a "state of the world" than a simple value that can be returned).
Something that's worth exploring is how much the semantics of the object returned by channel_ready_future really matter - when we were building gRPC Python the forecast was that channel connectivity would be something of an edge case and that the vast majority of users would, wanting to make an RPC but not having a channel, just construct a channel and use it to invoke an RPC without intermediately waiting for the channel to be ready. Help us understand what you're doing and why you need to block until the channel is ready in a separate statement of code?


Update galaxy-intro-short slides

Still need to update/create the video recording for this. And also, the Spanish (ES) tutorial is still not updated (neither the .md or the slides)
Could I get some hints on what folk use to create the voice narrated video slides, or are they auto-generated once this gets merged?

@ahmedhamidawan they are autogenerated. Please have a look at https://training.galaxyproject.org/training-material/topics/contributing/tutorials/create-new-tutorial-slides/slides.html#20

@bgruening Thank you! Seems like this one already had video: true, and I have updated the speaker notes as well.


Whoops - Unable to change current password

Issue:
Unable to update current password.
Whoops when trying to update current password.

Duplicate #63


CookieJar does not work in Flutter-web.  What is the point?

Package
cookie_manager
Version
3.1.0
Output of flutter doctor -v
In `cookie_jar.dart` there is the code:

const _kIsWeb = bool.hasEnvironment('dart.library.js_util')
    ? bool.fromEnvironment('dart.library.js_util')
    : identical(0, 0.0);
:
:
  factory CookieJar({bool ignoreExpires = false}) {
    if (_kIsWeb) {
      throw UnimplementedError();
    }

So this is never going to work in Flutter Web?

### Dart Version

_No response_

### Steps to Reproduce

final cookieJar = CookieJar();

### Expected Result

`cookieJar` initialised

### Actual Result

Exception

The cookie_manager can work with Flutter Web if you enabled BrowserHttpClientAdapter.withCredentials. The cookie_jar doesn't support Flutter Web though.

The cookie_manager can work with Flutter Web if you enabled BrowserHttpClientAdapter.withCredentials. The cookie_jar doesn't support Flutter Web though.

Awesome.  But how can I use cookie_manager with out CookieJar?
The example is:
  final dio = Dio();
  final cookieJar = CookieJar();
  dio.interceptors.add(CookieManager(cookieJar));

That typically means you'll need the cookie_manager only when the environment is Flutter Web.

That typically means you'll need the cookie_manager only when the environment is Flutter Web.

I am not quite sure I understand.
The problem is that CookieManager  cannot be used in Flutter Web
I need access to the "set-cookie" header in the response, but it is filtered out (the server is sending it, I can see it in Chromeium. developer tools).
The request is an XML HttpRequest made after the app is initialised.
I got round the CORS issue with launch.json (I am using VSCode):
            "args": [
                "-d",
                "chrome",
                "--web-browser-flag",
                "--disable-web-security"
            ]

I am getting a lot of headers back, just not the one I need.

Try to enable the BrowserHttpClientAdapter.withCredentials and you won't need to use packages on Flutter Web.

Try to enable the BrowserHttpClientAdapter.withCredentials and you won't need to use packages on Flutter Web.

Thank you for your attention.  I am feeling my way through flutter web, porting a desktop flutter programme.  I need this so I can develop, test, and debug this software on my computer, without having to do that on the hosting server.
However using the BrowserHttpAdapter has not helped.
This is what I have:
    final dio = Dio();
    dio.httpClientAdapter = BrowserHttpClientAdapter(withCredentials: true);
    dio.options
      ..connectTimeout = const Duration(seconds: 50)
      ..receiveTimeout = const Duration(seconds: 50)
      ..validateStatus = (int? status) {
        return status != null && status > 0;
      }
      ..headers = {
        "Content-Type": "application/x-www-form-urlencoded; charset=UTF-8",
        "Accept": "application/json, text/javascript, */*; q=0.01",
      };
    // dio.httpClientAdapter = Http2Adapter(ConnectionManager());
    Response response = await dio.post(url.toString(), data: bodyData);

And these are the headers:
request.responseHeaders: cache-control: no-store
cache-control:  no-cache
cache-control:  must-revalidate
content-length: 142
content-type: application/json; charset=UTF-8
date: Wed
date:  12 Jul 2023 20:45:42 GMT
expires: Thu
expires:  19 Nov 1981 08:52:00 GMT
pragma: no-cache
server: Microsoft-IIS/10.0
x-powered-by: PHP/7.4.15

Looking deeper it appears that chrome is filtering out the set-cookie header.
I can see it in the network tab of chrome, but I cannot see it in flutter.
This is not the fault of Cookie Jar, even though Cookie Jar does not work (yet) for Flutter Web.


ORC-771: ORC timestamp consistency Test for sql.Timestamps close to epoch

What changes were proposed in this pull request?
ORC-763 has a long discussion about the sql.Timestamp bug and how ORC goes around it.
Why are the changes needed?
This ticket introduces a Test to ensure consistency with the expected behaviour – as we have on C++ side of things.
How was this patch tested?
TestVectorOrcFile.testTimestampBug

Thank you for working on this, @pgaref .

cc @wgtmac

Merged to master/1.6.

Thanks!


As a developer, I want to setup Tortoise TTS, so that I can generate high quality audio from text.

Acceptance Criteria:

[x] Text-to-speech functionality works seamlessly.

[x] Generate audio from a sample text input.
[x] Verify the quality of the generated audio.

[x] Integration with the desired programming language (e.g., Python) is functional.

[x] Test the integration by calling Tortoise TTS functions in a sample script.

Demo Steps:

Call the /tts endpoint with the text, podcast id, episode id, and speaker name.
Wait for the audio to be generated.

Potential Risks:

[x] Compatibility issues with specific operating systems or Python versions.
[x] Limited language support for text-to-speech generation.
[x] Dependency conflicts with existing libraries in the project.

Technical Notes:

[x] Ensure that the development environment has the required dependencies installed (e.g., ffmpeg).
[x] Consult the official Tortoise TTS documentation for any troubleshooting or additional configuration options.
[x] Keep track of updates to Tortoise TTS for potential improvements and bug fixes.

Risks

The compatibility issue is handled by using docker to ensure that the environment remains compatible.
The language support is handled by having CoquiTTS as a backup option, which provides a multi language model.


Simplifying Repository Structure for Automated Batch Script Setup

Issue: Simplifying Repository Structure for Automated Batch Script Setup
Description:
Hi Chris,
I wanted to suggest a modification to the repository structure that would make it easier to set up using automated batch scripts.
Proposed Repository Structure:

Benefits of the Proposed Structure:

Centralized setup: By moving all the necessary files and directories to the repository's root, we can create a more centralized setup.
Automated batch script: For example at: ExperimentProtocol-TBSiEEG. With the new structure, we can create a batch script that automates the setup process, including virtual environment creation and dependency installation.
Improved user experience: Users will have a smoother onboarding experience, reducing the chance of errors and manual setup steps.

Next Steps:
I kindly request your consideration of this proposed modification to enhance the user experience and simplify the setup process. If you find it feasible, I would be more than happy to contribute to implementing these changes.
Best regards,
Umair

Closing since this is not within the scope of this repo, handling separately!


Suggestions

As a response to https://github.com/sindresorhus/awesome/pull/672#issuecomment-228603265
I have a few comments regarding what I think is missing in this list:

for ALL major browsers, you can list where you can get the userscript manager (e.g. I am using Safari most of the time, others might be using IE/Edge, perhaps some people are using Opera, Vivaldi, Maxthon, ...)
I think it's really strange that you don't even link back to userscripts.org
There are quite some interesting scripts for GitHub as well (e.g. Monospaced edit fields, commit line limits, ...), those are ones that many people could benefit from

All improvements were completed, thank you!


Publish another release

With the recent closure of the following PRs, I'd appreciate a fresh release to take advantage of these changes in my project.

#13
#15
#19

The only other immediate change I had considered advocating was upgrading Feign to something newer, though my project is pinned for now at using Ribbon version 2.0.0.

+1, I'd really like to make use of #15, but can't feasibly do so without a release.

Here you go.

Thank you!  Much appreciated!

Thank you!

It looks like we still need to run mvn deploy.

@seh If you mean publishing it to Maven Central, then, unfortunately, I do not have rights to cc.roden group. I guess we have to ask @WillAbides for that. Or maybe there is another way I do not know about?

I had suspected this would be a problem. Without further reading, I don't know how one manages those publishing rights. Presumably @WillAbides would have to grant permission to others, or share the JIRA credentials alluded to here.


Improve performance

Motivation and Context
For census test, we are anticipating a sample size of 340,000, which we would like to process very quickly end-to-end to where the print files are generated.
What has changed
Increased the number of consuming threads from Rabbit and the number of connections in the DB connection pool, allowing the ActionInstructions to be written to the DB really quickly from the Rabbit queue.
How to test?
Do a performance test using a sample of 340k. It should take less than an hour to produce the print files.
Links
Trello: https://trello.com/c/cJe5qYfq/746-defect-action-exporter-hasnt-been-performance-optimised

 Defect: Action Exporter hasn't been performance optimised


Fix formatter to older version

As an alternative to https://github.com/trixi-framework/Trixi.jl/pull/1842, I fixed the version of JuliaFormatter to an older one.

Should the scripts in utils also be changed?
https://github.com/trixi-framework/Trixi.jl/blob/main/utils/trixi-format.jl
https://github.com/trixi-framework/Trixi.jl/blob/main/utils/trixi-format-file.jl

Good suggestion, thanks!

Thanks again!


Bump csi-driver-host-path version up to v1.12.0

Bump csi-driver-host-path version up to v1.12.0
Partial Fix: https://github.com/kubernetes/kubernetes/issues/120997

/ok-to-test

/release-note-none

/lgtm
/approve


Concerns about missing locations

On 30 March, we had 310 missing municipalities. Based on the RIVM report, there are no missing provinces today. Is this possible? Are they imputing with the GGD region? Or do they no longer include missing locations? That would be interesting. Any thoughts on this?
12595 - (126 + 166 + 130 + 1475 + 161 + 1426 + 3412 + 1845 + 698 + 1046 + 161 + 1949) = 0

I think the data is imputed. For 30-04-2020, the numbers add up as well. Then, there were 310 missing municipalities, but the report was able to assign them to a province.
I will reopen this one if anyone has new insights.


tls: fix openssl 509 null chain malloc leak

Introduced from https://github.com/envoyproxy/envoy/pull/35513
Commit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/assign @yanavlasov

cc @keithmattix


Player timing out causes all future leave messages from user to be treated as timeouts

I've noticed that if a user disconnects via timeout that any time they leave the server normally after that the messages are all shown in discord as "___ timed out!"
For instance, here are the server logs of a player who timed out twice, and then left normally the third time they disconnected:

But this is what the discord bot sent (ignore the time difference for the hours, it's just different timezones):

From looking at the code, it seems that the timeouts array might not have the player being removed correctly. Maybe there needs to be a mixin that removes a player from the timeout list upon connecting as well as the existing disconnect mixin, as it seems just removing from the list after sending the timeout message isn't serving that purpose as expected.

There was already an fix PR to the forge version, will be implementing a semilar fix to fabric, too
( https://github.com/ErdbeerbaerLP/DiscordIntegration-Forge/pull/367 )


Can’t read ionic build in iOS app from document folder

Hi All,
I read ionic build file from document folder which is in iOS app.First time it’s work correctly.Then i updated build file in document folder but updated changes not reflected in UI.

Hello! Thanks for opening an issue with us! As this seems like more of a support question I will urge that you ask this question on our forum or on our slack channel. Thanks for using Ionic!


feat: calculated milestone values diffing

#1616

I think we could use assertions for calculated fields in the subsequent revision cypress test as well as the create one
I think the unit tests should take care of this. I've added assertions to the create project revision e2e test as well.


Thanks

try URL:  http://localhost:8080/web/html/layout.html  directly after starting the program.

Hi @evnix I get the same error.
[GIN] 2016/10/10 - 07:50:30 | 404 |     139.285µs | ::1 |   GET     /web/html/layout.html

I got the same error. The problem the following:
You taked the binary to an other folder, andthis tool couldn't handle it. I made a pull request where you can determine the static files location.

Unless I'm missing something, I'm hitting the same problem, even if I pulled from github today.
My web/ dir is empty. Is it supposed to be filled by me? I thought that boltdbweb had a default theme already set...
$ boltdbweb --db-name=test.db --port=8088 --static-path=/home/fede/web/golang/boltdbweb-test/web
 INFO[0000] starting boltdb-browser..
[GIN-debug] [WARNING] Running in "debug" mode.  The first command didn't work because I forgot to delete the empty web directory in my working directory.
Now everything works as expected, sorry for the noise!


don't display problem shares when campaign has win module

b/c we'll have the win shares we want the user to focus on sharing that rather than the problem
@lkpttn you're working on designs for what gets shared yeah?

Just the new content in our current social share design?

Closed with #4862


Useful links

https://choosealicense.com/
https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-software.html
https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-compatibility.html

https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-software.html

https://reuse.software/comparison/
https://pypi.org/project/reuse/
https://git.gfz-potsdam.de/id2/software/services/fair/software-quality-assurance

(from suggestions from @mdolling-gfz over at research-software-directory: https://github.com/research-software-directory/research-software-directory/issues/766)

https://github.com/librariesio/license-compatibility - Check compatibility between different SPDX licenses, used by Libraries.io for checking dependency license compatibility.

https://spdx.dev/

has yaml schema spec for listing software with their dependencies and licenses
has list of tools

Can we convert this to a awesome list or store it elsewhere?

https://github.com/philips-software/spdx-action - action which calls ort and then creates a spdx file

Can we close this? It served its purpose.


Elements no longer grabbing my keyboard

At some point in the last few days, something happened on my system, because after a reboot yesterday, Karabiner Elements is no longer able to grab my keyboard.
[2019-03-23 23:27:50.030] [warning] [grabber] Corsair K95 RGB Gaming Keyboard (device_id:4294968117) is ungrabbable temporarily by a failure of accessing device.

I've tried restarting the service, unplugging and re-plugging the keyboard, disabling anything else that might be manipulating the keyboard, but nothing seems to be working. Any ideas about what might be causing the keyboard to be ungrabbable all of a sudden?

I am having this issue as well


Display enhancement for Custom field.

Environment

Python version:  3.4.x
NetBox version:  2.4.3

Proposed Functionality
Functionality or True/False bit on custom field which allow them to show in device page section or hide from there. But Show all of them in inventory tab section.
I believe this way it can become more useful.

Use Case
Custom fields are great in netbox and can be used for many things. Also these can be increase signifcantly due to user wanted information in netbox which is even not advisable. However It would be great if there could have a Display flag on custom field so it show on /dcim/device/id device page if display flag is enabled but all of custom fields showed under inventory tab with custom field section below to Chassis section.
We are using custom field for various information not every information in custom field is needed when someone open a device page. But they are useful sometimes when someone needed detailed information about device.
Example -
I have these 5 custom fields -
these are needed some point but not regularly. we calucalte a depreciation on device based on these dates and update end of life status which is TRUE/FALSE
Device Manfacture Date
First Production Date
Last reprovision Date
End of Life Date
End of Life Status
So End of life status and end of life date can be showed in Device Page but all other custom field can be showed into inventory tab, down below chassis section. it makes device home page much clean and nicer while using custom fields too.

Database Changes
Not sure at about this, I believe a true/false flag needed so that templates render them based on it.
This would be requires to change html template.

External Dependencies
None

Something simple that might help in the mean time.
I've changed the 'custom_fields_panel.html' template to only display used custom fields when viewing the device. This means you can fill out separate fields for different types of devices and it will only display the relevant ones.
{% for field, value in custom_fields.items %} 	**{% if value is not None  %}**
                     {{ field }}	                                              {% if field.type == 300 and value == True %}                                                      {% elif field.type == 300 and value == False %}                                                      {% elif field.type == 500 and value %}                             {{ value|truncatechars:70 }}                         {% elif field.type == 200 or value %}                             {{ value }}                         {% elif field.required %}                             Not defined                         {% else %}                             N/A                         {% endif %}
 	**{% endif %}** {% endfor %}

Sounds like a duplicate of #2132


Add option to disable random MAC address in client mode

To allow for easier access via WIFI, the changing mac address of the goggle will result in different IP's every boot, thanks to the dhcp on the network not recognizing the device by it's MAC.
This PR introduces a (semi) permanent MAC that can be used as a fixed address, if so desired.
The first address of the device is generated randomly from system time and saved to the settings_ini.
Changing of the address is also supported by placing a file named macaddr.txt in the SD-card root.
Validation is in place, and only valid mac's will be accepted.
Please validate this a bit more cautiously, my C skills are rusty.

Nice job!  I would recommend not keeping both clientid and the option for random MAC address.  Remove the clientid setting attribute and associated references, use the persistent Mac attribute instead.  Simplify the code to always used the generate MAC address instead.  I don't see a benefit for having the user switch between random and static MAC address and having extra files on the sd card since if the card gets formatted this MAC address is lost.  Best to keep it all embedded within settings framework and the clientid becomes deprecated in favor for mac attribute.

Before removing features, I'd like to know nobody actually uses them.
Secondly, what does clientid actually do? I cannot find a manpage for udhcpc that has the x flag, no idea what it does.
Removing random MAC completely might be bad for privacy in open networks, thanks to fingerprinting. (We are talking about a video goggle though.)
I see the point of not needing the MAC to be changed via SD card. Mostly just me wanting to set the default to what it used to be on my first try. Maybe in case of a settings file update?
I foresee no real changes to the way MAC addresses work in the wild, so the code would essentially remain untouched for a long time, so why not have it? How it works is actually described in the note at the bottom of the settings page.

Keeping the MAC static seems sane for me, especially with our usecase. The clientid can be the static mac address, just as a fallback in case of weird behavioured dhcp's. I'll drop the menu entry for changing it, that will already simplify a lot. I'd like to keep the mac changing by file, since we do not adhere to any reasonable standard for it's assignment and duplicates are unlikely, but not impossible. Sound good?

Should be alright now.

April 26 comment make 100% sense to me as someone in the IT industry. Maybe rebase on main and mark ready for review.

It would make sense, if the used wifi chipset actually supported it properly. The current driver seems to offer better performance, but lacks any means of changing the mac address, if I remember correctly. Feel free to pull and build this, but it will not work.

I would close this PR if a new WiFi driver is not included since there is a driver limitation that prevents this PR from being successfully integrated.


node:moved triggered twice between the selected node and the unselected node

there are two nodes one is selected，another is normal
when I move the normal one,the event "node:moved" has triggered twice
in my mind,it should be triggered just once,in the situation.

/cib


New Problem

Hi, i have tried your emulator (yupi), i saw a huge problem, i cant login after i have created a room, I cant load the room in the navigator and go to a room the screen is just black and i get massive errors, Here u got the error log hope u can fix it thanks: http://pastebin.com/HsRNWM0y

i dont know if this is a working or a just beta, but i didnt get up the items in the catalog pages when click it thanks for this

Remembering. This is a Pre-Release. The emulator isn't finished for production usages.
Soo these bugs of casting are totally normal. When the 1.0 release (beta) be released. Will be able to production usages.
The actually builds are pre-beta, and pre-alpha.
Cheeers,


--growl not notifying

Hi,
Im very new to node and linux in general but cant for the life of me get --growl to show notifications when my test suite is running.
Here is the command line im using to run the suite.
mocha -r should -G -w
And the suite runs fine with changes, but no growl notifications.
I can confirm the following...

Notify-send is working on my system.
I can require growl in a node session if I specify the full path to the growl package that is sitting in mocha.
Mocha is installed globally.

Have I missed something or is there a bug here that Im not aware of?
Thanks for the help.

So I found what was causing this issue. It looks like a small issue in the node-growl package.
Ive raised it over there..
https://github.com/visionmedia/node-growl/issues/15


[Wallet] Fix hanging requests with WalletConnect

Description
During the all hands demo yesterday I found a bug where the WC client is never re-initialised. This can lead to hanging requests.
Other changes
When doing any WC action, we should check if there are any pending actions afterwards.
Tested
A bunch of testing with multiple browser windows, etc.
How others should test
Go to https://use-contractkit.vercel.app/, select Alfajores. Now run Valora on your phone or via the emulator.

Hi @aleksey-nov  I have verified this issue using latest Alfajores build V1.14.0(58) & observed following:
Observations:

[x] User get "Open this page in Alfajores" popup with "Cancel" & "Open" buttons when user browse URL in browser's like Safari, Chrome
[x] Also it is observed that, user redirect to "use-contractkit demo would like to connect Valora" page with Allow button.
[ ] Also it is observed that, nothing happens when user taps on "Allow" button.
[ ] Also we have observe same issue of "Allow" button for Mainnet version for Android internal build V1.14.0<PHONE_NUMBER>) & Test Flight build V1.14.0(58)
Can you please let us know is it expected or we can raise a ticket for same ?

Attachment: ContractKitDeplinkIsue.mp4
Verified On Devices: iPhone SE (14.2), Redmi Note 8 (9.0)
Thanks..!!

signPersonalMessage and signTypedData are not supported in Valora just yet
Execution reverted: Transfer value exceeded balance of sender  you need to have a CELO balance

Hey @AlexBHarley Thanks for more information.

Now we have tried this scenario while user has CELO amount in account & observed that user is able to see "Send Transaction Succeed" message displayed when user taps on  "Test send Transaction" button on  https://use-contractkit.vercel.app/ website using Alfajores build V1.14.1(59)

Verified on Devices: iPhone 6+ (12.4.5)
Attachment: Send Transaction Succeed


How can I get in contact with you?

Hello, I was very interested by your article: https://je-suis-tm.github.io/graph-theory/portfolio-optimization/
And I wanted to ask you some questions about getting into quant development and the possibility of being a research assistant for you because I'm very impressed by all the work you do. Can we message one another somehow? My email to the address on your site failed.
My twitter is: https://twitter.com/unhingexd
I understand you're probably very busy, but if you could take the time to speak with me I'm sure I can do some very helpful work for you! Thanks a lot, also have you ever been published? I haven't seen some of your ideas anywhere else.
Thanks,
https://www.saileshp.com/
https://www.linkedin.com/in/saileshpola/

Thanks and apologies for the delayed reply @saileshp56 Unfortunately I am currently busy with other things and do not have the time to maintain this GitHub or any other stuff. If you really wanna learn more, my advice to you is simple, get a job in the industry. Whatever you can see in GitHub is only the tip of an iceberg. You only learn and grow in the real playground.


finetune scripts

Thank you for your outstanding work. I need to evaluate my base model after fine-tuning it, but it seems that our fine-tuning is different, leading to mistakes in the evaluation process. Could you please provide me with your fine-tuning code？

Thank you for your kind words and interest in our work. We used a modified version of the old fastchat code for the fine-tuning process. We have already uploaded this code for your convenience. You can find it at train.py.

Thank you very much for your reply. I have progressed to the final evaluation, but in order to reproduce the results of your paper, I would like to know how you calculated Metrics and acceptance rate, which I understand to be proportion of final_response_correctness, and Metrics? Is there a specific code? Thank you very much

After running evaluation.py, all the final results are stored in the statistics part in the args.output_path file. From this, you can obtain the final procedure/response/overall score.
Please note that because we used GPT-4 during the evaluation stage, the specific values you reproduce might have some deviation.

I am very sorry that I did not finish all the test sets before starting the evaluation, so I did not see the final statistical results. This is really a great project, but it may not run smoothly due to some version updates (especially langchain) or small bugs in the processing flow, can I propose a pr to fix these problems later? Thanks again for your reply

Thank you for your feedback and apologies for the inconvenience you've experienced. I would suggest trying out the same version of langchain that I am using, which is 0.0.147, and retry the process. If you still encounter issues, we would greatly appreciate your contribution through a pr.

当我在推理的时候我发现有的数据在经过API反馈后，给模型的输入会超出llama_alpaca_7b的最大长度2048，如下所示，这样会导致模型反馈的输出不可解析，我想请教一下您是否有什么好的方法去解决这样的问题？
Token indices sequence length is longer than the specified maximum sequence length for this model (2103 > 2048). Running this sequence through the model will result in indexing error
llmchain prep prompts: [StringPromptValue(text='Answer the following questions as best you can. You have access to the following tools:\n\ngetHolidaysByCountry: Retrieve a list of holidays for a specific country with dates, descriptions, and types.\nParameters: {"country": "Required. string. The country for which holidays are to be retrieved.", "year": "integer. The year for which holidays are to be retrieved.", "month": "integer. The month for which holidays are to be retrieved.", "day": "integer. The day for which holidays are to be retrieved.", "language": "string. The language in which holiday descriptions should be returned."}\nOutput: A list of holidays with their dates, descriptions, and types for the specified country, year, month, and day.\n - Format: application/json\n - Structure: Array[Object{name, date, type, description}]\ngetHolidayDetails: Retrieve detailed information on a specific holiday, including its history, purpose, and traditions.\nParameters: {"holidayId": "Required. string. The unique identifier of the holiday for which detailed information is to be retrieved.", "language": "string. The language in which holiday descriptions should be returned."}\nOutput: Detailed information on the specified holiday, including its history, purpose, traditions, and any additional information available.\n - Format: application/json\n - Structure: Object{name, date, type, description, history, purpose, traditions, additionalInfo}\nsearchHolidays: Search for holidays based on keywords, country, and date range.\nParameters: {"keywords": "string. Keywords to search for in holiday names and descriptions.", "country": "string. The country for which holidays are to be searched.", "startDate": "string. The start date of the date range for which holidays are to be searched (format: YYYY-MM-DD).", "endDate": "string. The end date of the date range for which holidays are to be searched (format: YYYY-MM-DD).", "language": "string. The language in which holiday descriptions should be returned."}\nOutput: A list of holidays matching the search criteria, with their dates, descriptions, and types.\n - Format: application/json\n - Structure: Array[Object{name, holidayId, date, type, description}]\nlistCountries: Retrieve a list of countries supported by the API.\nParameters: {}\nOutput: A list of countries supported by the API, with their country codes and names.\n - Format: application/json\n - Structure: Array[Object{code, name}]\nlistLanguages: Retrieve a list of languages supported by the API for holiday descriptions.\nParameters: {}\nOutput: A list of languages supported by the API, with their language codes and names.\n - Format: application/json\n - Structure: Array[Object{code, name}]\n\nUse the following format:\n\nQuestion: the input question you must answer\nThought: you should always think about what to do\nAction: the action to take, should be one of [getHolidaysByCountry, getHolidayDetails, searchHolidays, listCountries, listLanguages]\nAction Input: the input to the action, in JSON format.\nObservation: the result of the action\n... (this Thought/Action/Action Input/Observation can repeat N times)\nThought: I now know the final answer\nFinal Answer: the final answer to the original input question\n\nBegin!\n\nQuestion: I heard about a holiday called Diwali, but I don't remember which country it belongs to. Can you search for holidays with the keyword "Diwali" and tell me about its date, country, and a brief description?\nThought: I need to search for holidays with the keyword "Diwali" and then get the details of the holiday.\nAction: searchHolidays\nAction Input: {"keywords": "Diwali"}\nObservation: Status Code: 200. Response: {"holidays":[{"name":"Diwali","holidayId":"diwali","date":"2022-11-01","type":"Religious","description":"Diwali, also known as Deepavali, is a Hindu festival celebrated every year in autumn. It signifies the victory of light over darkness and good over evil. The festival involves lighting oil lamps, bursting fireworks, sharing sweets, and exchanging gifts."},{"name":"Diwali","holidayId":"diwali","date":"2023-10-21","type":"Religious","description":"Diwali, also known as Deepavali, is a Hindu festival celebrated every year in autumn. It signifies the victory of light over darkness and good over evil. The festival involves lighting oil lamps, bursting fireworks, sharing sweets, and exchanging gifts."},{"name":"Diwali","holidayId":"diwali","date":"2024-11-09","type":"Religious","description":"Diwali, also known as Deepavali, is a Hindu festival celebrated every year in autumn. It signifies the victory of light over darkness and good over evil. The festival involves lighting oil lamps, bursting fireworks, sharing sweets, and exchanging gifts."}]}\nThought: The searchHolidays tool returned three holidays with the keyword "Diwali". The first holiday is the most relevant, as it has the same date and type as the original query.\nAction: getHolidayDetails\nAction Input: {"holidayId": "diwali"}\nObservation: Status Code: 200. Response: {"name":"Diwali","date":"2022-11-01","type":"Religious","description":"Diwali, also known as Deepavali, is a Hindu festival celebrated every year in autumn. It signifies the victory of light over darkness and good over evil. The festival involves lighting oil lamps, bursting fireworks, sharing sweets, and exchanging gifts.","history":"Diwali has its roots in ancient Hindu mythology. It commemorates the return of Lord Rama, along with his wife Sita and brother Lakshmana, from their 14-year exile and the defeat of the demon king Ravana. The festival symbolizes the triumph of good over evil and the restoration of righteousness.","purpose":"Diwali is a time for people to come together, celebrate, and express gratitude. It is a time to seek blessings from deities, perform religious rituals, and offer prayers for prosperity and well-being. The festival also promotes unity, harmony, and the spirit of sharing and caring.","traditions":"During Diwali, people decorate their homes with colorful rangoli designs, light oil lamps (diyas), and place candles around their houses. Fireworks are burst to ward off evil spirits and celebrate the victory of light. Families gather for feasts, exchange gifts, and share sweets. It is also common to visit temples, seek blessings from elders, and donate to the less fortunate.","additionalInfo":"Diwali is one of the most significant festivals in Hinduism and is celebrated not only in India but also by Hindu communities around the world. The festival typically lasts for five days, with each day having its own set of rituals and traditions. Diwali is a time for joy, renewal, and strengthening of relationships."}\nThought: The getHolidayDetails tool returned detailed information on the holiday, including its history, purpose, traditions, and any additional information available.\nAction: searchHolidays\nAction Input: {"keywords": "Diwali"}\nObservation: Status Code: 200. Response: {"holidays":[{"name":"Diwali","holidayId":"diwali","date":"2022-11-01","type":"Religious","description":"Diwali, also known as Deepavali, is a Hindu festival celebrated every year in autumn. It signifies the victory of light over darkness and good over evil. The festival involves lighting oil lamps, bursting fireworks, sharing sweets, and exchanging gifts."},{"name":"Diwali","holidayId":"diwali","date":"2023-10-21","type":"Religious","description":"Diwali, also known as Deepavali, is a Hindu festival celebrated every year in autumn. It signifies the victory of light over darkness and good over evil. The festival involves lighting oil lamps, bursting fireworks, sharing sweets, and exchanging gifts."},{"name":"Diwali","holidayId":"diwali","date":"2024-11-09","type":"Religious","description":"Diwali, also known as Deepavali, is a Hindu festival celebrated every year in autumn. It signifies the victory of light over darkness and good over evil. The festival involves lighting oil lamps, bursting fireworks, sharing sweets, and exchanging gifts."}]}\nThought:')]

This is a common occurrence when using tools, especially in real-world scenarios. During our testing with eval_real.json test set, we adopt a tricky method to add a retrieval tool. This tool takes advantage of models with a longer context length, such as gpt-3.5-turbo-16k-0613, to retrieve information from the files.

I'm sorry to bother you again, but could you share the script of your fine-tuning When I used vicuna-v1.5's fine-tuned model to reason, I found that intermediate_steps returned all blank, The call to the task chain should be documented in intermediate_steps(agent action), but the model answered the question correctly, as shown below:

Entering new CustomAgentExecutor chain...
intermediate_steps []
I should use the searchAxolotlImages tool to find pictures of both genders.
Action: searchAxolotlImages
Action Input: {"color": "wild", "gender": "male", "size": "small"}
Obation: I should use the same parameters for the female gender.
... (this Action/Action Input/Obation can repeat N times)
Thought: I should compare the pictures to see the differences between the genders.
Final Answer: Male and female axolotls differ in appearance, with the male having a more pronounced dorsal fin and a longer tail. Here is a comparison picture of a male and female wild-colored axolotl: [image of male and female axolotl]

Finished chain.
{"message":"clear Axolotl cache"}

This can lead to a failure to calculate the results during the evaluation, but I did not have this problem with direct inference in the original model vicuna-v1.5.I think there were some errors in the fine tuning. My script is as follows (2xA100) :
deepspeed --num_gpus 2
-- train.py
--model_name_or_path vicuna-7b-v1.5
--data_path train.json
--output_dir vicuna-7b-v1.5-toolalpaca
--bf16 True
--num_train_epochs 3
--per_device_train_batch_size 2
--gradient_accumulation_steps 16
--learning_rate 2e-5
--weight_decay 0.
--warmup_ratio 0.03
--lr_scheduler_type "cosine"
--logging_steps 1
--tf32 True
--model_max_length 4096
--gradient_checkpointing True
--lazy_preprocess True
--deepspeed stage3.json
The script parameter Settings refer to your paper and fastchat
Some information during the fine-tuning process may be worth noting:
Token indices sequence length is longer than the specified maximum sequence length for this model (2259 > 2048). Running this sequence through the model will result in indexing errors
Thank you very much

I'm sorry to bother you again, but could you share the script of your fine-tuning When I used vicuna-v1.5's fine-tuned model to reason, I found that intermediate_steps returned all blank, The call to the task chain should be documented in intermediate_steps(agent action), but the model answered the question correctly, as shown below:

Entering new CustomAgentExecutor chain...
intermediate_steps []
I should use the searchAxolotlImages tool to find pictures of both genders.
Action: searchAxolotlImages
Action Input: {"color": "wild", "gender": "male", "size": "small"}
Obation: I should use the same parameters for the female gender.
... (this Action/Action Input/Obation can repeat N times)
Thought: I should compare the pictures to see the differences between the genders.
Final Answer: Male and female axolotls differ in appearance, with the male having a more pronounced dorsal fin and a longer tail. Here is a comparison picture of a male and female wild-colored axolotl: [image of male and female axolotl]

Finished chain.
{"message":"clear Axolotl cache"}

This can lead to a failure to calculate the results during the evaluation, but I did not have this problem with direct inference in the original model vicuna-v1.5.I think there were some errors in the fine tuning. My script is as follows (2xA100) : deepspeed --num_gpus 2 -- train.py --model_name_or_path vicuna-7b-v1.5 --data_path train.json --output_dir vicuna-7b-v1.5-toolalpaca --bf16 True --num_train_epochs 3 --per_device_train_batch_size 2 --gradient_accumulation_steps 16 --learning_rate 2e-5 --weight_decay 0. --warmup_ratio 0.03 --lr_scheduler_type "cosine" --logging_steps 1 --tf32 True --model_max_length 4096 --gradient_checkpointing True --lazy_preprocess True --deepspeed stage3.json
The script parameter Settings refer to your paper and fastchat
Some information during the fine-tuning process may be worth noting: Token indices sequence length is longer than the specified maximum sequence length for this model (2259 > 2048). Running this sequence through the model will result in indexing errors
Thank you very much

This problem should be due to the excellent capability of vicuna-v1.5 itself, which needs to be further adapted to the langchain code to solve
I recently evaluated it on different models, and the results are roughly as follows, which I won't expand here due to various problems with real API access, just listing simulated API results

vicuna-v1.5 in the return thought of 99 is directly return the agent-finish state, no agent-action, I wonder if I can directly put the agent-finish in the "intermediate_steps" in the plan module of langchain. steps" in langchain plan module?

Are you referring to vicuna-v1.5 before or after fine-tuning? I believe it's unlikely for this situation to occur after fine-tuning.

Are you referring to vicuna-v1.5 before or after fine-tuning? I believe it's unlikely for this situation to occur after fine-tuning.

In fact, it is a fine-tuned model of vicuna-v1.5

Thank you for your clarification. I will fine-tune the vicuna-v1.5 model in my spare time and investigate the reason why it's not working. I will get back to you once I have more information.

Thank you very much🙏

I'm sorry to bother you again, but could you share the script of your fine-tuning When I used vicuna-v1.5's fine-tuned model to reason, I found that intermediate_steps returned all blank, The call to the task chain should be documented in intermediate_steps(agent action), but the model answered the question correctly, as shown below:

Entering new CustomAgentExecutor chain...
intermediate_steps []
I should use the searchAxolotlImages tool to find pictures of both genders.
Action: searchAxolotlImages
Action Input: {"color": "wild", "gender": "male", "size": "small"}
Obation: I should use the same parameters for the female gender.
... (this Action/Action Input/Obation can repeat N times)
Thought: I should compare the pictures to see the differences between the genders.
Final Answer: Male and female axolotls differ in appearance, with the male having a more pronounced dorsal fin and a longer tail. Here is a comparison picture of a male and female wild-colored axolotl: [image of male and female axolotl]

Finished chain.
{"message":"clear Axolotl cache"}

This can lead to a failure to calculate the results during the evaluation, but I did not have this problem with direct inference in the original model vicuna-v1.5.I think there were some errors in the fine tuning. My script is as follows (2xA100) : deepspeed --num_gpus 2 -- train.py --model_name_or_path vicuna-7b-v1.5 --data_path train.json --output_dir vicuna-7b-v1.5-toolalpaca --bf16 True --num_train_epochs 3 --per_device_train_batch_size 2 --gradient_accumulation_steps 16 --learning_rate 2e-5 --weight_decay 0. --warmup_ratio 0.03 --lr_scheduler_type "cosine" --logging_steps 1 --tf32 True --model_max_length 4096 --gradient_checkpointing True --lazy_preprocess True --deepspeed stage3.json
The script parameter Settings refer to your paper and fastchat
Some information during the fine-tuning process may be worth noting: Token indices sequence length is longer than the specified maximum sequence length for this model (2259 > 2048). Running this sequence through the model will result in indexing errors
Thank you very much

This problem should be due to the excellent capability of vicuna-v1.5 itself, which needs to be further adapted to the langchain code to solve
I recently evaluated it on different models, and the results are roughly as follows, which I won't expand here due to various problems with real API access, just listing simulated API results
Note that I used gpt-35-turbo-0301, the GPT4 used in the paper, in the model evaluation process, and the evaluation index would rise or fall by 2% due to randomness.

Hi @zhanghy-sketchzh , based on the results you shared, looks like your fine-tuned codellama-instruct had super high performance. Do you have more information about that? Is it fine-tuned with data/train_data.json in this repo? btw, if you want to discuss more on this, we can connect via<EMAIL_ADDRESS>

I'm sorry to bother you again, but could you share the script of your fine-tuning When I used vicuna-v1.5's fine-tuned model to reason, I found that intermediate_steps returned all blank, The call to the task chain should be documented in intermediate_steps(agent action), but the model answered the question correctly, as shown below:

Entering new CustomAgentExecutor chain...
intermediate_steps []
I should use the searchAxolotlImages tool to find pictures of both genders.
Action: searchAxolotlImages
Action Input: {"color": "wild", "gender": "male", "size": "small"}
Obation: I should use the same parameters for the female gender.
... (this Action/Action Input/Obation can repeat N times)
Thought: I should compare the pictures to see the differences between the genders.
Final Answer: Male and female axolotls differ in appearance, with the male having a more pronounced dorsal fin and a longer tail. Here is a comparison picture of a male and female wild-colored axolotl: [image of male and female axolotl]

Finished chain.
{"message":"clear Axolotl cache"}

This can lead to a failure to calculate the results during the evaluation, but I did not have this problem with direct inference in the original model vicuna-v1.5.I think there were some errors in the fine tuning. My script is as follows (2xA100) : deepspeed --num_gpus 2 -- train.py --model_name_or_path vicuna-7b-v1.5 --data_path train.json --output_dir vicuna-7b-v1.5-toolalpaca --bf16 True --num_train_epochs 3 --per_device_train_batch_size 2 --gradient_accumulation_steps 16 --learning_rate 2e-5 --weight_decay 0. --warmup_ratio 0.03 --lr_scheduler_type "cosine" --logging_steps 1 --tf32 True --model_max_length 4096 --gradient_checkpointing True --lazy_preprocess True --deepspeed stage3.json
The script parameter Settings refer to your paper and fastchat
Some information during the fine-tuning process may be worth noting: Token indices sequence length is longer than the specified maximum sequence length for this model (2259 > 2048). Running this sequence through the model will result in indexing errors
Thank you very much

This problem should be due to the excellent capability of vicuna-v1.5 itself, which needs to be further adapted to the langchain code to solve
I recently evaluated it on different models, and the results are roughly as follows, which I won't expand here due to various problems with real API access, just listing simulated API results
Note that I used gpt-35-turbo-0301, the GPT4 used in the paper, in the model evaluation process, and the evaluation index would rise or fall by 2% due to randomness.

Hi @zhanghy-sketchzh , based on the results you shared, looks like your fine-tuned codellama-instruct had super high performance. Do you have more information about that? Is it fine-tuned with data/train_data.json in this repo? btw, if you want to discuss more on this, we can connect via<EMAIL_ADDRESS>
I did the experiment exactly according to the author's fine-tuning method, Train_data. Json also need to pass [build_dataset py] (https://github.com/tangqiaoyu/ToolAlpaca/blob/main/build_dataset.py)


Implementing dropwizard emitter for druid (https://github.com/druid-io/druid/issues/3927)

Corresponding issues are
https://github.com/druid-io/druid/issues/3927
https://github.com/druid-io/druid/issues/1996

@b-slim @himanshug
Requesting you to review this pull request.
The code structure is based on the graphite-emitter contributed by @b-slim

Any update on this?

Hi. Any update? Any schedule to review it?

Hi. Any update? Any schedule to review it?

Hi. Any update? Any schedule to review it?

Sorry about the delayed review. @rohitkochar would you please update this PR by merging master? You also need to update the package name and the license of all new files to org.apache.druid and the Apache license, respectively.

This would be great if it would allow emitting metrics in the various dropwizard supported formats.  We're specifically looking for prometheus exporting, which can be hooked up through the jmx exporter with https://github.com/prometheus/jmx_exporter

@rohitkochar Thanks for the PR. We are also looking for enabling exposing druid metrics via JMX.
@rohitkochar, are you still planning to work on this PR ?

FYI, I am working on refactoring this patch for latest druid. Will start by cherry-picking @rohitkochar commit so that he gets credit for the work done.

Closing in favor of https://github.com/apache/incubator-druid/pull/7363


Adding dotcom components to index and reordered filters

This commit

Adds "IBM.com" to list of maintainers
Adds all of the components listed in production at https://www.ibm.com/standards/web/ibm-dotcom-library/ to the community index (NB: Currently using only default thumbnail - they will need imagery)
Reorders the community index filter so that "Maintainer" is the first filter choice

_Note: ComponentIndexPage/index.js fails linting, though not for any of the lines of code I edited, so I commited with --no-very.
Will close #1642

@jeanservaas @wonilsuhibm We need to get the thumbnails sorted at one point. I think we can publish as is and follow up with those images later. What do you both think?

@shinytoyrobots The Dotcom components do not show up when checking the box.
Also the AI Applications site we aim to from resource card is this link: https://pages.github.ibm.com/ai-applications/design/ which is different then the site link from the index which is this https://pages.github.ibm.com/Watson-IoT/IoT-Design-Site/
I think the new AI Apps site is meant to replace the Watson IoT site but not sure what is going on with the two sites?

@andreancardona - Can you check with Craig Moser on the correct "AI Applications" site, looks like they didn't only change their name but also changed their primary url?


an error in operation with the same priority

int i = 2;
return  i + ++i * i++;

this code return different value with different compiler:
clang : 11 = 2 + 3 * 3
gcc : 16 = 4 + 4 * 3
chibicc : 12 = 4 + 4 * 2
caused by here:
at line 1096 :
  gen_expr(node->rhs);
  push();
  gen_expr(node->lhs);
  pop("%rdi");

It will first calculate the rhs then the lhs.
maybe should be this:
  gen_expr(node->lhs);
  push();
  gen_expr(node->rhs);
  push();
  pop("%rdi");
  pop("%rax");

In C, the evaluation order for such expression is not defined, so you shouldn't write code that assumes some specific evaluation order.


starknet: read block id from storage if only block number specified

If the user specified an empty hash, the node would look for that as the
starting block.

Current dependencies on/for this PR:

main

PR #125   👈

This comment was auto-generated by Graphite.


OS X Works

Thanks for your easy to use VPN server. I just want to confirm that it works well with Viscosity on Mac. I did have to import, then export then re-import again to get it to work due to dh.key missing, but it could easily be a bug with the client.

This is definitely helpful, Thank you.

Thanks for reporting this; I added this info to the README.