Connection problems (maybe) due to neo4j-driver==1.1.0

Hi,
I have found an error when trying to connect to neo4j, I don't know exactly why it happens because I haven't had any time to debug it, but my guess is it could be related either to the sockets library or to the neo4j driver. The error is:
   db.set_connection(neo4j_uri)   File "/home/devel/anaconda3/lib/python3.6/site-packages/neomodel/util.py", line 63, in set_connection     self.refresh_connection()   File "/home/devel/anaconda3/lib/python3.6/site-packages/neomodel/util.py", line 28, in wrapper     return func(self, *args, **kwargs)   File "/home/devel/anaconda3/lib/python3.6/site-packages/neomodel/util.py", line 70, in refresh_connection     self._session = self.driver.session()   File "/home/devel/anaconda3/lib/python3.6/site-packages/neo4j/v1/bolt.py", line 51, in session     return BoltSession(self.pool.acquire(self.address))   File "/home/devel/anaconda3/lib/python3.6/site-packages/neo4j/bolt/connection.py", line 459, in acquire     connection = self.connector(address)   File "/home/devel/anaconda3/lib/python3.6/site-packages/neo4j/v1/bolt.py", line 46, in <lambda>     pool = ConnectionPool(lambda a: connect(a, security_plan.ssl_context, **config))   File "/home/devel/anaconda3/lib/python3.6/site-packages/neo4j/bolt/connection.py", line 615, in connect     return Connection(s, der_encoded_server_certificate=der_encoded_server_certificate, **config)   File "/home/devel/anaconda3/lib/python3.6/site-packages/neo4j/bolt/connection.py", line 256, in __init__     self.buffering_socket = BufferingSocket(self)   File "/home/devel/anaconda3/lib/python3.6/site-packages/neo4j/bolt/connection.py", line 99, in __init__     self.address = Address(*self.socket.getpeername()) TypeError: __new__() takes 3 positional arguments but 5 were given
A fast solution I have found is to force neomodel to use neo4j-driver==1.2.0.
I have posted this issue so that you could be aware of this kind of problem, but I haven't checked if you already were. Feel free to delete this if this is redundant/inappropiate information.
Best regards!

Super thank you i will update neomodel

Interesting have you tried running tests against 1.2? A lot of them broke for me. I will update neomodel but need to fix the code first.

Hi Robin, I'm sorry it took me so long to answer this. Unfortunately I updated the driver on a rush (I had to solve an issue really quickly and was lacking ideas) and didn't even have the time to run any test. I guess my system is working correctly because I am not using advanced features, but if I did they would break.
If I find time I will run the tests and try to help neomodel to be upgraded.
Regards!

I'm having problems with the locked requirements for neo4j-driver==1.1.0 as well..
Getting same error as @croccam when running latest version on neomodel with 1.1.x version of neo4j-driver.
Would be really awesome to be able to upgrade soon =)
Thanks for a great library, btw!

Hello,
I have fixed this locally unfortunately it will be a couple of weeks before
i push as I am on vacation.
On 23 May 2017 11:52, "Rolf Håvard Blindheim"<EMAIL_ADDRESS>wrote:

I'm having problems with the locked requirements for neo4j-driver==1.1.0
as well..
Getting same error as @croccam https://github.com/croccam when running
latest version on neomodel with 1.1.x version of neo4j-driver.
Would be really awesome to be able to upgrade soon =)
Thanks for a great library, btw!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/robinedwards/neomodel/issues/251#issuecomment-303362491,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJ0YcnxD52h6hdN2t5sEW_dZA0qaYWUks5r8rpbgaJpZM4NKBV1
.

Great, thanks!
Have a nice vacation!

Fixed


Rebuild with ace 8.0.1 and stop using CDTs for OpenGL

Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #50.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.

[x] Bump the build number if needed

Fixes #50

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

No valid build backend found for Python recipe for package yarp-python using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge-webservices/actions/runs/11144938799.

@conda-forge-admin please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge-webservices/actions/runs/11145017557.

Not sure why it started now, but python 3.12 builds are failing with:
CMake Error at python/CMakeLists.txt:74 (install):
  install FILES given no DESTINATION!

CMake Error at python/CMakeLists.txt:90 (install):
  install TARGETS given no LIBRARY DESTINATION for module target
  "_yarp_python".

-- Configuring incomplete, errors occurred!


Release the code

[ ] Make sure that the license is applied correctly.
[ ] Make sure that the code works.
[ ] Make sure copyright is completed correctly.

Duplicate of #2


Member detail page should include link to chapter

Summary of the Bug
If a member is part of a chapter, their detail page does not include this information.
Steps to Reproduce the Behaviour
Visit the member page of a member who is part of a chapter. Random example: https://agagd.usgo.org/player/11121/
The Expected Behaviour
It would be natural to see the name of, and a link to, the user's affiliated chapter.

Oops this should have been a feature request.


Error obtaining file URL

An error occurred while obtaining the file upload URL
Description
I have tried deploying to the Huawei app gallery but I am always faced with the same issue.
{"ret":{"code":203489281,"msg":"[AppGalleryConnectPublishService]getUploadUrl.arg2: size must be between 1 and 6"}}
Steps to Reproduce (if applicable)

create Huawei app gallery account
create your app api key and set it to N/A as per documentation
Add your variables and keys to Bitrise
Run your build

Expected Behavior
The step should run successfully and deploy the .aab to Huawei app gallery
Actual Behavior
The step fails with error  {"ret":{"code":203489281,"msg":"[AppGalleryConnectPublishService]getUploadUrl.arg2: size must be between 1 and 6"}}
Screenshots or Additional Information (if applicable)

Environment
[Provide information about your environment:]

Bitrise machine: MacOS, M1 Medium
step version: 1.5.6

Hi, i am currently facing the same issue, have you found a solution for this issue?

not yet @AdricBM, still waiting for a response from the step creator

Hey thanks for following this up @AdricBM and @Monir-Shembesh. This is still under investigation.
Unfortunately I don't have an additional buffer to dedicate longer on this. Feel free to open an issue in AppGallery based on the results you recently got and let me know what they suggest to address this

Having a similar issue here :

Hi, i am currently facing the same issue, have you found a solution for this issue? Anyone found a solution ?

I will check with Huawei this week @dariusz-rosiek-branchspace. Since they added some disruptive changes in their public API this Bitrise Step has not been able to work, but hopefully I'll get some clarity and a potential fix soon.


Promote aggregated builds

Is your feature request related to a problem? Please describe.
We use aggregated builds in our pipeline since we build on several different machines. This works fine and the next step in the pipe can download all artifacts etc. But promotion doesn't seem to work. Promoting a aggregated build doesn't seem to do anything to copy/move the artifacts to a new repo. We can do it by listing all the builds included in a aggregated build and then promoting each of those - but that requires manual steps to query the API and script around it. It would be nice if the cli could do this instead.
Describe the solution you'd like to see
New flag to build-promote --include-aggregated or similar that could do the same operation on all sub-builds.
Describe alternatives you've considered
calling jfrog rt curl to query a buildinfo JSON and then scripting a loop over the sub-builds.

We have exactly the same problem. This behaviour currently makes aggregated builds more or less useless in practice, which is a shame.

Also have this issue with build promotion with aggregate builds, was there a fix for this??

Hi! We have been investigating the Artifactory build-info to see how we can benefit from it in our current CI flows (especially applied to Conan).
We have hit this issue as well, basically, the promotion using build info of aggregated build-infos is not working. Here is a brief test case:
jf rt upload "a*.zip" default-generic-local --build-name a --build-number 1
jf rt build-publish a 1
jf rt upload "b*.zip" default-generic-local --build-name b --build-number 1
jf rt build-publish b 1
jf rt build-append aggregating-build 10 a 1
jf rt build-append aggregating-build 10 b 1
jf rt build-publish aggregating-build 10
jf rt build-promote aggregating-build 10 test-generic-local  # Does not promote the artifacts of build infos a & b

The JFrog CLI reports that the promotion has gone fine but when I check the test-generic-local repository there are no artifacts there.
Not sure if this is a problem with Artifactory or CLI issue.
Tested with JFrog CLI 2.35.0 and Artifactory cloud 7.55.2

We ended up with scripts that extract the sub-builds from the top level build, and then run jf rt build-promote on each one of them. Super annoying. I'm still wondering what the intended purpose of aggregated build is.

We have this issue too. Currently trying to solve it by having a plugin that can handle promotion of aggregated builds


FR: unwrapped aliases

I would like a feature that unwraps yaml collections in frontmatter (per example 2.3 here). This was an option on an older obsidian linter.
Example:
---
tags: red, yellow, green
aliases: Note, 'Note , Comma', BigNote
===

would convert to:
---
tags:
  - red
  - yellow
  - green
aliases:
 - Note
 - Note , Comma
 - BigNote
---

The dataview plugin allows arbitrary fields in frontmatter, so this functionality would not be limited to fields recognized by Obsidian. (Perhaps there would be an option to list the fields that should be unwrapped)
Describe Alternatives You've Considered
I have not been able to think of any alternatives other than manually doing this.

Thanks for this feature request @ScottKillen . This is something I have considered working on in the past. I think this should be made more generic and allow for yaml attributes that are lists to be setup to convert values to one of 3 types:

Single line array (i.e. key: [...])
Multiline array (i.e. key:\n  - ...)
Single line value (i.e. key: ...). The latter would only be possible for tags and aliases as they are special.

I am not sure that that this has ever been a feature of Obsidian Linter, but it would be a welcome addition that I can see being useful for may users including myself.

I know it was never a feature of this project...but somewhere in my distant memory, I seem to remember some other plugin with this feature.
It could be that I ran a tool outside of Obsidian to do this, but I have some ancient notes that bear the results of whatever I did. 😉

Gotcha. I thought you were saying Obsidian Lint did makw these kinds of changes prior. I will see what can be done around this.

Note: this is a partial duplicate of #182 .

@ScottKillen , are those formats you posted valid for Obsidian? I am asking since it looks as though they are not following a valid YAML format for an array.

It looks like I will need to hold off on this in favor of a refactor that is being worked on to allow it to go through prior to this. However this will give time to think about how to best handle the code and not create a rushed solution in a matter of hours. I hope to be able to include this in the next release after the one today which will likely be two weeks from now.

Seems to also take care of https://github.com/platers/obsidian-linter/issues/172 as well.

Better to take the time to do it right!
I corrected my examples because you are right—they were not in proper format—though it looks like #172 wants linter to correct issues like this.

I believe this should now be possible on master. I plan to release it later today. I believe I have worked out several of the blatant issues with it when inspecting how it affected my local notes. Please let us know if master or the next release does not allow for the desired formatting.
@ScottKillen , this took a bit longer than expected, but hopefully most of the bugs are ironed out now.

@pjkaufman  Thanks for the effort!

No problem.


Relax patch level pronto restriction

There isn't really a need to lock to a minor pronto version, and when using many pronto support gems, the chances of updating when one moves to a new minor version of pronto become very small.

Ah, I've just seen there may be a breaking change for this in pronto.
I'll close this PR, but look forward to a new version of pronto-eslint.


Lutron Button 7 LED Device and Indigo Trigger

Creating an LED device (87) causes it to appear along with the device (7) in the list of possible triggers (when creating a trigger).

This is a bug in the manual device creation definition.

Fixed in 2022.1.1


pytest output on travis is too verbose

I have to scroll over an immense amount of passing tests on travis before I can get to the failures. (example) This is pretty annoying.
The amount of tests in xarray has exploded recently. This is good! But maybe we should turn off --verbose in travis.
What does @pydata/xarray think?

Agreed. 9000 lines of output is too much!
I think I originally turned this on to make it more obvious what the culprit is if/when tests stall, but that doesn't happen very often.


Prevent OOM on array size over VM limit

414

 Quality gate: Passed
 Everything looks good
Details

 Quality gate: Passed
 Everything looks good
Details


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/342 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit 2c50b57:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/index.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/sql-database-engine.png
:white_check_mark:Succeeded

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Change istio-system deletion propagation

Description
Changes proposed in this pull request:

Use the same deletion propagation as the current reconciler implementation

Related issue(s)

/test pull-istio-lint


[Help request] SetStoreCategories call ignores ChildCategory

Hello, of course this is not a bug related with your package but I'd like to know if you may help me.
I can't upload a category tree to the ebay store with SetStoreCategories call since the ChildCategory is always ignored and only top level categories are added.
Is there any advice to handle this or am I forced to add categories one level at a time?

I'm not 100% sure but you may have to  upload one level at a time. Also in future please ask personal issues with the SDK via the forum.


[Validator] Add method to get Orion.Validator.RuleResult[] using validation service

Missing feature
According to the documentation of the Validator (see below), it is possible to get the RuleResult list of a validator with the validate method but it's not possible to do the same using the useValidation service.
https://github.com/orion-ui/orion-ui/blob/90b5246dd95af1c77ea85744504d4eed0d71b052/docs/tooling/validator.md?plain=1#L69-L104
Only a boolean result is returned from the validate function when we use it with the object
readonly testValidator = useValidation({ test: 'randomString' }, { test: new Validator([Validator.rules.hasMaxLength(2)]) });

giving that result

What is my use case ?
There are some instances where I need to be able to parse the warnings triggered by the validators and follow up with a specific action for the user.
Expectations
I think it would be great if you provide a way for us to use the "API" in a similar way as the Validator, or at least the ability to request the state of the validators using the service.
I also think to easily parse the rules, it would be nice to be able to "identify" a rule using a name or id because I can only target a specific rule using their message and it can literally be impossible if we parametrize the string (eg: { ..., message: `Date cannot be more recent than ${new Date()}` })
Optional
Valuable considering the use case cited above, it seems the "API" of the Validator returns all the rules and their states so a way to be able to filter them could be a nice feature to have. (filter by level and their result)
It prevents each user creating their own tooling to sort and filter the rules even though it's not difficult to do.

TODO : update documentation @jbmaisner

@Phaesyla can you please try if it fit your needs by installing feature version: @feature-validation
Example:
ruleA: (val) => ({
  result: (val?.length ?? 0) > 2,
  message: 'length supérieure à 2',
  level: 'error',
  uid: 'lengthSup2',
}),
ruleB: val => ({
  ...Validator.rules.required()(val),
  uid: 'idRuleB',
}),

I tested the new functionality and it seems perfect !
I am able to filter on the right rule triggered by the condition and I am able to pass metadata so I can easily identify which one to act on.
Well done 👍


Not working on chrome

Describe the bug

i create the by using standard template
then when i run it on browser
it render on browser but it doesnot any content

but i remove follwing the, but i render the chrome with content

Steps to reproduce
Hint: A simple way to reproduce is to clone and modify the https://github.com/fzyzcjy/flutter_rust_bridge/tree/master/frb_example/dart_minimal example package according to your needs.

...
...
...
s

Logs
d

Expected behavior
No response
Generated binding code
#[flutter_rust_bridge::frb(sync)] // Synchronous mode for simplicity of the demo
pub fn greet(name: String) -> String {
    format!("Hello, {name}!")
}

#[flutter_rust_bridge::frb(init)]
pub fn init_app() {
    // Default utilities - feel free to customize
    flutter_rust_bridge::setup_default_user_utils();
}

OS
window
Version of flutter_rust_bridge_codegen
flutter_rust_bridge_codegen 2.0.0-dev.28
Flutter info
Flutter 3.19.4 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 68bfaea224 (32 hours ago) • 2024-03-20 15:36:31 -0700
Engine • revision a5c24f538d
Tools • Dart 3.3.2 • DevTools 2.31.1

Version of clang++
clang version 17.0.1
Additional context
No response

Hi, could you please check/paste the browser's console output?

Close since inactivity, but feel free to reopen if still having any questions!


Update nix files

Update nix files to use specific erlang and elixir versions and install livebook on first shell automatically.

Going to check if it works on Mac/Windows

Hey @mvkvc can you help me understand the purpose of this PR?
I don't use nix personally. I accepted adding these files originally since it was requested by nix users.
Is using specific versions rather than generic versions an improvement? I'm concerned about adding overhead to managing these files. Does this solve some issues I'm not aware of?

Nix uses a rolling release so the current version of the elixir package is 1.13, and because livebook updates require using the latest version of elixir when installing, the old version of nix.flake does not work anymore. I tried it now and got the error ** (Mix) You're trying to run :livebook on Elixir v1.13.4 but it has declared in its mix.exs file it supports only Elixir ~> 1.14.2.
As long as livebook keeps requiring the latest elixir version and the version of livebook and elixir is not pinned in the course then it is necessary to occasionally bump the version number like similar tools such as asdf. I can maintain this for the forseeable future as I am using it for the course, and maybe also add a note in the file that this is a DIY method without support.

I'm wondering if we should remove nix from the project 🤔 It's easy for these kinds of configs to get out of date, and I only plan to monitor asdf for breaking changes.
Thoughts?

Makes sense if it's not something that you want to deal with. I'll close this PR and then keep the files in my fork.


Vault ssh private key

Chef vault ssh-private-key and related changes

depends on the PR#525, so please merge PR252 into master first

his pull request is covered by PR#260, so can be merged in PR#260.

Covered by PR#260


Dependency on acorn resolves to 1.0.1 which breaks the require to 'acorn/util/walk' in index.js

In version 1.0.1 of acorn there's no util folder.
The acorn dependency is resolved in a weird way, because ^0.11.0 shouldn't resolve to 1.0.1 am I right?
Might be an issue with acorn..?

This is because your npm is very out of date.  If you update to the latest version of npm and then re-install with it should be fixed.


"Ciulnița" is listed in the drop-down menu

Description:
"Ciulnița" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Ciulnița" in the search bar.

Expected results
The location is listed in the drop-down menu as "Ciulnița, Argeș (Leordeni)".


Create outputs for the new results of the variables

Add the following to outputs:

assets_decommission_simple_method
assets_decommission_compact_method
and decommission for flow, assets_investment_energy (waiting for #792 #806)

Blocked by #792 #806

This is more complex than expected, because assets_decommission_compact_method is a vector without information on the indices. It create trouble when we want to save solution to files.
Maybe it is better to do after the refactor.


What about playtests?

I see there is commented code about playtests.
https://github.com/Citrinate/FreePackages/blob/8f8f9144e324785fefe64c5314bc88684ce6c592/FreePackages/Handlers/PackageFilter.cs#L79-L88
With the current plugin, what happens to playtests? Are they ignored? Or do they get added to the account?
Is there a difference between playtests which can be instantly added by the user, and playtests which require the user to make a request and wait for a validation from the dev?
I don't see playtests in the category setting. Maybe it would make sense to have a configuration setting for them.

As of now, I don't see why the plugin couldn't join playtests.  However, playtests are activated differently from apps and subs.  The plugin can't currently do anything with them, and so they're just ignored.
There's an ethical question here, because some playtests have a limited number of slots.  It's unfair to the average Steam user and to developers if a playlist's queue is filled with people using this plugin who likely aren't going to participate in a playtest.
If this plugin ever does support playtests, they'll have their own filter settings and will be disabled by default.

Thank you for the detailed reply! I understand your stance regarding playtests.

There's an ethical question here, because some playtests have a limited number of slots. It's unfair to the average Steam user and to developers if a playlist's queue is filled with people using this plugin who likely aren't going to participate in a playtest.

For info, playtests are not limited by Valve according to:

this introduction to Barter: https://github.com/bartervg/barter.vg/wiki/Ultimate-Beginners-Guide#steam-playtest
the official documentation of playtests: https://partner.steamgames.com/doc/features/playtest

It's good to know that limited testers are selected randomly and not first-come-first-serve.
I am planning on adding this in V1.2.  Plans are still for it to be an opt-in feature, and also for only 1 account to be able to opt-in.


Containers not stretching to the full width of the tab

I am not sure if this is intentional or not but having the container indicator being just a dot makes it a little hard to see, is there a way to make it span the full tab?

Activate the key "userChrome.AdditionalContainerIndicator-Enabled" or/and you can install v1.5.107. It's pretty much done, just waiting for Firefox 107.0 to be released on the Beta update channel to check the style before the final release.


not works

do you know any solutions which creates without phone numbers?

@unix121 But you still need to confirm that you are a human in the next step.

The script can be easily modified to work with any other e-mail provider as well. My plan is (when I get the time) to make it work with disposal e-mails to generate multiple accounts at once.

I've decided to do my best to ressurect this project for fun as well as to test my rusty python memory.. havent coded in it since college... lol.. smh..
So far have gotten it to the point of working till Phone Verification. However, I am actually going to migrate back to RHEL 7.5 from this kali linux install.. :)


Implement new expressions from frontend in backend

Description
Frontend has implemented a set of new functions https://github.com/Altinn/app-frontend-react/issues/1176.
We need to implement the same functions in backend so evaluation of expressions still function the same frontend and backend for those functions that are regarded as common for both frontend and backend.
Additional Information
No response
Tasks

[ ] syncronize shared-tests folder
[ ] add new folders to test fictures
[ ] implement missing functions

Acceptance Criterias

[ ] all tests run green

Update documentation to reflect what's supported on the backend ref. https://docs.altinn.studio/app/development/logic/expressions/


Support to control volume of player android

Issue

This PR is related to https://github.com/hayanmind/mimiking-rn/issues/1285

Changes

Add setStreamType() functionality for Android

Logic

setStreamType() resets mediaPlayer, changes its streamType, and then reprepares.
prepare() no longer makes new mediaPlayer everytime it is called.

Refactoring

This PR has been refactored by @ghsdh3409 with #34 .

@ohtangza @ghsdh3409 This needs review!

@ohtangza @ghsdh3409 PR from @ghsdh3409 has been merged!

@sunjae1294 I merged this pull request! Thanks for your efforts!!!😄


feat: introduce StateCommitment type

Overview
This PR introduces StateCommitment and KeyHasher traits. The StateCommitment trait is integrated as an associated type in the NodeTypes trait.  A implementation of the StateCommitment trait is provided for the MerklePatriciaTrie which represents the state commitment used in ethereum.
supports: #11830

What is the prefered method or fixing conflicts? Rebase and force-push or merge upstream?

@joshieDo could you provide a review on this when you have time please? We have a number of PR's lined up that will work towards #7434 in an incremental fashion.


Add option to export altered (rotated, etc.) versions of photos from iPhoto

Right now, it exports the original photos.  iPhoto offers ability to rotate (and otherwise edit, but rotation is the most important one) the photos. Apparently they are stored separately, and not actually over-writing the original files. I'd love there to be an option to export the rotated ones, instead of the originals.

If a photo is rotated in iPhoto the following happens:
photo.hasadjustments is False (assuming no previous adjustments)
photo.width, photo.height are adjusted accordingly
photo.orientation does not change (is 0 for iPhoto)
photo._info["rotation"] is set to the degrees rotated (e.g. 90 deg counter clockwise = 270]

Implemented as --fix-orientation. Need to add tests.

This is included in release v0.67.4


[$500] Task - Task shared in admin-only room can be marked done in chat, but not in the task report

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

As user A, create a room with admin only posting permission with User B and C
As user B, go to the room and click on the task
As user B, attempt to mark the task as done in the task report
As user B, return to the room chat and tap on the checkbox to mark it as done

Expected Result:
If the task edit access is denied for the other user, user should not be able to complete the task from the room chat and also the task report
Actual Result:
User is unable to mark the task as complete in the task report, but can do so from the room chat
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.69-0
Reproducible in staging?: Yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/ccd24bff-ac48-44b7-9644-c3b2e9b42d83
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010a5abcdb42d5f07e
Upwork Job ID:<PHONE_NUMBER>758084608
Last Price Increase: 2023-09-18
Automatic offers:

mollfpr | Reviewer | 26848651
hoangzinh | Contributor | 26848653

With new implementation, Anyone who can view the task can edit it.
Please confirm, @thi

adding external to get a c+

The issue still reproduces, but what is weird to me is that completing tasks from the non-admin user is returned fine from the API.

With new implementation, Anyone who can view the task can edit it.

@BhuvaneshPatil Could you attach the discussion of this?

Hmm yeah I think we may need to rethink this for an admin-only room though.
In this case actually I would think that only admins / the task assignee would be able to modify the task

We can align the check on the TaskView and TaskPreview with a unified function, so when we decide to change the behavior, we only need to change the function on each component.
Does this sound good to you?

Yeah sounds good, though I am surprised they are different - I would imagine that they would be using the same check if they can modify the task

I think the proposal from @hoangzinh looks good but with the addition of creating the function to check the disable action for both components. So let's go with that!
🎀 👀 🎀 C+ reviewed!

Not overdue, just assigned

Confirming the hire date here for @mollfpr is September 18.  Their first hire date was March 8, 2022 - link
cc @greg-schroeder, as an example for when/how we denote a contributor can be paid via NewDot

Payments:
Contributor: @hoangzinh $500
C+: @mollfpr $500

[@hoangzinh / @mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@hoangzinh / @mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR is causing the bug. This is an improvement to align the task action across the components.

[@hoangzinh / @mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@hoangzinh / @mollfpr] Determine if we should create a regression test for this bug.
[@hoangzinh / @mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Precondition: As user A, create a room with admin-only posting permission with User B and C. In that room, create a Task that is assigned to user B

Login as user B
Go to room above
Verify that user B can press the checkbox of updating Task status
Press on the task to go to Task report details
Verify that user B can press the checkbox of updating Task status
Sign out and sign in as user C
Go to room above
Verify that user C can not press the checkbox of updating Task status
Press on the task to go to Task report details
Verify that user C can not press the checkbox of updating Task status

$500 payment approved for @mollfpr based on BZ summary.

Created the TestRail GH cuz I happened to be reviewing this issue (for some unknown reason) so, closing meow

https://github.com/Expensify/Expensify/issues/327078


WIP: Issue 966: Extend HasSBOM to include references to included software …

…(Package and Artifact), dependencies and occurrences
Description of the PR
Extends HasSBOM to include related packages/artifacts, dependencies and occurrences.  Requires IDs to be sent for included nodes.  Addresses #966, but still needs work done on backends other than inmem.
Consider this a work in progress for now
PR Checklist

[X] All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
[X] All new changes are covered by tests
[X] If GraphQL schema is changed, make generate has been run
[ ] If collectsub protobuf has been changed, make proto has been run
[X] All CI checks are passing (tests and formatting)
[ ] All dependent PRs have already been merged

Note this PR needs discussion and further work so should not be merged at present

One question that needs answering relates to the edges used to identify Neighbors, as these are currently unidirectional (sbom -> PackageVersion/Artifact, IsDependency, IsOccurrence).  Do we want those to be bidirectional?  If so, how should we handle PackageVersion -> sbom?

Cherry-pick'd https://github.com/guacsec/guac/pull/1367/commits/890fe58057796046c2b56f2ee4e03de16ac1cdf7 because other PRs failing and it would fix them without having to wait for this PR to get merged.

@pxp928 updated to use a flattened structure.  There's also an additional commit for one e2e tests, it seemed to be non-deterministic in that the versions being diffed could be in different orders.

@pxp928 @mihaimaruseac I've pushed the latest version, now also including the sbom includes in the filtering.  I have also updated the source ingestion so it returns all IDs, rather than just the top level, non-specific ID.
I believe this is all the required functionality, let me know what you think and I can squash and remove the WIP tag if you are happy

Thanks very much.  I'll squash the PR into two commits, the first for these changes and the second for the small e2e test that's also in this PR.

Looks like I need to rebase again, I'll update to the latest main branch and push


native support for custom attributes on auth

Environment information
System:
  OS: macOS 14.4.1
  CPU: (8) arm64 Apple M1
  Memory: 210.19 MB / 16.00 GB
  Shell: /opt/homebrew/bin/fish
Binaries:
  Node: 20.11.1 - ~/.local/share/nvm/v20.11.1/bin/node
  Yarn: 1.22.19 - ~/.local/share/nvm/v20.11.1/bin/yarn
  npm: 10.2.4 - ~/.local/share/nvm/v20.11.1/bin/npm
  pnpm: 8.15.4 - ~/Library/pnpm/pnpm
NPM Packages:
  @aws-amplify/backend: 1.0.2
  @aws-amplify/backend-cli: 1.0.3
  aws-amplify: 6.3.2
  aws-cdk: 2.141.0
  aws-cdk-lib: 2.141.0
  typescript: 5.4.5
AWS environment variables:
  AWS_STS_REGIONAL_ENDPOINTS = regional
  AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
  AWS_SDK_LOAD_CONFIG = 1
No CDK environment variables

Description
Followup on issue: https://github.com/aws-amplify/amplify-backend/issues/1511
we currently need to modify the cfnUserPool schema to add a custom property on the backend. would be great if we could add this on defineAuth directly.

marking as a feature request

we could do something like
import { defineAuth } from "@aws-amplify/backend"

export const auth = defineAuth({
  loginWith: {
    email: true,
  },
  userAttributes: {
    "custom:favorite_color": {
      required: true,
    },
  },
})

The AWS CDK Congito user pool takes separate parameters for standardAttributes and customAttributes.
I think there are a few approaches that might be easier than allowing user attribute keys prefixed with custom:

Allow a user attributes key custom that is an object of user attributes. Example:

const userAttributes = {
  email: {
    required: true,
    mutable: true,
  },
  custom: {
    myCustomAttribute: {
      required: false,
      mutable: true,
    },
  },
}

Create a separate, optional auth prop for customAttributes that uses the CustomAttributeProps interface from the CDK

@josefaidt if you are open to either of these I can work on a PR.

Hey @ataylorme :wave: sorry I missed this message! This is now available with<EMAIL_ADDRESS>closing


Server doesn't indicate what _text is not supported

Describe the bug
Send a request
https://{FHIRSERVER}/Patient?_text=MOBILE
You get back:
{
    "resourceType": "Bundle",
    "id": "067b6651-9118-4543-b06c-3731ae039d8d",
    "meta": {
        "lastUpdated": "2021-04-26T23:46:54.070378+00:00"
    },
    "type": "searchset",
    "link": [
        {
            "relation": "self",
            "url": "https://localhost:44348/Patient?_text=MOBILE"
        }
    ],

which looks like we actually performed search with _text, but that's not the case.
FHIR Version?
Stu3/R4/R5
Data provider?
CosmosDB/SQL Server
To Reproduce
Steps to reproduce the behavior:
1.
2.
3.
Expected behavior
            "resource": {
                "resourceType": "OperationOutcome",
                "id": "516df2c7-7b92-4533-900d-5149641369b2",
                "issue": [
                    {
                        "severity": "warning",
                        "code": "not-supported",
                        "diagnostics": "The search parameter '_text' is not supported for resource type 'Patient'."
                    }
                ]
            },

be added to bundle, and _text be removed from self url.
Actual behavior
_text is present

AB#82463

@Ivanidzo4ka thanks for reporting the issue. Issue is now fixed.


Superset-node docker compose fails to create container

Docker-compose off of the master branch fails to launch the superset-node container with No such file or directory
Expected results
Superset-node container starts with docker-compose.
Actual results
Superset-node container does not start with docker-compose.
The docker error is bash: line 0: cd: /app/superset-frontend: No such file or directory
Seems like this commit may have caused the problem:
291306392 (David Aaron Suddjian 2020-02-09 17:53:56 -0800 69)     command: ["bash", "-c", "cd /app/superset-frontend && npm install && npm run dev"]
Screenshots
How to reproduce the bug
git clone https://github.com/apache/incubator-superset/
docker-compose up
Environment
Ubuntu 18.04.3 - AWS
Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[ ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

Can you try running docker-compose build first?

Delving further into this, I've discovered a related issue with the Dockerfile: some files are not being copied at the correct times from the correct places. I'll have a fix up soon. docker-compose build or docker-compose up --build will still be necessary after the fix.


How to generate a gallery of multi assets？

Your demo is so awesome. I wonder how to generate a gallery of multi assets. Thanks!

@YuyangYin We generate the assets one-by-one with the same input 3D exemplars but different concept images. Please refer to our paper for more details.


Fix AWS051 value is null warning

When aws_rds_cluster attribute kms_key_id was explicitly set to
null, tfsec did not catch the disabled encryption and issued a
warning:

WARNING: skipped AWS051 check due to error(s): value is null

The added test case reproduces this issue.
Note: The test case does not catch the issue though, as the test execution
logic seems to differ from the real scanning logic, in that it doesn't
try to format the result.

The actual error source is probably here: https://github.com/tfsec/tfsec/blob/6155d330bbb3b1c501fd431cc8242b86516d59f3/internal/app/tfsec/checks/aws051.go#L69-L74
Where check.NewResultWithValueAnnotation complains about kmsKeyIdAttr being null


append overwrites memory in extremely non-intuitive/difficult to debug way

What version of Go are you using (go version)?
go 1.11.1
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
Reproducible on go playground and on OSX
What did you do?
https://play.golang.org/p/m5q_dukI-21
What did you expect to see?
Same, correct sorted value.
What did you see instead?
Different values.
What is happening in this algorithm, is that in the incorrect sort, when it gets to sorting the last 2, it appends the 2 onto first := A[:i] ([1, 2]. When this happens, it appears to overwrite first memory address of last := A[:i] with the appended value, discarding the prior value that was desired to be maintained. Thus, instead of last being [3, 4], it is at that point [2,4], which when appended on insert result, gives the wrong answer.
The work around is to copy the slices first. Then all works fine.
This just feels wrong that append works this way and may be a bug. At the very least, it seems some documentation on this is warranted to highlight this non-intuitive behavior that appending to a partial slice can overwrite the original slice's memory allocation.

Created simpler script to highlight issue:
https://play.golang.org/p/1BRWOxmXaoU

Regarding documentation: this is a fairly direct consequence of the fact that a slice is just a view into an array. This is explained in the go tour (which is probably the main entry point to the language for beginners, and the most basic piece of documentation we have):

An array has a fixed size. A slice, on the other hand, is a dynamically-sized, flexible view into the elements of an array.

A slice does not store any data, it just describes a section of an underlying array.
Changing the elements of a slice modifies the corresponding elements of its underlying array.
Other slices that share the same underlying array will see those changes.

(https://tour.golang.org/moretypes/7 and the following page).

@ALTree The documentation there is clear in the context of a slice and changing an element of the slice mutating the original array. I think the addition of append and the wording on available capacity and allocating a new array is a little unclear. Basically, with append, depending on the nature of the slice, you will get two different results. In any case, made another mental note about unexpected mutation possibilities in go.
Thx.


Initial draft POC implementation of C API to be used by Lua language

Initial draft POC implementation of C API to be used by Lua language.
Use example in lua_example directory after installing the library from source code.
Run the example as lua hello.lua. Before running the example, create a symbolic link named hazelcast.so in the directory to the installed libhazelcast-cpp-client.so file.
Prerequisites:

Install lua
Install boost library (see installing the library )

Linux test PASSed.

Windows test PASSed.

Linux test PASSed.

Windows test FAILed.

Linux test FAILed.

Windows test FAILed.

Linux test FAILed.

Windows test FAILed.

Linux test PASSed.

Windows test FAILed.

Linux test PASSed.

Windows test FAILed.

Closing this PR, since we decided to continue with a different solution which works async with co-socket API.


Neighbourhooding with topographic masking - Investigate implementation

As an IMPROVER developer I need to determine the best method of implementing masked neighbourhooding using a series of discrete topographic bands. This investigation needs to consider the stages from masking the data, through performing the neighbourhooding, to consolidating the data back into a single level diagnostic as output. The way the plugins will interface should be considered, the amount of work to implement a given scheme should be assessed, and the scientific validity of different approaches should be appraised.
There is discussion of the issues in the "Neighbourhood Processing and spatial filtering" epic pages.
There are two main possible ways of implementing masked neighbourhoods:

Use binary masks for the neighbourhooding and then use blending across adjacent bands using a weighting that is determined point by point based on the point's position in the band.

Use fuzzy masking to take into account where all the point in the band are relative to the boundaries of the band. Use these fractional masks in neighbourhood processing.

In principle the neighbourhooding with mask plugin produced (see IMPRO-179) could support either method of implementation. The topographic mask generation code currently only produces binary masks and would need to be adapted to support method 2.
The product of the neighbourhooding with mask plugin has the following structure as output:
thickness_of_rainfall_amount / (m)
(topographic_zone: 3; realization: 3; projection_y_coordinate: 970; projection_x_coordinate: 1042)
The topographic_zone coordinate must be collapsed if we are to obtain a single level surface diagnostic variable once again (the topographic zones are ASL, whilst the diagnostic being processed is terrain following surface diagnostic). This is the final stage in the process that must be considered. If sharp masks are applied (e.g. -re_mask = True) then each level will contain data only in non-overlapping spatial regions. This vertical coordinate could be collapsed with a procedure as simple as taking the max in a column to give a single layer diagnostic. If fuzziness has been employed, or binary masks without remasking, then there will be overlap and a weighted blend across the vertical coordinates must be employed.
Acceptance criteria:

Explore the methods discussed above and others if appropriate.
Perform tests and record the comparative results of the approaches.
Recommend a method of implementation, noting any likely difficulties or useful information.

Completed.


Not able to find the 'identity' jar

Cannot find the identity jar on maven repository
I tried to build via gradle but it is not finding implementation group: 'com.hedera.hashgraph', name: 'identity', version: '1.1.4'

please review the readme file https://github.com/hashgraph/did-sdk-java/blob/master/README.md and try again. If you are getting the same issue. please provide more detail or close this ticket.


[feat] Adding kn-plugin-func to release page

Changes

:gift:  This PR adds the knative-sandbox/kn-plugin-func to the release process. This is added after knative/client as the project depends on it.

/kind enhancement

It doesn't fix any issue, as we are just adding knative-sandbox/kn-plugin-func to the release process.

Release Note

Docs

Related: https://github.com/knative-sandbox/knobots/pull/237

/lgtm
/approve


Spectrum Style differing a lot in terrafomr .tf files

Hi, could you take a look at this issue?
Seems like similar colours but complitley different placed.
*Left is the original Monokai Pro Spectrum on VSCode with the Hashicorp terraform plugin.
*Right is the Free Pycharm IDE with monokai-pro spectrum style and terraform plugin.
This are normal variables declared in module_vars.tf
https://cdn.knightlab.com/libs/juxtapose/latest/embed/index.html?uid=25a49e4c-2f4d-11eb-83c8-ebb5d6f907df
This are module implementation in module.tf
https://cdn.knightlab.com/libs/juxtapose/latest/embed/index.html?uid=bb7249a0-2f4b-11eb-83c8-ebb5d6f907df

Sorry for the late response, I wasn't able to see what you are referring to. Could you include an attachment what you are seeing?

Let me re-upload and edit.


"Invalid issuer or signature" from SPO while attempting a REST GET request from Salesforce

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
An XML document showing the list of all the files in a Sharepoint environment with the following URL: https://hanoverresearch.sharepoint.com/_api/web/list
Observed Behavior
When executing my Salesforce Apex code to run the REST action on Sharepoint, I receive the following error: DEBUG|{"error_description":"Invalid issuer or signature."} even after uploading a self-signed certificate to the app under the Microsoft App Registration Portal.
Steps to Reproduce
In Salesforce Apex, copy the below C# code and select Run:
public class AuthCallout {
   public static void basicAuthCallout(){
     HttpRequest req = new HttpRequest();
     req.setMethod('GET');
     req.setEndpoint('callout:Sharepoint_Online/_api/web/list');
}
}

I solved the issue. The URL for my callout needs to go through Microsoft Graph. I'll let someone else close this issue if deemed necessary.


Add zsh completion for the new 'docker secret' command

ref. #27794
I didn't manage to test it on a 1.13 build yet. I would really appreciate if someone can test it to confirm that secret completion is working well.
ping @albers for bash completion
Signed-off-by: Steve Durrheimer<EMAIL_ADDRESS>

@sdurrheimer Thanks for the ping.

Thank you @sdurrheimer !

@sdurrheimer don't forget to also add --secret completion to service create and service update 👼


Forwarding data to other mqtt clients

It would be very helpful if the data were forwarded to other mqtt clients. e.g.: if you operate a productive and a test system. I hope this is doable.

Simply connect to the server with a client and subscribe? I would assume this works


README.md

edit README.md file

You should notice that if you decide to split your PR into two, you should also split the commits between them. The flake8 file doesn't belong here, you can remove it. Also, you can remove the "added image" commit from the other PR. You can close the related issue #16 Besides that, everything looks good


Update for Compute 2021-11-01 version

All SDK Contribution checklist:
This PR is for Compute Rest API 2021-11-01 version: https://github.com/Azure/azure-rest-api-specs/pull/17120
Tests that use CRP calls were re-recorded to use the 2021-11-01 version.
New features were added for this version with new test coverages and recordings.
Customizations were added for changed signature changes to avoid breaking changes.
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[x] Include updated management metadata.
[x] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@grizzlytheodore please fix the failed tests.

@fengzhou-msft  I am having a hard time solving the CI failure. Looking at the CI failure log, if I search for [FAIL] I see that test Compute.Tests.VMScaleSetUpdateTests.TestVMScaleSetScalingOperations is failing with:
System.Collections.Generic.KeyNotFoundException : Unable to find a matching HTTP request for URL 'GET /subscriptions/e37510d7-33b6-4676-886f-ee75bcc01871/providers/Microsoft.Compute/locations/SoutheastAsia/publishers/MicrosoftWindowsServer/artifacttypes/vmimage/offers/WindowsServer/skus/2012-R2-Datacenter/versions?$top=1&api-version=2021-11-01'. Calling method Item().
However I can find that line is recorded here for that test.
Also, I am getting different number of tests failing in playback mode in my VM, and in my personal workstation. Also the numbers change when I run all the tests vs just the failing ones.
Any advice?

@fengzhou-msft  please review/merge !


Expose Flutter SDK version through API

As for testing, I haven't tested with the existing DartPad. However, looking at the code that Discovery generates for the API, it'll have no issue ignoring additional fields. It's looking for specific named fields in the json parsed object tree.

@RedBrogdon I've tested this PR in production, and everything appears happy in DartPad land. Landing as is.


refactor grunt to load tasks only when required (JIT)

The main Grunt file sets the key paths as variables, which are then available for use in the tasks. This helps with a few things including:

reusable configs across different projects
git history is cleaner with modular approach
easier to avoid merge conflicts

We'll be working on this one Friday. Thanks!


YARN-11621: Fix intermittently failing unit test: TestAMRMProxy.testAMRMProxyTokenRenewal

Description of PR
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m  8s

trunk passed

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 29s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 34s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 56s

trunk passed

+1 :green_heart:
shadedclient
32m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 24s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 25s

the patch passed

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 56s

the patch passed

+1 :green_heart:
shadedclient
32m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
28m 22s

hadoop-yarn-client in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

148m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6310/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6310

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 27ddc97e7269 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20 08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d3824e1ed902fba02203cc83d19c2290aebadece

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6310/1/testReport/

Max. process+thread count
675 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6310/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @susheelgupta7 for the patch, @p-szucs and @slfan1989 for the review. Merging to trunk. @susheelgupta7 can you please check if this is applicable for branch-3.3/3.2?


ClusterLoader - Updating measurement api

Adding new fields to Measurement API:

Identifier - is a identifier within method scope.
Pair <Method, Identifier> makes measurement unique at global scope. The new field is needed due to possible having multiple measurements  instances that uses the same measurement method.
Params - map of <name, value>. Optional additional method parameters. Allows measurements to be more generic.

/assign @shyamjvs

Since we started thinking about the precise details of the measurement API, I have some thoughts about how it should look like:

We should change the Measurement interface to just have a single method in it called Execute() instead of two methods Start() and Stop(). This also would be similar to how we have ExecutePhase method for phases. The reason I say is the following:

Not all measurement operations need to have start and stop, because it may not make sense for certain operations (for e.g one-off things like WaitForAllPodsReady, GatherMemoryProfile, etc). IMO we shouldn't force user to implement 2 functions (start and stop) for such cases.
For operations where start and stop indeed make sense, you can still represent those through single Execute method - you'd just need to pass an additional start/stop as a parameter in Params

The signature of the Execute function should look as follows - func (m Measurement) Execute(ClientConfig, Params) error. ClientConfig would contain kubeClient (to talk to the k8s API) and cloudProvider (to talk to cloud-provider API) - I can think of e.g.s why either of them would be needed. And Params of course is to allow injecting arbitrary inputs to the Execute method.

@wojtek-t

/lgtm
I'll send a PR to update the doc with the above thoughts. Let's see what Wojtek thinks.


Convert metadata to async

Plus small fix to pass new Get Assertion F-5 test.

LGTM.
I would change our controllers to be Async so that we can await the Initialize method if we want to.
@CodeTherapist So the reason why we don't initialize internally automatically is because we have sync API's and the init should be done async so to avoid complexity, we need to offload this.
Also running with MetaData is "kind of optional" and the consumer could use other MetaDataServices (cached on file for closed environments) etc.


page.evaluate returns CSSOM as lowercased

While inside of a page, getting rules via window.document.styleSheets[index].cssRules seems to be returning the selectorText of each rule in the array as lowercase, regardless of the case of the CSS read. I ran into this while using https://github.com/filamentgroup/criticalCSS which makes use of phantomJS.
In this case, because the outputted data is lowercased css, further use of document.querySelector() to find matching rules will fail if the original CSS was not lowercase, because that method (as well as the class attribute of HTML)  is case sensitive.

You can close this. The issue occurs when your document is missing the HTML5 doctype:
<!DOCTYPE html>

The fix for this issue was submitted to criticalCSS. For other PhantomJS users, the fix would be in the source HTML document being requested by phantom.


feat: use Pydantic validator and support for new CNIs

Description
This PR aims to leverage Pydantic to validate charm config input parameters.
Support for host-device CNI type is added.
Config option enable-hugepages is removed and it is inferred from upf-mode.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] I have added tests that validate the behaviour of the software
[x] I validated that new and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have bumped the version of the library

what do you think about taking advantage of the types CNIType and UpfMode inside charm.py ?


Question, why has the development halted in this repo?

Is it unmaintained or is there simply no reason for updates?

really good question

In case you are still looking for more active projects for GLTF integration in Unity, these two seem quite interesting: glTFast and GLTFUtility

There's also an active fork, https://github.com/prefrontalcortex/UnityGLTF, which will be PR'd into this repository here at some point to at least bring it back into shape and make sure other people benefit from the fixes we did.

Update: PR has now been made. If you care about this repo it would be great if you check that –

https://github.com/KhronosGroup/UnityGLTF/pull/644

Thanks!


use different formatter for different section

I am using eslint. So I want to auto-format the .vue files on save.
I want to invoke eslint to format the script section and vscode.css-language-features to format the style section. Is it possible?

ESLint part: try https://github.com/antfu/eslint-processor-vue-blocks


Add a PR triage policy to the contributing guide.

@Hixie @csells @kf6gpe

Ideally all of this would go to the wiki, as we have done for the engine and framework contributor docs. (Doesn't have to block this PR, though.)

@amirh should we land this PR or move it to the wiki as @Hixie suggested?

Filed https://github.com/flutter/flutter/issues/35747 to move all contents from CONTRIUBTING.md to the wiki.
Landing this for now.


Having issue with basic install

After going through installation instructions - git pull and pdm sync, any command I try to run I am getting following error " from fish_diffusion.archs.diffsinger.diffsinger import DiffSingerLightning
ModuleNotFoundError: No module named 'fish_diffusion'"
Not sure how to go past this.

Can you try pdm install?

fish-diffusion>pdm install
All packages are synced to date, nothing to do.
Installing the project as an editable package...
v Update fish-diffusion 2.2.0+editable -> 2.2.0 successful
All complete!
fish-diffusion\tools\diffusion\inference.py", line 17, in
from fish_diffusion.archs.diffsinger.diffsinger import DiffSingerLightning
ModuleNotFoundError: No module named 'fish_diffusion'

Did you activate the pdm env? ususally in .venv

Closed due to inactive


Tiny layout shift (SSR)

I experiment a tiny layout shift (tenth of a percent) after hydration.
On the server, and during the first render on the client, Panes flex-grow are set with defaultSize:
https://github.com/bvaughn/react-resizable-panels/blob/6d9f1b33553fb61a548384631b3731271dfe66f6/packages/react-resizable-panels/src/utils/computePanelFlexBoxStyle.ts#L29
On consecutive renders, Panes flex-grow are set with size.toPrecision(precision)
The difference between the raw size and the rounded one cause a tiny layout shift just after hydration. (eg. flex-grow:64.3238875877 becomes flex-grow:64.3).
Is it possible to apply same constraints on defaultSize than on size to prevent this?
Possible user workaround: store rounded sizes[] in cookie/backend instead of the raw one.
  const onLayout = (sizes: number[]) => {
    const roundedSizes = sizes.map(s => Number(s.toPrecision(3)));
    ...
  };

Hopefully fixed in a45ab6c; published in 2.0.7

❤ → ☕ givebrian.coffee


Allow navigation between related code, e.g. from test to implementation

I have checked that this feature is not already implemented

[x] This feature does not exist

Use case
See below
Description
It's convenient for developers to jump between a test and its corresponding implementation.
(in Vim, Projectionist is a popular plugin for this)
Implementation
A planned VS Code feature may help with this: https://github.com/microsoft/vscode/issues/126932
But it would good to have it available for all editors.

How is this one different than #2665? Can we close one of the two and keep a single issue?

Ah, I didn't find that when looking.
Let's keep this one as it describes it in a more general way (e.g. for Rails, this the same mechanism that could power jumping from a controller action to its view).

We should report this as a possible use case in https://github.com/microsoft/vscode/issues/126932 and suggest making go to related code more generic. I might be wrong, but based on the issue's title it looks like they are planning it more as a testing thing rather than a general feature.

https://github.com/microsoft/vscode/issues/126932#issuecomment-2532116867


Made changes in the profile section

Also, please mention the issue number

Issue No. - #385

Hi @shruti8302 can you please resolve the conflicts? Sorry for the inconvenience

I did.

I have added a commit to remove the syntax error due to merge conflict.. please try git pull before making changes

Okay

I have made the required changes.

I have made the required changes.

Cool, reviewing them

Thanks for your contribution! :)


gerrit-313790-6

Current coverage is 62.77% (diff: 100%)

Merging #432 into master will decrease coverage by 11.17%

@@             master       #432   diff @@
==========================================
  Files           179        267      +88
  Lines         39503      50265   +10762
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          29211      31553    +2342
- Misses        10292      18712    +8420
  Partials          0          0

Powered by Codecov. Last update 897bbb3...aabab5e


interpolation operator

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 82 (0.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 84.937%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

operators/src/processing/interpolation/mod.rs
0
82
0.0%

Files with Coverage Reduction
New Missed Lines
%

operators/src/source/ogr_source/mod.rs
1
92.53%

services/src/server.rs
1
66.46%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
31183

Relevant Lines:
36713

💛  - Coveralls

bors merge


Display tooltip on the custom emoji

EmojiText: 3.6.0
macOS: 14.3 (23D56)
Once again, thank you for fixing the custom emoji text height.
Please, I would like to have tooltip displayed on the custom emoji. If you browse the website and place the cursor on the custom emoji, it will display a tooltip showing the custom emoji shortcode. I was thinking by default, it should do that but allow the developer to customise it to display anything else.
The API could look something like this for RemoteEmoji:
RemoteEmoji(shortcode: ..., url: ..., help: ":customshortcode:")

I called it help because that is what it is called in SwiftUI whereas in Cocoa and Cocoa Touch, it is called tooltip, sometimes toolTip.

Agreed, that would be a nice addition. I was looking into that not too long ago, but I haven't found a proper way to add that.
If you find a way to add help / tooltip to an interpolated Image in Text let me know.


Name of the option to select a specific pluralization

Hi!
I have been using your wonderful library (by react-translate-component).
When I used pluralization, I was faced with a problem. I used notationsCount instead of count as name for option to select a specific pluralization and got an error Uncaught Invariant Violation: Interpolate expects either a format string as only child or a 'format' prop with a string value.
It took some time until I figured it out.
Please emphasize in the documentation the fact that the name of the option to select a specific pluralization must be count.

Done. Thanks!

Interpolate expects either a format string as only child or a format prop with a string value
error ? any solution !


export feature in jstable

is jstable have a export feature to excel or csv?

There is currently no export feature.
Feel free to submit a pull request for the export.


Improving support for numpy.random

I've noticed that there are four distributions in numpy.random that are not supported by Numba yet, i.e.
multinomial
multivariate_normal
noncentral_chisquare
noncentral_f

Is there any particular difficulty?

This can certainly be done (and you can often write the implementations in Python rather than use the LLVM builder syntax).  Here is where the implementation of the beta distribution is defined, as an example:
https://github.com/numba/numba/blob/master/numba/targets/randomimpl.py#L557-L579
New functions also need to be registered with the front end, as seen here:
https://github.com/numba/numba/blob/master/numba/typing/randomdecl.py#L105

I haven't looked at the implementation of these distributions in numpy, though.  They might depend on some external data or functions that are harder to put into Numba.  If you do attempt one of these functions, please let us know if you run into trouble.

Some of those distributions return vectors, which wasn't possible in nopython mode when the random module was first implemented. We would actually have to add the possibility of return random arrays to all existing methods.

@seibert
The pseudo-code for implementing  noncentral_chisquare and noncentral_f is quite simple. I gave one at numpy/numpy#5766 for improving noncentral_chisquare. According to
https://github.com/numpy/numpy/blob/master/numpy/random/mtrand/distributions.c#L256-L260
a noncentral-f random variate with parameters dfnum, dfden, and nonc can be generated by
t = np.random.noncentral_chisquare(dfnum, nonc) * dfden
t / (np.random.chisquare(dfden) * dfnum)

My python skill is very limited (otherwise I would have submitted a PR). Unless there's something more subtle, is it possible to add support for these two methods in Numba?
Btw, an important application of noncentral chisquare distribution is in financial engineering, where it is used to simulate sample paths of the popular Cox-Ross-Ingersoll model.

multinomial is now supported as of PR #1758.

multivariate_normal?
Any workaround?

@spring-haru thanks for asking about this on the Numba issue tracker. I believe you may be able to use http://numba.pydata.org/numba-doc/latest/developer/autogen_numpy_listing.html#numpy.random.normal as a basis to sample from a multinomial Gaussian. I did a quick google and found: http://numba.pydata.org/numba-doc/latest/developer/autogen_numpy_listing.html#numpy.random.normal -- from what I can tell from a first glance all required NumPy functions are supported so the listed code is likely to work with Numba with a few adaptations. Good luck and do let us know how it goes.

I am interested in using multivariate_normal  in Numba. Any tips on how to do so? Thanks!

I am interested in using multivariate_normal  in Numba. Any tips on how to do so? Thanks!

I think the hard part is multivariate_normal.cdf. It uses some arcane fortran code that might be hard to port.

For anyone looking to sample from a multivariate_normal in Numba, I would recommend following the steps in this blog post. Specifically, you can use the Cholesky decomposition to get samples from the target distribution using samples from the standard normal.


Global ignore filter tag

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.

🔖 Feature description
I would like to use a tag to ignore tasks which have that tag in them.
currently, we have a Global task filter setting which only includes tasks which have a specific tag. But I would not prefer adding a tasks to all the tasks just for the sake of using the tasks plugin. So I'm not using the global filter. But I still do have few tasks in couple of notes which I don't want the plugin to consider, and I would like to have a Global ignore filter to exclude all tasks that have this tag.
✔ Solution

Add an option to add a ignore tag in the settings window
use this tag from settings to ignore all tasks that have this tag.

❓ Alternatives
The current alternative is to use the do not include clause in the query like below
```tasks
not done
tags does not include #ignoreTask
group by filename
```

but I would like not having to include this in every query.
📝 Additional Context
No response

Hi, thanks for using Tasks.
This is similar to #1564, which proposed adding a setting to exclude one or more folders.
Out of the discussion for that, I proposed #1619.

Provide a user setting for filters and instructions to apply to every tasks block

This would allow you to add that tags does not include automatically in to every query, and is a more general solution.

This would allow you to add that tags does not include automatically in to every query,

A potential issue with doing this is that - it will not be dynamic.
For example, if the tags does not include #ignoreTask is automatically added to 100 query till today, and I want to change the tag or rename the tag to something else (like #excludeTask), I would have to edit the queries in all of these 100 pages, which would be cumbersome.

This would allow you to add that tags does not include automatically in to every query,

A potential issue with doing this is that - it will not be dynamic.
For example, if the tags does not include #ignoreTask is automatically added to 100 query till today, and I want to change the tag or rename the tag to something else (like #excludeTask), I would have to edit the queries in all of these 100 pages, which would be cumbersome.

I don't understand. Why will it not be dynamic, and why would you need to change 100 queries?
Did #1619 make sense to you?
Its idea is that you specifically would not need to state the tag to ignore in 100 files, because you could do it in one place in a task block in you settings, so if you change the tag, you would change the filter in your settings.
Which is the same amount of effort as changing an global ignore filter tag in the settings, but a lot more flexible, because you could also ignore a whole folder without needing to add ignore tags to every task in that folder.

This would allow you to add that tags does not include automatically in to every query,

My understanding of this statement is that, when I add a query in any note using ```tasks``` keyword, I can configure the plugin to automatically add the following query
```tasks
tags does not include #ignoreTask
```

If this is the case, then this hard-codes the text tags does not include #ignoreTask inside the query in the note that i'm adding it in.
So in the future if I do decide to change the tag from #ignoreTask to #excludeTask, then I have to go back to all the past notes and manually change them - since they are hard-coded in the query.
Please correct me if i'm wrong.

My understanding is that in this feature request, you are asking for:

Add an option to add a ignore tag in the settings window
use this tag from settings to ignore all tasks that have this tag.

If in future you decided to change the tag that is in the settings from #ignoreTask to #excludeTask, then you would still have to go back to all the past notes and manually change their tags, to prevent them from otherwise re-appearing after you changed the settings.
I am struggling to find other ways of explaining why the two suggestions achieve the same effect for the same behaviour.

Oh, okay. I'll try to articulate in a better way below.

the feature request is to automatically ignore all the tasks which contain the specified tag - without having to speficy the clause (tags does not include #ignoreTask) in the query (manually or automatically)

But the statement below says that the clause will be automatically added in all queries

This would allow you to add that tags does not include automatically in to every query,

So the difference between the two is

If I change the tag later in settings, this will automatically update all the queries - since they refer to the specified tag from the settings pane & the query does not have the clause specified
If I change the tag later, I'll have to change the clause in all the previous queries - since the clause is within the query.

I hope this conveys what I'm trying to say.

One more point I'd like to add is - the feature request is basically the exact opposite of the global task filter feature - where only tasks that contain the specified tag are included in the result - the query doesn't have to specify the clause tag includes #task if the global task filter has this tag.
Similarly, the global ignore filter will exclude the tasks that contain a specified tag in the result - the query doesn't have to specify the clause tag does not include #ignoreTask if the global ignore filter has this tag.

So the difference between the two is

If I change the tag later in settings, this will automatically update all the queries - since they refer to the specified tag from the settings pane & the query does not have the clause specified
If I change the tag later, I'll have to change the clause in all the previous queries - since the clause is within the query.

Ah, I see the misunderstanding now.
No, that is not what the feature request is describing.
The feature would not literally add a tag includes...-type line to all your queries in files.
Instead, whenever any queries are executed, the proposed feature would make the Tasks plugin go to your settings, and if you had any global query instructions there, it would add them in memory to your own query lines.
The idea is that you can edit the global query, restart Obsidian, and change the behaviour of all your queries (without changing all your query files)
I hope that is at least clear.

you would still have to go back to all the past notes and manually change their tags, to prevent them from otherwise re-appearing after you changed the settings.

And to address this point, I would include both #ignoreTask and #excludeTask in the global ignore filter.
I understand that the ultimate output is going to be the same. But in my opinion, not adding the clause in the query makes it

easy to manage
Scalable
Does not clutter the source markdown

The feature would not literally add a tag includes...-type line to all your queries in files.

Okay great. This helps in clarifying things.
Thank you so much. That's what I was looking for as well.

you would still have to go back to all the past notes and manually change their tags, to prevent them from otherwise re-appearing after you changed the settings.

And to address this point, I would include both #ignoreTask and #excludeTask in the global ignore filter.

Ah right, so I understand why this is appealing, but now this proposes to allow the user to add more than one global ignore filter. Which is more complexity in the settings and a lot more complexity in the code.
Whereas a set of global instructions can have any combination of the existing query filters.
If this were a commercial product and someone felt there was financial value in providing global ignore filters as well as global query instructions, I might consider doing it.
But as well as user convenience I have to consider avoiding adding the overhead of more complexity to the plugin's code base.
So although I know you are really keen on global ignore filters, now that the alternative proposal is at least clear, I am going to close this issue, in favour of the more flexible (for users) and more doable for (for developers) https://github.com/obsidian-tasks-group/obsidian-tasks/issues/1619.

Just released in Tasks 3.5.0 is a new Global Query facility, that allows this request to be solved by adding an instruction to the vault's global query.
See the Global Query docs for details and ideas.


Integrate watcher into CI for GS

Issues that watcher has uncovered from our post_commit suite:
Hang:

[x] #4151

Watcher noc transaction errors / immediately actionable:

[x] #3827
[x] #3988
[x] #4069

PCC errors

[x] #4055
[x] #4086 - testing here
[x] #4089 - David has fixed, currently testing here
[x] #3625 - to remain disabled on Bill's branch. this test will be deprecated soon.
[ ] #4085 - Muthu to check PCC
[ ] #4088 - Muthu to check PCC; not passing stress test https://github.com/tenstorrent-metal/tt-metal/actions/runs/7084274248/job/19278233730

@TT-billteng , what is the status of the remaining issues here? do we know if they still fail with these test turned on?

Watcher is now active on the stress test pipeline and recently has been green! https://github.com/tenstorrent-metal/tt-metal/actions/runs/7441497962


Add support for Python 3.10

Addressing issue https://github.com/conda-forge/sktime-feedstock/issues/47 and https://github.com/conda-forge/autogluon.timeseries-feedstock/pull/9

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@fkiraly @dhirschfeld @freddyaboulton @lmmentel @mloning The PR has passed the Python 3.10 checks. Can one of you review and merge it? We are wait for sktime to support Python 3.10 so that downstream packages can support Python 3.10.

This PR looks fine and upstream claim to support requires-python = ">=3.7,<3.12" so I think this is good to merge.
I'll give the upstream maintainers a chance to review though before applying EAFTP and merging myself...


Upgrade card creation

Description

Calculate the upgrade to the gold price
Hide info card in the gold package
Add tooltip for each package card

Changes

Related Issues

https://github.com/threefoldtech/tfgrid-sdk-ts/issues/2429

Checklist

[ ] Tests included
[x] Build pass
[ ] Documentation
[x] Code format and docstrings
[x] Screenshots/Video attached (needed for UI changes)

please include UI changes such as these cards in the PR description as well

the cards show up like this for me even after pulling and rebuilding

@amiraabouhadid it's because you used your current price which doesn't even reach the bronze package price

@AlaaElattar are you sure you're on my branch?
Screencast from 19-05-24 16:29:44.webm

@AlaaElattar are you sure you're on my branch?
Screencast.from.19-05-<IP_ADDRESS>.webm

yes I tested it again now and it's working right.


Can no longer load SD1.5 models in tester

When trying to load either of my two stable diffusion 1.5 training sessions in the "Test the trained model" step, I get the following error.  I have tried deleting the sd folder from my gdrive to get a fresh install of the UI, but the error persists.
LatentDiffusion: Running in eps-prediction mode
DiffusionWrapper has 859.52 M params.
Downloading100% 961k/961k [00:00<00:00, 1.88MB/s]
Downloading100% 4.52k/4.52k [00:00<00:00, 2.93MB/s]
Failed to create model quickly; will retry using slow method.
LatentDiffusion: Running in eps-prediction mode
DiffusionWrapper has 859.52 M params.
loading stable diffusion model: TypeError
Traceback (most recent call last):
  File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/sd_models.py", line 338, in load_model
    sd_model = instantiate_from_config(sd_config.model)
  File "/content/gdrive/MyDrive/sd/stablediffusion/ldm/util.py", line 79, in instantiate_from_config
    return get_obj_from_str(config["target"])(**config.get("params", dict()))
  File "/content/gdrive/MyDrive/sd/stablediffusion/ldm/models/diffusion/ddpm.py", line 563, in __init__
    self.instantiate_cond_stage(cond_stage_config)
  File "/content/gdrive/MyDrive/sd/stablediffusion/ldm/models/diffusion/ddpm.py", line 630, in instantiate_cond_stage
    model = instantiate_from_config(config)
  File "/content/gdrive/MyDrive/sd/stablediffusion/ldm/util.py", line 79, in instantiate_from_config
    return get_obj_from_str(config["target"])(**config.get("params", dict()))
  File "/content/gdrive/MyDrive/sd/stablediffusion/ldm/modules/encoders/modules.py", line 99, in __init__
    self.tokenizer = CLIPTokenizer.from_pretrained(version)
  File "/usr/local/lib/python3.8/dist-packages/transformers/tokenization_utils_base.py", line 1777, in from_pretrained
    return cls._from_pretrained(
  File "/usr/local/lib/python3.8/dist-packages/transformers/tokenization_utils_base.py", line 1932, in _from_pretrained
    tokenizer = cls(*init_inputs, **init_kwargs)
  File "/usr/local/lib/python3.8/dist-packages/transformers/models/clip/tokenization_clip.py", line 328, in __init__
    with open(merges_file, encoding="utf-8") as merges_handle:
TypeError: expected str, bytes or os.PathLike object, not NoneType

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/webui.py", line 74, in initialize
    modules.sd_models.load_model()
  File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/sd_models.py", line 341, in load_model
    sd_model = instantiate_from_config(sd_config.model)
  File "/content/gdrive/MyDrive/sd/stablediffusion/ldm/util.py", line 79, in instantiate_from_config
    return get_obj_from_str(config["target"])(**config.get("params", dict()))
  File "/content/gdrive/MyDrive/sd/stablediffusion/ldm/models/diffusion/ddpm.py", line 563, in __init__
    self.instantiate_cond_stage(cond_stage_config)
  File "/content/gdrive/MyDrive/sd/stablediffusion/ldm/models/diffusion/ddpm.py", line 630, in instantiate_cond_stage
    model = instantiate_from_config(config)
  File "/content/gdrive/MyDrive/sd/stablediffusion/ldm/util.py", line 79, in instantiate_from_config
    return get_obj_from_str(config["target"])(**config.get("params", dict()))
  File "/content/gdrive/MyDrive/sd/stablediffusion/ldm/modules/encoders/modules.py", line 99, in __init__
    self.tokenizer = CLIPTokenizer.from_pretrained(version)
  File "/usr/local/lib/python3.8/dist-packages/transformers/tokenization_utils_base.py", line 1777, in from_pretrained
    return cls._from_pretrained(
  File "/usr/local/lib/python3.8/dist-packages/transformers/tokenization_utils_base.py", line 1932, in _from_pretrained
    tokenizer = cls(*init_inputs, **init_kwargs)
  File "/usr/local/lib/python3.8/dist-packages/transformers/models/clip/tokenization_clip.py", line 328, in __init__
    with open(merges_file, encoding="utf-8") as merges_handle:
TypeError: expected str, bytes or os.PathLike object, not NoneType

Stable diffusion model failed to load, exiting

It seems to work fine when testing my SD v2 models however

it might be a problem with your repos, try with a clean sd folder

I have the same problem

same  , delete the sd folder and use the latest version of the drembooth notebook and the error still appears

Guys, try this colab, looks like it works fine now
https://colab.research.google.com/github/TheLastBen/fast-stable-diffusion/blob/main/fast_stable_diffusion_AUTOMATIC1111.ipynb?authuser=2

Facing the same issue, deleting sd folder and installing new version doesnt help

you need to use the latest colab https://colab.research.google.com/github/TheLastBen/fast-stable-diffusion/blob/main/fast_stable_diffusion_AUTOMATIC1111.ipynb

this workbook still throws the error for me:
https://github.com/TheLastBen/fast-stable-diffusion/blob/main/fast-DreamBooth.ipynb
one day before it worked :/

I I'm using the same notebook at this very moment and it works, remove your sd folder

I am quite confused. I deleted all data on google drive - did a fresh run - now it breaks at training with new images...
no custom image.
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 64: invalid start byte

During handling of the above exception, another exception occurred:

one of your images is probably corrupt, try converting the image to png or jpg

one of your images is probably corrupt, try converting the image to png or jpg

I will try to figure out if the image files are the problem. thanks!

There is definitely an issue here, I've tried multiple times with the latest notebook and by removing the sd folder (which usually always does the trick)
I trained a new 1.5 model just to be sure and still errors out. When trying to load that same recently trained 1.5 through the fast-stablediffusion instead of fast-dreambooth notebook the model works perfectly.
Also I've seen 2 different errors one occurred right after training and trying to test: TypeError: expected str, bytes or os.PathLike object, not NoneType and the other happens when trying to load an old 1.5 model: Can't load tokenizer for 'openai/clip-vit-large-patch14'.
All v2 models working on fast-dreambooth
No 1.5 models working on fast-dreambooth
All models working on fast-stablediffusion-auto
I might still be doing something wrong but tried everything I can think of.

There was something messed up with my google Drive I think, somehow the trainig worked again after using another Google account.
However I am running in the same issue like @Excalibro1 described.
stable diffusion 1.5
TypeError: expected str, bytes or os.PathLike object, not NoneType
I can confirm the error when loading  an old model also.
Can't load tokenizer for 'openai/clip-vit-large-patch14'

working on a fix

working on a fix

Just tested the update you pushed and it worked perfectly cheers.


Addition to ISSUE TEMPLATE

Here are three templates that I want to include to make it easier for contributors and maintainers to understand and address the problems or feature requests effectively. :
Bug/Issue Template: This template enables users to create well-structured issue reports by providing sections for a concise title, detailed description, steps to reproduce (if applicable), expected behavior, actual behavior, additional information, and environment details.
Feature Request Template: The feature request template allows users to outline their desired features with clarity, including sections for a clear feature description, expected benefits, and any additional context or information.
Documentation Template: This template facilitates the creation of comprehensive documentation by providing a structured format, including sections for an introduction, usage instructions, examples, and other relevant details.
Please assign this issue to me under GSSoC'23 @AshutoshDash1999

@DivyanshiNarang please go ahead