MyLocationNewOverlay direction icon movement "jumpy"

MyLocationNewOverlay is "jumpy" when driving around, see video. Is it possible to have fixed direction icon position, and move only map beneath it?
video: https://www.uschovna.cz/zasilka/KHBAT7RLDW2TA2N4-E23/
Issue Type
[x] Question
[ ] Bug
[] Improvement
[ ] Build system related
[ ] Performance
[ ] Documentation
If it's a bug, version(s) of android this affects:
All
Version of osmdroid the issue relates to:
6.1.13

You can check the sample code from the OpenStreetMapViewer demo app (available as osmdroid app on Google Play Store ; current version 6.1.14)
More Samples > Location > Directed Location Overlay:
https://github.com/osmdroid/osmdroid/blob/master/OpenStreetMapViewer/src/main/java/org/osmdroid/samplefragments/location/SampleCustomIconDirectedLocationOverlay.java
Try using the demo app to determine if you still experience jumpy location issues.


Two top level (Span, HTML) with Vaadin 23

Hi,
since we upgrade to Vaadin23 we face an issue while exporting the grid.
java.lang.IllegalArgumentException: HTML must contain exactly one top level element (ignoring text nodes). Found 2 elements with the tag names span, html
	at com.vaadin.flow.component.Html.setOuterHtml(Html.java:128)
	at com.vaadin.flow.component.Html.<init>(Html.java:113)
	at org.vaadin.reports.PrintPreviewReport.setItems(PrintPreviewReport.java:126)
	at org.vaadin.reports.PrintPreviewReport.getStreamResource(PrintPreviewReport.java:149)
	at org.vaadin.reports.PrintPreviewReport.getStreamResource(PrintPreviewReport.java:144)

It's seems to be on line 126 when you create a Vaadin HTML element. The parser behind the HTML element create more than one HTML tag.
I'm not sure if it's your addon or the Vaadin HTML component that has change. But now the export fail each time.
Can I have your please.
Best regards

I've replace the line 126 by:
Html htmlContent = new Html(Jsoup.parse(outputStream.toString(StandardCharsets.UTF_8.name())).body().html());

I'm not sure if it's working for all cases but now the export work again.

Thanks, @WilliamFreau for figuring this out. Maybe you can create a PR that might be merged by @alejandro-du?

Hello may i ask exxactly how u fixed your problem , my code is like this and i get the same error :
@Route(value = "/Rapport" , layout = MainLayout.class)
@PageTitle("Rapport")
public class Rapport extends VerticalLayout {
    private VenteService venteService;
    public Rapport(VenteService venteService) {
        this.venteService = venteService;
        PrintPreviewReport<Vente> rapport = new PrintPreviewReport<>(Vente.class);
        rapport.setItems(venteService.getFilteredVentesAll("All"));
        add(rapport);
    }
}

Please feel free to reopen and provide additional information if you are still facing this issue.


Show note text content

This PR allows user to define optional note text shown on the note view.

@aure @wtholliday please review thanks

If you want to resolve the conflicts, I'll merge this.

If you want to resolve the conflicts, I'll merge this.

@aure conflicts resolved.


[Quarkus 3.0.0.CR1] CXF SOAP integration test failures

Something must have changed in Quarkus JAXB because all of the CXF SOAP tests fail with similar Two classes have the same XML type issues like this:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
        [error]: Build step io.quarkus.jaxb.deployment.JaxbProcessor#setupJaxbContextConfig threw an exception: java.lang.IllegalStateException: Failed to configure JAXB context
        at io.quarkus.jaxb.deployment.JaxbProcessor.validateContext(JaxbProcessor.java:392)
        at io.quarkus.jaxb.deployment.JaxbProcessor.setupJaxbContextConfig(JaxbProcessor.java:317)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
        at io.quarkus.builder.BuildContext.run(BuildContext.java:282)
        at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
        at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
        at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
        at java.base/java.lang.Thread.run(Thread.java:833)
        at org.jboss.threads.JBossThread.run(JBossThread.java:501)
Caused by: org.glassfish.jaxb.runtime.v2.runtime.IllegalAnnotationsException: 47 counts of IllegalAnnotationExceptions
Two classes have the same XML type name "{http://www.w3.org/2000/09/xmldsig#}ObjectType". Use @XmlType.name and @XmlType.namespace to assign different names to them.
        this problem is related to the following location:
                at org.apache.cxf.ws.security.sts.provider.model.xmldsig.ObjectType
        this problem is related to the following location:
                at org.apache.xml.security.binding.xmldsig.ObjectType
                at public jakarta.xml.bind.JAXBElement org.apache.xml.security.binding.xmldsig.ObjectFactory.createObject(org.apache.xml.security.binding.xmldsig.ObjectType)
                at org.apache.xml.security.binding.xmldsig.ObjectFactory
                at protected java.util.List org.apache.xml.security.binding.xmldsig.TransformType.content
                at org.apache.xml.security.binding.xmldsig.TransformType
                at protected java.util.List org.apache.xml.security.binding.xmlenc.TransformsType.transform
                at org.apache.xml.security.binding.xmlenc.TransformsType
                at public org.apache.xml.security.binding.xmlenc.TransformsType org.apache.xml.security.binding.xmlenc.ObjectFactory.createTransformsType()
                at org.apache.xml.security.binding.xmlenc.ObjectFactory

It looks like CXF 4 does not depend on santuario:xmlsec anymore. So quarkus-cxf should also stop depending on Qverse xmlsec. This is surely reproducible also in Qverse CXF.

Blocked by https://github.com/quarkiverse/quarkus-cxf/issues/730

It looks like CXF 4 does not depend on santuario:xmlsec anymore. So quarkus-cxf should also stop depending on Qverse xmlsec.

No, this is not true. The santuario:xmlsec dependecy is still there, although now it is transitive.

Just a heads up - in order to upgrade to Quarkus 3.0.0.Alpha5, I had to disable the cxf-soap test bits in https://github.com/apache/camel-quarkus/commit/c8a4adb958733134031323dc668bc37ef5c244f6.


User email in admin panel

Hi, The user e-mail field in the admin panel are with type password....

hi, thanks for the report. will be fixed on next update

Hi @raisiqueira, this fix is already done. Download the master branch with the security fixs improvement.

Tanks! :dancers:


(fuzzer) - should the parser allow constructors in parentheses within if condition and for range?

Aim
Tried to parse the following code:
fn foo() {
  let x = Bar  { baz : 1 };
  if (Bar { baz: 1 } == Bar { baz: 2 }) {
    // do something
  }
}

Expected Behavior
I know that constructors appearing directly after if and for ... in are disallowed, but I expected the code to parse and compile OK because the constructors are surrounded by parentheses.
Bug
Got parse error Expected an expression but found {.
This behavior is inconsistent with Rust lang, which allows the code to compile. Also, it does not quite make sense to disallow such syntax.
Most likely reason for the bug is the second argument to expression_with_precedence called from expression_no_constructors:
fn expression_no_constructors() -> impl ExprParser {
    recursive(|expr| {
        expression_with_precedence(Precedence::Lowest, expr.clone(), expr, false, false)
    })
    .labelled(ParsingRuleLabel::Expression)
}

Installation Method
Compiled from source
Additional Context
Found by the parser-fuzzer tool.
Would you like to submit a PR for this Issue?
Yes, possible

Seems important because formal grammar is much tougher with two kinds of expression, allowing constructors or not.

I have code that may fix this.

Yes, we should allow it. It was an oversight that it was not already allowed.


hadoop rollup not perfect

we are running hadoop batch task on druid 0.10 via emr hadoop 2.7.3
Used the following dimensions to process the data:
verb ,actor.type,actor.guest,actor.gender,actor.ab_segment
Querying the row_count
curl -X POST 'prod-druid-broker-1:8082/druid/v2?pretty' -H 'Content-Type:application/json' -d '{"queryType":"timeseries","dataSource":"raw_events","granularity":"day","descending":"true","aggregations":[{"type":"count","name":"sample_name1"}],"intervals":["2017-05-30T00:00:00.000/2017-06-02T00:00:00.000"]}'
[ {
  "timestamp" : "2017-06-01T00:00:00.000Z",
  "result" : {
    "sample_name1" : 32125
  }
} ]

But the counts on raw_data is much lower 26806[
select count(*) from (
select verb ,actor.type,actor.guest,actor.gender,actor.ab_segment
group by verb ,actor.type,actor.guest,actor.gender,actor.ab_segment
)

Discussion from :
https://groups.google.com/d/msgid/druid-user/50516391-db64-4154-ab91-679922282cf9%40googlegroups.com?utm_medium=email&utm_source=footer

What do you get if you do the Druid SQL query:
select * from raw_events where __time >= timestamp '2017-05-30 00:00:00' and __time < timestamp '2017-06-02 00:00:00'
Do you see two different rows that should have rolled up together?
It's possible that you are missing the time factor (maybe you need to add a time component to your groupby query on raw_data that you're using to verify).

we did add the time rolled up to earliest 15th minute within the group by clause. Will take a dump of 32k rows and come back with few examples

sorry about it. It does seem that pre-processing the data on my end was blowing it up.


Print only non-default parameters in testing.backend.BackendConfig

To more easily figure out the configuration.

It was pointed out that if a default parameter that is significant for a test is explicitly given, this PR won't print that parameter. We may distinguish explicit parameters, but I don't have a strong motivation to implement it for now. So I'm closing the issue.


Finding data in Exchange mailboxes

Within this article, it states: "At this time these cannot be used to find data in Exchange mailboxes at rest."  Is this really true, as this article seems to suggest that this is possible?
https://docs.microsoft.com/en-us/microsoft-365/compliance/manage-gdpr-data-subject-requests-with-the-dsr-case-tool
Quote from the attached article: "Any user mailbox in your organization. This includes Skype for Business conversations and one-to-one chats in Microsoft Teams"
Can this be reviewed please?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6fae7253-e256-9879-1b3c-c8e335d73db2
Version Independent ID: a4a671cc-95d0-bcaa-d3b5-579e5bea4e1f
Content: Search for and find personal data
Content Source: microsoft-365/compliance/search-for-and-find-personal-data.md
Service: o365-seccomp
GitHub Login: @BrendaCarter
Microsoft Alias: bcarter

@robm82  - Thank you for submitting feedback.
I will get this issue over to the Microsoft 365 writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@robm82 - From our understanding, the issue has been resolved based on this merged commit https://github.com/MicrosoftDocs/microsoft-365-docs/commit/9a71936.
Thank you for your contribution to make the docs better! Much appreciated!


Save the image to databas

I'm trying to use this as a file upload to send the cropped image to the file server and add the filename to database with CodeIgniter.
How do you send the cropped image with the input field?

+1


kallisto: Add updateScript

Description of changes
Adds a passthru.updateScript so that @r-ryantm will automatically open version update PRs.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

CC @arcadio

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/2082

seems r-ryantm was updating the package before anyway, but no harm in explicitly specifying the updateScript 👍


[Fix] [Breaking change] Remove url variable source

This PR removes the url variable source and removes the SDK method setSource in the variable controller.

All variable image assets are going through a media-url embedded connector.
MediaConnectorImageVariableSource is renamed ConnectorImageVariableSource.
UrlImageVariableSource and ImageVariableSourceType are removed.
SDK methods have not changed but the types have (setSource is removed).

Related tickets

https://chilipublishintranet.atlassian.net/browse/EDT-991

Can be tested against https://studio.chiligrafx-dev.com/?workspace=latest&engine=314

Any news on this one?

@abdelhalimkhouas had some concerns about WRS getting broken after this merge, the breakage should be handled by
https://chilipublishintranet.atlassian.net/browse/WRS-1262 https://chilipublishintranet.atlassian.net/browse/WRS-1263
Technically, yes, WRS might break when we are manipulating variable w/ connector sources as connectorId is hardcoded to grafx-media on WRS. Some issues may be handled "ok" w/ some unexpected states but I wouldn't count on this.
I'll let the team handle the merge (as I'm going on holiday).

@pkgacek  We wanted to make sure these two are ready first, just to avoid any potential issues.

I added an export of VariableType and adjusted the ImageFrame to the new naming, further cleanup of types and enums in the SDK should happen f.e ImageFrameConnectorSource and ImageSourceTypeEnum


[HOPS-1150] Problems in Users&Groups cache invalidation leads to perm…

…ission denied exception when a user belongs to multiple groups
Make sure there is no duplicate PR for this issue

Please check if the PR fulfills these requirements

[x] Tests for the changes have been added and passed (for bug fixes / features)
[x] HOPS JIRA issue has been opened for this PR
[x] All commits have been squashed down to a single commit
[x] The commit message has the following format: [HOPS-XXX] message

Post a link to the associated JIRA issue
https://hopshadoop.atlassian.net/browse/HOPS-1150

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bug fix

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
Tests are passing on my jenkins
https://bbc1.sics.se/jenkins/view/salman/job/hops-salman/16/

Can one of the admins verify this patch?

Jenkins test this please.


[FEATURE] More lyrics alignment options

It would be nice to have flags for different alignment options.
Maybe centering would be enough, I don't think that anyone would want to use right alignment.

Indeed, alignment options would be interesting. However, I think it's out of scope for a cli program, because then we would need to be calculating terminal width and what not to decide on how to center it evenly. I think it's more appropriate for the GUI (which iirc has slightly better alignment already).
https://github.com/SwagLyrics/SwagLyricsGUI


(LSL) update to SL server v<IP_ADDRESS>2072

Compare http://wiki.secondlife.com/wiki/Release_Notes/Second_Life_Server/16#<IP_ADDRESS>2072

/cc @codeviolet

Merged, thanks.

Do you know why it was stuck?  It looks like it was waiting for something else to happen but it didn't show any hold ups int he UI?  Or else I would have merged it myself.

I think it's because it was a very old PR. Something has changed in gitlab statuses since then.
I'd prefer to open a new PR for something more complex, but this one was straight and plain, so I just merged it.

Yeah, I've been trying to close out easy wins that are easily reviewed.  Get our PR queue down to noting but grammars and then figure out that problem. :-)


Re-order settings in package.json alphabetically

Having the settings in alphabetical order makes it easier to scan through the list when looking for a setting.

can this task be assigned to me?

Hi @TheAfroOfDoom! Thanks for your interested in contributing to our repo 🥳
We're participating on Grace Hopper's Open Source Day this year, happening on September 16th, and we created a lot of "good first issues" across several of our Python extensions repos for first time contributors who are participating on the event that day. If no one shows interest in tackling this issue until the end of the event, we would love to have your contribution in case you're still up for it!
I'm tagging issues that we were hoping to take to Open Source Day with the "ghc-osd" tag to mark them as "reserved" until the day of the event. When it's over, we'll remove the tags from issues like this 😊

@luabud Can I please be assigned to this issue?

@luabud can you assign this to me as part of Grace Hopper's Open Source Day?

Sorry folks! I assigned it to @MarissaMunilall as she commented first

Just to make it clearer, this is about sorting the whole blocks under the properties field, based on the strings after "isort.":

No need to sort the items between those blocks 😊


Update libraries.md

Appended directory to the console script that adds project references to AwesomeLibrary.Core.csproj

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@kscelfo Thanks again for helping correct these. :shipit:


NDP should be enhanced with Security, RFC 3971

The Zephyr IP stack shall support Secure Neighbor Discovery for IPv6 as specified in RFC 3971. This is an extension to the existing Neighbor Discovery Protocol supported by the Zephyr IP stack.

Seems like SeND is almost dead, so maybe this is not a good fit. Any alternatives making NDP more secure?


Might be better to slightly change the Citation format

Just this it might be better. (From d2l.ai).
In papers this format is more used.

Either is OK. Issue closed.


Project fails to run in 4.0.2

I'm unsure of if there are further errors hidden behind the ones that are logged, but I don't know how to fix the existing ones myself to check.
Log:

Godot Engine v4.0.2.stable.official.7a0977ce2 - https://godotengine.org
Vulkan API 1.3.224 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 3060 Ti
USER WARNING: res://Player/Grenade.tscn:4 - ext_resource, invalid UID: uid://d5jny5gc8ntg - using text path instead: res://Player/GrenadeVisuals/grenade/grenade.tscn
at: load (scene/resources/resource_format_text.cpp:448)
--Main Shader--
1 | shader_type spatial;
2 |
3 | uniform vec3 shallow_color : source_color;
4 | uniform vec3 deep_color : source_color;
5 | uniform vec3 foam_color : source_color;
6 | uniform float water_scale = 1.0;
7 | uniform float time_scale = 100.0;
8 | uniform sampler2D noise_sampler : hint_normal;
9 | uniform sampler2D small_waves_sampler : hint_normal;
10 |
11 | uniform sampler2D foam_noise : hint_normal;
12 |
13 |
14 | float fresnel(vec3 normal, vec3 view, float intensity){
15 |  return pow(1.0 - clamp(dot(normal, view), 0.0, 1.0), intensity);
16 | }
17 |
18 | void fragment() {
19 |
20 |
21 |  vec2 scaled_uv = UV * water_scale;
22 |  float scaled_time = TIME / time_scale;
23 |
24 |
E  25->  float _log_depth = textureLod(DEPTH_TEXTURE, SCREEN_UV, 0.0).x;
26 |  vec3 _depth_ndc = vec3(SCREEN_UV * 2.0 - 1.0, _log_depth);
27 |  vec4 _depth_view = INV_PROJECTION_MATRIX * vec4(_depth_ndc, 1.0);
28 |  _depth_view.xyz /= _depth_view.w;
29 |  float linear_depth = -_depth_view.z;
30 |
31 |  float depth = VERTEX.z + linear_depth;
32 |  depth *= 0.2;
33 |  depth = clamp(depth, 0.0, 1.0);
34 |
35 |  float foam_n = texture(foam_noise, scaled_uv + scaled_time).x;
36 |
37 |  float foam_mask = smoothstep(0.0, 0.5 * foam_n, depth);
38 |
39 |  vec3 screen_color = texture(SCREEN_TEXTURE, SCREEN_UV).rgb;
40 |
41 |  vec3 screen_color_depth = mix(screen_color * shallow_color, deep_color, depth);
42 |
43 |  vec3 water_color = mix(screen_color_depth, deep_color, fresnel(NORMAL, VIEW, 2.0));
44 |
45 |  ALBEDO = mix(foam_color, water_color, foam_mask);
46 |  ROUGHNESS = 0.02;
47 |  SPECULAR = 1.0;
48 |
49 |
50 |  vec3 normal_map = texture(noise_sampler, scaled_uv + scaled_time).rgb;
51 |  vec3 small_waves = texture(small_waves_sampler, scaled_uv - scaled_time).rgb;
52 |
53 |  NORMAL_MAP = mix(normal_map, small_waves, 0.5);
54 |  NORMAL_MAP_DEPTH = 0.25;
55 | }
56 |
USER SHADER ERROR: DEPTH_TEXTURE has been removed in favor of using hint_depth_texture with a uniform.
To continue with minimal code changes add 'uniform sampler2D DEPTH_TEXTURE : hint_depth_texture, filter_linear_mipmap;' near the top of your shader.
at: (null) (:25)
USER ERROR: Shader compilation failed.
at: set_code (servers/rendering/renderer_rd/forward_clustered/scene_shader_forward_clustered.cpp:137)
USER ERROR: Condition "!version" is true. Returning: RID()
at: version_get_shader (./servers/rendering/renderer_rd/shader_rd.h:140)

You just need to do what the error said, then it will work, so add to the top of your shader:
uniform sampler2D DEPTH_TEXTURE : hint_depth_texture, filter_linear_mipmap;
uniform sampler2D SCENE_TEXTURE : hint_scene_texture, filter_linear_mipmap;

This was already fixed by https://github.com/gdquest-demos/godot-4-3d-third-person-controller/pull/13, closing


Adds support for multiple documents in a YAML file and encrypted_regex options

This PR adds two new features to the pre-commit hook.  Both primarily designed to make the hook work better in a kubernetes/flux workflow, but also helpful in other contexts like ansible playbooks.
First it allows multiple documents using an option matching the one used in the check_yaml hook provided by the upstream project relevant PR I tried to match their patterning as well as possible and make as few changes to the underlying code of this project as possible, but it may be better to do something like always using the _load_all() function and simply error out if there is more than one doc and the -m flag was not passed (or assume that multiple docs are fine and allow users to perform that type of check using the check_yaml hook itself).  I'm happy to make those changes if you'd like me to. fixes #12
Second it adds support for sops encrypted_regex option, which limits the actual fields sops encrypts to only ones the user expects/intends to contain secrets.  This change looks for the encrypted_regex key within the sops configuration and uses it if available, if not, it uses \S to match any valid string (and so all keys). I omitted a flag for this one since the behavior remains unchanged for any file that does not include the encrypted-regex key, and any file that does specify it will always fail without this additional filtering, but I'm happy to add a flag if you feel that being explicit here is better, just let me know if you'd like to see that or any other changes before the commit.  fixes #13

Somehow I never got notified of this :( I will take a look at this shortly. Apologies, @mgaruccio and thank you for your patience & contribution.

was just looking if this feature is supported and then i found this open PR
would be really nice so this merged :)


Update imports on file move rewrites ./index to '.'

From https://github.com/Microsoft/vscode/issues/54981#issuecomment-408448682

TypeScript Version:  3.1.0-dev.20180726

Search Terms:

update imports
getEditsForFileRename

Code
For a project
index.ts
export const foo = 123

foo.ts
import { foo } from './index';

In VScode, Rename foo.ts to bar.ts
Confirm that you want to update import paths

Expected behavior:
No edits returned from getEditsForFileRename
Actual behavior:
An edit is returned that rewrites foo.ts to:
import { foo } from '.';

We could add this as a new UserPreferences property: readonly importIndexPreference: "omitIndex" | "includeIndex";.

What should the default be?

My expectation as a user is that we don't touch the import in this case. If it's './index' leave it as './index' and if its '.' leave it as '.'

@andy-ms @mhegazy I think it should be: readonly importIndexPreference: "omitIndex" | "includeIndex" | "noChange";
where "noChange" is the default. Then users could opt in to always or never include index, but the default is to not change existing imports.


New conditional C Scanner; Improvements for virtual C Pre-Processor

Hi all!
I've finally found a time to make a PR with conditional C Scanner which we use 2 years in production for @PlatformIO. This PR is continue of a work on https://bitbucket.org/scons/scons/pull-requests/380/improvements-for-scons-c-c-pre-processor/diff
I made it maximum compatible with existing API, I even didn't touch original tests. The only incoming data for tests were extended to show that new changes don't break previous behaviour and provide a new conditional C Scanner.
Documentation? This is very complex question for me. I didn't check this item in a list below because I don't know where these changes should be reflected in documentation.
A default classic C Scanner is hardocded here. Should we make additional option for SCons command which will allow to switch between Scanners?
Nevertheless, new conditional Scanner is a good addition for developers who create an own high level wrapper around SCons. We do this in PlatformIO and use CConditionalScanner to build a library dependency tree before calling SCons builder.
I'm ready for any corrections and any comments are welcome.
Changes

New conditional C Scanner (SCons.Scanner.C.CConditionalScanner())
which interprets C/C Preprocessor conditional syntax (#ifdef, #if, #else,
#elif, #define, etc.)
Improvements for virtual C Pre-Processor:

Handle UNSIGNED LONG and LONG numeric constants in DEC (keep support for HEX)
Skip unrecognized directives, such as #if( defined ...)
Ignore #include DYNAMIC_INCLUDE directive that depends on a dynamic
macro which is not located in a state TABLE.
Cleanup CPP expressions before evaluating (strip comments, carriage returns)

Contributor Checklist:

[x] I have created a new test or updated the unit tests to cover the new/changed functionality.
[x] I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
[ ] I have updated the appropriate documentation

I'd love to merge this in as an optional scanner.
If I'm reading it correctly you've modified the existing scanner.
Given the depth of the change we'd minimally have to go through a deprecation cycle and do some evaluation of the performance vs existing scanner.
If you can change this to be a second optional C/C++ scanner. Then I can merge it.

Thanks!

I've just pushed new changes to our @PlatformIO branch, now you will see only real modified files
Yes, you are right, we created a separate scanner named CConditionalScanner
"Given the depth ". Do you mean C-Preprocessor? The default value for depth is -1 which is the same which we have now in the master branch of the preprocessor. So, existing projects should not be affected.

@ivankravets  - no, by depth I mean how that changing the C/C++ scanner is a nontrivial change.
So if I merge this it will or will not modify the existing C/C++ scanner?
#2 looks like your answering the inverse of the question I asked.

I didn't touch original CScanner. You can compare 2 files:

https://github.com/SCons/scons/blob/master/src/engine/SCons/Scanner/C.py#L111
https://github.com/platformio/scons/blob/c-conditional-scanner/src/engine/SCons/Scanner/C.py#L138

If someone would like to use a new scanner, he needs def CConditionalScanner():.

I've just isolated CConditionalScanner from an original scanner. Indeed, there is a bug in SConsCPPScanner.find_include_file which does not resolve correctly includes in " quotes which should be found based on the self.current_file directory.
I don't know if it is good if SConsCPPScanner will return the correct found items. Do you mean that it can break existing projects?

I'd rather you break that out into a separate pull request.
Is there an existing github issue  for that?
Please separate that out to another PR, then it'll be easier to merge this and then take a look at that issue separately.?

I already separated, see https://github.com/SCons/scons/blob/fe2680ddd07a4bc7c6064e7193f4979060e178ba/src/engine/SCons/Scanner/C.py#L128

You have both changes in this PR right? I'm asking if you can split them into a separate PR for the new scanner and one for the fix to the existing.

No, I reverted back all my changes to the original scanner and duplicated it with modifications for the conditional preprocessor.

I added a comment block

Can you hop on discord  #devel channel?

Sorry for my confusion on this PR.
It is as you said.
Also did some perf testing and no diff.
Merging.

@bdbaddog Thanks for the merge!!! I'm so proud of this contribution!

Can you hop on discord #devel channel?

Sorry, it looks like I missed this comment :((((

Just a little curious... test/CPPDEFINES/scan.py emits a line

Scanner evaluation of CPP lines not yet supported; skipping test.

Do these changes affect that decision in any way?

This commit should not affest test/CPPDEFINES/scan.py because it does not use conditional scanner. Maybe I don't know something :( How to debug this case?

No, I didn't mean you broke it; it's been this way (intentionally skipped) for a while. I wondered if enough scanning is available now that it could maybe be enabled for this scanner?

Yes, it makes sense. There are some examples in src/engine/SCons/cppTests.py
We have been using it for ~4 years in production. Maybe our use case will help someone https://github.com/platformio/platformio-core/blob/develop/platformio/builder/tools/piolib.py#L97
In @PlatformIO we thing called "Library Dependency Finder. So, thanks to the SCons and this Conditional Scanner, we actually automatically resolve all dependencies based on #include directives and build static libraries on-the-fly. Developers just install libraries from our registry and later just use #include <include/MyLib.h>, we do the rest of the work in auto mode.


↔ [Converter] Add support for torch.squeeze (without dim argument) in Torch-TensorRT

torch.squeeze

Function Schema:
torch.squeeze(input) → Tensor

(Note that torch.squeeze is currently supported only if the dim argument is supplied; torch.squeeze with only the input tensor to be squeezed is not currently available).

Original PyTorch API:
torch.squeeze(input, dim=None, *, out=None) → Tensor

Relevant TensorRT Documentation:

Alternatives
Squeeze all dimensions by iterating through each dimension may work here.
Additional context
Currently only the torch.squeeze(input, dim=X) API is supported; however, it is useful to have torch.squeeze(input) which squeezes all dimensions.

Closing, as it appears latest master already supports this action.


Added Cloudhunter, improved webs_nuclei.txt , passed webs_nuclei to gf instead.

Replaced cloud_enum with Cloudhunter, since cloud_enum mostly produced garbage,
Improved url lists send to various places like nuclei, gf etc .

Code is probably not the best or cleanest feel free to improve.

I need to carefully review this PR but looks great!


Add support for greenkeeper.io

Use http://greenkeeper.io/ to manage npm dependencies.

fixed in https://github.com/linkeddata/ldnode/commit/51700053498beee7c13d7cf0c08f46204fbc093e


feat: add google-cloud-dataplex to GCB

feat: add google-cloud-optimization to GCB
feat: add google-cloud-datastream to GCB

Wait until java-dataplex, java-optimization and java-datstream has been promoted to GA and 1.0.0 released.


Add draft indicator to the channel item

Summary
Add a pencil icon in the Channel sidebar and the jump to channel sidebar when the channel has a draft. does not considers drafts in threads
Ticket Link
https://mattermost.atlassian.net/browse/MM-12049
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Added or updated unit tests (required for all new features)
[x] Has UI changes

Device Information
This PR was tested on: iOS and Android
Screenshots

@hmhealey changes made


Add NFDeployment interface to support the NF Deployment KRM function

Add an NFDeployment interface, that allows NF vendors (by implementing the interface) to create SMFDeployment-like CRDs to their own NFs and then use @aakashchan's SDK to create an NFDeployment KRM function based on his code in this PR: https://github.com/nephio-project/nephio/pull/137

/lgtm

@henderiw @s3wong @gvbalaji Please take a look into this.

I don't see this as an multivendor implementation but a generic interface across the NF types.
Btw as a convention we put all methods in _interface.go and the type definition in _types.go. I believe this is a clean convention.
I am ok with this approach

/approve

I don't see this as an multivendor implementation but a generic interface across the NF types.
Btw as a convention we put all methods in _interface.go and the type definition in _types.go. I believe this is a clean convention.
I am ok with this approach

Moved the NFDeployment interface into an _interface.go file


Wrong mouse coordinates in FunctionChart1Dist

mouseOverlay gets calculated relative to the vega chart outer box, which has margins and wider than the actual chart.

Fixed in #1613.


Bridges should take height of buildings and terrain underneath them into account

Two parts to this:

If something tall exists under the bridge, you can't build it.
If a bridge exists, you can't build a tall structure underneath it.


Why is there no "reveal" button?

display"You are still the top bidder."But i can not reveal bids, how do i do? After two days I can only get 1% ether.
This is its tender information     https://etherscan.io/enslookup?q=tickets

0xB4f1c9554b7818A6711D022Ec78ec4953c6610e9
This is the public key to apply for "yaojiang.eth"

Please open issues relating to the registrar app at ethereum/ens-registrar-dapp.


Implement issues, milestones and notes interaction

Implement issues, milestones and notes interaction.

please accept this pull request

I've tweeted the info that ai can't no longer maintain this & looking for a
new maintainer. Are you ready to be one?
22 lut 2016 10:02 "hellboy81"<EMAIL_ADDRESS>napisał(a):

please accept this pull request
—
Reply to this email directly or view it on GitHub
https://github.com/Scooletz/NGitLab/pull/9#issuecomment-187104671.

Are you ready to be one?

yes!

@hellboy81 DM me on Twitter or send an email pls to discuss this.


Incorrect service account in ClusterRoleBinding

Description:
Fixed service account in cluster role binding to point to the adot-collector service account which is created in previous steps.
Link to tracking Issue:
Testing Performed:
Created a new EKS cluster and AMP workspace with fixed yaml for collector CRD and confirmed metrics ingestion into AMP instance through AMG dashboards.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thank you @normalfaults!


Query builder tests should also make assertions about graphs

// TODO: Properly assert on graphs, also below
https://github.com/opencypher/cypher-for-apache-spark/blob/3afbaabb55d6ec808e7b181f80911e332fef8aa1/src/test/scala/org/opencypher/caps/ir/impl/CypherQueryBuilderTest.scala#L48
https://github.com/opencypher/cypher-for-apache-spark/blob/3afbaabb55d6ec808e7b181f80911e332fef8aa1/src/test/scala/org/opencypher/caps/ir/impl/CypherQueryBuilderTest.scala#L84
https://github.com/opencypher/cypher-for-apache-spark/blob/3afbaabb55d6ec808e7b181f80911e332fef8aa1/src/test/scala/org/opencypher/caps/ir/impl/CypherQueryBuilderTest.scala#L198

Obsolete.


Test commit

Codecov Report
Patch and project coverage have no change.

Comparison is base (9d006c9) 10.74% compared to head (3401d09) 10.74%.

:exclamation: Current head 3401d09 differs from pull request most recent head 54bf108. Consider uploading reports for the commit 54bf108 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage     10.74%   10.74%
  Complexity       14       14
=========================================
  Files           140      140
  Lines          2001     2001
  Branches        113      113
=========================================
  Hits            215      215
  Misses         1784     1784
  Partials          2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Testing cc-bot!

We're introducing a bot that cc potential reviewers when you submit a pull request based on the blame information.

Very cool. The thing I like about this the most is that it means contributors are responsible for their PRs.

I ran it against 50 open pull requests last week and interestingly, there's a lot of non-fb employees in the list :) https://gist.github.com/vjeux/8e58e6e6e52e7a04c877


Created API-contract for FeatureFlags

@Cartmanishere  @ankushdharkar  @ASHWINIAJIT
Created API-contract for feature flags.
Please review the PR!

@Ankita2002-Fr @swarajpure A lot of this contract is going to be changed anyway.
I would say, let's merge it as it is. I will update the correct contract after this PR is merged.
https://github.com/Real-Dev-Squad/website-backend/pull/406


can't open localhost:8080

I am not able to open localhost:8080. It shows connection timeout. I opened ./karaf installed necessary features but still its not opening. Can anyone help me with this?

OpenDaylight DLUX GUI is running on port 8181. After starting karaf (./bin/karaf and installing all features) you can open the DLUX GUI with "http://localhost:8181/index.html". Please try this URL. It should open the login screen of OpenDaylight DLUX.

Try localhost:8181
Sent from my iPhone

On Oct 27, 2016, at 9:47 AM, Herbert Eiselt<EMAIL_ADDRESS>wrote:
OpenDaylight DLUX GUI is running on port 8181. After starting karaf (./bin/karaf and installing all features) you can open the DLUX GUI with "http://localhost:8181/index.html". Please try this URL. It should open the login screen of OpenDaylight DLUX.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi Liu,
Is there any problem?
Cheers,
Martin
Von: olinchy<EMAIL_ADDRESS>Gesendet: Donnerstag, 27. Oktober 2016 11:44
An: OpenNetworkingFoundation/CENTENNIAL<EMAIL_ADDRESS>Betreff: Re: [OpenNetworkingFoundation/CENTENNIAL] can't open localhost:8080 (#11)
Try localhost:8181
Sent from my iPhone

On Oct 27, 2016, at 9:47 AM, Herbert Eiselt<EMAIL_ADDRESS><EMAIL_ADDRESS>> wrote:
OpenDaylight DLUX GUI is running on port 8181. After starting karaf (./bin/karaf and installing all features) you can open the DLUX GUI with "http://localhost:8181/index.html". Please try this URL. It should open the login screen of OpenDaylight DLUX.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/OpenNetworkingFoundation/CENTENNIAL/issues/11#issuecomment-256682333 , or mute the thread https://github.com/notifications/unsubscribe-auth/AIuxpXxenokFMwhb6nTQatHCHVAtJxrPks5q4MbPgaJpZM4KiNSu .  https://github.com/notifications/beacon/AIuxpbwOl0yfxu_dg5qZdegEhd0zWzXdks5q4MbPgaJpZM4KiNSu.gif

no problem at all
Sent from my iPhone

On Oct 27, 2016, at 11:04 PM, Martin Skorupski<EMAIL_ADDRESS>wrote:
Hi Liu,
Is there any problem?
Cheers,
Martin
Von: olinchy<EMAIL_ADDRESS>Gesendet: Donnerstag, 27. Oktober 2016 11:44
An: OpenNetworkingFoundation/CENTENNIAL<EMAIL_ADDRESS>Betreff: Re: [OpenNetworkingFoundation/CENTENNIAL] can't open localhost:8080 (#11)
Try localhost:8181
Sent from my iPhone

On Oct 27, 2016, at 9:47 AM, Herbert Eiselt<EMAIL_ADDRESS><EMAIL_ADDRESS>> wrote:
OpenDaylight DLUX GUI is running on port 8181. After starting karaf (./bin/karaf and installing all features) you can open the DLUX GUI with "http://localhost:8181/index.html". Please try this URL. It should open the login screen of OpenDaylight DLUX.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/OpenNetworkingFoundation/CENTENNIAL/issues/11#issuecomment-256682333 , or mute the thread https://github.com/notifications/unsubscribe-auth/AIuxpXxenokFMwhb6nTQatHCHVAtJxrPks5q4MbPgaJpZM4KiNSu . https://github.com/notifications/beacon/AIuxpbwOl0yfxu_dg5qZdegEhd0zWzXdks5q4MbPgaJpZM4KiNSu.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Unexpected \ in docstring

For swagger description https://github.com/Azure/azure-rest-api-specs/blob/c142d613ea72dcc1251a5d4402147f13afc01f2a/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2023-07-01/keyvault.json#L1233:

Generated SDK contains unexpected \:

Similar issue for network:

After debug, I find the root cause is related with https://github.com/Azure/autorest.python/blob/ad59817944e3a2a678b2004706abb2d5819fbb46/packages/autorest.python/autorest/m2r/init.py#L54-L59.

It is bug of package m2r2: https://github.com/CrossNox/m2r2/issues/70


Version 1.9 Not compatible with Mcreator 2024.2

The version 1.9 of the plugin is not compatible with the Mcreator 2024.2 Patch.

fixed


[4078] Withdraw trainees with DQT

Context
We aren't currently sending withdrawals to DQT. We should be.
Changes proposed in this pull request
Following the established pattern this PR adds:

Dqt::WithdrawTraineeJob - sidekiq job to queue the call DQT.
Dqt::WithdrawTrainee - service class to actually make the API call.
Dqt::Withdrawal::Params - wrapper for API params used by Dqt::WithdrawTrainee.

Guidance to review

I've tested the integration with the DQT API manually by running the Dqt::WithdrawTrainee locally against the Test DQT API to iron out any issues with the API call itself. Not sure what other manual testing we can do.
Are the tests sufficient? (Is there a way to write a better end-to-end test?)

Important business

[x] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[x] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Withdraw trainees with DQT


Change from Feather Icons to Lucide

It seems that the Feather repository is not actively maintained anymore, but there is Lucide which is a fork, with an actively maintained code base. Please consider switching to Lucide.

Thank you for pointing this out; I'm deprecating Feather and adding Lucide in 0.5.0!


[Settings] UI elements are blank

Microsoft PowerToys version
0.51.0
Running as admin

[X] Yes

Area(s) with issue?
General, Settings
Steps to reproduce
Open Settings, switch to FancyZones, scroll down

I can provide a bug report if needed.
✔ Expected Behavior
Buttons and/or windows are visible and can be interacted with.
❌ Actual Behavior
Some buttons and windows are white and cannot be interacted with.
Other Software
No response

Could you attach a full bug report file?
Right-click on the tray icon and click Report Bug. Then drag-and-drop the generated file into the GitHub comment to upload it. Thanks!

cc: @niels9001

Sur
PowerToysReport_2021-12-01-17-52-25.zip
e.

@bielej Can you share your theming settings you have configured in Windows Settings?

Relevant WinUI issue: #6344

This might be helpful:

#tranking-external?

Yeah, another instance of this.

Interesting since they are win10 too

What are everyone's GPU?

Intel UHD 630 + RTX 3070 - tried on both (using Graphics preference in Graphics settings) - same result.

Also started to face this issue after updating from version 0.51.1 to 0.53.1. I am on the Windows 10 Pro (2004) with RTX 2070 Super

Seeing the pattern I suspected. Nvidia

Seeing the pattern I suspected. Nvidia

Not sure. I haven't updated Nvidia drivers or OS version, only the Powertoys version. Reboot of windows helped to solve this issue

@dima-f1 are you running the nvidia app itself?

@crutkas What is Nvidia app?) I have only Nvidia driver installed (without Nvidia experience)

I've been affected by this issue for several months already. I first noticed it in the new updated Microsoft Store App on Windows 10, but now it also affects PowerToys and some other apps sharing the same framework/components.
AMD Ryzen CPU, Nvidia RTX 3080.

It was the nvidia driver


text should be relative to entity size

text size should update relative to the entity size.. or be controllable with an input?

or maybe just make it resizable? ["t0", "t1", "t2", ...]

this is a dead end.
we either dynamic font size:
.insert_resource(TextSettings {
            allow_dynamic_font_size: true,
            ..default()
        })

=> CPU: dies
or we have to regenerate the font atlases => RAM: dies (big.scn was 500mb)

this is whatever, will give it an info command for selected, so really tiny or really big circles can still be inspected

in your face you cute bitch 786b1dc


Provide explicit type mappings for ingested logs

While the implicit type mappings are sufficient for exploration, most more pronounced use cases imply drill down needs which almost always require wildcard based exclusions etc.

This primarily blocks progress on #2, but also impacts #4 for similar reasons.

Accordingly, these need to be enabled via explicit mappings.

:information_source: Worth noting that the need for explicit mappings has come up in pretty much all logsearch-for-* sub projects and suggests a respectively generic approach for managing those accordingly.

I've committed type mappings for the three current log types to ./src/logsearch-config/logs.


Set up scalafmt

Codecov Report

Merging #254 into master will increase coverage by 0.17%.
The diff coverage is 95.78%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7320c9...ee0b7d6. Read the comment docs.


Add color for Light blue in Circo-Pallet.svg

The light blue color in the pallet file doesn't have a hex value which makes it hard to use without inspecting the color of the SVG. Should be added in the same way as for the other colors.

Change pallet to include CMYK value for light blue with note about error for not having a hex value

Thanks!


Add images: Android Basics with Compose - Closing }

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-add-images#5
In which task and step of the codelab can this issue be found?
6
Describe the problem
Closing '}' missing on first code snippet for the GreetingText function
Additional information
fixed code snippet
@Composable fun GreetingText(message: String, from: String, modifier: Modifier = Modifier) {     // Create a column so that texts don't overlap     Column(         verticalArrangement = Arrangement.Center,         modifier = modifier     ) {         Text(             text = message,             fontSize = 100.sp,             lineHeight = 116.sp,             textAlign = TextAlign.Center         )         Text(             text = from,             fontSize = 36.sp,             modifier = Modifier                 .padding(16.dp)                 .align(alignment = Alignment.End)         )     } }

Hi @johnshea
Thank you for bringing this to our attention.
The lesson content has been updated and will be republished again in the near future with this fix.
Hope you are enjoying the course.
Regards.


Can not export using Pop OS 22.04

You have the option to create a light and dark theme, but when you select Export, nothing happens.

I believe we've fixed the issue. v0.1.1 should be dropping on flathub soon.


Upgraded to latest parent pom and asto lib

#20 - upgraded to the latest parent pom and ASTO lib

Job gh:artipie/rpm-adapter#21 is not assigned, can't get performer

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @g4s8/z

Job gh:artipie/rpm-adapter#21 doesn't exist in WBS, can't create order

Job gh:artipie/rpm-adapter#21 doesn't exist in WBS, can't create order


Make project generation work with different locales

Fixes #17383

@bot-gradle test rFM

OK, I've already triggered ReadyForMerge build for you.


Spark support added

Verdict's query rewriting works for both Spark and PySpark.
Sample creations passed all for Spark, Impala, and Hive. Integration passed using Impala for the samples created by Spark and Impala.
Error bounds for count and distinct-count are not accurate yet. An issue is registered on GitHub repo for this.
Loading from a user configuration json file should be addressed further.

This merge is a snapshot and needs more tests for v0.3 release.


unpack脚本安装后，LSP工作有问题

method textDocument/definition is not supported by any of the servers registered for the current buffer

已经修复lsp配置问题


[5.5] Add constants for new OS versions

5.5 cherry-pick of https://github.com/apple/swift-package-manager/pull/3537

@swift-ci please test

/home/buildnode/jenkins/workspace/swift-package-manager-PR-Linux/tmp/TemporaryFile.NUmxTq.swift:5:15: error: extra arguments at positions #3, #4, #5 in call

Looks like I made a mistake while resolving conflicts during the cherry-pick.

@swift-ci please test


Public API for updating PlanHammer piece table to help Mod Compatiability

As discussed in the past, PlanBuild currently can't detect when other mods like MoreVanillaBuildPrefabs add/remove pieces in-game. Rather than requiring PlanBuild to constantly rescan pieces the idea of simply exposing the ScanPieceTables methods through a public API was proposed to mods like MoreVanillaBuildPrefabs could update PlanBuild as needed and the onus of compatibility could be placed on mods that add/remove pieces while in-game.
This PR adds a public API method to the main plugin that simply calls PlanDB.Instance.ScanPieceTables and I also rewrote the method ScanPieceTables to separate the process of creating PlanPieces and the process of managing the PlanHammer piece table. This way PlanPieces are only ever created once and pre-existing PlanPieces are left alone when rescanning piece tables but the PlanHammer piece table can still be updated.

Hey searcia,
I finally made it :) Sorry it took me so long.
Thank you for the PR, will make a new official version today.


Add installation instructions to README

Hi there!
Congrats on this library, definitely a nice addition to the ASGI ecosystem!
Proposing a small README update that adds install steps. :-) I eventually figured the package was on PyPI but I think it's not obvious when looking at the README page.

Or there is any way to do it automatically when installing from pypi?

Yes, if you want I believe you can make the package depend on the git version like this:
# setup.py

setup(
    # ...
    install_requires=["brotli @ git+https://github.com/google/brotli/@master#egg=brotli"],
)

For the purpose of this PR I added the pip install instructions, they can be updated if you decide to go for "ship with brotli master". :-)

Thanks for the tip. I tested both version of brotli, pypi and from github, and both works identically. So, right now, let's leave it as it is. Thanks for your PR


Ordered set lattices.

Anna-side C++ representation.
Anna-side serialization and deserialization.
Client-side python representation.
Anna C++ client interface.
Python IPC client serialization and deserialization.

@cw75  can you approve again? i had to force-push after rebasing


[VS Code] Collaboration session not found.

Error:
Collaboration session not found.
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
0.3.869

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.27.1

platformName
MacOS

platformVersion
17.7.0

Hi,
We display this message if the collaboration session is over and the guest tries to join it. It is not an error. Ask the host to start a new session and join it again.
If you see this message when the session is actually going on, then that would be a bug. If you experience that, please re-activate this issue and run the command "Live Share: Export Logs" and drag-and-drop the zip here or send it to<EMAIL_ADDRESS>


LAMG testSmallGraphs is runtime-dependent

Currently, the testSmallGraphs test for LAMG requires the solver to converge within a given time frame. Depending on the execution environment (e.g. Travis) this might lead to a failed test. Should probably be a benchmark instead.

Yes, if time is the only criterion, then adapt it to be a typical benchmark (use a larger graph then, I guess). Keep a test that is not timing-related.

For now I'm removing the timeout. If this becomes a problem in the future, we should consider setting a reasonable iteration limit.


fix: Show error on TextFormField

Closes https://github.com/lenra-io/lenra_components/issues/120
Checklist

[ ] I didn't over-scope my PR
[ ] My PR title matches the commit convention
[ ] I did not include breaking changes
[ ] I included unit tests that cover my changes
[ ] I added/updated the documentation about my changes
[ ] I made my own code-review before requesting one

Description of the changes

Technical highlight/advice

Codecov Report
Base: 71.91% // Head: 71.83% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (760c6c5) compared to base (105fbc6).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #121      +/-   ##
==========================================
- Coverage   71.91%   71.83%   -0.08%
==========================================
  Files          38       38
  Lines         908      909       +1
==========================================
  Hits          653      653
- Misses        255      256       +1

Impacted Files
Coverage Δ

lib/component/lenra_text_form_field.dart
50.00% <66.66%> (-1.29%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

:tada: This PR is included in version 1.0.0-beta.51 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


optional/optionalAt: dealing with "malformed" structures

Both optional and optionalAt currently error out if the value decoder fails, and use the fallback when either the value does not exist or is null.
The specific semantics of "does the value exist" are not totally obvious. Intuitively, I would say "the JSON object has the specified key" describes the intended semantics.
It's probably better to illustrate with an example; so lets imagine a decoder decode identity |> optional "foo" (maybe int) Nothing, and running that on a couple of inputs:

Input
Result
Expected

{ "foo": 12 }
Ok (Just 12)
✅

{ "foo": "bar" }
Err "..."
✅

{ "foo": null }
Ok Nothing
✅

{ "bar": "baz" }
Ok Nothing
✅

{}
Ok Nothing
✅

null
Ok Nothing
✅

"hello world!"
Ok Nothing
❌

The last one seems odd - the input isn't an object, so talking about the existence of a value does not make sense. The null case seems in line with the behaviour of decoding the value itself works.
Having the wrong structure in the underlying JSON value (i.e. anything but null or an object) seems like it should also be rejected. Thoughts?

@zwilias
I did some experiments with the core decoder's maybe with some undocumented examples.
http://package.elm-lang.org/packages/elm-lang/core/5.1.1/Json-Decode#maybe
json = """{ "name": "tom", "age": 42 }"""

decodeString (maybe (field "age"    int  )) json        -- Ok (Just 42)
decodeString (maybe (field "name"   int  )) json        -- Ok Nothing
decodeString (maybe (field "height" float)) json        -- Ok Nothing
decodeString (maybe (field "height" float)) "null"      -- Ok Nothing
decodeString (maybe (field "height" float)) "\"hello\"" -- Ok Nothing ------ (A)
decodeString (maybe (field "height" float)) ""          -- Err ...

decodeString (field "age"    (maybe int  )) json        -- Ok (Just 42)
decodeString (field "name"   (maybe int  )) json        -- Ok Nothing
decodeString (field "height" (maybe float)) json        -- Err ...
decodeString (field "height" (maybe float)) "null"      -- Err ...
decodeString (field "height" (maybe float)) "\"hello\"" -- Err ... --------- (B)
decodeString (field "height" (maybe float)) ""          -- Err ...

What I got to know here is that the (A) decoder does not expect the input is an object but (B) does. So If we expect optional to behave the same as (A), the result you listed above seems no problem.
(My first intuition was the same to yours, btw.)


ISPN-11525 Sending correctly the subject

https://issues.redhat.com/browse/ISPN-11525

Please add a few tests to AuthorizationLDAPIT

Please add a few tests to AuthorizationLDAPIT

Yes I want to add them, I was unsure about the corrections here. I'll go discuss in zulip

@karesti and I discussed offline, and we came to the conclusion that since the REST API is becoming larger over time, we need a strategy to avoid that security bugs keep popping up constantly:

Some utilities to create an embedded REST server with auth/authz should be created
Each resource should have a unit test with security enabled, extending the main one.
The tests should not leak to other modules and should be container in rest itself
Other kinds of auth (LDAP, OAUTH, etc) are not covered in rest or this PR, and could be added later to the server module.
We should not pollute xyzResource classes with the doAs construct by isolate the cache/cachemanager/etc decoration in the invocationHelper or RestCacheManager

Additionally, for methods which return lists of caches, it is perfectly valid for a user to be able to "see" some caches and not others. The code should skip those caches

Please see https://github.com/infinispan/infinispan/pull/8184
It enabled security for all REST resources and it reproduced problems in the Cache, CacheManager and Task Resources

@tristantarrant @gustavonalle @pruivo I'm not done here yet. I need to have a pass to the code and there are a couple of things to get fixed yet

Checkstyle failed

@gustavonalle I know haha I need to fix stuff still! :)) I ping here when the review is ready to be done again

(console look and feel is from a PR that does not affect creation, just look and feel).
with authz it does not work

I managed to make the console work, my authz configuration was not ok!

@tristantarrant @gustavonalle ready for merge ?

checkstyle errors

Ready to merge, will @tristantarrant commit go with this PR?

@gustavonalle I changed the commit message

merged into master, thanks @karesti !


Bug Report: GuapSwap CLI v1.x.x-beta

Please report here any errors you encounter, any questions you have, or any feedback you want to give. For specific bugs, consider creating a separate issue for it. Thanks.

Hello?.... Anybody out there?....
We found an issue in the beta that prevented the "execution fee per token" from being properly calculated. An integer division error essentially. It is getting fixed asap right now. We will update the beta release accordingly.

Please update to v1.0.1-beta

I realized I forgot to announce the updated version in here to. I will do this from now on as well. So, roughly two months late, please update to v1.1.1-beta.
Furthermore, there is a bug that prevents payouts from being swapped if the cumulative ERG value in the proxy contracts is above ~ 2ERG. So, please use less than 2 ERGs for swapping payouts. Otherwise, refund option will still work. If we changed the contract then everyone would need to generate a new proxy addresse, so since this bug is not critical or dangerous, we will not be fixing it. We decided to focus on v2 of GuapSwap CLI since this is a higher priority (time resources) that will also greatly increase functionality compared to now. We follow the Semantic Versioning guide for software, so we only increase the version number if there are backward-incompatible changes made (e.g. a smart-contract is modified that requires a new proxy address to be generated).
Since this is still technically a beta/mvp, please only use small amounts of ERG anyway, it isn't meant for large amounts of people to be using it. As always, let us know of any other issues you may have encountered.
Thanks


Add readme for frost-radio-button/group

Closed via: https://github.com/ciena-frost/ember-frost-core/pull/267


Get weather data from openweather

Based on location of the detectors and timestamp
wind direction
wind speed
humidity
pressure

Done by @wtvisser and Angus. Incorporated into the training data set. I'll create the followup.


Add Nick and George as maintainers

I propose to add @nicksneo and @gtebrean as Besu project maintainers. In addition to quality code contributions, they have been contributing to Besu community via contributing to discussions in Discord.
Nick has made a number of code contributions including -

show correct revert reason data in priv_call
removed GoQuorum permissioning interop
migrated several packages from Junit4 to Junit5

Nick’s PRs: https://github.com/hyperledger/besu/pulls?q=is%3Apr+is%3Aclosed+author%3ANickSneo
George has made a number of code contributions including -

bugfix in eth_feeHistory
decoupled JsonRPCError enum from the data field
made pretty JSON feature user-configurable

George's PRs: https://github.com/hyperledger/besu/pulls?q=is%3Apr+is%3Aclosed+author%3Agtebrean
Voting ends two weeks from today.
For more information on this process see the Becoming a Maintainer section in the MAINTAINERS.md file.

I am willing to be convinced otherwise, but since we only require one ✅ to merge a PR to main, I'd like to see examples of more substantive commits before :+1:
Also, shouldn't we split these into two separate PRs since we are effectively voting on the addition of 2 different maintainers?

I completely agree with Gary. I would also like to see more contributions before giving my approval. On the second point, I also agree with Gary that we should create two separate pull requests, one for each contributor.

Agree that there should be a separate PR for each proposed maintainer

will close this in favour of separate PRs for individual maintainers


feat(operators): add average and sum operators

average operator returns the average of values emitted by an Observable. Nested values can be accessed with a predicate function. sum operator returns the sum of values emitted by an Observable. Nested values cam be accessed with a predicate function. Both operators already exist in other ReactiveX libraries.

Description:
Related issue (if exists):

before any other code changes, why this PR have huge changes in package-lock without any package changes?

Honestly I didn’t see that the package-lock came in with it. I ran npm install to run the tests and it must’ve updated package-lock. I can close and submit another pull request if that’s easiest.

you don't need to create new PR, just delete it and can force push commit.

A few things before this PR continues.
Both of these proposed operators will only function on Observable<number>, presumably? I didn't see any actual code files here. Honestly, this could be done just as easily with a third party library of reducer functions that weren't RxJS specific:  source$.pipe(reduce(sum)) for example.
Given that it's specific to Observable<number>, it's trivial to implement, and it might be better off in a more utilitarian library of common reducer functions, I'm not sure this is a worthy inclusion to RxJS core.
I'm interested in what my peers think, though. @kwonoj? @david-driscoll? @cartant?

I noticed that the operator and spec files didn’t transfer over. I’ll add those as soon as I get back to my computer. You’re right that they’re mostly for Observable<number> but they can also take a predicate function. I wrote the operators separately then noticed they were in RxJava and RxPHP but not RxJS. No worries if you don’t want to have them in core. I was just reading the docs and noticed a hole that I had already filled.

I admit I'm not in great favor of adding new one in general.

noticed they were in RxJava and RxPHP but not RxJS

This is obvious case I mentioned time to time, we don't carry over operator 1:1 between different language bindings.
Other judgement call I usually use are

How hard will it be if chain existing operator? Is it impossible / too verbose?
How hard will it be if new operator serves as user land module? any dependency to core implementation requires new operator should be in core?

Given that average and sum were removed in the port from RxJS v4 to v5 my question is: what's changed that would warrant their being reinstated?
I'm not in favour of the reinstatement. I don't think anyone who needs to average or sum a stream of numbers would be hard pressed to implement the calculation.
Also, if they are to be merged, there is an implementation problem in average - there is internal state within the reducer that's not per-subscription.

Ah I didn’t see any references in this repo to them ever being in the library so didn’t realize they had been removed. Sorry about that. I can close if everyone is opposed to bringing them back or leave it open if you’d like to discuss it further.

@jafaircl I think that would be best.  We haven't had much demand for this, and it's something that individuals can hand-roll pretty easily.

Thank you so much, @jafaircl, for your thoughtful contribution! I hope that the closing of this PR doesn't put you off from contributing again!


feat(kube): add schema validation

Adds validation against the swagger schema.
Example error:
Error: release telling-wildebeest failed: error validating "": error
validating data: expected type int, for field
spec.template.spec.containers[0].ports[0].containerPort, got string

The current error message would resemble:
unable to decode "": [pos 177]: json: expect char '"' but got char 'n'"'

This change is

\o/ Is this also used when doing --dry-run?
I would find it super awesome if even `helm lint' would already do validations against the swagger schema.

I am working on another patch that will support schema validation on --dry-run.  I'll check out adding lint too.


Multiple API versions

We are looking at a solution to rebuild our documentation. At the moment we have a simple node.js application that renders markdown. However, we are working on the v2 of our API and we'll need to add versioning to our documentation.
Is there a way with Slate to generate documentation for multiple versions? Like having a dropdown somewhere that allows to swap from v1.0 to v2.0.
If there is not a native way to do it, are you aware of any forks that added this feature?

Charles,
There are a couple of ways to solve this problem.  If you reach out to me at<EMAIL_ADDRESS>we can discuss how we did to solve the problem and what we like about the approach we took.
Paul
PAUL S NERGER
<EMAIL_ADDRESS>This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this message which arise as a result of e-mail transmission. If verification is required please request a hard-copy version.

On Mar 15, 2016, at 2:02 PM, Charles Ouellet<EMAIL_ADDRESS>wrote:
We are looking at a solution to rebuild our documentation. At the moment we have a simple node.js application that renders markdown. However, we are working on the v2 of our API and we'll need to add versioning to our documentation.
Is there a way with Slate to generate documentation for multiple versions? Like having a dropdown somewhere that allows to swap from v1.0 to v2.0.
If there is not a native way to do it, are you aware of any forks that added this feature?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub https://github.com/tripit/slate/issues/479

There's already a discussion for this feature in #138, feel free to chat about it there!

Hello,
Is there any news on this?
Thanks
Miguel

Any news on this?


Provide a Simple and Native Certificate Management Solution

While https://github.com/envoyproxy/gateway/issues/81 identifies the need for a production-quality certificate management solution, EG should support native cert management for simple, non-prod use cases.

I'd suggest looking at lego

I'm closing this issue since a simple self-signed CA-based solution was implemented in https://github.com/envoyproxy/gateway/pull/208. A more comprehensive solution will be implemented to resolve https://github.com/envoyproxy/gateway/issues/81.


ERROR: The Compose file './docker-compose.yml' is invalid because:Unsupported config option for services.mysql: 'platform'

Question
when i setup,  i meet flow issue:
ERROR: The Compose file './docker-compose.yml' is invalid because:
Unsupported config option for services.mysql: 'platform'
Screenshots
$ cat ./docker-compose.yml
version: "3"
services:
mysql:
image: mysql:8.0.26
platform: linux/x86_64
volumes:
- mysql-storage:/var/lib/mysql
restart: always
ports:
- <IP_ADDRESS>:3306:3306
environment:
MYSQL_ROOT_PASSWORD: admin
MYSQL_DATABASE: lake
MYSQL_USER: merico
MYSQL_PASSWORD: merico
grafana:
image: grafana/grafana:8.0.6
ports:
- 3002:3000
volumes:
- grafana-storage:/var/lib/grafana
- ./grafana/provisioning:/etc/grafana/provisioning
- ./grafana/dashboards:/etc/grafana/dashboards
- ./grafana/img/grafana_icon.svg:/usr/share/grafana/public/img/grafana_icon.svg:rw
- ./grafana/img:/usr/share/grafana/public/img/lake:ro
environment:
- GF_USERS_ALLOW_SIGN_UP=false
- GF_DASHBOARDS_JSON_ENABLED=true
- GF_INSTALL_PLUGINS=grafana-piechart-panel
- GF_LIVE_ALLOWED_ORIGINS=*
restart: always
depends_on:
- mysql
devlake:
image: mericodev/lake:0.3.0
ports:
- <IP_ADDRESS>:8080:8080
env_file:
- ./.env
restart: always
depends_on:
- grafana
config-ui:
image: mericodev/config-ui:0.3.0
ports:
- <IP_ADDRESS>:4000:4000
environment:
- ENV_FILEPATH=/.env
- DEVLAKE_ENDPOINT=http://devlake:8080
- GRAFANA_PORT=3002/d/RXJZNpMnz/homepage?orgId=1
volumes:
- ./.env:/.env:rw
volumes:
mysql-storage:
grafana-storage:
Additional context
Add any other context here.

What is your docker-compose version? Try to

Upgrade docker-compose to 1.29.x
Or downgrade the version property to 2.4 in docker-compose.yml#L1

thanks :), it work

Closed this issue since the problem is fixed. Feel free to reopen it if there is any more questions about this.


Release v1.2.0

Hi there. I'd love to deploy the ~18 commits that have ben made since April. Is there anything I can do to help get v1.2.0 released?

Done 10 hours ago: https://github.com/Yelp/detect-secrets/releases/tag/v1.2.0

Thanks a bunch @jpdakran !


Replace Session Cookie for a Token

I'm using JWT tokens for access to my website's API, so when the users log in through SSO I just hand them a token.
With that, I don't use the session cookie for anything else other than to store the SSO data:

AuthNRequestID
samlUserdata
samlNameId
samlNameIdFormat
samlNameIdNameQualifier
samlNameIdSPNameQualifier
samlSessionIndex
LogoutRequestID

I was thinking of foregoing the session cookie and placing this data on the user's localStorage, and on every request and response to any SSO endpoint, receive and update that data.
Are there any security implications to this scheme? Is there a problem if the user just deletes the data mid-session (I'm guessing the only implication is the inability to complete a SLO)?
Can you offer any further thoughts on this?

Browser local storage (or session storage) is not a secure place to store sensitive information. Any data stored there:

Can be accessed through JavaScript.
May be vulnerable to cross-site scripting.

See https://dev.to/rdegges/please-stop-using-local-storage-1i04


appbar: fonticon -> iconbutton

now we get a nice ripple effect on the appbar icons.
this factory thing to get ripples going is a bit annoying. What would folks say about a slightly different effect (sacrificing the ripple origin) achieved with css only?
here is an initial thought:
http://codepen.io/hastyrobot/pen/XjmAQL

Thanks @acornejo Actually the ripple thing is a bit tricky. It should be kept until mouse up, track the origin, expand multiple times with multiple clicks... The factory is not used just for the ripple but to allow to get components with dependencies with/without styles.
For example, if you want to import a raw Button component, it should not require styles for the Ripple either and viceversa. The factory allows to inject the dependency component forgetting about styles. I know it may be annoying at first but we export injected components too so requiring the factory is optional from outside. More difficult but way more powerful too :)


[downgrade] downgrader does not convert steps.spec.ports

Example github workflow
name: service

jobs:
  test:
    runs-on: ubuntu-latest
    services:
      nginx:
        image: nginx
        # Map port 8080 on the Docker host to port 80 on the nginx container
        ports:
          - 8080:80

Default conversion
name: service
stages:
- name: test
  spec:
    platform:
      arch: amd64
      os: linux
    runtime:
      spec: {}
      type: cloud
    steps:
    - name: nginx
      spec:
        image: nginx
        ports:
        - 8080:80
      type: background
  type: ci
version: 1

Downgraded conversion
pipeline:
  identifier: default
  name: default
  orgIdentifier: default
  projectIdentifier: default
  properties:
    ci:
      codebase:
        build: <+input>
  stages:
  - stage:
      identifier: test
      name: test
      spec:
        cloneCodebase: true
        execution:
          steps:
          - step:
              identifier: nginx
              name: nginx
              spec:
                image: nginx
              timeout: ""
              type: Background
        platform:
          arch: Amd64
          os: Linux
        runtime:
          spec: {}
          type: Cloud
      type: CI

I feel this should convert to
pipeline:
  identifier: default
  name: default
  orgIdentifier: default
  projectIdentifier: default
  properties:
    ci:
      codebase:
        build: <+input>
  stages:
  - stage:
      identifier: test
      name: test
      spec:
        cloneCodebase: true
        execution:
          steps:
          - step:
              identifier: nginx
              name: nginx
              spec:
                image: nginx
                portBindings:
                  "8080": "80"
              timeout: ""
              type: Background
        platform:
          arch: Amd64
          os: Linux
        runtime:
          spec: {}
          type: Cloud
      type: CI

NOTE: portBindings requires both host and container ports, other providers support passing in a single port. In that case I think our conversion should set both host and container ports to the same value.
GitHub also supports the port protocol, for example
    ports:
      - 6379/tcp

Maybe we are safe to convert this since TCP is the default? I'm not sure what the behavior should be for UDP.

Duplicate of #86


zstack-cli can't dump primary storage environment

When use zstack-cli -D to dump current cloud environment, the primary storage fields won't be correctly dumped.

Fixed by https://github.com/zstackorg/zstack-utility/commit/58e6deb0c8b9edfa7242f1cef83d378c19883cf3


Modify EDMF filtering

Purpose
This PR changes how EDMF filtering works by making it so that we filter a copy of the state vector instead of the state vector itself. In order to prevent the state and its filtered version from diverging during each timestep, this PR also adds a relaxation tendency.
Content
After a great deal of trial and error, it has been determined that, if we split the EDMF tendency into implicit and explicit components, the state vector (Y) cannot be filtered from within the implicit component, as that somehow breaks the GMRES algorithm. Currently, the only known solution to this problem is to filter a copy of the state vector instead of the state vector itself, and to use this copy to compute the implicit component of the EDMF tendency. However, only doing this in the implicit component of the tendency will cause filtering to be inconsistent between the implicit and explicit components, which seems like a bad idea. So, before we actually split the EDMF tendency, we should modify it to use the form of filtering that will be required by the implicit component.
However, just using a filtered copy of the state vector is not sufficient, as it causes several of the examples in the pipeline (particularly anelastic BOMEx and compressible TRMM) to develop spurious updrafts near the top of the atmosphere. This is because, if the state itself is not filtered on every Runge-Kutta stage, these spurious updrafts can quickly develop over the course of a single timestep; then, even though we filter the state after every timestep through a callback, the spurious updrafts are sometimes sufficiently large to survive this filtering. The solution that seems to work best is to add a "filter relaxation tendency" of the form (filter(Y) - Y) / dt, which makes the results look nearly identical to those on the main branch. Interestingly, scaling this tendency down by a factor of a 100 also seems to work, which indicates that only a very small relaxation tendency is needed to prevent filter(Y) and Y from diverging too much before the callback at the end of each timestep realigns them. However, using a large relaxation tendency works well enough, so a scaling factor does not need to be included in the tendency.

[x] I have read and checked the items on the review checklist.

Basted on what we discussed today:

We want to merge this PR as soon as possible. So that we can start Jacobian testing.
We want to refactor the filters: (i) make sure we only have the filters we need, (ii) use regularisation instead of area fraction clipping, (iii) move filtering to be part of tendency computation. We will move that work to a separate issue.

bors r+


NativeMap is not available at OnElementChanged of the Android Map renderer

I'm trying to override map renderer for my specific needs and custom renderer is unable to access NativeMap because at that stage it's not available.
From the code, there is MapReady handler, but it's private and not available for an override.

Fixed in https://www.nuget.org/packages/Xamarin.Forms.GoogleMaps/3.0.0-beta4 .


fix: Allow win/mac credential managers to build on all platforms

What does this PR try to resolve?
This is a step towards #11987 by making two of the platform-specific credential managers build on all platforms using cfg.
I haven't done gnome-secret yet because that is more of an oddball in that it isn't just platforms-specific but dependent on what is installed on that platform.
How should we test and review this PR?
$ cargo check --workspace --exclude cargo-credential-gnome-secret

Note that the commits are broken down so you can view the movements of code separate from the functionality being changed.
Additional information
Other information you want to mention in this PR, such as prior arts,
future extensions, an unresolved problem, or a TODO list.
-->

@bors r+

:pushpin: Commit 943edea4a4ebf06a1d18c9b65789b65349f6120a has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 943edea4a4ebf06a1d18c9b65789b65349f6120a with merge 9d506e58cd7a872c8bb586936e6c528ec65ab571...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 9d506e58cd7a872c8bb586936e6c528ec65ab571 to master...


Fixed RegFileTime parsing

Was using an old copy of python-registry whilst I worked on a project (https://github.com/woanware/usbdeviceforensics), then updated  to the latest and the ability to get valid Windows FILETIME values was broken

Should the data be returned in an "handled" manner?
raw_data to me implies that it is raw bytearray data, and it is up to the caller to handle? (if this should be changed, so should all the other ret =  lines in the function as well)
self.unpack_qword() should probably be used instead.
-            ret = self._buf[data_offset + 4:data_offset + 4 + data_length]
+            ret = self.unpack_qword(data_offset + 4)

Could you elaborate on what "everything broke" means? maybe a stacktrace?
The woanware/usbdeviceforensics repo is empty on github? Otherwise i would have liked to see how this code is called.
IMHO The more correct solution would be this in def data(self):
-            return parse_windows_timestamp(d)
+            return parse_windows_timestamp(struct.unpack_from(str("<Q"), d, 0)[0])

If possible I would prefer a git rebase instead of the merge. (keeping repo history more clean)

Without the fix suggested then the values are not correctly parsed. I really don't mind how the fix is implemented, however, it was the last "cleanup" that didn't actually implement what the original code was attempting to do.
This was the original commit that added support for the RegFileTime:
https://github.com/williballenthin/python-registry/commit/1bfb035c784a915138f28437743bea8b1dc211fc

I see, looks like a miss in the refacoring done in commit b6428982f15dc09b3dc6790deee4e0da1f18f7c6 (added comment)
For my reference (since I'm kind of a newbie to reg hives) could you point me to where the RegFileTime type can be found? (will for my own sake want to implement testcases for this in the future)

The RegFileTime type can be found is in a Win8 hive (which introduced lots of new data types).
An example path is:
SYSTEM\CurrentControlSet\Enum\USBSTOR\Disk&Ven_Kingston&Prod_DataTraveler_G3&Rev_PMAP\000FEAFB9197BC7067D500C8&0\Properties{83da6326-97a6-4088-9453-a1923f573b29}\0066(Default)
More info on the data can be found here:
http://www.swiftforensics.com/2013/11/windows-8-new-registry-artifacts-part-1.html
The only reason I knew it was broken was that I had to implement the original code to parse the data out, as it wouldn't work that those particular keys, then investigation identified the new data type and parsing required.

Thanks a bunch! Will look more on this in a few days, now that i know where I should be looking.


I have no idea, but installing nvm couldn't possibly be related to something like that.
I'd recommend making a Genius Bar appointment at your local Apple Store unless you can find answers on Google.


peek support

It seems this structure almost does what I need, except that I would need to peek in addition to pop. I tried to push back after pop, but that does not work for me since that modifies the top, and I might need to push a value equal to the previous top (or in between).
Would it be possible to implement peek with this data structure?

Peeking the key coiuld be implemented in O(lg n), but peeking the value would be O(n). Is peeking the key enough for you?

Peeking the key is what I need, and it sounds generally useful to have that if it's significantly cheaper.
By the way, Readme says "Popping an element is O(log m)". Out of curiosity, are you saying that peeking the value would be more expensive than that? I was expecting peek to be cheaper than pop since it needs to find the same data but skips the rearranging part.

It's actually amortized O(log n). Popping involves finding the next bucket and redistributing the elements if necessary, which is O(n), but each element will be moved to another bucket at most O(log n) times. When peeking, we would have to scan through the bucket to find the min value but without the rearranging we cannot ensure we will only "pay" O(log n) per element in total.
Peeking the key is simpler, as the min key for each bucket is stored, so it's just scanning through the list of buckets. I have just released 0.3.8 with peek_key. :)


Refactor routes and minor things

Coverage decreased (-0.2%) to 42.399% when pulling 997edc454c29f8bc38df4b96530ab8eaef0cb58c on refactor into 5e2d39e7c759420b472df80f147330af03dc19ad on master.


Sum up common scenarios for RequestHooks

Find out which use cases for RequestHooks are the most problematic for users.

We don't plan to address this issue in the near future. Feel free to reopen the ticket if the issue is important for you.


Issues with block line comments in lua

Hi,
I was giving block commenting  a try, and ran into one issue. Here's the gif:

I'm not sure how this should be handled though.
Also, did you thought about adding the block comment style like vim-commentary does, where each line gets the single line comment?

Hi, this isn't an issue with this plugin, it's just the way comments are handled in lua.
You're trying to comment in a section which contains ]], meaning as far as lua is concerned, the comment ends there. As you can see, the plugin correctly adds the prefix at the end, it just doesn't have the desired effect.

I'm not sure how this should be handled though.

I'm also not sure how this should be handled, a possibility would be checking for illegal patterns in a string before block commenting it in, but since that does add a bit of complexity to the code (The whole text being commented in has to be checked every time, image you want to comment in a file with tens of thousands of lines of code) I haven't added it yet, and I'm not sure if I will.

Also, did you thought about adding the block comment style like vim-commentary does, where each line gets the single line comment?

Yes! You can already do that, it's just hidden behind a bit of configuration. Here are your (current) options:
Define a function and map to it
The drawback here is that you need to essentially rewrite the parts of the toggle_comment function (In the init file), but here it is for just visual:
Put this in your init.lua if you have one, or in our init.vim in an EOF lua block:
function comment_in_selection_singles()
    local kommentary = require('kommentary.kommentary')
    local config = require('kommentary.config')
    local line_number_start = vim.fn.getpos('v')[2]
    local line_number_end = vim.fn.getcurpos()[2]
    kommentary.toggle_comment_range(line_number_start, line_number_end, config.get_modes().force_single)
end

The crucial part here is setting the mode to force_single, which will force the function to comment in every line using single-line comment style. You could also set it to force_multi, which would force the function to use a multi-line comment style, even when you're only commenting out a single line.
Then you can map to it:
vnoremap gc <cmd>lua comment_in_selection_singles()<cr>

Remove the option for multi-line comments
The drawback here is that you will lose the ability to do multi-line comments in that language completely, but that may not be a problem. Put this in your init.lua:
require('kommentary.config').config["lua"] = {"--", false}

That will overwrite the default config for the lua filetype and tell the plugin that the language doesn't support multi-line comments.

Hi, this isn't an issue with this plugin, it's just the way comments are handled in lua.
You're trying to comment in a section which contains ]], meaning as far as lua is concerned, the comment ends there. As you can see, the plugin correctly adds the prefix at the end, it just doesn't have the desired effect.

I'm not sure how this should be handled though.

I'm also not sure how this should be handled, a possibility would be checking for illegal patterns in a string before block commenting it in, but since that does add a bit of complexity to the code (The whole text being commented in has to be checked every time, image you want to comment in a file with tens of thousands of lines of code) I haven't added it yet, and I'm not sure if I will.

Also, did you thought about adding the block comment style like vim-commentary does, where each line gets the single line comment?

Yes! You can already do that, it's just hidden behind a bit of configuration. Here are your (current) options:
Define a function and map to it
The drawback here is that you need to essentially rewrite the parts of the toggle_comment function (In the init file), but here it is for just visual:
Put this in your init.lua if you have one, or in our init.vim in an EOF lua block:
function comment_in_selection_singles()
    local kommentary = require('kommentary.kommentary')
    local config = require('kommentary.config')
    local line_number_start = vim.fn.getpos('v')[2]
    local line_number_end = vim.fn.getcurpos()[2]
    kommentary.toggle_comment_range(line_number_start, line_number_end, config.get_modes().force_single)
end

The crucial part here is setting the mode to force_single, which will force the function to comment in every line using single-line comment style. You could also set it to force_multi, which would force the function to use a multi-line comment style, even when you're only commenting out a single line.
Then you can map to it:
vnoremap gc <cmd>lua comment_in_selection_singles()<cr>

Remove the option for multi-line comments
The drawback here is that you will lose the ability to do multi-line comments in that language completely, but that may not be a problem. Put this in your init.lua:
require('kommentary.config').config["lua"] = {"--", false}

That will overwrite the default config for the lua filetype and tell the plugin that the language doesn't support multi-line comments.

Thanks for the explanation. I think it would be great to have a mapping that does multi line single comment out of the box (The function you wrote above).Something like gcC or something like that, just to be able to handle these edge cases more easily.
I'm pretty sure current block line implementation covers 99% of the cases, but edge cases like this happen. I can also see it happen in html, since it has weird comment strings.

Thanks for the explanation. I think it would be great to have a mapping that does multi line single comment out of the box (The function you wrote above).Something like gcC or something like that, just to be able to handle these edge cases more easily.
I'm pretty sure current block line implementation covers 99% of the cases, but edge cases like this happen. I can also see it happen in html, since it has weird comment strings.

I think it would be great to have a mapping that does multi line single comment out of the box

I agree, I'm just not quite sure how to implement it elegantly.

(The function you wrote above)

As I said, the problem with this function is the repetition of code, ideally we would have a function which is called by mappings, this would then figure out in which mode to operate and on which line/range, then call a second function with those things as arguments, and that second function could be given as an argument to the first function, I think this would allow for easy and elegant configuration. I just haven't gotten around to implementing this yet, since up to now my main focus was making sure that the features that do exist work correctly.
I'll probably implement this soon, I might write the rest of the unit tests first though. If you're interested in giving it a go yourself, I'm always open to PRs.

I think it would be great to have a mapping that does multi line single comment out of the box

I agree, I'm just not quite sure how to implement it elegantly.

(The function you wrote above)

As I said, the problem with this function is the repetition of code, ideally we would have a function which is called by mappings, this would then figure out in which mode to operate and on which line/range, then call a second function with those things as arguments, and that second function could be given as an argument to the first function, I think this would allow for easy and elegant configuration. I just haven't gotten around to implementing this yet, since up to now my main focus was making sure that the features that do exist work correctly.
I'll probably implement this soon, I might write the rest of the unit tests first though. If you're interested in giving it a go yourself, I'm always open to PRs.

Ok, thanks. I can give it a try, but since you have an idea how to make this easily configurable, I'll just leave it to you. I believe you'll do it much better.

Ok, thanks. I can give it a try, but since you have an idea how to make this easily configurable, I'll just leave it to you. I believe you'll do it much better.

Alright, I have implemented basic support for this, for now this not work when using on motions, but a mapping for visual mode is built-in. (I might implement a bit of a workaround to get it to work with motions)
I'm not going to merge this into main now, since I really, really need to sleep and don't trust my ability to judge this code right now, so I'd be very grateful if you could take this for a test drive and tell me if you experience any issues.
Here is the branch: go-callback
If you install from that branch, the mapping in visual mode should be with the new functionality by default, so you shouldn't have to do anything, when you try to comment out a single line with gcc it will work normally, the same goes for gc-motion, but if you do gc on a selection it should comment it in using only single-line comments.

Alright, I have implemented basic support for this, for now this not work when using on motions, but a mapping for visual mode is built-in. (I might implement a bit of a workaround to get it to work with motions)
I'm not going to merge this into main now, since I really, really need to sleep and don't trust my ability to judge this code right now, so I'd be very grateful if you could take this for a test drive and tell me if you experience any issues.
Here is the branch: go-callback
If you install from that branch, the mapping in visual mode should be with the new functionality by default, so you shouldn't have to do anything, when you try to comment out a single line with gcc it will work normally, the same goes for gc-motion, but if you do gc on a selection it should comment it in using only single-line comments.

I gave it a try, looks like it's working fine. I tried it in a bigger JS file (> 1k LOC), and it can be a bit slow (with foldmethod=syntax). Tpope's commentary have same issue, and here are few pending PRs that resolve that issue:
https://github.com/tpope/vim-commentary/pull/136
https://github.com/tpope/vim-commentary/issues/110#issuecomment-511793483
Both of these solutions works, so you just have to pick the one that works better for you.
Having blocks commented in the way you initially implemented does not cause this issue, so that is a plus.

It's great to hear that this is working, I also tried it out a bit and had no issues (But I also did try it on big files).
The way it's implemented right now, we just loop over the range of lines, then call the commenting in function for a single line on each line individually. If we just change that, we can set the whole range in one go, which means foldmethod shouldn't be affected, also this would make it possible to set an indentation level for the whole range (Atm, when you comment in a range that with different indentation levels, each line will be commented in at the first non-whitespace character, maybe we should search for the lowest level of indentation in the range and comment in everything at that index, although this should probably be an option).
If you want to give this a go, (It shouldn't be too complicated, the function we're after is called comment_in_range_single in kommentary.lua) I'd be very grateful, since I have some school work to do right now, if you don't want to I can probably get on this myself later. (If you do decide to give it a go, make your changes against the go-callback branch as well)
Thanks for bringing this to my attention!

There's no rush on this :) It's really an edge case where we need this. I'll let you slowly adapt it and set it up however you want. I just reported it since i ran into it.

Maybe we should close this issue, since the original issue has been addressed?
If you feel that this issue has been answered, please close it, I'll open two new ones, one for tracking the performance issue and one for proper configuration (Configure which comment style to use by default on a per-filetype basis, configure the indentation of single-comment ranges, etc.).

Yeah, i'll close it. Thanks.


Use prost Message from geozero

@Tristramg this fixes the issue you discovered.

Nice to see that there was a quick relesase!