fix: send original Error to custom error handlers instead of H3Error

🔗 Linked issue
#517
❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[X] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[X] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
The custom errorHandler option currently gets passed a H3Error instead of the original Error in order for the
custom errorHandler to handle specific errors it should get passed the original error. This PR fixes this.
Resolves #517
This could break currently existing errorHandlers that expect an H3Error to be passed. Those can be fixed very easily by
calling createError(error)
📝 Checklist

[X] I have linked an issue or discussion.
[X] I have updated the documentation accordingly. (not applicable)

Hi dear @MarijnMensinga sorry for checking on this late. As I have explained in https://github.com/unjs/h3/issues/517#issuecomment-1694486230, you can always use error.cause to access the original error(s).
It was an intentional behavior but would be happy to rediscuss this if you think is still a wrong behavior.


Invalid grant - consent_required

Issue

Please provide us with the following information:

let tokenObj = await getNewAccessToken(userToken);
returns:
{
  error: 'invalid_grant',
  error_description: "AADSTS65001: The user or administrator has not consented to use the application with ID 'APP_ID' named 'APP_NAME'. Send an interactive authorization request for this user and resource.\r\n" +
    'Trace ID: TRACE_ID\r\n',
...
  suberror: 'consent_required'
}

    - [ ] 1-1) Sign-in with Azure AD
    - [ ] 1-2) Sign-in with Azure AD B2C
    - [ ] 2-1) Acquire a Token and call Microsoft Graph
    - [ ] 3-1) Protect and call a web API on Azure AD
    - [ ] 3-2) Protect and call a web API on Azure AD B2C
    - [ x ] 4-1) Call a web API that calls Microsoft Graph on-behalf-of user
    - [ ] 4-2) Call a web API that calls another web API on-behalf-of user
    - [ ]   5) Deploy to Azure Storage and App Service

This issue is for a
    - [x ] bug report -> please search issues before submitting
    - [ ] question
    - [ ] feature request
    - [ ] documentation issue or request

Expected/desired behavior

get new access token

Library version

Browser and version

Chrome 88.0.4324.150

@stajnert it looks like the consent for web API's permissions is not obtained. Can you confirm you have carried out this step in readme?
Regardless, this is a problem with our code and I will make a PR asap. Essentially what's needed is that the web API should catch this error and send it back to the client SPA. The client SPA then should initiate an interactive method to acquire a token (which will prompt the consent dialogue).
In API/index.js
// This is where your API methods are exposed
app.get('/api', passport.authenticate('oauth-bearer', { session: false }),
    async (req, res) => {
        console.log('Validated claims: ', JSON.stringify(req.authInfo));

        // the access token the user sent
        const userToken = req.get('authorization');
        let tokenObj;

        try {
            // request new token and use it to call resource API on user's behalf
            tokenObj = await getNewAccessToken(userToken);

            // check for errors
            if (tokenObj['error_codes']) {

                 * If the user has not consented to required scopes, an AADSTS65001 error will be thrown instead.
                 * In that case, propagate the error back to the client.
                 */
                if (tokenObj['error_codes'].includes(65001)) {
                    return res.status(403).json(tokenObj);
                }
            }

            try {
                // access the resource with the token
                let apiResponse = await callResourceAPI(tokenObj['access_token'], config.resources.downstreamAPI.resourceUri);
                return res.status(200).json(apiResponse);
            } catch (error) {
                console.log(error);
                return res.status(403).json(error);
            }

        } catch (error) {
            console.log(error);
            return res.status(403).json(error);
        }
    }
);

Then in SPA/App/api.js
function callApi(endpoint, token) {

    const headers = new Headers();
    const bearer = `Bearer ${token}`;

    headers.append("Authorization", bearer);

    const options = {
        method: "GET",
        headers: headers
      };

    logMessage('Calling Web API...');

    fetch(endpoint, options)
      .then(response => response.json())
      .then(response => {
            /**
             * If the user has not consented to required scopes,
             * an AADSTS65001 error will be thrown.
             */
           if (response['error_codes'].includes(65001)) {

            // calls the MSAL.js acquireToken* API
            passTokenToApi();
          }
        } else {
          // if no errors, display user name
          logMessage('Web API responded: Hello ' + response['name'] + '!');
        }

        return response;
      }).catch(error => {
        console.error(error);
      });
  }

@derisen my configuration is fine. I did everything step-by-step.
I have one question about SPA/App/apiConfig.js What is the correct value for scopes?
I have
scopes: ["api://API_CLIENT_ID/.default"]

I checked also
scopes: ["api://API_CLIENT_ID/access_as_user"]

but without success.

Ok, I found. You have wrong parameters in the Api/index.js:

line 50 config.resources.resourceUri should be config.resources.graphAPI.resourceUri
line 69 config.resources.resourceScope should be config.resources.graphAPI.resourceScopes

@stajnert thank you very much for catching this! I've just made a PR to fix these. Really appreciate your help here.


feat: extend websocket support

Motivation
JavaScript WebSocket API does not support adding authorization headers making the live console endpoint unusable. The only controllable header is Sec-WebSocket-Protocol, which is not convenient to use and support.
Modification/Result
Methods or parameter annotated with TokenAuth allows to either add the generated token as a bearer token or as a query parameter.
I made the decision to create a third annotation because this will still force a user to use the correct header if the endpoint won't upgrade to a websocket connection later on.

Hi, sorry for the late reply on this. We are currently rewriting the rest module and have solved this issue there. Thanks for you effort.


Update cats-effect to 3.2.8

Updates org.typelevel:cats-effect from 3.2.5 to 3.2.8.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "cats-effect" } ]

labels: library-update, semver-patch

Codecov Report

Merging #5 (04c06e9) into main (ed47561) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   67.22%   67.22%
=======================================
  Files          14       14
  Lines         180      180
  Branches        2        2
=======================================
  Hits          121      121
  Misses         59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed47561...04c06e9. Read the comment docs.


colours of POI-Cluster on map

Currently the POI-Cluster colours do not add much information, but distract, as especially the green of the smallest cluster break the colour-pattern.

Best change to the colour pattern of www.solidarityeconomy.us

For the colour of the actual POI, we could use the green that currently is at the smallest cluster.

3 people here liked it, let´s try.
The dark blue is not really applealing, and the turquois would probably interfere with colours in the map tiles.

Tried out bright blue for POIs, not really a good idea

changed to solidarity economy us color scheme, used green for pois on standard leaflet marker icon.


Problem with accents

When writing use pc keyboard at phone apps, cant write as expected when want accents
Its output is like: oó
aá
eé
ií
...
...
First the vocal without accent then vocal with accent

Either use --prefer-text, or better, switch to UHID keyboard.

Option 1
Running with --prefer-text works:
scrcpy --prefer-text

Option 2
Switching to UHID keyboard changes the keyboard layout. It requires further configuration on the Android device, like going into Settings → Additional settings → Keyboard & input method → Manage keyboards → Gboard → Settings → Languages.
I was able to change it to Portuguese, but only if I choose the Gboard. This option does not work with the Microsoft SwiftKey Keyboard.

@leo3487 I think you can try and confirm that this works. If it works, please close the issue.


PBL-21165 Add hiddenApp & onlyShownOnCommunication to settings

Note: This allows developers that are using PebbleKit JS (not Pebble.js) to specify onlyShownOnCommunication (selecting "Only Visible When Companion App Running" option), even though that's going to end up with ghost apps if they select incorrectly. I didn't think checking for the presence of JS files in the project at the time of showing the selector was worth pursuing for a rarely-used flag, but I can go back and alter, if we're worried about error-checking developers.

I wonder if that case should be handled in the build tool so it would catch it for non-CloudPebble users too.  Having that in settings means a lot of consistency checking, since you can add JS files after the project is created.

Your suggestions have resulted in a ticket being created for better appinfo.json field checking, yay!

@Katharine, code review please!

:+1:


Duplicate Notifications (Signup, Un-enroll, Status Change)

When debugging the code to evaluate work on a prior issue I noticed that the IAsyncNotificationHandlers for things such as NotifyVolunteerForTaskSignup and NotifyAdminForSignup seem to get triggered twice on each occurrence of a notification.
I can't see any obvious reason for this but suspect possibly the issue stems with the service registration / dependency resolution.
The result of this issue would be duplicated emails being sent for task notifications.

@mgmccarthy Best way to replicate is to make sure you have an event with a task both with current date ranges. Put some breakpoints on the handlers for task signup volunteer notification and admin notification and debug in. You should see that both breakpoints are hit twice, despite a single notification being sent from the task signup handler. I messed around a bit last night taking out the ASP.NET core DI registration for Mediatr and directly registering via autofac but it made no difference. Didn't get much further than that.

@stevejgordon, my dev machine is down and out for the rest of the elongated weekend. The soonest I'll be able to do anything will be on Tuesday, and thats' assuming my machine can be fixed by the same Help Desk that ended up making it not even able to boot to windows anymore 😠
Long story short, could be awhile until I can get eyes on this.

@tonysurma, if no one else claims this, when I get a working machine back on Tuesday, I'd be happy to look into this, especially since @stevejgordon did all the hard work of removing the concept of volunteering for Events from the system.

Neither rain, nor sleet or failing SSDs can stop @mgmccarthy 😸
it's all yours

Well the SSD can ;) we'll see how I fair when visit the "Helpless Desk" this Tuesday. Hoping for the best.

@stevejgordon, is this still an issue?

I haven't check the latest code but I would expect so. Meant to take a look this weekend but got side-tracked.
Sent from my Windows Phone

From: Michael<EMAIL_ADDRESS>Sent: 14/09/2016 20:22
To<EMAIL_ADDRESS>Cc: Steve<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [HTBox/allReady] Duplicate Notifications (Signup, Un-enroll, Status Change) (#1216)
@stevejgordon, is this still an issue?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/HTBox/allReady/issues/1216#issuecomment-247125171

@stevejgordon, I just replicated this on my system. Like you said, each handler is being called twice when it should only be called once. I'm investigating now.

@stevejgordon, I think I found the problem, and it looks like it might be related to the library Jimmy Bogard wrote to register MediatR in the StartUp.cs class.

https://lostechies.com/jimmybogard/2016/07/19/mediatr-extensions-for-microsoft-dependency-injection-released/
https://www.nuget.org/packages/MediatR.Extensions.Microsoft.DependencyInjection

basically, we're registering MediatR using this library like this in startup:
//register MediatR
//https://lostechies.com/jimmybogard/2016/07/19/mediatr-extensions-for-microsoft-dependency-injection-released/
services.AddMediatR(typeof(Startup));

when I took that code out and went back to the old way of registering MediatR:
var containerBuilder = new ContainerBuilder();
containerBuilder.RegisterAssemblyTypes(typeof(IMediator).Assembly).AsImplementedInterfaces();
containerBuilder.Register<SingleInstanceFactory>(ctx =>
{
    var c = ctx.Resolve<IComponentContext>();
    return t => c.Resolve(t);
});

containerBuilder.Register<MultiInstanceFactory>(ctx =>
{
    var c = ctx.Resolve<IComponentContext>();
    return t => (IEnumerable<object>)c.Resolve(typeof(IEnumerable<>).MakeGenericType(t));
});

the duplicate handling of VolunteerSignupNotification in both NotifyVolunteerForTaskSignup and  NotifyAdminForSignup stopped. I'm going to check in the older version of the MediatR handler code in StartUp as a fix for this Issue.
In the meantime, I'll see if I can open an Issue with MediatR about this new registration package causing handling of a notification in the same handler twice.


resources: allow use of ULPI PHYs with active-low RST pins

Didn't foresee this when creating the resources: PHYs like the USB3343 have an active-low RST instead of the more typical active-high. Adding a parameter for that.
Also, fixes a typo that affected PHYs with rst specified (😳 ).

Apologies for the delay on this; just got back from avoiding work over the weekend for my own sanity. :)

Thanks!


[Bug]: When enable log drain container is always restarts

Description
When I try to turn on log drains (doesn't matter axiom or new relic) container restarts every time:
cr.fluentbit.io/fluent/fluent-bit:2.0              "/fluent-bit/bin/flu…"   59 seconds ago   Restarting (255) 4 seconds ago
Minimal Reproduction (if possible, example repository)
Maybe it's my local VPS issue, but the rest containers working well
Exception or Error
No response
Version
v4.0.0-beta.306

Same here. When I check the logs of the container I get this error.
Maybe adding a custom configuration for fluentbit might solve this issue?
I am running coolify on an ARM chip, are you by any chance also? Might this be an issue?
:
[error] [filter:modify:modify.1] Invalid config for set
[error] Failed initialize filter modify.1
[error] [engine] filter initialization failed

complete logs:
[2024/07/08 08:21:52] [ info] Configuration:
[2024/07/08 08:21:52] [ info]  flush time     | 5.000000 seconds
[2024/07/08 08:21:52] [ info]  grace          | 5 seconds
[2024/07/08 08:21:52] [ info]  daemon         | 0
[2024/07/08 08:21:52] [ info] ___________
[2024/07/08 08:21:52] [ info]  inputs:
[2024/07/08 08:21:52] [ info]      forward
[2024/07/08 08:21:52] [ info] ___________
[2024/07/08 08:21:52] [ info]  filters:
[2024/07/08 08:21:52] [ info]      grep.0
[2024/07/08 08:21:52] [ info]      modify.1
[2024/07/08 08:21:52] [ info] ___________
[2024/07/08 08:21:52] [ info]  outputs:
[2024/07/08 08:21:52] [ info]      http.0
[2024/07/08 08:21:52] [ info] ___________
[2024/07/08 08:21:52] [ info]  collectors:
[2024/07/08 08:21:52] [error] [lib] backend failed
[2024/07/08 08:21:52] [ info] [fluent bit] version=2.0.14, commit=bf20c16ea4, pid=1
[2024/07/08 08:21:52] [debug] [engine] coroutine stack size: 196608 bytes (192.0K)
[2024/07/08 08:21:52] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2024/07/08 08:21:52] [ info] [cmetrics] version=0.6.1
[2024/07/08 08:21:52] [ info] [ctraces ] version=0.3.1
[2024/07/08 08:21:52] [ info] [input:forward:forward.0] initializing
[2024/07/08 08:21:52] [ info] [input:forward:forward.0] storage_strategy='memory' (memory only)
[2024/07/08 08:21:52] [debug] [forward:forward.0] created event channels: read=21 write=22
[2024/07/08 08:21:52] [debug] [in_fw] Listen='<IP_ADDRESS>' TCP_Port=24224
[2024/07/08 08:21:52] [debug] [downstream] listening on <IP_ADDRESS>:24224
[2024/07/08 08:21:52] [ info] [input:forward:forward.0] listening on <IP_ADDRESS>:24224
[2024/07/08 08:21:52] [error] [filter:modify:modify.1] Invalid config for set
[2024/07/08 08:21:52] [error] Failed initialize filter modify.1
[2024/07/08 08:21:52] [error] [engine] filter initialization failed
[2024/07/08 08:21:52] [ info] [input] pausing forward.0`

@Blochergroup, it’s not an ARM. I have an AMD EPYC on my VPS. So, it’s definitely not because of the chip architecture

@ReWWeR very weird. Just tested it on a ryzen 9 7950X3D and it works.


UI handle event update parcel

handle parcels events :

[x] update

https://github.com/allilou/onchain-land-administration/pull/38


Roadmap for v1

AST Metrics aims to become a leading, language-agnostic, user-friendly, and educational code analyzer.
This is my first project in Go, and I'm completely new to the language. Contributions are highly welcome, particularly to enhance stability and performance.
The v1 roadmap is as follows:
Supported Languages

[x] PHP (full)
[x] Golang (partial)
[ ] TypeScript
[ ] Java
[x] Python (partial)
[ ] Dart

Features

[x] Unified AST descriptor via Protobuf
[x] CLI report
[x] Support for non-interactive environments (CI)
[x] Configuration file support (.ast-metrics.yaml)
[x] HTML report
[x] Git analysis
[x] Markdown report
[x] Easy integration with Github, via Github actions
[ ] Easy integration with Gitlab CI, via Templates

Metrics

[x] Halstead metric
[x] Bug probability
[x] FanIn / FanOut (afferent / efferent coupling)
[x] Cyclomatic complexity
[x] Maintainability index
[x] Size (lines of code, comments, logical lines)
[x] Bus factor
[x] Commits, top committers
[x] Risked files

All of this is subject to change, and discussions may lead to new ideas or modifications to the roadmap.

v2 will probably include: 'failIf' conditions, relations between objects, OpenAI plugin...

Thank you in advance for your assistance!

Hello @Halleck45
Would it be possible to add a search option on certain pages? I'm specifically thinking about the "risk" page.
Often, after initiating an analysis of a project, I need to focus on specific components of my application (commands, controllers, a set of specific classes within a namespace, etc ...).
Currently, this requires me to rerun the entire analysis just to target these classes.
Thank you !

Hi @DeGraciaMathieu , thanks for the suggestion!
To avoid having to restart the tool, I just added a --watch option that refreshes the page and the HTML report as soon as a file is updated.
Regarding the search functionality, what do you think? Should we add a --filter argument? Or maybe a search field that appears in the window when you press Ctrl + F?
Could you please create a discussion here ?

Hi!
Unfortunately, I found that there is no Distance from the main sequence metric. Are you planning to add it?

I opened an issue in PhpMetrics, but I think it could be done in this project instead, WDYT of supporting the OpenMetrics specification?
It could be then be used for instance in GitLab to have the metrics directly in the MR!
It seems there are some available packages in Go as well, for instance: https://github.com/bsm/openmetrics

@alanpoulain excellent idea !
I hope https://github.com/Halleck45/ast-metrics/pull/70 will help you

Wow already! :rocket: Nice to see it implemented, thank you! Now I need to replace PhpMetrics with AST Metrics :smile:

How to you plan to support the newer versions of PHP if VKCOM/php-parser is not updated anymore?


[DRAFT] Bugs/fix some failing system tests

Proposed changes
Fix some of the currently failing tests.
Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[ ] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

This should have been a draft PR. Strangely, I cannot switch back to draft.

Disabled test tedge_mapper_c8y_alarms due to https://github.com/thin-edge/thin-edge.io/issues/966

Rebased on main

... after all that time this became a two-liner.
Rebased it on main.


ESM

Hello.
Currently, this package uses the deprecated CommonJS type. Please consider switching to ESM.

CJS is used for maximum compatibility with Express


Update build-number reading

Make build-number configurable with a build-argument
Allow the build-number query to timeout
resolve #8

Thanks for fixing this! :+1:


service: Add gRPC client/server call logging interceptors

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Add interceptor classes for logging gRPC client and server calls.

nims._loggers.ClientLogger:

Debug logging: logs the start and completion of each call.

nims._loggers.ServerLogger:

Production logging: logs the completion of each call with elapsed time and status code, similar to the logging Serilog provides with ASP.NET Core.
Debug logging: logs the starts and completion of each call.

Why should this Pull Request be merged?
As a developer, I want better visibility into MeasurementLink measurement execution time for Python measurement services.
What testing has been done?
Ran pytest and mypy locally.
Manually tested with nidcpower and streaming examples.

nidcpower_source_dc_voltage production output (measurement -v):
2023-08-10 13:45:05,405 INFO: Measurement service hosted on port: 64165
2023-08-10 13:45:05,414 INFO: Successfully registered with discovery service.
Press enter to close the measurement service.
2023-08-10 13:45:29,596 INFO: gRPC server call /ni.measurementlink.measurement.v2.MeasurementService/GetMetadata responded OK in 1.1631 ms
2023-08-10 13:45:29,700 INFO: Executing measurement: pin_names=['Pin1'] voltage_level=6
2023-08-10 13:45:29,975 INFO: site0/Pin1:
2023-08-10 13:45:29,975 INFO:   Voltage: 6 V
2023-08-10 13:45:29,975 INFO:   Current: 0.0001 A
2023-08-10 13:45:29,976 INFO:   In compliance: False
2023-08-10 13:45:29,976 INFO: Completed measurement
2023-08-10 13:45:29,976 INFO: gRPC server call /ni.measurementlink.measurement.v2.MeasurementService/Measure responded OK in 276.0277 ms

2023-08-10 13:45:42,018 INFO: Successfully unregistered with discovery service.
2023-08-10 13:45:42,019 INFO: Measurement service closed.

nidcpower_source_dc_voltage debug output (measurement -vv):
2023-08-10 13:43:30,521 INFO: Measurement service hosted on port: 64110
2023-08-10 13:43:30,522 DEBUG: Discovery service key file path: C:\ProgramData\National Instruments\MeasurementLink\Discovery\v1\DiscoveryService.json
2023-08-10 13:43:31,033 INFO: Successfully registered with discovery service.

I just glanced through the changes since I don't think I'm enough of a Python expert to provide any meaningful feedback. However, the high level changes and direction look good to me.


How to use device Attribute

Hi,
New to using Traccar 3.7.  I change Adc1  to display as Fuel, but not success. Could you tell me correct way to display using with Attribute. Thanks.

Device attributes have nothing to do with position attributes.


Blog Post for bst speak Command

Similar to the bst proxy post, we want a simple blog post that outlines what the bst speak command is and what it can be used for.

Closed by pr #16


[compliance] add SPDX identifiers and scripts for SPDX.

resolve #381

Can we auto-check the license in the CI?

I think we can. I can write a script to check with the CI.
However, I do not possess the accessibility to the CI. So may someone to pick the CI up after the script is ready.

I may add another script with things related to the CI check. You can review this PR and merge if it looks okay.


Socket error: Connection reset by peer, when Nmap

(great job btw!)
I'm still on the example. Launching testwebsock.php works fine, but asa a nmap scan occured, a RST packet is received and the connection fail fatally. Dropping data.
Server started
Listening on: <IP_ADDRESS>:9000
Master socket: Resource id #6
Client connected. Resource id #7

Socket error: Connection reset by peer

nmap <IP_ADDRESS> -p9000

Unusual client disconnects (or any socket error, for that matter) no longer throw an exception.


Consider using .gitignore rather than .git/info/exclude

Since .git/info/exclude is not version controlled by default, using .git/info/exclude only works on the original developers program/repo.
Why is this used instead of .gitignore?  It is very annoying when working with a team, if one person adds a library only their local repo has the correct git ignore settings.

ARM Internal Ref: MBOTRIAGE-1508

@screamerbg Would you mind shedding some light on this? Feels odd to me as well.

Thank you for raising this issue. Please note we have updated our policies and
now only defects should be raised directly in GitHub. Going forward questions and
enhancements will be considered in our forums, https://forums.mbed.com/ . If this
issue is still relevant please re-raise it there.
This GitHub issue will now be closed.


MODULES-10063, extend apt::key to support deeplinks, this time with f…

…ilename (https://some.source/somefile.key)

@atarax Thanks for submitting the PR.

The changes are already merged with this PR https://github.com/puppetlabs/puppetlabs-apt/pull/892/files
Could you please take a look and let us know if you are happy with the change and we close the PR.Thank you.

@sheenaajay this PR was also from me https://github.com/puppetlabs/puppetlabs-apt/pull/892/files, however, notice the slight difference of the dot in the regex. with my previous PR, this was not possible:
https://foo.bar/some.key
only
https://foo.bar/somekey


AJ-676: Leverage proxyUrls from Leo for WDS

Relates to https://broadworkbench.atlassian.net/browse/AJ-676
This PR references a proxyUrl from Leonardo, in which a running WDS application exists. This allows us to reference a running app in a k8s cluster facilitated by Azure AKS, rather than relying on a local dev server of WDS.
There are a few outstanding TODOs that will come up in additional PRs soon

@davidangb @rtitle
Just wanted to give a heads up -- I'm still seeing sporadic failures of the responses from proxyUrls specifically: 502 Bad Gateway errors and the following error -- that disguises itself as 404:
{"error":{"code":"EndpointNotFound","message":"There are no listeners connected for the endpoint. TrackingId:328c5f28-0d86-4624-94ed-7caa73aa1a8e_G9, SystemTracker:lzced5d128aea78ac24a9b5e0d893a01d72c47912cb29a7304.servicebus.windows.net:friday-dec-9-aaronkanzer/wds/87454afd-58cf-4b28-a7fe-1ea4260f62ae/search/v0.2/a-working-table, Timestamp:2022-12-13T16:01:49"}}

These errors sometimes resolve on their own, so I'm assuming we probably need to check on what is going on within the corresponding AKS cluster, and any surrounding resources (The corresponding LZ here is lzced5d128aea78ac24a9b5e0d893a01d72c47912cb29a7304) I'm curious if the "autoscalingEnabled": false flag in kubernetesRuntimeConfig is causal to the problems here....
I'm still unable to access the appropriate k8s cluster context to view logs/state of the pods to get more insight, perhaps y'all might have more info/access.  Anyways, definitely a post-Broad-retreat thing, but figure I'd let you both know! Happy to dig in further here.


Introspection call missing authorization

When trying to use token introspection with ORY Hydra, I get the following error:
2018/07/31 15:41:41 [debug] 55#0: *26760 [lua] openidc.lua:409: openidc_call_token_endpoint(): introspection endpoint response: {"error":"request_unauthorized","error_description":"The request could not be authorized","error_hint":"Check that you provided valid credentials in the right format.","status_code":401,"error_debug":"HTTP Authorization header missing"}

See PR #62 for further details and fix

Thanks for the fix! I'm closing it. Reopen, if there are still problems.


[JakartaOne Livestream] What We Learned from Porting PiggyMetrics from Spring Boot to MicroProfile

Join @emilyfhjiang @edburns  #JavaChampion @JakartaOneConf Tuesday, 8th Dec at 12 am PT / 3 pm ET / 21:00 CET for a great session "What We Learned from Porting PiggyMetrics from Spring Boot to MicroProfile" Register here https://www.crowdcast.io/e/jakartaonelivestream_dec8/register

good to go

@rstjames can you also mention Edward Burns from Microsoft as this is a joint talk.

@Emily-Jiang good catch. Updated it :)

Thank you @rstjames ! This is awesome!


Remove validate_decimal_precision check in DecimalBuilder.append_value

Which issue does this PR close?

Closes #1766.
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Codecov Report

Merging #1767 (e2ad586) into master (5cf06bf) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1767      +/-   ##
==========================================
+ Coverage   83.32%   83.47%   +0.15%
==========================================
  Files         196      196
  Lines       55961    55925      -36
==========================================
+ Hits        46627    46683      +56
+ Misses       9334     9242      -92

Impacted Files
Coverage Δ

arrow/src/array/array_binary.rs
93.05% <ø> (-0.26%)
:arrow_down:

arrow/src/array/builder.rs
86.79% <ø> (-0.01%)
:arrow_down:

parquet/src/util/cursor.rs
63.86% <0.00%> (-13.45%)
:arrow_down:

parquet/src/util/io.rs
88.33% <0.00%> (-1.67%)
:arrow_down:

parquet_derive/src/parquet_field.rs
65.53% <0.00%> (-0.46%)
:arrow_down:

parquet/src/file/writer.rs
92.85% <0.00%> (-0.45%)
:arrow_down:

arrow/src/array/transform/mod.rs
86.85% <0.00%> (-0.12%)
:arrow_down:

arrow/src/array/array_struct.rs
88.40% <0.00%> (-0.05%)
:arrow_down:

...arquet/src/arrow/array_reader/dictionary_buffer.rs
94.44% <0.00%> (-0.04%)
:arrow_down:

parquet/src/arrow/array_reader/offset_buffer.rs
94.79% <0.00%> (-0.03%)
:arrow_down:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf06bf...e2ad586. Read the comment docs.

I'm not sure how I feel about this, the promise of the builders is they won't let you construct an ArrayData that would fail validation, and can therefore elide this validation. I think this change violates that?
Tbh this feels like a bug in the C++ implementation... Perhaps we should raise a ticket to at the very least get context?

In C++, the similar check is done in validating ArrayData, not during appending values into the builder. I'm not sure which one is more correct under Arrow's context.
I'm trying to remove the check and (not committed yet) put the precision check into the validation of ArrayData (this is what C++ Arrow does).
In one way, as we don't do full validation when finishing the builder, it seems this check is necessary if it is the promise of the builder to always build a valid ArrayData. Then the check is needed and it seems C++ needs to add the check there. I will open a ticket there and try to get some feedbacks.

In one way, as we don't do full validation when finishing the builder, it seems this check is necessary if it is the promise of the builder to always build a valid ArrayData. Then the check is needed and it seems C++ needs to add the check there. I will open a ticket there and try to get some feedbacks.

I think this is the right thing to do -- thank you @viirya

Thanks @alamb @nevi-me @tustvold. I've opened a ticket https://issues.apache.org/jira/browse/ARROW-16696 to hear some feedback there.

I am a little worried about removing the validation from DecimalBuilder -- I think one of the philosophies we are shooting for is if you use safe APIs you will create valid Arrow arrays.

Hmm, seems at C++ implementation, the builder is unsafe API, in Rust parlance. This is based on the reply I got in the JIRA ticket. This seems the difference between Rust and C++ implementations.

What would you think about making validation optional for the builder?
I think this would avoid having to add #[cfg(not(feature = "force_validate"))] and it would allow the interop test to bypass value validation only when needed?

Generally it sounds good to me. But in the test, we are not using the builder directly. The builder is called by more higher API when reading JSON/Arrow files into Arrays. So seems we need more than adding an API like disable_value_validation to DecomalBuilder.
Let me try to play it around and see if an optional validation of the builder is possible to solve the interop test issue.

Hmm, I think it is not directly related. C++ also does this check but it does in full validation, not in the builder. Actually C++ Arrow avoids the full validation too in the interop to avoid similar issue.

I think this would avoid having to add #[cfg(not(feature = "force_validate"))]

Oh, BTW, adding #[cfg(not(feature = "force_validate"))] to several tests is for the added check in ArrayData::validate, not due to removal of the check from DecimalBuilder.
These tests build ArrayData with incompatible decimal values. As this adds the check when full validation, these tests will fail during that.

Generally it sounds good to me. But in the test, we are not using the builder directly. The builder is called by more higher API when reading JSON/Arrow files into Arrays. So seems we need more than adding an API like disable_value_validation to DecomalBuilder.

I'm wrong. Fortunately, for interop test, we directly invoke DecimalBuilder to read JSON file to Array. So adding disable_value_validation call there can fix the interop issue. Verified it locally.

Thanks @alamb @tustvold @nevi-me


saveat causes incorrect evaluation of the history function

using the saveat  feature seems to cause incorrect evaluation of history function.
The code:
using StochasticDelayDiffEq

function f(du,u,h,p,t)
     du[1] = -u[1]
     println(h(p, t-0.001))
 end

 function g(du,u,h,p,t)
     du[1] = 0.1
 end

 tspan = (0.0,0.1)
 h(p, t) = 0.0
 u0 = [0.0]
 prob = SDDEProblem(f,g, u0,h,tspan, 0.0,constant_lags=[0.001])
 alg = EM()

 sol = solve(prob,alg,dt=0.01);

 sol = solve(prob,alg,dt=0.01,saveat=0.1);

println output of evaluation of history function for a realisation without saveat
0
[0.0]
[0.0014037592652750368]
[0.0009688081360439431]
[0.00614797237584531]
[0.0035864500205580593]
[0.001500811510678003]

println output of evaluation of history function for a realisation with saveat
 0
[0.0]
[0.0]
[0.0]
[0.0]
[0.0]
[0.0]

Tried other SDE algorithms and the same problem occurs.
Julia Version 1.7.2

It's probably https://github.com/SciML/ModelingToolkit.jl/pull/1490/files#diff-47c27891e951c8cd946b850dc2df31082624afdf57446c21cb6992f5f4b74aa2R475. I don't think that method was made safe for symbolic arrays @ValentinKaisermayer

Maybe I have but I don't think that this is the problem here. This does not even has ModelingToolkit.jl as dependency.

😅 posted on the wrong issue.


Fix missing substitutions in log messages

Thanks for taking the time to submit a bug fix for this script, but I'll be deprecating it soon as part of #651. The new system won't need to synchronize changes like this anymore.


Bugfix with Remote Desktop

Fixed a bug where after using Remote Desktop and client
disconnection/reconnection, the server wasn't able to run Remote Desktop
again.  I believe there is an issue with the buffer/flow in the
UnsafeStreamCodec class however I wasn't able to pinpoint it.  Setting
this object to null allows a new object to be created when running
Remote Desktop with a fresh buffer.

Please close, will push mergable version


feat: Generic Preview Component

[x] I have read the Contributing Guide
[x] I have signed the CLA
[x] Lint and unit tests pass locally with my changes
[ ] I have labeled the PR correctly with the related package
[ ] I have run Loki's visual regression tests (if applicable)
[ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
[ ] I have added necessary documentation (if applicable)
[ ] Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

Closed in favor of #553 (that has already been merged)


nRF91: DPS310 I2C driver not working

Describe the bug
I have integrated a DPS310 sensor from Infineon to nRF9160 via I2C and trying to get the example DSP310 sample application provided in the samples to work. However, after checking and rechecking all the configurations, I keep getting
Could not get DPS310 device
which simply tells me that the application is failing to get the device binding.
const struct device *dev = device_get_binding(DT_LABEL(DT_INST(0, infineon_dps310)));

if (dev == NULL) {
	printk("Could not get DPS310 device\n");
	return;
}

To diagnose this issue, I have enabled the logs at the I2C and the DPS310 driver level as follows
CONFIG_LOG=y
CONFIG_SENSOR_LOG_LEVEL_DBG=y
CONFIG_I2C_LOG_LEVEL_DBG=y

and found the following:
/* Initialize the sensor and apply the configuration */
static int dps310_init(const struct device *dev)
{
	struct dps310_data *data = dev->data;
	const struct dps310_cfg *config = dev->config;

	data->i2c_master = device_get_binding(config->i2c_bus_name);
	if (data->i2c_master == NULL) {
		LOG_ERR("Failed to get I2C device");
		return -EINVAL;
	}

	uint8_t product_id = 0;
	int res = i2c_reg_read_byte(data->i2c_master, config->i2c_addr,
				 IFX_DPS310_REG_ADDR_PRODUCT_ID, &product_id);

	if (res < 0) {
		LOG_ERR("No device found");
		return -EINVAL;
	}

	if (product_id != IFX_DPS310_PRODUCT_ID) {
		LOG_ERR("Device is not a DPS310");
		return -EINVAL;
	}
	else
	{
		LOG_DBG("DPS310 product_id: 0x%02x", product_id);
	}

	LOG_DBG("Init DPS310");
	/* give the sensor time to load the calibration data */
	k_sleep(K_MSEC(40));

	/* wait for the sensor to load the calibration data */
	if (!poll_rdy(data, config, REG_ADDR_MEAS_CFG,
		      IFX_DPS310_REG_ADDR_MEAS_CFG_SELF_INIT_OK)) {
		LOG_DBG("Sensor not ready");
		return -EIO;
	}

	/* read calibration coefficients */
	uint8_t raw_coef[18] = { 0 };

	res = i2c_write_read(data->i2c_master, config->i2c_addr,
			     &REG_ADDR_CALIB_COEFF_0, 1, &raw_coef, 18);
	if (res < 0) {
		LOG_WRN("I2C error: %d", res);
		return -EIO;
	}

	/* convert calibration coefficients */
	dps310_calib_coeff_creation(raw_coef, &data->comp);

	/*
	 * check which temperature sensor was used for calibration and use it
	 * for measurements.
	 */
	uint8_t tmp_coef_srce = 0;

	res = i2c_write_read(data->i2c_master, config->i2c_addr,
			     &REG_ADDR_COEF_SRCE, 1, &tmp_coef_srce, 18);
	if (res < 0) {
		LOG_WRN("I2C error: %d", res);
		return -EIO;
	}

	/* clear all other bits */
	tmp_coef_srce &= IFX_DPS310_COEF_SRCE_MASK;

	/* merge with temperature measurement configuration */
	tmp_coef_srce |= IFX_DPS310_TMP_CFG;

	/* set complete configuration in one write */
	const uint8_t config_seq[] = {
		IFX_DPS310_REG_ADDR_PRS_CFG,	/* start register address */
		IFX_DPS310_PSR_CFG,		/* PSR_CFG */
		tmp_coef_srce,			/* TMP_CFG */
		0x00,				/* MEAS_CFG */
		DPS310_CFG_REG			/* CFG_REG */
	};

	res = i2c_write(data->i2c_master, config_seq, sizeof(config_seq),
			config->i2c_addr);
	if (res < 0) {
		LOG_WRN("I2C error: %d", res);
		return -EIO;
	}

	dps310_hw_bug_fix(data, config);
	dps310_measure_tmp_psr(data, config);

	LOG_DBG("Init OK");
	return 0;
}

In the DPS310 driver dps310_init() function;
The code runs as expected up to reading the product ID and then the  i2c_write_read() call for reading calibration coefficients fails and gives a negative value for input/output error failing to initialize the driver properly.
I2C error: -5

What is surprising that the I2C call for reading the product ID from the sensor register works and it gives the correct product id as 0x10h which indicates that connections and i2c address are correct.
Looking deeper into the code, the  i2c_reg_read_byte() actually returns  i2c_write_read(). However, directly calling the  i2c_write_read() in the DPS310 driver layer is not working as expected. So why does one I2C API call works while the other does not?
static inline int i2c_reg_read_byte(const struct device *dev,
				    uint16_t dev_addr,
				    uint8_t reg_addr, uint8_t *value)
{
	return i2c_write_read(dev, dev_addr,
			      &reg_addr, sizeof(reg_addr),
			      value, sizeof(*value));
}

To Reproduce
Add the following config to the overlay file:
/*
 * A DPS310 attached to the I2C pins: SDA:26, SCL:27
 */

&i2c1 {
	compatible = "nordic,nrf-twim";
	sda-pin = < 0x1a >;
	scl-pin = < 0x1b >;
	status = "okay";
	DPS310@77 {
		status = "okay";
		compatible = "infineon,dps310";
		reg = <0x77>;
		label = "DPS310";
	};
};

&uart1 {
	status = "disabled";
};

and the following to the prj.conf file
CONFIG_I2C=y
CONFIG_SENSOR=y
CONFIG_DPS310=y
CONFIG_LOG=y
CONFIG_SENSOR_LOG_LEVEL_DBG=y
CONFIG_I2C_LOG_LEVEL_DBG=y

Then build and flash the application as follows:
cd samples/sensor/dps310
west build -b nrf9160dk_nrf9160 --pristine
west flash

Expected behavior
On application startup, log message says:
Could not get DPS310 device

Impact
Simply annoying and unreliable as now I am unsure that which of these sensor drivers might be working or broken unless each one is retested. Also, one might have to rewrite the specific sensor driver to make it work for their specific platform which is not what one might expect.
Environment:

MacOS
nRF Connect SDK + Zephyr
v1.5.1

Additional context
After reading other threads, this might the ongoing and lingering i2c issue in Zephyr as mentioned here and here.

In the DPS310 driver dps310_init() function;
The code runs as expected up to reading the product ID and then the i2c_write_read() call for reading calibration coefficients fails and gives a negative value for input/output error failing to initialize the driver properly.
I2C error: -5

What is surprising that the I2C call for reading the product ID from the sensor register works and it gives the correct product id as 0x10h which indicates that connections and i2c address are correct.
Looking deeper into the code, the  i2c_reg_read_byte() actually returns  i2c_write_read(). However, directly calling the  i2c_write_read() in the DPS310 driver layer is not working as expected. So why does one I2C API call works while the other does not?

I think the problem is that the TWIM peripheral that handles I2C in nRF9160 cannot perform a transaction when the provided buffer is located in flash, and that is the case when i2c_write_read() is called from the DPS310 driver (REG_ADDR_CALIB_COEFF_0 is defined as static const). When i2c_write_read() is called via i2c_reg_read_byte(), the buffer to be sent is &reg_addr, so it will be on the stack, i.e. in RAM.
You can confirm this by trying to use the following in the driver:
	uint8_t raw_coef[18] = { 0 };
	uint8_t reg_addr = REG_ADDR_CALIB_COEFF_0;

	res = i2c_write_read(data->i2c_master, config->i2c_addr,
			     &reg_addr, 1, &raw_coef, 18);

But that's obviously not a proper solution of this problem. The i2c_nrfx_twim driver needs to be improved to handle also transfers from flash (use some internal buffer and copy there the provided data from flash to overcome the limitation of the TWIM peripheral).

@anangl,
Thanks for the suggestion. So after making similar changes (or should I say hack) across the DPS310 driver code, basically, getting rid of static const uint8_t especially for the register addresses and the buffer to be written, I have managed the driver to work and fetch the sensor values.
Now all the i2c_write_read() calls within this driver are working as expected without error values.
For now, I will make the changes to the DPS310 driver and use it as a local driver rather than directly fetching it from Zephyr's driver library.
Thanks and I hope in the future release this issue will be hopefully fixed for all the related drivers or the core i2c driver itself.

@anangl do you want to open an enhancement and close this?

@carlescufi I think it is fine to keep this issue opened as a bug. This missing feature of the i2c_nrfx_twim driver actually causes the DPS310 driver to not work on nRF9160, so that's something that needs to be fixed.


build(fabric): rm fabric and the corresponding actions

This PR is the following task of PR714 https://github.com/pycontw/pycon.tw/pull/774

Codecov Report

Merging #968 (47b5436) into master (c28aeb3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   75.05%   75.05%
=======================================
  Files          80       80
  Lines        3083     3083
=======================================
  Hits         2314     2314
  Misses        769      769

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c28aeb3...47b5436. Read the comment docs.

Codecov Report

Merging #968 (47b5436) into master (c28aeb3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   75.05%   75.05%
=======================================
  Files          80       80
  Lines        3083     3083
=======================================
  Hits         2314     2314
  Misses        769      769

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c28aeb3...47b5436. Read the comment docs.


poe power switch, client reconnect, pr #553 added

port_overrides objects added to switch poe power of single port. Based on this:
https://github.com/alxwolf/ubios-poe_switch/
@jens-maus
Perhaps you would like to integrate this function in your node-unifi lib?

Thanks for the contribution. But, what about...

#553 in this context?
Have you checked https://github.com/jens-maus/node-unifi/blob/master/examples/poe-switch-onoff.js which is also an example on how to perform POE port switch on/off using node-unifi

1. [Added Structures for poe_mode and complete port-overrides #553](https://github.com/iobroker-community-adapters/ioBroker.unifi/pull/553) in this context?

oh, unfortunately I didn't see that. But a merge should work, because I translated poe_mode directly to poe_enabled. So there should be no conflict.

2. Have you checked https://github.com/jens-maus/node-unifi/blob/master/examples/poe-switch-onoff.js which is also an example on how to perform POE port switch on/off using `node-unifi`

of course i didn't see it either, thanks for the example, i implemented it almost the same way

Added Structures for poe_mode and complete port-overrides #553 in this context?

oh, unfortunately I didn't see that. But a merge should work, because I translated poe_mode directly to poe_enabled. So there should be no conflict.

Well, I haven't checked #553, but to me it looks like this older PR and yours is trying to implement the same. So please advice what to do with #553 after yours have been merged because I feel that we won't require it anymore now that with your PR you seem to have invested more time and efforts implementing POE switching.

Jens ich schreib mal auf deutsch, geht schneller.
So wie ich das sehe ist im #553 nur die Struktur für für das array port_overrides angelegt worden. Heißt alle verfügbaren properties sind angelegt - read only.
In meine PR beschränke ich mich auf poe_mode inkl. der notwendigen Funktion um die Daten korrekt zu schreiben.

Denke das das sehr aufwendig und plfege intensiv sein wird - dafür hab ich leider nicht die Zeit.

Hab noch folgendes hinzugefügt:

PR #14
client reconnect funktion

thank you @Scrounger and @jens-maus
this is really a major new feature

sorry, I got lost how to activate it... I update the adaptor to 0.6.3, Changed the instance/Adaptor settings to show
under devices - port overwrites - port , ich checked all objects... but only poe_mode is shown here... (in Port_table the port_poe_enabled is shown)
restarted the instance
I do only see the peo_mode =  auto statement...
I tried to overwrite the name, but no update...
what is wrong?  I am handeling the ports overwrite correct?

Yes perfect it worked... I was somehow confused from the discussion above... (and also wondering why all other overwrite objects are getting checked)...
one thing is not so nice... the power consumpton remains in the old state...

But I can live with that - Perfect I was waiting for this feature soe time - thank You all!

ok, seems to take time to get the update... I am fine with that...
but the node in the tree is still a little confusing...?

all port overwrites are show checked here... but are not getting activated...  what is good!


Quicktype extension

Description
This is an extension for  Quicktype.io which lets you "convert JSON into gorgeous, typesafe code in any language."
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed in the metadata folder

Another extension seems to been pushed, will be making a new PR


Add Web Recorder script

Description of the change
Added the script that was missing due to integration for Wom.
However, I haven't seen this change on my local server. I couldn't launch my local server because the dependencies installation failed. I'll report it later as an issue.
I agree to the following :-

[x]   Added description of the change
[x]   I've read the contributing guidelines
[x]   Search previous suggestions before making a new PR, as yours may be a duplicate.
[x]   I acknowledge that all my contributions will be made under the project's license.

Notes (optional):

However, I haven't seen this change on my local server. I couldn't launch my local server because the dependencies installation failed. I'll report it later as an issue.

My local npm was still v6.x. I've resolved the error by upgrading to v7.x!


Add support for array selection without left index

Adds support for array selection when the left index is missing. For example: foo[:42].

LGTM


➕Privacy Policy and Terms and Conditions Pages Added

Hey @Anushkabh, @RitiChandak and @himanshu-03
issue closes #674
Below are the changes I implemented -

Added a dedicated Terms and conditions page
Added a dedicated Privacy policy page
Created A New Column named "LEGAL" in the footer section
I tried my very best to style the pages to Follow the theme of the website.
I Also Added Favicons to both the pages
I integrated the footer in the pages for smooth navigation and Navbar at top
I Added the Hover effect and transitions to the new column.

Here is the footer with new Column "Legal"

Below is the Overall implementation -
https://github.com/Anushkabh/krishiconnect/assets/131389695/e3ee38e7-facd-42e8-bd01-7adbed9a5247

@himanshu-03 @RitiChandak

@himanshu-03 @RitiChandak , @Anushkabh
please take a look

@himanshu-03 @RitiChandak , @Anushkabh
please take a look

@RitiChandak @himanshu-03
Please merge the PR

@himanshu-03 @RitiChandak , @Anushkabh
please take a look


"% Processor Time" is greater than 1000

Hi Team, I have a question about the screenshot below.
This screenshot is in the following document about container solution
https://docs.microsoft.com/en-us/azure/azure-monitor/insights/containers#monitor-containers

The query of this chart is as the screenshot below shows

As far as I know, CPU Usage should alwasys be smaller than 100 and even sometimes it comes to a multiple core computer, it should be less than (core amount * 100). However, as you can see from this screenshot, CPU Usage is always greater than 100 and sometims it's greater than 1000.
Could you please tell us how this information is collected and why it's over 100?
Thank you in advance!
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7783cfe9-0508-9a73-3923-597cbc523cda
Version Independent ID: e2dba78f-0f1a-20d1-54d8-f30084328bb0
Content: Container Monitoring solution in Azure Monitor - Azure Monitor
Content Source: articles/azure-monitor/insights/containers.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@EricZhu0510 Thanks for your comment! We will review and provide an update as appropriate.

Assigning to content author @MGoedtel for his inputs

Reassigning to #assign @Bwren who is responsible for the container-related content now (i.e. Container monitoring solution and AzMon for containers).

#reassign:bwren

#label:"TriagedFeb2021"

@ghost Very late reply obviously. We are trying to clean these up.  From what I can tell this can be due to a process using multiple processors. If it's using 3 processors at 50%, you might get a reading of 150%.  Not sure if that's your particular issue though. Did you ever resolve this issue?


model in huggingface cannot load mixtures.skops

When I load the mini model downloaded by huggingface (https://huggingface.co/benjamin/wtp-bert-mini), I could not load the file mixtures.skops, resulting in the parameter style being unable to be used during segmentation. Found through query code
https://github.com/bminixhofer/wtpsplit/blob/main/wtpsplit/__init__.py#L48
The file names are inconsistent. Change the downloaded file name from mixtures.skops to mixture.skops and you can load it successfully. I hope to modify the code or modify the file name in hf

Hi, thanks, good catch! I guess this also happened in #108. It's fixed in version 1.2.4 via https://github.com/bminixhofer/wtpsplit/commit/41821e00dd7d2a990b82426ef90c52609edc818a.


DevUI Card

Start simple at first and then we can see what we can add to it like links to the Temporal central UI etc?

We should also add the temporal version

agreed!

Should i work on adding this now or are you in the middle of any other changes?

you can now @melloware everything has been renamed

I just reported this bug to Temporal: https://github.com/temporalio/sdk-java/issues/2177


Updated Docs

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/kohirens/version-release?version=dev:4ad2affab735e1ad70bfd2c4aa1436ff42c80cff

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/kohirens/version-release?version=dev:65b04d3df8f947756229c1dd1278b49feab5326d

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/kohirens/version-release?version=dev:1f1ea459879549ca39784cc4b67df48e831cebba


:sparkles:  Replace v4 module references with v5

What kind of change does this PR introduce?
release prep

[X] PR title follows the guidelines defined in our pull request documentation

What is the current behavior?
v4 referenced
What is the new behavior (if this is a feature change)?**
v5 reference

[ ] Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes
NONE (release prep)

Special notes for your reviewer
This was just a simple text replace of github.com/ossf/scorecard/v4 -> github.com/ossf/scorecard/v5.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

I'll need to look at #1441 tomorrow to double check this is all that's needed for the pre-release to work.

note: there's a few badge-related references to v4 in the README, but they don't exist yet for v5 because we haven't cut a release. we can update those references later


Online help: Counterwallet, not Counterparty

 JSON dictionary like the following:
                        {
                           "your sjcx address": {
                              "message": "your message here",
                              "signature": "base64 signature from bitcoin\
                                             wallet or counterparty",
                           }
                        }

Where is this?

./downstream --help, I believe (on iPad now, cannot verify)


Move the Spring Auto-Configuration doc to opentelemetry.io

Related to https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/10083
Move and adapt the documentation Readme: main/instrumentation/spring/spring-boot-autoconfigure/README.md

Preview: https://deploy-preview-3758--opentelemetry.netlify.app/docs/languages/java/automatic/spring-boot/

@jaydeluca The Jaeger exporter and Jaeger Spring Boot starter will be removed from the 2.0 version (https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/10241/files). I think we could remove all the Jaeger content from this PR.

@jeanbisutti thank you for all the guidance and feedback. I believe I have made the changes according to your recommendations but please let me know if I've misunderstood if there are any additional changes or areas to work on further

/fix:format

/fix:format

@open-telemetry/java-approvers PTAL!

Thanks @jaydeluca!
I would let the ### Additional instrumentations part in the OpenTelemetry starter. The reason is most users should be interested by the OpenTelemetry starter. The Other Configurations part is for things that should not interest mot users.
So, we would have something like this:
OpenTelemetry Spring starter
Automatic instrumentation with Spring auto configurations
Additional instrumentations
JDBC Instrumentation
Logging Instrumentation
Instrumentation Annotations
Other instrumentations

Hi @jaydeluca I have a look at the Spring Boot page version, I may have badly explained what I had in mind. What do you think about this version?

@jaydeluca Could you please rebase and integrate this content?

There are some spelling issues with the PR:
Warning: Unknown word (webflux)
Warning: Unknown word (webmvc)
Warning: Unknown word (webmvc)
Warning: Unknown word (webflux)
Warning: Unknown word (webflux)
Warning: Unknown word (autoconfigures)
Warning: Unknown word (webmvc)
Warning: Unknown word (webflux)
Warning: Unknown word (webflux)
Warning: Unknown word (autoconfiguration)
Warning: Unknown word (autoconfigurations)
Warning: Unknown word (classpath)

I'm assuming I just need to add these to this list?

@jaydeluca - no, add them to the page-local front matter entry cSpell:ignore: at the top of the file.

Thank you @jaydeluca for this great contribution!

/fix:refcache

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/7712299869

@chalin The refcache action has not fixed the build. Could you please help on this?

@jeanbisutti - this PR needs to be manually rebased due to conflicts, so you'll need to do that first:

@jeanbisutti - this PR needs to be manually rebased due to conflicts, so you'll need to do that first:

@chalin It was rebased (no conflict with the main branch). The issue is the same.

You didn't rebase, you merged:

If you attempt to rebase you should see a conflict that needs to be resolved, at least I do:
$ git rebase main
Auto-merging content/en/docs/languages/java/automatic/spring-boot.md
CONFLICT (content): Merge conflict in content/en/docs/languages/java/automatic/spring-boot.md
error: could not apply 73587986... rebase to remove docsy changes
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
...

wow I apologize everyone, I must have taken a wrong turn when rebasing this and don't know how I ended up in this state with everyone added as a participant. I'm really sorry.

closing this PR and continuing via: https://github.com/open-telemetry/opentelemetry.io/pull/3900 to avoid spamming everyone with notifications. Sorry again.


500 HTTP error being thrown when missing required request parameter

Posting a request with a missing parameter that is required: True in swagger.yaml does not throw a 400 error but instead throws a 500 error. This seems to be the case for GET parameters and POST body (but not the body properties, which acts as expected).
Here's a test POST endpoint:
    /test:
        post:
            description: Test endpoint
            parameters:
            -   in: body
                name: body
                required: True
                schema:
                    properties:
                        my_property:
                            description: Test property
                            type: integer
                    required:
                    - my_property
                    type: object
            responses:
                '200':
                    description: An uploaded resource, including S3 URL.
            tags:
            - swagger

Sending a POST request with all the required parameters acts as expected and returns:
POST /test HTTP/1.1
Host: ****
Content-Type: application/json
Cache-Control: no-cache

{
    "my_property": 1
}

Sending a POST request with the required property, my_property, missing correctly throws a 400 error. Request:
POST /test HTTP/1.1
Host: ****
Content-Type: application/json
Cache-Control: no-cache

{}

Response:

  <title>400 Bad Request</title>

400 Bad Request

  The server could not comply with the request since it is either malformed or otherwise incorrect.

'my_property' is a required property

Failed validating 'required' in schema:
    {'properties': {'my_property': {'description': 'Test property',
                                    'type': 'integer'}},
     'required': ['my_property'],
     'type': 'object'}

On instance:
    {}

However, not sending a body at all incorrectly throws a 500 error. This doesn't even hit the view endpoint.
POST /test HTTP/1.1
Host: ****
Content-Type: application/json
Cache-Control: no-cache

Response:

  <title>500 Internal Server Error</title>

500 Internal Server Error

  The server has either erred or is incapable of performing the requested operation.

Running pip freeze | grep bravado gives bravado-core==4.2.2. Also running pip freeze | grep swagger gives:
pyramid-swagger==2.3.0-rc2
swagger-spec-validator==2.0.2\

This is also an issue with GET required query parameters.

I ran into this today and was able to get a traceback:
Traceback (most recent call last):
  File "/virtualenv_run/lib/python3.6/site-packages/bravado_core/param.py", line 181, in unmarshal_param
    raw_value = request.json()
  File "/virtualenv_run/lib/python3.6/site-packages/pyramid_swagger/tween.py", line 263, in json
    return getattr(self.request, 'json_body', {})
  File "/virtualenv_run/lib/python3.6/site-packages/pyramid/request.py", line 237, in json_body
    return json.loads(text_(self.body, self.charset))
  File "/usr/lib/python3.6/json/__init__.py", line 354, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.6/json/decoder.py", line 339, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.6/json/decoder.py", line 357, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/virtualenv_run/lib/python3.6/site-packages/pyramid_swagger/tween.py", line 464, in _validate
    return f(*args, **kwargs)
  File "/virtualenv_run/lib/python3.6/site-packages/pyramid_swagger/tween.py", line 572, in swaggerize_request
    request_data = unmarshal_request(request, op)
  File "/virtualenv_run/lib/python3.6/site-packages/bravado_core/request.py", line 66, in unmarshal_request
    param_value = unmarshal_param(param, request)
  File "/virtualenv_run/lib/python3.6/site-packages/bravado_core/param.py", line 184, in unmarshal_param
    format(str(json_error)))
bravado_core.exception.SwaggerMappingError: Error reading request body JSON: Expecting value: line 1 column 1 (char 0)


AttributeError: '_AppCtxGlobals' object has no attribute 'current_user'

The code was working perfectly untill I reached chapter about API. Now, it points to this file and piece of code:
authentication.py
in line: if not g.current_user.is_anonymous and not g.current_user.confirmed:
error: AttributeError: '_AppCtxGlobals' object has no attribute 'current_user'

Something must be missing on your version of the app. See below where g.current_user is set:
https://github.com/miguelgrinberg/flasky/blob/master/app/api_1_0/authentication.py#L22

Not really. My code is just the same as yours. Actually I though that: As in the before_request method tha call will be made before every request, how would the g.current_user be defined if you call it in the very before_request method?

The verify_password is called automatically by the login_required decorator that is attached to the before_request function. That runs first and sets g.current_user.
It would be useful if you can debug on your side to figure out why the verify_password function isn't setting g.current_user.

Thanks!
I also forgot to set g.current_user = user, the user is set as user=User.query.filter_by(email=email_or_token.lower()).first() before.


Auto Stop Idle Policy hangs on Amazon Linux 2 Instance (notebook-al2-v1)

Hi,
The auto Stop Idle Lifecycle Configuration hangs when using Amazon Linux V2 (notebook-al2-v1) platform identifier type for Notebook, the same policy works without fail on V1. Suspect this is related to python2 Python3 upgrade.
https://github.com/aws-samples/amazon-sagemaker-notebook-instance-lifecycle-config-samples/tree/master/scripts/auto-stop-idle

It seems that the environment being used for AL2 doesnt have boto3 installed. We need to modify the script. The line here [1] needs to be updated to the following:
(crontab -l 2>/dev/null; echo "*/5 * * * */home/ec2-user/anaconda3/envs/python3 $PWD/autostop.py --time $IDLE_TIME --ignore-connections") | crontab -
I also tested this change with AL1 aswell and was successful in stopping an idle notebook.
References:
[1] https://github.com/aws-samples/amazon-sagemaker-notebook-instance-lifecycle-config-samples/blob/a6b627c7de883674b3cbeefdff34947ee08aadcd/scripts/auto-stop-idle/on-start.sh#L24

try the following updated command instead of this [1]
(crontab -l 2>/dev/null; echo "*/5 * * * * /usr/bin/python3 $PWD/autostop.py --time $IDLE_TIME --ignore-connections") | crontab -
[1] https://github.com/aws-samples/amazon-sagemaker-notebook-instance-lifecycle-config-samples/blob/a6b627c7de883674b3cbeefdff34947ee08aadcd/scripts/auto-stop-idle/on-start.sh#L24


Deduplicate github action logs

Deduplicate the logs
Fixes: #1778
would like a piece of code that would break on 1 of the os's to double check if fully works

will do some testing on my fork later

Another possible approach could be to use the ::remove-matcher workflow command according to this documentation. I think how it would be used here would be to do echo "::remove-matcher owner=csc::" on non-ubuntu runners.


Clarification of task entity in the appendix

Clarification of task entity in appendix
In the current description of task-<label> it states wrt definition of task:
task
Full name: Task
Format: task-
Definition: Each task has a unique label that MUST only consist of letters and/or numbers (other characters, including spaces and underscores, are not allowed). Those labels MUST be consistent across subjects and sessions.
@satra commented in PR 1185 on the last sentence here not being clear, see here. Specifically, the question was what does this mean if half the subjects do the task and half don't? @Remi-Gau suggested to update this in general, but since it has broader implications, I made this separate issue for it.
Now my understanding is similar to @Remi-Gau's,  meaning label task-foo for subject 1 must mean the same thing as task-foo for subject 2. There is no restrictions of the type "all participants must have done all the tasks."
So I propose to extend the last sentence to say:
"Those labels MUST be consistent across subjects and sessions, meaning label task-foo for subject X must mean the same thing as task-foo for subject Y."
Opinions or objections?

"Those labels MUST be consistent across subjects and sessions, meaning label task-foo for subject X must mean the same thing as task-foo for subject Y."

@melanieganz - thank you. this is better.

I agree with this clarification

There other occurrences of this sentence that could be deleted because it appears in the definition.
For task:
https://github.com/bids-standard/bids-specification/blob/7240c43bd66395b8776b07eb3548174ab06aa9d7/src/04-modality-specific-files/09-positron-emission-tomography.md?plain=1#L82
https://github.com/bids-standard/bids-specification/blob/7240c43bd66395b8776b07eb3548174ab06aa9d7/src/04-modality-specific-files/07-behavioral-experiments.md?plain=1#L27
I have found more occurrences of "consistent across subjects and sessions" in the spec for some other labels notably for the acq one or the trc one.
https://github.com/bids-standard/bids-specification/blob/7240c43bd66395b8776b07eb3548174ab06aa9d7/src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md?plain=1#L587
https://github.com/bids-standard/bids-specification/blob/7240c43bd66395b8776b07eb3548174ab06aa9d7/src/04-modality-specific-files/10-microscopy.md?plain=1#L135
https://github.com/bids-standard/bids-specification/blob/7240c43bd66395b8776b07eb3548174ab06aa9d7/src/04-modality-specific-files/09-positron-emission-tomography.md?plain=1#L93
The acq label definition also include this sentence: https://bids-specification.readthedocs.io/en/latest/appendices/entities.html#acq
But it does not specify what is meant by "consistent" either.
In general I would not mind if that was actually a spec wide recommendations of what we mean for "consistent" once and we said it applies to all "labels". It would remove a lot of duplication I think. Also because as the spec stands right now, this recommendation does not exist for other labels which opens the door to have things like sub-01_rec-foo_T1w.nii and sub-02_rec-bar_T1w.nii where foo and bar actually mean the same thing.
Only exception I can find is for the sample label in microscopy: https://bids-specification.readthedocs.io/en/latest/04-modality-specific-files/10-microscopy.html#filename-entities.

The label MUST be unique per subject and is RECOMMENDED to be unique throughout the dataset.

But this sentence in itself could be an exception to the otherwise spec wide recommendation.
Any thoughts?
FYI: I am fine with a much smaller change, was just trying to see how we can achieve more internally consistency about what we mean by consistent... (Sorry... I had to).

achieve more internally consistency about what we mean by consistent

nicely done @Remi-Gau
a common recommendation with potential overrides sounds good to me. it may be helpful to point to the exception from the common language.

@melanieganz do you want to start this as PR or should I go for it?

achieve more internally consistency about what we mean by consistent

nicely done @Remi-Gau
a common recommendation with potential overrides sounds good to me. it may be helpful to point to the exception from the common language.

:100: agreed, thanks a lot for diving just a bit more deeply into this @Remi-Gau!

Will take care of the PR

This discussion has ended up in a merged PR. Hence, this issue is closed.


Added model_recalculate_bounds_exact()

This computes a model bound based on (transformed) vertices, instead of using per-mesh AABBs. Main reason for this is to have a much tighter bound, especially for interaction volumes, at the cost of a longer time needed to compute bounds for models with many vertices.
Note that I haven't tested this from the C# side, but the C code does compile on Linux :smile:

Btw, model_recalculate_bounds_exact() isn't called in any way, except when forced through Model.RecalculateBoundsExact(). Perhaps that call can even be offloaded to a thread/asyn, in order not to lock up the app.

Comparison on a model file I noticed the (still) quite loose bounds:
Current: center [-0, 0.26, 0], dimensions [12.43, 0.52, 11.94]

Exact: center [-4.64, -0, -4.25], dimensions [4.64, 0.52, 4.25]

This is a pretty neat feature! Do you know what level of "slower" this might be? I imagine it's probably not so bad that it'd really need to be async, but I'm curious!
I've also taken to using some of the DirectXMath functions directly for bounds stuff, I think its likely to have some good speed benefits in this loop! XMVectorMin/Max in particular, in case the compiler isn't auto-vectorizing that already. It'd be nice if you could add that here! Might also be worth hoisting the XMMATRIX conversion out to a higher scope like here, but I'm less certain about that.
I'm not genuinely concerned about optimization here, just wanted to shout out that there may be some low hanging fruit :) I'll take it either way if you're not keen on that right now!

Good suggestion on the DirectXMath functions. Just updated the patch and exact bounds computation time went from 99ms to 33ms. This is with the C API and a large unoptimized (85 visuals, 5.4M vertices and 5.4M indices) GLB file.

Wooh, that's a hefty model! Yeah, okay, I can see why that might be a good candidate for async still, I'll keep that in mind for later :) Though I'm glad to know the DXM functions helped that much!

I only now noticed that this model (one of a set I've been using for months) consists of unconnected triangles :laughing: "Blame" it on modern hardware (GTX3090) and lean software like SK to make that hardly noticeable.


Fix the the ocaml parser test for TravisCI

Travis was failing since

Parser ocaml test was linking with hh_shared.c
hh_shared.c uses `BuildInfo_kRevision'
We don't run the get_build_id step for the parser ocaml test

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


[MINOR][SQL] Rename normalizeFilters in DataSourceStrategy to be generic

What changes were proposed in this pull request?
This PR renames normalizeFilters in DataSourceStrategy to be more generic as the logic is not specific to filters.
Why are the changes needed?
These changes are needed to support PR #26751.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.

retest this please

Test build #115096 has started for PR 26830 at commit 00f677a.

The failure doesn't seem related to this PR:
[ERROR] Failed to execute goal on project spark-parent_2.12: Could not resolve dependencies for project org.apache.spark:spark-parent_2.12:pom:3.0.0-SNAPSHOT: Could not transfer artifact org.scalatest:scalatest_2.12:jar:3.0.8 from/to google-maven-central (https://maven-central.storage-download.googleapis.com/repos/central/data/): GET request of: org/scalatest/scalatest_2.12/3.0.8/scalatest_2.12-3.0.8.jar from google-maven-central failed: Premature end of Content-Length delimited message body (expected: 7,546,277; received: 524,288) -> [Help 1]

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19910/
Test PASSed.

Test build #115097 has started for PR 26830 at commit 00f677a.

Test build #115096 has finished for PR 26830 at commit 00f677a.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115096/
Test FAILed.

Test build #115097 has finished for PR 26830 at commit 00f677a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115097/
Test PASSed.


[Feature][Core] Rename result_table_name/source_table_name to plugin_input/plugin_output

Purpose of this pull request
close #8062
Does this PR introduce any user-facing change?

How was this patch tested?

Check list

[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist
Add ci label in label-scope-conf
Add e2e testcase in seatunnel-e2e
Update connector plugin_config

[ ] Update the release-note.

This is a big change. cc @TyrantLucifer @liugddx @liunaijie @dailai @Carl-Zhou-CN

Will this affect existing tasks?

@hailin0  Do we need to keep a few test cases and end-to-end tests for backward compatibility with the old version？

PTAL

This is a big change, even it's backward compatibility with the old version, but how many version should we keep backward, all the time or like 2 or 3 versions?
How about add a upgrade note on each release, in this page, introduce how to upgrade from old version (which is the minimum version).  which feature (parameters) is deprecated, moreover we can introduce the features, fixed bug.
Now we have the release-node, but it's not enough.
WDYT

how many version should we keep backward, all the time or like 2 or 3 versions

I think we should keep it indefinitely, not just for 2 or 3 versions. Perhaps after one or two years, we can revisit it to decide whether to keep or remove it, as keeping it poses no burden to us. However, we should mention in the documentation that the use of result_table_name and source_table_name is no longer recommended. cc @hailin0

How about add a upgrade note on each release version, in this page, introduce how to upgrade from old version (which is the minimum version). which feature (parameters) is deprecated, moreover we can introduce the features, fixed bug.

+1

This is a big change, even it's backward compatibility with the old version, but how many version should we keep backward, all the time or like 2 or 3 versions?
How about add a upgrade note on each release version, in this page, introduce how to upgrade from old version (which is the minimum version). which feature (parameters) is deprecated, moreover we can introduce the features, fixed bug.
Now we have the release-node, but it's not enough.
WDYT

Yes, this is what is still missing

how many version should we keep backward, all the time or like 2 or 3 versions

I think we should keep it indefinitely, not just for 2 or 3 versions. Perhaps after one or two years, we can revisit it to decide whether to keep or remove it, as keeping it poses no burden to us. However, we should mention in the documentation that the use of result_table_name and source_table_name is no longer recommended. cc @hailin0

How about add a upgrade note on each release version, in this page, introduce how to upgrade from old version (which is the minimum version). which feature (parameters) is deprecated, moreover we can introduce the features, fixed bug.

+1

Current, an outdated parameter warning will be printed in the log.

Current, an outdated parameter warning will be printed in the log.

We should metion it in doc too, let users to consciously change expired configurations. Doc more important than log.

Current, an outdated parameter warning will be printed in the log.

We should metion it in doc too, let users to consciously change expired configurations. Doc more important than log.

Added notes.


Position/index of sorted element(s) before/after moved

It would be helpful to see both the previously selected sortable and the moved element's previous position/index in that list as well as the new sortable it is a part of and its new position/index.
I see a position property, but it returns all null values. — see attached

The sortable:update event was changed to include more arguments, including the previous and the new indexes of any element being sorted within a single sortable or between two sortable instances.
The following commit addresses your suggestion:
https://github.com/marcospont/agnostic-draggable/commit/08902cd0451b6e3066a26189b8627b49f1b37e41
Thanks,
Marcos


boards/nucleo-l432kc: Add internal DAC code.

Summary

Nucleo-L432KC board was missing internal MCU DAC initialization code.
DAC is now available on PA4/A3 and /dev/dac0 when enabled.
Updated info on ADC inputs (PA6/A5,PA7/A6) depending on configuration.
Most boards have pins hadrcoded in *.h and *.c files, here too, would be nice to have them configurable via Kconfig, but there is no generic mechanism for that yet?

Impact
boards / nucleo-l432kc can now use DAC.
Testing

Build host: FreeBSD 13.3 AMD64.
Test setup: oscilloscope on A4, generator on A5 nucleo pins.
Before: DAC was not available even though enabled in the config.
After: DAC is available as /dev/dac0 and controllable with example dac application.

nsh> uname -a
NuttX 12.7.0-RC0 a94c099b7d-dirty Oct 19 2024 06:44:25 arm nucleo-l432kc
nsh> ls /dev
/dev:
 adc0
 console
 dac0
 null
 random
 rtc0
 ttyS0
nsh> adc -n1
adc_main: g_adcstate.count: 1
adc_main: Hardware initialized. Opening the ADC device: /dev/adc0
Sample:
1: channel: 11 value: 1310
nsh> dac put 1024
devpath=/dev/dac0 data=1024 delay=0
write: ret=5, errno=0
wrote: chan=0, data=1024
ret=1

[Experimental Bot, please feedback here]
Yes, this PR meets the NuttX requirements.
It clearly explains the necessary changes for adding DAC functionality to the Nucleo-L432KC board, outlines the impact on users (DAC availability) and hardware (PA4/A3 pin usage), and provides testing verification on a specific build host and target.
The suggestion for future Kconfig-based pin configuration is a valuable addition for maintainability.

Most boards have pins hadrcoded in *.h and *.c files, here too, would be nice to have them configurable via Kconfig, but there is no generic mechanism for that yet?

Pin configuration is individual to each board (it's more of a board property than a system configuration) and shouldn't be done by generic Kconfig options. Of course, there is a certain group of boards that require pin configuration (such as devkits), but then this logic should be implemented in board port code, like it's done for example here:
https://github.com/apache/nuttx/blob/2ed9bd5e716246601f3de59a999f55ad2602d83d/boards/arm/stm32f7/nucleo-144/Kconfig#L30-L35

i'm looking for a simulator so i can test my project on nucleo l432kc can you suggest some if you have any ? thanks

@cederom: Most boards have pins hadrcoded in *.h and *.c files, here too, would be nice to have them configurable via Kconfig, but there is no generic mechanism for that yet?

@raiden00pl: Pin configuration is individual to each board (it's more of a board property than a system configuration) and shouldn't be done by generic Kconfig options. Of course, there is a certain group of boards that require pin configuration (such as devkits), but then this logic should be implemented in board port code, like it's done for example ere:

Thank you @raiden00pl :-) Yes I mean the DevKits quick reconfiguration from the Kconfig we don't have that yet in any generic standard way that would be common for various different boards :-)

@nieoma: i'm looking for a simulator so i can test my project on nucleo l432kc can you suggest some if you have any ? thanks

I work on STM32 hardware. There are various QEMU approaches to emulate MCUs. For instance Espressif develops QEMU for their MCUs and I saw some support of virtualized hardware in NuttX Simulator for ESP (i.e. recent PR with OpenEthernet support but that is ESP specific). Quick search reveals there are people who works/runs STM23 QEMU but I have no experience with that sorry:

https://hackmd.io/@MarconiJiang/qemu_hardware
https://github.com/beckus/qemu_stm32


Make nobram false by default for gowin

Make nobram to false, to make it same as for other architectures.
Right not it is not possible to make yosys actually use bram due to this.
Also makes testing of parts of code for bram instantiation possible.

I'm sorry @mmicko nobram was disabled in GoWin due lack of techmap model. I have it incomplete (only DRAM). I will push that change also today so you can continue.


Add credential verification

Implement credential verification to ensure that the credentials entered are in the correct format and contain the correct URL format.
Currently, this error is thrown when not in the correct format, this should also be more descriptive:
2024-02-22 12:31:02.638 +01:00 [INF] Executed endpoint '"HTTP: GET /api/witsml-servers => GetWitsmlServers"'
2024-02-22 12:31:02.638 +01:00 [FTL] Something went wrong: System.InvalidOperationException: This operation is not supported for a relative URI.
   at System.Uri.get_AbsoluteUri()
   at WitsmlExplorer.Api.Services.CredentialsService.<>c__DisplayClass16_0.<GetSystemCredentialsByToken>b__4(ServerCredentials n) in /build/Src/WitsmlExplorer.Api/Services/CredentialsService.cs:line 143
   at System.Linq.Enumerable.WhereListIterator`1.MoveNext()

I think the relevant file in this case is WitsmlSystemCredentials.cs, before adding items to the credential list. To ensure that the application won't just fail like it does today, I think we should just skip adding the items to the list, and then log an error with a fitting message.


Feat: Improve AgroBlogs

Describe the feature
The interface can be made better for agro blogs
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Suchitra-Sahoo please assign this issues me

@Suchitra-Sahoo please assign me with this issue.


Remove hardcoded gridResolution value

See TODO at https://github.com/havochvatten/MSP-Symphony/blob/18e79a4aa23b27293f84278ed5ebd8070e09f92b/symphony-ws/src/main/java/se/havochvatten/symphony/service/ReportService.java#L128

This problem implies that calculated area will be wrong since it uses this value squared as the area of one pixel


Form data allow null value

New Pull Request Checklist

[x] I have read the Documentation
[x] I have searched for a similar pull request in the project and found none
[x] I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
[x] I have added the required tests to prove the fix/feature I'm adding
[x] I have updated the documentation (if necessary)
[x] I have run the tests without failures
[ ] I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

Form data now accept null value

The PR also requires a test and CHANGELOG update.

The PR also requires a test and CHANGELOG update.

Test added. If it's fine I will update the CHANGELOG as well.

The PR also requires a test and CHANGELOG update.

CHANGELOG updated.
Is it correct?

CHANGELOG updated. Is it correct?

No. Take https://github.com/cfug/dio/pull/1794/files as the example.

CHANGELOG updated. Is it correct?

No. Take https://github.com/cfug/dio/pull/1794/files as the example.

Ok, fixed.
Let me know if I have to do anything else.


taproot on hard wallets zh translation

A Chinese translation of 'taproot on hard wallets' in Advancing Bitcoin 2022.

thanks @editor-Ajian!


Correct module url in go.mod after repository name change

Change to correct the error bellow:

Why this error occur

@lucasfloriani Thank you for pointing out 🙏


Create pages for genres, and create Browse page listing genres

Similar to tags, pages should be created for each genre, listing all works of that genre.
And similar to OffprintStudios/dragonfish#736 , these pages should be listed on one Browse page.

this is now implemented as of 1.0.0-alpha.10


Cluster shows active even thou I deleted it on provider side

Rancher versions: 2.0 master 4/2
Steps to Reproduce:

Create a Cluster (I used GKE)
Delete the cluster on the provider side (I went to gke and deleted from there)

Results:  Cluster still shows active.  Should do check to make sure we can still communicate with cluster and if we can't, change state.

Can not reproduce the issue.
I am using rancher/server:master 4/9

@tfiduccia can you try again?

So the Cluster shows unavailable, but the nodes (which have been deleted), still show active now.  Shouldn't the nodes also show unavailable?

closing in favor of #12176


Resolve issue with focus being lost on search box after selecting a user

Details
Expected behavior:

Open the New Group page
Start typing the name of a user, and then select from the list of results.
Then if the search input was focused before the option was selected from the list, then the search input should retain focus, and the previous input value should be highlighted.
If the search input was not focused before the option was selected from the list, then the search input should not regain focus. Clicking on the search input should highlight the previous value, not clear it.

Fixed Issues
https://github.com/Expensify/App/issues/6470
Tests

Open the New Group page
Start typing the name of a user, and then select from the list of results.
If the search input was focused before the option was selected from the list, verify that it retains focus and the input value is highlighted.
If the search input was not focused before the option was selected from the list, click on it and verify that the input value is highlighted.

QA Steps

Open the New Group page
Start typing the name of a user, and then select from the list of results.
If the search input was focused before the option was selected from the list, verify that it retains focus and the input value is highlighted.
If the search input was not focused before the option was selected from the list, click on it and verify that the input value is highlighted.

Tested On

[x] Web
[x] Mobile Web
[ ] Desktop

The problem is present on Web and Desktop, but i have no way of testing the macOS desktop app
Screenshots
https://user-images.githubusercontent.com/9059945/147157544-0b512212-bfb7-43ed-808f-2ff3a5d3541a.mp4

Please test it on Android and sign your commits.

The original issue states that this problem occurs only on Web and Desktop platforms.
On Android textInput never loses it's focus, it stays focused even when we press on OptionRow.
The only difference I can see between Android and web is that, since on Android textInput never loses it's focus, selectTextOnFocus is useless (there's only one onFocus when the component first renders) and text is not selected when we press on OptionRow. Should text be selected after selecting a user on mobile platfroms too?

Should text be selected after selecting a user on mobile platfroms too?

Exactly. Unless Mobile platforms create some challenges for us and do not affect anything, we can keep the same behavior for all devices.

Exactly. Unless Mobile platforms create some challenges for us and do not affect anything, we can keep the same behavior for all devices.

There is a challenge i bumped into.
React-Native's textInput does not have a select() method, so there's no way to select text programatically. And since input doesn't lose it's focus, selectTextOnFocus is irrelevant.
We could, however, check for mobile platform in selectRow method, call .blur() and then immediatelly .focus(), that way text inside textInput will be selected.
But it results in keyboard being dismissed for a moment, which does not look good.

Lets select the text on native instead.
this.textInput.setNativeProps({selection: {start:0 , end: content.length}});

Do you think this will work?

Do you think this will work?
Yup, I've verified it working, thank you.
We will also need to call this.textInput.setNativeProps({selection: null}) on textInput's onChangeText.

So I'm gonna close this PR, sort-out issue with my commits not being signed and will create a new pull-request, right?

Whatever is easier for ya. You can also rebase the commits instead of creating a new PR. But I leave that part up to you.


Overflow/Panic/Infinite Loop when connecting to Sql Server from Blazor Server app

Good morning everyone,
Apologies for the vagueness of the title, I'm unsure how to describe the issue I'm facing.
The code below (codebehind for razor page in BlazorServer application) hits var visits = this.VisitRepository.ListAsync().Result; but never makes it to this.Visits = visits when retrieving data from an Sql Database, using an In-Memory Database works just fine.
I've tried F11-ing through the code but have been able to deduce anything meaningful to aid debugging.
`public partial class Request
{
[Inject]
private IRepository VisitRepository { get; set; }
private List<Visit> Visits { get; set; }

projected override void OnInitialized()
{
    base.OnInitialized();
    var visits = this.VisitRepository.ListAsync().Result;
    this.Visits = visits;
}

}`

Entity Framework logs and Sql Server traces both report that the related database query is completing successfully
BlazorServer trace logs show that websockets are still pinging and getting a response, but the UI is completely unresponsive

Querying the DbContext directly (e.g. below) works fine but clearly breaks all of the patterns this library supports
`public partial class Request
{
[Inject]
private AppDbContext DbContext { get; set; }
private List<Visit> Visits { get; set; }

projected override void OnInitialized()
{
    base.OnInitialized();
    var visits = this.DbContext.Visits.ToList();
    this.Visits = visits;
}

}`
I've tried putting a service class in between the Request page and IRepository which has the same result.
My current working theory is that there's some conflict between the Blazor Server request lifecycle and the way Ardalis.Specification handles Sql Connections but at this point I'm clutching at straws.
Sincerely grateful for any thoughts, opinions or otherwise

Hi Fiseni,
Thank you very much for taking the time to reply.
I clearly missed that ToList vs ToListAsync - ToListAsync causes exactly the same issue.
For anyone else coming across this issue, the resolution is to override the OnInitializedAsync method of the Razor Page, working code below:
`public partial class Request
{
[Inject]
private IRepository VisitRepository { get; set; }
private List<Visit> Visits { get; set; }

protected override async Task OnInitializedAsync()
{
    await base.OnInitializedAsync();
    var visits = await this.VisitRepository.ListAsync();
    this.Visits = visits;
}

}`
Thanks again to Fiseni for your help.