special DNS record for host.docker.internal + gateway.docker.internal

I was not able to find "magic" for mac and windows systems about 'host.docker.internal' and all solutions in the Net just workarounds. Here I am with my solution... Maybe it's not the best, but it works just fine.
Yes, this functionality can be implemented with dnsmasq, but not everyone can do it by themselves. That's why i find this PR useful

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:0xbad0c0d3/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

When can we expect it to be merged into master branch?

The way docker does DNS by default is fundamentally broken. It should always use dnsmasq and the host's DNS configuration by default (and not use <IP_ADDRESS>). Each container should (by default) resolve DNS by querying the host, which should forward the request to its own resolver, and provide resolution for all of .docker.internal, including host.docker.internal. All other accessible containers should also resolve in .docker.internal

Any idea when this will be merged? :slightly_smiling_face:

When will this nice feature be merged?

I have been watching this one, we have Linux members on the team that have this record broken which seems bizarre that Windows and Mac would have this record and not Linux

Dev team is using this one, and when are pushing things on production - we are in a great challenging situation. Any anticipated fix date?

Dev team is using this one, and when pushing things on production - we are in a great challenging situation. Any anticipated fix date?

Hello,
if you really need a feature like this before it has been merged, you can do something like this. In our Dockerfile, we override the entrypoint.sh with something like this:
#!/usr/bin/env bash
set -x
set -e
function fix_linux_internal_host() {
DOCKER_INTERNAL_HOST="host.docker.internal"
if ! grep $DOCKER_INTERNAL_HOST /etc/hosts > /dev/null ; then
DOCKER_INTERNAL_IP='/sbin/ip route | awk '/default/ { print $3 }' | awk '!seen[$0]++'
echo -e "$DOCKER_INTERNAL_IP\t$DOCKER_INTERNAL_HOST" | tee -a /etc/hosts > /dev/null
echo "Added $DOCKER_INTERNAL_HOST to hosts /etc/hosts"
fi
}
fix_linux_internal_host
/usr/local/bin/gosu jboss:jboss bash -c "/opt/jboss/wildfly/bin/standalone.sh $@"
Be aware, that you need to do this as root user, so the change to a specific user needs to be done within entrypoint.sh (in our Wildfly version via gosu).
Afterwards, you have a "host.docker.internal" available within your container.

Again, that workaround is known, but not generally practical for complex deployments

Again, that workaround is known, but not generally practical for complex deployments

I know that, thats why its called "workaround". But until the final solution is merged and available, it IS a possibility.

@schildbach, done

Let’s merge that bad boy! 😛

Any day now for this merge! :D

If i'll remove it it will brake check section in CI
https://circleci.com/gh/docker/libnetwork/8545
чт, 2 мая 2019 г. в 13:17, Andreas Schildbach<EMAIL_ADDRESS>
@schildbach commented on this pull request.
In sandbox.go
https://github.com/docker/libnetwork/pull/2348#discussion_r280359507:

@@ -133,7 +133,8 @@ type containerConfig struct {
}

const (

resolverIPSandbox = "<IP_ADDRESS>"

resolverIPSandbox  = "<IP_ADDRESS>"

It doesn't matter who or what produced it. It's a change that doesn't
belong to the title of this PR. As such, it will distract any reviewers of
this PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/docker/libnetwork/pull/2348#discussion_r280359507,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABRBMANTHSJPMQLC2XQBIS3PTK5URANCNFSM4G4UBRQA
.

Totally agree with you about the history and will keep in mind for future
;)
On Thu, 2 May 2019, 23:33 stativ<EMAIL_ADDRESS>wrote:

@stativ commented on this pull request.
In sandbox.go
https://github.com/docker/libnetwork/pull/2348#discussion_r280585254:

@@ -133,7 +133,8 @@ type containerConfig struct {
}

const (

resolverIPSandbox = "<IP_ADDRESS>"

resolverIPSandbox  = "<IP_ADDRESS>"

Another advice, though I don't know whether this applies to docker
specifically, but you usually update the pull request, rather than adding
more commits that fix the problem in the original pull request.
The reason is to keep the repository history clean and concise.
What I mean, it's better to have a commit that implements the desired
functionality (or a logical part of it) without any unrelated changes such
as code reformatting, and then another commit that does the reformatting.

But to end on a more positive note - I really hope this will get merged
soon (whatever version will be accepted by the devs). It's an incredibly
useful functionality.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/docker/libnetwork/pull/2348#discussion_r280585254,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABRBMAMRM3ST65RFZRQRT7DPTNFZPANCNFSM4G4UBRQA
.

/cc @arkodg

@0xbad0c0d3 Sorry about the delayed response. couple of questions/comments :

I think this change will not have any effect for the default bridge (docker0) network since it doesn't use the built-in SD resolver. If we need this behavior for all  the networks, then we will unfortunately have to tamper with the /etc/hosts of the container in the docker0 bridge networks.
What are the expectations of this fix in d4mac and d4win ? This will ofcourse return the gateway ip of the bridge which is local to the VM hosting the docker daemon. But wont directly point to the mac or win host. Will it satisfy the requirement ?

@0xbad0c0d3 have not tried this out but AFAIK this will break Docker Desktop (Mac and Windows) . Today this works on Desktop through a magic proxy called vpnkit running on OSX host ( ps -e | grep com.docker.vpnkit ) for more info which allows you a way to reach the OSX host via host.docker.internal (the DNS proxy in vpnkit sends this A record to the VM)
By adding a SRV Record in the DNS Server in the dockerd daemon that maps host.docker.internal to the Gateway-IP, containers running in a native Linux environment will be able to reach the Linux Host , but on MAC, containers will be sending traffic to the Linux VM and not the OSX host
If users were able to insert A records into dockerd's DNS server through cmdline/config options and so custom mappings such as host.docker.internal could be mapped to the Host IP / or interface, this functionality could be achieved (Note: this would not work for default docker0 bridge, since for this case, the host's resolv.conf is mounted so the nameserver does not point to dockerd). I will bring up this feature with the team .

@0xbad0c0d3 have not tried this out but AFAIK this will break Docker Desktop (Mac and Windows) . Today this works on Desktop through a magic proxy called vpnkit running on OSX host ( ps -e | grep com.docker.vpnkit ) for more info which allows you a way to reach the OSX host via host.docker.internal (the DNS proxy in vpnkit sends this A record to the VM)
By adding a SRV Record in the DNS Server in the dockerd daemon that maps host.docker.internal to the Gateway-IP, containers running in a native Linux environment will be able to reach the Linux Host , but on MAC, containers will be sending traffic to the Linux VM and not the OSX host
If users were able to insert A records into dockerd's DNS server through cmdline/config options and so custom mappings such as host.docker.internal could be mapped to the Host IP / or interface, this functionality could be achieved (Note: this would not work for default docker0 bridge, since for this case, the host's resolv.conf is mounted so the nameserver does not point to dockerd). I will bring up this feature with the team .

I was thinking about possibility to manage this feature with cmdline option, but, I am new in go, and do not have time to implement it, more because i could not test it on WIN/MAC systems... But, i think it's easy to detect OS family and apply my "fix" for linux only. Also, i realized that it would not work with docker0 because of the resolv.conf.

@0xbad0c0d3 dockerd for both the scenarios (Mac and Linux) is running on Linux 😄 , for the Mac case it happens to be a VM .
https://docs.docker.com/engine/reference/commandline/run/#add-entries-to-container-hosts-file---add-host documents how you can use the --add-host argument to add entries to your container's /etc/hosts so something like docker run --add-host=host.docker.internal:<IP_ADDRESS> --rm -it alpine ping host.docker.internal should help you reach the Linux host, but please do not add this argument while running containers on Mac or Windows

@0xbad0c0d3 dockerd for both the scenarios (Mac and Linux) is running on Linux  , for the Mac case it happens to be a VM .
https://docs.docker.com/engine/reference/commandline/run/#add-entries-to-container-hosts-file---add-host documents how you can use the --add-host argument to add entries to your container's /etc/hosts so something like docker run --add-host=host.docker.internal:<IP_ADDRESS> --rm -it alpine ping host.docker.internal should help you reach the Linux host, but please do not add this argument while running containers on Mac or Windows (https://docs.docker.com/docker-for-mac/networking/)

--add-host is requiring extra work, you have to configure interface first (add alias IP), then modify all your containers to be run with --add-host, or install dnsmasq, configure it...rather than just enjoying the feature "out of the box".

@mavenugo as you suggested i'e wrapped this functionality with if ep.needResolver() and, also, with runtime.GOOS == "linux"

what's the deal with what's left on this in order to merge? :) just wondering.

It seems there are a lot of platform dependent details that, if not addressed, may cause some bad side effects. In general, the name resolution in docker seems poorly designed and fragile.

Any updates on this yet? Waiting for it to merge!

Me too!

PTAL @arkodg

@0xbad0c0d3 want to reiterate that this code will break Docker Desktop on Mac and Windows, what is needed is

a dockerd configuration flag called --dns-resolve-docker-host or something similar (such as --iptables) which needs to be added to https://github.com/moby/moby and enabled by default
Based on that flag we can programtically add a DNS entry (either in moby/moby or libnetowrk) that maps host.docker.internal to docker0's IP
Docker Desktop internally can then override this flag when creating a VM and spawning dockerd so that all these DNS requests go to its special proxy outside the VM

cc: @thaJeztah @justincormack @djs55

@0xbad0c0d3 want to reiterate that this code will break Docker Desktop on Mac and Windows, what is needed is

a dockerd configuration flag called --dns-resolve-docker-host or something similar (such as --iptables) which needs to be added to https://github.com/moby/moby and enabled by default
Based on that flag we can programtically add a DNS entry (either in moby/moby or libnetowrk) that maps host.docker.internal to docker0's IP
Docker Desktop internally can then override this flag when creating a VM and spawning dockerd so that all these DNS requests go to its special proxy outside the VM

cc: @thaJeztah @justincormack @djs55

@arkodg, I doubt about windows and not pretty sure about Mac... because of:
if ep.needResolver() && runtime.GOOS == "linux"
If on windows you have GOOS=linux - i think you need to reinstall windows :D

For Desktop for Mac Docker spawns a Linux VM and creates dockerd inside that VM so runtime.GOOS == "linux" will evaluate to true, and I believe in Windows too there's an option to create a Linux VM for Linux containers which will also evaluate the above cmd to true

(I work on the Docker Desktop Mac + Win DNS proxy in vpnkit). @arkodg is correct -- on both Mac and Windows we run Linux containers inside a Linux VM where runtime.GOOS == "linux" so adding a DNS record conditionally on that would break host.docker.internal because it would point inside the VM rather than on the host as expected.
If this feature is conditional based on a command-line argument (e.g. --dns-resolve-docker-host) then in Desktop we can disable this feature when we start dockerd and fall back to our existing vpnkit proxy. We could then have the same feature on Mac, Windows and Linux.

Will this ever be merged?

Please merge. This is basic functionality.

@0xbad0c0d3 want to reiterate that this code will break Docker Desktop on Mac and Windows, what is needed is

a dockerd configuration flag called --dns-resolve-docker-host or something similar (such as --iptables) which needs to be added to https://github.com/moby/moby and enabled by default
Based on that flag we can programtically add a DNS entry (either in moby/moby or libnetowrk) that maps host.docker.internal to docker0's IP
Docker Desktop internally can then override this flag when creating a VM and spawning dockerd so that all these DNS requests go to its special proxy outside the VM

cc: @thaJeztah @justincormack @djs55

@arkodg I've implemented trough dns-opt, to switch the feature on --dns-opt resolve-docker-internal should be passed to dockerd command

@0xbad0c0d3 according to https://docs.docker.com/v17.09/engine/userguide/networking/default_network/configure-dns/
--dns-opt is specific to resolve.conf, having a new flag in moby is the way to go IMHO

I can't understand, why this request is not merged. For us in an agency, we need a workaround for linux. Otherwise for WIndows or OSX, but this is the regular thing.
There are round abound more than 400 "likes" for this feature and there is nothing technical, why this can not merged.
So please merge this request.

@0xbad0c0d3 according to https://docs.docker.com/v17.09/engine/userguide/networking/default_network/configure-dns/
--dns-opt is specific to resolve.conf, having a new flag in moby is the way to go IMHO

@arkodg Generally - you are right, but in other way it requires another PR directly to docker engine, or I am wrong?

@0xbad0c0d3 I think this issue can be solved completely in moby with --dns-resolve-docker-host and ExtraHosts. I can look into this next week

@0xbad0c0d3 thanks for highlighting this issue, I've raised a similar PR in moby https://github.com/moby/moby/pull/40007 that solves this issue using the the below approach

a dockerd configuration flag called --dns-resolve-docker-host or something similar (such as --iptables) which needs to be added to https://github.com/moby/moby and enabled by default
Based on that flag we can programtically add a DNS entry (either in moby/moby or libnetowrk) that maps host.docker.internal to docker0's IP
Docker Desktop internally can then override this flag when creating a VM and spawning dockerd so that all these DNS requests go to its special proxy outside the VM

Any idea when this will be merged?

need this, please add  it

MERGE MERGE MERGE!

Looks like it will take another 3-4 months to actually solve all the dependency problems

FYI for people who have been watching this like a hawk, dialogue has been going on here between members of the Moby team: https://github.com/moby/moby/pull/40007

is this scheduled?

@0xbad0c0d3 can you please close this PR in favor of https://github.com/moby/moby/pull/40007


[zh-cn]fix intro.md

Follow up on https://github.com/kubernetes/website/issues/35059
Updated Windows containers in Kubernetes page.

Hold until upstream change merged.
/hold

Hold until upstream change merged. /hold

The upstream has change

@Sea-n cc

Please run ./scripts/lsync.sh content/zh-cn/docs/concepts/windows/intro.md script.
There is another typo fix in upstream.

@Sea-n cc

/approve

/unhold


Add basic support for multiple tabs

Please check if the PR fulfills these requirements:

[ ] The commit message follows our code of conduct and contributing guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added / updated (for bug fixes / features)

Please include the following information in your pull request:

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Any other information (if needed):

Thanks for opening the PR! Can you resolve the merge conflicts?

@all-contributors add @mohebifar for code and bug fixes

stale. closing this out.

@grzim will take care of this feature. thanks mo for the work here. hope to see your future contributions soon. cheer.


Fix typo for hint in meta description video

Here is the current feedback
Refer back to the middle of the video where there are examples showing where the page's descriptions typically shows up.

It should be show up not shows up
Refer back to the middle of the video where there are examples showing where the page's descriptions typically show up.

Here is the file you need to change:
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/25-front-end-development/lecture-html-fundamentals/67083952f800051a8a21fcfd.md

This has been opened for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors.
If you would like to contribute and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/
If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum
Happy coding


fix(app): update cli for singleton config

This change updates @janus-idp/cli to 1.13.2 which contains an update to the singleton configuration for federated modules to fix issues where styles do not correctly apply to MUI v5 components that are loaded from a dynamic plugin.  This change is half of the solution, dynamic plugins that are affected by this issue would need to be rebuilt with the same @janus-idp/cli version.
Description
Please explain the changes you made here.
Which issue(s) does this PR fix
This issue fixes RHIDP-3471
PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

/cherry-pick release-1.3


raftstore: move sst cleanup (compact range) task to its own thread

Signed-off-by: Yi Wu<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: close #9044
Problem Summary: move sst cleanup task to its own thread. It fixes deadlock when compaction guard is enabled, and there are few thread in the background_worker pool.
What is changed and how it works?
What's Changed: Revert changes done in #8821 which move sst cleanup task to background_worker pool. The cleanup task will fire compact range, which is a blocking call and can take up to minutes. Meanwhile when compaction guard is enabled, the feature will schedule a task to fetch regions in the compaction range, which is also executed in the background_worker pool. When there's few background_worker pool thread (the pool size is min(4, max(1, (#cpu +7)/8)), so there could be only 1 thread when #cpu <= 8), it could cause a deadlock.
Despite the deadlock, having SST cleanup task sharing the background_worker pool is bad, since it could take an extensive amount of time, it could delay other tasks in the thread pool.
Related changes
compaction guard was added in #8115. SST cleanup task worker is merged with background worker in #8821.
Check List
Tests
CI
Release note

No release notes.

@Little-Wallace @hicqu do you have advice on what I should test other than CI? Thanks.

Which worker does the task fetch regions run? Could we refresh this region info async and get it in rocksdb pool directly?

@yiwu-arbug Maybe you can adjust default value of background_thread_count to 2 to PASS CI at first.....

Which worker does the task fetch regions run? Could we refresh this region info async and get it in rocksdb pool directly?

Also good suggestion, but maybe not making the change right now. I'm not sure why RegionInfoProvider implemented in the current way, and was just reusing the logic.

/merge


pull request for e2e test at 11/19/2016 11:56:06

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add option to mark issues that wasn't reported via issue forms

Type of issue
Feature Request
Description
As discussed in https://github.com/systemd/systemd/issues/23968#issuecomment-1201036765 it would be useful to be able to mark issues that bypassed issue form.
/cc @evverx
Describe the solution you'd like
Introduce new optional input that would take name of label, which would be set when issue forms were bypassed.

Blocked by: https://github.com/stefanbuck/github-issue-parser/issues/26


findViewById within a MessageListAdapter

When i use "MessageListAdapter".setOnMessageClickListener into the
onMessageClick i would like to get the View which i suppose it's a TextView
from the MessageListAdapter object by using the findViewbyId method.
What i'm missing its how do i get the View id that i should pass to findViewById method ?!?
The thing i need to do is to change the color of a part of the text dynamically and that's why i need the TextView.

Hello @teslazero !
To get access to views in message items you need to create your own holders (for both incoming and outcoming) which must be extended from IncomingMessageViewHolder and OutcomingMessageViewHolder respectively. Than you will have an access to protected fields (in this case - TextView) and will have ability to change its behavior in onBind(Message message) method.
And don't forget to register your holders via HoldersConfig object:
MessagesListAdapter.HoldersConfig holdersConfig = new MessagesListAdapter.HoldersConfig();
holdersConfig.setIncomingHolder(CustomIncomingMessageViewHolder.class);
holdersConfig.setOutcomingHolder(CustomOutcomingMessageViewHolder.class);;
adapter = new MessagesListAdapter<>(senderId, holdersConfig, imageLoader);

P.S. Looking ahead, i can assume that you want to linkify your messages. If it's true - you can wait a few days for a new library version, where we already implemented this features
Best regards, Alexander


3x notifications per notification from web app

Application version: 3.1.0
OS: Windows 11 23H2 22631.3880

Steps to Reproduce:

Install station
Add groupme
Log in, let it sit and wait for something to happen
See the same notification 3x in windows notification center, one after another. If you get 5 notifications from GroupMe, you will get 15 notifications from Station.

Windows 10: non reproducible. Only one notification per message.
I doubt that Windows version is important here

I'm experiencing the same challenge with 3.3.0
Windows 11
app: Google (mail, calendar, chat all do this)
Behavior, multiple toast notifications for every event in these apps.


Subdirectory navigation

Navigating to subdirectories should work
Example: if o/google/ maps to google.com, going to /o/google/mail/ should yield gmail.

It might be a good idea to also allow someone to explicitly create a link to a subdirectory, which should override the default behavior. For example, o/modsim/fa17/ might go somewhere different than o/modsim/


Lua support

This PR adds support for Lua via neovim internals

This looks familiar 👀

Yes, I renamed the branch at my side and this cause the PR to close...

Sorry I was being silly 😅 I'm playing with it now, thank you for creating this! Were you evaluating using tree-sitter to select forms or using visual / range evals?

Both. But TS support seems not that good. The optimal way, I think, is to use nvim-treesitter-textsubjects to select, and call evaluation on selection.

Also, lua is strict on local variables, which will be clear to nil from evaluation to evaluation. One have to use global ones to preserve values. This is the same behavior as lua's REPL, but maybe it can be fixed?

Yep, I had the same issues with evaluating Fennel. I eventually wrapped up the Fennel REPL implementation in a continuation based stateful function that allows me to create one eval context per buffer. This maintains local contexts between buffers which makes logical sense to the user I think.
Something like that for this would be fantastic... maybe with continuations again but I'm not sure how to do it right now. I'll have a think, maybe this will be good enough for now then we can add buffer local contexts later. I also want to look at keeping the HUD up after doing a visual eval since that's annoyed me for a while.

I make a list of what to improve here (but maybe some of them is not doable):

Investigate the way tree-sitter select nodes, and fix them. (maybe via other PRs)
Investigate the behavior of HUD so that it will appear after each evaluation. (maybe via other PRs)
preserve locals across evaluation. (may not be doable)
Non-blocking evaluation.

I think tree-sitter and HUD improvements are definitely possible. Preserving locals requires us to be able to store contexts and reuse them between evals (I have high hopes for this being possible!) but the non-blocking won't be possible I don't think.
Since Neovim is single threaded and the Lua interpreter is embedded within Neovim we're relying on that single process. So any Lua work MUST block until it's done. Unless maybe we create some sort of libuv threads but that'll probably lead to very very very weird bugs and problems. Neovim was not designed for that so I wouldn't want to mess with that ideally.

OK, I'll invest some time to the first 3 issues later.

I'm fixing the HUD one now 🙂  I have a fix, just working on config and naming.

Sorry my change to the config added a conflict but make compile will fix it, no big deal.

Would you be okay with me merging this to develop and resolving the conflict? You can open subsequent PRs but I'd like to get this onto develop in it's current state so I can work on it too and get people looking at it / trying it 😄

Cool, let's go! Thank you for this, it's really cool! The HUD thing should be fixed already on develop too 🙂  added a minimum lifetime to the HUD for passive closing on cursor move which should catch all cases of cursor movement after eval.

Merged! ❤

I don't think the eval with persistent locals will be possible because I spent about a month trying to do it before for Aniseed. Here's a quick attempt but it doesn't work, just remembered it's probably what I tried first ages ago.
(defn lua-repl []
  (let [env {}]
    (setmetatable env {:__index _G})
    (fn [code]
      (let [f (assert (loadstring code "some-chunk-name"))]
        (setfenv f env)
        (f)))))

(let [r (lua-repl)]
  (r "local n = 10")
  (r "print(n)"))

n is nil in the second eval, so you can set the env of the eval but it won't mutate the env table for reuse. That's the part I could never work out.
I got it working for Aniseed by hacking around with the REPL in fennel.lua, that does a LOT of work to make this possible since it's almost an entire stand alone interpreter. If we can work out a way to introspect the env of a function call or eval we can pull out locals and preserve them for the next eval.
If we can't then this will just have to remain a caveat of this client until someone basically writes a Lua in Lua interpreter that works flawlessly and exposes the locals each eval defines 😅

I don't agree.
-- WARN: please keep this default to be true!!!
_G._PAUSE_COLLECT_LOCALS = true
function _G.collect_locals(_, _)
  if _G._PAUSE_COLLECT_LOCALS then return end
  _G._PAUSE_COLLECT_LOCALS = true
  _G._LOCALS = {}
  local i = 1
  while true do
      local n, v = debug.getlocal(2, i)
      if not n then break end
      _G._LOCALS[n] = v
      i = i + 1
  end
  _PAUSE_COLLECT_LOCALS = false
end
debug.sethook(collect_locals, 'r')

function _G.call_and_collect(f, ...)
    _G._PAUSE_COLLECT_LOCALS = false
    f(...)
    _G._PAUSE_COLLECT_LOCALS = true
    return _G._LOCALS
end

function f(a, b, c)
    local d = a
    local e = b
    local f = c
end

call_and_collect(f, "hello", "world", "!")

Yeah I've experimented with this route for probably 40+ hours of tinkering, they all ended in either dead ends or "this half works and it's super hacky and scary". The best thing that ever worked for me was wrapping up the Fennel REPL in continuations, so I could continually feed code into a stateful loop that I could pause and continue (through continuations). It would spit out results through callbacks...
I think I've actually thought of a way to do that just now... using basically the code I wrote with some tweaks (there's a different function that reads chunks over time from a function) + a callback it has access to that it'll call with every eval result... it'd work just like the Fennel REPL.
It all hinges on that Lua eval function being able to evaluate each chunk on it's own or if it needs to read to the end of the string before it evaluates. I'm mostly writing this down for my own notes for some time soon when I try it 🙂 will report back in when I get some time but I'm off holiday and back at work now


Use certifi to set GDAL_CURL_CA_BUNDLE / PROJ_CURL_CA_BUNDLE defaults

Resolves #66
This makes certifi and installation requirement and follows approach from Fiona #1095 and rasterio #2459

Accidentally opened twice, so closing this one in favor of https://github.com/geopandas/pyogrio/pull/97

(moral of the story: don't use a mobile phone hotspot with low connectivity while opening PRs...)


C# auto attach to process

VSCode Version: 1.15
OS Version: Windows 10

I've Just noticed that when I try to attach to a DotNet Core process using command:pickProcess, VSCode does a good job by enumerating all system's processes with their details.
As you can see from the picture above, VSCode seems to have the possibility of auto selecting the correct process automatically without the user jumping and scrolling through all the processes available from  command:pickProcess
I have a small suggestion. Allow VSCode attach (in Launch.json) to have two new settings:
"processId":"${command:autoPickProcessWithPattern:${workspaceRoot}/bin/Debug/netcoreapp2.0/TopTen-Server.dll}",
VSCode will then lookup the string, and when it find a match, It will retrieve the pid and attach to it automatically.
That will also open another possibility for a feature that I greatly miss from Node.Js; auto re-attach on change when using "Watcher".
"restart" : "true"

The re-attach feature and the filtered process picker is something that needs to be implemented by the C#/dot net extension and you should create a new issue there.
However, as a prereq for this feature VS Code needs to support passing arguments to command-based variables. I've created a separate issue for this.


Question Marshaling vs validation

There are two common ways for validation in go (at least that I know of):

using tags (eg govalidator)
using explicit validation (like this library)

Both good libraries, but both require using a Validate() function and checking error before using the struct, which is IMO not very convenient having to check every time the struct is used.
I was having this idea of moving validation into custom Unmarshaller.
package main

import (
	"encoding/json"
        "github.com/go-ozzo/ozzo-validation"
	"fmt"
)

type Person struct {
	Name string `"json:name,omitempty"`
	Age  int    `"json:age,omitempty"`
}

func (p *Person) UnmarshalJSON(b []byte) error {
	type Alias Person
	alias := &Alias{}
	err := json.Unmarshal(b, alias)
	if err != nil {
	    return err
	}
	*p = Person(*alias)

        // define error checks here
	if p.Age < 18 {
	    return fmt.Errorf("Age must be more than 18")
	}
        // or fields could be validated by using this library
        return validation.ValidateStruct(p,
            // Age must be more than 18
            validation.Field(p.Age, validation.Min(18)),
        )

	return err
}

func main() {

	jsonPerson := []byte(`{"name":"Joye", "age":17}`)
	person := &Person{}
	if err := json.Unmarshal(jsonPerson, person); err != nil {
	    fmt.Println("error decoding json into Person: %v", err)
	    return
	}

	fmt.Println(person)

}

it just seems more convenient (having to just unmarshal rather than validate and unmarshal) also it is easier to set a default value.
could you correct me if I am mistaking or forgeting something

I think your design makes a lot of sense if you are unmarshaling from user input data (or any input data that is not trustable). If you are unmarshaling from trusted data, then doing validation within unmarshaling is not necessary and could be a performance hit when there are a lot of data to be unmarshaled.
So ultimately, the Validate method is more like a building block that you can choose to call it within or outside of the unmarshal process, depending on your use scenarios.

Indeed, the library provides more options and is covers more use cases (my idea was for one case). Thx for clarification!


Splash images

The only information in the mobile boiler plate about splash images is this:
<link rel="apple-touch-startup-image" href="img/l/splash.png">
I think the situation is significantly more complex than this. Here is a snippet which attempts to deal with the situation on the iPhone 6 and 6+, but there are obviously a lot more variants:
http://stackoverflow.com/questions/26026492/correct-size-for-apple-touch-startup-image-in-iphone-6-iphone-6-plus/26057714#26057714
Is this something you would consider adding to the mobile boiler plate?

Hey there. Thanks for reporting this. We appreciate it :) I'm going to close this as this project is deprecated.


Heatmap rendering crashes iOS when adding custom HeatmapGradient

Using a branch of flutter_google_maps with an implemented heatmap layer
I am running on iOS 13.3 iPhone XS emulator and on iPad Pro
I am currently able to display a heatmap in my app using this however when I add the gradient parameter, it seems to cause the app to crash when it tries to render the heatmap
The error I am getting is this:
*** First throw call stack: ( 	0   CoreFoundation                      0x00007fff23c7127e __exceptionPreprocess + 350 	1   libobjc.A.dylib                     0x00007fff513fbb20 objc_exception_throw + 48 	2   CoreFoundation                      0x00007fff23c91fd4 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132 	3   CoreFoundation                      0x00007fff23c75c4c ___forwarding___ + 1436 	4   CoreFoundation                      0x00007fff23c77f78 _CF_forwarding_prep_0 + 120 	5   Runner                              0x00000001044cb68f -[GMUGradient interpolateColorFrom:to:ratio:] + 255 	6   Runner                              0x00000001044cb4ca -[GMUGradient generateColorMap] + 1178 	7   Runner                              0x00000001044cd8e2 -[GMUHeatmapTileLayer prepare] + 738 	8   Runner         <…>
This is an example of my code:
This does not crash:
final Heatmap heatmap = Heatmap(
        heatmapId: HeatmapId('${heatmaps.length + 1}'),
        radius: 40,
        points: points,
        opacity: 1.0);

This crashes:
final Heatmap heatmap = Heatmap(
        heatmapId: HeatmapId('${heatmaps.length + 1}'),
        radius: 40,
        points: points,
        gradient: HeatmapGradient(
            colors: [Colors.green, Colors.red],
            startPoints: [0.1, 0.6],
            colorMapSize: 8),
        opacity: 1.0);

Hi @LucaJeevanjee, can you fill out the questions in the above issue template? This'll help us debug the issue so we can address it. Thanks!

I edited the issue to answer the questions

HI @LucaJeevanjee, I have not been able to reproduce your bug. On the SwiftDemoApp project I tested similar parameters as yours. See 2a8057f.
Curious how you are using the library? The code snippet you shared is not Swift nor Objective-C. If you can give me more info on how you are integrating the library that might help. The stacktrace you shared implies missing symbols.

I am using flutter with a custom branch of google-maps-flutter which has the heatmap feature. The heatmap seems to be working on android and ios without a gradient parameter.

Interesting! The Flutter version of this library is not something we maintain in this GitHub org.
Are you referring to this package https://pub.dev/packages/google_maps_flutter_heatmap ? If so, perhaps filing an issue in the repo linked there would allow you to receive better support.


Need Azure DevOps Pipeline expression function to access a numbered item in an array

If you have an array-typed object in a template expression (e.g. passed by parameters), you can only iterate over that array with today's syntax. There is no way to access a specific (i.e. indexed) item from that array.
Consider the following example, where a template is invoked with a defaults object that contains a list of default object specifications coming from different sources. By using a filtered-array expression it is easy to access the item property of each array-element. But there is no way to access, the first or last item (which would be very useful in this scenario).
I propose to add three new function expressions:

item(index, array)
Returns the element in array that is located at position index (0-based), or returns null if the index was out of bounds. array can be a filtered-array expression, or a YAML sequence object obtained from a parameter or variable in the current context.
If array is a string, the item returns the character located at index.
If array is neither an array, nor a string, then coerce the value into a string following normal type-casting rules.
first works like item with the index parameter set to 0 to obatin the first item.
last works like item with the index parameter set to the length of array minus 1, to get the last item in the sequence.

parameters:
- name: defaults
  type: object
  default:
    - item: default1
    - item: default2
    - item: default3
steps:
- pwsh: 'Write-Host ${{ item(1, parameters.defaults.*.item) }}'
  # Writes: default2
- pwsh: 'Write-Host ${{ first(parameters.defaults.*.item) }}'
  # Writes default1
- pwsh: 'Write-Host ${{ last(parameters.defaults.*.item) }}'
  # Writes default3

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77c58a78-a567-e99a-9eb7-62dddd1b90b6
Version Independent ID: 680a79bc-11de-39fc-43e3-e07dc762db18
Content: Expressions - Azure Pipelines
Content Source: docs/pipelines/process/expressions.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

Thanks for the suggestion! The product teams aren’t always watching this repository, so to make sure it gets in front of them for triage, please submit your idea here.

do you know if anything came out of this?

@martinmeinke -- Martin, thank you for your follow-up.  I'm not sure.  Please consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow

If you would like this functionality added, please note it here.


Update tbtc.js for redemption fix

We renamed an important var in the contracts, and need to update the dApp and client to support redemption
https://github.com/keep-network/tbtc.js/issues/51

Update coming in https://github.com/keep-network/tbtc.js/pull/52

Closed by keep-network/tbtc.js#52


Make fake-hwclock run before fsck-root

fsck is failing because of clock issues.
https://www.raspberrypi.org/forums/viewtopic.php?f=66&t=198937&p=1368234#p1368234
#351

Thank you @mdzw that sounds very promising!
I'll test that build and hopefully we get a new release out soon.

Thanks again @mdzw, works perfectly!


Set up Hugo release flow on CircleCI

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: bep:x: hugoreleaserhugoreleaser seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


node-problem-detector: 0.8.11 -> 0.8.12

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/kubernetes/node-problem-detector/releases.
meta.description for node-problem-detector is: "Various problem detectors running on the Kubernetes nodes"
meta.homepage for node-problem-detector is: "https://github.com/kubernetes/node-problem-detector"
meta.changelog for node-problem-detector is: "https://github.com/kubernetes/node-problem-detector/releases/tag/v0.8.12"
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.8.12 with grep in /nix/store/vmkk349c31z84xsjhbjnxyar6wg9kbj6-node-problem-detector-0.8.12
found 0.8.12 in filename of file in /nix/store/vmkk349c31z84xsjhbjnxyar6wg9kbj6-node-problem-detector-0.8.12

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
node-problem-detector

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vmkk349c31z84xsjhbjnxyar6wg9kbj6-node-problem-detector-0.8.12 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A node-problem-detector https://github.com/r-ryantm/nixpkgs/archive/c018ad1418171e54e77851b10a4ccc153fc41964.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vmkk349c31z84xsjhbjnxyar6wg9kbj6-node-problem-detector-0.8.12
ls -la /nix/store/vmkk349c31z84xsjhbjnxyar6wg9kbj6-node-problem-detector-0.8.12/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

node-problem-detector

Maintainer pings
cc @lbpdt for testing.

Result of nixpkgs-review pr 190601 run on x86_64-linux 1

1 package built:

node-problem-detector


Reference github oidc tests in release action

Since we moved them to a separate group #114, we need to update the release script to depend on it.

I think https://github.com/sigstore/sigstore-java/pull/147 makes this issue obsolete.


Feat: Making a new css file for index.html

Describe the feature
In the index.html there are lot of internal css so i want to create a new css file to make the index.html to view properly due to internal css the code is very clumsy so i want to create a new  css file for the index.html
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

/assign

Assigned!


is it needed to assign undefined to a variable to improve garbage recycling?

    let _bus: EventEmitter = new EventEmitter()
    // after use
    _bus = undefined

There's a variable _bus. After use, I want to assign undefined to _bus to improve garbage recycling. That's what I learned in vanilla js period.
However, I got an error:
   Type 'undefined' is not assignable to type EventEmitter.ts(2322)
So, is it still needed to do this to free the memory?

I'd rather not offer an opinion on garbage collection, which will depend a lot on the underlying code and the JS engine in use, and is not Typescript's problem.  But if you want to do this, Typescript certainly supports it:
    let _bus: EventEmitter | undefined = new EventEmitter()
    // after use
    _bus = undefined

It looks like this is a question rather than a bug report. This issue tracker is for tracking bugs and active work on TypeScript itself, rather than a general forum for programmers using TypeScript to get help or ask questions.
You can ask questions on sites like Stack Overflow. We are not able to provide one-on-one support on the issue tracker. Please read the issue template carefully - it has important information on what kinds of reports can be acted on here, as well as links to useful TypeScript resources. Thanks!


Font SimSun is not available

I used cmaps https://unpkg.com/pdfjs-dist/
google chrome console:
Warning: Error during font loading: Font SimSun is not available
I want to know how to generate SimSun.bcmap file through Windows`s *.ttf or *.ttc font file；

When opening an issue you need to provide all of the information requested in https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md, as-is this issue will be closed as INCOMPLETE since there's no actionable information provided.

The .bcmap files are generated from CMap files using the tools from https://github.com/mozilla/pdf.js/tree/master/external/cmapscompress. The CMap files we use originate from Adobe, so we don't know how they are generated exactly. This is Adobe's repository: https://github.com/adobe-type-tools/cmap-resources; I would recommend to ask there for more information.

Thank you for response..
Sorry to miss the info：
Comments do not support uploading attachments in issue, so send this email。
This pdf attachment can reproduce the problem.
you provide the Adobe's repository，i not find simsun.bacmp file，i think pdf.js framework's  cmaps Folder directory ，it‘s all .cmap files exclude font simsun。


Connection reset by peer

I use spring-data-redis with lettuce to connect redis 3.2.6
I often get the exception "Connection reset by peer"
I capture the packet on the server where my application on and on the server where redis on.
I found that when the tcp-keepalive setting took affect, the FIN  package is lost. Please the following image.So my application can not know the connection is close.
Can you tell me how to solve this problem with Lettuce. Thank you.

Please check that your Redis server does not disconnect idle clients and does not disconnect clients when a max client limit is met. There's nothing we can do as TCP business is handled by the kernel/Java I/O system.


Introduce Group Permissions

Introduce role groups to allow the assignment of multiple roles to a user simultaneously.
Enable permission checks for an entire group.
Implement a convenient interface for creating groups and assigning/removing roles to/from them.

Too much effort for something that could easily be implemented on the gem user side. As a group is just a collection of roles, such a collection can be defined anywhere in the project and then passed as roles argument to the grant_access method.


Current release of @vue/cli-service is affected by CVE-2021-27290 Regular Expression Denial of Service in ssri

Version
4.5.12
Environment info
Environment Info:

  System:
    OS: Linux 5.11 Arch Linux
    CPU: (8) x64 Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz
  Binaries:
    Node: Not Found
    Yarn: 1.22.10 - /tmp/yarn--1618510365267-0.6910111220689819/yarn
    npm: 7.8.0 - /usr/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: 87.0
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.2.1
    @vue/babel-plugin-transform-vue-jsx:  1.2.1
    @vue/babel-preset-app:  3.12.1
    @vue/babel-preset-jsx:  1.2.4
    @vue/babel-sugar-composition-api-inject-h:  1.2.1
    @vue/babel-sugar-composition-api-render-instance:  1.2.4
    @vue/babel-sugar-functional-vue:  1.2.2
    @vue/babel-sugar-inject-h:  1.2.2
    @vue/babel-sugar-v-model:  1.2.3
    @vue/babel-sugar-v-on:  1.2.3
    @vue/cli: ^4.5.4 => 4.5.11
    @vue/cli-overlay:  4.5.12
    @vue/cli-plugin-babel: ^3.5.0 => 3.12.1
    @vue/cli-plugin-eslint: ^3.5.0 => 3.12.1
    @vue/cli-plugin-router:  4.5.12
    @vue/cli-plugin-vuex:  4.5.12
    @vue/cli-service: ^4.5.4 => 4.5.12
    @vue/cli-shared-utils:  4.5.11 (3.12.1, 4.5.12)
    @vue/cli-ui:  4.5.11
    @vue/cli-ui-addon-webpack:  4.5.11
    @vue/cli-ui-addon-widgets:  4.5.11
    @vue/compiler-core:  3.0.7
    @vue/compiler-dom:  3.0.7
    @vue/compiler-sfc:  undefined (3.0.7)
    @vue/compiler-ssr:  3.0.7
    @vue/component-compiler-utils:  3.2.0
    @vue/preload-webpack-plugin:  1.1.2
    @vue/reactivity:  3.0.7
    @vue/runtime-core:  3.0.7
    @vue/runtime-dom:  3.0.7
    @vue/shared:  3.0.7
    @vue/web-component-wrapper:  1.3.0
    eslint-plugin-vue: ^5.0.0 => 5.2.3 (4.7.1)
    typescript:  3.9.9
    vue: ^2.6.10 => 2.6.12 (3.0.7)
    vue-cli-plugin-apollo:  0.21.3
    vue-cli-plugin-vuetify: latest => 2.0.7
    vue-cli-plugin-vuetify-essentials: latest => 0.8.3
    vue-codemod:  0.0.4
    vue-eslint-parser:  5.0.0 (2.0.3)
    vue-hot-reload-api:  2.3.4
    vue-loader:  15.9.6 (16.2.0)
    vue-style-loader:  4.1.3
    vue-template-compiler: 2.6.12 => 2.6.12
    vue-template-es2015-compiler:  1.9.1
    vuetify: ^2.1.11 => 2.3.14
    vuetify-loader: ~>1.4.2 => 1.4.4
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce

Require the latest stable version of the @vue/cli-service package in any app.
Run yarn audit.

What is expected?
The latest version of the software does not report any vulnerabilities.
What is actually happening?
The latest version of the software has two vulnerabilities from ssri, one from a direct dependency on the package.

My pipeline broke today once this vulnerability finally made it into the audit database.
https://www.npmjs.com/advisories/565

My pipeline has been failing since yesterday and I tried with both 4.5.11 and 4.5.12 and both fails. I reproduced it on privacy.sexy with npm install and then npm audit after cloning.

here's the npm audit report
# npm audit report

ssri  5.2.2 - 6.0.1 || 7.0.0 - 8.0.0
Severity: moderate
Regular Expression Denial of Service - https://npmjs.com/advisories/565
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/@vue/cli-service/node_modules/ssri
node_modules/ssri
  @vue/cli-service  4.0.0-alpha.0 - 4.5.12
  Depends on vulnerable versions of ssri
  Depends on vulnerable versions of terser-webpack-plugin
  node_modules/@vue/cli-service
  cacache  10.0.4 - 11.0.0 || 13.0.0 - 14.0.0
  Depends on vulnerable versions of ssri
  node_modules/@vue/cli-service/node_modules/cacache
    terser-webpack-plugin  2.1.1 - 2.3.8
    Depends on vulnerable versions of cacache
    node_modules/@vue/cli-service/node_modules/terser-webpack-plugin

4 moderate severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

It seems to be caused dependencies to ssri directly and through webpack-contrib/terser-webpack-plugin and cacache.
FYI ssri has backported the fix to 6.0.2

yeah we have the same problem, also see https://github.com/npm/ssri/pull/20

Same problem, and similar npm audit report as @undergroundwires. Is it safe to proceed creating a project with these warnings?

I Have now 3 ssri installed. 6.0.1 7.1.0 7.0.0 and 8.0.1.

package.json :
"scripts": {
    "preinstall": "npx npm-force-resolutions"
}
.
.
.
.
  "resolutions": {
    "yargs-parser": "^18.1.2",
    "ssri": "8.0.1"
  },

@dawwad Thank you. I tried, but no luck:
$ npm ls ssri
└─┬<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └─┬<EMAIL_ADDRESS>  │   └──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      └──<EMAIL_ADDRESS>deduped

I removed yargs-parser from resolutions because i don't think it's part of this solution? Or didn't i understand correctly and do i need to include that as well?

@dawwad Thank you. I tried, but no luck:
$ npm ls ssri
└─┬<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └─┬<EMAIL_ADDRESS>  │   └──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      └──<EMAIL_ADDRESS>deduped

I removed yargs-parser from resolutions because i don't think it's part of this solution? Or didn't i understand correctly and do i need to include that as well?

hey, @gerbenvandekraats,  regarding yargs-yarser i had a low vulnerability as well, but yes it's not part of this solution.
after adding the preinstall script and resolutions, an npm install needs to be triggered. Post that I checked npm audit,  and I got 0 vulnerabilities...
     === npm audit security report ===

found 0 vulnerabilities

this is my npm ls ssri
├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └─┬<EMAIL_ADDRESS>│     └─┬<EMAIL_ADDRESS>│       └──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └─┬<EMAIL_ADDRESS>  │   └──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      └──<EMAIL_ADDRESS>

hi guys, anyone looking at this?
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-27290


Release v1.2.0

Automatic release of v1.2.0

LGTM
(although we should agree on the writing style in our changelog, what should be formatted as code, etc.)


Allows changing the edge color and style

Is your feature request related to a problem? Please describe.
Visibility is poor because the color and type of the tip are the same.
Describe the solution you'd like

Allows changing the color and style of the edges.
Allows specifying by edge color or style theme.
Edge is automatically color-coded.

Duplicate of #142


fix: fixed abort listener behaviour

Abort listener must be kept alive until an Abort message is received

Nice fix!


feat: add signinPath to SdkConfig

Fix: https://github.com/casdoor/casdoor-js-sdk/issues/34

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Admin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@xiaocode use the same committer as your github account, and sign CLA

@xiaocode your committer Email should be added to your GitHub account:

@xiaocode your committer Email should be added to your GitHub account:
Also refer to: https://casdoor.org/docs/contributing#modify-prs

Done!


dockerhub image fails to start

docker run --rm -it mailhog/mailhog:latest
docker: Error response from daemon: linux spec user: unable to find user mailhog: no matching entries in passwd file.
Building the latest dockerfile from branch master works fine, perhaps dockerhub just needs pushing the latest image?

you're still having troubles?
don't think it's related to mailhog. what's your docker version? image hash? (docker image inspect mailhog/mailhog:latest --format "{{.Id}}")
i run the same command without any troubles on docker 19.03.2 on linux mint

just noticed this still open - I've certainly been using it with no issues


turn off bold in mode and line number indicators

I generally hate bold anywhere in my interface, is there a simple command I can add to my .vimrc that will turn off bold in any airline theme and make it so the mode, line number and change file indicators are not bold.
Thanks! I love the plugin.
Rick

word of warning for iTerm2 users on OSX: recent changes in iTerm2 have made this setting rather important.  It seems that some of the powerline glyphs don't like to be rendered in bold (like the L/N indicator for example). I found that unchecking the "Draw bold text in bold font" iTerm2 setting resolved the issues I was seeing.


Upgrade com.google.googlejavaformat:google-java-format 1.15.0 -> 1.16.0

This PR contains the following updates:

Package
Type
Update
Change

com.google.googlejavaformat:google-java-format
compile
minor
1.15.0 -> 1.16.0

Release Notes

google/google-java-format
v1.16.0
Compare Source
Changes

Format long exception lists one per line (https://github.com/google/google-java-format/commit/198fa4236724f0305f1d4fb9447ce0b48984746f)
Normalize parameter comments (https://github.com/google/google-java-format/commit/dda43216576c4cb84e2497424b9ca9246f2687e5)

Bug fixes

Return a non-zero exit code on error (#848)
Formatter leaks threads and memory (#847)

Full Changelog: https://github.com/google/google-java-format/compare/v1.15.0...v1.16.0

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Google Java Format 1.15.0 -> 1.16.0

See:
- https://github.com/google/google-java-format/releases/tag/v1.16.0
- https://github.com/google/google-java-format/compare/v1.15.0...v1.16.0


own model input without internsity,how to modify this code

Hi, my model input only has x, y, z, andwithou intensity.Feature shape is 3. By modifying the relevant parameters of exporter.py, onnx was successfully converted and got params.h.
But don't know how to modify the code in the .cu file to fit my model
Looking forward to your reply
params.h :
#ifndef PARAMS_H_
#define PARAMS_H_
const int MAX_VOXELS = 40000;
class Params
{
  public:
    static const int num_classes = 1;
    const char *class_name [num_classes] = { "Car",};
    const float min_x_range = -5.12;
    const float max_x_range = 15.36;
    const float min_y_range = -5.12;
    const float max_y_range = 15.36;
    const float min_z_range = -2.0;
    const float max_z_range = 2.0;
    // the size of a pillar
    const float pillar_x_size = 0.16;
    const float pillar_y_size = 0.16;
    const float pillar_z_size = 4.0;
    const int max_num_points_per_pillar = 32;
    const int num_point_values = 3;
    // the number of feature maps for pillar scatter
    const int num_feature_scatter = 64;
    const float dir_offset = 0.78539;
    const float dir_limit_offset = 0.0;
    // the num of direction classes(bins)
    const int num_dir_bins = 2;
    // anchors decode by (x, y, z, dir)
    static const int num_anchors = num_classes * 2;
    static const int len_per_anchor = 4;
    const float anchors[num_anchors * len_per_anchor] = {
      3.9,1.6,1.56,0.0,
      3.9,1.6,1.56,1.57,
      };
    const float anchor_bottom_heights[num_classes] = {-1.78,};
    // the score threshold for classification
    const float score_thresh = 0.1;
    const float nms_thresh = 0.01;
    const int max_num_pillars = MAX_VOXELS;
    const int pillarPoints_bev = max_num_points_per_pillar * max_num_pillars;
    // the detected boxes result decode by (x, y, z, w, l, h, yaw)
    const int num_box_values = 7;
    // the input size of the 2D backbone network
    const int grid_x_size = (max_x_range - min_x_range) / pillar_x_size;
    const int grid_y_size = (max_y_range - min_y_range) / pillar_y_size;
    const int grid_z_size = (max_z_range - min_z_range) / pillar_z_size;
    // the output size of the 2D backbone network
    const int feature_x_size = grid_x_size / 2;
    const int feature_y_size = grid_y_size / 2;
    Params() {};
};
#endif

@angryhen  you do not need to modify the code. just make the internsity is 0, you data format should be like this （x, y, z, 0)


unknown location of executable

After running 'go build' as per the install instructions, there doesn't seem to be an executable generated... could you update the README with the location of the resulting binary.

Ah, good call.
Yeah, if you run go build ./cmd/gitdir it should build. I'll update the docs on my next pass through the app. I've got a number of cleanups I want to do.


Asp.net core .Net 5 compatibility?

Describe your question
Hello. I am using the Mqtt server with the AspNetCore integration and trying to upgrade to .Net 5 (RC2).
Sadly I get a compile error after upgrading to the latest Mqtt + .Net5 RC2 packages.
The error is:
CS7069	Reference to type 'ConnectionsRouteBuilder' claims it is defined in 'Microsoft.AspNetCore.Http.Connections', but it could not be found.
I found out that the type ConnectionsRouterBuilder is removed with .Net 5 hence the error.
The actual question: Is .Net 5 compatibility in work or is it planned? And if so will it be shipped before the .Net 5 release next month?
Thanks in advance
Which project is your question related to?

Server (AspNetCore integration)

Edit:
The method in question is
app.UseEndpoints(endpoints =>
{
    endpoints.MapMqtt("/mqtt");
});

Is .Net 5 compatibility in work or is it planned?

nothing is planned but I will update MqttNet.AspnetCore as soon as AspnetCore is Released and most likely ifdef my way to compatibility.

And if so will it be shipped before the .Net 5 release next month?

no it will certainly not be shipped before .Net 5 release. maybe in december when im on vakation and have some spare time. If you need to early adopt .Net 5 feel free to create a pr.

this seems to be the the issue:
https://docs.microsoft.com/en-us/dotnet/core/compatibility/3.1-5.0#signalr-usesignalr-and-useconnections-methods-removed

Hi @StefanOssendorf  @JanEggers
I made it work on NET 5.0 by just changing these lines in Startup.cs:
Old startup.cs:
                      app.UseEndpoints(endpoints =>                 {                     endpoints.MapMqtt("/mqtt");                 });
.NET5 Startup.cs:
   app.UseEndpoints(endpoints =>             {                 endpoints.MapConnectionHandler<MqttConnectionHandler>("/mqtt");             });
I made a quick test and it is working without any issue.
Cheers

MapMqtt should call exactly that I  guess ms just changed some types so the extension is not recogniced

Hi, maybe this is helpful for someone. Using the solution from @Jossec101 we still had a problem with the "Sec-WebSocket-Protocol".
WebSocket connection to '...' failed: Error during WebSocket handshake: Sent non-empty 'Sec-WebSocket-Protocol' header but no response was received
To fix that we had to specify a SubProtocolSelector, like this:
            builder.MapConnectionHandler<MqttConnectionHandler>("/api-gateway",                 httpConnectionDispatcherOptions => httpConnectionDispatcherOptions.WebSockets.SubProtocolSelector = protocolList => protocolList.FirstOrDefault() ?? string.Empty);

@SeppPenner Should we add the above hint to the wiki and close this issue?

@SeppPenner Should we add the above hint to the wiki and close this issue?

Good idea, if you ask me :)

Good idea, if you ask me :)

Is it correct like this: https://github.com/chkr1011/MQTTnet/wiki/Server#net-50? If yes, we can close the issue :)

Is it correct like this: https://github.com/chkr1011/MQTTnet/wiki/Server#net-50? If yes, we can close the issue :)

If somethings wrong just tell me and I will update the information :)

If somethings wrong just tell me and I will update the information :)

If somethings wrong just tell me and I will update the information :)

The code snippet has a syntax error.

@sean-mcl I have changed the example and it should work now.

I'm still encountering this issue.
Error :   No service for type 'Microsoft.AspNetCore.Http.Connections.Internal.HttpConnectionDispatcher' has been registered
Here some snippets of how I setup the MQTT Server
ConfigureServices
            services.AddSingleton<MQTT.IGMQTTServer>();
            services.AddHostedMqttServerWithServices(options => {
                var s = options.ServiceProvider.GetRequiredService<MQTT.IGMQTTServer>();
                s.ConfigureMqttServerOptions(options);
            });
            services.AddMqttConnectionHandler();

Configure
            app.UseEndpoints(endpoints =>
            {
                endpoints.MapControllers();
                endpoints.MapRazorPages();
                endpoints.MapConnectionHandler<MqttConnectionHandler>("/mqtt", httpConnectionDispatcherOptions => httpConnectionDispatcherOptions.WebSockets.SubProtocolSelector = protocolList => protocolList.FirstOrDefault() ?? string.Empty);
            });

            app.UseMqttServer(server => app.ApplicationServices.GetRequiredService<MQTT.IGMQTTServer>().ConfigureMqttServer(server));

MQTT.IGMQTTServer
    internal class IGMQTTServer : MqttServer, IMqttServerClientConnectedHandler, IMqttServerClientDisconnectedHandler, IMqttServerStoppedHandler
    {
        private IMqttServer _mqttServer;
        private readonly ILogger<IGMQTTServer> _logger;

        public IGMQTTServer(IEnumerable<IMqttServerAdapter> adapters, ILogger<IGMQTTServer> logger, IMqttNetLogger mqttLogger) : base(adapters, mqttLogger)
        {
            _logger = logger;
        }

        public void ConfigureMqttServerOptions(AspNetMqttServerOptionsBuilder options)
        {
            options.WithDefaultEndpointPort(1883);
        }

        public void ConfigureMqttServer(IMqttServer mqttServer)
        {
            _logger.LogInformation($"Configuring MQTT Server. Current State : {(mqttServer.IsStarted ? "Started" : "Stopped")}");

            _mqttServer = mqttServer;
            _mqttServer.ClientConnectedHandler = this;
            _mqttServer.ClientDisconnectedHandler = this;
            _mqttServer.StoppedHandler = this;
        }

        public Task HandleClientConnectedAsync(MqttServerClientConnectedEventArgs eventArgs)
        {
            _logger.LogInformation($"Client Connected");

            return Task.CompletedTask;
        }

        public Task HandleClientDisconnectedAsync(MqttServerClientDisconnectedEventArgs eventArgs)
        {
            _logger.LogInformation($"Client Disconnected");

            return Task.CompletedTask;
        }

        public Task HandleServerStoppedAsync(EventArgs eventArgs)
        {
            _logger.LogInformation($"MQTT Server Stopped");

            return Task.CompletedTask;
        }

    }

Any help would be greatly appreciated, Thanks in advance.

I would like to point out that using
            app.UseMqttEndpoint();
Is actually working !

@Fungusware Could you share your example ? Currently I tried to use MQTTnet with ASP.NET 5 without WebSockets and with Controllers and Tls support, but cannot figured out how to run it ...
Do not see connection from mqtt client:
    public class Startup
    {
        public Startup(IConfiguration configuration)
        {
            Configuration = configuration;
        }

        public IConfiguration Configuration { get; }

        // This method gets called by the runtime. Use this method to add services to the container.
        public void ConfigureServices(IServiceCollection services)
        {
            services.AddMqttControllers();

            var currentPath = Directory.GetCurrentDirectory();
            var certificatePath = ...;

            Debug.WriteLine($"certificatePath = {certificatePath}");
            var certificate = new X509Certificate2(certificatePath, "<password>", X509KeyStorageFlags.Exportable);

            services
                .AddHostedMqttServer(mqttServer => mqttServer.WithoutDefaultEndpoint())
                .AddHostedMqttServerWithServices(s =>
                {
                    // Optionally set server options here
                    s.WithoutDefaultEndpoint();
                    s.WithEncryptedEndpoint();
                    s.WithEncryptedEndpointBoundIPAddress(IPAddress.Parse(Configuration["IpAddress"]));
                    s.WithEncryptedEndpointPort(int.Parse(Configuration["Port"]));
                    s.WithEncryptionCertificate(certificate.Export(X509ContentType.Pfx));
                    s.WithEncryptionSslProtocol(SslProtocols.Tls12);
                    // Enable Attribute routing
                    s.WithAttributeRouting();
                    s.WithConnectionValidator(c =>
                    {
                        Debug.WriteLine("WithConnectionValidator");
                        c.ReasonCode = MqttConnectReasonCode.Success;
                    });
                })
                // Identify and build routes for the current assembly
                .AddMqttConnectionHandler()
                .AddConnections();
        }

        // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
        public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
        {
            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
                //app.UseWebAssemblyDebugging();
                app.UseHsts();
            }

            app.UseRouting();

            app.UseEndpoints(endpoints =>
            {
                // Root endpoint for MQTT - attribute routing picks up after this URL
                endpoints.MapConnectionHandler<MqttConnectionHandler>("/mqtt");
            });
        }
    }

I want to use MVC controllers, but it is hard to figured out how to run properly MQTT Server

Unfortunately I no longer have this working as I did not need the MQTT functionality. Sorry.


What rule "SAVE_WEIGHTS_INTE" parameters

total train data num?

it means how long do you want to save a checkpoint.


Parking Lot Card Count Not in Sync with Managed Lots

Issue Description
The parking lot card on the home screens shows the number of lots selected by the circles at the bottom of the card. When four lots are selected, only three circles are shown on the home screen under the parking card. When five lots are selected, only four circles are shown. When six lots are selected, six circles are show. Deselecting a lot and going back to five lots, four circles are shown. Closing and re-opening the app does not fix the problem.
Steps to Reproduce / Code Snippets
Add another parking lot in the Manage Parking Lots view, so two lots are selected. The Home view shows no circles under the parking card. Adding another lot in the Manage Parking Lots view, so three lots are selected. The Home view shows two circles under the parking card. This continues for four and five parking lots selected. Only when all six lots are selected does the Home view show six circles under the parking card.
From six lots, deselecting one lot, so that five lots are selected - the Home view shows four circles under the parking card.
Expected Results
The number of circles under the parking card in the Home view should match the number of parking lots selected in the Manage Parking Lots view.
Additional Information

React Native version:
Platform(s) (iOS, Android, or both?): Android
Operating System (macOS, Linux, or Windows?):

Verified in rmp-v2 (fb71c59). Closing

Merged into dev


Investigate alternatives to tsc for compiling Typescript files

Fast feedback loops are important for quick development. Especially since there's no real tradeoff I'm no fan of using tsc for compilation; it's not particularly featureful as a compiler, as you seem to be discovering.

Originally posted by @Zarel in https://github.com/Zarel/Pokemon-Showdown/issues/3278#issuecomment-466585834
Opening up this issue to track switching from tsc to a faster compiler, as the compile time of tsc is deemed to be a blocker for migrating to native Typescript (#3278). @Zarel suggests https://github.com/swc-project/swc as one option, but we should investigate to see if there are any other alternatives as well.

To be fair, "switch" is not the right term; we don't use a compiler at all right now.

The main alternative I've heard is:
https://github.com/alangpierce/sucrase

It looks like sucrase preserves lines by default, which saves us a lot of work in practice. I'm pretty impressed so far.

sucrase apparently defines a separate init function for each class field, though, which can't be good for performance:

To make sure I understand: sucrase/swc/??? would be used for compiling the .ts files, but we would still be using tsc in the npm run test step to actually check the types?
sucrase benchmarks for compile speed certain make it look good, but yeah, the generated code doesn't look ideal. I might try to see how easy they are to set up and then run them through my random simulation harness to get an idea of how it would effect performance numbers.

sucrase apparently defines a separate init function for each class field.

Looks like that's because you used an initializer - if you set the member in the constructor instead you avoid that. Still, I agree, somewhat worrisome.

You should think carefully before using Sucrase in production. Sucrase is mostly beneficial in development, and in many cases, Babel or tsc will be more suitable for production builds.

Sucrase is an experiment

There may also be breaking changes in Sucrase

Taken from the sucrase documentation. Doesn't inspire a ton of confidence unless we wanted to use it simply in development as it was intended and actually use tsc to emit in prod (which could result n odd bugs from divergence). Or, if we're willing to embrace a separate compilers for dev (optimized for compile speed) vs. prod (optimized for runtime speed), we could try using something like tsickle in a prod build setup. Note: actually setting up tsickle is out of scope for this bug, just wanted to point out that if we have seperate dev and prod build processes then there are potential benefits (I have a lot of experience with the Closure compiler, but none with tsickle so I'd need to play around more with it to understand its pain points, bazel already seems like it would be one of them).
So - my question is: how do you feel about a setup that has different builds for dev vs. prod? Its a fairly common practice (for example, using different optimization flags in prod with C++), but is more of a departure from what we're currently doing. If you're onboard with it, then sucrase looks like a good choice for the development compiler  because the key factors we would care about are correctness and compile speed, and sucrase's benchmarks seem to place it on top. If we want one build solution across the board I'd lean towards swc.

Different builds for dev and prod is unfortunately doesn't make sense for PS, which doesn't really distinguish the two – we essentially run prod in dev mode at all times – every debugging tool is available to us at all times. Even if it did, I don't want to maintain two build pipelines, either.
But even leaving aside considerations specific to PS, I don't think the trade-off makes sense in general: it's not like a crash becomes less of a problem when it happens in prod than when it happens in dev. I want as much information as possible in either case.

Different builds for dev and prod is unfortunately doesn't make sense for PS, which doesn't really distinguish the two – we essentially run prod in dev mode at all times – every debugging tool is available to us at all times.

Having a different build pipeline for dev vs. prod does not preclude you stripping away debugging tools.

Even if it did, I don't want to maintain two build pipelines, either.

This is fair, that's why I asked. In that case I think swc is probably the better choice at the moment.

But even leaving aside considerations specific to PS, I don't think the trade-off makes sense in general: it's not like a crash becomes less of a problem when it happens in prod than when it happens in dev. I want as much information as possible in either case.

 It doesn't mean you turn off stack traces or warnings or whatever, in fact you could have the compiler do extra correctness passes. It can mean you strip certain debug or dev only tools, but doesn't need to. For C++ it might mean just building at -O3 with all optimizations instead of the usual fast build. It's whatever you define it to be. My proposal would be to use sucrase to compile in prod and tsc (or if it becomes viable,tsc + tsickle in the future). No debug information would be stripped, and source maps would ensure you still get line numbers in the stack traces which make sense. The maitenance burden is having an extra config around, and adding a --prod or --dev flag to ./pokemon-showdown, maybe some scripts to package.json. But yeah, thats more than just using swc solely for both environments, so I can understand if you'd be opposed.

Yeah, swc sounds like the better choice.
Part of it's the mental overhead of deciding when you should use --prod or not. I already have enough indecision with ./build vs ./build full on client. If swc is performant and doesn't have many negative trade-offs, why not?

Yeah, swc sounds like the better choice.
Part of it's the mental overhead of deciding when you should use --prod or not. I already have enough indecision with ./build vs ./build full on client. If swc is performant and doesn't have many negative trade-offs, why not?

Because I want to have my cake and eat it to. If sucrase gives better compile times for dev and tsc/tsickle could produce more optimized code in prod, it seems like a win-win.
Still, let's go with swc for now.

Alright, I finally got native typescript to work, so now I'm trying these compilers!
Trying to use swc and to begin with its not very ergonomic. https://swc-project.github.io/docs/usage-cli is all you get, no globs etc. It also seems to have trouble with sim/battle-stream-example.ts and sim/battle-stream.ts, it spits out the other files fine.
$ npx swc sim -d sim
error: Expected Comma, got Some(Arrow)
  --> sim/battle-stream-example.ts:97:11
   |
97 | (async () => {
   |           ^^

[Error: failed to parse module]

Next up: sucrase:
$ npx sucrase ./srcDir -d ./outDir --transforms typescript,imports
Works pretty much instantly and does exactly what I want. The generated code doesn't look bad at all, and I think it keeps line numbers. Color me impressed. I've changed my mind. For now, I think I'll recommend sucrase unless I can prove it has significant runtime performance disadvantages.
I'm going to close this out, because I was using this bug for investigation. Feel free to reopen, but for now I think we've got our compiler.


[Refactor] Migrate all command-related interface functions from ProcessServiceImpl

Purpose of the pull request

This PR close #12468
This is a part of #12403

Brief change log

Migrate command-related interface functions to CommandService
Add ParamUtils

Verify this pull request
This pull request is already covered by existing tests

Codecov Report

Merging #12474 (4842822) into dev (b5193ee) will increase coverage by 0.00%.
The diff coverage is 67.83%.

@@            Coverage Diff            @@
##                dev   #12474   +/-   ##
=========================================
  Coverage     39.41%   39.41%
  Complexity     4214     4214
=========================================
  Files          1039     1041    +2
  Lines         39140    39123   -17
  Branches       4475     4460   -15
=========================================
- Hits          15426    15420    -6
+ Misses        21941    21937    -4
+ Partials       1773     1766    -7

Impacted Files
Coverage Δ

...server/master/runner/MasterSchedulerBootstrap.java
0.00% <0.00%> (ø)

...nscheduler/service/process/ProcessServiceImpl.java
28.64% <0.00%> (-3.17%)
:arrow_down:

...cheduler/api/service/impl/ExecutorServiceImpl.java
43.73% <40.00%> (ø)

.../server/master/runner/WorkflowExecuteRunnable.java
8.00% <50.00%> (+0.08%)
:arrow_up:

...che/dolphinscheduler/service/utils/ParamUtils.java
69.56% <69.56%> (ø)

...nscheduler/service/command/CommandServiceImpl.java
75.80% <75.80%> (ø)

...erver/master/processor/queue/TaskEventService.java
69.64% <0.00%> (-10.72%)
:arrow_down:

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
43.54% <0.00%> (-6.46%)
:arrow_down:

...org/apache/dolphinscheduler/remote/utils/Host.java
42.55% <0.00%> (-2.13%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
51.38% <0.00%> (-1.39%)
:arrow_down:

... and 20 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


feat: Add abilitity to delinate slides in markdown output

I have added an arg --enable_slides . This option is off by default. However, when you enable   adds the pattern \n---\n between slides. This is the default for most markdown slide programs and thus allows ingesting pptx slide decks into markdown slide programs.

In the original code, \n---\n is already used for comments. This evolution should also change that by replacing \n---\n by \n???\n when slides are activated (again, standard way of delimiting comment in markdown slides)

I agree, supporting speaker notes would be very useful.
To the best of my knowledge, there is no syntactical convention on speaker notes in slide markdown files.  Unlike slides delineation, which always uses--- or *** (a <hr> when rendered for conventional markdown).
It is not clear to me whether you are suggesting to use \n???\n as the syntax for this, or whether you expect ??? to be replaced, for example with ***. It does not appear to be the case that \n???\n is convention for example, sli.dev uses HTML comments as speaker notes.
An alternative may be to use some sort of code block where the language is specified as being notes. (Maybe this is a bad idea?)
I am not invested in any solution to this problem however, I feel a solution that has the widest possible compatibility is imperative.

LGTM. sorry for the delay.


build is failing

 cmake ./ -B./build is OK but
 make -C ./build failed below:

(llvm was installed prior and all prior prereq in the README.md file.
make[2]: Entering directory '/root/ROCm/ROCmValidationSuite/build'
make[2]: Leaving directory '/root/ROCm/ROCmValidationSuite/build'
[ 10%] Built target rvs_gtest_target
make[2]: Entering directory '/root/ROCm/ROCmValidationSuite/build'
make[2]: Leaving directory '/root/ROCm/ROCmValidationSuite/build'
[ 16%] Built target rvshelper
make[2]: Entering directory '/root/ROCm/ROCmValidationSuite/build'
make[2]: Leaving directory '/root/ROCm/ROCmValidationSuite/build'
[ 26%] Built target rvslib
make[2]: Entering directory '/root/ROCm/ROCmValidationSuite/build'
make[2]: Leaving directory '/root/ROCm/ROCmValidationSuite/build'
make[2]: Entering directory '/root/ROCm/ROCmValidationSuite/build'
[ 26%] Linking CXX executable ../bintest/unit.rvs.cli
clang-11: warning: argument unused during compilation: '-fno-gpu-rdc' [-Wunused-command-line-argument]
/usr/bin/ld: cannot find -lclang_rt.builtins-x86_64
clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
rvs/CMakeFiles/unit.rvs.cli.dir/build.make:99: recipe for target 'bintest/unit.rvs.cli' failed
make[2]: *** [bintest/unit.rvs.cli] Error 1
make[2]: Leaving directory '/root/ROCm/ROCmValidationSuite/build'
CMakeFiles/Makefile2:434: recipe for target 'rvs/CMakeFiles/unit.rvs.cli.dir/all' failed
make[1]: *** [rvs/CMakeFiles/unit.rvs.cli.dir/all] Error 2
make[1]: Leaving directory '/root/ROCm/ROCmValidationSuite/build'
Makefile:162: recipe for target 'all' failed
make: *** [all] Error 2

can close this one, no longer an issue.


Word wrap not working

Environment data

VS Code version: 1.54.3
Jupyter Extension version: 2021.3.619093157
Python Extension version: 2021.3.6568691958
OS (Windows | Mac | Linux distro) and version: Windows 10 pro
Python and/or Anaconda version: Python 3.8.6
Type of virtual environment used: N/A
Jupyter server running: Local

Expected behaviour
Words will not wrap and you will see a horizontal scroll bar.
Actual behaviour
Words are wrapping even when word wrap option is OFF
Steps to reproduce:

Turn off wordwrap
Change windows size

Thanks for your feedback. This issue will be addressed once VS Code adds native support for editing notebooks. Please see https://github.com/microsoft/vscode/issues/91987. You can experiment by using VS Code insiders, which defaults to the new notebook experience.


Rethink schema modifications in spring-test

Currently the CassandraTestDB object has gotten quite fat and tracks state for things I'm not sure it should.
tableExists for example will truncate a table after it's been used (I'm not sure this feels right)
createTestKeyspace will drop the keyspace after it's been created (this feels right ,but maybe doesn't belong on CassandraTestDB since a DB is logically equivalent to a keyspace anyway)
My idea is one of two, either:

all schema modifications go into a separate object with it's own rules. This would have to either be autowired in separately or be created off the CassandraTestDB object.
Make the rule that only thing that are "created" by CassandraTestDB are dropped, rather than things that are visited by CassandraTestDB. this would mean, count for example would not drop, and a separate call to markTableForCleanup would be needed, probably with a full keyspace and table name, in case the mapper is not used.

Fixed in 0.3.0


Set training iteration steps

Hi Yuval! Thanks for this work.
I understand there's a flag to save training progress but on Kaggle my program crashes due to 12 hours session duration. This way my whole training progress is lost. I wanna be able to set the training iteration steps to avoid crash. How can I do that?
Regards
Rahul Bhalley

If I understand what you want to do, you can save the self.global_step in the state_dict when saving. Then, when you load the checkpoint, you can set the current start step as the step saved in the state_dict.

This seems to be doable with --resume_training_from_ckpt and --save_training_data flags as in comments in your code.
Sorry for not being able to convey my query correctly.
What I wanna do is stop training at some iteration step (which I'll find myself) so that the program doesn't crash due to 12 hours per session limit.
For instance, if the training currently runs for a total of 70k steps but after first 12 hours only 2k steps were completed then I wanna stop training right there (just few minutes before 12 hours session duration) so that the notebook doesn't crash. Then I wanna continue training in next session using that trained checkpoint (which I think will be handled with --resume_training_from_ckpt and --save_training_data flags).

Thank you. Found this flag inside train_options.py.


Calling mrbc_release when returning C method

I noticed that C extension library was being created.
In the method of the C extension class library, the SET_XXX_VALUE macro is used to specify the return value.
The reference counter is supported after version 1.1, and it is necessary to release self (--ref_count) stored in v[0] before setting the return value.
static void c_hoge(mrb_vm *vm, mrb_value v[], int argc)
{
   mrbc_release(v);    /* I do not want to call this */
   SET_INT_RETURN(0);
}

It is hard for the library developer to call this mrbc_release() call, and if you forget to call, the self's reference counter will continue to increase and become a fatal situation.
I think that calling mrbc_release() should be included in the SET_XXX_RETURN macro.
Please consider it.

I agree with your proposal. Usually there is mrb_release near SET_*_RETURN.

Thank you.
I will change and PR.

close


Run CBOR Codec benchmarks on CI

Description
This PR depends on https://github.com/IntersectMBO/ouroboros-network/pull/4798.
We should only have benchmarks on CI if we have a dedicated GHA runner where the benchmarking results are reliable.

The codeowners file contains errors, because @intersectmbo/network-superowners doesn't exist:
Unknown owner on line 5: make sure the team @intersectmbo/network-superowners exists, is publicly visible, and has write access to the repository


relase spring boot 2.3.5

release spring boot starter 2.3.5 version

/azp run java - spring - tests


[AppService]: fix #19645- Update parameter descriptions for az webapp config storage-account commands

#19645
Description

Update parameter descriptions for az webapp config storage-account commands
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

AppService


Internet explorer not rendering Buttons in card Properly (.ac-pushbutton)

I have tried this with
master/webchat-es5.js and
latest/webchat-es5.js
but the button doesn't adapt to the text size inside it
in chrome

in IE

UPDATE :
Looks like removing flex-basis property fixes the issue
$(".ac-pushButton").css("flex-basis", "");

Hi @keshavnagpal, this appears to be a dupe of https://github.com/Microsoft/BotFramework-WebChat/issues/1493
Please use HTML5 and it should fix this problem.


chore: bdd-spring-1573227324 to 0.0.1

chore: Promote bdd-spring-1573227324 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


How to get group and child position from flatPos in setOnGroupClickListener

setOnGroupClickListener function will returns the position of onClick you make. But   the flatPos will returns the location not only the group but with child position . is there anyway that can get the group position . ??  i saw that ExpandableListPosition . can do that , but no idea how it can be done

I made a method to get the real group position from group item and flat position:
private int calculateRealGroupPosition(ExpandableGroup group, int flatPosition) {
int realPos = flatPosition;
    int groupsBefore = 0;
    List<? extends ExpandableGroup> groups = getGroups();

    for (ExpandableGroup expandableGroup : groups) {
        if (expandableGroup.equals(group)) {
            break;
        }
        groupsBefore++;
    }

    for (int i = 0; i < groupsBefore; i++) {
        InterviewSectionRecyclerItem groupItem = getGroupItem(i);
        if (isGroupExpanded(groupItem)){
            realPos -= groupItem.getItemCount();
        }
    }

    return realPos;
}

Can you explain this line.
InterviewSectionRecyclerItem groupItem = getGroupItem(i);

Just wondering if someone still looking for a solution, i solved this issue by modify @shadowpath solution
`private fun calculateRealGroupPosition(group: ExpandableGroup<*>, flatPosition: Int): Int {
var realPos = flatPosition
    val groupsBefore = arrayListOf<ExpandableGroup<*>>()
    val groups = groups

    for (expandableGroup in groups) {
        if (expandableGroup == group) {
            break
        }
        groupsBefore.add(expandableGroup)
    }

    for (i in 0 until groupsBefore.size) {
        val groupItem = groupsBefore[i]
        if (isGroupExpanded(groupItem)) {
            realPos -= groupItem.itemCount
        }
    }

    return realPos
}`

@ganjarramadhan Thank you

Not sure if this helps.
use expandableList.getFlattenedGroupIndex(group) method to get real group position.
@Override
public void onBindChildViewHolder(MenuChildViewHolder holder, int flatPosition, ExpandableGroup group, int childIndex) {
    holder.setChildAdapter(menuChildModel.getName(), expandableList.getFlattenedGroupIndex(group), childIndex);

}

@ganjarramadhan can you please provide this in Java?


where are windows server 2022 installation instructions?

Hi. The readme says:
https://github.com/microsoft/winget-cli/blob/f1ae1267c330f7ec463a58fc6c7b0e2ea6f44a16/README.md?plain=1#L16
I'm glad to hear that installation on windows server 2022 "may be possible." What steps should I take to test if it's possible for me?

After doing some more searching, I think this issue is a duplicate of https://github.com/microsoft/winget-cli/issues/438 which has seemingly been closed as a "won't fix" if I understand correctly (issue marked closed & docs are non-existent).
I think it's a bit strange to dangle the possibility of installation on windows server 2022 in the readme, then make it a secret out of how to actually do it.

There are a couple of different options. Users should also be aware that WinGet distributed through the App Installer is considered a Windows System component which means once it's been added to Windows Server 2022, removal is not supported.
One method is the instructions at Microsoft Learn for bootstrapping WinGet in the Windows Sandbox. The other method is using the Repair-WinGetPackageManager PowerShell cmdlet inside the Microsoft.WinGet.Client PowerShell module.
$progressPreference = 'silentlyContinue'
Write-Information "Downloading WinGet and its dependencies..."
Invoke-WebRequest -Uri https://aka.ms/getwinget -OutFile Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle
Invoke-WebRequest -Uri https://aka.ms/Microsoft.VCLibs.x64.14.00.Desktop.appx -OutFile Microsoft.VCLibs.x64.14.00.Desktop.appx
Invoke-WebRequest -Uri https://github.com/microsoft/microsoft-ui-xaml/releases/download/v2.8.6/Microsoft.UI.Xaml.2.8.x64.appx -OutFile Microsoft.UI.Xaml.2.8.x64.appx
Add-AppxPackage Microsoft.VCLibs.x64.14.00.Desktop.appx
Add-AppxPackage Microsoft.UI.Xaml.2.8.x64.appx
Add-AppxPackage Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle

Hi @denelon I followed your suggestion above and received an error about missing license.

A non Microsoft approach is
Bit.ly/winget-install
Works for unsupported OS like Windows Server 2022 and 2019.


Elmond memory leak

psum02 was using nearly 16G of memory and opensearch could not start because there was not enough memory available. Upon restart of elmond it dropped down to a memory usage value measured in MB. This feels like some type of memory leak in the Elmond python code that we need to hunt down. Planning to track how quickly its growing on psum02. We could potentially explore an regular restart as interim solution while we track down leak.

Haven't seen this in awhile and unable to recreate so closing. Can re-open if encounter again and can gather more info.

I removed the Debug mode in flask which I think might have been cause of this. I finally saw this in one of my test instances.


Add appointment link for no CNI explanatory letter

Removing embassy contact details and adding link because users can now use the CABS appointment service instead.
Trello
https://trello.com/c/4we62Wrb/789-getting-married-in-south-africa-new-appointments-service-content-change-request
Zendesk
https://govuk.zendesk.com/agent/tickets/2097107

Superseded by #3071


Don't return a copy

Closes #251

Finally found the bug (https://github.com/theislab/cellrank/pull/252/commits/a6e808b802e757b5c88db6e34b8cdd3bc6377415#diff-2a9c983177e1b2ff5e17f5446fd392e9R860) and made LineageView improvements!


[Bug report] When syncing cropped images from iCloud, isLocallyAvailable(isOrigin: true) always returns false.

Version
2.8.1
Platforms
iOS
Device Model
any
flutter info
[✓] Flutter (Channel stable, 3.13.9, on macOS 14.1 23B74 darwin-arm64, locale en-GB)
    • Flutter version 3.13.9 on channel stable at /Users/who/dev/flutter3.13.9
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d211f42860 (5 weeks ago), 2023-10-25 13:42:25 -0700
    • Engine revision 0545f8705d
    • Dart version 3.1.5
    • DevTools version 2.25.0
    • Pub download mirror https://pub.dartlang.org
    • Flutter download mirror https://storage.googleapis.com

How to reproduce?
When syncing cropped images from iCloud, isLocallyAvailable(isOrigin: true) always returns false.
I discovered a possible reason from the following code:

The array returned by this method has more than one element, but based on the data, it appears that the value of the last element should be retrieved.

Logs
No response
Example code (optional)
No response
Contact
No response

@sy5075391 Sorry for the late reply. Can you extract those resources and verify their corresponding images? Like which one is the raw picture and which one is edited.


custom transform style

I need to custom css transform style, like add rotate.

I think we need to change the position of props here.


User defined types don't work in ASM block's curly braces syntax

TYPE sid
    init AS WORD
END TYPE

DIM music AS sid
music.init = $beef

ASM
    lda {sid.init}
END ASM

/var/folders/t8/ngfvr40134l01825gycspzg80000gn/T//xcbtmp_4DDE1127.asm (26): error: Not enough args passed to Macro.
/var/folders/t8/ngfvr40134l01825gycspzg80000gn/T//xcbtmp_4DDE1127.asm (27): error: Illegal character '{sid.init}'.
/var/folders/t8/ngfvr40134l01825gycspzg80000gn/T//xcbtmp_4DDE1127.asm (27): error: Illegal character '}'.
Fatal assembly error: Source is not resolvable.

The variable name extrapolation in assembly blocks is currently limited to variables. UDT fields cannot be accessed this way.

Warning in ASM documentation would be nice as this was not quickly understood from the dasm error.