x265: 3.5 -> 3.6

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4305

Seems to have broken cross-compilation to aarch64:
Complete (failing) build log from my hydra instance
Running phase: unpackPhase
unpacking source archive /nix/store/559pklxypdib3wsrx8r28vm8vp1w94d6-x265_3.6.tar.gz
source root is x265_3.6/source
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file x265_3.6/source/x265cli.h
Running phase: patchPhase
substituteStream() in derivation x265-aarch64-unknown-linux-gnu-3.6: WARNING: '--replace' is deprecated, use --replace-{fail,warn,quiet}. (file 'cmake/Version.cmake')
Running phase: updateAutotoolsGnuConfigScriptsPhase
Running phase: updateAutotoolsGnuConfigScriptsPhase
Running phase: configurePhase
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/frfz6zc4arvbrmxfg12skiib7w0zf389-x265-aarch64-unknown-linux-gnu-3.6/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/frfz6zc4arvbrmxfg12skiib7w0zf389-x265-aarch64-unknown-linux-gnu-3.6/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/frfz6zc4arvbrmxfg12skiib7w0zf389-x265-aarch64-unknown-linux-gnu-3.6/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/frfz6zc4arvbrmxfg12skiib7w0zf389-x265-aarch64-unknown-linux-gnu-3.6/share/doc/x265 -DCMAKE_INSTALL_INFODIR=/nix/store/frfz6zc4arvbrmxfg12skiib7w0zf389-x265-aarch64-unknown-linux-gnu-3.6/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/frfz6zc4arvbrmxfg12skiib7w0zf389-x265-aarch64-unknown-linux-gnu-3.6/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/xcx9mhkxm5yhpzrbf976kk4m5k2bz0wd-x265-aarch64-unknown-linux-gnu-3.6-dev/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/xcx9mhkxm5yhpzrbf976kk4m5k2bz0wd-x265-aarch64-unknown-linux-gnu-3.6-dev/include -DCMAKE_INSTALL_SBINDIR=/nix/store/frfz6zc4arvbrmxfg12skiib7w0zf389-x265-aarch64-unknown-linux-gnu-3.6/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/frfz6zc4arvbrmxfg12skiib7w0zf389-x265-aarch64-unknown-linux-gnu-3.6/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/frfz6zc4arvbrmxfg12skiib7w0zf389-x265-aarch64-unknown-linux-gnu-3.6/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_SYSROOT= -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/5gp9gg7la6mhrc2czx831bg5vpn3sili-aarch64-unknown-linux-gnu-gcc-wrapper-13.3.0/bin/aarch64-unknown-linux-gnu-strip -DCMAKE_RANLIB=/nix/store/5gp9gg7la6mhrc2czx831bg5vpn3sili-aarch64-unknown-linux-gnu-gcc-wrapper-13.3.0/bin/aarch64-unknown-linux-gnu-ranlib -DCMAKE_AR=/nix/store/5gp9gg7la6mhrc2czx831bg5vpn3sili-aarch64-unknown-linux-gnu-gcc-wrapper-13.3.0/bin/aarch64-unknown-linux-gnu-ar -DCMAKE_C_COMPILER=aarch64-unknown-linux-gnu-gcc -DCMAKE_CXX_COMPILER=aarch64-unknown-linux-gnu-g++ -DCMAKE_INSTALL_PREFIX=/nix/store/frfz6zc4arvbrmxfg12skiib7w0zf389-x265-aarch64-unknown-linux-gnu-3.6 -Wno-dev -DDETAILED_CU_STATS=OFF -DCHECKED_BUILD=OFF -DENABLE_PPA=OFF -DENABLE_VTUNE=OFF -DWARNINGS_AS_ERRORS=OFF -DCMAKE_SYSTEM_NAME=Linux -DCMAKE_SYSTEM_PROCESSOR=aarch64 -DCMAKE_HOST_SYSTEM_NAME=Linux -DCMAKE_HOST_SYSTEM_PROCESSOR=x86_64 -DGIT_ARCHETYPE=1 -DENABLE_SHARED=ON -DHIGH_BIT_DEPTH=OFF -DENABLE_HDR10_PLUS=ON -DCROSS_COMPILE_ARM=ON -DENABLE_CLI=ON -DENABLE_TESTS=OFF
-- cmake version 3.29.6
-- The C compiler identification is GNU 13.3.0
-- The CXX compiler identification is GNU 13.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/5gp9gg7la6mhrc2czx831bg5vpn3sili-aarch64-unknown-linux-gnu-gcc-wrapper-13.3.0/bin/aarch64-unknown-linux-gnu-gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/5gp9gg7la6mhrc2czx831bg5vpn3sili-aarch64-unknown-linux-gnu-gcc-wrapper-13.3.0/bin/aarch64-unknown-linux-gnu-g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detected ARM64 target processor
-- Could NOT find NUMA (missing: NUMA_ROOT_DIR NUMA_INCLUDE_DIR NUMA_LIBRARY)
-- Looking for include file inttypes.h
-- Looking for include file inttypes.h - found
-- Performing Test CC_HAS_NO_STRICT_OVERFLOW
-- Performing Test CC_HAS_NO_STRICT_OVERFLOW - Success
-- Performing Test CC_HAS_NO_NARROWING
-- Performing Test CC_HAS_NO_NARROWING - Success
-- Performing Test CC_HAS_NO_ARRAY_BOUNDS
-- Performing Test CC_HAS_NO_ARRAY_BOUNDS - Success
-- Performing Test CC_HAS_FAST_MATH
-- Performing Test CC_HAS_FAST_MATH - Success
-- Performing Test CC_HAS_STACK_REALIGN
-- Performing Test CC_HAS_STACK_REALIGN - Failed
-- Performing Test CC_HAS_FNO_EXCEPTIONS_FLAG
-- Performing Test CC_HAS_FNO_EXCEPTIONS_FLAG - Success
-- Found nasm: /nix/store/ssg27i5z498mvqvz7js96gz5xzxccgqf-nasm-2.16.03/bin/nasm (found version "2.16.03")
-- SOURCE CODE IS FROM x265 GIT ARCHIVED ZIP OR TAR BALL
-- GIT ARCHIVAL INFORMATION PROCESSED
-- X265 RELEASE VERSION 3.6+1-aa7f602f7
-- Detected CXX compiler using -O3 optimization level
-- The ASM compiler identification is GNU
-- Found assembler: /nix/store/5gp9gg7la6mhrc2czx831bg5vpn3sili-aarch64-unknown-linux-gnu-gcc-wrapper-13.3.0/bin/aarch64-unknown-linux-gnu-gcc
-- Looking for strtok_r
-- Looking for strtok_r - found
-- Looking for include file getopt.h
-- Looking for include file getopt.h - found
-- Configuring done (8.7s)
-- Generating done (0.1s)
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_TESTING
    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_DOCDIR
    CMAKE_INSTALL_INCLUDEDIR
    CMAKE_INSTALL_INFODIR
    CMAKE_INSTALL_LIBDIR
    CMAKE_INSTALL_LIBEXECDIR
    CMAKE_INSTALL_LOCALEDIR
    CMAKE_INSTALL_MANDIR
    CMAKE_INSTALL_OLDINCLUDEDIR
    CMAKE_INSTALL_SBINDIR

-- Build files have been written to: /build/x265_3.6/source/build
cmake: enabled parallel building
cmake: enabled parallel installing
Running phase: buildPhase
build flags: -j8 SHELL=/nix/store/4bj2kxdm1462fzcc2i2s4dn33g2angcc-bash-5.2p32/bin/bash
[  1%] Building CXX object encoder/CMakeFiles/encoder.dir/analysis.cpp.o
[  2%] Building CXX object encoder/CMakeFiles/encoder.dir/search.cpp.o
[  3%] Building CXX object encoder/CMakeFiles/encoder.dir/bitcost.cpp.o
[  4%] Building CXX object encoder/CMakeFiles/encoder.dir/motion.cpp.o
[  5%] Building CXX object encoder/CMakeFiles/encoder.dir/slicetype.cpp.o
[  6%] Building CXX object encoder/CMakeFiles/encoder.dir/frameencoder.cpp.o
[  7%] Building CXX object common/CMakeFiles/common.dir/arm/asm-primitives.cpp.o
[  8%] Building CXX object dynamicHDR10/CMakeFiles/dynamicHDR10.dir/json11/json11.cpp.o
/build/x265_3.6/source/encoder/analysis.cpp: In member function 'x265::Mode& x265::Analysis::compressCTU(x265::CUData&, x265::Frame&, const x265::CUGeom&, const x265::Entropy&)':
/build/x265_3.6/source/encoder/analysis.cpp:160:51: warning: comparing the result of pointer addition '((*((x265::Analysis*)this)->x265::Analysis::<anonymous>.x265::Search::m_frame->x265::Frame::m_ctuInfo) + ((sizetype)(((long unsigned int)ctu.x265::CUData::m_cuAddr) * 272)))' and NULL [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Waddress-Waddress8;;]
  160 |     if (m_param->bCTUInfo && (*m_frame->m_ctuInfo + ctu.m_cuAddr))
      |                              ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
[  9%] Building CXX object encoder/CMakeFiles/encoder.dir/framefilter.cpp.o
[ 10%] Building CXX object dynamicHDR10/CMakeFiles/dynamicHDR10.dir/JsonHelper.cpp.o
[ 10%] Building CXX object dynamicHDR10/CMakeFiles/dynamicHDR10.dir/metadataFromJson.cpp.o
[ 11%] Building CXX object encoder/CMakeFiles/encoder.dir/level.cpp.o
[ 12%] Building CXX object common/CMakeFiles/common.dir/aarch64/asm-primitives.cpp.o
[ 13%] Building CXX object common/CMakeFiles/common.dir/aarch64/pixel-prim.cpp.o
[ 13%] Building CXX object encoder/CMakeFiles/encoder.dir/nal.cpp.o
[ 14%] Building CXX object common/CMakeFiles/common.dir/aarch64/filter-prim.cpp.o
[ 15%] Building CXX object common/CMakeFiles/common.dir/aarch64/dct-prim.cpp.o
[ 16%] Building CXX object dynamicHDR10/CMakeFiles/dynamicHDR10.dir/SeiMetadataDictionary.cpp.o
[ 17%] Building CXX object dynamicHDR10/CMakeFiles/dynamicHDR10.dir/api.cpp.o
[ 18%] Building CXX object encoder/CMakeFiles/encoder.dir/sei.cpp.o
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:467: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  467 | #pragma unroll(4)
      |
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:472: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  472 | #pragma unroll(2)
      |
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:489: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  489 | #pragma unroll(1)
      |
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:515: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  515 | #pragma unroll(4)
      |
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:522: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  522 | #pragma unroll(2)
      |
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:577: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  577 | #pragma unroll(2)
      |
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:650: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  650 | #pragma unroll (8)
      |
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:653: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  653 | #pragma unroll (4)
      |
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:674: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  674 | #pragma unroll (2)
      |
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:714: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  714 | #pragma unroll (2)
      |
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:729: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  729 | #pragma unroll (4)
      |
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:736: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  736 | #pragma unroll (8)
      |
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:748: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  748 | #pragma unroll (16)
      |
/build/x265_3.6/source/common/aarch64/dct-prim.cpp:770: warning: ignoring '#pragma unroll ' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunknown-pragmas-Wunknown-pragmas8;;]
  770 | #pragma unroll (8)
      |
[ 19%] Building CXX object encoder/CMakeFiles/encoder.dir/sao.cpp.o
[ 20%] Building CXX object common/CMakeFiles/common.dir/aarch64/loopfilter-prim.cpp.o
[ 21%] Building CXX object common/CMakeFiles/common.dir/aarch64/intrapred-prim.cpp.o
[ 21%] Built target dynamicHDR10
[ 21%] Linking CXX static library libhdr10plus.a
[ 21%] Built target hdr10plus-static
[ 22%] Linking CXX shared library libhdr10plus.so
[ 22%] Built target hdr10plus-shared
[ 23%] Building CXX object encoder/CMakeFiles/encoder.dir/entropy.cpp.o
[ 24%] Building CXX object encoder/CMakeFiles/encoder.dir/dpb.cpp.o
[ 25%] Building CXX object common/CMakeFiles/common.dir/aarch64/arm64-utils.cpp.o
[ 26%] Building CXX object common/CMakeFiles/common.dir/primitives.cpp.o
[ 27%] Building CXX object encoder/CMakeFiles/encoder.dir/ratecontrol.cpp.o
[ 28%] Building CXX object encoder/CMakeFiles/encoder.dir/reference.cpp.o
[ 29%] Building CXX object encoder/CMakeFiles/encoder.dir/encoder.cpp.o
[ 30%] Building CXX object encoder/CMakeFiles/encoder.dir/api.cpp.o
[ 31%] Building CXX object encoder/CMakeFiles/encoder.dir/weightPrediction.cpp.o
[ 32%] Building CXX object common/CMakeFiles/common.dir/pixel.cpp.o
In file included from /build/x265_3.6/source/common/aarch64/pixel-prim.cpp:10:
In function 'uint32x4_t vld1q_lane_u32(const uint32_t*, uint32x4_t, int)',
    inlined from 'void {anonymous}::sad_x4_neon(const pixel*, const pixel*, const pixel*, const pixel*, const pixel*, intptr_t, int32_t*) [with int lx = 12; int ly = 16]' at /build/x265_3.6/source/common/aarch64/pixel-prim.cpp:1115:34:
/nix/store/9k3nlxxxxdlszkkzlja5yz1m4ixi6bnf-aarch64-unknown-linux-gnu-gcc-13.3.0/lib/gcc/aarch64-unknown-linux-gnu/13.3.0/include/arm_neon.h:13439:10: warning: 'p_x4' is used uninitialized [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wuninitialized-Wuninitialized8;;]
13439 |   return __aarch64_vset_lane_any (*__src, __vec, __lane);
      |          ^
/build/x265_3.6/source/common/aarch64/pixel-prim.cpp: In function 'void {anonymous}::sad_x4_neon(const pixel*, const pixel*, const pixel*, const pixel*, const pixel*, intptr_t, int32_t*) [with int lx = 12; int ly = 16]':
/build/x265_3.6/source/common/aarch64/pixel-prim.cpp:1114:24: note: 'p_x4' was declared here
 1114 |             uint32x4_t p_x4;
      |                        ^~~~
In function 'uint32x4_t vld1q_lane_u32(const uint32_t*, uint32x4_t, int)',
    inlined from 'void {anonymous}::sad_x4_neon(const pixel*, const pixel*, const pixel*, const pixel*, const pixel*, intptr_t, int32_t*) [with int lx = 4; int ly = 8]' at /build/x265_3.6/source/common/aarch64/pixel-prim.cpp:1115:34:
/nix/store/9k3nlxxxxdlszkkzlja5yz1m4ixi6bnf-aarch64-unknown-linux-gnu-gcc-13.3.0/lib/gcc/aarch64-unknown-linux-gnu/13.3.0/include/arm_neon.h:13439:10: warning: 'p_x4' is used uninitialized [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wuninitialized-Wuninitialized8;;]
13439 |   return __aarch64_vset_lane_any (*__src, __vec, __lane);
      |          ^
/build/x265_3.6/source/common/aarch64/pixel-prim.cpp: In function 'void {anonymous}::sad_x4_neon(const pixel*, const pixel*, const pixel*, const pixel*, const pixel*, intptr_t, int32_t*) [with int lx = 4; int ly = 8]':
/build/x265_3.6/source/common/aarch64/pixel-prim.cpp:1114:24: note: 'p_x4' was declared here
 1114 |             uint32x4_t p_x4;
      |                        ^~~~
In function 'uint32x4_t vld1q_lane_u32(const uint32_t*, uint32x4_t, int)',
    inlined from 'void {anonymous}::sad_x4_neon(const pixel*, const pixel*, const pixel*, const pixel*, const pixel*, intptr_t, int32_t*) [with int lx = 4; int ly = 16]' at /build/x265_3.6/source/common/aarch64/pixel-prim.cpp:1115:34:
/nix/store/9k3nlxxxxdlszkkzlja5yz1m4ixi6bnf-aarch64-unknown-linux-gnu-gcc-13.3.0/lib/gcc/aarch64-unknown-linux-gnu/13.3.0/include/arm_neon.h:13439:10: warning: 'p_x4' is used uninitialized [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wuninitialized-Wuninitialized8;;]
13439 |   return __aarch64_vset_lane_any (*__src, __vec, __lane);
      |          ^
/build/x265_3.6/source/common/aarch64/pixel-prim.cpp: In function 'void {anonymous}::sad_x4_neon(const pixel*, const pixel*, const pixel*, const pixel*, const pixel*, intptr_t, int32_t*) [with int lx = 4; int ly = 16]':
/build/x265_3.6/source/common/aarch64/pixel-prim.cpp:1114:24: note: 'p_x4' was declared here
 1114 |             uint32x4_t p_x4;
      |                        ^~~~
[ 32%] Building CXX object common/CMakeFiles/common.dir/dct.cpp.o
[ 33%] Building CXX object common/CMakeFiles/common.dir/lowpassdct.cpp.o
/build/x265_3.6/source/encoder/ratecontrol.cpp: In member function 'int x265::RateControl::writeRateControlFrameStats(x265::Frame*, x265::RateControlEntry*)':
/build/x265_3.6/source/encoder/ratecontrol.cpp:3241:36: warning: '~' directive writing 1 byte into a region of size between 0 and 127 [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wformat-overflow=-Wformat-overflow=8;;]
 3241 |             sprintf(deltaPOC, "%s%d~", deltaPOC, rpsWriter->deltaPOC[i]);
      |                                    ^
In file included from /nix/store/9k3nlxxxxdlszkkzlja5yz1m4ixi6bnf-aarch64-unknown-linux-gnu-gcc-13.3.0/aarch64-unknown-linux-gnu/sys-include/stdio.h:980,
                 from /nix/store/9k3nlxxxxdlszkkzlja5yz1m4ixi6bnf-aarch64-unknown-linux-gnu-gcc-13.3.0/include/c++/13.3.0/cstdio:42,
                 from /build/x265_3.6/source/common/common.h:33,
                 from /build/x265_3.6/source/encoder/ratecontrol.cpp:30:
In function 'int sprintf(char*, const char*, ...)',
    inlined from 'int x265::RateControl::writeRateControlFrameStats(x265::Frame*, x265::RateControlEntry*)' at /build/x265_3.6/source/encoder/ratecontrol.cpp:3241:20:
/nix/store/9k3nlxxxxdlszkkzlja5yz1m4ixi6bnf-aarch64-unknown-linux-gnu-gcc-13.3.0/aarch64-unknown-linux-gnu/sys-include/bits/stdio2.h:30:34: note: '__builtin___sprintf_chk' output between 3 and 140 bytes into a destination of size 128
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
/nix/store/9k3nlxxxxdlszkkzlja5yz1m4ixi6bnf-aarch64-unknown-linux-gnu-gcc-13.3.0/aarch64-unknown-linux-gnu/sys-include/bits/stdio2.h:30:34: warning: '__builtin___sprintf_chk' argument 5 overlaps destination object 'deltaPOC' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wrestrict-Wrestrict8;;]
/build/x265_3.6/source/encoder/ratecontrol.cpp: In member function 'int x265::RateControl::writeRateControlFrameStats(x265::Frame*, x265::RateControlEntry*)':
/build/x265_3.6/source/encoder/ratecontrol.cpp:3232:14: note: destination object referenced by 'restrict'-qualified argument 1 was declared here
 3232 |         char deltaPOC[128];
      |              ^~~~~~~~
/build/x265_3.6/source/encoder/ratecontrol.cpp:3242:33: warning: '~' directive writing 1 byte into a region of size between 0 and 39 [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wformat-overflow=-Wformat-overflow=8;;]
 3242 |             sprintf(bUsed, "%s%d~", bUsed, rpsWriter->bUsed[i]);
      |                                 ^
In function 'int sprintf(char*, const char*, ...)',
    inlined from 'int x265::RateControl::writeRateControlFrameStats(x265::Frame*, x265::RateControlEntry*)' at /build/x265_3.6/source/encoder/ratecontrol.cpp:3242:20:
/nix/store/9k3nlxxxxdlszkkzlja5yz1m4ixi6bnf-aarch64-unknown-linux-gnu-gcc-13.3.0/aarch64-unknown-linux-gnu/sys-include/bits/stdio2.h:30:34: note: '__builtin___sprintf_chk' output between 3 and 42 bytes into a destination of size 40
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
/nix/store/9k3nlxxxxdlszkkzlja5yz1m4ixi6bnf-aarch64-unknown-linux-gnu-gcc-13.3.0/aarch64-unknown-linux-gnu/sys-include/bits/stdio2.h:30:34: warning: '__builtin___sprintf_chk' argument 5 overlaps destination object 'bUsed' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wrestrict-Wrestrict8;;]
/build/x265_3.6/source/encoder/ratecontrol.cpp: In member function 'int x265::RateControl::writeRateControlFrameStats(x265::Frame*, x265::RateControlEntry*)':
/build/x265_3.6/source/encoder/ratecontrol.cpp:3233:14: note: destination object referenced by 'restrict'-qualified argument 1 was declared here
 3233 |         char bUsed[40];
      |              ^~~~~
[ 34%] Building CXX object common/CMakeFiles/common.dir/ipfilter.cpp.o
[ 35%] Building CXX object common/CMakeFiles/common.dir/intrapred.cpp.o
[ 36%] Building CXX object common/CMakeFiles/common.dir/loopfilter.cpp.o
[ 37%] Building CXX object common/CMakeFiles/common.dir/constants.cpp.o
[ 38%] Building CXX object common/CMakeFiles/common.dir/cpu.cpp.o
/build/x265_3.6/source/common/cpu.cpp: In function 'uint32_t x265::cpu_detect(bool)':
/build/x265_3.6/source/common/cpu.cpp:388:26: warning: unused parameter 'benableavx512' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-parameter-Wunused-parameter8;;]
  388 | uint32_t cpu_detect(bool benableavx512)
      |                     ~~~~~^~~~~~~~~~~~~
/build/x265_3.6/source/common/cpu.cpp: At global scope:
/build/x265_3.6/source/common/cpu.cpp:65:13: warning: 'x265::enable512' defined but not used [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-variable-Wunused-variable8;;]
   65 | static bool enable512 = false;
      |             ^~~~~~~~~
[ 39%] Building CXX object common/CMakeFiles/common.dir/version.cpp.o
[ 40%] Building CXX object common/CMakeFiles/common.dir/threading.cpp.o
[ 41%] Building CXX object common/CMakeFiles/common.dir/threadpool.cpp.o
[ 42%] Building CXX object common/CMakeFiles/common.dir/wavefront.cpp.o
[ 42%] Building CXX object common/CMakeFiles/common.dir/md5.cpp.o
[ 43%] Building CXX object common/CMakeFiles/common.dir/bitstream.cpp.o
[ 43%] Built target encoder
[ 44%] Building CXX object common/CMakeFiles/common.dir/yuv.cpp.o
[ 45%] Building CXX object common/CMakeFiles/common.dir/shortyuv.cpp.o
[ 46%] Building CXX object common/CMakeFiles/common.dir/picyuv.cpp.o
[ 47%] Building CXX object common/CMakeFiles/common.dir/common.cpp.o
[ 48%] Building CXX object common/CMakeFiles/common.dir/param.cpp.o
[ 49%] Building CXX object common/CMakeFiles/common.dir/frame.cpp.o
[ 50%] Building CXX object common/CMakeFiles/common.dir/framedata.cpp.o
[ 51%] Building CXX object common/CMakeFiles/common.dir/cudata.cpp.o
[ 52%] Building CXX object common/CMakeFiles/common.dir/slice.cpp.o
[ 52%] Building CXX object common/CMakeFiles/common.dir/lowres.cpp.o
[ 53%] Building CXX object common/CMakeFiles/common.dir/piclist.cpp.o
[ 54%] Building CXX object common/CMakeFiles/common.dir/predict.cpp.o
[ 55%] Building CXX object common/CMakeFiles/common.dir/scalinglist.cpp.o
[ 56%] Building CXX object common/CMakeFiles/common.dir/quant.cpp.o
[ 57%] Building CXX object common/CMakeFiles/common.dir/deblock.cpp.o
[ 58%] Building CXX object common/CMakeFiles/common.dir/scaler.cpp.o
[ 59%] Building CXX object common/CMakeFiles/common.dir/ringmem.cpp.o
[ 60%] Building CXX object common/CMakeFiles/common.dir/temporalfilter.cpp.o
[ 60%] Built target common
make[2]: *** No rule to make target '/build/x265_3.6/source/common/arm/blockcopy8-common.S', needed by 'blockcopy8-common.S.o'.  Stop.
make[2]: *** Waiting for unfinished jobs....
make[2]: *** No rule to make target '/build/x265_3.6/source/common/arm/blockcopy8-common.S', needed by 'blockcopy8-common.S.o'.
Short excerpt of the errors:
make[2]: *** No rule to make target '/build/x265_3.6/source/common/arm/blockcopy8-common.S', needed by 'blockcopy8-common.S.o'.  Stop.
make[2]: *** Waiting for unfinished jobs....
make[2]: *** No rule to make target '/build/x265_3.6/source/common/arm/blockcopy8-common.S', needed by 'blockcopy8-common.S.o'.  Stop.
make[2]: *** Waiting for unfinished jobs....
[ 61%] Generating ssd-a.S.o
[ 62%] Generating ssd-a.S.o
[ 63%] Generating asm.S.o
[ 64%] Generating asm.S.o
/build/x265_3.6/source/common/arm/asm.S: Assembler messages:
/build/x265_3.6/source/common/arm/asm.S:28: Error: unknown pseudo-op: `.syntax'
/build/x265_3.6/source/common/arm/asm.S:38: Error: unknown pseudo-op: `.fpu'
/build/x265_3.6/source/common/arm/ssd-a.S:77: Error: junk at end of line, first unrecognized character is `@'
/build/x265_3.6/source/common/arm/ssd-a.S:34:  Info: macro invoked from here
/build/x265_3.6/source/common/arm/ssd-a.S:35: Error: unknown mnemonic `vld1.32' -- `vld1.32 {d16[]},[r0],r1'
/build/x265_3.6/source/common/arm/ssd-a.S:36: Error: unknown mnemonic `vld1.32' -- `vld1.32 {d17[]},[r2],r3'
/build/x265_3.6/source/common/arm/ssd-a.S:37: Error: unknown mnemonic `vsubl.u8' -- `vsubl.u8 q2,d16,d17'
/build/x265_3.6/source/common/arm/ssd-a.S:38: Error: unknown mnemonic `vld1.32' -- `vld1.32 {d16[]},[r0],r1'
/build/x265_3.6/source/common/arm/ssd-a.S:39: Error: unknown mnemonic `vmull.s16' -- `vmull.s16 q0,d4,d4'
/build/x265_3.6/source/common/arm/ssd-a.S:40: Error: unknown mnemonic `vld1.32' -- `vld1.32 {d17[]},[r2],r3'
/build/x265_3.6/source/common/arm/ssd-a.S:42: Error: unknown mnemonic `vsubl.u8' -- `vsubl.u8 q2,d16,d17'
/build/x265_3.6/source/common/arm/ssd-a.S:43: Error: unknown mnemonic `vld1.32' -- `vld1.32 {d16[]},[r0],r1'
/build/x265_3.6/source/common/arm/ssd-a.S:44: Error: unknown mnemonic `vmlal.s16' -- `vmlal.s16 q0,d4,d4'
/build/x265_3.6/source/common/arm/ssd-a.S:45: Error: unknown mnemonic `vld1.32' -- `vld1.32 {d17[]},[r2],r3'
/build/x265_3.6/source/common/arm/ssd-a.S:47: Error: unknown mnemonic `vsubl.u8' -- `vsubl.u8 q2,d16,d17'
/build/x265_3.6/source/common/arm/ssd-a.S:48: Error: unknown mnemonic `vld1.32' -- `vld1.32 {d16[]},[r0],r1'
/build/x265_3.6/source/common/arm/ssd-a.S:49: Error: unknown mnemonic `vmlal.s16' -- `vmlal.s16 q0,d4,d4'
/build/x265_3.6/source/common/arm/ssd-a.S:50: Error: unknown mnemonic `vld1.32' -- `vld1.32 {d17[]},[r2],r3'
/build/x265_3.6/source/common/arm/ssd-a.S:52: Error: unknown mnemonic `vsubl.u8' -- `vsubl.u8 q2,d16,d17'
/build/x265_3.6/source/common/arm/ssd-a.S:53: Error: unknown mnemonic `vmlal.s16' -- `vmlal.s16 q0,d4,d4'
/build/x265_3.6/source/common/arm/ssd-a.S:54: Error: unknown mnemonic `vadd.s32' -- `vadd.s32 d0,d0,d1'
/build/x265_3.6/source/common/arm/ssd-a.S:55: Error: unknown mnemonic `vpadd.s32' -- `vpadd.s32 d0,d0,d0'
/build/x265_3.6/source/common/arm/ssd-a.S:56: Error: unknown mnemonic `vmov.32' -- `vmov.32 r0,d0[0]'
/build/x265_3.6/source/common/arm/ssd-a.S:57: Error: unknown mnemonic `bx' -- `bx lr'
/build/x265_3.6/source/common/arm/ssd-a.S:69: Error: junk at end of line, first unrecognized character is `@'
/build/x265_3.6/source/common/arm/ssd-a.S:58:  Info: macro invoked from here
/build/x265_3.6/source/common/arm/ssd-a.S:77: Error: junk at end of line, first unrecognized character is `@'
/build/x265_3.6/source/common/arm/ssd-a.S:60:  Info: macro invoked from here

Trying to reproduce and explore locally.

At least the following makes it cross-compile:
--- a/pkgs/development/libraries/x265/default.nix
+++ b/pkgs/development/libraries/x265/default.nix
@@ -92,7 +92,6 @@ stdenv.mkDerivation rec {
       ${mkFlag (!stdenv.hostPlatform.isStatic) "ENABLE_SHARED"}
       -DHIGH_BIT_DEPTH=OFF
       -DENABLE_HDR10_PLUS=ON
-      ${mkFlag (isCross && stdenv.hostPlatform.isAarch) "CROSS_COMPILE_ARM"}
       ${mkFlag cliSupport "ENABLE_CLI"}
       ${mkFlag unittestsSupport "ENABLE_TESTS"}
     )

The change enables arm32 code for arm64. I'll try to tweak it to contain CROSS_COMPILE_ARM64 for 64-bit arm.

Proposed possible fix as:

https://github.com/NixOS/nixpkgs/pull/333539

[ ] Also (native) x86_64-darwin build fails now, though I don't have real evidence that the update is the cause:
https://hydra.nixos.org/build/268803889
-review says that it blocks ~3k builds.

/tmp/nix-build-x265-3.6.drv-0/x265_3.6/source/test/testharness.h:78:24: error: static declaration of '__rdtsc' follows non-static declaration
static inline uint32_t __rdtsc(void)
                       ^
/tmp/nix-build-x265-3.6.drv-0/x265_3.6/source/test/testharness.h:78:24: note: '__rdtsc' is a builtin with type 2

Possibly an effect of https://bitbucket.org/multicoreware/x265_git/commits/0983cffc501e5279e7d9e9b2241b506cb332efcb : source/test/testharness.h brought __rdtsc() in for
I'll have a closer look.

Proposed the x86_64-darwin fix as:

https://github.com/NixOS/nixpkgs/pull/333985


Allow Decoder::next_image() to be called multiple times to allow paging through a multi-page TIFF

Due to some ownership issues, it does not seem possible to iterate through a multi-page TIFF, since next_image can only be called once. I just fiddled with the borrows a bit. This should fix #34.

There is one failing test but it should be fixed by #32

I want to merge this as it should make the library more usable. @HeroicKatora do you have any objections?
After this and #41 is merged I think we should release a new version of the library,

Seems fine. If you're ready for releasing 0.3 feel free to ping me.


Does Pixie plan to support K8S on Windows? Such as Docker Desktop running on Windows.

Since Pixie relies on Linux eEBP, does it work on Docker for Desktop on Linux? I am using Docker Desktop on Windows for POC and evaluation purposes.

Pixie does not currently support Docker Desktop. For a list of supported environments, see: https://docs.px.dev/installing-pixie/requirements/


How do I pass a custom rules file to the GitHub action?

I tried pointing rules: at a rules file in the repository I want the action to run on, but that doesn't seem to work?

Can you provide more informtaion about error?
This config should work as you want:
    - name: Lint changelog file
      uses: docker://avtodev/markdown-lint:v1
      with:
        rules: './your/rules.js'
        config: './your/config.yml'
        args: './path/to/the/target.md'

My action is at https://github.com/NTAP/rfc8312bis/blob/markdownlint/.github/workflows/markdownlint.yml and has this bit:
      uses: docker://avtodev/markdown-lint:v1
      with:
        rules: './.markdownlint.json'
        args: 'draft-*.md'

My rules are at https://github.com/NTAP/rfc8312bis/blob/markdownlint/.markdownlint.json and contain:
{
  "default": true,
  "MD029": {"style": "ordered" },
  "MD034": false,
  "MD040": false,
  "MD041": false
}

The error is:
Error: Property 'names' of custom rule at index 0 is incorrect.
    at newError (/usr/local/bin/markdownlint:2:204300)
    at forProperty (/usr/local/bin/markdownlint:2:204531)
    at Array.forEach (<anonymous>)
    at forRule (/usr/local/bin/markdownlint:2:204391)
    at Array.forEach (<anonymous>)
    at validateRuleList (/usr/local/bin/markdownlint:2:204223)
    at lintInput (/usr/local/bin/markdownlint:2:212115)
    at Function.markdownlintSync [as sync] (/usr/local/bin/markdownlint:2:213059)
    at lintAndPrint (/usr/local/bin/markdownlint:2:4558)
    at Object.2390 (/usr/local/bin/markdownlint:2:4606)

It seems like incorrect parameter is used. Try to use config instead rules

Thanks, that worked! (And was kinda non-obvious).


Add description of collateralOutpoint and signing of ProRegTx

This change is required to support HW wallets. These allow only signing of arbitrary text messages and not by hash.

Is this ready for merge? No ACKs yet...

ACK looks okay to me. I'm assuming the magic string gets handled internally since it does not show up in the signMessage field of the protx register_prepare output (assuming this is correct).


Null safety support?

Is there a plan to support null safety ?

https://github.com/pstromberg98/flutter_bouncy/issues/12


GH-1399 Added support for listener container customizer

This work is basically parsing out some rabbit specific work from https://github.com/spring-cloud/spring-cloud-stream-binder-rabbit/pull/145 into a an AbstractMessageChannelBinder
Resolves #1399

Codecov Report

Merging #1400 into master will increase coverage by 0.01%.
The diff coverage is 60%.

@@             Coverage Diff             @@
##             master   #1400      +/-   ##
===========================================
+ Coverage     61.28%   61.3%   +0.01%
- Complexity      825     826       +1
===========================================
  Files           133     133
  Lines          3970    3972       +2
  Branches        565     565
===========================================
+ Hits           2433    2435       +2
+ Misses         1251    1250       -1
- Partials        286     287       +1

Impacted Files
Coverage Δ
Complexity Δ

...ud/stream/binder/AbstractMessageChannelBinder.java
47.82% <60%> (+0.35%)
26 <1> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819542d...9626b58. Read the comment docs.


include<EMAIL_ADDRESS>for<EMAIL_ADDRESS>

Following #5573.

:+1:

@timbur Thanks.

how do I get the fix? is it now available via npm?

Latest npm version is still 0.16.2 which requires<EMAIL_ADDRESS>When can we expect a new release?


Add:  Clover (AL)

Channel Name
Clover
Alternative Names (optional)
No response
Network (optional)
No response
Owners (optional)
No response
Country
AL
Subdivision (optional)
No response
City (optional)
No response
Broadcast Area
Albania
Languages
sqi
Categories (optional)
kids
NSFW
FALSE
Launched (optional)
N/A
Closed (optional)
N/A
Replaced By (optional)
No response
Website (optional)
No response
Logo
https://static.wikia.nocookie.net/international-entertainment-project/images/9/97/Clover_logo.webp/revision/latest/scale-to-width-down/120?cb=20230804040919
Notes
No response

Please update your request:

broadcast area code is incorrect
logo is not loaded

https://github.com/iptv-org/database/blob/master/CONTRIBUTING.md#channels


Remove Notebook Image Build and Push steps from release workflow

Issue link
Related to release of codeflare sdk.
What changes have been made

Removing Notebook Image Build and Push steps from the release workflow as they are no longer required.
Verification steps

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] Testing is not required for this change

/lgtm

/lgtm


Add irrigation interfaces in Noah-MP

Including updates outlined in W. Nie et al. (2018) (https://agupubs.onlinelibrary.wiley.com/doi/pdf/10.1029/2017WR022178) with the ability to toggle the groundwater abstraction on and off.

Can this issue now be closed?

Closing this issue.  Interfaces were added via pull request #150


Lightbox for images to show full resolution image

Is it possible to incorporate something like this to show full resolution images on click ?

This is something that could be made using a Markserv app. An app will run custom code and use custom HTML templates to render the view. I'm working on this currently. I will try and add lightbox as an example to the github app for Markserv.
Thanks for the idea.

Thanks a lot for responding for requests and building this thing! This could be a very nice wiki platform.
Thanks again!

Hi @vgonisanz @sushruth - Update...
I've added some experimental templating features.
See: https://github.com/F1LT3R/markserv#just-in-time-templating
If you take a look at the tests/templates/ directory, you will see an index.html file that uses includes/templates to inject sub-content into pages on the fly.
I would be interested to have you two take that for a spin and give me some feedback.


Cancellation steps should occur in state representation.

from stories import I, Story

class Action(Story):
    I.one(
        ~I.cancel_one,
    )
    I.two(
        ~I.cancel_two_a,
        ~I.cancel_two_b,
    )
    I.three

    def one(self, state):
        ...

    def two(self, state):
        ...

    def three(self, state):
        raise Exception

    def cancel_two_a(self, state, error):
        ...

    def cancel_two_b(self, state, error):
        ...

    def cancel_one(self, state, error):
        print(state)

Action
  one
  two
  three (error: Exception)
  ~cancel_two_a
  ~cancel_two_b
  ~cancel_one

State()

Superseded by #627


Added moveable text

Need to add boundaries to card and remove additional space created by each new text box.

Shouldn't have any issues merging! Good job!


Make TypeAdapter.typeId a string

It looks like there may be a concern of type adapter collision if more than one adapter uses the same typeId.
If this is true, I'm wondering if it would be better if it was a String instead.
An easy migration path is to use the hashCode of String typeId to get an int value that could be used otherwise, then recommend that people give each type adapter a unique name.
If my understandings here are wrong, please let me know if this is documented somewhere.

This would be very useful! Risk of conflict is too high currently.


Fix data directory of unnamed projects

Fixes #44083
Desktop platforms defaulted to the project directory if its name was empty. Now they will use [unnamed project] instead.

Thanks!

Cherry-picked for 3.5.


⚠ Cioos Pacific CKAN has degraded performance

In 5dc6006, Cioos Pacific CKAN (https://catalogue.cioospacific.ca) experienced degraded performance:

HTTP code: 200
Response time: 9492 ms

Resolved: Cioos Pacific CKAN performance has improved in b88db66 after 44 minutes.


[FLINK-30657] Remove Shared and Key_Shared related tests in Pulsar connector

What is the purpose of the change
This pull request removes the flaky tests in flink-connector-pulsar. These tests have been dropped in the externalized flink-connector-pulsar and won't get fixed in the old Flink release. So we have discussed in https://issues.apache.org/jira/browse/FLINK-30413 and think these test codes are dead code now.
Brief change log
Remove these test classes.

SharedSplitAssignerTest.java
PulsarUnorderedSourceReaderTest.java
PulsarUnorderedPartitionSplitReaderTest.java
PulsarSourceUnorderedE2ECase.java
PulsarUnorderedSourceITCase.java

Drop Shared subscription test in PulsarSourceEnumeratorTest.java.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Thanks for your contribution @syhily! Mergiung...


Error on train_val file

Issue in train_val.py file

I encountered the same problem. have you solved that problem? @adarsh-dikhit


[QUESTION] How could I make this work with TypeScript?

TypeScript warns about .toMatchError not existing, could you add instructions to make it work with it?

The same way you make your typescript compiler aware of jest types:
{
  "compilerOptions": {
    "types": [
      "node",
      "jest",
      "jest-matcher-specific-error"
    ],
  }
}


Add a search to the attribution column in the audit view.

Summary of changes
Add a search functionality for signals. This is accessed by clicking on the search icon, which is located next to the tabs. This opens a textbox that allows a user to search attributions by package name, license name and copyright.
Context and reason for change
As a user I would like to search attributions for problematic licenses.

Some points regarding the visual:

When no signals found, the user can still see sources titles, this is confusing:

User can close the search window when there is some text and move to another file/folder/view, but the filtering is still active:

you can either disable closing the search field when it is not empty or automatically clear it when it is closing.

It would be nice to make some margin between tabs local/global and the search field, as the text "Search" covers the LOCAL tab.

Still working on Vasily's first comment

Would be nice to indicate the user that there are no results in case that there are no results. Possible using some text.

Is it intended that the search is restored when navigating from audit view to attribution view and back?

I fear it is not transparent for the user how search works. Which fields are included in search and which are not. For example, the user might try to search for a version number and might get zero results even if that version is included in the list of packages.

It would be nice to have a "clear search" button, like we have on attribution view


Fix bug in RouterQueryEngine, update QASummaryQueryEngineBuilder and associated notebook

I think those are response extra infos. Not sure what they do right now.


Backport -Add features label for e2e feature tests for ginkgo focus

Manual backport of #982

/test-e2e-1-26-1-27-upgrade-release-1-4

/test-e2e-1-26-1-27-upgrade-release-1-4

/keep-test-e2e-1-26-1-27-upgrade-release-1-4

/test-e2e-1-25-1-26-upgrade-release-1-3

/test-e2e-1-26-1-27-upgrade-release-1-4

/test-e2e-1-26-1-27-upgrade-release-1-4

/keep-test-e2e-1-26-1-27-upgrade-release-1-4

/keep-test-e2e-1-26-1-27-upgrade-release-1-4

/test-e2e-1-26-1-27-upgrade-release-1-4

/test-ubuntu-e2e-integration-release-1-4

/approve

/test build

/test build

/test build

/retest

/test build

/retest

/retest

/test build

/test all


Added arabic

Added locales/ar folder with arabic translations

Great job!
I think that options can be removed since we are using the defaults.
Works well, tested by changing the local storage to ar-AE.
I see there are still some in work:

Also some of the internal services like terms of usage still missing translations, guess it is still in work


Add UTA coordinate fetching

[ ] Transcript -> Genomic
[ ] Genomic -> Transcript

UTA uses 0 based coordinates to describe tx and alt start/end. We will use inter-residue coordinates in SequenceLocations


Bug : Title doesn't appear in survey (window mode) when using dxService

Hi Andrew,
The header of the window remains blank whereas the JSON returned by dxService contains a string in its "title" property.
The title appears correctly when initializing the model directly with the said JSON in Survey.Model constructor. I'm not sure where it comes from yet but I'll keep looking and let you know otherwise.
Thanks

browser: Chrome 58.0.3029.110 (64-bit) (Last version as of now I think)
surveyjs platform : jQuery
surveyjs version: 0.12.14

@rsauvage Yes, indeed it was a bug. I have fixed it.
Thank you,
Andrew

Great, many thanks Andrew !
Romain


staff users can remove delegates from motion support list

a delegate logged in and supported a motion
now the staff users/admin can remove this user from the support list.

This is a problem because at least in political parties members fear misuse all the time and in this case the admin could remove a person from the supporter's list against his will.

This was a design decision: The admin/stuff should be able to support semi paperless assemblies. If someone comes to him (shows his ID) and says that he do not want to be a supporter of a motion any more, the admin should be able to remove him. (The admin is also able to change and reset the password of this user, log in using his credentials and the support oder unsupport motions.) The admin is even able to hack the database and change data to whatever he likes for OpenSlides does not use crypto stuff here.
If the members of an assembly do not trust his admin they should not use his software for some aspects of their work (e. g. elections).

If the members of an assembly do not trust his admin

Of course many people don't trust "new" things. I cannot accept that this bug is closed without any discussion.
I cannot follow you argumentation: The user already logged in and presses the support button, so he can log in again and unsupport. So there is no need for the admin to do this. If a user refuse to log in again and to unsupport it is his decision.
Also for a later feature to support elections the admin must not be able to change election results. This is a very important issue to get acceptance for a software like OpenSlides. If you deny to rethink about the design for OpenSlides I fear it cannot be sued as a tool that supports also elections.
Please reopen the bug and discuss a close first (maybe on a phone call conference or by mail).

I can imaging many situations where someone want to support or unsupport a motion but is not able to log in (at the moment or at all):

May be the admin uses OpenSlides in presentation mode so he does not share user credentials and does not want to give participants network access. He just wants to control what is shown on the projector.
May be the user has not computer. He just asks the admin for service. (And it may be a decision of every assembly whether to offer such a service or to offer a public computer terminal.)
May be the user misuses his accounts and has to be blocked. Nevertheless his request to support or unsupport the motion is valid according to the legal system of the assembly.
...

All in all users of OpenSlides have to have the choice how to use it. If users request a more secure version we need personal software or even hardware certificates, signatures, card readers, an independent CA and thelike for every action a participant may do. This is because the admin is able to change every (unsigned) value of the underlying database all the time. So we should not discuss about how to restrict the UI for admin users.

If we later implement personal elections using the credentials OpenSlides currently provides (no extra crypto stuff) then this is the same. The election should no be considered valid because OpenSlides has not button for the admin to change/remove votes but because in the end everybody is able to check if his vote was counted correctly. (OpenSlides should provide a printable (ordered) named list of all votes.)

May be the admin uses OpenSlides in presentation mode so he does not share user credentials and does not want to give participants network access. He just wants to control what is shown on the projector.

But this is not the bug. The bug is when the user already logged in and added himself to the supporter list. if OpenSlides is not used that way users can log in he would not be able to add himself to the list before.

May be the user has not computer.

But again, the bug is if he already logged in before. If he lost he computer meanwhile, he must login from another PC. That should not be a hard task.

May be the user misuses his accounts and has to be blocked.

This is not allowed. A member of e.g. a party has certain rights that cannot be removed. If anybody has the right to participate via OpenSlides it is not allowed to hinder him. if he pulls out 200 motions at once it is his right to do  and this happens in practice. People know how to ignore this or to put such motions to the very end of the list so that there is always "unfortunately" time to speak about this.

@donovaly Please accept that we have to prioritize all reported OpenSlides issues. And this issues has a very low priority for us. We (the core developers) have to allot our (reduced) time slots to bring OpenSlides to the front by implementing the most useful things for all organisations and their assemblies.
This issue is not a valid bug for us because our basic assumption is that all admin users of OpenSlides are trusted persons in the assembly. If it not valid for your event you have to think about organisational actions by using OpenSlides (e.g. that users have to support motions only by signing on motion paper). We cannot protect OpenSlides against malintent administrators! This is a requirement (as in every software).
So please let us concentrate on issues where we are agree with the suggested improvements and which are helpful for all the other organisations using OpenSlides. (Please call me personally if you have still some questions to my decision.)


Adding function: Allow users to designate the number of batches

Now when calling the register_model function, the users can designate the batch size so that all the containers could use this specific batch size instead of using the default batching strategy. For example:
connection.register_model(name="model_name", version="model_version15", input_type="floats",batch_size=5)
The default value of the parameter "batch_size" is -1. Clipper will apply the default strategy under this situation.

Can one of the admins verify this patch?

OK to test.

jenkins ok to test

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/785/
Test FAILed.

@Unous1996 There's an issue with the jenkins cluster right now, it's not your code that's causing the tests to fail. Hang tight, working to get the issue resolved.

OK. So are there anything I need to do right now?

@Unous1996 This is definitely on the right track! Most of the review comments are concerned with code cleanup and readability

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/787/
Test FAILed.

Is there anything wrong with the cluster right now? Or there's some issue with my code.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/789/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/790/
Test FAILed.

The tests are failing right because of the format checker. Run ./bin/format_code.sh to format the code correctly.

OK. Thanks.
On Mon, Nov 27, 2017 at 8:22 AM, Dan Crankshaw<EMAIL_ADDRESS>wrote:

The tests are failing right because of the format checker. Run
./bin/format_code.sh to format the code correctly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ucbrise/clipper/pull/320#issuecomment-347235388, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AgAM14V1oPEGRRmgr_RTlmTNYsBNyzJFks5s6uG0gaJpZM4Qjkld
.

Well, it seemed that I had problem when running the format_code.sh
/Users/tim/Documents/Clipper_proj/clipper/bin/.. xargs: clang-format: No such file or directory xargs: clang-format: No such file or directory
I have already install the clang format file, move it to the ./bin/directory and changed the folder name to "clang-format", but it did not work.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/804/
Test FAILed.

OK. I will try to fix it.
On Sat, 30 Dec 2017 at 3:17 AM Corey Zumar<EMAIL_ADDRESS>wrote:

@Corey-Zumar requested changes on this pull request.
@Unous1996 https://github.com/unous1996 This just needs a few more
changes
In src/libclipper/include/clipper/task_executor.hpp
https://github.com/ucbrise/clipper/pull/320#discussion_r159121001:

@@ -272,9 +291,19 @@ class TaskExecutor {
VersionedModelId vm = VersionedModelId(
container_info["model_name"], container_info["model_version"]);
int replica_id = std::stoi(container_info["model_replica_id"]);

       active_containers_->add_container(

           vm, std::stoi(container_info["zmq_connection_id"]), replica_id,

           parse_input_type(container_info["input_type"]));

         active_containers_->add_container(

                 vm, std::stoi(container_info["zmq_connection_id"]), replica_id,

                 parse_input_type(container_info["input_type"]));

       auto model_info = redis::get_model(redis_connection_, vm);

       VersionedModelId model_id = VersionedModelId(model_info["model_name"], model_info["model_version"]);

The value of this variable will be identical to vm (defined on line 291)
and can be deleted
In src/libclipper/include/clipper/task_executor.hpp
https://github.com/ucbrise/clipper/pull/320#discussion_r159121008:

@@ -272,9 +291,19 @@ class TaskExecutor {
VersionedModelId vm = VersionedModelId(
container_info["model_name"], container_info["model_version"]);
int replica_id = std::stoi(container_info["model_replica_id"]);

       active_containers_->add_container(

           vm, std::stoi(container_info["zmq_connection_id"]), replica_id,

           parse_input_type(container_info["input_type"]));

         active_containers_->add_container(

                 vm, std::stoi(container_info["zmq_connection_id"]), replica_id,

                 parse_input_type(container_info["input_type"]));

       auto model_info = redis::get_model(redis_connection_, vm);

       VersionedModelId model_id = VersionedModelId(model_info["model_name"], model_info["model_version"]);

         int batch_size = DEFAULT_BATCH_SIZE;

         auto batch_size_search = model_info.find("batch_size");

         if(batch_size_search != model_info.end()){

           batch_size = std::stoi(model_info["batch_size"]);

           active_containers_->register_batch_size(model_id, batch_size);

move this outside of the if statement and replace model_id with vm
In src/libclipper/include/clipper/task_executor.hpp
https://github.com/ucbrise/clipper/pull/320#discussion_r159121013:

@@ -272,9 +291,19 @@ class TaskExecutor {
VersionedModelId vm = VersionedModelId(
container_info["model_name"], container_info["model_version"]);
int replica_id = std::stoi(container_info["model_replica_id"]);

       active_containers_->add_container(

           vm, std::stoi(container_info["zmq_connection_id"]), replica_id,

           parse_input_type(container_info["input_type"]));

         active_containers_->add_container(

                 vm, std::stoi(container_info["zmq_connection_id"]), replica_id,

                 parse_input_type(container_info["input_type"]));

       auto model_info = redis::get_model(redis_connection_, vm);

       VersionedModelId model_id = VersionedModelId(model_info["model_name"], model_info["model_version"]);

         int batch_size = DEFAULT_BATCH_SIZE;

         auto batch_size_search = model_info.find("batch_size");

         if(batch_size_search != model_info.end()){

           batch_size = std::stoi(model_info["batch_size"]);

Replace with: batch_size = std::stoi(batch_size_search->second)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ucbrise/clipper/pull/320#pullrequestreview-86028813,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgAM1_3FlQSi5Q6n2E8ONw1Xt9bL1-HTks5tFhu8gaJpZM4Qjkld
.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/817/
Test FAILed.


adjust "30 DAYS TEST DETAILS" to apply new widget templates

group by OWNER is lost and should be returned
RUN_NAME should be unchecked in legend by default

changes applied:

it can be tested on General board after setup zebrunner using branch develop

Verified on develop branch.
ui: <IP_ADDRESS>-SNAPSHOT
server: <IP_ADDRESS>-SNAPSHOT
Fixed.


Keep Call Stack closed while running

VSCode keeps opening the Call Stack during debugging. This makes debugging multiple Apps simultationsly impossible.
For example, I am running App A while debugging App B. The Call Stack of App A keeps expanding everytime a new subprocess is launched or terminated. This makes debugging App B impossible because its call stack jumps up and down in the list.
Suggestion:
A functionality to keep the Call Stack closed upon launching subproccesses, e.g. a button.
Image:
Callstack keeps going back and forth between the left and right image.

The issue that the callstack is expanded whenever a new subprocess is launched should be fixed in Insider (@isidorn correct?).

@weinand yes this should behave better now.
@cemde can you please try this with vscode insiders https://code.visualstudio.com/insiders/
And if it still does not behave well let us know and there might be other things which we could do to further improve this (maybe we should fully respect if a user collapses some node in the tree and not auto expand it anymore)


caffe compilation failed

Hi,
I am trying to compile caffe by including your layers, however i get following error message
src/caffe/layers/extended_image_data_layer.cpp:39:21: fatal error: maskApi.h: No such file or directory

@sajjo79 Hello，I would like to ask you that have you built that caffe now? Thanks a lot.

Hi,
I have the same issue. Did you solve it?

Hi,
I found out how to solve this issue.
First, you need to clone the cocoapi to your python directory; for example,  /lib/python3.5/site-packages/
git clone https://github.com/cocodataset/cocoapi.git
Then cd into cocoapi/PyhtonAPI and run these commands:

2to3 . -w Note that you might have to install a package to get 2to3
python3 setup.py install

After installing it, add this line to your Makefile.config:
lib/python3.5/site-packages/cocoapi/common
this directory includes the maskApi.h file


Realsense as default torso down camera

Please merge together with https://github.com/ipa320/cob_common/pull/196


bufload loads file into nofile buffer

Steps to reproduce
From :help 'buftype'

nofile buffer which is not related to a file and will not be written

Literally, "not related to"... However this bash script
echo "why read me" >> ./foo
vim -u NONE \
    -c "let n = bufadd('foo')" \
    -c "call setbufvar(n, '&bt', 'nofile')" \
    -c "call bufload(n)" \
    -c "echo getbufline(n, 1, '$')"

Gives
"foo" 1 line, 12 bytes
['why read me']
Press ENTER or type command to continue

And they are related.
Expected behaviour
The buffer should be empty.
Version of Vim
9.0.77
Environment
Fedora 36
Logs and stack traces
No response

Plugins are broken now https://github.com/vim/vim/issues/10983


Clarify range of various ID values are 32 bit

Fixes #74427
3.x version #77232
There are various places where 32 bit values are used but they are generally cases where those values are provided by the engine, such as indices, the ID values however are provided by the user and can be out of range
If there are any I've missed feel free to point them out and I'll add them
This also makes me wonder if there's good reason to add indications of 32 bit values in the documentation
I would also even go so far as to suggest that any use of int in the codebase should be made explicit to int32_t, not sure if this has been discussed before but it can easily trap people as the fact that int is 32 bits (on almost all hardware, at least I suspect all that Godot supports) is not obvious to people looking into the code and adding documentation etc. (Especially if they're conflating it with GDScript) will see about a proposal for that later though

Thanks!

Thank you!

Cherry-picked for 4.0.4.


CA3009 - shall you mention sanitizers?

I am wondering whether the documentation shall be updated to list the sanitizers. WDYT?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc7b065c-09be-9384-2559-fbaed5c0f783
Version Independent ID: b9671a87-4b8f-11e7-d155-f4eb7a3d194b
Content: CA3009: Review code for XML injection vulnerabilities - Visual Studio
Content Source: docs/code-quality/ca3009.md
Product: visual-studio-windows
Technology: vs-ide-code-analysis
GitHub Login: @dotpaul
Microsoft Alias: paulming

@Evangelink -- Amaury, thank you for your attention to detail.
@Mikejo5000, @dotpaul -- Mike, Paul, there is a new handful of these CA* issues:
https://github.com/MicrosoftDocs/visualstudio-docs/issues/created_by/Evangelink

@Evangelink I'd be fine with sanitizers. It'd be good to list those under the "How to fix violations" section. Is that something you would be willing to pick up? 😀
FYI @mavasani for the other issues by by @Evangelink.

@Evangelink Do you have a link to the sanitizers? I'm unable to find them.

@Mikejo5000 Here are the two lists of sanitizers for this rule: general sanitizers and xml specific sanitizers.
Let me know if you have some trouble to read/understand the methods from the code.

@Evangelink So, to resolve this, can I add something like the following to the "How to fix violations" section?
Or, validate user input by using sanitizers for primitive type conversion and XML encoding.

LGTM, I don't think that was your plan but don't refer directly to the classes as they might move.

OK, thanks. I guess there's no official reference docs for these types.

Updating. Doc should go live around noon PST.

@Mikejo5000 Sorry to bother you but looking at the doc for this rule I think it would be better to have either a table listing the sanitizers or to have a separate documentation page to refer too.
Here is the list I have extracted from the code (note that I didn't put the url link to the documentation for each method but it might be nice to do so).
XML sanitizers
Microsoft.Security.Application.AntiXss.XmlAttributeEncode
Microsoft.Security.Application.AntiXss.XmlEncode
Microsoft.Security.Application.Encoder.XmlAttributeEncode
Microsoft.Security.Application.Encoder.XmlEncode
System.Web.Security.AntiXss.AntiXssEncoder.XmlAttributeEncode
System.Web.Security.AntiXss.AntiXssEncoder.XmlEncode
Primitive type conversion
bool.Parse
bool.TryParse
byte.Parse
byte.TryParse
char.Parse
char.TryParse
short.Parse
short.TryParse
int.Parse
int.TryParse
long.Parse
long.TryParse
float.Parse
float.TryParse
double.Parse
double.TryParse
decimal.Parse
decimal.TryParse
System.DateTime.Parse
System.DateTime.TryParse
System.TimeSpan.Parse
System.TimeSpan.TryParse
System.Number.ParseInt32
System.Number.ParseInt64
System.Number.TryParseInt32
System.Number.TryParseInt64

No problem. Thanks! I'll re-open this for now and plan the updates.

Updated content links


Created a subheading in the Features section and Adjusted the color o…

…f the heading of the same
Issues Resolved:#847
Created a subheading in the Features section and Adjusted the color of the heading of the same
Before:

After:

name: Pull_request_TEMPLATE.yml
about: use this template for creation of pull requests
title: '[FIX/Feat] '
labels: ''
assignees: ''

name: Pull Request Template
Description

Fixes : #847

Screenshots (if applicable)

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist

[ ] I have read the contributing document.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added necessary tests to ensure my changes are effective.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

Additional Information

there are conflicts, resolve. and some changes done, please review your code again. so that this pr don't make any blunder

All the issues has been resolved.


[Event Grid] [Event Hubs] [Service Bus] [Storage] Adding ActivitySource and migrating all DiagnosticScope.ActivityKind references

Contributes to https://github.com/Azure/azure-sdk-for-net/issues/37593
The ActivityExtensions were accessing these API's via reflection, so this doesn't change anything behaviorally. DiagnosticScope.ActivityKind is the same as Diagnostics.ActivityKind
There is more information in the following issues/PRs:

https://github.com/Azure/azure-sdk-for-net/issues/33683
https://github.com/Azure/azure-sdk-for-net/pull/37418

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.

I realized we don't actually need to migrate ActivityKind.

We need to add direct dependencies on Azure.Core for packages that haven't been released in a while because they are pulling in older Azure.Core references. These older references have the wrong version of System.Diagnostics.DiagnosticSource which is breaking the shared source build.


feat: add extra extra large responsive component

Changes:

Added ExtraExtraLarge screen size https://getbootstrap.com/docs/5.0/layout/breakpoints/
Updated tests
Updated documentation

This change is required for https://openedx.atlassian.net/browse/VAN-560

Coverage increased (+0.007%) to 90.623% when pulling f083f9e0c6c68d6ba4efe7e43a0da508b78d5e1c on zamir/VAN-560/add_extra_extra_large_display into eb5df8e47d6421166f2e4a3076130061ab2234e9 on master.

:tada: This PR is included in version 16.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix: Added react and react-dom to devDependencies

I'm having some conflicting issues when developing https://github.com/deamme/laco. I don't think fuse-box is using react and react-dom internally so this should be fine.

Just moved react and react-dom to devDependencies  instead of dependencies in package.json

Ooops, they snuck in there by accident


GPT-4 Examples

I read the page through to the end.  The only examples provided on this page are for GTP-3.5, nothing for GPT-4.  Where are the GPT-4 examples so that they can be incorporated.  Yes, I have already filled out the form and been approved to use GPT-4.  The response letter informing me that we can use GPT-4 is also lacking any specific GPT-4 examples, and so is any literature linked from it.  This is unbelievable.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 13994f3e-a96a-8804-4deb-7e0adad7f479
Version Independent ID: e087d8ce-bf3a-f12c-41dc-3ea924c6f089
Content: How to work with the GPT-35-Turbo and GPT-4 models - Azure OpenAI Service
Content Source: articles/ai-services/openai/how-to/chatgpt.md
Service: cognitive-services
Sub-service: openai
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@dodge1350-frp
Thanks for your feedback! We will investigate and update as appropriate.

Hi @dodge1350-frp
Currently, there are no examples available for GPT-4 as it is a very new model and still in the early stages of development. However, you can use the same Chat Markup Language (ChatML) format and the same API to interact with GPT-4 as you would with GPT-3.5, The main difference is that GPT-4 is expected to have even better performance and capabilities than GPT-3.5
In order to use GPT-4, you will need to specify the gpt-4 engine when making API calls.
If there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

@dodge1350-frp
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.
#Please-close


Update kv certs sync stack

Integrate Sync Stack into KV Certificates
Paging and Poller APIs will be updated later, once support for them lands in azure-core.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-security-keyvault-certificates

/azp run java - keyvault - tests

/azp run java - keyvault - tests

/azp run java - keyvault - tests

/azp run java - keyvault - tests

/check-enforcer override


Integrate neo4j-spark-connector into CAPS

remove GraphFrames dependency
remove GraphX dependency
transfer necessary code to CAPS
cleanup

Let's move this to trello


Carriage Returns/LFs stripped out of main.js

I always modify a few things in the main.js to get the specific format that I like. With the most recent update, I'm struggling to find my way around. Somehow almost all the newline/LF's (I'm not sure which?) have been stripped out. I can open a previous version of the file, and the LF's are as expected.
Is there an easy solution?
Thanks much!

I've opened this in Meld 3.20.4 and in Neovim 0.6.1 with the same results.

the main.js file is a minified production version,
So it does not keep the original source code format.

I will not recommend editing main.js file directly, because you will need to do it again and again for each new release.
If you still want to mofigy the main.js file,
You can build one and change the setting here to non production.
https://github.com/tim-hub/obsidian-bible-reference/blob/df5427aa04a2585f16adb70e5ea3937af89d14a1/scripts/esbuild.config.mjs#L41


CMake: Avoid Linux specific stuff in 3rd party builds

Some 3rd part src like MUSL use autoconf etc which are not available in Git Bash.
These need to be avoided so that they build on Windows.
CC: @soccerGB @andschwa

@ionutbalutoiu Would you please take a look at this?
The ask is to make the musl "build" cross-platform. Specifically, things like this and this won't work on Windows.
It doesn't have to ported to Windows immediately, but if we could replace these steps where we're calling musl's Autotools build system (the ./configure) with our own CMake code, that would get us a long way toward bringing it over.

@andschwa I'm afraid I don't have much experience with CMake/CMakeLists and I'll need a bit more guidance on this as I'm unsure on how to proceed.

@dragoshsch We'll pause for a bit, I'll ping you all again later on this.
@anakrish and @mikbras how likely is it that we could skip this work? Anand's branch doesn't actually require this to build ELFs (elves? 👅) on Windows, it seemed more of like a nice-to-have, as otherwise we're just relying on some Linux tools on Windows to provide Autotools. Mike, it sounds like musl will become an optional plugin in favor of elibc... so I am not convinced we need to do the work to build musl with CMake.

@andschwa  Yes, at minimum we need the changes on my branch to build elves on windows.

So let's change this from "CMake: Avoid Linux specific stuff in 3rd party builds" (which implies a fully cross-platform build for musl e.g. CMake) to "Make WSL a requirement for building elves on Windows" as the only changes for musl were to call bash (as in WSL) when running Autotools.
I think this is reasonable given the scope; it doesn't seem reasonable to rewrite the build for musl when most people will be using elibc instead (according to @mikbras).

First clarification with @anakrish, the dependency actually isn't even bash from WSL, it's bash from Git bash.
Second clarification, the elibc @mikbras had mentioned won't be exposed to the end user as the libc API, that'll still be musl.
So we still need to build musl in both places all the time.
I think the right call is to just require a bash equivalent (Git bash or WSL etc.) when building elves on Windows, and not to rewrite musl build system in CMake.
So this becomes the question: can we take that dependency? Avoiding that dependency requires writing that build system, which I don't think is worth it.

I am going to close this issue. We settled on using the Linux tools (e.g. Bash) when needed on Windows, via Git Bash (or WSL or whatever). Writing a new build system for musl is not required.


Add Nilearn plotting functionality to scona

[ ] I'm ready to merge

What's the context for this pull request?
(this is a good place to reference any issues that this PR addresses)

What's new?
Created visualisation tools for plotting with nilearn
Added tutorial to show how to use these tools

What should a reviewer feedback on?
Functions Implementation
Produced plots

Does anything need to be updated after merge?
(e.g the wiki or the WhitakerLab website)

compare this branch to Ruslan/master (eg PR 121)

Hey @wingedRuslan!
Can we adjust the view_connectome code so that the symmetric colormap works more intuitively? If the threshold is positive can we create a copy of the graph that sets all negative weights to 0 so we don't have to deal with them?
G_pos = G.copy()

for edge in G_pos.edges():
    if G.edges[edge]['weight'] < 0.0:
        G.edges[edge]['weight'] = 0

OR you can just do it from the adjacency matrix as that's what's passed to plotting.view_connectome.
The only slightly fiddly bit is figuring out the threshold - if its a number which is greater than 0 then that's easy, but if it is a percentage as a string you need to detect that its a string, drop the '%' character and then divide by 100 before you pass to np.percentile.
Does that make sense?

Hey @wingedRuslan - I'd love to get this merged in so that it can be in your final report! Can you fix the merge conflicts and ping me in gitter when you think the tutorials is good to be merged? I think its very close and so I'll try to find time either before or after the meeting to review.

@KirstieJane, sure, I plan to do this today! It would be great if you would have time after the meeting to review.


Remove HPO annotation

Description
Annotation in HPO is moved per our discussion.
Test Options

[x] fast test
[x] full test - HPO
[x] full test - NAS
[x] full test - compression

Checklist

[ ] test case
[ ] doc

How to test

/azp run integration test - local - linux


Adds tests for loading reporters w/ relative/absolute paths

@dasilvacontin How does this look for https://github.com/mochajs/mocha/issues/2772?

Coverage increased (+0.3%) to 88.501% when pulling 555a90ab4d1978ac1913e9c9247c7223d08664a5 on sul4bh:master into 73929ad851434a7253252ad054d37c40f9c692b9 on mochajs:master.

I totally botched the test in previously. It looks better now.

Coverage increased (+0.09%) to 88.277% when pulling bb799c293fdd51d51c799521f70a43202ad07834 on sul4bh:master into 73929ad851434a7253252ad054d37c40f9c692b9 on mochajs:master.

True, I thought of that when I saw the '+' concatenation, but I ended up forgetting to comment it. Good catch!

On 21 Apr 2017, at 01:49, Scott Santucci<EMAIL_ADDRESS>wrote:
@ScottFreeCode commented on this pull request.
In test/integration/reporters.spec.js:

describe('loader', function () {
it('loads a reporter from a path relative to the current working directory', function (done) {

 var reporterAtARelativePath = 'test/integration/fixtures/simple-reporter.js';

 var args = ['--reporter=' + reporterAtARelativePath];

 run('passing.fixture.js', args, function (err, result) {

   assert(!err);

   done();

 });

});

it('loads a reporter from an absolute path', function (done) {

 // Generates an absolute path string

 var reporterAtAnAbsolutePath = process.cwd() + 'test/integration/fixtures/simple-reporter.js';

For the first thing, path.join is real nice in terms of not having to care whether there's already a /.
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Coverage increased (+0.09%) to 88.277% when pulling f704aa3c981734176bbe3b6e1d6eda99b27cac71 on sul4bh:master into 73929ad851434a7253252ad054d37c40f9c692b9 on mochajs:master.

travis failure is due to a test infrastructure issue.

Reran, looks like that passed now.

LGTM, thanks @sul4bh! ❤


I am Zeljko from freelancer

Nice to meet you here.
I think it is better to contact out of freelancer for our long term relationship.
Could you share one of these?
discord, skype, telegram

<EMAIL_ADDRESS>this is my gmail

If possible, please add your social info like discord, skype and telegram here


Color picker history

📝 Color picker history
Display a list of the last (n) color picker values; display the Color, HEX value, and RGB value in the hsitory

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@Vasim-DigitalNexus thanks for a suggestion, this is already tracked by #5379, please have a look there and add more suggestions if your idea is not covered there.


⚠ ClamAV has degraded performance

In 49f91b3, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 588 ms

Resolved: ClamAV performance has improved in d4dc466 after 5 minutes.


epic: API and CLI to enable/disable CORS

Problem

Users are facing a CORS configuration issue when using a different frontend (eg ChatGPT)
Also encountered on test requests sent from the docs /api-reference site
We should offer the option to enable/disable CORS (similar to Jan API server)

Access to XMLHttpRequest at 'http://<IP_ADDRESS>:39281/v1/chat/completions' from origin 'https://cortex.so' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource

Success Criteria

Ensure it works on browsers (Safari may have stricter CORs)

Tasklist

[ ]

Reference bug reports

#1450
discord cortex-help:

@namchuai For this, let's quickly spec out an API and CLI for activating/deactivating CORS.

This API will be used to power Jan's API Server CORS toggle

For enable / disable CORS, I propose:
| > Note: Enable/Disable CORS will only be applied after server reset.
API interface
a. CLI
Update CORS configuration
cortex config cors on|off

Get CORS status
cortex config cors status

b. API

Thanks @namchuai!

Seems like we dont need to restart server, much better UX.
Can we add our 2 allowed_origins by default? http://localhost:39281, http://<IP_ADDRESS>:39281
Bug - Some requests fail on our swagger site:
with cors = true, allowed_origins = http://<IP_ADDRESS>:39281,
GET /configs works, but POST /models/start doesnt work (discord convo)

And thank you for adding docs! #1652

Hi @namchuai, 3 questions:

I turned CORS off but I am still able to send a request to http://<IP_ADDRESS>:39281/ (may be linked to below)
=> I expect to get a CORS error in console when I turn off CORS

API: PATCH cortex config --allowed_origins is not updated.
I expect allowed_origins to change from 3 to 0

I expect the allowed_origins to change from 3 to 2. CORs successfully updated to false.

Via CLI:
✅ Successfully adds / updates allowed_origins.

❓ But I cant remove the list of allowed origins (do I put empty list?)

@gabrielle-ong , the parameter requires a list, not a map, I can see you putting allowed_origins: {} which is not correct.

I see, gotcha on cortex-nightly config --allowed_origin and allowed_origins [] list

Here's the Configuration for CORS = off

But I can still send a chat completion

I see. Then checking - The test request swagger is incorrect? it shows {0: ..., 1: ...}

Here's the Configuration for CORS = off
But I can still send a chat completion

This is weird. I test on my end and I see that I have CORS error. Maybe we can jump on a quick call to solve it out.
I see. Then checking - The test request swagger is incorrect? it shows {0: ..., 1: ...}

You are right. Let me quickly update the example

@namchuai  thanks for checking and updating the example.
Sorry for the trouble. So no fix required -
I restarted the server and it seems to correctly get the CORS error
Setting CORs yes = successfully sends the request

Hmm, regarding the update docs, I was wrong. https://cortex.so/api-reference#tag/configurations/patch/v1/configs displayed correct. I'm suspecting this issue comes from scalar.

Thanks James for CORS! Closing it and separating the Scalar issue (local displays differently from deployed)


FR: Blast Network Support

SDK currently not supporting blast network

this has been added as of v3.4.1


Versions

Please can some tell me how versioning is working with allsky
The version in the version file is different than in the readme.md.
will the version and the readme.md be updated by every merge to master
It looks like it's not in sync. It would be handy if the version is shown in the WebGUI.
I have no idea where I am now, so mostly I look to the modification date of the files
Chris

@calberts   Chris,
With the current software we switched to releases called "vYYYY-MM-DD", which is what's in the version file.  We didn't fully implement this, but the next release will - the version file will match the README.md file and what appears in the log file.
We are only updating the current software with major bug fixes.  Everything else is being done in our "dev" branch.  When it's ready, we'll ask for testers, then merge the "dev" branch into the "master" branch and give it a new version number.
We'll then create a new "dev" branch.
I'm hoping that when we update the "master" branch with major bug fixes we also update the version file, probably by appending a point release of some kind.
I agree with putting the version number on the WebUI.  We also want to have it check if there's a new version, and if so, display a message.
When you created this Issue, did it present a green "Get Started" button?  Creating new Issues is supposed to display a template, but apparently didn't in your case.
Going forward, when you have a question, please add it to the Discussions link above rather than creating an Issue; we're trying to keep the Issue list to just problems so we know how much work we have to do.  Thanks.

Eric
Thanks for the answer,
Below the bug report, there is the possibility of opening a black request.
By the way clear answer
you are right in this in relation to. it was a time ago that I was here
Thanks for all the excellent work for this community
Chris

@calberts   Chris,  thanks for the "Thanks ...".  I enjoy doing it, especially when people say "thanks".
I hope I can find a way to get rid of the "blank request" on the new Issue page.  I really want people to use the template.


Cannot use skills

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
NA
FGA build number
1664
Describe the bug
After selecting a skill, the ok button isn't pressed. On my old phone fga was working fine.
Video
https://youtu.be/UFQ813QdduQ
Device model
Redmi note 10 je
Android version
12
Screen size
1080x2400
RAM
4gb

Skill Confirmation, it's part of the troubleshooting guide.


Error reporting when I run roslaunch quad_utils quad_gazebo.launch

The following error occurred in the terminal when I run roslaunch quad_ utils quad_gazebo. launch.May I ask if anyone has encountered it before? Thank you for your reply

Hi @nanbwrn,
Sorry for the late reponse, this looks similar to a problem I resolved in the past. Do you still need help with this, and if so, could I see your rviz settings (display tab), and if possible general information about your system (what branch are you currently using etc.) Checking the gazebo model path in your bash file could also help.
Best,
David Ologan

@nanbwrn I am facing the same issue. Can you please tell me how you fixed it? Thanks.

1.I updated Gazebo at that time:
sudo apt upgrade libignition-math2
2.Then, I updated this .sh file, opened the terminal at the quad_simulator directory, and entered: ./setup_deps.sh


Create a option for invitation link #463

Make sure you've reviewed the checklist. (DO NOT REMOVE)
🚨Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[x] Make sure you are making a pull request against the dev branch. Also you should start your branch off dev branch.
[x] Check you have included issue number in your pr (e.g #23).
[x] Check you have added tests that prove your fix is effective or that your feature works.
[x] Check your code additions will fail neither code linting checks nor unit test.
[x] Check you added any notable changes to the CHANGELOG.md file.

Description
Please describe your pull request.
💔Thank you!

Codecov Report

Merging #479 into dev will decrease coverage by 0.51%.
The diff coverage is 57.14%.

@@             Coverage Diff              @@
##                dev     #479      +/-   ##
============================================
- Coverage     76.64%   76.12%   -0.52%
- Complexity      401      408       +7
============================================
  Files           126      127       +1
  Lines          1340     1374      +34
============================================
+ Hits           1027     1046      +19
- Misses          313      328      +15

Impacted Files
Coverage Δ
Complexity Δ

app/Core/Http/Controllers/InvitationController.php
79.16% <79.16%> (ø)
5 <5> (?)

.../Core/Http/Controllers/Auth/RegisterController.php
71.42% <9.09%> (-22.33%)
11 <2> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989a380...38ad261. Read the comment docs.


Process with command powerup_manager exited with status 1

I'm on a macOS El Capitan with ruby 2.3.3 (rbenv). After upgrading some dependences in my project, I'm having a strange issue when running invoker.
Even if the processes are spawned, I got:
Process with command powerup_manager exited with status 1
And the DNS feature is not working. I need to load localhost:myport instead of myproject.dev
Here's the stack trace:
D, [2017-03-04T11:25:12.613585 #28482] DEBUG -- : Terminating 1 actor...
/Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/celluloid-0.16.0/lib/celluloid/calls.rb:39:in `check': wrong number of arguments (1 for 0) (ArgumentError)
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/celluloid-0.16.0/lib/celluloid/calls.rb:24:in `dispatch'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/celluloid-0.16.0/lib/celluloid/calls.rb:63:in `dispatch'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/celluloid-0.16.0/lib/celluloid/cell.rb:60:in `block in invoke'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/celluloid-0.16.0/lib/celluloid/cell.rb:71:in `block in task'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/celluloid-0.16.0/lib/celluloid/actor.rb:357:in `block in task'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/celluloid-0.16.0/lib/celluloid/tasks.rb:57:in `block in initialize'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/celluloid-0.16.0/lib/celluloid/tasks/task_fiber.rb:15:in `block in create'
	from (celluloid):0:in `remote procedure call'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/celluloid-0.16.0/lib/celluloid/calls.rb:92:in `value'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/celluloid-0.16.0/lib/celluloid/proxies/sync_proxy.rb:33:in `method_missing'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/invoker-1.5.1/lib/invoker/power/powerup.rb:17:in `block in run'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/eventmachine-1.2.2/lib/eventmachine.rb:194:in `run_machine'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/eventmachine-1.2.2/lib/eventmachine.rb:194:in `run'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/invoker-1.5.1/lib/invoker/power/powerup.rb:13:in `run'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/invoker-1.5.1/lib/invoker/power/powerup.rb:7:in `block in fork_and_start'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/invoker-1.5.1/lib/invoker/power/powerup.rb:7:in `fork'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/invoker-1.5.1/lib/invoker/power/powerup.rb:7:in `fork_and_start'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/invoker-1.5.1/lib/invoker/process_manager.rb:72:in `run_power_server'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/invoker-1.5.1/lib/invoker/commander.rb:39:in `start_manager'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/invoker-1.5.1/lib/invoker/cli.rb:49:in `start'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor.rb:369:in `dispatch'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/base.rb:444:in `start'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/invoker-1.5.1/lib/invoker/cli.rb:12:in `start'
	from /Users/progm/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/invoker-1.5.1/bin/invoker:7:in `<top (required)>'
	from /Users/progm/.rbenv/versions/2.3.3/bin/invoker:22:in `load'
	from /Users/progm/.rbenv/versions/2.3.3/bin/invoker:22:in `<main>'

@ProGM downgrading ruby to 2.3.1 fixed the problem for me


Sample code does not work as described for request body bindings

https://aqueduct.io/docs/http/resource_controller/#http-request-body-bindings
Answer I got back from @zoechi: Dart doesn't do type coersion.
This example doesn't work anymore.
`class City extends Serializable {
int id;
String name;
@override
void readFromMap(Map<String, dynamic> map) {
id = map['id'];
name = map['name'];
}
@override
Map<String, dynamic> asMap() {
return {
'id': id,
'name': name
}
}
}`
I guess you could change it to this. And ";" is missing in the return statement for asMap().
`class City extends Serializable {
int id;
String name;
@override
void readFromMap(Map<String, dynamic> map) {
id = map['id'] as int; // this had to be adjusted
name = map['name'] as String; // this had to be adjusted
}
@override
Map<String, dynamic> asMap() {
return {
'id': id,
'name': name
}; // this was missing
}
}`
And btw. Aqueduct is great!!!

This OK to close?

Yes, fine with me.


Peerflix doesn't kill streaming server on engine.destroy()

I have the following function, which is called every time a magnet is loaded into my peerflix app. It should kill the previous peerflix engine whenever a new 'engine' is created.
playStep1 returns the callback when I start a new playback instance, but it doesn't appear to actually destroy the streaming server (http://localhost:port).
var peerflix = require('peerflix');
var Q = require('q');

function(magnet){
//Step 1: Check if a torrent is streaming. If so, destroy the stream.
	function playStep1(){
		if(GLOBAL.engine !== undefined){
			engine.destroy(function(){
				console.log('Destroy');
			});
		}
	}

	//Step 2: Start up new torrent stream
	function playStep2(){
		GLOBAL.engine  = peerflix(magnet);
	}

	//Step 3: When torrent stream is available, add it to GLOBAL.magnets array
	function playStep3(){
		engine.server.on('listening', function() {
			GLOBAL.magnets[streamCount] = magnet;
		});
	}

	//Up the streamCount so the next magnet link can get saved in GLOBAL.magnets[streamCount]
		function playStep4(){
			streamCount++;
		}

	Q.fcall(playStep1)
	.then(playStep2)
	.then(playStep3)
	.then(playStep4)
	.catch(function(error){
		console.log(error);
	})
	.done();
}

I think currently you need to call engine.server.close() as well. Could you try and see if that works? If so we should do that automatically

quoted @mafintosh from this comment: https://github.com/mafintosh/peerflix/issues/190#issuecomment-77683863

@jaruba I tried the way you described in the referenced thread and it indeed closes the server when called without Q promises. However doing this without promises kills the next engine created in playStep2.
When I chain the process (to make sure the new engine creates when the previous one is destroyed), playStep1 never returns 'Destroyed':
function playStep1(){
    var deferred = Q.defer();
    engine.server.close(function() {
  		 engine.destroy(function(){
                     console.log('Destroyed');
                     deferred.resolve();
                });
     });
      return deferred.promise;
 }

could you throw some console.log()'s in there to see which event callback function isn't triggered?

@jaruba When I console.log(), everything before engine.server.close is logged. Nothing after. I can also properly return engine.server.address().port, so engine should be properly defined.

Yeah, just realised it was a dumb question, only server.close could of been the issue. :)
What is your streaming server doing? If it is in use when you try to close it (ie: streaming to something), then it will not close until it is released by all current clients.

@jaruba That was it it! My client isn't closing the stream URL. Thank you @jaruba for the insight :100:
It would be nice to have a 'force' option for engine.server.close, to force closing the stream even if it's open in client.

It would indeed be nice.. peerflix uses http.Server to create the server.
From the docs:

server.close([callback])#
Stops the server from accepting new connections and keeps existing connections. This function is asynchronous, the server is finally closed when all connections are ended and the server emits a 'close' event. Optionally, you can pass a callback to listen for the 'close' event. If present, the callback is invoked with any potential error as the first and only argument.

Looking at the docs, you can see there is no way of closing any connection to a client from the server-side.
More so, everything in the http.Server API seems to only affect future clients, even setting the server timeout would not disconnect or change the timeout setting of already connected users.

@jaruba If I engine.server.close, but not engine.destroy() does peerflix basically become torrent-stream with the torrent continuing to stream (except not to the http.Server)?

continuing to stream

You mean "continuing to download"? Yeah, it should continue to download the files normally, just doesn't use a server to stream the files.

@iadj Apparently there is a way to close the connections from the server side, it's just not developer friendly:
http://stackoverflow.com/questions/18874689/force-close-all-connections-in-a-node-js-http-server#answer-18875088


Verifying signature of image in golang or java code

Hi Team,
We have a product which plays around docker images /oci artifacts. This product has implemented using GOLANG and JAVA. We have started using COSIGN to sign images externally. But currently we are directly processing those images in our product without doing any signature verification. Now we want to implement code to verify signature of every image before processing it.
SO can you please help whether there are any third party libraries which can help to code in GOLANG or JAVA to verify cosign signed image signatures?.. Please let us know if there are any examples documented...
Thanks..

@surendrababuravella Have you had a look at sigstore/policy-controller?

Hi @hectorj2f,  Thank you for your quick response.
Our product is a standalone application written in JAVA/GOLANG. It doesn't need Kubernetes. Policy-controller won't be useful here.
We need to add signature validation capability as part of our product by implementing respective code in JAVA/GOLANG. Can you suggest on this please..

You can use Cosign as an API, take a look at https://github.com/sigstore/cosign/blob/main/pkg/cosign/verify.go. The Kyverno project has an example of that. We also have an example of verifying OCI images using our newer sigstore-go library: https://github.com/sigstore/sigstore-go/tree/main/examples/oci-image-verification
The sigstore-java (https://github.com/sigstore/sigstore-java) library does not support OCI images, though you could open an issue there if you wanted to contribute that feature.

Thank You @haydentherapper for your help ..