Wrapping the Button class inside a component will make autoclose stop working

Describe the bug
If I have a Modal, and a component inside that modal that in turn contains a button, then autoclose will not work anymore.
It only works for buttons directly in the modal.
Reproduction
<Modal autoclose> <ButtonWrapper></ButtonWrapper> </Modal>
ButtonWrapper.svelte:
<Button>Will not autoclose</Button>
Flowbite version and System Info
"flowbite": "^1.6.5",
    "flowbite-svelte": "^0.37.4",

I can't confirm that behaviour. Please check that REPL example.
This shows the correct ring behaviour as well (see #961)
Did I misunderstand your issues?

Thanks, I try the latest version then.


Netlify CMS commits that are signed with a verified signature.

Is your feature request related to a problem? Please describe.
We try to enforce signed commits on our projects to ensure people are who they say they are when they commit to a repo, but we have to turn this setting off when creating repo's that can be committed to by Netlify cms.
Describe the solution you'd like
A way to have signed commits, possibly verified by using gpg keys.
Describe alternatives you've considered
Making a specific github account/repo seperate for the cms commits.
Additional context
There may be a way to do this currently that I can't think of or find an idea on how to start going about it.

Thanks for opening this @christopherdufort, there are two challenges here:

Finding a secure way to distribute the signing keys. I believe this will require some kind of backend that matches the user to its signing key and then prompts for the signing key password. Having a backend that stores all signing keys requires some considerations as well.
Implementing commit signing in the browser using JavaScript. This might server as a good reference.

I am also looking for a solution to this problem also.
I am not making claims to know how the backend works but I have some ideas how this could be implemented.
I'm thinking of something similar to a 2FA using a YubiKey or Windows Hello in the browser. Perhaps there could be a browser extension (or browser API) similar to mailvelope, that stores and handles your keys locally. But not just for Netlify CMS, instead any website could use this API. The website could send the information it requires signing, the format for signing, and perhaps a public key it's expecting. If the extension has the corresponding private key, and is configured to sign in the format requested (git in this case). Your browser will then prompt the user, do you want to sign this? then prompt for password. Your browser would reach out to the configured app (git) to request signing as if it was done locally, then pass the signed request back to the website to be processed as normal.
I just want to be able to use my keys in more places online as a way to verify or encrypt my activity with various websites. Without having to do everything from the command line or a local program.
Now if anyone understands that, congratulations. I am autistic and communication is not a strong point for me. But I believe something like this could be accomplished. I don't know if there would be an security implications because of it, but I still think it's possible. I just don't know how to make it happen, otherwise I would be building that extension right now.

I too would like this feature. Why complicate things when you can just use the GitHub API (Or other APIs for other backends) to add an SSH key to the repo Netlify CMS works on? Just like actual netlify does


submissions: fix ungraded filter

The ungraded filter has no effect on assignments which should not be handed in.

This was fixed by 2df11e1.


Bug (1.18) - Nether ores have incorrect sounds

Describe the Bug
The nether based ores (Heart Rhodonite, Power Pyrite and Kinetic opal), have basic stone sounds, in contrast to other nether ores like nether quartz.
Reproduction Steps
1.Mining ore (be the mining master)
Expected Result
Hear stone
Screenshots and Videos
No response
Operating System
Windows 10
Mod Version
2.1.0
Minecraft Version
1.16.5
Forge Version
111
Other Mods
No response
Additional Context
No response

Fixed by #24


Also Unable connection to the captcha server

#29 fixes the curl side so it might be nice to fix the get_file_contents side too.
You could catch the exception and incorporate the error message into the exception message.
Better still remove the @ and let the original exception get thrown upwards as it has all the information you need to address the problem.
ReCaptchaValidator
    protected function getResponse($request)
    {
        if ($this->grabberType === self::GRABBER_PHP) {
// remove @ to reveal exception
            $response = file_get_contents($request);

            if ($response === false) {
                throw new Exception('Unable connection to the captcha server.');
            }
        } else {

From Eclipse debugger:
$this	yii\\web\\ErrorHandler
$exception	yii\\base\\ErrorException
	*Exception*previous	null
	*Exception*string	""
		length	0
	*Exception*trace	Array [12]
		[0]	Array [7]
			[function]	"getResponse"
			[type]	"->"
			[class]	"himiklab\\yii2\\recaptcha\\ReCaptchaValidator"
			[file]	"/Applications/AMPPS/www/witp/web2/yii-application/vendor/himiklab/yii2-recaptcha-widget/ReCaptchaValidator.php"
			[line]	99
			[params]	Array [1]
				[request]	""
					length	0
			[args]	Array [1]
				[request]	""
		[1]	Array [7]
		::
		[11]	Array [7]
	code	2
	file	"/Applications/AMPPS/www/witp/web2/yii-application/vendor/himiklab/yii2-recaptcha-widget/ReCaptchaValidator.php"
	line	115
	message	"file_get_contents(): SSL operation failed with code 1. OpenSSL Error messages:\nerror:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed"
	severity	2
	xdebug_message	"
( ! ) yii\\base\\ErrorException: file_get_contents(): SSL operation failed with code 1. OpenSSL Error messages:\nerror:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed in /Applications/AMPPS/www/witp/web2/yii-application/vendor/himiklab/yii2-recaptcha-widget/ReCaptchaValidator.php on line 115
\n
Call Stack
\n
#	Time	Memory	Function	Location
\n
1	0.0059	144284	{main}(  )	<td title='/Applications/AMPPS/www/witp/web2/yii-application/fro"

iam using the invisible one but ... the same error (classic recaptcha work fine)

@davidnewcomb Thanks for commenting helped me to see that the problem was similar to its more was an option that is disabled in my hosting.

Is there a reason why GRABBER_PHP is the default value for $grabberType? I think GRABBER_CURL should be default, cause curl is much more reliable than file_get_contents (which most providers disable for security reasons anyway). @davidnewcomb


zhs translation - Add thanks to Rita-B in Github and Steam new and future versions (translation is now part of the main code)

Done!


Fixes frame of PINAnimatedImageView initializer

          1 Warning

:warning:
Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

  Generated by :no_entry_sign: Danger

Please add a test.

I'm going to let this one slide without a test…


Add ClearSiteDataMiddleware

Add a ClearSiteDataMiddleware and respective django settings.
CLEAR_SITE_DATA_URL_WHITELIST -  whitelist of URLs that Clear-Site-Data response header is applied to (eg. /accounts/logout/)
CLEAR_SITE_DATA_DIRECTIVES - what directives to apply (defaults to wildcard)
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Clear-Site-Data

I think there is a doc or README we need to update to document the new middlewre

I think there is a doc or README we need to update to document the new middlewre

Looks like docs are autogenerated based on index.rst

This MR and the other look good to me.  I haven't tested it, but I can if you'd like me to. CR +1.

I think there is a doc or README we need to update to document the new middlewre

Looks like docs are autogenerated based on index.rst

I don't think the README file gets auto-updated though; I just remember having to manually update that every time I modify a middleware.

@RouganStriker Oh right! Good call I forgot about the list of middlewares there

+1.


Ability to optimistically update detailShape

Is your feature request related to a problem? Please describe.
Currently, optimistically updating detailShapes with useFetcher (from another resource) is not possible. This is because the destResults passed into updateFunction is replaced with its primary key.
Describe the solution you'd like
I'd like to have a way to optimistically update a resource's detailShape from a different resource.

This is also related to https://github.com/coinbase/rest-hooks/issues/179


[devops:bot] update deps in nix/sources.json (from: rhino-core@ff32666

update nix refernces for rhino-core and|or nixpkgs to match https://github.com/rhinofi/rhino-core/blob/ff3266693a49ff6adb07f57d0299eae9bd1286d1/nix/sources.json (branch: dev)

superseded by #107


No page is returned localhost:8000

My OS is win10, the page localhost:8000 is loading forever with nothing returned

Not sure if it will help but i did "localhost:8000/example/" and it worked.


Sorry, didnt know how to contact you. So using this. :(

Hello :)
I would love to understand the process of location the correct addresses inside the byte array.
AFAIK the decrypted save file is differently sized for everybody. How does it work that you can locate the correct address? For example: my player name is stored inside the offset of: 0x2570 but for other people it will be 0x3680. Is it understandable what I mean? Sorry to disturb and missuse the issue tab. An explanation would be golden tho :)

The game serializes the save structure using ZeroFormatter and saves it as a file. Reading the save involves deserializing the file back into the save object


Handle High issues from Fortify scan of lib-nist-validator.

fortify issues have been resolved previously


Update test

A part of #16756
Signed-off-by: Hu Keping<EMAIL_ADDRESS>

@HuKeping gofmt failure :/

Updated @LK4D4  and the windows failure seems not related.

@HuKeping cool ! :wink:.
Note there is a pkg/integration/checker package that defines additionnal checkers (one for now :sweat_smile:), and I'm working on a library to provide more (shakers) that I think could be integrated when more complete.

Hi @vdemeester  have you came to conclusion that we should
use checker.Contains() instead of check(string.Contains(), check.Equals, true)
use check.NotNil instead of check.Not(check.IsNil)
waiting on line :)

@HuKeping I would tend to alsways use checker.Something here and everywhere (even if it's a built-in one, that makes us have more control on the checkers). I tend to prefer NotNil than Not(Nil) :stuck_out_tongue_closed_eyes:.

@vdemeester get it :smile:

Updated @vdemeester

Thanks @cpuguy83 @vdemeester , PR updated.

@cpuguy83 updated

LGTM

LGTM


Add X-Forwarded-For header in proxy to API server.

Add X-Forwarded-For header so that the API server has the proper end-user IP address in the req.ip field.

Thanks for your pull request !


feature: metrics for sql query\execute

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

using opentelemetry
and the metric is about

time cost
what kind of query: select / delete / update

assign to me


feat: update starknet.py

What I did
Updated starknet-devnet, and starknet.py.
How I did it
How to verify it
Checklist

[x] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[x] PR title follows Conventional Commit standard (will be automatically included in the changelog)

It seems it will be stuck until https://github.com/ApeWorX/ape-cairo/pull/15 + new ape-cairo release.


Point to function for consistency check

Fixes a bug from recent changes that would cause server to fail to start.
Traceback (most recent call last):
  File "server_dev.py", line 7, in <module>
    ga4gh.cli.server_main()
  File "/Users/david/ga4gh/server-1/ga4gh/cli.py", line 77, in server_main
    args.config_file, args.config, args.port)
  File "/Users/david/ga4gh/server-1/ga4gh/frontend.py", line 206, in configure
    dataRepository.checkConsistency()
AttributeError: 'FileSystemDataRepository' object has no attribute 'checkConsistency'

+1 - see the problem, above solution fixes it. @jeromekelleher @dcolligan extend test coverage to checking that the server_dev.py process starts up OK on a sample dataset?

+1

Good idea @macieksmuga ... see #898


Fix link hook typo

Fixes a typo in the link hook implementation.
cc @dcharkes
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@mosuem Is this ready to be merged?

@andrewkolos Yes! :)


readFile behaviour not aligned with fs module

I detected 2 issues when using readFile that is different from the "fs" module counterpart:

encoding cannot be passed in as a string in the second parameter
data.Body.toString(encoding) is only called when using the non-promise version of the method  causes inconsistencies in its usage: https://github.com/RiptideElements/s3fs/blob/master/lib/s3fs.js#L199

We actually support passing in Encoding to both readFile and writeFile as the parameter in lieu of an options object.
I do see the inconsistency that you are talking about for readFile with a promise. The original intention of that was because when reading a file from S3 you might also want to grab the Hash of the file or metadata stored by S3.

Yes, I saw that passing the encoding as an options object would do. It's really no big deal. Just pointed out the inconsistency with "fs" because I'm using your library and "fs" interchangeably, and these things popped out when using "readFile".

I definitely understand @demetriusnunes. I'm not trying to push back on it and say the way it works currently is 100% correct. I just need to do some investigation on the impacts of this and it will definitely be a Major version bump since it will fundamentally change how the readFile function works.
I'm thinking that a new option will be introduced which will make the current functionality work so that you receive the return from the S3 API instead of the standard FS return. That way it is explicit and we can still support retrieving a file and getting the metadata about it without having to do an extra Head call (minimizing this to a single call to get object metadata is definitely something we use in a number of our projects so they are more performant).


Edge doesn't support all wasm features needed

Fixes #6540

Can confirm the issue is fixed.  Since Edge will eventually support wasm, we will probably need a better check in the long run.  Please write up an issue with this workaround.  Thanks.


Have separate update/delete queries for table models

This should address the issue in #75
Let me know what you think @inoc603

So now if I were to use UpdateAll, looks like the entry would be:
sqlResult, err := models.VideoTable.UpdateAll(ctx, db, mods...).Exec()

I don't have anything against it, but the UpdateAll method used to return (int64, error). Maybe we could add a wrapper around it or return only RowsAffected so the return types can stay the same?

Maybe we could add a wrapper around it or return only RowsAffected so the return types can stay the same?

Done. Makes sense to only return rows affected. Insert/Delete operations would not need LastInsertID anyway

LGTM.
BTW Implementing bob.Mod on Setters is a really nice idea. It actually inspired me to make some of my own types into Mods and works really well.

Yeah. It makes me really like the query mod system.


Track licenses for each data pointers and records

We need to decide what we want to do wrt. licenses for data.
See https://cve.mitre.org/about/termsofuse.html for instance for the CVE/NVD.
There are a few ways to think about this:

we are storing only pointers so there is no licenses issues to track as we are not storing third-party data
we are storing only pointers and caching existing data so we should handle this in a way similar to what search engine do.
we are storing data so we should track licenses either per-record or per source

Each of these cases may have an impact of the resulting data licenses, which should be as open as possible (ideally some CC0-1.0)

Another take on this topic: we are building open tools to collect, aggregate and redistribute a free and open software vulnerability database. At a high level we are keeping pointers/references and relate together many vulnerability records and software package versions they impact.
A pointer/reference is typically a URL and an ID to vulnerability information and to packages such as these below that are all related together:

https://bugzilla.redhat.com/show_bug.cgi?id=813428
https://nvd.nist.gov/vuln/detail/CVE-2012-0217
https://lists.xen.org/archives/html/xen-announce/2012-06/msg00001.html
https://www.debian.org/security/2012/dsa-2508
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677297
https://www.openwall.com/lists/oss-security/2012/06/12/1
...

We have a few areas where we would need some help and make some decisions soon enough:

we want the data we re-distribute to be as open as possible (ideally
some kind of CC0),

the data we collect are itself under a variety of more or less open
licenses, but all available publicly, and we need to decide:

what data we can aggregate or not based on licenses?

what if we keep only pointers/URLs as opposed to actual details of
the records?

should we track the license of individual records or not? (and also
based on what data we keep)

I did have an extensive chat with @LeChasseur on that topic and some of the key points are:

while a single vulnerability record may not be copyrightable, databases can be copyrighted
on top of that, Europe has a notion of "sui generis" rights that may apply when data comes originally from Europe. It does not extend to non European data
the cleanest way to promote reuse for the data we create (and for any right in the aggregate) is to use a public domain CC0-1.0 dedication. We could request but not demand some attribution. Anything else makes the data rather problematic to reuse, and we want to promote maximum reuse.
we would need to track at the minimum the license if any of each data source.
some data source may be out of reach for us to redistribute as aggregates based on their licenses

Some pointers about possibly problematic sources:

RedHat victims: https://github.com/fabric8-analytics/victims-cve-db data is CC-BY-SA (was AGPL https://github.com/victims/victims-cve-db/commit/86df6d7c14c11c41a60db8ebffdaa8409f856ead#diff-e0903c27550bef075e6af0bb73039f25 )

Suse CVRF and OVAL data is CC-BY-NC which makes completely non open and impractical to reuse
See ftp://ftp.suse.com/pub/projects/security/cvrf/cvrf-suse-su-2017%3A2968-1.xml

<DocumentDistribution xml:lang="en">
Copyright SUSE LLC under the Creative Commons License 4.0 with Attribution for Non-Commercial usage (CC-BY-NC-4.0)
</DocumentDistribution>

RedHat RHSA CVRF and OVAL data only has a "Copyright © 2019 Red Hat, Inc. All rights reserved."
https://www.redhat.com/security/data/cvrf/2019/cvrf-rhsa-2019-3300.xml
https://www.redhat.com/security/data/oval/

Pyup https://github.com/pyupio/safety-db is also CC-BY-NC

Snyk was AGPL but this is completely stale and non open data now so we will not use it https://github.com/snyk/vulnerabilitydb/tree/43c0cce02216dac20ef22441c6a3f50c995f5d55

https://github.com/fabric8-analytics/cvedb does not have a clear license for now but may be entirely aggregated from other sources

This is best handled a tad later to decide how we will implement license tracking possibly in #123
This is important enough to defer to the next milestone.

Slightly off-topic comment, but here we go :)
I am no longer involved with https://github.com/fabric8-analytics/cvedb but it should only contain data collected from NVD (there is a dummy bot which scans NVD once a day and opens pull-requests in the database repository for further review/human curation 1). AFAIK, the team never decided on what license the database should use.

Things which we already use, without clarification of LICENSE. We need to reach/dig deeper  these sources

[ ] https://gitlab.alpinelinux.org/alpine/infra/alpine-secdb

[ ] https://security.archlinux.org/json

[ ] http://ftp.suse.com/pub/projects/security/yaml/

[ ] https://usn.ubuntu.com/usn-db/database-all.json.bz2

[ ] https://api.github.com/graphql

[ ] https://anongit.gentoo.org/git/data/glsa.git answer maybe found on https://www.gentoo.org/support/security/

See also https://github.com/nexB/scancode-toolkit/issues/2143 for the Rubysec data

See also #277

Suse CVRF and OVAL data is CC-BY-NC which makes completely non open and impractical to reuse
See https://ftp.suse.com/pub/projects/security/cvrf/cvrf-suse-su-2017%3A2968-1.xml

Suse has changed (some? all?) its vulnerability data license from CC-BY-NC-SA to CC-BY

https://ftp.suse.com/pub/projects/security/cvrf/cvrf-suse-su-2017%3A2968-1.xml : "The CVRF data is provided by SUSE under the Creative Commons License 4.0 with Attribution (CC-BY-4.0)."

https://ftp.suse.com/pub/projects/security/oval/ : "SUSE OVAL data is supplied under Creative Commons license, with Attribution (CC-BY-4.0)."

https://www.suse.com/support/security/oval/ : "The OVAL data is provided by SUSE under the Creative Commons License 4.0 with Attribution (CC-BY-4.0)."

Though there is still some global ambiguity based on the text of https://ftp.suse.com/pub/projects/security/cvrf-cve/LICENSE

_The SUSE CVRF data is provided by SUSE under the Creative Commons license,
with Attribution for Non Commercial use:
CC-BY-4.0
https://creativecommons.org/licenses/by/4.0/_

And based on https://ftp.suse.com/pub/projects/security/cvrf/cvrf-opensuse-su-2015%3A0255-1.xml or https://ftp.suse.com/pub/projects/security/cvrf1.2/cvrf-opensuse-su-2015%3A0225-1.xml we still have some records with this:

The CVRF data is provided by SUSE under the Creative Commons License 4.0 with Attribution for Non-Commercial usage (CC-BY-NC-4.0).

But even in the same data source we have other licenses in https://ftp.suse.com/pub/projects/security/cvrf/cvrf-opensuse-su-2016%3A1623-1.xml

Copyright SUSE LLC under the Creative Commons License 4.0 with Attribution (CC-BY-4.0)

So this is a bit messy. I am reaching out to Suse security by email.

I sent this to<EMAIL_ADDRESS>
Hi:
Thank you for changing most of your vulnerability data license to CC-BY somewhat recently.
Yet there are still some problems with leftover CC-BY-NC.
Because of this, it makes the data difficult to consume automatically as each record need to be cherry picked based on its licenses allowing or not allowing usage (CC-BY-NC essentially prohibits any usage beyond mere reading)
May I suggest to use the plain CC-BY license consistently everywhere?
Or update your web pages and top level license notices to be consistent to alert that there is a mix of CC-BY and CC-BY-NC?
Thank you for your kind consideration!
For extra details, please see https://github.com/nexB/vulnerablecode/issues/63#issuecomment-1134425600 for reference that I am pasting here:

And we got a super speedy reply from SUSE security team:

Sorry for this oversight that it was not done consistently.
(the ones affected were not being regenerated by the tooling.)
I now did a massive replacement, and all of cvrf files should be fine.
Also adjusted the LICENSE files in the directories.

Thank you ++ SUSE!

I chatted on the side with Ubuntu folks on their IRC:
on libera.chat #ubuntu-security
This is about

#1051
#754

pombreda> Philippe Ombredanne Hiya :) What the license for the security data at https://ubuntu.com/security/notices (and the usn-db dump)
6:51 PM And the license for https://ubuntu.com/security/oval reports itself as GPL and I do not know what to do for data with a GPL.
6:51 PM Who to talk to?
6:51 PM FWIW, we aggregate this in our little project at https://github.com/nexB/vulnerablecode/blob/main/vulnerabilities/importers/ubuntu.py and https://github.com/nexB/vulnerablecode/blob/main/vulnerabilities/importers/ubuntu_usn.py and we like to have a license for that!
6:52 PM Debian did not have a license ... but that was clarified at https://github.com/nexB/vulnerablecode/blob/main/vulnerabilities/importers/debian_oval.py
 Steve Beattie pombreda: hey, thanks for the question, and apologies that we don't have explicit terms on this stuff. In general, we want people to be able to consume, integrate, aggregare, and use the data presented in tools like nexB (so long as the data is represented accurately).
7:19 PM I'll poke people internally about getting more explicit statements in place.

With https://github.com/aboutcode-org/vulnerablecode/issues/1393 we could add a field at the advisory level to track its license, but on the other hand we are tracking the license consistently for each importer. I am closing this now.


Optimize cat

This provides a simple optimization where concatenate3 tasks can be merged if they are concatenating different slices of the same array.

Cool work @laliberte .  Because this PR is performance-conscious it would be good to see a couple of benchmarks for the kinds of computations with which it helps and also benchmarks on unrelated computations, to make sure that it doesn't negatively impact performance (array optimzations are sometimes bottlenecks)

I've written this PR as part of a slightly larger project. I don't know if this is something that fits with your vision for dask but I think I've figured out a way to allow targets of array.core.store to be sliced dask arrays.
The use case is simple:
import h5py
import dask.array as da
source = da.from_array(h5py.File('source_file.h5', 'r')['x'], chunks=(1, 100, 100))
#e.g. source.shape = (1000, 10000, 10000)
dest = da.from_array(h5py.File('large_dest_file.h5', 'a')['x'], chunks=(1, 100, 100))
#e.g. dest.shape = (10000, 10000, 10000)
da.store(source, dest[:1000, ...])

This idea is to allow array.core.store to store to a subset of the destination array. At the moment it works well but it requires the optimize_cat PR.
Where should we go from here?

The problem with optimizations is that they get applied to all computations and can slow things down or introduce odd bugs.
If your goal is to support that particular use case then there might be more narrow changes that we can make to solve that need without having to affect all computations.
For example, perhaps da.store should take an extra argument that allows you to specify a certain sliced region within the target.

My idea was to minimize options as much as possible and leverage dask internals.
What if I submit my da.store PR with the concatenation optimization but only apply the optimization in that narrow case? Then, in the future, the optimization could be benchmarked and added? Is this something that could make sense?

Adding a region= keyword to da.store seems simpler me.

I agree with Matt on this one - optimization passes can interact in unexpected ways, increase overhead, and are much harder to maintain than an special purpose functions. In most cases it works out better to create the graph you want originally (in this case by adding an option to da.store) instead of trying to change it with optimizations later.

That makes sense. I'll close the PR and resubmit a more targeted version.
Would any of you see any inconvenience if I was to keep the optimize_concantenate for my implementation but remove it from optimize?


Develop

@rafhaini it seems that this PR was created by mistake. Closing it to avoid accidental merge :)))

@rafhaini are you running into some bugs with a spec? I see some of your modifications.
https://github.com/rafhaini/iso8583/commit/bd4cffe65cd486c037ece5ff91daf17b9c2b5543#diff-2ce052ca28a77c3b54be26bfc568dddef91bf239253d0ad537609af1731032d4


add auth headers for

const images = [
    {
        url: `${this.props.uri}`,
        props: {
            headers: {
                Authorization: `Bearer ${this.props.authToken}`
            }
        }
    },
];

headers in props not working.
it looks like headers property only works like this:
<Image
    source={{
      uri: 'https://facebook.github.io/react/img/logo_og.png',
      method: 'POST',
      headers: {
        Authorization: `Bearer ${this.props.authToken}`
      },
      body: 'Your Body goes here'
    }}
/>

However, in the source code line 545, there is no image.props.headers passed into the source property.
Thanks.

Good question! Now 2.1.3 is released, and you can add header to image by this following code:
const images = [
    {
        url: `${this.props.uri}`,
        props: {
            source: {
                headers: {
                    Authorization: `Bearer ${this.props.authToken}`
                }
            }
        }
    },
];

Thanks for your reply!
Unfortunately it looks like the props is still not working.
but all the images that do not contain props work perfectly as always

I tried this input:
{
  url: "https://avatars2.githubusercontent.com/u/7970947?v=3&s=460",
  props: {
    source: {
      headers: {
        Authorization: `Bearer`
      }
    }
  }
}

And final props passed to <Image> is like this:
finalProps Object {
  "source": Object {
    "headers": Object {
      "Authorization": "Bearer",
    },
    "uri": "https://avatars2.githubusercontent.com/u/7970947?v=3&s=460",
  },
  "style": Object {
    "height": 375,
    "width": 375,
  },
}

Is there anything wrong?

Everything looks great to me.
However, the images that require auth headers to load still do not show up.
My work-around is: Ask the backend guys to change the image source to not requiring an auth headers, use a token in the uri instead 😵
I'll come back to this issue and look into it more when I got time.
Thanks for your help!

Guys, It still actual, I tried to look through code and noticed that:
{
  url: "https://avatars2.githubusercontent.com/u/7970947?v=3&s=460",
  props: {
    source: {
      headers: {
        Authorization: `Bearer`
      }
    }
  }
}

is the proper way, but nothing works, how can we set up headers?

The same issue still continues..

I did exactly like this, but it is not working.. I can not see the header at my server..

@kyhnlbyrk You can try renderImage to custom the image element.

I also have this problem, the problem by the way seems to be that width and height are not being set to the Image component when it comes from a remote (and uses bearer?), that produces probably an image of 0 width and height, look at this:
props Object {
11:45:09 [exp]   "source": Object {
11:45:09 [exp]     "headers": Object {
11:45:09 [exp]       "Authorization": "Bearer somebearer",
11:45:09 [exp]     },
11:45:09 [exp]     "uri": "http://someurl/to/img.jpeg",
11:45:09 [exp]   },
11:45:09 [exp]   "style": Object {
11:45:09 [exp]     "height": undefined, // <------ problem here
11:45:09 [exp]     "width": undefined,  // <------ problem here
11:45:09 [exp]   },
11:45:09 [exp] }

@jper92 By default, will get width and height by url field: source code. So if you give params like this, will got right width and height:
const images = [
    {
        url: `http://someurl/to/img.jpeg`,
    },
];

but if you use like this:
const images = [
    {
        props: { source: require('../img.jpeg') }
    },
];

It won't fetch width and height, so get undefined. And one way is to define it's width and height:
const images = [
    {
        props: {
          source: require('../img.jpeg'),
          style: { width: 100, height: 100 }
        },
    },
];

Thanks, the downside is (as far as I know), I cannot get the size of a remote image requiring a custom header like a bearer token, unless I manually download it and store to local disk. The workaround works almost fine, but the image won't display completely full size due to the proportions

I'm going to create a fork of this to use Fast Image - which provides the size onLoad by default

You definitely have to add  width and height like the following:
const imageViewer = [{ 			url: ${img_url}, 			width:width, 			height:height, 			props:{ 				source:{ 					headers:{ 						Authorization: Bearer ${access_token} 					} 				} 			} 		}]

@kyhnlbyrk You can try renderImage to override the image element.

render your own image and everything will work like charm.

//Get width/height:
import {Dimensions} from "react-native";
const windowWidth = Dimensions.get("window").width;
const windowHeight = Dimensions.get("window").height;

//Array with images:
{
    url: x.payload.image.thumb_urls.md,
    width: windowWidth,
    height: windowHeight,
    props: {
        source: {
            headers: {
                'x-authorization': 'Token ' + this.props.token,
            }
        },
    }
}

It's working like a charm without problems!
Note:
When I didn't set width/height propert then I got black screen for every image except the first one. This is a workaround for that problem (mentioned in this thread and anothers in this repo)
My original answer here:
https://github.com/ascoders/react-native-image-viewer/issues/161#issuecomment-487321393

@divisble Thanks for this solution! Setting width/height worked.
Must be something to do this line, maybe because width/height doesn't work for network images even though the typings suggest it does?
https://github.com/ascoders/react-native-image-viewer/blob/31298e1fecf76d3934c071e35632598f71e61180/src/image-viewer.component.tsx#L207

@ascoders Mind reopening this issue?


The title of the "Always On Top" tool missing translation and the translation is not very reasonable.

Microsoft PowerToys version
0.80.1
Utility with translation issue
Always on Top
🌐 Language affected
Chinese (Simplified)
❌ Actual phrase(s)

✔ Expected phrase(s)
I think "Always on Top" can be translated as "始终置顶", which better reflects the function of the tool.
This translation also seems to have appeared in the previous version #30816, but I think the translation #30816 (窗口置顶器) is a bit redundant.
ℹ Why is the current translation wrong
I think the title of the tool should also be translated, just like any other tool.
And I think the current Chinese translation (前端显示) is not quite in line with the understanding of ordinary people when using computers, and the word "前端" does not reflect "Top" well.

https://dev.azure.com/GlobalCollaborationService/Global Collaboration Service Project/_workitems/edit/738532/ /loc

should be fixed in .86

should be fixed in .86

Hi, I updated PowerToys to v0.86.0, but it still not be fixed.

It doesn't seem to be fixed...


Using weak scope is leaking objects?

I have this dummy object
protocol DevTestProtocol: class {}
class DevTest: DevTestProtocol {}

which is registered like follows (I'm using an assembly)
container.register(DevTestProtocol.self) { _ in
    return DevTest()
}
.inObjectScope(.weak)

For testing purposes I added a property in my app delegate
var devTest: DevTestProtocol?
and in applicationDidFinishLaunchingWithOptions I resolve the object then forget about it
self.devTest = DI.resolve(DevTestProtocol.self)!
self.devTest = nil

Is the DevTest instance supposed to be gone by now?
Because it's not. It still shows in the debug memory graph as a leak (see screenshot).

I guess this isn't expected behaviour? Am I missing something?
It looks like a bug to me and it's messing up my whole setup.
What can we do about this?

Can you post the DevTest class as well? Are there any retain cycles that are keeping it alive?

That's what I'm wondering. At least they don't show up in the debug memory graph.
This actually happens with the actual empty implementation of DevTest I provided at the top of my post.

Ok, I can look into adding some tests for this (if there aren't already some), and see if I can track down the problem.

Allright thanks, you can checkout this project to reproduce the issue if needed: https://github.com/alexisbronchart/SwinjectWeakLeak

I just found that if DevTest inherits from NSObject then the leak doesn't show up in the debug memory graph.

Thanks @alexisbronchart and @mpdifran!

@yoichitgy, also found the issue in my project :(.  Are there any updates? Or workarounds?

Thanks @igorkotkovets for the investigation 👍👍👍 I'll check it.

Any updates on this issue? I'm seeing it as well. I'm not sure it's an Xcode8 profiling issue. I started noticing it in the app, then confirmed it with the profiler.

Thanks @jodyscho for the investigation😃 I’m going to close this issue in Swinject project.
Please anyone feel free to reopen this issue, or open an issue in SwinjectStoryboard project if you find the leak issue is reproducible👍


Update version of rsync tarball

Previous version is no longer available. Updated version to allow correct installation.

@ctfhacker Thank you! LGTM


Not picking up the new CRON and running on previous schedule only. Even disable cannot stop it from running.

I accidentally set my code to run every 15 seconds. Now, no matter what CRON expression I am giving it is not updating only. Even Disable feature in Manage tab of the azure function is not making it stop. The only way I am able to stop it is deleting the TimerInfo parameter or deleting the Timer parameter from Integrate tab. In that case the compilation starts failing and the code stops. What is the expected behavior here? Shouldn't the disable button stop the function execution. And what is the ETA for it to pick the new Schedule provided to it by CRON expression?

That definitely should not be happening - a schedule change once saved should take effect immediately. Do you have a consistent repro for this? Are you saying that after forcing the function to recompile, the new schedule was then used?

An update. I did nothing different today morning. Not even a single change i made. All i did was instead of using App Service Editor i used the normal function console provided on azure portal and it worked.
Though it worked here are what were some issues I saw :

Even if i was giving a wrong CRON expression shouldn't the execution stop? Because it continuously ran for two days.
Also, about the disable button on the portal. I have an azure function to send mail. I clicked on disable since i was not able to fix the schedule issue but then after a couple of day i could see some 53K mails in my folder. Isn't the disable function supposed to function from execution?

What do you mean specifically by "App Service Editor"?
The function execution should always be in sync with your CRON schedule. If your schedule is invalid, the function should not be running.
Regarding the disable button: yes, it should immediately disable the function. I tried this myself just now and it works for my TimerTrigger - the timer stops immediately. The way this works is we write a "disabled": true value to the function.json metadata file for your function, and that causes a host restart. The host will then skip that disabled function.

@mathewc  -- "App Service Editor" is Monaco.
I've been playing with this in the editor this morning and not been able to reproduce the problem. It seems like we somehow missed the updates to the function.json file -- I'm going to see if I can figure out if that's true (and why it happened).

https://github.com/Azure/azure-webjobs-sdk-extensions/issues/149 has been checked in and the new nuget is now in Script (#684). It's not yet in production, but I believe the issue here is the same.


Remove PUBLIC_KEY & PRIVATE_KEY from .env.example and settings.ts

Description
All reporters are now defined through Orakl Network API, therefore we do not need to define PUBLIC_KEY or PRIVATE_KEY inside of .env (.env.example) and settings.ts.
Fixes # (issue)

[x] Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

[x] I have performed a self-review of my code.

LGTM!
I am merging the PR.


Nativescript 1.1 rebased

I rebase nativescript-1.1 to the latest master and made a few small changes. I noticed that the new approach for SConstruct in master isn't recognizing properly that I have a 64 bits system on Windows so that needs fixing up but that is already in master i guess.
If people can recheck my work and maybe do a final compare between this and the current nativescript-1.1 branch to make sure i didn't overlook anything maybe we can finally merge this into master.
I do suggest creating a branch called nativescript-1.0 from the current master branch for those who want to keep using the older library.

And squashed all the commits, here goes nothing...


Abort runs if loss scale gets stuck at minimum

https://github.com/EleutherAI/DeeperSpeed/commit/a6748a420be10240ff86baa65b0e6ab5fcbddf03 fixed here


[Features] Rename the BuiltinBuildTaskExecutor feature guard.

The name of the TaskExecutor protocol was recently changed in https://github.com/apple/swift/pull/71145 to remove underscores after the task executor preference proposal was accepted in Swift Evolution. An implication of that rename is that the buildOrdinaryTaskExecutorRef builtin changed the type that it expected as the argument. However, the original _TaskExecutor protocol landed in the _Concurrency library which as since produced .swiftinterface files that contain the following @inlinable code:
@inlinable public init<E: _TaskExecutor>(ordinary executor: __shared E) {
  #if $BuiltinBuildTaskExecutor
  self.executor = Builtin.buildOrdinaryTaskExecutorRef(executor)
  #else
  fatalError("Swift compiler is incompatible with this SDK version")
  #endif
}

When a compiler containing the TaskExecutor protocol rename attempts to type check the above @inlinable code when rebuilding the _Concurrency module from its .swiftinterface file, it crashes because the builtin is expecting an argument conforming to TaskExecutor, which doesn't exist in this version of the standard library. Specifically, the crash happens here:
  case _taskExecutor:
    return SC.Context.getProtocol(KnownProtocolKind::TaskExecutor)
      ->getDeclaredInterfaceType();

The issue is that the current compiler still supports the $BuiltinBuildTaskExecutor feature guard, and thus attempts to typecheck self.executor = Builtin.buildOrdinaryTaskExecutorRef(executor), but the type of executor conforms to _TaskExecutor instead of TaskExecutor. Because TaskExecutor doesn't exist in this version of the _Concurrency library, SC.Context.getProtocol(KnownProtocolKind::TaskExecutor) returns nullptr.
To resolve this issue, we need to stop supporting the $BuiltinBuildTaskExecutor feature guard and introduce a new one that is only supported by compiler versions that contain the TaskExecutor rename. This approach relies on nothing having adopted the API, otherwise we would need to stage in the rename as a parallel set of APIs, and only remove the old APIs once nothing is relying on the old _Concurrency .swiftinterface files.

@swift-ci please smoke test


Unix Socket Mode

An attempt at adding an option to control the file mode of the Unix socket.

This is fine, because it's small. Next time before you make changes, try to discuss it with me first, or even open a ticket so I can comment on it.

Noted.
I have made the changes in rebase, also changed the flag from UintFlag to IntFlag because it was not being read from server.yml.
Let me know if I should change the default mode as well.


Particle shaders

Restores particle shaders (and GPUParticles)
Bugsquad edit: Addresses #35353 but only for 3D

For the reference, I force pushed the master branch to squash those two commits into one (while preserving the merge commit with --preserve-merges to reference this PR).


Suggestions for external links.

Each link should be a comment, and we will upvote/ downvote them, and every end of the month decide which ones go in.

Simple bash tutorial: http://www.ee.surrey.ac.uk/Teaching/Unix/index.html

Linux command line by example: https://github.com/learnbyexample/Linux_command_line

Morris has an introduction to HPC course:
https://www.youtube.com/watch?v=CedBuahAzqI

https://www.hpc-training.org/xsede/moodle/enrol/index.php?id=32
On Lustre


Script for running Model builds

Run pnpm run build-last-revision, to build the last revision. This will create a "build", that will run the squiggle model, and save the Exports for that revision, if it succeeds. If it fails, it will store a simple string error message.

My main concern is that buildRecentModelRevision will get stuck on the first model that will fail because of memory or almost-infinite loops.

Yea, I thought about that too. Wasn't sure how likely it would be.
Seems simple enough to try this, then handle errors when they come, or in future PRs. As you know, I like doing things incrementally.

So maybe something like buildStatus field should be stored on the DB level? Probably makes more sense in ModelRevisionBuild, not on ModelRevision. Then we could inject the build flagged as pending immediately, and then update it after the job is completed.

It might even make sense to separate "build results" (squiggle output + errors) from "build runs" (jobs for running a build). Then we won't have to worry about null fields on pending builds.

I imagine this is the most critical if we have multiple workers that can build items that are pending - this way they wouldn't conflict with each other. I'm not sure how much of a priority this is though, it might be a while until we have that.


Updates to get correct site and default values into DB

This PR is a follow up to #836 and includes updates relevant for the export of simtel model parameters using the applications convert_all_model_parameters_from_simtel.py and convert_model_parameter_from_simtel.py. Note that getting the handling of the format from simtel right is hard and difficult to write in a very clean code style.
We also expect that these applications are needed only in the short-to-medium term, until all model parameter are exported correctly to the databases.
Changes:

(hopefully) correct handling of all: variants in the simtel configuration files output (this is unfortunately complicated; e.g. "all:0", "all: 0", "all:0, 5:3" (the latter means all all values are set to zero with the exception of the 5th)
convert_all_model_parameters_from_simtel.py prints differences between default and set values for parameters which are not covered by schemas. This is important to debug the schema files in the model_parameters and make sure that schemas are there for all model parameters and that defaults / limits are correct.
add require_exact_data_type command line option to convert_all_model_parameters_from_simtel: if set (not default), we require exactly the same data types in the validation (meaning 'int' as 'int64' is not accepted). In this context allow as well int values as floats (meaning: a '5' is allowed as value when the required data type is float)
add 'prod6' as allowed production (not ideal that these are hardwired in names.py)
print list of file-type model parameters and values (this is useful to find those files)

@tobiaskleiner - thanks for the review. I've improved the docstring to make it clearer that 'none' is ok as return value for the camera pixels.


Feature/#342 deselecting shape cmd+click

Look @brauliodiez handleSelected was being called twice.

From src/pods/canvas/use-multiple-selection-shape.hook.tsx
And  src/common/components/shapes/use-shape-selection.hook.ts

To make this works i commented the first one, i need some feedback about this. Currently working nice.

I have found a case where it break:
Drag a shape.
Click on the canvas to un select the sape
Just Drag again the shape (the transformer won't be on the shape).
Right now this behavior on version 0.1:

On this branch version:


Make the Regex type Sendable

This is mostly trivial, with the exception of the lazy compiled regex. For that, we can use atomics to make storing the compiled program safe, even if it might result in an extra, thrown-away compilation.

So that we don't have to import swift-atomics, I've subset out the UnsafeAtomicLazyReference type and its dependencies.
I've added a test that consistently traps due to concurrent mutation under main, but succeeds with these changes.

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test


Unexpected preemption between ClusterQueues within a Cohort

What happened:
In a setup where three ClusterQueues (Q1, Q2, and Q3) are part of the same cohort, we observed that a high-priority workload (WL3) from Q3 preempted a low-priority workload (WL1) from Q1, despite preemption policies being configured to prevent this. Specifically:

reclaimWithinCohort: Never
borrowWithinCohort.policy: Never
withinClusterQueue: LowerPriority

What you expected to happen:
WL3 should have remained pending because:

The preemption policies (reclaimWithinCohort: Never and borrowWithinCohort.policy: Never) should have prevented resource reclamation across ClusterQueues within the same cohort.
There was no candidate for preemption within Q1 based on the preemption policy (withinClusterQueue: LowerPriority).

How to reproduce it (as minimally and precisely as possible):

Set up three ClusterQueues (Q1, Q2, Q3) in the same cohort with the following preemption policies:

reclaimWithinCohort: Never
borrowWithinCohort.policy: Never
withinClusterQueue: LowerPriority

Assign 8 GPUs in total to the cluster.
Submit 4-GPU low-priority workloads (WL1 and WL2) to Q1 and Q2, respectively.
Submit a 4-GPU high-priority workload (WL3) to Q3 and admit it.
Observe that WL3 preempts WL1, despite the preemption policy setup.

Anything else we need to know?:
It appears the preemption policy does not fully respect the cohort-level restrictions, allowing WL3 to preempt WL1, which contradicts the configured settings.
WL1 Status/Events did not log the preemption. Kueue immediately started a new WL1-1 for the deployment and WL1 was evicted. It occurred to WL1 or WL2 randomly. Attached Kueue controller logs during the event happened. In this log kueue_logs.txt, WL2 was evicted.
This unexpected preemption behavior also occurs between cohorts. According to the documentation, preemption should never happen between cohorts.
Environment:

Kubernetes version (use kubectl version): 1.27.2
Kueue version (use git describe --tags --dirty --always): v0.8.1
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools: helm
Others:

test.yaml:
apiVersion: v1
kind: Namespace
metadata:
  name: dac-resv-1
---
apiVersion: kueue.x-k8s.io/v1beta1
kind: ClusterQueue
metadata:
  name: "dac-resv-1"
spec:
  namespaceSelector: {} # match all.
  cohort: cohort-dedicated
  preemption:
    reclaimWithinCohort: Never
    borrowWithinCohort:
      policy: Never
    withinClusterQueue: LowerPriority
  resourceGroups:
    - coveredResources: ["nvidia.com/gpu"]
      flavors:
        - name: "default-flavor"
          resources:
            - name: "nvidia.com/gpu"
              nominalQuota: 4
              borrowingLimit: 0
              lendingLimit: 0
---
apiVersion: kueue.x-k8s.io/v1beta1
kind: LocalQueue
metadata:
  namespace: dac-resv-1
  name: dac-resv-1
spec:
  clusterQueue: dac-resv-1
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: dac-resv1-deployment
  namespace: dac-resv-1
spec:
  replicas: 1
  selector:
    matchLabels:
      kueue-job: "true"
  template:
    metadata:
      labels:
        kueue-job: "true"
        kueue.x-k8s.io/queue-name: dac-resv-1
    spec:
      priorityClassName: low-priority-class
      containers:
        - name: pod-dac-resv-1
          image: busybox
          command: ["sh", "-c", "sleep infinity"]
          ports:
            - containerPort: 80
          resources:
            requests:
              nvidia.com/gpu: "4"
            limits:
              nvidia.com/gpu: "4"
      affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
              - matchExpressions:
                  - key: kubernetes.io/hostname
                    operator: In
                    values:
                      - <IP_ADDRESS>
---
apiVersion: v1
kind: Namespace
metadata:
  name: dac-resv-2
---
apiVersion: kueue.x-k8s.io/v1beta1
kind: ClusterQueue
metadata:
  name: "dac-resv-2"
spec:
  namespaceSelector: {} # match all.
  cohort: cohort-dedicated
  preemption:
    reclaimWithinCohort: Never
    borrowWithinCohort:
      policy: Never
    withinClusterQueue: LowerPriority
  resourceGroups:
    - coveredResources: ["nvidia.com/gpu"]
      flavors:
        - name: "default-flavor"
          resources:
            - name: "nvidia.com/gpu"
              nominalQuota: 4
              borrowingLimit: 0
              lendingLimit: 0
---
apiVersion: kueue.x-k8s.io/v1beta1
kind: LocalQueue
metadata:
  namespace: dac-resv-2
  name: dac-resv-2
spec:
  clusterQueue: dac-resv-2
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: dac-resv2-deployment
  namespace: dac-resv-2
spec:
  replicas: 1
  selector:
    matchLabels:
      kueue-job: "true"
  template:
    metadata:
      labels:
        kueue-job: "true"
        kueue.x-k8s.io/queue-name: dac-resv-2
    spec:
      priorityClassName: low-priority-class
      containers:
        - name: pod-dac-resv-2
          image: busybox
          command: ["sh", "-c", "sleep infinity"]
          ports:
            - containerPort: 80
          resources:
            requests:
              nvidia.com/gpu: "4"
            limits:
              nvidia.com/gpu: "4"
      affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
              - matchExpressions:
                  - key: kubernetes.io/hostname
                    operator: In
                    values:
                      - <IP_ADDRESS>
---
apiVersion: v1
kind: Namespace
metadata:
  name: dac-resv-3
---
apiVersion: kueue.x-k8s.io/v1beta1
kind: ClusterQueue
metadata:
  name: "dac-resv-3"
spec:
  namespaceSelector: {} # match all.
  cohort: cohort-dedicated
  preemption:
    reclaimWithinCohort: Never
    borrowWithinCohort:
      policy: Never
    withinClusterQueue: LowerPriority
  resourceGroups:
    - coveredResources: ["nvidia.com/gpu"]
      flavors:
        - name: "default-flavor"
          resources:
            - name: "nvidia.com/gpu"
              nominalQuota: 4
              borrowingLimit: 0
              lendingLimit: 0
---
apiVersion: kueue.x-k8s.io/v1beta1
kind: LocalQueue
metadata:
  namespace: dac-resv-3
  name: dac-resv-3
spec:
  clusterQueue: dac-resv-3
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: dac-resv3-deployment
  namespace: dac-resv-3
spec:
  replicas: 1
  selector:
    matchLabels:
      kueue-job: "true"
  template:
    metadata:
      labels:
        kueue-job: "true"
        kueue.x-k8s.io/queue-name: dac-resv-3
    spec:
      priorityClassName: high-priority-class
      containers:
        - name: pod-dac-resv-3
          image: busybox
          command: ["sh", "-c", "sleep infinity"]
          ports:
            - containerPort: 80
          resources:
            requests:
              nvidia.com/gpu: "4"
            limits:
              nvidia.com/gpu: "4"
      affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
              - matchExpressions:
                  - key: kubernetes.io/hostname
                    operator: In
                    values:
                      - <IP_ADDRESS>

WL1:
apiVersion: kueue.x-k8s.io/v1beta1
kind: Workload
metadata:...
status:...
spec:
  active: true
  podSets:...
  priority: 10
  priorityClassName: low-priority-class
  priorityClassSource: scheduling.k8s.io/priorityclass
  queueName: dac-resv-1

Other setups:
Installed Kueue from helm chart.
Integrated with "pod" in Values.integrations.frameworks.
Enabled "waitForPodsReady" with "blockAdmission".
Did not enable fairSharing.

/cc @mbobrovskyi @trasc
PTAL

/assign

In your example test.yaml you have three different ClusterQueues with nvidia.com/gpu=4 on each of them and all of Workloads running on separate ClusterQueues which is correct because each Pod have request nvidia.com/gpu=4.
kubectl get wl -A
NAMESPACE    NAME                                              QUEUE           RESERVED IN   ADMITTED   FINISHED   AGE
dac-resv-1   pod-dac-resv1-deployment-7bd484bfdb-x5f4s-857c8   dac-resv-lq-1   dac-resv-1    True                  3s
dac-resv-2   pod-dac-resv2-deployment-9d4dff9dd-cr9lf-f5046    dac-resv-lq-2   dac-resv-2    True                  3s
dac-resv-3   pod-dac-resv3-deployment-54b4f969cb-rhgm7-83a91   dac-resv-lq-3   dac-resv-3    True                  3s

Assign 8 GPUs in total to the cluster.

I think that the confusion is here. Kueue is not aware of the cluster's actual resources.

Thank you for investigating this issue.
This situation arises when the cluster has insufficient resources. Are you suggesting that this behavior is expected as long as Kueue allows the workload to be admitted?
I have some concerns about scenarios where GPU utilization in the cluster is high. There may be potential race conditions that could allow a workload to be admitted despite insufficient resources, which could pose a significant risk.

Are you suggesting that this behavior is expected as long as Kueue allows the workload to be admitted?

Yes, Kueue is not checking if the resources described in the ClusterQueue's definition are meet by the cluster's overall resources or if such resources are currently in use by  workloads that are not managed by Kueue.

I see, if you specify more quota than the actual resources, then you may be observing preemptions at the level of Pods by kube-scheduler, rather than Kueue.
To mitigate that I saw some users assign a bit more cluster capacity than actual quota for some buffer (say 10%) for the high priority Jobs. This buffer can be used for low-priority Jobs and may mitigate for nodes going down.
Alternatively use ProvisioningRequest with check-capacity from ClusterAutoscaler. In this setup the CA simulates if the Job could run, and gives green light to Kueue via the AdmissionCheck mechanism (see here.

I see, if you specify more quota than the actual resources, then you may be observing preemptions at the level of Pods by kube-scheduler, rather than Kueue.

In that case, I would recommend using the WorkloadPriorityClass instead of core kube PriorityClass: https://kueue.sigs.k8s.io/docs/concepts/workload_priority_class/
This can mitigate the race condition between Kueue and kube-scheduler. This WorkloadPriorityClass is used for preempting and ordering only inside Kueue, never used by kube-scheduler.

In that case, I would recommend using the WorkloadPriorityClass instead of core kube PriorityClass: https://kueue.sigs.k8s.io/docs/concepts/workload_priority_class/

Thanks, this works.

Excellent! Closing as the behavior is WAI from Kueue PoV, and we have a workaround for the kube-scheduler initiated preemptions.
/close

/remove-kind bug
/kind support


Fix delegation error.

Jira link
Bug fix.
What?
Allow nil for the delegation on duty expression description.
In short, it can happen that the duty expression is nil, so the description cannot be retrieved.

As discussed with @jebw , the root cause of this issue was the lack of Timemachine in the measure controller#show.
Fixed now!


Bug: Markdown code node importing is hardcoded

Markdown functionality relies on passed transformers list, which allows passing built-in ones as well as custom nodes trasnfomers. But the code block is an exception - MarkdownImport always processes code blocks regardless of transformers list:
https://github.com/facebook/lexical/blob/2abc8244d5754860b96bfc6f875bdcbf23d4e390/packages/lexical-markdown/src/v2/MarkdownImport.ts#L54-L74
Which means even if we don't pass code blocks (or if we pass custom code node) the built-in version will be used.

Hey @fantactuka I've been experimenting with a solution for multi line transformers, how about a new type of transformer "multiline-transformer" that takes in a RegExp for start and a RegExp for end? the resulting lines are joined and passed into the replace function for the transformer to parse / create node from?
for (const {startRegExp, endRegExp, replace} of transformers) {
    // check if the block could be opening
    const openMatch = lines[startLineIndex].match(startRegExp);
    if (openMatch) {
      let endLineIndex = startLineIndex;
      const linesLength = lines.length;

      while (++endLineIndex < linesLength) {
        const closeMatch = lines[endLineIndex].match(endRegExp);

        if (closeMatch) {
          const matchingLines = lines.slice(startLineIndex, endLineIndex);
          const match = matchingLines.join('\n');

          const textNode = $createTextNode(match);
          const elementNode = $createParagraphNode();
          elementNode.append(textNode);
          rootNode.append(elementNode);

          replace(elementNode, [textNode], match, true);
          return [elementNode, endLineIndex];
        }
      }
    }
}

I like it, will give it a go when I get some time 👍

This issue seems to be inactive for a while, not sure if the proposed changes still in consideration.
For my case, I need to convert the Excalidraw code block (See the example below) to a ExcalidrawNode. So I created a custom markdown transformer for the  ```excalidraw pattern but it never work due to the hardcoded code block transformer.
```excalidraw
{
...
}
\```

For temporary workaround, I copied the entire lexical-markdown directory to my project and modify the importCodeBlock logic. I'm looking forward to get rid of this hacky workaround. :(

@mattrhysgregory , please have a look at it, it really is a blocker

Hey guys, any updates on this? I'd like to work out a solution if no one is already doing it

Feels this would unblock some very powerful caes.
@cesar-ibr did you ended up taking a look?

This issue seems to be inactive for a while, not sure if the proposed changes still in consideration.
For my case, I need to convert the Excalidraw code block (See the example below) to a ExcalidrawNode. So I created a custom markdown transformer for the ```excalidraw pattern but it never work due to the hardcoded code block transformer.
```excalidraw
{
...
}
\```

For temporary workaround, I copied the entire lexical-markdown directory to my project and modify the importCodeBlock logic. I'm looking forward to get rid of this hacky workaround. :(

same issue, I want to transform code into into mermaid node.  here is my solution
// after call $convertFromMarkdownString()
for (const code of $nodesOfType(CodeNode)) {
  const lang = code.getLanguage()
  if (lang ==='mermaid')
    code.replace($createMermaidNode(code.getTextContent()))
  }
}


chore: update container templates to use node18 and aws sdk v3

Description of changes
For the 3 sample nodejs-based container apps, flip to using nodejs18 and aws sdk v3.
CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
N/A, EOL for Nodejs14
Description of how you validated changes
Manually deployed via setup-dev to test these three apps after the changes, verifying they successfully deploy.
Unit + E2E Tests
Checklist

[x] PR description included
[x] yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

All E2E's except for the one that's known failing passed.


Add encoded path name tests for SQL kernel

Also did some cleanup - I'm not sure where invocationCount was supposed to come from but I can't find any documentation about it in mocha and it was just returning NaN in my local runs. We shouldn't really need it anyways - it'd just get reset each time we ran and each test shouldn't be running more than once normally anyways.
Test build without URI fixes (I expect there to be integration test failures) : https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=101157&view=results
I will queue another build once the URI PR has been merged in to verify that the tests pass on the lab machines (I've verified they pass locally)

Pull Request Test Coverage Report for Build 768002959

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 43.61%

Totals

Change from base Build 766179557:
0.002%

Covered Lines:
26254

Relevant Lines:
55003

💛  - Coveralls


Repackage sampling into class and workflow script

This allows script to be run from terminal to general output csv

Update - currently not seen necessary to repackage into class, but separate workflow script produced


feat: add a reply to a post

This PR adds the ability to reply to posts
Closes #9

I am Reply 1 post , but the answer is showing under 2 POST. I expect Reply to 1 post to appear below 1 Post.

Good example on GitHub Discussions. Answers are linear until they are posted.
If a new post is created, the answer should be written below the new post.
see https://github.com/codeigniter4/shield/discussions/765

If this is to be changed, we need to determine how it should look/work

The way to display nested posts (should it look like GitHub Discussions?)
Whether to show all nested posts at once, add pagination, or a "more" button.
Number of levels - because we can't nest posts indefinitely.

Probably worth addressing in a separate issue. For now, we keep all the necessary information, so we can figure out how to display it later.

One important thing to note... the goal is also to import data from the old forum at some point.... so posts there may have a multi-level structure. Although I haven't checked what the DB schema looks like in MyBB.

The MyBB posts shema doesn't seem to link to other posts as a parent. I didn't see any other tables that I would imply otherwise either.

I do think we should discuss the threading of posts and decide how necessary it is. If we did, I don't think we'd need to thread it deeper than 1 level, kind of like Slack. Especially since forum posts are usually wordy affairs :)

I approved, and am going to merge, but we should probably start building up a test suite and get some CI going on here since this is no longer just me slinging code over a couple weekends for the fun of it :)

I approved, and am going to merge, but we should probably start building up a test suite and get some CI going on here since this is no longer just me slinging code over a couple weekends for the fun of it :)

Here comes a thief of joy, the smiler reducer, a.k.a. the testing suite, ready to turn your code party into a debugging disco  😆
Yeah... you're right. Thought it was fun without them.

@lonnieezell Is the replyto column in the screenshot associated with the user?

@lonnieezell Is the replyto column in the screenshot associated with the user?

Sorry - missed this. I have no idea :) They don't have foreign keys setup. I would guess it was replying to another post, but not really sure.
I could get you a copy of the SQL dump if you'd like it. It's only 96mb, zipped, and like 355mb unzipped :)

Nah, that's ok. If it's the post_id we're responding to, it would potentially create multi-level threading... old posts should be displayed in a linear fashion, which makes more sense since they are displayed that way now.


rapidcsv is not that rapid!

Thanks for this module. I expected it would be faster than it is however.
I changed the main character addition line from:
cell = cell + buffer[i]; to
cell += buffer[i];
and on Visual Studio 2017 64 bit it ran twice as fast!

Thank you, I'll try add some performance test(s) to this project and check if your suggestion applies across platforms, and change the code accordingly.
Generally speaking on performance there's a trade-off between the "simplicity" of the API vs. raw throughput, and rapidcsv (despite its name) focuses on ease-of-use (and enabling rapid development). So I'm pretty sure there are other CSV libraries which are faster out there (but leaving more work to the application code).
Anyway, you seem to have found a good low-level improvement (not affecting API usability) which I'm happy to include if I can confirm the results on my systems. I would have thought a decent compiler would produce similar code for those two lines, but that assumption seem to be wrong.

Thanks @fordp2002 - I can confirm the suggested improvement applies for all three major platforms (Linux, Mac, Windows). Measurement data for ptest002.cpp (which essentially just loads a CSV file) before and after fix are provided below. Will proceed to merge the fix.
Linux: before 53.4 ms --> after 37.9 ms
Mac: before 72.4 ms --> after 30.2 ms
Windows: before 33.5 ms --> after 10.7 ms

Thanks for this, it is great that you are willing to make improvements!


Documentation resource

Is there a solid documentation resource?
I'm trying to find a current list of methods for the config / nodes / edges.
edit:  I have used https://danielcaldas.github.io/react-d3-graph/docs/index.html#graphconfig but I find the configurations do not match what agraph uses.     Node 'symbolType' vs 'shape', for instance.

Dear @taws34 ,
we moved from d3-graph to react-graph-vis .
Please check it out.

Just check also the ConfigBuilder Class I just released. You can play with it in the Demo app linked in the README.


[sram/dv] Fix RAL hdl path

sram dut path is tb.dut.u_sram_ctrl which isn't same as the others
override it in sram_ctrl_env_cfg with the correct path
@udinator I think this PR should fix the hdl path issue, but I saw other errors when rerunning with this. LMK if this doesn't work.
Signed-off-by: Weicai Yang<EMAIL_ADDRESS>

close this as it's included in #5119


Skip Oxygen checks when @shopify/remix-oxygen is not installed

Related to https://github.com/Shopify/hydrogen/discussions/1122
This PR skips Oxygen requirements we had for the config when not deploying to Oxygen.
I've also renamed config.ts to remix-config.ts to make it more obvious since we have another file called shopify-config.ts.

@frandiox Hey. I'm updating our template and it looks like these checks are still being triggered when @shopify/remix-oxygen is not installed, because @shopify/remix-oxygen is also a dependency of @shopify/cli-hydrogen. Would it be possible to instead check if @shopify/remix-oxygen is in the package.json, so it only triggers for explicitly-installed packages?

OK, I just realised that it's an optional dependency, and was only installed for me because it had previously been installed with the template. All good!

Hi! Forgot to reply earlier today but here's a PR that removes @shopify/remix-oxygen from our peer deps. I think it was a mistake to add it as a peer dep in the first place. This should fix your issue. If it doesn't then I'll change it to check package.json instead 👍


Feat/lamp timing api

Owner

[x] Nickname(Tuya):
[x] Intra-group review（组内审阅人员）：

Description
Please provide a brief summary of the changes. If it is related to an issue, please bring the issue number, like fixes #${number}.
Package
Please select the relevant package.

[ ] tuya-panel-animation-sdk
[x] tuya-panel-api
[ ] tuya-panel-electrician-sdk
[ ] tuya-panel-ipc-sdk
[ ] tuya-panel-lamp-sdk
[ ] tuya-panel-lock-sdk
[ ] tuya-panel-robot-sdk
[ ] tuya-panel-outdoor-sdk

Type of change
Please select the relevant option.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Self CheckList
Please check all options.

[x] Intra-group review
[x] ESLint lint
[x] Example Run
[x] Jest Run
[x] No Grammer Error
[x] No Spell Error
[x] No Merge Conflict

Codecov Report

Merging #217 (bd26646) into main (7a25c2f) will decrease coverage by 0.34%.
The diff coverage is 14.65%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
- Coverage   60.43%   60.09%   -0.34%
==========================================
  Files         402      403       +1
  Lines       15608    15724     +116
  Branches     3934     3951      +17
==========================================
+ Hits         9433     9450      +17
- Misses       6148     6219      +71
- Partials       27       55      +28

Impacted Files
Coverage Δ

packages/tuya-panel-api/src/lamp/utils.ts
13.04% <11.11%> (-1.25%)
:arrow_down:

packages/tuya-panel-api/src/lamp/rhythm.ts
14.15% <14.15%> (ø)

packages/tuya-panel-api/src/lamp/index.ts
100.00% <100.00%> (ø)

packages/tuya-panel-api/src/lamp/general.ts
13.61% <0.00%> (ø)

packages/tuya-panel-api/src/robot/gyroDataApi.ts
9.72% <0.00%> (ø)

packages/tuya-panel-sensing-sdk/src/utils/ble.ts
34.54% <0.00%> (ø)

packages/tuya-panel-api/src/robot/laserDataApi.ts
8.88% <0.00%> (ø)

...ges/tuya-panel-sensing-sdk/src/SensingSDK/index.ts
3.02% <0.00%> (ø)

...s/tuya-panel-remote-sdk/src/utils/getAirKeyData.ts
15.58% <0.00%> (ø)

...l-gateway-sdk/src/components/setPassword/index.tsx
48.27% <0.00%> (ø)

... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Issues on Manage Wallets

- [ ] Duress mode not working on Dev App, works on Live.

[x] Do not need Currency Switch.
[x] I cannot dismiss the Enter Passcode modal.

Verified this issue on keeper app v 1.2.17(402)


encode dictionary type (fst, sstable)

the dictionary is currently controlled by a feature flag to be an fst or sstable.
To make the index forward compatible we should store the dictionary type in the metadata

#1943 adds a footer containing the dictionary type and its version, and implement its usage for sstables. The fst part isn't implemented yet, nor is a test that read one kind of dictionary with the other reader


Metrics compute result is being cached after reset

🐛 Bug
It looks like after calling pl.metrics.Metric.reset_state(), the previous value of pl.metrics.Metric.compute() is somehow cached afterwards:
To Reproduce
import torch
import numpy as np
import pytorch_lightning as pl

class AverageMeter(pl.metrics.Metric):
    def __init__(self):
        super().__init__()
        self.add_state("value", torch.zeros(1), dist_reduce_fx="sum")
        self.add_state("count", torch.zeros(1), dist_reduce_fx="sum")

    def update(self, value):
        if isinstance(value, torch.Tensor):
            self.value += value.sum()
            self.count += value.numel()
        else:
            self.value += value
            self.count += 1

    def compute(self):
        return (self.value / self.count).item()

m = AverageMeter()
m.update(1)
m.compute()   # This passes if I don't call this line

m.reset()
print(m.value, m.count)
assert np.isnan(m.compute())

This crashes with:
tensor([0.]) tensor([0.])
1.0
Traceback (most recent call last):
  File "scratch.py", line 29, in <module>
    assert np.isnan(m.compute())
AssertionError

This is very strange -- the values of value and count are reset appropriately to be (0, 0), but for some reason the compute value is 1.0.
If I comment out the m.compute() line, then this gives the expected behavior (of being nan).
Expected behavior
This script should run without problems
Environment
* CUDA:
	- GPU:
	- available:         False
	- version:           None
* Packages:
	- numpy:             1.19.5
	- pyTorch_debug:     False
	- pyTorch_version:   1.7.1
	- pytorch-lightning: 1.1.6
	- tqdm:              4.56.0
* System:
	- OS:                Linux
	- architecture:
		- 64bit
	- processor:         x86_64
	- python:            3.6.10
	- version:           #1 SMP Sun Jan 17 19:52:43 UTC 2021

This is the intended behavior, that no matter how many times compute is called in sequence you will still get the last computed result. The cashe is reset whenever update or forward is called.

Hm... would it be possible to update the documentation at https://pytorch-lightning.readthedocs.io/en/latest/metrics.html? There's no mention of this caching behavior, and I think it's not really obvious.
I would love a section on the "lifetime" of a metric -- when are things cached, when are things updated, and when are things reset (I assume they're reset by the Trainer on each epoch, but I don't think that's actually stated anywhere?).

@alanhdu we can definitly agree that it is not well documented. Thanks for pointing out :]
Metrics are still relatively new, and we are open for changes. For example from v1.2 compute will no longer call reset automatically anymore (many users was confused about this). However, this cashing behaviour is nessesary for us to proper log metrics in lightning.
I will try to come up with something that betters describes the lifetime of an metric.
If you dont mind, could you tell me what the usecase was that you wanted to call compute twice in a row?

For example from v1.2 compute will no longer call reset automatically anymore (many users was confused about this).
That'd be great!

could you tell me what the usecase was that you wanted to call compute twice in a row?

In this particular case, I was writing tests for some custom metrics and was confused about the right hooks for them. In general though, we implement a __str__ to log the metrics to a custom logger which calls compute to get the current value of the metric. B/c of "reasons", in a complicated code-base we sometimes call __str__ and compute to log to Lightning's logger.


Swift Charts: DateBins

Doc: https://developer.apple.com/documentation/charts/datebins

We cannot support this, it is a client-side storage method for chart data, but in LVN we need to use for loops.

Rejecting


hardened geometric mechanism, data processing, merged constructors

Geometric mechanism:

Hardened constant-time geometric mechanism against an unaccounted delta term if input is outside the provided bounds.
Added non-constant-time version of the geometric mechanism that needs no bounds.
Added overflow/underflow protection on all flavors of the geometric mechanism.
Added vector-geometric constructor
Added shift and direction arguments to SampleGeometric
Added SampleTwoSidedGeometric sampler

Expanded data processing:

Added several imputation constructors
Added OptionNullDomain and InherentNullDomain for representations of nullity
Added/revised casters for emitting data in OptionNullDomain or InherentNullDomain
Removed make_parse_series
Added make_cast_metric for casting among metrics
Added make_is_equal for conversion to bool

Merged constructor functions:

Many constructors have multiple flavors for different domains. They can be merged by making the domain itself generic.
These have not been plumbed through FFI
Merged all vector vs. scalar flavors of measurements
Merged impute, clamp

Misc:

Maintain additional type information in JSON default value for better language-specific code-generation.
make_row_by_row constructor that is private to the crate, for building row-by-row transforms
Hairy temporary dispatch for some merged constructors based on indicators

this will be removed once the domains are plumbed through FFI

The DatasetMetric trait bound inherits from Metric<Distance=u32>, simplifying code throughout the library
Removed unnecessary generics among trait bounds in aggregators
Added const-generic LPSensitivity, and let L1Sensitivity/L2Sensitivity be aliases for LPSensitivity<Q, 1>/LPSensitivity<Q, 2>
The IntervalDomain constructor validates that bounds make sense, de-duplicating checks in constructors.

Closes #21.
Closes #145.
Closes #146.
Closes #144.

Thanks for resolving all my nit-picky nit picks, looks great!

Oops, accidentally hit Close, please ignore!


[xlnt] Upgrade to v1.4.0

Describe the pull request

What does your PR fix? Fixes issue #
Upgrade xlnt to version 1.4.0

Which triplets are supported/not supported? Have you updated the CI baseline?
All supported.

Does your PR follow the maintainer guide?

/azp run


Placement of shared components

I'm submitting a ...
[ ] bug report
[ ] feature request
[x ] question about the decisions made in the repository

Where is it intended to place shared components like a http-service in the folder structure? Should I place it on the same level as app like it is in angular2-seed
-app
--pages
--theme
-shared
--http-service
or into the app folder next to pages and theme?
-app
--pages
--theme
--shared
---http-service
Thanks and regards
Johannes

Hi, i work like this.
-app
--model
--pages
--services
--theme
--utils


make max_tokens param in Generate optional

This PR makes the max_tokens param in Generate not required. The backend sets a default value of 20 if one is not provided.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Minor Modifications

Added a file to create new accounts
Cleaned up some code
Refined the README to make it more readable

TODO:

Update civ6.js with improved programming practises and use the config files

Thanks for the collaboration

Do u have discord? pls add me juzz#3891

Done. I'm DerpZ#9141


Question

How can I get information in player_blind event about who threw the grenade and who it blinded?
{
  blind_duration: 3.5758512020111084,
  entityid: 602,
  event_name: 'player_blind',
  tick: 124537
}

Now it's only entityid and it's not clear which player and which team he's from, and who threw the grenade.
Another question is how to find out the time when the event occurred

This is the same bug as #10 . These events were missing user/attacker fields. Should be fixed in 0.4.0

Entityid actually refers to the grenade and not to the player. You can map to this id in parse_grenades(). Anyway I think for your use-case it seems like the fixed attacker and user fields will do the trick.

Thanks i will wait 0.4.0 )

As 0.4.0 is out now I'm closing this. Feel free to re-open if something is still wrong.


Allow passing caller to telemetry

What type of PR is this:
/kind feature
/area telemetry
What does this PR do / why we need it:
This sets a caller property in telemetry based upon the TELEMETRY_CALLER environment variable.
Per the acceptance criteria, this is enforced against a list of allowed values.
Which issue(s) this PR fixes:
Fixes #6147
PR acceptance criteria:

[x] Unit test

[x] Integration test

[x] Documentation

How to test changes / Special notes to the reviewer:
Set ODO_DEBUG_TELEMETRY_FILE and TELEMETRY_CALLER environment variables prior to calling odo and check the resulting telemetry data file. Or check telemetry servers.

/lgtm

/test v4.11-integration-e2e

/lgtm

/lgtm
/approve


[GOBBLIN-1045] Emit more events in compaction job

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title.

https://issues.apache.org/jira/browse/GOBBLIN-1045

Description

[x] Here are some details about my PR:

Emit count event for the following item in compaction job

number of files, corresponding to hive metadata "numFiles"
record count, corresponding to hive metadata "numRows"
bytes written, corresponding to hive metadata "totalSize"

Tests

[ ] My PR adds the following unit tests:
WIP

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@yukuai518 Hi Kuai, please look at the pr when you get time

Codecov Report

Merging #2885 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2885      +/-   ##
============================================
+ Coverage     45.73%   45.73%   +<.01%
- Complexity     9112     9123      +11
============================================
  Files          1921     1923       +2
  Lines         72391    72505     +114
  Branches       7967     7977      +10
============================================
+ Hits          33106    33162      +56
- Misses        36262    36318      +56
- Partials       3023     3025       +2

Impacted Files
Coverage Δ
Complexity Δ

...a/org/apache/gobblin/runtime/mapreduce/MRTask.java
58.49% <ø> (ø)
11 <0> (ø)
:arrow_down:

...ction/action/CompactionHiveRegistrationAction.java
57.14% <100%> (+21.14%)
6 <1> (+1)
:arrow_up:

...gobblin/compaction/mapreduce/MRCompactionTask.java
81.13% <100%> (+4.94%)
13 <4> (+4)
:arrow_up:

...compaction/mapreduce/CompactorOutputCommitter.java
88.88% <100%> (+1.38%)
6 <0> (ø)
:arrow_down:

...pache/gobblin/metrics/event/CountEventBuilder.java
86.95% <100%> (ø)
12 <1> (ø)
:arrow_down:

...a/org/apache/gobblin/cluster/GobblinHelixTask.java
77.41% <0%> (-3.02%)
6% <0%> (+1%)

...main/java/org/apache/gobblin/util/HadoopUtils.java
30.2% <0%> (-0.68%)
24% <0%> (-1%)

...src/main/java/org/apache/gobblin/runtime/Task.java
66.89% <0%> (-0.16%)
84% <0%> (+2%)

...metastore/FileContextBasedFsStateStoreFactory.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

...pache/gobblin/cluster/GobblinHelixTaskFactory.java
100% <0%> (ø)
10% <0%> (+2%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef3003c...972db94. Read the comment docs.

+1 LGTM


[docs] updated the part about Boost in installation guide

Add a note about custom CUDA paths in Windows guide, like in Linux one.
Encourage users to pass Boost paths via CMake options instead of environment variables to deal with CMP0074. I tested on Windows 10 with Visual Studio 2017 the following cases: CMake 3.14.1 and Boost 1.69.0 (after adding CMP0074); CMake 3.11.0 and Boost 1.65.1 (before adding CMP0074). They worked fine.

Closed #2081.
Refer to

https://github.com/Microsoft/LightGBM/issues/2081#issuecomment-480504939,
#1632,
https://cmake.org/cmake/help/v3.14/policy/CMP0074.html,
https://cmake.org/cmake/help/v3.14/module/FindBoost.html.

@huanzhang12
Another case of successful installation by this guide: #2096.

@huanzhang12 Please review.


Tom can now trigger builds in Jenkins

Thanks for submitting a pull request! Maybe @cf-bottom can review this?

Thanks for submitting a pull request! Maybe @vpodzime can review this?


feature:  tile specifications should have some named coordinates

When making tiles like this one:

it would be nice to have a way to specify the locations of midpoints of gentle and sharp track for the purposes positioning centerTowns, starting track, etc. rather than having to fiddle numbers and hunt for the right spots.  Similarly, bar-shaped towns should have some way of positioning, and exact perpendicular rotations.
I'm sure there are other examples that I'm not thinking of, too.

Very nice idea, can improve position to support fields that automatically do this.


大辞泉 Error (255)

When I try and import my daijisen file zero-epwing.exe stops responding and I get
conversion process failed: exit status 255

I managed to get Daijirin working properly though w/ the same steps.

An exit code of 255 means that the Zero-EPWING utility crashed when trying to parse the EPWING data. Are you sure that the copy of Daijisen that you are using is intact and does not have any issues? Also probably not the problem, but figured I would ask -- are you running on a system that has plenty of memory available? I don't know what the usage would be for Daijisen, but I've seen memory usage spike to over 1GB on some larger dictionaries.


feat: universal dialog component

https://sovryn.monday.com/boards/2218344956/pulses/2236624785
Example is in https://feat-refactor-dialog.sovryn.pages.dev/storybook?path=/story/molecule-dialog
Note: had to make close button / icon smaller than it was, otherwise it's going out of viewport on smaller screens (because it's outside of dialog for non-mobile devices)

Point 6a in the spec indicates we should have sizes for 2-7xl but we only have up to 3 in this PR

Added missing sizes

Point 6c in the spec doesn't seem to be implemented here

It's implemented but you need to change your storybook preview width to the mobile device (xs size)


Creation of StreamReader class

Closes #94

Codecov Report

Merging #107 into master will increase coverage by 0.00%.
The diff coverage is 98.77%.

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   94.85%   94.85%
=======================================
  Files         143      145    +2
  Lines        3477     3519   +42
  Branches      387      399   +12
=======================================
+ Hits         3298     3338   +40
  Misses         89       89
- Partials       90       92    +2

Impacted Files
Coverage Δ

packages/buffer-cursor/lib/StreamReader.ts
94.44% <94.44%> (ø)

packages/buffer-cursor/lib/BufferCursor.ts
100.00% <100.00%> (ø)

packages/buffer-cursor/lib/bufToStream.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063ed05...2150551. Read the comment docs.


Cow: Watch prevaj.com

Cow requests the watch of the watch_keyword prevaj\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

prevaj\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ

Approved by Dragonrage in Charcoal HQ