Code issues in the paper

Hello, I am trying to replicate the example in the JOSS paper but I have some issues.

First to reproduce it I need to use the whole register_haberman() and  _haberman() functions. This data processing step distracts from the objective of showing SIRUS, so perhaps you can find some other simple way to retrieve an already-nicelly-formatted dataset for work on it, or you may want to put X and y already nicely formatted somewhere that you (and the reader) can retrieve them with a HTTP.get or a Downloads.download...

You are mixing MLJ and non-MLJ API together and I think this is distracting.. for example model = StableRulesClassifier(; max_depth=2, max_rules=8) is not MLJ API.
Instead it should be:

modelType   = @load StableRulesClassifier pkg = "SIRUS"
model       = modelType()

Related to the previous point, I can't find in the MLJ constructor the option max_rule that you describe in the paper
The mach.fitresult call to me doesn't return the nice rule base that you present in the paper but rather a ugly:

julia> mach.fitresult
SIRUS.StableForest{Float64}(Union{SIRUS.Leaf, SIRUS.Node}[SIRUS.ClassificationLeaf([0.5, 0.5, 0.0]), SIRUS.ClassificationLeaf([0.5, 0.0, 0.5]), SIRUS.ClassificationLeaf([0.0, 0.5, 0.5]), SIRUS.ClassificationLeaf([0.0, 0.0, 1.0]), SIRUS.ClassificationLeaf([0.0, 0.0, 1.0]), SIRUS.ClassificationLeaf([0.5, 0.0, 0.5]), SIRUS.ClassificationLeaf([0.5, 0.0, 0.5]), SIRUS.ClassificationLeaf([0.5, 0.5, 0.0]), SIRUS.ClassificationLeaf([1.0, 0.0, 0.0]), SIRUS.ClassificationLeaf([1.0, 0.0, 0.0])  …  SIRUS.ClassificationLeaf([0.5, 0.5, 0.0]), SIRUS.ClassificationLeaf([0.5, 0.5, 0.0]), SIRUS.ClassificationLeaf([0.0, 1.0, 0.0]), SIRUS.ClassificationLeaf([0.5, 0.5, 0.0]), SIRUS.ClassificationLeaf([0.5, 0.0, 0.5]), SIRUS.ClassificationLeaf([0.5, 0.0, 0.5]), SIRUS.ClassificationLeaf([0.0, 0.0, 1.0]), SIRUS.ClassificationLeaf([0.5, 0.0, 0.5]), SIRUS.ClassificationLeaf([0.5, 0.0, 0.5]), SIRUS.ClassificationLeaf([0.0, 1.0, 0.0])], SIRUS.Classification(), [0.0, 1.0, 2.0])

I have tried to apply the model to the iris dataset but I got predictions that don't even define a probability distribution (bug for multiclasses??):

julia> (X,y)       = @load_iris;
julia> modelType   = @load StableRulesClassifier pkg = "SIRUS";
[ Info: For silent loading, specify `verbosity=0`.
import SIRUS ✔
julia> model       = modelType() ;
julia> mach        = machine(model, X, y);
julia> fit!(mach);
[ Info: Training machine(StableForestClassifier(rng = Random.TaskLocalRNG(), …), …).
[ Info: Converting outcome classes ["setosa", "versicolor", "virginica"] to [0, 1, 2].
julia> est_classes = predict(mach, X)
150-element CategoricalDistributions.UnivariateFiniteVector{Multiclass{3}, Float64, UInt8, Float64}:
 UnivariateFinite{Multiclass{3}}(0.0=>0.5, 1.0=>0.5, 2.0=>0.5)
 UnivariateFinite{Multiclass{3}}(0.0=>0.5, 1.0=>0.5, 2.0=>0.5)
 UnivariateFinite{Multiclass{3}}(0.0=>0.5, 1.0=>0.5, 2.0=>0.5)

I believe that it is useful to show an example that for as much concise and simple as possible, it is also reproducible.
https://github.com/openjournals/joss-reviews/issues/5786

This is a nice suggestion. Thank you for trying SIRUS out. Guillaume Dalle agrees on this issue in https://github.com/rikhuijzer/SIRUS.jl/issues/49. I've added a basic example to https://sirus.jl.huijzer.xyz/dev/basic-example/ and am adding this to the paper too. I'll request a PDF generate in the review issue once I'm done updating the paper.

First to reproduce it I need to use the whole register_haberman() and  _haberman() functions.

This should now be solved. It's still 9 lines of code, but I hope this is okay. I really like the DataDeps checksum to ensure that the dataset is the right one.

You are mixing MLJ and non-MLJ API together and I think this is distracting..

You're right on that. My reasoning was that the MLJ API is non-standard Julia because @load in the background loads symbols from packages. I'm not a fan of such dynamic loading because it has bitten me a few times when trying to get R packages to work. Still, I have incorporated your suggestion in the tutorial and show both ways. I hope that's okay.

Related to the previous point, I can't find in the MLJ constructor the option max_rule that you describe in the paper

You found a bug! Thank you. It turns out that @load StableRulesClassifier pkg="SIRUS" actually loaded the StableForestClassifier (which doesn't have the max_rules hyperparamete) instead of the StableRulesClassifier. I hope that https://github.com/JuliaAI/MLJModels.jl/pull/526 will be merged so that the issue gets resolved. Until then, using SIRUS: StableRulesClassifier works.

The mach.fitresult call to me doesn't return the nice rule base that you present in the paper but rather a ugly:

This is also the result of StableForestClassifier versus StableRulesClassifier.

I have tried to apply the model to the iris dataset but I got predictions that don't even define a probability distribution (bug for multiclasses??):

Do you mean that the output should be a different type than UnivariateFinite? I chose this type because it's the MLJ.jl standard. Also, the random forest model, with these predictions, is tested via MLJ and achieves quite good performance scores, see for example the GitHub Actions Job Summary at https://github.com/rikhuijzer/SIRUS.jl/actions/runs/6171051743/attempts/1#summary-16748537050. The summary shows that the StableForestClassifier often performs similar to the XGBoostClassifier.


Added csv_to_json

Hello,
Can you please tell me why this MR is on hold? Are there any changes required from my end?

@jp9573 Probably not, we are trying to figure out some internal things before we can proceed with merging this.

@jp9573 Probably not, we are trying to figure out some internal things before we can proceed with merging this.

Okay, can you please add hacktoberfest-accepted label to it.

Re-opening MR.


Add DUK_TVAL_SET_xxx_UPDREF() macros

Current idiom for overwriting a duk_tval with another is:
duk_tval tv_tmp;
DUK_TVAL_SET_TVAL(&tv_tmp, tv_dst);
DUK_TVAL_SET_TVAL(tv_dst, tv_src);
DUK_TVAL_INCREF(thr, tv_src);
DUK_TVAL_DECREF(thr, &tv_tmp);  /* side effects */

Provide a macro to make this shorter:
DUK_TVAL_SET_TVAL_UPDREF(thr, tv_dst, tv_src);  /* side effects */

Optimize this combined macro for performance: it appears in a lot of hot paths like LDREG, LDCONST, etc. Also add similar macros for other setters, e.g. DUK_TVAL_SET_NULL_UPDREF() which can avoid an unnecessary INCREF.
Tasks:

[x] Write the basic macros
[ ] Convert call sites throughout
[ ] Optimize DUK_TVAL_SET_TVAL_UPDREF() with measurement as it matters the most
[ ] Test build with refcounting, without fastints
[ ] Test build with refcounting, with fastints
[ ] Test build without refcounting
[ ] Add refcount leak regression test (manual)
[ ] Releases entry

The manual leak regression test is a testcase which exercise as many INCREF/DECREF call sites as possible, and runs a test 10000 times.  The loop count magnifies any leaks, so that a leak of 10 bytes per loop will be detectable as a 100kB leak in final heap usage.
It is executed manually with duk --no-heap-destroy with mark-and-sweep disabled. Leaks can then be detected by comparing the final heap state between a test run with 1000 loops and 0 loops; heap state can also be compared to a "hello world" test. Mark-and-sweep must be disabled so that garbage with broken refcounts won't get collected by mark-and-sweep which would normally happen (and is a good backstop for production environments).
For example:
# Leak test with 10000 loops
$ valgrind ./duk --no-heap-destroy tests/ecmascript/test-dev-refcount-leak-basic.js
[...]
==9802== HEAP SUMMARY:
==9802==     in use at exit: 96,619 bytes in 1,194 blocks
==9802==   total heap usage: 2,263,122 allocs, 2,261,928 frees, 223,363,298 bytes allocated

# Leak test with 0 loops (test case edited manually)
$ valgrind ./duk --no-heap-destroy tests/ecmascript/test-dev-refcount-leak-basic.js
[...]
==9836== HEAP SUMMARY:
==9836==     in use at exit: 96,619 bytes in 1,194 blocks
==9836==   total heap usage: 3,118 allocs, 1,924 frees, 322,742 bytes allocated

# Hello world
$ valgrind ./duk --no-heap-destroy tests/ecmascript/test-dev-hello-world.js
[...]
==9797== HEAP SUMMARY:
==9797==     in use at exit: 87,227 bytes in 1,133 blocks
==9797==   total heap usage: 2,171 allocs, 1,038 frees, 198,512 bytes allocated

Injecting an intentional refcount update bug into the executor and re-running the refcount test:
# Leak test with 10000 loops
$ valgrind ./duk --no-heap-destroy tests/ecmascript/test-dev-refcount-leak-basic.js
[...]
==9261== HEAP SUMMARY:
==9261==     in use at exit: 2,016,619 bytes in 31,194 blocks
==9261==   total heap usage: 2,263,122 allocs, 2,231,928 frees, 223,363,298 bytes allocated

# Leak test with 0 loops (test case edited manually)
$ valgrind ./duk --no-heap-destroy tests/ecmascript/test-dev-refcount-leak-basic.js
[...]
==9277== HEAP SUMMARY:
==9277==     in use at exit: 96,619 bytes in 1,194 blocks
==9277==   total heap usage: 3,118 allocs, 1,924 frees, 322,742 bytes allocated

# Hello world
$ valgrind ./duk --no-heap-destroy tests/ecmascript/test-dev-hello-world.js
[...]
==9281== HEAP SUMMARY:
==9281==     in use at exit: 87,227 bytes in 1,133 blocks
==9281==   total heap usage: 2,171 allocs, 1,038 frees, 198,512 bytes allocated

This branch seems to be free of refcount issues based on running the above test manually.
There are actually two kinds of refcount issues and now there should be a reasonable harness for each:

The refcount is too low, so that the object gets freed prematurely. This is usually caught in valgrind testing at least, and there's been a reasonable harness for this already.
The refcount is too high, so that the object stays around until mark-and-sweep. This is not fatal even in a production environment (the object just sticks around longer than ideal). There hasn't been a harness for this, but this manual testcase, added to release checklist, should catch most of these.

Refcounting bugs are the worst.  I speak from experience.  With a normal double-free there are only two possible places where the bug could be; if on the other hand a double free is caused by a refcount bug, any one of the DECREFs could be in error.  Very fun to diagnose.


Fix links in documentation

What this PR does / why we need it:

Fix links in docs to use HTTPS (annoying when on a network that blocks HTTP)
Fix broken links in docs

Special notes for your reviewer:
Release note:

NONE

/retest-required

/ok-to-test

Rebased to try and get the failed tests to pass, but it looks like I kicked myself back in the special labels process.

Rebased to try and get the failed tests to pass, but it looks like I kicked myself back in the special labels process.

@andrewimeson The failures are not related to this PR itself, so there is no problem. :slightly_smiling_face:
Once, there will be an approval, the kubevirt-bot will automatically retry the failing tests.
/lgtm
/retest-required
@jean-edouard Can you have a look?
Thanks

/approve


Can't build xcframework success

I want to build iOS xcframework, but it's fail with following error message
❌  ld: library not found for -lmbgl-core
❌  clang: error: linker command failed with exit code 1 (use -v to see invocation)
The following build commands failed:
Ld maplibre/platform/ios/build/ios/ArchiveIntermediates/dynamic/IntermediateBuildFilesPath/ios.build/RelWithDebInfo-iphoneos/dynamic.build/Objects-normal/armv7/Binary/Mapbox normal armv7 (in target 'dynamic' from project 'ios')
I have tried several Xcode version(14.1, 13.4.1, 13.1), but it doesn't work.
My Mac OS version is "Monterey 12.6.1"
Xcode version is "14.1"
And my Mac is M1 chip
The build command I inputed was

cd platform/ios
make iproj CI=1
make xcframework BUILDTYPE=Release

Thanks for the report. I am able to reproduce this locally.

I am also able to reproduce on Big Sur with Xcode 13.2.1.  The scheme that builds for UI Tests, iosapp, builds and works fine.
Looking at the log file, within.cpp fails to build.  In a Slack chat @louwers mentioned GitHub Actions that build the XCFramework.  I went to check those and release hasn't ran for a month and pre-release hasn't ran for a couple of years on GitHub.
I just kicked off both of those manually to see what they will yield.   Here is where the GitHub Actions can be verified.

https://github.com/maplibre/maplibre-gl-native/actions

These are the two actions to be monitored when there status is updated at GitHub:

[ ] ios-release
[ ] ios-pre-release

 failure in target 'mbgl-core' src/mbgl/style/expression/within.cpp
** ARCHIVE FAILED **

The following build commands failed:
	CompileC /Users/roblabs/Library/Caches/XCSBuilder/Bots/0a0160914c83b73de4c77f2f650006b1/Source/maplibre-gl-native/platform/ios/build/ios/build/mbgl-core.build/Debug-iphonesimulator/Objects-normal/i386/within.o /Users/roblabs/Library/Caches/XCSBuilder/Bots/0a0160914c83b73de4c77f2f650006b1/Source/maplibre-gl-native/src/mbgl/style/expression/within.cpp normal i386 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'mbgl-core' from project 'Mapbox GL Native')
(1 failure)

# print Mac OS X operating system version information
sw_vers
ProductName:	macOS
ProductVersion:	11.7.1
BuildVersion:	20G918

# Print operating system name
uname -a
Darwin nullisland.local 20.6.0 Darwin Kernel Version 20.6.0: Thu Sep 29 20:15:11 PDT 2022; root:xnu-7195.141.42~1/RELEASE_X86_64 x86_64

# Xcode version & path
/usr/bin/xcodebuild -version
Xcode 13.2.1
Build version 13C100

@roblabs ios-release runs though it seems (only fails because the tag has already been released).

mbgl/style/expression/within.cpp is defined once in the CMake files.   That seems fine.  My other guess would be to investigate if or when the CMake files were last refactored.

https://github.com/search?q=repo%3Amaplibre%2Fmaplibre-gl-native+within.cpp+language%3ACMake&type=code&l=CMake

I tried a lot of things to fix this, including increating the minimum deployment target to iOS 12, removing and re-adding the libraries to link in Xcode (Stack overflow reported that this sometimes helps), set "build active active architecture only" to NO. All to no avail.
Just tried again on the macOS runner which is using macOS Montery (12.5.1) and Xcode 14.2. Selecting the dynamic scheme and "Any iOS Device" as target, then selecting Product > Archive works (as well as creating an archive through xcodebuild).

OK I think I finally found the issue: CMake 3.24 works while CMake 2.35 does not.

Switching cmake versions worked locally for me as well.  We'll have to decide on either creating a dependency for<EMAIL_ADDRESS>or fixing up due to the changes in the link above.
Good catch @louwers

The policies can be set conditionally as you know which version of CMake you run with. So I'd set the policy accordingly for the versions of CMake when it appeared (or fix our config that the policy is not needed).
It seems though that they reverted it in 3.36, but we should not rely on that.

I tried setting the policy but that did not fix the issue for me.

Did you do a full rebuild?

I can investigate but not before the weekend.

Note that it is still possible to create an XCFramework with Bazel. #806
I am not very happy with the setup of CMake + checked in Xcode files + Makfile + scripts + xcodebuild on the iOS side. The Bazel setup seems much cleaner, in part thanks to much better iOS support.

I will be a bit provocative and say, why not CMake-only 😊
I think we should really aim in that direction.

Because CMake support for iOS is lacking. It cannot build XCFrameworks for example.

Really? You still generate the Xcode project and then you can do anything with it. Do XCFrameworks require some very special configuration to be made?

Generating the entire Xcode project with CMake and getting rid of the checked in Xcode files is probably a big improvement already. But I am not sure if it is feasible. I have to look more into it #737

We have overhauled the build config.
Please try out build instructions in the pre-release thread.


Enhancement | Clear filters

User should be able to clear the filters they've selected.
If user clicks on filtered language, the list should reset.
If user clicks on sorted item, the list should reset.

This works for langugage, doesn't work for sorting.

Hey @aadeshkulkarni ,
done with the Enhancement of clear filters for the sorted item. u can assign this task to me.


Gateway admin UI packaged as an LnBits extension

We should explore building a gateway Admin interface packaged as an LnBits extension.

I wonder if we could use the LNBits API to also make/receive payments? I doubt that all backends it runs on support HTLC interception, but maybe plugins can only be available for certain backends?

hey ok, I'm looking to explore this with you

I wonder if we could use the LNBits API to also make/receive payments? I doubt that all backends it runs on support HTLC interception, but maybe plugins can only be available for certain backends?
Curious to see how Cashu did this for their extension. We can look closer at LnBits api in exploration

hey ok, I'm looking to explore this with you

Hello @IgboPharaoh can I assign this to you? Happy to collab on the exploration of what we need to design and implement

that sounds great @okjodom look forward to it

Hey @IgboPharaoh make sure you join the discord chat.fedimint.org. We can coordinate more over there!


SLO workload native

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: #568
What is the new behavior?

SLO workload for native driver
workflow for github actions

Other information

Codecov Report
Patch coverage has no change and project coverage change: -18.63 :warning:

Comparison is base (57d382e) 65.03% compared to head (c188b62) 46.41%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #671       +/-   ##
===========================================
- Coverage   65.03%   46.41%   -18.63%
===========================================
  Files         220      149       -71
  Lines       21843    15785     -6058
===========================================
- Hits        14205     7326     -6879
- Misses       6864     8124     +1260
+ Partials      774      335      -439

Flag
Coverage Δ

?

1.17.x
46.06% <ø> (-0.07%)
:arrow_down:

1.19.x
46.48% <ø> (-18.49%)
:arrow_down:

1.20.x
46.49% <ø> (-18.24%)
:arrow_down:

integration
?

macOS
46.41% <ø> (+0.01%)
:arrow_up:

secure
?

ubuntu
46.41% <ø> (ø)

unit
46.41% <ø> (-18.16%)
:arrow_down:

windows
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 169 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Cannot Login to Gerrit Server

Hello,
I am using intellij 2018.1 ultimate edition.
Just wanted to know which plugin is compatible with this intellij edition.
I tried using the one from https://plugins.jetbrains.com/plugin/7272-gerrit. (downloaded the latest one)
But its not working at the very first step. I am not able to login to our gerrit Server.
I get error as below on Test connection
com.google.gerrit.extensions.restapi.RestApiException: Request failed.
Could you please help here?
P.S. - Gerrit server version is 2.14
Thanks in advanced.

@abihani10: Can you please post the URL you are using (feel free to anonymize the domain name)? The plugin is compatible with this version of IntelliJ and Gerrit.

@uwolfer - we are using this URL: http://abcgerrit:8080

@abihani10: Thanks. I assume this is the URL you are also using when you access Gerrit with your web browser (also check if you are using HTTP / HTTPS)? Please verify that you are using exactly the same URL as you are using in the the browser. Please also note the password hint in the connection dialog.
Also, I suggest downloading the plugin in IntelliJ settings -> plugins in order to get updates, but I think this does not fix your current issue.

@uwolfer Thanks for the suggestions. I had implemented all of those before asking the question here.
But out of nowhere when I tried to test the connection today morning, unbelievably it worked.
Have no idea what went wrong and what is right now.
Anyways that solved my issue. Thanks for the prompt help!! :)


Need adding empty line before fun

I would like to add this check
Case 1:
Fails:
interface Rule {
    fun check()
    fun test(enabled: Boolean)
}

Success:
interface Rule {

    fun check()

    fun test(enabled: Boolean)
}

Case 2:
Fails:
    fun method1() {
        // ...
    }
    fun method2(p: Boolean) {
        // ..
    }

Success:
    fun method1() {
        // ...
    }

    fun method2(p: Boolean) {
        // ..
    }

Correct me if I'm wrong but with 0.14.0, you should get this behavior now thanks to https://github.com/shyiko/ktlint/pull/72/
The only thing you'll still get flagged is
interface Rule {

    fun check()

    fun test(enabled: Boolean)
}

since there's no need for that newline between the interface and method declarations. It's unnecessary.


Adding worker dummy data

Adding dummy data for workers and other modules
Added relevant scripts used to create the data

Thank you. Will check and merge in the evening EST.

Closed the current one will merge new one with updates


bug: internal table doesn't display correctly

Describe the bug
PK is partition_id, but count(*) > count(distinct(partition_id)), i.e. a single row repeats multiple times.
dev=> describe __internal_some_table_123_source_123;
       Name        |                             Type                             | Is Hidden | Description
-------------------+--------------------------------------------------------------+-----------+-------------
 partition_id      | character varying                                            | false     |
 offset_info       | jsonb                                                        | false     |
 primary key       | partition_id                                                 |           |
 table description | __internal_some_table_123_source_123 |           |
(4 rows)

dev=> select count(distinct(partition_id))  from __internal_some_table_123_source_123;
 count
-------
    73
(1 row)

dev=> select count(*)  from __internal_some_table_123_source_123;
 count
-------
 17520
(1 row)

Error message/log
No response
To Reproduce
No response
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
No response
Additional context
No response

Is this related to https://github.com/risingwavelabs/risingwave/issues/5590?


No files/findings for github enterprise.

When I use gitrob against github.com things seem to work fine, however, when I point it at my enterprise github it does not list any files or findings.
I'm calling it like so:
gitrob analyze jhenrich --site=https://github.acme.com --endpoint=https://github.acme.com/api/v3
I do not see any errors in the output, all the repositories are found, but there is nothing in the repos.
I'm using v1.1.0

Hi @crimsonknave, debugging problems with GitHub Enterprise installations is unfortunately a little difficult for me as I don't have access to an installation.
If you run Gitrob like this:
DEBUG=1 gitrob analyze jhenrich --site=https://github.acme.com --endpoint=https://github.acme.com/api/v3

You should see details of the HTTP request and responses from the github_api gem. Do you see any 404s or something when it starts fetching repository content?

/cc @hgautam (reported the same issue in an old Issue)

I have asked GitHub Enterprise Support if it's possible for me to get a trial installation so I can verify that everything works against GitHub Enterprise. Let's see what they say.
I would of course still appreciate any comments from you folks if you figure out what the problem might be or if you have any interesting output from Gitrob.
Thanks!

Thanks Mike. I just see bunch of sql commands in std out. Are there any details logs anywhere that can tell me more?I would be happy to debug this more. Any pointers appreciated.
Thanks,HimanshuDate: Sun, 17 Apr 2016 09:09:47 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [michenriksen/gitrob] No files/findings for github enterprise. (#61)
I have asked GitHub Enterprise Support if it's possible for me to get a trial installation so I can verify that everything works against GitHub Enterprise. Let's see what they say.
I would of course still appreciate any comments from you folks if you figure out what the problem might be or if you have any interesting output from Gitrob.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@hgautam could try to run Gitrob with DEBUG=1 gitrob analyze ...? Then you should see request/response information from the github_api gem. It would be interesting to see the response could when Gitrob fetches repository contents.
Thanks!

I only see three statuses printed in the debug. It looks like /user?access_token, /user/repos and a second page of repos. After that I see it printing the connection options and an info about a call to each repo, but never the payload or response code.
When I run against public github I see the status printed out for each repo.
I know that our version of github enterprise is a bit old, but I can't find a version anywhere. But, I wouldn't expect that to break anything like this. It is responding on the v3 api url so it's not that old.

Hi Joseph,We upgraded to GH enterprise 2.5.4 over the weekend. Ran gitrob analyze with debug option on the newer version and I dont see response code or payload either.
Please let me know if you guys want me to run any other test commands or capture any logs etc.
Appreciate your help.
-HimanshuDate: Mon, 18 Apr 2016 08:14:15 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [michenriksen/gitrob] No files/findings for github enterprise. (#61)
I only see three statuses printed in the debug. It looks like /user?access_token, /user/repos and a second page of repos. After that I see it printing the connection options and an info about a call to each repo, but never the payload or response code.
When I run against public github I see the status printed out for each repo.
I know that our version of github enterprise is a bit old, but I can't find a version anywhere. But, I wouldn't expect that to break anything like this. It is responding on the v3 api url so it's not that old.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

I'm having a similar problem.  I noticed that the gathering targets does a GET on /users/xxx
meaning the url should be
https://github.mycompany.com/users/xxx
however the actual URL is
https://github.mycompany.com/xxx
So I get an error:
Gathering targets...EXECUTED: get - /users/xxx with PARAMS: {} failed
[!] Faraday::TimeoutError: Connection timed out - connect(2)
[!] No users or organizations found; exiting

I should add that I'm running UBUNTU
Linux ip-10-206-4-240 3.13.0-83-generic #127-Ubuntu SMP Fri Mar 11 00:25:37 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
and I built the the server and the GitRob app today.

I had to list a valid endpoint on the commandline and then it took off running.

So, @michenriksen, I figured it out! It all works if I add a / after v3.
--endpoint=https://github.roving.com/api/v3/

It would be nice if there'd been some sort of error in the output. Even with debug enabled I don't see anything indicating that it got a 404 back from github.

I have it running too against an enterprise github server.  I ran it with the
DEBUG=1 gitrob analyze.....
and I think I found the problem.....
after the   .../api/v3 there should be a forward slash before repos when it is looking at the repo.  its missing.  I copied the URL out and tried it in a browser and got essentially a 404.  then I inserted the / and got a lot more data back.  Looks like the file list.

@crimsonknave, @osok: Wow, thanks a ton for your help and figuring out the problem. This is awesome! I'm happy that you got it working for you.
It sounds like a pretty easy fix. I will look into implementing it as soon as I have some time.
I haven't heard back from GitHub yet regarding getting access to a GitHub Enterprise installation, but hopefully I will get access to one soon, so I can help with debugging these problems.
Cheers,

That did it for me to. Just added a / after api/v3/ and i see flagged material now.
Thanks for all your help. However, I didn't see see any error in the debug output indicating this might be the problem. How did you even figure this out?
Thanks,HimanshuDate: Wed, 20 Apr 2016 13:10:36 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [michenriksen/gitrob] No files/findings for github enterprise. (#61)
I have it running too against an enterprise github server.  I ran it with the
DEBUG=1 gitrob analyze.....
and I think I found the problem.....
after the   .../api/v3 there should be a forward slash before repos when it is looking at the repo.  its missing.  I copied the URL out and tried it in a browser and got essentially a 404.  then I inserted the / and got a lot more data back.  Looks like the file list.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

I think I experienced this issue because I copy pasted the URL format for the API from the README. Would it be a good idea to change --endpoint=https://github.acme.com/api/v3 to --endpoint=https://github.acme.com/api/v3/ on this line?


Update pip to the latest version (19.x)

We had issues in the past with versions of pip >= 10.x breaking our code and build process on some distros (RHEL 6, etc.) so we pinned pip to 9.x to avoid those issues.
It has been a long time since that so we should re-evaluate if we can upgrade pip to the latest version.
Related PRs / issues:

https://github.com/StackStorm/st2/pull/4500
https://github.com/StackStorm/st2/issues/4515

Complements https://github.com/StackStorm/st2/pull/4712
st2common/bin/st2-run-pack-tests is the file I missed in previous PRs.


[Event Request] Table 81 "Gen. Journal Line" - function FindFirstVendLedgEntryWithAppliesToDocNo - event

Could you please add integration event
OnFindFirstVendLedgEntryWithAppliesToDocNoOnAfterSetFilters(var GenJournalLine: Record "Gen. Journal Line"; AccNo: Code[20]; var VendLedgEntry: Record "Vendor Ledger Entry")
right before exit(VendLedgEntry.FindFirst) in function FindFirstVendLedgEntryWithAppliesToDocNo()?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Add "tag" option to second and third level headings

Adds an optional tag prop to secondLevelHeadings and thirdLevelHeadings in NavigationAccordion.

Excellent points! I have a slight preference for tag over flag, but could be convinced otherwise. I can merge this PR and #207 first, then work on these two points in a follow up PR. 🎉

Then this tag prop would accept a string for the theme of the flag instead of a whole component.

I'm slightly hesitant to disallow nodes altogether in case we're moving fast and need to add a new tag theme to one repo temporarily until the next dr ui release can be done. Maybe there's a way to allow a "custom" option + component for those temporary situations. 🤷♀

Sounds good!


Fn::Transform does not support Fn::Ref in the Name field of the Transform.

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request
What do you want us to build?
Support Fn::Ref in the Name field of Fn::Transform, like below.
'Fn::Transform':
  Name: !Ref MyTransformName
  Parameters:
    Location: !Ref InputValue

Currently, the above will fail with the error Key Name of transform definition must be a string.
Tell us about the problem you are trying to solve. What are you trying to do, and why is it hard?
Trying to reference the name of the transform under Fn::Transform.
Are you currently working around this issue?
Yes, have to hard-code the name of the Transform.
What is the expect behavior with this new feature
Please include some code examples showing how this feature can be used.
Fn::Ref should work in the Name field of the transform just like it does in the Parameters field.
'Fn::Transform':
  Name: !Ref MyTransformName  ----> Does not work
  Parameters:
    Location: !Ref InputValue ---> Works

Additional context
Anything else we should know?
Attachments
If you think you might have additional information that you wouldd like to include via an attachment,
please do - we will take a look. (Remember to remove any personally-identifiable information.)

Please don't take this the wrong way, but what's the use case for this?

Please don't take this the wrong way, but what's the use case for this?

So I'm creating this on behalf of a customer, but one use case would be when using a custom macro, the customer might want to pass the name of the custom macro as a Parameter to the Stack using Fn::Transform.

I feel like if Fn::Transform did support using a macro name provided as a parameter, I would describe it as a remote code execution vulnerability for your stack.

I don't immediately see why you'd want to pick a macro at runtime.
To me macro's are things you think about when authoring, not when you're deploying.
Eg. Marco's can have different parameters depending on their name, so you'd might have to change the macro anyway.

I don't immediately see why you'd want to pick a macro at runtime.
To me macro's are things you think about when authoring, not when you're deploying.
Eg. Marco's can have different parameters depending on their name, so you'd might have to change the macro anyway.

I agree with you on that, they're something to add when authoring not deploying. Perhaps the customer just wanted to keep all the variables under Parameters.
Another use case could be if the customer's creating the Macro in the parent stack and using the Macro in a nested stack under the parent stack, then they might want to pass the Macro Name as a parameter to the Nested Stack, and then it would be referenced in the Fn::Transform name.
I've shared this GitHub issue with the customer as well and requested them to comment. They can give us more details on their specific use-case.

Thank you for the suggestion @shantgup. We will triage this and post updates here.

Hey @shantgup, it looks like this issue is a duplicate of https://github.com/aws-cloudformation/cfn-language-discussion/issues/64. Unless you disagree I will close this one in favor of the existing one.

Closing in favor of #64. Please feel free to reopen if you have any questions.


feat: add scalar WKB reader/writer

This is adding a similar wrapper around the GeoArrow reader/writer as we have for WKT.
(it's actually sufficiently similar code that I am wondering if we shouldn't template it for WKT/WKB ..)

@paleolimbot good to go?


Lab test

Pull requests into cqm-parsers require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[ ] This pull request describes why these changes were made.
[ ] Internal ticket for this PR:
[ ] Internal ticket links to this PR
[ ] Code diff has been done and been reviewed
[ ] Tests are included and test edge cases
[ ] Tests have been run locally and pass

Reviewer 1:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Codecov Report

Merging #26 into full_qdm_5_4_support will decrease coverage by 0.35%.
The diff coverage is 100%.

@@                   Coverage Diff                   @@
##           full_qdm_5_4_support     #26      +/-   ##
=======================================================
- Coverage                 86.16%   85.8%   -0.36%
=======================================================
  Files                        59      60       +1
  Lines                      1409    1423      +14
=======================================================
+ Hits                       1214    1221       +7
- Misses                      195     202       +7

Impacted Files
Coverage Δ

lib/qrda-export/catI-r5/qrda1_r5.rb
100% <100%> (ø)
:arrow_up:

lib/qrda-import/base-importers/section_importer.rb
90.24% <100%> (-1.76%)
:arrow_down:

lib/qrda-import/patient_importer.rb
92.85% <100%> (+0.08%)
:arrow_up:

...-importers/laboratory_test_recommended_importer.rb
100% <100%> (ø)

...nt-importers/laboratory_test_performed_importer.rb
95.45% <100%> (-4.55%)
:arrow_down:

lib/cqm_report.rb
100% <100%> (ø)
:arrow_up:

...element-importers/assessment_performed_importer.rb
94.11% <0%> (-5.89%)
:arrow_down:

...ment-importers/physical_exam_performed_importer.rb
95% <0%> (-5%)
:arrow_down:

...t-importers/diagnostic_study_performed_importer.rb
96% <0%> (-4%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92aa28f...63ad85d. Read the comment docs.


Fixed SDEs being unnecessarily slow to solve when max_steps!=None.

The main changes needed to make this happen are in
https://github.com/patrick-kidger/equinox/pull/548
and as such this commit is fairly small -- it declares a dependency on
a new (as yet unreleasd) version of Equinox, and removes the
compatibility shim that was there before.
How things used to be.
To explain what's going on here a little more carefully: JAX only
recently added support for communicating to a custom_vjp which
input arguments were being perturbed, and which output cotangents were
symbolic zeros. Prior to that, a custom_vjp basically just had to
differentiate all inexact arrays.
However, there are some nondifferentiable inexact arrays, in the
sense that attempting to differentiate them will raise an error.
Solving SDEs has one such array: the nondifferentiable input to a
VirtualBrownianTree, which is guarded by a eqxi.nondifferentiable to
reflect the fact that Brownian motion is nondifferentiable.
So it used to be the case that the custom_vjp underlying
RecursiveCheckpointAdjoint would differentiate the overall
make-a-step function with respect to all inexact arrays,
including the time variable, hit the nondifferentiable guard, and
crash.
One (unsafe) fix would have just been to remove the nondifferentiable
guard. In practice I previously took the slower, safer option: silently
switch out RecursiveCheckpointAdjoint for a DirectAdjoint. The
latter is much less efficient, but uses no custom_vjp, and thus used
the perturbation and symbolic-zero propagation rules already present
in JAX's AD machinery, and was thus safe to use here.
How things are now.
And so, what has now changed: JAX has now added support for tracking
which inputs are perturbed, and which cotangents are symbolic zeros.
The Equinox PR above uses this functionality to determine which parts
of the carry need to be differentiated; no longer is it just "all
inexact arrays".
And thus this Diffrax PR removes the compatibility shim that is no
longer needed.
Implications.
SDE solving should now be much faster. In particular this fixes the
speed issue reported in #317.

(Ignore the failing CI, it just doesn't know about the as-yet-unreleased version of Equinox.)


Missing /warewulf/etc/functions?

Hi,
Is there a missing directory? It seems there should be a directory /warewulf/etc/functions but I don't find it is warewulf-overlay-gpu. I checked utils-core also. Have I missed something in the README?
# /bin/bash -xv /warewulf/sbin/service.warewulf-overlay-gpu-setup.sh
which () {  ( alias;
 eval ${which_declare} ) | /usr/bin/which --tty-only --read-alias --read-functions --show-tilde --show-dot $@
}
#!/bin/bash

# Source our common warewulf functions
[[ -f /warewulf/etc/functions ]] && source /warewulf/etc/functions || exit 1
+ [[ -f /warewulf/etc/functions ]]
+ exit 1

That's currently in the utils-core repo, which includes stuff that get's re-used by the other overlays. I'm also in the process of renaming these to be more descriptive in what they do.

Yeah, I missed it. Thanks for pointing me to it


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-24-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 959

Questions ?
Please refer to the Backport tool documentation


add weekly posts chinese translation

adding chinese translations for weeklies 56 - 58

@renrutnnej  - here is the merge for chinese translations. I have merged already and is commenting for FYI.


How to use the pagechange event?

Hey guys, I read the documentation and examples a lot but i was unable to use the events.
Can someone show me what i am doing wrong?
To a better experience I put the sample of my code here: jsfiddle

Hi,
You can find here a new jsfiddle. I don't use the page-change event but I use the v-model to know the current page index.
I have changed the url of the vue-carousel js by this one<EMAIL_ADDRESS>to ensure the use of the latest version (0.18 from NPM).
I hope this helps you.

Probably not going to help you now, but for anyone else: http://jsfiddle.net/3sfrc5ov/
I updated the url for the lib in the fiddle and moved the handler to carousel component instead of the slide.


The search functionality is broken when using the localcdn extension

There are some errors in the browser console:
https://i.imgur.com/lw0Wro8.png
"LocalCDN is a web browser extension for your Firefox that emulates CDNs (Content Delivery Networks). It intercepts the network traffic between a website and remote CDNs, finds supported resources locally, and injects them into the environment. All of this happens automatically, so no prior configuration is required."  (from the developers at https://codeberg.org/nobody/LocalCDN/wiki )

Shouldn't this be a bug on the localcdn plugin, not on us?

Looks like they have a jQuery specific FAQ that they rewrite the version of jQuery used sometimes.

Will this have an effect on #139 ?

Shouldn't this be a bug on the localcdn plugin, not on us?

I opened because it was working with the old version and now it isn't... So it was the new version that introduced the issue and also maybe someone would also have the same issue as me.
With a bit more investigation by using https://www.localcdn.org/test/check to test the site
it indicates that the issue is because "Crossorigin and/or integrity attributes". It also presents a solution within the extension configuration:
Solution:
• Firefox: Enable the HTML filter
• Other browsers do not support the HTML filter. Please disable LocalCDN for these websites.

Given that the solution for non-FF is "disable localCDN" - I'm going to close this ticket, but it's good you opened it, because now others have a trail if they have a similar issue.


[DOC] Fixing random_state in docstrings

fixes: #1349
adds a general docstring for random_state

I think there was a miss understanding, the idea is not to use the same documentation we used in #1271 , the idea is to check if there is somewhere where the documentation needs more information. For example in the case of deep learning it needed to be clarified about the GPU CPU thing in #1271  but thats not the case everywhere

I think there was a miss understanding, the idea is not to use the same documentation we used in #1271 , the idea is to check if there is somewhere where the documentation needs more information. For example in the case of deep learning it needed to be clarified about the GPU CPU thing in #1271 but thats not the case everywhere

Understood!, will update according to the individual models! also, I think @MatthewMiddlehurst  has given general docstrings to some, should I follow the same suite and add specifics to the modules which need them?
general docstrings:
    random_state : int, RandomState instance or None, default=None
        If `int`, random_state is the seed used by the random number generator;
        If `RandomState` instance, random_state is the random number generator;
        If `None`, the random number generator is the `RandomState` instance used
        by `np.random`.

I think there was a miss understanding, the idea is not to use the same documentation we used in #1271 , the idea is to check if there is somewhere where the documentation needs more information. For example in the case of deep learning it needed to be clarified about the GPU CPU thing in #1271 but thats not the case everywhere

Understood!, will update according to the individual models! also, I think @MatthewMiddlehurst has given general docstrings to some, should I follow the same suite and add specifics to the modules which need them?
general docstrings:
    random_state : int, RandomState instance or None, default=None
        If `int`, random_state is the seed used by the random number generator;
        If `RandomState` instance, random_state is the random number generator;
        If `None`, the random number generator is the `RandomState` instance used
        by `np.random`.

yeah i think this part should be the same everywhere (if the code does that, if not than not) correct me if am wrong @MatthewMiddlehurst

Be careful, this may not be appropriate for every random_state. Generally if it goes through check_random_state it should be fine.

will be done in #1417


List courses aleksi

LGTM.

Coverage decreased (-6.6%) to 42.857% when pulling c5db748709d1ff71079ddc376aec7be57aed9b90 on list-courses-aleksi into c58d9954b7b40e5af85aa9662089aa8beef8d0ea on master.


Non monitoring Agent

This will likely be an enhancement proposal. Logging an an initial issue here.
The idea is to run an agent on a machine, with no TPM, yet still capable of accepting revocation events.

there's already a skeleton of this in the keylime ca.  the "listen" functionality essentially does this: https://github.com/keylime/keylime/blob/89e2ffb55829ea3af7cb602b7df90e43d23372e1/keylime/ca_util.py#L338  but we'd need to expand that to execute some set of revocation actions (instead of being hard wired to revoke certs)

Very handy, thanks @nabilschear !

I've worked around this in the past by just having an exclude list that includes everything. But you still have to set up the tpm, ima, etc just to have it all ignored. Would be nice to have as a real feature

Would it also be possible for this agent (and others) to receive events when a new nodes is approved? This would be useful for things like: make sure a host is monitored by keylime before it is put into a k8s cluster. We have the ability to remove a node from a cluster that fails, but nothing to tell some bootstrapping system it's time to add a node.

Now that we have webhook support for external systems, is this issue still relevant?

Probably not. I think webhooks are a cleaner solution than something that can do even more code execution.


When we're ready: activate the track!

@tgecho can you fix the conflicts on this so we can take this thing live?

w00t. OK, @tgecho I think we're ready. Want to rebase this onto master?

haha. Ditto. What he said.

Well... that's not quite the silliest merge conflict I've ever seen. Fixed!

:tada: w00t!!!!!!

Yay! Updating and deploying the api now!


Integrate new RIPK2 dataset into perses/examples/new-cli/

We have a new RIPK2 public dataset we should integrate into perses/examples/new-cli/ and automate benchmarking for these datasets.

This is superseded by #1120


Convert SystemDeviceType enum to a string

Just to be sure, the real version of this needs to be at github.com/youtube/cobalt, not on sandbox !

Just to be sure, the real version of this needs to be at github.com/youtube/cobalt, not on sandbox !

Oh, no!!


reva: add oidc config options

[ ] OIDC provider url
[ ] InsecureSkipVerify when connecting to the IdP, needed to make testing easier, should log a warning
[ ] client id
[ ] username attribute
[ ] stable identifier ... default to sub&iss? stored in the opaque user info?

fixed by https://github.com/cs3org/reva/pull/127


add POST /eth/v1/beacon/pool/sync_committees

added based on https://hackmd.io/@QYHAVYiHRg65pdI_CEm7Eg/syncommitteeapi#POST-ethv1beaconpoolsync_committees

@rolfyone Consider adding back ticks to the route in the PR title for consistency with other PRs :)
When a validator submits a signature and that validator is part of multiple subnets, should the node broadcast the signature on all those subnets?

sorry, i did it for most, i didn't think people really cared either way, but fixed.

The beacon node should broadcast the signature on all subnets it is applicable to

@rolfyone Consider adding back ticks to the route in the PR title for consistency with other PRs :)
When a validator submits a signature and that validator is part of multiple subnets, should the node broadcast the signature on all those subnets?

The beacon node should broadcast the signature on all subnets it is applicable to


quiche: add support of delayed close to QUIC session

Implement a TODO in QuicFilterManagerConnectionImpl::close() to delay close a quic connection.
The behavior mimics ConnectionImpl::close():
If there is buffered data at quic stream or connection layer, wait for QUIC to drain all the data with a timeout if delayed close timeout is configured. After data is drained, close the connection if FlushWrite.
If close() takes in FlushWriteAndWait and config has delayed close timeout, delay closing the connection even when there is no pending data or data has been drained.
Risk Level: low, no in production
Testing: added new unit tests
Part of #2557

/assign @alyssawilk

I sync'ed with https://github.com/envoyproxy/envoy/pull/8496 and added client side implementation and integration test. PTAL

Ping? @alyssawilk


Xnero: Watch Amtex[\W_]*Enterprises(?!.net)

Xnero requests the watch of the watch_keyword Amtex[\W_]*Enterprises(?!\.net). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Amtex[\W_]*Enterprises(?!\.net) has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


How to predict using trained model in T2T?

Help

I have trained a Speech Recognition model based on transformer. How can I test its performance? Is the command "t2t-decoder"?

Yes, see the README.


Markdown monospace font option; fix some validation and default values

This PR addes an optional forceMono flag to the signature of Markdown sections. The use case is the 'half page' (first verso page with publication details) of many books. To do this I

added a mono font to all the font set options
added substitution of that value for CSS
made alternative CSS and HTML template for monospace variant

Tested with value absent, set to false and set to true.

LGTM


May I ask is there any code for the training?

impressive!
May I ask is there any code for the training?

Yes, there's training code based on Jaxline.  See here: https://github.com/deepmind/tapnet#installation-for-tap-net-training-and-inference


Add the ability for a player to withdraw their trade offer

As of commit de8d58c72f8c0e915f162589cf56f512e034ced7, if a player make a trade offer, and would like to change that trade offer, they currently need to wait for all players to reject the trade. Add a button/action to withdraw the current trade offer.

Added in<PHONE_NUMBER>23b59d8cbd4838880879c13077b3be.


Overwrite Editor Mark

Is it possible to overwrite an exisiting mark? E.g when inserting an image, the resulting html is <img src="/files/test.png" alt="test.png" data-nodeid="12">. In my use-case I would like to add an <a>-tag around the <img>-tag. Is there any way to do this?

I think you can use customHTMLRenderer


Genymotion support example

Add Genymotion Cloud example in demo-react-native-jest project

This pull request adds configuration on how users can start Genymotion Cloud devices from UUID or recipe name in example project for reference.

@lilinor thanks for this! I will accept this PR ASAP, but will add some minor changes first.

@lilinor I've added subtle changes so that this could theoretically run on Detox CI, if programmed to. Please see https://github.com/wix/Detox/pull/2857/commits/38a87a8d9f4e9bf595febedf38d6de96c0b371a9

Thanks a lot @d4vidi for accepting the PR :)


Potential for documentation copy-paste error

Changelog

Documentation typo error.
Description

The example given for including the foxglove bridge launch file in another XML launch file in ROS2 had an extra forward slash that was removed.
Prevent copy-paste issue.

BeforeAfter
[INFO] [launch]: Default logging verbosity is set to INFO
[ERROR] [launch]: Caught exception in launch (see debug for traceback): Caught multiple exceptions when trying to load file of format [xml]:
 - InvalidFrontendLaunchFileError: Caught multiple exceptions when trying to load file of format [xml]:
 - ParseError: mismatched tag: line 6, column 4
 - RuntimeError: Expected only one root
 - SyntaxError: invalid syntax (foxglove_bridge_launch.xml, line 1)

Something is stuck with the CLA check so I made a separate PR with the fix: https://github.com/foxglove/ros-foxglove-bridge/pull/296


Send emails to all users with tokens informing them that we're breaking the API

Write/Generate the API docs
Find all users with an API token
Email them sending them the new docs

@SylvainChevalier assigning this to you since you're handling / coordinating the "communications" bit around the new metaculus release.

Note to Molly: Sync with luke or hlib about this

https://metaculus.slack.com/archives/C02JGTBC7DJ/p1725373605560949

@hickman-santini this is done, right?

@SylvainChevalier yup although I need to follow up today


'MTCNN' object has no attribute '_MTCNN__session'

Hi all,
I begin with my project about Face detection using MTCNN, I have issue in line:

detector = MTCNN()
Terminal showed as image below

The real error here is "module 'tensorflow' has no attribute 'ConfigProto'" and it is related with the tensorflow version. What version of TF are you using?
Related issues: #47 #56

Thank you @ipazc. I fixed this issue

I have a same problem! My tensorflow's version is 2.0.0 gpu what should i do ?

Thank you @ipazc , i fixed this issue  by  changing to tensorflow version 1.14.0

This is working for version 2.0
https://github.com/instabotai/instabotai/tree/master/mtcnn
I made this 2 months ago so it's not 100% up to date with current build but it works.


Change file class from pyh5md.H5MD_File to pyh5md.File

Change file class from pyh5md.H5MD_File to pyh5md.File. Repeating 'H5MD' serves no purpose.
Impact all using programs but trivial to change.

Moot point after current work that simply subclasses h5py.File.


[NEW CONTENT TYPE REQUEST] Unity resource

What type of file would you like magika to detect?
Unity resource file (.resource)
What software can create/open these files?
Unity Engine, Asset Studio, Asset Ripper.
Where can these files be found?
Any Unity game.
If possible, please provide a specification for this file type.
Additional context

Closing, see https://github.com/google/magika/issues/152 for context. Thanks!


Filename starts with special character breaks the line

Step to reproduce
Enter the command line window by q:, then the error happens:

E5108: Error executing lua ...e/pack/packer/opt/nvim-cokeline/lua/cokeline/buffers.lua:108: malformed pattern (missing ']')
stack traceback:
[C]: in function 'find'
...e/pack/packer/opt/nvim-cokeline/lua/cokeline/buffers.lua:108: in function 'get_pick_letter'
...e/pack/packer/opt/nvim-cokeline/lua/cokeline/buffers.lua:193: in function <...e/pack/packer/opt/nvim-cokeline/lua/cokeline/buffers.lua:168>
vim/shared.lua: in function 'vim_map'
...e/pack/packer/opt/nvim-cokeline/lua/cokeline/buffers.lua:297: in function 'get_valid_buffers'
...e/pack/packer/opt/nvim-cokeline/lua/cokeline/buffers.lua:332: in function 'get_visible_buffers'
...site/pack/packer/opt/nvim-cokeline/lua/cokeline/init.lua:26: in function <...site/pack/packer/opt/nvim-cokeline/lua/cokeline/init.lua:25>

It is because the filename for the command line window is [Command Line], while [ is a special character in lua pattern. Perhaps the filename should be escaped in advance?

Thanks for quick fix 😄


Snowy's Fixes

Basically fixed every issue + added a better, more faithful bed model ;)

DONT MERGE IM MAKIN A BE'ER ONE

Oh, and I fixed bugs that weren't in the Issues page

I realised that the Villager hats are pretty much impossible without modding the game. And if we're going with Optifine, we'll get a crap ton of model work, for example, Zombified Piglins.. oh, I just realised that we need to update the names of items and blocks, Hardened Clay should be Terracota.

Changes
(For the changelog)

Added boat icon

Added Jack o' lantern

Bonemeal no longer looks like white dye

Added zombie pigman

Updated doors to match latest version

Added the various types of fish

Added tripwire hooks

Updated sugar cane to 1.18 version

Updated cocoa texture to 1.19

Fixed boats

Fixed horse's

Fixed horse armour

Fixed Dead bush


Refactor - Deprecate ImageNode width_factor property

The attribute does not seem to be used at all. I've checked the database and there are only a few image nodes having width_factor set to anything else except 100%. All used in a few fairly old stories dating to 2018.

👍


Add route data to reducer action

My route that I am using looks like this:
<Route path="/messages/:id" component={Message} />

In my Message component I have access to this.props.params.id.
In my reducer my action looks like this:
location: {
  action: "POP"
  hash: "#/messages/2?_k=xcl5yg"
  key: "u1jk2m"
  pathname: "/"
  search: ""
  state: null
},
type: "@@router/UPDATE_LOCATION"

So a couple issues I see here.
First, using this relies on my reducer knowing first hand whether the router is using hash or pushState. I shouldn't have to change my reducers if I change how my router is configured.
Second, there is a params object given to my component via the router but not present in the action.
To solve these I think there needs to be an extra route object on the action so it looks like so:
location: {
 action: "POP"
 hash: "#/messages/2?_k=xcl5yg"
 key: "u1jk2m"
 pathname: "/"
 search: ""
 state: null
},
route: {
 path: "/messages/2",
 params: {
   id: 2
 }
},
type: "@@router/UPDATE_LOCATION"

If I am just completely off base on this or using this library wrong then please point me in the right direction. Also I would be more than willing to help out with this, I have experience hacking on routers

Yes please! For us the param is actually also present somewhere else in the state tree so I can get it from there, but it'd seem more natural for the parsed route to exists there, if nothing else than convenience.
Just realized this is only the action and not the state, but both apply, I think.

This sounds sensible.  I was just looking for how to access the url params but cant see where to get them from.  When hitting my app I need to get a route param to work out what data to start fetching.

@rockingskier The param is passed to your navigation component as props, so you can access them there

I have access to this.props.params in the Component but not in mapStateToProps which is where I need to pull some data out of the store based on the URL

You should, props is the second argument to mapStateToProps. Might be better to use mergeProps, though.
https://github.com/rackt/react-redux/blob/master/docs/api.md#connectmapstatetoprops-mapdispatchtoprops-mergeprops-options

facepalm, of course, thanks @SimenB

Yes, you can use mergeProps to get all the data from the router and from redux into your component. However, as it stands (unless I am wrong?) you are pretty much left to fetch your async data in your component.
I would rather my route change, trigger a redux reducer that can fetch the appropriate data based on the route using params, query, etc. and then pass the fetched data to the component.

@jisaacks another option is to write a middleware that listens for the simple router action type and dispatches a subsequent action.

Yes, state.router.params would be very handy.

Unfortunately, this isn't going to be possible within this project. We don't talk to react-router directly, so we have no idea if it interprets a location change as a route change and any sort of router state changes that occur.
You should be getting this directly from react-router via this.props.params along with this.props.location. connecting a component to the state we provide is a bad code pattern that is both dangerous (infinite loops) and potentially non-performant (double-renders on navigation). I highly recommend not doing that and using the built-in stuff that react-router provides.

@timdorr so the recommended way to load data that is specific to a route is in the component (not a reducer)? That feels so anti react and anti redux with no single source of data and one way data flow.
I think infinite loops and double renders would be due to a poor implementation. I don't think it would be impossible to achieve passing the router data to a reducer and let redux pass the data or processed data to the component. It may be very difficult based on how this project currently works without talking to react router.
The package says that this is supposed to let you use the router as documented but I think it is more important, when accessing data to use redux as documented. Since the router's primary goal is responding to routes, and redux's goal is handling the data the app is concerned with.

Loading data from components is super common and, taken to an extreme, is basically what Relay embraces. Ideally you'd even have a way to static analyze what data you need before you render all your components, which is exactly the kind of stuff that react-router enables you to do.
It's possible we may eventually have router params in the state, but we're still ironing out the current technique so we want to make this stable first. It's deceptively tricky to keep this stuff in sync, so it introduces too many places to trip up, we aren't going to do it. There are many other ways to integrate data loading, and now that I think about it, you can't trigger data loading from a reducer anyway, so providing routing params doesn't help.

Thanks @jlongster, for clearing that up. Isn't redux thunk and redux promise for triggering data loading in a reducer? Hmm, I'm not a redux expert so I could be wrong on that.
Also as far as "it's possible we may eventually" how could I get involved in that process?

Redux thunk and promise are for action creators, not reducers

SimenB is correct, those are for action creators, not reducers. You cannot do anything like that in reducers, no side effects at all, which is a critical part of the design.

Also as far as "it's possible we may eventually" how could I get involved in that process?

There isn't really any work going into it right now, so there's not really much to do. You can present a real-life use case that cannot be solved by other data loading patterns, but as it seems you don't understand basic patterns of redux, I suggest you do some research about existing patterns first. You'll realize that you don't need this.

@jisaacks It's not so much a poor implementation as it is a convoluted one.
The infinite loop problem involves 4 separate libraries (redux, react-redux, history/react-router, and this one). When you connect a component to location state and then issue a route action within componentWillRecieveProps, you can trigger it. Who is ultimately responsible for fixing that? It can be any of them, which makes this so tough.
The double render is more of an issue with history. When the history listener fires, react-router issues one setState to update props and if you're connected to location state, you'll get a second setState from react-redux. We can solve that by batching updates in history, but it's not aware of React itself and the batching is limited to react-dom, which would drive us further away from eventual proper react native support.
It's tough stuff that may not even end up in this library. If we can make it work here without workarounds, then we should totally do that. However, doing that will require coordination, new APIs, and, most importantly, a lot of time. :)

Ok took another look at things with fresh eyes, y'all are correct. It is the action creator where I really need the params and I can pass them to it in the component, makes perfect sense. In that case, yes it makes needing the data in a reducer much less necessary. Sorry y'all, thanks for bearing with me.


Mattermost compatibility

Hi,
Not really an "issue", but I don't think this is so far from working with Mattermost as well. Do you think it'd be possible to somehow have a version that satisfies both?
Thanks!
Best,
fred

@madchap If someone provided a pull request to make this plugin compatible with other Slack clones, we'd certainly be willing to merge it.

I'd be glad to see this happen, since alerts fail on mattermost (despite the fact most slack plugins work out of the box with mattermost).
For the record, mattermost return this kind of errors:
 {"id":"web.incoming_webhook.parse.app_error","message":"Unable to parse incoming data","detailed_error":"","request_id":"uh78or6tjpf5uk7m3wgn7hraza","status_code":500,"is_oauth":false}

The payload sent by the plugin is as follows:
{"link_names":"0","channel":"#alerts","text":"*Alert for Graylog stream <https://monitoring.phonealchemist.com:9001/streams/574d9ac4e4b0b8e910e3aeb7/messages?q=*&rangetype=relative&relative=3600|Celery - Succeeded tasks>*:\n> Dummy alert to test notifications","parse":"none","username":"Graylog"}

And the request metadata:
Content-Length: 297
User-Agent: Java/1.8.0_66
Content-Type: application/x-www-form-urlencoded

After messing a bit with the hook, it seems sending a Content-Type: application/json header and removing \n from the payload fix the issue. Since I'm not a Java guy, I really don't feel confident enough to write that code directly in the plugin.

Mattermost compatibility was introduced and verified with ef55ffd207d6c7f26449b092b2867d6de2e49446. I've released 2.2.1 of the plugin. Thanks for your help guys!


Docker CLI not starting or starts random

Expected behavior
"DOCKER CLI" button in left corner  in Kitematic should start Docker cli.
Actual behavior
It starts randomly
Information about the Issue
I am on Mac OS X El Capitan
Steps to reproduce the behavior
1Buy a Mac with El Captian ;)

and so on. ... start Kitematic

When you say it starts randomly, do you mean that no window appears, or that executing a docker ps doesn't work?

The actual window. I noticed this is a very random thing, sometimes I just wait and then it will appear with as many windows as I have pressed the "DOCKER CLI" button. It is very hard to tell what is exactly happening, I will just have to restart to make it work again if it will not come after some time. I will reformat my mac and see if it helps, have to do it anyways.

let me know if that helps - It always comes up for me without any issue.

To be clear, on Windows 10, Docker Cli open Powershell but do load modules.
I obtain the same problem without create container and just to click on docker cli. It open Powershell but without docker extension loaded.  See image attached.

If i use Windows powershell provided by Windows 10, i have no problem to execute docker command. Really strange.

I'm not sure if I understand this:
The problem is only when i use the button docker cli after call kinematic by docker services (Not toolbox). If i call directly kinematic, i don't have the problem.

Qu'est-ce que tu veux dire? Tu cliques sur quoi?

Closing this issue due to lack of update/activity - Feel free to re-open if appropriate.

what is the solution? i cannot open docker cli from kitematic.
use the latest docker ce for mac and the latest kitematic.


Margin OCO API implementation

Thanks @alekseiko the endpoints had been implemented, but I'll include the enum values.


Corrupt radial gradient on Apple Silicon

I've encountered a strange bug when rendering an svg with certain focal point values.
Strangely enough, the rendering is correct on Intel x64 (mac/PC) and the online ThorVG viewer,
but Apple Silicon / ARM show weird horizontal lines instead of the expected gradient.
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="800" height="590" version="1.1" id="svg13" xmlns="http://www.w3.org/2000/svg"
   xmlns:svg="http://www.w3.org/2000/svg">
   <defs>
      <radialGradient cx="429" cy="3" fx="429" fy="-600" gradientUnits="userSpaceOnUse" id="b" r="600">
         <stop offset="0" stop-color="red" id="stop10" />
         <stop offset="1" stop-color="white" id="stop11" />
      </radialGradient>
   </defs>

   <path d="M 800,200 H 0 V 590 H 800 V 0 Z" fill="url(#b)" id="svg_4" />
</svg>

Note that if fx is changed to 600, then there are no artefacts anymore.
This is using latest ThorVG 0.12.6, XCode 15.2 and macos Sonoma 14.3.1.
ThorVG viewer:

Test application | x64:

Test application | Apple Silicon:

@lmdsp could you please try after this slight change?
https://github.com/thorvg/thorvg/pull/2018
this is a random guess since for now I'm able to test on apple silicon.
Also could you please test what will happen if you change fy="-600" to fy="-597" ?

@mgrudzinska Thanks for looking into this.
Changing from fy="-600" to fy="-597" doesn't change anything.
Changing line 207 from if (fill->radial.a > 0); to if (fill->radial.a > RADIAL_A_THRESHOLD); doesn't fix the problem either I'm afraid.
Perhaps a hint; those are the contents before and after executing the instructions at line 198
 //This condition fulfills the SVG 1.1 std:
 //the focal point, if outside the end circle, is moved to be on the end circle
 //See: the SVG 2 std requirements: https://www.w3.org/TR/SVG2/pservers.html#RadialGradientNotes
 if (fill->radial.a < 0) {

(lldb) p fill->radial
(SwFill::SwRadial)  (a11 = 0, a12 = 0, a13 = 0, a21 = 0, a22 = 0, a23 = 0, fx = 429, fy = -600, fr = 0, dx = 0, dy = 603, dr = 599.999939, invA = 0, a = -3609.0625)

(lldb) p fill->radial
(SwFill::SwRadial)  (a11 = 0, a12 = 0, a13 = 0, a21 = 0, a22 = 0, a23 = 0, fx = 429, fy = -596.999939, fr = 0, dx = 0, dy = 599.999939, dr = 599.999939, invA = 0, a = 0.0107421838)

So it turns out in this case fill->radial.a = fill->radial.dr * fill->radial.dr - fill->radial.dx * fill->radial.dx - fill->radial.dy * fill->radial.dy; at line 204 evaluates to 0 on Intel, but to 0.0107421838 on Apple Silicon !
The correct result is indeed 0 as a=dr²-dx²-dy² with dx=0, dr=dy=599.999939
It seems clang is doing some instruction reordering / FMA which is causing loss of precision.
This happens in both release/debug builds, with options such as GCC_FAST_MATH set to off.
I found that storing intermediary results in temporary variables as shown below fixes the problem:
// Prevent loss of precision on Apple Silicon when dr=dy and dx=0
// https://github.com/thorvg/thorvg/issues/2014
const float dr2 = fill->radial.dr * fill->radial.dr;
const float dx2 = fill->radial.dx * fill->radial.dx;
const float dy2 = fill->radial.dy * fill->radial.dy;

fill->radial.a = dr2 - dx2 - dy2;

@mgrudzinska Do you want me to submit a PR ?

@lmdsp ThorVG welcomes contributors! If you have solutions or improvements, please don't hesitate to submit patches. Thank you for your support!

@lmdsp Your fix will be applied in 0.12.7. Thanks for your contribution


fleetctl status needs  SSH_AUTH_SOCK

Hi,
i try to use fleetctl from inside a rkt container, to made this work i bind mount the fleet.sock.
I can successfully run fleetctl list-machines and list-units
When i try to run fleetctl status <some_unit> i got this error

Error running remote command: SSH_AUTH_SOCK environment variable is not set. Verify ssh-agent is running. See https://github.com/coreos/fleet/blob/master/Documentation/using-the-client.md for help.

is this expected ?
regards f0

fleetctl status uses ssh under the hood so it will need access to run successfully..

@jonboulle ok thx, then we use the api


xrdp can't be built with openssl3

It is failed to build xrdp with openssl3. The error message is as the following:
| ../../git/common/ssl_calls.c: In function 'ssl_rc4_set_key':
| ../../git/common/ssl_calls.c:145:5: error: 'RC4_set_key' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   145 |     RC4_set_key((RC4_KEY *)rc4_info, len, (tui8 *)key);
|       |     ^~~~~~~~~~~
| In file included from ../../git/common/ssl_calls.c:29:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/rc4.h:35:28: note: declared here
|    35 | OSSL_DEPRECATEDIN_3_0 void RC4_set_key(RC4_KEY *key, int len,
|       |                            ^~~~~~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_rc4_crypt':
| ../../git/common/ssl_calls.c:152:5: error: 'RC4' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   152 |     RC4((RC4_KEY *)rc4_info, len, (tui8 *)data, (tui8 *)data);
|       |     ^~~
| In file included from ../../git/common/ssl_calls.c:29:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/rc4.h:37:28: note: declared here
|    37 | OSSL_DEPRECATEDIN_3_0 void RC4(RC4_KEY *key, size_t len,
|       |                            ^~~
| ../../git/common/ssl_calls.c: In function 'ssl_sha1_clear':
| ../../git/common/ssl_calls.c:175:5: error: 'SHA1_Init' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   175 |     SHA1_Init((SHA_CTX *)sha1_info);
|       |     ^~~~~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/x509.h:41,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:31,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/sha.h:49:27: note: declared here
|    49 | OSSL_DEPRECATEDIN_3_0 int SHA1_Init(SHA_CTX *c);
|       |                           ^~~~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_sha1_transform':
| ../../git/common/ssl_calls.c:182:5: error: 'SHA1_Update' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   182 |     SHA1_Update((SHA_CTX *)sha1_info, data, len);
|       |     ^~~~~~~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/x509.h:41,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:31,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/sha.h:50:27: note: declared here
|    50 | OSSL_DEPRECATEDIN_3_0 int SHA1_Update(SHA_CTX *c, const void *data, size_t len);
|       |                           ^~~~~~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_sha1_complete':
| ../../git/common/ssl_calls.c:189:5: error: 'SHA1_Final' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   189 |     SHA1_Final((tui8 *)data, (SHA_CTX *)sha1_info);
|       |     ^~~~~~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/x509.h:41,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:31,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/sha.h:51:27: note: declared here
|    51 | OSSL_DEPRECATEDIN_3_0 int SHA1_Final(unsigned char *md, SHA_CTX *c);
|       |                           ^~~~~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_md5_clear':
| ../../git/common/ssl_calls.c:212:5: error: 'MD5_Init' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   212 |     MD5_Init((MD5_CTX *)md5_info);
|       |     ^~~~~~~~
| In file included from ../../git/common/ssl_calls.c:30:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/md5.h:49:27: note: declared here
|    49 | OSSL_DEPRECATEDIN_3_0 int MD5_Init(MD5_CTX *c);
|       |                           ^~~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_md5_transform':
| ../../git/common/ssl_calls.c:219:5: error: 'MD5_Update' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   219 |     MD5_Update((MD5_CTX *)md5_info, data, len);
|       |     ^~~~~~~~~~
| In file included from ../../git/common/ssl_calls.c:30:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/md5.h:50:27: note: declared here
|    50 | OSSL_DEPRECATEDIN_3_0 int MD5_Update(MD5_CTX *c, const void *data, size_t len);
|       |                           ^~~~~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_md5_complete':
| ../../git/common/ssl_calls.c:226:5: error: 'MD5_Final' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   226 |     MD5_Final((tui8 *)data, (MD5_CTX *)md5_info);
|       |     ^~~~~~~~~
| In file included from ../../git/common/ssl_calls.c:30:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/md5.h:51:27: note: declared here
|    51 | OSSL_DEPRECATEDIN_3_0 int MD5_Final(unsigned char *md, MD5_CTX *c);
|       |                           ^~~~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_hmac_info_create':
| ../../git/common/ssl_calls.c:316:5: error: 'HMAC_CTX_new' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   316 |     hmac_ctx = HMAC_CTX_new();
|       |     ^~~~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:37,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/hmac.h:33:33: note: declared here
|    33 | OSSL_DEPRECATEDIN_3_0 HMAC_CTX *HMAC_CTX_new(void);
|       |                                 ^~~~~~~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_hmac_info_delete':
| ../../git/common/ssl_calls.c:329:9: error: 'HMAC_CTX_free' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   329 |         HMAC_CTX_free(hmac_ctx);
|       |         ^~~~~~~~~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:37,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/hmac.h:35:28: note: declared here
|    35 | OSSL_DEPRECATEDIN_3_0 void HMAC_CTX_free(HMAC_CTX *ctx);
|       |                            ^~~~~~~~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_hmac_sha1_init':
| ../../git/common/ssl_calls.c:340:5: error: 'HMAC_Init_ex' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   340 |     HMAC_Init_ex(hmac_ctx, data, len, EVP_sha1(), NULL);
|       |     ^~~~~~~~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:37,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/hmac.h:43:27: note: declared here
|    43 | OSSL_DEPRECATEDIN_3_0 int HMAC_Init_ex(HMAC_CTX *ctx, const void *key, int len,
|       |                           ^~~~~~~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_hmac_transform':
| ../../git/common/ssl_calls.c:352:5: error: 'HMAC_Update' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   352 |     HMAC_Update(hmac_ctx, ldata, len);
|       |     ^~~~~~~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:37,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/hmac.h:45:27: note: declared here
|    45 | OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data,
|       |                           ^~~~~~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_hmac_complete':
| ../../git/common/ssl_calls.c:366:5: error: 'HMAC_Final' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   366 |     HMAC_Final(hmac_ctx, ldata, &llen);
|       |     ^~~~~~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:37,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/hmac.h:47:27: note: declared here
|    47 | OSSL_DEPRECATEDIN_3_0 int HMAC_Final(HMAC_CTX *ctx, unsigned char *md,
|       |                           ^~~~~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_gen_key_xrdp1':
| ../../git/common/ssl_calls.c:480:5: error: 'RSA_new' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   480 |     my_key = RSA_new();
|       |     ^~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/x509.h:36,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:31,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/rsa.h:201:28: note: declared here
|   201 | OSSL_DEPRECATEDIN_3_0 RSA *RSA_new(void);
|       |                            ^~~~~~~
| ../../git/common/ssl_calls.c:481:5: error: 'RSA_generate_key_ex' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   481 |     error = RSA_generate_key_ex(my_key, key_size_in_bits, my_e, 0) == 0;
|       |     ^~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/x509.h:36,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:31,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/rsa.h:260:27: note: declared here
|   260 | OSSL_DEPRECATEDIN_3_0 int RSA_generate_key_ex(RSA *rsa, int bits, BIGNUM *e,
|       |                           ^~~~~~~~~~~~~~~~~~~
| ../../git/common/ssl_calls.c:485:5: error: 'RSA_get0_key' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   485 |     RSA_get0_key(my_key, &n, NULL, &d);
|       |     ^~~~~~~~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/x509.h:36,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:31,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/rsa.h:217:28: note: declared here
|   217 | OSSL_DEPRECATEDIN_3_0 void RSA_get0_key(const RSA *r,
|       |                            ^~~~~~~~~~~~
| ../../git/common/ssl_calls.c:520:5: error: 'RSA_free' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   520 |     RSA_free(my_key);
|       |     ^~~~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/x509.h:36,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:31,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/rsa.h:293:28: note: declared here
|   293 | OSSL_DEPRECATEDIN_3_0 void RSA_free(RSA *r);
|       |                            ^~~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_get_dh2236':
| ../../git/common/ssl_calls.c:567:5: error: 'DH_new' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   567 |     DH *dh = DH_new();
|       |     ^~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/dsa.h:51,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/x509.h:37,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:31,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/dh.h:199:27: note: declared here
|   199 | OSSL_DEPRECATEDIN_3_0 DH *DH_new(void);
|       |                           ^~~~~~
| ../../git/common/ssl_calls.c:579:9: error: 'DH_free' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   579 |         DH_free(dh);
|       |         ^~~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/dsa.h:51,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/x509.h:37,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:31,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/dh.h:200:28: note: declared here
|   200 | OSSL_DEPRECATEDIN_3_0 void DH_free(DH *dh);
|       |                            ^~~~~~~
| ../../git/common/ssl_calls.c:584:5: error: 'DH_set0_pqg' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   584 |     if (0 == DH_set0_pqg(dh, p, NULL, g))
|       |     ^~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/dsa.h:51,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/x509.h:37,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:31,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/dh.h:255:27: note: declared here
|   255 | OSSL_DEPRECATEDIN_3_0 int DH_set0_pqg(DH *dh, BIGNUM *p, BIGNUM *q, BIGNUM *g);
|       |                           ^~~~~~~~~~~
| ../../git/common/ssl_calls.c:588:9: error: 'DH_free' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   588 |         DH_free(dh);
|       |         ^~~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/dsa.h:51,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/x509.h:37,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:31,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/dh.h:200:28: note: declared here
|   200 | OSSL_DEPRECATEDIN_3_0 void DH_free(DH *dh);
|       |                            ^~~~~~~
| ../../git/common/ssl_calls.c: In function 'ssl_tls_accept':
| ../../git/common/ssl_calls.c:768:5: error: 'DH_free' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
|   768 |     DH_free(dh); // ok to free, copied into ctx by SSL_CTX_set_tmp_dh()
|       |     ^~~~~~~
| In file included from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/dsa.h:51,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/x509.h:37,
|                  from /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/ssl.h:31,
|                  from ../../git/common/ssl_calls.c:27:
| /ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/recipe-sysroot/usr/include/openssl/dh.h:200:28: note: declared here
|   200 | OSSL_DEPRECATEDIN_3_0 void DH_free(DH *dh);
|       |                            ^~~~~~~
| cc1: all warnings being treated as errors
| make[2]: *** [Makefile:559: ssl_calls.lo] Error 1
| make[2]: *** Waiting for unfinished jobs....
| make[2]: Leaving directory '/ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/build/common'
| make[1]: Leaving directory '/ubinux-dev/ubinux003/ubinux/ubinux202202/build-ubinux-armv8-daily/tmp/work/aarch64-ubinux-linux/xrdp/0.9.18-r0/build'
| make[1]: *** [Makefile:472: all-recursive] Error 1
| make: *** [Makefile:404: all] Error 2

Thanks for reporting, this issue needs to be addressed.

Although we still need these ciphers and hashes to provide standard RDP security (see this table) it should be possible to re-implement the calls using higher-level calls. See the openssl migration guide
The provider concept mentioned in the migration guide was introduced subsequent to OpenSSL 1.1.1. Our two oldest Enterprise platforms, RHEL 7 (up 'til Jun 2024) and Ubuntu 16.04 LTS (up 'til April 2026) ship with releases from the 1.0.2 series. RHEL 8 (up 'til 2029) ships with 1.1.1.
I haven't looked looked into the details yet, but we'll clearly need to support both types of call for some time.
There's a relatively simple workaround; Fedora already ships with openssl 3, and addresses this by building with -Wno-error=deprecated-declarations. Fedora rawhide RPM spec file is here
@leimaohui - is this workaround good enough for you at the moment?
@metalefty - I think you can remove the bug blocker label from this, as Fedora already has OpenSSL 3.

@matt335672 Thanks very much. By your suggestion, this error message has gone.

I'm re-opening this, as it needs to be addressed anyway so the workaround isn't required.


Use -deststoretype pkcs12 to remove warning

Motivation:
When I follow https://armeria.dev/docs/advanced-saml/#configuring-your-server-as-a-service-provider, it shows following warnings which suggest to specify -deststoretype pkcs12.
JKSキーストアは独自の形式を使用しています。"keytool -importkeystore -srckeystore a.jks -destkeystore a.jks -deststoretype pkcs12"を使用する業界標準の形式であるPKCS12に移行することをお薦めします。

Modifications:

Add -deststoretype pkcs12 option to example

Result:

Less warns at example

I cannot remember how we sync between this repo and https://github.com/line/armeria-examples but... is it ok to put PR to here? or need to send to https://github.com/line/armeria-examples instead?

I cannot remember how we sync between this repo and line/armeria-examples but... is it ok to put PR to here? or need to send to line/armeria-examples instead?

You don't need to do anything. 😉
The repository is updated when we release a new version. 😉

For reference: https://www.baeldung.com/java-keystore-truststore-difference