Small dbxref formatting bugs in mpo.obo?

I'm looking at the mpo.obo file with data-version: releases/2017-06-05.
The following diff shows dbxref entries that might be incorrect. What do you think?
--- /home/mholtgre/Downloads/mp.obo.bak	2017-06-19 15:38:23.827044779 +0200
+++ /home/mholtgre/Downloads/mp.obo	2017-06-19 15:42:51.657771048 +0200
@@ -47080,7 +47080,7 @@
 [Term]
 id: MP:0008284
 name: abnormal hippocampus pyramidal cell layer
-def: "any structural anomaly of the cytoarchitectural term denoting the layer of the hippocampus in which pyramidal cells are predominant. Its location is superficial to the Stratum oriens; it is deep to the Stratum radiatum in area CA1 and area CA2 and deep to the Stratum lucidum in area CA3" [ISSN: 0073-0114, UBERON_0002313]
+def: "any structural anomaly of the cytoarchitectural term denoting the layer of the hippocampus in which pyramidal cells are predominant. Its location is superficial to the Stratum oriens; it is deep to the Stratum radiatum in area CA1 and area CA2 and deep to the Stratum lucidum in area CA3" [ISSN:0073-0114, UBERON:0002313]
 subset: IMPC
 subset: Sanger_Terms
 synonym: "abnormal stratum pyramidale morphology" EXACT []
@@ -47095,7 +47095,7 @@
 [Term]
 id: MP:0008286
 name: abnormal hippocampus molecular cell layer
-def: "any structural anomaly of the cytoarchitectural region of the hippocampus consisting of a composite of the two outermost layers of the hippocampus, the Stratum lacunosum-moleculare and the Stratum radiatum" [ISBN 13:<PHONE_NUMBER>617, UBERON_0005368]
+def: "any structural anomaly of the cytoarchitectural region of the hippocampus consisting of a composite of the two outermost layers of the hippocampus, the Stratum lacunosum-moleculare and the Stratum radiatum" [ISBN13:9780683014617, UBERON:0005368]
 synonym: "abnormal stratum moleculare morphology" EXACT []
 is_a: MP:0000813 ! abnormal hippocampus layer morphology

@@ -74640,7 +74640,7 @@
 [Term]
 id: MP:0011150
 name: abnormal hippocampus stratum oriens morphology
-def: "any structural anomaly of the layer that is part of the CA fields of the hippocampus consisting of a narrow relatively cell free layer located deep to the pyramidal cell layer extending through areas CA1, CA2 and CA3" [NIFSTD:birnlex_4113, UBERON_0005371]
+def: "any structural anomaly of the layer that is part of the CA fields of the hippocampus consisting of a narrow relatively cell free layer located deep to the pyramidal cell layer extending through areas CA1, CA2 and CA3" [NIFSTD:birnlex_4113, UBERON:0005371]
 subset: IMPC
 subset: Sanger_Terms
 is_a: MP:0000813 ! abnormal hippocampus layer morphology
@@ -74650,7 +74650,7 @@
 [Term]
 id: MP:0011151
 name: abnormal hippocampus stratum radiatum morphology
-def: "any structural anomaly of the layer located immediately above the pyramidal cell layer in CA2 and CA1 and superficial to the stratum lucidum in CA3. Suprapyramidal region in which CA3 to CA3 associational connections and CA3 to CA1 Schaffer collateral connections are located" [NIFSTD:birnlex_1298, UBERON_0005372]
+def: "any structural anomaly of the layer located immediately above the pyramidal cell layer in CA2 and CA1 and superficial to the stratum lucidum in CA3. Suprapyramidal region in which CA3 to CA3 associational connections and CA3 to CA1 Schaffer collateral connections are located" [NIFSTD:birnlex_1298, UBERON:0005372]
 subset: IMPC
 subset: Sanger_Terms
 is_a: MP:0000813 ! abnormal hippocampus layer morphology
@@ -74660,7 +74660,7 @@
 [Term]
 id: MP:0011152
 name: thick hippocampus molecular cell layer
-def: "increase in the width of the cytoarchitectural region of the hippocampus consisting of a composite of the two outermost layers of the hippocampus, the Stratum lacunosum-moleculare and the Stratum radiatum" [UBERON_0005368]
+def: "increase in the width of the cytoarchitectural region of the hippocampus consisting of a composite of the two outermost layers of the hippocampus, the Stratum lacunosum-moleculare and the Stratum radiatum" [UBERON:0005368]
 synonym: "thick stratum moleculare " EXACT []
 is_a: MP:0008286 ! abnormal hippocampus molecular cell layer
 created_by: csmith
@@ -74669,7 +74669,7 @@
 [Term]
 id: MP:0011153
 name: thick hippocampus stratum oriens
-def: "increase in the width of the layer that is part of the CA fields of the hippocampus consisting of a narrow relatively cell free layer located deep to the pyramidal cell layer extending through areas CA1, CA2 and CA3" [NIFSTD:birnlex_4113, UBERON_0005371]
+def: "increase in the width of the layer that is part of the CA fields of the hippocampus consisting of a narrow relatively cell free layer located deep to the pyramidal cell layer extending through areas CA1, CA2 and CA3" [NIFSTD:birnlex_4113, UBERON:0005371]
 subset: IMPC
 subset: Sanger_Terms
 is_a: MP:0011150 ! abnormal hippocampus stratum oriens morphology
@@ -74679,7 +74679,7 @@
 [Term]
 id: MP:0011154
 name: thick hippocampus stratum radiatum
-def: "increase in the width of the layer located immediately above the pyramidal cell layer in CA2 and CA1 and superficial to the stratum lucidum in CA3" [NIFSTD:birnlex_1298, UBERON_0005372]
+def: "increase in the width of the layer located immediately above the pyramidal cell layer in CA2 and CA1 and superficial to the stratum lucidum in CA3" [NIFSTD:birnlex_1298, UBERON:0005372]
 subset: IMPC
 subset: Sanger_Terms
 is_a: MP:0011151 ! abnormal hippocampus stratum radiatum morphology
@@ -74689,7 +74689,7 @@
 [Term]
 id: MP:0011155
 name: absent hippocampus stratum oriens
-def: "absence of the layer that is part of the CA fields of the hippocampus consisting of a narrow relatively cell free layer located deep to the pyramidal cell layer extending through areas CA1, CA2 and CA3" [NIFSTD:birnlex_4113, UBERON_0005371]
+def: "absence of the layer that is part of the CA fields of the hippocampus consisting of a narrow relatively cell free layer located deep to the pyramidal cell layer extending through areas CA1, CA2 and CA3" [NIFSTD:birnlex_4113, UBERON:0005371]
 subset: IMPC
 subset: Sanger_Terms
 is_a: MP:0011150 ! abnormal hippocampus stratum oriens morphology
@@ -87647,7 +87647,7 @@
 [Term]
 id: MP:0012444
 name: thin hippocampus molecular cell layer
-def: "decrease in the width of the cytoarchitectural region of the hippocampus consisting of a composite of the two outermost layers of the hippocampus, the Stratum lacunosum-moleculare and the Stratum radiatum" [UBERON_0005368]
+def: "decrease in the width of the cytoarchitectural region of the hippocampus consisting of a composite of the two outermost layers of the hippocampus, the Stratum lacunosum-moleculare and the Stratum radiatum" [UBERON:0005368]
 subset: IMPC
 subset: Sanger_Terms
 synonym: "thin stratum moleculare " EXACT []
@@ -87658,7 +87658,7 @@
 [Term]
 id: MP:0012445
 name: thin hippocampus stratum radiatum
-def: "decrease in the width of the layer located immediately above the pyramidal cell layer in CA2 and CA1 and superficial to the stratum lucidum in CA3" [NIFSTD:birnlex_1298, UBERON_0005372]
+def: "decrease in the width of the layer located immediately above the pyramidal cell layer in CA2 and CA1 and superficial to the stratum lucidum in CA3" [NIFSTD:birnlex_1298, UBERON:0005372]
 subset: IMPC
 subset: Sanger_Terms
 is_a: MP:0011151 ! abnormal hippocampus stratum radiatum morphology
@@ -87668,7 +87668,7 @@
 [Term]
 id: MP:0012446
 name: thin hippocampus stratum oriens
-def: "decrease in the width of the layer that is part of the CA fields of the hippocampus consisting of a narrow relatively cell free layer located deep to the pyramidal cell layer extending through areas CA1, CA2 and CA3" [NIFSTD:birnlex_4113, UBERON_0005371]
+def: "decrease in the width of the layer that is part of the CA fields of the hippocampus consisting of a narrow relatively cell free layer located deep to the pyramidal cell layer extending through areas CA1, CA2 and CA3" [NIFSTD:birnlex_4113, UBERON:0005371]
 subset: IMPC
 subset: Sanger_Terms
 is_a: MP:0011150 ! abnormal hippocampus stratum oriens morphology
@@ -101503,19 +101503,19 @@
 [Term]
 id: MP:0020038
 name: retinal macular degeneration
-def: "retrogressive pathological change of the macula lutea" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "retrogressive pathological change of the macula lutea" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0001326 ! retinal degeneration

 [Term]
 id: MP:0020039
 name: increased bone ossification
-def: "increase  in the formation of bone or of a bony substance, or the conversion of fibrous tissue or of cartilage into bone or a bony substance" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "increase  in the formation of bone or of a bony substance, or the conversion of fibrous tissue or of cartilage into bone or a bony substance" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0008271 ! abnormal bone ossification

 [Term]
 id: MP:0020040
 name: decreased bone ossification
-def: "decrease in the formation of bone or of a bony substance, or the conversion of fibrous tissue or of cartilage into bone or a bony substance" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "decrease in the formation of bone or of a bony substance, or the conversion of fibrous tissue or of cartilage into bone or a bony substance" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0008271 ! abnormal bone ossification

 [Term]
@@ -101849,7 +101849,7 @@
 [Term]
 id: MP:0020080
 name: increased bone mineralization
-def: "increase in the rate at which minerals are deposited into bone" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "increase in the rate at which minerals are deposited into bone" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0002896 ! abnormal bone mineralization

 [Term]
@@ -102324,7 +102324,7 @@
 [Term]
 id: MP:0020138
 name: delayed bone mineralization
-def: "late onset of the process by which minerals are deposited into bone" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "late onset of the process by which minerals are deposited into bone" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0002896 ! abnormal bone mineralization

 [Term]
@@ -102338,13 +102338,13 @@
 [Term]
 id: MP:0020140
 name: increased brain external capsule size
-def: "larger than the normal physical proportions of the series of white matter fiber tracts in the brain that run between the most lateral segment of the lentiform nucleus and the claustrum" [ORCID: orcid.org/0000-0003-4606-0597, PMID:24997765]
+def: "larger than the normal physical proportions of the series of white matter fiber tracts in the brain that run between the most lateral segment of the lentiform nucleus and the claustrum" [ORCID:orcid.org/0000-0003-4606-0597, PMID:24997765]
 is_a: MP:0020139 ! abnormal brain external capsule morphology

 [Term]
 id: MP:0020141
 name: decreased brain external capsule size
-def: "smaller than the normal physical proportions of the series of white matter fiber tracts in the brain that run between the most lateral segment of the lentiform nucleus and the claustrum" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "smaller than the normal physical proportions of the series of white matter fiber tracts in the brain that run between the most lateral segment of the lentiform nucleus and the claustrum" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0020139 ! abnormal brain external capsule morphology

 [Term]
@@ -102387,7 +102387,7 @@
 [Term]
 id: MP:0020146
 name: abnormal vascular endothelial cell proliferation
-def: "anomaly in the ability of the cells that line the vasculature to undergo expansion by cell division" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "anomaly in the ability of the cells that line the vasculature to undergo expansion by cell division" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0000350 ! abnormal cell proliferation
 is_a: MP:0004003 ! abnormal vascular endothelial cell physiology

@@ -102509,7 +102509,7 @@
 [Term]
 id: MP:0020161
 name: increased vascular endothelial cell proliferation
-def: "increase in the expansion rate of any vascular endothelial cell population by cell division" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "increase in the expansion rate of any vascular endothelial cell population by cell division" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0020146 ! abnormal vascular endothelial cell proliferation

 [Term]
@@ -104016,57 +104016,57 @@
 [Term]
 id: MP:0020316
 name: decreased vascular endothelial cell proliferation
-def: "decrease in the expansion rate of any vascular endothelial cell population by cell division" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "decrease in the expansion rate of any vascular endothelial cell population by cell division" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0020146 ! abnormal vascular endothelial cell proliferation

 [Term]
 id: MP:0020317
 name: abnormal vascular endothelial cell adhesion
-def: "altered ability of an endothelial cell in the vasculature to adhere to another cell or to a non-cellular component of the environment" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "altered ability of an endothelial cell in the vasculature to adhere to another cell or to a non-cellular component of the environment" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0003566 ! abnormal cell adhesion
 is_a: MP:0004003 ! abnormal vascular endothelial cell physiology

 [Term]
 id: MP:0020318
 name: increased vascular endothelial cell adhesion
-def: "greater than expected ability of an endothelial cell in the vasculature to adhere to another cell or to a non-cellular component of the environment" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "greater than expected ability of an endothelial cell in the vasculature to adhere to another cell or to a non-cellular component of the environment" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0020317 ! abnormal vascular endothelial cell adhesion

 [Term]
 id: MP:0020319
 name: decreased vascular endothelial cell adhesion
-def: "less than expected ability of an endothelial cell in the vasculature to adhere to another cell or to a non-cellular component of the environment" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "less than expected ability of an endothelial cell in the vasculature to adhere to another cell or to a non-cellular component of the environment" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0020317 ! abnormal vascular endothelial cell adhesion

 [Term]
 id: MP:0020320
 name: abnormal vascular endothelial cell apoptosis
-def: "change in the timing or the number of vascular endothelial cells undergoing programmed cell death" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "change in the timing or the number of vascular endothelial cells undergoing programmed cell death" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0001648 ! abnormal apoptosis
 is_a: MP:0004003 ! abnormal vascular endothelial cell physiology

 [Term]
 id: MP:0020321
 name: increased vascular endothelial cell apoptosis
-def: "increase in the timing or the number of vascular endothelial cells undergoing programmed cell death" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "increase in the timing or the number of vascular endothelial cells undergoing programmed cell death" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0020320 ! abnormal vascular endothelial cell apoptosis

 [Term]
 id: MP:0020322
 name: decreased vascular endothelial cell apoptosis
-def: "decrease in the timing or the number of vascular endothelial cells undergoing programmed cell death" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "decrease in the timing or the number of vascular endothelial cells undergoing programmed cell death" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0020320 ! abnormal vascular endothelial cell apoptosis

 [Term]
 id: MP:0020323
 name: abnormal heart apex size
-def: "any anomaly in the proportions  of the lowest superficial part of the heart, normally directed downward, forward, and to the left, and overlapped by the left lung and pleura; the heart apex is formed by the inferolateral part of the left ventricle and responsible for regulating ventricle contraction" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "any anomaly in the proportions  of the lowest superficial part of the heart, normally directed downward, forward, and to the left, and overlapped by the left lung and pleura; the heart apex is formed by the inferolateral part of the left ventricle and responsible for regulating ventricle contraction" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0012515 ! abnormal heart apex morphology

 [Term]
 id: MP:0020324
 name: jejunum polyps
-def: "development of numerous growths that are connected to and protrude from the mucous membrane of the jejunum" [ORCID: orcid.org/0000-0003-4606-0597, PMID:25578479]
+def: "development of numerous growths that are connected to and protrude from the mucous membrane of the jejunum" [ORCID:orcid.org/0000-0003-4606-0597, PMID:25578479]
 synonym: "jejunal polyposis" EXACT []
 synonym: "jejunal polyps" EXACT []
 synonym: "jejunum polyposis" EXACT []
@@ -104076,7 +104076,7 @@
 [Term]
 id: MP:0020325
 name: abnormal beige fat cell morphology
-def: "any structural anomaly of fat cells that are beige in color, thermogenic, and which differentiates in white fat tissue from a Myf5-negative progenitor" [CL_0001070, ORCID: orcid.org/0000-0003-4606-0597, PMID:22796012, PMID:23603813, PMID:24575370]
+def: "any structural anomaly of fat cells that are beige in color, thermogenic, and which differentiates in white fat tissue from a Myf5-negative progenitor" [CL_0001070, ORCID:orcid.org/0000-0003-4606-0597, PMID:22796012, PMID:23603813, PMID:24575370]
 synonym: "abnormal beige adipocyte morphology" EXACT []
 synonym: "abnormal beige brown adipocyte morphology" EXACT []
 synonym: "abnormal brite adipocyte morphology" EXACT []
@@ -104087,100 +104087,100 @@
 [Term]
 id: MP:0020326
 name: dilated capillary
-def: "stretched or widened aperture of the luminal space of the small branching blood vessel that form a network between the arterioles and venules" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "stretched or widened aperture of the luminal space of the small branching blood vessel that form a network between the arterioles and venules" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0003658 ! abnormal capillary morphology
 is_a: MP:0004938 ! dilated vasculature

 [Term]
 id: MP:0020327
 name: abnormal capillary branching pattern
-def: "any changes in the placement, morphology or number of divisions of the capillaries" [ORCID: orcid.org/0000-0003-4606-0597, PMID:14713950]
+def: "any changes in the placement, morphology or number of divisions of the capillaries" [ORCID:orcid.org/0000-0003-4606-0597, PMID:14713950]
 is_a: MP:0003658 ! abnormal capillary morphology

 [Term]
 id: MP:0020328
 name: abnormal capillary density
-def: "any anomaly in the number of capillaries in a given cross-sectional area of a tissue" [ORCID: orcid.org/0000-0003-4606-0597, PMID:20944627]
+def: "any anomaly in the number of capillaries in a given cross-sectional area of a tissue" [ORCID:orcid.org/0000-0003-4606-0597, PMID:20944627]
 is_a: MP:0003658 ! abnormal capillary morphology

 [Term]
 id: MP:0020329
 name: decreased capillary density
-def: "reduction in the number of capillaries in a given cross-sectional area of a tissue" [ORCID: orcid.org/0000-0003-4606-0597, PMID:20944627]
+def: "reduction in the number of capillaries in a given cross-sectional area of a tissue" [ORCID:orcid.org/0000-0003-4606-0597, PMID:20944627]
 is_a: MP:0020328 ! abnormal capillary density

 [Term]
 id: MP:0020330
 name: increased capillary density
-def: "increase in the number of capillaries in a given cross-sectional area of a tissue" [ORCID: orcid.org/0000-0003-4606-0597, PMID:20705734]
+def: "increase in the number of capillaries in a given cross-sectional area of a tissue" [ORCID:orcid.org/0000-0003-4606-0597, PMID:20705734]
 is_a: MP:0020328 ! abnormal capillary density

 [Term]
 id: MP:0020331
 name: increased capillary tortuosity
-def: "increase in the degree of twisting of capillaries" [ORCID: orcid.org/0000-0003-4606-0597, PMCID:PMC3369246]
+def: "increase in the degree of twisting of capillaries" [ORCID:orcid.org/0000-0003-4606-0597, PMCID:PMC3369246]
 synonym: "'tortuous capillaries'" EXACT []
 is_a: MP:0003658 ! abnormal capillary morphology

 [Term]
 id: MP:0020332
 name: impaired leukocyte tethering or rolling
-def: "reduced ability or inability  in the transient adhesive interactions between leukocytes and endothelial cells lining blood vessels mediated primarily by selectins and which are typically the first step in cellular extravasation" [GO:0050901, ORCID: orcid.org/0000-0003-4606-0597]
+def: "reduced ability or inability  in the transient adhesive interactions between leukocytes and endothelial cells lining blood vessels mediated primarily by selectins and which are typically the first step in cellular extravasation" [GO:0050901, ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0003627 ! abnormal leukocyte tethering or rolling

 [Term]
 id: MP:0020333
 name: enhanced leukocyte tethering or rolling
-def: "enhancement of the transient adhesive interactions between leukocytes and endothelial cells lining blood vessels mediated primarily by selectins and which are typically the first step in cellular extravasation" [GO:0050901, ORCID: orcid.org/0000-0003-4606-0597]
+def: "enhancement of the transient adhesive interactions between leukocytes and endothelial cells lining blood vessels mediated primarily by selectins and which are typically the first step in cellular extravasation" [GO:0050901, ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0003627 ! abnormal leukocyte tethering or rolling

 [Term]
 id: MP:0020334
 name: abnormal melanophage morphology
-def: "any structural anomaly in the  melanin-containing macrophages that obtain the pigment by phagocytosis of melanosomes" [CL_0002060, ORCID: orcid.org/0000-0003-4606-0597]
+def: "any structural anomaly in the  melanin-containing macrophages that obtain the pigment by phagocytosis of melanosomes" [CL_0002060, ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0002446 ! abnormal macrophage morphology

 [Term]
 id: MP:0020335
 name: abnormal dentate gyrus neuron dendrite morphology
-def: "any structural anomaly of the highly branched tree-like process of a neuron in one of two interlocking gyri of the hippocampus formation" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "any structural anomaly of the highly branched tree-like process of a neuron in one of two interlocking gyri of the hippocampus formation" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0008143 ! abnormal dendrite morphology

 [Term]
 id: MP:0020336
 name: abnormal motor neuron dendrite morphology
-def: "any structural anomaly of the highly branched tree-like process of cells that innervate an effector (muscle or glandular) tissue and are responsible for transmission of motor impulses" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "any structural anomaly of the highly branched tree-like process of cells that innervate an effector (muscle or glandular) tissue and are responsible for transmission of motor impulses" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0008143 ! abnormal dendrite morphology

 [Term]
 id: MP:0020337
 name: abnormal pyramidal neuron dendrite morphology
-def: "structural anomaly of the highly branched tree-like process of the neurons that have a pyramid-shaped soma with the apex and an apical dendrite pointed toward the pial surface and other dendrites and an axon emerging from the base" [CL_0000598, ORCID: orcid.org/0000-0003-4606-0597]
+def: "structural anomaly of the highly branched tree-like process of the neurons that have a pyramid-shaped soma with the apex and an apical dendrite pointed toward the pial surface and other dendrites and an axon emerging from the base" [CL_0000598, ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0008143 ! abnormal dendrite morphology

 [Term]
 id: MP:0020338
 name: abnormal hippocampal pyramidal neuron dendrite morphology
-def: "structural anomaly of the highly branched tree-like process of the hippocampal neurons that have a pyramid-shaped soma with the apex and an apical dendrite pointed toward the pial surface and other dendrites and an axon emerging from the base" [CL_1001571, ORCID: orcid.org/0000-0003-4606-0597]
+def: "structural anomaly of the highly branched tree-like process of the hippocampal neurons that have a pyramid-shaped soma with the apex and an apical dendrite pointed toward the pial surface and other dendrites and an axon emerging from the base" [CL_1001571, ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0020337 ! abnormal pyramidal neuron dendrite morphology

 [Term]
 id: MP:0020339
 name: abnormal retinal ganglion cell dendrite morphology
-def: "any structural anomaly of the highly branched tree-like process of neurons in the retina that receive neural inputs via bipolar, horizontal and amacrine cells" [CL_0000740, ORCID: orcid.org/0000-0003-4606-0597]
+def: "any structural anomaly of the highly branched tree-like process of neurons in the retina that receive neural inputs via bipolar, horizontal and amacrine cells" [CL_0000740, ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0008143 ! abnormal dendrite morphology

 [Term]
 id: MP:0020340
 name: abnormal inhibitory learning
-def: "anomaly in the process by which a subject learns to suppress a prior learned response" [http://cognitivedefusion.tumblr.com/post/90402024947/what-is-inhibitory-learning, ORCID: orcid.org/0000-0003-4606-0597, PMID:19321764]
+def: "anomaly in the process by which a subject learns to suppress a prior learned response" [http://cognitivedefusion.tumblr.com/post/90402024947/what-is-inhibitory-learning, ORCID:orcid.org/0000-0003-4606-0597, PMID:19321764]
 synonym: "'abnormal latent inhibition of learned behavior'" EXACT []
 is_a: MP:0002063 ! abnormal learning/memory/conditioning

 [Term]
 id: MP:0020341
 name: abnormal circulating hyaluronic acid level
-def: "any anomaly in the amount in the blood of hyaluronic acid, an anionic nonsulfated glycosaminoglycan containing the constituent sugars: glucuronic acid and glucosamine" [ORCID: orcid.org/0000-0003-4606-0597, PMID:9260563]
+def: "any anomaly in the amount in the blood of hyaluronic acid, an anionic nonsulfated glycosaminoglycan containing the constituent sugars: glucuronic acid and glucosamine" [ORCID:orcid.org/0000-0003-4606-0597, PMID:9260563]
 synonym: "'abnormal circulating hyaluronan level'" EXACT []
 is_a: MP:0009642 ! abnormal blood homeostasis
 is_a: MP:0011475 ! abnormal glycosaminoglycan level
@@ -104196,14 +104196,14 @@
 [Term]
 id: MP:0020343
 name: abnormal ureteric bud number
-def: "anomaly in the number of the epithelial swelling on the metanephric duct that elongates to invade the adjacent metanephric mesenchyme" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "anomaly in the number of the epithelial swelling on the metanephric duct that elongates to invade the adjacent metanephric mesenchyme" [ORCID:orcid.org/0000-0003-4606-0597]
 synonym: "abnormal mesonephric diverticulum number" EXACT []
 is_a: MP:0006032 ! abnormal ureteric bud morphology

 [Term]
 id: MP:0020344
 name: abnormal susceptibility to injury induced morbidity/mortality
-def: "differences from the expected moribund state caused by trauma, especially that by physical means" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "differences from the expected moribund state caused by trauma, especially that by physical means" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0001657 ! abnormal induced morbidity/mortality
 is_a: MP:0005164 ! abnormal response to injury

@@ -104217,21 +104217,21 @@
 [Term]
 id: MP:0020346
 name: abnormal mycardial fiber calcium currents
-def: "any anomaly in the electrical currents produced by cardiac calcium ion channels, typically measured using  whole-cell patch-clamp techniques" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "any anomaly in the electrical currents produced by cardiac calcium ion channels, typically measured using  whole-cell patch-clamp techniques" [ORCID:orcid.org/0000-0003-4606-0597]
 synonym: "abnormal cardiomyocyte calcium currents" EXACT []
 is_a: MP:0020345 ! abnormal myocardial fiber currents

 [Term]
 id: MP:0020347
 name: abnormal mycoardial fiber sodium currents
-def: "any anomaly in the electrical currents produced by cardiac sodium ion channels, typically measured using  whole-cell patch-clamp techniques" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "any anomaly in the electrical currents produced by cardiac sodium ion channels, typically measured using  whole-cell patch-clamp techniques" [ORCID:orcid.org/0000-0003-4606-0597]
 synonym: "abnormal cardiomyocyte sodium currents" EXACT []
 is_a: MP:0020345 ! abnormal myocardial fiber currents

 [Term]
 id: MP:0020348
 name: decreased olfactory sensory neuron number
-def: "decreased number of the neurons in the olfactory epithelium that are activated by specific odorants" [MGI:mberry, ORCID: orcid.org/0000-0003-4606-0597]
+def: "decreased number of the neurons in the olfactory epithelium that are activated by specific odorants" [MGI:mberry, ORCID:orcid.org/0000-0003-4606-0597]
 synonym: "decreased olfactory receptor neuron number" EXACT []
 is_a: MP:0000966 ! decreased sensory neuron number
 is_a: MP:0006092 ! abnormal olfactory sensory neuron morphology
@@ -104239,49 +104239,49 @@
 [Term]
 id: MP:0020349
 name: abnormal dendritic cell migration
-def: "any anomaly in the movement of dendritic cells from one site to another" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "any anomaly in the movement of dendritic cells from one site to another" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0002376 ! abnormal dendritic cell physiology
 is_a: MP:0003156 ! abnormal leukocyte migration

 [Term]
 id: MP:0020350
 name: fused pharyngeal arches
-def: "failure of two or more arches to fully separate" [ORCID: orcid.org/0000-0003-4606-0597, PMID:22319578]
+def: "failure of two or more arches to fully separate" [ORCID:orcid.org/0000-0003-4606-0597, PMID:22319578]
 synonym: "fused branchial arches" EXACT []
 is_a: MP:0002884 ! abnormal pharyngeal arch morphology

 [Term]
 id: MP:0020351
 name: decreased vocalization
-def: "decrease in the production of vocal sound" [ORCID: orcid.org/0000-0003-4606-0597, PMID:26621702]
+def: "decrease in the production of vocal sound" [ORCID:orcid.org/0000-0003-4606-0597, PMID:26621702]
 synonym: "reduced vocalization" EXACT []
 is_a: MP:0001529 ! abnormal vocalization

 [Term]
 id: MP:0020352
 name: abnormal endoplasmic reticulum physiology
-def: "any functional anomaly of the irregular network of unit membranes, visible only by electron microscopy, that occurs in the cytoplasm of many eukaryotic cells" [GO:0005783, ORCID: orcid.org/0000-0003-4606-0597]
+def: "any functional anomaly of the irregular network of unit membranes, visible only by electron microscopy, that occurs in the cytoplasm of many eukaryotic cells" [GO:0005783, ORCID:orcid.org/0000-0003-4606-0597]
 synonym: "abnormal ER physiology" EXACT []
 is_a: MP:0005621 ! abnormal cell physiology

 [Term]
 id: MP:0020353
 name: abnormal endoplasmic reticulum stress
-def: "any anomaly in the accumulation of misfolded or unfolded proteins in the endoplasmic reticulum lumen; this accumulation maybe stimulated by genetic or enviromental factors" [ORCID: orcid.org/0000-0003-4606-0597, PMID:21266244]
+def: "any anomaly in the accumulation of misfolded or unfolded proteins in the endoplasmic reticulum lumen; this accumulation maybe stimulated by genetic or enviromental factors" [ORCID:orcid.org/0000-0003-4606-0597, PMID:21266244]
 synonym: "abnormal ER stress" EXACT []
 is_a: MP:0020352 ! abnormal endoplasmic reticulum physiology

 [Term]
 id: MP:0020354
 name: increased endoplasmic reticulum stress
-def: "increase in in the accumulation of misfolded or unfolded proteins in the endoplasmic reticulum lumen; this accumulation may be stimulated by genetic or enviromental factors" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "increase in in the accumulation of misfolded or unfolded proteins in the endoplasmic reticulum lumen; this accumulation may be stimulated by genetic or enviromental factors" [ORCID:orcid.org/0000-0003-4606-0597]
 synonym: "increased ER stress" EXACT []
 is_a: MP:0020353 ! abnormal endoplasmic reticulum stress

 [Term]
 id: MP:0020355
 name: abnormal Sertoli cell barrier morphology
-def: "any structural anomaly of the physical barrier found between adjacent Sertoli cells within the seminiferous tubules; the sertoli cell barrier consists of several types of cellular junctions including tight junctions, gap junctions and adhesion junctions, and divides the seminiferous tubules into the basal and apical (adluminal) compartments" [PMID:24713828 http\://www.ajandrology.com/article.asp?issn=1008-682X;year=2014;volume=16;issue=4;spage=572;epage=580;aulast=Jiang]
+def: "any structural anomaly of the physical barrier found between adjacent Sertoli cells within the seminiferous tubules; the sertoli cell barrier consists of several types of cellular junctions including tight junctions, gap junctions and adhesion junctions, and divides the seminiferous tubules into the basal and apical (adluminal) compartments" [PMID:24713828 "http://www.ajandrology.com/article.asp?issn=1008-682X;year=2014;volume=16;issue=4;spage=572;epage=580;aulast=Jiang"]
 synonym: "abnormal blood-testis barrier morphology" EXACT []
 synonym: "abnormal BTB morphology" EXACT []
 synonym: "abnormal SCB morphology" EXACT []
@@ -104290,7 +104290,7 @@
 [Term]
 id: MP:0020356
 name: abnormal Sertoli cell barrier function
-def: "any functional anomaly of the physical barrier found between the blood vessels and the seminiferous tubules of the testes; this barrier between Sertoli cells is composed of  tight junctions, basal ectoplasmic specializations, and desmosome-like junctions" [https://en.wikipedia.org/wiki/Blood%E2%80%93testis_barrier, PMID:24713828 http\://www.ajandrology.com/article.asp?issn=1008-682X;year=2014;volume=16;issue=4;spage=572;epage=580;aulast=Jiang, PMID:24803656]
+def: "any functional anomaly of the physical barrier found between the blood vessels and the seminiferous tubules of the testes; this barrier between Sertoli cells is composed of  tight junctions, basal ectoplasmic specializations, and desmosome-like junctions" [https://en.wikipedia.org/wiki/Blood%E2%80%93testis_barrier, PMID:24713828 "http://www.ajandrology.com/article.asp?issn=1008-682X;year=2014;volume=16;issue=4;spage=572;epage=580;aulast=Jiang, PMID:24803656"]
 synonym: "abnormal blood-testis barrier function" EXACT []
 synonym: "abnormal BTB function" EXACT []
 synonym: "abnormal SCB function" EXACT []
@@ -104331,7 +104331,7 @@
 [Term]
 id: MP:0020362
 name: abnormal male germ cell physiology
-def: "any functional anomaly of male germ cells whether they are undifferentiated or fully differentiated" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "any functional anomaly of male germ cells whether they are undifferentiated or fully differentiated" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0020363 ! abnormal germ cell physiology

 [Term]
@@ -104344,7 +104344,7 @@
 [Term]
 id: MP:0020364
 name: abnormal female germ cell physiology
-def: "any functional anomaly female germ cells whether they are undifferentiated or fully differentiated" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "any functional anomaly female germ cells whether they are undifferentiated or fully differentiated" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0020363 ! abnormal germ cell physiology

 [Term]
@@ -104353,7 +104353,7 @@
 def: "increase in the amount of iron present in the brain tissue" [MGI:Anna]
 synonym: "elevated brain iron level" EXACT []
 is_a: MP:0008811 ! abnormal brain iron level
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020366
@@ -104361,7 +104361,7 @@
 def: "reduction in the amount of iron present in the brain tissue" [MGI:Anna]
 synonym: "reduced brain iron level" EXACT []
 is_a: MP:0008811 ! abnormal brain iron level
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020367
@@ -104371,7 +104371,7 @@
 synonym: "elevated heart iron level" EXACT []
 synonym: "increased cardiac iron level" EXACT []
 is_a: MP:0008741 ! abnormal heart iron level
-property_value: http://purl.org/dc/elements/1.1/creator "ORCID: orcid.org/0000-0003-4606-0597" xsd:string
+property_value: http://purl.org/dc/elements/1.1/creator "ORCID:orcid.org/0000-0003-4606-0597" xsd:string

 [Term]
 id: MP:0020368
@@ -104381,7 +104381,7 @@
 synonym: "reduced cardiac iron level" EXACT []
 synonym: "reduced heart iron level" EXACT []
 is_a: MP:0008741 ! abnormal heart iron level
-property_value: http://purl.org/dc/elements/1.1/creator "ORCID: orcid.org/0000-0003-4606-0597" xsd:string
+property_value: http://purl.org/dc/elements/1.1/creator "ORCID:orcid.org/0000-0003-4606-0597" xsd:string

 [Term]
 id: MP:0020369
@@ -104389,18 +104389,18 @@
 def: "increase in the amount of iron present in the large or small intestinal tissue" [MGI:Anna]
 synonym: "elevated intestinal iron level" EXACT []
 is_a: MP:0008740 ! abnormal intestinal iron level
-property_value: http://purl.org/dc/elements/1.1/creator "ORCID: orcid.org/0000-0003-4606-0597" xsd:string
+property_value: http://purl.org/dc/elements/1.1/creator "ORCID:orcid.org/0000-0003-4606-0597" xsd:string

 [Term]
 id: MP:0020370
 name: abnormal glymphatic system morphology
-def: "any structural anomaly in the macroscopic waste clearance system that utilizes a unique system of perivascular tunnels, formed by astroglial cells, to promote efficient elimination of soluble proteins and metabolites from the central nervous system" [ORCID: orcid.org/0000-0003-4606-0597, UBERON:0036145]
+def: "any structural anomaly in the macroscopic waste clearance system that utilizes a unique system of perivascular tunnels, formed by astroglial cells, to promote efficient elimination of soluble proteins and metabolites from the central nervous system" [ORCID:orcid.org/0000-0003-4606-0597, UBERON:0036145]
 is_a: MP:0003632 ! abnormal nervous system morphology

 [Term]
 id: MP:0020371
 name: abnormal glymphatic system physiology
-def: "any functional anomaly in the macroscopic waste clearance system that utilizes a unique system of perivascular tunnels, formed by astroglial cells, to promote efficient elimination of soluble proteins and metabolites from the central nervous system" [ORCID: orcid.org/0000-0003-4606-0597, UBERON:0036145]
+def: "any functional anomaly in the macroscopic waste clearance system that utilizes a unique system of perivascular tunnels, formed by astroglial cells, to promote efficient elimination of soluble proteins and metabolites from the central nervous system" [ORCID:orcid.org/0000-0003-4606-0597, UBERON:0036145]
 is_a: MP:0003633 ! abnormal nervous system physiology

 [Term]
@@ -104421,13 +104421,13 @@
 [Term]
 id: MP:0020374
 name: abnormal nocifensive behavior
-def: "any anomaly in a behavioral response to a noxious signal typically mediated by nociception" [ISBN:1588299333, ORCID: orcid.org/0000-0003-4606-0597]
+def: "any anomaly in a behavioral response to a noxious signal typically mediated by nociception" [ISBN:1588299333, ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0004924 ! abnormal behavior

 [Term]
 id: MP:0020375
 name: abnormal costotransverse joint morphology
-def: "any anomaly in the structure of the articulation between the facet of the tubercle of a rib and the transverse process of a thoracic vertebra" [ORCID: orcid.org/0000-0003-4606-0597, UBERON:0011967]
+def: "any anomaly in the structure of the articulation between the facet of the tubercle of a rib and the transverse process of a thoracic vertebra" [ORCID:orcid.org/0000-0003-4606-0597, UBERON:0011967]
 is_a: MP:0008149 ! abnormal costovertebral joint morphology

 [Term]
@@ -104440,7 +104440,7 @@
 [Term]
 id: MP:0020377
 name: abnormal dopaminergic amacrine cell morphology
-def: "any structural anomaly of the retinal amacrine cells that express dopamine and are often identified by immunostaining for expression of tyrosine hydroxylase" [http://webvision.med.utah.edu/book/part-iii-retinal-circuits/roles-of-amacrine-cells/, ORCID: orcid.org/0000-0003-4606-0597]
+def: "any structural anomaly of the retinal amacrine cells that express dopamine and are often identified by immunostaining for expression of tyrosine hydroxylase" [http://webvision.med.utah.edu/book/part-iii-retinal-circuits/roles-of-amacrine-cells/, ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0005240 ! abnormal amacrine cell morphology

 [Term]
@@ -104452,7 +104452,7 @@
 [Term]
 id: MP:0020379
 name: abnormal sucrose solution preference
-def: "any anomaly in the desire to drink water containing sucrose compared to consuming straight water" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "any anomaly in the desire to drink water containing sucrose compared to consuming straight water" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0001423 ! abnormal liquid preference

 [Term]
@@ -104478,14 +104478,14 @@
 [Term]
 id: MP:0020383
 name: decreased kidney epithelial cell primary cilium length
-def: "decreased length of the cilia on cells of the renal tubule or collecting duct" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "decreased length of the cilia on cells of the renal tubule or collecting duct" [ORCID:orcid.org/0000-0003-4606-0597]
 synonym: "short kidney epithelial cell primary cilium" EXACT []
 is_a: MP:0011065 ! abnormal kidney epithelial cell primary cilium morphology

 [Term]
 id: MP:0020384
 name: absent kidney epithelial cell primary cilium
-def: "absence of non-motile cilia on cells of the renal tubule or collecting duct" [ORCID: orcid.org/0000-0003-4606-0597]
+def: "absence of non-motile cilia on cells of the renal tubule or collecting duct" [ORCID:orcid.org/0000-0003-4606-0597]
 is_a: MP:0011065 ! abnormal kidney epithelial cell primary cilium morphology

 [Term]
@@ -104494,7 +104494,7 @@
 def: "reduction in the amount of iron present in the large or small intestinal tissue" [MGI:Anna]
 synonym: "reduced intestinal iron level" EXACT []
 is_a: MP:0008740 ! abnormal intestinal iron level
-property_value: http://purl.org/dc/elements/1.1/creator "ORCID: orcid.org/0000-0003-4606-0597" xsd:string
+property_value: http://purl.org/dc/elements/1.1/creator "ORCID:orcid.org/0000-0003-4606-0597" xsd:string

 [Term]
 id: MP:0020386
@@ -104504,14 +104504,14 @@
 synonym: "fat tissue inflammation" EXACT []
 is_a: MP:0001846 ! increased inflammatory response
 is_a: MP:0005666 ! abnormal adipose tissue physiology
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020387
 name: abnormal radial glial cell number
 def: "anomaly in the number of the supporting cells of the developing central nervous system that guide neuronal migration during development and exchange metabolites with developing and migrating neurons; these cells differentiate into astrocytes and some neuronal types in the adult" [MGI:anna]
 is_a: MP:0003648 ! abnormal radial glial cell morphology
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020388
@@ -104519,7 +104519,7 @@
 def: "reduction in the number of the supporting cells of the developing central nervous system that guide neuronal migration during development and exchange metabolites with developing and migrating neurons; these cells differentiate into astrocytes and some neuronal types in the adult" [MGI:anna, PMID:25698753]
 synonym: "reduced radial glial cell number" EXACT []
 is_a: MP:0020387 ! abnormal radial glial cell number
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020389
@@ -104527,7 +104527,7 @@
 def: "increase in the number of the supporting cells of the developing central nervous system that guide neuronal migration during development and exchange metabolites with developing and migrating neurons; these cells differentiate into astrocytes and some neuronal types in the adult" [MGI:anna, PMID:25100583]
 synonym: "elevated radial glial cell number" EXACT []
 is_a: MP:0020387 ! abnormal radial glial cell number
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020390
@@ -104536,7 +104536,7 @@
 synonym: "abnormal radial glial endfeet" EXACT []
 synonym: "abnormal radial glial endfoot" EXACT []
 is_a: MP:0003648 ! abnormal radial glial cell morphology
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020391
@@ -104544,7 +104544,7 @@
 def: "detachment of the radial glia cell endfoot from the pial basement membrane" [MGI:anna, PMID:17715063, PMID:23217742, PMID:24256719]
 synonym: "detached radial glia endfeet" EXACT []
 is_a: MP:0020390 ! abnormal radial glial cell endfoot morphology
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020392
@@ -104552,7 +104552,7 @@
 def: "change in the timing or the number of radial glial cells undergoing programmed cell death" [MGI:anna, PMID:25948253]
 synonym: "abnormal radial glia apoptosis" EXACT []
 is_a: MP:0010170 ! abnormal glial cell apoptosis
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020393
@@ -104564,7 +104564,7 @@
 synonym: "increased neuroblast proliferation" EXACT []
 synonym: "increased neuronal progenitor proliferation" EXACT []
 is_a: MP:0004948 ! abnormal neuronal precursor proliferation
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020394
@@ -104576,7 +104576,7 @@
 synonym: "reduced neuronal precursor proliferation" EXACT []
 synonym: "reduced neuronal progenitor proliferation" EXACT []
 is_a: MP:0004948 ! abnormal neuronal precursor proliferation
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020395
@@ -104584,14 +104584,14 @@
 def: "any anomaly in the interaction of an individual with a familiar versus a novel individual of the same species; in mouse the typical behavior is is for increased interaction with the novel individual" [PMID:23280234]
 is_a: MP:0001360 ! abnormal social investigation
 is_a: MP:0003107 ! abnormal response to novelty
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020396
 name: abnormal social recognition
 def: "any anomaly in the ability of an individual to recognize another individual of the same species during repeated encounters" [PMID:11950245]
 is_a: MP:0001360 ! abnormal social investigation
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020397
@@ -104601,21 +104601,21 @@
 synonym: "abnormal megalocaryocyte physiology" EXACT []
 synonym: "abnormal megalokaryocyte physiology" EXACT []
 is_a: MP:0009278 ! abnormal bone marrow cell physiology
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020398
 name: abnormal megakaryocyte emperipolesis
 def: "any anomaly in the process by which a a megakaryocyte is penetrated by another living cell; unlike in phagocytosis the engulfed cell remains viable and may exit the megakaryocyte without damage to either cell" [PMID:25654060]
 is_a: MP:0020397 ! abnormal megakaryocyte physiology
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020399
 name: enhanced megakaryocyte emperipolesis
 def: "an increase in the process by which a a megakaryocyte is penetrated by another living cell" [PMID:25654060, PMID:26950939]
 is_a: MP:0020398 ! abnormal megakaryocyte emperipolesis
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020400
@@ -104623,7 +104623,7 @@
 def: "excretion of excessive amounts of cystine in the urine" [HP:0003131]
 synonym: "increased urine cystine level" EXACT []
 is_a: MP:0003311 ! aminoaciduria
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020401
@@ -104631,7 +104631,7 @@
 def: "excretion of excessive amounts of arginine in the urine" [HP:0003268]
 synonym: "increased urine arginine level" EXACT []
 is_a: MP:0003311 ! aminoaciduria
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020402
@@ -104639,7 +104639,7 @@
 def: "excretion of excessive amounts of ornithine in the urine" [HP:0003532]
 synonym: "increased urine ornithine level" EXACT []
 is_a: MP:0003311 ! aminoaciduria
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020403
@@ -104647,7 +104647,7 @@
 def: "excretion of excessive amounts of lysine in the urine" [http://medical-dictionary.thefreedictionary.com/lysinuria]
 synonym: "increased urine lysine level" EXACT []
 is_a: MP:0003311 ! aminoaciduria
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020404
@@ -104655,7 +104655,7 @@
 def: "excretion of excessive amounts of proline in the urine" [HP:0003137]
 synonym: "increased urine proline level" EXACT []
 is_a: MP:0003311 ! aminoaciduria
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020405
@@ -104663,7 +104663,7 @@
 def: "excretion of excessive amounts of taurine in the urine" [HP:0003166]
 synonym: "increased urinary taurine level" EXACT []
 is_a: MP:0003311 ! aminoaciduria
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020406
@@ -104672,7 +104672,7 @@
 synonym: "increased urinary threonine" EXACT []
 synonym: "increased urine threonine level" EXACT []
 is_a: MP:0003311 ! aminoaciduria
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020407
@@ -104680,14 +104680,14 @@
 def: "any anomaly in the formation or presence of a thrombus within the blood vessel network of the placenta" [MGI:anna]
 is_a: MP:0003231 ! abnormal placenta vasculature
 is_a: MP:0005048 ! abnormal thrombosis
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020408
 name: altered susceptibility to induced thrombosis
 def: "any anomaly in the formation of thrombi following mechanical or chemical stimulation of thrombosis" [PMID:16614756, PMID:9262402]
 is_a: MP:0005048 ! abnormal thrombosis
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020409
@@ -104695,21 +104695,21 @@
 def: "any anomaly in the formation or presence of thrombi in the heart" [PMID:15870284]
 synonym: "abnormal heart thrombosis" EXACT []
 is_a: MP:0005048 ! abnormal thrombosis
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020410
 name: increased liposarcoma incidence
 def: "greater than the expected number of malignant tumors derived from primitive or embryonal lipoblastic cells; these may be composed of well-differentiated fat cells or may be dedifferentiated: myxoid, round-celled, or pleomorphic" [MESH:D008080, PMID:27573812]
 is_a: MP:0002032 ! increased sarcoma incidence
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020411
 name: increased abdominal adipose tissue amount
 def: "increase in amount of adipose tissue associated with internal organs" [MGI:anna]
 is_a: MP:0001781 ! abnormal white adipose tissue amount
-created_by: ORCID: orcid.org/0000-0003-4606-0597
+created_by: ORCID:orcid.org/0000-0003-4606-0597

 [Term]
 id: MP:0020412

I think it looks okay. I think Anna just went through and removed an extra space from the ORCID cross-references. Or is there something else I'm missing?


More tight_loop_contents() ?

This may be a stupid question, which is why I'm asking in an issue rather than just creating a PR :wink:
Should there be a tight_loop_contents() on any / all of these lines?
https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/hardware_sync/include/hardware/sync.h#L257
https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/hardware_xosc/xosc.c#L38
https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/hardware_xosc/xosc.c#L47
https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/hardware_xosc/xosc.c#L54

yes!

merged into develop


Exporting data

The app suits me well, but I cannot export notes (like Obsidian, for example). Is there a way to do it? If not, that would be a great addition.

right now i still focussing on backup data, but i'll see how the export notes works

thanks, bro. I'm really into open software, but i know nothing about programming. take your time


Update Interface

Note: this builds off of my prettier branch, see the actual diff here
Summary
Updating a few aspects of the react-percy interface based on our conversation earlier this week.
Suites and Snapshots
The first change is dropping the BDD-style testing describe/it lingo. We want to differentiate Percy tests from regular unit tests, so using different function names makes sense.

describe => suite
it => snapshot

As an example:
import MyComponent from '../MyComponent';
import React from 'react';

suite('MyComponent', () => {

  snapshot('default', () => (
    <MyComponent />
  ));

  snapshot('selected', () => (
    <MyComponent selected />
  ));

});

I went with snapshot here as I know that's the standard term you guys use across all the other Percy integrations. I do have some concerns with that, though, given that many people will be familiar with Jest snapshots. I could easily see people getting confused by Jest-generated __snapshots__ folders near their Percy tests, which have nothing to do with Percy.
The main alternative I see is screenshot, which would at least differentiate it from Jest. But I suspect you guys may have reasons you prefer the term "snapshot" to "screenshot". Open to ideas!
Percy File Naming
This also updates react-percy to look for test files in __percy__ folders or with .percy.js/.percy.jsx extensions. This mirrors the unit testing conventions of using a __tests__ folder or .test.js/.spec.js extension.
I see some pros and cons to this naming convention.
On the plus side, it's very unambiguous that these files are related to Percy. Hopefully this will prevent people from mixing them up with unit test files.
On the other hand, if I'm a new developer jumping into a codebase and I haven't used Percy before, I might be confused by what these files are. With unit tests, I've never seen anybody create a .jasmine.js file or __jest__ folder, they just use .spec.js and __tests__ as those names more clearly convey what the files are for rather than how they're run. The corollary here would be to create .screenshot.js files or __screenshots__ folders. As I mentioned above, "snapshots" has another meaning in many React projects, so using that naming would cause a lot of confusion (and likely break some Jest configurations).
ESLint Plugin
With the previous describe/it naming conventions, users could easily use the jest or jasmine ESLint environment to whitelist those globals. Now that we're moving towards our own naming convention, it will be handy for users to have an easy way to whitelist the global variables we expose in Percy tests.
I've created a new package here, eslint-plugin-react-percy, which as of right now just contains a globals section that whitelists beforeEach, afterEach, suite, snapshot, etc. Note that I did not prefix the package name with @percy-io because ESLint has very particular rules for how it resolves plugins. The very latest versions of ESLint have gotten better about handling scoped package names, but for users with ESLint 3 it'll just cause more trouble than it's worth.

@thomashuston I've temporarily changed the base here from master to th-prettier to do the review. Once you've merged th-prettier, we can switch this back before merge.

Just merged the prettier PR. Feel free to change this back to master!

@thomashuston Done, needs a resolve merge here.

Per discussion:
Example: flat style (default, suite name inferred from filename):
// MyComponent.percy.js

percySnapshot('default', () => {
  <MyComponent />
});

percySnapshot('selected', () => {
  <MyComponent selected />
});

With beforeEach/afterEach at module level:
// MyComponent.percy.js

beforeEach(() => {
  initializeCityDatabase();
});

afterEach(() => {
  clearCityDatabase();
});

percySnapshot('default', () => {
  <MyComponent />
});

percySnapshot('selected', () => {
  <MyComponent selected />
});

Suite style:
// MyComponent.percy.js

suite('MyComponent', () => {
  percySnapshot('default', () => {
    <MyComponent />
  });

  percySnapshot('selected', () => {
    <MyComponent selected />
  });
});

With beforeEach/afterEach in the suite:
// MyComponent.percy.js

suite('MyComponent', () => {
  beforeEach(() => {
    initializeCityDatabase();
  });

  afterEach(() => {
    clearCityDatabase();
  });

  percySnapshot('default', () => {
    <MyComponent />
  });

  percySnapshot('selected', () => {
    <MyComponent selected />
  });
});

Argument passing:
percySnapshot('default', {widths: [375, 1280]}, () => {
  <MyComponent />
});

percySnapshot('default', {widths: [375, 1280], minimumHeight: 300, enableJavaScript: false}, () => {
  <MyComponent />
});

Only note I would make is that we should not support enableJavascript as an argument in this. The framework either needs to server-side render all test cases and upload them in the HTML already rendered, or it needs to just upload a JS file that renders the component into the page client side in Percy's rendering infra. I'd rather not have to support both systems within our code here unless there's a compelling reason, and my gut was to just switch to client rendering with JS enabled so that references to window etc. just work.

Updated snapshot to percySnapshot as we discussed. Next steps:

Tweaking the way options are passed into suites and test cases
Doing a round of package renames since we're talking about this supporting frameworks other than React (e.g. Vue)

What do we want to call this now...? The most natural name for this repo now seems like percy-js, but that's already used by the JS Percy client

I'd propose we merge this and tackle those two items in separate PRs, but your call!


[ext] Allow NULL value for GPS coordinates for instances where Timeout Error cannot be resolved

@onlyjsmith commented on Thu Jul 19 2018
External feedback source: https://github.com/disarm-platform/user-requests-and-feedback/issues/88
In instances where users are not able to collect GPS points due to hardware issues, they should still be able to submit their form details. These would count in coverage calculations according to their location dropdown selection, but would naturally not appear on the map.

Ok - from today's CHAI call: they are removing this as a requirement, but we've agreed to go ahead and implement. This will be very useful if mid-season, any users are having trouble with GPS coords - we can turn-off with a config change, and there won't be a major drop in data quality.

The branch uses the property location_coords_optional from instance_config.applets.irs_record_point.
@onlyjsmith any thoughts on naming?
Will need to update config-validation and config-editor when we decide on name.

We now have two properties under irs_record_point:

location_selection_required
gps_coords_required

We need to update the configurations for all instances to include those two properties and make sure they are both set to true to maintain current behaviour.


host scaladocs

added sbt command to publish scaladocs.
Type sbt ghpagesPushSite to push scaladocs.
They are hosted here:
https://clulab.github.io/eidos/latest/api/org/clulab/wm/eidos/index.html
Some other things would be nice, like a redirect from https://clulab.github.io/eidos so that we don't need to remember the whole url. However, this already works.

Note that the gh-pages branch must exist for this to work.

Does the gh-pages branch need an index.html like the one below?  Will it get overwritten or cause problems?

		<meta http-equiv="Refresh" content="2; url=https://clulab.github.io/eidos/latest/api/org/clulab/wm/eidos/index.html">
		<title>Eidos Reference Documentation Redirector</title>

		You should momentarily be redirected to the Eidos reference documentation at
		https://clulab.github.io/eidos/latest/api/org/clulab/wm/eidos/index.html.

That looks good to me, except that I wonder why the redirect is done in JavaScript.  Is that the new way of doing things?  If for some reason we need to have other pages, the redirect could become a web page with multiple links.  Would you like to add a redirecting src/site/index.html to this branch before it gets merged?

Sure I can add it. And we don't need to use the javascript redirect. I'll try your version first.

I should have had a document type, encoding, language, etc.

Added the redirect. You can now visit https://clulab.github.io/eidos and be redirected to the scaladocs.

@bsharpataz if you want to see the scaladoc without publishing it (e.g. in some branch other than master) you can use sbt previewSite

@marcovzla and @kwalcock when do we get to merge this bad boy?

I think this is complete. Unless you want me to add something else?


@function -> @method

Functions and methods are fundamentally different things, at least for webdoc. A function can be called without a this context and is not a member of a class/object. They are documented as separate pages. A method does have a this context and only is called using "context."method()
The methods added by the cache mixin should be tagged @method and not @function.

Codecov Report

Merging #6905 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #6905   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           15        15
  Lines          671       671
=========================================
  Hits           671       671

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bec6c5...092b7a2. Read the comment docs.

While you're at it, could you fix these two classes in the docs:

BasisFile
IGLUniformData

Hello

``h

Thanks @SukantPal. If you can do a docs follow-up with those classes above, that would be great :+1:


[BUG] Cannot apply model from download tab

recording.webm

Some models have some issues because they haven't the right structure for the index or the pth file so the downloader breaks. Did you try with another model?

Some models have some issues because they haven't the right structure for the index or the pth file so the downloader breaks. Did you try with another model?

I chose to download it and put it in the folder manually and it worked.

Some models have some issues because they haven't the right structure for the index or the pth file so the downloader breaks. Did you try with another model?

I chose to download it and put it in the folder manually and it worked.

I said that "the downloader breaks" if you put them manually it should work as you said, but did you try with another model in the downloader?


WIP: Updating android sdk and related tools to version 26.

My Android application based on the reflex-platform does not yet build with this
changes. So please don't merge. I am just putting it here, because I won't get
to finishing this for at least a few weeks, so others needing this, can more
easily pick up the work, if needed.
Also full disclaimer: I am an absolute noob when it comes to Android
development, so if someone more involved can have a look at my changes - that
would be great.
Motivation for this change
If you build an Android application requiring APIs like Foreground service, you need at least version 26 of the androidsdk to have it compile.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Hmm great initiative. I'm however have also started some attempts to package this new SDK concurrently, but I haven't published anything about it yet.
Furthermore, there is something else you need to take into account -- the newer Android SDK's license has changed and mandates people to accept an EULA. This means that in Nixpkgs, we must prevent the SDK from being downloaded automatically because this violates the terms and conditions.

Hmm great initiative. I'm however have also started some attempts to package this new SDK concurrently, but I haven't published anything about it yet.

Awesome! I am happy to assist!

Furthermore, there is something else you need to take into account -- the newer Android SDK's license has changed and mandates people to accept an EULA. This means that in Nixpkgs, we must prevent the SDK from being downloaded automatically because this violates the terms and conditions.

That's kind of a bummer. How do we handle something like this in nix? We can't really package it then - right?

@svanderburg do you have a solution for the EULA problem? Are there any other blockers?

Other packages with license agreements work by requiring the user to specify some argument or config option.  See sc2-headless, or maybe even androidenv.buildgradleapp.

uh nice, thank you!

Any updates on this pull request, please?

Indeed, this is obsolete.


fix: gnews prepare_gnews_url function

Related Issues

fixes #645

Proposed Changes:
Reason:
The prepare_gnews_url function in the google_news.py file was causing a crash due to an AttributeError. Specifically, the error message observed was: AttributeError: 'NoneType' object has no attribute 'groupdict'
This occurred while attempting to access primary_url = match.groupdict()["primary_url"] which failed because match was None at the time of execution.
Found out google has changed something and code wasn't able to decode the url.
Proposed Solution
Found a package google-news-url-decoder used it, it basically does an HTTP get request to get the url.
How did you test it?
I ran the specific tests related to this change. The tests were previously failing due to the error, but after the fix, they passed without any modification to the test cases.
Notes for the reviewer
I ran into a problem with the Python version compatibility. I was able to resolve the issue by setting the minimum Python version to 3.9.
Checklist

[x] I have updated the related issue with new insights and changes
[x] I added unit tests and updated the docstrings
[x] I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
[x] I documented my code
[x] I ran pre-commit hooks and fixed any issue

Hi @AndyTheFactory, I hope you're doing well! Could you kindly take a look at this? It’s quite important for my work. I’d really appreciate your help!


It broke again!

Absolutely love this, my mini map runs with it but it seems to have broke again with one of the recent updates. Is there a fix coming out soon?

Fixed by #4.


[MRG] Reader for Neuroscan cnt files.

Closes https://github.com/mne-tools/mne-python/issues/2815
Followed the logic on eeglab reader. Do we want to include everything from the header file to the raw_extras? It has quite a lot of stuff: http://paulbourke.net/dataformats/eeg/

Amazing !!!

_raw_extras is private, for now I'd only include things we need to provide proper mne-python standard Raw functionality. If there are bits of data people end up needing, we can add it in subsequent PRs, driven by actual use cases.

Does anyone happen to have a small cnt file to add for the tests? The smallest one I have is 2 MB.

That's reasonably small to add to the testing repo

@jaeilepp : I get this warning:
In [12]: raw = read_raw_cnt('cba1ff09.cnt')
/home/mainak/anaconda2/bin/ipython:1: RuntimeWarning: Reading in data in blocks of %d. If this fails, try using read_blocks=False.
  #!/home/mainak/anaconda2/bin/python
Reading in data in blocks of %d. If this fails, try using read_blocks=False.

I tried using mne.find_events but no luck because it could not find stim channel. Would it be possible to set it automatically or have a option in the reader (like in the other readers)?

I couldn't set the channel type either. Not sure if this is a separate issue:
In [14]: raw.set_channel_types({'STI': 'stim'})
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-14-960a4dfacf35> in <module>()
----> 1 raw.set_channel_types({'STI': 'stim'})

/home/mainak/Desktop/projects/mne-python/mne/channels/channels.pyc in set_channel_types(self, mapping)
    289             if unit_old != _human2unit[ch_type]:
    290                 warn("The unit for channel %s has changed from %s to %s."
--> 291                      % (ch_name, _unit2human[unit_old], _unit2human[unit_new]))
    292             self.info['chs'][c_ind]['unit'] = _human2unit[ch_type]
    293             if ch_type in ['eeg', 'seeg']:

KeyError: 0

thanks @jaeilepp . Would be great to have this working soon :)

That error has been "fixed" in master, if this branch is rebased you'll now see an error saying that this indicates an error with the conversion routines. There is no unit 0.

@jaeilepp can we also have the channel locations read in? Merci bien :)

Okay, I think this is ready for review.

@jaeilepp : I get this warning
test_cnt.py:5: RuntimeWarning: Reading in data in blocks of %d. If this fails, try using read_blocks=False.

Also, don't forget to update python_reference.rst and manual/io.rst. Documentation is a must.

I changed the title so that you don't forget to add the docs ;)

@jaeilepp : something is still wrong with the channel locations. This is how they should be: https://en.wikipedia.org/wiki/10-20_system_(EEG)#/media/File:21_electrodes_of_International_10-20_system_for_EEG.svg. For you, it is rotated 180 degrees I think

@jaeilepp : something is still wrong with the channel locations

It seems that the y-axis orientations aren't really consistent (see testing data for example). Maybe we should have invert_y param to define it.

Actually the y-axis might be inverted in the testing data too. I'll just flip it 180 degrees.

did you compare our plots with the ones obtained with eeglab?

Seems that eeglab uses separate files for channel locations. I did not find a correct layout file for the files I have so I could not plot topomaps.
I also have a reason to believe that the channel locations in the header don't always refer to actual locations, but positions in some view. I added documentation about it and forced the user to provide either a montage or allow reading the positions from the header. See if you're happy about it.

can you also rebase to make travis happy?
thx @jaeilepp

Somehow this requires another rebase

that's it for me.
+1 for merge once comments addressed and travis is happy.
thx @jaeilepp !

This is ready for review/merge from my end.

Otherwise LGTM

Thanks !


Proper check for value of min and max

This PR addresses this bug https://github.com/TabDigital/strummer/issues/20

Nice catch! :+1: I think we might have similar bugs in array and string, should we have a look as part of this PR?
On top of this, maybe we could add some checks on opts before returning the matcher, for example asserting that opts.min == null || typeof(opts.min) === 'number'. This would not have any runtime performance if it's executed outside of the matcher function we return. See the duration matcher, that asserts that the min and max durations are actually valid.

@nguyenchr Your suggestion is applied.
@rprieto Agree, I applied same pattern of validation to the number matcher.

nice one :+1:
is it worth making the same change to array and string matchers in this PR?

@rprieto @nguyenchr Good idea. I will extend this PR to fix other matchers as well.

@rprieto @nguyenchr Actually I don't think using this new method in array or string is a good thing. For it doesn't make sense if somebody says minimum length of array should be 0 or maximum length of array should be 0. It's same thing for string. I feel we should leave them as it's now. Putting new logic doesn't change anything in mentioned matchers, it only brings more process to the matcher.

Good point!

:+1:

Per chat with @nguyenchr changelog.md is added to library to keep track of changelog for each version.


blib2to3 tries to store grammar pickle in global site-packages

blib2to3 tries to store a version specific pickle of the grammar in the global site-package directory. This works fine for user-owned installations in a virtual env but not for OS vendored installation. Users typically don't have permission to write to system-wide site-packages directory.
$ strace black
...
openat(AT_FDCWD, "/usr/lib/python3.6/site-packages/blib2to3/Grammar3.6.5.final.0.pickle", O_WRONLY|O_CREAT|O_TRUNC|O_CLOEXEC, 0666) = -1 EACCES (Permission denied)
stat("/usr/lib/python3.6/site-packages/blib2to3/PatternGrammar.txt", {st_mode=S_IFREG|0644, st_size=793, ...}) = 0
stat("/usr/lib/python3.6/site-packages/blib2to3/PatternGrammar3.6.5.final.0.pickle", 0x7ffc225e5c40) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/usr/lib/python3.6/site-packages/blib2to3/PatternGrammar.txt", O_RDONLY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=793, ...}) = 0
...

I tracked down the write through Grammar.dump, load_grammar and load_packaged_grammar to https://github.com/ambv/black/blob/master/blib2to3/pygram.py. The load_grammar takes a pickle file name as gp argument, but load_packaged_grammar and pygram don't use it.
Some pickle files are checked into git but not installed by setup.py, too.

The cache shoves off about 18ms startup time on my machine:
$ python3 -m timeit -s "from blib2to3.pgen2 import pgen" "pgen.generate_grammar('blib2to3/Grammar.txt')"
100 loops, best of 3: 18.1 msec per loop
$ python3 -m timeit -s "from blib2to3.pgen2 import driver" "driver.load_grammar('blib2to3/Grammar.txt')"
1000 loops, best of 3: 245 usec per loop

We should move this cache to the cache dir in appdirs. @ojii, interested?

I'll try to have a look next week.


docs: update rosdep usage in installation page

To users who install ROS for the first time, run "sudo rosdep init" and
"rosdep update" are necessary.
While running "rosdep install", it would be better to add "-y" to
ignore too many prompts.

Signed-off-by: ChenYing Kuo<EMAIL_ADDRESS>Description

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kenji-miyake what's the policy if some of the links in the documentation are not valid? Should we merge the PR anyway?

@esteve You can ignore it if it's not related to the PR since it's optional.
I'll create an issue and address the issue!

@kenji-miyake I've rebased this PR now that #70 is merged

@esteve Thank you!
Just out of curiosity, did you use this button? (Then, it's nice! It's a recently added feature.)

@kenji-miyake yeah, super cool! One of the features that are in Gitlab that wasn't in GitHub, happy they added it, it's so convenient. I rebased this PR using that button :slightly_smiling_face:


Web app - ORM & Data access layer setup

Description
Covers the following

Selection of technology choice for ORM & DB libraries as applicable
Specification of ORM models
Assessment of re-usability in ORM models between Web app & Covalent core
Seperation of data access methods between Web app & Covalent core.

Please add your planning poker estimate with ZenHub @ArunPsiog


Mark test that sometimes fails on windows as xfail.

See #2468. This doesn't fix the bug, obviously, but the flaky test causes failures in unrelated PRs and I think we should try to avoid that.

@vtomole, I agree that could be a risk. The problem is that a flaky test like this slows down everyone working on the code, not just people who might be working on the bug in question or be qualified to fix it. We should definitely assign that bug so someone is responsible for it, not just wait for someone to get sufficiently annoyed :-)

LGTM. Going to merge.

Note: Have to revert once we find a fix.
CC: @kevinsung  @maffoo @Strilanc


Revolver: Minimal integration example

This is the beginning of the examples section. I'm planning to add more examples one by one, covering iOS, Android and KMP integrations. However, it takes a lot of time on commenting the code and reveal features in proper order.

yes, I will add it also. SO it will be Android + iOS + KMM example

Idea is to show that Revolver is easy to use and integrate in any case and if developers do not want to run KMP project they may skip it and use Revolver directly on the platform.


Make typings work w/o using compilerOptions.lib.

This is primarily to make it work w/ typedoc.

That's awesome!

Can we merge?

LGTM


Actually log progress updates

This is a cleaned up version of #326 which does the same thing, but removes some unintended noise of related changes.
The change here is to properly populate log messages for progress statements. This has the potential to be very expensive, and we may quickly return here to put this under a separate logger (the main risk: there is no data reduction going on, so we are logging something proportional to the volume of progress messages rather than a summary of how much work we are doing). In addition, timestamps are converted to strings from their native types (which are often non-allocating) which could be another source of overhead.
This is potentially mitigated by the recent change to default progress tracking, to the demand variant that reduces the risk of runaway volumes of progress information.
In principle, this and #321 could log into a different logger that could be enabled or disabled as appropriate. I think no one was using these messages, as they weren't properly populated, so while it would be technically breaking to do that, I don't think the fix would be more than changing enums around to not reference this variant.

For example, I think I'm a bit more comfortable with the following diff, which allows a user to override logging of progress events by specifying a new destination (which could just discard the logged records; I suppose in that case we might want a clearer way to "disable" to prevent the formation of the events in the first place).
--- a/timely/src/progress/broadcast.rs
+++ b/timely/src/progress/broadcast.rs
@@ -38,6 +38,13 @@ impl<T:Timestamp+Send> Progcaster<T> {
             identifier: channel_identifier,
             kind: crate::logging::CommChannelKind::Progress,
         }));
+
+        // If progress logging is enabled, route messages there instead of to
+        // the general event logging stream.
+        if let Some(progress) = worker.log_register().get::<crate::logging::TimelyEvent>("timely/progress") {
+            logging = Some(progress);
+        }
+
         let worker_index = worker.index();
         let addr = path.clone();
         Progcaster {

This would allow folks to opt out of feeding the events to the logging stream, but not opt out of the cost of generating the events.
Ignoring ergonomics, the logging options may look a fair bit like the recently added Config stuff, which maps strings to Box<Any> types, which can then be downcast to e.g. Logger types among others. That would allow more general instructions, like expecting an Option<Logger> to signify either a new destination or an explicit nothing to avoid producing the event (i.e. a disabled logger). It would be great to avoid a random global stash of crud, but it would also be nice to be able to easily avoid expensive logging.

For example, I think I'm a bit more comfortable with the following diff, which allows a user to override logging of progress events by specifying a new destination (which could just discard the logged records; I suppose in that case we might want a clearer way to "disable" to prevent the formation of the events in the first place).
--- a/timely/src/progress/broadcast.rs
+++ b/timely/src/progress/broadcast.rs
@@ -38,6 +38,13 @@ impl<T:Timestamp+Send> Progcaster<T> {
             identifier: channel_identifier,
             kind: crate::logging::CommChannelKind::Progress,
         }));
+
+        // If progress logging is enabled, route messages there instead of to
+        // the general event logging stream.
+        if let Some(progress) = worker.log_register().get::<crate::logging::TimelyEvent>("timely/progress") {
+            logging = Some(progress);
+        }
+
         let worker_index = worker.index();
         let addr = path.clone();
         Progcaster {

This would allow folks to opt out of feeding the events to the logging stream, but not opt out of the cost of generating the events.
Ignoring ergonomics, the logging options may look a fair bit like the recently added Config stuff, which maps strings to Box<Any> types, which can then be downcast to e.g. Logger types among others. That would allow more general instructions, like expecting an Option<Logger> to signify either a new destination or an explicit nothing to avoid producing the event (i.e. a disabled logger). It would be great to avoid a random global stash of crud, but it would also be nice to be able to easily avoid expensive logging.

Okies, I think technically this bounces back to @utaal for thoughts, but as most of the PR is now his maybe there isn't much to say.

Okies, I think technically this bounces back to @utaal for thoughts, but as most of the PR is now his maybe there isn't much to say.


Document new rules for seccomp profile

Describe the proposed changes
Document new seccomp rules from https://github.com/docker/docker/pull/29076/
Unreleased project version
Engine 1.14
Related issue or PR in another project
https://github.com/docker/docker/pull/29076/files
Please take a look
@justincormack @riyazdf
Can you also please clarify the version where this will land? I've put 1.13 for now...

Deploy preview ready!
Built with commit 1a8aa033523e12572a61c2664a0ecdda53238be9
https://deploy-preview-776--docker-docs.netlify.com

Also I think this change is landing in 1.14, @justincormack can confirm

@mstanleyjones: we cherry-picked the change for 17.03, so can we release these earlier?


Improve database builder

Right now there are only a couple of available database types. Weirdly enough they are called TableRow — I don't know what I thought when building it 😅 We'll need to refactor a couple of things:

Obviously "row" isn't the right term. Let's call them DataType instead.
We'll need to add types on a per-driver basis, or find another way to support different syntax between at least MySQL and SQLite. My thought is that we split DataType config and translation to SQL into two separate concerns. We'll need a translator per driver, and each translator will need to support all data types, or know how to deal with them if some types are not supported.
We'll need to support a bunch of types:

[ ] IdType
[ ] TextType > make configurable normal or long
[ ] IntType > make configurable tiny, small, normal, big, unsigned
[ ] FloatType > make configurable unsigned
[ ] ForeignType — which references a column on another table
[ ] JsonType
[ ] UuidType
[ ] Blob/BinaryType
[ ] …

Closing for #80


Webpack - Critical dependency: the request of a dependency is an expression with 2.25.0

This morning I upgraded moment from 2.24.0 to 2.25.0 and started getting this warning from my Webpack build :
Critical dependency: the request of a dependency is an expression
Versions I'm using :
gulp - 4.0.2
webpack - 4.43.0
babel - 7.9.6
No other updates occurred in between. Only moment.js got updated and the warning appeared.

same issue

same issue
after installing moment in laravel vue app.
ARNING in ./node_modules/moment/src/lib/locale/locales.js 78:12-82:13 Critical dependency: the request of a dependency is an expression  @ ./node_modules/moment/src/lib/locale/locale.js  @ ./node_modules/moment/src/moment.js  @ ./resources/js/app.js  @ multi ./resources/js/app.js ./resources/sass/app.scss

Same here, locking the package version to 2.24.0 helps for now...

Same problem over here!

same

I have had the same issue! Locked mine to 2.24.0 and fixed my build

Seconded

Same here. 2.25.0 gives this issue but not 2.24.0. Changes at 2092:16-2096:17 is the root.

Same issue, but strangely only when running as dev (this is a nuxt project) The issues seems to be in src/lib/locale/locales.js line 78 - 82,
Changing:
aliasedRequire(
                (typeof __dirname !== undefined ? __dirname : '.') +
                    '/locale/' +
                    name
            );

to:
aliasedRequire('../locale/' + name);

Fixes the issue for me

I get it both on dev and prod builds with my setup.

Same here, locking the package version to 2.24.0 helps for now...

Yeah, that's the obvious workaround, but not really a solution :-).

I am also getting the same warning and runtime I am getting following console errors, in web browser for angular application.
ERROR TypeError: __WEBPACK_IMPORTED_MODULE_2_moment__ is not a function
    at LmsChallengeComponent.webpackJsonp.../../../../../scadminapp/app/admin-page/lms-challenge/lms-challenge.component.ts.LmsChallengeComponent.getMinDate (main.bundle.js:11539)
Show 102 more frames

same here

Confirmed as well

Wait a second -- this is warning, not an error. Does it still produce a bundle?

With moment 2.25.0:
% ./node_modules/.bin/webpack
Hash: 42b60d02778538c038dc
Version: webpack 4.43.0
Time: 497ms
Built at: 05/01/2020 4:56:43 PM
    Asset      Size  Chunks             Chunk Names
bundle.js  72.2 KiB       0  [emitted]  main
Entrypoint main = bundle.js
[13] ./node_modules/moment/src/lib/units/month.js + 1 modules 9.92 KiB {0} [built]
     |    2 modules
[26] ./node_modules/moment/src/lib/create/valid.js + 1 modules 1.88 KiB {0} [built]
     |    2 modules
[36] ./node_modules/moment/src/lib/create/from-anything.js + 8 modules 25.1 KiB {0} [built]
     |    9 modules
[46] (webpack)/buildin/harmony-module.js 573 bytes {0} [built]
[47] ./node_modules/moment/src/lib/locale sync 160 bytes {0} [optional] [built]
[48] ./src/index.js + 54 modules 84.6 KiB {0} [built]
     | ./src/index.js 62 bytes [built]
     |     + 54 hidden modules
    + 43 hidden modules

WARNING in ./node_modules/moment/src/lib/locale/locales.js 78:12-82:13
Critical dependency: the request of a dependency is an expression
 @ ./node_modules/moment/src/lib/locale/locale.js
 @ ./node_modules/moment/src/moment.js
 @ ./src/index.js

WARNING in configuration
The 'mode' option has not been set, webpack will fallback to 'production' for this value. Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/configuration/mode/

And it works.
With<EMAIL_ADDRESS>% ./node_modules/.bin/webpack
Hash: c16dbd62d51ed42203b2
Version: webpack 4.43.0
Time: 559ms
Built at: 05/01/2020 4:58:27 PM
    Asset     Size  Chunks                    Chunk Names
bundle.js  263 KiB       0  [emitted]  [big]  main
Entrypoint main [big] = bundle.js
[128] ./src/index.js 62 bytes {0} [built]
[129] (webpack)/buildin/module.js 497 bytes {0} [built]
[130] ./node_modules/moment/locale sync ^\.\/.*$ 3 KiB {0} [optional] [built]
    + 128 hidden modules

WARNING in configuration
The 'mode' option has not been set, webpack will fallback to 'production' for this value. Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/configuration/mode/

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  bundle.js (263 KiB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  main (263 KiB)
      bundle.js

WARNING in webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/

And it still works.

Wait a second -- this is warning, not an error. Does it still produce a bundle?

Yes, it does.

I'm also seeing this, but only in production builds via our CI.

@jontybrook I was seeing the same behavior but after nuking node_modules folder, I was able to reproduce this locally.

The code with __dirname which was fixing an issue for react-native had to be reverted so that you (webpack users) can look at a better console output.
Fixed in 2.25.1

This has nothing to do with better console output...but rather less than ideally tested code breaking builds for MANY MANY people!

Glad to hear its been fixed and published minutes ago though - spent the last many hours digging into on our end trying to find the cause

This has nothing to do with better console output...but rather less than ideally tested code breaking builds for MANY MANY people!

Exactly ! Warning today is a potential error tomorrow.

It was much worse than a warning...if you by chance were running moment-timezone which dynamically pulls in latest version of moment, this caused a full breaking of code!

Wait a second -- this is warning, not an error. Does it still produce a bundle?

If only producing a bundle was the only desired result...

The code with __dirname which was fixing an issue for react-native had to be reverted so that you (webpack users) can look at a better console output.
Fixed in 2.25.1

Why the sarcasm ?! Clean output is important. In my setup I’ve put stats and metrics which are important for me and flooding it with unnecessary stuff makes it tiresome to read and slows my work at the very least. Then it comes the fact that a warning is always something that should not be ignored in the long term. Last, but actually first - it turns out to be really breaking for some setups as @agrohs  reported. So ... sarcasm is not well placed here I beleive. Thanks for fixing it, though.

Glad to see this fixed. Will continue with 2.24.0 till a later version or may keep it... took way too long to figure out why our web app was broken this morning after a deploy.
"You" webpack users... aka a large portion of web app developers. We don't currently have any extra data coming from our webpack process, so I don't want to look at better console output, I just want it to work.

Still causing issues: https://github.com/moment/moment/issues/5472

https://github.com/moment/moment-timezone/issues/837

https://github.com/moment/moment/issues/4216

The code with __dirname which was fixing an issue for react-native had to be reverted so that you (webpack users) can look at a better console output.
Fixed in 2.25.1

Sarcasm aside, v2.25.1 doesn't actually fix anything (the Module not found warning is still there).  I typically refrain from being critical of open source contributors who are volunteering their time, but please don't have an attitude towards users who are simply reporting issues.  And yes, warnings are there for a reason.  Ignoring them obscures all sorts of other info and usually leads to something broken down the road.

This issue should not be closed...it is a breaking change for moment-timezone users who are using webpack, not just an issue of showing a warning (and affecting an enormously large number of people)

same problem
not fix 2.25.0
not fix 2.25.1
not fix 2.25.2
I want you to revert to the original version.

Guy this is not fixed! Can we not close defects until they are resolved especially when they break existing builds such as Webpack?!

Hi, BUMP!, this is braking my build also, not fixed!.

I just update moment with npm i moment and it solved it

Same issue, but strangely only when running as dev (this is a nuxt project) The issues seems to be in src/lib/locale/locales.js line 78 - 82,
Changing:
aliasedRequire(
                (typeof __dirname !== undefined ? __dirname : '.') +
                    '/locale/' +
                    name
            );

to:
aliasedRequire('../locale/' + name);

Fixes the issue for me

Thanks, this really helped me!!!


Use queue.Queue().get() rather than queue.Queue().get_nowait()

I tested the following and the CPU load remains close to zero:
from queue import Queue
print(Queue().get())


Remove the current GdkPixbuf plugin

Its authorship is not entirely clear and the plugin might benefit from
its incoming rewrite anyway.

Can we first have an alternative implementation and then remove?

I'm ok to remove now

Could the headers be restored (from the FLIF version) and the plugin be sent upstream to the GTK folks?  It's only really useful when combined with their code anyway.

It is not a lot of work to write a new one from scratch anyway.

I believe given #519 we don't need this anymore.


"Access was denied. You may have entered your credentials incorrectly, or you might not have access to the requested resource or operation."

Regardless on the Bing API Key provided the error message I get is, have created a couple different keys with no luck
"Access was denied. You may have entered your credentials incorrectly, or you might not have access to the requested resource or operation."

This seems to have resolved itself not sure maybe my key was in a pending state

How much time did it take btw?

This seems to have resolved itself not sure maybe my key was in a pending state


Prepare Release 2.15.0

Feature or Bugfix

Release

Detail

Drop Python 3.6
Unpin Pandas to allow 1.4.0 and above
Arrow 7.0.0
Bump2Version
XFail pandas index tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 087a081e0d08696715ad7763ecb606062d8134e3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Object returned onBlur vs Event?

Is it possible to return the same Object onBlur as is returned from the onChange event?
onBlur returns an Event, eg:
Event {isTrusted: false, type: "react-input", target: react, currentTarget: react, eventPhase: 2…}
onChange returns an Object, eg:
Object {name: "shipping_id", search: true, placeholder: "Shipping method", defaultValue: 1, options: Array[2]…}
My use case for this is that I'd like to save form updates when the user is done typing with onBlur and not hitting my API on every keystroke with onChange.
That or I'm missing how to get the form data from the onBlur event?
Testcase
http://codepen.io/searleb/pen/KNJWGd

We only add the second data object to callbacks that we explicitly handle.  There a lot of event handlers one might add, so I don't think it is reasonable to add all the potential callbacks to all components (which would be required to pass back the data object).
That said, we only added this extra object as many components have callbacks for which there is no SyntheticEvent nor DOM event to send back.  In that case, you are flying completely blind.  We added the data parameter there as a stop gap until React someday allows dispatching custom SyntheticEvents.
What are you to do if there is no data object?  The same as you would do with vanilla React.  In this case, you should be capturing the value with onChange and then, onBlur, you can post that data to your server.

@levithomason Thanks for the super fast reply!

In this case, you should be capturing the value with onChange and then, onBlur, you can post that data to your server.
I hadn't thought of that taking that approach, thanks for the insight 👍

No problem!

Just for future reference if anyone else comes across this problem, it ended up being simpler than I thought:
 handleOnBlur = ({ currentTarget }) => {
    const data = {
      name: currentTarget.name,
      value: currentTarget.value,
    }
    someFunction(data)
  }

<Form.Input
  type='text'
  name='myInputField'
  onBlur={this.handleOnBlur}
  placeholder='Some input field'
/>