Upgrade version of grpc-bom to 1.43.2 , protobuf to 3.19.2

Motivation:

To use latest versions of protobuf
To those who use kotlin dsl (https://github.com/grpc/grpc-kotlin), it helps to get protobuf associated changes for that

Modifications:

Upgrade version of grpc-bom to 1.43.2 , protobuf to 3.19.2

Result:

grpc libraries upgraded to version 1.43.2
protobuf libraries upgraded to version 3.19.2

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

why is there no CI jobs triggered for this change @ikhoon @jrhee17 @minwoox @trustin

Thanks for your contribution, @gurudatta-carbon. Let me merge once the build passes. :slightly_smiling_face:


Lazily load the debug gem

Fixes #291
Lazily load the debug gem in order to mitigate issues with docker environments such as dip.
Backport the port configuration so it allows overriding.

Looks simple and nice!

Apologies for my slow response. This looks great! Thank you!


#683 remove results folder and link to new repo

Description
Remove results folders and add some lines to READMEs to link to the new repo of results.
See new results repo here
Fixes #683
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[x] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[ ] No style issues: $ flake8
[ ] All tests pass: $ python run-tests.py --unit
[ ] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

in the new results repo the line "- Specify (in your README) the PyBaMM version number or commit hash with which your repository works" looks to be written as code rather than text


how to set the number of the ticks

I used .ticks(). But it doesn't work.

Please read the instructions in the issue template if you would like to report an issue or ask for help.


Font Awesome Angular library (angular-fontawesome)

I propose to use @fortawesome/angular-fontawesome instead of @fortawesome/fontawesome-free
https://www.npmjs.com/package/@fortawesome/angular-fontawesome
This library provides an Angular component that allows to add icons like this...
<fa-icon [icon]="['fas', 'fa-music']"></fa-icon>

...instead of this:

The advantage of this library is that it provides the Auto Accessibility feature.
In order to make current icons accessible, without the alternative libraty, we would need to add either a title attribute or aria-hidden="true" to each icon.
The library can be used alongside the current one, so we won't need to migrate all the icons in one shot.

For what it's worth, this seems reasonable to me @davide-negretti , especially since @fortawesome/angular-fontawesome seems to be an official Angular version from the same team that provides Font Awesome.
Personally, though, if possible, I'd recommend changing over all at once.  I'd rather not keep two similar dependencies around for very long, as it encourages developers creating new PRs to continue to use @fortawesome/fontawesome-free.
In any case, this needs a volunteer.

Hi, I want to ensure that we're all aligned on the changes that need to be implemented. Could you @tdonohue please let me know if you're already aware of these proposed modifications? I've detailed the necessary changes below for your convenience.
At present, we're utilizing @fortawesome/fontawesome-free. In the src/styles/helpers/_font_awesome_imports.scss file, we import four different SCSS files associated with FontAwesome. This method employs FontAwesome's font approach, which allows us to use icons in a straightforward manner, like so:

The above code is rendered as:

However, we're considering migrating to @fortawesome/angular-fontawesome, which uses an SVG approach instead of fonts. This requires us to register the FontAwesomeModule and each icon we intend to use, as shown below:
@NgModule({
  declarations: [
    AppComponent,
  ],
  imports: [
    ...IMPORTS,
    FontAwesomeModule,
  ],
  providers: [
    ...PROVIDERS,
  ],
  bootstrap: [AppComponent],
})
export class AppModule {
  constructor(library: FaIconLibrary) {
    library.addIcons(faSearch); // Each icon we want to use in the application should be registered here
  }
  ......
}

With this setup, we can use a component-based approach to add an icon in the template:
<fa-layers [fixedWidth]="true">
  <fa-icon [icon]="['fas', 'search']" size="lg"></fa-icon>
</fa-layers>

The above code is rendered as:
<fa-layers _ngcontent-dspace-angular-c347="" class="ng-tns-c347-7 fa-layers fa-fw" ng-reflect-fixed-width="true">
  <fa-icon _ngcontent-dspace-angular-c347="" size="lg" class="ng-fa-icon" ng-reflect-size="lg" ng-reflect-icon="fas,search">
    <svg role="img" aria-hidden="true" focusable="false" data-prefix="fas" data-icon="magnifying-glass" class="svg-inline--fa fa-magnifying-glass fa-lg" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
      <path fill="currentColor" d="M416 208c0 45.9-14.9 88.3-40 122.7L502.6 457.4c12.5 12.5 12.5 32.8 0 45.3s-32.8 12.5-45.3 0L330.7 376c-34.4 25.2-76.8 40-122.7 40C93.1 416 0 322.9 0 208S93.1 0 208 0S416 93.1 416 208zM208 352a144 144 0 1 0 0-288 144 144 0 1 0 0 288z"></path>
    </svg>
  </fa-icon>
</fa-layers>

Let me know if you have any questions.

This looks like a significant improvement in accessibility.  Yes, please.
The need to declare each icon is a minor inconvenience for developers, but also provides a place to see which icons are already in use when pondering how to pictorialize a UI feature, as well as making the code easier to understand.

@pcg-kk : At a glance that sounds reasonable.  However, I do want to note that I'm not sure whether we'll have time to add this into DSpace 8.0.  We have already passed the Feature deadline and our 8.0 Testathon starts next week.  See the 8.0 release timeline.
If the scale of the changes here are very large (and they sound like they might be), then it may be difficult to get them tested/approved for the 8.0 final release.  That said, we can do our best.  If it doesn't make it into 8.0, then the developer team can discuss how best to move this forward and whether it could go into a 8.1 or if it needs to wait for 9.0.
In any case, you are welcome to start working on this, and I can find volunteer reviewers once it is ready for review/testing.

All occurrences of FontAwesome icons are replaced by a new library except for the dynamically declared icons. I would like to propose splitting those dynamics into a separate PR because it will be easier for the reviewer to check all "just replacements" and then the logical changes. WDYT @tdonohue  ?
If you accept this idea to split this task into 2 separate ones, I can prepare the next one immediately after merging this one. Or if you prefer to remove the old font-awesome completely in this one task & PR I need one day more to finish it.


Discuss how to make it easier to debug when executors die because of memory limit

@foxish
I was doing the HDFS-in-K8s experiment using Spark TeraSort jobs. It turned out the default memory size for executors, which is 1 GB per executor, is way too small for the workload.  I ended up specifying 6 GB per executor.
Learning the root cause was a painful process though. Because there is no easy way to see why the JVMs get killed. It does not show up in $ kubectl log of executor pods. I show a glimpse of that only in the Kubernetes dashboard UI when I was visiting the pod page at the right time.
I wonder if there is a better way. I hear a lot that Spark uses lots of memory depending on applications. I fear many people have to go through this troubleshooting without much help.

Is it the pod getting OOMKilled by Kubernetes, or is this happening within Spark?

I think it's Kubernetes. (I think I saw "OOM Kill" in the Kubernetes Dashboard UI, but I am not quite sure again because it was hard for me to find the clue). I also was doing $ kubectl logs -f executor-pod when executors get killed and I didn't see any log message indicating it's Spark.

@varunkatta I see #244 handling VMEM_EXCEEDED and PMEM_EXCEEDED. Maybe these are the symptom of OOMKilled by Kubernetes? Maybe we just need clear log messages in the driver?

Sometimes it's killed by JVM java.lang.OutOfMemoryError.  And the message is present in driver log.
17/06/29 01:54:39 WARN KubernetesTaskSetManager: Lost task 0.0 in stage 2.0 (TID 4, <IP_ADDRESS>, executor 1): java.lang.OutOfMemoryError: Java heap space        at scala.reflect.ManifestFactory$$anon$2.newArray(Manifest.scala:177)        at scala.reflect.ManifestFactory$$anon$2.newArray(Manifest.scala:176)        at org.apache.spark.util.collection.KVArraySortDataFormat.allocate(SortDataFormat.scala:109)        at org.apache.spark.util.collection.KVArraySortDataFormat.allocate(SortDataFormat.scala:86)        at org.apache.spark.util.collection.TimSort$SortState.ensureCapacity(TimSort.java:951)


GitLab : CLA enforced project MR is not gated

Steps :

Go to PCC --> Add GitLab Group
CLA enforced GitLab group
Go to GitLab project & create Merge request

Actual Results : Merge request is not gated
Refer Video clip :
https://images.zenhubusercontent.com/194341141/f241a46e-8b80-49be-82cd-10f3c7b886c7/mr_not_gated_.mp4

Issue is not reproducible as reported, Seems it fixed automatics with fixes of issue #3244 & #3239, So making issue status QA-Done
https://images.zenhubusercontent.com/194341141/e7eacb67-cfc2-47d2-8e6c-a66198494b13/_3239.mp4

Issue is again reproducible while it working fine early morning
Moving issue status to Rejected by QA

Project : https://pcc.dev.platform.linuxfoundation.org/project/a092h000003hptEAAQ/tools/easycla/repositories/a092h000003hptEAAQ#76bdcbf6-a6a5-4e4f-b4f5-6a9fa72613f2

GitLab Group : veergitlabmailtestgroup

MR : https://gitlab.com/veergitlabmailtestgroup/test/-/merge_requests/2

Refer Video clip :
https://images.zenhubusercontent.com/194341141/e99f7104-b5b1-4799-82ab-50a00e196b15/mr_not_gated___1_.mp4

Issue is tested on reported GitLab group & found that MR are gated as expected, So moving issue status QA-Done


.env file setup but test e-mail returning "Unable to connect to localhost:587"

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
I am using docker compose to spin up a bookstack instance.
I have the below .env file
MAIL_DRIVER=smtp
MAIL_HOST=smtp.gmail.com
MAIL_PORT=587
MAIL_ENCRYPTION=tls
<EMAIL_ADDRESS>MAIL_PASSWORD=pwd
<EMAIL_ADDRESS>MAIL_FROM_NAME=Recipes

I restarted the container  but when I try a test, I get
Error thrown when sending a test email: Connection could not be established with host "localhost:587": tream_socket_client(): Unable to connect to localhost:587 (Address not available)
I would have thought  should be seeing a reference to gmail.com in the error which leads me to think that the .env file is not being referenced.
Exact BookStack Version
BookStack v24.02.3
Log Content
docker logs container-id did not return anything.
Hosting Environment
Ubuntu 22.04.4
Docker 25.0.4
Docker Compose version v2.3.3

Hi @ZuluPilgrim,
Just to confirm, Where is this .env file you're editing? Did you create this file?

Hi @ssddanbrown
I created the file in the same folder as the docker-compose.yml file

@ssddanbrown Have I missed something above?

Hi @ZuluPilgrim,
That .env file won't do anything unless you're somehow importing that into config.
Assuming you're using the linuxserver.io docker image, I would guess you'd find you .env file at recipes_app_data/www/.env.

Ah, another lightbulb moment :) Sorry, I think I now finally understand docker :)


Sc-5716 : set threshold code coverage

Scope of changes
Sc-5716 : set threshold code coverage
Type of change

[x] bug fix
[ ] new feature
[ ] documentation
[ ] other (describe)

Acceptance criteria
Sc-5716 :  set threshold code coverage
Author checklist

[x] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[x]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[ ]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report

Merging #550 (95dc60c) into main (ea03d7a) will decrease coverage by 7.76%.
The diff coverage is n/a.

:exclamation: Current head 95dc60c differs from pull request most recent head 3462d70. Consider uploading reports for the commit 3462d70 to get more accurate results

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   45.23%   37.47%   -7.77%
==========================================
  Files         479      152     -327
  Lines       13913     2391   -11522
  Branches     1082      608     -474
==========================================
- Hits         6294      896    -5398
+ Misses       6638     1320    -5318
+ Partials      981      175     -806

Impacted Files
Coverage Δ

...ds-user-ui/src/components/Header/LandingHeader.tsx

web/gds-user-ui/src/layouts/LandingLayout.tsx

.../gds-user-ui/src/layouts/SimpleDashboardLayout.tsx

web/gds-user-ui/src/modules/auth/login/index.tsx

web/gds-user-ui/src/utils/theme.ts

web/gds-user-ui/src/layouts/FormLayout.tsx

...acrypto/directory/pkg/gds/store/leveldb/leveldb.go

...er-ui/src/components/Sidebar/MobileNav.stories.tsx

...eb/gds-user-ui/src/components/Icon/EllipseIcon.tsx

web/gds-user-ui/src/utils/utils.ts

... and 317 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea03d7a...3462d70. Read the comment docs.


Fix sampling on demo host and document Linux setup

There is no demo host right now and the single-node deployment is documented. Closing for now :)


Change the UX a bit if we are in single mode

If we are in "single" mode I think we can remove the "external X" at all.
Or maybe we can remove (or change a little) the UI for the single mode and remove the "tag" x.
I don't know, but both together is strange.
And even the 1/1. I know we can remove it with maxSelectMsg={() => ""} but maybe is unnecessary.

I don't know, but both together is strange.

Agreed. I think removing the outer "remove all" button in single mode is easier but maybe removing the "tag" cross icon looks better. Need to think about it.

And even the 1/1. I know we can remove it with maxSelectMsg={() => ""} but maybe is unnecessary.

Good point, will do that tomorrow.

Something like this for inspiration:
https://vue-select.org/


Support for Swift Package Manager

Adds support for Swift Package Manager. Picking up where #73 left off. Closes #67.

hey @wzrad
I fixed my PR #73
Apologies for the delay. As noted in my last comment, DVR still won't work in running tests from the command line with the swift cli until SPM supports bundling non Swift resource files (i.e. the JSON that DVR uses for fixtures).
Wanna upvote these two (duplicate) tickets on SPM?
SR-2866
SR-4725

@loudmouth
awesome, i will close this then :)


[QUERY] We are not able to get the method to retrieve files or folders within the backed up recovery point ?

Library name and version
Azure.ResourceManager.RecoveryServicesBackup 1.0.0
Query/Question
We used below code to get the fileshare recovery point data, now we need to get files or folders  that are backed up within this fileshare recovery point.
Could you please help us ?
ResourceIdentifier backupProtectedItemResourceId = BackupProtectedItemResource.CreateResourceIdentifier(subscriptionId, resourceGroupName, vaultName, fabricName, containerName, protectedItemName);
BackupProtectedItemResource backupProtectedItem = client.GetBackupProtectedItemResource(backupProtectedItemResourceId);
            BackupRecoveryPointCollection collection = backupProtectedItem.GetBackupRecoveryPoints();

            await foreach (BackupRecoveryPointResource item in collection.GetAllAsync())
            {
                FileShareRecoveryPoint resourceData = (FileShareRecoveryPoint)item.Data.Properties;
            }

Environment
No response

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Thanks

Hi @ArthurMa1978 @jsquire ,
Any update on this query ?
Thanks in advance.

@pksouza23: Unfortunately, I have no insight.   We'll need an update from @ArthurMa1978 and team.

Hi @pksouza23 , Thank you for using Azure SDK for .NET.
Looks like this is beyond our Mgmt SDK coverage, more like a Data operation, or the service team will know the API for this.
The best operation I could offer is try to catch the traffic of those portal operation.
I got one
Request:
https://sdktest1113.file.core.windows.net/sdktest1113?restype=directory&comp=list&prefix=&sharesnapshot=2023-11-13T08%3A46%3A49.0000000Z&marker=&maxresults=30&_=1699867709194&sv=2022-11-02&ss=bqtf&srt=sco&sp=rwdlacuptfxy&se=2023-11-13T17:12:30Z&sig=<Sanitized>
Response:

Looks like the request is conbine of FileShareSnapshotUri and access token.
And the response is a XML formatted file list you needed.
But how to use it in our SDK is out of my domain knowledge.

During the restore for AFS, portal uses storage API to browse snapshots. Please refer to API here https://learn.microsoft.com/en-us/rest/api/storageservices/list-directories-and-files

Thank @Daya-Patil for the answer, based on the provided API, the corresponding method in Data SDK was found. @pksouza23  please check: https://learn.microsoft.com/en-us/dotnet/api/azure.storage.files.shares.sharedirectoryclient.getfilesanddirectories?view=azure-dotnet#azure-storage-files-shares-sharedirectoryclient-getfilesanddirectories(system-string-system-threading-cancellationtoken)


Using relationships

I have a News and NewsCategories models which I have generated CRUD for using the relationship option.
I now need to generate a select list for the News model to select the NewsCategory it belongs to.
I know how to do this in the model but no idea how to do it using the repository pattern.
I can't see any examples in the docs so any help with this would be appreciated.
Thanks

you are right  but it's a about l5-repository there's no such a thing like pluck or list. so we've to mention that to them not here I think

This is getting old but I've seen l5-repository documentation and the query has to be built like this:
api/resourceA**?with=resourceB**
This is the case of a 1-N relationship
This works when requesting a list of resourceA and could work when selecting an item (api/resourceA/1?with=resourceB) but the generated API Controller show() method needs some changes as follows:
public function show(Request $request, $id) //Added $request param
    {
        $this->fileRepository->pushCriteria(new RequestCriteria($request)); //Added RequestCriteria
        ....

That's it! That worked but I didnt run any tests. I believe this change should by added to the apicontroler template.

@perezale that can be the solution. But still not sure what and how it needs to be displayed in the table. so can not comment much. But I think it's too old and maybe some solution is already developed then. so closing it.
Even from laravel 5.8, we have a base repository published and no more dependent on l5-repository, since it not active for a long time and planning to add our customizations there.


Error out if publicHeadersPath is absolute

Before we were running into a precondition in RelativePath.
rdar://problem/52811361

@swift-ci please smoke test

Can you add a unit test? It'll probably go in PackageBuilderTests.

@swift-ci please smoke test

@swift-ci please smoke test

Hm
--- bootstrap: error: tests failed with exit status 1
Building the standard library for: swift-stdlib-macosx-x86_64
Running Swift tests for: check-swift-validation-macosx-x86_64
/Users/buildnode/jenkins/workspace/swift-package-manager-PR-osx-smoke-test/swift/utils/build-script: fatal error: command terminated with a non-zero exit status 1, aborting
/Users/buildnode/jenkins/workspace/swift-package-manager-PR-osx-smoke-test/swift/utils/build-script: fatal error: command terminated with a non-zero exit status 1, aborting

I don't see any test failures or actual error messages.

@swift-ci please smoke test

Ah some tests were crashing:
Precondition failed: file /Users/neonacho1/Projects/swiftpm-public/Sources/Basic/Path.swift, line 632
Exited with signal code 4```

I'm undoing the precondition change.

@swift-ci please smoke test

@neonichu this would be reasonable for cherry picking into 5.1


Error: shrink: parameter hshrink not set

I have a 1x256 image that I am trying to crop to a 1x1 image using the attention strategy.
Image is here:
https://padlet-assets.s3.amazonaws.com/wallpapers/violet.png
This is how I am doing it:
const fs = require('fs');
const sharp = require('sharp');

const img = fs.readFileSync('violet.png');

console.time('violet');
sharp(img)
  .resize(1, 1)
  .crop(sharp.strategy.attention)
  .toBuffer()
  .then(() => console.timeEnd('violet'));

I get the following error
(sharp:64338): GLib-GObject-WARNING **: value "0.031250" of type 'gdouble' is invalid or out of range for property 'hshrink' of type 'gdouble'
Error: shrink: parameter hshrink not set

Did you see #1003?

I did. In this case, though, I'm specifying a 1x1 dimension for the target image. In both #1003 and #767, it seems like the target dimensions were going to be sub 0.5. Why would that happen here?

Hello, this fails in v0.18.4 but works with the forthcoming v0.19.0 suit work-in-progress branch so it looks like https://github.com/lovell/sharp/pull/977 dealt with this.


[CP Staging] fix unable to add assignee when creating a task

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/34518
PROPOSAL: https://github.com/Expensify/App/issues/34518#issuecomment-1892541469
Tests
Same as QA step

[ ] Verify that no errors appear in the JS console

Offline tests
Same as QA step
QA Steps

Go to FAB > Assign task
Fill in the Title and Description fields
Click Next
Click on the Assignee field
Try adding any member
Verify that assignee is selected
Create task
Click on the Assignee field on task view
Try updating any member
Verify that assignee is updated

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/97676131/0208fd69-b374-423a-bbb7-f8f23b9376a9

Android: mWeb Chrome
https://github.com/Expensify/App/assets/97676131/6d9f55e5-b638-49d7-9d65-ce069791dd18

iOS: Native
https://github.com/Expensify/App/assets/97676131/da3c0456-0c5b-4187-b969-ea601524c4e8

iOS: mWeb Safari
https://github.com/Expensify/App/assets/97676131/c497dbe9-8e44-4258-8f67-b64feaa67b21

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/97676131/64132515-acd0-4d8a-9c52-736133373cdf

MacOS: Desktop
https://github.com/Expensify/App/assets/97676131/8b20c57f-42b5-4832-9644-766c991a8874

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@akinwale I'm going to forego C+ review here

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 1.4.25-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.25-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Helm upgrade produces : unable to upgrade connection: Unauthorized

Hello
I need your help to resolve issue with SSL certificates.
I have produced my own SSL certificates for K8S cluster. Ininitalization of K8S cluster runs without problem and all PODs in kube-system namespaces are up and running, everything seems to work correctly.
But when I am trying to run helm deployment it throws me following error:
helm upgrade --install --reset-values prom-helmf-ns-monitoring /tmp/kubernetes/stable/prometheus --namespace monitoring --values /tmp/kubernetes/monitoring/values/values_prometheus_ns_monitoring.yaml --values /tmp/kubernetes/monitoring/values/main_promethus_config_ns_monitoring.yaml --kube-context kubernetes-admin@kubernetes

Error: forwarding ports: error upgrading connection: unable to upgrade connection: Unauthorized

Tiller pod is up and running"
tiller-deploy-759cb9df9-rltzf                  1/1       Running   0          14m

Thanks
Output of helm version: v2.9.1"
Output of kubectl version: v1.11.0
Cloud Provider/Platform (AKS, GKE, Minikube etc.): On Premisse

Hi,
What is the fix for this issue?
Please advise!
Thanks,
Vishal

hello @vishal49naik49, I have already resolved issue. The issue was with one wrongly generated SSL certificate. Once it was repaired, everything working as expected. What issue you currently face ? Do yo need to also generate your own SSL certs ?

closing as resolved. Thanks for the follow-up.


MemoryCache Compact doesn't remove items for low percentage

If you explicitly run  public void Compact(double percentage) and your percentage calculation is less than 1 item, the Compact method will round it down to zero, and no items will be removed.
e.g.
Count = 10
Percentage = 0.05 (the default CompactionPercentage)
no items will be removed. IMO at least a single item should be removed.
this is rooted in the following code (MemoryCache.cs)
int removalCountTarget = (int)(_entries.Count * percentage);
(int) will round down any number lower than 1.
I think either Math.Ceiling can be used, or even better, to keep exiting behavior similar,
int removalCountTarget = Math.Max(1,(int)(_entries.Count * percentage));
Thanks!
Amit

That would only make sense if the result was anywhere close to 1 already. e.g. should 1% remove 1 of 10 items (10%)? Should 25% remove 1 of 1 items (100%)?
This is a mute point though. How many items do you normally expect to store in the cache? More than 20 I'd guess, so 5% would already remove at least one.

I understand your point, though IMO it doesn't matter how close it is. and it's true that if you are using a large enough cache, the issue won't manifest, but it's still hidden there.
I still think the expected behavior is to remove a single item as long as the percentage > 0

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


[Test] Filter out further symbols now visible on Linux

CentOS has a whole bunch of new std::string symbols that are now visible. Filter them all out.

I think it makes sense to do this to get things passing, but CentOS is always added a whole slew that is different from the Debian ones. We should really see if we can get away with something like -fvisibility=hidden and -fvisibility-inlines-hidden to reduce this spew.

Sounds good, I'll give that a go in the background next week. Hopefully this is the last set 😆. There might be more from remotemirror too...


esmodule ways not work

This was example for old webpack/babel. I have removed this info from website


http doesn't repeat a url fetch of the same url

Expectation - this chunk of code retrieves new values every 10 seconds.
search
[#time seconds]
0 = mod[value: seconds, by: 10]

commit @http
[#request #melete-latest url: "http://foo/getlatestevents"]

Actual result - it only runs once and never again.
This worked around the problem (but will fail tomorrow).
search
[#time hours minutes seconds]
0 = mod[value: seconds, by: 10]

commit @http
[#request #melete-latest url: "http://foo/getlatestevents?{{hours}}{{minutes}}{{seconds}}"]

My assumption is that since the request commit was non-unique no further event fired to actually call the url?
This makes sense in eve but I don't think it does when interacting with an api that is going to the outside world.

Also the requests don't get garbage collected, they seem to just build up over time.

One work around that wouldn't fail tomorrow would be to use timestamp instead, and do the same thing you did here.
But to address the point, maybe @http needs some logic where a request is deleted after a response is received? I'm afraid I don't know enough about the protocol though to know all of the gotchas involved.

The database already adds a #handled flag that states it has been seen and actioned by the database. This only happens if the #request and url attribute is present. You can use this or the response attribute that is written to separate the completed requests.
If you inject identity on creation it will run again, and there are various ways to handle both injecting identity and cleaning up the records afterwards if necessary.
Regards,
Cormac.

1- So I'd lean towards the @http tool to inject the unique values under the covers, given that http endpoints will almost always have these issues ie url is static but the data coming from it is changing constantly.
2- The cleanup also seems like something that the api should handle after a configurable amount of time.
I can also see another answer which runs along the lines of this change of behavior would be undesirable because it's different from other parts of eve.
It seems like this exact issue will come up with something like a call to a sql database, so it seems a more general pattern for these issues will need to be laid out or at least clearly documented api by api.
Thank you for the workaround advice, I'll probably try to garbage collect and work the timestamp in tonight.


Save to latest table aswell

Following from https://github.com/openclimatefix/nowcasting_datamodel/issues/2
We should save forecasts to the latest table too.
This will make it easier to load all results.
For this repo, should just need to bump nowcasting_datamodel version

Deployed in 1.1.1


Overridable deployment timeout

We need to be able to set a longer deployment timeout for certain applications. Therefore, we need a way to override the default deployment timeout.

Sorry for the noise, wanted to open a PR on the fork first.


flag on config to allow singleton factories per config object

useful for tests, along with a memo-ized config.

Ship it


New version: maurizuki.O2 version 2.2.7

Result: Installation Failed

Manifest
Add/Remove Programs

Name
O2

Version
2.2.7

Publisher
maurizuki

ProductCode

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 4227
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Add get group count and get group endpoints to Admin API SDK

Last PR this time, I promise :)

@NikiforovAll It seems like there are no tests for IKeycloakGroupClient?

Just because no one did it :) Please feel free to add tests

This PR is stale. Closing it.


[AMORO-1857]: Check short name for principal before call constructUgi()

Why are the changes needed?
Close #1857.
Brief change log

Check short name for principal before call constructUgi()

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

There is a checkstyle problem. could you please fix it and run mvn validate before you push the code?


Atmi revision number wrong for Apt/Dpkg

atmi_0.0.1-_amd64.deb
The revision number is invalid, but you released it anyways on August 10, 2019.
http://repo.radeon.com/rocm/apt/debian/pool/main/a/atmi/
A rather absurd and unprofessional Software Quality Assurance/Build Harness review I might add.

We would love to know about any technical feedback you may have from using ATMI -- what you use it for and how we can improve it?
The above issue is known and we are fixing it for our next release. Thanks for the kind feedback.

Fixed


Remove buffering in the partials handling of u8u16 and u16u8

I'm making this a draft because @lhecker already prototyped a slightly different approach. I'd like to have him a look at this first, and if my proposal is considered to perform worse we should just close it out.

Summary of the Pull Request
Perform the handling of partial code points in the u8u16 and u16u8 conversion functions without preparation in a preliminary buffer.

References
Briefly discussed with @lhecker in #10946.

PR Checklist

[x] Closes #10946
[x] CLA signed. If not, go over here and sign the CLA
[x] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #10946

Detailed Description of the Pull Request / Additional comments
We complete the partial codepoint in the 4-bytes long cache and convert it separately. This makes the cache ready for capturing the next partials before the remaining string is converted. This way, we neither need to copy the whole string into a buffer which contains complete codepoints, nor do we need to allocate an unnecessarily long buffer which exists for the life time of the state class instance.
Additionally, the parameters for the incoming data are now explicitely declared to be referenced string_views.

Validation Steps Performed

manually tested
unit tests passed

Going to let @lhecker think about this with you before I do a more full review.

Summary of the draft updates:

cache buffers -> simple arrays
inline functions for simple string-string conversions (enable having the parameter a string_view)
never return converted partials from the cache
determine the length of the codepoint before caching partials (named bitmasks and comparison arrays not necessary anymore)

@lhecker The scope grew quite a bit. I'm going to address this in the PR description. Also - to be fair - is there any possibility of making you a co-author of this PR?

@german-one That's super kind of you!
In that case I've taken the liberty just now to add myself as Co-authored-by: Leonard Hecker<EMAIL_ADDRESS>to the PR's description, which will then be used as the commit message when this PR gets merged. 🙂
(I've also removed the <!-- ... --> comments, which aren't needed.)

@DHowett I've already had quite a lengthy discussion with @german-one in this PR which culminated in the current code. Personally I don't have any other comments and thus approved the PR. 🙂

@DHowett Notes are added.
I don't want to leave any doubt the this is merely Leonard's credit. I just had the same idea of removing the buffer.


Storing ViewModel in parent-view and wrapping in child throws error on rerender of child

When creating a ViewModel in a parent view and passing the reference to a child view which wraps it with any of the property wrappers from KMM-Viewmodel, the app crashes on a rerender of the child view with the error:
Uncaught Kotlin exception: kotlin.IllegalStateException: KMMViewModel can't be wrapped more than once

I know that the error is intentionally thrown since the stored ViewModel is already wrapped and not recreated on rerender of the child, but to me this looks like a common pattern that should be supported.
Why is it currently not supported and is it technically possible?
This is my setup, where the parent handles navigation between some screens and also holds the ViewModels for each screen.
I don't want to recreate the ViewModels on each recreation of the view, as I want to save the state between rerenders.
class NavigationViewModel: ObservableObject {
    @Published var destination: Destination = .home

    let mapVM = MapViewModel()

    enum Destination: Hashable {
        case home
        case map(MapViewModel)
        case profile
    }
}

struct MainNavigationView: View {
    @ObservedObject var viewModel: MainNavigationViewModel

    var body: some View {
        VStack {
            Group {
                // this is from the swiftui-navigation library, it just shows the view for the current `destination`
                IfCaseLet($viewModel.destination, pattern: /MainNavigationViewModel.Destination.home) { $vm in
                    HomeView()
                }

                IfCaseLet($viewModel.destination, pattern: /MainNavigationViewModel.Destination.map) { $vm in
                    MapView(
                        viewModel: vm
                    )
                }

                IfCaseLet($viewModel.destination, pattern: /MainNavigationViewModel.Destination.profile) { $vm in
                    ProfileView()
                }
            }
            .frame(maxWidth: .infinity,maxHeight: .infinity)
        }
    }
}

The Subview wraps the passed ViewModel with ObservedViewModel
struct MapView: View {

    @ObservedViewModel var viewModel: MapViewModel

    var body: some View {
        Text("SubView")
    }
}

Why is it currently not supported and is it technically possible?

While technically possible, it would require a lot of state management which is otherwise handled by SwiftUI.
The idea is that you wrap the Kotlin view model once (which the library does automates for you) and use the projected value in Swift to forward the view model to other views.
However in this case you don't have a projected value, since the view model property doesn't have a property wrapper.

I don't want to recreate the ViewModels on each recreation of the view, as I want to save the state between rerenders.

Are you able to use StateObject/StateViewModel? That would keep the state between rerenders.
Will take a look at an easy way to move the view model wrapping to a custom property.
Such that the property wrappers can skip the wrapping and prevent this error 😄.

Sorry, I used rerender a bit wrong, what I actually meant by rerender was the navigation between screens and the resulting recreation of the e.g MapView, since that calls the ObservedViewModel wrapper again.
Before I was triggering a navigation like this:
func goToMap() {
    destination = .map(.init())
}

which works fine, since the MapViewModel is always a new instance.
But know I want to navigation like this, to keep the state between navigation:
let mapVM = MapViewModel()

func goToMap() {
    destination = .map(mapVM)
}

but here the same instance get's wrapped again on each navigation, which throws the error.

Below is a simpler reproducible example:
class NavigationViewModel: ObservableObject {
    let mapVM = MapViewModel()
}

struct MainNavigationView: View {
    @ObservedObject var viewModel: MainNavigationViewModel

    @State var showChild = false

    var body: some View {
        VStack {
            if (showChild) {
                MapView(viewModel: viewModel.mapVM)
            }
            Button("Toggle child") {
                showChild.toggle()
            }
        }
    }
}

struct MapView: View {
    @ObservedViewModel var viewModel: MapViewModel

    var body: some View {
        Text("SubView")
    }
}


Better understanding Google Patents Research Dataset

Google Patents Research dataset (on BigQuery) has a table called annotations which has useful information for research. The schema of the annotations table comprises of the following columns:

publication_number
ocid
preferred_name
domain
source
confidence
character_offset_start
character_offset_end
inchi
inchi_key
smiles
conf_bucket

Most of the fields are understandable through their names and values. However, I am having a hard time figuring out what does character_offset_start and character_offset_end mean here. Intuitively, it should refer to character offset in the original patent documents (column 1) but since patents are mostly pdfs it is not very clear how to make use of it. If anyone has any idea then please share.
Thanks in advance

I sent this over email but here's the same reply if others have the same question:
No problem! Happy to help - the character_offset fields are the number of bytes from the start of the full text where the annotation is found. We get both PDF and machine-readable text from patent offices (like you see on Google Patents). The offsets won't match up exactly with the text for various reasons, but you can use the relative position and distance for other tasks such as co-occurrence within a window of characters.

Thanks a lot, @wetherbeei for your prompt reply. I can understand that Google must be using its own text extractors for pdfs so extracting the same text for using offset directly will be difficult. Sure, we will try to work with relative distances in that case.
Thanks again!


cairo_ft_* functions are assumed to be available

I believe that right now, both the -sys crate and the main crate assume that Cairo is built with FreeType support, i.e. that the cairo_ft_* functions are defined. In the main crate, these functions are used here: https://github.com/gtk-rs/cairo/blob/master/src/font/font_face.rs#L95-L105
On Windows, cairo might not be built with FreeType, as in the conda-forge cairo package. We recently ran into a build issue with librsvg that seems to stem from the violation of this assumption.
If this diagnosis is correct, and there's a desire to increase the build portability to include systems where Cairo is built without FreeType, I think that another build feature would have to be added, mapping to CAIRO_HAS_FT_FONT.

By the way ... obviously, Cairo has a ton of build-time features, and it would probably be extremely tedious to manually map all of them into Rust features plus the appropriate cfg! guards on surrounding code. What I did in slurm-sys is have the build.rs script run bindgen on-the-fly, so that the sys library only links to symbols actually defined in the underlying library, and then (ew) parse the bindgen output to identify which features are activated, which can be wired up to turn on cfg! features in the non-sys library. Gross for sure, but the least-bad solution I could come up when you've got a C library that has a wide array of its own "feature flags".

For simplicity I would now make it another feature flag. In the future we could consider selecting these automatically based on the cairo configuration (no need to do hacks like you described: cairo provides one pkg-config file per optional feature, e.g. cairo-ft.pc for this case).
Do you want to provide a PR for this?

Not really, but yes I can prepare one :-) I'm thinking I'd name the feature freetype, and maybe mark it as a "default feature" to provide continuity with previous releases?

Sounds good, thanks!


v0.1.2 not available on GitHub Marketplace

I think someone forgot to publish the latest dioxus-deploy (v0.1.2) as only v0.1.1 and v0.1.0 are available on the marketplace, but the README says to use v0.1.2 which fails with Error: Unable to resolve action<EMAIL_ADDRESS>unable to find version 'v0.1.2'
This is a breaking bug as the main branch is 13 commits ahead of v0.1.1 which causes the action to install an archived version of cli with cargo install --git https://github.com/DioxusLabs/cli which is v0.3.1 instead of the upstream cargo install dioxus-cli which is v0.5.4 that is necessary to work with the latest Dioxus.

With a little digging I found a workaround, as actions aren't strictly limited to what is published on the marketplace. In fact you can specify a commit SHA, and the latest on main works fine:
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
index 6e9b124..a004417 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -10,4 +10,4 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Dioxus Deploy
-        uses<EMAIL_ADDRESS>+        uses: DioxusLabs/deploy-action@0025333337468cee2a224f2db60b6434ef9e2164

That said I still think v0.1.2 should be available on the marketplace as the README says.


MacOS binary name in 0.3.0 is wrong

https://github.com/umputun/updater/releases/tag/v0.2.0 vs https://github.com/umputun/updater/releases/tag/v0.3.0: macos binary name is wrong, was updater_v0.2.0_macos_arm64.tar.gz, became updater_v0.3.0_darwin_arm64.tar.gz.
Reason is https://github.com/umputun/updater/pull/28, I need to fix it.

@umputun could you please fix it? I don't have write permissions for this repo.
This line has to be replaced:
https://github.com/umputun/updater/blob/c2c238e/.goreleaser.yml#L21
Before:
  - name_template: "{{.ProjectName}}_{{.Tag}}_{{.Os}}_{{.Arch}}"

After:
  - name_template: "{{ .ProjectName }}_{{ .Tag }}_{{ if eq .Os \"darwin\" }}macos{{ else }}{{ .Os }}{{ end }}_{{ .Arch }}"


Demo5 doesn't function well?

Started the demo5 and apply the add_entry.sh and mclearn, it cannot pingall successfully.
Env: VMware, Ubuntu 14.04 64bit.

It worked well with the initial environment. I think it was caused by the software switch. I configured the bmv2 with --with-pdfixed label before. Not sure but no exceptions appeared in commands and code.

closed but reopen it if need


child_process.spawn Jscs file match pattern issue

I tried to spawn a process to run jscs and ran into a problem with using "*", ie, "src/*".  Please see below link to reproduce the error:
https://github.com/1001b/jscs_spawn_issue/blob/master/index.js
The same command text runs fine directly in sh:
./node_modules/jscs/bin/jscs -c .jscsrc src/.js*

That is actually a cool thing that happens, when you executing jscs from the console, it goes through shell, say bash for example, which parses the stdin, so bash parsers the input, not jscs, not node, but shell, which unfolds that wildcard.
But with spawn, you bypass the shell part, so there is nobody who doing this job anymore.
Anyhow, primary, you have two options, either use exec or unfold that pattern yourself.

Just curiosity.  The spawn approach works for ESLint.   What is the implementation difference between ESLint and JSCS?


VirSorter predicts prophage larger than contig size

Test assembly:
kleiner_2015.fasta.gz
Observation
It seems that VirSorter predicts a prophage in a range that is actually larger than the contig size. Example:
>NODE_51_length_63443_cov_50.479870

So contig NODE_51 (seq51 after renaming) has a length of 63443 nt.
Now VirSorter predicts a prophage for this contig from position 19922-63493:
(base) [mhoelzer@hh-yoda-11-01 ~]$ grep seq51 /hps/nobackup2/metagenomics/mhoelzer/nextflow-results/virify/v0.1/kleiner_2015/kleiner_2015/01-viruses/virsorter/Predicted_viral_sequences/VIRSorter_prophages_cat-4.fasta
>VIRSorter_seq51_gene_20_gene_72-19922-63493-cat_4

So the predicted prophage's stop position is larger than the actual contig size. I have the feeling this is a VirSorter problem or maybe a wanted feature. Maybe we should restrict the predicted prophage stop to the length of the contig.
@mberacochea will add some checks and print a message to let us know.

Pending update of container with latest release of virsorter (https://github.com/simroux/VirSorter/releases/tag/v1.0.6)

Pending update of container with latest release of virsorter (https://github.com/simroux/VirSorter/releases/tag/v1.0.6)

Maybe helps to build a Docker from the 1.0.6 VirSorter branch: https://github.com/replikation/What_the_Phage/blob/master/phage-tool-Dockerfiles/virsorter/Dockerfile
Or this should also work:
FROM continuumio/miniconda3
ENV VERSION 1.0.6
ENV TOOL virsorter

RUN apt update && apt install -y procps wget gzip pigz bc && apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

RUN conda config --add channels conda-forge && \
		conda config --add channels bioconda && \
		conda config --add channels default

RUN conda install $TOOL=$VERSION && conda clean -a

based on the bioconda recipe.
Or that container also works for me in the dev branch :)
docker pull mhoelzer/virsorter:1.0.6

Maybe helps to build a Docker from the 1.0.6 VirSorter branch: https://github.com/replikation/What_the_Phage/blob/master/phage-tool-Dockerfiles/virsorter/Dockerfile
Or this should also work:
FROM continuumio/miniconda3
ENV VERSION 1.0.6
ENV TOOL virsorter

RUN apt update && apt install -y procps wget gzip pigz bc && apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

RUN conda config --add channels conda-forge && \
		conda config --add channels bioconda && \
		conda config --add channels default

RUN conda install $TOOL=$VERSION && conda clean -a

based on the bioconda recipe.
Or that container also works for me in the dev branch :)
docker pull mhoelzer/virsorter:1.0.6

Thanks! I got it to work now using 1.0.6.
Closing this ticket :+1:

Thanks! I got it to work now using 1.0.6.
Closing this ticket :+1:


INSTALL probably violates licensing/copyright

It is a straight up copy of a GNU boilerplate. #blameblippy (lol, I tease... thanks for all your hard work, @blippy)

OK, I'll eat my words: https://github.com/milancurcic/datetime-fortran/blob/master/INSTALL#L7-L10

LOL! :smile:


Container's dragged onto maps cannot be accessed by players

Players get the notification "You do not have sufficient permissions to view this entity sheet" when trying to access a container, it doesn't matter what permission level the container has.
The following is displayed in the console:
foundry.js:3215 You do not have sufficient permissions to view this entity sheet.
render @ foundry.js:3215
openLootCollectionSheet @ canvas.js:262
callback @ foundry.js:35473
_handleClickLeft2 @ foundry.js:35677
_handleMouseDown @ foundry.js:35639
a.emit @ index.js:181
r.dispatchEvent @ interaction.min.js:8
r.processPointerDown @ interaction.min.js:8
t.recursiveFindHit @ interaction.min.js:8
t.recursiveFindHit @ interaction.min.js:8
t.recursiveFindHit @ interaction.min.js:8
t.recursiveFindHit @ interaction.min.js:8
t.findHit @ interaction.min.js:8
r.processInteractive @ interaction.min.js:8
r.onPointerDown @ interaction.min.js:8

This issue has been fixed about a week ago, and is waiting to be released. :-)


Docs incorrect for cg

From the README:

All linear solvers have a common function declaration
solver(A, b::Vector, [x, Pl, Pr, varargs...]; tol::Real, maxiter::Int, kwargs...)

cg starts from zero and doesn't take the x input---if you try to supply it, you get a cryptic error:
julia> cg(A, rand(5), rand(5))
ERROR: DimensionMismatch("dot product arguments have lengths 5 and 1")
 in dot at linalg/blas.jl:153
 in dot at linalg/generic.jl:286
 in cg! at /home/tim/.julia/v0.4/IterativeSolvers/src/cg.jl:18
 in cg! at /home/tim/.julia/v0.4/IterativeSolvers/src/cg.jl:8
 in cg at /home/tim/.julia/v0.4/IterativeSolvers/src/cg.jl:3

Is starting at zero important for cg, or should one be able to supply x?

It's generally not a good idea to supply x. If you supply an x that is close to a solution, an iterative method is likely to compute small steps that will vanish (when you add x + ∆x) due to numerical cancellation. If you want to "start" from a nonzero x, it's typically better to shift your system Ax=b to A ∆x = r, where r = b-Ax, let CG solve A ∆x = r, and then to compute x + ∆x at the end.

@dpo Could you point out any reference for that, please? I think supplying a nonzero initial guess for CG is a very common practice.

@astudillor I'm not sure there's a reference out there about it. It's nothing specific to CG but applies to all finite-precision computations. In a basic scientific computing class, you'll typically see the example of adding the first N terms of the alternating harmonic series (with N large), first in increasing, then in decreasing order. It's the same phenomenon. Here's a simplistic example in Julia (I'm sure there's a more efficient way to do this!) I use Float16 to emphasize the effect:
julia> N = 10^8

# Forward
julia> app1 = Float16(0.0);
julia> for i = 1 : N
       app1 += Float16((-1)^(i+1) / i)
       end
julia> app1
Float16(0.6963)

# Backward
julia> app2 = Float16(0.0);
julia> for i = N : -1 : 1
       app2 += Float16((-1)^(i+1) / i)
       end
julia> app2
Float16(0.6934)

# The asymptotic sum is
julia> log(Float16(2.0))
Float16(0.6934)

@dpo How does the example you provided relate to CG? As far as I can tell the only thing it shows is that order matters when performing arithmetic on Floats.

As all the Krylov method, it should be possible to provide an initial to cg.
Therefore, there is a kind of bug.
Now, from the algorithmic point of view, the question is: is it a good idea to "help" or not with an initial guess ?
There is literature, e.g., see Hegedüs trick.
Give a look at "5.8.3 The Backward Error Concept in Iterative Computations" from "Krylov Subspace Methods: Principles and Analysis" by Jörg Liesen and Zdenek Strakos.
What it is generally remarked is: the non-zero initial guess does not help for the convergence behavior.


TCGA sample mapping?

Hi,
Thanks for a very comprehensive resource! I have compiled a list of unique diagnoses assigned to TCGA patients/samples. I was wondering whether there exist a mapping somewhere between OncoTree codes and the diagnoses/primary_tissues assigned to TCGA samples? Since OncoTree is used in cBioPortal, I reckoned that this may exist somewhere, but I may be wrong.
regards,
Sigve

Hi @ritikakundra,
Thanks for the response. Considering the > 100 different tumor subtypes/diagnoses within TCGA samples which I pointed to, this mapping was not exactly what I was looking for. The mapping you point to refers to the main tumor types only. Considering the depth and detailed subtypes within OncoTree, I was looking for a more fine-grained mapping. I guess then that this mapping is not something you or others have at hand?
best,
Sigve

All TCGA  samples  in the portal do have an oncotree assigned to them. I think I can get you that too based on your list.

From: Sigve Nakken<EMAIL_ADDRESS>Sent: Thursday, August 29, 2019 5:11:03 AM
To: cBioPortal/oncotree
Cc: Kundra, Ritika/Sloan Kettering Institute; Mention
Subject: [EXTERNAL] Re: [cBioPortal/oncotree] TCGA sample mapping? (#200)
Hi @ritikakundrahttps://github.com/ritikakundra,
Thanks for the response. Considering the > 100 different tumor subtypes/diagnoses within TCGA samples which I pointed to, this mapping was not exactly what I was looking for. The mapping you point to refers to the main tumor types only. Considering the depth and detailed subtypes within OncoTree, I was looking for a more fine-grained mapping. I guess then that this mapping is not something you or others have at hand?
best,
Sigve
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/cBioPortal/oncotree/issues/200?email_source=notifications&email_token=AC3TTNVCSQRNEFJ4WZFGVFDQG6HCPA5CNFSM4IMF2FH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5N2BPI#issuecomment-526098621, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AC3TTNUP54PYVTHMSJ7ATGTQG6HCPANCNFSM4IMF2FHQ.
=====================================================================
 Please note that this e-mail and any files transmitted from
 Memorial Sloan Kettering Cancer Center may be privileged, confidential,
 and protected from disclosure under applicable law. If the reader of
 this message is not the intended recipient, or an employee or agent
 responsible for delivering this message to the intended recipient,
 you are hereby notified that any reading, dissemination, distribution,
 copying, or other use of this communication or any of its attachments
 is strictly prohibited.  If you have received this communication in
 error, please notify the sender immediately by replying to this message
 and deleting this message, any attachments, and all copies and backups
 from your computer.

Hi @ritikakundra,
Thanks for the response. Considering the > 100 different tumor subtypes/diagnoses within TCGA samples which I pointed to, this mapping was not exactly what I was looking for. The mapping you point to refers to the main tumor types only. Considering the depth and detailed subtypes within OncoTree, I was looking for a more fine-grained mapping. I guess then that this mapping is not something you or others have at hand?
best,
Sigve

I'm looking for this mapping file too, was there any solution to this issue in the end?

Hello Looking for that mapping as well.
Best,


NFCManager.registerTagEvent got 3 arguments expected 2

I got the following error

@gosuisez Sorry for the late resopse. It looks like a version mismatch between library and your client code. Please show me your code and library version for further info.

this is happening for me also on iOS 13, version 2.0.1.
index 2 beyond bounds [0 .. 1]' was thrown while invoking registerTagEvent on target NfcManager with params (     "",         {         invalidateAfterFirstRead = 0;         isReaderModeEnabled = 0;         readerModeFlags = 0;     },     1923 )

This was an issue for my project using codepush, it was reverting the library back to an older version.

This was an issue for my project using codepush, it was reverting the library back to an older version.

Hi @bigescalade,
My project using codepush, How to solve this problem when using codePush.
Hi @bigescalade,
My project using codepush, how to solve this problem when using codepush.
Please sharing your solution^
Thanks

Hey @anaraa3
I've had updated some packages including

react-native-nfc-manager

So It was a version problem, so what worked for me was to clear all data, do a fresh install and rebuild.


img2img mode fails (The command "Select" is not currently available.)

I can't seem to make img2img mode work, see video:
2023-01-18 09-16-09.webm
using PS 23.3.2

Also experiencing this issue- both with img2img and inpaint. No error appears in the terminal window, and the plugin appears to get stuck attempting to generate an image until it is interrupted.

Fixed my issue. Did a git pull of the latest webUI commit after removing the Dreambooth extension folder.
Hope this helps.

I don't have the Dreambooth extension installed and I just updated to the latest commit too, but I still have the issue

Does the same happen for the inpaint mode or only img2img?

Also happens with inpaint

I just downloaded this as I needed the ability to finely mask/select for some inpainting work to be hit with this select nonsense.  I filed ticket #18 on it, but it appears tickets are not being looked at, so is this abandoned already?

is this abandoned already?

What do you mean? I am still working on other bugs/features, I cannot fix all issues in seconds.

is this abandoned already?

What do you mean? I am still working on other bugs/features, I cannot fix all issues in seconds.

Just wondering since I saw so many tickets without a response out of you.  Glad to know this is being worked on.

Guys, could you test it again? It should be fixed.

Guys, could you test it again? It should be fixed.

Could you please record a video like OP? Need to check what happens with layers during generating.

Could you please record a video like OP? Need to check what happens with layers during generating.

Maybe someone else can, but it is the same for i2i or inpainting only now instead of select it is delete.

Do you have layers with transparent areas? Try to use inpaint in a document with just one layer without transparent areas, will the error remain?

Do you have layers with transparent areas? Try to use inpaint in a document with just one layer without transparent areas, will the error remain?

I have only the background layer.  I hit layers flatten and there is nothing to flatten because there is only the one layer.

Could you verify that your version hash is e029076? I reproduced the deletion error, and yes, it is related to the lock. But the issue with selection should have been fixed in the latest update. If your hash is not e029076, try to close and reopen Photoshop.

@DarkAlchy could you please check again? A new hash should be 387cb83.

@DarkAlchy could you please check again? A new hash should be 387cb83.

Cannot reproduce :(
Does your original background layer have any transparent areas? Or is it entirely black? Will the error remain if you create a new document with default settings?

I2I or Inpainting have the same error.

Same issue here as of https://github.com/isekaidev/stable.art/commit/155019e4af9ef3097257c6e6f34259b12eb28fc9.

@Puncia What is your photoshop version?
I reproduced the bug, it seems a bug is in Photoshop API itself, and it is related only to old versions (23.3.0 has the bug, 24.1 does not). I added a workaround, and now it should be fixed. Could you test?

Thanks, it seems to be fixed now. I do get ReferenceError: atob is not defined when clicking on the result now though, making me unable to use it. Happens with txt2img and inpaint as well.

I hope so.

Worked for me.

All seems to work well now! thanks again for your efforts, appreciated.


Repeated items in list

Hi, I am having repeated items in a list.
I have created a fourth element in the top menu, it is called Protected, the value inside is:
title: "Protected"
description: "test protected index"
date: 2020-01-11T14:09:21+09:00
draft: false
When it renders it creates two elements for each element in the folder.
I did a test removing one of the elements and it removes both copies.
This issue doesn´t happen in the other folders.
You can see it running in here:
https://davidmarcielp.github.io/davidmarcielp
and the code here:
https://github.com/davidmarcielp/davidmarcielp

Hi, I can't reproduce it.
Can you show me the repository which is not public folder(build version) but the original site code?

Yes, sorry, the proper repo is: https://github.com/davidmarcielp/hugo-zdoc

It's strange.
It works fine with my local environment.

Yes, it happens when I run it locally but also when I run it in a server, but only in the protected menu folder.

How did you start the Hugo?
Why the port number is 8080.
The default port number is 1313.

yes, in this case is using node, in this case is using hugo server:

In this case is direcly in github:

It only happens in the protected folder (next to blog)

What OS are you using?
It looks fine in Windows 10.
Are you using Ubuntu?

How about deleting these folders?
This is not necessary since you are using language folder

It still happens when I remove those folders 🤕
Im using Win 10,

How about delete _index.md file at config/_default folder which is not necessary.
And what Hugo version are you using?

I´ve tried everything and I couldn't find the way to make it work,
doesn´t matter, thanks for your help zzossig.


Develop

In this project,

I have created a simple HTML to-do list.
The list is styled according to the specifications listed later in this lesson.
This simple web page is built using webpack and served by a webpack development server.

I deploy it on netlify because my github forces me to create another pull request that is not allowed in this project. but the god part of the project I will deploy it on github because it will contain a new pull request

you will find all its requirements in this section sir:
  ${todo.description}   ;
From where each element in my array has its project index.

Hello 👋,
This is an additional review as a result of the second opinion request.
Looks like the issue was resolved here, so I have nothing else to say other than best of luck with the rest of your projects!
Keep rocking 🚀!


Agent: add server subcommand to expose agent protocol via websockets

Previously, it was only possible to do RPC with the Cody Agent via stdin/stdout, which required the client to run on the same computer as the Cody Agent. This PR adds a new server subcommand that starts a server that allows clients to connect with the Cody Agent via web sockets from another computer.
One example use-case for this feature is to implement a browser client to interact with Cody Chat. By using websockets, the browser client can interact with Cody without installing any custom dependencies. To improve the ergonomics of interacting with Cody, we can extend our current Kotlin bindings generation tool to generate bindings for other languages like TypeScript and Go.
Below is a demo of a SvelteKit static page that establishes a websocket connection to expose a basic chat interface

Test plan
Manually tested with a SvelteKit client.

That is awesome @olafurpg
Better than the workaround I took to set the CODY_AGENT_DEBUG_REMOTE flag for TCP communication (which works also pretty well):
May you put that as a release?

@PriNova that's cool! When I have some bandwidth, I could take a stab at auto-generating Python bindings that will work similarly to https://github.com/PriNova/codypy/blob/main/codypy/cody_py.py I see you're only using a few endpoints so it might not be too bad, but let me know if you are interested. No promises when I'll find the time but would be a fun project :)


[Android][iconSize is not honoured for iconUrl using resource resolver]

Platform
What platform is your issue or question related to? (Delete other platforms).

[ ] .NET HTML
[ ] .NET WPF
[x] Android
[ ] iOS
[ ] JavaScript
[ ] UWP

Author or host
Host - Cisco WebEx
Cisco Webex
Version of SDK
latest main
Details
The iconSize host config field for iconUrl (inline) is not being honoured when resource resolver is used.

@golddove - care to take a look?

@paulcam206 yup, this is a known inconsistency between platforms (Android renderer only respects iconSize when iconPlacement is above). Will take up in 21.04

@golddove - do we have another bug tracking this already?


Safety of incrementing executionCount

I might be missing something here. Is incrementing  the executionCount safe like this, without syncronization or using interlocked operations?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c3460b0d-9c60-3a06-ac63-18cf990e53c3
Version Independent ID: b2dece1f-15b8-03af-6d52-7cc070432b4b
Content: Background tasks with hosted services in ASP.NET Core
Content Source: aspnetcore/fundamentals/host/hosted-services.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @guardrex
Microsoft Alias: riande

OOF for the :gift: holidays :snowman: and will return on January 6.
If you need support, we recommend contacting devs on support channels and chat:

Stack Overflow
ASP.NET Core Slack
ASP.NET Gitter

Potential bugs in the ASP.NET Core framework and product feedback can be reported at aspnet/AspNetCore issues (include full repro steps and cross-link to a repro project in GH when appropriate). For Visual Studio, use the Report a Problem gesture or Suggest a Feature gesture within VS, which open internal issues for the VS team. For Visual Studio Code, you can open an issue at microsoft/vscode issues.
:dancer::man_dancing: Happy New Year! See you in 2020! :balloon::champagne:

Hello @thanuja89 ... It's fine in these cases. executionCount variables in these services are local to each service. Nothing external to each service can access them.

Hi @guardrex..
Correct me if I'm wrong here. The TimedHostedService uses System.Threading.Timer which queues callbacks to the treadpool. According to my understanding, it is not guaranteed that all the previous callbacks have finished execution when they run. So I'm assuming there may be two callbacks executing at the same time. If that is the case, the executionCount could be easily wrong.
The other concern is these callbacks are more likely to be run in different threads, so the executionCount could be cached in the CPU. If the code is run on a machine with more than one processor, each processor could cache the executionCount and increment that value (since non-volatile writes are used).
What are your thoughts on this @guardrex?

Ah! I see what you mean now.
I think your first concern is very real. In this silly example that we have, it should be fine. We probably need to at least add a remark on it so that devs are warned.
The second point needs to be addressed by a REAL developer (not a hack like me :smile: lol) ... @huan086, do you have a moment to address that one, and what do you think about @thanuja89's first point, too?
For reference, here's the service :point_right: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/host/hosted-services?view=aspnetcore-3.1&tabs=visual-studio#timed-background-tasks
Let's keep in mind something as we sort this out: We might be able to stick with the silly example and cross-link to MS content that shows how to avoid these issues. If not, we'll have to do something else with the example so that we're not guiding readers with a pattern that's going to :boom: on them in real apps.

Yup a reminder that System.Threading.Timer does not wait for previous execution to finish, and may run in different threads would be great. Especially to people who started from WinForms (me), which has timer that "just works safely".
To fix the code, I think this would be sufficient:
Replace executionCount++; with Interlocked.Increment(ref executionCount);.

Thanks @thanuja89 and @huan086 ... I'll get the topic+sample updated.


New-Cli

with improved portfolio management and analysis.

Codecov Report

Merging #205 (18fc092) into master (ccb54af) will decrease coverage by 0.36%.
The diff coverage is 18.33%.

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   40.11%   39.75%   -0.37%
==========================================
  Files          58       58
  Lines        3198     3255      +57
==========================================
+ Hits         1283     1294      +11
- Misses       1915     1961      +46

Impacted Files
Coverage Δ

liualgotrader/analytics/analysis.py
16.10% <10.00%> (-0.12%)
:arrow_down:

liualgotrader/models/accounts.py
34.42% <19.04%> (-7.04%)
:arrow_down:

tests/test_accounts.py
29.32% <20.68%> (-2.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb54af...18fc092. Read the comment docs.


How I recreate Realm Database file?

I'm using realm database, but the file has been corrupted in any devices. I think delete the file and recreate.
Anyone knows how is the best way to do it?

@narlei
It is OK just to delete the file before creating any Realm(or RLMRealm) instances.
Then instantiate Realm as usual, new Realm file is created automatically.
If you used the Realm file as default configuration, the way to delete the file is the following:
let config = RealmConfiguration.defaultConfiguration
if let path = config.path {
    try NSFileManager().removeItemAtPath(path)
}

@narlei we're closing this issue because we haven't heard back from you in a while. Please reopen if you'd like some clarifications or have any further questions.


add aws_iam module

Please restore the lockfile (again) :)

It is restored. I did it because I also thought it got deleted again by mistake. It mostly seems to be deleting lines?

On the branch
iasql-engine iam % yarn install
yarn install v1.22.18
[1/4] 🔍  Resolving packages...
success Already up-to-date.
✨  Done in 0.17s.
iasql-engine iam % git diff
iasql-engine iam %


Make EDA tab error messages more friendly

Big error messages like this one (created by io-ts) are somewhat common when an error occurs:

We should make these more user-friendly (like the oops error messages), possibly giving them a friendlier message with the error itself semi-hidden in a collapsible.

cool idea from @jernestmyers : add a Read More option to the current banner component.
Doesn't make it perfect but doesn't break the ux

might be already part of the component. Think maybe @moontrip did this work?

@asizemore yes Read more/less feature is currently available at CoreUI Banner as I added it to address other tickets (e.g., Banner message on Scatterplot/Lineplot Vizs, etc.)

based on meeting Jan 18 2023 I understand this is a service formatting error. .not a user error.. therefore we should not show an error banner (for user errors).. but a generic popup?
I dont think this is a styling issue.


gripper_action_controller: Disable writing until action is active

When the gripper_action_controller starts it writes zero's to the gripper desired position, which causes the gripper to start moving on startup, which is not the behavior of the joint_trajectory_controller. I modified the gripper_action_controller to disable writing to the hardware unless an action goal is active.
I also had to link some of the tests to control_toolbox in order to build correctly.

This issue of the gripper changing position to the default zero position doesn't occur in ROS Humble now. This PR can be closed without merging it in.


CASSANDRA-19758: CommandsForKey Pruning

CommandsForKey should periodically self-prune, so as to continue functioning well in-between garbage collections. This is a bit complicated, as once we prune we are left with potentially incomplete information, and have to sometimes load per-command information from disk. But the payoff is ensuring CommandsForKey objects - which drive the majority of the state machine - are kept to a reasonable size.

I think everything raised so far has been addressed

org.apache.cassandra.service.accord.async.AsyncOperationTest#testFutureCleanup is failing btw.

There seems to be a bug with this test; it is treating both the main thread and CommandStore threads as inStore, so we have two threads messing with the state cache.

thank you both!


Easy way to get Windows Terminal version info via script

Description of the new feature/enhancement
I like having my console sessions start with a dump of pertinent version information. I was hoping to find an easy way to get the version info of the Windows Terminal session. I'd add it to my profile.ps1:
"- posh-git version/path: $($m = Get-Module posh-git; '{0} {1} {2}' -f $m.Version,$m.PrivateData.PSData.Prerelease,$m.ModuleBase.Replace($HOME,'~'))`n- PowerShell version: $($PSVersionTable.PSVersion)`n- $(
git --version)`n- OS: $([System.Environment]::OSVersion)`n- Terminal: ($([System.Environment]::WindowsTerminalVersion)"

Seems the best place to do this is in an environment variable as I've shown above (- Terminal: ($([System.Environment]::WindowsTerminalVersion)).

If #1040 were solved, would you be able to use that?

Yes. Thanks.

(Closed as a /dup of #1040)


not sure what this error could be...

i updated the script to the latest version and now I cant seem to avoid this error. Anybody know what it means?
compute_flow.py: error: unrecognized arguments: Diffusion\stable-diffusion-webui\scripts\SD-CN-Animation-main\1.mp4 Diffusion\stable-diffusion-webui\scripts\SD-CN-Animation-main\flow.h5
i'm guessing the path structure is incorrect on my part. not sure but any help would be appreciated and please accept my humblest apology if this error was posted and solved somewhere else.

Please show the exact thing you run in the console.

python3 compute_flow.py -i {D:\Stable Diffusion\stable-diffusion-webui\scripts\SD-CN-Animation-main\1.mp4} -o {D:\Stable Diffusion\stable-diffusion-webui\scripts\SD-CN-Animation-main\flow.h5} -v -W 512 -H 512
this is what i ran. everything look ok or no?

Try :  py compute_flow.py -i D:\Stable Diffusion\stable-diffusion-webui\scripts\1.mp4 -o D:\Stable Diffusion\stable-diffusion-webui\scripts\flow.h5 -v -W 512 -H 512

Try : py compute_flow.py -i D:\Stable Diffusion\stable-diffusion-webui\scripts\1.mp4 -o D:\Stable Diffusion\stable-diffusion-webui\scripts\flow.h5 -v -W 512 -H 512

Thank you so much for your help, I'll give it I try.

I written the wrong path I have updated my first comment

@jAyATJaY You are not supposed to use brackets in the console, it is just for input indication. I should probably update instruction to avoid this confusion.

Now I have this,
Traceback (most recent call last):
File "D:\Stable Diffusion\stable-diffusion-webui\scripts\SD-CN-Animation-main\compute_flow.py", line 1, in
import cv2
ModuleNotFoundError: No module named 'cv2'

Do you have install dependencies ?  : pip install opencv-python opencv-contrib-python numpy tqdm h5py

yes it says that are requirements are satisfied.

You might have issue with multiple python instances installed on the system. No. Try the following, run:
python3 -m pip freeze
Check if there is opencv-python in the list. If there is not, that means that when you run 'pip' command it interacts with the different version of python that is set to 'python3' command. If so, you should install opencv-python again with the following command:
python3 -m pip install opencv-python

okay so this is what it came up with. i do see opencv python.
accelerate==0.18.0
certifi==2022.12.7
charset-normalizer==2.1.1
colorama==0.4.6
diffusers==0.14.0
filelock==3.9.0
h5py==3.8.0
huggingface-hub==0.13.4
idna==3.4
importlib-metadata==6.3.0
Jinja2==3.1.2
MarkupSafe==2.1.2
mpmath==1.2.1
mypy-extensions==1.0.0
networkx==3.0
numpy==1.24.1
opencv-contrib-python==<IP_ADDRESS>
opencv-python==<IP_ADDRESS>
packaging==23.0
Pillow==9.3.0
psutil==5.9.4
pyre-extensions==0.0.23
PyYAML==6.0
regex==2023.3.23
requests==2.28.1
scipy==1.10.1
sympy==1.11.1
tokenizers==0.13.3
torch==2.0.0+cu118
torchvision==0.15.1+cu118
tqdm==4.65.0
transformers==4.27.4
typing-inspect==0.8.0
typing_extensions==4.4.0
urllib3==1.26.13
xformers==0.0.19.dev516
zipp==3.15.0

Ok. That's weird. If you use ubuntu you may try to do the following:
sudo apt update
sudo apt install libopencv-dev python3-opencv

You could create a virtual environment for this, that's what I do to maintain separation from all the different versions of stuff I'm using.

Yes, I'm on Windows. I'm new to all of this. I'll keep trying. I'm really excited about trying this script. It looks like one of the best ones out there and I think I've tried them all. I think.

You might have issue with multiple python instances installed on the system. Try the following, run: python3 -m pip freeze Check if there is opencv-python in the list. If there is not, that means that when you run 'pip' command it interacts with the different version of python that is set to 'python3' command. If so, you should install opencv-python again with the following command: python3 -m pip install opencv-python

you were right, i did discover multiple instances of python installed. went through the windows app store which i wasn't aware of. i just uninstalled both and reinstalled just to be sure. now everything's working as it should.


Site header universal search

The search bar itself works. The underlying pages need to be updated. Specifically, requests and collages need to be rewritten to use Manticore, and the rest of them just need to not suck.


LineMappings should not be generated for imports

Follow up to https://github.com/aspnet/Mvc/pull/5776

ae34e14358779d64aec468e56259ca5da0b30421


Better more complete fix for allowing filename to set date and slug

This is a better and more complete PR for https://github.com/gohugoio/hugo/pull/3310 which:

has actual working tests :)
uses a single boolean to decide if should enable filename as fallback or not
(this allows us to add if needed more and more complex parsing of the header rather than lock it down to user specified regex)
also sets the slug so the date is not part of the url

I've updated with a fix that ensures even if post has no frontmatter dates gets calculated correctly.
Anything else I need to do here  to get it merged in ?

now rebased against master.

rebased again - hope this can go in soon :)


Update to Skype, Discord, Messenger icons

Pre-flight Checklist
Please ensure you've completed all of the following.

[x] I have read the Contributing Guidelines for this project.
[x] I agree to follow the Code of Conduct that this project adheres to.

Description of Change

Great thanks :slightly_smiling_face: As an advice for another contribution: you should make your change in a different branch than your main branch. This will allow you to fast-forward to the changes of the upstream without having to delete anything, and then you can use the rebase function in order to bring these changes into your other branch.
@all-contributors please add @Arthur-Huan for code


Review MSAL Dependency and Upgrade As Appropriate

MSAL4j released v1.0.0 last weekend.  We should upgrade our dependency to this latest release.

Moving this to the January milestone


Add 'advanced' thermal runaway detection

Detect when hotend is not warming up and remains in same temperature. This can cause a fire since heater may continue to heat up while thermistor is not reading increase in temp. Could be because of some hardware failure. Printers whose firmware does not detect thermal runaway will not detect this case so this alert may save someone from starting a fire!!!

Here's a log with false alarms happening.
Explore-logs-2021-08-17 21_29_30.txt

Getting better with the latest dev build, but still a number of false warnings today.  You can see the # of instances of the error have gone down since yesterday.

Here's a log from today (8-18-20).
Explore-logs-2021-08-18 17_18_14.txt

Yes, it is getting better. In the logs I see 2 instances of alerts and both are because of the same reason: "After 5 seconds temp should have gone up and it went down".

2021-08-18T14:30:48-04:00	2021-08-18 18:30:48,574 - octoprint.plugins.octopod - WARNING - Possible thermal runaway detected for bed. Actual 67.1 and Target 85.0
2021-08-18T14:30:43-04:00	2021-08-18 18:30:43,567 - octoprint.plugins.octopod - DEBUG - Thermal runaway - Started to track bed. Temp should go up. Actual 67.5 and Target 85.0

2021-08-18T13:52:14-04:00	2021-08-18 17:52:14,887 - octoprint.plugins.octopod - WARNING - Possible thermal runaway detected for bed. Actual 84.8 and Target 90.0
2021-08-18T13:52:09-04:00	2021-08-18 17:52:09,879 - octoprint.plugins.octopod - DEBUG - Thermal runaway - Started to track bed. Temp should go up. Actual 84.9 and Target 90.0

I will handle this case so that if after 9 seconds the temp did not go up then send the alert. Sounds good?
Thanks,
Gaston

Yep, or you could put a fudge factor in since its only off by less than 1*c.  Give it a little buffer to bounce around a bit.   I wasn't doing anything special with them today, most of these were either during initial preheat (from the LCD menu) or shortly after starting the print.

One error today, this time with the nozzle temp.  I had the printer set to pre-heat and it had just reached 230 and was overshooting a bit.  I started the print and looks like the hot end was cooling down a bit right when I clicked start and it set the temp to 240.

Interesting. Temp went down more than 1C when warming up. I guess I was being too aggressive/optimistic. Update again from dev, I now allow up to 2C margin. Hope we got them all now! :D