Add Custom error message support for Toml Schema validator

Purpose
$Subject.
Fixes #27903
Approach
Introduced a seperate field for each schema, called message. Message can contain error messages for all the validations. Keys of the message field is equals to the validation key. See the sample below.  and check CustomErrorTest.java for usage.
Samples
{
    "$schema": "http://json-schema.org/draft-07/schema#",
    "title": "Ballerina Manifest Spec",
    "description": "Schema for Ballerina Manifest",
    "type": "object",
    "additionalProperties": false,
    "properties": {
        "package": {
            "type": "object",
            "additionalProperties": false,
            "properties": {
                "name": {
                    "type": "string",
                    "message" : {
                        "type" : "Invalid Type"
                    }
                },
                "org": {
                    "type": "string",
                    "pattern": "^(?!\\s*$).+",
                    "message" : {
                        "pattern" : "Org cant be empty"
                    }
                },
                "version": {
                    "type": "string",
                    "pattern": "^(?!\\s*$).+"
                },
                "port": {
                    "type": "integer",
                    "minimum": 0,
                    "message" : {
                        "minimum" : "Port should be positive int"
                    }
                },
                "capacity": {
                    "type": "integer",
                    "maximum": 5,
                    "message" : {
                        "maximum" : "Max Capacity is 5"
                    }
                },
                "repository": {
                    "type": "string"
                },
                "keywords": {
                    "type": "array",
                    "items": {
                        "type": "string"
                    }
                },
                "exported": {
                    "type": "array",
                    "items": {
                        "type": "string"
                    }
                }
            },
            "required": ["name","org"],
            "message" : {
                "required" : "Field ${property} is required",
                "additionalProperties" : "Field ${property} is not supported"
            }
        }
    }
}

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[x] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

What would the full form of these errors look like when printed on the console?

Pls check comments added
Thanks. Addressed the issues, please check

What would the full form of these errors look like when printed on the console?
When we add the following changes to C2C(Kubernetes.toml)

"repository": {
    "type": "string",
    "pattern": "^(?!\\s*$).+",
    "message" : {
        "pattern" : "repository cant be empty"
    }
}

If the repository is empty in the Kubernetes.toml, repository=""
It'll give the following error on the console while compiling.
ERROR [Kubernetes.toml:(4:12,4:14)] repository cant be empty


"Hotspots Witnessed" section is reporting for the last 3 days but text is telling 5-days

Describe the bug
blockchain-http module is updated to report the last 3 days witnessed counts, instead of 5 days with release 1.2.121 https://github.com/helium/blockchain-http/releases/tag/1.2.121
"Hotspots Witnessed" section is telling "over the last 5 days", but the value is actually for the last 3 days.
To Reproduce
Just check a random hotspot on Explorer.
Explorer: https://explorer.helium.com/hotspots/11wu65LGrmmSsAMwoGtzDg2xTjs4iPZfNvuXQJrGb41e5AVRVDT
API server: https://api.helium.io/v1/hotspots/11wu65LGrmmSsAMwoGtzDg2xTjs4iPZfNvuXQJrGb41e5AVRVDT/witnessed
HTTP API change: https://github.com/helium/blockchain-http/commit/49ee76c5602a6271526bc0ce0582f8a208890a0a#diff-d8093e0584440e6498640985e7b519129691d9e4df4a2d8db197332208142170L394
Expected behavior
"Hotspots Witnessed" section should show "over the last 3 days"
Screenshots
Smartphone (please complete the following information):

Device: Irrelevant, happening for all devices
OS: Irrelevant, happening for all devices
App Version Verified on 4.0.1

Additional context

updated copy. closing.


Can not find module i18n

What version of this package are you using?
"next-translate-plugin": "^2.5.2"
What operating system, Node.js, and npm version?
node 16 yarn 1.22.19
What happened?

Are you willing to submit a pull request to fix this bug?
I am so sorry I new to new ,I could not fix it

Did you add i18n config file following this guide?

@chanphiromsok would be great to know more details about your project. Maybe is something missing like i18n.js file. Thanks

@chanphiromsok do you have a monorepo? https://github.com/aralroca/next-translate#13-how-to-use-next-translate-in-a-mono-repo
to better understand the problem if you share a repo reproducing the error we will see what happens. Thanks!

I'm seeing the same issue. We're passing in a NEXT_TRANSLATE_PATH.
It seems to be something to do with this code in the plugin:
var basePath = pkgDir();
basePath = path_1.default.resolve(path_1.default.relative(basePath, process.env.NEXT_TRANSLATE_PATH || '.'));

My project structure is something like this:
Users/me
└── Development
    └── my-monorepo
        └── apps
            └── my-app
                ├── i18n.js
                ├── next.config.js
                └── other-files

My basePath is /Users/me/Development/my-monorepo. Inside my-monorepo, I have an app at apps/my-app, which is where my NextJS and Next Translate configs live. apps/my-app is what I set NEXT_TRANSLATE_PATH to.
The resulting basePath of the code above is /Users/me/Development/my-monorepo/apps/my-app/apps/my-app/apps/my-app.
This is when running through nx. For example, nx run my-app:serve:development.
I'm wondering if there is something going on with what is used to derive basePath here (i.e., pkgdir) versus what path might be using under the hood for path comparison (my guess is process.cwd()).

I have the same error in my project with nx

@chanphiromsok do you have a monorepo? https://github.com/aralroca/next-translate#13-how-to-use-next-translate-in-a-mono-repo
to better understand the problem if you share a repo reproducing the error we will see what happens. Thanks!

Hi sorry for late response Now I have skip this feature 😅

@ilchenkoArtem how did you solve TS errors when running NX composePlugins?

Just want to add a little more data that I found that might be related to this, at least in my case.
As I mentioned, I'm seeing this when using nx and upgrading to v16. While it's not listed in the breaking changes, one thing I noticed about v16 is that they now spin up webservers in the outputPath of your build target. Previously this wasn't the case, as it used the root instead.
Since the NextJS config gets read in both the build and serve phases, and those phases now run from different directories, this also causes issues with relative paths for the translate configs.
One workaround in this particular case is to inspect the phase (such as PHASE_PRODUCTION_SERVER or PHASE_PRODUCTION_BUILD) in the Next config and assign the correct path accordingly. Still no idea why the dev server path is so screwy, though (my above comment).

Hi, I have the same problem as ian-hutchinson, the NEXT_TRANSLATE_PATH is not respected correctly inside nx dev.
My workaround to make it works is to update my environment variable like this:
NEXT_TRANSLATE_PATH=../..

Please correct me if I'm wrong, won't this part of code var _a = require(path.join(dir, 'i18n')) return a folder instead of a JSON or .js file, regardless of NEXT_TRANSLATE_PATH ? Is is mandatory to have a folder called i18n? I'm having the same problem in a production environment in firebase

I have the same error in my project with nx

Same issue.
Fixed with @perscrew fix. The path.relative and path.join are not working.


Fix acqmon veto field

'straxen_deadtime_veto' doesn't fit into a U20 string

Coverage decreased (-0.01%) to 93.171% when pulling 9cbe454411b50a09b0a721527217a5c7db98d98d on fix-acqmon-fields into 4ba2209e7d30202222af7653119d04d99d259a59 on master.


Dev

Moved all game data to src/ - so you will see a lot of changes but none to the actual source code on this
Added a .gitignore, since there were files before the .gitignore I removed tracking and readded them with the .gitignore so it would work properly
car_game.py -> added get_relative_dir() so that files can be added relative to the main file so that if the game is run using 'python' and the directory is not the game's parent folder, the game will still be able to run and load the files correctly
Readme updated with installation and pre
Modified Readme.md with further information on the installation and dependancies

LGTM!

Fixed all conflicts with the file, added your changes to overview and my changes to installation and dependencies


Viewport highlight, colour cache and minimap scrolling fixes.

The viewport highlight colour is now based on the background colour, instead of current line colour.
Fixed syntax highlighting cache not clearing the final line, causing it to not update.
Made scrolling via the minimap act similar to the scrollbar, so it should no longer lag.
I also refactored the control height calculations into its own method.
closes #31584
closes #31617
closes #31582

Thanks!


Error while trying to deploy Azure Function

Hi,
I was following this tutorial
https://docs.microsoft.com/en-us/samples/azure-samples/mxchip-iot-devkit-state/sample/
At the "Deploy Azure Functions step", I keep getting this error and I don't know how to resolve it, screenshots below

Any help would be appreciated, thank you in advance !

I'm able to solve the problem, apparently it has something to do with netcore app version, I switched to netcoreapp3.1 & the problem is gone .


toybox: 0.8.9 -> 0.8.10

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/toybox/versions.
meta.description for toybox is: Lightweight implementation of some Unix command line utilities
meta.homepage for toybox is: https://landley.net/toybox/
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.8.10 with grep in /nix/store/p6sngfwav5jpb93qgzy4yf1s1kkz1b1a-toybox-0.8.10
found 0.8.10 in filename of file in /nix/store/p6sngfwav5jpb93qgzy4yf1s1kkz1b1a-toybox-0.8.10

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
toybox

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/p6sngfwav5jpb93qgzy4yf1s1kkz1b1a-toybox-0.8.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A toybox https://github.com/r-ryantm/nixpkgs/archive/29c7ce56873f050560f90bd99c116f1334d4723c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/p6sngfwav5jpb93qgzy4yf1s1kkz1b1a-toybox-0.8.10
ls -la /nix/store/p6sngfwav5jpb93qgzy4yf1s1kkz1b1a-toybox-0.8.10/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

toybox

Maintainer pings
cc @hhm0 for testing.

Result of nixpkgs-review pr 253976 run on aarch64-darwin 1

1 package built:

toybox


Switch to LocalDate & DateEpoch representation instead of Date & seconds since epoch

Fixed by https://github.com/witmoca/BEATs/commit/1a6ed450223dd1e90b2054c72c09674a87fb89e7


Module 2.2 Assignment

log containing the result of git pull

👋 for this assignment, if you'd like to try again, please include a screenshot of merging on the command line using git fetch and git merge.

my bad, i thought you wanted to see the changes as shown in the log, I re-created this assignment, is this ok?


chore(main): release 1.1.0

:robot: I have created a release beep boop
1.1.0 (2024-01-23)
Features

remove integrated style and moved to external css file (cd8857f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/X3ne/vue-depth-viewer/releases/tag/v1.1.0 :sunflower:


Is there any plan to make an electron app for a bit more native experience

I think many more people like me would love a native version of an apple music app.

Thanks for the request, it's something on the radar but I haven't had the time to look into it. I'm going to close this as a duplicate of #6.


Question about importing Bottom Sheet to child component

Hi,
Hope you're having a nice week.
I have a question If there any way that I can import your BS in a child component? I've tried but it only works when I import BS at the parent component. The problem that I'm using the TabView in the parent component so It's hard to get the ID or name prop from the child to parent.
Thanks for your time, sir.

Yes, I have the same issue.


fix: ensure Dockerfile includes etc directory and correct CMD based on config

fix: ensure Dockerfile includes etc directory and correct CMD based on config

Modify dockerCommand to correctly check for etc directory relative to Go file
Use filepath.Join for better cross-platform compatibility
Ensure etc directory is included in Dockerfile regardless of current working directory
Fix issue where CMD was not set correctly due to missing etc directory

Bug Fix: Include etc directory in Dockerfile and set correct CMD based on config
Description
This PR fixes two related issues:

The etc directory was not being included in the generated Dockerfile when running goctl docker from a directory different from where the Go file is located.
Due to the missing etc directory, the Dockerfile's CMD was not being set correctly based on the configuration file.

Problems

When users ran goctl docker from a directory that was not the same as the Go file's location, the generated Dockerfile did not include the etc directory. This caused issues for projects that rely on configuration files stored in the etc directory.
As a consequence of the missing etc directory, the Dockerfile was not able to locate and use the configuration file to set the correct CMD instruction. This led to incorrect startup commands in the resulting Docker containers.

Solution
The fix involves modifying the dockerCommand function to:

Correctly check for the existence of the etc directory relative to the Go file's location, rather than the current working directory.
Ensure that when the etc directory exists, it's properly included in the Dockerfile, and the CMD is set based on the configuration file.

Changes made:

Updated the logic to check for the etc directory using the Go file's path as a reference.
Used filepath.Join for better cross-platform compatibility.
Ensured that the etc directory is included in the Dockerfile if it exists in the same directory as the Go file.
Fixed the logic to properly set the CMD in the Dockerfile based on the configuration file when the etc directory is found.

Testing
Tested the changes by:

Running goctl docker from various directory locations relative to the Go file, confirming that the etc directory is correctly included in all cases where it exists.
Verifying that the generated Dockerfile contains the correct CMD instruction based on the configuration file when the etc directory is present.
Building and running containers using the generated Dockerfiles to ensure they start up correctly with the proper configuration.

Additional Notes
This fix improves the reliability and consistency of the goctl docker command, especially for users working with more complex project structures or running the command from different locations within their project. It ensures that not only is the etc directory properly included, but also that the resulting Docker containers are configured correctly based on the project's configuration files.

This PR addresses a potential issue with path duplication when generating Dockerfiles.
The change uses filepath.Base() to extract just the filename from goFile,
preventing situations where the project path might be inadvertently duplicated.
Changes made:

Modified the GoMainFrom field assignment in the Docker struct to use filepath.Base(goFile).

This change ensures that the path used in the Dockerfile is always relative to the project root,
improving consistency and preventing potential build issues due to incorrect file paths.
Please merge the two submissions together, otherwise it will be incomplete


CI should use redis-stack

This has been blocked by redisearch/redisearch#2803, I think this should have been resolved, not sure if the fix has made it into Redis Stack, when it does this can be addressed.


make typing: ninja: build stopped: subcommand failed.

Describe the bug
Python typing cheking failed when running the command make typing the following error was generated:
/home/ubuntu/shaystack/.pytype/pyi/shaystack/pintutil.pyi
[6/80] check shaystack.sortabledict
ninja: build stopped: subcommand failed.

To Reproduce
Steps to reproduce the behavior:

git clone -b develop https://github.com/engie-group/shaystack.git
cd shaystack/
make configure
conda activate shaystack
make typing

Used environment

conda 4.13.0
ubuntu 22.04 and same error on 18.04
GNU Make 4.3

Error traceback
Check typing...
Computing dependencies
Analyzing 60 sources with 0 local dependencies
ninja: Entering directory `.pytype'
[3/80] check shaystack.pintutil
FAILED: /home/ubuntu/shaystack/.pytype/pyi/shaystack/pintutil.pyi
/home/ubuntu/anaconda3/envs/shaystack/bin/python3.8 -m pytype.single --disable pyi-error --imports_info /home/ubuntu/shaystack/.pytype/imports/shaystack.pintutil.imports --module-name shaystack.pintutil -V 3.8 -o /home/ubuntu/shaystack/.pytype/pyi/shaystack/pintutil.pyi --analyze-annotated --nofail --quick /home/ubuntu/shaystack/shaystack/pintutil.py
File "/home/ubuntu/shaystack/shaystack/pintutil.py", line 24, in _load_haystack_alias: Function importlib.resources.open_text was called with the wrong arguments [wrong-arg-types]
         Expected: (package: Union[module, str], ...)
  Actually passed: (package: None, ...)

For more details, see https://google.github.io/pytype/errors.html#wrong-arg-types
[6/80] check shaystack.sortabledict
ninja: build stopped: subcommand failed.
Leaving directory '.pytype'
make: *** [Makefile:767: .make-typing] Error 1

All these issues have been resolved in Shaystack version 0.10.0


Support for in-memory SSH keys is missing

libgit2 has support for in-memory SSH keys. There is already git2::SSH_MEMORY to indicate that the credentials type is allowed, but a wrapper for git_cred_ssh_key_memory_new is missing.

I this the corresponding PR was merged 7 days ago.
So I tried using 0.7.2which was released 5 days ago.
Yet I still get the following error message:
this version of libgit2 was not built with ssh memory credentials

@promethe42 can you share snippets for how to reproduce to poke around?

@alexchrichton here you go:
pub fn git_credentials_callback(
    _user: &str,
    _user_from_url: Option<&str>,
    _cred: git2::CredentialType,
) -> Result<git2::Cred, git2::Error> {
    let user = _user_from_url.unwrap_or("git");

    if _cred.contains(git2::CredentialType::USERNAME) {
        return git2::Cred::username(user);
    }

    match env::var("GPM_SSH_KEY") {
        Ok(k) => {
            let key_path = path::Path::new(&k);

            if key_path.exists() {
                debug!("authenticate with user {} and private key located in {}", user, k);
                git2::Cred::ssh_key(user, None, key_path, None)
            } else {
                debug!("authenticate with user {} and private key stored in the GPM_SSH_KEY env var", user);
                git2::Cred::ssh_key_from_memory(user, None, &k, None)
            }
        },
        _ => Err(git2::Error::from_str("unable to get private key from GPM_SSH_KEY")),
    }
}

@alexcrichton The issue comes from libgit2-sys. The GIT_SSH_MEMORY_CREDENTIALS flag has to be defined:
cfg.define("GIT_SSH_MEMORY_CREDENTIALS", "ON");

@alexcrichton here is a PR that makes this feature actually usable: https://github.com/alexcrichton/git2-rs/pull/331

sure thing, should be done now!


FR: Shorten Source Information

Could you maybe shorten the source path to the file name only? having the full file path makes it a bit much.

Originally posted by @chrisgrieser in https://github.com/tadashi-aikawa/obsidian-various-complements-plugin/issues/82#issuecomment-1036181524

@chrisgrieser
I have released v5.5.0 🚀
Maybe the default setting of a new option (Short) is what you like :)

works perfectly 💙


nuget dependencies

seems quite a few mods have nugit dependencies, maybe we can improve our schema/automation to directly support them without needing to manualy review them.

Adding as up for grabs since seems like a good idea to me, and nobody has commented to oppose this so far.


The rbfManager has been packaged along with the relevant files related to it.

@joji2468ng  I did the merge, and realized that this will affect ongoing productions importing rbf manager IO and node in custom_steps. So I have ever it.
I am sorry, the idea to keep everything tight is great, but I can't merge it. at less not until 5.0 where will be ok to break back compatibility 😅
Thanks


Updating participant families in Metamist

It would be good to have a mechanism to update the family a participant resides in. In cases where family IDs are provided incorrectly in the original individual metadata manifest, there doesn't seem to be a way to correct the error.
Managing participants in groups linked together by a shared family ID is what seqr hinges on, but we need a way to modify the family of participants in Metamist, then ideally seqr will sync and move that participant from the incorrect family to the correct one.

Small issue that in metamist, participants can belong to multiple families - but agreed we should support this. Happy for you to spec out a change if you've got time.


Ribbon Timeout not working in FeignClient

I create ribbon client in application.properties
ribbon.ConnectTimeout=10
ribbon.ReadTimeout=10

And create feign client
@FeignClient(name = "authFeign", url = "${service.auth.endpoint}",
    fallbackFactory = AuthFeignFallbackFactory.class)
public interface AuthFeign {

But even the response 1000 miliseconds from the service, feign client still using default ribbon connect timeout 2000 miliseconds and read timeout 5000 miliseconds

When you use the URL parameter in the feign client it will not use Ribbon so those Ribbon parameters will not apply.

Hi @ryanjbaxter thanks for the answer, so if I'm using URL, how to set connection timeout? There is no documentation in spring cloud netflix page

I try using configuration attribute, and it works
@FeignClient(name = "authFeign", url = "${service.auth.endpoint}",
    fallbackFactory = AuthFeignFallbackFactory.class, configuration = AuthConfiguration.class)
public interface AuthFeign {

@Configuration
public class AuthConfiguration {

  @Bean
  public Request.Options options() {
    Request.Options options = new Request.Options(
        10, 10
    );
    return options;
  }

}


Cross-origin request blocked when attempting OpenID connect authorization

When trying to login with using Gitlab as an OpenID Connect Provider, staticdeploy will replace the "Login with Gitlab" button with a network error message and the following error will be in the console.
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://gitlab.com/.well-known/openid-configuration.
(Reason: CORS header ‘Access-Control-Allow-Origin’ missing)

When I deliberately mis-configure the OIDC_CONFIGURATION_URL variable so that it would 404 I still get the same error.  So I don't believe it's an issue with Gitlab.
This is the docker-compose file that I'm using.
version: '3'

services:
  staticdeploy:
    image: staticdeploy/staticdeploy
    ports:
      - 80:80
    environment:
      MANAGEMENT_HOSTNAME: local.staticdeploy.io
      OIDC_CLIENT_ID: $OIDC_CLIENT_ID
      OIDC_CONFIGURATION_URL: https://gitlab.com
      OIDC_PROVIDER_NAME: GitLab

Hey @ptwales, thank you for reporting this.
I think this might be due to GitLab not returning CORS headers on that resource (see this GitLab issue).
This unfortunately doesn't allow using GitLab as a OpenID Connect provider, since StaticDeploy uses the browser-only implicit OAuth flow. 😕
As an immediate workaround I think you could use an intermediate provider like Auth0 (tested to work), pointing your StaticDeploy to an Auth0 app, and connecting that app to GitLab (I do this for logging in with GitHub for example, which doesn't support OpenID connect).
A longer term solution would be making StaticDeploy use another OAuth login flow, which is probably a good idea regardless.

I have confirmed that it works with google (mostly, the management screen is still giving me a 401 but that's a different issue).

A longer term solution would be making StaticDeploy use another OAuth login flow, which is probably a good idea regardless.

This would be great since Gitea can be an OAuth2 provider.  Pairing staticdeploy and gitea would make a wonderful little stack for hosting static deployed websites.

A longer term solution would be making StaticDeploy use another OAuth login flow, which is probably a good idea regardless.

I also ran into this issue and I'd like to point out that implicit flow has been deprecated by Gitlab (and new applications will not allow it). But even more important, it has been removed from OAuth 2.1. So it really seems like using OIDC with staticdeploy is going to get harder and harder as a result which is a bummer.

Hey @mtiller , thanks for pointing this out, it does seem like it's time to migrate to another login flow. At the moment I can't commit to a timeline for working on this, but I've opened a dedicated issue to remind me to look at it next time I'll be working on StaticDeploy. Thanks again!


Is there any way to increase the running speed?

Hello, I am very interested in your package, and I also tried to use pairwise alignment. But when the data I input is slightly larger, the running speed will be very slow, and it may take a day. Is there any way to increase the running speed?

I have met this question too.......

Thanks for your interest in our method and for pointing out this issue. We are working on improving on improving the runtime. In the meanwhile, I suggest you give the method an initial alignment to speedup the convergence. You can give it using the Python interface or the command line interface. By default, the optimization starts with a uniform alignment.

Thanks for your interest in our method and for pointing out this issue. We are working on improving on improving the runtime. In the meanwhile, I suggest you give the method an initial alignment to speedup the convergence. You can give it using the Python interface or the command line interface. By default, the optimization starts with a uniform alignment.

Thank you for your reply. Great tool!

Our new recent version supports GPU implementation which should help speed up run time.


Add Composer script handler

Same as #18, + I updated the build script for releases, hopefully didn't mess it up.

This PR couldn't have come at a better time for me. Thanks :)

@fabpot: It'd be nice to merge this to make it easier for people to try symfony/symfony-standard#267


Background colors of text pane

In a project browser, the method pane background may have one of three colors,
Color for Compile Errors (pink)
Color for No Edits (yellow)
Color for Unsaved Edits (green)
However, if you are on the class definition tab (or the class documentation tab), the background is white (usually).  If you edit it turns pink.  Then a compile error is inlined, not displayed in the status bar.
It should DEFINITELY turn green when edited rather than pink - that's just wrong.
I think it should be yellow for no edits.
I see this in reproducing a cross-browser problem... this bug is really a tail-end part of bug #418.  When you have two project browsers open, with the class definition showing in one, the background of the class definition is white.  If you select the same class in a second browser, the background of the text pane in the OTHER browser turns from white to yellow.   I think it's the initial white that's the problem.

Would like to fix this in the next customer release of Jadeite targeted for April. Changing label.

Have a fix for this in 3.0.69. Will need review and, no, I couldn't get the sunit tab header to be anything other than white. The rest are yellow and a dirty class def pane is green - same as method pane dirty.

I don't see anything white on the Sunit tab of the PB.  Just FYI - it looks good.

[ ] The class documentation tab does not turn green on edit.

[ ] in a method browser, the comparison tab backgrounds are white; they are yellow in the project browser.

Class compile errors are currently not working quite correctly, I think, but that's not part of this issue.

Fixed in 3.0.75

This is all consistent in 3.0.75.
I will say that the comparison tab's bright yellow highlights on the softer yellow is... well... not a particularly agreeable color combination.  But it seems like it would be functional and I'll leave it for someone who uses this feature to initiate further aesthetic discussion.


Adding Pompler.com to 'Projects'

Pompler.com - A service that allows images to be shared with popular content being tipped directly in BCH.

This is pretty cool, you should let them know there password requirements are terrible (20 char pw's don't work). They should probably fix that. I will add this tonight. =)


Revert "connectivitycheckcontroller: disable by default"

This reverts commit 7a1eb382378730ad57fad1046f24bf2e715757b8.

/lgtm

/hold

/retest

/hold cancel


Fails to generate JSON schema for time fields

ay go time fields json do string serialize, so json schemas should note this structure

With PR #1420, MarshalJSON() and UnmarshalJSON() have been added to models with date/time fields.
Does it address the failure you reported?


There is a vulnerability in fastjson 1.2.47,upgrade recommended

https://github.com/dianping/cat/blob/facd399416d1caaa3fa2a613d0af963453f8c584/pom.xml#L142-L145
CVE-2020-8840
Recommended upgrade version：1.2.48.sec10

这个问题不处理嘛


DASH-488 add burnnft functionality to oracle script

@orkhan-huseyn Fixes need to go into develop branch for initial testing.


[Feature]: Add the possibility to specify action types to invoke the reducer in the storage sync helper

Context
The requirement is for syncing stores in feature modules instead of the root app module. This requires certain additional action types to be taken into account for invoking the reducer.
Proposal
The idea is to add a new optional property actionTypes to the SyncStorageConfig that will specify the action types for which the reducer should be invoked in case the state is undefined. This is required for syncing feature stores for which the action type UPDATE needs to be taken into account.

Can you explain in which case you have a state that is undefined after the store initialization?


CHEBI:84836, formula to correct

Dear ChEBI team,
Could you please change the formula of CHEBI:84836 1,2-di-octadecenoyl-sn-glycero-3-phosphocholine, to the correct one
C44H84NO8P
such this is the correct formula for CHEBI:74669 1,2-dioleoyl-sn-glycero-3-phosphocholine?
And by the way CHEBI:74669 should be
is a 1,2-di-octadecenoyl-sn-glycero-3-phosphocholine (CHEBI:84836), right?
Thank you very much in advance for the changes.
Best regards,
Anne N.

Dear Anne,
Sorry it too so long to get to this - now sorted.
Kind regards,
Gareth


WFLY-16647 Upgrade smallrye-fault-tolerance to 5.5.0

Resolves
https://issues.redhat.com/browse/WFLY-16647

The CI runs only failed with well-known DiscoveryGroupExternalMessagingDeploymentTestCase, no need to rerun.

Thanks @rhusar


Save all calibration snapshot data for use in Bundle Adjustment

Likely place to start is stereocalibrator.store_stereo_data()
Make sure that data from all pairs is being stored at each eligible capture time for later refinement of calibration.

[ ] Record calibration data from GUI
[ ] Store all points from all cameras from calibration.
[ ] Create Initial Ranked connection of stereopairs

I think this is something that I did in a previous iteration (Learn openGl repo?)
"DaisyChain" method

[ ] Visualize all cameras in pyqtgraph
[ ] Create projections from each stereo-pair

[ ] Visualize in pyqtgraph with different colors


fix(errorEvents/commanderror): ignore UserError

Between @vladfrangu, @Stitch07, @kyranet and myself we've pretty much said no to this PR so I'm closing it.


How to predict?

There is just eval.py and demo.py in the tools, and how can I get the predict result of txt/csv?

@jiangnanwuyanzu We don't support txt/csv format data. You may modify our code by yourself.


feature: optimized sequencer api demo

What this PR does:
optimized sequencer api demo
Which issue(s) this PR fixes:
#579

Thanks for your contribution!


The script is not working as expected - connected by SSH but hungs

Hi team,
This issue was opened due to when I executed this script with GUI option and when the server was selected an issue getting the IP was shown in the prompt:

The first error is shown when the resource group is selected, the other is when the VM is selected.
When I executed from prompt with the parameters, and after troubleshooting, my user (ibmrguardado) opened a SSH connection but seems like was hung. The script didn't finish and no HTML file was generated:

The SSH connection was successful:

Hi @msftphleiten,
I've sent an email with the findings, but still without any log being created.
I execute the script in two paths (C:\Users\RogerErnestoFloresGu\Documents\PowerShell\Scripts\SAP and C:\Program Files\PowerShell\7) but any file was created.

hi @msftphleiten, I hope you are doing well.
Can you please give me an update regarding the modifications in this script we troubleshooted in out last session?
If we need to schedule a new meeting to validate this, please let me know.


Expand IWebAuthenticationCoreManagerInterop pages

Make clear the relationship between the IWebAuthenticationCoreManagerInterop interface and UWP WebAuthenticationCoreManager.

Show how to get a IWebAuthenticationCoreManagerInterop reference from a WebAuthenticationCoreManager.

Show the correlations between ...Interop methods and the corresponding ...CoreManager methods.

@metathinker : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@metathinker : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@metathinker : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@metathinker : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@stevewhims : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Rather than delete the description from the interface topic (sdk-api-src/content/webauthenticationcoremanagerinterop/index.md), is there a better description that we can give?

The file <webauthenticationcoremanagerinterop.h> only contains the IWebAuthenticationCoreManagerInterop interface, so any description in the main topic for the file (which is the source file you're pointing to) would necessarily duplicate the description in the interface's main topic, in sdk-api-src/content/webauthenticationcoremanagerinterop/nn-webauthenticationcoremanagerinterop-iwebauthenticationcoremanagerinterop.md. In fact, in the old version of the 2 files, the description sections did duplicate each other exactly.
That's the reason I deleted the description in the file topic. I wouldn't object to putting it back, however.

@stevewhims : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@stevewhims : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@stevewhims : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good, I think that duplication is necessary/unavoidable in this case, and it's ok. I've added that.
Note that links can be tricky, but I made them all site-relative so that the Microsoft Help Viewer works with them.
As for the pre-existing "Type:" sections, there were a number of problems with those, so deleting them was reasonable, but I tend to like the value that those add, and the expectation they set (I'm trying to get them into every topic), so I fixed up the pre-existing problems with them and restored them.
Thanks for your contribution! :)
-Steve


Fix Velox nightly builds

Builds are failing with :
The workflow is not valid. .github/workflows/linux-nightly.yml (Line: 36, Col: 30): Unrecognized named-value: 'secret'. Located at position 1 within expression: secret.AWS_PYTORCH_UPLOADER_ACCESS_KEY_ID .github/workflows/linux-nightly.yml (Line: 37, Col: 34): Unrecognized named-value: 'secret'. Located at position 1 within expression: secret.AWS_PYTORCH_UPLOADER_SECRET_ACCESS_KEY

Secrets needs to be provided before workflow runs via workflow input. Added pull request check for initial testing.

Looks like upload succeed!

upload: fixed_dist/torcharrow-0.0.2.dev20220314-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl to s3://pytorch/whl/nightly


Tooltips for in-line documentation/guidance

We should add tooltips or "info" icons and populate them with text. This ticket is two-fold: I can add the icons, but someone else can add the text. Or I can add the text.


7zip Header files in output dir missing

Describe the bug
After building the 7zip,
Header files are missing in include\7zip\CPP
Missing directories of Header Files:  include\7zip\CPP\Windows ,  include\7zip\CPP\7zip\Bundles,  include\7zip\CPP\7zip\Common,  include\7zip\CPP\7zip\Compress,  include\7zip\CPP\7zip\Crypto,  include\7zip\CPP\7zip\UI
and in   include\7zip\CPP\7zip\Archive only 5 header files are there
Environment

OS: Windows 10
Compiler: MSVC 2019

To Reproduce
Steps to reproduce the behavior:

./vcpkg install 7zip

No error shows

@DSP-ENP, Thanks for posting this issue, I can not reproduce your error on my machine:
PS F:\Feature-test\vcpkg> ./vcpkg install 7zip --editable
Computing installation plan...
The following packages will be built and installed:
<EMAIL_ADDRESS>Installing 1/1<EMAIL_ADDRESS>Building<EMAIL_ADDRESS>Downloading ip7z-7zip-24.09.tar.gz
warning: Download failed -- retrying after 1000ms
Successfully downloaded ip7z-7zip-24.09.tar.gz.
-- Extracting source F:/Feature-test/vcpkg/downloads/ip7z-7zip-24.09.tar.gz
-- Using source at F:/Feature-test/vcpkg/buildtrees/7zip/src/24.09-69efbab586
-- Found external ninja('1.11.0').
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: F:/Feature-test/vcpkg/packages/7zip_x64-windows/share/7zip/copyright
-- Performing post-build validation
Elapsed time to handle 7zip:x64-windows: 1.6 min
Total install time: 1.6 min
7zip provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(7zip CONFIG REQUIRED)
  target_link_libraries(main PRIVATE 7zip::7zip)

Please  re-run the ./bootstrap-vcpkg.bat script to update the vcpkg tools and try again.

JonLiu1993  did you get all header files in Dir : vcpkg\installed\x64-windows-static\include\7zip
if yes can you check  vcpkg\installed\x64-windows-static\include\CPP\7zip\Archive\Zip\ZipHandler.h is present in output.

@JonLiu1993 did you get all header files in Dir : vcpkg\installed\x64-windows-static\include\7zip
if yes can you check vcpkg\installed\x64-windows-static\include\CPP\7zip\Archive\Zip\ZipHandler.h is present in output.
downloaded vcpkg today itself

I get header files in Dir as follow : vcpkg\installed\x64-windows-static\include\7zip:

I don't get cpkg\installed\x64-windows-static\include\CPP\7zip\Archive\Zip\ZipHandler.h


AWSO 2.9.0 Docs update

Purpose of this pull request
Added new dashboards for MSSQL in Amazon RDS section for AWSO, and incorporated the AWSO 2.9.0 related changes.
Select the type of change

[ ] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions, updating sections
[x] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)
https://sumologic.atlassian.net/browse/SUMO-240446

Merged the PR: https://github.com/SumoLogic/sumologic-documentation/pull/4290 in order to maintain a single PR for AWSO 2.9.0 docs changes.


Differentiate both redirect apps better in share menu

Is your feature request related to a problem? Please describe.
As I'm a user of Lemmy and Mastodon, I also use both redirect apps. I've noticed that in the share menu you can't really differentiate which app is for which network. That's confusing and frustrating.
Describe the solution you'd like
You should be able to easily differentiate the two apps. Probably the easiest solution would be to add the corresponding network to the apps name in the share menu. Since there are apps that utilize two lines for the app name, maybe you can do it too. My suggestion would be to simply add the networks name under the apps name, e. G.
first line: Open Link
second line: Mastodon (or Lemmy)
Describe alternatives you've considered
Another good way of differentiation would be to allow the user to change the color of the app icon. Although I don't know if this would also change the apps icon color in the share menu or if it would instead use the default color 🤔
Or change the app icons a bit, e. G. add a "Mammoth" for the Mastodon redirect app for easier differentiation.
Additional context
Below I've attached a screenshot to demonstrate my problem.

P.S: Thanks for taking the time to read & developing this nice app 👍

Addressed in 1.12.1 https://github.com/zacharee/MastodonRedirect/releases/tag/1.12.1


[wip] aliases: add old aliases for previous Nixpkgs version

This is adapted from my post:  https://matthewbauer.us/blog/channel-changing.html.
I am still undecided whether this is a good idea but I definitely
think it’s cool. This adds some top-level attributes for old releases
of NixOS/Nixpkgs. With them you can combine old versions of stuff in
one package, fairly easily:
{ pkgs }:
pkgs.impala.stdenv.mkDerivation {
  name = "hello";
  src = pkgs.impala.fetchurl { ... };
  buildInput = [ pkgs.gorilla.firefox
                 pkgs.emu.libedit ];
}

You could move this under a new nixos-releases top level attribute, and this should fix the evaluation error reported by the bot.

Yeah that would be an overlay then, right? Does that make sense to people? I originally thought of having it be fixed output here, but I thought that would be too much to maintain, constantly updating old hashes (although a bot could be useful).

Closing for now.


Add support for mock generation to match the original headers Subdirectory

My current project has a very nested folder structure which forces us to use globs in the :include: section of our project.yml which in turn at some point caused the gcc-compile command to exceed the maximum command-line length.
In order to fix this i would like to eliminate the need for globs while also allowing us to mock headers located in Subdirectories.
This pull request allows ceedling to generate mocks for headers located in sub directories. (also requested by #358 )
This allows headers in sub directories to be mocked without using globs in the :include: section of the project.yml
The following use-cases would now be supported:
#include "Subdir/Mock_Test.h"
#include "Mock_Test2.h"
#include "Subdir1/Subdir2/Mock_Test3.h"

Current Limitations:

The FFF plugin's setup_mocks()-function still needs to be updated to allow sub-directory mocks (BREAKING CHANGE)
Will do that if this is pull-requests is something thats needed/wanted.
Mocking multiple headers with the same name is currently (probably) not supported because of the way ceedling handles dependencies.
Unfortunatly a CMock update is required to allow it to generate mocks in Subdirectories.

Further improvements:

Allowing ceedling to mock multiple headers with identical names could maybe achieved by modifying the way dependecy names are generated by file_path_utils.rb and modifying the preprocessinator.rb to use it.
The file_finder.rb would probably also need to be updated aswell.

Disclaimer: Im no professional ruby developer so im more than happy for any feedback :)
If there are any issues please let me know :)
Related CMock pull request: https://github.com/ThrowTheSwitch/CMock/pull/327
Thanks to @alex116 for is work in #343.

Hello,
first of all: Thank you @mvandervoord for merging my PR in the CMock repository. I really appreciate it :)
I resolved the merge conflicts by updating cmock submodule to the latest version and reversed it pointing to my custom version.
Is there anything else required in order for this to be mergeable?
(Update the FFF plugin maybe? I will take a look if this pull request is something that is desired)

Hello,
first of all: Thank you @mvandervoord for merging my PR in the CMock repository. I really appreciate it :)
I resolved the merge conflicts by updating cmock submodule to the latest version and reversed it pointing to my custom version.
Is there anything else required in order for this to be mergeable?
(Update the FFF plugin maybe? I will take a look if this pull request is something that is desired)

@Hannes103 -- thanks for the good work! I think this is going to make a lot of people happy. Supporting subdirectories is a frequently-requested feature.
I would definitely appreciate it if you resolved the FFF plugin issue. At that point, it appears it doesn't have any breaking changes and should be safe to submit.
If you're interested in continuing to help, I'd love to see a followup PR towards handling the "same" filename under multiple directories. I'd be happy to help or talk through that.

@Hannes103 -- thanks for the good work! I think this is going to make a lot of people happy. Supporting subdirectories is a frequently-requested feature.
I would definitely appreciate it if you resolved the FFF plugin issue. At that point, it appears it doesn't have any breaking changes and should be safe to submit.
If you're interested in continuing to help, I'd love to see a followup PR towards handling the "same" filename under multiple directories. I'd be happy to help or talk through that.

@mvandervoord
I have update the FFF plugin to also support sub folder mocks.
Once its merged this should also be ready.
However I would need some help to determine why the CI checks are failing. I cannot replicate it on my machine.
It seems to have some problems creating the fake_project folder.
However it seems kind of random to me because I have not modified any tests.

@Hannes103 -- It appears that Ceedling is crashing during most operations and not creating the projects it's supposed to be testing. Unfortunately, the errors being shown don't tell us much. I'll see if I can get it to send us more useful information.

Hello!
I'm glad to inform you that corresponding pull request to FFF plugin is merged and included in the latest release (v0.2.0).
While I'm at it, @mvandervoord , may I ask you to please investigate why FFF plugin distribution shipped with Ceedling gem is broken? Considering presence of sublime text editor files in gem archive it looks like gem is generated manually, so I think this is some kind of human error leading to removal of plugin's "vendor" subfolder.

Hello everyone! Happy to see this is a work in progress. This PR closes #358, right? Thanks!

@papb hello! Yes, AFAIK this PR will solve the issue you linked.

Is this going to be merged?

Hello @Hannes103 @mvandervoord, are there any plans to merge this? This seems like really necessary feature.
I'm currently stuck at mocking inline functions that are included with subdirectories paths and this feature seems like the only way to do it.

Thanks for the continued pings and especially for the original work! You people are great!

Wow, that was fast! Thanks!

Only if you ignore the date/time this thread actually started. ;)

Yeah, it was more of a "that was fast reaction cosidering the activity in this PR" ;)

@mvandervoord please please please look into this issue on the next release.

Hi is this merge in the latest release ?

It is in the release candidate (which you can find by going to releases)

@mvandervoord Thanks .
Sorry for newbie question
can I install the Rc with  gem install ceedling -v 0.32.0  ?

Ruby gems don't get posted for the automatic installer until they are official releases... so if you'd like to test a release candidate, you download it to your machine, then from a command prompt in the same directory, you use this:
gem install --local ceedling-full-filename.gem

@mvandervoord Is there any work going on to allow ceedling to work with multiple files with identical names?
There seem to be a few issues mentioning this topic but im not entirely sure if this is something thats currently being worked on by someone?
If not, I might have a go at it.
Thanks in advance.

A large portion of the work exists already and is in the pre-release branch for 0.32. This will likely be released without full support for this feature yet, but then it's a high priority to finish this feature for the next release. You're welcome to take a look at that branch. We appreciate the help!


FR: Multiple region support for samconfig.toml

Describe your idea/feature/enhancement
Most serverless apps I build are designed for active-active across multiple regions. While it's easy to use samconfig.toml to quickly deploy my app within a single region for dev I recently found myself jumping back and forth between two config files for us-east-2 and eu-west-2. The process was cumbersome because there's no argument for passing which toml file to use ( #1615 )and I need to rename the files every time I wanted to deploy to both regions.
If I'm working on an app and I want to have it go to multiple regions when I run sam deploy it might be beneficial to be able to store those options in one config file and then the deploy action would iterate over them using the same set of build artifacts locally.
This is actually what we do in CodeBuild jobs in CodePipeline. The script in CodeBuild will run sam build and then we loop over a list of regions passed into the env vars and run sam package for each. The output deployment templates are then passed to CloudFormation actions in the next stage.
Proposal
Here's the current 0.1 spec for a config file that's generated:
version = 0.1
[default]
[default.deploy]
[default.deploy.parameters]
stack_name = "my-api"
s3_bucket = "aws-sam-cli-managed-default-samclisourcebucket-xxxxxxxxxx"
s3_prefix = "my-api"
region = "us-east-2"
profile = "my_profile"
capabilities = "CAPABILITY_IAM"
parameter_overrides = "Foo=\"Bar\""

I understand there is a semi-hidden feature where other environments can be set besides default with some overrides. Maybe the .deploy.parameters can be extended with region/environment specific overrides.
version = 0.1
[default]
[default.deploy]
[default.deploy.parameters]
stack_name = "my-api"
s3_prefix = "my-api"
profile = "my_profile"
capabilities = "CAPABILITY_IAM"
[default.deploy.parameters.us-east-2]
s3_bucket = "aws-sam-cli-managed-default-samclisourcebucket-xxxxxxxxxx"
parameter_overrides = "Foo=\"Bar\""
[default.deploy.parameters.eu-west-2]
s3_bucket = "aws-sam-cli-managed-default-samclisourcebucket-xxxxxxxxxx"
parameter_overrides = "Foo=\"Baz\""

The presence of the region suffix would trigger package/deploy logic for multiple regions.

I believe this is covered by #1615, so closing this as a duplicate of that feature request. If multiple config files/profiles would not be sufficient for your issue, please feel free to add additional context in that issue.


Missing some NonDataEvents like FE (framing error), PE (parity error), OE (overrun error)

Dear all,
currently I'm trying to detect misconfigurations between sender and receiver especially different setting in communication parameters (parity, number data and stop bits).
Normally such a misconfiguration leads to events at the receiver site (SerialPortEvent.FE/PE/OE).
But in PJC these events are never created.
Looking into PureJavaSerialPort.java I found the method sendNonDataEvents() but only the events of the control lines (DSR, CTS, RI and CD) are created here.
Is it correct that the events FE, PE and OE are never created?
I compared PJC with RXTX and in RXTX the events are created as expected. So I'm wondering if this is a missing feature in PJC or if there are other limitations?
Thanks in advance and best regards

On 4 Sep 2018, at 19.26, SLeit<EMAIL_ADDRESS>wrote:
Dear all,
currently I'm trying to detect misconfigurations between sender and receiver especially different setting in communication parameters (parity, number data and stop bits).
Normally such a misconfiguration leads to events at the receiver site (SerialPortEvent.FE/PE/OE).
But in PJC these events are never created.
Looking into PureJavaSerialPort.java I found the method sendNonDataEvents() but only the events of the control lines (DSR, CTS, RI and CD) are created here.
Is it correct that the events FE, PE and OE are never created?
I compared PJC with RXTX and in RXTX the events are created as expected. So I'm wondering if this is a missing feature in PJC or if there are other limitations?
Thanks in advance and best regards
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I guess we have to call this a missing feature. I'd be happy to get a pull request on that ;)
cheers Kusti

Nice to see that there is interest for that ;-)
So I will get in touch with the JTermios but I currently I have no idea how much time this will take.
If there is anyone whow has experience with the WinAPI (I think ClearCommError() is the keyword) so feel free to participate.
best regards


[meta] Document DXVK_CONFIG in readme

dxvk.:frog: = True

I'd drop the note about # and put an actual example with two options in so you can see the ; separator in action.

Hope it's fine i also moved the two lines down since the example with two configs might look a bit unwieldy in the middle when it's so long compared to the others.


fix: search page top bar is hidden after deleting an expense

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/52497
PROPOSAL: https://github.com/Expensify/App/issues/52497#issuecomment-2488977807
Tests

[Mobile Web & Native only]

Submit expenses so that the expenses list in Search page is SCROLLABLE (list height exceeds app height)
Scroll down so that search page header (search type menu, filter button, search status bar) is hidden
Long press an expense > Select to toggle selection mode
Delete several expenses to make the list NOT SCROLLABLE (list height not exceed app height)
Tap Back to exit selection mode
Verify search page header does not disappear

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Same as Tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/8f404f0a-db6f-49e1-a3d6-bd986e70554a

Android: mWeb Chrome

https://github.com/user-attachments/assets/73cec36f-3352-4395-a62f-0dabcb730806

iOS: Native

https://github.com/user-attachments/assets/78660792-5c5a-40fb-ba11-818854579e3d

iOS: mWeb Safari

https://github.com/user-attachments/assets/4648b94c-6bc7-4951-95a9-1475dd78c61f

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@hannojg do you think this is a real performance regression?

Hm, this one might be, would be interesting to reproduce locally!


Custom properties on choices and selected items

PR for issue #185

Perfect!! Thanks so much, this is a great addition.


Can I get result with dash?

I scanned the license plate number AA-1234, but the result returned is AA1234
Can i get result AA-1234 ?

No, there is no such an option.


Updating find_rocm_config.py to account for ROCm 5.2 related header file changes (ROCm version header)

This PR is really a continuation for PRs #1603, #1605, #1607, #1612, #1614, #1617 and #1620(in the ROCm TF fork)
Newer ROCm 5.2 builds are running into build failures related to ROCm version header file location/content updates.
This commit applies the same fix (updated location, newer locations searched first) to the ROCM version header files

jenkins : retest Ubuntu-sanity please

jenkins : retest Ubuntu-GPU-multi please


Remove explicit relay handling

@st-review merge it!

:ok_hand: Merged as 3c2dc032ca346cf68b20f981d71f7d2d20bc4c6d. Thanks, @AudriusButkevicius!


update py3dns

Bump py3dns version to make is import without asyncore on python-3.12
https://launchpad.net/py3dns/+milestone/4.0.0
rename attribute pydns to py3dns to match the package name

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

tested with (apart from nixpkgs-review)
$ NIX_PATH=nixpkgs=/tmp/nixpkgs/ nix-shell -p 'python312.withPackages (p: [ p.py3dns ])' --command python3.12
install: cannot remove '/tmp/env-vars': Operation not permitted
Python 3.12.6 (main, Sep  6 2024, 19:03:47) [GCC 13.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from DNS import ParseResolvConf, Request
>>> ParseResolvConf()
>>> Request(qtype='A').req("nixos.org").answers
[{'name': 'nixos.org', 'type': 1, 'class': 1, 'ttl': 20, 'rdlength': 4, 'typename': 'A', 'classstr': 'IN', 'data': '<IP_ADDRESS>'}, {'name': 'nixos.org', 'type': 1, 'class': 1, 'ttl': 20, 'rdlength': 4, 'typename': 'A', 'classstr': 'IN', 'data': '<IP_ADDRESS>'}]

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 351242

x86_64-linux

:white_check_mark: 16 packages built:

python311Packages.py3dns
python311Packages.py3dns.dist
python311Packages.pymilter
python311Packages.pymilter.dist
python311Packages.pyspf
python311Packages.pyspf.dist
python312Packages.py3dns
python312Packages.py3dns.dist
python312Packages.pymilter
python312Packages.pymilter.dist
python312Packages.pyspf
python312Packages.pyspf.dist
spf-engine
spf-engine.dist
trustymail
trustymail.dist

Thank you!


convertUnresolved sometime fails on large playlist

when resolving large spotify playlist, convertUnresolved may fails

seems to be fixed in latest master, tried 1k playlist. and no error occured.


[network] fix connected peers counter

Motivation
https://github.com/libra/libra/issues/3128
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
existing tests.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@bors-libra r+

:pushpin: Commit 18549cf has been approved by davidiw

:hourglass: Testing commit 18549cf9971f1a92a1381e83a653c356e71d5f55 with merge d231a132b1f0f4465b8affde73d826a21f261bfe...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: davidiw
Pushing d231a132b1f0f4465b8affde73d826a21f261bfe to master...


Update to handle SDF version 0.81

There were no breaking updates to the coordinated bombing attack example, which retained its 0.8 version.


[BUG] Other dates are not working as intended

Describe the bug
Last month I posted a similar issue about how the date of birth was displayed as a day before when downloading PDFs, this issue is now gone (thanks) but it seems like more dates are actually affected by this problem.

Product Flavor

[X] Managed (https://rxresu.me)
[ ] Self Hosted

To Reproduce
When I enter a date for a certificate the preview is fine but when downloading the PDF the date is one day before.
Again, I'm in France if it helps

Expected behavior
The date should be the same in the preview and in the pdf

Screenshots

Desktop (please complete the following information):

OS:
Browser
Version

Additional context

Want to point out that this happens to both the dates on each section as well as date of birth for me

bump

This issue should be fixed as of v3.6.17.

Yeah, about that, at least for me, when using the website  it is still off when rendering the PDF.
PDF:

Website:

The birthdate is fine though.
Just so you have all informations: I'm in France. Like the last issue I posted said, it may be because of timezone differences when my browser shows me the dates on the page it is in UTC+1, whereas the server where the render is made (I assume the US) is in UTC-5 so this might be why.
*Sorry to

Okay so, after some investigation I found out that I had to rewrite all my dates in inputs to get them to work when rendering.


adding in monorail.intel.ipxe for NUC support

requires https://github.com/RackHD/on-imagebuilder/pull/51 to be merged prior to this being fully operational (need the merge to generate binaries in bintray for this to work)

👍

:+1:

test this please

:+1:


for Julia 0.4: rename to HTTPServer

Make naming of 'HTTP' packages (HTTPClient.jl, HttpServer.jl, HttpParser.jl, and HttpCommon.jl) consistent. Timing to mirror timing of rename of Color.jl to Colors.jl.

Closing in favour of https://github.com/JuliaWeb/Roadmap/issues/3


Option for segment metadata only upload

Adding a new API that allows users to upload segments by only sending their segment metadata files
Putting up for early feedback, tests are in progress

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b0c20b7). Click here to learn what that means.
The diff coverage is 28.23%.

@@            Coverage Diff            @@
##             master    #2953   +/-   ##
=========================================
  Coverage          ?   69.83%
=========================================
  Files             ?      914
  Lines             ?    43343
  Branches          ?     5926
=========================================
  Hits              ?    30267
  Misses            ?    11039
  Partials          ?     2037

Impacted Files
Coverage Δ

.../com/linkedin/pinot/filesystem/PinotFSFactory.java
0% <0%> (ø)

...i/resources/PinotSegmentUploadRestletResource.java
51.2% <32.83%> (ø)

.../com/linkedin/pinot/controller/ControllerConf.java
42.74% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c20b7...864e841. Read the comment docs.


UnhandledPromiseRejection when using notFound or redirect functions

Hi,
We have just discovered an issue where we can see Runtime.UnhandledPromiseRejection in the logs when using the notFound or redirect functions from next/navigation. The error messages are Error: NEXT_NOT_FOUND and Error: NEXT_REDIRECT, with the page itself displaying Internal Server Error, rather than executing the function.
This is a replica of the code, which lives in this file path: /src/app/blogs/[slug]/page.tsx.
const post = await getPost(params.slug);

if (!post) {
  notFound(); // or redirect('/')
}

When running this locally, it works as expected, with either a 404 page or redirect. We are using Next 14.1.2, SST 2.40.6 and OpenNext 2.3.7.
If there is more information I can provide, please just ask.
Thank you.

It is executing the function, these functions are supposed to throw those exceptions. But it should be handled by NextServer itself.
I've tried to reproduce with something like that with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>and it works just fine.
Could you provide a minimum reproduction ?
import React from 'react';
import Image from 'next/image';
import { notFound, redirect } from 'next/navigation';

export const dynamic = "force-dynamic"

const Product = async ({ params: { id } }: { params: { id: string } }) => {

  if(id=== "not-found") {
    notFound()
  }
  if(id === "redirect") {
    redirect("/product/1")
  }
  return (
    <div>
      THE COMPONENT
    </div>
  );
};

Hi,
Please find the minimum reproduction here: https://github.com/leanderiversen/open-next-379
It looks like there could be an issue with output: standalone , rather than OpenNext, as it looks like it fails to fetch the CSS and JS required.
Happy to report this to Next directly if that is the case.
Thank you!

This does not reproduce the issue at all, i added sst and deployed and both notFound and redirect works.
For your information, with standalone output you have to manually add the css and js

Hi,
I am very sorry about this. Following your feedback, I have managed to find the root cause, which was an unexpected error in the fetch function used in generateStaticParams, when there were no data to fetch. The fetch function returns an empty array when there is no content during build, so I suspect that something was going wrong when trying to fetch the data on demand when visiting the /blogs/[slug] pages.
Sorry for the inconvenience this has caused.


Unable to set max/min zoom on Android

I have been able to get expected results on iOS using maxDelta on MapView but am not able to get the same behavior on Android using maxZoomLevel or minZoomLevel. They don't seem to have any effect, is anyone else having this issue?
I am using CRNA, with expo 20 and react-native-maps 0.15.3

minZoomLevel and maxZoomLevel have been implemented on 0.16


[upstream] [feature] Parametrize launcher image in KFPV2

Upstream issue copy for tracking: https://github.com/kubeflow/pipelines/issues/10229

Created an issue to track this upstream: https://github.com/kubeflow/kfp-tekton/issues/1416

Closing this issue as completed since the relevant PR has been merged in upstream kubeflow/pipelines.


Hotfix#189

This pull request resolves #189
This PR is ready to be merged

Pull Request Test Coverage Report for Build 659

2 of 9 (22.22%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.09%) to 96.13%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

autokeras/utils.py
2
9
22.22%

Totals

Change from base Build 634:
-0.09%

Covered Lines:
1888

Relevant Lines:
1964

💛  - Coveralls


API: estimateGas does not return correct values for contract creation txs.

I'm running:

Which Aion version?: 0.3.2
Which operating system?: Linux
Which distributor and version?: Ubuntu 16.04
How installed?: from source
Are you fully synchronized?: yes
Did you try to restart the node?: yes

Contract creation transactions have a minimum gas value of 200,000. However, when estimateGas is called with a contract creation transaction (indicated by an empty to field), the value returned is sometimes below 200,000.
As an example, the following web3 call currently returns an invalid estimate of 90,000.
web3.eth.estimateGas({value:0,data:0x1}).then(console.log)

The simplest workaround to this bug is to avoid using the estimateGas API call for contract creation transactions for now. The minimum gas value for such transactions is 200,000. I suggest using a value of 250,000 to ensure successful contract deployment.


[Feature] add kernel level benchmark

Checklist

[ ] 1. If the issue you raised is not a feature but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
[ ] 2. Please use English, otherwise it will be closed.

Motivation
use triton benchmark utils https://triton-lang.org/main/python-api/generated/triton.testing.do_bench.html#triton.testing.do_bench to benchmark kernels (flashinfer, triton, vllm, tensorrt llm, cudnn etc)
Related resources
No response

Currently, the main branch already has some e2e benchmarks, but this is far from enough for us. We need kernel-level benchmarks, ranging from small batch size to large batch size, various shapes, and data types. Compared to existing libraries, what level are we at, and how much room for optimization is there?

ref https://github.com/sgl-project/sglang/pull/2486


Use mojo's scripts for downloading android tools on the bots

Alternatively I could teach the bots that they (normally) have an engine build sitting right next to their flutter build, but it seems better to keep the builds hermetic.
@abarth

LGTM


Revert "Only call ctx.fireChannelReadComplete() if ByteToMessageDecod…

…er decoded at least one message."
This reverts commit d63bb4811ed8ccd5d9e45853f3ac6aee9da7ecab as this not covered correctly all cases and so could lead to missing fireChannelReadComplete() calls. We will re-evalute d63bb4811ed8ccd5d9e45853f3ac6aee9da7ecab and resbumit a pr once we are sure all is handled correctly

@Scottmitch yep will do then merge.

Cherry-picked into 4.1 (123e07ca80bb9cc58ebee598ff0a9379ad9a09fd) and 4.0 (703dc8c95dc9aa30dacfeb23c4db4f97d69cd207)


KAFKA-14587: Move AclCommand to tools

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@mimaison could you please fix conflicts?


Wholebody yaml missing

Hi, I get the following error when I try to run the demo.py to extract 2d keypoints
FileNotFoundError: [Errno 2] No such file or directory: 'wholebody_w48_384x288.yaml'

Thanks for pointing out. The missing .yaml file is uploaded to the wholepose folder.

I also need the wholebody_w48_384x288.yaml file. Where should I find it?

FileNotFoundError: [Errno 2] No such file or directory: 'wholebody_w48_384x288.yaml'

It can be found in the Google Drive shared folder link

Hi, a password is required to unzip the validation_labels.zip and test_labels.zip.
How I have to proceed?
Thanks in advance


Write a full test scenario for the disableDriftDetection feature

The new .spec.disableDriftDetection requires a full specification as the following.

a Terraform object with "auto" mode performs "plan" and "apply", with interval like 10s. We set 'disableDriftDetection" to "true"
then we wait 20s.
the Ready condition should NOT be changed to "NoDrift", as the detection is disabled.

@chanwit I can follow up with this.

Thank you @phoban01


[release-4.15] OCPBUGS-36325: Set required-scc for openshift workloads

OCPBUGS-36325
Manual cherry-pick of #1008

/retest-required

/retest-required

/retest-required

/retest-required

/lgtm

/label backport-risk-assessed

Installed some platform and regression, upgrade test
/label qe-approved

/cherry-pick approved

/label cherry-pick-approved


Fixed bugs

Add additional rule to EDGE SG (access from SSN)
Add additional rule to EDGE SG (3128 port)
Fix issue with rollback (with edge_conf['dataengine_instances_name'] variable)
Fix issue with getting EDGE IP address
Removed unimportant SG rules from SSN


merge request id added to pipeline hook

fixes #26

This is amazing! 💥 🙇
Now we can trace all gitlab build events associated with a pull request!


echart and material-ui card: resposive width and height

Version
5.2.0
Reproduction link
This is the link to my codesandbox with the issue
Steps to reproduce
open console, in codesandbox and the error message is there
What is expected?
echart taking the width and height of parent component
What is actually happening?
Can't get DOM width or height. Please check dom.clientWidth and dom.clientHeight. They should not be 0.For example, you may need to call this in the callback of window.onload.
in Newvsresturnvisitors (at card.js:34)
in SimpleCard (at src/index.js:50)
in App

I tried your demo

The clientHeight is 0. Please make sure your DOM has proper clientWidth and clientHeight when initializing chart. If not. do resize when the DOM size is prepared.

I have give it a proper width and height
 return (
    <div
      ref={chart}
      style={{
        width: "500px",
        height: "300px",
        background: "white"
      }}
    />
  );

but i want to update those values of the parent width and height. Thats the part I am having the issue?

You can specify the chart width and height explicitly:
echarts.init(dom, null, { width: 500, height: 300})

but how do i capture when the card changes its width and height? how do I then use those values and set it as the chart own width and height ?


Private key permissions too permissive

Subject of the issue
Postgres fails to start because the permission on the key is too loose (0644)
Environment

Kubernetes version: k3s version v1.23.6+k3s1
Cloud provider or hardware configuration: Mythic Beasts
OS (e.g., from /etc/os-release): Debian 11
Kernel (e.g., uname -a): 5.10.0-14-amd64
Install tools:
Other:

Steps to reproduce
Install autocert
Create a deployment based on docker.io/postgres:14.3-alpine
Update postgres config to point at autocert cert/key
Start postgres
Expected behaviour
Postgres should start with TLS using auto cert keys
Actual behaviour
Postgres fails to start:
2022-06-01 18:24:51.139 GMT [37] FATAL:  private key file "/var/run/autocert.step.sm/site.key" has group or world access
2022-06-01 18:24:51.139 GMT [37] DETAIL:  File must have permissions u=rw (0600) or less if owned by the database user, or permissions u=rw,g=r (0640) or less if owned by root.
2022-06-01 18:24:51.139 GMT [37] LOG:  database system is shut down

Additional context
The bootstrapper script explictly sets the permissions on the cert and key to 644.
Given that the duration attribute is passed through to bootstrapper, could you add a set of attributes for cert/key owner/group/mode?

This looks great, thanks!
Any idea when the next release is going to be posted?


Retrieve more than 10k results from BSO

Probably using the search-after param https://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html ?

Yes exactly, based on https://www.elastic.co/guide/en/elasticsearch/reference/current/point-in-time-api.html, I am currently on it as I did it in python before, it is "just" a translation task. But I will close this issue as it is a duplicate of #2


Support for string:uuid

Is it reasonable to suggest support for uuid strings? I understand that it is not required within spec, however the option to specify type (string) and format (uuid) would aid in describing an attribute.
Thoughts?

Have you tried using parameter definitions? I think you can define the type once, then use it globally.
Though it might be a good idea to include some pre-defined and well-recognized default formats such as RFC-4122 format UUID's.

I am working with parameter definitions and this is what I've got.
What I've got
/**
 * rest\query? string userId
 */

{
    "name": "userId",
    "in": "query",
    "type": "string"
}

What I want:
{
    "name": "userId",
    "in": "query",
    "type": "string",
+   "format": "uuid"
}

With your RFC-4122 suggestion:
{
    "name": "userId",
    "in": "query",
    "type": "string",
+   "format": "uuid",
+   "pattern": "^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$"
}

What datetime does (similar to what I want)
/**
 * rest\query? datetime createdAt
 */

{
    "name": "createdAt",
    "in": "query",
    "type": "string",
    "format": "date-time"
}

Proposal
/**
 * rest\query? uuid userId
 */

I believe that would mean updating PHPSwaggerGen/SwaggerGen/Swagger/Type/StringType.php with:
	private static $formats = array(
		'string' => '',
		'byte' => 'byte',
		'binary' => 'binary',
		'password' => 'password',
		'enum' => '',
+		'uuid' => 'uuid',
	);

I would prefer instead to specify a format along with the type, but I wouldn't know how to express it nor build it.
Crappy example below:
/**
 * rest\query? string{"type":"uuid"} userId
 */

Here's an example of how zircote/swagger-php does it:
/**
 *     @SWG\Parameter(
 *         name="userId",
 *         in="query",
 *         type="string",
 *         format="uuid",
 *         required=false,
 *     ),
 */

While I think zircote/swagger-php's composition is extremely verbose and long-winded (most of my annotations tower over my code!), it does allow me to describe formats.

I'm working on a mechanism for including uuid (and possibly others), but am still working on a simple syntax. However, Swaggergen currently already supports patterns and such:
/**
 * rest\query? string(^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$) userid
 */

This works just fine. The only problem is the difficult syntax.
What I'm currently trying to do is boil it down to something like
/**
 * rest\query? uuid userid
 */

The reason I'm still working on it, is because I'm conflicted about the syntax. This might conflict with people who have made their own uuid definition. I guess an RFC-4122 compliant UUID wouldn't be much of a problem, but perhaps you subject suggests a nicer solution to this problem:
/**
 * rest\query? string:uuid userid
 */

But that would require the user to know that a UUID's is a type of string internally. Ideally, the user shouldn't need any knowledge of the internals or the Swagger/Open-API specification.
I'm edging on the former (just uuid), but would like to have a mechanism in place to allow users to disable/enable and possibly extend these types, so I can introduce a lot more (i.e. email, zipcode, iso-locale, currency, etc), without conflicting with types defined by the user.
Perhaps prefering definition over local type might be a solution to this problem, effectively allowing the user to overwrite builtin types should they so desire (or more significantly; should they have already done so before a new type is introduced in Swaggergen).

Implemented rest\query? uuid userid type format in v2.3.8.
The builtin should also be available wherever string is recognized as a type.
The UUID regex I enforces the M and N bits and requires lowercase, as per strict interpretation of the RFC-4122 specs (so 123e4567-e89b-12d3-a456-426655440000 is valid, 123e4567-e89b-62d3-a456-426655440000 is not).
Also implemented overwriting type definitions with models for backwards compatibility in the future.
Could you please test it and (hopefully) confirm.

I'm glad we share the same view and internal conflict on how to design a fix. 😄
I very much like your short-hand proposal of:
/**
 * @rest\query? string:uuid userid
 */

I disagree though that it forces users to understand more about internals. If someone chooses to specify:
/**
 * @rest\query? string:foobar userid
 */

it would simply resolve to
{
    "name": "userId",
    "in": "query",
    "type": "string",
+   "format": "foobar"
}

Library support for specific internal formats is an added benefit.
As for how to implement a fix. I really don't even know how SwaggerGen would load classes apart from its own. So I don't quite understand how there could be user-defined uuid definitions out there in the wild. But if you want to be the most compatible, perhaps not including the pattern with the format would be the way to go. (I acknowledge that it is complete contradiction to adding a useful string:uuid)

For whatever reason, I missed that you actually supplied a fix. So firstly, THANK YOU!
I am testing it right now and it doesn't look like it's supplying a format.
I am using this library in combination with another closed lib to actually code-gen input validation, and "format": "uuid" is actually a contract there.
Given datetime includes format with its output, would it be possible to add format to the new uuid def, as well?

I missed the part of the OpenAPI spec that says you can add custom formats. Will add it tomorrow.
It should actually make the code a bit better by allowing nicer error messages.

v2.3.9 has custom format for uuid type.
Also improved exception messages naming the correct format for string and descendants.
Please test and confirm.


Create Jenkinsfile

@Sumanth17-git Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

sd

Spam request. I get the feeling people are using the PetClnic as some toy project to learn spring and github!


Improved Regex

Rule named "random_vacation_off_xyz" would turn on the device again because of "on" in "vacatiON".

Thanks very much!


Fix bug minimizing a maximized result grid

Fixes #3993. ScrollableSplitView's addViews method expected views in reverse order (the last one in the array passed in would end up at the top), but the views were not being passed in reverse order when minimizing a maximized result set. I've changed addViews to expect them in a normal order and updated code where needed.

@MattIrv I'll merge now for tonight's build.


No HDR on some Films/Series in 4K

Netflix add-on version
1.20.1
Operative systems used
Android, Other (specify in description)
Kodi version used
Kodi 20 (Nexus)
Description of the bug
Shield 2019.
In the last Days i noticed that some Videos played fine in 4k but without HDR.
Examples: The Watcher and actual Enola Holmes 2
Steps to reproduce the behavior
No response
Debug log - mandatory

Possible fix
After looking at the latest changes in the code i get this one:
https://github.com/CastagnaIT/plugin.video.netflix/commit/6a0d09e7706fcc3aec82a4ff0eb2e1bca5f4a4af
I have changed the hdr part to the old values:
'hdr':
        _profile_strings(base=HDR,
                         tails=[(LEVELS_3 + LEVELS_4 + LEVELS_5, CENC),
                                (LEVELS_3 + LEVELS_4 + LEVELS_5, CENC_PRK),
                                (LEVELS_3 + LEVELS_4 + LEVELS_5, CENC_PRK_DO)]),

And now the 4K Videos have HDR again.
Additional context
No response
Screenshots
No response

please test with this:
'hdr':
        _profile_strings(base=HDR,
                         tails=[(LEVELS_3 + LEVELS_4 + LEVELS_5, CENC_PRK),
                                (LEVELS_3 + LEVELS_4 + LEVELS_5, CENC_PRK_DO)]),

the following tail do not exists on website

(LEVELS_3 + LEVELS_4 + LEVELS_5, CENC),

After testing, this restores 4K HDR display. The test movie was Enola Holmes 2.

please test with this:
'hdr':
        _profile_strings(base=HDR,
                         tails=[(LEVELS_3 + LEVELS_4 + LEVELS_5, CENC_PRK),
                                (LEVELS_3 + LEVELS_4 + LEVELS_5, CENC_PRK_DO)]),

the following tail do not exists on website

(LEVELS_3 + LEVELS_4 + LEVELS_5, CENC),

Yes this is working fine here.


Don't generate const variables as lazy getters

Not high priority, but something to consider.
I see code that looks like:
const int TAG_TYPE_BITS = 3;

Generating code that looks like:
dart.defineLazy(protobuf, {
  get TAG_TYPE_BITS() {
    return 3;
  },

Would probably be worth just generating direct properties for these kind of things.

Hmmm. We used to optimize more of these, I'm surprised we don't do that here. I think it gets tricky if we're dealing with user classes and ordering issues though, so that may be why we backed off. I did think JSON stuff was still optimized though.

I also think we could do better for lazy getters in general.


Use proper scikit-learn dependency

Depend on scikit-learn instead of sklean in docs/requirements.txt. sklearn seems to be some form of mirror for scikit-learn but its not the proper dependency.

Merged with master to fix CI.


I tried to receive a message and found that the sender's information is the same as the chat person's information. Is this the design?

i think that's normal, it's not always the case, for example in a group


Details
After this commit, CTRL-R command history search has failed to display some commands in zsh.
The new method to cut the history number from the each line can't capture the command containing an asterisk(*) mark followed by the number.
If you have command history like an example below, CTRL-R only displays ls, vi, man, git and ssh... .
$ fc -rl 1 output example
123* ls
122* cd
121* date
120 vi
119 man
118* git
117* which
116* emacs
115 ssh
...

I have little knowledge about perl, but I guess when it processes the 123* ls line, capturing failure makes 'undef' hash key. So the next commands(cd and date) including asterisks aren't be displayed because perl recognize them as the same commands.
While I don't know why git is displayed, my assumption is undefs that are not produced in the continuous block are treated differently by perl internals.

Thanks. Do you know when * appears? My fc output doesn't have any item with *.

If I understand correctly, when you execute some commands in other terminal sessions, asterisks are added to those commands in the original session.
For example,

Open two terminal sessions side by side
In the first terminal, execute ls, cd, date in order. At this point, fc -rl 1 shows history without *s.

3 date
2 cd
1 ls

In the second terminal, execute those commands in the same order ls, cd, date.
Go back to the first terminal, and see the output of fc -rl 1. *s are added.

3* date
2* cd
1* ls

I've searched for the zsh documentation mentioning this behavior, but can't find it so far.

Thanks, I can reproduce the problem by following your instruction after adding setopt share_history.

Merged, thanks!

Ah, I bumped into the same issue, thanks for the fix here.
According to builtin.c in zsh,
fprintf(f, "%5s%c ", buf,
    ent->node.flags & HIST_FOREIGN ? '*' : ' ');
}

it seems indeed that fc adds an asterisk for commands that came from another shell.

A couple years later, I found the match for \** very surprising, so I am PRing a comment for it in PR #3006.

According to builtin.c in zsh,

Stable code link: https://github.com/zsh-users/zsh/blob/b7f280ab597b07bbb22fb741589fe7754fc5cc0c/Src/builtin.c#L1822-L1828


Fix webdev error line numbers where possible

This fixes issues where line numbers were misreported or missing in web-dev levels when an error occurs.
Some errors unfortunately are unable to be parsed for line numbers because of the way that window.onerror (and global error event listeners) work, which do not include the stack trace that ends up in the console. For those errors, we return line:0, column:0 which points the user to the <script> line.
This fix revealed a behavior that we may want to change: When typing code, if an error occurs in the code you've typed, and you haven't clicked "run" recently, it will display This error was generated by old code — Try running your new code first every time you type a character. The fix for this is probably to make userCodeHasChangedSinceLastCast be determined differently. This bug may have been introduced by us changing the editor to re-run the code every time you type, rather than when you click "Run", though I'm not sure if we did that explicitly.
That "old code" error message's original intention is for when an error occurs from user interaction with their webpage, when they've changed their code since the last run.

Coverage remained the same at 61.959% when pulling 55aafb5e6683e12b0b8d42b0ac204864bc82cbdc on fix-webdev-line-numbers into 996d8f66812a83d76c20c45252dec02c35233ec3 on master.

The logic looks good as near as I can tell. Was this tested in a variety of browsers, including IE? Want to ensure that they either all stayed the same or got better in terms of position.

Coverage remained the same at 61.959% when pulling 48ba58f5ac2f36f0aa0d1fe5131824231cfa0fcc on fix-webdev-line-numbers into 179b22bc0fa445f40a62471a7e85267118e9dda4 on master.

Coverage remained the same at 61.959% when pulling e47d5452a372facb154bbcef975ecd7fdae2ac32 on fix-webdev-line-numbers into 179b22bc0fa445f40a62471a7e85267118e9dda4 on master.