ReDash - Reporting Metrics - Received Dashboard

Describe the bug in current situation
Seeing issues in our redash production environment's received dashboards, compared to existing IAO dashboards (that are still being manually updated).
For the larger dashboards/All received dashboards:
Pulling far too many requests - filter for start FY22/23 showing 3800+ requests, should only be 1545 per today's reports. (CFD shows 1754, only received 493 - as an example of one)
Data visualization - current FY showing as Q2 when it should be Q1 (Q1 ends June 30th)
Requests pulled should only be open requests. Persistent display of active requests should show any active FOI request regardless of FY start date.
Ministry Specific (but may be part of larger issue):

When filtered to requests last week (at the time, June 13th - June 17th), it displayed 6 requests received; however, all 6 were duplicate requests of the same

Impact of this bug
Reports will be unreliable and could skew perceptions. Loss of confidence in system if reports are not generating correctly.
Chance of Occurring - High
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Steps to Reproduce
Steps to reproduce the behavior:
Go to '...'
Click on '....'
Scroll down to '....'
See error
Actual/ observed behaviour/ results
See issues summarized above
Expected behaviour
Received outputs should match what is being produced manually - as both systems use the same DB as source of truth
Screenshots/ Visual Reference/ Source
Will provide specific days reports as comparisons for analysis.

Confirming that the received dashboard is now largely reflecting accurate counts - in fact, I think it may be more accurate than our existing dashboards. I just saw that ours is reporting requests that were submitted up until yesterday (confirmed in AXIS PROD) - and the crystal reports may be having a greater lag than expected .
A few tables will need some tweaks to be consistent with "Total Active by On-Time/Overdue" - specifically the "Total Active by ProcOrg", "Total Active by ApplicantType", "Total Active by Status" and "Total Active by CurrentActivity"
All of those tables are only pulling active requests that were received this fiscal, they should capture -all- active requests, similar to how Total Active by On-Time/Overdue functions.
cc: @nkan-aot @richard-aot

yes - appears so! There's some minor variations between some... but as my analysis the other day showed, it appears our nightly jobs may in fact be pulling more accurate data as I compared against what is in AXIS itself and found the numbers to match. Will close this ticket - nice work.


ListAdapter

Change RecyclerView.Adapter to ListAdapter

@NayakNavin yes you can

hey
short tip
maybe assign @NayakNavin  this issue
I'm searching for unassigned Hacktoberfest issues
and I found this one
would make searching easier
thx

@antercepter sure go ahead

@alfianyusufabdullah Before the start, can I ask why do you need to replace RecyclerView.Adapter with ListAdapter? All works fine and looks good for me :)

@antercepter sebelumnya saya sudah mencoba, saya  hanya ingin melihat bagaimana jika ini dibuat oleh developer lain

Fixed #2


fix: visibility of Blocks visualiser when error

Description
Editor retains the previous version of the document when an error occurs, Hence doesn't assume it to be not a version 3 document.
BEFORE https://github.com/user-attachments/assets/f6fadd7a-443c-407e-af61-df8699090614
AFTER https://github.com/user-attachments/assets/263d3ecd-41e2-45fb-986f-e2edf136f6f4
Related issue(s)
#1142

/ptal


Support for switching the light/dark themes of Reader mode (Readability)

Reader mode (ctrl+alt+R on most websites such as blogs) is great, and it would be even greater if this extension could tell it to switch between the light and dark theme!

Actually, from my understanding of this feature request that just got fixed in Firefox now, automaticDark might not even need to manage this after all: https://bugzilla.mozilla.org/show_bug.cgi?id=1594828#c7


Confusing use of human shaped icon

The human silhouette is used for both registering new user and accessing your own user info while logged in. Especially on mobile this becomes very confusing as there are no helping texts.
Suggestion: Adding a plus sign when the icon refers to adding/registering new user.
Current, the svg element of the html says:
<use xlink:href="#icon-user"></use>
And if changed to:
<use xlink:href="#icon-user-plus"></use>
The icon looks as suggested and this issue is fixed.

Made a pull request to implement this for the Create account button.
Adding users to events and games should also user this icon.

That is a good idea @zwrawr. I will merge that in once I return with dinner. :+1:

Okay, this fix and live.


Add another API for jokes

I wonder if, instead of developing our own list of jokes, why not look for repos on GitHub that might have aggregated such a list?
Perhaps contributing to, and then somehow sourcing from such repos would prove to be more productive.. Just a thought..
API Credit: https://github.com/KiaFathi/tambalAPI
Some other possible sources:
https://github.com/CallumBarclay/Jokes-API
https://github.com/ChrisMcKenzie/dadjokes

I agree that this is a good idea - maybe using a small web scraping script to pull from parts of the web with an abundance of jokes.
Ex. https://www.reddit.com/r/dadjokes
Then grab the title / body of the posts and push it to the other projects

@havanagrawal Great finds!
This API is much better than the current one, so how about we replace it (instead of keeping both) ?
And yes, we shouldn't be reinventing the wheel when we can devote that time to expand to support another type of query. :smile:

I feel we should keep both, as they both are different genres (one-liners vs Chuck Norris).. Eventually, we can take genre requests too for the joke api, and these will be handy then.. But by all means, if you want me to replace it, I'll replace it :smile:

I also want to keep both but if you query the chuck norris api multiple times, you'll find some offensive jokes that I want to avoid. We have users requesting for different genre jokes so that's our next priority. But for now, our main aim is to filter out jokes (which the tambal api already has).


Why does the result after autohic adjustment look worse than the result before adjustment, and how should this situation be adjusted

Why does the result after autohic adjustment look worse than the result before adjustment, and how should this situation be adjusted?
AutoHiC Report at Wed Apr 17 01_31_42 2024.pdf
How to specify chromosomal data in Autohic, for example 2n=66.

Judging from your results, your scaffold works very well, with no translocation and inversion errors. You think the adjustment effect is getting worse, just because of the color threshold of the contact heatmap, but in fact the effect is better. But the problem is, from the contact heatmap, you may have 31 chromosomes. If you have experimental data proving that there are 33 chromosomes, I suggest you use reference methods to manually divide the chromosomes and compare them with homologous species to check whether there are chromosome fusion events, etc.

The AutoHiC algorithm employs image detection techniques to assign chromosomes based on contact heatmaps. One may infer the chromosome number from an adjusted heatmap. However, it is possible that the number of chromosomes ultimately divided may be inconsistent with the actual situation due to the influence of the visual color threshold or other issues with the data.


💡 Lighthouse Optimization

Lighthouse Optimization
Cool template, was looking into using this for an upcoming project. Though you could argue these are not needed for a template I love to see those 💯s.
FYI here is before:

Turn Into Template
You can mark a repository as a template.

Thanks a lot for the PR! I was debating with myself if I would make this a template. I am not convinced that this could be a nice template since there is a lot more background configuration for this to properly work.

Redirect URLs
Supabase credentials
Deployment adapter

My idea of a template would be sort of a "Click here to deploy" and it works.
That's why I was thinking about making this an "example repo" or "basic demo" showcasing some Astro and Supabase features.


ML 1.9 : Hypothesis Testing (A)

Welcome to 'ML' Team, good to see you here
This issue will helps readers in acquiring all the knowledge that one needs to know about Hypothesis Testing.
To get assigned to this issue, add your Batch Numbers mentioned in the spreadsheet of "Machine Learning", the approach one would follow and choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
Domain : Machine Learning
Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.

"Issue Title" and "PR Title should be the same. Include issue number along with it.

Changes should be made inside the Machine Learning/Machine_Learning/Statistics_for_Machine_Learning Branch.

Follow Contributing Guidelines & Code of Conduct before start Contributing.

This issue is only for 'GWOC' contributors of 'Machine Learning' domain.

To be Mentioned while taking the issue :

Full name
Batch Number
GitHub Profile Link
Which type of Contribution you want to make :

[ ] Audio

All the best. Enjoy your open source journey ahead. 😎

Arjun Wankhede
ML batch 3
https://github.com/Arjun2905
Type of Contribution : Audio

is there is something for documentation

@Arjun2905 Great, You can work on it 👍

@m0hit-kumar Check out other issues or wait for it.

@Isha307 do you have any issue unassigned pls assigned me that

@m0hit-kumar Checkout this https://github.com/girlscript/winter-of-contributing/labels/Up-For-Grabs

@Isha307 they are for video and audio only and the rest are already assigned which lie under my domain

@Isha307 i already checked it out, the only left one is for audio and video  not for documentation in my domain.

@Isha307  Please go through my pull request https://github.com/girlscript/winter-of-contributing/pull/1905


Enable deserialization for newtype field values

PR in relevance to #1778 .
The original code used deserialize_any for newtypes.
Implemented a separate deserialize_newtype_struct.

I wasn't to run tests for the whole workspace due to errors like below, which I wasn't able to fix.
I don't think this will break other test, but I'm not sure.
  = note: Undefined symbols for architecture arm64:
            "_sqlite3_unlock_notify", referenced from:
                rusqlite::unlock_notify::wait_for_unlock_notify::h68227f6013bf55ed in rusqlite-d113afe8a2e6076a.08udfb9kdnese01layhcpep3w.rcgu.o
          ld: symbol(s) not found for architecture arm64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)


Consider self hosted runner for link checker job

Description
We're excluding more and more external links https://github.com/kumahq/kuma-website/pull/2118 because of flakyness and other reasons. I think this is because different websites / CDNs / DDOS protection systems just ban traffic from GH IP ranges. We could try running these on self-hosted runners to see if that stabilises it.
Why is it important? It allows us to make sure we link to correct parts of the docs of things we integrate with. If they change their website and we don't adjust we're giving our user a bad experience. If we don't to anything with it we might as well disable all external link checking 🤷 .

Triage: Let's have a scheduled job that runs on master and verify once a day. We can observe a status in project-report

I think this is because different websites / CDNs / DDOS protection systems just ban traffic from GH IP ranges.
You think or you've seen?


postgres:  integer out of range

I think I found a regression related to: #97
When using deltas & rails fixtures with postgresql I get the error: "ERROR: index 'catalog_edition_core': sql_range_query: ERROR:  integer out of range"
I tracked the problem down to my sphinx.conf:
sql_query = SELECT "catalog_editions"."id" * 4 + 0 AS "id".....
updating the sql_query to
sql_query = SELECT "catalog_editions"."id"::bigint * 4 + 0 AS "id".....
fixes the issue.  My temporary workaround is to monkey patch thinking sphinx:
ThinkingSphinx::ActiveRecord::SQLBuilder.class_eval do
  def document_id
    quoted_alias = quote_column source.primary_key
    "#{quoted_primary_key}::bigint * #{config.indices.count} + #{source.offset} AS #{quoted_alias}"
  end
end

which obviously breaks mysql.

I've seen such an error today when someone inserted 20014-12-25 in indexed date field :bomb:

@Envek you may want to set 64bit_timestamps to true for each environment in config/thinking_sphinx.yml - and/or have some validation on dates to avoid those massive values ;)


Use a different combination than Control + M to toggle

I paid for meteor toys and already have it in a number of projects, but I really like the idea of the constellation plugins and would like to evaluate this some more. It already has plugins with some features that I like that meteor toys doesn't have. Would it be possible do use a different combination than Control + M to avoid having both meteor toys and constellation show up or at least make it configureable?
Also, I noticed the github link on atmosphere at https://atmospherejs.com/constellation/console points to the wrong repo (https://github.com/babrahams/constellation/ instead of https://github.com/JackAdams/constellation)

Hi @landland,
Very good point about not conflicting with meteor toys.  There will be a release with a default ctrl + C option to toggle the interface coming very soon and ctrl + M will have no effect. Because Constellation is all about configurability, I'll look into making this configurable too.
Thanks for the heads up about the wrong repo link too!
Brent

Okay. That's all in place in the latest release.  Docs mention how to configure if ctrl + C isn't the key you want.

that was quick! thanks and keep up the great work.

so I recently upgraded last night and I noticed it changed back to Control + M. I see the docs say Control + C in one part and Control + M in another. Is this a bug?

Thanks for spotting that typo in the docs.  It should only be CTRL + C.  Check your .meteor/versions file and make sure that it says<EMAIL_ADDRESS> CTRL + M should only toggle Mongol/MeteorToys and should have no effect on Constellation.

CTRL + C collidates with the copy hotkey.
Maybe not the best default value.

Haha... that's windows machines, right?  Should have remembered that.
Any suggestions?  If I pick something at random, I'll probably just hit another hotkey.

Package['constellation:console'].API.setKeyCode(71);

will make it CTRL + G.
But then you've got Constellation-specific code in your app so that's not really an acceptable solution ...

Hehe, actually it's Linux :penguin:
Not sure about a good default key. ctrl + x/c/v are used by Linux/Windows.
Nearly all other characters besides 'm' are used by most browsers.
CTRL + g for example is used for 'find next' in chrome and firefox
Maybe CTRL + . or ,


Where is the BOSH release?

Is there a BOSH release for cf-tcp-router? Thanks!

You can find the BOSH release for the cf-tcp-router in the link below.
https://github.com/cloudfoundry-incubator/cf-routing-release

Thanks!
On Wed, Jul 22, 2015 at 6:57 AM, Leo Chu<EMAIL_ADDRESS>wrote:

You can find the BOSH release for the cf-tcp-router in the link below.
https://github.com/cloudfoundry-incubator/cf-routing-release
Reply to this email directly or view it on GitHub:
https://github.com/cloudfoundry-incubator/cf-tcp-router/issues/1#issuecomment-123730418

We'll add a link to the README


Electron apps code-signed on OSX 10.11.4 do not verify on <= 10.11.3

Electron version: 0.37.2, 0.34.3
Operating system: OSX 10.11.4

Repro Gist: https://gist.github.com/mkscrg/a6f85dba729be431748b (BYO signing cert)
Electron apps signed on OSX 10.11.4 fail codesign --verify on 10.11.3 and lower. We hit this in our production builds, then reproduced it with a minimal Electron app (see Gist) and self-signed cert.
codesign --verify on <= 10.11.3 returns errors similar to this:
.../Codesign Test.app/: invalid signature (code or signature have been modified)
In subcomponent: .../Codesign Test.app/Contents/Frameworks/Codesign Test Helper EH.app

Things we tried/learned along the way:

"deep code signing", where each internal framework / helper is signed before the top-level .app (as in the MAS Submission Guide): no difference from repro Gist
signing via<EMAIL_ADDRESS>no difference from repro Gist
signing on <= 10.11.3 still works, verifies correctly on 10.11.4
a minimal XCode project, built and signed on 10.11.4, verifies correctly on 10.11.3 and lower

Workaround: none, except to sign on a machine running <= 10.11.3.

@joshaber have you heard anything about signing problems on the latest el cap update?

I haven't, though it's not unheard of for Apple to change how code signing works without publicizing it.

Yeah... unfortunately they changed some things in 10.10 as well without really publicizing it.
Can you try analyzing the codesigned app with these commands? They give more detail than codesign -verify and helped us track down our last codesigning issue (We had a bad symlink in the app, which became a failure condition for codesigning at some point this winter...)
codesign --verbose=4 --deep --strict Nylas.app
(strict option is new in El Capitan)

$ spctl -a -v --raw Nylas.app
Nylas.app: rejected
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>assessment:authority</key>
	<dict>
		<key>assessment:authority:source</key>
		<string>obsolete resource envelope</string>
		<key>assessment:authority:weak</key>
		<true/>
	</dict>
	<key>assessment:cserror</key>
	<integer>-67003</integer>
	<key>assessment:remote</key>
	<true/>
	<key>assessment:verdict</key>
	<false/>
</dict>
</plist>

@bengotow thanks! I tried that with a real cert (spctl rejects self-signed certs AFAIK):

Signed with --strict on 10.11.4.
$ codesign --verbose=4 --deep --strict --sign '...' 'Codesign Test-darwin-x64/Codesign Test.app'
Codesign Test-darwin-x64/Codesign Test.app: signed app bundle with Mach-O thin (x86_64) [com.electron.codesign_test]

Checked via spctl on 10.11.4 (same machine):
$ spctl -v -a --raw Codesign\ Test-darwin-x64/Codesign\ Test.app
Codesign Test-darwin-x64/Codesign Test.app: accepted
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
    <key>assessment:authority</key>
    <dict>
            <key>assessment:authority:row</key>
            <integer>6</integer>
            <key>assessment:authority:source</key>
            <string>Developer ID</string>
    </dict>
    <key>assessment:remote</key>
    <true/>
    <key>assessment:verdict</key>
    <true/>
</dict>
</plist>

Zipped and moved to a machine running 10.11.3, checked via spctl there:
$ spctl -a -v --raw Codesign\ Test.app
Codesign Test.app: invalid signature (code or signature have been modified)

I ran into the same issue code signing an Electron 0.37.3 app on OS X 10.11.4 using electron-packager 5.2.1 and resolved it by updating to 6.0.0. I didn't investigate what changed in 6.0.0, but figured I'd share in case it's helpful to others.
Like others, I saw this error on OS X 10.11.3:
$ codesign -vvvv Basecamp\ 3.app
Basecamp 3.app: invalid signature (code or signature have been modified)
In subcomponent: /Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/Basecamp 3 Helper EH.app

Here's the same app on 10.11.3 signed using electron-packager 6.0.0:
$ codesign -vvvv Basecamp\ 3.app
--prepared:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/Basecamp 3 Helper EH.app
--validated:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/Basecamp 3 Helper EH.app
--prepared:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/Basecamp 3 Helper NP.app
--validated:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/Basecamp 3 Helper NP.app
--prepared:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/Basecamp 3 Helper.app
--validated:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/Basecamp 3 Helper.app
--prepared:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/Electron Framework.framework/Versions/Current/.
--validated:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/Electron Framework.framework/Versions/Current/.
--prepared:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/Mantle.framework/Versions/Current/.
--validated:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/Mantle.framework/Versions/Current/.
--prepared:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/Current/.
--validated:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/Current/.
--prepared:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/Squirrel.framework/Versions/Current/.
--validated:/Users/chef/Downloads/Basecamp 3.app/Contents/Frameworks/Squirrel.framework/Versions/Current/.
Basecamp 3.app: valid on disk
Basecamp 3.app: satisfies its Designated Requirement

@javan confirmed<EMAIL_ADDRESS>solved our problem.
FWIW, we're not using electron-packager to sign, just to package. We're still signing by running codesign explicitly. It's not obvious to me what change in electron-packager solved this issue.

I'm not sure if this is an Electron, OS X 10.11.4, or code signing issue, but it's particularly troubling. In my case, I released a signed app that appeared to work perfectly, and almost immediately people on earlier OS X versions reported autoUpdater and install errors. This caused OS X's Gatekeeper to kick in, preventing launching the app even after downloading a newer, correctly signed version. See http://www.mackungfu.org/dealing-with-damaged-and-can-t-be-opened-error-messages for a solution if you encounter this.
No disrespect to the Electron maintainers intended. I'll continue to investigate and report back if I discover the source of the problem.

It seems that CFBundleExecutable in Info.plist actually needs to match the name of the executable now. If you rename the helper executable from Electron Helper EH to MyApp Helper EH but didn't update CFBundleExecutable in the helper's Info.plist, then this issue happens. electron-packager updates CFBundleExecutable for all the helpers and renames the executables as well to the same thing.
Making them match worked for me. Can someone else try this and see if it works for them too?

@hongrich yep, that seems to be it. Confirmed I can do this on 10.11.4:

package with<EMAIL_ADDRESS>

fix CFBundleExecutable in the the helper apps:
/usr/libexec/PlistBuddy \
  -c "set :CFBundleExecutable \"$app_name Helper EH\"" \
  "$dist_dir/$app_name.app/Contents/Frameworks/$app_name Helper EH.app/Contents/Info.plist"
/usr/libexec/PlistBuddy \
  -c "set :CFBundleExecutable \"$app_name Helper NP\"" \
  "$dist_dir/$app_name.app/Contents/Frameworks/$app_name Helper NP.app/Contents/Info.plist"

codesign the top-level bundle with codesign --force.

Then take the signed app to 10.11.3 and pass codesign --verify.

Going to close this out since it seems to be an Info.plist behavior change between 10.11.3 and 10.11.4 that can't be addressed by a change to Electron but instead via an electron-packager upgrade to at least 6.0.0.
Thanks so much to everyone who helped out here :+1: :+1: :+1:

:heart:

If someone else encounters this in the future: another reason this can happen is if you have another executable in the MacOS folder that is not referenced by the Info.plist file.

Thanks for tracking this down @hongrich


[SDK] Fix: Account switching with connected smart wallets

Fixes #5537

PR-Codex overview
This PR focuses on improving wallet connection handling in the thirdweb project, specifically when switching signer accounts and simplifying connection logic for smart wallets.
Detailed summary

Updated biome.json to add "noUselessElse": "off".
Modified wallet connection logic in packages/thirdweb/src/wallets/manager/index.ts for better handling of active wallets.
Added tests for connection management in packages/thirdweb/src/wallets/manager/connection-manager.test.ts.
Removed environment variable logging across multiple API routes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Merge activity

Dec 2, 6:35 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


option_chain result is not a dataframe and does not convert to json

ticker = yf.Ticker(symbol)
data = ticker.option_chain(date=date)
print(type(data))

results:
<class 'yfinance.ticker.Options'>
and I can't convert the var data to a json string with to_json() method, cause it's not a pandas dataframe.
How can I serialize the yfinance option_chain table into a string so I could send it over the network?

It looks like Ticker#option_chain returns a named_tuple of two DataFrames.  You can access the two members calls and puts which are DataFrames.

For example, if you wanted to return BOTH calls and puts as one list, with a new column to differentiate the type of contract, you might do something like:
option_chain = yt.Ticker('GOOG').option_chain('2022-06-16')
puts = option_chain.puts
puts['type'] = 'PUT'
calls = option_chain.calls
calls['types'] = 'CALL'
puts.append(calls).to_json(orient='records')

will give you a nice list of objects.

I ditched yfinance and wrote my own yahoo finance scraper which is way more elegant in implementation and achieves more than the yfinance module. The code is proprietary unfortunately... :D

Then I guess we'll just have to take you on your word that it's more elegant. ;)

yfinance is 7 files of 56kb on disk and 1284 lines of code, my lib is two files of 16kb on disk and 449 lines of code AND links into a local uvicorn/fastapi server to serve data to consumer programs.


Joining cluster fails

Hi guys,
I'm having an issue running more than a single node control plane as nodes doesn't seem to be joining the cluster, here's the error I am seeing
2020-11-11 14:42:56,743 - util.py[DEBUG]: Running command ['/var/lib/cloud/instance/scripts/00_download.sh'] with allowed return codes [0] (shell=False, capture=False)
2020-11-11 14:44:34,107 - util.py[DEBUG]: Running command ['/var/lib/cloud/instance/scripts/01_rke2.sh'] with allowed return codes [0] (shell=False, capture=False)
2020-11-11 14:46:36,461 - util.py[WARNING]: Failed running /var/lib/cloud/instance/scripts/01_rke2.sh [1]
2020-11-11 14:46:36,461 - util.py[DEBUG]: Failed running /var/lib/cloud/instance/scripts/01_rke2.sh [1]
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/cloudinit/util.py", line 896, in runparts
    subp(prefix + [exe_path], capture=False)
  File "/usr/lib/python3.6/site-packages/cloudinit/util.py", line 2083, in subp
    cmd=args)
cloudinit.util.ProcessExecutionError: Unexpected error while running command.
Command: ['/var/lib/cloud/instance/scripts/01_rke2.sh']
Exit code: 1
Reason: -
Stdout: -
Stderr: -
2020-11-11 14:46:36,463 - cc_scripts_user.py[WARNING]: Failed to run module scripts-user (scripts in /var/lib/cloud/instance/scripts)
2020-11-11 14:46:36,464 - handlers.py[DEBUG]: finish: modules-final/config-scripts-user: FAIL: running config-scripts-user with frequency once-per-instance
2020-11-11 14:46:36,464 - util.py[WARNING]: Running module scripts-user (<module 'cloudinit.config.cc_scripts_user' from '/usr/lib/python3.6/site-packages/cloudinit/config/cc_scripts_user.py'>) failed
2020-11-11 14:46:36,464 - util.py[DEBUG]: Running module scripts-user (<module 'cloudinit.config.cc_scripts_user' from '/usr/lib/python3.6/site-packages/cloudinit/config/cc_scripts_user.py'>) failed
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/cloudinit/stages.py", line 852, in _run_modules
    freq=freq)
  File "/usr/lib/python3.6/site-packages/cloudinit/cloud.py", line 54, in run
    return self._runners.run(name, functor, args, freq, clear_on_fail)
  File "/usr/lib/python3.6/site-packages/cloudinit/helpers.py", line 187, in run
    results = functor(*args)
  File "/usr/lib/python3.6/site-packages/cloudinit/config/cc_scripts_user.py", line 45, in handle
    util.runparts(runparts_path)
  File "/usr/lib/python3.6/site-packages/cloudinit/util.py", line 903, in runparts
    % (len(failed), len(attempted)))
RuntimeError: Runparts: 1 failures in 2 attempted commands

and if I try to run the script manually afterwords, I do get the following
# /var/lib/cloud/instance/scripts/01_rke2.sh
[INFO]  Beginning user defined pre userdata
[INFO]  Beginning user defined pre userdata
[INFO]  Fetching rke2 join token...
REDACTED
[INFO]  Found token from s3 object
[INFO]  API server available, identifying as server joining existing cluster
[INFO]  Cluster is ready
[ERROR]  Failed to create kubeconfig

I am also looking into that right now so I will share more insights unless you guys have any ideas? Not sure if important, but I am not using spot instances.
Thanks!

It's really hard to troubleshoot this. Sometimes there's 2 out fo 3 master nodes that are working, while the 3rd one does not have a kube-apiserver started (rke2-server service running) hence shown as OutOfService for the LB. And sometimes just one node is good while 2 are reporting the errors from the initial comment.

Hi @kaosmonk , this is unfortunately a known issue with rke2 and not specific to this implementation with terraform.  You can see the full discussion, workarounds, and track the status here.

For me, I found that the /var/lib/cloud/instance/scripts/00_download.sh file that gets populated needs to be tweaked.  The scenario is that awscli basically already exists and it is failing on the install.
[root@ip-10-2-5-28 ~]# /var/lib/cloud/instance/scripts/00_download.sh
Loaded plugins: amazon-id, search-disabled-repos
Package unzip-6.0-21.el7.x86_64 already installed and latest version
Nothing to do
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100 33.5M  100 33.5M    0     0  47.0M      0 --:--:-- --:--:-- --:--:-- 47.0M
Found preexisting AWS CLI installation: /usr/local/aws-cli/v2/current. Please rerun install script with --update flag.
[root@ip-10-2-5-28 ~]# echo $?
1
I'll try and figure out how to modify the population of the /var/lib/cloud/instance/scripts/00_download.sh script but if anyone knows already please let me know.  :)

Issues with preexisting awscli installations were resolved via this commit:
https://github.com/rancherfederal/rke2-aws-tf/commit/7b729dbb41be09d700bb69e9d401d33858860f05


Implement Gradient Ascent

Currently the main tracker algorithm is quite slow, which necessitates the image being scaled down, which reduces accuracy. There is a method proposed by Dr. Timm (creator of the algorithm) in his thesis for using gradient ascent to speed up the algorithm from O(n^2) to O(n) where n is the number of pixels.
The basic idea is that the eye centre-ness field can be sampled at any pixel independently in O(n) time. Currently eyeLike samples all pixels and finds the one with maximum centre-ness. Instead of doing this it is possible to rearrange the formula to be able to compute the gradient (slope) of the centre-ness field at any point. This direction can then be used to "climb" the gradient towards the maximum in a small number of iterations.
The method for doing this is detailed in his thesis, I might be able to email it to anyone who is interested in working on this. The method in his thesis is stated in terms of general circle identification which would need some tweaking to make it work for eyes. It wouldn't require much code to do, but would require a good level of understanding.

Hi trishume,
I'm working on this project and I'm really interested on the thesis you are talking about.
I've speed-up the code my way using the eye cascade on the face region.
This strategy set the box center near the eyes one so I set the for loop search starting near the box center, you can think about 10px offset from it.
It is quite fast now, I think I have some limitations on others strategy I applied

If you have access to a university library you might be able to find it under "Machine Vision for Inspection and Novelty Detection" by Fabian Timm. Otherwise email me at<EMAIL_ADDRESS>and I may send it to you. It's somewhere in among all those pages, it shouldn't be too hard to find.
The basic idea is you take the partial derivative in the x and y direction of the "centreness" formula you can then use standard gradient ascent formulas to find the maximum.
The derivative in the thesis will need a little tweaking to account for the eye-specific changes to the general circle-finding algorithm. Specifically to deal with only counting black circles rather  than white circles by only counting one gradient direction.

I am going to try and implement this some point down the line:
Is the algorithm the one shown on page 27 here? http://www.zhb.uni-luebeck.de/epubs/ediss1030.pdf

@abhisuri97 yup, that's the one. Nice that his thesis is public online, I didn't know that was the case.
That algorithm isn't specialized for eye tracking like in the other paper so it doesn't include things like weighting by darkness (which you could possibly skip, I'm not sure it helps that much), and only counting dark circles on light backgrounds (see my blog post, this is super important to adapt it to do).
I recommend doing the partial derivatives yourself so that you understand the equation he gives and how you might adapt it. I did them once and figured out how to adapt it, but I don't remember, I just remember it wasn't that difficult to adapt or to do the derivatives, and I hadn't even taken high school calculus back when I did them, just looked up the rules for derivatives online, so it doesn't need anything advanced.

I think I have a good idea of how to go about it. One part I can't quite understand how to do is computing the step size via Armijo's rule. Would you happen to know a good programmatic way to do this?

@abhisuri97 I have no idea. I've never looked into it and haven't studied optimization enough to know what it is. Hope Google helps I guess ¯\_(ツ)_/¯

@trishume
Would you happen to have the contact info for Dr. Timm? I couldn't find it online. You can privately email it to me at<EMAIL_ADDRESS>if you wish to not make the contact information public. Thanks.

Did anybody manage to implement it in some way? It would be great to speed up the process.
Also, it would be nice to have some optimization for real-time processing, such as passing previous pupil coordinates and starting search from there (although not sure if there would be any benefits - we still have to search entire area in case of rapid changes).


Issues in SimulMask example

Thanks for the great work!
When I followed the instructions in the SimulMask example, I met the following error
finetune.py: error: unrecognized arguments: --weight-decay 0.1

Is weight-decay missing in trainer_wrapper.py?

BTW, are the training configurations shown in the SimualMask example exactly the same as those used in your paper?

Thanks for the great work!
When I followed the instructions in the SimulMask example, I met the following error
finetune.py: error: unrecognized arguments: --weight-decay 0.1

Is weight-decay missing in trainer_wrapper.py?

Hey @gpengzhi!
Yes, it is probably just missing. I'll fix it really quick and add a few more options for fine-tuning.

BTW, are the training configurations shown in the SimualMask example exactly the same as those used in your paper (LoRA and quantization are not discussed in your paper)?

Saw your other issue, @Meaffel should be able to assist with reproduction.

I'll look a bit further at what actually useful arguments we should still add interfaces for (some are obviously not useful or, worse, result in buggy behavior), but that's outside the scope of this and issue #14 covers the other comment, here.
Closing the issue.

Thanks!
BTW, Parameters such asnum_train_epochs' and 'save_strategy should also be included in self.training_arguments of LLMSimulSFTTrainerWrapper.


Just a question about install

Just would like to ask if when configuring Automator, the instructions have setup info for things like Sonarr, CouchPotato, SAB, NZBGet, etc.    I have Sonarr, CP, SAB and NZBGet installed on my computer. DO I setup Automator for both the media manager and the downloader, or is this a one or the other type thing?
And if it is one or the other, which is recommended to do the postprocess job?

You need both the manager and downloader setup

Correct


Return class weights from data generator

Hi, I have a multi-output model. I need to change the class_weights dynamically (during training). I created a custom data generator and now want to return the class_weights also. I have following doubts -

What should be the data type of class_weights?
What is the difference between sample_weights and class_weights

@QuickLearner171998  Moving this issue to closed status as there has been no recent activity, in case you still face the error please create a new issue.Thanks!


Localization for Nigeria should be en_NG

Nigerian is an English speaking country and its locale is internationally recognized as "en_NG".

This is a valid issue, but it breaks the compatibility. I dont know if the maintainer will merge it now or in a major release

Fixed by #1205


[ServiceBus] use core-paging primitive for RuleManager listRules()

RuleManager's listRules() async paging operation was implemented manually.  Using core-paging primitive instead greatly reduces the code.
Service Bus doesn't support getting the total number of rules, so we only know that results are exhausted when the service returns an empty array. However, currently core-paging api would force us to return a page of empty result and undefined nextPageLink to stop the enumeration:

current getPage() calls service api to get up to maxPageSize of elements. Suppose this is the last batch of results from service.
getPage() returns a page of { page: results, nextPageLink: pageLink + results.length } because we don't know yet whether there are more results we will try to get more.
next getPage() calls service api again, getting empty results back
With current core-paging api, we can now use { page: results, nextPageLink: undefined } to stop paging.  However, it is a page with an empty array, which is undesirable.

To address this, this PR also updates core-paging to allow returning undefined from PagedResult.getPage and we stop yielding pages after receiving an undefined page.
Packages impacted by this PR
@azure/core-paging
@azure/service-bus
Issues associated with this PR
#22108
Describe the problem that is addressed by this PR

API change check
API changes are not detected in this pull request.

but I wonder if the service could consider revealing the number of rules somehow.

That might help, although it is also a possible scenario that while enumerating elements, other clients are adding/deleting.


Data directory linter

How do we get that linter into the repo?

Originally posted by @zachleat in https://github.com/11ty/11ty-website/issues/1117#issuecomment-886813222

Here is the new and "improved" linter I wrote as a bored weekend project for the ./src/_data/ files.
Currently everything passes the linter, but I did have to tweak the schemas a bit to make everything work. Like, in the case of the sitesSchema, only a name is required [because one site doesn't have a description and another doesn't have a url].
But yeah, I can put up a proper PR sometime today and we can tweak the schemas/code as needed, if this is of any interest to you. If nothing else, it will fail PRs on some obvious issues if you add this to CI. Although the readability of the error logging leaves a bit to be desired.
// data-lint.js
const inspect = require("util").inspect;
const lib = require("./data-lint-lib");

let errors = [];

main();

async function main() {
	await Promise.all([
		dataLint("./src/_data/community/", "*.js", lib.communitySchema),
		dataLint("./src/_data/demos/", "*.js", lib.demosSchema),
		dataLint("./src/_data/plugins/", "*.json", lib.pluginsSchema),
		dataLint("./src/_data/sites/", "*.json", lib.sitesSchema),
		dataLint("./src/_data/starters/", "*.json", lib.startersSchema)
	]);

	if (errors.length) {
		console.error(inspect(errors, { depth: 4 }));
		process.exitCode = 1;
	}
}

/**
 * Glorified wrapper for `schemaLint` which aggregates error messages.
 * @param {*} dir Directory of files to lint.
 * @param {*} ext Expected file extension of files in specified directory.
 * @param {*} schema Ajv schema definition to validate files against.
 */
async function dataLint(dir = "", ext = "", schema = {}) {
	try {
		await lib.schemaLint(dir, ext, schema);
	} catch (err) {
		errors = errors.concat(err.errors);
	}
}

And the data-lint-lib.js file is:
// data-lint-lib.js
const path = require("path");

const Ajv = require("ajv");
const addFormats = require("ajv-formats");
const fastglob = require("fast-glob");

const ajv = new Ajv({ allErrors: true });
addFormats(ajv);

module.exports = { schemaLint };

async function schemaLint(dir = "", ext = "*.json", schema = {}) {
	const validate = ajv.compile(schema);

	const validFilesGlob = path.join(dir, ext);
	// Find ALL files in the specified directory that do _NOT_ match the expected extension.
	const invalidFiles = await fastglob([
		path.join(dir, "*"),
		`!${validFilesGlob}`
	]);
	const validFiles = await fastglob(validFilesGlob, {
		absolute: true,
		objectMode: true
	});

	const errors = [];

	for (const invalidFile of invalidFiles) {
		errors.push({
			file: invalidFile,
			errors: [
				{
					message: `Unexpected file type: "${path.extname(
						invalidFile
					)}". Expected "${ext}"`
				}
			]
		});
	}
	for (const file of validFiles) {
		const absPath = file.path;
		const relPath = path.join(dir, file.name);
		const contents = require(absPath);
		await validate(contents).catch(err => {
			const data = { file: relPath, errors: err.errors, contents };
			errors.push(data);
		});
	}

	if (errors.length) {
		const err = new Error(`Schema check failed for ${validFilesGlob}`);
		err.errors = errors;
		return Promise.reject(err);
	}
	return Promise.resolve();
}

/// SCHEMAS

const uriOrEmptyString = {
	type: "string",
	anyOf: [{ format: "uri" }, { maxLength: 0 }]
};

module.exports.communitySchema = {
	$async: true,
	type: "object",
	properties: {
		// Required properties.
		author: { type: "string" },
		key: {
			type: "string",
			enum: [
				"collections",
				"data-cascade",
				"data",
				"getting-started",
				"image",
				"javascript",
				"plugins",
				"tutorial-blog",
				"tutorial-intro",
				"tutorial-simplewebsite"
			]
		},
		title: { type: "string" },
		url: { type: "string", format: "uri" }
	},
	required: ["author", "key", "title", "url"],
	additionalProperties: false
};

module.exports.demosSchema = {
	$async: true,
	type: "object",
	properties: {
		// Required properties.
		// TODO: This is generating the following warning:
		//   strict mode: "items" is 1-tuple, but minItems or maxItems/additionalItems are not specified or different at path "#/properties/category"
		category: {
			type: "array",
			minItems: 1,
			items: [{ type: "string", enum: ["serverless"] }],
			uniqueItems: true
		},
		name: { type: "string" },
		url: { type: "string", format: "uri" },
		// Optional properties.
		description: { type: "string" },
		twitter: { type: "string", minLength: 1 },
		source_url: { type: "string", format: "uri", minLength: 1 },
		// TODO: This is generating the following warning:
		//   strict mode: "items" is 1-tuple, but minItems or maxItems/additionalItems are not specified or different at path "#/properties/authoredBy"
		authoredBy: { type: "array", minItems: 1, items: [{ type: "string" }] }
	},
	required: ["category", "name", "url"],
	additionalProperties: false
};

module.exports.pluginsSchema = {
	$async: true,
	type: "object",
	properties: {
		// Required properties.
		description: { type: "string" },
		npm: { type: "string" },
		// Optional properties.
		author: { type: "string" },
		deprecated: { type: "string" }
	},
	required: ["description", "npm"],
	additionalProperties: false
};

module.exports.sitesSchema = {
	$async: true,
	type: "object",
	properties: {
		// Required properties.

We can make it even better! Is the code already part of the project?
*looks for the line numbers to add comments
In schemaLint you can pull out the properties via destructuring assignment from lib to make it a bit more readable.
Also, if any of the promises fail, Promise.all() will be rejected. On purpose? I don't see a catch handler there.
I prefer forEach over for … of loops, but that's a matter of taste.
An async function always returns a Promise, so a simple return should suffice (instead of return Promise.resolve().
Shall we track the TODO comments as checklist in this issue?

Not yet, it was just some weekend hacking project I was toying with.
I didn't get time to turn this into a PR yesterday, but probably easiest to either just keep adding comments here until I can PR it and then we can add inline comments.
Or, feel free to copy-paste-modify the code and create a PR if you want. They're all good points. I'm indifferent on forEach vs for..of. I think the main difference is that a forEach can get trickier if you have nested promises to await, but I don't think that applies here.

This would be https://github.com/11ty/11ty-website/pull/1125 then.
I added you as Co-author already.

Closing in light of @zachleat's comment in https://github.com/11ty/11ty-website/pull/1125#issuecomment-1075277069


Updating civis version to 1.3.0

This is covered by #16 , which can move forward now that v1.3.0 of the client is out.

Perfect.  Closing this in lieu of #16


Ninja Output no longer stays on one line

Brief Issue Summary
Hi,
One of the reasons I like Ninja is that, if there are no problems, compilation messages are overwritten on the same line so your terminal/output window does not get spammed. This has stopped working for me in the VS Code output pane this week - I don't know whether it is CMake Tools 0.11, or the March update to VS Code. Ninja continues to work correctly in the Mac OS terminal.
Expected:
Successful build messages from Ninja are overwritten on a single-line.
Apparent Behavior:
All Ninja messages are output across multiple lines.
Platform and Versions
[[For issues, fill out the following. Otherwise delete this section.]]

Operating System: Mac
CMake Version: 3.10.2
VSCode Version: 1.22.2
CMake Tools Extension Version: 0.11
Compiler/Toolchain: Clang

@spinicist CMT parses the output from CMake and then prints that to the VSCode output panel. If you are talking about the VSCode integrated terminal, then that has nothing to do with CMT.

Like I previously mentioned, CMT reads the stdout stream from the CMake instance and then prints it out to the output panel. I don't see a quick/easy fix for this either.

Did something change with that in the latest version? I could have sworn it was working as expected last week when I was still on 0.10. My memory is not great these days though.

We did a major refactor between 0.10 and 0.11, which is why it took so long. I don't know how it worked in the previous versions though.

Could you paste/screenshot the contents of your build log that look wrong? I'm a bit confused.

Sure - sorry, didn't think of cut and pasting the exact output.
Output from hitting Cmd+B, i.e. with CMake Tools:
[build] Starting build
[proc] Executing command: /usr/local/bin/cmake --build /Users/Tobias/Code/QUIT/cmake_build --config Release --target all -- -j 3
[build] [1/3] Generating version_depend_dummy
[build] -- Found Git: /usr/bin/git (found version "2.13.6 (Apple Git-96)")
[build] -- Version: v2.0.0-9-ga8038bb-dirty
[build] [2/3] Building CXX object Source/Relaxometry/CMakeFiles/qidespot1.dir/qidespot1.cpp.o
[build] [3/3] Linking CXX executable Source/Relaxometry/qidespot1
[build] Build finished with exit code 0

The final result from invoking /usr/local/bin/cmake --build /Users/Tobias/Code/QUIT/cmake_build --config Release --target all -- -j 3 in the integrated Terminal:
[1/3] Generating version_depend_dummy
-- Found Git: /usr/bin/git (found version "2.13.6 (Apple Git-96)")
-- Version: v2.0.0-9-ga8038bb-dirty
[3/3] Linking CXX executable Source/Relaxometry/qidespot1

Note that in this version you don't see the [2/3] Building CXX object Source/Relaxometry/CMakeFiles/qidespot1.dir/qidespot1.cpp.o line - it was printed, then overwritten by [3/3] Linking CXX executable Source/Relaxometry/qidespot1. For this trivial example it's not such a big problem, but my full build currently has 121 steps!

Ahh... I see. This isn't a regression from a prior CMake Tools version. The reason this happens is that Ninja doesn't clear the output line and re-write it unless it detects stdout to be a TTY.
I've been thinking about having builds run in the integrated terminal instead of the output channel, but haven't gotten around to implementing it or thinking about the design.

The output channel API from VSCode isn't that good. It needs to get some love, so I'm not sure I'd be able to clear individual lines, but I can look into it.

I'm tidying up my open issues and have learned to live with this one.


Automatically removing const for const_with_non_cost

This tracker is for issues related to:

Dart analyzer and linter

I apologize beforehand if this is the incorrect place to request this feature.
Dart linter has the ability to automatically remove unnecessary const keywords with unnecessary_const rule, and add them when suggested using prefer_const_constructors if we run dart fix --apply or while saving the file if the editor config is adjusted accordingly.
How about automatically removing the const keyword, when we decide to put a variable inside a widget tree that was completely constant before? Specifically, when we encounter const_with_non_const error. I'm aware that this is not a warning but an error unlike the linter rules I've mentioned above, I'm just wondering if it's possible to make such a fix using the analyzer.

dart info
#### General info

- Dart 3.1.1 (stable) (Tue Sep 5 12:20:14 2023 +0000) on "macos_arm64"
- on macos / Version 13.5.2 (Build 22G91)
- locale is en-TR

#### Project info

- sdk constraint: '>=3.0.3 <4.0.0'
- dependencies: balanced_text, bloc, cached_network_image, conditional_wrap, copy_with_extension, easy_rich_text, email_validator, equatable, expandable_page_view, firebase_core, firebase_crashlytics, flutter, flutter_bloc, flutter_hooks, flutter_keyboard_visibility, flutter_launcher_icons, flutter_localizations, flutter_spinkit, font_awesome_flutter, get_storage, http, intersperse, intl, just_the_tooltip, negative_padding, package_info_plus, pinput, qr_code_scanner, retry, shared_preferences, sliver_tools, sorted, spaced_flex, table_calendar, table_sticky_headers, top_snackbar_flutter, url_launcher, visibility_detector
- dev_dependencies: build_runner, copy_with_extension_gen, flutter_lints, flutter_test

#### Process info

| Memory |  CPU | Elapsed time | Command line                                                                    |
| -----: | ---: | -----------: | ------------------------------------------------------------------------------- |
|  35 MB | 0.0% |        12:13 | dart devtools --machine --try-ports 10 --allow-embedding                        |
|   8 MB | 0.0% |     08:38:29 | dart devtools --machine --try-ports 10 --allow-embedding                        |
|  52 MB | 0.0% |        12:13 | dart language-server --protocol=lsp --client-id=VS-Code --client-version=3.72.2 |
|  17 MB | 0.0% |     08:38:29 | dart language-server --protocol=lsp --client-id=VS-Code --client-version=3.72.2 |
|  65 MB | 0.1% |        12:13 | flutter_tools.snapshot daemon                                                   |
|  29 MB | 0.4% |     08:38:29 | flutter_tools.snapshot daemon                                                   |

</details

Yes, we have fixes for errors just like we have fixes for warnings and lints, and we could definitely add one here.
I tried a simple test case:
class C {
  C();
}

void f() {
  const [C()]; // errors here
}

Is that the kind of situation you're running into?
I'm seeing two errors: const_with_non_const and non_constant_list_element. If you're seeing both errors in your case, then I think it would make more sense to attach the fix to non_constant_list_element, because then it could be used in more case. If you're only seeing the one, could you provide a short sample of the kind of code you're running into?

After experimenting more thorougly, I've noticed that this feature could be applied to multiple non-const related scenarios. I've edited the original comment to include some examples.


Can't change viewpager title/Tab layout title

i can't change font style in viewpager strip title and tab layout title

Pretty sure a dup #325 #126


Fixed the irregularities in OrbitPlotter2D

Fixes #345
Now the plot looks good!
See these two plots:

Also, just ignore the branch name ! It was supposed to fix something else :sweat_smile:

Oh sorry that I missed that!

@Juanlu001  Some issue with Travis


Add template support

This is a work in progress. Do not merge.
This has become a little more complicated than I first envisioned. Right now, I'm still working through the init part of this. The plan is as follows:

react-scripts and create-react-app-template-* are installed as dependencies. Either or both of those can be defined via CLI.

Default is current default template.
Although the supported scripts version (range) is included in the template's peerDependencies, this is not used during install.

Upon react-scripts init, the template is copied from template package, and peerDependencies are installed from that package (excluding the scripts-version). That package is then removed, as it no longer has any value.

When using non-standard scripts, or a scripts version that is below the peerDependencies of the template, appropriate warnings will be shown - but the user can still continue. This, importantly, allows custom scripts versions to work with the template.
Optionally, the scripts version range could be in engines... but that doesn't feel clean.

The typescript flag is deprecated under this process.

OK, so I need to work on tests for this - and make sure it all works correctly - but the idea is in place.
The biggest issue I see with this implementation is that a) the template may require a different scripts version than the one the user set, and b) as the template is handled by react-scripts, we can only warn a  user when scripts versions don't match - when perhaps we should just install the scripts package requested by the template.

Would be awesome to have the ability to add custom scripts to the package.json. Say, my template has internationalisation, and I want to add extraction script to the project.

This can be tested with:
node ./create-react-app/packages/create-react-app test-project --template file:./create-react-app/packages/create-react-app-template/

Ok

After cloning your branch, and running your exact command, I get this error:
error An unexpected error occurred: "https://registry.yarnpkg.com/create-react-app-template-file;./create-react-app/packages/create-react-app-template/: Reques
t \"https://registry.yarnpkg.com/create-react-app-template-file;./create-react-app/packages/create-react-app-template/\" returned a 405".
info If you think this is a bug, please open a bug report with the information provided in "C:\\Dev\\test-project\\yarn-error.log".

Aborting installation.
  yarnpkg add --exact react react-dom create-react-app-template-file;.\create-react-app\packages\create-react-app-template\ file;.\create-react-app\packages\re
act-scripts\ --cwd C:\Dev\test-project has failed.

Yarn v1.12.3
Node v11.6.0
OS win32 x64

I'm working on Ubuntu (WSL actually), but it may be an issue we need to look into.
That being said, the file:.. resolution` if for testing this PR and is actually passing through to npm/Yarn.

Any further work on this?

Hi @Ugzuzg, this is a 3.2 goal now - I'll be restarting work on this next week.
We had some more urgent matters and wanted to think about this a little more.
Perhaps you can share a little more about what you'd like to see from templates?

Custom scripts, as mentioned above.
Also would be great to install additional dependencies. This PR achieves custom dependencies installing peerDependencies of a template, I believe? So this case is covered.
The ability to distinguish deps between dependencies and devDependencies isn't necessary, but is welcomed.
Thank you!


Check if two BSTs are identical using Python [GSSOC'21]

💥 Proposal
A program that will help us in determining whether the given two BSTs are identical or not.
Have you read the Contributing Guidelines on Pull Requests?
Yes

\assign

/assign


Failed to configure webpack entry

// craco.config.js
const path = require('path');
const { env: { NODE_ENV } } = process;

module.exports = {
  webpack: {
    configure: {
      entry: path.resolve(__dirname, './src/main.js'),
      resolve: {
        alias: {
          '@': path.resolve(__dirname, './src'),
        },
      },
      devtool: NODE_ENV === 'development' ? 'eval-source-map' : 'hidden-source-map',
    },
  },
}

// terminal
// -> yarn start
// <- $ craco start
// <- Could not find a required file.
// <-  Name: index.js
// <-  Searched in: E:\projects\react-doc\src
// <- error Command failed with exit code 1.
// <- info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Hi @chentianxin
It doesn't seem to be an error related to CRACO.
CRACO let you customize CRA config but it is your responsibility to provide valid config.
Patrick

@patricklafrance I am running into a similar issue.  Most of my aliases work.  Some of them don't.  I then try renaming them and they still fail.  I rewrite the definition so it's perfect and it fails still

Same problem. The project doesn't use the src name and I can't reconfigure.

Hey guys,
CRA seems to resolve the entry path, maybe you need to do something similar?
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/config/webpack.config.js#L185
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/config/paths.js#L88
We don't update CRA entry path at GSoft, so this is not something we tried.
If you think it should be handled by CRACO and you know how, a PR is welcome.
Patrick

Sorry I wasn't clear enough. Yes, CRACO works if the project has src like most projects do.
My problem is the project I inherited does not use src for reasons I have not control over. If I could I'd simply rename it.
Anyway, so it looks like in CRA's code they hard-coded it to look for src/index and there's no easy way to override.

Oh sorry I understand now.
Yes sadly in CRA they hardcoded a bunch of paths.


[CP-1741] Bash script to speed up local development

Disclaimer: I don't have much experience writing bash scripts; please have mercy 😨 . This script has just helped me personally so I thought it would help others as well.
Background:
The developers.strava.com documentation development cycle is currently pretty slow. It would be nice if there was a script to automate things
Solution:
Write a script to compile models and documentation, and deploy the website locally.\
Result:
Tighter feedback and faster development.
Completes CP-1741

friendly ping @jeffremer @jsilland

@jsilland ping

@jsilland 🔔

friendly ping.


Add Torch layers support

This PR provides a TorchLayer class for converting a PennyLane QNode to a Torch layer, which can then be used with standard torch.nn features such as the Module/Sequential models for constructing neural networks.
Note that a KerasLayer has already been introduced in https://github.com/XanaduAI/pennylane/pull/529.
The tests take 7.45s to run locally - is this too much?
Closes https://github.com/XanaduAI/pennylane/issues/166.

@josh146 I tagged you, was wondering if you'd have any idea why the test are failing :sweat_smile:

@trbromley: looks like the only test that is failing is TestCircuitDrawerIntegration, and only on the Python 3.7 build. This sounds to me like a dependency issue; is that specific build using an older/newer version of numpy compared to the others?

@trbromley: looks like the only test that is failing is TestCircuitDrawerIntegration, and only on the Python 3.7 build. This sounds to me like a dependency issue; is that specific build using an older/newer version of numpy compared to the others?

I changed the build to use Python 3.8 and it works. Not sure what the problem was :question:

@mariaschuld this is out of scope for this PR, but I agree re: interfaces page. I think we should do the following:

Add a short subsection on the Torch interface page https://pennylane.readthedocs.io/en/stable/introduction/interfaces/torch.html discussing torch.nn.

Add cards on the top-level Interface quickstart linking directly to the qml.qnn.TorchLayer and qml.qnn.KerasLayer docstrings. The docstrings have very nice usage details, and probably no point duplicating it.

@mariaschuld, I want to follow up to see if you still get those docs build errors? I couldn't replicate them when I tried to build locally so I'm wondering if it was either fixed or a system dependent problem?
Note that you requested changes so would be good to resolve. Thanks!


Dead symbolic link in dist-dev

In dist-dev there is an config.js linking to nothing.
Sorry for posting such a minor issue.
Imre
Addition: Am i right: in dist-dev the symbolic links to osjs.css and osjs.js are missing ?

You're right. Missed that one :)

Addition: Am i right: in dist-dev the symbolic links to osjs.css and osjs.js are missing ?
These are missing because you have not run grunt core


Initial WIP refactoring logic out of main package

(WIP -- not ready to merge. But I will try to keep the pushes here functioning so you can use it.)
This change moves some logic out of the main package and into a new warp package so that other clients can use this as a library.
Specifically, the login code that gets credentials and the code that starts a server has been moved over (mostly). Most of the additions are related to a rather sizable struct type that shuttles configuration settings into the StartServer() function.
Some TODOs:

[ ] Improve logging; it'd be nice if the library didn't require logrus (for example, Caddy doesn't use logrus and has logs of its own it could pass in) -- can we make an interface and pass in some "general" logger instead?

[ ] Test login more - I don't think it has anything to do with the this PR, but: when logging in to obtain a credential (the "login" subcommand), it opens a browser tab, into which I then log in (with 2FA), but then it takes me to my account dashboard instead of to Warp zones ("Authorize Cloudflare Warp"). However, running the command again, after I'm already logged-in in my browser, brings up the correct page immediately. It'd be nice if the login redirected to the correct page, but I'm not sure what change to make here for that to happen.

[x] Test startups/shutdowns more. I'm not sure if this related to my changes, but after a few trial runs I couldn't get the tunnel to register anymore -- no errors are produced, but accessing my warp hostname in a browser shows "503 Service Unavailable The origin has been unregistered from Cloudflare Warp" -- even after switching back to the master branch and compiling with no changes, I couldn't get that error to go away, despite no errors on the client-side. (EDIT: Okay, I guess sometimes it just takes a few minutes for it to start working. Maybe a propagation delay? Might be nice if this worked more real-time but I get that it's beta.)

[x] Fix the issue reported in #2. Right now this PR just comments out the offending lines as a workaround.

With this change, I was able to get a Caddy integration working.
Closes #1

There should never be a 503.  If so thats a bug.

For anyone following along, the Caddy plugin is now up at: https://github.com/caddyserver/cloudflare-warp-plugin

@mholt - thanks for contributing!

RE: a Logger interface - yes, definitely prefer this. Directly logging in libraries isn't a good experience, so accepting a minimal interface - e.g.

type Logger interface {
	Log(keyvals ...interface{}) error
}

RE: 503's - as Dane said, this shouldn't happen. We've put some mechanisms in place to prevent this, but you are correct in that it's a propagation delay (Tunnel backend -> provisions other services elsewhere -> needs those to services to push their config to the edge quickly).

@dknecht Resolved merge conflicts. Finally got my computer back from the shop so I'm mostly back in business (after I get over this jet lag)!
Can we possibly get this reviewed/merged sooner rather than later? Resolving merge conflicts when the warp client is updated is a bit tedious and risky for me to do alone.
As for the logging TODO, I don't really think it has to be resolved in this PR; seems like a separate thing.


[github-actions] test_firewall.py consistently failing

CI checks on all PRs are failing on this test.
======================================================================
ERROR: test (__main__.Firewall)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/ot-br-posix/ot-br-posix/third_party/openthread/repo/tests/scripts/thread-cert/thread_cert.py", line 302, in tearDown
    self._verify_packets(test_info_path)
  File "/home/runner/work/ot-br-posix/ot-br-posix/third_party/openthread/repo/tests/scripts/thread-cert/thread_cert.py", line 331, in _verify_packets
    self.verify(pv)
  File "./tests/scripts/thread-cert/border_router/test_firewall.py", line 239, in verify
    _pkt = pkts.filter_eth_src(vars['Host_ETH']).filter_ipv6_dst(
  File "/home/runner/work/ot-br-posix/ot-br-posix/third_party/openthread/repo/tests/scripts/thread-cert/pktverify/packet_filter.py", line 234, in must_next
    raise errors.PacketNotFound(self.index, self._stop_index)
pktverify.errors.PacketNotFound: ((561, 561), (770, 770))

----------------------------------------------------------------------

https://github.com/openthread/ot-br-posix/runs/5837544063?check_suite_focus=true

Do we have firewall related change recently ? @superwhd

We don't have recent firewall changes.
The test failed when verifying that HOST sends a ping packet to BR while the destination is a mesh local address or a link local address. That requires adding a route before the ping. I'm checking if the failure was due to insufficient delay.

Another observation is that this test case only fails when TREL is disabled. When TREL is enabled, the test is passed. However, I cannot reproduce the test failure locally when TREL is disabled.

I'll disable this step as for now and look for a long term solution later.


Misleading saveObj behaviour

When calling the saveObj method, the argument of the method is the filename that we want to save the object as (as most other save methods in any program). However, the method overrides this, takes the prefix, and renames the filename to (prefix).qmrlab.mat, which is an unexpected behaviour on the users side.
https://github.com/neuropoly/qMRLab/blob/cafdf0185361b7331e64400fb707df76bb715015/Common/AbstractModel.m#L22-L38
Not sure why it was necessary to add the second suffix (?) .qmrlab.?
I found this bug (feature?) while running my MATLAB test suite (https://github.com/neuropoly/qMRLab/blob/cafdf0185361b7331e64400fb707df76bb715015/Test/runTestSuite.m -> https://github.com/neuropoly/qMRLab/blob/cafdf0185361b7331e64400fb707df76bb715015/Test/Models/AbstractModel_Test.m), which tries to save the AbstractModel to a the file tmp.mat, and it errors because when it tries to load the expected file (tmp.mat), it is not there.

@mathieuboudreau .qmrlab. suffix was intended to serve as an identifier that distinguishes the record of a fit session by relating it to its model, while keeping it isolated from the other mat files in a directory, with Octave compatibility in mind. Object loading was more problematic there.
As for tmp.mat issue I am not quite sure what that script does. I will look into that, we can discuss more today's meeting.

I propose to raise an error if the user includes an extension different than .qmrlab.mat. And add the extension if missing.
.qmrlab.matis a way to identify which file can be loaded with qMRLoad

There is confusions with what .qmrlab. is intended to contain/enforce.

It is enforced for qMRLab models when saving, which I can understand
It is also enforced when saving fitting options, as can be seen in my issue #217
qMRLab models properties contain both fitting options + protocol. So, when saving a model, you save both the fitting options and the protocol. On the GUI, when you click save, you save the entire model.
It is enforced as an identifier that distinguishes the record of a fit session by relating it to its model, as mentionned by @agahkarakuzu
After the fitting is complete, the idea was to save the entire model again, so that other group can reproduce the study easily. Currently the model is hidden inside the Fitresults.mat file, I agree we should separate those 2 files.

So if I as a user has subject01.qmrlab.mat.... is this a model, fitting output, or the fitting options used for that session? As you can see, this added text does not necessarily guarantee or translate into added useful information (at least, not to me it doesn't). If the user isn't careful and depends on this "feature" too much as a sole identifier, they may overwrite a saved model with saved fitting output.
it should always be the entire model

What I would propose is this:

When saving qMRLab models (which are classes converted to structs), enforce a .qmr file extension.

(Mat)Lab's file extensions are *.mat, so it only makes logical sense that (qMR)Lab's proprietary file extension would be .qmr
ok for .qmr (.mat was a way to help dev to know the format, but I understand your point).
I guess we should also change the saving format to .json (more universal)

* Since they contain a qMRLab class, we want to enforce this with a non-mat file extension, as messing around with it at a *.mat file outside of the qMRLab environment can break it from loading.

When saving fitted data:

simply use *.mat, because users are free to reuse these outputs in any other software pipelines, the fitted data is not only meant to be used in qMRLab but in any MATLAB environment session.
I propose to save images as .nii.gz and the results model as .qmr

It should be up to the user to save it and organize it accordingly.

If we do use automated filename generations for pipelines, then using a (prefix)_qmr.mat pattern.

When saving fitting options:

simply use *.mat as an option, because users are free to reuse these outputs in any other software pipelines.

It should be up to the user to save it and organize it accordingly.

this also doesn't need a _qmr/.qmrlab enforcement, because I feel like these fitting options may be shareable in the future in other formats. E.g., VFA fitting options saved in JSON format in qMRLab should be compatible with running it in QUIT
Here we should save save the entire model (all properties) as a .qmr file. It will be much cleaner in the code (we just use the method qmrLoadObj)... As I proposed above, the .qmr file should be a json file, which could be turn into a QUIT compatible file quite easily if the user wants.

* We also expect that the user can load the fitting options in Matlab and modify them manually there in that environment (I've done this in my project [qmt-optimization](https://github.com/mathieuboudreau/qmt-optimization))

Models (that contain fitting options) can be modified after loading. It should not be a problem

qMRLab models properties contain both fitting options + protocol. So, when saving a model, you save both the fitting options and the protocol. On the GUI, when you click save, you save the entire model.

I see, I just noticed that you are correct, when saving you save the entire class object. I thought that "useless" non-fitting parameters like buttons weren't being saved with the fitting options, but I just checked and they are. I personally think they shouldn't, but since there are so few right now, I don't currently see it as an issue to remove them and give separation. Thanks for clarifying!

After the fitting is complete, the idea was to save the entire model again, so that this file can be shared easily with other group (in order to help reproducibility). Currently the model is hidden inside the Fitresults.mat file, I agree we should separate those 2 files.

Ok! I do see your point as to why have them contained together, but would also like that option only save the images. Hmm, not sure how to support both options without cluttering the GUI with another button 😅.

I guess we should also change the saving format to .json (more universal)
Here we should save save the entire model (all properties) as a .qmr file. It will be much cleaner in the code (we just use the method qmrLoadObj)... As I proposed above, the .qmr file should be a json file, which could be turn into a QUIT compatible file quite easily if the user wants.

It's really easy provide the option to save as both formats (*.qmr ("mat") or JSON), and I think we should. As it is today, the *.qmr model file is a class converted to a struct, and structs are easily converted to JSON format using JSONlab which is already on the repo (JSON was basically designed to contain structs). We could default it to *.qmr ("mat") so that advanced users (see last point below) can load them in Matlab to do modifications, but just give a drop-down option for *.json so that it may be used in other projects (e.g. QUIT)

I propose to save results as .nii.gz (compatible with other softwares) and the model as .qmr

Since we also support loading data as *.mat file, I feel like we should allow saving fitting results as *.mat files as well. There is a wide range of users who don't use .nii.gz (e.g. me during my entire PhD – I used MINC). For those users, it's great to allow at least the option to 1- load the data from whatever format they want into mat, and then 2- save the data in .mat, so they can convert it into their format themselves. This implicitly makes qMRLab support any file format without the messiness of implementing each of them, by letting the user loads it/save it into .mat themselves. But I'm fine (actually, really want) with giving an option to save the fitted data as .nii.gz, which we currently don't do.

When saving fitting options:
simply use *.mat as an option, because users are free to reuse these outputs in any other software pipelines.
It should be up to the user to save it and organize it accordingly.
this also doesn't need a _qmr/.qmrlab enforcement, because I feel like these fitting options may be shareable in the future in other formats. E.g., VFA fitting options saved in JSON format in qMRLab should be compatible with running it in QUIT

Here we should save save the entire model (all properties) as a .qmr file. It will be much cleaner in the code (we just use the method qmrLoadObj)...

Ok, I agree now.

It will be much cleaner in the code (we just use the method qmrLoadObj)...

Ok, I agree now.

Models (that contain fitting options) can be modified after loading. It should not be a problem

My point was that saved models are class objects converted to structs which needs to have the exact same parameter names. We (devs on the project) know this and would know how to do this correctly, but there is a large class of users users that won't and could "break" their saved model files if they accidentally rename a parameter or don't properly change it. I think having the *.qmr "wall" (which might not be auto-loaded by Matlab when double clicked) might protect that class of unexperienced users from themselves. For other more advanced users - we could add a File Format section in the documentation that explains what is contained in this file (e.g. it's just a .mat file, but contains all class properties, so change at your own risk).

Agreed. BTW, we should remove all props buttons from the saved object...

We could default it to *.qmr ("mat") so that advanced users (see last point below) can load them in Matlab to do modifications

I'm not a big fan of having 2 formats (mat and json) for *.qmr. If dev have methods to load json files in Matlab (e.g. using JSONlab) it should ok no? I don't see your point I guess

Sorry, I didn't mean that the data within the *.qmr is formatted in two different ways. I meant that we could save the fitting options in two different formats (e.g. like you can save a word file as a *.docx or a *.pdf, not that the *.docx file is formatted in two different ways (Microsoft and PDF)).

close this issue?

Merged #218.


create-reset action should not return the token value. Update readme about this breaking changett

@rjrodger @mihaidma @mcdonnelldean @geek are you agree with this issue?

Can you point to the code that implements the current behavior... I need more context


change Comment.ToString

Please, change Comment.ToString() to something like below. It's needed to allow using multiline precomments.
public override string ToString()
{
    char symbol = Symbol;
    return string.Join(
        System.Environment.NewLine,
        System.Array.ConvertAll(
            (Value ?? string.Empty).Split(new string[] { "\r\n", "\n" }, System.StringSplitOptions.None),
            s => string.Format("{0} {1}", symbol, s)
        )
    );
}

Could you give an example please?

I'd like to create following ini:
[Service]
# List of ports to listen
# Default = {1055,27000}
Ports = {1055,27000}

Now I have to do
Configuration cfg = new Configuration();
cfg["Service"]["Ports"].IntValueArray = new int[] { 1055, 27000 };
cfg["Service"]["Ports"].PreComments.Add(new Comment("List of ports to listen"));
cfg["Service"]["Ports"].PreComments.Add(new Comment("Default = {1055,27000}"));

And I'd like to do
Configuration cfg = new Configuration();
cfg["Service"]["Ports"].IntValueArray = new int[] { 1055, 27000 };
cfg["Service"]["Ports"].PreComments.Add(new Comment("List of ports to listen\nDefault = {1055,27000}"));

I see. A better solution would be to not keep multiple pre-comments around, but that many comment lines will be combined into a single Comment (when loading a config). I'll think of a good implementation.

I've applied this change for now, but expect it to change with SharpConfig 2.2. Thanks.


Update MD file on new branch 2017-18-10_12-11-22

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Export Components lib

Components used by the app must be exported through an index.ts file that will be created inside the components directory.

Minimize exports, only export what is required

Merge on #31


Add Disk Encryption for OS Disk

Hi @hyonholee, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (hylee). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@hyonholee Please update the package and assembly version.


Minimum filesize for use of progressive

I'm trying to get a 100 PageSpeed score, just because :)
Google does not like using progressive on jpg's smaller than ~10KB (read)
So I'm being told to compress my images. If I take off progressive my score goes up, but I know that my file sizes are bigger for large images and that the UX is worse.
So ideally I would just want to set progressive_min_size: 10 and only have images larger than that be optimized with progressive enabled.
Tried to find a way of doing this my self, but couldn't really find an easy solution.
Thanks for all the hard work on imagemin :)

Why not make a first pass through your file globs and filter them into those < and > the 10Kb limit, then pass those two separate file lists into imagemin with different option sets?  Only requires using simple general tools rather than more customizations to a very specific tool.

What @corps said.

@corps Thanks for your detailed answer.


Add gen gse basic

What does this Pull Request accomplish?

Basic Generation Tutorial (gse-gen-basic.md)
Minor typo fixes in Basic Acquisition Tutorial
Add screenshots for Basic Generation Tutorial

Live version of the proposed tutorial can be found here:
https://hernstrom.github.io/automotive-camera-module-reference/tutorials/gettingstartedexample/gse-gen-basic.html

I was not able to see any GPIO toggling just from GPIO level reset during the running of the VI in the 'Performing a Simple Generation with GPIO Logging' section. We still demonstrate the basic mechanics of GPIO logging, but there's not much to see in the results.

Does anyone know if I missed a step in configuring GPIO logging
Assuming it's correct, still worth keeping this section (I slightly lean towards yes)


BE: RBAC: Ignore values for non-applicable resources

[ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixed https://github.com/kafbat/kafka-ui/issues/253
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

[x] No need to
[ ] Manually (please, describe, if necessary)
[ ] Unit checks
[ ] Integration checks
[ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
[x] My changes generate no new warnings (e.g. Sonar is happy)
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged

Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)

@Haarolean Can you tell me if a unit test is needed for this refinement?
Is there anything I can do to improve PR ?

@wernerdv I was hesitant to merge this as I thought there might be some other corner cases and given we don't have tests for RBAC at all, I have to eyeball this as much as possible. I wouldn't push you to write all the tests for RBAC in a scope of this issue.

should be good
@wernerdv thank you and sorry for the delay with this.
Raised #729 to finally cover the RBAC parts with tests


Reformat code with black

@kharus just wanted to point out that there already is a pre-commit hook formatting the code with ruff — see https://github.com/smucclaw/gsheet/blob/main/.pre-commit-config.yaml
Anything you want to do with black, you can probably do with ruff  — you might need to adjust the indentation settings


Is there any plan to support official project manager tools like Kanban or Trello?

I really want to manage project schedule or sprint schedule or time schedule in VSCode, and want to keep it anywhere any devices with my hotmail account, is there any plan to support official project manager extension like Kanban or Trello tools?

This is an extension opportunity and there are already several extensions in the Marketplace that integrate a project manager /kanban tool, pls see https://marketplace.visualstudio.com/search?term=kanban&target=VSCode&category=All categories&sortBy=Relevance and https://marketplace.visualstudio.com/search?term=trello&target=VSCode&category=All categories&sortBy=Relevance.


Added ontoconvert tool

Allows to convert ontologies between different file formats.
It would be great to add an option for reasoning too.

Test seems to work now in branch tolerant-labels, so will work here too after merging them .


use composite actions to reduce CI duplication

We have a lot of duplication across our repositories used for CI and building releases.
This could be improved with a composite action that contains steps that are shared by all jobs, e.g. installing dependencies, setting up compilers, setting ENV vars.

e.g. a setup-ci repo in the spatial-model-editor org
composite actions can use other actions: https://github.blog/changelog/2021-08-25-github-actions-reduce-duplication-with-action-composition/
can use echo "{name}={value}" >> $GITHUB_ENV to set an env var in the main workflow

resolved by #981, #982


Move method bindings from ArrayMesh to Mesh:

surface_get_primitive_type
surface_get_format
surface_get_array_index_len
surface_get_array_len

I would extend cpp-bindings to get access from gdnative modules via api.json. I have already successfully tested this.
I would appreciate it if this would be included in the 3.2 branch.

You'll need to also update the corresponding documentation by running the doctool command e.g. path_to_engine --doctool . and moving the descriptions over.

I'm not sure this can be cherry-picked for 3.2, won't this break the GDNative ABI?
CC @BastiaanOlij

No, should be fine, as they are new bindings they just won’t be available
unless you regenerate the bindings. It does mean that if you use these but
load the plugin in an older version of godot it will break, but thats been
a problem with cpp bindings from day one.
On Mon, 31 Aug 2020 at 7:19 pm, Rémi Verschelde<EMAIL_ADDRESS>wrote:

I'm not sure this can be cherry-picked for 3.2, won't this break the
GDNative ABI?
CC @BastiaanOlij https://github.com/BastiaanOlij
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/41632#issuecomment-683667150,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO262OB6Z7YJYWIY75HKH3SDNTLDANCNFSM4QP2LFHA
.

--
Kindest regards,
Bastiaan Olij
My personal profile on Facebook https://www.facebook.com/bastiaan.olij
My professional profile on LinkedIn
https://www.linkedin.com/in/bastiaanolij/
My profile on Twitter https://twitter.com/mux213
My tutorials on Youtube https://www.youtube.com/BastiaanOlij
My code repositories on Github https://github.com/BastiaanOlij

@playmyskay Is this still desired? If so, this needs to be rebased on the latest master branch, and squashed, along with addressing all of the above feedback.

@playmyskay Is this still desired? If so, this needs to be rebased on the latest master branch, and squashed, along with addressing all of the above feedback.

@playmyskay Is this still desired? If so, this needs to be rebased on the latest master branch, and squashed, along with addressing all of the above feedback.

@aaronfranke
No longer desired.

@playmyskay should this issue be closed then ?


Add instantiate_address function

TBD

What is this supposed to do? The address generation of Instantiate is unspecified and belongs to the environment (wasmd). You can implement one in multitest if you need it there.

Ok.

The only reason to have such a function in Std is to keep this logic aligned with BuildContractAddressClassic in wasmd and use it where needed

This would create the false sense of stability. In the original Instantiate, the contract just gets an address assigned. The algorithm can change any time and the contract must not make any assumptions on it. It gets the contract address of the newly generated instance as part of the events and
// MsgInstantiateContractResponse return instantiation result data
message MsgInstantiateContractResponse {
  // Address is the bech32 address of the new contract instance.
  string address = 1;
  // Data contains bytes to returned from the contract
  bytes data = 2;
}


Is it possible to disable log creation and just have logs go to stdout?

Topic kind of says it all, is there currently a way to keep the logging output of dxvk without writing logs files and just have logs go to stdout? If not could this be added?

I decided to just send them to /tmp for now but could we have a switch in the future to disable log file creation but not logging itself? Thanks.

May I ask what the use case is?
It's easy, but I really don't want to add even more unnecessary bloat. We already have a million environment variables to worry about.

May I ask what the use case is?

I already capture the stdout and stderr of wine to a file having dxvk produce files is just duplicating what I already capture not to mention putting a bunch of files throughout game directories that can be hard to find and get rid of. I know it's a bit of a feature request but it would be really nice if dxvk didn't produce log files everywhere by default.

DXVK will continue to produce log files by default because otherwise we will see even more bug reports with zero information, and that is really the last thing I want.
I can add an option to disable file creation (even though I don't want to), but stderr alone is not reliable enough since DXVK is a windows library, and having to tell people how to capture stderr or manually enable logging especially with something like Lutris is just going to be a horrendous pain in the arse.