[No QA][TS migration] Migrate 'LoginUtils.js' lib to TypeScript

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/24834
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/91068263/d9f58cd8-fa86-4c4b-b06c-3f669e4a4cc6

Mobile Web - Chrome

Mobile Web - Safari
https://github.com/Expensify/App/assets/91068263/343e426e-9a44-440b-a14f-aec056d89251

Desktop
https://github.com/Expensify/App/assets/91068263/07566c25-47f3-4f8b-8ab9-aaa11a0d21d9

iOS
https://github.com/Expensify/App/assets/91068263/003627c8-3473-4e28-80a8-7a8027612243

Android
[android.webm](https://github.com/Expensify/App/assets/91068263/6efd727d-e5c7-416a-8e47-989ef5a32917)

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/20051562/1d2555f0-559f-4f34-9b62-86629a7fdc6a
https://github.com/Expensify/App/assets/20051562/a727380e-9e19-4274-910e-d7bba57e7295

Desktop
https://github.com/Expensify/App/assets/20051562/5e1aeaa5-c0e9-452f-88ba-7d18e305ffb8

Mobile Web - Chrome
https://github.com/Expensify/App/assets/20051562/84837082-642b-45c8-a152-f164778af9f8

Android
https://github.com/Expensify/App/assets/20051562/bf894120-98a9-4b79-a415-8e6c638aa8a6

Mobile Web - Safari
https://github.com/Expensify/App/assets/20051562/a8d43d76-b7a1-4333-ac09-1f3cc6c6565f

iOS
https://github.com/Expensify/App/assets/20051562/a63dff0a-8b64-4dc8-ab6f-0fd66ce66931

Can you write a few QA tests to confirm this isn't going to add a regression? Thanks!

@AndrewGable done ✅

@kowczarz We have lint errors here

I'm not seeing the QA tests and we should remove the [No QA]

@AndrewGable Kamil is OOO this week, he'll add QA steps and adjust the title next week.

@AndrewGable done ✅

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.77-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Fix signs for light probe coefficients

Light probes are neat!
While testing I noticed the light often came from wrong direction, and traced it down to few wrong signs when converting cubemap UV coordinates to 3D direction vector, and signs for SH coefficients.
I used https://www.ppsloan.org/publications/StupidSH36.pdf as a reference. Testing was done with this script.
I've also compared results with three.js implementation, it comes out completely identical to my eye.

Quick rundown of changes:

The SH basis coefficients alternate between + and - sign, as per appendix A2 of StupidSH36
When iterating through texels, offset by 0.5 to get to center of a texel
Converting UV to 3D direction - first image is -X, second is +X... so case 0 should have -1.f as X coord
V image coord is 0 for top and has to be inverted when converting to 3D space
introduced GammaToLinear for better contrast, and to match existing examples

The color being linearized is suspect for anything other than sRGB input
colors - does this only run on sRGB images?
On Wed, Mar 1, 2023 at 7:19 AM Josip @.***> wrote:

Quick rundown of changes:

The SH basis coefficients alternate between + and - sign, as per
appendix A2 of StupidSH36
When iterating through texels, offset by 0.5 to get to center of a
texel
Converting UV to 3D direction - first image is -X, second is +X...
so case 0 should have -1.f as X coord
V image coord is 0 for top and has to be inverted when converting to
3D space
introduced GammaToLinear for better contrast, and to match existing
examples

—
Reply to this email directly, view it on GitHub
https://github.com/bjornbytes/lovr/pull/644#issuecomment-1450326445, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABVS5UQ6XV5ECIIYQSDTU3WZ5SJDANCNFSM6AAAAAAVMFSM54
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

No, it's possible to create a light probe from e.g. a cubemap in a KTX file with a floating point format.
I think the getPixel callback should look at the lovrImageIsSRGB flag to see if the conversion is needed.

Also changed equirect. Not sure if it is correct because it's not as easy to generate in runtime as it is with skybox, but it looks better.
I couldn't find any KTX skybox file that lovr would cooperate with. Some were "supercompressed" and others reported "unsupported image format (glType = 0, glFormat = 0, glInternalFormat = 37492)". If you have any skybox in that format I can add the conversion check and test it.

If you've got filament's cmgen tool, it can convert cubemap/equirect images to KTX cubemaps in rg11b10f format.

I just learned that the convention where the sign alternates like this is called Condon-Shortley phase factor.  Some scientific fields use it, while others leave it out.  I think as long as you are consistent with the negation during both A) basis construction B) evaluation, everything should turn out the same.  The Sloan paper lists them with this phase factor, whereas the Stanford paper (which I used) doesn't use it, along with THREE/filament/Wikipedia.  Even though both are valid, I lean towards going back to all-positive coefficients since it seems to be a little more common in graphics.
Regarding cubemaps, I definitely got these wrong and forgot to flip on X/Y -- I've mostly been testing equirect so far.  (Note that the face order is still +X/-X, but there is an X flip needed during sampling for...reasons I don't remember.  But it's in cubemap.frag).

Reverted the Condon-Shortley alternating signs. Testing script in above gist is also updated.
Kept the +X/-X change to accommodate the cubemap flip, the results are obviously wrong without it. Reverted some code alignment whitespace.
The linearization now checks for sRGB image. It is done in another commit so it can be rejected or done in a different way. (I hated both options of adding the check for each and every pixel, and branching to 3 more functions)

Thanks for the fixes, looking good now.  Yeah, I'm worried about the performance of all the per-pixel checks, but didn't want to pass an Image/pointer into the math module.  I want to do some tests to see how bad it really is though.


Use sync model

Use sync model instead of async model.
Remove unused event.
Change foreach to LINQ.

@jjw24  please review.

i think we should stick with linq because: https://stackoverflow.com/questions/3156059/is-a-linq-statement-faster-than-a-foreach-loop
my understanding in terms of performance, for is faster than foreach, and foreach is faster than linq. That's why we used for loops in the FuzzySearch method.

i think you included the files from Output. We need to add a git ignore file

i think you included the files from Output. We need to add a git ignore file

Well I do add a git ignore file, but it seems that some file already been pushed, which makes those file cannot be ignored. If you know how to remove them from remote, please take a try!

i think we should stick with foreach because: https://stackoverflow.com/questions/3156059/is-a-linq-statement-faster-than-a-foreach-loop
my understanding in terms of performance, for is faster than foreach, and foreach is faster than linq. That's why we used for loops in the FuzzySearch method.

Well I think you are right, but not sure about how linq implement tolist. Will that be faster than adding each element separately? I will take a look on that later. If for is the fastest, it maybe possible to move to for.

@jjw24 done those change, please review again. Thank you

No problem, will take a look tmr

i think you included the files from Output. We need to add a git ignore file

Well I do add a git ignore file, but it seems that some file already been pushed, which makes those file cannot be ignored. If you know how to remove them from remote, please take a try!

i will play around with it tmr and push up the removal if ok

i think you included the files from Output. We need to add a git ignore file

Well I do add a git ignore file, but it seems that some file already been pushed, which makes those file cannot be ignored. If you know how to remove them from remote, please take a try!

i will play around with it tmr and push up the removal if ok

Thanks

why are we using sync instead of async?

why are we using sync instead of async?

We don't need async... Flow is already making Plugins runs async.

Will create the new release tonight.


Create array.cpp

Just a heads up you accidently made a PR to the Godot main repo. Try to avoid this same mistake in the future. :)


UI Refresh with updated dependencies

Duplication of #125 after the diff got messed up for some reason.
This is based on #122 adding a bit more clean up and polish to the UI.
Before

After

@alvi-khan Hi, when you get some free time, can you kindly review this one?
P.S: Desktop artifacts can be downloaded from the "Checks" > "Summary"

Hey @tecoholic. The UI updates look great! I added a few minor opinions I had above.
Two more things. Firstly, I guess the link under the Screenshots section in the README.md file needs to be updated to ![NER Annotator Screenshot](./public/assets/step-2.png). GitHub wasn't letting me add this as a comment since that line wasn't modified.
Secondly, I think the windows build is failing because of the version number. It seems this is a known issue. I guess we'll have to manually upload the windows builds to the releases section until this version is ready for a full release.

@alvi-khan Thank you for a detailed review. I fixed a number of issues you pointed out and also made a few adjustments to the start page, including disabling the menu items on start page - only "Open File" is allowed.

Yes. The screenshot link is broken in the README. I think we need to update the screenshots for HelpDialog as well. So, I am planning on doing that once we have the functional changes reviewed and finalized.
Windows builds - Yeah. That's annoying. I don't have a Windows machine for doing Windows build. Do you happen to have one? And would you be able to test it out? Otherwise, I can remove the pre-release tag from the version and let GitHub handle it.
I am also thinking of adding a MacOS build for the 2.0 release. What do think about it? There is no work from our side to do it, Tauri's build should handle that in the CI.

@alvi-khan I generally agree with your comments on colors. Would you be kind enough to update the PR with the colors you think would be appropriate? I am generally color challenged and that's the reason, I tend to stick to defaults for most things. I tried to communicate certain things with color, but seems to have failed terribly :shaking_face:

@tecoholic Hey, I struggle with colors too — it's tricky! And you're being way too hard on yourself. The UI you built, both before and in this update, looks amazing! The modern and user-friendly design you gave this app is a big reason I decided to use it in the first place.
I’ve made a few minor adjustments to the colors where I thought it might help. If you’re good with these changes, I think this is ready to be merged. Thanks so much for putting in all this effort — it really shows!

@alvi-khan Thanks for your kind words and taking the time to make the fixes. You have been a great support in maintaining this project.
Version 2.0.0 released :)


Added metrics for http response codes

We track all requests by status code, so we can return the ratio of e.g. 500 responses.
This is saved in cache for 60 mins, so this is reset when cache runs out. Inputs for a better solution is more than welcome?

Added @petersuhm in composer.json
Added check for 500 response ratio
Added route _health/stats to return all stats

Review? @petersuhm

Looks kewl! 🤘


regexp_replace() returning incorrect pointer?

Hello, I am trying to use the re extension for RegEx (on Windows, compiling for 32-bit).   Functions all work, except for the regexp_replace function.   It returns correctly when it doesn't find anything to replace, but there is a strange effect when something is replaced:
My Test case is
select regexp_replace('The current year is AD 2025', '[0-9]+', '2050')
The result varies on each call.  For example, here are ten calls:
mainThe current year is AD
sqlThe current year is AD 2
The current year is AD 2050
The current year is AD 2050
sqlite_masterThe current ye
tbl_name='AAA' AND type!='t
mainThe current year is AD
sqlite_masterThe current ye
The current year is AD 2050
TEXTThe current year is AD
It behaves as if the call I make to sqlite_column_text() returns a pointer that is a variable number of bytes smaller than the actual start of the result string.  I thus read some other bit of memory before the actual value starts, and loss the end of the value (I copy a number of bytes returned by sqlite3_column_bytes()).
Any ideas of what might be wrong?
-- James Powell

Thanks for noticing! Unfortunately, I don't have a Windows machine to check this issue. Will look into it when I have a chance.
The source code for the regexp_replace() function looks pretty awful, but it passes the tests on Linux / macOS.

Found the bug and fixed it in 0.15.3.

Thanks!


Support for websockets

What should we add or change to make your life better?
Support for proxying websocket requests to the backend and/or proxy websockets to another backend other than where the http requests go.
Why is this important to you?
It would broaden the scope of use cases for the application.

WebSockets are already supported by default, have you tried it?
If you want them to go to a separate destination then you would assign them their own route.

Triage: Closing as its already supported. Please re-open if you find issues.

I'm getting
core.b11c5824.js:1 WebSocket connection to 'wss://example.com/api/websocket' failed: Error during WebSocket handshake: 'Connection' header is missing
Is it a YARP related issue?

That's not enough information. A decrypted network trace or Trace level server logs with Kestrel's Connection logging enabled would help debug that.
https://docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/kestrel?view=aspnetcore-3.1#connection-logging

Triage: Need to add a functional test for web sockets


THRIFT-5147: Add uninstall function

[x] Did you create an Apache Jira ticket?  (not required for trivial changes)
[x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[ ] If your change does not involve any code, add  [skip ci] at the end of your pull request to free up build resources.

@Jens-G ,   @dcelasun ,   @emmenlau ,  done.


README examples

Me and a friendly group p2p enthusiasts had a go at exploring this very interesting library (many thanks for all your hard work!) using the examples in the README and came up against a few difficulties. I'm sure some of it was our own inadequate understanding of the underlying networking logic, but also wondered if you consider the examples to be showing the whole picture, or maybe if they could be set out in a clearer way for people to be able to quite quickly get to a working demo?
Our concrete error was:
Error: Too few nodes responded
    at Query._endAfterCommit (/home/sandreae/Code/hyper-swarm/node_modules/dht-rpc/lib/query.js:195:20)
    at Query._flush (/home/sandreae/Code/hyper-swarm/node_modules/dht-rpc/lib/query.js:190:10)
    at Query._readMore (/home/sandreae/Code/hyper-swarm/node_modules/dht-rpc/lib/query.js:175:12)
    at Query._onerror (/home/sandreae/Code/hyper-swarm/node_modules/dht-rpc/lib/query.js:274:10)
    at Request.destroy (/home/sandreae/Code/hyper-swarm/node_modules/dht-rpc/lib/io.js:296:10)
    at Timeout.oncycle [as _onTimeout] (/home/sandreae/Code/hyper-swarm/node_modules/dht-rpc/lib/io.js:396:9)
    at listOnTimeout (node:internal/timers:559:11)
    at processTimers (node:internal/timers:500:7)

We had a publicly addressed bootstrap node running which was successfully receiving queries from nodes we were individually running but then the querying nodes timed out with the above error. We felt like we were missing an important step.
I understand there is a higher level API in https://github.com/hyperswarm/dht, but we actually chose to explore this lib as we're interested in the underlying functionality for discovery and hole-punching. Maybe you wouldn't recommend this though...
I'm afraid I don't feel I got my head around it enough to draw up any example code suggestions, but if you have pointers of another library we should be using, code we could refer to, or have time to look at the examples here then I'm very happy to test something out and give feedback.

Did you pass ephemeral: false in the options for the DHT constructor?


[bug]: VAE is not changing when "Use all"

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Windows
GPU
cuda
VRAM
11
What version did you experience this issue on?
3.2.0rc3
What happened?
When we press "Use All" on generated image - VAE what was used for generating of image is not setting.
But in different situations need either use old VAE from generated image or new VAE. It also will be good if there will flag like [FIX-VAE] - so that we can optionally enable or disable the VAE changing.
If it is hard for add - then let it changing as in generated image, please)
Screenshots
No response
Additional context
No response
Contact Details
No response

Good first issue for a UI/frontend contributor:

The logic will all live in invokeai/frontend/web/src/features/parameters/hooks/useRecallParameters.ts
To recall the VAE, we need to check if the VAE model is available before setting it. There's existing logic for recalling a LoRA, ControlNet, etc that you could use as a reference. Generally, we need to:

use mainModelsAdapter to

On review, we don't check if the main model is available on the system before setting it, so it'd be create if this was fixed at the same time

(accidentally closed sorry!)

You can assign to me, I am gonna try and get this in this weekend.
I did notice that precision was not in the metadata for the image, I have not looked through the issues but this may be something we want to add to the VAE metadata.

In versions >3.3.0 it has been fixed as I tested it.
Check it out please, and if all good - issue can be closed

I just tested on 3.3.0post3 and it doesn't look to be working. Correct me if I am misunderstanding the issue.

Thanks @StefanTobler , feel free to @ me here or on discord if you have any questions.


Use items(), print_function, and absolute_import.

LGTM. Can you as the imports to all the files?
Also, didn't you want to rename cmd.py?

@karth295 Let's add them as we need them. Also, the rename is ready to PR (cmd_to_main). I figured we'd do this one first since the other one is based on this (meaning it would show a combined diff unless this one merges first).


Reduce reliance on lodash

This reduces the reliance on "simple" lodash using vanilla methods in place of:

get -> accessing property directly with optional chaining
difference -> comparative filter of array
inRange -> >= and <
isArray ->Array.isArray
flatten -> flat
head(arr) -> arr[0]
last(arr) -> arr.at(-1)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 93.792%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
5618

Relevant Lines:
5820

💛  - Coveralls


[Question] Extract labels from PR title

I have tried lots of different configurations but can't figure out how to extract the label from the PR title. No matter what I do, I always get only uncategorized PRs.

The latest config I'm using looks like this:
 - name: Generate release changelog
        id: generate_release_changelog
        uses: mikepenz/release-changelog-builder-action@v4
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          configurationJson: |
            {
              "label_extractor": [
                {
                  "pattern": ".*(\\[Feature\\]|\\[Fix\\]|\\[Chore\\]|\\[Test\\]).*",
                  "on_property": "title",
                  "target": "$1"
                }
              ]
            }

I've looked at similar issues and found a reference to the test here: https://github.com/mikepenz/release-changelog-builder-action/blob/dffddcd83353ebb1c64f53b6cacfd6e24b707728/tests/transform.test.ts#L145
However, that's not working for me either.
Can you point out what I'm doing wrong?

Good day.
So before looking into the extractor itself, I'd like to point out that in your case you use the default configuration for categories, so chore would not be recognized as a category.
The default categories are: https://github.com/mikepenz/release-changelog-builder-action/blob/v4.2.2/src/configuration.ts#L76-L93
That said you can probably use something like this instead: https://github.com/mikepenz/release-changelog-builder-action/issues/1172#issuecomment-1650493613 whichever is first in [] to be the label. that also scales better for the future.
Unless you already used that too?

Hi @mikepenz, thanks for the quick response.
I tried lots of different configurations and also defined them explicitly.
For example:
{
  "template": "#{{CHANGELOG}}\n\n\nUncategorized\n\n#{{UNCATEGORIZED}}\n",
  "categories": [
    {
      "title": "## 🚀 Features",
      "labels": [
        "feat",
        "feature"
      ]
    },
    {
      "title": "## 🐛 Fixes",
      "labels": [
        "fix",
        "bug"
      ]
    },
    {
      "title": "## 🛠 Chores",
      "labels": [
        "chore"
      ]
    },
    {
      "title": "## 🛠 Dependencies",
      "labels": [
        "deps"
      ]
    }
  ],
  "label_extractor": [
    {
      "method": "match",
      "pattern": "^\\[(\\w*)\\]",
      "target": "$1",
      "on_property": "title"
    }
  ]
}```

In my understanding of the regex, it should match `Chore` in the case of a PR titled `[Chore] ....`. I also tried defining the labels in the categories as title case. I've played around with the regex in regex tools to see if that works, then escaped the `\`. I still get all PRs as uncategorized. It seems like it reads the JSON correctly as the template looks different.

Am I not getting something regarding the escaping of the regex or the definition of the labels?

Thanks!

Is the repo you run those on open source? Would allow me to reproduce it more quickly

The repos I'm trying to do this for are not, but I was able to reproduce it in this public repo: https://github.com/sebastianrosch/changelog-test

That is super helpful. Using the repo. Here's an adjusted config which should handle your use-case.
{
    "template": "#Changes: #{{CHANGELOG}}\n\n\nUncategorized\n\n#{{UNCATEGORIZED}}\n",
    "categories": [
        {
            "title": "## 🚀 Features",
            "labels": [
                "[feat]",
                "[feature]",
                "[Feature"
            ]
        },
        {
            "title": "## 🐛 Fixes",
            "labels": [
                "[fix]",
                "[bug]",
                "[Fix]"
            ]
        },
        {
            "title": "## 🛠 Chores",
            "labels": [
                "[chore]",
                "[Chore]"
            ]
        },
        {
            "title": "## 🛠 Dependencies",
            "labels": [
                "[deps]"
            ]
        }
    ],
    "label_extractor": [
        {
            "method": "match",
            "pattern": "\\[.+?\\]",
            "on_property": "title"
        }
    ]
}

Key details:

fixed the template, the # was missing in front of CHANGELOG
adjusted the regex to match the [] bracket. note this will match including the bracket
adjusted the labels in the categories to include the brackets as well

That said, v5 of the action actually contains a feature that makes such regex's much simpler, by offering a regex match logic similar to what regexr does.
So for @v5 the following will work:
{
    "template": "#Changes: #{{CHANGELOG}}\n\n\nUncategorized\n\n#{{UNCATEGORIZED}}\n",
    "categories": [
        {
            "title": "## 🚀 Features",
            "labels": [
                "feat",
                "feature",
                "Feature"
            ]
        },
        {
            "title": "## 🐛 Fixes",
            "labels": [
                "fix",
                "bug",
                "Fix"
            ]
        },
        {
            "title": "## 🛠 Chores",
            "labels": [
                "chore",
                "Chore"
            ]
        },
        {
            "title": "## 🛠 Dependencies",
            "labels": [
                "deps"
            ]
        }
    ],
    "label_extractor": [
        {
            "method": "regexr",
            "pattern": "\\[(.+?)\\].+",
            "target": "$1",
            "on_property": "title"
        }
    ]
}

Awesome, thank you, that worked! I've tried the regexr method before but didn't see that this was only supported in v5.
Thanks for the help!


feat: Improve tool.pixi.project detection logic

@tdejager , as discussed, an improved detection of pixi project table in pyproject.toml , encapsulating all non-pixi pyproject.toml logic used during init into a struct.
plus minor cleanup (e.g. typo)

Same here, going to merge!


don't know how to make protobuf::protoc. Stop

 protobuf::protoc gets into makefiles:
ortools/sat/boolean_problem.pb.cc: protobuf::protoc

Version: 7.7
OS: FreeBSD 11.2

Hi,
Which build system did you use ?
Which command did you run ?
Do you have a log to share ?

I use the FreeBSD ports framework. cmake/ninja combination fails (cmake/gmake combination also fails).
For configuration cmake is run line this:
UNIX_CBC_DIR=/usr/local UNIX_CLP_DIR=/usr/local PKG_CONFIG=pkgconf XDG_DATA_HOME=/usr/ports/math/or-tools/work  XDG_CONFIG_HOME=/usr/ports/math/or-tools/work  HOME=/usr/ports/math/or-tools/work PATH=/usr/ports/math/or-tools/work/.bin:/home/yuri/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin SHELL=/bin/sh CONFIG_SHELL=/bin/sh \
cmake \
-DCMAKE_C_COMPILER:STRING="cc"  -DCMAKE_CXX_COMPILER:STRING="c++"  -DCMAKE_C_FLAGS:STRING="-O2 -pipe -fno-omit-frame-pointer  -fstack-protector-strong -fno-strict-aliasing "  -DCMAKE_C_FLAGS_DEBUG:STRING="-O2 -pipe -fno-omit-frame-pointer  -fstack-protector-strong -fno-strict-aliasing "  -DCMAKE_C_FLAGS_RELEASE:STRING="-O2 -pipe -fno-omit-frame-pointer  -fstack-protector-strong -fno-strict-aliasing "  -DCMAKE_CXX_FLAGS:STRING="-O2 -pipe -fno-omit-frame-pointer -fstack-protector-strong -fno-strict-aliasing -fno-omit-frame-pointer  "  -DCMAKE_CXX_FLAGS_DEBUG:STRING="-O2 -pipe -fno-omit-frame-pointer -fstack-protector-strong -fno-strict-aliasing -fno-omit-frame-pointer  "  -DCMAKE_CXX_FLAGS_RELEASE:STRING="-O2 -pipe -fno-omit-frame-pointer -fstack-protector-strong -fno-strict-aliasing -fno-omit-frame-pointer  "  -DCMAKE_EXE_LINKER_FLAGS:STRING=" -L/usr/local/lib -fstack-protector-strong "  -DCMAKE_MODULE_LINKER_FLAGS:STRING=" -L/usr/local/lib -fstack-protector-strong "  -DCMAKE_SHARED_LINKER_FLAGS:STRING=" -L/usr/local/lib -fstack-protector-strong "  -DCMAKE_INSTALL_PREFIX:PATH="/usr/local"  -DCMAKE_BUILD_TYPE:STRING="Release"  -DTHREADS_HAVE_PTHREAD_ARG:BOOL=YES  -DCMAKE_INSTALL_RPATH_USE_LINK_PATH=YES  -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DBUILD_DEPS:BOOL=OFF -DINSTALL_BUILD_DEPS:BOOL=OFF -DBUILD_PYTHON:BOOL=OFF -DBUILD_EXAMPLES:BOOL=OFF -GNinja

Failure log: https://people.freebsd.org/~yuri/or-tools-protobuf%3A%3Aprotoc-failure.log
I had to apply this patch:
@${REINPLACE_CMD} -e 's|protobuf::protoc|protoc -I${LOCALBASE}/include| ; s|protobuf$$:$$:protoc||' ${BUILD_WRKSRC}/build.ninja

to work around this issue, because cmake doesn't expand protobuf::protoc.

ok so you are using the freebsd protobuf package.
You should try to fix https://github.com/google/or-tools/blob/stable/cmake/FindProtobuf.cmake instead which is currently more in its infancy (i.e. it's a skeleton) as you can see.
note: concerning freeBSD hope to have soon a vagrant freebsd12 box to test the cmake build (ed using -DBUILD_DEPS=ON)

seems fixed on master by:
https://github.com/google/or-tools/commit/92fd9c5b74907029a10d50791fbaa6e3f0e65415


Version 5

Hi
I had some LiteDB, version 5, files i wanted to view, so i updated this repo to version 5. The details of my changes are in my commit messages. I made two commit because i was partially unsuccessful, and the second commit contains the files i was unsuccessful in updating. However - it is a start - and i thought perhaps you might want to create a new branch to pull these changes into but since there wasn't one i made the request to the master branch?

Hi, cool looks like a good start.
Yes, the ideal is create a new branch, I will see this as soon as possible.
I had pretensions to keep the single exe functional for versions 4 and 5, this proved possible but very complicated.
As I have limited time at the moment, the best option may be to proceed only with the version for LiteDB 5, more abstraction and assemblies for specific versions.

Hi, yeah i saw there were some other people in the issue's sectoin requesting an update for version 5, so i figured a incomplete solution might be worthwhile. Especially if its on a separate branch.
On Gitter I asked a question about updating
LiteDatabase.Engine.Run(command);

I think it's this issue and the one concerning passwords that are only ones causing missing features.
Also great project.

Up!


Google Adwords destination requires floodlightAccountId though it should be optional

Description
When creating Google Adwords destination 5a03bfe73156760001ab34ec terraform apply throws this error:
422 Unprocessable Entity
 {
   "errors": [
     {
       "type": "input-validation",
       "field": "floodlightAccountId",
       "message": "Please enter a valid config ID. Example: DC-1234567",
       "data": {
         "description": "Enter your DoubleClick Floodlight Advertiser ID to have it passed to Gtag's `config` parameter. This ensures tags are loaded by first-party cookies. This value should look like DC-1234567. For more information, see [Google's documentation](https://support.google.com/campaignmanager/answer/7554821?hl=en).",
         "type": "string"
       }
     }
   ]
 }

floodlightAccountId should be optional!
To Reproduce
resource "segment_destination" "google_adwords" {
    enabled = var.enable
    name = var.name
    source_id = var.segment_source_id
    settings = jsonencode({
        "accountId": var.account_id,
        "clickConversions": var.click_conversions,
        "conversionLinker": true,
        "defaultPageConversion": "",
        "disableAdPersonalization": false,
        "pageLoadConversions": [],
        "sendPageView": true,
        "floodlightAccountId": ""
    })
    metadata = {
        id = "5a03bfe73156760001ab34ec" # Google Adwords
    }
}

Hi @alex-haproff the issue with that field should be fixed now. Let me know if you run into any other issues and thanks for your patience!


Add servers, creds and nkey options to nack

Hi, this pr is for #21 .
NATS is a so amazing project! So I want to do something to make it better. I don’t know if my understanding is correct, so I drew a picture to express my thoughts:

What's different:
Add a servers option for Stream/StreamTemplate and Consumer crd. It's optional and will be an empty array by default. When you set this option, the controller will create a new nats connection and then initialize a jsm client to create Stream/StreamTemplate or Consumer.
$ kubectl logs jetstream-controller-65d5898bb7-9r4rb -f
# without servers option
I0304 08:04:14.386280       1 event.go:282] Event(v1.ObjectReference{Kind:"Stream", Namespace:"default", Name:"testnoserver00", UID:"e48551cf-6101-4e1f-813a-637b4d711605", APIVersion:"jetstream.nats.io/v1beta1", ResourceVersion:"21314662", FieldPath:""}): type: 'Normal' reason: 'Creating' Creating stream "testnoserver00"
I0304 08:04:14.474232       1 event.go:282] Event(v1.ObjectReference{Kind:"Stream", Namespace:"default", Name:"testnoserver00", UID:"e48551cf-6101-4e1f-813a-637b4d711605", APIVersion:"jetstream.nats.io/v1beta1", ResourceVersion:"21314663", FieldPath:""}): type: 'Normal' reason: 'Created' Created stream "testnoserver00"

I0304 08:07:27.259351       1 event.go:282] Event(v1.ObjectReference{Kind:"Consumer", Namespace:"default", Name:"testnoserver00", UID:"1cd08dae-bb7c-41aa-863d-6306a352bcfd", APIVersion:"jetstream.nats.io/v1beta1", ResourceVersion:"21315279", FieldPath:""}): type: 'Normal' reason: 'Creating' Creating consumer "testnoserver00" on stream "testnoserver00"
I0304 08:07:27.340657       1 event.go:282] Event(v1.ObjectReference{Kind:"Consumer", Namespace:"default", Name:"testnoserver00", UID:"1cd08dae-bb7c-41aa-863d-6306a352bcfd", APIVersion:"jetstream.nats.io/v1beta1", ResourceVersion:"21315280", FieldPath:""}): type: 'Normal' reason: 'Created' Created consumer "testnoserver00" on stream "testnoserver00"

# with servers option
I0304 08:13:37.694530       1 event.go:282] Event(v1.ObjectReference{Kind:"Stream", Namespace:"default", Name:"testserver00", UID:"3629f0b3-522d-4286-99aa-71dbe8c9fc8e", APIVersion:"jetstream.nats.io/v1beta1", ResourceVersion:"21316506", FieldPath:""}): type: 'Normal' reason: 'Creating' Creating stream "testserver00"
I0304 08:13:37.696927       1 event.go:282] Event(v1.ObjectReference{Kind:"Stream", Namespace:"default", Name:"testserver00", UID:"3629f0b3-522d-4286-99aa-71dbe8c9fc8e", APIVersion:"jetstream.nats.io/v1beta1", ResourceVersion:"21316506", FieldPath:""}): type: 'Normal' reason: 'Connecting' Connecting to new nats-servers
I0304 08:13:37.958991       1 event.go:282] Event(v1.ObjectReference{Kind:"Stream", Namespace:"default", Name:"testserver00", UID:"3629f0b3-522d-4286-99aa-71dbe8c9fc8e", APIVersion:"jetstream.nats.io/v1beta1", ResourceVersion:"21316507", FieldPath:""}): type: 'Normal' reason: 'Created' Created stream "testserver00"

I0304 08:17:10.385516       1 event.go:282] Event(v1.ObjectReference{Kind:"Consumer", Namespace:"default", Name:"testserver00", UID:"1c5afc4d-703f-4cdb-aaba-cfc243c23f5d", APIVersion:"jetstream.nats.io/v1beta1", ResourceVersion:"21317215", FieldPath:""}): type: 'Normal' reason: 'Creating' Creating consumer "testserver00" on stream "testserver00"
I0304 08:17:10.391586       1 event.go:282] Event(v1.ObjectReference{Kind:"Consumer", Namespace:"default", Name:"testserver00", UID:"1c5afc4d-703f-4cdb-aaba-cfc243c23f5d", APIVersion:"jetstream.nats.io/v1beta1", ResourceVersion:"21317215", FieldPath:""}): type: 'Normal' reason: 'Connecting' Connecting to new nats-servers
I0304 08:17:10.843949       1 event.go:282] Event(v1.ObjectReference{Kind:"Consumer", Namespace:"default", Name:"testserver00", UID:"1c5afc4d-703f-4cdb-aaba-cfc243c23f5d", APIVersion:"jetstream.nats.io/v1beta1", ResourceVersion:"21317216", FieldPath:""}): type: 'Normal' reason: 'Created' Created consumer "testserver00" on stream "testserver00"

Thanks a lot for documenting this and the PR. I think the use case sounds good, and generally LGTM, but will try to take a proper look next week.

Hello, how is it going? @wallyqs

@JackZxj apologies, it has been a busy couple of weeks shipping the server and now the Go client, I will try to check today and merge. Thanks again.

My pleasure. If anything is wrong, please contact me. I'm happy to contribute to this project!

Hi, @wallyqs .
I added two other options to NACK. With these two options, the controller can connect to the new jetstream in different authentication ways.

Hi, thanks  for your work @JackZxj !
We are also waiting for this feature, can we know if it will be merged soon or if there is any issue with this PR ?

We finally merged this as part of #42, thanks for the contribution. Apologies with the delay in integrating this into the main repo... There is now an accounts CRD where the creds can be stored so that they are fetched from the API server:
---
apiVersion: jetstream.nats.io/v1beta2
kind: Account
metadata:
  name: a
spec:
  name: a
  servers:
  - nats://nats:4222
  tls:
    secret:
      name: nack-a-tls
    ca: "ca.crt"
    cert: "tls.crt"
    key: "tls.key"

---
apiVersion: jetstream.nats.io/v1beta2
kind: Stream
metadata:
  name: foo3
spec:
  name: foo3
  subjects: ["foo3", "foo3.>"]
  storage: file
  replicas: 1
  account: a

I am so glad to contribute to this project~


feat(healthcheck) set_all_target_statuses_for_hostname

I'm not sure about this, but maybe (probably?) I'm wrong
The hostname is not an attribute the healthcheck needs by itself, it is only there in case there is an http proxy in between the healthchecker and the system being checked. A proxy that routes traffic differently based on Host header, eg:

the proxy living on <IP_ADDRESS>:80

proxying traffic for Host: myhost.com to <IP_ADDRESS>:8000
proxying traffic for Host: yourhost.com to <IP_ADDRESS>:8080
(traffic on a single ip/port is distributed over multiple ip/ports combo's)

DNS resolution gives:

record myhost.com has <IP_ADDRESS>
record yourhost.com has <IP_ADDRESS>
(both names resolve to the same IP; the proxy)

from the healthchecker perspective they are configured as:

probing Host: myhost.com to <IP_ADDRESS>:80
probing Host: yourhost.com to <IP_ADDRESS>:80

So I guess my conclusion is that the IP's could be duplicates, with multiple hostnames. But the hostnames should never have multiple IP's?
Or is there a case where this doesn't hold?

But the hostnames should never have multiple IP's?

This is for the targets configured in Kong using hostnames in the target, which expand to multiple addresses, and correspond to multiple healthcheck entries. When one hits the Kong endpoint to set the entire target as healthy, it needs to update multiple healthcheck entries at once.
Instead of exposing the internals of the healthchecker list and iterating from Kong, we expose a function here to do it in one call, like the dns-client library does with balancer:setHostStatus; we can't use that directly in the balancer because hitting the balancer directly like that doesn't propagate to all workers. We need to hit the healthchecker library instead, which then propagates correctly to all balancers via its own internal event system.
PR Kong/kong#5539 has more context on why this is needed (it is marked as "draft" because it is waiting for this PR to be merged here, a release of this library, and a version bump in Kong). IMO the Kong PR also shows why adding a function here provides a better match for the behaviors we want to achieve.


Detect service manager for new st2ctl

Provides fix for https://github.com/StackStorm/st2/pull/2367/files#r49736848

when service command is not available under CentOS7 (replaced by systemctl).
Tested/Verified.

lgtm. nice!


[WIP] Deploy Jobs Release (local branch)

Migrate to backend v4 with a job configuration.
Note: this is equivalent to #233 but from a branch rather than a fork.
This is a WIP thread used for deploying to development.

[x] Deploy v4 and test basic functionality
[ ] Switch to release-jobs branch
[x] Create test job config
[ ] Add rabbitMQ to job config and test archiving
[ ] Add email to job config
[ ] Test that all features are working as in v3

Keycloak and functional accounts now work.
jobConfig.json gets created from the github secret.

rebased again onto main


Handlebars.js

Project must use Handlebars.js as the template engine

working on handlebars documents and will push my work thus far to the dev branch tonight!

need to ask TA / team for help with initial handlebars rendering of all players on index page


Cache issues and questions

Does anyone know what to do when encountering this error?
Installing dependencies...
Resolving dependencies...
cabal: Could not resolve dependencies:
trying: hw-succinct-<IP_ADDRESS> (user goal)
next goal: hw-rankselect (dependency of hw-succinct-<IP_ADDRESS>)
Dependency tree exhaustively searched.

Note: when using a sandbox, all packages are required to have consistent
dependencies. Try reinstalling/unregistering the offending packages or
recreating the sandbox.
Process failed: cabal install --reorder-goals --max-backjumps=-1 --avoid-reinstalls --dry-run --enable-tests --enable-benchmarks --enable-profiling (exit code: 1)

Try mafia update to upgrade your cabal package list.

Try mafia update to upgrade your cabal package list.

I think hw-rankselect is source dependency, so this probably won't help.
@newhoggy got a link to the repo? it looks like mafia isn't finding the cabal file for hw-rankselect in your git repository, or in a submodule.

The repository does not have a .submodules file.
Here is the failing build:

https://circleci.com/gh/haskell-works/hw-succinct/528

Rebuild without cache works:

https://circleci.com/gh/haskell-works/hw-succinct/530

They are both building against commit id 06c5f83.
This commit id is tagged and can be viewed here: https://github.com/haskell-works/hw-succinct/tree/v<IP_ADDRESS>
Even though there is no .submodules file, I may have had such a file somewhere earlier in the history of the project.  Is it possibly that mafia has stored some state about the .submodules file and is failing because of that despite having removed it?

Ok I think I misunderstood, I guess hw-rankselect is not supposed to be a source dependency, but should come from hackage?
I noticed that you are caching /home/ubuntu/hw-succinct/.cabal-sandbox, I wonder if removing that from the cache might make it work.

I'm not caching the /home/ubuntu/hw-succinct/.cabal-sandbox, at least not intentionally:
The circle.yml file specifies the following: directories for caching:
  cache_directories:
    - "~/.ambiata"
    - "~/.cabal"
    - "~/.ghc"

Could ~/.caba or ~/.ghc be the problem?

@newhoggy I think it could be back to what @tmcgilchrist said originally, hw-rankselect has only been on hackage for a day so unless you have run cabal update it doesn't know about it which makes it looks like a submodule  in the error message, the cache for cabal update is in ~/.cabal so it would be persisted between builds. If you are running mafia update you should note it only updates from hackage once a day so depending on timings it may not of picked up that version yet (but would tomorrow), if you want to force it you could run cabal update directly. The only other possibility which I only mention because I have no idea about the innards of circle-ci is that if it does something dumb with sync the cache (for example updating the timestamp rather than keeping the original file attributes) it might mess with how mafia update determines how fresh the pacakges file from hackage is.

Cool.  I think I have the information I need to know what to look out for.  Currently my builds aren't in this state so I'll wait till it happens again, then take a look and report back.
Thanks!


Migrate Icon component over to LitElement; reduce overall SVG file size by 2.5x

Jira
http://vjira2:8080/browse/BDS-2127
Summary
Switches our Icon component over to render via LitElement + significantly reduce SVG file sizes by updating (and simplifying!) the Icon-portion of our build process.
Updates the Jest snapshots of components with inlined SVG assets to reflect the now smaller file sizes.
Details
Before our Icon JS bundle clocked in at around 390.7KB (uncompressed) -- now it's down to around 146KB! 🎉
How to test

Reference icon docs to confirm everything continuing to work exactly as expected
Double-check that Icons render correctly in Accordion (since that's one of the few places where Icons render inside the Shadow DOM of the parent component)

@sghoweri icons look good, no regressions to Accordion.
Good to merge once conflicts are resolved 👍

Thanks @danielamorse!

PR was released with v2.23.0


startsWith() does not use the PK index

Describe the bug
startsWith(a, 'a') does not use the index, though functionally identical like 'a%' does. This is confusing.
How to reproduce
create table test_index (a String) Engine = MergeTree PARTITION BY tuple() ORDER BY a;

INSERT INTO test_index (a) values ('a');

select count() from test_index where startsWith(a, 'abc') settings force_primary_key=1;

Received exception from server (version 19.4.3):
Code: 277. DB::Exception: Received from localhost:9000, ::1. DB::Exception: Primary key (a) is not used and setting 'force_primary_key' is set..

Similar query with LIKE:
select count() from test_index where a like 'abc%' settings force_primary_key=1;

Ok.

Expected behaviour
startsWith to use index if possible.

KeyCondition.cpp, look at atom_map and its usage.


API operations on a Flow should be Transactional

There are currently two API commands that are serialized into two distinct database events. If an error occurs and the second event is not persisted, the flow will end up in an inconsistent state and transaction guarantees around the API calls would be broken.
The problematic requests are model.AddCompletedValueStageRequest and model.AddDelayStageRequest. The proposal to fix this is to extend  model.StageAddedEvent to include an optional completed value and delay, so that we can recover the full state of those stages on restarting the graph actor.

After further discussion, we decided to create new event types for completed values and delayed stages.

I am closing since this can be solved more generally as part of a solution to https://github.com/fnproject/flow/issues/116


correction of module description

In reality, it pluralizes and singularizes English words.

Would you like to contribute another language? I don’t know others well enough to give it a shot.

Gladly, but this would probably require making it modular so that people can choose only the languages they need.


More publication types

It would be useful to be able to classify my personal publications as technical reports or book chapters

Sure thing Julian. I can take care of that.


Add new output formats

This adds new output formats for InfluxDB and DogStatsD
Description
Adds two new subclasses, one for InfluxDB and another one for DogStatsD.
Motivation and Context
I'm using InfluxDB and I wanted to have a way of creating plugins that natively supported, I also believe that Graphite's lack of support for tags is limiting so, I added two new formats that support tags.
How Has This Been Tested?
Created new tests.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have updated the Changelog following the conventions laid out on Keep A Changelog

Known Caveats

released: https://rubygems.org/gems/sensu-plugin/versions/2.3.0


Changing backbone of the model

Is there anyway to change model's backbone? If so, have anyone tried changing using backbone/ weights from timm yet?

recent, I changed the backbone by my custom model for training mask rcnn, but I got an issue
my model has similar parameters to the swin-t model, but the memory consumption shown in the training log is too big(12000 vs 6000), yet I have no idea about this issue.


Split the PropertyTest.test into testPropertyValuesUpdateAndEffect and testServiceInitializationWithDefaultProperties

Fix #714
Description
Refactored PropertyTest to split the combined test() method into two distinct tests: testServiceInitializationWithDefaultProperties and testPropertyValuesUpdateAndEffect. This change improves test clarity by isolating specific behaviors into separate tests.
Key Changes

Removed test() method to avoid redundancy.
Added testServiceInitializationWithDefaultProperties to test service initialization with default settings.
Added testPropertyValuesUpdateAndEffect to test the behavior upon updating property values.

Thank you for these improvements :-)


Support for imagePullSecrets in KeptnTaskDefinition

Goal
As a user, I want to use the KeptnTask container runtime with my container images from private registries. For that, I need the ability to define imagePullSecrets in the KeptnTaskDefinition so that the private images can be pulled successfully.
Details
Add a new optional field to the KeptnTaskDefinition to be able to define image pull secrets as it would be done in the Kubernetes PodSpec.
DoD

optional field added to CRD
helm chart updated with new CRD
CRD reference docs updated with new field
task documentation pages updated where applicable
new feature covered by unit test(s)
new feature covered by e2e test(s)

Hi @mowies could you please assign this issue to me. once it been refined.


Escaping backquotes

Is escaping backquotes done this way, or is it still unimplemented?
54 │       [else '(you can\'t go that way.)])))
   │                      ^ Parse: Unexpected character: '\\'

Good catch, looks like this isn't handled correctly. I'm currently re-implementing the tokenizer which should make handling this a bit easier. I'll follow up with the PR to replace that when its ready, and link to some test cases to handle it

This should get fixed in #102


Symbols and emojis

They're fun and help to visualize the information that you're displaying in different sections.

Tracking this one internally.


Can authors provide a bibtex for citation?

As title.

Hello,
Below is the BibTeX entry you can use for citation:
@software{Yang_Kyara_2024,
  author = {Yang, Kai-Chou},
  doi = {10.5281/zenodo.14001626},
  month = oct,
  title = {{Kyara}},
  url = {https://github.com/zake7749/Kyara},
  version = {1.0.0},
  year = {2024}
}


List all the groups per AdminID

Is your feature request related to a problem? Please describe.
This was requested/asked in ETHDam 2024 Hackathon. Seems like a good devex need
Describe the solution you'd like
I would like to have an API SDK method that returns all the groups of an AdminID.
Describe alternatives you've considered
Another related but different needs could be:

Return all groups per memberID

Additional context
There is an API endpoint to get all the groups using an adminId: https://api.bandada.pse.dev/#/groups/GroupsController_getGroups
If devs use the API SDK, they will need to get all groups using the getGroups() function and then filter by AdminId.

Hi! I would like to work on this issue.
Would you like it to be implemented into getGroups(adminId) with optional adminId or separate it to getGroupsByAdminId(adminId)?
Similar question for memberId, would you like it to be implemented as an optional query to getGroups in groups.service.ts or separate it?

Hi! I would like to work on this issue.
Would you like it to be implemented into getGroups(adminId) with optional adminId or separate it to getGroupsByAdminId(adminId)?
Similar question for memberId, would you like it to be implemented as an optional query to getGroups in groups.service.ts or separate it?

hello @waddaboo thanks for the interest.
tbh i'm okay with specific functions - getGroups() & getGroupsByAdminId() - or applying filters per field to the generic version - getGroups(filterBy: )

Hey @waddaboo do you want me to assign you this issue?

Hi! I would like to work on this issue.
Would you like it to be implemented into getGroups(adminId) with optional adminId or separate it to getGroupsByAdminId(adminId)?

Having separated functions in the API SDK is fine. It would be: getGroupsByAdminId() and getGroupsByMemberId().

Similar question for memberId, would you like it to be implemented as an optional query to getGroups in groups.service.ts or separate it?

Yes, an optional query in the backend is fine:
https://github.com/bandada-infra/bandada/blob/79cd218d5d28d47de083a9737925f69881f2e178/apps/api/src/app/groups/groups.service.ts#L814

Hey @waddaboo do you want me to assign you this issue?

Hey @vplasencia! Yes, please :)

Having separated functions in the API SDK is fine. It would be: getGroupsByAdminId() and getGroupsByMemberId().
Yes, an optional query in the backend is fine:

Noted, I will proceed with the suggested solution.

Hey @waddaboo
I just assigned you this issue. Please, let us know if you have any questions.


Can I drop all labels from lower level on every entry?

Trying to figure out a rule for GC'ing labels that I already have their entry, while creating new entries cheaply.
Is it accurate to say, on each label with hight Y I can delete all labels with height Y-1?
For example:

(3,0) => Nothing to delete
(3,1) => Delete (1,0), (2,0), (3,0)
(6,1) => Delete (4,0), (5,0), (6,0)
(9,1) => Delete (7,0), (8,0), (9,0)
(9,2) => Delete (3,1), (6,1), (9,1)

At least it appears so from all the graphs, just want to check the math.

To be able to continue creating new events and compute the labels of all their associated vertices, you need to keep around the labels of the vertices of the shortest path from the most recent event x to the topmost vertex of the greatest power of two that is strictly less than or equal to x.
In the papers, this is the information needed to be able to continue to call iterative_digest (https://aljoscha-meyer.de/reed/assets/references/meyer2023sok.pdf, section 4).

Thanks, I will try to see if my rule of thumb satisfies that formal definition for larger sequences than in the paper. It would be nice if it does, since it is simpler to check and implement: check the top of the stack, if its y is smaller than the new vertex, delete it and repeat until it is not true, then push the new vertex.


audio: use the new malloc_uncached API

The internal buffers are meant to be used with uncached accesses as
they are primarily consumed via DMA (AI or RSP).
This is a slight API change as the recent audio_write_begin() will
now return an uncached pointer, but hopefully it will not change much
for most use cases.
@meeq @ryzee I would appreciate if you could test this PR in your games. It should not break audio :)

Tested with FlappyBird, no issues detected.


Stock span problem in C

Have you read the Contributing Guidelines on Pull Requests?
yes
Description
I have added code for Stock span problem in C using Stack.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#1566

@iamrajiv Please review


[CodeForces]: Problem can be updated twice in one submission script execution

Hi i want to solve this bug . Please  can u give some guidelines?

Hey @namanbiyani : Sorry for the late reply, was stuck with a few things.
The overview:
We have daily submission retrieval script which fetches submissions from every site. After this is done we run another script which retrieves tags for the newly added problems (say from a new contest).
Now this is the generic behaviour, but Codeforces gives tags of the problems along with submission retrieval. So what we do is we try to update the tags in the problem table along with insertion in submission table (note: this is just for Codeforces).
As you could figure out from the above descriptions there is a chance where the user might have submitted multiple submissions for a problem. In the process of retrieving submissions we will end up updating the problem table multiple times.
This is our submission retrieval script - https://github.com/stopstalk/stopstalk-deployment/blob/master/private/scripts/submissions.py
The line where we update the problem table - https://github.com/stopstalk/stopstalk-deployment/blob/master/modules/sites/codeforces.py#L175
PS: In the process of explaining you, I figured out a quick fix
https://github.com/stopstalk/stopstalk-deployment/blob/master/modules/sites/codeforces.py#L176
Just add at least this along with the above line
plink_to_id[problem_link] = str(tags)

and test if this fixes the problem
Feel free to reply with any point where you get stuck at this.


Remove reply keyboard in certain cases

[ ] When there are no more overdue chores left
[ ] On show_welcome_message(), add reply_markup=ReplyKeyboardRemove(remove_keyboard=True, selective=True)
[ ] Fix the broken test for the /start command

This issue has become obsolete. See #135.


Regarding the issue of EfficientSAM of checkpoints

Hello, I'm grateful for your research.
I have a question about checkpoints. Is the change in weights of efficentsam compared to sam only the image encoder part.
Or can I get the correct result by processing the weights of the image encoder of efficentsam with the weights of the prompt encoder and mask decoder of the original sam?

@feivellau, thanks for your interest! We finetuned the entire model including encoder and decoder. I guess it may not work with efficientsam encoder and original sam decoder. Maybe you can give it a try?

@feivellau, thanks for your interest! We finetuned the entire model including encoder and decoder. I guess it may not work with efficientsam encoder and original sam decoder. Maybe you can give it a try?

@yformer I have tried it and it doesn't work properly. Furthermore, I have found that the results are very poor when setting multimask_output=False to get a single mask.

@feivellau, the entire model is finetuned. It may not work properly with efficientsam encoder and original sam decoder. For a single mask, you can set multimask_output=True and then obtain the single mask from output with single_mask = predicted_logits[0, 0, 0, :, :] >= 0.

@yformer.
if multimask_output and self.num_multimask_outputs > 1:
    return masks[:, 1:, :], iou_pred[:, 1:]
else:
    return masks[:, :1, :], iou_pred[:, :1]

I'm just trying to follow what the original SAM paper said about a couple different mask outputs. But the results masks[:, :1, :], iou_pred[:, :1] in EfficientSAM are not good. And  masks[:, 1:, :], iou_pred[:, 1:] needs to be sorted to determine the best output

The same issue as Expose multimask_output in EfficientSam.forward has some examples.


"DllNotFoundException: SVMModel" when trying to "Train" with OpenSeeExpression

I'm using Unity 2020.3.30f1 Personal running on KDE Neon 5.24 (Ubuntu 20.04 LTS)
I'm trying to record expressions with the OpenSeeExpression Script, but when I click "Train" I get this Exception in the Console:

DllNotFoundException: SVMModel
OpenSee.SVMModel.trainModel (System.Single[] features, System.Single[] labels, System.Single[] weights, System.Int32 rows, System.Int32 cols, System.Int32 classes, System.Int32 probability, System.Single C) (at Assets/OpenSeeFace/Plugins/SVMModel.cs:19)
OpenSee.SVMModel.TrainModel (System.Single[] features, System.Single[] labels, System.Single[] weights, System.Int32 rows, System.Int32 cols, System.Int32 probability, System.Single C) (at Assets/OpenSeeFace/Plugins/SVMModel.cs:174)
OpenSee.OpenSeeExpression.TrainModel () (at Assets/OpenSeeFace/OpenSeeExpression.cs:528)
OpenSee.OpenSeeExpression.Update () (at Assets/OpenSeeFace/OpenSeeExpression.cs:701)

I also get this message when clicking the "Load" tick:

ArgumentNullException: Buffer cannot be null.
Parameter name: buffer
System.IO.MemoryStream..ctor (System.Byte[] buffer, System.Boolean writable) (at <695d1cc93cca45069c528c15c9fdd749>:0)
System.IO.MemoryStream..ctor (System.Byte[] buffer) (at <695d1cc93cca45069c528c15c9fdd749>:0)
(wrapper remoting-invoke-with-check) System.IO.MemoryStream..ctor(byte[])
OpenSee.SVMModel.LoadSerialized (System.Byte[] modelBytes, System.Int32& cols, System.Int32& maxClasses, System.Boolean compress) (at Assets/OpenSeeFace/Plugins/SVMModel.cs:82)
OpenSee.SVMModel.LoadModel (System.Byte[] modelBytes, System.Boolean compress) (at Assets/OpenSeeFace/Plugins/SVMModel.cs:129)
OpenSee.SVMModel.LoadModel (System.Byte[] modelBytes) (at Assets/OpenSeeFace/Plugins/SVMModel.cs:134)
OpenSee.SVMModel..ctor (System.Byte[] modelBytes) (at Assets/OpenSeeFace/Plugins/SVMModel.cs:277)
OpenSee.OpenSeeExpression+OpenSeeExpressionRepresentation.LoadSerialized (System.Byte[] modelBytes, System.Collections.Generic.Dictionary``2[System.String,System.Collections.Generic.List`1[System.Single[]]]& expressions, OpenSee.SVMModel& model, System.String[]& classLabels, System.Int32[]& indices, OpenSee.OpenSeeExpression+PointSelection& pointSelection) (at Assets/OpenSeeFace/OpenSeeExpression.cs:172)
OpenSee.OpenSeeExpression.LoadFromBytes (System.Byte[] data) (at Assets/OpenSeeFace/OpenSeeExpression.cs:653)
OpenSee.OpenSeeExpression.LoadFromFile () (at Assets/OpenSeeFace/OpenSeeExpression.cs:675)
OpenSee.OpenSeeExpression.Update () (at Assets/OpenSeeFace/OpenSeeExpression.cs:704)

I haven't edited neither the script nor the plugin, I also seem to be getting the corresponding Debug.Logs when clicking "Train" up until

Training LibSVM
UnityEngine.Debug:Log (object)

I also tried with ThunderSVM but it also fails

DllNotFoundException: ThunderSVMWrapper
ThunderSVMModel.trainModel (System.Single[] features, System.Single[] labels, System.Single[] weights, System.Int32 rows, System.Int32 cols, System.Int32 classes, System.Int32 probability, System.Single C) (at Assets/OpenSeeFace/Plugins/ThunderSVMModel.cs:18)
OpenSee.SVMModel.TrainModel (System.Single[] features, System.Single[] labels, System.Single[] weights, System.Int32 rows, System.Int32 cols, System.Int32 probability, System.Single C) (at Assets/OpenSeeFace/Plugins/SVMModel.cs:174)
OpenSee.OpenSeeExpression.TrainModel () (at Assets/OpenSeeFace/OpenSeeExpression.cs:528)
OpenSee.OpenSeeExpression.Update () (at Assets/OpenSeeFace/OpenSeeExpression.cs:701)

Hi! I believe the expression detection may not currently work natively under Linux.
You can probably make a Linux build using the files here:
https://github.com/emilianavt/OpenSeeFace/tree/master/Source
I haven't tested it, but something like g++ SVMWrapper.cpp svm.cpp -shared -o LibSVM.so might work.

When trying to build I get:

SVMWrapper.cpp:4:10: fatal error: stdafx.h: No existe el archivo o el directorio (The file nor the path exists)
4 | #include "stdafx.h"
|          ^~~~~~~~~~
compilation terminated.
svm.cpp:1:10: fatal error: stdafx.h: No existe el archivo o el directorio (The file nor the path exists)
1 | #include "stdafx.h"
|          ^~~~~~~~~~
compilation terminated.

I checked with Visual Studio Code to see what was happening and I got some the exceptions (Translated)

svm.cpp (3)

#Include errors have been detected. Update the value of includePath. The undulating underline is disabled for this translation unit
The source file can not be opened (Error code "stadfx.h").
The source file can not be opened (Error code "combaseapi.h").

svm.h (1)

#Include errors have been detected. Update the value of includePath. The undulating underline is disabled for this translation unit

SVMWrapper.cpp (2)

#Include errors have been detected. Update the value of includePath. The undulating underline is disabled for this translation unit
The source file can not be opened (Error code "stadfx.h").

ThunderSVMWrapper.cpp (7)

The source file can not be opened (Error code "pch.h").
The source file can not be opened (Error code "framework.h").
The source file can not be opened (Error code "ThunderSVMWrapper.h").
The source file can not be opened (Error code "thundersvm.h").
The source file can not be opened (Error code "svmmodel.h").
The source file can not be opened (Error code "svc.h").

I thought this was a problem with Linux so I checked in Windows and tried to build there, but I get the same problems. I searched and found that it seems I'm missing some header files that are supposed to be bundled with the IDE but I couldn't find them.

I'll look into making this part build properly.

Ok, thank you so much!


Create dataset loader for UP2.0

Dataloader name: up2/up2.py
DataCatalogue: http://seacrowd.github.io/seacrowd-catalogue/card.html?up2

Dataset
up2

Description
Southeast Asian language subsets from Universal Propositions (UP) 2.0 dataset. Semantic role labeling (SRL) is a shallow semantic parsing task that identifies “who did what to whom when, where etc” for each predicate in a sentence. It provides an intermediate (shallow) level of a semantic representation that helps the map from syntactic parse structures to more fully-specified representations of meaning.

Subsets
ind, vie

Languages
ind, vie

Tasks
Semantic Role Labeling

License
Community Data License Agreement – Permissive, Version 1.0 (cdla-permissive-1.0)

Homepage
https://github.com/UniversalPropositions/UP_Indonesian-GSD, https://github.com/UniversalPropositions/UP_Vietnamese-VTB

HF URL
-

Paper URL
https://aclanthology.org/2022.lrec-1.181.pdf

#self-assign

@SamuelCahyawijaya @holylovenia Hi, I have some doubts here:

There is no Tasks.SEMANTIC_ROLE_LABELING, shall I make it as a sequential labeling schema (token-to-label)?
It is necessary to merge with UD to get the token, but it seems the original tools for merging requires additional library. Shall I use try-catch or is it better to re-implement the merging with UD, i.e. ID to sequence token mapping only?

For the time being, I implemented this as source-only.
Please advice when possible.
@SamuelCahyawijaya @holylovenia

@SamuelCahyawijaya @holylovenia Hi, I have some doubts here:

There is no Tasks.SEMANTIC_ROLE_LABELING, shall I make it as a sequential labeling schema (token-to-label)?
Does anyone know where to get the whole set of roles?
It is necessary to merge with UD to get the token, but it seems the original tools for merging requires additional library. Shall I use try-catch or is it better to re-implement the merging with UD, i.e. mapping ID to get only the sequence of token?

Hi @fhudi, sorry for the late response.

We can do a source-only schema for this dataloader. What do you mean by "the whole set of roles"?
Have you taken a look at common_parser.py and if it can help or not? If it's insufficient, we can use try-except to import the additional library.

Thanks @holylovenia  for the reply.

We can do a source-only schema for this dataloader. What do you mean by "the whole set of roles"?
Have you taken a look at common_parser.py and if it can help or not? If it's insufficient, we can use try-except to import the additional library.

The semantic roles (column 11 of UP).

Yeah, I wrote that parser. I do believe the common_parser.py suffices.
The reason I highlighted this is due to not following the steps from original UP dataset reconstruction.

Tag: @ijindal
Could you please clarify these 2 points?

@fhudi
The whole set of roles in UP means all EN propbank rolesets. Be careful though all the roleset are consistent with V3.0 of EN propbank. The current labeling schema may not work with the current version of EN propbank which is v3.4.

Yes, But the steps mentioned are specific to UP2.0 datasets not for semantic role labeling in general.


Walk down member expressions when resolving class extensions

Fixes #324

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Could you please rebase?

Sure thing

ping :)

there seem to be a lot of unrelated changes

It is because I rebased instead of merging, which is, I believe, what you wanted me to do.


chore(card): add a11y demonstration and social post like card

Signed-off-by: Bogdan Bogdanov<EMAIL_ADDRESS>PR Checklist
PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

#5563


Updating AWS.pidx, README and Changelog with Amazon cloudFront Url.

AWS is updating the TLS configuration for all AWS API endpoints to a minimum of version TLS 1.2. To avoid potential disruption for users still accessing the CMSIS packs stored Amazon S3 bucket using TLS 1.0 or 1.1, moving forward all of the CMSIS packs stored in S3 bucket will be accessed via Amazon CloudFront.

Hi, my name is Joachim Krech and I am working for Arm and I am part of the team overlooking the CMSIS-Pack public index (www.keil.com/pack/index.pidx).
Could you please check whether you have been following the steps for moving packs to a new url documented here: https://open-cmsis-pack.github.io/Open-CMSIS-Pack-Spec/main/html/createPackPublish.html#cp_PackRehosting
a) you have updated the pidx file content, but not the <timestamp>
b) if there is no updated new pack version, the package description file information will not be "reimported" and a changed <url> is not making its way to the user's pack description cache.
c) make sure that the pdsc file stored at the update <url> also contains the new location and all pack versions listed in the <releases> are also moved to the new <url>.
Thanks a lot for maintaining the AWS CMSIS-Packs.
~ Joachim


Fixed indentation in !embedhelp

Makes more sense to me to make the "MyNew" in the !embedhelp name a template

Thanks :)


Right prompt username color when root

Is it possible to change the color of the username display when it's root ?
Instead of adding text next to the username like tmux_conf_theme_root.
Maybe change the behavior of tmux_conf_theme_root_fg/bg or create other variables similar to this ?

Hello @Kidlike,
Currently it's not possible. But I'll figure out a way to do so.

Hey @Kidlike 👋
I still don't know how to generalize it, but I gave it 5 minutes today 🎁
Here's what you can do in your ~/.tmux.conf.local copy:
tmux_conf_theme_status_right='#{prefix}#{pairing}#{synchronized} #{?battery_status, #{battery_status},}#{?battery_vbar, #{battery_vbar},}#{?battery_percentage, #{battery_percentage},} , %R , %d %b | #{?#(cut -c3- ~/.tmux.conf | sh -s _root #{pane_tty} #D),#[fg=#ffff00]#[bold]#[blink],}#{username}#[inherit] | #{hostname_ssh} '

#{?#(cut -c3- ~/.tmux.conf | sh -s _root #{pane_tty} #D),#[fg=#ffff00]#[bold]#[blink],}#{username}#[inherit] will make the username bold, yellow and blinking when root.
Please note you can't use #[fg=#ffff00,bold,blink] as my parser is not robust enough 🤷♂
Hope that helps!

Changed the line, and now I have a blinking red "root" on a yellow background, while the hostname is white on green :
`....#[fg=#d70000]#[bold]#[blink]#[bg=##ffff00],}#{username}#[inherit] | #[fg=#e4e4e4]#{hostname}'
Next step is howto make the username white, while keeping 'root' blinking red.

I think this is a great idea, and is also related to #189

Closing. The solution in #321 is more elegant.


Readme bad rendering with dark theme

I suppose this is linked to dark theme but redering is almost not readable.

thanks for the hint, never tried it with dark mode, I'll update the png graphics to have white instead of transparent background.

updated. for other repos (e.g. word beam search) I still have to do the changes.


Collapse ecmascript.ts container.

This drastically improves the ability of TypeScript to infer types of the functions that were previously within the container.

Phew! What a slog - thank you both for bearing with me on this.
I've reverted some of the changes I made to treat dayLengthNs as a BigInt - it's now treated as a number (though I suspect this will need to be revisited as I'm integrating JSBI... along with other locations where the implicit conversion of big-integer's BigInteger to Number is happening via valueOf (as this doesn't happen with JSBI, fortunately).
What's left should mostly be mechanical changes (removal of ES., de-indentation, line-wrapping), and some small type adjustments to allow methods to be called without their optional params (implicit any isn't the same as ?: any).
I'll be following up with PRs to swap to using JSBI and to add types to ecmascript.ts, and I'll definitely be circling back to the conversations here for hints - I simply didn't want to end up "hiding" those changes in such a larger otherwise mechanical PR like this one.


[type:feat]Rule and MetaData module adapts to namespace transformation

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

#5623

pls add sql to support ocean bean

pls add sql to support ocean bean, or add this sql after the feature completed.

ok


Split up multiclass networks

Split network architectures in artifact_type.py, models.py, Densnet.py into separate classes/files and put in appropriate folders

done with a1303a089266f173f3e5822ae2d5f48df6187574


Rename config.yml to settings.yml

The GitHub App formerly known as "Configurer" has been renamed to Settings in https://github.com/probot/settings/pull/36. Along with that, the app now looks for .github/settings.yml instead of .github/config.yml.
You should have received an email with the subject "Settings is requesting updated permissions". Click the link in that email to review and accept the updated permissions before merging this pull request.
❤ & 🤖

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines           5      5
=====================================
  Hits            5      5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f0763...9c73353. Read the comment docs.


Example script doesn't seem to be working.

I'm just following the instructions found in the README, and I was able to successfully run the scripts, and I get two output files, vocals.wav and accompaniment.wav, but both the files sound exactly the same as the original. I am not hearing any difference between the three.

INFO:tensorflow:Using config: {'_model_dir': 'pretrained_models/2stems', '_tf_random_seed': None, '_save_summary_steps': 100, '_save_checkpoints_steps': None, '_save_checkpoints_secs': 600, '_session_config': gpu_options {
  per_process_gpu_memory_fraction: 0.7
}
, '_keep_checkpoint_max': 5, '_keep_checkpoint_every_n_hours': 10000, '_log_step_count_steps': 100, '_train_distribute': None, '_device_fn': None, '_protocol': None, '_eval_distribute': None, '_experimental_distribute': None, '_experimental_max_worker_delay_secs': None, '_service': None, '_cluster_spec': <tensorflow.python.training.server_lib.ClusterSpec object at 0x13a157eb8>, '_task_type': 'worker', '_task_id': 0, '_global_id_in_cluster': 0, '_master': '', '_evaluation_master': '', '_is_chief': True, '_num_ps_replicas': 0, '_num_worker_replicas': 1}
INFO:tensorflow:Could not find trained model in model_dir: pretrained_models/2stems, running initialization to predict.
INFO:tensorflow:Calling model_fn.
WARNING:tensorflow:From /anaconda3/envs/spleeter-cpu/lib/python3.7/site-packages/spleeter/model/functions/unet.py:29: The name tf.keras.initializers.he_uniform is deprecated. Please use tf.compat.v1.keras.initializers.he_uniform instead.

INFO:tensorflow:Apply unet for vocals_spectrogram
INFO:tensorflow:Apply unet for accompaniment_spectrogram
INFO:tensorflow:Done calling model_fn.
WARNING:tensorflow:From /anaconda3/envs/spleeter-cpu/lib/python3.7/site-packages/tensorflow/python/ops/array_ops.py:1354: add_dispatch_support.<locals>.wrapper (from tensorflow.python.ops.array_ops) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.where in 2.0, which has the same broadcast rule as np.where
INFO:tensorflow:Graph was finalized.
INFO:tensorflow:Running local_init_op.
INFO:tensorflow:Done running local_init_op.
WARNING:tensorflow:The dtype of the watched tensor must be floating (e.g. tf.float32), got tf.string
WARNING:tensorflow:The dtype of the watched tensor must be floating (e.g. tf.float32), got tf.int32
WARNING:tensorflow:The dtype of the watched tensor must be floating (e.g. tf.float32), got tf.string
INFO:tensorflow:Loading audio b'spleeter/audio_example.mp3' from 0.0 to 600.0
INFO:tensorflow:File output/audio_example/vocals.wav written
INFO:tensorflow:File output/audio_example/accompaniment.wav written

I'm running on a mac with Conda.

Log indicates that some error occurs while looking for model. Those models are downloaded from Github automatically when not found. Sound like a lack of error handling here when downloading such model, did you retry since ?

I have the same issue that got 2 same track as original one. both GPU/CPU mode tried.GPU is NVidia 1060. And tried CPU mode on other computer(as no NVidia GPU), same issue. Suppose all components would be downloaded automatic, any step might be missing?
I downloaded \ installed GIT \ ANACONDA and ran below commands.
git clone https://github.com/Deezer/spleeter
conda env create -f spleeter/conda/spleeter-cpu.yaml
conda activate spleeter-cpu
spleeter separate -i spleeter/audio_example.mp3 -p spleeter:2stems -o output
Got same as above error
INFO:tensorflow:Could not find trained model in model_dir: pretrained_models/2stems, running initialization to predict.
INFO:tensorflow:Calling model_fn.
Also asked my friend to try on other location, same result.

Any thing we could do?

I'm just following the instructions found in the README, and I was able to successfully run the scripts, and I get two output files, vocals.wav and accompaniment.wav, but both the files sound exactly the same as the original. I am not hearing any difference between the three.

INFO:tensorflow:Using config: {'_model_dir': 'pretrained_models/2stems', '_tf_random_seed': None, '_save_summary_steps': 100, '_save_checkpoints_steps': None, '_save_checkpoints_secs': 600, '_session_config': gpu_options {
  per_process_gpu_memory_fraction: 0.7
}
, '_keep_checkpoint_max': 5, '_keep_checkpoint_every_n_hours': 10000, '_log_step_count_steps': 100, '_train_distribute': None, '_device_fn': None, '_protocol': None, '_eval_distribute': None, '_experimental_distribute': None, '_experimental_max_worker_delay_secs': None, '_service': None, '_cluster_spec': <tensorflow.python.training.server_lib.ClusterSpec object at 0x13a157eb8>, '_task_type': 'worker', '_task_id': 0, '_global_id_in_cluster': 0, '_master': '', '_evaluation_master': '', '_is_chief': True, '_num_ps_replicas': 0, '_num_worker_replicas': 1}
INFO:tensorflow:Could not find trained model in model_dir: pretrained_models/2stems, running initialization to predict.
INFO:tensorflow:Calling model_fn.
WARNING:tensorflow:From /anaconda3/envs/spleeter-cpu/lib/python3.7/site-packages/spleeter/model/functions/unet.py:29: The name tf.keras.initializers.he_uniform is deprecated. Please use tf.compat.v1.keras.initializers.he_uniform instead.

INFO:tensorflow:Apply unet for vocals_spectrogram
INFO:tensorflow:Apply unet for accompaniment_spectrogram
INFO:tensorflow:Done calling model_fn.
WARNING:tensorflow:From /anaconda3/envs/spleeter-cpu/lib/python3.7/site-packages/tensorflow/python/ops/array_ops.py:1354: add_dispatch_support.<locals>.wrapper (from tensorflow.python.ops.array_ops) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.where in 2.0, which has the same broadcast rule as np.where
INFO:tensorflow:Graph was finalized.
INFO:tensorflow:Running local_init_op.
INFO:tensorflow:Done running local_init_op.
WARNING:tensorflow:The dtype of the watched tensor must be floating (e.g. tf.float32), got tf.string
WARNING:tensorflow:The dtype of the watched tensor must be floating (e.g. tf.float32), got tf.int32
WARNING:tensorflow:The dtype of the watched tensor must be floating (e.g. tf.float32), got tf.string
INFO:tensorflow:Loading audio b'spleeter/audio_example.mp3' from 0.0 to 600.0
INFO:tensorflow:File output/audio_example/vocals.wav written
INFO:tensorflow:File output/audio_example/accompaniment.wav written

I'm running on a mac with Conda.

Hi Robbert, I fixed the problem by manually downloaded the trained module for 2istems with below URL link
https://github.com/deezer/spleeter/releases/download/v1.4.0/2stems.tar.gz
Just put it to C:\Users\username\pretrained_models\2stems
Then run the script again, you cld find 2 tracks with different layout.
Nice day.
Alan


num workers for Dataloaders

If !os=="linux", num_workers always == 0. Fix for all data loaders, e.g. image laoders

@Cdk29 There could be potential issues with num_workers in different data loaders. They all need to be set to 0 if the os is windows or mac. Below is how I do that:
https://github.com/henry090/fastai/blob/a34f08cfa667c179f8b5cd6554d4396cca704942/R/vision_core.R#L551-L561
If you have time and would like to contribute more, that would be great/helpful! =)

Hehe. So basically add this lines of codes inside the other dataloaders ?

Actually, yes. Because without this, the tests for mac and windows hang or fail. See test here: https://github.com/henry090/fastai/blob/master/tests/testthat/test-nn_module.R
In this part, the Tfdml contains above-mentioned part. Therefore, tests are successful. https://github.com/henry090/fastai/blob/a79a21930432c683d7d28eefd6b0a6050d11bc45/tests/testthat/test-nn_module.R#L31-L32

Okay. Today I will be a bit short for this, but in the next days I can do it.

Hi, I currently have time to fix the issues. If you haven't yet started working on this, I can take it.

@henry090 yes sorry, I did not got time to start working on this. You can take it.
I will do a PR later today but for something related for fine tuning.

Done


Javalin scalability

how javalin manage asynchronous scalability for clients (connections, requests) and thers any max limit for clients connections also requests

Javalin runs on top of Jetty, you can ready their docs for handling high load: https://www.eclipse.org/jetty/documentation/current/high-load.html


VPC CNI Policy is missing CloudWatch Logs permissions if you enable Network Policy logs

Description
Submodule: iam-role-for-service-accounts-eks
The VPC CNI Policy in https://github.com/terraform-aws-modules/terraform-aws-iam/blob/v5.39.0/modules/iam-role-for-service-accounts-eks/policies.tf is missing some permissions when AWS VPC CNI Network Policy logs are enabled
When network policy is enabled on VPC CNI add-on, a second container is added to the aws-node pod for a node agent. This node agent can send the network policy logs to CloudWatch logs.
With the current configuration, aws-node is in a CrashLoopBackOff state because that container does not have the right permissions related to CloudWatch logs.

[X] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version: 5.39.0

Terraform version: 1.8.2

Provider version(s): 5.48.0

Reproduction Code

I am creating the EKS cluster by using the AWS EKS Terraform module 20.8.5. When setting up the cluster addons I am enabling the Network Policy and the Network Policy logs as we can see below:
module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "20.8.5"

  cluster_addons = {
    coredns = {
      addon_version = var.cluster_addons_versions.coredns
    }
    kube-proxy = { # Upgrade of this component usually makes sense after the control plane upgrade
      addon_version = var.cluster_addons_versions.kube_proxy
    }
    vpc-cni = {
      before_compute           = true
      addon_version            = var.cluster_addons_versions.vpc_cni
      service_account_role_arn = module.vpc_cni_irsa.iam_role_arn

      configuration_values = jsonencode({
        "enableNetworkPolicy" : "true",   <==== here
        "nodeAgent" : {                  <===== here
          "enablePolicyEventLogs" : "true",
          "enableCloudWatchLogs" : "true"
        }
      })
    }

The IRSA role is created by using the submodule iam-role-for-service-accounts-eks in this repo.
module "vpc_cni_irsa" {
  source  = "terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks"
  version = "5.39.0"

  role_name             = "${local.resource_prefix}-vpc-cni-irsa-role"
  attach_vpc_cni_policy = true             < ==== Attaching
  vpc_cni_enable_ipv4   = true

  oidc_providers = {
    main = {
      provider_arn               = module.eks.oidc_provider_arn
      namespace_service_accounts = var.irsa_service_accounts.namespace_service_account_vpc_cni
    }
  }
}

Expected behavior
It would be nice to add those permissions to the policy file.
Based on https://docs.aws.amazon.com/eks/latest/userguide/cni-network-policy.html#cni-network-policy-setup the following permissions should be added
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "VisualEditor0",
            "Effect": "Allow",
            "Action": [
                "logs:DescribeLogGroups",
                "logs:CreateLogGroup",
                "logs:CreateLogStream",
                "logs:PutLogEvents"
            ],
            "Resource": "*"
        }
    ]
}

Actual behavior
aws-node is in a CrashLoopBackOff state because that policy does not have the right permissions related to CloudWatch logs.

This issue has been resolved in version 5.42.0 :tada: