allow renaming directories on windows

closes https://github.com/jystic/unix-compat/issues/30

👍 looks good, will bump the version to 0.5 for this as the behaviour has changed, hopefully that's cool


[tests-only] [full-ci] Trigger CI

I am seeing webUILogin/openidLogin.feature:38 failing unexpectedly in another PR.
See if it is an existing failure in master.

I am seeing webUILogin/openidLogin.feature:38 failing unexpectedly in another PR.
See if it is an existing failure in master.

Please see https://github.com/owncloud/web/commit/4a4c9db583dcd33fa14e1f99ac3a19ff3447d293

https://drone.owncloud.com/owncloud/ocis/6203/44/6
runsh: Total unexpected failed scenarios throughout the test run:
webUILogin/openidLogin.feature:38

This is an existing problem in master. Somehow we merged something into owncloud/ocis that broke a web test scenario.

I raised issue #2350 to look into this.

https://drone.owncloud.com/owncloud/ocis/6203/44/6
runsh: Total unexpected failed scenarios throughout the test run:
webUILogin/openidLogin.feature:38
runsh: There were no unexpected success.

This confirms that there is a current problem with this web test in OCIS.


Generated File missing end of Expression

When generating my files I’m getting this error:
▸    ';' expected. (176:8)
▸    174 | export type ShortCodeTxJarsOrderByInput =
▸    175 |
▸    > 176 | export type UserOrderByInput =   'id_ASC' |
▸    |        ^

So it looks like ShortCodeTxJarsOrderByInput is not getting assigned a variable. Here is an abbreviated schema:
type ShortCodeTx {
  id: ID! @id
  jars: [Jar!]! @relation(link: TABLE, name: "ShortCodeTxJars")
  updatedAt: DateTime! @updatedAt
  createdAt: DateTime! @createdAt
}

type ShortCodeTxJars @relationTable {
  jar: Jar!
  shortCodeTx: ShortCodeTx!
}

type Jar {
  id: ID! @id
  transactions: [ShortCodeTx!]! @relation(name: "ShortCodeTxJars")
  updatedAt: DateTime! @updatedAt
  createdAt: DateTime! @createdAt
}

Referenced from this post on the forum.

This bug has already been reported. https://github.com/prisma/prisma/issues/4424
This has been fixed in 1.33 so please try that version.
I am no longer able to reproduce this.

Actually I am struggling with the same error nowadays . As I can see this bug should be fixed in version 1.33 but I have used 1.34.1 and the error is still happened.
SyntaxError: ';' expected. (142:8)
  140 | export type SheetPermissionOrderByInput =
  141 |
> 142 | export type WorkbookOrderByInput =   'workbook_id_ASC' |
      |        ^
  143 |   'workbook_id_DESC' |
  144 |   'created_ASC' |
  145 |   'created_DESC' |

Prisma schema
type Sheet @db(name: "sheet") {
  sheet_id: Int! @id
  active: Boolean
  cell: [Cell]
  created: DateTime
  isSynchronized: Boolean @db(name: "is_synchronized")
  mappedSheetId: Int @db(name: "mapped_sheet_id")
  name: String
  sheetPermission: [SheetPermission]
  synchronizationType: SynchronizationType! @db(name: "synchronization_type_id")
  workbook: Workbook! @db(name: "workbook_id")
}

type SheetPermission @db(name: "sheet_permission") @relationTable {
  sheet: Sheet! @db(name: "sheet_id")
  user: User! @db(name: "user_id")
}

type User @db(name: "user") {
  user_id: Int! @id
  created: DateTime
  name: String
  sheetPermission: [SheetPermission]
  workbook: [Workbook]
}


Fix for tokens not getting updated correctly.

Fixes #1675
Fixed with a small refactor in TokensService:
Remove the separate list of tokens in the TokensService, which controlled updates. This list could get out of sync with the app's known tokens in the database.
The separate list was replaced with a call to fetch all the active tokens from the database; we then find the token with the highest update priority (taking into account if the token has value; is it on main chain or a test chain, when was it last updated etc). This token is then marked as updated so it won't get picked again and the app goes on to attempt a balance update.
Now the TokensService update operates entirely from the database; this way we don't have to keep a separate list in sync with a master list; less maintenance, less to go wrong.

Maybe raise a new issue with (if possible) a repro case.
Opening etherscan in the phone's default browser is the current behaviour.
Neither of these points are related to this PR.

Also fixes #1687


Nuget Package missing

Hi, I can't find the nuget package mentioned in this page - it's not showing up in nuget package manager even with the prerelease option checked.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eb09de11-6321-20b6-1632-21d4b4568536
Version Independent ID: b5a3bdc7-185c-27ad-79d8-ea3b4b4a5dfc
Content: Feedback loop - Personalizer - Azure Cognitive Services
Content Source: articles/cognitive-services/personalizer/csharp-quickstart-commandline-feedback-loop.md
Service: cognitive-services
Sub-service: personalizer
GitHub Login: @edjez
Microsoft Alias: edjez

@dmeineck Thanks for the feedback. We are investigating the issue and will update you shortly.

Hi, The nuget package not showing in search, when I try to search in the Microsoft.Azure.CognitiveServices.Personalizer in Manage NuGet Packages for Solution.

Same issue - doesn't exist on nuget.org

@jjgriff93 Thanks, I couldn't find Microsoft.Azure.CognitiveServices.Personalizer in nuget.org. Could you please point to the link of the nuget package.

Hi @vrishni I'm having the same problem, doesn't seem to exist - I've tried searching for Microsoft.Azure.CognitiveServices.Personalizer and Microsoft.Azure.CognitiveServices.Personalization on Nuget.org, both don't seem to be there, hence why it's not appearing in VS either

Thank you everyone for reporting this issue. The package is currently on a GitHub repo. You can download the whole repo as a zip file which will get you the samples and the package. Please know you need to direct Visual Studio to look for NuGet packages in the new, local location. #in-progress

I also have this issue. It is not yet a NuGet Package.

@dmeineck @vrishni @jjgriff93 @Axxeption NuGet package is available. Thank you for your patience.

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

I was having this problem too.  When searching, tick the checkbox that says, "Include prerelease".  That worked for me.

@StrongBishop - thanks for adding this. Great tip.

Doh!
Thanks @StrongBishop

#please-close

The right command for this is dotnet add package Microsoft.Azure.CognitiveServices.Personalizer --version 0.8.0-preview
Please, update the doc.
Cheers,


[Bug]: Console.log printing which is of no use to user

What happened?
I found a BUG 🐞
i can work on this please assign to me

Add screenshots
Add screenshots

What browsers are you seeing the problem on?
Chrome
Code of Conduct

[X] I agree to follow this project's Code of Conduct

assign this to me I will solve this ASAP!

I think you opened this issue on the wrong project. The QuickLearn repository is here: https://github.com/DSC-JSS-NOIDA/QuickLearn

Really sorry for that there are so many tabs open i confused it was not intentional


[SDPA-5027] Remove column setting for navigation_card and update component breakpoint

Motivation and Context

JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-5027
Changed

Removed column setting for navigation_card
Updated component width breakpoint settings
Added content max-width to card content
Updated storybook card date to use static for chromatic ui testing to pass

Screenshots
https://app.pr-910.ripple.sdp1.sdp.vic.gov.au/
https://storybook.pr-910.ripple.sdp1.sdp.vic.gov.au

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

[x] I've added relevant changes to the documentation.
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] My change requires a template update for create-ripple-app.
[ ] I have added template update script for next release.

@rubyllamadora I think we will need some dev guide for how to add a story for new component.
It can be some simple points, what we need to do. How do you think?
Somewhere I think In https://github.com/dpc-sdp/ripple/blob/develop/CONTRIBUTING.md#storybook-testing. Not in this PR, need another task to do it.

@tim-yao yes we can add basic example also like https://storybook.js.org/docs/react/writing-docs/mdx#basic-example


Change API header titles and info

The API documentation now includes the following information:

title of the page includes the functions that are documented in each page
the header file (along with its link) needed to be included is listed under the page title

For example, instead of the title:
hpx/parallel/algorithms/adjacent_find.hpp
The new title will be:
hpx::adjacent_find
followed by the include information:
Defined in header hpx/algorithm.hpp

@dimitraka could you please resolve the conflicts intorduced by a recent merge to HPX master?

@dimitraka Would you mind having a look at the clang-format issues reported?


Add screencaps for filing new issues

Adding two images for internal use

@tdurnford will take a look at the failing test -- it is unrelated to this PR :)


Code Gardening

A few things that I've been collecting

Fixing up documentation comments
Adding/improving logging

Codecov Report

Merging #403 (cc842b0) into master (819580e) will increase coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   63.04%   63.06%   +0.02%
==========================================
  Files         144      144
  Lines        9838     9841       +3
==========================================
+ Hits         6202     6206       +4
+ Misses       3081     3080       -1
  Partials      555      555

Impacted Files
Coverage Δ

hack/generator/pkg/astbuilder/literals.go
76.92% <ø> (ø)

.../astmodel/armconversion/arm_conversion_function.go
75.75% <ø> (ø)

.../generator/pkg/astmodel/code_generation_context.go
51.06% <ø> (ø)

...nerator/pkg/astmodel/external_package_reference.go
100.00% <ø> (ø)

hack/generator/pkg/astmodel/flagged_type.go
94.23% <ø> (ø)

...generator/pkg/astmodel/interface_implementation.go
50.00% <ø> (ø)

.../generator/pkg/astmodel/local_package_reference.go
100.00% <ø> (ø)

...rator/pkg/astmodel/one_of_json_marshal_function.go
92.72% <ø> (ø)

hack/generator/pkg/astmodel/package_import.go
85.00% <ø> (ø)

...ck/generator/pkg/astmodel/package_reference_set.go
100.00% <ø> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819580e...cc842b0. Read the comment docs.


hidinput exception in Kivy. No such devices

I'm using a Kivy Python framework in my project and USB touch panel for user interraction and I faced with problem. When my touch panel has lost connection (for a second) and then reconnect again the application get an exception HidinputException in hidinput.py file.
Here I show my stacktrace:
Exception in thread Thread-7:
 Traceback (most recent call last):
   File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
     self.run()
   File "/usr/lib/python2.7/threading.py", line 763, in run
     self.__target(*self.__args, **self.__kwargs)
   File "/usr/local/lib/python2.7/dist-packages/kivy/input/providers/hidinput.py", line 687, in _thread_run
     data = fd.read(struct_input_event_sz)
 IOError: [Errno 19] No such devices

Seems good to me. It's not provider's problem that your device disconnected. If it's only Thread exception, you can surely trace the line of code that checks for devices and when it occurs, run it manually (from your file, not from provider).

Sorry, but I'm not sure that I understand you correctly. Could you tell me what exactly  should I do ?

Line 687 in provider throws an error. If it's only when the device disconnects (which probably is), the import from provider a function that works with that line and call it manually if such an error happens. Chech how to handle thread errors here. Hmm... probably a welcome edit in provider could be that the thread would return some value for user to check.

Hi,
I have same problem with my touch screen.
I am using 10.1" touch screen from WaveShare.
http://www.waveshare.com/wiki/10.1inch_HDMI_LCD_(B)_(with_case)
Though I am using external power source for the touch screen, same errors are occasionally occurs and it is suffering me continuously.
After error is occurred, screen is locked up and does not accept any touch input.
Is there any way to recover the connection in the hidinput.py?
Do I need to modify it?
Thanks.

I also face this problem when running a Raspberry Pi with a Kivy application as a display.  Occasionally, I'd like to plug in a USB mouse/keyboard in order to tweak the application.  Under these cases, I am forced to restart the entire Kivy Application, just so that I can use keyboard/mouse.
Strange thing is that Kivy itself is obviously reconnecting to the keyboard (despite the IOError crash above).  I know that because I'm still able to CTRL-C my way out of the Kivy Application.

I have the same problem whenever a usb keyboard (or any other devices) is unplugged from the Raspberry while a kivy app is running. In that case, OSError: [Errno 19] No such device is prompted in the log file and the whole kivy app becomes extremely laggy. If the usb device is reconnected I'm able to write characters but the application remains laggy until the app is restarted.

Closed by #5206

Same issue on a RaspberryPi if I turn off the USB-bus for a connected HID.
Kivy "out of the box" doesn't properly handle system USB dis-/re-connections taking place while the app is running.
Everything works fine if Kivy runs under X/windows-system (since X then handles the HID and their dis-/re-connections, I expect), but it doesn't work for system-devices enabled in the .kivy/config.ini.
I guess this is why the issue has been overlooked / neglected: Everything works fine when running under X, and even if not under X; everything is fine as long as you don't disconnect / reconnect a USB-device while the app is running.
However, since I want to be able to disconnect and reconnect a USB HID while runing my Kivy-app on a stripped down raspbian without X, I'm out of luck...
The important issue is the fact that input from a device will not reach the app if the device is reconnected after the app has been started - So far I have not been able to find any solution (when not running X).


large-file-upload: always print elapsed time when -e arg is passed

Prior to this change, the elapsed time would only be printed when the -d (debug) option is passed. This change makes it so that the elapsed time will always be printed regardless of the d option
Tested this by launching application in debug mode and in normal mode and saw the elapsed time in both cases when -e option was passed.

Looks good. Ready to merge.


DcelFactory is using a coincidentEdgeComparer of usorted IComparer

Dear All,
The DcelFactory is using a coincidentEdgeComparer to sort the OriginalSegment's in "SetHalfEdgesValues". This is ok, if PointA of the original segment is equal to "vertex". But it might result in a invalid sorting of the half-edges if PointB is equal to "vertex".
It would be good to check whether a "dummy segment" with inverted points should be used if vertex equals PointB:
var getEdgeFrom = (TEdge segment, TPoint origin) =>
    {
        if (segment.PointA.Equals(origin))
            return segment;
        else
            return new SegmentDummy(segment.PointB, segment.PointA);
    };

    var verticesHalfEdgeLists = verticesDictionary.Values.Select(vertex => vertex.HalfEdges.Cast<InternalHalfEdge>().OrderBy(he => getEdgeFrom(he.OriginalSegment, vertex.OriginalPoint), coincidentEdgeComparer).ToList());

With this modifications, one of the unit tests (complex shape) must be adapted.
Kind regards

First of all, congratulations 🎊  first issue, welcome 😄. Someone else is using this library, awesome!
Second, I'm sorry but I'm not sure I understand exactly the issue you're facing. Could you maybe give a code sample (or a unit test) where you have the issue with the current behavior?

Indeed, that's awesome!
I think I understand the issue, and I'll have a look as soon as I get back
to work!
As Xavier said, it would be great if you could provide a minimal test case
that fails and that passes with your fix.
On Wed, 16 Mar 2022, 16:59 Xavier Hahn, @.***> wrote:

First of all, congratulations 🎊 first issue, welcome 😄. Someone else is
using this library, awesome!
Second, I'm sorry but I'm not sure I understand exactly the issue you're
facing. Could you maybe give a code sample (or a unit test) where you have
the issue with the current behavior?
—
Reply to this email directly, view it on GitHub
https://github.com/Gimly/DoublyConnectedEdgeList/issues/6#issuecomment-1069290463,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIMJJ722XA4VPLGDDFNHU3VAIANHANCNFSM5Q27CQ5Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Dear all,
Thank you very much for the positive feedback. I would like to try to narrow down the issue better.
Please let me try to describe the effect:
In lines 83...91 in "DcelFactory.cs" a dictionary is built. For each vertex (keys), a sorted list of edges adjacent to this vertex is generated (values). These edges should be sorted in a star-shaped order. This star-shaped sorting only works reliably if the starting point of the edges equals the respective vertex. At the moment, however, the original edge is always used and it is not checked whether its PointA also equals the vertex.
With the unit test I need your help (I can not compile and test code here at the moment - this one is freehand):
The easiest thing should be to extend the test "Given_a_right_triangle_Should_return_valid_dcel". Simply add an outward facing edge to the triangle. The half-edge A->B (belonging to the outer surface) should have the half-edge "B-->D" as its "next". With the current code, this test should fail due to the fach segmentA a is defined A-->B (and not the other way around). Could you please verify this?
// Arrange
var a = new TestPoint(-1, 2);
var b = new TestPoint(4, 3);
var c = new TestPoint(5, -2);
var d = new TestPoint(4, 4);

var segmentA = new TestSegment(a, b);
var segmentB = new TestSegment(b, c);
var segmentC = new TestSegment(c, a);
var segmentD = new TestSegment(b, d);

var segments = new[] {segmentA, segmentB, segmentC, segmentD};

var dcelFactory = new DcelFactory<TestSegment, TestPoint>(new TestSegmentComparer());

// Act
var result = dcelFactory.FromShape(segments);

// check the next of half edge AB; it should be BD
var halfEdgeAB = result.FindHalfEdge(a, b);
var halfEdgeBD = result.FindHalfEdge(b, d);
halfEdgeAB.[Next].Should().Be(halfEdgeBD);

Please let me point out again that some of the existing unit tests should fail after fixing this issue and need to be adjusted.
Kind regrads

Hello,
Just to let you know that indeed, I was able to reproduce your issue (thanks for the code).
In your unit test the result is indeed BC and not BD, I have it in the branch issue/6/gimly/fix_coincidentEdgeComparrer_issue.
A bug reproduced is a bug half fixed 😄, I'll try to make that work correctly.

@thomashilke what do you think, is this an issue with the TestComparer, or is that an issue with the code itself?

@Gimly I'll take a moment today to have a look.

@grunerjmeier I know understand what you meant. In my opinion it is the EdgeComparer's responsibility to check which of all four extremities is common to both edges, and compute the order accordingly. It is guaranteed by the DcelFactory that the EdgeComparer will only be called with paires of Edge that have an extremity in common.
The other difficulty with your fix proposal is that there is no way to implement a DummySegment generically. One motivation for this implementation of the DCEL was to handle edges that are more exotic than plain line segments, such as arcs, elliptic arcs, splines, etc.
With these cases in mind, the order between two edges cannot be determined by the tangent direction, as these may very well be identical (think two circle arcs whose centers are aligned with the vertex), so curvature must be inspected. All this complexity should no be handled by the DcelFactory, and must be delegated to particular implementations of EdgeComparers.
However, it is clear that the current implementation of the TestEdgeComparer in the unit tests is not correct in that respect, and it is an easy fix.

Hi @thomashilke,
the fix I'm proposing is to replace the type of coincidentEdgeComparer from
IComparer<TEdge>
to
IComparer<IDcelEdge<TPoint>>.
By doing so you can provide an private "SegmentDummy", in case PointA and PointB of the original segment is in reverse order. This is what is shown here.

Thanks for the clarification. Now I get what you propose.
The check to determine which extremity is in common between two IEdge cannot be avoided. However, since only the knowledge of the extremity locations is required, it is true that it can be either performed by:

the DcelFactory, or
the IComparer<TEdge> injected by the client.

However, the downsides that I see with 1. is that

It require to break the current public API, and injecting an additional lambda or interface,
It require the client to implement a comparator for an interface other than his own TEdge, which may be a bit confusing,
The SegmentDummy will turns out to be in general clientEdge.Reverse() where clientEdge is of type TEdge. Since each edge will be mis-oriented at least once in the construction of the DCEL, it will lead to a boatload of temporary dummy segment allocations.

It is true that handling the orientation in the IComparer<TEdge>.Compare in 2. leads to a little bit of additional work, but I still feels that it is the correct way to do it. Due to the additional work, it may also be less performant. But careful benchmarking will be needed to discriminate the two approaches.


Disable auto creation of addresses prevents address & queue creation via the Operator

Describe the bug
Disable auto creation of addresses via the address settings prevents address & queue creation via the Operators CRD.
To Reproduce
Steps to reproduce the behavior:

Create an ActiveMQArtemis with the following addresssettings

apiVersion: broker.amq.io/v2alpha4
kind: ActiveMQArtemis
metadata:
  name: ex-aao
spec:
  deploymentPlan:
    size: 1
    image: quay.io/artemiscloud/activemq-artemis-broker-kubernetes:0.2.0
    persistenceEnabled: false
  addressSettings:
    addressSetting:
      - autoCreateAddresses: false
        match: '#'
    applyRule: merge_all

Try to create the following Address

apiVersion: broker.amq.io/v2alpha2
kind: ActiveMQArtemisAddress
metadata:
  name: ex-aaoaddress
spec:
  addressName: myAddress0
  queueName: myQueue0
  routingType: anycast

The address & queue doesn't get created.

Under the hood the creation fails with the following error
java.lang.IllegalStateException : AMQ229203: Address Does Not Exist: myAddress0

The error doesn't get logged because of wrong error handling - see https://github.com/artemiscloud/activemq-artemis-management/issues/3
The error message can be reproduced when trying to create the queue via the Jolokia / JMX Operation in the hawt.io console.
Platform (please complete the following information):

Operator Version: 0.18.0
ActiveMQ Artemis Image: quay.io/artemiscloud/activemq-artemis-broker-kubernetes:0.2.0

Expected behavior
The Operator should provide the possibility to create Addresses and Queues even though the auto creation (for consuming applications) is disabled. Therefore, it might be better to be able to define an Address and a Queue (which references an Address) in its own CRD instead of using the CRD 'ActiveMQArtemisAddress' for both of them (actually it's only for creating a Queue)
Additional context
The goal is to be able to disable all the auto creation features of ActiveMQ Artemis (Addresses & Queues) and explicitly define them via the operator.

yes it lacks such flexibility for the moment.

If you are using the latest release 0.20.0, you can first create the address by specifying only the address in the CR, then deploy another CR with queue/address in it.

@mhofstetter are you able to reproduce this issue using the latest version of the operator?

@brusdev seems to be fixed with the latest version. address & queue are getting created after applying the CR :+1:

@mhofstetter thanks for your feedback.


[ARCTIC-1083] support modifying log4j2.xml dynamically

Why are the changes needed?

fix #1083
Brief change log

add <Configuration monitorInterval="10"> to log4j2.xml

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before making a pull request

Documentation

Does this pull request introduces a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

monitorInterval="10" denotes reloading log4j2.xml every 10 seconds.


Feature/session replay

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1417 (6e3e93b) into session-replay-snapshots-release-branch (48c5281) will increase coverage by 0.11%.
The diff coverage is 95.15%.

@@                             Coverage Diff                             @@
##           session-replay-snapshots-release-branch    #1417      +/-   ##
===========================================================================
+ Coverage                                    83.56%   83.67%   +0.11%
===========================================================================
  Files                                          387      399      +12
  Lines                                        13539    13720     +181
  Branches                                      2185     2207      +22
===========================================================================
+ Hits                                         11313    11479     +166
- Misses                                        1554     1560       +6
- Partials                                       672      681       +9

Impacted Files
Coverage Δ

...sionreplay/material/MaskInputTabWireframeMapper.kt
0.00% <0.00%> (ø)

...nreplay/internal/recorder/mapper/CheckBoxMapper.kt
88.89% <ø> (ø)

...l/recorder/mapper/CheckableCompoundButtonMapper.kt
94.44% <ø> (ø)

.../internal/recorder/mapper/CheckedTextViewMapper.kt
93.33% <ø> (ø)

.../internal/recorder/mapper/MaskAllCheckBoxMapper.kt
83.33% <ø> (ø)

...al/recorder/mapper/MaskAllCheckedTextViewMapper.kt
90.00% <ø> (ø)

...ternal/recorder/mapper/MaskAllRadioButtonMapper.kt
92.31% <ø> (ø)

...play/internal/recorder/mapper/RadioButtonMapper.kt
94.44% <ø> (ø)

...nal/recorder/obfuscator/rules/TextValueResolver.kt
25.00% <25.00%> (ø)

...nternal/recorder/mapper/MaskInputTextViewMapper.kt
50.00% <50.00%> (ø)

... and 32 more

... and 1 file with indirect coverage changes


Grails added

Thanks, but that list has almost no content and haven't been updated in a year and a half.


transport (and other function in config) are broken

Looks like a big regression has been introduced by https://github.com/mowispace/react-native-logs/pulls?q=is%3Apr+is%3Aclosed
By doing a JSON.parse(JSON.stringify(config)) every function defined in the config is transformed into a null value.
const transport = [
  () => {
  },
  () => {
  },
];
JSON.parse(JSON.stringify(transport)) // output [null, null]

If you wanna do a deepmerge you'd probably better to use a lib such as https://www.npmjs.com/package/deepmerge-ts or write a custom function

This is causing the error ERROR  Error: [react-native-logs] ERROR: transport is not a function, js engine: hermes to be shown and logging is broken.
const defaultConfig = {
  levels: {
    debug: 0,
    info: 1,
    warn: 2,
    error: 3,
  },
  severity: __DEV__ ? "debug" : "error",
  transport: [
    consoleTransport,
    sentryTransport,
  ],
  transportOptions: {
    colors: {
      info: "blueBright",
      warn: "yellowBright",
      error: "redBright",
    },
    SENTRY: Sentry,
    errorLevels: ["fatal", "error", "warning"],
  },
  async: true,
  asyncFunc: InteractionManager.runAfterInteractions,
  dateFormat: "time",
  printLevel: true,
  printDate: true,
  fixedExtLvlLength: false,
  enabled: true,
};

The following gets us back to working:
npm install<EMAIL_ADDRESS>

Sorry, I hadn’t considered the functions. For now, let’s roll back and keep the old config merging system.
Fixed in v 5.2.2.


Distance sensor downward

This PR enables the use of a downward facing distance sensor for low flight altitudes. The local planner sees and treats the ground as an obstacle if it lies inside the field of view. This is a problem when flying low using obstacle avoidance or collision prevention. When using the obstacle avoidance the drone gets trapped, because even if it yaws, it will see ground in all directions. When using collision prevention, the forward movement is prevented at low altitudes. This is not a desired behavior.
The distance sensor input is read in and the pointcloud is cropped such that we are sure, the ground is not inside the FOV (except where there are steep slopes, but there we might want to prevent getting closer). There are a lot of hardcoded numbers. They come from the tuning (realsense noise, etc.). In the future we will aim at a more generic solution

@baumanta what's the state of this PR? Flight tests? In any case it needs rebasing on master

Yes, it is somewhat on hold. We had some terrible flight tests this week. I'm pretty sure it is unrelated to those changes but it is on hold until we can show clearly that this is not what broke the stuff

Tested and working on a single-Realsense frame.


Support for SECURITY INTEGRATION

Describe the solution you'd like
Support for for the SECURITY INTEGRATION resource
Additional context
https://docs.snowflake.com/en/sql-reference/sql/create-security-integration.html
There's only one per account, so we should specify that in the docs I think (same as the network_policy_attachment)

@LouisAmon There are different types of Security Integration. The SCIM type is already implemented. Is there a particular one that you require?

@ChrisIsidora I meant the SAML2 integration : it typically involves a lot of back and forth between two different services so it's a great use-case for IaC ;)

Agreed, SSO/SAML2 needs to be available in the terraform provider.

I think this issue can be closed with recent pull request

We are closing this issue as part of a cleanup described in announcement. If you believe that the issue is still valid in v0.89.0, please open a new ticket.


NAS-121523 / 23.10 / Remove process pool executor when gathering plugins data

Context
conf object is re-initialised in the process pool which results in various inconsistencies when executing plugins.
We could workaround it but after discussion with @yocalebo we decided to remove the process pool executor for now and re-visit this as required.

Jira URL: https://ixsystems.atlassian.net/browse/NAS-121523


Edit to categorical data section and the addition of box and whisker plots

Please let me know if this works and if you have suggestions for changes. Please don't change things without prior discussion.

Hello! Of course. Thanks for the pull request.
Just looking at what's committed here, I see three Notebooks added for chapter 8. I'm guessing these are/were intended for what's now chapter 9 (data visualization). Were these Notebooks added accidentally? Or are they perhaps intended to replace what's now in chapter 9? (There are of course also changes here to the files currently making up chapter 9.)
Beyond that, just looking over the other changes:

(Kind of trivial to mention but I also see the empty file .Rhistory added. I would think this is not needed for the repository and I can just ensure it's excluded.)

It's not hugely important but I see the addition of filters to ignore warnings (warnings.filterwarnings()). I would hope this isn't necessary for the textbook; though there's not great harm in it either. Of course if there's an ongoing issue relating to this I'd be happy to help with it.

Otherwise of course this looks great. I might hold off on testing it in the textbook just until I know which files are intended.

Hi Jesse,
Thanks for your reply and attention. The files for chapter 8 was a mistake on my end. Those can be deleted, as we only need the place holder file for that.
Where was the .Rhistory file added? I didn't intend to add that as well and it can be deleted.
I added a warnings command just for the Categorical data notebook. The other notebooks should be fine I believe.

Hi Jesse,
Thanks for your reply and attention. The files for chapter 8 was a mistake on my end. Those can be deleted, as we only need the place holder file for that.
Where was the .Rhistory file added? I didn't intend to add that as well and it can be deleted.
I added a warnings command just for the Categorical data notebook. The other notebooks should be fine I believe.

OK – (as you can see above) – I've committed two changesets, one to remove the .Rhistory file and ignore these in the future, and one to remove those notebooks that were added to the chapter 8 directory.
For the moment you can review these changesets in this pull request.
And if you like you can review the end-result changes here as well.
These data visualization notebooks appear nicely compatible with the textbook and build fine. Looks good to me.
I'm curious that we need to filter warnings at all; but, that's fine, certainly there and for now.
I can incorporate this if it looks good to you as well.

OK – (as you can see above) – I've committed two changesets, one to remove the .Rhistory file and ignore these in the future, and one to remove those notebooks that were added to the chapter 8 directory.
For the moment you can review these changesets in this pull request.
And if you like you can review the end-result changes here as well.
These data visualization notebooks appear nicely compatible with the textbook and build fine. Looks good to me.
I'm curious that we need to filter warnings at all; but, that's fine, certainly there and for now.
I can incorporate this if it looks good to you as well.

Looks good to me, thanks!

OK. This work is merged and published: https://ds1.datascience.uchicago.edu/09/data-visualization.html

FYI: Since this was pulled from your fork's main branch (master), you might just want to re-sync that branch with this repository's before beginning anything new. No need to worry about it but it might help in the future. I've outlined this for example here. (Otherwise it can help just to do work in separate branches.) Thanks.


[DROID] Implemented Popups, fixed AppBuilder

Codecov Report

Merging #883 into master will increase coverage by 0.01%.

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
+ Coverage   61.51%   61.52%   +0.01%
==========================================
  Files         530      530
  Lines       20086    20089       +3
  Branches     2853     2854       +1
==========================================
+ Hits        12355    12359       +4
  Misses       6910     6910
+ Partials      821      820       -1

Impacted Files
Coverage Δ

src/Avalonia.DotNetFrameworkRuntime/AppBuilder.cs
18.18% <100%> (+2.55%)
:white_check_mark:

src/Avalonia.Controls/AppBuilderBase.cs
80.24% <100%> (-0.25%)
:x:

src/Skia/Avalonia.Skia/BitmapImpl.cs
78.04% <50%> (-3.54%)
:x:

src/Shared/PlatformSupport/AssetLoader.cs
67.24% <ø> (+5.17%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e517a7...185a42e. Read the comment docs.


How to close Model X window?

https://owner-api.teslamotors.com/api/1/vehicles/{remote_id}/command/window_control
I POST:
{
"command": "close"
}

Response:
{
  "response": {
    "reason": "too_far_from_vehicle",
    "result": false
  }
}

I tried:
{
"command": "close",
"latitude": 39.871517,
"longitude": 116.63881
}

Response too_far_from_vehicle too.
But I seen some app can close model X window.

Helo Mr Gaolei,
You probably need to send latitude and longitude that correspond to where
your car is.
Without that, the windows will not entirely close.
Stay safe
Nicolas
http://tesla.jeedom.free.fr
On Tue, May 5, 2020 at 10:58 AM mrgaolei<EMAIL_ADDRESS>wrote:

https://owner-api.teslamotors.com/api/1/vehicles/{remote_id}/command/window_control
I POST:
{"command": "close"
}
Response:
{
"response": {
"reason": "too_far_from_vehicle",
"result": false
}
}
I tried:
{"command": "close","latitude": 39.871517,"longitude": 116.63881
}
Response too_far_from_vehicle too.
But I seen some app can close model X window.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/timdorr/tesla-api/issues/189, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKZEEOIOGXV5VZI2ZLNZR5TRP7ILLANCNFSM4MZMSAJA
.

Helo Mr Gaolei, You probably need to send latitude and longitude that correspond to where your car is. Without that, the windows will not entirely close. Stay safe Nicolas http://tesla.jeedom.free.fr
…

I send latitude and longitude same as the car's, too_far_from_vehicle too.
And Tesla official app also can't close Model X's window.
But I seen third party app can close.
So can you close Model X's window remote?

Don't make it exact, just close to it.


Adding unit test for coverage

Change log description
Adding unit test for coverage.
Purpose of the change
Improvement of code coverage.
What the code does?
Adds unit tests to improve code coverage
How to verify it
Building the project will gives improved coverage

updated pr and removed unwanted code


Remove use of "build_path_for_sudo_or_user"

This information is already available through TEdgeConfigLocation.

Inject TEdgeConfigLocation to commands that depend on this.

While there, refactor some String's to PathBuf and dedup some
other code.

Codecov Report

Merging #282 (27839bb) into main (9eedd91) will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
+ Coverage   65.61%   65.70%   +0.08%
==========================================
  Files          65       65
  Lines        3711     3706       -5
==========================================
  Hits         2435     2435
+ Misses       1276     1271       -5

Impacted Files
Coverage Δ

tedge/src/cli/connect/cli.rs
0.00% <0.00%> (ø)

tedge/src/cli/connect/command.rs
0.00% <0.00%> (ø)

tedge/src/cli/disconnect/cli.rs
0.00% <0.00%> (ø)

tedge/src/cli/disconnect/disconnect_bridge.rs
0.00% <0.00%> (ø)

tedge/src/command.rs
0.00% <ø> (ø)

tedge/src/main.rs
0.00% <0.00%> (ø)

tedge/src/utils/paths.rs
64.00% <0.00%> (+7.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eedd91...27839bb. Read the comment docs.


opencv3: Move IPP to use sha256

Motivation for this change
#4491
Replace md5 with sha256
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Thanks!


Using the auth0 word in the URL path triggers an authorization code exchange

Steps to reproduce:

Configure a page to have a URL like http://[wp_authority]/auth0test/;
Configure the WP plugin to have Login redirection URL set to http://[wp_authority]/auth0test/;
Perform a end-user login

The above flow will trigger a second authorization code exchange when navigating to http://[wp_authority]/auth0test/; since there's no code available on that URL, the exchange will fail and appear in the Auth0 logs as a failed one due to Missing required parameter: code.
It seems that having auth0 in the URL will trigger the code exchange to be executed as doing the above flow with  http://[wp_authority]/thisisatest/ will not cause any additional code exchange.

Sounds like a easy fix: https://github.com/auth0/wp-auth0/blob/master/lib/WP_Auth0_Routes.php#L23

Thanks for the digging @aslafy-z ... the fix is easy but just removing it might be breaking. I'll see if I can make this change without harming anyone 👍

Have to punt this to the major release, planned for early next year. I've not been able to find a simple way to keep this route as a functional callback for sites still using it so removing outright would be a breaking change.


Virtual Content: Reverse navigation

In the Virtual Content explainer, the last two steps of the scenario walkthrough say:

Eventually, the backing server sends a content payload which also contains a signal that the end of the document has been reached. Script code removes
the aria-virtualcontent attribute from the main element to indicate there is no more virtualized content.

The next time the user attempts to navigate to the next heading, the AT searches for a virtual content container, finds none, and announces there are
no further headings in the document.>

In this scenario, what would happen if/when the screen reader user decides to reverse direction and move backwards through the headings?

The behavior of the feature is intended to be symmetric in both the block and inline directions. For this very reason we're planning for a value set of the attribute that would allow authors to hint if there is content forward, backward in the block or inline direction. The canonical example here being a large excel spreadsheet with many columns overflowing in the inline direction and many rows in the block direction.


[6.0🍒] Resolve main executable symlink when looking up driver-adjacent subcommand binaries

Cherry-pick of https://github.com/apple/swift-driver/pull/1583
Explanation: As per https://github.com/apple/swift/issues/70932, when swift-driver is installed via a symlink, it is not able to correctly resolve adjacent tool binaries by following their corresponding symlinks. This is a regression from the old, legacy C++ driver. This change fixes this behavior by having the driver resolve its own path if it is a symlink, first.
Risk: Low. Cases where the added code takes effect were previously not working.
Testing: Expected behavior validated manually by implementor and issue originator (on main)
Resolves https://github.com/apple/swift/issues/70932

@swift-ci test

@swift-ci test Windows platform

@swift-ci test macOS platform

@swift-ci test

Is there a plan to merge this into 6.0?

sorely needed for swiftly compatibility https://github.com/swiftlang/swiftly/issues/122

@swift-ci test Windows platform

This should really get merged in - I'm surprised there are not more folks chiming in!

This has blocked me from trying out swift 6 for months so yes please merge this.


ledge climbing

when you see a ledge or anywhere you can climb or even climb/vault can you make a button so instead of fully climbing over it you climb to hold the ledge and then press w or spacebar to climb? ps: i know you can release w to hold on the the ledge but on shorter obstacles its every unreliable.

no

dam

pretty please?


[AKS] Upgrade api-version to 2021-07-01 for aks-preview module

Update SDK "azure-mgmt-containerservice" to 16.1.0 and API version to v2021_07_01 in aks-preview module.
Replace several strange class names introduced by the previous track 2 SDK, which now have been fixed.
Remove useless v2019_04_01 vendored sdk.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

AKS

@FumingZhang Could you fix the CI issue?

@FumingZhang Could you fix the CI issue?

I suppose the reason for CI failure is that CI is not using the latest azure-cli code base during testing, since this PR depends on the changes introduced in PR#19245.


ESP32 with 8 HX711

Hi,
I'm trying to use an Adafruit Feather ESP32, with 8 HX711.
My Pinsetup is like this:
int pinsDout[] = {18,5,4,36,21,17,16,19};
const int numPins = sizeof(pinsDout) / sizeof(pinsDout[0]);
int pinSlk = 14;

It works quite well, thank you for this library :)
however, i get some weird peaks from time to time:
https://ibb.co/GkVsjqd
Do you have an explanation for this? How can I get rid of them?
Thank you.

I think that the problem depends on specification of HS711 or power supply.
I'm happy if you find some way to resolve the problem and share it on this thread.


Process object validation finishing

All ok?

Not sure )) Can't push my changes. Something is wrong with ssl certificate.
I do it via Github Mac OS X desktop application. It says that I have no rights to push code to Motis project.
Don't you know what can be a problem?

Well, you cannot push directly to the Motis repository (mine). But you should be able to push it to your repository (in your account) and create a pull request.
Check the SSH keys or just push it via HTTPS.


Support YAML data

Hi,
I wonder how RML-IO could cope with datasets encoded in YAML format. YAML can be translated to JSON without losing information, so I think rml:JSONPath could be used as rml:ReferenceFormulation for YAML data.
In such case, the RML-IO spec should also mention YAML when using JSONPath, though it should also note that RML engines must internally translate YAML to JSON to make this possible.
Any thoughts?
Thanks!

Maybe this issue is more a rml-io-registry issue than a rml-io one. @DylanVanAssche what do you think?

While translating YAML to JSON works, isn't there a similar thing to JSONPath/XPath for YAML?
If there is, then it is rml-io, if not, then it it rml-io-registry

AFAIK there is no such thing as "YAMLPath". The best example I know about is Kubernetes API, which allows you to select data in the YAML manifest using JSONPath (see JSONPath Support). Maybe someone can shed some light here.
What's the purpose of rml-io-registry and how it relates to rml-io? In any case, I still think YAML should be mentioned in the RML-IO spec. Otherwise, it seems you cannot handle YAML data in RML.

What's the purpose of rml-io-registry and how it relates to rml-io?

RML-IO puts its focus on Logical Source/Target and Source/Target of RML.
In a Source/Target you have the access description while the Logical Source/Target contains the Source/Target as access description and the reference formulation and other things.
rml-io-registry aims to provide a detailed description for each data format on how to iterate over the data given a reference formulation and such. RML-IO is the abstraction while rml-io-registry puts the abstraction into reality for each data format e.g. SQL, JSON, XML, ... or YAML. The RML-IO spec aims to refer to this registry as you get now the impression that YAML ain't supported, which is what we want to avoid since RML-IO can support any data format, but requires a different access description, reference formulation, etc. depending on the data format at hand. As we cannot mention all existing and future data formats in a spec like RML-IO, we aim to move that to the registry so RML does not need to be revised at W3C each time a new format comes to light (like YAML here).
So I propose to define YAML and how to iterate over such data in the registry, we add then the reference formulation etc. in RML-IO as a possible reference formulation. How to do things in practice is then described in the registry for YAML.

I'm glad this is being discussed!
There is also YAML-LD. The current spec "dumbs down" YAML to JSON,
but we've also discussed leveraging YAML unique features.
Eg for representing datatypes:
issued: !xsd!date 2024-10-03
is much nicer than
"issued": {"@type": "xsd:date", "@value": "2024-10-03"}
Perhaps RML should consider such special constructs


Small copy and paste error

Hello,
Thank you for the great doco. Small re-write for a sentence is needed:
"Delete a new Application Insights resource."
should read
"Delete an Application Insights resource."

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d12f6146-c67e-a67b-2878-5e8b882be173
Version Independent ID: 588219b1-1476-3a0a-4c78-bd4afb8aa08d
Content: az monitor app-insights
Content Source: latest/docs-ref-autogen/monitor/app-insights.yml
Service: monitoring-and-diagnostics
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@kairu-ms for awareness


[Feature Request] Rename _TargetNetUpdate in TargetNetUpdater

Motivation
The _TargetNetUpdate could be better named: first, it is used for type annotation at several places in the code and we should make it public. Second Updater seems more adequate than update (which would imply that this is a method, not a class).

closed as of #422


Added support for additional path separator

Thank you for this pull request.  This looks very valuable.
Is there any situation on the Windows platform that you would not want alt_path_sep='\\'?  If not, it seems best to set it automatically.  What do you think?
Also, the variable name uses alternate and the docstrings use additional.  Let's use one or the other.

Yes, I wasn't sure about this. If you are using the default path separator it makes sense to set it automatically, otherwise not. Maybe we should indeed set it automatically in the default case and not   pass it as an argument at all. What do you think?
About the name - yes, I changed my mind halfway through the code, I will fix this.

This is great work.  After further investigation, I found that module os has os.altsep, which is the same as the alt_path_separator that you added.  Note that os.altsep is also exposed as os.path.altsep.  I noted that on Linux these are both initialized to None, which makes sense.
Could you please implement os.altsep and os.path.altsep and add a test for them?

Ah, good find! I wasn't aware of os.altsep (though may have seen it). Done.


Update bpchainmap.md

For BlocksIndia BP

@pawmmm - Can you please check the update to the chaimap for blocksindia BP


Test iOS 11

@lmulhall-phet Please spot check with production HTML5 sims in mobile Safari:

[x] phetsims/joist/issues/234 (just comment in that issue if it still occurs or not)
[x] Below sims with sound have working sound
[x] Molecule Shapes
[x] Energy Skate Park Basics
[x] Arithmetic
[x] Acid Base Solutions
[x] Charges and Fields
[x] Color Vision
[x] Projectile Motion
[x] Plinko Probability
[x] States of Matter
[x] Wave on a String

Just spend about ~1 minute on each sim. At least do the above, but also feel free to do additional ones.
Then do everything again, but this time in...

[x] ...the PhET App!! (Don't test the joist issue here)

Labeling top priority because it should be quick.

Everything looks good! Closing. :)


Issue with folder iam policy access for read only sa in project factory

With the project factory - the read only service account gets only folder viewer permission.
This does not give access to resourcemanager.folders.getIamPolicy. Folder Viewer IAM
So PRs fail (in plan stage) with errors such as these
module.projects.module.hierarchy-folder-lvl-1["sandboxes"].google_folder.folder[0]: Refreshing state... [id=folders/nnnn]

Error: Error when reading or editing Resource "folder \"folders/nnnn\"" with IAM Binding (Role "roles/pubsub.admin"): Error retrieving IAM policy for folder "folders/nnnn": googleapi: Error 403: Permission 'resourcemanager.folders.getIamPolicy' denied on resource '//cloudresourcemanager.googleapis.com/folders/nnnn' (or it may not exist).
Details:
[
  {
    "@type": "type.googleapis.com/google.rpc.ErrorInfo",
    "domain": "cloudresourcemanager.googleapis.com",
    "metadata": {
      "permission": "resourcemanager.folders.getIamPolicy",
      "resource": "folders/nnnn"
    },
    "reason": "IAM_PERMISSION_DENIED"
  }
]
, forbidden

  with module.projects.module.hierarchy-folder-lvl-1["sandboxes"].google_folder_iam_binding.authoritative["roles/pubsub.admin"],
  on .terraform/modules/projects/modules/folder/iam.tf line , in resource "google_folder_iam_binding" "authoritative":
  36: resource "google_folder_iam_binding" "authoritative" {

I am considering doing this

create a custom role folder_iam_viewer (in bootstrap stage) - that includes the getIamPolicy permission.

And then update the resman level - branch-teams to include that custom role.
     (local.custom_roles.folder_iam_viewer) = (       local.branch_optional_r_sa_lists.pf-dev     )
Is this the right approach? Should I make a PR for this or am I missing something?

Good point and thanks for reporting it. I would just use the custom organizationAdminViewer role we are already defining in stage 0.
Can you send a PR to add that role to the project factory service accounts, probably at the org level with conditions on the prod and dev tags? Otherwise I can do it soonish (probably tomorrow).


3D Tiles Styling - change math constants and tileset time variable

From the discussion here: https://github.com/AnalyticalGraphicsInc/3d-tiles/pull/169

PI - Math.PI
E - Math.E
TILES3D_TILESET_TIME - ${tiles3d_tileset_time}

Just those trivial comments.

Ready


Zoom link implementation

There have been complaints that GunnWATT does not have the Zoom link features that UGWA has.
People have asked for a way to manually input links while our automatic schoology link finder thing is still in the works.
I can try to implement that, but if someone more qualified wants to spend a little time on it that'd be cool too.

Closed in latest commit


BUG: distributions' var method does not respect broadcasting

Describe your issue.
It seems that since scipy 1.7.0, the .var() method of scipy distributions like norm or logistic does not respect the broadcasting rule. I would expect the following reproducing assertation pass.
Reproducing Code Example
import numpy as np
import scipy.stats as sp
assert (sp.norm(np.zeros(2), np.array([[1], [2]])).var() == sp.norm(np.zeros(2), np.array([[1, 1], [2, 2]])).var()).all()

Error message
AssertionError

SciPy/NumPy/Python version information
1.7.1 1.19.5 sys.version_info(major=3, minor=7, micro=12, releaselevel='final', serial=0)

Seems like a bug in argsreduce here:
https://github.com/scipy/scipy/blob/c30fefc2446a7cb93de1b45765e243345d5929db/scipy/stats/_distn_infrastructure.py#L572
When all the values are valid, it doesn't broadcast the arrays to correct shape. But if any invalid values are given, it will return the correct output:
>>> import scipy.stats as sp
>>> sp.norm.var([0,0], [[1],[float('nan')]])
array([[ 1.,  1.],
       [nan, nan]])


Added CLI option to read license file for inlets operator.

Signed-off-by: Anit<EMAIL_ADDRESS>
CLI option license-file or lf added to read a inlets operator license file.
Description

CLI option license-file or lf added to read a inlets operator license file.
Motivation and Context

[x] I have raised an issue to propose this change (64)
The existing and previous option to read license key passed as a string is insecure. Hence, this featured was needed.

How Has This Been Tested?

Module has been developed as an standalone package
Unit test has been added to verify it works standalone.
Manual test are done by running the application is done.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

[ ] New application can be installed on ARM platform.
[ ] New application shows an error message if the architecture is not supported.

@Waterdrips Hope things are well. Could you please review?

Thanks for the PR. @Waterdrips did you see this ping?

Thanks for having a go at this PR, we needed it a little sooner, but you were not to know.
Fixed via: #83
Please feel free to stop by again and we'll see if we can find something else for you to get a quick win with.

Will do @alexellis. Thanks.


[Profiler] Fix distributed deinit crash when emitting coverage

We need to emit the profiler increment in the deinitBodyBB if we're within a distributed actor.
Resolves #60910

@swift-ci please test

Oh, thanks for noticing and the fix @hamishknight !


Doesn’t work programmatically

Hi, the JS usage doesn’t work. Try running this script in node:
const sleep = require('sleep-ms');
setTimeout(() => console.log('500 ms passed!'), 500);
sleep(1000);
console.log('1000 ms passed!');

Here’s the output:
1000 ms passed!
500 ms passed!

BTW, the only way to implement sleep in native JS is to block execution:
const begin = Date.now();
while (true) if (Date.now() - begin >= ms) break;

– but that freezes a thread completely and is usually a very bad idea. On a single-thread processor this would freeze the whole system!

…but the CLI works like a charm and is pretty useful :) I’ll happily star this module if you take the JS thing out of the docs :)

Actually CLI was the main thing I created this for.
The JS API does not block the code running scope. It simply acts as setTimeout.  But, there's no use case for it. Blocking execution is not really a good thing.
I think I will remove the JS related doc like you've suggested.

Also, version 1 of this module used the blocking method, which I replaced with timeout in v2.

I think I will remove the JS related doc like you've suggested.

Good thing! :+1:

Actually CLI was the main thing I created this for.

It’s the only thing I need it for :)


Running in Nashorn

I'm not sure if this is the right place for questions like this. If not, please direct me elsewhere.
I'm looking to run sass.js (or whatever variant is needed) in the JVM, and it sounds like Nashorn is the best suited engine to do so. However, the documentation is a little confusing regarding which distribution file to use when running in Nashorn.
Should I be using sass.js, or sass.sync.js? I've tried both, neither giving me the results I'm looking for.
Using sass.js, I'm able to load script into the engine, but I am unable to use the "synchronous" api i.e. Sass.compile..., and it seems like this version requires WebWorkers. Does this mean I also need to load in sass.worker.js?
Using sass.sync.js, while loading that script into the engine, I get the following error:
javax.script.ScriptException: TypeError: X is not a function in <eval> at line number 73

Obviously, this is not easily parsable given the state of the source file.
For reference, my Java code looks like this:
javax.script.ScriptEngine engine = new javax.scriptScriptEngineManager().getEngineByName("nashorn");
try {
	engine.eval("sass.js script here");
	...
} catch (Exception e) {
	throw new RuntimeException(e);
}

Should I be using sass.js, or sass.sync.js? I've tried both, neither giving me the results I'm looking for.

sass.js is what one would use in a browser (where you can run Workers). It contains the API, but not libsass (which is run in a Worker)
sass.sync.js contains all of the API and libsass and is generally what one would use in any context that does not allow access to Workers. This is what you want to load into nashorn, this is also what we use in Node.

Unfortunately I don't know much about Nashorn, so cannot tell you why it's failing. I could point you at https://github.com/m4r71n/sass.js-rhino-nashorn/blob/master/src/TestNashorn.java (via this comment), but I have no idea if that helps…

Thanks for the link, somehow I missed that comment while reading that issue the other day. Using the same sass.js files as used in that sample (a nashorn shim and sass.sync.js from the cleanup-initialization branch), I was able to get sass.js to work. However, that version is quite old (~2016) and I'd like to be as up to date as I can. This is a good start, at least. I'll continue to investigate using the latest sass.sync.js.

Did you get this to work?

Unfortunately I had to put this on the shelf shortly after I closed this issue. I did not get to where I wanted but I don’t recall exactly how close I got. I will try to get back to you

Having just worked on lein-sass I found that the latest version of sass.sync.js to load in Nashorn without any problems is 0.10.8.  Currently, though, I believe lein-sass is using 0.9.13.


Quickstart: Join your calling app to a Teams meeting

I have integrated my Calling App with Teams Meeting, but I get the following error, I am entering a valid Link.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 814e94a3-80a3-927b-b1ce-d4526435feb4
Version Independent ID: a304ea23-c2cf-5a31-5b37-74b92da342be
Content: Quickstart - Teams interop on Azure Communication Services - An Azure Communication Services quickstart
Content Source: articles/communication-services/quickstarts/voice-video-calling/get-started-teams-interop.md
Service: azure-communication-services
Sub-service: calling
GitHub Login: @chpalm
Microsoft Alias: chpalm

@deepakhariharan
Thanks for your feedback! We will investigate and update as appropriate.

This is the Teams Link I used
https://teams.microsoft.com/l/meetup-join/19%3Ameeting_ZmE3NDI1YWQtYzRhOS00YjFiLTgzYjMtYWI0M2VhYjI4MTU2%40thread.v2/0?context={"Tid"%3A"36da45f1-dd2c-4d1f-af13-5abe46b99921"%2C"Oid"%3A"21434d69-289a-4ef8-af03-c67b497ff28b"}>

@deepakhariharan Please note that this forum is intended for doc feedback.
Since this seems to be related to troubleshooting, we would need to work with you via email. If you still require assistance, please reach out to us at<EMAIL_ADDRESS>with the subject as ATTN: Bryan and in the body of the email please include your Azure subscription ID.
Thank you for your understanding.


static preview endpoints

This feature includes:

Torque png rendering using node-canvas
HTTP layers
Static preview endpoints: being able to request a preview from a mapconfig

Using base layers (HTTP layers)
Using torque layers

Part of the functionality in server.js was split into several pieces: controllers, backends
Render cache was also split into smaller components: renderer factory and several renderers

Any feedback is welcome in this PR.
cc @javisantana @zenitraM @fdansv


Figure out publishing to gradle when one tool depends on another

Today when we publish to maven central, we publish all tools at the same time with the same version number. That includes the Tools Viewer, which has a dependency on the other tools.
Let's imagine a scenario where we are on version 1.0.0 and there is a bug with Presence Viewer. We then fix the bug, publish a new version of tools and call it version 2.0.0. However, in the source code Tools Viewer is still pulling in version 1.0.0 because technically at the time of publishing that's the latest version in maven central.
So we then have to publish another version of tools, maybe 2.0.1 where it is pointing to the updated version 2.0.0.
This issue is to discuss ideas on how to streamline this process so we don't have to publish two updates.
FYI it's not just Tools Viewer, some of the other tools also depend on each other. All modules are also using the same version catalog too (which should not be a problem).
One option that was discussed is including mavenLocal() in the list of repos, and pointing to what the future published version will be ahead of time. We can then publish to maven local (with the upcoming version) so that the modules compile and then publish to maven central.
I don't think maven central checks dependency/compilation issues.

CC: @zmarkan @texasRanger09

Some of my thoughts on this, taken from a Slack thread:
What if we distributed everything in a single library module, and advise developers to use minify to get around by essentially letting to build tools do the tree shaking on any unused modules?
For example if someone only wants presence viewer, or heartbeat they would just use them from tools, and the minify process will remove all other unused classes.
R8 will check and shrink unused code automatically - https://developer.android.com/build/shrink-code
To make it more straightforward, we can configure the tools viewer to dynamically create the menu, based just on the tools they want.
This could work  all tool entry points implementing a common interface consumed by the tools viewer, and initializing the tools viewer menu by passing a list of desired tools.
Default behaviour shouldn't change - the tools viewer should by default include all tools.
Upsides:

more seamless publishing, versioning - easier and faster for the Ditto team and external contributors to ship changes
less fragile dev process. No local implementation changes required.

Downsides:

By default the included package would be larger (unless using DittoToolsViewer as the main entry point and not minifying). Developers must use minifyEnabled to benefit from smaller library sizes. At the moment, they can just pull individual library modules as dependencies.

Neutral:

Major release version required
Deprecation of existing tools modules required

I really like this idea, it solves the dependency hell quite nicely while also being a low friction way to implement things quickly.
We should also make sure that each tool can still take in whatever configuration parameters they may need (e.g. Health tool can be configured to display only certain things).

What about to provide a BOM?
Providing something like live.ditto:tools-bom:2024.11.01 seems more align with the android ecosystem.
So now internally we can do the mapping of the correct library version

@zmarkan's single-module idea is certainly the simplest from a release point-of-view, but I imagine a lot of dev teams won't take the extra effort to configure minification to exclude the parts they don't use.
@anyercastillo's BOM idea solves the idea of "what tools versions are compatible with other tools versions" but only for teams that actually use the BOM dependency instead of the individual tools dependencies.
One thing to keep in mind with both this BOM approach and our current individual tools is that they should be published in the reverse order of dependencies. In other words: publish the tools that don't depend on any tools before publishing tools that depend on the leaf nodes and on up the dependency tree. The BOM package should be the last module published.
While the window of publishing is typically small, I've seen several cases where Maven Central stops working for uploads or where we ran into an issue publishing something in the middle of SDK releases. Just something to think about.
One option to address this case of publishing multiple inter-dependent libraries is to use Maven Central's staging repo behavior and upload all the libraries before releasing the changes from the staging repo - this makes the new versions all available in one update to Maven Central. This staging repo behavior effectively works around any publishing ordering issues that could arise.

That's valuable, thanks. The BOM approach is definitely worth investigating further.

We have actually mentioned the BoM idea before: https://github.com/getditto/DittoAndroidTools/issues/63 but we didn't explore it any further because other higher priority items came up.
Is there some world where we can combine both solutions? e.g. the only dependency a client would pull in is Tools Viewer, then using Tools Viewer configure what tools they want to display. Internally Tools Viewer is using a BoM/managing dependencies of the tools.
By doing this we could still have the individual tools available, especially if clients might have apk size requirements we need to think about, then those clients might have to do a few extra steps, but that would be expected?


A very general question

Hi @xorbit,
A very general question. I find it difficult to document the sensor. What are your experiences with the sensor? How much noise does it produce? I'm thinking about using it in my system. Thank you in any case for making the code available!
Regards Steffen-W

Yes, Sharp is one of those companies who like to hide documentation and don't care unless you buy billions worth.  Very annoying.
Anyway, the readings seem quite stable and reproducible between parts.  The fine (close up) range varies smoothly, I'd say with mm resolution or so though my testing wasn't very thorough in that regard.  According to the spec the accuracy is +/- 6 mm, so you may need to use some calibration.
If you want to play with the part, I am now selling my extra breakout boards on Tindie if that would help in your evaluation: https://www.tindie.com/products/silicognition/sharp-gp2ap03vt00f-time-of-flight-breakout/

Thank you for the answer. Sorry for the late response. For me, accuracy is not quite so important. The noise is actually much more relevant. The sensor has a very high resolution, which is much more interesting. Your circuit board is very interesting. Unfortunately, the shipping costs to Germany are very high.

Yeah, not much I can do about that.  For other products I'd send you to Mouser to buy it locally, but this breakout is more of a one/off that will not make it to Mouser.


Add article from external link

verified the webpage host (Txt DNS verfify?)
extract title (use rehype)

How about just adding an option like Origin post on, and showing a badge?


refactor: improve logging (add tracing crate)

Switch to using tracing instead of println!() for logging.
Next steps:

Add support for Prometheus (check out this guide)

things left to do:

enable debug log level
pass in log level to WakuNodeConfig


Shows up, but not clickable

I finally got it to work (sort of) but I cant click on anything.

Great! The thing about clicking is that Ubersicht sits behind your rendered desktop. Unfortunately I have no control over this. If you want to enable seamless interaction with supernerd, there instructions in the readme, I'll copy them here:
Lucky for you, in order to use all of the interactive shit, you must renounce interacting with your desktop icons. I know, I know.  Do so: defaults write com.apple.finder CreateDesktop -bool FALSE;killall Finder

When you're ready to revert back to your barbarian-like usage of your desktop/dumpster, do this: defaults delete com.apple.finder CreateDesktop;killall Finder

If you'd rather not do that, everything will be clickable only when you are holding down your selected Ubersicht modifier key. I think the predefined key is fn, but you can change that in the Ubersicht preference panel

Ok thanks
Sent from my iPhone

On Mar 14, 2018, at 15:21, blahsd<EMAIL_ADDRESS>wrote:
Closed #20.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Privacy reference unit tests for content blocker rules

Task/Issue URL: https://app.asana.com/0/1171671347221384/1200272854466885/f
Tech Design URL: https://app.asana.com/0/1171671347221384/1200501100360630
CC:
Description:
Adds reference tests for domain matching rules.  Test definitions pulled as git submodule from https://github.com/duckduckgo/privacy-reference-tests
Steps to test this PR:

update git submodules
cmd-U in Xcode, or run the test in domainMatching.swift directly

Note CI seems to be failing but for seemingly unrelated reasons (comscore tests), will retry again later.

Copy Testing:

[ ] Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

[ ] Portrait
[ ] Landscape

Device Testing:

[ ] iPhone SE (1st Gen)
[ ] iPhone 8
[ ] iPhone X
[ ] iPad

OS Testing:

[ ] iOS 13
[ ] iOS 14

Theme Testing:

[ ] Light theme
[ ] Dark theme

Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

A few comments related to style / convention for you.
The tests don’t appear to pass. Please check bitrise. Click on Checks then head to bitrise for more info. If you think they should pass ping me and I’m happy to pair on it to get it going.

Yes as I mentioned in the intro there are 3 Comscore tests failing that seem unrelated to my tests?
UnitTests.EntityMappingTests
  testWhenDomainHasSubdomainThenParentEntityIsFound, XCTAssertEqual failed: ("Optional("comScore")") is not equal to ("nil")

The odd thing is that all tests pass on my local, and they were also passing on the previous WIP branch (https://github.com/duckduckgo/iOS/runs/2917260792) before I created this fresh (rebased) one for landing purposes.
Lets pair up on Mon!

Ok all feedback addressed, tests green.   I squashed the last 3 commits to clean up the history

Oh one thing before you merge can you give it a more readable name for the history just to make it easier to find in the future, please. :)

Oh one thing before you merge can you give it a more readable name for the history just to make it easier to find in the future, please. :)

Done, and thank you for the prompt & thorough reviews!


Is this project maintained?

I discovered this project while searching for open-source HLS-solutions.
Unfortunately, this project pretty much looks abandoned. The last commit dates back to 2017 and it was impossible for me to build the project with a recent version of gcc, throwing a bunch of errors.
For reproducibility, I used the following gcc-version:
$ g++ --version
g++ (GCC) 13.2.1

I propose to use this issue to let anyone, willing to maintain the project, fork it and update the source code in order to make it compatible with more recent compiler versions.

To be fair, I will share some more context about my specific problems:
Apparently the current ABI of libllvm does only support C++17. However, exchanging the CXX-flag in the Makefile is not sufficient to make it compile on modern systems, as there have been also some general ABI-changes in Libllvm that require adaption for c-ll-verilog.
The described problems could be reproduced with the following Dockerfile:
FROM ubuntu:22.04

RUN apt update
RUN apt install -y make g++ git llvm bison flex
RUN git clone https://github.com/medbzkst/c-ll-verilog.git
RUN make -C c-ll-verilog

(just run $ docker build .)


Stochastic Gradient Langevin Dynamics + Bayesian Dark Knowledge examples

Stochastic Gradient Langevin Dynamics & Bayesian Dark Knowledge Example
Contains examples related to Stochastic Gradient Langevin Dynamics (SGLD) (Welling and Teh, 2011)
and Bayesian Dark Knowledge (BDK) (Balan, Rathod, Murphy and Welling, 2015).
sgld.ipynb shows how to use MXNet to repeat the toy experiment in the original paper. bdk_demo.py contains scripts related to Bayesian Dark Knowledge.
Use python bdk_demo.py -d 1 -l 2 -t 50000 to run classification on MNIST. More details will be added.
See https://github.com/sxjscience/mxnet/blob/bayesian-dark-knowledge/example/bayesian-dark-knowledge/sgld.ipynb for the current notebook. However, the math formulas may not be aligned correctly (see https://github.com/jupyter/nbviewer/issues/452 for similar problems).

Thanks for the contribution! This can be very helpful for people working on MCMC.
Can you also make an notebook on bayesian dark knowledge?
Let us also think about folder name, maybe MCMC or bayesian-method could be a better name. We could possibly add other optimizers like SGHMC and SGNHT

Fine, I'll work on a notebook for BDK. For the folder name, I think bayesian-method would be better and we can add more Bayesian modeling examples to this folder in the future.

@sxjscience do we have any updates on this?

@tqchen, I've added the notebook for Bayesian Dark Knowledge. See https://github.com/sxjscience/mxnet/blob/bayesian-dark-knowledge/example/bayesian-methods/bdk.ipynb

This looks great, can you squash the commits into one? I will merge it in after the squash

@tqchen Done.


pull request for e2e test at 11/18/2016 01:56:02

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


hello, how to export the projection onnx?

From the export, I didn't find how to export the projection onnx as well?

PR is here, but not been merged yet since I didn't have time to do some changes (about testing and inference scripts). However, you can use the export script for now.

@EmreOzkose Hi, I only found these onnx were exported, didn't find encoder_proj.onnx or decoder_proj.onnx.

which needed by your onnx c++ inference code.

I have 2 questions:

the export didn't aligned with your inference code, how to resolve it?
you have a all_in_one model, in my opinion, this is useless, since we using encoder and decoder to inference, how didi u using it?

What have you done and what are the  error messages?

Hi @jinfagang , I am updating PR now. You can use export script

the export didn't aligned with your inference code, how to resolve it?

Export script is updated.

you have a all_in_one model, in my opinion, this is useless, since we using encoder and decoder to inference, how didi u using it?

Initially, the aim was to combine all parts into one .onnx like model.pt. There is a branch which uses only all-in-one.onnx to decode. It is written in Python. This repo uses Onnxruntime without dependency on Libtorch and I couldn't extract each model (encoder, decoder, etc..) internally. Hence models are given separately for now.

@EmreOzkose thanks. now i can get proj model as well.
the all in on infefrence, from I can see: https://github.com/EmreOzkose/sherpa/blob/887ddd0924cf5c4216a8671c39b04e8e8371356d/sherpa/bin/pruned_transducer_statelessX/offline_asr.py#L298
this still using model's decoder when greedysearch. This is not convenient on onnxruntime.

Oh, I get it. Will this also port to c++ as well?

This repo contains the first working version, but I have to do refactoring (adding OfflineASR, OfflineRecognizer, etc..). I am planning to do it in a few days.

Please use
https://github.com/k2-fsa/icefall/blob/master/egs/wenetspeech/ASR/pruned_transducer_stateless2/export.py
to export Chinese models.


standardize_crashes date filtering

config file now passed entirely to data_standardization function, in line with other functions
standardize_crashes now filters crashes outside of specified range
PEP8 formatting applied to modified files

I can see the difference. Moving to full start & end dates makes sense, but that'll require changes in multiple scripts, right?
As an interim solution, could I change:
..(end_year is not None and crash_year > end_year)
to something like
..(end_year is not None and crash_year > (end_year - 1))
to complete this issue and not have it be a blocker for getting the new refined crash data? Then we could create a separate issue to review start & end date usage throughout the pipeline.
Thanks.


Ambiguous use of 'evo_drawerController'

I have 2 targets in my application, one is of main application target and one is of Unit Test target of my application. I have used DrawerController in my application.
Now, my main application target is running fine without any error. But when I try to run the Unit Test target, I am getting the "ambiguous use of 'evo_drawerController' "
Below is the exact error from build logs:
           /Users/dhirenshah/Documents/git/ThirdParties/DrawerController/DrawerController.swift:39:35: error: ambiguous use of 'evo_drawerController'
    if let drawerController = self.evo_drawerController {
                              ^
          /Users/dhirenshah/Documents/git/ThirdParties/DrawerController/DrawerController.swift:24:9: note: found this candidate
var evo_drawerController: DrawerController? {
    ^
       PCities.UIViewController:2:16: note: found this candidate
           public var evo_drawerController: PCities.DrawerController? { get }

I tried few of the solutions but didn't work. I followed this link but did'nt worked: http://stackoverflow.com/questions/24087011/ambiguous-use-of-propertyname-error-given-overridden-property-with-didset-ob

Did you add the DrawerController to both targets (app and unit tests) at the same time? That will usually give you that error. You should only have to add it to the app target, because the unit tests automatically include everything that's in the app target.


Choose a continuous integration tool

Considering between

Travis CI
Circle CI

Chose travis-ci, turn on the project to public after #27


Improve bulk record field error handling

Flow
client:
on form submit:

generate a sequential set of ID's for all new records
FE validation
hit API

on errors:

use id provided in the meta to determine if this item contains errors

API:
on preproc:

if record has no ID, create a sequential ID from the provided prefix and a counter
if record has ID, use that

on error:

identify the error with the above-mentioned ID

Dev notes

I refer to these ID's as an item ID, since they are not consistently record ID's
I construct a fresh set on each form submit, to make the API's life easier when determining what ID a new record should have. Since errors are reset on each form submit, this is perfectly valid.

Codecov Report

Merging #96 into develop will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff            @@
##           develop      #96   +/-   ##
========================================
  Coverage    36.47%   36.47%
========================================
  Files          496      496
  Lines        46665    46671    +6
========================================
+ Hits         17019    17023    +4
- Misses       27642    27643    +1
- Partials      2004     2005    +1

Impacted Files
Coverage Δ

compose/types/record.go
26.66% <ø> (ø)

compose/service/record.go
49.76% <33.33%> (-0.24%)
:arrow_down:

compose/types/rest.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 686b10f...d2a9581. Read the comment docs.


"docker node ps [nodeId]" show nothing even ran a container on node

work node run  "docker ps"

manage node ls

then I ran docker node ps but show noting

I ran docker node ps -a  return "unknown shorthand flag: 'a' in -a" then I ran "docker node ps --help" show me

my docker version

why?

Hi, @wcggit ,Thanks for your feedback.
I am afraid that your issue is related to Swarm Mode of docker engine, maybe it is more proper to post issue here https://github.com/docker/docker/issues/new . This project is about Swarm which is different from swarm mode in docker engine.
Here are more details about the difference https://github.com/docker/swarm#swarm-disambiguation
I am closing this. If you need more help, feel free to let us know. Thanks again for your contribution.


no tag latest

Being a complete docker newbie, I failed to install your docker image, see error message below:
make download-image
docker pull modelicainaction/jmodelica
Using default tag: latest
Pulling repository docker.io/modelicainaction/jmodelica
Tag latest not found in repository docker.io/modelicainaction/jmodelica

Two things I noticed when building the image: You are installing python first via apt-get and then later via pip. Is this on purpose?
I get some warning regarding apt-utils not being installed, you might want to install it earlier.

Thanks for finding this problem, this commit 3d85cfd1d6dba4e9cc75f7cf2da4d459c32b49a5
should fix the problem associated with the make download-image command.

Thanks for the quick fix.
Building the image also succeeded and the notebook gives me the same results.
Very nice and very helpful!


Change to use Templates in Components Build

Update build to use Templates and conditional phases instead of Matrix.
See https://github.com/Microsoft/vsts-agent/issues/1501

@JakeRadMSFT , I think we accomplished this, right? Closing for now.


missing dedicated Azure Route Server sudnet name

Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[x] The relevant Azure service or technology.
Azure Route Server
[x] A link to the published documentation article that you have feedback about.
https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/virtual-network/virtual-network-for-azure-services.md
[x] Clear, specific feedback that the author can act on.
Missing "RouteServerSubnet" dedicated subnet name.

Asm entioned in https://learn.microsoft.com/en-us/azure/route-server/quickstart-configure-route-server-cli#add-a-dedicated-subnet
The Azure Route Server service must have its own dedicated subnet name of "RouteServerSubnet".

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b1b8e120-45a7-584b-a421-8e41d29ebbcc
Version Independent ID: 54a37832-4c47-ab50-a811-baae97a0b17f
Content: Quickstart: Create and configure Route Server using Azure CLI
Content Source: articles/route-server/quickstart-configure-route-server-cli.md
Service: route-server
GitHub Login: @halkazwini
Microsoft Alias: halkazwini

@ko5tas
Thank you for bringing this to our attention. I've assigned this issue to the author who will investigate and update as appropriate.

@halkazwini
Could you please review add comments on this, update as appropriate.

Hi @ko5tas
Thank you for your feedback! I've just added Azure Route Server to the table in: https://learn.microsoft.com/en-us/azure/virtual-network/virtual-network-for-azure-services. It may take a few hours until you can see the update reflected on the public doc.

#please-close


First pass at improving documentation

Document environments, templates, history, remembers, contributing
Add some todo

Got some more words for you @pglass

Now that I'm reading it, I think it's generally more readable if we move bash comments like:
# spag does the thing
$ spag request do_thing
...

to regular text, like:
Spag does the thing:
$ spag request do_thing
...

But I don't know what you think about that and not a big deal.

Did all the things, def like it better @pglass


Update readme

Summary of the Pull Request
Update the readme with the message we will be archiving the project.

Codecov Report

Merging #3408 (9e58a45) into main (9c4bc3e) will decrease coverage by 3.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3408      +/-   ##
==========================================
- Coverage   34.24%   30.96%   -3.29%
==========================================
  Files         297      133     -164
  Lines       36365    14378   -21987
==========================================
- Hits        12453     4452    -8001
+ Misses      23912     9926   -13986

see 164 files with indirect coverage changes


The Activity page is not applied your theme

I installed your theme. It's great.
But the Activity page  is still displayed with default theme.
Did you implement your theme for the Activity page yet ?

Closed.
It's caused by cache.


Issue with map-obj 5.0.2 being an ES module and @adzerk/management-sdk compiled to ES5

Hello,
I've encountered an issue while using the @adzerk/management-sdk library. It seems that this library is trying to use the map-obj version 5.0.2, which is an ES Module, but @adzerk/management-sdk is compiled to ES5 and uses CommonJS module syntax.
Here is the error message that I am getting:
Error [ERR_REQUIRE_ESM]: require() of ES Module /app/node_modules/map-obj/index.js from<EMAIL_ADDRESS>not supported.
Instead change the require of index.js in<EMAIL_ADDRESS>to a dynamic import() which is available in all CommonJS modules.

As you can see, the error message suggests using a dynamic import() instead of require(). But as @adzerk/management-sdk is transpiled to ES5, it is not compatible with ESM syntax.
Possible solutions could be:

Updating the @adzerk/management-sdk build process to output ES6 or later, which includes native import/export syntax.
Sticking with CommonJS, but adding a build step to transpile dependencies to CommonJS.
Using dynamic import() to load map-obj.

Could you please look into this issue?
Thanks for your help and let me know if you need any more information.

Hi @rlustemberg, can you try updating to the latest version and see if that helps? Please let me know how you go.


Did /v2/machines change to /v2/members ?

I was diagnosing a problem with confd, where it would not recognize my v0.4.6 etcd cluster. Turns out it was because confd was compiled with the latest etcd client, which was changed to check a node for /v2/members rather then /v2/machines in this commit
Is that intentional? Seems like it will cause problems when code using the new client tries to talk to older etcd clusters?

@lordelph Sorry for confusion.
current master is for v2.0 cluster, and i have tagged v0.4.6 for v0.4.6 cluster.

Thanks - I solved my issue by using a prebuilt binary of confd rather than compiling the go source. Will close this ticket now, there's an open ticket on confd for supporting both versions of etcd.


Scene Tree: double click on subscene icon will open it

It's possible to double click scene icon inside tree view, to open it quickly:

Didn't doubleclick focus on the node in the scene?
On Wed, Jun 21, 2017 at 3:12 PM, kubecz3k<EMAIL_ADDRESS>wrote:

@kubecz3k commented on this pull request.
In editor/scene_tree_editor.h
https://github.com/godotengine/godot/pull/9305#discussion_r123325415:

@@ -141,6 +141,8 @@ class SceneTreeEditor : public Control {
List *script_types;
bool _is_script_type(const StringName &p_type) const;

int subscene_previously_clicked_at_time = 0;

oh yeah, remember from previous pr that you are right, thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/9305#discussion_r123325415,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z23UxCl2MNxPF0BkaO2Jhf_G5j1x6ks5sGV0EgaJpZM4OBQxH
.

@reduz double click on the normal icon will focus. Double click on that 'subscene' icon (the one that normally shows popup) does not.

oh, i see
On Wed, Jun 21, 2017 at 3:37 PM, kubecz3k<EMAIL_ADDRESS>wrote:

@reduz https://github.com/reduz double click on the normal icon will
focus. Double click on that 'subscene' icon (the one that normally shows
popup) does not.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/9305#issuecomment-310167911,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2xPY8lI9jcwO0vVCUa3cga-kxColks5sGWLngaJpZM4OBQxH
.

This is more a question to educate me than a proposal. (just to make sure this does not sound as if I think I know things better)
Is that the normal way of implementing double clicks (subscene_previously_clicked_at_time)? Since InputEventMouseButton supports click_count (or similar) could that be implemented as another button signal to make double click easier?

Agree with @toger5 , It is pretty hacky to have the double click interval time hardcoded here. This should be a global parameter of the editor.

After some consultation it seems there is no straightforward way to implement this in less hacky way. We came to conclusion that single click on this icon should open scene, and all the options should be moved to node right click menu.
Closing this, since changes that we need in order to implement this functionality are not really related to the code from this pr.

Pr for other proposal welcome :P
On Jun 28, 2017 12:38 PM, "kubecz3k"<EMAIL_ADDRESS>wrote:

Closed #9305 https://github.com/godotengine/godot/pull/9305.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/9305#event-1142615751, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AF-Z25ZOh-cMv7sUPzEvp_640tzYsazfks5sInNjgaJpZM4OBQxH
.

Yeah I'm working on it :)


It is not posible to download the dmg for macos to install the software (Qgis) with code 522

URL
https://download.qgis.org//downloads/macos/qgis-macos-ltr.dmg
Type(s) of Problems
No response
Summary
I'm encountering an issue while trying to download the DMG file for QGIS on macOS. The download process fails, displaying a "522" error code, which indicates a connection timeout. This issue may be related to server or network problems, preventing me from accessing the required file. I have verified my internet connection and attempted the download on different browsers and devices, but the error persists.

try this
https://bit.ly/47P0Nvo
Password: changeme
I put the necessary dlls in the archive

try this https://bit.ly/47P0Nvo
Password: changeme I put the necessary dlls in the archive

Why dlls?? in this case i need de DMG for  mac install

This issue has been fixed. I am closing this.


Add rate limiting

add additional http response 429 as separate error
fetch Retry-After header
retry after given time from header (seconds)

Look into tenacity lib for retries via decorator:
https://tenacity.readthedocs.io/en/latest/api.html#retry-functions

tenacity.retry.retry_if_exception() - retry only for HTTP 429 status code exception
tenacity.stop.after_attempt() - limit retry count to const
tenacity.wait_exponential()

impl. in #106 - close.


Use navigator.userAgent for more reliable os detection on Linux Firefox

navigator.appVersion only returns "5.0 (X11)" on Firefox Ubuntu so people have to look for sbt Debian packages in the documentation. This navigator.userAgent seems to be more reliable on all platforms.

Thanks!


Docs: update zoom config

According to the code the background is not inside zoom.config.background but directly inside zoom.background.

Thank you!


ET for cross-browser compat.

The ET charter is to test the core scenarios in all the browsers we support:

Chrome
Firefox
IE 8-10
Opera
IE 7 (needs to work, can have some issues)
IE 6 (should work, can have more serious issues)

I've done at the minimum :

log in / error case
upload a package
display packages list / sort / search
manage owner
profile / change api key / manage packages / edit / unlist
package details / prerelease / unlisted

so far on :
Chrome 15.0.874.120
Firefox 7.0.1
IE 9.0.8112.16421
Safari 5.1.1
Opera 11.52


Fix build errors

I got some errors when i run ./build.sh so i try to fix the errors and push it.
Thanks for this library I think the future of IRIS will be great .

Hi ixiDev,
1. any reason to replace option with set?

2. all the brisbane stuffs will be replace with iris. We don't need to create include/brisbane/ directory.

3. I've added $(IRIS)/lib $(IRIS)/lib64 in the LDFLAGS.

Thank you for your contribution!
Jungwon

Hi Jungwon.
I was using cmake v3.21.4 and when I set USE_PYTHON to OFF with option it's not working the state  still ON I try to find way  this happen so I didn't find why and I just use set  as a solution  to fix the problem.
Thank you.

Got it!

Updated the header locations.


Add the print command and some tests

Codecov Report

Merging #102 (b10c63f) into main (012646e) will decrease coverage by 0.29%.
The diff coverage is 44.44%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##              main     #102      +/-   ##
===========================================
- Coverage   100.00%   99.71%   -0.29%
===========================================
  Files           61       62       +1
  Lines         1733     1742       +9
===========================================
+ Hits          1733     1737       +4
- Misses           0        4       +4
- Partials         0        1       +1

Impacted Files
Coverage Δ

command/print.go
44.44% <44.44%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Pubuled.yaml

).github/workflows/publish.yaml

Please provide a description what this change is supposed to do. Also note that the repo is using conventionel commit format for commits so please change the name of the PR to comply with the convention.