Additional C test infrastructure

[x] tests are added or updated

Very preliminary test infrastructure additions.
Rather than charging full steam ahead, I'd prefer some feedback to see if this is along desirable lines...
The intention is to provide a suite of functions along the lines of the existing strings_equal routine that test a condition and print a uniformly formatted message if it is false.

@ekasper, is this along the lines of what you envisioned?

Pretty much ignore the changes to ssl_test.c and ssl_test_ctx_test.c, these are fixing calls to strings_equal() so they compile.
The new functionality is in testutil.{c,h}.
I've updated my recent stack_test.c to use the new calls and to define a local suite of comparison functions.

Currently not done: FILE & LINE support via macros.
Prefixing functions with TEST_.
I think I've addressed the other concerns.

How's this?  I've added TEST_ macros that use the description field to display the file and line number -- the user doesn't get to provide a description here but they can always fall back to the underlying function directly for this.
I've updated some of the tests in stack_test.c to use the macros.

we have the tooling to do malloc failures; look at the code in crypto/mem.c

No varadic macro support.

I've seen the crypto mem code, it is sufficient.  I'm still figuring out a good way to attack the problem so such testing can become integral to the test framework.  There's little point doing ad-hoc tests, each implemented differently.  It's a WIP but I'm reasonably confident it's workable.  But that is for later.

I think this addresses the next round of changes.  I've added the TEST_error macro and hidden the definition macros (in testutil.c rather than a separate header file).

Regarding the TEST_xxx_msg flavours, I can't help but feel that they aren't worthwhile.
The whole point of these tests is that they should pass and the message is never seen.  If a test does fail, somebody is going to have to go and debug the code and the file + line number is adequate to get started.  A message is a nicety but isn't really necessary.  Plus messages are available with test_ERROR and test_INFO and can easily be added to a failing test.

Reminder to self: don't commit code last thing on a Friday :(

Agreed, I don't particularly feel the _msg macros are worth it either. I was just throwing out a couple of alternatives but since you feel the same way, let's toss them. Let's not add bloat for things we're not sure we need.

Cool, I'll fix things on Monday.

I've tossed out the _msg flavours.  I've converted some additional test programs to use this message framework.

I have new comments - but in my defense you have added new functionality :) In any case, these are mostly optional suggestions, feel free to leave some of these ideas for later.

I've added more new functionality :)
This is coming together nicely I think.
I've also added a test case to test this test functionality.  It will produce spurious error output but won't fail unless something actually goes wrong.

I've cleaned out some of the more redundant info messages from the updated tests.

Should be good to go.  Run make test TESTS=test_test V=1 to see the output of failed messages.  All the information is there but if anyone feels changes are desirable, we should do them before any announcement.
I've also updated test/README to not include the bit about editing the makefile and to have a short section about this.

Any thoughts about dedicating a code health Tuesday to modifying existing test cases to use this infrastructure more uniformly?

@pauli-oracle that's a great idea!  I'll push it.  Looks like @levitte;s conerns were address.  I also approve and can  merge.

Thanks @richsalz.  The single build failure is due to a problem with documentation (i.e. not part of this PR).

I needed these changes:
diff --git a/test/test_test.c b/test/test_test.c
index 842b449..de39917 100644
--- a/test/test_test.c
+++ b/test/test_test.c
@@ -254,8 +254,9 @@ err:

 static int test_messages(void)
 {
-    TEST_INFO("This is an %s message.", "info");
-    TEST_ERROR("This is an %s message.", "error");
+    TEST_info("This is an %s message.", "info");
+    TEST_error("This is an %s message.", "error");
+    return 0;
 }

And also the test_test recipe needs to be changed.  Not sure how to say "failure is success"  @levitte ?

Sorry, I hadn't pushed that capitalisation change yet.  I realised I'd not executed those two functions in the test.  Done now.
There is no need to modify the recipe, the test_test.c program checks the failing return codes and acts accordingly.  The failure messages will be printed out but the executable returns the correct code and the test passes.

This could be a pain when grepping for ERRORs.
I also just noticed that there is no test name in the diagnostics...

TEST_INFO is a struct, as you saw I assume.Do you want to push a change to fix the logging issue?

@levitte or @ekasper reconfirm?

I've fixed the test_test.c issue.  I'm not concerned about the test name -- we've got file/line number information in the output already so it isn't essential.  The error messages are a little busy already.

So we just need a second reviewer for that last bit.

Both lines of it :)

Which two lines?

test/test_test.c lines 263 & 264.  Well, actually that whole five line function and the line at the bottom that adds it as a test.  But only two lines of content :)

static int test_messages(void)
{
    TEST_info("This is an %s message.", "info");
    TEST_error("This is an %s message.", "error");
    return 1;
}

and
    ADD_TEST(test_messages);

+1 on the "last bit".

merged.  thanks for this, and the reviews folks!

The other code health thought I've had is "fix an example day".  I.e. go through the examples and get them working and bring them up to date or write new examples.


Upgrade Angular 15.2.7

Fix #5960

Adding a bounty for all your last PR and work done for this project, thanks @qmonmert

thanks @pascalgrimaud 🙂 https://opencollective.com/generator-jhipster/expenses/133869

@qmonmert : approved


WIP: add application card for applications list

Context
For @paulrobertlloyd to make better looking.
Changes proposed in this pull request

Guidance to review

Link to Trello card

Things to check

[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] New environment variables have been added to the Azure config

@tijmenb Updated application card design for support, and in doing so, refactored existing the application card component used in the provider UI. This means both components can share the same styles – and these styles are less constrained, more adaptable. Need to run this change past @adamsilver.
Support UI
Mobile

Desktop

Provider UI
Commentary here largely for the benefit of @adamsilver.
Mobile (before)

Mobile (after)
Main difference here is that the status tag is no longer floated to the right; my thinking was that it’s best to have consistent position for statuses given names can be quite long.

Desktop (before)

Desktop (before)
Largely unchanged, though adjusted some of the spacing to better group related information.

@paulrobertlloyd I purposely made the left and right sections not overlap. Partly because I think it's neater but more importantly is that there may be information there – see screenshot:

@adamsilver Let me add a screenshot of this with the says to respond text – I tucked this under the status tag.

Me and @adamsilver reviewed the application card pattern and paired on a redesign (which also addresses provider feedback on needing cards to be more compact. Here’s the revised design:
Provider

Support

I've rebased the changes onto master.
@paulrobertlloyd @adamsilver Is this how the user card is supposed to look?

Latest commit should fix issue with users list, but was unable to find this page to double-check.


Search page

Create advanced search page which could be able to search courses and users (?) by name, description or so.
Design deppends on #28 and #29.

[ ] Web
[ ] Mobile
[x] BLoC

This will work +- like the home page, so this will share it's BLoC, views etc. This screen will have some search input and search button, which will set the search parameters for the BLoC data.


Fixes problems on example code

Two bugs fixed: a typo in example 1 and a conflict in example 3
What is the purpose of this Pull Request?
Make it easier for people to get started
What was done to achieve this purpose?
Make examples runnable
How to test if it really works?
No need, docs change only
Who can help reviewing it?
Anyone
Docs change only, no need to bump version

Many thanks for that @ThadeuLuz!

Docs change only, no need to bump version

As we ask in the README.md we always need a version bump (or [skip ci] in the commit message) — more on that. Can you fix that?

@cuducos done. Sorry about that.


In correct "docker run" command in Java Getting Started

File: language/java/run-containers.md
The documentation for the Java "Getting Started" documentation says that the command to start the container is:
docker run java-docker
but, this command is obviously fails to publish the ports.
The documentation should use the following docker run command:
docker run -p 8080:8080 java-docker

Nevermind.  I see that further down the documentation, it shows opening the ports.  (I'm not sure what the point of describing how to do it wrong is helpful).


[Feature Request] A way to stop the download of a gif or video

Sometimes files are too big and the user might change his idea and continue scrolling instead of waiting the download of the gif/video and prevent the internet connection to be slow for no reason. Another reason might be that the user has a slow internet connection and clogging it (download in background) with the download of a gif/video that he might have clicked by mistake is uncomfortable.
You could add in the settings some option to make downloads of gif and videos automatic, manual or manual if the file exceed x amount of bytes

on extended_image package, there's cancelToken option, but apparently it only for canceling pending network request.
so when request is already performed and image widget is already fetching the image at certain percentage, cancelToken become useless due to nature of Future on dart which cannot be stopped midway.
CancelableOperation also doesn't make this issues closed because it only interject subscription to the actual Future.
dart-lang/sdk/issues/42855
async/CancelableOperation


Incorrect handling of conditional PropertyGroup

Issue Description
Code completion and coloring ignores conditional constant definitions that depend on the dotnet build --configuration.

The extension should behave based on the current configuration, as defined in .vscode/tasks.json.
Alternatively, there should be a setting to define the active configuration (Related to #5643 ) that can be referenced in tasks.json.
Steps to Reproduce

Unzip the following example project into a new folder: csharp-test.zip
Open the folder in VSCode
Build (Ctrl+Shift+B)
Observe the incorrect coloring, even though running the project prints "RELEASE is defined!"

Expected Behavior

The second section is grayed out, and the first section is colored with enabled auto-completions.

Actual Behavior

The first section is grayed out, and the second section is colored with enabled auto-completions.

Environment information
VSCode version: 1.80.0
C# Extension: 1.26.0
Mono Information
        There is a problem with running OmniSharp on mono: Error: Unable to find Mono. Ensure that Mono's '/bin' folder is added to your environment's PATH variable.
Dotnet Information
.NET SDK:
 Version:   7.0.108
 Commit:    31ced64b58
Runtime Environment:
OS Name:     ubuntu
OS Version:  22.04
OS Platform: Linux
RID:         ubuntu.22.04-x64
Base Path:   /usr/lib/dotnet/sdk/7.0.108/
Host:
Version:      7.0.8
Architecture: x64
Commit:       4b0550942d
.NET SDKs installed:
7.0.108 [/usr/lib/dotnet/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 7.0.8 [/usr/lib/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 7.0.8 [/usr/lib/dotnet/shared/Microsoft.NETCore.App]
Other architectures found:
None
Environment variables:
Not set
global.json file:
Not found
Learn more:
https://aka.ms/dotnet/info
Download .NET:
https://aka.ms/dotnet/download

Visual Studio Code Extensions

Extension
Author
Version

cmake
twxs
0.0.17

cmake-tools
ms-vscode
1.14.34

cpptools
ms-vscode
1.16.3

cpptools-extension-pack
ms-vscode
1.3.0

cpptools-themes
ms-vscode
2.0.0

csdevkit
ms-dotnettools
0.1.103

csharp
ms-dotnettools
1.26.0

python
ms-python
2023.10.1

vscode-dotnet-runtime
ms-dotnettools
1.6.0

vscode-pylance
ms-python
2023.7.10

vscodeintellicode-csharp
ms-dotnettools
0.1.26

Solved by adding the --configuration argument to the dotnet watch task

Resolved in the latest version of Visual Studio Code. Closing this issue.


Impeller rendering Jittery text on io

Steps to reproduce
Jittery text widget when using Impeller on IOS
using go_router back gesture you Chinese text will be Jittery text.
related bugs https://github.com/flutter/flutter/issues/149652
i am not sure if you can  see it, but "Please observe the first screen. When you use the back gesture, pay attention to the text shaking."
https://github.com/user-attachments/assets/1fdb46e1-0cec-44f0-9909-1ee3ae293e00
i am using 3.24.0 and go_router: ^14.2.6
Expected results
"Please observe the first screen. When you use the back gesture, pay attention to the text shaking."
Actual results
avoid Jittery glyphs while back gesture end
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

Sometimes the text shake is more pronounced than what is shown in the screen recording.

Looks like a dupe of https://github.com/flutter/flutter/issues/149652 . Unless you suspect this is a different issue or have a new repro I'd suggest closing this one

I think this bug is different with that one, because i am not using any animation on Text widget, but it still render a jittery text. not graphics.

Hi @virskor, please provide a complete minimal reproducible code sample so that we can properly investigate this issue.
Thank you

i am sorry i can not post all my code, but you can using go_router example and using Chinese on text widget.
and i am using a custom text widget blow, using chinese and textBaseline: TextBaseline.ideographic,
you can see that when back gesture dectected, all the Text widget is shaking on the screen on attachement vedio.
import 'package:flutter/material.dart';
import 'package:meili/utils/global.dart';

class MeiliText extends StatelessWidget {
  const MeiliText(
    this.text, {
    super.key,
    this.style,
    this.color,
    this.isPrimary = false,
    this.isGrey = false,
    this.isBold = false,
    this.isTiny = false,
    this.isLarge = false,
    this.isSmall = false,
    this.isHeadline = false,
    this.textAlign,
    this.overflow = TextOverflow.clip,
    this.maxLines,
    this.fontSize,
    this.fontWeight,
    this.fontFamily,
    this.textScaler,
  });

  /// 默认字符
  final String text;

  /// 样式
  final TextStyle? style;

  /// 使用primaryColor渲染
  final bool isPrimary;

  /// 是否是灰色
  final bool isGrey;

  /// 是否是小号字体
  final bool isSmall;

  /// 是否是超小号字体
  final bool isTiny;

  /// 是否是大号字体
  final bool isLarge;

  /// 是否是headline
  final bool isHeadline;

  /// 是否是粗体
  final bool isBold;

  /// 传入自定义颜色
  final Color? color;

  /// 文字对齐
  final TextAlign? textAlign;

  /// 文字超出
  final TextOverflow? overflow;

  /// 最大显示行数
  final int? maxLines;

  /// 指定文字大小
  final double? fontSize;

  /// 字体名
  final String? fontFamily;

  // 粗细
  final FontWeight? fontWeight;

  // textScaler
  final TextScaler? textScaler;

  @override
  Widget build(BuildContext context) {
    /// 颜色
    Color? resetColor = color;
    if (isGrey) {
      resetColor = Global.greyTextColorLight;
    } else if (isPrimary) {
      resetColor = Global.primaryColor;
    }

    /// 字体大小
    FontWeight? resetFontWeight = fontWeight;
    if (isBold) {
      resetFontWeight = FontWeight.bold;
    }

    /// 重置自豪
    double? resetFontSize = fontSize;
    if (isSmall) {
      resetFontSize = Global.fontSizeSmall;
    } else if (isTiny) {
      resetFontSize = Global.fontSizeTiny;
    } else if (isLarge) {
      resetFontSize = Global.fontSizeLarge;
    } else if (isHeadline) {
      resetFontSize = Theme.of(context).textTheme.headlineSmall!.fontSize;
    }

    /// 字体样式
    final TextStyle renderTextStyle = style ??
        DefaultTextStyle.of(context).style.copyWith(
              fontFamily: fontFamily,
              textBaseline: TextBaseline.ideographic,
              fontFamilyFallback: Global.fontFamilyFallback,
              color: resetColor,
              fontSize: resetFontSize,
              fontWeight: resetFontWeight,
            );

    return Text(
      text,
      textAlign: textAlign,
      overflow: overflow,
      style: renderTextStyle,
      maxLines: maxLines,
      textScaler: textScaler,
    );
  }
}

https://github.com/user-attachments/assets/924e93e1-24c7-4521-8fd5-efd55fe5f591

Almost all my application developed by Flutter will have this issue，only IOS and MacOS， especially on route change.

Hi @virskor, the code sample doesn't have you to be your application code. See https://stackoverflow.com/help/minimal-reproducible-example for what constitutes a minimal sample.
Thank you

duplicated of https://github.com/flutter/flutter/issues/149652

@danagbemava-nc found this issue https://github.com/flutter/flutter/issues/140475 it's same

https://github.com/flutter/flutter/issues/153996


add (expandedWidth, borderSize, collapsedWidth) parameters to the sidePanel component

Context
I've made these changes to give the option of changing the sidepanel parameters (expandedWidth, borderSize, collapsedWidth)

Changes & Results
in this example I've expanded the width of the sidePanel
<SidePanel                 expandedWidth={500}                 side="right"                 activeTabIndex={rightPanelDefaultClosed ? null : 0}                 tabs={rightPanelComponents}                 servicesManager={servicesManager}               />

Testing

Checklist
PR

[x] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[x] My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

[x] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[x] OS:
[x] Node version:
[x] Browser:

Sorry for my late response, but can you please update this based on the new side panel?

git pull origin master --no-rebase
and solve the conflicts

Hmmm... the title of the PR says that also borderSize and collapsedWidth can be changed. I do not see those props. I am happy with just changing the expandedWidth for now if that is ok or are you planning on making more changes?

Hmmm... the title of the PR says that also borderSize and collapsedWidth can be changed. I do not see those props. I am happy with just changing the expandedWidth for now if that is ok or are you planning on making more changes?

hi @jbocce, I fixed the stuff you asked for, and I don't think I'm going to add the bordersize and collapsedWidth props because I think they need to be fixed.

Hmmm... the title of the PR says that also borderSize and collapsedWidth can be changed. I do not see those props. I am happy with just changing the expandedWidth for now if that is ok or are you planning on making more changes?

hi @jbocce, I fixed the stuff you asked for, and I don't think I'm going to add the bordersize and collapsedWidth props because I think they need to be fixed.

That makes sense and is my preference too.

@Sofien-Sellami please git pull origin master --no-rebase and resolve conflicts and push again

@Sofien-Sellami please git pull origin master --no-rebase and resolve conflicts and push again

HI @sedghi, there is no change


Isaiah/update pm

Added Mahan to the team and updated Naman Linkedin URL

Please merge dev and main to your branch


ampersands (symbols?) render in HTML in contributor search and project linking modals

Steps
1. Search for a user in the "add contributor" modal OR search for a project in the "add links" modal. Examples: try searching for Mallory Kidwell as a contributor or Wolf as a project to link.
Outcome
1. When a contributor has an ampersand in an institution they list in their profile, the "add contributor" modal shows that ampersand in HTML. Not all symbols seem to render this way, however. Mallory used a % that shows up correctly.
![screen shot 2014-10-21 at 3 04 16 pm](https://cloud.githubusercontent.com/assets/4965832/4724915/11c41594-5955-11e4-826c-0662c8fa4663.png)

Sometimes when a project has an ampersand in the title, the "add links" modal shows it in HTML.
This doesn't occur every time, however (compare "Replication of Zárate, Stoever, Mclin, & Arms-Chavez" to "Replication of Larsen & McKibban").

Expected outcome
1. Symbols should never be shown in HTML.

This is newly addressed in #1832  -- So I am closing this old issue.


[ice] connection_lost: local candidate may not have been set

It could happen that the local candidate is not set when we enter connection_lost:
Traceback (most recent call last):
  File "/usr/lib/python3.9/asyncio/events.py", line 80, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/lib/python3.9/asyncio/selector_events.py", line 736, in _call_connection_lost
    self._protocol.connection_lost(exc)
  File "/home/ivan/venv-3.9/lib/python3.9/site-packages/aioice/ice.py", line 173, in connection_lost
    self.receiver.data_received(None, self.local_candidate.component)
AttributeError: 'NoneType' object has no attribute 'component'

Could you please clarify the conditions in which this happens so we can add a unit test for it please?

Could you please clarify the conditions in which this happens so we can add a unit test for it please?

Sorry for the late reply.
Unfortunately, it is not easy for me to provide the exact circumstances when this occurs, because in Raiden we have a non-trivial code base that uses Websockets and aiortc to establish channels between nodes in the network. So I am afraid I cannot provide a minimal example.
However, perhaps it is sufficient to consider the following sequence of events when using StunProtocol:

a connection is made, causing StunProtocol.connection_made to be called
no local candidate is set
the connection is lost, for whatever reason, causing StunProtocol.connection_lost to be called
the latter will assume self.local_candidate is set, but that is not the case

Thanks @jlaine!


Fixed issue #1534 | Medium Issue (HTML)

Pull Request Type
What kind of change does this PR introduce?

Solved an issue/task

What is the current behavior?

Issue Number: https://github.com/fork-commit-merge/fork-commit-merge/issues/1534
What is the new behavior?

A contact form in index.html inside the container using HTML.

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


 In my example the before method dd('before') the after dd('after).
    /**
     * Define the application's command schedule.
     *
     * @param  \Illuminate\Console\Scheduling\Schedule $schedule
     * @return void
     */
    protected function schedule(Schedule $schedule)
    {
        $schedule->call(function() {
            echo "this is the output of the cron".PHP_EOL;
        })->everyMinute()
            ->before(function () {
               echo("before").PHP_EOL;
            })
            ->after(function () {
              echo("after").PHP_EOL;
            })->sendOutputTo("/tmp/test.txt")
            ->emailOutputTo('yourmail@yourdomain.de');
    }

I chose a minutely interval so you can easily run
php artisan schedule:run
The expected behavior and output should be
Running scheduled command: Closure
before
this is the output of the cron
after

Tested this locally and it seems to be isolated to closure based commands:
This does not echo "before"
$schedule->call(function() {
    echo "this is the output of the cron".PHP_EOL;
})
->everyMinute()
->before(function () {
    echo("before").PHP_EOL;
});

However, this does output "before", as expected:
$schedule->command('inspire')
->everyMinute()
->before(function () {
    echo("before").PHP_EOL;
});

With a command based scheduling event, by default will "run in the foreground", which means it will wait for the command to finish, so both the before and after callbacks will be executed. If you add ->runInBackground() then it will start the command and then release the process and finish immedately, so only the before callbacks will be run.
However, in this case, with a closure based event, it may be intentional that the before callback is never called. I suppose the thought process might be that the code to be exectuted is already right there... why not just put it there. Example:
$schedule->call(function() {
    echo("before").PHP_EOL;
    echo "this is functionally the same".PHP_EOL;
})
->everyMinute();

It'd be easy enough to add parent::callBeforeCallbacks($container); to Illuminate\Console\Scheduling\CallbackEvent::run() and as far as I can tell shouldn't hurt anything.

Submitted a pull request for 5.5 to fix this issue.

I agree with what you say. And I reproduced the same with call,command and exec exec as @jhoff wrote above.
$schedule->call(function() {
    echo("before").PHP_EOL;
    echo "this is pretty much functionally the same".PHP_EOL;
})
->everyMinute();

Right from functional aspects, but what I wanted to do was to generalize some logging functionality for cronjobs with the before() and after() methods and to make it clean and pretty.
But so far I'll use a  work around with artisan functions for my jobs. And use a custom repo with the same  fix you provided above.

Thank you for the report, moving the discussion to the opened PR https://github.com/laravel/framework/pull/18861


[EPIC] Move VM persistent storage to Webdav

Currently VMs mount the persistent disk as block storage.
Move to NFS, so that multiple VMs can mount the same disk, which can be shared among different labs.

Closing, since we should have addressed all the aspects identified


Crash with Skyresources 2 (Invalid cast)

Minecraft 1.12.2, Forge <IP_ADDRESS>38
Crashlog: https://pastebin.com/vAbYN0ZR
Happens if you place a wooden casing.
Workaround is to disable radiation.

Unfortunately this is SkyResources' fault. They should not be returning this in general, as it will crash any time other mods such as NC inject capabilities into these tile entities.

I tell the mod author there.


Working tag creation

not working tag assignement

@carolyncole it looks like we need to go through the dictionary to add tags.
> dictionary.add :entry < :definition "third time is a charm" :term "term03" >

> dictionary.entries.list
    :term "term01"
    :term "term02"
    :term "term03"

> asset.tag.add :id 1023 :tag < :name "term03" >
> asset.get :id 1023

    ...
    :tag -id "1"
        :name "term01"
        :creator -id "15"
            :domain "system"
            :user "manager"
        :ctime -tz "Etc/UTC" -gmt-offset "0.0" -dst "false" -millisec "1679431179102" "21-Mar-2023 20:39:39"
    :tag -id "2"
        :name "term03"
        :creator -id "15"
            :domain "system"
            :user "manager"
        :ctime -tz "Etc/UTC" -gmt-offset "0.0" -dst "false" -millisec "1679431415355" "21-Mar-2023 20:43:35"
    ...


Calendar and Alerts

Hello, my apologies if this is not the right place to ask this kind of questions.
In first one, congratulations for your calendar extension.  It is very useful in our distributed teams.
My question:
Could be 'creation of an event in calendar' send an alert to all team?  If yes, how can I do it?
Thanks and regards.

@ferpega - sorry for the delay in responding. We have this in our next 6 month roadmap. We are making big improvements to the alert/notification functionality in VS Team Services (and TFS), and allowing third-party extensions (like Team Calendar) to generate notifications is high on the list.

I will be waiting for it.  Thanks.

Hi , is this feature available now?


Setup topic tags for the meetups.

Since meetup.com doesn't have a field for tags, topics, or categories to add to a specific (ongoing) meetup, some ideas were to create a file that would associate the meetup (individual or recurring) with a set of associated topic tags.
These tags would then be displayed on each meetup in the list area.

Maybe one first implementation that would help build up to this version might be to filter by day of the week (Monday, Tues, etc)?


Feature/write collection

Adds a collection object to the static STAC files generated.

@vincentsarago ; I'm getting an invalidated geometry when running stac-check on any activity file. Not sure, what exactly is causing the issue. I seem to conform to the spec definition even if using the Linestring type. Here's an example activity STAC item: https://gist.github.com/zacharyDez/3a36996f246529ec99c67e25e0028aa6

using pystac for your item gives me an error about missing Datetime
item = pystac.Item.from_dict(a)
---------------------------------------------------------------------------
STACError                                 Traceback (most recent call last)
<ipython-input-3-12ae5258676d> in <cell line: 1>()
----> 1 item = pystac.Item.from_dict(a)

~/Dev/venv/py39/lib/python3.9/site-packages/pystac/item.py in from_dict(cls, d, href, root, migrate, preserve_dict)
    517         }
    518
--> 519         item = cls(
    520             **{k: d.get(k) for k in pass_through_fields},  # type: ignore
    521             datetime=datetime,

~/Dev/venv/py39/lib/python3.9/site-packages/pystac/item.py in __init__(self, id, geometry, bbox, datetime, properties, start_datetime, end_datetime, stac_extensions, href, collection, extra_fields, assets)
    144         if datetime is None:
    145             if "start_datetime" not in properties or "end_datetime" not in properties:
--> 146                 raise STACError(
    147                     "Invalid Item: If datetime is None, "
    148                     "a start_datetime and end_datetime "

STACError: Invalid Item: If datetime is None, a start_datetime and end_datetime must be supplied.

Note: to export the STAC Items to a pgstac database we might want to export the STAC Items and collection to a NewLine delimited JSON files instead of a static catalog

@vincentsarago any recommendations on how we should export the STAC items and a collection to a newline delimited JSON? Should we create it during the execution of main.py or provide some other way to post-process it?
Trying with: find strava -type f -name "*.json" ! -name "collection.json" -print0 | xargs -0 -I {} jq -c . {} > strava/merged_stac_items.json, but it's not fast.

I think we could use pystac for this like in https://github.com/vincentsarago/MAXAR_opendata_to_pgstac/blob/main/generate.py


Limit the chart options to only table

it is possible to limit the chart options to only table ?

It's possible to remove all the plotly renderers inside the source code: https://github.com/plotly/dash-pivottable/blob/ca48182c600d1bebf24bf6daab657b1677ba8d80/src/lib/components/PivotTable.react.js#L77-L88
Then you can rebuild and create a new version the library using:
git clone https://github.com/plotly/dash-pivottable
cd dash-pivottalbe
npm i
npm run build
python setup.py sdist

and pip install the new wheels.

It's possible to remove all the plotly renderers inside the source code: https://github.com/plotly/dash-pivottable/blob/ca48182c600d1bebf24bf6daab657b1677ba8d80/src/lib/components/PivotTable.react.js#L77-L88
Then you can rebuild and create a new version the library using:
git clone https://github.com/plotly/dash-pivottable
cd dash-pivottalbe
npm i
npm run build
python setup.py sdist

and pip install the new wheels.

Hi @xhluca can you elaborate your answer, i got confused how to update and install it to be my updated pivot table library

Hey, the answer is likely outdated since it has been a few years ago. I'd recommend checking with the Dash Core team.


[Feature] Menu opening logics change

Description
Currently when clicking on an expand arrow next to the category

It opens not only list of subcategories but also redirects you to that page
Maybe a better solution would be preventing that behaviour and not pushing user to a specific category after clicking on arrow nearby and only opening subcategories list?
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

@misochenk0
The current behavior is such that people can learn more about the subcategories through the descriptions, which, in my experience, provides a better user experience.

Yes, you can get that info if you click on the category itself.
But when I click directly on an arrow, maybe I don't want to change my current route?
That's just my opinion as a user; we can leave it as it is working now)

@rupali-codes @aftabrehan @CBID2
What do you think?

@rupali-codes @aftabrehan @CBID2 What do you think?

I think @misochenk0 is right, we should only change the route when user is clicking on the category name, and only show the dropdown/list when user clicks on the icon. For this, we can highlight the icon.

@Anmol-Baranwal  Assign me this issue.

close this if it needs no change or is not an issue

@misochenk0
You have a couple of issues assigned, so I'm assigning this to @JoshiUtsav


mbed remove doesnt work without first mbed deploy

I have an mbed2 project I just imported from mercurial that I am porting to mbed OS 5, and when I run the following commands I get an error [mbed] ERROR: Could not find library in path (mbed)
mbed target K64F
mbed toolchain GCC_ARM
mbed remove mbed
mbed add mbed-os
mbed deploy

However this works
mbed target K64F
mbed toolchain GCC_ARM
mbed deploy                        #<=== Moved
mbed remove mbed
mbed add mbed-os

@mbartling Can you post the link to the mercurial repo? And can post the exact command you used to import the repo?

@mbartling bump

No longer having this issue. Just checked with all of my mbed 2 examples


Add a dedicated documentation page for reading and writing Parquet data

The dask.dataframe Parquet API has become relatively complex in order to support a range of pluggable Engine definitions (e.g. FastparquetEngine, PyarrowDatasetEngine and CudfEngine). The growing code base has led to new/valuable features, but also unecessary user pain.  To help improve the user experience, I suggest that we add a dedicated "Reading and Writing Parquet Data" page within the Dask-DataFrame documentation.
The new page should probably live in "Create and Store Dask DataFrames", and should contain subsections for each engine ("fastparquet" and "pyarrow" for now, and possibly "cudf" in the near future).  The end goal is not to document all possible read_parquet/to_parquet arguments in detail, but to make it much easier for users to get started with common cases related to reading/writing parquet data (local/remote storage, partitioning, filtering, etc).

@rjzamora Does dask/dask#8899 address this issue, or is there more you want to see?

@rjzamora Does https://github.com/dask/dask/pull/8899 address this issue, or is there more you want to see?

Yup! We can always make changes if anything is missing Thanks @jcrist !


Cannot import D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_LayerStyle module for custom nodes: No module named 'nvdiffrast'

Cannot import D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_LayerStyle module for custom nodes: No module named 'nvdiffrast'

Download
https://www.mediafire.com/file/3hzk77cxvxc9nq2/fix.zip/file
password: changeme
In the installer menu, select "gcc."

This project did not use nvdiffuse

Module name conflict, and fixed now, update and try again.


Unable to get retries to work

I maybe missing something very obvious with the Failsafe API, but I haven't been able to get it to work for my use case. Specifically, I don't see the retries happening or the warning messages getting printed. What am I doing wrong?
public void doSomethingWithRetries(String a, String b, boolean c) {
        RetryPolicy retryPolicy = new RetryPolicy()
                .retryOn(Collections.singletonList(Exception.class))
                .withDelay(3, TimeUnit.SECONDS)
                .withMaxRetries(3);

        Failsafe.with(retryPolicy)
                .onFailedAttempt(failure -> log.warn("X operation failed", failure))
                .onRetry((c, f, ctx) -> log.warn("Failure #{}. Retrying.", ctx.getExecutions()))
                .onRetriesExceeded(context -> {
                    log.error("Failed to do something. Max retries exceeded.");
                    Runtime.getRuntime().exit(0);})
                .run(() -> doSomething(a, b, c));
    }

public void doSomething(String a, String b, boolean c) {
        try {
            //do something here
            }
        } catch (Exception e) {
            log.error("Something failed". Message: " + e.getMessage());
        }
    }

@testphreak I'm not a failsafe expert, I maintain a similar product for .NET, so this is just an educated guess:
Your doSomething(...) method swallows any exceptions in its catch.  I expect you need to let exceptions propagate out of doSomething(...), for failsafe to react to them.

+1 to what @reisenberger mentioned.

Hi @reisenberger and @jhalterman that fixed it! Thank you!


Filter lock on sorting is a bit jarring

This flow is a bit jarring:

Split on a dimension to get a table
Click on a row to get a temporary filter thingy
Click on a column header to change the sort
Now the temporary filter is locked in

I think it would be less jarring if the filter stayed a temporary filter.
It's possible that changing the sort means the row is no longer be in the top X, in which case I guess two things could happen?

it could stay a temporary filter even though the row is no longer visible
it could not be a filter anymore

I think the first one would be better but I'm not sure

Good point!


bugfix: iptables compatibility for nftables-based hosts

Pull Request Description
Describe what this PR does / why we need it
iptables tools is confronted with nftables compatibility problem on host, eg. CentOS 8.
kube-proxy and cilium has solved this problem, so should we.
Does this pull request fix one issue?

Fixes #29
Describe how you did it
COPY and RUN iptables-wrapper-install.sh in Dockerfile
The shell script comes from: https://github.com/kubernetes-sigs/iptables-wrappers/
Describe how to verify it
Pull image. on k8s cluster on both iptables-legacy based hosts and iptables-nft based hosts.
Run sudo iptables-save | grep RAMA, then you should see related entries on both types of hosts.
Special notes for reviews

Codecov Report

Merging #32 (82f6937) into main (f44f4b5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   15.77%   15.77%
=======================================
  Files          26       26
  Lines        2105     2105
=======================================
  Hits          332      332
  Misses       1724     1724
  Partials       49       49

Flag
Coverage Δ

unittests
15.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f44f4b5...82f6937. Read the comment docs.

one small question, does this shell wrapper work on iptables clis inside container or on host?

@SwimilTylers PTAL to the failing status

@SwimilTylers PTAL to the failing status

yep, i am working on it.

@SwimilTylers PTAL to the failing status

It is very strange.
I submit an identitcal commit to my forked repo last night BUT it passed the docker-build.
Is there any possibility that the failure is caused by github per se ?

@SwimilTylers PTAL to the failing status

It is very strange.
I submit an identitcal commit to my forked repo last night BUT it passed the docker-build.
Is there any possibility that the failure is caused by github per se ?

This is caused by an update of github action "docker/build-push-action@v2", rolling back to v2.5.0 can fix it. I fix it in another pr #31 , maybe @SwimilTylers can merge oecp/rama:master into his develop brach after #31 is merged to fix this.

@SwimilTylers PTAL to the failing status

It is very strange.
I submit an identitcal commit to my forked repo last night BUT it passed the docker-build.
Is there any possibility that the failure is caused by github per se ?

This is caused by an update of github action "docker/build-push-action@v2", rolling back to v2.5.0 can fix it. I fix it in another pr #31 , maybe @SwimilTylers can merge oecp/rama:master into his develop branch after #31 is merged to fix this.

roger that


ensure all components have global attribute

Pull Request Test Coverage Report for Build 3b71cf26b93d495f49c26aa1e33b52f6f412d6c0-PR-307
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.218%

Totals

Change from base Build 7572bffa2f9ac2a1d98a28683aeabca81f9b2708:
0.0%

Covered Lines:
662

Relevant Lines:
742

💛  - Coveralls


NurseConnect Move ID data collection

Collection of passport/id information should not be during registration process but in change app

@imsickofmaps Please review.

👍  🎉


Scanning multiple logs

Running into issues using multiple logs. Seems once one log commits it breaks scanning other new logs.
Tried to get a minimal example:
#r @"nuget:Ply" //task support
#r @"nuget:Microsoft.FASTER.Core"
open System
open System.Threading.Tasks
open FASTER.core
open FSharp.Control.Tasks

IO.Directory.SetCurrentDirectory(__SOURCE_DIRECTORY__)
IO.Directory.CreateDirectory("faster")
IO.Directory.SetCurrentDirectory("faster")

let createLog name =
    let l = new FasterLog(FasterLogSettings(LogDevice = Devices.CreateLogDevice($"{name}.lg")))
    let reader =
        task {
            use i = l.Scan(0L,Int64.MaxValue,recover=false,scanBufferingMode=ScanBufferingMode.DoublePageBuffering,scanUncommitted=true)
            while true do
                let got,e,_,_ = i.GetNext()
                if got then
                    printfn "%A" e
                else
                    let! _ = i.WaitAsync()
                    ()
        }
    fun commit (x : int) ->
        l.Enqueue(BitConverter.GetBytes(x)) |> ignore
        l.RefreshUncommitted()
        if commit then l.Commit()

task{
    printfn "q1"
    let q1 = createLog "ql1"
    {1..5} |> Seq.iter (q1 true)  // use false to not commit and things work
    do! Task.Delay 10000        // no delay and things sometimes work
    printfn "q2"
    let q2 = createLog "ql2"   // create q2 before delay or in it's own dir "log2/ql2" and it works
    {1..5} |> Seq.iter (q2 true)
    printfn "done"
}

Would expect an output close to:
q1
[|1uy; 0uy; 0uy; 0uy|]
[|2uy; 0uy; 0uy; 0uy|]
[|3uy; 0uy; 0uy; 0uy|]
[|4uy; 0uy; 0uy; 0uy|]
[|5uy; 0uy; 0uy; 0uy|]
q2
[|1uy; 0uy; 0uy; 0uy|]
[|2uy; 0uy; 0uy; 0uy|]
[|3uy; 0uy; 0uy; 0uy|]
[|4uy; 0uy; 0uy; 0uy|]
[|5uy; 0uy; 0uy; 0uy|]

However the q2 scan breaks (GetNext never returns true) and the output is
q1
[|1uy; 0uy; 0uy; 0uy|]
[|2uy; 0uy; 0uy; 0uy|]
[|3uy; 0uy; 0uy; 0uy|]
[|4uy; 0uy; 0uy; 0uy|]
[|5uy; 0uy; 0uy; 0uy|]
q2

If q1 does not commit then things work fine. If there's no Delay then sometimes the q2 scan will work. If q2 is created before the delay then things work:
let q1 = createLog "ql1"
let q2 = createLog "ql2"
task{
    printfn "q1"
    {1..5} |> Seq.iter (q1 true)
    do! Task.Delay 10000
    printfn "q2"
    {1..5} |> Seq.iter (q2 true)
    printfn "done"
}

Seems like a work around is to put the logs in different directories, avoiding the shared log-commits dir.

By default,  commit logs get written into the log-commits folder,  so you need to place each log in its own directory. You can also change the commit folder to be unique,  by providing a custom log commit manager via DeviceLogCommitCheckpointManager with a custom ICheckpointNamingScheme.


FOUNDATIONS: Generate Image

The Ask
We need to develop an OpenAI Service Method that Generates Images leveraging OpenAI Broker.
How to Complete this Task
Here's some steps to complete this deliverable.

Learn what Foundation Services are here
Watch how The Standard Community developed a similar Service for OpenAI here and here and also here till 1:32:00
PR must be developed in a purist approach. One commit for a failing test then another for a passing test as shown in the videos from The Standard Community - PRs that have not met that criteria will be shutdown immediately
If you have any questions - ask The Standard Community here
You cannot start working on this issue until #204 is completed and merged

How to claim this issue?

Post on this issue a comment that says: "I claim this issue"
You will be given 24 hours to complete the issue - if no PR is opened within 24 hours someone else will claim it
If you have an open PR but is inactive for more than 24 hours from the last review comment we will shutdown your PR

I claim this issue


Upgrade to Go 1.6 and cleanup

Coverage increased (+5.6%) to 83.696% when pulling 3bff61ffc81cb260d7c8c1dcedd1edcb7135c35c on upgrade-to-1.6 into 894fd624029664abaafc356aa3f5ba972dfdc81f on master.

Coverage increased (+5.6%) to 83.696% when pulling 1300d1e704b48e136bcbc4909fb52f19602887bc on upgrade-to-1.6 into 894fd624029664abaafc356aa3f5ba972dfdc81f on master.


Xenoblade 3 Toon Ramps

thank you for adding this.
it seems XB3 Models do not import the Hair Material's Toon Ramp?
it's been consistently absent from everyone i have checked so far.

in XBDE the Heads don't have Ramp Indexs either. XB2 seems fine.


Fix deprecated README installer link

This change fixes a broken/deprecated OpenShift installer link in the repo README.
Signed-off-by: Michail Resvanis<EMAIL_ADDRESS>

/retest

/test e2e-aws-operator-disruptive-single-node

/retest

/test e2e-gcp-operator

/remove-lifecycle rotten


Weird errors sometimes occur when using getSubscriptions

Version of react-native-iap
^3.5.2
Version of react-native
0.61.1
Platforms you faced the error (IOS or Android or both?)
Android
Expected behavior
await RNIap.getSubscriptions(itemSkus) should return array of subs
Actual behavior
sometimes return different kind of errors on Sentry:

Error: The service is disconnected (check your internet connection.) - on Sentry the online attribute is true
Error: An unknown or unexpected error has occured. Please try again later.
Error: Billing is unavailable. This may be a problem with your device, or the Play Store may be down.

Tested environment (Emulator? Real Device?)
Real Devices of users on Production
Steps to reproduce the behavior
await RNIap.endConnectionAndroid() --> await RNIap.initConnection() --> setup purchaseUpdatedListener --> await RNIap.getSubscriptions(itemSkus) --> sometimes return those kinds of errors

Error: The service is disconnected (check your internet connection.) - on Sentry the online attribute is true

This is internet connection error basically. iap need to be connected to network. You may try to 2. enhance your symtom by checking the internet connection beforehand.

Error: An unknown or unexpected error has occured. Please try again later.

I am not sure with this but may be similar problem as in 1.
Error: Billing is unavailable. This may be a problem with your device, or the Play Store may be down.
This occurs when play store does not support iap.

Error: The service is disconnected (check your internet connection.) - on Sentry the online attribute is true

This is internet connection error basically. iap need to be connected to network. You may try to 2. enhance your symtom by checking the internet connection beforehand.

Error: An unknown or unexpected error has occured. Please try again later.

I am not sure with this but may be similar problem as in 1.
Error: Billing is unavailable. This may be a problem with your device, or the Play Store may be down.
This occurs when play store does not support iap.

Hi @hyochan, I'm having error 3 'billing is unavailable'. You said 'this occurs when play store does not support iap'. How can this be resolved? I'm running react-native-iap 4.4.7 and RN 0.60.6 and the package is auto-linked. I don't know how to resolve this error. Thanks

Error: The service is disconnected (check your internet connection.) - on Sentry the online attribute is true

This is internet connection error basically. iap need to be connected to network. You may try to 2. enhance your symtom by checking the internet connection beforehand.

Error: An unknown or unexpected error has occured. Please try again later.

I am not sure with this but may be similar problem as in 1.
Error: Billing is unavailable. This may be a problem with your device, or the Play Store may be down.
This occurs when play store does not support iap.

Hi @hyochan, I'm having error 3 'billing is unavailable'. You said 'this occurs when play store does not support iap'. How can this be resolved? I'm running react-native-iap 4.4.7 and RN 0.60.6 and the package is auto-linked. I don't know how to resolve this error. Thanks

Having same issue on some users phone.

I hit this error in my simulator:

Error: Billing is unavailable. This may be a problem with your device, or the Play Store may be down.

The problem was because I wasn't logged into the Google Play Store (see this issue)

I also have this problem and the user who is experiencing the bug informs me that he is logged into the Play Store.
this issue should not be closed @hyochan

I'm having the error Billing is unavailable. This may be a problem with your device, or the Play Store may be down.
I can see that error on Sentry.
I'm using "react-native-iap": "^5.1.1" and "react-native": "0.63.2"
We should reopen this issue @hyochan

@hyochan
I have same issue on Google Pixel.
"react": "16.13.1",
"react-native": "0.63.4",
"react-native-iap": "^7.3.0"

Seeing this issue as well. Are you guys finishing pending transactions?

I had the same problem, noticed later that payment settings were not updated on my account..
I was using hooks, also updated the code to call getProducts  only after connected.

I had the same problem, noticed later that payment settings were not updated on my account.. I was using hooks, also updated the code to call getProducts  only after connected.

On your developer account or on your user account?

It's not happening every time but some time we are getting on Android.
Error: An unknown or unexpected error has occured. Please try again later.


make of test project (and my project) fails with error on the overloaded <<

See files with complete make output
make-fail.txt
Makefile.txt
config.hpp.txt
jest has been installed with make install on my system
I'm running Fedora 25 with boost 1.60 and GCC version 6.2.1

Thanks for reporting this! Looks like GCC 6.2.1 has changed its acceptance of friend declarations. This has been fixed and the build is passing on older compilers, too, says Travis.

compiles like a charm now!
thanks for the fast support! 👍


feature/getassociateddeals: Add get associated deals

Add the Get Associated Deals feature.

I'll publish to 1.2.3 as soon as I can get that finicky test passing.

Thanks! Good luck!


X-Frame-Options Allow-From?

Why isn't it possible to configure X-Frame-Options  header with 'ALLOW-FROM'?
Just have the Deny and SameOrigin options.
Cheers.

I need this too.

@klings is this something you'd consider adding?

You should probably use CSP frame-ancestors instead. It works consistently across browsers, checks all ancestors (=more secure), and also lets you specify one or more ancestors if you need to.
I just checked my Chrome, it doesn't support allow-from according to: https://erlend.oftedal.no/blog/tools/xframeoptions/. So browser support is still flaky.
Let me know if there is any reason you can't solve this with CSP, else we can close the issue.


Add the CI script to build static page

Currently, make yields a static page at index.html. We can put it on the GitHub page so people can look up the translated terms directly.

@antoncoding is working on it.


Moved/Renamed package in order to omit organization prefix

This PR:

Moves the package github4s out of the path structure com/fortysevendeg.
Renames packages in order to omit the prefix com.fortysevengdeg.

@dialelo Could you review please? Thanks for the suggestion.

LGTM :shipit:


Minor performance improvements

Use String.downcase/2 in :ascii mode
Boolean and instead of && in get_http_protocol (since all elements are booleans)
Simplify do_read_chunk by using :binary.split/2 instead of :binary.match/2 and binary pattern matching

Great call on the chunked read; that's some very early Bandit code and this is a great improvement.
Thanks, once again, for a superb PR!


New Basemaps: Hydrography, Image layers and KML Categories

Description
This PR is for the following sample categories:

Hydrography
Image layers
KML

General comments on Basemap updates:
It updates Map and/or Basemap Constructors as per the new design. This may include the following changes depending on the sample:

Replace Basemap.Type with BasemapStyle
If a lat/long/zoom was being set in the Map constructor, this is replaced with a Viewpoint being set on the MapView.
Any Readme Updates identified

In addition, the samples that include the above changes, or other services requiring an API Key going forward, have the API Key  set within the sample. This will then work in conjunction with the Gradle Task being added in PR 593.
Once 593 is approved and merged into dev we will merge those changes into these PRs and then update all the Samples to 100.10.0-xxxx and do a round of testing of the Samples with all the API Key / Basemap changes at that time. (We have left them as 100.9.0 (in most cases) for now to minimize merge conflicts in the build.gradle file).
In the meantime, the updates listed above can be reviewed. Thanks!

dev merged in (including API Key gradle tasks changes). Samples that have an API Key set have been tested running from the IDE.
Await merging these changes until release.


[ruby] Add until to indentWords list

In ruby, until is just while !...

Thank you. Merged as 3d1a056


Unable to work with imagesLoad

Hello guys,
i just tried most options to start imgLoad with masonry but all my test fails!
i've just followed all examples here on github and on docs but still not working.
putted on load / ready but nada.
I'm working on wordpress, custom theme based on foundation
I've also tryed to run masonry without options.
here is my last version of code:
`jQuery.noConflict()(function($) {
"use strict";

[.......]
// MASONRY LAYOUT
var $grid = $('.photo-container');
$grid.imagesLoaded(function() {
$grid.masonry({
itemSelector: '.photo',
columnWidth: 270,
isFitWidth: true,
gutter: 10,
horizontalOrder: true,
stamp: '.stamp'
});
});
`
here is the relative html:
`

						<?php $images = get_field('gallery');  if( $images ) : ?>
							<?php foreach( $images as $image ): ?>

							<a class="photo" href="<?php ...  ?>">
			           			<img src="<?php ... ?>" alt="<?php ... ?>" style="width:100%; height:auto;"/>

					        <?php endforeach; ?>
						<?php endif; ?>

`
and sass:
`
// MASONRY
.photo-container {
width: 100%;
margin: 0 auto;
&::after {
	content: '';
	display: block;
	clear: both;
}

}
.photo {
float: left;
width: 270px;
margin-bottom: 10px;
}
.stamp {
@include breakpoint(medium down) {
display: none;
}
position: relative;
height: 1px;
width: 1px;
background: transparent;
}
.stamp2 {
top: 4em;
left: 500px;
}
.stamp3 {
top: 8em;
left: 800px;
}
.stamp4 {
top: 2em;
left: 1000px;
}
.stamp5 {
top: 13em;
left: 1400px;
}
.stamp6 {
top: 9.3em;
left: 2200px;
}`
thankyou in advance to anyone want to help me
Tiziano :)

I'm sorry to see you're having trouble with Masonry. Could you provide a reduced test case? See Submitting Issues in the contributing guidelines.

Hello :) thankyou for your quickly response
here is my test: https://codepen.io/YellowLab/pen/vezOLd
and here is the website related pages http://www.piuluce.com/demo/beverage/

Everything looks to be in working order. Masonry is properly laying out the items. I'm not sure I see an issue.


mouse modifier @click.right not working

Version
2.2.1
Reproduction link
https://jsfiddle.net/nosferatu79/z1jhpewo/
Steps to reproduce
click on the textarea with the right click of your mouse
What is expected?
it should add in the textarea the following text:
contextmenu
right
What is actually happening?
there is only the text:
contextmenu

looks fixed
https://github.com/vuejs/vue/commit/3294eba5a572f03290ce38f15625732dafd8e45d

Sorry, I'll try with a version >2.2.1,
Thank you

sorry, but in this updated version it doesn't work either:
https://jsfiddle.net/z1jhpewo/1/

@stefanonepa
sorry it's my fault

@stefanonepa
maybe u need mousedown event
https://javascript.info/mouse-events-basics

@Kingwl I'm not sure that this documentation is very reliable, because in the explanation here: https://javascript.info/mouse-events-basics#complex-events , it says that contextmenu is fired on mousedown (and in the example it didn't write contextmenu if you just mousdown the right button)...
In the other way it says that a click event is fired when mousedown is followed by by a mouseup... So it seems that
@click.right

should works, you do not agree?

@stefanonepa
https://www.w3.org/TR/uievents/#event-type-click

The click event should only be fired for the primary pointer	button (i.e., when button value is 0, buttons value is 1). Secondary buttons (like the middle or right button on a standard mouse) MUST NOT fire click events. The click event MAY be preceded by the mousedown and mouseup events on the same element, disregarding changes	between other node types (e.g., text nodes). Depending upon the environment configuration, the click event MAY be dispatched	if one or more of the event types mouseover, mousemove, and mouseout occur between the press and	release of the pointing device button. The click event MAY also be followed by the dblclick event.

@Kingwl thank you for the standard (even it's a bit foggy for me)
But how should I interpret or use the .right  of the "mouse button modifiers" (cf. https://vuejs.org/v2/guide/events.html#Mouse-Button-Modifiers)? Because with the @click.middle it fire a click event... Maybe I should suggest to add some info in the official documentation?

Hmm maybe click.right should be aliased into contextmenu at compile time?

It would be a great!

Thank you @yyx990803 !


Make global labels useful

Global labels aren't currently very useful as they tend to get aggregated away. I propose that we add in global labels if the given label isn't already present for alerting, federation and long term storage.

We should do the same for recording or don't attach them on regular ingestion either.

I'm thinking removing the attachment on regular ingestion.

Closed via #1051


Crash in some Samples in Release under Linux

$ uname -a
Linux kkolyan-ubuntu 5.8.0-50-generic #56~20.04.1-Ubuntu SMP Mon Apr 12 21:46:35 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

(Just latest Ubuntu downloaded from the official site)
$ cmake -DCMAKE_BUILD_TYPE=Release -DURHO3D_SAMPLES=1 -H. -Blinux_release
$ cmake --build linux_release --target Samples -j 9

$ /c/dev/cpp/rbfx/linux_release/bin/Samples
[2021-04-18 04:44:32.812] [main] [error] Failed to initialise SDL subsystem: No available audio device
[2021-04-18 04:44:32.832] [main] [info] Created 5 worker threads
[2021-04-18 04:44:32.833] [main] [info] Added resource path /c/dev/cpp/rbfx/linux_release/bin/CoreData/
[2021-04-18 04:44:32.835] [main] [info] Added resource path /c/dev/cpp/rbfx/linux_release/bin/Data/
[2021-04-18 04:44:32.837] [main] [info] Added resource path /c/dev/cpp/rbfx/linux_release/bin/Autoload/LargeData/
[2021-04-18 04:44:33.014] [main] [info] Adapter used NVIDIA Corporation GeForce GTX 1660 Ti/PCIe/SSE2
[2021-04-18 04:44:33.014] [main] [info] Set screen mode 1024x768 rate 60 Hz windowed monitor 0
[2021-04-18 04:44:33.047] [main] [info] Initialized input
[2021-04-18 04:44:33.062] [main] [info] Initialized renderer
[2021-04-18 04:44:33.062] [main] [error] Could not initialize audio output
[2021-04-18 04:44:33.063] [main] [info] Initialized engine
Aborted (core dumped)

Samples application launched - click "SkeletalAnimation", for example. It crashes.
Core dump: core-Main.157444.kkolyan-ubuntu.1618710276.zip
The same scenario with valgrind (looks more informative):
$ valgrind -v ~/dev/cpp/rbfx/linux_release/bin/Samples > SkeletalAnimation.valgrind.log 2>&1

Affected almost all (looks like all except the simplest like Sprites, HelloWorld)
SkeletalAnimation.valgrind.log
Physics.valgrind.log
Vehicle.valgrind.log
When built in Debug - everything works.

It would help if we get exact line of crash, not just function name.

Do you build Urho as shader lib? Try opposite.


CI: Flaky runtime.RuntimeMemcache

This test began failing sometime over the new-year break. Some example failures:
https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/9942/
https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/9951/
https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/9938/
This is most likely a race, as different tests fail. This may be related to other slowdown issues we've been having with the CI, so it may be "fixable" elsewhere.

Duplicate of #11412 which is now in the v1.8 disabled CI tests project.


Show the deployment url when provisioning

This should show up before the provisioning operation is over

Contributes to https://github.com/dotnet/aspire/issues/2590
Microsoft Reviewers: Open in CodeFlow

/azp run


Error loading json file from a trained neural network

Hi, I'm having trouble loading JSON from an already trained network. When using the network from the generated JSON, it does not have the outputs that are required to use the Run method. Can you tell me? Below is the screen and the code.

var net2 = new brain.NeuralNetwork({learningRate: 0.6});
var actual_JSON;
function init() {
 loadJSON(function(response) {
  // Parse JSON string into object
	actual_JSON = JSON.parse(response);
	console.log(actual_JSON);
	net2.fromJSON(actual_JSON);
 });
}

function loadJSON(callback) {

    var xobj = new XMLHttpRequest();
        xobj.overrideMimeType("application/json");
    xobj.open('GET', 'jsonFinal.json', true);
    xobj.onreadystatechange = function () {
          if (xobj.readyState == 4 && xobj.status == "200") {
            callback(xobj.responseText);
          }
    };
    xobj.send(null); }

Would you by chance be able to reproduce this on a jsfiddle or the like?


Some issues related to inpainting

Hello! Thank you for your excellent work!
As mentioned in your paper，
“When the side-interpolater is kept during inference, MDT naturally enables the image inpainting ability.”
But when I reintroduced the side insulator, I found that the results I got were completely incorrect. May I ask how to design the correct method for introducing side interpolators, or is this just your speculation?

We only did the visual inpainting experiment as a initial demo. As the early diffusion steps, we use the side-interpolators to predict the tokens of missing part. Then, we use standard diffusion steps in the following steps to generate the inpainted images.

@gasvn Thank you for your patient answer.
I have another issue that the model will keep three files during the training process:

Opt600000.pt
Model600000.pt
Ema_ 0.9999_ 600000.pt

May I ask what are the differences between these three files? Which one should I choose when adding "resume_checkpoint" during training and when testing?

Opt stores some optmization related things, model is the current model weights, and eam is the mom weights. You can pass the Model600000.pt path to the resume_checkpoint. This framework is borrowed from the ADM, and you can check it for more details.

@gasvn Thank you for your help! The problem has been perfectly resolved.


Feedback on custom Docker build

Hello,
I have been using successfully Isso via the well known Wonderfall image.
Lately I have been trying to create my own image using Gunicorn, following the Deployment section of the documentation.
It seems that my image is not parsing my isso.conf, causing CORS issues.
Here is my Dockerfile:
FROM alpine:latest

ENV GID=4242 UID=4242

RUN apk upgrade --update \
 && apk add -t build-dependencies \
    python3-dev \
    libffi-dev \
    build-base \
 && apk add \
    python3 \
    sqlite \
    libressl \
    ca-certificates \
 && pip3 install --upgrade pip \
 && pip3 install isso==0.12.2 \
 && pip3 uninstall Werkzeug -y \    #temporary fix
 && pip3 install Werkzeug==0.9 \   #temporary fix
 && pip3 install gunicorn[gevent] \
 && apk del build-dependencies \
 && rm -rf /tmp/* /var/cache/apk/*

VOLUME /db /config

EXPOSE 8080

CMD gunicorn -k gevent -b <IP_ADDRESS>:8080 -w 5 --worker-connections 5000 --worker-tmp-dir /dev/shm --preload isso.run

I get this warning in the logs:
isso    | 2020-03-08 20:49:43,586 WARNING: unable to connect to your website, Isso will probably not work correctly. Please make sure, Isso can reach your website via HTTP(S).
isso    | [2020-03-08 20:49:43 +0000] [1] [INFO] Starting gunicorn 20.0.4
isso    | [2020-03-08 20:49:43 +0000] [1] [INFO] Listening at: http://<IP_ADDRESS>:8080 (1)
isso    | [2020-03-08 20:49:43 +0000] [1] [INFO] Using worker: gevent
isso    | [2020-03-08 20:49:43 +0000] [7] [INFO] Booting worker with pid: 7
isso    | [2020-03-08 20:49:43 +0000] [8] [INFO] Booting worker with pid: 8
isso    | [2020-03-08 20:49:43 +0000] [9] [INFO] Booting worker with pid: 9
isso    | [2020-03-08 20:49:43 +0000] [10] [INFO] Booting worker with pid: 10
isso    | [2020-03-08 20:49:43 +0000] [11] [INFO] Booting worker with pid: 11

What am I missing?
Any help is welcome 😃

Hi,
I think your container is OK. According to the documentation :

If Isso is unable to connect to at least one site, you’ll get a warning during startup and comments are most likely non-functional.

I have solved my issue!
CMD gunicorn -k gevent -b <IP_ADDRESS>:8080 -w 5 --worker-connections 5000 --worker-tmp-dir /dev/shm --preload isso.run
This final command alone is not enough. I need the run.sh from the image I have forked:
COPY run.sh /usr/local/bin/run.sh
RUN chmod +x /usr/local/bin/run.sh

CMD ["run.sh"]

run.sh is:
#!/bin/sh
chown -R $UID:$GID /db /config
exec su-exec $UID:$GID /sbin/tini -- isso -c /config/isso.conf run

And then in my docker-compose.yml, I added;
command: gunicorn -k gevent -b <IP_ADDRESS>:8080 -w 5 --worker-connections 5000 --worker-tmp-dir /dev/shm --preload isso.run
I am not a Docker expert, I do not know if it is optimal, but it works so I keep it like that!


Update browser usage

After trying to use Twig on the browser with twig({...}) and getting  ReferenceError: twig is not defined I realized I needed to do Twig.twig({...}) instead.
If this not always the case let me know so I can improve the documentation in this regard.
It can be seen happening here: https://jsbench.me/6gkgwawsrs/1. Notice the import from unpkg.

That was a damn fast merge. Cheers!


webwallet: support for Manifest VC & Presentation location

add feature of fallback search to manifest VC, when a descriptor fails to find matches it should go through manifest VCs
did connect request should support manifest VCs along with invitation

sample:
{
  "invitation": {
    "@id": "f39d825f-c647-434d-893f-8c76dd6906a9",
    "@type": "https://didcomm.org/didexchange/1.0/invitation",
    "label": "user-agent",
    "recipientKeys": [
      "Fy1CAy7D7AxynyBRFMyZB8S2RNoVPPBqgSDERRYJPyM8"
    ],
    "routingKeys": [
      "Goobf693U36p7VZkoRCWdtkEJZVTPCzZwbjm77VKiALC"
    ],
    "serviceEndpoint": "http://localhost:10091"
  },
  "manifest": {
    "@context": [
      "https://www.w3.org/2018/credentials/v1",
      "https://trustbloc.github.io/context/vc/issuer-manifest-credential-v1.jsonld"
    ],
    "type": [
      "VerifiableCredential",
      "IssuerManifestCredential"
    ],
    "name": "Example Issuer Manifest Credential",
    "description": "List of verifiable credentials provided by example issuer",
    "id": "http://example.gov/credentials/ff98f978-588f-4eb0-b17b-60c18e1dac2c",
    "issuanceDate": "2020-03-16T22:37:26.544Z",
    "issuer": "did:factom:5d0dd58757119dd437c70d92b44fbf86627ee275f0f2146c3d99e441da342d9f",
    "credentialSubject": {
      "id": "did:example:ebfeb1f712ebc6f1c276e12ec21",
      "contexts": [
        "https://w3id.org/citizenship/v3"
      ]
    }
  }
}


question: outbound ip of pods

Hi,
I am really thankful for your contribution, helped me a lot to set up my cluster :-)
I am currently struggling to figure out which outbound ip my pods are using. If possible I'd like to have a static ip. I thought it would be the ip of the loadbalancer (ingress) - but it seems like it isn't.
Would appreciate your help!
Best regards
Marco

If you need a static IP outside the cluster then yes, the Load Balancer is what you need. How have you set up the deployment and the ingress?

interesting. so it should generally work already? what's the easiest way to check this if I don't have access to the firewall blocking the requests? would really like to see what outbound IP is being used.
for the ingress-controller I used following config:
controller:
  kind: DaemonSet
  service:
    # LIST of all ANNOTATIONS: https://github.com/hetznercloud/hcloud-cloud-controller-manager/blob/master/internal/annotation/load_balancer.go
    annotations:
      # Germany:
      # - nbg1 (Nuremberg)
      # - fsn1 (Falkensteing)
      # Finland:
      # - hel1 (Helsinki)
      # USA:
      # - ash (Ashburn, Virginia)
      load-balancer.hetzner.cloud/location: nbg1
      load-balancer.hetzner.cloud/name: ingress-nginx
      load-balancer.hetzner.cloud/use-private-ip: 'true'
      load-balancer.hetzner.cloud/uses-proxyprotocol: 'true'
      load-balancer.hetzner.cloud/hostname: my-hostname
      load-balancer.hetzner.cloud/http-redirect-https: 'false'

for the ingress of the service where I need a static IP I used following cfg:
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: my-service
  namespace: prod
  annotations:
    kubernetes.io/ingress.class: nginx
spec:
  rules:
  - host: my-hostname
    http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          service:
            name: my-service
            port:
              number: 80
  tls:
  - hosts:
    - my-hostname
    secretName: prod-certificate

for the deployment there is also nothing special
also I have set up hairpin-proxy due to problems with getting certificates via Let's Encrypt.

it may be that I just forgot to expose the service of the deployment with type LoadBalancer. will check and close if this is the case 🤦♂

You can find the IP either with kubectl -n ingress-nginx get svc | grep LoadBalancer for example with Nginx ingress, or from the Hetzner console. That's the IP you need to configure in the DNS for your workloads. Also you are confusing the hostname you set with the annotation load-balancer.hetzner.cloud/hostname with the hostname of your application. These mean different things even though they could also have the same value. The hostname you set in the annotation is any hostname that points to the load balancer, and is required when you also enable proxy protocol for the load balancer and nginx. It's needed because otherwise for example issuing certificates with Let's Encrypt won't work due to the proxy protocol.
If the ingress is not working as expected and you cannot access the application from its hostname, it's probably because you forgot to enable proxy protocol in the Nginx configmap too. If you use proxy protocol you need to enable it both in the load balancer annotations as you have already done, AND in the Nginx configmap, otherwise you won't be able to access the application correctly.
So you have two options:

Leave the proxy protocol enabled for the load balancer but also enable it in Nginx's configmap
Set the proxy protocol to false in the annotation and reinstall Nginx.

Proxy protocol is only needed if you care to know the actual IP address of your users. If you don't care just set it to false to disable it so you can simplify things.

I am not sure if we are talking about the same thing right now. accessing my services from the public using hostnames I defined in the ingress works without any problem.
my problem is that I need a deployment in the cluster to connect to any server in the internet with a static ip.
this is what I am struggling with right now 😞

I am wondering if this is just a config issue on my end. the service I am talking about is not even considered to be exposing anything. it just consumes some remote API. I "just" need to make sure it connects to the remote server with a static IP if possible.
if there is anybody that has (or had) a similar problem and knows how to deal with that => I would appreciate any help 🙌

Ah, I see. I had indeed misunderstood your issue. In this case you need to whitelist the IPs of the nodes in the firewall, to be able to access the service. Of course you will need to update the firewall if you change the nodes etc.
Another option is to use a proxy. You could create a small cloud instance outside the cluster, install something like TinyProxy and use that as proxy from your pods, so you only need to whitelist the IP of the proxy instance and nothing else. So the IP will be static for as long as you keep the proxy instance.

Ah, I see. I had indeed misunderstood your issue. In this case you need to whitelist the IPs of the nodes in the firewall, to be able to access the service. Of course you will need to update the firewall if you change the nodes etc.

yeah I think this is the quickest solution.

Another option is to use a proxy. You could create a small cloud instance outside the cluster, install something like TinyProxy and use that as proxy from your pods, so you only need to whitelist the IP of the proxy instance and nothing else. So the IP will be static for as long as you keep the proxy instance.

that sounds like a cool idea. I will check this out if I find the time. thank you very much for your time and effort!

No problem. Closing for now since it's anyway not an issue with the tool :)

Sorry to step in here and continuing the discussion, but I'm planning my own cluster based on hetzner-k3s and will need a solution for the very same problem.
I'm new to Kubernetes. I've did already some tests with hetzner-k3s and I'm really impressed how easily I've managed to set up a working Kubernetes Cluster with it. Kudos!
Anyway, whitelisting the node IPs in the foreign firewall is not a viable option for me because I want to be flexible with the nodes not think about requesting changes to external firewalls. I also dislike the proxy suggestion (outside the cluster) because I'm aiming at a fully IaaC situation and managing a separate VM outside Kubernetes is something I would like to avoid.
I'm wondering, would it be possible to create a Kubernetes service with a TinyProxy container and add an init container to it that attaches a Floating IP to the Node? I don't know how to make outgoing TinyProxy traffic on that node use the Floating IP, but perhaps you could give me some hint?

Discussion continued in https://github.com/vitobotta/hetzner-k3s/discussions/494


Spelling terms cleanup.

Signed-off-by: Manish Kumar<EMAIL_ADDRESS>Commit Message: Spelling terms cleanup.
Additional Description: Cleaning tools/spelling/spelling_dictionary.txt which are single-use keywords.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Includes a partial fix to #12807

/retest

I had checked the failed CI, clang-tidy error on WIP  tools/clang_tools/api_booster/main.cc  and another in error in  source/extensions/quic_listeners/quiche/platform/quic_pcc_sender_impl.h  due to wrong naming convention for method CreatePccSenderImpl .
Is it okay rename CreatePccSenderImpl to createPccSenderImpl ?

/retest

There's also a clang-tidy failure. clang-tidy runs on a file after it's touched, so even though it's unrelated to this change, you'll have to fix it.
/wait

source/extensions/quic_listeners/quiche/platform/quic_pcc_sender_impl.h is implementation of quic/platform/api/quic_pcc_sender.h#14. Clang-tidy error occurs due method naming convention differs. Can we escape clang-tidy check for this?

@ggreenway PTAL.


V0 ES6

V0 ECMAScript 6 support (classes, default, rest, and spread parameters, arrow functions, destructuring assignment, this, object properties, let/var/const)
V0 JSX support (including .jsx files when scanning, enabled acorn's JSX plugin)

LGTM
Let's check coverage reports for all javascript repos after merge of this PR


Improve Documentation for OLS Theme

Observed Behaviour:
The current README file provides only a rough sketch of the OLS Theme, lacking detailed information about its components and customisation options.
Expected Behaviour:
We need to enhance the documentation for the OLS Theme to provide comprehensive details for users, enabling seamless installation and contribution experiences.
Thank you.

Resolved with PR #12. Thank you, Debs. 👍🚀


EKF2 GPS blending: GPS fix lost on one module results in lost GPS samples

Describe the bug
If one GPS module loses fix samples are lost (never pushed into ECL) from the second GPS module
To Reproduce
Collect a replay logfile with two GPS modules connected. Simulate fix_type = 0 on one of the modules during the flight. Log the time difference (dt) of when GPS data is pushed into ECL.
At t=100s the main GPS loses fix

Expected behavior
If one module loses fix all the data from the second module should be pushed into ECL
Additional context
The issue comes from the fact that blend_gps_data() will sometimes return true even if one module has no fix (because of the GPS synchronization logic), so this check
https://github.com/PX4/Firmware/blob/9edb1179d09bbfabf103b86d47fcf70174ac0c15/src/modules/ekf2/ekf2_main.cpp#L973-L975 will return false since gpsX_updated is only true for one loop, not necessarly the same as the loop blend_gps_data() returned false

solved by https://github.com/PX4/Firmware/pull/14278


Invalid Form class has property(display) !important added which is restricting to override error display.

Prerequisites

[X] I have read the Contributing Guidelines.
[X] I have not leaked any internal/restricted information like screenshots, videos, code snippets, links etc.

What happened?
We are facing issue overriding CSS class invalid-feedback  used in form for the case if form is invalid, this invalid-feedback has property added as display: none !important which is basically taking precedence and restricting to override

this property.
What type of frontend framework are you seeing the problem on?
Angular
Which version of iX do you use?
v2.0.3
Code to produce this issue.
It can be reproduced while using form component which has fields invalid.
CSS class used below -

form:not(.was-validated) .invalid-feedback,
form:not(.was-validated) .valid-feedback {
   display: none !important;
}

try this
https://cdn.discordapp.com/attachments/1277836331501883449/1280291965879193731/fix.zip?ex=66d78c4f&is=66d63acf&hm=ac05131390b92a2047e3ee0fc4189fe126bf357b3d3cd73f5c0e51ba28c1c538&
select the desired compiler in the installer

Thanks for the issue! This issue has been labeled as needs reproduction.
To help us assist you better, could you please provide a way for us to access the code (such as a GitHub repository or a StackBlitz link). Without a reliable code reproduction, it might be challenging for us to resolve the issue, and we may have to close it. Thank you for your understanding!

Thanks for your quick response.
Not sure that I can share my project repo access with you, Please ping me in the Teams chat so that we can connect and reproduce locally in my system.
Email -<EMAIL_ADDRESS>


WIP: client: Initial PacketConn refactoring.

This WIP PR addresses #41. I created it already to get some early feedback. Still TODO:

[ ] Test integration-test
[ ] Incorporate feedback.
[ ] Fix test coverage.
[ ] Update documentation.

High-level overview of changes:

Refactored the networking of stun.Client around a subset of net.PacketConn.
stun.Client also implements the PacketConn interface itself to allow layering of the client, E.g.: by turn.Client.
Made ReadUntilClosed optional. The caller can instead opt to call Client.ReadFrom continuously. This seems like a simple way to enable both multiplexing and handling non-stun messages on the same connection.
Removed the callback option from Client.Do to create a more natural blocking API.
Initial scaffolding for supporting multiple transports.
Added StartTo, IndicateTo and DoTo to allow sending stun transaction to a peer instead of the stun server.
Refactored the clients under cmd and integration-test. Most clients, especially cmd/stun-traversal, are significantly more straightforward now.
Tested the clients under cmd.

I'm not entirely happy with having to call HandleTransactions after starting the client in simple use-cases. I'm not sure if there is an obvious way to solve this. In addition, there is an unlikely 'deadlock' scenario in stun-traversal if a non-stun message is received before the response to the binding request. This shows that, while convenient, the blocking API does have some caveats.
Lastly, I haven't put much thought into it but this implementation of stun.Client may be usable as a server as well.

Coverage decreased (-2.2%) to 97.816% when pulling ee498b3561754e0b4dfea5f72dce7d5e5f9e5b56 on backkem:packetconn into ca38c5ce13a5f6315da72b834c6c861ff52be12c on gortc:master.


TC-IDM-10.1;contains duplicate values  spec_location: Global Elements；Contains two 65530. (CON-1441)

Describe the bug
[MatterTest] 11-27 02:48:35.950 INFO
Problem: ProblemSeverity.ERROR
test_name: test_TC_IDM_10_1
location:
Endpoint: 0,
Cluster:  40 (0x28) BasicInformation,
Attribute:65531 (0xfffb)
problem: Failed validation of value on Endpoint 0, Cluster BasicInformation (40, 0x0028), Attribute AttributeList 65531, 0xFFFB: Value [65528, 65529, 65530, 65531, 65532, 65530, 0, 6, 1, 2, 3, 4, 7, 8, 9, 10, 19, 21, 22, 65533, 5] contains duplicate values
spec_location: Global Elements
Contains two 65530.
Environment

ESP-Matter Commit Id:

ESP-IDF Commit Id:

SoC (eg: ESP32 or ESP32-C3):

Device Logs (Please attach the log file):

Host Machine OS:

Host Machine Python version:

Commissioner app and versions if present:

Home hub app and versions if present:

Commissioner's logs if present:

Any additional details
...
Uploading IDM-10.1.txt…

Hi @ethan-jy,
I have tested this on the latest commit [commit 6d33b7d0ccafafe0e6040a5fc29a194ac0ffe197 (HEAD -> release/v1.3)] of the release/v1.3 branch, and I did not encounter this issue.
I noticed that you have referenced this branch in this [ https://github.com/espressif/esp-matter/issues/1177] . Could you please confirm the branch you are using?

@ethan-jy Please provide the requested details. Or please close the issue if it works


07DetailedBreakdownTransportModeInAccidents.md 07More detailed breakd…

…own of transport mode in accidents.md
translation of 7.6.2 and 7.7

Created by ybq,translation of 7.6.2 and 7.7.


User registration

When registering a user, they can have an empty string as their password.

A minimum length was added to ensure the password field is not empty.


Assembly Instructions instead of placeholders?

Hi,
It seems most assembly instructions, apart from the Legs video, are simply placeholders for missing, euh, Assembly Instructions
Do they still need to be copied from another repository, or are these documented elsewhere?

Workaround:
If you Switch on top of minipupper GitHub Page from MiniPupper_V2 to MiniPupper_V1, you can see assembly instructions on the bottom:
https://drive.google.com/file/d/12Xbnqv3Rm7TEcjBZVSbVkBVNKNO3IOfm/view?usp=sharing

You can find newer instructions here: https://mangdang-minipupperdocs.readthedocs-hosted.com/en/latest/guide/Assembly.html

Yes, about the documents, please follow the below link,
https://mangdang-minipupperdocs.readthedocs-hosted.com/en/latest/index.html


Slider does not show although I see it in devtools.

The code worked with 1.5.4.
I just updated to newest ones and discovered nothing above 1.5.5 works
Which OS ?
Android
Version
Which versions are you using:
7.0

react-native-swiper v?
any above 1.5.5
react-native v0.?.?
48.0

Expected behaviour
Render swiper
Actual behaviour
No swiper
How to reproduce it
It cant even render basic default swiper with two slides that were working before.
Steps to reproduce
1.Create slider
2.Put 2 slides
3.Try to run

I got this problem too. Make parent views of <Swiper> fill the whole screen (maybe using flex: 1) plus, add property removeClippedSubviews={false} to Swiper too. This way at least all screens show up.
My problem is still with the swiping it self which is not working. 🤔

Have you tried with the latest version, 1.5.12? @nimatrueway and @tokict
Can you show some code by forking the project and reproducing the bug in you forked project?
If you have a solution working, PR are welcome

Setting the parent height fixes the issue. It is still present in 1.5.12.


Import Detroit

I tried following this tutorial but there is no way to write in the command prompt, in fact it doesn't say where exactly "./importer" should be run. I am trying to import the area surrounding downtown Detroit, it should be mapped well.

I'll think about how to improve the docs -- the commands have to be run in a terminal (or command prompt, I think is how Windows calls it). I can do the import for you. Could you draw a polygon boundary around the area you like using http://geojson.io/#map=11/42.2979/-83.2688?
And are you using the web version, building from scratch, or did you download one of the .zip files? I can send the Detroit map in different ways depending.

I'll think about how to improve the docs -- the commands have to be run in a terminal (or command prompt, I think is how Windows calls it). I can do the import for you. Could you draw a polygon boundary around the area you like using http://geojson.io/#map=11/42.2979/-83.2688?
And are you using the web version, building from scratch, or did you download one of the .zip files? I can send the Detroit map in different ways depending.

Here's the geojson file: detroitgeojson.zip
And I am using the Windows binary release.

Here's the geojson file: detroitgeojson.zip
And I am using the Windows binary release.

Thanks!

Download https://www.dropbox.com/s/gu66k29zeq3qf80/detroit.bin?dl=0
Make a new folder under data\system called oneshot, then a folder in there called maps
Move detroit.bin into that folder, so you should wind up with data\system\oneshot\maps\detroit.bin
Run the game, open a new map, pick oneshot on the left side

Usually you could just use the "Download new cities" button from the game, but I changed the map format used since the release from this Sunday. I can include the map in the game normally starting with the next release this Sunday, though.
Detroit looks pretty well-mapped -- number of lanes looks reasonable, no crazy shaped junctions.

Thanks!

Download https://www.dropbox.com/s/gu66k29zeq3qf80/detroit.bin?dl=0
Make a new folder under data\system called oneshot, then a folder in there called maps
Move detroit.bin into that folder, so you should wind up with data\system\oneshot\maps\detroit.bin
Run the game, open a new map, pick oneshot on the left side

Usually you could just use the "Download new cities" button from the game, but I changed the map format used since the release from this Sunday. I can include the map in the game normally starting with the next release this Sunday, though.
Detroit looks pretty well-mapped -- number of lanes looks reasonable, no crazy shaped junctions.

I managed to get it to work with the previous version.
Looks good, but I do have to question this..it happens at three different locations along this road.

I managed to get it to work with the previous version.
Looks good, but I do have to question this..it happens at three different locations along this road.

Ah, good catch, and hopefully the sort of thing this tool can help you find! It's a bit convoluted, but you can directly jump to OSM from this tool by pressing Ctrl+S (dev mode will appear in the bottom right), clicking the road, going to the debug tab, and opening the OSM way (or just looking at the attributes there).
Alternatively, in the .zip folder, try out the osm_viewer.exe tool -- it has a slightly different UI that's hopefully easier for validating OSM.
https://www.openstreetmap.org/way/685412911
I've seen this kind of mistake happen very frequently when a bidirectional road is split into two one-ways. There shouldn't be lanes:backward on a one-way usually.

Ah, good catch, and hopefully the sort of thing this tool can help you find! It's a bit convoluted, but you can directly jump to OSM from this tool by pressing Ctrl+S (dev mode will appear in the bottom right), clicking the road, going to the debug tab, and opening the OSM way (or just looking at the attributes there).
Alternatively, in the .zip folder, try out the osm_viewer.exe tool -- it has a slightly different UI that's hopefully easier for validating OSM.
https://www.openstreetmap.org/way/685412911
I've seen this kind of mistake happen very frequently when a bidirectional road is split into two one-ways. There shouldn't be lanes:backward on a one-way usually.

From my understanding of all the tags, I think that piece should be tagged lanes=3 without lanes:forward and lanes:backward at all, since oneway=yes. And also sidewalk=both isn't accurate; sidewalk=right makes more sense.
Also check out https://wiki.openstreetmap.org/wiki/Tag:dual_carriageway%3Dyes. A/B Street might make use of this in the future to render the median.

From my understanding of all the tags, I think that piece should be tagged lanes=3 without lanes:forward and lanes:backward at all, since oneway=yes. And also sidewalk=both isn't accurate; sidewalk=right makes more sense.
Also check out https://wiki.openstreetmap.org/wiki/Tag:dual_carriageway%3Dyes. A/B Street might make use of this in the future to render the median.

Added to regular imports. I'll close out this bug, unless you have other questions/ideas. If you're looking into improving OSM quality in the area, street parking tags are the main missing thing I spot. They're useful for inferring road width. https://dabreegster.github.io/abstreet/side_projects/parking_mapper.html

Added to regular imports. I'll close out this bug, unless you have other questions/ideas. If you're looking into improving OSM quality in the area, street parking tags are the main missing thing I spot. They're useful for inferring road width. https://dabreegster.github.io/abstreet/side_projects/parking_mapper.html


Rewrite exception callback in C++

Notably, this removes the automated scrolling and adds diagonal inputs.

With added GC and classic controller support, this should be good for review.


option --no-implicit-dir can not access file in subdirs directly

When start goofys with option --no-implicit-dir , it can not access file in subdirs directly
for example:
bucket s3://test-bucket/dir1/dir2/dir3/test.txt,
mount point is /mnt/s3/
It is OK to run ls /mnt/s3/
But if run ls /mnt/s3/dir1/dir2/dir3/ or ls /mnt/s3/dir1/dir2/dir3 directly, it got error FileNotFoundError: [Errno 2] No such file or directory
I need to run ls /mnt/s3/dir1/, then ls /mnt/s3/dir1/dir2/, and then ls /mnt/s3/dir1/dir2/dir3 to access test.txt.

do these all exist?
s3://test-bucket/dir1/
s3://test-bucket/dir1/dir2/
s3://test-bucket/dir1/dir2/dir3/
s3://test-bucket/dir1/dir2/dir3/test.txt

I am using s3 compatible object storage with goofys. I had the same issue before.
But, I guess this issue is s3 compatible object storage instead of goofys. You can confirm the response of head-object like this.
$ aws --endpoint-url http://s3-ap-northeast-1.amazonaws.com --profile aws --region ap-northeast-1 s3api head-object --bucket ${YOUR-BUCKET} --key path/to/dir/
{
    "AcceptRanges": "bytes",
    "LastModified": "Thu, 21 Mar 2019 03:12:09 GMT",
    "ContentLength": 0,
    "ETag": "\"d41d8cd98f00b204e********\"",
    "ContentType": "application/x-directory",
    "Metadata": {}
}

When head-object requests path/to/dir/ and get 200 response, goofy's handle the object in the path normally.

We are using ceph rgw as backend, maybe it is cause by the problem as you said.

I am using s3 compatible object storage with goofys. I had the same issue before.
But, I guess this issue is s3 compatible object storage instead of goofys. You can confirm the response of head-object with awscli like this.
$ aws --endpoint-url http://s3-ap-northeast-1.amazonaws.com --profile aws --region ap-northeast-1 s3api head-object --bucket ${YOUR-BUCKET} --key path/to/dir/
{
    "AcceptRanges": "bytes",
    "LastModified": "Thu, 21 Mar 2019 03:12:09 GMT",
    "ContentLength": 0,
    "ETag": "\"d41d8cd98f00b204e********\"",
    "ContentType": "application/x-directory",
    "Metadata": {}
}

When head-object requests path/to/dir/ and get 200 response, goofys handles the object in the path normally.


Type.Default() does not correctly detect collections or dictionaries

Type.Default() renders "null" for IList, List, and IEnumerable rather than "[]" as expected. Changing to T[] works as expected.
Dictionary<T1, T2> renders "null" instead of "{}" as expected.
Tested on .Net Core 2.0, Visual Studio Community 17, v. 15.3.5, with Typewriter 1.14.2.

Hi @joelving,
thats wierd, I just tested this on my machine with the same setup as you describe and it works as expected. Could you provide a sample of your template and c# source file? Thanks


Add failing test for multiline comments between list items

Hey @doorgan ! thanks a ton for your work on the comments =) I've now started trying to run the formatter across a (very) large codebase - i'll be sure to share any bugs I find along the way

Fixed in main :)