Pre-trained shufflenetv2_x1.5 and shufflenetv2_x2.0 raise "...not supported as of now".

🐛 Bug
Pre-trained models of shufflenetv2_x1.5 and shufflenetv2_x2.0 raise the following NotImplementedError: pretrained {} is not supported as of now. Important: pre-trained models of shufflenet_v2_x0_5 and shufflenet_v2_x1_0 are working perfectly.
To Reproduce
Steps to reproduce the behavior:

from torchvision import models
model = models.shufflenet_v2_x1_5(pretrained=pretrained)
model = models.shufflenet_v2_x2_0(pretrained=pretrained)
Raises the following:

  NotImplementedError                       Traceback (most recent call last)
  <ipython-input-15-788c60a16542> in <module>
        1 # Build and train your network
        2 # Transfer Learning
  ----> 3 model = models.shufflenet_v2_x1_5(pretrained=pretrained)

  ~/venvs/pytorch_gpu/lib/python3.8/site-packages/torchvision/models/shufflenetv2.py in shufflenet_v2_x1_5(pretrained, progress, **kwargs)
      191         progress (bool): If True, displays a progress bar of the download to stderr
      192     """
  --> 193     return _shufflenetv2('shufflenetv2_x1.5', pretrained, progress,
      194                          [4, 8, 4], [24, 176, 352, 704, 1024], **kwargs)
      195

  ~/venvs/pytorch_gpu/lib/python3.8/site-packages/torchvision/models/shufflenetv2.py in _shufflenetv2(arch, pretrained, progress, *args, **kwargs)
      145         model_url = model_urls[arch]
      146         if model_url is None:
  --> 147             raise NotImplementedError('pretrained {} is not supported as of now'.format(arch))
      148         else:
      149             state_dict = load_state_dict_from_url(model_url, progress=progress)

  NotImplementedError: pretrained shufflenetv2_x1.5 is not supported as of now

Expected behavior

Get the pre-trained model of Shufflenet_v2_x1_5 and shufflenet_v2_x2.0.
Environment

PyTorch version: 1.5.1
Is debug build: False
CUDA used to build PyTorch: 10.2
ROCM used to build PyTorch: N/A

OS: Ubuntu 20.04.1 LTS (x86_64)
GCC version: (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
Clang version: Could not collect
CMake version: Could not collect

Python version: 3.8 (64-bit runtime)
Is CUDA available: True
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: GeForce GTX 1660 Ti with Max-Q Design
Nvidia driver version: 450.102.04
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip3] numpy==1.19.1
[pip3] torch==1.5.1
[pip3] torchvision==0.6.1
[conda] Could not collect

Additional context
Also tried to get the pre-trained model with:
model = torch.hub.load('pytorch/vision:v0.6.0', 'shufflenet_v2_x2_0', pretrained=True)
and it raised:
RuntimeError: Cannot find callable shufflenet_v2_x2_0 in hubconf

I found that models are unavailable. Model URLs are None in lines 13-18 of shufflenetv2.py:
model_urls = {
    'shufflenetv2_x0.5': 'https://download.pytorch.org/models/shufflenetv2_x0.5-f707e7126e.pth',
    'shufflenetv2_x1.0': 'https://download.pytorch.org/models/shufflenetv2_x1-5666bf0f80.pth',
    'shufflenetv2_x1.5': None,
    'shufflenetv2_x2.0': None,
}

so it raises the following:
if model_url is None:
            raise NotImplementedError('pretrained {} is not supported as of now'.format(arch))

at lines 169 and 170 of the same file.
I don't know if this is a bug or it's all ok, so I'll leave it open.

I found that models are unavailable. Model URLs are None in lines 13-18 of shufflenetv2.py:
model_urls = {
    'shufflenetv2_x0.5': 'https://download.pytorch.org/models/shufflenetv2_x0.5-f707e7126e.pth',
    'shufflenetv2_x1.0': 'https://download.pytorch.org/models/shufflenetv2_x1-5666bf0f80.pth',
    'shufflenetv2_x1.5': None,
    'shufflenetv2_x2.0': None,
}

so it raises the following:
if model_url is None:
            raise NotImplementedError('pretrained {} is not supported as of now'.format(arch))

at lines 169 and 170 of the same file.
I don't know if this is a bug or it's all ok, so I'll leave it open.

Hi It is not a bug :sweat_smile: PyTorch is yet to provide Pre Trained weights, for these. Marking for #2707 .

Hi It is not a bug :sweat_smile: PyTorch is yet to provide Pre Trained weights, for these. Marking for #2707 .

Thank you, I was a little bit confused. So I'll close this.

Thank you, I was a little bit confused. So I'll close this.


Git download strategy: shallow clone for submodules

Feature suggestion
When cloning modules from a Git repo, brew currently uses the --depth=1 option (shallow clones) when possible. If the repository contains submodules, brew also clones those, but it does a full clone. It would be great to do a shallow clone there as well, to save bandwidth and speed up the download.
A detailed description of the proposed feature
brew uses shallow clones when cloning from Git (when the remote is known to support it), but for submodules, a full clone is always used (through git submodule update --init --recursive).
Implementing this feature may not be super straightforward. We can't, for example, just pass --depth=1 to the git submodule init, because some of the submodules may point to remotes that don't support shallow clones. We could use git submodule status and friends to determine which submodules point to remotes that support shallow clones, and then invoke git submodule update with or without --depth=1 on individual submodules.
I ran into this when installing riscv-gnu-toolchain from source. The download size is pretty huge, and shallow clones of submodules make a pretty big difference.
The motivation for the feature
Save bandwidth and speed up downloads.
How the feature would be relevant to at least 90% of Homebrew users
Without looking at analytics data, I can't say for sure, but I expect that most Homebrew users end up cloning something from Git at some point (e.g. when using flags that require compiling from source rather than using a bottle), and many Git repos use submodules.
What alternatives to the feature have been considered
N/A? It could be left as-is. This feature doesn't affect functionality for end users, it would just make things faster.
Implementation
If a core maintainer would like to implement this, that would be great. If this feature is desired / is likely to be merged if a PR is submitted, but the team doesn't have time to work on it, I'm happy to work on a PR.

Seems like a good idea!

Maybe --recommend-shallow would be useful for this

@anishathalye I'd say go ahead and start on working on this if its something you're interested in doing. Feel free to open a draft PR or ask questions here if you need help!

Maybe --recommend-shallow would be useful for this

It looks relevant, but it doesn't do quite what we want. --recommend-shallow (which is the default) says whether the initial clone should follow the shallow recommendation in submodule.<name>.shallow. Looking at the relevant code in git/builtin/submodule--helper.c confirms this: when both submodule.<name>.shallow and --recommend-shallow are given, the clone command uses --depth=1.

Hello guys, I am new here
But I researched a bit and how do you think, will be the issue solved if we replace this to this:
git submodule foreach '
a=$(git config -f $toplevel/.gitmodules --get submodule.$name.shallow)
if [ $a = true ]; then
  git submodule update --init --recursive --depth=1
else
  git submodule update --init --recursive
fi
'

That's already effectively what happens (but recursively) with the code as it's written. Git by default respects submodule.<name>.shallow. The issue is that most people don't use that config, but we want to clone submodules shallowly anyways (when possible).

Is it just me, or should this really be --depth 1 (space) instead of --depth=1 (equal sign)?
As far as I can see, --depth=1 checks out everything (actually it times out after 5 minutes), while --depth 1 does a shallow clone (it takes like 10 seconds).

@anishathalye Are you still working on this issue?

Sorry, nope, too many things to do at the moment. Feel free to implement it if you're interested, you won't be duplicating work.

@anishathalye No worries at all. Just wanted to make sure I wouldn't be duplicating your work :)

Why is there a shallow clone allowlist? Are shallow clones not supported everywhere?

Why is there a shallow clone allowlist? Are shallow clones not supported everywhere?

Correct (I assume you're talking about this)
https://github.com/Homebrew/brew/blob/3476ca7b8ff889ef61e65783d35d1b2073bd4012/Library/Homebrew/download_strategy.rb#L779-L784
If the submodule isn't from one of those sources I think it will need to be a full clone.

Correct. I inferred that, but I was unsure as to why there is an allowlist. Shallow cloning is a relatively old feature of git and should be supported by any git server one might clone from.

Seems like a good idea!

To adjust my previous comment: the rule of thumb for shallow clones: they are only better when you are never going to git fetch or git pull in them e.g. in a CI job where you clone once and then delete the repo/VM.
Given this, we should consider in which cases we expect to fetch a shallow clone again and not fetch in those cases.

If you have the repository checked out from installing a certain version and then try to upgrade to a new formula version that checks out the same repo, does Homebrew reclone or update the old one?
If the latter, we're probably breaking our own rule already because allowing shallow clones in these situations raising the possibility of needing to fetch later. We could instead just delete the old clone and reclone (shallowly). I'm not sure what's done currently to know whether this is already implemented or would be desired.

If the latter, we're probably breaking our own rule already because allowing shallow clones in these situations raising the possibility of needing to fetch later.

Yes, we likely are.

We could instead just delete the old clone and reclone (shallowly).

This is more expensive and, over time, slower, unfortunately.

At the moment, the update method of GitDownloadStrategy calls update_repo which performs a fetch even if the clone is shallow. Similar logic is used to update submodules.
https://github.com/Homebrew/brew/blob/53b9f8528100ae999bc954d73b9918772a8ecfd9/Library/Homebrew/download_strategy.rb#L902-L916
I'm not sure that it's possible to know ahead of time if a fetch will be performed on a shallow clone for the reasons @Rylan12 mentioned. Should shallow clones even be used at all? It seems like they're being misused.

Should shallow clones even be used at all? It seems like they're being misused.

I'd say: no, we shouldn't use them. We should unshallow them before we attempt to fetch from them and stop creating any new shallow clones.


Gosund Plugs command 8 Error

I added Gosund Plugs and they show up in HomeKit but the plugs do not respond to on/off commands. Does that mean these are incompatible? Thanks for your help and the great plugin!  I get this message in my logs:
[TuyaAccessory] Sending Dining Room Plug 2 {"1":true}
[TuyaAccessory] Sending Dining Room Plug 2 {"1":false}
[TuyaAccessory] Sending Dining Room Plug 2 {"1":true}
[TuyaAccessory] Sending Dining Room Plug 1 {"1":true}
[TuyaAccessory] Sending Bedroom Room Plug 1 {"1":true}
[TuyaAccessory] Odd message from Dining Room Plug 2 with command 8: { cmd: 8,
data:
'ì&ÚiÂ^(6¢¤]}g\b£¸;- â'\u0007_ëü\u000b\rùkÇ\u00118k\u000e©
5¤2Øîl\ÁÙ¥V_ºánX' }
[TuyaAccessory] Odd message from Dining Room Plug 2 with command 8: { cmd: 8,
data:
'ì&ÚiÂ^(6¢¤]}g\b£¸;- â'\u0007_ëü\u000b\rùkÇ\u0011ç\u0010\u00054«óN»<4uÃ)X^gP\t³½06\u001büÈ¶;Ýº\u001cï%ÝÏvORô\u0006fN\u0006ë' }

Please install the latest rc release using npm i -g homebridge-tuya-lan@rc.
If you see Odd message we will need to dig more. In that case, please post logs that start with Discovered... and end with Raw message from...; this will let me understand the situation better.
Good luck.

Thanks @domsammut for confirming. Let's hope @tolthoff also has their problem solved by using the latest rc.

Thanks! I did the update per above and still have the same issue with the plugs. I can turn them on and off on the app but nothing happens in the real world unfortunately:(. Is there anything you need me to send to see what is happening?

@tolthoff, can you please post any log messages you have for me to piece together where things are going wrong?

Here are the logs related to the devices using the plugin (the bedroom plug is not in use which is why it can’t find it).:
[TuyaLan] Discovered Dining Room Plug 2<PHONE_NUMBER>0194b5e0ba) identified as Outlet (3.1)
[9/14/2019, 3:30:26 PM] [TuyaLan] Connected to Dining Room Plug 2
[TuyaAccessory] Sending first query to Dining Room Plug 2 (3.1)
[9/14/2019, 3:30:26 PM] [TuyaLan] Ready to handle Dining Room Plug 2 (Outlet:3.1) with signature {"1":false,"11":0}
[9/14/2019, 3:30:26 PM] [TuyaLan] Discovered Dining Room Plug 1<PHONE_NUMBER>0194b579ca) identified as Outlet (3.1)
[9/14/2019, 3:30:26 PM] [TuyaLan] Connected to Dining Room Plug 1
[TuyaAccessory] Sending first query to Dining Room Plug 1 (3.1)
[9/14/2019, 3:30:26 PM] [TuyaLan] Ready to handle Dining Room Plug 1 (Outlet:3.1) with signature {"1":false,"11":0}
[9/14/2019, 3:30:26 PM] [TuyaLan] Discovered Bedroom Room Plug 1<PHONE_NUMBER>0194bfd613) identified as Outlet (3.1)
[9/14/2019, 3:30:38 PM] [TuyaLan] Connected to Bedroom Room Plug 1
[TuyaAccessory] Sending first query to Bedroom Room Plug 1 (3.1)
[9/14/2019, 3:30:38 PM] [TuyaLan] Ready to handle Bedroom Room Plug 1 (Outlet:3.1) with signature {"1":false,"11":0}
[TuyaAccessory] Sending Dining Room Plug 1 {"1":true}
[TuyaAccessory] Sending Dining Room Plug 2 {"1":true}
[TuyaAccessory] Sending Dining Room Plug 1 {"1":false}
[9/14/2019, 3:31:35 PM] [TuyaLan] Failed to discover Bedroom Room Plug 2<PHONE_NUMBER>0194bfd689) in time but will keep looking.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/AMoo-Miki/homebridge-tuya-lan/issues/80?email_source=notifications&email_token=ANEENGXNHQB52NLT2Z4KEP3QJ3VJFA5CNFSM4IUVN6WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6X7CFQ#issuecomment-531624214, or mute the thread https://github.com/notifications/unsubscribe-auth/ANEENGQTWOV3KHYYAWJFN3TQJ3VJFANCNFSM4IUVN6WA.

While you have the logs open, manually turn one of the plus on or off with its physical button. Do you see an error in the logs?

Ok. Here is what I got:
[9/15/2019, 7:40:39 PM] ReferenceError: cleanMsg is not defined
at TuyaAccessory._msgHandler_3_1 (/usr/local/lib/node_modules/homebridge-tuya-lan/lib/TuyaAccessory.js:214:21)
at queue (/usr/local/lib/node_modules/homebridge-tuya-lan/node_modules/async/dist/async.js:3205:13)
at Object.process (/usr/local/lib/node_modules/homebridge-tuya-lan/node_modules/async/dist/async.js:1431:21)
at setImmediate$1 (/usr/local/lib/node_modules/homebridge-tuya-lan/node_modules/async/dist/async.js:1289:23)
at Immediate.defer (/usr/local/lib/node_modules/homebridge-tuya-lan/node_modules/async/dist/async.js:73:45)
at runCallback (timers.js:705:18)
at tryOnImmediate (timers.js:676:5)
at processImmediate (timers.js:658:5)
[9/15/2019, 7:40:39 PM] Got SIGTERM, shutting down Homebridge...
[9/15/2019, 7:40:39 PM] [Loft] INFO - shutdown
homebridge.service: Main process exited, code=exited, status=143/n/a
homebridge.service: Failed with result 'exit-code'.
homebridge.service: Service RestartSec=3s expired, scheduling restart.
homebridge.service: Scheduled restart job, restart counter is at 1.
Stopped Homebridge.
Started Homebridge.

On Sep 15, 2019, at 7:40 PM, Miki<EMAIL_ADDRESS>wrote:
While you have the logs open, manually turn one of the plus on or off with its physical button. Do you see an error in the logs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/AMoo-Miki/homebridge-tuya-lan/issues/80?email_source=notifications&email_token=ANEENGXOA2NZNR7SS7DJ5JDQJ3WYBA5CNFSM4IUVN6WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6X7M6Q#issuecomment-531625594, or mute the thread https://github.com/notifications/unsubscribe-auth/ANEENGTHZXRGFAKQVNTUVPDQJ3WYBANCNFSM4IUVN6WA.

Great hold on.


clean() does not drop foreign keys in MySQL

MySQL does not remove foreign keys when tables are dropped.
This lead us in practice to a "errno 150" when we ran Flyway clean() and then re-ran our migrations after having renamed a table in a later migration but neglected to drop the old foreign key.
Should the behavior of Flyway's clean() also remove foreign keys? It already removes tables, views, and events.
Thanks!

Please post an example migration script that Flyway then fails to clean so we can reproduce this.
Cheers
Axel

Any news?

I'm unable to reproduce this currently. I did not capture the particular details and a superficial migration removing tables with data and foreign keys does work.


python312Packages.portion: 2.5.0 -> 2.6.0

Things done
Changelog: https://github.com/AlexandreDecan/portion/blob/refs/tags/2.6.0/CHANGELOG.md

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 349263

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.portion
python311Packages.portion.dist
python312Packages.portion
python312Packages.portion.dist

aarch64-linux

:white_check_mark: 4 packages built:

python311Packages.portion
python311Packages.portion.dist
python312Packages.portion
python312Packages.portion.dist

x86_64-darwin

:white_check_mark: 4 packages built:

python311Packages.portion
python311Packages.portion.dist
python312Packages.portion
python312Packages.portion.dist

aarch64-darwin

:white_check_mark: 4 packages built:

python311Packages.portion
python311Packages.portion.dist
python312Packages.portion
python312Packages.portion.dist


Add Python 3 Support and Enable Execution on Mac OS X

Note to maintainers: I wasn't sure if there's a place for support files like six.py, so by all means move it to somewhere more appropriate.

Ugh, sorry to have you hang there, just saw it, i'm not really using this anymore, but if it's useful to you, great, so i'm merging :).


mkdir command returning "bad address" on ubuntu distro wsl2

I am on windows 10 2004 with wsl2 running Ubuntu with wsl 2.
NAME STATE VERSION
Ubuntu Running 2
My c drive is mounted as below:
uditr@u-PC:/mnt$ ls -la
total 8
drwxr-xr-x  4 root  root  4096 Jun 22 04:45 .
drwxr-xr-x 19 root  root  4096 Jun 23 16:21 ..
drwxrwxrwx  1 uditr uditr 4096 Jun 23 12:05 c
drwxrwxrwt  2 root  root    40 Jun 23 16:21 wsl
when I try to create a folder using mkdir command, it returns the following:
uditr@u-PC:/mnt/c/Users/uditr$ cd desktop
uditr@u-PC:/mnt/c/Users/uditr/desktop$ mkdir myfolder
mkdir: cannot create directory ‘myfolder’: Bad address
when the distro was in wsl version 1, mkdir command worked just fine, the problem is with wsl2.
After this error, c drive unmounts and no file level command works
ls also returns the following:
uditr@u-PC:/mnt/c/Users/uditr/desktop$ ls
ls: cannot open directory '.': Input/output error
After this, when I check back the mnt folder I get the following result.
uditr@u-PC:/mnt$ ls -la
ls: cannot access 'c': Input/output error
total 8
drwxr-xr-x 4 root root 4096 Jun 22 04:45 .
drwxr-xr-x 19 root root 4096 Jun 23 16:13 ..
d????????? ? ? ? ? ? c
drwxrwxrwt 2 root root 40 Jun 23 16:11 wsl

Can you please attach an strace output of the command failing?
Because you can't cp it to /mnt/c right now, try:
sudo apt install -y strace
strace -o output.txt mkdir /mnt/c/Users/uditr/test
cat output.txt | clip.exe

Then open notepad/other editor, paste in log, save and attach.

Same issue here. I can reproduce it trying to create a folder inside the mounted drive C: from wsl.
Ouput is attached here: output.txt

uditr@u-PC:/mnt/c/Users/uditr/desktop

Before getting into the EIO state, what is the output of:
$ ls /mnt/c/Users/uditr/[dD]esktop
$ cmd.exe /c 'dir C:\Users\uditr' | grep -i desktop

For me looks like:

...which is expected behavior. No 'desktop' subfolder, absent some deliberate steps to create one.
The reason I ask is "Users\you\desktop" is a really unusual folder name to create under your Windows home. The Desktop path you see in Windows Explorer is not actually a directory.

As I run into the same issue, I want to repoen this ticket again.
I studied the information given by @sirredbeard and @therealkenc and can provide following additional information:
My test happens within a directory on windows drive C: which is called workspace.
Using windows CMD, I am able to list the directory content:
C:\workspace>dir
 Datenträger in Laufwerk C: ist Windows
 Volumeseriennummer: CAD6-A6CA

 Verzeichnis von C:\workspace

01.06.2021  08:03    <DIR>          .
01.06.2021  08:03    <DIR>          ..
01.06.2021  08:03    <DIR>          BCOM
               0 Datei(en),              0 Bytes
               3 Verzeichnis(se), 389.844.418.560 Bytes frei

Now I try to list the same content in WSL2 (OK) and create a new subdirectory (notOK).
After the mkdir failure, even listing the content is not possible anymore:
cv@ubuntu -> ~ $ cd /mnt/c/workspace
cv@ubuntu -> /mnt/c/workspace $ ls -l
total 0
drwxrwxrwx 1 cv cv 512 Jun  1 08:03 BCOM

cv@ubuntu -> /mnt/c/workspace $ strace -o ~/output.txt mkdir test
mkdir: cannot create directory ‘test’: Bad address

cv@ubuntu -> /mnt/c/workspace $ strace -o ~/output2.txt ls -l
ls: cannot open directory '.': Input/output error

Please find attached the strace output of the commands:
output.txt
output2.txt
After this failure, all windows executables additionally seem not to be available anymore:
cv@ubuntu -> ~ $ cat output.txt | clip.exe
zsh: Input/output error: clip.exe

Additional system information:
C:\workspace>ver
Microsoft Windows [Version 10.0.19042.985]

C:\workspace>wsl -l -v
  NAME            STATE           VERSION
* Ubuntu-20.04    Running         2
  Debian          Stopped         2

I can reproduce this issue, what info do you need to debug the issue?

I ran into this issue when running "Ubuntu 20.04 LTS" from the Windows Store, the issue fixed for me when I reinstalled with just the "Ubuntu" installation. Not sure about the technical details though.

I still do have this issue regardless of using ubuntu or ubuntu20.04.
Still waiting for any hint how to fix this!


Azure ATP does not exists anymore

The page mentions Azure Advanced Threat Protection for AAD, however this product is now called Defender for Identity

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d6eed2e9-9f84-ef2f-82c5-82a933b45609
Version Independent ID: 9f40abab-94ae-3f76-16e4-8917ea30e8ed
Content: Azure security baseline for Cost Management
Content Source: benchmark/azure/baselines/cost-management-security-baseline.md
Service: cost-management-billing
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@tuxnam Thanks for the feedback. We will look into this and get back with an update.

@msmbaldwin FYI!

@tuxnam Hi there. You're right about ATP getting replaced. We're working on updating the article. Thanks for letting us know about this issue.
https://github.com/MicrosoftDocs/security-benchmark-docs-pr/pull/103
#please-close


How to properly match files in callbacks to uploader elements

More a question than an issue:
Currently I'm matching the file received from various callbacks to my uploader elements by using a custom filename attribute on those elements. That seems a bit messy (works well though). So for example to update the progress of a file I do:
 $('.uploading_file[data-file-name="' + data.files[0].name + '"]' .upload_percentage').html(progress);

However, I'm wondering if there is a simpler way.

Yep, there is a better way:
Just set data.context to your upload element before you fire data.submit, this will make it the target of this in the corresponding callbacks.

Great, thanks for the tip!


Form's generateHTML doesn't seem to work with type='select'

Using a field with type='select' in a auto-generated form does not work properly: instead of a SELECT element, DOM contains an INPUT.
I patched this adding a line in function generateHTML:
if (field.type == 'select') input = '<select name="'+ field.name +'" '+ field.html.attr +'>';
before the line:
if (field.type == 'toggle')   input = '<input name="'+ field.name +'" type="checkbox" '+ field.html.attr +'

I looked up some test scripts and it works just fine. Please specify version you used and provide JS fiddle to illustrate the problem

Closing issue: cannot reproduce.
Looks fine in the demos: http://w2ui.com/web/demos/#/form/3
Looks fine in a fiddle: https://jsfiddle.net/gjkd0a39/


{String,List}#[last]indexOf should return null instead of -1

This issue was originally filed by @seaneagan

See mailing list discussion:
https://groups.google.com/a/dartlang.org/forum/#!topic/misc/QRRY18rjoBE

Is there any update for this? Still it return -1 instead of null!

This issue is closed and marked as "not planned", so there is no plan to make any change to this current behavior.


Brand Collab request and accept,reject Ui And refactor Fixed

Description:
Brand profile collab requests and accept, reject, ui and refactoring and api call fixed and added.
Issue
Issue Link resolve #250

@Kajol-Kumari  @RohitGupta1237  can you please check.


Backtracking Algorithm(N-Queen) | Java

Title - N-Queen Backtracking Problem
what will change - Add new folder of backtracking in algorithm and code for N-Queen Problem.
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code
[] Improving Code
[] Improving Documentation
[] Bug Fix

Programming Language
Please add/delete options that are not relevant.

[] Python
[] C++
[x] Java
[] C
[] Go
[] Other language

Self Check

Ask for issue assignment before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Happy Coding,

Assign this task to me!


[History] Feature/mas 1759 get transfers

Change Description

Create get_transfers endpoint
Make get_transfers return specific information about transfers
Add transfers object to contract_types to support deserializing transfer action data
Support for trnsfiopbky, transfer
Fees collected from transaction are extracted and displayed in transfer_information record
subtransactions of trnsfiopbky are excepted from displaying transfers

We only want to roll this out in V1 history if we plan on supporting a similar endpoint in the new State History and/or Hyperion. Need to discuss this in the context of the EOSIO 2.x FIO upgrade.

Putting the get_transfers endpoint on hold. It is part of a larger discussion with wallets and exchanges regarding what, if any, issues they are encountering with accessing transaction data. If it is determined that a new endpoint is needed to access transaction data, we can re-open the story.
Keeping the branch in Draft for now.


Changing CLImageEditorTheme properties don't affect style

Changing CLImageEditorTheme properties don't affect style
    [CLImageEditorTheme theme].backgroundColor = [UIColor blackColor];
    [CLImageEditorTheme theme].toolbarColor = [UIColor blackColor];
    [CLImageEditorTheme theme].toolbarTextColor = [UIColor blackColor];
    CLImageEditor *editor = [[CLImageEditor alloc] initWithImage:image];
    editor.theme.backgroundColor = [UIColor blackColor];
    editor.theme.toolbarColor = [UIColor blackColor];
    editor.theme.toolbarTextColor = [UIColor blackColor];
    editor.delegate = self;
    [picker presentViewController:editor animated:YES completion:nil];
No success, still showing white Top Bar with 'Back' and 'OK' on any filter press.

I bumped into this too.  CLImageEditor is not setting the navigation bar color.  In the _CLImageEditorViewController.m file, there is a method named -(void)initNavigationBar.   Find the line that reads _navigationBar = navigationBar;  Immediately after that, I used the following code to set the nav bar color using the toolbarColor from the theme.  Not perfect, but it worked.
_navigationBar.barTintColor = [CLImageEditorTheme theme].toolbarColor ;


Access denied on S3 buckets

Hi!
I'm trying to access y8m dataset, but getting the AccesDenied:
$ aws s3 ls --no-sign-request s3://aws-roda-ml-datalake/yt8m_ods/

An error occurred (AllAccessDisabled) when calling the ListObjectsV2 operation: All access to this object has been disabled

Couple of weeks ago the same command worked fine. Could you please suggest how to get the data with s3 client?

I am seeing the same thing.


Can we change the style of cells in table which we have edited ?

Hello, @AllenFang I am using this library in my project, and I have some data which renders then if a user edits some cells using cellEditFactory then is there any ay I can show those cells in bold that user has edited, only these cells which have been edited.
meanwhile, I am using this little piece of code inside the cell edit factory, but this is not working for me.
if (Number(oldValue) !== Number(newValue)) {
column.style = { fontWeight: "bold" };
}

@AllenFang needs your insight in this.

Issue resolved we can use formatter and use div to set the custom style, also to see the values edited on not we can compare between oldValue and newValue, for more read:


Fix: signup and login buttons are aligned centered

issue #63
@Creatoon
signup and login buttons are aligned centered.
review it and pull the request.

@rajanandraj04 Great, you have done a nice job, as this is your starting issue that's why I have given you these tips, but from future onwards take care of these small things by yourself and instead of making the same pr again, you could have pushed changes on the same branch.
Just be consistent in open source, Community is always there to help you.

#70 contains a thread of this issue.


Fix bounds check in DateTime::from_time

The bounds check in the DateTime::from_time function did not use the correct bounds for checking the year.
The new bounds are [80, 207], which accounts for the tm_year field storing the years since 1900.

Nice find, thanks! 👍


Change owner on generated output files, log, checksum file

Now uses SUDO_UID and SUDO_GID from config file, seems to work.


Wrong flag for Suriname (SR)

Colors are slightly different
https://en.wikipedia.org/wiki/Flag_of_Suriname#/media/File:Flag_of_Suriname.svg

Would you mind also linking in the issue to the flag in the repo for fast comparison?
https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/sr.svg
https://github.com/lipis/flag-icon-css/blob/master/flags/1x1/sr.svg

Ok, will do for future issues.


Split combined borehole 163

Borehole 163 from odegard1997 is the combination of a 100 m borehole (temperature_uncertainty: 0.05, installed 1994-04-28) and a 52 m borehole (temperature_uncertainty: 0.03, installed 1995-04-02) 5 m apart. These should be split apart. They were drilled (and likely measured) in different years.

@ezwelty I decided (let me know if you want me to do this differently) to keep them as one borehole (and one profile), but updated the notes with additional uncertainty and the profile.min_date and profile.max_date with possible date range. Otherwise we have two profiles with the same data, which also seem inconsistent?


[Feature Request] Proxy service request and response without (de)serialization

Description
This requires the new feature in rclcpp, rcl and rmw such as rmw_take_serialized_request.
Currently in the code load balancer does (de)serialization when it needs to proxy the service request and response messages.
This is what we can do at this moment, but it would be much better for the performance and efficiency to proxy the serialized data without (de)serialization in the load balancer.

Yes, the current forwarding efficiency is quite low because it doesn't directly forward serialized data.
Like with Topic, we need the RMW layer to provide an interface to directly access serialized data, which can then be encapsulated through rcl and rclcpp for use at higher levels.
Once this new interface is ready, I will update code to provide better performance.


Support Tornado V5

I analyzed your code and found that just removing the "io_loop" param would be the easy way to support Tornado v5. Through my use, I haven't found a problem yet.

Hi @willxin1024.
Thank you pull request.
But, I'd like to hire your code when releasing v.0.5.
If you delete the io_loop variable, you will need to modify the test code, but are there any good ideas?


specs for control node

Just a question: Why is it relevant to give the specs that we use internally?
For the context, I'm not against adding specs that may help users to understand what hardware is known to work. My concern is tying the project and docs to Hedgehog as a company. Could we maybe rephrase it as “The VLAB is known to work on the following setup:” or “The project CI runs on:”, or “Project maintainers use the following setup:”?

@qmonnet the main goal is to have an easily referenceable section in docs to share with prospects as our tested recommendation.

@Frostman Got it, but presented as Hedgehog 's (the company) setup, it doesn't give a vendor-neutral look to the project. Looking ahead, if we intend to set up some open-source governance model for the Fabric in the future, then there will be no reason that one vendor gets to list their setup in the project's docs, and not competition.
It's probably early to care too much about that, given at the moment it's necessary to register with Hedgehog to get the artefacts and run the Fabric anyway, but I think it's still something worth considering 🙂

@Frostman Got it, but presented as Hedgehog 's (the company) setup, it doesn't give a vendor-neutral look to the project. Looking ahead, if we intend to set up some open-source governance model for the Fabric in the future, then there will be no reason that one vendor gets to list their setup in the project's docs, and not competition.
It's probably early to care too much about that, given at the moment it's necessary to register with Hedgehog to get the artefacts and run the Fabric anyway, but I think it's still something worth considering 🙂

100% agree with you, at some point we will need to do a cleanup and separate company and project. Some of the examples would be docs under company domain, company name in the API namespace, Broadcom sonic dependency, etc.


CoreFoundation: synchronize CF_EXPORT and CF_PRIVATE decorations

This is needed to ensure that CoreFoundation is built with the correct
visibility to enable re-export of symbols from Foundation.  The
adjustment to the sources are needed to synchronize the headers with the
sources.
The changes to the locale constants are needed as variable declarations
cannot be aliases according to clang.

CC: @parkera @phausler @millenomi

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

This has some severe consequences for synchronizing this back to macOS/iOS. I don’t want to merge this until we can reconsile those issues.

Well first off you are exposing symbols that we are not willing to make API; which is a no-go for merging back unless we are willing to devote support for it. We don’t have these symbols as public export on Darwin, so what is the issue here? Perhaps a deeper explanation of the problem at hand would be good. Because it works today on Linux and Darwin and this brings in a huge level of risk/need for support.

The problem is that the headers and the source files are in conflict.  Its unclear which API and SPI need to be exposed to support Foundation.  A concrete example is _GetThreadName.  That is an SPI which is used, and needs to be exported so that it can be used.  However, I'm happy to go through and change the functions which are now exported as being internal only (so that the header alters the decoration).  Would you mind going through and pointing out which are SPIs and which are not?

The best way to do this is to rely on the symbolic exports detailed by nm (using the system CF as reference)

@phausler - okay, reconciled it with that list.  There are a couple that need to be adjusted to support the tests/SPIs.  But, the vast majority are now marked as internal.

This looks more in the right direction. I will need to take some time with this to ensure it won’t break the Darwin side.

@phausler - sure.  I would appreciate it if you could take a look at this sooner though as it as we are really close to having the CMake based build working now :-).

@swift-ci please test

@swift-ci please test

I'm not sure about the effects of this one. Need some more time to review.

Okay, moved the declarations and switched Darwin to also use the visibility to permit building it with hidden visibility by default there as well.

@parkera ping

@parkera - hey, so, this is going to block a bunch of other work too :-( ... can you please take a look at this soon?

@swift-ci please test

Sorry for the delay on this. I'll take a look.

I'm still stuck on changing the definition of CF_EXPORT here. It's used all over the rest of the projects in the OS itself, and anyone who uses the SDK can also use this macro. If we remove extern from it then we will change its meaning, which is clear for CF itself from the diff required here to add it back to various constants.

I think we could change the definition to:
#define CF_EXPORT extern __attribute__((__visibility__("default")))

and fix up the mismatches between CF_EXPORT and CF_PRIVATE. The symbols that are used by the Swift Foundation code can be marked CF_CROSS_PLATFORM_EXPORT instead of CF_EXPORT.

@parkera - just to make sure that we are both looking at the same bits, the second commit (extern-ing all the constants) should be okay right?  I'll adjust the top commit and see if I can do what you are suggesting

I tried a simple C++ library in VS2017 and it seems to accept extern __declspec(dllexport) on the declaration and definition of a function and constant value. This documentation also seems to suggest that extern __declspec(dllexport) is ok:
extern __declspec( dllexport ) int k;  // Okay; extern implies declaration.

What am I missing? Do we have enough ready that I could try to build this for Windows and see the errors? I want to get this figured out so we can unblock you.

@parkera, yeah, I think I ran into issues with clang building with that.  That was the original motivation for splitting out the extern from that.

I see; so is the problem with clang's interpretation of Microsoft's rules about the dllexport decoration?

@compnerd (is there a clang output that we can look at for the issue?)

@parkera, well, its just more strict about it.  @millenomi, sorry, I don't have it on hand.  I can see if I can get my laptop dusted off to get another build though.

I want to discuss this further.

This has a bunch of conflicting files now; @compnerd do you want to rebase or close?

@alblue - I think that I should try to rebase this.  This would be a nice thing to get right.


What went wrong: A problem occurred evaluating project ':app'. > ASCII

I am reopening this to show a fix that worked for me. This issues was closed as if it worked for everyone but did not for me and possibly others. Where else can I post this solution to help others??
I noticed the solution was to downgraded google services.gms from 4.3.2 to 4.2.0 which did not work for me and even if it did I dont like downgrading.This fix is an upgrade to newer versions and it works like a charm. I will attach screen shot of before with error and after changing these 3 lines with a succesful build and upgrading instead of downgrading. Please leave this open as the problem is not resolved when building a new flutter app with new firebase for android.  So instead, keep the 4.3.2. DO NOT DOWNGRADE TO 4.2.0. Then In the android/build.gradle (project level, not app level) upgrade these two lines............    ext.kotlin_version = '1.3.50' in build script and .................        classpath 'com.android.tools.build:gradle:3.5.0' in dependancies.  then in android/gradle/wrapper/gradle-wrapper.properties  change the version to this  distributionUrl=https://services.gradle.org/distributions/gradle-5.6.2-all.zip     it works for me on every new project that fails out of the gate for whatever reason.

Hi @Isonomic
You mentioned a closed issue, can you please link it_
Also could you please provide your updated  flutter doctor -v
and your flutter run --verbose or flutter build --verbose ?
To better address the issue, would be helpful
if you could post a minimal code sample to reproduce the problem.
Please refrain from posting pictures if not necessary.
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v'  please.
All system setups can be slightly different so its always better to open new issues and reference related issues.


[Feature] Saving source generator output in source control

Discussed in https://github.com/AvaloniaUI/Avalonia/discussions/10359

Originally posted by workgroupengineering February 16, 2023
The files created by the source generator by default are created on the fly in the intermediate files and consequently excluded from the SCM (source control manager). Since generate files they are not persisted on the SCM it is not possible to include them in the debug information of the SourceLink.
To improve the debugging experience of us developers I would like to propose setting EmitCompilerGeneratedFiles to true, so that we can indicate where to save the generated files.
Ref: Saving source generator output in source control

The point of source generators in composition API was to avoid keeping tons of repetitive files in the source control (and not to write them by hand as well).
Visual Studio and Rider are able to decompile missing code, so SourceLink shouldn't be necessary there.

Visual Studio and Rider are able to decompile missing code, so SourceLink shouldn't be necessary there.

Yes, but in many cases they are not able to inspect the symbols.


Add support for single line control flow statements in code blocks.

This adds support for C# single line variations of: if, for, foreach, do, while, lock and using.
Turns out the existing parser had 99% of the support for these scenarios already. Therefore, in this change set I went ahead and added exhaustive tests to verify things worked end-to-end.
Added a restriction to single line markup to not allow markup in single line control flow statements. Updated resx to provide a better error message for cases when users do use markup in single line control flow statements.

#9637

🆙 📅


How do you get multiple scanners on one map?

How do you get multiple scanners on one map?

I believe you just need to open multiple exe's and leaving the checkbox 'server' open for 1 of them. Still weird you can't just add accounts in 1 instance.
Correct me if im wrong.


Update limitation description about EF Core's public API not being annoted for nullability

The description tells that it is planned to address this in the Entity Framework Core 5.0 release. It seems that this was scoped out of EF Core 5.0. Also the issue which tracks this is not mentioned.
Please update the release in which it is planned to address this and include the issue which tracks this.
Consider to leave out mentioning the release here as the GitHub repository can be considered as the source-of-truth. This just avoids that this part of the  document gets out-of-date again.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 93c3721a-da23-d9ea-a054-9d786d2ff4d2
Version Independent ID: 6d3b0f96-6642-75e5-93c8-02c23f142ac4
Content: Working with nullable reference types - EF Core
Content Source: entity-framework/core/miscellaneous/nullable-reference-types.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @roji
Microsoft Alias: avickers

Thanks, submitted #3002 to fix this. Work is already underway to annotate EF for nullability.

Thanks, submitted #3002 to fix this. Work is already underway to annotate EF for nullability.


How to use swagger-ui/cors?

Problem statement
XMLHttpRequest cannot load http://<IP_ADDRESS>:2000/swagger.json. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:8080' is therefore not allowed access.
i've tried to add "Access-Control-Allow-Origin" to response header

if origin := r.Header.Get("Origin"); origin != "" {
rw.Header().Set("Access-Control-Allow-Origin", origin)
}
rw.Header().Set("Content-Type", "application/json")
rw.Header().Set("Access-Control-Allow-Methods", "POST, GET, OPTIONS, PUT, DELETE")
rw.Header().Set("Access-Control-Allow-Headers", "Content-Type, Content-Length, Accept-Encoding, X-CSRF-Token")
rw.Header().Set("Access-Control-Allow-Credentials", "true")

but not work!
I can't use swagger-ui & swagger_editor to load swager.json & test API

you can add a cors middleware.
https://github.com/rs/cors
http://goswagger.io/use/middleware/

Working example (in configure_.go):
import "github.com/rs/cors"

func setupGlobalMiddleware(handler http.Handler) http.Handler {
	handleCORS := cors.Default().Handler

	return handleCORS(handler)
}

This is not working for me, I still get 405 Method Not Allowed. Is there a new fix for this?

405 method not allowed for what?  are you sure you're requesting with the right basepath etc?
This solution has been proven to work for many people so something else must be wrong.


room member information is incomplete

sometime cannot get member nickname and gender information

related issue: #98

Hi @zhaokefei ,
Could you please provide more information about this issue so we can debug this :)
Thanks

Need More Information
Sorry, you did not follow the ISSUE Template, and there's not enough information about your problem.
In order to help us to find the problem out, you should provide all the detail information about the issue. Please make sure you are following the ISSUE Template, answer all the question, and the more important: provide the steps to reproduce the problem.
I'll close this issue. Please re-submit a new issue to provide the information that needed.


buildRustPackage: fix fetch-cargo-deps when no Cargo dependencies

Motivation for this change
buildRustPackage failed for projects that declared no dependencies in Cargo.toml.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Sorry, I made a mistake during testing, this fix does not work. However the issue is still there.


Let an alias represent more than one directory

Description
The original discussion is here: https://github.com/vitejs/vite/discussions/17344
Let us be able to create an alias, and configure it to represent more than one directory.
Example:
import { Stats, ApproveReject } from "Courses"

The Courses alias should be resolved for this file-system hierarchy:
src
    Modules
        Courses
             Admin
                   ApproveReject.jsx
            Common
                   Stats.jsx

The reason is that we break a complex UI into components, and then break those components into different directories. One directory is the components shared between roles. For example, the instructor should be able to see stats, the admin should see stats, and students should see stats for a given course. So the Stats.jsx file/component goes into the Common directory.
Then we put each role's components into the role's directory. For example, the ApproveReject.jsx file/component should be only accessible to admins.
We have an SPL that creates these mappings in a dynamically created docker-compose.yml file. For example, when our developers work on instructor.mooc.tld, they would be given these directories:
src
    Modules
        Courses
            Instructor
                 Create.jsx
            Common
                   Stats.jsx

This directory structure is created dynamically using our SPL. This means that the developer inside the docker container does not have access to ApproveReject.jsx when he is developing for the instructor panel.
Right now we need to create two aliases called CoursesCommon and CoursesAdmin. We don't have a problem with the length of these aliases or working with two aliases. The problem is that the internal knowledge is leaked out.
Our developers should know what component is shared and what is not. This becomes tricky as the number of components is increases. And this makes refactoring hard if we decide that a component should not be shared anymore or should be shared from now on.
Suggested solution
Right now you take a simple object for aliases:
    return {
        resolve: {
            alias: {
                "CoursesCommon": "src/Courses/Common/Exports.jsx",
                "CoursesAdmin": "src/Courses/Admin/Exports.jsx"
            },
            preserveSymlinks: true
        },

I recommend that you also take an array of strings for the value of an alias:
    return {
        resolve: {
            alias: {
                "Courses": [
                      "src/Courses/Common/Exports.jsx",
                      "src/Courses/Admin/Exports.jsx"
                ]
            },
            preserveSymlinks: true
        },

Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I'm not sure if alias makes sense for this usecase. How it works today is that it simply replaces the import path so that other plugins can resolve later, so for instance:
"CoursesCommon": "src/Courses/Common/Exports.jsx"

When you do import { ... } from "CoursesCommon", it replaces as import { ... } from "src/Courses/Common/Exports.jsx" (technically, paths like this usually won't work in runtime and you need to specify the absolute path instead).
If you have multiple paths, what exactly would it be replaced as? Especially given that you can import multiple named exports from a single specifier.
What this looks like is perhaps a dynamic version of barrel files, where importing "Courses" would resolve to a virtual module with:
export * from "src/Courses/Admin/Exports.jsx"
export * from "src/Courses/Common/Exports.jsx"

Which you should be able to create a plugin that creates virtual modules like this. And in this case, I think it's less related to an "alias".
Usually for features like this, we recommend to create an external Vite plugin first, and if there's many interest, we can consider having this builtin, so for now I'll close this.

@bluwy, it seems that Webpack supported this feature almost 5 years ago. Out of curiosity, what architectural difference is there to prevent it? I understand you mentioned you replaced an alias with the path it represents. But I'm curious about what the true spirit behind aliases could be.
The way I see it, an alias is a layer of abstraction. It's not a direct one-to-one map to the underlying structure. It's there to enable us to do more things (that's what abstraction does). In the ideal world, an alias should even represent a function to dynamically find those specified modules.
Anyway, thank you for the "orchestrator barrel" idea. That might solve our problem.

IIUC webpack's array support is "try each item until the first matches", which means a single alias will still map to a single file path only, so I don't think it helps your usecase here? Both webpack and Vite has the same one-to-one map structure.

In the ideal world, an alias should even represent a function to dynamically find those specified modules.

It does with customResolver, but you'd still map a single specifier to another, not multiple.

that's exactly what I want. When I say import { Stats } from "Courses" I want it to search for the first path and if it's found then it returns it.

But that doesn't help if you want to export Stats, ApproveReject that comes from two different files? Checking path by path still means you'd resolve to one path, and there's no one path that would export both Stats, ApproveReject.

Do you think it would serve our purpose? I will write import { FirstComponent, SecondComponent } from "SomeAlias". Will I be able to resolve the FirstComponent from one directory and the SecondComponent from another directory using the customResolver?

I don't think it will, with the same reasoning above.

The thing with path resolution is that you're checking if "some plugins can handle a specifier" or "the specifier matches a filesystem path". Path resolution doesn't involve parsing the file, and checking what it exports.

So, in that case the only option that remains is to merge both barrel files dynamically as you have mentioned. A dynamic barrel. Thank you.


Replays downloaded seem to be always missing the first 1 minute.

It's very much what I said in the title. I've attached one replay for testing.
Process to replicate the issue:

Download replay using lol-replay-downloader-cli at the start of a game (it should wait for 3 minutes before replay data becomes available)

Use lol-replay-observer-silex as the replay server.

I'm not sure which part is causing issue so I list all the steps that I do.
Or maybe its intended behavior?
Replay is larger than 10mb (35mb) hence external link :(
Thanks
http://www.filedropper.com/1423257502

It's a known issue, the file is downloaded, but the observer cannot retrieve the first minute. For now, I don't have the time to fix this. A PR is always appreciated.

Can you elaborate a bit more? I'm planning to fix it on my own. Where should I start? any insight is much appreciated.

Sure sorry, I think it's in the ReplayObserverClient:: getLastChunkInfo() method. The download improved speed (full game in 1~ minutes instead of the in game real length) cause a BugSplat for computer with weak performance. So I applied a fix to avoid this. I force to download slower the first minutes.
See https://github.com/EloGank/lol-replay-observer/blob/master/src/EloGank/Replay/Observer/Client/ReplayObserverClient.php#L134

I basically commented out this 3 lines of code, and the problem is gone. Of course that disable the BugSplat fix entirely, so that's not ideal at all. Should I make a PR?.
I intended to make a replay server for the mass, should I care about that BugSplat?
if ($metas['endStartupChunkId'] + 2 == $firstChunkId) {
       $firstChunkId = $metas['startGameChunkId'] + 2;
}

Hey, it also seems that riot has changed the encryption method for keyframe
and chunks.  Do you have any idea how to discover (reverse engineer) the
encryption scheme that riot is using (current patch is 6.3)
Thanks
On Wednesday, February 24, 2016, Sylvain Lorinet<EMAIL_ADDRESS>wrote:

Sure sorry, I think it's in the ReplayObserverClient:: getLastChunkInfo()
method. The download improved speed (full game in 1~ minutes instead of the
in game real length) cause a BugSplat for computer with weak performance.
So I applied a fix to avoid this. I force to download slower the first
minutes.
See
https://github.com/EloGank/lol-replay-observer/blob/master/src/EloGank/Replay/Observer/Client/ReplayObserverClient.php#L134
—
Reply to this email directly or view it on GitHub
https://github.com/EloGank/lol-replay-downloader-cli/issues/6#issuecomment-188342336
.

You should try just after rebooting your computer. Shaders won't be in cache, and the bugsplat has better chance to occure.
You can't see the keyframe/chunk content with the new patch ?

I can see the content saved keyframe.decoded, chunk.decoded. However I cant
really make sense of data in it, using the keyframe specification in
lolspec repo. Is the specification outdated?
On Thursday, February 25, 2016, Sylvain Lorinet<EMAIL_ADDRESS>wrote:

You should try just after rebooting your computer. Shaders won't be in
cache, and the bugsplat has better chance to occure.
You can't see the keyframe/chunk content with the new patch ?
—
Reply to this email directly or view it on GitHub
https://github.com/EloGank/lol-replay-downloader-cli/issues/6#issuecomment-188697631
.

Do you have any idea Divi?

Sorry, I didn't see the message.
The lolspec repo is outdated after every patch indeed. Riot rework many packets after each patch.
But it's normal if you can't read the file content. You need to decode it manually by reverse engineering.


Explore MVDS

Problem
Data delivery is not guaranteed over the Waku Relay network.
In the past, issues with the network has led to developers implementing naive mechanism such as resending a message until the other party ack
We need to provide an efficient data sync mechanism for developers to improve the success of message delivery
DoD

[ ] Build/try to a PoC implementing MVDS
[ ] Define plan to implement MVDS in js-waku

From @kaiserd

This is based on the Briar protocol: https://code.briarproject.org/briar/briar-spec/blob/master/protocols/BSP.md#11-system-model

This spec is form Whisper/Waku1 times; parts of this would be redundant with gossipsub IHAVE / IWANT.
A reliable message transport can be an interesting protocol in the future, but we need to be careful with adding too much load (i.e. hinder scaling).
It does not make sense to implement the current version, imo. We would have to work on a -V2 RFC.
Something like this might be interesting for store sync in the future.

(This protocol was added before I joined, and it has never been discussed.
And afaik, the only code that exists is in the research repo: https://github.com/vacp2p/research/tree/master/archive/data_sync )

Let's close this. If needs comes then we would need to design a new protocol first.


Feature/pool enhancements

Support for Batch Size
Batch Size of the pool creation is now configurable by basis of an
additional flag, rather than the hardcoded value of 10

Support for relaxing all ip ranges
The schema now supports an addition relax_all_ip_ranges, which can
relax all ip ranges in the created scratch org, mainly for non CI users

Bugfix Deletion of ScratchOrg
ScratchOrg that had script execution failures where not returned to
the pool.

@manisfdcsfdx  with this we can move Scratch Org Pool out of Beta


Image preview in HTTP Response looks ugly

HTTP response with content-type of image (png, jpeg, etc.) looks like attempt to show text instead the real image graphics.
Expected outcome
Show image in user friendly way.
Actual outcome
Text attempt to show binary data.
Versions
App: 10.0.12
Platform: 5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.132 Safari/537.36
Steps to reproduce

Request external service that return an image in response.
for example: https://hackernoon.com/hn-images/0*4ty0Adbdg4dsVBo3.png

Hi,
Sorry for late response.
The image you posted is from Chrome application. Actively maitained is Desktop client. You can get it from https://install.advancedrestclient.com/install
Version 14 (now in beta) will have dedicated images preview. It also has PDF view to avoid binary data rendering.
I am closing iot as fixed in Ddesktop client.


When setting a 2D Pose Estimate, RViz incorrectly logs "Setting goal"

When setting a 2D Pose Estimate, RViz incorrectly logs "Setting goal".
Below is the log output from setting a 2D Pose Estimate then setting a 2D Nav Goal:
[INFO] [rviz2]: Setting goal: Frame:map, Position(1.30849, -2.7475, 0), Orientation(0, 0, 0.624316, 0.781172) = Angle: 1.34851
[INFO] [rviz2]: Setting goal: Frame:map, Position(-2.8186, 2.15941, 0), Orientation(0, 0, 0.555852, 0.831281) = Angle: 1.17878

This is a blocker issue for navigation, see https://github.com/ros-planning/navigation2/issues/905 and https://github.com/ros-planning/navigation2/issues/901.

This is a blocker issue for navigation

I don't think this issue should block you. Despite that the log says "setting goal", it still publishes an initial pose that I have successfully used in AMCL to seed localization.

Yeah, I probably should say "the rviz2 no responding issue" is a blocker issue which we met in both ros-planning/navigation2#905 and ros-planning/navigation2#901.

But that's a different issue. This issue is about the fact that the log message for the 2d pose estimate is wrong. That's true but it definitely doesn't affect any publishing of the goal itself.
You should probably open a different issue for each potential bug for tracking purposes.


Merge Uat ke Master 24 July 2017

Coverage increased (+0.2%) to 66.948% when pulling ba136fa29335c379f1299d51623d92d929a58efd on uat into 6c00060501c9d0e6e55b3ae01d1399f2d722da65 on master.


Weavewindow

Issue: GNB's No Mercy window asks for 9 GCDs for an estimated 2.49 GCD.
Fix: Introduce a very conservative weave delay estimate for buff windows to the ExpectedGcdCountEvaluator and AllowedGcdsOnlyEvaluator modules.
Because buffs with stacks (Meikyo Shisui, Blood Weapon, Swiftcast, Zoe) end immediately after the stack is consumed, this weave delay calculation would change the GCD incorrectly. Buffs with stacks are excluded from this change.
Test Plan:
Buffs using these modules are DRG (Dragon Sight, Battle Litany, Lance Charge), DRK (Blood Weapon), PLD (Fight or Flight, Tincture), SAM (Meikyo Shisui), GNB (No Mercy), BRD (Raging Strikes), MNK (Riddle of Fire), NIN (Trick Attack), SGE (Zoe), AST/SGE/RDM/SMN/WHM (Swiftcast).
I used the following logs to compare buff modules:
https://www.fflogs.com/reports/zHFwdv9bkBPgnYVX - test logs for DRG, DRK, PLD 2.44, 2.50, SAM, GNB 2.44, 2.45, 2.46, 2.49, 2.50, BRD, MNK, NIN, SGE. Each job includes both successful and failed buff windows. PLD/GNB include some early deaths during buff window.

fight 2 GNB 2.44 expects 7 GCDs instead of 8. It's an early death so probably OK.
fight 14 GNB 2.45 expects 6 GCDs instead of 7. Another early death.
fight 18 GNB 2.49 expects 8 GCDs instead of 9. Intended change.

https://xivanalysis.com/fflogs/NHyJtja7kGMDLFCY - GNB at 2.49 (fight 4) vs 2.50 (fight 14)

fight 4 GNB expects 8 GCDs. Intended change.

https://xivanalysis.com/fflogs/myFVR4WGCZ6PBhgH/ - tests logs for PLD at 2.42, 2.43, 2.50, MNK at 1.94, 2.00, and SSS 4.0, RDM swiftcast, PLD tincture

no changes

https://xivanalysis.com/fflogs/72pCAcYwRXyjqhDF#fight=12&type=damage-done - high end MNK, DRK, GNB

no changes

https://xivanalysis.com/fflogs/9k4hq3BLF8RDnaMQ#fight=23&type=damage-done - another high end MNK, DRK, GNB with GNB at 2.49 estimated GCD

GNB now shows 8/8 GCDs on No Mercy

https://xivanalysis.com/fflogs/6WY24f7gPNThBnxA#fight=13&type=damage-done - PLD with 2.49 estimated GCD on fight 9

no changes

I haven't fully read this yet. But I'm not sure I like the idea of windows adjusting themselves based on death. I feel like that might be confusing to users unless we add a note to explain they died mid buff window.

I haven't fully read this yet. But I'm not sure I like the idea of windows adjusting themselves based on death. I feel like that might be confusing to users unless we add a note to explain they died mid buff window.

I actually did not change that behavior! This was already baked into the analysis tool. Your buff expires on death, so we look at the shortened buff duration.


Cannot find module 'styled-jsx/css'

Hello everyone, thanks for the great project and all the work you guys are doing at Zeit, incredibly awesome work.
I'm having a weird problem when trying to import styled-jsx/css.
I see that you have specs for it so I think it's extremely unlikely to be a problem with the project itself.
But I decide to open the issue anyway in case I'm missing something...
I'm using "styled-jsx": "2.0.2", things that I tried without success:

Importing it on my project with NextJs
Adding styled-jsx as my project dependency
Creating an empty project, adding styled-jsx as dependency, and trying to simply require('styled-jsx/css')
Using the same node version as you use on travis
Cloning the project + yarn link + simply requiring it

All of them using 2.0.2 and with the same outcome: Cannot find module 'styled-jsx/css'.
Any thoughts? I hope it's not something stupid from my side 😓💭

Still the same for me. see

@Nipher styled-jsx 2.0 is integrated only in Next.js v4, if you have a project that is using v3 there is no way to use a different version of styled-jsx

also make sure that you clean any cache:
rm -rf node_modules/.cache .next

Hey @giuseppeg, thanks for the fast reply, I'm using the "next": "beta" actually, does it work with the beta?
Also I created a project only with styled-jsx, all stand alone, without nextjs, with no luck.
I tried removingnode_modules/.cache in my node_modules, but I had no luck 😕
In the meantime I managed to use pure template literals and not use styled-jsx/css, but I would love to use it instead.

I think some of the latest beta version ships with v2. styled-jsx/css is a fake import to detect css files/blocks internally the plugin eventually removes it. So if you are getting an error chances are that the plugin is not running at all.

I've done the same, starting up a brand new app with<EMAIL_ADDRESS>styled-jsx@, using just the sample given in the README:
/* styles.js */
import css from 'styled-jsx/css'

export const button = css`button { color: hotpink; }`
export default css`div { color: green; }`

This dependency was not found:

* styled-jsx/css in ./styles/index.js

alright folks I need a test case repo to debug this issue

@rgbkrk I've tried your case and can't reproduce 🤔

I'm having this issue too.
IIRC this is caused because there's no css.js file in the root of the project like this, but as @giuseppeg mentioned "styled-jsx/css is a fake import to detect css" so I don't know how to fix it.

also having the issue. I couldn't reproduce from the sample repo, but is verified not working in a project i upgraded from next 3

Just created a NextJs simple test repository from scratch (using<EMAIL_ADDRESS>+<EMAIL_ADDRESS>and it worked with a very quick and simple example! 👍
I'll upgrade my project to use 4.1.0 🙇
I wonder how this fake path works though, I'll look into it later for curiosity 🤔
Thank you for your time guys, I hope everyone else can also make it work with the same versions that I'm using on the test rep 😕
I would close the issue but not sure if you guys would like to check if everyone else managed to get it working fine, I didn't test with the same version as @rgbkrk though, not sure if it should be working there also.

In my case it still does not work, I'm not using next.js so can't upgrade it. Would be good to re-open this issue if possible.
Here's the project that fails: https://github.com/bukinoshita/pilot-component/tree/add/external-css

@bukinoshita you are importing ‘next/css’ in styles.js it shoukd be ‘styled-jsx/css’ instead

@giuseppeg you are right, my bad.  I had that fixed tho and still gives me the error
ERROR in ./src/styles.js
Module not found: Error: Can't resolve 'styled-jsx/css' in

Can we reopen @giuseppeg ??

@bukinoshita chances are that webpack or something else tries to load files/resolve imports before transpiling them with babel. Check your build pipeline

I'm having the same issue with 2.2.0 in a Meteor project

gonna release v2.2.1 today which should fix this

published

@giuseppeg Still experiencing this several month later. Using:
import css from 'styled-jsx/css';

export const global = css.global`
  html {
    font-size: 16px;
  }
  body {
    padding: 0;
  }
`;

Gets me:
Uncaught ReferenceError: css is not defined

Using Webpack 4.6.0 + Babel 7.0.0-beta.46.

@giuseppeg Ok, found out that this feature is still to be released. My bad.
Still, it's rather confusing to see "docs for v3" instructing you to install module using npm install --save styled-jsx, which won't get you the module you're documenting.

@nfantone yeah sorry about that

@giuseppeg Even if not using css.global I can't make the "fake" import to work properly with jest. Every time I run tests, I get:
  ● Test suite failed to run

    ReferenceError: css is not defined

      1 | import css from 'styled-jsx/css';
      2 |
    > 3 | console.log(css);

My Babel config already includes "styled-jsx/babel" and it works fine when building the application. But the jest runner doesn't seem to be liking it or it's conflicting in some way.
Any ideas?

what is your setup like?

@giuseppeg Looks something like the following:

React toolkit library built with Rollup.
styled-jsx 2.2.7
Using Babel 7.0.0-beta.46, with .babelrc below:

{
    "presets": [
      "react-app"
    ],
    "plugins": [
      "styled-jsx/babel"
    ]
}

Running jest + babel-jest (both ^23.4.0).
Slightly simplified CRA standard Jest configuration.

{
  "jest": {
    "verbose": true,
    "collectCoverageFrom": [
      "src/**/*.{js,jsx,mjs}"
    ],
    "transform": {
      "^.+\\.(js|jsx|mjs)$": "babel-jest",
      "^(?!.*\\.(js|jsx|mjs|css|json)$)": "<rootDir>/file-transform.js"
    },
    "transformIgnorePatterns": [
      "[/\\\\]node_modules[/\\\\].+\\.(js|jsx|mjs)$"
    ],
    "setupFiles": [
      "<rootDir>/polyfills.js"
    ],
    "setupTestFrameworkScriptFile": "<rootDir>/enzyme.config.js",
    "testEnvironment": "node",
    "moduleNameMapper": {
      "\\.css$": "identity-obj-proxy"
    }
  }
}

My suspicion is that jest does not know about styled-jsx/babel or is not being picked up.

@nfantone have you tried to transpile a colocated style tag:
() => {
  return
hi

}

Is that one transpiled? I can take a look if you put together a sample minimal repo.

@giuseppeg Yes, inline styles work as expected. The offending part is the "fake" css import.
I managed to put together a reproducible case. And even though it's doesn't exactly match my setup and doesn't output the same error, it does lead to the same behavior. I think this deserves an issue of its own. I'll open one now.

@giuseppeg Sorry for the delay on this. Here: https://github.com/zeit/styled-jsx/issues/469 - I've opened a new issue with a description of reproducible case so we can better track the problem down.


Apply loop contracts only if there exists some usage

In this PR, we detect the usage of loop contracts, and apply loop contracts with goto-instrument only if there exists some usage of loop contracts in the codegen unit.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@celinval I added two tests in this PR: one for harness without loop but loop contracts is enabled. One for harness with loop contracts, but loop contracts is not enabled. In both harness, Kani performs as no loop contracts present---unwind all loops.
We should apply loop contracts only when there exist some usages of loop contracts and the loop contracts is enabled by users.
I also fixed a bug in hook.rs of not correctly handling loop_contracts_register_function when loop contracts is not enabled.


knot-dns: 3.1.1 -> 3.1.2

https://gitlab.nic.cz/knot/knot-dns/-/tags/v3.1.2
The patch was included in this release.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 137106 at 12c40d99 run on x86_64-linux 1

2 packages built successfully:

knot-dns
knot-resolver


tutorial pages are also marked as stubs

the tutorial pages are marked as stubs, since, they are not usual guide articles, they shouldn't be treated as stubs and if possible they can only be considered as the sidebar heading that leads into the dropdown rather than acting as a link that opens a page.
Add a Link to the page with the problem:
https://guide.freecodecamp.org/css/tutorials/

@PragatiVerma18 Instead of creating a new issue for each section you find stubs in, I think it is best to change your original issue title to some less specific regarding stubs in the Guide.  There are going to be stubs scattered through all the Guide sections.  Plus update your other issue.  I am closing this one now.
Thank you.


Extra span tags in paragraphs

Pell seems to be putting extra span tags with font-size formatting in paragraphs tags. Did I do something to cause this, is it a bug, or intentional? If it is intentional is there someway to disable this?
[misc. text]

Thanks.

I encountered the same thing, solved it with this https://github.com/jaredreich/pell/issues/123

This issue happens when we add some texts, and remove the end of line.
Does that on Chrome, apparently not on Firefox.

It doesn't even happen when we copy/paste some text.
This issue is probably related to the browser, but still.

The solution we found to avoid the problem is to force some styles on the elements inside the contenteditable using CSS, like this:
.pell-content p {
    font-size: unset !important;
}

This way the span tags don't appear anymore.


Add vJunos-Router kind based on existing vJunos-switch implementation

This PR adds a vJunos-Router kind to match the recently added vrnetlab image: https://github.com/hellt/vrnetlab/pull/196
Since both vJunos-Switch and vJunos-Router images are handled identically by containerlab, alternatively, the two kinds could be merged into a "vJunos" or "vJunos-Classic" kind that handles both vJunos-Switch and vJunos-Router nodes; however, this difference in naming might be confusing to users.
This PR also contains some minor fixes to syntactic fixes to the documentation and adds short name support for other vJunos kinds.

Adding the new node type to https://github.com/srl-labs/containerlab/blob/main/docs/manual/vrnetlab.md will require a new release to be carved both for vrnetlab and containerlab.

Hi @vista-
thanks for your PR
I wonder, could you try and add the new kind name to this list https://github.com/srl-labs/containerlab/blob/main/nodes/vr_vjunosswitch/vr-vjunosswitch.go#L20
kindnames          = []string{"juniper_vjunosswitch","juniper_vjunosrouter"}

and then remove the duplicated code? I suppose this should work nicely but I have no vrouter image to test this myself, so if you give it a spin that might be very helpful and should reduce the duplication

@hellt merged the two kinds into one at your suggestion. For sake of simplicity, I left the vJunos-switch and vJunos-router's documentation separate.
I also updated the documentation based on your feedback, pointing out that all vJunos images can be downloaded without a Juniper account. :)

@hellt merged the two kinds into one at your suggestion. For sake of simplicity, I left the vJunos-switch and vJunos-router's documentation separate.
I also updated the documentation based on your feedback, pointing out that all vJunos images can be downloaded without a Juniper account. :)

@hellt Just pushed some changes removing the vr-prefixed short names and fixing the newlines!
Thanks for your quick review :)

great, thank you! Merging


Add AppMetadata interface, declared unimplemented methods to ProjectManagement

Description
Extend project scoped operations in the NodeJS Admin SDK with the addition of AppMetadata interface and 2 new methods into ProjectManagement class (unimplemented):

listAppMetadata() : Lists summary of all apps belongs to the project
setDisplayName(): Update display name of the project

In this pull request

Declare AppMetadata interface in AppMetadata.ts
Move AndroidAppMetadata and IosAppMetadata declaration into AppMetadata.ts
Make AndroidAppMetadata and IosAppMetadata inherited from AppMetadata
Update existing code and tests to match the change
Update types in index.d.ts (readonly will be added in a separate pr)
Declare listAppMetadata() and setDisplayName() which currently just throw errors.

@hiranya911, I have a question for AppMetadata - Should we simply add the platform field to AndroidAppMetadata with the field's type requiring it to be set to ANDROID? Or should we convert AndroidAppMetadata to a class, and give it a constructor like below?
interface AppMetadata {
  public readonly appId: string;
  public readonly displayName: string | null;
  public readonly platform: AppPlatform;
}

class AndroidAppMetadata implements AppMetadata {
  constructor(
      appId: string,
      displayName: string,
      readonly resourceName: string,
      readonly projectId: string,
      readonly packageName: string) {
    super(appId, displayName, AppPlatform.ANDROID);
  }
}

And would either of those options be considered a breaking change in the Admin SDK? There should be no reason for users of the SDK to ever construct an instance of AndroidAppMetadata themselves, but our public interface makes it possible to do so.

Is there an API proposal for these changes?
I don't think what you've proposed above will actually work. Because AppMetadata is an interface, you cannot initialize its properties in AndroidAppMetadata by calling super(). You probably need to make AppMetadata a class for that to work.

@hiranya911, I'd like to re-pose @TrCaM's question after replacing interface AppMetadata with class AppMetadata. I'll send you a link to the private API proposal.
Basically, the question is "Can we change AndroidAppMetadata and IosAppMetadata from interfaces to "classes that inherit from AppMetadata" without that being a breaking change?


Offline Transaction tab is hidden

Currently I'm unable to find a way to go to Offline Transaction tab

we moved the tab out of the way to make room for the ICO tabs, we will remove the ICO tabs and put offline TX back shortly

it's back now.


Add parameter to force path-style requests to S3 buckets

Enables the integration with LocalStack.
Fixes https://github.com/http4k/http4k-connect/issues/356

Codecov Report
Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (e2bc93f) 71.74% compared to head (e796d6b) 71.64%.
Report is 1 commits behind head on master.

Files
Patch %
Lines

...ttp4k/connect/amazon/s3/model/S3BucketPreSigner.kt
30.00%
13 Missing and 1 partial :warning:

...otlin/org/http4k/connect/amazon/s3/HttpS3Bucket.kt
44.44%
4 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #357      +/-   ##
============================================
- Coverage     71.74%   71.64%   -0.11%
  Complexity     1443     1443
============================================
  Files           781      781
  Lines          9163     9182      +19
  Branches        669      671       +2
============================================
+ Hits           6574     6578       +4
- Misses         2218     2231      +13
- Partials        371      373       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Traefik cert not renewing using AWS route53 - AWS_REGION is no longer optional

Initially had setup traefik using AWS route53 dns records months ago with success, however have since upgraded eth-docker multiple times and now certificates recently expired and traefik logs indicated errors when renewing the cert: "failed to resolve service endpoint, an AWS region is required, but was not found".
Unfortunately I don't have the logs anymore as I recreated the container after reviewing the following issue:
https://github.com/traefik/traefik/issues/10195
To renew certs again, I added AWS_REGION=XXX to .env
and added to traefik-aws.yml under services.traefik.environment
      - AWS_REGION=${AWS_REGION}

Interesting. When you look at your ~/.aws/config, does it contain a region?


Make excel related dependencies optional

I'm trying to dockerize fava and noticed the dependency on pyexcel-* caused ~22MB additional space.
Personally I never used that feature, and I could live with the CSV export if I really need it. I wonder if the dependency on them can be optional? setuptool allow extras_require in setup.py, and if people do want to export to .xlt file, they can install fava via pip install fava[excel].
Link to the doc: https://pythonhosted.org/setuptools/setuptools.html#declaring-dependencies

:+1: I also don't use the excel export and like this suggestion!

Is it possible to make this optional? Meaning that when pyexcel is installed the appropriate download-links are shown, and otherwise not.

Yes, we can wrap the import statement in a try...except... block. Will work on this.

Thanks @yagebu, nice trick on setting HAVE_EXCEL.

@yagebu Looks good!

Care to release a new version on PyPI? I'd like to pack a new docker image to reduce image size.

@yegle Sorry, forgot to reply sooner. I want to get some more features into the next release, so it might take some more time. I'm not very familiar how docker images work, but you could try building a source distribution (which will include the generated JS/CSS etc.) which you can then install with pip.


Assigning string literals to variables of different size doesn't clear old data

This yields surprising results when such variables are used as map keys. For example, the following program appears to produce duplicate map entries:
$ sudo bpftrace -
kprobe:try_to_wake_up {
  $comm = comm;
  if (pid == 0) {
    $comm = "swapper";
    @[$comm] = count();
  }
}

Attaching 1 probe...
^C
[...]
@[swapper]: 355
@[swapper]: 402
@[swapper]: 769

The issue here is that the type of $comm is string[16], but assigning a string literal of length N to it only overwrites the first N+1 bytes.
Here's the relevant part of the generated LLVM IR (note the 8-byte memcpy):
  %"$comm" = alloca [16 x i8], align 1
  [...]
  store [8 x i8] c"swapper\00", ptr %str, align 1
  call void @llvm.memcpy.p0.p0.i64(ptr align 1 %"$comm", ptr align 1 %str, i64 8, i1 false)
  [...]
  %lookup_elem = call ptr inttoptr (i64 1 to ptr)(ptr @AT_, ptr %"$comm")

Since the map key type is also string[16], all lookup/update operations are performed using all 16 bytes of the $comm variable, which looks like "swapper\0$NUM" (i.e. it includes data from the previous call to bpf_get_current_comm).
A potential fix is to emit a call to memset() to clear the destination variable prior to assigning a string literal.
$ bpftrace --version
pftrace v0.20.0-gc8fd

wow! thanks for the prompt fix


how to use overlay icon and context menu on win7

Version of SharpShell used: 2.7.1
I want to make  overlay icon and context menu  from my application on , it shoud be successed except used NativeBridge. but there is some problem about security when it access registry on windows 7，it's throw a exception typeof System.Security.SecurityException.so,how should I do?

Hey MatriQ,
sorry if that sounds a bit harsh but I can't really understand what you are trying to accomplish so I tried to put it into simple steps, please correct me If I didn't understand a point:

You want to make 2 servers in 1 dll: 1x SharpIconOverlayHandler and 1x SharpContextMenu.
This part, I don't understand, please clarify: "It should be successed except used NativeBridge"
You have a problem when it accesses the registry on Windows 7 (My guess: You mean when you install /register the server?)
The Exception is a System.Security.SecurityException

So please answer following questions for further assistance:

Did you manage to get some example server installed and running? Please download/compile one example and try it out if not done yet.
What do you mean by saying "It should be successed except used NativeBridge"?
Can you install/register the Server? How do you try to install/register? Via Regasm.exe? Via ServerManager? Via SRM.exe?
Where does the problem with the SecurityException happen? On registration (see above) or in your code? Does your Server try to access the registry?
What is the Message of the Exception? Usually it should give you information about why it failed.

When you access the registry it usually is required to have elevated privileges (except for some keys).
Maybe that's the problem?

Hey MatriQ,
sorry if that sounds a bit harsh but I can't really understand what you are trying to accomplish so I tried to put it into simple steps, please correct me If I didn't understand a point:

You want to make 2 servers in 1 dll: 1x SharpIconOverlayHandler and 1x SharpContextMenu.
This part, I don't understand, please clarify: "It should be successed except used NativeBridge"
You have a problem when it accesses the registry on Windows 7 (My guess: You mean when you install /register the server?)
The Exception is a System.Security.SecurityException

So please answer following questions for further assistance:

Did you manage to get some example server installed and running? Please download/compile one example and try it out if not done yet.
What do you mean by saying "It should be successed except used NativeBridge"?
Can you install/register the Server? How do you try to install/register? Via Regasm.exe? Via ServerManager? Via SRM.exe?
Where does the problem with the SecurityException happen? On registration (see above) or in your code? Does your Server try to access the registry?
What is the Message of the Exception? Usually it should give you information about why it failed.

When you access the registry it usually is required to have elevated privileges (except for some keys).
Maybe that's the problem?

Countryen,
I'm sorry, my words were vague.It's about install and register the server, and it was successed when I rebuild ServerRegistrationManager。
the really problem is I can't manage service use ServerManager on win7,whatever rebuild or run in administrator mode，it's no power to access the registry.

Hey MatriQ,

it's no power to access the registry.

-> Do you mean the user doesn't have access to the registry, at all?
Then you can't install your server without installing as a different user.
You need access to the registry (which an admin user should always have).
Can you try with an elevated user / admin user?
Also, can you please try one of the examples first?
If one (or all) of the examples worked, it would be a problem of your server's code, probably.
Lastly, please post the actual complete error message, does it prompt you?

Hey Countryen,
I opened the ServerManager.exe with an administrator account. and there is the error message
System.Security.SecurityException: 不允许所请求的注册表访问权。    在 Microsoft.Win32.RegistryKey.InternalOpenSubKey(String name, RegistryKeyPermissionCheck permissionCheck, Int32 rights)    在 SharpShell.ServerRegistration.ServerRegistrationManager.IsExtensionApproved(Guid serverClsid, RegistrationType registrationType)    在 SharpShell.ServerRegistration.ServerRegistrationManager.GetServerRegistrationInfo(Guid serverCLSID, RegistrationType registrationType)    在 ServerManager.ServerDetails.ServerDetailsView.Initialise(ServerEntry serverEntry)    在 ServerManager.ServerManagerForm.listViewServers_SelectedIndexChanged(Object sender, EventArgs e)    在 System.Windows.Forms.ListView.WmReflectNotify(Message& m)    在 System.Windows.Forms.ListView.WndProc(Message& m)    在 System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Hey MatriQ,
can you please translate "不允许所请求的注册表访问权。 在 " for me?
This should be the actual message, but please translate to English.
But from the looks of it:
If the method "IsExtensionApproved" is called, that would mean you already added one extension - can you give some information about the class?
Maybe the attributes of the class?
(COMServerAssociation etc.)

sorry ,
"不允许所请求的注册表访问权" means "requested registry access is not allowed".
I tested any samples of SharpShell,there were throw that exception all on win7.

Okay, but that would mean, that your user can't access the registry (or that special subkey). Now you need to find out which subkey the ServerManager is trying to access and check its security settings, every subkey can be secured seperately and iirc some anti virus programs (or firewall programs) change some key securities.
Can you list

what subkey it tries to access?
you can check that in code with some additional logging at the place where the key is accessed
also it's necessary to know which COMServerAssociationAttribute you are using

thanks, @Countryen
It's ok now. I think I copied an old file to my virtual widows7. it's  so stupid。 thanks for your help again.

@MatriQ ^^ happens - good to hear you resolved your issue. Then let's close this issue :)

OK thanks!


LabBench - list instances started across all domains

list domains
list apps et instance type of each app

in v0.1.0


Refactor blob group and package version file writing

This change refactors the blob group calculation and package version file writing such that these are done during the publish phase instead of the pack phase. The blob group and build version calculation are only done once (as opposed to for each project file). The package version is looked up using a custom MSBuild target invoked on the project file that corresponds to the package file.
The two motivations for this change are:

Minimize the number of files written to support blob subpath calculations. Note that the *.buildversionfile and *.versionfile files are no longer generated.
Allows for future changes to add more package types (e.g. *.zip and *.tar.gz) to make use of the same changes in the publish phase.

Example build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1749061&view=results

/backport to release/6.1


Hyper-express with deno

Deno is a modern runtime for JavaScript and TypeScript. It would be great If we can use hyper-express with deno. Please consider my feature request.

Since HyperExpress is built on top of uWebsockets.js, HyperExpress cannot be compatible with Deno until uWebsockets.js is also compatible with Deno.


Nice to have: help for resizing

If we want to resize by full column width steps, not just a fraction of width, we either need a snap feature or (more versatile) a popup tip displaying the width of what we are resizing. This is mostly useful for design process, not end user.

Feel free to implement and submit a PR


Suggestion: update parse.sh to reference Python3, call all parsing scripts

Hello - I just noticed the handy parse.sh script.  I was going to make two suggestions:

Call the scripts using python3 to avoid any potential conflicts
Also call parse_committees.py and parse_committee_members.py to cover all potential data changes even though committees and membership won't change often; this could then become the script users are directed to use on README.md to simplify and eliminate four steps on initial setup

I'll put together a pull request for this one, and happy to discuss.

I've merged PR #12 into gregoryfoster/legis-graph master branch.


ignoreColumns is not working

I occasionally get CSVs that have an extra comma on the header and rows. This results in the parser giving me unwanted columns, like 'field18'. I tried using the ignoreColumns option parameter like this:
		const converter = csv({
			noheader: false,
			ignoreColumns: /field\d+$/
		})

Or even hardcoding the column like this:
		const converter = csv({
			noheader: false,
			ignoreColumns: /field18/
		})

But it still gives me these unwanted columns. I suspect it is because 'field18' is not in the header. How can I get around this without deleting the trailing commas? I have an automated process, so manually editing the CSV is not an option.
Thanks!

I found the option to skip empty data columns, you can use ignoreEmpty.
const converter = csv({ 			noheader: false, 			ignoreEmpty: true 		})


⚠ Thumbnails API Endpoint has degraded performance

In 36b9c66, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 5036 ms

Resolved: Thumbnails API Endpoint performance has improved in 5f7b4ee after 25 minutes.


Add Docker template to generate-release-notes script

Starting CLI v8.0.0 we added Docker distribution.
Feature: Docker section in release notes
As cf cli user
I want to see a docker section with prepopulated docker command  in the release notes
So I can easily access docker image with new cf

Resources

Release notes script: https://github.com/cloudfoundry/cli/blob/19278c3aed08aa3ce867c02467be7e453c5c1c56/bin/generate-release-notes#L22
Example of the release with a Docker section

Closing since its complete


OAuth 2.0 Client credentials not working via GUI

Discussed in https://github.com/usebruno/bruno/discussions/1970

Originally posted by viveknz76 March 31, 2024
I tried using OAuth 2.0 client credentials (gui) in the latest version but I get the following error when I click "Get Access Token"
{
"error": "RESTEASY003065: Cannot consume content type"
}

I have the a similar issue with 1.12.3. It seems bruno sends the oauth request as json content. But standard requires it to be send as url form encoded (https://www.rfc-editor.org/rfc/rfc6749).
There exists a draft for a json oauth request (https://tools.ietf.org/html/draft-richer-oauth-json-request-00) but this is not supported by all oauth servers. BTW Brunos oauth json request is also not valid to this draft, as it does not convert scope value to list of strings ( ... "scope": ["read","write"] ... vs  ... "scope":"read write" ...)
It looks as if this should have already been fixed in #1701 But somehow it is not part of v1.12.3?

Same issue as https://github.com/usebruno/bruno/issues/1938
See also comment on merged pull request
https://github.com/usebruno/bruno/pull/1701#issuecomment-2036755440

This will go out in the 1.13.0 release. Please subscribe to Discord announcement channel to stay notified on the releases.

I am closing this issue as it has already been resolved.


Update to use WithInit() based on the changes in the dependent PR in fabric-sdk-go

Codecov Report

Merging #91 (bd6f48a) into main (997019c) will decrease coverage by 0.13%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   68.45%   68.32%   -0.14%
==========================================
  Files          47       47
  Lines        4499     4496       -3
==========================================
- Hits         3080     3072       -8
- Misses       1225     1230       +5
  Partials      194      194

Impacted Files
Coverage Δ

...nternal/fabric/client/client_gateway_clientside.go
44.05% <25.00%> (-2.52%)
:arrow_down:

internal/events/test_helper.go
90.90% <0.00%> (-3.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997019c...bd6f48a. Read the comment docs.


iyo-ImprovedIntegration: Improve sharing information with organizations

Currently an email address and phone number are requested to be shared when joining an organisation. This is not sufficient and also no business rules are in place when this authorisation is revoked.

[x] It should be possible to configure per organization what information members/owners should share
[x] We also need a way to indicate if this information is shared only the organization(+owners) or to all members.
[x] It should also be in the list of notifications of a user when he/she is part of an organization that requests some information to be shared and when he/she is not. Clicking on resolve would allow you to fix this.
[x] When someone is not sharing this information to an organization he/she is part of, this should be indicated by a ❗ in the list of owners/members and a tooltip what information is not shared.

No action to be taken when an organization removes something from it's requested share list.

Forgot to check the scopes in user /user/info call