Huge performance issue in character processing (tl;dr UTF-8 encoding methods are too slow for full time use)

I was examining speed and loading a file thousands of times.  This was loading and executing in JRuby.  Once I realized it was not compiled with optimizations enabled (used -O3)  I still noticed it was 2+x slower than JRuby's parser.  22s vs 9.8s.  I ran with async profiler and 75% of the profile was spent in 2 methods yp_encoding_utf8_alnum and yp_encoding_utf_8_isupper_char.  I then changed the file being parsed to use encoding: ascii and then Yarp on JRuby was 5.5s vs 9.8s.  Most files are generally 7 bit ASCII even though the default is UTF-8.
C Ruby's parser goes through lengths to try and stay in 7bit ASCII parsing land.  For identifiers/keywords, it has a cheap ISASCII() check and if it fails then it bails to a precise codepoint route.  This almost never happens so unsurprisingly it is a big win.  Most text even in a file containing mbc is mostly 7 bit ASCII.
For strings and heredocs it also hopes for ascii when encoding itself supports ASCII and fails to slower encoding methods when they notice.
The other thing to point out is when they do this they also track code range (unknown, 7bit, valid, broken) and it gets used for Strings to optimize better during execution.  So I think YARP will need to add this and definitely change how encoding it done.

I also saw yp_encoding_utf8_alnum in my profiling as well,

I don't see yp_encoding_utf_8_isupper_char, but I think I need to do like you did and process a file thousands of times. Right now YARP.parse is dominated by node creation time.
Good news is the call path looks really linear, so it might not be that hard to do like you suggest and add a fast ISASCII() check.

Put together something we can profile together: https://github.com/Shopify/yarp/pull/773
I'll run it through some profiling tomorrow.

Slightly tangential: there is prior art to performant decoding in C that may be worth looking at to speed up the unicode decoding as well. The gumbo parser (invented at Google and now maintained in the Nokogiri code base) uses the code described here: https://bjoern.hoehrmann.de/utf-8/decoder/dfa/
The implementation in gumbo can probably be dropped into YARP if you want to try profiling it along with the other approaches you're considering:
https://github.com/sparklemotion/nokogiri/blob/main/gumbo-parser/src/utf8.c#L40-L88

@enebo Do you have a benchmark I can run with just YARP that reproduces the,

75% of the profile was spent in 2 methods yp_encoding_utf8_alnum and yp_encoding_utf_8_isupper_char

finding?
I am having a hard time getting YARP to spend that much time in those methods.

@HParker That was within JRuby being consumed via JNI serialized data and it stood out like that.  I could not see this at all until I optimized (-O3) the files.  Are you using an optimized build?

I turned on -O3 and tried with the BUNDLE build and I can't get it over 3% time spent in alnum. Let me try profiling the serializer next Maybe there is something else in serialize that is causing this increase.

@HParker I have numbers using your PR benchmark on the PR itself

I guess we can close this now?


monorepo: show only files to be committed under workspace folder(s)

We're working on a monorepo, and each project is in a different folder under the one repository.
I have a different vscode workspace for each project, containing only the folders that are relevant to the project.
When I work on multiple projects (so, I have more than one vscode windows/workspaces) at the same time, Git(Lens) shows me all the files that have changed (to be committed) across all folders (projects).
I would like to see only the files that have changed below the folder(s) of my workspace.
There is a git command for this:
https://stackoverflow.com/questions/4104764/git-show-list-of-files-changed-in-recent-commits-in-a-specific-directory
https://stackoverflow.com/questions/16343659/how-to-show-git-log-history-for-a-sub-directory-of-a-git-repo

@digeomel where are you seeing all the files? Inside the GitLens repositories view or in the Source Control sidebar?

Source Control sidebar. I assume this is not handled by GitLens? Then I should probably remove this request and put it in the vscode github page...

@digeomel yeah, the views on the Source Control side bar are provided by the built-in Git extension for vscode (unless you have configured GitLens to explicitly add its views to that same side bar). So you should open an issue with them.

@digeomel if you think this was helpful, consider adding a reward to this issue using speedoss.com to support the issue solver for their work :)


bmake: 20230126 -> 20230414

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 231027 run on x86_64-linux 1

6 packages failed to build:

kgt
kgt.bin
kgt.doc
libfsm
libfsm.dev
libfsm.lib

4 packages built:

bmake
bozohttpd
bozohttpd-minimal
hikari

libfsm is a pre-existing failure. Proposed the fix as https://github.com/NixOS/nixpkgs/pull/231029.
kgt is also a pre-existing failure. I'll have a look at it as well.

kgt is also a pre-existing failure. I'll have a look at it as well.

Ah, already known upstream: https://github.com/katef/kgt/issues/62. I'll leave it broken.


In the Reorder option, the image of the product appearing is not accurate.

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
Master
Issue Description
After creating an order and navigating to the Reorder section in the admin end, we notice that the images are not appearing correctly.
Preconditions

Admin must be logged in.
Atleast one order must be done from logged in user.

Steps to reproduce

Go to Admin -> Sales -> Orders -> View Order placed by a logged in user.
Click on Reorder -> In product image we can see the issue.

Expected Result
Images should be clear and accurate.
Please check the screenshot ->  https://prnt.sc/vxllW8dg-8X3
Actual Result
Please check  the screenshot for the issue -> https://prnt.sc/nPCy7LVW8vMs
Screenshots
No response
Additional context
No response

Checked and found that the issue has been fixed.
Screenshots
https://scrsht.com/3e647056
https://scrsht.com/9b783384

Checked and Found that the issue related to the images in the Reorder is fixed and also PR has been merged. Hence I am closing the issue from here.
Video
https://github.com/bagisto/bagisto/assets/92721837/3dfa73b7-6189-499c-983e-0b380b78fd7f


Custom vite resolver

Resolves https://github.com/observablehq/plot/pull/880#issuecomment-1136350582
This makes it so we can use "js" extensions for TypeScript imports by adding a custom resolver for Vite (which was the only piece that wasn't happy with the js extensions for files that don't exist. This custom loader won't be necessary once all of the files are TypeScript, since Vite implemented the typescript fallback for when importing from a typescript file..
With this change, I'm able to successfully run yarn test, yarn dev, as well as import Plot as an ESM into another project.

I was starting to look into having TS rewrite the imports, but that proved fruitless.

Yeah, the TypeScript folks have taken a position against doing this: https://github.com/microsoft/TypeScript/issues/16577 😅


A way to dynamically configure environment variables prior to launching a debug session

I want to be able to define a templated launch configuration that is able to dynamically set environment variables based on something like Task inputs. For example:
"launch": {
        "version": "0.2.0",
        "configurations": [
            {
                "name": "Web (client)",
                "type": "debugpy",
                "request": "launch",
                "program": "manage.py",
                "args": [
                    "runserver",
                    "8001",
                ],
                "django": true,
                "justMyCode": false,
                "env": {
                    "DJANGO_SETTINGS_MODULE": "${input:client}.settings",
                    "DATABASE_NAME": "${input:client}-database",
                },
            },
 "tasks": {
        "version": "2.0.0",
        "inputs": [
            {
                "id": "client",
                "type": "pickString",
                "description": "Which Client?",
                "options": ["ClientA", "ClientB", "ClientC"]
            },

        ],

In reality, I have about 20 different "clients" and a lot more environment variables, and want to avoid having to define 20 different launch configurations.
The suggestion here is one possible implementation. Another possible implementation would be to allow running a script prior to launching the debugger. Something like:
    "configurations": [
          { ...
               "preLaunchScript": "setup.sh ${input:client}"
          }
     ]

Which would source/export environment variables into the session that runs the debugger.

@jarshwah You don't define the input used in a launch config in the task.
You can use the extension Command Variable I wrote to reuse a selected option and also define other variables at the same pick.
Use extension.commandvariable.pickStringRemember and look at: An example task that stores multiple values:.
The example uses a task but it works the same for launch configs.

If you are just trying to pick a string, you can also do that with an input in launch.json, right? I suppose pickStringRemember does this but remembers the selection?

@roblourens Looking at the example he wants to use the same picked string multiple times, using pickStringRemember and the command extension.commandvariable.remember he only has to pick once and re-use the picked string multiple times, And you can pick in a launch config and use the same string in a linked task.

If that's the problem, it looks like we already handle this to only resolve an input once in a launch config.

@roblourens reading his question again he might want to run a shell script that defines environment variables and use them in the launch config. His example does not reflect fully what he wants.
Regarding the env variables set in the shell script will never get to the launch config environment.
He could store the wanted info in a file and use extension.commandvariable.file.content to read all the specific fields (key-value, JSON, YAML) and define the environment variables in the launch config.
The problem is that the launch config resolves all the variables BEFORE calling the preLaunchTask.
Better would be if there is a preLaunchTask:

the variables in the preLaunchTask property string are resolved,
the task named in the resulting string is executed.
the other variables mentioned in the launch config property strings are resolved.
the launch config is now variable free an can be executed.

Let me share a partially redacted version of my launch configs so it's a bit more concrete:
{
    "name": "Web (Tenant 1)",
    "type": "debugpy",
    "request": "launch",
    "cwd": "${workspaceFolder}/src",
    "program": "manage.py",

    "args": [
        "runserver",
        "8001",
        "--skip-checks"
    ],
    "django": true,
    "justMyCode": false,
    "env": {
        "DJANGO_SETTINGS_MODULE": "localdev.settings",
        "DJANGO_CONFIGURATION": "Tenant1Web",
        "DJANGO_WATCHMAN_TIMEOUT": "10",
        "DATABASE_NAME": "tenant1-writer",
        "DATABASE_READER_NAME": "tenant1-reader",
        "ELASTICSEARCH_ENABLED": "1"
    },
},
{
    "name": "API (Tenant 1)",
    "type": "debugpy",
    "request": "launch",
    "cwd": "${workspaceFolder}/src",
    "program": "manage.py",
    "args": [
        "runserver",
        "8002",
        "--skip-checks"
    ],
    "django": true,
    "justMyCode": false,
    "env": {
        "DJANGO_SETTINGS_MODULE": "localdev.settings",
        "DJANGO_CONFIGURATION": "Tenant1API",
        "DJANGO_WATCHMAN_TIMEOUT": "10",
        "DATABASE_NAME": "tenant1-writer",
        "DATABASE_READER_NAME": "tenant1-reader",
        "ELASTICSEARCH_ENABLED": "0"
    },
},
{
    "name": "Web (Tenant 2)",
    "type": "debugpy",
    "request": "launch",
    "cwd": "${workspaceFolder}/src",
    "program": "manage.py",
    "args": [
        "runserver",
        "8001",
        "--skip-checks"
    ],
    "django": true,
    "justMyCode": false,
    "env": {
        "DJANGO_SETTINGS_MODULE": "localdev.settings",
        "DJANGO_CONFIGURATION": "Tenant2Web",
        "DJANGO_WATCHMAN_TIMEOUT": "10",
        "DATABASE_NAME": "tenant2-writer",
        "DATABASE_READER_NAME": "tenant2-reader",
        "ELASTICSEARCH_ENABLED": "0"
    },
},
{
    "name": "API (Tenant 2)",
    "type": "debugpy",
    "request": "launch",
    "cwd": "${workspaceFolder}/src",
    "program": "manage.py",
    "args": [
        "runserver",
        "8002",
        "--skip-checks"
    ],
    "django": true,
    "justMyCode": false,
    "env": {
        "DJANGO_SETTINGS_MODULE": "localdev.settings",
        "DJANGO_CONFIGURATION": "Tenan2API",
        "DJANGO_WATCHMAN_TIMEOUT": "10",
        "DATABASE_NAME": "tenant2-writer",
        "DATABASE_READER_NAME": "tenant2-reader",
        "ELASTICSEARCH_ENABLED": "0"
    },
},

Different tenants have different environment variable values. Ideally, I'd like to be able to "template" the environment variables. We have shell scripts that export environment variables into the environment when running the program outside of vscode - think use-tenant web 1.
What I'd like to be able to do is "launch web" -> "select tenant 1" -> it runs with the environment required for that tenant.
Thanks @rioj7 for interpreting what I meant despite the lacking example, you're correct. I want to be able to either:

Resolve variables (pickString?) that can be interpolated into the environment section; or
Resolve a variable that is passed to some script that can export environment variables that are made available to the program being launched

@jarshwah I have a working proof of concept.
Due to how launch configs now work you have to split the setting of the variable content and the actual launch/debug.
The env section of a launch config can contain ${input} variables.
Setting of the variable content is done with a task:
{
  "version": "2.0.0",
  "tasks": [
    {
      "label": "Choose Django Environment",
      "type": "shell",
      "command": "echo",
      "args": [
        "Django Environment: ${input:chooseDjangoEnv}"
      ],
      "problemMatcher": []
    }
  ],
  "inputs": [
    {
      "id": "chooseDjangoEnv",
      "type": "command",
      "command": "extension.commandvariable.pickStringRemember",
      "args": {
        "key": "choice",
        "options": [
          {"label": "Web (Tenant 1)", "value": {"choice":"Web (Tenant 1)", "djangoConfig":"Tenant1Web", "databaseName":"tenant1-writer"}},
          {"label": "Web (Tenant 2)", "value": {"choice":"Web (Tenant 2)", "djangoConfig":"Tenant2Web", "databaseName":"tenant2-writer"}}
         ],
        "description": "Pick a configuration"
      }
    }
  ]
}

You can bind a key to execute the task:
  {
    "key": "ctrl+alt+f5",
    "command": "workbench.action.tasks.runTask",
    "args": "Choose Django Environment"
    "when": "editorTextFocus"
  }

Define the following launch config:
{
  "version": "0.2.0",
  "configurations": [
    {
      "name": "Python: Current File with Django environment",
      "type": "python",
      "request": "launch",
      "program": "${file}",
      "console": "integratedTerminal",
      "env": {
        "DJANGO_CONFIGURATION": "${input:djangoConfig}",
        "DATABASE_NAME": "${input:databaseName}",
      }
    }
  ],
  "inputs": [
    {
      "id": "djangoConfig",
      "type": "command",
      "command": "extension.commandvariable.remember",
      "args": { "key": "djangoConfig" }
    },
    {
      "id": "databaseName",
      "type": "command",
      "command": "extension.commandvariable.remember",
      "args": { "key": "databaseName" }
    }
  ]
}

I have tested it with the following Python file:
import os

print('DJANGO_CONFIGURATION:', os.environ['DJANGO_CONFIGURATION'])
print('DATABASE_NAME:', os.environ['DATABASE_NAME'])

To have to modify the concept for your specific variables and launch config.


Logic to steal 10b from the casino does not check that player has BN4

When starting autoPilot.js after installing augments before getting access to BN4.
It continously throws error that ns.stopAction() is not available without BN4 while trying to run /Temp/stop-action.txt.js
change to prevent this could example be to check for BN4 at start.
example:
change from:
async function maybeDoCasino(ns, player) {
if (ranCasino) return;
const casinoRanFileSet = ns.read(casinoFlagFile);
to:
async function maybeDoCasino(ns, player) {
if (ranCasino) return;
if (!(4 in unlockedSFs)) return;
const casinoRanFileSet = ns.read(casinoFlagFile);
https://github.com/alainbryden/bitburner-scripts/blob/67a1584ceff06b5f0a7babd42b1f83a4bf7c16a5/autopilot.js#L403-L405

You don't actually need SF4 to do casino, that "StopAction" doesn't even really need to be in there, it's just a safety precaution.


[Doc] add button to copy code to clipboard

Feature Request
It would be nice to be able to click a button to copy the code

@danieljurek, this is an interesting request.  My guess is we'd have to relay it to the docs team though since I don't think this is a feature we can add or would own.
(also, ignore all those linked PRs.  That's an overzealous automation script from the CLI team making that noise)

@benbp @danieljurek Can you elaborate on this issue?  What are we attempting to copy and where would it go?  Should this issue be closed?


Do not propose to auto import fully qualified method paths

This PR solves an issue when an auto import was proposed for the paths like ast::SourceFile::cast (as in https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ra_assists/src/handlers/auto_import.rs#L46)

This PR solves an issue when an auto import was proposed for the paths like ast::SourceFile::cast (as in https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ra_assists/src/handlers/auto_import.rs#L46)
Unfortunately, we still propose auto imports for the paths that end with the method that does not exist: ast::SourceFile::nonexistent_nonsence
Maybe there is a better approach that covers this case also?

Now this PR in a bit of a weird state: after the last commit here, I don't really need the first two ones.
Yet, I've left them more for the sake of a discussion: is it the right way to try to detect methods as I do that in the first two commits?
I want to use that for the "auto import trait for the method" functionality later, so those are still valuable IMO.
Also note that the resolution does not work properly for cases like
use foo::bar::baz

fn call_baz_method() {
  baz_method<|>(5) // this gets wrongly resolved to a struct
}

I guess the first two tests should be  changed from whatever::Trait::consume to just consume?
Also, this might be a case where a mark might be useful, to makes sure we don't propose auto-import for the right reason

I think this PR needs a split into two, because it tries to solve 2 different issues and does not do it fully:

do not propose auto imports for methods and fully qualified methods: currently the PR does not provide a fix for the former
do not propose auto imports for fully qualified paths when the first segment is already in scope: currently the PR fixes that, but importing the first segment glitches sometimes

I'll close this PR and come up with 2 separate later, one for every issue.
But good that the https://github.com/rust-analyzer/rust-analyzer/pull/3061/files#diff-af32458a9c9edad8a17c19b48e2145e7R317 approach did not cause questions per se, I'll use it when fixing the first issue


HolographicDisplays integration

Current use cases include:

Show the Player's next checkpoint: https://github.com/filoghost/HolographicDisplays/wiki/Individual-holograms
An official version of this workaround, using a entry in the strings.yml for what text to display:

This has been implemented in the pending 7.0.0 release.
To avoid another dependency, a workaround has been achieved.
There is a new Checkpoint placeholder which will be populated when the next checkpoint matches the placeholder value.
A tutorial on this will be found in the docs when deployed.


Fix parsing of previous tag for release notes

Change-type: patch
Signed-off-by: Kyle Harding<EMAIL_ADDRESS>See: https://github.com/product-os/flowzone/pull/431

I self-certify!


Create a main script

Create a memome.py script which will serve as the main executable. It should contain modules for the following tasks:

[x] downloading necessary databases
[ ] preprocessing the input models
[ ] matching metabolites
[ ] renaming the of the models to facilitate merging
[ ] identifying futile cycles

The first two points are already kind of handled in the main.py

The second is not yet, is it? I was thinking about the checks for duplicate metabolites...

True, just the bulk annotation is kind of done

Has there been any discussion on this. I added some more stuff to the main script but the points mentioned above are currently not implemented and thus really cant be added at this point


After upgrading to 5.3.0-latest.20211125.2, node CPU and disk monitoring are not displayed

升级到5.3.0后node节点cpu和disk监控不显示

Are you able to translate your issue into English? What metrics operator setting is set?

After upgrading to 5.3.0, node  CPU and disk monitoring are not displayed

I have the same issue.
To more details, when we go on a specific node we are able to get all the metrics:

The cluster overview is also broken:

Lens version:

Is this possibly related to label changes such as https://github.com/prometheus-community/helm-charts/pull/1520 ?

Yes it could be...

We have the same issue

Seems to be a duplicate of #4435

Yes @bravecobra, good catch. Will close this in favour of that.


Is it possible to click outside the popover and hear to mouse events?

While the popover is showing, I would like to be able to click on buttons on the page that are around it (behind the barrier but not behind the popover itself.
Is this possible please?
Thank you

@arualana Thank you for your request!
We probably can implement such behavior. However, I'd appreciate it if you can provide more concrete examples of why do we need to add this, please 🙏

Closing the issues due


Wrong hash for leaflet.css

Hello,
I encoutered a bug with the following file: https://sparte.beta.gouv.fr/static/carto/css/leaflet.css
Provided hash with static_sri : y4gDEU/pxJrmohmEZFiWzZiKDba4qNsDmUTkUJjIN5U=
Expected hash : BPfK9M5v34c2XP6p0cxVz1mUQLst0gTLk0mlc7kuodA= (computed by chrome)
I am unsure on how this is possible, I am looking into it but with no result yet.
Swann

I might have a lead. It seems that reading a file then convert it in byte is not the same as reading it in byte mode from scratch.
with open(path, "rb") as f:
        content = f.read()

is not the same as :
with open(path, "r") as f:
        content = f.read()
content.decode()

I don't know why...
I will make a pull request.

Current version (0.3.0) has the bug, but it is fixed on master. When do you think you will be able to publish 0.4 on pypi ?

How strange, I suspect it has something to do with default file encodings? Either way, the latter example is always unnecessary if the file can be read as bytes anyway (it's much faster that way).
I've released 0.4.0 now, which does better deal with opening files correctly, but also in chunks which should improve performance.
Try giving that package a go and let me know if it's working.


docs: Improves Go builder example in quickstart

This commit improves the Go builder example in the quickstart based on the discussion at https://discord.com/channels/707636530424053791/1223010377097547857
It also fixes the shell output snippets, which in some cases were being automatically colorized by the syntax highlighter, even though the actual output seen by the user would not be colorized.

@kpenfound when using the command below with golang 0.1.10 as shown in the "daggerize a project" page
dagger -m golang call \
  build-container --source=. --args="-C","./hello" \
  publish --address=ttl.sh/my-hello-container-$RANDOM

I see this error
Stdout:
json: error calling MarshalJSON for type *dagger.Container: input: container.from.withMountedCache.withMountedCache.withDirectory.withWorkdir.withEnvVariable.withEnvVariable.withExec.directory resolve: process "go build -o /out/ -C ./hello -o /src/build-output/" did not complete successfully: exit code: 2

Stderr:
invalid value "./hello" for flag -C: -C flag must be first flag on command line
usage: go build [-o output] [build flags] [packages]
Run 'go help build' for details.

Ping @helderco for approval


Cut v1.2.1

@juliusv as you are apparently online.

:+1:

:+1:

Now we only need somebody to tell me how to convince Promu to use Go1.7.1.
Will https://github.com/prometheus/promu/pull/48 be sufficient?

Added it here to the .promu.yml.


Add simple MLflowCallback example

Motivation

Previously there was no minimal example of  MLflowCallback. Additionally, existing keras example did not use MLflowCallback, as discovered in https://github.com/optuna/optuna-examples/issues/41#issuecomment-920145258. This PR fixes both those issues. Resolves #56.
Description of the changes

Add minimal MLflowCallback example
Use MLflowCallback in keras example
Update CI and README

Like always, thank you for your sold contributions!
I think the two examples code are almost the same except for the objective function. I suppose that rename keras_mlflow.py with mlflow_simple.py with the proposed modification in this PR is enough for simplicity.  Sorry, I should have discussed more when I had created the issue. However, I'm not sure about the backward compatibility-ish policy in this repo. So I would like to the senior member's comment.
cc: @HideakiImamura @hvy @toshihikoyanase

Sorry, my mistake. I can close this PR and open new one with smaller scope if it's ok with you.


Executing workflows in batch mode is broken

Executing workflows from the comand-line with -b generates an error after the workflow has executed.
Bisected to 10ea3ca0648e12df82444431f9f393d5ee57e659.

It looks like the spreadsheet is the only thing keeping the VistrailsApplication alive in batch mode. The global VistrailsApplication in core/application is a weakref! I am not sure how this is supposed to work.

@rexissimus, what is the actual error? Could you add the stack trace?

Exception AttributeError: "'NoneType' object has no attribute 'startup'" in <bound method VistrailsApplicationSingleton.__del__ of <vistrails.gui.application.VistrailsApplicationSingleton object at 0x7f60c9a66b98>> ignored
Uncaught exception on initialization: TypeError: 'NoneType' object is not callable
Traceback (most recent call last):
  File "vistrails/run.py", line 140, in main
    app = vistrails.gui.application.get_vistrails_application()()
TypeError: 'NoneType' object is not callable


URL Cleanup

This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).
Fixed URLs
Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

http://maven.apache.org/xsd/maven-4.0.0.xsd with 1 occurrences migrated to:
https://maven.apache.org/xsd/maven-4.0.0.xsd (https result 200).

Ignored
These URLs were intentionally ignored.

http://maven.apache.org/POM/4.0.0 with 2 occurrences
http://www.w3.org/2001/XMLSchema-instance with 1 occurrences

Reviewed/merged.


Use single underscore for non-public methods and instance variables

According to PEP8 (https://www.python.org/dev/peps/pep-0008/#method-names-and-instance-variables):

Use one leading underscore only for non-public methods and instance variables.

To avoid name clashes with subclasses, use two leading underscores to invoke Python's name mangling rules.

The project currently uses the double underscore __ prefix to denote private instance variables and methods. I would propose altering that to use a single _ underscore.
The purpose is twofold.

It is the standard convention and conforms to the standard python style. There isn't any sub-classing so there isn't a real need for the name mangling.
If we wanted to unit test these methods, it is much cleaner to use _pyproject than _TaskRunner__pyproject inside of those unit tests.

I recognize that I likely may have started or at the least influenced the double underscore convention here via #15 :smile:

+1; I'm generally not a fan of double underscores and in general think that even single underscore should be used sparingly.

Hi! Thanks for the suggestion!
IMO double underscore is preferable, because it has actual practical use over single underscore. Double underscore gives you encapsulation - and in an OOI world this is always a good idea, regardless of whether or not you intend for your class to be subclassed. I know that Guido is more in favor of the "open kimono" approach (what an outdated and inappropriate term!) - but in this case (single vs double underscore) I think that safety beats comfort so there's a solid case for breaking the convention here.
As for unit tests, they are not a concern imo. I am a huge TDD advocate, so IMO all tests should be black box and we should never test private methods. If you agree with me about that, then name mangling is not a problem - to the contrary, we would much rather not know anything about private methods and fields during tests.
Finally, I agree with your that a single underscore is the standard. But double underscore is not that obscure as to confuse other python devs regarding what you mean. It has leading underscore\s? It's a private method, no doubt about it. And anyways, as per PEP8:

In the event of any conflicts, such project-specific guides take precedence for that project.

And in that case, as long as we consistently use double underscore across the codebase, we're good to go :)

@illBeRoy I'm not bullish on it, just bringing it up as a possible suggestion. I appreciate you taking the time to give your thoughts!
I don't think I would agree that using double underscores gives you any more encapsulation than using a single underscore. I agree encapsulation is important, no disagreement there, just that using the double underscores isn't any different.

It doesn't prevent access for anyone who wants to use internals.
It mangles the name in a very predictable _classname__attr form.
It's designed to help prevent issues with subclassing.

Really, it just makes it more verbose to access those internals for someone who wants to.
>>> class A:
...   def __init__(self):
...     self.__test = 'a'
...     self._test = 'a'
...
>>> dir(A())
['_A__test', '__class__', '__delattr__', '__dict__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getattribute__', '__gt__', '__hash__', '__init__', '__init_subclass__', '__le__', '__lt__', '__module__', '__ne__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', '_test']

Note the _A__test and _test are both shown and available.
Python doesn't really have firm encapsulation in that kind of way. You convey which attributes or methods are internal and trust that your client knows what they're doing if they use them because those are internals that can change at anytime.
If you accept the premise that using double underscores isn't any different encapsulation-wise, it felt like it made sense to just keep things simpler and follow the standard convention.
Feel free to close if you feel strongly otherwise :slightly_smiling_face:

My intention was not to stop people from tampering with our classes on purposes - if they want to mess with the internals then by all means go ahead (and since taskipy is OSS they can literally tamper with the entire codebase)
Instead, I want to make sure (as much as possible) that people will not break things by mistake. I want to keep them safe.
And I know that PEP says that you should use it if you design your class for inheritance, by IMO every class should be inheritable, as inheritance is a 100% legit way to extend pieces of software.
Since the mental overload of just using two _ instead of one is worth the benefit IMO, I really do feel that we should aim to use double underscore as much as possible - as long as we keep this standard consistent across our codebase.
I hope that I managed to get my point across. Even if you don't agree with me on this one, I really don't want to reject things "just because I said so", and always aim to provide reasonable explanations :)
BTW,
Even languages that offer "true" encapsulation usually give you the option to bypass their own rules, whether its by Java Reflections or CPP pointer magic, etc.

No worries, I appreciate you giving your thoughts 🙂 it’s a minor thing, just figured I’d bring it up as a consideration. I’ll close this one out


Removing BetaApi from ClientSettings

This should have been removed in the last pass of removing @BetaApi
tags, but it was somehow overlooked.

Codecov Report

Merging #423 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #423   +/-   ##
=========================================
  Coverage     70.58%   70.58%
  Complexity      628      628
=========================================
  Files           134      134
  Lines          2886     2886
  Branches        218      218
=========================================
  Hits           2037     2037
  Misses          770      770
  Partials         79       79

Impacted Files
Coverage Δ
Complexity Δ

...in/java/com/google/api/gax/rpc/ClientSettings.java
93.67% <ø> (ø)
8 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32572cd...a713aa0. Read the comment docs.


Operator overloading

#36
Implements some methods, which previously was relying on Ord.

I think it's looking like a good direction, thanks for taking the time!

because we can't raise individual errors using slice's sort method and in case of many errors in the loop, it's unclear which one of them should be returned

I had an idea of using .sort_by and then caching the first error and effectively terminating the sort by returning Ordering::Less for all remaining comparisons (or something like that), then propagating the error. A custom sort seems like a reasonable approach though.

I had an idea of using .sort_by and then caching the first error and effectively terminating the sort by returning Ordering::Less for all remaining comparisons (or something like that), then propagating the error. A custom sort seems like a reasonable approach though.

I discovered this approach later. It looks like it's applicable to map sorting, while I've gotten stuck with my approach there.

Great to see you've made progress here @ales-tsurko! I'll have time to dig into this properly tomorrow.

@ales-tsurko How do you want to proceed here? Would you like me to give review style feedback and you carry on with the implementation? Or shall I merge your commits as they are and continue the branch myself? I'm happy either way, and open to other options too.

I'm ok with you giving the review and me making changes. And I'm ok with you continuing it as well 😀

Let's go with the review, so you could spend your time on other things.

I'll get back to this after the weekend.

Hey @ales-tsurko, just to say I haven't forgotten about this and I'll get to it as soon as I can, hopefully before the weekend.

@ales-tsurko Thanks for pushing this forward, nicely done!


window object somehow gets nullified after throwing Error (?)

Basic info:

Node.js version: v8.9.1
jsdom version: v11.2.0 via Jest v21.3.0-beta.8, but reproducible on jsdom v9.x via Jest v21.2.x too

Minimal reproduction case
Run JEST test on this repository: https://github.com/wojtekmaj/react-pdf/tree/feature/unit-testing
During my testing, I got a TypeError after my package has failed to load a file during a test scenario.
    at Object.invokeGuardedCallbackDev (C:\react-pdf\node_modules\react-dom\cjs\react-dom.development.js:577:26)
    at invokeGuardedCallback (C:\react-pdf\node_modules\react-dom\cjs\react-dom.development.js:436:27)
    at renderRoot (C:\react-pdf\node_modules\react-dom\cjs\react-dom.development.js:10386:7)
    at performWorkOnRoot (C:\react-pdf\node_modules\react-dom\cjs\react-dom.development.js:11000:24)
    at performWork (C:\react-pdf\node_modules\react-dom\cjs\react-dom.development.js:10952:7)
    at requestWork (C:\react-pdf\node_modules\react-dom\cjs\react-dom.development.js:10861:7)
    at scheduleWorkImpl (C:\react-pdf\node_modules\react-dom\cjs\react-dom.development.js:10744:11)
    at scheduleWork (C:\react-pdf\node_modules\react-dom\cjs\react-dom.development.js:10706:12)
    at Object.enqueueSetState (C:\react-pdf\node_modules\react-dom\cjs\react-dom.development.js:6204:7)
    at Document.Object.<anonymous>.Component.setState (C:\react-pdf\node_modules\react\cjs\react.development.js:226:16)
    at Document._this.onLoadError (C:\react-pdf\src\Document.jsx:152:13)
    at <anonymous>

i went to react-dom.development.js:577:26 to investigate. I found that the line failing was:
var evt = document.createEvent('Event');

so I put some console.logs right before the failing line to find out what happens:
if (typeof document !== 'object') {
  console.log('Something very bad happened');
  console.log(window);
  console.log(document);
} else {
  console.log('Everything fine');
  console.log(typeof window);
  console.log(typeof document);
}

and the output in console was suggesting that for the first few runs, everything was working, until an error came:
console.log node_modules\react-dom\cjs\react-dom.development.js:582
  Everything fine
console.log node_modules\react-dom\cjs\react-dom.development.js:583
  object
console.log node_modules\react-dom\cjs\react-dom.development.js:584
  object
console.log node_modules\react-dom\cjs\react-dom.development.js:582
  Everything fine
console.log node_modules\react-dom\cjs\react-dom.development.js:583
  object
console.log node_modules\react-dom\cjs\react-dom.development.js:584
  object
console.error src\shared\util.js:96
  undefined Error {
    name: 'UnknownErrorException',
    message: undefined,
    details: 'UnknownErrorException' }
console.log node_modules\react-dom\cjs\react-dom.development.js:578
  Something very bad happened

interestingly, console.log that was supposed to be displayed right after "Something very bad happened", has thrown an error:
Cannot read property '_location' of null TypeError: Cannot read property '_location' of null
    at Window.get location [as location] (C:\react-pdf\node_modules\jsdom\lib\jsdom\browser\Window.js:165:79)
    at Function.getOwnPropertyDescriptor (<anonymous>)
    at formatProperty (util.js:828:23)
    at formatObject (util.js:649:17)
    at formatValue (util.js:609:18)
    at inspect (util.js:324:10)
    at format (util.js:191:12)
    at CustomConsole.log (C:\react-pdf\node_modules\jest-util\build\Console.js:38:53)
    at Object.invokeGuardedCallbackDev (C:\react-pdf\node_modules\react-dom\cjs\react-dom.development.js:579:17)
    at invokeGuardedCallback (C:\react-pdf\node_modules\react-dom\cjs\react-dom.development.js:436:27)

which suggests that window inside Window function suddenly got... nullified.
I can't figure out what could be going wrong here. Could you give me any hints on what could be happening? TIA!
How does similar code behave in browsers?
n/a

Sorry, but this didn't follow the issue template by giving a minimal reproduction case that doesn't use third-party libraries like Jest. We've seen similar problems before, all caused by Jest, and as such we cannot consider this a jsdom bug until someone provides a minimal reproduction case. So, closing.


Update ping_pong.py

The previous code had some errors, such as the "os" module not being imported and incorrect variable names, which could lead to program crashes in the middle.
Type of change

I added "import os" because the os module was used in the project but not imported.
I created variables like "ball_dx" and "ball_dy" that were not declared before but were used in the program, leading to an error.
I commented out code that was attempting to play an audio file that was not located in the project directory.
Added new comments to make code more readable.
Fix the position of the right paddle.
Fixed some logic for the ball movements.

Thanks @adixoo for correcting the codebase 👍


Setup release v0.0.22 [phab:D976]

Created by schroederc at 2016-07-20 18:05:24:

schroederc wrote at 2016-07-20 18:06:34:
https://github.com/google/kythe/releases/tag/untagged-9afcd03dd1bcf137137a

schroederc wrote at 2016-07-20 18:13:08:
There's something weird going on with the web UI.  I need to check it out before this release.

schroederc wrote at 2016-07-20 19:23:13:
Rebase w/ fix to sample web ui

schroederc wrote at 2016-07-20 19:24:19:
PTAL

fromberger accepted this revision at 2016-07-20 19:31:25

schroederc closed via commit 06eacfc7b7b2c2e6509fd50bfea3a08e640d8c5c at 2016-07-20 19:33:07


WIP: Travis CI: Switch to Ubuntu 20.04 LTS

The Ubuntu 20.04 ships the podman in official repo, change from docker
to podman.

Nope. Ubuntu 20.04 still don't have podman. Closing as travis CI document does not contain this 20.04 yet.


MAPL changes to support CICE6 rewind for replay

Hi,
Some code needs to be implemented to support rewinding CICE6 states when coupled model runs in replay mode.
Specifically, the following patch is required in subroutine MAPL_GenericRefresh.
       character(len=ESMF_MAXSTR)                  :: CHILD_NAME
       character(len=14)                           :: datestamp ! YYYYMMDD_HHMMz
       integer                                     :: status
+      integer                                     :: UserRC
       integer                                     :: I
       type (MAPL_MetaComp), pointer               :: STATE
       character(len=1)                            :: separator
@@ -2920,6 +2921,12 @@ contains
          ! call the actual record method
          call MAPL_StateRefresh (GC, IMPORT, EXPORT, CLOCK, RC=status )
          _VERIFY(status)
+
+         if (associated(STATE%phase_coldstart)) then
+            call ESMF_GridCompReadRestart(GC, importState=import, &
+                    exportState=export, clock=CLOCK, phase=MAPL_MAX_PHASES+1, userRC=userRC,
_RC)
+         endif
+
       endif
       call MAPL_TimerOff(STATE,"GenRefreshMine",_RC)
       call MAPL_TimerOff(STATE,"GenRefreshTot",_RC)

The above code was tested in V11.4.0 and shown to be working.
Could SI group add the implementation in the next MAPL version? This is required by @Dooruk for his coupled DA work with CICE6.
Thanks

@zhaobin74 We can certainly do this, but it also fine if you want to do a PR yourself (onto the develop branch).

I thought @atrayano added this to his plate before he departed for Bulgaria.  I think we wanted to do a slight variation ...
I'll email him separately to get a status update.  (Not sure if he links his personal email to GitHub.)

Thanks @tclune!

Yes, @atrayano said in https://github.com/GEOS-ESM/MAPL/pull/2982#issuecomment-2307907700 that:

@zhaobin74 I have several concerns regarding this PR. The most trivial one is that instead of hardcoding MAPL_MAX_PHASES+1, we could introduce a local variable "phase", which we should get by calling ESMG_GridCompGet(gc, currentPhase=phase, _RC). A far more serious concern is the fact that we are using cold_start method which was supposed to be only as a fallback strategy during Initialize. Luckily for us, thus method is not used anywhere in GEOS (with a possible exception of the dycore), but if another component legitimately tries to use it, this PR has the potential to break that imaginary component. Let's touch base on Monday to brainstorm and find a better solution.
For the time being, I will add "do not approve" label.

My guess is things got busy quickly as they do for Atanas. :)

@atrayano has a fix and will pass it along for testing in ~ 1 day.

I have got the fix from @atrayano . Will test it out using my setup for the PR.

During a meeting yesterday @zhaobin74 mentioned @atrayano's rewind fix didn't work. I wanted to write it here again just in case his update in the comment didn't generate any notifications 👀

I am forwarding this to Atanas’ gmeail account in the hopes he might have time to address this yet this week.
From: Doruk Ardağ @.>
Date: Wednesday, October 30, 2024 at 10:50 AM
To: GEOS-ESM/MAPL @.>
Cc: Clune, Thomas L. (GSFC-6101) @.>, Mention @.>
Subject: [EXTERNAL] [BULK] Re: [GEOS-ESM/MAPL] MAPL changes to support CICE6 rewind for replay (Issue #2959)
CAUTION: This email originated from outside of NASA.  Please take care when clicking links or opening attachments.  Use the "Report Message" button to report suspicious messages to the NASA SOC.
During a meeting yesterday @zhaobin74https://github.com/zhaobin74 mentioned @atrayanohttps://github.com/atrayano's rewind fix didn't work. I wanted to write it here again just in case his update in the comment didn't generate any notifications 👀
—
Reply to this email directly, view it on GitHubhttps://github.com/GEOS-ESM/MAPL/issues/2959#issuecomment-2447406084, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPP7YEG76TCOTFGLCLDWG3Z6DWZZAVCNFSM6AAAAABMMWMODWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBXGQYDMMBYGQ.
You are receiving this because you were mentioned.Message ID: @.***>

@zhaobin74 I had to make 1 change iCICE6::Restoren CICE_90: the registration method now requires slightly different syntax:
instead of call MAPL_GridCompSetEntryPoint ( GC, ESMF_METHOD_READRESTART,  Refresh,    _RC)
we need to call
call MAPL_GridCompSetEntryPoint ( GC, MAPL_METHOD_REFRESH, Refresh,  _RC)
I
I re-tested my "rewind fix", and it seems to be working. Note that no changes are required on my MAPL branch.
Could you please, verify it.
And by the way, while debugging, I noticed another (totally unrelated) bug: inside the Refresh subroutine the string variable "Iam" grows (i.e. it went from CICE6::Restore to CICE6::CICE6::Restore to CICE6::CICE6::CICE6::Restore, etc). Eventually this will lead to buffer overflow

@zhaobin74 I had to make 1 change iCICE6::Restoren CICE_90: the registration method now requires slightly different syntax:
instead of call MAPL_GridCompSetEntryPoint ( GC, ESMF_METHOD_READRESTART, Refresh, _RC) we need to call call MAPL_GridCompSetEntryPoint ( GC, MAPL_METHOD_REFRESH, Refresh, _RC)
I I re-tested my "rewind fix", and it seems to be working. Note that no changes are required on my MAPL branch.
Could you please, verify it.
And by the way, while debugging, I noticed another (totally unrelated) bug: inside the Refresh subroutine the string variable "Iam" grows (i.e. it went from CICE6::Restore to CICE6::CICE6::Restore to CICE6::CICE6::CICE6::Restore, etc). Eventually this will lead to buffer overflow

@atrayano, I can verify the MAPL fix works after changing to MAPL_METHOD_REFRESH.
I don't get why Iam keeps growing. It is a local string prefixed by comp_name. Anyhow, I removed the prefix so no overflows.
I'll make a PR in GEOSgcm_gridComp repo with these updates.
Thanks.

I have not looked at the specif module, but am guessing that (1) Iam is a module variable and thus has the SAVE attribute (implicitly) and (2) the procedure is doing something like Iam = Iam // ... and thus keeps appending.

I have not looked at the specif module, but am guessing that (1) Iam is a module variable and thus has the SAVE attribute (implicitly) and (2) the procedure is doing something like Iam = Iam // ... and thus keeps appending.

There is no such variable with name IAm at module level in CICE_plug. IAm is from
__Iam__('Restore') which is a macro defined in MAPL. It is equivalent to  integer :: STATUS; character (len=255) :: Iam = 'Restore'

OK - I had the details slightly wrong.  It is a local variable declared with the Iam macro.   But since the macro gives an initial value, the variable as the SAVE attribute.  (implicitly).  Then
https://github.com/GEOS-ESM/GEOSgcm_GridComp/blob/fd538d53a85fdedca503d8a0bc2dab08cb2cc760/GEOSogcm_GridComp/GEOSseaice_GridComp/CICE_GEOSPlug/CICE_GEOSPlug.F90#L1023
Causes it to grow each time the refresh() method is called.

OK - I had the details slightly wrong. It is a local variable declared with the Iam macro. But since the macro gives an initial value, the variable as the SAVE attribute. (implicitly). Then
https://github.com/GEOS-ESM/GEOSgcm_GridComp/blob/fd538d53a85fdedca503d8a0bc2dab08cb2cc760/GEOSogcm_GridComp/GEOSseaice_GridComp/CICE_GEOSPlug/CICE_GEOSPlug.F90#L1023
Causes it to grow each time the refresh() method is called.

Implicit SAVE when initialized? What a feature! Now I know how to fix it. Thanks, @tclune

Yes - this is an ancient rule inFortran.  It really throws off the C programmers, but also catches us Fortran old timers occasionally.


Figure out a testing (unit/integration) framework for testing the whole system including the hardware

https://docs.platformio.org/en/latest/advanced/unit-testing/index.html#unit-testing

Our problem is that we can't really run the code that interfaces with the hardware on our machines without the actual hardware.
For example how would we go about, testing the acceleration sensor works correctly.

I  would perform a resistance test to ensure all pins work on a given IC, perform a bench test on an apparatus where you can control the parameter in question (a drop test for the linear acceleration example, comparison test for most other sensors), and use a debugger probe to to test the code in situ.

Perhaps we can lay this test plan out tomorrow! And get onto laying out procedures on how to perform them and building apparatus to test our systems. I was looking at mainly software solutions like fuzz testing perhaps cause software is what I'm most familiar with.

Haven't looked into this a lot, but I'll try to get a proof of concept up and running by next week, we could using an additional micro-controller hijack the I2C lines and emulate the data received from the sensors, this would allow us to test a variety of scenarios really quickly and make fuzz testing fairly simple too.

Moved to the Delisle project!


ExpensifyApproved! user getting "Free trial expired" Popup on OldDot

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @zsgreenwald
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1715121255919949
Action Performed:

Login to OldDot as an Expenisfy Approved! user

Expected Result:
Partner user that doesn't get billed, and thus, shouldn't be receiving a "free trial expired" popup on their home page
Actual Result:
ExpensifyApproved! user has a Free Trial Expired pop-up on OldDot (on the Home page)
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@zsgreenwald is it just one accountant this is happening to? I can't replicate this for any of my accounting firms

Asked QA for help: https://expensify.slack.com/archives/C9YU7BX5M/p1715779044785969

@zsgreenwald is it just one accountant this is happening to? I can't replicate this for any of my accounting firms
Yep, this is the only account I've heard of where this is happening!

I'm afraid that I / the QA team haven't been able to reproduce. I have pinged Kavi in slack for one more try, afterwards I think we'll need to close unless its affecting more people.


Fix crash

Was crashing with error:
TypeError: unsupported operand type(s) for /: 'int' and 'NoneType'

On Windows 10

Thanks!  CC: @saching13


Keybinds are not working if there's no monitor available.

Hyprland Version
Hyprland, built from branch main at commit 68e57b7ee36f015d99988f38cb3a8b83c23ae7c3  (renderer: proper full occlusion checks for back layer). Tag: v0.32.3-79-g68e57b7e  flags: (if any)
Bug or Regression?
Bug
Description
I've set up a keybinding that runs a script that cycles between monitor configs. It works as long as at least 1 monitor is enabled, and if no monitors are available the keybind don't work and I'm stuck on black screen unless I kill Hyprland, go to tty, run the script manually and start Hyprland again.
How to reproduce

Disable all monitors
Press some keybind
The keybind doesn't work

Crash reports, logs, images, videos
No response

IIRC in unsafe state keybinds are purposefully disabled. What's the keybind?

What's the keybind?

bind = SUPERSHIFT, H, exec, ~/.config/hypr/scripts/switch-monitors-cfg

switch-monitors-cfg is bash script that uses sed to change monitors config path between:
source = ~/.config/hypr/configs/monitors/0.conf

and
source = ~/.config/hypr/configs/monitors/1.conf

IIRC in unsafe state keybinds are purposefully disabled

What is the reason? IG some dispatchers don't make sense to call when no monitor is available e.g. moving windows around, so maybe only allow some dispatchers selectively? I think exec should be ok to allow.

true

Cool. Are you planning to work on this anytime soon?

no clue. You can make a mr, that would help speed this up.

Just came across the same issue myself. I noticed none of my shortcuts work when no monitors are enabled. This poses a problem if I disconnect my external monitor, but then the shortcut for re-enabling the builtin monitor stops working.

keybindmanager.cpp:291 remove check for unsafe state and it should work I guess

I have this problem too and it is kind of an issue since I can't switch monitors to my laptop after unplugging the HDMI cable.


Highlight search term when output format is json

I see there's an option to highlight search term when output format is html. Is there a way to do it with json?

not right now.
On 08/26/2015 01:49 AM, Yan Takushevich wrote:

I see there's an option to highlight search term when output format is
html. Is there a way to do it with json?
—
Reply to this email directly or view it on GitHub
https://github.com/gigablast/open-source-search-engine/issues/50.

--
WARNING: CONFIDENTIALITY NOTICE: This E-mail and the materials attached are the private confidential property of the sender, and the message and attachments are privileged communications intended solely for the receipt, use, benefit, and information of the intended recipient indicated above. If you are not the intended recipient, you are hereby notified that any review, disclosure, copying, distribution, or the taking of any other action in reliance on the contents of this transmission is strictly prohibited, and may result in legal liability on your part. If you have received this transmission in error, please notify the sender immediately by replying to the sender, then fully delete the transmission from your computer and destroy any copies hereof. Your cooperation is appreciated.


[dkr] Install newer version of botocore in tools image

Motivation
It seems we need to update the botocore version >= 1.12.200 since aws-cli has a bug discussed in https://github.com/aws/aws-cli/issues/4371#issuecomment-518792844
update botocore to 1.17+ https://packages.debian.org/bullseye/python3-botocore
Have you read the Contributing Guidelines on pull requests?
Test Plan
build a container locally to verify the version of botocore.
root@75ffebdd7998:/# aws --version
aws-cli/1.18.111 Python/3.7.3 Linux/4.19.76-linuxkit botocore/1.17.22

@bors-libra land


gitflow

Action items from the 08-11-2022 meeting:

[x] Create a develop branch: terraform#898
[x] Set default branch to develop: terraform#898
[x] Decide on release naming (https://semver.org/): #515
[x] Add version API endpoint, or add it to the health endpoint: #515
[x] Write release process procedure doc: #511
[x] Publish to docker: #533
[ ] Publish to helm
[ ] Publish to maven
[x] Jenkinsfile change to sync kube and helm with AP feature and release branches: pipelines#422
[ ] Jenkinsfile change for release -> main CI
[ ] Talk to ops about solving the issue around a parallel branch structure in kube and helm repos
[ ] Add version to AP config file #497

Maybe it’s tied to the major version?

@erika-sdf  to create a separate issue for Helm chart publish


CannotPullContainerError: error pulling image configuration: toomanyrequests

Is your feature request related to a problem? Please describe.
When using the custom image feature to pull from dockerhub, how do we specify a username/access token so we do not get rate limited? Here's the error message:
[BUILD_CONTAINER_UNABLE_TO_PULL_IMAGE: Unable to pull customer's container image. CannotPullContainerError: error pulling image configuration: toomanyrequests: Too Many Requests. Please see https://docs.docker.com/docker-hub/download-rate-limit/]

Yes, retrying the build works, but hopefully we can find a better solution.

Hi @lorengordon just to confirm, have you setup the "Custom Build Image Requirements" from this doc?
https://docs.aws.amazon.com/amplify/latest/userguide/custom-build-image.html

@Athena96 Yes, I was actually testing using a python3.8-nodejs10 image from dockerhub. The build image is working just fine. It just will occasionally hit that rate limit on the dockerhub API.

I am also seeing this more frequently when using the default node base image: node:12.18.2

@hsspain Would be good to understand whether Docker's changes to rate limits is going to impact Amplify builds?

+1

I'm periodically getting the same error.

Hi, this is a known issue with custom images - please track the fix in #1009, closing this one


collections test in e2e test pack is flaking, failing frequently

Describe the bug
in collection_test.dart: "Model operations - save() with reshare() as true test" is failing frequently, requiring re-runs of the e2e test pack
Steps to reproduce
See https://github.com/atsign-foundation/at_client_sdk/actions/runs/5584776526/jobs/10207089878 for example
❌ test/collection_test.dart: Model operations - save() with reshare() as true test (failed)
  INFO|2023-07-18 08:15:54.007871|AtLookup|Creating new connection

  INFO|2023-07-18 08:15:54.191342|AtLookup|New connection created OK

  INFO|2023-07-18 08:15:54.395353|AtLookup|auth success

  INFO|2023-07-18 08:15:54.494525|SyncService (@ce2e2)|192496788|Returning serverCommitId 312115

  INFO|2023-07-18 08:15:54.50[158](https://github.com/atsign-foundation/at_client_sdk/actions/runs/5584776526/jobs/10207089878#step:8:160)0|SyncService (@ce2e2)|192496788|Inside syncComplete. syncRequest.requestSource : SyncRequestSource.app; syncRequest.onDone : null

  Expected: <0>
    Actual: <1>
  On the recipient side expecting a single keys with the regex supplied

  package:matcher                  expect
  test/collection_test.dart 305:5  main.<fn>

Expected behavior
test should pass
Screenshots
No response
Smartphones
No response
Were you using an atApplication when the bug was found?
No response
Additional context
No response

Failed again in this test run https://github.com/atsign-foundation/at_client_sdk/actions/runs/5584776526/jobs/10207763726

I was able to replicate the test failure locally after multiple tries. Client logs show a sync failure. Looking at server logs for more clues
SEVERE|2023-07-18 14:02:55.085840|AtLookup|Exception in sending to server, Exception: Waited for 10000 millis. No response after 2023-07-18 14:02:42.369355
SEVERE|2023-07-18 14:02:55.086943|AtLookup|Error in remote verb execution Exception: Waited for 10000 millis. No response after 2023-07-18 14:02:42.369355
SEVERE|2023-07-18 14:02:55.088203|SyncUtil|Exception while getting latest server commit id: Exception: Exception: Waited for 10000 millis. No response after 2023-07-18 14:02:42.369355
SEVERE|2023-07-18 14:02:55.089987|SyncService (@ce2e2)|Exception in sync 326e7b31-3256-4782-9dc8-631dbe4bba5d. Reason: Failed to syncData caused by
Unable to fetch latest server commit id: Exception: Exception: Waited for 10000 millis. No response after 2023-07-18 14:02:42.369355
INFO|2023-07-18 14:02:55.090454|E2ESyncService|Completed sync for @ce2e2| SyncStatus.failure | localCommitId: null | ServerCommitId: null | Processing time: 12730 millis

This is failing very frequently (read: requires a re-run pretty much every time) and having to manually trigger re-runs (sometimes more than once) is wasting a lot of time.

another failed run here

@gkc: Looking into this issue.

Problem is still occurring. See https://github.com/atsign-foundation/at_client_sdk/actions/runs/5736590366/job/15546506053 as an example. (There were also a few more examples yesterday)

Problem is still occurring. See examples

https://github.com/atsign-foundation/at_client_sdk/actions/runs/5736590366/job/15546506053 from this morning
https://github.com/atsign-foundation/at_client_sdk/actions/runs/5735991813/job/15544714736 from this morning
https://github.com/atsign-foundation/at_client_sdk/actions/runs/5725435274/job/15513952967 from yesterday

In each case, the test run failed the first time and succeeded on re-run

The issue is addressed in the PR: https://github.com/atsign-foundation/at_client_sdk/pull/1103

In PR-67, PR: 1103 is merged to trunk branch and mostly likely the issue will not resurface again.


Suggestion: use pudl_ prefix for all command line scripts

Is your feature request related to a problem? Please describe.
I forget what the various PUDL commands are, and I'm lazy. I know a bunch start with pudl_, but what's the sqlite one called? It would be nice to just type pudl_ and tab complete.
Describe the solution you'd like
It would be convenient if all of the PUDL command-line tools were prefixed with pudl_
Here are possible re-names:

datapkg_to_sqlite → pudl_datapkg_to_sqlite
epacems_to_parquet → pudl_epacems_to_parquet
ferc1_to_sqlite → pudl_ferc1_to_sqlite

Describe alternatives you've considered
Other options would be remembering the commands better, or maybe having a docs page that lists all of the command line tools.

Yeah, I've thought about doing this too.  Or using the command/subcommand structure that conda and git and apt and a bunch of other unix tools have. So like pudl data and pudl ferc1_to_sqlite or something.  But agree, with tab completion, this is unnecessarily complicated as it is.


How do I set internalOnly for the environment?

Please provide us with the following information:

This issue is a: (mark with an x)

[ ] bug report -> please search issues before submitting
[x] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
A clear and concise description of the observed issue.
Steps to reproduct

..
..

Expected behavior [What you expected to happen.]
Actual behavior [What actually happened.]
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Ex. Did this issue occur in the CLI or the Portal?

internalOnly environments are ones that are ones running with a custom vnet setup https://docs.microsoft.com/en-us/azure/container-apps/vnet-custom-internal?tabs=bash&pivots=azure-portal

Is this only available to certain regions? I deployed one yesterday  to eastus2 with a custom vnet and the option is grayed out for me. Is there a CLI or ARM template option

On May 26, 2022, at 2:12 PM, Ahmed ElSayed @.***> wrote:

internalOnly environments are ones that are ones running with a custom vnet setup https://docs.microsoft.com/en-us/azure/container-apps/vnet-custom-internal?tabs=bash&pivots=azure-portal
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

The confusion for me is that the internalOnly is part of the enviroment but it can not be changed after the enviroment has been created ( at least from the portal). Once the environment is created then as public ingress option is grayed out (makes sense now). I guess having the option to change the environment to be internal from the environment would be nice ( when attached to vnet)

Looks like the are some resources deployed in the customer subscription for this magic to work. Its a little surprising and it kind of makes sense why this is not a option on the environment. I would love it if there a link to the mc_ resource group so folks can see the stuff powering this magic since it is deployed in the subscription.

https://docs.microsoft.com/en-us/azure/container-apps/networking#managed-resources
Managed resources
When you deploy an internal or an external environment into your own network, a new resource group prefixed with MC_ is created in the Azure subscription where your environment is hosted. This resource group contains infrastructure components managed by the Azure Container Apps platform, and shouldn't be modified. The resource group contains Public IP addresses used specifically for outbound connectivity from your environment and a load balancer. As the load balancer is created in your subscription, there are extra costs associated with deploying the service to a custom virtual network.


Is the latest version compatible with v13?

Hi Team,
I'm upgrading my project from v11.4.2 to v13. I upgraded perplex to the latest version (3.0) however after an upgrade, every block is showing an error 'Block definition not found'. Neither does it allow me to add a new content item, instead showing an error 'No Content Block definition found'.
I wonder if it is because of the Nested Content being deprecated in v13?
Please let me know if you need any further info.
Thanks

Hi Daniel,
Thank you for the guidance. It is working now.
Out of curiosity, are you planning to introduce a migrator that can convert the NC blocks to the BLE? Would be extremely helpful in the future when deprecated property editors would not be available at all.
Kind Regards

Good to hear it works.

are you planning to introduce a migrator that can convert the NC blocks to the BLE?

While I cannot make any promises it is likely that for the next Umbraco LTS we at Perplex also need to migrate to either the native Block List or migratie ContentBlocks itself to use BlockList as base rather than NestedContent. Either way we probably need some sort of data migration from NC -> BL, so I do expect some sort of Perplex.ContentBlocks.DataMigration  package that will migrate data in some way (either to standalone BlockList types or to ContentBlocks with BlockList as underlying data model).
Not sure though, and regardless this will probably only be released around the time v17 (next LTS) is out and not when v14 (first major without NestedContent) is released since it's not LTS. v13 will be supported longer than all of v14 - v16.
Hope this gives you enough info, closing this now since your issue has been resolved!

Thanks Daniel, this makes sense.


Add RPC method starknet_getClassHashAt

Usage related changes

Close #47
If you run Devnet with DEVNET_PORT=5050 cargo run -- --seed 0 --accounts 1, then this works:

curl localhost:5050/rpc -X POST -H "Content-Type: application/json" --data '{
        "jsonrpc":"2.0",
        "method":"starknet_getClassHashAt",
        "params": {
            "block_id": "latest",
            "contract_address": "0x64b48806902a367c8598f4f95c305e8c1a1acba5f082d294a43793113115691"
        },
        "id":1
}'

Development related changes

Add getter of state at specific block (currently dummy logic - only suppots latest/pending).

Checklist:

[x] Applied formatting - ./scripts/format.sh
[x] No linter errors - ./scripts/clippy_check.sh
[x] Performed code self-review
[x] Rebased to the last commit of the target branch (or merged it into my branch)
[x] Documented the changes
[x] Linked the issues which this PR resolves
[x] Updated the tests
[x] All tests are passing - cargo test

Not to block further development, I'll deal with integration tests separately.


Support for Yew 0.21.0

Is this project dead?

I mean, isn't it best practice to nullify all previous documentation at each damn release?
I am trying to write an example using Actix backend sockets and Yew frontend sockets, do you have any example of use of this crate with any backend?

This issue should be now closed since it was handled in pull request https://github.com/security-union/yew-websocket/pull/13

sweet lets gooo!

Here's the latest version: https://crates.io/crates/yew-websocket
yew-websocket = "1.21.0"


Help setting up DNSCrypt with pdnsd

I've been using DNSCrypt for a while now, and although it's been a PITA making it work with Viscosity and the wifi portal I need to connect through, I decided I should also install pdnsd to cache DNS requests.
But this seems to be above my skill level, and I haven't been able to make it operable.
I installed Homebrew and then pdnsd, and have tried editing the pdnsd.conf file.
I've found virtually no help for setting up either one on Mac. I did try some steps found on different sites.
Got some error messages and it seems DNSCrypt needs to be diverted from port 53 to another port so that pdnsd can use that port.

Hi,
I've never used pdnsd, but looks like there is some information here.
Their sample configuration connect to the dnscrypt proxy on port 40, so you need to adjust the dnscrypt .plist file in order to add this to the <ProgramArguments> section:
          <string>--local-address=<IP_ADDRESS>:40</string>

I've read that page several times and that's where I copied the text to place in the pdnsd.conf file.
That page is loaded with commands, and I didn't know what all was necessary.
At the bottom of the page it says "Since DNSCrypt is a long-running network service, it is recommended to run it as its own, unprivileged user.
useradd -r -d /var/dnscrypt -m -k /var/empty -s /bin/nologin dnscrypt"
I don't know if that's something I should do or not, seems like DNSCrypt would have done this or instructed how to do this on install if it was a preferred method.
I've reinstalled pdnsd and it's currently running and DNSCrypt is connected.
I added that line to the DNSCrypt plist, changing to 40 to 54 which I'd previously set in pdnsd.
I don't normally edit plists, so I had to read a bit to get it right (I hope).

Due to my extensive hosts file (a known problem for pdnsd although it's only 872 kb), I created a basic hosts-pdnsd file and added that path to pdnsd's conf file.
That file now reads as follows:
**global {
perm_cache = 1024;
cache_dir = "/usr/local/var/cache/pdnsd";
run_as = "pdnsd";
server_ip = <IP_ADDRESS>;
status_ctl = on;
query_method = udp_tcp;
min_ttl = 15m;       # Retain cached entries at least 15 minutes.
max_ttl = 1w;        # One week.
timeout = 10;        # Global timeout option (10 seconds).
neg_domain_pol = on;
udpbufsize = 1024;   # Upper limit on the size of UDP messages.
}
server {
label = "dnscrypt-proxy";
ip = <IP_ADDRESS>;
port = 54;
timeout = 4;
proxy_only = on;
}
source {
owner = localhost;
file = "/etc/hosts-pdnsd";
}**
I don't know if I was supposed to remove everything else in the file or just replace parts of it, but I deleted everything then pasted in text found on that page you linked to and changed a couple things
The command sudo lsof -i -P | grep -i "listen" lists these ports.
Looks like I still need to redirect DNSCrypt from port 53?
I thought I did that already when I pasted in that string you posted.
iGlasses    537            Bob    9u  IPv4 0xa9a8b712bdd36883      0t0    TCP localhost:51622 (LISTEN)
dnscrypt-  8227         daemon    8u  IPv4 0xa9a8b712c41a6f8b      0t0    TCP <IP_ADDRESS>:53 (LISTEN)
2BUA8C4S2 35118            Bob   16u  IPv4 0xa9a8b712c6311883      0t0    TCP localhost:6258 (LISTEN)
2BUA8C4S2 35118            Bob   18u  IPv6 0xa9a8b712bdcd54fb      0t0    TCP localhost:6258 (LISTEN)
2BUA8C4S2 35118            Bob   19u  IPv4 0xa9a8b712c72f9693      0t0    TCP localhost:6263 (LISTEN)
2BUA8C4S2 35118            Bob   20u  IPv6 0xa9a8b712bdcd5a5b      0t0    TCP localhost:6263 (LISTEN)
pdnsd     68517         nobody    3u  IPv4 0xa9a8b712c41b1883      0t0    TCP localhost:53 (LISTEN)
Mac-mini:~ Bob$
With DNSCrypt disabled my IP address appears in the midwest where my chosen DNS server is located. When I enable it, the address is the selected location, currently overseas.

pdnsd DOES NOT start on boot.
I've rebooted several times and it DOES NOT launch on boot.

If I understand correctly, you are using Homebrew, including to install something called pdnsd, but not for not for the dnscrypt client.
That app does a lot of things. It changes network settings, it tries to find appropriate parameters for the proxy, it monitors the connection, it monitors the proxy, is enables modules, it detects network configuration changes, it provides a user interface and it bridges everything.
Adding support for a DNS cache in this application is likely to be way more complicated than just changing a .plist file.
The instructions you read on the Arch Linux website can be only be adapted to dnscrypt-proxy being run on macOS like it is on Linux.
But what are you actually trying to do? If you just need to block domain names, you can paste them in the "Block queries for the following domain names" box in the OSX-DNSCrypt Client application.

I already had DNSCrypt installed and had been using it a few months.
After reading that a local cache would speed up browsing, I decided to install pdnsd.
Pdnsd maintains a local disk cache of the queries that your system performs and subsequent queries will be faster from the cache. DNSCrypt turns regular DNS traffic into encrypted DNS traffic that is secure from eavesdropping and man-in-the-middle attacks.
Installing pdnsd required installing Homebrew or MacPorts first.
What Does Homebrew Do?
Homebrew installs the stuff you need that Apple didn’t (says the Homebrew website).
I really didn't like the thought of installing more "garbage" and  hope I can uninstall it if I ever get pdnsd working. If I'd known getting pdnsd to run would be so difficult I wouldn't have attempted it. It looks simple on this page.
I'm not sure this will ever work for me.
I'm supposed to set the DNS in System preferences to <IP_ADDRESS>.
But I'm connected to a business's wifi through their portal and it keeps changing the address to 127.0.0.x.
Also, there are four different DNSCrypt plist files in LaunchDaemons and they're very similar. I'm not sure which one that string should be placed in but I put it in ControlChange. And I don't know Jack about keys, arrays and strings, so did I insert it in the proper place?
It didn't work right using a text editor so I installed a plist editor.
WorkingDirectory
/Library/PreferencePanes/DNSCrypt.prefPane/Contents/Resources/usr/scripts
ProgramArguments
--local-address=<IP_ADDRESS>:54

/Library/PreferencePanes/DNSCrypt.prefPane/Contents/Resources/usr/scripts/handle-control-change.sh

/Library/LaunchDaemons/com.github.dnscrypt-osxclient.DNSCryptAfterboot.plist
/Library/LaunchDaemons/com.github.dnscrypt-osxclient.DNSCryptConsoleChange.plist
/Library/LaunchDaemons/com.github.dnscrypt-osxclient.DNSCryptControlChange.plist
/Library/LaunchDaemons/com.github.dnscrypt-osxclient.DNSCryptNetworkChange.plist

BUMP.
Can anybody assist?
Actually it may be hard to set up now because the owners of the wifi portal I connect through changed their ISP yesterday and now DNSCrypt won't connect at all.
But I'd still like to get the pdnsd cache working so when I change locations it will be usable.

Questions about pdnsd or Homebrew have a better chance to get answered if asked on their respective issue trackers/mailing lists.

My issue has nothing to do with Homebrew and there's no issues tracker on GitHub for pdnsd.
That's why I posted it here - these apps are supposed to work together, pdnsd just adds a cache for DNSCrypt to use.


Console Exception Message Spam

Description (Required)

I downloaded the latest version of Dyna Tech last night, but now the console is being spammed with these exception messages. I'm not sure what to write here, as there doesn't seem to be anything wrong at first glance from a player's point of view. Please let me know what other information I can provide.
Steps to reproduce the Issue (Required)

Update Slimefun server to 1.16.5
Update all add-ons and other plugins
Wait overnight
Check console to see error message spam

Expected behavior (Required)

No console spam
Server Log / Error Report

This gets spammed in the console roughly once a second: https://pastebin.com/TQwaDMix
Environment (Required)

Minecraft Version: 1.16.5 Paper Build 457
CS-CoreLib Version: DEV - 92
Slimefun Version: vDEV - 805
Plugin Version: vDEV - 36

Closed. Fixed in 43cdee8


Specify Relations in Flavor

Description
Its convenient to specify the relations in the Flavor (Standard/Ultra) classes.
Checklist:

[ ] I have reviewed my diff in github, line by line.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to the issue(s) that it resolves.
[ ] There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
[ ] There are no circuit changes, OR specifications in /markdown/specs have been updated.
[ ] There are no circuit changes, OR a cryptographer has been assigned for review.
[ ] I've updated any terraform that needs updating (e.g. environment variables) for deployment.
[ ] The branch has been rebased against the head of its merge target.
[ ] I'm happy for the PR to be merged at the reviewer's next convenience.
[ ] New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
[ ] If existing code has been modified, such documentation has been added or updated.

This work has been rolled into PR #455


Properly handle quoted values

Properly parse right hand side value when it is a quoted string.
Ignore comment line.

Thanks!


Implement Time class in Ruby Core

In MRI, Time is both a Core class and a Standard Library package.
The Core class is implemented in C, see time.c in CRuby. Reimplement this class in Rust with httpdate and chrono.
The Standard Library package is pure Ruby and can likely be imported as is once the Core class is in place. See GH-158 for an example of how to do this.
Remove dependency on mruby-time mrbgem.

I'm familiar with C and the ruby-c-api from some time back, would you say this is a good issue to start with, given that libraries to handle time exist / the code to port is reasonable?
Also, how does one get started contributing to this repo? I'm picking up rust as a new language, I come from a strong C++ background.

Hi @vaibhav-y 👋 I would love to leverage your experience to help implement Artichoke.
I've added a CONTRIBUTING.md which outlines how to get set up so you can build the code and run the tests.
The time package in MRI has both C and Ruby pieces to it. Artichoke has implemented Regexp already which follows a similar pattern.
For handling the time bits, we can probably use some combination of httpdate and chrono.
One thing Artichoke does that is maybe non-obvious Rust is make heavy use of Rc and interior mutability with RefCell. You can check out manual.rs for a self-contained example of how this works.
I hope this is enough to get started and I'm happy to answer any questions you have along the way.  I'm excited to have you contribute 💎

Thanks for all the information! I will keep you posted on developments, for now I'm reading through the items you've sent me, and also figuring out a mind map for using rust. Is there an IRC channel or group somewhere we keep in touch regarding general questions & such?

If you find chat conversations to be higher bandwidth, I've created a discord server, which you can join by clicking: https://discord.gg/QCe2tp2
I'll be adding this info to the CONTRIBUTING guidelines soon. Thanks for the push.

@vaibhav-y I've updated the issue description to reflect that this issue is focused on implementing Time as defined in Ruby Core.

Ack.

hey @b-n I'm doing some backlog grooming and found this ancient issue. I think we can close this?
If yes, please do the honors as this is a result of your hard work 💪

Oh nice :broom:ing.
Yeah, I think this makes sense to close. A quick grep for mruby-time only shows things in vendor/ which feels like that's the main goal here :-D.


draw a picture from the internals documentation

In PR #155 there is a useful writeup of how attic works. It might be useful to create some big picture from this, how it all works together.
Preferably a format should be used that can easily get updated in case something changes (see all the other PRs).

I would recommend SVGs for this: you get the source for free. After years of fighting with Dia, I finally gave up and use Inkscape now, which supports snapping and routing between objects now.

Also, browsers can show SVG directly and it's scalable. +1 for SVG from me (I likely won't work on this though, rather hack the code. :)

woot. if you can doodle some quick napkin drawings and take a picture, i can turn that into something pretty in my copious free time. i may do so myself.

+--------+ +--------+     +--------+
|archive0| |archive1| ... |archiveN|
+--------+ +--------+     +--+-----+
    |          |             |
    |          |             |
    |      +---+             |
    |      |                 |
    |      |                 |
    +------+-------+         |
    |      |       |         |
 /chunk\/chunk\/chunk\...   /maybe different chunks lists\
+-----------------------------------------------------------------+
|item list                                                        |
+-----------------------------------------------------------------+
    |
    +-------------------------------------+--------------+
    |                                     |              |
    |                                     |              |
+-------------+                     +-------------+      |
|item0        |                     |item1        |      |
| - owner     |                     | - owner     |      |
| - size      |                     | - size      |     ...
| - ...       |                     | - ...       |
| - chunks    |                     | - chunks    |
+----+--------+                     +-----+-------+
     |                                    |
     | +-----+----------------------------+-----------------+
     | |     |                                              |
     +-o-----o------------+                                 |
     | |     |            |                                 |
  /chunk0\/chunk1\ ... /chunkN\     /chunk0\/chunk1\ ... /chunkN'\
 +-----------------------------+   +------------------------------+
 |file0                        |   |file0'                        |
 +-----------------------------+   +------------------------------+

\o/

extracted from https://mail.python.org/pipermail/borgbackup/2016q1/000116.html


Update link to Cloud docs

Description
Update links to tutorial in Cloud docs to point to landing zone deployment guide

[x] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This PR is included in version 1.7.6 :tada:
The release is available on:

GitHub release
v1.7.6

Your semantic-release bot :package::rocket:


Wrong formula in "Set conditional formatting"

The formular written in the support page in the section "Set conditional formatting": If(DataCardValue2.Value = true, true)
is wrong (now). It has to be:
If(DataCardValue2.Value = true; true)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3a8c4146-101d-7ba2-7ae0-d7138b743154
Version Independent ID: 1f752762-0809-a2fb-4a03-b490547ee7f1
Content: Customize a SharePoint list form - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/customize-list-form.md
Service: powerapps
GitHub Login: @emcoope-msft
Microsoft Alias: emcoope

Thank you for reaching out. Looks like the formula If(DataCardValue2.Value=true,true) works fine. If there are any issues, please reach out to our support teams to help you investigate by creating a support ticket.


Add hacktoberfest label to "quality-assurance" repo

To ensure that contributions to the repository are counted for the hacktoberfest it would be necessary to update the repository label.
At the moment the "hacktoberfest2021" label is present:

Thanks so much @ludovicobesana - and apologies, we are in the process of revamping the process for QA community members to contribute.  An oversight on my part and we'll definitely get this fixed.


Fix: Fix Error When Fetching DevOps PRs

Fix error when the repo name is null while fetching Pull Requests

Looks like I no longer have permission to repository, could someone help me out?

@dpmex4527 -- any shot you could have someone take a peek at this PR?
cc: @jessicaliu100

Nudge.


Support policies like "allow every atSign to connect to someHost:somePort"

Is your feature request related to a problem? Please describe.
For demonstration / kicking the tyres purposes, we want to support policies like "allow every atSign to connect to someHost:somePort" - we have no way of doing that currently
Describe the solution you'd like
For demonstration / kicking the tyres purposes, we want to support policies like "allow every atSign to connect to someHost:somePort"

How do we stop this from being abused?

@XavierChanth can you add a little more background for this feature request please?

I don't think this should be part of the open source code. The main purpose for it is to serve a public trial device over NoPorts.
There aren't any clearly defined use cases for having an unrestricted policy anywhere else.


Set app visibility in update_admin_profile

and set tab visibility to DefaultOn

Looks like a good improvement, but I'm disappointed that there are no tests.


created trial.txt

created this file to show a sample in readme

@kalash2205  you can simply add a screenshot to show ur work no need to create addition sample files .

@kalash2205 you can simply add a screenshot to show ur work no need to create addition sample files .

yes i am doing this in the readme, i will delete file after this.


ImportError: libpyside6.abi3.so.6.4: cannot open shared object file: No such file or directory

Bug not reported or fixed as far as I can see (apart from #2114)

Same bug in develop

1.6rc2
Commercial: None
Python: 3.11.2 (main, Feb 12 2023, 13:27:53) [GCC 11.3.0]
Flavor: pyenv
Executable: /home/bers/.pyenv/versions/3.11.2/bin/python3
OS: Linux
Arch: x86_64
Distribution: Ubuntu (based on Debian) 22.04.1
Version C compiler: /usr/bin/gcc (gcc).

Installed via pip install https://github.com/Nuitka/Nuitka/archive/refs/heads/develop.zip

Short, Self Contained, Correct, Example: bug2.py

  # python -m pip install nuitka PySide6-Essentials
  # python -m nuitka bug2.py
  # bug2.dist/bug2.bin

  # nuitka-project: --quiet
  # nuitka-project: --standalone
  # nuitka-project: --static-libpython=no
  # nuitka-project: --enable-plugin=pyside6

  from PySide6.QtCore import QCoreApplication

  application = QCoreApplication()
  print("Done.")

Using PySide6-Essentials==6.4.2
Regression: 1.5 works, 1.5.1 fails

So, this is pyenv, which may not be a good idea to use. Their PySide6 may not be all that portable. Also apparently you didn't even care to make the static linking work, but that won't be the issue.
And this is Python3.11, of which I am not entirely sure it works for PySide6. I was just confirming PySide6 still works on Windows with 3.10, didn't try 3.11 yet. Also going to try my self compiled 3.11 on Debian. You seem to suggest you used PyPI to install PySide6, that ought to work. Something from pyenv I would be a lot more sceptic, but it's not clear from your report. Going to checkout 3.10/3.11 on Linux too.
This being a regression is indeed interesting. If possible it would be nice if you used git bisect to pin point it, but it's likely that I reproduce it too apparently.

If possible it would be nice if you used git bisect to pin point it, but it's likely that I reproduce it too apparently.

Sure. 09ac64b5fb750b309197cdd1173f39315ff4b1f8 works, a899b82df3dfa28ca0835961aa5bce6298ff40f5 fails. (I mentioned that commit in #2114, so I am not sure deleting that issue was a net positive.)

So, this is pyenv, which may not be a good idea to use. Their PySide6 may not be all that portable.

Out of curiosity, how is "pyenv's" PySide6 different from other PySide6s? Don't they use the same wheels? Note that I am not necessarily using virtual environments, I mainly use pyenv as a convenience tool to download and switch between Python versions.

I am sure it was, for the reasons I gave. It mentioned the commit, but didn't say you if actually bisected it. Also you mentioned Windows to stop working, which I wonder if this could be due to an unrelated issue that I fixed on the factory branch maybe. If you want to try that, and see it work, that would be great. I am currently waiting for the 3.11 on Windows to succeed before turning to Linux. I think you have been victim to distinct issues.

So, 3.11 on Windows is running too for me as well. I do not think said commit plays a role there at all. On Linux, this might be different, lets see.

So, two DLLs got moved, but libshiboken6 is duplicated in shiboken6 and top level. That may actually be preventing its load, and definitely is very unwelcome. It is what I saw with openvino which lead me to make this fix. But apparently it can cause the same issue elsewhere. I will revert it for a 1.5.2 later, until it is assessed what the impact of this is. Everything tensorflow, scipy, etc. works still, but PySide6 breaking is not acceptable at all.

So, 3.11 on Windows is running too for me as well.

I agree, with the above repro code it works on Windows for me as well. So the fact that my main application does not launch on Windows must be related to something else, which I will report separately when I can isolate it.

Update: That Windows issue was due to me using nuitka-project: --force-stdout-spec="%NONE%" on a pre-factory version of Nuitka without a console attached, so I did not see the error that was raised. No further issue to be reported at this point in time :)

Yes, and these values are also only checked in the new version, so that error went unnoticed. Sorry about that.

I have rebased main and develop, and 1.5.2 will release it with a change that restores PySide6, and only does the new thing for openvino, so I am closing this early, because I do not track it through factory now.

PySide6 breaking is not acceptable at all.

I guess so - v1.5.1 even made it to their developer notes ;)
https://wiki.qt.io/Qt_for_Python_Development_Notes

1.5.2 will release it with a change that restores PySide6

Thanks :)


[BallerinaToOAS] Fix Nullable record field mapping to OAS schema properties

Purpose

Fix #583

Automation tests

Unit tests  - add

Code coverage information

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Test environment

JDK 11

Learning

https://swagger.io/docs/specification/data-models/data-types/#:~:text=considered boolean values.-,Null,-OpenAPI 3.0 does

Went through the test-cases. LGTM!


Should include esxi provider

Added

Provider:

esxi

This solves https://github.com/mjuenema/python-terrascript/issues/145