Danger crash on Ruby 2.4.3

Report
What did you do?
bundle exec danger
What did you expect to happen?
Running your Dangerfile without it crashing.
What happened instead?
bundler: failed to load command: danger (/Users/distiller/project/vendor/bundle/ruby/2.4.0/bin/danger)
MultiJson::AdapterError: Did not recognize your adapter specification (dlopen(/Users/distiller/project/vendor/bundle/ruby/2.4.0/gems/json-2.1.0/lib/json/ext/parser.bundle, 9): Library not loaded: /usr/local/opt/ruby/lib/libruby.2.4.2.dylib
  Referenced from: /Users/distiller/project/vendor/bundle/ruby/2.4.0/gems/json-2.1.0/lib/json/ext/parser.bundle
  Reason: image not found - /Users/distiller/project/vendor/bundle/ruby/2.4.0/gems/json-2.1.0/lib/json/ext/parser.bundle).

CircleCI
Are you running the latest version of Danger?
Yes (5.5.5)
What is your Dangerfile?

 # Warn about develop branch
warn("Please target PRs to `develop` branch") if github.branch_for_base != "develop"

# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"

# Warn no CHANGELOG
#warn("No CHANGELOG changes made") if git.lines_of_code > 50 && !git.modified_files.include?("CHANGELOG.md")

# Warn essential files changes
warn(".gitignore changed") if git.modified_files.include?(".gitignore")
warn(".swiftlint.yml changed") if git.modified_files.include?(".swiftlint.yml")
warn(".circleci changed") if !git.modified_files.grep(/\.circleci/).empty?
warn("Cartfile changed") if git.modified_files.include?("Cartfile")
warn("Cartfile.resolved changed") if git.modified_files.include?("Cartfile.resolved")
warn("codecov.yml changed") if git.modified_files.include?("codecov.yml")
warn("Dangerfile changed") if git.modified_files.include?("Dangerfile")
warn("fastlane changed") if !git.modified_files.grep(/fastlane/).empty?
warn("Gemfile changed") if git.modified_files.include?("Gemfile")
warn("Gemfile.lock changed") if git.modified_files.include?("Gemfile.lock")
warn("Podfile changed") if git.modified_files.include?("Podfile")
warn("Podfile.lock changed") if git.modified_files.include?("Podfile.lock")

# Warn summary on pull request
if github.pr_body.length < 5
warn "Please provide a summary in the Pull Request description"
end

# If these are all empty something has gone wrong, better to raise it in a comment
if git.modified_files.empty? && git.added_files.empty? && git.deleted_files.empty?
fail "This PR has no changes at all, this is likely a developer issue."
end

# Warn when there is a big PR
warn("Big PR") if git.lines_of_code > 500

has_AnalyticService_changes = !git.modified_files.grep(/AnalyticService/).empty?
has_ApolloService_changes = !git.modified_files.grep(/ApolloService/).empty?
has_CredentialService_changes = !git.modified_files.grep(/CredentialService/).empty?
has_Entity_changes = !git.modified_files.grep(/Entity/).empty?
has_Interactor_changes = !git.modified_files.grep(/Interactor/).empty?
has_PaymentService_changes = !git.modified_files.grep(/PaymentService/).empty?
has_Utility_changes = !git.modified_files.grep(/Utility/).empty?

has_AnalyticService_tests_updated = !git.modified_files.grep(/AnalyticServiceTests/).empty?
has_ApolloService_tests_updated = !git.modified_files.grep(/ApolloServiceTests/).empty?
has_CredentialService_tests_updated = !git.modified_files.grep(/CredentialServiceTests/).empty?
has_Entity_tests_updated = !git.modified_files.grep(/EntityTests/).empty?
has_Interactor_tests_updated = !git.modified_files.grep(/InteractorTests/).empty?
has_PaymentService_tests_updated = !git.modified_files.grep(/PaymentServiceTests/).empty?
has_Utility_tests_updated = !git.modified_files.grep(/UtilityTests/).empty?

if has_AnalyticService_changes && !has_AnalyticService_tests_updated
   warn("The AnalyticService files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the AnalyticService changes.")
end
if has_ApolloService_changes && !has_ApolloService_tests_updated
warn("The ApolloService files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the ApolloService changes.")
end
if has_CredentialService_changes && !has_CredentialService_tests_updated
warn("The CredentialService files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the CredentialService changes.")
end
if has_Entity_changes && !has_Entity_tests_updated
warn("The Entity files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the Entity changes.")
end
if has_Interactor_changes && !has_Interactor_tests_updated
warn("The Interactor files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the Interactor changes.")
end
if has_PaymentService_changes && !has_PaymentService_tests_updated
warn("The PaymentService files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the PaymentService changes.")
end
if has_Utility_changes && !has_Utility_tests_updated
warn("The Utility files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the Utility changes.")
end

swiftlint.verbose = true
swiftlint.config_file = '/Users/distiller/project/.swiftlint.yml'
swiftlint.lint_files

junit.parse "fastlane/test_output/report.junit"
junit.report

@mylifeasdog Hi, I saw an error: MultiJson::AdapterError: Did not recognize your adapter specification, could you try to install any json engine? Thank you.

Since Danger has dropped support for Ruby <= 2.6, let me close this issue.
Feel free to reopen this issue if the problem still occurs with the latest Danger.


Start adding flow annotations, plus updates to build and linting processes

This is an initial Proof Of Concept for using flow for https://github.com/openstreetmap/iD/issues/3744.  I've added some annotations to a couple of utils files and updated the build process, including using a rollup plugin to remove the annotations during the build.  The build now runs flow as part of the "run all" script and will report any errors found by flow which will prevent the build continuing.
I've also updated the eslint config to be compatible with the flow annotations, which required use of the eslint-babel parser (see https://github.com/eslint/eslint/issues/2157).  I've used the default config for the https://github.com/gajus/eslint-plugin-flowtype plugin.
If this PR looks ok and is along the lines you were thinking, flow annotations could be added gradually to the rest of the codebase.

Hey @Psigio just wanted to give my feedback that I really like this!  I chatted with @kepta a bit yesterday and we are 👍 with adding flow annotations to the entire iD codebase gradually.
I would merge this right now, but I'm releasing a new version of iD today.  So I'll probably take a closer look over the weekend.  Thanks!

Looks good, I just merged this..
I also added flow-coverage-report, so we can check on our progress with npm run flow:coverage

41%! 📈

I'm not sure that percentage looks right for only three files with Flow annotations :smiley: - still it will be interesting to see how this value changes as more annotations are added. What's the best approach for adding more annotations? Will you keep the original issue open to track pull requests where the commits have only Flow annotations (rather than those with code changes)?

Flow is very good in guessing the type.
If your code has four
var foo=true;
and six complex variables you get 40% coverage

still it will be interesting to see how this value changes as more annotations are added. What's the best approach for adding more annotations? Will you keep the original issue open to track pull requests where the commits have only Flow annotations (rather than those with code changes)?

Sure, that seems like a good way to proceed.. I'll make a list of all the modules and we can check them off as people add the Flow annotations..
Also, yeah as @HolgerJeromin mentioned - the coverage statistics are kind of funny, but makes some sense.  For each file, there is a percentage of lines that are just trivially obvious.  So if we were to just do nothing but add the // @flow to the top of the file, it would start out with some base percentage complete already.


ghc: do not use ld.gold with musl libc #84670

Motivation for this change
Potential workaround for #84670.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build pkgsMusl.ghc

Looks like ofborg might have timed out.
@adamse Thanks for fixing this.
And thanks to @nh2 and @utdemir for reporting this.

I think we also need to backport to 20.03

Nitpick: would be nice to add a comment why musl is disabled

Added a comment in https://github.com/NixOS/nixpkgs/pull/84809

Does this need a 20.30 backport?

Does this need a 20.30 backport still?

Here: #93687


Target netstandard2.0 to run with Cake.CoreCLR

It would be cool, if the Cake.CoreCLR compatibility could be added, as stated here:
https://cakebuild.net/blog/2018/02/cake-v0.26.0-released
Due to this only "netstandard2.0" needs to be targeted by the addin.
Thanks for your support and your great work!

Not really able to do it any time soon. But I'm open to contributions

Closed by #8

already on nuget. Thanks for the help


Add Support for Apache Iceberg on Snowflake

Snowflake added support for Apache Iceberg.
There seem to be two ways on how this will be implemented:

external table with table_format specification (similar to #138), this will be an easy fix
fully supported iceberg tables with full DML support, expected syntax: "create or replace iceberg table my_iceberg_table"

While this feature is still in private preview, I'd like to add it to the backlog here already.

Note, the way that #138 is implemented, option 1 via "external tables" should already work.
    - name: iceberg_tbl
         description: "External table using Iceberg files"
         external:
           location: "@stage"                      # reference an existing external stage
           file_format: "( type = parquet )"       # fully specified here, or reference an existing file format
           table_format: iceberg                   # specify the table format
           auto_refresh: false                     # requires configuring an event notification from Amazon S3 or Azure

table_format: iceberg

table_format: iceberg is not support for create or replace external table

@ShahNewazKhan are you suggesting that TABLE_FORMAT = ICEBERG is not possible in Snowflake's CREATE EXTERNAL TABLE command? therefore not possible to add support for it in dbt-external-tables?

@dataders correct, if you try to use CREATE EXTERNAL TABLE with TABLE_FORMAT = ICEBERG you get the following error:

You need to use  CREATE OR REPLACE ICEBERG TABLE and specify an external_volume(similar to a snowflake named stage).

For creating the external iceberg table we would need something like:
CREATE OR REPLACE ICEBERG TABLE {database}.{schema}.{table}
  EXTERNAL_VOLUME='{external_volume}'
  CATALOG='{glue_catalog_integration}'
  CATALOG_TABLE_NAME='{glue_table}'
  CATALOG_NAMESPACE='{glue_database}';

The existing code doesn't support it.


Update apache-jena-libs to 4.4.0

Updates org.apache.jena:apache-jena-libs from 3.17.0 to 4.4.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.jena", artifactId = "apache-jena-libs" } ]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by #74.


[TE] frontend - aaronucsd/Add new tab components

Added new common-tabs components (and its sub components - tablist, tabpanel, tab)
Added new styles for this common-tabs component
Added integration tests for the new component
Updated RCA page to use this new component
Documented  example of usage (see below).

  @example
    {{#shared/common-tabs selection=activeTab activeTab=activeTab as |tabs|}}
      {{#tabs.tablist as |tablist|}}
        {{#tablist.tab name="metrics"}}Metrics{{/tablist.tab}}
        {{#tablist.tab name="dimensions"}}Dimensions{{/tablist.tab}}
      {{/tabs.tablist}}

      {{!-- metrics --}}
      {{#tabs.tabpanel name="metrics"}}
        {{!-- IMPORTANT metrics CODE --}}
      {{/tabs.tabpanel}}
      {{!-- dimensions --}}
      {{#tabs.tabpanel name="dimensions"}}
        {{!-- IMPORTANT dimensions CODE --}}
      {{/tabs.tabpanel}}
    {{/shared/common-tabs}}

nitpick:

in the provided screenshot, looks like there's a double border (around the tab card), background-- color seems a bit off as well

"nitpick:
in the provided screenshot, looks like there's a double border (around the tab card),
background color seems a bit off as well"
@justYves Yes t was intended. Have discussed with Kishore on these changes. The idea is to help make the tab more dominate and noticeable as customers reports not knowing those are tabs.


Add Prometheus metrics support to the decoder

In the wake of plonky2 Issue #1513, add metrics support to the decoder as well.

[ ] Investigate an initial set of metrics we want to track
[ ] Add prometheus support, including configuration and sane defaults

I think "decoder" in the title refers to evm_arithmetization, NOT e.g trace_decoder.
I understand we're interested in the following metrics, broken down by block, or by transaction within evm_arithmetization:

witnesses_proved
cpu_halts
cpu_trace_pads
trace_lengths

So I'm a bit skeptical of using Prometheus for the above, which I think shines with measurements like CPU % or throughput, perhaps broken down by a closed set - is this a hard requirement from ops?
Reading the prometheus docs:

When does it fit?
Prometheus works well for recording any purely numeric time series. It fits both machine-centric monitoring as well as monitoring of highly dynamic service-oriented architectures. In a world of microservices, its support for multi-dimensional data collection and querying is a particular strength.

And looking at the API for the prometheus instrumentation crate, we can

register a metric.
Metrics include, most relevant to the wording I've listed above, a CounterVec.

My preference is we go more "Observability 2.0", and canonical log what we need using tracing's structured logging.

Prometheus is a hard req.

Replaced by #797, where further discussions will follow.


Things to snapshot

[ ] NSAttributedString
[x] SCNView
[ ] URL
[x] URLRequest
[x] UIView recursive description
[ ] signal
[x] json
[x] plist
[x] html

For URL is there a reason you wouldn't simply compare absoluteString also maybe an option to compare URLComponents (nicer breakdown vs URL on it's own)?

Do you think it's possible to snapshot generated interface of a swift file?

In Swift 5 a .swiftinterface file is created (link) which is a textual representation of the public/open interface for the library.
Should be fairly doable to use __XCODE_BUILT_PRODUCTS_DIR_PATHS to load that file - snapshot it locally with the test and run a comparison.
(Should say I'm not running Swift 5 at the mo otherwise I'd jump on prototyping this, sounds like an interesting idea)

@Sherlouk @stephencelis Thanks for the replies.
For .swiftinterface it will be for Swift 5.1 for module stability.
For the memory and CPU snapshot we could use task_info API ?

I'm doing some spring cleaning and am closing issues that don't have an obvious fix, like this one 😄 Great discussion and ideas in this thread, though. When GitHub Discussions rolls out we should consider it as a forum for exploring new snapshot strategy ideas. Till then, if you come up with something you'd like to PR, we'd love to see it!


Get Karma unit tests working

I noticed that the Karma unit tests weren't working, and got it updated to get the tests passing.  I did notice the new UI repo so not sure if these tests make sense to maintain, but not sure when the switch to the new repo will occur.

The switch will not happen for a while. The angular upgrade was put on hold right now. I will review this PR shortly.

Running npm test has some test failures for me. How are you running them?

I'm also running npm test, but it's possible that I was running those tests against a much older commit (before splitting off various components into separate repos).  I'll try again this weekend but running them against master.

It does seem to work against master for me.  I'm running:
cd UI
npm install
npm test

Okay, looks like it may have been an environment issue. Can you update the branch so we can approve and merge?

I've rebased against master now

@rvema Since i have updated this branch can you approve and merge? I approve it.


test: example web3py usage

Description:
Creates an example project demonstrating Web3py usage with Hedera
Related issue(s):
Implements # #2724
Notes for reviewer:
Checklist

[X] Documented (Code comments, README, etc.)
[X] Tested (unit, integration, etc.)

Hey @mateuszm-arianelabs, there are some outstanding comments. Would you be able to address them so we can merge this?

LG but two minor change requests
@quiet-node Should be fixed, can you resolve it?

@quiet-node Can you accept requested changes?

Moved to: https://github.com/hashgraph/hedera-json-rpc-relay/pull/2998/files


"continuing this pattern" in output, instead of full data

I'm using Premium Mode to parse complex technical pdfs, with parsing instructions to break the table down by row with labels.  It does it properly for the first couple rows of each table, but then stops and just says "continuing this pattern..." instead of continuing and outputting the full table data.
It actually has in the context a question from the LLM processing it "[Would you like me to continue with more detailed breakdowns of specific pressure points or flow rates for any particular model?]". I've tried editing the prompting it to always continue.

Hi @bradmitchler,
Can you please provide a JobID?

Here's an example:
d4697f95-957d-415b-b192-5577fc286429

Looking at your prompt, I think you may have more consistent results by setting is_formatting_instruction to false, as you don't really want to change the format of the output but simply give some directions.

I tried it - but then it doesn't break apart the data tables in to rows of text.  I'm specifically trying to modify the tables to display in rows of text, like the output of that job I sent.  It's doing it correctly, but not continuing for all cells / data points.
If I turn off formatting instruction, it leaves the data tables fully in tact.  Thoughts?

Yeah, LlamaParse's purpose isn't really to reformat data. We have this feature because it's a nice hack for some use cases.
@hexapode I think this is a great use case for LlamaExtract


Make cli override option

This pull request includes an override option for themeName, and dbName via cli. A required zmqHostname argument was also added.
--themeName
--dbName
--zmqHostname
It also includes some error handling for the params app.
Questions

Working with this issue and the limited amount of tabs issue, I realized that we do a lot of type checking and if typeof props.value != undefined operations throughout the simpleui codebase. What are your guy's thoughts on creating a props class or interface? I believe it would cut down on a lot of repeated code (mostly type checking) throught the codebase

No comments from me otherwise, I'll assume this is tested and working


test_parallel_copy.py stucks sometimes

Example run: https://app.circleci.com/pipelines/github/zenithdb/zenith/4069/workflows/bd3b2ce9-64db-4b43-97da-9840533404f3/jobs/36860
It timed out on some test which didn't show up in passed list. Comparing list of passed tests with pytest --co it seems that testing stuck on test_parallel_copy.py. There is a pageserver log for this test (37MB) which mostly consists of following records:
2022-01-17T16:02:58.379443Z  WARN pagestream{timeline=530325df8c15ea4ba18a8c346d52b6bc tenant=97484f4322894bf1abc1df190ae5e4eb}:get_page{rel=1663/12974/16384 blkno=145108 req_lsn=0/3A89F530}: Page 1663/12974/16384 blk 145108 at 0/3A5D23D8 not found

so far we didn't manage to reproduce this
does this reproduce in CI? @knizhnik didn't notice any resent occasions when tests got stuck
should we mark as Done? or Backlog? kelvich


[bug] Missing nametag faction color

Previous to the last update, Filterplus mod handled only chat tags, while factions would update the HUD nametag. It worked fine, but filterplus was requesting the player's Rank, Exp, and Faction, with every message that was sent in chat. This is not efficient, and could be improved.
It's may take some time, but i think the way forward with this is:

[ ] in FilterPlus, have a table of registered callback functions to request tags during player_join events from the mods.
[ ] These tags are then saved in the session table which already exists
[ ] F+ must also be able to update tags when the information changes, for example a faction name change, or level up.
[ ] i think that's it?

If figuring this out takes more time than I'm comfortable leaving this issue open, i'll set the nametags to how they were before the update, but this may cause the same high cpu time from F+ we had before

idk why this is even open


Request: add support for other git hosting services

BitBucket
Git Lab

Would it possible to use it without git repo for example inside of a docker container with files in a volume?
Or with self hosted gogs / gitea?


The link to download the weight has expired

The link has timed out, could you repost a new link to download the weight? Thanks!

Please give some details. Which link? Which module you are running (verify / analyze), which model etc.
Besides, you can download it manually and copy to to HOME/.deepface/weights folder.


Use strong-typed args feature from docopt.net

This PR proposes to use the new strong-typed arguments model generation introduced with docopt.net 0.8.0 instead of the weaker dictionary-based argument look-up. The benefits are as follows:

Strong-typed arguments.
If the text-based usage (in the Help const) changes in an incompatible way then the program will fail to compile so the chances of the C# source code going out of sync with the help is going to be next to zero.
Parsing logic is generated at build-time so start-up time is quicker.

/cc @voieducode

@atifaziz Thank you for your time and consideration for adding this improvement to VIPR. We are limiting changes to VIPR as we plan to move away from using this to a new tool called Kiota. We will be deprecating VIPR when Kiota is officially released.

@MIchaelMainer Understood and I see you're not using docopt.net in Kiota so there's nothing to port there. I'll close this PR now, but thanks for taking a look and replying so soon.

@atifaziz correct we're using system
Command line for kiota


Missing sensors?

Hi.
This is probably a dumb question but I’ve spent some time trying to work it out. I’ve deleted the integration and reinstalled it.
The documentation says there are dispatch slots that I presume are populated when the charge schedule is
set up. However I can’t see any of these, the sensors are missing. My list is as per the attached screenshot

Logger: homeassistant.components.binary_sensor
Source: custom_components/octopus_intelligent/binary_sensor.py:100
Integration: Binary sensor (documentation, issues)
First occurred: 7:51:41 PM (1 occurrences)
Last logged: 7:51:41 PM
Error while setting up octopus_intelligent platform for binary_sensor
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 320, in _async_setup_platform
await asyncio.shield(task)
File "/config/custom_components/octopus_intelligent/binary_sensor.py", line 19, in async_setup_entry
OctopusIntelligentSlot(
File "/config/custom_components/octopus_intelligent/binary_sensor.py", line 59, in init
self._timer = async_track_utc_time_change(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/event.py", line 1628, in async_track_utc_time_change
f"time change listener {hour}:{minute}:{second} {action}",
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1026, in repr
return f"<entity {self.entity_id}={self._stringify_state(self.available)}>"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 596, in _stringify_state
if (state := self.state) is None:
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/binary_sensor/init.py", line 211, in state
if (is_on := self.is_on) is None:
^^^^^^^^^^
File "/config/custom_components/octopus_intelligent/binary_sensor.py", line 100, in is_on
return self._is_on
^^^^^^^^^^^
AttributeError: 'OctopusIntelligentSlot' object has no attribute '_is_on'

I downloaded earlier today. Tonight  there seemed to be a version number update so i decide to give that a go and the sensors have returned.

Version hasn't changed since June. These threads are for issues not general support.

I reported an issue. Provided some log information and then last night whist investigating what the problem was downloaded a newer version. After that I closed the issue.


AR Goggles

As suggested in #58 (by me), I implemented the AR goggles.
I'd be happy to provide documentation for the lua methods, too, I just don't know where I'd put that.
This makes the mod dependent on Curios, but I would consider that a worthwile tradeoff, even more so since Curios is already part of most modpacks.

Why not make Curios optional dependency? Would that be possible? Make it act as helmet if Curios is not installed.
Or skip it all together and make googles work from anywhere in player inventory?

I completely agree to what Wojbie means.
And could you send a text to the player when they link the AR goggles?

@Wojbie @Seniorendi
Curios as an optional dependency doesn't work the way it is implemented right now, since I am using a few convenience methods offered by it. I suppose it would be possible to refactor the code in a way to make curios optional, but I would have to look into that later today or tomorrow.
As for the text when linking the AR goggles, sure, I will add that as well.

Do NOT merge yet, still needs one fix

It would be cool if you could use colorcodes as &l / §l for thick or &o / §o for italic letters also an in-string color changing for example with the layout: "{\0xffffff}Hello {\0x000000}Goodbye"


Customization Suggestion <:

More than a bug, it's a suggestion, as a clarification, I'm new in Github and I didn't understand very well if the suggestions are made here.
Anyway, mainly my suggestion lies in the configuration file of the mod, I would like it to allow to configure the effect of all the armor separately, without disabling the other perks, if you do not understand me, I mean edit for example:
Dragon armor: allow flying, but don't allow all effects to be healed.
Gobber armor: allow the effects of the armor, except the effect of negating the poison that occurs when the full set is equipped.
etc...
My suggestion lies mainly in more customization, gossiping a bit the jar code, it is not soooooo complicated to make my suggestion (or so I think). thank you very much, I am fascinated by the mod, I had been waiting for version 1.20.1 for a long time.

This is now standard in 1.21+, except for the flight, which will no longer have a config option to disable.
All armor perks are full-suit based, instead of by armor piece.  The perks for each armor set can be enabled/disabled separately.

¡Amazing! ¡Thanks for reading my suggestion!


refactor(world-modules): remove unnecessary abi.encodePacked

I'm not convinced we should do this if this deviates from the spec, but noticed this when trying to debug some issues I thought were related to signing


Save/Load process environment variables in capture file

Fixes #1574 and #1575
This change introduces a new metadata block for saving the captured process's environment variables, which is written out when the capture file is created.
Also adds an argument to gfxrecon-replay-renamed.py for preserving specified environment variable values during replay.

CI gfxreconstruct build queued with queue ID 234128.

CI gfxreconstruct build # 4587 running.

CI gfxreconstruct build queued with queue ID 234173.

CI gfxreconstruct build # 4588 running.

CI gfxreconstruct build # 4588 passed.

CI gfxreconstruct build queued with queue ID 234229.

CI gfxreconstruct build # 4589 running.

CI gfxreconstruct build # 4589 passed.

CI gfxreconstruct build # 4596 running.

CI gfxreconstruct build queued with queue ID 234656.

CI gfxreconstruct build queued with queue ID 234688.

CI gfxreconstruct build queued with queue ID 234691.

CI gfxreconstruct build queued with queue ID 234912.

CI gfxreconstruct build queued with queue ID 235126.

CI gfxreconstruct build # 4600 running.

CI gfxreconstruct build # 4600 passed.

CI gfxreconstruct build # 4604 running.

CI gfxreconstruct build queued with queue ID 235831.

CI gfxreconstruct build # 4605 running.

CI gfxreconstruct build # 4605 passed.

CI gfxreconstruct build queued with queue ID 238759.

CI gfxreconstruct build # 4615 running.


GmSAFIR shuts down when opening a file

I had this error today earlier. When i open a .geo file, GmSafir shuts down instantly. The same file worked yesterday. Then i made a new file, copied the geometrie part from the old .geo file and it worked again. I added some physical groups, i closed GmSAFIR, I started it again, i opened the current file and it worked.
Now, an hour later i have the same Error with the new file again. I did not changing something, exept  that i created a 2D mesh and tried to open it afterwards. When i open the .geo file now, GmSAFIR shuts down. What could be the issue here?
Q7.txt

Hi, the file opens successuflly on my side. Download the newest version of gmsafir.py and redo the addition of physical groups. As soon as you get a crash, upload here the 2 files (Q7.geo and Q7.g4s). This will enable a diagnosis and then a debug

I have the newest version and I added new physical groups. I can open the file as long as i don´t close GmSAFIR. When i close GmSAFIR, then start it again and i try to open the file afterwards, GmSAFIR crashes. It is not possible to open the file again without a crash. The only way is to create a new file in GmSAFIR, copy the script from the old project and reload the script. This way it doesn´t crash but surfaces and physical groups ar not shown in the new model and i have to redo them. When i close GmSAFIR with the new project and try to open it again i have the same problem.
Q7-g4s.txt
Q7-geo.txt

sorry, not clear how to reproduce this bug. Let us try another way, to have a more verbose crash.
Please launch GmSAFIR the "old way" in command line:
1/ go to a DOS terminal ("cmd")
2/ launch following command in the terminal : pythone.exe [full_path]/gmsafir.py  (replace full_path with the one corresponding to the location of the gmsafir.py script)
3/ then in GmSAFIR, open Q7.geo, which should crash, if I get clear your problem.
Please send a "print screen" on the errors that will appear in the terminal after the crash.

First of all, Q7.geo contains a weird line:
Physical Surface("Insulation", 27) += {2, 1};
The "+" sign indicates that the physgroup with id=27 has already been assigned lines in a previous line, but the previous line does not exist!
However, "Physical Surface 27" is attributed a "Surface Material" in g4s file.
Verify the definition of this physgroup, this will remove the warnings in the command line.
However, this is not the origin of the bug that you reported.
Please, download the very last version that I uploaded just now, and retry.

I tried the new Version, the file still crashes. I tried different stuff and i think i could localize the problem to the user defined material. If i use the material "insulation" instead of my user defined material the file does not crash. I attach you the print screen and my user defined material. Thank you for your time

Rockwool2.txt
.

No, the problem does not come from your user defined file: I get it worlking properly when using this user defined file with your former case 2dtherm.geo. Here are the input files:
2dtherm.geo.txt
2dtherm.g4s.txt
Rockwool2.txt
And here the output file:
untitled.IN.txt
The crash that you have is when you use the user defined file with Q7.geo and Q7.g4s? Please, forward me the exact set of files that generate this crash.

I don´t know why but the Q7 file does not crash anymore even though i changed nothing since yesterday. But i have another file that has the same problem. I attach you the whole set of files that lead to the crash.
Q6.g4s.txt
Q6.geo.txt
Rockwool2.txt

ok, the problem is not due to the user defined file. It occurs because the Q6.g4s file has been written not by the newest version of gmsafir.py, which puts in the G4S file the following incorrect definition for your material Insm for physgroup 38:
Surface - New Material Definition : Insm = {
Material Name : defined
Material Group Name : User
Filename : Rockwool2.txt
Young module :<PHONE_NUMBER>00
Poisson coefficient : 0.3
}
Recreating this material with the newest version of gmsafir.py corrects the definition as follows:
Surface - New Material Definition : Insm = {
Material Name : User-defined
Material Group Name : Generic
Filename : Rockwool2.txt
Young module :<PHONE_NUMBER>00
Poisson coefficient : 0.3
}
which then works fine.

Can we close the issue or you still have the problem ?


Nterl0k - T1087.002 - 4662 EventID AD Enumeration

Pending https://github.com/splunk/attack_data/pull/816
Details
Showcases when attackers enumerate AD in mass or for specific high priv (default) groups.
Must allow 4662 events to be ingested by Splunk, which is typically advised against/filtered by the Windows TA.
Checklist

[ ] Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
[ ] CI/CD jobs passed ✔
[ ] Validated SPL logic.
[ ] Validated tags, description, and how to implement.
[ ] Verified references match analytic.

Hello @nterl0k :We are getting some errors for windows_ad_abnormal_object_access_activity.yml. Here is how the given attack data looks in Splunk : you can see that the ObjectName_count is NOT greater than the limit. Do you suspect an issue with the search/ the dataset ? You may need to dump a new dataset for this detetion
Screenshot without the | where ObjectName_count > limit condition

In our production environment the stddev*3 math seemed to be the sweet spot to avoid the detection being overly sensitive.
I can artificially inflate the dataset to make it work as expected.
If I make a PR to the attack dataset can that be expedited to help with this?
Regards,
Steven.
-------- Original message --------
From: Bhavin Patel @.>
Date: 9/12/23 7:56 PM (GMT-05:00)
To: splunk/security_content @.>
Cc: Steven Dick @.>, Mention @.>
Subject: Re: [splunk/security_content] Nterl0k - T1087.002 - 4662 EventID AD Enumeration (PR #2716)
Hello @nterl0khttps://github.com/nterl0k :We are getting some errors for windows_ad_abnormal_object_access_activity.yml. Here is how the given attack data looks in Splunk : you can see that the ObjectName_count is NOT greater than the limit. Do you suspect an issue with the search/ the dataset ? You may need to dump a new dataset for this detetion
Screenshot without the | where ObjectName_count > limit condition
[image]https://user-images.githubusercontent.com/7771446/267493748-a79c1a71-2249-4c33-840e-c9e92f426589.png
—
Reply to this email directly, view it on GitHubhttps://github.com/splunk/security_content/pull/2716#issuecomment-1716731385, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJIYP7UP45GKRC5DFJVJLILX2DZBHANCNFSM6AAAAAAZEYZPUA.
You are receiving this because you were mentioned.Message ID: @.***>

@patel-bhavin - I've built an updated dataset that will trigger the detection as expected. - See PR https://github.com/splunk/attack_data/pull/833 for the updated data.

awesome! i merged the attack_data PR and looks like this passes our detection testing now! Thank you for being so prompt as always. Closing this PR and we will be merging the updated PR that contains your content and will be released in ESCU 4.12.0
https://github.com/splunk/security_content/pull/2810


Multiple idP: restrict email by format

Hi,
I'm using nbgrp/onelogin-saml-bundle with multiple idP.
Users are mapped and logged by email.
I would like to restrict sign in and login only for email like<EMAIL_ADDRESS>Could you please help me to do this ?
Thanks

@dcr31000 hi.
You can look for User Checkers e.g. The checkPreAuth method will be called after handling of SamlResponse and before user authentication, so you could check the user email and throw an appropriate exception if it needed (see available exceptions).

@a-menshchikov seems to be what I need, thanks
Do you know how I can see from wich idp the user is from ?
For example, I would like to authorize emails as<EMAIL_ADDRESS>for idp1 and<EMAIL_ADDRESS>for idp2 etc.

I can only suggest you to pass something helpful in the SAML response attributes. There is no way to pass the IdP name to the user properties.

@dcr31000 you can also use Nbgrp\OneloginSamlBundle\Idp\IdpResolverInterface::resolve which resolve the IdP name from incoming request.


Add .gitattributes file to hide generated files diffs

Closes #2673.
This hides diffs from:

Pipenv lock files;
GraphQL generated files (types and schemas);
mjml precompiled files;
django generated migration files;
pot files;
svg files.

Pull Request Checklist

[x] Privileged views and APIs are guarded by proper permission checks.
[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] Database queries are optimized and the number of queries is constant.
[x] The changes are tested.
[x] The code is documented (docstrings, project documentation).
[x] GraphQL schema and type definitions are up to date.

@Pacu2 you can remove Help Wanted, thanks again.

@patrys I updated the changes, let me know if it's good now or not.


[Work in progress] Add udp.align option

Do you have any idea on where should the resource address option be checked and added on the connector side ?

I don't think we need to have any behavior for the connector, or at least I'm not sure what the behavior would be for outbound connections, so we can document that it has no effect on that.  Do you agree, or do you think we should also align outbound bytes?
We do need it as a  though, specifically for reverse connectivity, where it gets put on the connect-options, but is really used on udp ACCEPTOR.

From here: https://tools.ietf.org/html/rfc5766#section-2.5 it would look like a peer will send turn channel data messages to a client using the channel number. Since the proxy is in the middle it would mean that the data comes on the outbound connection.

In the reverse direction, when Peer A sends a UDP datagram to the
relayed transport address, this UDP datagram arrives at the server on
the relayed transport address assigned to the allocation.  Since the
UDP datagram was received from Peer A, which has a channel number
assigned to it, the server encapsulates the data into a ChannelData
message when sending the data to the client.

After giving more thought, the messages coming from the TURN Server without padding could be considered to always come on udp. I don't think we have anything between the server and the proxy that might alter the data or that we use an underlying protocol.
This would mean that the require.padding option would only apply to the TurnFrameDecoder initiated by the acceptor while the connector side should have the following logic:

buffer has exact length as declared we are most certainly on UDP so decode
buffer has more than declared, should assume padding and decode accordingly

We might even try to detect the underlying transport since the assumption is the connection is direct. The lmitation is that we cannot add on the connector side an intermediary gateway that connects to the turn server on udp but has the accept on tcp.
I think the problem comes because of the difference in the transports, where multiple tcp segments inside a buffer can trigger a read, meaning we can only see a stream of bytes, while only a single udp datagram will trigger a read. There is a protocol over IP that has the reliability of tcp but is message oriented: https://en.wikipedia.org/wiki/Stream_Control_Transmission_Protocol
Waiting for your thoughts on this, I will be focusing on implementing the UdpAlignFilter.

I think you are correct, that we need UDP align for inbound packets on the outbound/connector.  And then the logic can be added probably as a filter put on by the connector

This looks good to me, is it ready to merge?


Select a path to save profiling files

It would be nice to have a constant to set the path of the prof files.

@javaguirre I believe I understand the feature request. Could you describe your use case a little bit more for better context?

I want to be able to have the *.prof in certain path I choose, not in the root of my project.

I'd like to do it. :-)

@javaguirre if you can make a pr for it. I can take a look and merge it in if it checks out

@javaguirre I merged your PR in. Thanks for making your contribution for this issue.

Thank you @avelis more to come I hope! :-)

@javaguirre It's in master now. I have added a snippet to the README on how it's used. I will make a release soon. Likely by EOB Friday.


Add support for exploding dice

Our existing dice script is way too peaceful. Let's get some explosions going on.

lol


Rule idea: prefer individual per-function modules

Rule suggestion to prefer import uniq from 'lodash.uniq'; over import { uniq } from 'lodash'; to slim bundle sizes and call out explicit uses.

Hi, thanks for opening an issue!
This rule is already implemented as import-scope, and its value in the recommended configuration is method, which is what you're describing.

However, the plugin currently doesn't handle per-function modules, and can only read imports of files from the lodash modules. (e.g. it recognizes import uniq from 'lodash/uniq' but not import uniq from 'lodash.uniq').
Since it looks like Lodash themselves are going to discontinue per-method packages (second bullet point at the time of writing), I'm not sure the difference is worth implementing.

rule is already implemented as import-scope

as you later mentioned:

doesn't handle per-function modules

the import-scope rule is not at all what I'm suggesting. The per-function module piece is the crux of the rule. Thanks for pointing out the v5 roadmap; I hadn't seen that.
I can only speak as a user, but I'm not sure the potential deprecation would have any near term impact on me or my desire for this rule. It's presence on the roadmap doesn't guarantee the per-function modules actually get discontinued. Nor is there any timeline as to when that might even happen. (The roadmap currently mentions ~2017 for v5 but that was clearly optimistic.) Even if the per-function modules are discontinued (which isn't a certainty) and even if it happens this year (which is unlikely), a lot of teams will still be using lodash v3 or v4 for quite some time to come (years, most likely). So this rule would still be valuable (at least to me) for quite some time.
Indeed, the discontinuation might even make this rule _more_valuable. If the rule could be implemented in such a way as to be configurable between preferring per-function or rejecting per-function, then the rule would be useful both now in the short term (for current usage) and in the future when migrating to v5.

That's a good point.
It would take a small infrastructure change, as well, to include per-method packages in the first place.
Would you like to submit a PR?

I would like to but it's unlikely I'll have the time in the next few weeks.

I went ahead and implemented this. Fixed in v2.5.0.

sweet, thanks!!


[Feature Request] Include tripple quote comment in final output file!

Possible?
What I have in GraphQL schema:
""" New user account input fields """
input SignUpDetails {
  """ First name """
  firstName: String!

  """ Last name """
  lastName: String!

  """ Email address """
  email: EmailAddress!

  """ User role """
  role: UserRole!

  """ A legit and secure password """
  password: String!

  """ Repeat password """
  passwordRepeat: String!

  """ Language """
  language: String = "en-US"

  """ Timezone """
  timezone: String = "UTC"

  """ CAPTCHA verification code """
  captcha: String
}

What I expect:
export type SignUpDetails = {
  /** First name */
  firstName: string,
  /** Last name */
  lastName: string,
  /** Email address */
  email: EmailAddress,
  /** User role */
  role: UserRole,
  /** A legit and secure password */
  password: string,
  /** Repeat password */
  passwordRepeat: string,
  /** Language */
  language: ?string,
  /** Timezone */
  timezone: ?string,
  /** CAPTCHA verification code */
  captcha: ?string
}

What I got:
export type SignUpDetails = {
  firstName: string,
  lastName: string,
  email: EmailAddress,
  role: UserRole,
  password: string,
  passwordRepeat: string,
  language: ?string,
  timezone: ?string,
  captcha: ?string
};

Is it possible to include comments?

I think we broke description in 1.0.0, will fix soon.

Waiting for the next release.

Fixed in 1.0.1 🚀

Still, no comments in the output file or I am doing wrong?
GraphQL Schema
""" New user account input fields """
input SignUpDetails {
  """ First name """
  firstName: String!

  """ Last name """
  lastName: String!

  """ Email address """
  email: EmailAddress!

  """ User role """
  role: UserRole!

  """ A legit and secure password """
  password: String!

  """ Repeat password """
  passwordRepeat: String!

  """ Language """
  language: String = "en-US"

  """ Timezone """
  timezone: String = "UTC"

  """ CAPTCHA verification code """
  captcha: String
}

File: codegen.yml
overwrite: true
schema: "http://api.test:3000/graphql"
generates:
  flow-typed/thai-condos-graphql.js:
    plugins:
      - flow

What I got:
export type SignUpDetails = {
  firstName: string,
  lastName: string,
  email: EmailAddress,
  role: UserRole,
  password: string,
  passwordRepeat: string,
  language: ?string,
  timezone: ?string,
  captcha: ?string
};

Is there anything I have to do?

@blacksmoke26 I added a test with your example:
https://github.com/dotansimha/graphql-code-generator/blob/8061d5ff7e0d82a2ab4554b3020e41aa9a733a3d/packages/plugins/flow/tests/flow.spec.ts#L8
It seems to work.

Yeah, double checked, Will remove all then try again.

Fixed now. Uninstall and install all packages, working now. Thank You!


The !showemote command shows emotes outside the 1280px x 720px page dimensions

Even at 1920×1080 some time the emote shown is off the screen or barely visible. I solved this by putting the dimensions at 2560×1440.
The streak is in the middle but all emotes are shown inside the screen.

The page dimensions are 1280px x 720px


Creating a large number gives the wrong answer

The following gives the wrong answer:
console.log(require("big-rational")("1234.567000000000000000000000000000000000000000000000000000000000000000001e99999").toString())
The output has a lot of 8s and 9s. Varying the input gives different results, sometimes NaNs, sometimes a stack overflow.

This one is still outstanding. Is it to do with the bug in the integer package, and just needs to update to the latest version of that dependency, or is it something else?
If it's the case that you don't have time to fix this at the moment, but would accept a pull request if I sent one, let me know.

Hi,
Sorry for the delay, thanks for reminding me. I forgot to update this library when I fixed the biginteger issue.
Sure, if you submit a pull request resolving this issue I'll merge it in. Otherwise it will take me some time before I get around to it myself


Shuffle admin services

Changes Unknown when pulling b75db7affbcc53ba18bb6ce2eb7a8e91fc3cfab1 on nobodyiam:shuffle-admin-services into ** on ctripcorp:master**.


Update Reason
Use Case Asset Tracking decided to upgrade the model to a new version.

Convert from BAMM to SAMM

MS1 Criteria

[x ] The model that should be updated exists
[x ] The referenced use case exists
[x ] The potential updates are discussed with all stakeholders
[ x] A decision on versioning was made in consensus with the affected parties according to the guidelines.
[x ] The potential update will be either

[ ] backward compatible or
[x ] a (chain of) migration strategy(-ies) from all non-deprecated previous versions to the new model will be developed

[x ] A modeling steward has been assigned

@modeling_team

Modifying https://github.com/eclipse-tractusx/sldt-semantic-models/blob/main/io.catenax.iot_sensor_device_definition.
Changing from Bamm to Samm.


[BUG] Cursor is missing

goneovim version: 0.5.1
neovim version: 0.6.1
os version: macos 10.15.4
when tt open coc-explore then tt close.
cursor is missing. not happened in iterm2
https://user-images.githubusercontent.com/29330637/149083605-1a8ee965-3c25-4e50-ac14-f1a27f8423b2.mov

Hi.
Thank you for this issue report.
I have fixed this problem.
please try the following latest CI build.
https://github.com/akiyosi/goneovim/actions/runs/1698117338

Hi.
Thank you for this issue report.
I have fixed this problem.
please try the following latest CI build.
https://github.com/akiyosi/goneovim/actions/runs/1698117338

tks. i'll try it.

Cursor missing It still happens when type :help somthing  it opens a split window after close the help menu

@guolimin1995
Thanks for the response. I am waiting for your confirmation.
@sigma2647
Thanks for the report.
Are you saying that you still have the cursor loss problem with the following latest CI?

I have fixed this problem.
please try the following latest CI build.
https://github.com/akiyosi/goneovim/actions/runs/1698117338

I have tried to reproduce the problem by displaying the help menu in :help somthing, but have not been able to reproduce the problem.

@guolimin1995 Thanks for the response. I am waiting for your confirmation.
@sigma2647 Thanks for the report. Are you saying that you still have the cursor loss problem with the following latest CI?

I have fixed this problem.
please try the following latest CI build.
https://github.com/akiyosi/goneovim/actions/runs/1698117338

I have tried to reproduce the problem by displaying the help menu in :help somthing, but have not been able to reproduce the problem.

i use last CI of  https://github.com/akiyosi/goneovim/actions/runs/1698117338, it be fixed.

@guolimin1995 Thanks for the response. I am waiting for your confirmation.
@sigma2647 Thanks for the report. Are you saying that you still have the cursor loss problem with the following latest CI?

I have fixed this problem.
please try the following latest CI build.
https://github.com/akiyosi/goneovim/actions/runs/1698117338

I have tried to reproduce the problem by displaying the help menu in :help somthing, but have not been able to reproduce the problem.

i use last CI of https://github.com/akiyosi/goneovim/actions/runs/1698117338, it be fixed.

:help xxx it`s also fine.

@guolimin1995 Thanks for the response. I am waiting for your confirmation.
@sigma2647 Thanks for the report. Are you saying that you still have the cursor loss problem with the following latest CI?

I have fixed this problem.
please try the following latest CI build.
https://github.com/akiyosi/goneovim/actions/runs/1698117338

I have tried to reproduce the problem by displaying the help menu in :help somthing, but have not been able to reproduce the problem.

i use last CI of https://github.com/akiyosi/goneovim/actions/runs/1698117338, it be fixed.

:help xxx it`s also fine.

Thanks ! that very Cool, I don't need to restart goneovim since after , how do I use this action ,should I using build version instead of release version?

@guolimin1995 Thanks for the response. I am waiting for your confirmation.
@sigma2647 Thanks for the report. Are you saying that you still have the cursor loss problem with the following latest CI?

I have fixed this problem.
please try the following latest CI build.
https://github.com/akiyosi/goneovim/actions/runs/1698117338

I have tried to reproduce the problem by displaying the help menu in :help somthing, but have not been able to reproduce the problem.

i use last CI of https://github.com/akiyosi/goneovim/actions/runs/1698117338, it be fixed.

:help xxx it`s also fine.

Thanks ! that very Cool, I don't need to restart goneovim since after , how do I use this action ,should I using build version instead of release version?

download CI in this action. don't need to build.

@guolimin1995 Thanks for the response. I am waiting for your confirmation.
@sigma2647 Thanks for the report. Are you saying that you still have the cursor loss problem with the following latest CI?

I have fixed this problem.
please try the following latest CI build.
https://github.com/akiyosi/goneovim/actions/runs/1698117338

I have tried to reproduce the problem by displaying the help menu in :help somthing, but have not been able to reproduce the problem.

i use last CI of https://github.com/akiyosi/goneovim/actions/runs/1698117338, it be fixed.

:help xxx it`s also fine.

Thanks ! that very Cool, I don't need to restart goneovim since after , how do I use this action ,should I using build version instead of release version?

download CI in this action. don't need to build.

Got it, thank you sooooo much


Logs plugin

Port Logs plugin from legacy Hawtio, which enables you to view server-side logs on the console.
It should show logs from server side in a table with filtering on log level, logger, message, and MDC properties.
Under the hood, it uses LogQueryMBean to fetch the logs from server side. Currently it only supports Logback.

cc @joshiraez @lhein

Thank you Tada, I'll be working on this

I'll take this one due to the work assignment replanning.


Graph width config

This should in theory add new config option to change canvas width for the graph.
NOTE: this is untested, please test it if you can.

I have read the CLA Document and I hereby sign the CLA


feat: authorization implementation

This PR adds gateway API translator, XDS translator, and e2e tests for the Authorization setting of the SecurityPolicy.
Only source IP is supported for now.  Other principals such as JWT claims, basic auth, etc. will be supported later.
Fix: https://github.com/envoyproxy/gateway/issues/2462
Related: https://github.com/envoyproxy/gateway/issues/2250
Example config:
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: http-with-authorization-client-ip
  namespace: gateway-conformance-infra
spec:
  parentRefs:
  - name: same-namespace
  rules:
  - matches:
    - path:
        type: Exact
        value: /protected
    backendRefs:
    - name: infra-backend-v1
      port: 8080
---

apiVersion: gateway.envoyproxy.io/v1alpha1
kind: SecurityPolicy
metadata:
  name: authorization-client-ip
  namespace: gateway-conformance-infra
spec:
  targetRef:
    group: gateway.networking.k8s.io
    kind: HTTPRoute
    name: http-with-authorization-client-ip
  authorization:
    defaultAction: Deny
    rules:
    - action: Allow
      principal:
        clientCIDRs:
        - <IP_ADDRESS>/24
        - <IP_ADDRESS>/24
---

apiVersion: gateway.envoyproxy.io/v1alpha1
kind: ClientTrafficPolicy
metadata:
  name: enable-client-ip-detection
  namespace: gateway-conformance-infra
spec:
  clientIPDetection:
    xForwardedFor:
      numTrustedHops: 1
  targetRef:
    group: gateway.networking.k8s.io
    kind: Gateway
    name: same-namespace

Test results:
curl -I --header "Host: www.example.com" --header "X-Forwarded-For: <IP_ADDRESS>" http://<IP_ADDRESS>:80/protected
HTTP/1.1 200 OK

curl -I --header "Host: www.example.com" --header "X-Forwarded-For: <IP_ADDRESS>" http://<IP_ADDRESS>:80/protected
HTTP/1.1 403 Forbidden

@zhaohuabing questions, what is the differentiation of Authorization API & SecurityPolicy API.
since currently JWT, basic auth is located on securitypolicy. do we plan to move it to Authorization API in the future?

@zufardhiyaulhaq Authorization is part of the SeucrityPolicy, as the example in the PR description shows.

ahh just realized that @zhaohuabing thanks!

I am testing this and got error
'Unable to translate authorization rule: invalid CIDR address: <IP_ADDRESS>'
I could apply the configuration fine, but I was wondering why it was not provisioned. I could see that error in securitypolicy status. Just thinking, should it be validated in creation that ip address contains mask as well?

I am testing this and got error
'Unable to translate authorization rule: invalid CIDR address: <IP_ADDRESS>'
I could apply the configuration fine, but I was wondering why it was not provisioned. I could see that error in securitypolicy status. Just thinking, should it be validated in creation of securitypolicy that ip address contains mask as well?

Good point. I added a regex validation for CIDR. It should prevent most invalidate input such as lacking mask, but still need a second check in gateway API translation for some corner cases.

Otherwise looks good, I have verified and looks like working like should. However, I am just thinking that we might need to split the filter to two different rbac filters? I am thinking like ip policies as first in order, and then others after authentication things like jwt (that we can use jwt information for authorization)?

I actually proposed the same during the API review. :-)
Most gateway implementations have a standalone IP Allow/Deny list. However, some, like the Istio Authorization API, integrate this feature into their Authorization API.
Incorporating the client IP range in the Authorization enables use cases that require a combination of the client IP and other conditions. For instance, " allows admin users access an HTTPRoute from use-west-region, but not from other regions", which is either impossible or significantly challenging  to implement with two independent filters.


"Compile Project" is failing

Description of the bug:

Which category does this issue belong to?
No response
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
No response
Which Intellij IDE are you using? Please provide the specific version.
No response
What programming languages and tools are you using? Please provide specific versions.
No response
What Bazel plugin version are you using?
No response
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
No response

Hi @dkashyn-sfdc, Could you please provide complete steps to reproduce this issue?

@dkashyn-sfdc already fixed it in #7135, thank you!


[Auth] [BackStage] Remove the ro_import permission

Remove the ro_import permission because only the POST method is used.

Change the all_import permission to accept only the POST method.

user group permissions:
{
    "permissions": [
        {
            "id": 19,
            "path": "/import/(.*)",
            "name": "ro_import",
            "method": "GET",
            "permission": "permit",
            "type": "system",
            "created_date": "2019-04-16T18:34:57.685966",
            "created_by": 0
        },
        {
            "id": 20,
            "path": "/import/(.*)",
            "name": "all_import",
            "method": "(.*)",
            "permission": "permit",
            "type": "system",
            "created_date": "2019-04-16T18:34:57.686428",
            "created_by": 0
        }
    ]
}

The Import permission only accepts the POST method.

POST:
{
    "message": "data imported!"
}

PUT:
<!DOCTYPE html>

        <meta charset="utf-8">
        <title>Error</title>

Cannot PUT /import

GET:
<!DOCTYPE html>

        <meta charset="utf-8">
        <title>Error</title>

Cannot GET /import

DELETE:
<!DOCTYPE html>

        <meta charset="utf-8">
        <title>Error</title>

Cannot DELETE /import

user group permissions:
{
    "permissions": [
        {
            "id": 16,
            "path": "/import/(.*)",
            "name": "all_import",
            "method": "(.*)",
            "permission": "permit",
            "type": "system",
            "created_date": "2019-05-02T11:27:48.241335",
            "created_by": 0
        }
    ]
}

But the Import permission is accepting all methods, and only the POST method is used:
POST:
{
    "message": "data imported!"
}

PUT:
<!DOCTYPE html>

        <meta charset="utf-8">
        <title>Error</title>

Cannot PUT /import

GET:
<!DOCTYPE html>

        <meta charset="utf-8">
        <title>Error</title>

Cannot GET /import

DELETE:
<!DOCTYPE html>

        <meta charset="utf-8">
        <title>Error</title>

Cannot DELETE /import

The import permission only accepts the POST method.
Should not this permission be write-only and method = POST?
Tested on Version: 62.3-20190603

Test OK.

user group permissions:
curl -X GET <IP_ADDRESS>:30001/auth/pap/group/ImportarDados/permissions -H "Authorization: Bearer ${JWT}"  -H 'Content-Type:application/json'

{
    "permissions": [
        {
            "id": 16,
            "path": "/import/(.*)",
            "name": "wo_import",
            "method": "POST",
            "permission": "permit",
            "type": "system",
            "created_date": "2020-06-04T13:17:10.283518",
            "created_by": 0
        }
    ]
}

import permissions:
 curl -X GET <IP_ADDRESS>:30001/auth/pap/permission?path=\/import -H "Authorization: Bearer ${JWT}"  -H 'Content-Type:application/json'

{
    "permissions": [
        {
            "id": 16,
            "path": "/import/(.*)",
            "name": "wo_import",
            "method": "POST",
            "permission": "permit",
            "type": "system",
            "created_date": "2020-06-04T13:17:10.283518",
            "created_by": 0
        }
    ]
}

POST:
{
  "message":"data imported!"
}

PUT:
<!DOCTYPE html>

<meta charset="utf-8">
<title>Error</title>

Cannot PUT /import

GET:
<!DOCTYPE html>

<meta charset="utf-8">
<title>Error</title>

Cannot GET /import

DELETE:
<!DOCTYPE html>

<meta charset="utf-8">
<title>Error</title>

Cannot DELETE /import

Tested in v0.5.0-alpha.1


Error: Invalid Path

Description
I clone the repository but I can't checkout, it gives me an invalid path error.
Environment
Windows 11
Steps To Reproduce

Expected behavior
The repository should clone without any problems
Actual Behavior
Git throws two erros when trying to restore:
error: invalid path 'rules/ensure-default-service-accounts-has-only-default-roles/test/failed_clusterrolebinding /expected.json'
error: invalid path 'rules/ensure-default-service-accounts-has-only-default-roles/test/failed_clusterrolebinding /input/clusterrolebinding.json'

Have you tried this?
https://stackoverflow.com/questions/63727594/github-git-checkout-returns-error-invalid-path-on-windows

Thank you, it seems to work now that I used that option and sparse-config.


Make ButtonMethodDrawer work in Prefab mode

Not sure if this is the best approach, but if we try to change a component's field value via [Button] attribute while in Prefab mode, the changes won't be flushed to disk. (Because we are not working with SerializedProperties or SerializedObject.)
This is the suggested method to trigger a flush to disk by Unity team, it is also what happens when you change a value by hand in Prefab mode: the scene is marked as dirty, then a save is done automatically.
https://issuetracker.unity3d.com/issues/changes-made-to-a-variable-of-a-script-are-not-saved-when-they-are-made-inside-the-prefab-mode-even-with-autosave-enabled

Merged into the v2 branch


Fixed wrong trigger for warning

Fixes #972
In trl/trainer/utils.py the code func.__code__.co_varnames is being used to check if the user passed a formatting_func with more than 1 parameter. This code actually counts the function variables rather than function parameters.
For instance
def add_v1(a):
  return a + 1

def add_v2(a):
  b = a + 1
  return b

print("Number of parameters for add_v1 is", len(add_v1.__code__.co_varnames))
print("Number of parameters for add_v2 is", len(add_v2.__code__.co_varnames))

outputs
Number of parameters for add_v1 is 1
Number of parameters for add_v2 is 2

The proposed fix is to change the following:
formatting_func_signature = formatting_func.__code__.co_varnames
if len(formatting_func_signature) > 1:
    warnings.warn(
        "The passed formatting_func has more than one argument. Usually that function should have a single argument `example`"
        " which corresponds to the dictionary returned by each element of the dataset. Make sure you know what you are doing."
    )

to:
if formatting_func.__code__.co_argcount > 1:
    warnings.warn(
        "The passed formatting_func has more than one argument. Usually that function should have a single argument `example`"
        " which corresponds to the dictionary returned by each element of the dataset. Make sure you know what you are doing."
    )

Tested on python Python 2.7.5 and Python 3.6.8

Great catch! Would you mind adding a test for this as well if you have time?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


modcheck -f phase 1: fix requires

Our modcheck tool looks at the go.mod files in the repository root and the apis/ directory, and fails if any entries in the latter exist in the former at a different version. Heretofore, such failures would have to be addressed by manually updating the apis/go.mod to sync those versions.
With this change, we add a -f flag which asks modcheck to fix discrepancies it encounters.
In this first phase, we add the ability for modcheck to fix require entries, as these are by far the most common discrepancies we encounter.
Further work is required to make the tool fix exclude and replace entries.
The tool will succeed (exit zero) if the files are in sync when it completes -- whether because they started that way, or because it fixed everything it encountered.
The tool will fail (exit nonzero) if it encounters a processing error; or if the files are out of sync when it completes -- even if partially fixed.
Put another way: barring errors, the exit code is the same as if modcheck were run again without -f.
HIVE-2624

/assign @dlom

/override "Red Hat Konflux / hive-operator-enterprise-contract / hive"

/override "Red Hat Konflux / hive-operator-enterprise-contract / hive"

/lgtm


add east det model (don't merge yet)

add east det model, where the best f-score is 84.95%, compared with modelzoo +3.99%, compared with paddleocr +0.05%.

Please also update Supported Algorithm Section in Readme.md and reamd_cn.md

I've already pushed the readme_cn.md, but it seems does not appear in this review page.
Please see:
https://github.com/mindspore-lab/mindocr/pull/264/commits/04bd76c4d1ea939149baa044577d3d130d9f33ac#diff-a2f5307adeaccc5310fc03f22dbe74a5222dfb2a1344e2c05c5b02c1004b792dR1

refer to: https://github.com/mindspore-lab/mindocr/pull/316


Youtube Live not working while normal youtube videos work fine

Hi,
I was just trying to get a youtube livestream like this one:
https://www.youtube.com/watch?v=sw4hmqVPe0E
But I always get :
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/watch?v=sw4hmqVPe0E
error: No streams found on this URL: https://www.youtube.com/watch?v=sw4hmqVPe0E
Any other Video e.g.:https://www.youtube.com/watch?v=K7zQGQlSdWU works fine.
I'm on
[cli][info] Your Livestreamer version (1.12.2) is up to date!

livestreamer "https://www.youtube.com/watch?v=sw4hmqVPe0E" best
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/watch?v=sw4hmqVPe0E
[cli][info] Available streams: 1080p (best), 240p, 360p, 480p, 720p, 72p (worst)
[cli][info] Opening stream: 1080p (hls)

Seems that you can't access the stream due to some geographic restrictions.

Doh !
I got 2 networks, one with an blocked ip and one with an working ip. I'm surfing using the working IP and streaming using the blocked ip :(
Thanks for your quick help


show current version

it's a common grievance for me to ensure what exact version of a library i am actually running, especially when loaded with optimistic version constraints from a cdn.
a really simple solution is to blend in a very small footer addition with the current version, or if this is too distracting, just as a comment in the html file.

The current version is printed out in the developer console.

@KaneFreeman Is it possible that it does not happen when using the CDN version (@staticcms/app)? At least for me the first message I get in the console is that mount event

I will look into that.

confirmed, i don't see this line in the dev console

This is fixed in v3.4.3. You can see it in action here: https://eleventy.staticcms.org/admin/

yep, works for me. thank you


testing updates to travic-ci build, not including index building

fixed travis-ci builds by removing index creation and tests.  will be addressed in later build.

Because CLAVIN constructs the entire GeoNames.org index during the build process, travis-ci kills the process before it finishes.  We'll want to support tests during build (possibly using a smaller gazetteer) in order to make travis-ci work for us.

I'm assuming this pull request can be closed, @ppiersonbt?


Can't build with the latest BoringSSL

There was a change to make DH structure opaque on BoringSSL, and the change broke our DH_get_2048_256 implementation.
  CXX      SSLUtils.o
SSLUtils.cc:533:5: error: member access into incomplete type 'DH' (aka 'dh_st')
  dh->p = BN_bin2bn(dh2048_p, sizeof(dh2048_p), nullptr);
    ^
/Users/mkitajo/opt/boringssl/include/openssl/base.h:402:16: note: forward declaration of 'dh_st'
typedef struct dh_st DH;
               ^
SSLUtils.cc:534:5: error: member access into incomplete type 'DH' (aka 'dh_st')
  dh->g = BN_bin2bn(dh2048_g, sizeof(dh2048_g), nullptr);
    ^
/Users/mkitajo/opt/boringssl/include/openssl/base.h:402:16: note: forward declaration of 'dh_st'
typedef struct dh_st DH;
               ^
SSLUtils.cc:535:10: error: member access into incomplete type 'DH' (aka 'dh_st')
  if ((dh->p == nullptr) || (dh->g == nullptr)) {
         ^
/Users/mkitajo/opt/boringssl/include/openssl/base.h:402:16: note: forward declaration of 'dh_st'
typedef struct dh_st DH;
               ^
SSLUtils.cc:535:32: error: member access into incomplete type 'DH' (aka 'dh_st')
  if ((dh->p == nullptr) || (dh->g == nullptr)) {
                               ^
/Users/mkitajo/opt/boringssl/include/openssl/base.h:402:16: note: forward declaration of 'dh_st'
typedef struct dh_st DH;
               ^
4 errors generated.

Fixed by #9546.


fontFamily in ThemeData doesn't work anymore in Flutter 1.12

MaterialApp(
  ...
  theme: ThemeData(
    fontFamily: 'my-font-family',
  )
  ...

This used to work before, after upgrading to Flutter 1.12 my custom font is not used anymore. I have to specify fontFamily in TextStyle for each of my widgets instead.
[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Mac OS X 10.14.5 18F132, locale en-GB)
    • Flutter version 1.12.13+hotfix.5 at /Users/tudor/dev/flutter
    • Framework revision 27321ebbad (32 hours ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/tudor/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /Users/tudor/Library/Android/sdk
    • Java binary at: /Users/tudor/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/191.5977832/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.0, Build version 11A420a
    • CocoaPods version 1.7.2

[✓] Android Studio (version 3.5)
    • Android Studio at /Users/tudor/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/191.5977832/Android
      Studio.app/Contents
    • Flutter plugin version 38.2.3
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] Connected device (1 available)
    • iPhone 11 Pro • 332C8E72-5F12-4719-B917-2A2687F7FB42 • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-0 (simulator)

• No issues found!

Hi @tudor07
I'm not calling it a solution,
but a possible workaroud is using the new package google_fonts
thank you

@iapicca It doesn't matter where the font comes from, also I use a paid font which is not available on Google Fonts.

Maybe this introduces issue: https://github.com/flutter/flutter/pull/42366

Hi again @tudor07
could you please run
flutter clean
flutter pub cache repair
let me know if the issue persists
thank you

@iapicca Already tried that, did not work.
Also tried removing ~/.pub-cache, removing pods... clean from Xcode/Android Studio

CC @darrenaustin

It's possible my change (https://github.com/flutter/flutter/pull/42366) broke this (my apologies if so). However, I can't reproduce the issue as you describe it. Here is a modified demo app that sets a default font family as well as a special case title style. To run it, you will need to have to have Mansalva (https://fonts.google.com/specimen/Mansalva) and Big Shoulders Display (https://fonts.google.com/specimen/Big+Shoulders+Display) setup as assets for the app (or replace the references with fonts that you do have).
import 'package:flutter/material.dart';

void main() => runApp(FontFamilyTest());

class FontFamilyTest extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        fontFamily: 'Mansalva',
        textTheme: TextTheme(
          title: TextStyle(fontFamily: 'Big Shoulders Display'),
        ),
      ),
      home: FontFamilyTestPage(title: 'Flutter Demo Home Page'),
    );
  }
}

class FontFamilyTestPage extends StatefulWidget {
  FontFamilyTestPage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _FontFamilyTestPageState createState() => _FontFamilyTestPageState();
}

class _FontFamilyTestPageState extends State<FontFamilyTestPage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(
              'You have pushed the button this many times:',
              style: Theme.of(context).textTheme.title,
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.display1,
            ),
            RaisedButton(
              child: const Text('Button'),
              onPressed: () {},
            )
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ),
    );
  }
}

Which yields:

Which shows Mansalva being used for everything except the 'You have pushed...' text which uses the title style which is using Big Shoulders Display.
Can you try this with your fonts and see if you see the same problem? Or can you give us a test case that we can use to repro it?  Thanks.

I'm experiencing an app crash when a custom font is used.
2019-12-13 15:01:24.329096+1100 Runner[40874:1750268] [VERBOSE-2:FontFamily.cpp(184)] Could not get cmap table size!
2019-12-13 15:01:24.329305+1100 Runner[40874:1750268] [VERBOSE-3:FontCollection.cpp(95)] nTypefaces == 0

Ran flutter clean and flutter pub cache repair. No change, although the repair screwed a couple of firebase plugins that I had to fix, but unrelated.
Will test with fresh project as per @darrenaustin suggestion above and report back.

@darrenaustin No need to apologize.
Your example works, and I also found a solution for my problem.
So I have a custom theme where I change multiple fields in the TextTheme:
ThemeData(
  canvasColor: Colors.white,
  scaffoldBackgroundColor: Colors.white,
  fontFamily: 'my-custom-font',
  textTheme: TextTheme(
    display1: const TextStyle(
      fontSize: 17,
    ),
    display2: const TextStyle(
      fontSize: 22,
    ),
    display3: const TextStyle(
      fontSize: 27,
    ),
    body1: Theme.of(context).textTheme.body1.merge(
          const TextStyle(
            color: kMyColor,
          ),
        ),
    body2: const TextStyle(
      fontSize: 17,
    ),
    button: const TextStyle(
      fontSize: 17,
      fontWeight: FontWeight.w600,
    ),
    overline: const TextStyle(
      fontSize: 10,
    ),
  ),
)

Before upgrading, this worked fine. After upgrading I need to add the fontFamily property to body1 also, like this:
    ...
    body1: Theme.of(context).textTheme.body1.merge(
          const TextStyle(
            color: kMyColor,
            fontFamily: 'my-custom-font',
          ),
        ),
    ...

And now it works everywhere in the app like before. Not sure if this change was intentional, for me it seems like a resonable solution, so if this was intentional you can close this issue. Would be nice to have this written somewhere in the documentation that body1's fontFamily overrited ThemeData's fontFamily IMHO.

Ah I see the problem then. It is a little subtle, but the issue is that for body1 in the example above it uses:
Theme.of(context).textTheme.body1.merge(...

In this case the context that is being referenced doesn't see the MaterialApp that is being defined here. Therefore Theme.of(context) will return the default Material theme data. In the default Material theme, all text styles have their family set to 'Roboto'. When you then take that and merge with your changes (the color set to kMyColor), the family of 'Roboto' will be set on the resulting style. Because this has been set it will not be overridden by the fontFamily in the ThemeData constructor. The other styles pick up the 'fontFamily' value because they didn't have one set on them.
The reason this worked before is the fontFamily parameter to the ThemeData constructor used to always override any font family settings on a given text style. This was the bug I was trying to fix with my change (see #34915). The fontFamilly should only be used as a default when none has been set on the style.
So the change was intentional, but breaking your use case was not. If I had realized this would be breaking, I definitely would have gone through our breaking change process. At this point as you have a reasonable solution to the problem, I am going to go ahead and close this out. Thanks for the report and following up with us.

Hello so we couldn't use Theme.of(context).fontFamily directly ?
I prefer to set the size directly and not using textTheme...

Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v'  please.
All system setups can be slightly different so it's always better to open new issues and reference related issues.

@yelkamel What's stopping you from settings size directly?

the output from flutter doctor -v below.
when i attempt to create a ThemeData instance, the fontFamily property is not available and I get a compile error.  screenshot from IntelliJ:

[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.3 19D76, locale en-US)
• Flutter version 1.12.13+hotfix.8 at /Users/steve/Documents/Dev/flutter
• Framework revision 0b8abb4724 (3 weeks ago), 2020-02-11 11:44:36 -0800
• Engine revision e1e6ced81d
• Dart version 2.7.0
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /Users/steve/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3.1, Build version 11C504
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 43.0.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] IntelliJ IDEA Community Edition (version 2019.3.3)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin version 44.0.3
• Dart plugin version 193.6494.35
[✓] VS Code (version 1.42.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.8.1
[✓] Connected device (2 available)
• Android SDK built for x86 • emulator-5554                        • android-x86 • Android 10 (API 29) (emulator)
• iPhone 11 Pro Max         • C56A840C-CCD4-4234-84C3-6EB9752C6597 • ios         • com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)
• No issues found!

@stevenyix Looks like fontFamily is not defined in copyWith method. Why do you use copyWith? Just create your theme:
MaterialApp(
    theme: ThemeData(
        ...
        fontFamily: 'MyFontFamily'
        ...
    )
)

@tudor07 i'll try that.  my understanding of using copyWith was to use it so i could inherit and overwrite existing ThemeData properties without having to define every single one of them again.

Any update on copyWith method?

fontFamily from ThemeData properties is not working for me either.
Any update ?
Flutter Doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, v1.17.5, on Microsoft Windows [Version 10.0.18363.959], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[√] Android Studio (version 3.6)
[√] VS Code (version 1.47.3)
[√] Connected device (1 available)
• No issues found!

Not sure, if this is the right approach, but I'm using it as below in my theme file.

It doesn't matter what I do (I even tried @parthi22 's suggestion), the font family simply does not apply to Text widgets throughout the app. I even filled in every text style property possible in the theme (including the Cupertino overrides) and it still didn't make a difference. In fact, I have a feeling my theme doesn't make much of a difference altogether. I suspect BuildContext issues but I did make sure that I'm not creating new contexts deeper in the app. I'm sure I'll figure this out one day. For now, the only thing that works is to set the fontFamily on individual Text widgets' textStyle properties.

This is still an issue in Flutter v1.22.0, fontFamily in ThemeData does not work globally

Any clue to set Font globally?

Tried on Flutter (Channel stable, 1.22.3,
I have just done some changes as follows:

Paste some fonts file in your assets folder for example Courgette-Regular.ttf:

Edit your pubspec.yaml: as below:
  # example:
  fonts:
    - family: myFontFamily
      fonts:
        - asset: fonts/Courgette-Regular.ttf

set fontFamily in ThemeData In your MaterialApp tag of main.dart:
return MaterialApp(
  title: 'Flutter Demo',
  debugShowCheckedModeBanner: false,
  theme: ThemeData(
    primarySwatch: Colors.blue,
    visualDensity: VisualDensity.adaptivePlatformDensity,
    fontFamily: 'myFontFamily', // JUST ADD FONT FAMILY HERE...
  ),
  home: MyHomePage(title: 'Flutter Demo Home Page'),
);

Thank you


Add geo extensions to PairtreeDerivativePath

Merges into geo_concerns branch.
Adds geo extensions to PairtreeDerivativePath. Closes #844 Closes #842

Coverage remained the same at 100.0% when pulling 9f6fd7e467e6ee7c61ce1c7b0200bab4d9094010 on 844-derivative-path into 08611d68a98a757e042c58ecd2ec83d70f81de38 on geo_concerns.

Coverage remained the same at 100.0% when pulling cc7342a61ffcabd0474ae38e8223e44eb7add1e1 on 844-derivative-path into b2cba13e87bbd074ac07594ebce4c9926e4f911b on geo_concerns.


Base href not set in SPA mode

Version
v2.12.0
Reproduction link
https://codesandbox.io/s/spa-base-href-2761c
Steps to reproduce

Click the link to the subpage /foo/bar.

What is expected ?
The page should have <base href="/"> in <head> and the image should load correctly on both pages.
What is actually happening?
There's no <base> tag and the image on /foo/bar is not loaded.
Additional comments?
The base tag is only added if the mode is set to universal.

This bug report is available on Nuxt community (#c10443)

Hi @arildm !
I saw on the code that <base href=""> meta is only available into ssr mode but not in SPA.
So the base attribute isn't insert into <head> section.
It's not indicate into the official documentation (https://fr.nuxtjs.org/api/configuration-router#base).
I will purpose a PR :)

PR has been accepted and it will be available on next release 😉


Remove resourced-based policy permissions in source API delete operations

Codecov Report

Merging #271 into master will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   85.82%   86.06%   +0.24%
==========================================
  Files          16       16
  Lines         395      402       +7
  Branches       48       48
==========================================
+ Hits          339      346       +7
  Misses         56       56

Impacted Files
Coverage Δ

...ion/curator-service/api/src/controllers/sources.ts
88.60% <ø> (-0.29%)
:arrow_down:

...rator-service/api/src/clients/aws-events-client.ts
100.00% <100.00%> (ø)

...rator-service/api/src/clients/aws-lambda-client.ts
100.00% <100.00%> (ø)

verification/curator-service/api/src/index.ts
83.75% <100.00%> (ø)

...rification/curator-service/api/src/model/source.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fdf9b2...0e53856. Read the comment docs.

Based on #270 -- diff here is from the 3rd commit onwards.

I discovered that you can do diffbases in github by changing which branch it would merge into; once that parent PR is merged into master and the branch is deleted, it will switch to master here too

Based on #270 -- diff here is from the 3rd commit onwards.

I discovered that you can do diffbases in github by changing which branch it would merge into; once that parent PR is merged into master and the branch is deleted, it will switch to master here too

Awesome, thanks.

 Integrate deployed Lambda functions with staging environment services


I have some problem about demo.py?

INFO:tensorflow:Scale of 0 disables regularizer.
INFO:tensorflow:Scale of 0 disables regularizer.
INFO:tensorflow:Scale of 0 disables regularizer.
INFO:tensorflow:Scale of 0 disables regularizer.
INFO:root:Number of classes is 94
INFO:root:UNK label is 2
INFO:tensorflow:Scale of 0 disables regularizer.
INFO:root:Number of classes is 94
INFO:root:UNK label is 2
WARNING:tensorflow:From /home/lz/PycharmProjects/aster/core/spatial_transformer.py:111: calling norm (from tensorflow.python.ops.linalg_ops) with keep_dims is deprecated and will be removed in a future version.
Instructions for updating:
keep_dims is deprecated, use keepdims instead
INFO:tensorflow:Scale of 0 disables regularizer.
INFO:tensorflow:Scale of 0 disables regularizer.
INFO:tensorflow:Scale of 0 disables regularizer.
INFO:tensorflow:Scale of 0 disables regularizer.
Traceback (most recent call last):
File "demo.py", line 92, in
tf.app.run()
File "/home/lz/.conda/envs/tf/lib/python3.6/site-packages/tensorflow/python/platform/app.py", line 125, in run
_sys.exit(main(argv))
File "demo.py", line 55, in main
predictions_dict = model.predict(tf.expand_dims(resized_image_tensor, 0))
File "/home/lz/PycharmProjects/aster/meta_architectures/multi_predictors_recognition_model.py", line 51, in predict
predictor_outputs = predictor.predict(feature_maps, scope='{}/Predictor'.format(name))
File "/home/lz/PycharmProjects/aster/predictors/attention_predictor.py", line 74, in predict
maximum_iterations=self._max_num_steps
File "/home/lz/.conda/envs/tf/lib/python3.6/site-packages/tensorflow/contrib/seq2seq/python/ops/decoder.py", line 322, in dynamic_decode
swap_memory=swap_memory)
File "/home/lz/.conda/envs/tf/lib/python3.6/site-packages/tensorflow/python/ops/control_flow_ops.py", line 3291, in while_loop
return_same_structure)
File "/home/lz/.conda/envs/tf/lib/python3.6/site-packages/tensorflow/python/ops/control_flow_ops.py", line 3004, in BuildLoop
pred, body, original_loop_vars, loop_vars, shape_invariants)
File "/home/lz/.conda/envs/tf/lib/python3.6/site-packages/tensorflow/python/ops/control_flow_ops.py", line 2939, in _BuildLoop
body_result = body(*packed_vars_for_body)
File "/home/lz/.conda/envs/tf/lib/python3.6/site-packages/tensorflow/python/ops/control_flow_ops.py", line 3260, in
body = lambda i, lv: (i + 1, orig_body(*lv))
File "/home/lz/.conda/envs/tf/lib/python3.6/site-packages/tensorflow/contrib/seq2seq/python/ops/decoder.py", line 265, in body
decoder_finished) = decoder.step(time, inputs, state)
File "/home/lz/.conda/envs/tf/lib/python3.6/site-packages/tensorflow/contrib/seq2seq/python/ops/beam_search_decoder.py", line 657, in step
cell_outputs, next_cell_state = self._cell(inputs, cell_state)
File "/home/lz/.conda/envs/tf/lib/python3.6/site-packages/tensorflow/python/ops/rnn_cell_impl.py", line 233, in call
return super(RNNCell, self).call(inputs, state)
File "/home/lz/.conda/envs/tf/lib/python3.6/site-packages/tensorflow/python/layers/base.py", line 374, in call
outputs = super(Layer, self).call(inputs, *args, **kwargs)
File "/home/lz/.conda/envs/tf/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 757, in call
outputs = self.call(inputs, *args, **kwargs)
File "/home/lz/PycharmProjects/aster/core/sync_attention_wrapper.py", line 54, in call
self._attention_layers[i] if self._attention_layers else None)
ValueError: too many values to unpack (expected 2)

之前有人回答了这个问题，主要是因为tf版本问题引起的，引用一下之前的回答：
ValueError: too many values to unpack (expected 2)
这个问题，在core/sync_attention_wrapper.py里面，attention, alignments, attention_state = _compute_attention，这个返回了三个值，所以添加了这个attention_state，并且在下面next_state = seq2seq.AttentionWrapperState这个里面，缺了一项，缺了attention_state这个参数，我直接将上面返回的attention_state给了这个输入，现在demo可以跑了
@bgshih 不知道这样是不是正确的

之前有人回答了这个问题，主要是因为tf版本问题引起的，引用一下之前的回答：
ValueError: too many values to unpack (expected 2)
这个问题，在core/sync_attention_wrapper.py里面，attention, alignments, attention_state = _compute_attention，这个返回了三个值，所以添加了这个attention_state，并且在下面next_state = seq2seq.AttentionWrapperState这个里面，缺了一项，缺了attention_state这个参数，直接将上面返回的attention_state给了这个输入

Thanks


Record individual packages in bulk find(1) operation

Currently, if any packages have changed, we discard the results of our bulk find(1) operation (from straight--cached-packages-might-be-modified-p) and check each package individually. This is slower. It would be preferable to stick the results in a hash table so that we can skip checking all cached packages, even if some are modified.

Fixed in the referenced commit.


chore: refactor perfect rings / fields

The main changes are:

we replace the data-bearing PerfectRing typeclass with a Prop-valued (non-constructive) version,
we introduce a new typeclass PerfectField,
we add a proof that a perfect field of positive characteristic has surjective Frobenius map,
we add some basic facts such as perfection of finite rings / fields and products of perfect rings.

Would you like to add the equivalent definition that a field is perfect if and only if every (finite) algebraic extension is surjective?

Would you like to add the equivalent definition that a field is perfect if and only if every (finite) algebraic extension is surjective?

I don't plan to do this, but I encourage you to do it in a follow-up PR if you're interested!

we replace the data-bearing PerfectRing typeclass with a Prop-valued (non-constructive) version,

What do we gain by removing the data here? Is the problem that the class would not be subsingleton?

I'd claim this isn't really true; the actual statement then becomes that the classical.some to get nthRoot is unique (which of course is also true), but is more work to state not less!
Yes, this is really the same question, which I realize is controversial and subjective
That can be resolved with an ofBijective constructor: we have the same thing for IsInternal and Decomposition on direct sums, though maybe there is a stronger answer for 2) there (computably decompositions are common, I don't know about pthRoots).
This was the answer I was looking for, but I was hoping we had evidence that the problem was more than speculative!

Thanks for these thoughtful responses.
With regard to 4, to make it a bit less speculative, I just added an instance proving that the product R × S of two perfect rings is perfect. I claim this is exactly the sort of instance that would be problematic with a data-bearing instance as there might be a diamond of solutions (e.g., if R and S are both finite).

bors merge


Support to access the server property

oh wait .. I dunno why it removed the port number.

I'll try again.


tautulli: 2.1.33 -> 2.1.34

Motivation for this change
Update to latest version
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @csingley

Superseeded by https://github.com/NixOS/nixpkgs/pull/71914


Ignore warning about unused value

And run dune build @fmt

Must be removed later, see https://github.com/MinaProtocol/mina/issues/13914.


don't change the name of the test suite

Maybe I'm getting this all wrong but generating a different name for each run of the test suit means there is no proper history on the tests if you compare it with how the phpunit adapter works. But could bet his is needed for some reason?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Steam Deck Sprite issue

So there are 2 issues I've encountered with the app on the deck and wanted to see if there are known fixes.
1 - is simple since the latest update and download, it doesn't work on the deck in gaming mode, just desktop mode (I've swapped to a browser version for now but I do miss the app)
2 - this one is more interesting, when playing on the deck via app or website some of the sprites are wrong.
The example I have included below is the most obvious, mega Mawile fused with Cloyster. The image on the left is my phone version of this fusion with the colour palette enabled, the right is the steam deck version looking like a GBC game instead. Doesn't matter if this is on app or on Web browser, always does the same thing. Unsure why but it is weird. If I turn off the palette I get the proper sprite but shame to lose the colours.
Any ideas for both issues?

Fixed the deck issue, I forgot to add the command line no sandbox, just gonna accept the weird sprites haha


llvmPackages_11.compiler-rt: fix build on darwin

Needed to prevent faulty i686 codegen on x86_64. We're doing this
already for the older llvm packages, so not sure why 11 never had this.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 111701 run on x86_64-darwin 1

2 packages marked as broken and skipped:

puppeteer-cli
zig

2 packages built:

clang-analyzer
clang_11