Update github icon color on main page

Description
On the site, in instances "Contribute on  v0.62.3" the  is purple, while that looks good, the original github icon is black, so it is better if it's black right?
Screenshots
No response
Additional information
Will see if I can work on this, but I'm not sure so if someone else wants to take this up, please go ahead. Thanks

@BSlaven You only fixed this in one instance of the website, please do it in the other too
@emmalearnscode Please re-open this issue, I cannot reopen the issue, as you a mod of EddieHubCommunity closed it so GitHub doesn't let me.
Thanks, KendallDoesCoding

Information on the other instance:
@BSlaven You've not it in the footer in #1081 but not on the top.
Screenshot:

Please do the needful because the github icon is black not purple 😆 .
Thanks a lot!
Kendall Does Coding

@KendallDoesCoding maybe you could have been more specific when you opened the issue. Please don’t ping BSlaven telling them to do more in case they don’t have time, anyone is able to help resolve the issue.

@KendallDoesCoding maybe you could have been more specific when you opened the issue. Please don’t ping BSlaven telling them to do more in case they don’t have time, anyone is able to help resolve the issue.

Sorry about that, I meant in both locations/instances. Sorry for pinging BSlaven too.

No problem @KendallDoesCoding. I am on it.

No problem @KendallDoesCoding. I am on it.

Thanks, Sorry for the inconvenience.


Update dependencies

Codecov Report

Merging #124 (4ec01da) into main (f0c5c8b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           12        12
  Lines          406       406
=========================================
  Hits           406       406

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c5c8b...4ec01da. Read the comment docs.


Automatic role rewards

Server custom or completely automatic?

should 100% be server-custom

should 100% be server-custom

Issue is how would they be configured?


Issue on gptj quantized repo

Hi there, sorry if i Write here but i didnt know how to contact you since i open this issue:
https://github.com/IST-DASLab/gptq/issues/17
about your repo:
https://github.com/AlpinDale/gptq-gptj
cause i couldnt address this issue in your repo.
can you help me solve the issue or make possible to open issue on your gptq repo?
thank you very much!

Hi. I'd recommend opening this issue in the corresponding repository.

hi, this is what i wanted to do at first but there is no issue section in your repo (i did some research and apparently you have to specifically enable the issue section when you fork a repo otherwise it will not be present)

i look forward to continue the conversation in the proper repo when you will enable it!
thank you!

I've activated issues for the repo. Thanks for pointing that out.
On Tue, 11 Apr 2023, 21:54 imthebilliejoe, @.***> wrote:

Hi. I'd recommend opening this issue in the corresponding repository
https://github.com/AlpinDale/gptq-gptj.
hi, this is what i wanted to do at first but there is no issue section in
your repo (i did some research and apparently you have to specifically
enable the issue section when you fork a repo otherwise it will not be
present)
[image: C490D969-0B59-421C-B476-4B863ED38EF9]
https://user-images.githubusercontent.com/80759886/231241039-fdb744ce-3a54-4d2d-9a54-9392f1ae4e26.jpeg
i look forward to continue the conversation in the proper repo when you
will enable it!
thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/AlpinDale/pygmalion.cpp/issues/7#issuecomment-1503808979,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMNKRKU6UZWKAWN34O2D4TTXAWHVTANCNFSM6AAAAAAW2FOPPA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Upload/Download File

Sorry if wrong place I am new to github/programming
Is it possible to upload, like say nightmare-upload?
great library,thanks

Hi @dejay12,
Currently chromy does not support method of uploading file easily.
But it might be able to implemented.
I'll implement it in the near future.
If you want to implement soon, below issue maybe helps you.
https://github.com/cyrus-and/chrome-remote-interface/issues/164
Chromy wrapped chrome-remote-interface and you can access it like this:
const Chromy = new Chromy()
const client = chromy.client
const {DOM, Runtime} = client

Hi @dejay12,
I've just added setFile() command to Chromy.
This command sets file or files to file control.
This is what you want right?
Here is example:
const Chromy = require('../src')
const path = require('path')

let chromy = new Chromy({visible: true})
chromy.chain()
      .goto('http://localhost/'))
      .setFile('input[type="file"]', __filename)
      .click('button.submit')
      .sleep(3000)
      .end()
      .catch(e => {
        console.log(e)
      })
      .then(_ => chromy.close())

Wow, thank you very very much for this


Verify command issue when executing command with a for /F statement

There is a subtle bug in the windows command processor with regard to the verify command. You will receive two different results when executing the command in a batch script vs. executing the command with a for /F statement in a batch script. The following batch script demonstrates the issue:
@setlocal
  @prompt $N:$G$S
  verify
  for /F "usebackq tokens=3 delims=. " %%a in (` verify `) do echo verify=%%a=
  @prompt
@endlocal
@goto :EOF

which produces:
U:> verify
VERIFY is on.

U:> for /F "usebackq tokens=3 delims=. " %a in (` verify `) do echo verify=%a=

U:> echo verify=off=
verify=off=

Note that verify is on when the above batch script is run, but when trying to determine the state of verify with the for /F statement it says it's off. I suspect that this may be a result of the for /F statement executing the result in a different command processor where the default for verify is off. However, this seems to be an oddity with executing the verify command. When you do this for the echo command with the following similar batch script there are no issues:
@setlocal
  @prompt $N:$G$S
  echo
  for /F "usebackq tokens=3 delims=. " %%a in (` echo `) do echo echo=%%a=
  @prompt
@endlocal
@goto :EOF

which correctly produces:
U:> echo
ECHO is on.

U:> for /F "usebackq tokens=3 delims=. " %a in (` echo `) do echo echo=%a=

U:> echo echo=on=
echo=on=

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 09f8b51a-8984-72d4-c041-9eb8320fef7b
Version Independent ID: d18467dc-98bd-4fd4-ceca-6693d755d14a
Content: verify
Content Source: WindowsServerDocs/administration/windows-commands/verify.md
Product: windows-server
Technology: windows-commands
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

Note, this is also a problem with the echo command. I didn't formulate the test conditions appropriately in my original post of the verify issue. The following script modification shows the issue with the echo command too:
@setlocal
  @prompt $N:$G$S
  echo off
  for /F "usebackq tokens=3 delims=. " %%a in (` echo `) do echo echo=%%a=
  @prompt
@endlocal
@goto :EOF

My initial post comments about the echo command were incorrect and test scenario was incorrect because the default for the echo command is on, thus when it is executed in the for /F statement it "appears" to match. However, the altered test scenario for the echo command first changes echo to be off before executing the for /F statement and it also shows two different results:
U:> echo off
echo=on=

#assign:xelu86

Hey @houghtonap,
Thanks again for contacting Microsoft. We value your feedback.
This is a lot of testing you've gone through with this, commendable! As this is a short reference on the use of the verify command, we aren't able to discuss all the outputs produced in batch script making. GitHub isn't quite the right location if searching for technical support, feature requests, or the information you kindly provided as it is completely outside our scope to provide any insight. If there are any issues within the content itself, please let us know.
This information is beneficial and maybe a community expert can better assist as to why you are receiving this output with your scripts. Please open a ticket with Microsoft Support to see if this has been brought up before with any potential solutions.
Illfated already provided our other tech support forums in the post above. As we're unable to action this due to its scope, we will now be closing this thread.
Thank you and we do wish you a most pleasant day!
#please-close


Fix the case where there is several level of certificates between the…

… proxy and the root ca
Fix #47

Hi @Pansanel , could you please send this PR to the master branch of the repo?

@Pansanel I merged the changes manually into the master branch. I will do a backport and make a new release during this morning. Thank you for the patch.


document is not up to date with authentication options

Quoting from the page:
When the bcp utility is connecting to SQL Database or Azure Synapse Analytics, using Windows authentication or Azure Active Directory authentication is not supported. Use the -U and -P options.
This is no longer true, the latest version of bcp allows connection to the cloud based services without using the -U and -P options.
We can connect just fine using these flags only:  -G -q -c
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 86bd520a-7468-fd55-c357-b0f645a917ef
Version Independent ID: 3dc9dee5-afcb-8287-4441-e84ff717186a
Content: bcp Utility - SQL Server
Content Source: docs/tools/bcp-utility.md
Service: sql
Sub-service: tools-other
GitHub Login: @markingmyname
Microsoft Alias: maghan

@mc-mc -- Michael, thank you for your clear feedback.
@markingmyname -- Mark, please look into this issue.

I believe this issue has been resolved, as the article was recently updated.


[GEP-26] Support for GCP credentials configuration

What this PR does / why we need it:
This PR enables support for credentials configuration different from a file containing service account info. This enables support for workload identity federation.
Work in progress
/hold
Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/9586
Special notes for your reviewer:
Release note:

MCM can now retrieve the project ID from a "projectID" data key, allowing support for credential configurations that do not directly contain the project ID. One such case is a [workload identity credential configuration](https://cloud.google.com/iam/docs/workload-download-cred-and-grant-access).

/area security ipcei
/kind enhancement
/label ipcei/workload-identity

/unhold
/ready

/assign

/assign

/lgtm

Thanks for reviewing @rishabh-11 !

Can you please add a unit test for the successful creation of a machine using credentialsConfig and modify the file mockclient.go present in the fake package?

Done with https://github.com/gardener/machine-controller-manager-provider-gcp/pull/130/commits/7a52e304c660beea34913aa4ff85dd0a745cee9b. PTAL

I addressed the feedback and also removed some unused variables. I left the " escaping because the whole file follows that convention. @vpnachev PTAL


Which font are you using in the preview picture?

The preview picture
Preview
Thx

It looks like Operator. The keywords "function", "class" and "constructor" are using the Italic style of that font.


Update README.md

Add some question link that be posted in SO .

Awesome~ :100:
Thx for your contributions.


Switch the value of the isFront variable at the end of the animation instead of in the toggleCard method

The value switcher in the toggleCard method
setState(() {       isFront = !isFront;     });
should instead be placed where the animation is completed or dismissed. Indeed, when the toggle animation is triggered, the isFront boolean value changes even if the animation is not finished and it could be problematic for code relying on that variable.

yes, I had to study, you need to check whether the animation is completed, and then only turn the card over manually so that isfront is correct

@kpk-i710 Could you please help me out solving this issue, I don't quite seem to understand what you or the original creator of this issue mean by should instead be placed where the animation is completed or dismissed. Could you please write the issue in a format of: EXPECTED BEHAVIOUR:
ACTUAL BEHAVIOUR:
Thanks!
it’s hard to describe it until you try it. You just need to click on the card twice in a row and look in the conflip.state.isFront variable will not have the correct value.
Therefore, to solve this, I used when clicking on the card
if (! conflip.controller.isAnimating) {
conflip.toggleCard ();

}
since I cannot change the value of conflip.state.isFront before the animation ends, otherwise the data will be incorrect

@kpk-i710 Could you please help me out solving this issue, I don't quite seem to understand what you or the original creator of this issue mean by should instead be placed where the animation is completed or dismissed. Could you please write the issue in a format of: EXPECTED BEHAVIOUR:
ACTUAL BEHAVIOUR:
Thanks!

it’s hard to describe it until you try it. You just need to click on the card twice in a row and look in the conflip.state.isFront variable will not have the correct value.
Therefore, to solve this, I used when clicking on the card
if (! conflip.controller.isAnimating) {
conflip.toggleCard ();
}
since I cannot change the value of conflip.state.isFront before the animation ends, otherwise the data will be incorrect

@kpk-i710 This behavior should now be changed in the next update that I will release shortly, please let me know if this issue is somehow still persistent after updating to the 0.6.0 version. Thank you for the bug report!


Remove warning about unit tests not running

The referenced PR has been merged

@Zageron : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Evaluate using middleware stack with closures

We can use Koa like stack instead of manual return breaks in middleware function: mid(conn, &m, mid(conn, &m, conn(....))), although this would result in a stack trace that shows all inner next(...) calls which is not ideal.
Alternative approach is to use closures mid(conn, &m) fn(conn, &m) and returned functions can be executed after all middleware stack is done:
func(conn *neptulon.Conn, msg *Message) (result interface{}, err *ResError, fn ...) {
  a := 1
  return nil, nil, func (...) {
    return a, nil, nil
  }
}

For instance, go-martini#logger is using nested Next() stack which is not what we want (unless we can find a way to manually manipulate stack trace not to have nested levels of next() calling next() inside next()).

I've actually realized that go-martini/koa way could work. We never get stack for returned error types anyway and if there is a panic, it will be right form the handler function and we'll see all the other handlers that lead up to that point which might even be good.

Done. Now using Next() error


While trying to download symbols in BC 16 with Al language v5.0

Processing of message 'al/downloadSymbols' failed with error: 'Object reference not set to an instance of an object.'
Details:
System.NullReferenceException: Object reference not set to an instance of an object.
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.DownloadSymbolsRequestHandler.ProcessRequestAsync(DownloadSymbolsRequest request, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\DownloadSymbolsRequestHandler.cs:line 45
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.NavServerRequestHandler1.HandleAsync(T request, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\NavServerRequestHandler.cs:line 38    at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.RequestHandlerBase1.HandleAsync(JToken requestContents, Int32 requestId, CancellationToken cancellationToken) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\RequestHandlerBase.cs:line 54
at Microsoft.Dynamics.Nav.EditorServices.Protocol.RequestRegistry.Process(Message message) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Endpoints\RequestRegistry.cs:line 80
launch Json provided
{
"version": "0.2.0",
"configurations": [
{
"type": "al",
"request": "launch",
"name": "Your own server",
"server": "http://localhost",
"serverInstance": "BC160",
"authentication": "UserPassword",
"startupObjectId": 22,
"startupObjectType": "Page",
"breakOnError": true,
"launchBrowser": true,
"enableLongRunningSqlStatements": true,
"enableSqlInformationDebugger": true
}
]
}
Al language Version: Version 5.0.465995
Version: US Business Central 16.0 (Platform 16.0.11233.31159 + Application 16.0.11240.31204)

Hi, can you try to use a newer version of the AL language extension and letting us know if it still reproduces?


pyproj is required for coastline, but doesn't say in error message

~/anaconda3/envs/py3/lib/python3.8/site-packages/hvplot/util.py in process_crs(crs)
    182         import pyproj
    183     except:
--> 184         raise ImportError('Geographic projection support requires GeoViews and cartopy.')
    185
    186     if crs is None:

ImportError: Geographic projection support requires GeoViews and cartopy.

Only specifies GeoViews and cartopy, but not pyproj.

Isn't pyproj already a dependency of cartopy? At least in conda, pyproj automatically gets installed with cartopy (see output of conda create --dry-run -n d cartopy). And since cartopy is a direct dependency of geoviews, seems like this message can simply say that projection support requires GeoViews.


Ensure metrics are enabled on OVMS

Ensures that --metrics_enable is always passed to OVMS

Does it still valid?


Google and Microsoft providers do not work with verifier passed

Hello and thanks for this package!
I am not sure if it is a setup issue but the Google and MicrosoftEntraId providers both error out if a verifier is passed. If the verifier is removed (i.e. passed as undefined) they work with no issue. I have confirmed the verification code is the same between the URL and the validate methods.
Both of them have it as a required parameter for the createAuthorizationURL and validateAuthorizationCode methods.
Any suggestions as to why this is are appreciated!
Sample code
// generate code verification
const verifier = generateCodeVerifier();

// ..

// generate url
const url = await google.createAuthorizationURL(payload.state, payload.verified, {
    scopes: ['profile', 'email'],
});

// ..

// validate auth code, errors here
const { accessToken } = await google.validateAuthorizationCode(payload.code, payload.verifier);

Example error response from Google if verifier is passed
OAuth2RequestError: invalid_grant
    at OAuth2Client.sendTokenRequest ([REDACTED]/node_modules/.pnpm/oslo@1.2.0/node_modules/oslo/dist/oauth2/index.js:99:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async OAuth2Client.validateAuthorizationCode ([REDACTED]/node_modules/.pnpm/oslo@1.2.0/node_modules/oslo/dist/oauth2/index.js:59:16)
    at async Google.validateAuthorizationCode ([REDACTED]/node_modules/.pnpm/arctic@1.8.1/node_modules/arctic/dist/providers/google.js:23:24)
    at [REDACTED]
    at [REDACTED] {
  request: Request {
    method: 'POST',
    url: 'https://oauth2.googleapis.com/token',
    headers: Headers {
      accept: 'application/json',
      'content-type': 'application/x-www-form-urlencoded',
      'user-agent': 'oslo'
    },
    destination: '',
    referrer: 'about:client',
    referrerPolicy: '',
    mode: 'cors',
    credentials: 'same-origin',
    cache: 'default',
    redirect: 'follow',
    integrity: '',
    keepalive: false,
    isReloadNavigation: false,
    isHistoryNavigation: false,
    signal: AbortSignal { aborted: false }
  },
  description: 'code_verifier or verifier is not needed.'
}

What's payload.verified and payload.verifier?

They are verifier value just in different places of the code

Strangely enough it is now working for me. Closing for now,, will re-open if I can reproduce it again with a minimal example.


New version: GeostatInversion v0.4.0

Registering package: GeostatInversion
Repository: https://github.com/madsjulia/GeostatInversion.jl
Created by: @montyvesselinov
Version: v0.4.0
Commit: 9cc02c459217073bede2d385dc87bf4ca36b892d
Git reference: master
Release notes:

version

Your new version pull request met all of the guidelines for automatic merging.
I will automatically merge this pull request during the next cron job.
If you want to prevent this pull request from being auto-merged, simply leave a comment.
(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)

On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.
Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)
If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.

[noblock]


[Question]Slack link is not active

What happened:
Slack link is not active
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

OpenYurt version:
Kubernetes version (use kubectl version):
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

@zc2638 Thank you for filing issue. I'm going to update the slack info.

I can not sign in, please  check the settings.
thanks.

@rambohe-ch


[SPARK-37026][ML] Ensure the element type of ResolvedRFormula.terms is scala.Seq for Scala 2.13

What changes were proposed in this pull request?

This PR fixes the issue that scala.Seq[scala.collection.mutable.ArraySeq$ofRef] will be passed to ResolvedRFormula.terms though it expects scala.Seq[scala.Seq[String]] with Scala 2.13.
As of Scala 2.13, scala.Seq is scala.collection.immutable.Seq, so this issue happens.
Why are the changes needed?

Bug fix.
Due to this issue, ResolvedRFormula.toString throws ClassCastException.
java.lang.ClassCastException: scala.collection.mutable.ArraySeq$ofRef cannot be cast to scala.collection.immutable.Seq
        at scala.collection.immutable.List.map(List.scala:246)
        at scala.collection.immutable.List.map(List.scala:79)
        at org.apache.spark.ml.feature.ResolvedRFormula.toString(RFormulaParser.scala:143)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)
        at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:357)
        at py4j.Gateway.invoke(Gateway.java:282)
        at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
        at py4j.commands.CallCommand.execute(CallCommand.java:79)
        at py4j.ClientServerConnection.waitForCommands(ClientServerConnection.java:182)
        at py4j.ClientServerConnection.run(ClientServerConnection.java:106)
        at java.lang.Thread.run(Thread.java:748)

Does this PR introduce any user-facing change?

No.
How was this patch tested?

New test is added and build/sbt -Pscala-2.13 "testOnly org.apache.spark.ml.feature.RFormulaSuite" passes.
CIs should ensure that this change works with Scala 2.12 too.

Test build #144327 has started for PR 34301 at commit 76e499e.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48806/

Test build #144327 has finished for PR 34301 at commit 76e499e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144327/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48806/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48806/


feat: Add support for preserve_client_ip tg flag

Description
Add support for preserve_client_ip option supported in aws_lb_target_group
Motivation and Context
Fixes issue https://github.com/terraform-aws-modules/terraform-aws-alb/issues/207
Breaking Changes
Should not break anything
How Has This Been Tested?

[x] I have tested and validated these changes using one or more of the provided examples/* projects

v6.3.0 has been just released.


Apply patch Background isn't drawn when using a single char

Kudos to Marc Palmans.
Background isn't drawn when using a single char

See title.

Example:
before patch

after patch

#3

Thanks. Fixed the conflicts and rebased as aa875fa4557fa9c0f11f8df447291ef1959837b4.


undefined behaviour in integer_storage and double_storage

After reading your blog post about sajson optimizations (it was a really interesting read) I started browsing the code. I noticed type-punning through a union:
    union integer_storage {
        enum {
            word_length = 1
        };

        static void store(size_t* location, int value) {
            integer_storage is;
            is.i = value;
            *location = is.u;
        }

        int i;
        size_t u;
    };

From what I know from reading discussions on SO this is an undefined behavior in C++ (although a common practice). Just to let you know.
(it's not a big deal; I think I'll start using this library soon anyway)

Wow, it seems you're right.  For some reason I thought this was made okay in C++11.
I believe I've read MSVC has said they will continue to support type punning through unions in VC++.
Also, Owen Shepherd here says it's implementation-defined (and okay), not UB...  but is he talking about C or C++ there?
I played around with godbolt and found in-use compilers that don't do the constant-sized memcpy load and store optimization, even though on newer compilers it generates even better code than the union implementation...  I'm a bit nervous about changing it, even though it shouldn't matter that much.  What do you think?

yes, I suppose it's safe to leave it as is

Went ahead and fixed it anyway :) https://github.com/chadaustin/sajson/commit/fd7ad76cbaa131ad77a0c08deb3eec06695daa03

Great!
My warning options may be too pedantic :-)
../third_party/sajson.h:316:6: warning: extra ‘;’ [-Wpedantic]
     };
      ^
../third_party/sajson.h:335:6: warning: extra ‘;’ [-Wpedantic]
     };

:) https://github.com/chadaustin/sajson/commit/124950ba4c82f5d42461e7acfbff0eecd44ad3ba


refinerycms-settings should not be part of the core package

If people want to use refinerycms-settings they should gem dependency it.

I'm currently extracting settings and was wondering about couple of things:

Should settings even have ui? For example blog and inquiries engines have settings stuff in their own tabs.
What would be best approach to install settings migrations? Let's take blog engine as an example. We could add

rake("refinery_settings:install:migrations")

right under https://github.com/resolve/refinerycms-blog/blob/rails-3-1/lib/generators/refinery/blog/blog_generator.rb#L11. Thoughts?

Leave the UI intact.
I guess that the readme for refinerycms-settings would need to
describe how to set it up as a dependency, like you said seems fine.

Forgot to mention I made this repository:
https://github.com/parndt/refinerycms-settings
You've got push @ugisozols

Settings UI is very useful for customer custom settings - they will have an ability to change it.

Extracted.

Awesome @ugisozols thanks!


dependency-updates

@cbardini I made a commit to this since it's still in PR, and the change I wanted to make would fix the pipelines tests for this PR. I'm not sure why it's failing for EDS though


add cross_build_mingw task

https://github.com/aminya/setup-cpp/pull/103

I would like to add CPM from ModernCppStarter for downloading project_options.
That would also open some future features like Format.cmake


code release question

👋 awesome research,I am very interested in your research. Can you open up all the code when you are free?

Yes, I'll set up the rest of the code with a reproduction environment and add to the repo when I get a chance.

That's great! Thank you very much~

Awsome work! I am also looking forward to the open source code.


Search option

Btw, YouTube supports shortened links in form of https://youtu.be/{‘id’}

without title = video[‘title’] it does not work, returns exception, u can test


Test coverage

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.51%. Comparing base (d3249cd) to head (d3c2718).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   53.70%   61.51%   +7.80%
==========================================
  Files          10       10
  Lines         540      556      +16
==========================================
+ Hits          290      342      +52
+ Misses        227      192      -35
+ Partials       23       22       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add end-to-end encryption

Ideally, the secrets should be encrypted end-to-end so the backend API cannot access them. Only the GitHub Action should be able to decrypt the secrets.

That said tho, since I'm typing the secrets directly into your website, I can't avoid implicitly trusting your server - since the HTML/JS served by the page is also under your control.
Or are you talking about encrypting it as soon as the webserver receives it?

The secrets are stored in a data store for a short time until the GitHub Action workflow fetches them. Once fetched, they are deleted.
One option is to encrypt the secrets in the website using JavaScript before they are sent to the backend API.
Another option is to encrypt them as soon as it hits the backend API.
The idea is that even if the data store is compromised, one should not be able to access the secrets.

I think encrypting them in the client is nonsense, but encrypting them the instant it hits the webserver seems fine.

There could be a simple CLI that takes in a PSK and the plaintext and spits back ciphertext that could be in the browser client. The CLI could also just hit the API directly, I'm assuming?

There could be, but it would make the feature useless to me since i wouldn’t be able to input secrets easily on the go.
If i don’t trust the webserver here, i should be hosting one myself - ideally there’d be an open source option for self-hosting.

OK. There are more benefits to having the server than just having a mobile interface, and people may be willing to have the additional friction but still not want to host a webserver (assuming they trust passing ciphertext to a 3rd party).
There may be multiple concerns: not wanting secrets in plaintext at rest, but being OK with the server having access to those secrets; not wanting the server or client to have plaintext secrets ever. These can be addressed individually, and people could choose what works for them.

"plaintext" doesn't apply, since it's over HTTPS.
I'm very in support of providing options :-) it's just important to be very clear about what the UX and security tradeoffs are - and the security benefits are pretty minimal unless you're self-hosting.

HTTPS is encrypted over the wire but is terminated before or at the server, so "plaintext" does apply because the server has "plaintext". You can pass "ciphertext" via the API and the server won't see "plaintext".
Unless I'm mistaken, if you have an AES-256 key and you encrypt your secret, you can pass ciphertext to the server to be encrypted by a key that is configured on Github to decrypt in an Action. This would make it non-trivial for the server to decrypt and utilize any given secret.
Handing a random server a TOTP token on a consistent basis is essentially handing them over that authentication factor, making it useless. Assuming they gain access to your first factor, they can easily stage an attack for the next time your Action requests a secret. In your case, deploying malicious code to npm because you wanted to sacrifice security to be able to deploy on the fly ;)

Yes, but because any form of encryption in the browser relies on JavaScript controlled by the server, if the server is malicious you are always screwed, there’s no way to protect yourself (short of using out of band means to encrypt, like a CLI tool or an extension, neither of which are available on mobile or to the average user).
On the web, HTTPS is both enough, and the maximum worth doing, to secure content before it hits the server.

Ah, makes sense. I thought the CLI bit was still relevant because it was brought up as one option to support one use-case, and technically satisfies the issue description of wanting e2e encryption.

neither of which are available on mobile or to the average user

I don't think this issue is specifically targeting mobile users. And I think most people that are using Github Actions have a terminal and knows how to install and use a CLI.

Sure, maybe start a new issue?

I think this is the right issue, as they're related. Full end-to-end encryption from a website adds zero security, and actively harms valuable use cases, so it's a harmful thing to be seeking.

This is not only talking about encryption in the browser. The CLI use case is valid for people who want real end-to-end encryption, and does not "harm" the use case that you want. It could be a separate implementation.

@azban that's a fair point, that a CLI tool could be an alternative to using the website at all.

What about this proposal? I think this design will meet all requirements:

Create a public/private key pair in the job where wait-for-secrets is run.
Send public key to the back-end API.
API stores the public key.
When API is called to fetch secret metadata, it also returns the public key
API will expect the secrets sent to it to be encrypted with the public key
The StepSecurity website (which is one client) will do this encryption transparently. So the developer experience will remain same as current. Developer enters secrets into website. Website uses public key to encrypt them and sends to API.
There can be more clients, e.g. a phone App, a CLI etc. One could also write their own client if they do not want to trust the  StepSecurity website/ clients.
Clients should display the public key info, so if developer wants, they can compare it with what is in the build log.
Once the API gets the encrypted secrets, it cannot decrypt them. Only the job with the private key can.
Job receives the encrypted secrets and decrypts using the private key.

This design will enable end-to-end encryption without changing the current developer experience. It will also enable developers to write their own clients. Thoughts?

That sounds to me like it'd meet all concerns and use cases here.


When Del(keys...) errors, do none of the keys get deleted?

When r.client.Del(keys...).Err() != nil, are none of the keys deleted? Is it possible that some keys were deleted and others weren't? If so, how do I know which keys were deleted and which were not?
Thanks!

me too   ..


fix use function call in teardown

Closed: As this PR is more than six months old without having been merged. Please reopen (and rebase if necessary) if it is still relevant.


i3status-rust: 0.20.0 -> 0.20.1

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 122718 at c49f63cd run on x86_64-linux 1

1 package built successfully:

i3status-rust

1 suggestion:

warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/window-managers/i3/status-rust.nix:56:5:
   |
56 |     license = licenses.gpl3;
   |     ^


chore: add version information to init file

@jrobinAV When you say to put the version information on the root init file did you mean the one inside src/taipy/core right? Just to make sure

I've tried to put the code to load the version in a module on: src.taipy.core.version, but import this on setup.py causes an error because taipy.config is not yet installed, so is not possible to import anything from src.taipy.core module in setup.py. Let me know if you have any suggestions where we could isolate this logic in a function to be reused everywhere on the project.


core.memory: Catch SIGSEGV to map DMA memory [PoC]

This is a quick and dirty proof-of-concept hack done to support SnabbCo/snabbswitch#565 (multicore tests):
Extend core.memory so that the virtual addresses of all packets are
valid in all Snabb Switch processes. The memory allocated by
memory.dma_alloc() is treated specially: if another process tries to
access it then this triggers a SIGSEGV handler that will detect which
memory is needed and automatically map it into the process.
Two simple test scripts are provided: s1 that allocates memory and s2
that modifies it without any explicit mapping.
Run like this:
$ sudo ./snabb snsh s1
Installing SIGSEGV handler
address cdata<char *>: 0x5009f7c00000
current value = 0
current value = 0
current value = 0
...

Then use the same address to change the value with s2 that simply
converts it to a pointer and pokes it:
$ make && sudo strace  ./snabb snsh s2 0x5009f7c00000 42

and now you see the new value in s1:
current value = 42

This is really quick and dirty! I will clean it up if it works and we decide to keep it.
cc @javierguerragiraldez

This was the least disgusting implementation I could come up with when browsing kernel sources etc. The shm syscalls are really annoying and non-interoperable with other kernel features, but we seem to be stuck with them because mremap() doesn't work with hugetlb from mmap(). C'est la vie.
Weekend!

great!  it's much easier to hack around if there's a working PoC.
I'll go hacking with this tonight, next stop: remove fork()s!

btw: this version is going to leak huge pages because it doesn't unlink the shm IDs anymore. If you start running low on huge pages then you can use the command line tools ipcs to list the allocated ones and ipcrm to delete them.

@lukego That is another reason why SnabbBot broke down: It failed to allocate huge pages....

@eugeneia Good point. Have to think about potential impact of running these rough draft patches in the CI environment. (I don't think it will have been a problem here: much more likely it was the reboot.
I wonder if Docker-fication will help with this kind of problem. That is, if rough draft code makes a mess in /var/run and /dev/shm and so on, that this would be discarded with the one-shot container that runs the tests. Or indeed that the test suite could detect such messes since it knows that the tests had started running in a pristine environment.

@lukego Nope its the leaking (try sudo ipcs | wc -l on davos). Can I safely reboot davos nowadays? ipcrm doesn't seem fit for the task.

@lukego Do you have any pointers of what Docker sandboxing actually provides? I have a hard time finding out what it sandboxes and what not.

@eugeneia Interesting. I suppose the problem is that I "innocently" pushed a change with a resource leak on memory allocation, but then the CI is running zillions of tests (booting VMs, etc) with that leak enabled. So whereas I imagined that one or two pages would leak in fact this is happening a lot.
Here is a command-line to clean it up. Perhaps we want to run this in a loop for the time being:
for m in $(sudo ipcs -m | awk 'NF == 6 {print $2}'); do sudo ipcrm -m $m; done

It is very unlikely to cause a problem for the CI. The master Snabb Switch is only allocating the shared memory object for a millisecond or so in order to map it into memory.
Docker is using Linux Containers (cgroups). The kernel hackers have been busy and added support for multiple namespaces for filesystem / processes / sockets / routing table / etc.

But we also use shared memory objects for the counters? Won't that lead to segfaults?

Counters are a different kind of shared memory. The ipc commands are only operating on "System V" shared memory objects created by shmget(). That is how we allocate DMA memory (due to obscure Linux kernel limitations) but core.shm and counters are done differently (we mmap() a file instead).
However my command is pretty brutal in that it is deleting all of the root user's shared memory objects system-wide. So maybe it will crash some other process installed on the server. I suppose we will find out.
I do actually think that Docker/containers is a good solution to this problem. That should also protect against other interesting kinds of problems e.g. I tried to write the shm module test suite carefully to avoid potentially doing an rm -rf / if there would be a bug in the path resolving code. That would not be a problem if the test runs inside a container but it would be a major headache if it nuked davos' root file system.

i've been cleaning those in my tests "manually" with a grep line to only ipcsrm -m those with zero active references (the last column in ipcs).  I've also done a slightly longer bash script to use the ids written to /tmp/0x*0000 files.
in the end, i think any multi-process gathering of SnabbSwitch instances would be managed by  a 'director' that includes some cleanup options.

Closing PR: I am not actively developing this branch.


Update to enable TryGetService calls for the MixedRealityToolkit

XRTK - Mixed Reality Toolkit Change Request
Overview
Update to enable TryGetService calls for the MixedRealityToolkit
Target of the change:
Is this enhancement for:

Core (core framework, interfaces and definitions)

Changes:
Brief list of the targeted features that are being changed.

Adds TryGetService
Adds TryGetService (By Name)
Includes Test fixtures to validate new API

Closes: #259

Do you have any suggestions where we should replace some of the calls for this?


error: unknown attribute 'dynamicCallable'

I run 'swift build' command and there's a bunch of errors.. including this one
error: unknown attribute 'dynamicCallable'
I'm new to swift PM, so prolly I messed up on something 😶

PythonKit requires Swift 5, you can get a Trunk Development toolchain from swift.org.


Improve mailing configuratibility

Enable HTML e-mails
Make possible to configure certain e-mail types not to be send

@Alir3z4 I have fixed the conf vars names, the changelog.

This looks good to me!
Let's merge it.
Thanks for the great work.


Simple split

Simple split implementation when we're passing one-character regexp implemented according to https://youtu.be/YgGAUGC9ksk?t=2426

@konsoletyper my idea was about eliminating pattern presence in cases when String argument is constant, for instance: "a,b,c".split(","). If you are claiming that whole pattern will be compiled anyway, then it adds just minor performance improvement. I thought that TeaVM compiler would be able to detect that the branch with Pattern is not reachable and don't produce additional JS. In my case it's +100Kb of JS.


[INLONG-4715][Manager] Fix exception when no sink info is configured

Fixes #4715

In this scenario, it is should not start the Group-InitSort and related process.

Remove skip resolver to simply workflow processing.
Annihilate unnecessary work when no sink is configured.


tracking visits?

One downside to GH pages is that there are no real traffic stats.
I'd prefer to not use google analytics. Do we want or need tracking?

its always interesting to me, but not necessarily.
definitely don't want to use Google; there are open source solutions and/or we can roll our own if we want...

Let’s skip it,, since users may be uploading their birthday which is personal

https://trackgit.com/

looks good!
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, September 16, 2020 7:03 PM, albert<EMAIL_ADDRESS>wrote:

https://trackgit.com/
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.


why does Dapp's peer be saved in the db file of the main chain?

The network communication of the side chain needs to be forwarded by the main chain. Side chain does not implement network transmission is also so that dapp code can be safely hosted by third parties.


Able to fetch all refs for the git repos

fix the wrong release checking

Codecov Report

Merging #28 (e25f1a0) into master (8edf741) will decrease coverage by 0.61%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   17.93%   17.32%   -0.62%
==========================================
  Files          10       10
  Lines         368      381      +13
==========================================
  Hits           66       66
- Misses        302      315      +13

Flag
Coverage Δ

unittests
17.32% <0.00%> (-0.62%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

controllers/git.go
6.87% <0.00%> (-0.56%)
:arrow_down:

controllers/internal_scm/factory.go
22.22% <0.00%> (-0.64%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8edf741...e25f1a0. Read the comment docs.


Failures on start

Hey,
i try to start but i got two errors...

on composer create-project  ... .

[InvalidArgumentException]
Could not find package s1syphos/gulp-kirby-starter-kit with stability stable.

If i just skip this composer task and only pull your repo and try "npm start":

<IP_ADDRESS>:62413 [200]: / - Uncaught Error: Class 'Kirby' not found in /Users/XYZ/MY_PROJECT/index.php:25
Any ideas what i'm doing wrong ?

When downloading / cloning this, be sure to composer update && npm i to get the latest dependency packages - if the problem persists however, I'm glad to help!
Just let me know how it goes 🙂

hey, thx for fast answer
composer update helped ;)
if i start with php server everything looks good, but if i try with "npm start" i cannot access the panel, i just getting an error:
"The Panel cannot connect to the API"
i'm happy that it runs over php server, thank you very much for fast answer ;)

@pivster86 Regarding the composer error: I have to release a stable version  first - unless you set your minimum-stability accordingly ..


Add Cognitive Services support

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Provisioning


Google Maps cannot display

When trying to track the order, it cannot connect to Google Maps

Using Google Maps requires API key, which can be generated via Google Cloud. See https://pub.dev/packages/google_maps_flutter for more information.

I'm currently using flutter_map package instead of Google Maps, which doesn't need API to display the map. I'll open another issue related to that.


vendor-route-and-bigger-balance

Closed in favor of https://github.com/BuidlGuidl/event-wallet/commit/741a2bf6838d84d73f13547c5f32d53479333316


[Broker] Fix many stacktrace log when concurrent mark delete.

I reopened #14486 as a new PR.

Motivation
In my environment, sometimes found following logs.
2022-08-26T00:41:52,420+0000 [bookkeeper-ml-scheduler-OrderedScheduler-0-0] WARN  org.apache.bookkeeper.mledger.impl.ManagedCursorImpl - [public/default/persistent/log-topic1][sub1] Failed to flush mark-delete position
org.apache.bookkeeper.mledger.ManagedLedgerException: java.lang.IllegalArgumentException: Mark deleting an already mark-deleted position. Current mark-delete: 49:106343 -- attempted mark delete: 49:106338
Caused by: java.lang.IllegalArgumentException: Mark deleting an already mark-deleted position. Current mark-delete: 49:106343 -- attempted mark delete: 49:106338
	at org.apache.bookkeeper.mledger.impl.ManagedCursorImpl.setAcknowledgedPosition(ManagedCursorImpl.java:1722) ~[managed-ledger.jar:2.11.0-SNAPSHOT]
	at org.apache.bookkeeper.mledger.impl.ManagedCursorImpl.asyncMarkDelete(ManagedCursorImpl.java:1862) ~[managed-ledger.jar:2.11.0-SNAPSHOT]
	at org.apache.bookkeeper.mledger.impl.ManagedCursorImpl.flush(ManagedCursorImpl.java:3254) ~[managed-ledger.jar:2.11.0-SNAPSHOT]
	at org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl.lambda$flushCursors$1(ManagedLedgerFactoryImpl.java:240) ~[managed-ledger.jar:2.11.0-SNAPSHOT]
	at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]
	at org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl.lambda$flushCursors$2(ManagedLedgerFactoryImpl.java:240) ~[managed-ledger.jar:2.11.0-SNAPSHOT]
	at java.util.concurrent.ConcurrentHashMap$ValuesView.forEach(ConcurrentHashMap.java:4780) ~[?:?]
	at org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl.flushCursors(ManagedLedgerFactoryImpl.java:236) ~[managed-ledger.jar:2.11.0-SNAPSHOT]
	at org.apache.pulsar.common.util.Runnables$CatchingAndLoggingRunnable.run(Runnables.java:54) ~[pulsar-common.jar:2.11.0-SNAPSHOT]
	at org.apache.bookkeeper.common.util.OrderedExecutor$TimedRunnable.run(OrderedExecutor.java:214) ~[bookkeeper-common-4.15.0.jar:4.15.0]
	at com.google.common.util.concurrent.MoreExecutors$ScheduledListeningDecorator$NeverSuccessfulListenableFutureTask.run(MoreExecutors.java:718) ~[guava-31.0.1-jre.jar:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) ~[?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[netty-common-4.1.77.Final.jar:4.1.77.Final]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]

This is because periodic flush try to update mark delete position to old position.
In the log above, it tried to update mark delete position from 49:106343 to 49:106338.

Modifications

Logging with debug level because the marker location was already marked for deletion.

Reproduces

Start standalone with managedLedgerCursorPositionFlushSeconds=1
Create a producer and consumer with same topic.
Continue to  send and recieve/acknowledge messages.
Wait a minute and it will happen.

[x] doc-not-needed

Should we set isDirty as true if we pass the markDeleteLimiter and new markDeletePosition is greater than lastMarkDeleteEntry?

@AnonHxy
I don't know we should do that.
At least in my environment, just before calling asyncMarkDelete in ManagedCursorImpl#flush, lastMarkDeleteEntry.newPosition and markDeletePosition were same position(when the above log was output, they were  49:106338), so I think we can't avoid this issue even if set isDirty as true.
https://github.com/apache/pulsar/blob/46b1239a23fd2a250b009df1e9b4a65341d299a7/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java#L3259

/pulsarbot rerun-failure-checks


Auto reestablish StreamingPull connection after retryable error events

Environment details

OS: Debian GNU/Linux 8 (jessie)
Node.js version: v10.11.0
npm version: 6.4.1
@google-cloud/pubsub version: 0.20.1

Steps to reproduce

Create a StreamingPull listener:

request = {
  subscription: formattedSubscription,
  streamAckDeadlineSeconds: 60
};

stream = subscriberClient.streamingPull();

stream.on('data', response => {
  console.log(response);
});

stream.on('error', error => {
  console.error(error);
});

// Write request objects.
stream.write(request);

Works fine for few minutes until the server becomes UNAVAILABE (error 14, code 8a75). After that, the stream stops receiving events.

I know that some of the error codes for PubSub are "retryable", such as this one. I took a quick look at Java and Python PubSub clients at GitHub, and apparently there is some kind of "auto-retry" for UNAVAILABLE errors.
Is there such a feature in the node client? If not, should I expect this for v1.0 ?
If it is not possible to auto reestablish the connection, how can I do this manually?
Thanks for the help.

@alexander-fenster does this request make sense?  Is this reasonable?

This will be implemented as a separate feature in gax.

@danieljbruce: assigning to you since it looks similar to what you are going to work on :)

This looks like a Pub/Sub issue. This looks like @feywind's area of expertise. Feel free to send back my way if that is not correct.

Wow, ancient issue. I'm pretty sure this is already done - we do have a list of retryable errors that were set in the proto config, but are now local to the library project.
https://github.com/googleapis/nodejs-pubsub/blob/main/src/v1/subscriber_client_config.json
I'm going to go ahead and close this. Feel free to reopen if I misunderstood.


Cryptography: make the test compilable again and remove unwanted using namespace std

Remove unused warnings
Make the test app compilable again
Remove using namespace std

@HaseenaSainul sorry for getting back to this one, but can we remove the added empty file Cryptography.h and the reference to this empty file in Cryptography.cpp. That might be a bit confusing :-)

@HaseenaSainul sorry for getting back to this one, but can we remove the added empty file Cryptography.h and the reference to this empty file in Cryptography.cpp. That might be a bit confusing :-)

Sorry, this file is not added myself, it was there and it including below headers
"ICryptography.h"
#include "INetflixSecurity.h"
and the cryptography.h is included in some of the test files.
In my last changes, I mistakenly include cryptography.h Cryptography.cpp also. I. will remove that. Do I need to remove cryptography.h completely and include those headers I mentioned above directly ?

@HaseenaSainul yes please!

@HaseenaSainul yes please!

New PR created for this: https://github.com/rdkcentral/ThunderClientLibraries/pull/156


New Environmental Controller particle effect

One thing in this otherwise excellent mod always struck me as odd, and that is the Environmental Controller active particle effect. I think it could be much improved using vanilla particles, specifically mobSpell. The Controller even has them printed on the front — what is the reasoning behind the current "floating spheres" effect? Maybe Performance?
Here's a quick hack of what I'm imagining it could look like:

left: old - right: new
What do you think?

In case someone is interested, here's what I did to change the particles:
https://gist.github.com/wlhlm/cacb2f8210775076cab3
I borrowed the particle spawning from MaterialAbsorberTileEntity.java. I don't know anything about Forge modding and my Java knowledge is also very limited, so this could totally be the wrong way to approach it (for example I've seen other mods use randomDisplayTick() for particle spawning), but maybe it helps as a starting point.

Well taste differs I suppose but I actually prefer the left option :-)


[LANG-1692] Cast FieldUtils.readField result to the recipient type

This patch should be easy to understand.
Generally, it won't affect user cases as long as the type can be inferred by the recipient or JDK rules. There's a case as shown in ReflectionDiffBuilder.java that if the type inference results in ambiguity, it may cause compile error.
Thus, I'm unsure whether this is proper to be included with a minor version bump. I don't think adding another series of methods helps - it causes further confusion.
This patch doesn't cause extra class cast exception because if the recipient is Object the cast should always succeed. And if the recipient already cast it into another type, there will be an exception if the cast cannot be performed.

Codecov Report

Merging #951 (1720f16) into master (e81855a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #951   +/-   ##
=========================================
  Coverage     91.98%   91.98%
  Complexity     7423     7423
=========================================
  Files           189      189
  Lines         15666    15667    +1
  Branches       2913     2913
=========================================
+ Hits          14411    14412    +1
  Misses          677      677
  Partials        578      578

Impacted Files
Coverage Δ

...e/commons/lang3/builder/ReflectionDiffBuilder.java
91.30% <100.00%> (+0.39%)
:arrow_up:

...a/org/apache/commons/lang3/reflect/FieldUtils.java
93.33% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

This PR has no matching tests.

This PR has no matching tests.

Please read the description:

it won't affect user cases as long as the type can be inferred by the recipient or JDK rules
This patch doesn't cause extra class cast exception ...

No existing tests break is fine. I don't know how to add a new effective test.

I may write something like:
diff --git a/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java b/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java
index b68a994f3..dcecbca06 100644
--- a/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java
@@ -480,7 +480,8 @@ public void testReadDeclaredNamedStaticFieldForceAccess() throws Exception {
     @Test
     public void testReadField() throws Exception {
         final Field parentS = FieldUtils.getDeclaredField(parentClass, "s");
-        assertEquals("s", FieldUtils.readField(parentS, publicChild));
+        String s = FieldUtils.readField(parentS, publicChild);
+        assertEquals("s", s);
         assertEquals("s", FieldUtils.readField(parentS, publiclyShadowedChild));
         assertEquals("s", FieldUtils.readField(parentS, privatelyShadowedChild));
         final Field parentB = FieldUtils.getDeclaredField(parentClass, "b", true);

to prove this change works. But it seems useless.

You need to think about how to avoid regressions in case the change is reverted. IOW, in this case, you should get a compilation error.

@garydgregory Thanks for your comments. Will push a followup later this week.

Tests added.

@garydgregory is there any remaining blocker for this patch?

I'll take a look this weekend...

Closed as no response. I'll add wrappers for this changes downstream when necessary.


Add Quandl as a data source in examples

Thanks for creating ta4j! It's a great project with a very clean structure/codebase
I added a data loader in examples/ that pulls data from quandl.com. I think this will make it easier for people to have data in their sandbox to play with ta4j. It's a bit verbose but I tried to avoid adding more dependencies like a http client or a JSON parser for something that simple and reuse what's in there.

Hi and thank you for your contribution!
Sorry but examples are mainly SSCCEs used to show how ta4j can interact with other libs. I don't want to add an example for any data provider. Even if it may be interesting for you, that kind of sample comes with a low value-added for most users (since it's mainly a CSV reader, even if you make an HTTP GET before).
Please don't hesitate to ask before submitting a PR the next time.


change the way iframe url is retrieved for saving

iframe src never changes, so we need to check window location instead
videos!
before: http://d.pr/v/fPq4
after: http://d.pr/v/1d9g2

LGTM

changelog is in #4799


Create ARC for extension of ARC-06 with account switch functionality

Wallet is a gateway for dapps. For descent UX and wallet integration with a dapp we need to be able to instrument a wallet to execute a switch as well as register hooks for:

network switch
account switch

Rationale
Very often webapps have their own state and remember the network and user account. For example a webapp can use an indexer to show all pools where a user has a stake in a given Dapp. The webapp will use network genesis hash and user account address to query the pools.

If this is still relevant, please consider merging the version in the repo before submitting it.
ARC-6

@DanBurton, could you please give me your opinion on this?

I think this is good but should be its own follow-on ARC. Maybe we should combine it with #74.

@DanBurton, I merged your previous PR #74 into it.
Do you want this to be an extension rather than updating the current ARC-6?

Sorry for the delayed response. I am ok with updating the current ARC-6.

@DanBurton & @robert-zaremba
If the changes I made to merge the PR properly are ok for you, we can go like this.

👍 Looks good to me, @SudoWeezy.


[New Feature]: Upgrade HySDS to latest version (v5.2.0) and migrate to use OpenSearch from ES

Checked for duplicates
Yes - I've already checked
Alternatives considered
No - I haven't considered
Related problems
I'm frustrated when [...] happens as documented in issue-XYZ
Describe the feature request
OPERA PCM need to upgrade the HySDS to use the latest version (v5.2.0 as 3-12-24) and use OpenSearch for GRQ indices.

https://github.com/nasa/opera-sds-pcm/issues/806


writeln should be @nogc

turkeyman reported this on 2020-03-10T17:23:28Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=20663
CC List

destructionator

Description
I have had multiple complain (one of them *phoned me from overseas*) that writeln() doesn't work in @nogc.

Their claim goes: "How can it be acceptable that writeln() doesn't work in @nogc? It's literally the first thing you try and do!"

I have to agree. writeln() really should work everywhere, always.

destructionator commented on 2020-03-10T19:36:32Z
hmmm took a look at the code and the other thing that throws is on fwrite errors. I forgot about those... could possibly throw a static instance or something but that complicates the easy idea of just using replacement char.

turkeyman commented on 2020-03-10T19:23:21Z
Dunno what's going on with DIP1008, but I actually agree that using the replacement char is actually the more interesting and useful thing to do.

I might be interested in throwing a UTF exception from a function like `validateString`, but I don't want writeln to throw! I want it to write text to the output stream... it has one job!

destructionator commented on 2020-03-10T17:44:15Z
Whatever happened to that dip 1008 thing?

Or perhaps we could just change the invalid utf 8 sequence exception to the replacement char. I'd personally argue that is more useful for writing anyway (I often cast stuff to byte for it)


Boulder kills you to easily if you are moving to a spot that the boulder wants to claime too

.o.
*p*

If you want to claim the diamond on the right. Then the boulder will fall down. But it is still possible to go back left. Which will let you claim the same position as the boulder.  Annoying bug

Can not really reproduce. Only seems to happen when the boulder was already falling. Which should indeed kill you if you then move to the same spot as the boulder. What often seem to happen is that your move happens earlier (in the same game tick) as the boulder move.  An option would be that the player moves last and therefor could not move to that location (because the boulder already claimed it)

Will reopen on more proof off course


[SYM-5125] Add KnowBe4 SDK Integration example

Current dependencies on/for this PR:

main

PR #88   👈

This comment was auto-generated by Graphite.


Added an example for creating a channel from json input

We already have the splitJson operator to do this

oh wow, I did not know that. Thank you
On Thu, Aug 17, 2023 at 2:50 PM Ben Sherman @.***>
wrote:

We already have the splitJson
https://nextflow.io/docs/edge/operator.html#splitjson operator to do
this
—
Reply to this email directly, view it on GitHub
https://github.com/nextflow-io/patterns/pull/46#issuecomment-1682423963,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGMLNT5GVJTNXLHPNUBABDXVYVTRANCNFSM6AAAAAA3TVMYHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


feat: Date / Time / Datetime picker

Type: feat
Platform: mobile browser
When creating a small project with Ionic (which is very nice, by the way, thanks guys!!), one of the things I miss is a datetime picker. A component that could be configured to be date- or time-only, and perhaps emulating native appearance (if it doesn't use the native <input>) would be gold.

Greetings @nighto!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Google is a good friend here.
https://github.com/rajeshwarpatlolla/ionic-datepicker
We push people to the native input implementation, but this is a pretty good alternative.

I did know this component. I meant that it could be native to ionic core, since I don't believe it is supposed to be a component that many people might not use, such as a (say) Google Maps embed or something.

Something like that wouldn't be a good fit for ionic's core. Like I've said, the browsers own native controls off the best options in our opinion.

Fair enough. Thanks for your answer!


[Regression] Add tpch plan check

Proposed changes
Issue Number: noissue
Problem Summary:
Add plan check for tpch so that we can sense any changes to the final plan opportunely.
Checklist(Required)

Does it affect the original behavior: (Yes/No/I Don't know)
Has unit tests been added: (Yes/No/No Need)
Has document been added or modified: (Yes/No/No Need)
Does it need to update dependencies: (Yes/No)
Are there any changes that cannot be rolled back: (Yes/No)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow

please fix license

@morrySnow  review please

@dataroaring @sodamnsure help to review pls


Create a text on the screening page

Create a text: "Please refresh your browser to see your screening result"

@cekv to send text to Carlos, also regarding email option.

Done, the part of "Create a text: "Please refresh your browser to see your screening result""


RFC: Signature of Session::run

Overview
The API of Session::run needs to be decided.
Alternatives
Step
The current API defines an auxiliary type Step which holds all the arguments to be passed to the underlying call to TF_Run, and the signature of Session::run is run(&mut self, step: &mut Step) -> Result<()>.
The benefit of Step is that vectors of string pointers don't have to be created every time Session::run is called.  If we stop cloning the tensors to hide the fact that TensorFlow consumes them (which is another question), then Steps would no longer be reusable, and that benefit would at least partially go away.  Step is more future-proof, because if the signature of TF_Run changed (or if they introduced TF_Run2), code using Step wouldn't break.  It also introduces fewer types and fewer auxiliary objects.
Example usage:
let mut train_step = Step::new();
train_step.add_input("x", &x_tensor).unwrap();
train_step.add_input("y", &y_tensor).unwrap();
train_step.add_target("train").unwrap();
for _ in 0..steps {
  session.run(&mut train_step).unwrap();
}

Input, Output, and Target
It has been suggested than instead of Step, there should be Input, Output, and Target types, and the signature of Session::run will be run(&mut self, inputs: &[Input], outputs: &mut [Output], targets: &[Target], options: Option<&Buffer>, metadata: Option<&mut Buffer>) -> Result<()>.
The overhead of creating vectors of string pointers in each call to run is probably minimal, especially compared to the cost of the actual computation inside TF_Run.  This signature of run may also be viewed as more user-friendly.
Example usage:
let inputs = vec![
  Input::new("x", ok!(Tensor::new(x, &[n]))),
  Input::new("y", ok!(Tensor::new(y, &[n]))),
];
let targets = vec![Target::new("train")];
for _ in 0..steps {
  ok!(session.run(&inputs, &mut [], &targets, None, None));
}

Meta
The comment period will close on July 30, 2016.

Extended to August 31.  See #13 for why.

No real resolution.  May revisit later, if there is community interest.


Incorrect type generated for SMALLINT

Version
1.24.0
What happened?
When creating a table that includes a column of type SMALLINT, the generated model that represents the column's field as int32 instead of int16. This can lead to unexpected errors from the database.
Got
type Account struct {
        ID        string
        Userid    string
        Balance   float64
        Pin       int32
        Currency  AccountsCurrency
        Createdat time.Time
        Upatedat  time.Time
}

Expected
type Account struct {
        ID        string
        Userid    string
        Balance   float64
        Pin       int16
        Currency  AccountsCurrency
        Createdat time.Time
        Upatedat  time.Time
}

Relevant log output
No response
Database schema
CREATE TABLE IF NOT EXISTS accounts (
        id VARCHAR(80) NOT NULL,
        userId VARCHAR(80) NOT NULL,
        balance FLOAT DEFAULT 0.0 NOT NULL,
        pin SMALLINT NOT NULL,
        currency ENUM('LRD', 'USD') NOT NULL,
        createdAt DATETIME NOT NULL,
        upatedAt DATETIME NOT NULL,
        PRIMARY KEY(id),
        FOREIGN KEY(userId) REFERENCES users(id)
);

SQL queries
No response
Configuration
version: "2"
sql:
  - engine: "mysql"
    queries: "sql/queries"
    schema: "sql/schema"
    gen:
      go:
        out: "model"

Playground URL
https://play.sqlc.dev/p/486276076a4aae590e56c6a81de718232c89d551c51dfbcea042246b56f430a5
What operating system are you using?
Linux
What database engines are you using?
MySQL
What type of code are you generating?
Go

Thanks for reporting this. It would be a backwards-incompatible change, but might make sense.

This can lead to unexpected errors from the database.

What kind of error do you see or anticipate? A SMALLINT should scan into an int32 even though it wastes memory, right?

What kind of error do you see or anticipate? A SMALLINT should scan into an int32 even though it wastes memory, right?

Yes, but let's take a case where at the application level there's no check to verify whether the field/column is not bigger than int16 and the user enters a number that is larger than int16 passing that to the DB will lead to an error or unexpected behavior.

The input case does make more sense. I'll submit a pull request for this since I see that we do use int16 for PostgreSQL. Seems like it's worth fixing even though you can work around this with a type override.


Howto for adding datasets to intake and the howtoeurec4a book

In order to make it easier for the community to add datasets to the EUREC4A intake catalog and the HowTo EUREC4A book this PR adds some documentation on how to do so.

@Geet-George @raphvog please have a look a this PR and suggest edits. Maybe you could even try to add your own or favourite missing dataset to the catalog and the how-to page to test the documentations.

Thanks for the comments @Geet-George! I implemented most of them. Please feel free to also use the ```suggestion``` annotation next time so I can just accept your suggestions :)

use the ```suggestion``` annotation next time so I can just accept your suggestions :)
Ah ja, sorry I forgot

closes #106


Fix scan default_device_ios

The old logic allowed 'iPhone 6' to match on 'iPhone 6 8.1' even when
the Xcode target required 9.3 or better.
Fix #5638

Looks good - thanks for the fix! 👍

This seems to be an issue when paired with a Workspace and a Tests only target, where Scan.project.build_settings(key: "IPHONEOS_DEPLOYMENT_TARGET") seems to be returning nil and crashing the execution.
/Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/scan-0.11.3/lib/scan/detect_values.rb:60:in `include?': [!] no implicit conversion of nil into String (TypeError)        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/scan-0.11.3/lib/scan/detect_values.rb:60:in `block in default_device_ios'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/scan-0.11.3/lib/scan/detect_values.rb:58:in `each'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/scan-0.11.3/lib/scan/detect_values.rb:58:in `default_device_ios'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/scan-0.11.3/lib/scan/detect_values.rb:23:in `set_additional_default_values'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/scan-0.11.3/lib/scan.rb:27:in `config='        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/scan-0.11.3/lib/scan/manager.rb:4:in `work'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/scan-0.11.3/lib/scan/commands_generator.rb:41:in `block (2 levels) in run'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/commander-4.4.0/lib/commander/command.rb:178:in `call'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/commander-4.4.0/lib/commander/command.rb:153:in `run'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/commander-4.4.0/lib/commander/runner.rb:444:in `run_active_command'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/fastlane_core-0.50.3/lib/fastlane_core/ui/fastlane_runner.rb:36:in `run!'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/commander-4.4.0/lib/commander/delegates.rb:15:in `run!'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/scan-0.11.3/lib/scan/commands_generator.rb:60:in `run'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/scan-0.11.3/lib/scan/commands_generator.rb:14:in `start'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/fastlane-1.102.0/lib/fastlane/cli_tools_distributor.rb:48:in `take_off'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/gems/fastlane-1.102.0/bin/fastlane:5:in `<top (required)>'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/bin/fastlane:23:in `load'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/bin/fastlane:23:in `<main>'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `eval'        	from /Users/ivanbruel/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `<main>'

Oh, ouch. I didn't realize the target could be nil. The code should be updated like this:
lookup_device = lookup_device + " " + xcode_target if xcode_target && !has_version

I submitted https://github.com/fastlane/fastlane/pull/5966 which should resolve the error.


The type 'readonly [Plugin]' is 'readonly' and cannot be assigned to the mutable type 'PluginImpl[]

Type error when using createDirectStore with VuexPersistance plugin:

The type 'readonly [Plugin]' is 'readonly' and cannot be assigned to the mutable type 'PluginImpl[]

Is there a reason PluginImp[] is mutable?

const vuexPersistance = new VuexPersistence<RootState>({
  storage: localStorage,
});

export const {
  store,
  rootActionContext,
  moduleActionContext,
} = createDirectStore({
  modules: {
    // filter,
  },
  strict: process.env.DEV ? true : false,
  plugins: [vuexPersistance.plugin],
} as const);

There was a reason. The literal type of namespaced had to be inferred. But I just found a solution. Update to the version 0.8, then remove as const from the implementation.

Great, this works!


Introducing an additional tiles scale factor and possible fix for #776

Based on what @roman-nevr proposed in #728, it is now possible to set an additional tiles scale factor for map scaling. This now works both for ScaledToDpi and standard size display.
Also removed redundant MapTileProviderBase.clearTileCache() from MapTileProviderArray.detach() and MapView.detach() and moved it to MapTileProviderBase.detach() where it should belong. Might be a fix for #776.

@spyhunter99 Wouldn't that make sense to include it into 6.0.0 - I mean more specifically the cache part? Or is it too late?

Note that I'm facing frequent silent freezes when MapView.onDetach() is called. Maybe it's related to this.

@miguel-porto What you're experiencing is specifically with these commits, or mine in #908?
I just created #919 in order to improve memory cache management - and incidentally fix issues. And I don't think my own #908 goes 100% in the right direction.

I'm experiencing the freezes both with the master branch and with your PR #908. I didn't try this one here. Sorry I haven't been able to keep up so frequently in testing, as I have another project that is priority. Your #919, at first glance, seems to be the cure to my problems!

@miguel-porto Would be absolutely great, if you find the time to test this PR!
@spyhunter99 Like @monsieurtanuki I would recommend to include at least the cache part of this PR in 6.0.0 (if it's still possible) as it's cleaning up the detach chain regarding MapTileProviderBase.clearTileCache() in a more logical and safer way. Note that I have this released for a few days now and #776 hasn't reoccured yet as well as some other ANRs seem to have disappeared which cause I wasn't able to identify. So I have good reason to believe that this actually fixes them!

If you all are reasonably confident that this solves the problem, then that's fine. I've never seen the slight pause on this end. If it can be replicated, the best thing to do is to use the android device monitor and run a profiling session to find out what methods are causing the pausing. It's really the only way

I'm on @secaw 's branch and i'm now seeing cases where by the entire screen flips grey the almost immediately back to tiles and i'm seeing pauses when crossing integer. But...after a short amount of time of pinch zooming and whatnot, whatever the problem was seemed to go away. I occasionally still see a brief instant where the screen is completely gray. Profiling the session gives the following

Just looking at the output, a surprising amount of time is spent loading tiles from the database. This could indicate that the in memory cache is too small or that we may have too many threads running that are utilizing the database. Note that the above was running on the genymotion vm.
Profiling by my s5, its quite a bit different. I never saw the flicker, but i did see the pausing while zooming.

although there's a lot more tile spent downloading tiles, which is normal. Again, most of the time was spent loading a tile from the sql cache.
Reducing the threads to 4 didn't seem to help the problem at all. It's possible we are just seeing the garbage collector running

I'm also seeing the hang on detach issue.  Ugh, gonna check master for the hang later

@spyhunter99 That's strange, thanks for testing. I don't think, what you're seeing is caused by this PR though. Did you back check the master again?
This here is not about the slight pause thing and shouldn't have an influence on tile display / loading at all. I cannot reproduce any of that nor the hang on detach issue.
For me it seems to fix #776 though and possibly other related ANRs caused by concurrency issues before, that I believe now had the same source (basically MapTileProviderBase.TileCache was cleared too early in the detach chain while it was still open to be written to).
Just wondering, were you building your own MapTileProviderArray for the test above?

@secaw so far so good. This code here doesn't seem to hang on detach any more. But I'll keep on trying, since the hang problem was unpredictable, so it's better to keep on testing a bit more. I'll post here after I am more certain that this solves the issue.

Oh sorry speaked too early... yes the hang-on-detach problem still happens. I'm looking forward to #920...

Note that the hang-on-detach is silent, no exceptions are thrown, it gets completely blocked and the activity won't close. So it may be a different issue from #776.

Do we have a solid reproducible setup for the hang on detach issue? Is it only with certain overlays? when tiles are still in the download queue? maybe during a zoom animation?

I still find it unpredictable, but it seems to happen only after I have zoomed in & out a lot, so, after the memory cache being used a lot. It happens offline (not sure if online also). Note that I have nearly 1 GB of cached tiles. I'm only using Bing maps and SimpleFastPointOverlay (but as far as I remember, it also happens without any overlay).
It only happens when MapView.onDetach() is called. It never happened during the app use, even if I zoom like crazy. I'll post here if I have more clues. But can you reproduce it?

@miguel-porto i'm looking at the code for detach now... here's the basic order of operations

kill all overlays
destroy the tile provider (suspect)
purge the tile provider's memory cache (suspect)
destroy the tile request handler
destroy the projection

i'd suggest putting log statements in between each line to try and isolate the root cause.

do we have consensus on this yet? I'm ok with merging this

@spyhunter99 Still no #776 or related ANRs since this PR included in published app, so I'm even more positive about this!
@miguel-porto Thanks for testing, too bad it doesn't solve your hang on detach also. Might be good to open a separate issue.
I can't reproduce the hang on detach at all, although I'm switching back and forth the map activity a lot. Maybe we should compare setups, e.g. I'm just using Itemized Overlays, Paths and an additional map overlay. No compass, minimap etc. Did you check deactivating such additional features, if present in your setup?

It seems that the hang-on-detach is fixed by #908 ! Still not fully sure, but I'm positive about it.
My setup is pretty simple, just Bing maps and SimpleFastPointOverlay on top of it. However, I have 1GB of cached tiles and work offline, it might have something to do with pushing memory to the limits. But no worries with this for now, because the last commits to #908 probably fixed it!


the "isInSameDayAsDate" does not seem to be available?

I have a Swift project using SwiftDate however whilst I can see/use some of the SwiftDate NSDate extensions I am not seeing "isInSameDayAsDate" as available to use in XCode, even though I see this function in the doco/source code on github?
What do I need to do to get access to the "isInSameDayAsDate" in XCode?
My Podfile (using what was recommended on the user doco):
use_frameworks!
platform :ios, '8.0'
pod "SwiftDate", "~> 2.0"

PS.  Also wondering here was there a specific reason one has to put the v8 IOS platform statement in the Podfile, and also v2 only for SwiftDate?

You should try SwiftDate v3 and later.
Does that resolve your issue?

I get the following error message (below) if I drop the recommended Pod file lines of:
use_frameworks!
platform :ios, '8.0'
pod "SwiftDate", "~> 2.0"

Error message
$ pod install --verbose
  Preparing

Updating local specs repositories

Updating spec repo `master`
  $ /usr/bin/git pull --ff-only
  Already up-to-date.

CocoaPods 1.0.0.beta.4 is available.
To update use: `gem install cocoapods --pre`
[!] This is a test version we'd love you to try.

For more information see http://blog.cocoapods.org
and the CHANGELOG for this version http://git.io/BaH8pQ.

Analyzing dependencies

Inspecting targets to integrate
  Using `ARCHS` setting to build architectures of target `Pods`: (``)

Finding Podfile changes
  - SwiftDate

Resolving dependencies of `Podfile`
[!] Unable to satisfy the following requirements:

- `SwiftDate` required by `Podfile`
- `SwiftDate (= 2.0.2)` required by `Podfile.lock`

Specs satisfying the `SwiftDate` dependency were found, but they required a higher minimum deployment target.

Specs satisfying the `SwiftDate (= 2.0.2)` dependency were found, but they required a higher minimum deployment target.

/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/resolver.rb:411:in `handle_resolver_error'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/resolver.rb:69:in `rescue in resolve'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/resolver.rb:57:in `resolve'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/installer/analyzer.rb:539:in `block in resolve_dependencies'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/user_interface.rb:59:in `section'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/installer/analyzer.rb:537:in `resolve_dependencies'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/installer/analyzer.rb:70:in `analyze'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/installer.rb:213:in `analyze'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/installer.rb:136:in `block in resolve_dependencies'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/user_interface.rb:59:in `section'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/installer.rb:135:in `resolve_dependencies'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/installer.rb:105:in `install!'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/command/project.rb:71:in `run_install_with_update'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/command/project.rb:101:in `run'
/Library/Ruby/Gems/2.0.0/gems/claide-0.9.1/lib/claide/command.rb:312:in `run'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/lib/cocoapods/command.rb:47:in `run'
/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.39.0/bin/pod:44:in `<top (required)>'
/usr/local/bin/pod:22:in `load'
/usr/local/bin/pod:22:in `<main>'
$

Just try: pod "SwiftDate" without the , "~> 2.0"bit.
Does that work for you?

Fixed in 4994b9f


Update REGEX_YAML_BLOCK

Update REGEX_YAML_BLOCK to prevent matching metadata section in modelcards if some content is placed before it. Avoid having a false positive in case of a code section inside the modelcard.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

yes @nateraw correct, but maybe let's keep one with whitespace above the first --- as it should match in that case?

I've made the change suggested by @nateraw in https://github.com/huggingface/huggingface_hub/pull/1285/commits/2564e8c8f6862825493cb0adafb7c193ce51ba4d and added simple tests for the regex in https://github.com/huggingface/huggingface_hub/pull/1285/commits/950a20fb30bd17944666e6a16cd4150de43dbf77 (and also updated the PR description).
@julien-c @nateraw could you quickly review before I merge ?


whenGET function doesn't get called!

In my application, I am trying to mock backend data on GET request. I have already written code to initiate http-backend-proxy, defined onload functions and added mock json data in my app. But when I try to run the app and API call is made, the proxy.onload.whenGET function would not get executed. I don't know where am I doing wrong. Can you please give me any pointer to solve my problem?

Do you have an example app I can look at?  You might also take a look at some of the closed issues to see some of the typical problems people encounter and the resolutions.

Thanks for replying. Yes, I am sharing the example app here.
    httpBackend = require('http-backend-proxy');
    mockInventoryData = require('../data/devicesInventory.json');
    proxy = new httpBackend(browser);
    proxy.onLoad.reset();
    var proxy, httpBackend, mockFastProvisionData;
    page = require('./pages/homePage.js');
    homePage = new page();
    proxy.onLoad.whenGET('/ui/devices').respond(function(status, data) {
        return [200, mockInventoryData];
    });
    browser.ignoreSynchronization = true;

  it('should pass if the user_name and comments fields ARE associated with the device', function() {
         browser.get('http://localhost:9009/#/devices');
         expect(homePage.someFunc()).toBeDefined();

The someFunc() makes a http call to /ui/devices.
Please let me know if I can help you by providing more information.

I see this is closed, but adding some comments based on the example provided for those it may help.  There are a few possible issues here.

First, it appears that httpBackend is being declared twice. This may just be a cut/paste error and I'll assume that the var proxy... declaration is really at the top of the file.
Remember that the whenGet function actually runs on the browser and therefore will not have access to the mockInventoryData unless it is placed on the Context (see the docs).
ingoreSyncronization can cause problems with stuff executed via onLoad.  See issue #21, especially the last few comments.


Ansible Task - Tower Interface not enabled?

Hello,
I can see a bunch of code to enable calling Ansible Tower via its API, however, its not enabled in task.json a seletable in input interface in the initial radio button?

This PR seems to have removed the ansible tower interface, and corresponging service endpoint.
Althought he PR doesnt really say much about the change.
Pull Request:
#240
https://github.com/Microsoft/vsts-rm-extensions/pull/240/files

Hello Dan,
Earlier we had just added a basic version of ansible tower which will queue a job in tower.
We later realize that there are many gaps such as how artifact will flow. So we removed this option and decided to only enable based on user request and there requirement.
//Himanshu
From: Dan-Co<EMAIL_ADDRESS>Sent: 31 May 2018 02:10
To: Microsoft/vsts-rm-extensions<EMAIL_ADDRESS>Cc: Himanshu Lilha<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Microsoft/vsts-rm-extensions] Ansible Task - Tower Interface not enabled? (#436)
This PR seems to have removed the ansible tower interface, and corresponging service endpoint.
Althought he PR doesnt really say much about the change.
Pull Request:
#240https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvsts-rm-extensions%2Fpull%2F240&data=02|01|hililh%40microsoft.com|d7d40ea3acaa4e6e961e08d5c66d7575|72f988bf86f141af91ab2d7cd011db47|1|0|636633095782186451&sdata=huZFUqhE%2FrTyzzWdzMAQ9vq%2FLIBOBs13KYQl8AdutuU%3D&reserved=0
https://github.com/Microsoft/vsts-rm-extensions/pull/240/fileshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvsts-rm-extensions%2Fpull%2F240%2Ffiles&data=02|01|hililh%40microsoft.com|d7d40ea3acaa4e6e961e08d5c66d7575|72f988bf86f141af91ab2d7cd011db47|1|0|636633095782186451&sdata=gEdbUCTg1zIrSl%2BKwwnbQPFS1sed%2Fo3ju2z5MISUQ9U%3D&reserved=0
@hililhhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhililh&data=02|01|hililh%40microsoft.com|d7d40ea3acaa4e6e961e08d5c66d7575|72f988bf86f141af91ab2d7cd011db47|1|0|636633095782196464&sdata=XBX0%2F1CCur0mvJyhAJBr3t7z%2BXRuHc4H3v9o6UCtE6k%3D&reserved=0 - can you recall if this was intentional removal of Ansible Tower option?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvsts-rm-extensions%2Fissues%2F436%23issuecomment-393310923&data=02|01|hililh%40microsoft.com|d7d40ea3acaa4e6e961e08d5c66d7575|72f988bf86f141af91ab2d7cd011db47|1|0|636633095782196464&sdata=PGNnJBdtWrjeMtUdYzcVV0jgi089ItLoJaxEpNAFpFg%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAXGPyRuA-B8m89TnpB31KEHLm2Jfmdf6ks5t3wOIgaJpZM4UT9wE&data=02|01|hililh%40microsoft.com|d7d40ea3acaa4e6e961e08d5c66d7575|72f988bf86f141af91ab2d7cd011db47|1|0|636633095782206468&sdata=h%2FoSWiSFdVc1%2FUquUnN%2BTnAcoMUqCWEfyNBh%2FUC5Kj0%3D&reserved=0.

Hello.
Yes we already use Ansible Tower from VSTS using a shell script and tower-cli.
However a VSTS task calling tower directly would be great.
As long as we can pass extravars into the tower task, our artifact flow is currently as follows.

download artifact to agent
stage artifact on agent (http deamon)
call tower job template, passing int he http artifact location and the ansible playbook will retreive this as the first step of the playbook.
4 .retreive standard out and error and display/integrate to VSTS using VSO vars.

@Dan-Co - Apologies for the delayed response. Somehow this issue got out our radar.
Thanks for your feedback. As Himanshu mentioned above, since there were a lot of gaps in this feature, it got cut out. Adding @pulkitaggarwl to consider adding this support in a future version.


setup on fedora required code changes

I am running on fedora 33 and installed rust and gtk4-devel using dnf. When trying to get rust to compile I had to add
[dependencies]
gtk4 = { git = "https://github.com/gtk-rs/gtk4.git" }
to the Cargo.toml (just using gtk = .. did not work)
Also I compile the basic.rs code in the example, but any reference to gtk, I had to change to gtk4.
Is this an issue?

Can you describe what exactly you were compiling and how? gtk4 = { git = "https://github.com/gtk-rs/gtk4-rs.git" } would be correct for a crate outside this repository.

this is the main.rs file:
//! # Basic Sample
//!
//! This sample demonstrates how to create a toplevel window, set its title, size and
//! position, how to add a button to this window and how to connect signals with
//! actions.
use gtk4::prelude::*;
use std::env::args;
fn build_ui(application: &gtk4::Application) {
let window = gtk4::ApplicationWindow::new(application);
window.set_title(Some("First GTK Program"));
window.set_default_size(350, 70);

let button = gtk4::Button::with_label("Click me!");

window.set_child(Some(&button));

window.show();

}
fn main() {
let application =
gtk4::Application::new(Some("com.github.gtk-rs.examples.basic"), Default::default())
.expect("Initialization failed...");
application.connect_activate(|app| {
    build_ui(app);
});

application.run(&args().collect::<Vec<_>>());

}
and
this is the Cargo.toml file:
[package]
name = "basictest"
version = "0.1.0"
authors = ["jp"]
edition = "2018"
[dependencies]
gtk4 = { git = "https://github.com/gtk-rs/gtk4.git" }
just did the normal cargo new basictest
and executed cargo run in the new directory.

Yes that looks correct but you should better use https://github.com/gtk-rs/gtk4-rs.git instead of https://github.com/gtk-rs/gtk4.git. You're currently using the old repository.
What exactly is the problem though?

Yes that looks correct but you should better use https://github.com/gtk-rs/gtk4-rs.git instead of https://github.com/gtk-rs/gtk4.git. You're currently using the old repository.

We should archive all the old gtk4 repositories as they are just very confusing and are not useful any more.
cc @GuillaumeGomez

Done!

Thank you !


Sorry, didn't recognize that command!

Hi, Unable to create plugin, After upgrading to v2.0.0-beta.6.
$ weex plugin create pTest
Sorry, didn't recognize that command!
Type weex help to view common commands.

@manjuk41  name can no longer contain capital letters, try p-test.

@erha19 tried and still its not working. Also tired to downgrade version, still no luck.
The command 'plugin' itself is not recognising.

@erha19 removed weex-toolkit manually and installing it again worked.

卸载重装一样的报错

me too
i delete
~/.wx/modules/node_modules/
then weex not work
i reinstall
npm i -g weex-toolkit
but not work

install success
but


make it so staff can use

Helpers/Devs arguably shouldn't be allowed access to sensitive data. You would need to ask Dan to confirm such.


Add maximumAccountSize to login dialog

https://github.com/osmandapp/OsmAnd-Issues/issues/1544


Expand unit tests.

Our unit tests are currently quite minimal outside the core, and we also don't have full coverage in the core. This needs to be addressed before V1 is released.

In Cherab we have the ability to report test coverage using coverage.py, courtesy of https://github.com/cherab/core/pull/155. It would be an almost straight copy of this PR (with s/cherab/raysect/) to provide the same capability in Raysect. This could be used to track expansion of unit tests, and ensure any new features are fully supported by tests. Is this something you'd be interested in adding?

This sounds sensible to me. I can't see any reason why this couldn't be added. @CnlPepper?

Thanks @jacklovell I've added the relevant code and configuration to the raysect repository. See 0ff46d66b19138890d92bf3b0da5185bdb550a7b.

Great, I think this issue is too generic though. I think we should close it and replace with more targetted ones.