Web - Room Conversation - The #rooms creator does not see the reaction emoji

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com/
Log in to NewDot with a High traffic account that has and owns a existing Workspace
Click on the green + button
Click on the "New Room" option
Set the name of the #Room to anything you'd like (following the correct format)
Write a message
Log in as another account that has access to the same workspace (if needed invite another account you have access)
Search the room name and Verify it's displayed in the search results
Tap on the room and Verify the room opens and you can access it as another member of the workspace
Put a reaction emoji

Expected Result:
All messages and emoji reactions must be visible to the # room creation
Actual Result:
rooms creator does not see reaction emoji
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/229112577-2035ba58-8b26-438a-b526-d5fa108f19b5.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

I cannot recreate this:
https://user-images.githubusercontent.com/9133401/229574691-6a013320-ecd9-4138-b66d-624cc078aeaf.mp4
@kbecciv could you reopen if you can? I think this is actually fixed, or was due to some offline error?


Failed to create new bib file when exporting to a different disk partition

Support log ID: URVZ7PCL-apse
Exporter used:
Expected behavior:
I installed zotero in C:, and I want to export bib file to S:\myLib_zotero.bib, then
Actual behavior:
It cannot create the new bib file, and stucked. No error occured if I export bib file to C: partition.
support log:

(3)(+0000000): {better-bibtex Better BibLaTeX error (worker 2)} +0 worker: <Error: Will not make relative S: makeDirs@resource://zotero-better-bibtex/worker/zotero.js?version=<IP_ADDRESS>&platform=win&translator=Better%20BibLaTeX&output=S%3A%5CmyLib_zotero.bib&localeDateOrder=ymd&debugEnabled=true&worker=2:44940:13 init@resource://zotero-better-bibtex/worker/zotero.js?version=<IP_ADDRESS>&platform=win&translator=Better%20BibLaTeX&output=S%3A%5CmyLib_zotero.bib&localeDateOrder=ymd&debugEnabled=true&worker=2:45010:9 Zotero__workerContext</ctx.onmessage@resource://zotero-better-bibtex/worker/zotero.js?version=<IP_ADDRESS>&platform=win&translator=Better%20BibLaTeX&output=S%3A%5CmyLib_zotero.bib&localeDateOrder=ymd&debugEnabled=true&worker=2:45086:9 >

Can you get me a new support log from build 1028? It will fail again, but I need more information on the failure.

I am looking to put out a new release and I'd prefer to have this fix in it, but I don't have a windows machine, so I really need the feedback.

I really need that feedback

Dude this is likely a 10 minute fix if you could just give me feedback.

@retorquere Sorry for late response, I don't browse github very often. New support log ID is AYU26I5P-apse
(3)(+0000003): {better-bibtex Better BibLaTeX (worker 1)} +0 makeDirs: {"context":{"exportFileData":false,"workerContext":{"debugEnabled":true,"localeDateOrder":"ymd","output":"S:\\aaa.bib","platform":"win","translator":"Better BibLaTeX","version":"<IP_ADDRESS>","worker":"1"}},"path":"S:"}

Don't you get email notifications?
The problem may already be fixed on 5.4.23, please try that first..

I have updated to 5.4.23 and confirmed the problem have been solved, thanks a lot~
I don't check my email very often, either, actually haven't since this issue was created. Instant messaging is more popular in some countries. Sorry for any inconvenience.


false positives

I get a lot of false positives, because I think it looks for methods of another package inside the current file.
(And I think, the idea is to only "judge" the current file)
So basically It should ignore any function that doesn't exists in this file, right?

It should ignore any function that doesn't exists in this file

yes

it looks for methods of another package inside the current file

this should not happen, albeit collision of function name is possible. only function name is checked, receiver or package name is not. no type resolution is happening either. afaik

vertfn/analysis/vertfn/printer.go:98:54: func Error is declared(97) before used(98)
This is such a case, I believe
97 < 98 , so it is good I think


Remove db:prime task in favor of seeds.rb

@taboularasa #5

should README mention keeping the seed file up to date as the object graph evolves?

@taboularasa Yeah, I added that with the brand spanking new README in the stairs PR: https://github.com/philosophie/suspenders/pull/39/files#diff-872dc880005c812af97f2c706dcdeaa8R19

:shipit:


why no examples?

they would really help!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4f8a3f90-77e6-17bc-96da-86656c83b621
Version Independent ID: 1cff5de0-c3bd-489e-5fef-a2a6d6e55d89
Content: Get-DlpDetectionsReport (exchange)
Content Source: exchange/exchange-ps/exchange/policy-and-compliance-dlp/Get-DlpDetectionsReport.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

oops! there is an example!  but it is very basic!

@anwarmahmood1 do you have any suggestions for what would be a "good" example?


Using @children at a property level logs a warning

I have a CustomElement that uses the children annotation, like this:
@children('aubs-tabs') tabs = []
Everything works just fine, but it logs the following in the console:
WARN [property-observation] Cannot observe property 'tabs' of 'AubsTabsetCustomElement'
Now, the warning goes away if I use the children annotation at a class level:
@children({ name: "tab", selector: "aubs-tab" })
I did some debugging and that warn is being logged here: https://github.com/aurelia/binding/blob/1d6e826dbbc401ca21ad0deaf7acca498cd71c8b/src/property-observation.js#L104
And I believe this is the root cause:
Uncaught TypeError: Cannot redefine property: tabs     at Function.defineProperty (<anonymous>)     at eval (eval at evaluate (:117:21), <anonymous>:1:8)     at SetterObserver.convertProperty (http://localhost/aurelia/aurelia.bundle.js:5087:5)     at SetterObserver.subscribe (http://localhost/aurelia/aurelia.bundle.js:5072:12)     at Binding.addObserver (http://localhost/aurelia/aurelia.bundle.js:1560:14)     at Binding.observeProperty (http://localhost/aurelia/aurelia.bundle.js:1575:15)     at AccessScope.connect (http://localhost/aurelia/aurelia.bundle.js:2843:13)     at Binding.connect (http://localhost/aurelia/aurelia.bundle.js:6305:27)     at enqueueBindingConnect (http://localhost/aurelia/aurelia.bundle.js:1640:13)     at Binding.bind (http://localhost/aurelia/aurelia.bundle.js:6272:7)     at Controller.bind (http://localhost/aurelia/aurelia.bundle.js:10735:17)     at View.bind (http://localhost/aurelia/aurelia.bundle.js:8779:22)     at Controller.bind (http://localhost/aurelia/aurelia.bundle.js:10757:17)     at View.bind (http://localhost/aurelia/aurelia.bundle.js:8779:22)     at Controller.bind (http://localhost/aurelia/aurelia.bundle.js:10757:17)     at View.bind (http://localhost/aurelia/aurelia.bundle.js:8779:22)
Fortunately, there is an easy workaround, but I wonder why it only happens with property level annotations.

@jdanyow Can you look into why this is happening? There shouldn't be a warning for this.

Babel's decorator logic makes the property not configurable: https://github.com/aurelia/binding/issues/406

Issue moved to aurelia/templating #520 via ZenHub


Add general installation info

Hello, I added general installation info into README. If you have any questions and comments, please contact me by message.

@frostming
I submit pull request again.(#4205 )

@y-vectorfield You don't have to re submit a PR, you can just commit to the existing branch.

@y-vectorfield You don't have to re submit a PR, you can just commit to the existing branch.
A PR is not a one-off task, it often needs several rounds of review and updates.

Oh, sorry. I renamed this branch's name...

@frostming
Thank you very much for your approving.


sync: try next level after upper level is included

Codecov Report

Merging #1897 (059c5d8) into main (0c69891) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1897      +/-   ##
==========================================
+ Coverage   61.29%   61.49%   +0.20%
==========================================
  Files         135      135
  Lines       23411    23418       +7
==========================================
+ Hits        14349    14401      +52
+ Misses       7389     7343      -46
- Partials     1673     1674       +1

Impacted Files
Coverage Δ

pkg/sync/sync.go
45.56% <100.00%> (+0.29%)
:arrow_up:

pkg/object/redis.go
70.93% <0.00%> (-2.25%)
:arrow_down:

pkg/chunk/disk_cache.go
79.85% <0.00%> (-0.49%)
:arrow_down:

pkg/meta/redis.go
71.68% <0.00%> (+0.25%)
:arrow_up:

pkg/meta/sql.go
64.82% <0.00%> (+0.29%)
:arrow_up:

pkg/meta/tkv_etcd.go
76.69% <0.00%> (+0.97%)
:arrow_up:

pkg/vfs/writer.go
79.66% <0.00%> (+1.01%)
:arrow_up:

pkg/meta/tkv.go
76.54% <0.00%> (+1.27%)
:arrow_up:

pkg/meta/tkv_badger.go
73.80% <0.00%> (+1.78%)
:arrow_up:

pkg/meta/tkv_tikv.go
67.13% <0.00%> (+4.89%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c69891...059c5d8. Read the comment docs.


Clarification on req.clearTimeout()

Hi,
I was just looking for some clarification on the req.clearTimeout() function -- does it reset the timeout (ie. start the timeout counter from 0) or does it stop connect-timeout from monitoring the request for a timeout?  I wasn't sure based on the info in the README.
Thanks in advance!
Mike

It removes the timeout completely an is analogous to the clearTimeout function in JavaScript. I can add more description rather than relying on the similar name to communicate the functionality :)

Awesome, thanks! That's exactly what I was looking for.


Need support for PATCH method in API.

PATCH method should work similar to put or post in sending request data. Right now, it does not send the form data in the request.

@ikido Do you want me to do a PR for this? Thanks.


DoH

Why is the DoH format only accepting IP? It has to accept domain names rather than IPs. maybe even full DoH query URL

Please see this answer: https://github.com/9seconds/mtg/pull/222#issuecomment-956051360


 Original error: 500 - {"status":19,"value":{"error":"XPath Lookup Error","message":"Invalid XPath expression: TitleBar//[starts-with(@value, "HPB8033E")]"}}
at JWProxy.proxy$ (C:\Users\E2E Lab\AppData\Roaming\npm\node_modules\appium\node_modules\appium-base-driver\lib\jsonwp-proxy\proxy.js:152:13)
at tryCatch (C:\Users\E2E Lab\AppData\Roaming\npm\node_modules\appium\node_modules\babel-runtime\regenerator\runtime.js:67:40)
at GeneratorFunctionPrototype.invoke [as _invoke] (C:\Users\E2E Lab\AppData\Roaming\npm\node_modules\appium\node_modules\babel-runtime\regenerator\runtime.js:315:22)
at GeneratorFunctionPrototype.prototype.(anonymous function) [as throw] (C:\Users\E2E Lab\AppData\Roaming\npm\node_modules\appium\node_modules\babel-runtime\regenerator\runtime.js💯21)
at GeneratorFunctionPrototype.invoke (C:\Users\E2E Lab\AppData\Roaming\npm\node_modules\appium\node_modules\babel-runtime\regenerator\runtime.js:136:37)
at
[HTTP] <-- POST /wd/hub/session/7caca227-e70c-473d-ab9e-6b5c26258dce/element 500 371 ms - 199
[HTTP] --> POST /wd/hub/session/7caca227-e70c-473d-ab9e-6b5c26258dce/element {"using":"xpath","value":"TitleBar//[starts-with(@value, "HPB8033E")]"}
[MJSONWP] Driver proxy active, passing request on via HTTP proxy
[debug] [JSONWP Proxy] Proxying [POST /wd/hub/session/7caca227-e70c-473d-ab9e-6b5c26258dce/element] to [POST http://<IP_ADDRESS>:4728/wd/hub/session/B90ADA83-8975-4189-96C1-70240EBE05D2/element] with body: {"using":"xpath","value":"TitleBar//[starts-with(@value, "HPB8033E")]"}
[WinAppDriver] [STDOUT]
[WinAppDriver] [STDOUT]
[WinAppDriver] [STDOUT] ==========================================
[WinAppDriver] [STDOUT] POST /wd/hub/session/B90ADA83-8975-4189-96C1-70240EBE05D2/element HTTP/1.1
[WinAppDriver] [STDOUT] Accept: /
[WinAppDriver] [STDOUT] Connection: keep-alive
[WinAppDriver] [STDOUT] Content-Length: 73
[WinAppDriver] [STDOUT] Content-Type: application/json
[WinAppDriver] [STDOUT] Host: <IP_ADDRESS>:4728
[WinAppDriver] [STDOUT] User-Agent: appium
[WinAppDriver] [STDOUT]
[WinAppDriver] [STDOUT] {"using":"xpath","value":"TitleBar//[starts-with(@value, "HPB8033E")]"}
[WinAppDriver] [STDOUT] HTTP/1.1 500 Internal Error
[WinAppDriver] [STDOUT] Content-Length: 136
[WinAppDriver] [STDOUT] Content-Type: application/json
[WinAppDriver] [STDOUT]
[WinAppDriver] [STDOUT] {"status":19,"value":{"error":"XPath Lookup Error","message":"Invalid XPath expression: TitleBar//[starts-with(@value, "HPB8033E")]"}}
[MJSONWP] Encountered internal error running command: {"w3cStatus":400,"jsonwp":{"status":19,"value":{"error":"XPath Lookup Error","message":"Invalid XPath expression: TitleBar//[starts-with(@value, "HPB8033E")]"}}} ProxyRequestError: Could not proxy command to remote server. Original error: 500 - {"status":19,"value":{"error":"XPath Lookup Error","message":"Invalid XPath expression: TitleBar//[starts-with(@value, "HPB8033E")]"}}
at JWProxy.proxy$ (C:\Users\E2E Lab\AppData\Roaming\npm\node_modules\appium\node_modules\appium-base-driver\lib\jsonwp-proxy\proxy.js:152:13)
at tryCatch (C:\Users\E2E Lab\AppData\Roaming\npm\node_modules\appium\node_modules\babel-runtime\regenerator\runtime.js:67:40)
at GeneratorFunctionPrototype.invoke [as _invoke] (C:\Users\E2E Lab\AppData\Roaming\npm\node_modules\appium\node_modules\babel-runtime\regenerator\runtime.js:315:22)
at GeneratorFunctionPrototype.prototype.(anonymous function) [as throw] (C:\Users\E2E Lab\AppData\Roaming\npm\node_modules\appium\node_modules\babel-runtime\regenerator\runtime.js💯21)
at GeneratorFunctionPrototype.invoke (C:\Users\E2E Lab\AppData\Roaming\npm\node_modules\appium\node_modules\babel-runtime\regenerator\runtime.js:136:37)
at
[HTTP] <-- POST /wd/hub/session/7caca227-e70c-473d-ab9e-6b5c26258dce/element 500 301 ms - 199
[HTTP] --> DELETE /wd/hub/session/12a84140-e463-4765-8bd7-519e30eaa184 {}
[debug] [MJSONWP] Calling AppiumDriver.deleteSession() with args: ["12a84140-e463-4765-8bd7-519e30eaa184"]
[debug] [BaseDriver] Event 'quitSessionRequested' logged at<PHONE_NUMBER>250 (09:40:50 GMT-0700 (Pacific Daylight Time))
[Appium] Removing session 12a84140-e463-4765-8bd7-519e30eaa184 from our master session list
[debug] [WinAppDriver] Deleting WinAppDriver session
[debug] [WinAppDriver] Deleting WinAppDriver server session

Hi @AmitVerma4HP,
There are few issues above that can be broken down as follows:

The XPath expressions you sent are incorrect as the error message precisely described: "Invalid XPath expression: TitleBar//[starts-with(@value, "HPB8033E")]". Below are the corrected XPath queries based on the ones you provided above (notice the placement of // and the capitalization of the attribute).
"//TitleBar[starts-with(@Value, "HPB8033E")]")"
"//ListItem[starts-with(@Name, "test1 - Notepad")]"

The current XPath lookup does not consider the Value attribute. Hence, even with the proper XPath query, you will not get the TitleBar you are looking for with the current version of WinAppDriver. For the time being, I highly recommend using the Title session property to verify the Printer Queue window title as follows:

// Ensure you have Correct Print Queue opened
Assert.IsTrue(session.Title.StartsWith("HPB8033E"));

Would you give these a try and let us know how it goes?

@timotiusmargo
Sorry for typo in xpath. Both suggested changes worked :-) but I was wondering what properties I should use for constructing xpath expressions (that we supported in WinAppDriver). Are there plans to support other properties/attributes in future like Value etc.?

For title validation below element worked.
Assert.IsTrue(session.Title.StartsWith("HPB8033E"));

For queued print job validation -
Assert.assertTrue(PrinterQueueSession.findElementByXPath("//ListItem[starts-with(@Name, "test1")]").getText().contains("test1"),"Expected Print Job NOT FOUND in Print Queue");

Hi @AmitVerma4HP,
Glad to hear those solved your issues. In general we should use element attributes such as AutomationId, Name. ClassName etc to locate or specify the element we are interested in. Currently finding element using XPath are limited to attributes that are populated when you generate the Page Source. But we are looking to make it more versatile in the future.

Thank you for being very quick in response. Appreciate it.
Good to close this issue.


fixed minMarkerRadius and maxMarkerRadius

Before this, we couldn't set the minMarkerRadius and maxMarkerRadius and now it is possible

Thanks! Nice catch.


Classify contigs

allow classify_kraken2 to take contigs as input

blocked by bokulich-lab/q2-types-genomics/#54 and bokulich-lab/q2-types-genomics/#55

closes #63

can confirm that all tests are passing locally

Just an FYI that this needs to be merged before we can release, as it is paired with https://github.com/bokulich-lab/q2-types-genomics/pull/55

Merging because the KeyError won't be a problem, we just haven't gotten a build with the updates in types-genomics yet.


Update munit-cats-effect-3 to 1.0.6

Updates org.typelevel:munit-cats-effect-3 from 1.0.5 to 1.0.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "munit-cats-effect-3" } ]

labels: test-library-update, semver-patch

Codecov Report

Merging #197 (b1c8920) into main (b9e9faa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   88.85%   88.85%
=======================================
  Files          91       91
  Lines        2772     2772
  Branches       70       70
=======================================
  Hits         2463     2463
  Misses        309      309

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e9faa...b1c8920. Read the comment docs.


small oopsie

small, but critical, oopsie fixed.
for now people can use this for the changedetection container:
PLAYWRIGHT_DRIVER_URL=ws://playwright-chrome:3000/?--window-size=1920,1024

ahh fantastic, thank you :)


twister code coverage report base directory not setting

Describe the bug
passing in --coverage-basedir ../XXX/src/
leads to

Traceback (most recent call last):
  File "/opt/nordic/ncs/v2.4.0/zephyr/./scripts/twister", line 201, in <module>
    ret = main(options)
  File "/opt/nordic/ncs/v2.4.0/zephyr/scripts/pylib/twister/twisterlib/twister_main.py", line 212, in main
    run_coverage(tplan, options)
  File "/opt/nordic/ncs/v2.4.0/zephyr/scripts/pylib/twister/twisterlib/coverage.py", line 278, in run_coverage
    coverage_tool.generate(options.outdir)
  File "/opt/nordic/ncs/v2.4.0/zephyr/scripts/pylib/twister/twisterlib/coverage.py", line 101, in generate
    ret = self._generate(outdir, coveragelog)
  File "/opt/nordic/ncs/v2.4.0/zephyr/scripts/pylib/twister/twisterlib/coverage.py", line 208, in _generate
    subprocess.call(["gcovr", "-r", self.base_dir, "--gcov-executable",
  File<EMAIL_ADDRESS>line 345, in call
    with Popen(*popenargs, **kwargs) as p:
  File<EMAIL_ADDRESS>line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File<EMAIL_ADDRESS>line 1796, in _execute_child
    self.pid = _posixsubprocess.fork_exec(
TypeError: expected str, bytes or os.PathLike object, not NoneType

Please also mention any information which could help others to understand
the problem you're facing:

What target platform are you using? qemu_cortex_m3
What have you tried to diagnose or workaround this issue? I edited coverage.py to check if self.base_dir == None and it is none though even i set it in the python script or pass it through calling twister
To Reproduce
Steps to reproduce the behavior:
./scripts/twister --coverage --coverage-basedir ../XXX/src/ -p qemu_cortex_m3  -c --coverage-tool gcovr  -T ../XXX/tests

Expected behavior
code coverage report should generate
Environment (please complete the following information):

OS: Mac
Toolchain zephyr sdk 0.16.3
Commit SHA or Version used

Additional context
Add any other context that could be relevant to your issue, such as pin setting,
target configuration, ...

not able to reproduce

does  --coverage-basedir need to be in quotes?

seems like passing --gcov-tool gcov does the trick, but coverage report is blank

base directory still not setting. showing as '.'

Sorry, I still can't reproduce this, please provide exact steps which lead to this error
i9:zephyr(topic/twister/predicate): ./scripts/twister --coverage --coverage-basedir tests/kernel/threads/thread_init/src/ -p qemu_cortex_m3  -c --coverage-tool gcovr  -T tests/kernel/threads/thread_init/
Deleting output directory /home/nashif/zephyrproject/zephyr/twister-out
INFO    - Using Ninja..
INFO    - Zephyr version: zephyr-v3.5.0-4936-gc84df7ded81a
INFO    - Using 'zephyr' toolchain.
INFO    - Building initial testsuite list...
INFO    - Writing JSON report /home/nashif/zephyrproject/zephyr/twister-out/testplan.json
INFO    - JOBS: 20
INFO    - Adding tasks to the queue...
INFO    - Added initial list of jobs to queue
INFO    - Total complete:    1/   1  100%  skipped:    0, failed:    0, error:    0
INFO    - 1 test scenarios (1 test instances) selected, 0 configurations skipped (0 by static filter, 0 at runtime).
INFO    - 1 of 1 test configurations passed (100.00%), 0 failed, 0 errored, 0 skipped with 0 warnings in 10.17 seconds
INFO    - In total 3 test cases were executed, 1 skipped on 1 out of total 675 platforms (0.15%)
INFO    - 1 test configurations executed on platforms, 0 test configurations were only built.
INFO    - Generating coverage files...
INFO    - Using gcov tool: /home/nashif/bin/zephyr-sdk-0.16.4/x86_64-zephyr-elf/bin/x86_64-zephyr-elf-gcov
INFO    - HTML report generated: /home/nashif/zephyrproject/zephyr/twister-out/coverage/index.html
INFO    - Saving reports...
INFO    - Writing JSON report /home/nashif/zephyrproject/zephyr/twister-out/twister.json
INFO    - Writing xunit report /home/nashif/zephyrproject/zephyr/twister-out/twister.xml...
INFO    - Writing xunit report /home/nashif/zephyrproject/zephyr/twister-out/twister_report.xml...
INFO    - Run completed

reopen with how you get the issue with the upstream tree please.


Data connector UI: record opened after selecting connector.

Hi,
I'm working on a custom power BI connector and am customizing the connector UI as described here https://docs.microsoft.com/en-us/power-query/handlingdocumentation using metadata.
I have an optional record type that holds an optional text type as a parameter.
When I select the connector and the UI pops up the record is not folded/collapsed and I immediately see the text (box).
Is there a way to make it so that after selecting the connector when the UI pops up the record is folded/collapsed and the user has to click on it to expand it and to see the text field?
When selecting the connector now:

Desired:

Many thanks!
Pieterjan

No, there is no way to control this today... but there is a backlog item tracking the feature request.
Side note - accepting arbitrary odbc connection string parameters potentially opens up a whole lot of security issues (depending on the driver), so be sure this is only done in a trusted environment. This would not be allowed in a Certified Connector, for example.

Thank you! I'll definitely keep that in mind.


Deprecate CompilerAnnotation

This is a follow-on to https://github.com/freechipsproject/firrtl/pull/1835 to fully deprecate CompilerAnnotation.
This does a couple of things:

The CompilerAnnotation$ companion object is changed to emit RunFirrtlTransformAnnotations instead of CompilerAnnotations.

This adds a ConvertCompilerAnnotation phase which is doing an explicit conversion of a CompilerAnnotation to a RunFirrtlTransformAnnotation. This differs from #1835 which relaxed support so that a RunFirrtlTransformAnnotation(_ <: Emitter) could substitute for a CompilerAnnotation. This PR goes one step further and forces internal phases to only understand transforms.

Better checks and warnings are now provided inside ConvertCompilerAnnotation. The check of a single compiler is migrated from Checks here. Additionally, if a CompilerAnnotation is converted, a verbose warning is printed telling you exactly how to replace your transform, e.g., you now get:

CompilerAnnotation is deprecated since FIRRTL 1.4.0. Please use 'RunFirrtlTransformAnnotation(new firrtl.HighFirrtlEmitter)' instead.

Note that you should only now get a warning if you actually use a CompilerAnnotation. Any use of -X will not produce an error.
Contributor Checklist

[nope] Did you add Scaladoc to every public function/method?
[n/a] Did you update the FIRRTL spec to include every new feature/behavior?
[x] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[x] Did you add text to be included in the Release Notes for this change?

Type of Improvement

bug fix

code refactoring

API Impact

None. Removes a warning that the user couldn't do anything to fix.
Backend Code Generation Impact

None.
Desired Merge Strategy

Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

None.
Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[x] Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

Did you make sure that specifying only -X without -E works? What stage will add the EmitCircuitAnnotation?

@ekiwi: firrtl.stage.phases.AddImplicitEmitter is what is taking care of this. Fortunately, your edits in your original PR are already handling this case nicely.
I added a test to FirrtlMainSpec to hit this in a follow-up commit.


HA AddOn: Dokumentation update

For the AddOn, we need a user documentation how to use it.
At least:

prerequisites for using this AddOn (link to HA description)
adding our AddOn Repro to the costumer installation
Update and rollback concept

I'll create a short one pager typically implemented in the documentation tab of the add-on. from there I would link to the full documentation.

describing options and giving examples.
describe typical scenario with "Mosquitto" add-on and "AdGuard Home" -add-on

closed with #245


feat: Adds video "How to use Custom Branding"

Adds documentation and video guide for "How to use Custom Branding"
Video link https://www.youtube.com/watch?v=E_4I0J-0u1k

@Pranay105 @jnikhila please review this 🙏

@megaconfidence can you pull the latest from main. we the video on another PR https://docs.appsmith.com/advanced-concepts/branding. maybe this should be moved a bit to the top?

@megaconfidence - We replaced the documentation video with the custom branding video because having both videos was like repetition, and it is already available on docs.appsmith.com. Please let me know if you have different views.

Thanks for letting me know @jnikhila . LGTM!


[Bug]: Dev workflow stuck at "starting up"

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Describe the bug and reproduction steps
I am trying to run the dev workflow, but it seems to be stuck on "starting up". I open the frontend but no logs are displayed and the "starting up" indicator never disappears from the interface. I'm not sure how to debug, but full logs are below.
OpenHands Installation
Development workflow
OpenHands Version
277d991b371aed03eb9831e6dd18d9d7516fb992
Operating System
MacOS
Logs, Errors, Screenshots, and Additional Context
$ make build; make run
Building project...
Checking dependencies...
Checking system...
macOS detected.
Checking Python installation...
Python 3.12.2 is already installed.
Checking npm installation...
npm 10.8.2 is already installed.
Checking Node.js installation...
Node.js 22.7.0 is already installed.
Checking Docker installation...
Docker version 27.0.3, build 7d4bcd8 is already installed.
Checking Poetry installation...
Poetry (version 1.8.3) is already installed.
Dependencies checked successfully.
Installing Python dependencies...
Defaulting TZ (timezone) to UTC
Using virtualenv: /Users/gneubig/Library/Caches/pypoetry/virtualenvs/openhands-ai-mHbwbJq6-py3.12
Installing chroma-hnswlib...
Requirement already satisfied: chroma-hnswlib in /Users/gneubig/Library/Caches/pypoetry/virtualenvs/openhands-ai-mHbwbJq6-py3.12/lib/python3.12/site-packages (0.7.6)
Requirement already satisfied: numpy in /Users/gneubig/Library/Caches/pypoetry/virtualenvs/openhands-ai-mHbwbJq6-py3.12/lib/python3.12/site-packages (from chroma-hnswlib) (1.26.4)
Installing dependencies from lock file

Package operations: 0 installs, 1 update, 0 removals

  - Updating anthropic (0.36.0 -> 0.36.1)

Installing the current project: openhands-ai (0.9.8)
Running playwright install --with-deps chromium...
Python dependencies installed successfully.
Setting up frontend environment...
Detect Node.js version...
Current Node.js version is 22.7.0, corepack is supported.
Installing frontend dependencies with npm...
npm warn deprecated<EMAIL_ADDRESS>This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated<EMAIL_ADDRESS>Use @eslint/config-array instead
npm warn deprecated<EMAIL_ADDRESS>Rimraf versions prior to v4 are no longer supported
npm warn deprecated<EMAIL_ADDRESS>Use @eslint/object-schema instead
npm warn deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported
npm warn deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported
npm warn deprecated<EMAIL_ADDRESS>This version is no longer supported. Please see https://eslint.org/version-support for other options.

><EMAIL_ADDRESS>prepare
> cd .. && husky frontend/.husky

added 1785 packages, and audited 1786 packages in 7s

400 packages are looking for funding
  run `npm fund` for details

10 low severity vulnerabilities

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.
Frontend dependencies installed successfully.
Installing pre-commit hooks...
pre-commit installed at .git/hooks/pre-commit
Pre-commit hooks installed successfully.
 Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
✓ built in 5.46s
vite v5.4.9 building SSR bundle for production...
✓ 312 modules transformed.
build/server/.vite/manifest.json                 0.90 kB
build/server/assets/Terminal-CGrrDQr5.css        4.64 kB
build/server/assets/server-build-DS022aAH.css  222.36 kB
build/server/index.js                            1.07 kB
build/server/assets/Terminal-ntxR_w_t.js         5.27 kB
build/server/assets/server-build-DPv-CDRe.js   347.03 kB

✓ 1 asset moved from Remix server build to client assets.
build/client/assets/server-build-DS022aAH.css

SPA Mode: index.html has been written to your build/client directory
✓ built in 1.07s
Build completed successfully.
Running the app...
Starting backend server...
Waiting for the backend to start...
INFO:     Started server process [42957]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:3000 (Press CTRL+C to quit)
Connection to localhost port 3000 [tcp/hbci] succeeded!
Backend started successfully.
Starting frontend with npm...

><EMAIL_ADDRESS>start
> npx sirv-cli build/client/ --single --port 3001

  Your application is ready~! 🚀

  - Local:      http://localhost:3001
  - Network:    Add `--host` to expose

────────────────── LOGS ──────────────────

Yep I can reproduce as well.

This is what I see in the mac terminal.

This should be fixed now!

Confirmed that it works for me too!


"include_symbols: false" has no effect

I have Fastfile like this
fastlane_version "2.23.0"

generated_fastfile_id "4f808bfa-3660-4ef1-8577-2324ec613b9c"

default_platform :ios

lane  :adhoc do

    # blabla

    gym(
        # blabla
        include_symbols:  false,
        # blabla
    )

end

I use this command to build adhoc ipa
fastlane adhoc
It generates ipa and dSYM file as well.

✅ fastlane environment ✅
Stack

Key
Value

OS
10.12.3

Ruby
2.2.4

Bundler?
false

Git
git version 2.10.1 (Apple Git-78)

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.12.3 (16D32)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
true

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.2.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
`./fastlane/Fastfile`
fastlane_version "2.23.0"
generated_fastfile_id "4f808bfa-3660-4ef1-8577-2324ec613b9c"
default_platform :ios

lane  :adhoc do

    # build your iOS app
    gym(
        scheme:           "GymTest",
        clean:            true,
        output_directory: "~/Desktop/build",
        export_method:    "ad-hoc",
        include_symbols:  false
    )

end

`./fastlane/Appfile`
app_identifier "" # The bundle identifier of your app
apple_id "" # Your Apple email address

team_id "[[DEV_PORTAL_TEAM_ID]]"  # Developer Portal Team ID

# you can even provide different app identifiers, Apple IDs and team names per lane:
# More information: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Appfile.md

fastlane gems

Gem
Version
Update-Status

fastlane
2.23.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

CFPropertyList
2.3.5

activesupport
<IP_ADDRESS>

addressable
2.5.0

babosa
1.0.2

bigdecimal
1.2.6

bundler
1.14.3

claide
1.0.1

colored
1.2

commander
4.4.3

commander-fastlane
4.4.4

domain_name
0.5.20161129

dotenv
2.2.0

excon
0.54.0

faraday
0.11.0

faraday-cookie_jar
0.0.6

faraday_middleware
<IP_ADDRESS>

fastimage
2.0.1

gh_inspector
1.0.3

google-api-client
0.9.26

googleauth
0.5.1

highline
1.7.8

http-cookie
1.0.3

httpclient
2.8.3

hurley
0.2

i18n
0.7.0

io-console
0.4.3

json
1.8.1

jwt
1.5.6

libxml-ruby
2.9.0

little-plugger
1.1.4

logging
2.1.0

memoist
0.15.0

mime-types
3.1

mime-types-data
3.2016.0521

mini_magick
4.5.1

minitest
5.4.3

multi_json
1.12.1

multi_xml
0.6.0

multipart-post
2.0.0

nanaimo
0.2.3

nokogiri
1.5.6

os
0.9.6

plist
3.2.0

power_assert
0.2.2

psych
2.0.8

public_suffix
2.0.5

rake
10.4.2

rdoc
4.2.0

representable
2.3.0

retriable
2.1.0

rouge
1.11.1

rubygems-update
2.5.2

rubyzip
1.2.0

security
0.1.3

signet
0.7.3

slack-notifier
1.5.1

sqlite3
1.3.13

terminal-notifier
1.7.1

terminal-table
1.7.3

test-unit
3.0.8

thread_safe
0.3.5

tty-screen
0.5.0

tzinfo
1.2.2

uber
0.0.15

unf
0.1.4

unf_ext
<IP_ADDRESS>

unicode-display_width
1.1.3

word_wrap
1.0.0

xcodeproj
1.4.2

xcpretty
0.2.4

xcpretty-travis-formatter
0.0.4

generated on: 2017-03-26

The flag means it doesn't contain the symbols inside the ipa file. It will still generate the dSYM file locally. There is currently no way to disable that as far as I know, but you can use the clean_build_artifacts action for after you finished uploading the binary file 👍

Try putting it in a string include_symbols: 'false'?  Every so often I find I need to string a Boolean parameter.
Though krausefx is most likely right.

@PetrosIchor I'm pretty sure the boolean parameter shouldn't be passed as string

@AntonBelousov
include_symbols maps directly to uploadSymbols of xcodebuild -exportArchive command.
According to xcodebuild -h output:
	uploadBitcode : Bool

		For App Store exports, should the package include bitcode? Defaults to YES.

	uploadSymbols : Bool

		For App Store exports, should the package include symbols? Defaults to YES.

The main thing here is For App Store exports, which makes me think this flag should have no effect for "ad-hoc" exports.
Does it generate dSYM files outside the ipa?
In that case it is normal. The dSYM option is controlled DEBUG_INFORMATION_FORMAT build setting, it's not part of export command:

include_symbols tells xcodebuild whether debug symbols should or should not be included inside App Store ipa.
Why would you want to get rid of dSYMs though?
Is it the issue with free space on the build server?
You may need those when you get crashes in ad-hoc build and you'd want to symbolicate the crashes.

Why would you want to get rid of dSYMs though?
Is it the issue with free space on the build server?

Actually I'm ok with dSYM files but it was not obvious for me - how this parameter worked


Errors in CI on Build

Solution to issue cannot be found in the documentation.

[x] I checked the documentation.

Issue
I haven't had time to look into this, but builds have been failing recently.
It seem to fail on Run docker build with the following error:

  File "/opt/conda/lib/python3.12/site-packages/conda_build/utils.py", line 404, in check_call_env
    return _func_defaulting_env_to_os_environ("call", *popenargs, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.12/site-packages/conda_build/utils.py", line 380, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['/bin/bash', '-o', 'errexit', '/home/conda/feedstock_root/build_artifacts/dataclass-wizard_1731773831970/work/conda_build.sh']' returned non-zero exit status 2.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/conda/bin/conda-build", line 11, in <module>
    sys.exit(execute())
             ^^^^^^^^^
  File "/opt/conda/lib/python3.12/site-packages/conda_build/cli/main_build.py", line 589, in execute
    api.build(
  File "/opt/conda/lib/python3.12/site-packages/conda_build/api.py", line 209, in build
    return build_tree(
           ^^^^^^^^^^^
  File "/opt/conda/lib/python3.12/site-packages/conda_build/build.py", line 3655, in build_tree
    packages_from_this = build(
                         ^^^^^^
  File "/opt/conda/lib/python3.12/site-packages/conda_build/build.py", line 2563, in build
    raise BuildScriptException(str(exc), caused_by=exc) from exc
conda_build.exceptions.BuildScriptException: Command '['/bin/bash', '-o', 'errexit', '/home/conda/feedstock_root/build_artifacts/dataclass-wizard_1731773831970/work/conda_build.sh']' returned non-zero exit status 2.

##[error]Bash exited with code '1'.

Any help or assistance would be appreciated. I've checked my meta/recipe.yml and it seems OK, not any major changes recently.
Installed packages
n/a

Environment info
n/a

This is done.
I need to get better at Anaconda. Upskill when time allows! 😅


Error trying to run karma programmatically

I'm trying to run karma from my Gulpfile, the task is basically this:
var karma = require('karma').server;
gulp.task('test', function(done) {
  karma.start({configFile: path.resolve('karma.conf.js')}, done);
});

My karma config file: https://gist.github.com/thiagopnts/4584193678eea0431689
When I run gulp test I get this error:
[23:36:00] Starting 'test'...
WARN [plugin]: Error during loading /Users/thiago/code/player3/node_modules/karma-traceur-preprocessor plugin:
  Reflect is not defined
[23:36:01] 'test' errored after 735 ms
[23:36:01] Error: No provider for framework:traceur! (Resolving: framework:traceur)
    at error (/Users/thiago/code/player3/node_modules/karma/node_modules/di/lib/injector.js:22:68)
    at Object.parent.get (/Users/thiago/code/player3/node_modules/karma/node_modules/di/lib/injector.js:9:13)
    at get (/Users/thiago/code/player3/node_modules/karma/node_modules/di/lib/injector.js:54:19)
    at /Users/thiago/code/player3/node_modules/karma/lib/server.js:31:14
    at Array.forEach (native)
    at start (/Users/thiago/code/player3/node_modules/karma/lib/server.js:30:21)
    at invoke (/Users/thiago/code/player3/node_modules/karma/node_modules/di/lib/injector.js:75:15)
    at Object.exports.start (/Users/thiago/code/player3/node_modules/karma/lib/server.js:306:12)
    at Gulp.<anonymous> (/Users/thiago/code/    at Gulp.<anonymous> (/Us      at Gulp.<anonymous> (/Users/thiago/code/
at Gulp.<anonymous>
at Gulp.<anonymous> (/Users/thiago/code/)

$ karma start runs just fine. I'm not sure if this is a problem of karma-traceur-preprocessor plugin, traceur-compiler or from karma itself. It occurs when the plugin tries to require('traceur'). Any ideas?

For questions and support please use the mailing list or Gitter.
The issue tracker is for bug reports and feature discussions only.


Replying to third-party platform using Teams Microsoft Graph after completed migration

I have created team and imported messaged in Migration mode as instructed in Here using Microsoft Graph. After completing the migration and started with the teams, I am not able to reply to earlier messages. On exploring the API request by Teams web client I noticed that it fails to locate the resource for POST method. Error in Console:
message: "{"subCode":"PostNotFound","details":"Post does not exist in the thread.","errorCode":null,"errorSubCode":null}",
errorDescription: "PostNotFound-Post does not exist in the thread."

@kristiyandd - Thanks for reporting your issue. We will test this and update you soon.

Hello @kristiyandd - Sorry for delay in response. We are checking on this issue and let you know the updates soon.

@kristiyandd - We have followed the below document and tested all the steps but after completed migration we are not able to see the migrated team in Teams. Is there any step we are missing here?

@Nivedipa-MSFT - Hello, I tested again by following all the steps and again it returns the same error.

@kristiyandd - We have send the messages for different dates. For year 2022 and 2023 we are not getting this error but for year 2020 we are unable to send the reply.

We have raised a bug for the same and we will let you know once we get any updates on it.

@Nivedipa-MSFT If I migrate a channel for 15 days back I also get the same error, if they are earlier there is no problem. I mean if I set "createdDateTime": "2023-04-19T11:22:17.043Z" then return failed send, after "createdDateTime": "2023-04-20T11:22:17.043Z" then they are fine.

Any progress on this issue?

@kristiyandd - We are checking the status of the bug with the engineering team, and we will let you know if we get any updates from them.


I updated instructions for experience section of readme

This pr fixes #1147
Summary: This pr add instructions for the experience section of the readme
Files Changed: readme.md

When was this issue created?


code.tizen.org - example - Date Picker/Time Picker - after set opens blank page

Visit:
https://code.tizen.org/demos?path=1.0%2Fexamples%2Fwearable%2FUIComponents%2Fcontents%2Fcontrols%2Fdate-picker.html
Set date
Click Set
Observe:
Blank page is shown

also reproducible for time picker
https://code.tizen.org/demos?path=1.0%2Fexamples%2Fwearable%2FUIComponents%2Fcontents%2Fcontrols%2Ftime-picker.html

Waiting for samples update


Add node-tap support

It would be nice to be able to use Stryker with node-tap test framework.

Hi! How does node-tap differ from tape?

@simondel I guess they are unrelated projects. The only thing that is common is that they both use the Test Anything Protocol (TAP) to produce output.

Just a heads up. Stryker recently released with the 'command' test runner. This is also the default if you don't specify a test runner. It just runs your npm test command. Exit code 0 means the tests succeeded. Exit code != 0 means failed. @EvgenyOrekhov would that work for you?

@nicojs Sorry, I don't use node-tap or Stryker anymore.

Ok, please don't forget about us. 👋

I want to try to implement this

Thanks for the patience everyone, Node Tap support is released in v7 ♥, see docs here: https://stryker-mutator.io/docs/stryker-js/tap-runner/

Blog article here: https://stryker-mutator.io/blog/announcing-stryker-js-7/


Remove max_time parameter from Runner

Closes #32

Done. Any deprecation policy for the future? E.g. warnings.warn

Done

Thanks, I merged your PR.

Any deprecation policy for the future? E.g. warnings.warn

I don't know. We can discuss that later, if we have something to deprecate :-)


Lwd conf

Codecov Report
Base: 59.32% // Head: 59.32% // No change to project coverage :thumbsup:

Coverage data is based on head (d5c62c9) compared to base (293fad6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #214   +/-   ##
=======================================
  Coverage   59.32%   59.32%
=======================================
  Files          28       28
  Lines        3995     3995
=======================================
  Hits         2370     2370
  Misses       1625     1625

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


CT static API personality

Implements https://c2sp.org/static-ct-api
Pieces of work:

[ ] port certificate-transparency-go CTFE to this repo, removing all the things we don't need anymore, and connect it to GCP Tessera to write tiles (no checkpoint at this stage)

[x] break ground with an initial port
[x] move more things over to drop dependency on non X509/TLS stuff from github.com/google/certificate-transparency-go (for instance github.com/google/certificate-transparency-go/trillian/util, github.com/google/certificate-transparency-go/trillian/testdata)
[ ] double check that tiles and leaf are compliant with https://c2sp.org/static-ct-api

[x] Fix Data Type
[x] Store fingerprints chain in leaves

[ ] have a look through all the old TODOs I ported over
[x] move over handlers_test.go
[x] add README and/or docker config to generate proto and mocks

[x] add a signer option
[x] design+build a chain storage service (see what we can re-use from Roger's recent work on certificate-transparengy-go CTFE): see #132
[ ] design+build deduplication: ongoing
[x] design+modify configuration pipeline if need be: we've decided to stick to flags
[x] quota system: we've decided not rely on Tessera's pushbacks to start with. We'll add a quota system later if needed. See #186
[ ] decide how we handle errors, and which one we pass to clients
[x] migrate codebase to a different repo
[ ] load test with real world CT data
[ ] deployment instructions

What's the difference between this issue and #41 ?

I think #41 is Tessera APIs which enable a CT Static API personality to be built, and this one is the task of actually building such a personality.

I'm going to close this issue to migrate it under https://github.com/transparency-dev/static-ct, where the SCTFE now lives.

https://github.com/transparency-dev/static-ct/issues/10


Update to SDK version 12.1 and microhttpd >= 0.9.71

Tested on ubuntu 21.04 and debian bullseye

Aw, sweet! Will test & review later today!

Just checked, buster / 20.04 have an to old microhttp versions, we need a switch in the code. trying to find a buster system to test this on

i was pointed to https://github.com/voc/decklink-debugger/issues/9 so we need to test sie on a duplex card i guess.

With 0c16b85 i guess we can now merge it an make a new release. Thanks @derchrisuk !!

@MaZderMind i guess now we can merge this and continue in master / new feature branches.

@derpeter I'm so sorry. I'm do deep into family things that ended up taking up way more time and energy. I wanted to grab zwo Cameras and test out the former "Duplex"-Feature of my Duo2 but didn't come around getting the cameras or even compiling the code. I'm deeply sorry, but I don't think I'll find the time or enegery to it in the next weeks either. Sad things to organize…

don't worry and thanks for the update.

I did a test with Duplex enabled on a Duo2.
But it will crash the debugger, claiming that it failed to enable video input.
Here is a debug log: https://p.rrbone.net/?45c68f6d5279273f#75HPTqLEAgW11BJJrDrfZ2GTUUh3WvQ7bkk5dSNYbTiY

I just used this branch to creata a docker image with the Blackmagic DeckLink SDK 12.8 and it works fine for me. From my limited testing I could not reproduce @derchrisuk his issue
@derpeter Thanks for sharing this branch!

@frankforpresident your welcome. If someone with a one of the duplex cards at hand is could look into the remaining issue we can merge this into master i guess


Primary navigation styling is inconsistent with design intent

Primary navigation items should not have icons and should be styled according to these UI mockups.  Not hover and selected states for secondary icons within the Admin section.
See https://redhat.invisionapp.com/share/9XA4GEF4V  for high-fidelity UI mockup.

Thank you for design. I've put there some comments which are unrelated to navigation, sorry about that. Could you please recommend me better design document for comments like that?

@mkudlej Looks like all of your comments relate to the dashboard.  We do have a separate design document to address dashboard designs here: https://redhat.invisionapp.com/share/589XIRJBW  Please feel free to add your comments there and we will address them.

Pull request for this issue has been sent. #158

Merged in master. Hence closing this issue.


about Transform3D

Hi, thanks for sharing your experiments. I want to know that for 3D data, only custom Transform3D seems to be used in the code. Did you not try other transforms operations in the experiment, such as random cropping and random rotation? I'm trying to experiment with 3D medminist, can you give me some advice on transforms, torchvision.transforms seems to have no way to use it directly, Looking forward to your reply, thank you

In our benchmark experiments, we haven't tested many 3D data transformations, but you are free to do so for sure.
There have already been many existing medical imaging libraries, for instance you may check MONAI, or implement your own.
Jiancheng


⚠ ClamAV has degraded performance

In 78f38ee, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 199 ms

Resolved: ClamAV performance has improved in e909992.


Does authorizationType require a switch self?

I'm using the brand new 9.0.0 - thanks!
Using the example code from here:

https://github.com/Moya/Moya/blob/master/docs/Authentication.md
    var authorizationType: AuthorizationType {
    case targetThatNeedsBearerAuth:
        return .bearer
    case targetThatNeedsBasicAuth:
        return .basic
    case targetDoesNotNeedAuth:
        return .none
    }

Does the authorizationType var need a switch self  and a period in front of the case like so:
    var authorizationType: AuthorizationType {
        switch self {
        case .targetThatNeedsBearerAuth:
            return .bearer
        case .targetThatNeedsBasicAuth:
            return .basic
        case .targetDoesNotNeedAuth:
            return .none
        }
    }

As I am otherwise getting an error that a 'case' label can only appear inside a 'switch' statement.

Yes, it does. Only if all paths have the same AuthorizationType, you could return immediately.

Oh, seems like we have a missing switch in the documentation, nice catch @arjunnaha! Would you be up for fixing that one in a PR? 😄

This is exactly what I am doing, as all my endpoints use .basic. Does that mean I can just use:
    var authorizationType: AuthorizationType {
        return .basic
    }

@sunshinejr Sure can do!

Doh 😅 Sorry @arjunnaha can't believe I missed that. Thank you!!

Oh, and to answer the question, @arjunnaha: yes, you can just return .basic if you are using Basic everywhere, no need for a switch then 👍

@arjunnaha be aware the compiler won't warn you when adding a new endpoint that might using something other than .basic though!


Parse and Resolve

Move the parse functionality to ERMrestJS and common get requests that are made to retrieve the catalog, schema, and table.

This issue is related to PR #88.

@robes merged the code for PR #88, closing this issue.


The editor should warn if a lexical identifier is taking precedence over an inherited one

This issue was originally filed by<EMAIL_ADDRESS>
http://www.dartlang.org/docs/spec/latest/dart-language-specification.html
Issue/feedback:
    The interaction of lexical scoping and inheritance can be pretty surprising and well, nasty. It's also burdensome to have to review the top level functions of every library you import to see if it happens to contain a definition that will overwrite one you have somewhere in your inheritance hierarchy.  The section in the language spec on scoping and inheritance suggests warning users when this occurs.

Dart is now (more) strongly typed, so hitting the "wrong" identifier is very likely to be immediately visible.
The analyzer could still recognize when a lexical name gives the wrong type, and an instance member with the same name could (perhaps) have been correct, and suggest using this.foo instead of foo.


Add database to bot

Finally we have a database in our bot! Now we can use it in the modules to store data and create cool commands.

Something went wrong with this PR, I will close it and open a new one 😀


Removes project file

At the moment it is not possible to remove the project file because SPM does not support Unit Testing of Packages which have UIKit decencies


Add Dockerfile

Add Dockerfile to deploy this script in a container.

Waiting on pull request from @grogsaxle


Route Improvements

Make sure that Routes on the iOS app reflect the active status flag (currently displaying inactive routes)
When you select a Route from the schedule take them to a preview of the route with a header which displays the route name date and time selected; then draw the actual route on the map to give an example of what that route looks like

Guys, a local radio station would like to do an interview about the Trolley Tracker.  Are any of you available next Tuesday morning (2/2)? I can give them Greenlink's perspective but I think it would be interesting to have someone from Code for Greenville on there, as well.  Anyway, let me know when you have a chance. I think their studio is near Bob Jones University on Wade Hampton.

I nominate @agautsc, he has the prettiest voice.

@dacohenii and I work down the street from there.  I nominate @agautsc or @jeremywight.
What radio station is covering it?

103.3 Earth FM

@jeremywight are you able to do it? If not I can, but I've been interviewed a couple times for the trolley tracker and a different voice might be nice.
PS: The Bitmoji plugin now shows up as an option in the GitHub comment.

I could definitely jump in. Do we know what time?
On Wed, Jan 27, 2016 at 7:59 AM, greenlinktransit<EMAIL_ADDRESS>wrote:

103.3 Earth FM
—
Reply to this email directly or view it on GitHub
https://github.com/codeforgreenville/trolley-tracker/issues/128#issuecomment-175606516
.

Depends on our availability.  What does your schedule look like?

Best would be before 930am as I have my morning Standup at 10am, but if
need be I could move it @greenlinktransit
On Wed, Jan 27, 2016 at 1:57 PM, greenlinktransit<EMAIL_ADDRESS>wrote:

Depends on our availability. What does your schedule look like?
—
Reply to this email directly or view it on GitHub
https://github.com/codeforgreenville/trolley-tracker/issues/128#issuecomment-175793029
.

@jeremywight how does 8:30 AM on Tuesday sound? Shouldn't take more than 30 mins

https://github.com/codeforgreenville/trolley-tracker-ios-client/issues/17

Works for me @greenlinktransit

@jeremywight see you there

Jeremy - the address is 920 Wade Hampton


Remove blank in the sidebar for headings linking to other pages

When I use
## Getting Started

### [Snip](/Getting-Started#snip)

an unwanted blank line appears in the side bar:

It corresponds to , which I think should be removed.

Also, I am wondering if there is any way that I can hide certain headings in the content but keep them visible in the sidebar. The reason is that I have multiple pages and I would like to keep a consistent sidebar for all pages, while the content of each page stays clean and will not show the headings linking to other pages.

It's just a toc, I do not think it can be used as navigation. Maybe you can override style.
If only less navigation, you can refer to https://qingwei-li.github.io/docsify/zh-cn#导航. You have any ideas?

Maybe we can support custom sidebar, what do you think? such as

      Getting Started

Snip

Or global variables

For now, we can custom sidebar, such as

If you approve the feature, I'll publish it in next minor version. 😄

I think the current top navbar is very good for language switching. Adding other menu items seems not suitable. However, it would be very nice it if the drop-down list feature can be added on it.
Oh, while I'm writing this, I see your updates...
Awesome! Your solution can offer me the desired navigation and also keep my .md files clean (no adding titles of other pages)! :thumbsup:

The dropdown list can be achieved purely through CSS, maybe  the users to achieve better.

OK. I will try that. Thanks!


PoC: use v1beta1 in operator logic

This PR

adds this new feature

Related Issues

Fixes #352
Notes

Follow-up Tasks

How to test

I guess we can close this in favor of: https://github.com/open-feature/open-feature-operator/pull/539?

Sure!


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-07-05)
Features

add release please (0d5e76a)
init (fcec477)
init (bd6a124)
rename to manager (d1f396e)

Bug Fixes

change package.json module (d21d2ff)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.0.0
:sunflower:


Fix for Enum thunks in CPAOT per GitHub issue #6315

This change implements the fixes described by Michal in the
quoted issue and, in doing so, fixes two issues caused by
invalid casts of the enum helpers in CPAOT build of CoreCLR
framework.
Thanks
Tomas

Hmm, from your description I originally had an impression that this an independent "improvement"; as it's moreover something like a port from CoreCLR, I would probably prefer to leave that for a separate change to keep history cleaner. If I misunderstood you and the CoreCLR change is required to make Enum handling fully function in CPAOT, I should definitely fix this as part of this change.
So far I only know that two more CoreCLR framework assemblies compile, I don't yet have the complete Pri#0 results. I should also run the Pri#0 tests both with and without CPAOT framework because, as I've spent the last couple of days with my futile efforts to support VS 2019 in CoreRT, I haven't run the Pri#0 suite in a while and I need the most recent readings to be able to meaningfully compare the two numbers.

Hmm, from your description I originally had an impression that this an independent "improvement"

Yup, it's independent, that's why I signed off on this as-is. It's just an easy thing to forget porting.
But I guess we'll need to come up with a strategy for finding missed perf improvements compared to crossgen anyway and this is going to show up then.


README instructions may be overly-specific about python executable

Current README instructions says:

The currently supported Python versions for pyxform are 3.7, 3.8 and 3.9.

and then later:
/usr/local/bin/python3.8 -m venv venv

and
/usr/local/bin/python3.8 -m venv pyxform-release

The latter examples seem overly-specific, and there are various other code samples which reference the python executable as simply python.
Is there something specific to using /usr/local/bin/python3.8, or could these be replaced with python?

That annoyed me as well the other day. Should just be python!

It's that way mainly because pyxform supports specific python versions. Also, my (somewhat old) dev box has system python resolve to v2.7.5 and I've got python3.6, python3.7, python3.8, python3.9 binaries under /usr/local/bin.
After activating a virtual environment, it's possible to use just python and it resolves to the version that the venv was created with. So specifying the version like this is only a thing when creating a virtualenv for the first time. Once that's done you can henceforth write source ./venv/bin/activate then python ....


Detect and give good error message when calling Application.argument() in constructor

Haven't tried it yet, but likely to work...
https://github.com/Telenav/kivakit/pull/120


Snowflake | Optimize Snowflake tag_references for Snowflake Ingestion

Affected module
Does it impact the UI, backend or Ingestion Framework?
Ingestion Framework
Describe the bug
A clear and concise description of what the bug is.
Snowflake Ingestion pipeline seem to be running the query for tag_references multiple times for a specific table.
To Reproduce

Run ingestion for Snowflake on 0.10.1.dev.0 with tag_references
Notice the same query for extracting tag_references running multiple times

Screenshots or steps to reproduce
NA
Expected behavior
A clear and concise description of what you expected to happen.
Extract tag_references from only 1 metadata query per table.
Version:

OS: [e.g. iOS]
Python version:
OpenMetadata version: [e.g. 0.8]
OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]
metadata, version metadata <IP_ADDRESS>.dev1 from /usr/local/lib/python3.9 (python 3.9)

Additional context
Add any other context about the problem here.
NA

@harshach @ayush-shah Would we be able to get this on 0.11? 🙇

closed by https://github.com/open-metadata/OpenMetadata/pull/5376

@sidhreddy this will be part of 0.11. Thanks for reporting!


Front Page displays in Reading Settings

Hi guys,
The reading settings page doesn't have Front page displays section.
I thought it's kind of standard feature.
What do you think?
Thanks.

@idpokute That would indeed be weird. Can you send a screenshot of what you mean. It is indeed a standard feature.

@JPOak Sorry, it was my mistake. I didn't have any page when I tested it.


CLI converter stops in case of damaged diagrams

Describe the bug
If the CLI converter converts more than one diagram from the process engine and one of the diagram results to an issue, you will get nothing
Steps to reproduce

create two diagrams without a name
Convert them with the CLI converter
an error occurred and nothing gets converted.

Expected Behaviour
At least the successful converted diagrams should be written to the disk.
The faulty diagram should be mentioned in the output.
Library version
egal
Camunda version
egal
Camunda Distribution
Tomcat
Other Camunda distribution
No response

I guess this is something we didn't have a test for (yet).


Main page "responsive" design: keep heading on screen during vertical scroll

If possible with modest effort, it would be nice if the "Name | Value | Units | Fixed | Min | Max" heading would stay on screen when scrolling vertically.

At this time there is nothing to do with this issue since it all fits on one page, and there is no scrolling. Assigning to milestone unassigned/future. When we get to Springs then this will be required.


HDFS-16869 Fail to start NameNode when replay editlog onwing to  0 size of clientId or callId recorded in editlog

We first encouter this issue in Hadoop 3.3.1 version when we are rollingUpgrade from 3.1.1 to 3.3.1, which may cause NameNode start failure but just occasionally not everytime.
The root cause for why 0 size of clientId happened here is still under investigating.
So here we add a protection judge to exclude 0 size of clientId from being added into cache.

We first encouter this issue in Hadoop 3.3.1 version when we are rollingUpgrade from 3.1.1 to 3.3.1, which may cause NameNode start failure but just occasionally not everytime.

Thank you very much for your contribution, reporting this issue, but can you explain why this modification solves the issue?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 10s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 11s

trunk passed

+1 :green_heart:
compile
25m 44s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
22m 13s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 39s

trunk passed

-1 :x:
javadoc
1m  9s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 46s

trunk passed

+1 :green_heart:
shadedclient
25m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  2s

the patch passed

+1 :green_heart:
compile
25m 12s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
25m 12s

the patch passed

+1 :green_heart:
compile
22m 13s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
22m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 1 new + 7 unchanged - 0 fixed = 8 total (was 7)

+1 :green_heart:
mvnsite
1m 35s

the patch passed

-1 :x:
javadoc
0m 59s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 43s

the patch passed

+1 :green_heart:
shadedclient
25m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 25s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

222m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5235/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5235

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 604a53f2d73d 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8ce1ef6d3d45ed2c9d2eba5ba1146c13ac392455

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5235/1/testReport/

Max. process+thread count
2840 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5235/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Support postgres NUMERIC type fields

Forgive this question if it makes no sense but I am using this package to export a sample dataset and then I want to convert it to an apache arrow format using the library parquet2arrow.
When I convert the file, I get an error saying that it can't find the Arrow schema, which is a little weird.
Error: Failed to get Arrow schema from Parquet

Caused by:
    Arrow: Unable to convert parquet BYTE_ARRAY logical type Some(DECIMAL(DecimalType { scale: 18, precision: 38 })) or converted type DECIMAL

The error comes from this line.
I've made a reproduction here: https://github.com/mhkeller/convert-parquet-repro
When I read the parquet file in Tad, it appears just fine, but I'm wondering if the arrow conversion needs additional information that could be included by this package when the file is written.
I saw this issue but I'm not sure why such a simple data file would not yet be supported so I have a feeling that isn't the main issue. The types in the iris file are fairly basic.
Thanks for the help.

I'd say the problem is that pg2parquet always writes decimals as a fix_len_byte_array parquet type, even if the data would fit into Int64 or Int32. That was easier to implement, as I can write all precisions as single data type, and it was supported by the tools that I tried to use. I'll add support for writing decimals as Int64 for better compatibility (it should also be more efficient). You'll then have to reduce the precision, the default is 128 bit AFAIK.
In the meantime, you can convert the numeric columns to float64 (I think it's called float8 in postgres, for example select value::float8 from my_table)

I think I get it. So the issue is that I have these values stored as postgres NUMERIC type. If I export them as real or double precision, the file converts properly. So what you're saying is for postgres decimal and numeric types, you'll change it so that they export to a parquet int64 type, which should be easier to convert. I imagine you'll add this to the readme but in what scenarios would the conversion lead to a data loss?

I have release new version (0.1.0-beta.7) which should fix the issue. If you set the --decimal-precision to a value lower than 19, pg2parquet will serialize it as Int64 which datafusion should support. For example --decimal-precision=18 --decimal-scale=9 is a reasonable setting.
I have also added another option --numeric-handling. That can be set to double to serialize all numerics as Float64, which is generally well supported. That might lead to some loss of precision, you can assume that Float64 has precision of about 14 decimal digits. The main advantage is that scaling is adaptive, so you never loose too much precision (while the decimal would round 0.0000000000000000000000000000000000000001 to zero, float will preserve the small value). If you are then loading the data into Javascript number, you are converting it to Float64 anyway and the loss of precision is irrelevant.
Last option is to use --numeric-handling=string, that never looses precision, but it's harder to do arithmetics on it.

Thanks for your work on this! I'll give the new version a try!

Glad to help, let me know how it went. I'm now reconsidering which of these options should be the default. Float64 seems like the most universal choice, while String would be the safest way in terms of loss of precision :thinking: I'd prioritize compatibility and ease of use - this tool is for exports, not backups (at least I hope I'm not responsible for some broken backup :sweat_smile:)

Sorry for the delay in trying the new version. I just tried it and I get this error
Schema: root
 * OPTIONAL sepal_length: BYTE_ARRAY (Decimal { scale: 18, precision: 38 } precision: 38 scale: 18)
 * OPTIONAL sepal_width: DOUBLE
 * OPTIONAL petal_length: DOUBLE
 * OPTIONAL petal_width: DOUBLE
 * OPTIONAL species: BYTE_ARRAY (UTF8)
Wrote 150 rows, 7550 bytes of raw data in 1 groups
Error: Failed to get Arrow schema from Parquet

Caused by:
    Arrow: Unable to convert parquet BYTE_ARRAY logical type Some(DECIMAL(DecimalType { scale: 18, precision: 38 })) or converted type DECIMAL

I also tried --decimal-precision=18 --decimal-scale=9 but I get very large numbers. Is this by design and I have to handle the conversion elsewhere?

No, you should see a decimal number. Although, internally it is really stored as an integer with "shifted" decimal point by 9 digits. I tried it out, and it works for me (pg2parquet -> parquet2arrow -> pyarrow). I think it's most likely a bug/unsupported feature in the Arrow library you use - it loads the integer number without understanding the metadata saying it's actually a decimal.
However, if you want to, we can rule out the possibility of pg2parquet misbehaving in your environment. This file: testtable.zip contains a parquet and an arrow file which are "correct" (I hope, it works in pyarrow at least). Could you try to load it into your arrow loader to see if it indeed doesn't support the decimals?

edit: Just tried this using --numeric-handling double and that works well.

Perfect, I guess I'll just make this the default, the decimals seem to be quite broken, and each time in a different way :facepalm:

When I load that arrow file I get this result so I think the issue is in the arrow viewer as you describe. Thanks for helping narrow it down!
I'll file an issue with that library once I get a clean reproduction for them.

To confirm, what are the expected values? Using the apache-arrow node library it's logging out as this:

Full script:
import { readFileSync } from 'fs';
import { tableFromIPC } from 'apache-arrow';

const arrow = readFileSync('testfile-prec.arrow');
const table = tableFromIPC(arrow);

console.table(table.toArray());

When I use pyarrow, I get:
In [1]: import pyarrow as pa

In [2]: f=pa.ipc.open_file("code/pg2parquet/cli/testfile-prec.arrow")

In [3]: all=f.read_all()

In [4]: all
Out[4]:
pyarrow.Table
id: int32
normal: decimal128(18, 9)
high_precision: decimal128(18, 9)
----
id: [[1,2]]
normal: [[1000.000100000,null]]
high_precision: [[1.000000000,null]]

DuckDB sees the same values (it can only read parquet, not arrow AFAIK)
D select * from 'code/pg2parquet/cli/testfile-prec.parquet';
┌───────┬────────────────┬────────────────┐
│  id   │     normal     │ high_precision │
│ int32 │ decimal(18,9)  │ decimal(18,9)  │
├───────┼────────────────┼────────────────┤
│     1 │ 1000.000100000 │    1.000000000 │
│     2 │                │                │
└───────┴────────────────┴────────────────┘


[8/?] - lncli+lnrpc: add support for creating unadvertised taproot channels

Change Description
Depends on https://github.com/lightningnetwork/lnd/pull/7346.
Only the last 3 commits are new.
In this PR, we update the CLI+RPC interface to allow new taproot channels to be created.
The next PR in this series will tackle the contract court and the sweeper, to enable full on chain interaction and HTLC resolution for the new channels.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[ ] Tests covering the positive and negative (error paths) are included.
[ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[ ] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[ ] Commits follow the Ideal Git Commit Structure.
[ ] Any new logging statements use an appropriate subsystem and logging level.
[ ]  There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our  Contribution Guidelines for further guidance.

@roasbeef, remember to re-request review from reviewers when ready

@yyforyongyu: review reminder
@ellemouton: review reminder
@roasbeef, remember to re-request review from reviewers when ready

@yyforyongyu: review reminder
@ellemouton: review reminder
@roasbeef, remember to re-request review from reviewers when ready

@yyforyongyu: review reminder
@ellemouton: review reminder
@roasbeef, remember to re-request review from reviewers when ready

@yyforyongyu: review reminder
@ellemouton: review reminder
@roasbeef, remember to re-request review from reviewers when ready

@yyforyongyu: review reminder
@roasbeef, remember to re-request review from reviewers when ready

@roasbeef, remember to re-request review from reviewers when ready

@roasbeef, remember to re-request review from reviewers when ready

@roasbeef, remember to re-request review from reviewers when ready

@roasbeef, remember to re-request review from reviewers when ready

@roasbeef, remember to re-request review from reviewers when ready

@roasbeef, remember to re-request review from reviewers when ready

@roasbeef, remember to re-request review from reviewers when ready

@roasbeef, remember to re-request review from reviewers when ready

@roasbeef, remember to re-request review from reviewers when ready


Wholistic examples

Problem
Currently, we only have limited number of test cases.
To be

We would better to have examples/ directly and show how to use the Beam Rust SDK in codes
Or doc-tests in lib.rs

I'll do it simultaneously with #6 because Beam's documentation system has a mechanism to extract code snippets into docs: https://github.com/laysakura/beam/blob/master/website/CONTRIBUTE.md#github-sample


InternalLogger: use application.version as package name key

What does this PR do?
The current key: application that we are using to send the application package name as an internal log attribute is clashing with the already existing facet application.version. We will not be able to create a facet from it and make it queryable so we decided to use a new key instead: application.name
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #571 (d443915) into release/1.9.0 (24b4905) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##             release/1.9.0     #571      +/-   ##
===================================================
- Coverage            88.68%   88.66%   -0.02%
- Complexity            1566     1573       +7
===================================================
  Files                  170      170
  Lines                 5211     5211
  Branches               628      628
===================================================
- Hits                  4621     4620       -1
- Misses                 352      355       +3
+ Partials               238      236       -2

Impacted Files
Coverage Δ
Complexity Δ

...android/monitoring/internal/InternalLogsFeature.kt
100.00% <100.00%> (ø)
5.00 <0.00> (ø)

...android/rum/internal/ndk/DatadogNdkCrashHandler.kt
75.00% <0.00%> (-6.58%)
28.00% <0.00%> (-1.00%)

...nternal/tracking/OreoFragmentLifecycleCallbacks.kt
89.74% <0.00%> (-5.13%)
14.00% <0.00%> (-1.00%)

.../android/error/internal/DatadogExceptionHandler.kt
91.30% <0.00%> (-4.35%)
10.00% <0.00%> (-1.00%)

...og/android/log/internal/logger/LogcatLogHandler.kt
93.02% <0.00%> (-2.33%)
17.00% <0.00%> (-1.00%)

...g/android/rum/internal/domain/scope/RumEventExt.kt
81.82% <0.00%> (-1.82%)
0.00% <0.00%> (ø%)

...ore/internal/constraints/DatadogDataConstraints.kt
92.31% <0.00%> (-1.28%)
25.00% <0.00%> (-1.00%)

.../android/tracing/internal/domain/SpanSerializer.kt
89.16% <0.00%> (+1.20%)
23.00% <0.00%> (+1.00%)

...c/main/kotlin/com/datadog/android/DatadogConfig.kt
94.47% <0.00%> (+1.51%)
12.00% <0.00%> (+3.00%)

...ernal/instrumentation/gestures/GesturesListener.kt
91.53% <0.00%> (+1.69%)
48.00% <0.00%> (+2.00%)

... and 5 more


⚠ Tukarcoid has degraded performance

In 430af61, Tukarcoid (https://tukar.co.id) experienced degraded performance:

HTTP code: 200
Response time: 2599 ms

Resolved: Tukarcoid performance has improved in 5767c1b after 22 minutes.


Properties should be inferred to exist on object after "in" expression

Suggestion

🔍 Search Terms

in any unknown property access exist infer
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
Accessing a property in a block where an in expression involving the property name is guaranteed to be true shouldn't give a typecheck error.
📃 Motivating Example

I have a function that checks any object for something.
I'd like to avoid using any as the argument type, because it completely disables typechecking.
If I do this:
function foo(x: object): boolean {
    if ("m" in x) {
        return typeof x.m === "object"
    } else {
        return false
    }
}

this is viewed as invalid by TS.
With this new feature, it's valid, because "m" in x being true guarantees that x.m won't fail.
💻 Use Cases

Type guards for some types that don't use any.

Duplicate of #21732.

@MartinJohns
Thanks!


[WIP] scheduler use spinlock

Signed-off-by: zhangjinpeng1987<EMAIL_ADDRESS>What have you changed? (mandatory)
Replace Mutex with Spinlock in scheduler.
What are the type of the changes? (mandatory)

Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

[ ] benchmark

Does this PR affect documentation (docs) or release note? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No

/release

/release

em, any big difference?
seem Mutex may still enter Spin phase at first.

As the micro benchmark shows the spinlock(https://docs.rs/spinlock/0.1.2/src/spinlock/lib.rs.html#1-191) is more light.
#[bench]
fn bench_spinlock(b: &mut Bencher) {
    let spinlock = Spinlock::new(0);
    b.iter(|| {
        let _x = spinlock.lock();
    });
}

#[bench]
fn bench_mutex(b: &mut Bencher) {
    let m = Mutex::new(0);
    b.iter(|| {
        let _x = m.lock().unwrap();
    });
}

jinpengdeMacBook-Pro:bench-spinlock-mutex jinpengzhang$ cargo bench
    Finished release [optimized] target(s) in 0.07s
     Running target/release/deps/bench_spinlock_mutex-b6f6145e45142f47

running 2 tests
test bench_mutex    ... bench:          28 ns/iter (+/- 1)
test bench_spinlock ... bench:          13 ns/iter (+/- 1)

test result: ok. 0 passed; 0 failed; 0 ignored; 2 measured; 0 filtered out

LGTM. But spinlock is a deprecated crate. spin should be used instead.

Could you compare with the Mutex from parking_lot?

I bench std::sync::Mutex, spinlock::Spinlock, spin::Mutex and parking_lot::Mutex, on CentOS the result is
running 4 tests
test bench_mutex       ... bench:          25 ns/iter (+/- 1)
test bench_parking_lot ... bench:          15 ns/iter (+/- 0)
test bench_spin_mutex  ... bench:          14 ns/iter (+/- 0)
test bench_spinlock    ... bench:          15 ns/iter (+/- 0)

On MacOS
test bench_mutex       ... bench:          29 ns/iter (+/- 16)
test bench_parking_lot ... bench:          13 ns/iter (+/- 2)
test bench_spin_mutex  ... bench:           9 ns/iter (+/- 1)
test bench_spinlock    ... bench:          13 ns/iter (+/- 2)

The spin::Mutex performs better than the others.

@breeswish @siddontang PTAL again.

/run-integration-tests


suggest renaming ionSideMenuContent element directive

<ion-side-menu-content> is nested inside <ion-side-menus>. Functionally this is logical (especially since the docs are helpful in explaining it) because <ion-side-menu-content> is paired with a sibling <ion-side-menu> element. In my opinion coming from someone who has just finished going through the guide on building the ToDo app, the naming of ionSideMenuContent is confusing because it implies that it would contain the content of a side menu when in fact it does not – it contains the content for the foreground container which can be slid to the side to reveal the side menu. I propose renaming ionSideMenuContent to ionForegroundContent.

Greetings @abcd-ca!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Synapse and new nodes / auto scaling

From my understanding so far, we need to restart synapse for it to be aware of new nodes that are added to a service specifically in the case of autoscaling.
Is there a way we can make synapse aware of new nodes so it automatically reloads ?

I assumed that the watchers will make synapse aware of new nodes and the config will be regenerated but that isn't what I'm seeing in practice.

 What was your mistake?

I had socket enabled but hadn't given permission to the user to write to the file.


Uniq on nested fields

Add support for nested fields to uniq proc, by comparing values using values.equal.
refs: #55

cc: @dmajda @demmer

+1 with the guard added, the cols/fields thing is up to you

@dmajda - added the guard, renamed cols to fields.

+1


Print the set feeRecipient on startup of the VC

Description
Print the set feeRecipient on startup of the VC for each validator
Example
info: Validator exists in beacon chain validatorIndex=xx, pubKey=0xxx, feeRecipient=Ox39
Related

https://discord.com/channels/593655374469660673/593655641445367808/1093177663511863356

Implementation started in https://github.com/ChainSafe/lodestar/pull/5239


formatted-404-page-#84

I formatted the 404 page a bit as suggested.

Resolves #84

Resolves #84


Bar chart only as tall as mixed chart

Hello,
I am having problems when rendering a mixed and a bar graph. The bar graph only shows the top half of the bars and the size of the bar depends on the size of the mixed graph.

Also the position in the div doesn't affect the issue. It always cuts off the same graph. And the order of rendering and updating doesn't matter.
The mixed graph also has different options from the other two graphs.

@plabet00 I can see there is some issue with your charts, but it's hard to understand what is the actual problem. Can you please elaborate and add some codepen demos?

@junedchhipa Unfortunately I cannot reproduce the bug in codepen(https://codepen.io/plab1/pen/BaNJVeR), but it persists in my local application. It seems that the leftmost graph is somehow affecting the draw height of the bars in the middle graph, however the height of the element is correct. It also seems that changing the type of the left chart doesn't have any effect and the bug doesn't appear on every refresh.

Can you try codesandbox? As the issue isn't present in the codepen, it's still difficult for me to trace.
Maybe some configuration in your application is interfering with the drawing?

Sorry for the late reply, I managed to reproduce the bug on codepen(https://codepen.io/plab1/pen/BaNJVeR). It seems that the declarations of some other charts cause the bug, but only if they are placed before the declarations of the charts which are drawn here. Keep in mind that it doesn't happen on every page load so you might have to refresh several times before the bug appears.


Power down amount is showing as 0 in wallet

Expected behavior
Steem Power in wallet should show correct amount of steem that will power down on the next power down date.
Actual behavior
Wallet is showing power down amount as 0 for the next power down date.
Prerequisite

You will need a profile with active power down.
The profile needs to be in last week of power down.

How To Re-produce
Go to following url to see the issue: https://busy.org/@mightypanda/transfers

Browser: Chrome Version 69.0.3497.100 (Official Build) (64-bit)
Operating system: OSX 10.11.6
Version: 2.5.6

Hi @mightypanda-x, although I'm not a busy member, I explain this, since I implemented this cool :) feature. Hope you liked it.
Anyway, this isn't a problem of busy, but a problem of an alternative API server that Busy's currently using.
I've tested with local dev server with Steemit official API server and it's working without any problem. If you're a dev, you can test this easily by following https://github.com/busyorg/busy/blob/develop/README.md
Busy is using a different API server (probably anyx) due to some problem with Steemit API server. While mostly compatible, alternative API sever returns incorrect values for certain fields from time to time, in this case powerdown info.
@Sekhmet Do you continue to use anyx or some alternative server? Can we switch back to api.steemit.com? It'd be great if there is an option for that. e.g., steempeak has an option for users to choose API server. Thanks.

If the api returns invalid value, then the system should handle that particular input.

again this is my personal opinion. in some sense it's already doing what you suggested, "the api returns invalid value, then the system should handle that particular input." It shows 0 when it returns 0. 0 is special value so that you can easily notice there's some problem. Any further treatment? Well based on my experience, Busy team is using their time on Busy3.0, so you can't expect much from them. That's why I actually fix and implemented some features that I really want.
@Sekhmet It might be good at least one server (either production or dev) use the official API server so that some advanced user can easily notice whether it's simply API server problem or not.


Add collaborators to this repo

Comment below to be added as a collaborator
We will all be using this repository today. Even though it's public right now, you will not be able to make changes until you're given the correct permissions. We've automated this process via the GitHub API. Once you comment, we will add you as a collaborator.
You'll start to receive a lot of emails. (❗) You can slow these down immediately by clicking the Unwatch button at the top of the page and selecting either the Participating and @mentions or Ignore option.

Hello!

Hello

I have added a comment.

Wazup?

Hello

Hola!

Reached this link

Hi!

Leaving a comment

Hi

helloooo

hello

Hey hey

Yup


fix: ensure that no index out of bounds read can happen when populating node modules

fixes #289

@viktoria-shirunova can you check if this fixes your issue? I couldn't reproduce it locally but from the stacktrace it seems like the issue was the access to index 0 when its size was 0.
We're now trying to be more graceful. I'm not sure if a selection model of null works though.

@makepanic I'm sorry, but still the version 2019.3.1-0 is published where the exception is reproduced and, unfortunately, I don't know how where from to take the plugin other way. For reproducing - you need to be sure that no node.js is installed on your computer. If any node.js is installed - no exception then.

I've tried to uninstall node.
The intellij node picker widget has a graceful fallback for me:

The stacktrace pointed to an issue where the module picker had no modules to pick from.
We removed the nullpointer exception but I can't get this to happen locally.