Allow configuring header_key_format for envoy-proxy

Describe the feature request
Allow configuring HeaderKeyFormat in envoy-proxy. See https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/protocol.proto#envoy-api-msg-core-http1protocoloptions and https://github.com/envoyproxy/envoy/pull/8499 for details
Describe alternatives you've considered
Forcing third party libs to expect lower-cased headers is, unfortunately, impossible at this time.
Additional context
Istio is using envoy-proxy to intercept http calls. When it does that it also brings all headers to lower-case. Some [legacy and not only] apps/libs don't expect that. The only workaround for now, seems like, is turn off istio side car proxy container.

What is the status of this issue? Is it possible to set header_key_format for instance through LUA?

I'm using 1.5.1, have applied an EnvoyFilter to a CLUSTER in the SIDECAR_INBOUND context, but when i watch the network traffic inside the actual service container (jira), it still has all lowercase headers.
EnvoyFilter:
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: fisher-jira-proper-case-headers-prod
  labels:
      app.kubernetes.io/instance: fisher-jira-prod
      app.kubernetes.io/managed-by: Tiller
      app.kubernetes.io/name: fisher-jira-proper-case-headers-prod
      helm.sh/chart: fisher-jira-1.3.25
spec:
  workloadSelector:
    labels:
      app: fisher-jira-prod
  configPatches:
  - applyTo: CLUSTER
    match:
      context: SIDECAR_INBOUND
      cluster:
        name: "inbound|8080|http|fisher-jira-prod.prod.svc.cluster.local"
    patch:
      operation: MERGE
      value:
        http_protocol_options:
          header_key_format:
            proper_case_words: {}

istioctl output:
{
        "name": "inbound|8080|http|fisher-jira-prod.prod.svc.cluster.local",
        "type": "STATIC",
        "connectTimeout": "10s",
        "loadAssignment": {
            "clusterName": "inbound|8080|http|fisher-jira-prod.prod.svc.cluster.local",
            "endpoints": [
                {
                    "lbEndpoints": [
                        {
                            "endpoint": {
                                "address": {
                                    "socketAddress": {
                                        "address": "<IP_ADDRESS>",
                                        "portValue": 8080
                                    }
                                }
                            }
                        }
                    ]
                }
            ]
        },
        "circuitBreakers": {
            "thresholds": [
                {
                    "maxConnections":<PHONE_NUMBER>,
                    "maxPendingRequests":<PHONE_NUMBER>,
                    "maxRequests":<PHONE_NUMBER>,
                    "maxRetries":<PHONE_NUMBER>
                }
            ]
        },
        "httpProtocolOptions": {
            "headerKeyFormat": {
                "properCaseWords": {}
            }
        }
    }

Am I doing something wrong?
Thanks

I also tried to use this but the header was still lowercased.
This was on istio 1.5.4

I used istio 1.5.2 and with this envoyfilter. It's worked.

@uc-dang-tiki Could you clarify where you saw the proper-case headers?  Was it the request headers incoming to the echo workload?  So if you exec'd into the echo container, you saw incoming headers with proper case?
Or did you see it somewhere else? Thanks.

the proper-case in listener section of echo envoy config_dump. I call echo service via nginx ingress. first, i call echo service without config proper_case_words, I saw lowercase, after apply this config i saw Trun Case header.

Perhaps it works properly in the listener config but not in the cluster config.  Maybe an issue needs to be filed for envoy.  I'll try to do some more testing first.


Javascript Math tutorials not working in Chrome

Challenge http://beta.freecodecamp.com/challenges/waypoint-subtract-one-number-from-another-with-javascript has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
The math problems do not work with google chrome, however they work just fine with safari/firefox.
Not working on Chrome

Working on Safari

Hey @ClarkGH this has been fixed just a few minutes ago! Also just as a heads up safari is incompatible with our test suite so it's likely to encounter issues

Closing. @ClarkGH Please feel free to re-open if the issue still persist.
Happy Coding!


Remove duplicated words

Remove duplicated words in below files to make it more clearly:

pkg/dnsprovider/providers/aws/route53/interface.go
pkg/federation-controller/cluster/clustercontroller_test.go
test/k8s/e2e/framework/framework.go

/assign @marun

/approve

/assign @marun

@madhusudancs @quinton-hoole @marun  could you pls help review and approve? tks

/lgtm
/approve

The above error is due to the fact that I changed github user name, and the relevant owners files have not yet been updated.  I'll try to get all that resolved, but in the mean time perhaps @shashidharatd or @irfanurrehman can type /approve.

/approve
@mooncak, development is almost seized in this repo. request to give a try in https://github.com/kubernetes-sigs/federation-v2

/approve
@mooncak, development is almost seized in this repo. request to give a try in https://github.com/kubernetes-sigs/federation-v2

ok

@quinton-hoole-2 @shashidharatd    Could you also add /ok-to-test label? thanks.

/ok-to-test

/ok-to-test

@madhusudancs @quinton-hoole @quinton-hoole-2  Can you also add /ok-to-test label? thanks.

@mooncak I don't think anyone's interested enough in such a small PR to fix minor code comments in deprecated code to get this merged.  Please stop pinging this PR.   I would suggest that you run an automated grammar checker across all the kubernetes/* code, and submit the smallest number of PR's possible to address all of those issues.  Please close this PR.

/close


With Firebase Hosting Example

I managed to solve many of the problems people were having with Next.js on Cloud Functions for Firebase. EG:
- https://github.com/zeit/next.js/issues/2017
- https://github.com/zeit/next.js/issues/820
- https://github.com/zeit/next.js/issues/2467
- https://github.com/firebase/firebase-functions/issues/72
I'd like to contribute it here.
I know that everyone maintaining this repo and the Firebase Functions repo are busy and don't have the time to support a myriad of deployment methods or JS frameworks. Given that, I'm happy to tackle any Firebase Hosting issues if you wish to redirect people to my example Firebase repo. If and when we diagnose issues as being on the Next.js side I can bring the concerns to this repo.
I also have a thorough Medium post about this setup and the challenges overcome, but wasn't sure of the contributors guide for example repositories and linking externally. If it's okay to add a link to this example I think it will answer a lot of people's questions when they Google their way here.
Thanks for the cool framework! :smile:

This PR makes a few changes I wish to highlight:

It adds npm5 lockfile to the gitignore.
It renames the previous Firebase example from with-firebase to with-firebase-authentication as it only covers using Firebase Authentication and not Hosting.


CODE 93 barcode support in Quagga JS[enhancement]

Hey can we accommodate CODE 93 barcode scanning support in Quagga JS as enhancement in this plugin , because its the best plugin which i have found so far with great accuracy rate.

I'll put this request on my list. It doesn't seem to take to much effort to implement this kind of barcode-decoding. You will be notified as soon as I start implementing this type.
Since you are asking for support: Do you have a few samples on hand? Images from you camera? Mobile phone? Or even a video?

@serratus , i just checked your plugin, its cool :+1:  like other users of your plugin, even i 'm eager to know when code 93 decoding would be out.

@sidheshnalawade @dreamweiver it seems that there has been Code 93 support (code_93_reader.js) since at least May of 2017, can we go ahead and close this task, or is there something remaining to be done here?

Thanks!


coreui is not defined

I am using the CoreUI free version for one of my projects. It is a Laravel 10 project and I am using Vite to build the project.
After migrating the project from Webpack to Vite I am getting an error on the sidebar toggle button. When I click on the button it throws an error
coreui is not defined

for the code below
<button class="header-toggler px-md-0 me-md-3" type="button" onclick="coreui.Sidebar.getInstance(document.querySelector('#sidebar')).toggle()">

Can you please let me know the reason of this issue and way to fix it?
Project URL: https://github.com/nasirkhan/laravel-starter/blob/update/resources/views/backend/includes/header.blade.php

Hey @nasirkhan, you might want to post this as a discussion over here (https://github.com/coreui/coreui/discussions) and see if the community can jump in and show you how to set up CoreUI with Vite, as this is not a bug in CoreUI itself.

@nasirkhan please check if the following file coreui.bundle.js is available in this view


Enhancement/stages

See issue#5
Added 2 stages, namely pre_conf and container_conf

Should send the PR to master branch instead of production branch


SIL: move all the block-list modifying APIs to SILFunction.

... and remove SILFunction::getBlocks().
It's just a cleanup, NFC.

@swift-ci smoke test

@swift-ci smoke test

@eeckstein This comment is not directly related to the PR, but I'm reminded that SILBasicBlock::getParent() should not return SILFunction. It should always return a valid parent, but that parent should be some abstraction over global initializers and functions, say SILBlob. The caller should always need to explicitly check before assuming it is a SILFunction. Otherwise, we have a rare failure mode that is hard to test for. Some of SILFunction's APIs might be in that SILBlob abstraction instead so we don't need to always check for global initializers. The block list could be there as long as no one tries to add blocks.

@eeckstein This comment is not directly related to the PR, but I'm reminded that SILBasicBlock::getParent() should not return SILFunction. It should always return a valid parent, but that parent should be some abstraction over global initializers and functions, say SILBlob. The caller should always need to explicitly check before assuming it is a SILFunction. Otherwise, we have a rare failure mode that is hard to test for. Some of SILFunction's APIs might be in that SILBlob abstraction instead so we don't need to always check for global initializers. The block list could be there as long as no one tries to add blocks.

@swift-ci smoke test

@swift-ci smoke test

@atrick I'm not sure if it's worth to support getting the parent of a global initializer block. We currently don't have a need for that.
We could just rename SILBasicBlock::getParent() to SILBasicBlock::getFunction() and assert that the block is inside a function.

@atrick I'm not sure if it's worth to support getting the parent of a global initializer block. We currently don't have a need for that.
We could just rename SILBasicBlock::getParent() to SILBasicBlock::getFunction() and assert that the block is inside a function.


Improve documentation on how to install and use aurelia-kendoui-plugin

I have made 3 different repositories to demonstrate the installation process of the 3 installation options (core, vendors, and jspm-git)
I suggest that we test all these steps and combine these into the readme of the plugin.

we could even build an installation wizard in the demo site
in this wizard you could say, for example, that you have kendo PRO files but don't have telerik credentials, which will suggest you use the vendor approach to install the plugin.

we could even build an installation wizard in the demo site

This is the way to do this yes - our web site (residing in the gh-pages branch of the repository that we use to build the site) should be the only place anyone visits to either verify the function or to get the chosen installation type. Full service!

All three sample apps

aurelia-kendoui-core
aurelia-kendoui-vendors
aurelia-kendoui-jspm-git

function correctly as stated in
1.https://github.com/aurelia-ui-toolkits/aurelia-kendoui-core/issues/2
2.https://github.com/aurelia-ui-toolkits/aurelia-kendoui-vendors/issues/3
3. https://github.com/aurelia-ui-toolkits/aurelia-kendoui-jspm-git/issues/1
respectively.


Add Command Line Interface mode

Add support for pure Command Line Interface, by reimplementing GUIManager as CLIManager, for the case running on server without GUI Desktop as a 24*7-hour bot.
In the CLI mode, I only implemented the display of a few core information, because many functions are probably not required when it is simply running as a bot on a server (and it requires less work). Configuration through the user interface is not supported, so you need to edit settings.json manually (should not be a problem for someone using command line).
Logging in is supported. The user just needs to open the link in their browser (not required to be on the same machine as the server) and enter the code.
Usage
Add --cli argument to launch in CLI mode.
Screenshot
It works fine on my Ubuntu server:

Help wanted: In main.py, to make it works with CLI mode, I have to move the parser to before creating the window temporarily, so that works in the following flow:

parse arguments
skip creating window if --cli flag is set (or else an error will occur if it tries to create a window in a non-GUI environment)

In the current implementation, an error will occur if the parser output something to the message box. A better method is needed, maybe direct the parser output to the console? I am not sure whether it will bring any additional problems, so I did not fix it.

Just from my personal perspective: I'm a user in China (UTC+8 Time zone), where some Twitch live streaming in place like Europe starts at an unfriendly local time (like at mid-night) here. I don't want to keep my laptop on and idling for a whole night, but sometimes if I don't it's hard to get the full drop rewards. (In particular, the game I'm playing now, "Tom Clancy's Rainbow Six Siege", requires 4 hours' watching to get a single drop. And sometimes drops are even only enable for official live rooms, so I have to follow the official campaign schedule to get the full rewards.)
In this case, the best solution is to run this program on my VPS (and it's display-less). That's the initial reason why I wrote this fork.
It might be more convenient of allowing it to run on server non-stop, even for personal use. Also this PR doesn't cancel the limit of linked accounts, maybe still be able to prevent abuse to some degree (though adding CLI mode still facilitates for multi-instance mining and profiting, of course).
Anyway, I can understand your considerations if you decide to refuse adding this feature eventually. And thanks for your review comments <3

Honestly this is 1 of 2 things I really hope gets implemented.. the second hopefully being a lot easier once this gets implemented and that would be getting this to run in docker.

@JourneyOver You should check out the project goals: https://github.com/DevilXD/TwitchDropsMiner#project-goals
This PR isn't getting merged, because it leads to abuse. It goes as far as me considering pulling down the entire project, but it hasn't been bad enough yet to do so. At least as far as I'm aware.

I honestly have no idea, why do you consider using it through cli to be "abuse".
It's not like without it it's impossible to set it up on some private server to run 24/7. You literally designed it to launch in a tray on startup and mine as long as pc is running.
I'm in a situation, where there's a surprise campaign running, but out of like 50 enabled channels there's only one live and I'm not sure if I'd be able to get all drops before campaign ends, especially if that channel goes offline. I'd like to leave this program running overnight, but my gaming pc's fans are quite loud even when idling, so I'd prefer not to have to sleep in a room with pc on. I could run it on a raspberry pi that I own, which has passive cooling and is completely silent, but it's not plugged to any monitors, so it boots in headless mode and it would be a lot of hassle to boot it in a way where I can connect via vitual desktop.
So I'm failing to understand your thought process. I could run it 24/7 in a background on my pc. I could run it 24/7 on any remote server with remote desktop protocol. But the convenience of being able to run it on my own machine that happens to boot without gui is just too much, and you would consider this "abuse"?

@ignis05 The reasoning behind it is already explained in the Project Goals section, a link to which you seem to have intentionally ignored. There are links to issues within said section, that exactly explain why I really don't want this project to be possible to run in headless mode. I wanted to do it at the beginning, but I don't want to now. It only leads to abuse and nothing else. I don't want thousands of instances running on some remote server, for profit purposes.
In case you still can't understand it - this is a hobby project. I'm a one-man development team, currently taken away by a 6/10 work cycle since a month ago, and for the next month or so. I don't have the time to resolve the existing issues, yet alone design a foolproof system that won't end up crashing and sending the miner into an endless restart loop. Even if I wanted to, this project is far from being ready to become "headless" in a sense where you can "set and forget" it.
In other words, this project isn't ready for headless, and I'm not doing anything to help it, because I don't have the time for it, and it only leads to abuse, so why bother. Due to abusers, we can't have nice things - this is the sad truth of it.
For more abuse examples, see #84, also linked in the project goals section: https://github.com/DevilXD/TwitchDropsMiner#project-goals

I did not ignore anything, it's just that the project goals don't really mention anything other than it being possible to "abuse" and being at the bottom of the priority list. While on this pr you simply said This PR isn't getting merged, because it leads to abuse..
Like I said, it's not like running it in its current state as a 24/7 farm is impossible, it's just a bit more tedious to set up. I understand your reasons for not wanting your personal project to be used against your will, even if I disagree with the sentiment that automatically farming drops with like 60% uptime on a personal pc is great, but doing the same thing on a headless server with better uptime or including farming channel points and drops for unlinked accounts is taking it too far and straight up abuse. But I guess when it comes to morality, everyone draws the line one step ahead of where they stand.
You asked earlier in the thread in regard to the headless mode, Why exactly is this needed for a personal, single-account utility program like this one?, I just tried to give my perspective on a scenario that I was in that I believe might have met those criteria.
But while I might disagree on what counts as abuse, I understand that in the end, this is your project, and you are free to do anything you want with it. I appreciate the unpaid work you've already put into this and that you chose to share it with everyone, and I wish you the best, regardless of what you choose to do with this pr.

Personally, I use it on a headless Linux server, as I described in #17. Once you figure it out, it really requires little to no effort already. I even have a script that can updated to latest Master (.bat), so I could have it be 0 maintenance if I combined those.
The reason for doing this is partly because of #80 and partly so that I don't have to have my PC running 24/7 (for drops that are only one stream from one channel during a specific event), which spares additional wear on my PC and saves power.
Given it's really easy to implement headless, whether by finding this pull request, the docker pull request, or using Xvfb as I did, any server farm described in https://github.com/DevilXD/TwitchDropsMiner/issues/84#issuecomment-1331709361 could easily be deployed anyways. I think it's reasonable to assume, that anyone seeking profit would be willing to put the extra bit of effort in and thus it's only really inconveniencing ethical users, who might not have the knowledge, time or incentive to implement the bot in this way.

This project started as a small, personal script, that I eventually had an idea of sharing with others. From the very beginning of this project, the idea was to have a console application, capable of being deployed on a remote server and mostly forgotten about. As a personal bot of sorts, it'd take care of only a single Twitch account, and that's it. A simple, helpful tool, reliving you of having to keep track of which channels are online, changing the channel when the watching one goes offline, and having to be there on time to claim the drop. All of this info is still present in the README.md file, with only a couple of corrections here and there, ever since the first very few versions have been published.
However, some people didn't understand what this project is for. They wanted to "go big" - and have massive farms of hundreds, thousands of accounts, all mining drops for personal profit. I've been literally involuntarily dragged into a "deal" between two people, where one was selling a "server with 10 instances on it" to the other, where the other person was contacting me and demanding to know when I'd fix a critical-at-the-time issue (#68), preventing the miner from claiming the drops.
It changed me. I no longer want to make it possible to run this on a remote server, and this is the least I can do to try and limit the misuse of this project. Yes, it makes it "inconvenient" for people who would want to do that, but as I cannot control how many instances you're going to run on that servers of yours, I cannot allow for it. I do not support misuse and abuse - and if it's going to continue, this project will simply be discontinued entirely. I'm not going to waste my time for the profit of others, since again - this isn't the purpose of this project.

anyone seeking profit would be willing to put the extra bit of effort in

There are other projects like this out there, that make it much easier to deploy. I don't get why someone cannot just use that one instead. As far as my own personal experience goes, "putting in effort" is enough of a deterrent to limit the abuse on it's own. There's no way to stop it, unfortunately, as any open-source project can be repurposed to bypass it's limitations, with enough effort put in. It's been doing a good enough job, ever since "the change" happened, and I didn't head from anyone trying to make a giant farm since.

thus it's only really inconveniencing ethical users, who might not have the knowledge, time or incentive to implement the bot in this way

Good. Again, being able to run this on a remote server isn't the purpose of this project - not anymore. Nobody forces anyone to use this thing either. If one doesn't find it suitable for their purpose - they shouldn't use it. Simple. If anyone would like to have a miner they can deploy on a server, as I said before, there are other, more suitable projects out there, that can do exactly that, Please use that one instead.

While I disagree, it's a matter of opinion at this point.  Thank you. <3


Meltano supported tap-postgres

Repo: https://github.com/MeltanoLabs/tap-postgres
Slack channel: https://meltano.slack.com/archives/C04CLA0S4G0/p1669058552528759

Development Scope:

[x] tagged release
[ ] tests pass in CI
[ ] branch protection
[ ] cookiecutter TODOs completed and removed
[ ] clean README
[x] Added to meltano hub
[ ] feature coverage relative to Hub default https://hub.meltano.com/extractors/tap-postgres--transferwise/ ?

[ ] ?

@tayloramurphy I created this to define the scope of development for these new plugins, track status, and decide when its ready to recommend. Can you help fill in the description with the features (specific to this source) we expect the initial release to support? It will help us and users understand what done is and when we're there.

cc @visch

This one needs some love that's for sure
These 4 are pretty straight forward and <a few hours of work.

tests pass in CI - https://github.com/MeltanoLabs/tap-postgres/pull/26 Quinn has this one pretty much done
branch protection - https://github.com/MeltanoLabs/tap-postgres/issues/27
cookiecutter TODOs completed and removed - https://github.com/MeltanoLabs/tap-postgres/issues/28
clean README- https://github.com/MeltanoLabs/tap-postgres/issues/29

Feature coverage missing things. I can't say what should/shouldn't be there before we make the default switch but here's generally the "Important" missing features. The biggest thing transferwise has over this tap is that they have had their tap around longer so it's just seen more stuff in the wild

Log based pulls - https://github.com/MeltanoLabs/tap-postgres/issues/3
SSL / Username / Host broken out configurations - https://github.com/MeltanoLabs/tap-postgres/issues/30

@visch - Thanks for logging these. We have an emerging standard practice for CD deployments to PyPi, so I think it's safe to leave that out or do manually a few times for now.
I do think this one is important since it may front-load some breaking changes:

https://github.com/MeltanoLabs/tap-postgres/issues/30

This can come along a little later when higher priorities are all addressed:

https://github.com/MeltanoLabs/tap-postgres/issues/3

@aaronsteers @visch this is great! I updated the issue checklist with what I think is the consensus in/out of scope items. Definitely feel free to change them if more stuff comes up thats blocking us recommending this variant.


how to add message-id?

helllooooo men

Hi, could you please give us more detail and example about your use case?


IgorPavlov.7Zip version 19.00

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Its already available. You can close your pr.


Wheels for python 3.10 and newer

Hi @patmjen
Thank you for this amazing little library!
Is it possible to create wheels for python 3.10 (and other newer versions) on pypi server?

Wheels for all Python 3 versions should now be available under version 1.0.1.
It is the same as version 1.0.0 - I only removed the requirements for certain Python versions.
Since the code does not use any advanced/new Python 3 features, allowing all Python 3 versions should not be a problem. I just tested with Python 3.11 and that seems to work with no issues.
I apologize for the long wait. Updating the build systems for newer versions of Visual Studio proved to be very difficult so I had to resort to manually fixing the wheel files...

@patmjen Thank you so much! Again congrats on the nice work :muscle:


gotags fails for generics

Hi,
I have the following code.
type SdpDataSchemaCache[K comparable, V any] struct {
  capacity int
  dll      *list.List
  elements map[K]*list.Element
}

This code compiles with golang v1.21/22. However, I get the following error with gotags.
parse error: cache.go:9:27: expected ']', found comparable (and 2 more errors)

Not sure why gotags fails which the go compiler doesn't complain?

Yes, gotags doesn't work for generics yet - bummer.


Update to ROS2 Humble and Gazebo Garden

This PR updates the dependencies to ROS 2 Humble and Gazebo Garden.
Motivation: these changes are a pre-requisite to building the buoy project on macOS.
Posted as draft for discussion - if this could be maintained as a ros2-humble-dev branch or similar in the main repo that would be very helpful, otherwise the changes are here as a starting point for future migration.

This is quite a contribution! We do plan to move to Humble/Gazebo in the near-term to incorporate more faithful and native added mass terms. We have started the move here #83 . We should merge these two PR's.

Oops - missed that! Happy to test #83 if that helps. I can start by rebasing this change onto #83 and extract any changes that are specific to supporting macOS as well.

Defer to #83


Fix theme switcher

Fixes #187

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.288%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tsbrowse/main.py
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>4:
0.0%

Covered Lines:
753

Relevant Lines:
834

💛  - Coveralls


Add a license to the repository

I recently came across your project Quantum-Simulation-of-the-Schrodinger-Equation- and I noticed that the repository github.com/SantiagoTB/Quantum-Simulation-of-the-Schrodinger-Equation- currently does not have a license specified.
Why Adding a License is Important?
As GitHub documents

Public repositories on GitHub are often used to share open source software. For your repository to truly be open source, you'll need to license it so that others are free to use, change, and distribute the software.

Would be possible to add a valid license to this repository? Probably something really OpenSource such as the Apache 2.0 license would fit really well.
Thanks!

Hey Juan
Sorry for that, I just added the apache 2.0 license


[ruff] Also report problems for attrs dataclasses (RUF008, RUF009)

Summary
Resolves #9757.
Test Plan
cargo nextest run and cargo insta test.

@AlexWaygood would you mind taking a look at this rule. I don't have the necessary context about what it changes to review it.
I do think that we should make this a preview-only change because it increases the rule's scope.

Note that RUF009 can be a bit misleading when auto_attribs=False (or with older attr.s codebases):
import attrs

@attrs.define(auto_attribs=False)
class X:
    a_field: int = attrs.field(default=42)
    not_a_field: list = (lambda: [])()
#                       ^^^^^^^^^^^^^^ RUF009 Do not perform function call in dataclass defaults

Without auto_attribs, not_a_field can't possibly be a  dataclass field. In this example, it's an incorrectly typed class variable. Fixing the typing error also fixes the RUF009 warning:
@attrs.define(auto_attribs=False)
class X:
    attrs_field: int = attrs.field(default=42)
    not_an_attrs_field: typing.ClassVar[list] = (lambda: [])()

This is an issue though when using attrs.field wrappers:
def my_field():
    return attrs.field(default=42, metadata={'my_metadata': 42})

@attrs.define(auto_attribs=False)
class X:
    a_field: int = my_field()
#                  ^^^^^^^^^^ RUF009 Do not perform function call `my_field` in dataclass defaults


Is it worth adding an additional line continuation mechanism?

Line continuation in PowerShell suffers from at least two problems:

The backtick char is hard to see in PowerShell script:

Get-Module pester `
| Foreach { Get-ChildItem $_.ModuleBase -recurse about_*.txt} `
| Foreach {$_.BaseName -replace '\.help',''} | Select-Object -Unique | Sort-Object

Escaping a char like _ makes the line continuation more obvious:
Get-Module pester `_
| Foreach { Get-ChildItem $_.ModuleBase -recurse about_*.txt} `_
| Foreach {$_.BaseName -replace '\.help',''} | Select-Object -Unique | Sort-Object

The current line continuation mechanism is an escape of a newline (invisible) character.   As a result, line continuation is broken if the user has any sort of whitespace (space or tabs) after the backtick since <backtick><space>|<tab> does not signify line continuation.

The second issue is impossible to see via casual inspection of script and is common when you copy/paste script from a website. By using an escaped char like <backtick>_ there is no longer any issue with whitespace after this line continuation char.  That whitespace can safely be ignored by the parser.  For an example of this problem, copy the first script sample above and paste into a PowerShell console.  It will fail to run because there are spaces after the backticks.  :-)
FWIW I'm not sure escaping _ is the best choice but I do think escaping a "visible" character has the benefit of being more obvious.  I would love to ditch the escaping and just use a dedicated continuation character like _ (which VB uses) but that is tough with PowerShell where I can have a function named _.
Another option might be to use a double escape:
Get-Module pester ``
| Foreach { Get-ChildItem $_.ModuleBase -recurse about_*.txt} ``
| Foreach {$_.BaseName -replace '\.help',''} | Select-Object -Unique | Sort-Object

I believe such a change would not interfere with the existing line continuation mechanism so existing scripts would continue to work.
Migrated from #2751

Why?  I like the used of the backtick. I've been doing this for a long time and I like it. So, why change something that works?
:)

If you read the proposal all the way through, it mentions that this would not change the existing mechanism.  You can't because that would break too many scripts.
This issue is meant to discuss if it is worth adding another mechanism for line continuation.  I know, right?  Having more than one way to do something in PowerShell is SHOCKING I tell you.  Completely unheard of.   ;-)

How about adding ... as an optional continuation token? 🤔
Sure, there could be a function with that name, but it would kinda make sense...
(pun intended)

The general best practice is to not use the backtick for line continuation. Some times you can just restructure your command like this:
Get-Module pester |
    Foreach-Object { Get-ChildItem $_.ModuleBase -recurse about_*.txt} |
    Foreach-Object {$_.BaseName -replace '\.help',''} |
    Select-Object -Unique |
    Sort-Object

This is also where Here-Strings and Splatting come in handy. I tend to teach people these alternate approaches instead of introducing the backtick.

@KevinMarquette Keep in mind that neither breaking on | or using splatting is an option when invoking a native executable with a lot of lengthy parameters.

There are options for that too.
$MSIArguments = @(
    "/i"
    ('"{0}"' -f $file.fullname)
    "/qn"
    "/norestart"
    "/L*v"
    $logFile
)
Start-Process "msiexec.exe" -ArgumentList $MSIArguments

I should clarify that I am not opposed to having a much better way to express line continuation.

I personally don't feel it's necessary to add a new language construct. Instead of that first what came on my mind was better text editors support.
A lot of tokens is highlighted in editors, so why not backtick (with Cyan, Salmon, or any other nice color)? And the rest of the line behind the backtick might be in other color with meaning "warning, this might be wrong".

Backticks are the devil. We all have widescreen monitors nowadays and know how to use the horizontal scroll bar :). Joking aside, I have found long running lines could be broken into separate lines entirely and often run faster since they are avoiding the pipeline. Multiple pipes just equal slow and lazy IMO.

@stej there is help for this in Visual Studio Code.  I put this setting in my user settings file:
 "files.trimTrailingWhitespace": true,

And PSScriptAnalyzer has a rule PSMisleadingBacktick that will catch these.  But not everyone uses VSCode or PSScriptAnalyzer.

Nice one @rkeithhill!
I'm using VS Code for lightweight coding and I like it.  Thanks for sharing the "files.trimTrailingWhitespace": true setting.
:)

You most certainly can splat to native commands.
The catch is that native switch commands don't accept "true" values ;-)
E.g.
tf vc status /format:detailed

Could just as easily be:
$fmt = @{"format"="detailed"}
$cmd = "vc","status"
tf @cmd @fmt

I don't like line continuation characters. I wish we didn't have the one we have (Yay C# -- Boo VB).
One problem with line continuation characters is that the only reason for them to exist is to enable people to stay within some arbitrary line width. Next thing you know you've got people trying to make a 249 character file path somehow fit on 80 character lines by splitting it into many strings and appending them together -- as if that actually improved readability.

The reason that I like staying within some "arbitrary line width" is because a lot of devs run portrait monitors. Having a 100 or 120 character limit means that my code fits in the width of the window.
I would love to have a switch for a line terminator as opposed to implementing yet another continuation character.

Is there any language that has the concept of "line continuation" that has done it in a way that is better?
PowerShell's "line continuation" at first implied to me that the line was simply spliced together with the next one (as if the line ending was ignored).  But that's not turned out to be the way it works.  Try
'Power`
Shell'

It's pretty hard to create a good shell that doesn't have some way to split command lines because they can get pretty long. I chose backtick because it was similar to \ (and I couldn't choose \ for obvious reasons). Comparing PS to C# is a bit disingenuous they target different usage patterns - C# has a single statement end operator - requiring ; at the end of every command would be a pretty rotten interactive shell experience

@LarryWeiss

Is there any language that has the concept of "line continuation" that has done it in a way that is better?

On the visibility front yes.  Bash and Python use \ for line continuation.  But neither tolerates whitespace after \.  VB, which uses _, does tolerate whitespace after _.

some of those characters still have trouble in a windows environment where you're executing a command. _ is an allowed character for a filename - would I need to escape _ in this context?
get-content _

Agreed. That's where an escaped character would be better.

FWIW, a number of international keyboards don't even have the backtick key. In the Italian keyboard it's ALT+TN96 or nothing. FWIW again, many laptops don't have TN at all, so there is NO way to type a backtick

What about ## ?

`` is promising - the only existing code it would break is commands (argument-mode statements) that:

print a single `, individually escaped,
as the last argument

E.g., Write-Host You should not end a sentence with a `` . Existing code doing that strikes me as not too likely.
@spaghettidba brings up a good point, but it is outweighed by the long tradition of ignoring other languages and keyboard layouts in computing :) (e.g., \, @)
@iSazonov: It's quite likely that ## is used in existing code for comments, and even if you limited recognition to ##<newline> sequences, the potential for confusion with a comment is great.
[Tangent alert]
@LarryWeiss: Re line continuation in other languages (to add to @rkeithhill's comment):
Good point; to elaborate on the fundamental difference between POSIX-compatible shells such as Bash and PowerShell with respect to line continuation:

In Bash, \<newline> is removed from the lines of a command  / inside a double-quoted string; this allows splitting command lines at arbitrary points and composing single-line strings spread across several lines inside double quotes.

In PowerShell, `<newline> preserves the newline; this requires splitting to occur between arguments and makes use inside a (double-quoted) string pointless, because a <newline> by itself will do; to get line continuation with a string in a POSIX sense, you must use the workaround of an array of substrings with unary -join.

Note that in both environments there is no line continuation in single-quoted strings, where all content is treated literally (with the exception of '' in PS) - so, strictly speaking, your example doesn't apply.

Two years later, I think I'm going to close this.  The current situation is "somewhat" sub-optimal but I'm thinking the line-terminator sequence is not worth changing at this point.


EXC_BAD_ACCESS on app exit

Having the following crash when app exists.  Any ideas?
EDIT - If I comment out that function, the crash stops.  Is this needed for anything?

This seems to be an issue with OSX 10.11.3 or oF 0.9.1.  Commenting out the function or where it's called resolved the issue for me.


Actually allow building Skydns in Docker

The current Dockerfile does nothing. This actually builds Skydns in the container.

The docker image should be kept small. Building instructions are in the
read me.
On 8 Aug 2015 10:55, "Sami"<EMAIL_ADDRESS>wrote:

The current Dockerfile does nothing. This actually builds Skydns in the
container.
You can view, comment on, or merge this pull request online at:
https://github.com/skynetservices/skydns/pull/218
Commit Summary

Actually allow building Skydns

File Changes

M Dockerfile
https://github.com/skynetservices/skydns/pull/218/files#diff-0 (11)

Patch Links:

https://github.com/skynetservices/skydns/pull/218.patch
https://github.com/skynetservices/skydns/pull/218.diff

—
Reply to this email directly or view it on GitHub
https://github.com/skynetservices/skydns/pull/218.

Many people using it will not know Alpine and will not know what to do to actually get it working. If for instance you build on Ubuntu the binary will not work on Alpine. I know because I just tried and failed.

This also should not add much to the size of the container because the packages which are added are then removed.

Building this image does add a lot of "virtual size" to it because of the intermediate steps, but I don't see any way around this. Anyway, thanks for the consideration.

skydns                     latest              6c5170b1877b        9 seconds ago       22.82 MB
skynetservices/skydns      latest              b4607de36f8d        3 days ago          18.08 MB
So yeah 4 megs.

Sorry, but this is all explained in the README. We want a static binary in the docker image,

I don't know what you mean? There is nothing in the README that explains how to make a static binary that will run within the Dockerimage. Adding 4 megs to the Dockerimage to me does not seem to make any significant difference.

Actually I see where it gives instructions to build for Docker. I guess it's fine. This would be easier, but fine if you want to do it that way you can do it that way, just makes it more difficult for whoever is using this. But it's workable. I did not read down to that section before.


Compiled issues from playthrough on sc2-next

Compiling issues discovered from my playthrough last weekend, some of these may already be fixed:

[ ] Some kerrigan voicelines erroneously use the in-egg portrait / voice effect even when kerrigan is still alive. Happened twice when capturing garrisons in infested, and it happened in another mission as a onceoff (forgot which)

[ ] descriptions are missing for console commands /color, /skip_custcenes and /disable_forced_camera

[x] Using infestor mind-control on an ursadon during a flash freeze instantly freezes them. I can understand this happening for the protoss units I control, but the ursadons are canonically not frozen and that's on display right up until I control them

[x] If you mind-control an ursadon from an attack-wave on Harvest of Screams, their old AI still kicks in and periodically sends them back to the gather point

[x] I've noticed this a couple of times, including Harvest of Screams and Domination, so probably applies to all hots missions. Drones automatically start harvesting from minerals, but they don't start on vespene. Presumably because the extractor is an AP_extractor, and that screws up the trigger

[ ] on Harvest of Screams, Nafash's base isn't properly frozen. I missed if the buildings had the frozen model, but the overlords were certainly missing it

[ ] Raid Liberator fighter mode (the mobile aa one) doesn't use the same hotkey as normal liberator fighter mode. Raid liberators don't show up in any hotkey configuration menu, so it's not rebindable

[ ] Swarm Queens have the melee Queen spawn creep tumor, which costs 25 energy and has no cooldown. Swarm queen creep tumors normally have a cooldown but no energy cost.

[ ] Spawn banelings doesn't play the baneling unburrow animation

[ ] The Archipelago message box covers up the loss condition timer in Moebius Factor

[ ] (QOL more so than bug) Cyclones have a higher command-card selection priority than spectres, so I need to tab over / have multiple hotkeys to use spectre abilities when cyclones don't really have activateable abilities of their own I'd want to micro

[ ] The reaper jumping sound effect is different / landing sound effect is too loud or possibly unaffected by volume sliders

Need to re-test those

Added /skip_cutscene and /disable_forced_camera description text at some point (sorry I forget which pull request but it's there now)
Harvest of Screams non-frozen base bug fix here: https://github.com/Ziktofel/Archipelago-SC2-data/pull/38


Is there a way to use this in vue/nuxt?

Hi! I saw this package in reddit and was very interested in its capabilities and wanted to see if I can hook it up to my nuxt application!
I know it's built with react, but there's been some working going on with web components or the veaury package, so maybe there is a way I can convert it to web component and use it in vue, just want to get a confirmation on if this is feasible before I try, thanks

Also a bit of a separate issue, I noticed that EmailLayout is also used to build the block configuration, coudl that also be exported out as a package for convenience? that would be great!

Unfortunately, we don't have any experience with Vue, so we won't be able to help here. You are more than welcome to create a Vue fork if you are up for it as I'm sure there are others in the same boat.
Putting the root EmailLayout data in a separate block configuration with it's own package is an interesting idea. We're going to punt on this for now but we'll keep it in mind and consider it further if others find the need for it in the future.


Hms etcd rc updates

Summary and Scope
Update to ETCD portion of chart due to release critical issue in the old ETCD chart.
Issues and Related PRs

Resolves CASMHMS-6047
Resolves CASMHMS-6048
Resolves CASMHMS-6049
Resolves CASMHMS-6050
Resolves CASMHMS-6051

Testing
Tested on:

ashton

Test description:
Validate I can deploy the new chart and the proper version of ETCD was included.

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? N
Were continuous integration tests run? If not, why? Y
Was upgrade tested? If not, why? Y
Was downgrade tested? If not, why? Y

Risks and Mitigations
No known risks
Pull Request Checklist

[X] Version number(s) incremented, if applicable
[X] Copyrights updated
[X] License file intact
[X] Target branch correct
[X] CHANGELOG.md updated
[X] Testing is appropriate and complete, if applicable

/backport stable/1.5


Getting different results to the same query from Bolt and HTTP protocols

I have the following code:
$statement = new \Laudis\Neo4j\Databags\Statement($query, $params);
$vector = $this->connection->runStatement($statement);

$query = "merge(u:User{email: $email}) on create set u.uuid=$uuid return u';
$params = ['email' =><EMAIL_ADDRESS>'uuid' => 'cc60fd69-a92b-47f3-9674-2f27f3437d66'];
Using HTTP, I get the following returned as $vector:
object(Ds\Vector)#54 (1) {
[0]=>
object(Ds\Map)#55 (1) {
[0]=>
object(Ds\Pair)#52 (2) {
["key"]=>
string(1) "n"
["value"]=>
array(2) {
["uuid"]=>
string(36) "35a1a9f0-173f-4899-b2a6-fe66b9e46a79"
["email"]=>
string(5<EMAIL_ADDRESS>}
}
}
}
Using Bolt, I get the following returned as $vector:
object(Ds\Vector)#59 (0) {
}
The node is created (assuming it did not exist before) with both protocols.

My problem. Had the protocol setup incorrect.

Still happening.

Hello @jac12498,
Thank you for taking the time out of your day to report this issue. I have run your query over neo4j version 42, 41, 40 and 35 without any issues, as you can see at the commit referencing the issue.
My spider senses are tingling and telling me you might be testing this with PHPUnit. If this is the case, there is a weird interaction at the moment between php-ds and PHPUnit as you can read about here: https://github.com/php-ds/ext-ds/issues/122.
If this is not the case, I will need some more information before being able to help you.

how are you comparing the results and output?
What version of neo4j are you running?
What version of PHP are you running?
Are you on the latest neo4j-php-client and bolt driver?

Let's hope we can swiftly fix this.
Kind regards,
Ghlen

Thank you for your response.
I have reduced my test to the bare essentials and everything works correctly. The issue must be something with my code. Apologizes for not analyzing it more carefully before.

No problem! Good luck with your project :smile:


Change webext API calls to use browser instead of chrome

Firefox implements a promise-based version of Chrome's chrome.* extension API, referenced as browser.*: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API
It also provides a polyfill to support Chrome: https://github.com/mozilla/webextension-polyfill
Given we're converting lots of our code to promises, I think it would make sense to use a promise-based browser API since it doesn't seem like it's otherwise much different (shouldn't require much logic rewriting, just cleanup).

Yeah the problem with that used to be edge, with edge switching to chromium that hopefully shouldn't be an issue anymore.


Fix example in README

Call to preloadComplex missed the delay parameter.

@thiago-negri Thanks. Merged. :)


AudioSession.instance creates new listeners or instance every time called on iOS

Which API doesn't behave as documented, and how does it misbehave?
Each time that we call await AudioSession.instance in the code or at startup initWithRegistrar is called.
This causes the following code being run every time and we end up with a lot of listeners of the same type running at the same time
    [AVAudioSession sharedInstance];
    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(audioInterrupt:) name:AVAudioSessionInterruptionNotification object:nil];
    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(routeChange:) name:AVAudioSessionRouteChangeNotification object:nil];
    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(silenceSecondaryAudio:) name:AVAudioSessionSilenceSecondaryAudioHintNotification object:nil];
    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(mediaServicesLost:) name:AVAudioSessionMediaServicesWereLostNotification object:nil];
    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(mediaServicesReset:) name:AVAudioSessionMediaServicesWereResetNotification object:nil];

Minimal reproduction project
Audio_service example project
To Reproduce (i.e. user steps, not code)

Press AudioPlayer
Press Stop
... repeate a few times

Error messages
We can see how the listeners stack up an we get a new listener for every start/stop
When a route change happens after 3 start/stops we get the following:
routeChange detected
routeChange detected
routeChange detected
routeChange detected

We can also put a NSLog print statement in initWithRegistrar() in DarwinAudioSession.m
Expected behavior
Each listener should only be called once
Screenshots
If applicable, add screenshots to help explain your problem.
Runtime Environment (please complete the following information if relevant):

Device: Iphone Se (second generation)
OS: iOS 14.0.1

Flutter SDK version
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.22.0, on Mac OS X 10.15.7 19H2, locale en-GB)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
[✓] Android Studio (version 4.0)
[✓] IntelliJ IDEA Community Edition (version 2018.2.4)
[✓] VS Code (version 1.49.3)
[✓] Connected device (1 available)
    ! Error: Auglysingadeild4thgen is not connected. Xcode will continue when Auglysingadeild4thgen is
      connected. (code -13)
    ! Error: Living Room is not connected. Xcode will continue when Living Room is connected. (code
      -13)
    ! Error: Living Room is not connected. Xcode will continue when Living Room is connected. (code
      -13)

• No issues found!

Oh, you're right!
Both addObserver and removeObserver are tied to the plugin instance. What should happen is that initWithRegistrar and dealloc should both look at sessions.count and only call addObserver if this is the first session being created, and only call removeObserver if this is the last session being deallocated.

Not to mention that dealloc probably doesn't get called since each instance is retained in the sessions array. Probably the array of sessions needs to be __weak.

Unfortunately my obj-c knowledge is very limited or almost non-existant so I have little there.... But I'm wondering what benefits there are of having multiple instances over one platform instance?

Plugins that do it that way generally break when they are loaded into apps that use more than one FlutterEngine instance (like audio_service-based apps, or any apps that do background execution).
Basically what should happen in an app that uses multiple FlutterEngines is that each FlutterEngine will have its own plugin registrar, and the plugins will be instantiated anew in each registrar. So the plugin should have an instance of itself loaded in each FlutterEngine, but it is up to the plugin to manage any parts of its state that are to be shared globally between all instances. You'll notice that the only instance data in DarwinAudioSession is the registrar and the channel, which need to be different per instance, while everything else was intended to be shared.
Technically DarwinAudioSession isn't itself the plugin, AudioSessionPlugin is, but the way I designed it is that DarwinAudioSession is kind of like a sub-plugin that behaves in the same way as a plugin. If I ever end up exposing another iOS API aside from AVAudioSession, the intention was that it would also be encapsulated in its own class, and itself behave in the same way as a plugin. That way, AudioSessionPlugin doesn't need to concern itself with how each individual API works.

Plugins that do it that way generally break when they are loaded into apps that use more than one FlutterEngine instance (like audio_service-based apps, or any apps that do background execution).
Basically what should happen in an app that uses multiple FlutterEngines is that each FlutterEngine will have its own plugin registrar, and the plugins will be instantiated anew in each registrar. So the plugin should have an instance of itself loaded in each FlutterEngine, but it is up to the plugin to manage any parts of its state that are to be shared globally between all instances. You'll notice that the only instance data in DarwinAudioSession is the registrar and the channel, which need to be different per instance, while everything else was intended to be shared.
Technically DarwinAudioSession isn't itself the plugin, AudioSessionPlugin is, but the way I designed it is that DarwinAudioSession is kind of like a sub-plugin that behaves in the same way as a plugin. If I ever end up exposing another iOS API aside from AVAudioSession, the intention was that it would also be encapsulated in its own class, and itself behave in the same way as a plugin. That way, AudioSessionPlugin doesn't need to concern itself with how each individual API works.

Thank you for taking the time to write this. It all makes sense to me now.

I have fixed the ARC management in the latest commit along with your issue, although fixing the ARC code has revealed a bug in just_audio and forced me to fix it's ARC code, too. I'll need to do some sort of coordinated release so that the new audio_session and just_audio are available at the same time.
I haven't pushed the just_audio fixes yet, so if you try the new audio_session with just_audio now, you'll experience a crash whenever a FlutterEngine is destroyed (when audio_service is stopped).
I might take a look at #7 before doing a release, and will let you know when it is available for testing.

Fixed in 0.0.9


Test wasmd 0.7

Setting up for running tests against pre-release 0.7

Please avoid any kind of rebases in this branch, since it includes release tags (of alpha versions)

We can always make another small pr if we find anything between rc1 alpha2 and full release.


Trying  deployment in portainer fails

Hey thanks for writing such a cool server,  I would love to set this up in portainer on umbrel.
I succeeded and edited the env as suggested,  the server is running, but if I open the port no site is reachable,  what am I missing?
Will post logs...

Got it sorted out now! Running sataddress in Portainer on umbrel now, had to edit the host file, where I also had to add the correct value for host=<IP_ADDRESS> and for TOR_PROXY_URL= the tor proxy ip from umbrel in my case socks5://<IP_ADDRESS>:9050
Only I can't connect to Lnbits for keysend... what is the admin ID? Is it super user ID or wallet ID? I guess wallet ID plus wallet api key?


Fix column creation when adding additional normal and embedding columns, and make index name unique (for when there are multiple vector indexes in the same keyspace)

Fix column creation when adding additional normal and embedding columns, and make index name unique (for when there are multiple vector indexes in the same keyspace).
…
And change stream to for-loop when converting List to Float[] for performance

Thanks @michaelsembwever
rebased and merged at daf131be2cc668fe8f1b536b3025dff14e1d231f


.NET/C# build insights support

I am trying to diagnose very slow build times in a large C# project (VBCSCompiler.exe pegging the CPU for ~90s after a one-liner change, every time). I would love to use WPA to diagnose what can cause this extreme CPU usage on every build when so little code has changed. Is there an equivalent of this but for C# projects instead of C++?

No, there is not currently an equivalent for C#.

Please open a suggestion here: https://developercommunity.visualstudio.com/


Teams

Hi Adi
I see you have added team management which is brilliant, as it's a feature I will need shortly, I just wanted to check what the current functionality is and what your future intentions are?

Hi Steve,
You can check the current functionality on the demo.
Currently it's simple implementation where you have the ability to define teams as group of users.
Regarding relationships you can do both:
$user->teams and $team->users (many to many).
And this will be a good fit for the next-gen packages that we are working on (discussions, a better documents manager etc)


Solving unstable postMethods ordering in process_schemas.py

solving issue #116, which about that the postMethod is unstably ordered.
The reason for the unstable ordering is because of line 207, the glob.glob() function returns an arbitrary order. Here is a discussion about glob.glob ordering
http://stackoverflow.com/questions/6773584/how-is-pythons-glob-glob-ordered

+1

+1

Great job, @MollyZhang


Fix Unions accept no field_declaration_list

This fixes #78
No change in tests due to all usages of unions in tests already uses the right syntax

Thanks!


FreeText annotation, does not support arabic

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: Google chrome 104.0.5112.79
Operating system and its version: Debian GNU/Linux 11 (bullseye)
PDF.js version: 2.15.349
Is a browser extension: No

Steps to reproduce the problem:

Open PDF file, try to add FreeText annotation in Arabic
Save PDF file and, you will find that Arabic text is not displayed probably

This is, for all intents and purposes, a duplicate of issue #12430 and bug 1666824.


bug in RDA eigenvalues

See here for some discussion. @Jorge-C are you available to work on this?

@mortonjt are you available to work on this for 0.5.0? We're shooting for June 7 to cut the release.

That's a pretty tight deadline - particularly with finals week approaching
...
If the deadline were couple days later, I'd be more inclined to try to
knock out this.
On Wed, Jun 1, 2016 at 1:46 PM, Jai Ram Rideout<EMAIL_ADDRESS>wrote:

@mortonjt https://github.com/mortonjt are you available to work on this
for 0.5.0? We're shooting for June 7 to cut the release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/biocore/scikit-bio/issues/1002#issuecomment-223119442,
or mute the thread
https://github.com/notifications/unsubscribe/AD_a3d--YxUEPNVl0MfgnnTpmTmYk5heks5qHe-_gaJpZM4FWr42
.

I'm okay with pushing the release date back a couple of days. @gregcaporaso @ebolyen any objections?

No objections.

@mortonjt we're now shooting for Friday 6/10 as the release date, does that work for you?

My final is on the 8th.  Let me see what I what I can do by this weekend.
That might be OK.
On Thu, Jun 2, 2016 at 10:35 AM, Jai Ram Rideout<EMAIL_ADDRESS>wrote:

@mortonjt https://github.com/mortonjt we're now shooting for Friday
6/10 as the release date, does that work for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/biocore/scikit-bio/issues/1002#issuecomment-223364757,
or mute the thread
https://github.com/notifications/unsubscribe/AD_a3VSNa-yg0JQGh_MEJtB5zbObFdsQks5qHxRogaJpZM4FWr42
.

Sounds good, let us know if you'll need more time

Ok, I think I figured out exactly what is going on in vegan.
In vegan, they are normalizing the eigenvalues by the number of samples
So their eigenvalues reported are actually as follows
eigvals = np.sqrt(s / n-1)

Where s is the eigenvalues from the np.linalg.svd,  n is the number of samples, and eigvals is the reported eigenvalues.
TL;DR  I think we were are doing here is perfectly legit.  Its just a matter of personal preference.  If we want to be consistent with vegan, the change is really easy.  However, I don't see the benefit of doing so.

What about adding an option, by default set to False, so the results match? Does vegan's manual state that deviation?

👎 Its off by a constant, which can be easily corrected by the user if need be.  Adding an extra flag would add unnecessary complexity to the API.
I think we should opt for the vegan approach, or use the existing approach.  We can add documentation if necessary, explaining exactly what happened.  Thoughts?

And no, vegan doc's didn't state this at all.  It required a little guesswork to validate this.

OK, what about adding two methods: rda, and rda_vegan, similar to beta divs: bray_curtis, bray_curtis_faith, bray_curtis_magurran? Agree on adding documentation about this difference is important.

Since it's just off by a constant, how about updating the docs for now to describe how the eigenvalues are different from vegan, and how to obtain vegan's normalized eigenvalues if that's desired? Probably worth noting that scikit-bio's eigenvalues match Legendre & Legendre.

:+1: for updating docs
On Jun 3, 2016 11:51 AM, "Jai Ram Rideout"<EMAIL_ADDRESS>wrote:

Since it's just off by a constant, how about updating the docs for now to
describe how the eigenvalues are different from vegan, and how to obtain
vegan's normalized eigenvalues if that's desired? Probably worth noting
that scikit-bio's eigenvalues match Legendre & Legendre.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/biocore/scikit-bio/issues/1002#issuecomment-223646002,
or mute the thread
https://github.com/notifications/unsubscribe/ADyuZMKK5yJfGe1cfIhr_5WwOaCnfb_4ks5qIGhygaJpZM4FWr42
.

Only updating the documentation is one solution and should be done either way but not having both implementations means that users will have to use R vs. skbio to reproduce plots.

👎, we already deviate from R/vegan API in several places. scikit-bio isn't a replacement for R/vegan, and if R behavior is desired, use R. vegan is one of many R packages implementing ecological statistics, and they all have different APIs and (sometimes) different results. If we implement functions to match vegan exactly, we'd also need to implement functions that match any number of other R packages (e.g., the Mantel test can be found in vegan, ecodist, ade4, ape, ncf, probably others).
I think where practical we should match vegan or whatever the most trusted source is. In this case, it seems more justified to match Legendre & Legendre because vegan is normalizing eigenvalues differently and it isn't documented why. If users want vegan's normalized eigenvalues, scikit-bio's docs will describe how to do that.

:+1: on docs. IMO, a clear note on how it differs from vegan is sufficient.
On Fri, Jun 3, 2016 at 4:12 PM, Jai Ram Rideout<EMAIL_ADDRESS>wrote:

👎, we already deviate from R/vegan API in several places. scikit-bio
isn't a replacement for R/vegan, and if R behavior is desired, use R. vegan
is one of many R packages implementing ecological statistics, and they all
have different APIs and (sometimes) different results. If we implement
functions to match vegan exactly, we'd also need to implement functions
that match any number of other R packages (e.g., the Mantel test can be
found in vegan, ecodist, ade4, ape, ncf, probably others).
I think where practical we should match vegan or whatever the most trusted
source is. In this case, it seems more justified to match Legendre &
Legendre because vegan is normalizing eigenvalues differently and it isn't
documented why. If users want vegan's normalized eigenvalues, scikit-bio's
docs will describe how to do that.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/biocore/scikit-bio/issues/1002#issuecomment-223716001,
or mute the thread
https://github.com/notifications/unsubscribe/AAc8svT6ihEHXNjkN9k7cZXHEGmcyNBqks5qILTHgaJpZM4FWr42
.

Agree with Jai. Ideally we will write a series of short papers
identifying/benchmarking such discrepancies and justifying why we use the
optimal one in skbio, but skbio should not be the variorum edition of every
method tweak in microbial ecology...
Note that the microbial ecology indices and analyses, although we typically
use them now for amplicon data, will need to be repurposed and
re-benchmarked for metabolomics, shotgun metagenomics etc. so there is a
lot of scope for exciting new work on existing methods.
On Jun 3, 2016, at 5:12 PM, Jai Ram Rideout<EMAIL_ADDRESS>wrote:
👎, we already deviate from R/vegan API in several places. scikit-bio isn't
a replacement for R/vegan, and if R behavior is desired, use R. vegan is
one of many R packages implementing ecological statistics, and they all
have different APIs and (sometimes) different results. If we implement
functions to match vegan exactly, we'd also need to implement functions
that match any number of other R packages (e.g., the Mantel test can be
found in vegan, ecodist, ade4, ape, ncf, probably others).
I think where practical we should match vegan or whatever the most trusted
source is. In this case, it seems more justified to match Legendre &
Legendre because vegan is normalizing eigenvalues differently and it isn't
documented why. If users want vegan's normalized eigenvalues, scikit-bio's
docs will describe how to do that.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/biocore/scikit-bio/issues/1002#issuecomment-223716001,
or mute the thread
https://github.com/notifications/unsubscribe/AB69Kc6zTOvBdg_uHGcBbz_b6IMN2YcQks5qILTIgaJpZM4FWr42
.

@mortonjt, I noticed skbio/stats/ordination/tests/test_redundancy_analysis.py has a few comments of the form # These are wrong. See issue #1002. When the docs are updated to "fix" this issue, can you also remove those comments from the code or update them to note why the expected eigenvalues are different?

Fixed in #1370, thanks @mortonjt!


Change extra-readme to readme

Fixes #176
@hassox / @scrogson — could you guys give this a quick sanity check?

👍


Data analysis

Easy to analyse
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8da6c49a-f7cc-213c-adc3-5b33b76716dd
Version Independent ID: 2be2786b-c764-c142-0821-24f6a28b2459
Content: Smart narratives tutorial - Power BI
Content Source: powerbi-docs/visuals/power-bi-visualization-smart-narrative.md
Service: powerbi
Sub-service: powerbi-ai
GitHub Login: @aphilip94
Microsoft Alias: anphil

Thanks for your comment, @Gaibusha. This issue has been assigned to the doc author for review.

Thanks you for your feedback, @Gaibusha.


rhood/2002-Compass Urgent Care Onboarding

This PR adds the Experity and Compass Urgent Care schemas for onboarding Compass Urgent Care.
If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.
Changes
Note, there are three additions below that are duplicated in Issue #2004 because I had to include them in each branch into order to fully test them.

Adds the Master Schema for Experity EMR - Note, Issue #2004 also has the exact same Experity Schema.
Adds the sub-schema for Compass Urgent Care
Added Compass Urgent Care to the organizations.yml
Added yamlitos to Staging & Prod for Compass Urgent Care
Contains the sender-automation.valueset - #2009 is the Pull Request for adding sender-automation.valuesets.
Contains the bug fix for Positive results not setting the OBX.8 to "A" for abnormal automatically  - #2010 is the Pull Request for the OBX.8 fix.

Checklist
Testing

[x] Tested locally?  The final CSV used for testing and the HL7 output is on my GDrive.
[x] Ran quickTest all?
[x] Ran ./prime test against local Docker ReportStream container?
[ ] Downloaded a file from http://localhost:7071/api/download?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Fixes
List GitHub issues this PR fixes

#2002

To Be Done
Create GitHub issues to track the work remaining, if any

#2010
#2009

Jim,
This is what I struggled with when trying to determine whether or not to
create 4 pull requests or 1 big pull request.  I think one pull request
would be best because GUC and CUC both use the Experity schema,
sender-automation.valuesets, and Mappers.kt fix.  Should I simply create
one branch with everything and one pull request?
Rick...
Rick Hood
Business Analyst
501 West Broadway, Suite 800
San Diego, CA 92101
@.***
Agile Six Applications, Inc.
A Service-Disabled Veteran-Owned Small Business (SDVOSB)
www.Agile6.com http://www.agile6.com/
On Mon, Aug 30, 2021 at 8:54 AM jimduff-usds @.***>
wrote:

@.**** requested changes on this pull request.
This doesn't look right: you've got
prime-router/metadata/schemas/Experity/experity-covid-19.schema
in both this and in your previous PR. You'll get all kinda conflicts.
I suggest:

Make sure you have the latest from master, and merge it into your
GUC PR, and test it. (you should aways do this prior to merging any PR
into master)
Then merge your GUC PR into master
Then merge master into this PR. I think as written, you'll get
conflicts. You'll want to removed the experity schema and the .md doc, I'm
guessing.
Then re-test
Then re-submit this PR.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/CDCgov/prime-reportstream/pull/2008#pullrequestreview-741676528,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUSS5CT2XH64UEUKIRDZ4TDT7OERNANCNFSM5C4IQBIQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


ftpcompile.sh missed from migration

@kadler I didn't find the ftpcompile.sh in GitHub which was in the first level directory in BitBucket. That script is used to push a build from linux to i and building PTF process also needs it.

looks like crt* files are all missing.

Yes, that is by design.
Everything should be built on IBM i with:
./configure --library mylib
make

@kadler I tried the new build way. It is pretty good!
Some chars in the xmlservice output of xml seems different with ccsid 37 job.  ! [ ] are not displayed correctly.  Used cpyf Toccsid(37) to convert but seems not right.
<success><|¢CDATA¢+++ success JIMOXML XMLTEST !!></success>

Run system "chgjob ccsid(37)" with cpyf Toccsid(37), ! [ ] were displayed correctly.

Close this and will handle the ccsid issue in the other issue #32


Feature Request: Enforcement of non-newline command terminator (e.g. semicolon) within scripts, via opt-in directive

Summary of the new feature/enhancement
Is there any mileage or desire for an option that enforces the use of semicolon (and only semicolon) as the command terminator for a given script?
I regularly find myself at odds between the "natural" line-continuation points within the PowerShell language, and where I want to place a newline for the long-term readability of my scripts.  As such, I find myself resorting to escaping newlines with the backtick, which I am repeatedly led to believe is a bad thing™.
I completely understand why the natural points are what they are, but most of the reasons seem to boil down to the expectation that a newline can terminate the command.  If the script parser could be informed that semicolon was the only command terminator in a given script, it could bypass having to make continuation checks at each newline and make whitespace mostly-insignificant.  This would allow for better alignment of pipelines and command parameters, without having to resort to backtick and without the language seeming to have opinions as to where line continuation should happen.
Proposed technical implementation details (optional)
I see this as an extension to #Requires because of its existing script scope, however, the notion of requiring command termination is not semantically ideal.  As such, this could reasonably be via any other script-wide directive.  It could be a dedicated Set-CommandTermination command, or maybe an additional parameter to Set-StrictMode (although there may be lexical scope expectations around such).
It would certainly need to be an opt-in state, so as not to affect existing scripts.
It might be desirable to later extend this to allow for alternate command terminators—such as DoubleNewline—for those who find semicolons repulsive.
It is intended to facilitate such script formatting as the following (which is appreciably my personal preference), without requiring further complex line-continuation checks:
Instead of...
Import-Module DummyExample
Invoke-DummyPipelineProducer -SomeArgument -OtherArgument |
  Invoke-DummyLongParameterList -SomeSwitch -OtherSwitch -SomeParameter 12345 -Expression (
    Invoke-DummyMethod | Select-Object -First 1) |
  Where-Object { $_.SomeProperty -contains (
    Invoke-DummyFilterList -Type A | Select-Object -First 1) } |
  Select-Object -ExpandProperty Foo |
  ForEach-Object {
    if (-not (Test-Dummy $_)) { Invoke-DummyAction $_ }
    else { Write-Verbose "$_ already done" }
  }

...or the backtick-laden...
Import-Module DummyExample
Invoke-DummyPipelineProducer -SomeArgument -OtherArgument `
  | Invoke-DummyLongParameterList `
      -SomeSwitch `
      -OtherSwitch `
      -SomeParameter 12345 `
      -Expression (Invoke-DummyMethod | Select-Object -First 1) `
  | Where-Object { $_.SomeProperty -contains (
      Invoke-DummyFilterList -Type A | Select-Object -First 1 `
    ) } `
  | Select-Object -ExpandProperty Foo `
  | ForEach-Object {
      if (-not (Test-Dummy $_)) { Invoke-DummyAction $_ }
      else { Write-Verbose "$_ already done" }
    }

...we could write...
#Requires -CommandTermination Semicolon;
Import-Module DummyExample;
Invoke-DummyPipelineProducer -SomeArgument -OtherArgument
  | Invoke-DummyLongParameterList
      -SomeSwitch
      -OtherSwitch
      -SomeParameter 12345
      -Expression (Invoke-DummyMethod | Select-Object -First 1)
  | Where-Object {
      $_.SomeProperty -contains (Invoke-DummyFilterList -Type A
                                   | Select-Object -First 1)
    }
  | Select-Object -ExpandProperty Foo
  | ForEach-Object {
      if (-not (Test-Dummy $_)) { Invoke-DummyAction $_ }
      else { Write-Verbose "$_ already done" }
    };

Unfortunately, I can't comment as to how much effort this would add to the script parser.

The pipe-after-newline thing is already a thing in PowerShell 7. So that's already in the parser.
The other one you mention (parameters after newlines), I think @KirkMunro had a PR for, though I'm not clear on whether it's one that was decided that is being accepted or not. No idea there.
You can also use splatting (see Get-Help about_Splatting) to define parameters before you call commands and make that look a bit neater.
Beyond that, see also @markekraus' wonderful post Bye Bye Backtick - there are a ton of natural newline continuations already available to you that most folks overlook.

The parameters-across-multiple-lines-without-backticks PR you mention - yet to be reviewed by the committee - is at https://github.com/PowerShell/PowerShell-RFC/pull/179.

Thank you both for your responses.  I am aware of both KirkMunro's PRs and the article that you link, and these were almost-exactly why I thought to make this suggestion in the first place.
The article is very thorough in its description of the places where natural line-continuation can take place, and nearly all of them are the opposite of where I would want to put them.  The rules are inconsistent (keyword foreach can, pipelined foreach can't; prefixed incrementors can, postfixed increment can't, etc.).  This seems more like an attempt to document the limitations of the parser, rather than an intentional effort to promote a consistent style.
Splatting is a useful nicety, but it feels like a band-aid which is being used precisely because there is no support for parameters being on their own line, rather than because it is the better way of calling commands.  For all its usefulness, there are certainly negative aspects (assignment of a new hashtable variable, loss of implicit unquoted strings, required explicit array notation, required explict $true/$false for [Switch] parameters, no tab completion in the editor, for example).
The recent work by KirkMunro seems admirable—indeed, he may have a similar coding style to my own—but I am not sure that iteratively altering the parser to suit coding style issues as they arise is the right approach, as it will surely only lead to a very, very complex set of rules.  RFC179 is already (rightfully) under scruitiny for backwards compatibility with prefixed iterators.
I appreciate that issues of coding style are entirely subjective but all of the issues I have come across seem to stem from the decision to treat newline as the command terminator.  I am not expecting a massive sea-change in that mentality after 7+ major iterations of the language, but it does seem to me that most of those style-related issues could be put to bed by "simply" allowing the script-writer to use alternative termination.
I understand that this is "deceptively simple-looking".  I concede I have no experience with language parsing (else I would attempt to investigate this myself) but does anyone have any notion as to how difficult it would be to alter the logic that identifies the end of a command?
Without looking, my best-guess at this stage is that PS parses a stream of "tokens" in some sort of finite state machine, with END-OF-COMMAND being one of those tokens, where END-OF-COMMAND is currently set as [newline OR semicolon] (since semicolon is already a command separator.  If that guesswork is anywhere near correct, couldn't a variable terminator be used instead?

It's not even really about identifying the end of a command. As you say, in many cases a newline is sufficient. However, there are cases where newlines are ignored, deliberately. Quite a lot of them, as you seem to be at some somewhat aware.
So you can't just look for a different token suddenly; all of that existing newline-ignoring code would break, and there is quite a lot of it. As far as I recall, there isn't an explicit end-of-command token for that reason; newlines are not always an end-of-command/expression/line/statement depending on context.
You'd have to find a way to introduce that concept to the parser without also breaking both the existing functionality, and also making sure that current line continuations still work correctly when you change the end-of-command/statement/expression/etc token.

(For clarity, the work that I had initially viewed by KirkMunro was the closed RFC#176, not the open one linked by mklement0 RFC#179 -- whether this materially impacts the discussion is unknown.)


Add the ability to install from the beta releases channel

I'd like the ability to install from the beta releases channel. I am pretty new to circleci orbs but I was able to inline this code in my repo to verify it works. It's probably worthwhile if you verify that it works as is in the orb and not inlined.
Also let me know if any other changes are required.

If you add a new test using the beta channel it would be helpful.

@marboledacci I am not sure how to actually run the test but based on what I understand from just looking at the other tests... this one should work.

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/flutter?version=dev:315a169a2ac1ef51ad6897a551a1ea754e189949

Looks like the test passed but integration-test-linux failed. Is that something you could help me debug and fix?
Pass:
Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel beta, 3.27.0-0.1.pre, on macOS 12.6.3 21G419 darwin-arm64, locale en-US)

Fail:
Job was rejected because resource class large, image android:2022.09.1 is not a valid resource class

I did some updates on branch PR-48 that should fix that, but was unable to update it in the PR, I don't know why.
Now there is a different error that I haven't time to look at, and will check next week.
If you want to contribute to that, you can check the build failure here

I did some updates on branch PR-48 that should fix that, but was unable to update it in the PR, I don't know why. Now there is a different error that I haven't time to look at, and will check next week. If you want to contribute to that, you can check the build failure here

It looks like it is running Gradle 9, has that always been the case? Is there a way to test it on Gradle 8?
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

I was able to solve this, but couldn't bring the changes to the PR, so I created #49. I'm going to close this one


MQTT client issue

So I noticed in the serial monitor when I shut down HA that it was giving an MQTT error ever 5 seconds even though none of the work modes were set to it
I unchecked use it and the errors went away.
I think the tickbox use should not be required.  As in if a zone was set to it, enable it.  Otherwise I think it is creating too much overhead checking every 5 seconds if it is not needed?
Thanks,
Grey

MQTT is used not only to display data for the display, but also to control the display regardless of the work mode of the zones. Thats why MQTT settings required "Enable checkbox".

OK, thanks


Update file sync planning with common sync scenarios and solutions

These are scenarios we see customers struggling with until they get a good understanding of File sync solution, its limits, supported config etc. On-premise file server solutions usually have complex, not very well-managed file servers and structure. Also many a times customer doesn't think about the Azure files or Storage account limits and want consolidated single file share. This table address most common scenarios we see with file servers and sync requirements.
Note: this work item has been discussed with Mike already.

Learn Build status updates of commit cfd034c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

includes/storage-files-migration-namespace-mapping.md
:warning:Warning

Details

includes/storage-files-migration-namespace-mapping.md

Line 68, Column 310: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#share-grouping' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 68, Column 432: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#volume-sync' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 69, Column 706: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#share-grouping' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 69, Column 828: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#volume-sync' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 68, Column 310: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#share-grouping' will be broken in isolated environments. Replace with a relative link.
Line 68, Column 432: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#volume-sync' will be broken in isolated environments. Replace with a relative link.
Line 69, Column 706: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#share-grouping' will be broken in isolated environments. Replace with a relative link.
Line 69, Column 828: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#volume-sync' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@khdownie
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@jeffpatt24 please take a look at this and let me know if OK to merge (once warnings are fixed). Thanks!

Learn Build status updates of commit 23a6181:
:warning: Validation status: warnings

File
Status
Preview URL
Details

includes/storage-files-migration-namespace-mapping.md
:warning:Warning

Details

includes/storage-files-migration-namespace-mapping.md

Line 68, Column 310: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#share-grouping' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 68, Column 432: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#volume-sync' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 69, Column 706: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#share-grouping' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 69, Column 828: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#volume-sync' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 68, Column 310: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#share-grouping' will be broken in isolated environments. Replace with a relative link.
Line 68, Column 432: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#volume-sync' will be broken in isolated environments. Replace with a relative link.
Line 69, Column 706: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#share-grouping' will be broken in isolated environments. Replace with a relative link.
Line 69, Column 828: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning#volume-sync' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 5d6fc59:
:warning: Validation status: warnings

File
Status
Preview URL
Details

includes/storage-files-migration-namespace-mapping.md
:warning:Warning

Details

includes/storage-files-migration-namespace-mapping.md

Line 68, Column 310: [Warning: file-not-found - See documentation] Invalid file link: '../../../includes/storage-files-migration-namespace-mapping.md'.
Line 68, Column 418: [Warning: file-not-found - See documentation] Invalid file link: '../../../includes/storage-files-migration-namespace-mapping.md'.
Line 69, Column 706: [Warning: file-not-found - See documentation] Invalid file link: '../../../includes/storage-files-migration-namespace-mapping.md'.
Line 69, Column 814: [Warning: file-not-found - See documentation] Invalid file link: '../../../includes/storage-files-migration-namespace-mapping.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit b1ea2cf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

includes/storage-files-migration-namespace-mapping.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@khdownie and @jeffpatt24 , could you please review this contribution. If any changes/optimization required, happy to look into again. Thanks!

Learn Build status updates of commit b6ba1dc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

includes/storage-files-migration-namespace-mapping.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@khdownie I have added the changes you recommended. Hope you can approve and merge.

Learn Build status updates of commit 6c0f6ee:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/storage/file-sync/file-sync-planning.md
:white_check_mark:Succeeded

includes/storage-files-migration-namespace-mapping.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 321467f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/storage/file-sync/file-sync-planning.md
:white_check_mark:Succeeded

includes/storage-files-migration-namespace-mapping.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit ae8f290:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/storage/file-sync/file-sync-planning.md
:white_check_mark:Succeeded

includes/storage-files-migration-namespace-mapping.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#sign-off

#sign-off

#sign-off

Learn Build status updates of commit 78d1f1c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/storage/file-sync/file-sync-planning.md
:white_check_mark:Succeeded

includes/storage-files-migration-namespace-mapping.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit e736123:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/storage/file-sync/file-sync-planning.md
:white_check_mark:Succeeded

includes/storage-files-migration-namespace-mapping.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#sign-off

@khdownie I can't see the changes reflecting in the main article https://learn.microsoft.com/en-us/azure/storage/file-sync/file-sync-planning but see the changes in the include file https://github.com/MicrosoftDocs/azure-docs/blob/main/includes/storage-files-migration-namespace-mapping.md. Is there anything additional required to make data from include articles visible or is it just some delay in sync?

@jithubhaijabs I can't see them either. Not sure what happened. Give it a day and see if it syncs - otherwise I will make the changes in another PR in private repo. They are simple changes, so easy fix. Thanks for pointing this out.

@khdownie its visible now :) Thanks!