[BUG] Setting and clearing the toleration : leaves some down nodes in Longhorn system

Describe the bug
In a cluster with control/etcd nodes separated from workers nodes, the control/etcd nodes become down state when users set then clear the special toleration : (which means it will tolerate every taints)
To Reproduce

Create a cluster of 4 nodes with 1 control/etcd node and 3 worker nodes
Install Longhorn. Set toleration : in Longhorn UI
Wait until all Longhorn components comeback, clear the toleration in Longhorn UI
Wait until all Longhorn components comeback. Go to nodes tab in Longhorn UI, see that the control/etcd node is in down state

Expected behavior
Longhorn should clean up the control/etcd node
Environment:

Longhorn version: master 12/02/2020

The current workaround is that users can manually delete the failed Longhorn node CRs by:
kubectl delete nodes.longhorn.io <FAILED-NODE-NAME>  -n longhorn-system

It may be that this issue has either been fixed or morphed into something else with the passage of time.  When I do the steps to reproduce, setting the toleration to ":" does indeed force a general rescheduling of pods, some of which end up on the control-plane node:
 == k8s nodes ==
NAME                           STATUS   ROLES                       AGE     VERSION
jbm-u22-pool1-151e5e81-9wg5r   Ready    control-plane,etcd,master   3d18h   v1.25.15+rke2r2
jbm-u22-pool2-ca5a5aa4-bxbgr   Ready    worker                      3d18h   v1.25.15+rke2r2
jbm-u22-pool2-ca5a5aa4-glvzc   Ready    worker                      3d18h   v1.25.15+rke2r2
jbm-u22-pool2-ca5a5aa4-rb299   Ready    worker                      3d18h   v1.25.15+rke2r2

 == longhorn.io nodes ==
NAME                           READY   ALLOWSCHEDULING   SCHEDULABLE   AGE
jbm-u22-pool2-ca5a5aa4-bxbgr   True    true              True          2d20h
jbm-u22-pool2-ca5a5aa4-glvzc   True    true              True          2d20h
jbm-u22-pool2-ca5a5aa4-rb299   True    true              True          2d20h

 == pods ==
csi-attacher-776c477d6f-tlrh5                       1/1     Running   0               64s     <IP_ADDRESS>   jbm-u22-pool1-151e5e81-9wg5r   <none>           <none>
csi-provisioner-7d8d8d9887-b8cr4                    1/1     Running   0               64s     <IP_ADDRESS>   jbm-u22-pool1-151e5e81-9wg5r   <none>           <none>
csi-resizer-5bfd4fb474-blk7m                        1/1     Running   0               64s     <IP_ADDRESS>   jbm-u22-pool1-151e5e81-9wg5r   <none>           <none>
csi-snapshotter-68db784d4-ctcvr                     1/1     Running   0               64s     <IP_ADDRESS>   jbm-u22-pool1-151e5e81-9wg5r   <none>           <none>
engine-image-ei-b907910b-54lzc                      1/1     Running   0               64s     <IP_ADDRESS>   jbm-u22-pool1-151e5e81-9wg5r   <none>           <none>
longhorn-csi-plugin-msdfh                           3/3     Running   0               64s     <IP_ADDRESS>   jbm-u22-pool1-151e5e81-9wg5r   <none>           <none>

But when the setting is cleared again, they go back meekly to the worker nodes.
 == k8s nodes ==
NAME                           STATUS   ROLES                       AGE     VERSION
jbm-u22-pool1-151e5e81-9wg5r   Ready    control-plane,etcd,master   3d18h   v1.25.15+rke2r2
jbm-u22-pool2-ca5a5aa4-bxbgr   Ready    worker                      3d18h   v1.25.15+rke2r2
jbm-u22-pool2-ca5a5aa4-glvzc   Ready    worker                      3d18h   v1.25.15+rke2r2
jbm-u22-pool2-ca5a5aa4-rb299   Ready    worker                      3d18h   v1.25.15+rke2r2

 == longhorn.io nodes ==
NAME                           READY   ALLOWSCHEDULING   SCHEDULABLE   AGE
jbm-u22-pool2-ca5a5aa4-bxbgr   True    true              True          2d20h
jbm-u22-pool2-ca5a5aa4-glvzc   True    true              True          2d20h
jbm-u22-pool2-ca5a5aa4-rb299   True    true              True          2d20h

 == pods ==

Further, the control-plane node was never one of the nodes.longhorn.io set, and its status appears to be fine.
 kl get node.longhorn.io jbm-u22-pool1-151e5e81-9wg5r
Error from server (NotFound): nodes.longhorn.io "jbm-u22-pool1-151e5e81-9wg5r" not found

k get node  jbm-u22-pool1-151e5e81-9wg5r -o yaml
apiVersion: v1
kind: Node
metadata:
annotations:
alpha.kubernetes.io/provided-node-ip: <IP_ADDRESS>
cluster.x-k8s.io/cluster-name: jbm-u22
cluster.x-k8s.io/cluster-namespace: fleet-default
cluster.x-k8s.io/machine: jbm-u22-pool1-65dc765487-9qkgn
cluster.x-k8s.io/owner-kind: MachineSet
cluster.x-k8s.io/owner-name: jbm-u22-pool1-65dc765487
etcd.rke2.cattle.io/local-snapshots-timestamp: "2023-12-18T15:00:02Z"
etcd.rke2.cattle.io/node-address: <IP_ADDRESS>
etcd.rke2.cattle.io/node-name: -cde1bc2e
management.cattle.io/pod-limits: '{"cpu":"200m","memory":"192Mi"}'
management.cattle.io/pod-requests: '{"cpu":"1225m","memory":"2320Mi","pods":"15"}'
node.alpha.kubernetes.io/ttl: "0"
projectcalico.org/IPv4Address: <IP_ADDRESS>/20
projectcalico.org/IPv4VXLANTunnelAddr: <IP_ADDRESS>
rke2.io/encryption-config-hash: start-efd353c6a2bf99b3d51614646649f9a0771596c008d74cc8099ae14a5e7eb3a9
rke2.io/hostname: jbm-u22-pool1-151e5e81-9wg5r
rke2.io/internal-ip: <IP_ADDRESS>
rke2.io/node-args: '["server","--agent-token","","--cni","calico","--disable-kube-proxy","false","--etcd-expose-metrics","false","--etcd-snapshot-retention","5","--etcd-snapshot-schedule-cron","0
*/5 * * *","--kube-controller-manager-arg","cert-dir=/var/lib/rancher/rke2/server/tls/kube-controller-manager","--kube-controller-manager-arg","secure-port=10257","--kube-controller-manager-extra-mount","/var/lib/rancher/rke2/server/tls/kube-controller-manager:/var/lib/rancher/rke2/server/tls/kube-controller-manager","--kube-scheduler-arg","cert-dir=/var/lib/rancher/rke2/server/tls/kube-scheduler","--kube-scheduler-arg","secure-port=10259","--kube-scheduler-extra-mount","/var/lib/rancher/rke2/server/tls/kube-scheduler:/var/lib/rancher/rke2/server/tls/kube-scheduler","--node-label","rke.cattle.io/machine=09b89719-1c9c-4222-aef6-94601d5fb41c","--node-taint","node-role.kubernetes.io/control-plane:NoSchedule","--node-taint","node-role.kubernetes.io/etcd:NoExecute","--private-registry","/etc/rancher/rke2/registries.yaml","--protect-kernel-defaults","false","--token",""]'
rke2.io/node-config-hash: SG666XHEYZ62UENCBAKYNM6673XAFAYJ37PCIQWUDATYUODRGQPQ====
rke2.io/node-env: '{}'
volumes.kubernetes.io/controller-managed-attach-detach: "true"
creationTimestamp: "2023-12-15T00:54:07Z"
finalizers:

wrangler.cattle.io/node
wrangler.cattle.io/managed-etcd-controller
labels:
beta.kubernetes.io/arch: amd64
beta.kubernetes.io/instance-type: rke2
beta.kubernetes.io/os: linux
kubernetes.io/arch: amd64
kubernetes.io/hostname: jbm-u22-pool1-151e5e81-9wg5r
kubernetes.io/os: linux
node-role.kubernetes.io/control-plane: "true"
node-role.kubernetes.io/etcd: "true"
node-role.kubernetes.io/master: "true"
node.kubernetes.io/instance-type: rke2
plan.upgrade.cattle.io/system-agent-upgrader: 7dbfe3bc7aa1f9e217597840afda8c191bdef89403968ed04de99eec
rke.cattle.io/machine: 09b89719-1c9c-4222-aef6-94601d5fb41c
name: jbm-u22-pool1-151e5e81-9wg5r
resourceVersion: "2450457"
uid: 90e8597b-c149-43b6-9139-22bb3b5ed7cb
spec:
podCIDR: <IP_ADDRESS>/24
podCIDRs:
<IP_ADDRESS>/24
providerID: rke2://jbm-u22-pool1-151e5e81-9wg5r
taints:
effect: NoSchedule
key: node-role.kubernetes.io/control-plane
effect: NoExecute
key: node-role.kubernetes.io/etcd
status:
addresses:
address: <IP_ADDRESS>
type: InternalIP
address: jbm-u22-pool1-151e5e81-9wg5r
type: Hostname
allocatable:
cpu: "2"
ephemeral-storage: "78900761129"
hugepages-2Mi: "0"
memory: 4018124Ki
pods: "110"
capacity:
cpu: "2"
ephemeral-storage: 81106868Ki
hugepages-2Mi: "0"
memory: 4018124Ki
pods: "110"
conditions:
lastHeartbeatTime: "2023-12-15T00:55:22Z"
lastTransitionTime: "2023-12-15T00:55:22Z"
message: Calico is running on this node
reason: CalicoIsUp
status: "False"
type: NetworkUnavailable
lastHeartbeatTime: "2023-12-18T19:35:55Z"
lastTransitionTime: "2023-12-15T00:54:05Z"
message: kubelet has sufficient memory available
reason: KubeletHasSufficientMemory
status: "False"
type: MemoryPressure
lastHeartbeatTime: "2023-12-18T19:35:55Z"
lastTransitionTime: "2023-12-15T00:54:05Z"
message: kubelet has no disk pressure
reason: KubeletHasNoDiskPressure
status: "False"
type: DiskPressure
lastHeartbeatTime: "2023-12-18T19:35:55Z"
lastTransitionTime: "2023-12-15T00:54:05Z"
message: kubelet has sufficient PID available
reason: KubeletHasSufficientPID
status: "False"
type: PIDPressure
lastHeartbeatTime: "2023-12-18T19:35:55Z"
lastTransitionTime: "2023-12-15T00:55:18Z"
message: kubelet is posting ready status. AppArmor enabled
reason: KubeletReady
status: "True"
type: Ready
daemonEndpoints:
kubeletEndpoint:
Port: 10250
images:
names:

docker.io/rancher/rancher-agent@sha256:992e1f2c8131e12456dd15fef45cd6308859c42be4fa39b80180592fd888d2b8
docker.io/rancher/rancher-agent:v2.7.4
sizeBytes: 436600368

names:

docker.io/rancher/hardened-kubernetes@sha256:afd6bfa5b6b8b3f907be8437ee6472f35958662fa227462756ce0d1174b2ecc7
docker.io/rancher/hardened-kubernetes:v1.25.15-rke2r2-build20231102
sizeBytes: 214396534

names:

docker.io/longhornio/longhorn-engine@sha256:a087938ab55640b5561cd6d84ecafb6787cc6e81db2dbec52c08c5aa57c93089
docker.io/longhornio/longhorn-engine:master-head
sizeBytes: 129094759

names:

docker.io/longhornio/longhorn-manager@sha256:47bf326dc65be10ca63cbca549dbaf08a4dfc5828e15749ecedf224bb0a8b193
docker.io/longhornio/longhorn-manager:master-head
sizeBytes: 111285754

names:

docker.io/rancher/mirrored-calico-cni@sha256:d4ed12d28127c9570bf773016857c8cdc20d7862eaebd74d3d0fc7b345cc74f7
docker.io/rancher/mirrored-calico-cni:v3.26.1
sizeBytes: 93375345

names:

docker.io/rancher/klipper-helm@sha256:b0b0c4f73f2391697edb52adffe4fc490de1c8590606024515bb906b2813554a
docker.io/rancher/klipper-helm:v0.8.2-build20230815
sizeBytes: 90877642

names:

docker.io/rancher/mirrored-calico-node@sha256:65dfcd7a75c52ae5303af4b03d24d522133d7ec1135e1855ea9ee35ebec33ce2
docker.io/rancher/mirrored-calico-node:v3.26.1
sizeBytes: 86591907

names:

docker.io/rancher/hardened-etcd@sha256:c4d25c075d5d61b1860ae5496d1acc8f88dd3a8be6024b37207901da744efa08
docker.io/rancher/hardened-etcd:v3.5.9-k3s1-build20230802
sizeBytes: 64402047

names:

docker.io/rancher/hardened-coredns@sha256:3bbaf490bb8cd2d5582f6873e223bb2acec83cbcef88b398871f27a88ee1f820
docker.io/rancher/hardened-coredns:v1.10.1-build20230607
sizeBytes: 64397511

names:

docker.io/rancher/rke2-cloud-provider@sha256:e2d98791f28b7aed3ab99afb99b52310eb1a36844b9bc9c497ebce327e4c68d5
docker.io/rancher/rke2-cloud-provider:v1.26.3-build20230406
sizeBytes: 63663048

names:

docker.io/rancher/hardened-cluster-autoscaler@sha256:462d646604da3600521bff37608e1c03af322c30983c97c039fdc4afb7b69836
docker.io/rancher/hardened-cluster-autoscaler:v1.8.6-build20230609
sizeBytes: 58304503

names:

docker.io/rancher/mirrored-calico-kube-controllers@sha256:5e0df66c5028b9cab397e44970f747023d0fe5f9162c95920689248650f8a6d6
docker.io/rancher/mirrored-calico-kube-controllers:v3.26.1
sizeBytes: 32799621

names:

docker.io/longhornio/csi-provisioner@sha256:5005886e5beb365ce41b2c688d156be13da7f57d35b0894064b3d3db987f601a
docker.io/longhornio/csi-provisioner:v3.6.0
sizeBytes: 28656962

names:

docker.io/rancher/mirrored-calico-typha@sha256:47b7aa28a2e5bfd847be633aa5a825e5b5489b4e333213036c468c6141debc93
docker.io/rancher/mirrored-calico-typha:v3.26.1
sizeBytes: 28262748

names:

docker.io/rancher/system-agent@sha256:9bb6379007c4afd99948507f82f3b62a9c06ac889fe1baaae4ef0628249ceee3
docker.io/rancher/system-agent:v0.3.2-suc
sizeBytes: 27695105

names:

docker.io/longhornio/csi-resizer@sha256:9c70e50427afd9171d43506e141eab09993642f280a835d8be3e4a8e5c8d6d88
docker.io/longhornio/csi-resizer:v1.9.0
sizeBytes: 26957768

names:

docker.io/longhornio/csi-snapshotter@sha256:195d700862588836e5014dfc36d1267926c392605e296658f99691d47667395d
docker.io/longhornio/csi-snapshotter:v6.3.0
sizeBytes: 26794997

names:

docker.io/longhornio/csi-attacher@sha256:649954eacbea9b0dfa3de8163bb2931bc23ab721c3f1f87d0de0488424528f54
docker.io/longhornio/csi-attacher:v4.4.0
sizeBytes: 26684753

names:

docker.io/rancher/mirrored-calico-operator@sha256:5d91bf2448b434e42f074e096f6f433fcd0e41c9a4823afdeb8bfa4195196ba9
docker.io/rancher/mirrored-calico-operator:v1.30.4
sizeBytes: 21216633

names:

docker.io/longhornio/csi-node-driver-registrar@sha256:698949b9997d6d2779ade2d3563951aed06e5d480426a6bc33344fdb5132050b
docker.io/longhornio/csi-node-driver-registrar:v2.9.0
sizeBytes: 10755623

names:

docker.io/longhornio/livenessprobe@sha256:f0f8695d321ae8ca3e1fcb88e12a54a466a14182752212b674eb6e997bb2d14b
docker.io/longhornio/livenessprobe:v2.11.0
sizeBytes: 9696399

names:

docker.io/rancher/system-upgrade-controller@sha256:f4dcde2abcaa21b72247a13bb4c063e40e9803e18a9d5bb3f38038f628cb10ff
docker.io/rancher/system-upgrade-controller:v0.10.0
sizeBytes: 8592158

names:

docker.io/rancher/mirrored-calico-pod2daemon-flexvol@sha256:f490933d59c85bfb33530b762aa8040d9810e2da1c2fb3e039118bfaed2de14c
docker.io/rancher/mirrored-calico-pod2daemon-flexvol:v3.26.1
sizeBytes: 7290863

names:

docker.io/rancher/pause@sha256:036d575e82945c112ef84e4585caff3648322a2f9ed4c3a6ce409dd10abc4f34
docker.io/rancher/pause:3.6
sizeBytes: 299396
nodeInfo:
architecture: amd64
bootID: 2a902a68-075f-4b64-897f-4ece58de1615
containerRuntimeVersion: containerd://1.7.7-k3s1
kernelVersion: 5.15.0-67-generic
kubeProxyVersion: v1.25.15+rke2r2
kubeletVersion: v1.25.15+rke2r2
machineID: 33f7658762d7156f41d21360657ba35d
operatingSystem: linux
osImage: Ubuntu 22.04.2 LTS
systemUUID: 73b0bb4a-6ea5-4664-b5a9-e42f3fdf9d11

It may be that this issue has either been fixed or morphed into something else with the passage of time.  When I do the steps to reproduce, setting the toleration to ":" does indeed force a general rescheduling of pods, some of which end up on the control-plane node:
 == k8s nodes ==
NAME                           STATUS   ROLES                       AGE     VERSION
jbm-u22-pool1-151e5e81-9wg5r   Ready    control-plane,etcd,master   3d18h   v1.25.15+rke2r2
jbm-u22-pool2-ca5a5aa4-bxbgr   Ready    worker                      3d18h   v1.25.15+rke2r2
jbm-u22-pool2-ca5a5aa4-glvzc   Ready    worker                      3d18h   v1.25.15+rke2r2
jbm-u22-pool2-ca5a5aa4-rb299   Ready    worker                      3d18h   v1.25.15+rke2r2

 == longhorn.io nodes ==
NAME                           READY   ALLOWSCHEDULING   SCHEDULABLE   AGE
jbm-u22-pool2-ca5a5aa4-bxbgr   True    true              True          2d20h
jbm-u22-pool2-ca5a5aa4-glvzc   True    true              True          2d20h
jbm-u22-pool2-ca5a5aa4-rb299   True    true              True          2d20h

Hi @james-munson ! The nodes.longhorn.io doesn't seem to be available on the master node. Did you copy the correct output?

That was the complete output of kubectl -n longhorn-system get nodes.longhorn.io

For what it is worth, the regression test case commented out in https://github.com/longhorn/longhorn-tests/pull/495 does still fail when enabled.  So I do need to figure out what the failure is.

A couple of controllers have a note in comments that
            // there is no Longhorn node created for the Kubernetes
            // node (e.g. controller/etcd node). Skip it

https://github.com/longhorn/longhorn-manager/blob/7aa262549f443166d63becf5f8a2ecd351e88c73/controller/backing_image_data_source_controller.go#L938
https://github.com/longhorn/longhorn-manager/blob/7aa262549f443166d63becf5f8a2ecd351e88c73/controller/instance_manager_controller.go#L906

Thanks, @PhanLe1010 . That was the complete output of kubectl -n longhorn-system get nodes.longhorn.io

Thank you for the confirm. I see why the issue no longer exist:

In the past, the setting  taint-toleration controls both user-deployed comments (longhorn-manager deamonset, longhorn-ui, longhorn driver deployer) and longhorn managed components (instance-manager, csi-xxx sidecars,..). Therefore, when users change the taint-toleration setting to : , longhorn-manager pod is also deployed on the master node. This longhorn-manager pod created a nodes.longhorn.io CR for master node. Then when users clear the setting taint-toleration setting, longhorn-manager pod is removed from master node which leaves the nodes.longhorn.io CR of master node in down state forever
Now, the setting  taint-toleration only controls longhorn managed components(instance-manager, csi-xxx sidecars,..). Therefore, when users change the taint-toleration setting to : , longhorn-manager pod is NOT deployed on the master node. So there is no nodes.longhorn.io CR created for the master node. Then when users clear the setting taint-toleration setting, there is no leftover nodes.longhorn.io CR on the master node. We are good now

For what it is worth, the regression test case commented out in longhorn/longhorn-tests#495 does still fail when enabled. So I do need to figure out what the failure is.

Could you provide the logs when it failed?
Btw, I usually do this when I want to run a specific test:

cd into test repo. Deploy backup target kubectl apply -f manager/integration/deploy/backupstores/
Modify test.yaml at manager/integration/deploy/test.yaml to add a sleep command:

spec:
  containers:
  - name: longhorn-test
    image: longhornio/longhorn-manager-test:master-head
    command: ["/bin/sh", "-c", "sleep 36000000"]

deploy the test pod kubectl apply -f manager/integration/deploy/test.yaml
exec into the test pod k exec -it longhorn-test -- bin/bash
The the specific test case pytest -svvl test_setting.py::test_setting_toleration_extra

Thanks for the tip!
I saw it fail in regression run https://ci.longhorn.io/job/private/job/longhorn-tests-regression/5388/console
    def wait_for_toleration_update(core_api, apps_api, count,  # NOQA
                                   expected_tolerations,
                                   chk_removed_tolerations=[]):
        not_managed_apps = [
            "csi-attacher",
            "csi-provisioner",
            "csi-resizer",
            "csi-snapshotter",
            "longhorn-csi-plugin",
            "longhorn-driver-deployer",
            "longhorn-manager",
            "longhorn-ui",
        ]
        updated = False
        for _ in range(RETRY_COUNTS):
            time.sleep(RETRY_INTERVAL_LONG)

            updated = True
            if not check_workload_update(core_api, apps_api, count):
                updated = False
                continue

            pod_list = core_api.list_namespaced_pod(LONGHORN_NAMESPACE).items
            for p in pod_list:
                managed_by = p.metadata.labels.get('longhorn.io/managed-by', '')
                if str(managed_by) != "longhorn-manager":
                    continue
                else:
                    app_name = str(p.metadata.labels.get('app', ''))
                    assert app_name not in not_managed_apps

                if p.status.phase != "Running" \
                    or not check_tolerations_set(p.spec.tolerations,
                                                 expected_tolerations,
                                                 chk_removed_tolerations):
                    updated = False
                    break
            if updated:
                break
>       assert updated
E       assert False

Sorry, no idea on top of my head. I would set a breakpoint at the function wait_for_toleration_update and manually step through the test to see where it stuck exactly and how it stuck

In the re-added case, the check fails on this line in
56  	def check_workload_update(core_api, apps_api, count):  # NOQA
 57  	    da_list = apps_api.list_namespaced_daemon_set(LONGHORN_NAMESPACE).items
 58  	    for da in da_list:
 59  	        if da.status.updated_number_scheduled != count:
 60  ->	            return False

The item that fails is
(Pdb) print(da)
{'api_version': None,
 'kind': None,
 'metadata': {'annotations': {'deprecated.daemonset.template.generation': '29',
                              'longhorn.io/last-applied-tolerations': '[{"operator":"Exists"}]'},
              'creation_timestamp': datetime.datetime(2023, 12, 15, 22, 33, 45, tzinfo=tzlocal()),
              'deletion_grace_period_seconds': None,
              'deletion_timestamp': None,
              'finalizers': None,
              'generate_name': None,
              'generation': 29,
              'labels': {'longhorn.io/component': 'engine-image',
                         'longhorn.io/engine-image': 'ei-b907910b',
                         'longhorn.io/managed-by': 'longhorn-manager'},
... etc

And that makes sense, I think because at this point the daemonsets look like:
kl get daemonsets
NAME                       DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE
engine-image-ei-b907910b   4         4         4       4            4           <none>          5d1h
longhorn-csi-plugin        4         4         4       4            4           <none>          5d1h
longhorn-manager           3         3         3       3            3           <none>          5d1h

So the longhorn-manager has behaved itself, and we have indeed not made a misleading extra nodes.longhorn.io item for the master node.  So are we really unhappy with engine-image and the csi-plugin having expanded there?  When the toleration is removed, the daemonsets will shrink again.

We can

Find a way to keep the other daemonsets from expanding outside of the nodes.longhorn.io list, or
Doctor the test checking criteria, or
Continue to leave the test case commented out (and extend the comment) but close this issue because the stated problem of a bogus down master node is no longer true.

This is not an issue anymore. Closing this issue.


Enrich handlers

All of them should be inherit/implement something that can handle HTTP500 returns

And  some how manage path/prefix/domains correctly.
A list of 'prefix' should be allowed, handlers deployed on root and all suffixes (in order to allow KC style urls alongisde the standard root one).
Redirects/form actions should be able to 'keep' the prefix

The baseUrl (typically 'localhost') and scheme should be handled as well.


Ignore arbitrary keys in YAML front matter

I have a lot of blog content that is using the YAML pandoc header, but it includes unsupported items in the YAML. If possible, can those just be ignored? Right now the map won't publish.

Are they complex structures, or just key-value mappings? For simple key-value content, we could map them to <data> elements.

They're simple structures.
https://github.com/pixlsus/website/blob/master/src/articles/a-q-a-with-photographer-riley-brandt/index.md is a very typical example, as is all the other posts from that repo.
On April 27, 2017 11:53:30 PM PDT, Jarno Elovirta<EMAIL_ADDRESS>wrote:

Are they complex structures, or just key-value mappings? For simple
key-value content, we could map them to <data> elements.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/jelovirt/dita-ot-markdown/issues/43#issuecomment-297922401

There should be generic solution to metadata mapping, not sure how to handle the mapping definition.
Do you need to retain all the information in MarkDown, or is it enough for now to simply ignore the unsupported fields?

I would be happy if they were ignored and the publish was successful.
Off the top of my head, I'd think that mapping each unknown yaml key name to a data field where data's name attribute is the name of the unknown yaml key would be reasonable. In dita, you can nest data inside itself. Another option might be to provide an extension point or template that a customized plugin can use to further process unsupported yaml metadata.  In this case the remaining unsupported metadata is ignored.
On April 28, 2017 12:05:09 AM PDT, Jarno Elovirta<EMAIL_ADDRESS>wrote:

There should be generic solution to metadata mapping, not sure how to
handle the mapping definition.
Do you need to retain all the information in MarkDown, or is it enough
for now to simply ignore the unsupported fields?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/jelovirt/dita-ot-markdown/issues/43#issuecomment-297924279

Really looking forward to this feature, thank you!


PoC for libssh2 CVE-2019-17498

Please could somebody merge this?

Semmle/SecurityExploits has been migrated to (a subdirectory of) github/security-lab, so I am closing this PR and have reopened it here: https://github.com/github/security-lab/pull/20


Can't serve ansible.module_utils.distro._distro using default python3 packages on Rocky Linux.

Just trying to get ansible-mitogen working on a Rocky Linux 8.5 system. I'm using:

python 3.6.8 (which is what dnf install python3 provides) as I believe that is the latest which has access to the selinux bindings on EL8)
ansible --version reports core 2.11.9 (again, the current default pip-installed version for this python).
I have tried both mitogen 0.3.2 (which is what pip installs) and the master branch.

I have a playbook like this:
- hosts: all
  strategy: linear
  gather_facts: no
  become: yes
  tasks:
  - name: Install Python if necessary.
    raw: test -e /usr/bin/python3 || yum install -y python3

- hosts: all
  gather_facts: no
  vars:
    ansible_python_interpreter: /usr/bin/python3
  tasks:
    - shell: hostname

it fails on the 2nd play with The Mitogen master process was unable to serve 'ansible.module_utils.distro._distro'.
I have searched the issues tracker, but anything relevant looks like it got fixed in 0.3.
Is this an acceptable python / ansible combination? I am a bit confused from the docs to be honest!
Thanks for any help, really interested to try this.

Looks like it does exist for the python I'm using though:
(venv) [rocky@testhost mitogen-test]$ python3 -c "from ansible.module_utils import distro; print(distro)"
<module 'distro' from '/home/rocky/mitogen-test/venv/lib64/python3.6/site-packages/distro/__init__.py'>

Error part of logs:
[DEPRECATION WARNING]: Ansible will require Python 3.8 or newer on the
controller starting with Ansible 2.12. Current version: 3.6.8 (default, Nov  9
2021, 14:44:26) [GCC 8.5.0 20210514 (Red Hat 8.5.0-3)]. This feature will be
removed from ansible-core in version 2.12. Deprecation warnings can be disabled
 by setting deprecation_warnings=False in ansible.cfg.

[WARNING]:
[mux  3777346] 14:46:38.608236 W mitogen.service: Pool(8fd0, size=32, th='mitogen.Pool.8fd0.0'): call error: Message(0, 1, 0, 110, 1000, b"\x80\x02X'\x00\x00\x00ansible_mitogen.services.ContextServiceq\x00X\x03"..757): builtins.ModuleNotFoundError: The Mitogen master process was unable to serve 'ansible.module_utils.distro._distro'. It may be a native Python extension, or it may be missing entirely. Check the importer debug logs on the master for more information.
  File "<stdin>", line 3669, in _dispatch_one
  File "<stdin>", line 3656, in _parse_request
  File "<stdin>", line 668, in import_module
  File "<stdin>", line 1516, in load_module
  File "master:/home/rocky/slurm-app-mitogen/venv/lib64/python3.6/site-packages/ansible_mitogen/target.py", line 85, in <module>
    import ansible_mitogen.runner
  File "<stdin>", line 1516, in load_module
  File "master:/home/rocky/slurm-app-mitogen/venv/lib64/python3.6/site-packages/ansible_mitogen/runner.py", line 85, in <module>
    import ansible.module_utils.basic
  File "<stdin>", line 1516, in load_module
  File "master:/home/rocky/slurm-app-mitogen/venv/lib64/python3.6/site-packages/ansible/module_utils/basic.py", line 153, in <module>
    from ansible.module_utils.common.sys_info import (
  File "<stdin>", line 1516, in load_module
  File "master:/home/rocky/slurm-app-mitogen/venv/lib64/python3.6/site-packages/ansible/module_utils/common/sys_info.py", line 10, in <module>
    from ansible.module_utils import distro
  File "<stdin>", line 1516, in load_module
  File "master:/home/rocky/slurm-app-mitogen/venv/lib64/python3.6/site-packages/ansible/module_utils/distro/__init__.py", line 45, in <module>
    from ansible.module_utils.distro import _distro as distro
  File "<stdin>", line 1491, in load_module

[WARNING]:
[task 3777380] 14:46:38.609653 W ansible_mitogen.connection: Connection failed; stack configuration was:
({'kwargs': {'check_host_keys': 'ignore',
             'compression': True,
             'connect_timeout': 10,
             'hostname': '<IP_ADDRESS>',
             'identities_only': False,
             'identity_file': '/home/rocky/.ssh/id_rsa_slurm_app_ci',
             'keepalive_count': 10,
             'keepalive_interval': 30,
             'password': None,
             'port': None,
             'python_path': ['/usr/bin/python3'],
             'remote_name': None,
             'ssh_args': ['-o',
                          'ControlMaster=auto',
                          '-o',
                          'ControlPersist=240s',
                          '-o',
                          'PreferredAuthentications=publickey',
                          '-o',
                          'UserKnownHostsFile=/dev/null'],
             'ssh_debug_level': None,
             'ssh_path': 'ssh',
             'username': 'rocky'},
  'method': 'ssh'},)

(venv) [rocky@testhost slurm-app-mitogen]$ python3
Python 3.6.8 (default, Nov  9 2021, 14:44:26)
[GCC 8.5.0 20210514 (Red Hat 8.5.0-3)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from ansible.module_utils import distro
>>> from ansible.module_utils.distro import _distro as distro
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name '_distro'
>>>

On the other hand, after looking at venv/lib64/python3.6/site-packages/distro/distro.py, this works:
>>> from ansible.module_utils.distro.distro import _distro as distro

Agh. This fixes it:
 pip install distro==1.6.0
```.

Looks like this is https://github.com/mitogen-hq/mitogen/issues/906

This should now be fixed in master along with #906, by #913


Add a function call example for OpenAI

/claim #469
I've inserted a section of code that simulates making a function call via the OpenAI API. The system message establishes that the assistant can make function calls, and the user message specifies the function call ("Function: Tell me a joke about programming").
If OpenAI were to support function calls natively in the future, then the function_call parameter (which is hypothetical and not currently supported) could be used to specify the function name and any necessary arguments.

@ericallam let me know if you need any changes or something.

We appreciate the contribution but this issue was assigned to @RamK777-stack and he's submitted a competing PR, so I'm just going to close this for now 👍


Test of uniformity of p-values

ConformalPredictiveSystem.evaluate may return the result of a test of uniformity of p-values

This sounds like an excellent idea. I would propose the Kolmogorov–Smirnov test (https://en.wikipedia.org/wiki/Kolmogorov–Smirnov_test) as an initial implementation. It is simple, and non-parametric. Of course, an alternative would be a test martingale, but it might be computationally heavy in comparison.


Loading a KET file in macro mode, bond connections are preserved but microstructures are shifted

Steps to Reproduce

Open KET file in macro mode->Flex mode
template009.zip

Example of initial structure:

Note: If we open saved file in Micro mode structures not shifted.
Actual behavior
After open saved KET file in macro mode bond connections are preserved however micro structures are shifted

Expected behavior
After open saved KET file in macro mode bond connections are preserved and micro structures not shifted to new positions

Desktop:

OS: Windows 11
Browser Chrome
Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.6]
Indigo version
[Version 1.25.0-rc.4]
#188497033

Tested. Bug fixed for load KET and MOL V3000.

Desktop:

OS: Windows 11
Browser Chrome
Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.8]
Indigo version
[Version 1.25.0-rc.4]


Run tests with custom DLL locations

Hi there,
We are trying to get csharp_nunit_test working with a particular dotnet library in our product that has some interesting requirements. Let's call it business.dll. At runtime, business.dll looks for a folder named 'plugins' (relative to directory containing business.dll) and loads all DLLs inside that directory.
The source layout is:
src\dotnet\business\BUILD.bazel (business.dll)
src\dotnet\plugin1\BUILD.bazel (plugin1.dll)
src\dotnet\plugin2\BUILD.bazel (plugin2.dll)
src\dotnet\tests\BUILD.bazel(test)

The test is:
csharp_nunit_test(
    srcs = glob(["*.cs"]),
    deps = [
         "//src/dotnet/business",
         "//src/dotnet/plugin1",
         "//src/dotnet/plugin2",
    ],
)

The issue is, at runtime, the plugin DLLs are located in a mirror of their src tree locations instead of in a plugins subdirectory at the same parent directory of business.dll
I have tried using aspect copy_file and copy_to_directory to move the DLLs around and then make the test depend on the copied targets, but this does not seem to work
What is the correct way to get this working? I can't edit the code inside business.dll - should not put bazel logic inside our product.
Thanks!

Hmm, this is a side effect of the rules doing an optimization where we don't copy the DLLs to the root of every target. This is a fairly significant optimization so I'm not ready drop it but I think we could probably add a flag to the _library/_binary/_test targets where we would use the same logic as in the publish_binary rule. This would allow end users to have the same behaviour in their tests as is in MSBuild. I'm afraid I don't have the time to do this at the moment but I would be open to an contribution.
The main work in this would be to extract the copying logic from publish_binary and reuse it in the other rules behind an attribute.
Possible workarounds that I can imagine would work:

Create a copy_to_directory target in the same folder as the business.dll is located and then depend on the copy targets in data
Wrap the test in an script that copies the plugin dlls to the location of the business.dll


encoding too smart to use wrong charset

i have a file with utf8 encoding, and have content:
<html>
<meta http-equiv="Content-Type" content="text/html; charset=gb2312">
...
balabala
...

i use it:
fun file ->
                task {
                    let! text = File.ReadAllTextAsync(file) // this time text is correct.

                    let context = BrowsingContext.New(Configuration.Default)

                    // i guess open method go wrong
                    let! document = context.OpenAsync(fun req -> req.Content(text) |> ignore)

                    let html = document.Body.OuterHtml
                    do! File.WriteAllTextAsync("targetFileName",html, Encoding.UTF8) // assign encoding useless.
                }

may i ignore the charset of html file content, force use the file encoding?

Yes that is possible.
In the default configuration the EncodingMetaHandler (see https://github.com/AngleSharp/AngleSharp/blob/master/src/AngleSharp/Browser/EncodingMetaHandler.cs#L12) is used.
I guess if you remove this from the configuration you should be fine.
var config = Configuration.Default.Without<EncodingMetaHandler>();
// as usual

Hope that helps!

Laborious you!  another question is the config variable put global, and it can singleton or instances?
var config = Configuration.Default.Without<EncodingMetaHandler>();

/// for many context using same config
...

Yes you can do that - every context creates a snapshot ("instance") of the supplied configuration.


Should new devices be given 9-octet IDs by default?

Thanks for your efforts on this project - really nice to be able to integrate with Alexa without fiddling with adding skills.
It took me a while to get this going with a simple test http device - eventually it seems the device ID has to:

Have no hyphen in (see https://github.com/bwssytems/ha-bridge/issues/1272#issuecomment-748689997)
Have 9 octets (see https://github.com/bwssytems/ha-bridge/issues/1270#issuecomment-812894624)

Mine was of the form nn:nn:nn:nn:nn:nn:nn-nn. Initially I just tried changing the hyphen to a colon, but still no devices discovered , despite ./api/devices looking fine, and seeing all the expected UPnP trace logs.
I'm happy to update the wiki /trouble shooting (at the very least) to mention this, so people don't get too frustrated.
I'd also be interested in fixing the code to just generate the right form to start with - but only if you agree that's as expected?

Digging in I see @crush157's commit adding this as an option https://github.com/bwssytems/ha-bridge/pull/1358/commits/7f72b0311a3d21780fa27e168da6824861f0b706
However, I don't see any discussion or background on the PR.
Should this now be set to true by default?

Yes, I'd check that box by default.


net/url: parseQuery() better support for array parse.

What version of Go are you using (go version)?

$ 1.15.3

Does this issue reproduce with the latest release?
yes
What did you do?
import (
	"fmt"
	"net/url"
)

func main(){
	query := "params=fo,fu,n%2Cico"
	values, err := url.ParseQuery(query)
	if err != nil{
		panic(err)
	}
	for _, vs := range values{
		for _, v := range vs{
			fmt.Println(v)
		}
	}
}

What did you expect to see?
fo
fu
n,ico

What did you see instead?
fo,fu,n,ico

When an Array parameter is passed by URL or application/ x-www-Form-urlencoded mode, many clients will define the request content in a comma-separated way, so can this expectation be met?

That does not appear to be standard behaviour https://url.spec.whatwg.org/#urlencoded-parsing
And in this case, how would valid values containing commas be preserved?

I also think this is more of a business scenario, not suitable for general use

That does not appear to be standard behaviour https://url.spec.whatwg.org/#urlencoded-parsing
And in this case, how would valid values containing commas be preserved?

If a valid value needs to contain a comma, just escape it to %2C before initiating the request. But then again, it's not standard.

I also think this is more of a business scenario, not suitable for general use

That does not appear to be standard behaviour https://url.spec.whatwg.org/#urlencoded-parsing
And in this case, how would valid values containing commas be preserved?

If a valid value needs to contain a comma, just escape it to %2C before initiating the request. But then again, it's not standard.

However, while this practice is not standard, if it becomes standard, it may be possible to request data transfers:
tags=a&tags=b&tags=c

simplified to:
tags=a,b,c

Of course, this is just a personal thought. xD

I also think this is more of a business scenario, not suitable for general use

Well, in order not to break the standards, I should implement this functionality in the application framework layer.


Decompiled source uses same name for different locals

I found a strange case where a mod jar I tried to decompile managed to produce duplicated locals, where as the pure game jar (version b1.7.3) decompiled correctly.
The jar in question contains a lot of obfuscated Minecraft classes so I'm not comfortable with uploading it as an attachment here, and I'm not knowledgeable enough to check out java bytecode for possible problems. I have yet to try debugging RetroMCP and seeing what Fernflower (or whatever does the remapping/deobfuscation) does wrong here.
It would be appreciated if someone could chime in here and maybe tell if this is some Fernflower issue that has been fixed upstream, and if not, I could either provide the jar or debug RetroMCP to try nail down the bug.

Enable strip generics and see if the issues persists

I am pleased to inform that it enabling strip generics seems to have "fixed" it. The weird thing is that the vanilla jar seems to generate varX locals, while the modded jar produced fX, dX etc., but strip generics made it generate varX.
I will leave this issue open since this seems quite annoying.

The options strips all of local variable tables too, which manes the names are gone too

Closing this issue for inactivity and because there is not much that can be done here.
Generating an LVT is a PITA (and like black magic, nobody knows how to do it). If we generated a custom LVT that was overlaid onto the empty LVTs, that would work well for LVTs that are present to not conflict. We are not intending to work on this functionality yet (or possibly never).


Object property type not being enforced

type person = {
    name: string,
    age: int
};

let person = {
    "John"
};

person of type string is being allowed despite being typed as an object, why is that ?

@hcarty beat me to it, but one bonus thing to note is that you often won't need to use these sort of annotations once you start actually using the variable. You can see that the compiler will infer the type of person and throw an error if you try to access one of the record's fields:
let foo = person.name;  >> Line 5, 10: This expression has type string but an expression was expected of type person

So you know the typechecker's got your back even when you're not annotating your variables 😄


Extraction bug with use_extracted_interfaces flag

Suppose we have cache file for A.fst and all its dependencies. Then, running the command:
fstar.exe --cache_checked_modules --use_extracted_interfaces true A.fst --cache_dir ./cache --codegen OCaml --extract_module A

does not extract the module.
Whereas if we change the module A (thus invalidating the cache), then the command above creates the checked file and extracts it.
The bug is there in FStar.Universal.fs (around line 315) when the module is found in cache, we return its interface. Instead if codegen is set, and the module is in the list of extracted modules, it should return the module itself.
Will fix this with #1444.
cc @nikswamy.

We removed use_extracted_interfaces long back,closing.


Meeting 09/29 - Agenda

Pre:

[x] @arokem - could you generate a new recurring meeting zoom link so next time we are not cut off after 40 minutes?
[ ] @josephmje will put together a tutorial proposal for ISBI 2021 (deadline: 09/25).

Agenda:

Proposal for BrainHack Donostia: @oesteban will report back after meeting with @CesarCaballeroGaudes and @eurunuela:

Interest on dMRIPrep
Will there be timezones?

BIDS/IntendedFor/FieldMap correction strategies: perhaps we need a wide extension of BIDS to support sophisticated DWI protocols? - Follow up on #43 and check bids-standard/bids-2-devel#39 before for context.

You should have received a calendar invite with a new zoom link (this one has a washington.zoom.us URL).


Use ts-patch to transform module mappings

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


API doc generation will not remove old module files

https://github.com/digital-asset/contingent-claims/blob/992f700d82f28da1ca1ebb259811417f08b0ad38/scripts/publish-api-doc.sh#L16-L24
rm followed by git add doesn't remove old files (e.g. if I rename a module, the old generated HTML will still be around).
This is low prio.

Now that the Contingent Claims doc is integrated with the Daml Finance documentation (which is in turn integrated with the wider Daml documentation) do you think we can mark this as "Completed"?


Add back minimum window size in SDL

The game window can be resized to any ridiculous size, which wasn't possible before and probably shouldn't be allowed.

Gonna track this in https://github.com/ppy/osu-framework/issues/3501.


hidden$="{{hide(activepage, item.id, 'true')}}"

Why does polymer not execute hide when I do this or give me a error message ?
hidden$="{{hide(activepage, item.id, true)}}"
I need to do this before something happens
hidden$="{{hide(activepage, item.id, 'true')}}"

with

hidden$="{{hide(activepage, item.id, true)}}"

you are telling polymer to execute a call to the hide function with 3 properties/variables: activepage, item.id and true <- as a property/variable not the boolean value true
If you have to provide constants from the markup to a function, you need to provide it as a literal
(see [docs] (https://www.polymer-project.org/1.0/docs/devguide/data-binding.html#literals))
P.S. please use the SlackChannel or SO to ask questions instead of opening an issue if not reporting an issue or feature request

ok fair enough but stil think the current behaviour of crashing silently could be improved to at least a console error message

I agree on the need of more verbose errors... I think there is already an issue about that (but I'm from mobile and it's difficult to search)


Don't try to deploy vsix during OSS build.  Specify prereq in vsixman…

When building  setups with latest vsroslyn vsix installed a build error occurs.vssdk builds require this.
This change disables deployment of oss vsix during build.
Additionally it adds a prerequesites section to the vsixmanifest.  The latest vssdk requires this.

What is the build error?
The changes look fine to me, though it would be nice to have build just deploy a vsix that overrides the installed one in a specific hive for testing/debugging.

The deploy error is that the version being built is already installed, and then fails.

The missing prereq's error looks like this:
   "c:\kevinransom\visualfsharp\build-everything.proj" (default target) (1) ->
   "c:\kevinransom\visualfsharp\vsintegration\fsharp-vsintegration-vsix-build.proj" (Build target) (10) ->
   "c:\kevinransom\visualfsharp\vsintegration\Vsix\VisualFSharpFull\VisualFSharpFull.csproj" (Build target) (17) ->
   (CreateVsixContainer target) ->
     C:\Program Files (x86)\Microsoft Visual Studio\VS15Preview\MSBuild\Microsoft\VisualStudio\v15.0\VSSDK\Microsoft.VsSDK.targets(571,5): error VSSDK1026: There was a problem creating the
   zip package "..\..\..\src\..\release\net40\bin\VisualFSharpFull.vsix". VSSDK1078: The VSIX manifest must contain element 'Prerequisites'. [c:\kevinransom\visualfsharp\vsintegration\Vsix\
   VisualFSharpFull\VisualFSharpFull.csproj]

   "c:\kevinransom\visualfsharp\build-everything.proj" (default target) (1) ->
   "c:\kevinransom\visualfsharp\vsintegration\fsharp-vsintegration-vsix-build.proj" (Build target) (10) ->
   "c:\kevinransom\visualfsharp\vsintegration\Vsix\VisualFSharpDesktop\VisualFSharpDesktop.csproj" (Build target) (41) ->
     C:\Program Files (x86)\Microsoft Visual Studio\VS15Preview\MSBuild\Microsoft\VisualStudio\v15.0\VSSDK\Microsoft.VsSDK.targets(571,5): error VSSDK1026: There was a problem creating the
   zip package "..\..\..\src\..\release\net40\bin\VisualFSharpDesktop.vsix". VSSDK1078: The VSIX manifest must contain element 'Prerequisites'. [c:\kevinransom\visualfsharp\vsintegration\Vs
   ix\VisualFSharpDesktop\VisualFSharpDesktop.csproj]

   "c:\kevinransom\visualfsharp\build-everything.proj" (default target) (1) ->
   "c:\kevinransom\visualfsharp\vsintegration\fsharp-vsintegration-vsix-build.proj" (Build target) (10) ->
   "c:\kevinransom\visualfsharp\vsintegration\Vsix\VisualFSharpWeb\VisualFSharpWeb.csproj" (Build target) (42) ->
     C:\Program Files (x86)\Microsoft Visual Studio\VS15Preview\MSBuild\Microsoft\VisualStudio\v15.0\VSSDK\Microsoft.VsSDK.targets(571,5): error VSSDK1026: There was a problem creating the
   zip package "..\..\..\src\..\release\net40\bin\VisualFSharpWeb.vsix". VSSDK1078: The VSIX manifest must contain element 'Prerequisites'. [c:\kevinransom\visualfsharp\vsintegration\Vsix\V
   isualFSharpWeb\VisualFSharpWeb.csproj]

   "c:\kevinransom\visualfsharp\build-everything.proj" (default target) (1) ->
   "c:\kevinransom\visualfsharp\vsintegration\fsharp-vsintegration-vsix-build.proj" (Build target) (10) ->
   "c:\kevinransom\visualfsharp\vsintegration\Vsix\VisualFSharpOpenSource\VisualFSharpOpenSource.csproj" (Build target) (43) ->
     C:\Program Files (x86)\Microsoft Visual Studio\VS15Preview\MSBuild\Microsoft\VisualStudio\v15.0\VSSDK\Microsoft.VsSDK.targets(571,5): error VSSDK1026: There was a problem creating the
   zip package "..\..\..\src\..\release\net40\bin\VisualFSharpOpenSource.vsix". VSSDK1078: The VSIX manifest must contain element 'Prerequisites'. [c:\kevinransom\visualfsharp\vsintegration
   \Vsix\VisualFSharpOpenSource\VisualFSharpOpenSource.csproj]

In Roslyn we solve that problem by having the normal build with no parameters generate an abnormally high version number (<IP_ADDRESS>), and our official build process that produces builds that will be installed generate a real version.  That way the tools don't complain because you're installing a higher version when you build, but it allows you to just build and F5 the vsix project to test out changes.


Upgrade Chokidar to 1.7

Chokidar version needs a bump.

@napcs I verified mocha tests still pass and did a bit of adhoc testing and it seemed to be alright.


⚠ Fortnite has degraded performance

In 2e6e1c5, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1555 ms

Resolved: Fortnite performance has improved in a0526be.


Unable to extract initial player response/yt initial data

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I'm running yt-dlp version 2023.07.06 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
Sweden
Provide a description that is worded well enough to be understood
This seems to be different than #7900 as download and extraction succeeds. The warnings started to occur yesterday (18th August)
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp -Uvx --audio-format="mp3" https://www.youtube.com/watch?v=_zovGiekEEU[debug] Command-line config: ['-Uvx', '--audio-format=mp3', 'https://www.youtube.com/watch?v=_zovGiekEEU']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[b532a3481]
[debug] Lazy loading extractors is disabled
[debug] Python 3.11.2 (CPython x86_64 64bit) - Linux-6.4.11-Venom-x86_64-with-glibc2.36 (OpenSSL 1.1.1t  7 Feb 2023, glibc 2.36)
[debug] exe versions: ffmpeg 6.0 (fdk,setts), ffprobe 6.0
[debug] Optional libraries: brotli-1.0.9, sqlite3-2.6.0
[debug] Proxy map: {}
[debug] Loaded 1855 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>yt-dlp is up to date<EMAIL_ADDRESS>[youtube] Extracting URL: https://www.youtube.com/watch?v=_zovGiekEEU
[youtube] _zovGiekEEU: Downloading webpage
WARNING: [youtube] unable to extract initial player response; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
[youtube] _zovGiekEEU: Downloading ios player API JSON
[youtube] _zovGiekEEU: Downloading android player API JSON
[youtube] _zovGiekEEU: Downloading iframe API JS
[youtube] _zovGiekEEU: Downloading player f980f2a9
[youtube] _zovGiekEEU: Downloading web player API JSON
[debug] Loading youtube-nsig.f980f2a9 from cache
[debug] [youtube] Decrypted nsig kNibZeJ1CM3vAO3vQ9 => hn33zG0LevC-hA
[youtube] _zovGiekEEU: Downloading m3u8 information
WARNING: [youtube] unable to extract yt initial data; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
WARNING: [youtube] Incomplete data received in embedded initial data; re-fetching using API.
[youtube] _zovGiekEEU: Downloading initial data API JSON
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, size, br, asr, vext, aext, hasaud, id
[info] _zovGiekEEU: Downloading 1 format(s): 251
[debug] Invoking http downloader on "https://rr1---sn-cgxqc5oqufv-5gol.googlevideo.com/videoplayback?expire=1692470255&ei=j7fgZKSGH8e1v_IPs8GKwAY&ip=<IP_ADDRESS>&id=o-AAucb3pir61mnNCgzJEZHQ69qhpPN3wxX-E835Uh6yRG&itag=251&source=youtube&requiressl=yes&mh=AW&mm=31%2C26&mn=sn-cgxqc5oqufv-5gol%2Csn-i5h7lnls&ms=au%2Conr&mv=m&mvi=1&pcm2cms=yes&pl=22&pcm2=no&initcwndbps=1868750&spc=UWF9f6l6lSAFbebsByYjRZOO2QCxVTU&vprv=1&svpuc=1&mime=audio%2Fwebm&gir=yes&clen=2364117&dur=178.081&lmt=1642502339218879&mt=1692448147&fvip=5&keepalive=yes&fexp=24007246&c=ANDROID&txp=6211224&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cpcm2%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRAIfSHZJBqQkSTqm66IHHDCi6Hsrd-Xh3IoW9yVn1mdpCgIhAKTjdIx7BX4WWml0MOSWPpreUulmPx8HcZZe187ltkf9&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpcm2cms%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRQIhAKwU3YQP3YeZ9m4ZxxKNUTc3jfM6utw7mBWJWs6tBiGWAiAkf7j71pMAUWsY7XeUdcDNbdgMSaHa-ohWo83W27iBSw%3D%3D"
[download] Destination: Meme Bianchi - NUVOLE - Orchestra Ceragioli [_zovGiekEEU].webm
[download] 100% of    2.25MiB in 00:00:00 at 6.18MiB/s
[debug] ffmpeg command line: ffprobe -show_streams 'file:Meme Bianchi - NUVOLE - Orchestra Ceragioli [_zovGiekEEU].webm'
[ExtractAudio] Destination: Meme Bianchi - NUVOLE - Orchestra Ceragioli [_zovGiekEEU].mp3
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i 'file:Meme Bianchi - NUVOLE - Orchestra Ceragioli [_zovGiekEEU].webm' -vn -acodec libmp3lame -q:a 5.0 -movflags +faststart 'file:Meme Bianchi - NUVOLE - Orchestra Ceragioli [_zovGiekEEU].mp3'
Deleting original file Meme Bianchi - NUVOLE - Orchestra Ceragioli [_zovGiekEEU].webm (pass -k to keep)

Duplicate of #7594


Support multiple group/kind contexts in shared webhook.

In order to have a single webhook support multiple domain contexts, this reworks the Handlers argument to embed the schema.GroupVersion by wrapping the existing keys with it as a schema.GroupVersionKind.
This is mostly straightforward, but one oddity is that I discovered that AdmissionRequest gets this same tuple as the less capable metav1.GroupVersionKind, so there's a silly conversion we have to do.
I tried this manually vendored in serving with KPA and things worked great.

/lgtm


writing outputs

Thanks very much for this great lib!
More of a question than an issue - when processing something such as....
point_cloud.region_growing(norms, n_neighbours=30, min_size=100,
                           max_size=1000000, smooth_threshold=rad,
                           curvature_threshold=1, residual_threshold=0.1)

Is their a mechanism via pclpy to write the results to a new point cloud?

same question here !

I try to do this recently,
I fallow this article but get some problem,
https://stackoverflow.com/questions/59396391/how-to-get-a-specific-cluster-after-region-growing-using-pcl-library
the method is feeding the clusters into ExtractIndices then output the specific point.
my code is below:

pc = pclpy.read(inpcloud, "PointXYZI")
rg = pcl.segmentation.RegionGrowing.PointXYZI_Normal()
rg.setInputCloud(pc)
normals_estimation = pcl.features.NormalEstimationOMP.PointXYZI_Normal()
normals_estimation.setInputCloud(pc)
normals = pcl.PointCloud.Normal()
normals_estimation.setRadiusSearch(0.35)
normals_estimation.compute(normals)
rg.setInputNormals(normals)
rg.setMaxClusterSize(10)
rg.setMinClusterSize(5)
rg.setNumberOfNeighbours(15)
rg.setSmoothnessThreshold(5 / 180 * math.pi)
rg.setCurvatureThreshold(5)
rg.setResidualThreshold(1)
clusters = pcl.vectors.PointIndices()
rg.extract(clusters)
ext = pcl.filters.ExtractIndices.PointXYZI()
ext.setInputCloud(pc)
ext.setIndices(clusters[1])
ext.setNegative(False)
output_cloud = pcl.PointCloud.PointXYZI()
ext.filter(output_cloud)
but the ext.setIndices cloudn't accept the clusters that RegionGrowing's result.
in the article I share, they said that we need to transform clusters using this
extract.setIndices (pcl::PointIndicesConstPtr(clusters[cluster_idx]))
but in pclpy, I couldn't find a way to using "PointIndicesConstPtr" function.
this is my progress so far.


cluster service does not properly support absolute context paths

Docker allows context paths which do not have to be in a sub-directory relative to the dockefile, they can be parent directories or the Dockerfile and context can be separated. A docker context must be absolute if it is not a sub-directory, e.g. ../ is not a valid context.
Currently SST assumes the context will be in a relative position to the $cli.paths.root, this may not be the same root of the project in all cases, e.g. a monorepo where the modules are hoisted to a parent package.json.
Currently it is not possible to deploy a service having a context with an absolute path which is a parent directory of the sst.config.ts.

i ran into this myself and it should be fixed in 0.0.380


Style submission form to match designs

Need to adjust the Chakra theming to get us closer to design spec.

Adjusting theming is a a bit tricky, since you can affect other stuff that's been implemented based on the defaults.
I'm resisting any temptation to change the theme until I understand it better. For now, I've just been using the style props to customize components directly to try to match the design.
Folding stuff into the theme could be a refactoring step later on?


add optimization for blip text model generation

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

@regisss

@libinta @mandy-li please have review

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

two tasks could benefit from the optimization.
image-to-text. models are like "Salesforce/blip-image-captioning-large" and "Salesforce/blip-image-captioning-base"
visual-question-answering. models are like "Salesforce/blip-vqa-base" and "Salesforce/blip-vqa-capfilt-large". although VQA has another issue of torch.full type. filed in https://habana.atlassian.net/servicedesk/customer/portal/1/HS-1395.
the acceleration ratio in Gaudi2：
image to text: Salesforce/blip-image-captioning-large. generation speedup:238ms vs 40ms(after)
Salesforce/blip-image-captioning-base: generation speedup: 227ms vs 25ms(after)
visual-question-answering.
Salesforce/blip-vqa-base: generation speedup: 86ms vs 9ms(after)
Salesforce/blip-vqa-capfilt-large:generation speedup: 91ms vs 10ms(after)

test codes are like
from transformers import pipeline
import habana_frameworks.torch
import torch
import requests
import PIL.Image
from habana_frameworks.torch.hpu import wrap_in_hpu_graph
import time
from optimum.habana.transformers.modeling_utils import adapt_transformers_to_gaudi
adapt_transformers_to_gaudi()
image_url = "https://ankur3107.github.io/assets/images/image-captioning-example.png"
image = PIL.Image.open(requests.get(image_url, stream=True, timeout=3000).raw)
generator = pipeline(
"image-to-text",
model="Salesforce/blip-image-captioning-large",
torch_dtype=torch.bfloat16,
device="hpu",
)
generator.model.text_decoder = wrap_in_hpu_graph(generator.model.text_decoder)
generator.model.vision_model = wrap_in_hpu_graph(generator.model.vision_model)
for i in range(5):
generator(image)
start = time.time()
result = generator(image)
end = time.time()
print(f"{result}, time = {(end-start) * 1000}")

upload a PR to fix the issue in  https://habana.atlassian.net/servicedesk/customer/portal/1/HS-1395.

I check with latest transformers 4.37.2. this PR also work. could somebody review the PR?

from transformers import pipeline
import habana_frameworks.torch
import torch
import requests
import PIL.Image
from habana_frameworks.torch.hpu import wrap_in_hpu_graph
import time
from optimum.habana.transformers.modeling_utils import adapt_transformers_to_gaudi
adapt_transformers_to_gaudi()
image = PIL.Image.open("./vqa_cats.jpg").convert('RGB')
generator = pipeline(
"visual-question-answering",
model="Salesforce/blip-vqa-capfilt-large",
torch_dtype=torch.bfloat16,
device="hpu",
)
for i in range(5):
generator(image, "how many dogs are in the picture?", topk=1, max_new_tokens=20)
start = time.time()
result = generator(image, "how many dogs are in the picture?", topk=1, max_new_tokens=20)
end = time.time()
print(f"{result}, time = {(end-start) * 1000}")

I left a couple of minor comments. Also, could you add this model to the table here and there please?

after this PR is merged, I need to upload example for VQA and image-to-text case. currently there's no such example in optimum-habana, then update doc to add the model and example


How to build the aagw source code without buildroot?

This is not an issue, sort of like a request to the repo owner.
I've tried the buildroot image on a Pi0W and it work just fine. However, I'd like to add in some existing scripts from my side that works with GPIO. I prefer to run the AA wireless dongle code on an official Raspberry Pi OS instead of buildroot image. Naturally I tried to read your code and attempt to build the aagw source independently from buildroot but my meager C++/Make knowledge failed me.
Do you mind to provide a build script that can run on official Raspberry Pi OS? Thank you in advance.

If you prefer to run it on the RaspberryPI OS then I can tell you that it's not so easy, eg: you need to build a customized kernel modules for OTG/gadget and do configuration of those. I did similar thing (using GPIO and serial) with my LoRa project, but despite using aa-proxy-rs instead of aawgd I am still using the whole buildroot from this project as it is much easier (all hard work done by Nisarg).
Anyway: you can just build it as any other regular application. Full image installation steps are eg here:
https://github.com/nisargjhaveri/WirelessAndroidAutoDongle/blob/main/BUILDING.md#build-with-manual-setup
and if you want a aawgd alone, just go to:
https://github.com/nisargjhaveri/WirelessAndroidAutoDongle/tree/main/aa_wireless_dongle/package/aawg/src
and BR build script is here: https://github.com/nisargjhaveri/WirelessAndroidAutoDongle/blob/main/aa_wireless_dongle/package/aawg/aawg.mk

@manio thanks for the pointer. I'll have a look. Wonder if anyone attempt to build this as Docker image and run as container? It will be much more easier to run on official Raspberry Pi OS if it exists.

It will be much more easier to run on official Raspberry Pi OS if it exists.

First of all you have to communicate somehow from the container to the "outside" world... it's not possible to run a custom kernel module in docker - you need to have it in your own Pi OS. Look how it is working first.


Setup correct target/module/moduleResolution settings for TSConfig

This reverts some of the changes from https://github.com/data-eden/data-eden/pull/35

target should be the highest possible value (consumers can transpile with things like @babel/preset-env for specific browser targets as needed)
module should be es2020 which includes support for import() and import.meta
moduleResolution should be node16 (basically this is what nodenext turned into when they finally shipped it)

This change doesn't provide a usable ESM module.

This change doesn't provide a usable ESM module.

Hmm, seems to work for me locally when linked into a consumer package... 🤔

Have you tried linking this to a typescript consumer package?

Have you tried linking this to a typescript consumer package?

Yep! The same one that you shared a screenshot from in #35.

Created https://github.com/data-eden/data-eden/issues/42 to track fixing those issues.


can't find the plateautem

mod version 0.3.5
jotum 2.12.4
valheim latest (but not public test)
i have install it on both side client and server but i can't find the totem (no new recipe)
thx in advance

Hi, thanks for the feedback.
You have to have picked up stone and wood to unlock it.  Then it should appear in the Misc tab in the build menu.  It looks like the ward but with blue trim.
If it still doesn't show up, do you have other mods that may conflict?

i just try with only plateautem and jotum with the same result
but i see an error in log
[Info   :Plateautem.Plateautem] Adding fuel item Wood with value 1 to Plateautem.
[Warning:Jotunn.EventExtensions] Exception thrown at event InvokeOnVanillaObjectsAvailable in Plugin.OnVanillaPrefabsAvailable:
System.FormatException: Input string was not in a correct format.
at System.Number.ParseSingle (System.String value, System.Globalization.NumberStyles options, System.Globalization.NumberFormatInfo numfmt) [0x00083] in <695d1cc93cca45069c528c15c9fdd749>:0
at System.Single.Parse (System.String s, System.Globalization.NumberStyles style, System.Globalization.NumberFormatInfo info) [0x00000] in <695d1cc93cca45069c528c15c9fdd749>:0
at System.Single.Parse (System.String s) [0x0000b] in <695d1cc93cca45069c528c15c9fdd749>:0
at Plateautem.Plateautem.LoadFuelItems () [0x000a0] in :0
at Plateautem.Plugin.OnVanillaPrefabsAvailable () [0x00000] in :0
at Jotunn.EventExtensions.SafeInvoke (System.Action events) [0x00018] in D:\Projects\Jotunn\JotunnLib\Extensions\EventExtensions.cs:26

I've just uploaded version 0.3.6 with a probable fix.  It looks like I failed to take into account other cultures not using a dot for a decimal point.  Thanks for the help in tracking that down.

that solve the problem thx for the quick fix


v-bind and v-lang

I'm unable to bind  "v-lang" to an element in a v-for loop.
the value for v-lang should be equal to "item.name".
Is there a way to accomplish this?
	<button (need v-lang bind here)  v-if="!item.disabled" v-for="item in items"  v-bind:id="item.image" v-bind:class="{ active: item.active }">
		{{ item.name }}
	</button>

We have the translate method for it. Call {{ translate(item.name }}` for example.
Please, in next problem use right repository: https://github.com/leonardovilarinho/vue-acl


Process out of memory error

I wrote a small test querying a bunch of tables in a remote machine running MS SQL Server 2008 R2 and logged the time each query took.
The query was essentially same for all tables.
SELECT * FROM [table]

Some of the queries took exceptionally long time to complete, despite the fact that I am using the same connection for all the queries.
Here is the code and the response
Code
var sql = require('mssql');

// 200 minutes of timeout
var config = { requestTimeout: 60 * 1000 * 200 }; // assuming host, port etc are there

var tables = [
"tblTransactionUniqueId",
"tbltempOrderHistory",
"tbltempcoupon_mob",
"tbltaxMaster",
"tblSubCategory",
"tblstoreTaxMaster",
"tblStoreMenu",
"tblStoreMaster",
"tblRegister",
"tblProductType",
"tblProductMaster",
"tblOrderStatus",
"tblorders",
"tblorderhistory",
"tblOnlinePaymentDetailsnoTxn",
"tblOnlinePaymentDetails",
"tblmenumaster",
"tblDeliveryArea",
"tblCouponTypes",
"tblcouponMaster",
"tblcouponItems",
"tblcouponFreeItems",
"tblConfigureCoupons",
"tblCityMaster",
"tblCategory",
"tblBaseProductMaster",
"tblbasecity",
"tblAmtSetings",
"tblAddress"];

var connection = new sql.Connection(config, function(err) {
  // handle error

  var request = connection.request();

  tables.forEach(function(table) {
    console.time(table);
    request.query('select * from ' + table, function(err, recordset) {
      // handle error
      console.timeEnd(table);
    });
  });
});

requestTimeout is 200 minutes, so that I can benchmark how much time the whole operation takes in total.
STDOUT
tbltaxMaster: 2796ms
tblSubCategory: 2809ms
tblProductType: 2899ms
tblOrderStatus: 3343ms
tbltempOrderHistory: 4124ms
tblRegister: 4234ms
tblOnlinePaymentDetailsnoTxn: 4459ms
tblstoreTaxMaster: 4726ms
tblStoreMaster: 4745ms
tblmenumaster: 4763ms
tblCouponTypes: 5905ms
tblcouponMaster: 7967ms
tblProductMaster: 11869ms
tblConfigureCoupons: 12164ms
tblcouponFreeItems: 12217ms
tblCityMaster: 12473ms
tblCategory: 12522ms
tblBaseProductMaster: 12751ms
tblbasecity: 12987ms
tblAmtSetings: 13050ms
tblDeliveryArea: 13260ms
tblStoreMenu: 16637ms
tblTransactionUniqueId: 20570ms
tblcouponItems: 80056ms
tblAddress: 230940ms
tblOnlinePaymentDetails: 464066ms
FATAL ERROR: CALL_AND_RETRY_2 Allocation failed - process out of memory

I also checked the how much memory the process takes while it hung and I was surprised to see around 1.7 GB getting used up.
I'm on OSX Yosemite 10.2.2 and running node v0.10.35
At the end, the process runs out of memory. Do I need to free any resource that I am ending up using? Am I doing something wrong here?
It is possible that my application would make a bunch of queries simultaneously.

You should absolutely use streaming for this kind of queries. I can't see how much data is stored in your tables, but keep in mind that once you don't use streaming, every received row is stored in memory until the query is complete. Your code does execute all the queries at the same time so it must be a reason why your process is oom.

Shouldn't it free the memory for the queries that have returned. Once the recordset is logged, as I understand it that object should be eligible for garbage collection.

Yes it should, but at the moment your process crashed there was 3 active queries on those tables:
tbltempcoupon_mob
tblorders
tblorderhistory
As I said, I can't see how much data resides in those tables. Maybe its enough to oom the process.

Makes sense. Good amount of data is stuffed in those tables. Will try the streaming interface.


Build a transaction trie from a simple binary Merkle Tree

https://github.com/Sovereign-Labs/nmt-rs/tree/master/src/simple_merkle

@preston-evans98 please help groom this issue and populate details about desired outcome

Background
Currently, we have good default implementation of a sparse merkle trie (the jmt) which is generic over hash function so that it can run efficiently in any zkvm. But, many implementers will probably want a standard (non-sparse) merkle trie as well.
Desired Outcome
Provide a non-sparse binary merkle trie which is generic over hash function. https://github.com/Sovereign-Labs/nmt-rs/tree/master/src/simple_merkle is a good candidate, but it should be extracted into its own package and tested/audited if we want to use it.

Marking this as low priority since we don't currently have any customers asking for it and we managed to build the demo-rollup without it.


Rewrite the physics of supercapacitor

There is a TODO  with a question for you in electrochemical_physics.templates.h.

Done.

looks like version 8.4.0 has been tagged on deal.II repo!

Yes, it was done today. The announcement of the new version will probably be this week end.

I fixed the bug.

Current coverage is 94.34%

Merging #53 into master will decrease coverage by -0.39% as of 90d2f45

@@            master     #53   diff @@
======================================
  Files           38      42     +4
  Stmts         2810    2867    +57
  Branches         0       0
  Methods        182     191     +9
======================================
+ Hit           2662    2705    +43
  Partial          0       0
- Missed         148     162    +14

Review entire Coverage Diff as of 90d2f45

Powered by Codecov. Updated on successful CI builds.

coverage decreased. can't merge it. just kidding...


Ability to search within list of one's own groups in the group dropdown list when granting role to a group with SAML auth provider

Internal Reference: SURE-3461
The drop-down for selecting a group should use a combo-style that allows the user to search the list to refine it down.

This may be more of a bug in the end so once we look at this, we can back port something.


[bug] having to be root user for import function to work correctly

this bug showed the following results
1, if it was your first time importing then it would ask for the password and finish off correctly however it would not be in your accounts list and would not allow you to unlock the key
2. if you attempted to re-import then it would tell you the key already present but still would not show up in accounts to unlock.
3. only when you switched to the root user would it allow you to rerun the import function and would step through all the steps correctly, but then would it only show up in the accounts list.  also i confirmed that if you logged back in under normal user the key would stay active

Seems to be similar behavior exhibited here: https://discord.com/channels/484437221055922177/746316198806814760/783763691560501258

Closing this issue as it is stale for a long time.


[Bug]: Enumerations with wikilinks are not affected by font size

Contact Details
<EMAIL_ADDRESS>What happened?
Enumerations with wikilinks are not affected by the font size of the settings.
For example,

Appears as

With a larger font size than the one defined in the settings and that actually appears in the other columns
What platform were you using?
Desktop
Version of the plugin
3.5.0
Relevant log output
No response
Are you using the latest version of the plugin in your Obsidian vault?

[X] I have verified that I am on the latest version

Are you check if there is a similar issue?

[X] I have verified that there are not similar issues

I have a similar issue. I've tracked down to the element that changes the font size. It is applied to <p> elements, but not for <li>.
.database-plugin__td.data-input p {
    margin: 0;
    font-size: var(--dbfolder-font-size);
}

For lists, it inherits this rule:
.data-input * {
    margin: initial;
}

I don't know if the best solution would be copying the same rule to <li> elements, or wrapping the content of list items in a <p>.


Make relative shifts more explicit?

(Hey Chris, I absolutely love this library. I have a very minimal library that makes dealing with dates and times easier (times), but I intend to change it to simply "wrap" arrow, and issue deprecation warnings, so people start adopting this library instead directly.)

Anyway... there was one thing about the API that confused me.
The following line will replace a "position" in the datetime:
a = arrow.get(2014, 8, 23, 11, 43, 00)
a.replace(hour=10)  # would change to 10:43:00
a.replace(hours=10)  # would change to 21:43:00

The mere difference of the singular/plural form is quite confusing and not obvious from the docs. Ideally, the .replace() method would not take the plural form (including the weeks). Those could be moved to a move natural .shift() method instead, which would communicate the relative nature of the operation as well. It can be used to shift forward and backward in time.
What do you think?
Vincent

Arrow now has shift(), can this issue be closed?

@crsmithdev First of all, thanks for the great lib!
I'm wondering, is there a scheduled date/time for replace(hours=2) (plural form) to be fully deprecated? I know the source code already says it's deprecated, but I'm wondering if/when is the method itself going to stop accepting parameters in the plural form. And if/when this day comes, any code that still uses it like that will simply stop working (makes more sense to me) or will it work as if I was using the parameters in the singular form (that would be terrible, silent failures)?
I haven't found any info about this around, not sure if I didn't search for it properly. Any light about this would be really appreciated. Thanks!

@lucabezerra We don't have a firm date set out (IMO we'll remove deprecated features with our first 1.0 release), but yes these parameters will be fully deleted from replace, which will mean all code that continues to use them will break.


Request for LoRA Weights: Incontext Lora weights

Flux Simple Try On - In Context Lora
Flux In Context - visual identity Lora in Comfy
Flux Product Design - In Context Lora

these are the LORA models
https://huggingface.co/ali-vilab/In-Context-LoRA/tree/main

@fofr


Change config of SDK automation for Go

Regarding we have GAed track2 mgmt. plane SDK for Go and will not release any track1 packages, it is no use for running track1 SDK automation for Go. This PR will remove the config of track1 SDK automation for Go and merge two version of SDK automation for Go into one for every RP's readme config.

/azp run

@tadelesh, could you help to check why there are so many failures in the SDK generation?

@tadelesh, could you help to check why there are so many failures in the SDK generation?

As we've changed most of the RP's readme config, ci will run SDK automation for all of them. It seems most of the failure may come from batch execution (timeout, rate limit, etc.).

@tadelesh, could you help to check why there are so many failures in the SDK generation?

As we've changed most of the RP's readme config, ci will run SDK automation for all of them. It seems most of the failure may come from batch execution (timeout, rate limit, etc.).

I see. Then please contact @akning-ms  to get this PR merged.


WIP: [maistra-2.6] Rebase building OpenSSL-based proxy image

OSSM-2378: Use Maistra proxy CentOS Stream 8 img (#713)

OSSM-2378: Use Maistra proxy CentOS Stream 8 img

For integration tests. Based on (#609)

Build container images with docker

Use maistra proxy and CentOS Stream 8 as a base image for proxyv2

Test VMs using CentOS Stream 8

Temporarily skip failing security tests

Temporarily skip tests suite telemetry.prometheus.wasm

fix(tests): enables fixed integration tests

Use our proxy (#801)

OSSM-5958: Remove wasm extensions (#937)

Do not rely on WASM extensions

Since https://github.com/maistra/proxy/pull/253

Remove wasm extensions from EnvoyFilters

Disable tests for WASM extensions

Remove commented code

Disable failing tests

Fix TestTrustDomainValidation - change expected TLS error to make it work with OpenSSL

Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes.

We skipped some integration tests in the previous 2.5 proxy image rebase PR.
When we have a 2.6 maistra proxy build, we can re-enable the skipped tests.

/test maistra-istio-lint-2-6

/test maistra-istio-unit-2-6

Use 2.5 proxy binary SHA until having a 2.6 proxy build.
When we have a 2.6 proxy build, need to update the Dockerfile.proxyv2 base image from centos:stream8 to centos:stream9

Use 2.5 proxy binary SHA until having a 2.6 proxy build.
When we have a 2.6 proxy build, need to update the Dockerfile.proxyv2 base image from centos:stream8 to centos:stream9

/test maistra-istio-unit-2-6

/retest


element.summernote is not a function

Hi,
I try to use the angular-summernote, but when I called  it throws element.summernote is not a function. I tried to debug in the lib by using jquery $('.summernote').summernote() and it works. But when use element it does not work. Any solution for this.
FYI version use is 0.8.1 for angular-summernote, 0.8.2 for summernote

Check how your scripts are included, jquery should go before summernote


Prevent Services being re-instantiated with every REST call

The various services are currently being re-created with every single REST call that is received. This should not happen. When they have been first instantiated they should stay created and be re-used.
For example when the multi-jvm-example-rest-palisadeservice is started, every call to the REST service creates a new instance of SimplePalisadeService.
I believe this is a bug in the REST server somewhere.

merged into develop


Can't assign mouse wheel up and down with blt active

What are you trying to assign, a mod keybind, or a payday keybind
Is there any console output
What version of BLT
What Distro/Kernel
ldd libblt_loader.so

Seeing this issue too.


149351115.v2.pressablecdn.com

Blocking 149351115.v2.pressablecdn.com prevents stackoverflow.blog from working properly. Try opening this with it blocked for example. There's no reason for it to be blocked.

Thanks for example! Unblocked
Somewhere ago I noticed some bad scripts from where and didn't see any legal things. Your example made it right, thanks.


Custom_Order or Enumeration column in Metadata tables

I believe that we have to keep id numbers as sequential numbers and add a column to keep custom orders and/or group info.
Currently, all tables in metadata folder populated with predefined id numbers, which seems pretty like as an enumeration.
My suggestion is to add a column with possible names "custom_order" or "enumeration", in this way we don't need to re-create the table and relate the objects with alterable id numbers. This will make us able to reconsider the row orders and change them without changing the relations between features and metadata tables. (Situation like in the issue)

Closing due to inactivity. The order and ID values of metadata entries are stable for quite some time now and are not subject to change very often. There might be final changes when going from beta to release though.


bump version jquery

Resolves #456

Coverage remained the same at 98.668% when pulling 1ffb65006eeac453c7fc02fdccb9a1cb8c5837c8 on mum-never-proud:bump-version-jquery into f08cbc2e9047e58ba620d67493f2edb45e9d3272 on san650:master.

Thanks!


CLI outPath support

Checks if outPath (--output or -o) parameter is passed, and if so, uses it for the output instead of stdout.

PR-Codex overview
This PR focuses on improving the logging functionality of the eo-phi-normalizer application.
Detailed summary

Added import for System.IO module.
Created a new handle variable for file output.
Modified putStrLn calls to logStrLn for logging to file.
Added hClose to close the file handle after logging is done.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

In retrospect, I'm not sure why I didn't use whatever the Haskell equivalent of freopen is.

Please, update documentation in the README.


Prepping v7.0.0 release

CHANGELOG updates for upcoming version 7.0.0

oof, i didn't realize the eslint 5 stuff would require a semver-major :-/
could we maybe backport that into a v6 minor?

@ljharb @evcohen I would like to deprecate label-has-for in this release. We'll leave it in the plugin, but add -deprecated to the rule name and indicate that it will disappear in a future release. label-has-for is superseded by label-has-associated-control.

Coverage remained the same at 99.807% when pulling 1772c595da23cdea0aa8a4fde7d7c75ca9497b0f on prepping-version-7 into de25830443105388ad6da004d113b95d09e739f0 on master.

Coverage remained the same at 99.807% when pulling 1772c595da23cdea0aa8a4fde7d7c75ca9497b0f on prepping-version-7 into de25830443105388ad6da004d113b95d09e739f0 on master.

Coverage remained the same at 99.807% when pulling 1772c595da23cdea0aa8a4fde7d7c75ca9497b0f on prepping-version-7 into de25830443105388ad6da004d113b95d09e739f0 on master.

/cc @evcohen friendly ping :+1:


Add docs

While this app is similar to WE, it is not identical, so docs are probably needed.

f9cd2e2


Imported 3D Armature Missing Last Bone In Chain

Godot version
v4.0.alpha10.official [4bbe7f0b9]
System information
Windows 10
Issue description
I've noticed that gltf files imported from Blender are missing all leaf bones in the scene view and in the skin weights, yet the bones are still selectable in the Skeleton3D inspector window.
This is how the animation appears in Blender:

This is how the imported animation appears in the scene:
https://user-images.githubusercontent.com/38251868/211477994-7a739b6a-cf10-4fbb-9225-422dbef1fbf3.mp4
Steps to reproduce
Open the zipped scene, right click on test.gltf and select New Inherited Scene, play the test_anim animation in the AnimationPlayer and view the bones in the Skeleton3D inspector.
Minimal reproduction project
ArmatureImportIssue.zip

I have explained many many times in the past whenever it has been reported that leaf bones do not show up, but it is due to the different way of defining bones in Blender and gltf, and there is no bug in the GUI.
The only problem here is that the skinning is missing, and I can confirm that it previews fine in the gltf viewer, so this is an issue with the godot importer.

Upon closer look, it seems that the vertices are missing, not the Skining missing. Is it FOV problem? Is there any idea? @fire

@TokageItLab I know you've explained it many times, but is it documented? I can't see it anywhere in the Godot docs, so no wonder people keep wondering about their bones...

@Zireael07 For leaf bone should certainly be documented. I will add pipeline documentation for blender later...

FYI, it seems to import correctly when Generate LOD is unchecked.

In https://github.com/godotengine/godot/pull/73734 I attempt to resolve this bug by setting a minimum of 256 triangles and also assigning every attribute into the simplification algorithm.

I was looking into this with mesh lod set to 8 and 8 bone influences. There appears to be corruption. This appears to be a bug in godot engine.


Searchbar/zareenf01

Description

...
...
...

Related issue(s)

Hey can you just add a video or gif for the changes you have made?

Hey can you just add a video or gif for the changes you have made?

I have uploaded two files for search bar

@zareenf01 yeah, just wanna see if the code is working fine or not, hence a gif or video.
Will be happy to merge pr after seeing it.

@zareenf01 yeah, just wanna see if the code is working fine or not, hence a gif or video. Will be happy to merge pr after seeing it.

https://user-images.githubusercontent.com/109251356/193523218-7f5d28f2-f2b6-4715-8496-2a693cba9963.mp4

Hey @zareenf01 are you able to get playlists after searching their name?
can you just search Should be good and show it?


Modal z-index issue.  Potential Solution.

I first experienced the modal content displaying beneath the .modal-backdrop scrim in IE7, but I have since seen weird behavior in Chrome.
The problem, in essence, is that .modal and .modal-backdrop are not always siblings with similar attributes.  In a recent project I had a deeply nested .modal and there were custom z-indexings elsewhere on the page.  Thus, incorrect z-indexing.
I've created a jsFiddle: http://jsfiddle.net/ATeaH/8/ to illustrate the busted and fixed behavior.
Hope this is useful.

Thaks a lot! this was help ful


clean up the organization of the aws secrets

have separate files per domain

completed in v3.2.7


Update train.py

Fix Wrong Description!!!!!

Fix Wrong Description!!!!!

Thank you for noting this. As you suggest, the description is misleading. It actually represents the total number of batches. I have updated the docstring.


Export push directly to OCI registry

Is your feature request related to a problem? Please describe.
I would like to push my application as a set of OCI artifacts so that Fleet can pick it up and run/upgrade the application in many downstream clusters.
Describe the solution you'd like
I would like an additional subcommand that will pack up a built and deployed application and push it.
epinio export <app-name> --container <container-OCI-tag> --chart <chart-OCI-tag>
This would require auth which could be difficult so it should likely pull down locally then push using the client's auth. It would make sense to just be a second step after https://github.com/epinio/epinio/issues/1352
Additional context
What might be a bit tricky is that the two are obviously linked so the requested container tag might need to be rendered into the chart's values as well.

Ref: https://github.com/epinio/epinio/issues/1157

Pretty please?

Not on our radar at the moment. Please re-open if important to an actual usecase

This is an important use-case since it allows for integrations with other CD systems in a clean way.

Please implement. This is currently requested by one of our customers.

@agracey Your initial description mentions container and chart as elements to be exported, with a chosen tag.
What about the values.yaml ? That file links the container to the chart by configuring the chart appropriately.
Although the container information in the file will be for the registry used by the E installation.
I.e. if we want this to be directly usable the exporter will have to rewrite that part of the file.
Can OCI registries handle plain files ?
Can helm pull not just the chart from the OCI registry, but a referenced values.yaml as well ?
Note: It should already be possible to configure an OCI registry as the external registry used by E to save/pull container images from. That part of the system already has the ability for auth (*). In that situation only chart and values.yaml would have to pushed/exported too. And the values.yaml would contain the proper container/image reference by design.
And being reminded of that part it becomes clear a push to any other OCI registry can be done server side.
The client simply has to provide all the necessary credentials for auth.
And it can get these through command flags.
Hm. Or not, maybe ... The server does not do direct registry access. Access is from the staging pod to save the generated image, and then from the app pod to pull. ... ... ... Remembered, regular export uses a skopeo job to pull the image into the local PV to then copy it further ... Should be possible to launch a skopeo job for pushing the image, etc. into the desired registry.

Ad (*):
global:
  # Skip if containerregistry.enabled is true
  registryURL: ""
  registryUsername: "admin"
  registryPassword: "changeme"
  # Used in registry path when pushing -> "external.tld/apps/APPNAME"
  registryNamespace: "apps"

@agracey The initial spec makes no mention of how to specify the desired destination registry ?!
This also connects to the following ...
Having looked deeper into the how E handles an external registry I found that beyond user/pass E also needs/uses
containerregistry:
  # The certificateSecret is used to load the certificate of the registry in the staging job.
  # The certificate has to be in PEM format within in a 'tls.crt' key (it can be an Opaque secret).
  # It also has to be trusted by the kubelet, and it needs to be added in the cluster as well.
  certificateSecret: ""

i.e. certs to be used for the secure connection.
Note the has to be trusted by the kubelet, and it needs to be added in the cluster as well. part.
At this point I suspect that we will need some kind of setup outside of E for any desired destination registry, at least for the certs. If so then having some more external setup, i.e. k secret for the other configuration data, i.e. url, user, pass, ... should be no big problem either. At that point E would only have to search/find these secrets, and offer these to the user for selection (by name).
See also #2488 for something similar done for setting up auth data to access private git repos. Not as complex as here I suspect, due to not needing certs or if needed, not needed to be installed into the cluster.
Still some similarity to what I am thinking about here.

Ok, confirmed yesterday's research into the existing handling of an external registry by E staging and wrote it up more coherently.
E-ext-registry.md
Based on that information an initial draft spec was written.
OCI-export.md
@agracey Please have a look and comment.

@agracey
Looking at the example command from your description, i.e.
epinio export <app-name> --container <container-OCI-tag> --chart <chart-OCI-tag>

I notice that it does not mention values.yaml for the upload, just chart and container.
Point here is that the E application consists of three pieces, namely:

the container image with the runtime
the common app chart, a configurable helm chart, and
a values.yaml which links the two

and for the PR I was working on uploading all three pieces.
However for Fleet to handle this I guess now that you truly want only chart and image, and that deploying the chart should be all that is needed to run the app. No values.yaml to configure.
Can you confirm ?

For background, coming back to the spike after 3 weeks I implemented chart push today and noted that I cannot set name and tag of the chart in the push command. I have to unpack the tarball I have, edit the Chart.yaml to set the desired values, and then repack the tarball. And at that point it should be a trivial step to the integrate information from the app's values.yaml into the chart's values.yaml and not upload the app values.yaml as a third piece.
And looking again here this may have been your intent all along.
Thus my question above.


Add another name to flux command "stream-to-xml"

This name points to SimpleXmlEncoder.
Keeping the old name for compatibility reasons.
See #308.

Some flux test would be nice to verify that both commands still work, but we have no general place set up for flux tests, right?

Yes, we have no flux tests. However, calling flux.sh brings up two implementations of org.metafacture.xml.SimpleXmlEncoder. Also, copying the one example using the old flux command (MARC21-EDM.flux) to a new one which uses the new command encode-xml shows: both are good and results are the same.
As discussed, will update this MARC21-EDM.flux to use the new command as reference for future usage.


Module preconditions don't inherit

Module properties don't pass to their submodules. You have to re-specify a context for every submodule in the module.
Here's a quick working example.
[Module, Name("Example")]
[RequireContext(ContextType.Guild)]
public class ExampleGroup
{
    [Command("example")]
    [Description("This command requires a guild context, and will not work in a PM.")]
    public async Task Example(IUserMessage msg)
    {
        var guild = (msg.Channel as ITextChannel).Guild;
        await msg.Channel.SendMessageAsync(guild.Name);
    }

    [Module("example"), Name("Example")]
    public class SubCommands
    {
        [Command("subcommand")]
        [Description("This one does not, and will work in a PM.")]
        public async Task Subcommand(IUserMessage msg)
        {
            var guild = (msg.Channel as ITextChannel).Guild;
            await msg.Channel.SendMessageAsync(guild.Name);
        }
    }
}

Duplicate of #263

What Finite said


getPropertyAsObject: property '__fbRequireBatchedBridge' is not an Object -> Error

I want to develop a react native app, which is developed for android/ios app and web also. So I use the "react-native-web" and "react-native" package. I created a project by tutorial, the web version is working without errors, but if I execute the app for my device or on android emulator, then the error "getPropertyAsObject: property '__fbRequireBatchedBridge' is not an Object" pops up.
Need some help please.
React Native version:
^0.60.5
Steps To Reproduce

Make the tutorial of https://scotch.io/tutorials/build-mobile-friendly-web-apps-with-react-native-web
Execute "npm run start-web"
Install "@babel/plugin-proposal-object-rest-spread" as dev package instead of "babel-plugin-transform-object-rest-spread"!!! Replace the plugin in .babelrc
Plugin your device or open your android emulator.
Execute "npm run android" to install the right expo client version on device
Execute "npm run start-native".
Open the app.

Describe what you expected to happen:
If I want to start the app, then this error pops up.

Snack, code example, screenshot, or link to a repository:
This is the repository of the tutorial:
https://github.com/christiannwamba/react-native-web-example
Keep in mind, that at the repo, are older versions!
package.json
{
  "name": "react-web-mobile-test",
  "version": "0.1.0",
  "private": true,
  "main": "./App.js",
  "dependencies": {
    "expo": "^34.0.4",
    "react": "^16.9.0",
    "react-art": "^16.9.0",
    "react-dom": "^16.9.0",
    "react-native": "^0.60.5",
    "react-native-web": "^0.11.7",
    "react-scripts": "3.1.1"
  },
  "scripts": {
    "start-web": "react-scripts start",
    "build-web": "react-scripts build",
    "test-web": "react-scripts test",
    "eject-web": "react-scripts eject",
    "start-native": "expo start",
    "android": "expo android",
    "ios": "expo ios",
    "build:ios": "expo build:ios",
    "build:android": "expo build:android"
  },
  "eslintConfig": {
    "extends": "react-app"
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  },
  "devDependencies": {
    "@babel/plugin-proposal-object-rest-spread": "^7.5.5",
    "babel-plugin-module-resolver": "^3.2.0",
    "babel-plugin-transform-react-jsx-source": "^6.22.0",
    "babel-preset-expo": "^5.2.0",
    "react-native-scripts": "^2.0.1"
  }
}

app.json
{
  "expo": {
    "sdkVersion": "34.0.0",
    "name": "react-web-mobile-test",
    "slug": "react-web-mobile-test",
    "version": "0.1.0",
    "description": "An application for app test",
    "primaryColor": "#ff8179",
    "android": {
      "package": "react.web.mobile.test"
    }
  }
}

If you need more informationen, you can asks me.

Ok I deactived the web developer logging and now it is working.

Ok I deactived the web developer logging and now it is working.

hi Floridus ：
I same error . can you help me??

same error here, help me please???!!!

I'm also getting the same error. Please help me

Please help me as soon as possible.

i am getting same here, any luck on solution?

uninstall node modules and then try to install it again will fix the issue.
On Fri, 4 Sep, 2020, 12:13 shrimallamanoj<EMAIL_ADDRESS>wrote:

i am getting same here, any luck on solution?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/26165#issuecomment-686948204,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOBGZO4HWIXVJEIPOILD7SDSECEBJANCNFSM4IO6PZHQ
.