luci-app-wireguard: Invalid Error Message, Refresh

Steps to reproduce:
Hi,
I have noticed that if I have WireGuard configured, but handshake has not occurred, the status shows,
No WireGuard interfaces configured
But that's not really correct. It's not connected (vs. not configured). Perhaps update this wording? I don't mind updating it, if you'd prefer.
I have also noticed, that in this state refresh is not really updating. If it connects ... you have to manually refresh. This one seems a bit more odd. Any reason why it wouldn't refresh? And it seems that state changes are what cause this to not refresh properly?
Thanks!
Actual behavior:
As noted above.
Expected behavior:
As noted above.
Additional Information:
OpenWrt version information from system /etc/openwrt_release
DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='22.03.0-rc6'
DISTRIB_REVISION='r19590-042d558536'
DISTRIB_TARGET='ipq40xx/generic'
DISTRIB_ARCH='arm_cortex-a7_neon-vfpv4'
DISTRIB_DESCRIPTION='OpenWrt 22.03.0-rc6 r19590-042d558536'
DISTRIB_TAINTS='no-all'

Delete the Interface, then Recreate the Interface


Add kgc.edu.vn to domain list

Belong to Kien Giang College (or Kien Giang Community College). Located in Kien Giang, Vietnam

@yukoDotMoe First stage of verification passed, official domain is kgc.edu.vn as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@yukoDotMoe I have to close this request without merging, because you requested to add a non-existent domain to this repository: ;; connection timed out; no servers could be reached Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


⚠ Bofrost.de has degraded performance

In 305dade, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1010 ms

Resolved: Bofrost.de performance has improved in cc621c3.


ReqMgr2: cannot update request priority for assignment-approved wfs

Going to reqmgr2 and updating only the RequestPriority field raises a 'Server Error' on the browser.
The traceback in the logs is
Getting from Cache due to: CouchNotFoundError - reason: Object Not Found, data: {} result: None
[30/Jun/2016:08:47:33]  SERVER REST ERROR WMCore.ReqMgr.DataStructs.RequestError.InvalidSpecParameterValue 9b02ba1fc90401231b5c003a23fe3630 (Invalid spec parameter value: can't update value without state transition: {})
[30/Jun/2016:08:47:33]    Traceback (most recent call last):
[30/Jun/2016:08:47:33]      File "/data/srv/HG1606f-comp4/sw.amaltaro/slc6_amd64_gcc493/cms/reqmgr2/1.0.18.pre3/lib/python2.7/site-packages/WMCore/REST/Server.py", line 708, in default
[30/Jun/2016:08:47:33]        return self._call(RESTArgs(list(args), kwargs))
[30/Jun/2016:08:47:33]      File "/data/srv/HG1606f-comp4/sw.amaltaro/slc6_amd64_gcc493/cms/reqmgr2/1.0.18.pre3/lib/python2.7/site-packages/WMCore/REST/Server.py", line 783, in _call
[30/Jun/2016:08:47:33]        obj = apiobj['call'](*safe.args, **safe.kwargs)
[30/Jun/2016:08:47:33]      File "/data/srv/HG1606f-comp4/sw.amaltaro/slc6_amd64_gcc493/cms/reqmgr2/1.0.18.pre3/lib/python2.7/site-packages/WMCore/ReqMgr/Service/Request.py", line 549, in put
[30/Jun/2016:08:47:33]        result = self._updateRequest(workload, request_args)
[30/Jun/2016:08:47:33]      File "/data/srv/HG1606f-comp4/sw.amaltaro/slc6_amd64_gcc493/cms/reqmgr2/1.0.18.pre3/lib/python2.7/site-packages/WMCore/ReqMgr/Service/Request.py", line 523, in _updateRequest
[30/Jun/2016:08:47:33]        report = self._handleNoStatusUpdate(workload, request_args)
[30/Jun/2016:08:47:33]      File "/data/srv/HG1606f-comp4/sw.amaltaro/slc6_amd64_gcc493/cms/reqmgr2/1.0.18.pre3/lib/python2.7/site-packages/WMCore/ReqMgr/Service/Request.py", line 456, in _handleNoStatusUpdate
[30/Jun/2016:08:47:33]        raise InvalidSpecParameterValue("can't update value without state transition: %s" % request_args)
[30/Jun/2016:08:47:33]    InvalidSpecParameterValue: InvalidSpecParameterValue 9b02ba1fc90401231b5c003a23fe3630 [HTTP 400, APP 1102, MSG "Invalid spec parameter value: can't update value without state transition: {}", INFO None, ERR None]
[30/Jun/2016:08:47:33] alan-cloud1.cern.ch <IP_ADDRESS> "PUT /reqmgr2/data/request/amaltaro_MonteCarlo_Ext_HG1607_Validation_160629_152252_7641 HTTP/1.1" 400 Bad Request [data: 4695 in 788 out 143966 us ] [auth: OK "/DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=amaltaro/CN=718748/CN=Alan Malta Rodrigues" "" ] [ref: "https://alan-cloud1.cern.ch/reqmgr2/fetch?rid=amaltaro_MonteCarlo_Ext_HG1607_Validation_160629_152252_7641" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:47.0) Gecko/20100101 Firefox/47.0" ]

Ideally, all parameters not changed should be removed from the json passed upstream.
This goes inline with this issue as well #6932

@vkuznet how easy is it to pass only modified parameters upstream? Ideally we should make this change for ALL pages where there is a possible action.
If possible, we could target it for the next cmsweb release (the current one is too tight at this moment)

Alan, I don't see relation of posted traceback with your request feature. The traceback just says that it can't update state without state transition. The web UI should not make decision which parameters are accepted or not on a backend server it is a server job. The web UI should parse the web form that's it and parsing the web form means take all parameters on it. Don't delegate the action to inappropriate layer. If server need to do a PUT request with the same parameters nothing wrong with it, think about it. You have a doc with some values and you want to update it. If you'll be given the same parameters to update nothing wrong with that.

The traceback is misleading because the web UI is passes the whole json back to the server, regardless of what changed or not. Which then the backend server handles as a "whole" request update instead of a requestpriority only (there are different methods on the server to handle that).
I may agree with you that such logic should not be put on the web layer. However, since it has all the values already why to verify what is new and only pass those parameters?
Otherwise, we need to make another GET call on the server for every PUT call, to fetch the data and x-check what is updated or not. Do you see my point?

There is a restriction on assignment-approved to assigned transition.
Properties cannot be updated without state transition.
If that is not reasonable assumption, I can can change that in serverside.

If that's not too much work, I think allowing RequestPriority change at any request status before completed should be done. A use case would be: McM injects a small batch and notices their priority is wrong, so they'd simply update it without state transition.

I just gave it a try via web UI on request:
amaltaro_TaskChain_MC_HG1609_ReqMgr2_Validation_160906_130245_5036
and got back a "Server error message". The traceback is:
Getting from Cache due to: CouchNotFoundError - reason: Object Not Found, data: {} result: None
[06/Sep/2016:13:52:38]  Error: Traceback (most recent call last):
  File "/data/srv/beHG1609c/sw/slc6_amd64_gcc493/cms/reqmgr2/1.0.20.pre4/lib/python2.7/site-packages/WMCore/ReqMgr/Service/Request.py", line 205, in validate
    self._validateRequestBase(param, safe, validate_request_update_args, requestName)
  File "/data/srv/beHG1609c/sw/slc6_amd64_gcc493/cms/reqmgr2/1.0.20.pre4/lib/python2.7/site-packages/WMCore/ReqMgr/Service/Request.py", line 113, in _validateRequestBase
    workload, r_args = valFunc(args, self.config, self.reqmgr_db_service, param)
  File "/data/srv/beHG1609c/sw/slc6_amd64_gcc493/cms/reqmgr2/1.0.20.pre4/lib/python2.7/site-packages/WMCore/ReqMgr/Utils/Validation.py", line 116, in validate_request_update_args
    workload.validateArgumentForAssignment(args_without_status)
  File "/data/srv/beHG1609c/sw/slc6_amd64_gcc493/cms/reqmgr2/1.0.20.pre4/lib/python2.7/site-packages/WMCore/WMSpec/WMWorkload.py", line 1650, in validateArgumentForAssignment
    validateArgumentsUpdate(schema, argumentDefinition)
  File "/data/srv/beHG1609c/sw/slc6_amd64_gcc493/cms/reqmgr2/1.0.20.pre4/lib/python2.7/site-packages/WMCore/WMSpec/WMWorkloadTools.py", line 250, in validateArgumentsUpdate
    _validateArgumentOptions(arguments, argumentDefinition, "assign_optional")
  File "/data/srv/beHG1609c/sw/slc6_amd64_gcc493/cms/reqmgr2/1.0.20.pre4/lib/python2.7/site-packages/WMCore/WMSpec/WMWorkloadTools.py", line 124, in _validateArgumentOptions
    raise WMSpecFactoryException(msg)
WMSpecFactoryException: WMSpecFactoryException
Message: Validation failed: ProcessingString is mandatory {'attr': 'processingString', 'default': '', 'assign_optional': False, 'optional': True, 'validate': <function procstring at 0x7f036ff35e60>, 'null': False, 'type': <type 'str'>}
	ModuleName : WMCore.WMSpec.WMWorkloadTools
	MethodName : _validateArgumentOptions
	ClassInstance : None
	FileName : /data/srv/beHG1609c/sw/slc6_amd64_gcc493/cms/reqmgr2/1.0.20.pre4/lib/python2.7/site-packages/WMCore/WMSpec/WMWorkloadTools.py
	ClassName : None
	LineNumber : 124
	ErrorNr : 0

Traceback:

[06/Sep/2016:13:52:38]  SERVER REST ERROR WMCore.ReqMgr.DataStructs.RequestError.InvalidSpecParameterValue a56ef5fdc300f66feb59c298f0b0af26 (Invalid spec parameter value: Validation failed: ProcessingString is mandatory {'attr': 'processingString', 'default': '', 'assign_optional': False, 'optional': True, 'validate': <function procstring at 0x7f036ff35e60>, 'null': False, 'type': <type 'str'>})
[06/Sep/2016:13:52:38]    Traceback (most recent call last):
[06/Sep/2016:13:52:38]      File "/data/srv/beHG1609c/sw/slc6_amd64_gcc493/cms/reqmgr2/1.0.20.pre4/lib/python2.7/site-packages/WMCore/REST/Server.py", line 708, in default
[06/Sep/2016:13:52:38]        return self._call(RESTArgs(list(args), kwargs))
[06/Sep/2016:13:52:38]      File "/data/srv/beHG1609c/sw/slc6_amd64_gcc493/cms/reqmgr2/1.0.20.pre4/lib/python2.7/site-packages/WMCore/REST/Server.py", line 779, in _call
[06/Sep/2016:13:52:38]        v(apiobj, request.method, api, param, safe)
[06/Sep/2016:13:52:38]      File "/data/srv/beHG1609c/sw/slc6_amd64_gcc493/cms/reqmgr2/1.0.20.pre4/lib/python2.7/site-packages/WMCore/ReqMgr/Service/Request.py", line 238, in validate
[06/Sep/2016:13:52:38]        raise InvalidSpecParameterValue(msg)
[06/Sep/2016:13:52:38]    InvalidSpecParameterValue: InvalidSpecParameterValue a56ef5fdc300f66feb59c298f0b0af26 [HTTP 400, APP 1102, MSG "Invalid spec parameter value: Validation failed: ProcessingString is mandatory {'attr': 'processingString', 'default': '', 'assign_optional': False, 'optional': True, 'validate': <function procstring at 0x7f036ff35e60>, 'null': False, 'type': <type 'str'>}", INFO None, ERR None]

Alan, it won't allow only Priority update via Web interface. (It should allow via REST api).
The problem with GUI is that it will send all the data in the page when it updates the priority, which is not allowed.
What we can do is when there is no state transition it only update the Priority. But IMO, it is a little confusing behavior. i.e if someone changes 2 field including Priority and other field but it only gets updated one.

What we can do is when there is no state transition it only update the Priority. But IMO, it is a little confusing behavior. i.e if someone changes 2 field including Priority and other field but it only gets updated one.

That's exactly what we should do, IMO. Either:
a) Ops change the RequestPriority only (no need to validate/update anything else)
b) Ops change RequestStatus and update all the other assignment parameters
c) same as b), but Ops also updates the RequestPriority.
Anything that doesn't meet these use cases, should fail.

Fixed by #7265


Create API to get parent tree data for SMP lat, long and elevation calculation

Describe the task
An API needs to be developed to get the lat long and elevation data of parent trees used in the SMP success screen. The mean latitude, longitude and elevation is then calculated for the SMP mix. This issue should modify the GET /api/orchards/parent-trees/vegetation-codes/{vegCode} endpoint by adding those values for each parent tree
Some documentation related here:https://apps.nrs.gov.bc.ca/int/confluence/display/FSADT2/SPR_001A_SMP_CALCULATION+Package+Analysis
Spike task #779 was created to determine if this documentation identified all data needed for calculation
Acceptance Criteria

[ ] API returns all the seedlot SMP-related information
[ ] Cover new code with the minimum threshold of 80%
[ ] All tests pass

Additional information

For this task, is expected from the developer only create the APi and fetch existing information, not do the calculations.
All these information will come frm the seedlot table.

This task needs https://github.com/bcgov/nr-spar/issues/812

Rolled over to Sprint 26

Duplicate of #368


Improve Contributors page done ! #650

Hello, PR
Issue fixed - #650
🔴Before (it display only 30 contributors) - #650
🟢Now (it display all contributors) -
https://github.com/user-attachments/assets/2352aa65-35c3-49dc-8fe3-1cfba396adb5
Type of PR

Add X in the box to specify the improvement type.
[X] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): ___________

Checklist

Add X in the box to specify.
[X] I have performed a self-review of my code.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Thank you for reviewing my pull request!

PA done properly.. #650

please merge my PR.. Thank You 🙏🏻

@Subhajit-2023-44

Fix it...the total contributions.


Add more hash functions

Of particular interest (to me) are:

CRC32
MurmurHash3
Blake2b

Linked are the proposed implementations.
The crc32 implementation claims to be standard within js.
The blake2 implementation is linked on the blake2 website.

Right now hash functions are limited to those offered through the Web Crypto API with the addition of md5. Adding more hash functions is definitely on the roadmap. First though, a mechanism needs to be put in place to lazily load external libraries and Web Assembly code only when needed by the current brick combination. The whole code separation challenge needs to be solved before we can tackle more algorithms that require external, well tested libraries.

I'd like to also request keccak256

Quick update: We won't be adding more hash functions to cryptii, as of now. However, over at ciphereditor, we already added CRC32 and Keccak to the hash operation and may add more hash functions in the future. See #129.

Thank you!


Refactor grofer to make it more extensible ✨

👏 Major 👏 Changes 👏
The main theme of this refactor is to make grofer more extensible and to avoid duplicating
and writing redundant boilerplate for every new command created. grofer still has a long
way to go in terms of code quality, but this is defintiely a start in the right direction.
Design:
The design of grofer now more closely resembles a producer-consumer model of doing things.
MetricScraper - A MetricScraper is any entity that scrapes metrics of any form and Serves them.
A MetricScraper also has the ability to set a Sink. Meaning that it can choose
what the consumer of the produced metrics will be.
MetricScraperFactory - A MetricScraperFactory produces MetricScrapers based on what the command
is. The main purpose of a MetricScraperFactory is to provide a uniform set
of functions using which a MetricScraper can be Constructed for any command.
The advantage that the above two abstractions provide is that it allows us to introduce new scrapers independant
of the code in the cmd directory and also allows us to introduce new Sinks irrespective of the scrapers present.
As of now, only one sink exists - TUI. Which is the TUI of grofer that consumes the produced metrics. Ideally,
export should also be a sink, but this isn't possible with the current state because of non-uniform data formats
being used. Once these formats are unified, sinks can be added independent of scrapers and vice-versa.
Directory structure (trimmed, not including non-code files):
├── cmd
├── pkg
│   ├── core
│   ├── export
│   ├── metrics
│   │   ├── container
│   │   ├── factory
│   │   ├── general
│   │   └── process
│   ├── sink
│   │   └── tui
│   │       ├── container
│   │       ├── general
│   │       ├── misc
│   │       └── process
│   └── utils
│       └── visualization
└── scripts

The previously src directory is now renamed to pkg directory due to convention.
metrics contains the logic and implementation of different MetricScrapers and the MetricScraperFactory.
Directories like metrics/container contain scraper specific logic to actually get metrics.
Files like metrics/factory/container_metrics.go contain the implementaion of MetricScraper for a container
metrics specific MetricScraper.
In each implementation of MetricScraper, the Serve() method is reponsible for choosing between sinks.
FactoryOptions are used to inject command specific configuration into the MetricScraper implementation.
sink contains the different sinks that can consume metrics.
The core package contains different command and sink types, and also some custom errors.
Each command in the cmd directory uses a seperate command struct to and associated functions to abstract details
from top level functions in cobra.

Misc changes:

Everywhere interfaces and their corresponding implementations are involved:

Interface compliance checks are included.
This is done to catch any errors at compile time in case interfaces either upstream or downstream change.

File names of the form fileName.go are changed to file_name.go because camel case in file names is weird.
The script to check licenses now aggregates all files that don't have licenses and then exits with non-zero code.

Previously this used to exit with non-zero code on occurence of the first such file.
Ironic isn't it? Considering its in python :p

@Gituser143 made the changes discussed on call, along with refactoring error art ;)


Turn market_id attribute into consumption_price_sensor

          I was [planning](https://github.com/FlexMeasures/flexmeasures/discussions/763#discussioncomment-6500979) to document which attributes are actually relevant, and market_id would have to be added to the list.

Is it possible to replace the name market_id with consumption-price-sensor, for instance, so we get more consistency?
Originally posted by @nhoening in https://github.com/FlexMeasures/flexmeasures/pull/695#discussion_r1274711114
As @Flix6x said, this needs a db migration, a few code replacements and maybe a check within plugins we have, like the one we use for simulations.
Plus, maybe mentioning in the upgraded documentation that consumption-price-sensor can also live outside of the flex context as an attribute.
Or (my preferred option), we use flex-context["consumption-price-sensor"], for more consistency. I want us to look up flex-model and flex-context on either sensor or asset, and this way we can get rid of market_id with a comprehensive solution which will work for all other things, as well (capacity_in_mw would be part of flex-model, see #335 - we could tackle these together)

@Flix6x suggests doing this together with other renaming work, see #911


[match] How can make certificate for ApplePay base on CSR?

How can make certificate for ApplePayfor merchant base on CSR through fastlane?
Please help me

Have you had a chance to check out the docs yet? I think something like: https://docs.fastlane.tools/actions/produce/#creating-apple-pay-merchants-and-associating-them-with-an-app-id might help.

@taquitos yes I read this.
But for merchant need upload CSR request and in answer receive CERT for payment system.
this is functional not isset.

I about this functional

For example in arg for produce set csr path and generated cert save in same dir
or
set csr data how string and get cert in ENV variable

@taquitos you can help?

@GandjaFuzz sorry, it's not supported right now in fastlane 😞 We don't have plans to add that feature right now since demand is very low and our current workload is very high. If you want to build it out we'd be happy to review your PR though 🚀

😞😞😞😞😞😞😞😞😞😞

@taquitos i have this problem too

@taquitos i have this problem too

+1

+1

@joshdholtz Any suggestions on I can start with the implementation for this?

@RishabhTayal I actually have never done anything with Apple Pay so I don't really have any suggestions besides inspect the requests in browser and/or with Charles Proxy 😉

@joshdholtz I meant how and where in fastlane would I generate the certificates? something similar to match or sigh?

@RishabhTayal Ohhhhhhhhhh lol... I would actually think maybe a brand new action? pem does something similar but for push certificates so I would create a new action for this I think

I think for example need use so
in fastfile
pay (
	username: USER,
	csr: REQUEST, //path or data from csr
	merchant: merchant.com.example.app,
)

ENV['APPLE_PAY_CERTIFICATE_ID']
ENV['APPLE_PAY_CERTIFICATE'] //maybe base64 or paste in file

//download
pay (
	username: USER,
	merchant: merchant.com.example.app,
	certificate_id: id
)

ENV['APPLE_PAY_CERTIFICATE_ID']
ENV['APPLE_PAY_CERTIFICATE'] //maybe base64 or paste in file

//revoke
pay (
	username: USER,
	merchant: merchant.com.example.app,
	certificate_id: id,
	revoke: true
)```

Can we reopen this issue? I have a working PR in progress. @joshdholtz @taquitos ?

hello, when it is will released?

I review commit action for apple_pay_cert.
need add configuration with custom certificate signing request

@joshdholtz any plan on merging the PR?

PR #12466 is waiting for reviews and merge.

I see this pr, it is not correct, need can set path to custom csr, but this don’t have this functional.

@RishabhTayal Any comment on what @GandjaFuzz wrote?

LOL @fastlane-bot

So, is this ready or not?


Make region import robust even with messy polygons

Region polygons often have problems, such as:

Unclosed linear rings (the first and last point are not the same, even though GeoJSON says they must be).
Duplicate positions in a linear ring, other than the first and last.  This indicates a loop in the ring, which is not allowed by the OGC simple feature specification, even though it is allowed and common and Esri shapefiles.  Elasticsearch seems to expect GeoJSON polygons to conform to the simple feature specification.
Self-intersecting segments in the polygon.

In a perfect world, whoever provided the regions would fix these problems.  But in reality our system needs to be robust in the face of imperfect data.  To that end, we should automatically clean up these problems in the regions we load.  This recent paper, A triangulation-based approach to automatically repair GIS polygons, proposes a very promising approach:
http://dx.doi.org/10.1016/j.cageo.2014.01.009
http://www.sciencedirect.com/science/article/pii/S009830041400020X
There is an implementation of this approach, but it is not suitable for use in Magda because it uses the GPL licence.  It should be straightforward to implement it ourselves, though.

This is how I fixed the invalid geometries I had (for region mapping files):
ogr2ogr -f GeoJSON fixed.json invalid_geometries.json -dialect SQLITE -sql "SELECT ST_MakeValid(geometry) as geometry, * FROM OGRGeoJSON"

Would that help? @kring @AlexGilleran

Yes, that's great!  I didn't realize you can use ogr2ogr to execute ST_MakeValid.  For what it's worth, the paper above compares itself to MakeValid.  The paper's approach has some advantages, but this is still great.


#194 Logo / Favicon

Resolves #194, pending resolution of hover effects and CSS positioning janky-ness.

Did you colorize the background of the logo? It should really be transparent.

I did, partially because the original illustrator file wasn't set up in a real "vector" way. I'm going to just have to recreate it and then have one will full transparency.

Blergh, this took a lot longer than I thought it would. Here's the new logo (Illustrator is a pain in the butt):

Now everything's that's supposed to be transparent is transparent, so it should be pretty straightforward to regenerate the navbar logo.

Here's the updated logo:

I'll get these into my branch tomorrow and make sure everything plays nicely.

Oh man I haven't done ERB stuff in so long, my bad.

Tried dealing with the hover effect, major pain in the butt. See #194 for more details, tried both recoloring SVG's and CSS / div backgrounds but couldn't get it to work properly. Ended up going with a basic jQuery hover function, any suggestions for improvement are welcome.
Also downsized the logo images, but then realized we might want higher resolution files for high DPI screens or whatever... might be beyond the capabilities of our app though :stuck_out_tongue:. Let me know how it looks!

So IMO, we shouldn't use an image for this, but rather one of two things:

an SVG
an icon font

(For the latter we'd have to make one.) One of the reasons I chose an icon from FontAwesome as the placeholder logo was so it'd be resolution-independent – going back to ol' raster images is a bit of a downgrade.
We would then handle the color and sizing of the logo in our CSS, instead of it being "hard-coded" in an image file. Does that make sense?
I'd also like to add the source files (Illustrator file?) to the repo too (not sure where exactly...)

I agree, that was my first try but it didn't work because we have to filled paths (the "R" and the area above it) and the rest are transparent filled. I could try going back into the Illustrator file to split the remaining path; in that case I could go back to my CSS-driven SVG changes vs two separate image files. I guess a second option is just switching to two SVG's instead of two PNGs.
I've got all the source files and will find a place with them in the repo.

What about an icon font?

Tried creating an icon font but because we have some unfilled paths the online generator I found didn't work. I switched to using two SVG's instead and some basic JS to switch the src files on hover; it can be a little slow at first but seems to be adequate in my mind. I also uploaded the *.ai file to the repository (stuck it in app/assets/images/). Let me know what you think!

Update: trying to use the inline SVG method I mentioned in the issue still doesn't work because the SVG export from Illustrator ends up creating some closed paths (like the clock outline) that should really be open; this means that changing the fill color in the whole SVG ends up destroying the clock :confused:. I'd really rather use CSS to switch the logo color but I'm not sure how to do that right now :cry:.

I used the inline svg gem to, well, inline the svg so that we can use CSS/JS to change the color instead of having to replace the image source, speeding up the animation by quite a bit (and removing the need for having two different svg logo files)

@squidgetx Why'd you take the Illustrator file out?

I figured it wasn't necessary since the current .svg contains enough information. I can put it back if you want to mess with it but the current .svg can be colored entirely through setting fill and stroke anyway

Of course there's a gem to do what I was doing manually before :-P. I'm with @mnquintana, let's keep the AI source file in case anyone ever wants to edit it using the native Illustrator format (I'm aware that the SVG should have enough information but the paths are slightly different in the Illustrator file). Reading through the code now...

Ok, I made some whitespace fixes, re-added the AI file, and slightly increased the right padding on the logo. This should be good to go, @mnquintana do you want to give it one more look over and then I'll squash / merge? Thanks @squidgetx for the cleaner inline SVG implementation!

I figured out how to do the change using CSS inherit so we don't even need any JS anymore :D

Awesome, great job! I renamed the logo file to res_logo.svg and I think this is good to go. @squidgetx, are you good for me to squash / merge?

:shipit:

@orenyk Let me take a look at this tonight before you do

I dealt with @mnquintana's comments, added a little SASS magic to our stylesheet for the hover styling, and squashed. @mnquintana, want to double check it or am I good to merge?


fix Fixed the bug that would be core when exporting large amounts of data

Proposed changes
Issue Number: close #xxx
A heap-buffer-overflow error occurs when exporting large amounts of data to orc format.
Reserve 50B for buffer to avoid this problem.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 53.55 seconds
stream load tsv:          502 seconds loaded<PHONE_NUMBER>9 Bytes, about 142 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          88.4 seconds inserted 10000000 Rows, about 113K ops/s
storage size:<PHONE_NUMBER>2 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230712185642_clickbench_pr_177193.html

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 53.31 seconds
stream load tsv:          503 seconds loaded<PHONE_NUMBER>9 Bytes, about 141 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          86.8 seconds inserted 10000000 Rows, about 115K ops/s
storage size:<PHONE_NUMBER>0 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230713115401_clickbench_pr_177766.html


Fails at npm run serve

node: 8.9.1
npm: 5.5.1
weex-toolkit: 1.1.0-beta.7
osx: 10.12.6

npm install -g weex-toolkit
weex create myproject
cd myproject
npm install
npm run build
npm run serve

><EMAIL_ADDRESS>serve /Users/___/git/weex/myproject
> webpack-dev-server --config webpack.dev.js --watch --open

server is running! Please open http://MY_IP:8080/
events.js:183
      throw er; // Unhandled 'error' event
      ^

Error: listen EADDRINUSE <IP_ADDRESS>:8081
    at Object._errnoException (util.js:1024:11)
    at _exceptionWithHostPort (util.js:1046:20)
    at Server.setupListenHandle [as _listen2] (net.js:1351:14)
    at listenInCluster (net.js:1392:12)
    at doListen (net.js:1501:7)
    at _combinedTickCallback (internal/process/next_tick.js:141:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
    at Function.Module.runMain (module.js:678:11)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>serve: `webpack-dev-server --config webpack.dev.js --watch --open`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>serve script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

arrr, other app was using same port.


[gql] events (eventConnection) on tx

Description
Use fetch_events for transaction
Test Plan
transactions/events.move

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Note that the StoredTransaction keeps track of a serialized representation of all its events:
https://github.com/MystenLabs/sui/blob/0a4182d17651e5b4d496f8ca2fa4610362bcf9af/crates/sui-indexer/src/models_v2/transactions.rs#L36
So it would be better to implement this referencing that, instead of doing another DB roundtrip, if we can avoid it, but we can treat that as a follow-up.

Hmm.. not sure how I missed this, thanks for calling it out. I think I can update Event representation to have optional StoredEvent and required NativeSuiEvent

I think I can update Event representation to have optional StoredEvent and required NativeSuiEvent

I was just having a look at this -- there are quite a few rows in StoredEvent that are actually derived from the transaction block, so you may want to keep the representation of GraphQL's event the same (a StoredEvent) but provide a way to build one given a GraphQL transaction block and a native event, or just a plain StoredEvent.

I think I can update Event representation to have optional StoredEvent and required NativeSuiEvent

I was just having a look at this -- there are quite a few rows in StoredEvent that are actually derived from the transaction block, so you may want to keep the representation of GraphQL's event the same (a StoredEvent) but provide a way to build one given a GraphQL transaction block and a native event, or just a plain StoredEvent.

Astute observation! Yes exactly, StoredTransaction and the native event can recreate a StoredEvent. Verified in the indexer code that values such as timestamp_ms are the same between the Indexed -> Stored Transaction and Event. I will do this to keep things simple

Ready for another review. Figured it'd be easier to just do the "right" thing straight up (use serialized events on StoredTransaction)

Thanks @wlmyng, some small clean-ups for this here: #15577


Simplify the read_i08() bool result cast.

The cython-generated code for bool(read_i08(buf)) includes a call to the
Python bool type function. That extra call is unnecessary in this case.
Instead, we can cast to cython's bint type, which generates code that
directly returns Py_True or Py_False (via __Pyx_PyBool_FromLong).
This appears to be the most efficient code generation for this expression.
For completeness, I also investigated these variants:

<bool>read_i08(buf)
read_i08(buf) != 0
<bool>(read_i08(buf) != 0)
return False if read_i08(buf) == 0 else True

Thanks!


Long files tend to error out

Audio/video files over an hour sometimes error out. Probably due to diarization.

I can't reproduce the error.
Tried with this youtube video: https://youtu.be/RcYjXbSJBN8
I will try with a local audio file.

For reference this was a 1.5+ hour video in a non-English language

Fixed by the recent updates in the diarization process and release v0.4.0 #186


test: Add release test workflow [DEV-4160]

Task linked: DEV-4160 Modify playwright tests that are causing longest delays


Don't enable pulsar manager by default

Motivation

because of security reasons

it increases the attack surface
pulsar manager cannot be run as non-root user, issue reported as https://github.com/apache/pulsar-manager/issues/407

it's an unnecessary feature for most users

wasted resource consumption

+1


Deploy Dev into main

Merging will be quite difficult as our main and dev branches have diverged. Especially the already existing squashed commit of dev inside main is rather problematic. Solving the merge conflicts manually is not really feasible.
We propose to cherry-pick the two heroku-related fixes which are currently only in the main branch into the dev branch. Then we could remove the last three commits from main (would require a force push :/), so that dev is based on main again.
Then, rebase-merging (not squash merging) dev into main should be no problem. Generally, we should make sure to never squash-merge into main as this will always yield conflicts.
What do you think about this @chrisma @Tratori

What do you think about this @chrisma @Tratori

Oh, what a shame that squash merges made it into main, but good to see that there was a Heroku fix! If you cherry-pick the Heroku fixes into dev, would that allow you to rebase the dev changes onto main?
However, we should also consider the time investment. As not much has happened on main recently and its main use is serving as a stable base for being deployed to Heroku, it might not be worth investing a lot of time into fixing the issue "properly" just now. It may be wise to update main using whatever method works and is fastest.

We have resetted main to before the squash merge. We should wait with this PR until #207 is merged. Then, we should enable the "Squash and Rebase" button in the Github settings and use it for this PR @Tratori @JessicaDierking

I don't see the point in squashing before the rebase... Can you explain why that would make sense?
@bewee

I don't see the point in squashing before the rebase... Can you explain why that would make sense?
@bewee

I was wondering this too. What would be the advantages of squashing commits from dev and then having only a single additional commit in main?
I understand the motivation to squash-merge feature branches / individual PRs into dev, as that cleans up the various tiny changes and fixes required for a feature, leaving only a single neat feature commit in dev. Assuming dev is then tidy, what would an additional squash of those dev commits accomplish?
If a fixed state of the application is to be described, maybe tags can be helpful?

Damn it, that was a typo, obviously a "Rebase and Squash" button does not exists. Meant the "Rebase and merge" button 🤦♂ I am completely on your side here, squashing into main is not sensible.

Currently, only squash merges are permitted

Yes, that's why we have to change github settings before every merge of dev into main

Merged it into main... The result is stunning :D

Also GitHub doesn't seem to like the rebase very much

Uff, yes, for some reason the commits got new commit IDs
On main:

On dev:

I can't find the one additional commit on dev however 🤔

If we would have used "Create a merge commit", would this problem have occured as well?


[HW] puru

Name: Puru
Email<EMAIL_ADDRESS>Linkedin Profile: www.linkedin.com/in/puru-soni-646188205
Attach the homework step I screenshots below:
Creating database:

Deploying TikTok clone site:

Linking with Netlify:

Attach the homework step II screenshots below:
Collection in our database called "tktkposts":

Documents stored in a database:

PART - 3:

Hey Puru, great job! Congrats! Here is your badge! https://api.badgr.io/public/assertions/bzsCpc9oTcWFRDRhC6IOqg


Fix build issues related to Arrow headers

Fixes https://github.com/facebookincubator/velox/issues/7399

cc: @majetideepak

Please add a description to the PR on what issues this change fixes.

@yingsu00, the fix here and the issue linked in the description do not align. Can you please clarify? Thanks.

@yingsu00, the fix here and the issue linked in the description do not align. Can you please clarify? Thanks.

@majetideepak Sorry I don't understand your question, as the fix and issue do align, and each of the commit explains the issue in the commit message in detail. Anyways I added more explanations in the PR message. Let me know if that answers your question.

and each of the commit explains the issue in the commit message in detail.

Ah! Unlike a Presto PR, the commits here get squash merged. And the PR description is what gets reflected in the final commit.

@pedroerp @majetideepak Updated the PR message to the following
This PR fixes "parquet/level_conversion.h: No such file or directory" issue caused by the recent
Arrow package move to the Parquet writer. The tests include ParquetReader headers but the
Parquet reader is not turned on by default (VELOX_ENABLE_PARQUET = OFF), and thus Arrow
was not enabled and installed, causing the Arrow headers like "parquet/level_conversion.h to be
missing.

This PR includes two fixes:

1. The include of ParquetReader.h in S3InsertTest.cpp is not needed. The first commit
cleans up the includes for S3InsertTest.cpp.

2. Guard RowContainerSortBenchmark and velox_sort_benchmark with the VELOX_ENABLE_PARQUET setting.

Resolves https://github.com/facebookincubator/velox/issues/7399

@pedroerp @kgpai Will you please review and merge this? Thanks!


Feature/not found for deleted submissions

Oooh, this is super helpful! I hadn't realised it wasn't handling 404s correctly. Turns out I have a local branch that partially does this, which I never pushed, whoops.
Sorry for the delay, I'll make some edits and get this merged soon, thank you!

I accidentally ended up reworking the whole error checking there, thank you for poking me on this, the error checking FAExport has been doing needed quite some improvement, and this prompted me to look into it

Oh wow, I keep debating that, but I figured it would need quite a big refactor to make it do so in a nice way. That's a lot of work!

Frustrating (but somewhat understandable) that forks can't access the secrets to actually run the regression tests. I'm not sure how that's meant to actually work.
But pushing to a branch on this repo, I can see all the tests are passing now, woo! I'll get this merged and released, thanks again!
(Also, the github code scanning doesn't seem to recognise that the tests run in Ruby 2.5, and suggests things for Ruby 2.6? Frustrating.. I might need to look into those settings. I'm not an expert at Ruby)


play button position in small size

Hello,
I see a strange thing. I am trying to use the clappr to play some hls audio only streams and then I used that config:
`var player = new Clappr.Player({
source: 'https://myurl/playlist.m3u8',
parentId: '#player',
poster: '',
height: 45,
hideMediaControl: false,
width: 325,
});`
In demo page the play button stay align in middle and in the center. But in my page the play button stay scruffy near the bottom of the player.
https://fb.radiosnaweb.com/clapp/sample.png
How can I handle that and why in http://clappr.io/demo it is ok and in my code not?

The issue you describe seems to be a CSS conflict: use browser debug tool to inspect and check css rules applied on play button.

I try to simulate in a page without other css stuff: https://v2.atendimento.inf.br/teste.html

It is the background image you configured as poster : https://fb.radiosnaweb.com/clapp/play9.png

It is the background image you configured as poster : https://fb.radiosnaweb.com/clapp/play9.png

But the issue is the vertical alignement of the play button in stop state. It stay not in the middle, it stay near the botton. I did not find a reason for that misalignment. Try stop the play and you will see where the play button pops up.

I found out what was affecting the placement of the play button in the stopped state:
this tag on my page before the  tag:
<!doctype html>


[BUG] Folder icons not working on IntelliJ (Remote WSL setup)

Describe the bug
The folder icons are not loading
To Reproduce

Use IntelliJ from WSL using the Jetbrains provided remote Gateway directly from the IDE.
Install plugin on host and most importantly the client as it is an UI plugin
Folders icons not loading

Expected Behavior
I should see folder icons. I see them when deactivating the plugin's folder icons feature.
Environment
IntelliJ IDEA 2024.1.4
Build #JBC-241.18034.62, built on June 20, 2024
Runtime version: 17.0.11+1-b1207.24 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 11.0
Controller in Remote Development
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 12
Registry:
  ide.experimental.ui=true
  rdclient.backend.actionHandlers=false
Non-Bundled Plugins:
  com.intellij.plugins.vscodekeymap (241.14494.150)
  com.intellij.plugins.eclipsekeymap (241.14494.150)
  com.intellij.plugins.netbeanskeymap (241.14494.150)
  com.codeium.intellij (1.10.7)
  com.intellij.plugins.visualstudiokeymap (241.14494.150)
  com.mallowigi (97.0.0)

Screenshots

4cf574e
2024-08-01 10:25:13,784 [1660095]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.intellij.util.IconSizeWrapper@257fd35d
2024-08-01 10:25:13,784 [1660095]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.mallowigi.actions.IconToggleAction$selectedFallbackIcon$1@d585407
2024-08-01 10:25:13,784 [1660095]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.intellij.util.IconSizeWrapper@4aed4df1
2024-08-01 10:25:13,784 [1660095]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.mallowigi.actions.IconToggleAction$selectedFallbackIcon$1@548606c5
2024-08-01 10:25:13,785 [1660096]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.intellij.util.IconSizeWrapper@fb8c233
2024-08-01 10:25:13,785 [1660096]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.mallowigi.actions.IconToggleAction$selectedFallbackIcon$1@408f57af
2024-08-01 10:25:13,785 [1660096]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.intellij.util.IconSizeWrapper@60ad088a
2024-08-01 10:25:13,785 [1660096]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.intellij.util.IconSizeWrapper@4f99a74
2024-08-01 10:25:13,785 [1660096]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.mallowigi.actions.IconToggleAction$selectedFallbackIcon$1@4d997982
2024-08-01 10:25:13,785 [1660096]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.intellij.util.IconSizeWrapper@77116db1
2024-08-01 10:25:13,785 [1660096]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.intellij.util.IconSizeWrapper@7ff0c281
2024-08-01 10:25:13,785 [1660096]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.intellij.util.IconSizeWrapper@3792cd31
2024-08-01 10:25:13,785 [1660096]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.intellij.util.IconSizeWrapper@3141e728
2024-08-01 10:25:13,785 [1660096]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.mallowigi.actions.IconToggleAction$selectedFallbackIcon$1@4d417854
2024-08-01 10:25:13,785 [1660096]   WARN - #c.j.r.u.i.ProtocolIconRegistry - Failed to serialize a model for icon com.intellij.util.IconSizeWrapper@34dc5fb7

No, it's a long time issue with the Remote Gateway. I'll try to see if other theme packs are working but in the past it was not possible to make it work


Python library convert finish signal

Hey,
I'm looking for a way to determine when a video is downloaded AND finished converting.
Just like in the example but one step further. The example hook only shows when the download is finished, but not when the file is ready finished.
Thanks in advance!

There is no such hook. Override YoutubeDL.post_process in order to know when post processing is finished.


diverging from original types

the updated versions are at https://github.com/webxdc/hello (webxdc.js and webxdc.d.ts files)
this project is creating a completely new file which has extra maintenance cost, couldn't this project just host the mentioned files then it would be easier for other projects to use this package as a dev dependency in package.json without having to include the file in their repository and manually updating it from time to time

fixed by #2


Deprecate writing to QuantumCircuit.data

Similar to #2170 , but for QuantumCircuit. The possibility of arbitrary data in circuit.data makes modifying or replacing the internals of QuantumCircuit difficult and error prone (see discussion around circuit._append in #2824 ). We should:

Move circuit.data to circuit._data
Add a getter for circuit.data and document it as a ordered list of (Instruction, qargs, cargs). It's an open question whether or not we should commit to preserving user-insertion order.
Add a setter for circuit.data with a DeprecationWarning, directing users to e.g. QuantumCircuit.append and the rest of the circuit API.

@mtreinish can you take this one please?

Thinking about this more, I don't know if we are ready to deprecate write-access to circuit.data yet. As of now, circuit.data is the only exposed way to modify a circuit, and we shouldn't remove that ability without a plan to replace it. Do we have an idea how frequently users access circuit.data?
The motivation here was to sanitize QuantumCircuits internal data structures so that operations like merging circuits could be more performant, but maybe another approach (like making circuit.data a List subclass that validates/broadcasts when modified) would achieve the same goal.

https://github.com/mtreinish/qiskit-core/compare/deprecate-circuit-data-write...kdk:circuit-data-proxy-poc has some scratch work towards one option for keeping circuit.data as a validating proxy interface for circuit._data.
The goal would be to leave the circuit.data interface unchanged, but add validation so that circuit._data can be assumed to have been validated, so that we can build out a more performant set of circuit manipulation primitives.
Thoughts? What do people prefer? If this seems like a reasonable approach, I'll extend it onto @mtreinish 's PR and add some tests.

A feature in Ignis uses .data() heavily to insert gates into a circuit. Will there be a way to do this if it gets deprecated?
To be specific, it needs to be possible to take a given circuit and create a new circuit which is identical to the old, but with some arbitrary gate inserted at some arbitrary point.

Hi @quantumjim , the title of this issue is somewhat outdated (see the two comments preceding yours, and the PR #2838 ). The current plan is for circuit.data() to remain in place with the same list-like interface, but with changes to circuit.data() being validated to make sure they are of the right Instruction, qargs, cargs format. Existing code should continue to work.
Can you link to the example in ignis that works with .data()? It would be handy to have as a test case.

Thanks!
The relevant part of Ignis is in here: the _make_syndrome_graph() method of GraphDecoder. Any incompatible changes in .data() can be expected to cause this test to fail.


Issue in TotalTemplate When Accessing Date

When trying to access the date in TotalTemplate using @context.Date the value 01/01/0001 is returned instead of that total values set date.

OK, I will fix that.


How to share a window with cmd when call open-wsl ?

Call open-wsl in cmd will launch a seperate window, but WSL stays in the same window.
How can we call open-wsl just like bash without launch a seperate window ?

This is not possible because wsl-terminal starts wsl in mintty which has its own window. What you're looking for is maybe something like:
C:\Users<user>\wsl-terminal\bin\mintty.exe  -i "C:\Users<user>\wsl-terminal\open-wsl.exe" --rootfs=// --configdir "C:\Users\mosky\wsl-terminal\etc"  -t "        " cmd.exe
but then from cmd.exe you'll need to start somehow wsl using wslbridge


Simplify pre-commit scripts.

Caveats may apply.
Notably, this removes support for the path/command flags and requires that the scripts are run from the repository root.
I'm happy to restore support for the path/command flags and permit the commands to work from any directory, but figured I shouldn't complicate these files if that was unused complexity.

FYI, to make CI pass these lines have to be modified to call the renamed formatting scripts:
https://github.com/IntersectMBO/lsm-tree/blob/c361efb779c0dc3c8998f7c0106462353fb012f3/.github/workflows/haskell.yml#L274
https://github.com/IntersectMBO/lsm-tree/blob/c361efb779c0dc3c8998f7c0106462353fb012f3/.github/workflows/haskell.yml#L212

I've back ported some added robustness from a different project that checks for unstaged files and checks for the formatter versions.

Seems like something went wrong when rebasing, GitHub thinks you're adding 39 new commits.


[Project] Fix ToolRunner to check path

Revise ToolRunner to execute tools with full path.

Only one-build and onecc are added to /usr/bin
Other tools are not in PATH

Todo

[ ] check if onecc exist in execution path
[ ] get real path for onecc
[ ] get real path for the tool
[ ] check tool exist as executable

Let's prepare this in #70

Close as codes landed


“You will see your sent and received payments here” is shown  instead of "You will see completed Exchange here" empty message when user went empty “Gold” tab

Frequency: 100%
App version: Integration build v1.5.2 (101548777)
Repro on: Google Pixel XL 2 (9.0), Samsung Galaxy A8+ (8.0.0)
Pre-condition: Make sure users do not have gold activity in “Gold” tab.
Repro Steps:

Launch the app.
Tap on Gold tab.
Observe.

Investigation:

Issue does not repro in iOS.
empty message “You will see your sent and received payments here” is shown on Wallet tab

Current Behavior:  “You will see your sent and received payments here” empty message is shown
Expected Behavior: "You will see completed Exchange here" empty message is shown
Attachment: Android_EmptyMessage.png

Verified with Android build v1.5.2 (101548777) integration build  and found that issue is fixed now as "You will see completed exchanges here" empty message is shown on "Gold Activity" section when it is empty.


Custom function expecting TEXT fails on TEXT field containing only non-letter characters

In the following example, I have a custom function that returns true when two input strings match certain conditions. I create a table of first+last name pairs, and run the query on the table to find people where the names fulfill the function.
The function gets an error "argument must be BLOB or TEXT" when one of the entries in the table has the first name "123". Despite it being a STRING field in the table, it appears that something is converting it to a non-text type.
package main

import (
	"database/sql"
	"fmt"
	sqlite "github.com/mattn/go-sqlite3"
	"log"
	"strings"
)

func init() {
	// Register a custom SQL function to avoid an overly complex query.
	sql.Register("sqlite3_custom", &sqlite.SQLiteDriver{
		ConnectHook: func(conn *sqlite.SQLiteConn) error {
			if err := conn.RegisterFunc("match_reverse", MatchReverse, true); err != nil {
				return err
			}
			return nil
		}})
}

func MatchReverse(a, b string) bool {
	if len(a) != len(b) {
		return false
	}
	a = strings.ToLower(a)
	b = strings.ToLower(b)
	for i := 0; i < len(a); i++ {
		if a[i] != b[len(b)-1-i] {
			return false
		}
	}
	return true
}

func main() {
	db, err := sql.Open("sqlite3_custom", ":memory:")
	if err != nil {
		log.Fatal("Failed to open database:", err)
	}
	defer db.Close()

	_, err = db.Exec("CREATE TABLE Names (first_name STRING, last_name STRING)")
	if err != nil {
		log.Fatal("Failed to create table:", err)
	}
	_, err = db.Exec(`INSERT INTO Names VALUES ("Foo", "Bar"), ("Foo", "Oof"), ("123", "abc")`)
	if err != nil {
		log.Fatal("Failed to insert records:", err)
	}
	rows, err := db.Query("SELECT first_name, last_name FROM Names WHERE match_reverse(first_name, last_name)")
	if err != nil {
		log.Fatal("query error:", err)
	}
	defer rows.Close()
	// Output:
	//   Foo Oof
	//   <exits with:> argument must be BLOB or TEXT
	for rows.Next() {
		var first, last string
		if err := rows.Scan(&first, &last); err != nil {
			log.Fatal(err)
		}
		fmt.Printf("%s %s\n", first, last)
	}
	if err := rows.Err(); err != nil {
		log.Fatal(err)
	}
}

I was able to mitigate the issue with calling the custom function with each field cast to the proper type:
match_reverse(CAST(first_name AS TEXT), CAST(last_name AS TEXT))

Hah, this is just a nooby SQLite error. I just found https://www.sqlite.org/datatype3.html
The "Type Affinity" section explains this. The issue is that when storing elements in the database, "123" is by default stored as INT unless the field it's stored in has a different type defined. My error here was using STRING as the field type rather than TEXT.
It's unfortunate there isn't any warning or error when an invalid type is provided, but switching the database creation to use supported types is working:
	_, err = db.Exec("CREATE TABLE Names (first_name TEXT, last_name TEXT)")


creating unsigned apk using signing credentials.

Why below code is generating production-release-unsigned-signed.apk :
steps:
- uses: actions/checkout@v2
- name: set up JDK 1.8
uses: actions/setup-java@v1
with:
java-version: 1.8
- name: Make gradlew executable
run: chmod +x ./gradlew
# 2
- name: Generate Release APK
run: ./gradlew assembleProductionRelease --stacktrace
# 3
- name: Sign APK
uses: r0adkll/sign-android-release@v1
# ID used to access action output
id: sign_app
with:
releaseDirectory: app/build/outputs/apk/production/release
signingKeyBase64: ${{ secrets.SIGNING_KEY }}
alias: ${{ secrets.ALIAS }}
keyStorePassword: ${{ secrets.KEY_STORE_PASS }}
keyPassword: ${{ secrets.KEY_PASS }}
# 4
- uses: actions/upload-artifact@v2
with:
name: Signed app bundle
path: ${{steps.sign_app.outputs.signedReleaseFile}}

Same thing happening with my workflow also.


Fix issue #507

In Python 3.13 and 3.12.7, the behavior of _parse_optional has changed to return a list of tuples: https://github.com/python/cpython/pull/124631
This change would break the optional argument parsing of this library.
This PR will detect this behavior and return the proper format accordingly.
This PR resolves issue #507.
Cross ref: https://github.com/omni-us/jsonargparse/pull/591#pullrequestreview-2350465411

Awesome. Thanks for the fix!


Update files for duckdb 0.10.x

This PR allows to build duckdb_fdw with duckdb 0.10.0

thanks and please remove duckdb.hpp and duckdb.h first

Hi @alitrack sorry, I do not understand, do you want I delete duckdb.hpp and duckdb.h files? I see this PR already merged.
I have copied them from last source code zip file: libduckdb-linux-amd64

Hi @alitrack I think merging this does duckdb-fdw needs to build with duckdb 0.10.0, I am geting now an error when running the extension with duckdb 0.9.2:
duckdb_fdw.so: undefined symbol: _ZN6duckdb9ErrorData7MessageEv
Maybe we should to have a set of duckdb.hpp and duckdb.h files for old versions and for 0.10.x and use conditional #includes & #defines using a version setting?
What do you think?


Inconsistant API for onEdit

Hi,
Following a discussion with @justinr1234 on Slack, I'd like to point that the onEdit callback on schemas have an inconsistant API with onInsert and onRemove:
onInsert(document, currentUser)
onEdit(modifier, document, currentUser)
onRemove(document, currentUser)

onEdit needs a modifier argument, the issue is that it is the first argument of the callback, and not the last as you would expect. One can easily be tricked by this (starting with me ^^), and think that the onEdit signature is onEdit(document, currentUser, modifier) which is a bit more natural.
Then Mongo will go nut because you added a field at the root of the modifier believing you were working on the document argument. The error message will then be cryptic Mongo error, that is, as any of those lovely Mongo error, hard to debug and completely undocumented in their doc. The issue is easy to fix but hard to find.
So the solutions could be:

change the API. This is breaking and error-prone for people used to Vulcan, so if it has to be done it could wait the 2.0 version maybe
prevent invalid modifier, maybe throwing a warning. Might tedious though and breakable, because Mongo API might evolve.
provide less cryptic error messages. Same as option 2), this might be tedious. I don't know if it's Vulcan job to enhance cryptic Mongo/Meteor errors, that's also a lot of responsibility.
Dismiss the issue, it is not an emergency at all and can be fixed by reading the doc carefully

Maybe a better API would be onEdit({ modifier, document, currentUser })? this way the order wouldn't matter?

Yeah maybe an object as arg would be good. It makes the API a bit heavier but safer, and extensible if you'd like to add other objects to those callbacks like the context.
You can not fully rely on the number of argument, because you'll sometime write onEdit(document) (e.g when you want to create a field that will work as a index from other fields). I guess simply adding a deprecation message e.g onEdit, onInsert, onRemove now expects an object as argument would also help.


New feature for the docs command

When you type in an invalid argument for the docs command and it says "No documentation found for the requested symbol.", it also lists down the closest matches to what you type so you can see what the name of the argument is. Or could take this a step further and make the bot list the closest matches with corresponding number beside it to which the user can write the number/react to the emote showing that number and it would show the docs for that argument

I'm interested in this idea. Does anyone else have thoughts?

I agree, if that's feasible with our current infrastructure let's do this!

In fact, duplicate of #447


Crash

Type: Bug
I opened a js file and received the error that JT service had crashed 5 times
VS Code version: Code 1.82.2 (abd2f3db4bdb28f9e95536dfa84d8479f1eb312d, 2023-09-14T05:55:25.390Z)
OS version: Windows_NT x64 10.0.22000
Modes:
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i9-11900KF @ 3.50GHz (16 x 3504)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.86GB (14.70GB free)

Process Argv
--folder-uri vscode-remote://wsl%2Bubuntu-22.04/home/daz/websites/bondai --crash-reporter-id 1daca597-41a4-4aec-9378-f61e087f2d2b

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu-22.04

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
11th Gen Intel(R) Core(TM) i9-11900KF @ 3.50GHz (16 x 3503)

Memory (System)
15.55GB (13.00GB free)

VM
0%

Extensions (21)

Extension
Author (truncated)
Version

remotehub
Git
0.62.0

remote-containers
ms-
0.315.1

remote-ssh
ms-
0.106.5

remote-ssh-edit
ms-
0.86.0

remote-wsl
ms-
0.81.8

vscode-remote-extensionpack
ms-
0.24.0

azure-repos
ms-
0.38.0

remote-explorer
ms-
0.4.1

remote-repositories
ms-
0.40.0

remote-server
ms-
1.4.3

swdc-vscode
sof
2.7.2

scribeai
And
1.2.1

vscode-tailwindcss
bra
0.10.0

dscodegpt
Dan
2.1.26

gitlens
eam
14.3.0

chatgpt-vscode
gen
0.0.8

rest-client
hum
0.25.1

vscode-docker
ms-
1.26.1

python
ms-
2023.18.0

vscode-pylance
ms-
2023.10.10

vscode-thunder-client
ran
2.13.2

(2 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30856252
vscaac:30438847
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
2e4cg342:30602488
89544117:30613380
a9j8j154:30646983
showlangstatbar:30737416
03d35959:30757346
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxpt:30805730
pythonnoceb:30805159
copilotsettingc:30839828
dsvsc013:30795093
dsvsc014:30804076
diffeditorv2:30821572
dsvsc015:30845448

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.83.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Reason: This command is not enabled for your group (Default).

I cant figure out how to assign users to rolls so they can use the summon/disconnect and other commands.
it always says they are part of (Default)
In my config i see the names of [default] [dj] ect.
i both made rolls on discord called those, and in the line: GrantToRoles =
I put DJ in there as thats my discord roll name. doesnt work
still says they are part of default group.
how do i assign users in my discord a different roll from the default?

You need to use IDs, not names.
Type "!listids" in a channel the bot is in and it will PM a file with all the ID numbers

Exactly what i missed, working now, thanks.


frr: 9.0.2 -> 9.0.3

Currently no published release notes available.
CVEs fixed:

CVE-2024-31948
CVE-2024-31949
CVE-2024-31950
CVE-2024-31951

Some notable fixes:

isisd: fix heap-after-free with prefix sid
ospfd: Solved crash in RI parsing with OSPF TE
ospfd: Correct Opaque LSA Extended parser
ospf6d: Prevent heap-buffer-overflow with unknown type
pimd: fix crash when mixing ssm/any-source joins

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 318758 run on x86_64-linux 1

1 package built:

frr


fix BigTaxi on view, empty join taxis are actually joined to taxi

checking big taxi does not enable user to add more people to taxi
if empty join fields are created they are being added to the taxi as empty

should be fixed with adding validation to the email fields?


boards: nrf5340_audio_dk: Arduino and mcuboot added

Added definitions for Arduino headers and MCUboot button and LED.

@erikrobstad and @gWacey you should be able to post comments, even if not listed in reviewers.

FYI https://github.com/zephyrproject-rtos/zephyr/pull/55675

Closing in favor of #55675.
@koffes please review that one.

Closing in favor of #55675.
@koffes please review that one.
 Added definitions for Arduino headers and MCUboot button and LED.


Index out of range

I installed the latest master and I get the following error when running cppclean:
Traceback (most recent call last):
File "/usr/local/bin/cppclean", line 166, in
sys.exit(main())
File "/usr/local/bin/cppclean", line 139, in main
entire_ast = list([_f for _f in builder.generate() if _f])
File "/usr/local/lib/python2.7/dist-packages/cpp/ast.py", line 675, in generate
result = self._generate_one(token)
File "/usr/local/lib/python2.7/dist-packages/cpp/ast.py", line 753, in _generate_one
return self._get_method(temp_tokens, 0, None, False)
File "/usr/local/lib/python2.7/dist-packages/cpp/ast.py", line 1094, in _get_method
member = member[0]
IndexError: list index out of range

I'm getting this too. Cppclean gets about halfway through the GLM codebase before throwing this error.

I'm seeing this too. I don't know what C++ code causes this to fail. It looks like get_name() can return an empty list so there should probably be a check for it not being empty
https://github.com/myint/cppclean/blob/master/cpp/ast.py#L1097

I am attaching a sample cxx file. This reproduces the bug mentioned in this issue.
file.cxx.log

I had the same problem. Trying to parse this code:
class C {
public:
  C()
  : a(2)
#   pragma warning(disable: 4996) // name has been marked as
  , b(0)
  {}
  int a;
  int b;
};

Throws:
Traceback (most recent call last):
  File "/usr/local/bin/cppclean", line 166, in <module>
    sys.exit(main())
  File "/usr/local/bin/cppclean", line 139, in main
    entire_ast = list([_f for _f in builder.generate() if _f])
  File "/usr/local/lib/python2.7/dist-packages/cpp/ast.py", line 675, in generate
    result = self._generate_one(token)
  File "/usr/local/lib/python2.7/dist-packages/cpp/ast.py", line 702, in _generate_one
    return method()
  File "/usr/local/lib/python2.7/dist-packages/cpp/ast.py", line 1246, in handle_class
    return self._handle_class_and_struct(Class)
  File "/usr/local/lib/python2.7/dist-packages/cpp/ast.py", line 1243, in _handle_class_and_struct
    return self._get_class(class_type, None)
  File "/usr/local/lib/python2.7/dist-packages/cpp/ast.py", line 1558, in _get_class
    body = list(ast.generate())
  File "/usr/local/lib/python2.7/dist-packages/cpp/ast.py", line 675, in generate
    result = self._generate_one(token)
  File "/usr/local/lib/python2.7/dist-packages/cpp/ast.py", line 753, in _generate_one
    return self._get_method(temp_tokens, 0, None, False)
  File "/usr/local/lib/python2.7/dist-packages/cpp/ast.py", line 1098, in _get_method
    member = member[0]
IndexError: list index out of range

Because you only skip those macros in https://github.com/myint/cppclean/blob/master/cpp/ast.py#L1093
# skip preprocesors macros
if token.name.startswith(('#if', '#elif', '#else', '#endif')):
    token = self._get_next_token()
    continue

And than you enter the self.get_name function with 'token_type' of 'PREPROCESSOR' which return an empty list and cabum - you're failing to get the first element and throws IndexError for trying to get index 0.
A fix can be:
# skip preprocesors macros
if token.token_type == tokenize.PREPROCESSOR:
    token = self._get_next_token()
    continue


Generated function has misleading documentation

Imagine a scenario where I have a Cat table with a lives column to count how many lives a particular cat has left.  Here is the generated documentation for the function I need to use:
Documentation
    /**
     * Filter the query on the lives column
     *
     * Example usage:
     * <code>
     * $query->filterByLives(1234); // WHERE lives = 1234
     * $query->filterByLives(array(12, 34)); // WHERE lives IN (12, 34)
     * $query->filterByLives(array('min' => 12)); // WHERE lives > 12
     * </code>
     ...

So if I want to get all cats that have more than 5 lives, the documentation would suggest that I do this:
My code
$cats = CatQuery::create()
                 ->filterByLives(array('min' => 5))
                 ->find();

However, the generated function is using Criteria::GREATER_EQUAL rather than Criteria::GREATER, which means that my code is off by 1
Either the documentaion should be updated here to use >= rather than > or the code itself should change, I'm not sure which is the preferred way.

PR merged


Clang format

Added a formatting job that fails if code is not formatted with clang-format. This will fail now since the code currently is not.
Edit: Never mind, it's actually formatted, my bad. Using the default Travis environment provides clang-format 3.8 which is from 2016. Optionally, one could fetch the latest stable version of clang-format or use Travis's Ubuntu 18.04 environment which should provide clang-format 6.0.0. This would probably require a reformatting of the code in order for that job to be green.
Edit2: In order to do as I've done clang-format version 10.0.0 is needed due that's when --dry-run and --Werror was introduced. Using an older version of clang-format will require some more scripting.

Should the choice to stay on a clang-format version less than 10, one could achieve the same goal of failing non-formatted code by formatting in-place and ask git for changes:
clang-format -i $FILES
git diff-index HEAD --quiet

The second line will produce a non-zero exit code should any files have changed.


Create first Stargate deployment with one replica, before others

What this PR does:
Alternate solution for #297 (vs solution proposed in #298).
This commit modifies the Stargate deployment creation logic so that
the first Stargate deployment always contains one single replica.
Moreover, this commit also modifies the Stargate controller so that
it waits until the first deployment is fully rolled out before
proceeding to creating the following ones.
This eliminates the race condition where many Stargate pods are
created at once, and all of them attempt to modify the schema
concurrently.
Which issue(s) this PR fixes:
Fixes #297
Checklist

[ ] Changes manually tested
[ ] Automated Tests added/updated
[ ] Documentation added/updated
[ ] CHANGELOG.md updated (not required for documentation PRs)
[ ] CLA Signed:  DataStax CLA

My concern with the changes here is that we are introducing complexity where it isn't needed, at least not most of the time. The same can be said for the changes I made in #298. The common and most important use case is Stargate deployed as part of a K8ssandraCluster. In that scenario the schema initialization is not a problem.
What do you think about this. We check to see if the Stargate object is part of a K8ssandraCluster. If it is, proceed with reconciliation as we currently do. If it's not part of a K8ssandraCluster, then before creating any Deployments we perform schema initialization basically like we do in the reconcileStargateAuthSchema method of K8ssandraReconciler. It keeps the schema initialization consistent whether Stargate is deployed as part of a K8ssandraCluster or standalone. With a bit of refactoring, we should be able to avoid a lot of code duplication. Thoughts?

@jsanda I gave it a try here, looks nice indeed: #306.
Now we need to decide which approach to choose :-) With #306 we don't really need #305 and vice versa.

Closing. Superseded by #306 .


Require minimal php version in composer json

Thanks for contributing to Postleaf! 💙💚
Pull Request Summary
Tell us why you’re submitting this PR.
Have you...

[ X] Checked that your code adheres to our code guidelines?

Contributor License Agreement
We want Postleaf to remain free and open for everyone to use forever, so please don’t submit any code or content that is licensed or copyrighted without first getting written consent.
Before we accept your pull request, we ask that you agree to the following terms to ensure there are no conflicts with Postleaf’s license now or in the future.

I certify that the code I am contributing to this project is completely original or free of any known license or copyright.

I agree to allow the developer of Postleaf, A Beautiful Site, LLC, license or relicense my work at their discretion. By submitting this pull request, I agree to forfeit all copyrights, intellectual property rights, and royalties pertaining to my contribution.

By entering my name in the space provided below, I agree to all of the terms mentioned above.

Signed: [Pablo J. Iglesias]
Date: [2016-07-31]

I'm OK with db50968, but most users won't be building — they'll use the dist, so the check in 94bad5f is critical to make sure those users are running a supported version.

Agreed. I have updated the PR to also require the needed PHP extensions. The other PR can be closed

Makes sense to force these checks IMHO


new colo and coloctapp problems with opinion content display rendering

We recently changed the colo scraper, and some newly scraped documents are rendering as raw HTML. I think it's because doctor is tagging them as txt files. I am not sure if this can be fixed on the scraper side,
They look like this, and the opinion backup is on the txt folder

On the other hand, some that have been identified properly as HTML, look strange, 2 which may be fixed using Site.cleanup_content

No PDF option for these new courts.

It was more difficult to get the  opinions as PDFs before, now it seems like a single request. I haven't checked if the PDFs have time related tags or something, though. I have implemented cleanup_content for coloctapp, for now

Now doctor is interpreting the content as "txt", which makes the rendering look bad

@grossir can you push a fix for this - the problem stems from doctor being unable to identify HTML if the HTML tag is not present.  We should simply just wrap the final extracted content inside an HTML tag and that should fix this issue


Re-enable #337

Only #337 as it was removed from #340
By design this PR enabled Installer browser UI via a Flag(opt-in).
It uses the handoff screen to keep the UI servers on, once the user leaves the handoff screen the is closed, the API and UI servers are shotdown.
On silent mode, it is not tested, the idea was to just start and close the servers. But maybe we may have different ideas for it.
How to use it:
./kubefirst cluster create --enable-console

Signed-off-by: 6za<EMAIL_ADDRESS>

This feature is a way to use in experimental mode to test the UI on github/gitlab installs until we work to have console working as designed.

@CristhianF7 I had to disable this on the previous PR, due to lack of consensus. You can use this branch to test create with UI.

As this still experimental, the idea is to have a feature flag to allows developers to explore/sandbox the UI, before we commit with the design.


feat: Create new Fleets for all variants #1090

workflows and templates for downstream repos created from this repo.

** Create new Fleets for all variants #1090 **

Link: https://github.com/NebraLtd/hm-dashboard/issues/1090
Summary: template repository to create openfleet repositories.

How
When one create a new fleet repo as per our nomenclature from this template repository. On create workflow will run and creates its balena.yml and README.md.
It will fetch appropirate docker-compose.yml as well once we have agreed on the filenames for it on helium-miner-software side.
Screenshots

References

Checklist

[ ] Tests added
[ ] Cleaned up commit history (rebase!)
[ ] Documentation added
[ ] Thought about variable and method names

@pritamghanghas Do we need to keep the logic separately in generate_files.py and update_files.sh? I wonder if we can consoldate them into one.

@pritamghanghas Do we need to keep the logic separately in generate_files.py and update_files.sh? I wonder if we can consoldate them into one.

we want to update_files.sh will run as a dispatch helium-miner-software repo. generate_files.py will run only once when master branch is created on repository initialization using this has template repository.


added readme

Description
added readme
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
no test needed

approved


[Bug Report] Test of VOverflowBtn not correct

Versions and Environment
Vuetify: 2.0.0-alpha.10
Vue: 2.6.10
Browsers: Chrome 73.0.3683.75
OS: Windows 10
Steps to reproduce
Pull request #6797 was merged, however an error was introduced: see line 41 of VOverflowBtn.spec.ts in pull request diff.
Expected Behavior
The test "segmented - should warn when item has no callback" should be executed switching from one item with callback to one item without as previously.
Actual Behavior
Both items have no callback and the warning is tipped. However, this is an easier test than when switching between 2 items.
Reproduction Link
https://github.com/borisdayma/vuetify/tree/tests/VOverflowBtn
Other comments
When simply changing back first item to { text: 'Hello', callback: () => {} }, the test does not pass.

I put it in the wrong package. Moved issue to https://github.com/vuetifyjs/vuetify/issues/6810


Misbehaving with GreaseWeazle

Greaseweazle 0.31, using an F4
I've two 5.25" drives connected, a 40track as drive 1, and 80 (1.2mb, jumpered for 300rpm) as drive 0.
fluxengine analyse driveresponse --cylinder 0 --min-interval-us=0 --max-interval-us=30 --interval-step-us=.1 --write-img=driveresponse.png --usb.greaseweazle=COM3 -d drive:1
This is a bit hit and miss, sometimes I just get the drive clicking whilst "Measuring rotational speed", sometimes I get this:
"Measuring rotational speed...
Interval 0.00: failed
Interval 0.08: failed
Interval 0.17: failed
Interval 0.25: failed
Interval 0.33: failed
Interval 0.50: failed
Interval 0.58: failed
Interval 0.67: failed
Interval 0.75: failed
Interval 0.83: failed
Interval 1.00: failed
Interval 1.08: failed
Interval 1.17: failed
Interval 1.25: failed
Interval 1.33: failed
Interval 1.50: failed
Interval 1.58: failed
Interval 1.67: failed
Interval 1.75: failed
Interval 1.83: failed
Interval 2.00: Error: failed to send command: No error"
Once I got: "
Interval 1.75: failed
Interval 1.83: failed
Interval 2.00: failed
Interval 2.08: 8.7368
Interval 2.17: 2.1666
Interval 2.25: 2.2499
Interval 2.33: 2.3333
Interval 2.50: 2.4999
Interval 2.58: 2.5833
Interval 2.67: 2.6667
Interval 2.75: 2.7499
Interval 2.83: 2.8333
Interval 3.00: 3.0001
Interval 3.08: 3.0835
Interval 3.17: 3.1666
Interval 3.25: 3.2498
Interval 3.33: 3.3332
Interval 3.50: Error: GreaseWeazle error: Underflow"
If I try and use drive 0, the activity light goes on but the motor doesn't.

I have an F7 rather than an F4, but it shouldn't make a difference? The last error looks like it's running out of bandwidth, so do make sure it's plugged into a USB 2 port rather than a USB 1 port.
FWIW I do see from the last set of errors that 2.08us pulse intervals are not being reported correctly by the drive (it's getting back 8.7us pulses instead). That probably indicates the minimum pulse width supported by the drive.

No, it shouldn't - actually, mine is an F730 now I look closely :D It's
actually plugged into a USB3 port, so there shouldn't be any issues there.
Any ideas what's going on with drive 0?
I'm happy to debug etc, etc.
On Fri, 3 Dec 2021 at 13:08, David Given @.***> wrote:

I have an F7 rather than an F4, but it shouldn't make a difference? The
last error looks like it's running out of bandwidth, so do make sure it's
plugged into a USB 2 port rather than a USB 1 port.
FWIW I do see from the last set of errors that 2.08us pulse intervals are
not being reported correctly by the drive (it's getting back 8.7us pulses
instead). That probably indicates the minimum pulse width supported by the
drive.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/davidgiven/fluxengine/issues/360#issuecomment-985505171,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATU2PAOK7MSUROAVUURBV3UPC6NFANCNFSM5JJGJCRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

FWIW I can reproduce the driveresponse issue for pulses shorter than 2us on a greaseweazle v4.

Just to be clear, the drives work fine when using GreaseWeazle's own tools?
Also, actually FluxEngine runs out of USB bandwidth writing pulses closer than about 1.8us. (The shorter the pulse intervals, the more data is required.) So there's a hard-coded limit of 2.0us below which it just refuses to do anything. The GreaseWeazle is a USB 3 device and works intermittently down to about 1us, but my drive starts to fail at 1.2us.
I don't have any Victor 9000 disks but I've got an image here which I think has been read in a 300 rpm drive, and the pulse interval of the outer tracks is about 1.45us. I can write that with the GreaseWeazle but it fails miserably on the FluxEngine.

Yes, no problem with the drives at all with the greaseweazle software -
drives 0 and 1 happily co-exist. I've just tried a few different drives, I
can't get below about 2.2us to read reliably with any of my 80 track 5.25s,
which isn't going to be much cop for the victor discs I fear. That's TEACs
and Mitsubishis and NECs... I've got a couple more to try tomorrow.
On Fri, 3 Dec 2021 at 23:32, David Given @.***> wrote:

Just to be clear, the drives work fine when using GreaseWeazle's own tools?
Also, actually FluxEngine runs out of USB bandwidth writing pulses closer
than about 1.8us. (The shorter the pulse intervals, the more data is
required.) So there's a hard-coded limit of 2.0us below which it just
refuses to do anything. The GreaseWeazle is a USB 3 device and works
intermittently down to about 1us, but my drive starts to fail at 1.2us.
I don't have any Victor 9000 disks but I've got an image here which I
think has been read in a 300 rpm drive, and the pulse interval of the outer
tracks is about 1.45us. I can write that with the GreaseWeazle but it fails
miserably on the FluxEngine.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/davidgiven/fluxengine/issues/360#issuecomment-985909755,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATU2PHQX4TGHSA3OAS4KFTUPFHPDANCNFSM5JJGJCRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

What GreaseWeazle firmware do you have, BTW?

0.31 currently
On Fri, 3 Dec 2021, 23:42 David Given, @.***> wrote:

What GreaseWeazle firmware do you have, BTW?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/davidgiven/fluxengine/issues/360#issuecomment-985912996,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATU2PHNSNNR4SVX45VOVT3UPFIWPANCNFSM5JJGJCRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

The Greaseweazle V4 is still only USB 1.1 and I can't get more than about 8Msps of bandwidth out of it, which could be the problem.
(in my case I'm always writing pulses 2us or longer so I've had no problems introduced by this)
You might also want to check the state of pin 2 during writing, it should be high for HD disks.

FWIW, here's what I get on my 1.2MB drive via a GreaseWeazle. You can see the smear in the bottom right from spurious pulses as the interval gets too big, and this really weird repeated pattern on the left when the pulses are too short. The good range seems to be about 1.1us to about 7us.

If it's helpful, I've produced a bunch of frequency responses for all of my floppy drives on hand. These were all produced with the Greaseweazle V4, so none of them go below 2.00us.
https://docs.google.com/spreadsheets/d/1EG5jYsqBiQIu0XConvSuIooGkA_WonFZVIxuY0oHloE/edit#gid=0


fix: cli completion not working

Description
The CLI completion is not working (running Very Good Cli v0.12.2), when running default MacOs Terminal application running on Z shell (zsh 5.8 (x86_64-apple-darwin21.0)). Instead, when using TAB the shell completes with directories at the same level.
File contents
The  .dart-cli-completion directory has two files very_good.zsh and zsh-config.zsh.

 .zshrc partial file content
...
## [Completion]
## Completion scripts setup. Remove the following line to uninstall
[[ -f /Users/alestiago/.dart-cli-completion/zsh-config.zsh ]] && . /Users/alestiago/.dart-cli-completion/zsh-config.zsh || true
## [/Completion]
...

 "dart-cli-completion/very_good.zsh"  file content
if type compdef &>/dev/null; then
  _very_good_completion () {
    local reply
    local si=$IFS

    IFS=$'
' reply=($(COMP_CWORD="$((CURRENT-1))" COMP_LINE="$BUFFER" COMP_POINT="$CURSOR" very_good completion -- "${words[@]}"))
    IFS=$si

    if [[ -z "$reply" ]]; then
        _path_files
    else
        _describe 'values' reply
    fi
  }
  compdef _very_good_completion very_good
fi

 "dart-cli-completion/zsh-config.zsh" file content
if type compdef &>/dev/null; then
  _very_good_completion () {
    local reply
    local si=$IFS

    IFS=$'
' reply=($(COMP_CWORD="$((CURRENT-1))" COMP_LINE="$BUFFER" COMP_POINT="$CURSOR" very_good completion -- "${words[@]}"))
    IFS=$si

    if [[ -z "$reply" ]]; then
        _path_files
    else
        _describe 'values' reply
    fi
  }
  compdef _very_good_completion very_good
fi
alestiago@wireless-student-pt5-181-133 .dart-cli-completion % cat zsh-config.zsh
## [very_good]
## Completion config for "very_good"
[[ -f /Users/alestiago/.dart-cli-completion/very_good.zsh ]] && . /Users/alestiago/.dart-cli-completion/very_good.zsh || true
## [/very_good]

Versioning

Very Good Cli is running v0.12.2
The Terminal application is running Z shell (zsh 5.8 (x86_64-apple-darwin21.0)).
The computer is running macOs Monterey v12.2.1.
The computer is a MacBook Pro (14-inch, 2021) with Apple M1 Pro chip.

Video
https://user-images.githubusercontent.com/44524995/226970516-23a73d90-ecbf-4b57-973c-fe6453a01c5b.mp4

Solution:
Have to add two additional lines into the .zshrc before the completion script:
autoload -U compinit && compinit
setopt menu_complete


Added ExpansionTileController

Supports programmatically expanding or collapsing an ExpansionTile.
Most of the work for this PR was completed by @xvrh in https://github.com/flutter/flutter/pull/107038.
Fixes https://github.com/flutter/flutter/issues/60387
Here's an example:
class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  final ExpansionTileController controller = ExpansionTileController();

  @override
  Widget build(BuildContext context) {
    return Column(
      children: <Widget>[
        ExpansionTile(
          controller: controller,
          title: const Text('Collapsible menu'),
          children: const <Widget>[
            Text('Menu'),
          ],
        ),
        ElevatedButton(
          onPressed: () {
            if (controller.isExpanded) {
              controller.collapse();
            } else {
              controller.expand();
            }
          },
          child: const Text('TOGGLE MENU'),
        )
      ],
    );
  }
}

This PR doesn't include something comparable to ExpansionTile.of(context) from https://github.com/flutter/flutter/pull/107038; I will add ExpansionTileController.of(context).

what about list of ExpansionTile? How to pass different controllers n control expand close for every tile


feat(core): add customizable LoggerContext with labeling support

Fixes #4230

@B4nan I’m having a really difficult time tracking how data passes through the different abstract classes and where the context actually gets passed to logger.logQuery.
The changes to AbstractSqlDriver and QueryBuilder are the changes I think I need to get that data to logQuery, but not sure. I tried to test locally by bringing those changes into a real project but yarn link was seemingly breaking everything due to some strange types issue… I built the project, ran the link command from inside core, made sure all my other dependencies were on 58, and successfully got it linked into my other, but I get weird type errors around Loaded entities:
Types have separate declarations of a private property 'entity'
Any idea what I’m doing wrong there? Any suggestions on the approach?

Will you have time to do the mongo support? We can merge without it too, I'll be happy to do it myself.
Planning to ship v5.7 tomorrow probably, and want to rebase v6 again afterward, so would be good to merge this before instead of battling the rebases again :]

@B4nan sorry for the delay, I went on a mini vacation for the weekend + today; I'll work on it here shortly and/or tomorrow. I might have a question or two about it, but if I do I'll follow up in Slack for expediency!
Re: rebasing; feel free to rebase main, just don't pull it into this branch... when that happens, I'll see the "Update branch" button and know to reset/stash/delete/recreate 😬

@B4nan just added what I think are the only changes needed for Mongo, but I'm not able to test tonight (don't have a quick repo to test against and I'm calling it for the night).
Also I made some pretty substantial changes to the logging docs because I felt they were a little all over the place after adding more so I just reorganized. Hope you like it; if not, let me know and I can revert back to the old structure but with the new content.

Also re: tests, looks like they're all failing due to this error:
[Error: No driver specified, please fill in the `driver` option or use `defineConfig` helper (to define your ORM config) or `MikroORM` class (to call the `init` method) exported from the driver package (e.g. `import { defineConfig } from '@mikro-orm/mysql'; export defineConfig({ ... })`).]
But I didn't change anything related to the CLI 🤔 thoughts?

Test are passing locally again! Should be ready for that through review once you have time 🙂 no rush though!


Resource Template shows info about id

The ResourceTemplate component should display the (label?) and tooltip or something like that (check with Astrid's designs, of course)

No longer necessary, since applies to original BFE.


stream::select_all: replace "use_std" feature check with "std" check

This also moves the select_all fn into select_all.rs,
since that's where it should be (this uses if_std to
check for std, and prevents further issues with
not updating a feature name)
This e.g. leads to hiding this function from the current 0.2.0-alpha doc.

Thanks!


chore: Update pre-commit packages

One suggestion is to perhaps pin the same version of ruff in the github action, so we don't run into this inconsistency again. See bottom of https://github.com/ChartBoost/ruff-action#ruff-action

I assumed we'd want to keep up to date with developments in ruff


StorageReadObjects function optimization

It will be more efficient in terms of performance to access the elements of the slice and put the values instead of appending it after creating the slice.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The allocation was already being done once, so resizing wasn't needed during the loop iterations if that's the concern. Do you have a little benchmark test that compares the two approaches?

I don't know it is the appropriate test but here is my example benchmark code and results:
import (
	"testing"
)

var simpleObjs = []simpleObj{{
	Collection: "Collection-1",
	Key:        "0",
	UserId:     "309adcaf-9d5e-44b6-89f2-7b48e1f9ccab",
},
	{
		Collection: "Collection-2",
		Key:        "0",
		UserId:     "309adcaf-9d5e-44b6-89f2-7b48e1f9ccab",
	},
	{
		Collection: "Collection-3",
		Key:        "0",
		UserId:     "309adcaf-9d5e-44b6-89f2-7b48e1f9ccab",
	}}

func BenchmarkOriginalApproach(b *testing.B) {
	for i := 0; i < b.N; i++ {
		OriginalApproach(simpleObjs)
	}
}

func BenchmarkMyApproach(b *testing.B) {
	for i := 0; i < b.N; i++ {
		MyApproach(simpleObjs)
	}
}

func OriginalApproach(objs []simpleObj) {
	collectionParam := make([]string, 0, len(objs))
	keyParam := make([]string, 0, len(objs))
	userIdParam := make([]string, 0, len(objs))

	for _, s := range objs {
		collectionParam = append(collectionParam, s.Collection)
		keyParam = append(keyParam, s.Key)
		userIdParam = append(userIdParam, s.UserId)
	}
}

func MyApproach(objs []simpleObj) {
	collectionParam := make([]string, len(objs))
	keyParam := make([]string, len(objs))
	userIdParam := make([]string, len(objs))

	for index, s := range objs {
		collectionParam[index] = s.Collection
		keyParam[index] = s.Key
		userIdParam[index] = s.UserId
	}
}

type simpleObj struct {
	Collection string
	Key        string
	UserId     string
}

I don't know if it is worth changing the code, after testing I couldn't decide if it had much of an effect.
BenchmarkOriginalApproach-20            12865542                92.40 ns/op
BenchmarkOriginalApproach-20            12672062                93.03 ns/op
BenchmarkOriginalApproach-20            12060676                92.77 ns/op
BenchmarkOriginalApproach-20            12616186                91.90 ns/op
BenchmarkOriginalApproach-20            12636925                93.12 ns/op
BenchmarkMyApproach-20                  13567692                88.95 ns/op
BenchmarkMyApproach-20                  12824156                88.11 ns/op
BenchmarkMyApproach-20                  13065788                89.47 ns/op
BenchmarkMyApproach-20                  13172916                90.31 ns/op
BenchmarkMyApproach-20                  13523168                90.43 ns/op

@aliciMehmet thank you for providing the benchmarks, we'll close the issue as the difference isn't meaningful.


Audit leveldb removal artifacts

The peer_database.cpp contains this snippet, which is causing a compiler warning for some:
  else
  {
    uint32_t last_database_key;
    //_leveldb.last(last_database_key);
    uint32_t new_database_key = last_database_key + 1;
    potential_peer_database_entry new_database_entry(new_database_key, updatedRecord);
    _potential_peer_set.get<endpoint_index>().insert(new_database_entry);
    //_leveldb.store(new_database_key, updatedRecord);
  }

This should really be an error.  Commit ca89d505 is the culprit.  Someone needs to audit that commit and find the obvious bugs it introduced -- the commit message implies this may not be the only one.

@theoreticalbts I have removed all traces of LevelDB except in the net folder, which I have left to @emfrias who has been making his fixes in the remove_leveldb branch.

My mistake, I thought someone else was merging that branch.  I've merged my changes into master.

https://github.com/cryptonomex/graphene/compare/a0765e2cf2...37cadb2be8