RSS Feed for extensions gallery

It would be great to have a RSS feed for the new extensions added to the gallery.
It might not be related to this repo but I couldn't find a repo for the extension gallery website.

You can get the whole gallery feed as a JSON file from http://vscode.blob.core.windows.net/gallery/index
By adding your processing logic (such as defining the time range), you can filter out the "new extensions" from them and create your own feed.

Ping @hamenon

Noted. Will add it to the backlog, if possible could you add it on our uservoice page as well (https://visualstudio.uservoice.com/forums/331878-visual-studio-marketplace)? It'll help us gauge the interest for the feature from other users as well.

Looks like you beat me to it. When did that user voice show up? Cool!
Separate from this issue, but relevant for future marketplace requests - could you add a link to User Voice somewhere on the Marketplace page? I can't find one today and it would be good to give users a link to navigate to.

I'm going to leave this open on our end but if you stumble across this please go to https://visualstudio.uservoice.com/forums/331878-visual-studio-marketplace/suggestions/17406490-rss-feed-for-extensions-gallery and upvote!

+1
One use-case I have come across goes like this:
I'd like to query what is the latest version of my plug-in from the marketplace, and bump my versions using semantic-release. To do something similar today, I have to also publish my plug-in to npm, and query from there, which doesn't feel right.

I have created a PHP script that takes the JSON available at http://vscode.blob.core.windows.net/gallery/index but I found out that the JSON feed is out dated.
For instance, the MS C# extension is listed at https://marketplace.visualstudio.com/items?itemName=ms-vscode.csharp as version 1.13.1, last update from 11/13/2017, 3:00:42 PM but the JSON feed most recent version is version 1.8.0 from 2017/03/21.
Do you know of a working / up to date feed?

September issue grooming. Closing this issue it is not an issue we can act on in VS Code. To upvote pls see https://github.com/Microsoft/vscode/issues/16441#issuecomment-266525977


[BUG]ERROR: "local variable 'content' referenced before assignment" in src/backend/queue_agent/main.py

What happened:

To Reproduce
Steps to reproduce the behavior:
Attach logs
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

screensnap for the error


pex blocks /op command

when trying to op myself from the console i get the following:
[23:30:52] [Server thread/INFO] [io.github.hsyyid.essentialcmds]: [Server] executed command op backcab
[23:30:52] [Server thread/INFO]: PermissionsEx replaces the server op/deop commands. Use PEX commands to manage permissions instead!
[23:30:52] [Server thread/INFO]: Usage: /op user
please unblock the op command. minecraft requires you to be op and in creative mode in order to use command blocks. with the op command blocked, command blocks cannot be used.

https://github.com/PEXPlugins/PermissionsEx/blob/8bb458873a1f621afe785a6d1851ca551511a75d/permissionsex-sponge/src/main/java/ninja/leaping/permissionsex/sponge/PermissionsExPlugin.java#L187-L200
simply removing those lines wil fix it
and proof that you do in fact need to be op to modify a command block just in case you don't believe me: http://minecraft.gamepedia.com/Command_Block#Modification states "In multiplayer, command blocks can only be edited successfully by operators in creative mode"
FYI, the only reason you should ever prevent a command is if a server owner disables it in a configuration file, it causes problems for part of your plugin (e.x. teleporting out of a minigame), or it is a default minecraft command that you want to do something extra with (in this case the command should still do what it was designed to do, but add extra functionality).

No, the requirement of op status to edit a command block should be considered a Sponge issue. Sponge's permission system is designed to entirely replace the op system, so when PEX (or another permissions plugin) is installed that permissions plugin will be checked instead of the ops list. PEX overrides the MC op command to avoid confusion from users who try to op somebody and have it not work in most cases.
Until sponge is fixed, you can explicitly request the MC op command by using the command /minecraft:op instead.


Serde

To make the lib easier to use, we should provide serde::{Serialize, Deserialize} implementations of all message types.
However, not all consumers may want to use and bring serde dependency in so we should feature gate it.
Do note that if a user do need to be able to send those messages over the wire, they cannot be tagged as pub(crate) (see #25).

Done with #30


activeNavigator does not reset when clicking browser back button

I use the following to get the loading state during the auth.signInRedirect call.
const auth = useAuth()

const loadingText = useMemo(() => {
  switch (auth.activeNavigator) {
    case 'signinRedirect':
    case 'signinSilent':
      return 'Signing you in...'
    case 'signoutSilent':
    case 'signoutRedirect':
      return 'Signing you out...'
    case undefined:
      return undefined
    default:
      return 'Loading...'
  }
}, [auth.activeNavigator])

The problem is that when I press the browser back button the activeNavigator still is signinRedirect. Is this indented?
How do I cope with that?

This issue was made in the wrong repository i guess you meant https://github.com/authts/react-oidc-context


KAFKA-3608: Fix ZooKeeper structures and output format in documentation

We also have https://cwiki.apache.org/confluence/display/KAFKA/Kafka+data+structures+in+Zookeeper, @gwenshap which of the two copies do we want to maintain going forward? The one in the Git repo?

Obviously the one in Git :)
Our structure docs should be versioned with the releases.
Any chance we could auto-generate those too? Maybe @vahidhashemian can do a follow-on? Or @granthenke, since he auto-generated the protocol?

Not sure what is involved in auto-generate. If @granthenke sends me some pointers I can give it a try :)

For now, @vahidhashemian, can you just open a JIRA? Just so we won't lose track of the requirement?

@gwenshap Sure, will do shortly.


Instance: Murat test2

Cloud Computing Instance Flavor
g3.xl - GPU instance (32 CPUs, 125 GB RAM and A100 GPU)
Description
as
ORCID
1234-5678-1234-5678
Email
<EMAIL_ADDRESS>

/create

/delete


Doc: Install Emacs 27 on Windows WSL

Update the installation instructions for installing Emacs on Windows WSL from version 26 to 27, as Emacs 26 will be discontinued.

Not currently accepting PRs to our in-repo docs.


Turning chat into a runnable function

Context
As we move into a more LCEL-y world, we may need a chain for basic chat. This is about the simplest possible chain, so this is more about pre-work for an eventual refactor of core-api than that I think this is a stunning new feature.
Changes proposed in this pull request

Adds a chat LCEL factory and unit test

Guidance to review

Run unit tests, watch 'em pass
Verify you're happy with my implementation

Things to check

[x] I have added any new ENV vars in all deployed environments
[x] I have tested any code added or changed
[x] I have run integration tests

looks good to me


Added min_gap param for segments().

Allows for automatic consolidation of segments with small gaps.

Sorry for not working on your pull request. I'm looking for a new maintainer for Python IntelHex project. I hope someone will help.


support :terminal on Windows

use libvterm on Windows
use winpty to be possible to handle escape sequence
dynamic loading of winpty.dll

Codecov Report

Merging #1854 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1854      +/-   ##
==========================================
+ Coverage   75.08%   75.11%   +0.03%
==========================================
  Files          76       76
  Lines      125150   125190      +40
==========================================
+ Hits        93973    94041      +68
+ Misses      31177    31149      -28

Impacted Files
Coverage Δ

src/channel.c
83.87% <ø> (-0.05%)
:arrow_down:

src/message.c
67.9% <0%> (-0.46%)
:arrow_down:

src/gui.c
45.58% <0%> (ø)
:arrow_up:

src/evalfunc.c
82.43% <0%> (+0.02%)
:arrow_up:

src/undo.c
81.64% <0%> (+0.06%)
:arrow_up:

src/gui_gtk_x11.c
47.54% <0%> (+0.1%)
:arrow_up:

src/ex_cmds.c
77.85% <0%> (+0.14%)
:arrow_up:

src/os_unix.c
57.93% <0%> (+0.14%)
:arrow_up:

src/window.c
81.52% <0%> (+0.23%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58556cd...f27d9c7. Read the comment docs.

Yasuhiro Matsumoto wrote:

use libvterm on Windows
use winpty to be possible to handle escape sequence
dynamic loading of winpty.dll

Thanks for working on this!
Can you please add something to the INSTALL text file about how to get
winpty and make Vim build with it?
Would be nice to reduce code duplication, e.g. setting the job options.
--
% cat /usr/include/sys/errno.h
#define	EPERM		1		/* Operation not permitted /
#define	ENOENT		2		/ No such file or directory /
#define	ESRCH		3		/ No such process /
[...]
#define EMACS		666		/ Too many macros */
%
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

done. please check.

@brammool I could enable colors. Currently, disabled on code. How about this?

Remaining issue is delay of moving cursor. Do you have any idea?

Ah, sorry, maybe few last commit is not merged.

@brammool Could you merge following patch? Some multi-byte characters are not displayed correctly.
diff --git a/src/terminal.c b/src/terminal.c
index df40866ba..bc632e7cb 100644
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -628,9 +628,15 @@ term_update_window(win_T *wp)
 		{
 #if defined(FEAT_MBYTE)
 		    if (enc_utf8 && c >= 0x80)
+		    {
 			ScreenLinesUC[off] = c;
+			ScreenLines[off] = ' ';
+		    }
 		    else
+		    {
 			ScreenLines[off] = c;
+			ScreenLinesUC[off] = NUL;
+		    }
 #else
 		    ScreenLines[off] = c;
 #endif
@@ -642,7 +648,7 @@ term_update_window(win_T *wp)
 		++off;
 		if (cell.width == 2)
 		{
-		    ScreenLines[off] = ' ';
+		    ScreenLines[off] = NUL;
 		    ScreenLinesUC[off] = NUL;
 		    ++pos.col;
 		    ++off;

closed by https://github.com/vim/vim/commit/8f84c3a8666cea04484ec93fa05386bf33f93f5a


source data dictionary and postgres query draft

Draft version of source data structure and create scripts

update the source scripts and postgress table structure


Bump botframework-directlinejs in all packages/samples

Looks like this is missing package-lock.json, causing errors in npm ci in Travis CI.
If you have package-lock.json, please submit along. Otherwise, please do not modify package.json manually, always use either lerna add or npm install for dependency management. And also make sure npm is of latest version so it emit latest format of package-lock.json.

Ah, yeah this isn't ready. The lockfile generation on Mac looks to be doing something different than lockfile generation on Windows and I was inspecting the diff a bit before pushing them up.

Yea, it upset a lot of people when the fix is not in 6.4.1, including me.
As long as we are adding more optional than removing them, I am fine with it. And AFAIK, npm ci is fine with the missing optional too.

closing in lieu of https://github.com/Microsoft/BotFramework-WebChat/pull/1544


Update swiftformat

This updates the validation tooling to use swiftformat 0.52.10 (was 0.48.17).
I'm assuming there is value in updating tooling from time to time. If not, we can just close this PR.
This updated version of swiftformat does drive several formatting changes. The most common is to change, e.g.:
if let thing = thing {
    ...
}

to
if let thing {
    ...

which seems like a nice enough improvement.

Is if let thing available in swift 5.7? I thought it came in 5.9.
MQTTNIO supports the last three minor releases of Swift which include 5.7

Since swiftformat is configured for a particular minimum swift version, I was sort of trusting it to do the right thing in this regard.
The CI build/test with swift 5.7 also works.
So it seems like this is okay.

Of course you're right. Thanks for all the changes.

Thank you for taking the time to review these PR's. I very much appreciate your help!


Explainability

Hello,
Is there any code available for the explainability experiment in Section K in the appendix of your paper https://arxiv.org/pdf/2203.06125.pdf?
Thank you.

Hi, thanks for asking the question. It's a little complicated to release the code and model for interpretation, so I'm sorry that we don't plan to release it. But it should be easy to implement. You can refer to the interpretation script in LM-GVP. The only things you need to do are processing binding site data and using Integrated Gradients, both of which are shown in their script.


Amazon Price Tracker Italian country no price

Describe the bug
Amazon Price Tracker with Italian country doesn't show the price and doesn't send any price update
To Reproduce
Steps to reproduce the behavior:
Put this ASIN for example "B00F19Q7YI" in RSS-Brdige and select Italian country.
Save the Atom feed in any feed aggregator and check the result
Expected behavior
See the price of the items in the feed and receive update when there is a variation
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

FreshRSS in Docker as a Feed server and Reader 5 as FeedRSS client on Mac
FreshRSS directly on Safari Browser

Smartphone (please complete the following information):

iPhone 12 Pro
iOS 14.4
Safari
Reeder 5

Additional context
If I select US country and use an ASIN taken from US website version I can see correctly the price in the feed and receive the updates

I have the same issue. I tried with different Italian ASIN with no price updates.

The same issue happens to me...
Italian country doesn't work...
Could you kindly fix it please?

Ping @captn3m0 as maintainer of this bridge

Thanks for the tag, checking on this.

thank you;)

The same happens to Spain.

is there a way to make it works again?
thanks

able to add in "singapore" - "amazon.sg" in the price tracker?

German doesn't work too...

please reopen the issue is not solved.
Now:

@mada199122 please provide query string

I've used this
https://www.amazon.it/dp/B0738CB5CN/?coliid=ITTF2AX773TAV&colid=9P3BVTFDEQE4&psc=1&ref_=lv_ov_lig_dp_it
thanks

It is working on my Bridge
Please make sure to update your Bridge to this PR: https://github.com/RSS-Bridge/rss-bridge/pull/2194

yes you are true my version was outdate...
thanks
I confirm that know it works fine...

Sorry to bother you again but with this item the bridge return again no price
https://www.amazon.it/Pariani-Cubetti-Arancia-Candita-1000/dp/B078HQ68SQ

It isn't working on my Bridge too...
Please create a new issue, as I can't reopen this one... (Because I didn't close it...)


Implement logging for the server

The bug in https://github.com/stencila/sibyl/issues/14 and future errors can probably be mitigated if we apply server logging. In merry we've had good experiences using Ndjson (newline delimited JSON) through pino.
I propose we use a combination of:

https://github.com/pinojs/pino
https://github.com/yoshuawuyts/log-http
https://github.com/lrlna/pino-colada

Closed by #17


Non existing references are not deleted when creating translation

When creating a translation, nonexisting references are not deleted from an 'Array' type when creating a translation, but are replaced with an 'undefined' item. These should be filtered out instead.

Created an internal ticket


Wrong way to write True

[Enter feedback here]
When using the PS1 script you will find this line here:
True
But this true written with capital T causes to fail the VPN connection import with wrong values
The result is an Automatic VPN type instead of IKEv2 VPN type!
And this finally results VPN not using computer certificates
This also applies to the XML file created!
So in both you need it written this way:
true
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e7453068-95eb-2a42-fd0b-553ae593adb0
Version Independent ID: b39b2cb7-25b1-2af3-4954-dbcc04c836e9
Content: Configure Windows 10 Client Always On VPN Connections
Content Source: WindowsServerDocs/remote/remote-access/vpn/always-on-vpn/deploy/vpn-deploy-client-vpn-connections.md
Service: windows-server-threshold
GitHub Login: @shortpatti
Microsoft Alias: pashort

I talked to the Always On VPN engineer, and he stated that the syntax is lower case 't'.  I will verify with him the correct syntax.

True but be all lower case: 'true.'


Content in meeting view not displayed for OpenSlides 4 on Safari (probably BroadcastChannel issue)

Describe the bug
When opening the a Meeting in OpenSlides 4 with Safari only the side navigation is displayed but the content is empty.
See screenshots.
How to Reproduce
Steps to reproduce the behavior: Not possible on the Demo side, due to the version 3.4.1 (required at least 4)
Setup:
Same as described in OpenSlides Manage Service
$ wget https://github.com/OpenSlides/openslides-manage-service/releases/download/latest/openslides
$ chmod +x openslides
$ ./openslides setup .
$ docker-compose pull
$ docker-compose up -d
$ ./openslides initial-data

Steps after setup:

Open the local OpenSlides 4 setup with Safari
Login as administrator
Create a new Committee
Create a new Meeting for the Committee
Open the newly created Meeting
Now only the side navigation should be visible but no content. If you open the same page with Firefox on e.g. Linux the content is displayed correctly

Expected behavior
The meeting view should show the Welcome page as content and not only the side navigation.
System information

OpenSlides-Version: 4.0
Additional version information (if any): latest docker images used
Python Version: N/A
Device: iPad 9th Generation
OS: iPadOS 15
Browser: Safari
Browser-Version: N/A

Additional context
The console is showing the following error: "ERROR ReferenceError: Can't find variable: BroadcastChannel"
After activating BroadcastChannel API Support in the experimental features of Safari the Meeting side is displayed correctly.
Screenshots
Expected behavior screenshot (Firefox on Linux):

Actual behavior screenshot (Safari):

Actual behavior screenshot (Safari with experimental BroadcastChannel API support on):

Broadcast API now not experimental in Safari anymore, therefore this bug is not present any more


create static maps when importing gpx

Caches being imported from gpx have no static maps. If you are traveling to somewhere without data roaming, the static maps would be quite helpful with imported caches. I just have that situation. :)

Will have a look on this, too.

Set myself as placeholder again.

It is not as easy as it seems because GPXImporter only holds IActivityInstance but StaticMapsProvider needs
Activity to guess the display size. Will dig more into tomorrow,

I think google will set a stop here if this gets to much downloading, so I assume to download for one cache after the other is the better way to go.

I'm using thread pools for such things. But you should keep in mind that a mobile has usually only a singlecore CPU and that there are already some other threads running, so already a lot of context switches. But a pool with only one thread makes sense because for such a simple task like downloading an image the overhead would be really big.
PS: This would be a good solution for the map-issues, too.

This is refactoring for StaticMapsProvider. I will put it into another issue.
For this issue I prefer a serialized download without a thread.
So StaticMapsProvider could offer both, serialized and threaded download.

@SammysHP How would a thread-pool solve our map issues? And which of them?

AFAIK (never looked really deep into the code) we're creating a thread for each request, correct? Creating a new thread takes a few ms and uses a lot of system resources. Also we're starting multiple threads at the same time, e.g. if you move the map again when the first request hasn't finished yet.
Now we use a thread pool with one thread. It's started with the start of the map. Then we have a queue (thread-safe) with a length of 1 (Samuels idea). The thread is notify()-ed, removes the request from the queue and runs it. You can add multiple new request to the queue now (older ones are removed, so that there is only one element), but they are not executed, because the thread is still running.
After finishing the current request we can let the thread wait a few ms (to limit the rate of requests). Then it sees the new element in the queue etc. (normal thread pool behavior).
We can have a look at java.utils.concurrent, because it implements some of the required constructs.

OK, I understand what you mean. This would certainly improve the way threads are handled currently in the live-map code. Even the current code (at least tries to) ensures that there is only one active request at a time but what you sketched would make that much easier. The concurrency issues we face will probably not be solved by such a concept, as they occur due to threads the mapping libraries themselves create for rendering and stuff. Here I got the impression that the API essentially is not designed to be used in the way we do it, especially as the documentation lacks even the slightest hints about how to resolve concurrency concerns.
That said we probably should continue discussion in #437 to not pollute this request with different concerns. :)

Ready now. Tonight I will submit.

Did the merging of pull request #1173 close this issue?

Yes, that happens automatically when you use fix ore fixes with the issue number

Yes, but only without the # ;)

So if I use Fix 285 for the pull request name that would close the issue itself automatically but Fix #285 doesn't?

The title of the pull request is irrelevant. Important is to use Fix, Fixes, Close, Closes in conjunction with #issue numer (e.g. #285) in your commit ,-)

Sorry, you're right - the # is absolutely fine. :D The reason - like blafoo said - is that it must be in the commit message, not in the pull request title.


[BUG]: code in ppo.py always read same datas from prompt_dataloader

🐛 Describe the bug

“ prompts = next(iter(self.prompt_dataloader))”   always read same data from prompt_dataloader. Is it correct?
And what is meaning of "num_episodes" and "max_timesteps"? How to set these two param?
thank you
Environment
No response

@chengeharrison

Hi @lizongzhi Thanks for your feedback, we will fix it later.

This will raise a StopIteration exception. How to set num_episodes and max_timesteps ?

The error lies in  the __len__ fuction in coati/dataset/prompt_dataset.py, a quick fix can be:
    def __len__(self):
        return len(self.keyed_prompt["input_ids"])

We will soon fix this in the main branch.

The error lies in the __len__ fuction in coati/dataset/prompt_dataset.py in line 47, a quick fix can be:
    def __len__(self):
        return len(self.keyed_prompt["input_ids"])

Don't forget to run pip install . when you make changes to coati.
We will soon fix this in the main branch.

it work now. Thank you

🐛 Describe the bug
 “ prompts = next(iter(self.prompt_dataloader))” always read same data from prompt_dataloader. Is it correct?
And what is meaning of "num_episodes" and "max_timesteps"? How to set these two param?
thank you
Environment
No response

Hi, @lizongzhi, here are some explanations.

During one timestep, experience will be made.
When timestep % update_timesteps == 0, the model will learn once.
When timestep reaches max_timesteps, one episode is over.

This training process is similar with that of other RL applications such as training an agent to play games.

In one episode, the agent will have one life.
In each step the agent will choose one action such as attack or something and the system will return a reward (this is "make experience").
When timestep % update_timesteps == 0, the agent will learn to play the game accoding to its experience buffer.
One episode will end if the agent loses its life or it reaches the max timestep.

To set these parameters, I think you should at least let num_episodes * max_timesteps * experience_batch_size >> prompt dataset size and make sure the model is updated at an appropriate frequency (number of updating: num_episodes * max_timesteps / update_timesteps).


fix: update the storage-version-migration script to complete execution in finite time

Changes

hack/storage-version-migration.sh script is mentioned in the install steps. If that script is executed it runs infinitely without reporting any success or failure. This PR adds changes to put checks in hack/storage-version-migration.sh script to give success or failure response and terminate the execution in finite time.
Fixes #1680
-->
Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes

NONE

/retest


added azure open ai settings class with pydantic base class

Motivation and Context

Description

Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
[ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

This looks perfect. The only additional suggestion I'd make is to also modify the .env.example file and add the underscores between AZURE_OPENAI and the remaining parts like:
AZURE_OPENAI_API_KEY --> AZURE_OPENAI__API_KEY (One added underscore).


Please remove "react" etc as npm dependencies

Can you please remove "react" and "react-dom" from the "dependencies" section of package.json?
(but leave them in peerDependencies and devDependencies)
Our app breaks due to there being two versions of react.
Thanks!

done
https://github.com/roadmanfong/react-cropper/commit/a3bb22e924707547ee9914b484fcde35a4ad58c3


Branch 0.6.3

Coverage remained the same at 100.0% when pulling 936a2071551458002eac468601b5a5a7eeea3567 on branch-0.6.3 into 09a751d56218a1d2fca2f4778501214afdf96b43 on master.


lollypop: 0.9.601 -> 0.9.604

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: lollypop
Partial log (click to expand)
Wrapping program /nix/store/jrp3vacfphp0hn3ia6r9nyrsp8i5iy38-lollypop-0.9.604/bin/lollypop
Wrapping program /nix/store/jrp3vacfphp0hn3ia6r9nyrsp8i5iy38-lollypop-0.9.604/libexec/lollypop-sp
shrinking RPATHs of ELF executables and libraries in /nix/store/jrp3vacfphp0hn3ia6r9nyrsp8i5iy38-lollypop-0.9.604
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jrp3vacfphp0hn3ia6r9nyrsp8i5iy38-lollypop-0.9.604/lib  /nix/store/jrp3vacfphp0hn3ia6r9nyrsp8i5iy38-lollypop-0.9.604/libexec  /nix/store/jrp3vacfphp0hn3ia6r9nyrsp8i5iy38-lollypop-0.9.604/bin
patching script interpreter paths in /nix/store/jrp3vacfphp0hn3ia6r9nyrsp8i5iy38-lollypop-0.9.604
checking for references to /build in /nix/store/jrp3vacfphp0hn3ia6r9nyrsp8i5iy38-lollypop-0.9.604...
wrapping `/nix/store/jrp3vacfphp0hn3ia6r9nyrsp8i5iy38-lollypop-0.9.604/bin/.lollypop-wrapped'...
wrapping `/nix/store/jrp3vacfphp0hn3ia6r9nyrsp8i5iy38-lollypop-0.9.604/bin/.lollypop-cli-wrapped'...
/nix/store/jrp3vacfphp0hn3ia6r9nyrsp8i5iy38-lollypop-0.9.604

Success on aarch64-linux (full log)
Attempted: lollypop
Partial log (click to expand)
Wrapping program /nix/store/2gqvph2ks55d5xv8r0v6ax8d20p3h6y6-lollypop-0.9.604/bin/lollypop
Wrapping program /nix/store/2gqvph2ks55d5xv8r0v6ax8d20p3h6y6-lollypop-0.9.604/libexec/lollypop-sp
shrinking RPATHs of ELF executables and libraries in /nix/store/2gqvph2ks55d5xv8r0v6ax8d20p3h6y6-lollypop-0.9.604
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2gqvph2ks55d5xv8r0v6ax8d20p3h6y6-lollypop-0.9.604/lib  /nix/store/2gqvph2ks55d5xv8r0v6ax8d20p3h6y6-lollypop-0.9.604/libexec  /nix/store/2gqvph2ks55d5xv8r0v6ax8d20p3h6y6-lollypop-0.9.604/bin
patching script interpreter paths in /nix/store/2gqvph2ks55d5xv8r0v6ax8d20p3h6y6-lollypop-0.9.604
checking for references to /build in /nix/store/2gqvph2ks55d5xv8r0v6ax8d20p3h6y6-lollypop-0.9.604...
wrapping `/nix/store/2gqvph2ks55d5xv8r0v6ax8d20p3h6y6-lollypop-0.9.604/bin/.lollypop-wrapped'...
wrapping `/nix/store/2gqvph2ks55d5xv8r0v6ax8d20p3h6y6-lollypop-0.9.604/bin/.lollypop-cli-wrapped'...
/nix/store/2gqvph2ks55d5xv8r0v6ax8d20p3h6y6-lollypop-0.9.604


Make it friendly for new go users

Coverage remained the same at 100.0% when pulling 4ff5efdc9d7306835e15ff1ec04af42994f4df2e on build-from-makefile into 697450ec16982e91de6b4ea7e17c6bfcc457282c on master.

Coverage remained the same at 100.0% when pulling eadbcfc85253e37873918201e42481ee70298f5f on build-from-makefile into 697450ec16982e91de6b4ea7e17c6bfcc457282c on master.


highlight and note disappear issue

in any chapter(in any book ) select one verse -> highlight it and on another verse a create a note. then just navigate twice through any random book-chapter ,after that try to access the highlighted verse form the drawer ,one can notice that both highlight and note icon got disappeared .(one can do the same steps and access the created verse, same is the output  i.e the highlight and the note icon got disappeared)
https://user-images.githubusercontent.com/34941343/171046743-728f5bd3-dfa2-4d74-b53b-32215b11ea35.mp4

For notes the issues is fixed but issue with highlights is still exists.
Steps to track the issue :
Bible-->Select one verse from highlight panel-->book change-->select same verse from the highlights --> highlights disappeares.

Testing completed and the issue with Notes , highlights and bookmarks are fixed. As discussed moving this issue to done.


MediaPlayer in PREPARED state when calling pause after setting the speed parameter

Bug

On a Huawei phone running Android Pie, playback of a streaming audio file never starts. This is because of the call to pause after setting the speed parameter is made with the player in the PREPARED state.
https://github.com/react-native-community/react-native-audio-toolkit/blob/master/android/src/main/java/com/reactnativecommunity/rctaudiotoolkit/AudioPlayerModule.java#L358
I can work around it by manually setting speed to null before calling prepare/play which skips setting speed and removes the need to pause.
Worth noting is that it works, without the workaround, on a Pixel 3 Emulator, also running Android Pie.
The log line 2019-06-11 10:57:35.118 14743-14931/com.example.player D/PAUSE: needsToPauseAfterSet in the log below was added by me. State 8 is PREPARED according to https://stackoverflow.com/questions/15589845/android-media-player-pause-called-in-state-8
2019-06-11 10:57:34.467 14743-14931/com.example.player D/AudioPlayerModule: /wp-content/uploads/2017/11/file_example_MP3_700KB.mp3
2019-06-11 10:57:34.468 14743-14931/com.example.player W/MediaPlayer: Couldn't open https://file-examples.com/wp-content/uploads/2017/11/file_example_MP3_700KB.mp3: java.io.FileNotFoundException: No content provider: https://file-examples.com/wp-content/uploads/2017/11/file_example_MP3_700KB.mp3
2019-06-11 10:57:34.469 14743-14931/com.example.player I/MediaPlayerNative: setDataSource(https://file-examples.com/wp-content/uploads/2017/11/file_example_MP3_700KB.mp3)
2019-06-11 10:57:35.107 14743-14931/com.example.player D/MediaPlayerNative: MediaPlayer::setVolume(1.000000, 1.000000)
2019-06-11 10:57:35.108 14743-14931/com.example.player I/PlayerBase: isRestricted: falseLeftvolume: 1.0 Rightvolume: 1.0mPanMultiplierL: 1.0mPanMultiplierR: 1.0
2019-06-11 10:57:35.118 14743-14931/com.example.player D/PAUSE: needsToPauseAfterSet
2019-06-11 10:57:35.118 14743-14931/com.example.player I/MediaPlayer: [HSM] stayAwake false uid: 10340, pid: 14743
2019-06-11 10:57:35.123 14743-14931/com.example.player E/MediaPlayerNative: pause called in state 8, mPlayer(0x7c00fd42c0)
2019-06-11 10:57:35.123 14743-14931/com.example.player D/MediaPlayerNative: Message: MEDIA_ERROR(100), ext1=Unknown MediaErrorType(-38), ext2=0x0
2019-06-11 10:57:35.123 14743-14931/com.example.player E/MediaPlayerNative: error (-38, 0)
2019-06-11 10:57:35.125 14743-14931/com.example.player E/MediaPlayer: Error (-38,0)

Environment info

Huawei P20 Pro CLT-L29
Build number <IP_ADDRESS>0
EMUI version 9.0.0
Android version 9
React native info output:
 React Native Environment Info:
    System:
      OS: macOS High Sierra 10.13.6
      CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
      Memory: 20.10 MB / 16.00 GB
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 10.11.0 - /usr/local/bin/node
      Yarn: 1.3.2 - /usr/local/bin/yarn
      npm: 5.6.0 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
      Android SDK:
        API Levels: 21, 23, 24, 25, 26, 27, 28
        Build Tools: 23.0.1, 24.0.0, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.1, 27.0.3, 28.0.3
        System Images: android-24 | Google Play Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom
    IDEs:
      Android Studio: 3.4 AI-183.54<IP_ADDRESS>52501
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.8.3 => 16.8.3
      react-native: 0.59.5 => 0.59.5
    npmGlobalPackages:
      create-react-native-app: 1.0.0
      react-native-cli: 2.0.1
      react-native-create-library: 3.1.2
      react-native-git-upgrade: 0.2.7
      react-native-swift-cli: 2.3.0

Library version<EMAIL_ADDRESS>Steps To Reproduce

Play a streaming audio file

Describe what you expected to happen:

Audio playback starts

Reproducible sample code

import { Player } from 'react-native-audio-toolkit'
const p = new Player('https://file-examples.com/wp-content/uploads/2017/11/file_example_MP3_700KB.mp3')
p.play(error => console.warn(error))

Thanks for the bug report @othorin.
Does it solve your issue if you change:
            if (needToPauseAfterSet) {
                player.pause();
            }

to:
            if (player.isPlaying() && needToPauseAfterSet) {
                player.pause();
            }

It probably makes the error go away. But since we're setting the playback speed, the player will start playing automatically.
I tried simply commenting out the player.pause() in AudioPlayerModule.java. But then playback started automatically when doing new Player('...').prepare(() => {}).
So I guess we need some sort of delayed pause for when the player starts playing.

While testing my examples and the example you provided, I didn't see any automatic playing when it shouldn't or audio not playing when it should. Does the playback start with your example on your Huawei phone with the above change?

Weird. I really thought so. But testing now, it doesn't start to play after prepare() 👍
I still get the pause called in state 8 when pause() is called in set().
As player.isPlaying() returns true, the code you suggested doesn't make a difference, unfortunately.
Calling player.pause() is equivalent to player.setPlaybackParams(player.getPlaybackParams().setSpeed(0)) according to: https://developer.android.com/reference/android/media/MediaPlayer#setPlaybackParams(android.media.PlaybackParams)
But this actually works and doesn't produce the state error.
if (needToPauseAfterSet) {
    player.setPlaybackParams(player.getPlaybackParams().setSpeed(0));
}

The docs also state that:

The object sets its internal PlaybackParams to the input, except that the object remembers previous speed when input speed is zero

So setting the speed to zero after setting it to any other value would still start playback at the previous value. I verified that it indeed started playback at the custom speed configured.
While trying to reproduce the issue I created a completely blank react native app and only use `react-native-toolkit´ for the example above. It worked as it should.
Maybe my "real" app is busy doing stuff, causing the state to lag behind. But that's just a guess. Worth noting is that it also plays audio from within JNI, potentially disturbing something.
Do you see any issues with using double setPlaybackParams() instead of pause()?

FYI, we just released our app with this updated library to production and are receiving a number of reports from Huawei users claiming that they aren't able to play any audio either. Here's a snippet of our play function.
  /**
   * Handler for the play button.
   * Creates a new audio object if it's not a controllable audio component.
   */
  function play() {
    // The play state should be stopped
    if (!player.current || state !== PlayState.STOPPED) {
      return;
    }

    // Re-initialize player
    if (!player.current.canPrepare) {
      initPlayer();
    }

    dispatch(actions.loading());

    let playTimedOut = false;

    // Wait 7 secs for audio to load
    const playTimeout = setTimeout(() => {
      playTimedOut = true;
      if (player.current) {
        player.current.destroy();
      }
      handlePlaybackError({ err: "stopfail", message: "Stopped", stackTrace: "" });
    }, 7000);

    player.current.play(e => {
      if (playTimedOut) {
        return;
      }
      // Cancel playback timeout
      clearTimeout(playTimeout);

      if (e) {
        handlePlaybackError(e);
        return;
      }
      dispatch(actions.playing());
    });
  }

The docs say about setPlayBackParams: "After the object is prepared, calling it with non-zero speed is equivalent to calling start(). Calling it before the object is prepared does not change the object state."
So, no need to pause if you're not playing. player.isPlaying() && should work perfectly.

I tested it. On a Nexus 5 with Android 6 I always get the reported error with the current lib (it cannot play audio at all). With this solution, I do not:
if (player.isPlaying() && needToPauseAfterSet) {
    player.pause();
}

Fixed an issue with this by instead of calling Stop / Call:
player.pause();
player.seekTo(0);

Also creating a local boolean for isPlaying and acting accordingly. Media player has some sync issues with main thread and when you seek/play or stop a media player that is not playing or already seek at playhead location can cause the whole media player to die


Test adapter not found for >= .net5.0 test containers

Description
Hello,
I'm working on a test adapter for benchmarks that I'm trying to execute using the vstest.console command line with /TestAdapterPath.
The test adapter is discovered for .net461 unit test projects and the tests are correctly ran (don't mind the exception in the logs, that one is in the adapter, on my end)

The test adapter is not discovered for >= .net5.0 test projects and the user receives a warning that no tests are available

Steps to reproduce

Create a TestAdapter project (TFM: netstandard2.0)
Create an MsTest project for that adapter (TFM: net461, any >= net5.0)
Build the projects
open a regular console commands (outside vs env but should be the same)
launch vstest.console from devenv directory with --TestAdapterPath: and the > net461 < unit test project output ====> OK, the test adapter is correctly loaded
launch vstest.console from devenv directory with --TestAdapterPath: and the > net5.0 < unit test project output

Expected behavior
The test adapter is discovered and the RunTests method is called
Actual behavior
The test adapter is not discovered and the RunTests method is not called
Diagnostic logs
log-net7.0-KO.log
log-net461-OK.txt
Environment

I am surprised this works for .net framework with the full path to the adapter, because it should be a directory of where the adapter is placed (not sure why we did not change that), other than that I don't see a reason why it should not work, no errors specific to your adapter in the KO log, it just never tries to load that adapter dll.

Please try providing the adapters path as directory only, not the dll, and let me know if that helped. :)

Hi @nohwnd, thanks for the quick help.
Yes I tried both without success.
From my understanding, the behavior you describe is indeed the default behavior. However, I think the framework is supposed to handle both use cases when the TestAdapterLoadingStrategy is set to Explicit.
From my little investigation, the problem seems to come from the fact that the test runtime provider does not send back the path of the test adapter when sending the TestExecution.Initialize command to the testhost, but I can't even compile the project so I figured it would be quicker to raise an issue
Thanks for the help though, if you have anything else you want me to try just let me know

That was other thing that I was suspecting, but it should send the info eventually.
Easiest way to debug this kind of issue is via the Playground project we have in this repo, you will set values in the EnvironmentVariables.cs and run that project and it should build everything for you, and automatically attach the sub processes to your Visual Studio (if you are using VS for your development).
What problem do you have building this repo? It is because you are using VS 2019 and we require 2022?

@nohwnd, well, Before I gave up I had to:

switch to main branch because the master requires csharp 9
find and disable the analyzers that requires .net 4.8 (I'm on 4.7)
remove the x86/arm dependencies of the Playground project because of a dnxcore50/netcore50 requirement (similar to 4)
I switched back to v17.8.0 and had this error,

Long story short, the rainbow in my console window didn't want to shrink after each each "fix" so I said "not today" :)
I don't doubt it can be done if you really want to, but let's just say it's not the simplest project out there to clone for a quickfix :)

@nohwnd, thanks a lot for that.
Yes it's weird that it went unnoticed for so long indeed. Ok I understand the concern so I will do the necessary modifications on my end then.
This ticket can be closed
Thanks again for the quick help


Draft: Merge in sgemm commits of upstream

Note: I will test this on the cloud system and verify that the upstream commits were merged properly


feat: create table for results

fix https://github.com/aneoconsulting/ArmoniK/issues/597

Wontfix, please refer to #287


A couple of fixes to pyproject.toml

Git dependency is admissible for a development project. Make sure to drop it before any release

Git dependency is admissible for a development project. Make sure to drop it before any release

Yes sure.


Include test case for Cirq v0.6 and v0.7 as well

Context
A test case in test_apply output different messages with Cirq version 0.6 and 0.7.
Description of Change
This PR creates fixtures for these two cases, such that the version number of the Cirq package can remain as is in the requirements.txt file.
It basically includes both the old and new test message from #18 and skips exactly one of them based on the Cirq version.
Benefits
This way, the test suite will pass with both cirq==0.6 and cirq>=0.7.
Drawbacks
Branching off for a test case might be unfavourable.

Nice catch @antalszava! As with the Qiskit case, I would also suggest here supporting only the latest cirq version (0.7). So far, with Cirq so new, there are no use-cases for supporting old versions (this might change in the future, once there is stability in the API/Cirq provides ongoing support for older versions)

Cool, thanks! :) I'll close this one!


Maybe add limiting the number of results to the User example code?

A lot of groups get the logic wrong for limiting the number of responses, often by limiting first and then filtering, which frequently yields fewer results than desired/expected.
We could make this less likely by including an example of limiting in the example User code. That said, they already do a lot of "copy/paste" problem solving in these labs, and I'm not sure we want to give them everything?
Also, we have very few users in this lab, so that kind of limited wouldn't make a lot of sense at the moment. We have a lot more later on in the DB lab (I think?), so we could just copy the larger set of users up to this lab.

We might consider putting some end-to-end tests in this lab that we give them and put them in the actions... and maybe show the students how to run them?

@NicMcPhee - I've given this some further thought, and what about giving a bit more detail in a "spec" written in English that explains that they should filter first and THEN limit, with an explanation/example of why/what it could look like if you don't do things in that order? It's a step between incorporating tests and making an example. It still asks them to do this in a particular order (and can serve as a reminder to those of us grading that we should check that), but it doesn't go so far as to give them something they can copy/paste.


Device's PPI

iOS has no public API for getting the device's PPI.
It seems the only way is to hardcode the values based on the device.

See https://github.com/dennisweissmann/DeviceKit/pull/78

Resolved by #82 :) Thanks again @piterwilson


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_5eh729e07u/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_5eh729e07u/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_5eh729e07u/clone/recipe/meta.yaml:27: python_build_tool_in_run: The python build tool setuptools is in run depends
ERROR: /tmp/abs_5eh729e07u/clone/recipe/meta.yaml:42: missing_dev_url: The recipe is missing a dev_url
WARNING: /tmp/abs_5eh729e07u/clone/recipe/meta.yaml:42: missing_description: The recipe is missing a description
ERROR: /tmp/abs_5eh729e07u/clone/recipe/meta.yaml:42: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_5eh729e07u/clone/recipe/meta.yaml:42: missing_license_family: The recipe is missing the about/license_family key.
Errors were found


./test/term is broken

The double-brackets in Inet-config is a quick fix, which makes it run. But there are also some minor issues:

It looks like a carriage return is missing after printing the banana logo
Typing e.g. Ctrl+c will make the prompt disappear.

This is all very minor but the terminal is so cool it would be nice to get some polish on it :-)

The control-characters are abit more involved to add support for.. At some point, maybe. I fixed the carriage return as it was a modification to the inline multistring.

Cool, so close?

No, I will revisit this later and see if I can't figure out what Ctrl+C actually does in telnet. Just keep in mind it could be a "telnet thing" and could be unrelated to the terminal. We'll see.


BUG: Set the owner property on the queue created using stm manage command to a valid client-username (say default)

Leaving it blank causes issues when you add subscriptions.

Fixed in v0.0.36


Chore/feedback 2 implementation

What does this PR do?
Implements the check point defence feedback
Description of Task to be completed?
N/A
How should this be manually tested?
N/A
Any background context you want to provide?
The model's unit testing has been implemented
What are the relevant pivotal tracker stories?
N/A
Screenshots (if appropriate)
N/A
Questions:
N/A

Coverage decreased (-1.04%) to 87.744% when pulling 324a2c046c7b40142dae2513f15a537cdf42d261 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.9%) to 87.841% when pulling 1be4c4272d0dee3b1d31c0109fd07c18f46defd8 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-1.06%) to 87.722% when pulling 6e7cddd6d9d03215925d2f114f2ba8dee756c416 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.5%) to 88.303% when pulling 3caa3a7f98006ac6e2db8bcdf1d32c8a60761097 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.3%) to 88.468% when pulling 1a2aa2e450cae0eab4c82ea1ec997ff3ac0e7726 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.3%) to 88.468% when pulling 79129772cf8b996aa07a80e60f875fd3da21026c on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.3%) to 88.468% when pulling 7676a88fa4c4564c24385b0911d2179d2ced492b on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.3%) to 88.468% when pulling 9c3e8b104235d1b4f4f2ba40b053221258ba927a on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.3%) to 88.468% when pulling 1bcbbfb342b592e094b77c09ed676cd53ba99f58 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.3%) to 88.468% when pulling 28498b715af05eb948852255ec19ae1d16db41f9 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.3%) to 88.468% when pulling 9fd3d50aeb373cdf887fff708e13554fb6f3fdd4 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.3%) to 88.468% when pulling 9f62ce22d849b1f8b21f596d8233874d0131d1cb on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.3%) to 88.474% when pulling 84e9dcc32e7336abadad0c131eee71d6a76b9139 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.03%) to 88.751% when pulling 4013cd2f7fe0b9cd20b6e61a0fe7e148e692beac on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.6%) to 88.149% when pulling ba9493821974a4610b22119ee247952464ce21df on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.6%) to 88.149% when pulling 275a276faf576dd62ab2285c4d3442f26e309623 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.6%) to 88.149% when pulling cb7be1d63c446dfd0948f1871c8213533e5023b3 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-0.6%) to 88.149% when pulling abbed78f3dc59f1a0ff11d34401c48f636d45732 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-1.3%) to 87.438% when pulling 3833a077aedfe99b01850fc278b4bdc34c8b61b1 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-1.3%) to 87.438% when pulling 3befebb3559fc10cc72a826862ce0a2fe556a01c on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-1.3%) to 87.438% when pulling 5fb468ff1493b42b286c84dc775040aeb39876c8 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-1.3%) to 87.438% when pulling 9d087f26948d44536ee4ef140e285a8d59bcba52 on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-1.3%) to 87.438% when pulling 698aad696606ebf24095b70512ca931c1af7ea3e on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.

Coverage decreased (-1.3%) to 87.438% when pulling e1a9d56a43029b6f34299b98d9d6401e162168bf on chore/feedback-2-implementation into 5ea343f27c5c26d2a6f65d1a8b1860a3d5237eca on develop.


v0.3.13 error win32 x64

:warning:Please attach %TEMP%\vscode-java-installer\log.txt and %TEMP%\vscode-java-installer\AdoptOpenJDK-MSI.log for more details.
version: 0.3.13
env:
JAVA_HOME: undefined
PATH:
C:\Windows\system32
C:\Windows
C:\Windows\System32\Wbem
C:\Windows\System32\WindowsPowerShell\v1.0\
C:\Windows\System32\OpenSSH\
C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common
C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL
C:\Program Files\Intel\Intel(R) Management Engine Components\DAL
C:\Program Files\Intel\WiFi\bin\
C:\Program Files\Common Files\Intel\WirelessCommon\
C:\WINDOWS\system32
C:\WINDOWS
C:\WINDOWS\System32\Wbem
C:\WINDOWS\System32\WindowsPowerShell\v1.0\
C:\WINDOWS\System32\OpenSSH\
C:\Program Files\NVIDIA Corporation\NVIDIA NvDLISR
C:\Program Files\MATLAB\R2020b\bin
C:\Users\mehmet-emre\AppData\Local\Microsoft\WindowsApps
C:\Program Files\Intel\WiFi\bin\
C:\Program Files\Common Files\Intel\WirelessCommon\
JDKs:

log:
[4:37:35 PM] AdoptOpenJDK-11-x64
[4:37:56 PM] Error: EBUSY: resource busy or locked, unlink 'C:\Users\MEHMET~1\AppData\Local\Temp\vscode-java-installer\binaries\jdk\11\x64\OpenJDK11U-jdk_x64_windows_hotspot_11.0.10_9.msi'
[4:37:56 PM] Retry downloading ... [1]
[4:37:57 PM] StatusCodeError: 416 - ""
[4:37:57 PM] Retry downloading ... [2]
[4:37:59 PM] StatusCodeError: 416 - ""
[4:37:59 PM] fallback to Adopt API v3
[4:38:21 PM] Download JDK ... [Completed]
[4:38:21 PM] Install JDK
[4:38:21 PM] Installing AdoptOpenJDK-11-x64...
[4:38:21 PM] Error occurred
[4:38:21 PM] Error: Command failed with exit code 1618: C:\WINDOWS\System32\msiexec.exe /i "C:\Users\MEHMET~1\AppData\Local\Temp\vscode-java-installer\binaries\jdk\11\x64\AdoptOpenJDK-11.msi" MSIINSTALLPERUSER=1 ADDLOCAL=FeatureJavaHome,FeatureEnvironment,FeatureJarFileRunWith /passive /l*v "C:\Users\MEHMET~1\AppData\Local\Temp\vscode-java-installer\AdoptOpenJDK-MSI.log"
Another program is being installed. Please wait until that installation is complete, and then try installing this software again.

Another program is being installed. Please wait until that installation is complete, and then try installing this software again.

You may want to reboot your system to ensure there's no other MSI installer process running. Or you can manually download and install a JDK 11+, e.g. here, and re-run the installer. Let me know if it works.


[WIP] import static cloud information (service)

The PR relates to #147, it is WIP yet!

added draft service data definition (it reflects the currently stored data, no optimisations or other improvements have been done to it)
service and provider related validation has been amended (validation done against data in the store  services also stored in the store)
service related operations have been abstracted from the "infoers", these are handled in the CloudInfo implementation
services are loaded in the store during startup, from a configurable yaml file
introduced the notion of 'static service' -these are excluded from the automatic refresh operation

As per the current status a new 'static service' can be added/imported to a given (supported) provider;
and it's working along with the usual services
TBD:

where to keep the service definition file and the service information data file
how to drive the import (configuration / automatic triggering etc ...)
optimize the data file structure to reduce redundancies (eg.: add flags to entities that are the same between services / regions etc ...)
refine requirements (custom infoer - no cloud provider implied)

changes in this PR have been already merged as


Update toc.yml

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/5708
Updated US in toc

Docs Build status updates of commit dd9635f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@CarolynRowe PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@CarolynRowe PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@CarolynRowe PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


78 responsive

Issue Number
#78
Purpose/Implementation Notes

Adds responsive helper
Adds ResponsiveSheet component for filter menu and nav menu
Adds useResponsive hook to tie into grommets built in responsive hook and provides a function that returns one value when on mobile and another when on desktop
Updates in the styles for responsive home, about, browse, and sample pages

Types of changes

New feature (non-breaking change which adds functionality)

Functional tests
Tested locally
Checklist

[x] Lint and unit tests pass locally with my changes

Screenshots

Pre-commit test will fail here but is fixed in a downstream PR #141


Refactor query language parser

This major refactor does the following:

Moves code into various sub-packages for clarity. We now have:

analysis -> validation and optimization of AST (things like type checking etc.)
ast -> all things AST related
parser -> all things parser
plan -> build all steps to execute the query (doesn't actually execute it though)
scanner -> all things scanner
types -> generic representation of a "Value" so we can actually execute an AST

Implements a static type checker, which validates types for a particular DB and AST
Refactors the Visitor interface to be more flexible, allowing for depth-first, as well as breadth-first traversal
Adds back initial variable declaration to the grammar. In other words, if you want to use data pipelines, it is required to declare the variable ("all x in /foo" etc.)
Rewrites metadata filters to be created using the new Visitor interface, rather than having it be some weird FilterGenerator interface
Moves ASTNodes to explicitly define their fields (rather than the generic Children() method), which improves clarity. Inspired by the go parser.
First whack at a data pipeline which can be executed (not fully implemented yet).

This is work towards #117

Cool output:
> query all in /numbers
+----------------------------------+----------+--------+------+
|               TIME               |  TOPIC   | SCHEMA | DATA |
+----------------------------------+----------+--------+------+
| 2023-01-12T16:17:33.742625-08:00 | /numbers | int32  |    1 |
| 2023-01-12T16:17:35.52783-08:00  | /numbers | int32  |    2 |
| 2023-01-12T16:17:42.102728-08:00 | /numbers | int32  |    3 |
| 2023-01-12T16:17:43.302907-08:00 | /numbers | int32  |    4 |
| 2023-01-12T16:17:44.604381-08:00 | /numbers | int32  |    5 |
| 2023-01-12T16:17:45.751371-08:00 | /numbers | int32  |    6 |
| 2023-01-12T16:17:46.846735-08:00 | /numbers | int32  |    7 |
| 2023-01-12T16:17:48.286286-08:00 | /numbers | int32  |    8 |
| 2023-01-12T16:17:49.504595-08:00 | /numbers | int32  |    9 |
| 2023-01-12T16:17:52.687078-08:00 | /numbers | int32  |   10 |
+----------------------------------+----------+--------+------+

> query all n in /numbers : filter n -> n > 5
+----------------------+-------+--------+------+
|         TIME         | TOPIC | SCHEMA | DATA |
+----------------------+-------+--------+------+
| 0001-01-01T00:00:00Z |       | int64  |    6 |
| 0001-01-01T00:00:00Z |       | int64  |    7 |
| 0001-01-01T00:00:00Z |       | int64  |    8 |
| 0001-01-01T00:00:00Z |       | int64  |    9 |
| 0001-01-01T00:00:00Z |       | int64  |   10 |
+----------------------+-------+--------+------+

(obviously there are still some bugs)

Support for map and arithmetic:
> query all in /sensors/temp
+----------------------------------+----------------------+---------+-----------+
|               TIME               |        TOPIC         | SCHEMA  |   DATA    |
+----------------------------------+----------------------+---------+-----------+
| 2023-01-12T09:21:17.318712-08:00 | /sensors/temp/garage | float64 | 56.300000 |
| 2023-01-12T21:18:47.839436-08:00 | /sensors/temp        | float64 | 60.000000 |
| 2023-01-12T21:18:51.337499-08:00 | /sensors/temp        | float64 | 75.000000 |
| 2023-01-12T21:18:55.281458-08:00 | /sensors/temp        | float64 | 32.000000 |
+----------------------------------+----------------------+---------+-----------+

> query all F in /sensors/temp : map F -> F - 32 : map x -> x * 5 / 9
+----------------------------------+----------------------+---------+-----------+
|               TIME               |        TOPIC         | SCHEMA  |   DATA    |
+----------------------------------+----------------------+---------+-----------+
| 2023-01-12T09:21:17.318712-08:00 | /sensors/temp/garage | float64 | 13.500000 |
| 2023-01-12T21:18:47.839436-08:00 | /sensors/temp        | float64 | 15.555556 |
| 2023-01-12T21:18:51.337499-08:00 | /sensors/temp        | float64 | 23.888889 |
| 2023-01-12T21:18:55.281458-08:00 | /sensors/temp        | float64 |  0.000000 |
+----------------------------------+----------------------+---------+-----------+

Although the above requires two maps because we don't have parenthesis in the grammar.

Count of rows in a database:
> query all x : map x -> 1 : reduce a, b -> a + b
+-------------------------------------+----------------------+--------+------+
|                TIME                 |        TOPIC         | SCHEMA | DATA |
+-------------------------------------+----------------------+--------+------+
| 2023-01-03T21:59:36.312486177-08:00 | /sensors/temp/garage | int64  |   13 |
+-------------------------------------+----------------------+--------+------+


Unable to find blog or user profiles via mas.to or mastodon.social after setup

Quick summary
I'm placing this here because I'm unable to use the support forum due to do being unable to create a new user account while the team is on holiday break. I also feel that the situation is a bug as I've confirmed with the hosting company that there aren't any errors that they can see.
I'm running...
Wordpress Version 6.7.1
ActivityPub Version 4.6.0
Security Optimizer Version 1.5.7
Speed Optimizer Version 7.7.2
WebFinger Version 3.2.7
Speed and Security Optimizers are only installed to turn off all their settings. When I had uninstalled them before it seems there were still settings interfering.
I was receiving an error about not being able to see the profile but that has since disappeared. I now only have an error related to "WebFinger endpoint is not accessible" even though I've installed the plugin. When I expand the drop down it is blank so I can't fix it/get rid of it.
After installing and setting up ActivityPub (I have profiles and blog setting selected) I am unable to find neither when using search in mas.to and mastodon.social (not logged in and logged-in).
I'm still setting up the website so it isn't the end of the world, plus it is the holidays, but I answered the last couple of questions as accurately to the situation as possible.
Thank you and happy holidays if you celebrate this time of year!
Steps to reproduce

Go to mas.to or mastodon.social
Search for<EMAIL_ADDRESS>(user<EMAIL_ADDRESS>(blog), or<EMAIL_ADDRESS>(blog)

What you expected to happen
Should be able to find the profile(s).
What actually happened
Both sites say they can't find anything related to the search.
Impact
All
Available workarounds?
No and the platform is unusable
Logs or notes
No response

I am sorry, but I have bad news for you: siteground blocks the WebFinger path completely, so there is no chance to make this work without their support.
You can find some background infos here: https://wordpress.org/support/topic/doesnt-work-at-all-218/

I will close this for now, because it is no direct issue of the plugin, but you can still comment if you have further questions!

Thank you very much for the information and links! I have reached out to siteground.com and this is there response:
I am afraid the plugin requires a custom modification of the Nginx setup that we cannot accommodate.

The ".well-known" folder is a system folder, and due to security reasons, access to it is limited to specific queries only.

However, as a workaround, you may be able to resolve this issue by manually creating the "webfinger" file inside that folder.

For your convenience, I have manually created the file, which is accessible by the "webfinger" service:

https://webfinger.net/lookup/?resource=https%3A%2F%2Fmadmolelabs.com%2F

Note that you can ignore the JSON warning, which is returned because the file has no data.

You should now save the following JSON code in that file:

{
    "subject"<EMAIL_ADDRESS>    "aliases": [
        "https://madmolelabs.com/author/AUTHOR_USERNAME/"
    ],
    "links": [
        {
            "rel": "self",
            "type": "application/activity+json",
            "href": "https://madmolelabs.com/author/AUTHOR_USERNAME/"
        },
        {
            "rel": "http://webfinger.net/rel/profile-page",
            "type": "text/html",
            "href": "https://madmolelabs.com/author/AUTHOR_USERNAME/"
        }
    ]
}

Where you need to replace "AUTHOR_USERNAME" with your actual username.

I updated the script with TheMadMole for AUTHOR_USERNAME, however, I'm not sure if that is accurate. Can you please confirm if it should just be TheMadMole or perhaps<EMAIL_ADDRESS>Also, after siteground added the file and I added the above script with "TheMadMole" the webfinger error in the Site Health section disappeared.

You should use https://madmolelabs.com/?author=1 instead of https://madmolelabs.com/author/TheMadMole/ but the rest should be fine!

Thank you very much! It worked!


Re-visit the query critical section

See https://github.com/aspnet/EntityFrameworkCore/issues/12615#issuecomment-409060201
Specifically, within the framework of 3.0 query, we should discuss:

What the query critical section contains
Whether the message should be updated
That this will then work with either buffering or MARS
Whether or not this can be made to not require MARS by enabling buffering by default

No need for buffering part for 3.0.


Coordination Services Ensemble not in Config diagram

Thanks for putting in the Cache Servers to the config diagram!  I'm hoping you could do the same with the active coordination service ensemble hosts.  They're available in the config using the same format as cache servers and under the key:
coordinationservice.hosts
Thanks!
-Tony

Hi Tony,
Thank you for the feedback - we added this request to our backlog.


Escaping

Duh addslashes() on everything.

This is far too much work for me to handle by myself :|.


Disable Tampermonkey to access the website.

Disable Tampermonkey to access the website.
It doesn't work

version 0.15.14

It just got patched by musescore devs

fixed in  v0.15.17


Website: Search function/ splash page

Need an initial page that a user can search on that triggers a http GET creating a bokeh serve of the website.

Closing with pull #62


copytools command

first commit on this repo, hope i help!

while this is already a command ":steal", this is better as it doesn't directly "steal" the tools


Could you also please provide test code for us to learn

Hello, could you please provide the test code about how your group gets the result in ACL paper.  We can learn more if the test file and code also provided.

We have uploaded splitData.py and auc.py for evaluation.

where is the splitData.py?


/etc/init.d/slurm restart fails on compute nodes

Launching many nodes (e.g. 15 C4.8xlarge instances) results in nodes taking very long to register with Slurm, and ultimately results in downscaling. Inspecting "sinfo", about 1 node is registered with Slurm every 5-10 minutes. Further, the logic for scaling down the node count checks if nodes were running jobs in the past hour (outlined here: http://cfncluster.readthedocs.io/en/latest/processes.html#sqswatcher). High node count jobs cannot run since there aren't enough nodes in a ready state, therefore the cluster will scale down even though jobs are pending.
There may be a problem with how nodes are registered to Slurm, as registration takes too long. The autoscaling logic needs to be revised since the policies for scaling up and scaling down can result in cyclic scaling behavior. Nodes may not register in time with the scheduler (not necessarily Slurm), resulting in a scale down event. Since jobs cannot run and are therefore pending, scaling up events will follow.
One possible fix for the downscaling behavior would be to only allow downscaling if no jobs are pending. Downscaling can also happen if jobs are pending, but a job can never run due to requiring more nodes than allowed by autoscaling (e.g. the only job in the queue needs 10 nodes, but the max node count is 5).
!jobs_pending || (max_allowed_node_count < min_required_nodes(jobs))

Thanks for the report; this looks like a bug in our integration with SLURM (or possibly a bug in SLURM, still digging).  The SQS messages from the compute nodes starting all show up about 2 minutes after scale-up, which is what you would expect for an instance to boot.  The process that sits on the SQS queue for new instance events then takes 5 minutes to process each message.  It looks like it's running slow because restarting slurm on the compute node is timing out.  If I log into the compute node on my cluster and run /etc/init.d/slurm restart, it takes multiple minutes to fail.  When we fix that, the scale-up times should fix themselves (and get back to the normal slow ramp up / down problems, which usually at least don't cycle, but just go slower than we might like).

Example failure:
root@ip-172-31-60-170:/etc/init.d# time /etc/init.d/slurm restart
[....] Restarting slurm (via systemctl): slurm.serviceJob for slurm.service failed because a timeout was exceeded. See "systemctl status slurm.service" and "journalctl -xe" for details.
 failed!

real	5m0.162s
user	0m0.000s
sys	0m0.004s

It looks like all systemd platforms are impacted (meaning CentOS6 and alinux are not).  The problem is how the sysv autoconversion works in systemd.  It's pulling the last pidfile variable it sees in /etc/init.d/slurm, which is the slurmctld.pid file, which works fine on the master node as it only runs slurmctld but doesn't work on the compute nodes, which only run slurmd and create a slurmd.pid file.  It looks like the best solution is to stop using the sysv compatibility mode, but that means updating the sqswatcher plugin to run the right command when restarting a compute node's slurm daemon.  I think that's ok, because we require compute and master to run the same OS.

@mkuchnik, I can't find any rational reason that we're restarting the compute node slurmd when a node gets added.  While we're finding a couple fixes for systemd issues as part of 1.3.3, a quick fix is to edit the sqswatcher slurm plugin on the master node (/usr/local/lib/python2.7/dist-packages/sqswatcher/plugins/slurm.py) and remove lines 59 - 62.  That will remove the 5 minutes timeout ssh that's causing the slow cluster start.

@bwbarrett For my clarification, are below the steps to fix slow cluster start problem if I have to use slurm?

Use CentOS or alinux
Edit sqswatcher slurm plugin by commenting lines 59-62 of /usr/local/lib/python2.7/dist-packages/sqswatcher/plugins/slurm.py
killall sqswatcher

Sorry, I wasn't clear.  There are three options:

Use Centos6 or alinux (note that Centos7 will also break)
Use a batch scheduler other than SLURM
Edit sqswatcher's slurm.py plugin and restart sqswatcher.

Any of the three will solve the problem (or, since the second isn't an option, either 1 or 3 in your case).
The root issue is that we install SLURM's SysV init script always and systemd's SysV compatibility layer gets the SLURM init script wrong.  So it can't restart processes properly, and times out in 5 minutes instead.  This will happen on any systemd distro (ubuntu1604, CentOS7), but not on SysV or upstart distros (Centos6, alinux).  We'll fix that in CfnCluster 1.3.3, but I can't give a timetable on release yet.

Thanks @bwbarrett. In my case, using centos or alinux is also not an option. I have my AMIs created for ubuntu. I will try 3.
Basic question: How do I restart sqswatcher?
Santi

If you make the change in the ami, then you should be good to go (I'm pretty sure, anyway).  Easiest way to restart sqswatcher is just "killall sqswatcher" as root; there's a nanny that will restart it when it is killed.

@bwbarrett I tried commenting lines 59-62 and restarting sqswatcher. Nodes are added right away. But the ones that are added after the restart are in an unknown state. Is this expected?
Lines commented:
#command = 'sudo sh -c "/etc/init.d/slurm restart 2>&1 > /tmp/slurmdstart.log"'
#stdin, stdout, stderr = ssh.exec_command(command)
#while not stdout.channel.exit_status_ready():
time.sleep(1)
Sinfo output:
PARTITION AVAIL  TIMELIMIT  NODES  STATE NODELIST
compute*     up   infinite      3   unk* ip-172-xx,ip-172-xx,ip-172-xx
compute*     up   infinite      1   idle ip-172-xx

Odd; that wasn't happening to me (they entered "up" state and I could.  It's possible that there's a race I'm just lucking out with which is why the restart was there.  In which case, there aren't a lot of good solutions.  We need to remove the SysV init script and install systemd init scripts instead, but I think you'll end up fighting with Chef recipes if you do that by hand.

I don't want to fight with Chef recipes :). I am building a centos6 AMI. I will update the thread with my findings.

@bwbarrett Building a custom cfncluster centos6 AMI using instructions here worked for me. Addition of instances to slurm was almost immediate.
If your AMI depends on recent versions of gcc/g++ be prepared for several hours of installation and > 20GB EBS storage.

@bwbarrett  I tried centos6 but there are too many libraries that are not easy to install on centos6 compared to ubuntu1604. I would like to use ubuntu1604 instead. Is there a timeline on CfnCluster 1.3.3, where SLURM's SysV init script issue is resolved?

@adavanisanti, unfortunately, we don't have a timeline for when we'll have a fix.  I'm hoping to have a fix for this issue in git this week, but there are other issues we need to address before releasing the next version of CfnCluster.

@bwbarrett Just wondering if the slurm issue is resolved. Is there anything I need to do other than upgrading my cfncluster on my notebook to latest git version?
Thanks
Santi

@adavanisanti
This fix will be available in the next release of cfncluster.
Unfortunately there is no timeline of when that will be released, but we will keep you informed when that is.
Thanks!
Jordan

Thanks @jocherry

@bwbarrett @adavanisanti
Strangely, if you DO NOT comment out the lines in:
/usr/local/lib/python2.7/dist-packages/sqswatcher/plugins/slurm.py
and instead change the line:
command = 'sudo sh -c "/etc/init.d/slurm restart 2>&1 > /tmp/slurmdstart.log"'
to
command = 'sudo sh -c "cd /etc/init.d/; ./slurm restart 2>&1 > /tmp/slurmdstart.log"'
all the compute nodes come up straight away and are in a state on idle and jobs can be submitted.
why running the slurm command using ./slurm from within the directory works and running
/etc/init.d/slurm doesn't I don't know, I did it by accident!
This can be changed in the AMI

@brundle56uk Thanks for the workaround. I will try this out. Which OS version(s) did you test this on?

@adavanisanti I tested this on Centos 7, specifically, I built a cluster on the following custom AMI:
ami-9cb9aef8
this is the Centos 7 AMI for eu-west-2,  full list here:
https://github.com/awslabs/cfncluster/blob/master/amis.txt

https://github.com/awslabs/cfncluster-cookbook/pull/52 and https://github.com/awslabs/cfncluster-node/pull/16
Should take care of this issue.
Closing


Fixed class-becomes-object-nok test. Re #75

When fixing #75, I've forgot to update the class-becomes-object-nok test, which
was affected by the changes made to fix the mentioned ticket.
The reason why the CI didn't fail building #75 is that a fix for #82 was only
merged after having merged #75.

LGTM


MSFT:18139538 Remove the use of Guest Arena from parser code to avoid ScriptContext leak.

MSFT:18171347 Parser's Temporary Guest Arena leaks in case of modules with Regex patterns.

@dotnet-bot test Windows 10 x64_test please


[🐛] Cannot read property 'launchImageLibrary' of undefined react-native-image-picker

Description
Not able to properly use plugin because is throwing error undefined when calling launchCamera or launchImageLibrary
How to repeat issue and example

Added plugin thru yarn add react-native-image-picker
Perfomed pod install @ ios directory
Add configs to Info.plist as described in plugin's docs.
Code written as below

import React from 'react';
import {
    StyleSheet,
    Image,
    TouchableOpacity,
    Alert
} from 'react-native';
import { launchImageLibrary, launchCamera }  from 'react-native-image-picker';

const ImageUpload: React.FC<any> = ({}) => {
    const [response, setResponse] = React.useState(null);

    function showMessage() {
        Alert.alert("Alert", "Choose an option", [
            {
                text: 'Back',
                onPress: () => {},
            },
            {
                text: 'Camera',
                onPress: () => openCamera(),
            },
            {
                text: 'Library',
                onPress: () => openLibrary()
            },
        ]);
    }

    const openLibrary = () => {
        launchImageLibrary(
            {
              mediaType: 'photo',
              includeBase64: false,
              maxHeight: 200,
              maxWidth: 200,
            },
            (response) => {
                console.log(response);
            //   setResponse(response);
            },
          )
    }

    const openCamera = () => {
        launchCamera(
            {
              mediaType: 'photo',
              includeBase64: false,
              maxHeight: 200,
              maxWidth: 200,
            },
            (response) => {
                console.log(response);
            //   setResponse(response);
            },
          )
    }

    return(
        <>
            <TouchableOpacity onPress={()=>showMessage()}>
                <Image source={require('./picture.png')} style={{ width: 70, height: 70 }}/>
            </TouchableOpacity>
        </>
     );
};

const style = StyleSheet.create({
    ImageIcon: {
        justifyContent: "center",
        alignItems: "center",
    }
});

export default ImageUpload;

Solution
Clarification on steps to properly install plugin.
Additional Information

Image Picker version: "react-native-image-picker": "^3.3.4"
React Native version: "react-native": "0.63.2"
Platform: iOS
Development Operating System: Mac OS Catalina
Dev tools: [Xcode 12.1]

Same issue here. I'm using typescript

As with all native modules, after an install, you'll have to rebuild your project (sometimes even restart the packager).
i.e. react-native run-ios or react-native run-android
Alternatively open your project in xcode/android studio and run it from therre.

I dont know why, but on some project, react-native-image-picker does not want to link and need to link it manually.
If you get this error, also try to check if this package is linking in xcode:

If no - link it manually. I add code in Podfile even though I have 0.60.4 react native version on this project.

This answer helped me https://github.com/react-native-image-picker/react-native-image-picker/issues/1627#issuecomment-790801724

I'm running into this error. What is the fix for this for android?

I fixed it by changing the import to import * as ImagePicker from "expo-image-picker";

any news?


sensible-utils: init at 0.0.18

Description of changes
Some packages, like pet and qc depend on "sensible-editor" to select an editor for editing its config file.
This package provides that script via Debian's sensible-utils.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 237715 run on x86_64-linux 1

1 package built:

sensibleUtils

Thanks a lot for your feedback and changes, @SuperSandro2000! I integrated and squashed.

@ofborg build sensibleUtils


[Feature Request]: Parallelize RAPTOR to run for multiple files at 1 go

Is there an existing issue for the same feature request?

[X] I have checked the existing issues.

Is your feature request related to a problem?
No response
Describe the feature you'd like
Currently, RAPTOR is running one by one for each file.
It takes a long time and CPU is still very idle
Below 2 images show bottom half number of files are 50% complete, and still awaiting above file to complete the RAPTOR clustering
RAPTOR for bottom half can already run, and do not need to wait for the file above
image 1

image 2

Describe implementation you've considered
No response
Documentation, adoption, use case
No response
Additional information
No response

The procedure of calling LLM is parallel already.
The parallelity for processing file depends on number of process of the task_executor.


TFRecords with variable length data

Hey Hvass,
I don't know if this is the most proper channel to ask you a question,
but since I'm here I can try it anyway.
In the past 2 weeks, I'm working with tf-records and the tf-estimator & i can definitively feel your pain.
But I've a question which has been bothering me for a few days.
How do you use tf-records whereby you don't know which kind of shape they have?
Okey, creating a tf-record might be a mess, and you can do it in several ways. But as soon as you've a tf-record, it doesn't know which kind of shape it has. And that is a bit problematic when you create your own NN. because the first layer requires somehow a shape.
first_hidden_layer = tf.layers.dense(features['x'], 10, activation=tf.nn.relu)

Tensor("IteratorGetNext:0", shape=(?, ?), dtype=float64, device=/device:CPU:0)
-
ValueError: The last dimension of the inputs to `Dense` should be defined. Found `None`.

And that is a bit ... i think.
Because, i can imagine that you sometimes would like to use variable length arrays  (like when you work with text) .
And I can also imagine that, if i create a tf-record now, then i would like to use that same record also in the future when I've forgotten the shape of that record.
Basically, I, as a person don't want to remember the shape of a tf-record.  or write it down somewhere ... And this for FixedLenght as well as for the Variable Length  tf-records.
Thus the question which I've is, do you've managed to use the tf-records and tf-estimator, together whereby you (act like) you don't know the shape of the tf-record? (with shape --> i mean, amount of features in a record (or pixels, or ...))
because in every single example these values are hard coded,
(even you, use img_size)
therefore, can you help me?

I hope that my question is clear -
-- if you want, i can provide you a notebook --

I only recently started using these and as you can see in the tutorial I am rather displeased with the API and file-format. So I don't know how to solve your problem. Did you ask on StackOverflow?
An idea is to save the shape in the TFRecord as well. In my Tutorial #18 look for this code and then add the shape:
data = \
    {
        'image': wrap_bytes(img_bytes),
        'label': wrap_int64(label)
     }

And then in the parse() function you would get the shape back again and then use it to reshape the arrays.
Would that work?
If you find a solution then please write it here in case other's have the same problem in the future and find this post via google.

I don't think it will work, and I think that i've tried this before, together with the tutorial of "https://www.tensorflow.org/extend/estimators".
The only thing which works, and that is what we are doing now is.... creating a configuration script, which knows all the sizes and types of each record/feature/tensor...  (speaking of records --> e.g. you also have to remember which kind of type something is,  float32,  float64, etc  it doesn't make sense .... )
Nevertheless,
I hope that they change their tf-records  in a next version of tensorflow because, the idea is great, it is much easier to create a network via the estimator, (even though the code can be a mess)

OK, I'm closing this issue. Perhaps you could ask on StackOverflow or TensorFlow's github forum instead? If you find a solution somewhere else, then please provide a link here for people who may have a similar problem and who find this post in the future.


added sdata package

copied sdata package from plugin sdk experimental package.

Maybe dpdata or dpd or something? "sdata" was basically "not data" since the packages are used together. So if you have a better name, while fixing imports, maybe do it in one go?

does framebuilder makes sense here instead dpdata?

While things under (currently sdata) build with paired reading (or help with building and reading) Datatypes (Kind+Formats) defined in dataplane. So the building is only part of it, and frame aspect is more how the data types are encoded and hidden more.

Also we should merge this about the same time as removing sdata so no gaps.


Mask component with unmask-value not allowing removal of last character

Reproduction
https://formkit.link/92f8620e97082596a7ea2c47e81f0e04
Describe the bug
(First off, loving Formkit so far! Thanks for the cracking product.)
To the issue:
When using a mask input with the options in the attached example, removing input from the field results in the final character(s) removed being left in the data.
As a couple of examples:

Enter '123456'
Use backspace to remove all characters
The value remains as '1', the final character deleted

Enter '123456'
Select the text
Delete it (backspace, cut, etc.)
The value remains '123456'

The mask used is a slight adaptation from the example in 'Running the mask in reverse' - in fact, the documented mask has the issue when run with the same options in the playground.
I'd love this to be my fault, so please correct me if you can spot an issue in the playground. I've a feeling it might be a bug in the interplay of the mask and the value's unmasking though?
Worth noting I'm using a schema for my local setup, but I had trouble reproducing that in the playground - both seem to have the issue.
Environment
• OS: Mac OS Monterey 12.6.3
• Browser: Chrome
• Chrome version: 112
• Formkit version: 0.16.4

Thanks for the reproduction. It looks like the issue here is we dont "emit" when the input is fully empty. Even if you remove reverse, remove the repeat, and type in some number 123 and then select all and delete, we leave the value in place.
Good find, we’ll address this 👍
https://formkit.link/4da8f5150ce0b189e42d65c5c3535ed8

Great, thanks @justin-schroeder - appreciate the rapid response. Looking forward to the fix :)

This is now fixed in<EMAIL_ADDRESS>

I spoke to soon

Ok haha. Fixed in<EMAIL_ADDRESS>:)

Brilliant, thanks very much for the speedy patch @justin-schroeder 🙌
(Incidentally, found a hacky fix using prefix: '\u2028',, but am happy I don't need to push that anywhere :D)


Dot commands

Describe the problem you'd like to have solved
it would be nice if we had dot commands similar to SQLite. The purpose of dot commands is to run persistent or session based configuration.
Describe the ideal solution
It can reflect what we have in the config.yml but it can be run override at runtime or be persistent.
once nice command would be .config verbose=true  or .config output.time=true which prints useful information alongside the REPL output.
>> .config verbose=true
>> PING
PONG
elapse: 0.2ms connection: 0.2ms replied: 0.1ms

We can have .whatever
Alternatives and current work-around
None
Additional context
>> .config verbose=true
>> .config verbose
1
>> .config verbose=false
>> .config verbose
0

For example can tell me that verbose can be toggle and viewed.
>> .config verbose=true
>> PING
PONG
elapse: 0.2ms connection: 0.2ms replied: 0.1ms

Example this can show how much the server replied, and show us if it is the server or the client is problem.
>> .log
log.ttrace
>> .log log2.ttrace
>> .log
log2.ttrace

Another example instead of prefixing everything of .config. Here I have override the config but at session level.
>> .max_log_size 1000
You cannot change this configuration at run time. Change it your configuration file instead
>> .max_log_size
10

Here it denied the change to a config
>> .mode
line
>> GET myset mysset
 hello-123456789  hello-1212  hello-123456789  hello-123456789  hello-123456789
>> .mode row
>> GET myset mysset
 hello-123456789
 hello-1212
 hello-123456789
 hello-123456789
 hello-123456789
>> .mode ascii
>> GET myset mysset

+-----------------+
| hello-123456789 |
+-----------------+
| hello-1212      |
+-----------------+
| hello-123456789 |
+-----------------+
| hello-123456789 |
+-----------------+
| hello-123456789 |
+-----------------+
>> .mode box
>> GET myset mysset

┌─────────────────┐
│hello-123456789  │
├─────────────────┤
│hello-1212       │
├─────────────────┤
│hello-123456789  │
├─────────────────┤
│hello-123456789  │
├─────────────────┤
│hello-123456789  │
└─────────────────┘

@eznix86 Should we support this runtime config change also for clients connected to TCP server and talking with TQL, or just in REPL?
I mean they they are commands for TQL and core, or just reply feature?

why not both !

@eznix86 The issue is our current command model is a little complex to support it I think.
Only the change will be applied to the reply if we change the verbose mode. not other type of clients.
Do you have any idea for implementation?
I think we can add a command and simply modify the config struct on database. what do you think?