[bug] "in context" fragment parsing silently degrades functionality when XML errors are encountered

Please describe the bug
A fragment that is parsed "in context" and contains recoverable errors is silently parsed "out of context".
The code at https://github.com/sparklemotion/nokogiri/blob/d852d97de3c4ca356aa45036cc8c77d86d86881d/lib/nokogiri/xml/node.rb#L824-L829 is responsible for this behavior, dating back to a 2010 fix for #313.
The root cause is that libxml2 does not pay attention to the "recover" option when parsing fragments in context via xmlParseInNodeContext.
Help us reproduce what you're seeing
#! /usr/bin/env ruby

require 'nokogiri'

context_xml = "<root xmlns:n='https://example.com/foo'></root>"
context_doc = Nokogiri::XML::Document.parse(context_xml)

valid_xml_fragment = "<n:a><b/></n:a>"
invalid_xml_fragment = "<n:a><b></n:a>" # note missing closing tag for `b`

# valid fragment parses fine
context_doc.root.parse(valid_xml_fragment).tap do |fragment|
  fragment.to_xml # => "<n:a>\n  <b/>\n</n:a>"
  fragment.first.name # => "a"
  fragment.first.namespace # => #<Nokogiri::XML::Namespace:0x3c prefix="n" href="https://example.com/foo">
end

# invalid fragment parses with errors, cannot recover, and is silently parsed out of context leading
# to namespaces not being properly referenced
context_doc.root.parse(invalid_xml_fragment).tap do |fragment|
  fragment.to_xml # => "<a>\n  <b/>\n</a>"
  fragment.first.name # => "a"
  fragment.first.namespace # => nil
end

run with:
# Nokogiri (1.10.10)
    ---
    warnings: []
    nokogiri: 1.10.10
    ruby:
      version: 2.7.0
      platform: x86_64-linux
      description: ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-linux]
      engine: ruby
    libxml:
      binding: extension
      source: packaged
      libxml2_path: "/home/flavorjones/.rvm/gems/ruby-2.7.0/gems/nokogiri-1.10.10/ports/x86_64-pc-linux-gnu/libxml2/2.9.10"
      libxslt_path: "/home/flavorjones/.rvm/gems/ruby-2.7.0/gems/nokogiri-1.10.10/ports/x86_64-pc-linux-gnu/libxslt/1.1.34"
      libxml2_patches:
      - 0001-Revert-Do-not-URI-escape-in-server-side-includes.patch
      - 0002-Remove-script-macro-support.patch
      - 0003-Update-entities-to-remove-handling-of-ssi.patch
      - 0004-libxml2.la-is-in-top_builddir.patch
      - 0005-Fix-infinite-loop-in-xmlStringLenDecodeEntities.patch
      libxslt_patches: []
      compiled: 2.9.10
      loaded: 2.9.10

Expected behavior
I think preferable behavior would be to choose one of:

add an error noting that we "fell back" and pointing the user to turning off the recover option
don't recover, but raise a sensible exception
fix libxml2

Additional context
The behavior described here was introduced in #313.

Side note: on JRuby in-context parsing seems to not work:
#! /usr/bin/env ruby
require 'nokogiri'

context_xml = "<root xmlns:n='https://example.com/foo'></root>"
context_doc = Nokogiri::XML::Document.parse(context_xml)

valid_xml_fragment = "<n:a><b/></n:a>"
invalid_xml_fragment = "<n:a><b></n:a>" # note missing closing tag for `b`

# valid fragment parses fine
context_doc.root.parse(valid_xml_fragment).tap do |fragment|
  fragment.to_xml # => "<n:a><b/></n:a>"
  fragment.first.name # => "a"
  fragment.first.namespace # => nil
end

# invalid fragment parses with errors, cannot recover, and is silently parsed out of context leading
# to namespaces not being properly referenced
context_doc.root.parse(invalid_xml_fragment).tap do |fragment|
  fragment.to_xml # => "<n:a><b/></n:a>"
  fragment.first.name # => "a"
  fragment.first.namespace # => nil
end

run with
# Nokogiri (1.10.10)
    ---
    warnings: []
    nokogiri: 1.10.10
    ruby:
      version: 2.5.7
      platform: java
      description: jruby <IP_ADDRESS> (2.5.7) 2019-10-30 458ad3e OpenJDK 64-Bit Server VM 11.0.8+10-post-Ubuntu-0ubuntu120.04
        on 11.0.8+10-post-Ubuntu-0ubuntu120.04 [linux-x86_64]
      engine: jruby
      jruby: <IP_ADDRESS>
    xerces: Xerces-J 2.12.0
    nekohtml: NekoHTML 1.9.21

This recovery behavior seems to be fixed for HTML4 documents on libxml2 master, but isn't fixed for XML documents. I've inquired about it at (on master) in-context parsing recovery: XML vs HTML (#645) · Issues · GNOME / libxml2 · GitLab

The underlying behavior being worked around will be fixed in libxml 2.13 for both HTML4 and XML, so I'm not going to fix this in Nokogiri.

Tagged for v1.17.0 since that seems to be when we'll ship libxml 2.13.x.


[refactor](refactor field) remove unused method

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.29 seconds
load time: 493 seconds
storage size:<PHONE_NUMBER>5 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230118164735_clickbench_pr_83304.html


Fix retry warning

site-packages/sdcclient/_common.py:11: DeprecationWarning: Using 'method_whitelist' with Retry is deprecated and will be removed in v2.0. Use 'allowed_methods' instead

All is working, thank you for the PR @marojor!


Parse Webhook payload into actual event

Not sure this works, but would it make sense?

Actually it works
@willnorris is that something that could be merged?

Updated, does it make more sens @shurcooL

@gmlewis could you take a look and compare with our internal webhook processing code.  I do like how this reuses the existing logic in Event.Payload.

@willnorris - It is similar to what we use internally, although the main difference is that we map the eventType to a specific handler, and then pass the payload []byte to the handler, which can then choose to use Event.Payload or not.

@gmlewis Updated

A few minor nits - but I like how this turned out.
LGTM after the minor tweaks.

Awaiting LGTM from @shurcooL

Yes, please wait, I'm about to push a new version :-)

@shurcooL updated
A couple of point:

Not sure where you saw WebHook being used rather than Webhook. The existing documentation reads Webhook
I added a ParseWebhookType function. I don't want ParseWebhook() to depend on the request

Hope you like it!

Thanks, I'll be able to review this tonight.

Not sure where you saw WebHook being used rather than Webhook. The existing documentation reads Webhook

I see WebHook used in all the exported types.
See https://godoc.org/github.com/google/go-github/github.

OK Good catch, let me change that now so you can review it tonight.
Thanks

Updated

Updated, I think I've addressed each individual comment. There are no sentence not ending with dots.
Thanks again for your excellent feedback!

Updated :-)

You've addressed all my feedback. Thanks!
I'll let @gmlewis or @willnorris take it from here.

Very nice!  Thank you, @apelisse and @shurcooL !
LGTM. Merging.

Integrated in https://github.com/google/go-github/commit/94a3cd9f531888fe4a03487276c0adb887428e77


Fix exception on multiple AuthenticateAsync calls

Fix for #56, exception on AuthenticateAsync call after previously successful authentication for the same instance of AndroidWebAuthenticationUi.

@VitalyKnyazev,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@VitalyKnyazev, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot


Consolidate expansion I/O into single stackable header in v2

I like that you broke the extra I/O out for expansion. Mechanically though, I'd like to see it consolidated into single stack able header. I'd also switch from through hole to SMD like J45. You could probably route of all the expansion down just below the RPI header.

Possibly. PCB real estate is pretty tight though. If you put another full 0.1" pitch header in there, that would be significant. Anything that stacks needs to fit in a 10mm ish depth, or the thing goes from handheld to laptop.
I do like common interfaces though. SFEs micromod / qwiic are some good examples.


Update gitian build guide to link to Debian 8.0

Have you tested 8.0 to verify that there are no wonky build issues like for ex. the SSL problems we had before?

Closing in favour of https://github.com/bitcoin/bitcoin/pull/6419/files


PYIC-2751 Update the Lambda removing support for API Gateway requests.

Proposed changes
Update the Lambda removing support for API Gateway requests.
What changed
Updated (build-proven-user-identity-details) Lambda to remove support for API Gateway requests.

Why did it change

Issue tracking

PYIC-2751

Checklists
Environment variables or secrets

[ ] No environment variables or secrets were added or changed

[ ] Documented in the README
[ ] Added to deployment repository
[ ] Added to local startup repository

Other considerations

[ ] Update README with any new instructions or tasks

Tested running regression pack against dev stack.


MorphToMany relation not being invalidated

First off, thank you for the package!
I'm not sure if I'm doing this wrong or it's simply not supported but here it is:
Describe the bug
I have a Subscription model that has a morphToMany relation to setting keys (so a many to many polymorphic). The Subscription model is not cacheable and the relation to setting keys looks like this. The Setting model (the pivot) is also not cacheable.
    public function settingKeys(): MorphToMany
    {
        return $this
            ->morphToMany(SettingKey::class, 'settingable', 'settings')
            ->using(Setting::class)
            ->withPivot('value')
            ->withTimestamps();
    }

The SettingKey model on the other hand uses Cachable.
Eloquent Query
This test will fail with Failed asserting that 1 matches expected 0. at the last line:
        ...
        $subscriptionPeriod->settingKeys()->attach($settingKey->id, ['value' => 'something']);

        $this->assertEquals(1, $subscriptionPeriod->settingKeys()->count());

        $subscriptionPeriod->settingKeys()->detach();

        $this->assertEquals(0, $subscriptionPeriod->settingKeys()->count());

This test with disableCache will pass:
        ...
        $subscriptionPeriod->settingKeys()->attach($settingKey->id, ['value' => 'something']);

        $this->assertEquals(1, $subscriptionPeriod->settingKeys()->count());

        $subscriptionPeriod->settingKeys()->detach();

        $this->assertEquals(0, $subscriptionPeriod->settingKeys()->disableCache()->count());

I'm using the array driver for testing. (We do have the file driver in production although it's not officially supported anymore.. I hope to be switching it over to redis soon as we'll need to cache some more things).
Stack Trace
....
Environment

PHP: 7.4
OS: Windows 10
Laravel: 7.28.3
Model Caching: 0.10.2

Same issue with HasManyThrough.
Seems like intermediate model is not supported.
class User extends Model {
    public function comments(): HasManyThrough
    {
        return $this->hasManyThrough(
            Comment::class,
            UsersComment::class,
            'user_id',
            'id',
            'id',
            'comment_id',
        );
    }
}

Comment is cached.
User and  UsersComment - not cached.
Adding new sources to the intermediate table users_comment doesn't invalidate cache for comment
The following will fail at any time, unless I clear the cache manually:
$this->assertEquals($user->comments()->disableCache()->count(), $user->comments()->count());


Visibility - Button Icon

Widget
Visibility
Version of widget
1.0.0
Bug or Enhancement
Change the button
Repo Steps or Enhancement details
There are several icons better suited for visibility than a book, I've circled some suggestions.

I'd say this is Version-Next but not high-priority, based on how easy it is to change.
FYI @nfeuerstein

I have amended the Near Me icon for visibility as per images:

Everybody happy with that?

@adgiles thanks for the new icon. Verified.


Rubocop upgrade

@jamelablack Do you have any interest in continuing on this PR? That benchmark is nice (I would not have guessed that!). I'd be happy to merge if you can wrap it up.

I'm going to close this. @jamelablack if you'd like to continue the PR, let us know, and you can re-open.


Go To Definition

Type: Performance Issue
On right click mouse goto definition is not working on my vs code. My is Already Update
VS Code version: Code 1.88.0 (5c3e652f63e798a5ac2f31ffd0d863669328dc4c, 2024-04-03T13:26:18.741Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz (4 x 2712)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: unavailable_offvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
7.88GB (2.24GB free)

Process Argv
--crash-reporter-id 5196b5b2-b388-4691-bbb0-9af957ba1414

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    3	   114	  2504	code main
    0	    79	  5336	fileWatcher [1]
    1	   346	  6684	window [1] (f5_report.html - PMIS_MPPWD_PIU - Visual Studio Code)
    0	   231	  9720	extensionHost [1]
    0	    94	  2052	     electron-nodejs (server.js )
    0	   111	 12464	     "C:\Users\S\AppData\Local\Programs\Microsoft VS Code\Code.exe" "c:\Users\S\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\html-language-features\server\dist\node\htmlServerMain" --node-ipc --clientProcessId=9720
    0	    95	 14340	     electron-nodejs (serverMain.js )
    8	   106	 10044	window [2] (Issue Reporter)
    2	   180	 11036	   gpu-process
    0	   102	 11096	shared-process
    0	    43	 12948	   utility-network-service
    0	    90	 14108	ptyHost
    0	    74	  5344	     C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -noexit -command "try { . \"c:\Users\S\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\contrib\terminal\browser\media\shellIntegration.ps1\" } catch {}"
    0	     7	 11804	     conpty-agent
    0	    27	 14580	   crashpad-handler

Workspace Info
|  Window (f5_report.html - PMIS_MPPWD_PIU - Visual Studio Code)
|    Folder (PMIS_MPPWD_PIU): more than 20695 files
|      File types: py(4595) pyc(4556) po(1232) mo(1229) json(1201) dat(827)
|                  gz(389) pyi(237) html(206) h(116)
|      Conf files:;

Extensions (37)

Extension
Author (truncated)
Version

aessoft-class-autocomplete
AES
0.1.0

vscode-javascript-snippet-pack
aka
0.1.6

bootstrap5-vscode
Anb
0.4.4

html-class-suggestions
And
1.2.1

django-html
bib
1.3.0

django-snippets
bib
1.1.1

django
big
1.0.2

vscode-standardjs-snippets
cap
0.9.0

vscode-postgres
cko
1.4.3

python-environment-manager
don
1.2.4

python-extension-pack
don
1.7.0

css-flexbox-cheatsheet
dzh
3.3.4

gitlens
eam
14.9.0

vscode-html-css
ecm
2.0.9

vsc-material-theme-icons
equ
3.5.0

auto-rename-tag
for
0.1.10

code-runner
for
0.12.1

remotehub
Git
0.62.0

vscode-pull-request-github
Git
0.86.0

vscode-django-support
jun
1.0.26

vscode-colorize
kam
0.11.1

MagicPython
mag
1.1.0

rainbow-csv
mec
3.11.0

azure-repos
ms-
0.38.0

remote-repositories
ms-
0.40.0

autodocstring
njp
0.6.1

vscode-thunder-client
ran
2.20.3

LiveServer
rit
5.7.9

jinjahtml
sam
0.20.0

django-intellisense
sha
0.0.2

bootstrap5
shr
0.0.9

html-to-css-autocompletion
sol
1.1.2

teamhub
Tea
17.0.4

vscode-djaneiro
the
1.4.2

bootstrap4-vscode
the
6.1.0

vscode-icons
vsc
12.7.0

jinja
who
0.0.8

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
d34g3935:30971562
fegfb526:30981948
bg6jg535:30979843
ccp2r3:30993541
dsvsc020:30976470
pythonait:31006305
gee8j676:31009558
dsvsc021:30996838
g1icg217:30999571

What language is this for?

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

is fake

I am having the same problem as Ranjeetdigimind
Right clicking on a symbol no longer gives an option to Go To Definition or the other cool stuff
Now it just gives very limited list of options that have no value to anyone..
Using

This is the feature that we are referring to (where did it go??)
https://code.visualstudio.com/docs/csharp/navigate-edit << where is this feature in 1.88.# Bring this back please!!!!!
I'm using
Version: 1.88.1 (user setup)
Commit: e170252f762678dec6ca2cc69aba1570769a5d39
Date: 2024-04-10T17:41:02.734Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Windows_NT x64 10.0.19045
Language C# Windows 10 & Unity etc..
Also, Spare us the neckbeard mod BS about old threads covering it or not providing enough info, it's all there...
If you haven't got a solution just Fk off but cheers in advance if you do.

Don’t expect help if you can’t even have a civil conversation (or even file issues correctly)


Form component has of attribute with value of [object Object]

As mentioned in #92. It seems like the prop of is accidentally passed onto a form element and becomes an attribute, from what I can see, it is only used for the inner working of the library.
According to the example playground on stackblitz (with the latest versions of @modular-forms/x), it only affects SolidJS implementation.
I've looked into this a little bit, and it comes from https://github.com/fabian-hiller/modular-forms/blob/cb8f503c7571a6f6ac4656df2adeb048c21db32c/packages/solid/src/components/Form.tsx#L70
We should probably split the props one more time and spread only valid HTML attributes on the form.
If you agree with the proposed solution or propose a better one, I can try to make PR to save you some time on more high-priority issues.

Fixed it. The change will go live with the next version.


october update?

anyone?

?

Updates are posted over here now:
https://github.com/WAZAAAAA0/TekkenBot

Updates are posted over here now:
https://github.com/WAZAAAAA0/TekkenBot

thanks

You're welcome


docs(cook/component-communication): AstronautComponent word typo fix

Changed AstronoutComponent to AstronautComponent.

Thanks

Thanks


Setting refreshEnabled on a RefreshComposite disables all children

Problem description
I want to disable the pull-to-refresh gesture and only show it programatically. In the docs, it says setting refreshEnabled to false disables the gesture. Unfortunately, it also sets enabled to false on all children.

Expected behavior
refreshEnabled should only control the gesture behavior and enabled should control any other interactions.

Environment

Tabris.js version: 3.2.0
Device: Google Pixel 3
OS: Android 10

Code snippet
import {RefreshComposite, TextView, contentView, Button} from 'tabris';

contentView.append(
  <RefreshComposite stretch refreshEnabled={false} onRefresh={handleRefresh}>
    <TextView stretchX top={32} alignment='centerX' font='black 24px'>
      Pull to refresh
    </TextView>
    <TextView id='log' stretchX top='prev() 32' alignment='centerX' lineSpacing={1.4}/>
    <Button text="test" top="prev()" onSelect={() => $(RefreshComposite).only().refreshIndicator = true} enabled={true}/>
  </RefreshComposite>
);

const refreshComposite = $(RefreshComposite).only();
const log = $(TextView).only('#log');

function handleRefresh() {
  setTimeout(() => {
    refreshComposite.refreshIndicator = false;
    log.text = `last refresh: ${new Date()}\n${log.text}`;
  }, 1000);
}

Thank you for the bug report. You are right about your observation. refreshEnabled should only disable the gesture. We will fix the issue for the upcoming 3.3. release.

Issue has been resolved as advertised.


Hooks with type parameters

What Changed
This adds the ability to use Hooks with type parameters. The use case for this is when some piece of data is known only to the consumer of a library and the consumers of the taps, but not necessarily the library itself. As an example:
class FooHooks<T> : Hooks() {
    open val beforeCalc = syncHook<(T) -> Unit>()
}

data class Foo<T>(val t: T)  {
    public val hooks = FooHooksImpl<T>()

    fun calc() {
        hooks.beforeCalc.call(t)
        // ...
    }
}

fun runCalcsWithLog() {
    val f = Foo<String>("hi")
    f.hooks.beforeCalc.tap("hi") { x -> println(x) }
}

Todo:

[x] Add tests
[ ] Add docs
[x] Add release notes

Release Notes
Enhance DSL to adds the ability to generate Hooks with type parameters. The use case for this is when some piece of data is known only to the consumer of a library and the consumers of the taps, but not necessarily the library itself. As an example:
class FooHooks<T> : Hooks() {
    open val beforeCalc = syncHook<(T) -> Unit>()
}

data class Foo<T>(val t: T)  {
    public val hooks = FooHooksImpl<T>()

    fun calc() {
        hooks.beforeCalc.call(t)
        // ...
    }
}

fun runCalcsWithLog() {
    val f = Foo<String>("hi")
    f.hooks.beforeCalc.tap("hi") { x -> println(x) }
}

:rocket: PR was released in v0.9.0 :rocket:


Consider to add additional providers

At the moment this library only uses Google Shared Stuff (S2) to get the favicons, mostly because I found it works better than the alternatives. Need to consider if adding additional providers is useful.
The additional providers which I found are:
http://fvicon.com
http://getfavicon.appspot.com

Isn't necessary.


nixos: unstable fails to load luks encrypted btrfs drive

Summary
After upgrading a fresh nixos install to nixos-unstable from a flake, systemd init fails to detect the btrfs partition after luks decryption
Steps To Reproduce
Steps to reproduce the behavior:

Install nixos via the latest stable installer
Encrypt disk with LUKS, use btrfs for the main partition
Reboot
nixos-rebuild a flake that uses unstable nixpkgs (for example, my flake)
Reboot
System will timeout and fail at stage 1 due to the decrypted partition not being detected

Expected behavior
The btrfs drive should be detected
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I was able to get a working setup using ext4 as an alternative

Add a :+1: reaction to issues you find important.

I think sharing your hardware configuration file may help here.
I am running the same setup (unstable packages and btrfs in a luks container) with no issues.
My hardware-config:
{
imports =
[ (modulesPath + "/installer/scan/not-detected.nix")
];
boot.initrd.availableKernelModules = [ "nvme" "xhci_pci" "ahci" "usbhid" "usb_storage" "sd_mod" ];
boot.initrd.kernelModules = [ "dm-snapshot" ];
boot.kernelModules = [ "kvm-amd" ];
boot.extraModulePackages = [ ];
fileSystems."/" =
{ device = "/dev/mapper/vg--nix-root";
fsType = "btrfs";
options = [ "subvol=root" ];
};
fileSystems."/home" =
{ device = "/dev/mapper/vg--nix-root";
fsType = "btrfs";
options = [ "subvol=home" ];
};
fileSystems."/nix" =
{ device = "/dev/mapper/vg--nix-root";
fsType = "btrfs";
options = [ "subvol=nix" ];
};
fileSystems."/boot" =
{ device = "/dev/nvme0n1p1";
fsType = "vfat";
};
fileSystems."/home/betalars/Data" =
{ device = "/dev/disk/by-uuid/dd7b79f0-12be-405a-aa0e-8e48362ed4f2";
fsType = "ext4";
};
swapDevices =
[ { device = "/dev/mapper/vg--nix-swap"; }
];
Enables DHCP on each ethernet and wireless interface. In case of scripted networking
(the default) this is the recommended approach. When using systemd-networkd it's
still possible to use this option, but it's recommended to use it in conjunction
with explicit per-interface declarations with networking.interfaces.<interface>.useDHCP.
networking.useDHCP = lib.mkDefault true;
networking.interfaces.enp41s0.useDHCP = lib.mkDefault true;
hardware.cpu.amd.updateMicrocode = lib.mkDefault config.hardware.enableRedistributableFirmware;
}

And I also have this line in my configuration.nix:
`boot.initrd.luks.devices."lucks-container".device = "/dev/nvme0n1p2";`

Also the second thing: it is reccomended to use a git repository to keep track of the changes you make to your nix configuration.
Is there maybe something else that has changed in your configuration except for the unstable packages? I really do not see how they would influence the ability to boot your system.

Check out my flake linked in the issue description
I tried both /dev/by-id (nixos default) and /dev/by-label in the hardware config, both failed to come online on unstable but would on stable. Afaik it's preferable to use by id or label to avoid any possible issues with how the kernel mounts the drives (and why nixos has it as the default in the generated hardware config)

Sorry, I did not make the connection that your flake would also include the hardware config.
at this point i unfortunately have to say it works for me and I am in way over my head.

I think I have an idea of where this error comes from, since I had a similar problem, and so I had to change the drive uuid from the one that would be reported reported by mkswap to the one reported by cryptsetup luksUUID /dev/my_encrypted_swap_disk. I'm not an expert, but I believe it has something to do with mkswap being unaware of the disk's encryption scheme, so it give the wrong UUID.


Minor Typographical Fix

Fixes # (provide issue number of applicable)
None
Feature Summary and Justification
Was browsing the code and this struck my eye. Flagged it as insignificant and scrolled past but it kept bugging me. I hope it's not too much of a bother :)
This feature provides ...
a correct spelling
References
None

Thanks a ton. We really appreciate even the smallest fixes to help improve the documentation. 🎆

Least I could do :)


Add picker style options

Add picker style options

Thanks for PR, but it can not be accepted due to completely overridden package.json. However I will implement prop for picker style overrides in next release.


fix: treat watch.ignore correctly

Description
https://github.com/vitejs/vite/blob/eef51cb37db98a1ad9a541bdd3cd74736ff8488d/packages/vite/src/node/server/index.ts#L320-L322
The current codes are only compatible with Array. But it should support something like ignore: /foo/. Details see https://github.com/vitejs/vite/pull/4616#discussion_r689172244.

Additional context

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

move to #4616.


fix(RadioGroup): Centre radio button dots in Safari, fixes #60

Issue #, if available:
#60
Description of changes:
Fixes the radio button dot alignment in Safari.
Before:

After:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

:tada: This PR is included in version 1.0.31 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Investigate why filters_test is flaky

Per https://github.com/tensorflow/addons/pull/796 we would like to resolve why this test is flaky and remove the need for this.
Example log:
https://source.cloud.google.com/results/invocations/d1ca38c5-6236-49f1-bdf7-8e1874e6f9ca/targets/tensorflow_addons%2Fubuntu%2Fgpu%2Fpy2%2Fpresubmit/log

cc @Mainak431 as code owner

Tests are no longer marked flaky. Most likely fixed by moving to fully eager testing, but it's difficult to parse from the history.
Closing.


GPU Support Needs Clarifying

It's not clear in the docs whether some recent but not cutting-edge cards, such as my R9 390, can use RocM. The docs. make it unclear whether the cards simply don't work, or if they just don't play well with the CPU/one-another.
I'm currently trying to use ROCm and hipCaffe, and anything CL-related, even clinfo, seems to freeze early and occupy a full CPU core but negligible RAM until killed. I don't know if this is because my hardware isn't supported, or if I'm missing some key component (e.g., I uninstalled AMDGPU-pro, did I need to reinstall another OpenCL driver, or did that come with the ROCm package?).
Could do with some clarification, and I'd appreciate some quick answers also.

Sorry, that wasn't clear; I uninstalled AMDGPU-pro when installing ROCm. Should I take your message to mean that ROCm does include an OpenCL-compatible driver? So, that's not my problem.
Should ROCm work with an R9 390? I bought the card to do deep learning on, based on early support in Torch7 and Caffe. I'd love to use the hipCaffe stack, because compared to Tensorflow it uses less proprietary garbage, and compared to Torch7 it's not Lua. :)

Let me check the status on R390 and ROCm 1.5,   We test locally  W9100, S9150, S9170 sine we had  a  lot of them available from my previous program.  They are Hawaii based as well.
OpenCL is supported on ROCm,   we even released the source code for it this last week.   Fulfilling our promise on opening up all components in our stack.  It is compatible with OpenCL 1.2 but has OpenCL 2.0 kernel language support as well.
Post ROCm install to get OpenCL on the system you need use this command
sudo apt-get install rocm-opencl-dev
On May 17, 2017, at 8:07 AM, Cathal Garvey <notifications<EMAIL_ADDRESS>wrote:
Sorry, that wasn't clear; I uninstalled AMDGPU-pro when installing ROCm. Should I take your message to mean that ROCm does include an OpenCL-compatible driver? So, that's not my problem.
Should ROCm work with an R9 390? I bought the card to do deep learning on, based on early support in Torch7 and Caffe. I'd love to use the hipCaffe stack, because compared to Tensorflow it uses less proprietary garbage, and compared to Torch7 it's not Lua. :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/RadeonOpenCompute/ROCm/issues/123#issuecomment-302084220, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD8DudfxrF7V5aQRDNbEGQ3ZzaxGbKqQks5r6vD3gaJpZM4Nd0EZ.

Let me check the status on R390 and ROCm 1.5

Thanks a million @gstoner!

Post ROCm install to get OpenCL on the system you need use
this command
sudo apt-get install rocm-opencl-dev

Have done, but with no success.
I may try booting from a persistent live USB or something, and will attempt a clean install on an unaltered Ubuntu 16.04. That would rule out difficulties with a pre-existing CL platform.
I did just discover that I was using the clinfo binary previously installed by whatever OpenCL procedure I followed with AMDGPU-pro. I ran the clinfo that came with ROCm, and got this result:
cathal@thinkum:~/Projects/scrapers/altreich/misesorg$ /opt/rocm/opencl/bin/x86_64/clinfo -v
terminate called after throwing an instance of 'cl::Error'
  what():  clGetPlatformIDs
Aborted (core dumped)

Did this work
cd /opt/rocm/hsa/sample make ./vector_copy
On May 17, 2017, at 3:01 PM, Cathal Garvey <notifications<EMAIL_ADDRESS>wrote:
Let me check the status on R390 and ROCm 1.5
Thanks a million @gstonerhttps://github.com/gstoner!
Post ROCm install to get OpenCL on the system you need use
this command
sudo apt-get install rocm-opencl-dev
Have done, but with no success.
I may try booting from a persistent live USB or something, and will attempt a clean install on an unaltered Ubuntu 16.04. That would rule out difficulties with a pre-existing CL platform.
I did just discover that I was using the clinfo binary previously installed by whatever OpenCL procedure I followed with AMDGPU-pro. I ran the clinfo that came with ROCm, and got this result:
cathal@thinkum:~/Projects/scrapers/altreich/misesorg$ /opt/rocm/opencl/bin/x86_64/clinfo -v
terminate called after throwing an instance of 'cl::Error'
what():  clGetPlatformIDs
Aborted (core dumped)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/RadeonOpenCompute/ROCm/issues/123#issuecomment-302215382, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD8DuSRcAvVIshULmoQaHNrPzU-RyfU7ks5r61IdgaJpZM4Nd0EZ.

I tried that first, per the instructions for installing hipCaffe. Like
all other OpenCL-related things since installing ROCm, it freezes at
100% CPU use when trying to get a context, and doesn't crash, or
proceed, until killed.
If I try too many times (not sure what's the limit here) to launch an
OpenCL thing or things, then the output from vector_copy changes;
instead of putting out a few lines on its progress and then hanging, it
simply reports "Initializing the hsa runtime failed." and exits cleanly.

Could you do a uname -a make sure the correct kernel is loaded?  You should see compute-rocm-rel-1.5 in the name.  I'd also suggest trying /opt/rocm/bin/rocm-smi -a and see if the tool sees the GPU.

$ uname -a
Linux thinkum 4.9.0-kfd-compute-rocm-rel-1.5-80 #1 SMP Fri May 12
16:10:01 CDT 2017 x86_64 x86_64 x86_64 GNU/Linux

$ /opt/rocm/bin/rocm-smi
===================   ROCm System Management Interface
===================
===================          End of ROCm SMI Log
===================

(Though bear in mind in the second case; for some reason the HIP system
fails after a few tries, and right now it's failed. Possibly after a
restart the rocm-smi command would work?)
I'm just working on setting up a LiveUSB Ubuntu that I can try a clean
install on. It's taking longer than expected, sorry.

It looks like you didn't pass the -a switch to rocm-smi :)
I'd suggest that you start with /opt/rocm/hsa/sample/vector_copy first to make sure it works reliably.
For HIP/HCC, since the compiler generates ISA code for Fiji by default, you'll have to re-compile your programs with specifying the architecture for Hawaii (i.e. R390).
You could override the default architecture for your card by doing
export HCC_AMDGPU_TARGET=gfx701
more details:  https://github.com/RadeonOpenCompute/hcc/wiki#compiling-for-different-gpu-architectures

Hi, thanks for catching that! Here's the output with "-a":
cathal@thinkum:/opt/rocm/hsa/sample$ /opt/rocm/bin/rocm-smi -a

===================   ROCm System Management Interface
===================

===================   ROCm System Management Interface
===================
============================================================================
GPU[0] 		: GPU ID: 0x67b1
============================================================================
============================================================================
GPU[0] 		: Temperature: 68.0c
============================================================================
============================================================================
GPU[0] 		: GPU Clock Level: 7 (1040Mhz)
GPU[0] 		: GPU Memory Clock Level: 1 (1500Mhz)
============================================================================
============================================================================
GPU[0] 		: Fan Level: 89 (34.9)%
============================================================================
============================================================================
GPU[0] 		: Current PowerPlay Level: auto
============================================================================
============================================================================
GPU[0] 		: Current OverDrive value: 0%
============================================================================
============================================================================
GPU[0] 		: Minimum SCLK: 1008MHz
GPU[0] 		: Minimum MCLK: 0MHz
GPU[0] 		: Activity threshold: 30%
GPU[0] 		: Hysteresis Up: 0ms
GPU[0] 		: Hysteresis Down: 5ms
============================================================================
============================================================================
GPU[0] 		: Cannot get GPU power Consumption: Average GPU Power not
supported
============================================================================
============================================================================
GPU[0] 		: Supported GPU clock frequencies on GPU0
GPU[0] 		: 0: 300Mhz
GPU[0] 		: 1: 500Mhz
GPU[0] 		: 2: 726Mhz
GPU[0] 		: 3: 892Mhz
GPU[0] 		: 4: 935Mhz
GPU[0] 		: 5: 972Mhz
GPU[0] 		: 6: 1008Mhz
GPU[0] 		: 7: 1040Mhz *
GPU[0] 		:
GPU[0] 		: Supported GPU Memory clock frequencies on GPU0
GPU[0] 		: 0: 150Mhz
GPU[0] 		: 1: 1500Mhz *
GPU[0] 		:
============================================================================
===================          End of ROCm SMI Log
===================

I'll try exporting that and rebuilding the tests, thank you! Although,
perhaps the tooling, such as the libs and clinfo, would need
rebuilding also in that case? Would I need to do a source-level
re-build of ROCm including kernel modules, for this to work? :/

Output when I try with the env-var set (PS: I had to restart to get HIP
to work again, and now my screen has started flickering after a clean
reboot...)

cathal@thinkum:~/sample$ export HCC_AMDGPU_TARGET=gfx701
cathal@thinkum:~/sample$ make
gcc -c -I/opt/rocm/include -o vector_copy.o vector_copy.c -std=c99
gcc -Wl,--unresolved-symbols=ignore-in-shared-libs vector_copy.o
-L/opt/rocm/lib -lhsa-runtime64 -o vector_copy
cathal@thinkum:~/sample$ ./vector_copy
Initializing the hsa runtime succeeded.
Checking finalizer 1.0 extension support succeeded.
Generating function table for finalizer succeeded.
Getting a gpu agent succeeded.
Querying the agent name succeeded.
The agent name is gfx701.
Querying the agent maximum queue size succeeded.
The maximum queue size is 131072.
Creating the queue succeeded.
"Obtaining machine model" succeeded.
"Getting agent profile" succeeded.
Create the program succeeded.
Adding the brig module to the program succeeded.
Query the agents isa succeeded.
Finalizing the program succeeded.
Destroying the program succeeded.
Create the executable succeeded.
Loading the code object succeeded.

...and there it hangs, forever. top shows it running at 100% CPU and
0.1% mem. :/

OK, breakthrough, kinda:

Set up new hard drive with fresh Ubuntu 16.04 LTS install.
Follow installation instructions here as far as checking vector_copy.

With the provided envvar you suggested, this now builds and runs. And. the ROCm clinfo program runs. So that's great!
Problem: This is all done in TTY1, because after installing rocm and restarting, the login screen won't display. I get a white screen with pretty pastel specks all over it. TTYs will load, but if I try to go to the login screen, I just get an unchanging white/cream field with pastel speckles. :/
I'll build Caffe later and see how that goes, meanwhile I need to boot back into my actual harddrive. Though, the AMDGPU-pro -> ROCm transition seems to have destabilised that install, so I think I'll be reinstalling soon!

Giving up on this, at least for now. It looks like ROCm is being developed with very limited card support right now, and I need a stable system more than I need Tensorflow.
Thanks anyway..

@cathalgarvey
Sorry for the trouble with the R9-390,   ROCm is more optimized for GFX8 and newer GPU which support Atomics.  GFX7 had a number of limitation relative to newer hardware.   For your purpose would of running Tensorflow RX480 be better GPU.  If you let me know your contact info privately,  we can get one out to you for testing.

Wow, that's really generous @gstoner - I couldn't turn down an offer like that. :)
I'll email your HSA email, very happy to be a guinea pig for Open Source GPU deep learning!


UnixPb: add stdout of registered variable

Ref https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1910#issuecomment-795907758
The condition should compare the stdout of the variable, not the whole variable. Else it fails with this error
fatal: [test-macstadium-macos1014-x64-1]: FAILED! => {"msg": "The conditional check 'not macos_version | regex_search(\"10.12\")' failed.
The error was: Unexpected templating type error occurred on ({% if not macos_version |
regex_search(\"10.12\") %} True {% else %} False {% endif %}): expected string or bytes-like object\n\n
The error appears to be in '/tmp/awx_763_m5aop2n8/project/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/tasks/MacOSX.yml':
line 93, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\n
The offending line appears to be:\n\n\n- name: Install Build Tool Packages NOT macOS 10.12\n  ^ here\n"}

@gdams Were the playbooks used for setting up the new machines at nine? I would have thought you'd have hit this, unless you were using an alternate version of ansible that didn't fail this check.

Which version of ansible does the AWX server use?
My own mac hit this error too, I use:
ansible 2.9.13
  config file = None
  configured module search path = ['/Users/hkhel/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/Cellar/ansible/2.9.13_1/libexec/lib/python3.9/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.9.0 (default, Oct 27 2020, 14:15:17) [Clang 12.0.0 (clang-1<IP_ADDRESS>)]

@sxa
test-macincloud-macos1010-x64-2 and test-macincloud-macos1010-x64-1 are still unreachable. It would be ideal if I could test the playbook on either of these, since they are not currently being used by a jenkins job, hence I could bring them temporarily offline

It owul dhave been whichever one was latest and supplied with the verison of AWX we use, but I don't think it matters too much if (a) it's broken and (b) you get the same problem :-)
ping @gdams again - were the playbooks used to set up the macos machines at nine?

@gdams To be clear were the nine machine set up with the full playbooks from openjdk-infrastructure?

Yes they had the full playbook run on them, Not sure how it skipped over that error though

Just checked the nine machines:
admin@test-nine-macos1015-x64-1 JavaVirtualMachines % brew install ccache
Warning: ccache 4.2 is already installed and up-to-date.
To reinstall 4.2, run:
  brew reinstall ccache

They both have ccache installed so the logic must have worked when I ran the playbook


Problems during postOrderCreate - body not json

Hello
I'm using $bybit->privates()->postOrderCreate with necessary parameters
[body] => {"0":{"side":"Sell","symbol":"ETHUSDT","qty":0.2,"price":1261.15},"api_key":"...","timestamp":16730...,"sign":"..."}
but getting the answer:
[ret_msg] => body not json
Help plese
Thank you

[body] => {"api_key":"....","order_type":"Limit","price":"4000","qty":"1","side":"Buy","symbol":"BTCUSD","time_in_force":"GoodTillCancel","timestamp":1673401541233,"sign":"...."}
your body is not right.

Could you show an example of a correct request to create an order? Thank you

Hello I'm using $bybit->privates()->postOrderCreate with necessary parameters [body] => {"0":{"side":"Sell","symbol":"ETHUSDT","qty":0.2,"price":1261.15},"api_key":"...","timestamp":16730...,"sign":"..."}
but getting the answer: [ret_msg] => body not json Help plese Thank you

$bybit=new BybitLinear($key,$secret);

$result=$bybit->privates()->postOrderCreate([
        //'order_link_id'=>'xxxxxxxxxxxxxx',
        'side'=>'Sell',
        'symbol'=>'ETHUSDT',
        'order_type'=>'Limit',
        'qty'=>'0.25',
        'price'=>'40000',
        'time_in_force'=>'GoodTillCancel',

        'reduce_only'=>'false',
        'close_on_trigger'=>'false',
    ]);
    print_r($result);

Hello
Could you provide an example of working with websocket
For websocketposition example:
https://bybit-exchange.github.io/docs/futuresV2/linear/#t-websocketposition
I have secretkey, and your lib :)
Thank you very much
ср, 11 янв. 2023 г. в 11:37, lin @.***>:

Hello I'm using $bybit->privates()->postOrderCreate with necessary
parameters [body] =>
{"0":{"side":"Sell","symbol":"ETHUSDT","qty":0.2,"price":1261.15},"api_key":"...","timestamp":16730...,"sign":"..."}
but getting the answer: [ret_msg] => body not json Help plese Thank you
[image: 2023-01-11 17-36-00屏幕截图]
https://user-images.githubusercontent.com/5442664/211770734-2fbfc0c8-d015-41e3-8764-71e1dd45a9de.png
$bybit=new BybitLinear($key,$secret);
$result=$bybit->privates()->postOrderCreate([
    //'order_link_id'=>'xxxxxxxxxxxxxx',

    'side'=>'Sell',

    'symbol'=>'ETHUSDT',

    'order_type'=>'Limit',

    'qty'=>'0.25',

    'price'=>'40000',

    'time_in_force'=>'GoodTillCancel',

    'reduce_only'=>'false',

    'close_on_trigger'=>'false',

]);

print_r($result);

—
Reply to this email directly, view it on GitHub
https://github.com/zhouaini528/bybit-php/issues/17#issuecomment-1378474574,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABYAPFXKR56AV6LP4QNKODWRZ5OLANCNFSM6AAAAAATT4A36M
.
You are receiving this because you authored the thread.Message ID:
@.***>

How use SocketClient with Subscribe for detect orders and positions?
Give me example code please
Thank you
сб, 21 янв. 2023 г. в 16:40, Savchuk Ivan @.***>:

Hello
Could you provide an example of working with websocket
For websocketposition example:
https://bybit-exchange.github.io/docs/futuresV2/linear/#t-websocketposition
I have secretkey, and your lib :)
Thank you very much
ср, 11 янв. 2023 г. в 11:37, lin @.***>:

Hello I'm using $bybit->privates()->postOrderCreate with necessary
parameters [body] =>
{"0":{"side":"Sell","symbol":"ETHUSDT","qty":0.2,"price":1261.15},"api_key":"...","timestamp":16730...,"sign":"..."}
but getting the answer: [ret_msg] => body not json Help plese Thank you
[image: 2023-01-11 17-36-00屏幕截图]
https://user-images.githubusercontent.com/5442664/211770734-2fbfc0c8-d015-41e3-8764-71e1dd45a9de.png
$bybit=new BybitLinear($key,$secret);
$result=$bybit->privates()->postOrderCreate([
    //'order_link_id'=>'xxxxxxxxxxxxxx',

    'side'=>'Sell',

    'symbol'=>'ETHUSDT',

    'order_type'=>'Limit',

    'qty'=>'0.25',

    'price'=>'40000',

    'time_in_force'=>'GoodTillCancel',

    'reduce_only'=>'false',

    'close_on_trigger'=>'false',

]);

print_r($result);

—
Reply to this email directly, view it on GitHub
https://github.com/zhouaini528/bybit-php/issues/17#issuecomment-1378474574,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABYAPFXKR56AV6LP4QNKODWRZ5OLANCNFSM6AAAAAATT4A36M
.
You are receiving this because you authored the thread.Message ID:
@.***>

How use SocketClient with Subscribe for detect orders and positions?
Secretkey too
Give me example code please
Thank you
ср, 25 янв. 2023 г. в 11:46, Savchuk Ivan @.***>:

How use SocketClient with Subscribe for detect orders and positions?
Give me example code please
Thank you
сб, 21 янв. 2023 г. в 16:40, Savchuk Ivan @.***>:

Hello
Could you provide an example of working with websocket
For websocketposition example:
https://bybit-exchange.github.io/docs/futuresV2/linear/#t-websocketposition
I have secretkey, and your lib :)
Thank you very much
ср, 11 янв. 2023 г. в 11:37, lin @.***>:

Hello I'm using $bybit->privates()->postOrderCreate with necessary
parameters [body] =>
{"0":{"side":"Sell","symbol":"ETHUSDT","qty":0.2,"price":1261.15},"api_key":"...","timestamp":16730...,"sign":"..."}
but getting the answer: [ret_msg] => body not json Help plese Thank you
[image: 2023-01-11 17-36-00屏幕截图]
https://user-images.githubusercontent.com/5442664/211770734-2fbfc0c8-d015-41e3-8764-71e1dd45a9de.png
$bybit=new BybitLinear($key,$secret);
$result=$bybit->privates()->postOrderCreate([
    //'order_link_id'=>'xxxxxxxxxxxxxx',

    'side'=>'Sell',

    'symbol'=>'ETHUSDT',

    'order_type'=>'Limit',

    'qty'=>'0.25',

    'price'=>'40000',

    'time_in_force'=>'GoodTillCancel',

    'reduce_only'=>'false',

    'close_on_trigger'=>'false',

]);

print_r($result);

—
Reply to this email directly, view it on GitHub
https://github.com/zhouaini528/bybit-php/issues/17#issuecomment-1378474574,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABYAPFXKR56AV6LP4QNKODWRZ5OLANCNFSM6AAAAAATT4A36M
.
You are receiving this because you authored the thread.Message ID:
@.***>


Fix the start command from the CLI

https://github.com/platformatic/platformatic/pull/472 broke all start commands by making them exit with code 0. This PR changes that and adds a test.
Signed-off-by: Matteo Collina<EMAIL_ADDRESS>

cc @rozzilla

cc @rozzilla

Thank you for tagging me! I was looking to it!


Newcomers' Guide data model

AC: Describe the data model including the entities: Task, Info (find better name), Questionnaire, Question, Answer, TaxonomyTerm, with multilingual support and support for some form of mark-up.

This was my first stab at data model, with separate entities for user data and localization data:

However, I am tending towards a simpler model where the user data is stored in the entities, and the localized strings are also stored in their entities as a lookup table keyed on the locale:

Recognizing that there is actually a 1:1 relationship between Answer and TaxonomyTerm entities, the model can be simplified quite a bit:

Note that this model explicitly assumes that it will be represented in Javascript, translating this to SQL would involve additional tables (see several array and map data types).

Looks good at first glance.
I'm not sure about embedding/simplifying TaxonomyTerms down to just strings on Answer/Task/Article entities. Do we anticipate our taxonomy terms being user-facing at all? If so then our term names are going to need to be translated, would be best to use foreign-keys in that case.
I assume Article is for the general info content?

Robin raised some good points: We need to be able to add tasks that are not associated with answers, otherwise we're ending up with too few tasks or too many questions. So I'm now thinking more along the lines of a few dozen tasks being "featured" by being tied to answers in the questionnaire, plus a much larger number of more specialized tasks that can only be discovered through the ExploreAll deep delve.
With that I end up with something like this:

The recommendation algorithm is still not quite right, though...

Recommendation algorithm
A task or article is recommended

if it has isRecommendToAllUsers equal to true, or
if it has one or more associated question, all of those questions have isSelected equal to true, or
if it has no associated questions and it has a taxonomy term with recommendIfSelected, and that taxonomy term is associated with a question that has isSelected equal to true

I assume a "power" taxonomy term is one with recommendIfSelected equal to true. If so, looks good. If not, how does a taxonomy term get tagged as a "power" term?

This is looking good Rasmus.

For completeness, this is what the server side data entities would look like

Client side entities:

Recommendation algorithm
A task or article is recommended:

if it has isRecommendedToAllUsers equal to true, or
if it has one or more associated answers, all of those answers have isSelected equal to true

Implications of this implementation:

We can easily tag a task or article to be recommended to everyone.
"Featured" tasks and articles that are associated with one or more answers in the questionnaire are recommended only when all the related answers are selected, so we have precise control over how they are recommended.
Answers corresponding to broad categories such as "between 13 and 18 years old" can be used in combination with one or more other answers, to avoid recommending large number of tasks based on broad categories.
Answers corresponding to narrower categories, such as "I'm interested in LGBT issues" can be used by themselves, so that selecting just this one answer leads to the recommendation of tasks.
Tasks and articles that are not associated with answers will never be recommended, but they can be found through search and explore all.
In the likely event that we need to represent more complex logic and just AND among selected answers in the recommendation engine, storing the logic in the form of http://jsonlogic.com/ seems a possible solution.

Server side entities:

Following additional discussion with Robin, and refinement of the scope for the MVP to exclude all server side work, this more general data model (all relationships to taxonomy terms are 0..n rather than the more narrowly defined relationships above) is proposed to be sufficient for the MVP:

Final diagram represent the client data structure we want. Note that the tasks are represented using a different data structure, this is tech debt that we probably want to fix.

Here are some thoughts on what the server side data model could look like, @bensinjin, @robinpuga, @trisapeace please have a look.

Looking good, @rasmus-storjohann-PG .
Is there any time when we would need to get an Article or a Task without it being associated with user? For example, when would we need to get an article without knowing whether it were starred or not? I think you only need one API call that will return the join of Article and UserArticle. You wouldn't want to have to make two separate calls to get it. And the same for one API call that will get the join of Task and UserTask.
Similarly, an API call to answer would need to take a particular user as a parameter so you only get back Answers associated with a particular user. Am I understanding this correctly?
For structure elements not related to users, like ExploreSection, TaxonomyTerm, Task, Article, Question, and (sort of) Answer, do you envisage these being downloaded from the server on initial installation? Or will these be updated at some interval?
The reason that I say "sort of" in front of Answer is that it seems to be playing the role of both a read-only item like Article and also a write-able item like UserArticle. So maybe it needs two endpoints... one that will be readonly like /answer/:answerid and also one for read-and-write like /user/:userid/answer/:answerid (or /answer/:answerid/user/:userid).
Can you please explain what you mean by "localized string"? To do the locale switcher on the front end, it will need to know all the translations for each entity, won't it?

I think the model looks good although the api piece possibly shouldn't be modelled directly from it.  I think it's going to be better that we build specifically what we need from the api from example: "Heres a list of survey answers get me associated tasks" or "Here's a list of user tasks sync it with the server".

Hmmm, good point. This looks like it could be relevant https://savvyapps.com/blog/how-to-build-restful-api-mobile-app


Fix issue 286: Header cuts off body…

…by replacing {{ STATIC_URL }}x with {% static "x" %} in {public_,}base.html
Closes #286

Noticing that my initial commit broke Travis builds for Django 1.5 - 1.7, I have amended the PR with the appropriate fix.


Feature:Code Snippet Sharing

This issue is dedicated to sharing and discussing code snippets within our project. It serves as a centralized place where contributors can post code samples, utility functions, or helpful snippets that could benefit the project or other developers.

@Sahilll15 and we can share code snippet in this website


fix(client): Don't notify of actual change if there are no changes

Just a minor fix. There could be instances where actuallyChanged is called with an empty array.

@msfstef Done!

@davidmartos96 awesome! sorry for this but could you also add a patch changeset for this using pnpm changeset at the root of the project? We want to do a release today and would love to include this PR

@msfstef True, this might be interesting to include in the changelog as a fix for undesired renders/events


category handling compliant with jekyll

Only if the page's front matter doesn't specify categories, extract them from the path. See #247 for reasoning.

I just tested it and Jekyll use both directory and front matter categories when they are specified.


Integration tests for validator

Based on #99
We need to test the validator every time we push new code, so, it is required to build some scripts or code to test some of the vital interactions with the miners and the metagraph
Testing list

[ ]  Is the validator calling miners? Deploy a miner ( Dependency on docker setup ) and check if the miner gets a call from the deployed validator

[ ] Is the validator ignoring miners that don't meet the selection criteria? ( deploy a miner that doesn't meet the selection criteria and check if it's being ignored )

[ ] Setting weights ( Check if the weights are being set correctly after some calls to miners ) There is an example on the  parent ticket #99  (link)

[ ] Check that the scores are being updated ( deploy a miner and make some calls to the validator api, check that the state.pt file is updated )

This scripts must be called from the GH actions set up on #117

Based on the description, would you agree @hide-on-bush-x that this task is:

Blocked by #117

?
If so, i'd suggest to add the blocker label here

We need to groom this on the next planning and get final agreement between eng team and devops on how the integration tests should look like and how they should be executed.

Closing this because it is covered in #120 and #121


Fix all workers running beats

This caused inaccurate timings and some duplicate jobs running. There
should only ever be a single beat service, whereas we were using a dev
feature to run a beat service on all 16 workers

Codecov Report

Merging #419 into master will not change coverage.

@@          Coverage Diff           @@
##           master    #419   +/-   ##
======================================
  Coverage    77.8%   77.8%
======================================
  Files          28      28
  Lines        2365    2365
  Branches      150     150
======================================
  Hits         1840    1840
  Misses        479     479
  Partials       46      46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd877b8...8dd27fb. Read the comment docs.


Add NIC name and ASG to example powershell script

Also fixed minor typo for VirtualNetwork

@anharazi : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@anharazi: I'm sorry - only the author of this article, @v-miegge, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Hi @anharazi - This PR was opened in the public repository. We’ll leave this PR for review in the public repo, but would you make future article updates in the private repo?
In the private repo, content benefits from automated validations, a content staging environment, and comprehensive PR reviews. Also, you can sign off directly in your PR (in the public repo, you can't sign off in your own PR), and many PRs qualify for auto-merge.
To edit an article in the private repo from within the documentation, after you select Edit on an article page,  add “-pr” to the repo name in the URL.
SpineEdit is a Chrome extension that opens the edit option in the private repo, if there is one and if you have access to it.
Thanks!

Related links in the internal Microsoft Docs contributor guide:
Public vs. private repos | Move a commit to a different repo (public -> private) | GitHub for content reviews
Quick reference for contributing to the docs | Make changes to a Docs article | PR review quality criteria

Will do and thanks @ktoliver
For this PR, are the next steps for @v-miegge to review?

@anharazi Super, thanks!
For @v-miegge, he'll receive a GitHub notification as the listed author (depending on how he has set up notifications in his GitHub account). It's then up to him to review and sign off on the PR. In the public repo, no SLAs are set.

Thanks, all; merging the PR.

Will do and thanks @ktoliver Kristine Toliver (Aquent LLC) Vendor
For this PR, are the next steps for @v-miegge Mike Eggers (MOTIV INC) Vendor to review?

Sorry, I misread this as what are the next steps. Yes, that was the next step. :)


Ubuntu installation error: Failed to lock apt for exclusive operation

Describe the bug
When trying to run the installation script, the operations fails with this stacktrace..
The full traceback is:
  File "/tmp/ansible_lQg05D/ansible_module_apt.py", line 1027, in main
    cache.update()
  File "/usr/lib/python2.7/dist-packages/apt/cache.py", line 465, in update
    raise LockFailedException("Failed to lock %s" % lockfile)

failed: [fra1-deb-001] (item=[u'zabbix-agent', u'zabbix-sender', u'zabbix-get']) => {
    "changed": false,
    "invocation": {
        "module_args": {
            "allow_unauthenticated": false,
            "autoclean": false,
            "autoremove": false,
            "cache_valid_time": 0,
            "deb": null,
            "default_release": null,
            "dpkg_options": "force-confdef,force-confold",
            "force": false,
            "force_apt_get": false,
            "install_recommends": null,
            "name": [
                "zabbix-agent",
                "zabbix-sender",
                "zabbix-get"
            ],
            "only_upgrade": false,
            "package": [
                "zabbix-agent",
                "zabbix-sender",
                "zabbix-get"
            ],
            "purge": false,
            "state": "present",
            "update_cache": true,
            "upgrade": null
        }
    },
    "item": [
        "zabbix-agent",
        "zabbix-sender",
        "zabbix-get"
    ],
    "msg": "Failed to lock apt for exclusive operation"
}

Installation method/version

Ansible Galaxy, role version: 1.3.0

ansible 2.6.1
  config file = /home/tobias/.ansible.cfg
  configured module search path = [u'/home/tobias/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Jul 13 2018, 13:06:57) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

Targetted hosts
Concerns the following OS(es):

Ubuntu

Expected behavior
The ansible script is supposed to not crash =P
Additional context
no configuration changes.. it's right out of the box kind of.

Hi.
It seems as of the task is not running as root. Can you provide some more information with how your command line looks like, some more screen output?

I'll close this issue. If you still encounter this issue, please reopen.


amplitude is devided by omega in an Acos2 calculation

I found that an amplitude was not devided by omega in the GCEED part while it was in the ARTED part. So I fix. I also show a calculated result.

Thank you @mn2007 san for developing, I will check this later...

Thank you in advance for checking, @uemoto1 san.


White Widget since iOS18

Hi,
since iOS18 and iPadOS18, the widget are only clean white, no text to see. In Sciptable the widget works Fine.

Hey :) thanks for letting me know. I have currently no iOS18 device next to me so i can’t check what’s going on. But anyway i guess it is not a problem in the script (since it works inside the app as you said) so i guess it will be fixed with some future Scriptable update. There was a similar case in the past that also got resolved that way. But if i know what the problem is i will fix it 👍🏻

There is an update available. Can you give me feedback if it is fixed? Thanks

Hi,With update works fine for me😊Thanks for your help.Am 29.09.2024 um 14:32 schrieb lwitzani @.***>:
image.jpeg (view on web)
There is an update available. Can you give me feedback if it is fixed? Thanks
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


Migrate to new endpoint for Watson APIs

cf. https://cloud.ibm.com/docs/watson?topic=watson-endpoint-change
This will need updating at least in:
https://github.com/IBM/taxinomitis/blob/9f8f666c93a49598083d65f5441c88f45e0bf1c5/src/lib/training/conversation.ts#L625-L632
and
https://github.com/IBM/taxinomitis/blob/9f8f666c93a49598083d65f5441c88f45e0bf1c5/src/lib/training/visualrecognition.ts#L965-L967

I'll also need to update the endpoints stored in the prod DB

https://github.com/watson-developer-cloud/api-guidelines/pull/16/files
looks like there are some useful pointers in how to do it here

update from IBM Cloud

We will soon be retiring the watsonplatform.net endpoint and moving to watson.cloud.ibm.com. We are extending the retirement date to May 26, 2021 to give you more time.
To avoid any interruption in service please update your code to use the new api.{location}.{offering}.watson.cloud.ibm.com URL for all your Watson instances.
For additional details on how to find and update the URL, please checkout our Docs

update from IBM Cloud

We will soon be retiring the watsonplatform.net endpoint and moving to watson.cloud.ibm.com. We are extending the retirement date to May 26, 2021 to give you more time.
To avoid any interruption in service please update your code to use the new api.{location}.{offering}.watson.cloud.ibm.com URL for all your Watson instances.
For additional details on how to find and update the URL, please checkout our Docs

update bluemixcredentials
     set url='https://api.eu-gb.assistant.watson.cloud.ibm.com'
   where url='https://gateway-lon.watsonplatform.net/assistant/api';

update bluemixcredentials
     set url='https://api.jp-tok.assistant.watson.cloud.ibm.com'
   where url='https://gateway-tok.watsonplatform.net/assistant/api';

update bluemixcredentials
     set url='https://api.kr-seo.assistant.watson.cloud.ibm.com'
   where url='https://gateway-seo.watsonplatform.net/assistant/api';

waiting until select count(url) from bluemixclassifiers where url like 'https://gateway%'; returns 0 before this issue can be closed


Index Error when train yolonas small in google collab with TPU

💡 Your Question
I train yolonas with my own dataset and train it in TPU (I cant use GPU because the google colab always restart the runtime), when I run this code :
from super_gradients.training import Trainer
trainer = Trainer(experiment_name=EXPERIMENT_NAME, ckpt_root_dir=CHECKPOINT_DIR)
trainer.train(model=model,
training_params=train_params,
train_loader=train_data,
valid_loader=val_data)
I got error like this :
/usr/local/lib/python3.10/dist-packages/super_gradients/training/sg_trainer/sg_trainer.py in train(self, model, training_params, train_loader, valid_loader, test_loaders, additional_configs_to_log)
1359                     self.train_loader.sampler.set_epoch(epoch)
1360
-> 1361                 train_metrics_tuple = self._train_epoch(context=context, silent_mode=silent_mode)
1362
1363                 # Phase.TRAIN_EPOCH_END
/usr/local/lib/python3.10/dist-packages/super_gradients/training/sg_trainer/sg_trainer.py in _train_epoch(self, context, silent_mode)
440
441                     # COMPUTE THE LOSS FOR BACK PROP + EXTRA METRICS COMPUTED DURING THE LOSS FORWARD PASS
--> 442                     loss, loss_log_items = self._get_losses(outputs, targets)
443
444                 context.update_context(preds=outputs, loss_log_items=loss_log_items)
/usr/local/lib/python3.10/dist-packages/super_gradients/training/sg_trainer/sg_trainer.py in _get_losses(self, outputs, targets)
473     def _get_losses(self, outputs: torch.Tensor, targets: torch.Tensor) -> Tuple[torch.Tensor, tuple]:
474         # GET THE OUTPUT OF THE LOSS FUNCTION
--> 475         loss = self.criterion(outputs, targets)
476         if isinstance(loss, tuple):
477             loss, loss_logging_items = loss
/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py in _call_impl(self, *args, **kwargs)
1499                 or _global_backward_pre_hooks or _global_backward_hooks
1500                 or _global_forward_hooks or _global_forward_pre_hooks):
-> 1501             return forward_call(*args, **kwargs)
1502         # Do not call functions when jit is used
1503         full_backward_hooks, non_full_backward_hooks = [], []
/usr/local/lib/python3.10/dist-packages/super_gradients/training/losses/ppyolo_loss.py in forward(self, outputs, targets)
772             alpha_l = 0.25
773         else:
--> 774             assigned_labels, assigned_bboxes, assigned_scores = self.assigner(
775                 pred_scores=pred_scores.detach().sigmoid(),  # Pred scores are logits on training for numerical stability
776                 pred_bboxes=pred_bboxes.detach() * stride_tensor,
/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py in _call_impl(self, *args, **kwargs)
1499                 or _global_backward_pre_hooks or _global_backward_hooks
1500                 or _global_forward_hooks or _global_forward_pre_hooks):
-> 1501             return forward_call(*args, **kwargs)
1502         # Do not call functions when jit is used
1503         full_backward_hooks, non_full_backward_hooks = [], []
/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py in decorate_context(*args, **kwargs)
113     def decorate_context(*args, **kwargs):
114         with ctx_factory():
--> 115             return func(*args, **kwargs)
116
117     return decorate_context
/usr/local/lib/python3.10/dist-packages/super_gradients/training/losses/ppyolo_loss.py in forward(self, pred_scores, pred_bboxes, anchor_points, num_anchors_list, gt_labels, gt_bboxes, pad_gt_mask, bg_index, gt_scores)
505         gt_labels_ind = torch.stack([batch_ind.tile([1, num_max_boxes]), gt_labels.squeeze(-1)], dim=-1)
506
--> 507         bbox_cls_scores = pred_scores[gt_labels_ind[..., 0], gt_labels_ind[..., 1]]
508
509         # compute alignment metrics, [B, n, L]
IndexError: index 2 is out of bounds for dimension 1 with size 2
Versions
No response

We don't support TPU compute engine in SG.
Sorry, there is no solution for your problem at the moment.


Non-uniform depth spacing and available potential energy method

Jerry's paper has some Thorpe scale related 'potential energy' methods that should be included as well as refinements to the normal Thorpe scales for irregularly spaced data...
Smith, J. A. (2020). A comparison of two methods using thorpe sorting to estimate mixing. Journal of Atmospheric and Oceanic Technology, 37(1), 3–15. https://doi.org/10.1175/JTECH-D-18-0234.1

I think it would be really useful to add the non-uniform depth spacing calculation. It doesn't seem to hard.

Hi Jesse,
fully agree with you regarding the non-uniform depths. Have you added this option in the current version?
Cheers
Ivica

No it has not. If you you would like to have a go at implementing this feature that would be most welcome!


Improvements to the current celelry syntax

Description:
This includes below improvements

Remove ballerina.io package from cellery init file
APIDefinition struct, read swagger file and generate API Defintion
Rename HttpApiIngress
Remove 'public' from access modifiers
Rename exposeGlobalAPI -> exposeGlobal
Rename exposeIngressFrom -> exposeLocal"

Fixed via

https://github.com/wso2-cellery/sdk/pull/123
https://github.com/wso2-cellery/sdk/pull/118


Unable to maximize window closed window

Bug description:

Since the update to 5.6.3 i can't maximize a closed window with the tray icon.
Steps to reproduce:

Close the window.
Maximize it via the tray icon "show ferdi"

Expected behavior
My ferdi window.
Screenshots
N/A
Environment:

Operating System: Arch Linux / EndeavourOS

Ferdi Version: 5.6.3

Server: Ferdi

Debug information:

TypeError: Cannot read properties of undefined (reading 'isMinimized')
    at click (/opt/ferdi/resources/app.asar/lib/Tray.js:1:692)
    at MenuItem.click (node:electron/js2c/browser_init:73:1908)
    at Object.a._executeCommand (node:electron/js2c/browser_init:81:2453)
(node:161432) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 did-stop-loading listeners added to [EventEmitter]. Use emitter.setMaxListeners() to increase limit
(Use `ferdi --trace-warnings ...` to show where the warning was created)
TypeError: Cannot read properties of undefined (reading 'isMinimized')
    at click (/opt/ferdi/resources/app.asar/lib/Tray.js:1:692)
    at MenuItem.click (node:electron/js2c/browser_init:73:1908)
    at Object.a._executeCommand (node:electron/js2c/browser_init:81:2453)
TypeError: Cannot read properties of undefined (reading 'isMinimized')
    at click (/opt/ferdi/resources/app.asar/lib/Tray.js:1:692)
    at MenuItem.click (node:electron/js2c/browser_init:73:1908)
    at Object.a._executeCommand (node:electron/js2c/browser_init:81:2453)

Duplicate of #2147


Output full method name in assertion context

This make it easier to find the correct method in the history output.
Dependency

[x] PR #327

@t-b @MichaelHuth Ready for review.


Tooltip issue in School Infrastructure

Select
Allahabad district
Chaka block
Chak babura cluster
Mouse hover on the marker
issue: Half of the tooltip is not visible

If the content of the tooltip is too long, then the user have to scroll down the page or zoom out of the map.


ESLint 8 - Upgrade

This PR upgrade the dependencies and add compatibility for ESLint 8.
(Following the changes on #71).
Big thanks to @ezudas and @maldago, for supporting this update.

@rwaskiewicz could you please publish a 0.5.0 version with this commit to npm?

@MaksimShakavin FYI - The Stencil team has moved this package to the Stencil Community model. Moving forward, it is being published under @stencil-community/eslint-plugin. You should be able to download it via npm i -D @stencil-community/eslint-plugin


Added SFS to the company_names.txt

company_names.txt is deprecated. to change the default company names, you have to change it in company_names.py.


Added return probability for Logistic Regression

While calling Logistic Regression at scoring time, it used to return just the predicted class label. Made provisions for it to return predicted probability as well.

It looks good to me. Make sure all the tests are green.


Fix find.

[x] I need to do more manual testing with rm -f to make sure it's going to suffice for what I need from the Delete Files task. It needs to handle deleting symlink folders/files (i.e. delete the symlink only, not the actual folder/file). It also needs to handle deleting a symlink if the target folder/file no longer exists.
Nevermind. I'm going to use rm -rf for delete files. It removes a symlink without following. I added unit tests to verify.
[x] Add unit tests for the minimatch interface change. Madhuri pointed out to me that multiple tasks have a lot of code doing the same thing: applying match patterns. I added an overload so pattern can either be a string or an array of strings. I moved the hash table logic (which is used to avoid returning duplicate results) into the lib function.
[ ] I'm on the fence about this one, but I'm leaning toward switching the find function to the following interface: find(findPath: string) and an overload find(options: string, findPath: string). That would make it consistent with the shelljs function interfaces. Then instead of passing a dictionary of options, it would just be a string, e.g. find('-L', '/some/path').

Looks good.
As discussed, options is good as a class or interface.  More appropriate for javascript.
Thanks for adding tests

This also means the affected task will have to adopt the latest task-lib.  There's a few breaking changes when adopting newest task lib.  Send me review on that one.


Where to put services with custom business logic

Hi!
Currently I see that the logic which is in Northwind.Application project is very suitable for basic UI CRUD operations. Currently I am at the point in developing my application where I need to introduce custom business logic which is out of scope from basic CRUD operations (for example, I need to read, parse, process XML files) thus it is not clear to me how to handle it. This logic would belong in some sort of services, but where would an appropriate place in this template to put these service classes? How could it look like? Maybe domain layer?
Theoretically I understand that I can create a command (as per CQRS pattern), however, I feel that certain logic would be tied to that specific command even though there are parts of business logic which could be used in throughout application layer (many commands and queries).
Thanks!

Hi @t3hInox, thanks for your question.
Suggest implementing as follows:

Within Application, create an interface and models for working with the data.
Within Infrastructure, create an implementation that works with the XML files.
Within Application, create a query or command to work with the new interface and models.

Some key points:

The query / command will contain the business logic. That logic will interact with the new interface to receive the data.
The models will be contained within the Applciation layer. They will be basic data transfer objects.
The query / command won't know anything at all about the XML, since the implementation is contained within Infrastructure.
The implemntation will be responsible for reading the XML files and returning models.
The implementation can change at anytime, and this won't affect business logic.

Hope this helps.

Thanks, @JasonGT !
Appreciate your feedback.


Android-side camera implementation

Implementation of the camera in the Android app.
:ballot_box_with_check: Definition of Done checklist

[ ] Meaningful title and valuable description in pull request
[ ] Code change tested manually if not covered by automated tests
[ ] Pull request linked to one or more issues/stories
[ ] Acceptance criteria of the linked stories satisfied
[ ] Code change comprehended by those who approved it
[ ] State of target branch maintained or improved after the code change

The camera is working properly, and all requirements are satisfied. The camera window is positioned right above the joystick window, so that I left some space above the camera window for "delivered" button implementation. However, the "delivered" button can also be positioned below the camera window instead, what do you guys think?


Dev

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@882f1be). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   43.49%
=======================================
  Files           ?      105
  Lines           ?     8852
  Branches        ?     1345
=======================================
  Hits            ?     3850
  Misses          ?     4602
  Partials        ?      400

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882f1be...5e0c0c0. Read the comment docs.


No outbound peer connections when restarting & Sluggish startup

Background
Describe your issue here.
Your environment

version of lnd 0.4.2-beta commit=6dff599d213be4182a70c8eab4cac8a36d3c15e4 but was also running into something similar on pervious commmits
which operating system (uname -a on *Nix)
Ubuntu  x86_64 GNU/Linux
version of btcd, bitcoind, or other backend
btcd version 0.12.0-beta
any other relevant environment details

Steps to reproduce
Tell us how to reproduce this issue. Please provide stacktraces and links to code in question.
Expected behaviour
Tell us what should happen
Outbound connections
Actual behaviour
Tell us what happens instead
Here's what profiling shows:
https://paste.ubuntu.com/p/JxjrqWzrdw/
https://paste.ubuntu.com/p/QJ5k3rjGzn/
In previous commits LND would usually take 20ish minutes to startup and it would eventually. This time it refuses to connect outbound and I left it running overnight.
Seems after another restart I was able to connect to some peers but doesn't auto connect to any others.
2018-07-17 08:27:55.520 is where I restart, and any connections made following that I made manually.
LND logs
https://paste.ubuntu.com/p/4MgWjJqRB4/
Another profiler view from this point http://paste.ubuntu.com/p/tNXp4PX7jC/

See the two linked PRs!

Running both PR's now and can now addinvoice quickly after startup.
Just started running it but seems stalled a bit with no peers.
Here's the profile: http://paste.ubuntu.com/p/3q3h5T5JFm/
I've also tried manually connecting to peers as shown in the logs below:
https://paste.ubuntu.com/p/Rhd4YdT33S/
Without the patches lnd did eventually start connecting outbound. Will follow up and see how long it takes now.

In that trace, we see the same issue of the RPC client waiting on btcd to return a block:
1 @ 0x42e7aa 0x42e85e 0x4061a2 0x405e5b 0x833302 0x833583 0xb37529 0xb36d91 0xb358ec 0x45bd51
#	0x833301	github.com/lightningnetwork/lnd/vendor/github.com/btcsuite/btcd/rpcclient.receiveFuture+0x41				/home/ubuntu/gocode/src/github.com/lightningnetwork/lnd/vendor/github.com/btcsuite/btcd/rpcclient/infrastructure.go:797
#	0x833301	github.com/lightningnetwork/lnd/vendor/github.com/btcsuite/btcd/rpcclient.FutureGetBlockVerboseResult.Receive+0x41	/home/ubuntu/gocode/src/github.com/lightningnetwork/lnd/vendor/github.com/btcsuite/btcd/rpcclient/chain.go:119
#	0x833582	github.com/lightningnetwork/lnd/vendor/github.com/btcsuite/btcd/rpcclient.(*Client).GetBlockVerbose+0x42		/home/ubuntu/gocode/src/github.com/lightningnetwork/lnd/vendor/github.com/btcsuite/btcd/rpcclient/chain.go:154
#	0xb37528	github.com/lightningnetwork/lnd/chainntnfs/btcdnotify.(*BtcdNotifier).confDetailsManually+0x1a8				/home/ubuntu/gocode/src/github.com/lightningnetwork/lnd/chainntnfs/btcdnotify/btcd.go:564
#	0xb36d90	github.com/lightningnetwork/lnd/chainntnfs/btcdnotify.(*BtcdNotifier).historicalConfDetails+0x90			/home/ubuntu/gocode/src/github.com/lightningnetwork/lnd/chainntnfs/btcdnotify/btcd.go:480
#	0xb358eb	github.com/lightningnetwork/lnd/chainntnfs/btcdnotify.(*BtcdNotifier).notificationDispatcher+0x98b			/home/ubuntu/gocode/src/github.com/lightningnetwork/lnd/chainntnfs/btcdnotify/btcd.go:308

So it would appear that the issue might actually be with btcd. btcd supports the same profiling (even same arg) that lnd does, so I think a set of profiles or goroutiune dumps for when btcd when lnd is tarting up would allow us to get to the bottom of the issue at hand.

With that PR merged, can you try updating your btcd and giving it another shot? The other two related PR's have also been merged as well (async invoice ntfn, async rescan).

I've applied @wpaulino patch to make use of txindex and not scan back all the way to the channel opening time manually. Seems that made everything snappy, I haven't tried the btcd patch but can say for sure it was the ghost pendingchannels and having many of them taking ages to rescan for a txid that won't ever appear. Any way to fix the wrong balance or do I have to manually rescan everything like I did last time?
I applied this patch: https://pastebin.com/z4b2WMYk


Custom markup

I have some custom replacements I want to do, but they can't happen in pre or code blocks.  I can't do the replacements after the markdown has been done because it will replace them in code and pre blocks.
I assume this is a job for extensions, but I can't figure out how.  Any advice?

I can't do the replacements after the markdown has been done because it will replace them in code and pre blocks.

You can do this way → https://stackoverflow.com/a/63653055/1163000
Make sure to extend the regex pattern to exclude code tags too:
'/(<code(?:\s[^>]*)?>[\s\S]*?<\/code>|<[^>]+>)/'


docs: Add azure-pipelines CI guide

Closes https://github.com/facebook/docusaurus/issues/1208

Motivation
Adding azure pipelines CI guide.
Have you read the Contributing Guidelines on pull requests?
Yes.

See it in action here: https://dev.azure.com/ab16u10143/docusaurus-test/_build/results?buildId=34&view=results

hey @ayan-b, thanks
The docs you edited are for Docusaurus v1.
Wonder if you could do the same for Docusaurus v2 doc too (website/docs)?
We are going to release very soon a v1->v2 migration cli and we encourage you to migrate to v2 as long as you don't have versioning/i18n

@slorber Should I add a new file inside website/docs as I cannot find an existing one?


Handle Click drag rotation on placement

Click drag ignores RA.

I actually like this, it allows you to use the games default behavior.


SwiftCLI from Xcode terminal

Hello,
I made Swift script which runs some shell commands (mostly Fastlane). For running shell I use class Task.
I am using rbenv for changing Ruby version. Everything works when I compile script and executing it in terminal.
When I execute my script directly from Xcode it fails. Somehow Xcodes terminal does not know nothing about rbenv.
I find out the issue is related with terminals type and environment. https://mgrebenets.github.io/xcode/2019/04/04/xcode-build-phases-and-environment
Any idea how to fix my issue?
Thank you

I'm afraid this issue lies outside of this project -- if I'm understanding you correctly, the problem isn't with Task but with the Xcode terminal environment which I am not familiar with. If I've misunderstood and the problem does lie with the Task class, please feel free to reopen!


Influxdb knobs to control logging severity

Hi,
Are there any knobs to control influxd logging ? I see lot of events are logged (GET/POST etc.). When millions of data points are added continuously, this will fill up logs and effect performance as well. Is there a way to set different logging levels ? If not, is there any planned enhancement ?
Thanks,
Sarat

The configuration documentation lists the logging configuration settings for each portion of the database.


Bugfix after recent changes in prompt module

Simple bug fix with use declaration and public scope, it should be straightforward to approve, thanks.

Looks good, thanks!


Add 'Align to' option in Synchronized Integration dialog

I am not sure whether it is really necessary to ask the user which result file to align to when changing peak boundaries.
The most logical thing to do is to align to the result file in which the peak boundary was performed.
So, all you need to have is a checkbox that says "Align Times". (But, then, you also need to ask the user whether to align things using iRT).

At this point it is just a shortcut to doing what we were allowing before,
which is only aligning when the x-axis was set to align, which seemed
pretty hard to find. So, I suggested adding this as a way of advertising
it. It just performs the matching menu action to set the x-axis to the
aligned values.
Your idea sounds cool. I think the all vs all alignment case is less common
that iRT, though.
Let’s not change it right now. Let’s leave it just and advertisement for
what was already implemented.
On Thu, Nov 18, 2021 at 7:32 PM nickshulman @.***>
wrote:

I am not sure whether it is really necessary to ask the user which result
file to align to when changing peak boundaries.
The most logical thing to do is to align to the result file in which the
peak boundary was performed.
So, all you need to have is a checkbox that says "Align Times". (But,
then, you also need to ask the user whether to align things using iRT).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/1849#issuecomment-973671853,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYBWUGCCICEARYMEBI24PDUMWZKNANCNFSM5IK2XIHA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I am not sure I totally agree with you on that, Nick. I sort of do, but I
also wonder how confusing it could be to people who are less abstract than
you (pretty much 99% of the population). With the way it is, we are
guaranteed that the user is currently visualizing the data in a way that
makes sense for the synchronization, and which provides viewing
compatibility with synchronized zooming.
Your way makes the best sense in the abstract but could be highly confusing
to a user less comfortable with the nuance of the abstraction.
On Tue, Nov 23, 2021 at 9:03 AM nickshulman @.***>
wrote:

@.**** approved this pull request.
Looks good enough to me for code complete.
In the future I would recommend decoupling the synchronizing of peak
boundaries from the way that they are displayed in the chromatogram window.
The user really should only need to be asked whether they want to align
peak boundaries using iRT or MS/MS IDs.
In pwiz_tools/Skyline/EditUI/SynchronizedIntegrationDlg.cs
https://github.com/ProteoWizard/pwiz/pull/1849#discussion_r754821235:

       {

           if (!settings.HasResults || settings.DocumentRetentionTimes.FileAlignments.IsEmpty)

               yield break;

           var chromFileInfos = settings.MeasuredResults.Chromatograms.SelectMany(chromSet => chromSet.MSDataFileInfos).ToArray();

           foreach (var name in settings.DocumentRetentionTimes.FileAlignments.Select(alignment => alignment.Key))

           {

               var chromFileInfo = chromFileInfos.FirstOrDefault(info => name.Equals(FileDisplayName(info)));

               if (chromFileInfo != null)

                   yield return chromFileInfo;

           }

       }

       private static string FileDisplayName(IPathContainer chromFileInfo)

       {

           return Path.GetFileNameWithoutExtension(SampleHelp.GetFileName(chromFileInfo.FilePath));

You should do:
return chromFileInfo.FilePath.GetFileNameWithoutExtension();
"SampleHelp" just exists for backwards compatibility before the class
"MsDataFileUri" existed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/1849#pullrequestreview-813250823,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYBWUF47ZI7OSGMQBKR2XDUNPCMPANCNFSM5IK2XIHA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Client NG Join Federation

Making progress on #2506

Question from dev call: will we still be able to instantiate the client if we've already downloaded the config and don't have internet access.

Is this blocked on anything @okjodom?

Is this blocked on anything @okjodom?

Will look at this end of week, to rework conditions in which we download config, and complete test coverage. No explicit blocker

Resumed work on this item today...
@dpc I'm trying to understand this trace which tells me the gateway client built is not (en/de)coded properly, but I've not been able to figure out where exactly. I am adding WsClientConnectionInfo to gateway db, and ClientConfig to the client db, so I started looking there to figure out what the mishap could be.
Trace from a test:
---- can_switch_active_gateway stdout ----
thread 'tokio-runtime-worker' panicked at 'Expected decoded value', /home/okj/fedimint/fedimint/fedimint-core/src/encoding/mod.rs:739:43
stack backtrace:
   0: rust_begin_unwind
             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/std/src/panicking.rs:575:5
   1: core::panicking::panic_fmt
             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/core/src/panicking.rs:64:14
   2: fedimint_core::encoding::DynRawFallback<T>::expect_decoded_ref
             at /home/okj/fedimint/fedimint/fedimint-core/src/encoding/mod.rs:739:43
   3: fedimint_core::config::ClientModuleConfig::cast
             at /home/okj/fedimint/fedimint/fedimint-core/src/config.rs:550:9
   4: {async_block#0}<fedimint_dummy_client::DummyClientGen>
             at /home/okj/fedimint/fedimint/fedimint-client/src/module/gen.rs:100:123
   5: poll<alloc::boxed::Box<(dyn core::future::future::Future<Output=core::result::Result<fedimint_client::module::DynClientModule, anyhow::Error>> + core::marker::Send), alloc::alloc::Global>>
             at /rustc/fc594f15669680fa70d255faec3ca3fb507c3405/library/core/src/future/future.rs:124:9
   6: {async_fn#0}<fedimint_client::secret::PlainRootSecretStrategy>
             at /home/okj/fedimint/fedimint/fedimint-client/src/lib.rs:1429:21
   7: {async_fn#0}<fedimint_client::secret::PlainRootSecretStrategy>
             at /home/okj/fedimint/fedimint/fedimint-client/src/lib.rs:1317:47
   8: {async_fn#0}
             at /home/okj/fedimint/fedimint/gateway/ln-gateway/src/client.rs:83:13
   9: {async_fn#0}
             at /home/okj/fedimint/fedimint/gateway/ln-gateway/src/lib.rs:677:13
  10: {async_block#0}
             at /home/okj/fedimint/fedimint/gateway/ln-gateway/src/rpc/rpc_server.rs:137:57
             ```

Resumed work on this item today...
@dpc I'm trying to understand this trace which tells me the gateway client built is not (en/de)coded properly, but I've not been able to figure out where exactly. I am adding WsClientConnectionInfo to gateway db, and ClientConfig to the client db, so I started looking there to figure out what the mishap could be.

Figured it out! I'd simply lost this oneline change in my refactors of client builder!

Question from dev call: will we still be able to instantiate the client if we've already downloaded the config and don't have internet access.

Yes. Clients stores a downloaded config in client DB. As long as we are reusing the same DB when offline, client builder instantiates the client without re-downloading config

Figured it out! I'd simply lost this oneline change in my refactors of client builder!

Sorry. Should have made panics more informative.
https://github.com/fedimint/fedimint/pull/2871

I didn't do a full review yet, but when trying to use the code I noticed it loops forever when receiving config it can't decode (particularly when joining the Fedi alpha federation with the current, incompatible code base). build should fail instead of looping indefinitely.

mysteriously broke lightning_reconnect_test in the latest iteration. debugging

There should probably also be a static function that allows checking if there is already config in the DB in cases where this isn't clear.

I'll hold off merging to give @justinmoon a chance to take a look.


Fix node resolving in React 16 adapter

I added a test relative to https://github.com/airbnb/enzyme/issues/1163#issuecomment-332438576
I tried to fix it but I couldn't figure out when to use alternate node.

@lelandrichardson It is probably not the cleaner way to do it but it fixes a huge bug. I think merging it and publishing a patch would be great!

Do you have a plan for what we need to expose on React side to remove this hack?

I was running into a an issue similar to https://github.com/airbnb/enzyme/issues/1153 so I followed @gaearon's advice and tried this patch out. It seemed to do the trick for me :+1:
I had to sprinkle wrapper.update() after dom-manipulating events and it worked fine for the most part.
Here is what I did to test this locally:

Cloned https://github.com/neoziro/enzyme.git
Switched to the react-16-updated-props branch.
Inside the cloned enzyme repo: lerna bootstrap && lerna run build
Then replaced the enzyme, enzyme-adapter-react-16, and enzyme-adapter-utils packages (in my node_modules directory) with the newly built lerna alternatives (in the packages directory).

I ran into an oddity where enzyme was throwing the following error:
Enzyme Internal Error: configured enzyme adapter did not inherit from the EnzymeAdapter base class

I assumed it was something weird related to how I built this package and so I just commented out the relevant lines in validateAdapter.js - https://github.com/neoziro/enzyme/blob/react-16-updated-props/packages/enzyme/src/validateAdapter.js#L16-L21

Do you have a plan for what we need to expose on React side to remove this hack?

@gaearon ideally React would expose a way to call toTree on an instance. This logic is already duplicated from the test renderer, so unifying and exporting it could mean that future adapters don't need to implement toTree themselves.

@neoziro thanks for hitting this! I think this is good and am going to merge. It puts us in a strictly better state than where we are now.
That said, I'm definitely interested in hashing out more details with @aweary and @gaearon around getting the react 16 adapter to a state where it doesn't depend on any internals. I agree with Brandon that this likely doesn't need to be much more than just exposing a ReactTestUtils.toTree(instance) or something like this. The function itself is kind of already built for the test renderer, but isn't publicly exposed.
Perhaps this wednesday (at react wednesday) could be a good time to hash out some of these details.
In the mean time, I'm going to merge this to get some people unblocked.
Oh, also, @marvinpinto the error you got is indicative of multiple copies of enzyme being installed in your node_modules directory, thus instanceof doesn't match between them.

@lelandrichardson you are welcome! It was a pleasure to help!