Add columnAnalyze example

Coverage remained the same at 15.51% when pulling 4a90e5a43ee1d7d144df6a427fa495875a33f4ac on develop into 1b1cd405dd96e796fd60da51f0bda7761cc2c674 on master.


MKOB: Playback controls for beginning/end of sender don't work

When testing the branch to fix #166 that changed windows updates to be message based;
@leskerr noted: The playback controls for skipping to the previous sender or next sender don't work.
Proper functionality is (currently) to move to the beginning/end of the current sender.

@leskerr added that: The station IDs in the capture file always show my own ID, no matter who's sending.

Latest changes fixed this.


Windows 11: Notifications vanishes after few seconds.

Please provide a brief summary of the bug
With previous version of Windows and JDK notification sticked in the Windows Notification Center forever until cancelled.
Since the latest Windows/JDK, notifications vanishes automatically after few seconds.
Code to reproduce the problem
import java.awt.*;

public class Main {
    public static void main(String[] args) throws Exception {
        SystemTray tray = SystemTray.getSystemTray();

        Image image = Toolkit.getDefaultToolkit().createImage("");
        TrayIcon trayIcon = new TrayIcon(image);
        trayIcon.setImageAutoSize(true);
        trayIcon.setToolTip("Demo");
        tray.add(trayIcon);

        trayIcon.displayMessage("Hello, World", "notification demo", TrayIcon.MessageType.INFO);
    }
}

Expected Results
Notifications sent from a TrayIcon should not vanish automatically after few seconds but should stay in the notification center until cancelled by the user.
Actual Results
Notifications sent from a TrayIcon vanishes automatically after few seconds
What Java Version are you using?
21.0.1
What is your operating system and platform?
Windows 11
How did you install Java?
MSI

https://bugs.openjdk.org/browse/JDK-8315647

@karianna thanks for the kind answer, I appreciate it.
I know that this isn't the best place where to open this issue but I don't know where to open it and I don't know where to start to fix it.
I want to thank you karianna and your team for the great work you are doing here and for the continued help you give to the community, this is much much appreciated.
People from OpenJDK closed this issue with a PASS status but it's obviously not passed since I can reproduce it in all my computers with various JDK versions and various Windows versions :)
I opened similar issue in past but my issues has been closed as well with a passed status.
it's sad to see that issues are closed without even testing them since sometimes opening them requires time...

I've added you use case to that issue to see if that helps them repro.

See https://bugs.openjdk.org/browse/JDK-8310352 - this is a Windows issue that will need to be reported to Microsoft.

Thanks for the answer karianna, I appreciate it.
One last question if possible.
Java is using a 30 years old API for the notifications.
The same API used in Windows 95 (Shell_NotifyIcon).
Microsoft released new APIs for Windows 11 (ToastNotification).
Is it correct to consider it a Windows issue?
Every other languages updated their APIs to use the new Windows APIs,
why Java still uses a 30 years old API for such an important feature like OS Notifications?

Thanks for the answer karianna, I appreciate it. One last question if possible.
Java is using a 30 years old API for the notifications. The same API used in Windows 95 (Shell_NotifyIcon).
Microsoft released new APIs for Windows 11 notifications. (ToastNotification).
Is it correct to consider it a Windows issue? Every other languages updated their APIs to use the new Windows APIs, why Java still uses a 30 years old API for such an important feature like OS Notifications?

Might be, I've updated the upstream issue with some MSFT learn docs on the new API

https://bugs.openjdk.org/browse/JDK-8310352 has been updated with a link to the new feature request for toast notifcations

hope to see it implemented in the near future, thank you for your help and for your super great work here karianna,
it is much appreciated.

https://bugs.openjdk.org/browse/JDK-8323821 for the new feature

something tells me that we will not see it implemented (for the next years) but thanks for linking the new feature request. :)


[Bug] Unable to find default config

Describe the bug
I installed Xenia Manager 2.0.0 today and couldn't find any way to adjust the default configuration.
To Reproduce
Steps to reproduce the behavior:

Go to Settings
Click on game list
See error

Expected behavior
A way to configure the default settings so I don't have to do it for every single game.
Environment Information

OS: Windows 11
App Version: 2.0.0

This is because of how per game configuration works now. Every configuration file is the "default" one because it's loaded up that way.

Ohhh okay. Thanks for the response though!


Count recoveredFundsReceiver for isRecoveryEnabled

Consider to improve the logic in isRecoveryEnabled
https://github.com/zkBob/zkbob-contracts/blob/944bcf5adad326283d369943559c3b76c6f6331f/src/token/Recovery.sol#L89-L91
The recovery is enabled if recoveredFundsReceiver is set and totalRecovery does not exceed the limit.

Addressed in f2a398fddee8f8903907bc739f0781c34b31232e, closing the issue


GL_INVALID_OPERATION when binding VAO when creating own framebuffer

Instead of passing a window handle to bgfx::init I'm creating my own frame buffer for a window handle. This triggers a GL_INVALID_OPERATION.
Running this on Ubuntu 24.04
To Reproduce
I've edited the Hello World example to trigger the GL_INVALID_OPERATION.
#include <bx/uint32_t.h>
#include "common.h"
#include "bgfx_utils.h"
#include "logo.h"

namespace
{

class ExampleHelloWorld : public entry::AppI
{
public:
  ExampleHelloWorld(const char* _name, const char* _description, const char* _url)
  : entry::AppI(_name, _description, _url)
	{
	}

	void init(int32_t, const char* const*, uint32_t _width, uint32_t _height) override
	{
		m_width  = _width;
		m_height = _height;

		bgfx::Init init;
		init.type = bgfx::RendererType::OpenGL;
		init.platformData.ndt  = entry::getNativeDisplayHandle();
		bgfx::init(init);
	}

	virtual int shutdown() override
	{
		bgfx::shutdown();

		return 0;
	}

	bool update() override
	{
		if (!bgfx::isValid(m_fbh))
			m_fbh = bgfx::createFrameBuffer(entry::getNativeWindowHandle(entry::kDefaultWindowHandle), m_width, m_height);

		bgfx::setViewFrameBuffer(0, m_fbh);
		bgfx::setViewRect(0, 0, 0, uint16_t(m_width), uint16_t(m_height) );
		bgfx::touch(0);
		bgfx::frame();

		return true;
	}

	uint32_t m_width;
	uint32_t m_height;
	bgfx::FrameBufferHandle m_fbh = BGFX_INVALID_HANDLE;
};

} // namespace

ENTRY_IMPLEMENT_MAIN(
    ExampleHelloWorld
	, "00-helloworld"
	, "Triggers an open gl invalid operation"
	, ""
	);

Additional context
OpenGL core profile version string: 4.6.0 NVIDIA 550.90.07
Think this is related to issue #209

You're using window handle that's already used for primary window...

I removed the nwh assignment so it's headless isn't it?

Alright I thought headless OpenGL was supported because I didn't get an error when I didn't pass in the nwh. I didn't realize it was getting the window handle somehow.
I created an offscreen window that I pass into init.nwh and that seems to work.

OK I've been playing around with this some more. I created on offscreen window to set as the initial nwh. Then later create a frame buffer for the window I actually want to render to. This still crashes when binding to the VAO.
I edited the example above, this should work right?


[#418] Add component: sidebar

Fixes #418
Start of a sidebar variant of the existing navbar
TODO:

new icons (add an svg icon sprite, so we can use <use>?)
Add a page layout as a separate organism, that the sidebar can be dropped into (start a section on page layouts, or repurpose the current page-content section?)

So far looks like:

Diverged too much, closed in favour of #445


The use of List and Tuple is vague in Tensorflow tf.data.Dataset.map.

System information
Have I written custom code (as opposed to using a stock example script provided in TensorFlow): no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.14.0
Python version: 3.7.3
CUDA/cuDNN version: 10.1.168 / 7.6.0 but also failing in CPU-only mode
GPU model and memory: GTX 1080 8G
Exact command to reproduce:
import tensorflow as tf
input = tf.constant([10,20,30])
ds = tf.data.Dataset.from_tensor_slices(input)
#Out: <DatasetV1Adapter shapes: (), types: tf.int32>

ds1=ds.map(lambda x: [x+1, x+2, x+3])
#Out: <DatasetV1Adapter shapes: ((), (), ()), types: (tf.int32, tf.int32, tf.int32)>
ds2=ds.map(lambda x: [[x+1, x+2, x+3]])
#Out: <DatasetV1Adapter shapes: ((3,),), types: (tf.int32,)>
ds3=ds.map(lambda x: ([x+1, x+2, x+3]))
#Out: <DatasetV1Adapter shapes: ((), (), ()), types: (tf.int32, tf.int32, tf.int32)>

I think tensorflow treats tuple as nested structures of Tensor and list as tensor, as shown in link.
However, tf.data.Dataset.map doesn't behave like this in above code. I expect ds1, d2, ds3 to be of shape [3, ], [1, 3], ([3, ], ) respectively,  rather than ((), (), ()), ((3,),), ((), (), ()) since top-level list [] should be treated as tensor rather than nested structure.
A solution is that I use tf.convert_to_tensor to force convert [x+1, x+2, x+3] to a single tensor but it's not elegant.
ps: It's confusing to output shape only with tuple, why not using list to represent shape and using tuple to represent nested structure of tensor jsut like
the output of Tensor.shape and Tensor.get_shape. e.g. #Out: <DatasetV1Adapter shapes: ([],[],[]), types: (tf.int32, tf.int32, tf.int32)>

@kzhangair
Is this still an issue

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


[Bug]: UnboundLocalError: local variable 'cwv_max' referenced before assignment for arm_diags plot with region `sgpc1

What happened?
There is a FIXME: comment to address this for awhile:
https://github.com/E3SM-Project/e3sm_diags/blob/2b303dfdf1a83b115a8f372a81bf2f6b3bfbbc68/e3sm_diags/plot/cartopy/arm_diags_plot.py#L177-L178
What did you expect to happen? Are there are possible answers you came across?
This occurs when the region is sgpc1. The conditional that sets cwv_max and other plotting variables don't consider this region:
https://github.com/E3SM-Project/e3sm_diags/blob/2b303dfdf1a83b115a8f372a81bf2f6b3bfbbc68/e3sm_diags/plot/cartopy/arm_diags_plot.py#L136-L156
Minimal Complete Verifiable Example (MVCE)
No response
Relevant log output
No response
Anything else we need to know?
No response
Environment
Latest main and cdat-migration-fy24 branch

Hey @chengzhuzhang, this bug has been around for a long time. I can now fix it in #842.
Do you have an idea what the values should be for cwv_max, cwv_min, bin_width, and sitename?

I think there is a typo:
https://github.com/E3SM-Project/e3sm_diags/blob/2b303dfdf1a83b115a8f372a81bf2f6b3bfbbc68/e3sm_diags/plot/cartopy/arm_diags_plot.py#L152
It should be
if region == "sgpc1":

Closed by #842


Ice Plus becomes unavailable

Reloading the integration recovers the state and becomes operational.

config_entry-smartthinq_sensors-3b263efb4c72c42c08d4581499aa354b.json.txt

I'm having a similar issue, but it's not just Ice. Other sensors will show no value (like temperature) or not update properly (like opening a door).
This error originated from a custom integration.

Logger: custom_components.smartthinq_sensors.wideq.device
Source: custom_components/smartthinq_sensors/wideq/device.py:173
Integration: SmartThinQ LGE Sensors (documentation, issues)
First occurred: May 19, 2022 at 11:28:19 AM (3 occurrences)
Last logged: 2:02:36 PM

Device ac6a1d30-4027-11ec-89cb-7440be77bae6 (REFRIGERATOR): Connection to ThinQ failed. Network connection error

This error originated from a custom integration.

Logger: custom_components.smartthinq_sensors
Source: custom_components/smartthinq_sensors/__init__.py:388
Integration: SmartThinQ LGE Sensors
First occurred: May 19, 2022 at 11:28:19 AM (2 occurrences)
Last logged: 2:02:36 PM

Status for device Refrigerator was reset because disconnected or unreachable

I know the error says it's a network issue, but I don't see drops to my oven or washer and dryer using the same connection and credentials.

Reloading the integration recovers the state and becomes operational.

Please provide HA logs related to the moment when entity becomes unavailable.

I know the error says it's a network issue, but I don't see drops to my oven or washer and dryer using the same connection and credentials.

If polling only to this specific device fails, probably means that WIFI connection for your refrigerator is unstable.

All I have at the moment is:

2022-05-24 07:53:57 WARNING (SyncWorker_10) [custom_components.smartthinq_sensors.wideq.device] Device ac6a1d30-4027-11ec-89cb-7440be77bae6 (REFRIGERATOR): Connection to ThinQ failed. Network connection error
2022-05-24 07:53:57 WARNING (SyncWorker_10) [custom_components.smartthinq_sensors] Status for device Refrigerator was reset because disconnected or unreachable

I'll turn on debug logs to see if there's more.

If polling only to this specific device fails, probably means that WIFI connection for your refrigerator is unstable.

Interesting thought. The fridge is basically in the same room as an access point (I have a few Unifi APs). The Unifi client list shows it as connected for over 4 days. I'll look into setting up a ping monitor.

A new bit; the fridge came immediately back online in Home Assistant when I opened the LG app on my iPhone. It had been unavailable in Home Assistant for over 12 hours.

Here's the debug logs. I wonder if pinging has changed things, because the fridge came back on it's own. tldr; I agree this is likely an issue with the appliance wifi connection and unlikely to be related to the integration. @elmillero can you check to see if your fridge is dropping off wifi too? If so, we can probably close this issue.
Here's my notes in case anyone else finds them helpful.

2022-05-24 23:12:36 DEBUG (SyncWorker_2) [custom_components.smartthinq_sensors] Updating ThinQ device Refrigerator
2022-05-24 23:12:36 DEBUG (SyncWorker_2) [custom_components.smartthinq_sensors.wideq.device] Updating ThinQ device ac6a1d30-4027-11ec-89cb-7440be77bae6 (REFRIGERATOR)
2022-05-24 23:12:36 DEBUG (SyncWorker_2) [custom_components.smartthinq_sensors.wideq.device] Polling...
2022-05-24 23:12:36 DEBUG (SyncWorker_2) [custom_components.smartthinq_sensors.wideq.core_v2] lgedm2_post before: https://aic.lgthinq.com:46030/api/rti/rtiMon
2022-05-24 23:12:36 DEBUG (SyncWorker_2) [custom_components.smartthinq_sensors.wideq.core_v2] lgedm2_post after: {'lgedmRoot': {'returnCd': '0106', 'returnMsg': '장치가 접속중이 아닙니다.', 'stateCode': 'F', 'deviceState': 'D', 'timestamp': 0}}
2022-05-24 23:12:36 DEBUG (SyncWorker_2) [custom_components.smartthinq_sensors.wideq.device] Device ac6a1d30-4027-11ec-89cb-7440be77bae6 (REFRIGERATOR) not connected. Status not available
2022-05-24 23:12:36 WARNING (SyncWorker_2) [custom_components.smartthinq_sensors] Status for device Refrigerator was reset because disconnected or unreachable
2022-05-24 23:12:36 DEBUG (MainThread) [custom_components.smartthinq_sensors] Finished fetching smartthinq_sensors-Refrigerator data in 0.258 seconds (success: True)

We can see a period of time where pings were not returned, but in this case the latency spike corresponds to an unavailable period. However, an hour later there was another drop, with the same log messages, but this time there is a gap in ping responses:

timestamp
source
message

2022-05-25T03:20:44.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 stahtd: stahtd[1999]: [STA-TRACKER].stahtd_dump_event(): {"dns_resp_seen":"yes","assoc_delta":"10000","message_type":"STA_ASSOC_TRACKER","auth_delta":"0","mac":"74:40:be:77:ba:e6","assoc_status":"0","vap":"ath1","event_type":"success","wpa_auth_delta":"60000","auth_ts":"367633.132411","ip_delta":"1180000","ip_assign_type":"dhcp","event_id":"1","arp_reply_gw_seen":"yes"}

2022-05-25T03:20:44.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 RADIUS: starting accounting session EA628305E03044AF

2022-05-25T03:20:35.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 : wevent[1998]: wevent.ubnt_custom_event(): EVENT_STA_IP ath1: 74:40:be:77:ba:e6 / <IP_ADDRESS>

2022-05-25T03:20:35.000Z
blackbox.lan
blackbox.lan dhcpd[62632]: DHCPACK on <IP_ADDRESS> to 74:40:be:77:ba:e6 (QCA4002) via igb0_vlan666

2022-05-25T03:20:35.000Z
blackbox.lan
blackbox.lan dhcpd[62632]: DHCPREQUEST for <IP_ADDRESS> (<IP_ADDRESS>) from 74:40:be:77:ba:e6 via igb0_vlan666

2022-05-25T03:20:35.000Z
blackbox.lan
blackbox.lan dhcpd[62632]: DHCPOFFER on <IP_ADDRESS> to 74:40:be:77:ba:e6 via igb0_vlan666

2022-05-25T03:20:35.000Z
blackbox.lan
blackbox.lan dhcpd[62632]: DHCPDISCOVER from 74:40:be:77:ba:e6 (QCA4002) via igb0_vlan666

2022-05-25T03:20:34.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 WPA: pairwise key handshake completed (RSN)

2022-05-25T03:20:34.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 /usr/sbin/lbd[1995]: <IP_ADDRESS>0043 LBDR wlanif   info : wlanifBSteerEventsHandleNodeAssociatedInd: Node 74:40:BE:77:BA:E6 associated on APId 255 ChanId 1   ESSId 1  , Capabilities:    SMPS, Max bandwidth: 0, Num of spatial streams: 1, PHY mode: 8, Max MCS: 7. Max TX power: 0, bandcap: 0

2022-05-25T03:20:34.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 WPA: received EAPOL-Key frame (4/4 Pairwise)

2022-05-25T03:20:34.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 WPA: sending 3/4 msg of 4-Way Handshake

2022-05-25T03:20:34.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 WPA: received EAPOL-Key frame (2/4 Pairwise)

2022-05-25T03:20:34.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 kernel: [367633.166581] ieee80211_update_node_ecm_flags: node with aid 1 and mac 74:40:be:77:ba:e6 has been tagged [ dvlan ]

2022-05-25T03:20:34.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 : wevent[1998]: wevent.ubnt_custom_event(): EVENT_STA_JOIN ath1: 74:40:be:77:ba:e6 / 1

2022-05-25T03:20:34.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 WPA: sending 1/4 msg of 4-Way Handshake

2022-05-25T03:20:34.000Z
garage
garage 802aa889a38e,UAP-AC-Pro-Gen2-6.0 /usr/sbin/hostapd[22816]: FT: f6:9f:c2:f4:8e:01 STA Roamed: 74:40:be:77:ba:e6

2022-05-25T03:20:34.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 IEEE 802.11: associated

2022-05-25T03:20:34.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 /usr/sbin/lbd[1995]: <IP_ADDRESS>6725 LBDR wlanif   info : wlanifBSteerEventsHandleSMPSUpdateInd: SM Power Save mode received from 74:40:BE:77:BA:E6 on APId 255 ChanId 1   ESSId 1  : STATIC

2022-05-25T03:20:34.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA f6:9f:c2:f4:8e:01 DRIVER: Send AUTH addr=74:40:be:77:ba:e6 status_code=0

2022-05-25T03:14:04.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 IEEE 802.11: deauthenticated due to local deauth request

2022-05-25T03:13:59.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 stahtd: stahtd[1999]: [STA-TRACKER].stahtd_dump_event(): {"message_type":"STA_ASSOC_TRACKER","mac":"74:40:be:77:ba:e6","assoc_status":"0","vap":"ath1","event_type":"sta_leave","event_id":"1"}

2022-05-25T03:13:59.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 : wevent[1998]: wevent.ubnt_custom_event(): EVENT_STA_LEAVE ath1: 74:40:be:77:ba:e6 / 1

2022-05-25T03:13:59.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 WPA: group key handshake failed (RSN) after 4 tries

2022-05-25T03:13:58.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 WPA: sending 1/2 msg of Group Key Handshake

2022-05-25T03:13:57.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 WPA: sending 1/2 msg of Group Key Handshake

2022-05-25T03:13:56.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 WPA: sending 1/2 msg of Group Key Handshake

2022-05-25T03:13:55.000Z
main
main f09fc2f38e01,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 WPA: sending 1/2 msg of Group Key Handshake

2022-05-25T03:10:35.000Z
downstairs
downstairs f09fc2706733,UAP-AC-Pro-Gen2-6.0 /usr/sbin/lbd[1994]: <IP_ADDRESS>9468 LBDR wlanif   info : wlanifLinkEventsCmnGenerateDisassocEvent: Client 74:40:BE:77:BA:E6 disassociated on APId 255 ChanId 11  ESSId 1

2022-05-25T03:10:35.000Z
downstairs
downstairs f09fc2706733,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA 74:40:be:77:ba:e6 IEEE 802.11: disassociated

2022-05-25T03:10:25.000Z
downstairs
downstairs f09fc2706733,UAP-AC-Pro-Gen2-6.0 stahtd: stahtd[1999]: [STA-TRACKER].stahtd_dump_event(): {"mac":"74:40:be:77:ba:e6","message_type":"STA_ASSOC_TRACKER","assoc_status":"0","event_type":"failure","vap":"ath1","event_id":"1","auth_failures":"2","auth_ts":"367484.519494"}

2022-05-25T03:10:15.000Z
downstairs
downstairs f09fc2706733,UAP-AC-Pro-Gen2-6.0 hostapd[2002]: ath1: STA f6:9f:c2:71:67:33 DRIVER: Send AUTH addr=74:40:be:77:ba:e6 status_code=0

Unfortunately group key handshake failed has only happened once in the past 7 days, so it's not the most significant cause of drops. I'm not seeing any other recurring errors during periods of drops - just the usual log messages that happen when a client drops and reconnects to the network.

A new bit; the fridge came immediately back online in Home Assistant when I opened the LG app on my iPhone. It had been unavailable in Home Assistant for over 12 hours.

This not so simple to solve. I understand now that you have a refrigerator based on APIv1, I suppose that this protocol have a kind of stand-by and for this reason you lost the connection. Probably the phone application send a kind of wake-up and this allow communication to be back available. You should try to intercept communication between phone app and LG cloud using a software like mitmproxy so that we can implement this inside integration. You should find some example on how this was already done looking at closed issue with higher number of posts.
Attach in any case here the integration diagnostic, just to check if I can found some interesting information inside JSON definition.

Here's the diagnostics: https://gist.github.com/deviantintegral/47664d84d230c80c2e4adb950d82d7d1
I'm familiar with mitmproxy, so I'm glad to get that set up. Hopefully they haven't implemented cert pinning on the iOS app recently.

When you create diagnostic, Ice Plus was available or not? Can you generate diagnostic files for both condition?

The above was a working state. Here's a diff showing going from a non-working state to it working after restarting Home Assistant:
https://gist.github.com/deviantintegral/7f17b0a9e9ea0f9b3894a69039d07ae3

I grabbed a capture, and ran it pausing requests to try to identify which one causes the fridge to come back. Unfortunately, it wasn't clear. Either there's some delay or it comes online due to multiple different requests.
How would you like to go from home? What I have has API tokens and credentials in it. If you think there's specific API calls to look at, I can extract and redact them. Otherwise, is there somewhere private or a secure method you'd prefer to send you the capture?

I’m still having this issue. I set up an automation to tell me when to reload the integration, but I don’t think it’s possible to do that automatically.

I'm updating to the latest now and will see if this comes up. I haven't seen anything in the changelogs saying it's fixed.


Update RLMProperty.mm

Drop #import "RLMObject.h". RLMObject_Private.h imports <Realm/RLMObject.h>. Hence RLMObject.h is transitively imported.
Import of RLMObject.h and <Realm/RLMObject.h> confuses clang and results in duplicate interface.
In file included from Realm/RLMProperty.mm:24:
In file included from Realm/RLMObject_Private.h:19:
Realm/Realm/RLMObject.h:66:1: error: duplicate interface definition for class 'RLMObject'
@interface RLMObject : RLMObjectBase
^
In file included from realm-cocoa/Realm/RLMProperty.mm:22:
realm-cocoa/Realm/RLMObject.h:66:12: note: previous definition is here
@interface RLMObject : RLMObjectBase
           ^

Note: This happens when using realm-cocoa with cococapods with the :path argument in the Podfile.

Thanks for the PR, @angerman! We'll need you to accept our Contributor License Agreement before we can merge your contributions.
Cheers,
The robots and humans at Realm

Only CI issue seems to be the duplicate iPhone 6 simulators on Xcode 6.4

@angerman we'll need you to sign the CLA before we can review this, thanks!

Closing due to lack of signed CLA.


Singular / plural issue with counters and many

Singular entry, plural entries, does that work with automatic counters and many relationships?

Fixed.


not showing collections Ubuntu 16.04, mongo 3.14.3

I have tried all permutations of more recent versions of gems : mongo, bson, bson_ext.
The latest gem versions that will actually load genghisapp in the browser are
mongo 1.12.3
bson 1.12.3
bson_ext 1.9.2  (there is no 1.12.3, and 1.12.5 doesnt work)
With above config (as well as all 3 on 1.9.2) the genghis app loads in the browser, but shows "0" for collections of all databases.
How to fix?
thanks
G

I can confirm this on Linux Mint (19 Tara - x86-64) with the versions:
bson (1.9.2)
bson_ext (1.9.2)
mongo (1.9.2)
Versions for GenghisApp:
'genghisapp' 2.3.11
rack 1.3
sinatra 1.4.8
vegas 0.1.11
I have installed mongodb in the current version (4.0.0)
The GenghisApp loads in the browser but shows "0" for collections of all databases.
You can manually add a new collection in GenghisApp for existing collections and it shows the correct amount of documents in the collection.
If you try to open the collection you get redirected to an error page.
There is no '--auth' option set on mongodb.
I think it's maybe some sort of authentification error.
My browser (firefox) information shows me the following debugger information:
{"id":"test_database","name":"test_database","count":0,"collections":[],"stats":{"db":"test_database","collections":1,"views":0,"objects":2,"avgObjSize":138.0,"dataSize":276.0,"storageSize":16384.0,"numExtents":0,"indexes":1,"indexSize":16384.0,"fsUsedSize":585996488704.0,"fsTotalSize":983433551872.0,"ok":1.0}}
I also get some errors for passing empty strings to getElementById() in the script.js.
Hope that information help.
Any information to fix this are welcome.

Maybe guys should try Mongoku, a new, more modern Web-based client for Mongo, inspired by Genghis:
https://github.com/huggingface/Mongoku
It's built on Node.js (using Typescript) and Angular.
I'd be surprised if it didn't solve your issue.


Fully redisassemble repo

Now works with devkitPro r40+
Fully split with all visibility info, symbols and types from original .elf
Fully shiftable
Various improvements to build system

I integrated my project decomp-toolkit, which is now used to fix powerpc-eabi-as object files to work correctly with mwldeppc. It also provides sha1sum and elf2dol, so those now use dtk.
Things left to do:

[ ] Re-organize new asm files into directories
[ ] Split COM symbols, they're currently stuffed at the end of one of the files.

They'll be moved to individual files in the form of .comm name, size, align (align will be 4)

[ ] Update compiler flags

Use -common on for main source files (global BSS variables are pushed to the end of .bss and deduplicated)
Use -sym on for main source files (affects function ordering & generates multiple .text sections)

[ ] Verify matches for src files and re-link them (objdiff will help)
[ ] Fix progress calculation

Really good stuff here, thanks for the PR. I think this will help a lot with getting this project moving again. I'm curious about what some of the new ASM files are for (renderware?) but not going to look too closely until the PR is ready for review.

Not sure yet, all the unit names were extracted from the .elf, which doesn’t provide anything more than just the filename.
I could use help from project maintainers to finish the to-do list. In particular, assisting with organizing the asm and updating src files to match.

Yes, I will work on your TODO list and try to help. This week is going to be very chaotic for me as I am wrapped up in traveling but once I'm back in the US I should have a good amount of time to sit down and get things organized over the holidays

I get an error during the make process:
\bfbb> make
 AS      asm/xAnim.s
asm/xAnim.s: Assembler messages:
asm/xAnim.s:4477: Error: unknown pseudo-op: `.bss'
make: *** [Makefile:152: obj/asm/xAnim.o] Error 1
```

It's likely you'll need to update to the latest devkitPro.

I was just using the built-in directives where possible, it generates slightly better output from the assembler. But my elf fixup step already unifies the output, so it’s fine to use either.

Nice, your most recent fixes work fine for me and it also now passes the CI build.
I'm wondering what our goal should be before we merge this. This undoubtedly needs to become our working branch now. We can merge it now and work on integrating our C++ code back into it, or we can figure it all out before merging it to master. @seilweiss thoughts?
I don't think it particularly matters which order we do it in. One thing I want to do is have a similar workflow that will enable us to decompile functions out of order. Now instead of inlining the raw bytes like the old way we could have a similar pre-processing script but this time it actually patches in the real ASM instructions in the C++ source. I really like keeping as much junk out of our CPP source files as possible

Do we need to remove the decomped functions from the ASM again or is progress tracked differently now?

Do we need to remove the decomped functions from the ASM again or is progress tracked differently now?

I forgot to mention this in the TODOs as well, this breaks the existing method of calculating progress. I'm attempting to figure a better solution.

""LINK    main.elf
Identifier "x\0A\0n\0i\0m\0.\0o\0" was not in the list of identifiers passed to GnuBuilder::new()
make: *** [Makefile:145: main.elf] Error 1""
i got this error

That’s fixed in dtk v0.2.3, update dtk_version file

That’s fixed in dtk v0.2.3, update dtk_version file

do i download "dtk-windows-x86_64.exe" or "dtk-windows-arm64.exe"?

thanks it works now

well it seems like it didnt do nothing with the src/game code or im just dumb

This branch isn't configured to build our C++ source yet. It is a 100% assembly build. We are still in the process of getting this branch to work with our C++ source

oh ok

I'm getting the following error when building this after a fresh install, not sure what exactly is going on:

LINK    main.elf
Identifier "x\0A\0n\0i\0m\0.\0o\0" was not in the list of identifiers passed to GnuBuilder::new()
make: *** [Makefile:145: main.elf] Error 1

That’s fixed in dtk v0.2.3, update dtk_version file

My mistake, I should pay more attention to the comments in this thread 😅 Sorry.

Merging this now to work off of this as our main branch and will fix the issues as we run into them.


JObject.Merge does not with object

newtonsoft 12.0.3, I notice the JObject.Merge (object) but it does not work, it can only merge with a JObject.
public class Foo
{
        public string x { get; set; } = default!;
        public string y { get; set; } = default!;
}

JObject jSource = JObject.Parse (@"{ ""x"" : ""original"",   ""y"" : null }");

updateFoo = JsonConvert.DeserializeObject <Foo> (@"{  ""x"" : null, ""y"" : 3 }", new JsonSerializerSettings
{
   DefaultValueHandling    = DefaultValueHandling.Include,
   MissingMemberHandling   = MissingMemberHandling.Error,
   NullValueHandling       = NullValueHandling.Include,
});

jSource.Merge (updateFoo, new JsonMergeSettings
{
    MergeArrayHandling      = MergeArrayHandling.Replace,
    MergeNullValueHandling  = MergeNullValueHandling.Merge,
});

Expected behavior
jSource { "x:" null, "y" : 3 }
Actual behavior
jSource { "x" : "original", "y" ; null }
There is no error. It works fine if I change updateFoo to a JObject. Is it supposed to work with object or only JObject, if latter, who not declare as   JObject.Merge (JObject)

We're running into this as well.


Remove Timeline screenshots for MSIT env

@savvinsergey,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


the enable copy button in the toolbar is useless for me...

i've never had to use it on the phone...
i wonder if on the laptop it is more useful.
in any case, since we are always providing
the link to the original article, the reader can
in those very rare cases when they need it to
open the original and select there.
and the icon is also misleading: heard multiple times
people thinking that it's a copy/paste button.
i'd vote for removing it, together with its functionality.
or finding a better icon.
what do you think?

I also never used it, and students seemed to not find it that useful either... I think we can find a better use for the space it is occupying (or for now remove it).

i just used it now... still rarely... if we find a more expressive icon, that would say select instead of copy... maybe we could still keep it...

We also have this material design icon for selections:

i was also thinking about a disable-touch mode button as a possibility


#70 Issue 70

The following commands can be used on the CM to rollback to a particular stage. The rollbacks also do the needful on LC nodes.
puppet apply -e "simple_grid::deploy::config_master::rollback"

puppet apply -e "simple_grid::pre_deploy::config_master::rollback"

puppet apply -e "simple_grid::config::config_master::rollback"

fix #70


Offer "encryption" out of the box

What's your idea?
The idea to somehow "encrypt" or "encode" the parameters came up multiple times now, for one of two reasons:

Decrease URL length for concerns of "hitting a limit" (specifically in IE)
Security concerns in real-life projects

We should consider how we could support this if this is a frequent use-case.
Describe the solution you'd like
Two possible solutions:

Offer pre-built functions to "secure" the data. The advantage is a small API surface and flexibility of offering different mechanisms, e.g. with varying levels of security (simple encoding all the way to some proper encryption)
Implement a new configuration option on QueryParam level.

Additional context
This is currently possible by providing custom (de-)serializers, but requires the user to do it manually everytime.

We should consider how we could support this if this is a frequent use-case.

I have gotten this question several times now, so there's definitely a need for it. :-)


Getting translation issue on the bottom of the customer registration form.

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
master
Issue Description
Getting translation issues on the bottom of the customer registration form.
Preconditions

Needs to visit Shop.

Steps to reproduce

Go to 'Shop'
Click on 'SignUp' inside the Account option
Scroll down to 'bottom'
See the error

Expected Result
It should be shown the proper content.
Actual Result
getting translation issues. Here
Screenshots
No response
Additional context
No response

Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.


include in TechEmpower Framework Benchmarks

Hi,
I saw a lot good web server in there and it will be great if uWebSockets.js is also listed.
website: https://www.techempower.com/benchmarks/
github: https://github.com/TechEmpower/FrameworkBenchmarks

No, that is a common request. I do not recommend anything TechEmpower. They are incompetent and cannot properly handle fast servers. No discussion thanks.


feat(order-cancellations): add support for listing Order Cancellations

The Order Cancellations API supports listing order cancellations - optionally filtered by order ID.
This makes that functionality available in the library, with both manual pagination (list) and auto-pagination (listWithGenerator).
This gap in the library was reported by an integrator via a support ticket.

I can't get a bunch of tests to pass locally due to output like this:
 FAIL  src/booking/OrderCancellations/OrderCancellations.spec.ts
  ● Test suite failed to run

    Cannot find module 'node:http'
    Require stack:
    - /Users/timrogers/Projects/duffel-api-javascript/node_modules/jest-runtime/build/index.js
    - /Users/timrogers/Projects/duffel-api-javascript/node_modules/jest-runner/build/testWorker.js
    - /Users/timrogers/Projects/duffel-api-javascript/node_modules/jest-worker/build/workers/processChild.js

    Require stack:
      node_modules/jest-runtime/build/index.js
      node_modules/jest-runner/build/testWorker.js
      node_modules/jest-worker/build/workers/processChild.js

      at Runtime._requireCoreModule (node_modules/jest-runtime/build/index.js:1772:12)
      at Object.<anonymous> (node_modules/node-fetch/src/index.js:9:1)

But it seems to be fine in CI! 🧡


Add function get_cnv_and_ssm_status

Discussed in this Slack thread.

Sorry, but not yet. I'll address all issues I'm assigned after finishing a function that I'm writing. If this is okay for you.


Extend CMake functions for reuse in other Cartographer subprojects.

This is related to https://github.com/googlecartographer/cartographer_ros/pull/100


Add support for miniBill/codec

@miniBill you can now generate your codecs with elm-review-todo-it-for-me!

Looks good but I would be happier if there was a test (even something simple like FuzzerCodeGenTest.elm). See the docs for  fakeDependency on how to generate that value.

Oops, yes got excited and forgot the boring details. Will fix in a moment.

I copied the elm-serialize tests and changed them to fit elm-codec. Only two tests are still failing. For some reason Maybe isn't being detected as a core type and code gen is generating a maybeCodec instead of using Codec.nullable.


Error: The selector "" did not match any elements after reload

I created my own webpack config using angular2-hmr-loader. The build works fine, the page loaded by webpack-dev-server successfully. But after a first change and first reload the root element (<main-layout>) missing from the index template so I got an error about the selector did not match any elements.
I'm using the html-webpack-plugin with index.html as a template.
I don't use angular2-hmr yet, I already wrote before my exactly same bootloader(...) function. I don't use any store logic so I think I don't really need it.
Here is the relevant part of my webpack config file:
{
    context: folder.source.path, //d:/dev/project1/source/
    entry: {
       engine: [...], //all project deps, angular2, rxjs, ng-semantic
       polyfill: [...], //all polyfills, including ts-helpers
       project: './script/main.web.debug'
    },
    output: {
        path: folder.deploy.path, //d:/dev/project1/deploy/
        filename: 'script/project.js', //prefix script/ because index.html should be one folder up.
        chunkFilename: 'script/project.[id].js'
    },
    module: {
        loaders: [{
            test: /\.ts$/,
            loaders: [
                'awesome-typescript-loader',
                'angular2-template-loader',
                '@angularclass/hmr-loader'
            ],
           exclude: [/\.(spec|e2e)\.ts$/]
         },
         { test: /\.css$/,  loader: 'raw', include: source_code }, //d:/dev/project1/source/script/
         { test: /\.html$/, loader: 'raw', exclude: source_html }, //d:/dev/project1/source/index.html - EXCLUDE!

       ]
    },
    plugins: [
         new HtmlWebpackPlugin({ template: '!!ejs!'+source_html }),
         new webpack.HotModuleReplacementPlugin(),
         new webpack.optimize.CommonsChunkPlugin({
            names: ['engine', 'polyfill'],
            filename: 'script/[name].js'
        })
    ],
    devServer: {
      port: 3000,
      hot: true,
      watch: true,
      quiet: true,
      noInfo: true,
      inline: true,
      stats: 'minimal',
      contentBase: 'source',
      historyApiFallback: true,
      watchOptions: { poll: 1000, aggregateTimeout: 300 }
    }
}

Here are the relevant package versions:
"@angular/<all>": "^2.0.0",

"@angularclass/hmr-loader": "^3.0.2",
"angular2-template-loader": "^0.5.0",
"awesome-typescript-loader": "^2.2.4",
"html-webpack-plugin": "^2.22.0",
"typescript": "^2.0.2",
"webpack": "^2.1.0-beta.22",
"webpack-dev-server": "^2.1.0-beta.4",

Finally I figured out that I need to use angular2-hmr too. It was so confusing to me of mixing store and hmr concept.


Timeline hover has empty line

VSCode Version: 1.44 Insiders
OS Version: Windows

Found while testing #93819
When you hover over a Timeline item, the hover displays an extra empty line between the timestamp and comment.

Is this line filled in certain scenarios? It looks odd to have an empty line.

Looks like extra line per line break

That is intentional -- I added a line break between the "meta-data" section and the commit message. And the commit message will render with any of its own line breaks.


Cannot find module '../../package.json'

Trying to import package.json using latest version of ionic-app-scripts (0.0.36) gives a compile error.
[12:56:05]  transpile started ...
[12:56:06]  lint started ...
[12:56:14]  typescript: src/app/app.config.ts, line: 2
            Cannot find module '../../package.json'.
[12:56:14]  transpile failed

       L1:  import { Injectable } from '@angular/core';
       L2:  import p from '../../package.json';

Couldn't find an example in @danbucholtz mega test project that imports a json file.
Also adding .json to rollup.config.json nodeResolve extensions does not help.
    nodeResolve({
      module: true,
      jsnext: true,
      main: true,
      browser: true,
      extensions: ['.js', '.json']
    }),

Hello, thanks for using Ionic! Would you mind installing the latest beta release of app-scripts by running npm install @ionic/app-scripts@beta --save-dev and trying this again? That release uses webpack by default which should handle this better out of the box than rollup.

Hi @jgw96, I have no problem trying out app-scripts beta, but it is my understanding that you will not drop rollup for webpack, but offer it as an alternative. Is that not the case?
If so I would think solving rollup issues is still important. If you are dropping rollup for webpack, then it makes sense to stop trying to work around issues.

I can confirm that using latest app scripts 0.0.37 I can use require imports to include package.json.
const p = require('../../package.json');

not really ES6, but I guess will have to do for now.

Hello @masimakopoulos You are correct that we still offer rollup as the alternative and will continue to develop both the rollup part of app-scripts and the webpack part of app-scripts. The reason I mentioned trying webpack is because importing JSON files is not supported by the ES6 module spec, which rollup follows strictly. Webpack however does allow things like importing json files as it follows the non-standard commonjs spec instead. If you would like to continue using rollup (which does provide slightly smaller/faster bundles than webpack) i would recommend loading json files with the http module in Angular 2 instead of importing them. Thanks!

@jgw96 just to clear things up a bit, I am now using webpack and the import works using require instead of import. Also I believe what you are stating about rollup not being able to load json files through imports is incorrect.
The rollup documentation on the section about plugins actually has an example that uses the rollup-plugin-json plugin to load package.json using es6 syntax.
import { version } from '../package.json';
export default function () {
  console.log('current version is ' + version);
}

as long as you enable the plugin
import json from 'rollup-plugin-json';

export default {
  entry: 'src/main.js',
  format: 'cjs',
  plugins: [ json() ],
  dest: 'bundle.js'
};

And in this projects package.json I see you are actually listing this plugin in dependencies and you are actually enabling it in the default config so this should work out of the box, but it doesn't.
Is there something I am missing?


scaleDiverging for domain [1,1,0] produces wrong results

The d3.scaleDiverging Method returns wrong results if the domain is reverted and the left domain border is equal to the midpoint.
const s = d3.scaleDiverging().domain([1, 1, 0]);
for (const i of [-0.5, 0, 0.25, 0.5, 0.75, 1, 1.5]) {
    console.log(i, s(i));
}
/* prints
-0.5     0.5
 0       0.5
 0.25    0.5
 0.5     0.5
 0.75    0.5
 1       0.5
 1.5     0.25
*/

Having the domain sorted and applying 1-x to the scale produces the expected results:
const s = d3.scaleDiverging().domain([0, 1, 1]);
for (const i of [-0.5, 0, 0.25, 0.5, 0.75, 1, 1.5]) {
    console.log(i, 1 - s(i));
}
/* prints
-0.5     1.25
 0       1
 0.25    0.875
 0.5     0.75
 0.75    0.625
 1       0.5
 1.5     0.5
*/

I encountered this because I wanted to use the RdBu colormap and map values [0,1] to [0.5,1] (blue part) and [1,max(data)] to [0, 0.5] (red part):
const colorMap = d3.scaleDiverging().domain([Math.max(maxValue, 1), 1, 0]).interpolator(d3.interpolateRdBu);

and had to change it to this:
const colorMap = d3.scaleDiverging().domain([0, 1, Math.max(maxValue, 1)]).interpolator(x => d3.interpolateRdBu(1 - x));

I use<EMAIL_ADDRESS>

Right, diverging scales don’t currently support reversed (or “descending”) domains. We’d need to add that feature.


Update/feat web3js

Breaking Changes
N/A
Changes

feat:
fix:
chore:

Associated Issues
closes #...

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 12 committers have signed the CLA.:white_check_mark: xiaoxianBoy:white_check_mark: luu-alex:x: chris13524:x: lukaisailovic:x: enesozturk:x: tomiir:x: ganchoradkov:x: tien:x: gooxpf:x: phoenixVS:x: nikosrossolatos:x: svenvoskampYou have signed the CLA already but the status is still pending? Let us recheck it.


AS5600 module came with a resitor between PGO and GND

I spent several hours trying to change the output mode to PWM. Both with the library and bare I2C. Actually, the output wasn't working at all. I discovered that the module has a resistor between PGO and GND, and that it was causing the AS5600 to disable the output (to use it for programming, check datasheet). This resistor needs to be removed to use the out pin.
This obviously has nothing to do with the library, but I think it could save some people a lot of trouble if you would add a disclaimer/warning somewhere in the README (under the OUT pin section) for people to check whether this is the case, and to remove the resistor if they intend to use the out pin.

Thanks for this info, I will add it ot the readme

Added section below in readme.md file.
Will be part of the next version.
Thanks again for this info.

Note: (From Zipdox2 - See issue #36)
Some AS5600 modules seem to have a resistor between PGO and GND.
This causes the AS5600 to disable the output (to use it for programming, see datasheet).
This resistor needs to be removed to use the OUT pin.


Destroy

I need "accordion" only for tablets(mobile), how to remove it when the desktop version ("destroy" -not working)?

You are using destroy like this and it doesn't work?
$("#demo1").navgoco('destroy');

yes


C# Sample not working as documented

The provided C# sample results in the following AAD error "AADSTS50011: The reply URL specified in the request does not match the reply URLs configured for the application: '55747057-9b5d-4bd4-b387-abf52a8bd489'."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 62886f64-db39-73f2-a7bf-05336bdbef73
Version Independent ID: 5325ef4c-c584-d242-b201-1a3466904a5f
Content: Silent install Azure Active Directory Application Proxy connector
Content Source: articles/active-directory/app-proxy/application-proxy-register-connector-powershell.md
Service: active-directory
Sub-service: app-proxy
GitHub Login: @kenwith
Microsoft Alias: kenwith

@trevonmckay, Thank you for your feedback . We will investigate and update the thread.

@trevonmckay,  Could you enable verbose and decode your code to verify if following ReplyAddressValue "https://login.microsoftonline.com/common/oauth2/nativeclient" being generated by PublicClientApplicationBuilder.WithDefaultRedirectUri Method? because this must be value used as redirect_uri during authentication.

Reference:
https://docs.microsoft.com/en-us/dotnet/api/microsoft.identity.client.publicclientapplicationbuilder.withdefaultredirecturi?view=azure-dotnet
https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/wiki/Default-Reply-Uri

We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.
#Please-close


Roadmap

I've seen the milestones, and think it's worth laying out what I think is left, for present and future contributors, before we release (the ever elusive) 1.0? Feedback welcome!

OSM Elements: I think we can take our cue from the OSM Concepts adopted by imposm-parser

[ ] Provide Support for Relations
[ ] Query API (for filtering of osm-elements/tags/etc - previous discussion here)
[ ] Data Structures -- my preference is towards reasonable and concrete data types, and to add abstractions only when necessary (some discussion here and here)

Interfaces for interoperability with other Packages

[ ] Plotting/Visualization: maybe Gadfly/Compose/GraphViz, apart from Winston

[ ] Routing/Algorithms: to use JuMP, or maybe even OSRM, apart from Graphs. Also, FastGraphs seems to be developing rapidly.

[ ] File IO:

[ ] XML Parsing: LibExpat versus LightXML (or maybe just settle on one -- discussion here)
[ ] Support other file formats: GeoJSON and Shapefile
[ ] interface to the Overpass API?

Beyond 1.0, since this has always been an experimental kind of repository, I think it's worth having a look at our python neighbours for inspiration:

[ ] Pandana (example here), and
[ ] GeoPandas (example here)

I think it makes sense for Buildings/Features/Highways to return DataFrames, with columns corresponding to tags/etc, rather than the existing Dicts that we use.
@kjordahl @jwass @fscottfoti

This looks great.
PBF as another possible format (it would be especially nice right now, with strings being costly, but that should be improved at least in 0.4)?
Speed limits.

I agree these look like good features to add. A couple comments on the features:
*I would also like speed limits, and also elevation data (I used LLA format, but OSM doesn't provide the altitude).
*I'm not really sure that I see the need for other visualizers. I see value in more detailed map rendering, but I'm not sure why we should duplicate capability.

I have thought about adding an interface to the Overpass API, but for my own use cases, using the XML files works better (I don't want my map pulls to change). That certainly doesn't mean we shouldn't have it, I just don't have a need for it, personally.
Interfacing to a real routing engine like OSRM sounds cool and valuable, but I think it should be in a separate add-on package, so that OpenStreetMap.jl doesn't require additional dependencies or compiling.
I haven't used DataFrames. I'm not opposed to the switch, but I'm also not sure of their value here.

In general, I would prefer for OpenStreetMap.jl to be an easy way to parse OSM data and perform basic tasks with it, to serve as a starting point for anyone wanting to work with OSM data and a central hub for OSM-related packages by defining common data representations. Then fancier routing could be performed with an additional package, or detailed map tile rendering with a separate package. But OpenStreetMap.jl will help you get your data loaded, converted into the coordinate system you prefer, cropped to a region and filtered, combined (e.g., add speed limits and elevations), allow you to perform basic capabilities like find the drive time regions or find a driving route, and give you a quick visualization of the results.
I think I have a slightly different view on versioning than others, but in my view, many of the features you mentioned could be released as versions 1.1, 1.2, etc, leading up to version 2.0. The only thing that I really think is worth waiting for on version 1.0 is making sure we have settled on our data formats and function interfaces for the core tasks. I'm not convinced we're there yet, but we're close. Also, I'm not sure whether it's considered to be in poor form to have version 1.0 when Julia hasn't even hit 1.0 yet. But I think that as soon as we hit version 1.0, we will be making a declaration about stability, and more people will be willing to use the package. Basically, I don't want Version 1.0 to be ever-elusive. I also think that once we get the core functionality, the package can probably be mostly "done," and most additional features will probably fit better in add-on packages.

I have to say, I'm not as convinced we're close to 1.0. I'm not saying the interfaces are bad, or that we have to wait until Julia and all the packages we rely on are 1.0 to go there ourselves. Just that:

it would be strange to go 1.0 before Julia or any of the packages we rely on go 1.0

we often return the data structures they create / make available, so the stability promise that we would not change any of those things without making a major version bump seems both unkeepable, and like an unacceptable burden on development of this and complementary packages

none of the most popular packages, packages with 1000 commits, packages with dozens of contributors, are at 1.0, or likely near it
from the last couple comments (and I'm in the same place) there's a lot in the air about what should end up in what packages even
I think the interfaces will likely benefit benefit if they get a couple rounds of updates over time

My hope would be for the roadmap to be the goal and not the number. I don't think forcing the package to have multiple development branches, with new or split out packages having to keep in sync with the more obscure branches rather than release (and be hard to release themselves as a result), would be a good situation, especially with only a few developers.
The conversation around functionality and scope of packages seems great to me, and I think we should flesh out priorities and timelines, just perhaps without 1.0 presumed to fall so early in it. (I'm also not saying robustness and stability and full-featured-ness and improved APIs should be pushed off.)

Rather than editting the original comment, I think I'll just reply here, so that your replies still make sense to subsequent viewers --
Yeah, I agree with the both of you: let's frame the discussion as goals for subsequent "minor versions" (increment by 0.1), rather than 1.0 then? I think feature releases (that doesn't break/deprecate anything) should actually be released as patches (see the example by JuMP), which we haven't been following so far.. Our previous milestones should really have been patches instead?

Regarding features:

we should include speed limits and elevation data then (are they provided in OSM though?)
I'm not familiar with the PBF format, but sure! There's also lots of other formats: WKT, GTFS. The emphasis on GeoJSON is because it seems to be the de facto format for web maps. I included shapefiles because I commonly work with them too, and julia has an existing package for parsing it.
just thought I should mention: it took me quite a while to figure out how to get the osm extracts that I'm interested in, and

the interface to the Overpass API is a big deal for people who want the latest changes/features in OSM. We could
we could perhaps provide convenience functions for people to fetch metro extracts from mapzen too (see their github repo)

regarding the use of DataFrames, I think their value is better understood through the examples by geopandas and pandana. We don't seem to use features/buildings much, so we're ambivalent either way. But for people doing urban studies/simulations, I think it makes sense to "query" (i.e. what we've been doing so far by providing keyword arguments and filtering) OSM data, and get results back in the form of a table (hence a DataFrame), for subsequent processing in the data-analysis pipeline.

All the stuff on "interoperability with other Packages" is not a priority (to me) at this point, so they might seem like over-engineering at this point. I'll try to explain the motivation for them, using plotting/visualizations as a running example:
I like the default styles we have, but it's not clear to me how to conditionally plot objects (buildings/highways) in a modular/composable way, apart from

"removing those objects and re-plotting" (which btw might be made easier if we work with DataFrames, rather than Dicts),
"write the logic of selecting the objects you want to plot, and then plotting them (which is what we do right now, but would get more and more complicated when we deal with more osm attributes/objects)" or
"export those objects (since you have the data right?), and plot it yourself (and lose all the nice styling defaults in OSM)"

I had thought of re-writing it in Compose/Gadfly (as an exercise), and there are immediate benefits, like the ability to export to alot more formats:

PNG, Postscript, PDF, SVG. The SVG backend uses embedded javascript, powered by Snap.svg to add interactivity like panning, zooming, and toggling"

and would be helpful for web mappers. Which made me wonder about maintaining support for Winston, and the possibility of allowing for other plotting engines (if we want to support both Gadfly and Winston, might as well get it right the first time right?).
We've gone through the same experience with xml parsing, which is why I think it's worth bringing it up again. The immediate way forward would just to be a lot more careful about reducing the internal coupling of the functions we write with the libraries that we use (which wasn't the case with XML parsing, and isn't the case with plotting, and routing). That way, if we move towards a model of allowing extensions to be built upon OSM, it'll become easier to define abstract interfaces for the various extensions to implement.

@yeesian I agree about what you say about decoupling, and what we should think hard about, but I think rather than making interoperability not a priority, it means it's a bigger deal.
Being able to factor things out into packages at will gets more important, as does making sure experimental packages can be based off our master branch.
For example, I think we're on the same page about this, but the last PR would have had to wait until 2.0 if we were at 1.0 right now, in a branch that creates double work to keep up with bugfixes and and features on master, and other functionality developers wanted to be based on the current/future state of the ecosystem rather than the past, would have to interoperate with an unpublished, untagged branch of our package. It also would have been a pain if we weren't willing to deprecate APIs quickly in the name of coherent building blocks.
More relevant, various functionality for updating, subsetting, analyzing geospatial, representing geospatial data will likely move across package boundaries as we experiment with the roadmap items you and Ted mentioned, and updating the interfaces at function and package boundaries as new use cases comes up, seems critical.
Anyway, that doesn't counter anything you said -- I just wanted to bring it up in case is spurs any discussion about belongs in and out of this package, and how to get there with the least friction given we probably don't know yet. Specifically because Ted mentioned not everything belongs inside this package, and you didn't seem to be thinking about complementary packages, though your interfaces approach seems right for it.
Maybe the will be a lot of things too tightly coupled to OSM's specific data format to move them out, and what we'll be moving out are more of the building blocks, like how to draw generic points and ways and features to any backend in a composable way, with an OSM wrapper staying in the package.
P.S. Thanks for linking so heavily in recent issues -- I'm learning about a lot of new projects, and remembering discussions I had forgotten about, thanks to you.

Oh, agreed on releasing more patchlevel versions.
Speed limits exist for a significant minority of roads. I think Ted knows more about elevation, but sounds like it's a very small minority, and people integrate other data sources when they need it?

Versioning
First, I want to say I agree with Sean on versioning. And I'm uncomfortable with going to version 1.0 before Julia does. However, just because we don't have 1000 commits doesn't mean, to me, we are versioning too fast. It just means that the functionality we're providing probably isn't as complex. And I think the interfaces need time to settle.
I think that the versioning so far has been accurate, and I disagree that the releases so far should have been patches. I've been going off the Semantic Versioning Guidelines, which was suggested in my original Metadata pull request. It looks like JuMP is following this, as well, but maybe we should also have a news page at some point. I agree we should frame the milestones in terms of minor versions. I think we should push out patches when necessary, but never as a milestone. I would love to nail down the core API and release version 1.0, but I think that's a way off. But in my mind, the only thing required of version 1.0 is stabilizing the API, not any additional features.
@garborg I see you posted as I was writing. But I definitely get what you mean about the multiple branches, and I don't want to have to keep up with that. All I really meant was that if we know for certain we can lock down the API, then I think we're ready for version 1.0. But we're a ways away from knowing that yet. But if Julia, LibExpat, Winston, and Graphs all bumped to version 1.0 tomorrow, I'd suggest we focus more on API stabilization than we are currently and work towards version 1.0.
Additional Features

Speed limits are only occasionally available in OSM. We would need to get this from another database if we were going to use them for routing, but I haven't looked into it very much. There are global elevation databases, but they are pretty big files so I ended up not dealing with them. I don't know of a way to query a database to give us the elevation profile of just a Bounds object, for example. As a navigation person, I'll admit it drives me nuts that elevation changes aren't incorporated when we compute distances between nodes.
I certainly agree that integration with Overpass would be a valuable inclusion. I had a ton of difficulty learning that the first round, but I tried to include simple directions in our own documentation. Did you happen to see those, and did they help?
DataFrames do sound nice, thank you for explaining.

I like that Julia packages tend to be focused, and the awesome repository system makes it easy to have dependencies. I think we could basically have "modules" that exist as separate packages for specific tasks, and link to them all from the OpenStreetMap.jl main page, or Geodesy.jl. I think that anything requiring additional source dependencies should be modulized, so the average user doesn't have to worry about compilation issues, etc.
Map Plotting

Winston can export in JPEG (barf), PNG, PDF, and EPS. I use EPS for everything. I'm not sure if it can do SVG or not.
Plotting is slow, which I'm not crazy about, but I'm hoping Winston continues to speed up as it matures.
I really wish we could pan and zoom, but not enough so for me to have done anything about it. :)
I have always seen the map plotting capabilities as just a convenience, since visualizing your data is so important in really any field. I'm all for more detailed map viewing, but I question at what point it should move into its own package.
I think what you say about abstracting the packages is a great point. If there's an easy way to do this, then I think it's probably worthwhile in the long term.

Other
To put my point of view in a little more context, I'm very busy right now trying to hopefully graduate sometime this year, and hopefully sooner rather than later. Right now this package does everything that I personally need it to do for my work, so while I focus on writing a thesis I probably won't be adding any additional "extraneous" features (from the point of view of my own work). I obviously am quite attached to the package and will keep working on it and trying to make it the best that it can be, especially after graduation, but I also think that there will be a limit to how many features need to be added by us to make this package worthwhile to the larger community, and I'm not all that interested in surpassing that limit.
I'm absolutely thrilled that you guys have been continuing to add features, and you shouldn't worry about breaking compatibility for me, etc., since I can always just pin a specific version. I don't say it enough, but thanks for all your help. All your code speed ups and improvements have really sped up my work for me and helped me learn Julia much better than I otherwise would have, and have also turned this package into something that's useful for a much wider audience.

That all sounds good.
Versioning:
Pre 1.0, semantic versioning leaves the meaning of minor and patch levels up to the developer. I see some Julia packages tagging patchlevel versions for minor increases in functionality, bug fixes, maybe minor breaks in compatibility, etc., and saving the minor versions for when enough of the major items have been ticked off, but it's ad hoc and certainly not a rule, and we don't necessarily have to tag that often because our user group is up to date with current development on master.
We could probably tag more patches after bugfixes to be a little friendlier to outsiders, or to give us versions to pin that are without previous bugs and without later compatibility breaks? For the latter, manual git checkouts work, too, and there's DeclarativePackages.jl.
You're welcome for the help -- thanks, first for releasing the package and for being so open to contributions! It has been a great intro to geospatial work for me, and contributing has been helping me become a better programmer, too.

@yeesian @garborg
I haven't made any changes to this package in a while, but we have two big changes that still haven't made it into a release: XML streaming and moving the coordinate systems into Geodesy.jl. I've been quiet lately because I've been working on my thesis (and I also just don't have anything else I needed to add), but I think it would be good to get those changes into a release for others to use (if anyone else is using the package).
For my thesis, I'd like to give a release number. Does anyone have any objections to me pushing a new release or any changes that are about to be committed? I had wanted to wait until we figured out the Travis testing issues, but those don't seem to have worked themselves out in the last couple of months like I had hoped.

I'm okay with that! I have friends from my office who might be using this package for their own work as well, so it'll be great to have a release number.

@tedsteiner I am, too. If you're not in a hurry, I can put the package through the motions on 0.4 tonight, and try to clear up any compatibility issues (or give an ETA), but don't let that hold you up if you want to get something out the door.

Nope, I'm not in a big hurry, I'd just like to push out a release sometime in the next week or so. Thanks, guys!

No problem. I ran into an issue running using the package 0.4 (amitmurthy/LibExpat.jl#30), but it just requires a naming decision, so it shouldn't take long to resolve.

Perhaps we should push for the release soon, in lieu of #70?

Yes, I definitely agree. I should be able to get to it later this week (my thesis defense is this afternoon, so after today I should have more time).
@garborg Do you happen to know if LibExpat's naming decision has been resolved yet?

Nothing yet, just pinged Amit.


Cant seem to get callbacks working.

Hi,
I have a question regarding the callbacks. I have implemented a nested form for the belongs_to association. Ive managed to get the partial working in that it is added and removed to the form but i can't seem to get the call backs working which would hide and show the partial.
Any hep would be appreciated.
Here is my code.
_form.html.erb
<%= simple_form_for(@user) do |f| %>
    <%= f.error_notification %>

          <%= f.input :asa_number, :label => "ASA Number" %>
          <%= f.input :f_name, :label => "Name" %>
          <%= f.input :s_name, :label => "Surname" %>
          <%= f.input :known_as, :label => "Known As" %>
          <%= f.input :dob, label: "Date of Birth", start_year: Time.now.year - 90,
                    end_year: Time.now.year - 6, order: [:day, :month, :year]%>
          <%= f.association :ethnic_background, :label => "Ethnic Background" %>
          <%= f.association :asa_category,  :as => :radio_buttons, :label => "ASA Category" %>
          <%= f.association :subscription_status,
                          :as => :radio_buttons, :label => "Subscription Status"%>
          <%= f.association :user_address, :prompt => 'Choose an existing address' %>
          <%= link_to_add_association 'add a new address', f, :user_address %>

      <%= f.button :submit %>

<% end %>

_user_address_fields_html.erb

 <%= f.input :house_num_name, :label => 'House Number/Name' %>
 <%= f.input :street, :label => 'Street' %>
 <%= f.input :city, :label => 'City' %>
 <%= f.input :district, :label => 'District' %>
 <%= f.input :country, :label => 'Country' %>
 <%= f.input :postcode, :label => 'Postcode' %>
 <%= link_to_remove_association "remove owner", f %>

User model
class User < ActiveRecord::Base

  validates_presence_of :f_name, :s_name, :dob, :pri_phone_num, :asa_number, :sex,
                        :user_address, :ethnic_background, :asa_category, :subscription_status

  belongs_to :user_address
  belongs_to :ethnic_background
  belongs_to :asa_category
  belongs_to :subscription_status

  has_one :swimmer
  has_many :user_qualifications
  has_many :qualifications, through: :user_qualifications

  accepts_nested_attributes_for :user_address, :reject_if => :all_blank

end

users.js
$(document).ready(function() {
    console.log("here")
    $("#user_address a.add_fields").
        data("association-insertion-position", 'before').
        data("association-insertion-node", 'this');
        console.log("here2");

    $('#user_address').bind('cocoon:after-insert',
        function() {
            console.log("HIDE");
            $("#user_address_from_list").hide();
            $("#user_address a.add_fields").hide();
        });
    $('#user_address').bind("cocoon:after-remove",
        function() {
            console.log("SHOW");
            $("#user_address_from_list").show();
            $("#user_address a.add_fields").show();
        });
    console.log("here3");

});

user_controller
class UsersController < ApplicationController
  before_action :set_user, only: [:show, :edit, :update, :destroy]

  # GET /users
  def index
    @users = User.all
  end

  # GET /users/1
  def show
  end

  # GET /users/new
  def new
    @user = User.new
  end

  # GET /users/1/edit
  def edit
  end

  # POST /users
  def create

    @user = User.new(user_params)

    if @user.save

      redirect_to @user, notice: 'User was successfully created.'
    else
      render :new
    end
  end

  # PATCH/PUT /users/1
  def update
    if @user.update(user_params)
      redirect_to @user, notice: 'User was successfully updated.'
    else
      render :edit
    end
  end

  # DELETE /users/1
  def destroy
    @user.destroy
    redirect_to users_url, notice: 'User was successfully destroyed.'
  end

  private
    # Use callbacks to share common setup or constraints between actions.
    def set_user
      @user = User.find(params[:id])
    end

    # Only allow a trusted parameter "white list" through.
    def user_params
      params.require(:user).permit(:f_name, :s_name, :known_as, :dob, :pri_phone_num,
                                   :sec_phone_num, :asa_number, :sex,  :user_address_id,
                                   :ethnic_background_id, :asa_category_id, :subscription_status_id,
                                   user_address_attributes: [:id, :house_num_name, :street, :city,
                                   :district, :country, :postcode, :_destroy])
    end
  end

Thank you in advance for any help

At first glimpse I see you bind to an html element with id #user_address and I do not see you creating such a container.

Amazing! Thank you so much for getting back to me. I am new to web app development and didn't realise my mistake. It works perfectly now.
Thank you again.


[WIP][FINE] fog google upgrade 1.5.0

Cherry-picked version of https://github.com/ManageIQ/manageiq-providers-google/pull/64 for FINE release.
Depends on: ~https://github.com/ManageIQ/manageiq/pull/17914~, ~https://github.com/ManageIQ/manageiq-providers-google/pull/59~

@miq-bot add_label wip

@miq-bot remove_label wip, unmergeable

@simaishi and this should be the last one! :wine_glass: :tada:


Refactor tryToGetClientIp method

What's the purpose of this PR
Refactor tryToGetClientIp method

Codecov Report

Merging #4514 (36a2385) into master (4ca9739) will increase coverage by 0.00%.
The diff coverage is 100.00%.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Cm/docs canon

Docs broken.

src/canon/docs_test.jl may have a working macro defined but it should be moved to src/canon.jl and applied to the other examples.
Literate is commented out in docs/make.jl because of rogue formatting obstacles in the examples.

I think we should use the Markdown stdlib to get the formatting right.
https://github.com/JuliaLang/julia/blob/master/stdlib/Markdown/src/Markdown.jl
a="a"; using Markdown; Markdown.catdoc(md"# h1", md"$a", md"$a", md"paragraph")
works for me.

Also squash all this history into 1-3 commits before merging.


Features

Let's list out what features are must-have/nice-to-have:
(First I'll list the ones that are very easy to activate or create out-of-the-box)

Forum???
Should the new site have a separate forum or will  knowledge.robotlegs.org suffice?

Commenting system?
Site-wide? Content type restricted? Disabled?

OpenID, FB login, Twitter login?

Polls?

Karma/reputation/points/whatever system? This could be useful if we add a resource-submission system. For instance: people can post a link to their RL extension/add-on, each time your extension is viewed or turns up in a resource-search points could be added to both the resource and to the user.
This allows for ordering the resources by popularity (or need...?), but it also allows to assign a level of "trust" to someone's new resource. If you already have posted a resource that has generated a lot of points, your next resource could get a higher level to begin with.

If we go for a points system, will we add user badges as well?

Direct messaging between users?

Sharethis functionality for all content types seems like a must-have

Re. the resources: Yeah, I think it could be really helpful to have people post tutorials, extensions, templates, etc. Obviously nicely categorized and with a number of tags and fields that help to order/filter the resources.
As I said in the other thread, drupal.org's centralisation of all contrib modules is fantastic, since you don't have to start searching around the web, but it could definitely be improved upon, by having points and some kind of "staff pick" label.
If we're going down that road, user registration and logins will have to go very smoothly, regardless of enabling commenting or not.
Speaking of commenting: with drupal the commenting system is very granular, you can define what content types, if any, are allowed to be commented on. With or without automatic approval. Anonymously or only for registered users etc etc.
Disqus is definitely great, but I have no idea how configurable it is.

re the forum, I think you're right. Tender's a bit quirky sometimes I think, but knowledge.rl is an established place now with a lot of content. Some link-back mechanism would be nice though, maybe a "stream" of the latest posts on knowledge.rl??

Sounds good. Perhaps we can syndicate knowledge.rl posts with certain tags.
Regarding logins: OpenID and Twitter make sense. But not FB - most devs aren't keen on signing in with FB accounts as far as I can tell:
http://blog.leahculver.com/2012/02/log-in-or-sign-up-with-github.html
On that note: What about GitHub sign-in?

I don't mind if GitHub is the only official way to distribute extensions. Or, am I missing what you're saying?

No, that's what I meant!


Vanilla 1.14 | UnrecognizedOptionException noconsole

Hey,
I wanted to upgrade a server from 1.13.2 to 1.14 and starting n a new map, using docker-compose.
So i went into the server Properties and changed the level name, pulled the new docker and did a docker-compose restart
now i get the following error when starting the server:
Checking version information. Checking type information. Downloading minecraft_server.1.14.jar ... DEBUG: Finding version manifest for 1.14 DEBUG: Found version manifest at https://launchermeta.mojang.com/v1/packages/3aa13ae273eb9f05c2b1fcee1aff6c9254492941/1.14.json DEBUG: Downloading server from https://launcher.mojang.com/v1/objects/f1a0073671057f01aa843443fef34330281333ce/server.jar
...
So Downlaoding 1.14 worked
Then the start of the new server begins
...
server.properties already created, skipping Checking for JSON files. Copying any mods over... Setting initial memory to 1G and max to 8G [07:33:55] [main/FATAL]: Failed to start the minecraft server joptsimple.UnrecognizedOptionException: noconsole is not a recognized option at joptsimple.OptionException.unrecognizedOption(OptionException.java:108) ~[minecraft_server.1.14.jar:?] at joptsimple.OptionParser.handleLongOptionToken(OptionParser.java:510) ~[minecraft_server.1.14.jar:?] at joptsimple.OptionParserState$2.handleArgument(OptionParserState.java:56) ~[minecraft_server.1.14.jar:?] at joptsimple.OptionParser.parse(OptionParser.java:396) ~[minecraft_server.1.14.jar:?] at net.minecraft.server.MinecraftServer.main(SourceFile:879) [minecraft_server.1.14.jar:?] 2019/05/11 07:33:56 Done
i have already tryed removing the console option from the composer file or setting it to true, but neither seamed to have worked.
Any further ideas?
Thx for your time

I found a solution myself.
Removing the containers and restarting then helped apparently.
so:
docker-compose stop
docker-compose rm
docker-compose up

Glad you resolved it, but strange that was the solution.

Having minecraft_server.1.14.1.jar but other than that I get exact the same error message. Docker container constantely tries to restart. Removing the container and recreating it as you suggested didn't help.

I also got a very simmular error, when having a older docker Image, have you tryied pulling a fresh one, if you havent just started with the newest Version?

I also got a very simmular error, when having a older docker Image, have you tryied pulling a fresh one, if you havent just started with the newest Version?

I just started and should use the latest image

@lorenzschmid I believe what @Wiamor meant was to do a docker pull itzg/minecraft-server to double check you're running the latest image.

Thanks for answering. I just tried a new pull but everything is up-to-date.

@lorenzschmid can you post some more details about how you’re launching the se

I used more or less the example given for docker compose combined with your itzg/rcon:
version: '3'
services:

  ...

  minecraft:
    image: itzg/minecraft-server
    container_name: minecraft
    environment:
      UID: 1031
      GID: 100
      EULA: "TRUE"
      CONSOLE: "false"
      ENABLE_RCON: "true"
      RCON_PASSWORD: "password"
      RCON_PORT: 28016
      SERVER_NAME: minecraft-server
    ports:
     - "25565:25565"
    volumes:
      - "/volume1/minecraft/data/:/data/"
    restart: unless-stopped

  minecraft-rcon:
    image: itzg/rcon
    container_name: minecraft-rcon
    ports:
     - "8701:4326"
     - "8702:4327"
    volumes:
      - "/volume1/minecraft/rcon/:/opt/rcon-web-admin/db"
    depends_on:
      - minecraft
    restart: unless-stopped

And concerning my docker logs the might be handy as well:
Running as uid=1031 gid=100 with /data as 'drwxrwxr-x    1 1031     100            146 May 26 16:33 /data'
Checking version information.
Checking type information.
server.properties already created, skipping
Checking for JSON files.
Copying any mods over...
Setting initial memory to 1G and max to 1G
Starting the Minecraft server...
[16:35:47] [main/FATAL]: Failed to start the minecraft server
joptsimple.UnrecognizedOptionException: noconsole is not a recognized option
	at joptsimple.OptionException.unrecognizedOption(OptionException.java:108) ~[minecraft_server.1.14.1.jar:?]
	at joptsimple.OptionParser.handleLongOptionToken(OptionParser.java:510) ~[minecraft_server.1.14.1.jar:?]
	at joptsimple.OptionParserState$2.handleArgument(OptionParserState.java:56) ~[minecraft_server.1.14.1.jar:?]
	at joptsimple.OptionParser.parse(OptionParser.java:396) ~[minecraft_server.1.14.1.jar:?]
	at net.minecraft.server.MinecraftServer.main(SourceFile:879) [minecraft_server.1.14.1.jar:?]
2019/05/26 16:35:47 Done
usermod: no changes
Running as uid=1031 gid=100 with /data as 'drwxrwxr-x    1 1031     100            146 May 26 16:35 /data'
Checking version information.
Checking type information.
server.properties already created, skipping
Checking for JSON files.
Copying any mods over...
Setting initial memory to 1G and max to 1G
Starting the Minecraft server...
[16:36:35] [main/FATAL]: Failed to start the minecraft server
joptsimple.UnrecognizedOptionException: noconsole is not a recognized option
	at joptsimple.OptionException.unrecognizedOption(OptionException.java:108) ~[minecraft_server.1.14.1.jar:?]
	at joptsimple.OptionParser.handleLongOptionToken(OptionParser.java:510) ~[minecraft_server.1.14.1.jar:?]
	at joptsimple.OptionParserState$2.handleArgument(OptionParserState.java:56) ~[minecraft_server.1.14.1.jar:?]
	at joptsimple.OptionParser.parse(OptionParser.java:396) ~[minecraft_server.1.14.1.jar:?]
	at net.minecraft.server.MinecraftServer.main(SourceFile:879) [minecraft_server.1.14.1.jar:?]
2019/05/26 16:36:35 Done

@lorenzschmid yeah, you're compose looks fine. If you could docker pull itzg/minecraft-server I have just added an env option DEBUG_EXEC to debug the java invocation. After pulling you can add this to your environment:
   DEBUG_EXEC: "true"

Thanks a lot for your help, @itzg . Just pulled the new image and added the environment variable. here you go with the new logs:
Running as uid=1031 gid=100 with /data as 'drwxrwxr-x    1 1031     100            146 May 26 16:39 /data'
Checking version information.
Checking type information.
server.properties already created, skipping
Checking for JSON files.
Copying any mods over...
Setting initial memory to 1G and max to 1G
Starting the Minecraft server...
+ exec mc-server-runner --stop-duration 60s java -XX:+UseG1GC -Xms1G -Xmx1G -jar minecraft_server.1.14.1.jar --noconsole
[17:11:41] [main/FATAL]: Failed to start the minecraft server
joptsimple.UnrecognizedOptionException: noconsole is not a recognized option
	at joptsimple.OptionException.unrecognizedOption(OptionException.java:108) ~[minecraft_server.1.14.1.jar:?]
	at joptsimple.OptionParser.handleLongOptionToken(OptionParser.java:510) ~[minecraft_server.1.14.1.jar:?]
	at joptsimple.OptionParserState$2.handleArgument(OptionParserState.java:56) ~[minecraft_server.1.14.1.jar:?]
	at joptsimple.OptionParser.parse(OptionParser.java:396) ~[minecraft_server.1.14.1.jar:?]
	at net.minecraft.server.MinecraftServer.main(SourceFile:879) [minecraft_server.1.14.1.jar:?]
2019/05/26 17:11:41 Done
usermod: no changes
Running as uid=1031 gid=100 with /data as 'drwxrwxr-x    1 1031     100            146 May 26 17:11 /data'
Checking version information.
Checking type information.
server.properties already created, skipping
Checking for JSON files.
Copying any mods over...
Setting initial memory to 1G and max to 1G
Starting the Minecraft server...
+ exec mc-server-runner --stop-duration 60s java -XX:+UseG1GC -Xms1G -Xmx1G -jar minecraft_server.1.14.1.jar --noconsole
[17:11:53] [main/FATAL]: Failed to start the minecraft server
joptsimple.UnrecognizedOptionException: noconsole is not a recognized option
	at joptsimple.OptionException.unrecognizedOption(OptionException.java:108) ~[minecraft_server.1.14.1.jar:?]
	at joptsimple.OptionParser.handleLongOptionToken(OptionParser.java:510) ~[minecraft_server.1.14.1.jar:?]
	at joptsimple.OptionParserState$2.handleArgument(OptionParserState.java:56) ~[minecraft_server.1.14.1.jar:?]
	at joptsimple.OptionParser.parse(OptionParser.java:396) ~[minecraft_server.1.14.1.jar:?]
	at net.minecraft.server.MinecraftServer.main(SourceFile:879) [minecraft_server.1.14.1.jar:?]
2019/05/26 17:11:53 Done

Aha @lorenzschmid , it took seeing the debug output to realize that normally I don't use the CONSOLE=false option, which is why I didn't run into this.
Apparently this is an issue in the upstream server itself as of 1.14
https://bugs.mojang.com/browse/MC-151445
Easy solution for now is to remove the
   CONSOLE: "false"

That did the trick indeed! Thank you very much!


[bug] error - TypeError: create__default.default is not a function

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
2.1.0
Current Behavior
When installed on nextjs application, and run  npm run dev, it flags the above error
I had to delete my node modules and .next folders , installed it again and when you start the server, it still flags the error
Expected Behavior
To work properly
Steps To Reproduce
No response
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

@dob @iameli @ericxtang

See Discord for reponse to this question:
https://discord.com/channels/423160867534929930/426114749370204170/1065347166173937795


Feature Req: advanced filtering

The way this lib gets search results is by converting strings to lower case and doing a string .contains(query).
In my app I use permutations so that "red apples" and "apples, red" would give the same search results.
I did this by extending SearchAdapter. But by doing this I lost history because mDatabaseKey is private.
Can you please either make it public/protected, or instead of
if (string.contains(key)) {
 results.add(item);
}

put the condition in a public method such as compare(key,string), which the user can then override easily. (or both methods if you can)
I know you're busy but this is an easy feature :)

Sure. I will change it in next version on which I am already working.

+1

mDatabaseKey will be public in 4.1.


Use moment.weekdaysMin() for weekdays

Considering that moment is used for formatting of date-related stuff in datepicker (e.g. month+year in calendar header), why is it not used to obtain weekdays?
I am currently setting it as
const weekdays = moment.weekdaysMin()
<Datepicker weekdays={weekdays} />

I assume this would be sensible default - also taking into account locale property of <Datepicker />?
Current implementation also overrides moment locale setting with weekdays as set in Datepicker (https://github.com/Hacker0x01/react-datepicker/blob/master/src/calendar.jsx#L59), which can be rather surprising for the user of the component.

SGTM. Not sure if I can find the time to work on this, so a PR would be much appreciated.

Fixed by #277


Black and White colors are missing in 1.0.0

Hi there.
I've found that black and white colors are missing in colors/ of 1.0.0-beta.18 when they are still here in 0.x and Google Material Colors (https://material.io/guidelines/style/color.html#color-color-palette)
I think it is a good idea to add those colors to comply Material Design literals.

Tech
Version

Material-UI
1.0.0-beta.18

You can find them in the common.js file:
https://github.com/callemall/material-ui/blob/167893084034a7455c08c131f1d48146b9fa0bd7/src/colors/common.js#L4-L5
It's also accessible under the theme.palette.common.x path.


Node Template Fails to Change Epoch

When running a node template on Substrate, it fails to produce blocks after 100 due to "Expected Epoch Change":
2019-09-30 19:35:42 Idle (0 peers), best: #100 (0xb075…c064), finalized #100 (0xb075…c064), ⬇ 0 ⬆ 0
2019-09-30 19:35:47 Idle (0 peers), best: #100 (0xb075…c064), finalized #100 (0xb075…c064), ⬇ 0 ⬆ 0
2019-09-30 19:35:48 Starting consensus session on top of parent 0xb075eeb491f2531a81323bc2e8b9c4aa1da8f6e1d8a66bec66bd1721bbe8c064
2019-09-30 19:35:48 Prepared block for proposing at 101 [hash: 0x5e2dae479d06712d50c84baf71895bf2558ef07a189f44f9965f6ff01b2a959d; parent_hash: 0xb075…c064; extrinsics: [0xd801…18b8]]
2019-09-30 19:35:48 Pre-sealed block for proposal at 101. Hash now 0x02018d7198c46b28b3370f07ee6fbc14dfdd57f6fe7bf21aa2827a8b5326285e, previously 0x5e2dae479d06712d50c84baf71895bf2558ef07a189f44f9965f6ff01b2a959d.
2019-09-30 19:35:48 Error with block built on 0xb075eeb491f2531a81323bc2e8b9c4aa1da8f6e1d8a66bec66bd1721bbe8c064: ClientImport("Expected epoch change to happen at 0x02018d7198c46b28b3370f07ee6fbc14dfdd57f6fe7bf21aa2827a8b5326285e, s261644158")

Tested on Substrate commit e0d486d617cbe24f0c91cd6aa0dfcfb6c4e4dcc2 and 7d7e74fb77b6bee2ce9d6ebafcae09caff2d0e50
The regular Substrate node works.
@rphmeier

Works in 3ba0f2a2dbd37c31851a0ff1c1c0c47aa940de90 before BABE changes

Somehow node and Polkadot both work with the babe commits, while node-template fails to bootstrap.

Oh, it's because node-template isn't using session - the epoch change logic in srml-babe isn't triggered because of that.

seems like it is non-sensical at the first place for node-template to exist without session module and just needs s fix for that?

But this does bring up a question:
If Babe is not functional properly without session, it should be strictly dependent on it, no? it is quite strange that I see babe's cargo file requires session, while a runtime is allowing babe to be included without session. Ideally, I imagine each module statically naming a few module ID's as strong dependency or something, and perhaps construct_runtime! checking it?

You don't want to have a strong link to session. Just yesterday you recommended a pr that removed such a strong dependency and now you want to add one for yourself :D
I think the only solution is to improve the documentation in the srml-babe module, telling you that you need something that handles sessions. Besides that, we could also improve the error message and giving a hint that probably no session change occurred.

@bkchr is there a way to have the trait be such that anything can implement "sessions" but it has to be implemented?
I see that as also a solution here if rust/magic allows it?

Normally you could just declare the other modules trait as super trait:
trait Trait: other_module::Trait {}

But that enforces you to directly use the other module in your runtime.
We could add some dummy associated type to the Babe Trait that requires that a trait Session is implemented. Currently this Session trait could only be some sort of marker trait, so just an empty trait. We would implement this marker trait for our sessions module and the user would be forced to provide something that implements this session trait.
We could add some dummy associated type, that requires that a dummy Session trait is implemented and impl

You don't want to have a strong link to session. Just yesterday you recommended a pr that removed such a strong dependency and now you want to add one for yourself :D

Shawn also pointed out the same. But frankly, I see this differently. If Babe is dysfunctional without session, or let's say something that can provide some session handler implementation etc., then I see a strong dependency more suitable. It is better to ship a less generic srml that works, rather than a dynamic fancy generic one that does not :P
But as you mentioned, that would be supertrait, which is not nice. That bounds srml-babe to always use srml-session, not some custom session implemented by anyone else. Ideally, would be great if we could:

We could add some dummy associated type, that requires that a dummy Session trait is implemented and impl

👍

We could add some dummy associated type, that requires that a dummy Session trait is implemented and impl

I'll do something like this, but cleaner

Hey buddy, I am a green bird to substrate. same problem when I import babe into runtime.
I aware you guys already decouple seesion from babe. My question is how to import session into runtime?😂

@zikunfan we have a tutorial here: https://substrate.dev/docs/en/next/tutorials/adding-a-module-to-your-runtime
But depending on what you are trying to do, it may be easier to start with the Substrate node which is already set up with a PoS consensus system with Babe + Session + everything else:
https://github.com/paritytech/substrate/blob/master/bin/node/runtime/src/lib.rs


[zh] Sync tasks/administer-cluster

Two files are already in sync
Remove reviewer in metadata
Add link anchors
Fix punctuation
Remove redundant spaces

Related PR

#33661

/approve

/lgtm


Multi-node deployments fail to upload files to MediaLibrary

Environment

Elixir version (elixir -v): 1.17.1
Phoenix version (mix deps): 1.7.14
Phoenix LiveView version (mix deps): 0.20.12
Beacon version (mix deps): 0.3.3
Operating system: Flyio
Browsers on which you attempted to reproduce this bug (the more the merrier): N/A

Actual behavior
On a multi-node deployment, file uploads fail during processing

This is due to the /tmp file location being on one node, while another node attempts image processing

Expected behavior
File upload is OK

It seems like the main issue on dockyard is with - Image.open!(metadata.path). This expects the path to be on the local node, but in a multi-node setup this is never the case.  File.read! has the same problem.  Therefore we need a better way of reading a file, which can handle remote calls.  e.g.
defmodule Beacon.Something do
  def open_upload(%UploadMetadata{original_node: node, path: path}) do
    if node == Node.self() do
      apply(File, :read!, [path])
    else
      :erpc.call(node, File, :read!, [path])
    end
  end
end

currently UploadMetadata does not have the :original_node field so that will need to be added.

Note that Image.open! has a different return type from File.read! so an additional step could be necessary to convert the binary into an %Image{} e.g.
Before:
metadata.path
|> Image.open!(access: :random)
|> Image.write!(:memory, suffix: target_file_type)

After:
metadata
|> Beacon.Something.open_upload()
|> Image.from_binary(access: :random)
|> Image.write!(:memory, suffix: target_file_type)

another option could be to use key :pid instead of :original_node because the first segment of the pid represents a node, but it would require special care/cleanup to close those I/O connections after we're done using them

an eventual optimization with the :original_node + File.read! approach could be compressing the file before returning it to the caller, to reduce the data sent between nodes


Fix assertFailure bug in JsonSerializableAddressBookTest.java

Fix assertFailure bug in JsonSerializableAddressBookTest.java on changing  assertEquals(addressBookFromFile, typicalPersonsAddressBook); instead of assertEquals(addressBookFromFile.toString(), typicalPersonsAddressBook.toString());
Bugs:

Values in typicalPersonsAddressBook.json does not equal to values assigned in TypicalPersons.java.

The values created in TypicalPersons.java do not match the values saved in typicalPersonsAddressBook.json, causing Persons with different information to be created, causing assertFailure on test run.

Default tags and skills are created although they do not exist in JsonSerializableAddressBookTest.java.

Default values initialized in PersonBuilder.java caused default tags to be created. If tags are empty in typicalPersonsAddressBook.json, default values get created, causing test to fail.

PersonUtil::getEditPersonDescriptorDetails missing whitespace to separate tag and skills.

PersonUtil::getEditPersonDescriptorDetails is previously set to accept tags as the last parameter. As we added a new Skill field, the lack of whitespace caused the descriptor to create 't/s/' at the end of the string. This string gets parsed by the parser which throws a ParseException when it tries to parse 's/' as a tag, failing the validation regex in Tag.java.

Fixes: https://github.com/AY2122S2-CS2103T-W13-3/tp/issues/34

Codecov Report

Merging #35 (9c265e5) into master (98021c6) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
+ Coverage     71.99%   72.07%   +0.07%
- Complexity      418      419       +1
============================================
  Files            72       72
  Lines          1332     1332
  Branches        140      140
============================================
+ Hits            959      960       +1
  Misses          330      330
+ Partials         43       42       -1

Impacted Files
Coverage Δ

...c/main/java/seedu/address/model/person/Person.java
96.00% <0.00%> (+2.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98021c6...9c265e5. Read the comment docs.

Looks good to merge. Thanks for spotting it!