fix(framework): fix migration scripts

Summary
In pr: https://github.com/apache/incubator-devlake/pull/3727, we fixed bugs for #3713 but just a hotfix for v0.14, this pr is to resolve the problem in main branch ,  in addition, for all fields with datatypes.JSON, we changed to json.RawMessage as pg would treat these two types with difference.
Lastly, we tested through the following steps:

deploy devlake v0.12 by docker-compose
created several blueprints and pipelines
collect jira, github, jenkins which were impacted in new data
shutdown v0.12 devlake
export all data
deploy 0.14 devlake and shutdown
deploy new code
check blueprints and pipelines through config-ui

Again, we also tested through the following steps which skipped step 4 above:

deploy devlake v0.12 by docker-compose
import the data which was exported at step 5 above
shutdown v0.12 devlake
deploy new code
check blueprints and pipelines through config-ui

Does this close any open issues?
Closes #3713
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.

TransformColumns is packed with rename column operations. I think we don't need to rename it manually. The doc of TransformColumns is not very clear about that, we should provide an example to help developer understand the usage

Fixed, I will submit a pr for that


3dot button missing?

Sanity checks (must complete)

[X ] I have read and followed the installation instructions in the README
[X ] I have not modified the userChrome.css file
[X ] I have tested the latest release or commit on master

Describe the bug
The 3dot menu button in the top right corner is missing on FireFox 74 update.
To Reproduce
Steps to reproduce the behavior:
Update to FireFox 74.
Screenshots

System info

Windows 10
FireFox 74

I'm unable to reproduce this. Is it missing all of the time or just sometimes? For example, it should change to an arrow when an update is pending. There may be another edge case I've missed where it's meant to change to something else but doesn't.

It seems to have pushed the 3 dot menu item off the side of the screen and into some invisible limbo on the next row - only visible at browser startup, really not sure how to explain this any further O.o

Do you see the 3-dot-button when you open the customization menu or without any extension buttons?

I've tried adding 14+ buttons to the nav bar and shrinking the window to its smallest possible width and it still behaves as expected. What happens when you use the customise menu; do the buttons reappear? You're the only one thus far to experience this issue so it might be beneficial if you try a fresh profile to see if it's a specific configuration issue.

75 update fixed it.


Desktop notifications are not shown with Firefox on linux

The setting to show desktop notifications (dn) in the preferences of rainloop is set.
dn are also allowed for the site rainloop is installed on.
When I receive a new mail, it plays the sound but no dn is shown. The system is an Arch linux 64bit machine with Gnome 3 and Firefox 39.0. rainloop is v<IP_ADDRESS>3 (05.07.2015).
dn itself is working with the same browser on the same system, as the test button on this page shows the dn: https://developer.mozilla.org/de/docs/Web/API/notification
I made a cross test and dn do work on Firefox for Windows. To verify, that this is no issue with my system, I installed Kubuntu 15.04 into a VM and tested there with the same result: dn work, but not with rainloop. Firefox there is 37.x.
I wonder why nobody else seems to have this problem.
Could somebody please confirm this?
Cheers,
Ralph

I can confirm that they're not show in Firefox, Windows 7, either. The button on your link is also glitchy. I have to click on it a number of times in succession for it to work, but then multiple notifications appear in a jerky motion and the browser gets slow as hell.

With the new notifications that came with FF 44 new mail is notified again.
So I am closing this issue.


resonance: init at unstable-2023-06-06

Description of changes
Resonance is an intuitive GTK4/LibAdwaita music player.
I'm new to Nix packaging... Please tell if I did anything wrong :-)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Following new versioning scheme. master/pkgs/README.md#package-naming

Maybe you could update your commit message as well?

No worries :grin:
Could you flip the order of the commits, so you add yourself as a maintainer before you create the package?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3660


current implementation with users vs workers is a bit messy

When uploading data that I downloaded from timeld.org, the user is 'm-ld' but the worker is 'http://timeld.org/angus'. Then when running print-timesheet-json with the 'm-ld' user, it can't find those entries back. It should choose all that match the userId but instead it's choosing all whose movement.fromComponent == user.name, which is all a bit messy.

I have noticed that it's not possible to update the worker with update-entry

@gsvarovsky You can see for now it is working, you can add worker.
https://github.com/pondersource/prejournal/pull/152

curl -d'["23 August 2021"      "Add worker"    "Add Project"        2        "Add Description"              2]'<EMAIL_ADDRESS>


Use inspectNetworkCmd to get the gateway's IP

To avoid running a container with ip|awk, we can simply inspect the bridge network instead.
This idea was discovered while hacking on https://github.com/testcontainers/testcontainers-rs/pull/139

I've tested this with our internal derivative of dind-drone-plugin and am happy that it behaves consistently in even our slightly complicated DinD setup 😄.


Local installation

@petersgiles

@JohannesHoppe yep that's the way it happened for me.
I tried installing npm install --save-dev angular-cli-ghpages and it didn't make the ngh available so I uninstalled it and did npm install -g angular-cli-ghpages and it worked.
macOS Sierra
node: 6.9.5
os: darwin x64
@angular/common: 2.4.7
@angular/compiler: 2.4.7
@angular/core: 2.4.7
@angular/flex-layout: 2.0.0-beta.5
@angular/forms: 2.4.7
@angular/http: 2.4.7
@angular/material: 2.0.0-beta.1
@angular/platform-browser: 2.4.7
@angular/platform-browser-dynamic: 2.4.7
@angular/router: 3.4.7
@angular/cli: 1.0.0-beta.31
@angular/compiler-cli: 2.4.7

see https://github.com/angular/angular-cli/pull/4385#issuecomment-279309014

by @tkow
from https://github.com/angular/angular-cli/pull/4385#issuecomment-280826566
It seems @petersgiles 's problem not that ngh command is not incleded in your path because node install packages in node_moudules/.bin when local installing. $(pwd)/node_moudules/.bin path are exported when npm commands run before executed so that node's package commands are available in scripts in package.json but not shell environment with no explicitly path prefix . npm support npm bin command which get path $(pwd)/node_modules/.bin So, you can use ngh commands by $(npm bin)/ngh ... .

I tested this out and it works flawlessly via npx. (Nodejs 8 or higher required)
npm i angular-cli-ghpages --save-dev
npx ngh [OPTIONS]


Is "Track Anything" (TAM) container broken on JetPack 6?

The github autobuilds are failing..

Ah thanks @chaos6887, addressed this in commit https://github.com/dusty-nv/jetson-containers/commit/9f4df1a159a4d1601da1821a3e55d633b23aa82b - you can try dustynv/tam:r36.2.0

@dusty-nv with JP6 DP available, I want to start helping build containers as I will be actively using them in the coming weeks. What's the best way to get involved with this repository? Thanks

@IamShubhamGupto if you want to build containers, I'd follow the System Setup guidelines form here first:  https://github.com/dusty-nv/jetson-containers/blob/master/docs/setup.md
Then see https://github.com/dusty-nv/jetson-containers/blob/master/docs/build.md

@dusty-nv thanks for the guides. I have set up my Jetson Orin machine with the above instructions. Is it possible to use a bigger / faster machine for building these containers?
I see that there isn't a JP6 with ros2 iron, realsense, pytorch 2 and tensorRT already available and I will be building it for my project. Let me know if this image is a requirement / what can I build for this repository

@IamShubhamGupto there is a JetPack cross-compilation container on NGC here:
https://catalog.ngc.nvidia.com/orgs/nvidia/containers/jetpack-linux-aarch64-crosscompile-x86
However each project you build would need support for cross-compilation (like ROS2, librealsense, ect) and I don't attempt it.   I build jetson-containers natively on the 12-core Jetson AGX Orin and that is fast enough for me (i.e. ROS2 takes like an hour to build IIRC...and ROS2 Humble/Iron are also available from the OSRF apt repo for Ubuntu 22.04 on JetPack 6)


Generalize gamma

Summary
Generalizes gamma distribution related functions to accept Eigen expressions.
Tests
Tested using expression testing framework.
Side Effects
None.
Release notes
Generalized gamma distribution related functions to accept Eigen expressions.
Checklist

[x] Math issue #1470

[x] Copyright holder: Tadej Ciglarič
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

Looks like there are conflicts on the signatures file so you'll have to merge in develop.

More conflicts weeeee


pr-pull,upload: don't quote passed --committer value

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Should fix:
https://github.com/Homebrew/homebrew-core/runs/2249865658?check_suite_focus=true
I tested it in a funky way, so I'm not sure it will actually resolve the problem.

Would it be safe to use " instead?

The problem here is that we pass this value multiple times down the stream and it is quoted multiple times too.

Review period skipped due to critical label.


Set delimiter

I didn’t find how to specify the delimiter when wrongly detect. I tried let b:delimiter=";" and let g:csv_delim=";". Nothing happen.

:h NewDelimiter_CSV

You know, it helps if you mention what you already tried.  See :h CSVInit and :h csv-configuration.

But he syntax color doesn’t fall back to the ,

That's why you need to re-initialize the plugin using :CSVInit.


Cloud storage are marked as failing when I migrate from 8.0.17 to 8.1.0

Hello,
Cloud storage are marked as failing when I migrate from 8.0.17 Bosh-Release to 8.1.0 Bosh-Release.
Cloud storage definitions are configured in the errand import which loads the configuration as follow :
...

name: minio
summary: |
Minio cloud storage for all SHIELD tenants to use
agent:  <IP_ADDRESS>:5444
plugin: s3
config:
s3_host: ((minio_s3_host))
s3_port: "443"
access_key_id: ((minio_s3_access_key_id))
secret_access_key: ((minio_s3_secret_access_key))
signature_version: "4"
bucket: ((s3_bucket_prefix))-bucket #pre-requisite
skip_ssl_validation: true
...
The same configuration works properly with 8.0.17 release and not with 8.1.0.
Thanks in advance for your help,
Jean-Christophe.

Hello,
I found the problem.
The minio_s3_host must now include the protocol.
Prior 8.1.0 the s3_host value is : <my_host>
With 8.1.0 the s3_host value must be : https://my_host
Regards,
Jean-Christophe.

Interesting.  I'll put in a feature request to auto-munge that where necessary.


proposal: Generate non-go files

I'd like to be able to generate non go files.

Nevermind. Did not see #367.

Hey @masseelch and thanks for proposing this feature.
This was actually answered before, and you can find it in https://github.com/facebook/ent/issues/780#issuecomment-695038170.
Also, you can see another example in https://github.com/facebook/ent/issues/367#issuecomment-701959271.
Please let me know if you still need help with it 😃


add LocalFileStorage delay to simulate s3

Good idea, but making it a feature is not a good idea.

--all-features will enable it and no one expects that.
also it requires recompiling things way too much.

In many places, rust treats feature flags as additive semantically.
It is not supposed to change the behavior (we make that mistake in tantivy I think too).
For instnace, if deps A and deps B depends on C with feature flag [feaflag1] and [featflag2] and compatible versions,
rustc will compile a single version of C with [featflag1, featflag2].


Development with Docker - Ruby version adjusted to avoid gem issues

Hello folks!
Ive found issues with Ruby versions while setting up my Development environment following Docker instructions from here:
Docker Compose for contributors
https://github.com/jnunemaker/flipper/blob/master/docs/DockerCompose.md
flipper % docker-compose build
...
OK

flipper % docker-compose run --rm app bundle install
Starting flipper_mongo ... done
Starting flipper_redis ... done
Starting flipper_bundle_cache ... done
Starting flipper_memcached    ... done
Fetching gem metadata from https://rubygems.org/..........
Fetching version metadata from https://rubygems.org/..
Fetching dependency metadata from https://rubygems.org/.
Resolving dependencies...
i18n-1.8.2 requires ruby version >= 2.3.0, which is incompatible with the current version, ruby 2.2.5p319

After upgrading ruby version to 2.3.0 within Dockerfile:
flipper % docker-compose build
...
OK

flipper % docker-compose run --rm app bundle install
Creating flipper_bundle_cache ... done
Creating flipper_redis        ... done
Creating flipper_mongo        ... done
Creating flipper_memcached    ... done
Fetching gem metadata from https://rubygems.org/...........
Fetching version metadata from https://rubygems.org/...
Fetching dependency metadata from https://rubygems.org/..
Resolving dependencies....
Installing builder 3.2.4
Installing rake 12.3.3
Installing erubi 1.9.0
Installing zeitwerk 2.3.0

Gem::InstallError: zeitwerk requires Ruby version >= 2.4.4.
...

After upgrading ruby version to 2.4.4 within Dockerfile:
flipper % docker-compose build
...
OK

flipper % docker-compose run --rm app bundle install
Creating flipper_bundle_cache ... done
Creating flipper_redis        ... done
Creating flipper_mongo        ... done
Creating flipper_memcached    ... done
Fetching gem metadata from https://rubygems.org/.........
activesupport-6.0.3 requires ruby version >= 2.5.0, which is incompatible with the current version, ruby 2.4.4p296

After upgrading ruby version to 2.5.0 within Dockerfile:
flipper % docker-compose build
...
OK

flipper % docker-compose run --rm app bundle install
Creating flipper_bundle_cache ... done
Creating flipper_redis        ... done
Creating flipper_mongo        ... done
Creating flipper_memcached    ... done
Fetching gem metadata from https://rubygems.org/.........
Fetching rake 12.3.3
Fetching zeitwerk 2.3.0
Fetching concurrent-ruby 1.1.6
Fetching builder 3.2.4
Fetching erubi 1.9.0
Fetching thread_safe 0.3.6
Fetching minitest 5.14.0
Installing zeitwerk 2.3.0
Installing rake 12.3.3
Fetching mini_portile2 2.4.0
Installing erubi 1.9.0
Installing builder 3.2.4
Fetching crass 1.0.6
Fetching rack 2.2.2
Fetching nio4r 2.5.2
Installing concurrent-ruby 1.1.6
Fetching websocket-extensions 0.1.4
Installing mini_portile2 2.4.0
Fetching mimemagic 0.3.5
Installing thread_safe 0.3.6
Fetching mini_mime 1.0.2
Installing nio4r 2.5.2 with native extensions
Installing crass 1.0.6
Fetching public_suffix 4.0.5
Installing websocket-extensions 0.1.4
Fetching ast 2.4.0
Installing mini_mime 1.0.2
Fetching bson 4.8.2
Installing rack 2.2.2
Installing minitest 5.14.0
Using bundler 1.16.1
Fetching coderay 1.1.2
Fetching coffee-script-source 1.12.2
Installing ast 2.4.0
Fetching execjs 2.7.0
Installing public_suffix 4.0.5
Fetching safe_yaml 1.0.5
Installing mimemagic 0.3.5
Fetching dalli 2.7.10
Installing coderay 1.1.2
Installing coffee-script-source 1.12.2
Fetching diff-lcs 1.3
Installing bson 4.8.2 with native extensions
Installing execjs 2.7.0
Fetching ffi 1.12.2
Using flipper 0.17.2 from source at `.`
Installing safe_yaml 1.0.5
Fetching moneta 1.1.1
Installing dalli 2.7.10
Fetching redis 4.1.4
Installing diff-lcs 1.3
Fetching sequel 5.32.0
Installing moneta 1.1.1
Fetching formatador 0.2.5
Fetching rb-fsevent 0.10.4
Fetching lumberjack 1.2.4
Installing ffi 1.12.2 with native extensions
Installing formatador 0.2.5
Fetching nenv 0.3.0
Fetching shellany 0.0.1
Installing shellany 0.0.1
Fetching method_source 1.0.0
Installing nenv 0.3.0
Fetching thor 1.0.1
Installing method_source 1.0.0
Fetching guard-compat 1.2.1
Installing lumberjack 1.2.4
Fetching rspec-support 3.9.3
Installing thor 1.0.1
Installing rb-fsevent 0.10.4
Fetching parallel 1.19.1
Fetching rainbow 3.0.0
Installing guard-compat 1.2.1
Fetching rexml 3.2.4
Installing parallel 1.19.1
Installing rspec-support 3.9.3
Installing rainbow 3.0.0
Fetching ruby-progressbar 1.10.1
Fetching unicode-display_width 1.7.0
Fetching hashdiff 1.0.1
Installing unicode-display_width 1.7.0
Fetching sqlite3 1.3.13
Installing hashdiff 1.0.1
Installing rexml 3.2.4
Fetching statsd-ruby 1.2.1
Fetching i18n 1.8.2
Installing ruby-progressbar 1.10.1
Fetching nokogiri 1.10.9
Installing sqlite3 1.3.13 with native extensions
Installing statsd-ruby 1.2.1
Fetching tzinfo 1.2.7
Installing sequel 5.32.0
Installing i18n 1.8.2
Fetching websocket-driver 0.7.1
Fetching mail 2.7.1
Installing redis 4.1.4
Fetching minitest-documentation 1.0.0
Installing websocket-driver 0.7.1 with native extensions
Installing tzinfo 1.2.7
Fetching rack-test 0.6.3
Installing minitest-documentation 1.0.0
Fetching rack-protection <IP_ADDRESS>
Installing rack-test 0.6.3
Fetching sprockets 4.0.0
Installing rack-protection <IP_ADDRESS>
Fetching shotgun 0.9.2
Fetching parser <IP_ADDRESS>
Installing mail 2.7.1
Fetching addressable 2.7.0
Installing shotgun 0.9.2
Fetching marcel 0.3.3
Installing sprockets 4.0.0
Fetching coffee-script 2.4.1
Installing marcel 0.3.3
Fetching crack 0.4.3
Installing addressable 2.7.0
Using flipper-api 0.17.2 from source at `.`
Installing coffee-script 2.4.1
Using flipper-cloud 0.17.2 from source at `.`
Installing parser <IP_ADDRESS>
Using flipper-dalli 0.17.2 from source at `.`
Installing crack 0.4.3
Using flipper-moneta 0.17.2 from source at `.`
Fetching mongo 2.12.1
Fetching notiffany 0.1.3
Fetching rspec-mocks 3.9.1
Fetching rspec-core 3.9.2
Fetching rspec-expectations 3.9.2
Fetching pry 0.13.1
Installing notiffany 0.1.3
Using flipper-sequel 0.17.2 from source at `.`
Using flipper-redis 0.17.2 from source at `.`
Fetching rollout 2.4.5
Installing rspec-expectations 3.9.2
Fetching activesupport 6.0.3
Installing rspec-mocks 3.9.1
Using flipper-ui 0.17.2 from source at `.`
Fetching rb-inotify 0.10.1
Installing rspec-core 3.9.2
Fetching rubocop 0.83.0
Installing rollout 2.4.5
Fetching webmock 3.8.3
Installing pry 0.13.1
Fetching rspec 3.9.0
Installing rb-inotify 0.10.1
Using flipper-rollout 0.17.2 from source at `.`
Fetching listen 3.2.1
Installing rspec 3.9.0
Fetching sass-listen 4.0.0
Installing activesupport 6.0.3
Fetching globalid 0.4.2
Installing listen 3.2.1
Fetching activemodel 6.0.3
Installing webmock 3.8.3
Using flipper-active_support_cache_store 0.17.2 from source at `.`
Fetching guard 2.16.2
Installing sass-listen 4.0.0
Fetching sass 3.7.4
Installing globalid 0.4.2
Fetching activejob 6.0.3
Installing rubocop 0.83.0
Installing guard 2.16.2
Installing activemodel 6.0.3
Fetching guard-bundler 2.2.1
Fetching guard-coffeescript 2.0.1
Installing activejob 6.0.3
Fetching guard-rspec 4.7.3
Fetching activerecord 6.0.3
Installing guard-bundler 2.2.1
Fetching guard-rubocop 1.3.0
Installing guard-coffeescript 2.0.1
Fetching rubocop-rspec 1.39.0
Installing sass 3.7.4
Fetching guard-sass 1.6.1
Installing guard-rspec 4.7.3
Installing guard-rubocop 1.3.0
Installing guard-sass 1.6.1
Installing rubocop-rspec 1.39.0
Installing mongo 2.12.1
Using flipper-mongo 0.17.2 from source at `.`
Installing activerecord 6.0.3
Using flipper-active_record 0.17.2 from source at `.`
Installing nokogiri 1.10.9 with native extensions
Fetching rails-dom-testing 2.0.3
Fetching loofah 2.5.0
Installing rails-dom-testing 2.0.3
Installing loofah 2.5.0
Fetching rails-html-sanitizer 1.3.0
Installing rails-html-sanitizer 1.3.0
Fetching actionview 6.0.3
Installing actionview 6.0.3
Fetching actionpack 6.0.3
Installing actionpack 6.0.3
Fetching actioncable 6.0.3
Fetching actionmailer 6.0.3
Fetching railties 6.0.3
Fetching sprockets-rails 3.2.1
Fetching activestorage 6.0.3
Installing sprockets-rails 3.2.1
Installing actionmailer 6.0.3
Installing actioncable 6.0.3
Installing activestorage 6.0.3
Fetching actionmailbox 6.0.3
Fetching actiontext 6.0.3
Installing actiontext 6.0.3
Installing actionmailbox 6.0.3
Installing railties 6.0.3
Fetching rails 6.0.3
Installing rails 6.0.3
Bundle complete! 32 Gemfile dependencies, 111 gems now installed.
Bundled gems are installed into `/bundle_cache`
Post-install message from i18n:

HEADS UP! i18n 1.1 changed fallbacks to exclude default locale.
But that may break your application.

If you are upgrading your Rails application from an older version of Rails:

Please check your Rails app for 'config.i18n.fallbacks = true'.
If you're using I18n (>= 1.1.0) and Rails (< 5.2.2), this should be
'config.i18n.fallbacks = [I18n.default_locale]'.
If not, fallbacks will be broken in your app by I18n 1.1.x.

If you are starting a NEW Rails application, you can ignore this notice.

For more info see:
https://github.com/svenfuchs/i18n/releases/tag/v1.1.0

Post-install message from sass:

Ruby Sass has reached end-of-life and should no longer be used.

* If you use Sass as a command-line tool, we recommend using Dart Sass, the new
  primary implementation: https://sass-lang.com/install

* If you use Sass as a plug-in for a Ruby web framework, we recommend using the
  sassc gem: https://github.com/sass/sassc-ruby#readme

* For more details, please refer to the Sass blog:
  https://sass-lang.com/blog/posts/7828841

Test suite is failing because of these un-related details:
Inspecting 220 files
......................................................................................................................................................................W.......................................C.............
Offenses:
spec/flipper/feature_spec.rb:211:88: W: Lint/RedundantCopDisableDirective: Unnecessary disabling of RSpec/RepeatedDescription.
      it "always instruments #{thing.inspect} as #{wrapped_thing.class} for enable" do # rubocop:disable RSpec/RepeatedDescription
                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/flipper/feature_spec.rb:300:90: W: Lint/RedundantCopDisableDirective: Unnecessary disabling of RSpec/RepeatedDescription.
      it "always instruments #{thing.inspect} as #{wrapped_thing.class} for enabled?" do # rubocop:disable RSpec/RepeatedDescription
                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/integration_spec.rb:4:1: C: RSpec/FilePath: Spec path should end with flipper*_spec.rb.
RSpec.describe Flipper do
^^^^^^^^^^^^^^^^^^^^^^
220 files inspected, 3 offenses detected

Perhaps Rubocop settings for Lint/RedundantCopDisableDirective could be adjusted or we could just fix these issues. Either way, I can take care of them 👍

Failing tests are un-related to this PR - There's a separate PR addressing that: https://github.com/jnunemaker/flipper/pull/462

Failing tests are un-related to this PR - There's a separate PR addressing that: #462

PR #462 rebased on this PR - test suite green again : )

@jnunemaker this PR is ready and works like a charm 🚀


Upgrade to Acorn 5.0.0

Acorn 5.0.0 introduces a breaking change to conform to what other ESTree-compatible parsers are doing for export default declarations (see https://github.com/ternjs/acorn/issues/512). This means that FunctionDeclaration and ClassDeclaration nodes are no longer guaranteed to have an id property. This patch updates the version of the acorn dependency and fixes the code where it assumed such a property is never null.
I was not able to run the tests on my machine (clone, npm install, npm test produced a Cannot find module 'webpack/lib/Chunk' error), so I'm hoping the CI will run them for me.

Hey you passed the CI on the first try.... Yeah :tada:

Thanks


add _filter to variance and mean

closes #380
@haesleinhuepf _box and _phere version still exist.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.70%. Comparing base (4e8662d) to head (4ed614e).

Files with missing lines
Patch %
Lines

clic/src/tier2/detect_maxima.cpp
0.00%
0 Missing and 1 partial :warning:

clic/src/tier2/detect_maxima_box.cpp
0.00%
1 Missing :warning:

clic/src/tier2/detect_minima.cpp
0.00%
0 Missing and 1 partial :warning:

clic/src/tier2/detect_minima_box.cpp
0.00%
1 Missing :warning:

clic/src/tier2/standard_deviation.cpp
0.00%
1 Missing :warning:

clic/src/tier2/standard_deviation_box.cpp
0.00%
0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #381   +/-   ##
=======================================
  Coverage   47.70%   47.70%
=======================================
  Files         243      243
  Lines        4000     4000
  Branches     1830     1830
=======================================
  Hits         1908     1908
  Misses        660      660
  Partials     1432     1432

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Masonry: Request layout does not implicitly start a redraw

If, when responding to an event, you change state which will be updated in layout, the way you have to handle that is:
ctx.request_layout();
ctx.request_paint();

e.g.
https://github.com/linebender/xilem/blob/aaeeadbbd75a3984e404c2d545fcf7e8abaa72f0/crates/masonry/src/widget/textbox.rs#L182-L184
Otherwise, the update does not actually get drawn. This is not very ergonomic, and is a significant footgun in the masonry layer that this does not happen. We need to find a solution here. That might just be that request_layout also requests a paint; this should be at the right level in the passes

Maybe we can request a paint, when the layout pass needs it? So that when layout doesn't change anything that requires a repaint, we can save a paint pass? But maybe this is also too much of a footgun, and a layout request should just imply a paint request.

That's a subtly different question, I think. This is about scheduling a layout to actually happen. Currently, that is the next time a paint is requested, because only needs_paint sends Winit a redraw requested command - handling that is when the layout/paint pass actually happens

Yeah probably a subtly different question. I do think though, it's not necessarily a footgun when we have a good testsuite. One just needs to remember what may really have changed and request all the passes that are necessary for that. And when one of the passes requires a further pass, that should be reflected in that pass.
I just checked, currently at least a layout pass implies a repaint:
https://github.com/linebender/xilem/blob/aaeeadbbd75a3984e404c2d545fcf7e8abaa72f0/crates/masonry/src/widget/widget_pod.rs#L848-L849
But when checking e.g.
https://github.com/linebender/xilem/blob/aaeeadbbd75a3984e404c2d545fcf7e8abaa72f0/crates/masonry/src/widget/image.rs#L59-L64
this could indeed be a footgun, when the TODO would be resolved and the image dimensions haven't changed in a new ImageBuf...


Courses fr from @adamzebiche #3938

What does this PR do?
Add cleaned-up Courses-fr from @adamzebiche #3938

any comments from @innocenzi or @x0rld ?

primeFX has bad reputation too

primefx seems popular enough, though.


Bugfixes

Signed-off-by: DIMITRIS KARNIKIS<EMAIL_ADDRESS>

If these are necessary (and don't break the installation process) let's merge them immediately! @dkarnikis


Rendering issues with some ultrasound studies

Bug Report
Describe the Bug
One of our users reported us visualization issues with some DICOMS generated by the same ultrasound machine. We've compared the Dicoms tags of the problematic studies with the tags of normal ultrasounds, but we can't find relevant differences. This issue only happens with Ohif Viewer, in Horos and Weasis all of this images are rendered without problems.
The problem is that images are rendered inverted on his vertical axis and the only workaround is to zoom-in it, after that the image is correctly rendered.
An anonymized example a problematic study can be downloaded here: https://drive.google.com/file/d/1Z97rYEpoXPcq0k6GyLO08UnejxoSbFpc/view?usp=sharing
What steps can we follow to reproduce the bug?

Download the study
Open it with Ohif viewer
The image is rendered vertically inverted
Zoom-in it solves the problem

Anyone have some idea of what is the root of the problem?

This is certainly a weird one.
I tried on cornerstone3D itself (https://www.cornerstonejs.org/live-examples/local.html) and works fine, so i'm wondering if
it is a metadata provider issue, like OHIF is giving some metadata that shouldn't

Does anyone have any idea which field is causing problems? I have the same problem in some studies and I can try to solve it (or modify the metadata of that study).

Please review the latest code in the master branch. I am confident that this issue has been resolved. If it persists, kindly reopen the issue with updated details.
Try viewer-dev.ohif.org instead of viewer.ohif.org
Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master  branch
Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing


Fix invalid database resulting from failed DROP DB

Problem
If the control plane happened to respond to a DROP DATABASE request with a non-200 response, we'd abort the DROP DATABASE transaction in the usual spot. However, Postgres for some reason actually performs the drop inside of standard_ProcessUtility. As such, the database was left in a weird state after aborting the transaction. We had test coverage of a failed CREATE DATABASE but not a failed DROP DATABASE.
Summary of changes
Since DROP DATABASE can't be inside of a transaction block, we can just forward the DDL changes to the control plane inside of ProcessUtility_hook, and if we respond with 500 bail out of ProcessUtility before we perform the drop. This change also adds a test, which reproduced the invalid database issue before the fix was applied.
Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Nice, thank you! Without this hook does this test reproduce that 'invalid database' state?

Without this hook does this test reproduce that 'invalid database' state?
Yes, I was getting the hint in the test

E       psycopg2.OperationalError: connection to server at "localhost" (::1), port 15011 failed: FATAL:  cannot connect to invalid database "failure"
E       HINT:  Use DROP DATABASE to drop invalid databases.

And also it was failing consistently across all versions
============================================================================================== short test summary info ===============================================================================================
FAILED test_runner/regress/test_ddl_forwarding.py::test_ddl_forwarding[debug-pg14] - psycopg2.OperationalError: connection to server at "localhost" (::1), port 15001 failed: FATAL:  cannot connect to invalid database "failure"
FAILED test_runner/regress/test_ddl_forwarding.py::test_ddl_forwarding[debug-pg15] - psycopg2.OperationalError: connection to server at "localhost" (::1), port 15003 failed: FATAL:  cannot connect to invalid database "failure"
FAILED test_runner/regress/test_ddl_forwarding.py::test_ddl_forwarding[debug-pg16] - psycopg2.OperationalError: connection to server at "localhost" (::1), port 15005 failed: FATAL:  cannot connect to invalid database "failure"
FAILED test_runner/regress/test_ddl_forwarding.py::test_ddl_forwarding[release-pg14] - psycopg2.OperationalError: connection to server at "localhost" (::1), port 15007 failed: FATAL:  cannot connect to invalid database "failure"
FAILED test_runner/regress/test_ddl_forwarding.py::test_ddl_forwarding[release-pg15] - psycopg2.OperationalError: connection to server at "localhost" (::1), port 15009 failed: FATAL:  cannot connect to invalid database "failure"
FAILED test_runner/regress/test_ddl_forwarding.py::test_ddl_forwarding[release-pg16] - psycopg2.OperationalError: connection to server at "localhost" (::1), port 15011 failed: FATAL:  cannot connect to invalid database "failure"


your paper table4 issue

abviously, the 40.20 is bigger than 39.05

Hi @HouTong-s, thank you for bringing this to our attention. This correction will be integrated into the next arXiv paper version update.


Fix Redis Rust component instantiation

Fixes #1650.
I am not sure if this is the right solution - I have a rough sense for what it's doing, but it is cargo-culted in from the HTTP component macro rather!  It did seem to fix it in my limited testing but you folks are the experts...

-_______________- 😆 https://github.com/fermyon/spin/pull/1652

I will close mine!

I think the e2e fail is because e2e uses the template, which points to the tag, which has not yet been updated.  So I am merging this despite the failure.


[BUG]: Stratified model configuration - add uncertainty

Scenario: https://github.com/DARPA-ASKEM/terarium/blob/main/testing/manual/model-configuration-input.md
Step: 4
Link to the project: https://app.staging.terarium.ai/projects/3215b073-4869-4b1d-8cfb-1c2f961b1108/workflow/cb0f1edc-0b60-42a3-9243-8364fe7fabdd?operator=a1460315-b8f0-403c-ae54-8d89c72f522b

Describe the issue
When utilizing the add uncertainty I do not see any selection boxes for parameters I also do not see any changes made to parameters.

@YohannParis @Tom-Szendrey
Checkboxes will only appear for Constant values not uniform ones.  Once I switched the value to constant the checkbox appears and the uncertainty is applied.


Feature/my progress plus plus

Add the following changes to the my progress page:

Add github style heatmap instead of the activity graph.
Add the most recently answered and easiest unsolved questions as links.
Add currently set assignments to page.

We have no merged the replacement for this, and so no longer need this. But it was a helpful stepping stone to the final thing!


Throws error when deleting 2 paragraphs d2ap

Steps to reproduce:

Open new file
Create 2 paragraphs
ggd2ap (go to beginning and attempt to delete 2 paragraphs)

Expected behaviour: The two paragraphs disappear.
Actual behaviour: Throws error.
The same problem occurs with d2ip, and 2dap does not delete both paragraphs.
Atom Version: 0.200.0
System: linux 3.18.1-1-chromebook
Thrown From: vim-mode package, v0.54.0
Stack Trace
Uncaught TypeError: undefined is not a function
At /home/zaz/.atom/packages/vim-mode/lib/vim-state.coffee:263

TypeError: undefined is not a function
  at Repeat.Prefix.isLinewise (/home/zaz/.atom/packages/vim-mode/lib/prefixes.coffee:30:21)
  at Delete.Operator.setTextRegister (/home/zaz/.atom/packages/vim-mode/lib/operators/general-operators.coffee:51:17)
  at Delete.execute (/home/zaz/.atom/packages/vim-mode/lib/operators/general-operators.coffee:96:8)
  at VimState.module.exports.VimState.processOpStack (/home/zaz/.atom/packages/vim-mode/lib/vim-state.coffee:266:23)
  at VimState.module.exports.VimState.processOpStack (/home/zaz/.atom/packages/vim-mode/lib/vim-state.coffee:258:10)
  at VimState.module.exports.VimState.processOpStack (/home/zaz/.atom/packages/vim-mode/lib/vim-state.coffee:258:10)
  at VimState.module.exports.VimState.pushOperations (/home/zaz/.atom/packages/vim-mode/lib/vim-state.coffee:224:8)
  at atom-text-editor.commands.(anonymous function) (/home/zaz/.atom/packages/vim-mode/lib/vim-state.coffee:196:45)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app.asar/src/command-registry.js:238:29)
  at /usr/share/atom/resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/usr/share/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:519:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/usr/share/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:354:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/usr/share/atom/resources/app.asar/src/window-event-handler.js:178:20)

Commands
     -0:40.4.0 blur (atom-text-editor.editor.mini.is-focused)
     -0:39.7.0 pane:reopen-closed-item (ul.list-inline.tab-bar.inset-panel)
     -0:31.2.0 application:open-file (ul.list-inline.tab-bar.inset-panel)
  7x -0:31.1.0 blur (ul.list-inline.tab-bar.inset-panel)
     -0:21.7.0 vim-mode:activate-insert-mode (atom-text-editor.editor.vim-mode.command-mode.is-focused)
  2x -0:15.9.0 core:backspace (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
  2x -0:11.7.0 editor:newline (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:08.7.0 vim-mode:activate-command-mode (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
  3x -0:08.1.0 vim-mode:move-up (atom-text-editor.editor.vim-mode.is-focused.command-mode)
     -0:04.8.0 vim-mode:delete (atom-text-editor.editor.vim-mode.is-focused.command-mode)
     -0:04.5.0 vim-mode:select-around-paragraph (atom-text-editor.editor.vim-mode.is-focused.operator-pending-mode)
     -0:04.0 vim-mode:undo (atom-text-editor.editor.vim-mode.is-focused.command-mode)
  3x -0:02.6.0 vim-mode:move-up (atom-text-editor.editor.vim-mode.is-focused.command-mode)
     -0:01.5.0 vim-mode:delete (atom-text-editor.editor.vim-mode.is-focused.command-mode)
     -0:01.5.0 vim-mode:repeat-prefix (atom-text-editor.editor.vim-mode.is-focused.operator-pending-mode)
     -0:01.1.0 vim-mode:select-around-paragraph (atom-text-editor.editor.vim-mode.is-focused.operator-pending-mode)

Config
{
  "core": {
    "disabledPackages": [
      "foldingtext-for-atom",
      "run-in-atom",
      "coffee-lint",
      "markdown-preview"
    ],
    "autoHideMenuBar": true
  }
}

Installed Packages
# User
atom-runner, v2.4.1
git-diff-details, v0.18.0
linter-coffeelint, v1.0.0
markdown-preview-plus, v1.5.0
mathjax-wrapper, v0.1.0
vim-mode, v0.54.0
vim-surround, v0.7.2

# Dev
No dev packages

@zaz can you try to upgrade to Atom 1.0.0 and see if you can still reproduce this?  Thanks.

@50Wliu: Yes. The issue still occurs on Atom 1.0.0.
Atom Version: 1.0.0
System: "Arch Linux"
Thrown From: vim-mode package, v0.54.0
Stack Trace
Uncaught TypeError: undefined is not a function
At /home/zaz/.atom/packages/vim-mode/lib/vim-state.coffee:263

TypeError: undefined is not a function
    at Repeat.Prefix.isLinewise (/home/zaz/.atom/packages/vim-mode/lib/prefixes.coffee:37:34)
    at Delete.Operator.setTextRegister (/home/zaz/.atom/packages/vim-mode/lib/operators/general-operators.coffee:64:90)
    at Delete.execute (/home/zaz/.atom/packages/vim-mode/lib/operators/general-operators.coffee:137:14)
    at VimState.module.exports.VimState.processOpStack (/home/zaz/.atom/packages/vim-mode/lib/vim-state.coffee:775:32)
    at VimState.module.exports.VimState.processOpStack (/home/zaz/.atom/packages/vim-mode/lib/vim-state.coffee:762:23)
    at VimState.module.exports.VimState.processOpStack (/home/zaz/.atom/packages/vim-mode/lib/vim-state.coffee:762:23)
    at VimState.module.exports.VimState.pushOperations (/home/zaz/.atom/packages/vim-mode/lib/vim-state.coffee:725:28)
    at atom-text-editor.commands.(anonymous function) (/home/zaz/.atom/packages/vim-mode/lib/vim-state.coffee:691:26)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app.asar/src/command-registry.js:241:29)
    at /usr/share/atom/resources/app.asar/src/command-registry.js:3:61

Commands
     -0:02.0 vim-mode:delete (atom-text-editor.editor.vim-mode.command-mode.is-focused)
     -0:02.0 vim-mode:repeat-prefix (atom-text-editor.editor.vim-mode.is-focused.operator-pending-mode)
     -0:01.5.0 vim-mode:select-around-paragraph (atom-text-editor.editor.vim-mode.is-focused.operator-pending-mode)

Config and installed packages same as above.

@50Wliu – I've reproduced it with a simple d2ap anywhere.

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


Stop using GitHub personal access tokens on Travis

This may not be possible but here to allow us to explore/discuss the options.

Is this a case of replacing it with an OAuth token generated from the org level?

I couldn't see anything at the org level but it may be because I'm not an org admin.

Try again

Closing this as we are no longer using an individual's access token


Update aqua-trivy-scanner-reference.md

Correct bullet list for Trivy settings
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[X] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Preview environment: https://ci.pr.harness.io/pr-459


chore: release v0.3.1

:robot: I have created a release beep boop
0.3.1 (2024-04-30)
What's Changed

chore(deps): bump anyhow from 1.0.81 to 1.0.82 by @dependabot in https://github.com/coffeebeats/gdpack/pull/223
chore(deps): bump typed-builder from 0.18.1 to 0.18.2 by @dependabot in https://github.com/coffeebeats/gdpack/pull/225
chore(deps): bump serde from 1.0.197 to 1.0.198 by @dependabot in https://github.com/coffeebeats/gdpack/pull/224
chore(deps): bump toml_edit from 0.22.9 to 0.22.10 by @dependabot in https://github.com/coffeebeats/gdpack/pull/226
chore(deps): bump toml_edit from 0.22.10 to 0.22.12 by @dependabot in https://github.com/coffeebeats/gdpack/pull/227
chore(deps): bump reqwest from 0.12.3 to 0.12.4 by @dependabot in https://github.com/coffeebeats/gdpack/pull/228
chore(deps): bump thiserror from 1.0.58 to 1.0.59 by @dependabot in https://github.com/coffeebeats/gdpack/pull/229
chore(deps): bump zip from 0.6.6 to 1.1.1 by @dependabot in https://github.com/coffeebeats/gdpack/pull/230
chore(deps): bump zip from 1.1.1 to 1.1.2 by @dependabot in https://github.com/coffeebeats/gdpack/pull/232
chore(deps): bump serde from 1.0.198 to 1.0.199 by @dependabot in https://github.com/coffeebeats/gdpack/pull/233
chore(deps): bump rstest from 0.18.2 to 0.19.0 by @dependabot in https://github.com/coffeebeats/gdpack/pull/222

Full Changelog: https://github.com/coffeebeats/gdpack/compare/v0.3.0...v0.3.1

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/coffeebeats/gdpack/releases/tag/v0.3.1 :sunflower:


[Question] Figures and captions

Question
Hi, is this library also able to use multi-modal LLMs to interpret charts and figures within PDF documents?

Hello @austinmw,
Thank you for your question. Currently, Docling does not offer this feature. However, our team is actively working on introducing an image classifier model first, and then a multi-modal LLM that can convert charts into structured formats like JSON, CSV, and Markdown. Stay tuned!

@Matteo-Omenetti keep us updated on this!


Create Login and Register Frontend Page

Create Login and register page

Create Register page with username, email, passworfd , confirm password fields
Create  Login page with email, password.

To be completed before 1:00 PM on 31-12-2023


FOGL-1773 sense HAT plugin code added with debian package structure

Features
The Sense HAT features an 8x8 RGB LED matrix, a mini joystick and the following sensors:

[x] Gyroscope
[x] Accelerometer
[x] Magnetometer
[x] Temperature
[x] Humidity
[x] Barometric pressure

Do we really need to implement 8x8 RGB LED and joystick implementation?

re: Do we really need to implement 8x8 RGB LED and joystick implementation?
For now, no. However, @MarkRiddoch, we should think about how to fit control into our architecture.

Actually, please implement joystick as the API returns: {"direction": "up", "action": "pressed"}.
Functionally, this looks great. Please resolve the feedback called out in this PR and commit it to the develop branch ASAP.

@billehunt @praveen-garg feedback changes incorporated and joystick feature implemented.


Support for embed migrations

There is a lack of support for built-in migrations.
Example:
https://docs.diesel.rs/master/diesel_migrations/macro.embed_migrations.html

Embed migrations seems nice ☺ I add it in the same time I work on !76

Btw, PR's are welcome ofc :)

Geni was built to be a CLI and not to be something integrated within production apps. Better to use something built for be running in prod rather then geni


support for version 2.8.1 (#362)

support for version 2.8.1 (#362)

Summary by CodeRabbit

New Features

Updated the application to version 2.8.1, enhancing overall functionality.
Improved Docker environment with updated versions of Airflow, Watchtower, and Provider Amazon.
Enhanced compatibility and performance through updated Apache Airflow providers for various services (Amazon, Celery, SQL, FTP, HTTP, IMAP, Postgres, SQLite).
Updated documentation to reflect the new version of Airflow and guide on plugin creation.

Bug Fixes

Adjusted environment variables and scripts to align with the updated software versions, ensuring smoother operations.

Chores

Updated requirements to include newer versions of Snowflake and MySQL providers, optimizing compatibility and performance.

@egonzalezfsl @ronco @G00SE-EGG @oscarito-taquito MWAA has released another airflow version update. FYI Will be upgrading airflow prod to 2.8 instead of 2.7, will release the upgrade for local stack here in this PR.


Settings - Search

Upgrade Sheet Settings so one can search by the setting name or setting hint text. The search criteria should be case-insensitive and use "contains" logic.
Stretch
Highlight text that matches search criteria

This would be cool, but it's not worth the effort and time, given all the other things goals I have.


[Question] Is there a way to have auto-batch fitting?

From  https://github.com/awslabs/sockeye/blob/master/CHANGELOG.md#11885 and https://github.com/awslabs/sockeye/pull/662 , we understand that the auto-batching should be disable because it's slow in inference, is it possible to enable only during training? Or is it also slow during training too?
Any pointers as to how should we go about re-implementing a working and non-slow dynamic batching?

When you refer to dynamic batching in the context of training could you clarify what you mean? Are you referring to batch sizes that automatically fill the GPU until there's no memory left?

For training the batching strategies currently are to either create batches for a given number of words or for a given number of sentences.


Epic: Improve type system

This issue gathers discussions and issues related to the Projects type system. The plugin was released with a rather simple type system that needs some improvements. Since the type system is a corner-stone of the Projects plugin, a well-designed type system is crucial for the success of Projects.
Rationale
Notes are just text. Text can be incredibly powerful as it can contain pretty much anything, and users can use whichever editor they want to edit it. Unfortunately, the downside of this power is that you can't make any assumptions on pure text.
The purpose of the Projects type system is to extract well-known types of data from pure text so that any views can act as if they communicated with a database.
For example, if Projects detects the text publish: true between a pair of delimiters, ---, it detects it as a boolean field (true/false).
By defining a piece of text to have a type, we can also define operations on those types. Boolean fields can be toggled on and off. Numbers can be used for mathematical operations.
Since they no longer need to care about parsing text, views become easier to build. And since they have a shared understanding of the data, the user can define the data once, and view it in many different ways.
Design
The type system is the same regardless of where the data came from. In Projects, data sources acts as translation layers (or adapters) that convert data into the shared data format.
For example, the front matter data source knows how to convert from YAML front matter, and the Dataview data source know how to convert the Dataview result into a shared format.
Challenges
Fields have multiple types
Consider the following two notes:
publish: true

publish: 3

When the data source read the first note, it detects publish as a boolean field. When it reads the second note, it detects publish as a numeric field. Since the type system can't determine the type, it needs to fall back to a common denominator. Hence publish is detected as a String field.
Related issues:

#71
#100
#183

Missing type information
If a field is empty (null) in all notes, there's nothing we can use to detect the type. In this case, the plugin should fall back to a String field.
publish:

publish:

Complex types
Notes may also contain complex type. For example, the Kindle plugin adds the following front matter:
kindle-sync:
  bookId: '3759'
  title: Design for How People Learn (Voices That Matter)
  author: Dirksen Julie
  asin: B018OJP5QW
  lastAnnotatedDate: '2022-05-06'
  bookImageUrl: 'https://m.media-amazon.com/images/I/51M0cX78XnL._SY160.jpg'
  highlightsCount: 1

Projects should not attempt to edit fields it doesn't understand. Ideally, I'd like to detects these as nested types, types that can contains other types. That way, you could still build a Kindle view that understands the field value. Other views might not even display them.
Repeated fields
Consider the following examples where values is a field containing multiple values that may or may not share the same type.
values:
  - 10
  - 20
  - 30

values:
  - 12
  - true
  - [[Hello]]

I propose that we introduce a repeated property for each field. The type of the field is detected as if the repeated values came from separate notes. For example, in the first example, values would be detected as a repeated number, and in the second example, it would be a repeated string (because of falling back to string).
Rich-text support
In the following example, all of these front matter properties would be detected as text (string) fields:
---
math: $x^2$
html: This has HTML in it
markdown: This is **Markdown** formatted text
---

# My note

Should these be implemented as separate field types, separate from the String field type? For example, HTML fields and Markdown fields, or should the current String type support parsing of these formats?
In the case of separate field types, automatically detecting these field types would be tricky, so the user would likely have to tell which String fields that should be parsed in a certain way.
If we assume that all cells of String fields can have Markdown, HTML, Latex, it will likely have a non-trivial performance hit on projects with a lot of notes.

Related issues:

#66
#64

Fields derived from Markdown content
The type system should support Markdown elements, such as tasks. Ideally, I'd like to find a way to avoid creating specific types for Markdown content, but rather reuse the standard types.
## Heading

- [ ] Do this
- [ ] Do that
- [x] Already did that

## Another heading

- [ ] Do this
- [ ] Do that
- [x] Already did that

Markdown elements could be represented as repeated fields. For example, tasks could be typed as repeated boolean fields and headings as repeated string fields.
Related issues:

#149
#164

In the case of separate field types, automatically detecting these field types would be tricky, so the user would likely have to tell which String fields that should be parsed in a certain way.

i actually like the idea of separate string field types, and having the user distinguish between them via a dropdown setting.
as for how the type would be persisted, i was thinking of using frontmatter like this:
stringfield:
  type: html
  content:
nice job!

stringfield:
  type: html
  content:
nice job!

This would introduce a custom format, which would go against the leave no trace principle. We could of course parse all string fields as if they contained HTML, Markdown, LaTex etc, but that would likely be a performance hit.
Maybe the user just have to choose to enable parsing for the fields they want parsed.

but that would likely be a performance hit.
How about auto-detection combined with user-specified types?

When initializing the project or a new field detected, run type detection and save the results as project-level configuration. User can define another type which overides the detected ones. "Type" here affects how data parsed, displayed and edit, while the raw values are still in string forms.
To deal with incorrect existed values, just not parse them and display them in string format. When a incorrect input detected, send message as notificaion.
To parse user-defined/complex types, provide custom parsers to transfer string into different views.

Hi. I am the developer or 3d graph and frontmatter generator. I made a video about how to make tag properties using frontmatter generator. Basically I can strong typed the properties using zod.
recently I have been thinking about ways to integrate frontmatter generator with Projects. Hopefully It can help. Also I am interested in helping out making Projects work more seamlessly with frontmatter generator.

r. Basically I can strong typed the properties using zod.
recently I have been thinking about ways to integrate frontmatter generator with Projects. Hopefully It can help. Also I am interested in helping out making Projects work more seamlessly with frontmatter generator.

Did they allow you to help? It'd been half a year.


strings: Add a function to get the nth rune in string

Is there any already?

Well you just do ([]rune(myString))[n].
Obligatory comment that this issue tracker is not for asking questions but for bugs and proposals only.
You can turn your question into a proposal by filling out the proposal issue template.

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues # Asking Questions
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For asking questions, see:

Stack Overflow with questions tagged "go"

The Go Forum, a web-based forum

Gophers Slack, use the invite app for access. The #general channel is a good starting point.

Go Community on Hashnode with questions and posts tagged with "go"

The golang-nuts mailing list

IRC channel #go-nuts on Freenode

you could just give a good answer instead of writing that big comment.

@qlcom You already got an answer, above.
We're trying to help you ask questions in the right place.  You will get better and faster answers there.  Thanks.


Return full size of image by default

Issue
With the changes introduced in https://github.com/timber/timber/pull/1320, Timber doesn’t return the full source of an image when the src method is called without a parameter. Instead, it returns the default size of wp_get_attachment_image_src(), which is thumbnail. @davidmaneuver already mentioned this in https://github.com/timber/timber/pull/1320#commitcomment-20979891.
As I understand it, the default size should be full, because otherwise filters like the following would resize the thumbnail src instead of the full size.
<img src="{{ post.thumbnail.src|resize(640) }}" />

would result in a src like
http://example.org/wp-content/uploads/2016/03/dog-150x150-c-default-640x0-c-default.jpg

Solution
Change default parameter for $size from '' (empty) to 'full' in Image::src().
Impact
Restores default behaviour?
Testing
No (unfortunately, I’m still too inexperienced in testing).

Coverage remained the same at 97.376% when pulling d32af82db6e619ca1ab3f4681319113636f5f2d6 on gchtr:fix-image-src into 052e91079953d2770b7730e352d9a681a37611cd on timber:master.

Codecov Report

Merging #1330 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #1330   +/-   ##
=========================================
  Coverage     97.65%   97.65%
  Complexity     1403     1403
=========================================
  Files            45       45
  Lines          3283     3283
=========================================
  Hits           3206     3206
  Misses           77       77

Impacted Files
Coverage Δ
Complexity Δ

lib/Image.php
100% <100%> (ø)
66 <2> (ø)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052e910...d32af82. Read the comment docs.

Thanks @gchtr — great find and fix


⚠ Spryr has degraded performance

In 7bebf07, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 5214 ms

Resolved: Spryr performance has improved in 456ff19 after 11 minutes.


Multiple errors on brew install , brew doctor, brew upgrade

Checklist:

[x] Confirmed this is a problem with running a brew command and not brew installing or the post-install behaviour of one or more formulae? If it's a formulae-specific problem please file this issue at the relevant tap e.g. for Homebrew/homebrew-core https://github.com/Homebrew/homebrew-core/issues/new
[x] Ran brew update and retried your prior step?

Already up-to-date.

[x] Ran brew doctor, fixed all issues and retried your prior step?

Note: running brew doctor also throws up a similar list of errors

[x] Ran brew config and brew doctor and included their output with your issue?

Here is my brew config:

HOMEBREW_VERSION: >1.0.0 (no git repository)
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: 63122c241ce5c46e8201fe55773632e11e7eb187
Last commit: 1 year, 4 months ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 83f665fe3cefb8adeb0c447343d813eb30eea579
Core tap last commit: 7 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_REPOSITORY: /usr/local/Homebrew
HOMEBREW_CELLAR: /usr/local/Cellar
HOMEBREW_BOTTLE_DOMAIN: https://homebrew.bintray.com
CPU: octa-core 64-bit haswell
Homebrew Ruby: 2.0.0-p648
Clang: 9.0 build 900
Git: 2.14.1 => /usr/local/bin/git
Perl: /usr/bin/perl
Python: /usr/bin/python
Ruby: /Users/734665/.rbenv/shims/ruby => /Users/734665/.rbenv/versions/2.1.2/bin/ruby
Java: 1.7.0_45
macOS: 10.12.6-x86_64
Xcode: 9.2
CLT: <IP_ADDRESS>.1.1510905681
X11: N/A

To help us debug your issue please explain:

What you were trying to do (and why)

I was trying to install python3 and came across the errors. I then ran brew update, brew upgrade (error'd) and brew doctor (error'd) in an attempt to troubleshoot.

What happened (include command output)

Here are the errors I get while trying to run brew doctor:

$ brew doctor
Error: /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/coreutils.rb:72: syntax error, unexpected <<
  def caveats; <<~EOS
                 ^
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/coreutils.rb:76: syntax error, unexpected tIDENTIFIER, expecting keyword_end
    can add a "gnubin" directory to your PATH from your bashrc like:
                                ^
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/coreutils.rb:76: syntax error, unexpected ':', expecting keyword_end
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/coreutils.rb:78: dynamic constant assignment
        PATH="#{opt_libexec}/gnubin:$PATH"
             ^
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/coreutils.rb:80: dynamic constant assignment
    Additionally, you can access their man pag...
                 ^
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/coreutils.rb:80: syntax error, unexpected tIDENTIFIER, expecting keyword_do or '{' or '('
    Additionally, you can access their man pages with ...
                         ^
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/coreutils.rb:81: syntax error, unexpected tIDENTIFIER, expecting keyword_end
    the "gnuman" directory to your MANPATH from your bashrc as well:
                          ^
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/coreutils.rb:81: syntax error, unexpected ':', expecting keyword_end
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/coreutils.rb:83: dynamic constant assignment
        MANPATH="#{opt_libexec}/gnuman:$MANPATH"
                ^
Please report this bug:
  https://git.io/brew-troubleshooting
/usr/local/Homebrew/Library/Homebrew/formulary.rb:25:in `module_eval'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:25:in `load_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:42:in `load_formula_from_path'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:97:in `load_file'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:88:in `klass'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:84:in `get_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:222:in `factory'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1411:in `[]'
/usr/local/Homebrew/Library/Homebrew/diagnostic.rb:944:in `check_for_non_prefixed_coreutils'
/usr/local/Homebrew/Library/Homebrew/cmd/doctor.rb:43:in `block in doctor'
/usr/local/Homebrew/Library/Homebrew/cmd/doctor.rb:35:in `each'
/usr/local/Homebrew/Library/Homebrew/cmd/doctor.rb:35:in `doctor'
/usr/local/Homebrew/Library/Homebrew/brew.rb:94:in `<main>'

What you expected to happen

I expected some troubleshooting information :(

Step-by-step reproduction instructions (by running brew commands)

The following brew commands error out for me:

brew upgrade
brew doctor
brew install [formula]

I suspect HOMEBREW_VERSION: >1.0.0 (no git repository) is a problem, though I can't find how to add a git repo for brew. I also suspect it might be an x-code problem, as I had just completed an update prior, but I'm not sure how to get to the bottom of it. Any help or direction at all would be very much appreciated.
Thanks :)

From https://github.com/Homebrew/brew/issues/3750#issuecomment-362154576:
brew update --force and if that doesn't work brew update-reset

Wow, that seems to have fixed it! Thank you so much!


Draft breaks under weird circumstances

Hi! My team and I were using draft to build a beautiful rich text editor, so first of all, thank you for open sourcing this, is great!
The issue that we found was this:

Focus on draft
Add an atomic block
Press up arrow an position in the first editable block (non-atomic)
Press del (on windows) or fn + del (on mac I think)
Try to write something
Error Uncaught Invariant Violation: Unknown DraftEntity key.

And draft is left broken
I think the solution will be focus in the next editable block and if there's none, add a new one.
I would like to hear what you guys think about this.
Thanks in advance, best regards, Gabriel.

Are you rendering children in your entity decorator?
On Tuesday, April 19, 2016, Gabriel Miranda<EMAIL_ADDRESS>wrote:

Hi! My team and I were using draft to build a beautiful rich text editor,
so first of all, thank you for open sourcing this, is great!
The issue that we found was this:

Focus on draft
Add an atomic block
Press up arrow an position in the first editable block (non-atomic)
Press del (on windows) or fn + del (on mac I think)
Try to write something
Error Uncaught Invariant Violation: Unknown DraftEntity key.

And draft is left broken
I think the solution will be focus in the next editable block and if
there's none, add a new one.
I would like to hear what you guys think about this.
Thanks in advance, best regards, Gabriel.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/facebook/draft-js/issues/326

@guitardave24 it doesn't matter, try it in the media example of this repo, it happens too

Any updates on this guys?

Yeah, this breaks if the text block with the cursor is empty, but seems to work properly otherwise. The cursor is left in an uncertain state, hence the error.
(I think the media examples may also have some selection state issues due to using window.prompt, I'm not sure. cc @tasti)
RichUtils.onBackspace and RichUtils.onDelete should handle this for you, though their behavior seems to need some tweaking for the empty block case.
I think the SelectionState is not being moved upward properly when the empty block is removed.

Correct. I fixed this by locally overriding backspace key command and
checking explicitly for the previous block as atomic, removing it, and
setting the style and cursor in the right place It's not much code and I
expect to delete it once draft is fixed.
Would paste code if I weren't on my phone
On Friday, April 22, 2016, Isaac Salier-Hellendag<EMAIL_ADDRESS>wrote:

Yeah, this breaks if the text block with the cursor is empty, but seems to
work properly otherwise. The cursor is left in an uncertain state, hence
the error.
(I think the media examples may also have some selection state issues due
to using window.prompt, I'm not sure. cc @tasti https://github.com/tasti
)
RichUtils.onBackspace
https://github.com/facebook/draft-js/blob/master/src/model/modifier/RichTextEditorUtil.js#L106
and RichUtils.onDelete
https://github.com/facebook/draft-js/blob/master/src/model/modifier/RichTextEditorUtil.js#L168
should handle this for you, though their behavior seems to need some
tweaking for the empty block case.
I think the SelectionState is not being moved upward properly when the
empty block is removed.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/facebook/draft-js/issues/326#issuecomment-213540151

Cool. Putting together a fix now.


Implementing Dark Mode Using Tailwind CSS.

Proposed title of article
Implementing Dark Mode using Tailwind CSS.
Introduction paragraph (2-3 paragraphs):
Dark mode/theme is gradually becoming one of the most used features on applications and operating systems. It lets a user change the color theme of an application to black or a color close to black. The applications and websites include a toggle switch/button that changes the theme only on the page/app.
In this tutorial, we will implement dark mode on a page using Tailwind CSS. We will create a small webpage using Tailwind, build a switch then add some JavaScript for it to work.
Key takeaways:

Reader will learn how to make their pages responsive to the color scheme they like.
Reader will be able to understand how adding a feature like Dark mode will improve the quality of the website.
Reader will understand more about Tailwind CSS and the Dark Mode feature.

References:
N/A
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Good afternoon and thank you for submitting your topic suggestion.
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it. @M0nicah

Hi @M0nicah
This sounds like a helpful topic. Please ensure your content is original and does not match what is available on the official documentation or other blog websites. Also, check that it doesn't conflict with content already available in section.
topic approved :rocket:


Prevent comments from a bot username from notifying

I will fix this in a separate commit

e158a1c5d9ca647ac8ca8f33f7c3b52237a5ac09 does this, but I recently saw v commenting on a market, so maybe we should just exclude manifold dream? https://manifold.markets/SG/will-elon-musk-buy-twitter-this-yea#VbOgpaneOKAaBZqRnyGI


Added Package.swift

Working with external project SPM in Xcode 11 and swift 5

‼ SvProgressHUD.bundle not found
⚠ https://forums.swift.org/t/draft-proposal-package-resources/29941/13


docs: add page on builder & consumer mappings

We've got different types of mappings now, and it isn't very intuitive, so here's a section about it.

@RajatPawar merging this. Can you move object and field mappings between Embed UI components and CLI when you get a chance?


use avatar images for chatbot

edit chatbot to have image and title
https://www.gradio.app/guides/agents-and-tool-usage

use metadata key

added avatar image for chatbot


Fixup toolchain sync PRs

-iE edits in place and makes a backup with suffix E on Linux. Use plain -i to edit in place. https://linux.die.net/man/1/sed
Add workflow_dispatch: trigger so the workflow can be manually triggered.
Explicitly add files to the index for committing when making the PR. The Ruby action ends up dumping a ton of content to disk when doing the bundle install. See #198.

admin merged, CI is known broken with latest upstream artichoke. this PR is meant to unblock the workflow which will fix CI.


feat: next recurrence on line below

Description

Motivation and Context
The current implementation of recurrences pushes the completed task below and replaces the original task with the new recurrence (as documented).
In my workflow I prefer to have it the other way around  - the next recurrence of a recurring task on the line below the original task. This mimic "human" behaviour  - completing a task and making a new one on the line below.
So I made an option for that. And the default behaviour is the original one.
Please feel free to reformulate my English in the settings and/or docs as you can do it quite better =)
How has this been tested?
Relevant user tests added.
Manual tests of the Settings Tab in my live vault:

With the default setting toggle an incomplete task with recurrence. Result : the new task appears on the original line and the completed one on the next line. Revert the changes in the file.
Set the setting to true (enabled) and toggle the same incomplete task with recurrence. Result : the new task appears below the original line and the original is at its place with DONE status. Revert the changes in the file.
Set the setting back to false (disabled, default) and toggle the same incomplete task with recurrence. Result : the new task appears on the original line and the completed one on the next line. Revert the changes in the file.

Task used for testing: - [ ] #task blablabla 🔁 every week on Tuesday ⏳ 2023-05-23
Screenshots (if appropriate)
Below is the view with the enabled option which is not the default.
I decided not to make one whole section for this and put it in the Date Settings. Lmk if you prefer otherwise.

Types of changes

Changes visible to users:

[ ] Bug fix (prefix: fix - non-breaking change which fixes an issue)
[x] New feature (prefix: feat - non-breaking change which adds functionality)
[ ] Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (prefix: docs - improvements to any documentation content for users)
[ ] Sample vault (prefix: vault - improvements to the Tasks-Demo sample vault)
[ ] Contributing Guidelines (prefix: contrib - any improvements to documentation content for contributors - see Contributing to Tasks)

Internal changes:

[ ] Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
[ ] Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
[ ] Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

[x] My code follows the code style of this project and passes yarn run lint.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] My change has adequate Unit Test coverage.

Terms

[x] My contribution follow this project's contributing guide
[x] I agree to follow this project's Code of Conduct

Relevant user tests added + manual tests of the Settings Tab in my live vault.

I am very interested in this change - it would be my personal preference too - but a bit surprised at how few changes were needed!
Please at least work through the smoke tests, and also provide a detailed list of what manual tests you have done, so I can have a think if there are any more areas that need testing.

Also, please have a search through all the Discussions and Issues with the scope: recurrence (or whatever it is) to see if anyone has requested this previously, and if so, add links to the found items in the 'Motivation' section of the ticket. Thanks.

Also, please have a search through all the Discussions and Issues with the scope: recurrence (or whatever it is) to see if anyone has requested this previously, and if so, add links to the found items in the 'Motivation' section of the ticket. Thanks.

I did but found none =(

Please help to reduce time in the review process by also including a screenshot of the new settings section in the 'Screenshots' bit of this PR, showing a bit of the previous and following section of the settings, so that it is visible where this new settings has been added. Thanks.

I should have done it in the first place...

Please at least work through the smoke tests, and also provide a detailed list of what manual tests you have done, so I can have a think if there are any more areas that need testing.

Done

I am very interested in this change - it would be my personal preference too - but a bit surprised at how few changes were needed!

Would you change the default behaviour then to add the new recurrencies below?

I am very interested in this change - it would be my personal preference too - but a bit surprised at how few changes were needed!

Would you change the default behaviour then to add the new recurrencies below?

No definitely not.

Please at least work through the smoke tests, and also provide a detailed list of what manual tests you have done, so I can have a think if there are any more areas that need testing.

Manual test description provided.

Thank you.
There are a lot more ways of toggling a task than just the checkbox:
https://publish.obsidian.md/tasks-contributing/Code/How+does+Tasks+handle+status+changes
Please can you explicitly test all of them?

Please could you leave the conversations unresolved so that I can review the changes and then resolve them.
Otherwise I have no realistic way of keeping track of feedback...
(I realise this makes it harder for you to keep track of feedback. Sorry)

Please could you leave the conversations unresolved so that I can review the changes and then resolve them.
Otherwise I have no realistic way of keeping track of feedback...
(I realise this makes it harder for you to keep track of feedback. Sorry)

Sure, it is actually simpler for me if you resolve them =)

Please at least work through the smoke tests, and also provide a detailed list of what manual tests you have done, so I can have a think if there are any more areas that need testing.

Manual test description provided.

Thank you.
There are a lot more ways of toggling a task than just the checkbox:
https://publish.obsidian.md/tasks-contributing/Code/How+does+Tasks+handle+status+changes
Please can you explicitly test all of them?

Oh, great this exists! Love it! I will! =)

There are a lot more ways of toggling a task than just the checkbox:
https://publish.obsidian.md/tasks-contributing/Code/How+does+Tasks+handle+status+changes
Please can you explicitly test all of them?

Toggling tested. Test is: enable the option in the settings and complete a recurring task. OK result = new recurrence appears below the completed task. Results in same order as on the page:

OK (In Editing view with Live Preview)
OK
OK (In Reading view)
OK (Tested both Reading view and Editing view)
Not available

This seemed odd to me, I expected something to fail, but then I analyzed the code and the Task.toggle() is always joined to string after use without checking what the first task is:
Task.toggleDone():
        const lines = task.toggle().map((t) => t.toFileLineString());
        return { text: lines.join('\n'), moveTo: { line: lines.length - 1 } };

LivePreviewExtension.handleClickEvent():
        const toggled = task.toggle();
        const toggledString = toggled.map((t) => t.toFileLineString()).join(state.lineBreak);

        // Creates a CodeMirror transaction in order to update the document.
        const transaction = state.update({
            changes: {
                from: line.from,
                to: line.to,
                insert: toggledString,
            },
        });

TaskLiveRenderer.renderTaskLine():
        const toggledTasks = task.toggle();
        replaceTaskWithTasks({
            originalTask: task,
            newTasks: toggledTasks,
        });

The order of the task array returned by Task.toggle() is used ONLY in the tests with most of them done with one task, where other functionalities are tested like statuses.
So far this seems to be pretty safe for me. However I understand your concern and your argument:

every place in future where this method (Task.toggle()) is called will have to check the settings to know which is the old task and which is the new

To tackle this I could duplicate the code after each Task.toggle() call in TaskLiveRenderer.renderTaskLine(), LivePreviewExtension.handleClickEvent(), Task.toggleDone() but for now this seems to be a duplication...
More that that, if we modify the callers of Task.toggle(), next time someone uses Task.toggle() they will need to test manually smoke tests against the new setting they may not be aware about the setting at all. Not to mention that the callers are harder to debug and test, for instance the LivePreviewExtension.ts can be only tested manually.
If we keep the changes as they are now, whoever calls the Task.toggle() has a way to see the behaviour in a debugger and has just one unit test in front of them (In Task.test.ts).

You make a lot of very good points, and thank you for very thorough testing!! ❤
I didn't say in my previous message that I am aware that the locations mentioned in that how status changes work page are ripe for refactoring - there is a lot of duplication with very subtle differences between them... I have tried unifying them several times and never got far.
OK, how about a compromise third way? 🤣
Separate the concerns....

Keep Task.toggle() as it is
Create a new task method called (something better than) Task.toggleTheTaskAndGiveMeTheNewTasksBackInTheOrderTheUserWantsThemWritten()
(Obviously) change the umpteen locations that write the toggled task(s) out to call the new method
Add jsdocs links between the two toggle methods...

And Bob's your uncle, job done!

I also thought about introducing another layer =) What is the benefit here? I'm not against that, but can't see what would change for the better. Maybe the benefits are:

Keeping the existing tests on Task.toggle() as they are
Making the user of Task.toggleTheTaskAndGiveMeTheNewTasksBackInTheOrderTheUserWantsThemWritten() being aware that the method provides the TasksBackInTheOrderTheUserWantsThemWritten and then they will be like:

I have to take care of that and Bob's your mother's brother!

Anything else?

PS

(Obviously) change the umpteen locations that write the toggled task(s) out to call the new method
there are just 3 of those out of the tests...

I also thought about introducing another layer =) What is the benefit here? I'm not against that, but can't see what would change for the better. Maybe the benefits are:

Keeping the existing tests on Task.toggle() as they are

Only time for a very quick reply.
The tests exist to serve the code, the developers and the users, so no, it's not about keeping the tests the same.
For example...

It's about safety - not risking causing any breakages in any forked repos, where people may be calling toggle() directly.....
It's about keeping toggle() only doing 1 thing, and putting the settings handling code in a different layer (which is what I meant by 'separating the concerns' in my previous comment
It's about making the behaviour explicit (for those who know the behaviour of the existing toggle() method... ) - toggle() does one this, and toggleInUserChosenOrder() does something different.
If  code wants the new task after toggling, they call toggle()
If code wants to write out the toggled tasks to file, they call the new method.

It's about safety - not risking causing any breakages in any forked repos, where people may be calling toggle() directly.....
It's about keeping toggle() only doing 1 thing, and putting the settings handling code in a different layer (which is what I meant by 'separating the concerns' in my previous comment
It's about making the behaviour explicit (for those who know the behaviour of the existing toggle() method... ) - toggle() does one this, and toggleInUserChosenOrder() does something different.
If  code wants the new task after toggling, they call toggle()
If code wants to write out the toggled tasks to file, they call the new method.

Solid arguments, thanks. I've implemented as you proposed. And did the same smoke tests with same results:

Toggling tested. Test is: enable the option in the settings and complete a recurring task. OK result = new recurrence appears below the completed task. Results in same order as on the page:

OK (In Editing view with Live Preview)
OK
OK (In Reading view)
OK (Tested both Reading view and Editing view)
Not available

Great stuff - I'm really looking forward to using this.


Edge case issues

I ran into some edge cases that get_coefficient() doesnt gracefully handle.  ie:
{'Name': 'Youhais Vilda-Wilma S63105/87', 'Sire': None, 'Dam': None}
{'Name': 'Dido S51199/87', 'Sire': {'Name': 'Wochs-Bob S50896/87', 'Sire': None, 'Dam': None}, 'Dam': None}
it was easy enough to work around but I thought I should mention it at least for the benefit of others:
if record.get('Sire') is None or record.get('Dam') is None:
            # Insert 'IC': 'unknown' into the top level of the pedigree_dict
            pedigree_dict[name]['IC'] = 'unknown'
            print(f"Updated record for {name}: IC set to 'unknown'")
        else:
            calculator = InbreedingCalculator(record)
            calculator.id_key = "Name"
            calculator.sire_key = "Sire"
            calculator.dam_key = "Dam"

            ic = calculator.get_coefficient()
            pedigree_dict[name]['IC'] = ic
            print(f"{name} | Inbreeding Coefficient: {ic} ({ic * 100}%)")

Note that I have a dictionary of pedigree dictionaries so hence the pedigree_dict[name]['IC'] = ... lines

Thank you for letting me know about this problem. I just made a quick update to fix this in eb630ae.


update template with fixes from CB-CSV

@FairlyNewHere this pull request adds bug fixes from the main collectionbuilder-csv template. Unfortunately your copy of the template included some bugs that where in the repository during development (the project is still in active development!).
Merging this PR should fix your error during site generation. Everything looks like it is working--except keep in mind that your current metadata file has a bunch of empty records with an "objectid" and no other values--these will show up in your collection as empty records.

@FairlyNewHere if you are unfamiliar with PRs, here is a GitHub doc explaining the process: https://docs.github.com/en/github/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request


publish offline when disconnect gracefully

MQTT-client uses last will to set status=offline if the client has disconnected ungracefully.
But it doesn't seem to publish an offline state when it disconnects gracefully. So the online state remains and will probably never be changed. But for my client it is important to know whether the publisher is online or offline, no matter for what reason.
Is it possible to publish an offline state before disconnecting?

I have the same issue.
Greetings Thomas

Please provide a debug log of such a case

I start and stop this adapter. MQTT Explorer send me "connected" but not "lastwill".

2021-09-23 22:32:23.819 - info: mqtt-client.0 (21812) Adapter is disabled => stop
2021-09-23 22:32:23.821 - info: mqtt-client.0 (21812) cleaned everything up...
2021-09-23 22:32:23.823 - info: host.iobroker-syn "system.adapter.mqtt-client.0" disabled
2021-09-23 22:32:23.827 - info: host.iobroker-syn stopInstance system.adapter.mqtt-client.0 (force=false, process=true)
2021-09-23 22:32:24.027 - info: mqtt-client.0 (21812) terminating
2021-09-23 22:32:24.027 - info: mqtt-client.0 (21812) Terminated (NO_ERROR): Without reason
2021-09-23 22:32:24.585 - info: host.iobroker-syn instance system.adapter.mqtt-client.0 terminated with code 0 (NO_ERROR)
2021-09-23 22:32:24.585 - info: host.iobroker-syn Do not restart adapter system.adapter.mqtt-client.0 because disabled or deleted
2021-09-23 22:33:56.250 - info: host.iobroker-syn "system.adapter.mqtt-client.0" enabled
2021-09-23 22:33:56.391 - info: host.iobroker-syn instance system.adapter.mqtt-client.0 started with pid 4249
2021-09-23 22:33:57.313 - info: mqtt-client.0 (4249) starting. Version 1.4.0 in /opt/iobroker/node_modules/iobroker.mqtt-client, node: v12.22.6, js-controller: 3.3.18
2021-09-23 22:33:57.418 - info: mqtt-client.0 (4249) enabled syncing of hm-rega.0.34265 (publish/subscribe:true/true)
2021-09-23 22:33:57.419 - info: mqtt-client.0 (4249) Try to connect to mqtt://mqtt:*******************@<IP_ADDRESS>:1883?clientId=iobroker with lwt "/iobroker/System"
2021-09-23 22:33:57.481 - info: mqtt-client.0 (4249) connected to broker
2021-09-23 22:34:42.793 - info: host.iobroker-syn "system.adapter.mqtt-client.0" disabled
2021-09-23 22:34:42.792 - info: mqtt-client.0 (4249) Adapter is disabled => stop
2021-09-23 22:34:42.796 - info: host.iobroker-syn stopInstance system.adapter.mqtt-client.0 (force=false, process=true)
2021-09-23 22:34:42.793 - info: mqtt-client.0 (4249) cleaned everything up...
2021-09-23 22:34:42.995 - info: mqtt-client.0 (4249) terminating
2021-09-23 22:34:42.996 - info: mqtt-client.0 (4249) Terminated (NO_ERROR): Without reason
2021-09-23 22:34:43.546 - info: host.iobroker-syn instance system.adapter.mqtt-client.0 terminated with code 0 (NO_ERROR)
2021-09-23 22:34:43.547 - info: host.iobroker-syn Do not restart adapter system.adapter.mqtt-client.0 because disabled or deleted

Greetings Thomas

see other rerploy ... enable debug loglevel first please

I finish your request. Please see other reploy.
Greetings Thomas

Wozu ein Debug Log? Die Sachlage ist klar:
Aus der Dokumentation des Adapters:

Der Entwickler hat keine Nachricht für den Disconnect vorgesehen.
Korrekte Vorgehensweise laut MQTT-Spezifikation:

send connect mit last will = ioBrokerTest/status = broken
send publish ioBrokerTest/status = online
...
send publish ioBrokerTest/status = offline
disconnect

Der MQTT löscht den Last Will bei Disconnect weg. Er wird nur bei Abbruch der Verbindung ausgeführt, nicht bei jeder Trennung, wie in der Dokumentation behauptet.
Grund: Damit kann der Subscriber erkennen, ob der Publisher regulär beendet oder abgebrochen ist.


Set corner for transaction support notifications

Notification toasters currently appear in lower left corner of the browser window, stacking upwards. Allow Dapp to choose which corner to use. Top left/right corner would stack downwards. Bottom left/right corners would stack upwards.

@cmeisl Are you thinking that the Blocknative logo will be inverted as well when the toasters are set to top left/right? So the logo would be on top with toasters stacking downwards underneath it making a mirror image of the current notifications setup.

Closed via #81


docs: corrected spelling in deeper_overview.md file

Made changes to misspelled words.
What ❔
Auxiliary is the correct spelling, but Auxilary has been used even in the coding part, only comment has been rectified, in this commit.

Why ❔
Because spelling was incorrect.

Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[ ] Code has been formatted via zk fmt and zk lint.
[ ] Spellcheck has been run via cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.

@bskrksyp9 please check why the CI is failing - thanks

But all i did is just a spell fix and that too from online console, i have no environment setup for this even

@bskrksyp9 please check why the CI is failing - thanks

I just saw it said lint issue with PR title, but I had changed it very next moment when the PR was made, I don't know why it's still showing old issue...

Thank you for your contribution. We are working on an automatic spell-checking tool and will not accept PRs with spelling corrections.


Multiple small changes

Enabled magnifier for sketch sample
Added time and distance feedback for offline routing sample

@singhgag This branch needs to be updated to resolve conflicts. Otherwise it looks okay to merge

Resolved the conflicts. Merging changes.


fix(parser,semantic): make semantic own Trivias

closes #708
Making the parser return Rc is not a good API, and ideally Semantic should just own Trivias so it can process or mutate it.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@9714e46). Click here to learn what that means.
Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #711   +/-   ##
=======================================
  Coverage        ?   89.46%
=======================================
  Files           ?      206
  Lines           ?    42611
  Branches        ?        0
=======================================
  Hits            ?    38124
  Misses          ?     4487
  Partials        ?        0

Files Changed
Coverage Δ

crates/oxc_cli/src/lint/isolated_handler.rs
0.00% <0.00%> (ø)

crates/oxc_parser/src/lib.rs
98.95% <ø> (ø)

crates/oxc_linter/src/tester.rs
98.27% <100.00%> (ø)

crates/oxc_parser/src/lexer/trivia_builder.rs
100.00% <100.00%> (ø)

crates/oxc_query/src/tests.rs
100.00% <100.00%> (ø)

crates/oxc_semantic/src/builder.rs
98.10% <100.00%> (ø)

crates/oxc_semantic/src/jsdoc/builder.rs
98.09% <100.00%> (ø)

crates/oxc_semantic/src/module_record/mod.rs
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


taglib-extras: add missing dependency zlib

This change adds zlib as a dependency to address the error:
/nix/store/5xyjd2qiily84lcv2w2grmwsb8r1hqpr-binutils-2.35.1/bin/ld: cannot find -lz
collect2: error: ld returned 1 exit status
make[2]: *** [taglib-extras/CMakeFiles/tag-extras.dir/build.make:208:
taglib-extras/libtag-extras.so.1.0.0] Error 1
make[1]: *** [CMakeFiles/Makefile2:154:
taglib-extras/CMakeFiles/tag-extras.dir/all] Error 2
make: *** [Makefile:149: all] Error 2
builder for
'/nix/store/w1ac3b6v5yfblbnqzyxa6y4738frlmvr-taglib-extras-1.0.1.drv'
failed with exit code 2

This allows amarok to build. See https://hydra.nixos.org/build/142979429
ZHF: #122042

Motivation for this change
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 123071 at 281c5413 run on aarch64-linux 1

2 packages built successfully:

cantata
taglib_extras

Result of nixpkgs-review pr 123071 run on x86_64-linux 1

3 packages built:

amarok
cantata
taglib_extras