1.2.0

Codecov Report

Merging #1752 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1752      +/-   ##
============================================
- Coverage     48.54%   48.54%   -0.01%
+ Complexity     1912     1911       -1
============================================
  Files           392      392
  Lines         11617    11617
  Branches       1219     1219
============================================
- Hits           5640     5639       -1
- Misses         5530     5531       +1
  Partials        447      447

Impacted Files
Coverage Δ
Complexity Δ

...amework/apollo/openapi/util/ConsumerAuditUtil.java
80.55% <0%> (-2.78%)
6% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc25e3...d3a2dd0. Read the comment docs.


Issues with updating manager value

We have set up 2 additional alias  for some of our business users by following this link. This created separate User profile which is not mentioned in documentation.
But the real issue is the manager field used in the user profile is not syncing now. The manager user changed. So we deleted the old user and updated the details in Ad and it synced for main alias but not reflecting in other alias. We do not wish to go through all the user profile with other domain and verify that manager field. Can you please provide any solution, how can we update manager value for all the alias profiles?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 94754a91-ac3b-9b1c-ded9-3fdab2dd229c
Version Independent ID: 517f9726-1861-8b1c-fe9d-6c50047e16d3
Content: Add another email alias for a user - Microsoft 365 admin
Content Source: microsoft-365/admin/email/add-another-email-alias-for-a-user.md
Service: o365-administration
GitHub Login: @KwekuA
Microsoft Alias: kwekua

@lovethakker02 - Thank you for submitting feedback.
I think the best way forward is if you can open a service ticket in your tenant so this can get resolved ASAP. Based on outcome, let us know if it is something that can be called out in the docs.
If you don't mind please keep us posted here on the resolution so we can get the applicable information you are discovering back into the docs.

It seems that the primary domain only gets the changes. We have asked our client to generate the ticket for same. If we get any update from them, we will surely post here.


Rename write_only_fields to hidden_fields

Issue: AAH-1912
API PR: https://github.com/ansible/galaxy_ng/pull/1490
After renaming write_only_fields to hidden_fields and moving them to https://github.com/pulp/pulpcore/pull/3167.  API and UI have to be updated to use hidden_fields.
Pulpcore issue: https://github.com/pulp/pulpcore/issues/2825
I added small tests to verify that the hidden_fields are working as expected.

@himdel FYI I removed hidden_fields from the request data, I don't think we need to send them to API. https://github.com/ansible/ansible-hub-ui/pull/2710/files#diff-049213a32cbacbeec291dbc3e5e6809c847a354420364508110b50235ea0103fR170 and https://github.com/ansible/ansible-hub-ui/pull/2710/files#diff-d7ccf0af7fdb44f2f4106924dd93a79d428f3d0289160b2e219486c3a3653d46R18

Converting to draft for now. This will have to include new pulp endpoints with hidden_fields after updating to the newer pulpcore version. No additional API changes/refactoring will be needed.

Closing, EE endpoints API still use write_only_fields, so we're supporting both for now.


md-input is not known, but md-card is

Bug, feature request, or proposal:
bug
What is the expected behavior?
working md-input
What is the current behavior?
I can use <md-card>, but <md-input> is not a known element

md-input was deprecated with the latest release.
https://github.com/angular/material2/blob/master/CHANGELOG.md use
  <input mdInput name="value" ngModel>
</md-input-container> ```

md-input was deprecated with the latest release.
https://github.com/angular/material2/blob/master/CHANGELOG.md use
<md-input-container>
  <input mdInput name="value" ngModel>
</md-input-container> ```

Thanks, it works!

Why would only mdInput use camel case, yet everything else uses hyphens?  This is dumb.

@NeuralChris your profile looks like mine :)


Custom Authentication Method - Passing Error Messages

How would you pass back a custom error message from a custom authenticator?  Obviously my example below is pulled completely out of thin air and would never work, but I think you get what I mean?  Somehow, there must be a way to pass a message from here, back to the error handler, or alter the $arguments?
class DbAuthenticator implements AuthenticatorInterface {
    private $settings;

    public function __construct($settings) {
        $this->settings = $settings;
    }

    public function __invoke(array $arguments) {
        if (wrongPassword($user, $pass)) {
            $returnAmessageSomeHow = "Invalid password";
            $failedLogins = $failedLogins + 1;
            return false;
        }
        if (invalidUsername($user, $pass)) {
            $returnAmessageSomeHow = "Invalid username";
            return false;
        }
    }

}

then...
$container["HttpBasicAuthentication"] = function ($container) {
    return new HttpBasicAuthentication([
        "path" => [ ... ],
        "authenticator" => new DbAuthenticator($container['settings']),
        "error" => function ($request, $response, $arguments) {
            $data = [];
            $data["status"] = "error";
            $data["message"] = $messageReturnedFromAuthenticatorSomehow;
            return $response->write(json_encode($data, JSON_UNESCAPED_SLASHES));
        }
    ]);
};

This is not currently possible. It is however a good idea and I should implement it in the near future.

I am not sure if it's implemented already, but if that's not the case is there another way I can pass container setting to my custom authenticator?

This bug report is about custom error messages. Container you can pass with something like:
$app->add(new \Slim\Middleware\HttpBasicAuthentication([
    "path" => "/admin",
    "realm" => "Protected",
    "authenticator" => new CustomAuthenticator($container["custom_settings"])
]));

Thanks that's really helpful.
I know this is probably not the place for it, I am fairly new to this. I am using your slim skeleton.

- Container
$container["HttpBasicAuthentication"] = function ($c) {
    return new \Slim\Middleware\HttpBasicAuthentication([
        "path" => "/",
        "error" => function ($request, $response, $arguments) {
            return new UnauthorizedResponse($request, $response, $arguments);
        },
        "users" => [
            "root" => "t00r"
        ]
    ]);
};

- UnauthorizedResponse
    public function __construct($request, $response, $arguments)
    {
        $path = $request->getUri()->getPath();
        // Is it possible to use renderer here doesn't seem possible since I can't pass it as an argument

    }

Hi, has this issue been developed?

It is still in TODO list but plan is to implement this feature since it is quite useful.

Tks

Hi,
Any news on this feature for 3.0 ?
Mika, do you have some implementation ideas in mind ?
I wonder if I could implement this feature by passing a Response object to the authenticator, and return a Response instead of a boolean.
We could check the status of the response to determine the success/error state, and we give ability to the Authenticator to manage it's own status?
What do you think ?
Thank you.

Adding this just before the final return in the process function (src/HttpBasicAuthentication.php) worked for me, may not the best way to handle it though.
           if(method_exists($this->options['authenticator'], 'getCustomErrorMessage')) {
                return $this->processError($response, [
                        "message" => $this->options['authenticator']->getCustomErrorMessage()
                ]);
            }

Thanks @apuleus , but I dont understood how this works. What does getCustomErrorMessage do?

getCustomErrorMessage() returns a string with the customer error message that my authenticator set.  I placed it right before the code that returns the $response and default message. You can see that original code snippet below.  It changes the behavior by checking if the "getCustomErrorMessage()" method exists in my custom authenticator.
Original Code

 /* Check if user authenticates. */
        if (false === $this->options["authenticator"]($params)) {
            /* Set response headers before giving it to error callback */
            $response = (new ResponseFactory)
                ->createResponse(401)
                ->withHeader(
                    "WWW-Authenticate",
                    sprintf('Basic realm="%s"', $this->options["realm"])
                );
            return $this->processError($response, [
                "message" => "Authentication failed"
            ]);
        }

Code with my addition

 /* Check if user authenticates. */
        if (false === $this->options["authenticator"]($params)) {
            /* Set response headers before giving it to error callback */
            $response = (new ResponseFactory)
                ->createResponse(401)
                ->withHeader(
                    "WWW-Authenticate",
                    sprintf('Basic realm="%s"', $this->options["realm"])
                );
            if(method_exists($this->options['authenticator'], 'getCustomErrorMessage')) {
                return $this->processError($response, [
                        "message" => $this->options['authenticator']->getCustomErrorMessage()
                ]);
            }
            return $this->processError($response, [
                "message" => "Authentication failed"
            ]);
        }

The function in my authenticator class

public function getCustomErrorMessage() {
  return (string) $this->errorMessage;
}

Like I said, may not be the best way, but it worked for my purposes.  The reason why I needed the authenticator to handle the error message is due to the authenticator class having the ability to lock people out and this was an easy way to allow the authenticator to change the default message when that happens.

Thanks @apuleus!!!


Make JournalDirWatcherError publicly accessible

yo,
Currently JournalDirWatcherError is not accessible as the live_journal_dir_reader isn’t pub. Not sure if you’d rather make the entire module public, or just reexport the error. This PR does the latter but either works for me!

Thanks again! I really need to find a better way to handle those reexports...


Fails to build

Every commit past e576a7519767387707a5684b6f31671e1e0e3032 have build errors.
I'm sure you're aware of this already, but if not now you are :)
Happy coding!

Maybe try also posting the build error...

1e47e6912c37c83438b7bb7a9c520ba88e9dede0 build info: https://gist.github.com/tsalwierz/c33610bc31eada00d1848c01a449ae2d

Issue is fixed as of 35a9423648153ecb08e195e5f0c400aa4f4ddc97, closing.


Docs/test projects

Added documentation on how to write all the different kind of test projects.

unit tests
auto tests
fuzzy tests

I have nowhere to put this so I will add it as a comment here.
Would it be possible to add a feature that is able to update a single external without updating the file in required_externals?
IIRC this is also possible within Unreal.
for instance: _rex.py setup libs=glad+glm -v=latest

Also nowhere to comment this:
I think there is a typo here, shouldn't it be unit_tests instead of unity_tests


Nous-Hermes-13b on 1x8 H100 FSDP zero2 with thunder_cudnn is 23% slower than with inductor

🐛 Bug
Nous-Hermes-13b  with FSDP zero2 trained on 1 node with 8 H100 each is considerably slower for thunder_cudnn than inductor.
To Reproduce
Steps to reproduce the behavior:
It was tested on Slurm cluster. You can contact me on Slack for more details

Create a file script.sh (second version will be with  `--compile  inductor'):

#!/bin/bash
#SBATCH -A YOUR_DETAILS
#SBATCH -p batch
#SBATCH -J YOUR_DETAILS
#SBATCH -N 2
#SBATCH --ntasks-per-node 8
#SBATCH --time 0:29:00
#SBATCH --mail-type=FAIL
#SBATCH --exclusive

IMAGE="INTERNAL_IMAGE:pjnl-20240524"

TRAINING_CMD="python /opt/pytorch/lightning-thunder/thunder/benchmarks/benchmark_litgpt.py \
 --model_name Nous-Hermes-13b  \
 --micro_batch_size 2 \
 --distributed_mode fsdp \
 --shard_mode zero2 \
 --compile thunder_cudnn
"

After you are logged into Slurm cluster run:

sbatch script.sh

The results should be visible in slurm-JOB_ID.out file.

Expected behavior
The time of training iteration should be similar in both cases.
Environment
As in the docker image used.

triage review — @parthmannan - what's going on here?

Thanks @mruberry We'll take a look.
@mpatel31415 - Did we try thunder_inductor_cat_cudnn on this? The architecture is very similar to LLaMa and without inductor_cat, the RoPE performance is expected to perform worse.

This is actually quite interesting. Despite no RoPE support, thunder_cudnn outperforms inductor on mbs=1
Time per iter
eager: 528.17 ms
inductor: 496.06 ms
thunder_cudnn: 452.87 ms

thunder_inductor_cat_cudnn fails to run. Will need to investigate and file an issue for that separately.
But on MBS=2, the performance degrades quite a bit leading to the slowdown. More in next comment.

MBS=2 Time per iter
eager: 878.01 ms
inductor: 762.20 ms
thunder_cudnn: 996.90 ms

Now, here's what the profile looks like -
There are two very large ReduceScatter kernels that are not seen in inductor.

So either other GPUs are not participating at the same time and there is large jitter in the execution OR FSDP over 2 nodes is causing the delay.
Taking a look at what is going with other GPUs tells us that there is some kind of memory operations that are causing the ReduceScatter to wait for data causing large delays making jitter the likely cause.
This corresponds to the first large RS and is actually present on multiple GPUs.

This corresponds to the first large RS and is actually present on multiple GPUs.

We need to find out why these memory operations exist in the timeline on some GPUs when using Thunder. Is there any reason for memory thrashing or other memory issues to pop on some GPUs and not on others?

Oh well, all the time spent debugging the above issue led me back to #420
Setting TORCH_NCCL_AVOID_RECORD_STREAMS=1 solves the issue and this is being added by default to Thunder in #512
Performance is now thunder_cudnn: 730.59 ms which is faster than inductor.
Marking this closed for now as the fix for underlying issue is underway. Please feel free to reopen if needed.


URLs not working in intro.ipynb notebook

@norvig , @chiragvartak , @MrDupin , @ad71
In intro.ipynb notebook in the What version of Python? section, 2 URLs are not working.

The link to the legacy branch gives 404 error.
The link to Anaconda is also not accessible. The link of Anaconda has been modified  to https://www.anaconda.com/download/ .

Good catch, it's fixed now.
Thanks!


Clone panel fixes

Backport https://github.com/go-gitea/gitea/pull/15435 to 1.14.

Make lgtm work


Public event RSVP form

endpoint: /event/:id/rsvp
no protection on endpoint - any non-affiliate should be able to sign up
no need to hook up with backend yet

Similar to to the event sign in page. Once we get the confirmation snackbar onto this, then it should be fine closing this issue.

closed?

Still need the snackbar, but otherwise done


Added semicolon to URI pointing to old docs.

Purpose of this pull request
This pull request (PR) ...
Issue number:

Select the type of change:

[x] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions and updating sections
[ ] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

Apparently this change has appeared on main in the meantime https://github.com/SumoLogic/sumologic-documentation/commit/508582a955cca5b5b3bc8241b1b6af370c7ad83f. Anyway, thanks @astefanski-sumo for your contribution and please do not hesitate to bring in more! :bowing_man:


"Unhealthy Estimator" warning too aggressive

We need to increase the duration of no accel updates before the warning is issued to something more reasonable.

I believe the current duration is 0.5s, is that too agressive?


[BUG]: PowerFlex RWX volume no option to configure the nfs export host access ip address.

Bug Description
Currently its programmed to configure the sdc ip as the nfs export host access ip.
I am facing two problems with this,

If there are multiple sdc ips, it not predictable which ip is selected to configure the host access in nfs export.
If the setup requires the nfs export to be accessed by another ip address, not the ip address used for the block access, no option to do that.

Please allow to configure the interface on which the user want to access the nfs export from the PowerFlex.
Logs
no logs
Screenshots
No response
Additional Environment Information
PowerFlex 4.5
OpenShift 4.13
CSM Operator 1.3
CSM 1.8
Steps to Reproduce
Integrate CSM with PowerFlex with multiple PowerFlex Data network
Integrate CSM with PowerFlex and configure PowerFlex NAS Server in network other that SDC network.
Expected Behavior
Customer should be able to configure the ip used for accessing the nfs export.
CSM Driver(s)
CSI Driver PowerFlex 2.8
Installation Type
CSM Operator 1.3
Container Storage Modules Enabled
No response
Container Orchestrator
OpenShift 4.13
Operating System
CoreOS

link: 18467


Add .types() for command arguments

Command arguments are automatically assigned a type but there doesn't seem to be any support for explicit typing like with options. When entering in a phone number with special characters like so:
vorpal.command("send <number> <message>")

app$ send +1212345678 "hello world"

the argument "number" is converted to a number, omitting the + symbol. Furthermore, I think the .types() function available for options should also support command arguments.

I would also love to use this feature. Faced this issue when trying to specify API version using number wrapped in brackets like "1.0". It got converted to number 1.

Same for me.  Is there any workaround?  I'm having problems with hex strings such as:
"0x4e47e95247a535d9c1ed9e5a73f1344a5d864383"
Being converted to a number:
4.469049581943643e+47
The only alternative is to use a type with an option but this is a little awkward for the CLI I'm working on.

maybe arguments that are quoted should be passed as strings, at least.

Hello again dear contributors.
@dthree, I'm ready to implement this feature/bugfix and I was wondering if you would be willing to accept my contribution.
If you would, please share your opinion on this issue and maybe some guidelines if you think this issue makes sense.
Thank you! :)

Greetings to everyone having this issue.
I've discovered a way to parse params as strings. Hopefully this will be useful to someone.
Note: This enables such behavior per-command and parses ALL params(non-options) as strings.
So the solution is - add "_" to your string types by calling .types({string: ['_']}).
Examples:
If you already have .types() call add "_" to its "string":
Before:
vorpal
  .command('send <number> <message>')
  .option('--anotherNumber <val>')
  .types({string: ['anotherNumber']})

After:
vorpal
  .command('send <number> <message>')
  .option('--anotherNumber <val>')
  .types({string: ['anotherNumber', '_']})

If you don't have .types() call, make new one with "_" in "string":
Before:
vorpal
  .command('send <number> <message>')

After:
vorpal
  .command('send <number> <message>')
  .types({string: ['_']})

Documentation on .types()

@dthree Any plans to fix this issue ?


Script classification: main script

Right now we detect the main types of scripts and sometimes repositories are service, packages and libraries.
However, we should extract the MAIN script. This needs:

Annotate for each repo which is the main script.
Use the call graph to figure out which script is the main one.

Fixed in https://github.com/SoftwareUnderstanding/code_inspector/pull/223


Manually enter the routing path in the browser address bar and report an error 404

Version
4.0.0-beta.10
Reproduction link
https://github.com/zhenzhenChange/awaking
Steps to reproduce
I directly typed a path in routes in the browser address bar, the console reported an error 404, but the to prop of router-link can be used to jump correctly.But after the jump is completed, F5 refreshes the page and also reports a 404 error.Is this a bug? Or is there no such feature yet? Or set it on purpose?
What is expected?
I expect to enter the route path in the address bar to jump to the corresponding view
What is actually happening?
In fact, there is no jump, the console reports an error 404, and the page displays Not Found

If there is a corresponding document or issue description, please let me know, thank you

git clone https://github.com/zhenzhenChange/awaking
cd doraemon
yarn
yarn dev
open browser
Use the router-link in the lower right corner of the picture to jump (success)
Enter path directly in the address bar or F5 refresh will report an error 404

Trouble: I can actually test in the codesandbox provided by you.

you didn't add a catch all route https://next.router.vuejs.org/guide/essentials/dynamic-matching.html#catch-all-404-not-found-route

Very sorry for interrupting you.
First of all thank you for your reply. Then I found the reason now.
This is a problem with the location of index.html. In the initialization template of Vite, the directory structure is like this:

vite-demo

public
src
index.html （Same level as public folder）

But due to past development habits, I moved it to the public folder：

vite-demo

public

index.html

src

This leads to a problem with the path referenced by the src prop of the script tag in the index.html file：
<script type="module" src="/src/main.ts"></script>

I didn't pay attention to this problem
I found out by comparing a new vite project. And pressing F5 to refresh the browser causes the 404 problem, which is similar to the problem of the vue-router conflicting with the URL when the vue project is deployed on the server (this usually requires additional configuration on the server). Of course, in the vite project, it may be able to pass vite .confit.js file configuration, I am still studying...


ENG-7237 - Add function to point to dev for full E2E tests

Pulled, tested by adding this line to the app main NeuroID.getInstance()?.setTestURL(Constants.devEndpoint.displayName) and ran. Saw the dev endpoint in the network inspector. Removed the line and saw the prod endpoint. LGTM. 🚢.


Latest PyPi package not yet compatible with Python 3

Hello, was wondering when you will push a more recent version of ftw to PyPi?
https://pypi.org/project/ftw/
I used the one from there but couldn't get my tests to run under Python 3.6. The latest commit in the master branch works fine, however.
Thanks!

Hi @pirxthepilot,
I think it's much more interesting that where came from the version 1.2.0 to PyPI - because the latest version number (here on GH) is 1.1.7.
Could you try to reinstall this version from PyPI?

@airween hmm that is interesting. is there a way to trace where that v1.2.0 came from?
Installed 1.1.7 from PyPi but unfortunately it didn't work - I think it's still on 2.x only.

hmm that is interesting. is there a way to trace where that v1.2.0 came from?

I don't know - checked the tarball, but didn't found any relevant info.
Yes, I also played with the PyPI version of ftw (1.1.7), and got similar results as you. It needs to more investigation, but may be it would be better to make a new release (1.1.8) from the current master.
Note, that if the new release would be 1.1.8 (or any other but less than 1.2.0), then the PyPI wouldn't allow it. The next release must be the 1.2.1 least - as I know you can't upload the lower version from any package, but may be I'm wrong. @fgsch, @fzipi, any ideas?
I think the best solution is that you use the master version while we will solve this.

I just tried installing it from scratch and this works as expected, meaning 1.2.0 is installed from pypi.
Can you try removing it and reinstalling it, ensuring you are using the pip script corresponding to python3?

Actually, for now install from this repo as @airween suggested as 1.2.0 has some issues.
You can do that with pip3 install  git+https://github.com/CRS-support/ftw.
I will try to organise a new release soon. Sorry about that.

No worries, just using latest master for now. Thanks!

A new release is coming in the next weeks, with py3 support, stay tuned.

Sorry for the delay. ftw 1.2.3 has Python 3 support.
There are still some issues to fix but you can use it instead of master.


db-manager: simplify signatures query

This query was really slow cause the join was on a column
that wasn't indexed. After examining the usage of this func,
we only need the columns from pull_signatures anyway.
It went from 1400ms to < 10ms.
Closes #104

CR 👍

CR 🐬

CR :+1:

Going to QA this on our dev server and then merge it.

QA :+1: didn't see any problems clicking around


LDAP_TLS_ENFORCE=true can't be reverted

I am using osixia/docker-openldap v1.1.8 and I expected the LDAP_TLS_ENFORCE to be revertable.
Following #91 #107 and commit https://github.com/osixia/docker-openldap/commit/6163e400f041926d2e9e6e93ef4cc132a947d685
From the Changelog the issue seems to be resolved but this commit comment the changes:
https://github.com/osixia/docker-openldap/commit/0578ede275c63c4123517646b552107090b66d3c
Apparently the fix isn't working since I still have this when trying to gain access on phpldapadmin:
error	Unable to connect to LDAP server ldap.service.consul
Error: Confidentiality required (13) for user
error	Failed to Authenticate to server
Invalid Username or Password.

By setting LDAP_LOG_LEVEL=256, I can see the following in my openldap container :
/!\ WARNING: LDAP_TLS_ENFORCE=false but the container was previously started with LDAP_TLS_ENFORCE=true
TLS enforcing can't be disabled once added. Ignoring LDAP_TLS_ENFORCE=false.
Add TLS config...
Add enforce TLS...
Disable replication config...

I also tried like recommended in the disable-tls instruction from  doc and this appear:
/!\ WARNING: LDAP_TLS=false but the container was previously started with LDAP_TLS=true

TLS can't be disabled once added. Ignoring LDAP_TLS=false.

I wasn't aware of this warning before, maybe the README.md need to be updated ?
Is it possible to recover my previous configuration ?

This is already in the README ;)


side bar button replacement

replace with evans' assets

Side bar buttons are now using the swift preset, change them with the assets from Evans.

doing a overhual on the sidebar, might be done tomorrow.

Side bar buttons assets are in the general button asset folder, if you need more assets just fetch them using chrome F12. Also please fix the wrong button logics.


Adding pixel.runative-syndicate.com

pixel.runative-syndicate.com is used to serve hxxp://pixel.runative-syndicate.com/api/v1/p/p.gif.
Runative describes the role of their pixels in this article. While the article doesn't mention the pixel subdomain, I have seen my devices connect to it.
runative-syndicate.com is already blocked on Steven Black's ad-hoc list. EasyList has opted to block it and all its subdomains.

Thank you for this Pull Request @bremich.
Merging.


Cant connect in api.ng.bluemix.net with fedora 22

Command:
CF_TRACE=true cf login -a api.ng.bluemix.net
Terminal de API: api.ng.bluemix.net

SOLICITAÇÃO: [2016-06-25T12:36:31-04:00]
GET /v2/info HTTP/1.1
Host: api.ng.bluemix.net
Accept: application/json
Content-Type: application/json
User-Agent: go-cli 6.19.0+b29b4e0 / linux

SOLICITAÇÃO: [2016-06-25T12:36:46-04:00]
GET /v2/info HTTP/1.1
Host: api.ng.bluemix.net
Accept: application/json
Content-Type: application/json
User-Agent: go-cli 6.19.0+b29b4e0 / linux

COM FALHA
Erro ao executar solicitação: Get http://api.ng.bluemix.net/v2/info: dial tcp: i/o timeout
DICA: se você estiver protegido por um firewall e precisar de um proxy HTTP, verifique se a variável de ambiente https_proxy está configurada corretamente. Caso contrário, verifique sua conexão de rede.

Version:
cf -v
cf version 6.19.0+b29b4e0-2016-06-08

This looks like a network issue in your environment. Can you resolve and access the API endpoint using other tools (curl, ping, nslookup)? Is it possible that your primary DNS server was down at the time you ran the command?

Hi @dkoper , i was in AngelHack BR hackaton in IBM in Rio de Janeiro,
traceroute was not finding the route to the IBM API server in my laptop, now here in my house it is working.
The IBM team failed to solve the problem on site then i openned this issue because i belived that may be one problem related to Clound Foundry but i think may be some local network error.
It is working here in my house and i cant reproduce the problem then i will close this issue.


Errors in log

E 0:00:13:0559   SceneLoader.gd:47 @ change_scene_to_resource(): Can't create buffer of size: 0, error -3.
Condition "err" is true. Returning: ERR_CANT_CREATE
drivers/vulkan/rendering_device_vulkan.cpp:1378 @ _buffer_allocate()
SceneLoader.gd:47 @ change_scene_to_resource()

Sorry you are having issues. Please include the steps you took to reproduce the bug.

I can't repeat it, I changed a lot of things :(
Let me clarify - everything works, but there are errors in the log. And only in forward mode. In compatibility mode I get other errors:


Rename v1 release to v1.0.0

Describe the bug
Currently GitHub thinks the v1 release is the latest release. This causes some unexpected behaviour if you use microsoft/setup-msbuild@v1, thinking you get the actual latest release (which is v1.0.2). Therefore I would propose to rename the v1 release to v1.0.0, so that a plain @v1 references the latest stable v1.x.x release again.
See https://github.com/microsoft/setup-msbuild/releases

The plan @v1 does reference the latest due to updating the tag.  Do you have a repo showing that it is not working as such?

Right. That's kind of confusing behavior I think, because the release notes and date now don't match the commit.
I would suggest removing/renaming the v1 tag and continue using semantic versioning. That way if you just specify microsoft/setup-msbuild@v1 it takes the latest v1.x.x release without needing to rename or retag commits.

Hmm, the @v1 relies on using a tag...I do not believe GitHub's action resolution by default assume semver and would do this automatically.  Hindsight here is 20/20 and the first release would have been cleaner, but I don't want to change things that would now BREAK people using the @v1 moniker. See: https://github.com/actions/toolkit/blob/master/docs/action-versioning.md

I completely disagree with @EwoutH. Recommend to see the most used action https://github.com/actions/checkout.

Closing this out.  We released v1.0.3 and named a release specifically for that.  Thanks for providing the feedback here.


Rename CSF segmentations in derivatives

Description
This PR does the following steps on CSF segmentations:

renames the CSF segmentations in the derivatives from csfseg-manual to label-CSF_seg
Reorients and resmaples to native space using this script:

I ran the following command with the script:
sct_run_batch -jobs 1 -path-data ~/datasets/data-multi-subject -path-out ~/process_results/reorient_csf_v2 -script fix-orientation-derivatives.sh -include-list [ sub-cmrrb03 sub-tokyoIngenia06 sub-nottwil03 sub-pavia04 sub-barcelona05 sub-geneva04 sub-perform02 sub-nottwil04 sub-nottwil01 sub-tokyoIngenia05 ]

@mguaypaq finally, we want to revert this commit, I am not sure how in git annex: https://github.com/spine-generic/data-multi-subject/pull/154/commits/f7f3db5827b7cc826588cbe8e78e768914f27303
and delete: https://github.com/spine-generic/data-multi-subject/pull/154/commits/79e7157a149fe8a73af5d9f18ec3ccfad9ccc901


Added support for logging out on all devices as a member

fixes https://github.com/TryGhost/Product/issues/3738
Tech Spec

Adds the transient_id column to the members table. This defaults to email, to keep it backwards compatible (not logging out all existing sessions)
Instead of using the email in the cookies, we now use the transient_id
Updating the transient_id means invalidating all sessions of a member
Adds an endpoint to the members api to log out a member from all devices
Added the all body property to the DELETE session endpoint in the members API. Setting it to true will sign a member out from all devices.
Adds a UI button in Admin to sign a member out from all devices
Portal 'sign out of all devices' will be added in a separate change

Related changes (added because these areas were affected by the code changes):

Adds a serializer to member events / activity feed endpoints - all member fields were returned here, so the transient_id would also be returned - which is not needed and bloats the API response size (transient_id is not a secret because the cookies are signed)
Removed loadMemberSession from public settings browse (not used anymore + bad pattern)

Performance tests on site with 50.000 members (on Macbook M1 Pro):

Migrate: 6s (adding column 4s, setting to email is 1s, dropping nullable: 1s)
Rollback: 2s


Add 'x5t' claim to JWTHeader when SecurityKey is of type X509SecurityKey

In 4.x we set 'x5t'.
In 5.x we set 'kid'
Some runtimes are expecting one or the other and are broken by this change from 4.x to 5.x.
So we will add both.

this would be a breaking runtime change for users that coded using JwtHeader.Add(...) api.


Performances degradation with long string selections on chrome

I am using atomSet.toSeleString()  in every representation. I noticed a big slow down generating the representation, when the selection string is very big, especially on Chrome. Firefox experiences much less performances degradation respect to chrome. I have made a pen.

I don't know why performance differs so much, but this relates to #269 (the idea being you could set selection directly from a Selection object, rather than converting to/from a selection string).

This would be nice


Create tests for tasks and update the relevant test-related classes

For the testing timeline, perhaps have two or more people make separate tests (and combine them later) to catch more bugs/unintended behaviors.


Cupertino Icons Gallery web page 404

https://flutter.github.io/cupertino_icons doesn't work.

duplicate of https://github.com/flutter/flutter/issues/88754


Change site URL to flow.coe.hawaii.edu

Currently lives at https://flow.coe.hawaii.edu/flow/

Also get rid of the old WP site

Working on getting this done with Paul now.

alright Paul was able to give the site its final home: https://flow.coe.hawaii.edu/

Thanks @enriquezm @figureone !


Unfair comparison on ImageNet?

As this post mentioned, Adabelief on ImageNet is trained with weight decay rate 1e-2, while the results reported in previous work are usually with 1e-4. Since the weight decay rate has significant effect on the test accuracy, have you conducted experiments on the same setting for Adam and its variants?

Not yet. We also discussed this in the README.md file, in Discussion section. That might be a problem, but results in the table for other optimizer are the best from other papers (before I wrote this paper), which I reasonably assume they are well tuned. But I'll try and report the results later.

Thanks for your response!


fix(traverseFiber): skip siblings when ascending

Currently traverseFiber visits siblings in both descending and ascending mode. This means that ancestors can be visited multiple times - in fact you can end up visiting the same ancestor thousands of times if you have enough elements nested deep enough. This can cause stack overflows just by including something that uses useContextBridge like a Canvas.

Thanks, published a patch in v1.0.6. I'll upgrade the lockfile in R3F as well in a patch release.


cmd/compile: pointer update without write barrier in reslice operation

The ssa back end does not eliminate as many write barriers as the non-ssa back end. This should be fixed. I thought there were tests of this. Were they disabled?
In particular, reslicing an addressable slice with low index 0 should not rewrite the pointer (or the cap, usually), and not rewriting the pointer will avoid the expense of a write barrier.
Test program:
package p

func f(x *[]byte) []byte {
	*x = (*x)[:8]
	g()
	return *x
}

func g()

Without ssa:
0x0020 00032 (/tmp/x.go:4)	MOVQ	"".x+8(FP), BX
0x0025 00037 (/tmp/x.go:4)	NOP
0x0025 00037 (/tmp/x.go:4)	MOVQ	16(BX), BP
0x0029 00041 (/tmp/x.go:4)	CMPQ	BP, $8
0x002d 00045 (/tmp/x.go:4)	JCS	$0, 102
0x002f 00047 (/tmp/x.go:4)	MOVQ	$8, 8(BX)

With ssa:
0x0013 00019 (/tmp/x.go:4)	MOVQ	"".x+24(FP), CX
0x0018 00024 (/tmp/x.go:4)	MOVQ	(CX), DX
0x001b 00027 (/tmp/x.go:4)	MOVQ	16(CX), BX
0x001f 00031 (/tmp/x.go:4)	CMPQ	BX, $8
0x0023 00035 (/tmp/x.go:4)	JCS	$0, 130
0x0025 00037 (/tmp/x.go:4)	CMPQ	BX, $0
0x0029 00041 (/tmp/x.go:4)	JEQ	$0, 43
0x002b 00043 (/tmp/x.go:4)	MOVQ	$8, 8(CX)
0x0033 00051 (/tmp/x.go:4)	MOVQ	BX, 16(CX) << rewritine slice cap
0x0037 00055 (/tmp/x.go:4)	MOVL	runtime.writeBarrier(SB), AX
0x003d 00061 (/tmp/x.go:4)	TESTB	AL, AL
0x003f 00063 (/tmp/x.go:4)	JNE	$0, 109
0x0041 00065 (/tmp/x.go:4)	MOVQ	DX, (CX) << rewriting slice base ptr

If I remember correctly, the optimization in the non-ssa back end applies to any expression of the form thing = thing[:n], where thing can be arbitrarily long, provided its the same on both sides, has no idempotency problems (like function calls), and is addressable.
/cc @randall77 @dr2chase

I just fixed this with https://go-review.googlesource.com/#/c/20791/

Apologies for having an old copy.
That CL actually makes things worse. Now there is a pointer update without a write barrier. If there were a race on the slice, before the GC could not have lost track of the pointer. Now it can. This is kind of an ABA problem. Its very important never to write to a pointer in the heap without using a write barrier. The optimization must delete the pointer write entirely, not just the use of the write barrier.
At current tip:
0x000f 00015 (/tmp/x.go:4)	MOVQ	"".x+8(FP), CX
0x0014 00020 (/tmp/x.go:4)	MOVQ	16(CX), DX
0x0018 00024 (/tmp/x.go:4)	MOVQ	(CX), BX
0x001b 00027 (/tmp/x.go:4)	CMPQ	DX, $8
0x001f 00031 (/tmp/x.go:4)	JCS	$0, 91
0x0021 00033 (/tmp/x.go:4)	CMPQ	DX, $0
0x0025 00037 (/tmp/x.go:4)	JEQ	$0, 39
0x0027 00039 (/tmp/x.go:4)	MOVQ	BX, (CX) <<< update to heap pointer without write barrier (!!!)
0x002a 00042 (/tmp/x.go:4)	MOVQ	$8, 8(CX)
0x0032 00050 (/tmp/x.go:4)	MOVQ	DX, 16(CX) <<< unnecessary update of cap

Ok, then maybe I misunderstand what guarantees we provide in the presence of races.  Are we trying to guarantee that at least the GC doesn't fail if there's a race?
With a race on writing a slice to the heap bad things can happen, like getting the pointer from one slice and the length from another.  That could easily crash the gc anyway by overwriting memory.

Yes, no matter what the programmer does as far as racy writes, the GC must not lose track of and free a pointer that is still referenced. Obviously programs that corrupt memory or that hide pointers in uintptr fields may crash, but not all racy programs corrupt memory.
Much like Java, Go's memory model states that if there is a race on a single word, a future or concurrent read must see some past write. The memory model also states that multi-word writes behave like multiple single-word writes.
Suppose the initial state of the world is:
*x = make([]byte, 16) // call this x1

and then goroutine g1 does:
*x = make([]byte, 16) // call this x2

and goroutine g2 does
*x = (*x)[:8]

Although there is a race here, the guarantees about the semantics of racy programs mean that this cannot cause arbitrary memory corruption. Because the slice assignments are like three individual word assignments and because the base pointers, lengths, and caps here are valid in any combination, the result should be a valid memory state. Specifically, once both goroutines end, *x should hold one of x1[:8:16] or x1[:16:16] or x2[:8:16] or x2[:16:16]. None of those is addressing memory beyond an underlying allocation, so there's no corruption possible.
Now suppose that while these goroutines are running, the GC is also running, and consider only the slice base pointer. It could happen in the current SSA-generated code that the GC starts, then g2 reads x1 from *x on the rhs of its assignment, then g1 writes x2 to *x, then the GC scans the memory object holding *x, seeing x2. Then g2 writes x1 back to *x in its assignment, without a write barrier. Now we're in a state where the GC thinks x2 is the live pointer stored in *x, and has not seen and will never see x1. Eventually the GC will collect x1 despite it being referenced by *x, eventually causing memory corruption in a program that had none.
This is why every pointer write to the heap must use a write barrier. Optimizations to eliminate write barriers must do so by eliminating the pointer writes entirely.

Much like Java, Go's memory model states that if there is a race on a single word, a future or concurrent read must see some past write.

I'm unable to locate this guarantee in the memory model document. Can you point it out?

@cespare, see golang.org/ref/mem in the "Happens Before" section and search for "allowed". Each read is only allowed to see some value written by a write that is either in the past (and not clearly overwritten) or happening concurrently.


Setting restRequest for put and get blob

Add restRequest to get and put blobs so we can extract the IC from them. This should be done long time ago.

Codecov Report

Merging #2009 (f5afd02) into master (7c20d57) will increase coverage by 73.87%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master    #2009       +/-   ##
=============================================
+ Coverage          0   73.87%   +73.87%
- Complexity        0     9888     +9888
=============================================
  Files             0      707      +707
  Lines             0    54228    +54228
  Branches          0     6743     +6743
=============================================
+ Hits              0    40061    +40061
- Misses            0    12047    +12047
- Partials          0     2120     +2120

Impacted Files
Coverage Δ

...src/main/java/com/github/ambry/rest/RestUtils.java
92.10% <100.00%> (ø)

...om/github/ambry/frontend/AmbrySecurityService.java
91.66% <100.00%> (ø)

...hub/ambry/frontend/FrontendRestRequestService.java
90.58% <100.00%> (ø)

...com/github/ambry/frontend/NamedBlobPutHandler.java
92.56% <100.00%> (ø)

...ava/com/github/ambry/frontend/PostBlobHandler.java
97.93% <100.00%> (ø)

...ithub/ambry/tools/perf/ServerWritePerformance.java
0.00% <0.00%> (ø)

...y/network/http2/Http2PeerCertificateValidator.java
73.07% <0.00%> (ø)

...va/com/github/ambry/clustermap/DataNodeConfig.java
67.94% <0.00%> (ø)

.../com/github/ambry/frontend/GetReplicasHandler.java
75.00% <0.00%> (ø)

...github/ambry/cloud/azure/AzureReplicationFeed.java
100.00% <0.00%> (ø)

... and 702 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c20d57...f5afd02. Read the comment docs.


Reason for using a complex model.

Hi maintainers,
Just wanted to know the reason for using a complex transformers with 6 layer deep encoder and decoder. The way I see it is the transliteration depends on the current letter and one letter before and after the current letter. So won't using a simpler architecture which focuses just on the current letter the previous letter and next letter make the architecture simpler and easier to train without giving too much on the performance. Quite clearly I don't see the reason of focusing on the first letter while transliterating the last letter.
The reason I am asking this question is because this is how humans generally do transliteration (at least from hindi to english) and I am planning to explore a similar architecture. Can you suggest drawbacks of this model architecture?

(Moved your issue from the indicTranslate repo, which is for translation, not transliteration)

What you are saying is more like an character-level n-grams model. It is shown in literature that when one has significant amount of data, deep-learning models easily outperform such simple models. See this Google's paper for example, which showed that transformer-based models performed best for most languages.
Since the main motive behind the current IndicXlit was to build a multilingual model which can serve as a good baseline for the Aksharantar dataset that we released, we chose the vanilla transformer model. However, we encourage researchers to try training multilingual models which are lower in params and faster in inference. (Exploring this was out of scope of our paper).


Update Log4j to 2.17.1 to address CVE-2021-44832

What does this PR do?
Updating Log4j version to 2.17.1 because of CVE-2021-44832 vulnerability.
https://nvd.nist.gov/vuln/detail/CVE-2021-44832
Motivation

Testing Guidelines

Additional Notes

Types of changes

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

[ ] This PR's description is comprehensive
[ ] This PR contains breaking changes that are documented in the description
[ ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
[ ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
[ ] This PR's changes are covered by the automated tests
[ ] This PR collects user input/sensitive content into Datadog

Thanks again, Neel!


Column comments

resolves:

https://github.com/fishtown-analytics/dbt/issues/1722
https://github.com/fishtown-analytics/dbt/issues/1573

Description
Adding in support for Persist Docs into the Snowflake adapter and laying out a general framework for other adapters to support this feature.
Some caveats:

It only supports table materialization currently. Incremental materializations will not be refreshed with new docs until further logic is added to them. Additionally, views in Snowflake do not support altering column comments and must be created when the view is created.
Snowflake uses $$ string literal $$ to make ingesting strings with quotes easy. Therefore in your docs, if you have a $ we will replace it with [$] such that you never have two $$ next to each other.

Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[x] I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot check

Additionally, views in Snowflake do not support altering column comments and must be created when the view is created.

Just out of curiosity, how does one do that? I can see how to set a comment for the whole view, but not for columns. Is the same syntax viable for tables?

@beckjake exactly, you would have to inject it into the SQL statement itself:
https://support.snowflake.net/s/article/How-To-Add-a-Comment-to-the-Column-of-a-View

@drewbanin let me know what I need to get this over the finish line :)

hey @snowflakeseitz - do you think you'll be able to revisit this PR? I think we can indeed proceed without support for column-level comments on views for now, and there are certainly ways we can add support for them in the future too. Let me know if you're able to respond to the comments I dropped inline in this PR :)

@drewbanin I fell off the face of the earth last week with work :) I will make these changes and test them by tomorrow

@jtcohen6 can you give this a review tomorrow? Please loop in @beckjake if you have any questions :)

Discussion: where should this happen?

Let me chime in with my $0.02 here, since I'm likely going to be doing the postgres/redshift one. When I first thought about this, I was firmly in favor of this happening in a special macro called by materializations, similar to how hooks work, and letting BigQuery be the weird special case.
But then I realized that create_X_as macros have kind of misleading names. Those macros are always going to act with the current model's config settings, regardless of the relation name you create.  If you call create_table_as in bigquery with a Relation that isn't the model being materialized, your created relation will have docs corresponding to the model being materialized, even if it makes no sense! Same goes for labels. In the interest of consistency, maybe it makes a lot of sense to put this stuff into the create_X_as macros.
It also makes me think maybe we should rename these macros, but I would really prefer not to do that, plugins have just seen so much churn lately.

Those macros are always going to act with the current model's config settings, regardless of the relation name you create.

That's a really good point. Insofar as create_x_as macros are pulling directly from the model config, they are more than just boilerplate DDL wrappers.
I recall having discussed the desire for a future state in which only materializations pull directly from model config, and pass those values around to macros as keyword arguments. I don't know if that's still something we want, or if we want it enough to make meaningful steps in that direction—or, in this case, to not make meaningful steps away from that direction.

I recall having discussed the desire for a future state in which only materializations pull directly from model config

You'd have to pass something suspiciously similar to the full generic model config to a lot of these things if you wanted to handle per-adapter differences nicely while allowing third parties to create their own custom adapter-generic materializations that pass along adapter-specific configs cleanly. I suppose you could have a generic adapter_macro that takes arbitrary keyword arguments and/or a model, returns some sort of object that you should then pass to create_table_as. So materializations would do:
{# get_create_table_opts calls return adapter_macro('get_create_table_opts', model=model, **kwargs) #}
{% set create_table_opts = get_create_table_opts(model=model) %}
{% do run_query(create_table_as(tmp_relation, sql, create_table_opts) %}

Or, instead of a macro maybe you'd just pass in the global config object and give materialization authors an easy way to make their own "config"s to pass to create_table_as?
I'm not sure what that means for this PR, but I'm inclined to accept its answer of doing what bigquery already does and assuming that create_X_as is only being run for the currently-being-materialized model. I think revisiting that assumption is also totally on the table, we should just do it somewhere else (and  before 1.0).

@jtcohen6 I resolved the rebase issue from above, so the PR should be much cleaner
@beckjake happy to make further modifications if you think necessary or if it is worth waiting for the future

@snowflakeseitz FYI these tests are failing! I can take a deeper look and follow up with some more info about what's going wrong here

@snowflakeseitz I had the same issue you did when I was working on #2333! What I found was that the incremental model uses this, which doesn't have a type. My solution was to put {% set relation = relation.incorporate(type='view') %}in thecreate_view_asmacro implementation before I called the comment-setting methods, and{% set relation = relation.incorporate(type='table') %} in the create_table_as macro.

@beckjake good catch, I just merged your suggestion!

@drewbanin this has been rebased to @beckjake most recent changes! Hopefully, we can get this merged soon!

I'll kick off the test suite now, assuming it passes I'll merge it!


Crd

In seguito ai diversi cambiamenti apportati ai model e al database è richiesto il merge con il master affinchè tutti abbiano le versioni più aggiornate.

Codecov Report

Merging #33 into master will decrease coverage by 6.49%.
The diff coverage is 21.87%.

@@            Coverage Diff            @@
##           master      #33     +/-   ##
=========================================
- Coverage   77.21%   70.71%   -6.5%
=========================================
  Files           2        2
  Lines         158      181     +23
=========================================
+ Hits          122      128      +6
- Misses         36       53     +17

Impacted Files
Coverage Δ

server/routes/coordinatoriCNT.js
39.02% <21.87%> (-16.54%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c9cc5f...4bd14fb. Read the comment docs.


Gestures on-release get offset - on device event.gesture.srcEvent.layerX doesn't exist

I am trying to get offsetX on element  on which  ionic gesture is used and i do get offsetX via event.gesture.srcEvent.layerX on desktop.
But event.gesture.srcEvent.layerX shows as undefined on device.
I am using Android 6 with Ionic version 1.1.1

Thanks for opening an issue with us! We just need a little more info from you so we can better help you with this issue. Would you mind posting a codepen or giving us a code sample we can use to repro this issue with? Also if you could run ionic info and paste the output here that would be great!

Hello! Thanks for opening an issue with us! Since it has been a little while since there was any activity on this issue i will be closing it, but feel free to reopen this issue if needed!

WebView on device doesn't have the same offset properties as desktop browser, that's for sure.
So i calculated offset this way:
var realOffset = gesture.touches[0].pageX - element.offsetLeft
gesture.touches[0].pageX is offset from parent element and element.offsetLeft is offset from parent element to your element. So this works fine.


feat: SLSA 3

Description
Updates the CI to make policy server SLSA 3 complaint by providing the SBOM and provenance files.
Fix #944

I'm in the middle of a review, but I came by this specific doc for faster cross arch builds in Dockerfiles:
https://github.com/rancher/security-team/blob/main/docs/kb/rst-slsa-journey.md#faster-cross-archicture-builds

Merged by a manual merge commit as instructed by GH.


Table : update edit mode tab to navigate

Description

References
Fixes #2437
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

@prashanthr6383 Regarding the issue Dateinput field edit mode is not updated when tabbing through cells you can assign handleBlur to onDateInputBlur prop of modus-data-input component.
Apart from the issue you brought up, I see the autocomplete dropdown and date picker dropdown is not appearing as before when I press tab. Can you check that?


get_action -> get_checked_permissions

TODO

[ ] Update docs.
[ ] Changelog
[ ] Remove 8e9d158 after #900 goes in.

Do we have tests for:
* [ ]  Deny by default

* [x]  Deny all if `checked_permissions={}`

* [x]  Deny if "Foo: None" in checked_permission map

* [x]  Allow all if `None`

Not sure what you mean by "Deny by default", but I added coverage of the other three cases in e89590d.

Is there any doc string we should update for this functionality (not sure if that's included in adding docs?)

Updated doc strings in 003255d.


Feature: Prompt when applying tag on non NTFS drive

Resolved / Related Issues

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #14194...

Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

Apply tag to files on non NTFS drives

Known issues

Prompt will be displayed multiple times when trying to add a tag to multiple items at the same time

Screenshots (optional)
Add screenshots here.

Cloud drive adds tag (Should they be disabled too since it random whether they work or not, even on an NTFS drive)

Is this only for online files, or can it happen for downloaded files as well?

I think the prompt will show for those as well but either way, we'll find out one we release these changes.

/format

/Format

/format


webfontloader definitions added

webfontloader/webfontloader.d.ts
check list

[ ] is collect naming convention?

https://www.npmjs.com/package/webfontloader
http://bower.io/search/?q=webfontloader
others?

[ ] has a test file? (webfontloader/webfontloader-tests.ts or others)
[ ] pass the Travic-CI test?

Thanks for this, somehow i missed it :) I'm new to this contributing stuff. Anyhow when i'm about to run the test something goes wrong.
I did:

Created a "webfontloader-tests.ts"
Created a "webfontloader-tests.ts.tscparams" containing "--noImplicitAny --module commonjs --target es5"
Check that git(GitHub client in this case) is aware of the files
Run npm update in dt root
Run npm test

and this is where my issue occur, the testrunner does not find my tests, as it appears under the "typings without tests" category.Though it does check my syntax and header.
It does appear under the interesting files, as "not mapped? -> xxxx", could this be the issue?

:+1:


Some important changes

Changed log

Integrate StyleCI service to check PSR-2 coding style automatically on incoming commits and PRs.
Integrate the Travis CI service, please. And it can find the bugs/errors via automatic CI build.
Fix wrong namespace for ImageConverter class.
Create helper function and let convert function split from the ImageConverter class.

The completed Travis CI build log and StyleCI log are as follows:

Travis CI build log.
StyleCI log.

Now I got confused. I thought we agreed on not using jens in the namespace, but now it's back again? namespace Jens\ImageConverter; https://github.com/jenstornell/php-image-converter/issues/6
About splitting the class and the helper method into two files. It's good from a developer perspective, but from a user perspective we need to include two files instead of one, in every project. Especially if Composer is not used. I will think about it, but it has some pros and cons.

Now I got confused. I thought we agreed on not using jens in the namespace, but now it's back again? namespace Jens\ImageConverter; #6
About splitting the class and the helper method into two files. It's good from a developer perspective, but from a user perspective we need to include two files instead of one, in every project. Especially if Composer is not used. I will think about it, but it has some pros and cons.

I think we can revert the namespace to the ImageConverter. And I'm sorry I almost forget this.
Without composer, we can rpovide the autoload.php for developers to load related ImageConverter automatically.

This looks fine to me

Hey @jenstornell
any change this could be reviewed and merged? I'd like to use the package :)
Cheers,
Peter


[Vue3] build fails after installing electron-builder

https://shoprogram.blogto.jp/archives/14329281.html

https://shoprogram.blogto.jp/archives/14329499.html

finally this resolve the problem.

The issue is because ts-loader 9 doesn't support Webpack 4.

Now the build is succeeded, but not run even if double clicked the appimage file on the filer.
Finally installing fuse and libfuse2 using apt resolve this issue.


Documentation Staging

Updates from CS2101.
Documentation staging branch.
Do not merge till final.

Coverage remained the same at 92.095% when pulling<PHONE_NUMBER>6c35e8a9bf96f920eb618d9fe11003 on GeneralDocumentation into 6ba85b976c6f538a9608ae9aab1e94586413e4c2 on master.

Coverage remained the same at 92.095% when pulling 784ae01bc89dbee2d15ee82327490a4894ceac88 on GeneralDocumentation into 6ba85b976c6f538a9608ae9aab1e94586413e4c2 on master.

Coverage remained the same at 92.095% when pulling b5b1861566aeb21a3331789eabef84effbf81991 on GeneralDocumentation into 6ba85b976c6f538a9608ae9aab1e94586413e4c2 on master.

Coverage remained the same at 92.095% when pulling 31a0617393948f6c357de476681b27764f90edf1 on GeneralDocumentation into 6ba85b976c6f538a9608ae9aab1e94586413e4c2 on master.

Coverage remained the same at 92.095% when pulling 31a0617393948f6c357de476681b27764f90edf1 on GeneralDocumentation into 6ba85b976c6f538a9608ae9aab1e94586413e4c2 on master.

Coverage remained the same at 92.095% when pulling 0a217f58e7fa653dd4c93dcf3c31cb065c701381 on GeneralDocumentation into 6ba85b976c6f538a9608ae9aab1e94586413e4c2 on master.


fix($snifferProvider): allow history for nwjs applications

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
sniffer incorrectly detects NW.js applications as chromePackagedApp disallowing them to make use of the history API.
What is the new behavior (if this is a feature change)?
Correctly detecting NW.js applications allowing them to make use of the History API.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
#15474

BTW, can you change the commit message to not have : after Fixes/Closes. I.e. Fixes: 12345 --> Fixes 12345. (The : prevents proper detection of the Fixes/Closes.)

Done !


Rule CA1710: Add configurability section - Exclude indirect base types

@Evangelink commented 3 days ago — with docs.microsoft.com
Rule CA1710 was updated to allow for a new configurability section. This restrict the analysis to the current base type.
Note that on another PR we updated the default value to be true.
See https://github.com/dotnet/roslyn-analyzers/pull/3148/files#diff-1b5cdc4937a8cdfc79545945ad6c0783R413-R438 and see also dotnet/roslyn-analyzers#3236

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83202117-8bd8-aa22-d55c-42ecc59fc11f
Version Independent ID: 2374ea4f-0f8d-283e-5803-7c8de04b48f7
Content: CA1710: Identifiers should have correct suffix - Visual Studio
Content Source: docs/code-quality/ca1710.md
Product: visual-studio-windows
Technology: vs-ide-code-analysis
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@CeciAc -- Cecilia, thank you for raising this.
@Mikejo5000 -- Mike, please look into this issue.

@Evangelink How does this look?
Exclude indirect base types
Starting in version 3.0.0 of the analyzers, you can configure whether to exclude indirect base types from the rule. By default, this rule is set to true, which restricts analysis to the current base type.
dotnet_code_quality.CA1710.exclude_indirect_base_types = false

@Mikejo5000 LGTM. It might be useful to indicate that this is a breaking change compared to behavior of previous versions. I don't know how you usually represent such breaking change.

Fix is live now


Use more recent gem for caching

Replace the old lrucache gem with lru_redux, as newer versions of Ruby can't compile the dependencies of lrucache (see #16).

@Dav2070 thanks for the PR! Do you know why some tests are failing?

The problem is that Bundler 2 can't be installed with Ruby <2.3. Maybe you can set the version of Bundler to 1.x for those tests?
This isn't related to my changes, the other pull requests seem to have the same issue.

I'm having the same issue using ruby 2.7.1p83


How to drag data-point/circle in Lineseries/ScatterSeries

It is not possible to drag the points of a LineSeries / ScatterSeries they are not interactive. I also do not have plans to make such a series right now. Feel free to submit a PR if end up making one


Vectors are not identical in form

https://github.com/BAMresearch/fenics-constitutive/blob/9285ebbd4af676cf829db6ecdf2f1d6575947194/src/fenics_constitutive/solver.py#L237-L239
So, it just happened to me that this assertion failed, which means that it can happen that the solution vecor supplied in the form(self, x) method is not the vector that has been created by the function u....

What exactly does that mean, why is that important, i.e. why was the assert added?

Sorry for the short description. I just wanted to add this issue as a reminder for myself.
So basically, the solver from dolfinx provides the current solution vector with which we can determine the current strains. I assumed that this is the same vector that is inserted in the solver.solve(u) call. Furthermore, the IncrSmallStrainProblem requires the solution field u as input. Therefore the check was supposed to make sure that the u in solver.solve(u) and the one provided in the IncrSmallStrainProblem are the same (by checking the memory address) because from this u we create the expression that evaluates the gradients. This worked really well and we did not need to copy anything from the vector that dolfinx provided us because it was the vector from u.
However, in one simulation, the assert failed which meant that probably a copy of the solution vector was made somewhere, therefore we cannot work without copying the values anymore. I added this copy in https://github.com/BAMresearch/fenics-constitutive/pull/60


Urgent - Microraiden Demo Issue

"server won't accept this channel.
Please, close+settle+forget, and open a new channel"
this message is displayed on both chrome and firefox with metamask on the ropsten test network. it appears after depositing the TKN tokens and trying to sign them. Please suggest.

That was caused by the Ropsten consensus issue between parity and geth:
https://github.com/paritytech/parity-ethereum/releases/tag/v2.0.8
We're fixing our deployed instances, everything should be running fine soon. Will keep the issue open until then

Thanks Andre for your quick response. We have a planned demo with client on coming Monday(22nd ) and one of the candidate we have to demo is Micro-raiden. Waiting for your fix.

Thanks Andre,
Do I need to do anything if I am running Microraiden on my local server?.


Long pauses using LMDB on Windows

Environment

LWJGL version: 3.2.2
LWJGL build #: ?
Java version: 8
Platform: Windows
Module: core|lmdb

Description
I'm investigating lwjgl3's LMDB module.  The program starts with a massive bulk insert.  For some reason, there is roughly a 10 second pause every couple thousand inserts (it needs to make a couple hundred-thousand inserts).  I ran the same program on a Linux box and it does not have this problem.  I can also confirm that lmdbjni and lmdbjava does not have this problem, not even on Windows.
I turned on all the memory debugging options (-Dorg.lwjgl.util.Debug=true -Dorg.lwjgl.util.DebugAllocator=true -Dorg.lwjgl.util.DebugStack=true) and there haven't been any reports while the program is running.  I also tried turning on MDB_NOSYNC and MDB_NOMETASYNC and it is still pausing.
Typically, what I would expect to see in the Task Manager is the CPU usage to spike near 100% and the memory usage would slowly climb over the duration of the program.  What I'm seeing with lwjgl3's LMDB module is the CPU only slightly goes up and the memory usage remains relatively flat.
I'm not sure what else to look for.  Any idea's on what else to look for?

Hey @ChrisTrenkamp,
The LMDB build included in LWJGL supports sparse file mappings on Windows, which has not made it to the official LMDB release (and probably never will - search for ITS#8324 for details). The incremental file growth was initially very expensive, that's why we have applied this patch. It was much faster in tests, but it sounds like there's something else that interacts badly with this approach and causes the pauses in your case.
I could revert LMDB to the official release. This issue will be fixed but we lose sparseness, i.e. database files will grow immediately to their maximum size. I think you're the first user that does anything serious with LMDB on Windows, so please let me know if you're OK with this.

ITS#8324 does mention a performance reduction.  If there's a build with the patch reverted, I can test it to see if that's the culprit.

I should mention I'm currently using a non-patched LMDB release on Windows, so I'm okay with the files immediately growing to their max size.

Hey @ChrisTrenkamp, sorry for the delay, a build you may test is available here. Compiled from current head of https://github.com/LMDB/lmdb/commits/mdb.RE/0.9, the only difference is that malloc/free calls have been replaced by LWJGL's configurable allocator.
Pass -Dorg.lwjgl.util.Debug=true -Dorg.lwjgl.util.DebugLoader=true to the JVM to verify that the new build is being used. You'll need to remove lwjgl-lmdb-natives-windows.jar from the class/module-path and also pass -Djava.library.path or -Dorg.lwjgl.librarypath to the JVM (pointing to the folder that contains the new lwjgl_lmdb.dll).

Yup, the patch is the cause of the slowdown.  When using the test lmdb build, it's back to normal.

@ChrisTrenkamp Thank you!


Should be able to upgrade a project using  that only targets one framework

Describe the bug
Should be able to upgrade a project that uses <TargetFrameworks> attribute but only targets one one framework.
To Reproduce
Run the upgrade on a class library that uses the following TargetFrameworks element.
Review the MultiTargetFrameworkCheck.cs to see if the ; triggers the project system to read 2 target frameworks.
<TargetFrameworks>
net472;
</TargetFrameworks>

Looks like we want to validate the following condition was triggered by the MultiTargetFrameworkCheck.cs
            ...

            if (tfms.Count == 1)
            {
                _logger.LogTrace("Confirmed project {Project} has a valid TFM ({TFM})", project.FileInfo, tfms.First());
                return Task.FromResult(UpgradeReadiness.Ready);
            }

            ...

<TargetFrameworks> is a different property, though, then <TargetFramework> even if a single item in TargetFrameworks is equivalent to <TargetFramework>. We'll need to make sure that UA handles the properties correctly if we permit single-item <TargetFrameworks>. The MSBuild layer of the tool that reads and updates TFM properties will likely need modified.

I will try to improve this problem


Home page navbar too low

Anyone else facing this?
Browser: Firefox

Which browser are you using?

Which browser are you using?

I checked. This issue is not detected on most chromium-based browsers like Edge, Google Chrome, or Brave. However, when we use Firefox this exactly what we get.

There's a default padding maybe given by Firefox but none by any other Browser. Should I close this or let this be as a bug?

There's a default padding maybe given by Firefox but none by any other Browser. Should I close this or let this be as a bug?

Did you tried fixing it in your local files?and let us know if fixing it for firefox creates any issues in other browsers.

There's a default padding maybe given by Firefox but none by any other Browser. Should I close this or let this be as a bug?

No this is a serious bug we need to consider

Sure, I'll sit with this when i get a break again. Please do consider one day skip. Exam day tomorrow :)

Sure @rachejazz .  I can understand. You can take a day or two off for this. All the best for your exam

I will try to fix this bug!!

@smaranjitghose I saw this only on firefox:

but on chrome, there's none:

Hey @harshit078 thanks for taking this up :))
Hope this svg discovery helps you!

@rachejazz Yes, the avg animation is supposed to appear for a sidebar in smaller screens and not in the nav bar for laptop screen sizes

Cool then @harshit078 can easily now fix some more specific css tags to omit that out

Any updates @harshit078 ?

Any updates @harshit078 ?

ya sorry kinda missed few previous messages and I have been working on the bug and I will pull the request and upload it within 2 days

Any updates @harshit078 ?

I am using safari and there seemed no issue for that and checked for chrome too, I have adjusted the position Margin left and margin right attribute. I am fixing for Firefox too


add the libXScrnSaver dependency on RPM distros

This prevents Electron from crashing with:
libXss.so.1: cannot open shared object file: No such file or directory

r? @cjb

I've confirmed that the package fixes the crash, but I haven't manually tested the package build yet after this change. To do.

:thumbsup:


Add my content for website-2

update contents

why error

It looks like you changed your theme, but for this activity we want to use minima.
Activity: Change the theme to minima
Let's change the theme to minima:

At the top of this Pull Request, click the Files changed tab.
Click the icon to enter edit mode and change the  theme: to minima.
Scroll to the bottom of the window to create a commit.
Enter a commit message then click Commit changes.

Don't worry, if you don't like this theme you can always change it later.

If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.
Watch below for my next comment.

how i can change theme?


Fix build scripts

Scripts used to only build sqlite version of the binary in the build
script and then rename that file and call the build script again from
the package script to build a production-worthy static binary. This
behavior is confusing and doesn't work if you just want to call the
build script to get a static binary.
This change does two things:

Just build both versions of the binary in the build script with the
appropriate names
In the package script, if the bin dir doesn't exist, call the build
script. This lets you to just call make package directly to get a
tarball if you need to.

LGTM


Local/Global State Estimation Nodes

Typical use cases of robot_localization have two state estimation nodes - one for global pose estimates and one for local pose estimates. In terms of REP 105 (http://www.ros.org/reps/rep-0105.html), the global pose estimate is in the map frame, while the local pose estimate is in the odom frame.
The way this will be implemented is with two nodes, henceforth known as map_state_node and odom_state_node. Both will be one of robot_localization's state estimation nodes, either ekf_localization_node or ukf_localization_node. Local sensor data will feed into both nodes - these are sensor streams like IMUs, wheel encoders, and visual odometry (camera data). map_state_node will be fed data from global pose estimators as well, such as GPS and lidar.
When this issue is closed, our robot will have two state estimation nodes, map_state_node and odom_state_node. map_state_node will fuse data from lidar, GPS, IMU, and wheel encoders, while odom_state_node will fuse data from IMU and wheel encoders alone.
In a future ticket, we may decide to incorporate visual odometry into both nodes, as visual odometry is a form of local pose estimation.
https://roscon.ros.org/2015/presentations/robot_localization.pdf
https://vimeo.com/142624091

Decided that this was unnecessary. Using one state estimation node alone.


Move static files out of distribution + add prepare script for Safari

Closes https://github.com/refined-github/refined-github/issues/5250

@sindresorhus hopefully this means we'll see Safari updates more often 🙂

I tested this with two other extensions and it works flawlessly. I'll tag a new release today so @sindresorhus please try it soon. The other change I requested can come later as it's just a DX thing for local testing


lag with no output

I'm on Foundry 11.313 and using dnd 5e 2.3.1. When I click the "Export" button, the module causes foundry to freeze momentarily.
There is no dialog or output. It seems to be using deprecated code.
Here's the console output.

Error: The value of CONFIG.DND5E.abilities has been changed to an object. The former value can be acccessed from .label.
Deprecated since Version 2.2
Backwards-compatible support will be removed in Version 2.4
at Object.logCompatibilityWarning (commons.js:2054:19)
at Object.toString (config.mjs:1912:19)
at Object.f [as escapeExpression] (handlebars.min.js:27:3781)
at eval (eval at createFunctionContext (handlebars.min.js:29:1808), :11:17)
at h (handlebars.min.js:27:17870)
at c (handlebars.min.js:27:6899)
at Object. (handlebars.min.js:27:7289)
at Object.c (handlebars.min.js:27:19853)
at Object.eval [as main] (eval at createFunctionContext (handlebars.min.js:29:1808), :37:49)
at c (handlebars.min.js:27:15429)
at d (handlebars.min.js:27:15744)
at e (handlebars.min.js:28:22748)
at renderTemplate (foundry.js:7685:10)
at async PrintSheetHtml._renderInner (foundry.js:5915:16)
at async PrintSheetHtml._renderInner (foundry.js:6485:18)
at async PrintSheetHtml.convertdataToHtmlText (printHtml.js:23:24)
at async printActorSheet (print_sheet.js:37:22)
logCompatibilityWarning @ commons.js:2065
toString @ config.mjs:1912
f @ handlebars.min.js:27
eval @ VM6507:11
h @ handlebars.min.js:27
c @ handlebars.min.js:27
(anonymous) @ handlebars.min.js:27
c @ handlebars.min.js:27
eval @ VM6515:37
c @ handlebars.min.js:27
d @ handlebars.min.js:27
e @ handlebars.min.js:28
renderTemplate @ foundry.js:7685
await in renderTemplate (async)
_renderInner @ foundry.js:5915
_renderInner @ foundry.js:6485
convertdataToHtmlText @ printHtml.js:23
printActorSheet @ print_sheet.js:37
(anonymous) @ print_sheet.js:20
dispatch @ jquery.min.js:2
y.handle @ jquery.min.js:2

I didn't reproduce your error. On which version of the module are you ?
I think the error was fix some version ago. At some time I was push to change the of the id of the module from dnd5e-printSheet to dnd5e-print-sheet, you are perhaps at the old version and new one is not push to you anymore.
Can you try to to uninstall the module an reinstall it (last version is Version 2.3.2) ?

Closed because there is no more reply.


Question re: screen resizing

What is the best way to get notified when the console screen is resized?
I've tried 'Signal.trap' w/o success.
I'm using Tmux and Terminator consoles.

Hi Andy,
Please have a look at an star wars logo example in tty-font project. I'm listening for a window resize singnal to repaint the logo.


Godot v4 crashes and screen turns black

Godot version
4.0dev (commit 8485d0c)
System information
Windows 10, AMD Ryzen 5 2600, AMD Radeon RX 580 Series
Issue description
When running the compiled executable the following error messages appear:

Godot shows that it is in the Project Managment in the title bar but then turns black after a few seconds
For further information:
I have already built and run Godot 4 like 1-2 months ago and it didn't crash at that time.
Steps to reproduce

Compile Godot
Run the compiled build

Minimal reproduction project
No response

@Calinou I think you might have misread the label of my OS. Mine is windows but you added Linux as the OS label. Or was that intentional?

@Calinou I think you might have misread the label of my OS. Mine is windows but you added Linux as the OS label. Or was that intentional?

I misread the issue, sorry.

No idea how this issue got fixed, but both a custom build and the v4.0.dev.20220118.official [bc5ba38ff] works perfectly now on my maschine! I will close this issue then

Glad to hear that it is working now!


Please fix Documentation NAV bar

Environment:

Python version: NA
Jinja version: NA

The Doc link below has an unreadable navbar. Looks like styling that just happened in 3.1 version
https://jinja.palletsprojects.com/en/3.1.x/api/

Duplicate


[SPARK-22739][Catalyst] Additional Expression Support for Objects

What changes were proposed in this pull request?
This PR is a working followup to the expression work begun in #20085. It provides necessary Expression definitions to support custom encoders (see this discussion in the Spark-Avro project).
It adds the following expressions:

ObjectCast - performs explicit casting of an Expression result to a DataType
StaticField - retrieves a static field against a class that otherwise has no accessor method
InstanceOf - an Expression for the Java instanceof operation

Modifies NewInstance to take a sequence of method-name and arguments initialization tuples, which are executed against the newly constructed object instance.
Removes InitializeJavaBean, as the generalized NewInstance subsumes its use-case.
How was this patch tested?
Adds unit test for NewInstance supporting post-constructor initializations. All previous "JavaBean" tests were refactored to use NewInstance.
Additional examples of working encoders that would use these new expressions can be seen in the Spark-Avro and Bunsen projects.

Test build #90699 has finished for PR 21348 at commit f8643e3.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
            s\"in any enclosing class nor any supertype of $

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90699/
Test FAILed.

Can one of the admins verify this patch?

Test build #90700 has started for PR 21348 at commit cd7e6f3.

Test build #90700 has finished for PR 21348 at commit cd7e6f3.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90700/
Test FAILed.

Test build #90701 has started for PR 21348 at commit ab51b9f.

Test build #90701 has finished for PR 21348 at commit ab51b9f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90701/
Test PASSed.

Can one of the admins verify this patch?

The jira SPARK-25789 guide me here, thanks for @bdrillard your great job, we also meet the requirement on supporting dataset of avro during Structure Streaming. I'm adapting your code in https://github.com/databricks/spark-avro/pull/217 to newer spark version, it seems work well. Could you give me credit to give a following up work of dataset of avro support? Look forward to your reply :)

Hi @xuanyuanking, if you'd like to take on the work to fold my prior work in databricks/spark-avro#217 into Spark, that sounds good to me. Please do include me in pull-requests on this topic. Our work with an Encoder for Avro fulfills particularly heavy use-cases. I'm happy to review the work and I'd also be able to test the feature branch against our workflows as it's being discussed.
The parent ticket was previously marked as Resolved. Should we go ahead and re-open it and follow through with this PR, since it's required work for SPARK-25789? cc: @cloud-fan

@bdrillard Thanks for our reply, of cause I'll request your review and make sure I understand your implement correctly.
Should we go ahead and re-open it and follow through with this PR, since it's required work for SPARK-25789?

As avro has been included in Spark, maybe it's ok to just add these new-added expression in external?

Can one of the admins verify this patch?

The PR https://github.com/apache/spark/pull/24299 proposes another solution to add support for Avro objects; your opinions matter, we are eager to have a working solution to create Avro datasets

Hi @mazeboard, thanks for bringing your work to my attention.
To clarify, this PR could be considered follow-up work for another PR addressing adding support for Dataset of arbitrary Avro Objects, see #22878 opened by @xuanyuanking.
I'll take the time to read your request as well. It'd be good for us to compare/contrast the approaches in both #24299 and #22878.

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Tray icon is blank on macOS

When having an app open, it adds an invisible icon item to the OS top bar.

There should be a parameter to change that to an actual icon
There should be a parameter to remove it completely.

Example 1:

Example 2: View GIF

@Abruptive please respect the bug report issue template. Quoting its first three lines:
Help us help you, please take the time to fill this information 🙂.
An incomprehensible bug report is a useless bug report.
Incomprehensible / incomplete bug reports will be closed.

name: Bug Report / Feature
about: When having an app open, it adds an invisible icon item to the OS top bar.
labels: bug

Bug description
When having an app open, it adds an invisible icon item to the OS top bar.

There should be a parameter to change that to an actual icon

There should be a parameter to remove it completely.

[X] I looked at nativefier --help and https://github.com/jiahaog/nativefier/blob/master/docs/api.md

[X] I searched existing open & closed issues. Yes, my bug is new.

[X] I'm using the latest version available at https://github.com/jiahaog/nativefier/releases

Steps to reproduce
Bundle any app with Nativefier.
Expected behavior
Shouldn't show an invisible icon.
Actual behavior
Shows an invisible icon.
Debug info
Example 1:

Example 2: View GIF
Context

Nativefier: Latest
Node.js: Latest
Npm: Latest
OS: macOS

@ronjouch

@Abruptive nope, still incomplete:

Steps to reproduce
Give your full nativefier command, with the --verbose flag, on a public site:

and

Debug info
Verbose logs (command-line and/or in app DevTools console)

and

Context

Nativefier: (for example: 8.0.4)
Node.js: (for example: 13.11.0)
Npm: (for example: 6.14.7)

JS
var nativefier = require('nativefier').default;

var options = {
    name: 'Intercom',
    targetUrl: 'https://app.intercom.com/',
    appCopyright: 'Abruptive',
    appVersion: '1.0.0',
    counter: true,
    bounce: true,
    width: 1600,
    height: 1000,
    showMenuBar: false,
    ignoreCertificate: false,
    ignoreGpuBlacklist: false,
    enableEs3Apis: false,
    insecure: false,
    internalUrls: '.*?\.webflow.com/\.*?',
    hideWindowFrame: true,
    titleBarStyle: 'hiddenInset',
    disableDevTools: true,
    disableContextMenu: true,
    singleInstance: true,
    clearCache: false,
    tray: 'stay-in-tray',
    darwinDarkModeSupport: true,
    platform: 'darwin',
    arch: 'x64',
    version: '1.0.0',
    out: './build',
    overwrite: true,
    inject: [
        './source/css/styles.css',
        './source/css/scripts.js',
    ],
    asar: false,
    icon: './source/img/icon-intercom.png',
    fastQuit: false,
    // userAgent: 'Mozilla ...', // will infer a default for your current system
    honest: false,
    zoom: 1.0,
    // fileDownloadOptions: {
    //     saveAs: true // always show "Save As" dialog
    // },
    // processEnvs: {
    //     "GOOGLE_API_KEY": "<your-google-api-key>"
    // }
    win32metadata: {
        CompanyName: 'Intercom',
        FileDescription: 'Intercom Desktop App',
        OriginalFilename: 'Intercom',
        ProductName: 'Intercom',
        InternalName: 'Intercom'
    }
};

nativefier(options, function(error, appPath) {
    if (error) {
        console.error(error);
        return;
    }
    console.log('App has been nativefied to', appPath);
});

Context:
Nativefier: 8.0.6
Node.js: 12.11.0
Npm: 6.14.3

@Abruptive thanks. Well, already now I know you're using the programmatic interface, which is relatively untested.
So,

I don't have a mac and tray/trayicon works for me on Linux, so what I'm looking at, for a blind fix, is a trace in verbose logs of something gone wrong with icon preparation, or a potential warning. For CLI users it's the --verbose flag, for you please pass verbose: true in your options and come back with logs.
Also, what if you manually convert your ./source/img/icon-intercom.png to an icns file (using the tool of your choice) and pass icon: ./source/img/icon-intercom.icns ?
Finally, 1. was to get errors at build time. Can you run your app from the terminal and report about run -time errors/warnings?

I have same issue

Nativefier: 8.0.6 AND  8.0.0 tested.
Node.js: v13.12.0
Npm: 6.14.4
OS: OSX 10.11.6 (15G22010)
My verbose log:
Running in verbose mode!.txt

Hello @ronjouch I have same issue, Can you please help? Thanks.
Nativefier: 8.0.7
Node.js: 8.9.1
Npm: 5.5.1
OS: OSX 10.15.4 (19E287)
nativefier --tray start-in-tray --single-instance  www.facebook.com  --name "Facebook" --verbose
Logs:
logs.txt


Add custom color scheme picker to the Material Design 3 sample website

Use case
The Material Design 3 sample website shows how Flutter components change their theme's when a main color changes. It would be very useful for designers to be able to simulate their apps' own color palettes in the website, and see how the app would look like with all those MD3 widgets.
Proposal
Allow the website to accept a custom color scheme.

Hi! Thanks for filing this issue. I'm going to work on this once new ColorScheme roles are added(#138521).
This is duplicate issue. We can track this one https://github.com/flutter/flutter/issues/138274

Amazing, thank you!


Non root case for dockerfile_directory not working

Thanks for this simple and intuitive action!
It works perfectly when the Dockerfile is in the root of the repository (dockerfile_directory: ./).
However, I had no luck modifying this setting to a folder. It looks like the script runs cd <dockerfile_directory> before docker build ..., but none of my tries worked.
Do you have an example that works, or is this a bug?
Thanks!

Update: tried some tweaks in my fork, but I still see the same error when changing the dockerfile_directory: ./ to e.g. dockerfile_directory: appdir:
unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /home/runner/work/heroku-app/heroku-app/Dockerfile: no such file or directory

Which is a clear indication that something is wrong with cd appdir. Could it be that the async event is not finished before the docker build command?
I made some minor changes, updated @actions/core to 1.2.6, fixed typos but none of those fixed the issue. Let me know if you need a PR.
As a workaround for anyone running into this until it is fixed: add this step to your yaml
      - name: Copy
        run: cp -R appdir/* .

Hi @psolymos,
Sorry for the late reply. Interesting 🤔.  I will take a look at this and will back to you with more information soon.
Stay tuned 💪🏻

Hi @psolymos 👋🏻
Thank you for opening this issue. Previously this argument was working for me, so I did not think about it as long as I should (now I see, that it was probably working due to some other bug - possibly related to the node.js distribution I was using at the time).
The issue should be resolved by #4. A new action version is available in the marketplace under the version: v1.3.0.
Let me know if it works for you, if no, feel free to reopen this issue.
Have a nice day! 😃

Great thanks!


FC: Add new vsock connection handshake

Which feature do you think can be improved?
New Firecracker v0.20.0 has changed the host-initiated vsock connection protocol to include a trivial handshake.
The new protocol looks like this:
    - [host] CONNECT <port><LF>
    - [guest/success] OK <assigned_host_port><LF>

See PR firecracker-microvm/firecracker#1472 for detailed info.

/test

Hi guys
FC CI is definitely failing here, since this change is included only in v0.20.0. ;).
I've added another PR to do the FC version bump.

@Pennyzct thanks, but please add Depends-on: github.com/kata-containers/runtime#2379 in your commit message, that way we can see the CI using the latest version of firecracker

Hi~ @devimc
FWIT, even if I add the Depends-on: github.com/kata-containers/runtime#2379, if we don't do the runtime/ vendor update to include this commit, FC CI will still fail. ;).

/test-fc

/test

@Pennyzct thanks, now I can see that fc 0.20 is installed
[Hypervisor]
  MachineType = ""
  Version = "firecracker 0.20.0"

unfortunately FC CI is failing
Stderr: docker: Error response from daemon: OCI runtime create failed: Failed to check if grpc server is working: rpc error: code = DeadlineExceeded desc = context deadline exceeded: unknown.

Updates:
The debugging part should be only running after already getting right response code, since otherwise we may encounter JSON decode error.
dockerd[16053]: time="2020-01-10T03:34:14.461867307Z" level=error msg="Handler for POST
/v1.38/containers/7a52caa16c60249ceb09ede8b65a8161a0ad7bfe6c1cc206040456ba9737541b/start
returned error: OCI runtime create failed: unable to retrieve OCI runtime error (invalid character 'i' in
literal true (expecting 'r')): /usr/local/bin/kata-runtime did not terminate sucessfully

@Pennyzct good catch!


[New game]: Memorization cards

🎮 Game Request
Game Concept:
Memorization Cards is a challenging and engaging card game designed to test and improve players' memory skills. The game is suitable for players of all ages and can be played individually or in small groups.
Objective:
The objective of the game is to match pairs of cards with identical images or patterns on them. The catch is that all cards are initially face-down, requiring players to rely on their memory to remember the placement of cards as they flip them over one by one.
Point down the features

Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Vedansh-777 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @Vedansh-777 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Symlink files to vault rather than copying them

Is your feature request related to a problem?
I update some content from a vault within a code editor/whist developing features for the site and I have to reload the developer environment to see those changes.
Describe the solution you'd like
Either some mechanism for detected changed files within the vault path that copies the new version into the src/content/docs folder OR the ability to opt into using symbolically links files/folders instead of a raw copy.
That way the development server can stay loaded the entire time and content will refresh as if it was always in the content directory.
Describe alternatives you've considered
I considered trying to build something like this myself first but thought I should ask first.
Additional Context
No response

Thanks for the feedback.
Symlinking is not an option in this case as files from the vault are not just copied. They are actually processed, edited and then the result of this processing will be saved.
This kind of workflow is not one I envision for the plugin which is closer to the one from Obsidian Publish where you edit the vault, and then manually publish it at some point in time. Watching the vault for changes and automatically handling them properly would require quite a bit of work and add some complexity to the plugin that I'm not sure is worth it.
As a workaround, a potential solution could be for a usere to manually add a custom Astro integration that would use the addWatchFile helper:
// astro.config.mjs
export default defineConfig({
  integrations: [
    starlight({ … }),
    {
      name: 'watch-vault',
      astro:config:setup': ({ addWatchFile }) => {
        addWatchFile('path/to/vault/file');
      },
    },
  ],
});

I'll keep an eye out to see if I get some more feedback on this and if it's a common request, I might reconsider adding this feature.

Just a couple updates;

due to the location of my vault(s) within my project it seems they're already being watched by Astro and it does seem to restart the server
however, despite the server restarting - Astro does not seem to reload the config each time content changes so it doesn't result in this plugin's transformations taking place again.

A bit of a bummer but it is what it is - thanks for trying to help :D I understand your reasoning for avoiding this even for just development mode.


Fake out form change when clearing volatiles so OMs still work

Prior to commit c8d4463 this used to say this.formeChange(this.baseTemplate);. Typically this would pick up the empty effect created at the start of a battle. Because that effect has no effect type, this would exit early from the formChange code. However, that wasn't the only case, and so commit c8d4463 explicitly passed a null effect instead, so that the early exit would always apply. Unfortunately this means that onModifyTemplate cannot distinguish between a clearVolatile and a transformInfo. Since passing the empty effect used to fake everything out at the start of a battle, my best idea was to explicitly pass an empty effect so that everything else works again as they expect.
Note that passing an explicit this.battle.getEffect('') doesn't work because that effect still has an effect type, so it won't trigger the early return. Maybe it should ignore the effect type and early return on an empty id?

Shouldn't we instead just always set a source effect for transformInto? Either the Transform ActiveMove or the Imposter Ability?

I could do it this way I guess...


print warning when slack client is disabled instead of failing

I'm going to sleep now, but feel free to merge!