Cryptic GDScript Error Message for A Beginner Programming Mistake - "Unexpected token"

Godot version: v3.2.2 stable
OS/device including version: Windows 7
Issue description:
This 1-line beginner program throws a cryptic error message:

print("Hello World")

Corresponding error message:

"Unexpected token: Built-In Func:"

And it's elaborated on in the Errors tab as:

"get_token_identifier: Condition "tk_rb[ofs].type != TK_IDENTIFIER" is true. Returned: StringName()"

Expected Behavior: GDScript is advertised to new users for its similarity to Python. So it's bad when trivial code doesn't work for incomprehensible reasons - nobody should have to check documentation or have to google to debug a "Hello World" program.
How to Fix it: GDScript doesn't like the code above because you aren't allowed to do much of anything but define variables or functions at the base level of a script. So either make the reason for this specific error message crystal clear, or make the "Unexpected token" error message in general more clear.
Elaboration: Comprehensible error messages are very important for programming. Personally, I tried Godot Engine and GDScript for the reasons mentioned above, then got this bizarre error even when following basic, community-approved programming tutorials. For instance, I followed this tutorial by GDQuest (https://www.youtube.com/watch?v=UcdwP1Q2UlU ), and copying the code on most of the slides in that video causes the error mentioned in this issue, unless you code inside a function like _ready. Naturally, an incomprehensible error message in that situation is really bad.

Related to https://github.com/godotengine/godot/issues/27702.

The editor highlights issues like this immediately and is very helpful in showing incorrect syntax usage. "Unexpected token" is a common error shared by at least Python and Javascript, but I agree that the message is cryptic for a beginner.
To give a clearer message the parser would need to understand the context here and I'm not sure how easy that is to achieve.

@vnen Do you know how difficult would it be to detect method calls outside of functions?


dcrd cert file error on launch

[z@mac decred-v0.1.5]$ ./dcrticketbuyer
Failed to read dcrd cert file at /home/z/.dcrd: read /home/z/.dcrd: is a directory

Are you on the latest master?
It is possible that there is a mac specific bug.  I'll test that once I get my mac to boot up.  For the moment you can specify your cert file location with --dcrdcert=

Okay, I tried and the latest master does the right thing on a mac:
--dcrdcert=           File containing the dcrd certificate file
(/Users/jcv/Library/Application
Support/Dcrd/rpc.cert)
@raedah can you try updating?

Possibly related to this error, that I get when I manually specify the cert.
[z@mac decred-v0.1.5]$ ./dcrticketbuyer --dcrdcert=/home/z/.dcrd/rpc.cert
Failed to start dcrd rpcclient: dial tcp <IP_ADDRESS>:19109: getsockopt: connection refused
dcrd is running, and I see <IP_ADDRESS>:9109 listening, which I see if a different port. Not sure what 19109 is suppose to be.
I'll either try to get it built from the the latest master code, or try 0.1.6 if that comes out shortly.

Changed to master for dcrd, dcrwallet, and dcrticketbuyer. Now I get different errors.
[z@hostz bin]$ ./dcrticketbuyer
Failed to start dcrd rpcclient: authentication failure
[z@hostz bin]$ ./dcrticketbuyer --dcrdcert=/home/z/.dcrwallet/rpc.cert
Failed to start dcrd rpcclient: x509: certificate signed by unknown authority

@raedah You've specified .dcrwallet/rpc.cert for dcrdcert (not dcrwcert).


Sort changelogs by date then version

Fixes #1389

@weshaggard @chidozieononiwu @danieljurek should I send out an email about this, and make sure people know to add (preferably accurate) dates for older versions in their changelogs?

I don't think it is worth sending an email as most folks will ignore it. If there are any issues they will come to light in the version increment PRs.


gnutar: 1.31 -> 1.32

Motivation for this change
https://lists.gnu.org/archive/html/info-gnu/2019-02/msg00010.html

Not sure if Darwin fixup is needed, likely harmless if not
but might be good to check.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Thoughts on this? Small fixes, but nothing critical if now's a bad time?

@GrahamcOfBorg build gnutar
(fetch failed previously since it wasn't on the GNU mirrors yet, I think)

Anyone know about the Darwin fixup?

Unfortunately appears merging and seeing letting people report failures is the only way forward here, hehe.  Hopefully doesn't come to that, gnutar is hardly the sort of package that whimsically pushes versions and then leaves things broken for months, lol.  Err that is to say I think it's unlikely to be problematic (as much as such is meaningful anyway).
Apologies and of course ping me liberally on any problems or concerns.


lambda argument removal clobbers arguments within lambda

https://github.com/avo-hq/avo_upgrade/blob/53537b1b66c5e6da790e6fe5098299a4872ff909/lib/avo_upgrade/upgrade29to30.rb#L39
Given the following field option:
field :budget_total,
  format_using: ->(value) { view_context.number_to_currency(value) }

The upgrade script will transform it to
field :budget_total,
  format_using: -> { view_context.number_to_currency }

The transformed code is invalid, as the value does need to be provided to number_to_currency.

I think the value is available in that block. We pass it behind the scenes. This is our push to make all APIs more consistent and not have any arguments in our blocks.
Try to use it regularly:
format_using: -> { view_context.number_to_currency(value) }

I think the value is available in that block. We pass it behind the scenes. This is our push to make all APIs more consistent and not have any arguments in our blocks.
Try to use it regularly:
format_using: -> { view_context.number_to_currency(value) }

I think my issue description may have been unclear -- the upgrade script currently strips both occurrences of (value) from the line of code, where it should only remove the first occurence that is the lambda param. I agree that the second occurrence (the param being passed to number_to_currency) should remain in the code.

pfff. I misunderstood it! got it now! Thanks for writing back!


Automate Nightly Release

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
I'd like to see a nightly release pushed to GHCR, or Docker Hub, that allows people to adopt into the latest versions a bit quicker.
Affected area/feature

@rawkode so typically for nightly dev builds we push like a -alpha style release - is that acceptable for you here?

I'd love that. Yes, please

In previous projects we've ended up pushing nightly (or main branch) builds to a separate repository. That makes the switch to nightly builds more explicit, so there's less chance of automation accidentally configuring your production system to run a nightly build (because you assumed that everything that's pushed is a release).


Should flying-squid be es6 ?

like prismarine-world and other prismarine modules (node-minecraft-protocol included) are

Noo! ECMASCRIPT4 forever! :D

So yeah, it would be nice, we might even have some use for async/await (see kinda related discussion there https://github.com/PrismarineJS/prismarine-world/issues/4 )

We can take a look at this later. For now we don't need to make this decision

Well I don't know when "now" is, but it seems to me this should stay open. (Creeplays was joking)

If you say so :P

So, I think I'm going to do that, and use async/away. It would probably make sense to provide a promise API instead of a callback one.

done


Apply Merative Copyright

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Problem caused by stray " .iron-icon-1 " class

What is the purpose of the class .iron-icon-0 in this code segment found here
 .pd-list-item iron-icon.iron-icon-0 {           position: absolute;           top: 0.5em;         }
The reason I ask is it is causing this behavior:

By changing that rule to:
 .pd-list-item iron-icon.iron-icon-1 {           position: absolute;           top: 0.5em;         }
The view is corrected to this:

Where does the .iron-icon-1 originate in the initial version of the source code? Deleting the ".iron-icon-0" in the source also corrects the issue. Where do you apply the .iron-icon-1 class in the original source?
Thanks - it was helpful to have go through this torture. Polymer really doesn't seem like a good choice for rapid prototyping, let alone a maintainable system.

Hmm, I can't seem to reproduce this

It has the iron-icon-0 class. These classes are added by Polymer.js to scope its elements.
If I add the iron-icon-1 and it has both the 0 and the 1 will that work for both of us you think?
.pd-list-item iron-icon.iron-icon-0, .pd-list-item iron-icon.iron-icon-1 { position: absolute; top: 0.5em; }

Thanks. It looked liked Polymer was scoping - but I can't figure out how it happens. Actually, you don't even need the class. Its strange.


[move-prover] Using schemas to simplify libra.move spec.

This uses the new schemas to avoid some repetition in libra.move specs. It also fixes a bug with specification functions using the sender() builtin.
The exercise showed the need for a more powerful parameter mechanism in schemas (replacing the renaming we have right now), which is in a PR on which this one is based.
Motivation
Making specs better readable.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Existing tests pass.
Related PRs
NA

FYI @shazqadeer @sblackshear
For review, only look at the commit "Using schemas to simplify.." as it is based on the unmerged schema implementation.

:umbrella: The latest upstream changes (presumably 36e45250e0f4a6d349d49f9402724284ed0df8ea) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably b253b1f328bbdb0ee726a3541acc82ed1f552efe) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra r=DavidLDill

:pushpin: Commit 95d593c has been approved by DavidLDill

:hourglass: Testing commit 95d593c489999ed663c511acb792fceb105b8a08 with merge 1df685d78c8ecc08e5eed14c89745592574a6598...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: DavidLDill
Pushing 1df685d78c8ecc08e5eed14c89745592574a6598 to master...


Demo website and the inference model are showing different results

I am getting different results on demo website and by testing inference code. Does anyone got the same result from both sources? Demo website results are much better.
For Ex.
Ground Truth

Result from inference model code

Result from demo website

They do like the same, but when we compare there are differences between the photos.

hi,
I have the same problem, so how do you solve this problem?
Thank you!


Custom Attribute suggestions are not getting populated on auto complete

monaco-editor version: 0.25.2
Browser: Chrome
OS: Mac OS
Playground code that reproduces the issue:
const data = {
	"version": 1.1,
	"tags": [
	  {
		"name": "foo",
		"description": "The foo element",
		"attributes": [
		  { "name": "bar" },
		  {
			"name": "baz",
			"values": [
			  {
				"name": "baz-val-1"
			  }
			]
		  }
		]
	  }
	],
	"globalAttributes": [
	  { "name": "fooAttr", "description": "Foo Attribute" },
	  { "name": "xattr", "description": "X attributes", "valueSet": "x" }
	],
	"valueSets": [
	  {
		"name": "x",
		"values": [
		  {
			"name": "xval",
			"description": "x value"
		  },
          {
			"name": "xy-val",
			"description": "x value"
		  },
          {
			"name": "xyx-val",
			"description": "x value"
		  },
          {
			"name": "z-val",
			"description": "x value"
		  }
		]
	  }
	]
  }

monaco.languages.html.htmlDefaults.setOptions({data: { useDefaultDataProvider: true, dataProviders: [ data ]}});

var template = `
<html>
    <head>
    </head>
    <body>
    </body>
</html>`;

monaco.editor.create(document.getElementById('container'), {
	value: template,
	language: 'html'
});

Sample Code taken from this issue : #2284
_Added new entries in valueset x and gave true to useDefaultDataProvider in options
Description
When I type xa , the autocomplete perfectly suggests the globalAttributes, but the suggestion for the value of the attribute is not shown when i continue typing ( I think it is because of the selection )
It will be better if the autocomplete suggestion for the attribute values are shown right after the attribute name is selected from the list
Current Behaviour
The suggestions are provided only after removing the quotes and retriggering the value suggestions by typing next to the = character
Expected Behaviour
The suggestions for values has to be provided immediately after the attribute name is autocompleted
Video Explaining the issue
https://user-images.githubusercontent.com/29809906/124463128-10c10580-ddb0-11eb-9e14-ffd4b55f75bb.mov

Thanks for reporting. Value sets with global attributes didn't work.
Fixed in the language service. Not sure how quick it will be in the monaco build.

@aeschli  Thanks for this quick response . Value sets with global attributes didn't work. - Actually it is not about global attributes (or) Value sets, It didn't work when I tried the below snippet
const data = {
	"version": 1.1,
	"tags": [
	  {
		"name": "foo",
		"description": "The foo element",
		"attributes": [
		  { "name": "bar" },
		  {
			"name": "baz",
			"values": [
			  { "name": "baz-val-1" },
                          { "name": "baz-val-2" }
			]
		  }
		]
	  }
     ]
}

I hope this gets fixed in https://github.com/microsoft/vscode-html-languageservice/commit/77e44833eac686d68bc91da4684aeab306553cb8

For me there were no proposals at all as I tried with a tag other than foo. That's fixed now.
Your concern was that code completion automatically opens again (retriggers) after completing an attribute name?
I pushed a fix that too.

@aeschli Thanks for this feature https://github.com/microsoft/monaco-html/commit/04c34d444ab9e2a19d6c14e3ad30e53d05dea7f9. I will try this once it gets released in monaco-editor


My last commit breaks xrv qemu (pull request #78 )

Indeed, the IOS-XRV kernel doesn't support the virtio-blk-pci.
Only ide-hd is supported....
A way  to fix it:
Rollback and use a new mechanism to  call virtio:
into addon/qemu, using virtio-hdx.qcow2 could call a new way to construct flags
I'll work on it with your advices and your preferences....

Second possibility is to add a new option in template to choose the IDE driver.... As you like.....

I added a virtide option. Check if it works better.

xr works fine


Fullscreen window changes video mode from interlaced to progressive

I'm trying to get GLFW to create a window that plays nicely with the pre-existing video mode set up for an output that requires a very specific resolution and scan method (1080i50).
I have the output working correctly on the Windows desktop, however whenever either a fullscreen or borderless fullscreen window is created that covers the entire display, the output video mode changes from 1080i50 to 1080p25, and then to 1080p50. If I use a borderless window that is exactly 1 pixel larger, or 1 pixel smaller than the display, this video mode change does not occur.
The code I'm using to create the windows is below (I'm using a glfw wrapper in C#, but it's a fairly close mapping to the original API, so hopefully it all makes sense):
"Windowed full screen" window creation:
Glfw.WindowHint(Hint.ContextVersionMajor, 3);
Glfw.WindowHint(Hint.ContextVersionMinor, 3);
Glfw.WindowHint(Hint.OpenglForwardCompatible, true);

Monitor glfwMonitor = FindMonitor();

var videoMode = Glfw.GetVideoMode(glfwMonitor);
Glfw.WindowHint(Hint.RedBits, videoMode.RedBits);
Glfw.WindowHint(Hint.GreenBits, videoMode.GreenBits);
Glfw.WindowHint(Hint.BlueBits, videoMode.BlueBits);
Glfw.WindowHint(Hint.RefreshRate, videoMode.RefreshRate);

Window glfwWindow = Glfw.CreateWindow(videoMode.Width, videoMode.Height, "Hello World", glfwMonitor, Window.None);

"Borderless fullscreen" window creation:
Glfw.WindowHint(Hint.ContextVersionMajor, 3);
Glfw.WindowHint(Hint.ContextVersionMinor, 3);
Glfw.WindowHint(Hint.OpenglForwardCompatible, true);

Monitor glfwMonitor = FindMonitor();

var glfwVideoMode = Glfw.GetVideoMode(glfwMonitor);
Glfw.WindowHint(Hint.Visible, false);
Glfw.WindowHint(Hint.Floating, true);
Glfw.WindowHint(Hint.Resizable, false);
Glfw.WindowHint(Hint.Decorated, false);

Window glfwWindow = Glfw.CreateWindow(glfwVideoMode.Width, glfwVideoMode.Height, "Hello World", Monitor.None, Window.None);

Glfw.SetInputMode(glfwWindow, InputMode.Cursor, (int)CursorMode.Hidden);
Glfw.SetWindowPosition(glfwWindow, glfwMonitor.WorkArea.X, glfwMonitor.WorkArea.Y);
Glfw.ShowWindow(glfwWindow);

The following code however, which is a hack in my opinion, doesn't cause this video mode change:
Glfw.WindowHint(Hint.ContextVersionMajor, 3);
Glfw.WindowHint(Hint.ContextVersionMinor, 3);
Glfw.WindowHint(Hint.OpenglForwardCompatible, true);
Glfw.WindowHint(Hint.OpenglDebugContext, true);

Monitor glfwMonitor = FindMonitor();

var glfwVideoMode = Glfw.GetVideoMode(glfwMonitor);
Glfw.WindowHint(Hint.Visible, false);
Glfw.WindowHint(Hint.Floating, true);
Glfw.WindowHint(Hint.Resizable, false);
Glfw.WindowHint(Hint.Decorated, false);

Window glfwWindow = Glfw.CreateWindow(glfwVideoMode.Width, glfwVideoMode.Height + 1, "Hello World", Monitor.None, Window.None);

Glfw.SetInputMode(glfwWindow, InputMode.Cursor, (int)CursorMode.Hidden);
Glfw.SetWindowPosition(glfwWindow, glfwMonitor.WorkArea.X, glfwMonitor.WorkArea.Y);
Glfw.ShowWindow(glfwWindow);

Note how the window is exactly 1 pixel taller than the actual display.
Ideally, I'd use the windowed fullscreen window creation option, however in the video mode options, there doesn't appear to be an option to pass scan mode through, just refresh rate. Is this something that glfw handles, or the lower level display manager?

"Borderless fullscreen" window creation:

Since this method fails it is likely your OpenGL driver that detects a full screen window and changes the video mode. GLFW does not touch the video mode unless you specify a monitor.
There may be a way to disable this behavior in the settings of your GPU driver but I'm not aware of anything GLFW can do about it. I wish there was because this automagical mode switching is a frequent source of issues.

@elmindreda Thanks for the comment. I'll try a different card vendor/driver and see if I can reproduce the behavior. Pity it can't be solved in a cross-vendor way...

Hi, I am troubled by this strange phenomenon too.
I am trying to implement IME support, and I need soft fullscreen mode.
Basically, GLFW's fullscreen mode is strongly exclusive and cannot display IME candidate window or OS notifications.
I can implement it well on other platforms, but I don't know how to do it correctly only on Win32.
After checking various behaviors, it appears that the mode switches to exclusive display only when the window size exactly matches the screen size.
The only way I have found to create soft fullscreen is to shift the size by one pixel.
If anyone knows anything about this phenomenon, please let us know...
https://github.com/clear-code/glfw/commit/09cc177863d4025916aff11999b826e293c074b4#diff-475ae98b1c5241adc1365b9672ee3c565946a3618c8d6f2e409500eb9dba0395


Index out of range

Hi! I have no idea what's going wrong with my code, please help. This is my first time building a deep learning model so I'm sorry if it's a rookie issue!
params = dict(epochs = [10,20,30])
def create_model(X_train, y_train, X_test, y_test, params):
    model = Sequential()
    model.add(Conv2D(32, (3, 3), padding='same', input_shape=(X_train.shape[1], X_train.shape[2], X_train.shape[3]), activation='relu'))
    model.add(MaxPooling2D(pool_size=(2, 2))) #40x40
    model.add(Dropout(0.25))

    model.add(Conv2D(32, (3, 3), padding='same', activation='relu'))
    model.add(MaxPooling2D(pool_size=(2, 2))) #20x20
    model.add(Dropout(0.25))

    model.add(Conv2D(32, (3, 3), padding='same', activation='relu'))
    model.add(MaxPooling2D(pool_size=(2, 2))) #10x10
    model.add(Dropout(0.25))

    model.add(Conv2D(32, (10, 10), padding='same', activation='relu'))
    model.add(MaxPooling2D(pool_size=(2, 2))) #5x5
    model.add(Dropout(0.25))

    model.add(Flatten())
    model.add(Dense(512, activation='relu'))
    model.add(Dropout(0.5))

    model.add(Dense(2, activation='softmax'))

    sgd = SGD(lr=0.01, momentum=0.9, nesterov=True)
    model.compile(loss='categorical_crossentropy',optimizer=sgd,metrics=['accuracy'])
    history = model.fit(X_train, y_train,batch_size=32,epochs=20,validation_data=(X_test,y_test),class_weight=class_weights)
    return history, model

model = create_model(X_train, y_train, X_test, y_test, params)

This is what I am trying to run, my model instantiation is successful. My Hyperparameter optimization using ta.scan is not:
t = ta.Scan(x=X,             y=y,             model= create_model,             params=params,             experiment_name = 'ConvNNets')
This is the output:
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
<ipython-input-163-75bfb822ac57> in <module>
      3             model= create_model,
      4             params=params,
----> 5             experiment_name = 'ConvNNets')

/anaconda3/lib/python3.7/site-packages/talos/scan/Scan.py in __init__(self, x, y, params, model, experiment_name, x_val, y_val, val_split, random_method, seed, performance_target, fraction_limit, round_limit, time_limit, boolean_limit, reduction_method, reduction_interval, reduction_window, reduction_threshold, reduction_metric, minimize_loss, disable_progress_bar, print_params, clear_session, save_weights)
    194         # input parameters section ends
    195
--> 196         self._runtime()
    197
    198     def _runtime(self):

/anaconda3/lib/python3.7/site-packages/talos/scan/Scan.py in _runtime(self)
    199
    200         from .scan_run import scan_run
--> 201         self = scan_run(self)

/anaconda3/lib/python3.7/site-packages/talos/scan/scan_run.py in scan_run(self)
     24         # otherwise proceed with next permutation
     25         from .scan_round import scan_round
---> 26         self = scan_round(self)
     27         self.pbar.update(1)
     28

/anaconda3/lib/python3.7/site-packages/talos/scan/scan_round.py in scan_round(self)
     17     # fit the model
     18     from ..model.ingest_model import ingest_model
---> 19     self.model_history, self.round_model = ingest_model(self)
     20     self.round_history.append(self.model_history.history)
     21

/anaconda3/lib/python3.7/site-packages/talos/model/ingest_model.py in ingest_model(self)
      8                       self.x_val,
      9                       self.y_val,
---> 10                       self.round_params)

<ipython-input-162-2102ec36c34a> in create_model(X_train, y_train, X_test, y_test, params)
      2     model = Sequential()
      3
----> 4     model.add(Conv2D(32, (3, 3), padding='same', input_shape=(X_train.shape[1], X_train.shape[2], X_train.shape[3]), activation='relu'))
      5     model.add(MaxPooling2D(pool_size=(2, 2))) #40x40
      6     model.add(Dropout(0.25))

IndexError: tuple index out of range

Am I wrong or did you never use your params in your create_model function?

Your error seems to come from your input model from this line:
model.add(Conv2D(32, (3, 3), padding='same', input_shape=(X_train.shape[1], X_train.shape[2], X_train.shape[3]), activation='relu'))
One of the shapes you are referencing is out of range.


Specified custom port doesn't seem to work

Hi, I'm trying to bind the process to a specific port however, the port is ignored when creating a new socket.
(Truncated) sample code
const dtls = require('@nodertc/dtls');
const dgram = require('dgram');
const udp = dgram.createSocket('udp4');

const socket = dtls.connect({
  socket: udp,
  remotePort: 4445,
  remoteAddress: '<IP_ADDRESS>',
});

udp.on('listening', () => {
  const address = udp.address();
  console.log(`UDP server listening at ${address.address}:${address.port}`);
});

Running the code above (code is truncated) outputs this in the console: UDP server listening at <IP_ADDRESS>:59102. In other words, a random port is used. To verify, I used  $ netstat -plun and it shows a random port is used.
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
udp        0      0 <IP_ADDRESS>:59102           <IP_ADDRESS>:*                           24098/node /var/www

Looking at the dgram documentation, the following is written:
When address and port are not passed to socket.bind() the method will bind the socket to the "all interfaces" address on a random port (it does the right thing for both udp4 and udp6 sockets)"
This made me try the following, binding a port on the udp object like so
udp.bind(41234);

Doing so generates the following error:
0|index  | AssertionError [ERR_ASSERTION]: Forbidden transition from 5633 to 5633
0|index  |     at Protocol12ReaderClient.next (/var/www/ws/node_modules/@nodertc/dtls/src/node_modules/fsm/protocol.js:175:7)
0|index  |     at Protocol12ReaderClient._write (/var/www/ws/node_modules/@nodertc/dtls/src/node_modules/fsm/protocol.js:208:12)
0|index  |     at doWrite (/var/www/ws/node_modules/readable-stream/lib/_stream_writable.js:429:139)
0|index  |     at writeOrBuffer (/var/www/ws/node_modules/readable-stream/lib/_stream_writable.js:418:5)
0|index  |     at Protocol12ReaderClient.Writable.write (/var/www/ws/node_modules/readable-stream/lib/_stream_writable.js:327:11)
0|index  |     at Defragmentation.ondata (/var/www/ws/node_modules/readable-stream/lib/_stream_readable.js:635:20)
0|index  |     at Defragmentation.emit (events.js:182:13)
0|index  |     at Defragmentation.EventEmitter.emit (domain.js:442:20)
0|index  |     at addChunk (/var/www/ws/node_modules/readable-stream/lib/_stream_readable.js:301:12)
0|index  |     at readableAddChunk (/var/www/ws/node_modules/readable-stream/lib/_stream_readable.js:283:11)

I had a look at the example.js file you provided, but that doesn't seem to work for me as well.
const socket = dtls.connect({
  type: 'udp4',
  remotePort: 4444,
  remoteAddress: '<IP_ADDRESS>',
});

Running this piece of code also assigns a random port.
Node version: v10.13.0
OS Version:
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.1 LTS
Release:	18.04
Codename:	bionic

Hello, @Milannv.
You may bind a custom port using port option:
const dtls = require('@nodertc/dtls');
const dgram = require('dgram');
const udp = dgram.createSocket('udp4');

const socket = dtls.connect({
  socket: udp,
  port: 5555,
  remotePort: 4444,
  remoteAddress: '<IP_ADDRESS>',
});

It means that you want to listen on port 5555 and want to receive data from port 4444. Also you may specify a custom message filter if you receive data from many interfaces. See unicast api.

Hi @reklatsmasters,
Thanks for your quick reply. I ran your snippet above, but it still picks a random port for me.
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
udp        0      0 <IP_ADDRESS>:40477           <IP_ADDRESS>:*                           25254/node /var/www

It's a bug in unicast. Try this:
const dtls = require('@nodertc/dtls');

const socket = dtls.connect({
  type: 'udp',
  port: 5555,
  remotePort: 4444,
  remoteAddress: '<IP_ADDRESS>',
});

Unicast bind to a custom port only self-created sockets. I will fix it.
https://github.com/reklatsmasters/unicast/blob/fe83eb884bcd8687e50a4b5163a5af584d32444b/lib/create-socket.js#L16-L30

@Milannv Stop. If you provide a custom / external socket, you should bind your socket myself. Right answer is:
const dtls = require('@nodertc/dtls');
const dgram = require('dgram');

const udp = dgram.createSocket('udp4');

udp.bind(5555);

const socket = dtls.connect({
  socket: udp,
  remotePort: 4445,
  remoteAddress: '<IP_ADDRESS>',
});

udp.on('listening', () => {
  const address = udp.address();
  console.log(`UDP server listening at ${address.address}:${address.port}`);
});


I would like to see this debut in LuaConsole

I have my own build situation, but this project is magnificent. I would like to have this project as one of my build options in the program http://github.com/tilkinsc/LuaConsole , or better yet a feature. I am toying around with a few ideas and one of them is to have a preprocessor added to lua (like gcc's) and have yet to integrate lua compiler into my app. Take a look at build.lua and build_func.lua for more information on why I am interested.

Sorry, I do not understand what you want to do, is to use xmake to build your project? You can add xmake.lua in the root directory of your project.


Error when conversion region wasn't studied

Prerequisites
Please answer the following questions for yourself before submitting an issue.

[x ] I am running the latest version
[x ] I checked the documentation and found no answer
[x ] I checked to make sure that this issue has not already been filed

Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.
Test case is based on a targeted genome study. (vcf_filename='HG00403A.vcf.gz', has_tabix='True', ref_build='GRCh37', conv_region_filename='HG00403A_convert.bed', region_studied_filename='HG00403A_studied.bed') (files are on google drive in vcf2fhir/test_cases folder)
Expected Behavior
When the requested conversion region hasn't been studied, we are generating a non-conformant diagnostic report. We should decide what we want in this situation - for instance, we probably want to include a regionStudied observation that somehow indicates that the intersection of convert and studied is null.

Suggested resolution - where intersection is null, include a region-studied observation, where ranges-examined's dataAbsentReason is set to 'not-performed'


Fixer removes line breaks of Exception-sprintf-arguments

Bug report
Code snippet that reproduces the problem
<?php

throw new Exception(sprintf(
    'Old Version No. %d - V %d is not predecessor of new Version No. %d - V %d',
    2,
    6,
    2,
    3
));

After ./vendor/bin/php-cs-fixer fix -vvv
<?php

throw new Exception(sprintf('Old Version No. %d - V %d is not predecessor of new Version No. %d - V %d', 2, 6, 2, 3));

Expected: Multilines should stay.
./vendor/bin/php-cs-fixer --version:
PHP CS Fixer 3.8.0 BerSzcz against war! by Fabien Potencier and Dariusz Ruminski.
PHP runtime: 8.1.4

.php-cs-fixer.dist.php:
<?php

$finder = (new PhpCsFixer\Finder())
    ->in(__DIR__)
    ->exclude('var')
;

return (new PhpCsFixer\Config())
    ->setRules([
        '@Symfony' => true,
        '@Symfony:risky' => true,
        'combine_consecutive_issets' => true,
        'combine_consecutive_unsets' => true,
        'declare_strict_types' => true,
        'global_namespace_import' => [
            'import_classes' => true,
            'import_constants' => true,
            'import_functions' => true,
        ],
        'ordered_imports' => [
            'imports_order' => ['class', 'const', 'function'],
        ],
        'phpdoc_order' => true,
        'phpdoc_to_comment' => false,
        'class_definition' => ['multi_line_extends_each_single_line' => true],
    ])
    ->setRiskyAllowed(true)
    ->setFinder($finder)
;

This works as expected - you are using Symfony rule set which contains fixer single_line_throw.


Facing the below issue while i was trying to run node botium.js (botium-connector-alexa-smapi)

Describe the bug
when i was trying to run command node botium.js (for botium-connector-alexa-smapi).
To Reproduce
Steps to reproduce the behavior.
Expected behavior
It should run the test case(which has been coded in botium.js).
Screenshots

Desktop (please complete the following information):

OS: linux(ubuntu)
Version : 16

Additional context
why the command (i.e node botium.js) is expecting for the path/directory instead of running test case.
Below screenshot describes the  code of botium.js:

I am seeing the same issue.
"botium-cli": "0.0.44",
"botium-connector-alexa-smapi": "0.0.2",
"botium-core": "^1.4.7"
Tried running both via botium-cli and by defining a botium.js test runner file.

It is definitly a bug in the connector. I am working on it the next days. New build will be out on Monday.

The latest build of the connector (0.0.3) contains the fix for this. It is not yet available in botium-cli, will be done with the next build.

Thnx to the botium-core team
On Wed, 6 Feb 2019 at 4:30 AM, Botium<EMAIL_ADDRESS>wrote:

The latest build of the connector (0.0.3) contains the fix for this. It is
not yet available in botium-cli, will be done with the next build.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/codeforequity-at/botium-core/issues/205#issuecomment-460838415,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AoMNonYh9jDEjqkqhEIpp1iFKlbTSOFvks5vKgz0gaJpZM4aZyYa
.


ubuntu-cx11-02: Am 13.01.22 um 13:01: Transport endpoint is not connected

●<EMAIL_ADDRESS>loaded failed failed Syncthing - Open Source Continuous File Synchronization for root

LOAD   = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB    = The low-level unit activation state, values depend on unit type.

1 loaded units listed. Pass --all to see loaded but inactive units, too.
To show all installed unit files use 'systemctl list-unit-files'.

Manual restart of some dependent service(s).


Add support for loggers in LightningCLI

🚀 Feature
Hi,
add support for loggers in LightningCLI similar to the callback support.

Motivation
I want to use the LightningCLI as I want to use config files. However, I do not know how to define loggers with LightningCLI. The docs mention how to add callbacks in the config files. I just assumed to add the logger similarly. But this does not work. I added this to the trainer part of the config file:
  logger:
    class_path: pytorch_lightning.loggers.TensorBoardLogger
    init_args:
      save_dir: data/tensorboard

But I get this error

error: 'Configuration check failed :: No action for key "trainer.logger" to check its value.'

Pitch
It would be nice if one could define the logger via the config file as mentioned above.

Alternatives
It would also be possible to just pass the logger to LightningCLI:
from pytorch_lightning.utilities.cli import LightningCLI
from pytorch_lightning import loggers as pl_loggers
tb_logger = pl_loggers.TensorBoardLogger("path/to/logs")

cli = LightningCLI(Model, logger=tb_logger)

But here the ability of configuration via files is lost again.

Hi,
I think this is actually not an issue for PyTorchLightning, but for jsonargparse. Somehow the combination of Union and Iterable is not working properly (https://github.com/omni-us/jsonargparse/issues/53).
In the Trainer.__init__ the typehint for the logger has such a combination
https://github.com/PyTorchLightning/pytorch-lightning/blob/f58865aada46afcf374a3aca965292635e96319f/pytorch_lightning/trainer/trainer.py#L89
whereas the typehint for the callbacks works with List instead of Iterable
https://github.com/PyTorchLightning/pytorch-lightning/blob/f58865aada46afcf374a3aca965292635e96319f/pytorch_lightning/trainer/trainer.py#L91
I just changed Iterable -> List in my local version, i.e.
        logger: Union[LightningLoggerBase, List[LightningLoggerBase], bool] = True,

Then, parsing of the logger via the config file worked. However, I do not know if the typehint Iterable is necessary here or could be exchanged with List.

This was only a problem for python>=3.7 and is fixed by jsonargparse v3.10.1.


add theme for offline root website

As part of https://github.com/mitodl/hq/issues/785, we need to provide an offline version of the www theme, aka the root website. This theme should:

[ ] Using Hugo's pagination, create a paginated list of courses based on content of type "website" produced by ocw-studio added in this PR
[ ] Each course card should assume that an offline course site exists at the url_path front matter property and render a link to it
[ ] Render an index.html page with pagination controls that displays said pages

@pdpinch @Ferdi I made more progress on this today, styling the course cards like the search result cards:

Some things to think about:

In the content I'm using to generate this (generated by https://github.com/mitodl/ocw-studio/pull/1705) instructors are only referenced by UUID, the same way they are in the course metadata. Therefore, we need to fetch them during the build like we do during course builds. This isn't the end of the world, as the build still completes in about 4 minutes, but it does make it susceptible to the same kind of build failures as the course sites if an instructor can't be found / hasn't been deployed yet.
In a similar fashion, the course image is referenced by UUID and normally only fetched by course being rendered. I'm currently handling this by fetching the data.json from the deployed course site and using the image_src property to generate the img tag. This is the same data that open-discussions fetches to build the search index.

I'm not sure if either of these are worth addressing, but instead of doing this I was thinking that instead we might want to modify the code I wrote in ocw-studio to instead write in static instructor names and image paths. Because of the way it's set up as a prepublish action, if the instructors or images are updated then that info will also be updated in ocw-www as part of the publish. It would simplify this work and make it less prone to failure.

Let's base this off of the "compact" design instead. It doesn't have instructors so we can sidestep this concern.

@pdpinch @Ferdi Okay, I reworked this to use the compact design. fixed up the pagination controls to work offline and sorted the courses by course number. Right now I have the paginate setting in the config set to 20, so 20 items per page.

My only remaining question is what we want to do about the header. It makes sense for the logo to go back to page 1, but what about the rest of the links? Our strategy with the header in the offline course sites is to link those to the live site, so if you click give now, contact, etc. it will go there. I don't really think this makes sense for mirror drives, does it? Should we hide the links, or display something else?

My only remaining question is what we want to do about the header.

You're already changing 34 files in your PR. Can we pull out the header into a separate issue, to address later?

Can we put the pagination buttons  at the bottom ?


Revamp error handling and port tests to Jest

Currently the internal error handling sends out errors as plain
text which is not usually desirable especially if the client is
expecting JSON. Send errors as JSON if the client accepts any
content type as a response or requests for a JSON response body.
Closes #4
Remove magic error handling when a statusCode is present in an
Error object as that seems to cause more trouble than good in
general, e.g. accidentally leaking backend API errors and secrets.
As it might be sometimes desirable to short-circuit and throw a
non-500 error response let's implement a new MicriError object
that supports exactly that but with a well defined API that will
never leak any secrets.
Closes #1

Helps with issue #2 a bit


Fix Redis Test

redis test always fails when a password is set.

Nice catch!

thanks @charlesLF!


Add request context to validation

Hello, firstly thank you for this project.
Proposal
Add the context goyave.Request in the validation.
This gives the possibility to create custom validations with parameters from the Request like the user.
Current custom validation from the documentation:
func validateCustomFormat(field string, value interface{}, parameters []string, form map[string]interface{}) bool {
    str, ok := value.(string)

    if ok { // The data under validation is a string
        return regexp.MustCompile(parameters[0]).MatchString(str)
    }

    return false // Cannot validate this field
}

Proposal:
func validateUserIsAdmin(request *Goyave.Request, field string, value interface{}, parameters []string, form map[string]interface{}) bool {
    if value != nil {
        user := request.User.(*model.User)

        userIsAdmin := user.isAdmin

        return userIsAdmin
    }

    return true
}

With the fields in Request.Extra this opens more possibility to create validations that match use cases.
Possible drawbacks
A changes in the organization of structures to avoid cyclical imports.

I like the idea but this is a breaking change. The function signature is also already pretty heavy with lots of parameters. If I were to change it, I would probably create a validation.Context struct containing everything the validators could need.
About your example, this is a wrong usage of validator. You are checking for permissions, and that should take place in middleware. That is because a validator returning false will result in a http.StatusUnprocessableEntity, while you should use http.StatusUnauthorized instead.
I don't think that change would require a reorganization of the structure because we could just pass the request.Extra map to the validator, without the need for an import of the main package. I don't think validators need (nor should) get any other information from the request to avoid them going beyond their primary goal.

Sorry for the late response.
Indeed, maybe it wasn’t the best example to give, but you understood what I needed.
Your solution allows to have custom fields without having to pass the Request entirely which solve the problem.


Referencing multiple licenses

Are there any thoughts on referencing multiple licenses in contribute.json?
For https://www.gimp.org/contribute.json I went with
        "license": "GPL-3.0+, LGPL-3.0+"
The GIMP application code is licensed under the GNU GPL version 3 or any later, the library code (used by e.g. plug-ins) is licensed under the Lesser GNU GPL version 3 or any later.

I think the best would be to follow npm's lead here for package.json files and use SPDX license expression syntax. I don't think we'll be enforcing this, but it seems as close to a standard as there is, and allows for more complex license relationships than just "and". I could be convinced otherwise if others have better ideas though.

👍 on copying what npm does. It's not perfect but it's quite well established.


Fix incorrect kubernetes version in tinkerbell E2E

Issue #, if available:
Description of changes:
Fixes incorrect kubernetes version on TestTinkerbellUpgrade127MulticlusterWorkloadClusterWorkerScaleDown
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve

/cherry-pick release-0.17


Update bootstrap logic to output all changed files on disk

Signed-off-by: Brian Downs<EMAIL_ADDRESS>

Proposed Changes

Adds additional logic to capture all changed files on disk and output them as part of the error message.
Update bootstrap logic to print out all changed files on disk before exiting rather than the first one found in the loop.
Types of Changes

Verification

Change more than one file on disk that's part of the bootstrap data. E.g. client-ca.crt and client-ca.key
Linked Issues

#4797
User-Facing Change

Further Comments

Codecov Report

Merging #4800 (4dacb1c) into master (2e91913) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4800      +/-   ##
==========================================
- Coverage   10.54%   10.53%   -0.01%
==========================================
  Files         142      142
  Lines       10234    10239       +5
==========================================
  Hits         1079     1079
- Misses       8927     8932       +5
  Partials      228      228

Flag
Coverage Δ

unittests
10.53% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cluster/bootstrap.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e91913...4dacb1c. Read the comment docs.


Using $CIRCLE_BRANCH as base-revision

Orb version:
0.0.2
What happened:
We'd like to be able to pass $CIRCLE_BRANCH to the base-revision parameter in the orb so that the git checks are against it's own branch dynamically. In github the logic is in the python script to check HEAD~1 when the base revision is the same as the current branch. We weren't able to pass $CIRCLE_BRANCH to the base-revision parameter so we tried to override the BASE_REVISION env var which is used in create-parameters.py, again we couldn't find a way to do this with the orb.
base = subprocess.run(  ['git', 'merge-base', os.environ.get('BASE_REVISION'), head],  check=True,  capture_output=True).stdout.decode('utf-8').strip()
I'm not sure if this is a bug, a missing feature or theres something simple we've missed but having a dynamic base revision opens up lots of possibilities for us and any other teams that aren't doing trunk based development.
If you could advise us on if there's a work around for this that would be great
Thanks

IMO  $CIRCLE_BRANCH should be the default setting. Makes way more sense than main or staging 🤔

I experienced the same behaviour with any environment variable with the following (simplified) code:
jobs:
  setup:
    docker:
      - image: cimg/python:3.9.5
    environment:
      GITHUB_PR_BASE_BRANCH: main # set dynamically by a command
    steps:
      - checkout
      - path-filtering/set-parameters:
          base-revision: $GITHUB_PR_BASE_BRANCH
          mapping: |
            api/.* build-api true
            zoomapp/.* build-zoomapp true
            packages/ui-kit/.* build-packages-ui-kit true
            packages/redux-kit/.* build-packages-redux-kit true

When running the set-parameters command base-revision contains the string $GITHUB_PR_BASE_BRANCH instead of its value.

@ciaranmcveigh5 Using HEAD~1 as 'base-revision' seems to be a good workaround.

Can you please help me understand what use case using $CIRCLE_BRANCH as the base-revision would support? Are you pushing changes directly to the default branch?

We don't support using any environment variables here as they are injected later. However, you should be able to use a pipeline value to do what you want, if you don't like @nick-homex 's workaround:
base-revision: << pipeline.git.branch >>
Hope this helps!

pipeline.git.base_revision

I would agree but the docs indicate pipeline.git.base_revision will be empty on the first build, so will this be an issue ?
The long (40-character) git SHA of the build prior to the one being built. Note: While in most cases pipeline.git.base_revision will be the SHA of the pipeline that ran before your currently running pipeline, there are some caveats. When the build is the first build for a branch, the variable will not be present. In addition, if the build was triggered via the API, the variable will not be present.

Closing this for now as @stig has outlined why this isn't possible at this time.


STOP Button

Clicking "STOP" button causes "End of Stream" error in the UI

steps to reproduce:

make 3 identities for the same network (might need to be from demo4)
enroll with tunneler
click stop

observe service crash and output to stdout/err:
panic: listen udp6 [::1]:53: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.

goroutine 24 [running]:
github.com/openziti/desktop-edge-win/service/cziti.runListener(0xc00009caa8, 0x10, 0x10, 0x35, 0xc000086420)
        c:/git/github/openziti/desktop-edge-win/service/cziti/dns-proxy.go:145 +0x307
created by github.com/openziti/desktop-edge-win/service/cziti.runDNSserver
        c:/git/github/openziti/desktop-edge-win/service/cziti/dns-proxy.go:120 +0x107

Second attempt at reproducing crashes the desktop edge for windows - but no actual output is shown on stdout/err nor in the logs. process 'just exits'

resolved around 1.2.14+


refactor: migrate from sdk.Context to Context.Context (1/n)

Description
This pr aims to remove sdk.Context in ibcKeeper. This pr will also aim to replace many sdk imports with services from core to allow reducing the dependency graph on the sdk
Example commit messages:
fix: skip emission of unpopulated memo field in ics20
deps: updating sdk to v0.46.4
chore: removed unused variables
e2e: adding e2e upgrade test for ibc-go/v6
docs: ics27 v6 documentation updates
feat: add semantic version utilities for e2e tests
feat(api)!: this is an api breaking feature
fix(statemachine)!: this is a statemachine breaking fix
-->

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

opening this for review so the other prs dont get blocked and build up a backlog


Failed to declare brightness in variables in mostBrightColor

Failed to declare brightness in variables in mostBrightColor.

Take a look at the examples here:
https://stackblitz.com/edit/hexsorter?file=index.js


changed layout of inline code

Issue #222
Signed-off-by: Ralph Soika<EMAIL_ADDRESS>

Thanks @rsoika!


How to retrieve build artifact in release to be consumed with yml file

Hello,
I don't have find any indication on how to be able to retrieve generated build artifact in release pipeline to be deployed, with yaml file. Could you please explain how ?
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7175ebdc-0bba-7e00-d113-036a5cffe5fa
Version Independent ID: 149ab9f4-0b7d-97e7-6cf5-1b54fd04c63c
Content: Publish and consume build artifacts in builds - Azure Pipelines and TFS
Content Source: docs/pipelines/artifacts/build-artifacts.md
Product: devops
Technology: devops-cicd
GitHub Login: @chasewilson
Microsoft Alias: phwilson

@bertrandpons Thank you for the question.
Please refer to https://github.com/MicrosoftDocs/vsts-docs/issues/2341 for an extensive discussion on the subject.

@msebolt Thank you for your answer and the link. The thing is that I cannot retrieve my zip file contained in a specific artifact to be deployed with app service deployment task. I tried many combinations to be able to specify the right path to the zip package but I have not found the right way.
Is there a documentation or something to do this very simple step in yaml: publish artifact in build then retrieve its content in release pipeline task?
With the classic editor, it is straightforward!
Thank you

@msebolt well actually I have found a way that works:
I use the task PublishPipelineArtifact@1 on build side with the targetPath set to '$(Build.ArtifactStagingDirectory)'
Then on deployment side, I use the task DownloadPipelineArtifact@2 with buildType set to 'current' and downloadPath set to '$(Build.ArtifactStagingDirectory)'

I am glad you were able to resolve the problem.
You can also use publish and [download] (https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema#download) macros instead of the complete tasks to the same effect.
Closing this issue now.


Have one conda environment instead of many

@James-Price has already made progress on this.

I would have thought that PR #43  and commit 17f8300c7a320a2d5e18d014689fabfdd63422c9 would have closed this issue, but when I looked at the main branch, it looks like the rules, for example rule build_hydro_capfac, uses the old environment files:
rule build_hydro_capfac:
...
conda:
"envs/build_hydro_capfac.yml"
Does this mean that the model will not run the way the workflow is set up?

This issue is resolved through PR #43. One should no longer run in a snakemake minimal environment, but rather from highres_environment.yaml, without specifying the --use-conda argument in snakemake.
Closing this issue.


chore: add windowsnodereset.log in loggenerator.ps1

What type of PR is this?
/kind feature

What this PR does / why we need it:
add windowsnodereset.log in loggenerator.ps1
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.409%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
2620

Relevant Lines:
3669

💛  - Coveralls


make bundled app service loader use the Provider interface without auto-calling ctor

Using the SPI provider type does not allow for custom constructor signatures, as the non-JPMS path will still only find providers for classes with a no-args ctor. JPMS modules may behave differenly as the JRE libs have a different code path for that case.
For now, at least, accessing special ctor signatures still requires indirection through a stub loader service. This is the approach in 5.21


Fix #3589 Incorrect preview URL after changing in menu state

https://github.com/divio/django-cms/issues/3589 for details.
This pull request is for 3.0.x branch if it's possible to be released before 3.1

Coverage decreased (-0.1%) to 87.23% when pulling aea47ea8239c2ab149d029d185c540674e50198b on vstoykov:fix_3589_for_3.0.x into 1ecc678cb8b841d051e6db30bcc591dfe5e1653c on divio:support/3.0.x.


Frontend - Search Events - Build in Search events bar to search events page

Incorporate and style search events bar into search events page ???
Requirements:

ensure is mobile friendly

for search by date range - need start and end date "YYYY-MM-DD"


Keep old changelog entry dates/version

Don't think this is likely a bug, but probably just working as intended but when I run the command on an changelog file that already has an entry, the last date and version is replaced with the new one. And commits are just merged on top of old ones.

Is there a way to keep the old entries. Basically append the new changlog entry (version/date and commits) on top of the old entries so all version entries are saved and separated by date and version.
Like this for example:
v0.3.0 - 2017-12-12
Merged

[GRIDP-1] Landing page #7
Server Docs and Version Route #6

Commits

[GRIDP-1] Landing page - (known issue: need full images from design) 63013a4
Changing order of setup to make logs work for health check again

v0.2.0 - 2017-12-08
Merged

Root component must re-render for routing. #3
root component must re-render for routing. #2

Commits

[GRIDP-1] Landing page - (known issue: need full images from design) 63013a4
Changing order of setup to make logs work for health check again

You have to tag your commits with versions for things to work correctly. See the tags in this repo as an example. Tagging old commits is pretty easy, eg:
git tag v0.2.0 6f85d9a

Ahh right.. Thanks! Much appreciated.

Yep works, thank you sir. Such and awesome tool!


[DOC-408] Add separate page for Kubernetes Operator release notes

[DOC-408] HTML Preview
This adds a separate page for announcing Kubernetes Operator releases. Rather than list individual changes, it provides links directly on Github.
I've put the new page below the sub-section for CBDB releases.

This change is

LGTM

At @jseldess 's suggestion, I've made an update to point to the changelog entries in master rather than Git diffs. I also added some Liquid templating to make the page easier to maintain in future.


Only update contentInset if needed

Only update contentInset if the new insets are different from the existing insets. This avoids triggering unnecessary table/collectionview reloads.

Looks like we might have some CI issues, possibly related to our recent move to GitHub Enterprise. @br-will-mcginty are you able to check the web hook settings for Travis CI to see if we need to update them?

@tylermilner  It looks like the web hook is being delivered to Travis and the build is running https://travis-ci.org/github/BottleRocketStudios/iOS-KeyboardSupport/jobs/766957208/config. I don't have a whole lot of time to debug it right now, especially considering we won't be able to use it soon when it's no longer free. I'm going to wait until the end of the day for any issues with the content and then merge without the checks.


fix rosdep broken issue

Fix for issue reported in https://github.com/ros-infrastructure/rosdep/issues/878 (I'm keeping the later code - not sure if that is entirely right, but right now rosdep is broken for ALL users who try to run rosdep update)

Appears to have been broken in https://github.com/ros/rosdistro/commit/28562ef9c1e558dc71099055c0f16db6ec30cc24 - CI failed after the merge (not sure why it passed initially).
Maybe @audrow @jacobperron or @tfoote are around and can get this merged?

Looks like https://github.com/ros/rosdistro/pull/33535 is another possible fix

I think I beat you by less than a minute :)


cmd/go: adding -cover to "go test -n" can cause spurious failures

On tip,  invoking "go test -n -cover ./..." on a collection of packages that include at least one package with code but no tests can result in a spurious errors. Example:
$ cd `go env GOROOT`
$ cd src/internal/coverage
$ go test -n -cover ./...
...
internal/coverage/uleb128: open $WORK/b112/covmeta.b07a5f2dff1231cae3a6bdd70c8cc7c19da16abf8ac59747d8e9859c03594d37: no such file or directory
$ echo $?
1
$

This obviously shouldn't be happening for a "-n" test run (works fine without -cover).

Similar Issues

https://github.com/golang/go/issues/65653
https://github.com/golang/go/issues/23454
https://github.com/golang/go/issues/43242
https://github.com/golang/go/issues/27333
https://github.com/golang/go/issues/63356

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)


Corrected spelling mistake

Issue Number
fixes #108

Describe the changes you've made
Corrected spelling: parlimentary -> parliamentary
Adress -> Address already done by someone.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Additional context (OPTIONAL)

Checklist

[ ] I have added my name in the contributors list at the end of README.md file.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.
[x] Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here) LGMSOC'21

@QAZIMAAZARSHAD plz add LGMSOC and Level label to this PR.

@QAZIMAAZARSHAD plz add LGMSOC and Level label to this PR.

No need already in issue.


Support for mute/deafen commands - Feature Request

The Story:
I'm attempting to use vesktop over the good ol' discord client because of performance however it is lacking a feature I've gotten too used to and that is being able to Mute/Unmute with a mouse button via Logitech's discord integration, after asking in the vencord server I was told that it's because arRPC doesn't support the required RPC commands.
The Request:

Mute/Deafen RPC Commands

Just chiming in to say I'd like this functionality as well for usage with the stream deck. I am willing to contribute to getting this in if it's something achievable.


Rule: Prefer IntArray instead of Array to escape boxing

Prerequisites
Since Kotlin has no notion of primitive types, there are speicalized Array instances for each Java primitive:

IntArray
DoubleArray
FloatArray
ShortArray
ByteArray
LongArray
CharArray

From this point I will refer to the arrays of primitive types as Array<Primitive>.
As stated here in docs and stackoverflow, using Array<Primitive> leads to implicit boxing and perfomance hit.
Thus, I think we should mark Array<Primitive> usages to help improve performance and educate non-Java newcomers
Actual rule
Actual rule should detect these patterns:

Using Array<Primitive> as a parameter of the function
Using Array<Primitive> as an explicit return type
Using arrayOf() factory with primitive types

These three can be standalone rules or one rule tweakable from config

@Mishkun Is there any specific reason why this rule should only detect the following cases and not all usages of Array<Primitive>.

Using Array as a parameter of the function
Using Array as an explicit return type
Using arrayOf() factory with primitive types

@Mishkun I updated your initial issue post to supply a check list for future features/improvements of this rule.


⚠ Bofrost.be has degraded performance

In 34eb11e, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2175 ms

Resolved: Bofrost.be performance has improved in 75bada1.


Motivation for file headers

The coding standards associated with the template make a specific  recommendation for file headers, however, it is not clear where these recommendations come from, or how these values would be read or set in practice.
Also, the specific line
# encoding: utf-8

is more commonly
# -*- coding: utf-8 -*-

Finally, by recommending
#!/usr/bin/env python

you're basically saying that every Python module file will be executable.  I don't think this is recommended practice.  The #! line only belongs in truly executable scripts that will be installed in a bin/ directory.

I have been using the utf-8 encoding line like that forever (not sure why, it has always been like that in my new file snippet) and not seen any problem, but I'm not opposed to changing it.
I see the point in your comment about the shebang, but adding a shebang doesn't make the file executable. It does prepare it for the case that so that if you make it executable. But I think I agree that only python files in bin/ should be executable.
Thoughts?

I think that
# encoding: utf-8

is exactly equivalent to
# -*- coding: utf-8 -*-

in the Python environment, because both contain the substring coding: utf-8.  However, the second form may be more widely recognized, for example by certain text editors, in addition to Python.

By the way, my views are strongly shaped by the Astropy code & documentation guidelines, so this is where I'm coming from:

http://docs.astropy.org/en/stable/development/codeguide.html
http://docs.astropy.org/en/stable/development/docguide.html

Those are good resources. I've added them to the further reading section.


After integrating sentry, the white screen takes too long to start the app, with a delay of about 3 seconds.

Platform
Dart
Obfuscation
Disabled
Debug Info
Disabled
Doctor
[!] Flutter (Channel unknown, 3.7.0, on macOS 14.0 23A344 darwin-x64, locale
zh-Hans-CN)
! Flutter version 3.7.0 on channel unknown at /Users/anker/flutter
Currently on an unknown channel. Run flutter channel to switch to an
official channel.
If that doesn't fix the issue, reinstall Flutter by following instructions
at https://flutter.dev/docs/get-started/install.
! Unknown upstream repository.
Reinstall Flutter by following instructions at
https://flutter.dev/docs/get-started/install.
• Framework revision b06b8b2710 (10 months ago), 2023-01-23 16:55:55 -0800
• Engine revision b24591ed32
• Dart version 2.19.0
• DevTools version 2.20.1
• If those were intentional, you can disregard the above warnings; however
it is recommended to use "git" directly to perform update checks and
upgrades.
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/anker/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• Java binary at: /Applications/Android
Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15A240d
• CocoaPods version 1.13.0
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
[✓] VS Code (version 1.84.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.76.0
Version
7.9.0
Steps to Reproduce
Future<void> setupSentry(AppRunner appRunner, String dsn,
    {bool isIntegrationTest = false,
    BeforeSendCallback? beforeSendCallback}) async {
  await SentryFlutter.init((options) {
    options.dsn = dsn;
    options.tracesSampleRate = 1.0;
    options.addInAppInclude('charging');
    options.considerInAppFramesByDefault = false;
    options.attachThreads = true;
    options.attachStacktrace = true;

    // We can enable Sentry debug logging during development. This is likely
    // going to log too much for your app, but can be useful when figuring out
    // configuration issues, e.g. finding out why your events are not uploaded.
    options.debug = true;
    options.maxRequestBodySize = MaxRequestBodySize.always;
    options.maxResponseBodySize = MaxResponseBodySize.always;

    options.environment = serverEnv.toString();
  },
      // Init your App.
      appRunner: appRunner);
}

Expected Result
After integrating sentry, the app starts without a white screen.
Actual Result
After integrating sentry, the white screen takes too long to start the app, with a delay of about 3 seconds.
Are you willing to submit a PR?
No

Hi, are you able to try out the latest 7.13.2 and see if this problem persists?
Also which platforms are affected by this?

Hi, are you able to try out the latest 7.13.2 and see if this problem persists?
Also which platforms are affected by this?

After upgrading to the latest version 7.13.2, it was found that it was a device problem.


Avoid duplicate cache layers for fetching display recipients

I dismissed the CodeQL alert, since it's unrelated to this PR. A few inline comments above, and a few higher-level thoughts:

Medium-term, we will add an API option to just request a list of user_ids instead of a display_recipient and sender* fields when fetching messages; I expect that's what we'd want our official clients to be doing to avoid wasted resources fetching all the data. (We might still want the current behavior to be supported to make life easier for simple API clients, but fancier clients should already know what users exist and/or support doing a separate API query to find out more about users they don't know anything about).
Am I correct that this is indirectly another piece of payoff from the denormalized .recipient fields we added, or could we have always done this, I guess at least ever since we arranged to fetch these in bulk for the entire batch of messages once per aPI request? Mostly just curiosity.

* Medium-term, we will add an API option to just request a list of `user_ids` instead of a `display_recipient` and `sender*` fields when fetching messages; I expect that's what we'd want our official clients to be doing to avoid wasted resources fetching all the data. (We might still want the current behavior to be supported to make life easier for simple API clients, but fancier clients should already know what users exist and/or support doing a separate API query to find out more about users they don't know anything about).

Yeah, that would make a ton of sense.  It actually seems pretty easy to do, since post_process_dicts does the hydration, and it's only four or five functions down the stack, so not too painful to plumb in the flag for it.

Am I correct that this is indirectly another piece of payoff from the denormalized .recipient fields we added?

This particular PR was more enabled by 2017 work related to message hydration, such as 3910448b1dd27ca71203fa7b9448bb89f2c97a2a
But the broader effort that I have been making to clean up some of the cache-related stuff has definitely taken advantage of the denormalized recipient field on Stream.

Ready for review again.

I added a fourth commit here to clean up a layer of indirection that is no longer useful.

Looks great, merged, thanks @showell!


Cow: Watch toptobottomrenovation.com

Cow requests the watch of the watch_keyword toptobottomrenovation\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

toptobottomrenovation\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


outofcontext.party games

This PR adds 3 writing based games to rocketcrab from outofcontext.party and a new "Writing" category:

Raconteur - collaboratively write stories one line at a time while only seeing the last line
Hodgepodge - collaboratively build recipes in a similar fashion
Redacted - Raconteur, but with extra steps in the middle to modify the previous line (collab mad lib)

outofcontext.party has been updated to support creating games from rocket crab, inheriting nicknames, and hiding the lobby code.
I didn't add the other games because Scribble (another drawphone) and Wurderer (spoon assassin with words) didn't seem necessary.
Raconteur was created without the knowledge it was based on something but I included the "flavor" of game it is in basedOn. Hodgepodge and redacted are original creations and aren't really based on anything.
At the moment, games are capped to 255 players but I've never seen a lobby with more than 20 so it's probably not a big deal.

Thank you for your submission! Apologies for taking 3+ years to get back into developing rocketcrab.

Awesome! Happy to contribute! A good project never dies


Remove image uploading to 3rd party service

The xcresulttool will no longer process attached images and upload the to a 3rd party service.
Fixes #4
Fixes SECINC-79

@jozefizso thanks, but after changing dependencies in the package.json file, the package-lock.json file must be also "recreated"


Allow hard-coded defaults to be overridden by pkgr.yml

Otherwise these take precedence over the config file and can only be overridden by CLI options

@crohr Review please?

Could you set the defaults in https://github.com/crohr/pkgr/blob/master/lib/pkgr/config.rb instead?

@crohr I think that should do it. It seems that modifying the package name is already working on Packager.io.

Merge please @crohr ?


[ci] Factor out "release crate versions" script

Sometimes we want to manually release, often when we are making a change and releasing it in the same commit. This makes that process easier.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.40%. Comparing base (7f2d45d) to head (1a660ec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1824   +/-   ##
=======================================
  Coverage   87.40%   87.40%
=======================================
  Files          16       16
  Lines        5995     5995
=======================================
  Hits         5240     5240
  Misses        755      755

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Safe Sysctl 1.32 sync: net.ipv4.rmem and net.ipv4.wmem

This should be merged after https://github.com/kubernetes/kubernetes/pull/127489 was merged.
xref https://github.com/kubernetes/kubernetes/issues/125234

This is ready for review as https://github.com/kubernetes/kubernetes/issues/125234 was merged last week.

/cc @SergeyKanzhelev

/sig node network

Thanks.
/approve


Rebase in changes from main branch

Merging changes from main into the current branch to re-sync.
CLA:
I have read the CLA Document and I hereby sign the CLA
Code of Conduct:
I have read the Code of Conduct and I hereby accept the Terms

CLA:
I have read the CLA Document and I hereby sign the CLA

Code of Conduct:
I have read the Code of Conduct and I hereby accept the Terms


Registering New Email

How to register new Email -- In Web UI ?

Please review the end of this section: https://github.com/Netflix/security_monkey/blob/develop/docs/userguide.md#receiving-notification-mails
There are a bunch of changes that need to be made to streamline and improve the email feature.


Fixed #1109 : Make country clickable on Product Page

Description
The country is now clickable and opens in a chrome custom tab .
Related issues and discussion
#1109
Screen-shots, if any

conflict to solve

The build seems to be failing.

@teolemon Sorry , I have been busy lately .
Will send a new pull request .


Looks like two events with the same name can be added.

There already exists a test for the validating two events with same name. The state machine already checks for existing state with same name. For reference look at the below test
https://github.com/blakewatters/TransitionKit/blob/master/Specs/TKStateMachineSpec.m#L77


Discrepancy with respect to OTel semantics in RabbitMq Span

Setup: Traceshop application instrumentation with HT java agent
Routing key which is a required key for RabbitMq backend, is missing in the span event for rabbitmq request from    shipitservice (https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/messaging.md#rabbitmq)
Span kind is missing in the span event for rabbitmq request from login service & user service . A span event is considered as backend if it is an Exit span & it is a leaf span. Missing span kind  causes the span to be not considered for backend resolution. (spec: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/messaging.md#span-kind)
cc @pavolloffay
rabbitmq-span-event.zip

Routing key which is a required key for RabbitMq backend, is missing in the span event for rabbitmq request from shipitservice (https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/messaging.md#rabbitmq)

The routing key attribute is added only if it is not empty:

RabbitMQ
In RabbitMQ, the destination is defined by an exchange and a routing key. messaging.destination MUST be set to the name of the exchange. This will be an empty string if the default exchange is used. The routing key MUST be provided to the attribute messaging.rabbitmq.routing_key, unless it is empty.

The implementation looks correct:
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/master/instrumentation/rabbitmq-2.7/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rabbitmq/RabbitTracer.java#L114

Right, the routing key for shipitservice rabbitmq event is present when instrumented with old java agent.
https://app-dev.traceable.ai/backends/backend/d1912eb7-5745-31a6-9e7b-bc63397ee3e6/traces?time=1h&filter=tags_ckv_servicename%253Ashipitservice

Span kind is missing in the span event for rabbitmq request from login service & user service . A span event is considered as backend if it is an Exit span & it is a leaf span. Missing span kind causes the span to be not considered for backend resolution. (spec: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/messaging.md#span-kind)

The rabbitmq instrumentation sets explicitly the span kind to client/producer https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/master/instrumentation/rabbitmq-2.7/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rabbitmq/RabbitTracer.java#L36
or consumer https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/master/instrumentation/rabbitmq-2.7/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rabbitmq/RabbitTracer.java#L80
I assume the span kind gets lost somewhere in the conversion process. Our java agent uses Zipkin exporter and exports data to OC service wich converts data to OpenCensus and then to Jaeger.

The routing key seems to be present in all cases when it makes sense e.g. amqp.command=channel.open does not have the attribute bc there is no routing in this case.
The missing span kind is because the opencensus-service (used by HT platform) does not recognize producer and consumer types https://github.com/hypertrace/opencensus-service/blob/main/receiver/zipkinreceiver/trace_receiver.go#L514. These types are not defined in OC proto. As a workaround I will put them directly into attributes.

Done in the collector


The right way to add wallet button resource

I have copy pasted your xml for the button but now lint is failing on my project
Here is the issues that are in the icon

What do you recommend?

You need to put it bellow


New package: Openstreetmap.Osm2pgsql version 1.7.2

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

This is a version 1.4.0 manifest. Awaiting zip support.

/AzurePipelines run

Validation got an HTTP error:

Exception Message: The remote server returned an error: (503) Server Unavailable. (type WebException)

/AzurePipelines run

Hi @noenandre,
This application doesn't seem to stay running, and it gives an error exit code. Is this expected?

Launching executable file: C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\osm2pgsql.exe
Executable ran for 10 seconds: False
Executable returned exit code: -1073741515

No, seems like this PR has to wait on #2711


Order-dependent circular import error

Currently, attempting to import the gaslines.solve module without having previously imported the gaslines.display module results in an ImportError, illustrated below:
>>> import gaslines.solve
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "./gaslines/gaslines/solve.py", line 7, in <module>
    import gaslines.display as display
  File "./gaslines/gaslines/display.py", line 9, in <module>
    from gaslines.solve import has_head
ImportError: cannot import name 'has_head' from partially initialized module 'gaslines.solve' (most likely due to a circular import) (./gaslines/gaslines/solve.py)

I agree with the diagnosis that this is "most likely due to a circular import", as a function from solve is indeed dependent on one from display, and vice versa.
In contrast, if the display module is instead imported prior to importing solve, then this error is avoided:
>>> import gaslines.display
>>> import gaslines.solve

In other words, whether such an error is encountered is dependent on the order in which modules are imported, which should not be the case.
In fact, even though it is true that all unit tests pass upon running a command like invoke test, this is most likely a consequence of the fortuitous order in which the modules of the tests package are loaded prior to running the tests. More specifically, it appears as though the error is avoided in this case simply because the modules are loaded in alphabetical order, and the test_display module, which imports the display module, alphabetically precedes the test_solve module, the sole test module dependent on the solve module. Indeed, renaming the test_display module (for example, to test_zdisplay) so that it alphabetically succeeds test_solve causes the error to manifest.

This issue has been resolved via #51.


Implement IGMP packets

Retake on #60/#176 to clean up commit history.

Thank you for the feedback.
Please forgive that I've cheated a bit in set_max_resp_time() but generating the exp/mant form is tricky while currently not needed. I added a comment in that place.

No, that's not acceptable. There shouldn't be any broken accessors.
You could make the Packet accessors read and write the raw value--the transformation to/from Duration shouldn't happen at that level anyway--and panic in Repr::emit, with documentation.

Thank you for the feedback. I hope the max_resp_time is now properly.

Thanks!
@dlrobertson r?

@whitequark looks good to me


Submitting Issue - crash

Goals
Submit my iOS app to App Store
Expected Results
Archiving the app, upload to App Store. (Realm was ok when developing the app. It runs with no issue at all. The app runs on both simulator and real device perfectly.)
Actual Results
At Archiving stage, start to have issue about Realm. Get "/Frameworks/Realm.framework: unknown error -1=ffffffffffffffff
Command /bin/sh failed with exit code 1"

Steps to Reproduce
Nothing special. My app was building totally fine, no issues. Then cleaned and tried to Archive it. Started to report same thing over and over for Realm.framework: unknown error -1
I've tried many times to uninstall and reinstall Realm on Cocoapod, by both way:
Code Sample
pod 'Realm', :git => 'https://github.com/realm/realm-cocoa.git', :branch => 'master',     submodules: true
pod 'RealmSwift', :git => 'https://github.com/realm/realm-cocoa.git', :branch =>     'master', submodules: true
(This way gives me Realm 3.0.2 and RealmSwift 3.0.2)
and:
pod 'Realm'
pod 'RealmSwift'
(This way gives me Realm 2.9.1 and RealmSwift 2.9.1)
I also tried the way to download latest Realm package and drag and drop the frameworks from latest version, which is Realm 3.0.2. Also copied the Run Script:
bash "${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/Realm.framework/strip-frameworks.sh"
I tried both Swift-4.0 and Swift-4.0.2 version, none worked.
Now still have the same error, and I don't know where to go. Please help me with this issue, as my app is ready to submit for the store. I hope to make it before Christmas.
Thanks a lot!!
Joyce
Realm framework version: 3.0.2
Realm Object Server version: n/a
Xcode version: ?9.1
iOS/OSX version: 11
Dependency manager + version: n/a

@cityinthepark Could you send us<EMAIL_ADDRESS>your project? Archiving issue is not difficult but debugging remotely is very hard. We keep your project completely private.

OK. Please do keep my work secure. Will you please delete it right after solve the problem?
And which folder should I send? The root folder of the whole project? Or some subfolder of it? Right now the zip file is 138mb.
Thanks a lot!

On Nov 15, 2017, at 7:50 PM, Kishikawa Katsumi<EMAIL_ADDRESS>wrote:
@cityinthepark https://github.com/cityinthepark Could you send us<EMAIL_ADDRESS>your project? Archiving issue is not difficult but debugging remotely is very hard. We keep your project completely private.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/realm/realm-cocoa/issues/5477#issuecomment-344807478, or mute the thread https://github.com/notifications/unsubscribe-auth/Aeieiq-u-RNsBbfK7gRXcc1uMKTEoiZiks5s27D8gaJpZM4Qf44g.

Oh I've solved the issue.
By doing this:
pod cache clean Realm
pod cache clean RealmSwift
pod deintegrate || rm -rf Pods
pod install --verbose

@cityinthepark We keep your project secure. Also, will delete it right after solving the problem.
We need a reproducible case. So please send the root folder of the whole project. Probably a mail server cannot receive 138MB zip file. Can you upload it to cloud storage like google drive and let us know share URL?

@cityinthepark Sounds good.


[Improvement]: Improve worker message passing to reduce memory leak

Description
$subject
Describe your problem(s)
The following code which passes 10KB json data between 3 workers increases the memory usage over time.
The heap dump shows a large count of WorkerDataChannel objects.
import ballerina/time;

// json payload = some 10KB json value
public function main() returns error? {
    time:Utc utc = time:utcAddSeconds(time:utcNow(), 1800); // 30 mins running
    while (utc >= time:utcNow()) {
        check testWorkerMessaging();
    }
}

isolated function testWorkerMessaging() returns error? {

    worker w1 returns error? {
        json res1 = clientFunc1(payload);
        res1 -> w2;
    }

    worker w2 returns error? {
        json res1 = check <- w1;
        json res2 = clientFunc2(res1);
        res2 -> w3;
    }

    worker w3 returns error? {
        json res2 = check <- w2;
        json res3 = clientFunc3(res2);
        res3 -> function;
    }

    json res3 = check <- w3;
    check wait w3;
    return ();
}

type Rec record {|
    int i;

|};

isolated function clientFunc1(json payload1) returns json {
    return payload1;
}

isolated function clientFunc2(json payload1) returns json {
    return payload1;
}

isolated function clientFunc3(json payload1) returns json {
    return payload1;
}

Memory graph :

Heap dump :

Heap dump file :
https://drive.google.com/file/d/1dXK7C2tZiPxXkHsfhEYhXgRaG7y_Datw/view?usp=sharing
Describe your solution(s)
Clean up the channels & channel details.
Related area
-> Runtime
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

After removing the redundant WorkerDataChannel and ChannelDetails instances, the memory usage is reduced to the following.
Memory graph :

Heap dump :

This is now available in 2201.9.0.


Empty spring.factories

Not actually an issue, but I am investigating on how to create my custom spring boot starter and I came across your repo. My question is: why is spring.factories file empty?
My understanding is that if the file is empty, the user has to manually include @EnableSAMLSSO, otherwise if the user includes the configurer class in the file, spring boot will automatically process the configuration without @EnableSAMLSSO. Is this correct?

you're right, spring.factories in this library is not doing anything. Originally I was gonna make it a starter jar but then I modeled it based on other security plugins such as Spring OAuth2 that use annotations such as EnableAuthorizationServer and EnableResourceServer. For a sample where spring.factories is actually used you can check this other repo I have jasypt-spring-boot where the module jasypt-spring-boot-starter all it does is to have a spring.factories to load the auto configuration


fix faulty error checker

Fixed faulty error checker from issue #8

Is this okay @anonymouse-cmd?

Yes, looks good!

Great, lets merge this!


cranelift: Sign extend Imm64 immediates

When an instruction has an Imm64 immediate, but operates on values of a
narrower width, we need to sign extend the value.
Fixes #1095
cc @bjorn3

This isn't quite ready; needs a little more finesse than this blunt of a hammer.

Ok, I think this should be passing tests now.

Thanks for reviews!


Stopped packs are not cleaned up

The hub probably needs to a a wait to clean up the child process, left over after it kills it. Right now, zombie processes remain visible in the ps (they have already ceased execution, the O/S keeps them around for their exit state) - reported by @doewie on Gitter.

Shelved, closing.


Added WSS Stuttgart

@koch86 First stage of verification passed, official domain is wss-stuttgart.de as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@koch86 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


pre-build binary in release

Can a release also include a pre-build binary ? we need this to create a runtime update package for zos so we can include both the new version of seektime and the code to handle it to running machines
Please check my comment here
https://github.com/threefoldtech/zos/pull/2023#issuecomment-1686272264

Implemented https://github.com/threefoldtech/seektime/commit/98be93d9d609c5397c85abd057902c3e23a3f1d7


Add docs about integration into Asana

Oops PR'd this into the wrong repository. While working on setting up a fork which includes #34.
My apologies.


Unable to generate admin.conf

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Environment:

Cloud provider or hardware configuration: AWS

OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"): ubuntu

Version of Ansible (ansible --version): 2.7

Kubespray version (commit) (git rev-parse --short HEAD):
Network plugin used:
Copy of your inventory file:
Command used to invoke ansible:
Output of ansible run:

Anything else do we need to know:

no information provided


testnet network support - fx70g758shqh64 - validator,rpc,api

@LexPrime , Your Moniker and validator addresses are required, please update the PR with those details

@LexPrime , Your Moniker and validator addresses are required, please update the PR with those details

@LexPrime , Your Moniker and validator addresses are required, please update the PR with those details

My moniker - Lex_Prime, validator address - akashvaloper17w3haph6mw4yjs2fe92vjhf5zs3hkluthc0u4n

@LexPrime , Your Moniker and validator addresses are required, please update the PR with those details

My moniker - Lex_Prime, validator address - akashvaloper17w3haph6mw4yjs2fe92vjhf5zs3hkluthc0u4n


controlpanel: add delserver command (closes #810)

This belongs to 1.6 branch, right?

only stabilizing bug fixes belong to 1.x.y. new features belong to master


Encryption?

Does it support Encryption as a feature?

Hi, there isn't support for encryption built in but you can write your own Fetcher or Persister to handle encryption as you wish using something like https://github.com/tozny/java-aes-crypto.

@ramonaharrison hey, thanks for the reply. I'll be closing this ticket for now 👍


php82: init at 8.2.0rc6

PHP 8.2.0 should be released the 8th of December, this PR can either be committed as it is or I can continue to update it until the 8th of December.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[x] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build php82

@GrahamcOfBorg build php82

@GrahamcOfBorg build php82

I fixed xdebug and pdo_oci8 and mark as broken datadog_trace and gnupg

Broken eval :slightly_smiling_face:

Fixed.