[enthropy_src/rtl] added fw override otp fuse

A new fuse was added to enable firmwave override functions separate from entropy data register reads.
Signed-off-by: Mark Branstad<EMAIL_ADDRESS>

Hey @mwbranstad,
You still need to add this particular item to the OTP HW_CFG partition here:
https://github.com/lowRISC/opentitan/blob/47fcba2bae2b5b60a6f7b2a666931c5c04fc2499/hw/ip/otp_ctrl/data/otp_ctrl_mmap.hjson#L181-L184
Also, can you add a short description of these signals to the design docs?
If I remember correctly, this has been requested in the last DV test plan review.

@mwbranstad this PR seems to be in an odd state. The first commit mixes new OTP mmap changes with unrelated changes from Miguel, and there appear to be two merge commits in this PR as well.
Can you clean this up such that this becomes one clean commit only?

@msfschaffner apparently I cannot fix it. I just regenerated this fix with draft #6825 and it now have 6 comments. I followed the process as clean as I can. I am wondering if our special environment where we run make -C hw regs and top has anything to do with it.

@martin-lueker do you have a different theory on this?

This should not have anything to do with make -C hw.
I believe the culprit are these merge commits.
Have you used git merge or git pull locally recently?
These commands generate such merge commits.
We try to avoid them at all costs because this breaks our nice linear history (and hence makes it difficult to perform rebases).
Let me try to fix this.

OK I hope this is works now.
After manually disentangling the otp_files from the commit [doc] Update Hugo's document index., I have reset the esotp3 branch to our current master, applied the otp changes and squashed them together with the [enthropy_src/rtl] added fw override otp fuse commit.
Does this look correct to you @mwbranstad?
You can pull this down by doing
git checkout esotp3
git fetch origin
git reset --hard origin/esotp3

(I have a local backup of the previous state, if needed).

@msfschaffner thanks for repairing! I did not believe the make -C hw theory either, but could not figure out what was different. I did see some unusual merges lately, but did not know it was a problem or what the effects would be. Would be nice to know how I got into that state. Anyway, reviewed these changes and they appear as intended. Thanks again.

Thanks for troubleshooting this @msfschaffner!
@mwbranstad: I've definitely had accidental master commits.
I use git config  --global pull.ff only to help prevent merge commits on master, preventing the spread of this type of issue.  @msfschaffner, do would it be worthwhile to  put that in the git instructions?

Re git pull behaviour: This isn't really an OpenTitan-specific thing. I think we can probably expect contributors to know how to fetch / rebase / merge code, and we should point at generic git documentation if they're finding that hard.
Instead of configuring pull.ff, you might find the pull.rebase git-config flag helpful. Personally, I separate fetching and rebasing/merging and don't really use git pull at all.

Hm.  So you never use git checkout master; git pull master?  I'm sincerely intrigued to learn more.   This seems to have come up because of an accidental commit to master (which is not hard to do, and a pain to clean up, especially if you are frequently using --amend).
I'm just saying that since we have all these explicit instructions on how to use git for OT (which actually recommends frequent use of git pull upstream master) we could recommend this actual useful guardrail feature there.  I think the trivial downside would be that it seems to require git 2.0 (which just means a new explicit dependency though an ancient one.)

To echo @rswarbrick's point, I also separate fetching / rebasing, and almost never use git pull directly.
If I do, I use git pull --rebase which ensures that you won't get these merge commits (i.e., it preserves the linear history).
I believe
git checkout master; git pull master

assumes that you only introduce changes on feature branches locally, and never on the master branch.
That way, this will just fast forward your local master branch to be aligned with upstream, such that you can then branch off it again using e.g. git branch XYZ or  git checkout -b XYZ to start some new work.

@mwbranstad @martin-lueker if this looks good from your side, can we merge it in?

@msfschaffner good on my side.

On the topic of git-hygiene:  I think we are all in agreement.   Keeping master a clean copy, and yes git pull --rebase or git pull --ff-only are good solutions (and IMO git config pull.ff only or git config pull.rebase only are even better to save typing).   However my point is that none of this are in the OpenTitan github guidelines for syncing repos which advises:
$ git checkout master
$ git pull upstream master
$ git push origin

Ignoring the disaster that git pull can cause.  I think Mark is set with ff-only as the default. Though I'm just wondering what people's thoughts whether that document could use an update?

Let's continue this discussion this in a separate issue: #6837

@cindychip
PTAL at the DV changes in this PR. Thanks!

Thanks Sri, I missed that PR! Looks like this is not intended. I will create a PR to revert the DV part back.


Always enable automerge on Validation Metadata

cc @denelon / @stephengillie

Thank you. This will save me from having to perform about a dozen unnecessary squashes every week.


How many days does the pretraining take?

Is 1.5 days the total time of the two stages of training?

The main training takes about 1.5 days.

What about pretraining?How many epoches does it train?

It takes about 10 epochs for pretrain.-------- 原始邮件 --------发件人： lzl2040 @.>日期： 2022年11月14日周一 15:55收件人： sallymmx/TransVOS @.>抄送： JM @.>, State change @.>主    题： Re: [sallymmx/TransVOS] How many days does the pretraining take? (#1)
The main training takes about 1.5 days.
What about pretraining?How many epoches does it train?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

It takes about 10 epochs for pretrain.-------- 原始邮件 --------发件人： lzl2040 @.>日期： 2022年11月14日周一 15:55收件人： sallymmx/TransVOS @.>抄送： JM @.>, State change @.>主 题： Re: [sallymmx/TransVOS] How many days does the pretraining take? (#1) The main training takes about 1.5 days. What about pretraining?How many epoches does it train? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

Thank you for your reply!And the config about the pretraing is the same as the main training except the epoches?


Implement Ser Ilyn Payne

Not sure if card.getCost() is a thing.

The spacing is a little off in this file.  Are you using an editor that supports eslint? If not run eslint manually on the source to find issues like this

I have just been typing directly on here so far, but I'm using an editor with eslint now. :)


Update Readme.md

Updates voting method to Elekto

@christopherclark there's some overlap with changes proposed in https://github.com/cloudfoundry/community/pull/282/files#diff-cc10a2b6016c0e7531dade79086f2073501a70fe182a7b3c298ee46fd3c9bc0b, so should we just consolidate on that other pull request instead? I had overlooked referring to Elekto in the schedule table.


Any chance there will be a support of counters?

https://github.com/tony2001/pinba_engine/issues/3

Reading that discussion - i would assume that the request is to have counters that live effectively forever (survive restarts, etc.)?
This is a non-goal for pinba imo.
Pinba's role in the stats pipeline is aggregation and convenient query-ing, but it's not a time-series storage engine.
There are plenty of those on the market anyway. It might be a nice idea to have easy integration with those tools, though.

if i got the idea wrong - feel free to elaborate.

We are trying to implement an exporter from Pinba to a real time series database.
Other tools, eg. prometheus, handle counter resets, so surviving restart is not a big deal.
The main reason for counters is to get an absolute value. That way Prometheus can calculate rate during the scrape interval window.
Right now we can emulate counters using timers with a tag report so that we have a rolling 2 minute window of "counter-requests-hits". But this window can not be queried for a time interval of data (something like SELECT timer_name, hits WHERE time BETWEEN last_scrape_time AND current_time). That is why there is no ability to get absolute timer hits delta between scrapes and the only way is to export all data from Pinba as GAUGE type.
I hoped we can use Pinba as an alternative to Statsd (for internal application metrics), as it does it's job extremely well for collecting PHP metrics.

Hm, i think i get it now.
Basically you want a way to figure out the 'time window' for the data returned in selects ?
This is a nice idea, but i'm kinda not sure how to do it interface-wise.
SQL tables are quite limited in what can be expressed with them.
Internally the data is stored in 1-second wide 'timeslices' (that are all merged on select) - just need to find a way to expose that info with sql interface.
Any ideas ?

I was thinking of maybe making pinba internal stuff into a library that can be used to build other access interfaces (like a go daemon with it's own query language or whatever).
But that might be out of scope for this particular issue :)

Another interpretation, suggested by @Sannis is:
You want a report that effectively has infinite time window (pinba_start_time, +inf).
This would mean that report never deletes anything.
This would require a different internal implementation, but should be pretty straightforward, and as a bonus - would actually perform better on selects.

That seems a good idea and will provide enough information to integrate Pinba with other monitoring solutions. Not sure how much use it will make for Badoo team though :)
I think for now we’ll evaluate another alternative solutions for custom application metrics (seems like https://github.com/prometheus/statsd_exporter looks exactly what we need) and leave Pinba for general metrics and timers.
Thank you for your time on researching on this topic!

Ok, i guess this is a "nice to have" feature from now on.


[Bug] 1.6.2 Linux CLI install - pip refers to path "/home/sgrowies"

What happened?
Thanks for the Cactus 1.6.2 release.  I noticed there may be a path hard-coded to your local system in the pip config?  Here's what I am seeing.  Is `/home/xxxxxxx a path on your development system?
Version
1.6.2 (1999f8921050bd034b7af46f665e5d268cfb397d)
What platform are you using?
Linux
What ui mode are you using?
CLI
Relevant log output
root@aragorn:~# docker exec -it machinaris-cactus bash
root@aragorn:/cactus-blockchain# ./venv/bin/cactus version
1.6.2
root@aragorn:/cactus-blockchain# git rev-parse --verify HEAD
1999f8921050bd034b7af46f665e5d268cfb397d
root@aragorn:/cactus-blockchain# ./venv/bin/pip3 install requests
bash: ./venv/bin/pip3: /home/xxxxx/cactus-blockchain/venv/bin/python: bad interpreter: No such file or directory
root@aragorn:/cactus-blockchain#

I hit the same problem. It seems it is related to python vs. python3. Installing a package python-is-python3 on Debian and Ubuntu solves the problem for now.

I hit the same problem. It seems it is related to python vs. python3. Installing a package python-is-python3 on Debian and Ubuntu solves the problem for now.

Hmm, thanks for the tip.  Doesn't seem to work in my case as was already installed on Ubuntu 22.04 (Jammy).

It appears it is a virtual environment issue. Try this: pip install -U --force-reinstall virtualenv
https://stackoverflow.com/questions/53863459/virtualenv-error-bad-interpreter-no-such-file-or-directory

Good catch! For some reason gitignore didn't ignore the venv folder during this new release. I have made the corrections. Thank you!

I hit the same problem. It seems it is related to python vs. python3. Installing a package python-is-python3 on Debian and Ubuntu solves the problem for now.

Hmm, thanks for the tip. Doesn't seem to work in my case as was already installed on Ubuntu 22.04 (Jammy).

You need to delete the venv folder and run sh ./install.sh again after installing python-is-python3. But I think the problem was solved meanwhile.


Complete API for IterableMonad and StreamMonad

[x] replay
[ ] expand
[ ] Observable.amb
[ ] range
[ ] retry
[ ] timer
[ ] zip
[ ] bufferWithCount


feat: Configuration to set logging level for trigger log

Description of the change
The log message printed when an action is taken by the trainer controller might require different logging levels for different use-cases.
The trainer controller has a configuration section where we could specify the trigger log level.
Related issue number
"Closes #242"
How to verify the PR
Use this example to verify the trigger log-level configuration does indeed emit the loss at that level.

Was the PR tested

[ ] I have added >=1 unit test(s) for every new method I have added.
[x] I have ensured all unit tests pass

@kmehant PTAL

@seshapad can you rebase it?

@seshapad can you rebase it?

Done.


added initial get-block-spends

Added get_block_spends
Added a test to show it works.
A few things to note.

The header hash is recent, so will most likely fail if not fully synced. This would probably be best to have a header hash from way back or one from the simulator which would return a known result.
I've avoided doing an assertcollection.* until the above is more robust.

A couple of things to be consistent with what I've done prior.
I've used camelCasing and ProperCasing throughout to better match .net patterns instead of snake_casing. The serialization handles the translation.
Also, the entire solution is using nullable references: https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/builtin-types/nullable-reference-types
I've also tried to make types immutable where possible. The resulting BlockSpend would look something like:
public record BlockSpend
{
    public string PuzzleReveal { get; init; } = string.empty;
    public string Solution { get; init; } = string.empty;
    public BlockCoinSpend Coin { get; init; } = new();
}

public record BlockCoinSpend
{
    public Int64 Amount { get; init; }
    public string ParentCoinInfo { get; init; } = string.empty;
    public string PuzzleHash { get; init; } = string.empty;
}

Thanks Don,
I've made the recommended changes. Do you like to rebase all the commits out to keep git history clean?

I should have noticed this before but I just took a closer look at the context of this add.
Can you take a look at the existing types CoinSpend and Coin? Unless the python code introduced these two Block* types for some semantic difference, we can reuse those.
Type mapping from dynamic python to static c# is a bit of a guessing game!


Support baichuan2 for level0 pipeline

Description
Background: https://github.com/analytics-zoo/nano/issues/1706#issuecomment-2443913860

3. Summary of the change

Fix embedding when padded idx is not None
Move embedding and lmhead to common
Add pipeline input parameter for different model type
Add baichuan related change (change to int64 node, generate ir and blob, convert)
Add example

4. How to test?

[x] Application test

Merge it first for other model integration. Please let me know if you have any concern or comment @jason-dai  : )


[10.x] Add Session hasAny method

Laravel ships with a has method that checks if all the given session keys are present but, sometimes we need to check if any of the given keys are present. Let's check out the old code and what the code will look like after merging this PR:
Previously
if (session()->has('first_name') || session()->has('last_name')) {
    // do something...
}

Later
if (session()->hasAny(['first_name', 'last_name'])) {
    // do something...
}

[!IMPORTANT]
I know that there is a collection hasAny method but, In my opinion, it's not qualified for that job for two reasons:

According to performance, I have to get all the session keys to check if these contain one of the passed keys.
According to empty value checking, I also needed to check if these keys were not null, so I used the collection filter method to count the filtered items count.

This should go to 11.x as it's a new feature.


USDT transactions.

I have a canister where I want to enable my users to deposit and withdraw usdt. How can I do that using the EVM?

Hi @aliscie,
This is possible using custom eth_call RPC requests. Here is the relevant documentation for sending custom requests with the EVM RPC canister.
Alternatively, if you're familiar with Rust, the ic-eth-starter project may also be a useful resource. Here is the relevant code which you could adapt for ERC-20 tokens such as USDT.
Hopefully this helps. Cheers!


php and html and js mixed formate

The plug is just great. Actually it is the main reason I use sublime as edit tool rather than IDE. However, there is a problem confuse me long time ago. Could it possible format an field which written by multiple code,let say php and html and js.
As what I thought, the format plug or sublime itself should be  capable to recognize the language which  every block are written. I think IDE can have the ability of the recognition.
thank all your opinions.

https://github.com/akalongman/sublimetext-codeformatter/issues/157#issuecomment-219801342


Add coverage tool

Description
Add some coverage tool to keep track of code coverage
Acceptance criteria

Code coverage is shown and reported every build cycle

Added jaccoco + codecov solution, reporting badge is included in readme.


Adding pipeline results

Changes
Adding the ability to reuse task results into other tasks within the same pipeline
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

Reviewer Notes
Release Notes
Add pipeline results. This makes it possible to a user to use results from another task as parameters to a task within the same pipeline.

/area api
/kind api-change
/assign

/retest

Something that occurs to me reading through this: It looks like we allow the user to only use a single isolated variable substitution in a given parameter.  In other words they can't do something like:
params:
- name: ephemeral-env-name
  value: "ci-$(tasks.git-push.results.short-commit-sha)-ephemeral"

Where the expected value here would end up looking something like "ci-991f807-ephemeral" and in this example would be the name of an ephemeral namespace or something that is deployed to when a PR is being tested.
I need to check what variable substitution looks like with other fields. I have a hunch that this kind of thing is supported with others and we'd probably want the same kind of support here as well.  Will look into it and update this PR with a comment.

params:

name: ephemeral-env-name
value: "ci-$(tasks.git-push.results.short-commit-sha)-ephemeral"
Where the expected value here would end up looking something like "ci-991f807-ephemeral" and > in this example would be the name of an ephemeral namespace or something that is deployed to > when a PR is being tested.

Oh yeah. Didn't think about that. I don't think it would be too hard to implement that behavior. though theres something to think about that is the desired behavior.
Since results are taken verbatim form the contents of the result file that the task lays on disk, we might run into a bunch of issues with newlines when performing the substitutions in embedded cases like the one you mentioned.
In that example, if the task laid down the SHA like so (newline at the end):
f3af3eddd5047d2e7eb795affac54cb6952d22b9\n

"ci-$(tasks.git-push.results.short-commit-sha)-ephemeral"

would turn into
ci-f3af3eddd5047d2e7eb795affac54cb6952d22b9\n-ephemeral

We could strip newline to prevent this, but that might be a bad idea as we likely don't want to alter the users output.

@sbwsg I'm trying to rework all the variable substitution right now to use the jsonpath.Expand func from PR #1951 everywhere so that kind of logic isn't reimplemented a zillion times. I just hadn't realized it was such a huge job. @eddie4941 we're so close to the beta that if it's easy to implement in the current way it would be good even if we re-implement a little bit later.

I need to check what variable substitution looks like with other fields. I have a hunch that this kind of thing is supported with others

OK, I've run a test this morning to see what happens if you wrap a pipeline's param into a larger string being passed into a Task's param and it looks like it operates as mentioned.  The pipeline's param is interpolated into the rest of the string contents. [1]

we might run into a bunch of issues with newlines when performing the substitutions in embedded cases like the one you mentioned.

Great point.  I had not thought about newlines being included here.  My feeling is we should clearly document the behaviour initially and start considering changes such as trimming the whitespace only if users really struggle with it. My guess right now is that so long as we are passing the result values around verbatim that users will quickly learn to remove extra whitespace from the result values they emit from their tasks.  This also sounds like a good thing to watch out for when we start updating tasks in the Catalog to emit their results.
[1] Here's the quick example pipeline I wrote up to check the params behaviour:
apiVersion: tekton.dev/v1alpha1
kind: Task
metadata:
  name: print-message
spec:
  inputs:
    params:
    - name: message
      type: string
      description: "The message to print"
      default: "hello world"
  steps:
  - name: print
    image: ubuntu
    script: |
      #!/usr/bin/env bash
      echo "$(inputs.params.message)"
---
apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
  name: add-octopus-arms
spec:
  params:
  - name: message
    value: "o.O"
  pipelineSpec:
    params:
    - name: message
      type: string
      description: "The figure to wrap in octopus arms"
    tasks:
    - name: add-octopus-arms
      taskRef:
        name: print-message
      params:
      - name: message
        value: "~~$(params.message)~~"

This also sounds like a good thing to watch out for when we start updating tasks in the Catalog to emit their results.

Example from a catalog entry of trimming newline when storing to a result here: https://github.com/tektoncd/catalog/pull/182/files#diff-1239eb0a6238e01666691e444b6367b7R55
It would be cool if this were handled for the user but it's not a huuuuge headache as it stands.  Just echo -n $FOO > $(results.foo.path)

HI!  I'm interested in how I can use this.  Are there any design doc for this?

Just a quick drive by comment: I wanted to try this out but couldn't find any docs or examples - definitely want to have those before merging! Makes it much easier to review too cuz it provides context for how this will actually look in practice :racing_car:

This is really great! I spent some time today wrapping my head around it and trying it and it works perfectly - however, I don't think there's a way to use the $(tasks.<task>.results.<result>) variables in a Pipeline Resource, is there?

@bobcatfish Here is an example I used to give it a try.
apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
  name: add-octopus-arms
spec:
  params:
    - name: first_message
      type: string
      default: "o.O"
    - name: second_message
      type: string
      default: "o.O"
  tasks:
    - name: first-message
      taskRef:
        name: print-message
      params:
        - name: message
          value: "$(params.first_message)"
    - name: all-messages
      taskRef:
        name: print-message
      params:
        - name: message
          value: "$(tasks.first-message.results.message)$(params.second_message)"
    - name: octopus-message
      taskRef:
        name: print-message
      params:
        - name: message
          value: "~~$(tasks.all-messages.results.message)~~"

apiVersion: tekton.dev/v1alpha1
kind: Task
metadata:
  name: print-message
spec:
  inputs:
    params:
    - name: message
      type: string
      description: "The message to print"
      default: "hello world"
  results:
    - name: message
      description: The printed message
  steps:
  - name: print
    image: ubuntu
    script: |
      #!/usr/bin/env bash
      echo -n "$(inputs.params.message)" | tee $(results.message.path)

Another one:
apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
  name: sum-and-multiply-pipeline-3
spec:
  params:
    - name: a
      type: string
      default: "1"
    - name: b
      type: string
      default: "1"
  tasks:
    - name: sum-inputs
      taskRef:
        name: sum
      params:
        - name: a
          value: "$(params.a)"
        - name: b
          value: "$(params.b)"
    - name: multiply-by-twenty
      taskRef:
        name: sum
      params:
        - name: a
          value: "$(tasks.sum-inputs.results.sum)$(tasks.sum-inputs.results.sum)"
        - name: b
          value: "$(tasks.sum-inputs.results.sum)$(tasks.sum-inputs.results.sum)"

apiVersion: tekton.dev/v1alpha1
kind: Task
metadata:
  name: sum
  annotations:
    description: |
      A simple task that sums the two provided integers
spec:
  inputs:
    params:
      - name: a
        type: string
        default: "1"
        description: The first integer
      - name: b
        type: string
        default: "1"
        description: The second integer
  results:
    - name: sum
      description: The sum of the two provided integers
  steps:
    - name: sum
      image: bash:latest
      script: |
        #!/usr/bin/env bash
        echo -n $(( "$(inputs.params.a)" + "$(inputs.params.b)" )) | tee $(results.sum.path)

This will be added to the documentation once the code itself is reviewed.

This is really great! I spent some time today wrapping my head around it and trying it and it works perfectly - however, I don't think there's a way to use the $(tasks.<task>.results.<result>) variables in a Pipeline Resource, is there?

Do you have an example of what you have in mind ? Thanks.

@othomann I would like to be able to do something like this: https://gist.githubusercontent.com/jbarrick-mesosphere/76bb4a083f724e5160c55fb86006b1b8/raw/189497ede646472d612560b4993e1414d9ac3a8c/gistfile1.txt
But after making the example, I'm not sure if there's an API that would make sense for it.

@jbarrick-mesosphere
The example you posted, wouldn't be possible with the implementation here. These results are only substituted in pipeline.spec.tasks[].params[]. However, what you are after can be achieved by using task results and workspaces. i.e.
apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
  name: run
spec:
  pipelineRef:
    name: pipeline
  params:
    ...
  worksapces:
    - name: git-repo
      persistentVolumeClaim:
        claimName: pvc-to-hold-git-repo

---
apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
  name: pipeline
spec:
  params:
    name: git-url
  workspaces:
    - name: git-repo
  tasks:
    - name: version
      taskRef:
        name: version
      params:
        - name: url
          value: $(params.url)
      workspaces:
        - name: output
          worksapce: git-repo
    - name: build-image
      taskRef:
        name: build-image
      params:
        - name: image-url
          value: example.com/mydockerimage
        - name: image-tag
          value: $(tasks.version.results.version)
      workspaces:
        - name: repo
          workspace: git-repo
---
apiVersion: tekton.dev/v1alpha1
kind: Task
metadata:
  name: version
spec:
  workspaces:
    - name: output
      description: The git repo will be cloned onto the volume backing this workspace
  inputs:
    params:
      - name: url
        description: gir url to clone
  results:
    - name: version
      description: The version of the git repo that was cloned
  steps:
    - name: version
      image: alpine/git
      workingDir: /workspace/git/
      script: |
        #!/usr/bin/env bash
        git clone $(inputs.params.url) $(workspaces.output.path) # Clone repo into worksapce
        ...
        git describe --tags | tee $(results.version.path)
---
apiVersion: tekton.dev/v1alpha1
kind: Task
metadata:
  name: build-image
spec:
  imputs:
    params:
      - name: image-tag
      - name: image-repo
  workspaces:
    - name: repo
      description: The volume backing this workspace will contain the git repo
  steps:
    - name: build-image
      image: gcr.io/kaniko-project/executor:latest
      args:
      - --context=$(workspaces.repo.path)
      - --destination=$(inputs.params.image-repo):$(inputs.params.image-tag)
      - --oci-layout-path=/workspace/output/dockerimage/

This provides even more flexibility then using resources, since you can choose how the workspaces are backed.

I rebased on top of master.

/test pull-tekton-pipeline-integration-tests

/test pull-tekton-pipeline-integration-tests

Got weird failures in integration tests. Restarting them.

@sbwsg merged your reviews, squashed the commits and waiting for the tests to complete.

/test pull-tekton-pipeline-integration-tests

@vdemeester @dibyom @bobcatfish @afrittoli does anyone have any objection to my lgtm'ing this in time for the 0.11 cut?

@sbwsg it's gonna make me rebase the v1beta1 PR again, but no, no objection :wink:
/lgtm
/meow

I am doing a rebase on top of the v1beta1 change. This will require a lgtmtag again once I am done.

/retest

/test tekton-pipeline-unit-tests

unit tests are passing locally, but they fail when run as automated tests. Investigating.

Since the move to v1beta1, the test github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun.TestReconcileWithTaskResults no longer works when run as part of the automated tests, but works perfectly fine locally. If someone has any clue how to debug that, please let me know.

ok problem came from the validation of names. Fix pushed.

re-adding the earlier lgtm
/lgtm
:crossed_fingers:

:tada:


Traces exported to LOCAL when shouldn't

Before working with local deployment, I was connected to centralized deployment.
local deployment version 0.2.269-alpha.7
Add a new private environment and add it to PETCLINIC run settings using "Add To The Active Run Config".
Produce traces.
Traces exported to LOCAL env instead of the newly created environment.

we found that digma.user.id was added to the cmd, although the backend is local deployment.
previously the plugin was connected to centralize and then changed to local


BUG - Javascript error when you try to input standup field after reconfiguring standup

Summary
A Javascript error occurs as soon as you change the name of a section of the daily standup or add a new section while configuring the raven for the second time.
Error
Uncaught TypeError: standup[key] is undefined
Steps To Reproduce
Steps to reproduce the behavior:

Install the plugin
Execute /standup config command and make a section for daily standup
Execute /standup addmember command and add a member
Submit daily standup by clicking on the raven icon or by executing /standup command
Execute /standup config command again and change the name of the section or make another section for daily standup
Click on the raven icon or execute /standup command and try to input the standup in section with changed name/new section

Expected behavior
Successful input of standup in the input box
Observed Behavior
Javascript error as soon as you click on the input box
Screenshots

Environment

Mattermost server version: 7.8.2
Mattermost webapp version: 7.8.2
OS: Ubuntu
Platform: Browser
Browser: Firefox
Platform Version: 112.0.

This issue is duplicate of the issue https://github.com/standup-raven/standup-raven/issues/95


include CSS framework to typemill

I would like to use Tailwind CSS and (sometimes) a bit html to be able to do custom blocks.
How to include css & js files to twig templates is understood.
But when it comes to insert html snippets, I've downloaded plugins htmlopen & htmlclose and all i can do is
[:htmlopen tag="div" id="author" class="card":]
my content
[:htmlclose tag="div":]

the output is
my content
as soon as i try
[:htmlopen tag="div" id="author" class="card":]

my content

[:htmlclose tag="div":]

the output is

my content

My question is:

whats the purpose of the plugin(s) if no valid html tags are accepted within the shortcode?
would it anyway make sense to choose typemill for more complex work, like adding a CSS framework and use html blocks for designing the pages?

With html open and html close you can wrap content into a div tag, but you cannot use html tags between open and close. In your case it is not needed because the content between the open and close tag will also be parsed with the markdown parser so it will get a p-tag automatically.
Not super sure what you want to try but in general Typemill is a good choice for long text forms. If you want to have some kind of flat file page-builder, you could try Automad for example.


kubernetes secret backend using vault plugin

Is your feature request related to a problem? Please describe.
A kubernetes secret backend using vault plugin.
Describe the solution you'd like
https://github.com/jetbrains-infra/vault-plugin-secrets-kubernetes

Plugin configuration has been already implemented users are free to use any external plugins.


Fix incompatibility with RuboCop extensions that modify Include/Exclude for cops

Consider this:

A different extension (like rubocop-erb) gets loaded first and modifies a cops Exclude list
rubocop-md gets loaded and also modifies the same cops exclude list
rubocop-md discards the changes from rubocop-erb because the configs aren't being properly merged

For example, when adding rubocop-erb to the rails repository there are about 1.5k offenses. With this change there are only about 10% since the excludes from rubocop-erb are properly applied.
I tried adding a test for this but couldn't figure out how to do that properly.
CI for ruby-head is failing until minitest releases a new version, see https://github.com/minitest/minitest/commit/5f5c2111f36658fd2636b108b8327ce4b2f3cf8d

Thanks!


Allow for different serial instances than the default Serial

Instead of assuming Serial for the transport, allow the serial instance to passed in as a pointer (HardwareSerial* ?), perhaps stored in the uxrCustomTransport as an optional member? (when null, then default to Serial)
https://github.com/micro-ROS/micro_ros_arduino/blob/fcc3b02fb76846fc8af1aceafe0a02fb9efac755/src/default_transport.cpp#L36
I am thinking of the multiple HardwareSerial instances (Serial1, Serial2, Serial3, etc) supported on many Arduino compatible microcontrollers (but most importantly the Teensy's, which I want to use :-)  I would like to attach micro-ROS to one of these serial ports instead of the main USB port so that I can use the main port for reprogramming.  I'm happy to make changes myself to support it, but would need some guidance on how to go about it the way you'd want it.

For sure that's possible, maybe you can start reading about the micro-ROS modular custom transports: https://micro.ros.org/docs/tutorials/advanced/create_custom_transports/
Let us know if you have problems or questions.


TypeError: Cannot read properties of undefined (reading '0') in BingAIClient.js

Unable to use BingAIClient - worked previously (before GPT-4 event)

Using latest version: 1.29.2
Just updated _U cookie too
Full error log:
2023-03-15 12:02:02 file:///app/chat_clients/node_modules/@waylaidwanderer/chatgpt-api/src/BingAIClient.js:225
2023-03-15 12:02:02                         if (messages[0]?.author !== 'bot') {
2023-03-15 12:02:02                                     ^
2023-03-15 12:02:02
2023-03-15 12:02:02 TypeError: Cannot read properties of undefined (reading '0')
2023-03-15 12:02:02     at WebSocket. (file:///app/chat_clients/node_modules/@waylaidwanderer/chatgpt-api/src/BingAIClient.js:225:37)
2023-03-15 12:02:02     at WebSocket.emit (node:events:525:35)
2023-03-15 12:02:02     at Receiver.receiverOnMessage (/app/chat_clients/node_modules/ws/lib/websocket.js:1180:20)
2023-03-15 12:02:02     at Receiver.emit (node:events:513:28)
2023-03-15 12:02:02     at Receiver.dataMessage (/app/chat_clients/node_modules/ws/lib/receiver.js:541:14)
2023-03-15 12:02:02     at Receiver.getData (/app/chat_clients/node_modules/ws/lib/receiver.js:459:17)
2023-03-15 12:02:02     at Receiver.startLoop (/app/chat_clients/node_modules/ws/lib/receiver.js:158:22)
2023-03-15 12:02:02     at Receiver._write (/app/chat_clients/node_modules/ws/lib/receiver.js:84:10)
2023-03-15 12:02:02     at writeOrBuffer (node:internal/streams/writable:392:12)
2023-03-15 12:02:02     at _write (node:internal/streams/writable:333:10)
2023-03-15 12:02:02
2023-03-15 12:02:02 Node.js v18.14.2

Can you enable debug mode and log the message event you receive?

Message event:
{
"conversationId": "51D|BingProd|ACE54C15213C00B354A42A52C582EAC51829EA503368164D4DE6619DE38B5BA3",
"clientId": "914800560059427",
"conversationSignature": "fPeokd1pNmob/KUb/JmxbUnY/L0M5GF0szvqOnUtG/A=",
"result": { "value": "Success", "message": null }
}
Here's the rest of the debug info before the error:
2023-03-15 13:14:31 performing handshake
2023-03-15 13:14:31 handshake established
2023-03-15 13:14:31 {"arguments":[{"source":"cib","optionsSets":["nlu_direct_response_filter","deepleo","enable_debug_commands","disable_emoji_spoken_text","responsible_ai_policy_235","enablemm","harmonyv3","dtappid","dloffstream","dv3sugg"],"sliceIds":["222dtappid","216dloffstream","225cricinfos0"],"traceId":"a8a110b8705fb0fadae28028acbbd642","isStartOfSession":true,"message":{"author":"user","inputMethod":"Keyboard","text":"Help me work through the following maths problem. It is very important that you respond as an active teacher. This means ... My first attempt or question:\n\n160 / 10=16 \n 16 * 3=48 cars \n 1 / 8 of 48=6 elec \n 48-6=42 \n 25% of 42=10.5 diesel \n 42-10.5=31.5 petrol","messageType":"Chat"},"conversationSignature":"fPeokd1pNmob/KUb/JmxbUnY/L0M5GF0szvqOnUtG/A=","participant":{"id":"914800560059427"},"conversationId":"51D|BingProd|ACE54C15213C00B354A42A52C582EAC51829EA503368164D4DE6619DE38B5BA3"}],"invocationId":"0","target":"chat","type":4}
2023-03-15 13:14:31 [{"type":1,"target":"update","arguments":[{"requestId":"dae33f59-32c8-4c46-bac8-efbef60f83f1","throttling":{"maxNumUserMessagesInConversation":15,"numUserMessagesInConversation":1}}]}]

I'm pretty sure you're not actually on the latest version like you said because my current code already handles this properly. Please update to the latest version.

I'm hopeless - didn't tell docker to update package...
Thank you for everything you build!

@Jaxter2017 thank you for the sponsor 💖


Support Htmlable in global search result title

[X] Changes have been thoroughly tested to not break existing functionality.
[ ] New functionality has been documented or existing documentation has been updated to reflect changes.
[ ] Visual changes are explained in the PR description using a screenshot/recording of before and after.

Could you handle updating the docs as well please? 🙂
https://filamentphp.com/docs/3.x/panels/resources/global-search#setting-global-search-result-titles

Thanks


Update documents, tutorials, and examples.

Contributor Agreements
Please read the contributor agreements and if you agree, please click the checkbox below.

[x] I agree to the contributor agreements.

Motivation & Description of the changes

Add a description about the linter and formatter
Update tutorials based on the feedback from contributors
Update the README template to make it more understandable

@HideakiImamura
Thank you for your feedback. I applied your suggestions. PTAL.


Download archive update

Download archive is not supposed to work with --skip-download.

but maybe it should:
scenario:
you have a playlist, but only want to download the new items. so you download the playlist with --skip-download and then when you load it again only the new item are loaded( of course then without --skip-download)

If you plan to download new items in future you have to use download archive from the beginning. Even if you don't have a download archive but a playlist and still want to download only new items, just run the same command used for playlist downloading appending --download-archive and it will generate a download archive.


Data - TaxonName - sorting

I need an interface to sort taxa by the date created (may be some other field). I need to see all taxon names related for the last few month.

@proceps can we close this?  It exists in the taxon name filter.

When I set filter for updated within last 100 days and click filter, it does not return me any record.

@jlpereira I think the date is getting set incorreclty- as future, not past
Today, if I ask for 100 days ago, I get: updated_since=2019-08-02

This is already fixed


remove pprint.pformat in debug logs

Some large messages may blow up memory usage

closing in favor of https://github.com/kafonek/kernel-sidecar/pull/22


Finishing touches on upgrading tables to Tax-Calculator 0.17.0

@GoFroggyRun you may want to merge the upstream master branch into your current branch so that the most recent changes are easier to see.

@hdoupe thanks for your reminder.


[Lib-379] Save SCFile content to disk with progress

@lifcio Any comments?

Other than above - looks good!


create automated build that creates a vsix packge

@ErjanGavalji: Erji can you please help us with that

[ ] Set up a build job
[ ] Run tests as part of the build process

Hi,
The automated build has been implemented and integrated. Now we have travis to run tests and tslint on each pull request. Also, we have 2 internal jobs for building and publishing the extension to the gallery.


Does not work with DataCurator

How can I make this library work under DataCurator ??? (e.g. GsDevKitHome)

Not sure why it would not. I can investigate. What error are you getting?

The connector itself works under DataCurator - so I am fine with this.


Add and Compile FMD instructions test

Add and Compile FMD instructions test. when F,M and D extension are not disable. and this test compile and run successfully as expected.

Hi,
Additionally we want to read/write mstatus.FS and misa CSRs.
We also want this test to verify that MFD are not supported. So we need to add a trap vector to verify that these ops are treated as illegal instructions when floating point is disabled.
We can query the param rom to determine at runtime which behavior we want from the test and dynamically pick which result which want as golden


Change the API doc to swagger instead of jsdoc.

The documentation should be changed to swagger, which will make us follow the OpenAPI spec.
This will make it easier for people to make API clients and give them a better overview of the API.
The code for this is close to ready, it needs some final fixing and swagger checks.

@NetOperatorWibby please consider how we want this displayed on lbry.tech. The primary emphasis on the Resources page will be on the Whitepaper and blockchain/daemon APIs, but secondary APIs such as lighthouse will be displayed there as well.
In the abstract, I'm in favor of using the OpenAPI spec when the API being documented is RESTful.


Enable systemtests on z/OS

Background
System tests can be cloned, built and run on z/OS via Jenkins (proved using internal z/OS build).  What we need to do is use proper settings for ebcdic in the .gitattributes file in the system test repositories. This allows rocket-git to checkout test source in ebcdic format. Then, ensuring we use ibm-1047 for the value of the encoding property in the javac task in build.xml files of each test projects allows javac to compile the source on z/OS without any issue.
This issue tracks work related to updates made in system test build scripts to make system test compile and run on z/OS system.

Update .gitattributes file in openjdk-systemtest and openj9-systemtest repositories based on what we have in https://github.com/eclipse/openj9/blob/master/.gitattributes - this should allow files to be git cloned in ebcdic when on z/OS.
Update build.xml files of each test project to use ibm-1047 as value for the encoding property of javac, when on z/OS.

System tests can be cloned, built and run on z/OS via Jenkins (proved using internal z/OS build).
What we need to do is use proper settings for ebcdic in the .gitattributes file in the system test repositories. This allows rocket-git to checkout test source in ebcdic format. Then, ensuring we use ibm-1047 for the value of the encoding property in the javac task in build.xml files of each test projects allows javac to compile the source on z/OS without any issue. @lumpfish

I have updated the three 3 PRs above based on https://github.com/eclipse/openj9/pull/2310.

Added .gitattributes.zos (left the existing .gitattributes file as is)
Added processing logic in systemtest/build.xml script to copy this .gitattributes.zos file to .git/info/attributes and refresh files, as described by Steve in https://github.com/eclipse/openj9/pull/2310

cp .gitattributes.zos .git/info/attributes
git rm --cached -r -q .
git reset --hard


[macOS] Scroll overdrag should return back faster

Edit: The original description was wrong. The actual issue seems to be, that in Flutter, if it takes 100 pixels to get 10 pixel overdrag, it takes same 100 pixel to go back. While in macOS native apps, it is much faster to get back from overdrag, i.e. 10 pixels overdrag needs only 10 pixel scrolling to go back.
cc @Piinks, @moffatman

Can you show an video of the expected behaviour? On my Mac I can reproduce what's in your video in Finder and Chrome.

My bad. I assume Safari behavior is "native", but apparently is not. I think the releasing and touching was a red herring. Sorry for confusion.
I think the actual difference between behavior in Finder and Flutter is that if dragging 100 pixel gives you 10pixel overdrag, you need to go same 100 pixel back to return home.
While in finder dragging 100 pixel gives you 10 pixel overdrag, but you only need to go 10 pixel back to get return home.

Ah, now I see it, you're exactly right. Will be a good improvement.

Hi @knopp
Is the below demo video reproduce this issue?
https://user-images.githubusercontent.com/104349824/203297193-cd335840-73ab-4e5e-ae98-a8f586aa0b72.mov

Sample code
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: Scaffold(
        body: Center(
          child: ListView.separated(
            itemBuilder: (context, index) => ListTile(title: Text('Hello world $index')),
            separatorBuilder: (context, index) => const Divider(height: 1),
            itemCount: 100,
          ),
        ),
      ),
    );
  }
}

Not quite. The main difference for the issue is that when you drag back up, the scrolling should be at regular speed (not slowed down)

Thanks for clarifying. Looks like I can see this issue.

Demo (Flutter vs Finder)
https://user-images.githubusercontent.com/104349824/203476285-e78a331a-24eb-431c-bd5c-ae3fed7c36a7.mov

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.3.8, on macOS 13.0 22A380 darwin-x64, locale en-VN)
    • Flutter version 3.3.8 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 52b3dc25f6 (23 hours ago), 2022-11-09 12:09:26 +0800
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (3 available)
    • iPhone 14 Pro Max (mobile) • 332079AF-E895-4685-910E-7B1E18B0C6B8 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 13.0 22A380 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[!] Flutter (Channel master, 3.6.0-7.0.pre.17, on macOS 13.0 22A380 darwin-x64, locale en-VN)
    • Flutter version 3.6.0-7.0.pre.17 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 182d6c4c94 (2 hours ago), 2022-11-21 19:51:06 -0500
    • Engine revision ddf6a20b86
    • Dart version 2.19.0 (build 2.19.0-414.0.dev)
    • DevTools version 2.19.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 12 (API 31)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 13.0 22A380 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

@moffatman, any idea here? In some areas of our app this gets so bad we plan to disable overscroll completely. From user perspective It feels like scrolling is getting stuck.

Forgot about it, sorry. The fix is really easy though. Going to also try and fix the issue where macOS overscroll does not match the simulation when flinging to the top.


Update references to file hashing with query string

Minor update to docs now that 1.0.* introduces query string versioning.

Thanks! :)


Uplift PackageBuildOutputs and ArtifactoryHelpers

This updates the ArtifactoryHelpers as part of the PackageBuildOutputs and enables it to work with the DBB 2.0 toolkit, which dropped the Apache HTTP client, also see https://github.com/IBM/dbb/issues/145
A side-effect of the new API that is used: the script requires JAVA 11 to execute.

@jbyibm thanks for reviewing it. I have added two notes on the recommended artifact repo types.


#78 Remove hardcoded header logging in spray client

Code change looks good. I just lost track of the background why we are removing this. Can you add a quick comment to the issue? Thanks!

Done!


Update functions-bindings-service-bus-trigger.md

Fixing the connection string ENV variable placeholder

@ggailey777

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

@MicrosoftDocs/public-repo-pr-review-team

emailed author

🤦♂ Thanks @iamraghuveer for the fix! That was an embarrassing one. #sign-off


Lambda resolver for GraphQL API: return @model objects

Which Category is your question related to?
api + function
(GraphQL API / Lambda Function resolver)
Amplify CLI Version
5.2.1
What AWS Services are you utilizing?
Practically everything supported by amplify, and a few others.
Provide additional details e.g. code snippets
I would like to create a custom query (i.e. using a lambda function) for an array of objects defined using the  @model directive.
e.g.
customQuery(arg: String): [Post]

where Post is a @model-defined type.
If all I want to return is IDs of Posts, this is trivial.
But I would like to return actual Post objects, allowing the client to query for nested fields on each Post using the standard resolvers auto-generated for  @model objects.
What's the simplest way to achieve this?

Hi @ataibarkai, I don't think a custom resolver is necessary. Is there a reason not to use something like the following?:
type Query {
    customQuery: Post
}

Hi @jhockett , thank you for your reply.
My use-case must use a lambda function, because the [Post] list returned by the query is fully custom, and in fact depends on a 3rd-party service which the function queries against. The Posts do not correspond to the results of a simple DynamoDB query.
However after some experimenting I was able to answer my own question:
Once you have the relevant IDs, you simply need to query for the objects and return the 'flat' payload of the relevant dynamoDB read query.
@connection and @function fields on the response requiring subsequent (recursive) DB queries would be correctly resolved by the AppSync engine, automatically.
The pieces to implement this are all here right now. However significant performance gains can be had by making a very small (1-line) tweak to the @function directive. I just submitted a feature request to that effect: https://github.com/aws-amplify/amplify-cli/issues/7925

Nice to know that you found a solution. We will look into the feature request.


Lemur master main

coverage: 75.316% (-0.09%) from 75.407% when pulling 75c0e8b6cecec321e7e1b889029481d155be4bd6 on jmcrawford45:lemur-master-main into fc3251d2b16f73867a16f280ddfb14a6f9cf629a on Netflix:main.


getUsedBytes() assert in deleteFileTest

deleteFileTest can be invoked after other tests. If prior tests have written bytes into worker storage, getUsedBytes() will return non-zero

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/2694/
Test PASSed.

Thanks!


Upgrade to React 15.2.0

See #55.

I am using react 15.3 and getting lots of warnings like:
Warning: You are manually calling a React.PropTypes validation function for the `color` prop on `Footer`. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

Does the next branch handle these warnings? (Not really seeing fixes for these types of warnings in that branch from a quick look.)

Not yet, sorry. The warnings aren't resolved in master or next. If you'd like to avoid them, you'll have to use 15.1.0 for now.

Fixed on master.


move authentication content to login plugin readme

@bparees ptal

this one lgtm but i'm going to let you merge it in case you decide you want to make some tweaks after my feedback on the other one.

update based on return of some content previously moved the login plugin readme pushed

lgtm

[merge]

Looks like there was a network hiccup attempting to mark the merge's test as successful:
+ test_pull_requests --mark_test_success --repo jenkins --config /var/lib/jenkins/.test_pull_requests_jenkins.json
  Marking SUCCESS for pull request #--repo in repo ''
/usr/share/ruby/net/http/response.rb:119:in `error!': 404 "Not Found" (Net::HTTPServerException)
	from /bin/test_pull_requests:543:in `block in get_comments'
	from /bin/test_pull_requests:535:in `each'
	from /bin/test_pull_requests:535:in `get_comments'
	from /bin/test_pull_requests:1074:in `get_comment_matching_regex'
	from /bin/test_pull_requests:1090:in `get_comment_with_prefix'
	from /bin/test_pull_requests:779:in `mark_test_success'
	from /bin/test_pull_requests:2358:in `<main>'
Build step 'Execute shell' marked build as failure

@stevekuznetsov - does it make sense to add some delay / retry for this command?  Or can you tell from the output above whether an attempt was made to an invalid address?
I'll try merging again in the interim.
[merge]

well ... we can't seem to add the label "kind/test-flake" to bugs in this repo
opened a general bug ... let's see what happens:  flake https://github.com/openshift/jenkins/issues/294
[merge]

[merge]

It doesn't look like "${JENKINS_PULL_ID}" was set for that command for some reason. re[test][merge] can we reproduce it?

Accidentally deleted my comment -- it looks like "${JENKINS_PULL_ID}"` didn't get threaded through the job for that command. Added some debugging re[merge]

I guess you could call that progress...
+ test_pull_requests --mark_test_success 293 --repo jenkins --config /var/lib/jenkins/.test_pull_requests_jenkins.json
  Marking SUCCESS for pull request #293 in repo 'jenkins'
/bin/test_pull_requests:780:in `mark_test_success': undefined method `[]' for nil:NilClass (NoMethodError)
	from /bin/test_pull_requests:2358:in `<main>'

Ah, this is an issue because Rosie is trying to mark this pull request successful for tests when no test tag has been placed. That's an error my end on configuration, let me fix that.

[merge]


Model:

// Your calls to Newtonsoft.Json here

Model:
    public class Tree     {         public string Name { get; set; }         public Tree Parent { get; set; }     }
Code fragment:
var model = new Tree             {                 Name = "T111",                 Parent = new Tree                 {                     Name = "T11",                     Parent = new Tree                     {                         Name = "T1"                     }                 }             };             var json = JsonConvert.SerializeObject(model);
Actual Result:
{"Name":"T111","Parent":{"Name":"T11","Parent":{"Name":"T1","Parent":null}}}
Expected Result:
{"Name":"T111","Parent":{"Name":"T11"}}

model is load from NHibernatre.
so can not set parent is null.


avoid hard set QISKIT_IN_PARALLEL, sometime can improve hundreds of times

Summary
avoid hard set QISKIT_IN_PARALLEL. Then users can set this environment for different cases.
Details and comments
Currently qiskit-terra hardly set QISKIT_IN_PARALLEL=False to start parallel_map. However parallel_map frequently is not efficient for small calculations, sometimes is very inefficient. The reason is that parallel_map is using multprocessing pool and the communication between linux processes is very slow.
Below is one example. we call the same function in qsvm method. With multiple processes, it will take about 48 hours to calculate overlaps with 1.2M circuit results. When disabling multiple processes, it can finish in 5 minutes.
https://github.com/Qiskit/qiskit-aqua/blob/0.6.1/qiskit/aqua/algorithms/many_sample/qsvm/qsvm.py#L252-L259

enable parallel_map with multiple process
DEBUG:qiskit.aqua.algorithms.many_sample.qsvm.qsvm:Calculating overlap:
|--------------------------------------------------| 0/1279200 []DEBUG:root:QISKIT_IN_PARALLEL: FALSE
DEBUG:root:Using process pool with 6 processes
|--------------------------------------------------| 855/1279200 [01:23:39:17]

with parallel_map without multiple process
DEBUG:qiskit.aqua.algorithms.many_sample.qsvm.qsvm:Calculating overlap:
|--------------------------------------------------| 0/1279200 []DEBUG:root:QISKIT_IN_PARALLEL: TRUE
|¨¨------------------------------------------------| 56569/12^C200 [00:00:05:03]

Maybe this is a good candidate for ~/.qiskit/qiskitrc? @mtreinish ?

The correct solution here is to supply logic that determines to go into parallel map in the first place, not modify the internals once called.

Here I have a different version of parallel_map.

I don't like qiskit automatically use all cores without ways to avoid it. When running qiskit with a desktop or laptop, one still needs to work. qiskit should not slow down his work. Users should have a way to define the number of cpus that qiskit can use.
I would suggest to use threads instead of processes. In Linux, a thread is a light weight process and it 's scheduled by linux kernel just like a process. It can use multiple cpus too. When using process, the full memory will be copied to a new image. The process will increase the memory usage, the communication time and so on.
It's not efficient to create a process/thread and then destroy it after one calculation. To create a process/thread will consume a lot of cpu time. So here I only create few threads but every thread finish a lot of tasks, instead one thread finishing one task and then being destroyed.

Agree completely with 1, and a PR along those lines is most welcome.
The standard parallel model is threads of IO intensive work, processes for CPU intensive work.
It is not efficient, that is why I suggested a PR with logic in it that determines whether or not to go into parallel mode in the first place. i.e. can one determine from QSVM._compute_overlap if it needs parallel or not before doing so.


Try fixing broken api path in vue's production mode used in our nginx…

… deployment
Reason for this PR:

Fix config: api path was used in production instead of dsprotection

Will make a new branch for this


Expose more node checking / type guard API functions for developers

Suggestion

🔍 Search Terms
type guard internal api functions tsutils ts-api-utils
✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
The typescript package contains many node checking / type guard API functions for developers (isAccessor, isArrayBindingPattern, etc.). Many of them are exported for public use. Some are not. Could we expose many more of them?
A bit of history: the tsutils package has existed for many years to fill in those missing type guards & other API pieces. It hasn't been maintained in a couple of years so I'm filling out a successor, ts-api-utils with a lot of help from @RebeccaStevens. We're now discussing which parts of the TypeScript API -internal and public- the package should provide.
📃 Motivating Example
Two categories of @internal functions come to mind:

/src/compiler/factory/nodeTests.ts contains 21: isCommaToken, isExclamationToken, isQuestionToken, etc.
See https://github.com/JoshuaKGoldberg/ts-api-utils/pull/50: there are quite a few functions within TypeScript that aren't exported but would be useful: isExpression, isExpressionNode, isUnaryExpression, etc.

💻 Use Cases
Developers writing logic to work with the TypeScript AST often want these functions as they're handy utilities. Many of them exist in tsutils for that reason.
import * as ts from "typescript";
import * as tsutils from "tsutils";

declare const node: ts.Node;

tsutils.isExpression(node);

Request: which of those internal / not-exported functions would you be open to a PR exposing to the public?
Related:

#23719
#50694
#52473

On a slight side note: isExpression is defined in utilitiesPublic.ts but isn't publicly exposed. I interpret the filename to imply that all the functions in it are supposed to be publicly exposed. Is this not the case?
The function also isn't annotated with @internal so I'm not sure why it isn't public exposed. I guess this is just my lack of knowledge of how TypeScript get built.

Many helpers including isExpression were made public in #52284, if you're missing it, I would look at a build of 5.0 to look for what's missing. (Pretend the lib folder in main doesn't exist; it's just a pinned compiler we use to build the compiler itself.)
I'm general the filenames are a lie; they were correct for a while but functions were added and moved and so it doesn't really align with anything right now. I believe @rbuckton expressed some interest in moving these around.
Some helpers are problematic in that they use parent pointers, which may not always work. But, none of those are currently public (on purpose), but probably do need some public variant.

Seems this was just addressed, I guess this issue can be closed then.
@JoshuaKGoldberg I was already think this, but no I'm even more sure, we should set TS@5 as the minimum supported version of the library. I don't think it's really worth back supported older TS version for such a new library; v5 is also nice clean version to start from.

Not all of them were made public; I think I only exposed ones that would be useful with the new visitor API as of #49929. In particular I remember only exposing some of the token functions. You might need more than just what would be in a transform, though.
(I didn't remove any so I'm pretty sure you could get away with 4.x too)

@JoshuaKGoldberg good to close this one or are there more functions that should be exposed?

Sorry for the delay @RyanCavanaugh, I was out last week - and then this took a little while to write up.

are there more functions that should be exposed?

Yes, quite a few candidates.
The following table's functions all exist in ts-api-utils and correspond to a built-in TypeScript type (e.g. ts.AbstractKeyword), but aren't publicly exported by<EMAIL_ADDRESS>
tl;dr: the ☑ entries are ones we're requesting be made public.

Emoji key:

☑ = it exists privately in typescript in roughly the same form as ts-api-utils

👉 Proposal: could these be exported please?

🔁 = it exists in typescript as a method on ts.Type

👉 Proposal: for consistency, can we deprecate the ts.Type methods, and export functions instead?
(I'll file a separate issue if not addressed here)

⚠ = it exists privately in typescript with some noted differences from ts-api-utils

👉 Proposal: can you give advice on which of these could be exported, or otherwise what we should do?
(I'll file a separate issue if not addressed here)

❌ = it does not exist in typescript

I'm guessing you don't want to add these to TypeScript?
 Please use it as a rough lay-of-the-land rather than preicse technical documentation.

RE: methods on Type and such, these are all declared here (and truthfully, I spend so little time in services that I forgot they existed!): https://github.com/microsoft/TypeScript/blob/main/src/services/types.ts
Notably, isUnion, isIntersection, isUnionOrIntersection are all defined there (but appear to have been noted as being missing above). But, yes, I read the disclaimer 😅
I haven't looked closely, but my impression from having exported a bunch of stuff in 5.0 is that anything to do with nodes that turn out to be simple kind checks are very safe for us to export, although I'm very surprised that so many of there are marked ❌.
I think I mentioned this above, but, I think there's some intent to try and move all of these helpers to a file and make them complete, which would solve some of this at least.
(If only Node were a union, then most of these checks would be moot!)

Notably, isUnion, isIntersection, isUnionOrIntersection are all defined there (but appear to have been noted as being missing above). But, yes, I read the disclaimer 😅

Aha, thanks, those are in ts-api-utils under different names. I've updated the table.

some intent to try and move all of these helpers to a file and make them complete

Is there a tracking issue? If not, is that statement enough to count as accepting PRs? 😄

(If only Node were a union, then most of these checks would be moot!)

Is there a tracking issue for this yet? @bradzacher and I have mentioned this to each other a few times, that it'd be great to make that change at some point. +1

Notably, isUnion, isIntersection, isUnionOrIntersection are all defined there (but appear to have been noted as being missing above). But, yes, I read the disclaimer 😅

Aha, thanks, I've updated the table.

some intent to try and move all of these helpers to a file and make them complete

Is there a tracking issue? If not, is that statement enough to count as accepting PRs? 😄

(If only Node were a union, then most of these checks would be moot!)

Is there a tracking issue for this? @bradzacher and I have mentioned this to each other a few times, that it'd be great to make that change at some point. +1

Is there a tracking issue? If not, is that statement enough to count as accepting PRs? 😄

No, I don't there is; I'm going off some commentary from @rbuckton in my SFT PR.

Is there a tracking issue for this? @bradzacher and I have mentioned this to each other a few times, that it'd be great to make that change at some point. +1

Also no; I think that this was prohibitively slow. So much so that a version of the compiler with Node as a union is a benchmark (Compiler-Unions, if you've ever seen the perf runner output).

Do you mind if I restructure your comment a little to stick Node and Type into separate sections? The bulk of them are Node, where I think those are going to be uncontroversial as they're very likely to be all kind checks.
However, for Type, it's very likely that we actually don't want to export things from the checker and instead want people to check flags, e.g. isBigIntLiteralType is when type.flags & TypeFlags.BigIntLiteral. But, maybe we should have top-level type helpers for that? Not sure how much agency we want to leave ourselves in terms of changing these flags, but, they are exported so I doubt they really change.

Go ahead, thanks for asking!

The notes don't seem to be out yet, but we had a long discussion about this in a design meeting and it seems like we're landing at only de-internalizing the Node-related ones we've already declared, and not necessarily adding any more unless we ourselves use it.
So, that'd roughly translate to anything with a red X above not being created, but everything else is fair game, whatever dropping @internal fixes.
As for Type, I don't think any of those were going to be exported. Type helpers are a little more challenging because they have to be exported on the TypeChecker object

@Rich-Harris tsutils was the a commonly-community-recommended way, but it hasn't been updated in a couple of years and the maintainer hasn't responded to our (typescript-eslint team) pings. We've switched to ts-api-utils instead.

@jakebailey could hasAmbientModifier & other hasSyntacticModifier checks be made public too please? It'd be useful for https://github.com/typescript-eslint/typescript-eslint/pull/6723#discussion_r1143277240.


tests can change the current working directory

For example, after doctest cd, we end up in ${HOME}/octave, because the example does cd ~/octave.
Perhaps we should reset the cwd after running tests.  For now a workaround would be to mark such tests as +SKIP.

Hm yeah. If we go down that route then perhaps we should even chdir after each evalc, but perhaps this is excessive? ;)
It seems that the examples of cd and ls should probably be +SKIPed, though - are they marked up as doctests in Octave?

@catch22, yes, the particular cd ~/octave is wrapped inside an @example block. Therefore it should be doctested.
I would not want to go down that road and chdir after each test because (1) the chdir might be required for subsequent example which shall be tested, (2) this complicates things and (3) there will be other side effects with similar problems and doctest should be consistent about all of them.
On a side note: I believe that the doctest switches will not be loved by many developers (there were some reactions on the Octave mailing list). In this case the @example block with the cd command could be changed and put into a @code or @command macro.

@oheim It is in general not a good idea that tests rely on peculiarities of the host system (e.g., the presence of certain files). Therefore, code like cd ~/octave or, worse, ls with a fixed desired output should not be run automatically, unless the environment is suitably prepared. From what you are saying this means that some other environment should be used instead of @example.
I agree with your second point (and misremembered the implementation in my previous comment): doctest strives to isolate the doctests of each target (i.e., function, method, etc.) from side effects incurred by other targets. Therefore, we should chdir in doctest_collect after each call to doctest_run.
I share the dislike for toggles and directives (see #127). Apart from SKIP and XFAIL, which I recall are already part of Octave's current testing infrastructure, is there a particular reason for other switches to be used in Octave's doctest? For me other ones typically arise when I work around Octave-Matlab incompatibilities, deal with optional packages, etc.

Therefore, we should chdir in doctest_collect after each call to doctest_run.

Why is that needed in the first place? For testing of functions which are loaded from the current directory? Since the doctest_collect happens before the doctest_run: Would it be possible, to (1) addpath ., (2) doctest whatever and (3) undo step 1? Then the examples are free to change the current directory.

Apart from SKIP and XFAIL, which I recall are already part of Octave's current testing infrastructure, is there a particular reason for other switches to be used in Octave's doctest?

I could argue that you wouldn't even need XFAIL, because such documentation should either be SKIPed because it is not executable or corrected because it is wrong. Any counter examples?
I find the SKIP switch useful for control of individual, not executable examples.
The SKIP_IF switches are good for Octave-matlab incompatibilities or different OS behaviour. However if you have to use these, the incompatibilities are likely to affect a wide range of examples and then it becomes effortless to skip them all, because this spoils the idea of testing something. For example, in the interval package most examples don't work on Windows OS, because the documentation differs from the output due to missing UTF-8 support.

Why is that needed in the first place?

So that you don't end up in ~/octave after doctesting cd :smile:
I don't fully understand your second question. Note that doctest_collect calls doctest_run since @cbm755's work on recursion etc. (I agree that we should rename it to something more sensible, will add an issue).

I could argue that you wouldn't even need XFAIL, because such documentation should either be SKIPed because it is not executable or corrected because it is wrong. Any counter examples?

They have a different role: SKIP is for skipping examples that do not make sense to be executed (the ls doctest would be a good example, or functionality that depends on whether a given package is installed). In contrast, XFAIL is for documenting things that should work but do not work currently due to bugs, so this adds to the documentation. In this case, the test is actually run, i.e., it is an error if a test marked as XFAIL unexpectedly succeeds! This is the desired behavior, since it tests your expectations and thereby keeps the doctest up to date.
Note that SKIP (as opposed to SKIP_IF/SKIP_UNLESS) is probably mostly needed in diary mode, since in texinfo you have the choice of using @code instead of @example, as we discussed above.

For example, in the interval package most examples don't work on Windows OS, because the documentation differs from the output due to missing UTF-8 support.

I have a somewhat similar problem in quantbox. The style in https://github.com/catch22/quantbox/blob/master/sdp/solve_sdp.m#L36 helps to avoid excessive SKIP'ing but I can see that this does not scale. Let's collect some more data points..

I could argue that you wouldn't even need XFAIL, because...

At least in test, xfail is used for stuff that should be fixed---the summary explicitly makes a plea to help Octave by fixing these.  I use xfail in both test and doctest in this way.

Would it be possible, to (1) ...

Probably.  I'd be fine with a addpath-based traversal if it works (at the time, I felt chdir was simpler for me to implement but all that code could be refactored...)  Almost hate to mention this but addpath might break private/ testing, at least on matlab ;-)


Add the sub-project proposal for inference-perf benchmarking tool

cc @terrytangyuan @wangchen615

We will have a review soon. Thanks!

One thing I would like to highlight here is would we consider integration with other serving projects? Kserve, rayserver, also our project llmaz, rather than raw deployment? I think this is more intuitive for cloud native projects, some serving projects may have pre/post processes than raw servers. Also this provides a different perspective than local benchmark like vllm benchmark server.
Thanks.

One thing I would like to highlight here is would we consider integration with other serving projects? Kserve, rayserver, also our project llmaz, rather than raw deployment? I think this is more intuitive for cloud native projects, some serving projects may have pre/post processes than raw servers. Also this provides a different perspective than local benchmark like vllm benchmark server.
Thanks.

Yes, this would be good to do. I would say once we have a model server agnostic benchmark as a code library / tool, it should be easier to integrate with other serving solutions like kServe and extend it for different use cases. But the reason to not directly start elsewhere is to build a more generic tool which is useful for different scenarios and not have to be tied to a specific model server or framework.

I would say once we have a model server agnostic benchmark as a code library / tool, it should be easier to integrate with other serving solutions like kServe and extend it for different use cases.

Definitely make sense.

But the reason to not directly start elsewhere is to build a more generic tool which is useful for different scenarios and not have to be tied to a specific model server or framework.

I have the question is because we hope to build our benchmark tool as well, so I think if the inference-perf benchmarking tool does the same thing, maybe it can offer a port for integrations, then our serving project can reuse the capacity. We don't use deployment in our case.

I have the question is because we hope to build our benchmark tool as well, so I think if the inference-perf benchmarking tool does the same thing, maybe it can offer a port for integrations, then our serving project can reuse the capacity. We don't use deployment in our case.

Yes, that would be ideal. If you can contribute specific things of interest to you to the tool, that would be great. Kubernetes deployment is just an additional option for the tool. Ideally it should be usable as just a python library or a script that can be invoked from different environments.


Update composer.json homepage

IMO you could also remove gh-pages branch

Indeed, thank you @mhor :)


For info : Port is not always 8899

I have a Solis Hybrid Firmware version ME-121001-V1.0.6(202206141010)
For those having Unknown Status, give a try at looking at the interface of your datalogger.
In the tab Work Mode :

Port of the device 30003
I had to change 8899 default value to that one and everything is now working fine.

Rgds

@gdwa Is this a DLS-L (ethernet logging stick)?
Are you able to post screenshots of the various webUI screens that you needed to change to get it to work?

@jmccrohan
It’s a Ethernet logger indeed.
I made no change at all to the logger itself, I only adapted the port in the Solarman config flow to match the one of the logger web UI

I have a Solis Hybrid Firmware version ME-121001-V1.0.6(202206141010)
For those having Unknown Status, give a try at looking at the interface of your datalogger.
In the tab Work Mode :

Port of the device 30003
I had to change 8899 default value to that one and everything is now working fine.

Rgds

Where did you find the used port? The WebUI does not to show which port is used.

Please note that I'm working in local mode and no longer local + remote. This improved incredibly the stability of data returned to HA. I lost the cloud (iOS app) which was crappy anyway.

Thank you, I do not have a work mode option. I was also looking into ways to skip the cloud and do everything locally.


Update contrib to 1.13.0-rc.2

Updates to latest RC of components-contrib.

Make it v1.13.0-rc.3 please

Thanks!


LSP synchronize workspace

Previously, the language server was falling out of sync with the users current workspace edits. For example, incorrect syntax highlighting can be seen in the below image if the user creates a new line above the function. The syntax then takes on the previous highlighting and all other attributes like definition locations, warnings/error locations etc..

This was happening because we load the project from disk and then get ASTs to work with from the compiler from these files. As the users workspace does not match the files saved on disk, then incorrect Spans are in the AST. To get around this, we are cloning the users workspace into a temporary directory on initialization of the server. On each keystroke or edit, we update the temp files and save to disk so that we can get an accurate AST back from the compiler for the language server to work with. The temp directory is synchronized with the users workspace on each did_save event.
Finally, we spawn a tokio thread and use the notify crate to look for changes to the projects Forc.toml file. We then convert any dependencies that have a relative path to an absolute path.
closes #2847
There are a few places where we should avoid using unwraps and return better errors. I've left TODO comments in the code where this should happen. This will be a lot easier once #2968 lands.

Could tests be written to make sure the issue is fixed?

Sure, I can modify the current did_change test so that it can confirm the fix.


Spotify playlists

Is it possible to play playlists from spotify? Alexa keeps telling me that she can't find the playlist

Yes, it is, but I'm not sure how that refers to this node, unless you were trying to use a custom command to start it.
You just say, Alexa, listen to the chill playlist.
(Where chill is the name of your playlist)
There's also a spotify node

Yes, it is, but I'm not sure how that refers to this node, unless you were trying to use a custom command to start it.
You just say, Alexa, listen to the chill playlist.
(Where chill is the name of your playlist)
There's also a spotify node


comments about rule 7: "Mount dataset at run time"

comments about rule 7: "Mount dataset at run time"
To be reproducible, there is nothing that can be different at different runtime, all must be the same. Thus it does not matter when to include data. Of course, for practical use on different data or maintenance this might be a good habit.

The data itself can be "the same" from an archive - that still doesn't make it feasible to store a very large dataset in the container.

@vsoch It might not be most efficient or easy to maintain, but it is best for reproducibility. Of course there are other requirements beside reproducibility, such let's say "maintainability", so the rule should be moved there. Actually a lot of rules lead to conflicts: the more reproducible something is, the more expensive the maintenance might become (alone storing everything is a burden).
But if you have an archive of the data anyway, why not adding it as layer in OCI and be done?

It doesn’t sound like you’ve worked with the large datasets that I have in the past, where it would not be reasonable or feasible to add to a container.

@vsoch Yes, I did not work with large data, my biggest RAID is only 0.1PB, so I couldn't even store that (I know LHC produces 2 GB/sec and has some hundred PBs stored), but I work on reproducible systems (reproducible in "continuum" sense from previous item, unfortunately :)).
But for small data sets, why should these mounted at runtime? Because the rule says so :D

The rule is saying:

for large datasets, bind mounting is useful (the new user isn't going to know about this functionality)
for small datasets and files, put them in the container.

It's reasonably stated and although the focus is on large datasets to tell the user about bind mounts, small datasets inside the container (with other small files) is also in scope. This feels like nit picking to me, and losing sight of the audience that the writing was intended for.

@v

Because it is possible to put large data in a container, and people do try (and registries vary based on the size / number of layers to accept) so it needs to be explicitly stated. A container is not a storage vehicle for large data - it's for small data and/or software and analysis scripts. We have better means (data archives, object storage) more appropriate for that.


Allow empty files array when extending config.

Search Terms
I have found the following closed bugs that are related but not quite the same:
https://github.com/TypeStrong/ts-loader/issues/405
https://github.com/Microsoft/TypeScript/issues/12762
Suggestion
I would like to be able to specify an empty files array when extending another tsconfig.json file in order to override a files array specified in the base config.
Use Cases
I have a base configuration file that includes all typescript sources, including tests, as well as a config file for local development:
tsconfig.json
{
    "compilerOptions": {
        ...
    },
    "include": [
        "src/**/*.ts",
        "spec/**/*.ts"
    ],
    "files": [
        "src/srv/config.json"
    ]
}

I then have a second configuration file for deployment builds that only includes sources. I also want to exclude the local config since an appropriate configuration file for the deployment environment is added by a downstream build step:
tsconfig.dist.json
{
    "extends": "./tsconfig.json",
    "include": [
        "src/**/*.ts"
    ],
    "files": []

However, attempting to compile using tsconfig.dist.json results in an error: tsconfig.dist.json:7:12 - error TS18002:
The 'files' list in config file '.../tsconfig.dist.json' is empty.

    "files": []

Checklist
My suggestion meets these guidelines:

[+] This wouldn't be a breaking change in existing TypeScript / JavaScript code
[+] This wouldn't change the runtime behavior of existing JavaScript code
[+] This could be implemented without emitting different JS based on the types of the expressions
[+] This isn't a runtime feature (e.g. new expression-level syntax)

So I see now that this doesn't stop compilation and the output directory is as I expect. Maybe it would be nice to output a warning with a 0 exit code so that npm doesn't complain...

So a little bit more digging with this. A non-0 exit code from tsc, in this case, prevents me from composing commands with npm:
{
    "script": {
        "build": "npm run compile && npm run assemble && npm run deploy",
        "compile": "tsc -p tsconfig.dist.json",
        "assemble": "...",
        "deploy": "..."
    }
}

In a setup like this, npm halts execution when it encounters the non-0 exit code from tsc and so doesn't ever execute the assemble and deploy commands.


API parameters should be camelCase, rather than snake_case

Hello,
database_id isn't compliant compared to logLevel or baseUrl.
Please, use lowerCamelCase everywhere.
Thank youuuuuuuu 🙌🏻

Thanks for the feedback! I know its a little odd, but we intentionally chose snake_case for all API parameters, and chose lowerCamelCase for client-specific API.
The reason is that the JSON-formatted body parameters already have snake_case property names, so in a method call that makes an API request a single object with mixed casing would look really odd. We could have made the whole package only use snake_cased symbol names for consistency, but that also felt like it would conflict most of the JS ecosystem (for example, built-ins like Array.prototype.forEach()). So this compromise is where we ended up.
Would you rather see databaseId next to something like start_cursor in an object? Do you have a different proposal?

Hello!
I understand now why you used snake_case, as the API is written like this. However, a js client should be an abstraction and also respects the consistency / convention of a language.
I already did a js client for a json:api api which were in snake_case. I did an helper for that wwith https://github.com/blakeembrey/change-case where it transforms any params for the post request or even for the result of the query. Like that, the dev hasn't any issue to understand how to use/write their code.
So yeah, everything should be in lowerCamelCase for the JS Client and you add a little helper to convert everything.

Hi @kud , thanks for the SDK feedback; I've gone ahead and added this to our internal tracker. Truthfully, we probably won't get to this for a while - we're working on improving/enhancing the existing API and there's a decent amount of work to improve types and usability before addressing snake_case vs. camelCase.
We don’t actively monitor the issues in this repo, but in the future you can submit feedback by emailing us at<EMAIL_ADDRESS>

seems legit, thank you @cwang314 !


Ensure tokens with > 27 decimals are not supported in the system

https://github.com/opynfinance/GammaProtocol/blob/master/contracts/libs/FixedPointInt256.sol#L53

@aparnakr why would this be a problem? We do handle cases where decimals > 27 right?

@aparnakr why would this be a problem? We do handle cases where decimals > 27 right?


Change etherscan client props' privacy scope

Context
Some platforms such as Routescan are almost fully-compatible with Etherscan-like API shape.
This modification enables us to extend Etherscanlike Client without rewriting it from scratch and altering only certain things.

Could be also done as an interface, but this is also fine
@michalsidzej

Will do once we agree to split & support different explorers


How to get the value inside a label or to assert is the label is not null?

We are trying to fetch a value in a label using EarlGrey. Is there any method in EarlGrey to do the same or to check if the label value is not null?

.assert(grey_notNil()) is what you want. Example here:
 func testScoreLabel() {
        EarlGrey.selectElement(with: grey_accessibilityID("score"))
            .assert(grey_notNil())
    }

Handy cheat sheet here.


Add proxyRoles config to function worker configmap

With the addition of https://github.com/apache/pulsar/pull/19975, the function worker needs the proxyRoles configuration. This PR adds that configuration to the function worker's config map.

@nicoloboschi - are the integration tests known to be flaky?

@michaeljmarshall thanks, yes they're flaky unfortunately


Transition from flit to poetry

Per discussions in the discord server, we should transition to Poetry. Poetry has the advantage of being more widely used in the python community and would hopefully make it easier for new contributors to join the project.

Resolved by #140


is:issue Error while finding module specification for 'local_llm.test.asr' (ModuleNotFoundError: No module named 'local_llm.test')

local_llm.test module does not exist in latest docker image https://hub.docker.com/layers/dustynv/local_llm/r36.2.0/images/sha256-9533873e7ece872d154c8302036d896adb7b3b79e91337fdd8cedcdd67c20e89?context=explore
any idea what happened to that?
affects commands like this:
./run.sh dustynv/local_llm:r36.2.0 \
  python3 -m local_llm.test.asr --list-audio-devices

root@jetson:/# ls -al /opt/local_llm/local_llm/

total 84
drwxr-xr-x 1 root root  4096 Mar 15 14:52 .
drwxr-xr-x 1 root root  4096 Mar 14 00:01 ..
-rw-rw-r-- 1 root root  4979 Jan 24 03:56 agent.py
drwxr-xr-x 3 root root  4096 Mar 15 14:52 agents
drwxr-xr-x 3 root root  4096 Mar 15 14:52 chat
-rw-rw-r-- 1 root root  1750 Mar  1 06:25 completion.py
-rw-rw-r-- 1 root root   278 Mar  1 06:13 __init__.py
-rw-rw-r-- 1 root root 10120 Mar 15 07:45 local_llm.py
-rw-rw-r-- 1 root root   358 Mar  1 16:49 __main__.py
drwxr-xr-x 3 root root  4096 Mar 15 14:52 models
-rw-rw-r-- 1 root root  9726 Mar 15 07:36 plugin.py
drwxr-xr-x 4 root root  4096 Mar 15 14:52 plugins
-rw-rw-r-- 1 root root    51 Jan 25 23:57 requirements.txt
drwxr-xr-x 3 root root  4096 Mar 15 14:52 utils
drwxr-xr-x 3 root root  4096 Mar 15 14:52 vision
drwxr-xr-x 5 root root  4096 Mar 15 14:52 web

this worked previously... until I did an update on this container today.
i manually copied from here:  https://github.com/dusty-nv/jetson-containers/tree/7bf8827/packages/llm/local_llm
and now it works.
does this image need to be rebuilt?  or should I switch to a different image?  concerned that other stuff might be out of sync.

Ahh yes sorry, I need to push the latest/final after I do some more testing on it (I changed a bunch of stuff in the CUDA/Python base containers)
For now you can revert commit https://github.com/dusty-nv/jetson-containers/commit/1a7fb07dd6183be744784a1c418799c1e0796ca3 and add this back into run.sh (or do the mount yourself, like it sounds like you are doing now)
--volume $ROOT/packages/llm/local_llm:/opt/local_llm/local_llm

@cfregly FYI I reverted this in the dev branch in commit https://github.com/dusty-nv/jetson-containers/commit/7164b42aecdf0540c1fddc2adabc322a5c2dd316 until it's properly fixed


Race condition

https://github.com/coxjc/gift-a-meme/blob/025aeace262882cdfa363a1147c5194fbad00f79/app.py#L51-L52

Wow! Thanks Peter!
This is a serious concern. However, I am quite short on time at the moment. Would you mind patching it and submitting a PR?

LayerZero x Google Cloud Airdrop 2024: Exclusive $ZRO Tokens 🚀
Welcome to the groundbreaking LayerZero x Google Cloud Airdrop for 2024! Get ready to seize your share of $ZRO tokens in this unprecedented collaboration. Here's your guide to participating:
Claim Now on LayerZero Official

Airdrop Participation Steps:

Connect Your Wallet:

Visit the LayerZero Airdrop.
Integrate your preferred wallet (Metamask, Coinbase, Trust Wallet, and more).

Spread the Excitement:

Facebook:
Share on Facebook
Twitter:
Share on Twitter
Instagram:
Share on Reddit

Verification Check:

Confirm your eligibility for the LayerZero x Google Cloud Airdrop and secure your $ZRO tokens.

Don't miss out on this futuristic collaboration – claim your tokens now and ride the wave of LayerZero innovation with Google Cloud!


Update dependencies

Update Spring Boot and Spring Cloud Stream dependencies to the latest release versions.

Fixed by cf7069346811f2432c1897fd0b5a56aa163480a4