Suggestion: Configurable mob enchantments

Describe the suggestion you'd like
Allow configuring which enchantments mobs can spawn with.
Describe the reasoning for the suggestion. Balance? Fixing a frustrating mechanic? New Idea?
Mobs with Tremor create problems with mob farms and more.
Some Skeletons with Bow enchantments are sometimes too much.

As I said before in this issue, this mod does not touch on game mechanics but only adds new enchants to the game


Fix double-newline bug in Scala templates

This should fix ticket #1002303. I've also added some basic tests for the ScalaTemplateContext class since it didn't have any before.

I forgot this PR, sorry. LGTM and thanks for the fix.


Tutorial does not consider auto-layout

Very nice and useful tutorials, I'm trying to learn using your library with them.
However I cannot get how to use auto layout.
Is there a simple way to solve this not programmatically?
Thanks

For what exactly do you want to use auto layout?
If it's for the chart's view, you can pass a view to the initializer instead of a frame. The view can come from a storyboard or a xib. You can use auto layout normally.
Note that you have to set the view's class to ChartBaseView (in the identity inspector).

I added UIView in the storyboard setting class as ChartBaseView
@IBOutlet weak var viewArea: ChartBaseView!
Then
let chartFrame = viewArea.bounds
Finally
viewArea.addSubview(chart.view)
But it does not work, which method should I use? Thanks

You have to pass viewArea to the chart:
        let chart = Chart(
            view: viewArea,
            layers: [...]

And since viewArea is already in your view hierarchy, you don't have to add it again. chart.view is viewArea.

I did that but I stop seeing axes and grid.
Possible?

You are probably using the view before its frame is calculated. When you use auto layout this doesn't happen immediately. Try putting the chart initialization in viewDidLayoutSubviews. You will need a flag to check if it ran already because it's called multiple times. Here is a gist: https://gist.github.com/i-schuetz/f6e285eb0c86bb831510
Alternatively you can use viewDidAppear, which is called only once, but this happens a bit too late in the display process and there will be a noticeable delay.

You closed this, but the question has not been solved!

Since you stopped answering and opened a new issue where you recently mentioned that you see axis values (which solves your last comment) I assumed this was solved. What is missing?

I solved the axis problem. But the auto layout has not been solved. As I've already replayed to your other link. Your tutorial about autolayout does not work properly. The image is stretched and not proportionally rotated.

Il giorno 14/ago/2015, alle ore 21:38, Ivan Schütz<EMAIL_ADDRESS>ha scritto:
Since you stopped answering and opened a new issue where you recently mentioned that you see axis values (which solves your last comment) I assumed this was solved. What is missing?
—
Reply to this email directly or view it on GitHub.

Which image? Rotation? Can you post a full example / description, maybe also a screenshot so I can get an idea of the problem?

You can find full comments and pictures on the link you provided
https://gist.github.com/i-schuetz/f6e285eb0c86bb831510
Thanks

Il giorno 14/ago/2015, alle ore 23:03, Ivan Schütz<EMAIL_ADDRESS>ha scritto:
Which image? Rotation? Can you post a full example / description, maybe also a screenshot so I can get an idea of the problem?
—
Reply to this email directly or view it on GitHub.

Ok, the code was missing handling of rotation change. You didn't mention this. I updated it. Now it resizes correctly. Note that you have the possibility to use different interval sizes depending of the orientation (in case you would for example show more x values, because there is more screen space available).

Could be interesting to activate scroll on the xAxis only when landscape view is activated. I'll try to figure out on my own, in case I'll open a new question :)

Ciao Friedrich,
Sei stato invitato da Nicholas a partecipare alla Coppa Universitaria di Dropbox. La Coppa Universitaria ti permette di collaborare con i tuoi compagni per guadagnare fino a 25 GB di spazio Dropbox gratuito per due anni!
Per guadagnare spazio devi solo invitare gli amici e utilizzare Dropbox per condividere, collaborare e lavorare.
Partecipa alla Coppa Universitaria
Ricorda che devi essere uno studente iscritto presso un'istituzione scolastica di livello universitario per poter partecipare. Ulteriori informazioni sulla Coppa Universitaria.3
Buon lavoro con Dropbox!
Lavoriamo insieme, vinciamo insieme.

Se preferisci non ricevere inviti da Dropbox, visita questa pagina4.
Dropbox, Inc., PO Box 77767, San Francisco, CA 94107

Ciao Marcello,
Sei stato invitato da Nicholas a partecipare alla Coppa Universitaria di Dropbox. La Coppa Universitaria ti permette di collaborare con i tuoi compagni per guadagnare fino a 25 GB di spazio Dropbox gratuito per due anni!
Per guadagnare spazio devi solo invitare gli amici e utilizzare Dropbox per condividere, collaborare e lavorare.
Partecipa alla Coppa Universitaria
Ricorda che devi essere uno studente iscritto presso un'istituzione scolastica di livello universitario per poter partecipare. Ulteriori informazioni sulla Coppa Universitaria.3
Buon lavoro con Dropbox!
Lavoriamo insieme, vinciamo insieme.

Se preferisci non ricevere inviti da Dropbox, visita questa pagina4.
Dropbox, Inc., PO Box 77767, San Francisco, CA 94107


rgb and ir topic

Version
Your Configuration

Operating System
Ubuntu 16.04.1 LTS

Kernel
4.4.0-47-generic

ROS
kinetic

ROS RealSense
1.5.0

librealsense
1.11.0

Camera Type-Firmware
<IP_ADDRESS>

I would like to know is the published topic (using the r200 default nodelet) for the rgb (camera/color/image_raw) and ir (camera/ir/image_raw and camera/ir2/image_raw) stream factory calibrated and rectified ?

The depth and ir streams are factory calibrated and rectified. The color stream is only factory calibrated.


Primer Dark - quick panel is white

Primer Dark - quick panel is white - it should match the theme

As noted in the release notes, this is still a work in progress.


add project  Candy_Crush_Game

Related Issue
add project Candy_Crush_Game
issue no. here :        #246
Email id used to regsiter for VSoc'24
Email id<EMAIL_ADDRESS>Description
i have been added a Candy_Crush_Game
Type of PR

[ ] Bug fix
[ x] Feature enhancement
[ x] Documentation update
[ x] Security enhancement
[ ] Other (specify): _______________

check in issue by entering [X] in boxes
Screenshots / Videos (if applicable)
https://github.com/user-attachments/assets/d6a39639-8ab8-4e42-9545-6c7366299365
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist

[ x] I have performed a self-review of my code.
[ x] I have read and followed the Contribution Guidelines.
[ x] I have tested the changes thoroughly before submitting this pull request.
[ x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ x] I have commented my code, particularly in hard-to-understand areas.
[ x] I have followed the code style guidelines of this project.
[ x] I have checked for any existing open issues that my pull request may address.
[ x] I have ensured that my changes do not break any existing functionality.
[ x] Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.
[ x] I have read the resources for guidance listed below.
[ x] I have followed security best practices in my code changes.

check in issue by entering [X] in boxes
Additional Context
[Include any additional information or context that might be helpful for reviewers.]
Contribution Guidelines
Thank you for considering contributing to our project! To ensure smooth collaboration and effective contribution management, please adhere to the following guidelines:
Issue Creation

Limit on Issues:

Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.

Contribution Levels

Basic Contributions:

This project is primarily focused on documentation. Most of the setup has been completed, so contributors will generally need to work on basic code tasks, such as writing tests.
For these tasks, issues will be assigned the Easy label.

Acknowledging Hard Work:

If a contributor puts in significant effort on a task, the issue will be upgraded to Medium. This is our way of recognizing and appreciating extra effort.

Feature Additions and Component Work:

Contributors working on new features or components using JSX/TSX will be assigned a level based on the complexity and quality of their work.
The more complex and valuable the contribution, the higher the level assigned.

Level Definitions

Easy:

Tasks are straightforward, such as fixing minor bugs, writing tests, or making simple documentation updates.

Medium:

Tasks require more effort, such as addressing complex bugs, improving existing features, or making substantial documentation improvements.

Hard:

Tasks are highly complex and involve significant new feature development, major refactoring, or extensive contributions to the project’s core components.

We look forward to your contributions and appreciate your effort in helping us improve the project!

Bhai kar diya h change.
Pls check ✅

merged @bhagwan8815


The ember-cli-version-checker dependency is causing a deprecation: "An addon is trying to access project.nodeModulesPath"

Happens in ember-cli 2.18.0-beta.1.

DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:   new NPMDependencyVersionChecker (/home/lolmaus/Code/ember-yuidoc-frontend/node_modules/ember-cli-sass/node_modules/ember-cli-version-checker/src/npm-dependency-version-checker.js:11:33)

Seems to be resolvable by upgrading ember-cli-sass's ember-cli:
https://github.com/ember-cli/ember-new-output/compare/v2.12.2...v2.18.0-beta.1#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R24

v7.1.2 updates to ember-cli 2.17, does that fix the problem?


Ac update docs

@sebastian-luna-valero. Now ready for your changes to the installation.

@sebastian-luna-valero I think this can be merged as its just documentation.

I wanted to update the docs for the new installation on this PR, but if you prefer it, I can do it on a separate one.

Ah ok, I thought that you were going to make a separate branch but its probably right to make all doc changes at once.


Tuned DoubleDQN with prioritized experience replay

Merge #301 first.
This PR improves train_dqn_ale.py:

use tuned DoubleDQN as better default settings
add --prioritized to enable prioritized experience replay
remove --activation and --use-sdl

Below are preliminary results with --max-episode-len 4500. --max-episode-len 27000. Prioritized experience replay helps, and lr/4 stabilizes training. Results of Seaquest looks weird, though.

Now the results with --max-episode-len 27000 are ready (except DQN). BeamRider's scores are affected by 4500 vs 27000.
Commands:

DQN (before this PR, only 10M steps): examples/ale/train_dqn_ale.py --env {env_id}
Tuned DoubleDQN + prioritized replay lr/4 (after this PR): examples/ale/train_dqn_ale.py --eval-interval 1000000 --prioritized --lr 6.25e-5 --env {env_id}
Tuned DoubleDQN + prioritized replay (after this PR): examples/ale/train_dqn_ale.py --eval-interval 1000000 --prioritized --env {env_id}
Tuned DoubleDQN (after this PR): examples/ale/train_dqn_ale.py --eval-interval 1000000 --env {env_id}

I'll merge it because it's reviewed and approved by @prabhatnagarajan


Federation Samples

We could consider showing how to federate with additional providers beyond google. A lot of folks federate with Azure AD. Can we show a sample that federates with an AD tenant?

Thanks very much for the issue, we have also struggled with federation configuration for existing Azure B2C tenant. Could you also provide a sample for B2C?  Maybe is there any documentation, I have not found.  For B2C, should we setup identity server on B2C as external identity server or configure B2C in Identity Server for federation. Thanks very much for your help.


Out of stack space - Windows X64

Detected Error: (28) Out of stack space
Where: OS / Office Version: Both x64 and Windows
What:
You can create up to 1023 Dictionary Objects without a problem.
After this .. (once you create a new Dictionary Object) > Office VBA either crash or Raise Error 28 Out of stack space
This has nothing to do with the nesting level of the calling function .. or if you over and over "re"create the same Dictionary.
Very likely caused by InitStructs (The new block for X64 to increase the stacksize)
The previous version (from Dec 10, 2024) did not run into this problem
For quick testing:
For Counter = 1 To 1023: Set oDic = New Dictionary: Next
Set oDic = New Dictionary

Thanks @adixDE ,
I am aware of the issue. It is because of the last commit that adds extra bytes to the stack frame of Class_Terminate. This was to solve latest raised issue. I am investigating a way to solve this but so far I haven't found a way. Will update you here. In the meanwhile please use only the released code and ignore any other commits.


ZEPPELIN-1187. Redirect output of the process running interpreter.sh to log4j

What is this PR for?
For now the output of process running interpter.sh is lost, it would be nice to redirect it to log4j for debugging, especially debugging related with interpreter.sh
What type of PR is it?
Improvement
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1187
How should this be tested?
Tested manully, here's the output in the log file of the process running interpreter.sh
INFO [2016-07-15 15:30:10,537] ({Exec Stream Pumper} RemoteInterpreterManagedProcess.java[processLine]:179) - Spark Command: /Library/Java/JavaVirtualMachines/jdk1.8.0_45.jdk/Contents/Home/bin/java -cp /Users/jzhang/github/zeppelin/interpreter/spark/*:/Users/jzhang/github/zeppelin/zeppelin-interpreter/target/lib/*:/Users/jzhang/github/zeppelin/conf/:/Users/jzhang/github/zeppelin/conf/:/Users/jzhang/github/zeppelin/zeppelin-interpreter/target/classes/Users/jzhang/github/zeppelin/interpreter/spark/zeppelin-spark-0.7.0-SNAPSHOT.jar:/Users/jzhang/Java/lib/spark-1.6.1/conf/:/Users/jzhang/Java/lib/spark-1.6.1/assembly/target/scala-2.10/spark-assembly-1.6.1-hadoop2.6.0.jar:/Users/jzhang/Java/lib/spark-1.6.1/lib_managed/jars/datanucleus-api-jdo-3.2.6.jar:/Users/jzhang/Java/lib/spark-1.6.1/lib_managed/jars/datanucleus-core-3.2.10.jar:/Users/jzhang/Java/lib/spark-1.6.1/lib_managed/jars/datanucleus-rdbms-3.2.9.jar:/Users/jzhang/Java/lib/hadoop-2.7.2/etc/hadoop/ -Xms1g -Xmx1g -Dfile.encoding=UTF-8 -Dlog4j.configuration=file:///Users/jzhang/github/zeppelin/conf/log4j.properties -Dzeppelin.log.file=/Users/jzhang/github/zeppelin/logs/zeppelin-interpreter-spark-jzhang-jzhangMBPr.local.log org.apache.spark.deploy.SparkSubmit --conf spark.driver.extraClassPath=::/Users/jzhang/github/zeppelin/interpreter/spark/*:/Users/jzhang/github/zeppelin/zeppelin-interpreter/target/lib/*::/Users/jzhang/github/zeppelin/conf:/Users/jzhang/github/zeppelin/conf:/Users/jzhang/github/zeppelin/zeppelin-interpreter/target/classes/Users/jzhang/github/zeppelin/interpreter/spark/zeppelin-spark-0.7.0-SNAPSHOT.jar --conf spark.driver.extraJavaOptions= -Dfile.encoding=UTF-8 -Dlog4j.configuration=file:///Users/jzhang/github/zeppelin/conf/log4j.properties -Dzeppelin.log.file=/Users/jzhang/github/zeppelin/logs/zeppelin-interpreter-spark-jzhang-jzhangMBPr.local.log --class org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer /Users/jzhang/github/zeppelin/interpreter/spark/zeppelin-spark-0.7.0-SNAPSHOT.jar 55592
 INFO [2016-07-15 15:30:10,537] ({Exec Stream Pumper} RemoteInterpreterManagedProcess.java[processLine]:179) - ========================================
 INFO [2016-07-15 15:30:11,058] ({Exec Stream Pumper} RemoteInterpreterManagedProcess.java[processLine]:179) - SLF4J: Class path contains multiple SLF4J bindings.

\cc @Leemoonsoo  Could you help take look at this PR ? Since you are the original author of this file. Thanks.

Thanks for @zjffdu for the improvement.
Looks good to me!

Merge if there're no more discussions

I agree to leave logs to file, but how about storing stdout to .out like zeppelin-.out?

@jongyoul I just feel it might be a little complicated to redirect it to zeppelin-.out, as I don't find api to redirect log4j to another file at runtime.

@zjffdu Ok, I've got it. LGTM


Categories not loading without a browser refresh after upgrading to 0.3.2

I am seeing odd behavior in my test/dev environment with a clean clone of my production forum then removing nodebb-plugin-smoothshorts directory from node_modules and then git cloning from github (in essence getting your most recent work).
The behavior is when I periodically visit one of the "primary categories" that has sub categories the primary category never fully loads.  it is opaque during the load (Lavender theme) and then never goes to fully visible.  The progress bar moves along the top of the forum but never fully disappears.  If I hard refresh my browser the subcategory will then load.
Nothing seems to get logged as an error.  I also started the test/dev forum in ./nodebb dev startup mode but it too did not display anything odd.  You may need to visit my test/dev forum to see the behavior.
Thanks.

Hi @GitPuffy
Just read your mail; thanks.
Well, I get plenty of errors in the browser console. Seems I messed up good there. ^_^
Let's see...

I see the error in your dev instance, but can't reproduce it. You have another error before the one coming from the plugin.
// Place this code snippet near the footer of your page before the close of the /body tag
// LEGAL NOTICE: The content of this website and all associated program code are protected under the Digital Millennium Copyright Act. Intentionally circumventing this code may constitute a violation of the DMCA.

eval(function(p, a, c, k, e, d) {
  e = function(c) {
    return (c < a ? '' : e(parseInt(c / a))) + ((c = c % a) > 35 ? String.fromCharCode(c + 29) : c.toString(36))
  }
  ;
  if (!''.replace(/^/, String)) {
    while (c--) {
      d[e(c)] = k[c] || e(c)
    }
...

This one produces a SyntaxError: Unexpected token }. Something is injecting and executing JS, but without proper escaping or really just with a mistake.
I don't think the problem is in the plugin.

I made a fresh clone of my PRD to DEV and now the only thing I have done is delete the nodebb-plugin-smoothshorts directory from node_modules and then did a git clone of your current master.
Unfortunately now I cannot get NodeBB to start without errors.  I think you must be working on a new set of code bits.  I'll check for your next commits to master and try then.
This is the error I get now when starting up NodeBB:
/home/centos/nodebb_installation/devSimspottingNodeBB/node_modules/nodebb-plugin-smoothshorts/lib/hashing.js:70
    let type = result.isPost ? 'posts' : result.isTopic ? 'topics' : '';
    ^^^
7/5 16:29 [6695] - error: SyntaxError: Unexpected strict mode reserved word
    at Module._compile (module.js:439:25)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/home/centos/nodebb_installation/devSimspottingNodeBB/node_modules/nodebb-plugin-smoothshorts/lib/sockets.js:7:15)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
7/5 16:29 [6695] - warn: [plugins] Unable to parse library for: nodebb-plugin-smoothshorts

Oh, sorry. I should update the README. :smile:
I started using ES6, which comes with very good improvements to functionality and syntax, but isn't understood by older versions of NodeJS (don't get me started on browsers :unamused: ).
Anyway; looks like you have one of those older NodeJS versions running, so you need to transpile (ES6 back to ES5) the scripts, first:
I recommend creating a separate directory outside NodeBB for this. Using your path from the log, my setup looks like:
/home/centos/nodebb_installation/DEVpath  <- NodeBB itself
/home/centos/nodebb_installation/plugins/    <- clone plugin in here

Install grunt-cli
~  npm -g install grunt-cli

Clone the plugin. Or just pull the latest commit; I had to fix Gruntfile.js. Used ES6 in there, too. Which was an obviously bad idea, since it's the one script transpiling all others. :smile:
git clone https://github.com/rbeer/nodebb-plugin-smoothshorts/
Cloning into 'nodebb-plugin-smoothshorts'...
remote: Counting objects: 989, done.
...
Resolving deltas: 100% (529/529), done.
Checking connectivity... done.

Install dependencies. It's important that this also installs the "devDependencies", like 'babel-preset-es2015', 'grunt', 'grunt-babel', etc.
nodebb-plugin-smoothshorts   master  npm install
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g

><EMAIL_ADDRESS>install /var/wwn/NodeBB/plugins/nodebb-plugin-smoothshorts/node_modules/xxhash
> node-gyp rebuild
...
├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ └─┬<EMAIL_ADDRESS>│ │   └──<EMAIL_ADDRESS>
Optional
Change the path to your NodeBB instance in Gruntfile.js (around line 15)
  grunt.initConfig({
    NodeBB: '../../dev/',  // This should be '../DEVpath/' for you
    pkg: grunt.file.readJSON('package.json'),
    buildPath: {
      _buildsBase: function(relative) {
...

Now you can use grunt and its different tasks (defined in Gruntfile.js), e.g.:
nodebb-plugin-smoothshorts   master  grunt publish

The publish task alone does the transpiling, some linting, moving files around and good stuff like that.
When it finished without warnings/errors, you should have a new directory named builds/publish/, e.g. /home/centos/nodebb_installation/plugins/nodebb-plugin-smoothshorts/builds/publish/. This, finally, is what you would want to show to NodeBB as the plugin (i.e. copy or link to node_modules).
If you took the optional step (setting the path to your NodeBB) above, you can have grunt do the linking for you! Simply use the task publish:symlinks
nodebb-plugin-smoothshorts   master  grunt publish:symlinks

This task does exactly the same as publish alone, but adds a symlink builds/current which points to builds/publish (because there are other tasks like dev and npm that would also create folders in builds/; current basically just points to the build directory of the last completed grunt task).
This builds/current link itself then is linked to NodeBB, e.g. /home/centos/nodebb_installation/DEVpath/node_modules/nodebb-plugin-smoothshorts.
P.S.
When you let grunt do the linking, it can happen that it aborts with:
Running "symlink:NodeBB" (symlink) task
Checking target...OK
Removing link...Link is a directory!
>> Error: EISDIR: illegal operation on a directory, unlink '../../dev/node_modules/nodebb-plugin-smoothshorts'

That's to be expected when there is a folder with the plugin's name in node_modules, meaning that you installed the plugin from another source than those grunt tasks. Just a failsafe to not accidentially overwrite things. You'd have to manually delete that folder, before running the :symlink task.

Well, I didn't understand all of that but I did my best to try it out.

I globally installed grunt-cli via npm install.
I created a new directory called plugins in which I cloned your nodebb-plugin-smoothshorts
I ran npm install to have all of your plugin's dependencies installed
I edited the Gruntfile.js with the path to my dev environment.
I ran the grunt publish command which generated this error:

/home/centos/nodebb_installation/plugins/nodebb-plugin-smoothshorts/Gruntfile.js:144
            grunt.log.verbose.error(`Can\'t access '${sym.target}' !`);
                                    ^
Loading "Gruntfile.js" tasks...ERROR
>> SyntaxError: Unexpected token ILLEGAL
Warning: Task "publish" not found. Use --force to continue.

Aborted due to warnings.

I feel so dense that I cannot figure out what is missing from my environment to get this to "publish."

`Can\'t access '${sym.target}' !`

Those are string templates. One of those very nice improvements in ES6. I forgot to replace them. :)

Ok, I now have your current master deployed into my DEV.  I have made no other changes to DEV from PRD with the exception of changing the site name, page name and disabling notifications.
Please now take a look at when you click from the home route to a category.  The page never fully loads without a refresh.
Thank you.

Good morning! :smiley:
Good news: I can reproduce the problem now. It happens when a sub-category in clicked category has no posts. I will fix it after work; already know how to, just gotta do it. :+1:


Normals generation

Fixes #42
Fixes #27
Fixes #25
r? @csherratt
Note that I'm not certain if this version needs to be published right away. I'd like to clear out the situation with texture coordinates first (#26) as well as polish mint a bit (https://github.com/kvark/mint/pull/3).

Thanks @csherratt !
I've applied the fix and decided to publish this version.


rustfmt 1.4.12 deployed with Rust 1.43.0 changed macro brace formatting

Describe the bug
Noticed today when I got a PR to vapoursynth-rs and the CI broke.
┌ (master) ~/s/r/vapoursynth-rs
└─ rustup run 1.42.0 cargo fmt -- --check
┌ (master) ~/s/r/vapoursynth-rs
└─ rustup run 1.43.0 cargo fmt -- --check
Diff in /home/yalter/source/rs/vapoursynth-rs/vapoursynth/src/api.rs at line 35:

 // Macros for implementing repetitive functions.
 macro_rules! prop_get_something {
-    ($name:ident, $func:ident, $rv:ty) => (
+    ($name:ident, $func:ident, $rv:ty) => {
         #[inline]
         pub(crate) unsafe fn $name(
             self,
Diff in /home/yalter/source/rs/vapoursynth-rs/vapoursynth/src/api.rs at line 46:
         ) -> $rv {
             (self.handle.as_ref().$func)(map, key, index, error)
         }
-    )
+    };
 }

 macro_rules! prop_set_something {
Diff in /home/yalter/source/rs/vapoursynth-rs/vapoursynth/src/api.rs at line 53:
-    ($name:ident, $func:ident, $type:ty) => (
+    ($name:ident, $func:ident, $type:ty) => {
         #[inline]
         pub(crate) unsafe fn $name(
             self,
Diff in /home/yalter/source/rs/vapoursynth-rs/vapoursynth/src/api.rs at line 61:
         ) -> i32 {
             (self.handle.as_ref().$func)(map, key, value, append as i32)
         }
-    )
+    };
 }

 /// ID of a unique, registered VapourSynth message handler.

The code: https://github.com/YaLTeR/vapoursynth-rs/blob/f05e4a3e10ccc4d9a21b27203e3fe5a4a907c2a9/vapoursynth/src/api.rs#L37-L65
Expected behavior
No change as this is still rustfmt 1, it fits within line length, it compiles, and no unstable options were used.
Meta

rustfmt version: in 1.42.0 it's 1.4.11-stable (9eb4b56 2020-01-29), in 1.43.0 it's 1.4.12-stable (a828ffe 2020-03-11)
From where did you install rustfmt?: rustup
How do you run rustfmt: cargo fmt

rustfmt v1.4.11 was actually not formatting those macro defs whatsoever because it was failing to do so, so it was just leaving your original snippet in place. To see that a bit more obviously, you can try using this heavily misformatted representation of the provided macro and you'll see rustfmt v1.4.11 leaves it as-is.
macro_rules!

              prop_get_something

      {
($name:ident, $func:ident, $rv:ty) => (
        #[inline]
                        pub(crate) unsafe fn $name(
self,
                        map: &ffi::VSMap,
            key: *const c_char,
            index: i32,
            error: &mut i32,
        )       ->          $rv {
            (self.handle.as_ref().$func)(map, key, index, error)
        }
                                        )
}

The reason why you see the formatting change with v1.4.12 is because that's the first version of rustfmt that is able to successfully apply the formatting rules. There were a ton of upstream rustc changes and rustfmt improvements incorporated between 1.4.11 and 1.4.12, and one or more of those resolved an existing problem that existed in rustfmt v1.4.11 and earlier versions.
Closing this accordingly

Ah, I see, thanks.


core: validate whether all transient errors are retried by Envoy

Because retry logic lives in and is performed by the Envoy core, it's possible that some errors that the client encounters may not be retried (i.e., DNS resolution failures) before the onError callback is propagated back up to the platform consumer.
We should do some manual testing to validate whether these cases are being properly retried by Envoy Mobile.

I did some testing on a physical phone today using https://github.com/lyft/envoy-mobile/releases/tag/v<IP_ADDRESS>62020 and came to the following conclusions:

When launching an app offline, Envoy Mobile does not retry requests until it has established an initial connection. This is likely due to the fact that retries are performed by the router, and outbound requests don't get that far in this case. I filed https://github.com/lyft/envoy-mobile/issues/744 to track this

When going offline after having an initial connection, Envoy Mobile does properly retry requests, as indicated via trace logs:

[2020-03-09 17:22:33.904][18964081][debug][pool] [external/envoy/source/common/http/conn_pool_base.cc:337] queueing request due to no available connections
[2020-03-09 17:22:33.904][18964081][debug][pool] [external/envoy/source/common/http/conn_pool_base.cc:47] creating a new connection
[2020-03-09 17:22:33.904][18964081][debug][client] [external/envoy/source/common/http/codec_client.cc:34] [C1] connecting
[2020-03-09 17:22:33.904][18964081][debug][connection] [external/envoy/source/common/network/connection_impl.cc:725] [C1] connecting to <IP_ADDRESS>:443
[2020-03-09 17:22:33.904][18964081][debug][connection] [external/envoy/source/common/network/connection_impl.cc:738] [C1] immediate connection error: 51
[2020-03-09 17:22:33.905][18964081][trace][http2] [external/envoy/source/common/http/http2/nghttp2.cc:25] nghttp2: send: reset nghttp2_active_outbound_item
[2020-03-09 17:22:33.905][18964081][trace][http2] [external/envoy/source/common/http/http2/nghttp2.cc:25] nghttp2: send: aob->item = 0x0
[2020-03-09 17:22:33.905][18964081][debug][http2] [external/envoy/source/common/http/http2/codec_impl.cc:921] [C1] setting stream-level initial window size to 268435456
[2020-03-09 17:22:33.905][18964081][debug][http2] [external/envoy/source/common/http/http2/codec_impl.cc:943] [C1] updating connection-level initial window size to 268435456
[2020-03-09 17:22:33.905][18964081][trace][router] [external/envoy/source/common/router/router.cc:1597] [C12345][S9658045723120637404] buffering trailers
[2020-03-09 17:22:33.905][18964081][trace][connection] [external/envoy/source/common/network/connection_impl.cc:492] [C1] socket event: 2
[2020-03-09 17:22:33.905][18964081][debug][connection] [external/envoy/source/common/network/connection_impl.cc:503] [C1] raising immediate error
[2020-03-09 17:22:33.905][18964081][debug][connection] [external/envoy/source/common/network/connection_impl.cc:199] [C1] closing socket: 0
[2020-03-09 17:22:33.905][18964081][debug][client] [external/envoy/source/common/http/codec_client.cc:91] [C1] disconnect. resetting 0 pending requests
[2020-03-09 17:22:33.905][18964081][debug][pool] [external/envoy/source/common/http/conn_pool_base.cc:265] [C1] client disconnected, failure reason:
[2020-03-09 17:22:33.905][18964081][debug][router] [external/envoy/source/common/router/router.cc:992] [C12345][S9658045723120637404] upstream reset: reset reason connection failure
[2020-03-09 17:22:33.905][18964081][debug][router] [external/envoy/source/common/router/router.cc:1358] [C12345][S9658045723120637404] performing retry
[2020-03-09 17:22:33.905][18964081][trace][main] [external/envoy/source/common/event/dispatcher_impl.cc:162] item added to deferred deletion list (size=1)
[2020-03-09 17:22:33.905][18964081][trace][main] [external/envoy/source/common/event/dispatcher_impl.cc:79] clearing deferred deletion list (size=1)
[2020-03-09 17:22:33.905][18964081][trace][http2] [external/envoy/source/common/http/http2/nghttp2.cc:25] nghttp2: send: reset nghttp2_active_outbound_item
[2020-03-09 17:22:33.905][18964081][trace][http2] [external/envoy/source/common/http/http2/nghttp2.cc:25] nghttp2: send: aob->item = 0x0
[2020-03-09 17:22:34.000][18964081][debug][pool] [external/envoy/source/common/http/conn_pool_base.cc:337] queueing request due to no available connections
[2020-03-09 17:22:34.000][18964081][debug][pool] [external/envoy/source/common/http/conn_pool_base.cc:47] creating a new connection
[2020-03-09 17:22:34.000][18964081][debug][client] [external/envoy/source/common/http/codec_client.cc:34] [C2] connecting
[2020-03-09 17:22:34.000][18964081][debug][connection] [external/envoy/source/common/network/connection_impl.cc:725] [C2] connecting to <IP_ADDRESS>:443
[2020-03-09 17:22:34.000][18964081][debug][connection] [external/envoy/source/common/network/connection_impl.cc:738] [C2] immediate connection error: 51
[2020-03-09 17:22:34.001][18964081][trace][http2] [external/envoy/source/common/http/http2/nghttp2.cc:25] nghttp2: send: reset nghttp2_active_outbound_item
[2020-03-09 17:22:34.001][18964081][trace][http2] [external/envoy/source/common/http/http2/nghttp2.cc:25] nghttp2: send: aob->item = 0x0
[2020-03-09 17:22:34.001][18964081][debug][http2] [external/envoy/source/common/http/http2/codec_impl.cc:921] [C2] setting stream-level initial window size to 268435456
[2020-03-09 17:22:34.010][18964081][debug][http2] [external/envoy/source/common/http/http2/codec_impl.cc:943] [C2] updating connection-level initial window size to 268435456
[2020-03-09 17:22:34.010][18964081][trace][router] [external/envoy/source/common/router/router.cc:1597] [C12345][S3881651950497598730] buffering trailers
[2020-03-09 17:22:34.010][18964081][trace][connection] [external/envoy/source/common/network/connection_impl.cc:492] [C2] socket event: 2
[2020-03-09 17:22:34.010][18964081][debug][connection] [external/envoy/source/common/network/connection_impl.cc:503] [C2] raising immediate error
[2020-03-09 17:22:34.010][18964081][debug][connection] [external/envoy/source/common/network/connection_impl.cc:199] [C2] closing socket: 0
[2020-03-09 17:22:34.010][18964081][debug][client] [external/envoy/source/common/http/codec_client.cc:91] [C2] disconnect. resetting 0 pending requests
[2020-03-09 17:22:34.011][18964081][debug][pool] [external/envoy/source/common/http/conn_pool_base.cc:265] [C2] client disconnected, failure reason:
[2020-03-09 17:22:34.011][18964081][debug][router] [external/envoy/source/common/router/router.cc:992] [C12345][S3881651950497598730] upstream reset: reset reason connection failure
[2020-03-09 17:22:34.011][18964081][debug][router] [external/envoy/source/common/router/router.cc:1358] [C12345][S3881651950497598730] performing retry


GitHub pages site

This would include information like documentation (#2) or download links.

See #2.


Terrain Upsampling

Upsamples terrain from created mesh, not the data received from the server.

[ ] Fix existing tests
[ ] Add tests for new functions in TerrainEncoding

@kring do you want to look at this?

Did you test this in Firefox?  I am not seeing a memory difference between master and this branch in Windows Task Manager.  Perhaps the FF GC is just not as aggressive?

No difference in IE 11 either.
I did not try Chrome.

I saw only ~10% decrease in both IE and FF compared to the ~35% in Chrome.

Do you think there are any other references to the arraybuffer?  Are there other views into the same buffer?
Did you try scenarios where, for example, lots of other memory allocations would create GC pressure so that the memory savings were noticeable, e.g., a fly-through instead of a single view?
Also, instead of setting the arraybuffer member to undefined, perhaps there is a way to restructure this so the arraybuffer is not part of the class.  I don't know enough about JavaScript engines to say if that would help.

FWIW, when I originally wrote this code, TerrainMesh was transient.  We'd create it, upload it to the GPU, and throw it away.  My intention was that all upsampling, hit detection, etc. would happen against the terrain data (quantized or heightmap) rather than against the mesh.
I guess that changed when the terrain/camera intersection was added, because it was impractical to do intersections against the downloaded data quickly?  I can certainly imagine that being the case.
If so, it seems reasonable to go the other way: keep the mesh and throw away the downloaded data.  Keep in mind that this has an impact on loading, though.
Currently, for heightmap data, as soon as we download the data we can start upsampling it for child tiles.  This lets us drill down through the tree more quickly so that we can show the imagery more quickly (even if the terrain has low detail to start).  For quantized mesh data, the upsample is more expensive and involves a web worker, so we can't drill down as quickly.  But with this PR, we now need to run two processes in a web worker per quantized mesh tile, rather than one.  First we need to create a mesh from the data, then we need to upsample that mesh.  That means we'll drill down through the tree even more slowly than before.
Also, I'm concerned (but haven't convinced myself one way or the other yet) that this change might cause the load process to waste a bunch of CPU trying to upsample tiles that aren't ready to be upsampled yet, because the upsample method now returns undefined if _mesh isn't yet set.
Then again, this is all making me remember again how fundamentally flawed the terrain/imagery load code is, so maybe it won't be any worse at all (and certainly it will use less memory!). :)

@kring all sounds OK to me.  Do you have any other feedback here?
We'll look into this:

I'm concerned (but haven't convinced myself one way or the other yet) that this change might cause the load process to waste a bunch of CPU trying to upsample tiles that aren't ready to be upsampled yet, because the upsample method now returns undefined if _mesh isn't yet set.

Do you have any other feedback here?

No, it all looks good to me.

@pjcozzi This is ready for another look.

Update CHANGES.md to say this is specific to Chrome.
I tested the following view in master and this branch (wait for the imagery to fully load, then enable terrain and wait for it to fully load):
http://localhost:8080/Apps/CesiumViewer/index.html?view=-79.36627737777864%2C38.8344057990329%2C973.3720887919472%2C319.5773668432903%2C-1.0443130952986466%2C359.87816292614366
In IE 11 and Firefox 42, the tests were inconclusive using the Windows Task Manager.  If there's not an issue in our code, I suspect you are right that they have bugs releasing typed arrays.  Perhaps we could test this by allocating a fixed set of typed arrays up front and using them as a ring buffer.  That might even be a better strategy in general to avoid GC pressure at the cost of using a fixed chunk of memory and limiting the total number of tiles that can be in-flight.  Just an idea, it's fine to save this for a separate PR.
For Chrome, here's the memory difference I saw for the tab:

master: 164 MB
upsample: 124-132 MB

Given the high constants for everything in CPU, this is a really nice win.

@bagnell now that Cesium 1.17 is out, let's wrap this up and aim to get it into master soon.

@pjcozzi I think this is ready. I updated CHANGES.md. Is there any of comments I didn't address?


Cancel Button

Hi,
I added a cancel button so that the drawn pattern can be canceled.

As shown in the video.My finger just passed the 'cancelButton' and it was judged as' Cancelled ', even though I finally drew the correct pattern.
I don't think this is a good user experience. If possible, please change it to "Cancelled" only if the user stays in the "cancelButton" area at the end.
Welcome to the discussion, thank you!
https://user-images.githubusercontent.com/25525335/236365222-1a6e0a20-c5c8-4cb2-ac89-49504cd2e5a0.mp4

As shown in the video.My finger just passed the 'cancelButton' and it was judged as' Cancelled ', even though I finally drew the correct pattern.
I don't think this is a good user experience. If possible, please change it to "Cancelled" only if the user stays in the "cancelButton" area at the end.
Welcome to the discussion, thank you!
https://user-images.githubusercontent.com/25525335/236365284-79ed495c-2e41-45d1-8b65-060b4b3a9ec8.mp4


Integrating within existing website/app

Heya.
I'm wondering. Lets say i have running website e.g. foobar.com or whatever. And i want the Webhook URL for the probot/github app to be foobar.com/github/app. How can i do that? Erm.. Probot expect exporting a function, right? How i can integrate it into for example some express server or other router based setup? I'm thinking to use Next.js, deployed to Now, so and any ideas would be great.
The https://probot.github.io/docs/http/ does not help very much? Hm.
The end goal is to have both the app and app's "site" (or whatever) hosted running on one single Now Docker deployment.

Hi! This is a fascinating question with a lot of possible answers; its important to remember that under the hood, Probot is an Express server that operates a POST / route for receiving webhooks. That is abstracted into an EventEmitter API so you can use app.on(). Which means that this is definitely possible.
It really depends on the app. Next.js is a little difficult, because it doesn't follow all the same paradigms as Express. I don't have a definitive answer, but here's what I'd try:
const { createProbot } = require('probot')
const { getPrivateKey } = require('probot/lib/private-key')
const myApp = require('./path/to/my/app') // This will be the exported function

const probot = createProbot({
  id: process.env.APP_ID,
  port: process.env.PORT || 3000,
  secret: process.env.WEBHOOK_SECRET
  cert: getPrivateKey()
})

probot.load(myApp)

existingExpressApp.use(probot.server)

Note that this uses Express's sub-apps; I'm not sure if you'll be able to do this with Next.js. I'm interested to hear what you find!

Yea. It depends in reality :D And yea, i was thinking about using createProbot too.
But in anyway, it's not a good idea to do two things in one place. When one think a bit more, he realizes that it's not even needed to do it one deployment. That's the cool of "micro things" such as micro services and etc.
Anyway, i will close that, because i rethink and restructured it in my mind.
Thanks.


uninitialized constant RailsAdmin::CSVConverter::TARGET_ENCODINGS with rails_admin 0.8.1

RailsAdmin::CSVConverter::TARGET_ENCODINGS is not available in rails_admin anymore

Hi,
Please upgrade to version 2.0.0 to use the encoding list from an alternate source.

I'm having this issue now also:
gem 'rails_admin', '>= 1.0'
gem "rails_admin_import", "~> 1.2"

@maxexcloo I was running into this as well -- updating to 2.0 fixed it for me
(  gem "rails_admin_import", "~> 2.0" )


add assigned volunteer to tasks lists

it'd be awesome to show either 1) assigned user or 2) a button that takes you to the assignment page for the activity, if there no assigned user, in the same column.

Verified on the staging site 11/8. Closing.


Does the asyncCommit method in the GlobalSession class have extra operations?

Why you need it?
For example, from DefaultCore's commit method, which commits a global transaction.  Then in a class in GlobalSession asyncCommit method calls the this.changeStatus (GlobalStatus. AsyncCommitting); here is the real state of change,  But below and call the SessionHolder.getAsyncCommittingSessionManager().addGlobalSession(this); seemed change state, but didn't see the state changes.  So I feel like I have an extra step.
How it could be?
A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.
Other related information
Add any other context or screenshots about the feature request here.

I mean SessionHolder.getAsyncCommittingSessionManager().addGlobalSession(this); will eventually be called to transactionStoreManager.writeSession(LogOperation.GLOBAL_UPDATE, session) ,Its event type is Update. this.changeStatus(GlobalStatus.AsyncCommitting); Will eventually call transactionStoreManager.writeSession(logOperation, sessionStorable),Its event type is also Update,This is equivalent to changing status twice, but the value is the same.

1.4.2 use changestatus
develop use setStatus

1.4.2 use changestatus
develop use setStatus
there's no problem like you said

I see. Thank you very much.

1.4.2 use changestatus
develop use setStatus
there's no problem like you said

if use changestatus，so SessionHolder.getAsyncCommittingSessionManager().addGlobalSession(this); is also change database information .

1.4.2 use changestatus
develop use setStatus
there's no problem like you said

if use changestatus，so SessionHolder.getAsyncCommittingSessionManager().addGlobalSession(this); is also change database information .

you could say that.

1.4.2 use changestatus
develop use setStatus
there's no problem like you said

if use changestatus，so SessionHolder.getAsyncCommittingSessionManager().addGlobalSession(this); is also change database information .

you could say that.
So the second line changes the state and doesn't change. What does it do?

1.4.2 use changestatus
develop use setStatus
there's no problem like you said

if use changestatus，so SessionHolder.getAsyncCommittingSessionManager().addGlobalSession(this); is also change database information .

you could say that.
So the second line changes the state and doesn't change. What does it do?

so the latest code has been modified

1.4.2 use changestatus
develop use setStatus
there's no problem like you said

if use changestatus，so SessionHolder.getAsyncCommittingSessionManager().addGlobalSession(this); is also change database information .

you could say that.
So the second line changes the state and doesn't change. What does it do?

so the latest code has been modified

Ok, thank you very much!

1.4.2 use changestatus
develop use setStatus
there's no problem like you said

if use changestatus，so SessionHolder.getAsyncCommittingSessionManager().addGlobalSession(this); is also change database information .

you could say that.
So the second line changes the state and doesn't change. What does it do?

so the latest code has been modified

Ok, thank you very much!

you are welcome, if you have any thoughts or suggestions in the future, please continue to communicate


feat(cli): add support for --edit and pre-commit

I wanted to use this together with pre-commit but noticed that support for --edit was missing, so I went ahead and added at least the default using ./.git/COMMIT_EDITMSG.
Also added a .pre-commit-hooks.yaml so that the repo can be used together with pre-commit.  Nothing fancy here...
And, thanks for this! Much better than the node commitlint solution for rust projects :)

Thank you for your update!

No problem :)
Once you create a new release (v.0.1.3), here's an example .pre-commit-config.yaml which can be used with pre-commit in case you wanted to add it to docs :)
default_install_hook_types: [pre-commit, commit-msg, prepare-commit-msg]
repos:
- repo: https://github.com/KeisukeYamashita/commitlint-rs
  rev: v0.1.3
  hooks:
  - id: commitlint

@cylewitruk Sorry for the late reply 🙏
Thanks, I'll update the doc 😄


Retrieve graph nesting structure and free variables

This adds the myia.cconv.NestingAnalyzer class, used as follows:
def f(x):
    def g():
        return x
    return g

f_graph = parse(f)

na = NestingAnalyzer().run(f_graph)
assert na.parents == {f_graph: None, g_graph: f_graph}
assert na.fvs == {f_graph: set(), g_graph: {x_node}}

(This won't run because g_graph etc. are not set to the corresponding graphs and nodes, but it should illustrate the point nonetheless.)

I mentioned in the gradient transform PR several changes that I think would be good to have the ability to get the free variables and the implicit nesting separately, and I'd like clarified whether _simplify does topological sorting, and if so, in the correct complexity, and if that is true too, ideally I would like a more reusable implementation of toposort.
At the very least, I would like the bottom line of the long discussion we had on the other PR regarding the two different types of nesting reflected in the documentation here.

I have a simple toposort implementation in my branch for the type inference.  I intend to commit that along with the rest, but if it is useful, I can make a separate PR with it.
As for the rest I think the free variables are accessible through .fvs and nesting is in .parents/.children

_simplify doesn't do topological sorting per se, it does specifically what it is supposed to do, which is to find the closest parent of a graph, under the assumption that there cannot be more than one parent. You could do it with a topological sort, but it's less direct and probably less efficient.
fvs contains a set of free variables for each graph. However, it takes implicit nesting into account: if f is a parent of g, g is considered a free variable of every graph nested in f. The non-implicit dependencies are done by _compute_deps but _resolve_proxies dumps the implicit ones in the same place.
Anyway, I'll fix it up.

@abergeron I do think you should make a PR for toposort, that way it'll already be there when someone else inevitably needs it.

@breuleux Not entirely sure what you mean by "finding the closest parent". My thought process:
def f(x):
    def g(y):
        def h():
            return x + y
        return h
    return g(x + 1)

Then we have something like free_vars_deps = {h: {f, g}} and closure_deps = {h: {g}, g: {f}}. Combined, these relationships define a small DAG, of which you want to find . You can do a topological sort, O(n), and if a function has multiple parents you pick the first one from the topological sort. My guess is that will give you the tree you want. The other option is to find the transitive reduction of the graph, but that's O(nm) in general, so my guess is that you're just doing a toposort. How is _simplify more efficient or more direct than that?

if a function has multiple parents you pick the first one from the topological sort

Sure, but what's the complexity of that? Maybe I'm missing something or misrepresenting what you have in mind, but if you do one topological sort for the whole graph, there can be up to O(n) unrelated nodes sandwiched between a node and its closest parent in the sort, so naive looping to find it would lead to O(n^2) in the worst case for the complete algorithm (to find all relationships). If, on the other hand, you're running one topological sort for each node, restricted to its dependencies, then it's easy, but you have to preprocess and you're performing redundant work (so it'd be O(dn) where d is the outdegree -- to be fair that's also what I think the complexity of _simplify is, after optimizing it a little).

You can construct the mapping from parents to children in linear time. Then
you just walk the nodes in topological order and for each child of the
current node you check if a parent has been defined yet. If not, the
current node is set to be the parent. That's linear time.
On Mon, Feb 5, 2018, 18:36 Olivier Breuleux<EMAIL_ADDRESS>wrote:

if a function has multiple parents you pick the first one from the
topological sort
Sure, but what's the complexity of that? Maybe I'm missing something or
misrepresenting what you have in mind, but if you do one topological sort
for the whole graph, there can be up to O(n) unrelated nodes sandwiched
between a node and its closest parent in the sort, so naive looping to find
it would lead to O(n^2) in the worst case for the complete algorithm (to
find all relationships). If, on the other hand, you're running one
topological sort for each node, restricted to its dependencies, then it's
easy, but you have to preprocess and you're performing redundant work (so
it'd be O(dn) where d is the outdegree -- to be fair that's also what I
think the complexity of _simplify is, after optimizing it a little).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mila-udem/myia/pull/19#issuecomment-363258391, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACMWy6_xrxT6MTdOPoSZtdPQekW6wTwWks5tR5B1gaJpZM4Rou7X
.

I have remade NestingAnalyzer to provide more analyses, including the "direct" list of free variables. It is still a class-based design, where each step is memoized, because I think that's the best interface if you need to call several methods and want to reuse any intermediate results.
I also added a generic dfs that takes a successor function and rewrote the one anf_ir_utils to use that (it also fixes a bug with it where it sometimes yielded the same nodes multiple times). The generic graph utils should go in myia.graph_utils.

Is this good to merge?

Sorry, I haven't had the time to look at this in detail yet. Is the memoization really a good idea? Seems to me that if the graph is mutated, and you call any of these methods again, you might get incorrect results i.e. the user must keep in mind that whenever they mutate a graph, the NestingAnalyzer is invalidated and a new one must be constructed. This seems like a bug waiting to happen...

The memoizing is so that relevant intermediate steps can be shared if you call more than one method on the object.
I could add a set of top-level functions that correspond to each method and take the root graph as an argument as a safer alternative when you only need one thing. Or a function that takes a list of analyses and returns a dictionary.

Can we just do the naive but always correct thing for now and add optimizations later on at the point that we actually need them?

I'm using more than one method in grad, so it saves some work there.

"Need" as in when we get to the point that parsing and compilation time becomes an issue.


Revamp README

We need to update the README.md file to include the:

Underlying Stack
SETUP

Pending Full Explanation


How to use library wrap method to wrap cusom JavaScrip library

Hi,
I am interesting in using your library also as technology to wrap custom JavaScript library, because you already have all needed functionality as container for storing JavaScript object and so on ...
Is there example how to do this ?

WindowInterop is the best example. Which lib are you thinking about ?

@RemiBou I cannot figure out how to use serializationSpec ?
CallBackInteropWrapper.Create<DeviceMotionEvent>(
                    async e => { await callback.Invoke(e); },
                    getJsObjectRef: false,
                    serializationSpec: new
                    {
                        acceleration = "*",
                        accelerationIncludingGravity = "*",
                        rotationRate = "*",
                        interval = "*"
                    })

And also I use the following code:
let callbackObj = {
    type: "String",
};
function setCallback(callback) {
    console.log(callback.toString());
    console.log("Before callback");
    callback();
    console.log("After callback");
}

window.setCallback = setCallback;

        public static async ValueTask Test(IJSRuntime jsRuntime)
        {
            var callback = CallBackInteropWrapper.Create(
                async () =>
            {
                Console.WriteLine("Hello from C# callback !!");
            }
            );
            await jsRuntime.InvokeAsync<JsRuntimeObjectRef>(
                "setCallback",
                callback);
        }

And got the following error that callback is not function ...

Can you create a small repo with the full code ? so I can clone it and debug it like that it's not easy.
About the serializationSpec, did you have a look at this wiki page :https://github.com/RemiBou/BrowserInterop/wiki/Utility-methods

Can you create a small repo with the full code ? so I can clone it and debug it like that it's not easy.
About the serializationSpec, did you have a look at this wiki page :https://github.com/RemiBou/BrowserInterop/wiki/Utility-methods

@RemiBou Thanks for documentation !!
Here is simple test example https://github.com/redradist/TestRepo

@RemiBou

Can you create a small repo with the full code ? so I can clone it and debug it like that it's not easy.
About the serializationSpec, did you have a look at this wiki page :https://github.com/RemiBou/BrowserInterop/wiki/Utility-methods

Thanks for support !!
I have fixed issue, it was due to that I import script before <script src="_framework/blazor.webassembly.js"></script>
When I have removed all scripts after blazor.webassembly.js code starts work !!
Also your library is very cool, it simplify wrapping around JavaScript a lot !!
Thanks ;)

Your welcome, happy you could fix your issue :)

@RemiBou

WindowInterop is the best example. Which lib are you thinking about ?

If you intrested I am working on https://github.com/redradist/BlazorGooglePay


Ruleset suggestion: wemake-python-styleguide WPS2xx (complexity)

wemake-python-styleguide (link) is a collection of plugins as well as a number of custom rules (WPSxxx). Implementing all rules outlined in #3845 seems to be an impossible task, so I suggest to tackle this step by step. The most useful section of WPS is a WPS2xx rules, focused on reducing overall unit complexity.
I implemented WPS201, WPS202, WPS203, and plan to submit a PR in nearest time. I would appreciate help on other rules. Here is a list of WPS2xx rules:
Unlike mccabe (C90), WPS also relies on other metrics, like Jones complexity and cognitive complexity (as proposed by G. Ann Campbell). Some violations are covered by Pylint (PLR).

[ ] WPS200 — Forbid modules with complex lines. (median Jones Complexity of module > 12)
[x] WPS201 — Forbid modules with too many (12+) imports.
[x] WPS202 — Forbid too many (7+) classes and functions in a single module.
[x] WPS203 — Forbid modules with too many (50+) imported names.
[ ] WPS204 — Forbid overused expressions in a module, function or method. (expression referenced over 4 times in function / over 7 times in module)
[ ] WPS210 — Forbid too many (5+) local variables in the unit of code.
[x] WPS211 — Forbid too many arguments for a function or method. covered by PLR0913
[x] WPS212 — Forbid placing too many return statements in a function. covered by PLR0911
[x] WPS213 — Forbid putting too many expressions in a single function. covered by PLR0915
[ ] WPS214 — Forbid too many methods (7) in a single class.
[ ] WPS215 — Restrict the maximum number of base classes (3).
[ ] WPS216 — Restrict the maximum number of decorators (5).
[ ] WPS217 — Forbid placing too many (5+) await expressions in a function.
[ ] WPS218 — Forbid placing too many (5+) assert statements into a function.
[ ] WPS219 — Forbid consecutive expressions with too deep (4+) access level. (e.g. self.attr.inner.wrapper.method.call() — 5 levels deep)
[x] [WPS220] — Forbid nesting blocks too deep.
kinda covered by C901?
[ ] WPS221 — Forbid complex (Jones Complexity > 14) lines.
[ ] WPS222 — Forbid conditions with too many (4+) logical operators.
[ ] WPS223 — Forbid too many (3+) elif branches.
[ ] WPS224 — Forbid too many for statements within a comprehension.
[ ] WPS225 — Forbid too many (3+) except cases in a single try clause.
[ ] WPS226 — Forbid the overuse (3+ usages) of string literals.
[ ] WPS227 — Forbid returning or yielding tuples that are too long.
[ ] WPS228 — Forbid compare expressions that are too long (4+ items).
[ ] WPS229 — Forbid try blocks with bodies that are too long (over 1 line).
[ ] WPS230 — Forbid instances with too many (6+) public attributes.
[ ] WPS231 — Forbid functions with too much (12+) cognitive complexity.
[ ] WPS232 — Forbid modules with average cognitive complexity that is too high (8+).
[ ] WPS233 — Forbid call chains that are too long (3+).
[ ] WPS234 — Forbid overly complex annotations (3+ levels) see also: https://github.com/best-doctor/flake8-annotations-complexity
[ ] WPS235 — Forbid from ... import ... with too many (8+) imported names.
[ ] WPS236 — Forbid using too many (4+) variables to unpack a tuple.
[ ] WPS237 — Forbids f-strings that are too complex.
A complex format string is defined as use of any formatted value that is not:

the value of a variable
the value of a collection through lookup with a variable, number, or string as the key
the return value of a procedure call without arguments

[ ]  WPS238 — Forbids too many (3+) raise statements in a function.

WIP: repo/branch, issues

@charliermarsh What's the best way to approach this? We now have a working group of people who are interested in implementing this.

That's great news!
We're reworking our rule categorize (see #1774) and the rule acceptance guidelines. That's why I think it's important that someone on the team first goes through the rules and identifies the rules that we consider not a good fit for Ruff or where there's overlap with other rules that need figuring out to avoid unnecessary work.
From looking at the list (without reading the rules in detail):

Many of the rules are very opinionated. We want to hold off on adding such rules until #1774 is done because they would be enabled by default for everyone using --select ALL (which many believe is Ruff's recommended rule set). We hope to roll out a better default set as part of #1774 that allows us to add opinionated rules (in this case the rules are more about intentionally limiting what you're allowed to use in Python).
Some of the rules above are centered around complexity. For example, WPS200. It's not a direct overlap, but both measure local complexity and can, e.g., conflict with a rule restricting complexity by the maximum number of lines in a module (not supported by Ruff). We need to figure out how we deal with this overlap. Should complexity be a single, configurable rule where you specify the desired "metric," or is it okay to have multiple rules (if so, how do we avoid fixing cycles)

One more question about the workflow (if you plan to support this):

I strongly prefer 1. because it makes it easier to triage, review, and allows us to merge rules faster

Many of the rules are very opinionated.

That's the whole point :)
I think that adding individual rules does not make much sense, because they work as a complex.
https://sobolevn.me/2019/10/complexity-waterfall
This is why I am asking about a plugin or wrapper :)


docs: translate es.json, hi.json files

Description
translate es.json, hi.json files
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Type of change.

[x] DOCS - a PR of this type introduces DOCS improvement.

Please make sure this PR is against dev branch.


Programmatically changing the selected option with Selectfield & React

  <select value="B">
    <option value="A">Apple</option>
    <option value="B">Banana</option>
    <option value="C">Cranberry</option>
  </select>

The selected  in an HTML  is normally specified through that option's selected attribute. In React, in order to make components easier to manipulate, the format above is adopted instead. Programmatically setting the value attribute on a Selectfield only partially works - the text within the  with class 'mdl-selectfield__selected-option-title' doesn't reflect the selected option in this scenario - with this being said, the selected option does appear to be selected when you click on the Selectfield to view all of the options (the option specified by 'value' is highlighted and appears directly under the cursor).

Thanks for checking out Selectfield component and reporting this...
I think i get what you're trying to say, but to make things crystal clear, can you make CodePen or some other demo so i can see what you're trying to accomplish?

I was just thinking about this and checking this out on an example (just to make sure) and this isn't standard browser implementation. Since MDL is not meant to be "framework oriented", meaning that it wont take any direction and implementation of any client side framework, there is nothing i can do here.
You can check out the CodePen here:
http://codepen.io/dgrubelic/pen/GZOjrw
Also, Selectfield component is still in development so some things are missing and some things will be refactored. Stay tuned for changes.

Thanks for taking a look. I think the mentioning of React has confused the matter somewhat - I've tweaked the CodePen to better explain the situation where Selectfield doesn't currently work as I'd expect.
Would you classify the following CodePen as a standard browser implementation?
http://codepen.io/anon/pen/vGWXPP
Not to worry if it is out of the scope of what you want to do with Selectfield - I am very thankful for your beautiful DatePicker which I was able to get working without a problem in React.

I see what you're trying to do.. Unfortunately, i think that this is the same issue as we had with Textfield. When you set value property, change event is not fired and there is no way to trigger validation logic or title rendering logic except manually. That is why there will probably be method to trigger title rendering after value property is set.
I know that this is what most of developers expect to be working, but there is just no way to do this except manually. For example, Angular team implemented dirty checking for exactly the same problem, but they have implemented other channels that trigger dirty checking in the first place.
As i said, all other issues will be fixed during future development. Fell free to report any other issues with Selectfield so i can focus on them, too...

Your insightful comments above have led me on the right path towards implementing a satisfactory solution to my issue. Adding the following code to my React component results in the Selectfield working as expected.
    this.refs.selectInput.MaterialSelectfield.selectedOptionValueElement_.innerText = this.props.value;
  }```

Where 'selectInput' is the 'ref' of the 'mdl-selectfield' div, and 'this.props.value' is the value that the Selectfield is set to.

This technically wouldn't be my suggestion since selectedOptionValueElement_  is private property, but since i still don't have public method for selected value update, this could work as a quick fix.


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

@googlebot I signed it!

@googlebot

@googlebot help

@googlebot I signed it!


Set cursor timestamp in Logs Explorer links to the beginning

Set cursor timestamp in Logs Explorer links to the beginning. Normally the cursor points to the end, where the SIGTERM stack traces are.
Minor change. Saves a few clicks.

[ ] grpc/java/v1.61.x/branch/psm-security
[ ] grpc/java/v1.61.x/branch/xds_k8s_lb
[ ] grpc/java/v1.61.x/branch/xds_url_map

Example:

with cursor timestamp: https://console.cloud.google.com/logs/query;query=resource.type%3D"k8s_container"
resource.labels.project_id%3D"grpc-testing"
resource.labels.container_name%3D"psm-grpc-client"
resource.labels.namespace_name%3D"psm-interop-client-20240201-1847-7h1dx"
labels."k8s-pod%2Fdeployment_id"%3D"psm-grpc-client-scvro6y5";timeRange=2024-02-01T18:50:28.431981Z%2F2024-02-01T18:53:18.508354Z;cursorTimestamp=2024-02-01T18:50:37.013234Z?project=grpc-testing

without cursor timestamp: https://console.cloud.google.com/logs/query;query=resource.type%3D"k8s_container"
resource.labels.project_id%3D"grpc-testing"
resource.labels.container_name%3D"psm-grpc-client"
resource.labels.namespace_name%3D"psm-interop-client-20240201-1847-7h1dx"
labels."k8s-pod%2Fdeployment_id"%3D"psm-grpc-client-scvro6y5";timeRange=2024-02-01T18:50:28.431981Z%2F2024-02-01T18:53:18.508354Z?project=grpc-testing


Demo kosmos identify w/ new templates

Redo the example with the old Neon lamp data from 2022, but now using templates created in 2023 and stored within Pykosmos v>=0.3.3
This will require a new reading function to be added to pykosmos!
https://github.com/jradavenport/pykosmos/issues/19

new feature has been added to pykosmos, with the loadarctemplate function. This has been integrated into the notebook


integ tests: Create and remove_linux_bridge

@SvetaHBar please rebase the commit to resolve the conflict.

Looks like this PR commit has been already merged through #252 .


Ignore Stylelint rules in SCSS files

... instead of ignoring them in the Stylelint configuration.
So further violations will pop up!
Lovely 5 line config file 🤩
Please consider doing this in other projects.

I am on the fence with this. Right now just these 4 modification needed?

Right now just these 4 modification needed?

Righty-right!

Let's say you have four violations and one of them is intentional (false positive).
If you ignore a rule in the config file all four will vanish 〰

@szepeviktor not forgotten. After the release of the admin theme (in the next 2-3 weeks), I will come to Spruce (both CSS and UI) for a bigger iteration. Thanks for the reminder!

@adamlaki I am planning to close this on the 4th monthiversary

@adamlaki I would like to contribute again but emotionally blocked my the above ignoring method.

@szepeviktor, you know you are welcome, Viktor. The config - as it is now - was just easier for me, that's all.
What would prettier solve? The alphabetizing? We can ditch stylelint for prettier?

What would prettier solve? The alphabetizing? Can we ditch Stylelint for prettier?

Stylelint v16 dropped formatting features. Those features could be added back by installing Prettier.

Prettier is not easy.
-@mixin generate-table(
-  $selector: '.table',
-  $has-variations: true,
-  $has-responsive-table: true
-) {
+@mixin generate-table($selector: '.table', $has-variations: true, $has-responsive-table: true) {

e.g. I don't know how to prevent this change.
You won't be happy with prettier-ignore comments.

I understand; thanks for the clarification!
Well, the example is not so ideal. We have so much mixin where the line-breaking helps visually. I will try to look into it.


enrich the AWS lambda docs with screenshots

Context:
As we are working towards improving our AWS docs, screenshots are needed to provide visuals on how the dashboard looks like. I re-used the screenshots that were used in the blog post.

@SollyzDev Thanks a lot. I wanted to do this as well. Generally, I would like to use fewer screenshots, but they make sense on this page.
The only thing is that I've added alt text to the images. Please feel free to merge.


Simple get request never returns

The following request never returns:
import requests
r = requests.get('http://en.wikipedia.org/w/api.php?rcprop=ids&format=json&action=query&rclimit=10&rctype=edit&list=recentchanges&rcnamespace=0', headers={'user-agent': 'api test'})

I've tried under both Python 2.7 and Python 3.
Adding a timeout (eg 5 seconds) causes the request to complete successfully - but adds 5s latency to every request.  And, of course, makes the request fail if the API call takes longer than 5s to process.  So I guess what is happening is that the server has finished sending the response but Requests is sat waiting for ... something ... to happen.  What?  Is it possible that the server is sending a wrong content-length?

Sorry, this turned out to be because IPv6 claims to work on my network but doesn't work very well.  Setting a timeout would then cause the IPv6 request to timeout and the request would fall back to IPv4, which succeeds.


trac_ik: 1.5.0-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository trac_ik to 1.5.0-1:

upstream repository: https://bitbucket.org/traclabs/trac_ik.git
release repository: https://github.com/traclabs/trac_ik-release.git
distro file: melodic/distribution.yaml
bloom version: 0.6.6
previous version for package: 1.5.0-0

trac_ik
* Switch to C++-11 threads and pointers instead of Boost

Release repo seems to have all the branches created on this one :+1:


No tracking events called for subsequent ads

Describe the bug
Tracking events called for the first ad only. For the subsequent ads no tracking events are called.
To Reproduce
Steps to reproduce the behaviour:

Initialise the player with multiple preroll ads
Start playback and monitor the network tab of the dev tools
Tracking events are called for the first ads but not for any subsequent ad

Expected behaviour
The tracking events should be called for every single ad.

@adeelmiraj - Can you please confirm if the issue is still reproducible?

Moving the ticket to closed since there is no input from the reporter .

Hi.. I can reproduce this in Chrome and Edge but not Firefox, which works as expected. Demonstration can be made available on request


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v5.15.22",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=b0a7836ecf1345814a7d8ef748fb797c520dad18"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "b0a7836ecf1345814a7d8ef748fb797c520dad18",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "ASoC: ops: Reject out of bounds values in snd_soc_put_xr_sx()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15.22 by commit b0a7836ecf1345814a7d8ef748fb797c520dad18. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000571


Does nebula support the deployment of lighthouse server on server with ipv6 addess only?

Does nebula support the deployment of lighthouse servers on a server with ipv6 addess only?
I've tried to the set a lighthouse server listening on an ipv6 address, but it cannot regonize the address.

The lighthouse can listen on only IPv6 addresses, but the practice is discouraged.
Peers without IPv6 connectivity will not be able to connect to the lighthouse.
For IPv4-only peers to be able to connect to other IPv4 peers with NAT traversal, all peers must connect to the lighthouse over IPv4 (for NAT IP/port discovery.)
That being said, to configure the lighthouse to listen only on its IPv6 address, configure listen.host: "<IPv6-address>" (or listen.host:"" to bind to all local addresses). Then, configure each peer's static_host_map to "<Lighthouse-Nebula-IP>":"[<Lighthouse-IPv6-address>]:4242", assuming you're still using the default Nebula port 4242. (Note the square brackets are needed around the IPv6 address when including the port number - everything between and including the less-than and greater-than should be replaced with your actual IPv6 address.)

@brad-defined Got it. Thanks for the detailed explaination.


Logos pixelate when it's first loading in our hiring network page

Not sure how big of a deal it is, but the logos pixelate when it's first loading

It's an optimization thing, they load in progressively.
On Fri, Mar 1, 2019 at 12:41 PM Kento<EMAIL_ADDRESS>wrote:

[image: screen shot 2019-03-01 at 12 40 12 pm]
https://user-images.githubusercontent.com/45078344/53655812-4fae8180-3c1f-11e9-902c-137a654dd20a.png
Not sure how big of a deal it is, but the logos pixelate when it's first
loading
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/suncoast-devs/web/issues/142, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAABKni2SHmf83bLMbdNLsJ-rXl8xZOwks5vSWZWgaJpZM4bZf8b
.

--
Jason L Perry
CEO at Suncoast Developers Guild
(727) 201-2012
<EMAIL_ADDRESS>


[MINOR] Fix comment about ReplicaFetcherThread

This comment is misleading, as this was fixed during the consolidation of fetcher threads.
The relevant code was removed here https://github.com/apache/kafka/commit/f6890e78687afbbe09ff34b0a9383b548be77ee6#diff-a8437f241a5ae585d5805ee769313080L231-L235 so this comment is out of date.
As this is a comment change, I don't think there's a need for testing.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

From what I can tell, the method is still present in that diff you linked - https://github.com/apache/kafka/commit/f6890e78687afbbe09ff34b0a9383b548be77ee6#diff-2d03a5d4349a23e56c09b4e773055249R121 and is still called in the same places
What changed, actually?

I see what you're saying.  The comment is still wrong, because this is happening in AbstractFetcherThread not ReplicaFetcherthread, but the time is still doubled.

LGTM as well


AreIn broken when single collection given

Due to a change in the constructor to add the boolean flag, now when a single collection is provided, the varargs constructor is used which puts the collection inside another collection:
https://github.com/gchq/koryphe/blob/9ccb3b0ed8e6c45a269b46e4fd2b5fc6f8b8eca9/core/src/main/java/uk/gov/gchq/koryphe/impl/predicate/AreIn.java#L55-L62
Another constructor must be added which can take a single collection

Closed by https://github.com/gchq/koryphe/pull/300


feat(protocol): Genesis / DeployOnL1 with new proxy upgrades

@dantaik @adaki2004  @davidtaikocha  this makes both GenerateGenesis and DeployOnL1 work again, however, TaikoL1 does not work without removing one line of code. It is too big. It is at exactly the kb size limit. So TaikoL1 needs to be refactored.
Here is a screenshot of pnpm run deploy:foundry with removign one line of code from TaikoL1.

However, it will fail in this CICD, until refactored.

@cyberhorsey I made very small changes in this commit, let me know if the code is smaller.
https://github.com/taikoxyz/taiko-mono/pull/15265/commits

@cyberhorsey I made very small changes in this commit, let me know if the code is smaller.
https://github.com/taikoxyz/taiko-mono/pull/15265/commits

Looks like this commit didn't fix the size issue:

@dantaik after merging proxy base back into his branch, tests fail again on TaikoGovernor init function in deploy script. I'll take a look at it tonight.

@dantaik after merging proxy base back into his branch, tests fail again on TaikoGovernor init function in deploy script. I'll take a look at it tonight.

i'm looking into it too

OK, looks good, I will merge now.


Unknown Agent: "structured-chat-zero-shot-react-description" Error

Getting a value error when trying to use the structured agent.
ValueError: Got unknown agent type: structured-chat-zero-shot-react-description. Valid types are: dict_keys([<AgentType.ZERO_SHOT_REACT_DESCRIPTION: 'zero-shot-react-description'>, <AgentType.REACT_DOCSTORE: 'react-docstore'>, <AgentType.SELF_ASK_WITH_SEARCH: 'self-ask-with-search'>, <AgentType.CONVERSATIONAL_REACT_DESCRIPTION: 'conversational-react-description'>, <AgentType.CHAT_ZERO_SHOT_REACT_DESCRIPTION: 'chat-zero-shot-react-description'>, <AgentType.CHAT_CONVERSATIONAL_REACT_DESCRIPTION: 'chat-conversational-react-description'>]).

Please provide working code that can reproduce this issue.

import os
os.environ["OPENAI_API_KEY"] = "XXXXXXXXXXX"
from langchain.llms import OpenAI
import os
os.environ["LANGCHAIN_TRACING"] = "true" # If you want to trace the execution of the program, set to "true"
from langchain.agents import AgentType  # Replace this import statement according to your project structure
from langchain.agents import AgentType
from langchain.chat_models import ChatOpenAI
from langchain.agents import initialize_agent
from langchain.agents.agent_toolkits import PlayWrightBrowserToolkit
from langchain.tools.playwright.utils import (
create_async_playwright_browser,
create_sync_playwright_browser, # A synchronous browser is available, though it isn't compatible with jupyter.
)
This import is required only for jupyter notebooks, since they have their own eventloop
import nest_asyncio
nest_asyncio.apply()
async_browser = create_async_playwright_browser()
browser_toolkit = PlayWrightBrowserToolkit.from_browser(async_browser=async_browser)
tools = browser_toolkit.get_tools()
llm = ChatOpenAI(temperature=0) # Also works well with Anthropic models
agent_chain = initialize_agent(tools, llm, agent=AgentType.STRUCTURED_CHAT_ZERO_SHOT_REACT_DESCRIPTION, verbose=True)
response = agent_chain.arun(input="Hi I'm Erica.")
print(response)

i'm using the latest version of langchain.
yes it's the newest agent i'm wanting to test out.
When i print out agent types it shows the new structured tool agent is there.
to get await working in put it in that function down the bottom of the code.
any ideas?

tried multiple fixes, still getting "AttributeError: STRUCTURED_CHAT_ZERO_SHOT_REACT_DESCRIPTION"

did you get the fix, am also getting same problem


FIX: fetch-mock Response.body is not always a stream

The WhatWG fetch spec requires that Body.body (and therefore Response.body) is always a readable stream, but it doesn't always happen that way in Node. This seems to be because ResponseBuilder tries to fetch the stream module from fetchMock, but it looks in the wrong place.
Fixes #609.

The CI check that shows failure if code is similar in test cases is not fun.

I've fixed all the issues I can find. I can't access the circleci tests to see what it's complaining about.

In the latest fetch-mock@10 I just use native fetch and I think all these issues should now be resolved.
Thanks for working on this, and apologies for the very slow response.


[TypeReconstruction] Fix reconstruction for VarDecls.

We were previously asserting on the following tree:
kind=Global
kind=Variable
kind=Module, text="EyeCandySwift"
kind=PrivateDeclName
kind=Identifier, text="_ADC08935D64EA4F796440E7335798735"
kind=Identifier, text="_previousUniqueNumber"
kind=Type
kind=Structure
kind=Module, text="Swift"
kind=Identifier, text="UInt64"
rdar://problem/39283527

@swift-ci please test and merge


Create a landing page

Blocked by https://github.com/jduong09/gitcoding/issues/1 (react boilerplate)
Blocked by https://github.com/jduong09/gitcoding/issues/2 (node/express server)
Backend

Create a GET route for the landing page

Frontend

Create a landing page UI
This will eventually require(?) authentication before proceeding

The landing page will include a sign-in button, which will route the user to a login page correct? And then after logging in, the user will be directed to the app with their content correct?

Yah, I think that's the move. At least for now. I think eventually we would want more of a landing page with info about the app to entice the user to want to use it/create a profile. but for now, that simple call-to-action button should suffice

Things to do for this ticket:

[ ] When navigating to the base '/' route, show a sign-in button if the user has not logged in yet
[ ] After logging in, show the "homepage" (this is where we'll add all our content)

[ ] Display a logout button (should only show this button when a user is already logged in)

[ ] Clean up all that boilerplate create-react-app code (we can get rid of it now)
[ ] Comment out or remove the "click me" and "create user" buttons. We'll want to create a separate ticket with database schema functionality to better fit out needs


Updated django.md

I tried following this but kept receiving ModuleNotFoundError: No module named 'composeexample' error. This seems to have been happening because manage.py was inside the folder composeexample, so prefixing the manage.py from python manage.py runserver worked.
(furthermore, I think this should be another ticket, but after solving this I received psycopg2.OperationalError: FATAL:  the database system is starting up and this answer on stackoverflow solved it).

I noticed that I might've ran python manage.py startproject composeexample instead of python manage.py startproject composeexample ., which seems to have created the problem in the first place.


Synchronous Pull problem

I run this code every minute to test API, what I expected, the first time I should get messages about the new and edited review, then for this subscriber, this messages will be acknowledged, and during next iteration I got nothig

but every iteration I get the same message

I faced this issue today, for example, earlier acknowledge function work properly and I got message only one time
In the same time I try to get notification about another review adding/changing but get nothing, maybe this stuck message break the queue

Taking a closer look at this, it's possible that between the time you run the publisher and the subscriber, it's timing out and retrying delivery of the message, which would go into the same topic. Do you get similar results if you run them consecutively? Like:
./publisher && ./subscriber

(I mean, conceptually, because your files are no doubt different.)
I believe it's possible to adjust that ack timeout if that's the issue.

Taking a closer look at this, it's possible that between the time you run the publisher and the subscriber, it's timing out and retrying delivery of the message, which would go into the same topic. Do you get similar results if you run them consecutively? Like:
./publisher && ./subscriber

(I mean, conceptually, because your files are no doubt different.)
I believe it's possible to adjust that ack timeout if that's the issue.

can't understand what do you mean saying, run publisher and subscriber, as I understand we have publisher it is the service that create messages when review changed or created, then we created subscriber, then I posted or changed some review, using this subscriber profile (if we can call it like this) I tried to get messages about my actions, as I expected I should get message only one time then acknowledge the message and it should be deleted from queue for this subscriber, but i got the same message every time, it seems wrong,  today I riun the code to check will get I something or not, I got nothing although I know for sure that recently some review was changed, is it bug or I make something wrong

@Zimovets I was wondering if this is still a problem for you.
To clarify my last comment there, the default ack extension timeout is pretty short by default. So if you push a lot of messages onto a topic (which has a subscriber) and aren't reading them off that subscriber relatively quickly, they can end up being redelivered. So you might end up with N copies of the same message.
@kamalaboulhosn Double-checking, does my comment make sense in your understanding of the Pub/Sub service?

I'm going to go ahead and close this for now for lack of comments, but please feel free to comment/re-open if needed.


Class not made for 201 Payment Created response

#Issue Summary
The deserialization of the AccountCapturePaymentResponse Object has the field twoHundredAndOneApplicationJsonPayment but not the type making it (unable) to access the information in the object with PHP. Not sure if there is a way to access the info without declaring a type for it. See https://github.com/speakeasy-sdks/exactpayments-php/blob/main/docs/Models/Operations/AccountCapturePaymentResponse.md same could be said for the CapturePaymentResponse object.

Found out it gets parsed as an array and the information inside can be accessed like any associated array.
$response->twoHundredAndOneApplicationJsonPayment["$KEY"]
Usable but I think it should still be fixed 🙂


Not initialize in nuxt js

Hi
Looks like tinymce wasn't found
Make sure that tinymce available as global variable
You can listen for error with @error="yourLogMethod" and see the error message
Regards


[Feature Request] - Creating Backups Don't Include Anime in your library

[ App version: <IP_ADDRESS>-mi ]
Creating a backup does not include the Anime section of your library.

I think this should be priority. The app doesn't last even a day (crash on launch), so it needs to be reinstalled every time (data gone).

Even on the latest version it's still a big for me


dispatch(push('/bla') builds nonsense URL AND does not redirect

My .env file contains
PUBLIC_URL=http://mywebsite/my/subproject

In my actionCreators, I have some action that uses fetch to retrieve data from a WebAPI. I want to redirect the user to the login page when a 401 occurs.
fetch(process.env.WEB_API_URL + 'SomeResource', requestOptions)
	.then(response => {
		if (response.ok) {
			return response.json() as Promise<Something[]>
		} else {
			switch (response.status) {
				case 401:
					console.log(`Unauthorized (status=${response.status}), redirecting to login.`);
					dispatch(push("/loginpage"));
					break;
			}

			throw new Error(response.statusText);
		}
	})
	.then(data => {
		// Process the data if 200 OK
	});

Two issues:

My URL is changed to http://mywebsite/http://mywebsite/my/subproject/loginpage. This should have been http://mywebsite/loginpage
And also, the page is not reloaded. I stay on the old page even though the URL changes.

I'm also seeing issues using dispatch(push(...));, but my console prints out
Uncaught (in promise) Could not find router reducer in state tree, it must be mounted under "router"

Same here as @codyseibert

Nevermind, I got mine working.  It looks like I was accidentally using the  and  at the same time...

@codyseibert can you create a gist with a minimal example? Thanks

I had the same issue and I had two problems:

As @codyseibert mentioned, I was using ´BrowserRouter´ and ´ConnectedRouter´ at the same time, for this, you can look up the example on the readme or the examples on the code
I was using ´history´ on its version ´5.0.0´, and it was messing with the ´LOCATION_CHANGED´ action, downgrading it to ´^4.9.0´ fixed the issue.

I hope this helps.

I had the same issue and I had two problems on my code:

As @codyseibert mentioned, I was using BrowserRouter and ConnectedRouter at the same time (@efstathiosntonas, for this, you can look up the example on the readme or the examples on the code)
I was using the history package on its version 5.0.0, and it was messing with the LOCATION_CHANGED action, downgrading it to ^4.9.0 fixed the issue.

I hope this helps.

thank @piedrahitapablo  I resolve the page update and that working.
that's my dependencies
"history": "^4.9.0",
"react-router-dom": "^5.2.0",
"connected-react-router": "^6.8.0",
"redux": "^4.0.5",
"redux-saga": "^1.1.3"
The package all lastest version for my project without history, it downgrading to 4.9.0.

Thanks @piedrahitapablo history: '5.0.0' was the issue, downgrading to 4.9.0 automagically got it fixed and the Uncaught (in promise) Could not find router reducer in state tree, it must be mounted under "router" was gone.

@efstathiosntonas This is due to React Router v5 doesn't support history v5.
When adding history v5, I expect it should show a warning like
<EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>React Router v6 will use history v5.


Update README.md

Kestrel is not (only) libuv-based anymore :)

@fgreinacher,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


changing permission request to later + My Contribution :)

First and foremost, THANK YOU for providing this.
Currently, when I start the app, it'll ask for permission to access files. Due to the following line in onCreate:
if (ASWP_FUPLOAD) {
                if (ContextCompat.checkSelfPermission(this, Manifest.permission.WRITE_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {
                    ActivityCompat.requestPermissions(MainActivity.this, new String[]{Manifest.permission.WRITE_EXTERNAL_STORAGE}, 2);
                }
}

This doesn't make sense unless the app's entire purpose is to upload files. Otherwise, it'll confuse the user as to why the app is asking for permission. is it possible to move this request to After the user clicks Browse in an upload form?

And here is my tiny contribution, which will help the shouldOverrideUrlLoading method work on both new as well as old SDKs
//Overriding webview URLs
		@SuppressWarnings("deprecation")
        @Override
        public boolean shouldOverrideUrlLoading(WebView view, String url) {
            boolean a = true;

           *******
        }

		@TargetApi(Build.VERSION_CODES.N)
		@Override
		public boolean shouldOverrideUrlLoading(WebView view, WebResourceRequest request) {
			String url = request.getUrl().toString();
            boolean a = true;
			*******
		}

Ghazi, is there a simple fix for this? I tried copy & pasting that line of code (ActivityCompat.requestPermissions()) with no luck.

Thank you for the contribution and suggesting for change in permissions Jake.
I've updated the codes and now you'll be able to handle permissions wherever you want with a new simple permission checker method introduced in the script.
Also, by default, permissions will be asked only when needed. ACCESS_FINE_LOCATION is onCreate as required, WRITE_EXTERNAL_STORAGE and CAMERA only when FileChooser method shoots.
Don't forget to tell me what you made of it.

First and foremost, thank you for your prompt reply!
I've updated the code and here is how it currently executes:
Step 1. I browse to the upload page inside the app
Step 2. Click Browse
Step 3. File Chooser pops up
Step 4. I select image
Step 5. Then it asks "app would like to access your files". (instead of at step 2)
I think this may be an issue with not the code, but the Android Emulator I'm using. I'm going to submit the app to Google Play and test on a real device. Will update you soon!

Works Great! Cheers.


The window script set CLASSPATH should not traverse all liBs. This causes the command line to be too long and fail to start

Current Behavior

The window script set CLASSPATH should not traverse all liBs. This causes the command line to be too long and fail to start

this maven appassembler-maven-plugin script

The CLASSPATH script is changed to the path. The classpath script starts normally

Expected Behavior
Windows can start normally
Context (optional)
No response
Steps to Reproduce

Distributing springboot
Start-up project

Gradle version
8.8
Build scan URL (optional)
No response
Your Environment (optional)
No response

We appreciate the effort, but we must ask for more information so that we can triage it.
We do not see an immediate root cause, and we need a minimal reproducible example for the triage. If we have a reproducer, we may be able also to suggest workarounds or ways to avoid the problem.
The ideal way to provide a reproducer is to leverage our reproducer template. You can also use Gradle Project Replicator to reproduce the structure of your project.
This issue will be closed after 7 days unless you provide more information.

Screenshots are hard to investigate; please provide a proper reproducer.
Related:

https://github.com/gradle/gradle/issues/5754
https://github.com/gradle/gradle/issues/21712


STARTPAGE Permalink Handler intercepts parameterless URL

Its common in MVC for the default route to have a default Home/Index pattern to deal with a parameter-less URL call. Piranha registers an HttpHandler using
Handlers.Add("", "STARTPAGE", new PermalinkHandler());
Which maps all parameter-less URLs to a permalink handler for StartPage. The declared defaults on the MVC routing table are bypassed by this.
Request to make this re-routing optional (perhaps web.config driven, or by dynamic examination of the MVC routing table)

The handler for the startpage can be removed from your application startup code (Global.asax.cs) with the following line:
Piranha.Application.Current.Handlers.Remove("STARTPAGE");

Works great, thankyou.


Missing 'next-intl/plugin

Description
Hi,
I followed tutorial on your homepage to try server components (dynamic rendering).
When I try to start nextjs, there is an error saying that 'next-intl/plugin' is not missing.
- error Failed to load next.config.js, see more info here https://nextjs.org/docs/messages/next-config-error Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './plugin' is not defined by "exports" in \node_modules\next-intl\package.json     at new NodeError (node:internal/errors:372:5)     at throwExportsNotFound (node:internal/modules/esm/resolve:472:9)     at packageExportsResolve (node:internal/modules/esm/resolve:753:3)     at resolveExports (node:internal/modules/cjs/loader:482:36)     at Function.Module._findPath (node:internal/modules/cjs/loader:522:31)     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:27)     at \node_modules\next\dist\server\require-hook.js:113:36     at Function.Module._load (node:internal/modules/cjs/loader:778:27)     at Module.require (node:internal/modules/cjs/loader:1005:19)     at require (node:internal/modules/cjs/helpers:102:18) {   type: 'Error',   code: 'ERR_PACKAGE_PATH_NOT_EXPORTED' }
Mandatory reproduction URL (CodeSandbox or GitHub repository)
#starter-template
Reproduction description
Use with starter template.
Expected behaviour
It should work.

Ah sorry, I installed wrong version, need to install beta version.


Carousel is not working in Facebook - BOT - Nodejs - Reg.

Hello Steve,
The carousel is not working in Facebook, and I am getting the below error:
Facebook graph API call failed with: BadRequest {"error":{"message":"(#194) param message[quick_replies] has too few elements.","type":"OAuthException","code":194,"fbtrace_id":"COhgOFiKq6h"}}
Could you please help here to resolve it .
My bot id: VZEntBot (Node js) version.
Regards,
Giri G.

Just a shot as per my experience on node bot card...
Just check length on title , subtitle valid url  in images and tab...Make sure they are not longer then guidelines provided by Facebook. Try by test data...

I have a proper title length and images...Still it is not coming up.
Steve, Could you please review my code and let me know....I have to present to my next level about this carousel piece.
Appreciate your help here.
Regards,
Giri G.

One issue I get into is that HeroCards MUST all have the same size (aka components) on Facebook. For instance you can't have a card with a button and an other without in the carousel

@giriganapathy would you be willing to share the carouselArr?
I can try to repro with your specific code/values

@giriganapathy sorry for the delay. did you get this figured out?