Bug with the new version

Describe the bug
In the new version the plugin is disabled
How to reproduce
In the new version the plugin is disabled
Screenshots / Videos

Server Log
https://pastebin.com/ziu6Egrv

This issues page is for AdvancedSeaons.
https://github.com/AdvancedPlugins/Jobs


Unsorted Loading Issue

Feature Request
As a peoplemover user
I would like my space to load better
so that I am not confused by the flash of my unsorted/unfiltered space before it appropriately loads
Acceptance Criteria
We need to discuss the solution before I can outline the acceptance criteria

If I do A B should happen

Notes
Space data is stored in database in unsorted fashion. As soon as we get response back, we draw it on page, we apply filtering and sorting to it. And then it is rendered a second time the way it should be.
What is the solution for this? Loading icon? Way to sort on the page?

Dev Options to solve:

Do nothing, it's not that bad (No time spent until we need to hit sort/filter again. Tech debt remains)
Rethink sort/filter and state storage, do a full refactor (Large estimate, tech debt largely addressed)
Keep trying to find the quick fix (Unclear how long this would take. Tech debt remains)


Adding methods to prototypes of Element, Node, etc.

Hi there,
I've just started experimenting with jsdom (moving our repo away from domino).  We'd previously added some extensions to domino's Element, Document, Window and other classes, and I'm trying to port those extensions to the jsdom equivalents of those classes.
One key thing is that I would need to define a new method on, for example, the Element prototype, and then have all the subclasses get that new method on their prototypes as well.
I haven't come up with a great approach so far, but here are the ideas that I've come across and why I'm not excited about them:

Send a pull request to jsdom with the updates.

Cons:

Some of the extensions we've built are not fully-baked, and fully-baking them would take more effort than I'm willing to invest at the moment.

Fork a local version of jsdom

Cons:

Makes subsequent version updates much more painful.
Just feels wrong.

For any class (like Element) where I want to add a new prototype method, iterate over all the children and define a prototype method on them.

Cons:

Tedious code.
Just feels wrong.

Stick with domino

Cons:

Domino is failing us for other reasons, and although we've made a fix there, upgrading to the latest version appears to disrupt configurability (like setting a different user agent for a particular test).

Would love suggestions on how to tackle this.  Thanks in advance!
Tim

For any class (like Element) where I want to add a new prototype method, iterate over all the children and define a prototype method on them.

Why would you need to iterate over all children? If it's not defined on a child-class, it'll search the prototype chain upwards until JS finds such a method.

Sorry.  This is probably due to my ignorance of JavaScript.  I just did a simple example and it worked exactly as you described, so I must have had a coding error somewhere.  I will report back if it's anything worth reporting.

Turns out the issue is the Object.create() calls at the start of the generated files.  For example, in the generated HTMLElement.js file:
HTMLElement.prototype = Object.create(Element.interface.prototype);
The Object.create, as I understand it, creates a copy of the Element prototype (and that copy will have references to the original Element.prototype functions).
Because of this, the search of the prototype chain will search up these copies created by Object.create, which means anything added to, say, Element.prototype after the Object.create call will not be found.

That's not true.
Can you give a small ten line example that works in browsers but not in jsdom?

Yeah, turns out it was PEBKAC.  I was actually redefining a method that already existed (focus) in an intermediate subclass (HTMLElement) that I missed when I was looking for the definition in HTMLDivElement and Element.  My apologies for the distraction and my confusion.


Error with valid and fake tensors

I am trying to run the code to apply to a new dataset, however when attempting to run the code to make sure it was working correctly (training on the vimeo 90k dataset), I had some errors.
When running the code I get an error with the valid and fake tensors, when attempting to train a model on a small subset of the data. Can you help? Furthermore, there were a few errors in the code that had to be fixed (missing imports etc.). Is there a more up to date version of the code that has not been pushed that does not include these errors?
Thanks in advance for your help
Traceback (most recent call last):  File "/home/FI-DUSGAN/train.py", line 277, in <module>    main()
File "/home/FI-DUSGAN/train.py", line 270, in main    epoch, g_loss, d_loss = train(cur_gen_epoch, dataloader)
File "/home/FI-DUSGAN/train.py", line 185, in train    gen_imgs, real_loss, fake_loss, g_loss, adv_loss = _train_interval(in_pres, in_lats, gt, 1)
File "/home/FI-DUSGAN/train.py", line 108, in _train_interval    real_loss = adversarial_loss(gt_distingue, valid)
File "/opt/conda/envs/mlp/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl    return forward_call(*input, **kwargs)
File "/opt/conda/envs/mlp/lib/python3.9/site-packages/torch/nn/modules/loss.py", line 720, in forward    return F.binary_cross_entropy_with_logits(input, target,
File "/opt/conda/envs/mlp/lib/python3.9/site-packages/torch/nn/functional.py", line 3160, in binary_cross_entropy_with_logits

raise ValueError("Target size ({}) must be the same as input size ({})".format(target.size(), input.size()))ValueError: Target size (torch.Size([20, 1, 1, 1])) must be the same as input size (torch.Size([20, 1, 5, 11]))

Thank you for your interest in my work and your reminder. This issue might be caused by the unexpected size of the training sample. With this version, the discriminator supports input with a resolution of 128x128 only (fitting the Vimeo-90k dataset).
I will make a quick fix on this and the other issues.

All the modifications have been committed after the successful local test.

Closing the issue with no more comments.

Thanks for your help!


Trouble using fastlane / sigh on multi-user system

Hello,
I'm starting to work with fastlane on a Jenkins installation. I noticed that if something fails or is still in progress with one user (AKA the jenkins user), another user (AKA my user on the same box) cannot use fastlane due to the following error:
/Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.7.6/lib/fastlane_core/developer_center/developer_center.rb:44:in `initialize': Permission denied - /tmp/fastlane_core//poltergeist_log.txt (Errno::EACCES)
	from /Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.7.6/lib/fastlane_core/developer_center/developer_center.rb:44:in `open'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.7.6/lib/fastlane_core/developer_center/developer_center.rb:44:in `block in initialize'
	from /Library/Ruby/Gems/2.0.0/gems/capybara-2.4.4/lib/capybara/session.rb:79:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/capybara-2.4.4/lib/capybara/session.rb:79:in `driver'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.7.6/lib/fastlane_core/developer_center/developer_center.rb:50:in `initialize'
	from /Library/Ruby/Gems/2.0.0/gems/sigh-0.5.2/lib/sigh/manager.rb:6:in `new'
	from /Library/Ruby/Gems/2.0.0/gems/sigh-0.5.2/lib/sigh/manager.rb:6:in `start'
	from /Library/Ruby/Gems/2.0.0/gems/sigh-0.5.2/bin/sigh:36:in `block (2 levels) in run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/command.rb:153:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/runner.rb:428:in `run_active_command'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/runner.rb:68:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/delegates.rb:15:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/sigh-0.5.2/bin/sigh:67:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/sigh-0.5.2/bin/sigh:74:in `<top (required)>'
	from /usr/bin/sigh:23:in `load'
	from /usr/bin/sigh:23:in `<main>'

The following file exists and is owned by another user:
/tmp/fastlane_core//poltergeist_log.txt
Perhaps this is a configuration problem, but it would be helpful to have some documentation around resolving that if it is.

I haven't seen this error before. It seems to be a poltergeist error and has nothing to do with fastlane directly. Also, I never used fastlane in a multi-user environment. Let me know if you found a good solution for it.
You'll be glad to hear, within the next weeks/months fastlane will get rid of the poltergeist dependency :+1:

Just remove the fastlane_core folder from temp as a superuser. It'll be rebuild. It's because you used fastlane with a different user than the jenkins user and the jenkins user has no write permissions to this folder.

I noticed almost the same problem with sigh, even if it is no longer running. sigh creates a file named /tmp/spaceship.log and when you run it again with another user, it will complain that it cannot write to that file.
The solution would be not to hardcode any /tmp paths but to create a unique folder in tmp (cf. mktemp).

@nschum Technically it wouldn't be a problem to use a real Ruby temp file, but this wouldn't make it easy for the user to find and read it. The advantage of the current solution is that the user can just always open /tmp/spaceship.log and see the log lines of spaceship
What do you think? Maybe something like /tmp/spaceship#{Time.now.to_s}?

:+1: Maybe Time.now.iso8601 to avoid spaces.

@nschum sorry, I meant Time.now.to_i :wink:
Would that be a reasonable solution for you?

Sure.

This is now implemented and will be available with the next version :+1:

@KrauseFx think this is still broken, I just had to clear out /tmp/spaceship_api_key.txt :(

@KrauseFx this still exists, there's some issues with how the certificates are trying to be loaded on a multi-user system, I'm still getting build errors too:
[09:24:27]: ------------------
[09:24:27]: --- Step: sigh ---
[09:24:27]: ------------------
[09:24:27]: Starting login
[09:24:28]: Successfully logged in
[09:24:28]: Fetching profiles...
[09:24:31]: Found 1 matching profile(s)
[09:24:31]: Downloading provisioning profile...
[09:24:31]: Successfully downloaded provisioning profile...
[09:24:31]: Installing provisioning profile...
security: cert import failed: write permissions error
security: problem decoding
[09:24:31]: Variable Dump:
[09:24:31]: {:DEFAULT_PLATFORM=>:ios, :ENVIRONMENT=>nil, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios adhoc", :GIT_REPO_WAS_CLEAN_ON_START=>true}
[09:24:31]: undefined method `count' for nil:NilClass

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
| 3    | ensure_git_status_clean             | 0           |
| 4    | sigh                                | 3           |
+------+-------------------------------------+-------------+

[09:24:31]: fastlane finished with errors
/Library/Ruby/Gems/2.0.0/gems/sigh-0.10.3/lib/sigh/profile_analyser.rb:7:in `run': undefined method `count' for nil:NilClass (NoMethodError)
	from /Library/Ruby/Gems/2.0.0/gems/sigh-0.10.3/lib/sigh/manager.rb:36:in `install_profile'
	from /Library/Ruby/Gems/2.0.0/gems/sigh-0.10.3/lib/sigh/manager.rb:20:in `start'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/actions/sigh.rb:20:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/runner.rb:142:in `block (2 levels) in execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/actions/actions_helper.rb:62:in `execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/runner.rb:128:in `block in execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/runner.rb:127:in `chdir'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/runner.rb:127:in `execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/fast_file.rb:120:in `method_missing'
	from (eval):23:in `block (3 levels) in parse'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/lane.rb:29:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/lane.rb:29:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/runner.rb:50:in `block in execute'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/runner.rb:44:in `chdir'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/runner.rb:44:in `execute'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/lane_manager.rb:36:in `cruise_lane'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/lib/fastlane/command_line_handler.rb:31:in `handle'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/bin/fastlane:35:in `block (2 levels) in run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/command.rb:153:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/runner.rb:428:in `run_active_command'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/runner.rb:68:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.4/lib/commander/delegates.rb:15:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/bin/fastlane:124:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.14.1/bin/fastlane:130:in `<top (required)>'
	from /usr/bin/fastlane:23:in `load'
	from /usr/bin/fastlane:23:in `<main>'

So the really TLDR; of this is Codesigning via Jenkins is REALLY hard to get right. It seems sometimes it'll just 'work' but most of the time it'll just fail. My solution was to:

Ensure Jenkins is running with a user session, so default keychains are mounted
Create a custom codesign.keychain in ~/Library/Keychains and ensure this keychain is the top in the left hand list of keychains in Keychain Access.
If you right-click on the codesign keychain and change settings set the Lock After to 60 minutes, save then change settings again and uncheck the Lock After.
In Jenkins before running fastlane add below bash script:

# keychain
security -v list-keychains -d system -s ~/Library/Keychains/codesign.keychain
security -v unlock-keychain -p $CODESIGN_KEYCHAIN_PASSWORD ~/Library/Keychains/codesign.keychain

@robertjpayne what does the first point mean exactly?

OK I found out. for me this simply meant mv /Library/LaunchDeamons/org.jenkins-ci.plist /Library/LaunchAgents/org.jenkins-ci.plist and reboot (more info on this on https://nickcharlton.net/posts/installing-jenkins-osx-yosemite.html)

@stefreak Really glad to hear you got up and running! 👍


What about AUTOINCREMENT for integer keys??

One feature I rely on is the AUTOINCREMENT feature, and I can't find any support for that in the documentation. Is it there? I hate to have to create my table definition uses SQL strings just for that.

It's there: https://github.com/stephencelis/SQLite.swift/commit/798ee8eb9ba3f637031d0099bc792caac4a1a458

OK, after reading the AUTOINCREMENT description again, apparently it's got high overhead and is usually unnecessary and the default behavior is sufficient, probably for my needs.  I will try it out without autoincrement and then use it if necessary.  BTW: GREAT job on this API.  Really fantastic/prodigious, timely, convenient, complete, etc...  major kudos.

Yep, avoid AUTOINCREMENT unless you really need it!
And thanks! Glad you like it :)

Yes. Compared to ugly libsqlite and Objective C which I used to use, this is far cleaner, makes easier to read more maintainable code, and it actually works!

Stephen Celis is the man.
On Fri, Jan 30, 2015 at 12:40 PM, reflectivist<EMAIL_ADDRESS>wrote:

Yes. Compared to ugly libsqlite and Objective C which I used to use, this
is far cleaner, makes easier to read more maintainable code, and it
actually works!
—
Reply to this email directly or view it on GitHub
https://github.com/stephencelis/SQLite.swift/issues/55#issuecomment-72239593
.

:blush:


Remove timeout option

What is the purpose of this pull request?

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:

What changes did you make? (provide an overview)
Removed the timeout option and updated the migration guide.
Which issue (if any) does this pull request address?
Fixes https://github.com/node-fetch/node-fetch/issues/523

For some reasons my email reply to issues/PRs are no longer getting through, so add it again:

This PR has the same level of risk as removing browser export, please make sure at least 3 reviewers have approved it before merging.

The timeout signal modular appear to be the main alternative after deprecating timeout, I suggest moving it to node-fetch org and adding extra npm owners to ensure maintenance.

The documentation shouldn't just say we deprecate it because of  "non-standard", while this is a part of our reasoning, the main reason is something like "Abort Signal offers more finegrained control of timeout, and is standardized in Fetch spec. For convenience, we provide a timeout signal as a simple replacement for users upgrading from v2".

Should #810 be merged first, to keep changes to typing in this PR?

Again, here Coveralls Coverage decreased by -0.01%

@NotMoni This is not a big deal here, once we merge #829 the coverage will raise, as it also includes the updated ignore comments.
We might want to try and bring the coverage back to a full 100% soon.

@tinovyatkin Yes, I think so.

@NotMoni This is not a big deal here, once we merge #829 the coverage will raise, as it also includes the updated ignore comments.
We might want to try and bring the coverage back to a full 100% soon in a separate PR.

Yea, coverage to 100% will be good to do.

This will be a very painful breaking change for may libraries that depends on node-fetch, as it will require to introduce abort-controller as dependence. Maybe we should just deprecate timeout in 3.0 and remove it in the next major?

@tinovyatkin It would, but only for people, who actually want to use this feature. So the others would benefit, as the "core" node-fetch package would not include it.

@xxczaki I mean, I believe that it will be too hard to implement vs a desire to just stick with 2.x version. For example, gaxios by Google is using node-fetch and even has abort-controller as a dependency, but only to declare types:
https://github.com/googleapis/gaxios/search?q=abort-controller&unscoped_q=abort-controller
So, now they will need to decide whether to drop timeout parameter on their side and release new major of gaxios or implement their timeout via AbortSignal or just pin the dependency on the latest 2.x version of node-fetch until they will have the bandwidth to deal with it.
gaxios engine requirement is already 10.x, so, actually that will be the only breaking change for them...

pls fix merge conflict with TS Typing before we can merge
cc/ @Richienb

This will be a very painful breaking change for may libraries that depends on node-fetch, as it will require to introduce abort-controller as a dependency

For what it's worth, I use node-fetch heavily in the @octokit libraries, and I allow to pass a signal option to each request, which can be set using an AbortController instance. I do not need to add abort-controller as a dependency, it's up to the integrator to add that if they need to.


chore(api-reference): unify @scalar/snippetz and httpsnippet-lite API

WIP
This is a follow up to #2899, which adds a helper method to get code example from @scalar/snippetz and httpsnippet-lite without caring which comes from which package.
I’ve chosen to not add httpsnippet-lite to @scalar/snippetz and add a meta helper on top of both. Eventually, we’d like to get rid of httpsnippet-lite and I’d prefer to keep @scalar/snippetz light-weight. :)
Note: This is not used yet, I’m waiting for movement in #2825. Once that’s completed, I’ll replace the actual code with the new helper.
Wdyt?
Tasks

[ ] Get rid of the httpsnippet-lite HarRequest type

Great feedback! I’ll do another round next week. ✌

Cool, let’s get this in! :) I’ve more ideas to improve this and get less reliant on httpsnippet-lite, but that’s for another PR I guess. :)


Define constants for rules operators

We have several operators defined in rules.go that are reused in sampler_config.go for datatype matching. It would be a good idea to define constants for these operators to keep both places on consistent. The list as it stands seems to be.
"exists"
"not-exists"
"!="
"="
 ">"
">="
"<"
"<="
"starts-with"
"contains"
"does-not-contain"

Figure out id there any that are missing and define them in rules.go.

Closed by #813


Memory Leak

This is pretty cool, to have socks 4/5 in one file, but if you use it with Firefox (or Chrome), the connections never get closed, so opening 5 pages eats up all ram and the proxy server becomes unresponsive.

Yes, it's not very stable yet. Its not meant to be a production tool but rather a quick hack to get through firewalls. I am trying to improve it though.
I have noticed different behaviors depending on the OS and browser. It worked the best with Windows 10 and FoxyProxy.
HTTP is never going to be perfect with this as multithreading in power shell in really inefficient. SSH and RDP work much better as examples.

Detecting end of data and closing the connection would be a good place to start. It uses a lot of CPU, RAM and it loads relatively slow, but it's OK. Because the CPU does finish processing and the pages do load in the end. The fact that it uses a lot of memory is fine too, for what it is, and at this stage, but let's release the memory when it's no longer needed. There is some code in place that checks client.Connected && server.Connected (or similar), but the client object must be reporting as connected, because the script never closes connections, even when I close the browser. I will try FoxyProxy, but I doubt the connections will close.

The script will close the connections when either the client or the server does it. It works most of the time.

Looks like the issue is related to a while loop. I was able to use the script successfully by changing it to:
$count= 0
while($client.Connected -and $tmpServ.Connected -and $count -lt 100) {
    sleep -m 100;
    $count = $count + 1
}

I'm not going to do a pull request because I don't really know what the loop is doing...

The loop is checking if the client and server are still connected. The script is supposed to disconnect both once one of them closes the connection. Sadly it does not always work and I do not know why.
Your solution works and will be valid for HTTP type protocols, however, if users are using the socksproxy for a statefull protocol such as RDP or SSH, the connection will be disconected after 10 seconds.

Improved performance and fixed the memory leak.


addressing java migration technical debt

JIRA: https://companieshouse.atlassian.net/browse/JU-528

upgrading Spring Boot to 3.3.2
upgrading dependency versions
replacing wildcard imports
implementation of new suppressions method

CI: No security warnings found

CI: No security warnings found

CI: No security warnings found


More details about RNN-T results.

Hi wenet team,
I want to know more details about the RNN-T result.
Just list the last table here:

rnnt
ctc
att
greedy
beam
rescoring
fusion

✔
✔
✔
4.88
4.67
4.45
4.49

✔
✔

5.56
5.46
/
5.40

✔

✔
5.03
4.94
4.87
/

✔

5.64
5.59
/
/

✔
✔
4.94
4.94
4.61
/

My question is:

What is ctc beam search used in here? I noticed there's a ctc header inside transducer module. Are you using T's encoder only and CTC header for decoding?
Compare with CTC only result on Conformer, CTC is better with attenstion rescoring, right?
Is "Fusion" decoding with LM? Is that LM a TLG graph or just BPE level LM?

1 there are three losses in wenet-rnnt training style。 So you can also ues ctc + rescoring
2
3 fuison here means ctc probs fusion with transducer when decoding ， not with lm

Do you have Conformer-RNNT results on Librispeech? Do they match the numbers from the Conformer paper? Thanks.

please see https://github.com/wenet-e2e/wenet/tree/main/examples/librispeech/rnnt, the result is far behind the conformer paper. Maybe @yuekaizhang could show more details.

please see https://github.com/wenet-e2e/wenet/tree/main/examples/librispeech/rnnt, the result is far behind the conformer paper. Maybe @yuekaizhang could show more details.

@ruomingp  This link's model size is about 34Mb. For mid size model in conformer paper, they got 2.3%, 5.0% on librispeech testsets. I have no idea why we can't reach the paper numbers. Maybe they train more epochs or use other techniques. I was wondering if you have some suggestions.

Thanks for the info! Have you tried Conformer-L?

Thanks for the info! Have you tried Conformer-L?

Not yet. FYI, https://github.com/k2-fsa/icefall/blob/master/egs/librispeech/ASR/RESULTS.md#large this one has similar size with Conformer-L.

Thank your guys for the information.


Help needed:

Environment

Technology
Version

Flutter version
1.22.4

Plugin version
4.0.0+4

Android version

iOS version
14.2

Xcode version

Device information: iPhone 11 Max Pro
Description
Expected behavior:
When starting the App, the instance of WebView should be similar to the one in a previous version.
I am saving my cookies, give them to the initialHeaders field.
I expect that when I re-open the app after closing it, that my login still stays valid.
Current behavior:
I can use as many instances of webview in a flutter app while running, and use the saved cookies to access the current valid session.
However when I close the app, and re-open, with the exact same cookies, I am unable to use the previous session.
I am getting an error, that "It seems you are using this page already in another tab".
Is there any way I can re-create the environment I had before the app was closed, so I can resume the same session?
Additional Information
With a simple dart http get request, with the same cookies and url for InAppWebView and http.get(), I am getting the correct response with http.get(), but with InAppWebView the error, that the session is being used in another window.

To save cookies, you need to use the CookieManager and not the initialHeaders.
It doesn’t make any sense put the cookie header in it because cookies are set by the server responses and not by the client requests.
You need to access and manage cookies, you need to use the CookieManager class.


Bug fixes in examples

@roussel-ryan sent me these files directly, so this PR can be closed without merging.


Added Error handling in playStateSubscription

Please review the changes . Fixes https://github.com/ConnectSDK/Connect-SDK-iOS/issues/150

Where are tests? It's not very clear what the expected behavior is.

Added Tests and refactored the code


Open Sans: wrong font in latin-ext woff2 file

Describe the bug
Open Sans WOFF2 files for latin-ext contain wrong font.
To Reproduce
Steps to reproduce the behavior:

Install @fontsource/open-sans
Open node_modules/@fontsource/open-sans/files in your file explorer
Compare e.g. open-sans-latin-ext-300-italic.woff and open-sans-latin-ext-300-italic.woff2 in some font viewer

Expected behavior
WOFF and WOFF2 files should contain the same font.
Screenshots
from fontsee

woff
woff2

Additional context
Maybe also some other files may be affected, I think cyrillic of cyrillic-ext have been different as well.

It's an issue with WOFF actually having more glyphs than it should (but that's an upstream Google issue), though I'm considering deprecating subset-specific WOFF files in favour of the all subset format to reduce complexity.
You need to load both latin and latin-ext variants to get the full range of glyphs. Example - https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>

Thanks for explanation.

You need to load both latin and latin-ext variants to get the full range of glyphs. Example - https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>
Oh yes, you're right, thanks! I don't know why I missed it. It had to be both in webpack-google-fonts-plugin as well which I'm migrating away from.
Should this issue be closed now or you want to keep it open?

Nope. I'm tracking the WOFF deprecation in #547. Thanks!


[CY-4272] Running Docker tools with GoSec and StaticCheck leads to exit code 11

I am using the following GitHub Actions workflow file:
name: Codacy Analysis CLI

on: ["push"]

jobs:
  codacy-analysis-cli:
    name: Codacy Analysis CLI
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
        uses: actions/checkout@main

      - name: Run Codacy Analysis CLI
        uses: codacy/codacy-analysis-cli-action@master
        with:
          run-staticcheck: true
          run-gosec: true
          run-docker-tools: true
          project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}
          upload: true
          max-allowed-issues:<PHONE_NUMBER>

This causes an error, with exit code 11.
+ '[' true == true ']'
+ cd /tmp
+ curl -sfL https://raw.githubusercontent.com/securego/gosec/master/install.sh
+ sh -s v2.7.0
securego/gosec info checking GitHub for tag 'v2.7.0'
securego/gosec info found version: 2.7.0 for v2.7.0/linux/amd64
securego/gosec info installed ./bin/gosec
+ chmod +x ./bin/gosec
+ grep browser_download_url
+ xargs -L 1 curl -fsSL -o /tmp/codacy-gosec
+ grep -v 'browser_download_url.*jar'
+ cut -d '"' -f 4
+ curl -fsSL https://api.github.com/repos/codacy/codacy-gosec/releases/latest
+ chmod +x /tmp/codacy-gosec
+ cd -
+ /tmp/bin/gosec -no-fail -fmt json -log /tmp/log.txt ./...
/home/runner/work/piledriver/piledriver
+ /tmp/codacy-gosec
+ '[' true = true ']'
+ curl -XPOST -L -H 'project-token: ***' -H 'Content-type: application/json' --data-binary @/tmp/codacy-out.json https://api.codacy.com/2.0/gh/RedDocMD/piledriver/commit/4782877e682bd5dbed544f06e2c61b7a6e1a77f1/issuesRemoteResults
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  3765  100    44  100  3721     55   4698 --:--:-- --:--:-- --:--:--  4753
{"success":"Results received successfully."}
+ '[' true == true ']'
+ cd /tmp
+ curl -fsSL https://api.github.com/repos/dominikh/go-tools/releases/latest
+ cut -d '"' -f 4
+ grep -E 'browser_download_url.*staticcheck_linux_amd64.tar.gz"$'
+ xargs -L 1 curl -fsSL -o /tmp/staticcheck_linux_amd64.tar.gz
+ tar -xvf /tmp/staticcheck_linux_amd64.tar.gz staticcheck/staticcheck
staticcheck/staticcheck
+ chmod +x ./staticcheck/staticcheck
+ grep browser_download_url
+ cut -d '"' -f 4
+ xargs -L 1 curl -fsSL -o /tmp/codacy-staticcheck
+ grep -v 'browser_download_url.*jar'
+ curl -fsSL https://api.github.com/repos/codacy/codacy-staticcheck/releases/latest
+ chmod +x /tmp/codacy-staticcheck
+ cd -
+ find . -type f -name go.mod -exec bash -c 'cd $(dirname $1); PKGS=$(go list ./...); /tmp/staticcheck/staticcheck -f json $PKGS' _ '{}' ';'
/home/runner/work/piledriver/piledriver
+ /tmp/codacy-staticcheck
+ '[' true = true ']'
+ curl -XPOST -L -H 'project-token: ***' -H 'Content-type: application/json' --data-binary @/tmp/codacy-out.json https://api.codacy.com/2.0/gh/RedDocMD/piledriver/commit/4782877e682bd5dbed544f06e2c61b7a6e1a77f1/issuesRemoteResults
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  1165  100    44  100  1121     56   1435 --:--:-- --:--:-- --:--:--  1489
100  1165  100    44  100  1121     56   1435 --:--:-- --:--:-- --:--:--  1489
{"success":"Results received successfully."}
+ '[' -n '' ']'
Skipping Clang Tidy
+ echo 'Skipping Clang Tidy'
+ '[' -n '' ']'
+ echo 'Skipping Faux Pas'
Skipping Faux Pas
--2021-05-04 14:56:11--  https://raw.githubusercontent.com/codacy/codacy-analysis-cli/6.2.1/bin/codacy-analysis-cli.sh
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|<IP_ADDRESS>|:443... connected.

Hi @franciscodua, still getting the error.

Hey @brunopadz
Exit code 11 means that you have "Uncommitted changes in project" when the CLI tries to send results. Do you have any examples that we can check for this problem? It would also help If you can find out which files have changed.
Otherwise, check if your files are up to date, and unchanged by the CI before calling the CLI.
Let us know how these steps went!

I'm closing this issue due to inactivity. If the problem remains, feel free to re-open it.


Add Chris Elliott to KFP org.

Add zpChris<EMAIL_ADDRESS>to the Kubeflow organization, Google team, and pipelines team, as well as to ci-team.yaml to administer Kubeflow CI infrastructure.
Test output from pytest test_org_yaml.py (included due to these instructions):
================================================================ test session starts ================================================================
platform linux -- Python 3.9.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /usr/local/google/home/cell/Desktop/zpChris/internal-acls/github-orgs
collected 1 item

test_org_yaml.py .                                                                                [100%]

================================================================= 1 passed in 0.28s =================================================================

/assign @zijianjoy

/lgtm
/approve
Welcome to Kubeflow, Chris! Excited to have you onboarded!


Smart Sorting & Grouping

Bring tab groups to front
Bring tab groups to back
Group by domain

Supported in v1.0.0


Detect the language for CONTRIBUTING

It is the base of language specific CONTRIBUTING generation.

ref https://github.com/mfojtik/go-detect/blob/master/main.go


Remove dependency on comcast infrastructure

All tests, documentation and similar need to remove dependency on comcast infrastructure.

Specifically:
--1) Change parameter ‘dns-id’ to ‘dns-txt-url’
--2) Change names in readme file not to refer to Comcast specific urls, etc.
--3) create mock_dns_server.
--4) In mock_dns_server we #define USE_MOCK_DNS_SERVER true
Defaults true, but we can set it false, so that we can compile a test
that can access fabric-beta.
Since we spent many months debugging the dns server lookup,
we don’t want to throw away the test code that does that.
--5) We need some test dns txt records that have fake endpoint values.
We can use these to test dns server lookups when
USE_MOCK_DNS_SERVER is false, so we don’t point to anything real.

What about this idea?
We create another repository, not open source: https://github.comcast.com/webpa/test_parodus,
and I will put all the tests I already have in there.
In open source, https://github.com/Comcast/parodus, I will change the tests to use a mock dns server,
or whatever we decide to do for that.


expenses: init at 0.2.1

Motivation for this change
An interactive command line expense logger
GitHub: https://github.com/manojkarthick/expenses
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Thanks for the review @SuperSandro2000 - I've updated the PR with the requested changes.

Thanks for the review @SuperSandro2000 - I've updated the PR with the requested changes.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108753 run on x86_64-darwin 1

1 package built:

expenses

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108753 run on x86_64-darwin 1

1 package built:

expenses

@SuperSandro2000 - All the comments have been resolved, and it seems to be building okay. Would you be able to approve and merge this when you get a chance? Thanks!

@SuperSandro2000 - All the comments have been resolved, and it seems to be building okay. Would you be able to approve and merge this when you get a chance? Thanks!

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108753 run on x86_64-linux 1

1 package built:

expenses

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108753 run on x86_64-linux 1

1 package built:

expenses

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108753 run on x86_64-darwin 1

1 package built:

expenses

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108753 run on x86_64-darwin 1

1 package built:

expenses

Thank you!

Thank you!


Add Cloudlinux-related leapp repository changes

This PR adds a set of custom actors that are required to perform a migration on CloudLinux-based systems.
These actors are placed in a separate sub-repository, not mixed in with the common actor list.
CL actor execution is conditional, and will not affect migration on non-CL systems.

@andrewlukoshko This is the up-to-date version of CL-related changes.
#11 should probably be merged before this one.


Added album name support.

I have added Album Name support to SpotMenu, of course with a preference to configure it. By default, it is set to true. I also updated the Xcode Workspace project format to be Xcode 8 and higher compatible only, since we don't target any macOS versions that still use Xcode 3.2.
I have tested this a bunch, and so far it works really well aside from the fact that I haven't figured out a way to hide the album name if it's the exact same as the song title unfortunately.

looks good to me!


添加 store key 报错

There was an error saving the API Key, please try again.
Fernet key must be 32 url-safe base64-encoded bytes

Hi @java668 ,
Could you please tell where did that bug happen, and what did you do to make it happen? I would like to check out this issue with you as soon as possible!
Thanks!

Hi @java668 ,
Could you please tell where did that bug happen, and what did you do to make it happen? I would like to check out this issue with you as soon as possible!
Thanks!

hello，here

Hi @java668 ,
Could you please tell where did that bug happen, and what did you do to make it happen? I would like to check out this issue with you as soon as possible!
Thanks!

hello，here

你的API Key是根据指引，登录langflow.store后获取的吗？如果不是的话可以尝试使用登录langflow.store后获取的API Key来填写

https://github.com/langflow-ai/langflow/issues/2458


Add Form tag custom class configuration

It's great configuring default form field classes in ENV, but would it be possible to also add the ability to configure default classes for the form element itself?

Sure! If you could implement it and open an PR, that would be awesome!

Sweet. I'll look in to that today/this weekend


Fix incorrect GitHub references

"Github" should be "GitHub"

If GitHub is correct, we should change "Github" word in DEVELOPMENT.md.

+1

Thank you @queeniema for check it.
It's not critical and simple to modify. So I'll create Jira issue with "newbie" tag to attract newest person.


feat: rename azdls to adls with alias

Iceberg spec will call credential adls. We should follow that naming in user facing APIs.

Probably not worth it. Azdls is also used in opendal everywhere.


Warning in edid_master_slave_hack

This looks like a real warning:
hdl/edid/edid_master_slave_hack.v" Line 112: Result of 8-bit expression is truncated to fit in 7-bit target.

The code looks like this, with the warning referring to the last line of this snippet:
wire [7:0] edid_byte_lcd;
reg [6:0] segments;

segments <= edid_byte_lcd;

8 does not fit into 7, as the warning tells us.
This blocks #38.

Closing this as the HDMI2USB-jahanzeb-firmware is no longer under development.

The HDMI2USB-jahanzeb-firmware is no longer under development.
All active development is now on the HDMI2USB-misoc-firmware which supports both the Atlys and Opsis boards and has loads of other new features!


sparse_selection function

Given a STM, make a subset with min_dist arg. Every two entries of the output STM should have at least the min_dist distance.
The results will be used for #16.

Hi Ou,
I actually ended up creating a working Matlab script, see attachment.
pseudocode_sparsify.txt
The iterative calculation of the distances with the hypot function is the most expensive operation, I guess. Optimization is possible I guess, e.g. by selection of the points around the middle point in the bounding box around it.


disable InsecureRequestWarning for local HTTP dev/test scenario

Disabled the InsecureRequestWarning message, because most people will run this sample locally over HTTP:// instead of HTTPS://.

@dmahugh,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


CLI - Gen2+TLVM As default - New VM with minimal Inputs

Related command

az vm create --name 'vmname' --resource-group 'vm-rgname'
az vmss create --name 'vmssname' --resource-group 'rgname'

Resource Provider
Microsoft.Compute/virtualMachines
Description of Feature or Work Requested
Gen2+TLVM as default (Preferred)
As part of making compute layer secure for customers to deploy workloads, request is to make Trusted Launch (GA Date: November 2021) as default deployment option in CLI. Following changes will need to be made for same:
Scenario 1 - User runs az vm create with minimal parameters.

Present Behavior
Updated Behavior post change

New VM with minimal parameters: User runs command az vm create --name vmname --resource-group rgname.User gets prompted for value of --image parameter. User provides specific image ID or URNAliasCLI creates VM with size Standard_DS1_v2.
Updated default parameters: runs command az vm create --name vmname --resource-group rgname.CLI takes default value for --image parameter as MicrosoftWindowsServer:WindowsServer:2019-DATACENTER-GENSECOND:latest i.e., no prompt for user for value of --image parameter.Following parameters are set by default:--enable-secure-boot with value true--enable-vtpm with value true--security-type with value TrustedLaunchCLI creates VM with size Standard_DS1_v2 and default values for parameters mentioned in Step 2 & 3

Notification Message if needed to be provided to end users prior to making changes - Starting xx/xx/xxxx az vm create command will deploy Trusted Launch VM by default. To know more about Trusted Launch, please visit https://docs.microsoft.com/en-us/azure/virtual-machines/trusted-launch
Scenario 2 - User runs az vmss create with minimal parameters.

Present Behavior
Updated Behavior post change

New VMSS with minimal parameters: User runs command az vmss create --name vmssname --resource-group rgname.User gets prompted for value of --image parameter. User provides specific image ID or URNAliasCLI creates VMSS with size Standard_DS1_v2.
Updated default parameters: runs command az vmss create --name vmssname --resource-group rgname.CLI takes default value for --image parameter as MicrosoftWindowsServer:WindowsServer:2019-DATACENTER-GENSECOND:latest i.e., no prompt for user for value of --image parameter.Following parameters are set by default:--enable-secure-boot with value true--enable-vtpm with value true--security-type with value TrustedLaunchCLI creates VMSS with size Standard_DS1_v2 and default values for parameters mentioned in Step 2 & 3

Notification Message if needed to be provided to end users prior to making changes - Starting xx/xx/xxxx az vmss create command will deploy Trusted Launch VM by default. To know more about Trusted Launch, please visit https://docs.microsoft.com/en-us/azure/virtual-machines/trusted-launch

NOTE: Please review limitations Trusted Launch VM Limitations to assess any impact for CLI users.

Gen2-as-Default (Failback)
If Gen2+TLVM-as-default cannot be implemented, we request to make Generation 2 VM (GA Date: 2019) as failback alternative default deployment option in CLI. Following changes will need to be made for same:
Scenario 1 - User runs az vm create with minimal parameters.

Present Behavior
Updated Behavior post change

New VM with minimal parameters: User runs command az vm create --name vmname --resource-group rgname.User gets prompted for value of --image parameter. User provides specific image ID or URNAliasCLI creates VM with size Standard_DS1_v2.
Updated default parameters: User runs command az vm create --name vmname --resource-group rgname.CLI takes default value for --image parameter as MicrosoftWindowsServer:WindowsServer:2019-DATACENTER-GENSECOND:latest i.e., no prompt for user for value of --image parameter.CLI creates VM with size Standard_DS1_v2 and default image mentioned in Step 2.

Scenario 2 - User runs az vmss create with minimal parameters.

Present Behavior
Updated Behavior post change

New VMSS with minimal parameters: User runs command az vmss create --name vmssname --resource-group rgname.User gets prompted for value of --image parameter. User provides specific image ID or URNAliasCLI creates VMSS with size Standard_DS1_v2.
Updated default parameters: User runs command az vmss create --name vmname --resource-group rgname.CLI takes default value for --image parameter as 2019-DATACENTER-GENSECOND i.e., no prompt for user for value of --image parameter.CLI creates VMSS with size Standard_DS1_v2 and default image mentioned in Step 2.

Notification Message if needed to be provided to end users prior to making changes - Starting xx/xx/xxxx az vmss create command will deploy Generation 2 VM by default. To know more about Azure Generation 2 VM, please visit https://docs.microsoft.com/en-us/azure/virtual-machines/generation-2

NOTE: Generation 2 VMs have full feature parity with existing Generation 1 VMs used by majority of customers.

Minimum API Version Required
2021-11-01
Swagger PR link
Compute Swagger 2021-11-01
Request Example

Create VM with UEFI Settings JSON
Create VMSS with UEFI Settings JSON

Target Date
2022-10-10
Additional context

Target date for implementing notification for user is to match ignite event scheduled for 2022-10-12
My understanding is before change is implemented, user will need to be provided with notification, hence target date for implementation of the changes is Build event 2023 (May 2023)
Multiple Trusted Launch VM limitations will be tentatively addressed before actual implementation date of May 2023.
VM Size / SKU capability to support Gen2 or Trusted Launch VM can be queried using API Resource SKU List API

For Gen2 refer to property HyperVGeneration with supported value of v2
For trusted launch VM, refer to property TrustedLaunchSupportDisbled set to true, for sizes which support Gen2 but not Trusted Launch.

Compute

@AjKundnani In fact, when users only execute the az vm create --name vmname --resource-group rgname command without other parameters, CLI will prompt incorrect usage: --image IMAGE | --attach-os-disk DISK
This is because at present, users can also create a VM by attaching the OS disk without using the --image parameter, such as execute vm create -g {rg} -n vm2 --attach-os-disk {disk_uri} --os-type linux --use-unmanaged-disk. And it is similar for VMSS.
So I want to confirm whether these default behaviors only take effect when the user has neither passed in --image parameter nor --attach-os-disk parameter?

@AjKundnani In fact, when users only execute the az vm create --name vmname --resource-group rgname command without other parameters, CLI will prompt incorrect usage: --image IMAGE | --attach-os-disk DISK This is because at present, users can also create a VM by attaching the OS disk without using the --image parameter, such as execute vm create -g {rg} -n vm2 --attach-os-disk {disk_uri} --os-type linux --use-unmanaged-disk. And it is similar for VMSS.
So I want to confirm whether these default behaviors only take effect when the user has neither passed in --image parameter nor --attach-os-disk parameter?

That is correct, for this scenario we assume user has not passed values to parameter --image nor for --attach-os-disk. For scenario where users will pass specific values (and other scenarios), I'll be submitting different request.

@zhoxing-ms - Based on other initiatives, updated default OS Image to Windows Server 2022 Azure Edition. Will not impact notification message, it will be needed during implementation.

@AjKundnani OK, got it. Please also update the default OS Image in the feature description~

Hi @AjKundnani
could you please help review this change?

Hi @AjKundnani could you please help review this change?

@yanzhudd - The condition in validator.py looked good to me. Will validate further during bug bash.


Nested directives using angular2 & blaze

Hi,
I've been trying incorporate Angular 2 in our system which is currently using blaze, step by step.
One of the major problems I encountered trying to replace one of the system pages from Blaze to Angular2 (while keeping all other pages working with blaze in a working order) is when I try to use on directive inside of another.
I getting what I think is a dummy exception from the browser, Uncaught SyntaxError: Unexpected token <. from what I can see in the browser dev-tools some part of the infrastructure try to use the concatenated html since the imported file of the nested directive files to either be transpiled or imported, I don't really know since I don't see any errors from the meteor CLI 'compilation' process.
Any clue what can cause this behavior?

I usually get this exception when a file is not well referenced in an application. Try to look inside debug console --> explore to see which file is it.

Source of the issue is unlikely related to nested directives. As was mentioned above, some module is likely referenced wrongly in your app.


feat(tonic): add unix socket support in server

Addresses https://github.com/hyperium/tonic/issues/856
Adds tonic::transport::server::UdsConnectInfo to facilitate consumers using a unix domain socket on the server side. Updates the existing uds example to use this UdsConnectInfo and tokio's UnixListenerStream as the latter cuts down on consumer boilerplate. Adds an integration test for UdsConnectInfo.
Motivation
Currently using a unix socket requires consumers to provide an implementation of the tonic::transport::server::Connected trait (UdsConnectInfo).
When I started using tonic, I copy+pasted this stuff from the uds example into my application. I bet other users have done this as well, and while this is not the end of the world, it would be nice if unix sockets worked out of the box with a tonic server.
This PR aims to allow consumers to more easily use a tokio::net::UnixListener with a tonic server.
Solution
The UdsConnectInfo implementation here is pulled directly from the existing uds example. I pulled UnixListenerStream into the uds example to remove some boilerplate code there.

Left a few comments but I like this idea, we should have probably added this a while ago.

Great to hear - his simplifies our server usage a bit and hopefully it will do the same for others! I've addressed your comments, let me know what you think

Oops, looks like I missed a #[cfg(unix)] in the UDS example and that broke non-Unix builds. Just pushed a fixup to address that

Is this gonna land in the next release?

Also, does this support abstract sockets?


runner: make the ARRAY_SIZE/min/max macros global

Signed-off-by: Xiubo Li<EMAIL_ADDRESS>Preparing for xcopy patches followed.

Thanks.


Memos not Loading

Describe the bug
After the last update on the docker image, loading the page it just displays "Fetching data…" while doing absolutely nothing.
Steps to reproduce

Go to page
Wait for Memos to load

The version of Memos you're using
v0.18.2
Screenshots or additional context

Loading memos dosent work, but the resources tab works.

Please provide error messages from the browser console, as well as logs of related network requests.

@boojack I'm able to recreate this in v0.18.1 latest commit. Home/Explore page displays fetching data and this error is thrown:
Home-nUummMMK.js:1 Uncaught (in promise) ClientError: /memos.api.v2.MemoService/ListMemos UNKNOWN: pq: column "parent_id" does not exist
    at makeCall (index-Qitdbhvp.js:300:6112)
    at async at (index-Qitdbhvp.js:300:11471)
    at async Object.listMemos (index-Qitdbhvp.js:300:11982)
    at async Object.fetchMemos (index-Qitdbhvp.js:323:72482)
    at async y (Home-nUummMMK.js:1:10592)

Please provide error messages from the browser console, as well as logs of related network requests.

Browser Console:

Network requests:

Containers Logs:

I'm no expert but i guess the requests takes so long that it Times out.
Below screenshot is captured a few minutes after the first screenshot.

After looking to the DB i found a few very long memos (about 48294 characters for each memo) and deleted them, after that the site loaded with no problems agains. I would maybe add an serverside check for the Memo length, or something like this. To prevent this from happening to other instances.

Thanks for your feedback. Updated with https://github.com/usememos/memos/commit/ddcf1d669d41dbb19b94955d19c9ed6ca44c1b9f


Add option to enable f-strings

This adds starlark_enable_f_strings property in buck2 section. We want to keep it behind a flag for now because some internal tool at facebook doesn't support f-strings yet.
fix #647

@stepancheg Here the PR, I can't assign it to you myself

(the import logic is currently having some issues on our side, I'll get this merged as soon as that's unblocked)


robot_state_publisher: 2.4.5-1 in 'foxy/distribution.yaml' [bloom]

Increasing version of package(s) in repository robot_state_publisher to 2.4.5-1:

upstream repository: https://github.com/ros/robot_state_publisher.git
release repository: https://github.com/ros2-gbp/robot_state_publisher-release.git
distro file: foxy/distribution.yaml
bloom version: 0.10.7
previous version for package: 2.4.2-1

robot_state_publisher
* Restore tf frame prefix support for ROS 2 (#159 <https://github.com/ros/robot_state_publisher/issues/159>) (#170 <https://github.com/ros/robot_state_publisher/issues/170>)
* Contributors: Chris Lalancette

Holding for Foxy sync


Scheme config variants wrong assignment for similar config names

We've found out a strange bug when using multiple config names and generating schemes automatically.
If config names are similar (example: PROD and PREPROD), the Prod scheme will be (wrongly) assigned to the PREPROD configuration.
Example project.yml:
name: Test
configs:
  DEV Debug: debug
  DEV Release: release
  PROD Debug: debug
  PROD Release: release
  PREPROD Debug: debug
  PREPROD Release: release
settings:
      configs:
        DEV Debug:
           SWIFT_ACTIVE_COMPILATION_CONDITIONS: DEV DEBUG
        DEV Release:
           SWIFT_ACTIVE_COMPILATION_CONDITIONS: DEV
        PROD Debug:
           SWIFT_ACTIVE_COMPILATION_CONDITIONS: PROD DEBUG
        PROD Release:
           SWIFT_ACTIVE_COMPILATION_CONDITIONS: PROD
        PREPROD Debug:
           SWIFT_ACTIVE_COMPILATION_CONDITIONS: PREPRD DEBUG
        PREPROD Release:
           SWIFT_ACTIVE_COMPILATION_CONDITIONS: PREPRD
options:
  createIntermediateGroups: true
  deploymentTarget:
    iOS: "12.0"
targets:
  Test:
    type: application
    platform: iOS
    sources:
      - path: "Sources"
    settings:
        base:
            CURRENT_PROJECT_VERSION: 1
            MARKETING_VERSION: 0.26.0
            INFOPLIST_FILE: Sources/Info.plist
    scheme:
      configVariants:
        - DEV
        - PROD
        - PREPROD

Result
Opening the generated Test PROD scheme, there will be the PREPROD Debug and PREPROD Release configurations assigned.

I believe the problem may be here:
https://github.com/yonaskolb/XcodeGen/blob/master/Sources/XcodeGenKit/SchemeGenerator.swift - line 74.
Since we're forced to use Release and Debug in config names, we should trim those names from current config and check for complete equality with the variant.
I'll try to put together a PR and see if I'm able to add non-breaking tests


Distributed Storage

Same as Ingress, I think it would be good if we offer a default option.
Yesterday, I setup an (almost) successful cluster (without Let's encrypt), and I used rook.
It was almost straight forward, and it looks like a very viable option for the storage.
The plus are:

part of CNCF
almost in beta (0.7 is a pre-release)
support for:

Block Storage (I just tried that)
Object Storage
Shared File System

Here are some notes I used:
git clone https://github.com/rook/rook
cd rook/cluster/examples/kubernetes
kubectl create -f rook-operator.yaml
kubectl create -f rook-cluster.yaml
kubectl create -f rook-storageclass.yaml
kubectl create -f mysql.yaml
kubectl create -f wordpress.yaml

The helm chart didn't work, but this way, it wokred.
(didn't have time to debug further the helm, but I think it should be the way to go)
Then I deployed a RocketChat instance, with the official helm chart, and it worked with the storage \o/ (and the ingress, but without tls :/ )

Don't get me wrong, I'm a big fan of rook and watching it from April last year.
I think it should be offered as an addon like mentioned in #15

At a minimum, it should be documented.
The 'full tutorial' installs OpenEBS, but doesn't mention that OpenEBS doesn't specify a default storage class by default.

ok, the new rook option looks good to me!
I still think we would be better off using an helm chart, event with our specific configuration, but this can be discussed later, once the helm chart is fixed :) .
We can envision that based on the node tags (VMs or BareMetal) the rook addon would be configured accordingly with a sane default, and yes, in this sense it makes sense to have an addon :)
I'll close the issue now!
Thanks @xetys for the amazing work! Looks promising!


Single module app. Index.js for method_stubs/ and actions/

I'm starting off focusing on a single module with users and posts features. Is this the correct approach for these files? I'm new to meteor and mantra. Pardon my ignorance.
// client/modules/core/configs/method_stubs/index.js

import users from './users';
import posts from './posts';

export default function (context) {
  users(context);
  posts(context);
}

// client/modules/core/actions/index.js

import users from './users';
import posts from './posts';

export default {
  users,
  posts
};

Yeah. This should be the way.

Seems correct, as long as you think that this part of functionality belongs to "core" module.
Maybe we can decouple these posts and comments from demo app also and show how to do collections init in separate modules.
So they would be really ready to be bundled as separate npm modules for the future.
Maybe even abstract routes to separate package - as currently in demo it is just routes.jsx, but not in separate directory. That means if they grow and need to be spread to more files, it can look bad in the module root directory.
If we want to set example for larger apps too.


my stm32f103c8 + hx8352b tft support implementation

here is the link to my test project. may be it will be useful.
https://www.dropbox.com/s/7hbxg3vrh6w9ym0/lvgl_test.tar.gz?dl=0
the lcd is connected through 8 bit bus, so it is very slow and that's why i even not tried optimizing the functions.
but it won't work out of the box, because by default stm32f103c8 has 64k ROM, which is not enough for LVGL. but it is possible to unlock second flash bank. i needed to edit openocd device script. and of course edit linker script. so LVGL fits fine in 128k ROM and works fine on 20k RAM.
P.S. code is a mess, i know, i'm not very experienced in C yet.

Thank you! I will check it soon and write!

I was very curious so I removed the sscanf  and done the following changes in your project:

updated to lvgl to  v5.1 (from dev-5.1) branch
disabled the complex objects (e.g. Tab view)
disabled unused modules in general
switched to O3 optimization  (Project properties -> C/C++ build -> Settings -> Optimization)
removed the mentioned sscanf
enabled buffered drawing: LV_VDB_SIZE     (10 * LV_HOR_RES)
Implemented TFT_Flush (based on TFT_Map just added lv_flush_ready at the end)
Registered TFT_Flush in the display driver (disp_flush = TFT_Flush)

Here is the modified project:  lvgl_test_kisvegabor.zip
It compiles for me and results 44kB code.
Can you test it?

wow! that's great! i was thinking that 'flush' routine was meant only for LCDs with gpu capabilities, like DMA2D in higher stm32 MCUs. will check your project as soon as possible!

i've tested it. it draws the gui fine and it even seems to draw it faster, but i failed to enable touch. and during debug, i see no code. seems like you've disabled symbols for size optimisation, but i don't know how to switch them back, lol.

Great!
I modified your TFT_ReadTouch function to set the last coordinates even in released mode. Hence the lv_indev modification is not required.
bool TFT_ReadTouch(lv_indev_data_t *data) {
	static int16_t last_x = 0;
	static int16_t last_y = 0;

	data->state = readZ() > TOUCH_Z_MIN ? LV_INDEV_STATE_PR : LV_INDEV_STATE_REL;

	if (data->state == LV_INDEV_STATE_PR) {
		if (xMin == 0) {
			last_x = readX();
			last_y = readY();
		} else {
			last_x = mapX(readX());
			last_y = mapY(readY());
		}
	}

	/*Always set valid points*/
	data->point.x = last_x;
	data->point.y = last_y;

       ...
}

aha! now i understood what you've meant bu setting coords everytime. i made it that they were updated every time from ADC, but not updated conditionally using static variables. it really works fine that way.

Great! :)
Please. keep us informed if you made the optimization working with touchpad.
I'm very curious about the final code size with -O3.

that is very interesting things happening here. i've added again the debug label, because debug dots were not drawing. and i'm noticing jumping x or y coords while touchpanel is not touched at all. and while i make coord vars volatile or move them to header file, they alter behaviour, in some case jumps x and y is right, in other case jumps y and x is right. rofl. c optimisations are hell for me. but i will try hard to make my code work.

oh! i've fixed it not only by getting those static variables out of TFT_ReadTouch, but also leaving them uninitialised and resetting them to zero in TFT_Init.
here is the result of your variant:
Generating binary and Printing size information:
arm-none-eabi-objcopy -O binary "lvgl_test.elf" "lvgl_test.bin"
arm-none-eabi-size "lvgl_test.elf"
   text	   data	    bss	    dec	    hex	filename
  49608	   1184	  10308	  61100	   eeac	lvgl_test.elf

but yeah, buffering looks much better! while i was trying to solve optimisation issue, i was using my project with no buffering, and now i run your variant with buffering and it just feels better!

Yes, optimization can make strange things. The voaltile prefix usually helps.
So the code is < 50kB which leavs you 16 kB space for the application. Which is not too much but might be enough for a simple GUI and the related measure/control .

And thank you for telling you experiences :)

while this 'blue pill" stm32f103c8 board actually has 128k ROM (but need unlocking), this makes your library suitable even for those "1 dollar" boards! and even without config hacking it works with default 64k! and even with buffering running on just 20k RAM! that's is very very great!


Merge to live!

Add-ins: minor edits
Get started topics: updated steps

Docs Build status updates of commit 41571cd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/delegate-access.md
:white_check_mark:Succeeded

docs/includes/rest/app-registration-intro.md
:white_check_mark:Succeeded

docs/rest/dotnet-tutorial.md
:white_check_mark:Succeeded

docs/rest/get-started.md
:white_check_mark:Succeeded

docs/rest/index.md
:white_check_mark:Succeeded

docs/rest/ios-tutorial.md
:white_check_mark:Succeeded

docs/rest/java-tutorial.md
:white_check_mark:Succeeded

docs/rest/javascript-tutorial.md
:white_check_mark:Succeeded

docs/rest/node-tutorial.md
:white_check_mark:Succeeded

docs/rest/php-tutorial.md
:white_check_mark:Succeeded

docs/rest/python-tutorial.md
:white_check_mark:Succeeded

docs/rest/ruby-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.