minor: [BinaryOperatorFixer] Deprecate single_space option in favor of single_space_minimal

Related to https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/4396
single_space currently means "Exactly one space"
align_single_space means "At least one space"
aligne_single_space_minimal means "Exactly one space"
I think we should rename single_space to single_space_minimal.
In 4.0, single_space can be newly implemented to at least one space.

Coverage increased (+0.0004%) to 92.837% when pulling 535e17188327c3d06b58fac0e6fa4a6c4c09791c on VincentLanglet:singleSpaceMiniaml into 17e55913427ee15e73f5f7001c025ecc83f09ff7 on FriendsOfPHP:master.

I think we should rename single_space to single_space_minimal.

I don't think so, I think single_space_minimal would mean:
in:
$a =$b&&$c;
$d =$a   &&    $e;

out:
$a =$b && $c;
$d =$a   &&    $e;

and not
out:
$a =$b && $c;
$d =$a && $e;

this is also discussed here: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/4497
besides, if we are going to rename option I think should be properly deprecated so it will be the docs and triggers warning if still using the old configuration value

I think we should rename single_space to single_space_minimal.

I don't think so, I think single_space_minimal would mean: in:
$a =$b&&$c;
$d =$a   &&    $e;

out:
$a =$b && $c;
$d =$a   &&    $e;

If we do this, this will "conflict" with the definition for align_single_space and align_single_space_minimal.
You can't say that single_space_minimal means at least 1 space when align_single_space_minimal means align with exactly 1 space.

Exactly one space
At least one space

Aligned
align_single_space_minimal
align_single_space

Not aligned
single_space
single_space_minimal

would be confusing
We could say that align_single_space should have been exactly one space but changing this does not allow to provide a BC upgrade path... A solution could be to rename the align_ options to align_with_
Something like

Exactly one space
At least one space

Aligned
align_with_single_space
align_with_single_space_or_more

Not aligned
single_space
single_space_or_more

The upgrade path for user (helped by deprecation message) would be

Changing align_single_space_minimal to align_with_single_space
Changing align_single_space to align_with_single_space_or_more
And we could introduce single_space_or_more in this version without waiting for 4.x.

WDYT ?

besides, if we are going to rename option I think should be properly deprecated so it will be the docs and triggers warning if still using the old configuration value

Sure I can, I'll wait for the right name to be decided

On 4.x I would go with just two options: align and one_space, where align is always minimal spacing and of at least one space on the left of the operator and always one space on the right of it. All other options are just there for BC reasons AFAIK.
Not sure about the upgrade path here, like to hear some thoughts on it.

On 4.x I would go with just two options: align and one_space, where align is always minimal spacing and of at least one space on the left of the operator and always one space on the right of it. All other options are just there for BC reasons AFAIK.

So basically you want to only propose
align which is the current align_single_space_minimal
one_space which it the current single_space option.
For the align, there is the following tricky subject, how do you align
$a = [
    1 => [
    ],
<PHONE_NUMBER>111 => 2
];

Because currently, it's not aligned but, people which aligns => are generally expecting
$a = [
    1             => [
    ],
<PHONE_NUMBER>111 => 2
];

This is the current reason I have for using the align_single_space and not align_single_space_minimal option.
For the one_space, looking at comment like https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/4396#issuecomment-519911680, it seems like people doesn't want every time to restrict to strictly one space.
So, so far, I would say there are still reason for 4 options.

I would expect
$a = [
    1             => [
    ],
<PHONE_NUMBER>111 => 2
];

as it is still:

minimal one space, like  2
the => [ is aligned with the one below
there is one space after the =>'s

would there be use case for another option than?

I would expect
$a = [
    1             => [
    ],
<PHONE_NUMBER>111 => 2
];

as it is still:

minimal one space, like  2
the => [ is aligned with the one below
there is one space after the =>'s

I expect the same :)
Currently it's not fixed because the => are not on consecutive lines, and the BinaryOperatorFixer only align groups by groups. Example, the following code with align_single_space is untouched:
$a = 1;
$b = 2;

$aaa = 1;
$bbb = 1;
```

I created https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/6590 to discuss about this special case.

> would there be use case for another option than? I never align stuff, so I might be overseeing this here, but I think it would be better to reduce the amount of options as four is a bit much to understand IMHO

I agree that less option are better.

Also, maybe the right solution would be to split the rule.
- BinaryOperatorFixer would just check that there is a space before and after every operator. (The execution might be faster than the current rule)
- AlignmentBinaryOperatorFixer would be executed after BinaryOperatorFixer and would align the binary operators.

@julienfalque @keradus WDYT ?

Closing du to lack of interest


Parameters of the full size car model

Hi @alexliniger
After I customize my track and bound, I try to modify the model but found that the exitflag of the solver was 2. I think it should be caused by the improper vehicle model parameters I set. Would you like to ask if you have full-size vehicle model parameters for simulation?
Waiting for your reply. Thank you !
Tairan Chen

I noticed the problem when i tried the same. I assume normalizing the state and input should help, at least it did for the Matlab code.
Another solution could be transforming the origin of the global coordinate system to X_0, Y_0, in the MPC. The last approach is to use the warm start feature in hpipm.
I try to look into them once I have time.
Best,
Alex

I found that if I didn't change the model parameters, I could get exitflag equal to 0.
Do you mean that I need to normalize both state and input to eliminate the influence of changes in parameters such as Cm1 and Iz in the model?
Best,
Tairan

The issue is that a full scale car results in a bad scaled problem, you have positions in the range of 1000m and inputs and states that are only in a range of +/- 1. Thus it often makes sense to scale everything to +/-1 as I did in the Matlab code.
Since the biggest problem are the positions, moving the coordinate system or using an initial guess most probably also fixes the problem. And as usual everything together is what one should do.
Best,
Alex

I see. Thank you for your reply !
Best,
Tairan

In the acado version I reproduced, I have not added tire constraints, and the solver seems to be able to converge.

Thanks, this means there is a small bug in my code or using the affine system is causing issues (this is currently something I suspect as it may work good for the miniature cars where the states are very small and all in a similar scale but it may causes issues for the full sized cars).
Acodo is using the following approximation x_{k+1} = A_k x_k + B_k u_k


timeDelta function returns wrong time delta

Is there a specific reason to return twice the amount of time (return secs*1000 + msecs)?
def timeDelta(timeBegin):
end     = time.time()
secs    = end - timeBegin
msecs   = (end - timeBegin) * 1000.0
return secs*1000 + msecs

Hello,
It not a feature, it's just a bug. It's very old code, I not write in this way now. Sorry. Thank you for your report.

Hi Bohdan,
No thank you for your code. And thanks for your reply.
Have a nice day.
Best regards.

From: Bohdan Danishevsky<EMAIL_ADDRESS>Sent: Saturday, August 12, 2017 10:25 PM
To: JFF-Bohdan/sim-module
Cc: Vangeels; Author
Subject: Re: [JFF-Bohdan/sim-module] timeDelta function returns wrong time delta (#11)
Hello,
It not a feature, it's just a bug. It's very old code, I not write in this way now. Sorry. Thank you for your report.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/JFF-Bohdan/sim-module/issues/11#issuecomment-322003863, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdTd0xK3U1cjFqv4ay6g7yX0bOScVJ0Vks5sXgpDgaJpZM4Otv4U.


Remove maven dependency resolver.

Also has to remove classpath check as jar does not contain any dependecies.
Classpath loading support for Java 9+ could be implemented in some another PR (possibly via #495).
Closes #451

great, thank you!
cc @bethcutler


A fix for the unicode tags

A soon as read() returns only positive values (int range 0..255) and match[i] is signed (byte range -128...127) we have to cast.

@dvasilen bump?

@tooptoop4 I no longer work on this project. No plans to fix.


Option to customize the text on the "Sign in with Auth0" link

In watching this animated gif I realized that most users really don't have to care what "Auth0" is - they just need a sign in link!

The only reason I'm not going to make this the default text is that you might have the same plugin installed alongside other authentication options like https://datasette.io/plugins/datasette-indieauth

... but that's silly, because it is going to be VERY rare that people install more than one auth plugin.
So I should set the default to "Sign in" and allow people to customize it if they want to instead.


240 pods after installation in +-6 different states, 46GB host swapping

After installation that passed, there is too many pods it too many different states like (I particularly dislike "Terminating" and "OOMKilled" :)).
$ oc --config ocp/auth/kubeconfig get pods --all-namespaces
NAMESPACE                                               NAME                                                              READY   STATUS        RESTARTS   AGE
kube-system                                             etcd-member-master-0                                              1/1     Running       0          17h
kube-system                                             etcd-member-master-1                                              1/1     Running       0          17h
kube-system                                             etcd-member-master-2                                              1/1     Running       0          17h
openshift-apiserver-operator                            openshift-apiserver-operator-7b8c99bb8b-7dnlk                     1/1     Running       1          17h
openshift-apiserver                                     apiserver-jmjrs                                                   1/1     Running       0          17h
openshift-apiserver                                     apiserver-mzkx6                                                   1/1     Running       0          17h
openshift-apiserver                                     apiserver-p2c7x                                                   1/1     Running       0          17h
openshift-authentication-operator                       openshift-authentication-operator-bb8775754-9s258                 1/1     Running       0          17h
openshift-authentication                                openshift-authentication-677f9f678-2djk7                          1/1     Running       0          17h
openshift-authentication                                openshift-authentication-677f9f678-b6p4p                          1/1     Running       0          17h
openshift-cloud-credential-operator                     cloud-credential-operator-5cf49888b5-ccktg                        1/1     Running       0          17h
openshift-cluster-machine-approver                      machine-approver-6cf997dbcc-g25cx                                 1/1     Running       0          17h
openshift-cluster-node-tuning-operator                  cluster-node-tuning-operator-cb6dd6bcb-2c72p                      1/1     Running       0          17h
openshift-cluster-node-tuning-operator                  tuned-6djpt                                                       1/1     Running       0          17h
openshift-cluster-node-tuning-operator                  tuned-dx6sl                                                       1/1     Running       0          17h
openshift-cluster-node-tuning-operator                  tuned-zwkng                                                       1/1     Running       0          17h
openshift-cluster-samples-operator                      cluster-samples-operator-749c4b7dc7-zc5hz                         1/1     Running       0          17h
openshift-cluster-storage-operator                      cluster-storage-operator-7d7fcb7b56-xzhfm                         1/1     Running       0          17h
openshift-cluster-version                               cluster-version-operator-56c74d99b9-4qxhf                         1/1     Running       0          17h
openshift-console-operator                              console-operator-589ddb9775-tll9h                                 1/1     Running       0          17h
openshift-console                                       console-595b47967-nqqkz                                           1/1     Terminating   1          17h
openshift-console                                       console-6d8db4c7df-b5gwh                                          1/1     Running       1          17h
openshift-console                                       console-6d8db4c7df-dqnn7                                          0/1     Terminating   0          17h
openshift-console                                       console-6d8db4c7df-vlkrd                                          1/1     Running       0          17h
openshift-console                                       downloads-7748c8d856-2bhqw                                        1/1     Running       0          17h
openshift-console                                       downloads-7748c8d856-wd56w                                        1/1     Running       0          17h
openshift-controller-manager-operator                   openshift-controller-manager-operator-5f78855946-xxj86            1/1     Running       1          17h
openshift-controller-manager                            controller-manager-fj5hk                                          1/1     Running       0          17h
openshift-controller-manager                            controller-manager-m5vhr                                          1/1     Running       0          17h
openshift-controller-manager                            controller-manager-tpdkm                                          1/1     Running       0          17h
openshift-dns-operator                                  dns-operator-6f9d679b9c-fqj8s                                     1/1     Running       0          17h
openshift-dns                                           dns-default-9t87q                                                 2/2     Running       0          17h
openshift-dns                                           dns-default-d942l                                                 2/2     Running       0          17h
openshift-dns                                           dns-default-pb227                                                 2/2     Running       0          17h
openshift-image-registry                                cluster-image-registry-operator-86885f6c8d-4csbf                  1/1     Running       0          17h
openshift-image-registry                                cluster-image-registry-operator-86885f6c8d-vvpzn                  1/1     Terminating   0          17h
openshift-ingress-operator                              ingress-operator-7f8dcf7bb9-hvk9r                                 1/1     Running       0          17h
openshift-ingress                                       router-default-55f4fcfd66-774t6                                   1/1     Running       0          17h
openshift-ingress                                       router-default-55f4fcfd66-k4gz2                                   0/1     Pending       0          17h
openshift-ingress                                       router-default-55f4fcfd66-phlq7                                   1/1     Terminating   0          17h
openshift-ingress                                       router-default-55f4fcfd66-z555w                                   1/1     Running       0          17h
openshift-kube-apiserver-operator                       kube-apiserver-operator-6976f454fb-r5tkj                          1/1     Running       1          17h
openshift-kube-apiserver                                installer-1-master-0                                              0/1     Completed     0          17h
openshift-kube-apiserver                                installer-1-master-1                                              0/1     Completed     0          17h
openshift-kube-apiserver                                installer-2-master-0                                              0/1     OOMKilled     0          17h
openshift-kube-apiserver                                installer-2-master-1                                              0/1     Completed     0          17h
openshift-kube-apiserver                                installer-2-master-2                                              0/1     Completed     0          17h
openshift-kube-apiserver                                installer-3-master-0                                              0/1     Completed     0          17h
openshift-kube-apiserver                                installer-3-master-1                                              0/1     Completed     0          17h
openshift-kube-apiserver                                installer-4-master-0                                              0/1     Completed     0          17h
openshift-kube-apiserver                                installer-4-master-1                                              0/1     Completed     0          17h
openshift-kube-apiserver                                installer-4-master-2                                              0/1     Completed     0          17h
openshift-kube-apiserver                                installer-5-master-0                                              0/1     OOMKilled     0          17h
openshift-kube-apiserver                                installer-6-master-0                                              0/1     Completed     0          17h
openshift-kube-apiserver                                installer-6-master-1                                              1/1     Running       0          17h
openshift-kube-apiserver                                kube-apiserver-master-0                                           2/2     Running       0          17h
openshift-kube-apiserver                                kube-apiserver-master-1                                           0/2     Init:0/2      0          17h
openshift-kube-apiserver                                kube-apiserver-master-2                                           2/2     Running       0          17h
openshift-kube-apiserver                                revision-pruner-1-master-0                                        0/1     Completed     0          17h
openshift-kube-apiserver                                revision-pruner-1-master-1                                        0/1     Completed     0          17h
openshift-kube-apiserver                                revision-pruner-2-master-0                                        0/1     Completed     0          17h
openshift-kube-apiserver                                revision-pruner-2-master-1                                        0/1     Completed     0          17h
openshift-kube-apiserver                                revision-pruner-2-master-2                                        0/1     Completed     0          17h
openshift-kube-apiserver                                revision-pruner-3-master-0                                        0/1     Completed     0          17h
openshift-kube-apiserver                                revision-pruner-3-master-1                                        0/1     Completed     0          17h
openshift-kube-apiserver                                revision-pruner-4-master-0                                        0/1     Completed     0          17h
openshift-kube-apiserver                                revision-pruner-4-master-1                                        0/1     Completed     0          17h
openshift-kube-apiserver                                revision-pruner-4-master-2                                        0/1     Completed     0          17h
openshift-kube-apiserver                                revision-pruner-5-master-0                                        0/1     Completed     0          17h
openshift-kube-apiserver                                revision-pruner-6-master-0                                        0/1     Completed     0          17h
openshift-kube-controller-manager-operator              kube-controller-manager-operator-7566b748b8-7wk4l                 1/1     Running       1          17h
openshift-kube-controller-manager                       installer-1-master-0                                              0/1     Completed     0          17h
openshift-kube-controller-manager                       installer-2-master-0                                              0/1     Completed     0          17h
openshift-kube-controller-manager                       installer-3-master-0                                              0/1     Completed     0          17h
openshift-kube-controller-manager                       installer-4-master-0                                              0/1     OOMKilled     0          17h
openshift-kube-controller-manager                       installer-5-master-0                                              0/1     OOMKilled     0          17h
openshift-kube-controller-manager                       installer-5-master-1                                              0/1     Completed     0          17h
openshift-kube-controller-manager                       installer-5-master-2                                              0/1     Completed     0          17h
openshift-kube-controller-manager                       installer-6-master-0                                              0/1     OOMKilled     0          17h
openshift-kube-controller-manager                       installer-6-master-1                                              0/1     Completed     0          17h
openshift-kube-controller-manager                       installer-6-master-2                                              0/1     OOMKilled     0          17h
openshift-kube-controller-manager                       kube-controller-manager-master-0                                  1/1     Running       2          17h
openshift-kube-controller-manager                       kube-controller-manager-master-1                                  1/1     Running       3          17h
openshift-kube-controller-manager                       kube-controller-manager-master-2                                  1/1     Running       0          17h
openshift-kube-controller-manager                       revision-pruner-1-master-0                                        0/1     Completed     0          17h
openshift-kube-controller-manager                       revision-pruner-2-master-0                                        0/1     Completed     0          17h
openshift-kube-controller-manager                       revision-pruner-3-master-0                                        0/1     Completed     0          17h
openshift-kube-controller-manager                       revision-pruner-4-master-0                                        0/1     Completed     0          17h
openshift-kube-controller-manager                       revision-pruner-5-master-0                                        0/1     Completed     0          17h
openshift-kube-controller-manager                       revision-pruner-5-master-1                                        0/1     Completed     0          17h
openshift-kube-controller-manager                       revision-pruner-5-master-2                                        0/1     Completed     0          17h
openshift-kube-controller-manager                       revision-pruner-6-master-0                                        0/1     Completed     0          17h
openshift-kube-controller-manager                       revision-pruner-6-master-1                                        0/1     Completed     0          17h
openshift-kube-controller-manager                       revision-pruner-6-master-2                                        0/1     Completed     0          17h
openshift-kube-scheduler-operator                       openshift-kube-scheduler-operator-cd7fd87ff-7jhlk                 1/1     Running       1          17h
openshift-kube-scheduler                                installer-1-master-0                                              0/1     Completed     0          17h
openshift-kube-scheduler                                installer-1-master-1                                              0/1     Completed     0          17h
openshift-kube-scheduler                                installer-1-master-2                                              0/1     Completed     0          17h
openshift-kube-scheduler                                installer-2-master-0                                              0/1     Completed     0          17h
openshift-kube-scheduler                                installer-2-master-1                                              0/1     Completed     0          17h
openshift-kube-scheduler                                installer-3-master-0                                              0/1     Completed     0          17h
openshift-kube-scheduler                                installer-3-master-1                                              0/1     Completed     0          17h
openshift-kube-scheduler                                installer-3-master-2                                              0/1     Completed     0          17h
openshift-kube-scheduler                                installer-4-master-0                                              0/1     Completed     0          17h
openshift-kube-scheduler                                installer-4-master-1                                              0/1     Completed     0          17h
openshift-kube-scheduler                                installer-4-master-2                                              0/1     Completed     0          17h
openshift-kube-scheduler                                openshift-kube-scheduler-master-0                                 1/1     Running       0          17h
openshift-kube-scheduler                                openshift-kube-scheduler-master-1                                 1/1     Running       3          17h
openshift-kube-scheduler                                openshift-kube-scheduler-master-2                                 1/1     Running       3          17h
openshift-kube-scheduler                                revision-pruner-1-master-0                                        0/1     Completed     0          17h
openshift-kube-scheduler                                revision-pruner-1-master-1                                        0/1     Completed     0          17h
openshift-kube-scheduler                                revision-pruner-1-master-2                                        0/1     Completed     0          17h
openshift-kube-scheduler                                revision-pruner-2-master-0                                        0/1     Completed     0          17h
openshift-kube-scheduler                                revision-pruner-3-master-0                                        0/1     Completed     0          17h
openshift-kube-scheduler                                revision-pruner-3-master-1                                        0/1     Completed     0          17h
openshift-kube-scheduler                                revision-pruner-3-master-2                                        0/1     Completed     0          17h
openshift-kube-scheduler                                revision-pruner-4-master-0                                        0/1     Completed     0          17h
openshift-kube-scheduler                                revision-pruner-4-master-1                                        0/1     Completed     0          17h
openshift-kube-scheduler                                revision-pruner-4-master-2                                        0/1     Completed     0          17h
openshift-machine-api                                   cluster-autoscaler-operator-6dd695cc7d-v2rx6                      1/1     Running       1          17h
openshift-machine-api                                   clusterapi-manager-controllers-5cf47db544-vg7dr                   4/4     Running       0          17h
openshift-machine-api                                   machine-api-operator-bd5f59899-z46pj                              1/1     Running       1          17h
openshift-machine-api                                   metalkube-baremetal-operator-8f9c66c86-mpq5t                      0/1     Terminating   0          17h
openshift-machine-api                                   metalkube-baremetal-operator-8f9c66c86-scgzw                      1/1     Running       0          17h
openshift-machine-config-operator                       machine-config-operator-767fcfcf74-5w5mv                          1/1     Running       1          17h
openshift-marketplace                                   certified-operators-5997774686-hkg4h                              1/1     Running       0          17h
openshift-marketplace                                   community-operators-7fbb7c4588-bbklz                              1/1     Running       0          17h
openshift-marketplace                                   marketplace-operator-78d556c764-l2zgv                             1/1     Running       0          17h
openshift-marketplace                                   redhat-operators-6b4f995b78-5csgz                                 1/1     Running       0          17h
openshift-monitoring                                    alertmanager-main-0                                               0/3     Pending       0          17h
openshift-monitoring                                    alertmanager-main-1                                               3/3     Running       0          17h
openshift-monitoring                                    cluster-monitoring-operator-5c68c9d967-th5qk                      1/1     Running       0          17h
openshift-monitoring                                    grafana-74876d8b8d-4qwqf                                          0/2     Preempting    0          17h
openshift-monitoring                                    grafana-74876d8b8d-6h8zm                                          2/2     Running       0          17h
openshift-monitoring                                    kube-state-metrics-56d947b89d-dfk66                               3/3     Terminating   0          17h
openshift-monitoring                                    kube-state-metrics-56d947b89d-l6jlz                               3/3     Running       0          17h
openshift-monitoring                                    node-exporter-4jjkc                                               2/2     Running       0          17h
openshift-monitoring                                    node-exporter-jsrzm                                               2/2     Running       0          17h
openshift-monitoring                                    node-exporter-kv4bb                                               2/2     Running       0          17h
openshift-monitoring                                    prometheus-adapter-c76d6596f-82vjk                                1/1     Running       0          17h
openshift-monitoring                                    prometheus-adapter-c76d6596f-lcnfv                                1/1     Running       0          17h
openshift-monitoring                                    prometheus-adapter-c76d6596f-q5kwq                                1/1     Terminating   0          17h
openshift-monitoring                                    prometheus-k8s-0                                                  0/6     Pending       0          17h
openshift-monitoring                                    prometheus-k8s-1                                                  6/6     Terminating   1          17h
openshift-monitoring                                    prometheus-operator-6ff74c9976-rmqvq                              1/1     Running       0          17h
openshift-monitoring                                    prometheus-operator-6ff74c9976-x52g6                              1/1     Terminating   1          17h
openshift-monitoring                                    telemeter-client-6579d7cf8-q7mkk                                  3/3     Running       0          17h
openshift-multus                                        multus-8j6kb                                                      1/1     Running       0          17h
openshift-multus                                        multus-98kcc                                                      1/1     Running       0          17h
openshift-multus                                        multus-nzm94                                                      1/1     Running       0          17h
openshift-network-operator                              network-operator-56b8ccdcbb-xd9q5                                 1/1     Running       0          17h
openshift-operator-lifecycle-manager                    catalog-operator-6865f8bd88-hwqth                                 1/1     Running       0          17h
openshift-operator-lifecycle-manager                    olm-operator-fccbd8798-9x77k                                      1/1     Running       0          17h
openshift-operator-lifecycle-manager                    olm-operators-zhkk2                                               1/1     Running       0          17h
openshift-operator-lifecycle-manager                    packageserver-544b89c886-8ldtr                                    0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-54569d7c8f-8j9sv                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-5486cc45fd-nqwvt                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-556df8d845-gcn7w                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-55b74df5bb-m2cqx                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-5647ff4c9b-z78cm                                    0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-5668b7bd5-ssvrf                                     0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-5687977596-db522                                    0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-56ccf9988b-f5rzq                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-576dddbcf6-f4fk8                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-58d68cfc8b-lpz5m                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-58f796cb5-zcfk8                                     0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-596f49576c-zj282                                    0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-599489cfbf-5tng4                                    0/1     Terminating   0          13h
openshift-operator-lifecycle-manager                    packageserver-5bc68c459b-mlpsg                                    1/1     Running       0          13h
openshift-operator-lifecycle-manager                    packageserver-5bc68c459b-mqxvq                                    1/1     Running       0          13h
openshift-operator-lifecycle-manager                    packageserver-5c548f4fb5-h6tpf                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-5c6c4f598b-xh7hv                                    0/1     Terminating   0          13h
openshift-operator-lifecycle-manager                    packageserver-5cc868cff6-kz2gb                                    0/1     Terminating   0          17h
openshift-operator-lifecycle-manager                    packageserver-5cdfd89cf9-r7bqn                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-5df46449fb-58pdm                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-5dfcd9fb56-fgmlc                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-6484b96c7-lxbnq                                     1/1     Terminating   0          17h
openshift-operator-lifecycle-manager                    packageserver-64cbcff7cb-chrv9                                    0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-64ff8c5b89-vnpj4                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-658d685bdf-t4j7v                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-65fb76c755-qgh47                                    0/1     Terminating   0          17h
openshift-operator-lifecycle-manager                    packageserver-66845969c7-qg7ks                                    0/1     Terminating   0          13h
openshift-operator-lifecycle-manager                    packageserver-669b56f59-xz8xb                                     0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-6798cc6565-49dlp                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-68475586b6-tx6wm                                    0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-687768b948-q9l9t                                    0/1     Terminating   0          17h
openshift-operator-lifecycle-manager                    packageserver-68bdb47898-lh6bm                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-68cf9fd6bf-dlbn9                                    0/1     Terminating   0          17h
openshift-operator-lifecycle-manager                    packageserver-69488c7665-zbvnt                                    0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-6988754f9c-t7rp2                                    0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-699795f5c6-22lxq                                    0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-6b59bdb4d7-2mgjc                                    0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-6d6548469d-k7jth                                    0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-6d8446c695-z5n4h                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-6d89c547c9-m8bk8                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-6f769fdc56-nqc8g                                    0/1     Terminating   0          13h
openshift-operator-lifecycle-manager                    packageserver-74cd8b5574-cg8gp                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-76648b7798-tpfsn                                    0/1     Terminating   0          17h
openshift-operator-lifecycle-manager                    packageserver-76d4b8dbc4-frmd5                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-77678bbdc-s6pd8                                     0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-7869f5c94f-vj6xn                                    0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-78d7685975-jwg4k                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-79d9f749bd-28h7x                                    0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-79ff46ccc5-kwpwg                                    0/1     Terminating   0          13h
openshift-operator-lifecycle-manager                    packageserver-7b5bbc9db6-xhpdb                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-7bbf6b9f9c-klrst                                    0/1     Terminating   0          13h
openshift-operator-lifecycle-manager                    packageserver-7bdf97c5d5-nzbfz                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-7c58db8f46-kh9db                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-7c64c778c7-gzlsd                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-7cf476b5b4-xpnm5                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-7dcc548b54-vvt6j                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-845c6bbf44-ppzmv                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-84b6f97575-s962t                                    0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-84c9cbb78c-bjskn                                    0/1     Terminating   0          13h
openshift-operator-lifecycle-manager                    packageserver-85985d844c-prpfw                                    0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-867448d9-f8cfq                                      0/1     Terminating   0          16h
openshift-operator-lifecycle-manager                    packageserver-8b74bd6d8-f8vk9                                     0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-b48c575c8-257jl                                     0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-b89585667-srqhn                                     0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-c4dd86cc9-tppd6                                     0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-c78858db-blkc8                                      0/1     Terminating   0          14h
openshift-operator-lifecycle-manager                    packageserver-c9f694678-fn8cd                                     0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-cc84784b6-nqnwr                                     0/1     Terminating   0          15h
openshift-operator-lifecycle-manager                    packageserver-cf694654d-c724r                                     0/1     Terminating   0          17h
openshift-sdn                                           ovs-7p2qf                                                         1/1     Running       0          17h
openshift-sdn                                           ovs-k8qbx                                                         1/1     Running       0          17h
openshift-sdn                                           ovs-z7wwv                                                         1/1     Running       0          17h
openshift-sdn                                           sdn-7xlxr                                                         1/1     Running       0          17h
openshift-sdn                                           sdn-controller-jfmj5                                              1/1     Running       0          17h
openshift-sdn                                           sdn-controller-nfmkf                                              1/1     Running       0          17h
openshift-sdn                                           sdn-controller-sl2g4                                              1/1     Running       0          17h
openshift-sdn                                           sdn-sjskt                                                         1/1     Running       2          17h
openshift-sdn                                           sdn-t8bc8                                                         1/1     Running       1          17h
openshift-service-ca-operator                           openshift-service-ca-operator-7957dd76c9-p7425                    1/1     Running       0          17h
openshift-service-ca                                    apiservice-cabundle-injector-6589bb696b-phqmw                     1/1     Running       0          17h
openshift-service-ca                                    configmap-cabundle-injector-787f7f684b-z78kn                      1/1     Running       0          17h
openshift-service-ca                                    service-serving-cert-signer-58f9487f4f-5stwv                      1/1     Running       0          17h
openshift-service-catalog-apiserver-operator            openshift-service-catalog-apiserver-operator-84d5b596c7-wghlc     1/1     Running       1          17h
openshift-service-catalog-controller-manager-operator   openshift-service-catalog-controller-manager-operator-77cf59cj8   1/1     Running       1          17h

Logs with internal hostname replaced by "HOSTNAME" string. Let me know in next ~3 days if you would like to see the actual system.
dev-scripts-make.log
01_install_requirements-2019-04-03-094035.log
02_configure_host-2019-04-03-094759.log
03_ocp_repo_sync-2019-04-03-094937.log
04_setup_ironic-2019-04-03-095417.log
04_setup_ironic-2019-04-03-095418.log
05_build_ocp_installer-2019-04-03-101309.log
06_create_cluster-2019-04-03-101407.log

Can you confirm if you had https://github.com/openshift-metalkube/dev-scripts/pull/254 applied please?
We were definitely seeing OOMKilled prior to that, but we probably need to look at the AWS flavors if the increase from #254 wasn't enough.
Also note you can re-test this with more memory by modifying tripleo-quickstart-config/metalkube-nodes.yml - it's a tough compromize because some folks want to do minimal testing on memory contrained hosts, and some want to do more realistic tests on a box with plenty of spare resources.

$ git log | grep d16dcdeca841b9ce291156c67a1ba47a9b2b8c98

Looks like I do not have it. Will pull, make clean and make. Thank you!

Now while make is running...
@hardys Problem I had was that even the host itself swapped something which means that on a host with 46GB RAM I can not increase VM's memory.

Ack thanks, looking at the openshift/installer code it looks like the default instance type for AWS is m4/m5 xlarge, which means 16GB and 4vCPU
Regarding the swapping, can you perhaps check if there are any other workloads consuming resources on the host?  I've been testing on a 32G host and it's not swapping, my assumption was that KSM was doing a good job of sharing duplicate pages between the VMs

That was a clean up2date CentOS7 installation - nothing else was running on the host. Only thing I have created was:
oc --config ocp/auth/kubeconfig new-app https://github.com/OpenShiftDemos/os-sample-python.git

I'll take a look at the closer memory consumption once make finishes.

OK, make is still running this loop:
level=debug msg="Still waiting for the Kubernetes API: Get https://api.ostest.test.metalkube.org:6443/version?timeout=32s: dial tcp <IP_ADDRESS>:6443: connect: connection refused"
level=debug msg="Still waiting for the Kubernetes API: Get https://api.ostest.test.metalkube.org:6443/version?timeout=32s: dial tcp <IP_ADDRESS>:6443: connect: connection refused"
level=debug msg="Still waiting for the Kubernetes API: Get https://api.ostest.test.metalkube.org:6443/version?timeout=32s: dial tcp <IP_ADDRESS>:6443: connect: connection refused"

this is an issue that is now solved.
i suggest you retry from scratch and feel free to increment memory and virtual cpus for the master nodes so that all pods can run

After new installation I have:
[kni@hp-dl360gen8-01 dev-scripts]$ oc --config ocp/auth/kubeconfig get pods --all-namespaces | wc -l
3447
[kni@hp-dl360gen8-01 dev-scripts]$ oc --config ocp/auth/kubeconfig get pods --all-namespaces | grep -v Running | wc -l
3339

I assume it is not healthy state? How to debug that please?

There's not enough information here to propose any fix, so I'm going to close this.  If you're still having issues please either raise another issue with more details, or jump onto slack and we can talk about the steps to debug, thanks!


Decouple Vacuum Tool From CT Example (WIP)

Not currently working due to some Spring issues but an idea of how much needs to be added from CT.
As this is a stand alone tool I don't think dependency on CT is that big of an issue. Other projects shouldn't depend on this code and having CT Core as a dependency gets rid of a lot of repetition

Coverage decreased (-28.6%) to 36.823% when pulling 698057b9b4187ca14f08f95cc619f66d21fb8814 on decouple-vacuum-tool-from-ct into 0b2e11876c83536ddc37223a128aa525d6d0c8a7 on general-purpose-vacuum-tool.


configurable engine for container images

Description of the change:
Allow the container engine to be configurable in the generated Makefile.
Motivation for the change:
For users running Podman or other container runtimes, this adds the capability to run make commands with a simple variable specifying their runtime.
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[x] Add or update relevant sections of the docs website in website/content/en/docs

Hi @everettraven,
Thanks for taking a look.  I've rebased now.

@itroyano Looks like the DCO check is now failing - if you look at the details of the failing check it should tell you how to resolve it, but the gist is that your commit is missing the sign-off

Added.

I see the latest version added a CONTAINER_TOOL option.  Thanks!
This PR can be closed now.


Star label loses focus as one gets closer to the star

Related to Issue #23. When getting closer to the star and the label expands, the label also loses focus/becomes blurry.
Regardless of the size of the label, its should be crisp and readable. This screenshot is identical to the one for issue 23.

same explanation. Its a 3D scene and while objects have a specific size and pixel density, when you zoom in on them that happens
I will have to figure out haw to dynamically change them

You're probably going to have to regenerate the scene when zooming so that the APPARENT size of the labels stays the same.
Similar to the rotation issue... although you probably don't have to re-generate the 3d scene until the rotation exceeds some value (50, 60 degrees)... but then, you pretty much have to re-gen in order to re-orient the labels to face the viewer.
Basically, I think you need to re-gen if the zoom changes by more than "X" percent.  My first guess is 25 or 30.  Zooming out is as bad as in since the labels get smaller...   and re-gen if the scene rotates by more than THETA in any direction.

label stays the same size at any range


Does not work on codespaces

Fails with following CSP error in console:
index.html?id=ecf3f705-5c6f-44be-808c-c32ae4e6ca53&origin=dc695ab0-0436-4d25-9221-918d6c757d15&swVersion=4&extensionId=ms-vscode.live-server&platform=browser&vscode-resource-base-authority=vscode-resource.vscode-cdn.net&parentOrigin=https%3A%2F%2Fdidactic-space-xylophone-4jx4gjj727rw5.github.dev&remoteAuthority=codespaces%2Bdidactic-space-xylophone-4jx4gjj727rw5:999

Refused to frame 'https://github.dev/' because it violates the following Content Security Policy directive: "frame-src https://didactic-space-xylophone-4jx4gjj727rw5-3000.app.github.dev".

Did you try the steps in the FAQ?

Q. I'm trying to use Live Preview in Codespaces and the embedded preview isn't working.
A. Currently, you will need to manually navigate to the links host the forwarded port content before it works
In the area of the editor where the integrated terminal usually is, navigate to Ports and open the local addresses (usually at ports 3000 and 3001) in the browser. You can do this by using CTRL+Click on the URLs in the Ports menu.
Allow the browser to perform the necessary redirects, then close the windows. Re-open the preview window and it should work now.

I think this was a duplicate of https://github.com/microsoft/vscode-livepreview/issues/546

I switched to latest prerelease and had to follow the steps from FAQ mentioned above to get this working.
@andreamah is this expected?
Also live reload does not work with simple static html files.

Yes, this is expected. The full functionality is tracked in https://github.com/microsoft/vscode-livepreview/issues/111.
To get the full functionality, click on the forwarded port link for both 3000 and 3001. 3001 will say 'update required', but this is expected since it is a websocket port.


HTML/Polymer file script gets stripped out

Here is my gist with the debug.md: https://gist.github.com/adefran83/35d95b8ab9a82fdcbe80
When attempting to beautify the html in the attached gist it removes everything below the

PrettyDiff defect.  I will have this patched in just a few.

Thank you so much for reporting this.  It's now fixed in v1.15.15.


adjusting the vertical axis of dos plot when --no-total is selected

in projected dos, when --no-total is used, the graph height/vertical axis seems to be still based on the height of the total DOS.
as a result, my projected dos is too small to analyze.
Is there a way to have the plot to automatically adjust based on the maximum height of the selected projection instead, when --no-total is used?
as it is now, i can only think of either using maybe --yscale to replot this manually, or use the dat file to plot it with spreadsheet or other software. Is there another way?

The reason the plots are scaled to the (invisible) total is that this gives consistent scaling when several plots are made for the same system. Clearly, in this particular case the outcome is not very useful!
I think in this case using --yscale will be the way to go, then you have the benefit that you can use the same scale factor for any other plots of the same system and keep things comparable.


add -e to echo command

To solve the problem of invalid escape characters, add the - e option to the echo command in the ". mk" files in the gateway/tool/make directory

Plz sign your commit first, and describe the details of the issue you pointed out.

You need to add SHELL=/bin/bash to common.mk, to specify the shell which makefile is using.
Others LGTM. Thank you @thredreams.

In fact, I didn't do this at the beginning because I was worried about whether there were some commands in the file that should not be executed in bash

In fact, I didn't do this at the beginning because I was worried about whether there were some commands in the file that should not be executed in bash

Not for now : )

Codecov Report

Merging #741 (533f0c0) into main (6be6950) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
- Coverage   63.62%   63.57%   -0.06%
==========================================
  Files          47       47
  Lines        5927     5927
==========================================
- Hits         3771     3768       -3
- Misses       1921     1922       +1
- Partials      235      237       +2

Impacted Files
Coverage Δ

internal/provider/kubernetes/gatewayclass.go
70.28% <0.00%> (-3.63%)
:arrow_down:

internal/provider/kubernetes/gateway.go
51.59% <0.00%> (+0.42%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks @thredreams, after CI passed, I am going to merge this.


Prefer start handler on top for same hour selection

When the start handler and the end handler are on top of each other, the end handler is show, but the start handler is the one that actually moves.

Imo, the start handler should be shown because it is selecting a whole day range, and the icon for start would be more appropriate

@cedvdb You may use drawInitHandlerOnTop <- TimePicker bool flag to achive this.


XcodeTask @Input for project dependencies

This will update the Podfile when the j2objc project dependencies change

PTAL

Please add a comment to CHANGELOG.md also; LGTM when passes.

@advayDev1 - it also required implementing writeObject() and calling defaultWriteObject(). I added deserialization as well, so that I could test it end it end. Curiously, the @EqualsAndHashCode wasn't needed, so I wanted your opinion on that.

Not throwing without EqualsAndHashCode makes sense.  However, I think you use it anyway: while serialization will work, you need it to make sure up-to-date checks are correct and even in Groovy, equality is referential unless overridden.

I'm not understanding why writeObject/defaultWriteObject were needed for you.  I don't have them.  Instead of doing that, consider using @AutoExternalize: http://docs.groovy-lang.org/2.4.5/html/gapi/groovy/transform/AutoExternalize.html

Aha: you don't have a default no-arg constructor for PodspecDetails.  Ok this makes sense now

I expect that Gradle is comparing Serialized binary to Serialized binary, that way that can get consistent behaviour over time and across daemon runs - they can't keep the object around in memory. The writeDefaultObject is a necessary part of serialization.

I'd still suggest using @EqualsAndHashCode - we don't know what the implementation detail of Gradle is (I looked briefly, couldn't find it).  Understood about writeDefaultObject, the point of @AutoExternalizable is to do that for you.  (I'm still trying to figure out why I don't need AutoExternalizable nor implementations of Serializable - but that is an aside).

I've added back @EqualsAndHashCode. Since the serialization is working (and is tested), I'm fine with doing it the Java way with writeDefaultObject().
One concern I have is that getPodspecDependencies() is called 2-3 times during the gradle run. I'm surprised that this happens. Dependending on how large the dependency trees become, this may need caching.
I'll merge this once the build is green.

sg - LGTM


updated URL that was resulting 404

[ ] I have followed (at least) the PR section of the contributing guide.

Updated url that was pointing to old branch.

@meera Thanks for the problem was already fixed :).


Cannot start server

Actual behavior (Required!)
Error when opening a java file and auto-completion isn't working
As if unable to work
Expected behavior (Required!)
Opening a java file without without error and make auto-completion work.
The steps to reproduce actual behavior (Required!)

Install vim-javacomplete2 using vim-plug
Open a java file
The input a line of Java Code

Environment (Required!)

OS: Windows 10
Vim version: VIM - Vi IMproved 8.1 (2018 May 18, compiled Oct 12 2018 22:03:58)
Neovim version: Don't have neovim

Q&A

Yes, I tried minimal .vimrc configuraion.
Yes, I have enabled logs with JCdebugEnableLogs and can put here content of JCdebugGetLogContent command, if you need.
Even, if you wish, I can set g:JavaComplete_JavaviLogLevel to 'debug', then set g:JavaComplete_JavaviLogDirectory, and put here server logs, too.

Screenshot (Optional)
The output of :redir and :message (Optional)
Failed to compile javavi server

You can try compile it manually. Go to vim-javacomplete2/libs/javai directory and run mvn compile

I have manually compiled javavi server but prompted Unknown function javacomplete#complete.
And when I open a java file, any operation of any plugin will give an error.
The strange thing is that I set the log directory but there is no log output.

Function should be javacomplete#Complete. Check if your config is right.

updating vimrc file according to the README file but when I open a java file, any operation of the plugin will go wrong.

Are you sure you have installed it right? What if you call it manually like this: :call javacomplete#Complete(1,1) ?

Yes, I am very sure that it has been installed.

https://github.com/xwcsgo/vim
This is my configuration file.

Other plugins still work. l have tried to reinstall but still error. The same error as above.

Does PlugInstall command list vim-javacomplete2?

Thank you, my vim can suddenly be used.

So, can we close it?


TAPT Logo Update

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

@TaurusPayToken
Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwalletapp.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:

Twitter: @trustwalletapp

Facebook: @trustwalletapp


[Cookiecutter Explorer] Banner's shade of yellow, "x", and feel does not match with other tools

Should we match the yellow color of the cookiecutter banner with the yellow color of the team explorer banner? Same for the feel: Our banner is embossed, Team Explorer’s is flat. Also the “x” are different. Not major, but looks a bit out of place now when you can have both tools open SxS.

We're using the built-in info bar functionality.  We provide text and links, and VS takes care of presentation.  Team Explorer doesn't use it.  They probably should match their color with the VS built-in info bar.


Widget related fixes

While checking out what has changed in the past months, I noticed that it was not possible to add widgets anymore, because the modal was always empty. This is because iteritems doesn't exist in python3 anymore.
I also ran into an issue trying to view the edit history widget while not being in a department. While this is not a usecase that should happen at the MPIB, I fixed it anyway.

awesome, thank you :)


[SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

What changes were proposed in this pull request?
In PR #30140, it will compare new and old plans when replacing view and uncache data
if the view has changed. But the compared new plan is not analyzed which will cause
UnresolvedException when calling sameResult. So in this PR, we use the analyzed
plan to compare to fix this problem.
Why are the changes needed?
bug fix
Does this PR introduce any user-facing change?
no
How was this patch tested?
newly added tests

cc @maropu

cc @maropu

Test build #134552 has started for PR 31365 at commit 3a048a7.

Test build #134552 has started for PR 31365 at commit 3a048a7.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39138/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39138/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39138/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39138/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39138/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39138/

Test build #134552 has finished for PR 31365 at commit 3a048a7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134552 has finished for PR 31365 at commit 3a048a7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134552/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134552/

The issue happens in branch-3.0 only?

The issue happens in branch-3.0 only?

Test build #134576 has started for PR 31365 at commit cc4645e.

Test build #134576 has started for PR 31365 at commit cc4645e.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39162/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39162/

@maropu the PR for master is merged: https://github.com/apache/spark/pull/31360

@maropu the PR for master is merged: https://github.com/apache/spark/pull/31360

Test build #134576 has finished for PR 31365 at commit cc4645e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134576 has finished for PR 31365 at commit cc4645e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134576/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134576/


How should i use co v4 in loops?

Hello folks,
For previous version of c (v3) we have few solutions on wiki page, but they doesn't work with v4.
I need something like this:
array.forEach(function *() {
    yield asyncFunction();
});

yield array.map(function (item) {
  return function * () {
    yield asyncFunction();
  };
});

BTW: this isn't StackOverflow.

Thanks. Sorry for that.

Should this be added to the examples? I can PR

better to do:
yield array.map(function* (item) {
  yield asyncFunction()
})

actually no... just do:
yield array.map(asyncFunction)

yes... example welcomed!

oh this question is for loops. i would do it this way:
for (let val of arr) {
  yield asyncFunction(val)
}


How to verify the VPA address using custom ui SDK - Flutter

I'm not able to find out a function to verify if the user's VPA is valid or not.
Can you guys redirect me to that function of this SDK?

@yashwp this issue is been resolved, please update our razorpay_flutter_customui SDK to 1.1.0 to get this validation method.

@ramprasadAnand can you please provide any sample


Create File Share: Type should have 2 volume types

Type should have 2 volume types: 3-way distributed replicated and Erasure Coded.
2-way distributed replicated is left off as we will plan on  arbiter volumes to cover that scenario in the future.
@japplewhite can confirm.
@gnehapk @nnDarshan @cloudbehl

@julienlim yes that's correct. In the very near future we will need to add 2 way with arbiter but not now.


[website] clear website status at McAfee

WTF?!
The website was flagged / categorized as "- Malicious Sites"
at McAfee's database, which is used by products like SiteAdvisor.
This means their products are blocking the website.
I did not receive a message or warning about the status change
nor a message about the potential threat they might have found.
They simply blacklisted the website.
I've have contacted McAfee to clear the website status
over at https://www.trustedsource.org/
Ticket ID 1233984 - Opened 16/May/2016.

Ticket_ID 1233984 Reviewed Progress Report for URL Submissions

Status:Reviewed
URL: http://wpn-xm.org
Initial categories: Malicious Sites
Post-review categories: Software/Hardware
Which List: ts
Please allow the Web Reputation some time to update.
In some cases, the Web Reputation shown at the time of the ticket closure may not reflect the updated Web Reputation.
Updates at times may take longer to complete. Please consult TrustedSource.org to verify the published Web Reputation for any given URL or IP address.
List Number Closed: -

Ticket_ID 1233984 Closed Progress Report for URL Submissions

Status:Closed
URL: http://wpn-xm.org
Initial categories: Malicious Sites
Post-review categories: Software/Hardware
Web Reputation: Minimal Risk
Please allow the Web Reputation some time to update.
In some cases, the Web Reputation shown at the time of the ticket closure may not reflect the updated Web Reputation.
Updates at times may take longer to complete. Please consult TrustedSource.org to verify the published Web Reputation for any given URL or IP address.
List Number Closed: 195881


Enhance the syntax checker to display better error message

A small change to add missing parameter to syntax checker
Now, the error message is more clear
(NimbleOptions.ValidationError) expected :syntax option to match at least one given type, but didn't match any. Here are the reasons why it didn't match each of the allowed types:

invalid value for :syntax option: The module specified ‹Ray.Vm› does not implement requested callbacks ‹[validate: 1, parse: 1, lint: 1]›
invalid value for :syntax option: expected one of [:flowchart, :state_diagram], got: Ray.Vm

Stacktrace:
│ lib/ray/vm.ex:6: (module)

Package published to https://hex.pm/packages/finitomata/0.11.3
(91c2a4c26823a9223a47c767f2336f0699ba08f90eb148df96db4af2f645479b)


Caddy - add Caddy HTTP Rate Limit Module

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ x] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[x ] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[ x] When the request is meant for an existing plugin, I've added its name to the title.

Is your feature request related to a problem? Please describe.
As I use caddy as a reverse proxy for api first applications. A would suggest a solution for rate limiting that is actively supported.
Describe the solution you'd like
@Monviech  , I would like to propose the integration of Caddy HTTP Rate Limit Module, developped by Caddy author.
Describe alternatives you've consideredN/A
Additional context
N/A

Hey, this looks like a rather big addition. It would need a contributer.
Here is an example how to extend this plugin with an additional optional module:
https://github.com/opnsense/plugins/pull/4112
Additionally to that, the caddy-custom build would need to include this module. Check the opnsense/tools repository.
Im leaving this open if somebody wants to contribute this functionality with a PR.

Hey, this looks like a rather big addition. It would need a contributer.

@Monviech I have admittedly not clearly defined the scope of my request.
Allow me to clarify:
I use the caddy plugin exclusively through /caddy.d config files. Since rate limiting is a very recommended security feature, I am hoping you could add the http rate limit module into the caddy build without any UI addition at all. People who need this feature will want to modify the caddy file manually anyway in my opinion.
Maybe if/when the feature gains popularity the community can ultimately step up regarding a future UI.
thank you in advance.

Thanks for clarifying. Im unsure about adding a module to the build that is not exposed in the GUI.
@fichtner whats your opinion on this?

We do it sometimes. The question is if it poses a risk to others or if it bloats the build too much. Risk of future breakage also is a factor, but less problematic because then it can just be removed again if in need to fix the build.

We do it sometimes. The question is if it poses a risk to others or if it bloats the build too much. Risk of future breakage also is a factor, but less problematic because then it can just be removed again if in need to fix the build.

My reading into it is that the risk factor is not applicable in this use case. And it is not a heavy module either + as long as it is not called it will not have any performance impact from my understanding.
But I can think you’ll be more positioned to judge ofc.

Since its a module from mholt directly I see no issue adding it to the build. I'll evaluate it later and if my test xcaddy build works I'll add it to the opnsense/tools built.

@Roeda The new pkg will come automatically with the next OPNsense version (community).

thank you very much sir


if publish call fails, cannot be resubmitted without refresh

Submitted an upload with a name that I guess I have another claim for (maybe a playlist, but wasn't alerted to that).  Will confirm and file separately. Will retest on neko too, wanted to document.
This process can fail for other reasons, and should be retriable. Preview publish is on.

@toshokanneko I think you fixed this right? If not, please re-open.

This is still broken in the case of this modal popup.


NJPW World no video formats found

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.02.26. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.02.26

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://njpwworld.com/p/s_series_00461_09', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2018.02.26
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.15063
[debug] exe versions: none
[debug] Proxy map: {}
[NJPWWorld] s_series_00461_09: Downloading webpage
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfqykkd7x\build\youtube_dl\YoutubeDL.py", line 785, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfqykkd7x\build\youtube_dl\extractor\common.py", line 440, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfqykkd7x\build\youtube_dl\extractor\njpwworld.py", line 79, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfqykkd7x\build\youtube_dl\extractor\common.py", line 1071, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
NJWP World is listed under supported sites but when I run the command it gives the error above.  Youtube-dl does not seem to be picking up the video present on the webpage.

This video requires paid subscription. For any further work on the issue you must provide account credentials.

I will send the login credentials to your e-mail.  Thanks!

Credentials data provided is no longer enough to access this video. Though it may work in the next release.


add scheduling blog

Signed-off-by: Bill Mulligan<EMAIL_ADDRESS>

nit: Could we add a small image to it? Even if just a partial screenshot from the motivation letter, but would be nice.


How to embed "regular" JS-Libs (e.g. Chart.js, dragula.js) in dev & prod built

There are a lot of discussions going on regarding the --prod built and how difficult it can be to embed 3rd-Party libraries.  So far I have managed to add the following libraries, they run perfectly in dev and prod-built with beta5

ng2-uploader
ng2-bootstrap
ng2-table

I wanted to add ng2-dragula and ng2-charts but each of them rely on a separate JavaScript-Library (chart.js and dragula.js) which I am only able to get up and running in dev-mode and when I add the import to index.html.
When I add them via system-config.js I only get errors. I tried changing the format to cjs or register or just leave it away. But I didn't find a way to add a "regular JS library like "Chart.JS" to the angular-cli project so that it runs in dev and --prod mode.

I was able to get Chart.JS and dragula.js working by declaring it a "global" module in system-config.ts
  'chartjs':{ format: "global" },
and importing it in my main-component import 'chartjs so that SystemJS knows that is has to include it into its combined main.js.
I don't know if this should be in the docs, since this is an SystemJS issue but it would be great to have it in the "How to install 3rd party libs" section.

Heya, glad to know that you got it working! I'll try to add it to the wiki when reviewing the angular2-material example.
Meanwhile I might just redirect people here when they have similar issues. Cheers!

It doesn't work in my case, I used jquery and bootstrap and tried defining the format global but it still not able to recognise them. Finally, I moved them to public folder and used them in index file. Please help if there is another working approach exists

+1


Update the secure naming based on the SAN in the actual GCP certificates

Update the secure naming based on the SAN in the actual GCP certificates

/cc @wattli

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lei-tang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ayj
If they are not already assigned, you can assign the PR to them by writing /assign @ayj in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lei-tang, wattli
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [wattli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fauxmo Device Types

Fuxmo trick is what all Arduino/Alexa people talk about. And, Yes... it's a great way to connect/control your own switch/plug by your phone too.
However, any descent approach of any descent engineer and/or hobbyist must involve a wide variety of device types, like dozens of sensors, valves, locks, meters etc.
Another problem is that Alexa sees my "Fauxmo" gadgets as Belkin (or such) switches, which looks embarrassingly fraudulent even for my family members.
Is there a way that I connect to any of these gateways (like Alexa) with my own authentic device?

At this time I think the only way to do that would be to make your own Alexa skill.


try out if codecov works now

ref:

https://github.com/openstax/cnx-recipes/issues/5516
https://github.com/openstax/ce/issues/2214

fixes https://github.com/openstax/ce/issues/2214


Provide alternate ways to add version to a file path for cache busting.

Currently the only way to add version to a file path is query string. That is, http://someurl.com/hello becomes http://someurl.com/hello?v=hashed_string. But some popular proxies do not cache the query string at all. As a result, it is not cache busted : http://www.stevesouders.com/blog/2008/08/23/revving-filenames-dont-use-querystring/
An alternate is to provide an option to modify the file name itself. I suggest it look something like: <script src="js/something.js" asp-file-version="true" asp-file-version-method="filename" />. Depending on asp-file-version-method we could modify the method appropriately.

We can revisit this based on customer feedback.


IronCAD 2019 does not work with DXVK 1.9.2

Following things were given:
HOME_PATH="/home/ubuntu"
WINE_PATH="${HOME_PATH}/.ironcad"
ARCHITECTURE="win64"
WINE="wine64"
I executed following commands:
WINEPREFIX="${WINE_PATH}" WINEARCH="${ARCHITECTURE}" winetricks -q dxvk
WINEPREFIX="${WINE_PATH}" WINEARCH="${ARCHITECTURE}" winetricks -q win10

WINEPREFIX="${WINE_PATH}" WINEARCH="${ARCHITECTURE}" ${WINE} IronCADDCS2019_x64.exe

WINEPREFIX="${WINE_PATH}" WINEARCH="${ARCHITECTURE}" ${WINE} \
"${WINE_PATH}"/drive_c/Program\ Files/IronCAD/2019/bin/IRONCAD.exe

Downloading the IronCADDCS2019_x64.exe can be problematic with Wine since the exe file installer requires dependencies that I've not figured out yet. I just got the IronCADDCS2019_x64.exe through VirtualBox through Windows. Download link is https://community.ironcad.com/index.php?/files/file/13-ironcad-2019-release-version/
The installent went ok, beware that when you start the application you have to hit the return key at least once maybe twice for it start, otherwise it just stays idle. Once started, you select a new 3D scene. Then you will be notified in the terminal that 3D scene can't be created and application crashes within a minute or two.
0680:fixme:vulkan:X11DRV_vkCreateWin32SurfaceKHR Application requires child window rendering, which is not implemented yet! err:   Failed to create surface

I tested by creating a new 3D scene with both DirectX 9 and DirectX 11, same result. To select rendering driver go to menu->tools->Options->Rendering then there you can select either DirectX9 or DirectX11.
Software information

Distro: Ubuntu 20.04
Application: IronCAD 2019

System information

GPU: Advanced Micro Devices, Inc. [AMD/ATI] Baffin [Radeon RX 460/560D / Pro 450/455/460/555/555X/560/560X]
Driver:

filename:       /lib/modules/5.4.139-0504139-generic/kernel/drivers/gpu/drm/amd/amdgpu/amdgpu.ko
version:        <IP_ADDRESS>.30
license:        GPL and additional rights
description:    AMD GPU
author:         AMD linux driver team

Wine version:

wine-staging-amd64/focal,now 6.20~focal-1 amd64 [installed]
wine-staging-i386/focal,now 6.20~focal-1 i386 [installed]
wine-staging/focal,now 6.20~focal-1 amd64 [installed]
winehq-staging/focal,now 6.20~focal-1 amd64 [installed]
winetricks/focal,focal,now 0.0+20200412-1 all [installed]

DXVK version: 1.9.2

Apitrace file(s)
Unsuccesful with the command WINEPREFIX="${WINE_PATH}" WINEARCH="${ARCHITECTURE}" ${WINE} apitrace-latest-win64/bin/apitrace.exe trace -a dxgi "${WINE_PATH}"/drive_c/Program\ Files/IronCAD/2019/bin/IRONCAD.exe application wouldn't even start.
Log files

d3d9.log: IRONCAD_d3d9.log
d3d11.log: IRONCAD_d3d11.log
dxgi.log: IRONCAD_dxgi.log
d3d9_wine.log: IRONCAD_d3d9_wine.log
d3d11_wine.log: IRONCAD_d3d11_wine.log

I've seen your posts on the Wine bug pertaining to vulkan child window support, so you are aware this is still an unfixed Wine issue with only an experimental patch available...
Secondly, you're trying to get DXVK working with llvmpipe? Really?

@WinterSnowfall 'vulkaninfo | grep amd' gives me

GPU id 	: 0 (AMD RADV POLARIS11)

I didn't try anything to get DXVK work especially with llvmpipe, and yes, I've run several other kind of CAD Windows applications in Wine and several of Steam games with Proton (Wine) without bothering about the graphic driver details.
I am aware of this bug exist, I didn't mind reporting it here since I'm not sure how the WineHQ bug community and DXVK community works together by implementing/fixing DirectX to Vulkan DirectX 9/11 transformation features to Wine upstream.

I'm not sure how the WineHQ bug community and DXVK community works together by implementing/fixing DirectX 9/11 to Vulkan transformation rendering features to Wine upstream.

They don't - they're entirely separate projects. DXVK is indeed included in Proton but not in Wine.
This is a Wine bug, not a DXVK bug, so not much good will come out of reporting it here.
As to your setup, I guess it looks fine as per your output above, but then why do all the logs you've captured default to llvmpipe? llvmpipe/lavapipe is a software vulkan implementation, so don't expect it to work properly. You are warned as such in the logs you've shared: WARNING: lavapipe is not a conformant vulkan implementation, testing use only.

Noted.

At least this issue '"fixme:vulkan:X11DRV_vkCreateWin32SurfaceKHR Application requires child window rendering, which is not implemented yet!"' was mentioned here in the DXVK community in the past https://github.com/doitsujin/dxvk/issues/879

At least this issue '"fixme:vulkan:X11DRV_vkCreateWin32SurfaceKHR Application requires child window rendering, which is not implemented yet!"' was mentioned here in the DXVK community in the past #879

I'm aware of the bug because I raised an issue about it here myself (https://github.com/doitsujin/dxvk/issues/1770). It's not something which can be fixed in DXVK, though it affects it in a manner in which all vulkan apps running in Wine are affected.

At least this issue '"fixme:vulkan:X11DRV_vkCreateWin32SurfaceKHR Application requires child window rendering, which is not implemented yet!"' was mentioned here in the DXVK community in the past #879

I'm aware of the bug because I raised an issue about it here myself (#1770). It's not something which can be fixed in DXVK, though it affects it in a manner in which all vulkan apps running in Wine are affected.

I looked at one of the patches that Patrik suggest works, https://github.com/Frogging-Family/wine-tkg-git/blob/master/wine-tkg-git/wine-tkg-patches/misc/childwindow.patch https://github.com/Frogging-Family/wine-tkg-git/issues/358. By looking at what commit it applies to I can see that it applies to Wine mainline commit bca1b7f , the patch is applied for Wine version 6.20 and above. I did run the building and installation of the repository in a container context with the commands:
WORKDIR /usr/src/wine-tkg-git/wine-tkg-git

RUN sed -i "/'jack2'                 'lib32-jack2'/d" PKGBUILD
RUN sed -i "/'gst-plugins-good'      'lib32-gst-plugins-good'/d" PKGBUILD
RUN bash -c 'yes | PKGDEST=/tmp/wine-tkg makepkg --noconfirm -s'

I executed it literally the same way as the pipeline is executed for the Arch Linux distro https://github.com/Frogging-Family/wine-tkg-git/blob/master/.github/workflows/wine-arch.yml since that distro has best support (least complications) for multi-arch compilation compared to Ubuntu/Debian.
You can easily redirect the rendering to X11 and still preserve the bare metal speed if it's OCI container like Docker.
I don't get the child window error anymore, now it's

err:   D3D11CreateDevice: Failed to create a DXGI factory

So at least some progress.

I applied by running the child window patch from  https://github.com/Frogging-Family/wine-tkg-git/blob/master/wine-tkg-git/wine-tkg-patches/misc/childwindow.patch and by installing the Wine version 6.20 by the following commands on my Arch Linux distro
cd /usr/src/wine-tkg-git/wine-tkg-git # checked out git commit 6bffd57

sed -i "/'jack2'                 'lib32-jack2'/d" PKGBUILD
sed -i "/'gst-plugins-good'      'lib32-gst-plugins-good'/d" PKGBUILD
sudo bash -c 'yes | PKGDEST=/tmp/wine-tkg makepkg --noconfirm -s'

sudo pacman -U --noconfirm /tmp/wine-tkg/wine-tkg-staging-fsync-git-6.20.*.pkg.tar.zst

Following things were given:

HOME_PATH="/home/winer"
WINE_PATH="${HOME_PATH}/.ironcad"
ARCHITECTURE="win64"
WINE="wine64"

I executed with following commands:
WINEPREFIX="${WINE_PATH}" WINEARCH="${ARCHITECTURE}" winetricks -q dxvk
WINEPREFIX="${WINE_PATH}" WINEARCH="${ARCHITECTURE}" winetricks -q win10

WINEPREFIX="${WINE_PATH}" WINEARCH="${ARCHITECTURE}" ${WINE} IronCADDCS2019_x64.exe

WINEPREFIX="${WINE_PATH}" WINEARCH="${ARCHITECTURE}" ${WINE} \
"${WINE_PATH}"/drive_c/Program\ Files/IronCAD/2019/bin/IRONCAD.exe

Once started,after selecting a 3D scene. Then you will be notified in the terminal that 3D scene can't be created and application crashes within a minute or two. No more '"fixme:vulkan:X11DRV_vkCreateWin32SurfaceKHR Application requires child window rendering, which is not implemented yet!", that seems to be fixed with the mentioned applied patch above.
Software information

Distro: Arch Linux

LSB Version:	1.4
Distributor ID:	Arch
Description:	Arch Linux
Release:	rolling "archlinux:base-devel-20211017.0.36769"
Codename:	n/a

Application: IronCAD 2019

System information

GPU: Advanced Micro Devices, Inc. [AMD/ATI] Baffin [Radeon RX 460/560D / Pro 450/455/460/555/555X/560/560X]
Driver: radv

driverID                                                = DRIVER_ID_MESA_RADV
driverName                                          = radv
driverInfo                                             = Mesa 21.2.4
conformanceVersion                            = <IP_ADDRESS>

Wine version: wine-tkg-staging-fsync-git 6.20.r10.gdf26057d-326

DXVK version: 1.9.2

Apitrace file(s)
Not available.
Log files

d3d9.log: IRONCAD_d3d9.log
d3d11.log: IRONCAD_d3d11.log
dxgi.log: IRONCAD_dxgi.log
d3d9_wine.log: IRONCAD_d3d9_wine.log
d3d11_wine.log: IRONCAD_d3d11_wine.log

What exactly is the problem now and how exactly are we supposed to fix it?

What exactly is the problem now and how exactly are we supposed to fix it?
Also

0200:fixme:d3dcompiler:D3DCompile2 HLSL shader compilation is not yet implemented.

not a dxvk problem, you'll need some native d3dcompiler libraries.

Ok, I close the issue again and dig deeper into what d3dcompiler libraries I'm missing.

What exactly is the problem now and how exactly are we supposed to fix it?
Also

0200:fixme:d3dcompiler:D3DCompile2 HLSL shader compilation is not yet implemented.

not a dxvk problem, you'll need some native d3dcompiler libraries.

I needed to install the d3dcompiler_47 library. I see still rendering issues, but it's app related.

Thank you for your time.

For the sake of completeness it should be added here:
CAD and stock Wine users should look into this matter with Gallium Nine instead of DXVK. (The later is also in 2023 still broken because of the missing Vulkan "child window rendering support" in Wine.)
Yes, d3d9 is super old but even in 2023 some CAD software still comes with a fallback for this ancient rendering path. Furthermore, it looks that at least IronCAD 2019 effectively had some support for d3d9.
Finally it is confirmed for Autodesk-Fusion-360 that the mentioned "child window rendering support" is working with Gallium Nine. More information can be found here.
Note, - regarding newer Wine releases (from 7.x and up) I would clearly not recommend to install the native Windows 7 gdiplus.dll via winetricks. It causes more problems than it helps. If a native MS gdiplus.dll is really needed then get a newer one from Windows 10 and make a manual override via winecfg. :wink:


Use typescript for jest config

What's the rationale for this change? I don't mind the change, but like to understand is there is something specific that it solves.

What's the rationale for this change? I don't mind the change, but like to understand is there is something specific that it solves.

Nothing specific, just nicer to use same syntax for everything.


Breadcrumbs capture backspace from editor

Issue Type: Bug
When I have breadcrumbs enabled I cannot use the backspace key in the editor, because it is captured by the breadcrumbs as seen in the gif below. This happens whether or not I have any extensions enabled. I do not see any errors in the developer console. The suggested fix from the related issue in #28737 does not apply here.
Screencast

Steps to reproduce

Enable breadcrumbs (View > Show Breadcrumbs)
Open an editor and try backspacing to remove some text
Observe that hitting backspace causes the breadcrumbs to focus, rather than deleting text.

Expected behavior
Pressing backspace deletes text while the editor is focused
Observed behavior
Pressing backspace focuses the breadcrumbs
VS Code version: Code 1.36.0 (0f3794b38477eea13fb47fbe15a42798e6129338, 2019-07-03T13:09:31.507Z)
OS version: Darwin x64 18.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz (8 x 2300)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.79GB free)

Process Argv
-psn_0_376924

Screen Reader
no

VM
0%

Extensions (9)

Extension
Author (truncated)
Version

vscode-eslint
dba
1.9.0

gitlens
eam
9.8.2

vsc-material-theme
Equ
29.2.0

rainbow-csv
mec
1.1.1

vscode-language-babel
mgm
0.0.22

theme-monokai-pro-vscode
mon
1.1.13

python
ms-
2019.6.22090

material-icon-theme
PKi
3.8.0

vscode-icons
vsc
8.8.0

(2 theme extensions excluded)

@idreyn Can you try with 1.36.1 that we have release yesterday? Also, can you paste your keybindings.json file (F1 > Open Keyboard Shortcuts (JSON))

Ah, I found the issue in keybindings.json!
{
    "key": "backspace backspace",
    "command": "breadcrumbs.focus",
    "when": "breadcrumbsPossible"
},
{
    "key": "shift+cmd+;",
    "command": "-breadcrumbs.focus",
    "when": "breadcrumbsPossible"
}

I'm not sure how these came to be here, but it definitely fixes the problem, thanks!