Update Subscription Status with Deprecation Warnings

Description of the change:
Adds the OperatorDeprecated Condition to the status of Subscriptions when the bundle has been deprecated.
Doing this in the step resolver is convenient because:

We have ready access to the cache entries.
Subscription status is already updated in this area.
Deprecated status should be added promptly if a catalog update occurs which adds the property to a bundle.

Modifying the subscription status within the resolver was both problematic and risky. We've changed strategies and are now updating status during catalog state update. This carries much lower risk.
Remaining Tasks:

[x] Populate cache entries with deprecation info.
[x] Add additional deprecation condition types (package, channel, bundle).
[x] Update logic in catalog operator's syncResolvingNamespace to account for subs updated with only OperatorDeprecated and do not necessarily require InstallPlan updates in the namespace (currently it assumes all updates are new bundles).
[x] Update test and/or add more tests with additional condition types (as above).
[x] Update go.mod to use merged/released API updates to api and registry.
[x] Squash commits where appropriate.

Motivation for the change:
Closes #3099
Brief
RFC
Architectural changes:

/lgtm

/approve

/lgtm


style: add margin to pages AB#28184

Describe your changes
Add a wider horizontal margin to pages.
It was decided by Tijs to make it 5% of the viewport width
Additional changes in this PR:

Bring tabs-component out of navigation-component and remove the latter
Improve L&F of disable-registrations component and align it with the tabs
Align the import button to the others in its row

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added tests wherever relevant
[x] I have made sure that all automated checks pass before requesting a review
[x] I do not need any deviation from our PR guidelines

@arsforza @elwinschmitz I am merging this branch to feature branch. From my side, the changes looks fine.


Feature request - orderBy

Hey there 👋
First off, thanks for providing this library. Really makes unit testing with Prisma a breeze.
When you get a chance, I'd love to request for the orderBy functionality.
Thanks!

Hello @adamtay , thanks a lot! I'm having a look, I hope to get it working in a few days!

Hello,
Good news, a new version has been published (1.15.0) with a first version of orderBy.
I noted it as a partial implementation: different databases have different behaviours when it comes to ordering elements with the same values. Otherwise, the order is working as expected.
I'll close this issue for now. Feel free to let me know if you're experiencing issues with orderBy.

amazing! thanks for the update

Thanks @morintd!


Improve food models by taking country into account.

For some more remote locations, like Iceland - most food items and even gasoline is shipped there, increasing their carbon footprint.
To be able to take this into account we'd have to:

[ ] Identify countries for which this is an issue (other than Iceland)
[ ] Find scientific analysis of how much this increases average item CO2eq
[ ] Implement country factor

We will get more clarity with ADEME, let's reopen when we have data.


re-add default database

This PR re-adds the default dataset.
It should fix #145.
I mistakenly deleted this in #131.

Let's merge this one instead: https://github.com/unitycatalog/unitycatalog/pull/102, it fixes a few other issues and also ensures that this cannot happen again.

Shall we close this PR now?

Yep, closing this and glad we have another PR to fix this the right way!


[BEAM-8280] Enable and improve IOTypeHints debug_str traceback

Improve format
Add multiple bases (in .with_defaults())
Include debug_str output in ptransform.py TypeCheckErrors.

Example format: https://gist.github.com/udim/9638eac962b0d89893c4a88c14be0476#file-less_verbose

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @kennknowles @robertwb


Schnorr & Taproot extension of Bitcoin Core TestFramework library

This is the Schnorr & Taproot library extension of the Bitcoin Core Python TestFramework I have been working on during my residency. Although the TestFramework is intended to provide functional test coverage for the Bitcoin Core project, it can also serve as a convenient Schnorr/Taproot prototyping tool for developers.
The goal of this project was to provide a toolkit for users to quickly prototype new Bitcoin contracting proposals with Schnorr & Taproot, so that the community can quickly get familiar and provide constructive feedback.
Schnorr extensions

[x] Musig signature aggregation
[ ] Adaptor Signature generation (Removed from this PR, out of scope for Optech)
[ ] Discrete Log Contract key generation (Removed, out of scope for Optech)

Taproot output classes (Segwit V1)

[x] Taptree & constructor methods (huffman construtor with weighted tapleafs)
[x] Tapscript descriptors (see below)

Minscript classes (can be composed to (correctly) express tapscript descriptors)
For example:

[x] pkolder(key, time) = and_v(v:pk(key),older(time))
[x] csahash(n, keys, hash) = and_v(v:thresh_csa,ripemd160)
[x] csahasholder(n,keys,hash,time) = and_v(v:thresh_csa ,and_v(v:ripemd160(hash), older(time)))

Utility Classes/Methods

[x] TestWrapper class wraps functionality of BitcoinTestFramework for external usage.
[x] Refactor BitcoinTestFramework to encapsulate code in main into setup and shutdown, in order to prevent current code duplication in TestWrapper. I will also create a PR in master for this once completed.

Future work

[ ] Complete miniscript language support.
[ ] Policy to Miniscript compiler for Taproot outputs (Policy language can provide flexible composition of spending conditions for taproot outputs. The compiler will separate policy sub-expressions in different tapleafs for user-defined privacy.)

Your feedback and review is greatly appreciated.
I am currently documenting the library in form of interactive jupyter notebook files in bitcoinops/taproot.

Hi James. Thanks for removing the adaptor signature/DLC stuff. There are still a couple of things more to do before this is ready for review:

squash the 'fixup' commits. (eg remove the Removed Whitespaces. Edited var name & comments. and Min nVersion corrected to 1 in tests. commits)
make the framework changes in the same (or consecutive) commits to the tests in which they're first used.

Could you also open a PR just for the Add TestFramework reset required by TestWrapper. and Reorganization of BitcoinTestFramework main method. commits please (since we'd want to get those merged into bitcoin/bitcoin).

squash the 'fixup' commits. (eg remove the Removed Whitespaces. Edited var name & comments. and Min nVersion corrected to 1 in tests. commits)
make the framework changes in the same (or consecutive) commits to the tests in which they're first used.

Could you also open a PR just for the Add TestFramework reset required by TestWrapper. and Reorganization of BitcoinTestFramework main method. commits please (since we'd want to get those merged into bitcoin/bitcoin).

Hi @jnewbery - Many thanks for the preliminary review. I have addressed your comments as suggested.

I've force pushed a change to fix some general best practices:

wrapped commit logs at 120 chars
removed unused python imports and sorted imports according to PEP 8.

force-pushed some more updates:

changed file permissions so test files are runnable (chmod 755)
renamed test files to be feature_ instead of framework_
added boilerplate licence text and doc strings
fixed all flake8 warnings

@jnewbery - Many thanks for your detailed review. I have incorporated all of your feedback in the latest push.

I've force-pushed a branch that squashes the latest changes into the appropriate commits, and also adds the tests to test_runner.py

@jachiang - this code is still undergoing active development in the https://github.com/bitcoinops/taproot-workshop repo. I suggest we close this PR until that's settled down, and then perhaps you can re-open against https://github.com/bitcoin/bitcoin when there's a schnorr/taproot PR?

@jachiang - this code is still undergoing active development in the https://github.com/bitcoinops/taproot-workshop repo. I suggest we close this PR until that's settled down, and then perhaps you can re-open against https://github.com/bitcoin/bitcoin when there's a schnorr/taproot PR?

Sounds good @jnewbery! Many thanks again for your extensive review on this PR.


Fix: Missed one.

Resolves #

Description
Found an issue where dates weren't being formatted correctly in widgets
Proposed Changes
Same as yesterday's bug fix, just missed one.
Screenshots

Truly inspiring work.


Install Dependencies not running before unittests

I was just setting up a little lab with the sample projects included with package just to see how the package worked, etc.
Create a separate directory called pybuilder-samples, copied the sample files in there, made a virtualenv, pip install pybuilder into it and then ran them.
It looks like maybe these are set up with the some "fill in the blanks" stuff but I wanted to get these working before doing anything more complicated.
When I try to run "simple-python-project" I get an error saying it can't find mockito. I had adjusted the build.py to be the same as in the tutorial:
from pybuilder.core import init, use_plugin

use_plugin("python.core")
use_plugin("python.install_dependencies")
use_plugin("python.unittest")

default_task = "publish"

@init
def initialize(project):
    project.build_depends_on('mockito')

When I run pyb under a debugger I see that it loads all the modules including "install_dependencies" however, none of the modules that actually install dependencies actually get executed. "initialized_install_dependencies_plugin" and "check_pip_available" are run but none of the "installl_*" methods are ever executed.
I am not convinced this is a bug but something I have missed in configuration.
Here is the structure of my "samples" project:
|____build.py
|____build.pyc
|____src
| |____main
| | |____python
| | | |____helloworld.py
| | | |____helloworld.pyc
| |____unittest
| | |____python
| | | |____helloworld_tests.py
| | | |____helloworld_tests.pyc
|____target
| |____dist
| | |____simple-python-app-1.0-SNAPSHOT
| | | |____helloworld.py
| | | |____helloworld.pyc
| |____reports
| | |____unittest
| | |____unittest.json

After @mriehl made the following comment early on in this thread, the points made got overtaken by the larger discussion.

I should be able to run unit tests when on the move, without network connection. The current inner workings of the install_dependencies plugin don't allow that because pip install fails when there is no network, even when the dependencies are already there.
I think this is a defect of the plugin and it should use pip.get_installed_distributions() to determine if it needs to install dependencies (considering install_dependencies_upgrade of course).

I believe the above highlights some real issues with the install_dependencies plugin. I'm not too concerned with whether or not the call to install_dependencies is made automatically or I have to wire it in myself, but what is a problem, and what makes where and when install_dependencies gets called an issue, is the current implementation where it's not determining if a  dependency already exists before attempting to (re)install it. Regardless of where, when, and if install_dependencies gets called, it's not being as smart as it should be with regard to installing dependencies and as a result is doing way too much work and consuming valuable time unnecessarily.
I see analogies to maven in this thread... maven (gradle, ivy, etc.) would never re-download and re-install a dependency that already exists locally.

The problem with the maven / ivy analogy is that these tools deal with downloading packages themselves.
PyBuilder just uses pip, which doesn't even have an official API.
The decision whether installing the dependency is a no-op or not is actually hard because it depends on several factors (is the package installed? Are we installing to a specific location and is it there? Do we want a specific version? Are we upgrading all dependencies?).
So as I see it now, PyBuilder cannot provide this feature unless it reimplements a substantial part of the pip install routines - consider that the "API" we use right now is a subprocess calling the pip program because there is in fact no API!
The easiest way would be to implement it in pip. In fact the current implementation (always fire up pip and let it decides) has the advantage that pip can become "smarter" at any time and it will just work.

Hello,
Sorry for re-opening this old discussion, but I think it is still relevant. I am a newcomer python in general and python build & packaging tools in particular. I just tried working through the tutorial (https://pybuilder.io/documentation/tutorial) and encounter the exact same issue with mockito not beeing installed upon execution of unit tests. It appears that was my fault for not following the steps exactly: I did not run everything in a fresh virtual-env (skipped the first step in the tutorial).  A quick search for issues then brought me here.
My remarks & Questions:

Why would running this simple tutorial yield different results in a venv vs base environment? After all, the tutorial only "recommends" this step, so I suppose usually this should work. I am encountering errors in other places as well, e.g. running pyb prepare yields Module not found `pybuilder._vendor.virtualenv.seed.via_app_data. Is pybuilder generally expecting to be run in a virtualenv?
What would be the current solution to always execute the install step? default_task = ['install_dependencies', 'publish'] Does not work for me, apparently "install_dependencies" is not a task. (New name "prepare" ?)
given that the presence of the build & test dependencies is a prerequisite to successfully running the test task, why aren't the outcomes of this task verified, before launching the tests? Not doing this defeats the point of having a declarative build description, because now I am basically back to selecting a sequence of scripts for execution, depending on the state I am in. A modern build system would rather allow me to define an outcome (target) e.g. "a tested project" and then would figure out what steps must be run to get there "install missing build dependencies", "build", "test". I think that pybuilder is a good project and a general and dedicated build system for python makes a lot of sense. But it is a sad design decision that tasks are basically used like scripts, not targets.

Hi, thanks for reaching out. Starting with PyBuilder 0.12 install_dependencies plugin is generally unnecessary, as PyBuilder maintains its own venvs.
Please see release notes for details: https://pybuilder.io/release-notes/v0.12.x#version-0120


refactor: use tertiary theme for overlay buttons

Remove styles applied to the buttons and use "tertiary" theme instead.
Fixes #734

Note, screenshots are different because of padding property change:
Before
padding: 0 0.75em; hardcoded here.

After
padding: 0 calc(var(--lumo-button-size) / 6); defined here.

I'm not sure where does 0.75em come from. In the tertiary button theme we always used a different padding.

Though, the margins should still be removed from the buttons, now that I look closer.


Deprecation report from itch.io

https://itch.io/post/9368196
Code is a lil deprecated with new renpy versions.
Replace
hold_last_frame = bool(kwargs["hold_last_frame"]) if "hold_last_frame" in kwargs else False with renpy.open_file(image_path) as handle: full_width, full_height = __get_image_size(handle) sprite_width = int(full_width / x_sprite_count)
With
hold_last_frame = bool(kwargs["hold_last_frame"]) if "hold_last_frame" in kwargs else False full_width, full_height = renpy.image_size(image_path) sprite_width = int(full_width / x_sprite_count)

Ah, no this function was intentionally disregarded for efficiency reasons.


local error: tls: bad record MAC

I have osquery 4.3.0 on Windows 2012 server and kolide 2.6.0
The osquery  agent from linux is working fine with kolide however when trying to integrate with Windows osquery with kolide then getting the following err
http: TLS handshake error from <IP_ADDRESS>:66566 local error: tls: bad record MAC
Osquery Client on Windows
Windows 2012 server
Kolide Fleet server
Centos 7.7

Please see https://github.com/kolide/fleet/blob/master/docs/infrastructure/faq.md#why-arent-my-osquery-agents-connecting-to-fleet and use #kolide in the osquery Slack for troubleshooting.

@zwass I've seen this issue pop up a few times in the #kolide Slack channel without an answer. I figured out that it's likely due to people accepting the defaults when generating fleets certificates using openssl. I'd recommend adding the following to Common problems in the infrastructure FAQ.
- `bad record MAC`: When generating your certificate for your Fleet server, ensure you set the hostname to the FQDN or the IP of the server. This error is common when setting up Fleet servers and accepting defaults when generating certificates using `openssl`.


Emmet Response very Slow

When I try Emmet command, Balance Outwards on XML files then the selection appears after a noticeable period of time (10 to 15 secs). During this time the editor stops taking keyboard input. I tried this with an XML file  having 4000 lines and another XML file with 44800 lines. The response is same.
I tried the same files on Sublime text and there is no lag at all.  (CTRL+SHIFT+A) and boom the selection happens. Another CTRL+SHIFT+A another level. No lag at all.

With the smaller XML(4000lines) file its 5 to 7 secs and with the larger XML file(44800 lines) its between 10 to 15 secs. Sublime text behaves same for both the files.

/needsMoreInfo
Please use this guide to provide more information: https://github.com/Microsoft/vscode/wiki/Performance-Issues#profile-the-running-extensions. Thanks.

Version:          Code 1.39.2 (6ab598523be7a800d7f3eb4d92d7ab9a66069390, 2019-10-15T15:35:18.241Z)
OS Version:       Windows_NT x64 10.0.16299
CPUs:             Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz (4 x 2400)
Memory (System):  7.88GB (2.75GB free)
VM:               0%
Screen Reader:    no
Process Argv:     --inspect-extensions=9993
GPU Status:       2d_canvas:                     enabled
flash_3d:                      enabled
flash_stage3d:                 enabled
flash_stage3d_baseline:        enabled
gpu_compositing:               enabled
multiple_raster_threads:       enabled_on
native_gpu_memory_buffers:     disabled_software
oop_rasterization:             disabled_off
protected_video_decode:        unavailable_off
rasterization:                 enabled
skia_deferred_display_list:    disabled_off
skia_renderer:                 disabled_off
surface_synchronization:       enabled_on
video_decode:                  enabled
viz_display_compositor:        disabled_off
webgl:                         enabled
webgl2:                        enabled
CPU %	Mem MB	   PID	Process
0	    87	  6072	code main
0	   161	  9128	   window (Running Extensions - ipflow - Visual Studio Code)
0	   500	 17260	     extensionHost
0	    11	 23956	     watcherService
0	    10	 34528	       console-window-host (Windows internal process)
0	    23	 19156	   utility
0	    73	 19616	   window (Issue Reporter)
0	    80	 20920	   gpu-process
0	    71	 21592	   shared-process
0	    15	 26312	   electron-crash-reporter
Workspace Stats:
|  Window (Running Extensions - ipflow - Visual Studio Code)
|    Folder (ipflow): 247 files
|      File types: txt(18) tcl(14) csv(12) py(11) xml(9) pyc(8) yaml(7)
|                  pptx(4) pdf(3) json(2)
|      Conf files: settings.json(1)

I tried running with all extensions disabled. The issue still persists.
I ran the extension profiling. It shows Emmet unresponsive. I am not able to figure out how to attach the profile file to this message. Every time I drop the file into this window it opens the file

vscode.emmet-unresponsive.cpuprofile.txt

Yeah, the emmet parser is very slow...We replaced it for auto-completion, but I guess we need to do it in other places as well.

I recently swapped to VSCode and I have to say my biggest gripe is how brutally slow emmet can be. It seems to require the dropdown to load to run the expand command.

I write css in Vue component file. The emmet dropdown showed slowly after my typing end. Maybe, it takes 3~5 seconds.

I have this problem. I type very fast, and sometimes after typing div.test-class and pressing Tab I get div expanded without class and .test-class as a plain text coming after the closing div tag.

I too have the problem, Emmet response is very slow, for example if I type div.header and quick tab press it's not works, instead either I need to wait few seconds or use SHIFT + SPACEBAR key to achieve that .. it's annoying.
Please, guys share if you find any solution for this, thanks

@stormrockwell @Alex1990 have you two tried enabling trigger expansion on tab?
@muthuweb I'm wondering what you have shift+space mapped to? For me it doesn't expand the abbreviation at all

This can also be a problem with extension. For me if I remember correctly the Bracket Colorizer 2 caused Emmet to perform extremely poorly. I suspect there are plenty other extensions that run too early as you type, and causes some issues with autocompletions like Emmet.

Turns out replacing the parser with the language-server one as @octref suggested in https://github.com/microsoft/vscode/issues/71996#issuecomment-562273179 might help.
Closing this in favour of https://github.com/microsoft/vscode/issues/71996


The footer.html customization isn't being applied in the Sphinx PyData theme

Describe the bug
There's extra information about the license, privacy notice, and terms of use that isn't being applied to the compiled HTML in the PyData theme. It appears others have hit this issue and identified a fix here: https://github.com/pydata/pydata-sphinx-theme/issues/1284

Fixed


unclear std error for Kaplan Meier estimator

The standard error for the Kaplan-Meier estimator returns what I would consider to be only "half" of the correct value. Perhaps this is just a misunderstanding on my part, but I think it should return the square root of the variance of the survival function. Right now, it does not. To actually make it the standard error of the survival curve, you need to multiply the two (AKA km.survival .* km.stderr).
Should I make a PR to fix this, or was it intentional?

Currently it computes the pointwise standard error of the log of the survivor function using Greenwood's formula. I forget why exactly I opted for that but likely it was because that's also what R does (which is what this implementation tests against).


Cannot change drive on windows

top level will be C:, instead going out one more level should list all volumes

1e29e234b4c9057e712a79a3695026c95773531d


Added thread tutorial

Added the example shown during today classroom that creates thread implementing the Runnable interface.

Ok thanks :)


Add command shortcuts for common operations

Currently, most yaman commands are namespaced (e.g. yaman container run). We could expose some common operations directly too, e.g., yaman run.

This is "easy" to solve but then we'll have to change the usage/help message to distinguish "management commands" from "operation commands".


Feature: enable pre-loading checkpoints into memory and executing workflow with different parameters fast

I think it would be useful to be able to run the generated workflow repeatedly, without re-loading everything into memory every single time. For instance, one could use it as API server which is running, the model loaded in memory and thus respond to different prompts (or other parameters) very fast. ComfyUI works that way (I think): it only recomputes nodes that changed.
I tried to change the generated code a bit, ie. wrap it in a class and keep checkpointloadersimple_4 etc as instance variables, and add method to run the workflow using these already instantiated objects, but it seems like every call to KSSampler.sample still re-loads everything into memory and it's not any faster.
Any ideas how to do that? (I would be happy to send a PR)

I have this feature implemented as part of command-line options or importable modules in my fork. It's available on the registry for extensions or here:
ComfyUI-SaveAsScript

@vojtajina The easiest way to do this with the current implementation would be to just throw the generated code into a notebook. Load everything in the top cell, then make iterative changes to the code you are experimenting with in cells below.


Improvement to the qiskit_nature.second_q.mappers module

What should we add?
A few things in the mappers module could be improved. I will try to summarize some thoughts below based on gathered observations. (See also this thread: https://github.com/qiskit-community/qiskit-nature/pull/1270#discussion_r1408833996.)

[ ] the QubitMapper.mode_based_mapping method should really not be part of the base class. Instead, we could implement this as a ModeBasedMapper class which only the mappers that actually follow this implementation derive from (i.e. JordanWignerMapper, ParityMapper, BravyiKitaevMapper, and DirectMapper). This would avoid all other mappers to have this public method without it actually working (since they don't implement the pauli_table classmethod.

[ ] we should revert the use of classmethod for the pauli_table in those mappers above, because this broke the initial implementation of the Bonsai mapper which was done externally. We should see if we can still keep the caching that was added in #699 as part of this change, to avoid a performance regression (#644).

I think the above two tasks could be combined into a single PR quite nicely.

[ ] Performance: Rather than duplicating #771 I am simply referring to it here for completeness.

Re: ModeBasedMapper
What would you do with the FermionicMapper/BosonicMapper classes that are a layer in between right now? I guess something like JordanWignerMapper would have to inherit from both FermionicMapper and ModeBasedMapper then?
Re: pauli_table
So pauli_table should be an instance method, do I get that right?
Regarding the caching, I think one could simply do that on the level of the actual implementation of pauli_table by having a helper classmethod or staticmethod _pauli_table with @lru_cache decorator.
I need to do something similar for the TernaryTreeMapper which has an attribute for the priority of X, Y, Z and the return value of pauli_table depends on this attribute. So I simply introduced a staticmethod _pauli_table that takes one extra argument and wrap lru_cache around that instead of the original pauli_table classmethod.
Although that works with a class attribute, it would make a lot more sense to implement pauli_table as an instance method also for the TernaryTreeMapper and then have the priority be a regular attribute of an instance.

Re: ModeBasedMapper
What would you do with the FermionicMapper/BosonicMapper classes that are a layer in between right now? I guess something like JordanWignerMapper would have to inherit from both FermionicMapper and ModeBasedMapper then?

Yes, they would subclass both :+1:

Re: pauli_table
So pauli_table should be an instance method, do I get that right? Regarding the caching, I think one could simply do that on the level of the actual implementation of pauli_table by having a helper classmethod or staticmethod _pauli_table with @lru_cache decorator.

Yes, an instancemethod would be preferable. In case we want to parallelize these methods, we will need to be careful when using lru_cache and mutable input arguments (such as lists) because these will have non-matching IDs across threads (just FYI).

I would offer to implement the first two things. I finished the Ternary Tree Mapper and wanted to start a PR for that today-ish, but I could include these changes and the new mapper into a single PR if that would be okay?
Otherwise, I guess it is a bit pointless to start a PR for the new mapper now just to need to restructure it again once these changes are done.
Regarding the caching:

Thanks for pointing that out with the mutable inputs. Shouldn't be an issue because input will be string (I add a pauli_priority argument that can be one of 'XYZ', 'XZY', ...) but good to keep in mind.
I have little experience with caching, but my feeling is that decision whether to cache should be made on an individual level at the concrete implementation? I would, therefore, get rid of all the @lru_cache decorators for the abstract classes in QubitMapper?
Specifically, I needed to remove the decorator from QubitMapper.sparse_pauli_operators because it messed up my implementation of the Ternary Tree Mapper. My preferred solution would be to have these methods call some private method, e.g. ._sparse_pauli_operators, and then use @lru_cache decorators on those where it makes sense. Then those can also be implemented as static methods or instance methods as needed. What do you think?

On a side note: I noticed that the base classes FermionicMapper and BosonicMapper are not included in the __init__.py (and thus also not in the apidocs). I am unsure whether this is on purpose but given that other base classes like e.g. QubitMapper or SparseLabelOp are included, I guess it should be changed?
Apart from that, will do as suggested (maybe this weekend).

On a side note: I noticed that the base classes FermionicMapper and BosonicMapper are not included in the __init__.py (and thus also not in the apidocs). I am unsure whether this is on purpose but given that other base classes like e.g. QubitMapper or SparseLabelOp are included, I guess it should be changed?

This was a conscious decision as part of https://github.com/qiskit-community/qiskit-nature/pull/1044.
See its discussion for some more insights.

Apart from that, will do as suggested (maybe this weekend).

Awesome! I will likely only be able to review your PR in the new year (just to make you aware).

On a side note: I noticed that the base classes FermionicMapper and BosonicMapper are not included in the __init__.py (and thus also not in the apidocs). I am unsure whether this is on purpose but given that other base classes like e.g. QubitMapper or SparseLabelOp are included, I guess it should be changed?

This was a conscious decision as part of #1044. See its discussion for some more insights.

I see. I won't touch that then.

Awesome! I will likely only be able to review your PR in the new year (just to make you aware).

No problem at all. Given that Christmas approaches - as every year - surprisingly fast, chances are that I won't even open a PR before then ;).


Create 208-Implement-Trie.cs

File(s) Modified: 208-Implement-Trie
Language(s) Used: c#
Submission URL: https://leetcode.com/submissions/detail/763165501/

Thanks, @notauserx!


Loading the same related models in multiple relationships merges them

In this jsfiddle I have created a Location model that has many Event models.
One relation is called past the other upcoming. Loading both of them or loading them separately returns all 5 events (past as well as upcoming) on the respective locations property.
But having a look at the state of the store reveals it has the correct values.

Oh well, this is expected behavior right now.
Since past and upcoming attribute defined at Location class is referencing same Event model and same foreign key localtion_id, when fetching data from the state, the result is going to be the same hence you get all 5 events back.
past and upcoming property in the state you posted (locations) are indeed the ID of the related items, but Vuex ORM will not reference those to fetch data, it looks for the foreign key (location_id by id of Location).
My recommendation is to make Past and Upcoming a separate Model, but also you could use hasManyBy relationship.
// Models
class Location extends VuexORM.Model {
    static entity = 'locations';

    static fields () {
        return {
            id: this.increment(),
            name: this.attr(''),
            past: this.hasManyBy(Event, 'past'),
            upcoming: this.hasManyBy(Event, 'upcoming'),
        }
    }
}

The hasManyBy relationship will look for the specified field's array and fetch data (in the above example it's past and upcoming field).

Thanks for the clarification, I just didn't expect it to work this way but hasManyBy is totally what I'm looking for.
Your recommendation of creating multiple models is no option for me as the location -> past/upcoming relation was just one of many examples in my app that have this problem and I wanna keep the models folder slim ... hasManyBy is just cleaner ;-)

Glad it worked for you! Let me know if you face any other trouble 👍


Scaffolding should stop adding IDbContextFactory implementation for 2.0

EF plans to change DbContext creation during design time to not require an IDbContextFactory implementation.
When that happens scaffolding needs to stop creating a factory for the newly added DbContext.
Related: https://github.com/aspnet/DependencyInjection/issues/524
cc @bricelam, @mlorbetske

PR aspnet/EntityFramework#8510 is in. Scaffolding can stop adding IDbContextFactory.


NextDNS.NextDNS version 2.2.1

[x] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

My mistake, there's an open PR #38207 for this already. Didn't see it because it was marked as draft. Closing this for now. Install did work on my machine though


No SVDF ref kernel support with all 8 bit weights and state

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
TensorFlow installed from (source or binary):
TensorFlow version (or github SHA if from source): 1180d389b41314e9715336b4b7b194140292d5c8

TFLM has support for this already:
https://github.com/tensorflow/tflite-micro/pull/506
If CMSIS-NN should add support for this it would be good to first have support in Tensorflow Lite, since CMSIS-NN has TFL as reference for its tests.

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.

This is not really needed anymore so closing it.


Fix remove icon class from wagtail userbar icon

This PR is related to the issue #6333 .

I haven't found the time to test drive, but this look good to me.

Merged in 884c78aa530539d884b5c67aae9f96e8e2cd919c (stable/2.10.x) and d9449150b5bb1bee32d67ce77b185a8c2fc33344 (master) - thanks @karranb!


chore(jolokia): upgrade to Jolokia 1.7.0

Fix #2593

Release Note
Jolokia is upgraded to 1.7.0

There is an error during the build:
Failed to execute goal on project camel-k-integration: Could not resolve dependencies for project org.apache.camel.k.integration:camel-k-integration:jar:1.6.0-SNAPSHOT: Could not find artifact com.sun:tools:jar:1.8 at specified path /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre/../lib/tools.jar


Additional examples with variable numbers of input/output dimensions

What is your issue?
We should add a gallery with several examples demonstrating batch generator usage with different numbers of input and output dimensions, for example an input Dataset with 3 dimensions with an output of 2 dimensions and so on.

I'm putting together some combined xbatcher/ML examples, although I think what you want is probably simpler. Mine are going to be end-to-end tutorials.

I'm putting together some combined xbatcher/ML examples, although I think what you want is probably simpler. Mine are going to be end-to-end tutorials.

That's fantastic! These end-to-end tutorials will be a really important contribution. I think they could be a great fit for the next generation of EarthML, which is being led by @jbednar's team and will be hosted on Project Pythia. Could you take a look at https://projectpythia.org/landsat-ml-cookbook and let me know your thoughts about formatting the tutorials into a similar Python cookbook? From my perspective, the main benefits of that structure rather than including the larger tutorials in the xbatcher docs are that you'll have more flexibility in dependencies (because there's no concern about bloating the environment used to build the xbatcher docs) and could use the JupyterBook configuration tools built by the Project Pythia team for more computationally expensive tutorials.
@rabernat and I spoke this AM and he seemed interested in this idea of linking the tutorials with the EarthML revamp, but still looping him into this conversation for any follow-up thoughts.
Are your end-to-end tutorials going to be centered around any particular topic areas (e.g., ML for oceanography)?
Thanks again for working on this, really excited about the end-to-end tutorials!

Sounds reasonable, their formatting is pretty clean too. I'll have to look into it more, but for now I'm just trying to get the notebooks working lol
They're oceanography-based, but I think the focus will be more on using different methods. We have two that have been partially done for a while. One is a more-or-less vanilla CNN implementation, and another is a graph CNN. My goal with these is to demonstrate how xbatcher can be used with diverse ML workflows, so maybe we'll see PCA, clustering, or other stuff in the longer term.

Sounds really cool; looking forward to seeing them!

👍  to leveraging EarthML / Pythia for Chris's tutorials. That's definitely a better home for this sort of long-form content.
Chris, if you want to just get a PR started with your drafts, I think folks would be glad to provide some feedback along the way.

@cmdupuis3, would you be willing to share the general topic for your ML-focused cookbook on the Pythia channel of the Pangeo discourse? It would be helpful to have the Project Pythia team members aware of the idea early in the process. The Pangeo discourse is their preferred way to discuss potential cookbooks.

@maxrjones Yeah, sounds great, I'll start a thread over there.

@cmdupuis3 Could you please share this tutorial? I am looking for some examples of xbatcher with PyTorch.


[RemoteInspection] Hardcode DefaultActorStorage's type info

No metadata is emitted for the builtin DefaultActorStorage type. Since its layout is fixed, hardcode its definition in Remote Mirrors.
rdar://128032250
(cherry picked from commit 4417786be42084c144ff094789382e8ae361094e)

@swift-ci test


Fix compilation issue for Xcode 9 in Swift 3.2 mode

Fix for https://github.com/Swinject/Swinject/issues/260

Thanks @mackoj for fixing the issue👍👍👍 I merged the pull request to swift4 branch for now because I expect the compiler will fix the issue before Swift 4.0 is released👏

When will this be released? I have a project that I tried opening using XCode 9 beta but I get the following message: Module compiled with Swift 3.1 cannot be imported in Swift 3.2


Assing global credentials for GIT id:4

TODO  Assing global credentials for GIT id:4 gh:5
ubuntuafterconf.sh:1153
@imdone commenter. The developer's task board. imdone.io

TODO  Assing global credentials for GIT id:4 gh:5
ubuntuafterconf.sh:1153
@imdone Issue Closer. The developer's task board. imdone.io


redesign right-hand menu

Someone should look into the right menu of CLARIN-DSpace. It is actually pretty confusing with 2x Deposit, Cite and Login, then 4 “help things”: Submission Lifecycle, FAQ and About and Helpdesk.  And still a bit different list of things in the footer.
It's also not sure if all the RSS feeds need to be displayed so prominently.

integration at http://lindat.cz/faq


FormElement: add class named after property

I find myself adding a classNames property all the time to form elements to make them addressable in integration and acceptance tests. A short code example:
{{#bs-form model=this as |form|}}
  {{form.element classNames='email' controlType="email" label="Email" property="email"}}
  {{form.element classNames='password' controlType="password" label="Password" property="password"}}
{{/bs-form}}

Could we please consider adding a class named after property as default? So a form element {{form.element property='email'}} would have an class property-email?
Perhaps we should make the prefix configurable to prevent naming collisions:
module.exports = function(environment) {
  var ENV = {
    ember-bootstrap: {
      'form.element': {
        propertyClassPrefix: 'form-element-for-'
      }
    }
  };

  return ENV;
};

If you like these proposal I'm willing to write a PR.

I like the idea of supporting test addressability of components. We would need to figure out a way to allow multiple instances of a component in a page, for example if something is in an {{each}}. Do you have any thoughts on that?

I am actually not a big fan of that. I think you should use classes only for styling purposes, and stuff used only for testing should not find its way into a production build.
We use https://github.com/simplabs/ember-test-selectors in our apps for this purpose, which I think is a much better solution. An example taken from an app where we automatically set the selectors based to the propertyvalue by default by extending the default bs-form/element:
import FormElement from 'ember-bootstrap-cp-validations/components/bs-form/element';

export default FormElement.extend({
  'data-test-selector': computed.reads('property')
});

I also have run into this issue while writing acceptance tests. @simonihmig, I agree from the context of integration testing that test descriptors are ideal. However, from an acceptance testing perspective, manipulating the outputs results in an inconsistent release between testing/production since the selectors are removed in production.
What might the solution be if you're running some form of validation/acceptance tests against "production" worthy code?

I agree with @simonihmig that extending default components to add testing selectors is the best solution if you don't want to add them to all elements manually. Test selectors applied could be either CSS classes or data attributes. I would also recommend data attributes now as the distinction between CSS classes used for styling and test selectors could be critical especially in bigger teams. I'm closing this issue now. Feel free to reopen.


TypeError: Object [object Object] has no method 'observe'

Hi, this package would actually exactly do what I need, unfortunately i get this error when I publish with this.related:
TypeError: Object [object Object] has no method 'observe'

My publish method looks like this:
Meteor.publish('owngroup-request-users', function () {
    check(this.userId, String);

    this.related(function (group) {
            if (!group.requests) {
                return;
            }

            return Meteor.users.find({_id: {$in: group.requests}}, {
                fields: {
                    statusConnection: true,
                }
            });
        },
        Groups.findOne({owner: this.userId}, {fields: {requests: true}})
    );
});

I'm using Meteor 1.2.1

Hm, can you provide a stack trace at least? Or a running reproduction.
Also, I would suggest you start using reactive-publish.

I'll check out another package.
Stack trace:
Exception from sub owngroup-request-users id 8nnhR6YbZF9g5ECak { stack: 'TypeError: Object [object Object] has no method \'observe\'\n    at _fn (packages/peerlibrary_related/packages/peerlibrary_related.js:109:1)\n    at [object Object].publish.related (packages/peerlibrary_related/packages/peerlibrary_related.js:137:1)\n    at [object Object].<anonymous> (server/publications/group/owngroupPublications.js:23:10)\n    at [object Object].<anonymous> (packages/peerlibrary_related/packages/peerlibrary_related.js:157:1)\n    at packages/matb33_collection-hooks/collection-hooks.js:275:1\n    at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)\n    at [object Object]._handler (packages/matb33_collection-hooks/collection-hooks.js:274:1)\n    at maybeAuditArgumentChecks (livedata_server.js:1698:12)\n    at [object Object]._.extend._runHandler (livedata_server.js:1023:17)\n    at [object Object].subscriptionProto._runHandler (packages/meteorhacks_kadira/lib/hijack/wrap_subscription.js:12:1)',

Oh, I see the problem. You are using findOne. It should be a cursor, not a element you are returning.

Thanks for quick answer!


Implement QSPI (QuadSPI) for stm32

Hello,
I would like to provide an implementation for QSPI in stm32. I already have an implementation which I successfully used in my project.
@Dirbaio is it something you'd be interested in?

Yes, of course! Support for more peripherals is always welcome!

fixed in #1294

I'd really appreciate, if there was some usage example of qspi for rust embassy beginners. Is there already something online, i.e. the project You mentioned, @Mirror0?

@pkoevesdi Unfortunately the project I mentioned is a company internal project not available to public. But I can create some dummy project to illustrate basic usage to my github. I post a link here when I finish it. :)

That would be nice, thank you. If ready I'd suggest to PR this into the example section of this repo here.

@pkoevesdi I just finished example of QSPI usage. Here is my repo with it: https://github.com/Mirror0/qspi-example. Hope it helps you :)

Great, thank You!


[SPRINT] DP0.2 Time Domain Data exploration

DP0.2 Time Domain Data exploration
Explore the DP0.2 time domain
Contacts: Bruno S.
Time: Morning
Main communication channel: #desc-dc2-dia
GitHub repo:
Goals and deliverable

Share the Data Preview dataset overview
Make an initial exploration on the recently released DP0.2 dataset
Create scripts to build light-curves, explore stamps and catalogs
Probably port some DESC code into the new gen3 and apply it to DP0.2

Resources and skills needed
Python (matplotlib, pandas, lsst-stack minimum skills). Be an LSST Data Preview delegate to run code yourself.

Here are some time-domain tutorial notebooks from Rubin CET:
https://github.com/rubin-dp0/tutorial-notebooks/blob/main/07a_DiaObject_Samples.ipynb
https://github.com/rubin-dp0/tutorial-notebooks/blob/main/07b_Variable_Star_Lightcurves.ipynb

We check the tutorials and explored the dataset!

Exploration went well, we learned a bunch of interesting things of the RSP (Notebook aspect) for DP0.2.
Produced some light-curves without meaning, but we understand basic schema now.
Next steps might lead to select SNIa in DP0.2 and get a sample of LCs

Finding a SNIa has been more difficult than might be expected. You might consider dropping a line to Melissa Graham or Jeff Carlin, or posting something on LSST Community.

Closing this as the sprint passed more than a year ago.


iTunesConnect And developer portal credentials

What if those accounts are different?

OK, I see that I can have credentials per lane - just need to separate iTunes actions from signing.

@ssuchanowski yes, see how Wikipedia is solving it: https://github.com/fastlane/examples/blob/master/Wikipedia/Appfile :+1:


Improve loading

Resources with a "?" in the URL are not cached by some proxy caching servers. Remove the query string and encode the parameters into the URL. Like these:

https://blog.birkhoff.me/assets/css/screen.css?v=832a8bc95b
https://blog.birkhoff.me/assets/fonts/casper-icons.woff?v=1
https://blog.birkhoff.me/assets/js/index.js?v=832a8bc95b
https://blog.birkhoff.me/assets/js/jquery.fitvids.js?v=832a8bc95b

Gravatar image dimensions. I found that some places only display 24x24 of the image, but Casper download 250x250 of the image. Thus if you specify dimensions of the image in the gravatar url, the image size can be reduced up to 99%.

Resources with a "?" in the URL are not cached by some proxy caching servers.

Please see this issue - it's Ghost that adds cache-busting to assets rather than Casper and ?s in URLs are not a problem as far as we're aware, if you have concrete evidence that it's a widespread issue and not a peculiarity of an individual's setup please add to the referenced issue.

Gravatar image dimensions. I found that some places only display 24x24 of the image, but Casper download 250x250 of the image.

The image is at a suitable size for retina screens, downloaded once, cached, and used everywhere for both small and large representations - I'm not sure the file size optimisation would outweigh the multiple requests needed to download gravatars at multiple sizes or the benefits gained from having a single size across a large number of Casper variants that can all re-use the same cached image.

This is a widespread problem now in 2020. How to reproduce:

Make a change to your CSS
Deploy your theme
Load your site using Chrome latest on a Win 10 machine

The new CSS is not loaded.


✨(models) add edX page_close browser event model

Purpose
The edX page_close browser events are the most simple and common browser events in the edX tracking logs. We want to validate them.
Proposal

[x] PageCloseBrowserEventModel
[x] PageCloseBrowserEventFactory
[x] Tests

Looks great, can you please rebase it on the master branch and change the commit emoji :pray:

Thanks a lot for the review) updated the PR and squashed commits, a backup is here for the latest changes.


 Let me check if that has been resolved, else will follow your suggestion and publish it as an independent library and refer it here..
Again thanks for all the hard work! :)

hey @rcdexta :), I'm using your react-trello - amazing functioning trello board btw! However, I'm  also having the issue with dragging/dropping cards, so when you do you get numerous errors that look like this:
[Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.
Have you guys figured out what to do? Is that a version thing because in react-trello you define smooth-dnd to a git repo so I don't even know what version it is..
Anyways, if you can let me know that would be awesome - thanks!!

Having the same issue.
When running the following command in command prompt in windows 10:
npm i react-trello
I'm receiving the following errors:
npm ERR! code ENOENT
npm ERR! syscall spawn git
npm ERR! path git
npm ERR! errno ENOENT
npm ERR! enoent Error while executing:
npm ERR! enoent undefined ls-remote -h -t https://github.com/rcdexta/smooth-dnd.git
npm ERR! enoent
npm ERR! enoent
npm ERR! enoent spawn git ENOENT
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR!      C:\Users\Anders\AppData\Roaming\npm-cache_logs\2020-03-03T20_42_45_576Z-debug.log

This should be fixed now. Pls pull latest version


LNDhub implementation (200k sat bounty)

Really like the LNDhub implementations on myNode and Umbrel. Having an open source bank is dope and brings lots of scaling benefits to family uncle-Jim setups, with the clean look of Bluewallet's interface.
If you can get this project merged into RaspiBlitz, i'll pay a 200k sat bounty 🙌.
After this is complete i'll be migrating to the Raspiblitz platform as my main node of choice 🤝

If someone wants to work on this, there is this unfinished code I made to implement lndhub without docker https://github.com/rootzoll/raspiblitz/issues/230#issuecomment-847757874

Try the existing LNbits extension, it might work already.

This might

If someone wants to work on this, there is this unfinished code I made to implement lndhub without docker #230 (comment)

This might fix it: https://github.com/rootzoll/raspiblitz/issues/230#issuecomment-890838807

@godSaysHODL did you try to install LNBits in which there is a functional LNDHub extension already?
Can also be tested on https://lnbits.com (this is a custodial demo wallet on Opennode). The biggest difference is that your own node would not be available on a public domain, but I think BW and Zeus can connect over Tor already.
@xanoni you could try this too.

@xanoni
Definitely still gonna pay the bounty. Just ping me here when it's reviewed and looks like it'll be merged and I'll donate to whoever you choose!

@godSaysHODL did you try to install LNBits in which there is a functional LNDHub extension already?
Can also be tested on https://lnbits.com (this is a custodial demo wallet on Opennode). The biggest difference is that your own node would not be available on a public domain, but I think BW and Zeus can connect over Tor already.

I will check this out also. 👌

Yeah I saw your comment already a few weeks ago, but I had already set up LndHub, so I never gave it a try. The LndHub script is almost done so I'll get that across the finish line. If after all this time there's still someone willing to pay a bounty, please donate it to RaspiBlitz or to one of the upstream projects ;-)

Do you still plan on finishing this? LNDHub support would be awesome :)

Oh man, I keep remembering this ticket all the time and feel a lot of guilt and shame (really!) ... thank you for pinging me. I'm not making promises because I already did that too often here and failed to deliver afterwards ;-)
There's no specific problem, there's just an infinite amount of other stuff. I just haven't prioritized time to continue.

There is a very promising reimplementation of LndHub in Go language here: https://github.com/getAlby/lndhub.go
I recommend to use this as a LndHub/BlueWallet server.


chart repo is not valid in offical karpenter page

Is an existing page relevant?
No response
What karpenter features are relevant?
Error: looks like "oci://public.ecr.aws/karpenter/karpenter" is not a valid chart repository or cannot be reached: object required
How should the docs be improved?
please update proper docs that is very useful to implement
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

What command are you running to get that error? Karpenter uses an OCI repo which doesn't work as a helm repo (for listing versions, etc) but it does work for installing a chart.

Facing same issue +1

We are facing a similar issue: Error: Failed to download "oci://public.ecr.aws/karpenter/karpenter"
We are just installing a karpenter with the helm upgrade command.
can anyone please help here?

What command are you running to get that error?

The helm install is working for me here: https://karpenter.sh/v0.27.1/getting-started/getting-started-with-karpenter/#3-create-a-cluster

Issue found. I am using the old Helm version 3.2.1, which doesn't support OCI. I tried with the latest version and it's working fine. Thanks

👍


[stable/redis] use recommended labels

What this PR does / why we need it:
Use recommended k8s labels
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels
https://github.com/helm/helm/blob/master/docs/chart_best_practices/labels.md
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Labels updated by recommended ones
[x] template function replaced by include

Could you explain the reason for changing all the template directives for include? AFAIK the include makes sense when it is part of a pipe or when using variables, for example.

@javsalgar

And it's default for a while in helm create template.


mbed-os: generate_pins.py fails if last value of PinName enum is not defined

In mbed OS, PinName enum is defined in PinNames.h file for each target.
Considering a case where a target (e.g TARGET_HI2110) marks the last entry of the enum as NUM_MAX, the generate_pins.py reports error: IndexError: list index out of range.

Unfortunately, this issue report hasn't been followed up. @wajahat-ublox Is this still an issue for you?

@akosthekiss
Yes problem is still there.

cc @dbatyai @rerobika

@akosthekiss
I apologize, i was on an older revision and hence saw the problem again. I just tried with latest and problem is not reproducible. I am closing this.


Tensorboard is missing css in lib/

I've noticed that since April 2016 built python wheel files are missing css in tensorboard/lib.
Take a look at those two builds from Jenkins:

13.04.2016
31.03.2016
and compare the contents of wheel file:

This causes issues when trying to run tensorboard after installation of wheel file.
Manual installation from source provides the same result as above.

Duplicate of https://github.com/tensorflow/tensorflow/issues/1923
Fixed by #1926


Adding GTM pools - branched out ofr PR(#674), merge this last

Fixes #621
Problem:
GTM Pools  endpoint was missing from the SDK. This is the last of a series of PRs meant to introduce the GTM pools to the SDK
Analysis:
GTM pools were added with tests
Tests:
Flake8
Functional Tests
Unit Tests
Files Added/Changed:
f5-common-python/f5/bigip/tm/gtm/init.py
f5-common-python/f5/bigip/tm/gtm/pool.py
f5-common-python/f5/bigip/tm/gtm/test/test_pool.py
f5-common-python/test/functional/tm/gtm/test_pool.py

curse bigip for changing its api so significantly that we needed to take drastic measures like this. good job @wojtek0806. lgtm

because i like to live dangerously and do merges of code on friday afternoons at close-of-business...merging


Separate to per "type" packages

Is there any plan to separate this package "type" specific packages? Like

locale-list-yaml
locale-list-csv
...

The whole repository has ~179MB. When building an image with ~40MB, app ~10MB this is so much overhead.

What kind of "image" are you building?

Oh, I'm sorry - docker image with the application.

I didn't plan to, I always assumed disk is cheap.
But you can easily create composer post install script that cleans up what you don't need.

Yes, it's cheap. But when you have more than 100 projects, which exists in x version (due to potential deployment rollback) you are trying to keep the vendor size as small as possible.
In the example above we're talking about more than 15 GB which must be hosted/transferred because of one library.
We could remove the files via post-install script, .gitignore or some other method but that means that we will be solving problem on a different level than the problem really is.
I think that the fork will be the most suitable.

I don't think .gitignore will help. Post install script sounds reasonable. If you go for the fork, you need to maintain it yourself.

Sorry, I wanted to write ".dockerignore".
Adding a post-install script means adding extra complexity to the project. In the case of a fork, there is extra maintenance work that should be done to keep things up to date. But the project is cleaner.

I still think post-install script is your best option, but whatever works for you.


"Must use PackageReference"

I'm trying to reference Azure.Identity with Paket (paket.dependencies):
nuget Azure.Identity

But it has dependencies (paket.lock):
    Azure.Identity (1.3)
      Azure.Core (>= 1.6) - restriction: && (>= net40) (>= netstandard2.0)
      Microsoft.Identity.Client (>= 4.22) - restriction: && (>= net40) (>= netstandard2.0)
...
    Microsoft.Identity.Client (4.24) - restriction: || (&& (>= net40) (>= netstandard2.0)) (&& (>= net45) (>= netstandard2.0))
      Microsoft.Windows.SDK.Contracts (>= 10.0.17763.1000) - restriction: >= net461
...

This all works well when referencing packages, but then when I try to build the project, it fails with an error:
A:\MyProject\packages\Microsoft.Windows.SDK.Contracts\build\Microsoft.Windows.SDK.Contracts.targets(4,5):
error : Must use PackageReference

Possible workaround is to put the code to a separate dll not using Paket but dotnet, and then reference that dll from the main project.

This refers to .fsproj file PackageReference-tag used by dotnet.exe
    <PackageReference Include="Azure.Identity" Version="1.3.0" />

rather than the typical dll-reference, used by .NET Framework and paket
    <Reference Include="Azure.Identity">
      <HintPath>..\packages\whatever.dll</HintPath>
      <Private>True</Private>
      <Paket>True</Paket>
    </Reference>

This refers to .fsproj file PackageReference-tag used by dotnet.exe
    <PackageReference Include="Azure.Identity" Version="1.3.0" />

rather than the typical dll-reference, used by .NET Framework and paket
    <Reference Include="Azure.Identity">
      <HintPath>..\packages\whatever.dll</HintPath>
      <Private>True</Private>
      <Paket>True</Paket>
    </Reference>

Same issue when using any class from the Win 10 API via Windows.SDK.Contracts.


Add parameterless overload of UseNpgsql()

See https://github.com/aspnet/EntityFrameworkCore/issues/8427

Closing in favor of #416


sanitize List-Id part used for maildir folder name

You get the $LISTNAME from group 3 here:
if ( \
        /^List-Id:.*<([0-9A-Za-z_\-]+)\.(list[sy]\.)?(.*)>/ \
)

This matches anything, even \0 or /. Later on, you use it in shell calls (even unquoted, wouldn't that be necessary, too?) an the to statement, which could both break / do funky things, if invalid chars occured
Or am I missing something here?

Have to admit that I did not tested it much. So far it worked ;D


Remove version count from the home page.

⚠ SCHEMA CHANGE ⚠
I've been meaning to remove this for a long time! It was a meaningless number at launch and it remains a meaningless number today!

I also took the opportunity to include the word "metadata" in the meta description tags for SEO purposes.

Migration tested on staging and all working. Deploying as 2.63.0.


Add guide: "Anatomy of an HTTP Request"

Note: This is part of the migration of content files from https://github.com/nodejs/docs, see: https://github.com/nodejs/docs/issues/44

@nodejs/documentation @nodejs/website Can I get a LGTM, just for good measure? :)

+1

The only thing I would add here is that the links to API docs are all linking to iojs.org, which was because at the time, nodejs.org did not have modern API docs. This should probably be changed, and now's a good time.

Ah, yep. I'll fix that. This was just a quick port of the commits. I didn't really look too closely at the content, since it had already gone through review on https://github.com/nodejs/docs.

Nice! Any plans for listing these guides? A completely new section or under docs maybe?

@phillipj yes, I think a 'Guides' section would be great for these kind of things. I had basically the same idea over at https://github.com/nodejs/docs/issues/42.

The original plan for the docs wg, discussed back at nodeconf, was to sort docs into topics, guides and reference. We kind of dropped the ball on coordinating with website to figure out how this stuff would all appear though, which is what I'm working on fixing now. :smile_cat:

Looking forward to having these resources on the website :+1:
@Qard so lets merge this content now, and figure out the best way to group/present them later in a separate issue?

Ok, it should be ready now. I just had to fix some links.
I'm good with merging and starting another PR to sort out linking to this content.

Now we PRs for adding pages as docs, meta docs, guides and knowledge base. Please choose one.
Otherwise LGTM.

Merged, although it's not linked on the site yet.


bundle produces invalid entrypoint on Windows

Describe the bug
Running yarn bundle on Windows produces an entrypoint.js file that uses a backslash causing the script to crash.
This is due to the use of the path module and its sep value https://github.com/ojkelly/yarn.build/blob/e47d1197d5a02bd4f7f92a3d0b262cc00f2ceed2/packages/plugins/plugin-build/src/commands/bundle/index.ts#L387-L388 producing this output:

"use strict";

const pnp = require("./.pnp.cjs").setup();

const index = require("./.\register.js");

Object.defineProperty(exports, "__esModule", { value: true });

exports.default = index;

To Reproduce
Run the following in Git Bash on Windows
set -ex

cd $(mktemp -d)

yarn init -2
yarn plugin import https://yarn.build/latest

touch register.js
printf '{"main": "register.js"}' > package.json

TARGET="$(mktemp -d)"
yarn bundle --no-compress --output-directory "$TARGET"
node "$TARGET/entrypoint.js"

Expected behavior
The entrypoint should use a forward slash to ensure it works on Windows
Desktop (please complete the following information):

OS: Windows 10

require supports mixing \ and / on Windows so just using the POSIX relative path would handle both.


Any info on the inter-board connector?

It should be nice to have spare I/O. Are there any free pins left on the connector? They could be "extracted" with a custom pcb I think.

The smaller half of that connector carries most of the Chrontel inputs to generate DVI. Those are only about 17 pins or so (data is DDR).
So it’s a bit of a mystery why there are so many other pins.
I haven’t mapped them out and it pretty low priority, but I doubt that there will be something useful for GPIOs.

Thanks.

Here is a link to a breakout board for the connector.
https://github.com/twj42/PanoLogicG2_ReverseEngineering/blob/master/pages/bob.md
Quite a nice design. 16 FPGA pins instead of micro-HDMI, LEDs and the switch.

Here is a link to a breakout board for the connector.
https://github.com/twj42/PanoLogicG2_ReverseEngineering/blob/master/pages/bob.md
Quite a nice design. 16 FPGA pins instead of micro-HDMI, LEDs and the switch.

Wow, that's awesome!


Added backwards compatibility for index.json with analytics fields

cvc support for -a/--include-analytics re-added, with a note that -a is deprecated in favor of -r
Will download raw/analytics data for index.json regardless of whether the field is rawMd5 or analyticsMd5
Added missing requirement to requirements.txt which was causing issues with document build

File Changes:
FLIR/conservator/cli/cvc.py

Re-add -a/--include-analytics options to download command

FLIR/conservator/local_dataset.py

Check both analyticsMd5 and rawMd5 when downloading raw TIFF data

requirements.txt

Added missing requirement myst-parser

[JIRA Task]

@rlc2 @SJLC We'd like to get this deployed quickly, so if you could review and merge (if approved), I'd appreciate it!


If I have another large JS file open, completion will be slow.
Repro:

mkdir test && cd test
yarn add typescript
Have the above code, do a completion. 🐇
Open node_modules/typescript/lib/typescript.js, do a completion. 🐌

I confirmed that the tsserver seems to be taking a very long time with a geterr request in this case. VS Code attempts to cancel the request but the server continues processing it. Here's a quick profile after triggering geterr:


Pluto notebook for part 01 adapted - is now functional

The notebook for part 01 of the tutorial (notebook.pluto.jl) has been adapted, so that is now fully functional for use with Pluto.
Among other things

some variable names have been changed
all using and import clauses are now in one place at the beginning of the notebook using the built-in Pluto environment mechanism
some formatting has been changed to make it more "Pluto like"
a TOC has been added

@ablaom, as a first example, I have adapted the Pluto notebook for part 01 of the tutorial. If these changes are ok with you, I could adapt the remaining Pluto notebooks in the same way.

@roland-KA That's awesome, many thanks!
My only concern is this introduces parallel maintenance for the different flavors of notebooks, rather than generating all the notebooks from a single Literate.jl script, notebook.jl, which was the original vision. However, achieving this vision is tricky, which is why I kind of gave up on the Pluto notebooks.
Unless you have a better suggestion, let's live with the dual maintenance issue and see how it goes. I'll be very happy to have your help converting the remaining notebooks - I just can't make a water-tight commitment to updating them along with the others in the future.
How's that sound?

By the way, I just tested out your tutorial and it looks very nice.
I've  added an option pluto() to launch the first tutorial.

@roland-KA That's awesome, many thanks!
My only concern is this introduces parallel maintenance for the different flavors of notebooks, rather than generating all the notebooks from a single Literate.jl script, notebook.jl, which was the original vision. However, achieving this vision is tricky, which is why I kind of gave up on the Pluto notebooks.
Unless you have a better suggestion, let's live with the dual maintenance issue and see how it goes. I'll be very happy to have your help converting the remaining notebooks - I just can't make a water-tight commitment to updating them along with the others in the future.
How's that sound?

This concern came also to my mind. But I don't think that it is possible to achieve a completely automated conversion. And even if it would be possible, I doubt that the usability of the resulting notebooks would be of good quality. Especially with a tutorial you address people who are typically not on an expert level. So I think it's worth the extra effort and your suggestion sounds good to me. 👍
I will convert the remaining parts of the tutorial and if my time allows, I will support also future adaptions (of course hoping, that MLJ won't introduce too many code braking changes in the future 😀).

Sounds, good, thanks!


Create Component Navbar

Creation of the Navbar Component:
Navbar Mockup
https://docs.google.com/drawings/d/1N4wB9z9lZAHw7JOiO1rvy6LTY-06ieYnnuSoFdW5SRU/edit

Basic design completed - will push to main when ready
Waiting for more information to adjust to dropdowns


Security Configuration

Enable Authorise attribute for Class or Method for All or Selected Controllers.

Added basic auth feature on 0.6


Alpine build

Closes #103
This is a bit trickier than I hoped. Happy if anyone wants to reproduce and try to follow.
# this takes Dockerfile.alpine and builds demo-alpine:latest
make docker-image-alpine

cd build
# this will run the compilation steps... edit this til it works
./alpine_test.sh

I went through a few passes, where I realized you need to set crate_type=["staticlib"] (this should be configured for one target later, but for now let's just hack until it works). Then it was complaining about not finding crti.o which is a rust internal lib, and I updated LIBRARY_PATH.
Now, it all compiles and I get to an ld error saying it cannot find -lc. I am not sure what I need to add here. Is this glibc it is requesting???
Note: the alpine linux docker just sets up rust and any other dependencies / libraries that are needed to compile. The alpine_test.sh is a fast way to test different compiler options. If/when this compiles this all needs to be refactored, but this was the quickest debug cycle I could find.

Full error message:
error: linking with `cc` failed: exit code: 1
  |
  = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-Wl,--eh-frame-hdr" "-m64" "-L" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.0.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.1.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.10.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.11.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.12.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.13.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.14.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.15.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.2.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.3.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.4.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.5.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.6.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.7.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.8.rcgu.o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.build_script_build.5cgknvoa-cgu.9.rcgu.o" "-o" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2" "/code/target/debug/build/proc-macro2-07640fe6c42569c2/build_script_build-07640fe6c42569c2.d22mwwkwozqshhs.rcgu.o" "-Wl,--gc-sections" "-pie" "-Wl,-zrelro" "-Wl,-znow" "-nodefaultlibs" "-L" "/code/target/debug/deps" "-L" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib" "-Wl,--start-group" "-Wl,-Bstatic" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib/libstd-e580b01fa2a7ce4c.rlib" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib/libpanic_unwind-d393a7bb0560f7a5.rlib" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib/libhashbrown-3e818e0bdc064d95.rlib" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib/librustc_std_workspace_alloc-2c6966dcd8d15b47.rlib" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib/libbacktrace-742f3ed03e902fa8.rlib" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib/libbacktrace_sys-7d969583ee5e6269.rlib" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib/librustc_demangle-5d0336fc5218be46.rlib" "/tmp/rustck96SoR/libunwind-53e661fd8454a2b7.rlib" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib/libcfg_if-20f2510cb5a14419.rlib" "/tmp/rustck96SoR/liblibc-484d9d5b8731d696.rlib" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib/liballoc-7cf629b7a485663f.rlib" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib/librustc_std_workspace_core-650e03a7e69a40f7.rlib" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib/libcore-7b48633d89f678d4.rlib" "-Wl,--end-group" "/usr/local/rustup/toolchains/nightly-2020-06-08-x86_64-unknown-linux-musl/lib/rustlib/x86_64-unknown-linux-musl/lib/libcompiler_builtins-af34d55ee60228b9.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lc"
  = note: /usr/lib/gcc/x86_64-alpine-linux-musl/9.3.0/../../../../x86_64-alpine-linux-musl/bin/ld: cannot find -lc
          collect2: error: ld returned 1 exit status

I assume you need some libc-dev equivalent package. Can you try this? https://github.com/gliderlabs/docker-alpine/issues/24#issuecomment-519142097

I assume you need some libc-dev equivalent package. Can you try this? gliderlabs/docker-alpine#24 (comment)

Yes, that was golden. It now compiles! Let's see if it runs...

@webmaster128 with your help and a bit more fiddling with go images, I got this working.
Building a (large) libgo_cosmwasm.a file in a rust docker image.
Compiling the go code and running go tests (linked to the .a file) in an alpine-based go docker image.
This needs serious cleanup, but the research phase is done. We will have this for 0.9 :smile:

You cannot really build .so for muslc as far as I could tell - it errors on cdylib. I can try more.
I also agree not to commit this *.a to github (and the others ideally not as well... although they are needed for go-cosmwasm development)


Can you add iso code on search icon site?

Hi, could you please add the ISO codes to the flag names on https://mantinedev.github.io/mantine-flagpack/? For example: Español ES
I couldn't find to mantinedev.github.io/mantine-flagpack website repo for this reason I opened this issue.

@rtivital


Glob <node_internals>/**/fs.js in skipFiles doesn't seem to work

Testing #19042
I was able to get <node_internals>/fs.js to work, but not <node_internals>/**/fs.js when using the skipFiles feature of debug.

@joaomoreno is this a problem with node or node2?

Great question, only seems to happen in node2.

Aha, IIRC 'node2' only supports regular expressions at the moment. This explains why the '**' part doesn't work.

I do support **, but have to map it to a regex, and I don't do that right for this node_internals case


Display an error message for the uploaded file being in the incorrect format

We should display an error message if the batch file trying to be checked in the tool is not a CSV file. The error message should display when the user selects a file and clicks "check addresses".

@benguhin Not sure what the error message should say but maybe "The file uploaded is not a CSV. Please reformat using the provided template and try again." Please let us know your thoughts on what it should say.

I have this working locally, just need the content for the message. :+1:

How about this:

The file uploaded is not a CSV file. This tool can only process CSV files that use our CSV template. For more information about CSV files, view our Frequently Asked Questions below.

This is better:

The file uploaded is not a CSV file. Please try again with a CSV file that uses our CSV template. For more information about CSV files, view our Frequently Asked Questions below.

This is better:

The file uploaded is not a CSV file. Please try again with a CSV file that uses our CSV template. For more information about CSV files, view our Frequently Asked Questions below.

Got it. Thanks.


Cancelling a search doesn't work when the search started before the searchProcess started

Disable extensions
Ensure "searchRipgrep.enable": false
Open the process viewer and check that the searchProcess hasn't started
Start a text search and immediately cancel it with

This will be easiest to see if the search will run for a long time. Open a large folder and search for a string that won't appear very often so it doesn't hit the 10k limit.

See that the search is canceled in the UI but the rg process keeps running

Then try this again when the searchProcess is already running, and see that rg is actually killed.
This has something to do with this function: https://github.com/Microsoft/vscode/blob/master/src/vs/base/parts/ipc/node/ipc.ts#L619
I think the Relay isn't disposed, so the source listener isn't disposed, and search relies on the event listener to be disposed when search is canceled, here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/search/node/rawSearchService.ts#L46
I can change this to use a cancellation token if that's better?

Absolutely great catch and analysis, you are 100% correct. This is a bug on the Relay which should also handle onFirstListenerDidAdd and onLastListenerRemove calls, in order to provide detach scenarios. Pushed fix!
PS: Found out about htop -d 1, super fast refresh rate.
PPS: While researching this, I found another issue: https://github.com/Microsoft/vscode/issues/58057


Create dialog to inform that current branch is not managed by plugin

Create some kind of dialog to inform user that current branch is not managed by plugin. Maybe create some checkbox to add this branch to plugin. Add also button to Don't ask again about this issue.

Dialog should be non-modal, we don't want it be intrusive.

create some checkbox to add this branch to plugin
I'd even say, it can be button/link (rather than checkbox per se)

What's the specific scenario for this one?

Be on a managed branch
Checkout non-managed branch (from command line / git4idea)
Show VcsNotification with an action to add the non-managed branch under the inferred parent.

Is that it?

Notes:

We need handling for no-managed root branches - where the parent cannot be inferred (I suppose).
What if the inferred parent is different from what a user expects? The VcsNotification could have two actions (despite Dismiss or smth). Accept or Accept and edit Machete file
Such a notification should take an expiration into account. I think that another checkout or Machete file edit belongs to actions that would make the notification expired (no longer valid) - probably there is more of them.

Writing it just for a log.
The topic
BranchChangeListener.VCS_BRANCH_CHANGED

is not good enough for us. I took a look into what comes to com.intellij.openapi.vcs.BranchChangeListener#branchHasChanged(String branchName) and I saw HEAD, f47545bb46bdfe280a2f80e37925d5df6918be1f, build-chain^{0} and sometimes correct result - the newly checked out branch
I think we must rely on
GitRepository.GIT_REPO_CHANGE

and most likely have our own implementation of branch change tracking.

The "wrong" ones are those I listed: HEAD, f47545bb46bdfe280a2f80e37925d5df6918be1f, build-chain^{0}.

Okay... and what was expected? That none of them shows up? 🤔

So, in a nutshell, when VCS_BRANCH_CHANGED is used, do we experience false positives (superfluous notifications) or false negatives (missing notifications)?

I would expect the name of a branch that I ve checked out 😆 the above ones even might refer to the same thing (the branch) but we need simply a name.
Another thing is that the branchHasChanged does not cover all cases. When you change the branch from command line and then move back to IDE window the topic is not being synced (it is not triggered). On the other hand, GitRepository.GIT_REPO_CHANGE works in that case correctly.

It turned out that we need #1285 before this one.


Add instructions for snapshots in README.md

Description
The current README mentions snapshots to speed up syncing of nodes. However there are no clear instructions on how to use the snapshot upon startup of the node.
Suggested Solution
Add a section on how to use the snapshots. There was a helpful thread on Discord that summarized the process. It would help new node operators to have a single source to reference when starting a node.

@d-szns
Thanks for the feedback! We'll look into adding this. :+1:

Yes publish the snapshot.
Set-up for those that don't use discord, not everyone uses that
Platform.


Optimize FK

Current coverage is 100% (diff: 100%)

Merging #38 into master will not change coverage

@@           master   #38   diff @@
===================================
  Files           9     9
  Lines         270   270
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits          270   270
  Misses          0     0
  Partials        0     0

Diff Coverage
File Path

•••••••••• 100%
pybotics/geometry.py

•••••••••• 100%
pybotics/kinematics.py

Powered by Codecov. Last update d62384d...4637f75

Coverage remained the same at 100.0% when pulling 4637f75793cdcf0a12fb6a4c36bdb269a5f78988 on fk into d62384d391c975323a6a85d6ca508fabd715f9f1 on master.

Coverage remained the same at 100.0% when pulling 4637f75793cdcf0a12fb6a4c36bdb269a5f78988 on fk into d62384d391c975323a6a85d6ca508fabd715f9f1 on master.

Coverage remained the same at 100.0% when pulling 4637f75793cdcf0a12fb6a4c36bdb269a5f78988 on fk into d62384d391c975323a6a85d6ca508fabd715f9f1 on master.


EventManager unit tests

This pull request increases the code coverage of the module, it also fixes a bug in FilterIterator when trying to extract from an empty heap.

it also fixes a bug in FilterIterator when trying to extract from an empty heap.

I think it is better to split this PR into:

1 PR for improved code coverage
1 PR for fixing the bug you mentioned

Mixing them into one PR creates lack of clarity.

I disagree; if the fix was made due to expanding the unit tests, it makes
absolute sense to keep it in the same patch.
On Jul 11, 2015 5:00 PM, "Martin-P"<EMAIL_ADDRESS>wrote:

it also fixes a bug in FilterIterator when trying to extract from an empty
heap.
I think it is better to split this PR into:

1 PR for improved code coverage
1 PR for fixing the bug you mentioned

Mixing them into one PR creates lack of clarity.
—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/zend-eventmanager/pull/5#issuecomment-120665117
.

@weierophinney What if the specific tests for the bug are wrong and code was changed to make the tests pass? Because it is unclear which tests are created specifically for the bug fix, it is unclear if all angles are covered. Looking at FilterIteratorTest I can already confirm not all code changes are covered (test for $chain instanceof FilterIterator part is missing).
Furthermore only FilterIterator::next() is covered in FilterIteratorTest and all other methods of FilterIterator are not tested at all. This indicates the fix was not created by expanding tests, because in that case more methods than only FilterIterator::next() would be covered.

My apologies for not adding more tests in the FilterIteratorTest.
The reason behind this was because the code was covered elsewhere, however if this is required then I'll make sure to do that for future pull requests.

@rms230 At this moment certain angles are not covered at all with the introduction of your new code which can create unwanted side effects which could have been prevented with the correct unit tests.


Support for latest Ginlong/Solis wifi stick (S3-WIFI-ST)

Hi,
I recently got a Solis inverter and it seems to now come with a new Wifi stick (S3-WIFI-ST).
Unfortunately the web UI is slightly different here and although it's still a web site with authentication and a status.html page, the page now contains actual HTML instead of the vars expected for the old stick and the HTML is populated via JS:
var inverter = new XMLHttpRequest();
inverter.open("get", "inverter.cgi?t=" + Math.random(), true);
inverter.send();
inverter.onreadystatechange = function() {
  if (inverter.readyState == 4 && inverter.status == 200) {
    var inverterArr = inverter.responseText.split(";");
    set_inner_by_id("webdata_sn", inverterArr[0]);
    set_inner_by_id("webdata_msvn", inverterArr[1]);
    set_inner_by_id("webdata_pv_type", inverterArr[2]);
    set_inner_by_id("webdata_rate_p", inverterArr[3] + "℃");
    set_inner_by_id("webdata_now_p", inverterArr[4] + "W");
    set_inner_by_id("webdata_today_e", inverterArr[5] + "kWh");
    set_inner_by_id("webdata_total_e", inverterArr[6] + "kWh");
    set_inner_by_id("webdata_alarm", inverterArr[7]);
  } else {
    console.log(inverter.status)
  }

Accssing the cgi URL directly gives output such as:
380XXX228080XXX;7800XX;205;44.9;4210;6.300000;d;NO;
Seeing as this is now quite different from the original format and that the project was originally for omnik inverters and not solis, do you see any point in adding support for it as part of this project?
I can try whipping up an implementation, otherwise it might be better suited in its own project.
Cheers

@koyote have you tried other source methods like the "newly added" TCP backend?

Port 8899 was not open when I tried.
I did a basic nmap scan and only found port 80 to be open.
Unless there's some other way to confirm the TCP back-end?


very poor support for TPCDS

it seems to be a bug, sqlframe don't seems to support tpcds queries at all, is this a sqlglot issue ?
https://colab.research.google.com/drive/1NGFqooYmbKs2ffQkTzMu_AWTHCHbE419#scrollTo=bANKQEwPhETg
so far only 5 % of the queries did run

Thanks for sharing this. I'm going to add this to the SQLFrame test suite and fix any issues. In general the best compatibility in SQLFrame will be using DataFrame operations directly (not passing in SQL) but it should perform much better on these queries. This should only matter when using more advanced functions since SQLFrame has specific overrides to maintain PySpark compatibility that are not part of SQLGlot.
One workaround while I improve this is to change engine.sql(value).show() to engine.sql(value, qualify=False).show() for SQLFrame. That will fix many of them but that shouldn't be needed and some others still have issues which I will take a look.

Fixed in 3.3.0. The qualify=False workaround is no longer needed.
@djouallah Let me know if you notice any performance concerns in this latest release. To fix the issue I used an approach that was most simple/versatile but could have unexpected performance implications. If you notice then I can find something more performant for each format.

it is way better, the performance is a bit strange , duckdb finish the test under 8 seconds

it is way better, the performance is a bit strange , duckdb finish the test under 8 seconds

Do you happen to know how long DuckDB alone takes? That would be a good baseline to compare against.

yes, duckdb alone took 8 second using version 1.1

yes, duckdb alone took 8 second using version 1.1

Ok thanks I will take a look at this next.

i added back duckdb, the joy of sql, I fixed the space name for spark which duckdb does not like :)


Sodium Shadowy Path Blocks

Modrinth link
https://modrinth.com/mod/sodium-shadowy-path-blocks
Source link
https://github.com/Rynnavinx/sodium-shadowy-path-blocks
License
GNU LGPLv3
Mod description
An addon for Sodium that reintroduces smooth lighting to dirt paths.
Why should it be in the modpack?
• Most users are used to the shadowyness of the vanilla dirt path and this mod reintroduces it.
• Actively Updated
• Can be disabled in settings if the user doesn't like the mod.
Why shouldn't it be in the modpack?
• It could be incompatible with a mod within the modpack.
Additional details
• It's incompatible on minecraft versions before 1.19
• Only works when Smooth Lighting is enabled.

Will be added in the next release. 👍