MutationObserver should accept HTMLElement too

Question asked on Stackoverflow (https://stackoverflow.com/questions/56546116/typescript-convert-htmlelement-to-node/56546557?noredirect=1#comment99675409_56546557 ), full credit to Cristian Traìna answer.

Inside the lib.dom.d.ts (the type definition library used by Angular), the MutationObserver object is not much correctly defined:
interface MutationObserver {
    disconnect(): void;
    observe(target: Node, options: MutationObserverInit): void;
    takeRecords(): MutationRecord[];
}

According to the MDN documentation, a HTML element is also accepted (seen in the demo: https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver´, document.getElementById('some-id') returns a HTMLElement ).
So a better definition would be
    observe<T extends Node>(target: T, options: MutationObserverInit): void;

The current workaround is to cast the HTMLElement to node via
observer.observe((<Node> <any> errorElement), {
....
});

All HTMLElements are Nodes, so this just works.  No workaround is needed, and no error is issued.
https://www.typescriptlang.org/play/#src=declare var a%3A HTMLElement%3B

var o %3D new MutationObserver(() %3D> { })%0D%0A%0D%0Ao.observe(a)%3B%20%2F%2F%20No%20typescript%20error%0D%0A%0D%0A

Maybe resolved with the latest version, had "typescript": "~3.1.6"


Refactor(AboutView):Improve code organization and reusability

Create AboutManager to encapsulate AboutView functionality
Improve code organization and reusability
Separate content sections into individual methods
Maintain existing features and layout

Thanks for the commits on code cleanup! Just to confirm, are these tied to any API changes that are only relevant with iOS 18?

No it’s not tied to iOS 18
On Friday, September 13, 2024, Venkat @.***> wrote:

Thanks for the commits on code cleanup! Just to confirm, are these tied to
any API changes that are only relevant with iOS 18?
—
Reply to this email directly, view it on GitHub
https://github.com/venkatasg/DeTeXt/pull/8#issuecomment-2348984174, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A26JAPIEOK7KFT4SNZ2WZ4TZWLTCRAVCNFSM6AAAAABOEMBGBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBYHE4DIMJXGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'll look at them this weekend and merge.

ok thanks
On Fri, Sep 13, 2024 at 8:03 PM Venkat @.***> wrote:

I'll look at them this weekend and merge.
—
Reply to this email directly, view it on GitHub
https://github.com/venkatasg/DeTeXt/pull/8#issuecomment-2349940395, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A26JAPIEMD7DGAZMIPI5UOTZWMZG5AVCNFSM6AAAAABOEMBGBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBZHE2DAMZZGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

please don't forget
On Fri, Sep 13, 2024 at 8:38 PM DANIEL DANIEL @.***>
wrote:

ok thanks
On Fri, Sep 13, 2024 at 8:03 PM Venkat @.***> wrote:

I'll look at them this weekend and merge.
—
Reply to this email directly, view it on GitHub
https://github.com/venkatasg/DeTeXt/pull/8#issuecomment-2349940395, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A26JAPIEMD7DGAZMIPI5UOTZWMZG5AVCNFSM6AAAAABOEMBGBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBZHE2DAMZZGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

hello Good Day, i just wanted to remind on the review
On Sat, Sep 14, 2024 at 9:06 PM DANIEL DANIEL @.***>
wrote:

please don't forget
On Fri, Sep 13, 2024 at 8:38 PM DANIEL DANIEL @.***>
wrote:

ok thanks
On Fri, Sep 13, 2024 at 8:03 PM Venkat @.***> wrote:

I'll look at them this weekend and merge.
—
Reply to this email directly, view it on GitHub
https://github.com/venkatasg/DeTeXt/pull/8#issuecomment-2349940395,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A26JAPIEMD7DGAZMIPI5UOTZWMZG5AVCNFSM6AAAAABOEMBGBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBZHE2DAMZZGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Good day sorry a gentle reminder
On Wed, Sep 18, 2024 at 10:34 AM DANIEL DANIEL @.***>
wrote:

hello Good Day, i just wanted to remind on the review
On Sat, Sep 14, 2024 at 9:06 PM DANIEL DANIEL @.***>
wrote:

please don't forget
On Fri, Sep 13, 2024 at 8:38 PM DANIEL DANIEL @.***>
wrote:

ok thanks
On Fri, Sep 13, 2024 at 8:03 PM Venkat @.***> wrote:

I'll look at them this weekend and merge.
—
Reply to this email directly, view it on GitHub
https://github.com/venkatasg/DeTeXt/pull/8#issuecomment-2349940395,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A26JAPIEMD7DGAZMIPI5UOTZWMZG5AVCNFSM6AAAAABOEMBGBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBZHE2DAMZZGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hey I'm sorry I I've been busy with my work for last few weeks. This is a hobby for me and I can't attend to pull requests as frequently as I'd like. If you leave this open I will get to it in due course.


Feature request - trendline for Scatter Plot

Expected Behavior
Should draw a trend line if user wants to see it (via some API function most likely).
Current Behavior

No trendlines available yet
Possible Solution

Calculate trendline by calculating slope and y-intercept based on data points. Would need more detailed explanation, not exactly sure myself.
Steps to Reproduce (for bugs)

Screenshots (if appropriate):
Context

Relevant feature for scatter plots

The API function (probably is the simplest way to do it) could then simply be hasTrendline(hasTrendline: boolean). The x-extent could then be calculated from the dataset directly using d3.extent(data, d => d.x). The one complication that may be worth having is an optional parameter or overloaded form that allows a custom x-extent. Then calculate y points using the following (or similar) helper function:
function linest(data) {
  let n = 0, x = 0, y = 0, xy = 0, x2 = 0, y2 = 0;

  data.forEach(d => {
    n++;
    x += d.x;
    y += d.y;
    xy += d.x * d.y;
    x2 += d.x * d.x;
    y2 += d.y * d.y;
  });

  const denominator = (n * x2) - (x * x);
  const intercept = ((y * x2) - (x * xy)) / denominator;
  const slope = ((n * xy) - (x * y)) / denominator;

  return { intercept, slope };
}

Looks great! Is that a usual calculation to find trends?

Yeah, that is just my super quick implementation of the standard least squares regression formula. There may be a more efficient way to do it, but I didn't investigate.

Great! Thanks for this!!
On Sat, May 26, 2018, 9:36 PM Brendan Ratter<EMAIL_ADDRESS>wrote:

Yeah, that is just my super quick implementation of the standard least
squares regression formula. There may be a more efficient way to do it, but
I didn't investigate.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/eventbrite/britecharts/issues/593#issuecomment-392304792,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALpcda12Fm_JRcnflo5o-yxFXDNl9wHks5t2i1ogaJpZM4TL8TA
.

Hi @bratter ! Thanks a lot for proposing the formula for calculation. I would appreciate your review in this PR: https://github.com/eventbrite/britecharts/pull/621

FWIW I looked quickly at the code and looks fine. Two suggestions though:

Might be worthwhile having a test or so to check the correctness of the regression formula.
Stylistically, why not put the math in a helper function and out of the main code?
Cheers!

@bratter thanks for reviewing! We could separate calculations from the main code - I just didn't see the case for the linear regression calculation for other charts other than Scatter Plot, but I can see that it will keep code cleaner. It would also be easier to write tests for the function since currently it's private function but if it's in a helper, we could write tests for validation of the calculations in helper tests. That makes sense. Thanks a lot for your great suggestions!


Readme correction

In ReadMe under EVALUATION text should be changed from:
"Not that results are not provided for the all_tools variant of GPT3.5 and LLama2-70B as the prompt does not fit into the context window for these models."
to
"Note that results are not provided for the all_tools variant of GPT3.5 and LLama2-70B as the prompt does not fit into the context window for these models."

Good spot, thanks @esbovee . Fixed that now, welcome to the repo :)


gs crashes when minotaur is restarted

sudo systemctl restart minotaur while minotaur --gs makes it crash.
Traceback (most recent call last):
  File "/home/mock/rpmbuild/BUILD/minotaur-<IP_ADDRESS>/minotaur.py", line 958, in <module>
  File "/usr/lib64/python2.7/curses/wrapper.py", line 43, in wrapper
    return func(stdscr, *args, **kwds)
  File "/home/mock/rpmbuild/BUILD/minotaur-<IP_ADDRESS>/gs.py", line 84, in gs
  File "/home/mock/rpmbuild/BUILD/minotaur-<IP_ADDRESS>/gs.py", line 449, in get_local_data
TypeError: string indices must be integers, not str

couldn't reproduce with the latest build, try upgrading


Fix strictness of query params

In cases where a non-GET request has optional query params, the .create() function incorrectly allow you to omit them. This runtime code must be present so the library can distinguish between body and query parameters, even if the actual call omits the optional param

@happycollision Would it be alright if I add this to my fork?


Micro.blog custom CSS, footer, JS

Added references to the special custom.css and custom_footer.html templates that Micro.blog uses. Increased the plug-in version number too, although feel free to manage that yourself. Thanks!

All are necessary changes, merged the PR.


main screen auto-select problem with ultrawide

Hello.
i love the ambilight feature integrated in aurora and would like to use it on a daily basis
the problem is : i've got 2 screens, a standard 16:9 and an ultrawide 21:9 monitor
because of the ultrawide nature of my main screen, aurora doesn't detect it as my primary screen (it is set as primary screen in windows, of course) and only selects my secondary screen
i saw that multi-monitor setups were "fixed" but i cannot choose my ultrawide as the ambilight screen
could you please add a setting allowing us to choose which monitor to use and not only the "main" one?

Will look into, but I believe dev branch has this issue resolved.

@ZephyrArcturus Could you try the latest development release to see if it resolves your issue?

@antonpup @simon-wh the issue is fixed with the 0.6.1 dev2 update!
thanks a lot for the awesome work


imagemagick: 6.9.9-34 -> 6.9.10-68, fixing numerous CVEs

Motivation for this change
To get an idea of how numerous see #70099
I haven't done a full nix-review yet as I don't have the resources, but everything I've rebuilt so far has been ok...
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@risicle Thanks for the PR! Bumping from 6.9.9 to 6.9.10 shouldn't be a problem, also when backporting to 19.09.
Did you check how hard it'll be to upgrade nixpkgs master to imagemagick 7.x (in a followup PR)?

backported to 19.09 in 29d40ef73562f0a2180dbdf56ad2960824bd7791.

Did you check how hard it'll be to upgrade nixpkgs master to imagemagick 7.x (in a followup PR)?

I didn't get on to that - my machine spent most of Sunday building less than a quarter of the 6.x reverse deps.

Can you publish the commit somewhere without running nix-review? I could trigger that on some more powerful machines.

I mean I didn't even look at 7.x, I'm already spinning ~6 open CVE PRs as it is.

All good :-) Thanks a lot :+1:

This update broke the tests of the gscan2pdf package because of https://github.com/ImageMagick/ImageMagick/issues/1632 and https://github.com/ImageMagick/ImageMagick/issues/1636. The issue seems to be fixed in 6.9.10-69 and 7.0.9-0.
Would it be possible to have a new update and a backport for 19.09?

Submit the PR :)


Javascript: add solution to hint Match Characters that Occur Zero or …

…More Times
Add solution to hint Match Characters that Occur Zero or More Times

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@greggubarev, everything LGTM! Thank you for helping us improve this section of the guide. Looking forward to your next contribution! :+1: :+1:


[canvaskit]: switch to the official shadow bounds estimator

We currently use a home-grown algorithm for estimating shadow bounds. There's risk that our algorithm gets it wrong and causes rendering issues. When https://bugs.chromium.org/p/skia/issues/detail?id=11146 is available we should switch to the official shadow bounds estimator.

https://bugs.chromium.org/p/skia/issues/detail?id=11146 have been marked "fixed". Is it available now?


gitflow-feature-stash: authentication

Added: Login, Registering, Logout, Base Screens
closes #18
closes #19

This PR is closed as its content is being pushed in #35


[stable/traefik] Add File Backend

What this PR does / why we need it:
While Traefik's Kubernetes Ingress serves most common cases, there are advanced cases when the Kubernetes Backend is not capable of. This PR allows user to add File Backend which allows more fine grain control in the same Traefik instance. For example see this issue https://github.com/kubernetes/kubernetes/issues/41881
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

hi @mmatur @nmengin could you have a look at this PR? Thanks.

/ok-to-test

/lgtm

@maorfr Thanks for reviewing. I've resolved the merge conflict on chart version. Please proceed.

/lgtm


Replace WebL10n to i18next

The web site rely on webl10n for localization both in index.html and activities.html.
It use both a local localization file locale.ini and the locales coming from Sugarizer core to get activities description (see here).
Because Sugarizer core has migrated to i18next, the idea is to migrate to i18next here. See here for inspiration.

Fixed in https://github.com/llaske/sugarizer-doc/commit/5c1e5c02f7374878908aa0167b7ccde41f9b87d2
Could be interesting to note for https://github.com/llaske/sugarizer/issues/1378 that I've added a function updateDocument method (see here) to update HTML element with the tag data-i18n.


CommandHandler: Implement simple help command

The help command has to be implemented in the command handler, as it holds the list of available commands
(This PR also includes a small commit that adds a missing await)

Sweet!


Is there any guideline for DCM versioning?

If add one more interface, should I change the capability model ID with a different name, or just increase the version? User will need to know this to well manage the capability models and interfaces.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b823a4ee-1a38-c575-6fc7-4bedf64e1edc
Version Independent ID: 7128fb4f-bbd4-68ba-618c-1734fb419b71
Content: Developer guide - IoT Plug and Play
Content Source: articles/iot-pnp/concepts-developer-guide.md
Service: iot-pnp
GitHub Login: @dominicbetts
Microsoft Alias: dobett

Contacting off-line
#please-close

@dominicbetts Thanks for the quick response.
@yphuangms If there are further questions regarding this matter or questions or feedback on the documentation, please do let us know and we will gladly continue the discussion.


Check recent Travis build times

Look through the most recent Travis build times and see what the average seems to be.

Linux jobs range from 20 to 30 minutes, and Mac jobs range from 25 to 35 minutes. So we are fine for now. But going forward, we should be aware whenever we add new tests that we need to keep all of our jobs below 50 minutes.


Relative motion properties

First, this is a great library, thanks to everyone who contributed to it.
I'm trying to use it with relative(percentage) properties like this:
<div
    v-motion
    :initial="{ x: '0%' }"
    :enter="{ x: '60%' }"
/>

And I'm getting the "TypeError: v.match is not a function" error.
Is this not supported? Thanks!

I don't know why this is here since June 2021...
Btw, you can leverage popmotion string parsing capabilities and write this code, which works:
<div
  v-motion
  :initial="{ transform: 'translateX(0%)' }"
  :enter="{ transform: 'translateX(60%)'}"
/>

@antfu this is a very much needed feature, hinders a lot of responsive animations. There should be a clear stand on this issue, when you have 5 minutes could you take a look at this? Thanks 😄 ❤

Would be great to have percentage values supported in style properties! :)


fix: overwrite system sound for push notifications via a custom one

Details
Based on the assumption, that we receive push-notification only for plain messages -> we can skip a call to playSound(SOUNDS.RECEIVE) and change a native code to play a receive sound (that's exactly what I did in this PR).
Fixed Issues

$ https://github.com/Expensify/App/issues/36579
PROPOSAL: N/A
Tests

Open app on two devices (A and B)
Send a message from device A to device B
Be sure that you hear a custom sound only when message is received (plain messages)

[x] Verify that no errors appear in the JS console

Offline tests
Not needed.
QA Steps

Open app on two devices (A and B)
Send a message from device A to device B
Be sure that you hear a custom sound only when message is received (plain messages)

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Android isn't working for me, I still get the default notification sound.

Can you try to clean app data or do a clean installation? I had the same problem - it seems like if channel is created then it's kind of persisted, so the modified code (new sound) will not be applied.

Can you try to clean app data or do a clean installation?

Yep, working now on Android 👍
iOS is going to be a problem to test though, I might need to build locally

Yep, working now on Android 👍

By the way I still think it's a bug, because if we publish a new version, then people will have to re-install app in order not to hear default sound - maybe we need to find a way on how to invalidate channel without an additional user interaction?

maybe we need to find a way on how to invalidate channel without an additional user interaction?

Ah, seems like a new channel is the solution. Though I'd rather not do that. We've barely started to migrate users yet so this isn't really a problem

After you create a notification channel, you can't change the notification behaviors.

After you create a notification channel, you can't change the notification behaviors.

I thought about deleting an old channel and creating a new one (and adding versioning to this). But if it's not a problem, then okay 🙂

Hey @abdulrahuman5196 can you review this, excluding iOS? For Android the generated build should work, and for the other platforms we should still here the received message sound.

@kirillzyusko I think the test steps are wrong. We want two tests, one for iOS/Android and another for the other platforms to ensure the sound plays

I think the test steps are wrong. We want two tests, one for iOS/Android and another for the other platforms to ensure the sound plays

@Julesssss I updated test steps 👍

@kirillzyusko Couple of auto-checks are failing for this PR? Could you kindly check on the same?
@Julesssss Could you kindly generate builds again, since we had changes after the last build?

@Julesssss Could you kindly generate builds again, since we had changes after the last build?

Build in progress 👍

@kirillzyusko I see there's a podfile error, have you been able to build ios and test that the audio doesn't play when a simulator recieves a message?

I see there's a podfile error, have you been able to build ios and test that the audio doesn't play when a simulator receives a message?

@Julesssss I think I also had a changed Podfile after Pods installation, but it wasn't related to changes that I did, so I thought  that problem comes from main, so I didn't commit the lock file. I pulled latest changes from main - I believe the problem should gone 🤞

@kirillzyusko can you add screenshots and check that item off the list please

@Julesssss / @kirillzyusko

Be sure that you hear a custom sound only when message is received (plain messages)

Does this mean only messages without any markdown? I hear sound for message I have strikethrough and italic features added.
Am I mis-understanding something here?
But anyways I get the custom sound for all event in android.

I hear sound for message I have strikethrough and italic features added.

@abdulrahuman5196 no, presence of markdown in messages shouldn't make any impact. By "plain" messages I meant all messages excluding mentions/money transfers/task completion/etc.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/46707890/d9ccb4f5-305b-4a18-ad46-283fbf6511f6

Android: mWeb Chrome

https://github.com/Expensify/App/assets/46707890/ce756c7f-29e4-4626-8cc0-69726b8de27f

iOS: Native

iOS: mWeb Safari

https://github.com/Expensify/App/assets/46707890/cb8d80a0-2a3c-464f-bc10-cc53b936fd4f

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/46707890/480bbb62-4086-45b4-ab31-30c8ec64f26e

MacOS: Desktop

https://github.com/Expensify/App/assets/46707890/38f85224-7aa8-4ad8-a7e3-a7141ebd2fd2

@Julesssss I am unable to test in iOS native alone, since I am not part of the development profile like here https://expensify.slack.com/archives/C02NK2DQWUX/p1698038568836489
I tested on other platforms.
Could you kindly test in iOS native and have a quick look?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Okay, I have verified Android, and @dylanexpensify has verified Android. Excellent 🎉

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Vertices and Faces ?

Hello, thank you for your amazing implementation
Can you guide me how can i get vertices and faces for my custom images to use with this implementation ?
It would be great if you can provide a Google Colab Notebook Demo for this repo, it'll help everyone and it'll be much appreciated,
Thank you

Hi @Adeel-Intizar ,
Thanks for asking. The SMPL model receives as input the pose (θ) and shape (β) parameters and returns the vertices and faces. Now, to get the pose and shape parameters you must train a previous model. In my case, a few months ago, I was working on a project and I used the STRAPS model as a base, the architecture is as follows:

To use the library you can be guided by this example.
I hope I have helped.

Can you tell me where and how can i get a smpl model for my custom images, which can be used with this implementation?


Bug: mesh parts of Spine are not shown when using basis texture

When png texture is used, everything works, but when basis texture is used for Spine, mesh parts are invisible.

Demo: https://pixi8spine.enea.sk/
Repo: https://github.com/EneaEntertainment/pixi-8-spine
PixiJS 8.1.5, spine-pixi 1.0.10

Hey, I believe we have fixed this in 1.1.0, feel free to reopen if not!

sorry, same in 1.1.0

Spine expects the image of the texture to be an HTMLImageElement or an ImageBitmap.
That's not the case when texture-basis is provided (an Array is received).
HTMLImageElement and ImageBitmap have both width and height properties that spine-core 4.1 used to get the width/height of the texture.
These values are used to calculate the uvs that in case of meshes becomes NaN since  width and height do not exists.
spine-core 4.2 no longer relies anymore on width and height of the image, but uses the information provided by the atlas file.
I'll try to backport to 4.1 the way the width and height of the image is read in 4.2.

Hi
We have now moved this project to the official Esoteric Software repo for them to maintain. As a result we will be archiving this repo and closing all issues. If you still are having this issue please feel free to open an issue over on the new repo!

New Repo

As for migrating between the projects it should be as simple as swapping out the imports from @pxi/spine-pixi to @esotericsoftware/spine-pixi-v8


#302 memoize expensive operations

decided against using useMemo to maintain pre 16.8 compat, rendered a very large code block
initial rendering:

subsequent:

will look at tests


Port Windows device support from containerd

(Contributes to the high-level goal of supporting Windows containers, as outlined in #28.)
This change adds support for exposing host devices to Windows containers using the --device flag with nerdctl run. The code itself is directly ported from containerd, where it was first contributed by @TBBle in #6618 (relevant diff lines here), and subsequently modified by @thaJeztah to use strings.Cut() in commit eaedadbe. My only unique contribution here is to update the command reference and adorn the --device flag with the little blue square which denotes Windows support. :laughing:
It's worth noting that I haven't added any unit tests to cover this functionality. Most of the existing Windows unit tests appear to run containers and check their output, but I don't know of a decent way to test this without requiring that a GPU be present on the underlying host system. I can see that Windows unit tests are currently run as part of the Cirrus CI workflow, but I suspect that the cloud VMs being used for the tests do not have GPUs, and any test requiring one would fail. If a simpler kind of unit test would be desirable (e.g. one that just tests the parsing behaviour for device IDType://ID values without actually running a container) then I would certainly be happy to write one.

LGTM for implementation. but is it possible to add an integration test with a special device ( e.g  NUL device)  ?

So looking at the Devices in Containers on Windows page, I see the following devices can be exposed to containers:

Device Type
Interface Class GUID

GPIO
916EF1CB-8426-468D-A6F7-9AE8076881B3

I2C Bus
A11EE3C6-8421-4202-A3E7-B91FF90188E4

COM Port
86E0D1E0-8089-11D0-9CE4-08003E301F73

SPI Bus
DCDE6AF9-6610-4285-828F-CAAF78C424CC

DirectX GPU Acceleration
See GPU acceleration docs

Perhaps a COM port might be the best option? I don't think cloud VMs typically have one by default, but if we're able to modify the VM image used for the Cirrus CI workflow then we could potentially install a third-party driver that provides a virtual COM port and use that?
(It's also worth noting that those docs are quite out of date compared to what's supported by newer versions of Windows, so experimentation might potentially reveal other types of devices that could be used instead. After all, that page still references the old IDType/ID syntax rather than the newer IDType://ID syntax, and makes no mention of exposing GPUs via their LocationPath, which was evidently introduced in HCS schema version 2.2 with the release of Windows 10 version 1903.)

IDType://ID is just a ctr format choice to introduce devices.

Oops, my mistake! I had incorrectly assumed that this was an HCS API convention due to seeing that format used within the hcsshim codebase, but looking again now, I can see that the only place it's actually used is within unit tests related to containerd (hence the use of the containerd/ctr format convention).

cirrus base image is windows-2019-core-for-containers. We fill all the requirement to run one of these devices. I am wondering is there a built-in/specific device in the above list

So looking at the Cirrus docs for the compute_engine_instance execution environment, it seems that the VM that gets launched is a Google Compute Engine instance (and the Packer template you linked also confirms this). According to the Google Cloud docs, GCE instances should have four COM ports by default, which are used for the instance's serial console. If one of these built-in COM ports can be exposed to Windows containers then we should be able to use that for testing, without the need for a virtual COM port driver. I'll run some tests with a GCE instance and report back.

To clarify, I was trying to standardise to IDType://ID everywhere as since the initial class/GUID syntax was introduced, we've had other IDTypes than class (in HCSv2 onwards) created that may have / in the ID, so this gives a less-ambiguous parse. It also lets us easily reject accidental use of POSIX paths, i.e. using Linux device syntax with a WCOW container is never incorrectly accepted.
As it happens, Docker had not yet had a release supporting anything except class as an IDType, so we took the opportunity to mark IDType/ID as deprecated, and only have one supported value for IDType in that syntax: class for back-compat. There was literally no tooling in existence that attempted to expose other IDType values except an old fork of containerd by one of the MS team, which is where the IDType://ID syntax was introduced. (Which is how it ended up in the hcsshim unit tests where I first saw it; they were run against that containerd fork.)
So I'd lean towards avoiding supporting class/X if possible, and only support IDType://ID for clis. That's what I did with ctr, as it had no existing --device support for Windows. Because we could get class/GUID from k8s-directx-device-plugin and the existing docker cli, both moby and the containerd-cri backends needed to support it.
It's a good call that now that Docker v.23.00 is released, the MS docs can probably be updated to prefer the new syntax, and possibly demonstrate some of the other IDTypes, although the others tend to rely on system-local details that you look up with pnputil. class itself is marked as legacy IDType, but the replacement name escapes me. (I'd have to look it up in the containerd unit tests, to be honest...)
Note that there was no matching change in the Docker cli AFAIR because it passes the string wholesale through the API, so all the parsing is on the moby/moby side.
So anyway, the current code seems fine to me on this basis (since I wrote an earlier version...), just giving some background as to why, and giving context if you decide you want Docker-legacy-compat as well. (In which case, consider slurping code from either containerd-cri, or moby, since both do the same splitting but also recognise class/GUID explicitly.

For integration tests, you could consider the trick I used in containerd (or moby... I forget which) which is that when activating the DirectX device class, even if no dedicated GPU is present, a magic host-bind-mount is created. That's where this nonsense came from, and proved able to run integration tests on the random Azure and GitHub Actions VMs that containerd test suites get run on.
If you check C:\windows\System32\containers\devices.def you might find another device class that also does something detectable when used.
We also had a discussion somewhere (probably in that PR's history, but it might have been in the matching moby/moby PR; whenever it was that MS's container device expert noticed what I was up to and suggested we find a not-relying-on-undocumented-internal-behaviour solution) about using pnputil or similar to detect mapped device classes or individual devices. However, pnputil isn't present in nanoserver images, from memory. So we filed the host-mount trick as "good enough" to merge, since it was already true for every released Windows version we cared about, and replacing it was still a "someday" idea for that team.
There's also this little toy I was putting together to use in integration tests of this code, before I realised the directory-mount trick would be simpler.
If you want to look at other IDType values for tests, I believe that the containerd-cri test suite's TestWithDevices contained every variation I could find, including links to where I found them. However, these were parse-only tests, since as I mentioned a few of the IDTypes depend on system-specific details, e.g. the PCI routing path to the device to be mapped into the container.

@TBBle thanks for the additional context and advice about testing this functionality!
So I performed some tests on a GCE instance, and I was indeed able to expose the COM ports to a Windows container. The only problem was that the chgport command I was using to test for their presence isn't available in the Windows Nanoserver image that's used for the unit tests, and the other alternatives I could find required PowerShell. As a workaround, I attempted to simply bind-mount C:\Windows\System32\chgport.exe from the host system, but unfortunately that failed due to #759.
In the end, I decided that the simplest option was to follow @TBBle's example by specifying the device interface class for GPUs and testing for the presence of the C:\Windows\System32\HostDriverStore directory inside the container. Obviously this isn't ideal given that Microsoft might decide to change the path in the future (breaking both this unit test and the one in containerd itself), but it's the best we can do without adding files to the test image or waiting for bind-mount support to function correctly. Later on down the track, I suspect that a better test would be using device-util.exe from the hcsshim repository to test for the presence of the \Device\DxgKrnl entry in the Object Manager namespace for the container's Silo, since my understanding is that the path for that particular mount cannot be changed out from under us without Microsoft making fundamental changes to the way that WDDM works.

CI is failing after 5 retires :( . I believe that cause is not related to your changes

Yeah, the CI failures all appear to be rootless Linux tests, and the changes in this PR only affect Windows hosts, so I guess something else must be going on there.


add multiple profiles

resolve #564
resolve #568
resolve #569
resolve #570
resolve #571
resolve #572
resolve #573
resolve #574
resolve #575
resolve #576
resolve #577

I have to take a closer look when I'm home but I think it would be better if there would be an issue for each of those profiles. But this is only my opinion may we can discuss this and someone else can share their thoughts on this.

I have to take a closer look when I'm home but I think it would be better if there would be an issue for each of those profiles. But this is only my opinion may we can discuss this and someone else can share their thoughts on this.

I revised my issue and pull request like what you suggest. You can check again

It is done.


"You must upload a watermark" warning is displayed "too early".

Using 3.0, when "enable watermark" is selected on admin-gui (while creating a new theme), a red warning is automatically shown which displays "You must upload a watermark".
It seems this warning might be shown only on form validation, not when just enabling watermark.

The decision was made to not migrate to Github but stay with Bitbucket and Jira.
If this  issue still persists, can you please open a ticket at
https://opencast.jira.com


merge v7.20.4 & add support for sqlite RETURNING clause

merge 'v7.20.4'
305de9a: add support for  sqlite RETURNING clause

discarding in favor of #6 that merges to v7.21.4 and adds support for WAL mode.


Add Bundled Type Decleration for the exports

This PR adds Type Definitions for the package. It is intended to be used by developers who're working with TypeScript.
I left out the types for the parameters of methods on *Solvers, as they would require the entirety of tfjs and mediapipe as dependencies
References
TypeScript: https://www.typescriptlang.org/docs/handbook/basic-types.html
Module Declaration: https://www.typescriptlang.org/docs/handbook/declaration-files/templates/module-d-ts.html

lgtm!


Updating Azure instructions

Updating the setup instructions for Azure to indicate the fact that the default StorageClass object no longer needs to be explicitly provisioned into the cluster.

// CC @nw


Add close method to interactive console

This is on top of https://github.com/sbt/zinc/pull/872

To validate this pull request against other sbt modules, please visit this link.


build: update build to use setuptools

old fashioned, I guess, but this project doesn't need anything special

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.


Use accept4 on *BSD as well as Linux.

The modern BSDs have accept4 too, so we should use it if it is available. The existing code already contains a fallback in case the syscall doesn't exist.
DragonflyBSD has it since 4.3: https://man.dragonflybsd.org/?command=accept4&section=2 (see the HISTORY section)
FreeBSD has it since 10.0: https://www.freebsd.org/cgi/man.cgi?query=accept&&manpath=FreeBSD+10.0-RELEASE
NetBSD has it since 8.0: https://man.netbsd.org/NetBSD-8.0/accept.2
OpenBSD has it since 5.7: https://man.openbsd.org/OpenBSD-5.7/accept.2
NetBSD also has an equivalent paccept since 5.0, but I didn't think it worth it to add another code path for that.

Good point, added :)

@de-vri-es macOS and iOS don't have accept4(2).


Document atlas.sh in readme.md

It was added recently, and it should be described along with build.sh

PR #55

Merged - Thanks again!


poppler can not find freetype in vckpkg

In cmake-gui
CMAKE_TOOLCHAIN_FILE is defined as path/to/vcpkg/scripts/buildsystems/vcpkg.cmake
cmake failed:

Could NOT find Freetype (missing: FREETYPE_LIBRARY FREETYPE_INCLUDE_DIRS)

> vcpkg list
...
freetype:x64-windows                               2.10.2#4         A library to render fonts.
...

solved by add set(CMAKE_TOOLCHAIN_FILE /path/to/vcpkg/scripts/buildsystems/vcpkg.cmake) as the first line in CMakeLists.txt


Add "true" to the command line for Windows.

The npm/bin folder is now on the environment path on Windows platforms, and the "true.cmd" file gives similar behavior to "true" on Linux.

Closing other pull request 1ae770e6314f70ac87d6bd9ef43d12ae067b17e6.
Relates to issue #1625.

Sorry, forgot the parentheses.

How does npm put the "npm.cmd", "npm_g.cmd", "npm-g.cmd" into the node folder?
Is there a way to do this conditionally only on the win32 platform?

I am more and more lukewarm on this pull request so I'm closing it.
For anyone running into this same problem, you can manually add a "true.cmd" file with exit 0 as the contents and put it in the same folder as node.  This will solve it.


Connect from ios

On the server:

list all the local listen addresses
use async main

On the client:

use async/await in Connect

It was probably deadlocking in Connect - for me it doesn't work without the client change, and does afterwards.
An alternative might be to Task.Run(() => Connect()) in the event handler, but I think it's best to write the Connect method etc. with async and Tasks and treat it as 'just a coincidence' that the method is called from an event handler (async void).

This works! Thank you! ♥


Forking the Node implementation on CodeSandbox fails

Build fails
Forking the Node implementation on CodeSandbox fails with 502: Bad Gateway
In the console you get the following:
$ node server/node/server.js
/sandbox/node_modules/serve-static/index.js:40
    throw new TypeError('root path required')
    ^
error Command failed with exit code 1.

To Reproduce
Fork and see

Thanks for the report, @lgs. This sample is deprecated. Please use: https://github.com/stripe-samples/subscription-use-cases/.


Fix databricks 3.0.1 for ParquetFilters api change

Pull https://github.com/NVIDIA/spark-rapids/issues/3098 back to 21.06.1
It requires cherry-pick https://github.com/NVIDIA/spark-rapids/commit/9bec1423d4c06ca506cca1c4312e94df53f9c41d and https://github.com/NVIDIA/spark-rapids/commit/e303d2d7dc0b371a6c5525b555e91ac22325adb8 .
I ran on databricks 7.3 and parquet tests all pass. Running the rest of the tests now.

build

integration tests all pass on databricks 7.3 and 8.2

since this is still running w/ the 21.06-version pre-merge tests, it would cost a few more hours. I will merge it instantly after the tests done finish


urcli api usage on Android devices.

No need to keep your system/laptop turned on for 24 hours a day. Now you can use awesome urcli API on our mobile devices.

@rpalsaxena This is really cool! :+1:
Unfortunately, Termux does not work for me because I have an outdated version of Android. :disappointed:
I've tried with this emulator with no success. The problem is that it does not come with apt and only have the built-in operations. To have better support I'd have to install BusyBox. But it seems that even then I would not have apt.
So, do you know if this approach works with another emulator besides Termux?

Hi @rpalsaxena, fantastic that you are contributing! I've only today written a guide on how to contribute and it hasn't been merged with master yet, awaiting input from @gabraganca , but you can read it in the contributing branch.
I've reviewed your additions, and I think it's really useful information. The comments are all about form rather than the substance, and I will approve the PR once we agree on the form.

It doesn't look like this PR will get an update, so I'm closing it.


Synchronize console writes

Signed-off-by: Michael Carroll<EMAIL_ADDRESS>🎉 New feature
Summary
Provide an internal mechanism for console writes.  This will prevent messages from being interleaved.
Test it

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

I'd be interested in knowing how this affects performance.

I agree.  We don't have any metric for console performance right now, so it's a bit handwavy.

I copied this latency test from a spdlog test I found: https://gist.github.com/KjellKod/4d88035f9af513eed69e
All times are in microseconds:
Without the mutex:
Num Threads: 1, Min: 3.0, Max: 742230.0, Mean: 6.500559, Median: 5.0
Num Threads: 2, Min: 2.0, Max: 134537.0, Mean: 15.518016, Median: 15.0
Num Threads: 4, Min: 2.0, Max: 103224.0, Mean: 32.359236, Median: 43.0
Num Threads: 8, Min: 2.0, Max: 59725.0, Mean: 68.890648, Median: 107.0
Num Threads: 16, Min: 2.0, Max: 57508.0, Mean: 140.911656, Median: 249.0
Num Threads: 32, Min: 2.0, Max: 56070.0, Mean: 285.820097, Median: 536.0

With the mutex:
Num Threads: 1, Min: 3.0, Max: 836221.0, Mean: 6.156619, Median: 4.0
Num Threads: 2, Min: 3.0, Max: 183572.0, Mean: 18.738199, Median: 17.0
Num Threads: 4, Min: 2.0, Max: 64967.0, Mean: 38.969061, Median: 52.0
Num Threads: 8, Min: 2.0, Max: 55175.0, Mean: 85.129123, Median: 137.0
Num Threads: 16, Min: 2.0, Max: 52507.0, Mean: 169.010793, Median: 292.0
Num Threads: 32, Min: 2.0, Max: 50190.0, Mean: 336.777897, Median: 602.0

I found more data races with TSAN and opened a PR suggesting chagnes: https://github.com/ignitionrobotics/ign-common/pull/237

The ABI check is not happy because of the new Logger::Buffer::xsputn override and the Logger::Buffer::syncMutex member. Technically, this is true, but Logger::Buffer is an internal class and should not be instantiated by users, so I don't think it's a true ABI break.

Logger::Buffer is an internal class and should not be instantiated by users

I'm not sure if that's true. The Logger class has virtual members, which implies that it's meant to be extended. Derived classes would have access to Buffer, right?

I'm not sure if that's true. The Logger class has virtual members, which implies that it's meant to be extended. Derived classes would have access to Buffer, right?

So...it looks like Logger::rdbuf returns a pointer the Buffer object, so yeah, any type of user, not just derived classes, would have access to Buffer. Adding a new override would break ABI  😢. But if we can't override xsputn, I don't know how we can prevent a race condition on the internal std::string buffer.

But if we can't override xsputn, I don't know how we can prevent a race condition on the internal std::string buffer.

Looking at the ABI report again, it looks like the only issue is the new mutex. Can we do the static map trick to avoid adding the member variable?

Thanks @nkoenig for adding the map. My concern with using a global variable is that it violates the GSG guideline about objects of static duration that have non-trivial destructors. I would vote for making the map a function-local static variable that gets allocated on the heap and never gets deleted. I know this would cause errors when running under a memory profiler, but I think it's worth it to avoid the potential bugs that can be caused by having the map be a global variable.

@azeey ready for another look, switched to function local static map pointer.

Are we planning to backport this to citadel?

Probably need to increase the timeout on the test. I think that's why windows CI is failing.

Probably need to increase the timeout on the test. I think that's why windows CI is failing.

Done, it looks like we are only failing in the plugin specialization test, which is known flaky.

This pull request has been mentioned on Gazebo Community. There might be relevant details there:
https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1


Gestures not detected : Drag

Hello,
My version ^0.60.5, seems not detecting drag or zoom gestures.
Only zoom-in by tapping on map is detected.
Below, my OSMOption.
  OSMOption osmOption = const OSMOption(     enableRotationByGesture: true,     showZoomController: true,     showDefaultInfoWindow: true,     zoomOption: ZoomOption(initZoom: 18.0),   );
Do you have any idea to fix it ?
Thanks

can you give us more code to see the issue
and on which platform you get the issue web or mobile ?

Hello @liodali,
Thanks for reply, without changing anything, issue seems to go away.
So, it's ok at the moment :)
Have nice day !


Setting global color value

How can I set the color value globally on Vue.directive?

Hi @luiztsmelo ,
For now you can provide the color you want when declaring the directive directly on each element. As explained in the documentation.

I have different color

Maybe we could think about adding that option for further releases.

It'd be a good implementation. Thanks @Edujugon.

#14


When move out of Alpha?

I think we have added the notice here recently about the Alpha version.

What's the timeline of auditing or any other essential steps to move out of Alpha?
This will be important when developers would like to build something serious with JS SDK.

@think-in-universe now we are trying to define the process and requirements for this. I will post updates here once I have them.

So there are two streams of work going on to reach 1.0.
The first is API stability, we want to rework the API a bit because some parts are a little finicky to work with and we don't have complete APIs for certain contract interfaces. We're not too far off completing that.
The second string of work is improving the correctness of QuickJS, the library we use to run JS in contracts. We've run into some issues there so we've hired some compiler/interpreter experts to vet and improve it. They're just starting work now, when they're happy with the quality of the code we'll move this into beta. I'll post an estimate on how long that will take after they've gotten stuck into the code.
After that auditors will give the code one more pass and then we can move it from beta to release. This will probably take another 6-8 weeks.

@volovyks @DavidM-D Thank you guys! Good to know the plan. 😃
I have pinged David on Slack about QuickJS auditing, and happy to help to connect with some auditors if needed.

@think-in-universe @volovyks @DavidM-D, After reviewing, speaking with a few people and planning, I make the decision to move this project out of alpha stage! See #345

@think-in-universe @volovyks @DavidM-D, After reviewing, speaking with a few people and planning, I make the decision to move this project out of alpha stage! See #345


Minor luacheck fixes

Tweak the LuaCheck configuration.
Add GitHub workflow.

I'll push these changes upstream too.
@fluxionary

Ping?


URL in repository's description is broken

Repository's description has this URL: http://quantecon.org/julia_index.html. This is a "Page Not Found" error in QuantEcon.

Currently, repository's URL (next to description) points to http://quantecon.org/julia_index.html. It should be https://quantecon.org/quantecon-jl/ instead.

That's the fix for this.

@mvinoba @zdroid Thanks! Fixed.


Update README.md - installing Drupal 8

First ever pull request - please be gentle:)
I got very confused trying to override the default Drupal 9 installation. I'm proposing an addition to the README to add some clarification. It's far from perfect, there are a couple of additions I would like to make but don't know how to

I don't understand the relationship between drupal_major_version and drupal_composer_project_package. drupal_major_version seems to have no affect on the default install, but somewhere on the web (can't find it now) it is the recommended solution. Perhaps just an update to the default.config.yml to link the two variables together would help?

2, I would like to add a pointer to the available versions e.g. https://www.drupal.org/project/drupal/releases or  "For a specific version, use drupal/recommended-project:8.8.0.  For all available versions, use the shell with composer show drupal/recommended-project --all."

Looks great, was just missing one backtick, which I added pre-merge. Thanks!


The code should run from scratch for each variation (Scale, Resolution, ...)

The code should run from scratch for each variation.

Only the varied object and MET should be saved

The code should take profit of all other objects already calculated with nominal parameters.

done


Getting aggregated data for displaying charts

Hi,
we would like to use this library to render your charts on the web. Is there any easy way to downsample/aggregate the data like you do in your charts? Something like .AggregateChart() which returns x: and y: which can be passed to different chart libraries or other tools
Thanks for your help!

Hi @xkuyax,
I don't think I fully understand your question. This library is designed to accept data (e.g., double[] xs and double[] ys) and produce a Bitmap you can display (in a GUI) or save to disk (perhaps as a jpeg). I have used this library in Azure Functions to generate images to display on the web (here).
If you would rather use another charting library to display xs and ys on the web, you can pass that data into the other library and do not need to use ScottPlot.
If your question relates to client-side interactive charting with JavaScript, I recommend looking into Google Charts https://developers.google.com/chart/interactive/docs/gallery
Let me know if this helps, or if I am misunderstanding your question! Thanks
Scott

Hi @swharden , thanks for your very fast reply!
I have been looking at your example program, which generates the fftPower, freqs and times arrays, and feeds this into the ScottPlot.Plot()
I generated this myself for an wav File i got (30s, 44k SampleRate) which resulted in 1,4million doubles. Id rather not transmit that over the web, but instead calculate xs and ys (i guess thats the "downsampled" data?) and send this to my chart lib (and make an new call with different calculation parameters on scrolling to update the chart)
Basically what i want are 2 arrays:
X: (2.5 Hz, 5 Hz, 7.5 Hz,...)
Y: (-1, 2, 0, 1,) the fft values for the specified frequency in x (but averaged, like it is being down with your plot library)
Thanks!

Hey @xkuyax,
First off let me apologize - I got mixed up and thought this question was posted as a ScottPlot issue and now I see it is a FftSharp issue. This is why I was confused, but your queston makes more sense to me now that I realize my mistake. If you analyze 30s of FFT data it will be very slow and produce a very large amount of data (you noted 1.4 million points). These types of high resolution FFTs are rarely required, and as you have found are difficult to display.
You indeed can indeed downsample the data (taking every Nth point and dividing sample rate by N) prior to calling the FFT methods to achieve fast calculations and a result with a small number of points.
Alternatively, you can also divide your signal into many 1s chunks, calculate all the individual FFTs, and average them together. This process is typically accompanied by a windowing function so each chunk starts and ends at 0.
You may find my Spectrogram library helpful, as its purpose is to simplify the process of creating many small FFTs from a long recording. https://github.com/swharden/Spectrogram
Let me know if this helps solve your problem!

Also, it may help to review the quickstart source code which produces this output

https://github.com/swharden/FftSharp/blob/1e623b5aab99dbb60231a933c740b3df138caee2/src/FftSharp.Quickstart/Program.cs#L1-L68
You can see that double[] freqs and double[] fftPower and are the Xs and Ys you are probably trying to plot. Since they are simple arrays, you can plot them with any charting library. In the example I use ScottPlot, but alternatively you could send them to the browser to display interactively or something like that.
Hope it helps!
Scott


running aspnetcore app to azure app service suddenly return 502.5

Development environment:
dotnet version 1.0.0-preview2-003131
VS2015
A few days ago my application was normal，suddenly，service return HTTP Error 502.5 . I re-built an app service in azure, and deploy  the default VS2015 webapp template, but the error still exists。
I use KUDU to view the log, the error is as follows:
In Eventlog.xml:
Application 'MACHINE/WEBROOT/APPHOST/TECLINK' with physical root 'D:\home\site\wwwroot\'  failed to start process with commandline 'dotnet .\*.dll', ErrorCode = '0x80004005 : e0434352\
In stdout log:
warn: Microsoft.AspNetCore.Server.Kestrel[0]Unable to bind to http://localhost:5000 on the IPv4 loopback interface. System.AggregateException: One or more errors occurred. (Error -4092 EACCES permission denied)   ---> Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvException: Error -4092 EACCES permission denied    at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.Check(Int32 statusCode)    at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.tcp_bind(UvTcpHandle handle, SockAddr& addr, Int32 flags)    at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvTcpHandle.Bind(ServerAddress address)    at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.TcpListener.CreateListenSocket()    at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Listener.<>c.<StartAsync>b__6_0(Object state)    --- End of inner exception stack trace ---    at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)    at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)    at System.Threading.Tasks.Task.Wait()    at Microsoft.AspNetCore.Server.Kestrel.Internal.KestrelEngine.CreateServer(ServerAddress address)    at Microsoft.AspNetCore.Server.Kestrel.KestrelServer.Start[TContext](IHttpApplication1 application)
---> (Inner Exception #0) Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvException: Error -4092 EACCES permission denied
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.Check(Int32 statusCode)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.tcp_bind(UvTcpHandle handle, SockAddr& addr, Int32 flags)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvTcpHandle.Bind(ServerAddress address)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.TcpListener.CreateListenSocket()
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Listener.<>c.b__6_0(Object state)<---
warn: Microsoft.AspNetCore.Server.Kestrel[0]
Unable to bind to http://localhost:5000 on the IPv6 loopback interface.
System.AggregateException: One or more errors occurred. (Error -4090 EADDRNOTAVAIL address not available) --->
Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvException: Error -4090 EADDRNOTAVAIL address not available
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.Check(Int32 statusCode)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.tcp_bind(UvTcpHandle handle, SockAddr& addr, Int32 flags)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvTcpHandle.Bind(ServerAddress address)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.TcpListener.CreateListenSocket()
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Listener.<>c.b__6_0(Object state)
--- End of inner exception stack trace ---
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
at System.Threading.Tasks.Task.Wait()
at Microsoft.AspNetCore.Server.Kestrel.Internal.KestrelEngine.CreateServer(ServerAddress address)
at Microsoft.AspNetCore.Server.Kestrel.KestrelServer.Start[TContext](IHttpApplication`1 application)
---> (Inner Exception #0) Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvException: Error -4090 EADDRNOTAVAIL address not available
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.Check(Int32 statusCode)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.tcp_bind(UvTcpHandle handle, SockAddr& addr, Int32 flags)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvTcpHandle.Bind(ServerAddress address)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.TcpListener.CreateListenSocket()
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Listener.<>c.b__6_0(Object state)<---
fail: Microsoft.AspNetCore.Server.Kestrel[0]
Unable to bind to http://localhost:5000 on any loopback interface.
System.AggregateException: One or more errors occurred. (Error -4092 EACCES permission denied) (Error -4090 EADDRNOTAVAIL address not available) ---> Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvException: Error -4092 EACCES permission denied
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.Check(Int32 statusCode)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.tcp_bind(UvTcpHandle handle, SockAddr& addr, Int32 flags)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvTcpHandle.Bind(ServerAddress address)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.TcpListener.CreateListenSocket()
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Listener.<>c.b__6_0(Object state)
--- End of inner exception stack trace ---
---> (Inner Exception #0) Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvException: Error -4092 EACCES permission denied
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.Check(Int32 statusCode)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.tcp_bind(UvTcpHandle handle, SockAddr& addr, Int32 flags)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvTcpHandle.Bind(ServerAddress address)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.TcpListener.CreateListenSocket()
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Listener.<>c.b__6_0(Object state)<---
---> (Inner Exception #1) Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvException: Error -4090 EADDRNOTAVAIL address not available
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.Check(Int32 statusCode)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.tcp_bind(UvTcpHandle handle, SockAddr& addr, Int32 flags)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvTcpHandle.Bind(ServerAddress address)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.TcpListener.CreateListenSocket()
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Listener.<>c.b__6_0(Object state)<---`
What is causing the error? Thank you.

It shouldn't be trying to bind to http://localhost:5000 in azure/IIS.
Why are you still using 1.0 previews? We'll need you to repro this on released 1.0 or 1.1 bits before we can investigate.

@Tratcher hi, i use  the default VS2017 webapp template and dotnet sdk version is 1.1, but the problem still exists; then i try deploy the webapp to other azure account ,it's work ok!

Are the logs much different?

@Tratcher there are some different place,;
the normal one :
warn: Microsoft.AspNetCore.Server.Kestrel[0]       Unable to bind to http://localhost:30464 on the IPv6 loopback interface: (Error -4090 EADDRNOTAVAIL address not available) Hosting environment: Production Content root path: D:\home\site\wwwroot Now listening on: http://localhost:30464 Application started. Press Ctrl+C to shut down.
the another is :
warn: Microsoft.AspNetCore.Server.Kestrel[0]       Unable to bind to http://localhost:29330 on the IPv4 loopback interface: (Error -4092 EACCES permission denied) warn: Microsoft.AspNetCore.Server.Kestrel[0]       Unable to bind to http://localhost:29330 on the IPv6 loopback interface: (Error -4090 EADDRNOTAVAIL address not available) crit: Microsoft.AspNetCore.Server.Kestrel[0]       Unable to start Kestrel. System.IO.IOException: Failed to bind to address http://localhost:29330. ---> System.AggregateException: One or more errors occurred. (Error -4092 EACCES permission denied) (Error -4090 EADDRNOTAVAIL address not available) ---> Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvException: Error -4092 EACCES permission denied    at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.tcp_bind(UvTcpHandle handle, SockAddr& addr, Int32 flags)    at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvTcpHandle.Bind(ServerAddress address)    at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.TcpListener.CreateListenSocket()    at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Listener.<StartAsync>b__8_0(Object state)    --- End of inner exception stack trace ---    --- End of inner exception stack trace ---    at Microsoft.AspNetCore.Server.Kestrel.KestrelServer.Start[TContext](IHttpApplication1 application)
Unhandled Exception: System.IO.IOException: Failed to bind to address http://localhost:29330. ---> System.AggregateException: One or more errors occurred. (Error -4092 EACCES permission denied) (Error -4090 EADDRNOTAVAIL address not available) ---> Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvException: Error -4092 EACCES permission denied
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.tcp_bind(UvTcpHandle handle, SockAddr& addr, Int32 flags)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvTcpHandle.Bind(ServerAddress address)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.TcpListener.CreateListenSocket()
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Listener.b__8_0(Object state)
--- End of inner exception stack trace ---
--- End of inner exception stack trace ---
at Microsoft.AspNetCore.Server.Kestrel.KestrelServer.Start[TContext](IHttpApplication1 application)    at Microsoft.AspNetCore.Hosting.Internal.WebHost.Start()    at Microsoft.AspNetCore.Hosting.WebHostExtensions.Run(IWebHost host, CancellationToken token, String shutdownMessage)    at Microsoft.AspNetCore.Hosting.WebHostExtensions.Run(IWebHost host)    at dynavinteclink.Program.Main(String[] args) in E:\Work\web\dynavinteclink\dynavinteclink\Program.cs:line 26

@halter73 port conflicts?

The -4090 EADDRNOTAVAIL IPv6 failure is expected for app services.
Normally in the case of port conflicts, we would expect an -4091 EADDRINUSE, but in the case the port has already been reserved for something else by netsh or similar, we have seen -4092 EACESS in the past.

last day , i buy a Technical Support from azure , he said : the version on which my application is running is 2.0 preview version, which is only supported over github/forums. my issue is seems to be because of runtime version of the application, but they can not downgrade to older version. so they could not troubleshoot the issue further.

That command line seems a little suspect
dotnet .\*.dll

I changed my app service, and it's worked fine!

@TechHome-fuyanwen Can you provide some more details, please? I am facing the same issues.

Hot works for me

I'm having the same exception here. Can you give more details, please?

@JesseXia please open a new issue with your details.


chore: provide command to check size and treeshakability

Ref https://github.com/react-bootstrap/dom-helpers/pull/46#issuecomment-522676087
cc @jquense

thanks!


ConTravel: Could we move the order of confirming name and age first and address second? If the user changes their current address but then sees a DOB that is not theirs/makes them ineligible, they've wasted time to input new address.

This could be tested as part of UR to see what makes more sense

@irinapencheva Kate & I discussed on Thursday that actually this checking DOB should be a background task that the user does not see. It is an extreme edge case that verify would return an incorrect address and thus I don't think we should include a step where the user can change their DOB. We will still include the page about communicating to the user that they are not eligible because of age - and we will add to this page the contact details for the LA.

@kaydale - sounds good, are you updating the comments spreadsheet or shall I as that was a council comment?


Leaner INotebook

Found this while working on a interactive window issue (found some code that initializes the cwd for the kernel in interactive window, however the exact same code is already in the new kernel code, removed that code from INotebook as it was only used in IW but the new code moved to IKernel).
While doing that I found more stuff that could be removed from INOtebook & now we have just 2 properties and 1 method on INotebook (session, connection & dispose)

Codecov Report

Merging #7979 (ec348aa) into main (94d6ccc) will decrease coverage by 0%.
The diff coverage is 70%.

@@          Coverage Diff          @@
##            main   #7979   +/-   ##
=====================================
- Coverage     70%     70%   -1%
=====================================
  Files        364     364
  Lines      22374   22283   -91
  Branches    3411    3399   -12
=====================================
- Hits       15825   15750   -75
+ Misses      5168    5156   -12
+ Partials    1381    1377    -4

Impacted Files
Coverage Δ

src/client/datascience/baseJupyterSession.ts
70% <0%> (-1%)
:arrow_down:

...datascience/editor-integration/cellhashprovider.ts
72% <ø> (+1%)
:arrow_up:

...tascience/jupyter/kernels/kernelCommandListener.ts
57% <ø> (ø)

src/client/datascience/types.ts
100% <ø> (ø)

src/client/datascience/webviews/webviewHost.ts
79% <ø> (ø)

src/client/debugger/jupyter/debuggingManager.ts
56% <ø> (ø)

src/client/datascience/raw-kernel/rawSession.ts
63% <42%> (+<1%)
:arrow_up:

src/client/datascience/jupyter/kernelVariables.ts
55% <50%> (-2%)
:arrow_down:

.../kernel-launcher/localKnownPathKernelSpecFinder.ts
73% <50%> (-9%)
:arrow_down:

...notebook/intellisense/jupyterCompletionProvider.ts
59% <58%> (-1%)
:arrow_down:

... and 24 more


[Snyk] Security upgrade mlflow from 1.30.1 to 2.3.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

requirements.txt

⚠ Warning
mlflow 1.30.1 requires scipy, which is not installed.
databricks-cli 0.17.7 has requirement urllib3<2.0.0,>=1.26.7, but you have urllib3 2.0.2.
pytoolconfig 1.2.5 has requirement packaging>=22.0, but you have packaging 21.3.

Vulnerabilities that will be fixed
By pinning:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

823/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 8.6
Relative Path Traversal SNYK-PYTHON-MLFLOW-5488283
mlflow:  1.30.1 -> 2.3.1
No
Proof of Concept

661/1000  Why? Recently disclosed, Has a fix available, CVSS 7.5
Directory Traversal SNYK-PYTHON-MLFLOW-5508649
mlflow:  1.30.1 -> 2.3.1
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Relative Path Traversal

Codecov Report
Patch and project coverage have no change.

Comparison is base (845ad91) 100.00% compared to head (a1f4948) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff            @@
##            master      #421   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           28        28
  Lines          960       960
=========================================
  Hits           960       960

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


DistributedBackgroundService sometimes fail to acquire lock

The DistributedBackgroundService sometimes throws an exception trying to insert the lock record into the database (violated PK constraint).

Mitigated improving locks robustness and not logging useless errors related to normal concurrency issues that may occur in such scenario.


Remove cardano-api dependency

db-sync mainly uses directly the ledger and the ledger-api. However it still depends on cardano-api on some parts. Cardano-api has recently moved to a separate repository https://github.com/input-output-hk/cardano-api and it's questionable how fast it will be upgraded after node is released. We should try to completely drop our dependency to it, so that it doesn't block future node integrations.

Interesting, I thought node & CLI had strong dependency on cardano-api, so the work on cardano-api would be locked prior to node being tagged


/vcsLoad no longer parses non-integers

In Dafny 3.5.0, /vcsLoad:0.5 now fails with Error: Invalid argument "0.5" to option /vcsLoad. This seems to be due to a regression in Boogie.
I don't have the setup to run Boogie tests directly, but looking at the code I think this call is suspicious:
https://github.com/boogie-org/boogie/blob/b090548f4c5e2b444b61884fb5b17f3fadf0a12c/Source/ExecutionEngine/CommandLineOptions.cs#L1422-L1424
There's no variant of GetNumericArgument that takes an Action<double>, so I don't know how this type-checks (is C# unsoundly casting it to Action<int>?). From the current API of CommandLineParseState I think this is the version to use:
https://github.com/boogie-org/boogie/blob/b090548f4c5e2b444b61884fb5b17f3fadf0a12c/Source/ExecutionEngine/CommandLineParseState.cs#L308-L312

There's no variant of GetNumericArgument that takes an Action<double>, so I don't know how this type-checks (is C# unsoundly casting it to Action<int>?).

x: int => load = x is a well-typed Action<int>; the cast happens when assigning to load.  The bug was introduced in 7867a2ef as a side effect of removing ref parameters (cc @keyboardDrummer):
         case "vcsLoad":
           double load = 0.0;
-          if (ps.GetNumericArgument(ref load))
+          if (ps.GetNumericArgument(x => load = x))
           {

The Dafny part makes sense. Not sure if you want to go back to ref load to the option parsing code or add an Action<double> variant to GetNumericArgument.
I shouldn't be surprised that the interaction of specialized type implementations, type inference, and capturing a reference would lead to confusing behaviors.

Thanks for reporting. I will look at fixing this. Seems like avoiding overloaded method names in this instance will help prevent bugs like this in the future.


Use Tokamak as front for creating libs.

Idea. Why creating something different? When you can use already existing engine/core SwiftUI
which fro open source is called Tokamak?
To build renderer for SwiftUI you can find more info here
There is implementation happening based on GTK. You can see their example here
However, I much prefer SDL2 due to its portability. It can be of use for Android, Linux, iOS, Windows and others.
Let me know what do you think.
I'm open to conversation & help If you are keen.
Does your dependency compile for other platforms? Are they limited to some?

I looked at Tokamak and it seems like we should have a conversation. I'll come on the Discord that is linked in the Tokamak repo.
Most dependencies should compile on Windows. The most important ones are SDL and NanoVG. I don't know how CombineX will behave.

What is your name on discord?

same as here on GitHub


Konnected receiving "Object IDs not unique" after 0.90 upgrade.

Home Assistant release with the issue:

Last working Home Assistant release (if known):
0.87
Operating environment (Hass.io/Docker/Windows/etc.):

Windows 10
Component/platform:

konnected.io
Description of problem:
Receiving "Object IDs not unique" for all the Konnected devices.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

konnected:
  access_token: 123456789
  api_host: http://homeassistant.weather-station.org:8123
  devices:
    - id: 84f3eb185940
      host: <IP_ADDRESS>
      port: 9595
      binary_sensors:
        - zone: 1
          type: door
          name: Front Door
        - zone: 2
          type: door
          name: Garage Entry Door
        - zone: 3
          type: door
          name: Kitchen Sliding Door
        - zone: 4
          type: window
          name: Kitchen Windows
        - zone: 5
          type: window
          name: Family Room Windows
        - zone: 6
          type: window
          name: Dining Room Windows
      switches:
        - zone: out
          name: Siren
    - id: 68c63ae166b8
      host: <IP_ADDRESS>
      port: 22771
      binary_sensors:
        - zone: 1
          type: window
          name: Foyer Window
        - zone: 2
          type: window
          name: 1st Floor Bedroom Windows
        - zone: 3
          type: window
          name: Basement Windows
        - zone: 4
          type: door
          name: Basement Sliding Door
        - zone: 5
          type: motion
          name: Foyer Motion Sensor
#        - zone: 6
#          type: window
#          name: Living Room Windows
      switches:
        - pin: 8
          name: 'Beep Beep'
          momentary: 150
          pause: 65
          repeat: 2
        - pin: 8
          name: 'Warning'
          momentary: 500
          pause: 80
          repeat: -1
    - id: 807d3a3e0c7b
      host: <IP_ADDRESS>
      port: 12066
      binary_sensors:
        - zone: 1
          type: window
          name: Living Room Windows
      switches:
        - pin: 8
          name: 'Beep Beep 2'
          momentary: 150
          pause: 65
          repeat: 2
        - pin: 8
          name: 'Warning 2'
          momentary: 500
          pause: 80
          repeat: -1

Traceback (if applicable):

Additional information:

I have this error for Konnected integration in 0.90.1: Error doing job: Future exception was never retrieved

as a result the hass IP is not reaching the konnected node. so I cannot get the konnected node to communicate with my HASS (I just changed the VLAN on which HASS runs)

CC @heythisisnate

I would add the the last working version was 0.88

I will look into this.

So to be clear. Once the device has been configured it continues to work and send and get state changes. But initial config is when this error is thrown

For me the sensors are very slow to change the state (HA version 0.90.1). For example after opening and closing the door HA is still showing door as open.. In 0.89 everything was working fine.

for those of you who are getting the KeyError: 'settings' error message, this is resolved by updating the Konnected device firmware: https://help.konnected.io/support/solutions/articles/32000023470-flashing-konnected-firmware-software

for those of you who are getting the KeyError: 'settings' error message, this is resolved by updating the Konnected device firmware to version 2.2.5 or newer (the latest version is 2.2.6): https://help.konnected.io/support/solutions/articles/32000023470-flashing-konnected-firmware-software (cc @TSparkas)
The Object IDs not unique error appears to be a bug and I am working on a fix.

Firmware update solved KeyError: 'settings' error message. However Konnected sensors are not working correctly for me. States are not changing for several minutes, showing door is always opened for example, but in reality it's closed. Any ideas what is wrong?

The original duplicate unique_id issue should be fixed in PR #22389. I introduced unique_id for each entity in the 0.90 release, but there was a bug where the same unique_id would be generated for multiple switches configured using the same pin/zone as @MarkHofmann11 has done in his configuration above. The fix is to generate unique_ids more ... uniquely 😉

@TSparkas check to make sure you're not inadvertently using your external endpoint with SSL for the Konnected communication. This causes latency and memory issues as the external endpoint requires SSL negotiation. For best performance, Konnected should communicate with the HA api via regular (un-secured) HTTP over your local wireless LAN.

@heythisisnate I use Nginx to serve SSL/TLS and everything was working fine until update to 0.90.1. Problems started after upgrade.

@TSparkas I have not been able to reproduce the problem that you're describing on 0.90.1. In any case, it's unrelated to the topic of this Github issue which has to do with non-unique entity ids, so it's not appropriate to discuss in this thread.
If you have made a purchase from Konnected, feel free to reach out to<EMAIL_ADDRESS>and we'll help you debug.

@heythisisnate does this apply for the alarm interface panel too? I am getting the same stack on home assistant.

@vajonam Yes. The firmware/software is the same for both of our hardware products.

can confirm

for those of you who are getting the KeyError: 'settings' error message, this is resolved by updating the Konnected device firmware to version 2.2.5 or newer (the latest version is 2.2.6): https://help.konnected.io/support/solutions/articles/32000023470-flashing-konnected-firmware-software (cc @TSparkas)

is fixed on alarm interface panel as well.


Train on custom data set

Hey pvtien,
I am desperately looking for a guide of how to train the deep sort on a custom dataset.
I saw your github and you have done some very nice work. As I understand the default deep sort is trained on humans but you did trained it with hands.
Could you please give me a guideline of how to procceed with it.
I am also using detectron2 for my detections.
Thanks a lot.

@geosaRW Yes, you're right.
At first I read many sources related to customize deepsort.
I base my deep appearance descriptor mainly on this repo.
But it still requires some tricks, you need a re-identification dataset, put each id in a folder (I read these on a chinese web but I currently forget the link)
Or you may want to refer deepsort for vehicle, many paper for this problem are published.
Glad to help!


Tracking issue: improve error handling

A number of errors get surfaced to the user via our UI that shouldn't be displayed the way they are. This tracking issue is for all the places where errors can be improved. Please add to it as more come to mind.

[x] #517
[x] #519
[x] #520
[x] #547
[x] #571

Can this tracking issue be closed?

Yep, done


jdk8u192-b12 Windows x64 Build doesn't work on my Windows 10 Enterprise machine

When I try to run java.exe (or anything else that use the jvm), I run into the following error:
Error: loading: C:\Temp\jdk8u192-b12\jre\bin\server\jvm.dll

jdk8u181-b13 works on the same machine
I confirmed that the checksum of the downloaded zip file is correct.
The version of Windows 10 Enterprise is Version 1803 (OS Build 17134.376)
I have been able to successfully run the same binary on a Windows Server 2008r2 machine.
@karianna suggested that I report the bug.
Please let me know what other information I can provide to help debug this.

@datallah Can you test the binary at https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-windows-x64-hotspot/74/ please

@datallah Can you test the binary at https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-windows-x64-hotspot/74/ please

That build works

resolved!


Event listening improvements

I offer some improvements for event handling:

Virtual events which eliminates different behavior between user-agents.
Listening events only on root node to reduce number of DOM API calls.

Are there any ideas about it?
Of course I haven't implemented this at current time, but I can help to do this, if it's really necessary.

I dislike both ideas. virtual events are not useful for remotely modern browsers. The performance improvement of listening on the root node only is actually a poor optimization that increase bloat since you have to create hooks for elements instead of native event handlers.

These features are not important for me (which is why they are not in Snabbdom already). But I understand that they are useful in certain use cases.
The Snabbdom core does not handle events at all. I think that these features could be implemented as new Snabbdom event module. And doing that would be very interesting.

In case of huge number of nodes, each of which requires own listener, we inevitably will have a drawdown of performance. And the reason of this behavior is a nature of a DOM API, not a browser implementation.

Hey guys, fly on the wall here :)
First, @paldepind snabbdom is an awesome vdom lib...i've evaluated many others and most have awkward ergonomics or are slow. I'm very impressed with how much it can do performance for its size.
Second, @katyo, @AlexGalays you guys may consider evaluating domvm [1]. It's not a pure vdom lib but sits somewhere between Mithril and and domchanger/snabbdom. It addresses many issues/use-cases I've been seeing crop up repeatedly in the vdom landscape, including this event delegation one. @paldepind, feel free to steal any good ideas from domvm if you find any which fit snabbdom, though I think architecturally they're pretty different but template ergonomics are similar.
cheers!
[1] https://github.com/leeoniya/domvm

@katyo  Did you benchmark it? "Huge number of nodes" is probably a bad sign in the first place; this is usually seen in big lists where windowing/occlusion culling/infinite scrolling should be implemented in the first place. I just can't see this ever being a bottleneck; Modern browsers manage to set a simple reference to a event handler function on every node just fine; the overhead is minuscule. Not to mention event delegation brings its lot of problems with it like akward event stopPropagation behavior.

@AlexGalays

"Huge number of nodes" is probably a bad sign in the first place;

except of course when you need a huge number of nodes...like a 10k cell spreadsheet grid [1].
[1] http://leeoniya.github.io/domvm/test/bench/patch/

You never need a huge number of nodes. It's always a very bad idea. You would have to pay the cost of building a monster vdom every repaint, the browser wouldn't like it very much either (layout and GC)
On google spreadsheet with a MacBookPro 15' I can only see 14*25 = 350 cells; No need to render many more than that. Your 10k cell spreadsheet is fine as a benchmark, not as an example of a real life scenario that demands event delegation.

Fair point, but a couple notes.
In the bench there is no full vtree rebuild, that would be ridiculous. This bench specifically shows the individual vnode patching functionality which just runs the diff on the explicit cell you ask it to.
The complexity and payload difference between being able to just render a huge table and implementing multi-axis culling code for tabular data is enormous. If you can have performance and simplicity, then why not?

Fair point too :)