truenas.service doesn't seem to enable services

setup:

TrueNAS-13.0-U5.3 (running through virt manager)
ansible collection arensb.truenas version 1.7.0
ansible version 2.15.2

for some reason, it doesn't seem to start services I have defined
this is my roles/truenas/tasks/main.yml that I'm using
---
- name: Create an ordinary user and their group
  arensb.truenas.user:
    name: testuser
    create_group: true
    sudo_commands: ALL
    password: "testpwd"

- name: Configure NFS exports
  arensb.truenas.sharing_nfs:
    enabled: true
    name: media nfs share
    path: /mnt/tank/data/media
    maproot_user: testuser
    maproot_group: testuser

- name: Enable NFSv4
  arensb.truenas.nfs:
    nfsv4: true

- name: Enable services
  arensb.truenas.service:
    name: "{{ item }}"
    enabled: true
    state: started
  with_items:
    - ssh
    - nfs

The last step is to enable ssh and nfs. SSH is already started which allows ansible to run, but it doesn't enable it. Also it doesn't seem to enable and start the nfs service.
Running ansible-playbook -vvv playbooks/truenas.yml gives me
<EMAIL_ADDRESS>ESTABLISH SSH CONNECTION FOR USER: None
<EMAIL_ADDRESS>SSH: EXEC ssh -C -o ControlMaster=auto -o ControlPersist=60s -o KbdInteractiveAuthentication=no -o PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o ConnectTimeout=10 -o 'ControlPath="/home/paulo/.ansible/cp/e04ab7b04b"'<EMAIL_ADDRESS>'/bin/sh -c '"'"'chmod u+x /root/.ansible/tmp/ansible-tmp-1691781720.9827127-9421-115081788509640/ /root/.ansible/tmp/ansible-tmp-1691781720.9827127-9421-115081788509640/AnsiballZ_service.py && sleep 0'"'"''
<EMAIL_ADDRESS>(0, b'', b'')
<EMAIL_ADDRESS>ESTABLISH SSH CONNECTION FOR USER: None
<EMAIL_ADDRESS>SSH: EXEC ssh -C -o ControlMaster=auto -o ControlPersist=60s -o KbdInteractiveAuthentication=no -o PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o ConnectTimeout=10 -o 'ControlPath="/home/paulo/.ansible/cp/e04ab7b04b"' -tt<EMAIL_ADDRESS>'/bin/sh -c '"'"'/usr/local/bin/python3.9 /root/.ansible/tmp/ansible-tmp-1691781720.9827127-9421-115081788509640/AnsiballZ_service.py && sleep 0'"'"''
<EMAIL_ADDRESS>(0, b'\r\n{"changed": false, "msg": "", "service_id": 11, "name": "ssh", "enabled": false, "state": "RUNNING", "pids": [1540], "invocation": {"module_args": {"name": "ssh", "enabled": true, "state": "started", "ha_propagate": null}}}\r\n', b'Shared connection to <IP_ADDRESS> closed.\r\n')
<EMAIL_ADDRESS>ESTABLISH SSH CONNECTION FOR USER: None
<EMAIL_ADDRESS>SSH: EXEC ssh -C -o ControlMaster=auto -o ControlPersist=60s -o KbdInteractiveAuthentication=no -o PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o ConnectTimeout=10 -o 'ControlPath="/home/paulo/.ansible/cp/e04ab7b04b"'<EMAIL_ADDRESS>'/bin/sh -c '"'"'rm -f -r /root/.ansible/tmp/ansible-tmp-1691781720.9827127-9421-115081788509640/ > /dev/null 2>&1 && sleep 0'"'"''
<EMAIL_ADDRESS>(0, b'', b'')
ok<EMAIL_ADDRESS>=> (item=ssh) => {
    "ansible_loop_var": "item",
    "changed": false,
    "enabled": false,
    "invocation": {
        "module_args": {
            "enabled": true,
            "ha_propagate": null,
            "name": "ssh",
            "state": "started"
        }
    },
    "item": "ssh",
    "msg": "",
    "name": "ssh",
    "pids": [
        1540
    ],
    "service_id": 11,
    "state": "RUNNING"
}
...
...
<EMAIL_ADDRESS>ESTABLISH SSH CONNECTION FOR USER: None
<EMAIL_ADDRESS>SSH: EXEC ssh -C -o ControlMaster=auto -o ControlPersist=60s -o KbdInteractiveAuthentication=no -o PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o ConnectTimeout=10 -o 'ControlPath="/home/paulo/.ansible/cp/e04ab7b04b"' -tt<EMAIL_ADDRESS>'/bin/sh -c '"'"'/usr/local/bin/python3.9 /root/.ansible/tmp/ansible-tmp-1691781721.2552562-9421-21221030135877/AnsiballZ_service.py && sleep 0'"'"''
<EMAIL_ADDRESS>(0, b'\r\n{"changed": false, "msg": "", "service_id": 9, "name": "nfs", "enabled": false, "state": "STOPPED", "pids": [], "invocation": {"module_args": {"name": "nfs", "enabled": true, "state": "started", "ha_propagate": null}}}\r\n', b'Shared connection to <IP_ADDRESS> closed.\r\n')
<EMAIL_ADDRESS>ESTABLISH SSH CONNECTION FOR USER: None
<EMAIL_ADDRESS>SSH: EXEC ssh -C -o ControlMaster=auto -o ControlPersist=60s -o KbdInteractiveAuthentication=no -o PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o ConnectTimeout=10 -o 'ControlPath="/home/paulo/.ansible/cp/e04ab7b04b"'<EMAIL_ADDRESS>'/bin/sh -c '"'"'rm -f -r /root/.ansible/tmp/ansible-tmp-1691781721.2552562-9421-21221030135877/ > /dev/null 2>&1 && sleep 0'"'"''
<EMAIL_ADDRESS>(0, b'', b'')
ok<EMAIL_ADDRESS>=> (item=nfs) => {
    "ansible_loop_var": "item",
    "changed": false,
    "enabled": false,
    "invocation": {
        "module_args": {
            "enabled": true,
            "ha_propagate": null,
            "name": "nfs",
            "state": "started"
        }
    },
    "item": "nfs",
    "msg": "",
    "name": "nfs",
    "pids": [],
    "service_id": 9,
    "state": "STOPPED"
}

Notice that ansible doesn't return errors, but returns state: STOPPED when it shouldn't

it looks like the code to start the service is commented out
https://github.com/arensb/ansible-truenas/blob/main/plugins/modules/service.py#L165-L167
similarly for enabling
https://github.com/arensb/ansible-truenas/blob/main/plugins/modules/service.py#L194-L202

Looks like you're right. This looks like a module that wasn't released; it escaped prematurely.

I believe this is fixed on the bugfix/6-services branch. @paulo-erichsen, can you please try it out and see if it works for you?

sorry for taking a while to get back. I was out of town for a few days.
I've tried the updated code and it looks good with one caveat.
The NFS service is able to start, but I think it takes a second or so to turn on. I see ansible returning
changed<EMAIL_ADDRESS>=> (item=nfs) => {
    "ansible_loop_var": "item",
    "changed": true,
    "enable_err": 9,
    "invocation": {
        "module_args": {
            "enabled": true,
            "ha_propagate": null,
            "name": "nfs",
            "state": "started"
        }
    },
    "item": "nfs",
    "msg": "service started; service enabled",
    "service_state": {
        "enabled": false,
        "id": 9,
        "name": "nfs",
        "pids": [],
        "state": "STOPPED"
    }
}

I would expect it to not show "state": "STOPPED", but it does start eventually. I guess this is fine as is

Oh! This isn't a bug, or at least not the bug you think it is: the service_state field in the return value is from the beginning of the module, when it's checking to see whether it needs to do anything, not from the end when the service has been started.
In other words, what it's showing you here is that the service was in "state": "STOPPED", which is why it decided that it needed to make a change, and start the service.

that makes sense, thanks for the clarification!


possible fix for gridview checkall name

https://github.com/yiisoft/yii/issues/3810

What about adding option for checkAll name (for example in headerOptions) if someone needs custom name?

@SDKiller not sure, that we need it now. May be added later on request.
@cebe looks good as for me. We can merge this after fixinx minor comment of @samdark


Fix issue with new grids setting

Some pages have example data which is a string while most are dictionaries. The code that checked
for a grid being set per-example assumed they were dictionaries so was breaking.

:+1:


Article says 'Web site' not 'Website'

http://www.freecodecamp.com/field-guide/what-is-the-free-code-camp-privacy-policy
Specifically, the subheading 'Links to other Web sites' has an unnecessary and incorrect space.

Thanks @MysteriousManfred,
I'm not sure this is an issue, but the privacy policy is now a github wiki page so you may edit it if you feel like it is still incorrect.


Fixed #10: allowed accept header override for MarkLogic

#10
Making it work for MarkLogic was no particular rocket-science. I started with disabling jsonp, which was just a flag in the profile. Next I had to add accepts to all ajax calls. You include accepts as follows in your profile:
        MarkLogicProfile.connection = {
          // http matches all http requests, so this will be the only connection settings used
          'http:': {
            endpoint: '/v1/graphs/sparql',
            accepts: {
              json: 'application/sparql-results+json'
            },
            description: {
              en: 'MarkLogic LodLive'
            }
          }
        };

See also: https://github.com/grtjn/ml-lodlive-ng/blob/master/src/ml-lodlive-profile-factory.js#L108

Nice solution! I was tweaking the ajax object via angular which was no good.  This looks much better.


ciano: init at 0.2.4

Motivation for this change
Closes #134847
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I have read expression from other distros.  I will try to use a virtual machine with one of them.


Add examples for slices

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.64%.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   98.64%   98.64%
=======================================
  Files          12       12
  Lines         591      591
=======================================
  Hits          583      583
  Misses          8        8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Default Bounds stream to None

Any arbitrary default values are unlikely to really make sense and Bounds should also allow None in other cases.

Any arbitrary default values are unlikely to really make sense

Well, I already made use of these values in a Bounds stream I used - my code snapped to the nearest available key which meant any value would do.
I also have a vague memory of the default of NumericTuple being specified as None actually becomes (None, None) or a similar tuple of the specified length. If that is true, then the length should be specified as four and the default is really (None,None,None,None).
I might be wrong but this is worth checking. If it really is None, I can merge and then update the code that made use of this default value.

It really is None.

Must be remembering an old param bug then. Merging.


docs: Add V3 to V4 Parameter Migration Guide

Pull Request Key Information
Reason for change
Much has changed from LDAR-Sim v3 to LDAR-Sim v4.
What was changed
Created a new document that outlines the key changes in parameters and inputs from v3 to v4.
Intended Purpose
Help users navigate the move to V4
Level of version change required
N/A
Testing Completed
N/A
Target Issue
N/A
Additional Information
N/A

Great job overall!
Instead of another folder for Version Migration Guides, could we rename the Feature Guides folder to Other Guides and move these parameter migration guides in there? I feel like there's too many folders... Also, the User manual section needs to be updated - specifically the section called file structure.

Make new folder guides with subfolder for different guide types. I know the user manual is going to be updated at some point, this will need to be update with it.


Allow TOC element to be fully customizable

[TOC]
# Header 1

will currently generate the following HTML:

Header 1

Header 1

The div element cannot be changed and so it is for the title span element and its toctitle class.
I suggest that other config parameters (toc_tag, title_class, title_tag) that defaults to their current defaults are introduced.
This would be very useful for producing semantic HTML, using specific HMTL elements.
For example to use the details disclosure element as toc, the extension could be called like so:
md = markdown.Markdown(extensions=[TocExtension(
    title='Summary',
    title_class="",
    title_tag="summary",
    toc_class="",
    toc_tag="details"
)]]

Summary

Header

Header

This will render an initially closed details element with a summary:

Summary

Header

Header

If I had to guess, number 2 is probably the big motivating factor driving this request. There are plenty of documentation sites that I've seen showing tables of contents in this fashion (with details).  The idea of generating TOC in a details vs a div doesn't seem that out there to me, but I understand the idea that this could be implemented as an external extension as well. I don't think that I personally have an issue with the request.
I'm not entirely sure how many different ways people want to generate TOCs though either, does it need to be fully configurable to any tag? Or is just an alternative details mode sufficient?

Thanks for your feedback.
My final goal is to add a way to generate the table of contents using the "details" element and I have proposed a flexible and retro-compatible implementation, but I guess that is not the only one possible.
For instance:

Do you think it might be a better solution to directly replace the classic "div" element with "details" and "span" with "summary" (not retro-compatible) ?
Or would you rather just add a boolean key in the configuration to choose between the "div" and "details" toc version (reto-compatible) ?

First, I will note that this is certainly not the first request to alter the markup for TOC. However, previous requests have asked for different changes (like not using a UL, for example). The most flexible approach would be to provide some sort of templating option (user provides a template with a default fallback). However, that adds an additional layer of complexity that we don't want to deal with. However, I think it would make for a great third-party extension and could possibly be popular with a subset of our users. Personally, I think that would be the most desirable solution from my perspective.
The original purpose of the existing extension was to mirror the behavior of preexisting extensions for other implementations (PHP Markdown Extra and MultiMarkdown specifically). As far as I am aware, of the three, ours is already the most flexible in its output. I feel like allowing configuration of the markup is perhaps a step to far. That is, unless you can point to other pre-existing implementations which do so.

I understand your point of view, but I think it's good that Python Markdown has evolved from its original purpose. I would suggest improving further without being swayed if the other extensions are stuck on older HTML versions.
Looking at my PR code at the moment, I don't see any unwanted effects, but it is possible that I may not be able to understand all the implications of my proposed change. If so, thank you anyway for the time dedicated to this review and obviously to all the work done.
My original intent was just to try to make an improvement contribution to a library that I have been using for long time.

Looking at my PR code at the moment, I don't see any unwanted effects, but it is possible that I may not be able to understand all the implications of my proposed change

No that's not it. Your changes look good. It's more about scope.
Perhaps I should have begun by pointing to the toc_tokens attribute. As documented, a nested list of tokens are available in addition to the preformatted  HTML. From that list of tokens, one can format their own TOC using whatever tools they are use to wrap the HTML output of Markdown. In fact, since that feature was added, I have been hesitant to add any additional features which modify the default output. Using toc_tokens  is preferred.
In other words, it is possible to do what you want without any modifications to the extension. so long as you don't use the `[TOC]' marker. In my experience, having the TOC separate from the body content is preferable in most environments anyway.
Except for backward compatibility reasons, I would prefer to remove any options which are used solely to modify the HTML output of the TOC and require all such modifications to make use of the toc_tokens to build a custom formatted TOC.

... Your changes look good. It's more about scope.
Perhaps I should have begun by pointing to the toc_tokens attribute ...

The goal of my contribution was to get markdown files that already contain the [toc] statement to be rendered with more modern HTML code with as little effort as possible for the user of this library.
I don't understand how I can use toc_tokens to get a table of contents that uses the details and summary elements without modifying existing files.
Your point about scope is not clear to me, but I accept if as a maintainer you want to reject my PR and close this issue.
BTW thanks to maintain this great library.

Your point about scope is not clear to me,

The concern is that if we allow the user to customize some of the generated markup, then the user will understandable ask to be able to change other parts of the generated markup. To avoid that, we don't include support for changing any of the markup. That feature is out-of-scope for this extension. If a user wants to use different markup, then they need to use a different solution.
The different solution that we provide is toc_tokens. Of course, that means not using the [toc] marker which, yes, means that you would need to edit/make changes to your documents and templates. Although, you could disable the toc extension's marker option and create your own extension which gets the toc_tokens from the toc extension and uses that to build your custom markup and swap that in for the marker. There would be no need to edit your files then.
I'm closing this as wontfix.


[system_mmap] Fix case where memory is not from zero

Hi @vvaltchev
linear_map_mem_region() previously had an assumption that the memory physical address would start at zero, but that assumption no longer applies.

Thanks @aenrbes, it makes sense.


LpSpec::__Pac attribute to be set on IsReadOnly:=False

UML still to be corrected.
+yang.4 already fixed.

IsReadOnly stereotype of _pureEthernetStructure_Pac attribute has been set on false.


I didn't find any instructions on how to build this Library on MSVC.

Hi hanickadot, thanks for this library at first.
We want to build this lib on MSVC, but I didn't find any instructions. Could you tell me where I can get it? Or can you provide the build steps for me? If you need any other question please let me know. Thank you very much.
Our environment: VS 2017 + Windows Server 2016

If you have MSVC at least version 15.8.8. Just include the single-header/ctre.hpp in your code and compile your project with /std:c++latest. The library is header only.

@hanickadot,  thank you for your reply. Actually, I mean we want to treat this lib as a standalone project that can be built separately in MSVC, instead of how to use this lib in the other projects.
This is a good project for constexpr, so we (MSVC team) are trying to add this project to our RWC (real world code) testing to detect regressions from MSVC, can you help provide build document? Like this: https://www.tensorflow.org/install/source_windows. Thank you in advance.

Ah, sorry. I do understand you now. I near future I should have a cmake project for the library and tests. Or if you want, just compile all tests: tests/*.cpp (not the subdirectories). Try to use latest tag, sometimes due my recklessness I break the master branch.

Glad to hear that, waiting for you to complete cmake project. :)

Hi, sorry for delay...
build with cmake with -DENABLE_CTRE_SELF_TEST=ON and then build target ctre_self_test
Please let me know if it's enough for you.

Wow, thank you very much. Please keep this issue active, I will have a comment once I get result.

@QuellaZhang just pinging you to ask for status :)

Hey, sorry for the late. We have added the project to our test suite. JonCaves provides patch to fix issues under c++20. Feel free to close this issue.
patch: ctre_test_error_c3688.patch.txt


how to remove the space between numbers before submit?

hi,
I need to save a number without space between numbers. how I can remove the space between numbers before submit and after submit completely reformat numbers?

Hi @nekooee , you can do so like this before sending the phone number
var phone = this.phone;
phone = phone.replace(/\s+/g, '');

Hi @nekooee , you can do so like this before sending the phone number
var phone = this.phone;
phone = phone.replace(/\s+/g, '');

Hi @Timibadass, a phone number is a bind to form and if I remove space manually, in the phone field change too. I need to remove space between numbers before send and reformat it after sending the form. Currently, I force remove space between the number on the server-side.

@nekooee , the above format wouldhelp you remove the space..if you use it just before attaching the phone to the body of the request.An example would be
sendPhoneToServer() {  var phone = this.phone; phone = phone.replace(/\s+/g, ''); axios.post(url,{ phone: phone }) }

@Timibadass I send all form fields with an array that bind to form. for example:
  data() {
            return {
                formContent: {},
                errors: {},
            }
        },
 methods: {
            onSubmit() {
                axios.post(`admin/roles`, this.formContent)

That's why I can not replace my own variable.

Now we use awesome-phonenumber behind the scene. @nekooee you can listen to the input event and use anything available from the returned object. Here is a sample:
{
  "canBeInternationallyDialled": true,
  "number": {
      "input": "0707123456",
      "international": "+46 70 712 34 56",
      "national": "070-712 34 56",
      "e164": "+46707123456",
      "rfc3966": "tel:+46-70-712-34-56",
      "significant": "707123456"
  },
  "regionCode": "SE",
  "valid": true,
  "possible": true,
  "type": "mobile",
  "possibility": "is-possible"
}

happens the same to mwe @nekooee . I am also using a form variable to get all inputs and send them to server. How did you solve it ?
TY

happens the same to mwe @nekooee . I am also using a form variable to get all inputs and send them to server. How did you solve it ?
TY

This is a long time ago and I do not remember how I used it. Maybe I upgraded to a new version.

happens the same to mwe @nekooee . I am also using a form variable to get all inputs and send them to server. How did you solve it ?
TY

This is a long time ago and I do not remember how I used it. Maybe I upgraded to a new version.


Support non-movable types

The standard doesn't require the target object to be move-constructible. It only says

if is_move_constructible_v<VT> is true, VT meets the Cpp17MoveConstructible requirements.

https://eel.is/c++draft/func.wrap.move.ctor#7
This implies that if a type is not move-constructible, it needs to be stored in the heap so that move_only_function can relocate it rather than move.

That line is too long /facepalm


Properties vs Methods in interfaces

While browsing the code, one of the first things that will be come across is this file.
Personally I was very confused at the beginning as to how it all works. I did find that the implementation is here, but it is not clear if methods like public void Use(Func<Task<T>> control) { _control = control; } would ever do more then just set the field.
If it is true that they will only be setting/getting the method to be scienced, then I would like to propose changing the interfaces to declare properties and not methods.

In its current implementation using the methods offers the ability to pass a Func<T> into the method, and re-write the delegate so that it gets converted into Func<Task<T>>.  With a property, only one or the other would be allowed to be defined.
Also in the Ruby framework the try member allows callers to submit a couple of different pieces:

Through multiple calls different delegates can be submitted in order to track multiple experiments.
The delegates can be named.

I have #14 being evaluated to better align the .NET framework to the Ruby framework, which begins to implement these features.

Thank you for the explanation.
Maybe I'll have to write up some documentation and put this in.


[document] Transaction Flow and Confirmation

from #100
Part of it describe in https://rooch.network/blog/modular-evolution-of-rollup-layer2

I have roughly skimmed through this blog, and I think my understanding of Rooch should be mostly correct.
I may not have explained it too clearly before. When I referred to the simulation layer, it means that the same application can have two "transaction execution environments," one that is "simulated" and one that is the "real deal". The simulation environment may be "missing a few things" compared to the real environment, so the execution speed will be faster. The difference becomes more apparent when the modules in the real environment are "heavier" or have a larger workload.
Looking forward to a more detailed and comprehensive article.


Display link to validate identity when pushing to keyserver

When sending keys to openpgp.org, user identity is stripped until verified. In order to verify, it is handy to do so immediately after sending the key:
gpg --send-key $KEYID | curl -T - https://keys.openpgp.org

@withinboredom would you mind documenting this detail with a PR? Would be glad to review and merge it. Thanks!


fix: Address early return preempting XHR harvest re-schedule

A early return condition in the harvest rescheduling logic in version 1.233.0 was preventing Ajax event harvest from being rescheduled. The agent now re-schedules Ajax event harvest on the regular interval.

Overview
This PR addresses a problem where, once the harvest scheduler runs for the Ajax feature and the Ajax feature has no accumulated data, the Ajax feature no longer performs future harvests. The issue appears to be line 92 in the harvest scheduler where it early-returns when there is no data to send, but does not schedule the next harvest.
Related Issue(s)
NEWRELIC-8876
Testing

All tests should run.
Manual verification of event harvest behavior should be confirmed.

Codecov Report

Merging #561 (a9b4ce8) into main (5046cb0) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
- Coverage   19.97%   19.95%   -0.02%
==========================================
  Files         132      132
  Lines        4326     4329       +3
  Branches     1103     1104       +1
==========================================
  Hits          864      864
- Misses       2735     2737       +2
- Partials      727      728       +1

Impacted Files
Coverage Δ

src/common/harvest/harvest-scheduler.js
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


HTML of mail is broken when Attaching files

Laravel Version: 5.2.45 (also happening on 5.1 LTS)
PHP Version: 7.0
Database Driver & Version: PostgreSQL

Description:
When sending an e-mail via Laravel and I add an attachment; the HTML of the e-mail template breaks. The same e-mail without attachment send correctly the HTML. But when having an attachment it shows:
https://www.dropbox.com/s/hhjt3hzjick9ld2/Schermafdruk 2016-10-14 15.45.26.png?dl=0
Steps To Reproduce:
Try sending an e-mail with PDF attachment attached
Mail::send('emails.invoice', $data, function ($m) use ($user,) {
            $m->to($user->email, $user->name)->subject('test');
            $m->attach(storage_path('invoice-test.pdf'), 'invoice.pdf', ['mime' => 'application/pdf']);
        });

@Jaspur From the image you posted i don't quite get what is your problem.
Is it a styling issue or it completely breaks with an error backend/frontend ?

It messes up the styling @PetarDambovaliev, so probably a parsing error in Laravel somewhere, but mail gets delivered except the styling.

@Jaspur try $m->attachData($data, 'invoice-test.pdf']);

@petardambovaliev tried that already (without the ] 😉), same styling issues.

I could not replicate your problem.

@PetarDambovaliev yes, that works; sending attachments. the attachment is always added. but the output of the html email thats send is broken. if you send the same html email without attachment, it shows up correctly. send it with attachment, the html is not correctly/missing/broken. mailtrap.io shows correct output. but real mail clients won't show the correct html. that is broken. its happening on multiple projects.

@Jaspur can you share a screenshot that shows that "broken" mail in real HTML clients?

https://www.dropbox.com/s/hhjt3hzjick9ld2/Schermafdruk 2016-10-14 15.45.26.png?dl=0

This may not be your actual problem – however, email layouts can break in some email clients if the email is too large. Fought this problem some time ago, especially on the iPhone when using mobile connections instead of WiFi. You could try to attach a smaller file – say just a few KB. However, as I already mentioned, this might not at all apply to you.
BTW: Your screenshot didn't tell me anything about your problem.

BTW: Your screenshot didn't tell me anything about your problem.

Does it work as intended in Mailtrap you say? What's the type of the attachment? If it works in Mailtrap that means the HTML is OK, maybe it's an issue with the mail client?

Can you send the .eml?

New screenshot:
https://www.dropbox.com/s/en2lh8e0e3hgy7h/Schermafdruk 2016-10-14 21.41.03.png?dl=0
The left is with attachment, the right is the same e-mail without attachment.
@themsaid yes, it is, but with all mail clients. Mailtrap shows the HTML, but all mailclients have their same way of "rendering" this. See the pastebin from the startpost.
Tried with a PDF of 3kb. Same issue. @tpraxl
Here is the EML: https://we.tl/4hM4XsJKP5

I know that bug. Has to do with Mac Mail. I believe it had to do with the type of attachment (there are at least two ways to attach it). Wait, I'll research. Hopefully, I can provide you with more information shortly.

Thunderbird looks OK. See:

Nice. Also happends in outlook by the way.

Well.. Outlook is not exactly known for rendering emails standards compliant:) I'm still researching. I'm a bit irritated, because I thought that this problem wouldn't occur with external images. Thought this only happened with inlined images. Maybe I cannot help you then, but I'm not done researching yet.

@Jaspur Looks like this is not a Laravel issue.

Your attachment:
Content-Type: application/PDF
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="test.pdf"

Try Content-Disposition: inline; filename=test.pdf
I know that sounds weird. However, I can tell, that I just struggled with the same problem and that solved it.
Example:
Content-Type: text/calendar; charset=utf-8; method=REQUEST; name="Termin.ics"
Content-Transfer-Encoding: base64
Content-ID: <Termin>
Content-Disposition: inline; filename=Termin.ics

In order to isolate the problem, would you please attach an image, the same way (Content-Disposition: attachment). Does it still happen? What happens, when you change to Content-Disposition:inline?)

@tpraxl uhm, how? :p
$m->attachData($pdf->output(), 'test.pdf', ['mime' => 'application/pdf', 'Content-Disposition' => 'inline']); doesn't do the trick.

Let's switch to private conversation and share the results afterwards here. I think this gets annoying for the others. I'll send you an email.

@tpraxl @Jaspur did you resolved it? just for the records on the conversation can you post here the solution?
I'm trying to do like Jaspur using fpdf:
$this->pdf = new Fpdi\Fpdi();
$this->pdf->AddPage();
$this->pdf->SetFont('Arial','B',16);
$this->pdf->Cell(40,10,'Fattura in pdf.');
$this->pdf->Output();

return $this->view(
        'orders.email.confirm',
        ['order' => $this->order]
)->attachData($this->pdf, 'test.pdf', [
        'mime' => 'application/pdf',
]);;

i am having this exact same issue -- what was the resolution?. For us, contents within the PDF that have markup show in the email download with all html markup while elsewhere using $pdf->download('sample.pdf') shows the html rendered perfectly. What is wrong with the below?
$pdf = $this->pdfService->getPDF($this->data['id']);
return<EMAIL_ADDRESS>'Sample')
->subject(sprintf("Subject line"))
->view('sample.view')
<EMAIL_ADDRESS>->bcc($this->creator->email)
->attachData($pdf->output(), 'sample.pdf');


Update image ghcr.io/zoriya/kyoo_migrations to 8a789c4

This PR contains the following updates:

Package
Update
Change

ghcr.io/zoriya/kyoo_migrations
digest
885adfa -> 8a789c4

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


-bash: [: 2: unary operator expected - OSX 10.7

I get this when I attempt to use <tab> for completion.
$ gba
* master
  remotes/ndbroadbent/master
  remotes/origin/HEAD -> origin/master
  remotes/origin/master
$ gf nd

If I stroke a <tab> to complete nd => ndbroadbent I get this output and it moves my cursor to the next line.
$ gf nd-bash: [: 2: unary operator expected

If I then press <tab> again
$ gf nd-bash: [: 2: unary operator expected
-bash: [: 2: unary operator expected

ndbroadbent   origin
$ gf nd

$ uname -a
Darwin ****** 11.2.0 Darwin Kernel Version 11.2.0: Tue Aug  9 20:54:00 PDT 2011; root:xnu-1699.24.8~1/RELEASE_X86_64 x86_64 i386
$ bash --version
GNU bash, version 4.2.10(2)-release (i386-apple-darwin11.2.0)

I don't notice this problem on ubuntu 10.04
$ uname -a
Linux ****** <IP_ADDRESS>-****** #8 SMP Mon Sep 20 15:54:33 UTC 2010 x86_64 GNU/Linux
$ bash --version
GNU bash, version 4.1.5(1)-release (x86_64-pc-linux-gnu)

This is strange. What version of git are you using? If less than 1.7.x, try installing homebrew and updating git.

  I'll have to downgrade packages, if it isn't much trouble, and test.  We may have to forward this upstream?

Hmm. Can you please try a plain git fetch nd<tab>?
If that works, can try set up tab completion manually and see if you still get the error?
e.g.
alias test_alias='git fetch'
complete -o default -o nospace -F _git_fetch  test_alias
# Test
test_alias nd<tab>

Thanks

Using test_alias produces the same error output.

If I use this form
g fetch nd\<tab\>

It works! I don't know if that helps.

Is the following any help? (from https://github.com/bobthecow/git-flow-completion/issues/2)

It sounds like you might have an outdated version of git-completion.bash. Grab a fresh copy here and see if that helps.

This is a pretty weird problem to have, looks like git <IP_ADDRESS> might be the culprit. I think this might need to go upstream to the git mailing list?

Fresh copy didn't fix the issue.

No change with 1.7.8-rc1

Here's a possible fix: https://github.com/bronson/dotfiles/blob/731bfd951be68f395247982ba1fb745fbed2455c/.bashrc#L81
Git mailing list thread: http://www.spinics.net/lists/git/threads.html#169149

Will implement the following soon, in aliases_and_shortcuts.sh:
# Credit to Scott Bronson for the following tab completion workaround.
# https://github.com/bronson/dotfiles/blob/731bfd951be68f395247982ba1fb745fbed2455c/.bashrc#L81
# (only for bash, zsh tab completions are done separately.)
__define_git_completion () {
eval "
_git_$2_shortcut () {
COMP_LINE=\"git $2\${COMP_LINE#$1}\"
let COMP_POINT+=$((4+${#2}-${#1}))
COMP_WORDS=(git $2 \"\${COMP_WORDS[@]:1}\")
let COMP_CWORD+=1

local cur words cword prev
_get_comp_words_by_ref -n =: cur words cword prev
_git_$2
}
"
}

__git_shortcut () {
    alias $1="git $2 $3"
    if [[ $shell == "bash" ]]; then
      type _git_$2_shortcut &>/dev/null || __define_git_completion $1 $2
      complete -o default -o nospace -F _git_$2_shortcut $1
    fi
}

Thanks, Scott!

Right on.  We'll see how long it works before they break it again.  :)

Still appears to be an issue (Git 1.7.8)
Any word on getting this fix in the main branch?
I wasn't successful at attempting a merge of bronson's code myself, though my bash scripting knowledge is limited.

Hi, I've finally fixed this issue, and I've pushed the changes to master.
Can you guys please test the alias tab completion and let me know if it works for you?
Cheers!

Seems to have partially fixed it, but some commands still throw errors, and others with display options upon TAB, but do not actually autocomplete. Kind of confusing, so here's some examples...

$ gco bash: [: 1: unary operator expected
$ gm
FETCH_HEAD      HEAD            master          ORIG_HEAD       origin/master
$ gm mast
FETCH_HEAD      HEAD            master          ORIG_HEAD       origin/master

So, gco still seems to throws the error, but gm does not (it did previously).
But even though gm doesn't throw an error, it doesn't autocomplete. In the last example, it should autocomplete to master, but it just displays the list of options instead. Interestingly, gd (diff) actually matches the behavior of both the examples; it doesn't autocomplete and it throws the unary opterator error, but it still shows a list of options (gco shows no options).
Seems like a rather frustrating issue to solve. Let me know if I can be of help in testing any further changes.
In case it matters, I am running Bash 4.2.10 on Ubuntu 11.10

Hi @BluSyn, thanks for helping me test this! I'm also using Bash 4.2.10 on Ubuntu 11.10, so we must be doing something slightly differently, since I'm not able to reproduce any of the problems you mentioned
The first thing I would test is just opening a new terminal after updating scm_breeze, since the previous script might have set up some conflicting functions.
Some additonal info:

At the bottom of my ~/.bashrc file I have the following line:

[[ -s "$HOME/.scm_breeze/scm_breeze.sh" ]] && . "$HOME/.scm_breeze/scm_breeze.sh"

~/.scm_breeze is running the latest code on the master branch.

Here's the contents of my ~/.git.scmbrc file: https://gist.github.com/1475635

Hope that helps!

My setup is exactly the same, it's seems very odd we are having different experiences. It has to be boiled down to some configuration, but I don't have any ideas where to start looking.
All my config files are available in my BluSyn/dotfiles repo if you want to bother poking around, but there's nothing really special about my bash setup.

I've just replaced my ~./bashrc with yours, and downloaded your ~/.bashTweaks file, but I'm still not experiencing any of your problems.
I think the first thing we should have checked is git versions: I'm using <IP_ADDRESS>

That must be it. I'm running 1.7.8 from the git-core ppa.
Looking back at this issue conversation, you and ghthor were talking about an issue in <IP_ADDRESS>, so it seems obvious now that the issue was never resolved in 1.7.8

Appears your fix worked perfectly. Not having any more issues.
Thanks!

Great, thanks for helping me test it!


[Feature Request]: Implementing Multilingual Support

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
On exploring the OnlineBookSales, I noticed that it is only available in English. To make it easier for more people to use and understand, I propose developing the website to support multiple languages. This will allow users to choose their preferred language for a better and more accessible experience.
Use Case
I wanted to make it available in different languages where non-English speaking users can access  and services in their native language.
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Is there an existing issue for this?

[x]  I have searched the existing issues

Feature Description
On exploring the OnlineBookSales, I noticed that it is only available in English. To make it easier for more people to use and understand, I propose developing the website to support multiple languages. This will allow users to choose their preferred language for a better and more accessible experience.
Use Case
I wanted to make it available in different languages where non-English speaking users can access and services in their native language.
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[x]  I have read the Contributing Guidelines
[x]  I'm a GSSOC'24 contributor
[x]  I have starred the repository

Hello @Anjankumarkamalapur , Go for it
All the Best

@Trisha-tech Assign this issue to me under GSSOC-ext and hacktoberfest and pls make it at least level 2 or 3

@Trisha-tech Assign this issue to me under GSSOC-ext and hacktoberfest and pls make it at least level 2 or 3

Hello @IkkiOcean , Go for it
All the Best

@Trisha-tech Assign this issue to me under GSSOC-ext and hacktoberfest and pls make it at least level 2 or 3

Hello @IkkiOcean , Go for it All the Best

I'm gonna PR soon but please make it Level 3 as  level 1 is not correct for this Issue


Logical rebranding of the admin panel

Is your feature request related to a problem? Please describe.
OP-FW is not directly related to Legacy, and the intent is that Legacy simply relies on OP-FW to provide the game servers and other services. With that in mind, it doesn't make that much sense for this admin panel to be called 'legacy' and be full with hardcoded Legacy branding.
Describe the solution you'd like
My suggestion would be to rebrand it to not announce any 'affiliation' with Legacy, and instead replace that with OP-FW.
Additional context
This isn't a big deal, but I figured I'd bring it to your attention and see if you'd like to change it.

Do you have any OP-FW assets like logos, etc. Link here.

Here's a link to all the files relating to the the current OP-FW assets & logos that I could find. There's also a discord guild for it here.


command-line: Run go code directly from command line.

Hello to all. Thanks for this great project, I'm very pleased to say it, because this language like gulp of fresh air! So I want to ask, will go support executing code directly from command line/terminal (I think it is called REPL).
Something like this:
go run "package main; func main() { println('hello') }"
hello

or
go run --directly "println('hello')"
hello

or
go exec --interactive
> for {
> println("hello")
> }

hello
hello
...

@pcc and @alandonovan have worked or are working on Go REPLs and it would be nice, but it's never been a goal for the Go project.


Added Theming

This is a rather large change in terms of the amount of code affected owing
to it proving rather difficult to add this feature into things in a reasonable
manner. The following changes have been made:

collect all plotting functions in a single class, where theme is defined at instantiation
all uses of the grayscale keyword have been either replaced with theme or removed as appropriate
the options keyword has been removed from qs.html()
as well, the download_filename keyword has been replaces with html_filename
type hinting was added to all code touched
all non-conventiona import statements have been made conventional
the 'Known Issues' segment of the README has been removed as the issue is no longer present

To use theming, a the current default and grayscale themes have been provided
in _plotting/themes.py. Any user-defined theme can be be created by following the
dictionary structure provided, noting that all keys must be present or the behaviour
is to fallback to default

closing as I messed squashing.


Dev

I checked the install and dryruns of the commands I think this branch is working better than the master.
Therefore I merge.


Use helm repo update <repo_name> instead of updating every repo

Currently, when adding a new helm repo in the Helm wrapper, the helm repo update causes to update all Helm repositories. With Helm 3.7 one can now specify the repo name to update. Introducing this requires that every project that uses KPOps uses helm > 3.7, which is not the case right now.

we should add a condition that checks if the installed version of Helm is > 3.7 to use this new approach, otherwise use the existing way of updating all helm repos.


serving a static mp4 file caused exception

ERROR:aiohttp.server:Error handling request
Traceback (most recent call last):
File "D:\soft\prog\python3\python-3.5.1\lib\site-packages\aiohttp\file_sender.py", line 131, in _sendfile_fallback
yield from resp.drain()
File "D:\soft\prog\python3\python-3.5.1\lib\site-packages\aiohttp\web_reqrep.py", line 888, in drain
yield from self._resp_impl.transport.drain()
File "D:\soft\prog\python3\python-3.5.1\lib\asyncio\streams.py", line 333, in drain
yield from self._protocol._drain_helper()
File "D:\soft\prog\python3\python-3.5.1\lib\asyncio\streams.py", line 211, in _drain_helper
yield from waiter
File "D:\soft\prog\python3\python-3.5.1\lib\asyncio\futures.py", line 361, in iter
yield self  # This tells Task to wait for completion.
concurrent.futures._base.CancelledError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\soft\prog\python3\python-3.5.1\lib\site-packages\aiohttp\web_server.py", line 61, in handle_request
resp = yield from self._handler(request)
File "D:\soft\prog\python3\python-3.5.1\lib\site-packages\aiohttp\web.py", line 249, in _handle
resp = yield from handler(request)
File "D:\prog\comp.lang.python\vmax\webfx2.py", line 330, in response
r = await handler(request)
File "D:\soft\prog\python3\python-3.5.1\lib\site-packages\aiohttp\web_urldispatcher.py", line 486, in _handle
ret = yield from self._file_sender.send(request, filepath)
File "D:\soft\prog\python3\python-3.5.1\lib\site-packages\aiohttp\file_sender.py", line 201, in send
yield from self._sendfile(request, resp, f, count)
File "D:\soft\prog\python3\python-3.5.1\lib\site-packages\aiohttp\file_sender.py", line 137, in _sendfile_fallback
resp.set_tcp_nodelay(True)
File "D:\soft\prog\python3\python-3.5.1\lib\site-packages\aiohttp\web_reqrep.py", line 737, in set_tcp_nodelay
resp_impl.transport.set_tcp_nodelay(value)
File "D:\soft\prog\python3\python-3.5.1\lib\site-packages\aiohttp\parsers.py", line 254, in set_tcp_nodelay
self._socket.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, value)
OSError: [WinError 10038] 在一个非套接字上尝试了一个操作。
■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■
I'm using py3.5.2, win32, aiohttp 1.3a (master)
request:
GET /static/upload/%E6%B5%99%E6%B1%9F%E8%81%94%E9%80%9Avmax/%E7%94%BB%E7%94%BB2.mp4 HTTP/1.1
Host: localhost:8080
Connection: keep-alive
Pragma: no-cache
Cache-Control: no-cache
Accept-Encoding: identity;q=1, *;q=0
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36
Accept: /
Referer: http://localhost:8080/static/issue.html?id=1
Accept-Language: zh-CN,zh;q=0.8
Range: bytes=0-
response:
HTTP/1.1 206 Partial Content
Content-Type: video/mp4
Last-Modified: Tue, 03 Jan 2017 02:19:38 GMT
Content-Length: 4201671
Date: Tue, 07 Feb 2017 15:26:24 GMT
Server: Python/3.5 aiohttp/1.3.0a0
the file is 4M, but the console shows only 366KB.

I'm just a plain lib user, have no idea how to fix it.  only thing to do is waiting this to be fixed.
thanks all~

exception is fixed in master. i am not sure about file size, try again with latest master

now no exception reported, but mp4 file still not correctly served.
only random sized bytes are transfered to browser.
response:
HTTP/1.1 206 Partial Content
Content-Type: video/mp4
Last-Modified: Tue, 03 Jan 2017 02:19:38 GMT
Content-Length: 4201671 █ full is 4M, only ~300KB is transfered at every refresh. video player not working... █
Date: Tue, 07 Feb 2017 15:26:24 GMT
Server: Python/3.5 aiohttp/1.3.0a0

I had 206 response and no content (blank line after headers) in browser. 1.3.1

To play Video in Chrome/Opera HTTP status Must be 200


Crash logging onto server

Describe the bug
I have a big modpack. Suddenly, when I log in my client crashes. When I do /enhancedweather killallOverworld on the server console, the server crashes.
To Reproduce
Steps to reproduce the behavior:

Install all mods
Run server
Log in on client
Run Enhanced Weather Commands on server

Expected behavior
Logging in without issue (as I have in the past)
Screenshots
If applicable, add screenshots to help explain your problem.
System Information:

OS: macOS (Linux on the server)
Minecraft Version: 1.19.2
Fabric/Quilt Loader Version: 0.14.19
Fabric API Version: Fabric API 0.76.0+1.19.2
EnhancedWeather Version: 1.0 Beta-5
Loaded mods: (See crash log)

Additional context
Opening of the crash log (which is attached):
Description: Ticking entity
java.lang.NullPointerException: Cannot invoke "sh.talonfox.enhancedweather.weather.ServersideManager.getClosestCloud(net.minecraft.class_243, double, boolean, boolean, boolean, boolean, int)" because "sh.talonfox.enhancedweather.EnhancedWeather.SERVER_WEATHER" is null
crash-2023-05-06_00.11.20-client.txt

I will add on by saying i have got this exact same issue on my server my log is slightly different but the issue seams the same
crash-2023-05-05_22.10.05-client.txt

Hello @bob4444, thank you for reporting this. At the moment, these commands only work on singleplayer mode. I will try to fix this in the near future. Thank you for reporting this.

Any update on this? Was it resolved in the 1.20 update? If so, will you be updating the other game versions as well?

I haven't fixed this yet, I'm currently working on other stuff and never got to doing that, though it is in my list of things to fix eventually. Technically the commands were meant for debugging purposes and weren't meant to be ran on a decdicated server, however I will try to fix this soon. Also unfortunately, this fix won't be backported to older versions, it will only be available for the latest version of Minecraft when it does get fixed, it just makes development easier.

These issues have now been fixed on the latest version of Enhanced Weather ;3


Translation to Romanian language

Description
I would like to contribute and help with the translation of the project into Romanian language but I'm not able to fine the language in the project. Can this be enables by the project team ? Thank you.
Priority
Low (Nice-to-have)

Related to #1954


how to publish

Hi,
I have installed and set up bookstore but I am not sure about how notebooks are supposed to be copied from the workspace to the published. On save notebooks seem to gracefully be stored on S3 but can't find how to properly publish then.

Hi @taniki! We're currently working on UI for this in the nteract frontend with https://github.com/nteract/nteract/pull/4144 and https://github.com/nteract/nteract/pull/4122. As of today you'd have to perform a PUT against the /api/bookstore/published endpoint directly: https://github.com/nteract/bookstore/blob/master/bookstore/handlers.py#L89

ok that's great. I will wait for the feature be shipped in a next nteract release then :smile:


Ep 2124 updated search

Description
Fixed loading state for search results

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Updated python sdk with Instance v3 Edit feature APIs

Updated python sdk with Instance v3 Edit feature APIs
PR summary

Fixes: https://github.ibm.com/hummingbird/tracker/issues/3101
PR Checklist
Please make sure that your PR fulfills the following requirements:

[X] The commit message follows the Angular Commit Message Guidelines.
[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

PR Type

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

For issue: https://github.ibm.com/hummingbird/tracker/issues/3101

Closing this PR as these changes have already been merged to master via a different PR.


[cadl] make generated cadl code pylint clean

close this since pylint enabled and cleaned in PR https://github.com/Azure/autorest.python/pull/1605


Add subword cursors - take 3

Fixes #1982 and an alternative to #3961. Also, hopefully can used with atom/vim-mode#377.
I can't figure out how to go left on the first line when there is only white space, see cursor.moveToSubwordBoundary(), /^[\t ]*$/ isn't working.
I haven't added keymaps yet. But maybe:
'.platform-linux .editor, .platform-win32 .editor':
  'alt-left': 'editor:move-to-previous-subword-boundary'
  'alt-right': 'editor:move-to-next-subword-boundary'
  'alt-shift-left': 'editor:select-to-previous-subword-boundary'
  'alt-shift-right': 'editor:select-to-next-subword-boundary'
  'alt-backspace': 'editor:delete-to-beginning-of-subword'
  'alt-k': 'editor:delete-to-end-of-subword'

'.platform-darwin .editor':
  'ctrl-alt-left': 'editor:move-to-previous-subword-boundary'
  'ctrl-alt-right': 'editor:move-to-next-subword-boundary'
  'ctrl-alt-shift-left': 'editor:select-to-previous-subword-boundary'
  'ctrl-alt-shift-right': 'editor:select-to-next-subword-boundary'
  'ctrl-alt-backspace': 'editor:delete-to-beginning-of-subword'
  'ctrl-alt-k': 'editor:delete-to-end-of-subword'

I would not mind if both were the same, though (ctrl-alt).  But Sublime uses just alt on Linux/Win, I'm not sure about Mac.

This one has gotten stale.  See #5806.


Add dockerfile for deployment of next-forge for self-hosting

I'm not a Docker user but I'd be open to a PR that implements this!

This would be great. I'm planing to host this on coolify but currently i'm gettins some issues with nixpacks. +1

This would be great especially if we could set it up for each package seperately to allow us to integrate each service seperately or as a group

hi there👋! I'd like to work on this

@coolchigi Go for it!

Hopefully this is still being looked into. Was hoping to host it on coolify as well


Chat Notifications Layout

Hello guys,
Is it possible for you to provide also the common layout used in chat apps? We need the possibility to display user avatar on the left of the notification tile as whatsapp/telegram do on both ios and android. Layout changes between the two platforms but user’s avatar is there.

Attaching examples of required layouts

On Android there is already a dedicated layout for chat apps, but on the Awesome plugin for iOS it doesn't yet, although there is already the equivalent for iOS. For now, iOS will group messages as it did before the new iOS chat layout feature. This new iOS layout will not be available for version 0.7.0, but will be implemented shortly right after, in a version 0.7.1.

Hi! Sorry for taking so long to respond to your issue on GitHub. I was focused on releasing the new 0.7.0 version of awesome_notifications and awesome_notifications_fcm and i didn't had time enough to do both. But now I can answer all your questions.
So now i'm asking you to recreate this topic using the new issue template. There's a lot of missing informations that i need to understand your problem, and all the instructions are already in the new issue template. Also, remember to check beforehand if your issue was posted by another user.
So I will automatically close all previous issues so far.
Sorry for the inconvenience and i will be waiting for your new issue request.
Thank you so much for your support!


display some HTML object doesn't get any useful output in IPython console

PR #289 introduces a new issue to me. that is when working with IPython console, display some HTML object doesn't get any useful output, it looks like this:

@twiecki What if use display(df) instead of display(df.to_html()),
for notebook:

for IPython console:

Now, they are both happy;)

@mickeydonkey Thanks for looking into that, will change. Do we even need the get_ipython() hack then?

Did you check whether that works from inside a function?

I checked the following code for print inside a function, and it works as before:
from IPython.display import display df = pd.DataFrame([1,2],[3,4]) def smart_print(a):     display(pd.DataFrame([1,2],[3,4])) smart_print(df)

Sweet! Want to do a PR?

Sorry, I haven't make any commit yet. in addition, I am not familiar with code styling stuff like PEP8. So you'd better fix it yourself. Thanks

even if I do hope I could contribute the code.....

Much simpler, thanks for your help!


Line renders both topFill & bottomFill colors for negative data

How to reproduce
fill = LineCartesianLayer.LineFill.double(
                            topFill = fill(MaterialTheme.colorScheme.primary),
                            bottomFill = fill(MaterialTheme.customColors.negative)
                        )

Data for this view:
xSeries = [19936, 19937, 19938, 19939, 19940, 19941, 19942]
ySeries = [500.00, -5, -5, -5, -5, -25, -25]

Observed behavior

Line colors are split and default marker mixes the colors of both fill colors
Expected behavior
The color of the line and marker should be distinct for positive/negative values.
Vico version(s)
2.0.0-alpha.27
Android version(s)
Any

Hi @mak1nt0sh, you seem to describe an additional issue here compared to your comment. The comment mentioned the marker problem, but here you've also described that the y = -5 line segment has split colors. With a single horizontal split it's geometrically impossible for it to never occur as the line has some thickness.
Here's the current state.

For the y = -5 line segment to not be split we'd have to shift the split upward. But then we'd be back to the problem described in #784.

A possible solution would be to split the line vertically. Is it what you expect?

Can't it always draw above or below the threshold line? Anything above or equal to the splitY value would push the line to draw on the border and if <splitY draw below?
Sorry I'm on my phone rn, can't draw these beautiful sketches <3

Can't it always draw above or below the threshold line? Anything above or equal to the splitY value would push the line to draw on the border and if <splitY draw below?
Sorry I'm on my phone rn, can't draw these beautiful sketches <3
Edit:
I guess it would require shifting the line by small offset equal to half the line width?

Also the #809 is still not fixed.

The bottom (negative line) is completely drawn with topFill.
Data for this view:
[19936, 19937, 19938, 19939, 19940, 19941,
[500, 500, 500, -2, -2, -2, -2, -2, -202]

Can't it always draw above or below the threshold line? Anything above or equal to the splitY value would push the line to draw on the border and if <splitY draw below?

In this case, the position of the line wouldn't reflect the data and there would be misalignments with axis guidelines, HorizontalLines, other layers, etc.

Also the https://github.com/patrykandpatrick/vico/issues/809 is still not fixed.

I believe it is.

The bottom (negative line) is completely drawn with topFill.

It's not. If you zoom into the line you can see it starts fading to red.

You don't see the pure red, because the sliver is less than a pixel in height. In a high enough resolution, you'd see this.

It's the same story as above. The current state.

Again, for the y = -2 line segment to be fully red we'd have to move the split upwards and we would be back to the issue #784.

Once again, it would require vertical splits.

I just checked a few apps like Yahoo finance and CoinMarketCap and it seems they both have different rendering ways. I guess I'll leave it up to you to decide the best way to go forward.
Yahoo seems to render by direction and stack the lines:

CoinMarketCap splits by x:

Is more information needed? (I can see the label for this issue).
I'm currently stuck on 2.0.0-alpha.22 due to this issue.

Sorry for the wait. Regarding the color mixing problem, we have all the required information for now. We will look into fixing this.
Regarding the edge case with the splits:

Yahoo seems to render by direction and stack the lines:

This is slightly suboptimal, because with round caps, the split positioning is a bit imprecise, and with butt caps gaps can appear.

CoinMarketCap splits by x:

The charts don't seem to be zoomable, or pannable so we weren't able to see how the splitting works. But we checked TradingView and it seems to use vertical splits.

This is what I mentioned above, and it seems to be the best choice. We'll look into implementing this. However, this is an enhancement and not a bug fix.
AreaFill.double now works as documented, even if it’s not suited for the edge case in question. Therefore, we’ll use this issue to track the color mixing problem, and we’d ask you to open a discussion in the “Ideas” category for the switch to vertical splits. It’s fine to just link this issue.

Please also check CoinMarketCap they handle horizontal splits pretty well. You can export graphs by clicking ... menu at the top right corner of the chart.

Vico v2 0.0-beta.4 fixes the color mixing.


Create benchmark harness

Create benchmark harness and run it in the pipeline, so that we can know if changes make the performance worse.

Good idea! https://github.com/bluefireteam/ordered_set/pull/43 adds a barebones setup to start with, but we need to figure out how/where to integrate it into the CI.


Confused about skpm versions

Hello,
I'm trying to install and run skpm.
After doing skpm create localize-screenshots, cd localize-screenshots, I'm having the following error:
✗ npm run start

><EMAIL_ADDRESS>start
> skpm-build --watch --run

🖨  Copied src/manifest.json in 2ms
🛠  Copied assets/icon.png
❗ Cannot run the plugin automatically for Sketch < 45
/Users/bruno/Documents/_TheGrizzlyLabs/src/sketch-screenshots/localize-screenshots/node_modules/webpack/lib/webpack.js:31
		throw new WebpackOptionsValidationError(webpackOptionsValidationErrors);
		      ^

WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration.plugins[3] should be one of these:
   object { apply, … } | function
   -> Plugin of type object or instanceof Function
   Details:
    * configuration.plugins[3] should be an object.
      -> Plugin instance
    * configuration.plugins[3] should be an instance of function
      -> Function acting as plugin
    at webpack (/Users/bruno/Documents/_TheGrizzlyLabs/src/sketch-screenshots/localize-screenshots/node_modules/webpack/lib/webpack.js:31:9)
    at /Users/bruno/Documents/_TheGrizzlyLabs/src/sketch-screenshots/localize-screenshots/node_modules/@skpm/builder/lib/build.js:148:46
    at Generator.next (<anonymous>)
    at step (/Users/bruno/Documents/_TheGrizzlyLabs/src/sketch-screenshots/localize-screenshots/node_modules/@skpm/builder/lib/build.js:298:191)
    at /Users/bruno/Documents/_TheGrizzlyLabs/src/sketch-screenshots/localize-screenshots/node_modules/@skpm/builder/lib/build.js:298:361
    at processTicksAndRejections (node:internal/process/task_queues:93:5) {

I checked which version of skpm I have:
✗ skpm --version
1.3.1

Which seems to be the latest version on npm.js, but dating back from a year ago.
But then I see on your repo that the latest tagged version is 0.10.3.
How can I actually get the latest version of skpm? Or is it a different problem that I'm having?
Thanks!

there is skpm that is used to create a new plugin and publishing it (currently on version 1.3.2) and skpm-build that is used to compile a plugin (version 0.7.11). I stopped using tags when I started having multiple library in the same repo.

there is skpm that is used to create a new plugin and publishing it (currently on version 1.3.2) and skpm-build that is used to compile a plugin (version 0.7.11). I stopped using tags when I started having multiple library in the same repo.


Build with dotnet (#70).

#70
cc @victorhurdugaci @Tratcher

I can't get AutobahnTestClient to run with dotnet. Will continue investigating tomorrow.

Is this done?

Alomst. Remove all of the dnx451.

Build passes on Windows and Linux (if you look at the Travis job). Fails on Mac due to an issue in dotnet. Can I merge or should I wait until it builds everywhere?

@Tratcher Could you take a look at the changes I've done to AutobahnTestClient?

They look fine.


docs: how to configure an IDE for development

Closes #50.
Summary of Changes

How to configure PyCharm
How to configure VS Code
Some hints about common mistakes

🦙 MegaLinter status: ✅ SUCCESS

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

✅ MARKDOWN
markdown-link-check
1

0
0.83s

✅ REPOSITORY
git_diff
yes

no
0.05s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by

:tada: This PR is included in version 0.11.0 :tada:
The release is available on:

v0.11.0
GitHub release

Your semantic-release bot :package::rocket:


No Vary: Accept-Encoding  when resource is not improved

Hi there
I have a site on a VM, centos 7.2, nginx 1.11.6 NPS <IP_ADDRESS>, and Wordpress moved from http to https http/2. When in http, css and js files where minified and combined with a wp plugin. I am triying to no combine nor inline these files because is the recommended with http/2, but have some issue with that:
1 css file is not url rewriten, not cache extended.... and no Vary Accept-Encoding, no Etag. When debugging I get <!--CSS rewrite failed: Cannot improve https://example.com/wp-content/themes/theme-name/css/responsive.min.css-->, but the file is inlined (I think because Prioritize Critical Css).
Headers:
HTTP/1.1 200 OK
Server: nginx
Content-Type: text/css
Transfer-Encoding: chunked
Connection: keep-alive
Date: Thu, 17 Nov 2016 19:55:35 GMT
Expires: Thu, 24 Nov 2016 19:55:35 GMT
Cache-Control: max-age=604800
Last-Modified: Fri, 28 Oct 2016 09:27:27 GMT
Content-Encoding: br
1 css file is not url rewriten too, nor cache extend, but have Etag and Vary: Accept-Encoding. User-Agent, Save-Data, no debug data because is a file called from a js script and don´t appear in the html code
Headers:
HTTP/1.1 200 OK
Server: nginx
Content-Type: text/css
Transfer-Encoding: chunked
Connection: keep-alive
X-Original-Content-Length: 273557
Etag: W/"PSA-aj-iduyDQ1HIB"
Date: Thu, 17 Nov 2016 19:55:35 GMT
Expires: Thu, 24 Nov 2016 19:55:35 GMT
Cache-Control: max-age=604800
Vary: Accept-Encoding, User-Agent,Save-Data
Content-Encoding: br
Some js (allmost 9) files that have url rewriten and cached extended, but don´t have Vary: Accept-Encoded, No debug messages and the rewriten url are type file.js.pagespeed.ce.aHvzEE8Xou.js
Headers:
HTTP/1.1 200 OK
Server: nginx
Content-Type: application/javascript
Transfer-Encoding: chunked
Connection: keep-alive
Last-Modified: Fri, 28 Oct 2016 01:00:15 GMT
Date: Thu, 17 Nov 2016 19:55:34 GMT
Expires: Fri, 17 Nov 2017 19:55:34 GMT
Cache-Control: max-age=31536000
Etag: W/"0"
X-Page-Speed: <IP_ADDRESS>-0
Content-Encoding: br
Here the filters applied:
Filters
ij	Canonicalize Javascript library URLs
cw	Collapse Whitespace
gp	Convert Gif to Png
jp	Convert Jpeg to Progressive
jw	Convert Jpeg To Webp
mc	Convert Meta Tags
pj	Convert Png to Jpeg
ws	When converting images to WebP, prefer lossless conversions
ea	Elide Attributes
ec	Cache Extend Css
ei	Cache Extend Images
ep	Cache Extend PDFs
es	Cache Extend Scripts
fc	Fallback Rewrite Css
hw	Flushes html
gf	Inline Google Font CSS
il	Inline @import to Link
io	In-place optimize for browser
id	Insert Image Dimensions
js	Jpeg Subsampling
tu	Left Trim Urls
cj	Move Css Above Scripts
cm	Move Css To Head
pc	Add pedantic types
pr	Prioritize Critical Css
rj	Recompress Jpeg
rp	Recompress Png
rw	Recompress Webp
rc	Remove Comments
rq	Remove Quotes
ri	Resize Images
ir	Resize to Rendered Image Dimensions
cf	Rewrite Css
jm	Rewrite External Javascript
jj	Rewrite Inline Javascript
cs	Rewrite Style Attributes
cu	Rewrite Style Attributes With Url
cp	Strip Image Color Profiles
md	Strip Image Meta Data
If nedeed I can send url to the site.

Files get cache extend and url are rewrited but files that "only" are cache extended don´t have the header Vary: Accept-Encoding nor x-original-content-length. This last seem normal, if file are unchanged content-length don´t change.

Changed NPS to <IP_ADDRESS> and the issue is ongoing.
The unchanged resources are getting a s-maxage of 10. not Vary: Accept-Encodding not etag....

Sorry for calling you here @jeffkaufman but this issue sound related to this other in mod_pagespeed #1382

Yes, they do look potentially related.  None of us have dug into this bug yet, though.


[feat] Add ability to enable basic events per-device

Is your feature request related to a problem? Please describe.
Aeotec Nano Switch (zw116) has a config option that configures whether presses of the physical switch will toggle the state of the load directly or whether button press will only be passed to the gateway as basic set events.
By default, this setting is set to control the load directly. This is fine for most use cases as user would probably want connected light to toggle whenever he/she presses the switch.
However, I have smart bulb wired to that switch. Smart bulbs are controlled directly and you should not ever cut electricity to them. That is why Nano Switch that is wired to the bulb is always in the "ON" position and aforementioned config option is set to send basic set events to the gateway (these events then toggle the smart bulb via Home Assistant automation). That way I can retain both smart bulb features and physical switch to toggle the bulb.
However, with recent version, zwavejs seems to ignore these basic set events. I cannot find a way (without editing config files) to receive these events and process them in Home Assistant.
Describe the solution you'd like
It would be useful it there was a way to enable transmission of basic set events via MQTT on per device basis. Maybe by creating special value that would reflect last basic set event, similar to how OpenZwave did it when appropriate flags were enabled (https://github.com/OpenZWave/qt-openzwave/issues/60)?
Describe alternatives you've considered
I'm currently using modified config for nano switch (https://github.com/zwave-js/zwavejs2mqtt/issues/1011) with treatBasicSetAsEvent compatibility flag enabled. This works, but it is cumbersome, I'm not getting any config updates automatically and it is applied to all nano switches in my network (I only want this behavior on one).

Can you post some logs? It would be helpful to see what is being sent and where it's being ignored. We'll need the node-zwave-js log at a silly or debug level.
Note that zwavejs2mqtt can't really do anything with this. There is no way for it to tell node-zwave-js to send basic events if node is ignoring them. That's not to say it can't be implemented but doing so would require upstream fixes too.
What happens if you don't use the compat flag but enable the parameter and toggle it. Can you show us that too in a log? For some devices that'll work but not if the the endpoint the report is mapped to continues to control the relay.

Huh I just checked and I seem to get the event even with treatBasicSetAsEvent disabled:
2021-04-11 08:25:11.991 INFO ZWAVE: Node 51: value notification: 32-0-event 0
2021-04-11 08:25:16.119 INFO ZWAVE: Node 51: value notification: 32-0-event 255

Maybe I screwed up something when testing before. Anyway, when this value notification happens, event will get emitted on zwave/_EVENTS/ZWAVE_GATEWAY-zwavejs2mqtt/node/node_value_updated:
{
    "data": [
        {
      ...
        },
        {
            "commandClassName": "Multilevel Switch",
            "commandClass": 38,
            "endpoint": 0,
            "property": "currentValue",
            "newValue": 0,
            "prevValue": 0,
            "propertyName": "currentValue"
        }
    ]
}

However, event is buried at the bottom of this very long JSON, making it a bit cumbersome to parse with Home Assistant templates. Any chance this value could be saved into some value instead of just being an event?

You have to restart and then reinterview the device after changing the config file.

@robertsLando another note about the event not showing up under 32

I did restart and reinterview the device. It still works without compat options.

Ah, I misread it. The basic command class is 32 not 38. Without the compat flag it's being mapped to the multi sensor CC not treated as an event.

Reading other issue, basic events being posted in their own topic is exactly what I want (https://github.com/zwave-js/zwavejs2mqtt/issues/1044#issuecomment-817585539). I think this can be closed as duplicate of the other issue.


Documentation for Output objects

Summarize Functionality
In the documentation the name of the object under Output is a link that goes nowhere.
https://thycotic-ps.github.io/thycotic.secretserver/commands/secrets/Get-TssSecret.html#outputs
For the Get-TssSecret page, the output Thycotic.PowerShell.Secrets.Secret has a link next to it which looks like a page heading anchor https://thycotic-ps.github.io/thycotic.secretserver/commands/secrets/Get-TssSecret.html#thycoticpowershellsecretssecret
Can examples be added of what the Thycotic.PowerShell.Secrets.Secret object contains?  This would also be useful for any other cmdlet outputs as well.
Is there a command that is similiar or close to what you are looking for?
No
Technical Details
No response

We previously attempted to maintain the output help files via about_* files that could be read using Get-Help, but it was to much to maintain along with the codebase. The output types on the commands mirror the endpoint's model object that can be viewed in the REST API Guide. (e.g. Thycotic.PowerShell.Secrets.Secret is mirror of the output from GET /v1/secrets/{id} endpoint).
PowerShell offers two methods that can be utilized to discover the output object properties:

Utilize Get-Member (e.g. <command call> | Get-Member -MemberType Properties,Methods)
Declare a new instance of the type, piping to Format-List (e.g. [Thycotic.PowerShell.Secrets.Secret]::new() | Format-List`)


K8SPXC-1044 set labels and annotations for replicas service

add possibility to set different labels and annotations for
<cluster-name>-replicas  service and for <cluster-name>-service

Test name
Status

scaling
passed

upgrade-haproxy
passed

haproxy
passed

cross-site
passed

storage
passed

scheduled-backup
passed

recreate
passed

big-data
passed

scaling-proxysql
passed

self-healing
passed

self-healing-chaos
passed

init-deploy
passed

restore-to-encrypted-cluster
passed

security-context
passed

self-healing-advanced
passed

self-healing-advanced-chaos
passed

upgrade-proxysql
passed

limits
passed

demand-backup
passed

monitoring-2-0
failed

operator-self-healing
passed

operator-self-healing-chaos
passed

smart-update
passed

pitr
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

demand-backup-encrypted-with-tls
passed

users
passed

upgrade-consistency
passed

tls-issue-self
failed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

proxy-protocol
failed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1181/commits/f74f28b08b3aaa1fbcc96fc11623871e15707783
image: perconalab/percona-xtradb-cluster-operator:PR-1181-f74f28b0

Test name
Status

storage
passed

recreate
passed

big-data
passed

haproxy
failed

scaling
passed

upgrade-haproxy
passed

scheduled-backup
passed

cross-site
passed

scaling-proxysql
passed

self-healing
passed

self-healing-chaos
passed

restore-to-encrypted-cluster
passed

security-context
passed

init-deploy
passed

self-healing-advanced
passed

self-healing-advanced-chaos
passed

upgrade-proxysql
passed

demand-backup
passed

limits
passed

operator-self-healing
passed

operator-self-healing-chaos
passed

smart-update
passed

monitoring-2-0
failed

pitr
failed

affinity
passed

one-pod
passed

upgrade-consistency
passed

auto-tuning
passed

demand-backup-encrypted-with-tls
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

proxy-protocol
failed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1181/commits/7631eb576b20bae5ea8b9789063176dfaeb0e233
image: perconalab/percona-xtradb-cluster-operator:PR-1181-7631eb57

Test name
Status

big-data
passed

cross-site
passed

storage
passed

self-healing
passed

recreate
passed

haproxy
passed

self-healing-chaos
passed

restore-to-encrypted-cluster
passed

upgrade-haproxy
passed

self-healing-advanced
passed

scaling
passed

scheduled-backup
passed

demand-backup
passed

self-healing-advanced-chaos
passed

scaling-proxysql
passed

pitr
failed

operator-self-healing
passed

security-context
passed

operator-self-healing-chaos
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

init-deploy
passed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

proxy-protocol
failed

demand-backup-encrypted-with-tls
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1181/commits/0f8c347751fa04bc01798b1493c291bb2ef17a92
image: perconalab/percona-xtradb-cluster-operator:PR-1181-0f8c3477

Test name
Status

We run 0 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1181/commits/bc79c725382b2e4e18ca583b05ec1d1b60f55ba0
image: perconalab/percona-xtradb-cluster-operator:PR-1181-bc79c725

Test name
Status

haproxy
failed

upgrade-haproxy
passed

scaling
passed

scheduled-backup
failed

recreate
passed

storage
passed

big-data
passed

cross-site
passed

scaling-proxysql
passed

self-healing
passed

self-healing-chaos
failed

restore-to-encrypted-cluster
passed

init-deploy
passed

security-context
passed

upgrade-proxysql
passed

self-healing-advanced
passed

self-healing-advanced-chaos
failed

demand-backup
passed

limits
passed

smart-update
passed

operator-self-healing
passed

operator-self-healing-chaos
failed

monitoring-2-0
passed

pitr
failed

affinity
passed

one-pod
passed

auto-tuning
passed

upgrade-consistency
failed

proxysql-sidecar-res-limits
passed

demand-backup-encrypted-with-tls
passed

users
failed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

proxy-protocol
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1181/commits/dfca4e74905e47e5c9804c2d7f516b5773d9eea5
image: perconalab/percona-xtradb-cluster-operator:PR-1181-dfca4e74

Test name
Status

big-data
passed

haproxy
passed

upgrade-haproxy
passed

cross-site
passed

recreate
passed

scheduled-backup
failed

restore-to-encrypted-cluster
passed

storage
passed

scaling
passed

demand-backup
passed

self-healing
passed

scaling-proxysql
passed

pitr
failed

security-context
passed

self-healing-chaos
failed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

init-deploy
passed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

self-healing-advanced
passed

self-healing-advanced-chaos
failed

operator-self-healing
passed

operator-self-healing-chaos
failed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

proxy-protocol
passed

demand-backup-encrypted-with-tls
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1181/commits/dfca4e74905e47e5c9804c2d7f516b5773d9eea5
image: perconalab/percona-xtradb-cluster-operator:PR-1181-dfca4e74


chore: fix some typos

fix some typos in docs to enhance readability.

@bors r+

:pushpin: Commit a140084b6c2dd823a84bacb0753af18ed38ff572 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit a140084b6c2dd823a84bacb0753af18ed38ff572 with merge 5d5c524ea2caa8e35789b5a3095fb9dc83f21b63...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 5d5c524ea2caa8e35789b5a3095fb9dc83f21b63 to master...


IE 11 - Keys greater in length than 889 characters are truncated.

Browser: IE 11
Version: 11.0.9600.17843, Update Versions: 11.0.20 (KB3058515)
Observed Behavior:
If a key of length greater than 888 characters is set in IE 11, anything beyond the 889th character is ignored. This means that if I have two keys of 900 characters in length, and only the last 10 characters are different, the last value set will be the one returned for either key.
Expected Behavior:
Key length should not affect behavior. Different keys of 900 characters in length should be able to map to different values even if only the last character is different.
To reproduce in console:
function testLocalForageKeyLength(length) {
    // Clear localforage
    localforage.clear();

    // init keys and values
    var key1 = new Array(length+1).join('1'),
        key2 = key1 + '2',// Key2 is 1 character longer than key1.
        val1 = '1',
        val2 = '2';
    localforage.setItem(key1, val1).then(function(){
        localforage.setItem(key2, val2).then(function(){
            localforage.getItem(key1).then(function(v1){
                localforage.getItem(key2).then(function(v2) {
                    var err = false;
                    if (v1 === v2) {
                        err = true;
                        console.error("Failed asserting that values are different.");
                    }
                    if (v1 !== val1) {
                        err = true;
                        console.error("Failed asserting that returned value for key1 is equal to set value for key1.")
                    }
                    if (v2 !== val2) {
                        err = true;
                        console.error("Failed asserting that returned value for key2 is equal to set value for key2.")
                    }
                    if (!err) {
                        console.log("Succeeded asserting that values are different.");
                    }
                    console.log("key1 length: " + key1.length + " key2 length: " + key2.length + " key1 value returned: " + v1 + " key2 value returned: " + v2);
                })
            });
        });
    });
}

testLocalForageKeyLength(10);
// Wait for return of each test before proceeding...
testLocalForageKeyLength(100);
testLocalForageKeyLength(888);
testLocalForageKeyLength(889);

Console Output:
testLocalForageKeyLength(10);
Succeeded asserting that values are different.
key1 length: 10 key2 length: 11 key1 value returned: 1 key2 value returned: 2

testLocalForageKeyLength(100);
Succeeded asserting that values are different.
key1 length: 100 key2 length: 101 key1 value returned: 1 key2 value returned: 2

testLocalForageKeyLength(888);
Succeeded asserting that values are different.
key1 length: 888 key2 length: 889 key1 value returned: 1 key2 value returned: 2

testLocalForageKeyLength(889);
Failed asserting that values are different.
Failed asserting that returned value for key1 is equal to set value for key1.
key1 length: 889 key2 length: 890 key1 value returned: 2 key2 value returned: 2

Note: This is pretty clearly an IE bug, not a bug in localforage. Nevertheless, it would be good to incorporate a workaround.

Edge is also affected. Given that IE10 doesn't pass IndexedDB tests either, I'd assume it is affected as well.

It not passing the IndexedDB tests might be unrelated, as we don't have a key length test.
Using 900-length keys seems... odd. We should support it if the spec does, of course! But I'm surprised that would come up :smile:
I wonder what the actual limit of key length is? 😮

I actually use localforage as a client-side cache for certain data - to generate the keys, I hash the request data (sometimes rather large) and store the hash as a cache key for the returned data. In debug mode, I don't hash the request data. I instead use the entire stringified request data as the key so it's easier to inspect the cache.
You can see how that would trigger the bug :wink:
I (quickly) looked through the spec a bit and couldn't find any mention of a maximum key size.

Oh, that makes perfect sense then!
Yeah I don’t recall a max size either. I wonder if @nolanlawson ran into anything like this with PouchDB sizes.
Anyway, I’ll check into why this is… do you get the error if you use IndexedDB directly in IE 11? I suppose we should figure out if this is an error in localForage or a browser vendor bug...

tofumatt

On Tue, Sep 8, 2015 at 1:06 AM, Bill Schaller<EMAIL_ADDRESS>wrote:

I actually use localforage as a client-side cache for certain data - to generate the keys, I hash the request data (sometimes rather large) and store the hash as a cache key for the returned data. In debug mode, I don't hash the request data. I instead use the entire stringified request data as the key so it's easier to inspect the cache.
You can see how that would trigger the bug :wink:
I (quickly) looked through the spec a bit and couldn't find any mention of a maximum key size.
Reply to this email directly or view it on GitHub:
https://github.com/mozilla/localForage/issues/444#issuecomment-138394351

I am not sure if the bug is in localforage or IE, but I did look through the driver, and nothing I can see would be truncating the keys like that. I did not have time to grok and attempt direct use of indexeddb, as it was Friday and the 3-day-weekend beer was calling my name.

Nope, I've never run into this bug before, but if it really is a MS bug, it would be worthwhile to file it on them. :) I've found they're pretty responsive at http://connect.microsoft.com/, although sadly none of the bugs I've filed have been fixed yet (not even in Edge...). :/

Sweet, good to know. I'll make a note to do that. :-)
Thanks Nolan!

tofumatt

On Tue, Sep 8, 2015 at 1:21 PM, Nolan Lawson<EMAIL_ADDRESS>wrote:

Nope, I've never run into this bug before, but if it really is a MS bug, it would be worthwhile to file it on them. :) I've found they're pretty responsive at http://connect.microsoft.com/, although sadly none of the bugs I've filed have been fixed yet (not even in Edge...). :/
Reply to this email directly or view it on GitHub:
https://github.com/mozilla/localForage/issues/444#issuecomment-138539171

I've reported the bug for now, but I'm open to a workaround in the future. https://connect.microsoft.com/IE/feedbackdetail/view/1767952/indexeddb-does-not-accept-keys-longer-than-888-characters

https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/5333188/

Thanks for filing the bug on Edge; hopefully someone at MS can look into this!


jpegoptim: 1.4.4 -> 1.4.5

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/jpegoptim/versions.
These checks were done:

built on NixOS
ran /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5/bin/jpegoptim -h got 0 exit code
ran /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5/bin/jpegoptim --help got 0 exit code
ran /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5/bin/jpegoptim help got 0 exit code
ran /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5/bin/jpegoptim -V and found version 1.4.5
ran /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5/bin/jpegoptim --version and found version 1.4.5
ran /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5/bin/jpegoptim -h and found version 1.4.5
ran /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5/bin/jpegoptim --help and found version 1.4.5
found 1.4.5 with grep in /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5
directory tree listing: https://gist.github.com/5b96a382d26959a9ce1da4b4d0b45d55

cc @aristidb for review

Success on x86_64-linux (full log)
Attempted: jpegoptim
Partial log (click to expand)
/nix/store/qrxs7sabhqcr3j9ai0j0cp58zfnny0jz-coreutils-8.29/bin/install -c -m 755 jpegoptim /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5/bin/jpegoptim
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5
shrinking /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5/bin/jpegoptim
gzipping man pages under /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5/bin
patching script interpreter paths in /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5
checking for references to /build in /nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5...
/nix/store/qldhz6lqamsv2pbdyimsgwdfc53bawyn-jpegoptim-1.4.5

Success on aarch64-linux (full log)
Attempted: jpegoptim
Partial log (click to expand)
/nix/store/c8bwnx988ckbw2igggv41s1mbd0v743m-coreutils-8.29/bin/install -c -m 755 jpegoptim /nix/store/jaxbw62injc26qkfgnwqxmswx060nj5n-jpegoptim-1.4.5/bin/jpegoptim
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jaxbw62injc26qkfgnwqxmswx060nj5n-jpegoptim-1.4.5
shrinking /nix/store/jaxbw62injc26qkfgnwqxmswx060nj5n-jpegoptim-1.4.5/bin/jpegoptim
gzipping man pages under /nix/store/jaxbw62injc26qkfgnwqxmswx060nj5n-jpegoptim-1.4.5/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/jaxbw62injc26qkfgnwqxmswx060nj5n-jpegoptim-1.4.5/bin
patching script interpreter paths in /nix/store/jaxbw62injc26qkfgnwqxmswx060nj5n-jpegoptim-1.4.5
checking for references to /build in /nix/store/jaxbw62injc26qkfgnwqxmswx060nj5n-jpegoptim-1.4.5...
/nix/store/jaxbw62injc26qkfgnwqxmswx060nj5n-jpegoptim-1.4.5

Success on x86_64-darwin (full log)
Attempted: jpegoptim
Partial log (click to expand)
/nix/store/ix13lzspi4vdn4wyn91l8vjl2dsfn0wa-coreutils-8.29/bin/install -c -d -m 755 /nix/store/jyqlnjjkwv06cmz4104yb59i16chkiqp-jpegoptim-1.4.5/share/man/man1
/nix/store/ix13lzspi4vdn4wyn91l8vjl2dsfn0wa-coreutils-8.29/bin/install -c -d -m 755 /nix/store/jyqlnjjkwv06cmz4104yb59i16chkiqp-jpegoptim-1.4.5/bin
/nix/store/ix13lzspi4vdn4wyn91l8vjl2dsfn0wa-coreutils-8.29/bin/install -c -m 644 jpegoptim.1 /nix/store/jyqlnjjkwv06cmz4104yb59i16chkiqp-jpegoptim-1.4.5/share/man/man1/jpegoptim.1
/nix/store/ix13lzspi4vdn4wyn91l8vjl2dsfn0wa-coreutils-8.29/bin/install -c -m 755 jpegoptim /nix/store/jyqlnjjkwv06cmz4104yb59i16chkiqp-jpegoptim-1.4.5/bin/jpegoptim
post-installation fixup
gzipping man pages under /nix/store/jyqlnjjkwv06cmz4104yb59i16chkiqp-jpegoptim-1.4.5/share/man/
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/jyqlnjjkwv06cmz4104yb59i16chkiqp-jpegoptim-1.4.5/bin
patching script interpreter paths in /nix/store/jyqlnjjkwv06cmz4104yb59i16chkiqp-jpegoptim-1.4.5
/nix/store/jyqlnjjkwv06cmz4104yb59i16chkiqp-jpegoptim-1.4.5


Define a Podspec

Background
We'll also want to deploy using CocoaPods
Description

Define SwiftUserDefaults.podspec to allow usage with CocoaPods.
Add a workflow for publishing if we are ready to make the repo public.
Add tests/validation for pods (library and example project)

Thanks @ryanpato! 🚀


Unable to build in VS2019

I noticed the .net version was bumped to 6.0. Any specific reason? The problems is that .NET6.0 isn't supported on anything older than VS2022 and I cannot upgrade to VS2022 for other reasons.
Wondering if the .NET5.0 target was creating some issue. Am trying to debug the app but can't run it from VS2019 for this reason.

Gotta keep up with the times :)
Suggested alternative, use VS Code 😀

Just as a note, changing the framework version to net5.0 and it works just fine with VS2019. Helps with backwards compatibility unless there is a specific need to target net6.0 :)

@rboy1 glad you found a resolution - will close this now


Update SVG Known Issues (and add SVG file/id column)

I noticed these show up in the KNOWN_ISSUES table but look fixed:
http://kjellmf.github.io/military-symbology-explorer/#/explore/10041010111213030000
http://kjellmf.github.io/military-symbology-explorer/#/explore/10061010111213030000
http://kjellmf.github.io/military-symbology-explorer/#/explore/10041000001204020000
http://kjellmf.github.io/military-symbology-explorer/#/explore/10061000001204020000
When you are updating this table, can you add a column with the filename or ID (even better link to SVG) that has the issue.
(I didn't want to update the table myself in case it wasn't the correct issue/svg/ID):

Thanks for the reminder.  Those have all been fixed.

Good deal - if those issues from that current table have all been addressed, then the only remaining known svg issue that comes to mind for me is the issue with the different/various reference sizes used for the control measure and weather points - is that issue being tracked somewhere in this repo (I remember discussing at length, just not sure where it is being tracked)?
Ex:
Small:
http://kjellmf.github.io/military-symbology-explorer/#/explore/10012500003217050000
Medium:
http://kjellmf.github.io/military-symbology-explorer/#/explore/10012500001808000000
Large:
http://kjellmf.github.io/military-symbology-explorer/#/explore/10012500002108000000
http://kjellmf.github.io/military-symbology-explorer/#/explore/10014500001902100000

Nope, its is not currently being tracked.  I'll write a CP this week to have those size differences fixed/addressed and submit it to DISA and we'll track it that way.
DISA will review it, as will the Service reps, and if they feel for some reason those sizes are appropriate, they'll let us know.  Otherwise, they'll know to fix them for Change 1.
I'll also add it to the svg issue doc when I update it to close those open statuses.

CP 031815-1 has been authored and submitted to cover these size issues and was Deferred by the SSMC at the SSMC/JSP 15-1 meeting.  DISA intends to bring this back up at a later date (the next meeting) after they have a chance to review the svg files and have their contract support back online.

Since this issue has been rectified (CP created and submitted), we can just track the CP.