[POAE7-2493]support orderBy and TopN pattern

What changes were proposed in this pull request?

support new patterns
Why are the changes needed?

suppoirt patterns:  partial TopN,  partial OrderBy ,   join+filter,  join + partialAgg
Does this PR introduce any user-facing change?

No
How was this patch tested?

UT
Which label does this PR belong to?

Per discussed, let's enable pattern registration in base classes and comment them out. Also in particular op test, let's add TODO comments explicitly mentioning they're commented out.

done.


Introducing LSOA to Cambridge and adding interactivity to the markers to show surrounding LSOAs

This change introduces the LSOA map of Cambridge with GP practices markers. It also adds interactivity to the map, where clicked on the marker shadows the surrounding LSOAs with popup of total population and maximum walking time.
Some work is still to be done:

Investigate gap in LSOAs
Algorithm to calculate surrounding LSOAs
Abstract LSOA loading and population calculation to library for reusability

Merged this and pushed back to main. Pull request is closed.


Add Lineage configuration

🗣 Description
Add Lineage configuration to enable automatic PRs from upstream.
Also did some light housekeeping in advance of the other changes that will be coming soon after Lineage is set up.
:eyes: Please verify that the correct upstream repo was selected.

Approved, although I'd prefer it if we went ahead and pulled in the upstream updates in this case, in order to get a PR with clean CI builds.

That's fair- I will go ahead and do that now.  Stay tuned.

Is this changed_when line here only to ensure idempotence? If so, you can tag the task with molecule-idempotence-notest as seen here.

It was, so I replaced it with the molecule-idempotence-notest tag in https://github.com/cisagov/ansible-role-pca-gophish-composition/pull/1/commits/30c03bd19c3e3d7523fb8633c1813bf20922e9b0.  Thanks!


select client certificate dialog

still missing:

styling
unit tests
e2e hookup

Pull Request Test Coverage Report for Build 1044

4 of 31 (12.9%)  changed or added relevant lines in 4 files are covered.
471 unchanged lines in 19 files lost coverage.
Overall coverage decreased (-2.8%) to 43.426%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/app/client/src/commands/uiCommands.ts
0
2
0.0%

packages/app/client/src/ui/dialogs/clientCertSelectDialog/clientCertSelectDialogContainer.tsx
2
4
50.0%

packages/app/client/src/ui/dialogs/clientCertSelectDialog/clientCertSelectDialog.tsx
0
9
0.0%

packages/emulator/core/src/utils/oauthLinkEncoder.ts
2
16
12.5%

Files with Coverage Reduction
New Missed Lines
%

testSetup.js
1
66.67%

packages/app/client/src/data/action/azureAuthActions.ts
1
83.33%

packages/app/client/src/data/action/endpointServiceActions.ts
1
83.33%

packages/sdk/shared/built/ipc/channel.js
1
85.71%

packages/app/client/src/ipc.ts
1
41.67%

packages/sdk/shared/built/utils/bot.js
1
94.12%

packages/app/client/src/platform/commands/commandServiceImpl.ts
1
44.44%

packages/app/shared/built/utils.js
1
53.13%

packages/app/client/src/data/editorHelpers.ts
2
0.0%

packages/app/client/src/data/action/connectedServiceActions.ts
4
50.0%

Totals

Change from base Build 1021:
-2.8%

Covered Lines:
3171

Relevant Lines:
6528

💛  - Coveralls


Supporting 0x514c : 0x8850

the device is a 3×3 with 2 knobs and bluetooth
Linux Info

Class
0
((Defined at Interface level))

Subclass
0

Protocol
0

USB Version
1.10

Vendor ID
0x514c

Product ID
0x8850

Speed
12 Mbit/s

Channels
0

Max. Packet Size
64

when i try it, i get the following errors
scofmb@scofmb-laptop:~/Downloads/src/ch57x-keyboard-tool$ RUST_BACKTRACE=full /home/scofmb/.cargo/bin/ch57x-keyboard-tool --vendor-id 0x514c --product-id 0x8850 led 0
thread 'main' panicked at /home/scofmb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ch57x-keyboard-tool-1.4.2/src/main.rs:196:14:
internal error: entered unreachable code: unsupported device
stack backtrace:
0:     0x58d8175f4252 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hffecb437d922f988
1:     0x58d817618d1c - core::fmt::write::hd9a8d7d029f9ea1a
2:     0x58d8175f223f - std::io::Write::write_fmt::h0e1226b2b8d973fe
3:     0x58d8175f4024 - std::sys_common::backtrace::print::he907f6ad7eee41cb
4:     0x58d8175f54db - std::panicking::default_hook::{{closure}}::h3926193b61c9ca9b
5:     0x58d8175f5233 - std::panicking::default_hook::h25ba2457dea68e65
6:     0x58d8175f597d - std::panicking::rust_panic_with_hook::h0ad14d90dcf5224f
7:     0x58d8175f5819 - std::panicking::begin_panic_handler::{{closure}}::h4a1838a06f542647
8:     0x58d8175f4726 - std::sys_common::backtrace::__rust_end_short_backtrace::h77cc4dc3567ca904
9:     0x58d8175f5584 - rust_begin_unwind
10:     0x58d817461985 - core::panicking::panic_fmt::h940d4fd01a4b4fd1
11:     0x58d81746fc6c - ch57x_keyboard_tool::open_keyboard::h1dbf727e80df639e
12:     0x58d81746d1fb - ch57x_keyboard_tool::main::h528d003de2047d0a
13:     0x58d817485d03 - std::sys_common::backtrace::__rust_begin_short_backtrace::h25fde1d23be9d262
14:     0x58d81747ff6d - std::rt::lang_start::{{closure}}::h069e3546c196ec5e
15:     0x58d8175ec263 - std::rt::lang_start_internal::h103c42a9c4e95084
16:     0x58d817470045 - main
17:     0x797b29c2a1ca - __libc_start_call_main
at ./csu/../sysdeps/nptl/libc_start_call_main.h:58:16
18:     0x797b29c2a28b - __libc_start_main_impl
at ./csu/../csu/libc-start.c:360:3
19:     0x58d817462035 - _start
What can i do to help supporting this mini keyboard?

In my case this model reports itself as 514c:8850, it's 3 columns, 4 rows and 4 knobs, 3 layers and bluetooth, with LEDs

Any help on this please?

I have a similar product with the same vendor and product id. When I try to set them with the utility it won't accept 514c as the vendor id:
error: Invalid value '514c' for '--vendor-id <VENDOR_ID>': invalid digit found in string

I have a similar product with the same vendor and product id. When I try to set them with the utility it won't accept 514c as the vendor id:
error: Invalid value '514c' for '--vendor-id <VENDOR_ID>': invalid digit found in string

Try '--vendor-id 0x514c'.


[Bug]: MudExDialog height not adjusting automatically

Contact Details
No response
What happened?
hello,
I switched from the standard dialog to the MudEx one, because I needed the ability to drag it.
In my dialog I have a MudTabs element and before the switch the height of the dialog was adjusting automatically depending on different heights of the tabs.
Now it stays at one height and even the dialog buttons are sitting higher and not at the bottom.

My options are:
var options = new DialogOptionsEx { DragMode = MudDialogDragMode.Simple, CloseOnEscapeKey = true, MaxWidth = MaxWidth.Medium };
Expected Behavior
same behavior as the standard dialog, automatic height adjustment
Screenshots
No response
Reproduction link
No response
What application type are you referring to?
ServerRendered
Custom Application Type
No response
MudBlazor.Extension Version
1.7.89
MudBlazor Version
6.20
What .net Version are you using?
.Net8
What browser are you using?
Chrome, Firefox
Sample Solution
No response
Pull Request
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

You are right. In general it should overwrite this behavior only with specific options like fullheight or resize etc. I will try to fix that.
But however you can easially workaround this by adding a class that contains "height: auto !important" to the dialog class.
    [Inject]
    MudExStyleBuilder _styleBuilder {get; set;}

    private async Task ShowSampleDialog()
    {
        DialogOptionsEx dlgOptions = new()
        {
            DialogAppearance = MudExAppearance.FromCss(await _styleBuilder.WithHeight("auto").AsImportant().BuildAsClassRuleAsync()),
            MaximizeButton = true,
            CloseButton = true,
            CloseOnEscapeKey = true,
            MaxWidth = MaxWidth.Medium,
            FullWidth = true,
            DragMode = MudDialogDragMode.Simple,
            DisableSizeMarginY = true,
            DisablePositionMargin = true
        };
        dialogService.ShowEx<SampleDialog>("Simple Dialog", dlgOptions);
    }

I've created a sample here: https://try.mudex.org/snippet/cawellazwMfSfQEx

I have noticed another similar issue, but I'm not sure, if its connected.
This just didn't occur with the standard dialog.
Sporadically the dialog opens up too low, so its title bar is at the middle of the page.
In this case I can just drag the dialog up a bit, but its still annoying.
Just in case this might be related to the workaround or another issue with the dialog itself, I thought to let you know.

Sorry for being annoying, but I had to switch back to the standard dialog again, because the MudEx one also doesn't adjust its width (for example on a phone or when simply making the browser smaller).
I would have assumed an Extension would retain the original functionalities and just add new ones or extend existing.

Width can changed with the same behavior, however your problem on resize of browser or viewport size is not width related the reason is the position. When using drag or resize dialog is made absolute. However I can easily change or add a setting to use the position as relative % values.

All I need is the original MudBlazor dialog with the added functionality of dragging it.
If you can make that happen, it would be great.

In general this is exactly the current situation but for drag and resize some css classes and ja style changes are working but it should easy to make them relatively. I will do it for the next version.

this is now done in MudBlazor.Extensions 2.0.7 Nuget


Lab E3 Content and Feedback

Missing Introduction section
Just thinking that the others have this section. What I feel is missing, is which copy of the app I am working on, I can see in the repo there is a folder and code for this, but the instructions do not reference this.

Just seen this, can this be in the instructions instead of a readme file?

Exercise 1 - Step 2 - Sample Documents
Should "working folder" contain a reminder in the introduction or lab start just so they know what this means.
Also, its "sampleDocs"

Exercise 2 - Step 1
You have moved away from inline code fragments to pointers to content in the repo (link to solution), what this intended?

Exercise 2 - Step 4 - Missing Step Completion Tick Box

Exercise 3 - Step 2
Is the comment in the screenshot intended, seems accidental?

THANKS very much!!
Fixed in https://github.com/microsoft/copilot-camp/pull/372


Migrate off CircleCI

We should use @tripodsan's workflow here https://github.com/adobe/remark-gridtables/blob/main/.github/workflows/main.yaml and disable the CircleCI build.

This seems to be done.


Typo + wording fix in README.md

Describe the pull request
I've found a typo in the main README.md and the sentence where it's located seems a bit off, so I fixed the typo and proposed a better wording!
Breaking changes ?
No

@kibotrel Thanks for your contribution, I don't see that when I reread the file


Dark mode

I use this app every single day for the last several months. My workflow has increased exponentially thanks to this amazing GUI! After several months of using it, my eyes get sore after a couple of hours due to the bright UI. I know supporting dark mode is not an important first issue, but it could be a nice enhancement.
Thank you for the wonderful work on this GUI!

Hey, Thanks for your feedback. It makes my day.
I gonna add dark mode this weekend. Hope it help :)


utils/process.py: ProcessRunner may discard output of a subprocess

Hi,
the following code in lib/symbioticpy/utils/process.py used to catch output of Symbiotics' sub-processes may discard some parts of it whenever the sub-process writes to the pipe and subsequently exits in the moment between the lines below are executed.
...
line = ProcessRunner.current_process.stdout.readline()
if line == b'' and ProcessRunner.current_process.poll() is not None:
...

One possible solution might be something like this:
diff --git a/lib/symbioticpy/symbiotic/utils/process.py b/lib/symbioticpy/symbiotic/utils/process.py
index 208dd1f..4c100f0 100644
--- a/lib/symbioticpy/symbiotic/utils/process.py
+++ b/lib/symbioticpy/symbiotic/utils/process.py
@@ -43,9 +43,8 @@ class ProcessRunner(object):
             msg = ' '.join(cmd) + '\n'
             raise SymbioticException(msg + str(e))

-        while True:
-            line = ProcessRunner.current_process.stdout.readline()
-            if line == b'' and ProcessRunner.current_process.poll() is not None:
+        for line in ProcessRunner.current_process.stdout:
+            if line == b'':
                 break

             watch.putLine(line)

Edit: Add possible solution.

Could you create a PR with the fix? Thanks!


When dragging cards, slots don't always detect hover correctly

Put 3 cards in a row in bucket
Pick up 1st card
Drag & hover over 2nd slot, card in 2nd slot shifts right to indicate hover
Continue dragging & hover over 3rd slot
2nd slot continues to think it's being hovered over

Implementation and visualisation of drop has changed, so this bug is no longer present.


Filter Condition Doesn't Support “=” ?

The filter condition in the Vearch Python SDK seems to include "=" as a filter option. However, after reviewing the document query code, it appears that Vearch filter does not support "=" and "LIKE".

Yes. It's on our todo list. Maybe a comment will make it clearer. I will add a comment.


#196 Init string handled with carriage returns or whitespace case

@hachi8833 @st0012  This PR aims to let special chars including \r, \t, \n, \v, \\ being interpreted

@Maxwell-Alexius I think there should be a better solution instead of replacing them one by one, I am also working on this.

@Maxwell-Alexius We should use Replacer instead of replace them one by one. It'll be more readable and performant. Reference


Reordering first spanish descriptions to follow changes in english

@vtamara why are you opening and closing your PRs?

Squashing didn't work first time.
Second time I found ortography error.
I hope this one is right

Please, make the changes in one PR, there is no need to open a new PR.

Thanks.

Great work, @vtamara - I'm looking forward to talking with you about our Spanish translation effort.


python3Packages.dask: disable tests requiring network

Motivation for this change
Build of python3Packages.dask is broken on master b/c it runs tests requiring network access.
Broken after #120310.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Duplicate of #120764, can you review that one?

Ah, thanks, didn't check.


Implement Quartz.net evaluation process

[ ] Set up Quartz.net job scheduler to pull database for submitted check engine evaluation processes and spawn off evaluation process for each queued item

no longer needed based on new approach


Add Lazy instance

This allows for recursive generators to be defined using fix, for types like JSON.

I'll just go ahead and merge this since I've checked that it behaves correctly - discovered that one has have to be a little careful defining generators with fix though, as unsurpisingly it will generate massive values if used inconsiderately.

You definitely need to use the sized generator, maybe more than that.


Add documentation for training your own version of Ultravox

Assuming someone wants to train a new version of Ultravox on a model of their choice, it would be great to have a basic set of instructions for doing so.

Farzad has updated the REAME to train custom Ultravox models, see: https://github.com/fixie-ai/ultravox/?tab=readme-ov-file#training


Export functionality

Thank you for this great tool, It's very handy for metrics sake but what I'm missing is the ability to export used javascript code. That way I could get rid of the 10 or so javascript that I'm currently using and minify the result.

Hi!
I'm not sure it would help you that much. For example, it would only extract what YOUR browser needs and delete some polyfills. It would also delete some user-activated code (i.e. onclick). It would delete some useful parts in if-then-else statements...
In my point of view, this functionality would be a lot of work for something not so useful.


Python: 3.1 What is type conversion?

Description :
What is type conversion in python?
Note :

Changes should be made inside the Python/ directory & Python branch.
Issue only for GWOC'21 contributors.
Issue will be assigned on a first come first serve basis, 1 Issue  ==  1 PR.
In the PR, keep this issue's title as your PR's title.

Must Follow : Contributing Guidelines & Code of Conduct before start Contributing.

can you please assign me (Documentation)

Can I try this!

I can contribute in this issue by any of three ways(Document, audio, video)... May I contribute???

@siddhi-244 AUDIO or VIDEO? You have to mention that.

@siddhi-244 AUDIO or VIDEO? You have to mention that.

Documentation

I would like to address this issue..via Documentation
@adityabisoi
Ashi Dubey(batch-5)

I would like to work on
Documentation and Video
Batch - 4
@adityabisoi

can you please assign me

@siddhi-244 AUDIO or VIDEO? You have to mention that.

Documentation

Doc is already take.

This issue is open for AUDIO and VIDEO contributions.

This issue is open for AUDIO and VIDEO contributions.

I can contribute as VIDEO @adityabisoi

I want to contribute, can I still contribute in some form ??

@adityabisoi I want to make a audio contribution for this task..Please assign it to me

I would like to address this issue...via Documentation or Video
@adityabisoi

i can contribute to this issue in form of audio or documentation
Subhoshree Pattnaik
python batch 1
@adityabisoi

I would like to contribute to this issue in form video @@adityabisoi

Hey @prathimacode-hub, I would like to work on this
Name - Dakshita Thakkar
Sno - 392
Type : Audio

I am interested to work with this issue (documentation)

I would like to contribute in documentation format

I want to contribute to this issue in the documentation format.

I would like to contribute to this issue in the form of Video
kindly please assign me this issue.
Thanks
Ishu khare
batch-1 (python)

@ankurg132 Is the mentor of this issue. Please reach out to him in case of queries.


[feat] Display Weeknumber

Displays the Weeknumber on the lefthand side:

This change is

cherry-picked ilmstudios fromObservable fix 5b75cdb73dec2bfe15f45787e3f172b2135505af


config global how it work?

hi boy
i want add global config so add this
Vue.component('star-rating', StarRating);
Vue.use('star-rating',StarRating, {
  'rounded-corners':true,
  'borderColor':'red'
});

or
import StarRating from 'vue-star-rating'
Vue.component('star-rating', StarRating, {
    'rounded-corners':true,
    'borderColor':'red'
  });

but don't work how add config global?
Tnx for help ...

I haven't set this up to allow a global config like that, it's usually better to declare these on the component itself. It may, however, be possible to extend the component by wrapping it in a Vue.extend() and then overridding the default props values.


Is onNonBranchLink() usable?

As the doc does not mention onNonBranchLink() and NonBranchLinkHandler() seems to be depreciated, I would like to ask if onNonBranchLink() is usable?
I've tried using it but the behavior is a little strange. It will be fired every onResume no matter if the app is opened through a deeplink (i.e. appname://).
If onNonBranchLink() is not suppose to be used, what should be the way to handle non-branch deeplinks? Perhaps using another plugin?

@chanphillip you can look in to this part of the doc on how to handle non-universal link.

Hello @chanphillip,
Ideally, onNonBranchLink() should never be called. This is a method to handle URI Schemes from other Cordova plugins which can interact with Branch URI Schemes.
When clicking on a Branch deep link, all deep link data should be retreived from the Branch.initSession(function(data) callback regardless of resume or deviceready:
Branch.initSession(function(data) {
  // read deep link data on click
  alert('Deep Link Data: ' + JSON.stringify(data));
});

Where you relying on the depreciated NonBranchLinkHandler() before? If so, I would like to know more (the steps, the use case, etc). It could be possible that the new onNonBranchLink() is not functioning correctly.
Best,

@chanphillip I am closing this ticket, feel free to reach out if you are still experiencing issues.


Add edit catalog image issue resolved

Description
On Add edit Catalog( product, category ) images placeholder adding issue is fixed

@akathuria289
Please resolve the conflicts

@akathuria289
Not working, the admin is not able to upload the product's image after merging this PR

@Sanjaybhattwebkul Please re-check

@akathuria289
Still not fixed, if we are uploading any image then there is a 404  error. Please find the screenshot Here

@akathuria289
Any update ?

@Sanjaybhattwebkul Please re-upload the screenshot URL

@abhishekkathuria
Not working, still getting 404 error, please find the screenshot Here

@abhishekkathuria
Any update?

@Sanjaybhattwebkul Resolved

@abhishekkathuria
Please resolve the conflicts

@abhishekkathuria
Please resolve the conflicts.

@abhishekkathuria
Any update?

@Sanjaybhattwebkul Resolved the conflict

Closing this PR as created new PR - https://github.com/bagisto/bagisto/pull/6649


Update CMake toolchains for alternative gcc/g++ names.

Remove compiler attribute in GHA when using CMake toolchain files.
Sometimes g++ compiler has g++ prefix or other times it has g++ suffix.

This PR is needed for #1126.


feat: true zero-downtime deployment with request draining

Changes:

Add --pre-stop-hook argument.
Describe in README how to setup a true zero-downtime deployment.

Notes:

Hook name "pre-stop" (instead of "before-stop") is inspired by watchtower hooks. This way other hooks can be named "post-stop" etc
I decided not to add other hooks yet - we will add them when somebody reports a need with a valid use case
I think it's better to implement draining with an explicitly written command in a hook, rather than a flag like --drain with the same implementation, so users can actually understand the process

Close #21, #32.

Thank you, @wowu. This looks fantastic! I'm looking forward to the rollout of this feature. 🚀


[draft - dual port SRAMs] - fixing dp ram configuration

AST provides 2 sets of configuration structs for dual port srams.
In current design a singlse set is connected to both SPI and USB devices.
After the fix each device gets a unique set of values.
Since top_earlgrey.sv is autogenerated, I'll need your help in implementing this simple fix in the hjson file.
thanks !

we have a deadlock:  CI fails because generated top_earlgrey doesn't match this top_earlgrey...

Hi @arnonsha - please see #18099.

Closing since implemented in https://github.com/lowRISC/opentitan/pull/18099.


Clean unused code and methods

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 72.364%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
5051

Relevant Lines:
6980

💛  - Coveralls

As part of issue #175


Fixes #12 (linked gradients with shared attributes)

I noticed @dirkschulze comment in the #12 bug about removing duplicating attributes, so I added this as a link to this bug.

LGTM


CSS in Extract Plugin messes up the modal dialog title styling in Brackets

(cc @ryanstewart @peterflynn).

Closing, apparently this only happens on my machine.


Windows Taskbar Right-click Context Menu Expansion

Description of the new feature / enhancement
Hello,
I got a suggestion,
Is that possible to add a feature to let user add items into the taskbar right-click context menu?

Scenario when this would be used?
right click short cut makes life easier
Supporting information
No response

/dup #25575


adding initial Dockerfile for SciPy 2024

As title

Use cd docs/docker && make && make run from the root of the git clone to build container and drop into a demo shell.

Looks like this is ready to go.  I'm going to merge and then ensure the latest docker container is available on DockerHub.


Running the deploy-admission-controller.sh script does not work

Hi,
I used the script to install the Kong Admission Controller in a GKE cluster and I get the following error:
time="2022-04-13T11:05:52Z" level=info msg="diagnostics server disabled"
time="2022-04-13T11:05:52Z" level=info msg="starting controller manager" commit=8990c5831546ff3b550393ba264afc37bef4e67d logger=setup release=2.3.0 repo="https://github.com/Kong/kubernetes-ingress-controller.git"
time="2022-04-13T11:05:52Z" level=info msg="getting enabled options and features" logger=setup
time="2022-04-13T11:05:52Z" level=info msg="getting the kubernetes client configuration" logger=setup
W0413 11:05:52.346644       1 client_config.go:617] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
time="2022-04-13T11:05:52Z" level=info msg="getting the kong admin api client configuration" logger=setup
time="2022-04-13T11:05:52Z" level=info msg="tag filtering enabled" logger=setup tags="[\"managed-by-ingress-controller\"]"
time="2022-04-13T11:05:52Z" level=info msg="configuring and building the controller manager" logger=setup
time="2022-04-13T11:05:52Z" level=info msg="Database mode detected, enabling leader election" logger=setup
time="2022-04-13T11:05:52Z" level=info msg="Metrics server is starting to listen" addr=":10255" logger=controller-runtime.metrics
time="2022-04-13T11:05:52Z" level=info msg="Starting Admission Server" logger=setup
Error: either cert/key files OR cert/key values must be provided, or none
Error: either cert/key files OR cert/key values must be provided, or none

openssl version
OpenSSL 3.0.2 15 Mar 2022 (Library: OpenSSL 3.0.2 15 Mar 2022)

k describe secret kong-validation-webhook
Name:         kong-validation-webhook
Namespace:    kong
Labels:       <none>
Annotations:  <none>

Type:  kubernetes.io/tls

Data
====
tls.crt:  1216 bytes
tls.key:  1704 bytes

k describe validatingwebhookconfiguration.admissionregistration.k8s.io/kong-validations
Name:         kong-validations
Namespace:
Labels:       <none>
Annotations:  <none>
API Version:  admissionregistration.k8s.io/v1
Kind:         ValidatingWebhookConfiguration
Metadata:
  Creation Timestamp:  2022-04-13T11:04:34Z
  Generation:          1
  Managed Fields:
    API Version:  admissionregistration.k8s.io/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
      f:webhooks:
        .:
        k:{"name":"validations.kong.konghq.com"}:
          .:
          f:admissionReviewVersions:
          f:clientConfig:
            .:
            f:caBundle:
            f:service:
              .:
              f:name:
              f:namespace:
              f:port:
          f:failurePolicy:
          f:matchPolicy:
          f:name:
          f:namespaceSelector:
          f:objectSelector:
          f:rules:
          f:sideEffects:
          f:timeoutSeconds:
    Manager:         kubectl-client-side-apply
    Operation:       Update
    Time:            2022-04-13T11:04:34Z
  Resource Version:  100912100
  UID:               18591da9-03e6-45bc-9303-dbe1dd27e7d1
Webhooks:
  Admission Review Versions:
    v1
    v1beta1
  Client Config:
    Ca Bundle: blablablaCg==
    Service:
      Name:        kong-validation-webhook
      Namespace:   kong
      Port:        443
  Failure Policy:  Fail
  Match Policy:    Equivalent
  Name:            validations.kong.konghq.com
  Namespace Selector:
  Object Selector:
    Match Expressions:
      Key:       owner
      Operator:  NotIn
      Values:
        helm
  Rules:
    API Groups:
      configuration.konghq.com
    API Versions:
      *
    Operations:
      CREATE
      UPDATE
    Resources:
      kongconsumers
      kongplugins
    Scope:  *
    API Groups:

    API Versions:
      v1
    Operations:
      UPDATE
    Resources:
      secrets
    Scope:          *
  Side Effects:     None
  Timeout Seconds:  10
Events:             <none>

I'm using the latest version of the script mentioned here: https://docs.konghq.com/kubernetes-ingress-controller/2.3.x/deployment/admission-webhook/#tldr
Can anybody point me in the right direction? How can I solve this?
Regards,
Andrei H.

Nevermind. I took a look at the changelog and there was a version from the 7th of April which solved this problem, as I was using version 2.3.0:
https://github.com/Kong/kubernetes-ingress-controller/blob/main/CHANGELOG.md#231
I took the latest yaml from github and redeployed and it works now (it's using version 2.3.1):
https://raw.githubusercontent.com/Kong/kubernetes-ingress-controller/main/deploy/single/all-in-one-postgres.yaml
Thank you,
Andrei H.


Move suggested API to individual endpoint files. Add document index.

Move suggested API to individual endpoint files
Add document index

This ROCKS! :+1:


[FEATURE] ViT with average pooling like ResNet

Is there any attempt on training ViT models with global average pooling like resnet models? If yes, what are the exact hyperparameters used to get the best performance when training on imagenet1k from scratch

@CharlesLeeeee there are already some there, but discussions for these sorts of q please.


Tiered storage for RocketMQ topics ？

The current topic compaction data and commitLog are kept on the broker, and topic compression scans commitLog for the latest offset.
I have two questions now

If a large number of topics are compressed, a large number of disk I/OS may be generated, reducing service availability.
commitLog stores old data and compressed files store the latest compressed data. In this case, if the compressed file is similar to the Stock ticker theme, you need to query the old data. Since rocketmq can only hold data for about 3 days, this is not sufficient in many scenarios. Do we need to implement hierarchical storage to offload old data to an external cheap storage medium such as gfs, hdfs, s3, etc. The broker only holds the previous ordinary messages and compresses them, while the old data in the compressed scenario is kept in external storage.

For example Just a simple demonstration interface through which to offload data
interface Offloader {
    void offload(Message msg);
    CompletableFuture<Message> readOffloaded(long messageID);
    void deleteOffloaded(long messageID);
}

This reduces broker pressure, and the latest messages that are read frequently can be stored in commitlogs, while messages that do not require read frequent but important can be stored in external storage, improving broker availability.

Hello, My understanding of your question is as follows
1: I understand that the server needs to support compression of topic data, which is reflected in the details before the offsetMap construction of [compact topic ](https://github.com/apache/rocketmq/wiki/ RIP-30-Support-Compaction-topic)

My understanding is assuming that the user has a topic that contains user actions used to train the recommender system, he may want to keep that data for a long time so that if the recommendation algorithm is changed, it is still rerun against the full user history. But in this case, there may be a need to have a place to persist managed-ledger metadata in pulsar to ensure that the query history consumes the cursor. I'm not sure if rocketmq needs to persist offset, subcription and other information, maybe it needs to be discussed further?


Hashbang routing

Route using hashbangs so we can live on github pages for a while.

This PR makes us github pages ready :)

Not sure I understand the necessity for the relative URLs for the assets, but otherwise :+1:

The relative urls aren't really necessary anymore. They were needed when hosting at http://caciviclab.github.io/disclosure-frontend-alpha/

@jnmarcus asked to remove the base-url which won't really be necessary going forward.


add prober to build and release the image/manifests

Summary

add prober to build and release the image/manifests

Fixes #283
Release Note

Documentation

maybe we can cut a patch release after this
thoughts @vaikas @priyawadhwa ?

A patch release would be great :)

I'm cutting a release right now. @priyawadhwa @cpanato


MessageTrait::setHeaders looses original header name casing.

According to the PSR-7 MessageInterface - Case-insensitive header field names, it states:

Despite that headers may be retrieved case-insensitively, the original case
MUST be preserved by the implementation, in particular when retrieved with
getHeaders().

However, the \Zend\Diactoros\MessageTrait::setHeaders method at Line 327 is performing a strtolower on each header name before writing the headers array to to the headers protected variable. In doing so, the original header names' case is lost, which appears to be in violation of PSR-7. If this is a violation and to be corrected, it will require changes to other header related methods as they are all assuming the normalization to lowercase for the names has been completed when accessing the headers variable.

@rbchasesc

…before writing the headers array to to the headers protected variable.

Sorry, this is wrong. Look at the next line:
https://github.com/zendframework/zend-diactoros/blob/bb833f8e92297be103bf6cd3fc25219474bbf0d0/src/MessageTrait.php#L327-L328
$headerNames !== $headers
See also:
https://github.com/zendframework/zend-diactoros/blob/bb833f8e92297be103bf6cd3fc25219474bbf0d0/src/MessageTrait.php#L20-L32

As @froschdesign notes, we do keep track of the original casing, and that casing is used when emitting or serializing headers. We normalize the names in $headers to allow simplified lookups, but store the originally provided values in $headerNames, which is used for representation.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_59f077d2-d1aa-419b-bd6f-d6e777ec35ed/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_59f077d2-d1aa-419b-bd6f-d6e777ec35ed.git

Docs Build status updates of commit ea8e8a4:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-UserAccountBuildPermissionInsufficientError] Owner v-alji no longer has Read permission of the repository https://github.com/VSC-Service-Account/docs-archive-test-source. It might be due to recent GitHub changes on SSO. Please ask the owner v-alji to logon to Docs Portal https://ops.microsoft.com once again. If it is not the case, please ask anyone of Admin permission of the repo to assign a new owner via Docs Portal https://ops.microsoft.com

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit ea8e8a4:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-UserAccountBuildPermissionInsufficientError] Owner v-alji no longer has Read permission of the repository https://github.com/VSC-Service-Account/docs-archive-test-source. It might be due to recent GitHub changes on SSO. Please ask the owner v-alji to logon to Docs Portal https://ops.microsoft.com once again. If it is not the case, please ask anyone of Admin permission of the repo to assign a new owner via Docs Portal https://ops.microsoft.com

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Anime Model Generation

Am I doing something wrong with the settings, or is this type of content just not generable?
Because, on one hand, with objects or characters that already have a sense of depth in the photo, I get good results. But as soon as I switch to a 2D style, anime, in this case, the proportions get really distorted, and the faces end up completely ruined and unrecognizable.
Examples with images and video:

https://github.com/user-attachments/assets/b2484baa-da96-4256-af18-65d3cbbb510c

https://github.com/user-attachments/assets/7c224263-30ed-4289-8ea3-5966d88feae6

https://github.com/user-attachments/assets/756b6969-ff8e-4265-afbc-d35992b38229

https://github.com/user-attachments/assets/9f81f1f0-17b6-4db9-905b-2cc33362f794

these still look pretty great to me for what this technology is.
but yes i'd assume that 2d images lack the extra information the model definitely uses to generate. i also haven't had much more detail than i see in your renders with humans so far. that's not exactly an easy case for 3d generation

these still look pretty great to me for what this technology is.
but yes i'd assume that 2d images lack the extra information the model definitely uses to generate. i also haven't had much more detail than i see in your renders with humans so far. that's not exactly an easy case for 3d generation

I hope it will be improved on this aspect, but as for the weapons, like this one:

https://github.com/user-attachments/assets/0967787e-185b-4e8b-9dfa-edc1354b4b53
I’m speechless, truly an amazing job


HR Section Submission

Please find that the following has now been completed:

Instances can be read from both text files and dictionaries
The relevant definitions of blocking pairs and stability are contained in the HRAbstract class
The resident-oriented algorithm exists and functions on correctly formatted input
The hospital-oriented algorithm exists and functions on correctly formatted input.

Thanks,
Ben

I didn't mean to close the request; oops!
I was just going to comment to let you know that the fixes have worked and that the SM and HR sections are ready for merging.


chore: changelog

Description of change
Changelog

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.693%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
10556

Relevant Lines:
11801

💛  - Coveralls


In Chinese typewriting mode, ` key is ignored by shortcut.

Does this issue occur when all extensions are disabled?: Yes/No
Yes

VS Code Version: 1.66.0-insider (Universal)
OS Version: macOS 12.2.1

Steps to Reproduce:

Switch to English typewriting mode and type `cmd + ``.
The terminal shows up.
Close the terminal panel.
Switch to Chinese typewriting mode and type `cmd + ``
The UI is no response, the terminal is not shows up.

@ekilzen do you mean ctrl+`?

@ekilzen do you mean ctrl+`?

Yes, sorry for the typo.

I find out when I toggle the typing mode, the value of 'Toggle Terminal' on watermark page is toggled between ctrl + ` and Unbound.

I took a screen record to present this issue:

Notice the IME indicator in menu bar and the key binding of toggle terminal.

Hey @Tyriar, this issue might need further attention.
@ekil1100, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue still exists.

@VSCodeTriageBot Issue still exists.

@Tyriar What information can I add to help solve this issue?

@ekil1100 I found add "keyboard.dispatch": "keyCode" in config resolve this problem.

@rebornix what would you expect the correct behavior is here? Does the Chinese IME use ` specially?

Think this is related to the keybinding system, not the terminal


Safety?

Hello, is it safe to use this extension? Chrome warning says it can access your data on your browser. Thanks

It is safe to use this extension.
The only thing it can do is reveal your password on cursor hover.

Hello, is it safe to use this extension? Chrome warning says it can access your data on your browser. Thanks


added tutorial notebook for vizgen mouse liver data

@cornhundred thank you so much, will go on and merge this!

Thanks @giovp 😀


#275 fix for Python3 and Gunicorn load config

Quick explanation, six does not exist anymore in gunicorn 20.x https://github.com/benoitc/gunicorn/tree/20.x/gunicorn, when comparing to 19.0 https://github.com/benoitc/gunicorn/tree/19.x/gunicorn


Replacing with "opaque box"

Per https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/b/black-box replacing with "opaque box"
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

@tdykstra @adegeo @KathleenDollard Do we have a resolution here?


Thumbnails broken for storage locations outside web root

If you create a new "Local" file storage location outside the website root thumbnails don't load. For example your website root is /var/www/html and you add a file storage location at /var/www/files.
The download URL does work and is correctly passed to the download_file single_page controller which proxies the content. However the thumbnail URLs are still formatted like http://yoursite/thumbnails/file_manager_listing_2x/9215/7782/4623/test.jpg.
If I symlink the /var/www/files folder to /var/www/html/files and edit my file storage location to include a relative path of /files the thumbnails work. The issue is now all my files are accessible by direct URL. Additionally this won't work with other backends like S3 unless the S3 Website hosting mode is enabled.

I was going through the source code and src/Entity/File/Version.php getThumbnailURL has no check to hasPublicURL() like getURL does. It also appears that controllers/single_page/download_file.php has no reference to thumbnails.
The solution looks to be building out the download_file or adding a view_thumbnail single_page controller and adding the hasPublicURL check to getThumbnailURL. What are your thoughts on this? If this looks good I'm happy to make a pull request with this fix.

Already fixed on develop, but not yet released.
https://github.com/concrete5/concrete5/pull/8159


[Performance] Optimize PositionImpl toString, compareTo and hashCode methods

Motivation
PositionImpl's toString, compareTo and hashCode methods aren't consistent with the style of performance optimized code used in Pulsar in a lot of hotspots.

String.format should be avoided in any performance optimized code.
compareTo was using Guava's ComparisonChain which creates object instances. It's better to avoid it in this case.
Objects.hashCode creates a new array instance on each call. that can be avoided.

Modifications

refactor toString, compareTo and hashCode methods to minimize object allocations

I've seen profile result above many times that ConcurrentOpenLongPairRangeSet#firstRange become a hotspot which calls PositionImpl#compareTo under the hood, this PR seem going to fix this.

LGTM


Incorporation of your TradeDealView into CQUI

Hello!
I wanted to ask if we could get your permission to add your TradeDealView into CQUI - with proper credits given, of course. Your implementation is simply the best - right now many of us are always replacing "our" version with the one that you made ^^ it would be wonderful to include it in the mod. Then we could also easier keep it up to date if updates happen.
Of course, it is totally understandable if this is not to your liking - I just figured I would ask :)
Best wishes!

sure, feel free to do what ever you want.
:)


Results not reproducible with fixed random seed.

While training the VarMisuse task with GGNN model, I have noticed that results are not reproducible even with the random seed fixed.
What I have done:

Fixed the random seed in VarMisuse_GGNN.json to any positive value (e.g., 1252).
Trained two models using python train.py GGNN varmisuse --data-path <my_data_path> --result-dir <my_result_dir>
What I expect:
With the same random seed, the results of training on the same dataset should be the exact same, reflected in the log files generated in the result dir.

What I get instead:
Different results, reflected in different training and validation accuracies and different numbers of epochs trained.
I was wondering whether this is an implementation error, or if there is a reason that fixing the random seed does not make results reproducible that I am overlooking.
Thank you!

Thanks for the report. I never realised this, but the VarMisuse task is special because it has an additional source of randomness, namely the parallel loading of data in https://github.com/microsoft/tf-gnn-samples/blob/master/tasks/varmisuse_task.py#L190. I never checked this explicitly, but this would explain a difference in results, as the training samples will be in a different order after data loading.
I'd suggest to check if this is indeed the source of the problem by flipping no_parallel in https://github.com/microsoft/tf-gnn-samples/blob/master/tasks/varmisuse_task.py#L168 to True.
If that resolves the issue, a proper solution would require to change _load_data to keep the order stable. The code is supporting the streaming case (because I stole it from another of my projects), but here the result just gets fed into a list on the consumer side, so it could be simplified to just use multiprocessing.Pool.map, which keeps the order stable.

Hi Marc! Thanks so much for the quick response. Unfortunately, even after flipping no_parallel to True, I still get different results. I've attached the run logs of two models I trained earlier today after making the change you indicated.
VarMisuse_GGNN_2020-08-13-10-17-26_32199.log
VarMisuse_GGNN_2020-08-13-10-52-02_32452.log


Do not show 0 in  tooltip when no value

Describe the bug
when using the line chart with more than one set of data the tooltip will show 0 if data is missing for a given x value.
To Reproduce
Steps to reproduce the behavior:
    <LineChart
      data={[
        { Spend: 200, date: 1, label: 'A' },
        { Spend: 400, date: 2, label: 'A' },
        { Spend: 500, date: 3, label: 'A' },
        { Spend: 500, date: 4, label: 'A' },
        { Spend: 500, date: 5, label: 'A' },
        { Spend: 500, date: 6, label: 'A' },
        { Spend: 300, date: 1, label: 'B' },
        { Spend: 600, date: 2, label: 'B' },
      ]}
      x={{ value: 'date' }}
      y={{ value: 'Spend', format: { currency: 'USD' } }}
      color='label'
    />

Expected behavior
If there is not a y value for a given x, do not show the item in the tooltip
Screenshots

This issue should be resolved now, no SDK update required. Thank you for your patience.


Improve Documentation

After reviewing the documentation, I believe there are several inaccuracies. Opening this pull request to propose some changes and make it easier for new users to get started.
Description
Improve the Documentation for Users Getting started
Issues Resolved

Inaccuracies or incomplete information in the documentation.

Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

I noticed several issues, so I'll work on pushing them up here to propose adjusting.
Thanks


Refactor slice.new to new style function

Also made the following changes:

Allowed slice to contain arbitrary objects
Implemented calling __index__ if slice property isn't an int

Codecov Report

Merging #767 into master will increase coverage by 0.08%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   61.95%   62.04%   +0.08%
==========================================
  Files          80       80
  Lines       12708    12730      +22
  Branches     2606     2610       +4
==========================================
+ Hits         7873     7898      +25
- Misses       3165     3166       +1
+ Partials     1670     1666       -4

Impacted Files
Coverage Δ

vm/src/obj/objrange.rs
61.8% <0%> (-1.27%)
:arrow_down:

vm/src/obj/objsequence.rs
54.68% <33.33%> (+0.19%)
:arrow_up:

vm/src/frame.rs
67.85% <60%> (-0.21%)
:arrow_down:

vm/src/obj/objslice.rs
76.38% <65.95%> (+12.92%)
:arrow_up:

vm/src/function.rs
48.18% <75%> (+0.81%)
:arrow_up:

derive/src/lib.rs
57.44% <0%> (+5.31%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c9181...a49895e. Read the comment docs.

It looks like rustfmt is the only thing failing, after that is fixed we can merge this

@skinny121 @OddCoincidence could we merge this PR? It looks like all review comments were dealed with?


Linters. Eslint.

Motivation and context
A written script for static code analysis using eslint of all files in PR.
For example:
To get the files into the commit, I added one EOF to the file from the cvat-* directory. Result: https://github.com/dvkruchinin/cvat/actions/runs/569756587
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Coverage remained the same at 70.794% when pulling 9ffec8a255f46002de5046bb2bfe1616eb437dd6 on dvkruchinin:dkru/linters-eslint-ci-check into daedff420404977226604090a1ebb8e45ed7367f on openvinotoolkit:develop.

@dvkruchinin Could you please investigate if it is possible to add a comment with a link to the published artifact?

@azhavoro

Could you please investigate if it is possible to add a comment with a link to the published artifact?

I'll spend some more time on this investigation. But I am becoming more and more convinced that this will have to be done as part of a separate task. Apparently, will need to write a script to interact with the github api and get a link to the artifact. I don't see any convenient tools for this.

What I found out.
Required data to get a link to an artifact

Ready-made url of the form URL_RUN_ID="https://api.github.com/repos/${{ github.repository }}/actions/runs/${{ github.run_id }}"
From it can read the link to the artifacts URL_ARTIFACTS=$(curl -s -H "Accept: application/vnd.github.v3+json" ${URL_RUN_ID} | jq '.artifacts_url') and check_suite_id value CHECK_SUITE_ID=$(curl -s -H "Accept: application/vnd.github.v3+json" ${URL_RUN_ID} | jq '.check_suite_id')
The next step - getting artifact id: ARTIFACT_ID=$(curl -s -H "Accept: application/vnd.github.v3+json" ${URL_ARTIFACTS} | jq '.artifacts[].id')
As a result, the link to the artifact takes the form https://github.com/${{ github.repository }}/suites/${CHECK_SUITE_ID}/artifacts/${ARTIFACT_ID}

The whole problem is that artifact id can get it only after the workflow is fully completed. Accordingly need a separate file to describe the workflow that would accept the input parameter for example ${{ github.run_id }}. To automatically start workflow to generate a link to an artifact, there are utilities such as workflow-dispatch
For which need to generate a GitHub access token (PAT) with write access to the repo due to restrictions ${{ secrets.GITHUB_TOKEN }} triggering-new-workflows. I think it might not be safe. And most likely will have to create all the development participants working with fork.


City nama as position

Is it possible to restrict position to evaluate only to cities? Now when I put in position city name it can evaluate to e.g. island with the same name :(
Appreciate any help.
Maras

no
you need to enter full address in this case instead of only city name. not "e.g., flower city", but "flower city, ON, Canada"


Log error on user output stream terminating with an error

Is it just me or would it not be more appropriate to log an error if the user stream terminates with an error?

This seems the a change for the best. :+1:


Custom Module Objective Message Duplication

What is your Quests version / build number (do not say "latest")?
4.8.3
Describe the problem and how to replicate it.
When given the objective for a quest that uses a custom quest objective the message is duplicated.
Any console errors to share?
No console errors but I assume it is an error with the Quest API

If applicable, can you provide an example quest from quests.yml?
ordered:
        '1':
          custom-objectives:
            custom1:
              name: Total Blocks Broken Objective
              count: 1
              data:
                Total: '150'
                Obj Name: This is doubled and shouldn't be
          start-event: a-mine-pickaxe
          delay: 2
          start-message: '&aMiner: &fLet''s start with the basics'

What caused your assumption that the Quests API is at fault? Have you reached out to the module developer?

My assumption is due to the fact that any built-in objectives do not have this duplication issue but any custom module whether it's another developer or the modules I made myself have this issue. I'd need to go back and check for the specific version but I'd like to note that reverting to previous versions of quests does solve the issue so it may very well not be Quests API (which is not very helpful for bug fixing I know). And regarding reaching out, as I said even my own modules don't work. Here is a simple example I used to check this to recreate the duplication issue on a fresh module:
package me.sir_draco;
import me.blackvein.quests.CustomObjective;
import me.blackvein.quests.Quest;
import me.blackvein.quests.Quester;
import me.blackvein.quests.Quests;
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockBreakEvent;
import java.util.Map;
public class BreakBlockObjective extends CustomObjective implements Listener {
private static Quests quests = (Quests) Bukkit.getServer().getPluginManager().getPlugin("Quests");
public AnyBreakBlockObjective() {
    setName("Break Blocks Objective");
    setAuthor("Sir_Draco");
    setShowCount(true);
    setCountPrompt("Set how many blocks to break");
    addStringPrompt("Total", "Set how many blocks to break", 1);
    setDisplay("Break %Total% Blocks (%count%)");
}

@EventHandler
public void onBlockBreak(BlockBreakEvent event) {
    Player p = event.getPlayer();
    Quester qp = quests.getQuester(p.getUniqueId());
    for (Quest q : qp.getCurrentQuests().keySet()) {
        int index = -1;
        for (int i = 0; i < qp.getCurrentStage(q).getCustomObjectives().size(); i++) {
            if (qp.getCurrentStage(q).getCustomObjectives().get(i).getName().equals(this.getName())) {
                index = i;
                break;
            }
        }

        Map<String, Object> m = getDataForPlayer(p, this, q);

        if (index > -1) {
            int total = Integer.parseInt((String) m.get("Total"));
            int count = qp.getQuestData(q).getCustomObjectiveCounts().getFirst();
            if (count < total) {
                incrementObjective(p, this, 1, q);
            }
            return;
        }
    }
}

}

I just tested and confirmed the bug does not exist using version 4.7.2 but does with version 4.8.x

Thanks for the clarification. The built-in objectives essentially use a different mechanism than custom ones, so this isn't too surprising. Now, it's possible I may have fixed this in 5.0.0-rc.1, so that's what I'll be using to proceed with testing. Note that the documentation hasn't been updated yet, but I'll keep you abreast of this as well.

So I wasn't able to replicate this on 5.0.0-rc.1 using any of my modules nor your example. Could be an issue with older versions. I've updated your code for 5.x here, although it doesn't work as expected because you're using addStringPrompt as a secondary count prompt, which isn't what it's intended for.
package me.sir_draco;

import me.pikamug.quests.BukkitQuestsPlugin;
import me.pikamug.quests.module.BukkitCustomObjective;
import me.pikamug.quests.player.Quester;
import me.pikamug.quests.quests.Quest;
import org.bukkit.Bukkit;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockBreakEvent;

import java.util.Map;
import java.util.UUID;

public class BreakBlockObjective extends BukkitCustomObjective implements Listener {
    private static final BukkitQuestsPlugin quests = (BukkitQuestsPlugin) Bukkit.getServer().getPluginManager().getPlugin("Quests");

    public BreakBlockObjective() {
        setName("Break Blocks Objective");
        setAuthor("Sir_Draco");
        setItem("DIAMOND_PICKAXE", (short)0);
        setShowCount(true);
        setCountPrompt("Set how many blocks to break");
        addStringPrompt("Total", "Set how many blocks to break", "1");
        setDisplay("Break %Total% Blocks (%count%)");
    }

    @EventHandler
    public void onBlockBreak(BlockBreakEvent event) {
        if (quests == null) {
            return;
        }
        UUID uuid = event.getPlayer().getUniqueId();
        Quester qp = quests.getQuester(uuid);
        for (Quest q : qp.getCurrentQuests().keySet()) {
            int index = -1;
            for (int i = 0; i < qp.getCurrentStage(q).getCustomObjectives().size(); i++) {
                if (qp.getCurrentStage(q).getCustomObjectives().get(i).getName().equals(this.getName())) {
                    index = i;
                    break;
                }
            }

            Map<String, Object> m = getDataForPlayer(uuid, this, q);

            if (index > -1) {
                int total = Integer.parseInt(m.get("Total").toString());
                int count = qp.getQuestDataOrDefault(q).getCustomObjectiveCounts().getFirst();
                if (count < total) {
                    incrementObjective(uuid, this, q, 1);
                }
                return;
            }
        }
    }
}


Fix build errors

Fix include path for providers
std::optional requires C++17
std::unary_function is removed from C++17
Fixes https://github.com/microsoft/onnxruntime/issues/13058

The build failures are expected. I will refactor the pipelines to let them fetch bits from our ORT-Nightly feed to fix the issues.


event logging changes

add std logger foundation to event_logger
log event for CSV export
change "log_this" to more self-documenting "log_requests"
add LoggingConfigurator type for user-definable log configuration

CATEGORY
Choose one

[ ] Bug Fix
[X] Enhancement (new features, refinement)
[ ] Refactor
[X] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
Current incarnation of "event logger" is an "abstract base class", but in practice its usefulness is tightly coupled to the DBEventLogger implementation, which in turn is tightly coupled to a mandatory db migration ('logs' table). The base class itself has a completely untyped interface (args and kwargs), but the DBEventLogger impl relies on very specific (but not codified-via-interface) kwargs to be in the incoming messages.  Those kwargs are put there by the log_this decorator which is scattered across the codebase, which means that if you have DBEventLogger configured you can't actually use this AbstractEventLogger outside of the log_this decorator unless you know the specific schema that the DBEventLogger expects to find in the untyped args and kwargs data it receives (which are very request-logging specific fields).
This change is a first step to move logging towards a standard logging based approach with clearer data types with crisp responsibilities surrounding the logging of various event types, and brings the following changes:

all incoming events are logged to a configured superset_events logger
log_this is renamed to log_requests to more clearly document what it is passing and persisting to the DBEventLogger, and now is logging an event through event logger prior to sending to DBEventLogger
LoggingConfigurator is added to allow local installations to configure a custom handler for events
query logger is now logging a query event to to event logger prior to calling the configured query logger
CSV export is writing a csv_export event to logs

Future work:

move log_requests out of AbstactEventLogger base and into its own decorator type which can use an event logger to log events, meaning we can also remove the existing call to log method (leaving only log_event call)
turn DBEventLogger into a logging.Handler impl that looks for endpoint_invocation events and does the db persistence that it does today
migrate AbstractEventLogger to EventLogger after
remove QUERY_LOGGER, that can be handled by registering logging.Handler impls that act upon incoming query event types.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@mistercrunch @betodealmeida @john-bodley @graceguo-supercat @dpgaspar

I submitted #8085 as a more tactical change to unblock what we need to audit CSV exports, we can revisit the broader changes here a bit later, perhaps more incrementally.


Using select2 in a unique way

HI,
I am using select2 in a unique way! I need to use to do an ajax search from 17K fields... if one is not found I am using the  select2 'tags: true'  to add that will add it as a new field. I have this all working in the background but for some reason select2 only works sometimes with the taging function.... It mainly fails when a field has not been found and I want to use the fall back function of the tags and I am not sure why...
I know it is possible (because I have done it now) but it seems to not use the tag method on occasion defaulting back to the placeholder text. I am just wondering if anyone else has experienced this.
Also, is it possible to link out from the list (li) div that select2 creates without activating the select?
Thanks in advance. This is a great project!

This appears to be more of a usage question than a bug report or common feature request.  As we continue to keep the Select2 issue tracker geared towards these two areas, bug reports and common feature requests, we are redirecting usage questions to other communities such as the mailing list, IRC, or Stack Overflow.


v-model on checkbox producing typing error when used with true-value and false-value

Vue version
3.2.45
Link to minimal reproduction
https://sfc.vuejs.org/#eNpNUEFSwzAM/IrGl8IMSe4lzQxv4OpLmiipiy17bDnQCfk78oRCfZLW0u5qV/UWQr1kVEfVMrpge8ZOE8hrQ/eOFgc2no6wrsB+ni3CtrVNuM8YCplhqZwf0Z602me0Ar4FlH644PBx9l8FiRmrpbe54DdMAk29Tf8YeYEaYW6bByvSpiGawGB7motE2UzIuZjQZFzwkWGFiBNsMEXv4CAXHV41DZ4S332fykSbOBqa4RsyjTgZwrF7+iufZafI74JCr17Uzl+5PtTX5EmCWsvt+vdDzEg4expaiW7ptbowh3RsmjQNJd5rqn2cG6nqmImNwxqTq87RfyaMQqxVodg0bWr7AeznjLA=
Steps to reproduce
Following the directions for true-value and false-value checkboxes, the v-model property warns of an incorrect type.
What is expected?
The true-value and false-value property type should influence the expected types of the v-model property.
What is actually happening?
The v-model property is restrict to https://github.com/vuejs/core/blob/e340add5a541df5d6563e24b11551b0d161d2f38/packages/runtime-dom/types/jsx.d.ts#L474
System Info
No response
Any additional comments?
This was first reported at https://github.com/johnsoncodehk/volar/issues/2341. The suggested solution fixes the type error, however it then prevents utilising const toggle as a string in the script.

https://github.com/vuejs/core/blob/7d0c63ff4361e59e820441a24bf4fb2a93335a1e/packages/runtime-dom/src/directives/vModel.ts#L251
getCheckboxValue define _typeValue and _falseValue type is _trueValue?: any _falseValue?: any
https://github.com/vuejs/core/blob/c6eb3ccccee8e43e7aafcbc3c9ededecc565fdf0/packages/runtime-dom/src/patchProp.ts#L52
that mean's true-value and false-value is any type of data
https://github.com/vuejs/core/blob/7d0c63ff4361e59e820441a24bf4fb2a93335a1e/packages/runtime-dom/src/directives/vModel.ts#L159
https://github.com/vuejs/core/blob/7d0c63ff4361e59e820441a24bf4fb2a93335a1e/packages/runtime-dom/src/directives/vModel.ts#L153
Input v-model actual value is _modelValue, toggle's type should be the same as _modelValue type, no same as checked.
So I think this is a volar type checking problem.

So I think this is a volar type checking problem.

@johnsoncodehk cc

See: https://github.com/vuejs/language-tools/pull/2417

See: https://github.com/vuejs/language-tools/pull/2417


Design System: Add Checkbox component

Summary
Adds a checkbox component to the design system.
Designs
Relevant Technical Choices

stuck with the normal browser api to get all the accessibility features of the input tag rather than using a 3rd party library
hides the checkbox with visibility: none so that we can style it
didn't need to test any events since it's just a normal checkbox

To-do
none
User-facing changes
none
Testing Instructions

run storybook
go to Design System -> Components -> Checkbox

General demo

Active from focus state

Fixes #4940

So this works with the keyboard too and is announced as a checkbox to screen readers?

So this works with the keyboard too and is announced as a checkbox to screen readers?

Yeah! It's tab-able and screen readers announce it as a checkbox. Added the checkbox to the dashboard and used voice over with safari to get this gif:

Yeah! It's tab-able and screen readers announce it as a checkbox. Added the checkbox to the dashboard and used voice over with safari to get this gif:

Current state of checkbox story:

Current state of checkbox story:

Fixed the problems we were seeing. Now the checkboxes are beautiful and there are no lint errors 🥳

Fixed the problems we were seeing. Now the checkboxes are beautiful and there are no lint errors 🥳

Got them updated! Now they look like this:

Got them updated! Now they look like this:


#doSearch breaks stencil js rollup build

Hi,
I am using alasql in a Stencil component project. After updating alasql from 1.x to 4.x the build is not working anymore.
Rollup: Plugin Error Unexpected token (5358:2) in /Users/sven/Projects/test/alas/node_modules/alasql/dist/alasql.js (plugin: commonjs, transform)
The unexpected token is the # in 35search. What is the # good for?
https://github.com/AlaSQL/alasql/blame/eaa0b902eccb219ad3fb9df72a0c468abada2571/src/35search.js#L50

Certainly! In JavaScript, the # symbol is used to denote private class fields. It was introduced in ECMAScript 2019 (ES2019) as part of the ES6 (ECMAScript 6) specification.
A private class field is a class member that can only be accessed from within the class itself. It is not accessible outside of the class, including from instances of the class or other external code. This helps in encapsulating implementation details and provides a way to hide internal state or functionality of a class.
Here's an example to illustrate the usage of private class fields:
class MyClass {
  #privateField;

  constructor() {
    this.#privateField = 10;
  }

  #privateMethod() {
    console.log('This is a private method.');
  }

  publicMethod() {
    console.log('This is a public method.');
    console.log(this.#privateField);
    this.#privateMethod();
  }
}

const myInstance = new MyClass();
myInstance.publicMethod(); // Output: This is a public method. 10 This is a private method.
console.log(myInstance.#privateField); // Error: SyntaxError: Private field '#privateField' must be declared in an enclosing class
myInstance.#privateMethod(); // Error: SyntaxError: Private field '#privateMethod' must be declared in an enclosing class

In the above example, the MyClass has a private field #privateField and a private method #privateMethod. These private members are denoted by the # symbol preceding their names.
Inside the class, the private field and method can be accessed just like any other class member. However, outside of the class, attempts to access the private members will result in syntax errors.
The # symbol is used to establish a convention that certain members of a class should be treated as private, indicating that they are intended for internal use and should not be accessed or modified directly from outside the class.

all green env / browser supports this today, but old build system might not... it might be worth it if you update your own dependencies.


CMP extension to OpenSSL, incremental PR chunk 1: CRMF API

Certificate Management Protocol (CMP, RFC 4210) extension to OpenSSL.
Also includes CRMF (RFC 4211) and HTTP transfer (RFC 6712).
CMP and CRMF functionality added to libcrypto, and the cmp app to the openssl CLI.
Adds extensive man pages and tests.  Integration into build scripts.
Incremental pull request as suggested by @mattcaswell: https://github.com/openssl/openssl/pull/6811#issuecomment-409893939 and recently agreed by email.
Initial chunk consists of the CRMF API
as declared in the header file include/openssl/crmf.h
and its documentation in doc/man3/OSSL_CRMF_*.pod
Checklist

[x] documentation is added or updated
[ ] tests are added or updated

The next chunk is going to be the CRMF implementation, after we have received reviewers' feedback on the CRMF API and dealt with it.

The CI build errors are just due to include/openssl/crmferr.h and the implementations of the functions in include/openssl/crmf.h not yet being part of the PR.

We have meanwhile reacted to all of Matt's review comments and provided an update with our respective fixes.

Pleased to hear.
I can squash all hitherto commits into one, will this help?

I can squash all hitherto commits into one, will this help?

Yes - lets do that.

Oops, I had overlooked your swift response.
Just did the squashing; in this branch there were anyway just two commits regarding the CRMF API.

Still looking for a second reviewer for this. Ping @openssl/committers

I've meanwhile provided the code portion of the CRMF implementation as the second commit.

I've meanwhile provided the code portion of the CRMF implementation as the second commit.

Personally I would remove that commit until such time as @bernd-edlinger has finished reviewing what is currently there. And then I would create it as a different PR with both the commits from here and the implementation commits so that we have a clear separation of the review history and we know exactly what is in scope for review at any one time.

All right, I will retract the second commit soon.
(I'm just curious to wait and see if besides the successful Travis CI build also the AppVeyor build will succeed).

@Bernd, thank you for your review of the CRMF API and doc.
My above commit addressed all your improvement hints. Is this now fine for you or do you see anything else that we should improve before we provide the actual CRMF code?

Nice that we meanwhile have both approvals :)
I've just provided the second chunk of our incremental PR in #7646.

I've just applied the "hold" label on this, so that no one attempts to merge it until chunk 2 is also ready.

Now that #7646 is approved, I pushed this one.


Allow editing entries

https://github.com/toaq/toadua/assets/16232127/0ec0fd35-ed2d-4471-887c-c2baf4180a98

(And deployed!)


RkModalImage zoom and pan feature

Hi, this is a great ui library and I like it so much.
I would like to propose an enhancement.
In RkModalImage would be nice to have the opportunity to zoom an pan the image.
I apologize in advance for my bad english.

Hello @makafuji.
Thanks for a proposal.
Sounds like a good idea.

+1: A gallery with pan/zoom would make my day (looking at how many other projects struggle with it, there may be dragons though!)

@makafuji @hardcodet
Glad to introduce you this feature in RkGalleryImage :)

Hi there! The ability to zoom in RKGalleryImage doesn't really solve the raised issue… I would also like to zoom in RKModalImage as we don't want to use a gallery instead.
Thanks!

Hi @willwright82 ,
If you don't want use gallery, you can just use RkGalleryImage, like you previously used RkModalImg.

Oh right, thanks @artyorsh!!


Cannot open include file: 'absl/strings/string_view.h

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version:
Python version:
Installed using virtualenv? pip? conda?:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

Describe the problem
Provide the exact sequence of commands / steps that you executed before running into the problem
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

@penghao1990 ,
Can you please fill details in the above mentioned template.
Also In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here.
Provide the exact sequence of commands / steps that you executed before running into the problem.Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Redirecting SMB Guest Logon enablement

Pull request guidance
Thank you for submitting your contribution to our support content! Our team works closely with subject matter experts in CSS and PMs in the product group to review all content requests to ensure technical accuracy and the best customer experience. This process can sometimes take one or more days, so we greatly appreciate your patience.
We also need your help in order to process your request as soon as possible:

We won't act on your pull request (PR) until you type "#sign-off" in a new comment in your pull request (PR) to indicate that your changes are complete.

After you sign off in your PR, the article will be tech reviewed by the PM or SME if it has more than minor changes. Once the article is approved, it will undergo a final editing pass before being merged.

@Xelu86 The article is an important support article and cannot be redirected out.

The article was redirected. Thanks.


[BEAM-828] BigQueryIO: Remove tempLocation usage at pipeline construction time

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify.
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

No semantic changes, just moves tempLocation access to runtime.

CC: @jkff @kennknowles (two tests still fail, will make reviewers once fixed, but feel free to comment).

Changes Unknown when pulling 5fb993614233d0d2d9d3b0dc46db53b4defe2b10 on vikkyrk:bq_templocation into ** on apache:master**.

Coverage remained the same at 70.64% when pulling fd808da13972d1ad8ff3f2ebe406997fb331f689 on vikkyrk:bq_templocation into a1d82c20323c5abf05dad9c877fc4622db91d253 on apache:master.

Done

run Java PostCommit

Coverage decreased (-0.01%) to 70.55% when pulling c318ec6e3ebe276eea9c7e5c03db18ddebf93515 on vikkyrk:bq_templocation into 1bc50d627289e6cbce617424744628a8cda4c52a on apache:master.

Coverage decreased (-0.003%) to 70.557% when pulling c318ec6e3ebe276eea9c7e5c03db18ddebf93515 on vikkyrk:bq_templocation into 1bc50d627289e6cbce617424744628a8cda4c52a on apache:master.

Coverage decreased (-0.007%) to 70.554% when pulling c318ec6e3ebe276eea9c7e5c03db18ddebf93515 on vikkyrk:bq_templocation into 1bc50d627289e6cbce617424744628a8cda4c52a on apache:master.

The test failures were known flakes.


1/0 hangs R

The fundamental problem is the server is sending bad json to the client.
it's very unfortunate that json does not support Infinity and Nan and eventually we will have to work around that.
In the meantime though I don't think adding quotes is a good idea because even correct values are changed by this.  pretty much all json results are altered.
I think a better approach for this bug is to avoid crashing the client on bad json.
this is the cometd library parsing the response:
  this.convertToMessages = function (response)
    {
        if (org.cometd.Utils.isString(response))
        {
            try
            {
                return org.cometd.JSON.fromJSON(response);
            }
            catch(x)
            {
                this._debug('Could not convert to JSON the following string', '"' + response + '"');
                throw x;
            }
        }

we should catch this error and so if there is any json problem from the server we should report and show it, instead of crashing the client.
furthermore, it looks like cometd has kindly set up its parser to be a hook that we can replace it with one that accepts Infinite and nan.  That would be ideal.

Python and Groovy seem to work fine:
https://pub.beakernotebook.com/publications/12bad6c4-9150-11e6-b118-5396e5a7b835


Move fill with nans dispatch

This PR makes fill_with_nans! itself do dispatch, so that it doesn't show up in the inference dict.

bors r+

bors r+


outbound connection limit mentined is not accurate

[Enter feedback here]
https://docs.microsoft.com/en-us/azure/azure-functions/functions-scale#service-limits
It says
Document says Max outbound connections "Unbound" for the "App Service Plan" & "Premium Plan"

But essentially it has a limit.. as discussed here https://github.com/projectkudu/kudu/wiki/Azure-Web-App-sandbox#numerical-sandbox-limits

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06436739-8586-23b1-6b69-1960e93c26be
Version Independent ID: 8f7abfae-cf6d-56cb-1d20-f02041a6f6d9
Content: Azure Functions scale and hosting
Content Source: articles/azure-functions/functions-scale.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Hi @anilpras - Thank you for your feedback! We will review and update as appropriate.

@anilpras I believe you're referring to the VM limits and you're right that there would be an eventual limit as per the Kudu doc (which can then be reasoned separately with your unique architecture and scale strategy) but the detail communicated on the doc above is still correct in the context of how outbound connection limit applies to a Function app instance.
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Feat/terraform docs

feat: terraform doc gen action based on terraform docs, with pinned hard version.  Action does following steps:

Checks if README.md exists.
If it does - action validate if delimiters are added and placed correctly  ( BEGIN should go before END).
If delimiters found but placed in wrong order action will fail.
If no delimiters found in existing README - they will be added at the end of file with info comment.
If no README.md found - doc action will generate new one and commit to PR.

Action runs on Github own runner  so we don't need run 3rd part pinned version on own hosted runners ( Kind of security measure )

Test run on TF MOD

Looks awesome!
What happens when a commit is pushed? A new PR workflow is scheduled and ran?

Yes. When branch is updated so everything runs again. Test are done and we make sure that they are green. If everything is OK there, then we run terraform docs again and see if there are any changes to README.md that need to be pushed.


🍒 Cherry pick PR #12722 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/12722 to staging 🍒

🚀 Cherry-picked to staging by @OSBotify in version: 1.2.27-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @roryabraham in version: 1.2.27-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


chore(ci): add python 3.13 to the ci test suite

What kind of change does this PR introduce?

Update CI https://blog.python.org/2024/10/python-3130-final-released.html

Please don't make CI changes feat as this will bump the project version and no code has changed in the project. CI changes should always be chore.


Correct spelling of Kourend in minecarts.tsv

Just came across this one, did not affect game play in any way (pure visual "bug").

A small rebase to keep the "no-newline-at-eof" style consistent with the rest.

Thank you!


What is the purpose of parameterless AddCors method?

I can register cors services without configuring policies:
services.AddCors()

What actually happens under the covers?
Could you add the explanation to this article, please?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 59bca5db-1196-2a8b-a0d8-4e89b2382288
Version Independent ID: d3f332c4-4c60-039e-0e1e-bc6b11831f87
Content: Enable Cross-Origin Requests (CORS) in ASP.NET Core
Content Source: aspnetcore/security/cors.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Via https://docs.microsoft.com/en-us/aspnet/core/security/cors?view=aspnetcore-2.2#enable-cors-with-attributes

@Rick-Anderson  Sorry, but it didn't become clearer =(
There are overloads for both UseCors and AddCors methods which do not accept any parameters. In code snippets 'AddCorsis always called with policies configifuration.UseCors` is called differently.

@pranavkm  what's the purpose of register cors services without configuring policies:
services.AddCors()

It's meant for scenarios where the application specifies a custom policy provider that isn't backed by CorsOptions.

@Rick-Anderson , would be nice to capture that in docs ;-)

@pranavkm OK if I add that to the doc?

Writing a custom policy provider isn't common and we don't expect most users to write one. AddCors is just as usable if you separately register the options type later. It's also usable if you write middleware that expects users to separately configure CORS. There could be others I'm not aware of.
I'd be happy to entertain documenting it if it were part of a coherent document that says if you were doing this scenario and happen to require CORS, here's what you would need to do. But adding docs that says you might use this overload in these non-exhaustive cases is helpful to anyone.

Thanks @pranavkm . This issue is very discoverable and will serve as the documentation.

@Rick-Anderson
In ConfigureServices I an write:
services.AddCors(options =>
{
    options.AddDefaultPolicy(builder => builder.AllowAnyOrigin().AllowAnyMethod());
});

and in Configure:
app.UseCors(builder => builder.AllowAnyOrigin().AllowAnyMethod());

I still do not get how do these calls relate to each other. They seem to do the same thing. Or not?

@voroninp  you're calling AllowAnyOrigin().AllowAnyMethod() off two different methods.

This discussion makes me feel like this guy =)

off two different methods?

Yes, UseCors and AddCors. But what is for what? How does semantic of these calls differ? In both cases I am working with PolicyBuilder. Which call do I need when?

It's been a long time, but I found this issue because I have the same questions as @voroninp.


A long overdue PyTorch version is here

@XingangPan
It is now 2021, SCNN (proposed over 3 years ago) has become the classic method for lane detection and still pose a challenge to SOTA methods. But the old torch7 code and matlab evaluation is just not enough for the community anymore. So we have been working on a unified lane detection codebase, and have now re-implemented a PyTorch version of SCNN (https://github.com/voldemortX/pytorch-auto-drive) on 6 different backbones (VGG16, ResNet18/34/50/101, ERFNet) and achieved better results than originally reported in the paper (we attribute the improvements mainly to large batch size, better pre-trained weights, larger learning rate with warmup). For instance, we find VGG+SCNN can reach 74.29 F1 score on CULane, almost 3% higher than the paper result. More results are available in our model zoo.
Although we could not get the TuSimple competition performance (96.53%) from VGG + SCNN training on the train set alone, we assume that is normal since it was indeed a competition.
This can help researchers who use Python/PyTorch to ease reproduction efforts: #117 #70 #69 #58 #6
We would also be providing visualization tools and fair FPS tests across methods, which can help issues like this: #20
Maybe you could add a link to our PyTorch version in README.md to help promote the codebase?
p.s. We use python to map predictions to lanes, there is no need for matlab anymore.

@voldemortX Thanks for your efforts. Your pytorch-auto-drive code base looks great! It's glad to know that your reproduction obtains even better results. I have added the link in README.md.

Thanks a lot for your support!


no_std support

I am looking at using one of the upstream dependents of this library on a no_std target. Is there any appetite to support that use case? The following git patch enables allows no-std builds when the package is brought in with default-features = false. I don't believe it would be a breaking change unless a package was already declaring default-features = flase for some reason and depends on functionality I ended up placing behind the std feature flag.
Subject: [PATCH] no_std support added

---
 Cargo.toml    |  6 +++++-
 src/debug.rs  | 12 ++++++++----
 src/lib.rs    |  2 ++
 src/traits.rs |  2 ++
 4 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index cb377fc..8bd6131 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -12,4 +12,8 @@ categories = ["parsing"]
 readme = "README.md"

 [dependencies]
-nom = { version = "7.0", default-features = false, features = ["std"] }
+nom = { version = "7.0", default-features = false, features = ["alloc"] }
+
+[features]
+default = ["std"]
+std = ["nom/std"]
diff --git a/src/debug.rs b/src/debug.rs
index ec8977b..74e80cb 100644
--- a/src/debug.rs
+++ b/src/debug.rs
@@ -1,11 +1,15 @@
 //! Helper functions and structures for debugging purpose

-use nom::combinator::{map, peek, rest};
-use nom::HexDisplay;
-use nom::IResult;
-use std::fmt;
+use alloc::{format, vec::Vec};
+use core::fmt;
+#[cfg(feature = "std")]
+use nom::{
+    combinator::{map, peek, rest},
+    HexDisplay, IResult,
+};

 /// Dump the remaining bytes to stderr, formatted as hex
+#[cfg(feature = "std")]
 pub fn dbg_dmp_rest(i: &[u8]) -> IResult<&[u8], ()> {
     map(peek(rest), |r: &[u8]| eprintln!("\n{}\n", r.to_hex(16)))(i)
 }
diff --git a/src/lib.rs b/src/lib.rs
index 8d23249..aa0def1 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -30,7 +30,9 @@
     unused_import_braces,
     unused_qualifications
 )]
+#![cfg_attr(not(feature = "std"), no_std)]

+extern crate alloc;
 pub mod combinator;
 pub mod debug;
 pub use macros::*;
diff --git a/src/traits.rs b/src/traits.rs
index 38f1402..7d041b1 100644
--- a/src/traits.rs
+++ b/src/traits.rs
@@ -1,5 +1,7 @@
 //! Common traits

+use alloc::vec::Vec;
+
 /// Common trait for structures serialization
 pub trait Serialize<O = Vec<u8>> {
     /// Type of serialization error
--

These changes have unblocked our use case for now but I would love to contribute it back upstream if there is interest. I can obviously prepare this as a proper pull request if that is the case.
Thanks,
Jason

Hi @jscatena88 ,
adding support for no_std would definitely be a good feature for this crate. Would you mind resubmitting this as a pull request, so this can be merged with usual git workflow?
At first sight, the patch looks fine (maybe just add a comment to function dbg_dmp_rest to indicate that it requires std).
Thanks!

Closing, merged in #7


[FEATURE REQ] Add support for AEAD with AES-GCM

Is your feature request related to a problem? Please describe.
In customer projects it is quite common to use a modern cryptographic function like AES with GCM in combination with AEAD (Authenticated Encryption with associated data) to add additional authenticated (and integrity protected) data or tags
alongside the cipher-text to convey the context of the encryption.
The KMS facilities of AWS and GCP both supports AEAD:
AWS: How to Protect the Integrity of Your Encrypted Data by Using AWS Key Management Service and EncryptionContext
GCP: Cloud Key Management Service: Additional authenticated data
Describe the solution you'd like
A clear and concise description of what you want to happen.
It would be great to see support for AEAD on Azure SDK for Java in case Azure Key Vault supports AEAD...
Then I'd like to see variants like:

AES128_GCM
AES256_GCM
listed in the EncryptionAlgorithm class.

The AAD information could be added via the Context parameter with a key like add.
The new API could be used like this for encryption:
Context context = new Context("aad", associatedData);
EncryptResult encryptionResult = cryptoClient.encrypt(EncryptionAlgorithm.AES128_GCM, plaintext, context);

... and for decryption:
Context context = new Context("aad", associatedData);
DecryptResult decryptResult = cryptoClient.decrypt(EncryptionAlgorithm.AES128_GCM, ciphertext, context);

where associatedData is a byte[].
Describe alternatives you've considered
Currently one cannot use AEAD with the Azure Java SDK.
Additional context
Add any other context or screenshots about the feature request here.
Libraries like google's tink have support for integrating with external KMS systems (GCP, AWS, Android / iOS), see
https://github.com/google/tink/tree/master/java_src/src/main/java/com/google/crypto/tink/integration
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Description Added
[x] Expected solution specified

Thanks for filing this feature-request on Key Vault @thomasdarimont.
@AlexGhiondea can you please include this in your KV planning?

Added support for AES GCM and AEAD in 4.3.0-beta.3 :)


Summarize By property

Hi,
I'm trying to setup the value to the property "Summarize By" in an advanced script, but I don't know the sintax:
foreach(var c in Selected.Columns)
{
c.SummarizeBy = "none";  // Something it's wrong ??????
}
Thanks in advance
Ramon.

The SummarizeBy property is not a string property (see https://docs.microsoft.com/en-us/dotnet/api/microsoft.analysisservices.tabular.column.summarizeby?view=analysisservices-dotnet) it expects an AggregateFunction enum value. So I think you will find that something like the following might work (I have not tested this)
foreach(var c in Selected.Columns)
{
c.SummarizeBy = AggregateFunction.None;
}

The SummarizeBy property is not a string property (see https://docs.microsoft.com/en-us/dotnet/api/microsoft.analysisservices.tabular.column.summarizeby?view=analysisservices-dotnet) it expects an AggregateFunction enum value. So I think you will find that something like the following might work (I have not tested this)
foreach(var c in Selected.Columns)
{
c.SummarizeBy = AggregateFunction.None;
}

It works.  Thanks


My sample doesn't use dart:html but I see "Hello world!" in the output

It's a bit weird that "Hello world!" is displayed when all my code does is print("hi"). I never touched HTML or CSS tabs.
I wonder, can we show the output of HTML only if the user intended to do some HTML coding?

@devoncarew says:

when creating a new, blank, sample, we may choose to not include the sample html snippet
we could look at detecting when the DOM is mutated in the iframe. this is easy if the html snippet is not empty (they wrote some html code); it's harder if they programmatically mutate the DOM (document.body.children.add(new SpanElement()..text = 'foo')).

The current blank sample just uses dart now, no html, and we're tracking some UI refactoring here: #289; closing this out.


Converge to a single copy of volatile.h

Fixes #7607

This breaks the Wasm build I think with:
Commencing build of native components for WebAssembly.wasm.Debug

**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.2.3
** Copyright (c) 2019 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x86_x64'
-- The ASM compiler identification is unknown
-- Found assembler: E:/GitHub/emsdk/emscripten/1.38.31/emcc.bat
-- Warning: Did not find file Compiler/-ASM
-- Configuring done
-- Generating done
-- Build files have been written to: E:/GitHub/corert/bin/obj/Native/WebAssembly.wasm.Debug

Microsoft (R) Program Maintenance Utility Version 14.22.27905.0
Copyright (C) Microsoft Corporation.  All rights reserved.

[  1%] Building CXX object Runtime/Portable/CMakeFiles/PortableRuntime.dir/__/FinalizerHelpers.cpp.o
In file included from E:\GitHub\corert\src\Native\Runtime\FinalizerHelpers.cpp:9:
In file included from E:/GitHub/corert/src/Native/Runtime/Portable/../gcenv.h:46:
E:/GitHub/corert/src/Native/Runtime/Portable/../../gc/env\volatile.h:71:2: error: The Volatile type is currently only defined for GCC when targeting x86, AMD64, ARM or ARM64 CPUs
#error The Volatile type is currently only defined for GCC when targeting x86, AMD64, ARM or ARM64 CPUs
 ^
1 error generated.

Unfortunately Wasm is not running in CI, but any idea what would be a good fix for Wasm?


elasticsearch: basic support to create metrics

Add support for labels in the import-elasticsearch scripts (for tests)
Implement create_metric() in elasticsearch.py (very basic implementation)
Add code the create missing indices when necessary (+ basic mapping)

Coverage decreased (-0.2%) to 79.375% when pulling fa52608132d6485f984b867d008d9f9755e49d00 on iksaif:master into 16995ae3c238dec681bb031c8ac504106f3a2360 on criteo:master.


Can not use subtitles or captions with the player

The template doesn't include track tag so is not possible to use subtitles or captions with the player.

🙂It will fix in v6.0.0

Thank you! when the v6 will be released ?

Will v6 with trackList support be released sometime soon?

🙂It will fix in v6.0.0

when will be option will be available for subtitles and captions in vue video player

+1