[error message feedback][TEST] provide feedback

🛑 IMPORTANT: You can get your feedback addressed faster if you use the comment section for the article in which you encountered a problem.
Problem:
What's wrong with the error message? For example,

Is error message clear and actionable?
Is there a documentation to provide more information?
If there is a documentation, is it relavent and helpful?
Is line number correct?
etc.

Log code info
(This is auto filled, no need to modify)

Severity
Type
Code
Category
File
Message
Source
Line
Time

Error
User

PullRequestMergeConflict

Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

Link to report
(This is auto filled, no need to modify)
report url

@phillipgibson Did your get past your merge conflict? Is this item ready to be closed?


ARROW-2214: [JS] add nullBitmap getter to DictionaryData that proxies to its indices' nullBitmap

Resolves https://issues.apache.org/jira/browse/ARROW-2214

Was this actually merged?

@nmichaud yes this is merged as a squashed commit in https://github.com/apache/arrow/commit/27d83392ecb763c7ae0f3775a6c6582377998522 As there was no merge commit, this does look different in the GitHub UI


LogReceived event in SharingStage causes Unity Logs to be duplicated

Overview
In order to catch and display logs coming from the sharing service managed library, an event is registered in the SharingStage which catches incoming logs from the console and pipes them into the UnityEngine log system by way of the Log class in the SharingClient.dll (which in turn feeds the log into the ConsoleLogWriter class).
The problem is that the UnityEngine.Debug.Log, UnityEngine.Debug.LogWarning, UnityEngine.Debug.LogError and UnityEngine.Debug.LogException apparently also output into the console (most likely to put the logs into the Editor.log in AppData, but I'm speculating). This in turn triggers the Application.logMessageReceived event and prints the log to the Unity Console a second time.
This occurs for the above mentioned Debug log methods called from both the user's scripts as well as the Unity Engine itself.
Expected Behavior
Unity Debug logs should not be duplicated in the unity Console.
Actual Behavior
Unity Debug logs are outputted to the Console twice
First log example:
Vuforia initialization successful
UnityEngine.Debug:Log(Object)
Vuforia.VuforiaRuntime:InitVuforia()
Vuforia.VuforiaRuntime:VuforiaInitialization()

Duplicate log example:
Vuforia initialization successful
UnityEngine.Debug:Log(Object)
HoloToolkit.Sharing.Utilities.ConsoleLogWriter:WriteLogEntry(LogSeverity, String) (at Assets/TQ3D/HoloToolkit/Sharing/Scripts/Utilities/ConsoleLogWriter.cs:29)
HoloToolkit.Sharing.LogWriter:SwigDirectorWriteLogEntry(Int32, String) (at Assets/TQ3D/HoloToolkit/Sharing/Scripts/SDK/LogWriter.cs:65)
HoloToolkit.Sharing.SharingClientPINVOKE:Log_Info(String)
HoloToolkit.Sharing.Log:Info(String) (at Assets/TQ3D/HoloToolkit/Sharing/Scripts/SDK/Log.cs:44)
HoloToolkit.Sharing.SharingStage:OnLogReceived(String, String, LogType) (at Assets/TQ3D/HoloToolkit/Sharing/Scripts/SharingStage.cs:385)
UnityEngine.Debug:Log(Object)
Vuforia.VuforiaRuntime:InitVuforia()
Vuforia.VuforiaRuntime:VuforiaInitialization()

Note, however, that the duplicate log (the one piped through the ConsoleLogWriter) actually is outputted to the log first.

Closing issues older than 180 days. If this is still an issue, please reactivate with recent information.


Fix PV coordinate conversion for non-19x19 boards

Fix PV coordinate conversion for non-19x19 boards

Thank you! But I can't make time right now, so I'll look into it in a few days.


generateWebsiteScreenshot() using Python

Issue
https://github.com/appwrite/appwrite/issues/4111
cURL request
curl --location --request POST 'http://localhost:3000' \
--header 'X-Internal-Challenge: secret-key' \
--header 'Content-Type: application/json' \
--data-raw '{
    "env": "{ \"API_FLASH_API_KEY\": \"<YOUR KEY>\" }",
    "payload": "{ \"url\": \"https://www.bruteforced.dev/\" }"
}'

Response
{
    "screenshot": "/9j/4AAQSkZJRgABAQAAAQABAAD/4gIoSUNDX1BST0ZJTEUAAQEAAAIYAAAAAAQwAABtbnRyUkdCIFhZWiAAAAAAAAAAAAAAAABhY3NwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAA9tYAAQAAAADTLQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAlkZXNjAAAA8AAAAHRyWFlaAAABZAAAABRnWFlaAAABeAAAABRiWFlaAAABjAAAABRyVFJDAAABoAAAAChnVFJDAAABoAAAAChiVFJDAAABoAAAACh3dHB0AAAByAAAABRjcHJ0AAAB3AAAADxtbHVjAAAAAAAAAAEAAAAMZW5VUwAAAFgAAAAcAHMAUgBHAEIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA...N2RjoMcLvaIvrYzU1H84zzvJnc8vNERFWRERAREQEREBERAREQEREEURFEEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERAREQEREBERB//2Q==",
    "success": true
}

Website screenshot validation
Used https://codebeautify.org/base64-to-image-converter to verify the validity of the base64 encoded screenshot.

Failure case
{
    "message": "Website could not be reached",
    "success": false
}

@acceptallcookies , thanks for the PR! 🤯 Please give us some time to review it.

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

Hey there 👋
We are temporarily closing your PR as there has been no activity on it. Feel free to re-open it when you're ready to start working on it again 😇


Thaumcraft dependency crash.

When attempting to run without Thaumcraft installed, this crash occurs on start-up. With Thaumcraft installed (a different instance), it works just fine. The relevant (I think) part of the crash log is here:
Caused by: java.lang.NoClassDefFoundError: thaumcraft/api/ThaumcraftApi
at pixlepix.auracascade.main.compat.TCCompat.postInit(TCCompat.java:13)
at pixlepix.auracascade.main.CommonProxy.postInit(CommonProxy.java:96)
at pixlepix.auracascade.main.ClientProxy.postInit(ClientProxy.java:41)
at pixlepix.auracascade.AuraCascade.postInit(AuraCascade.java:38)
I assume this is a bug, as TC is not mentioned as a dependency, and it crashes rather giving that forge screen. Here is the full log:
https://docs.google.com/document/d/1RKKACa8k7B78uwsS2uKpNhjeWUWwTGrquhZwINCmr5I/edit?usp=sharing

Duplicate of #35, it will be in the next update. Taking a bit longer than I wanted because I'm working on a new feature.


twitter roberta base sentiment example

Checklist:

[x] Version bumped

Added:

Code example for uploading and running the pipeline: twitter-roBERTa-base-sentiment

Just gotta remove the version increment, then LGTM, nice!

Oh yeah makes sense, no point in that here. Thanks


Better inspect method for Rake::Pipeline

Right now a ton of data is dumped which is awful for rake middleware.

I run rake middleware and don't see any issue. Is this fixed?

Honestly, I don't even remember what this issue was about. I'll reopen if I find any issues again.


Installing in a temp dir fails with file: deps

See https://github.com/benmosher/eslint-plugin-import/issues/1512#issuecomment-545590357

This should be solved by v3.


Can't import Ember projects

IntelliJ detects a "Web" project instead of "Ember.js"
git bisect blames this commit: 0945404b5d80f86ec9e192260aec7b3df2933436
(make sure to delete .gradle and .sandbox between each test)
Tested with

IntelliJ IDEA 2016.2.5 Build #IU-162.2228.15, built on October 14, 2016
Ember plugin version 2016.2.4-0

@dwickern I'd be very surprised if that commit was indeed responsible for breaking our code... 🤔

It works if I get rid of the <depends> in plugin.xml

Hmm, I think it's supposed to be just yaml instead of org.jetbrains.plugins.yaml

what are the implications of detecting a "Web" module instead? Can we "solve" that by using the FrameworkDetector instead?

Here's all I see when it's imported as a Web module

😒

I'm experiencing this as well, except the project fails to import entirely when being imported as a sub module.
It is auto-detected as type "Web", then I click finish and nothing happens, the module is not imported.
Reverting all the way back to v2016.2.1 fixes the issues.

Same issue here and I confirm that reverting back to v2016.2.1 fixed the issue.
Thanks for the hint !
And keep up your awesome work, love this plugin !


TC Meeting 2024-02-22

The OpenRail Technical Committee is holding a weekly meeting. The agenda is prepared in issues and the protocols are stored in the meetings folder.
Please add additional topics or any other comments by commenting on this issue.
Agenda
For this meeting the maintainers of OSRD are invited as guests. The main topic of the meeting is the onboarding of OSRD as first official project of the OpenRailAssociation

Introductions
Overview of role and tasks of technical committee
Representative of OSRD in Technical Committee
Project governance
Moving the repositories to the OpenRailAssociation organization

#33


renaming a parameter of an actual method locks up the IDE

This issue will likely be fixed as a side-effect of other things we're already working on, but we still need to test it thoroughly.

This does indeed seem to be fixed now.


numba.errors.NotDefinedError in simple model that parsed without error.

For this .yaml specification of a model:
https://gist.github.com/sbenthall/cf76a376ce5b6c5891de635e636790c9
The file parses properly, but I get the following error/stack trace when trying to inspect the model, after parsing it:
https://gist.github.com/sbenthall/47df4a150a3bd47ff75df2f632339289

Γp is not defined

This should throw an error earlier.

I am continuing to get the same error even with this corrected version of the .yaml file:
https://gist.github.com/sbenthall/a2ebcb351da977a83d92220f95a5ca15

In the transition equations states cannot appear on date t on the rhs (
which is the case for p )
On Fri, Feb 7, 2020, 10:59 PM Sebastian Benthall<EMAIL_ADDRESS>wrote:

I am continuing to get the same error even with this corrected version of
the .yaml file:
https://gist.github.com/sbenthall/a2ebcb351da977a83d92220f95a5ca15
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/EconForge/dolo/issues/177?email_source=notifications&email_token=AACDSKNL7GRFTAQ7LHGFYK3RBXKVZA5CNFSM4KM22D32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELEYZPI#issuecomment-583634109,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACDSKPT5PYC3JDHJKYIVSTRBXKVZANCNFSM4KM22D3Q
.

Ok, this version works fine:
https://gist.github.com/sbenthall/f96b9ccdf11254f419d8e99d962952de
Leaving this ticket open to log potential for improved error handling.


Typo in recipes.py(?) and basicTests failure

Trying to get this running for a work colleague.
On copying the maybrain/maybrain folder to site-packages and then trying to run test/basicTests.py
$ python basicTests.py Traceback (most recent call last):   File "basicTests.py", line 17, in <module>     from maybrain import recipes   File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/maybrain/recipes.py", line 12, in <module>     from plot import plotObj ImportError: No module named plot
Surely this should be mbplot?
Regardless of this, running basicTests.py results in the following error:
`$ python basicTests.py
red
red
green
blue
green
green
green
green
green
green
('x', 'gt', 0.5, 'x1', 'node')
('colour', 'eq', 'green', 'green', 'edge')
{'colour': 'green', 'weight': 0.60080034391699999}
('green', 'eq', 'green', True)
{'colour': 'green', 'weight': 0.203602458588}
('green', 'eq', 'green', True)
{'colour': 'green', 'weight': 0.16390494700200001}
('green', 'eq', 'green', True)
{'colour': 'green', 'weight': 0.84379894778099995}
('green', 'eq', 'green', True)
{'colour': 'green', 'weight': 0.242747996199}
('green', 'eq', 'green', True)
{'colour': 'green', 'weight': 0.63727884848299998}
('green', 'eq', 'green', True)
..E.
ERROR: test_loadAndPlot (main.TestSequenceFunctions)
load, threhsold and plot
Traceback (most recent call last):
File "basicTests.py", line 56, in test_loadAndPlot
br, plt = recipes.loadAndPlot(self.fnameAdj, self.fnameCo, 0.5, opacity = 0.2)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/maybrain/recipes.py", line 50, in loadAndPlot
plt = plotObj()
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/maybrain/plot.py", line 41, in init
self.startMayavi()
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/maybrain/plot.py", line 55, in startMayavi
self.mfig = mlab.figure(bgcolor = (1., 1., 1.,), fgcolor = (0., 0., 0.), engine = self.engine, size=(1500, 1500))
File "/opt/rh/python27/root/usr/lib64/python2.7/site-packages/mayavi/tools/figure.py", line 68, in figure
engine.new_scene(name=name, size=size)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/apptools/scripting/recordable.py", line 45, in _wrapper
result = func(*args, **kw)
File "/opt/rh/python27/root/usr/lib64/python2.7/site-packages/mayavi/core/engine.py", line 452, in new_scene
viewer = self.scene_factory(**factory_kwargs)
File "/opt/rh/python27/root/usr/lib64/python2.7/site-packages/mayavi/core/ui/mayavi_scene.py", line 86, in viewer_factory
viewer = MayaviViewer()
File "/opt/rh/python27/root/usr/lib64/python2.7/site-packages/tvtk/tools/ivtk.py", line 382, in init
super(IVTK, self).init(**traits)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/pyface/toolkit.py", line 124, in init
raise NotImplementedError("the %s pyface backend doesn't implement %s" % (ETSConfig.toolkit, oname))
NotImplementedError: the null pyface backend doesn't implement ApplicationWindow

Ran 4 tests in 0.005s
Python 2.7
apptools (4.4.0)
Babel (0.9.6)
cmp (2.1.0b0)
configobj (5.0.6)
cycler (0.10.0)
decorator (4.0.6)
docutils (0.11)
Easy-Lausanne (0.5)
functools32 (3.2.3-2)
Jinja2 (2.6)
MarkupSafe (0.11)
matplotlib (2.0.0b4-2053.g440adff)
mayavi (4.5.0)
mpmath (0.19)
networkx (1.11)
nibabel (2.0.2)
nipy (0.4.0)
nipype (0.7.0.gd2cbeaa-dev)
nose (1.3.0)
numpy (1.11.1)
pip (8.1.2)
pyface (5.1.0)
Pygments (2.1.3)
pyparsing (2.1.9)
python-dateutil (2.5.3)
pytz (2016.6.1)
scipy (0.17.0)
setuptools (27.2.0)
simplejson (3.2.0)
six (1.10.0)
Sphinx (1.1.3)
SQLAlchemy (0.7.9)
subprocess32 (3.2.7)
sympy (1.0)
traits (4.5.0)
traitsui (5.1.0)
virtualenv (13.1.0)
Werkzeug (0.8.3)
wheel (0.24.0)

OK, so I semi-solved my problem by switching over to use anaconda instead of trying to build everything which was proving to be more trouble than it's worth.
Now, after making the above change to recipes.py and running basicTests I just get the following error
Traceback (most recent call last):   File "basicTests.py", line 58, in test_loadAndPlot     plt.show() AttributeError: plotObj instance has no attribute 'show'
I am running this via ssh with X forwarding though so that may well be the issue.

Copying plot.py from the base directory to the maybrain folder in site-packages has resolved the problem. If the intention is for end-users to download this module and use it by copying the maybrain/maybrain folder into site-packages then that file should be included, or the mbplot file updated.

Apologies, the basicTests.py file is out of date. The plotting is now taking on by mbplot.py which is in the maybrain folder. I'm pleased you're using maybrain and a bit embarrassed about the lack of proper documentation. Please do get in touch with any further issues.


vcpkg_from_gitlab documentation unclear

Type of issue
Missing information
Description
Hi,
The documentation of vcpkg_from_gitlab is unclear. I thought it would use git and git credentials, but it didn't work (and the error messages were not very helpful). I opened this https://github.com/microsoft/vcpkg/issues/38687 and it turns out I need to use AUTHORIZATION_TOKEN, which is not mentioned on the vcpkg_from_gitlab docs page - and in fact as @Osyotr pointed out in https://github.com/microsoft/vcpkg/issues/38687, AUTHORIZATION_TOKEN is not documented yet at all. So it's pretty much impossible to figure out from vcpkg_from_gitlab's documentation how to use it and how to make it work.
Page URL
https://learn.microsoft.com/en-us/vcpkg/maintainers/functions/vcpkg_from_gitlab
Content source URL
https://github.com/Microsoft/vcpkg-docs/blob/main/vcpkg/maintainers/functions/vcpkg_from_gitlab.md
Document Version Independent Id
81d53087-e303-3245-3f52-08b88881c694
Article author
@vicroms
Metadata

ID: 81d53087-e303-3245-3f52-08b88881c694
Service: vcpkg

Thanks @andre-nguyen. I wouldn't call the docs added in #328 very verbose but it's better than nothing and should be a start for people to figure out what to do.


Made IMU Reset button

Before issuing a pull request, please see the contributing page.

On button B


when building rom it said  libiconv-2.dll and libwinpthread-1.dll are not found

when building rom it said  libiconv-2.dll and libwinpthread-1.dll are not found. then it said build failed make sure build tools are installed(i did install them). but other than that i love it

Oh no! Sorry to hear you ran into build problems. To help me debug what OS are you using and what compiler did you use?

i am on windows 10 and i used visual studio 2019

i can use the editor the only problem is when i click build rom

Cool thanks. Let me get a clean Win 10 machine put together so I can try and see if I need to rebuild the custom GNU compiler. Might have to static link some additional libraries. I'll let you know what I find once I trouble shoot some more. Glad though you're liking the editor so far! Long way to go still lol. :)

yah i love the idea of this... i dont know a lot of c or c++ but im getting there :) the error is with a file called mips64-elf-gcc.exe

here are some screenshots if that helps any

Thanks for the screen shots! I was able to reproduce your errors about the missing libraries. I'll have to see about building a new compiler that includes those libs statically or just bundle the DLLs with the compiler. I believe those libraries are from the MinGW environment. I'll investigate how I originally built the custom compiler and then apply a fix.
I'll keep this ticket posted with my progress. Sorry for the delay while I sort this out. In the meantime you could install MinGW and see if those DLLs are included. If so you could then add them into the Editor folder for UltraEd. Hacky but could work for now. :)

i found the dll files in another program i have called retro arch and putt them in the same folder as mips64-elf-gcc and it build fine now

Great, glad you got things working. I just pushed a commit that now fixes the problem so anyone in the future should be fine now. Thanks for reporting the issue to me and UltraEd is now better for it! :)


[Loc] "should NOT have additional properties" not localized

Brief Issue Summary
Environment:
VSCode 1.90.1+ CMake Tools v1.19.13(pre-release)
More info:
Repro Language: All loc languages
Repro platform: Windows, Linux, Mac
Repro steps:

Open VScode and change the display language to CHS
Download and unzip Version Validation
Open above project with VS Code.
Open CMakePresets.json file
Launch output window and navigate to "CMake/Build" category
Check the output info

Expected result:
“should NOT have additional properties" localized
Actual result:
“should NOT have additional properties” not localized

CMake Tools Diagnostics
No response
Debug Log
No response
Additional Information
No response

Verified with CMake Tools v1.19.35 (pre-release), this issue has been fixed.


After Install Semantic ui react my react app is not working showing totally white page

After Install Semantic ui react my react app is not working showing totally white page

I m facing same problem... raihan-biswas-dev...    I need an proper solution

I just installed Semantic UI on a fresh React install - I didn't reproduce the issue.
"dependencies": {
    "@testing-library/jest-dom": "^5.16.1",
    "@testing-library/react": "^12.1.2",
    "@testing-library/user-event": "^13.5.0",
    "react": "^17.0.2",
    "react-dom": "^17.0.2",
    "react-scripts": "5.0.0",
    "semantic-ui-css": "^2.4.1",
    "semantic-ui-react": "^2.1.1",
    "web-vitals": "^2.1.4"
  },

@raihan-biswas-dev please complete the full bug report form. We have no idea what your app toolchain looks like, what version of semantic ui react you are using, etc. Your report contains no information as to what sorts of error you are getting in your console, etc.
I am closing this report due to no actionable info, but we can reopen if a reproduction case and a full report is provided.


Inaccurate TS types on deeply nested relationship include queries

Bug description
Return types for my query are not accurate. The types from PromiseReturnType are also inaccurate.
How to reproduce

Check out https://github.com/justin-hackin/bug-report-prisma-ts
npm i && npm run dev
remove @ts-ignore comment and observe there is an error but the console output proves the type is wrong

Expected behavior
The type should match the instance
Prisma information
Refer to repo
Environment & setup
N/A
Prisma Version
Refer to repo

It turns out this was just an issue with my IDE (Webstorm) 🤦♂


Remove Tabs!

This should have been caught in the code review!
https://github.com/cmu-db/peloton/blob/2676275c8ea298cb0fede43e2d9f838a0e6fb57e/src/include/catalog/catalog_cache.h#L53

Sorry!

@ksaito7 https://github.com/cmu-db/peloton/wiki/Formatting this can help you. Also, I remember in CLion you can configure it to automatically format your code (Google C++ style is what we use)

@til2 Thanks. I will use its script. And I set up my eclipse to use space.


add Helium derivation path to application's access permissions

This PR gives the Solana Ledger App access to the Helium bip32 derivation path. This will allow the Helium Foundation to develop a migration tool to from the Helium bip32 derivation path to a standard Solana derivation path.
More details available here: https://docs.google.com/document/d/1AXalBlO03mMCtn8Bv8ngpr6_sE1V-6JX6DpET2dExRg/edit?usp=sharing
cc: @ChewingGlass

Hello @lthiery
Now that Helium has it's own app, can we drop this PR ?
App seems is here:
https://github.com/LedgerHQ/app-helium

Yes, thanks for pointing this out.


Convert BitAnd, BitOr, BitXor to UDAF

Is your feature request related to a problem or challenge?
Similar to other issues in #8708
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response

@jayzhan211  I'm really excited about getting involved with this project. This particular issue! Even though it's not marked as a 'good first issue,' I'm feeling confident and eager to dive in, give i have been spend a decent amount of time exploring this project.
I'm confident I can make some progress within a week or two, if not i will assigned it back.

take


Early review: Remove NetworkObject and NetworkService

Still need a NetworkObject in the parser since parseSystemAdapter uses it. (That will go away with the new model). Renamed that to NetworkXObject.

LGTM


FIX: limit ncols to a reasonable max in plot_events

Follow up to:

#12844

Beyond 3 columns (75! unique event IDs), adding more columns just ends up being chaotic.

Thanks @sappelhoff !


Add useCollectionService to handle collection service tags

Problem
As someone who uses collection service tags a lot to mark instances to have certain component, I thought it may be useful to add useCollectionService hook to handle them.
The advantage of this is that unlike useEvent, this will also handle all the instances with tag already added, meaning you won't need to run same operation twice separately for existing instances and newly tagged instances.
Proposed solution
The implementation of this hook is quite identical to useStream since it both handles addition and removal of instance, except on different event. It also has to add instances with tag already added on initialization.
Alternatives
One alternative is to have a similar implementation to what is provided in the matter docs.
https://eryn.io/matter/docs/Guides/CollectionService

I have the code ready, but I won't pr yet since I am not sure if this should be added or not.

I understand what's useful about this, but I want to make sure that hooks that make it into this library don't encourage non-idiomatic ECS usage.
My concern here is that if all you're intending to do is create components when they're tagged, the way the matter docs show should be the preferred way. I'm open to the possibility that this hook can be used for something other than that, but at the moment that's unclear to me.
These are the two things I'd like to see before adding something like this:

There are clear use-cases for this that aren't simply inserting a component that would represent the tag.
The specific interface of this hook won't discourage the usage of the method the matter docs provide.

Hi, thank you for responding.
I agree that at the moment, I am not so sure how else I would use this hook as I have never encountered such a case. However, I believe that being able to go through all tagged instances along with newly added instance once and only once on its addition or removal can be beneficial because it allows for matter system to also implement the following structure, which is useful since if game states are managed with the ecs loop, it makes more sense to do anything that is related to states from within the context too.
-- Normally, outside of matter
local function applyChange(instance)
    -- do something with instance
end

for _, instance in CollectionService:GetTagged("someTag") do
    applyChange(instance)
end
CollectionService.GetInstanceAddedSignal("someTag"):Connect(applyChange)
CollectionService:GetInstanceRemovedSignal("someTag"):Connect(function()
    -- handle removal
end)

-- What I propose
local function system(world, state)
    for _, collectionEvent: {added: boolean, removed: boolean, instance: Instance} in useCollection("someTag") do
        if collectionEvent.added then
            -- do something with instance
        elseif collectionEvent.removed then
            -- handle removal
        end
    end
end

I am not sure if this falls under the idiomatic ecs use because I am not too famliar with what the standard is, as matter is my first ever exposure to ecs. So if this is something that should be handled externally and not by hooks, I understand.

In hindsight, I admit that this may only serve niche uses because usually if we want to update instances with tags on events such as when state changes, we call getTagged for existing ones and InstanceAddedSignal for new ones. Meanwhile, this hook only exists to implement one time only change which might not really align with what ecs is.

I think this encapsulates the hesitation I have. In the case of useStream or useEvent you're using the hook to sync the ECS state and iteration with some external event as the events happen; you use it when you already have something in your ECS and are waiting for some signal from outside the ECS about how it should update at the correct time. With this, the primary use case I see is only the latter half of that, which is waiting for some signal from outside the ECS; if that's all we're doing we don't need to do that within our systems since we can access the world state from outside systems (in event driven code) just fine.
So for now I think we should avoid including something like this, but we can re-open this issue or a new issue later if a use case presents itself that requires that sort of synchronization of outside tagging and system iteration. The abstraction this hook is trying to create is valuable and can certainly be used alongside matter, I think it's just that making it a hook is the wrong choice, some other abstraction is likely better.


Resource Quotas for different namespace sizes

Rancher versions:
rancher/rancher:v2.1.0
rancher/rancher-agent:v2.1.0
Setup details: single node rancher
Environment Template: (RKE)
I have a Qustion regarding the new Resource Quotas released in v2.1.0.
A Project Level Limit Sounds like a great idea, but in our case the size of the namespaces differ greatly (from 500mCPU to a Namespace with about 10 CPU's) so i can't configure the namespace limit to the higher CPU value for this would limit our number of available namespaces greatly, unless I would overwrite moste of them with custom quotas.
Is there another way to configure this or is this a feature planed future releases?

I have this problem too. In the namespace edit display, current namespace use resource is zero, but other namespaces resource more than allocation. I think this problem is  edit namespace function used as create.

It sounds like you would need to configure each namespace individually  and specify which ones would have the higher limites on top of the project level.
No matter what the total of the namespace limits would need to be within the project level.


Add .DS_Store to .gitignore

I'd generally recommend you use a global gitignore for that on OSX but there's no reason not to add it here too.

I agree, it dosen't make much sense to have it in all the github projects...


ViewModel fails if app goes to background on iOS

In my application, I have ViewModel that works with Bluetooth service and collects data for me. The current behavior on iOS is that when a user exits the app ViewModel gets paused and no incoming data is read from Bluetooth, as soon as the user opens the app again, everything resumes and works as expected. I am not sure if this is iOS bug or limitation? On android doing the same does not prevent the app from working, on Android if the app goes to the background everything is working and data is being collected. Is this a bug or should I use isolates to move my Bluetooth piece to background event. I am currently just looking for a short term solution to be quick fix while I work with isolates in a long run.
Flutter (Channel stable, 2.8.1, on Microsoft Windows [Version 10.0.22000.434], locale en-US)
• Flutter version 2.8.1 at .........
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 77d935af4d (6 weeks ago), 2021-12-16 08:37:33 -0800
• Engine revision 890a5fca2e
• Dart version 2.15.1
pubspec.yaml
environment:
sdk: ">=2.7.0 <3.0.0"
dependencies:
flutter:
sdk: flutter
stacked: ^2.2.3

Problem was solved by turning on background services in Xcode


Connection loop

I'm trying to connect my esp8266 nodemcu to my mqtt broker.
The connection seems to be enstablished. But the client loops over and over trying to connect again.
This is my code: http://pastebin.com/V23Sy7fb
and this is my serial console output:
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...failed, rc=-4 try again in 5 seconds
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
. . .

Do your broker logs provide any clues as to why the client is disconnecting?
I see you're using a client ID of default - do you have any other clients using that ID?

My broker is Mosca, a Node.js-based broker.
I got this on the broker's log:
- Client Disconnected:  default
- Client connected:  default
- Client Disconnected:  default
- Client connected:  default
- Client Disconnected:  default
- Client connected:  default
- Client Disconnected:  default
- Client connected:  default
- Client Disconnected:  default

What client.loop(); exactly stands for? is it required?

And you dont have any other clients already using the 'default' client id?
client.loop is required: http://pubsubclient.knolleary.net/api.html#loop
Have quickly are these connect/disconnect cycles happening? I see your code publishes after connecting - do you see that message arrive anywhere?

No the message doesn't arrive. Do I need to put any delay somewhere?

I've used the latest release... so weird.. can you try the code i've pasted above?

I've just discovered that. If i set no authentication on my broker, everything works fine. Using authentication, something goes wrong.
My broker is the node.js open source project called "Mosca".
I don't know if it is related to the Client or to the Broker.

Have you tested the username/password work with another mqtt client? For example the mosquitto_pub command? I see your code retrieves the username/password from a json file - have you verified it is actually passing the values you expect to client.connect()?

The values expected are correct.
I've found the issue. Seems to be related to the publish authorization.
If I try to publish in a topic I'm not authorized to publish, the client disconnect and reconnect, the broker doesn't return the code 5 - "Connection Refused, not authorized" expected or the client doesn't get it.

That return code is only applicable in response to the Connect packet - there is no way in MQTT for the broker to send a failure code to the client in response to an invalid publish. All it can do is disconnect.
Glad you got to the bottom of it.

Alright, thanks :+1:


Switch to cube interface

http://ux.stackexchange.com/questions/11229/is-this-rotating-cube-interface-user-friendly/11264

Like, cubes for everything, though.

Um...is this Web .02 or something? WCAG have established that the spinning cube would be terrible UX, and that the best practice is to use spinning icosahedrons.

The issues page is a place of business, @danjmoore .


🐞 dagger call --help lists arguments as functions

What is the issue?
Fields in a module or custom type get listed as functions.
This is true at least for Go, have not tried others.
This is also true when using module constructors.
Dagger version
dagger v0.11.4 (registry.dagger.io/engine) linux/amd64
Steps to reproduce
I have a simple example here: https://github.com/MikaelElkiaer/daggerverse/blob/main/testing.go, from which I can run:
dagger --mod github.com/mikaelelkiaer/daggerverse call testing --help

Log output
Output is:
USAGE
  dagger call testing <function>

FUNCTIONS
  interrupt
  main

INHERITED OPTIONS
  -d, --debug             show debug logs and full verbosity
      --json              Present result as JSON
  -m, --mod string        Path to dagger.json config file for the module or a directory containing that file. Either local path (e.g.
                          "/path/to/some/dir") or a github repo (e.g. "github.com/dagger/dagger/path/to/some/subdir")
  -o, --output string     Path in the host to save the result to
      --progress string   progress output format (auto, plain, tty) (default "auto")
  -s, --silent            disable terminal UI and progress output
  -v, --verbose count     increase verbosity (use -vv or -vvv for more)

Use "dagger call testing [command] --help" for more information about a command.

main is not a function, but a field on the custom type Struct.

Hi @MikaelElkiaer, that is expected, see Develop with Go: Visibility.
If you don't want to expose a function for a struct field, you can add the // +private pragma.

Hi @MikaelElkiaer, that is expected, see Develop with Go: Visibility.
If you don't want to expose a function for a struct field, you can add the // +private pragma.

Thanks, totally missed that - too focused on searching this repo.
However, this raises 2 further questions:

What is the point of this feature - why would I want to expose my fields as functions? Particuilarily when looking at https://docs.dagger.io/manuals/developer/go/520657/constructor, there is an info box at the bottom stating I should have the fields as public, it seems to me that these use cases might be conflicting.
I do not understand the example in the doc - why is the job field not exposed? I get that age is not as it has the // +private pragma.

Final question on this.
For Go, why a private pragma, instead of public?
I get that Go enforces visibility based on casing, but is it not an explicit choice in the Go SDK to turn the public Go fields into Dagger functions?
To me it sounds like fields, even though public in Go, could be private by default in Dagger - which I understand would then be the same behavior for Python and TypeScript.
Thanks for your elaborations so far, keep up the good work!

To me it sounds like fields, even though public in Go, could be private by default in Dagger - which I understand would then be the same behavior for Python and TypeScript.

That is true but at the time it was introduced, it was more consistent with the general behavior of the Go SDK to expose by default. Pragmas weren't around from the beginning and they were added mostly to control what arguments are optional or not (difficult because Go doesn't support default values).
If you made that change today:

It would be a breaking change for many people.
Still inconsistent with functions that are exposed by default (unless lower cased).
From the modules that I've seen, in any language, exposing fields seems to be more common than not.

I get it now, and I do see the usefulness.
I think my confusion arose from how I discovered it.
I had not looked at the section you linked about Visibility, but on the other hand I used Module Constructor.
I then stumbled upon my fields turning up as functions, though I only added fields in order to use as constructor arguments.
I see how this behaviour could be useful for grabbing intermediate steps or state when using composite types.
However, it still does not make sense to me to expose module constructor arguments in this manner - for now I will turn them private.


[Event Request] codeunit 8618 "Config. Excel Exchange" - OnExportExcelFromConfigOnExportExcel

procedure ExportExcelFromConfig(var ConfigLine: Record "Config. Line"): Text
var
    ConfigPackageTable: Record "Config. Package Table";
    ConfigMgt: Codeunit "Config. Management";
    FileName: Text;
    "Filter": Text;
begin
    ConfigLine.FindFirst;
    ...
    ConfigPackageTable.SetRange("Dimensions as Columns");
    OnExportExcelFromConfigOnExportExcel(ConfigLine, ConfigPackageTable); //A115F0000.Event19.05
    ExportExcel(FileName, ConfigPackageTable, true, false);
    exit(FileName);
end;

[IntegrationEvent(false, false)]
local procedure OnExportExcelFromConfigOnExportExcel(var ConfigLine: Record "Config. Line"; var ConfigPackageTable: Record "Config. Package Table")
begin
    //A115F0000.Event19.05
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


[rmodels] Improve OBJ vertex data precision and lower memory usage by ExportMesh()

Using ExportMesh() to save a mesh as an OBJ currently creates broken models due to very low floating-point precision, both for vertex position, normals and UVs.
Here's a model I made, imported into a raylib program:

And here's the same model, first imported into the program, then exported using ExportMesh(), then imported back:

I guess vertex positions could be scaled x1000 before exporting to account for the precision loss, but neither vertex normals nor UVs can be treated the same way. I don't see any reason why these values cannot be increased; I replaced the relevant numbers with the precision values that Blender's OBJ exporter uses, which seems to give me a visually identical model to the original upon next import.
The exporter also greatly overestimates the amount of memory necessary to be allocated to store the data in, which could potentially lead to issues when attempting to export very big meshes. Wanting to lower the memory allocation to the minimum necessary, while trying to add the least amount of extra code as well as avoiding polluting the codebase with extra functions, I made a macro function declaration inside the exporter and replaced much of the code there with that new function. The code compiles and works fine in both Windows and HTML5; however I don't know if macro functions are acceptable in this project, and perhaps a different approach might be preferable to the one I ended up taking. If so, I totally understand; I'll change it as required.

@mikeemm I prefer to keep the same function structure as other similar functions and avoid that TEXT_APPEND macro. I the problem is the scale of the buffer, incrementing its size to fit more decimals would be enough, no need to redesign all the function.

@raysan5 I understand. I have reverted the macro changes and modified the initial allocation instead, please take a look whenever you'd like.


Update tasks page at https://coderefinery.org/tasks/

[x] remove tasks that were done
[ ] add undone tasks that would still be good to do to this board
[x] add link to board to task page
[x] leave "always welcome" tasks on webpage

Thanks! Working on it ...

I think done. I still need to go through the board itself but that's a separate task.


Error while parsing GS1 barcode

Hello, I tried parsing the data from the following barcode (data is<PHONE_NUMBER>172405310100693570007182 and does not include any separator/FNC1 characters) and received a ParseError

The data should be the following: (10)21072911(17)240531(01)00693570007182 (lot, expiry, GTIN)
I'm aware that ai 10 (lot) can vary in length so I wanted to check my understanding and confirm that this is not an issue with biip. Has this barcode not been constructed properly?
Thank you,

First of all, thank you for including a photo in the issue. It makes things so much more concrete and easier to debug!
If this was a one dimensional barcode, like GS1-128, I'd scan the barcode with a phone app that shows FNC1 separators (I'm using Cognex Barcode Scanner on Android). If it showed an FNC1 separator, I'd say that the issue was with your scanner's configuration, and that you need to configure it to give you a special character where there's a FNC1 separator, so that Biip could know about the FNC1's placement. If the phone app showed no FNC1 separator, I'd say the problem was with the production of the barcode.
I'm not as familiar with GS1 AI strings in Datamatrix barcodes, so I don't know without researching a bit if these also should use FNC1 or if they have some other replacement. The GS1 General Specification probably has the details here. Either way, the end of the variable length fields needs to be communicated to the scanning application in some way for the application to be able to correctly interpret the data. What I know is that the phone app I usually test with shows no FNC1 separator (usually shown by a space) here. Thus, I'm thinking that this barcode is either broken, or there is another solution for variable-length field separators in Datamatrix barcodes that my phone app doesn't support.

Quoting GS1 General Specification, section 5.6.2 GS1 DataMatrix features and symbol basics:

Data Matrix ISO version ECC 200 is the only version that supports GS1 system data structures,
including Function 1 Symbol Character (FNC1).

...

FNC1 for GS1 system compatibility SHALL be encoded at the beginning of the data string. When
a separator character is needed at the end of an element string, either the Function 1 Symbol
Character (FNC1) or the control character  (ASCII value 29 (decimal), 1D (hexadecimal))
SHALL be used and SHALL be represented in the transmitted message by control character
 (ASCII value 29 (decimal), 1D (hexadecimal)).

This is a screenshot from the GS1 DataMatrix Guideline, section 2.3:

This is a GS1 DataMatrix barcode with an FNC1 marking the end of a variable-length lot number. Scanning this with my phone app, a space character shows up where the FNC1 is supposed to be.
However, the space character does not show up when scanning the barcode with a variable-length lot number in your photo.
To me, this is a strong indication of your barcode is actually missing the required FNC1 markers.

@jodal Thank you for the detailed response. This is great! I also suspected that there's an issue with the barcode. The barcode is from a commercial setting and I get suspicious when an issue like this occurs believing that the industry would not make such mistakes. In case you're curious, here's another barcode with FNC1 characters. I had the foresight to include the encoded text in the same photo.

I use https://github.com/markusfisch/BinaryEye on my phone for scanning and save the text to file and read the contents of that file into biip which does properly parse the pieces of information.
IMG_20220326_214118.txt

Thank you for this package.

That looks like a very useful app, to get the data on byte level!
Just a final note: I'd love if you/your company as a user of Biip added yourself to https://github.com/jodal/biip/wiki/Users

For sure, let me get back to you next week. Just need to try out a few things first.


Alerting with Prometheus using Flapjack

Anyone has  tried alerting in Prometheus using Flapjack ?

Pretty sure nobody in the core team of developers has tried anything with Flapjack, but for general questions like this, I'd recommend asking on the mailing list or IRC channel (http://prometheus.io/community/).
Fine to close this issue here?

Thanks for the quick feedback


Upgrade to Rails 4.2.0 and Ruby 2.2.0

ran on local machine, everything seems to work fine :) :+1:


ValueError: invalid literal for int() with base 10: 'Alt Idle Animation'

Converter stops at 70% and throws an error
Traceback (most recent call last):
  File "fnf_converter.py", line 551, in exportAsOsz
  File "fnf_converter.py", line 176, in exportOsuFile
  File "fnf_converter.py", line 272, in getNotesAll8K
  File "fnf_converter.py", line 303, in getNotesPlayer
ValueError: invalid literal for int() with base 10: 'Alt Idle Animation'

FFmpeg is installed, and the python version is 3.9

Issue closed; chart-specific issue.
In my case, there is a string inside of an number-only array.

First way on how to fix it:

Delete the text and you should be good.

Also, it may raise some errors; instead of deleting only the text, delete the whole note itself
Second way on how to fix it:

Delete the note.


change specification for Cloud RPC Client

Currently in the specifications here: https://github.com/eclipse-uprotocol/uprotocol-spec/blob/main/up-l2/rpcclient.adoc
It says:
"The UUri and UAttributes passed to invokeMethod() MUST be cached non-persistent memory per call, this is to be able to complete the Future when the response is received from the server."
This might be a problem for cloud implementations since the node that sends the rpc request, might not be the same node receiving the rpc response. It could be difficult or inefficient to implement the MUST be cached non-persistent memory per call.
We would need to solve this problem by using something like an Akka Cluster that distributes the in-memory calls or use a database to persist the information while the stateless nodes poll for the response.

I'm fixing this on #53


Deduplicate and simplify code in HttpPostMultipartRequestDecoder

Motivation:

A HttpPostMultipartRequestDecoder contains two pairs of the same methods: readFileUploadByteMultipartStandard+readFileUploadByteMultipart and loadFieldMultipartStandard+loadFieldMultipart.
These methods use NotEnoughDataDecoderException to detecting not last data chunk (exception handling is very expensive).
These methods can be greatly simplified.
Methods loadFieldMultipart and loadFieldMultipartStandard has an unnecessary catching for the IndexOutOfBoundsException.

Modifications:

Remove duplicate methods.
Replace handling NotEnoughDataDecoderException by the return of a boolean result.
Simplify code.

Result:
The code is cleaner and easier to support. Less exception handling logic.

@Scottmitch @trustin PTAL as well.

Cherry-picked into 4.1 (3e9f617504adb6f3ac984a9320020dd2c202739e)


Add option to stick the element to bottom or top depending on scroll direction

Requested Update
Add option to stick the element to bottom or top depending on scroll direction
Are There Examples Of This Requested Update Elsewhere?
As here: http://leafo.net/sticky-kit/ - example Scrollable Sticky Element, the "Very tall sidebar" div is dynamically sticked to top when you scroll bottom, or to bottom if your scroll direction is top.
Thanks.

Hey @jdolinski1
This has been discussed in other issues. Here is link to a demo.
~Thanks

Hello, you did not provided link to a specific demo, just list of demos. Please advise which one i should focus on.

@jakiestfu did you manage for this one?

This snippet allows the same behavior found on this page:
https://www.zara.com/fr/fr/mini-jupe-à-ceinture-p04886254.html
const stickyEl = document.querySelector('.myStickyEl')
const distanceFromTop = 120 // adjust as you wish
let scrollPos = 0

const setStickElTop = directionIsDown => {
  stickyEl.style.top = directionIsDown
    // allows to scroll to bottom when sticky element is highter than viewport
    ? window.innerHeight - stickyEl.offsetHeight + 'px'
    : distanceFromTop + 'px'
}

// will show upper part of the sticky element when scrolling up
const scrollListener = () => {
  const top = document.body.getBoundingClientRect().top
  setStickElTop(top < scrollPos)
  scrollPos = top
}

window.addEventListener('scroll', scrollListener)
stickybits(stickyEl)

Enjoy


mysterious mapbox users filter

I was just having a play, trying out viewing notes in London using this tool with this URL https://www.mapbox.com/osm-comments/#/notes/?q=bbox%3A0.3021%2C51.7253%2C-0.5576%2C51.2550    but is seems as though there's an additional filter going on, maybe it's filtering just mapbox data team users? Any way of using the tool for browsing notes from all users?

Hey @harry-wood - yes, since we are primarily using this as an internal tool, the default is to search through all users of our team.
You can easily over-ride this, though by searching for users:* - example search: https://www.mapbox.com/osm-comments/#/notes/?q=users%3A*
Will add this to documentation. Thanks for pointing it out.

And multiple filters can be just space-separated, so for the bounding box query, you'd have something like https://www.mapbox.com/osm-comments/#/notes/?q=bbox:0.3021,51.7253,-0.5576,51.2550 users:*
Thanks again for trying it out and would appreciate any more feedback.

Also, just to add, the users are defined in https://github.com/mapbox/osm-comments/blob/mb-pages/app/config.js#L6 . Hope that clears the mystery :) - am creating a ticket to make the documentation around this better.

Thanks - never thought of using "space" as a separator.


Update Thailand testcases

Proposed change

This PR adds test cases for all known special holidays in Thailand, increasing test coverage.
Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good: make pre-commit
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
[x] The related documentation has been added/updated (check off the box for free if no updates is required)

Coverage: 99.728%. Remained the same when pulling e60fb75e221753d98b8d251eae506cdc5a550917 on PPsyrius:thai-inlieus-testcase into af76470c81d1a270d2a1ebc980821f3ffb446c0a on dr-prodigy:beta.


feat: Add docs for actor-to-actor integrations

(Added the label to trigger the PR toolkit)

@drobnikj Added it to the integrations description page. I'd add the screenshots once we have it released for all users (so the preview tag won't be there)


fix Autovalidate enum references in fix data

This fixes a typo in the fix data file which leads to generating bogus (non-existent) enum references.
It's also worth noting that these fixes don't auto add the required import.  (There's a way to do that with variables but I don't quite know the magic...)
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Yes, they can. The replacement text can use a variable and the variable can be specified as type 'import'.

Hey @kf6gpe, I don't think this was cherrypicked to 2.0. Did we get something mixed up in the cp tracking?


[stable/prometheus-rabbitmq-exporter] Rabbitmq prometheus exporter should use the same name for the port

Signed-off-by: Luke Alexander<EMAIL_ADDRESS>What this PR does / why we need it:
The Prometheus RabbitMQ exporter should use the same port name in the service template that is defined in the monitor template, otherwise the serviceMonitor will not scrape successfully
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test
/lgtm


Add support for ES6 import syntax

This might be a long shot but I'd like to see this in browserify.
The ES6 module syntax has a few nice features compared to commonJS require method,
namely bindings and cyclic dependencies.
Since these things are in the ES6 standard it seems reasonable to work them into browserify too!
Note that just using a ES6 to ES5 transpiler wouldn't work in this case because these are cross module concerns.
For instance, babelify is only able to transpile import foo from 'foo' to var foo = require('foo') at file-level, but this does not allow cyclic dependencies.
The Esperanto project has a nice way of handling things but lacks too many features to be a valid replacement for browserify.
Is there any possibility to see support for ES6 import syntax come to browserify?

I've been waiting for this feature to land in node first so browserify can match the semantics properly. I'm also concerned that if browserify implements a default es6 import mechanism while node doesn't have one, it will needlessly fragment browser and server ecosystems.

Yes, my approach to writing modules is currently to write them in ES6 but only expose ES5-compliant
code (transpiling everything on npm publish for example).
I get your concerns, and they are indeed important ones.
How feasible would you say it is to expose this as a plugin for browserify (I'm currently looking into
writing that).

I've created a small gist with a proof of concept for a plugin. I'll start working on it!

@romeovs
You can already use a transform like babelify to get ES6 imports. With both Node and Browserify. You can turn off the other features if you don't want them.

@nmn but do these imports have the complete ES6 semantics?
As far as I can see they just transform the import statements into require statements, but require and import have different semantics with respect to bindings and cyclic dependencies.
The problem is really the way browserify concatenates the imported files. esperanto does this correctly, but lacks other features that make browserify a much better choice.

@nmn after some testing I can see that it does!

I think @substack is right in waiting for proper node support. browserify brings node to the browser; if node doesn't support import, browserify shouldn't either.
If babelify doesn't follow the right semantics, lift the issue with them or ask for an esperantify plugin.

How about now?

It appears a good deal of fragmentation will start occurring because of<EMAIL_ADDRESS>relying on es6 imports. It's not seen an official release yet, but given the buzz around its components I think it's already becoming somewhat of an issue.
I know that Node doesn't support ES6 imports quite yet, but arguably browserify is in a somewhat different spot since it doesn't support dynamic imports (or at least I don't think it does out of the box).
The reason why I think we should consider options is because if  other loaders become popular because of only a single feature, it might signal there's a need for it.
I'm not quite sure what the correct resolution is; for the package I'm writing that consumes d3 I might include a compiled build (breaking npm reliance) or include babelify (making the package very heavy) - though neither is ideal. Perhaps an importify transform needs to be written, or perhaps  this should be resolved at the browserify level - I'm not sure.
For now I'm posting this here to signal that changes are happening, and we'll probably need to think of a solution for this 😕

@yoshuawuyts Implying that<EMAIL_ADDRESS>only works with loaders that support ES6 modules is a bit disingenuous. The main field in the root's package.json and the individual modules all point at Node.js compatible files (and I'm successfully using several d3 modules with Browserify just fine)

Browserify's greatest feature is the transform pipeline (heck the parts that actually break require into a dependency tree and combine that tree into a bundle aren't even in this repo, they're the module-deps and browser-pack packages) and the collection of transforms we have that make . IMHO rollup's greatest feature is not ES6 imports, but the static analysis and tree shaking it does. So even if browserify rushes to hastily implement non-babel ES6 import support before any JS engine natively supports it, I doubt that'll stop may people from using rollup.
There are already a pile of other packages using ES6 import; but they all do it alongside the use of other ES2015 features. So I expect packages like d3 that only use ES6 import is going to be a rarity. And the moment you use any other feature, you need Babel, whether you're using rollup or browserify. So I doubt "rollup lets me use packages that only use ES6 import without needing Babel" will be the reason people use rollup.
I think the problem browserify is going to have is rollup's plugins. That functionality is what turns rollup from just a tool to pack up ES6 exports/imports into something that can pass as a standalone loader.
Rather than trying to hack ES6 import in with require schematics, just as a way to bypass babel in a few cases (because if you use Babel this is already entirely possible). I think it would be better to accept the area that rollup is better at (tree shaking ES6 imports) and find a way to break up rollup and create a rollupify plugin that will integrate rollup's tree-shaking and also act as an optional ES6 import handler for those that don't want to use babelify.

It's a different topic. But I think browserify's other undoing may be how easy it I've seen it is to make a simple transform but hard it is to make one that correctly preserves source maps. I don't see any easy tools for source-map aware string manipulation. And while I'd love to transform using an AST, that's not viable when each transform has to source -> parse to AST -> transform -> AST to source -> source instead of sharing an AST. At this point, in my own code, I can't tell if my source maps work or not anymore and I have no clue which piece might be at fault for messing with them.

FYI: there's an enhancement proposal for Node.js being discussed here regarding ES2015 modules:

https://github.com/nodejs/node-eps/pull/3

Coming in to say I'm actively getting issues because d3's latest version is only using ES6 syntax. I can't use my browserify tooling now. The time seems ripe for this change as the ecosystem has already begun the move, otherwise I think browserify will have lost its relevance in this increasingly competitive bundling space.

Hello @TatumCreative. D3's README says their releases support CommonJS. Is that not the case? Even so, there are multiple tools for compiling ES6 module syntax to CJS -- can you not use one of those?

Hmm... Yeah my bad. It looks like user error on my part. Sorry about that. My opinion still stands though. Three.js just landed a big patch to go the ES6 route as well. Personally I'm in a weird position as I tend to primarily target one browser and I want what Browserify does with bundling without the side-effect of mangling my ES6 code and turning it into ES5 code.
I can probably come up with a solution if I do more research, but regardless I still feel it is important to support ES6 imports sooner rather than later, as the community is already adopting it in projects. I feel like fragmentation is happening as people have moved on to other bundling solutions, which I would really not have to do, as I really love the browserify tooling ecosystem. All that said, I probably don't have the time to contribute to this project to make it happen, and I appreciate the work everyone does here!

@TatumCreative I'm glad that you were able to correct this issue. The contributors to Browserify, including myself, understand your frustration.
Browserify has always been a way to use Node.js-compatible modules in the browser. As a result, Browserify has always looked to Node.js for how to implement the module resolution and loader. Right now Node.js doesn't support ES6 imports; there are blockers in other parts of the stack. We don't yet know the final algorithms or behaviors.
While slower than we would all like, these efforts are moving ahead. I'm excited for the day! Once Node.js has implemented ES6 imports and exports, we can add support to Browserify.
You may wish to opt-in to a possible future, and Browserify's plugin system allows you to do so. But it's not the place for us to make that decision for everyone.

@TatumCreative Ok, no problem, thanks for the feedback.

Personally I'm in a weird position as I tend to primarily target one browser and I want what Browserify does with bundling without the side-effect of mangling my ES6 code and turning it into ES5 code.

I understand. That's not that weird of a position, as people increasingly want to selectively transpile parts of ES6. For example, only transpile the parts not natively supported by recent versions of Node. ES6 has no native module bundling story anyway, so even if a browser supported ES6 100% you might still want to bundle them via transpiling just module syntax to ES5.
I think there's probably a solution for you. If I'm not mistaken some people run Rollup to convert module syntax before carrying on with bundling with Browserify, or you could run Babel (Babelify) with just the module transform enabled. With Rollup you could get the benefit of tree shaking as well.

but regardless I still feel it is important to support ES6 imports sooner rather than later, as the community is already adopting it in projects.

Like other people have mentioned, the community is adopting the syntax and speculating about what behavior will be standardized. So it's not necessarily all smooth sailing to implement it now. For example, from version 5 to 6 the core Babel CommonJS module transform made a big change in its output. If you look at the issue linked in the comment before yours up above you'll see that the discussion about how to implement ES modules in Node is epic and very complex.

I feel like fragmentation is happening as people have moved on to other bundling solutions

I think that has more to do with other factors than this.

I appreciate the work everyone does here!

Thanks!

Thanks @jmm and @terinjokes! I think that is very well reasoned, and I agree with where you all are coming from. I'll probably end up adding another tool to help me deal with this until all of this gets sorted out on the node end. I can deal with a little bit more tooling complexity on my end :) I'm almost afraid to read that node module discussion, lol.
Keep on rocking it! 😀

For anyone coming into this thread, the browserify transform rollupify will take all of your ES6 import statements and hoist them all into a single module scope.

I am assuming I can't use ES6 style imports with browserify and babelify still?

You can use babelify and things will work - it's still not recommended
though, given that Node has no support for it
On Wed, 4 Jan 2017, 15:33 George Katsanos<EMAIL_ADDRESS>wrote:

I am assuming I can't use ES6 style imports with browserify and babelify
still?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/substack/node-browserify/issues/1186#issuecomment-270383970,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWleq1joqUYnVh2Zr91XLw-dGrSngm4ks5rO62pgaJpZM4D4Vtf
.

I use browserify in Gulp.. does this change things?:)

Nope
On Wed, 4 Jan 2017, 15:45 George Katsanos<EMAIL_ADDRESS>wrote:

I use browserify in Gulp.. does this change things?:)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/substack/node-browserify/issues/1186#issuecomment-270386851,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWlem6m1eKTQn1jgG2Br7bqWwhgBbCFks5rO7BtgaJpZM4D4Vtf
.

What does "not recommended" mean? The end result seems to work?
Should I just drop gulp/browserify and use webpack instead?

I mean that Node doesn't have support for import and last I checked parts
of the spec are still not done and might change even. If you want things to
work everywhere, today and in the future, require is a more stable choice.
I don't want to debate anyone on this, I'm sure other people have other
views on this.
On Wed, 4 Jan 2017, 16:01 George Katsanos<EMAIL_ADDRESS>wrote:

What does "not recommended" mean? The end result seems to work?
Should I just drop gulp/browserify and use webpack instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/substack/node-browserify/issues/1186#issuecomment-270391071,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWlelQGOr3-AA2Jzh9voscMTuuBjzK8ks5rO7RagaJpZM4D4Vtf
.

Alright. From reading around it seems to me that's the basic syntax is pretty finalized and is the future but I could be wrong of course.

@gkatsanos the syntax is stable, but the mechanics of how to do imports (and specifically, how Node.js will do imports) are still being figured out.
Browserify is a set of tools that together bring Node.js's module resolution and loading to the browser. Since Node.js doesn't support importing ES6 modules, we have nothing to implement.

@terinjokes alright, it's clear. How does browserify compare to webpack in that respect?

@gkatsanos Being module bundlers, Webpack and Browserify are similar. They take input, resolve a tree of dependencies, and generate a bundle (or bundles) as output.
As described above, Browserify supports only require at the moment. Webpack supports of the illusion of other module types, including AMD and ES6, but the resolution algorithm is the same. If you used AMD modules expecting dependencies resolution according to AMD's rules, you'd be surprised to learn that it instead uses the Node.js rules!
Neither project knows how Node.js will handle ES6 resolution and loading. There have been discussions of using separate file extensions or looking up a key in the module's package.json. We'll have to wait and see gets implemented.
Webpack's plugin system would likely allow them to pivot and allow developers to configure which behavior they want. Browserify prefers waiting for Node.js to decide and not have the need for configuration or the fears of breaking user applications.

@terinjokes is right, we (at webpack) leverage nodes module resolution but allow allow plugins to define other types of dependencies and resolution patterns. If one becomes obsolete (like System.import did) and drop out the plugin from core. Below is a link to our resolver if you are curious.
https://github.com/webpack/enhanced-resolve

Thank you both, many things learned today.

@terinjokes one follow up: today I was trying to solve the infamous
'import' and 'export' may appear only with 'sourceType: module'
error, and discovered that the Bootstrap v4 JS plugins (Carousel and others) use the ES6 syntax.
Is there a way around this to keep using Browserify and using ES6 -based JS modules living in node_modules? (babelify doesn't transpile node_modules)

@gkatsanos I'm not sure how you're importing the bootstrap modules, but both node_modules/bootstrap/dist/bootstrap.js (the "main" import, if you had just done require('bootstrap');) and node_modules/bootstrap/js/dist/carousel.js are ES5 modules.

@terinjokes (referring to Bootstrap v4) :
https://github.com/twbs/bootstrap/blob/v4-dev/js/src/carousel.js
...
import Util from './util'
export default Carousel

@gkatsanos If you installed<EMAIL_ADDRESS>as noted in their Quick Start you'll see that they distribute ES5 code (by default) for this reason.

@terinjokes This is the code from alpha.5 :
https://github.com/twbs/bootstrap/blob/v4.0.0-alpha.5/js/src/carousel.js
and I believe this is ES6 modules?

@gkatsanos In the npm releases they distribute ES5 code. That is, they compile the ES6 to ES5 before publishing the package.

@terinjokes sorry, not following. The compiled version isn't related to what we're trying to do here which is use only one out of 10 Bootstrap plugins :) (a bit like how we can import lodash.debounce without loading the entire lodash library.)
https://github.com/twbs/bootstrap/commit/ce2e944aa6957528f23f1f7e680ac0cb4a75dcac

var Carousel = require('bootstrap/js/carousel);

Nah, doesn't work because the Carousel module is requiring another library (with ES6 imports) - I read on it and it seems Bootstrap v4 hasn't yet made it possible for people to use plugins independently.

I'm curious what the current feel is on this, now that ES6 modules are in browsers (at least in some form). I've also noticed more modules on npm being published with code that works fine in Webpack/Rollup/Parcel (and other ES6-able bundlers) but does not work in Browserify.
I personally don't like import/export but if the rest of the community is using it, and browsers are adopting it, I feel Browserify should definitely follow suit, even if Node.js hasn't fully adopted it yet.

I don't agree; until node supports it unflagged, browserify shouldn't support it.
Browsers only currently support URLs with import, and node doesn't support URLs with import.

It doesn't really matter. No-one is using browserify any more. It's hanging out with its old buddies Grunt and Gulp somewhere.

@ljharb Makes sense.
Another option: what about allowing import syntax and just ignoring it? Or perhaps providing a warning that it was skipped? I'm enjoying the new dynamic import() support in browsers (which isn't possible to fully re-create with a bundler), but I can't use that syntax currently in browserify.
In the mean time I am considering writing a small transform to handle this transparently so users don't need to deal with babel/config/etc.

(dynamic import() is also available in Scripts, import is only available in Modules)

It wouldn't be safe to treat a Module as if it was a Script - modules are in auto-strict mode, for examples, and there's a number of things that could behave differently.

For the mean time, I've created a browserify plugin that:

Adds .mjs extension to browserify so that it takes precedence over .js
Use "module" field in package.json (when "browser" is not specified)
Transform ES Module import/export syntax into CommonJS so that it can be consumed & used by browserify

See here:
https://github.com/mattdesl/esmify

I am happy and excited with the upgrade

Let's work together to meet my obligations to work

Since now its in experimental state in node? What is the state of this?

Experimental means it’s too soon for it to be used. Browserify should not support ESM until it’s supported unflagged in node; and once it is, imo browserify must support it.

ES Modules are no longer experimental in Node 13.2 and are supported natively.
https://github.com/nodejs/node/commit/796f3d0af49164314868c4778af90eca356f1fef
https://github.com/nodejs/modules/blob/master/doc/unflagging-announcement.md

They remain experimental, they’re just unflagged.
However, it means the clock has started, so it would be good to begin working on the necessary changes - although best to leave them unmerged/unreleased for now.

It looks to me like the discussion here is directly related to the problem I'm experiencing as outlined on my question here at StackOverflow: Browserify --standalone with ES6 modules and multiple source files and exports
In short, Browserify does not support ES6-style modules using the import syntax with the --standalone option.
Is that correct? If so, it's going to require some big-ish changes to either my code or my build pipeline, and I would like to make sure I'm understanding this properly before I do.

I would expect that currently browserify, with every option, requires a code transform first to convert from ESM to CJS before being able to continue.

I am already using babel via the babelify transformation. Should that work?
I have a minimal example to reproduce my problem on my StackOverflow question.
What I'm seeing is, browserify creates the expected API module in its output, but it includes exports from only one of the input source files. See pastebin here (Chrome pretty-printed version of the same thing here); source files are a.js and b.js, each of which export a single function. When running in the browser, the TestModule created by Browserify includes exports from all the source files in its definitions. But for some reason, the TestModule only gets the very last module that was included in those definitions. So in my example, TestModule only includes the fromB() function exported in b.js. TestModule does not end up with the fromA() function exported in a.js.
I thought the issue discussed here might be related to my problem, since I'm defining the exports using the ES6 syntax. But maybe since I am already using babelify, this is different? From the gulpfile:
function minimalExample(done) {
    return browserify({
            entries: [
                './src/a.js',
                './src/b.js'
            ],
            standalone: 'TestModule'
        })
        .transform('babelify')
        .bundle()
            .on('error', log.error)
        .pipe(source('minimalExample.js'))
        .pipe(plumber())
        .pipe(gulp.dest('./dist'));
}

BrowserifyModuleTest.zip
Here is a complete example of the problem I am having. Unzip the file into its own folder. I use yarn, so 'yarn install' followed by 'yarn build' creates output files in the dist/ folder. Open test.html in a browser, then go to the console to see the output.
Let me know if this helps, or if there is a better way of sending this.

If you have multiple entry points, all of them are executed, but browserify doesn't merge modules, which could cause bad unexpected behaviour. Usually multiple entry points are used primarily for things like polyfills, where you have one or more modules that do not export anything, and then one module that does:
entries: [
  './polyfills.js', // no exports
  './app.js', // yes exports
]

or with browserify plugins that then split each entry point's dependency tree into separate bundles at a later stage, so each bundle only ends up with a single entry point in the end.
If you want to expose multiple modules as one object, you need to combine them in a separate module:
// main.js
export * from './a.js'
export * from './b.js'

and then use that as the entry point.


fix: allow stub a middleware method and fix components scan

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 95.677%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
2911

Relevant Lines:
2920

💛  - Coveralls

:tada: This PR is included in version 6.114.3 :tada:
The release is available on:

v6.114.3
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 7.0.0-beta.12 :tada:
The release is available on:

v7.0.0-beta.12
GitHub release

Your semantic-release bot :package::rocket:


Dicom image import issues

1. Incorrect display for 16 uint dicom file
When I load a 4D uint16 grey scale dicom file to the software, it displayed the image with some issues like below:

After converting to 8-bit, it recognizes it as 8-bit RGB.

**2. Cannot display 3D image
Only displayed the first slice of 3D image.
Is it possible to load the 3D image from dicom or video file instead of using the a sequence of 2D images?
Thanks.
A 4-D dicom example (x, y, channel, z):
test_dicom.zip

@xycyx thanks, I saw, ImagePy now did not support 4D image, I will have a look how ImageJ do! I think it is not real 4D, It is just a sequence of 3D, I will think how to display "4D".
About reading 3D image, https://github.com/Image-Py/itk-plgs, some ITK plugins, and you can add new format reader and writer esaily.
About reading video, I would write some demo and upload here: https://github.com/Image-Py/opencv-plgs.
(ImagePy is just a pure python framework, based on numpy, scipy, scikit-image, And I would to build many plugins with opencv, tf, itk... finally build a image processing ecosystem, and user can write and upload their plugins to ImagePy)


Improve translation file

Hi.
Escape characters are not translatable. But some strings (pref_notification_priority_*) have them. I don't include "'" that has far as I know can not be avoided with the default Android translation system.
But the other ones can be avoided, and it would make life easier for potential non-programmer translators.
I am also wondering why there is a string (toast_front_string) that is empty.
Regards.

Hi, thanks for your translate.
"toast_front_string" is a useless code and I forgot to remove it.
Yes, it's a bad behavior to add '\n' in translate file. But I don't know how to control the layout of PreferenceActivity...
With '\n':

Without '\n'


Only match emoji autocomplete after two characters

https://regex101.com/r/QNAtHZ/5
Closes #1355

Why is this a do not merge?

The regex isn't matching correctly and I can't think of a proper fix -- it'll match multiple : after the emoji. i.e. :smile::::

It's not, according to the regex101 you put in the OP. Putting test lines with multiple trailing :s in the input there, they don't match.

@dgw, I could make :smile::: match indeed.
@MaxLeiter, what about \B:([-+\w]+[-+\w:])$?

 It works for me, but I don't know if there is a better way.

@astorije I could not. But I see you're on regex v5; when I checked, it was still showing v4, so :man_shrugging:

OP is regex 5; maybe weird caching thing going one

@MaxLeiter I clicked the link from the GitHub email, and I see you edited the OP, so that's probably it.

@MaxLeiter, what about \B:([-+\w]+[-+\w:])$?

Isn't this working in the end? I have tried a few things with it and it seems fine to me.

@maxpoulin64 any thoughts/comments on using \B:([-+\w]+[-+\w:])$?

Okay so @MaxLeiter and I identified an issue with the new Regex, something that we cannot overcome with a simple Regex. From the channel:
21:59 <MaxLeiter> the second : (end of the word) doesn't match correctly
21:59 <MaxLeiter> so if you type the full complete (i.e. :smile: or :+1: as opposed to :+1 it doesn't autocomplete0
22:00 <MaxLeiter> do we want that?
00:03 <astorije> Ah, I see the problem, MaxLeiter, one sec
00:03 <astorije> Essentially, the Regex is fine, but then the matched keyword includes the ":", which is not part of the emoji map
00:07 <astorije> >e can't have ":" part of the ()
00:21 <astorije> Uuuh, I don't think it can be done without altering the lib :/
00:21 <MaxLeiter> yeah
00:22 <MaxLeiter> which makes the regex a PITA
00:22 <MaxLeiter> so i say we go with "lesser of the evils"
00:22 <MaxLeiter> question is which one
00:22 <astorije> So we have 2 cases, which is fine with "|", except that it triggers 2 capture groups, and one will always be undefined
00:22 <astorije> And the lib always takes the first one, even if it's undefined
00:28 <astorije> Honestly, taking my solution and stripping the last char if ":" would work
00:28 <astorije> It feels gross though
00:33 <astorije> Actually, I have an idea

After a bunch of attempts, this is the "best" that I can come up with:
──────────────────────────────
modified: client/js/lounge.js
──────────────────────────────
@ lounge.js:51 @ $(function() {
 	const emojiSearchTerms = Object.keys(emojiMap);
 	const emojiStrategy = {
 		id: "emoji",
-		match: /\B:([-+\w]+[-+\w:])$/,
+		match(textFromHeadToCaret) {
+			// Matching text is either any 2 chars, or 1 char IF followed by a `:`.
+			// Since we cannot have a single capture group to express those two
+			// conditions, we have to check is any matches, and use it as a match
+			// term if so.
+			const oneCharCheck = /\B:([-+\w]):$/;
+			if (oneCharCheck.test(textFromHeadToCaret)) {
+				return oneCharCheck;
+			}
+			return /\B:([-+\w]{2,}):?$/;
+		},
 		search(term, callback) {
 			const results = fuzzy.filter(
 				term,

Done

I really don't like the fact this introduces more regex testing (which will run every time you type a character in input), at this point it's most likely cheaper to just trim the : in callback function.

I really have no preference. @astorije?

I'm not sure it's cheaper in both code or performance (hitting an extra regex per char is not going to change anything, but I see where you're coming from). When I tried, I couldn't get something 👌 when trimming after the fact, it always came back to having to do something like this.
 Happy to change my mind if you can make this work.
But overall, I just want this change in like ASAP 😅

@MaxLeiter, mind trying this out in an extra commit (for now)?

@MaxLeiter, come back, we need youuuuu 🙏 :)

Couldn't make anything work well.

@xPaw, do you want to give it a quick try to see if you can help out @MaxLeiter?

As I've commented before:

at this point it's most likely cheaper to just trim the : in callback function.

@xPaw, the ping is because @MaxLeiter couldn't make that work.

Now that was a pain to update fork branch, but I've changed it to trim as I suggested.


[hotfix][docs] Removed duplicate 'is'

What is the purpose of the change

Document correction

Brief change log

Removed duplicate is in doc

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? ( not applicable / docs / JavaDocs / not documented)

Hello @wuchong @leonardBang - Can you please review this PR ? Thanks


Consideration for Growth Factor

When you access the URL bellow, you find orientation about parameter Growth Factor.
https://docs.microsoft.com/en-us/azure/site-recovery/hyper-v-deployment-planner-run#considerations-for-growth-factor
Documentation don't clarify if we need inform growth factor per day, month or year.  Which measure of time can I consider?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fbf128d7-d77d-12dd-f497-98d39c8d9d01
Version Independent ID: 10d01522-5838-982d-d5fd-c796509d90b1
Content: Run the Azure Site Recovery Deployment Planner for Hyper-V disaster recovery to Azure
Content Source: articles/site-recovery/hyper-v-deployment-planner-run.md
Service: site-recovery
GitHub Login: @mayurigupta13
Microsoft Alias: mayg

@ussantos  Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

assigning to doc authors for review.

Thanks for your feedback. As the doc states, you can use the growth factor as works for you. You can generate multiple reports with different growth factors with the same profiled data. For example, you could assume 10% over a quarter and 30% over a year, in accordance with your specific app usage and growth projections.
#please-close


An error has occurred.

Got this when asking for a dashboard that uses a model connected to Athena. Other dashboards work fine. I'm thinking MAYBE it's a permissions issue with the model? Either way maybe a more helpful error message could be produced?
11:45:55 web.1 |  { message: 'An error has occurred.', 11:45:55 web.1 |    documentation_url: 'http://docs.looker.com/' }
In the slack chat the bot just edit's it's message to say "An error has occurred".

That's true – the bot just relays the error message Looker provides which in this case is basically useless.
Perhaps the Looker logs will have more information.
If it's a permissions issue it may be because the bot user does not have access to that model?

It did indeed turn our to be a permissioning issue. Found out by sudoing as the Looker bot user. Thanks!


Removing and regenerating .godot folder breaks project while plugin is installed

Describe the bug
If the .godot folder is removed and needs to be generated again. The plugin will enter a broken state which prevents the plugin from running and prevents any scene from being run.
Affected version

Dialogue Manager version: 2.38.0
Godot version: 4.2.1.stable.mono

To Reproduce

Create new Godot Project
Download Dialogue Manager Addon
Create test.dialogue file
Create Node2D Scene and save
Attach script to Node2D scene
Call test.dialogue file on first frame of _PhysicsProcess (Not strictly required but that is where I called it from)

    private Resource dialogue = GD.Load<Resource>("res://test.dialogue");
    private bool first = true;

    public override void _PhysicsProcess(double delta) {
        if (!first) return;

        DialogueManager.ShowExampleDialogueBalloon(dialogue, "this_is_a_node_title", new Array<Variant>() {this});
        first = false;
    }

Save Project and close Godot
Delete .godot folder
Open project again.

Expected behavior
When the .godot folder is regenerated, the plugin should keep working.
Screenshots
When Godot first loads we get the following parse error messages:

When running the scene the following error stops the scene from loading:
Invalid call. Nonexistent function 'get_next_dialogue_line' in base 'Nil'.

Stackframes (Apparently Godot does not make it easy to copy these or I couldn't find it)

Also when running the scene the following errors show up in the Debugger:
E 0:00:01:0205   NativeCalls.cs:9004 @ Godot.GodotObject Godot.NativeCalls.godot_icall_3_981(nint, nint, string, string, int): Cannot open file 'res://.godot/imported/test.dialogue-c753d1c1c091aac077788a0b087c8b29.tres'.
  <C++ Error>    Condition "err != OK" is true.  Make sure resources have been imported by opening the project in the editor at least once.
  <C++ Error>    Condition "found" is true.  Make sure resources have been imported by opening the project in the editor at least once.
  <C++ Error>    Condition "found" is true.  Returning: ret
  <C++ Source>   core/core_bind.cpp:73 @ load()
  <Stack Trace>  NativeCalls.cs:9004 @ Godot.GodotObject Godot.NativeCalls.godot_icall_3_981(nint, nint, string, string, int)
                 ResourceLoader.cs:100 @ Godot.Resource Godot.ResourceLoader.Load(string, string, Godot.ResourceLoader+CacheMode)
                 ResourceLoaderExtensions.cs:27 @ T Godot.ResourceLoader.Load<T>(string, string, Godot.ResourceLoader+CacheMode)
                 GD.cs:129 @ T Godot.GD.Load<T>(string)
                 Node2D.cs:9 @ DialogueManTest.Node2D..ctor()
                 :0 @ object System.RuntimeMethodHandle.InvokeMethod(object, System.Void**, System.Signature, bool)
                 :0 @ object System.Reflection.ConstructorInvoker.Invoke(object, System.IntPtr*, System.Reflection.BindingFlags)
                 :0 @ object System.Reflection.RuntimeConstructorInfo.Invoke(object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo)
                 :0 @ object System.Reflection.MethodBase.Invoke(object, System.Object[])
                 ScriptManagerBridge.cs:171 @ Godot.NativeInterop.godot_bool Godot.Bridge.ScriptManagerBridge.CreateManagedForGodotObjectScriptInstance(nint, nint, Godot.NativeInterop.godot_variant**, int)

Workaround
I found a workaround that seems to get the project back to a working state.

Open Project
Go into Project Settings
Plugin Settings
Turn off Dialogue Manager
Turn on Dialogue Manager
Close Godot making sure to say Save and Quit
Reopen the project
Select any dialogue resource
Go into Import settings
Click Reimport
Run scene

That's an issue with how Godot does a clean load of the file system. Doing a second project reload always works for me whenever I need to empty the .godot cache.

Ah I see. It was not affecting my other plugins so I assumed (incorrectly) that it was a bug in how the plugin was registering itself.
Thanks for your time and quick response.


Support default imports

Here's how you import mockRedux right now:
import { mockRedux } from "mock-redux";

There's no real reason why we wouldn't be able to support this:
import mockRedux from "mock-redux";

If you'd like this to be doable, feel free to send a pull request adding it in!

Fixed by #22 :tada:


Error implicating imported features on core features

While testing constraints, I encountered the following issue, but it only occurs in this particular configuration. See screenshots.

Important: If other features are used on both import1-side and the other side, taut will not occur.

It's the same for me. looks really weird.

Maybe solved by #94

Fixed by #94


Not able to import messages

Not able to import messages module.
It has dependency on jsonconfig-tools, which is failing
Python 3.8.10 (default, Jun  2 2021, 10:49:15)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import messages
/usr/lib/python3/dist-packages/secretstorage/dhcrypto.py:15: CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead
  from cryptography.utils import int_from_bytes
/usr/lib/python3/dist-packages/secretstorage/util.py:19: CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead
  from cryptography.utils import int_from_bytes
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ktawde/.local/lib/python3.8/site-packages/messages/__init__.py", line 7, in <module>
    from .api import send
  File "/home/ktawde/.local/lib/python3.8/site-packages/messages/api.py", line 3, in <module>
    from .email_ import Email
  File "/home/ktawde/.local/lib/python3.8/site-packages/messages/email_.py", line 15, in <module>
    from ._config import check_config_file
  File "/home/ktawde/.local/lib/python3.8/site-packages/messages/_config.py", line 12, in <module>
    import jsonconfig
  File "/home/ktawde/.local/lib/python3.8/site-packages/jsonconfig/__init__.py", line 7, in <module>
    from .core import Config
  File "/home/ktawde/.local/lib/python3.8/site-packages/jsonconfig/core.py", line 11, in <module>
    from .jsonutils import to_json_file, from_json_file
  File "/home/ktawde/.local/lib/python3.8/site-packages/jsonconfig/jsonutils.py", line 29, in <module>
    to_json = box._to_json
AttributeError: module 'box' has no attribute '_to_json'

Fixed with version 0.7.0, uploaded to PyPI.


Do not negotiate SSL again for RESEND packet.

This is a fix for #299. Tested against Oracle Cloud Autonomous Transaction Processing Database versions 19c and 21c.

It will not work
I test it many time against 12c and 19c and not work


pr1 ~ remove rayon+lib.rs cleanup

additionally realized that csum was csumoffload in the original dpdk/nb code. So i renamed it to be proper. We can remove it later if need be (once we clean-up native guts).

Codecov Report

Merging #88 into master will decrease coverage by 32.3%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #88       +/-   ##
==========================================
- Coverage    51.1%   18.8%   -32.31%
==========================================
  Files          70      69        -1
  Lines        4283    4280        -3
==========================================
- Hits         2189     805     -1384
- Misses       2094    3475     +1381

Impacted Files
Coverage Δ

framework/src/packets/icmp/v6/mod.rs
6.49% <ø> (-53.25%)
:arrow_down:

framework/src/packets/icmp/v6/too_big.rs
10% <ø> (ø)
:arrow_up:

...amework/src/packets/icmp/v6/ndp/neighbor_advert.rs
5.4% <ø> (ø)
:arrow_up:

framework/src/packets/ip/v6/srh.rs
4.95% <ø> (-78.1%)
:arrow_down:

framework/src/packets/icmp/v6/echo_reply.rs
5.88% <ø> (ø)
:arrow_up:

framework/src/packets/icmp/v6/ndp/options/mtu.rs
6.89% <ø> (-17.25%)
:arrow_down:

...ramework/src/packets/icmp/v6/ndp/router_solicit.rs
18.18% <ø> (-36.37%)
:arrow_down:

framework/src/utils/mod.rs
97.36% <ø> (ø)
:arrow_up:

framework/src/packets/icmp/v6/echo_request.rs
5.88% <ø> (ø)
:arrow_up:

framework/src/packets/icmp/v6/ndp/router_advert.rs
8% <ø> (-49.34%)
:arrow_down:

... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec310b...cf73e08. Read the comment docs.


Australian Scheme Question from review of Guidance

This question was received from the Australian scheme:
"Hey Josh,
We are still reviewing the document and a reviewer has this question:
I see this is testing on cloud of products. Is there further consideration of how CC applies to cloud services? E.g. a layer 4 security/firewall service offered natively that can be imported into a tenancy/VPC.
Any thoughts?
Thanks heaps!
Hin."

Response agreed upon during June 26th call:
"Hin:
If you read the first sentence of the Preface of the Guidance document we say:
“The Common Criteria (CC) in the Cloud (CCitC) Technical Community has developed this guidance document to provide a complimentary approach that allows for IT product evaluations in cloud operational environments.”
This does not mean that schemes cannot take this guidance document and utilize parts of it as they see fit to expand the scope of a given protection profile, for example for a technology offered as a SaaS.
Testing of products “on cloud” is required for evaluating such products in that environment. This is a given but is actually a small aspect of the guidance, see page 45.
Cloud services were initially discouraged so as to make the clear differentiation between a “product” that one could buy off the shelf and a service only available via a cloud provider. However as we moved forward in the last stages of this project, NIAP started a pilot with a vendor utilizing the MDM PP for a SaaS offering.  They mapped cloud requirements to CC and that project is still going on.   It is our expectation that when the pilot finishes, some inputs to the Guidance will be provided and our next version may offer more instructions around the unique nature of evaluating a cloud native service.  It should be noted that the key point is that each PP must be updated to support this approach; in other words this document is essentially a tool for PP authors and not to be used in isolation. “The intended audience of this document are Protection Profile authors (e.g. iTCs and national TCs),but it may also be useful for cloud service providers, evaluators, evaluation authorities (schemes), labs, customers, and other stakeholders of these types of products.”
Finally regarding your example of a firewall, there is nothing precluding the NDiTC from adopting our guidance to the Firewall Module.  In fact we have mentioned in multiple venue that iTCs should be planning to integrate CCitC into their PPs, modules and supporting documents.  However at this writing the only iTC that is actively working on this is the DBMS iTC (as far as I know).
Thank you for the questions, keep them coming!
--Josh
P.S. Your feedback has triggered us to relook at our wording perhaps there are ways we can explain these concepts up front to reduce confusion."


[test] SILOptimizer/string_literals.swift: Mark as unsupported on 32-bit

We can’t currently constant-fold away the initialization of StringObject’s 7-bit discriminator field, so string literal initialization is a bit more complicated on 32-bit platforms.
rdar://problem/45845142

Note that this test requires an optimized stdlib, so it isn't run in PR tests.
@swift-ci please smoke test

This is holding up CI. Merging