fix(Textbox): stops flash on inlineContent change

Description
It was noticed that the TextBox would flash when loading. This would occur when the TextBox contained content that were of type InlineContent and any property changed. This was due to the number of lines in the flex container potentially being more than the maxLines within the InlineContent. It would then calculate the height based on this wrong number and send it back to the TextBox and flash the wrong number of lines.
References
LUI-1435
Testing

Check to make sure everything within both the InlineContent stories and TextBox stories renders as expected.
Specifically, make sure that when changing the maxLines control, it works as expected and that there is no flashing of the component.

Automation

Checklist

[ ] all commented code has been removed
[ ] any new console issues have been resolved
[ ] code linter and formatter has been run
[ ] test coverage meets repo requirements
[ ] PR name matches the expected semantic-commit syntax

Not sure why but every time I load the component it shows up cut off like the screenshot here. Not sure if that's expected.

https://github.com/rdkcentral/Lightning-UI-Components/assets/32280146/f567b34a-2ce5-40f7-82a6-34c047d5a0da
I'm somewhat able to still see the flashing when I switch between wrapped and not wrapped, but I'm not sure how realistic this scenario would be for a user/ seems like this could be outside of the scope of the original problem you fixed.

regarding the component showing up cut off- I believe there is another ticket regarding that and it is not a result of this pr


the iframe height makes the parent not scrolling

Only on Windows, the parent document is not scrolling when the cursor is on the iframe. This problem does not occur on a Mac. It effects all browsers on Windows.
Does anyone know what is causing this problem? You can try it yourself here:
http://www.burtonfrance.com/2cv-pieces-en-ligne/
Thank you in advance!

I think it is because the iframe is getting the mousewheel event. But I think the parent should handle this if the iframe has a scrolling attribute with value "no".

I expect this is a bug with Windows, rather than anything we can control with code.


Supported Region URLs has a typo and inconsistencies

The Canada Central URL has an extra "c" at the end:
Canada Central | https://canadacentral.monitoring.azure.comc

Also, some of the URLs have '/' at the end
East US | https://eastus.monitoring.azure.com/

But some don't:
Central US | https://centralus.monitoring.azure.com

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 09e9e6a7-4b37-e559-f719-63199aa78a0a
Version Independent ID: 398a63dd-0e08-9ff3-da4e-e26fb50cb287
Content: Custom metrics in Azure Monitor (Preview) - Azure Monitor
Content Source: articles/azure-monitor/platform/metrics-custom-overview.md
Service: azure-monitor
Sub-service: metrics
GitHub Login: @AncaV
Microsoft Alias: ancav

@david-jarman Thank you for bringing this to our notice, we will look into it and get back to you at the earliest.

@david-jarman Thanks again for bringing this to our notice. I have raised a PR to correct the document , once its reviewed and approved early next week changes will be merged to the main repo accordingly.
At this point it appears that there's no further edits or updates needed to the documentation, other than what is listed above. We will go ahead and close this issue, however if you have any further queries please tag us in your reply and will be happy to reopen the thread and continue the conversation. Thank you


add fmp4 live streaming feature

Please describe the summary for this PR.
add http fragment-mp4 live streaming feature, which maybe more friendly for current browers than http-flv.

Codecov Report

Merging #3084 (e3adbf3) into develop (d117145) will decrease coverage by 0.42%.
The diff coverage is 3.26%.

@@             Coverage Diff             @@
##           develop    #3084      +/-   ##
===========================================
- Coverage    56.80%   56.38%   -0.43%
===========================================
  Files          149      149
  Lines        57907    58364     +457
===========================================
+ Hits         32896    32907      +11
- Misses       25011    25457     +446

Impacted Files
Coverage Δ

trunk/src/app/srs_app_http_stream.cpp
0.00% <0.00%> (ø)

trunk/src/kernel/srs_kernel_mp4.hpp
66.66% <ø> (-33.34%)
:arrow_down:

trunk/src/kernel/srs_kernel_mp4.cpp
79.94% <3.68%> (-8.31%)
:arrow_down:

trunk/src/protocol/srs_protocol_http_conn.cpp
92.95% <12.50%> (-1.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d117145...e3adbf3. Read the comment docs.


Add Wide and Deep model into benchmark

Goals :soccer:
Add Wide & Deep Model into benchmark
Implementation Details :construction:
Arguments of wide_schema and deep_schema are used to specify features for wide model and for deep model, for now it is only suitable for binary classification, which is similar to tf.estimator.DNNLinearCombinedClassifier
Testing Details :mag:
Passed the unit test defined in test_benchmark.py

It would be great if you could also add unit tests to check for cases raising ValueError (like missing deep_block). Here is an example of unit test that checks if the ValueError was correctly raised.

It seems that I do not have to check required arguments like this:
if schema is None:         raise ValueError("The schema is required by Wide and Deep Model")
I make both schema and deep_block become required arguments, so if they are not specified, there would be original type error:

It would be great if you could also add unit tests to check for cases raising ValueError (like missing deep_block). Here is an example of unit test that checks if the ValueError was correctly raised.

It seems that I do not have to check required arguments like this:
if schema is None:
       raise ValueError("The schema is required by Wide and Deep Model")

I make both schema and deep_block become required arguments, so if they are not specified, there would be original type error:

You're right! This is not needed anymore, I was suggesting such a test when deep_block was not required.

Hey @timmy00 . It seems your PR is including others commit, which makes it hard to review it.
Would you like to try rebasing your PR locally with main and then using git push -f origin wide_deep_model_test to see if it keeps only your PR commits here?

Refactor in #623 , close this one.


Calculate a custom tip: Android Basics with Compose

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-calculate-tip?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-2-pathway-3%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-calculate-tip#4
In which task and step of the codelab can this issue be found?
5. Set an action button
Describe the problem
There's no explanation as to why KeyboardOptions.Default.copy(..) became KeyboardOptions(...). If it's because they're equivalent, then what was the point of using the former in the first place? or, perhaps this could've been mentioned, there, that they're the same ? (if they are)

Use the KeyboardOptions.Default.copy function to use the other default options like capitalization and auto correction.

So are the following two equivalent? because that's the only explanation that makes sense to me currently, as to why KeyboardOptions.Default.copy(..) became KeyboardOptions(...) in the codelab, with no explanation.
@Composable
fun EditNumberField(
   //...
) {
   TextField(
       //...
       keyboardOptions = KeyboardOptions.Default.copy(
           keyboardType = KeyboardType.Number,
           imeAction = ImeAction.Next
       )
   )
}

and
@Composable
fun EditNumberField(
   //...
) {
   TextField(
       //...
       keyboardOptions = KeyboardOptions(
           keyboardType = KeyboardType.Number,
           imeAction = ImeAction.Next
       )
   )
}

In other words, why isn't KeyboardOptions.Default.copy(...)(instead of KeyboardOptions(...)) passed as an argument there in steps 5&6, eg. here:
EditNumberField(
   label = R.string.bill_amount,
   keyboardOptions = KeyboardOptions(
       keyboardType = KeyboardType.Number,
       imeAction = ImeAction.Next
   ),
   value = amountInput,
   onValueChange = { amountInput = it }
)

From what I can tell, they are equivalent, as per my interpretation of this:

@correabuscar
Thank you, this is fixed and to be published.


Add alert banner to query UI when results exceed limit

In the Queries UI, if a query has results more than the limit (currently 1000 rows), we should show a banner that says Result set exceeds the limits of the UI. Please use another SQL client to access more rows

@emilyvandewalle when you have a chance, could you take a look to see if we still have an example this in Figma?

I was thinking about using a similar warning pattern here like the Read-only warning to save space

See designs here


Scripts for computing human rankings

We would like to have scripts computing human rankings from the scores exported from Appraise.
There are already some scripts, which need to be checked, updated and documented:

https://github.com/AppraiseDev/Appraise/blob/master/Campaign/management/commands/ComputeAnnotatorMetrics.py
https://github.com/AppraiseDev/Appraise/blob/master/Campaign/management/commands/ComputeSystemScores.py
https://github.com/AppraiseDev/Appraise/blob/master/Campaign/management/commands/ComputeZScores.py

We could then try to propose using these scripts at WMT to provide a method for reproducing WMT human rankings. At the moment we don't compute and report WMT human rankings ourselves, and it is very difficult (if not impossible) to reproduce them 1:1.

We have it here: https://github.com/AppraiseDev/Appraise/blob/main/Campaign/management/commands/ComputeWMT21Results.py


on-run-end hooks don't work

instead, dbt runs the on-run-start hooks again
cc @jthandy

fixed in 0.6.1 https://github.com/analyst-collective/dbt/blob/development/CHANGELOG.md#dbt-061


2021 review article draft

This PR introduces the draft of the 2021 Fortran-lang review article.
I think it's mostly complete. I will likely be making small edits over the next few days. But I may have missed something. If you notice something is missing and should be added, please add it. If you add new content, please commit directly to this PR. if you edit existing content, please submit a commit suggestion via GitHub.
Anybody is welcome to contribute. If you review, edit, or add anything, please also add your name to the list of authors.
If possible and if there are no objections, let's please aim to merge and publish on Wednesday, December 29.
Thank you!

#build_preview

The images don't seem to show up in the preview, but they do in my local build. I wonder if that's expected.

#build_preview

Thanks a lot, @certik, these are great. I will have a few copy edits and suggestions.

Thanks for improving the wording. Looks good so far.

Thank you all for the great additions and fixes--I'll go ahead and merge.

It looks great now, thanks @milancurcic for the improvements and thank you and everybody for writing this up!

I was away a few days. Thank you @milancurcic and all of you for this nice review of 2021!

So this wraps up 2021. Very good year for Fortran. Thank you all!
Now, what should be our goals for 2022? Let's write down realistic goals that we should try to achieve.

Now, what should be our goals for 2022? Let's write down realistic goals that we should try to achieve.

Let's discuss on Discourse (https://fortran-lang.discourse.group/t/2465), conversations on closed issues/prs are always hard to find.

Sure. I created a dedicated thread for that: https://fortran-lang.discourse.group/t/fortran-goals-for-2022/2473


Laravel 6.0 support

Would really appreciate if this gets merged soon :)

Sorry, but this is wrong in so many ways...

I will update it to Laravel 6 soon. Unfortunately I have too many Laravel packages to update, this is only one of them.

Should be fixed now.


Adding oidc image to the metadata service

Summary of Changes
This adds a second docker container that has all the oidc configuration you need and instructions on how to use it. I will add a new helmchart next that uses this new image.
Tests
This change only includes integration code and build configs.
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes.
[x] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed. ()
[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[x] PR passes make test

Codecov Report

Merging #93 into master will decrease coverage by 0.96%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   77.69%   76.73%   -0.97%
==========================================
  Files          19       20       +1
  Lines         955      967      +12
  Branches       91       91
==========================================
  Hits          742      742
- Misses        187      199      +12
  Partials       26       26

Impacted Files
Coverage Δ

metadata_service/oidc_config.py
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a50001...761ca9d. Read the comment docs.


Optionally disable contrail-analytics

This patch allows you to enable or disable contrail-analytics with default to be
enabled.

This doesn't take care to disable the service, if it has already been installed.


Add Support for hours/minutes/seconds

TODO: Add option to display a more detailed countdown with Hours, Minutes and/or seconds.

Hello can you add french translation with option :
lang: fr, ??
days=jours
thank you for your work

Hello can you add french translation with option :
lang: fr, ??
days=jours
thank you for your work

I've created this module translatable. Feel free to make a pull request with the right translation inside the translations folder saved as fr.json.


change where condition in filterByModels method

It is necessary for optimization yii-redis ar relation find.
https://github.com/yiisoft/yii2/blob/master/extensions/redis/ActiveQuery.php#L350

I think enhancing the redis code would be better in this case so that it is able to do this optimization for any kind of IN condition.

Applied a fix for redis instead. Thanks!


brew-src: 4.1.11 -> 4.1.22

This PR updates homebrew to 4.1.22.
Now, as you can see from this PR, I tried updating to latest first, which did not work, and then tried a bunch of different version to find the last one that works. That version is 4.1.22.
In https://github.com/Homebrew/brew/pull/16268, they started using portable Ruby, which breaks the build for some reason. Need some guidance on how to fix this. Here is the error:
mkdir: /opt/homebrew/Library/Homebrew/vendor/portable-ruby: Permission denied
/opt/homebrew/Library/Homebrew/brew.sh: line 189: cd: /opt/homebrew/Library/Homebrew/vendor/portable-ruby: No such file or directory
Error: Failed to cd to /opt/homebrew/Library/Homebrew/vendor/portable-ruby!
Error: Failed to install Homebrew Portable Ruby (and your system version is too old)!

Hi there! I did the 4.1.22 update a while ago but forgot to push. I added a script to automatically extract the bootstrap from upstream Homebrew so maintenance is easier. Let me push that so we can continue investigating updating to newer versions in this PR.

Hi there! I did the 4.1.22 update a while ago but forgot to push. I added a script to automatically extract the bootstrap from upstream Homebrew so maintenance is easier. Let me push that so we can continue investigating updating to newer versions in this PR.

Hey, nudging you to push that update

Hi there! I did the 4.1.22 update a while ago but forgot to push. I added a script to automatically extract the bootstrap from upstream Homebrew so maintenance is easier. Let me push that so we can continue investigating updating to newer versions in this PR.

Hey, nudging you to push that update

Realized that you pushed it to another branch and didn't open a PR. Should we close this and switch to your branch instead?

I updated to 4.2.4 by patching the Ruby vendoring code to use our Nix-managed Ruby instead. Thanks for the PR!


Add header component

I'm not sure what the guidlines are around contributions as I can't find any. I've added a header component which can be found under this pr #19 please let me know what I need to do to get it merged.

Hi, I'm kind of newbie with open-source software and this type of collaboration. I will check your code and try to merge it into main branch. Thanks a lot for your contribution.

Your changes have been merged and released in version 1.6.7. Thanks a lot!


Fixes for Command-Line options are case sensitive

These are fixes for the command line options being case insensitive #251. The
fixes should work for the argument and switches.
Example
InstAll --ManuAl

We've avoiding including NuGet in the repo purposefully. I'm not sure if we want to revert that decision.

:+1: on the code changes themselves though.

Thanks, could you please let me know what is the reason behind avoiding  including NuGet in the repo?

Yeah, we just look to avoid including binaries in the repo. It bloats the repo and isn't needed for most cases -- you will likely have nuget installed on your machine in some fashion.
While this might not be the case for mono development, I don't think we're to the point of making this change to just support that use case.

I cherry-picked the case sensitivity commit.

So could I close thi PR?

I haven't because I want to get some of the build bits to convert to appveyor.

Chris Patterson

On Dec 3, 2015, at 11:00 AM, Naveen<EMAIL_ADDRESS>wrote:
So could I close thi PR?
—
Reply to this email directly or view it on GitHub.

command line fix was picked a while back, the build is now on appveyro so closing.


Update(translate useFormState into Chinese) #1363

 #1363

Please see https://github.com/reactjs/zh-hans.react.dev/wiki to get more information. Thanks!
This PR is not appropriate, I will close it.


[Bug]: Firefox. Cannot connect to existing browser in private mode

Minimal, reproducible example
import puppeteer from 'puppeteer';
const browserURL= "http://<IP_ADDRESS>:12345";
const pageURL ="https://podrobnosti.ua/";
// firefox started before in cmd "C:\Program Files\Mozilla Firefox\firefox.exe" --remote-debugging-port=12345 --private-window

(async () => {
    await new Promise(resolve => setTimeout(resolve, 5000));
    const browser = await puppeteer.connect({
        browserURL,
        defaultViewport: null,
        ignoreHTTPSErrors:true,
    });

    const pages = await browser.pages();

    if (pages.length > 0) {
        let page = pages[0]; // Select the first tab
        await page.goto(pageURL);
}})();

Error string
Error connecting to the browser: TimeoutError: Navigation timeout of 30000 ms exceeded
Bug behavior

[ ] Flaky
[ ] PDF

Background
I Tried to connect to existing Firefox (115.3.1esr (64-bit)
Firefox has been  started in private mode via cmd with command "C:\Program Files\Mozilla Firefox\firefox.exe" --remote-debugging-port=12345 --private-window
method  await page.goto()  triggers an error:
Error connecting to the browser: TimeoutError: Navigation timeout of 30000 ms exceeded
If I try to connect to Firefox that has been stared not in private mode - no problem.
Expectation
possible to connect to existing  incognito mode Firefox and perform   await page.goto(pageURL);
Reality
await page.goto(pageURL);  - timeout connection to browser
Puppeteer configuration file (if used)
No response
Puppeteer version
21.3.8
Node version
v16.20.2
Package manager
npm
Package manager version
8.19.4
Operating system
Windows

cc @whimboo

The Firefox profile as used here is most likely not prepared for Puppeteer and misses certain automation related preferences. This could be seen in the Firefox logs by this line:

1698051681427	CDP	WARN	Invalid browser preferences for CDP. Set "fission.webContentIsolationStrategy"to 0 and "fission.bfcacheInParent" to false before Firefox starts.

With both prefs not correctly set any navigation might not work. And this is not something that we are going to change for the experimental CDP support in Firefox. As workaround you could set those prefs on your own for the given Firefox profile, but make sure that it's not something that you do for your daily profile.
Please report back if that works. From our side it's a wontfix.

@whimboo  Unfortunately  in my case I cannot launch browser with prefs  because it has been launched by other app. I cannot control it.
Thank's Henrik for your support.

FYI when Puppeteer will support puppeteer.connect with the WebDriver BiDi protocol it should then work. @OrKoN might know more already when this is going to happen.


MarkdownTOC as a Standalone Python Plugin

@naokazuterada, thank you for the great plugin!
-Would be possible to port the plugin to the standalone python / command line version?
Purpose
It would be really great to execute it from the command line and insert/update/remove [TOC] in any editor or markdown documents.
How important it is
For me personally very important, since my favourite markdown editor (Ulysses) doesn't support TOCs.
Ideal implementation
Thank you & cheers!

Hi, @artoric
I'm sorry but this plugin has strong dependencies on SublimeText API. So I can't make your wish come true.
You may try CLI tools first, as I think plugins for specific editors often depend on their APIs.

https://github.com/rasbt/markdown-toclify (python)
https://github.com/thlorenz/doctoc (node)

I close this issue, but I hope you to find a good solution 😃


Rename branch and add file with test

Continuation of #692 and https://github.com/pmiossec/git-tfs/pull/8.
cc @pmiossec

I have worked on that again today and I encounter the same problem than before when trying to write a test on branch renaming. I fail to modify the TfsHelper.VsFake to return the good (complex!) data to be able to test the source code managing the rename :(
That still need a lot of work (and perhaps another big refactoring) and I must confess that I am tired by that. And I have definitely not enough time at the moment...
Things to do:

TfsHelper.VsFake.GetRootChangesetForBranch() should return a much more full list containing all the renamed branches history
In, InitializeBranches(), find the way to pass in the then clause of the if calling InitBranchSupportingRename()  instead of the else than call the Fetch (that do not support the renaming!). I think that the solution is to prevent the collection branchesToFetch to contain the renamed branches (for the moment, they are in the list because TfsHelper.VsFake is not perfect.

But I don't know if that could be easily made (by a complex treatment of test data) with the only data we've got....

@spraints I have finally took some time to adapt TfsHelper.VSFake to return the good data to let the unit test on the branch renaming pass! \o/
I'm very happy to have now a unit test on this scenario.
Unfortunately:

this test is not run on the travis build because of the FactExceptOnUnix attribute :(
this test do not permit to find the regression introduced in the commit e17136e524057f2b2327450ce0af1ee3a54ce02c :(, so I reverted it

I am convinced that we should merge this PR as it is now because I don't know how to write a test that show the problem on that commit

this test is not run on the travis build because of the FactExceptOnUnix attribute :(

Hi. Maybe we can create http://teamcity.codebetter.com/ configuration for testing on Windows.

@KindDragon In fact, we already have it: http://teamcity.codebetter.com/project.html?projectId=project256
That's just that I forgot it because that's not the result  used to unable/disable the merge button...

@pmiossec GitHub can check both build server results (we use this in GitExt)
Check section "Seeing notifications on the Pull Request"
http://blog.jetbrains.com/teamcity/2013/02/automatically-building-pull-requests-from-github-with-teamcity/

This branch solved the problem I had with the 0.20.0 release (reported in #461), with one issue. When my project was moved to it's current location, someone created the folder in one check in, deleted it in the next, then moved it from the old location to the current location in a third.
GitTfsRemote's FetchWithMerge detects the second commit (delete the empty folder) as a rename changeset, and the if statements on line 353 and 354 cause it to stop getting any more change sets. In this case the whole thing fails.
However, if I use the debugger to change the lastChangesetIdToFetch to the ID of the 3rd check in (creating the folder after the delete), everything works correctly, and the problems I experienced with the current master branch is resolved.

@pmiossec GitHub can check both build server results (we use this in GitExt)
Check section "Seeing notifications on the Pull Request"
http://blog.jetbrains.com/teamcity/2013/02/automatically-building-pull-requests-from-github-with-teamcity/

Sweet, I've wanted to hook that up, and hadn't figured out how to. The blog post got me to look in the right place. Thanks!

CI is green. I'd still love to have a test for the regression, but in the meantime :+1:.

This branch solves the problem I had in 0.21.0 release.
I tried to clone a repository. It happened that several files were missing. I tried to clone the repository again, but the same files were missing according to git tfs verify. I've googled https://github.com/git-tfs/git-tfs/issues/660 and tracked the code up to this pull requst. I've built git-tfs and tried to clone the repository. I got the files that were missing.
I don't have many actual details though. These files were introduced in the very first changeset. Tfs history contained files marked as renames and deletes (it was a move from another team project according to changeset message). I don't have access to the source project so I don't know whether the missing files were added in the changeset.
Anyway, it works for me. I'm able to use git-tfs again! Thank you!

Finally, could we merge it? I think we should move on....

Yes, merge :sailboat:

OK, thanks!


PowerShell 7.3.5 New-CMApplicationDeployment

Type: Bug
When executing the SCCM cmdlet New-CMApplicationDeployment using the script below I receive the following error:
New-CMApplicationDeployment:  Invalid Operation
CMPSNoMask = True
The command I am trying to execute is:
New-CMApplicationDeployment -Name $selectedapplication.LocalizedDisplayName -CollectionName $collection.Name -AvailableDateTime $date -DeadlineDateTime $date -DeployPurpose $Purpose -DeployAction Install -TimeBaseOn LocalTime -UserNotification DisplaySoftwareCenterOnly
This is occurring in Visual Studio Code with the PowerShell 7.3.5 extension.  It occurs using 7.3.6 as well.
Interestingly the issue does not occur if I run the code in PowerShell ISE (using PowerShell 5) on the same computer.
The actual parameter causing the issue is -TimeBaseOn LocalTime.  If I remove that parameter the script executes.  However, I require that parameter for our code to work properly.
VS Code version: Code 1.80.1 (74f6148eb9ea00507ec113ec51c489d6ffb4b771, 2023-07-12T17:22:07.651Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item
Value

CPUs
12th Gen Intel(R) Core(TM) i7-1260P (16 x 2496)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.71GB (20.11GB free)

Process Argv
--crash-reporter-id bcbde2cb-bba8-4fcb-99b5-ca674c42cfa3

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

powershell
ms-
2023.6.0

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263cf:30792227
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vscccc:30610679
282f8724:30602487
89544117:30613380
showlangstatbar:30737416
vsctsb:30748421
03d35959:30757346
pythonfmttext:30731395
pythoncmvfstrcf:30756944
fixshowwlkth:30771522
showindicator:30785052
pythongtdpath:30769146
i26e3531:30792625
pythonnosm12tcf:30779713
pythonidxpt:30784022
pythonnoceb:30776495
e537b577:30786199
dsvsc013:30795093

We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the VS Code Marketplace. Just in case, in a few simple steps you can get started writing your own extension. See also our issue reporting guidelines.
Happy Coding!


Top with group on Postgres

What happened?
We have a query builder in my company https://github.com/ToucanToco/weaverbird/, which is a click button interface that generates some config in our DSL that is then translated into Mongo, Pandas, many SQL dialects
We are rewriting our whole data pipeline in Rust and I wanted to use PRQL instead of generating many CTEs
I generated the code for the top step. The generated PRQL query works fine in the playground (without a dialect!) but our integration tests fail. And I force the dialect to Postgres in the playground, the query is indeed totally different
(In the MRE I want to keep the top 2 beers of each kind)
PRQL input
prql target:sql.postgres

from_text """
price_per_l,alcohol_degree,name,cost,beer_kind,volume_ml,brewing_date,nullable_name
0.1599999964237213,13.5,Superstrong beer,2.890000104904175,Triple,330,2022-01-01,
0.05400000140070915,4.877377033233643,Ninkasi Ploploplop,2.890000104904175,India Pale Ale,330,2022-01-02,Ninkasi Ploploplop
0.004999999888241291,0.5699344873428345,Brewdog Nanny State Alcoholvrij,2.2899999618530273,Sans alcool,330,2022-01-03,Brewdog Nanny State Alcoholvrij
0.0560000017285347,6.994105339050293,Ardwen Blonde,2.0899999141693115,Best-sellers,330,2022-01-04,Ardwen Blonde
0.07000000029802322,8.930644989013672,Cuvée des Trolls,1.5499999523162842,Blonde,250,2022-01-05,
0.004999999888241291,1.2437106370925903,Weihenstephan Hefe Weizen Alcoholarm,1.590000033378601,Blanche & Weizen,500,2022-01-06,Weihenstephan Hefe Weizen Alcoholarm
0.04500000178813934,4.717409610748291,Bellfield Lawless Village IPA,2.490000009536743,India Pale Ale,330,2022-01-07,Bellfield Lawless Village IPA
0.08399999886751175,12.974271774291992,Pauwel Kwak,1.690000057220459,Belge blonde forte & Golden Ale,330,2022-01-08,Pauwel Kwak
0.06499999761581421,7.74746561050415,Brasserie De Sutter Brin de Folie,2.190000057220459,Blonde,330,2022-01-09,
0.05999999865889549,8.749608993530273,Brugse Zot blonde,1.7899999618530273,Blonde,330,2022-01-10,Brugse Zot blonde
"""
select {`beer_kind`,`price_per_l`}
group {`beer_kind`} (
  sort {+`price_per_l`}
  take 2
)

SQL output
SELECT
  DISTINCT ON (beer_kind) beer_kind,
  price_per_l
FROM
  table_0
ORDER BY
  beer_kind,
  price_per_l

Expected SQL output
table_1 AS (
  SELECT
    beer_kind,
    price_per_l,
    ROW_NUMBER() OVER (
      PARTITION BY beer_kind
      ORDER BY
        price_per_l
    ) AS _expr_0
  FROM
    table_0
)
SELECT
  beer_kind,
  price_per_l
FROM
  table_1
WHERE
  _expr_0 <= 2

MVCE confirmation

[X] Minimal example
[X] New issue

Anything else?
Loving PRQL. Thanks for your help and sorry if I didn't create the right query for our usecase 🙏

Thanks @PrettyWood !
Am I correct in thinking that we do want DISTINCT ON in postgres, but there's a bug in ignoring the take 2 transform?

I guess so

No, we don't want DISTINCT ON since that will pick only the first item in each GROUP BY partition.
The correct behavior would be to pick first two items in each partition. In SQL, this is only achievable by using ROW_NUMBER() and WHERE.
This is the problem here: https://github.com/prql/PRQL/blob/main/prqlc/prql-compiler/src/sql/srq/preprocess.rs#L172-L177

we are checking if we should take_only_first,
we correctly apply this condition to DISTINCT,
we don't apply this condition to DISTINCT ON  <-- this is the bug

Oh, I didn't notice, you've opened a PR already.

Oh, I didn't notice, you've opened a PR already.

Yeah and also realized my suggestion was wrong 😄


Support being initiated from a UIBarButtonItem on iPad

Currently it will show both the UIActionSheet and UIPopoverController at the top left of the screen on iPad. This is because UIBarButtonItem inherits from NSObject instead of UIView because of legacy...
Found this code snippet somewhere for UIPopoverController:
if ([sender isKindOfClass:[UIBarButtonItem class]]) {
  [popoverController presentPopoverFromBarButtonItem:sender permittedArrowDirections:UIPopoverArrowDirectionAny animated:YES];
} else {
  [popoverController presentPopoverFromRect:((UIView *)sender).bounds inView:sender permittedArrowDirections:UIPopoverArrowDirectionAny animated:YES];
}

For UIActionSheet you need to use showFromBarButtonItem:
[self.actionSheet showFromBarButtonItem:self.barButtonItem animated:YES];

Can you also change to use the sender by default instead of us having to manually set it?

I would do a pull request, but I'm a total beginner with Objective-C.

Does this solution work for everyone else?

I tried it out from a UIBarButtonItem (that is located on the bottom of the screen) on iPad and it works correctly for the first UIActionSheet with the "Choose from Library" button, but when I tap that button it opens the next UIActionSheet with the actual image picker at the top of the screen, instead of bottom where the original UIActionSheet and UIBarButtonItem is.


[qtbase] Fix configuration race

Fixes build error
CMake Error at D:/installed/arm64-windows/share/Qt6/3rdparty/extra-cmake-modules/find-modules/FindEGL.cmake:135 (file):
  file COPY cannot set permissions on
  "D:/buildtrees/qtmultimedia/arm64-windows-dbg/../CMakeError.log":
  Permission denied.

https://dev.azure.com/vcpkg/public/_build/results?buildId=81873&view=logs&j=84da4f4a-968a-5b5c-16e9-f444c845396d

@Neumann-A I assume this was a temporary debugging aid (and a potential use case for a global script mode variable in #26754).

Yeah it was. Needed for debugging why libEGL didn't link on windows/linux


Updated list of types removed in NET3.1

We didn't document a removed class - https://learn.microsoft.com/dotnet/api/system.windows.forms.datagridcolumnstyle.compmodswitches?view=netframework-4.8.1&viewFallbackFrom=net-5.0
Adding it to the list.

@gewarren  - Thank you!


Weirdly-formatted HTML in the middle of the note

See the second paragraph:

I've seen this, it's the fault of clients who put html into notes. What do you think is the right approach?

35a9274


Request to alter registration flow

Hello,
We have a customer that made the following remark:

It is counterintuitive when registering an itsyou.online account one has to manually log in to his/her profile and verify his/her e-mail address.
It would be much more efficiënt that an activation e-mail is sent to the e-mail listed when the user has registered.

That way a customer that has not clicked the link in the e-mail, but has forgotten his/her password can still verify his or her account by retrieving the initial e-mail activation link.
Is it possible to forsee an implementation for this?
Kind regards

Qualifying this as a bug since it's bad user experience.

Hi,
Is it possible to provide a status update regarding this issue?
Kind regards


virtual box ip address

unable to connect sql server on  vm virtual box with sql express.
it list ie8winxp\sqlexpress ssms
the ip is internal in vm box and not known outside on the host machine
get error : Error message: A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections. (provider: SQL Network Interfaces, error: 25 - Connection string is not valid)

@rmpbklyn I think you may be able to resolve this if you configure the firewall to your SQL Server instance so that it allows your IP.

Closing for now, but please let me know if you run into more issues.


make tests & require them for new command additions

Would help fight buggy regex issues

Briggs wrote the below:

[ ] Setup jest as a dev dependency
[ ] Add unit tests for all commands
[ ] Add unit tests for all helper functions that are public
[ ] Add issues for any problems identified by the tests
[ ] Add a pre-push git-hook to prevent pushing (there may be a lib to help with this)

The goals of these tests are to help prevent REGEX issues, as well as making sure the bot is solid. If you'd like to help with this, I'm organizing a team to do this. Please comment here if you'd like to be on the team!

I'd love to help!

Happy to join the team.

@I3uckwheat next time just make a child comment, don't edit the OP

@twalton83 Would you like to lead this?

@I3uckwheat I don't mind! Only thing I don't know how to do is the git hook but I can look into it or see if someone else is familiar.

I'd like help implement the pre-push hook, I don't have any experience with git hooks but I hope it's not too complicated and the deadline isn't tomorrow or something lol

Add a pre-push git-hook to prevent pushing (there may be a lib to help with this)

Another thing, I'm not entirely sure what's the purpose of such a hook

@dvik1950 The purpose of the git hook is to prevent pushing if there are any failing tests. The hook will run the tests before pushing and can stop a push before it happens when writing git push origin <branch>
@twalton83 Great! It looks like you have enough people interested to get started! So start when you're ready! I'm around if you need to ask anything :)

@dvik1950 We made a private Discord channel for the issue, what’s your username?

Dependency added here: https://github.com/TheOdinProject/odin-bot-v2/pull/63

The commands themselves have been refactored, and there are now test files for every command, with an example in callbacks.test.js.


Improve warnings in editable install

This was initially motivated by #3557.
Summary of changes

Added warning about CWD interfering with editable installs
Listed CWD entries overshadowing installation, as a limitation in the editable installation docs.
Fixed existing RST syntax on changelog.
Fixed warning about install command during editable install.

Pull Request Checklist

[ ] Changes have tests
[ ] News fragment added in changelog.d/.
(See documentation for details)

Ignore above commits - they were meant for 3659.