feat: report download progress

This PR aims to address #24 and #51
there is no way to track download sequentially as s5cmd run or cp command will be locked on a thread. so, download progress is outsourced to a thread and will run simultaneously along side download thread on both series and manifest downloader
as the index only contains aws urls, when a manifest contains gcs urls, crdc series instance uuid is extracted from aws urls and queried against the aws urls in the index to get download size. For manifest download, download size is calculated first and the progress is tracked against as a whole.
manifest validator in download from manifest is offloaded to a dedicated function that will check not only the first line but every line, and if the manifest has urls from both gcp and aws to raise an exception.
s5cmd cp is replaced with sync to gracefully avoid downloading the same data again.
get functions will now return a message that data not found for the values given for a key.
queries folder is now removed as they will persist in idc-index-data

@jcfr whenever possible, could you help troubleshoot with the pylint error in CI? I am unable to figure what's causing the issue. Thanks!
https://github.com/ImagingDataCommons/idc-index/actions/runs/8411497038/job/23031159059?pr=56

Maybe this article can help troubleshoot pylint error 12: https://stackoverflow.com/questions/76181900/pylint-return-non-zero-code-error-only-if-errors-are-there

@jcfr sorry for the silly question - but if we are running ruff already, why do we also need to run pylint?

ruff and pylint are complementary

When first updating the CI, I added a lot "exception" related to potential issues:
https://github.com/ImagingDataCommons/idc-index/blob/1868f8a2b2ec4009c9928bca5c387ae4a57bc12f/pyproject.toml#L150-L174
https://github.com/ImagingDataCommons/idc-index/blob/1868f8a2b2ec4009c9928bca5c387ae4a57bc12f/pyproject.toml#L196-L206
To move forward, it would be sensible to:

gradually review and address these exceptions if it applies
address warnings associated with new code & feature

Note that in some cases, it is legitimate to have exception and not follow the recommendation associated with the warning. This should be address on a case-by-case basis

@fedorov I added the initial disk size as a baseline, and the download progress is now going as expected. Calculating file size may be an overhead if too many files are in a directory. I do not know if there is any better way.
I tried replacing threading with multiprocessing which seems to use Popen, it worked only on Ubuntu, but it did not work well on Windows and macOS systems, so I reverted to threading.
I can also confirm that s5cmd does not delete any existing files, so replacing cp with sync has been seamless.
Here's a run that did not work on Windows and Mac.
https://github.com/ImagingDataCommons/idc-index/actions/runs/8426861486

@vkt1414 this is the use of Popen I was referring to at the meeting. What is wrong with this simple approach?

@vkt1414 this is the use of Popen I was referring to at the meeting. What is wrong with this simple approach?

Thank you! Ubuntu(Linux) has no problem with any approach so far.
Either way, I'll give this a try.

The idea is to use the simplest approach possible to improve readability and reduce maintenance.

The idea is to use the simplest approach possible to improve readability and reduce maintenance.

Sure. I used Popen only this time, and this PR should now be ready for review.

@vkt1414 this PR is still marked as draft - is this right?

@vkt1414 this PR is still marked as draft - is this right?

I have now marked it as ready for review now.

@vkt1414 this PR is still marked as draft - is this right?

I have now marked it as ready for review now.

Changing back to draft as I think I can optimize the manifest validator and sync size calculations in seconds regardless of the manifest size. I'd be analyzing all series in the manifest, instead of one series at a time as it is currently implemented now. I'd be leveraging reading the manifest as a dataframe, followed by data wrangling operations to accomplish this.

here's my attempt at creating the flowchart: (it's an svg file, so we can zoom)

@vkt1414 I am going over the review. Your summary of what the function does is very helpful for the review! But I really do not think it should be in the docstrings - those should contain details needed to understand what the function does. Not how it does it. I would recommend moving details of how the function is implemented into the comments within the body function and outside of the docstring.
Please wait with responding to this and with any other edits until I am done with my review!

I submitted few small edits to your branch (I think I will want to review the docstrings separately after you move out the dev content to comments): https://github.com/vkt1414/idc-index/pull/9.
Also, can you add some logging statements to help debug this, like I added that one statement in the PR above?

@vkt1414 please let me know when this is ready for review!

As discussed today, there are some further optimization to be implemented in the validate function. Also, please see this PR for few comments/style changes: vkt1414#10. I have to say I did not finish the review - I only did the validate function...

Sounds good. I made the validator as efficient as I possibly could. Made tests more robust now by testing all combinations of optional parameters. Made pytest more verbose in CI to aid in troubleshooting.


Updating the overall UI to modern, good-looking UI

Updation of UI means..

Changing the look and feel of buttons
Changing the background
Expressing the messages with cute vector images.
more if any.

Can take references from templates like

instaflutter
dribble


Add support for thread local configuration when run  cross browser tests in parallel

Duplicate of https://github.com/selenide/selenide/issues/1372

Duplicate of https://github.com/selenide/selenide/issues/1372


trial report status = 'complete' is confusing

We should modify the way we describe reports while a trial is on going. "Complete" suggests that the trial is over.

The report is what's complete. Could be improved, but I don't think its worth the time now.


Add stress tests and find the recommended strategy for memory stability

e.g. executing runtime.GC in OnTick

hey @musaprg can you give the timeline here, and what's your progress? It is ok to give up but being silent is the worst I think.

@mathetake I'm sorry for the late. I was trying several libraries and chose fortio/fortio to use for our e2e load testing because it was handier than others and can be used as a go library. I am writing the test scenario based on the previous (already solved) issue https://github.com/envoyproxy/envoy/issues/14856. The small case (the payload size = 128KB, QPS = 10000) works fine, but the test with target case (the payload size = 32MB, QPS = 10000) isn't over. I'm investigating why this occurs.


Add optional port parameter for the development servers

As written in #1766 I would find it useful to have the ability to specify a port in UseReactDevelopmentServer and UseAngularCliServer. With that JavaScriptServices would automatically detect if there is already an active development server running and start a new one otherwise.

This is something I'm interested in for building a usable React SSR! And it doesn't appear to be a breaking change (so far as I can tell).
One thing, I would rather pass a configuration action like most middleware initializers. Then switch the current parameter-based versions to build the options and call the method with the configuration object.
public class ReactDevelopmentMiddlewareOptions {
  public int Port;
  public string NpmScript
}

// options is ReactDevelopmentMiddlewareOptions
app.UseReactDevelopmentServer(options => {
  options.Port = 7878;
});

Hi, this pull request is being closed because this repo is archived and all the source code and issues have been moved to the https://github.com/aspnet/AspNetCore repository. If you would like to send a new PR, you can find the new location for the source code here: https://github.com/aspnet/AspNetCore/tree/master/src/Middleware/NodeServices
Thanks,
Eilon


Move to FactoryBot 5.0

There are significant changes that break our present setup, these can likely be handled with a config file.
https://github.com/thoughtbot/factory_bot/blob/master/NEWS.md

@mjy looks it was simpler to fix. Or did you want to re-arrange all the code to some new style?
In case it is all good please wait for Travis to process it before merging.

Too late ;). Crossing fingers.

Its OK, most likely nothing will burn. I tested locally before pushing. This is the expected set of errors:
Finished in 25 minutes 59 seconds (files took 16.03 seconds to load)
6383 examples, 5 failures

Failed examples:

rspec ./spec/features/authentication_spec.rb:25 # Authentication /signin when credentials do not match existing user should not sign user in
rspec ./spec/features/taxon_determinations_spec.rb:51 # TaxonDeterminations signed in as a user, with some records created testing new taxon determination can create a new taxon determination
rspec ./spec/features/type_materials_spec.rb:67 # TypeMaterials when signed in and a project is selected creating a new type_materials testing the new type_materials form filling out the form
rspec ./spec/features/users_spec.rb:276 # Users when user is not signed in forgotten password reset valid email request password reset
rspec ./spec/features/users_spec.rb:307 # Users when user is not signed in flagged for password reset requesting password reset from sign in process

Those are all known and based on UI changes.  I should have them fixed today.


OCM-6347 | ci: Fix HCP testing

What this PR does / why we need it:
Disable one test for HCP as it is not relevant
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx):
https://issues.redhat.com/browse/OCM-6387
Change type

[ ] New feature
[ ] Bug fix
[ ] Build
[x] CI
[ ] Documentation
[ ] Performance
[ ] Refactor
[ ] Style
[ ] Unit tests
[ ] Subsystem tests

Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.

/lgtm


Patient validation for the Patient.communication.language error.  "Invalid Patient: Patient.communication[0].language: Unable to resolve value set "http://hl7.org/fhir/ValueSet/languages|4.5.0""

https://inferno.healthit.gov/community/hHf2FoFZON9/  This was passing in December, but seems to be failing now.

This issue should be addressed by https://github.com/inferno-community/fhir-validator-app/issues/44. Please re run your tests

This issue should be addressed by https://github.com/inferno-community/fhir-validator-app/issues/44. Please re run your tests

Thank you!  This is passing now.

Thank you!  This is passing now.


Fix issue #1171: np.int deprecated and replace by np.int64

References to other Issues or PRs
Fixes issue #1171
Brief description of what has been fixed
This PR replaces all instances of the deprecated np.int with np.int64. The recent updates in NumPy have led to np.int being deprecated, and this change ensures compatibility with the latest versions and avoids deprecation warnings.
Release Notes
Replaced deprecated np.int with np.int64 on space/transformers.py to eliminate deprecation warnings and maintain forward compatibility with NumPy.
(#1171 by @boemer00)

Dear Maintainer,
I've noticed that the continuous integration builds for the project are failing with the following error:
E: The repository 'http://security.debian.org/debian-security stretch/updates Release' does no longer have a Release file.
E: The repository 'http://deb.debian.org/debian stretch Release' does no longer have a Release file.
E: The repository 'http://deb.debian.org/debian stretch-updates Release' does no longer have a Release file.

This error seems to be occurring because Debian Stretch has reached its end-of-life, and the default repositories are no longer available. As a result, apt-get update is failing in the CI environment, which uses Debian Stretch.
Would the solution be upgrade the CI environment to a newer version of Debian? Not sure how costly and time-consuming it is, but I am happy to continue with some fixes once this is sorted.
In case, there is something I could do on my end to make sure my suggestion are checked successfully, please let me know.
best wishes,
@boemer00


Using StyleCop for ReSharper to provide Company and Copyright Information

How can we configure the company name and copyright text ?
// ---------------------------------------------------- // <copyright file="HomeControllerRoute.cs" company=""> //    // </copyright> // <summary> //   Defines the HomeControllerRoute type. // </summary> // ---------------------------------------------------------

I don't think it is possible using just the StyleCop plugin for Resharper. It is possible using the standalone StyleCop (not the jetbrains plugin). It would be great though to have this feature :)

Closing in favour of #44


Enhance styling when "Dropdown" is used within "Header".

name: Feature request
about: Suggest an idea for this project
title: ''
labels: ''
assignees: ''
Feature Type
[ ] Clarity Port
[X] Enhancement
Description
Enhance styling when "Dropdown" is used within "Header". Provided the following example, there is great opportunity to utilize the drop down control within the header with some very minor styling tweaks. Or, perhaps there is another more applicable approach. Thanks in advance for any feedback!

P.S. - apologies if I missed anything in the submission.

I can't figure out code snippets... I've attached a .txt of the header code sample. Apologies on the poor formatting on initial submission.
header_code_sample.txt

Just wanted to share the result - I was able to achieve styling evolving my CSS a bit. While the styling might be a bit specific to my implementation / not as re-usable as it should, maybe it'll be helpful somewhere - very minimal testing performed but it's allowed me to move forward with my concepts.

        <Dropdown Position=Position.BottomLeft>
            <DropdownTrigger>

<NavItem Icon="user"></NavItem>

            </DropdownTrigger>
            <DropdownMenu>
                <DropdownHeader>Account</DropdownHeader>
                <DropdownItem><Icon Shape="login" Size="24" style="margin-bottom:0.15rem;margin-right:0.3rem;color:var(--clr-dropdown-item-color, #666666);" />Log in</DropdownItem>
                <DropdownItem><Icon Shape="pod" Size="24" style="margin-bottom:0.15rem;margin-right:0.3rem;color:var(--clr-dropdown-item-color, #666666);" />Register</DropdownItem>
            </DropdownMenu>
        </Dropdown>
        <Dropdown Position=Position.BottomLeft>
            <DropdownTrigger>

<NavItem Icon="cog"></NavItem>

            </DropdownTrigger>
            <DropdownMenu>
                <DropdownHeader>Settings</DropdownHeader>
                <DropdownItem><Icon Shape="info-circle" Size="24" style="margin-bottom:0.15rem;margin-right:0.3rem;color:var(--clr-dropdown-item-color, #666666);" />User settings</DropdownItem>
                <DropdownItem><Icon Shape="terminal" Size="24" style="margin-bottom:0.15rem;margin-right:0.3rem;color:var(--clr-dropdown-item-color, #666666);" />Debug console</DropdownItem>
            </DropdownMenu>
        </Dropdown>

Tracked as issue with Clarity UI itself: https://github.com/vmware-clarity/ng-clarity/issues/114

Fixed, releasing as part of v0.12.0


can't save query statement of Azure Monitor log

The documentation I am referencing: Get started with Azure Monitor Log Analytics#save-queries
I am query the log of api management in Azure portal, however the Save button is disabled, what's up with this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 773e07ff-6bd8-47b2-5b83-75c7246693e6
Version Independent ID: 8723d5a6-ac93-0dba-b2b8-83905d807d67
Content: Get started with Azure Monitor Log Analytics
Content Source: articles/azure-monitor/log-query/get-started-portal.md
Service: log-analytics
GitHub Login: @bwren
Microsoft Alias: bwren

@ToMakeSense Thanks for the Comment. We are actively investigating and will get back to you soon.

@ToMakeSense this may help answer your question.

We will now close this issue. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

@femsulu thanks for clarification! However, it's better design by giving the message like "Save is not supported in this context, find this function in the Log Analytics workspace" than "Save is not supported in this environment" + figure this out in the FAQ.

Where is "All services > Monitor > Logs" ?

Where is "All services > Monitor > Logs" ?

Accessing from All Services > Monitors > Logs and still no "Save As" enabled?

Accessing from All Services > Monitors > Logs and still no "Save As" enabled?

@JoseFMP  @phil-dando  I think the portal should change a lot(also the docs), you can find it in the portal in this way:

Accessing from All Services > Monitors > Logs and still no "Save As" enabled?

@JoseFMP @phil-dando I think the portal should change a lot(also the docs), you can find it in the portal in this way:

@ToMakeSense - Thanks Kevin that worked perfectly!

I just want to note that disabling the save button with absolutely no reason displayed to the user is bad design.  If someone comes into this from an Automation account, then builds a query, only to realize they can't save it, and there's no indicator why they can't....bad stuff.
And the icing on that is they can't change the scope of the query to a Log Analytics workspace from there, either, because the scope selector only allows you to change to a scope of the same type you came into that view on.

I just ran into this issue and couldn't for the life of me understand why I could not save a query from the resource > logs view.


Added warning if databag and databag_item name consist of period

Signed-off-by: sanga17<EMAIL_ADDRESS>
Description
Databag item ID can not contain period " . " when created through knife databag commands or via chef manage UI.
As period is being used in existing databags, Adding warning instead of raising an exception OR restricting.
Related Issue
https://github.com/chef/chef/issues/3697
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

There are leading spaces in the log messages, and the log messages could use some rephrasing
Databags name with period is now deprecated, consider using name without '.' -> Data bag names containing periods are deprecated, consider using a name without '.'
Data bag item ID with period is now deprecated, consider using ID without '.' -> Data bag id's containing periods are deprecated, consider using an id without '.'

it also doesn't need to state that its deprecated in the message if its a deprecation message.
looking at the code though now it looks like its primarily going through knife which probably doesn't support deprecations?  the knife application class should probably be changed so that Chef.deprecated gets wired up properly so that it doesn't need to go through ChefConfig.logger and then the knife application class also needs to call the same API that Chef::Client does so that it outputs deprecations properly.

Closing this since we never confirmed the need. Many users have been doing this without issue for fqdn data bags.


feature: Customisable commiter variable

Hello!
I want to have an option to provide extra env vars for this action:

committer_name
committer_email

I can be a volunteer, if maintainers agree on this feat :)

@omBratteng can I implement this feature :)?

Go ahead 😄

Hi @omBratteng I've created a PR -> https://github.com/dailydotdev/action-devcard/pull/377, you can review and release if it is okey :D

Closed via #377


Merge master branch to prTesting1_201903121025 branch

OPS Build status updates of commit f19c0a9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: 🎸 Add validations to consumeAddMultiSigSignerAuth

:tada: This PR is included in version 14.0.0-alpha.4 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 14.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 14.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


goerli.net homepage link to multi-sig is dead tweet from @5chdn

Who has the Goerli multi-sig?

@q9f please fix


OS interface changes for Solo5 break mirage-os-shim

Building mirage-skeleton static_website_tls against the latest Solo5 development package universe (OPAM remote at https://github.com/Solo5/opam-solo5) results in the following error:
+ ocamlfind ocamlopt -g -dontlink unix -dontlink str -dontlink num -dontlink threads -linkpkg -output-obj -package uri -package tcpip.udp -package tcpip.tcp -package tcpip.stack-direct -package tcpip.ipv4 -package tcpip.icmpv4 -package tcpip.ethif -package tcpip.arpv4 -package tcpip -package nocrypto.mirage -package nocrypto -package mirage-types-lwt -package mirage-types -package mirage-solo5 -package mirage-runtime -package mirage-random -package mirage-net-solo5 -package mirage-logs -package mirage-conduit -package mirage-clock-freestanding -package mirage-bootvar-solo5 -package magic-mime -package lwt -package io-page -package functoria-runtime -package cohttp-mirage -predicates mirage_solo5 key_gen.cmx dispatch.cmx static1.cmx static2.cmx main.cmx -o main.native.o
File "_none_", line 1:
Error: Files /home/mato/.opam/ukvm-4.06.0/lib/mirage-entropy/mirage-entropy.cmxa
       and /home/mato/.opam/ukvm-4.06.0/lib/mirage-os-shim/solo5/mirage-os-shim.cmxa
       make inconsistent assumptions over interface Mirage_OS
Command exited with code 2.

I believe this is due to my adding an OS.Solo5 module in https://github.com/mirage/mirage-solo5/pull/27/commits/61925cfdb20629a4a866123a74d003f73c5921d7, however mirage-os-shim has "here be dragons" written all over it and I don't know what the fix is.
/cc @hannesm Solo5/solo5#245 mirage/mirage-solo5#27

this is due to 4.06.0 doing -keep-locs by default. fixed in #4, for testing an opam pin add mirage-os-shim https://github.com/hannesm/mirage-os-shim.git#4.06 should solve your issue.
@pqwy i'd be happy to move this repository to the mirageos organisation and maintain it in the future!?

@hannesm That fixes it, thanks. I'll add a pin for this version to Solo5/opam-solo5 for now.

fixed by 3.0.1 release


List of limitations in expression lambdas when generating expression trees

Certain things cannot be used in expression lambdas when used to generate expression trees, such as the null propagation operator, and dynamic. A list of such items would be useful here, after the section Creating Expression Trees from Lambda Expressions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c5f0dba-6178-976a-920d-b516afd5ec87
Version Independent ID: 99636ce3-bdc3-52b9-7a26-36f11b70e42b
Content: Expression Trees (C#)
Content Source: docs/csharp/programming-guide/concepts/expression-trees/index.md
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

An excellent starting point would be Bart DeSmet's description of his CSharpExpressions library in which he adds a set of factory methods for creating expressions that were added in later versions of the language.

Thank you for pointing this out @zspitz
I've added it to our backlog, and we'll address this when we next update this content.

@dotnet/docs
I feel that a comprehensive list of C# syntax that cannot be used within a lambda expression has great value.

null propagation
ref and out variables
dynamic

among others. Admittedly, the error message is rather straightforward; usually something to the effect that "you can't use feature x in a lambda expression", but I don't think that's a reason not to provide such a list.

@dotnet/docs
I feel that a comprehensive list of C# syntax that cannot be used within a lambda expression has great value.

null propagation
ref and out variables
dynamic

among others. Admittedly, the error message is rather straightforward; usually something to the effect that "you can't use feature x in a lambda expression", but I don't think that's a reason not to provide such a list.


Build Project issue

When I'm building the project this error appears to me {
CreateProcess error=2, The system cannot find the file specified
}
please advise me what to do

need to see more logs...


Feature Request - Web UI setting to change number of days for accesskey rotation

The Settings in the UI should offer an option to change the number of days from (good default) of 90 to any positive integer value.
"Active accesskey has not been rotated" is the audit item affected.

Agreed.  I'd also like to assign a unique ID to each auditor check, so when we change the text of the checks, the justifications aren't lost.


What's c2e and c2p? What to use?

https://github.com/ciromattia/kcc/releases/tag/v5.6.2

kcc is GUI (graphical user interface) version
kcc-c2e CLI (command line) version
kcc-c2p CLI (command line) version
https://github.com/ciromattia/kcc#usage

CLI version of KCC is intended for power users.


Table rendering support - registering/using custom cell renderers

GridModel will need to have a way of specifying a new type of renderer on a per cell basis. Currently we just support rendering text, so that should be the default cell renderer, and then allow for registering/specifying different renderers. We can have a TextCellRenderer as the default, and BarGaugeRenderer packaged in @deephaven/grid, but not a default.

[ ] Add a rendererForCell(column: ModelIndex, row: ModelIndex): CellRendererType and type CellRendererType = string
[ ] Refactor text cell rendering to a separate class TextCellRenderer and use that from GridRenderer when rendering a cell by default (or if renderer not specified)
[ ] Allow registering a different types of renderers that GridRenderer.drawCellContents will automatically call if there's a renderer specified for that cell
[ ] Create BarGaugeRenderer, and an extension to GridModel for the details required for BarGaugeRenderer

We should be able to test this out in the style guide using a mock (similar to MockGridModel).

Registering my expectation that gradient rendering use OKLab color space for interpolation.


Changed the example name for additional postgres server in CONFIG-VAR…

…S.md file due to the error while checking the server name using regex. additional_server -> additional-server
Error message :

@sandeepksaini PR #285 updates the PostgreSQL example in CONFIG-VARS.md. PR #285 is planned for upcoming release. Please take a look and close this PR as the example will be updated soon.

Additional Postgres server example was updated in PR #285. Closing this PR.


Adds TypeMatch for PresenceAbsence, Frequency for inputs and outputs in plugin_setup.py

Minor adjustment to already completed PR. Closes issue #161 and closes issue #144

Looks good. I look forward to your next PR on this issue induced by my negligence.


[WIP] Integrity check for minimal indexing stores

adresses https://github.com/mirage/irmin/issues/2133
Things left to work on/decide:

integrity check on inodes reads is currently broken (see https://github.com/mirage/irmin/issues/1773);
I would like an uniform naming scheme for the two integrity checks functions:

integrity_check works on all stores, but only for objects in index;
integrity_check_minimal (very bad naming, please suggests a better one:) ) only works on stores that support gc, but traverses all objects in a commit.

tests

Codecov Report

Merging #2138 (c0995dc) into main (7164bc9) will decrease coverage by 0.02%.
The diff coverage is 60.43%.

@@            Coverage Diff             @@
##             main    #2138      +/-   ##
==========================================
- Coverage   68.22%   68.20%   -0.03%
==========================================
  Files         134      134
  Lines       16093    16193     +100
==========================================
+ Hits        10980    11044      +64
- Misses       5113     5149      +36

Impacted Files
Coverage Δ

src/irmin-pack/inode.ml
78.38% <51.61%> (-0.33%)
:arrow_down:

src/irmin-pack/unix/checks.ml
23.00% <56.66%> (+12.92%)
:arrow_up:

src/irmin-pack/unix/store.ml
63.00% <94.44%> (-1.03%)
:arrow_down:

src/irmin-fs/unix/irmin_fs_unix.ml
67.74% <0.00%> (-0.65%)
:arrow_down:

src/irmin-test/store.ml
94.89% <0.00%> (-0.06%)
:arrow_down:

src/irmin/store.ml
65.95% <0.00%> (+0.14%)
:arrow_up:

src/irmin-pack/unix/pack_store.ml
84.57% <0.00%> (+1.59%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

This is ready for review.
I run the integrity-check command on a recent snapshot
time dune exec -- ./test/irmin-tezos/irmin_fsck.exe integrity-check --heads="Co…”

In that snapshot we have:
14874k contents / 20_954k nodes / 1 commits
nodes: lt_32 20_674_224 / btw_32_256 24_304 / gt_256  256_662

The explicit integrity check (traverses a commit and recomputes hashes) without recomputing hashes for stable nodes (i.e. 32 < children < 256) or with it takes similar times, around 5 minutes.  Also without any checks it is around 4:30 minutes (but all the bench I run were pretty noisy).
I also added a timer just around the stable hash computations, it also suggests that it is pretty fast, around 16s for the 24_304 nodes.
I think 5 minutes is too long to expect users to run an explicit integrity check when opening the store. However, checking all nodes including the stable ones, seems at least in these benchmarks, to not require considerable extra time compared to a commit traversal.
Related to this PR I had to update the version 1 stores in the tests, as they were corrupted, but because of the lack of integrity check on inodes, we did not detect it. Here is the script to generate them.

This work was postponed. We can reference this PR when we pick it back up in a future project.


Redesign claw

Make a kookybotz style claw
several advantages:

no intake needed
individual control of pixels
more reliable dual pixel grip

first iteration of cad complete, will fabricate on Monday

Claw has printed, ready to be assembled.

Nick assembled the claw, it's ready to attach to the arm.


How to Test Only the Depth Estimation Module (MVS)?

Hi,
Thank you for open-sourcing such an outstanding project!
I am currently working on multi-view depth estimation for panoramic images and would like to use your multi-view depth estimation module to evaluate on the Matterport3D dataset. However, I haven't found any specific guidance on how to proceed. It seems possible by modifying the relevant code and parameters in train_depth.py and train_mvs.sh, but I'm wondering if there is a simpler and more straightforward approach to achieve this.
Any guidance or assistance would be greatly appreciated!
Best regards,
Zhongmiao Yan

comment:
https://github.com/thucz/PanoGRF/blob/a8fb5c80e1c8653e926a6bc2770593d71b1f92af/configs/train/depth/m3d_mvs.yaml#L45-L48
uncomment:
https://github.com/thucz/PanoGRF/blob/a8fb5c80e1c8653e926a6bc2770593d71b1f92af/configs/train/depth/m3d_mvs.yaml#L50-L55
Then run:
https://github.com/thucz/PanoGRF/blob/a8fb5c80e1c8653e926a6bc2770593d71b1f92af/train_scripts/train_depth/train_mvs.sh#L1

Thank you for your prompt response! I have followed your instructions, but the visualized pred_depth image I obtained seems to exhibit periodic patterns and incorrect scaling. Could you tell me where the problem might be?
I have attached the resulting images from my run: the first one is depth_gt.jpg, and the second one is depthw_pred.jpg.

Again, thank you for your assistance.
Best regards, Zhongmiao Yan

You might confuse the output channel order. I am not very sure. Maybe you need to check the output dimension with import pdb; pdb.set_trace().

Thank you for your response. I have resolved the issue—it was due to confusing the dimensions of RGB images during data input. As a result, I have successfully obtained the depth prediction results I needed. I will go ahead and close this issue.
Once again, thank you for open sourcing this outstanding work!


Adds support for 'default' apiVersion

Fixes https://github.com/thegroundwork/groundwork.js/issues/49
The API now supports default as a value for the apiVersion header. This will use the latest working version of the API, rather than a hardcoded value.
This updates the validation on apiVersion to mirror what is accepted by the API.

:+1:


Callback issue Android

Version of react-native-iap
"react-native": "0.55.2"
"react-native-iap": "^2.3.19"
Platforms you faced the error (IOS or Android or both?)
Android
Expected behavior
No crash
Actual behavior
Fatal crash
Stacktrace:
java.lang.RuntimeException Illegal callback invocation from native module. This callback type only permits a single invocation from native code.
    CallbackImpl.java:28 com.facebook.react.bridge.CallbackImpl.invoke
    PromiseImpl.java:30 com.facebook.react.bridge.PromiseImpl.resolve
    RNIapModule.java:155 com.dooboolab.RNIap.RNIapModule$4.run
    RNIapModule.java:124 com.dooboolab.RNIap.RNIapModule$3.onBillingSetupFinished
    BillingClientImpl.java:903 com.android.billingclient.api.BillingClientImpl$BillingServiceConnection.onServiceConnected
    LoadedApk.java:1835 android.app.LoadedApk$ServiceDispatcher.doConnected
    LoadedApk.java:1864 android.app.LoadedApk$ServiceDispatcher$RunConnection.run
    Handler.java:809 android.os.Handler.handleCallback
    Handler.java:102 android.os.Handler.dispatchMessage
    Looper.java:166 android.os.Looper.loop
    ActivityThread.java:7377 android.app.ActivityThread.main
    Method.java:-2 java.lang.reflect.Method.invoke
    RuntimeInit.java:469 com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run
    ZygoteInit.java:963 com.android.internal.os.ZygoteInit.main

Tested environment (Emulator? Real Device?)
Live
Steps to reproduce the behavior
Unable to reproduce, have many reports from live app before rollback on crashlytics and bugsnag. App is always in the background when crash occurs.
Code
Initialised on app start:
function* loadAvailableSubscriptions() {
  try {
    const productIds = yield select(getProductIds);
    const subscriptions = yield call(RNIap.getSubscriptions, productIds);
    yield put(setAvailableSubscriptions(subscriptions));
  } catch (error) {
    console.error('Error: loadAvailableSubscriptions', error);
    reportError({ error });
  }
}

export default function* initializeSubscription(): Saga<*> {
  try {
    yield call(RNIap.initConnection);
    yield call(loadAvailableSubscriptions);
    yield put(subscriptionInitialized());
  } catch (error) {
    console.error('Error: initializeSubscription', error);
    reportError({ error });
  }
}

Calling every time app state changes:
export function* appStateChangeWorker(nextAppState: AppState): Saga<*> {
  if (nextAppState === 'active') {
    yield call(RNIap.initConnection);
  } else if (nextAppState === 'background' || nextAppState === 'inactive') {
    yield call(RNIap.endConnection);
  }
}

Same problem.

I think to figure out your case, you need to put log before each function call and try to find out where it is invoking methods. There may be some situations in your code which are not thread safe.

Having the same problem with live version of the app :(
Trying to make sure I init and close connection just once by counting invocations. Anything else I can try for thread safety?

@domhadfield thanks for suggestion, will do that too as a temporary fix. I'll also try closing connection on switching to background.
I've also managed to crash the app in background by force closing Play Store app while the IAP connection is open. Here is the comment I've got this idea from: https://github.com/googlesamples/android-play-billing/issues/45#issuecomment-324466519
I'm not sure how many users might actually close Play Store, but maybe there are similar circumstances causing the crash? @dooboolab can this help somehow?

Related #315. We will keep this issue up there.


[Native File Dialogs] Improve filter list handling.

Adds more filter checks.
Adds mode value checks.
Handles *.x,*.y;X + Y filter as a single filter.

Fixes https://github.com/godotengine/godot/issues/80784

Handles *.x,*.y;X + Y filter as a single filter.

How does that filter work? I've only heard of *.x (X description),*.y (Y description) syntax.

How does that filter work? I've only heard of .x (X description),.y (Y description) syntax.

It's creating a single filter for both extensions with a single description, this syntax should work in all Godot file dialogs.

Superseded by https://github.com/godotengine/godot/pull/81218


onSlideChangeTransitionEnd only works from the second swipe onwards in some weird conditions

Swiper Version: 6.5.9
Platform/Target and Browser Versions: Linux, Firefox and Chrome can reproduce

What You Did
https://codesandbox.io/s/swiper-react-fork-forked-2uuzq?file=/src/App.js
With 3 conditions, detailed in the codesandbox, I find that onSlideChangeTransitionEnd is not called on the first swipe.

Container needs to be hidden via CSS when there is no slides
Must call slideTo(0)
Added slides must be 2 level deep of useEffect

I know this is so weird. Took me a while to figure out the minimum reproducing example. But it's there.

On the first page load, it may work; be sure to refresh the sandbox's iframe using the button.
Expected Behavior
onSlideChangeTransitionEnd is called from the first swipe
Actual Behavior
onSlideChangeTransitionEnd only works from the second swipe onwards

It's not related to 301ffb096295017578e9309886686b42dd4b7785 or

react: fixed issue with Virtual, Controller and Thumbs when running React.StrictMode

as I can reproduce on 6.5.6

Thank you for having a look at #4528. I tried adding observer, and observeParents for this issue and I still observe the described behavior.

Having the same issue here.
Whenever the initialSlide is not 0, the onSlideChangeTransitionEnd does not fire at the first swipe.
Can hack it with:
remove initialSlide but call slideTo(x, 1) at the start;


preg match error Moor.php on line 1066 (missing parenthesis)

this
preg_match('/(?P.)\\(?P<short_class>)[a-zA-Z][a-zA-Z0-9])$/', $class, $matches);
should be
preg_match('/(?P.)\\(?P<short_class>[a-zA-Z][a-zA-Z0-9])$/', $class, $matches);
or maybe I missed something, but just in case you know now

This is fixed in the dotink fork if you want to try that


Add Nextcloud Workflow to apply music metadata on upload

We can write a script using beets to process music uploads and add metadata immediately

 Set up Nextcloud Flow to get Beets working automatically

 Add Nextcloud Workflow to apply music metadata on upload


Force run all tasks in a workflow

Sometimes we need rerun all tasks even if target exists.
To do this we have to introduce new CLI options --all
$ bundle exec tumugi run -f workflow.rb --all

Implemented in #127


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/50996

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/52489


Add libsecret-1-dev info to readme

Related: https://github.com/microsoft/vscode-azurestorage/issues/917
After looking into it more, I was hesitant to auto-detect this package because you have to use that distro's package manager to query the installed packages. This varies based on the distro and keeping all of those commands up to date sounds like a can 'o worms 🪱

Were you passing which into the shell?  Have you looked into using this package? https://www.npmjs.com/package/which

Were you passing which into the shell?  Have you looked into using this package? https://www.npmjs.com/package/which

Were you passing which into the shell? Have you looked into using this package? https://www.npmjs.com/package/which

Unfortunately which doesn't detect if this package is installed (I guess it's not in the path.) Here's an example of what querying the package database looks like on Kali with libsecret-1-dev installed:

Were you passing which into the shell? Have you looked into using this package? https://www.npmjs.com/package/which

Unfortunately which doesn't detect if this package is installed (I guess it's not in the path.) Here's an example of what querying the package database looks like on Kali with libsecret-1-dev installed:

Here's what the AzCopy fail error looks like on linux:

Here's what the AzCopy fail error looks like on linux:


Set the default branch for repositories generated from templates

Should fix #19082
The generate repository function generates a repository from a template, but when used from the API, it does not seem to have any value returned for the default branch. Seeing as the API was simply returning the generated repository object converted to JSON using a function (which did indeed have the default branch filled out), it seemed likely that the default branch was just not being set for the generate repository. This was fixed simply enough (hopefully correctly) with this PR. Please let me know if I missed something, did something wrong, or anything else :)

Not sure if the most recent commit will work, if anyone has any suggestions please let me know how to best approach making this simple change functional.

Will review when I get to my machine, but the CI is failing because you need to make generate-swagger

Yep, thanks :)

https://github.com/go-gitea/gitea/blob/60fbaa90683add2a8af891fc2ca8448b9b75c92e/modules/repository/generate.go#L211
It seems this is where the default branch for the generated repo is being defined. A request missing the key for default_branch would just fill in the object with an empty string for DefaultBranch right? So would it make sense to check whether repo.DefaultBranch is an empty string and only define the default branch using the template repo if it is?

I think once the API is figured out the UI can be implemented as well.

Default branch is also used here https://github.com/go-gitea/gitea/blob/60fbaa90683add2a8af891fc2ca8448b9b75c92e/modules/repository/init.go#L106

@jolheiser think that should also be implemented in a similar way as of the latest commit.

Hey @jolheiser sorry to bother you but I think I got it now, would you mind taking a look?

It looks like this is working via API now.

Is there anything left for me to do or is this PR mostly set?

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@909804b). Click here to learn what that means.
The diff coverage is 84.21%.

@@           Coverage Diff           @@
##             main   #19136   +/-   ##
=======================================
  Coverage        ?   46.53%
=======================================
  Files           ?      857
  Lines           ?   123207
  Branches        ?        0
=======================================
  Hits            ?    57332
  Misses          ?    58932
  Partials        ?     6943

Impacted Files
Coverage Δ

models/repo_generate.go
21.05% <ø> (ø)

modules/structs/repo.go
76.92% <ø> (ø)

modules/repository/generate.go
29.61% <66.66%> (ø)

routers/api/v1/repo/repo.go
66.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909804b...ef47540. Read the comment docs.

Any clue why this is failing CI?

it's not your fault - it's this TestRepoIndexer. The test is inherently racey and things have now started to become super racey there. I've added #19225 which should resolve the issue.

Alright, nice! Seems like it finally passed this time.


Actions: Remove needs  from the publish-github job

Publish action is failed due to unknown create-release action. This PR removes this because we manage the releases manually in this repo and we don't need needs. Please let me know if I miss anything or misinterpreted the error message!

:wave: Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

:art: If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
:fast_forward: If this is a PR that includes changes to an interaction, please include a video recording in the description.
:warning: If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.


Why don't the line numbers show by default?

I'm a bit confused by Bugsnag, because it doesn't seem to show the line numbers in the crash logs.
I was using Crashlytics previously, and it was able to show me the method names and line numbers for a crash. But I'm not getting the line numbers for Bugsnag in the crash reports.
Apparently I can upload the dsym to get this information.  I'm not really sure about that, because after I ran the suggested script, it still didn't show me any line numbers in the crash report.  (and it says "Still Missing" afterwards, which I don't get - maybe it's talking about other targets?).
Anyway why is it that out-of-the-box Crashlytics can show the line numbers, but Bugsnag can't? I don't have to upload any such dsym data manually for Crashlytics...
Or could there be something wrong with my Bugsnag configuration?  (I installed version 4.1.0 via Cocoapods...)

Hi @asgeo1, thank you for the report.

Apparently I can upload the dsym to get this information. I'm not really sure about that, because after I ran the suggested script, it still didn't show me any line numbers in the crash report.

Correct. After uploading your dSYM file, we can translate the raw stacktrace into the method names and line numbers involved. You can configure your project to upload dSYM data automatically, though it should have happened automatically when installing Bugsnag via Cocoapods. Can you check your project builds phases for a "Run Script" phase named "Upload Bugsnag dSYM"? If its not there, you can add it manually and retry, using the non-cocoapods installation guide, Step 5. This is very similar to how Crashlytics handles symbolication as well.
Was there any output from running the dSYM upload script?

Hi @kattrali,
You're right, there is no "Upload Bugsnag dSYM" run script.  That's strange, that it didn't get added for my project.  I've tried removing the pod and re-adding it, but it never gets added to my project.
Anyway, I followed the instructions to manually add the run script, and that has worked - I'm now seeing the line numbers in Bugsnag.
With regards to running the script manually on my machine, I was getting a Still Missing message output.  I'm not sure what that was about, but I guess it doesn't matter since it's working fine now.
Cheers!

For what it's worth, I'm getting the following error message when running the script manually:
Still missing: CAF09B10-6CAA-3FB7-AE73-2120F3C152D5

I'm looking into adding the Run Script right now...

Adding the Run Script in the Build Phase found here worked great!


How to set and get Claims from Controllers?

Hi, first of all thanks for this package!
I'm testing it and I would like to know how can I set and get Claims from Laravel Controllers:
// How to add Claims in login?
public function login(Request $request)
{
    // some code
    $credentials = [
            'email' => $request->email,
            'password' => base64_decode($request->password)
        ];
    Auth::attempt($credentials);

    $user= $request->user();
    $token = $user->createToken('ACCESS_TOKEN')->accessToken;

    // At this point, how can I add custom Claims to my token?
    // I would like to do something like this:
    $token->addClaim('companyId', $request->company_id); // how can I do this through a Controller?
}

// How to get Claims?
public function me(Request $request)
{
    $user = $request->user();
    $token = $user->token();

    // How to get the companyId Claim set on login method?
    $companyId = $token->getClaim('companyId'); // How can I do this?
}

If you use my package you don't use it like that. My package hooks into Laravel's token generation itself.  So the token you get back from your user->createToken() passes through my package.  But for that to happen to have to create a config, and a class to add the claims. That's described in my package documentation. Just follow it step by step.

@corbosman thanks for you reply. I looked at the docs, however I still don't understand how can I get a Claim value on a Controller function. I've tried (new \Lcobucci\JWT\Parser())->parse($token); but it don't work.

First you install my package. You either pick ^1 or ^2 depending on your version of Passport.
composer require corbosman/laravel-passport-claims ^2

Then you create a claim class, pick a good name for it.
php artisan claim:generate Claims/CompanyId

Then you edit the class you just made, and add the data to the token as it shows you in the example code in the class.
    public function handle($token, $next)
    {
        $token->addClaim('companyId', request()->input('company_id');

        return $next($token);
    }

Next you create/edit the config file that tells passport to hook into my claim package.
php artisan vendor:publish --provider="CorBosman\Passport\ServiceProvider"

<?php

return [
    /*
    |--------------------------------------------------------------------------
    | JWT Claim Classes
    |--------------------------------------------------------------------------
    |
    | Here you can add an array of classes that will each be called to add
    | claims to the passport JWT token. See the readme for the interface that
    | these classes should adhere to.
    |
    */
    'claims' => [
        App\Claims\CompanyId::class
    ]
];

Then you're done. Now when you create a token using passport, if all goes well it should have the company id claim attached to it.

Hello @corbosman , thanks for your help, I actually did this steps and it worked well, the companyId was successfully attached to the token, but my question is: how can I get the companyId Claim value back?
For example, in my controller, how can I get the companyId Claim value?

You can see how I do that in the tests. Either for version 1 or version 2.
https://github.com/corbosman/laravel-passport-claims/blob/1.7.1/tests/AccessTokenClaimTest.php
https://github.com/corbosman/laravel-passport-claims/blob/2.0.0/tests/AccessTokenClaimTest.php
basically you just parse the token with Lcobucci\JWT\Parser and then you can use a method to get claims from the token.

Nice, it worked! This is how I did it, in case of someone need it:
$jwt = \Lcobucci\JWT\Configuration::forUnsecuredSigner()->parser()->parse($tokenString);
$companyId = $jwt->claims()->get('companyId ');


Inspiration from other libraries

I want this library to be THE library that PHP developers use for CSV data. I want it to literally be laughable for somebody to use anything else. When you type in CSV PHP I want CSVelte to be at the top of the list. In order to get there though, I have no issue with standing on the shoulders of giants. After all, I wrote the original library (PHP CSV Utilities) as a quasi-port of python's CSV module. So... here is a list of other libraries that are doing cool things with CSV or are in some other way interesting or relevant:

csvkit python csv library
agate python library somehow related to csvkit
csv2sql converts a csv file to a mysql create table query
conformist very cool ruby library that allows you to define csv schemas programmatically so that you can validate/conform csv files to that schema
exafox/schema Go tool set for inferring datatypes from CSV
schema2csv Javascript library for CSV schema functionality
csv_schema Ruby CSV schema library
Omnidator Converts schema.org formats to other common formats
csv-validate - Another python CSV schema/validator library
csv-schema A PHP schema implementation!! And it even looks relatively well written/documented. Definitely worth a closer look.
csv-schema A javascript library that analyzes a CSV file and imports it into a database. GUI I think.
csv-schema - What looks to me, to be a mature, well thought out csv schema format/spec. If I were to go the "use an existing standard" route, this would probably be my choice.

I found all this from a ten second github search. I haven't even tapped Google yet. There's definitely a lot of quality stuff out there to fish for good ideas.
One thing I definitely want to avoid though, with this library, is feature creep. It is intended to be a simple, easy to use, no nonsense CSV library. I have no idea including functionality that isn't conformant to that principle, I just want to include those types of features as modules, extensions, plugins, or whatever you want to call them.

This library appears to be the (possible) de facto PHP CSV library as of now. Take a look at how they're doing things and see if you can do better... http://csv.thephpleague.com/

These two libraries appear to also be pretty popular. Well, at least the first. I believe the second is the inspiration for the first.

https://github.com/parsecsv/parsecsv-for-php
http://minghong.blogspot.com/2006/07/csv-parser-for-php.html

From what I've seen of the CSV libraries written in PHP, my library is certainly going to be able to hold its own.


Replace TableSegment of ColumnSegment with OwnerSegment.

Ref #4495.

Pull Request Test Coverage Report for Build 6

1 of 29 (3.45%)  changed or added relevant lines in 11 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 59.042%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java
0
1
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/OracleVisitor.java
0
1
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java
0
1
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java
0
1
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQLServerVisitor.java
0
1
0.0%

sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/generator/impl/TableTokenGenerator.java
1
4
25.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java
0
4
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDMLVisitor.java
0
4
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java
0
4
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/generator/impl/TableTokenGenerator.java
2
85.0%

Totals

Change from base Build 946:
-0.02%

Covered Lines:
10614

Relevant Lines:
17977

💛  - Coveralls

/run tests


Implement equality and multiplication operators for RgbaFloat & RgbaByte

In addition:

static Multiply methods
ToRgbaByte()/ToRgbaFloat()
RgbaFloat now has a public constructor that accepts a Vector4

Looks reasonable. Should there be multiplication operators and methods for both parameters orders?

Indeed, there should be.

Done.

@mellinoe I'm thinking maybe the equality operators and a public constructor accepting a vector is all we need. Anyone can implement the rest if needed (as extension methods).

@mellinoe Removed the questionable changes and squashed the commits.

We should also override Object.Equals(object o):

warning CS0660: 'RgbaByte' defines operator == or operator != but does not override Object.Equals(object o)
warning CS0660: 'RgbaFloat' defines operator == or operator != but does not override Object.Equals(object o)

I've manually merged this, and added the Equals(object) overrides as well. Thanks!


Not finding localhost site

When I click on my downloaded pantheon site in Kalabox it opens up my browser and tries to direct me to my-site.kala but is then redirected to http://www.dnsrsearch.com/index.php?origURL=http%3A//my-site.kala/&r= .  Any ideas on how to fix this?

I had this same issue, with Cox as my ISP, and used this link to solve the issue.  I had to chose the wireless network instead of the local.  http://www.cox.com/residential/support/internet/article.cox?articleId=e14ee070-6448-11df-ccef-000000000000


how to fix gap between dialog header and mat dialog starting

Please describe the feature you would like to request.
i want to remove gap of blue circles in attached screenshot
What is the use-case or motivation for this proposal?

Is there anything else we should know?

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.


[Feature] using spring discovery client replace eureka

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Problem Description
there have many code about eureka as service resgitry.  but I thank we should do this base spring cloud's abstract, not the eureka implementation.
Description
no
Use case
replace eureka with nacos
Solutions

remove the eureka related code, and use config file replaced.
the service's cache should managed by the Service registry implementation throuth config file.

Anything else
no
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

this is just for service discovery,  lb ribbon is not modifed.


Update template to match new dir structure

Contributes to https://github.com/Azure/azure-sdk-for-java/issues/2847 and sets an example.
@Azure/azure-sdk-eng

Can one of the admins verify this patch?


[X11] Partial fix for Editor and Project Manager stealing focus on some window managers

This is a workaround for the most critical portion of the WM focus bug described in #68305. On some specific X11 WM configurations, the editor's main window and any popups it creates will fight for focus, which causes a total system lockup due to mouse and keyboard input being stolen as well. Getting out of this infinite loop requires force restarting the system.
It can be tested with the following shell script:
!#/bin/sh

godot4 &
sleep 30
pkill -x godot4

Here is a gif of the bug in action on my machine:

The gif above actually doesn't show the exact behavior. The constant focus swap is actually too fast for my screen recorder's framerate to pick up, so what you are seeing is about 24 out of 60 focus swaps. :)
Here is the same with this patch applied:

My system information:

Linux version: 6.6.6-arch1-1 (linux@archlinux) (gcc (GCC) 13.2.1 20230801, GNU ld (GNU Binutils) 2.41.0)
WM: Fluxbox-only launched via Xinit.

The workaround identified by @nargacu83 in #68305 is to remove the call to XSetInputFocus in the ConfigureNotify event handler, so I have removed the conditional block that calls this as well as the setup code above it since there is no need to allocate the memory for the variables if they won't be used in that call anymore.
This is just a hack and is not a complete fix for #68305. Multiple developers are collaborating on a proper fix in the discussion in that issue, but time is a valuable resource that no one has enough of, so I am submitting this workaround as a stop-gap to prevent the most critical problem while we work on a full solution for the underlying cause.
This bug affects a very small number of users, and the general consensus in the related issue is that we don't want to submit a PR for a hack if we can get a proper fix. Particularly since we aren't completely sure why this workaround fixes the problem, and I agree with this as well, but personally, I am concerned that with this being a platform bug, it could affect exported games and not just developers, and in that case, it probably wouldn't show up on the developer's machine, but a player with the affected configuration could encounter the bug when running an exported Godot game, and although the number of people playing games on custom WM-only Linux machines is probably very low, it only takes one very vocal gamer on Twitter to ruin an indie studio, so I wanted to submit this workaround now instead of sitting on it since no one in the related issue has reported any regressions with this workaround, and we don't know when a proper fix will be ready.
Please feel free to close this PR if you feel that we should wait until we have a better idea of the problem and exactly why this workaround works. Thanks!

For the reference, it was added in https://github.com/godotengine/godot/pull/41456, and issues with freezing on some WMs were reported soon after https://github.com/godotengine/godot/issues/41574, but it's marked as resolved (probably only fixed with the i3 specifically).

Popup handling was changed a lot, so I'm not sure if this code is necessary for anything. It should be tested to see if it's reintroducing https://github.com/godotengine/godot/issues/37674 or https://github.com/godotengine/godot/issues/41578 on non tiling WMs.

Popup handling was changed a lot, so I'm not sure if this code is necessary for anything. It should be tested to see if it's reintroducing #37674 or #41578 on non tiling WMs.

Tested briefly on KDE Plasma on X11, it doesn't reintroduce those issues for me. From a quick test I didn't spot any weird change in behavior.
Would be good to have it tested on more DEs/WMs and on Xwayland.
CC @Riteo @groud @Calinou

As another random data point, I use i3 and Godot's "window grabbing focus behavior" is super disruptive. However, in my case, it doesn't lead to multiple windows fighting for focus and things getting locked up, it's just very annoying. :-) When I have a chance I'll try with this PR and see if it helps in my case. But it would be kind of nice to have an editor setting that I could enable that would just prevent any window in the editor from grabbing focus.

As another random data point, I use i3 and Godot's "window grabbing focus behavior" is super disruptive. However, in my case, it doesn't lead to multiple windows fighting for focus and things getting locked up, it's just very annoying. :-) When I have a chance I'll try with this PR and see if it helps in my case. But it would be kind of nice to have an editor setting that I could enable that would just prevent any window in the editor from grabbing focus.

In case it helps, #74378 is related to #68305, but has a broader scope, and users have reported odd focus behavior between workspaces on i3. I generally only use one workspace, so I haven't looked into this, but one user confirmed that this workaround does help with focus on i3 but doesn't fix the issue between workspaces. See https://github.com/godotengine/godot/issues/68305#issuecomment-1762851375 for details.
Confirmation from another i3 user would be really helpful though. :)

I just tested this PR with i3, and things don't seem to get any worse, but it doesn't seem to help my problems either.
To be clear, my issues mostly revolve around switching between the Godot editor and VS Code, where Godot will grab (or refuse to give up) input focus, and despite a new window visually appearing to have focus (like, the title bar is highlighted in the way that usually indicates it has focus), all the keyboard input still goes into the Godot editor. My "work around" is that I have to toggle back and forth between focusing on Godot and focusing on the thing I actually want to get my keyboard inputs, and eventually they'll go where I want.
I'll try to see if my problem is represented in one of the existing issues, and if not, make a new issue.

I just tested this PR with i3, and things don't seem to get any worse, but it doesn't seem to help my problems either.
To be clear, my issues mostly revolve around switching between the Godot editor and VS Code, where Godot will grab (or refuse to give up) input focus, and despite a new window visually appearing to have focus (like, the title bar is highlighted in the way that usually indicates it has focus), all the keyboard input still goes into the Godot editor. My "work around" is that I have to toggle back and forth between focusing on Godot and focusing on the thing I actually want to get my keyboard inputs, and eventually they'll go where I want.
I'll try to see if my problem is represented in one of the existing issues, and if not, make a new issue.

Yeah, there are a lot of problems with the focus behavior on WMs in the X11 backend. This PR is only intended to address the system lock up on very specific configurations since it seems like a fix for the other focus issues will require a significant overhaul of the event handlers, and a few devs have been working on this off and on for months without a lot of progress (mostly due to lack of time). I think some of the comments in #74378 mentioned similar issues with i3, and the user who tested this workaround on i3 previously did mention something similar about focus problems with an external text editor.
Thanks for testing it out!

Okay, I was able to test this on the following WMs/DEs: Fluxbox with picom (Xwayland), Openbox X11, Openbox Xwayland, Budgie, Cinnamon, Enlightenment, lxde, lxqt over Fluxbox, lxqt over Openbox, Mate, and xfce4.
I just did a quick test of launching the editor and opening a popup, so I have not tested for regressions related to #37674 and #41578 yet, but I wanted to make sure there wasn't anything weird going on with popups before regression testing on each DE.
I will check for #37674 and #41578 on each DE eventually this week, but it probably won't be tonight. :)
Here are the gifs of launching the editor and opening a popup window in each environment:
Fluxbox Xwayland:

Openbox X11:

Openbox Xwayland:

Budgie:

Cinnamon:

Enlightenment:
File size too large, but the result is the same as all the others.
lxde:

lxqt-fluxbox:

lxqt-openbox:

Mate:

xfce4:

This has really reminded me why I don't use full DEs. Thank $deity for XBindKeys :rofl:

Okay, scrolling through 10 gifs is a little much. Lmk if you want me to remove them.

Okay, I took a look at #37674 and #41578 and they were much simpler to test than I thought. :man_facepalming:
I tested both on all of these environments: Fluxbox X11, Fluxbox Xwayland, Openbox X11, Openbox Xwayland, Budgie, Cinnamon, Enlightenment, lxde, lxqt over Fluxbox, lxqt over Openbox, Mate, and xfce4.
The following is a gif of the test on Fluxbox X11. All of the other environments gave exactly the same behavior, so I am only uploading the single gif:

I believe this is everything I can test as far as different DEs goes. Please let me know if you have any questions for me. Thanks!

This needs a rebase against the current master branch to resolve conflicts. And then I guess we should just give it a spin and see if any X11 users report any regression.

Thanks!


Add position to click events

[x] I have definitely checked that there are no proposals for this already in the proposals folder

Summary of feature
Add the click position as a parameter to click events.
Comments
The single click event is per definition a delayed event as a single click can only be determined if no second click took place in a given time span. The problem now is that the position may have changed until then so the actual clicked position is not necessarily the position the mouse is at when the click event is raised. This is more relevant the longer the double click time is. So I would like to add the real click position as a parameter to the click event. For consistency reasons I would also add it to the double click event.
In the internal code we already store the position of the first click. But it is not provided in the event. Current workflow is retrieving the current position from the mouse when the click event is raised. But as I said the position may have changed between the first click and the event raising.

Slated for 2.0 as this will be a breaking change, sorry :(

No problem. There are at least workarounds like storing the click position in mouse down event handler and use it in click handler. ;)

@Pyrdacor Unrelated but can you check Discord?

Done in #260


non_max_suppression is very slow and doesn't appear to have a cuda or multi-threaded implementation

It appears that tf.image.non_max_suppression currently takes about 200ms for about 8000 boxes, runs on a single CPU thread and doesn't have a GPU implementation.
Environment info
Operating System:
Ubuntu 16.04
Installed version of CUDA and cuDNN:
(please attach the output of ls -l /path/to/cuda/lib/libcud*):
8.0, 5.1.5
If installed from binary pip package, provide:

A link to the pip package you installed:
The output from python -c "import tensorflow; print(tensorflow.__version__)".
0.12.0-rc1

Is there any progress on this feature?

Also interested in this as well.

Are there any good examples online on how to use tf.image.non_max_suppression ?? And does using this in-built nms function over our own function improves performance of the model ?

The documentation is pretty clear IMHO, which part do you have questions?
For speed the answer is always the same: it depends on the speed of "your own function" (which only you know) plus the overhead to transfer data between TF and your own function.

This feature will be fantastic

In Work-efficient parallel non-maximum suppression for embedded GPU architectures the authors describe how to bring NMS to the GPU.
Also does anyone know what the difference is between the implementation of NonMaxSuppressionV2 and NonMaxSuppression in Tensorflow?

@jonla1 Someone has implemented a CUDA version based on the mentioned paper here:
https://github.com/jeetkanjani7/Parallel_NMS
And following is my PyCUDA version:
https://github.com/keineahnung2345/Parallel_NMS

https://github.com/zengarden/light_head_rcnn/tree/master/lib/lib_kernel/lib_nms_dev
Here is a GPU version which can be built for TF.


[Full-auto] Handle transition of a replica from offline to dropped state on host start up

In Helix full-auto mode, when a host is down, it is possible that its replicas are reassigned to a different host. After the host comes up, Helix may directly transition the replicas from OFFLINE -> DROPPED state without going through OFFLINE -> BOOTSTRAP -> STANDBY -> INACTIVE -> OFFLINE -> DROPPED steps. In this case, we have to make sure the 'replica decommission' steps are followed to make sure peers have caught up with it before deleting the files.

Codecov Report
Patch coverage: 73.33% and project coverage change: -0.06 :warning:

Comparison is base (19fa188) 68.25% compared to head (c0fbe23) 68.20%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2454      +/-   ##
============================================
- Coverage     68.25%   68.20%   -0.06%
- Complexity    10276    10302      +26
============================================
  Files           775      778       +3
  Lines         61553    61726     +173
  Branches       7559     7579      +20
============================================
+ Hits          42016    42099      +83
- Misses        17123    17198      +75
- Partials       2414     2429      +15

Impacted Files
Coverage Δ

...in/java/com/github/ambry/store/StorageManager.java
87.46% <50.00%> (-0.69%)
:arrow_down:

...rc/main/java/com/github/ambry/store/BlobStore.java
81.48% <88.88%> (+0.09%)
:arrow_up:

... and 31 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Possible memory leak

I confirm (by marking "x" in the [ ] below: [x]):

[x] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
[x] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[x] I have read contributing guidelines.

Summary
Mattermost Desktop consumes constantly increasing amount of memory. I have something around 20 open channels and severl dialogues with other users. Memory consumption after cold restart was around 250 MB, after 5 hours it's around 750 MB. We also saw 1000 MB on one of our collegues desktop.
Steps to reproduce
Just use it for while and look at memory consumption in your Task Manager.
Version numbers

MS Windows 10 Pro 1709, MacOS X 10.13
Mattermost Desktop App Version 4.0.0
Mattermost Server 4.5.0 (4.5.1, postgres) - Omnibus GitLab install v10.4.3

Expected behavior
Memory consumption remains low.
Observed behavior
Growing memory consumption.

@divanikus Do you know if the happens on a browser?
I suspect it might be from loading more data over time as you switch channels (and receive new messages).

I can confirm that in-browser version also consumes memory, but at lesser amount. After 3 hours I see 360 MB for a Chrome tab and 1069 MB for desktop app.

Ok, switching between channels boosts memory consumption at both in-browser and desktop app. I got 600 MB in Chrome in 2 minutes by simply switching between channels.
Anyway, it's totally not OK.

Ok, I've reported an issue for server too mattermost-server#8297

Thanks. As you saw on Chrome, switching channel increases memory consumption. The process is merely executing the webapp JavaScript as well as Chrome. So the desktop app can't control the consumption.

@divanikus I'll close this issue for now, and we can continue discussion at https://github.com/mattermost/mattermost-server/issues/8297


Adding set_config_entry

made key/value registry thread safe
renamed the header file declaring the API functions
add test

Do we really initialize the config with multiple threads? I was under the impression that this would only always happen at startup and is then never changed.

This patch introduces a new API function set_config_entry. That means it can be called at any point in time.

What are the use cases for set_config_entry? What are the semantics in terms of making the changes visible to the application, especially when multiple localities are involved?

What are the use cases for set_config_entry?

The use case is runtime adaptive tuning of parcel coalescing. We want to be able to control the parameters for this dynamically.

What are the semantics in terms of making the changes visible to the application, especially when multiple localities are involved?

Same as before: the changes are propagated only to the locality where set_config_entry is called. No news here.

On 10/24/2016 02:31 PM, Hartmut Kaiser wrote:

Do we really initialize the config with multiple threads? I was
under the impression that this would only always happen at startup
and is then never changed.

This patch introduces a new API function |set_config_entry|. That means
it can be called at any point in time.

Is this really what we want? What are the semantics here? What about
keeping the config consistent over localities? What's the usecase?

On 10/25/2016 12:57 PM, Hartmut Kaiser wrote:

What are the use cases for |set_config_entry|?

The use case is runtime adaptive tuning of parcel coalescing. We want to
be able to control the parameters for this dynamically.

Do you really want to go through the runtime system config there?
Wouldn't some plugin specific mechanism be more suitable? In the end,
setting/getting config entries is always going through a string, or
other form of type-erasure, which isn't exactly the fastest form to
store/retrieve values.

What are the semantics in terms of making the changes visible to the
application, especially when multiple localities are involved?

Same as before: the changes are propagated only to the locality where
|set_config_entry| is called. No news here.

With the difference that it is now exposed as part of the public API, so
the config is, potentially, subject to change after runtime system
startup. Especially for runtime adaptivity use case, having special
purpose mechanisms sounds like the better option instead.

Do you really want to go through the runtime system config there?

Yes. a) it's already in place, b) why introduce something specific just for this?

In the end, setting/getting config entries is always going through a string, or other form of type-erasure, which isn't exactly the fastest form to store/retrieve values.

So what? Even if we have to go through a conversions to/from a string, if this is done once in a while only (perhaps once every 10 milliseconds) the introduced overhead shouldn't even be measurable.

With the difference that it is now exposed as part of the public API, so the config is, potentially, subject to change after runtime system startup.

Correct. Again: so what? I'd rather think this is a good thing (tm).

Especially for runtime adaptivity use case, having special purpose mechanisms sounds like the better option instead.

So you're proposing to introduce a custom solution for each and every runtime adaptive use case we might come across? I don't think this is a scalable solution.
Another point speaking against a custom solution would be that the coalescing module is a plugin module, i.e. none of the binaries directly link to it. Introducing a custom solution for setting the parameters would require either a custom solution for loading this plugin or direct linking with it. Both options are not exactly what we want.

Am 26.10.2016 6:56 nachm. schrieb "Hartmut Kaiser"<EMAIL_ADDRESS>
:

Do you really want to go through the runtime system config there?

Yes. a) it's already in place, b) why introduce something specific just
for this?

Because every component will require a specific, well defined interface (in
one way or another). Why not stick with c++ and benefit from compile time
checks and native types?

In the end, setting/getting config entries is always going through a
string, or other form of type-erasure, which isn't exactly the fastest form
to store/retrieve values.

So what? Even if we have to go through a conversions to/from a string, if
this is done once in a while only (perhaps once every 10 milliseconds) the
introduced overhead shouldn't even be measurable.

With the difference that it is now exposed as part of the public API, so
the config is, potentially, subject to change after runtime system startup.

Correct. Again: so what? I'd rather think this is a good thing (tm).

For the record: I think such an API might indeed have it's benefits. For
this specific use case, it feels like a quick and dirty hack.

Especially for runtime adaptivity use case, having special purpose
mechanisms sounds like the better option instead.

So you're proposing to introduce a custom solution for each and every
runtime adaptive use case we might come across? I don't think this is a
scalable solution.

Yes, that's exactly what I'm proposing. Every component will need to have
it's interface defined anyway. I'd prefer a properly designed c++ mechanism
over runtime based string lookups.

Another point speaking against a custom solution would be that the
coalescing module is a plugin module, i.e. none of the binaries directly
link to it. Introducing a custom solution for setting the parameters would
require either a custom solution for loading this plugin or direct linking
with it. Both options are not exactly what we want.

That's another discussion, I guess...

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

That's another discussion, I guess...

It is not. This is exactly why we can't have a special interface just to set the values

That's another discussion, I guess...

It is not. This is exactly why we can't have a special interface just to set
the values

It is to the extent that whether the runtime config is the right place to
exchange information for a feedback loop or not. We just don't know all
requirements yet. It is also to the extent whether the parcel coalescing
component should be a dynamically loadable module or not. It is also to the
extent why the auto tuning feature of a specific component shouldn't be tightly
coupled with the component it tries to adapt.
As said, having the an easy to use API function to set config values might
indeed be helpful. I don't think it is the right tool for the auto tuning
feature you described (not saying that it wouldn't work that way).

On Mittwoch, 26. Oktober 2016 12:50:03 CEST Hartmut Kaiser wrote:

That's another discussion, I guess...

It is not. This is exactly why we can't have a special interface just to set
the values

It is to the extent that whether the runtime config is the right place to
exchange information for a feedback loop or not. We just don't know all
requirements yet. It is also to the extent whether the parcel coalescing
component should be a dynamically loadable module or not. It is also to the
extent why the auto tuning feature of a specific component shouldn't be tightly
coupled with the component it tries to adapt.
As said, having the an easy to use API function to set config values might
indeed be helpful. I don't think it is the right tool for the auto tuning
feature you described (not saying that it wouldn't work that way).


Where is ../lib??

This example has the line:
const service = require('../lib');
...where is this?

@genyded Its created by the compile task in the package.json file. In your project it would just be require('feathers-rethinkdb')

I fixed the example. It should be require('feathers-rethinkdb')

Thanks Cory and David... I figured it out based on Cory's comment and then David 'fixed' it so it won't confuse others. I love how reactive (no pun intended) you Feathers JS folks are!

I forgot that this would break the build. I'll add it as a comment instead, we're actually running our tests against the example with the current build so ../lib has to remain there.


CLI Wont allow me to create VM, error message: An RSA key file or key value must be supplied to SSH Key Value.

So im currently on using bash on the cli. I am trying to create a new VM using the command: az vm create -g FirstRG -n FirstVM -l EastUS --image UbuntuLTS
It reads me an error message stating: An RSA key file or key value must be supplied to SSH Key Value. You can use --generate-ssh-keys to let CLI generate one for you
could someone please help me out July 23, 2019. I am currently using the cli pipeline for azure with my macbook

You can just specify the --generate-ssh-keys and the command will work. Or you can use your own key file and supply it through --ssh-key-values. For context, you can check out the doc

You can just specify the --generate-ssh-keys and the command will work. Or you can use your own key file and supply it through --ssh-key-values. For context, you can check out the doc

sir, could you please elaborate, because i still get it

[1]-[host]-[/d/work2]
# az vm create --resource-group Images --name portalz --image "https://xxxxxxxx.blob.core.windows.net/vhds/stuff.vhd" --use-unmanaged-disk --os-type linux --admin-username admin --ssh-key-values /home/admin/.ssh/id_rsa.pub
An RSA key file or key value must be supplied to SSH Key Value. You can use --generate-ssh-keys to let CLI generate one for you
[1]-[n76v]-[/cygdrive/d/work2]
# ls -l /home/admin/.ssh/id_rsa.pub
-rw-r--r-- 1 zvn None 390 Nov 20  2014 /home/zvn/.ssh/id_rsa.pub

ssh-key-values is ignored
the doc use a file and values..other place use value , no plural
az vm create
--resource-group myResourceGroup
--name myVM
--image UbuntuLTS
--admin-username azureuser
--ssh-key-values mysshkey.pub
any requirement on the public key ? ( beside RSA )


Fix original image meta not being set during creation when using delayed_paperclip

We use delayed_paperclip and paperclip-meta together in our Rails app. We want to return the original image with width and height when the other styles are being processed in the background. This PR makes it so that original image meta is set during creation.
More info: https://github.com/jrgifford/delayed_paperclip/#displaying-images-during-processing
Do you think this is a good addition?
Thanks for an excellent open source library!

Thanks for submitting this PR. If you rebase against the latest master, the build should pass.

Apparently Paperclip::Attachment#assign_attributes. does not exist in 3.x. However Paperclip 5.0 should soon be out. Do you think it's ok to drop the support for 3.x?

Btw. after I rebased on master bundle exec rake now outputs stuff like this:
/home/travis/.rvm/gems/ruby-2.3.0/gems/paperclip-4.3.6/lib/paperclip/geometry_detector_factory.rb:29: warning: assigned but unused variable - e
/home/travis/.rvm/gems/ruby-2.3.0/gems/paperclip-4.3.6/lib/paperclip/tempfile.rb:23: warning: assigned but unused variable - path
...

https://travis-ci.org/teeparham/paperclip-meta/jobs/125088495

Also I tried out this PR with Paperclip 5.0.0.beta2 and all tests passes.

I'm ok to drop support for paperclip 3, but that should be in a separate PR & will require a major version bump (which is fine). #assign_attributes is a Rails method.
All the warnings come from paperclip and other gems when running the new version of rake. I wonder if we can turn the warning level up.

Sorry if unclear: The fix in this PR doesn't work with Paperclip 3.x
I am talking about the #assign_attributes here and here.

Or, is there a way to merge this PR without dropping support for 3.x and then do that in another PR?

 You mean:

Open PR to remove 3.x support
Merge it
Rebase this branch on master

Correct?

Ok, so I have opened a separate PR and rebased this PR on top of that.
Is this what you had in mind?

When the other PR is merged, I will rebase again.

Rebased now. Please review when you have the time. Thank you very much!

Do you think you will get a chance to take a look at this?

Thanks!

@johanlunds I have the opposite problem: The original image dimensions are written to meta (thanks to your patch), but after this point no more meta is written for the other styles as they are processed. Did you need to do anything specific to get that working?


Allow block hashes in URL

The web3 API allows fetching blocks with either block number or block hash, so this is not an issue. And since our middleware uses the block.number from the response to write the block in store we always keep the right format no matter if fetching with hash or number in the first place. All good! 👍


Ability to sync database

Ref: https://github.com/bigbinary/boxy/issues/3

@neerajdotname I've got a basic version of sync feature ready. I'm wondering where I can test it end-to-end in a real environment. Do we have any unused staging instance of any project?

Use lab4 of innovista but be careful. Don't wipe out data in production.
Sent from my iPhone

On Jun 10, 2016, at 1:16 AM, Ershad Kunnakkadan<EMAIL_ADDRESS>wrote:
@neerajdotname I've got a basic version of sync feature ready. I'm wondering where I can test it end-to-end in a real environment. Do we have any unused staging instance of any project?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@RahulMahale can you work with @ershad to get this in?

@vipulnsward sure, @ershad lets skype to discuss this when you are up


Datastore: add toString() to OrderBy

PTAL

LGTM. When merging, please add line "Fixes #2651." so the issue auto-closes.


Disable all VDAFs except Prio2 in draft-ietf-ppm-dap-02

If codepoints change across VDAF versions, then taskprov will end up with different codepoints in different versions. Right now we only intend to support draft-02 and the latest version. Since draft-02 is only compatible with draft-ietf-ppm-dap-02 and we don't need any new VDAFs for this version, let's put in a feature freeze.

Update to VDAF-07 (blocked)
Update taskprov to latest version
For DAP-02, opt-out unless Prio2 is used
Bug: Opt-out if unsupported VDAF is indicated (currently we panic)


[SSR] context.styles is undefined when runInNewContext !== true

Version
2.4.2
Reproduction link
https://github.com/nekuz0r/vuejs-ssr-styles-issue
Steps to reproduce
npm run build
npm run start

What is expected?
context.styles to be defined
What is actually happening?
context.styles is undefined when runInNewContext is equal false or 'once'

context.styles getter is not set on the new context created when
runInNewContext is equal to false or once.
vue-style-loader is defining a getter for context.styles property
(https://github.com/vuejs/vue-style-loader/blob/master/lib/addStylesServer.js#L9)
When runInNewContext is false or once, VueJS is copying the _styles
property in userContext from initialContext but the styles getter is not.
(https://github.com/vuejs/vue/blob/8ff77a243cae0627a651fe852a6c07f7bcfce2a3/src/server/bundle-renderer/create-bundle-runner.js#L131)
Adding the following line after that one fixes the issue
Object.defineProperty(userContext, 'styles',
  Object.getOwnPropertyDescriptor(initialContext, 'styles')
)

It's a typo which makes styles not enumerable, it should be fixed after the PR merged.

@JounQin are you sure? Even if it's not enumerable it should still be present. (I haven't got time to properly investigate this issue yet)

Ah, sorry I read it wrong, and as I know it should not be an issue here, I'll try to figure it later.


Mpris repeat playback controls fix

Add simple fix for playback controls not going back or forward when it should while in repeat mode for mpris
Now expected behaviour will allow playback to go back or forward whenever while repeating, (same behaviour as the normal spot player)

Haha I can barely keep up with all your PR!
This is nice! But this additional field shouldn't be needed, has_prev_next should return the correct result (or else it's a bug), it might need to be refreshed when the event is received however

has_prev_next should return the correct result (or else it's a bug), it might need to be refreshed when the event is received however
Yes that appeared to be the bug. I was unaware that there was even the prev and next functions, which did not follow the proper repeat indexes. It should be following it now

Looks good to me thanks a lot for the fix :)


message edits are lost on time conversion

#32 would fix this

closed in the falsely named https://github.com/laralove143/timezoner/commit/5e8f27b402bede87fac6a5f91d65eedb7dce2eec comit


Unable to use it in react with create-react-app

How to add custom plugin to create-react-app ?

Thank you @AlCalzone !
I could build admin with socket-client.

:)

Damn. Still cannot build :(

What's the issue?

What's the issue?

Missing "@babel/plugin-proposal-class-properties". Now it is OK.

Hmm, we should probably change the compilation target to something that doesn't require further transpilation.

Yes. That should be nice, as it will be used not only in admin, but everywhere.

I checked yesterday in the npm package and it already is. The classes in compiled JS files have class methods, but no class properties which your error message suggests. I guess I need to see a repro to figure out what's happening.


Initial Dependency Updates

Closing issues
Closes #[GITHUB_ISSUE_NUMBER]
All PRs should link to a relevant issue. Please add one if it does not exist already.
Description
Describe what problem this PR solves and what changes it makes. Include an explanation of any design decisions you made.
Test Plan
Demonstrate the code works and fixes the problem.
For example, include references to relevant unit tests and/or tutorial scripts, the exact commands you ran and their output, screenshots

@zyteka are you willing to check over what I have done sofar with the unit tests and take a look at the last remaining issue? Do note that I have changed your nbmake pin and updated most of the libraries.

I'll revert to the older formatting tools. Is it possible to further restrict the python version to just 3.10, given the library has not been released yet?


chore(main): release 0.0.0

:robot: I have created a release beep boop
0.0.0 (2024-03-25)
init

Vue 工程初始化 (776a0c1)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/thelastcookies/WEB-BASE/releases/tag/v0.0.0 :sunflower:


Enclose Linux specific code in lightning-app/linux/main.cpp with CHIP…

…_DEVICE_LAYER_TARGET_LINUX
Problem
The lightning-app use code specific to the Linux device layer. It prevent it to be compiled with the darwin specific device layer.
Summary of Changes

Enclose the Linux specific code with CHIP_DEVICE_LAYER_TARGET_LINUX
Fixes #4472

Closing in favour of #4507. Seems cleaner to me.

Closing in favour of #4507. Seems cleaner to me.


Pract.08: Add 01 | Nikolay Radilov

Nikolay Radilov
SI 3 3MI0600253

A solution has already been merged


run run_bert_coqa.py OOM

I have used 3 GPUs to run this program. But it  still comes out an OOM.
ResourceExhaustedError (see above for traceback): OOM when allocating tensor with shape[12,12,512,512] and type float on /job:localhost/replica:0/task:0/device:GPU:0 by allocator GPU_0_bfc          [[node bert/encoder/layer_6/attention/self/Softmax (defined at /data2/wangfuyu/NQ/ycl/SMRCToolkit-master/sogou_mrc/libraries/modeling.py:728)  = Softmax[T=DT_FLOAT, _class=["loc:@bert/encoder/layer_6/attention/self/cond/Switch_1"], _device="/job:localhost/replica:0/task:0/device:GPU:0"](bert/encoder/layer_6/attention/self/add)]] Hint: If you want to see a list of allocated tensors when OOM happens, add report_tensor_allocations_upon_oom to RunOptions for current allocation info.
[[{{node truediv/_771}} = _Recv[client_terminated=false,recv_device="/job:localhost/replica:0/task:0/device:CPU:0",send_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device_incarnation=1,tensor_name="edge_5803_truediv", tensor_type=DT_FLOAT,_device="/job:localhost/replica:0/task:0/device:CPU:0"]()]]

recv_device="/job:localhost/replica:0/task:0/device:CPU:0"
Is it the cause of OOM?

您好，我也遇到了这个问题，请问您最后是如何解决的呢？

把batch_size弄小一点

@yanchlu @bigcat2333 @litao-buptsse @yukyang
I am running the code with 4 GPUs, 10 GB each (batch size 12), still, I am getting OOM error.

把batch_size弄小一点

Hey @yanchlu, did you able to solve the issue?

把batch_size弄小一点
Hey @yanchlu, did you able to solve the issue?

I modified the batch_size, but the results were not satisfactory.

@yanchlu
Thank you for the quick response.


Update Flask to v2

Is your feature request related to a problem? Please describe.
The older version of Flask we're using has security vulnerabilities.  Because mock_uss should be used only in test systems, these vulnerabilities are not high-impact, but we should still follow best security practices when possible.
Describe the solution you'd like
Update Flask to the latest version (2.2.5, as of the creation of this issue).  Note that multiple other dependencies should/must be updated at the same time -- see notes in requirements.txt linking to issues and noting Flask compatibility issues.
Additional context
Dependabot was unable to make this change automatically (see #325).

Note for later: we might want to start pinning all dependencies (incl. transitive ones) using something like pip-tools.
In a nutshell, we'd have our direct (or first-level) dependencies defined in a requirements.in file, and pip-compile it to a requirements.txt file that would contain the exhaustive list of our dependencies.