Linker problem with cuBLAS build in Linux

I ran into problems building on a fresh install of Linux (Ubuntu 18.04) when trying to build with the cuBLAS library. Details are
OS: Ubuntu 18.04
GCC: 7.4.0
cmake: 3.14.3
Boost: 1.65.1
CUDA: 10.1.105-1
Nvidia Driver: 418.39-1
GPU: GTX1080ti
Gpufit: 12496a... Apr 12 16:11:54 2019
I used the following commands to build;
mkdir Gpufit-build
cd Gpufit-build
cmake -DCMAKE_BUILD_TYPE=RELEASE -DUSE_CUBLAS=TRUE ../Gpufit
make

The build failed with the following statements...
../libGpufit.so: undefined reference to 'init_gemm_select'
../libGpufit.so: undefined reference to 'free_gemm_select'
../libGpufit.so: undefined reference to 'cublasLtGetVersion'
../libGpufit.so: undefined reference to 'cublasLtGetProperty'
../libGpufit.so: undefined reference to 'cublasLtCtxInit'
../libGpufit.so: undefined reference to 'cublasLtGetCudartVersion'
../libGpufit.so: undefined reference to 'cublasLtShutdownCtx'

I was able to eventually get around this (and subsequent) problem as follows;
(Note; I do not claim that this is the best way to solve the problem. It is merely what worked for me, and may be of assistance in addressing the actual problem).

After installing cuda toolkit (from .deb package) I had to create symbolic links from the /usr/local/cuda directory to the cuBLAS libraries (for some odd reason with CUDA 10.1, Nvida have put these in a different location /usr/lib/x86_64-linux-gnu). The commands I used were

sudo ln -s /usr/local/cuda/libcublasLt.so /usr/lib/x86_64-linux-gnu/libcublasLt.so
sudo ln -s /usr/local/cuda/libcublasLt.so.10 /usr/lib/x86_64-linux-gnu/libcublasLt.so.10
sudo ln -s /usr/local/cuda/libcublasLt.so<IP_ADDRESS> /usr/lib/x86_64-linux-gnu/libcublasLt.so.<IP_ADDRESS>
sudo ln -s /usr/local/cuda/libcublasLt_static.a /usr/lib/x86_64-linux-gnu/libcublasLt_static.a
sudo ln -s /usr/local/cuda/libcublas.so /usr/lib/x86_64-linux-gnu/libcublas.so
sudo ln -s /usr/local/cuda/libcublas.so.10 /usr/lib/x86_64-linux-gnu/libcublas.so.10
sudo ln -s /usr/local/cuda/libcublas.so<IP_ADDRESS> /usr/lib/x86_64-linux-gnu/libcublas.so.<IP_ADDRESS>
sudo ln -s /usr/local/cuda/libcublas_static.a /usr/lib/x86_64-linux-gnu/libcublas_static.a

To fix the build errors, it was necessary to tell the linker to include the static library libcublasLt_static.a This was achieved by modifying the files
Gpufit repository path/Gpufit/CMakeLists.txt
Gpufit repository path/Gpufit/examples/CMakeLists.txt
Gpufit repository path/Gpufit/Gpufit/examples/CMakeLists.txt
In each file, every instance of the line

target_link_libraries(${target} ${modules})

was replaced with the following line:
target_link_libraries(${target} ${modules} /usr/local/cuda/lib64/libcublasLt_static.a)

The build directory was then erased
cd <Gpufit repository path>/Gpufit-build
rm -rf *

and the cmake command rerun
cmake -DCMAKE_BUILD_TYPE=RELEASE -DUSE_CUBLAS=TRUE ../Gpufit
make

The build then succeeded.
As previously mentioned, I am not very familiar with the cmake machinery, so there may be a much better way to fix this problem than this workaround. Hope it helps anyway.

I had the same problem, I solved it with the following changes to a single CMake file. The  repo path/Gpufit/MakeLists.txt files was edited as follows:

   else()
        set( CUDA_CUBLAS_LIBRARIES
            /usr/lib/x86_64-linux-gnu/libcublas_static.a
            /usr/lib/x86_64-linux-gnu/libcublasLt_static.a
            ${CUDA_TOOLKIT_ROOT_DIR}/lib64/libcudart_static.a
            dl
            pthread
            rt
            #${CUDA_TOOLKIT_ROOT_DIR}/lib64/libcublas_static.a
            ${CUDA_TOOLKIT_ROOT_DIR}/lib64/libculibos.a )
    endif()

I had two problems, the cublas libraries weren't in the CUDA_TOOLKIT_ROOT_DIR, and additional libraries were required. The above edit isn't the most robust, but it worked for my platform. Looking how to make this more robust I found the FIND_CUDA module has been deprecated. So someone should really rewrite the  repo path/Gpufit/MakeLists.txt file to make use of the native CUDA support in CMake >3.10 now.

After more research the native CMake CUDA support doesn't really have as many features as the deprecated FIND_CUDA, which is probably why it isn't being used. I updated the above to the slightly more robust:

            find_cuda_helper_libs(cublas_static)
            find_cuda_helper_libs(cublasLt_static)
            find_cuda_helper_libs(culibos)

            set( CUDA_CUBLAS_LIBRARIES
                ${CUDA_cublas_static_LIBRARY}
                ${CUDA_cublasLt_static_LIBRARY}
                ${CUDA_cudart_static_LIBRARY}
                ${CUDA_culibos_LIBRARY}
                dl
                pthread
                rt )

I checked it and it may depend on the CUDA version. It may require some additional CMake code and testing. I'll come back to it later.


[AutoPR eventhub/resource-manager] EventHub: Revert the NetworkRuleSet

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5363

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/1520


Need some basic help

How to create a new project for cppwinrt? Is there any template on VS 2017 for it?
Can I get my xaml resources by id or name in the cpp code behind? Didn't see any sample for that.
Can I do data binding with the UI component like - with listbox, pivot etc?
Can I consume cpp library without building it with /ZW option?
I want to move my project to cppwinrt from c++/cx? Is it stable enough to create package(bundle) for distribution in offline and store mode?

How to create a new project for cppwinrt? Is there any template on VS 2017 for it?
please check here -->http://www.c-sharpcorner.com/article/learn-universal-windows-programming-via-modern-cpp/
Can I get my xaml resources by id or name in the cpp code behind? Didn't see any sample for that.-> here am now using any xaml design , just start writing the serious of articles , how to use the XAML controls in C++/WinRT
http://www.c-sharpcorner.com/article/learn-universal-windows-programming-via-modern-cpp-dispatchertimer/
Thanks & Regards ,
Vinoth.

How to create a new project for cppwinrt? Is there any template on VS 2017 for it?

Project templates are still under development. The simplest way to start is with one of the sample projects here on GitHub.

Can I get my xaml resources by id or name in the cpp code behind? Didn't see any sample for that.
Can I do data binding with the UI component like - with listbox, pivot etc?

No, we are still working on data binding.

Can I consume cpp library without building it with /ZW option?

Yes.

I want to move my project to cppwinrt from c++/cx? Is it stable enough to create package(bundle) for distribution in offline and store mode?

We are fast closing the gap with C++/CX, but it is ready for app development so do give it a try.

@kennykerr @rvinothrajendran Thanks for the details.

For a Direct3D app model application, you can take a look at the VS templates at directx-vs-templates. It looks like, however, you are looking for a XAML app model template which I don't support.


Feat/corrosive-acid-melting-overhaul

Closes https://github.com/RMC-14/RMC-14/issues/2952.
About the PR

Timer-based object destruction should now on average take the same time as CM13.
Flares now degrade their burning time additionally to being deleted based on timer. Burning time is always smaller then timed deletion, so the only situation where this matters is if flare was thrown without activation, then acidified, then picked up and activated.
Barricades are now damaged over time rather than being deleted based on timer.

Why / Balance
Feature parity with CM13. See https://github.com/RMC-14/RMC-14/issues/2952 for details.

Technical details

Added ServerXenoAcidSystem since shared code does not have access to ExpendableLight coponents.
Added new ServerCorrodingEvent and subscribed system above to that event so that it can manipulate respective component values.
CorrodingComponent was renamed to TimedCorrodingComponent to separate it from DamageableCorrodingComponent.
Added DamageableCorrodingComponent and it's respective handling in SharedXenoAcidSystem, it's capable of working with any entity with damageable component.
Entities with BarricadeComponent are assigned DamageableCorrodingComponent, everything else is assigned TimedCorrodingComponent.
Entities with ExpendableLight component are further processed to reduce burning time additionally to timed destruction.

Media

There is nothing to see really. Visually acidification works as before. Only difference is barricades drop half of their resources now on destruction since destruction process is used rather then outright object deletion. Ans flares stop burning while still being acidified. They are deleted shortly after, once the TimedCorrodingComponent timer runs out.

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

XenoAcidSystem was renamed to SharedXenoAcidSystem.
CorrodingComponent was renamed to TimedCorrodingComponent.

Changelog

:cl:

add: Xeno acid corrosion system was reworked and extended.
add: Flares now lose their burn time rather than disappear after a set amount of time if corroded.
add: Barricades are now damaged over time rather than disappear after a set amount of time if corroded.
tweak: Slightly nerfed acid corrosion times for them to be closer to CM13 values.

[ ] idk how i feel about the damagespecifier being recreated every time the corroding ticks
[ ] the var damageTickSeconds = 10 needs to go into a component, or a cvar, or at least a const field
[ ] same with the "Heat" for the damage
[ ] dont need to look up the damage type prototype every loop
[ ] ok yeah ServerCorrodingEvent can be a readonly record struct with [ByRefEvent] at the top without inheriting EntityEventArgs
dont need the TryComp for the expendable light either since you can access it with target.Comp

I believe this addresses all the notes. Ready for review.


Fix problem with compiling bezier-rs-wasm

Fix issue where npm run serve would occasionally fail with no description.

The watch list for the plugin was not pointing to the correct location

Adjust config files to match that of frontend

Remove jsconfig.json
change configuration in tsconfig.json

Glad you found the problem!


[gimie] github properties beyond codemetapy

Git providers (Gitlab, Github, Codeberg, ...) provide additional useful information with no corresponding codemeta property. Namely:

Where the repository is forked from
How many forks the repository has
How many stars the repository has

Would it make sense to add such properties, for example using schema.org terms. One example that come to mind would be to use schema:isBasedOn for forks:
<downstream-repo> schema:isBasedOn <upstream-repo>

For stars, maybe schema:InteractionStatistic ? But that seems a bit convoluted.
Would love to hear your suggestions @rmfranken

Realized today that github does not correctly notify me when tagged... isBasedOn seems very appropriate for forks indeed. number of forks or stars does not exist as a schema.org property. For stars: https://schema.org/membershipPointsEarned Is pretty close, and it does mention "stars" as one of the potential units. Number of forks is harder. I'll keep searching. :)

Isn't schema:membershipPointsEarned a Person-bound property rather than Project-bound? The description says: The number of membership points earned by the member
Knowing where a project is forked from is probably the most important anyways. Having platform-independent statistics is nice to have, but more superficial. Maybe I can create a separate issue to keep this in mind for later?

Yeah, you are right, I mis-read it. Perhaps we can make our own properties for #forks and #stars, which we define well and attribute to a softwareSourceCode. It would not be a lot of work, but I agree its not as nice as re-using something pre-existing.

I propose to put "is based on" as a separate ticket, and then close this one so we keep our issuelist clean. In the spirit of asking for forgiveness rather than permission I will do so :)


Switch scriptcs for dotnet-script

scriptcs doesn't work because it doesn't support using static nor the Args global.

/cc @filipw

:+1:


Issue selecting icon

When i select a png icon i get an error the icon isnt in png format
Log error
Installing icon...
I :: Open file '"/media/ade/Temp/Temp/build/gameimage.json"' as READ
I :: Open file '"/media/ade/Temp/Temp/build/gameimage.json"' as READ
I :: Open file '"/media/ade/Temp/Temp/build/gameimage.json"' as READ
I :: Open file '"/media/ade/Temp/Temp/build/gameimage.json"' as READ
I :: Reading image from "/media/ade/Temp/ageofempires.png"
I :: Usage: install [--help] [--version] [--remove] [--remote] args
I ::
I :: Install a file to the current project
I ::
I :: Positional arguments:
I ::   args           Install an application into the default directory [nargs: 0 or more] [required]
I ::
I :: Optional arguments:
I ::   -h, --help     shows help message and exits
I ::   -v, --version  prints version information and exits
I ::   --remove       Removes an installed file/dir
I ::   --remote       Install core from remote
I :: Image types aren't compatible.: iostream error
Could not install icon, use .jpg or .png

Hi @Blad3forc3 , I get these issues with fake png files sometimes, can you try to do convert my-image.png my-new-image.png to see if that makes it work? The convert command is part of the imagemagick suite, you can also use gimp or other software to export the imported image as a new png.

Ok attached the zip file
ageofempires.zip

@Blad3forc3 thanks a lot for the help on this. It should be fixed on patch 1.0.2. I have also fixed the alpha channel missing on the input png images, some tips:
If you want the result to be something like this:

On gimp, go to image -> resize canvas. Set the canvas size to 600x900 and click on center.

On the desktop icon selection screen, select the original icon.

Ok thanks Ruan that seems to have worked. You can close this


Angular Simple App

Angular Simple App

This is not a valid PR for the material-start tutorial branch.


sachinsom93/GOSW17

Issue Number
ISSUE #39

Describe the changes you've made
enhanced eventform to connect it to firestore.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
A clear and concise description of it.
Additional context (OPTIONAL)
Add any other context or screenshots about the feature request here.
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
How someone can test your code?
Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

@sachinsom93 Config is done already, you can directly initialize firestore(). Other things are correct, change these things.

@sachinsom93 Config is done already, you can directly initialize firestore(). Other things are correct, change these things.

Ok

@nanda-mik , I have done the changes, kindly review it again.


CLI: Better subcommand structure

I'm testing the latest version, and it's increasingly more obvious to me that we'll need to restructure the CLI. Currently it's confusing, and likely not permanent.
Specifically, we need a good structure of well separated subcommands. Also, might be useful to have a special MS-specicific file suffix, eg. .msfa.
The use should be more simple, eg:
kmercamel ms -k 31 genome.fa > genome.msfa
kmercamel optimize genome.msfa > genome_maskopt.msfa
kmercamel reformat -m mask.txt -s superstring.txt genome_maskopt.msfa
kmercamel reformat -P mask.txt -S superstring.txt > glued.msfa

Notes:

-c should be on by default; in fact there're 3 possible modes of work: canonical kmers, forward kmers, reverse kmers
for optimization, -k should be parsed automatically from the superstring (by default) and this extraction should appear in a well visible message (e.g.,"KMER SIZE EXTRACTED: 31")

What do you think @OndrejSladky @PavelVesely ?

Ok, immediately even after writing this ticket, I completely forgot the -c param to the command I was running, which likely made the computation much slower. This really needs to be fixed :) (I guess ~90% users forgets this as well.)

We actually discussed this at the prev meeting. This was the issue: while for max 1 it's simple, there're many things that can go wrong for min int, and there's risk the whole MS computation can be lost due to an error in the final optimization part.

Maybe a solution could be, once we have the MS command, to implement default / greedy zero / max ones as a param, and allow min int only in the reoptimalizaton subcommand?


Label nodes with infra role and prepare for inlining operator install…

…ation in OpenShift CI
Signed-off-by: Nico Schieder<EMAIL_ADDRESS>

/lgtm

/lgtm


PHP compatibility of LTS version

Affected Symphony version(s) : LTS
The current Symphony version is an "LTS" (Long Term Support) version. However, PHP compatibility is limited to PHP 7.1. Active support for PHP 7.1 has already ended, and security support will end on December 1st, nine months from now (see http://php.net/supported-versions.php). How bad.
My suggestion is to release a 2.8.0 LTS version and mark it compatible with PHP 7.3.
I already run one of my smaller web apps on PHP 7.3, and the changes required were not too difficult. I will also make my — legendary — "big system" run on PHP 7.3, and of course I am willing to share any findings and fixes.
Until now I discovered only two significant issues with PHP 7.3. (BTW, here is a nice overwview of the changes: https://ayesh.me/Upgrade-PHP-7.3.)

PHP's migration from PCRE to PCRE2 library requires to change some Regex expressions in the Symphony core. It's no big deal (and even backwards compatible).

The introduction of a JsonException class in PHP requires to rename Symphony's JSONException class in order to prevent a name clash. In pure theory renaming the class is a breaking change, but I really wouldn't care in this case — who would ever use this exception except the JSON class itself?

I can send corresponding PRs, and I suggest to open a 2.8.x branch for this.

While LTS ends soon, I do not oppose it.  Please submit both PR on 2.7.x for now.

@michael-e What about doing if class_exists('JSONException') before we declare the custom implementation ? Both should work (albeit they won't have the same error messages).

I wouldn't oppose this solution either, but I prefer to rename the Symphony class. e.g. to SymJSONException. This, at least theoretically, allows custom error handling in Symphony.

OK, done. Please take a look and comment.
All my systems are on PHP 7.3 now, so chances are that I will notice any hickups if they still occur. :-)


I'm getting this error upon runing the script:   "imagemin": "imagemin img/* --out-dir='dist/img'",

npm run imagemin

<EMAIL_ADDRESS>imagemin E:\Full Stack Using React\FrontEnd-UI-FrameWorks\Week 1\Exersises\Bootstrap4\conFusion
imagemin img/* --out-dir='dist/img'

'imagemin' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>imagemin: imagemin img/* --out-dir='dist/img'
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>imagemin script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\Admin\AppData\Roaming\npm-cache_logs\2020-05-19T02_43_29_876Z-debug.log

same here bro


Error while running MQTT-SN in Contiki

Hi @aignacio
I have tried to run the MQTT-sn in Contiki. Everything works fine for me except rsmb broker.
following is the command and error that prompt.
user@instant-contiki:~/contiki/mqtt-sn-contiki/tools/mosquitto.rsmb/rsmb/src$ sudo ./broker_mqtts config.mqtt
./broker_mqtts: 1: ./broker_mqtts: Syntax error: "(" unexpected
I have also gone through the broker.c file but there is not initial bracket for that.
Regards,
Vishal

The problem is that you're trying to run the broker in a machine that x86 (32-bits arch) and the source code of the broker was compiled to a x64. Pls check the first warning in the blog post about it again =)

Hello sir,
I am able to resolve the error. I have downloaded the new RSMB broker from the git repository and set the config as per your config file and then after it is running.
But now, I am getting the following message when I run the broker with the config file.
user@instant-contiki:~/contiki/mqtt-sn-contiki/tools/mosquitto.rsmb/rsmb/src$ sudo ./broker_mqtts config.mqtt
20200321 151708.743 CWNAN9999I Really Small Message Broker
20200321 151708.743 CWNAN9998I Part of Project Mosquitto in Eclipse
(http://projects.eclipse.org/projects/technology.mosquitto)
20200321 151708.743 CWNAN0049I Configuration file name is config.mqtt
20200321 151708.743 CWNAN0053I Version <IP_ADDRESS>, Mar 21 2020 15:13:26
20200321 151708.746 CWNAN0054I Features included: bridge MQTTS
20200321 151708.746 CWNAN9993I Authors: Ian Craggs (icraggs@uk.ibm.com), Nicholas O'Leary
20200321 151708.747 CWNAN0075W Socket error 98 (Address already in use) in a bind for socket 3
20200321 151708.747 CWNAN0078W Cannot bind port 1883
20200321 151708.747 CWNAN0015W Cannot start listener on port 1883
20200321 151708.747 CWNAN0016I MQTT protocol stopping
20200321 151708.747 CWNAN0301I MQTT-S protocol stopping
20200321 151708.747 CWNAN0075W Socket error 88 (Socket operation on non-socket) in shutdown for socket 0
20200321 151708.747 CWNAN0044I Messages sent: 0
20200321 151708.747 CWNAN0043I Messages received: 0
20200321 151708.747 CWNAN0042I Uptime: 0 seconds
20200321 151708.747 CWNAN0055I Maximum heap use: 129104 bytes
20200321 151708.747 CWNAN0047I Broker stopped

The problem is that you're trying to run the broker in a machine that x86 (32-bits arch) and the source code of the broker was compiled to a x64. Pls check the first warning in the blog post about it again =)

Thank sir.
I will try to run it in the local machine instead of VM.

Hi @aignacio
I am able to run it on my local machine.
I have one more question. Do you have any idea about running MQTT in Contiki? I have tried different things but didn't work for me.

Hi @vishal623,
it has been a long time since I worked with contiki, when I used they still didn't have changed to contiki-ng. I remember when I tried to use MQTT (tcp ofc) was extremely slow and heavy in terms of processing for my embedded targets so that's why I gave up and write my own mqtt-sn lib, to be fully honest I don't work anymore with contiki, neither mqtt/sn nowadays, so it's hard to me to guide you anyway, I'd suggest you go over contiki-ng repo and ask directly there.

Thanks sir.


A BUG about the setRotation method in the Matrix4 Class lacks the result parameter

The underlying implementation requires the parameter, but the externally exposed method lacks this variable, which is not passed in when it is used, resulting in bugs!

To avoid this bug, I passed this parameter when using it, but an error will be prompted in ts.

In ts.

So I added this parameter to the source code.

It's OK!

Therefore, Cesium maintenance personnel may also need to add this parameter.

Thanks for the report @ShenTiger!
This can be fixed by adding the result parameter to the jsdoc comment. That will ensure it is included in the generated TypeScript definitions.

hello shentiger
i am a beginner in open source world
can you please tell me exact location of code in files .
so that i can work on that

@gaurav8y785675474 That would be at https://github.com/CesiumGS/cesium/blob/main/packages/engine/Source/Core/Matrix4.js

@ggetz I think that this was fixed with https://github.com/CesiumGS/cesium/pull/10954 and could be closed.

Thanks @javagl!


add bahasa Indonesia strings

this is for Indonesian language support

@googlebot I signed it!

duplicate with #555

Hi,
Thanks for your contribution, however Sunflower is going to be archived in favour of maintaining a smaller set of up-to-date set of compose-samples, that can be found here: https://github.com/android/compose-samples, as well as snippets that can be found here: https://github.com/android/snippets.
Please feel free to keep your fork up-to-date for your learning, but this repository will be archived shortly.


Add command for converting various Byron keys to their Shelley counterpart

Add support for converting:

payment keys
genesis keys
genesis delegate keys

Support either verification or signing keys.
Support current or legacy (ie SL) formats.
Also add special conversion for Byron genesis verification keys in base64,
as they appear in the Byron genesis file as issuerPK.

bors merge

I can't approve since I originally opened this PR, but LGTM :100:


Cannot find compilation library location for package 'Microsoft.AspNet.WebApi.Client'

InvalidOperationException: Cannot find compilation library location for package 'Microsoft.AspNet.WebApi.Client'
I have uploaded .NET core 2.1 website on AWS .
Installed framework 4.7 and Dot net core framework 2.2 from https://dotnet.microsoft.com/download
Website URL : http://ec2-13-127-52-63.ap-south-1.compute.amazonaws.com/login
not able to found why it is giving error for the package
Regards,
Jigar

@jigarce I notice you closed this - did you find out what the problem was? I’m experiencing the same problem right now...

Yes,
It was website publish issue.
Select Deployment Mode : Self-Contained

Great advice, worked for me too.
Thanks

On 14 Mar 2019, at 07:16, Jigar<EMAIL_ADDRESS>wrote:
Yes,
It was website publish issue.
Select Deployment Mode : Self-Contained
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


WIP: Implement ABCI++

This PR implements the API changes for ABCI++.

[x] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[x] Updated all code comments where relevant
[ ] Wrote tests
[ ] Updated CHANGELOG.md

Hey, sorry for the delay in getting to this.  I think the thing that makes the most sense to do is to:

Get https://github.com/informalsystems/tendermint-rs/pull/862 merged upstream into tendermint-rs;
Apply these changes on top of those, so that the ABCI interface for current Tendermint isn't blocked on ABCI++.

There's been a bit of a delay getting the PR upstream because of some people being offline, but I talked with @thanethomson today about getting it merged, so hopefully I'll be able to get some movement on it soon.


fix: close sockets when they're stale instead of just killing the proxy

Summary of changes
Asana Ticket: 🚲 close stale sockets properly
Closes the socket when it's stale instead of just killing the proxy. This ensures that FIN is sent to the client (OCS).
Reviewer Checklist

[ ] Any new or changed functions have typespecs
[ ] Tests were added for any new functionality (don't just rely on Lcov)
[ ] Meets ticket's acceptance criteria

Oh also the Erlang version change is unnecessary, I just can't build 25.2.1 on my machine and didn't feel like fixing it today. Will pull that out before merge.


Suggestion: Add ability to ignore charter ships

The ability to use or ignore boats is great, but I would like to be able to have the paths consider using regular boats while ignoring the significantly overpriced charter ships.

Looks like this is already in the works according to #28, closing as duplicate.


ValueError: Could not parse LLM output:  on 'chat-conversational-react-description'

Error with the AgentOutputParser() when I follow the notebook "Conversation Agent (for Chat Models)"
`> Entering new AgentExecutor chain...
Traceback (most recent call last):
File "/Users/wzy/opt/anaconda3/envs/py3.8/lib/python3.8/site-packages/langchain/agents/conversational_chat/base.py", line 106, in _extract_tool_and_input
response = self.output_parser.parse(llm_output)
File "/Users/wzy/opt/anaconda3/envs/py3.8/lib/python3.8/site-packages/langchain/agents/conversational_chat/base.py", line 51, in parse
response = json.loads(cleaned_output)
File "/Users/wzy/opt/anaconda3/envs/py3.8/lib/python3.8/json/init.py", line 357, in loads
return _default_decoder.decode(s)
File "/Users/wzy/opt/anaconda3/envs/py3.8/lib/python3.8/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/Users/wzy/opt/anaconda3/envs/py3.8/lib/python3.8/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "demo0_0_4.py", line 119, in
sys.stdout.write(agent_executor(query)['output'])
File "/Users/wzy/opt/anaconda3/envs/py3.8/lib/python3.8/site-packages/langchain/chains/base.py", line 116, in call
raise e
File "/Users/wzy/opt/anaconda3/envs/py3.8/lib/python3.8/site-packages/langchain/chains/base.py", line 113, in call
outputs = self._call(inputs)
File "/Users/wzy/opt/anaconda3/envs/py3.8/lib/python3.8/site-packages/langchain/agents/agent.py", line 637, in _call
next_step_output = self._take_next_step(
File "/Users/wzy/opt/anaconda3/envs/py3.8/lib/python3.8/site-packages/langchain/agents/agent.py", line 553, in _take_next_step
output = self.agent.plan(intermediate_steps, **inputs)
File "/Users/wzy/opt/anaconda3/envs/py3.8/lib/python3.8/site-packages/langchain/agents/agent.py", line 286, in plan
action = self._get_next_action(full_inputs)
File "/Users/wzy/opt/anaconda3/envs/py3.8/lib/python3.8/site-packages/langchain/agents/agent.py", line 248, in _get_next_action
parsed_output = self._extract_tool_and_input(full_output)
File "/Users/wzy/opt/anaconda3/envs/py3.8/lib/python3.8/site-packages/langchain/agents/conversational_chat/base.py", line 109, in _extract_tool_and_input
raise ValueError(f"Could not parse LLM output: {llm_output}")
ValueError: Could not parse LLM output: , wo xiang zhao yi ge hao de zhongwen yuyan xuexiao`

Same problem here.
In the documentation doesn't appear anything about the format of the json expected when using CHAT_CONVERSATIONAL_REACT_DESCRIPTION or at least is not obvious where to find it.
Any clues?


RFC: Media Use Cases in Amplify

This is a Request For Comments (RFC). RFCs are intended to elicit feedback regarding a proposed change to the Amplify Framework. Please feel free to post comments or questions here.
This RFC is to gather customer feedback for a new proposed functionality in Amplify related to media use cases. Please find the details here https://github.com/aws-amplify/amplify-cli/issues/6896 and let us know which use cases or features you'd like to see in Amplify by providing your feedback here

we'd like to see the current 145 issues resolved first instead of adding more bugs...

Should this be converted to discussion?


Comments by '@çokkomik' persist after channel is deleted

I made comments a long time ago using two separate channels:
(1) @çokkomik
(2) @blah
I deleted both channels today and expected both comments to be gone.  The second one is gone, but the first one persists despite the channel being fully deleted.  I wonder if the ç is causing problems.

The comments are stored in a comment database and it has no idea the channels were deleted. We'd need to clean them up there.
Eventually this will be on the protocol so it should be more natively supported.

Actually, we resolve the channels to get the thumbnails / other data, so we can handle it then. Maybe take a look at this as part of the lazy loading you said you'd look at.

Close

No longer reproducible.


Remove pane index assertion

See also: #172

Current coverage is 83.28% (diff: 100%)

Merging #181 into master will decrease coverage by 0.02%

@@             master       #181   diff @@
==========================================
  Files             5          5
  Lines           743        742     -1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            619        618     -1
  Misses          124        124
  Partials          0          0

Powered by Codecov. Last update 5543593...5e244cd


Unable to upgrade from 0.8.4 - Exit code 243

Using the "Upgrade" button in Settings -> System throws the message: -
"Upgrade done (if it was available) with code 243."
...with no indication of any package changes.
Steps to reproduce the behavior:

Go to Settings -> System
Click on 'Upgrade'
When done the screen reads: -

"Starting upgrade, please wait...
Upgrade done (if it was available) with code 243.
Press the BACK button in your browser, then RELOAD the page."

On returning to the System tab, there are no changes.

The expected output is a summary of the upgrade, even if there are no changes, and the 243 exit code is new.
I did attempt to upgrade from the cli, with "npm install -g @saltcorn/cli@latest --unsafe", which seems to run as normal with lots of deprecation warnings and some updates reported "changed 1594 packages, and audited 1595 packages in 13s", but again the system does not upgrade.
Googling the error message suggests that other folks using node have worked around this by upgrading. This system is on Node.js 16.20.0  - that still seems to be the recommended version in the docs.
Would it be risky to upgrade node.js? Is there a later recommended version?
N.B. I've posted this as a bug because I don't think I've done anything exotic, but for completeness I should mention that the saltcorn user had a disk quota issue at one point.

Could it be that the installation from the cli lands in another directory? Can you run 'npm list -g' and compare the version number (@saltcorn/cli@[version]) with the one you see on the web interface?

@christianhugoch - thanks for the pointer, you were absolutely right. I had 2 x Saltcorn instances on the same server under different users, and they were "cross wired" in the service setup such that the root cause was likely a permission issue. I don't think that I could do that again if I tried!
Closing, absolutely not a bug!


windowrules: add 'solo' rule

Describe your PR, what does it fix/add?
This adds a new window rule which matches a window if and only if it is the only non-floating window visible. Alternatively, it matches the window only if it is the 'root' of the layout tree.
See https://github.com/hyprwm/Hyprland/issues/2324
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
This is not necessarily the most elegant way of handling this condition. Perhaps it would be better to allow directly querying the number of floating / non-floating windows on the workspace, for example. That would allow encoding this rule with 'fullscreen:1andonworkspacenonfloating:1` (as two separate window rules).
But, I can't think of a good name for the "on workspace but non floating" rule. Maybe it would be better to instead generalize this substantially, so we could encode conditions in a more flexible way. But that is probably out-of-scope for this change.
Is it ready for merging, or does it need work?
Tested and working but see above.

can't you just do windowrulev2 = [rule], onworkspace:1, floating:0?

can't you just do windowrulev2 = [rule], onworkspace:1, floating:0?

Consider the situation of there being one non-floating and one floating window on the same workspace. Your condition would be false for both, but the condition I want would be true for the non-floating window, as it is the only non-floating window.
The motivating use-case here is that I want to remove borders around windows when there is no reason to draw them, which is the case whenever a window effectively covers the whole screen - either because it is fullscreened, or because it is the only non-floating window.

I'd rather expand the onworkspace to support tiled and floating.

I'd rather expand the onworkspace to support tiled and floating.

Do we have a precedent for syntax? onworkspace.tiled:1, onworkspace:tiled:1?

1 tiled, 2 floating, 2 floating 1 tiled sounds reasonable

@haasn Does the workspace selector with onworkspace window rule work for you?
I'm currently using this.
# When only 1 tiled window is visible
windowrulev2 = noborder, onworkspace:w[tv1] f[-1], floating:0
windowrulev2 = rounding 0, onworkspace:w[tv1] f[-1], floating:0
workspace = w[tv1], gapsout:0

# When only 1 tiled window is visible (maximized)
windowrulev2 = noborder, fullscreen:1
windowrulev2 = rounding 0, fullscreen:1
workspace = f[1], gapsout:0

windowrulev2 = noborder, onworkspace:w[tv1] f[-1], floating:0

windowrulev2 = noborder, onworkspace:w[tv1] f[-1], floating:0
This works thanks!

windowrulev2 = noborder, onworkspace:w[tv1] f[-1], floating:0

This works thanks!

@haasn Does the workspace selector with onworkspace window rule work for you?
I'm currently using this.
# When only 1 tiled window is visible
windowrulev2 = noborder, onworkspace:w[tv1] f[-1], floating:0
windowrulev2 = rounding 0, onworkspace:w[tv1] f[-1], floating:0
workspace = w[tv1], gapsout:0

# When only 1 tiled window is visible (maximized)
windowrulev2 = noborder, fullscreen:1
windowrulev2 = rounding 0, fullscreen:1
workspace = f[1], gapsout:0

@haasn Does the workspace selector with onworkspace window rule work for you?
I'm currently using this.
# When only 1 tiled window is visible
windowrulev2 = noborder, onworkspace:w[tv1] f[-1], floating:0
windowrulev2 = rounding 0, onworkspace:w[tv1] f[-1], floating:0
workspace = w[tv1], gapsout:0

# When only 1 tiled window is visible (maximized)
windowrulev2 = noborder, fullscreen:1
windowrulev2 = rounding 0, fullscreen:1
workspace = f[1], gapsout:0

@haasn Does the workspace selector with onworkspace window rule work for you?
I'm currently using this.
# When only 1 tiled window is visible
windowrulev2 = noborder, onworkspace:w[tv1] f[-1], floating:0
windowrulev2 = rounding 0, onworkspace:w[tv1] f[-1], floating:0
workspace = w[tv1], gapsout:0

# When only 1 tiled window is visible (maximized)
windowrulev2 = noborder, fullscreen:1
windowrulev2 = rounding 0, fullscreen:1
workspace = f[1], gapsout:0

windowrulev2 = noborder, onworkspace:w[tv1] f[-1], floating:0

This works thanks!

@haasn Does the workspace selector with onworkspace window rule work for you?
I'm currently using this.
# When only 1 tiled window is visible
windowrulev2 = noborder, onworkspace:w[tv1] f[-1], floating:0
windowrulev2 = rounding 0, onworkspace:w[tv1] f[-1], floating:0
workspace = w[tv1], gapsout:0

# When only 1 tiled window is visible (maximized)
windowrulev2 = noborder, fullscreen:1
windowrulev2 = rounding 0, fullscreen:1
workspace = f[1], gapsout:0

windowrulev2 = noborder, onworkspace:w[tv1] f[-1], floating:0

This works thanks!

Perfect, then this isn't needed


Scripting documentation mentions Desktop Version and loading a script from File

Hi,
Looking into the scripting documentation I've noticed that it mentions:
You can test a script in the desktop version by selecting "Run Script" from the File menu.
I'm not entirely sure what this is referring to. Should it be removed?

Should be fixed now, thanks.  Those were a few lingering references from the original IE plugin which was a desktop app.


Dreamcast: Improve MIL-CD Piracy Explanation(?)

It feels like that section could go a lot further in depth then it does currently about the protection that the Dreamcast uses on MIL-CDs that was intended to stop piracy using the format. I found a small write up here with more info that could be pulled from, and then linked as further reading: https://fabiensanglard.net/dreamcast_hacking/
I know the wiki article on dcemulation that is linked in the article also goes through the same steps... Perhaps it doesn't need to go further in depth but this article could be linked to in the Sources/Keep Reading section?

The article linked states at the end that it requires corrections due to feedback received from experts (https://fabiensanglard.net/dreamcast_hacking/corrections/corrections.pdf). If I understood correctly to this day the article hasn't been corrected, so I'm not sure how reliable it's right now.
In any case, a year ago I asked dreamcast homebrew experts at the Simulant discord and feedback was positive, so all good for now. Also I try not to duplicate information already stated in the wiki.

Ah, I hadn't seen the corrections page there. Fair enough on not adding it in that case.
I'll close this PR.


Developer Documentation

Hi,
I have recently looked into the source code. It's a bit... big and to be honest, I'm pretty clueless.
Is there a developer documentation somewhere? Maybe I missed it. I looked in Wiki section but it isn't there. If not, I'd love to help. (And probably need some helps to get starting as well). The documentation may include these sections: What modules and components are there? What are their uses? What are the controls? At least we can get some starting points or an overview look of the whole project.

just read the source code

@laiqun Hey man, of course, I know how to read. And the contributors made a really great job keeping the project readable. But I'm talking about the possibility to have a unified documentation where we can levitate newcomers' experiences.

@laiqun You are not being helpful.
@nguyenlamlll

Is there a developer documentation somewhere?

No, there's no documentation. :/

I looked in Wiki section but it isn't there.

Yeah, the wiki contains only a guide for translators and users (this one is imcomplete).

If not, I'd love to help. (And probably need some helps to get starting as well)

That would be awesome! I'll explain everything that you need to know.

After reading the source code of Author,I write some note, but only cover some part of source code.
If you like to reading it ,I will upload it for help you .

@NickeManarin What format would you like and where should they be hosted? Wiki pages on Github are not so great in my opinion. One should be invited as a contributor to edit the pages, right? Or can we update the docs on the website repository?

For a developer documentation, it would be better to stay here, on GitHub (because the code is located in here).

So a folder /Docs at the root with markdown files inside. Sounds good?
Do you use any other chat tools? I think I can start working on it now and well, gonna have quite a few of quick questions.

So a folder /Docs at the root with markdown files inside. Sounds good?
Yes :)

Do you use any other chat tools?
Yes: Email, Discord, Twitter, Gitter.

http://www.screentogif.com/contact.html


where "remote.ip_list" this value is populating?

I want to know from where this variable is getting populated .Can you please help me?

I found out this and closing the issue.


Release on pypi

Great job!
But have you deleted this from pip distribution? Or maybe some other reason?
Cheer up!
Thanks!

Hi @demostars this project never was on pypi. I use it locally and didn't expect anyone else would use it. I can make an alpha release though. The simple operations are stable. I use it in production for backup but the pcloud API is not completly implemented.

Well thanks！

Done https://pypi.python.org/pypi/pcloud/1.0a2


get note API

LIT

receive a request with noteId
return the note requested

LIT app

request with a noteId
receive a response from LIT
show the note in main section

finished!
12a194dc68975e03f28345bab83c755b12d2490a
797a646bf7f8ce1a120c4eff011f2967e243bd48
bf7feaf5cea484dd665210b56affe044f879a860
c14a011f3ff8a298fefd8b2b48172ae7fb6903f1
2079ca3cec69edc2b1c4a7502e0f4ec325319f10


Support partial TCRdist calculation with incomplete information

Currently the TCRdist calculation on e.g. CDR3A will fail when no TRAV gene is in the dataframe. It would be preferable if each function worked with only its required input.

Yes, it is possible using internal functions. Take a look in the find_neighbors_tcrdist function in nn.py for an example


how to implement ion-searchbar filter item with AfoListObservable ?

I am trying to implement ion-searchbar with a filter over AfoListObservable which prompting below compile time error.
[ts]
Type 'Observable<any[]>' is not assignable to type 'AfoListObservable<any[]>'.
Property 'internalListObservable' is missing in type 'Observable<any[]>'.
appreciated for your input.

Hi @m-saifuddin it doesn't sound like this is related to this repo. I would create a question at StackOverflow.


make amp-ad samples preview in cache

This fixes also the validation errors in the amp-ad preview.

@kul3r4 PTAL


Some versions have not title on project home page

Details

Project URL: https://readthedocs.org/projects/aiohttp/

Expected Result
At the project home page on RTD it's supposed to see all the versions built.
Actual Result
For some reason, some versions appeared listed but without a name on them:

Duplicated of #3187


Installing extensions from v6.2.5 in v6.3.0 fails

Describe the bug
I'm looking to restore missing functionality to v6.3.0 by installing extensions that were removed from this repo.
When I check out v6.2.5 and build extensions/pod-menu/lens-pod-menu-6.1.0.tgz, I'm unable to install the extension in OpenLens v6.3.0 built from this repo. After selecting the tarball and clicking "Install", the install button animation spins forever, and the extension doesn't get installed.
To Reproduce

Build and install Lens v6.3.0 from this repo.
Check out the v6.2.5 tag in this repo.
Build the pod-menu extension, creating a extensions/pod-menu/lens-pod-menu-6.1.0.tgz file:

cd extensions/pod-menu
npm run build

Open Lens v6.3.0.
Press ctrl+shift+E to open the Extensions screen.
Click the folder icon in the "NAME OR FILE PATH OR URL TO AN EXTENSION PACKAGE" box and select the tarball you built in step 3 to install the extension.
Observe that the "Install" button animates forever, seems stuck, and nothing further happens.

Expected behavior
I expected the pod-menu extension to be installed.
Screenshots

Environment (please complete the following information):

Lens Version: 6.3.0
OS: Ubuntu 20.04
Installation method (e.g. snap or AppImage in Linux): .deb package, built from source (like MuhammedKalkan/OpenLens)

Logs:
Here are the developer tools console logs when trying to install the extension immediately after startup:
[LENS-EXTENSIONS]: LOADING ...
BrowserConsole.js:41 [LENS-EXTENSIONS]: LOADED from /home/timk/.config/OpenLens/lens-extensions.json
BrowserConsole.js:41 [LENS-FILESYSTEM-PROVISIONER-STORE]: LOADING ...
BrowserConsole.js:41 [LENS-FILESYSTEM-PROVISIONER-STORE]: LOADED from /home/timk/.config/OpenLens/lens-filesystem-provisioner-store.json
BrowserConsole.js:41 [LENS-USER-STORE]: LOADING ...
BrowserConsole.js:41 [LENS-USER-STORE]: LOADED from /home/timk/.config/OpenLens/lens-user-store.json
BrowserConsole.js:41 [LENS-CLUSTER-STORE]: LOADING ...
BrowserConsole.js:41 [LENS-CLUSTER-STORE]: LOADED from /home/timk/.config/OpenLens/lens-cluster-store.json
BrowserConsole.js:41 [LENS-HOTBAR-STORE]: LOADING ...
BrowserConsole.js:41 [LENS-HOTBAR-STORE]: LOADED from /home/timk/.config/OpenLens/lens-hotbar-store.json
BrowserConsole.js:41 [EXTENSIONS-LOADER]: auto initializing extensions
BrowserConsole.js:41 [PROTOCOL ROUTER]: internal registering /preferences
BrowserConsole.js:41 [PROTOCOL ROUTER]: internal registering /
BrowserConsole.js:41 [PROTOCOL ROUTER]: internal registering /landing
BrowserConsole.js:41 [PROTOCOL ROUTER]: internal registering /landing/view/:group/:kind
BrowserConsole.js:41 [PROTOCOL ROUTER]: internal registering /cluster
BrowserConsole.js:41 [PROTOCOL ROUTER]: internal registering /entity/:entityId/settings
BrowserConsole.js:41 [PROTOCOL ROUTER]: internal registering /cluster/:clusterId
BrowserConsole.js:41 [PROTOCOL ROUTER]: internal registering /cluster/:clusterId/settings
BrowserConsole.js:41 [PROTOCOL ROUTER]: internal registering /extensions
BrowserConsole.js:41 [PROTOCOL ROUTER]: internal registering /extensions/install/:LENS_INTERNAL_EXTENSION_PUBLISHER_MATCH(@[A-Za-z0-9_]+)?/:LENS_INTERNAL_EXTENSION_NAME_MATCH
BrowserConsole.js:41 [STORAGE-HELPER]: loading finished for /home/timk/.config/OpenLens/lens-local-storage/app.json
BrowserConsole.js:47 Unpacking extension<EMAIL_ADDRESS>{fileName: 'lens-pod-menu-6.1.0.tgz', tempFile: '/tmp/lens-extensions/lens-pod-menu-6.1.0.tgz'}
fileName: "lens-pod-menu-6.1.0.tgz"
tempFile: "/tmp/lens-extensions/lens-pod-menu-6.1.0.tgz"
[[Prototype]]: Object

And here are the relevant logs from ~/.config/OpenLens/logs/lens.log:
info: [CREATE-ELECTRON-WINDOW]: Loading content for window "splash" from file: /opt/OpenLens/resources/app.asar/static/splash.html...
info: [CREATE-ELECTRON-WINDOW]: Window "splash" loaded
info: [LENS-EXTENSIONS]: LOADING ...
info: [LENS-EXTENSIONS]: LOADED from /home/MyUser/.config/OpenLens/lens-extensions.json
info: [LENS-WEBLINK-STORE]: LOADING ...
info: [LENS-WEBLINK-STORE]: LOADED from /home/MyUser/.config/OpenLens/lens-weblink-store.json
info: 📟 Setting protocol client for lens://
info: 📟 Protocol client register failed ❗
debug: [APP-MAIN] initializing ipc main handlers
info: 🧩 Initializing extensions
info: [LENS-FILESYSTEM-PROVISIONER-STORE]: LOADING ...
info: [LENS-FILESYSTEM-PROVISIONER-STORE]: LOADED from /home/MyUser/.config/OpenLens/lens-filesystem-provisioner-store.json
info: 🐚 Syncing shell environment
info: [UNIX-SHELL-ENV]: running against /bin/bash {"command":" '/opt/OpenLens/open-lens' -p '\"65b3f57254eb4c25a85d609f7b563af4\" + JSON.str
ingify(process.env) + \"65b3f57254eb4c25a85d609f7b563af4\"'","shellArgs":["-l","-i"]}
info: [EXTENSIONS-LOADER]: auto initializing extensions
info: [LENS-HOTBAR-STORE]: LOADING ...
info: [LENS-HOTBAR-STORE]: LOADED from /home/MyUser/.config/OpenLens/lens-hotbar-store.json
info: [EXTENSION-DISCOVERY] loading extensions from /home/MyUser/.config/OpenLens
error: [EXTENSION-DISCOVERY]: can't load extension manifest at /home/MyUser/.k8slens/extensions/lens-pod-menu/package.json: TypeError: Cannot
read properties of undefined (reading 'lens')
debug: [EXTENSION-DISCOVERY]: 0 extensions loaded {"extensions":[],"folderPath":"/home/MyUser/.k8slens/extensions"}
info: [EXTENSION-DISCOVERY] watching extension add/remove in /home/MyUser/.k8slens/extensions

Here's the package.json file it's failing to load for the pod-menu extension (before building the extension, I modified its package.json to refer to the npm-hosted version of @k8slens/extensions instead of the relative file path, but neither reference made a difference):
{
  "name": "lens-pod-menu",
  "version": "6.1.0",
  "description": "Lens pod menu",
  "renderer": "dist/renderer.js",
  "lens": {
    "metadata": {},
    "styles": []
  },
  "scripts": {
    "build": "npx webpack && npm pack",
    "dev": "npx webpack -- --watch",
    "test": "npx jest --passWithNoTests --env=jsdom src $@"
  },
  "files": [
    "dist/**/*"
  ],
  "dependencies": {
    "@k8slens/extensions": "^6.3.0"
  }
}

Other Questions

What's the right way to install these extensions?

"everyone can still install those extensions manually to OpenLens if they desire to do so." --maintainer comment

Have the extensions been published somewhere else?
Do the extensions require updates to work with v6.3.0?

The extensions, as provided in 6.2.6, need some adjustments to work in the new OpenLens. I've published a working copy at https://github.com/alebcay/openlens-extensions for now.
See also ongoing discussion at https://github.com/MuhammedKalkan/OpenLens/issues/83 about community efforts on maintaining these extensions moving forward.


Support Mac version 12.1

Currently, I get an error while starting app:

Please support it. Thank you

I've set the minimum version to 12.4 out of caution because there may be virtualization bugs in older versions that affect OrbStack. Is there any reason you can't upgrade?

It looks like macOS 12.3 is the oldest version that doesn't have major virtualization bugs, so I've changed the minimum to 12.3. There are severe performance issues on Intel <=12.2 and VirtioFS bugs on <=12.1. We don't want people to have a bad experience with OrbStack due to old macOS bugs that were fixed over a year ago.

Thank you for your support. I try to upgrade version of my macos

12.3 support released in v0.6.1.


filling a bucket with lunar water from a cauldron does not work correctly

having a cauldron full of lunar water and attempting to scoop it into a bucket will void the fluid entirely.
from what it looks like, the issue stems from the item not changing from minecraft:bucket to forge:bucketfilled, as the nbt on the bucket is changed to what the nbt on forge:bucketfilled would need to be to create a bucket of lunar water.
steps to reproduce:

fill a cauldron with water, and transform it into lunar water
attempt to pick up the lunar water in a bucket and not a bottle
fluid will be voided, as it disappears from the cauldron and does not fill your bucket

is inspirations installed

inspirations is not installed

Fixed with 8cec1283e00e645ea69972b5bcf3bfa9de483842, should be out in next update


Job Gift spells should always pass addendum check

After unlocking Utsusemi: San I noticed it was always faded, and tracked that down to the difference between MainJobCheck() and JobPointCheck() in the spell updater.
As far as I'm aware no Job Gift spells are affected by addendums, so I've just got it always returning true. If this is a faulty assumption, I'm happy to mimic the logic performed by MainJobCheck() instead (or whatever is appropriate).

Your interpretation and patch are correct, if you'd like me to directly merge your commit you'll need to increase the version by 0.01 so that it is not identically numbered.  Otherwise, I can certainly make a new commit myself.


Getting an error while creating account

Trying to signup, getting an error message, account was not created.
Log
web-1  |  POST /register 200 in 38ms
web-1  |  GET /api/auth/providers 200 in 14ms
web-1  |  GET /api/auth/signin?callbackUrl=http%3A%2F%2Flocalhost%3A3100%2Fregister 302 in 8ms
web-1  |  GET /login?callbackUrl=http%3A%2F%2Flocalhost%3A3100%2Fregister 200 in 29ms
api-1  | [08/Aug/2024 13:52:23] "POST /api/users/ HTTP/1.1" 201 24
web-1  |  GET /api/auth/session 200 in 29ms
web-1  |  GET /api/auth/session 200 in 21ms

I just tested this functionality with the current main and it works as expected. Are you sure that you din't changed any code? Would you mind to try to rebuild the containers?


Fix-RpcNep5Tracker, prevent it from leveldb bug.

Fix-RpcNep5Tracker, prevent it from leveldb bug.

What's this?

@erikzhang We found if new a variable for ExtraGas evertime when execute ApplicationEngine.Run(), it will cause the bug of leveldb. Details please see here. https://github.com/neo-project/neo-cli/issues/472
We've already tested it on mainet, within this hotfix, chain number grows stablely. Without this, chain number grows rapidly which causes no space on disk. It's not a problem from our code but this could avoid causing leveldb bug.

This doesn't seems related to levelDB :S

This doesn't seems related to levelDB :S

At first, I'm not sure. But when I saw the issue reproduced again, I just try to readjust it. And I test it several times, it truely avoids this issue. I resync the node within this version, it works stablely.

Maybe was a random error. Because this change seems that only change the scope of a variable not related with LevelDB.

@shargon Could you try to sync two nodes on mainet on two different server with previous one and this one installed.  You'll find the previous one will crash because of no space on disk and this one runs stablely.

I am not sure, @superboyiii, however, your tests are usually always right! ahuehaeahuea
If it solves something I think you should proceed because there is not a notorious dangerous on this.

Hey, Vitor, my man. Thanks for your trust. This story begins here: https://github.com/google/leveldb/issues/320.
Details can be seem here: https://github.com/neo-project/neo-cli/issues/472
What I did was tested to prevent neo-cli from this issue, that's an accidental chance when I found that changing code to this way could avoid this issue. Could you help me to double check?
You need to do these:

Sync a node with master-2.x's version, build RpcNep5Tracker, and put it into Plugins folder. Try to sync to the latest height with offline package: https://sync.ngd.network/. After about ten hours, you'll find your disk has few space left.
Build this version and do the same steps again. After several hours, you'll find everything is normal and your node has already sync to the latest height.

Please test it.

Surely, @superboyiii, my pleasure.
It is always great to hear the history behind, these ideas should be valued because of that, it is always not easy to find any problem. But, when we find we are happy ;D
Give me some couple of days.
Can you describe 1. again, please?
I need to sync the node first and then include the plugin? Can not just include the plugin and sync with bootstrap?

We can upgrade leveldb in order to prevent future issues

@shargon Yes, that's the best solution. Please take a look at here. https://github.com/neo-project/neo-cli/issues/472 @Ashuaidehao has already build the latest leveldb library, and we've test it on three different OS: Win10，Ubuntu 16.04 and MacOS. We use base case to make function and rpc test, all pass. The final step we have to do is compare it with previous data to ensure it's compatible. @nicolegys is doing this, it will take several days, let's wait for it.

Surely, @superboyiii, my pleasure.
It is always great to hear the history behind, these ideas should be valued because of that, it is always not easy to find any problem. But, when we find we are happy ;D
Give me some couple of days.
Can you describe 1. again, please?
I need to sync the node first and then include the plugin? Can not just include the plugin and sync with bootstrap?

Bootstrap is available. Recommend to use bootstrap.

@superboyiii, can we merge it?
I did not had time to test. However, the change is trivial and does not produces any danger.

If merged, perhaps we need to port to master branch.


Support for FastTokenizer in huggingface

Hello, I found there is no a corresponding PLBartTokenizerFast in huggingface, do you have a plan to implement a fast version tokenizer?
In fact, I need to call the word_ids() function of fast tokenizer to get the list indicating the original word corresponding to each tokenized token.
 word_ids = tokenized_inputs.word_ids(batch_index=i)
Or do you have any ways to calculate the original word index corresponding to each tokenized token?
Thank you very much!

I'd appreciate if the Fast Tokenizer can be implemented for this model in HuggingFace.


Everything plus the Kitchen Sink

I have found the loadLanguages() utility very useful to load in languages "on demand" during build time. This works great but after reading the Extending Language Definitions section I was hoping I could pass in my own grammars in addition to those which come with the library.
I'm imaging something like this:
import Prism from 'prismjs'
import loadLanguages from 'prismjs/components/index'
import type { CodeOptions } from '../code-types'

export function getPrismHighlighter(options: CodeOptions) {
  loadLanguages() // loads all languages
  if (options.languageGrammars)
    loadLanguages(options.languageGrammars)

  return Prism.highlight
}

Where languageGrammars is a dictionary of Record<string, Grammar>

Is something like this possible?

loadLanguages's main job is to resolve dependencies. Prism has a non-trivial dependency system because this project got started before ESM was a thing.
So if your grammars don't have dependencies (or don't need loadLanguages to load them), you can just do:
for (const id in options.languageGrammars) {
  Prism.languages[id] = options.languageGrammars[id];
}


Add Github Action

CI is always nice.
Cabal new-test is running, so CI is easy.
Either look for new Github Actions (They are cool) or just copy past the travis.yml from Chesskell

So, there is no github action for haskell (buh).
However, looking at the Haskell Lint Action all it takes is a normal docker container. I will check if the haskell base image and a simple cabal-install is a-ok already

https://github.com/actions/setup-haskell
Nevermind, that is the haskell github action. Always good to look twice.

https://github.com/cirrus-actions/rebase This one looks nice too

https://github.com/actions/starter-workflows/blob/master/automation/greetings.yml would make a nice addition.


chore: pin external gh actions to hash

Issue #, if available:
Description of changes:

pin external gh actions to hash

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: 49896de95a77786d70087121e922c8a272afb7af
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Add music page

Just sorting out the fact that this includes an unmerged change.

Removing because I'm in a pickle.


Bump ws dependency to 1.0.1 (eliminates dependency on bufferutil)

This fixes issue #767.  Starting with version 1.0.0, ws no longer depends on bufferutil, eliminating the need to install a compiler on Windows and the whole node-gyp thing.

I'm not sure why the 2 Travis builds failed... The failing testcase doesn't fail on my Windows or Mac system (although there is another testcase that fails on Windows due to / vs \ in expected path names).

Landed as c769ae92bfec5dc8fcb4d291abf94271b17dabfa
Thank you for contribution!


Howto create proper group permissions without using Cognito

I have the following datastructure.
What I basically want to achieve is that people inside the same Group can read only  see each others Swipe data points.
type Swipe
  @model
  @auth(rules: [
    {allow: owner},
    {allow: groups, groupsField: "group"}
  ])
{
  id: ID!
  owner: String
  recipe: Recipe! @connection
  liked: Boolean!
  group: Group @connection(name: "GroupSwipes")
  timestamp: AWSDateTime
}

type Group
  @model
 {
  id: ID!
  owner: String
  groupname: String!
  groupcode: String!
  swipes: [Swipe] @connection(name: "GroupSwipes")
}

At the moment I get only my own Swipe data if I run my ListSwipes() query
Groups are dynamically created within the app, so Cognito wouldn't work here?
Cognito is also limited to 25 groups

As of writing you have a few options.

Turn top level queries off for the model that you want to be read protected by the group. For example,

type Group @model {
  id: ID!
  members: [String!]!

  # You can specify that only members of this group can access this connection field.
  swipes: [Swipe]
    @connection(name: "GroupSwipes")
    @auth(rules: [{ allow: "owner", ownerField: "members" }])
}
# We turn queries off so there is no `Query.getSwipe` or `Query.listSwipes`.
# You can only access these swipes via `Group.swipes` which protected by the group membership.
# Only owners may mutate swipe objects.
type Swipe
  @model(queries: null)
  @auth(rules: [
    {allow: owner, operations: [create, update, delete]}
  ])
{
  id: ID!
  owner: String
  liked: Boolean!
  group: Group @connection(name: "GroupSwipes")
  timestamp: AWSDateTime
}

I haven't tested this out yet, but the next issue would be, how do I add Cognito users to  members: [String!]! ?

@sprucify
I haven't tested this out yet, but the next issue would be, how do I add Cognito users to members: [String!]! ?
You would manually add the username, sub, or whatever attribute you want to use as the identity to the list of members on the object.
To implement your access patterns, it depends if the authorization information lives on the model that is being operated or not.
For example in The creator of a Group is the only one that can delete / update a group, if a Group contains and attribute creatorId and that creatorId contains a string equal to the sub claim in your JWT then you can use the auth directive to authorize update & delete operations.
type Group
  @model
  @auth(rules: [
      { allow: owner, ownerField: "creatorId", identityField: "sub", operations: [update, delete] }
    ])
{
  id: ID!
  creatorId: String!
}

To implement access patterns that cross @connections for mutations you can write custom resolvers that fetch and validate information from one or multiple tables if using pipelines. The general ideal is that if the authorization information lives on a type that is not directly being operated on, you can use a pipeline resolver to first fetch that information and authorize before executing the write. If you are storing your members as a list of strings on the group, then you can use the built in @auth directive to authorize mutations. For these you can use steps like shown here: https://aws-amplify.github.io/docs/cli/graphql#add-a-custom-resolver-that-targets-a-dynamodb-table-from-model

I'm gonna close this issue for now, if you till have any question feel free to comment on this or re-open this thread.


CNV-49651: put a default disk size if user have no access to the pvcs

📝 Description
If the user has no permission to access the PVC size, use the default value of 30Gi
🎥 Demo

/retest

/cherry-pick release-4.17


client.click is not implemented?

I want to click an element which exists certainly by checking with client.element(selector).
But click event is not triggered by client.click(selector).
I implemented this like following code based on the document,
http://webdriver.io/api.html
http://webdriver.io/api/action/click.html
Code:
`....
app.client.element('#MyElementId').then( (e)=> {
// O.K. reached
console.log('#MyElementId exists')
app.client.click('#MyElementId').then(()=> {
// not reach
})
// OR
app.client.click('#MyElementId');
setTimeout(()=>{
// not reach
},3000);
});
// OR using elements()
app.client.elements('.MyElementClassname').then( (elements)=> {
// not reach, timeout occured
// elements() also is not implemented?
})
`
Is client.click not implemented yet?...

More additional info,
The click target is a radio button, and click for the label element of that radio is fired by app.client.click.
I don't know why client.click(radio) is not tirggered...

This might do the trick: http://webdriver.io/api/state/isSelected.html

Thank you so much!!
I solved it!


Allow multiple excludes

Allow the exclude parameter to be an Array as well as a
minimatch string. This allows for greater flexibility when excluding
files as minimatch regexs with 'or' patterns quickly become unreadable /
unmaintainable.

@blakeembrey - can this be merged?

How would this be used from the command line? I tried --exclude "**/custom-error.ts" --exclude "**/other.ts" which only used the last minmatch and --exclude ["**/custom-error.ts","**/other.ts"] which didn't exclude anything.
It'd be great to also update the usage documentation as well with this new option.

@haraldF Could you please add an example for this, I can't make it work.

@harunurhan Yeah, some documentation is certainly needed. I believe this is only accessible programmatically. Are you passing typedoc options via the CLI?

I achieved that by using a config file. Thanks.


Changed scheme comparison to be case insensitive

The authentication scheme type comparison should be case insensitive. It's detailed in the OAuth 2.0 RFC, see token_type.

This should 'fix' issue #117.

Merged. In the future please add tests to validate new behavior.


Not working under IE 11

which version should i download to be compatable with ie 11?

First, I thought I would ask why. Microsoft no longer supports Internet
explorer 11 and has pushed it off desktops. The major corporations I work
with as clients do not support Internet Explorer 11 anymore. I am not
trying to be difficult, I am genuinely curious as to why you would need to
do this at this point.
That being said, if you do have such a use case, you should be using babel
to compile a version that is compatible with ES5. We don’t do that
ourselves because we don’t use this module in the browser and are not in a
position to support that well. It makes the most sense for you to have your
own babel build for your own requirements.
On Fri, Nov 4, 2022 at 2:35 AM NeilChoi @.***> wrote:

which version should i download to be compatable with ie 11?
—
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/sanitize-html/issues/578, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAH27LP4MTNJIY43R7VYLDWGSVC3ANCNFSM6AAAAAARW3VEPE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his

Don't know what was the case for original poster, but in my case - some Microsoft Office products launch WebView as IE, not Microsoft Edge. So applications that are supposed to run under Microsoft office should still support IE 11 for minority of their users (newer Microsoft office versions to use Microsoft Edge)

"Internet Explorer and Microsoft Edge Legacy are still used in Office
Add-ins
Some combinations of platforms and Office versions, including
volume-licensed perpetual versions through Office 2019, still use the
webview controls that come with Internet Explorer 11 and Microsoft Edge
Legacy (EdgeHTML-based) to host add-ins, as explained in this article. We
recommend (but don't require) that you continue to support these
combinations, at least in a minimal way,* by providing users of your add-in
a graceful failure message when your add-in is launched in these browsers.*"
Per Microsoft's recommendation, your best path here is to refuse to
operate. Seriously, this is unsafe in so many other ways unrelated to
sanitize-html. No one is maintaining it for security.
On Mon, Dec 19, 2022 at 5:08 AM Artur Buls @.***> wrote:

Don't know what was the case for original poster, but in my case - some
Microsoft Office products launch WebView as IE, not Microsoft Edge. So
applications that are supposed to run under Microsoft office should still
support IE 11 for minority of their users (newer Microsoft office versions
to use Microsoft Edge)
—
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/sanitize-html/issues/578#issuecomment-1357399803,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAH27LW6F6DG2JJ7HDMDXDWOAXZPANCNFSM6AAAAAARW3VEPE
.
You are receiving this because you commented.Message ID:
@.***>

--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his


fix(cn-browse): Fix result filtering for items.effectiveLocationId

Purpose
Fix result filtering for items.effectiveLocationId
MSEARCH-615
Approach
Add items filtering for items.effectiveLocationId filter
Changes checklist

[ ] API paths, methods, request or response bodies changed, added, or removed
[ ] Database schema changes
[ ] Interface versions changes
[ ] Interface dependencies added, or removed
[ ] Permissions changed, added, or removed
[ ] Check logging.

Please update NEWS


Move canvas functions out of library

We need to create a seperate library/plugin/file just for canvas operations, and it must be fully custumizable.

Plugin-like mechanism accomplished.


Crashing page

In an attempt to address the issue in #137, let's deploy this and see if the error will persist or not.
It might be related to unsubscribed Observables, accessing localStorage, using deprecated methods as the document.execCommand('insertText', ...) and so on.

An increasing index instead of a decreasing index in a for loop seemed to have caused this issue, i.e. the algorithm for storing data in localStorage seemed to have been causing it.
Let's write some tests for this functionality soon, as also mentioned in #114.


AArch64 SMP spinlock enhancements

Is your enhancement proposal related to a problem? Please describe.
The current spinlock implementation on AArch64 SMP leaves a lot of performance on the floor.
Describe the solution you'd like
As spinlock performance can quickly become a bottleneck in SMP, I would like to open the discussion to how to improve spinlock performance on AArch64 SMP.
I have collected a fair bit of data on the subject locally, using a microbenchmark on a bare-metal quad-core A53 system. Some setup:

All cores have interrupts disabled.
N cores are running the testing loop, and the other 4-N cores are running  while (1) {wfe} (again, with interrupt disabled.

This results in minimal memory traffic on unused cores. I would use wfi instead of wfe, but wfi wakes for physical interrupts regardless of if the interrupts are masked.

Each testing loop is just a loop of k_spin_lock / increment 64-bit variable in memory / k_spin_unlock.
The "uncontended" ("nc") cases are where each testing loop has its own spin lock and counter in a unique cache line (read: spaced far enough in memory that you don't have false sharing); the "contended" ("c") cases are where all testing loops are using the same spin lock and variable.
The cycle counts are captured over a ~50mcyc period (note: total; divided by the number of cores active.)

(I'm going to be adding more later here as comments; this is just a start.)
Baseline is what is on trunk (roughly; this branch does have differences from trunk to enable this working at all, but the code the test code is exercising is what's on trunk).
SeqRel is the following patch on both k_spin_unlock and k_spin_release:
-	// atomic_clear(&l->locked);
+	__atomic_store_n(&l->locked, 0, __ATOMIC_SEQ_CST);

(Which obviously isn't the "proper" way to do it, but hopefully suffices for a quick test.)
Prefetch is SeqRel + adding the ARM-recommended prefetch before the spinlock. (Note: ahead of time I'm suspecting here that this won't matter much on the A53, but may on larger cores.)
+	__asm__("PRFM PSTL1KEEP, %0" : : "Q"(l->locked));
	while (!atomic_cas(&l->locked, 0, 1)) {
	}

(Again, obviously non-portable as-is, but suffices for this.)
Spoiler: I'm not going to bother going through all of the cases here, because both 1 and 4C are slower than without the prefetch (although still faster than baseline). Dead end (for the A53; may be better on other cores), move on.
Litmus is SeqRel + replacing the CAS in lock with this monstrosity taken from the ARMv8-A ARM:
	atomic_val_t val;
	atomic_val_t one = 1;
	__asm__ volatile(
		"SEVL" "\r\n"
		"1:" "\r\n"
		"WFE" "\r\n"
		"LDAXR %w[val], %[where]" "\r\n"
		"CBNZ %w[val], 1b" "\r\n"
		"STXR %w[val], %w[one], %[where]" "\r\n"
		"CBNZ %w[val], 1b" "\r\n" :
		[where]"+Q"(l->locked), [val]"=&r"(val) :
		[one]"r"(one)
		:
		"memory");

(Which is pretty much verbatim what ARM recommends here, with the exception of dropping the preload.)
(Yes, this does reuse val for two different things here.)
(I'm personally not convinced that the SEVL is worth it here over an unconditional branch, but meh.)
(Interestingly, even though we're using WFE here we don't need a corresponding SEV. ARMv8 changed it so that clearing a global monitor sends an event, so another core doing a write to locked will wake us up.)
The main advantages of this are that a) cores that are waiting for the spinlock have substantially less memory traffic while doing so, and b) two major wrinkles that I will get into later.
The major wrinkles are as follows:

There is no simple extension to the current atomics API that permits the use of WFE, short of adding e.g. blocking_cas or somesuch. (You can get close by adding a weak CAS + a wfe hint API, but even that has issues.)
This relaxes the memory model. More on that below.

Comparison:

k_spin_lock

Normalized

k_spin_unlock

Normalized

total

Normalized

Baseline
SeqRel
Litmus
SeqRel
Litmus
Baseline
SeqRel
Litmus
SeqRel
Litmus
Baseline
SeqRel
Litmus
SeqRel
Litmus

1
38.50
41.00
32.20
93.90%
119.57%
30.50
9.00
12.00
338.89%
254.17%
69.00
50.00
44.20
138.00%
156.11%

4 NC
38.50
38.75
32.20
99.35%
119.57%
30.50
9.75
12.00
312.82%
254.16%
69.00
48.50
44.20
142.27%
156.11%

2 C
173.29
180.99
125.67
95.75%
137.90%
54.66
10.64
12.09
513.72%
452.08%
227.96
191.62
137.76
118.96%
165.48%

3 C
398.20
433.76
251.34
91.80%
158.43%
78.04
10.44
13.10
747.51%
595.74%
476.24
444.20
264.44
107.21%
180.09%

4 C
680.45
664.65
384.82
102.38%
176.82%
95.01
11.47
13.37
828.33%
710.73%
775.46
676.12
398.19
114.69%
194.75%

(So e.g. two contended cores trying to take a spinlock with the spin release patch each take ~192 cycles to do a lock + unlock.)
All told, just the SeqRel change ends up with about 140% of the performance when unloaded, dropping down to 110-120% when loaded.
(Note that even in the best case, N cores would take about N times the cycles to grab a single contended spinlock.)
And the Litmus version is ~1.5x the speed unloaded, increasing (!) to ~2x baseline when loaded.

So, what's the catch? Several, one less major, one major:

Although the SeqRel change can be done using the current indirection-through-atomics approach, I have been unable to find a good way to do the Litmus change in the same manner.
These relax the spinlock memory model from what it is documented as. (Even the "SeqRel" version as-is - it turns into a store-release, which does not prevent store reordering around it. Again, C11 atomics being "amusing" again and only considering ordering around other atomics.)

So let's talk about the memory model for a moment. (You may wish to look at #32133 for some background.)
The current spinlocks are documented as a full memory barrier. This optimized lock has k_spin_lock function as an acquire barrier only, and k_spin_lock_release function as a release barrier only. Or, translated somewhat:

If the spinlock is used purely to ensure ordering of operations inside the spinlock, there's no behavioral difference.
There are cases where an external observer can observe reordering of a write done inside a spinlock with a write done outside of said spinlock.
There are cases where an external observer can observe reordering of a write done before the spinlock with a write done after the spinlock.

For reference:

Any issues here will likely mainly affect ARM (and other weak memory models).
Any issues here will only affect SMP (every architecture under the sun observes sequentially-consistent stores within its own core)
In practice my local smoketests of AArch64 SMP didn't find any cases where Zephyr was relying on spinlocks as a full memory barrier.
In practice my quick glance through uses of spinlock didn't find any cases where Zephyr was relying on spinlocks as a full memory barrier - though again, quick glance.
Any issues here would likely be very much long-tail in nature. (So not so much "it always fails" as "it fails once in a billion operations").

Some potential approaches here:

Add new API calls k_spin_lock_acquire_barrier_only (and ditto for release) (or some such - I am terrible at names). Upside: compatible with existing code. Downside: existing code cannot take advantage of new API (or performance) without changes. Downside: additional API surface to maintain.
Change k_spin_lock  / release to an acquire/release only, but add memory barriers to all current callers, with the intent of removing barriers over time as appropriate. Upside: keeps API surface the same (ish). Downside: requires (rote) change to application code to restore current behavior.
Ignore it (always worth calling out as an option). Upside: keeps API surface the same. Upside: no application breakage. Downside: performance.

Thoughts?

Also see https://github.com/zephyrproject-rtos/zephyr/pull/32557#discussion_r583292495 for some context.

@carlocaione - you may be interested in this (you seem to be interested in AArch64 improvements)


Why not add npm bootstrap dependancy?

Would make it easier to upgrade or change version. Also would be nice to see the AWS SDK's as part of npm.

Hi @QuantumInformation ,
The npm bootstrap dependency had issues recently, so it made sense to take that out, especially since it's part of the UI and npm isn't really needed there. In regards to the AWS SDK's npm dependency -- it's on the roadmap.
Thanks,
Vladimir

thx, good to know! Nice work on the TS!

Would live a Typings to with the AWS stuff if possible.


my_init exits with 0 on SIGINT after runit is started

fixes #358

The change looks like a good idea, assuming that it passes CI (it's still running...)
I'll come back later and check if I can get the desired result.  From reading the issue report, I think I'm understanding that sending SIGINT (ctrl+c) should cause the container to quit with fail(1) exit status?  And that the current state is the container exits with success(0) which is misleading because the container didn't terminate normally, actually was aborted.

I'll be looking at this one as well.

@kingdonb @hyperknot Any feedback regarding this?


Pre-emptively mark a file to be not inline?

If I know in advance that a file will be very large, is there a way to pre-emptively mark it to not be an inline file when I create it?
In our file system, we have a few small files used to store things like calibration data, but we know in advance things like the datalog will be multiple megabytes in size.  It'd be nice to be able to tell the system in advance that a file will be large so it reduces the amounts of reading/writing/moving around that is done before we hit that magic limit where it decides it's no longer inline.

This is a good idea, and could be added with a flag (LFS_O_NOINLINE?).
One question, inline files are < cache size, and files aren't written to disk until > cache size. Is this occurring over a number of small writes? Or do you think there might be a bug causing excessive disk operations?

I don't think there's a bug or anything but neither have I looked in depth at the SPI traffic.  I have a little bit for some stuff but I was mostly writing large pieces of data at once (half a sector size) so after 2 writes I passed the INLINE threshold.  I haven't looked at it with this specific issue in mind (appending 20 to 40 bytes to a file at a time over an extended period of time).  I have a vague understanding of how LFS works but the details of it are too complex for me to fully grasp so I wasn't sure how often it was changing sectors when I was writing to a file that was inlined in a directory structure.  I'm not sure how often it has to update the 'directory' info when a file in said directory changes so I just thought it'd be nice to be able to say in advance "This file will be big".

Ah I see.
I don't think the performance improvements from LFS_O_NO_INLINE would be that great.

littlefs still writes a piece of metadata (12 bytes + padding) to the directory for every sync/close. For non-inline files this is just a pointer to the file data.
littlefs rewrites the last block being written to in non-inlined files. So it would still need to rewrite the same amount of data just in a different location.

littlefs (and by necessity any wear-leveling filesystem) is a bit different from a traditional filesystem in that the data is always moving. So it usually works out best if we just keep the amount of data we need to write as small as possible, even if it changes formats several times in its lifetime.
That being said, there's no reason not to try it once we have reproducible benchmarks running.


Fix integration tests

Fix the integration tests so that they are actually run and succeed. Builds upon #812.

Right.. I am going to close this.
These Integration tests haven't even been run in 4 years and would need to be rebuilt if we wanted to use them again as they relied on a package called dbunit that doesn't work past PHPUnit 8 (we are now on 10).
See: https://github.com/boxbilling/boxbilling/pull/618. Rather than rebuilding them, let's just get a new test infrastructure going an actual instance that's connected to a DB & gradually drop all of these old that came from BoxBilling and are oh so unhelpful.


Sub-workflow for Phage prediction

Description of feature
Create a sub-workflow for AMR detection with the following modules from nf-core.

[ ] CheckV

The following modules require writing nextflow modules before integration

[ ] Virsorter2

Only close this after #33 is completed


jumpy swallows type events when disabled

I'm maintaining an extension (https://github.com/michaelgriscom/LeaderMode) which leverages VSCode's type command to expand shortcut keys that jumpy clashes with. Upon being enabled, jumpy registers a custom type command, bubbling the type event to the default command if jumpy is disabled
https://github.com/wmaurer/vscode-jumpy/blob/e547c8f6b92613fd8dad57c36d4e0b4366a7739e/src/extension.ts#L130-L134
The issue is that when the jumpy extension registers its type command other non-default listeners don't see the event, breaking other extensions (this is essentially the reverse of issue #1). I believe that a better approach would be to dispose of the command whenever jumpy is disabled, then re-register the command when it is enabled; that way the jumpy command only exists when the mode is active. I've taken that approach with LeaderMode and haven't noticed any perf impact

Created a PR as a starting point for a fix


visitedURLs should be invalidate some how

For batch craw, the memory will grow very fast, colly become very slow

@wenerme you can disable it, collector has an AllowURLRevisit attribute, set it to true.


Proposal: Math Lib is missing some APIs.

(This is the original proposal text. See the updated version of this proposal below)
I propose (to the Q# API Design Review Board) to add to the Q# API the following missing calls to support the Math library.
    @Inline()
    function NAN() : Double {
        body intrinsic;
    }

    @Inline()
    function IsNan(d: Double) : Bool {
        body intrinsic;
    }

    @Inline()
    function INFINITY() : Double {
        body intrinsic;
    }

    @Inline()
    function IsInf(d: Double) : Bool {
        body intrinsic;
    }

    @Inline()
    function IsNegativeInfinity(d : Double) : Bool {
        body intrinsic;
    }

Currently they are needed to implement the Log() math function.
More details:
Discussion
Possible Implementation

@samarsha, looks like you are right ;-)
However I'm not sure if negative infinity is the same as -(positive infinity). It needs to be double-checked against the corresponding floating point standard.

@cgranade, I agree, Microsoft.Quantum.Math looks a good place.

I think you could define negative infinity as -1.0 / 0.0 in that case.

@samarsha, I like the ideas in both your posts!

I'd suggest going with IsInfinite for the name of the function to check against infinity and having it check against positive and negative infinity. In part, that makes for a nice complement with checking that a number is finite:
namespace Microsoft.Quantum.Math {
    function IsInfinite(d : Double) : Bool {
        return d == 1.0 / 0.0 or d == -1.0 / 0.0;
    }

    function IsFinite(d : Double) : Bool {
        return not IsInfinite(d) and not IsNaN(d);
    }
}

namespace Microsoft.Quantum.Diagnostics {
    function FiniteFact(d : Double, message : String) : Unit {
        Fact(IsFinite(d), message);
    }
}

Positive and negative infinities can still be discriminated by checking d > 0.0 and d < 0.0, so no expressive power is lost. This also more closely matches existing scientific computing APIs like np.isinf, 's isinf, or even MATLAB's isinf, all of which check against positive and negative infinity in precisely the same way.

@kuzminrobin: The API review for March is coming up in a few days, it would be good to get this in to that review cycle. Would you be willing to update your proposal to include the namespace, and the feedback from me and @samarsh, so that we can get it added to the discussion? Thank you!

Based on the feedback/discussion, the updated version of the proposal is below:
namespace Microsoft.Quantum.Math {
    function NaN() : Double {
        return 0.0 / 0.0;
    }

    function IsNaN(d : Double) : Bool {
        return d != d;
    }

    function IsInfinite(d : Double) : Bool {
        return d == 1.0 / 0.0 or d == -1.0 / 0.0;
        // Positive and negative infinities can still be
        // discriminated by checking `d > 0.0` and `d < 0.0`.
    }

    function IsFinite(d : Double) : Bool {
        return not IsInfinite(d) and not IsNaN(d);
    }
}

namespace Microsoft.Quantum.Diagnostics {
    function FiniteFact(d : Double, message : String) : Unit {
        Fact(IsFinite(d), message);
    }
}

@bettinaheim @swernli: In terms of dependency ordering, should this one live in libraries or the runtime repo (i.e.: QSharpFoundation)?

This should go in the runtime repo, in QSharpFoundation. One thing I'm confused on:
function IsNaN(d : Double) : Bool {
    return d != d;
}

If I pass 4.0 to IsNaN won't it return true? Or is there something about doubles that I don't understand? I would've expected this to be:
function IsNaN(d : Double) : Bool {
    return d != NaN();
}

If I pass 4.0 to IsNaN won't it return true?

No, because 4.0 == 4.0.

function IsNaN(d : Double) : Bool {
    return d != NaN();
}

Do you mean d == NaN()? This doesn't work, since NaN is not equal to anything, even another NaN. Since it's the only floating point value with this property, a float is NaN iff it is not equal to itself (d != d).

Whoops, never mind. I inverted the Boolean in my head. If a double is NOT equal to itself then it is NaN. I get it now.

This should go in the runtime repo, in QSharpFoundation. One thing I'm confused on:
function IsNaN(d : Double) : Bool {
    return d != d;
}

That's what I was thinking, but wasn't sure... I'll go on and add these there, then. Thanks!

If I pass 4.0 to IsNaN won't it return true?

No, because 4.0 == 4.0.

function IsNaN(d : Double) : Bool {
    return d != NaN();
}

Do you mean d == NaN()? This doesn't work, since NaN is not equal to anything, even another NaN. Since it's the only floating point value with this property, a float is NaN iff it is not equal to itself (d != d).

It will never sit well with me that IEEE 754 fails to be reflexive... I trip up all the time on NaN != NaN, sigh. All the more reason for good unit test coverage!

I'm happy either if you want to take this on, or if you'd prefer for me to

I can get back to this later. Feel free to go ahead and make the change if you have time and desire.

@kuzminrobin: Since the March milestone will be closing in not too long, I'll go on and take care of this one, then. Want to make sure we don't miss the release window.

(This is the original proposal text. See the updated version of this proposal below)
I propose (to the Q# API Design Review Board) to add to the Q# API the following missing calls to support the Math library.
    @Inline()
    function NAN() : Double {
        body intrinsic;
    }

    @Inline()
    function IsNan(d: Double) : Bool {
        body intrinsic;
    }

    @Inline()
    function INFINITY() : Double {
        body intrinsic;
    }

    @Inline()
    function IsInf(d: Double) : Bool {
        body intrinsic;
    }

    @Inline()
    function IsNegativeInfinity(d : Double) : Bool {
        body intrinsic;
    }

Currently they are needed to implement the Log() math function.
More details:
Discussion
Possible Implementation


Reroutes cmd-line launch of solution to VS 2017

At the cmd-line prompt, a solution may be opened by typing in its name.
c:> AppUIBasics.sln
When this is done with XAMLUIBasics.sln and VS 2015 is installed, AppUIBasics will default to VS2015 instead of VS2017.
A change to the .sln file takes care of this. (the pertinent line is the commented one, strangely)

@andrejo-msft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Fix has been folded into v5.0.1.


[SPARK-21835][SQL] RewritePredicateSubquery should not produce unresolved query plans

What changes were proposed in this pull request?
Correlated predicate subqueries are rewritten into Join by the rule RewritePredicateSubquery  during optimization.
It is possibly that the two sides of the Join have conflicting attributes. The query plans produced by RewritePredicateSubquery become unresolved and break structural integrity.
We should check if there are conflicting attributes in the Join and de-duplicate them by adding a Project.
How was this patch tested?
Added tests.

Test build #81117 has started for PR 19050 at commit edb6271.

Test build #81117 has finished for PR 19050 at commit edb6271.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81117/
Test FAILed.

retest this please.

Test build #81121 has started for PR 19050 at commit edb6271.

Test build #81121 has finished for PR 19050 at commit edb6271.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81121/
Test PASSed.

Test build #81172 has started for PR 19050 at commit 121ad5a.

Test build #81173 has started for PR 19050 at commit bf07e2a.

Test build #81172 has finished for PR 19050 at commit 121ad5a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81172/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81173/
Test FAILed.

Test build #81179 has started for PR 19050 at commit 82b5bac.

Test build #81179 has finished for PR 19050 at commit 82b5bac.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81179/
Test PASSed.

ping @hvanhovell Does the current change look good for you?

also cc @cloud-fan for review. Thanks.

ping @cloud-fan @hvanhovell Can you have time to review this? Thanks.

ping @cloud-fan @hvanhovell This blocks the #18956 going forward, can you help review this change? Thanks.

@cloud-fan and @hvanhovell seems too busy these days. maybe @gatorsmile can also help review this. Thanks.

Test build #81439 has started for PR 19050 at commit c1325fb.

LGTM pending Jenkins

Test build #81440 has started for PR 19050 at commit 8550828.

Thanks @gatorsmile

Test build #81439 has finished for PR 19050 at commit c1325fb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81439/
Test PASSed.

Test build #81440 has finished for PR 19050 at commit 8550828.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81440/
Test PASSed.

Thanks! Merging to master


StyleGuide - 05-17 showing the logic in the recommend

In this style we refactor the logic in the template to put it into the code, but we actually never show the logic in the code. I vote to add it.

SGTM (sounds good to me)
Go for it

Merged.


Issues with Icon Color based on state

DONT'T DELETE THIS.
Please answer all questions as good as possible.
Language: english/german
Make sure you have read the documentation at https://github.com/danielperna84/custom_homematic#custom_homematic.
Make sure you have read the release notes at https://github.com/danielperna84/custom_homematic/releases.
Make sure you are running the latest version of the custom_component (and Home Assistant) before reporting an issue.
ENSURE that your Backend (CCU/Homegear/...) is working as expected and connected devices are controllable.
custom_component version (if applicable):
latest
known last working custom_component version (if applicable):
unknown
Home Assistant version (if applicable):
2022.10.5
CCU version:

ProxmoxVE
RaspberryMatic
Version: latest

Problem-relevant configuration:
Do you use tls?
Do you use callback?
Do you use username and password?
Which interfaces do you use (hmip/bidcos/wired)?
hmip
Describe the bug
I am running a Window Sensor and a Window Handle sensor.
Both are reporting the state correctly - but it appears, that the sensor for the door handle does not change the Icon when it is open - nor change the color as configured in the lovelace card.

I am not sure, if this is related to this integration - but since the card does change the icon's color - I think it shouldn't be an issue inside of HA.
To Reproduce
Steps to reproduce the behavior:
Screenshots (if applicable)
Entity View

Relevant HA log entries (full log)

Diagnostic Information (available on every device)

Expected behavior
Sensor type HmIP-SRH should also change the Icon Color / the Icon based on its state.
Maybe, this isn't the case, because it can have at least three different states (closed, open, curtailed)
In this case, I would consider the curtailed state also as "open" indicator - which should change the icon color.
Additional context
Add any other context about the problem here.

HmIP-SRH is a special case. Unlike binary_sensors it does have a device_class that determines the icon color handling.
I will will not add a special handling for a single sensor to handle different icon colors.
You could do this on your own by using a template sensor/binary_sensor to customize this.

I found a solution that works with the existing code without having extra code for certain devices.
But this solution can only change the icon based on state.
Changing the color based on state is done in the frontend, and cannot be done by an integration.
That will be release with 1.19.9.