WIP: Add more tests and benchmarks

This PR adds several tests to increase the test coverage and more benchmarks.

This change is

(CI failure is due to miri missing on 2020-02-21 nightly: https://rust-lang.github.io/rustup-components-history/)

Should I fix the ci issue?

Should I fix the ci issue?

No, just leave it -- it'll likely be fixed tomorrow-ish.

Are there some must-have test / benchmarks that you would like to have in Flurry?
Because I wasn't able to find any missing tests from the Jdk.
I will just add some benchmarks.

The tests that I know of are the JDK tests, the JSR166 tests, and the hashbrown tests. Ideally we'd have pretty much all the tests from all those three.

I think all tests are implemented that are compatible with flurry.
I think I will leave the benchmarks as they are.

Thanks for working on this! A few comments from looking through the diff:

You added the OneBucketHasher from basic.rs to basic_ref.rs to use it there as well, and there is also ZeroHasher in hasher.rs. All of these hash everything to 0. It would probably make sense to have this only once and shared it everywhere it is needed.
It looks like you simplified uses of map.pin() in most tests. @jonhoo did you look at this in your previous review?

For some methods, such as insert_and_remove, this is probably okay since they also only used one pin() before.
Other methods use several pins, and we have to be careful to not involuntarily exclude testing that using multiple HashMapRefs works as intended. For example in update, we want the updates to be visible if we use a different Ref later. I think we should keep testing that.
The XYZ_equal methods previously tested HashMapRef equality against HashMapRef itself and against HashMap. Since these equality traits are added together with HashMapRef, I think the test should continue to check this.

Concurrent tests:

When setting up a map at the start of a concurrent test, e.g. here, if we use a guard and leave it around afterwards, then this guard will pin an epoch for the entire duration of the test. To avoid this, the guard can be put inside of a local scope, like here:
https://github.com/jonhoo/flurry/blob/master/tests/basic.rs#L253-L262
Also note that this uses map.guard() instead of epoch::pin(), which we could change while we're at it.
This one might be me not exactly keeping up with everything that happend here (if so, sorry 😅 ), but I didn't see new versions of some of the removed concurrency tests, for example concurrent_remove. If there isn't a new implementation, I would just keep the old tests so we don't loose anythin.

Lastly, there is a typo here, but that'll be quick to change 😊

Wonderful! Don't know why one of the CI targets failed, but all of my comments have been addressed with the new commits, so I'm happy to approve this now.

The miri failure is because miri was broken on the last nightly. I think the newest one has it again though, so I'll re-run.

:tada: Thank you!


GDPrettyPrint is an empty class

I've found that GDPrettyPrint is a completely empty class. What was it meant to be, and should we implement it, or remove it?

https://github.com/godotengine/godot/blob/master/modules/gdscript/gd_pretty_print.cpp
https://github.com/godotengine/godot/blob/master/modules/gdscript/gd_pretty_print.h

This class has been removed, so can be closed.


Cannot select some regions in ICBM 2009c Nonlinear Asymmetric

Some region names in "ICBM 2009c Nonlinear Asymmetric" is not selectable and searchable (region names looks like "jubrain mni152 v18 right#13"). For selection problem caused by "#" (like labelIndexId) in the name.

data issue, cannot label was not defined in hierarchy/xml, so cannot parse the label.


update ci.yml with yarn

Codecov Report

Merging #278 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #278   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           5      5
  Lines          83     83
  Branches       18     18
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a3598...f52176b. Read the comment docs.


Missing information about failed query against external providers

Describe the bug
While working at rest issue  #8327 we noticed that, in case of error during external system query, user is not properly informed about this failure.
To Reproduce
Steps to reproduce the behavior:

login to dspace7 and go to MyDSpace
start a new Publication submission from external source
enter a query string and select “Pubmed” as external source
In case query fails with a 500 backend error, following page is displayed

Expected behavior
In case of rest error (500 in this example) A message indicating that search went in error.  We believe current behavior could be improved, and such improvement would lead to a little UX improvement in case of failure of a query for live import towards an external system.
We, 4Science, can take in charge this improvement, our work estimation is 2/4 hours.

This ticket seems somewhat related to https://github.com/DSpace/DSpace/issues/8358, but it might be more specific to a single area of DSpace.
I'm not against this idea, but I think we need to be cautious.  As noted in that other ticket, the REST API was designed to not return error stacktraces in order to avoid "information exposure" (it can be a security issue to share full exceptions as it can give attackers too much information about the underlying system).
All that said, I do agree that there are specific areas where we can and should be providing a more detailed error message.  This seems like one that would qualify.  I just want us to try to avoid information exposure (see https://lgtm.com/rules/6780073/)

we are almost ready to open the PR, it was a bit harder than expected, it took 8 hours


Disallow uint8 indices.

/cc https://github.com/KhronosGroup/glTF-Blender-Exporter/pull/329

see my comment https://github.com/KhronosGroup/glTF/issues/1471
We cannot just remove it, as some people maybe need it.

For compatibility, can we keep uint8 import while removing uint8 export?

Also, regardless of the related spec issue outcome, 65536 should be changed to 65535 to avoid primitive restart.

We cannot just remove it, as some people maybe need it.

Are there people who specifically need UINT8 export from Blender via this plugin?  That seems like too small an edge case.
FWIW, in my conversations with artists, the "maximum indicies" options with different integer sizes are the most confusing of all this plugin's options.  I think it's the only one that doesn't reference a feature they know about from Blender, but rather references an internal detail of the file storage format that they've never heard of.

Thanks! I've reduced the maximum index values by 1, per https://github.com/KhronosGroup/glTF/pull/1476/files.


Enhancement to intellisense on method overloads

Could we get a number of overloads in the dev tools?
With C# we get that, but I often forget that AL allows overloading because C/AL didn't and sometimes miss things...

In AL we just get:

Despite there being 4 overloads for this:

See also: https://experience.dynamics.com/ideas/idea/?ideaid=69116e0b-dc8d-e911-80e7-0003ff68d305

This was mostly covered through the work on suggesting the correct overloads. If you type the parens after the function name you get a list of the overloads sorted by relevance.
I will be closing this as fixed.


Builds fail without Internet access (IDFGH-12120) (PACMAN-808)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
release/5.1 8d2dbd461fc7a31b3d3e55ec12149e53130c13f6
Operating System used.
Linux
How did you build your project?
Command line with CMake
If you are using Windows, please specify command line type.
None
What is the expected behavior?
Builds should succeed without an Internet connection.
export.sh is checking the component registry, and failing if there is no Internet available.
Builds should never be updating components on their own, so there is no need for this check at all.  Firmware builds should succeed without Internet connectivity.
What is the actual behavior?
Builds fail without an Internet connection.
Steps to reproduce.
Build an ESP32 project without Internet access.
Build or installation Logs.
jeremy@Saturn ~/J/T/f/p/esp32_firmware (main)> ./build.sh
~/JEREMY/Twine/firmware/pickup_firmware/esp-idf ~/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware
Setting IDF_PATH to '/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf'
Detecting the Python interpreter
Checking "python3" ...
Python 3.8.10
"python3" has been detected
Checking Python compatibility
Checking other ESP-IDF version.
Adding ESP-IDF tools to PATH...
Checking if Python packages are up to date...
Constraint file: /home/jeremy/.espressif/espidf.constraints.v5.1.txt
Requirement files:
 - /home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/tools/requirements/requirements.core.txt
Python being checked: /home/jeremy/.espressif/python_env/idf5.1_py3.8_env/bin/python
Python requirements are satisfied.
Added the following directories to PATH:
  /home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/espcoredump
  /home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/partition_table
  /home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/app_update
  /home/jeremy/.espressif/tools/xtensa-esp-elf-gdb/12.1_20221002/xtensa-esp-elf-gdb/bin
  /home/jeremy/.espressif/tools/riscv32-esp-elf-gdb/12.1_20221002/riscv32-esp-elf-gdb/bin
  /home/jeremy/.espressif/tools/xtensa-esp32-elf/esp-12.2.0_20230208/xtensa-esp32-elf/bin
  /home/jeremy/.espressif/tools/xtensa-esp32s2-elf/esp-12.2.0_20230208/xtensa-esp32s2-elf/bin
  /home/jeremy/.espressif/tools/xtensa-esp32s3-elf/esp-12.2.0_20230208/xtensa-esp32s3-elf/bin
  /home/jeremy/.espressif/tools/riscv32-esp-elf/esp-12.2.0_20230208/riscv32-esp-elf/bin
  /home/jeremy/.espressif/tools/esp32ulp-elf/2.35_20220830/esp32ulp-elf/bin
  /home/jeremy/.espressif/tools/openocd-esp32/v0.12.0-esp32-20230419/openocd-esp32/bin
  /home/jeremy/.espressif/python_env/idf5.1_py3.8_env/bin
  /home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/tools
Done! You can now compile ESP-IDF projects.
Go to the project directory and run:

  idf.py build

~/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware
~/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/build ~/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware
-- Building ESP-IDF components for target esp32c3
-- Checking Python dependencies...
Python requirements are satisfied.
Constraint file: /home/jeremy/.espressif/espidf.constraints.v5.1.txt
Requirement files:
 - /home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/tools/requirements/requirements.core.txt
Python being checked: /home/jeremy/.espressif/python_env/idf5.1_py3.8_env/bin/python
CMake Error at /home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/tools/cmake/build.cmake:540 (message):
  ERROR: Cannot establish a connection to the component registry.  Are you
  connected to the internet?

Call Stack (most recent call first):
  /home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/tools/cmake/project.cmake:547 (idf_build_process)
  CMakeLists.txt:14 (project)

-- Configuring incomplete, errors occurred!
See also "/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/build/CMakeFiles/CMakeOutput.log".

More Information.
No response

compote version: 1.4.1

There is a dependencies.lock, see attached (with .txt added for Github).  The versions are pinned so there shouldn't be any need to go out to the Internet.

There is no idf_component_manager.yml in ~/.espressif

dependencies.lock.txt

@readmodifywrite Thank you for your responses,

Do you have espressif__mdns directory in mananged_components of your project?
Did you change the target or ESP-IDF version since the last successful CMake run?

Could you please update the component manager by running pip install -U idf-component-manager  in your ESP-IDF shell? We improved network related error messages recently.

Yes, it is in managed_components.
No changes to target or IDF version, when I filed this report.
However, I am now experimenting with v5.2. I will update if this issue persists.
I cannot run the pip command now that I've updated to 5.2:
jeremy@Saturn:~/JEREMY/Twine/firmware/pickup_firmware/esp-idf$ pip3 install -U idf-component-manager
bash: /home/jeremy/.espressif/python_env/idf5.2_py3.8_env/bin/pip3: /home/jeremy/.espressif/python_env/idf5.1_py3.8_env/bin/python: bad interpreter: No such file or directory
See this issue: https://github.com/espressif/esp-idf/issues/13196
5.2 screws up the Python venv.  I managed to work around it to get builds working, but it looks like that breaks other things that are less obvious to fix.

So, to work around all of this, would it not make more sense to just directly copy the MDNS source into my project, and get rid of the component manager entirely?
I really don't see the value of the component manager at all, especially since it is creating more problems than it solves.
We never want components to auto update during a build in the embedded world.
Why not just put MDNS in the esp-idf/components like everything else?  The component manager is just extra overhead for nothing.  What is the actual use case here?

Ok, so you can't just manually include the MDNS source in your project, even after also adding the Kconfig to get the #defines for the configuration.  It will still break with a ton of random errors, see below.
This whole component manager thing seems to be designed to be impossible to get rid of.
I want to manually build mDNS in my project. I do not want to use the component manager (none of the handful of other "components" are of any use to me anyway).  I have no reason to deal with this extra baggage in my builds.
How do I get a component to build manually in my project?  The component manager is doing some kind of extra processing that doesn't appear to be documented anywhere.
Build error log below:
In file included from /home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/mdns_networking_lwip.c:12:
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/mdns_networking_lwip.c: In function 'udp_recv':
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:265:27: error: format '%d' expects argument of type 'int', but argument 7 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
265 | #define LOG_COLOR(COLOR)  "\033[0;" COLOR "m"
|                           ^~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:268:27: note: in expansion of macro 'LOG_COLOR'
268 | #define LOG_COLOR_E       LOG_COLOR(LOG_COLOR_RED)
|                           ^~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:282:37: note: in expansion of macro 'LOG_COLOR_E'
282 | #define LOG_FORMAT(letter, format)  LOG_COLOR ## letter #letter " (%" PRIu32 ") %s: " format LOG_RESET_COLOR "\n"
|                                     ^~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:410:86: note: in expansion of macro 'LOG_FORMAT'
410 |         if (level==ESP_LOG_ERROR )          { esp_log_write(ESP_LOG_ERROR,      tag, LOG_FORMAT(E, format), esp_log_timestamp(), tag, ##VA_ARGS); }
|                                                                                ^~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:432:41: note: in expansion of macro 'ESP_LOG_LEVEL'
432 |         if ( LOG_LOCAL_LEVEL >= level ) ESP_LOG_LEVEL(level, tag, format, ##VA_ARGS);
|                                         ^~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:340:38: note: in expansion of macro 'ESP_LOG_LEVEL_LOCAL'
340 | #define ESP_LOGE( tag, format, ... ) ESP_LOG_LEVEL_LOCAL(ESP_LOG_ERROR,   tag, format, ##VA_ARGS)
|                                      ^~~~~~~~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/private_include/mdns_private.h:162:29: note: in expansion of macro 'ESP_LOGE'
162 | #define HOOK_MALLOC_FAILED  ESP_LOGE(TAG, "Cannot allocate memory (line: %d, free heap: %d bytes)", LINE, esp_get_free_heap_size());
|                             ^~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/mdns_networking_lwip.c:146:13: note: in expansion of macro 'HOOK_MALLOC_FAILED'
146 |             HOOK_MALLOC_FAILED;
|             ^~~~~~~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:265:27: error: format '%d' expects argument of type 'int', but argument 7 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
265 | #define LOG_COLOR(COLOR)  "\033[0;" COLOR "m"
|                           ^~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:269:27: note: in expansion of macro 'LOG_COLOR'
269 | #define LOG_COLOR_W       LOG_COLOR(LOG_COLOR_BROWN)
|                           ^~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:282:37: note: in expansion of macro 'LOG_COLOR_W'
282 | #define LOG_FORMAT(letter, format)  LOG_COLOR_ ## letter #letter " (%" PRIu32 ") %s: " format LOG_RESET_COLOR "\n"
|                                     ^~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:411:86: note: in expansion of macro 'LOG_FORMAT'
411 |         else if (level==ESP_LOG_WARN )      { esp_log_write(ESP_LOG_WARN,       tag, LOG_FORMAT(W, format), esp_log_timestamp(), tag, ##VA_ARGS); }
|                                                                                ^~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:432:41: note: in expansion of macro 'ESP_LOG_LEVEL'
432 |         if ( LOG_LOCAL_LEVEL >= level ) ESP_LOG_LEVEL(level, tag, format, ##VA_ARGS);
|                                         ^~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:340:38: note: in expansion of macro 'ESP_LOG_LEVEL_LOCAL'
340 | #define ESP_LOGE( tag, format, ... ) ESP_LOG_LEVEL_LOCAL(ESP_LOG_ERROR,   tag, format, ##VA_ARGS)
|                                      ^~~~~~~~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/private_include/mdns_private.h:162:29: note: in expansion of macro 'ESP_LOGE'
162 | #define HOOK_MALLOC_FAILED  ESP_LOGE(TAG, "Cannot allocate memory (line: %d, free heap: %d bytes)", LINE, esp_get_free_heap_size());
|                             ^~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/mdns_networking_lwip.c:146:13: note: in expansion of macro 'HOOK_MALLOC_FAILED'
146 |             HOOK_MALLOC_FAILED;
|             ^~~~~~~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/private_include/mdns_private.h:162:101: error: format '%d' expects argument of type 'int', but argument 7 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
162 | #define HOOK_MALLOC_FAILED  ESP_LOGE(TAG, "Cannot allocate memory (line: %d, free heap: %d bytes)", LINE, esp_get_free_heap_size());
|                                                                                ^~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:282:59: note: in definition of macro 'LOG_FORMAT'
282 | #define LOG_FORMAT(letter, format)  LOG_COLOR_ ## letter #letter " (%" PRIu32 ") %s: " format LOG_RESET_COLOR "\n"
|                                                           ^~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:432:41: note: in expansion of macro 'ESP_LOG_LEVEL'
432 |         if ( LOG_LOCAL_LEVEL >= level ) ESP_LOG_LEVEL(level, tag, format, ##VA_ARGS);
|                                         ^~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:340:38: note: in expansion of macro 'ESP_LOG_LEVEL_LOCAL'
340 | #define ESP_LOGE( tag, format, ... ) ESP_LOG_LEVEL_LOCAL(ESP_LOG_ERROR,   tag, format, ##VA_ARGS)
|                                      ^~~~~~~~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/private_include/mdns_private.h:162:29: note: in expansion of macro 'ESP_LOGE'
162 | #define HOOK_MALLOC_FAILED  ESP_LOGE(TAG, "Cannot allocate memory (line: %d, free heap: %d bytes)", LINE, esp_get_free_heap_size());
|                             ^~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/mdns_networking_lwip.c:146:13: note: in expansion of macro 'HOOK_MALLOC_FAILED'
146 |             HOOK_MALLOC_FAILED;
|             ^~~~~~~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/private_include/mdns_private.h:162:101: error: format '%d' expects argument of type 'int', but argument 7 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
162 | #define HOOK_MALLOC_FAILED  ESP_LOGE(TAG, "Cannot allocate memory (line: %d, free heap: %d bytes)", LINE, esp_get_free_heap_size());
|                                                                                ^~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:282:59: note: in definition of macro 'LOG_FORMAT'
282 | #define LOG_FORMAT(letter, format)  LOG_COLOR_ ## letter #letter " (%" PRIu32 ") %s: " format LOG_RESET_COLOR "\n"
|                                                           ^~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:432:41: note: in expansion of macro 'ESP_LOG_LEVEL'
432 |         if ( LOG_LOCAL_LEVEL >= level ) ESP_LOG_LEVEL(level, tag, format, ##VA_ARGS);
|                                         ^~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:340:38: note: in expansion of macro 'ESP_LOG_LEVEL_LOCAL'
340 | #define ESP_LOGE( tag, format, ... ) ESP_LOG_LEVEL_LOCAL(ESP_LOG_ERROR,   tag, format, ##VA_ARGS)
|                                      ^~~~~~~~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/private_include/mdns_private.h:162:29: note: in expansion of macro 'ESP_LOGE'
162 | #define HOOK_MALLOC_FAILED  ESP_LOGE(TAG, "Cannot allocate memory (line: %d, free heap: %d bytes)", LINE, esp_get_free_heap_size());
|                             ^~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/mdns_networking_lwip.c:146:13: note: in expansion of macro 'HOOK_MALLOC_FAILED'
146 |             HOOK_MALLOC_FAILED;
|             ^~~~~~~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:265:27: error: format '%d' expects argument of type 'int', but argument 7 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
265 | #define LOG_COLOR(COLOR)  "\033[0;" COLOR "m"
|                           ^~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:270:27: note: in expansion of macro 'LOG_COLOR'
270 | #define LOG_COLOR_I       LOG_COLOR(LOG_COLOR_GREEN)
|                           ^~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:282:37: note: in expansion of macro 'LOG_COLOR_I'
282 | #define LOG_FORMAT(letter, format)  LOG_COLOR_ ## letter #letter " (%" PRIu32 ") %s: " format LOG_RESET_COLOR "\n"
|                                     ^~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:414:86: note: in expansion of macro 'LOG_FORMAT'
414 |         else                                { esp_log_write(ESP_LOG_INFO,       tag, LOG_FORMAT(I, format), esp_log_timestamp(), tag, ##VA_ARGS); }
|                                                                                ^~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:432:41: note: in expansion of macro 'ESP_LOG_LEVEL'
432 |         if ( LOG_LOCAL_LEVEL >= level ) ESP_LOG_LEVEL(level, tag, format, ##VA_ARGS);
|                                         ^~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:340:38: note: in expansion of macro 'ESP_LOG_LEVEL_LOCAL'
340 | #define ESP_LOGE( tag, format, ... ) ESP_LOG_LEVEL_LOCAL(ESP_LOG_ERROR,   tag, format, ##VA_ARGS)
|                                      ^~~~~~~~~~~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/private_include/mdns_private.h:162:29: note: in expansion of macro 'ESP_LOGE'
162 | #define HOOK_MALLOC_FAILED  ESP_LOGE(TAG, "Cannot allocate memory (line: %d, free heap: %d bytes)", LINE, esp_get_free_heap_size());
|                             ^~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/mdns_networking_lwip.c:146:13: note: in expansion of macro 'HOOK_MALLOC_FAILED'
146 |             HOOK_MALLOC_FAILED;
|             ^~~~~~~~~~~~~~~~~~
In file included from /home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/mdns.c:13:
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp32_firmware/main/mdns/mdns.c: In function 'mdns_mangle_name':
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:265:27: error: format '%d' expects argument of type 'int', but argument 7 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
265 | #define LOG_COLOR(COLOR)  "\033[0;" COLOR "m"
|                           ^~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:268:27: note: in expansion of macro 'LOG_COLOR'
268 | #define LOG_COLOR_E       LOG_COLOR(LOG_COLOR_RED)
|                           ^~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:282:37: note: in expansion of macro 'LOG_COLOR_E'
282 | #define LOG_FORMAT(letter, format)  LOG_COLOR ## letter #letter " (%" PRIu32 ") %s: " format LOG_RESET_COLOR "\n"
|                                     ^~~~~~~~~~
/home/jeremy/JEREMY/Twine/firmware/pickup_firmware/esp-idf/components/log/include/esp_log.h:410:86: note: in expansion of macro 'LOG_FORMAT'
410 |         if (level==ESP_LOG_ERROR )          { esp_log_write(ESP_LOG_ERROR,      tag, LOG_FORMAT(E, format), esp_log_timestamp(), tag, ##VA_ARGS); }
|                                                                                ^~~~~~~~~~
.... truncated.
It is over 6000 lines of this nonsense.

How to fix the build:
Add:
component_compile_options(-Wno-error=format= -Wno-format)
to CMakeLists.txt.
Add the component Kconfig to the project root to get the #defines and menuconfig.
I can confirm that moving the managed component and compiling the source directly fixes this issue.

I want to manually build mDNS in my project. I do not want to use the component manager (none of the handful of other "components" are of any use to me anyway). I have no reason to deal with this extra baggage in my builds.

In this case, the simplest option is to put the mdns component from https://github.com/espressif/esp-protocols/tree/master/components/mdns (or a specific version in that repo) into the components subdirectory of your project.
(The component manager helps with dependency hierarchies more than one level deep, but in your case simply getting the single component you need manually should work.)

Hello @readmodifywrite
Some components are moved out from the ESP-IDF to the component registry to deliver bug fixes and new features, not waiting for the next ESP-IDF release. If you would like to download a single component, you can either clone the repo, as Ivan suggested. Or download an archive from the registry (download archive link in the right-hand bar) and unpack to the components directory of the project.
If you want to turn off the component manager entirely, you can set the environment variable IDF_COMPONENT_MANAGER to 0.
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/tools/idf-component-manager.html?highlight=idf_component_manager#disabling-the-component-manager

Hello @readmodifywrite I accidentally closed this issue yesterday,

We never want components to auto update during a build in the embedded world.

Neither we do! Now, the dependency solver may run on build in a few cases:

No dependencies.lock file.
Some requirements have been modified in the idf_component.yml manifest files
The target has changed.
The IDF version has been updated.

If your case doesn't fall into these categories, it's likely a bug. We'd greatly appreciate your assistance in diagnosing this issue further. Please provide us with the full output of idf.py reconfigure using the latest component manager version (1.5.1) and any ESP-IDF version, if you can still reproduce the problem. And thank you for your collaboration and patience.
Running of solver when the target or IDF version has changed is a necessity because dependencies may be incompatible. We are now working on the fix to only download something when deps are actually incompatible. So likely this will help in your case.
We really want to make a useful tool, not an annoying one, if you wish to help the whole community by giving us more data, it will be very kind from your side.

@jgeertsema I apologize for the confusion. The logic behind it is simple: fullclean command removes most of the files created by the build process. Because the managed_components directory is created during it, the directory is also removed.
During the next run of CMake, it will be recreated. If you already have all the required components in the system-wide cache, no HTTP requests will be performed. You can find the location of the cache by running compote cache path.
A couple of exceptions are sdkconfig and dependencies.lock not removed by full clean.
In which scenario it causes you problems? We will find the best workaround.

@jgeertsema Which version of the component manager are you using? I've tried with the most recent one - v1.5.2 and I wasn't able to reproduce the issue. We had a regression some time ago, though. Could you please try to update? https://docs.espressif.com/projects/idf-component-manager/en/latest/guides/updating_component_manager.html

HINT: Cannot establish a connection to the component registry. Skipping checks of dependency changes.

The component manager checks for known vulnerabilities and bug fixes of the components you have in your projects, however, this process should never break the build. If you want to disable it entirely, you can set IDF_COMPONENT_CHECK_NEW_VERSION environment variable to 0

@jgeertsema

HINT: Cannot establish a connection to the component registry. Skipping checks of dependency changes.

We have a check for the fact if the component was deleted from the registry, and this message from this checker. We are reworking now how we deal with online/offline modes, and the behavior should be much clearer in the next release.

I also am butting into this issue.  In my particular case, I'm trying to build a firmware with ESP-IDF in a Nix environment, but a Nix derivation has no network connection.
@kumekay I can run the build with IDF_COMPONENT_MANAGER=0, but then the dependencies aren't included properly, even if they're already installed to managed_components/ from a previous run.  But if I run with the component manager enabled, then it fails due to the network not being available.
At the very least, if dependencies are already present, the network call should fail silently and non-fatally.

@jonahbron We will change the default behavior in the next feature release

I am having the same issue that I cannot build in VSCODE/ESPIDF if the machine has no access to the component registry. Auto updating components is not a good idea, and I would rather trust developer's knowledge about the components they use rather than going out of your way to make it harder to everyone.

@hsnprojects  It should be fixed in 2.0, you can try this commit: b543e18dd76df29d51a9a481928519ff3a031951 now
https://github.com/espressif/idf-component-manager?tab=readme-ov-file#installing-a-development-version-of-the-component-manager

closing the issue since 2.0.0 has been released.


empty path error: please  print name and exact position

it would be of great help if in case of an empty path error like:
ninja: error: build.ninja:37: empty path

the exact position and empty variable name would be printed out.
Currently the given position is always at the line following the
affected  build statement.

This seems like something that should be relatively easy to make a pull request for. Make sure to get permission from the ninja projects maintainer (which is not me) before doing that though.
I can try to help you identify where in the code the change would need to go, if you want.


Questions about hyperparameters in class MultiDexShadowHandUR

Hi,
Thanks for your excellent work! I have a question about the MultiDexShadowHandUR class in multidex_shadowhand_ur.py. Specifically, the _global_trans_lower and _global_trans_upper attributes are used as hyperparameters to normalize global translations.
Could you please explain how the values for these two parameters were determined? Were they calculated based on specific data, derived from experiments, or set using another method?
I appreciate your time and look forward to your reply. thank you.

If I remember correctly, these values are statistics from MultiDex[1], intented to normalize the data when training the model. However, since quite some time ago, I could not locate where the use of _global_trans_lower and _upper. Could you point me the exact code snippet?
[1]  Li, Puhao, et al. "Gendexgrasp: Generalizable dexterous grasping." 2023 IEEE International Conference on Robotics and Automation (ICRA). IEEE, 2023.
Code is available at https://github.com/tengyu-liu/GenDexGrasp.

Thank you so much for your detailed response and for providing the references! Regarding your question about the usage of _global_trans_lower and _global_trans_upper, I looked into the code, and they are indeed used in the MultiDexShadowHandUR class located in the multidex_shadowhand_ur.py file. Specifically, they are utilized in the trans_normalize and trans_denormalize functions.
trans_normalize: This function normalizes the translation part of each grasp pose from the dataset before feeding it into the model for training.
trans_denormalize: This function converts the normalized values back to their original scale when necessary.
I will also carefully read the paper you provided for a better understanding. Thanks again for your helpful feedback!


PHP8.1 - Explicit octal integer literal notation

PHP8.1 - Add support for explicit octal integer literal notation
(reworded)

Coverage decreased (-0.05%) to 92.298% when pulling 872ee8ce8a81a4b77ebaebb6b6dfb4980119c156 on SpacePossum:master_PHP81_OctalNotationFixer into ef44633652f41467e0ecf7122c8b0e4c6cfa752d on FriendsOfPHP:master.


[Task]: Add unit test case for bind preview

SubTasks

[ ] Check for tooltip on hover for suggested queries
[ ] Check for edit button for queries on hover

Closing as we have deprioritized the issue due to https://github.com/appsmithorg/appsmith/pull/31994#:~:text=pr due to %3A-,%2331112 (comment),-AmanAgarwal041 closed this


Can't create elasticache redis cluster due to the version missconfiguration

What happened?
Hello!
I'm trying to create an ElastiCache Redis cluster:
export const redisCluster = (
  new aws.elasticache.Cluster('foo', {
    engine: 'redis',
    engineVersion: '7.0.7',
    nodeType: 'cache.t4g.micro',
    numCacheNodes: 1,
    parameterGroupName: redisParameterGroup.name,
    subnetGroupName: redisSubnetGroup.name,
    securityGroupIds: [
      redisSecurityGroup.id,
    ],
  })
);

However, I'm getting an error:
error: diffing urn:pulumi:main::acme::aws:elasticache/cluster:Cluster::foo: 1 error occurred:
	* engine_version: Redis versions must match <major>.x when using version 6 or higher, or <major>.<minor>.<bug-fix>

I've tried various values for the engineVersion property, including the: 7, 7.x, 7.0.7, but am getting the various errors like the one above.
Expected Behavior
The cluster should be created with the specified engine version.
Steps to reproduce
Use the code above.
Output of pulumi about
I'm using the Pulumi Cloud.
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @slavafomin,
I apologize for the error you're encountering. It appears to be a bug in the upstream provider, specifically related to an inconsistency in the naming formats for the Redis engine in the AWS API. You can find more information about this issue at https://github.com/hashicorp/terraform-provider-aws/issues/27918. It seems that a fix for this problem is already in progress, and we will closely monitor the situation to ensure the fix is released as soon as possible.
In the meantime, you may find the following reference helpful:

ElastiCache Documentation: Please note that the valid engine versions have different formats depending on the major version, such as

memcached1.4, memcached1.5, memcached1.6, redis2.6, redis2.8, redis3.2, redis4.0, redis5.0, redis6.x, redis6.2, redis7

Thank you for your patience, and we will do our best to resolve this issue swiftly once the fix becomes available.

@rquitales thanks, waiting forward for the fix! However, the redis7 value also doesn't work as a valid version. Is there a workaround that we can use at the moment?

Hi @rquitales, it looks like https://github.com/hashicorp/terraform-provider-aws/issues/27918 has been merged and released in terraform 5.3.0. Do you have an idea of how long it would take for us to see this fix reflected in pulumi as well?

Actually, this seems to just work on the newest pulumi/aws!

Fixed upstream and confirmed to work, so I'll go ahead and close

Same issue here. Any fix?

@newman-dani Could you please open a new issue with a repro?

@mikhailshilkov I was able to overcome the
parsing old engine_version: Malformed version by

Upgrading Redis from AWS console.
Running refresh with "engineVersion": "7.1".
Exporting the stack pulumi stack export --stack my-redis-stack --file ~/Desktop/state.json.
Changing the "engineVersion": "7.x" to be "engineVersion": "7.1".
Re-importing the stack.
Refreshing the state again.


fix: hasLied&hasErrors are undefined

I found a small bug, not expected hasLied and hasErrors.

Nice catch. I will merge this.


Added storage structs for migrations per-version.

An attempt to fix #13024
Related to #13019

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2347492


Network auto focus on hover when bindToWindow is false

When options.keyboard.bindToWindow = false and the network element is just outside view port - hovering the element will cause the viewport to scroll to the element (focusing the canvas).
This behaviour is not always required as it can cause "glitches" if a user accidentally hovers on the element.
I created a PR that adds a skipHighlight option to allow consumers to opt out from this behaviour: #1537
Example of said behaviour: https://jsbin.com/ginolifusi/edit?html,output

@eilonudi


adding guardrails for parsing OS version

adding guardrails for parsing OS version as per discussion
Closes #438

Hey sorry, as per this  we need to run golangci-lint too, i will run it and make required changes if any.

closing due to #736


Fix template missing in docs

Proposed changes

docs(templates): add templates folder to copy:docs grunt
docs: temporarily link materialize -> docs
fix #236

Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

I think we should edit the existing GitHub action to commit the docs to the https://github.com/materializecss/materializecss.github.io instead of to the docs branch... Wdyt? @materializecss/members

@wuda-io to me it looks like it does: https://github.com/materializecss/materialize/pull/243/commits/6a2c6286a15991c27a53ceda0c0148c6a37e9ee4
Did you test it locally?

@wuda-io to me it looks like it does: 6a2c628
Did you test it locally?

yeah, and there's an additional commit 2d0a82e81b536f78758564ad59a6936fe0b3aceb to fix the styling if the user tries to navigate to /materialize/404/not/found.
In the local env it didn't show the 404.html, but it should appear normally in the github.io.


README.md: correct default of rsyslog::confdir

@bastelfreak Looks good to me. What do you think?

Good catch


[testing guide] accepting translations!

Set i18nReady: true for /guides/testing.mdx -- open for business!  :rocket:

👀🎉


[BACKLOG-23006] Add aggregation option for "Percentile - Nearest Rank" to Group By Step in PD

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/groupby/GroupBy.java
  engine/src/main/java/org/pentaho/di/trans/steps/groupby/GroupByMeta.java
  engine/src/main/resources/org/pentaho/di/trans/steps/groupby/messages/messages_en_US.properties

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -0.4% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupBy

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -1.1% :small_red_triangle_down:
Line Change: -1.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -1.8% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

@pentaho-mracine Please review Sir!

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/groupby/GroupBy.java
  engine/src/main/java/org/pentaho/di/trans/steps/groupby/GroupByMeta.java
  engine/src/main/resources/org/pentaho/di/trans/steps/groupby/messages/messages_en_US.properties

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.4% :small_red_triangle_down:
Line Change: -3.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupBy

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -1.1% :small_red_triangle_down:
Line Change: -1.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.systemdata.SystemDataMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -2% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:
Line Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:


Don't request region unless we are on ec2

If we aren't on ec2 (and we are probably using s3) just default to us-east-1

Looks good :+1:

Could we specify the region as an attribute? Seems like a better longterm solution.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@asivitz

Please sign the CLA here.

Oh jeez. I don't have a marketplace account. You can revert my commit, or make a similar commit on a different branch. Or call it an Obvious Fix or whatever.

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

OK.  I have fixed this and it pulls from an attribute.  Please merge.

@ubiquitousthey I think this looks legit.
One note I'd make is that there's a pattern in this library for creating methods that encapsulate the logic behind querying for a variable and responding with 'something' - see examples of instance_availability_zone - which uses this kind of pattern.
You might want to factor that out to a method, then squash commits to give this another go.

@miketheman do you mean something like this?
Looking up the region is a bit different from the other query_*-based stuff because it's not a separate query (the region is parsed out of the availability zone).

@mkantor I think I see your point - as well as adding the extra method may fail itself.
I guess if this is squashed, we can proceed.

@ubiquitousthey any chance you can make it happen please? :pray:

OK.  See PR #160 for the squashed commits

Closing this in favor of #160.


Return error instead of killing process

Rather than kill the whole load test (which is what log.Fatal does), proposing to delegate error handling so user can decide on:

retry policy
tracking error/retry metrics
finer-grained error handling policy

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Valentin Vakar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @pablochacin, point well taken! I'll make that change.

Updated. It's very odd, but I can't seem to get any CommandOptions with names longer than 4 characters going through...

Thanks for approving @pablochacin! Pls note - I don't have write access to merge the PR.


Reprocess options after debounce

There could be times where function based options are time sensitive and need to be computed right before we call validate. Unfortunately this means having to call processOptions twice.

@stefanpenner any thoughts on this?
The first requirement for processing the options is to get the debounce value which can be a function, the second time is to make sure that options are processes right before validate is called.


fix: do not report diff on adminstate_config when in registered state

Do not report diff on admin state when edge node is in REGISTERED state.

Could you make sure this is not breaking existing behavior?

Could you make sure this is not breaking existing behavior?

It actually should. The existing behavior is simply wrong. Unfortunately, there are no tests and writing one for this 'deprecated' version is not worth the effort imo.
The problem is, that this field admin_state can be set by the client, e.g. to ACTIVE but is set to REGISTERED state only by zedcloud once the edge-node is oboarded. This makes updating the local config manually required which counters the whole nature of automation for big amounts of edge-nodes. So client sets to ACTIVE, zedcloud onboards automatically and state is set to REGISTERED. Then terraform client config is out of sync. So we ignore this case when calculating diff. (edited)

I think we need to be sure this is not breaking some customer workflow.
i would like to loop in the systest team before releasing this.

@ ppal-zededa could you have a look?


Add support for import defer proposal

This proposal is currently at Stage 2.7: the last changes have been approved at the TC39 meeting last week, and I'm planning on proposing Stage 3 at the TC39 meeting on February 18th (the only blocker is me finishing writing test262 tests, and they will for sure be ready by then). I'm already opening this PR because, depending on when TS5.8 will be released, it's possible that the proposal will already be at Stage 3 by then :)
This PR only needs to add parsing support for the proposal:

it does not support downleveling it, as it's not possible to transpile it to older ESM versions

it would be possible add support for transpiling to CommonJS, if needed.

it does not introduce any type-checking changes, as the object created by import defer * as ns is meant to "look like" the one created by import * as ns

As you'll see from the code, whether a module is deferred or not is not a boolean but an enum. That's because of the import source proposal: there is no PR for it yet, but once it will be implemented it should be done by adding one more possible "import phase" to this enum. A question I have is if that should be an enum, or just an union of undefined | DeferKeyword (which will one day become undefined | DeferKeyword | SourceKeyword).
Fixes https://github.com/microsoft/TypeScript/issues/59391
This patch was originally written by @ryzokuken

I would expect that these need to be modifiers so that they are nodes that can be walked, since people can stick comments between them and so on...

Modifiers would precede the import here, so it's a bit more iffy than that. But I guess the export @decorator class C {} thing has already made things iffy between decorators/modifiers, and @rbuckton recalls how we handled this.
But this is close syntactically to import type, which just gets an isTypeOnly property slapped on, and hasn't caused issues. When we do need to hydrate nodes in the language service, we'll end up with a synthesized defer node. So from a technical standpoint, I think it's doesn't cause issues, but it might not be the best represenation long-term.

But this is close syntactically to import type, which just gets an isTypeOnly property slapped on, and hasn't caused issues.

We have emitTokenWithComment to handle synthetic punctuation and comments, so that's fine. IMO we should just use SyntaxKind instead of a separate enum, as I suggested above.

That said, ImportClause is parsed after the import keyword, so it could have modifiers and we could just make type a modifier with isTypeOnly existing purely for back-compat purposes. That would require a lot of additional complexity in how we handle modifiers, however, as we'd have to have grammar checks to disallow type, defer, and source as modifiers for most elements.

I updated the PR to go with the suggestion in https://github.com/microsoft/TypeScript/pull/60757#discussion_r1884548891, which is what I found the cleanest. Happy to do differently if needed. The API change is now backwards compatible. Probably I should do the same change for exports? Even though export defer and export source don't exist, so it's only for type.
I also added a test showing that comments are properly preserved.


[CLI] The vaults command is not working as expected

Bug Report
Expected behavior/code
The vaults command proposed by Arnold CLI is supposed to perform global actions for all namespace vaults.
For example, we should be able to decrypt all vaults for the application edxapp in all namespaces with the following command :
$> bin/arnold vaults -a edxapp decrypt
Actual Behavior
The command fails with the following error :
ERROR    You need to set both the ARNOLD_CUSTOMER and ARNOLD_ENVIRONMENT environment variables (see usage).
Steps to Reproduce

bin/arnold vaults -a edxapp decrypt

Environment

Arnold version: master branch
Platform: linux

I think we should update the command description to restrict performed actions to the current namespace?

Hmm yes indeed :+1:
I didn't understand it this way, I had another use case in mind.


Profiler metrics are not formatted correctly

[ ] Large numbers are not formmatted correctly with the coma speration

[ ] decimal numbers are not turned into percentage in the column detail view

[ ] column value count metric is not coma seperated
[ ] On graph hover metrics are not coma seperated

column value count metric is not coma separated
earlier we have added coma separated value but with this issue we have change the value

can you confirm what is the expected behaviour here?
cc @pmbrull

@ShaileshParmar11  we are expecting thousands to be coma separated (e.g 1,500,000). In the screenshots you can see the thousands separation is not correct. It is 1,50,000 instead of being 150,000.


Unreachability check within conditional-expr

Description:
With https://github.com/ballerina-platform/ballerina-lang/pull/31797 unreachability check is introduced for the if-else-stmt.
function printTrue() {
    if true {
        io:println(1);
    } else {
        io:println(-1); // throw a compiler error saying code unreachable
    }
}

Should we support the same for Conditional expressions?
_ = true ? io:println(1) : io:println(-1);

Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Need to verify this based on https://github.com/ballerina-platform/ballerina-spec/issues/887#issuecomment-991825589 and the last sentence in the spec.


Collecting coins and getting to the goal without dying to a trap or enemy.
How do you play your game?
Press WASD to move. You start in the top left corner. The goal is to collect all 7 coins and get to the orange goal without going onto a moving pink enemy or a blue trap. You will then proceed to the next level. There are 7 levels.
Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)
No image used.

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

Really cool game with interesting game mechanics, the coins as a collectible to works well! If you're a teenager, and you haven't already received a Sprig device, feel free to fill out this form to receive one! Also, feel free to join Hack Club's Slack in the #sprig channel to share your creation w/ others!


Update twitter dependency to 5.14.0

This is a security fix. chatterbot requires on twitter-5.8.0, which requires http 5.1.0, which is vulnerable to CVE-2015-1828.
Relevant twitter issue: https://github.com/sferik/twitter/issues/672
Vuln info: https://groups.google.com/forum/#!topic/ruby-security-ann/OLZxzGAFBig
Reason for the change in blocklist.rb is because Twitter::NullObject responds true to any method as of 5.14.0:
https://github.com/sferik/twitter/commit/cd32e310610edb5d3e88d1e13fd8d5de8876e2b1#diff-bb8c95cbf19e6d723329bd49aa104600

Thanks!


execute fall

Dear everyone,i have facing  a question:
I created a work on azkaban,sometimes when running the flow, it'll suspend by preparing,i tryed to cchange my configuration file,But it doesn't work.And my machian with 16 cores,256GB memory,so it's not bucause of computer.
I saw the logs:Flow XXX is already running. Skipping execution. But i'm sure last flow was runed success for long times.
What puzzled me is after half ~ 2hours,it'll go on and have success .
Who can help me solve this problem？

Dear everyone,i have facing a question:
I created a work on azkaban,sometimes when running the flow, it'll suspend by preparing,i tryed to cchange my configuration file,But it doesn't work.And my machian with 16 cores,256GB memory,so it's not bucause of computer.
I saw the logs:Flow XXX is already running. Skipping execution. But i'm sure last flow was runed success for long times.
What puzzled me is after half ~ 2hours,it'll go on and have success .
Who can help me solve this problem？

The preparation status of the workflow is waiting for the release of resources, which mainly depends on resources in three dimensions: CPU, memory, thread pool. Configured in azkaban.properties of the webserver, please ensure that there are sufficient resources
The log information indicates that the current workflow is running, so this execution is skipped. Please ensure that the execution id of this workflow is not in the list of currently running workflows in jmx


Update Heading During Month Changes

Prerequisites

[ ] Using an up-to-date main branch

Expected Behavior
When on a week that spans multiple months, the label heading label should display both months in the following format:
'ShortenedMonth 1 - ShortenedMonth 2 YYYY'

For example: "Jun - Jul 2024"

When the week spans multiple years (Dec-Jan), the label should change to:
'Dec YYYY - Jan YYYY'

Current Behavior

Notice: It says "December 2023", when the current day is actually January 2024, which is misleading for people like me who forget what year it is

Steps to Reproduce

Hard-code the today value to in useToday.ts to 2024-01-04: const today = dayjs("2024-01-04");

Notice: Month label is December 2023. It should be 'Dec 23 - Jan 24'

Repeat process for other month changes (eg set today to 2024-02-01)

Possible Solution (Not obligatory)

Compare the month's of start and end of view date objects
When they're different, use the new format

Context

Required: Please write unit tests to confirm the new label logic works as expected

@AzharAhmed-bot is working on this one

Moving this back to 'Todo' due to inactivity -- consider this up-for-grabs for anyone else interested!

Closing in favor of #165


Memory/CPU/HD requirements

Can you talk about memory requirements? As this is a proxy and no CPU math is done here, does a 512 MB RAM, 1 vCPU is enough?

CPU is done here for share validation. Must be ok on this configuration, depends on hashrate. But you need to run a daemon like geth || parity so you need a multi core Xeon with 16+ GB RAM for it.

Ok, so to be clear. For a proxy a 512MB RAM, 1 vCPU is enough? (geth will be running in another machine)
What about HD, does this proxy uses lot of space (comparing it with geth). Please elaborate.

Should be ok. No space required.


Session create throttling.  This ensures that we never attempt to cre…

…ate too many sessions concurrently.
Creating too many sessions concurrently can result in severe perf penalties server side (on the order of several seconds if several hundred sessions are created in one go).  This change throttles all session creates to ensure this cannot happen.

Also -- this is another candidate for something that would be nice to do in an ApiCall interceptor.

I may not get able to get to this one until tomorrow, FYI


require in go.mod github.com/DataDog/zstd v1.3.6-0.20190409195224-796139022798 does not exist

Versions
Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.
Sarama Version:1.22.1
Kafka Version:
Go Version:
Configuration
What configuration values are you using for Sarama and Kafka?
Logs
When filing an issue please provide logs from Sarama and Kafka if at all
possible. You can set sarama.Logger to a log.Logger to capture Sarama debug
output.
Problem Description
https://github.com/DataDog/zstd/tags

Thanks for reporting @zhaoying818


Feature/store elements

Hi @randrescastaneda!
This PR provides a first version of cache for testing.  I have added some examples on the README.md to give an idea of the range of current functionalities.  I have done preliminary testing and this seems to be working reasonably well, though I will continue with bug testing in a wider range of cases.  I think I need to do some more tests with frames in particular where there might be some minor issues.
For the moment, I will keep testing and build in a few more options that are flagged as pending on the README, but I am issuing a PR now so that you can have a look if you want, and see if you want to try some initial tests too.
Best wishes,
Damian

Hi @damiancclarke,
The package is looking great. Thank you!
I made a few additions and modifications. Please let me know if you agree with them. I also added a small comment to ensure I understand correctly. If everything looks good to you, please go ahead and merge.
Thank you very much.
Best,


Support for other response types then code & token

Allow for injection of CustomResponseTypesHandler in the
AuthorizationEndpoint to support for other response types other then
the default 'code' and 'token'.
The CustomResponseTypesHandler can be configured using
AuthorizationServerEndpointsConfigurer#customResponseTypesHandler or
using xml style with a custom-response-types-handler-ref on the
oauth2:authorization-code.
Resolves #626

The https://travis-ci.org/spring-projects/spring-security-oauth/builds/91321307 build fails, but it seems totally unrelated to my code. Also locally when running mvn clean test -P bootstrap everything is green. False negative?

@oharsta Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@pivotal-issuemaster , I already signed the Contributor License Agreement some time ago. See https://github.com/spring-projects/spring-security-oauth/pull/50. My confirmation number is<PHONE_NUMBER>1014936.

👍  !

@oharsta Thank you for signing the Contributor License Agreement!

Closing as this is stale and needs rebased. If this is still valid, please rebase and submit an additional PR


Hide optional flags when a command has too many options

The usage string feature that only shows positional args and required options/flags was incorrectly allowing through flags with type Bool?. For example, --enable-foo was incorrectly visible in the usage string for this type:
struct Example: ParsableCommand {
    // so many options
    // too many options

    @Flag(inversion: .prefixedEnableDisable)
    var foo: Bool?
}

Checklist

[x] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

@swift-ci Please test

@swift-ci Please test


python310Packages.openai: 0.27.9 -> 0.28.0

Description of changes
Update to latest version. No changes that effect build.
Diff: https://github.com/openai/openai-python/compare/refs/tags/v0.27.9...v0.28.0
Changelog: https://github.com/openai/openai-python/releases/tag/v0.28.0
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 252420 run on x86_64-darwin 1

4 packages marked as broken and skipped:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist
khoj
khoj.dist

2 packages failed to build:

python310Packages.minichain
python310Packages.minichain.dist

14 packages built:

chatblade
chatblade.dist
checkov
checkov.dist
openai (python310Packages.openai)
openai.dist (python310Packages.openai.dist)
python310Packages.guidance
python310Packages.guidance.dist
python311Packages.guidance
python311Packages.guidance.dist
python311Packages.openai
python311Packages.openai.dist
shell-genie
shell-genie.dist

Result of nixpkgs-review pr 252420 run on aarch64-darwin 1

4 packages marked as broken and skipped:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist
khoj
khoj.dist

2 packages failed to build:

checkov
checkov.dist

14 packages built:

chatblade
chatblade.dist
openai (python310Packages.openai)
openai.dist (python310Packages.openai.dist)
python310Packages.guidance
python310Packages.guidance.dist
python310Packages.minichain
python310Packages.minichain.dist
python311Packages.guidance
python311Packages.guidance.dist
python311Packages.openai
python311Packages.openai.dist
shell-genie
shell-genie.dist

Result of nixpkgs-review pr 252420 run on aarch64-linux 1

2 packages marked as broken and skipped:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist

20 packages built:

chatblade
chatblade.dist
checkov
checkov.dist
home-assistant-component-tests.openai_conversation
imaginer
khoj
khoj.dist
openai (python310Packages.openai)
openai.dist (python310Packages.openai.dist)
python310Packages.guidance
python310Packages.guidance.dist
python310Packages.minichain
python310Packages.minichain.dist
python311Packages.guidance
python311Packages.guidance.dist
python311Packages.openai
python311Packages.openai.dist
shell-genie
shell-genie.dist

Result of nixpkgs-review pr 252420 run on x86_64-darwin 1

4 packages marked as broken and skipped:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist
khoj
khoj.dist

2 packages failed to build:

python310Packages.minichain
python310Packages.minichain.dist

14 packages built:

chatblade
chatblade.dist
checkov
checkov.dist
openai (python310Packages.openai)
openai.dist (python310Packages.openai.dist)
python310Packages.guidance
python310Packages.guidance.dist
python311Packages.guidance
python311Packages.guidance.dist
python311Packages.openai
python311Packages.openai.dist
shell-genie
shell-genie.dist

Result of nixpkgs-review pr 252420 run on aarch64-darwin 1

4 packages marked as broken and skipped:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist
khoj
khoj.dist

2 packages failed to build:

checkov
checkov.dist

14 packages built:

chatblade
chatblade.dist
openai (python310Packages.openai)
openai.dist (python310Packages.openai.dist)
python310Packages.guidance
python310Packages.guidance.dist
python310Packages.minichain
python310Packages.minichain.dist
python311Packages.guidance
python311Packages.guidance.dist
python311Packages.openai
python311Packages.openai.dist
shell-genie
shell-genie.dist

Result of nixpkgs-review pr 252420 run on aarch64-linux 1

8 packages marked as broken and skipped:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist
openai-full
openai-full.dist
pentestgpt
pentestgpt.dist
python310Packages.langchain
python310Packages.langchain.dist

20 packages built:

chatblade
chatblade.dist
checkov
checkov.dist
home-assistant-component-tests.openai_conversation
imaginer
khoj
khoj.dist
openai (python310Packages.openai)
openai.dist (python310Packages.openai.dist)
python310Packages.guidance
python310Packages.guidance.dist
python310Packages.minichain
python310Packages.minichain.dist
python311Packages.guidance
python311Packages.guidance.dist
python311Packages.openai
python311Packages.openai.dist
shell-genie
shell-genie.dist

@SuperSandro2000, can you merge if this looks good to you?

Closing since #253110 was merged.


Make use of CRD status subresource

See: https://github.com/knative/build/pull/516
This will allow us to drop the webhook generation logic in knative/pkg in future releases
For context here's a comment about the migration path to drop this webhook logic in knative/serving

Note just in case someone comes across this later: I ran into trouble after this change because my kubectl was too old and there was some outdated client side validation that failed, so I needed to update kubectl.


Updates Ingress API providerParameters field to be a pointer

https://github.com/openshift/api/pull/672 added the providerParameters field. Although this field is marked +optional, the type is a value and therefore required. This PR updates providerParameters to be a pointer so the field is no longer required.

/assign @Miciah @knobunc

Thanks!
/lgtm
But someone with better knowledge of the API machinery and with permission to approve will need to /approve the PR.

/cc @deads2k @sttts

/approve


[Image] Image map support for image component

adds condition to noscript unwrap logic such that responsive map resize is enabled even if there are no widths defined (as is the case for SVG images), and lazy loading is disabled (the default).
updates ui-js test cases.

Q
A

Fixed Issues?
Fixes #35

Patch: Bug Fix?

Minor: New Feature?

Major: Breaking Change?

Tests Added + Pass?
Yes

Documentation Provided
N/A

Any Dependency Changes?

License
Apache License, Version 2.0

Codecov Report

Merging #203 into development will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             development     #203   +/-   ##
==============================================
  Coverage          82.68%   82.68%
  Complexity           787      787
==============================================
  Files                 73       73
  Lines               2541     2541
  Branches             462      462
==============================================
  Hits                2101     2101
  Misses               176      176
  Partials             264      264

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50850db...99aa0e0. Read the comment docs.


Typo fix

:tada: This PR is included in version 2.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update index.html to include vieport

Naming Rules
Name your PR like this: ISSUENUMBER-TITLE-YOURNAME
Description
Write a summary of your change. Explain why you have made it.
Related to
Make sure you include the issue number with a hash sign # so Github can link this PR to the right issue, like this:
Fixes #1
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have carefully reviewed my own code
[ ] I have commented my code
[ ] I have updated any documentation

Included in https://github.com/CodeYourFuture/cyf-final-project-starter-kit/commit/25ad53673e2eea687464e512e8bcfc6baf029d79, thanks for the suggestion


rabbitmq: Override PATH so rabbitmqctl works as expected

recheck

recheck

recheck

openstack-operator-crc-podified-edpm-baremetal and openstack-operator-crc-podified-edpm-deployment jobs have succeeded independently across separate test attempts.  Overriding Zuul.

/test openstack-operator-build-deploy-kuttl

Debug pods used for CRC storage cleanup keep hiccuping during testing.
/test openstack-operator-build-deploy-kuttl

/test openstack-operator-build-deploy-kuttl

Unable to connect to the server: read tcp <IP_ADDRESS>:51860-><IP_ADDRESS>:6443: read: connection reset by peer

/test openstack-operator-build-deploy-kuttl

@jeckersb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name 	Commit 	Details 	Required 	Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 	c63d1e3 link 	true 	/test openstack-operator-build-deploy-kuttl
Full PR test history. Your PR dashboard.

This time the bundle failed to build, which has succeeded on all previous attempts...
+ echo 'Build openstack-operator-bundle failed to complete. Current status is Running. Aborting...'
Build openstack-operator-bundle failed to complete. Current status is Running. Aborting...

We just can't win here :)
/test openstack-operator-build-deploy-kuttl


Set display in bgfx platform data

Fixes a crash when creating a BGFX window on linux.
It's calling XGetXCBConnection(nullptr) if the display is not set in the platform data
Simplified SDL_GetNativeWindowPtr definition a bit to remove the specific types, since they're not used anyways

Does this fix sporadic linux CI failure too ? Not sure though , as that is more VM related maybe

Don't think so, I think I encountered this because I built linux with the vulkan BGFX backend.