Bot fails to start after update to v1.3.0

Describe the bug
After updating to v1.3.0 the bot does not start in the emulator.

Publishing to azure is still going fine

Version
1.3.0
Browser

[ ] Electron distribution
Chrome
[ ] Safari
[ ] Firefox
Edge

OS

[ ] macOS
Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Open bot
Click on start bot or restart bot

Expected behavior
Bot opens in emulator
Screenshots

Additional context

Having the same problem. Cannot find any logs that might help solve the problem. Has ground the project to a halt.

@ysnoek2 @JohnRobertGreen Could you help try the following steps to get more logs?

go to the project settings page and toggle "Use custom runtime"

F
after the runtime is placed in your bot folder, go to that folder and run "dotnet build" in cmd tool. For example:
C:\Users\luhan\EchoBot-19\runtime>dotnet run --project azurewebapp

And then paste the error messages here. Thanks a lot!

Apologies but I've downgrade to Composer 1.21 to keep my project moving. I'll try to re-produce the issue in the next or so.

Have you tried exporting the runtime, and running the solution from Visual Studio?  (when I've seen this exception, i've been able to gather more information via running from Visual Studio)

@luhan2017 I followed your steps and tried connecting manually with the emulator and got this exeption:
PS C:\Users\snoekya\Desktop\Stage\BotComposer_project\Isabot\runtime> dotnet run --project azurewebapp
C:\Users\snoekya\Desktop\Stage\BotComposer_project\Isabot\runtime\azurewebapp\Microsoft.BotFramework.Composer.WebApp.csproj : warning
NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2
, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the
project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project.
C:\Users\snoekya\Desktop\Stage\BotComposer_project\Isabot\runtime\core\Microsoft.BotFramework.Composer.Core.csproj : warning NU1701:
Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFra
mework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project t
arget framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project. [C:\Users\snoekya\Desktop\St
age\BotComposer_project\Isabot\runtime\azurewebapp\Microsoft.BotFramework.Composer.WebApp.csproj]
C:\Users\snoekya\Desktop\Stage\BotComposer_project\Isabot\runtime\azurewebapp\Microsoft.BotFramework.Composer.WebApp.csproj : warning
NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2
, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the
project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project.
C:\Users\snoekya\Desktop\Stage\BotComposer_project\Isabot\runtime\core\Microsoft.BotFramework.Composer.Core.csproj : warning NU1701:
Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFra
mework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project t
arget framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.
info: Microsoft.Hosting.Lifetime[0]
Now listening on: http://localhost:3979
info: Microsoft.Hosting.Lifetime[0]
Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
Hosting environment: Development
info: Microsoft.Hosting.Lifetime[0]
Content root path: C:\Users\snoekya\Desktop\Stage\BotComposer_project\Isabot\runtime\azurewebapp
info: Microsoft.AspNetCore.Hosting.Diagnostics[1]
Request starting HTTP/1.1 POST http://localhost:3979/api/messages application/json 626
info: Microsoft.AspNetCore.Routing.EndpointMiddleware[0]
Executing endpoint 'Microsoft.BotFramework.Composer.WebAppTemplates.Controllers.BotController.PostAsync (Microsoft.BotFramework
.Composer.WebApp)'
info: Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker[3]
Route matched with {action = "Post", controller = "Bot"}. Executing controller action with signature System.Threading.Tasks.Tas
k PostAsync() on controller Microsoft.BotFramework.Composer.WebAppTemplates.Controllers.BotController (Microsoft.BotFramework.Compose
r.WebApp).
info: Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker[1]
Executing action method Microsoft.BotFramework.Composer.WebAppTemplates.Controllers.BotController.PostAsync (Microsoft.BotFrame
work.Composer.WebApp) - Validation state: Valid
info: Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker[2]
Executed action Microsoft.BotFramework.Composer.WebAppTemplates.Controllers.BotController.PostAsync (Microsoft.BotFramework.Com
poser.WebApp) in 922.6087ms
info: Microsoft.AspNetCore.Routing.EndpointMiddleware[1]
Executed endpoint 'Microsoft.BotFramework.Composer.WebAppTemplates.Controllers.BotController.PostAsync (Microsoft.BotFramework.
Composer.WebApp)'
fail: Microsoft.AspNetCore.Server.Kestrel[13]
Connection id "0HM5BT3PP82NS", Request id "0HM5BT3PP82NS:00000001": An unhandled exception was thrown by the application.
System.ArgumentNullException: Value cannot be null. (Parameter 'clientSecret')
at Microsoft.IdentityModel.Clients.ActiveDirectory.ClientCredential..ctor(String clientId, String clientSecret)
at Microsoft.Bot.Connector.Authentication.MicrosoftAppCredentials.b__14_0()
at System.Lazy1.ViaFactory(LazyThreadSafetyMode mode)    at System.Lazy1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
at System.Lazy1.CreateValue()    at System.Lazy1.get_Value()
at Microsoft.Bot.Connector.Authentication.AppCredentials.b__36_0()
at System.Lazy1.ViaFactory(LazyThreadSafetyMode mode) --- End of stack trace from previous location where exception was thrown ---    at System.Lazy1.CreateValue()
at System.Lazy1.get_Value()    at Microsoft.Bot.Connector.Authentication.AppCredentials.GetTokenAsync(Boolean forceRefresh)    at Microsoft.Bot.Connector.Authentication.AppCredentials.ProcessHttpRequestAsync(HttpRequestMessage request, CancellationToken can cellationToken)    at Microsoft.Bot.Connector.Conversations.ReplyToActivityWithHttpMessagesAsync(String conversationId, String activityId, Activity a ctivity, Dictionary2 customHeaders, CancellationToken cancellationToken)
at Microsoft.Bot.Connector.ConversationsExtensions.ReplyToActivityAsync(IConversations operations, String conversationId, String a
ctivityId, Activity activity, CancellationToken cancellationToken)
at Microsoft.Bot.Builder.BotFrameworkAdapter.SendActivitiesAsync(ITurnContext turnContext, Activity[] activities, CancellationToke
n cancellationToken)
at Microsoft.Bot.Builder.TurnContext.<>c__DisplayClass30_0.<g__SendActivitiesThroughAdapter|1>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at Microsoft.Bot.Builder.TurnContext.SendActivityAsync(IActivity activity, CancellationToken cancellationToken)
at Microsoft.Bot.Builder.TurnContext.SendActivityAsync(String textReplyToSend, String speak, String inputHint, CancellationToken c
ancellationToken)
at Microsoft.BotFramework.Composer.WebAppTemplates.Startup.<>c__DisplayClass12_0.<b__0>d.MoveNext() in C:\Users\sno
ekya\Desktop\Stage\BotComposer_project\Isabot\runtime\azurewebapp\Startup.cs:line 122
--- End of stack trace from previous location where exception was thrown ---
at Microsoft.Bot.Builder.BotAdapter.RunPipelineAsync(ITurnContext turnContext, BotCallbackHandler callback, CancellationToken canc
ellationToken)
at Microsoft.Bot.Builder.BotFrameworkAdapter.ProcessActivityAsync(ClaimsIdentity claimsIdentity, Activity activity, BotCallbackHan
dler callback, CancellationToken cancellationToken)
at Microsoft.Bot.Builder.BotFrameworkAdapter.ProcessActivityAsync(String authHeader, Activity activity, BotCallbackHandler callbac
k, CancellationToken cancellationToken)
at Microsoft.Bot.Builder.Integration.AspNet.Core.BotFrameworkHttpAdapter.ProcessAsync(HttpRequest httpRequest, HttpResponse httpRe
sponse, IBot bot, CancellationToken cancellationToken)
at Microsoft.BotFramework.Composer.WebAppTemplates.Controllers.BotController.PostAsync() in C:\Users\snoekya\Desktop\Stage\BotComp
oser_project\Isabot\runtime\azurewebapp\Controllers\BotController.cs:line 38
at lambda_method(Closure , Object )
at Microsoft.Extensions.Internal.ObjectMethodExecutorAwaitable.Awaiter.GetResult()
at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.AwaitableResultExecutor.Execute(IActionResultTypeMapper mapper, Ob
jectMethodExecutor executor, Object controller, Object[] arguments)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.g__Logged|12_1(ControllerActionInvoker
invoker)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.g__Awaited|10_0(ControllerActionIn
voker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompl
eted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.g__Awaited|13_0(ControllerActionInvoker
invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|19_0(ResourceInvoker invoker, Tas
k lastTask, State next, Scope scope, Object state, Boolean isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Logged|17_1(ResourceInvoker invoker)
at Microsoft.AspNetCore.Routing.EndpointMiddleware.g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger lo
gger)
at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication`1 application)
info: Microsoft.AspNetCore.Hosting.Diagnostics[2]
Request finished in 1010.8007ms 500

Downloading the 3.1 .NET Core sdk did the trick for my project!
https://dotnet.microsoft.com/download/dotnet-core/thank-you/sdk-3.1.404-windows-x64-installer

Downloading the 3.1 .NET Core sdk did the trick for my project!
https://dotnet.microsoft.com/download/dotnet-core/thank-you/sdk-3.1.404-windows-x64-installer

.NET sdk 3.1 is a requirement, so that is expected, however, the [object object] error message appears to be a potential bug.

.NET sdk 3.1 is a requirement, so that is expected, however, the [object object] error message appears to be a potential bug.

.NET sdk 3.1 is a requirement, so that is expected, however, the [object object] error message appears to be a potential bug.

According to the MSFT Bot documentation only the runtime is required note there are 2 separate downloads https://dotnet.microsoft.com/download
Create a bot with .Net:   https://docs.microsoft.com/en-us/azure/bot-service/dotnet/bot-builder-dotnet-sdk-quickstart?view=azure-bot-service-4.0
Prerequisites
ASP.NET Core Runtime 3.1
Bot Framework Emulator
Knowledge of ASP.NET Core and asynchronous programming in C#
Maybe it would be a good idea to change it there to the SDK?
ASP.NET Core Runtime 3.1 SDK

.NET sdk 3.1 is a requirement, so that is expected, however, the [object object] error message appears to be a potential bug.

According to the MSFT Bot documentation only the runtime is required note there are 2 separate downloads https://dotnet.microsoft.com/download
Create a bot with .Net:   https://docs.microsoft.com/en-us/azure/bot-service/dotnet/bot-builder-dotnet-sdk-quickstart?view=azure-bot-service-4.0
Prerequisites
ASP.NET Core Runtime 3.1
Bot Framework Emulator
Knowledge of ASP.NET Core and asynchronous programming in C#
Maybe it would be a good idea to change it there to the SDK?
ASP.NET Core Runtime 3.1 SDK

@VanyLaw , could you help check the error log logic in the local publish extension? we should show meaningful error log instead of [object object].

@VanyLaw , could you help check the error log logic in the local publish extension? we should show meaningful error log instead of [object object].


Mapping from figma.enum / variant property to enum in React code does not work as expected

I'm not sure if I'm misunderstanding the documentation or if this is a bug or limitation of some kind.
Based on this example from the React README:
// maps the 'Options' variant in Figma to enum values in code
figma.enum('Options', {
  'Option 1': Option.first,
  'Option 2': Option.second,
})

Here's a stripped down version of the code connect file to try to isolate the issue:
figma.connect(
  ButtonPrimary,
  "https://www.figma.com/design/this-is-not-a-real-link",
  {
    props: {
      text: figma.string("text"),
      iconLocation: figma.enum("iconLocation", {
        left: IconLocation.LEFT,
        right: IconLocation.RIGHT,
        none: IconLocation.NONE
      })
    },
    example: (props) => <ButtonPrimary
      buttonText={props.text}
      iconSide={props.iconLocation}
    />,
  },
)

and the output in Figma's dev mode for a button with the iconLocation variant property set to "left":
  <ButtonPrimary
      buttonText="label"
      iconSide="IconLocation.LEFT"
  />

I would expect the output to look like this, so that if it were copied and pasted into another React component, it would use the actual enum from the code, rather than using a string:
  <ButtonPrimary
      buttonText="label"
      iconSide={IconLocation.LEFT}
  />

I have tried this with the enum being imported, with it being local to the code connect file, with the enum's type being number, and with it's type being string, and they all result in the same output described above.

Hey @AHumphriesPD, thanks for the report! -- The team is aware of this issue and it should be fixed in the next release.

@AHumphriesPD we just released 0.2.1 that should fix this issue. I'll close it for now, but feel free to reopen if that's not the case.


Which license is this list?

In the footer it mentions by CC0 and CC-BY. Please clarify. ^_^

Answer him Siddharth11...the guy asked a question almost a year ago, what's the hold up?

Closed by 301fa99aae6467b1a8a23ed51326e5bbd69f7dbd


Entry chunk collapsed.

This change is

Review status: 0 of 7 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 4 of 6 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Readability: modify output colors

This tool is fantastic, but I struggle heavily reading the results, especially with the blue background.
Is there a possibility to modify the colors?

I'd also like to mention that the following is no good solution for readability as well
-a value Toggle ANSI colors display ( true or false )

It'd be best for readability if only the background disappeared instead of all the colors.

You can customize output and colors by using a configuration file, you can find an example here.

I just had the same issue, and solved using "background:49m". I think this could be set as a default


Implicit group assignment for initial administrator

Summary
Create access group together with organization and assign the initial organization administrator.
Details
Enhance implementations in OperatorServiceBean#registerOrganization and AccountServiceBean#registerCustomer to create group and assign the initial administrator, using the respective groups endpoint from oscm-identity.
This task can be implemented independently when mocking the oscm-identity endpoints (verify with unit tests).
Acceptance criteria

[ ] Unit tests
[ ] Platfrom Operator admin registers an organization: Same named access group is created for the Open ID Provider tenant
[ ] Supplier admin registers a new customer organization: Same named access group is created for the Open ID Provider tenant
[ ] Info to @SuessI for handling documentation

Additional context
N/A

https://github.com/servicecatalog/oscm/pull/414#pullrequestreview-280776303


Add datetime and bbox attributes to post-ingest SNS messages

Related Issue(s):

#45

Proposed Changes:

Add datetime, start_datetime, and end_datetime string attributes to post-ingest SNS messages
Add start_unix_epoch_ms_offset and end_unix_epoch_ms_offsetnumber attributes to post-ingest SNS messages
Add bbox.ll_lon, bbox.ll_lat, bbox.ur_lon, bbox.ur_lat number attributes to post-ingest SNS messages

@jkeifer provided guidance based on the Cirrus implementation of filterable SNS message attributes
https://github.com/cirrus-geo/cirrus-geo/blob/35f3de5b9c99b2295b51cccb7ee2e12f64be3f5a/src/cirrus/builtins/tasks/publish/lambda_function.py#L46-L93
PR Checklist:

[x] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

Can you add a changelog entry?

Can you add a changelog entry?

Added in 9e61618

Thanks for the review.


llvm37 3.7.0 (new formula)

Does this support OpenMP out of the box or does it need to depend on libiomp like the clang-omp formula?

Any chances it is merged?

@jenshnielsen When I try to build something with -fopenmp switch with clang from this formula, I get:
~ $ clang++-3.7 test.cpp -fopenmp
ld: library not found for -lgomp

Installing libiomp does not fix this though. I'm not sure what the official status of OpenMP support is on OSX; note that I get the same linker error if I use clang from Xcode 7 with -fopenmp switch.

Ping.

@BrewTestBot test this please

Does it need any more work?

@BrewTestBot test this please

Going to merge this because people keep asking and LLVM haven't rushed a new release, but please do bear in mind the accidentally broken API element if you run into unusual breakage against local projects. There's not really a lot we can or will do to resolve that until LLVM release the fix upstream.
Merged in https://github.com/Homebrew/homebrew-versions/commit/4cff8a0ca4c67d31d25177165429a5157bb09cb6. Thank you for another contribution to Homebrew @lembacon! :smiley_cat:

@DomT4 any help with https://github.com/Homebrew/homebrew-versions/issues/1076 ?

Absolutely no idea I'm afraid. I'll try and take a look but LLVM expert I am definitely not, to say the least.

@DomT4 who created the bottle though?

The CI machine. Asking him/her/it won't get you much of a reply, I'm afraid.

It's worth checking if your error reproduces from source. brew reinstall llvm37 -s. Obviously, bear in mind LLVM takes hours to build.

@DomT4 thats no the problem, Homebrew is needed for me only as provider of precompiled packages to not build llvm itself (I use it for travis ci). CMake modules of LLVM are generated after compiling (for example in old 3.6 bottles you can see user specific past to llvm lib in them) but in 3.7 bottle some parts are undefined and comment is left so I assume that the problem is with however someone made such bottle.

@DomT4
I compared to the cmake generated file on my windows machine (but it should be the same on OSX) and I think I found the issue. I have:
# Compute the installation prefix from this LLVMConfig.cmake file location.
get_filename_component(LLVM_INSTALL_PREFIX "${CMAKE_CURRENT_LIST_FILE}" PATH)
get_filename_component(LLVM_INSTALL_PREFIX "${LLVM_INSTALL_PREFIX}" PATH)
get_filename_component(LLVM_INSTALL_PREFIX "${LLVM_INSTALL_PREFIX}" PATH)
get_filename_component(LLVM_INSTALL_PREFIX "${LLVM_INSTALL_PREFIX}" PATH)

But in Homebrew bottle it's:
# Compute the CMake directory from the LLVMConfig.cmake file location.n get_filename_component(_LLVM_CMAKE_DIR "${CMAKE_CURRENT_LIST_FILE}" PATH)n # Compute the installation prefix from the LLVMConfig.cmake file location.n get_filename_component(LLVM_INSTALL_PREFIX "${CMAKE_CURRENT_LIST_FILE}" PATH)n get_filename_component(LLVM_INSTALL_PREFIX "${LLVM_INSTALL_PREFIX}" PATH)n get_filename_component(LLVM_INSTALL_PREFIX "${LLVM_INSTALL_PREFIX}" PATH)n get_filename_component(LLVM_INSTALL_PREFIX "${LLVM_INSTALL_PREFIX}" PATH)n set(_LLVM_LIBRARY_DIR "${LLVM_INSTALL_PREFIX}/lib")

Notice the difference? For some reason on OSX it's just n instead of newline (\n). I'm not sure if this one specific build issue, bug in cmake installed on travis ci or bug in how llvm handles osx.
Could you rebuild the bottle (maybe with updated cmake) and see if it helps? If possible the 3.7.1 llvm version (it's been tagged last week but not yet officially released across all platforms if I got that correctly: http://lists.llvm.org/pipermail/llvm-dev/2015-December/093179.html )

@danilaml You can try locally rebuilding using --build-from-source


Fix connection string of migration script in server environments

Current connection string does not work for socket auth

Has been fixed


Add Power{N} operator in computational graph

Codecov Report
Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (b063a68) 64.79% compared to head (d52c90b) 64.09%.
Report is 1 commits behind head on computgraph.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff               @@
##           computgraph     #143      +/-   ##
===============================================
- Coverage        64.79%   64.09%   -0.71%
===============================================
  Files               56       56
  Lines             3724     3824     +100
===============================================
+ Hits              2413     2451      +38
- Misses            1311     1373      +62

Files
Coverage Δ

src/computational_graph/optimize.jl
94.48% <100.00%> (-0.69%)
:arrow_down:

src/computational_graph/abstractgraph.jl
75.60% <83.33%> (+1.32%)
:arrow_up:

src/computational_graph/feynmangraph.jl
91.66% <96.66%> (+0.21%)
:arrow_up:

src/computational_graph/eval.jl
77.77% <0.00%> (-9.73%)
:arrow_down:

src/computational_graph/operation.jl
79.25% <48.71%> (-6.27%)
:arrow_down:

src/computational_graph/graph.jl
70.10% <58.06%> (-15.62%)
:arrow_down:

... and 8 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Looks good to me

Thanks. The modification for static compilers has been updated.


102 missing

The new postcode 102 is missing from postcodes

https://github.com/sveinbjornt/iceaddr/commit/3e7c9b5e29b667ec6d215cb2d18ab9d33e52b3ff


Changed grepme.py and login.py to be data files rather than scripts

Previously grepme.py and login.py were added as scripts so they were added to the PYTHONPATH. For setup.py, scripts and console_scripts seem to be two different methods of creating executables and should not be mixed.

Looks good but I won't merge until I get to a computer and can test it.
https://stackoverflow.com/a/28119736/7669110

I'm getting ImportError: No module named 'grepme' when I run setup.py install . && cd && grepme.

Modif ied and merged in https://github.com/jyn514/GrepMe/pull/13


Can you please explain the QC?

00104c81-2985-4943-9502-9143a1eee412	Escherichia coli UMEA 3053-1	O75	H5	O75:H5	NA	-	Based on 3 allele(s)	wzx:1.000;wzy:1.000;fliC:1.000;	-
0013e2ce-394b-4fc5-a356-abadd635fa00	Escherichia coli 2-177-06_S4_C2	O132	H10	O132:H10	NA	-	Based on 3 allele(s)	wzx:0.999;wzy:0.999;fliC:1.000;	-
Eg the two records above - the QC column is NA, confidence -   output looks sensible against eg MLST though - can you explain how EcTyper does this and what the above means?
Thanks

@samlipworth . The QC column is for testing purposes so far. The reason why you've did not get any values is because you run without --verify parameter which checks for sample to be of E.coli species and updates species column to Escherichia coli value. Since species check is done using exact match, the QC module considered these samples as non-E.coli and refused to output any QC assessment values. I should of used regular expression instead of an exact value match. I am currently working on version 1.0 which will have much better and sensible QC module where prediction accuracy and sensitivity are the main targets. Please run the tool with the --verify parameter to get QC values.
In current version 0.9.1 the QC module provides very vague idea of the result confidence and is based on our empirical data. For version 1.0.0 we are currently doing much thorough QC analyses to arrive at min quality values for each antigen to be confidently resolved (if possible at all).

If aggregate mean score across O and H antigen is >= 0.95 you get PASS value and HIGH confidence value.
If aggregate mean score across O and H antigen is between 0.80 and 0.95 you get PASS value and MEDIUM confidence value
For other definitions look at https://github.com/phac-nml/ecoli_serotyping/blob/a7e67b6df13c018b4b3348635220bef074557606/ectyper/predictionFunctions.py#L258

Thanks very much for this - does this use the Serotypefinder database / what should I cite when using this tool?

Hello,
We just released version 1.0.0 with the QC module that is different from the version 0.9.1. The QC module is designed mostly for reference services to understand if a given antigen call (e.g. O157) is reliable enough to get reported or needs additional wet-lab verification. The reliability was calculated as a function of minimum %id and %cov to prevent false hits against other antigens (i.e. cross-talk) based on the alleles database. E.g. some antigens like O17 fall into high similarity group and even at 99% identity and 100% coverage can give cross hits with O77, O73 and O106. Others like O157 require coverage of only 5% to successfully unambiguously resolve.
In new README there is a table at the bottom that explains all QC values. If coverage is good and antigen is not part of one of the high similarity groups, then you will get PASS (REPORTABLE) QC value. If O antigen call is mixed, then you will get a warning (WARNING MIXED O-TYPE) since this antigen could not be resolved to a single call. This does not mean that it is a fail. It just means that it is a mixed prediction and requires end-user call. We plan to expand on resolution power of the tool using other genes or other approaches in future, but it is a complex task as wet-lab results might also be misleading due to anti-sera cross-reactivity, etc.
The manuscript is currently in preparation and results section is almost complete. We plan to submit at the end of summer. For now refer to this repository (it is possible to cite repository).
Thanks for reaching out

Thanks this is all very helpful. Can you just confirm what the underlying allele reference database is - was this developed bespoke by you for this project or does it use another reference database eg. Serotypefinder?

The reference alleles database is in JSON format and was developed both by us and by merging SerotypeFinder and SRST2 databases.  You can take a look at the ectyper_alleles_db.json file stored in Data folder. Most of the alleles come from EnteroBase E.coli samples and those have ESC_ accession numbers mentioned in description field. Most E.coli serotyping tools use identical NCBI deposited references.  By sequencing reference strains we found that antigen alleles are identical to references already available in NCBI. Thus all alleles are from public sources. In future we might add a couple of internal allele references for poorly represented antigens like O90.

Perfect thanks a lot that explains everything!


How can get request body from command? (question）

Like， from client i send a POST request with some json body, How can I get that body content from script ?

Hi @eggcaker
you can use -cgi option for that, and POST data will get on stdin, something like:
shell2http -cgi /jq 'jq'

and
$ curl -X POST -d '{"id":123}' http://localhost:8080/jq
{
  "id": 123
}

thanks！


.net core 3.0 upload big file faild

From @1369521908 on Tuesday, October 15, 2019 5:39:11 PM
Issue Title
.net core 3.0 upload big file faild
General
1 IDE & windows

2 .net core version (my project version)

3 controller & api

4 startup config

5 upload file

5 error stack (error file size is >16MB)

6.success condition (file size is 1KB )

small file is success accepted

is this config not effect or i config wrong?
when i use .net core 2.2 ,that file[5] was success uploaded...
here is my code on github
https://github.com/1369521908/Obsidian.git
Copied from original issue: dotnet/core#3629

/cc @Tratcher

Duplicate of https://github.com/aspnet/AspNetCore/issues/15025

hey everyone , first , thanks for your reply. and in morning ,i try to remove the old project add a new project just now , and i works success...

i don`t konw where the problem is ,but already solve it is great. : )


Basic predicate skeleton

@skygering if you want to work here, we can merge this into the Caltech-OCTO fork before merging that into GeometryOps proper.


explorer: add highlighting to decompile view

Update explorer to add highlighting to decompiler view in addition to disassembly view

see IDA 7.6 changelog:

IDAPython: added an example showing how to toggle pseudocode lines’ background using UI hooks


Upgrade: Greenkeeper/html webpack plugin 4.2.0

What is the purpose of this pull request? (Check any that's applicable)

[ ] Feature
[ ] Bug fix
[x] Dependency updates
[ ] Documentation updates
[ ] Build related changes
[ ] Changes an existing functionality
[ ] Other, please explain:

Does this introduce a breaking change?

[ ] Yes
[x] No

What changes did you make? (Give an overview)
Upgraded html webpack plugin version to 4.2.0
Add any screenshots

To avoid multiple release's, closing manually created PR's.


Error when importing the same app in different DS

Description
When importing a marketplace app for the second time using another datastore, the core returns the following error:
2023-10-27 13:44:44 - NoMethodError - undefined method []' for Error deleting image 11:opennebula::error:         /usr/lib/one/ruby/opennebula/marketplaceapp_ext.rb:272:in export_vm_template'
/usr/lib/one/ruby/opennebula/marketplaceapp_ext.rb:80:in export'         /usr/lib/one/ruby/opennebula/marketplaceapp_ext.rb:651:in block in export_recursive'
/usr/lib/one/ruby/opennebula/marketplaceapp_ext.rb:614:in each'         /usr/lib/one/ruby/opennebula/marketplaceapp_ext.rb:614:in export_recursive'
/usr/lib/one/ruby/opennebula/marketplaceapp_ext.rb:294:in export_service_template'         /usr/lib/one/ruby/opennebula/marketplaceapp_ext.rb:82:in export'
/home/jorge/Documents/projects/one-ee/src/sunstone/models/OpenNebulaJSON/MarketPlaceAppJSON.rb:178:in export'         /home/jorge/Documents/projects/one-ee/src/sunstone/models/OpenNebulaJSON/MarketPlaceAppJSON.rb:54:in perform_action'
/home/jorge/Documents/projects/one-ee/src/sunstone/models/SunstoneServer.rb:228:in perform_action'         sunstone-server.rb:1242:in block in '
To Reproduce

import a marketplace app to a datastore.
re-import the same marketplace app to another datastore.
in the case of sunstone the requests data an error 500, since it is the propagation of the OCA error.

Expected behavior
A clear and concise description of what you expected to happen.
Details

Affected Component: [e.g. Sunstone, Core]
Hypervisor: [e.g. KVM]
Version: [6.6, master]

Additional context
the error may be related to the following file (https://github.com/OpenNebula/one/blob/master/src/oca/ruby/opennebula/marketplaceapp_ext.rb#L269)

Progress Status

[ ] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

https://github.com/OpenNebula/docs/commit/0a79bbbd6b822f441f42374bb4d4e778082188f4
https://github.com/OpenNebula/one-ee/commit/9c0877d30de62f95053af52282b6e308c2acd3f2


Support explicit table width when autowidth option is set

When the autowidth option is set on a table, the table should still honor an explicit width. In this case, autowidth enables automatic column sizing only.
[%autowidth,width=75%]
|===
| A | B B B B B B B B B B B B B B | C
|===

In addition to honoring the explicit width attribute, the converter should also recognize the role "spread" to mean 100% width.
[%autowidth.spread]
|===
| A | B B B B B B B B B B B B B B | C
|===

Note that an explicit width takes precedence out over the spread role if both are given.

Eventually I would like for core to set the tablepcwidth to nil in the case an explicit width should not be used. That will simplify the logic for all the converters.

Is there a special reason why asciidoctor-pdf uses the role spread to mean "100% width" instead of stretch?
From the User Manual on autowidth:

If you want each column to have an automatic width, but want the table to span the width of the content area, add the "stretch" role to the table or set the width attribute to 100%.

Oops. Asciidoctor PDF is out of date. That's old terminology. Can you file a new issue to have it renamed? Thanks.

Thanks for the fast response! I'll do that.


Testing #203089: Format alert not read

Testing #203089
So I made a little change to a testing file and forced the format of a document through the command palette. I was expecting to hear an alert that the documented was just formatted.
https://github.com/microsoft/vscode/assets/61460952/e6484ff3-c012-4ad4-ba20-e3732acad93e

It looks like that command is coming from the prettier extension, prettier.forceFormatDocument. I don't think I'm handling that case.


showFavorited property cannot be set false.

The showFavorited property is not able to be set false.
Since boolean properties are set by the presence of the attribute or not and the property is defaulted to true not having the attribute present doesn't turn off favorites..
The requirement for configurable boolean properties to default to false is documented in both the Polymer 1.x and 2.x docs.
https://www.polymer-project.org/1.0/docs/devguide/properties#configuring-boolean-properties
https://www.polymer-project.org/2.0/docs/devguide/properties#configuring-boolean-properties

Good catch @leebickmtu, fixing now.

Fixed in v2.2.0


Lost majority of my project when I bought more tokens.

Describe the bug
I ran low on tokens and purchased the new credits and then refreshed the browser to apply them I found that my project was backed up to several days ago.
Now I am going to have to rebuild the project , and its a fullstack application build.    And I am going to have to pay credits to rebuld only because I purchased more credits.   Frustrating.  Highly disruptive.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-wlgkaw
Steps to reproduce
No steps required.  I would have to rebuild, buy more credits and have it revert the project again in order to reproduce.
Expected behavior
I expect to have access to the latest build.
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 129
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 118654965,
  "usedJSHeapSize": 102601813,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = jaywakeford
Chat ID = e67c31e444d3

Additional context
No response

I should have been more patient.  This is NOT an error in the platform.    It just took time to reload the necessary files.
The full scripts are visible now.
Apologies for the panic.

Honestly just glad to hear everything is working well for you! No apologies needed :)
Closing for now but let us know if you run into any issues!


Issue59/hyperlinks

Hyperlink functionality has been added to the required output values in the signature: phone, email and linkedin. Ready for review!

Also patching up bug with hasData, imgUrl was not included in the logical calculation. 😮

Ready with the changes! Mailto and tel have been implemented with template literals and code cleaned up and printing LinkedIn instead of the URL!


Flatten the Strategy inheritance

Proposed refactor
Flatten the Strategy inheritance:
Part of #10416
Motivation
Reduce coupling between strategies, reduce unintentional overrides/inheritance and avoid silent failures
eg:

DeepSpeed inherited configure_ddp() from DDP, which is unnecessary and error-prone.
DDP and FSDP have totally different distributed behavior, but with current inheritance, adding a DDP strategy method will automatically enable this method for FSDP

Pitch
Tasks list:

FSDP inherit ParallelStrategy instead of DDP
DeepSpeed inherit ParallelStrategy instead of DDP
[RFC] DDPShard inherit ParallelStrategy instead of DDP
[RFC] DDPShardSpawn inherit ParallelStrategy instead of DDPSpawn
[RFC] TPUSpawn inherit ParallelStrategy instead of DDPSpawn

Additional context
The downside of this task will be code duplications.
Align DDP/DDPSpawn precess group creation #11643 and Collective refactor #9414 will reduce the duplication.

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @justusschock @awaelchli @akihironitta @rohitgr7

Let's first get process launchers #11643 done so the ddp launch logic does not get duplicated into every strategy?
cc @rohitgr7


Bug: App stops responding if there are thousands of items in recycle bin

Description
I recently came across an issue where the app can stop responding on startup or when deleting an item.
Steps To Reproduce

Unpin Recycle Bin from the sidebar
Create 25,000 blank text files from cmd line
Delete all of the files via File Explorer
Go back to Files and delete a single file, observe that the stops responding
Pin Recycle Bin to the sidebar again and restart Files and observe that the app stops responding
Empty Recycle Bin and the issue goes away

Requirements

Fix the freezing issues when there are a lot of items in Recycle Bin

Files Version
v3.0.13
Windows Version
Windows 11
Log File
NA

@hishitetsu do you know if your recent PR for pinned items fixes this?

For the freeze when deleting items, I wonder if it's because we check if the item is already in Recycle Bin IsUnderTrashBin.


Docker Swarm service discovery missing 'ancestor' filter

Hello,
Prometheus documentation states that Swarm targets can be filtered with Docker Engine API
# Optional filters to limit the discovery process to a subset of available
# resources.
# The available filters are listed in the upstream documentation:
# https://docs.docker.com/engine/api/v1.40/#operation/ContainerList
[ filters:
  [ - name: <string>
      values: <string>, [...] ]

I tried to filter by ancestor (i.e. image), based on the referenced Docker documentation
- job_name: 'mysqld-exporter'
    dockerswarm_sd_configs:
    - host: http://dockerd:2375
      role: tasks
      filters:
	- name: ancestor
          values:
            - prom/mysqld-exporter

Promtool returns an empty result, despite the Swarm cluster having mysqld-exporter containers.
$ promtool check service-discovery /etc/prometheus/prometheus.yml mysqld-exporter
[]

Either the ancestor filter is not working, or the referenced documentation is wrong. I believe https://docs.docker.com/engine/api/v1.40/#tag/Task should be the correct one (at least for tasks).
Thanks

The specific filters aren't implemented by Prometheus itself, we only have the functionality to pass them to the API. That means the issue either falls on your configuration or the Docker engine. I'd recommend checking what API version you have (via docker version), the ancestor filter seems to have been added in v1.23.

Hi,
Like you, i've lot of problems when using filters.
A single filter on name attributes, or desired-state, or label doesn't work.
I'm not alone : https://samizdat.dev/prometheus-scrap-all-docker-swarm-tasks/

Could you please provide the configuration that you're using?
And also, do all filters not work, or just this one? The issue implies that only the ancestor filter doesn't work, but if all don't maybe it's a problem with Prometheus.

Hi,
I've hardly worked on my configuration.
I use the filters like explained on the documentation and as finded on google :
  - job_name: docker-swarm-services
    dockerswarm_sd_configs:
      - host: tcp://socket:2375
        role: tasks
        refresh_interval: 30s
        filters:
          - name: name
            values: ["haproxy"]

After one hour of tries and tries..., i look at this page and the light has arrived !
https://prometheus.io/docs/guides/dockerswarm/
The principe is simple....  no filter used at query level.
Every services are pulled from the socket and prometheus simple exclude/include them, as you want.
After less than 30min, i've created a "labels powered scraping" :
Labels used in service :

  labels:
    prometheus_enable: "true"
    prometheus_job: powerdns-authorative
    prometheus_scheme: http
    prometheus_port: 8081
    prometheus_path: /metrics

Prometheus job configuration :
  - job_name: docker-swarm-services
    dockerswarm_sd_configs:
      - host: tcp://socket:2375
        role: tasks
        refresh_interval: 30s
    relabel_configs:
      # only keep services with prometheus_enable set to true
      - source_labels: ["__meta_dockerswarm_service_label_prometheus_enable"]
        regex: "true"
        action: keep
      # remove port if specified and set instance with address
      - source_labels: [__address__]
        regex: "([^:]+):\\d+"
        target_label: instance
      # remove port if specified and re-set address
      - source_labels: [__address__]
        # regex: ([^:]+)(:\d+)?;(\d+)
        regex: "([^:]+):\\d+"
        target_label: address
      # set instance with service name and task slot
      - source_labels: ["__meta_dockerswarm_service_name", "__meta_dockerswarm_task_slot"]
        regex: (.*)
        target_label: instance
        replacement: $1
        separator: "."
      # only keep services in running state
      - source_labels: ["__meta_dockerswarm_task_desired_state"]
        regex: running
        action: keep
      # Scraping metrics via a certain network only
      - source_labels: ["__meta_dockerswarm_network_name"]
        regex: monitoring-public
        action: keep
      # only keep services with prometheus_job set and set job variable
      - source_labels: [__meta_dockerswarm_service_label_prometheus_job]
        regex: .+
        action: keep
      - source_labels: [__meta_dockerswarm_service_label_prometheus_job]
        target_label: job
      # only keep services with prometheus_scheme set and set __scheme__ variable
      - source_labels: [__meta_dockerswarm_service_label_prometheus_scheme]
        regex: .+
        action: keep
      - source_labels: [__meta_dockerswarm_service_label_prometheus_scheme]
        target_label: __scheme__
      # only keep services with prometheus_port set and set prometheus_port variable
      - source_labels: [__meta_dockerswarm_service_label_prometheus_port]
        regex: .+
        action: keep
      - source_labels: [__meta_dockerswarm_service_label_prometheus_port]
        target_label: prometheus_port
      # only keep services with prometheus_path set and set __metrics_path__ variable
      - source_labels: [__meta_dockerswarm_service_label_prometheus_path]
        regex: .+
        action: keep
      - source_labels: [__meta_dockerswarm_service_label_prometheus_path]
        target_label: __metrics_path__
      # concatenate address with prometheus_port to re-set __address__ variable
      - source_labels: ["address", "prometheus_port"]
        # regex: "([^:]+):\\d+"
        # target_label: address
        # replacement: ${1}:${2}:${3}
        target_label: __address__
        action: replace
        separator: ":"

At this time, i've migrated more than 70 services, previously declared in static_configs or dns_sd_configs and lot of jobs (haproxy, nginx, etc....)
Now, i've just 8 jobs and i'm happy !!!

The specific filters aren't implemented by Prometheus itself, we only have the functionality to pass them to the API. That means the issue either falls on your configuration or the Docker engine. I'd recommend checking what API version you have (via docker version), the ancestor filter seems to have been added in v1.23.

Hi @LeviHarrison
Sorry, I should have been more precise. I'm using Docker 20.10, and some filters are perfectly working, like name or desired-state. That's why I suggested the issue may not be with Prometheus, but rather with the documentation referencing the wrong API (https://docs.docker.com/engine/api/v1.40/#operation/ContainerList vs https://docs.docker.com/engine/api/v1.40/#tag/Task). In the second one, there is no ancestor filter, so Prometheus is working as expected.

That's why I suggested the issue may not be with Prometheus, but rather with the documentation referencing the wrong API

Ah, I should have read more carefully, apologies. I believe you're right. There should be links to the ServiceList, TaskList, and NodeList API documentation, as those are what the Swarm SD uses. Interestingly enough, those links used to be there, but were replaced with a link to the ContainerList documentation in #8629 (https://github.com/prometheus/prometheus/commit/b253056163b705a13a4e2f961348717ae9657824#diff-17f1012e0c2fbd9bcd8dff3c23b18ff4b6676eef3beca6f8a3e72e6a36633334L604-L606). I wonder why.
cc @roidelapluie @xperimental

Thanks for the highlight. It looks like I moved around the documentation too much and added the wrong links to both sections (Docker Swarm referencing Docker Engine and vice-versa).
I'll give this another read and then create a PR fixing the documentation. Am I understanding the discussion correctly, that the feature works properly only the documentation is affected or is it also broken?

Thanks for the quick response and the explanation, I really appreciate it. Prometheus is working properly, just the documentation is inaccurate.

Documentation was fixed #10252


Fix/serviceaccount imagepullsecret drift

Fixes an issue with ServiceAccounts caused by the drift in the manifest spec's imagePullSecret and secrets fields that triggers a recurring sync in argoCD.
From the application point of view, it is in constant out-of-sync status while it attempts to synchronize.

With this change, ArgoCD will ignore the pullImageSecret and secrets difference.

@sabre1041 @nasx please review. I needed only imagePullSecrets, but I thought adding secrets might be also worth it since it can also be a cause of out-of-sync in other cases. Let me know if you want me to narrow it to only imagePullSecrets.
There is another way to approach this, and that's to define this specifically to an Application manifest, rather than globally in ArgoCD, just by adding this snippet of code to the Application manifest:
  ignoreDifferences:
    - jsonPointers:
        - /imagePullSecrets
        - /secrets
      kind: ServiceAccount

Let me know which one you prefer.

@jordigilh I have incorporated this into the bootstrap values so we may be able to close this issue


Automatically set docs current year

Summary
Closes #767
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.306%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
17481

Relevant Lines:
20492

💛  - Coveralls


Color not replaced

I cannot get replacement of colors to work.
Steps I have performed:

I have a column in my CSV file named Color1
I have a Solid color named %VAR_Color1% in my Scribus document and multiple other colors like "Blue", "Green"
I have set the background color of a polygon and the text color of some text to %VAR_Color1%. This can be seen if I open the document with a text editor. I a have a text field with the text %VAR_Color1%.
I run the Scribus Generator script without errors, creating only Scribus files.
The background color of the polygon is white and the text is black, not using my created colors Blue or Green. The text field however is changed to the text "Blue" or "Green" correctly. All other variables in text are also replaced correctly.
If I look into the generated document using a text editor I can see the PColor attribute of the polygon is empty ("").

I'm very new to both Scribus and Scribus Generator, so I might be doing something wrong, but I think I've got it all right.
The document, the CSV file and an example of a script generated file are attached in the zip file..
Colorbug.zip

hello and thanks for the feedback.
I see the name of your dynamic color %VAR_color1% has a small case "c" in the SLA template, instead of the capital "C" used in the data and text frame... that may be part of the issue.

besides the above problem I did spot an issue with your data (CSV) file :
It seems to have been created/encoded in some way that did lead ScribusGenerator to break the reading/parsing of that data, prepending a \ufeff byte before the header line.
I'm looking into it now... but just so I can understand: how did you create this CSV file please ? (what software+OS+settings if any) ?
FYI (and my personal notes) the header of data file has been parsed into %VAR_\ufeffNumber;Bibnumber;Class;Col1% ... and that definitely will not work. likely related to BOM UTF-8/UTF-16:  https://stackoverflow.com/questions/17912307/u-ufeff-in-python-string

indeed once both the (minorcase) name and CSV format issue are fixed the script works:

so I'm really interested in knowing how you created that CSV file... please
Colorbug_fixed.csv
Colorbug_fixed.sla.txt
;)

Turns out this encoding byte is not leading to any error, so I will disregard it unless you come back with contradictory information.
To get your original CSV data to work (after fixing color name) you just need to make sure to mention the proper "semicolon" separator character, instead of the default "comma":

have fun, and don't hesitate to share your work in the gallery : https://github.com/berteh/ScribusGenerator/wiki#gallery-of-examples--some-templates

Thanks for your quick response!
I used Excel (latest version I think) on Windows 11, with Swedish settings. The original csv file included some Swedish characters (å and ö), which I replaced in case that was the cause (Blue was Blå, and Green was Grön).

I got it working by just changing %VAR_color1% to %VAR_Color1%.
Sorry to take up your time with a typo. I am very thankful for your quick and friendly help!

great. by the way: sweedish characters should work without problems. I tested it in data and template at least... not in variables names yet, but it should be ok.


Address texture analysis performance issue

Thanks for taking the earlier fix.
I was exporting this houseplant model that I found on the 'net and it took more than five minutes to export.  After debugging, it seems the hotspot was in checking UV coords for the same material over and over on ~4000 polys.  This simple fix speeds things up a lot.  I tested with various textured models and it doesn't seem to break anything.
Again, this includes the model files for testing, but you may choose to leave them out, especially since they're kind of big.

Thanks! I see you also use game settings for material.

Hi, well, I don't always use the Blender Game mode or materials.  I just changed that bit of the code to make sure the face (f) wasn't actually used anywhere else.
In that regard, I wonder, why doesn't this code just iterate all the materials on the object directly?  To gather the materials, it doesn't need to iterate every poly, since the same ones are probably used on most faces.   For example:
                handled = set()
                for f in obj.data.polygons:
                    if f.material_index < len(obj.data.materials):
                        mat = obj.data.materials[f.material_index]
                        if not mat or mat in handled:
                            continue
                        handled.add(mat)

changes to:
                for mat in obj.data.materials:
                        if not mat:
                            continue

Or is the goal to cull out texture materials that really aren't used (as "used_textures" implies), like if someone puts 10 "temporary" materials on an object but never assigns them to any faces?

Yes, I did it to exclude materials that are not actually assigned to any face. However, if it's so affects performance, then I think that there is nothing wrong if that unused materials will be written to the resulting file.

I agree.  rdb mentioned on #panda3d that the egg loader will cull out unused materials.
On the other hand, in texture bake mode, if you can avoid baking unused materials, that may be good.  shrug
I don't think the performance now will be so bad unless there are really millions of polys in an object.

Ok. Anyway bake mode is still experimental, and I suspect that it almost never used.


Throttling problems

We have a build that relies heavily on using azure storage via the CLI.
A major thing that bugged me is that from time to time I get errors due
to throttling.  Recently this turned from an occasional annoyance to a
major issue, since we now have builds that fail because of throttle
related problems.
Solving these problems in a robust way as far as I can currently see is
difficult enough[*] that it's practically impossible.  There should
really be a flag for "just make it work, wait whatever time it takes for
it".
I think that such a mode should be the default, but just a flag would be
a huge help.
[*] The way I could think about resolving it now is to run the command
and capture its stdout and stderr separately; inspect the stderr for
things that look like throttle problems (ie, check for a magic word in
the stderr); and if there is such a problem, guess some time to sleep
and re-try (sometimes there's information in the stderr, but parsing
that would be very brittle); if not then spit out the saved stdout.

See also Issue #4347
When I was trying to trace how things work, it turns out that the CLI is
actually doing the right thing (via python http library): it gets a
reply from the management API that asks to re-try after 17 seconds, and
then it actually does that 17 second sleep, and retries.  In some
cases this works, and in other cases it just does this three times and
then it fails.
So this looks like an issue with the API not returning a proper header,
since the CLI is definitely doing what it should.  There's of course the
chance that someone else was hammering at the subscription at the same
time, but I have been tracking this problem for several days, and in all
that time we got consistent throttling, and the requested wait time was
always 17 seconds.
Bottom line: this issue should probably be closed, but you might want to
raise an issue with the API about that problem.  (Not the low threshold,
but the fact that it lies about the 17 second sleep...)


[develop] Pickles encoding and verification hardening

This PR is the counterpart to https://github.com/MinaProtocol/mina/pull/13704, via https://github.com/o1-labs/snarkyjs-bindings/pull/96.

See https://github.com/o1-labs/snarkyjs-bindings/pull/96#issuecomment-1653218876. Closing


The disconnect is not implemented for mongodb adapter.

Describe the bug
There is no way to close connections for a graceful shutdown of the keyv mongodb adapter.
How To Reproduce (best to provide workable code or tests!)

Using MongoDb as keyv adaptor with disconnect called on exit interrupt
terminal signal is sent to exit the node js process with a keyv mongodb running
node js doesn't exit.
installed wtfnode npm
performed a dump to confirm sockets to 27017 are open.

@tatejones - Hi. That is correct that mongo does not have this feature. Happy to take a pull request on this or I will leave it to see if others want to upvote this with a 👍

A pull request has been issued.  The MongodbClient needed to be exposed on the KeyvMongoConnect type to allow the disconnect to method to access the close() method.

Thanks for the pull request. This has been merged and should be released in the next couple weeks.


Added .spyproject to ignored paths

Reasons for making this change:
Looks like Spyder 3.1 uses .spyproject folder to store workspace config
Links to documentation supporting these rule changes:
Spyder Config

@random82 thanks!


[suggestion] new default keybindings

Hey, I have been experimenting with these keybindings for a month or two and they rock 🎸. They're like Fish completion keybindings. They allow for more fine-grained completion and they don't collide with Corfu nor Company TAB/C-n/C-p/RET usage.
(map! (:map copilot-completion-map
         "<right>" #'copilot-accept-completion
         "C-f" #'copilot-accept-completion
         "M-<right>" #'copilot-accept-completion-by-word
         "M-f" #'copilot-accept-completion-by-word
         "C-e" #'copilot-accept-completion-by-line
         "<end>" #'copilot-accept-completion-by-line
         "M-n" #'copilot-next-completion
         "M-p" #'copilot-previous-completion))

I've been using something similar. I don't think I've got them quite right yet,
(use-package copilot
  :straight (:host github :repo "zerolfx/copilot.el" :files ("dist" "*.el"))
  :ensure t
  :hook (prog-mode . copilot-mode)
  :bind (("C-c M-f" . copilot-complete)
         :map copilot-completion-map
         ("C-g" . 'copilot-clear-overlay)
         ("M-p" . 'copilot-previous-completion)
         ("M-n" . 'copilot-next-completion)
         ("<tab>" . 'copilot-accept-completion)
         ("M-f" . 'copilot-accept-completion-by-word)
         ("M-<return>" . 'copilot-accept-completion-by-line)))

I've been using something similar. I don't think I've got them quite perfected yet, but approaching something I'm happy with.
I think mapping C-g to 'copilot-clear-overlay is fairly essential.
(use-package copilot
  :straight (:host github :repo "zerolfx/copilot.el" :files ("dist" "*.el"))
  :ensure t
  :hook (prog-mode . copilot-mode)
  :bind (("C-c M-f" . copilot-complete)
         :map copilot-completion-map
         ("C-g" . 'copilot-clear-overlay)
         ("M-p" . 'copilot-previous-completion)
         ("M-n" . 'copilot-next-completion)
         ("<tab>" . 'copilot-accept-completion)
         ("M-f" . 'copilot-accept-completion-by-word)
         ("M-<return>" . 'copilot-accept-completion-by-line)))

Thanks. I've added copilot-clear-overlay to my doom-escape-hook since I'm using Doom Emacs.
(defun cae-copilot-clear-overlay-h ()
 "Like `copilot-clear-overlay', but returns `t' if the overlay was visible."
 (when (copilot--overlay-visible)
  (copilot-clear-overlay) t))
(add-hook 'doom-escape-hook #'cae-copilot-clear-overlay-h)

I have pinned this issue and would welcome any suggestions or recommendations on keybindings.
My intention is to make the default keybindings similar to those in VSCode, while also allowing for high customizability.

Since you asked for suggestions, these are the keybindings I'm using:
;; Based on function from https://robert.kra.hn/posts/2023-02-22-copilot-emacs-setup/
(defun copilot-complete-or-accept ()
  "Command that either triggers a completion or accepts one if one
is available."
  (interactive)
  (if (copilot--overlay-visible)
      (progn
        (copilot-accept-completion))
    (copilot-complete)))

(define-key copilot-completion-map (kbd "<tab>") 'copilot-accept-completion)
(define-key copilot-completion-map (kbd "TAB") 'copilot-accept-completion)
(define-key copilot-mode-map [C-down] #'copilot-next-completion)
(define-key copilot-mode-map [C-up] #'copilot-previous-completion)
(define-key copilot-mode-map [C-right] #'copilot-accept-completion-by-word)
(define-key copilot-mode-map [C-M-right] #'copilot-accept-completion-by-line)
(define-key global-map (kbd "C-<return>") #'copilot-complete-or-accept)

Where copilot-complete-or-accept based on rk/copilot-complete-or-accept from https://robert.kra.hn/posts/2023-02-22-copilot-emacs-setup/ sans the open-line bits (these bindings are similar to the ones suggested there). The C-Enter in particular is very nice and easy to type, and I find myself using it the most (I would suggest upstreaming copilot-complete-or-accept). I'm actually considering unbinding TAB so that it removes the ambiguity between completion and indentation (if I can train myself to stop typing it for completion).
C-up and C-down are probably not so great for defaults because they don't work in terminal emacs without some manual configuration to make the terminal emulator send the right ANSI sequence. I personally use M-p and M-n for something else, but they are probably better for defaults.

Some keys working well for me in evil-mode:
;; Setup keys with copilot:
(define-key copilot-completion-map (kbd ", a") 'copilot-accept-completion)
(define-key copilot-completion-map (kbd ", n") 'copilot-next-completion)
(define-key copilot-completion-map (kbd ", p") 'copilot-previous-completion)
(define-key copilot-completion-map (kbd ", c") 'copilot-clear-overlay)
(define-key copilot-completion-map (kbd ", w") 'copilot-accept-completion-by-word)
(define-key copilot-completion-map (kbd ", l") 'copilot-accept-completion-by-line)

It seems like multiple people here are suggesting fixes that bind to a broader keymap than copilot-completion-map. Could this be because of a bug where the proper keymap isn't always overlaid correctly? This has been my experience, though I haven't been able to consistently reproduce it or track down what the error is yet.

It seems like multiple people here are suggesting fixes that bind to a broader keymap than copilot-completion-map. Could this be because of a bug where the proper keymap isn't always overlaid correctly? This has been my experience, though I haven't been able to consistently reproduce it or track down what the error is yet.

I've also had this issue. I haven't got around to reporting to it because I was trying to get an idea about the problem first (e.g. whether it was something I'd misconfigured). The map isn't always active when the overlay is open, but I haven't been able to work out why not.

It seems like multiple people here are suggesting fixes that bind to a broader keymap than copilot-completion-map. Could this be because of a bug where the proper keymap isn't always overlaid correctly? This has been my experience, though I haven't been able to consistently reproduce it or track down what the error is yet.

I've also had this issue. I haven't got around to reporting to it because I was trying to get an idea about the problem first (e.g. whether it was something I'd misconfigured). The map isn't always active when the overlay is open, but I haven't been able to work out why not.

Have you updated copilot? An issue like that was fixed a while ago.

Have you updated copilot? An issue like that was fixed a while ago.

Yes, I'm running on the latest commit<PHONE_NUMBER>b9fed7ced4ccff4e60fc072290c9a4.

To pile it on here (this is more of a dicussion thread), for evil-mode I've been using:
;; accept completion from copilot and fallback to company
(use-package! copilot
  :hook (prog-mode . copilot-mode)
  :bind (:map copilot-completion-map
              ("<tab>" . 'copilot-accept-completion)
              ("TAB" . 'copilot-accept-completion)
              ("C-TAB" . 'copilot-accept-completion-by-word)
              ("C-<tab>" . 'copilot-accept-completion-by-word)
              ("M-n" . 'copilot-next-completion)
              ("M-p" . 'copilot-previous-completion)
              ))

This leaves C-n and C-p for company like before, and uses M-n and M-p to cycle through copilot suggestions

I hope there aren't going to be automatically configured keybindings when this package loads, as that could conflict my configuration.

I like when packages suggest keybindings that "just work". It makes packages more friendly to adopt. This package is especially tricky if you want to use tab complete for both company-mode (eglot) AND copilot. I wish there was a "blessed" example of how to tab complete both company-mode and copilot (i.e. mimic VS Code)—I tried for many hours but it's very finnicky to have the Tab key do multiple things, so I just decided to use M- for copilot-accept-completion and TAB for company-complete-selection.
I do think packages that have default keybindings should clearly document that fact and provide a simple example of how to get rid of them.

How would you make TAB do both? The only way I can see that working is if you intermingle the copilot completions with the company completions in the completion menu.


How would one go in order to add spanish support?

You'd need a labeled spanish dataset to train on, which unfortunately I don't have.

@vzhou842 we have seen there are no good spanish profanity checkers available, we would be interested in generating that labeled spanish dataset to train on. How would this dataset be in order to be useful to you?

You'd just need to have a large size of examples of both profane spanish text and clean (not profane) spanish text. Ideally you'd probably want 100k+ examples.

mmm.... If I make an open source list it might be possible

... That would be great.

... That would be great.


DOCS: Bot setup documentation

Add documentation in the README about how to set up, build and run the discord bot locally, so that new contributors can contribute to the bot.
Additional Info
I'd be interested in setting up this documentation

Would like to take on the issue...
Improving the Readme and adding the stats on how to setup the bot


Feature Request: Show Messages on Display ID5 / 6 / 7

Hey ho,
Is there any way, to implement a "proper" notification on CD after ID4?
Do you work on that feature?
If it is not possible to have something else than the "ping", than that ticket can be closed again ;)
Greetings,
Christian
P.S.: Radio Bob and accessing via shortcut works like a charm :D

Good morning!
I am collecting ideas in #99, I think the most promising approach will be to figure out how Mini FindMate works when it adds a new message to the car's Notification Center. This adds an icon in the top system bar, and the Notification Center would allow for clicking into the application. I haven't yet experimented with this API yet, but it should be relatively straight forward once I find an official application to log in as which supports this API.

Oh sorry, I missunderstood that issue - will close that one as dublicate


Project doesn't run

We get follow error:
The program '[13320] dotnet.exe' has exited with code -2147450751 (0x80008081).
and where we can find the database:  Data Source=AspNetCoreSpa.db ?
We have done everything according to instructions.

@j-nord are you using Visual studio IDE or VS code? You just need to do F5 in these two.
If you are using commandline you need to first set dev environment:
set ASPNETCORE_ENVIRONMENT=Development
then do
dotnet run

We use Visual Studio 2015.

Never seen this issue, can you let me know environment details?
dotnet info ?
node -v
npm -v

PM> node -v
v7.5.0
PM> npm -v
4.1.2

Try with latest 6.x node version as state in readme. haven't tried this under node v7.x.

It's working on my machine with that node version... So probably could be something related with the dotnet installation.

@j-nord can you attach some screenshot or further details for this issue as I am unable to guess any reason for above issue.

In Visual Studio we get follow error in Output:
The program '[20928] dotnet.exe' has exited with code -2147450751 (0x80008081).
The program '[8000] iisexpress.exe' has exited with code 0 (0x0).
In the event-protocol from windows:
Failed to start process with commandline '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\Extensions\Microsoft\Web Tools\ProjectSystem\VSIISExeLauncher.exe" -debug -p "C:\Program Files\dotnet\dotnet.exe" -a "E:\Users\Juergen\Documents\Visual Studio 2015\Projects\AspNetCoreSpa-master\bin\Debug\netcoreapp1.1\AspNetCoreSpa-master.dll" -pidFile "C:\Users\Juergen\AppData\Local\Temp\tmpD954.tmp" -wd "E:\Users\Juergen\Documents\Visual Studio 2015\Projects\AspNetCoreSpa-master"', ErrorCode = '0x80004005'.
We have found a perfect example which work's fine without any problems from chsakell:
https://github.com/chsakell/aspnet5-angular2-typescript

@j-nord I can see project running under following visual studio IDE without any error.

It could be your particular environment. Have you tried switching to node 6.9,x? You can use NVM to easily switch between different versions of nodejs.

@j-nord if you download project as *.zipfile, try to follow steps:

Close VS
Rename folder from 'AspNetCoreSpa-master' -> 'AspNetCoreSpa'
Remove 'node_modules' folder
Open VS and wait when 'restore dependencies' completed
F5

I helped it. But after run I see only 'fa-spinner', no errors in chrome console, no errors in VS.
I try past /home url, /registration url.... but see only spinner, it's all.

@maksir
Its probably an unnecessary question, but just in case: Do you have JS enabled?

@BitFlipp3r yes. I have many a angular2 projects, all works OK.

after command 'npm run clean:dist' and F5 again all work now.


Create a logo for Whales Manager and improve icon database

Create a logo for Whales Manager and include it on the icon database, login page, favicon and about modal
Fulfill the icon database (and the custom font) with new icons to autodetect and to customize more standard containers

Done in commits:

feat (frontend): improve iconsDB (2c16d59)
feat (frontend): add whales manager icon (9944523)
fix (frontend): correct svg usage for favicon (1da6e44)


Feature/vanilla

Description
Added checkbox for vanilla
What is the purpose of this pull request?

[x] New feature
[ ] Documentation update
[ ] Bug fix
[ ] Refactor
[ ] Release
[ ] Other

This is great! Thank you. I feel strongly on avoiding the Inputs(label) set up for examples if that's ok, especially because we already have labels set up on the individual components and those are aware of the keys so set the htmlFor more correctly.


feat: update better test file for liker function

What this PR does:  https://github.com/arana-db/arana/issues/621
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report
Base: 36.76% // Head: 36.76% // No change to project coverage :thumbsup:

Coverage data is based on head (4f73713) compared to base (bbb29fa).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   36.76%   36.76%
=======================================
  Files         202      202
  Lines       22425    22425
=======================================
  Hits         8245     8245
  Misses      13264    13264
  Partials      916      916

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


feat: support Q8_K

No testing, just saving the progress. As long as the next K quantization is implemented, the testing will be completed.
Fixes: #83

I am trying to implement support for Q6K, it will take some time. Let's first review this code, it is the first step towards K quantization.


bpf: update prog pointer immediate insn after prog gets rewritten

(Recent fix is not fully correct.)

https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=7c30013133964aaa2f45c17d6e9782ac6cfd7f5f


Backup just created broken Last backup date in linode list

Was going to label this a bug, but my branch was just behind. This still isn't too pretty.

Maybe ~14 hours would be better?

I like it.


AspectRatio probleme

Hi i have a problem with the aspect ratio propertie, the player strech the windows size on resize
<Grid>     <wpf:VlcPlayer              x:Name="Player"             AspectRatio="_16_9"             EndBehavior="Nothing"             LibVlcPath="./LibVlc"             VlcOption="{StaticResource VlcOptions}" /> </Grid>

Check the last commit f03c5c59f7a50b7c7b0e324d14f52daabddf198f
BTW, AspectRatio property only work on when Stretch property is not 'none'.

Thanks, will try the latest rev

Its look like ok for the aspect ratio but on resize the window, the is cut by the form, there is no black band on the player.
image preview with Stretch="None"

You should set Stretch to 'Uniform'...

Its ok, sorry forgot to post a feedback, its work fine ;)
Thanks


Modules are not being loaded

Including:
//= require highcharts
//= require highcharts/highcharts-more
//= require highcharts/modules/exporting
//= require highcharts/modules/no-data-to-display
//= require highcharts/modules/solid-gauge

results in:
couldn't find file 'highcharts/modules/no-data-to-display'
couldn't find file 'highcharts/modules/solid-gauge'

Removing the offending modules allows it to load cleanly.

Hi.
Which version of the gem are you using? It works on my machine, but the asset pipeline has a reputation for being slightly difficult at times.
Additionally, have you restarted "everything" after including the gem? Sometimes that seems to trick it into working.


(feat)Added parameter browserstackUseHttps to use https in BrowserStack Hub url

signed it.

I signed it!

The CLA has been signed up on my end, but it does not show up here, can someone please check. Also the CI test failures are due to unrelated timeout issues. Thanks

Following up on ray-pankaj - the CLA is signed and the failed tests appear unrelated to the changes. Since BrowserStack has updated to HTTPS and Protractor's integration is outdated, can someone reevaluate this?


About the specifications of KRaft

Hi! I'm a researcher that is currently learning the KRaft protocol and implementation. The specifications in this repo really help a lot. I find it interesting to develop multiple levels of specifications for KRaft (see the directory pull-raft: PullRaft.tla, KRaft.tla & KRaftWithReconfig.tla.
In my understanding, PullRaft.tla is more like a protocol specification that describes the core protocol design of a pull-based Raft variant. In contrast, KRaft.tla is specified based on the Kafka KRaft implementation, and KRaftWithReconfig.tla is developed based on KRaft.tla with the feature of reconfiguration.  The latter two stay more close to the implementation, so they can be used to verify the correctness of the code implementation with higher conformance.
I wonder if my above understanding is right. Thanks!

Yes that is correct. However, I have now written a better specification over in my kafka-tlaplus repo. There is one for reconfiguration that is faithful to the reconfiguration KIP-853. https://github.com/Vanlightly/kafka-tlaplus/tree/main/kraft/kip_853
Also, I have implemented a specification for the data replication protocol, which interacts with Kraft controllers. Included is a prose description of the protocol along with it. https://github.com/Vanlightly/kafka-tlaplus/tree/main/kafka_data_replication/kraft
Those would be good places to go to learn about KRaft and how it interacts with the partition replication protocol.

That really helps a lot! Thanks for your reply!


Coverage is Always Zero

I have been trying to add coverage reporting for unit testing of a fresh Angular project for weeks with no success...
Would be great if someone could help me. 🙏
My karma.conf.js:
// Karma configuration file, see link for more information
// https://karma-runner.github.io/1.0/config/configuration-file.html

module.exports = function (config) {
  config.set({
    basePath: '',
    frameworks: ['jasmine', '@angular-devkit/build-angular'],
    plugins: [
      require('karma-jasmine'),
      require('karma-coverage'),
      require('karma-chrome-launcher'),
      require('karma-jasmine-html-reporter'),
      require('karma-coverage-istanbul-reporter'),
      require('@angular-devkit/build-angular/plugins/karma')
    ],
    client: {
      clearContext: false // leave Jasmine Spec Runner output visible in browser
    },
    coverageIstanbulReporter: {
      dir: require('path').join(__dirname, './coverage/TddBdd2020'),
      reports: ['html', 'lcovonly', 'text-summary'],
      fixWebpackSourcePaths: true
    },
    // list of files / patterns to load in the browser
    files: [
      '**/src/**/*.js',
      // 'test/spec/**/*.ts'
    ],
    exclude: ['**/node_modules'],
    preprocessors: {'**src/**/*.ts': ['coverage']},
    reporters: ['coverage-istanbul'],
    port: 9876,
    colors: true,
    logLevel: config.LOG_INFO,
    autoWatch: true,
    browsers: ['Chrome'],
    singleRun: false,
    restartOnFileChange: true,
    verbose: true
  });
};

output:

bump! 🙃

preprocessors: {'src//*.ts': ['coverage']},

Does that work? I would be surprised since this is a JS tool.

logLevel: config.LOG_INFO,
Try LOG_DEBUG and look through the log. It will report coverage events.

I am trying to use it on an Angular project where everything is in TypeScript.
I tried with ts and with js, but the coverage report never finds any files...

I set the log level to LOG_DEBUG, and it prints out a lot of text to the console. However, I don't see anything in there that says what's wrong with the coverage...
 Babel users should use the istanbul babel plugin
https://github.com/istanbuljs/babel-plugin-istanbul to instrument your
code and webpack + typescript users should use the
istanbul-instrumenter-loader
https://github.com/deepsweet/istanbul-instrumenter-loader and then use
this karma reporter to do the actual reporting. See the test config
https://github.com/mattlewis92/karma-coverage-istanbul-reporter/blob/master/test/karma.conf.js
for
an e2e example of how to combine them."
On Wed, Mar 18, 2020 at 5:15 PM Jim Lynch<EMAIL_ADDRESS>wrote:

I set the log level to LOG_DEBUG, and it prints out a lot of text to the
console. However, I don't see anything in there that says what's wrong with
the coverage...

Reply to this email directly, view it on GitHub
https://github.com/karma-runner/karma/issues/3445#issuecomment-600920167,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABSGAWZOEU2UDDZ45R32SLRIFP3BANCNFSM4LIA4LIQ
.

Thanks so much @johnjbarton 🙏
the thing is... I am already using karma-coverage-istanbul-reporter, and it doesn't seem to be doing anything.
Thanks for your example config file. The thing is, my karma config from a recently scaffolded Angular project using ng new looks WAY different from the one you provided so I am still extremely confused as to what I'm supposed to change.
Here is my karma.conf.js: https://github.com/JimLynchCodes/Angular-TDD-BDD-2020/blob/master/TddBdd2020/karma.conf.js
Can you please instruct me on what exactly I need to change here to get it working? 🤔
Thanks! ❤

the thing is... I am already using karma-coverage-istanbul-reporter, and it doesn't seem to be doing anything.

That is the expected result. That reporter just reports coverage in a nicer way. It does not compute coverage. Thus you get zero coverage, reported nicely.

@johnjbarton So you are saying there is no way to get the coverage to report on the files...? 🤔

No, I am saying that you need to add something like karma-coverage to your config.

For anyone else having this problem, I finally figured it out after finding this blog post.
In the end, I was able to use the default karma config file from a fresh ng new scaffold with no changes to the karma file at all.
Just install the dependencies:
npm install karma karma-jasmine karma-chrome-launcher karma-jasmine-html-reporter karma-coverage-istanbul-reporter

And then add the --code-coverage flag when running the tests:
ng test --code-coverage

And now finally, it sees my files. 🎉


Upgrade UAA to 3.2.1

We brought master on cg-uaa to current, so this just removes the branch specifier :)

Looks good thanks!


Screen Reader NVDA 2015.2 reads the heading twice

The current day/month/year heading with ARIA tags indicating a live region (role="heading", aria-live="assertive", aria-atomic="true") is being read twice sometimes:

Hi @TheLast, do you know what is the culprit here?

hi @wesleycho,
I have the same problem. At first I thought that it's somehow related to Angular (i.e. twice setting of scope.title var), but adding a watcher to test if that's the problem showed that setter is called only once,  so I believe that's a problem somehow related to aria-roles.

Hi @wesleycho and @ssmirnow
Here's an example of accessible datepicker with the same ARIA roles: oaa-accessibility.org/example/15/
Still difficult to say if it's not a fault of ARIA roles working with angular

Closing in favor of #4772.


Solution Explorer crashes when startet w/o solution

Starting VStudio 2013 without a solution, the solution explorer does not show anything when loading a solution afterwards.
After disabling the paket addin, it works fine.

/cc @hmemcpy - ideas?

In debugging mode, I cannot see anything unusual... maybe there are other extensions interfering?

yes I was looking into this, but could not reproduce.

Sorry, I'm still not near an actual computer...
Could you please run Visual Studio with devenv.exe /log c:\temp\log.xml,
then reproduce the problem and attach the log here? Maybe the stacktrace
will be visible.
@forki In any event, it really doesn't make sense for the extension to load
if no solution was loaded, so inside the main package.cs file, try removing
the attribute with NoSolution parameter...
On May 19, 2015 7:08 PM, "Steffen Forkmann"<EMAIL_ADDRESS>wrote:

yes I was looking into this, but could not reproduce.
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket.VisualStudio/issues/48#issuecomment-103569157
.

[ProvideAutoLoad(UIContextGuids.SolutionExists)]
[PackageRegistration(UseManagedResourcesOnly = true)]
[InstalledProductRegistration("#110", "#112", "1.0", IconResourceID = 400)]
[ProvideMenuResource("Menus.ctmenu", 1)]
[Guid(Guids.PackageGuid)]
public sealed class PaketPackage : Package
{
}

there is no NoSolution

Oh, for some reason I thought there was :(
Well, let's hope the log reveals the problem
On May 19, 2015 8:19 PM, "Steffen Forkmann"<EMAIL_ADDRESS>wrote:

[ProvideAutoLoad(UIContextGuids.SolutionExists)]
[PackageRegistration(UseManagedResourcesOnly = true)]
[InstalledProductRegistration("#110", "#112", "1.0", IconResourceID = 400)]
[ProvideMenuResource("Menus.ctmenu", 1)]
[Guid(Guids.PackageGuid)]
public sealed class PaketPackage : Package
{
}
there is no NoSolution
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket.VisualStudio/issues/48#issuecomment-103600048
.

After disabling and re-enabling Paket.VS, the effect has gone.
I'll try it at home. If it happens again, I will use the devenv parameters to see what is going on.

Cannot reproduce again. Maybe earth radiation.


Pr/prefix config option

What:
Added the ability to configure an alternate prefix when transforming environmental variables (instead of VITE_).
{
  "plugins": [
    [
      "babel-plugin-transform-vite-meta-env",
      { "prefix": "REACT_APP_" }
    ]
  ]
}

{
  "plugins": [
    [
      "babel-plugin-transform-vite-meta-env",
      {
        "prefix": ["REACT_APP_" , "VITE_"]
      }
    ]
  ]
}

Why:
I would like to use this plugin with a React app that is being updated to use Vite instead of create-react-app, but I need the ability to inject environmental variables with a different prefix.
How:
I removed VITE_ as a possible Regex matcher and added code to use an alternate prefix from the plugin settings.
Checklist:

[ x] Documentation updated
[ x] Tests
[ x] Ready to be merged
[ x] Added myself to contributors table

Thank you for considering this PR!  🙂
Note: The script npm run contributors:add does not exist so I manually added myself to .all-contributorsrc.

This would also be a big help in storybook with the STORYBOOK_ prefix, when re-using sources from the main tree in a local storybook addon.

@andrew-kramm Storybook's Vite builder accepts an array param for this. Would it be hard to amend this PR to do the same? What I'd like is ['VITE_', 'STORYBOOK_']

@andrew-kramm Storybook's Vite builder accepts an array param for this. Would it be hard to amend this PR to do the same? What I'd like is ['VITE_', 'STORYBOOK_']

Yes, that is an easy update.  I will push an update in the next day or so.

I push a commit to support a string or an array of strings.

Codecov Report

Merging #9 (bf61fb2) into main (5e04373) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           67        79   +12
  Branches        22        28    +6
=========================================
+ Hits            67        79   +12

Impacted Files
Coverage Δ

.../babel-plugin-transform-vite-meta-env/src/index.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e04373...bf61fb2. Read the comment docs.

Can you talk a little bit more about the use cases here? This plugin is specifically to replicate Vite functionality, which, as I understand it, is an alternative to CRA.
I get that this is a relatively minor change to the code, but I’m wary to move too far away from its purpose.

@mpeyper My code ends up running in a few different contexts:

Build for release with Vite.
Run tests in Jest with Babel.
Develop in Storybook which has a Vite builder, but has a different prefix for environment variables
Run storyshot tests combining Storybook with Jest.
Run my code as part of an add-on in the Storybook manager.

The biggest problem is that different projects want to impose different prefixes, and they aren't always configurable, so it's hard to make them agree. This PR would help to ease the integration.
Also I'd point out that Vite itself is also configurable, and like this PR, allows either a string or array of strings: https://vitejs.dev/config/#envprefix
so currently the Babel plugin doesn't properly replicate Vite until this PR is merged. :stuck_out_tongue_winking_eye:

Thanks for the explanation @agriffis. The fact that vite is also configurable in the same way means we need this 😅
I’ll give the code a proper review after the kids go to bed tonight, but expect it to be merged soon.

I made some changes to the PR, the main ones being changing the option to envPrefix to match the Vite config setting and  to allow the options to be set for the preset as well and passed through the plugin via the existing env.
The other minor changes were typing the option for the plugin, and restructuring the README docs to match the style of the Options docs of the preset for consistency.
I also added the missing all-contributors script fo the next contributor 😅
While I was going through this, I thought it would be really nice if we could default to the configured envPrefix of the Vite config (falling back to VITE_ if not configured) rather than forcing users to set it twice, but Ii's probably more effort than it's worth.  Definitely not required for this PR, but if someone reading this want to have a crack at it in a follow up PR I'll happily review it.

I'll let this sit now until tomorrow night to give a chance for feedback on my additions.

Changes look good.  The README.md needs the following updates to reflect the code changes:
const mode = process.env.MODE;
const baseUrl = '/';
const nodeEnv = process.env.NODE_ENV || 'test';
const dev = process.env.NODE_ENV !== 'production';
const prod = process.env.NODE_ENV === 'production';
const viteVar = process.env.VITE_VAR;
const other = {
  ...Object.fromEntries(Object.entries(process.env).filter(([k]) => k.startsWith('VITE_'))),
  NODE_ENV: process.env.NODE_ENV || 'test',
  MODE: process.env.NODE_ENV || 'test',
  BASE_URL: '/',
  DEV: process.env.NODE_ENV !== 'production',
  PROD: process.env.NODE_ENV === 'production'
}.OTHER;
const env = {
  ...Object.fromEntries(Object.entries(process.env).filter(([k]) => k.startsWith('VITE_'))),
  NODE_ENV: process.env.NODE_ENV || 'test',
  MODE: process.env.NODE_ENV || 'test',
  BASE_URL: '/',
  DEV: process.env.NODE_ENV !== 'production',
  PROD: process.env.NODE_ENV === 'production'
};

And perhaps a code example showing multiple prefixes:
With multiple prefixes:
{
  "plugins": [
    [
      "babel-plugin-transform-vite-meta-env",
      {
        "envPrefix": ["CUSTOM1_", "CUSTOM2_"]
      }
    ]
  ]
}

Also, consider using the js language in for the code in the "In" and "Out" sections.

@mpeyper Just checking in.  How is the PR coming?

I’ve not looked at the documentation improvements (very busy week), but agree with the intention. Unfortunately I’m away for the weekend and won’t be able to look at anything until Monday now.
If you want to add code snippets to the Options sections and fix the output examples then I can review and merge from here.


WARNING: Multiple instances of Three.js being imported.

i'm getting this console log
WARNING: Multiple instances of Three.js being imported.
these two should be peerDependencies, by depending on them the bundler will include two bundles for threejs.
	"dependencies": {
		"postprocessing": "^6.28.0",
		"three": "^0.141.0"
	},

Oh I see, thanks for reporting. That should be resolved now.


data Symbolic link

Why is there a symbolic link in the data folder to itself?

No idea. I'll get rid of it. Hopefully that doesn't destroy everything!...


Response Size Not Shown

If content length is missing from the response, Bruno shows 0B. It would be super useful to show what was actually transferred.
Compare this to Insomnia, where it will show what was actually transferred. Mousing over this will show the separate Read and Content info. In the case of compression these two values would differ.

Can you please take a look at the closely related issue and confirm if this is a duplicate? https://github.com/usebruno/bruno/issues/497

Good spot, it's a duplicate. I must have missed that when I searched.


Fix extra args arrays for activation ops (when non-default values are set)

Build triggered. sha1 is merged.


Crash due to race condition when parsing Steam manifests

SKIF can still get into a thread race that can cause a crash in super rare instances. I need to investigate this further, but from the looks of it it's caused by SKIF changing the selected game on launch while the appmanifest of another game is still being read in the child thread that handles streaming icons and game names
2022-08-04 20:08:41.453 VERB  [5184] [SK_UseManifestToGetAppName@579] Steam AppID: 1286680
2022-08-04 20:08:41.453 VERB  [5184] [SK_GetManifestContentsForAppID@368] Steam AppID: 1286680
2022-08-04 20:08:41.453 VERB  [22780] [SK_UseManifestToGetAppName@579] Steam AppID: 1815780
2022-08-04 20:08:41.453 VERB  [22780] [SK_GetManifestContentsForAppID@368] Steam AppID: 1815780
2022-08-04 20:08:41.453 VERB  [5184] [SK_Steam_GetApplicationManifestPath@328] Steam AppID: 1286680
2022-08-04 20:08:41.453 VERB  [22780] [SK_Steam_GetApplicationManifestPath@328] Steam AppID: 1815780
2022-08-04 20:08:41.453 DEBUG [5184] [SK_GetManifestContentsForAppID@394] Reading G:\\Games\\SteamLibrary\steamapps\appmanifest_1286680.acf
2022-08-04 20:08:41.453 DEBUG [22780] [SK_GetManifestContentsForAppID@394] Reading O:\\Games\\SteamLibrary\steamapps\appmanifest_1815780.acf
2022-08-04 20:08:41.453 DEBUG [22780] [SK_UseManifestToGetAppName@586] Parsing manifest for AppID: 1815780
2022-08-04 20:08:41.453 DEBUG [5184] [SK_UseManifestToGetAppName@586] Parsing manifest for AppID: 1286680

Take inspiration from the Monitor tab and use a double-buffered approach maybe?

Monitor tab ended up being changed to a triple-buffered approach as SKIF could still crash with the double-buffered approach if the child thread happened to finish the result faster than the main thread finished reading the latest results.
A triple-buffered approach shouldn't be needed for the Library tab.

This was partially fixed by commit c1303e6, but the new design is not the intended final design.
Eventually SKIF will use a triple-buffered approach akin to the Monitor tab and other components of SKIF.

After having gone through and focused extensively on I/O optimizations related to the parsing and processing of Steam games, I think this bug has finally been properly solved in its current form.
There were multiple race conditions that occurred as a result of data related to Steam game being parsed and inserted into the apps object from multiple threads at the same time, causing crashes as a result. The excessive file reads and I/O operations contribued to this issue, as a lot of data wasn't properly cached and retain in memory, with e.g. the appmanifest acf file being opened, read, and parsed multiple times at different points just to extract a tiny amount of data from it.
The optimizations and improvements focused heavily on reducing all of these excessive I/O operations to the minimal amount necessary for SKIF to do its thing. The appinfo.vdf file is read and cached in memory at launch, as is the appmanifest_*.acf files. All appmanifest files are then processed during launch by the main thread as these contain the install directory and in some cases name of the game. The appinfo.vdf data is then parsed when a game gets selected in SKIF.
Upon selection of a game in SKIF, temporary data such as the injection strategy for the launch configurations is refreshed.
All in all, these changes all combined resulted in major delays and slowdowns in SKIF being reduced next to nothing -- especially for users with huge Steam libraries installed, with I/O operations reduced from thousands (or maybe even tens of thousands in some cases?) to just a few dozens or hundreds depending on the number of installed games.

A threaded worker approach to load the library was reintroduced over the last week. The worker is kept rather basic, to prevent it from messing around with resources shared with other threads.
The processing and logic of the Library tab is also heavily enforced, with no out-of-order calls allowed. The pApp pointer now always gets reset on each frame, and always gets set to the currently selected game at the beginning of the frame after any new refreshed games have been swapped in to the main thread.


origins

Is it possible to make achievements unlocker for EA origin or uplay? or it is completely server sided?

I've never looked at either service, it's likely absolutely possible, but I don't hold any interest in doing that personally.


Convert from BabyBearField to p3 babybear without going through integers

fixed in https://github.com/powdr-labs/powdr/pull/1693/commits/7d1ae5eca5745a084bc087e49d284bd59486ddfc


multiple Flux suppliers don't work

I have a spring cloud stream kafka application with two suppliers.
But it only works, if I comment one out (both are working if the other one is not there).
@Bean
public Supplier<Flux<Message<Product>>> productSupplier() {
    return () -> Flux.from(emitter -> {
        while (true) {
            try {
                emitter.onNext(createProductMessage());
                Thread.sleep(1000);
            } catch (Exception e) {
                // ignore
            }
        }
    });
}

and in another class
@Bean
public Supplier<Flux<Message<Channel>>> channelSupplier() {
    return () -> Flux.from(emitter -> {
        while (true) {
            try {
                emitter.onNext(createChannelMessage());
                Thread.sleep(1000);
            } catch (Exception e) {
                // ignore
            }
        }
    });
}

Edit
When I change both suppliers to work without Flux, everything works.

See the documentation.
When there is more than one binding, you must specify them using the spring.cloud.function.definition property (productSupplier;channelSupplier).

See the documentation.
When there is more than one binding, you must specify them using the spring.cloud.function.definition property (productSupplier;channelSupplier).

When I change both suppliers to work without Flux, everything works.

It has nothing to do with a wrong configuration...

When I change both suppliers to work without Flux, everything works.

It has nothing to do with a wrong configuration...

If you are still having problems, reopen this and provide a complete, minimal, example that exhibits the behavior you see.

If you are still having problems, reopen this and provide a complete, minimal, example that exhibits the behavior you see.