[New game]:

🎮 Game Request
Create a game window and ball object. Handle user input for movement. Implement physics for ball motion, gravity, and collisions with platforms. Design platforms as rectangles. Track and display the score. End the game when the ball falls off the screen. Implement a game loop for continuous updates. Optionally, add graphics and sound effects for a better gaming experience.
Point down the features

Game Window: Set up a display interface for the game.
Ball Object: Create a movable ball with properties like position and speed.
User Input: Enable user interaction for controlling the ball's movement.
Physics: Implement gravity and collision detection for realistic ball behavior.
Platforms: Design surfaces for the ball to bounce on.
Scoring: Keep track of points earned during gameplay.
Game Over: End the game when the ball falls off the screen.
Game Loop: Continuously update game elements for seamless gameplay.
Graphics/Sound: Enhance the experience with visual and audio effects.

Select program in which you are contributing
hacktoberfest
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Darkrider0007 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @Darkrider0007!
We are already having a similar game request in #2996 👀
Make sure you come up with a cool unique idea 😀
Waiting for your new game idea 💗.

Hey @Darkrider0007 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Dashboard improvements

This merge request addresses several improvements for the dashboard.
Closes #121
Closes #89
Closes #118

I saw latest release is v2.2.1, maybe this one should be v2.2.2


encoding was remove in python 3.9

I use python 3.10, what should I do to use API sdk?
`

from huobi.client.account import AccountClient
from huobi.constant import *
from huobi.utils import LogInfo
account_client = AccountClient(api_key=g_api_key,
secret_key=g_secret_key)
LogInfo.output("====== (SDK encapsulated api) not recommend for low performance and frequence limitation ======")
account_balance_list = account_client.get_account_balance()
if account_balance_list and len(account_balance_list):
for account_obj in account_balance_list:
account_obj.print_object()
print()

`
Some error comeup
TypeError: JSONDecoder.init() got an unexpected keyword argument 'encoding'

Still not fixed.

Same issue here. This repo is completely broken if anybody uses Python 3.9 or above. I’m using Python 3.11.
It’s not a difficult fix:
venv/lib/python3.11/site-packages/huobi/connection/impl/restapi_invoker.py >> call_sync():
dict_data = json.loads(response.text)  # Remove parameter ‘encoding’, similarly for all other json.loads() calls.


Cannot import name 'moduleTNC' on windows with conda

Hello,
I open another issue on this subject https://github.com/scipy/scipy/issues/6188
I use scipy on windows machine, python2.7 and conda installed it like: https://github.com/scipy/scipy/issues/6188#issuecomment-221669131
This doesnot solve the issue.
I rename moduletnc.pyd to moduleTNC.pyd and it works like https://github.com/scipy/scipy/issues/6188#issuecomment-338697754
I look at tarballs and seems OK.
It might be a conda problem.

Hi @slamer59. Thanks for reporting This is already mentioned in the linked issue and in the SO question. This looks like a conda issue so you might want to take is to them. We can't do anything about this.


Native module web

Implemented web version of the lib.

Please tag me for PRs on this repo. I don't get notifications for it.

@azimgd is this ready for review?

Yeap

I essentially aligned the logic of keycommand tracking to the one we implemented natively in the previous PR's

I will start testing this today.

It's getting close to 2 weeks since the PR was opened, can we speed things up please?

Yeah, of course.

I am getting an error on ``npm i` in example folder.

I will take a look tomorrow. Can you apply “force” flag for testing only

Ok

BUG: Does not work for me on the web?

@azimgd Any update?

On it, missed your previous comment.

Apologies for the late replies, I was ooo for the past 15 days. I believe that I replied to all comments I was tagged in and I'll review this once @parasharrajat is done with their review!

No worries, I guessed it.

@azimgd any updates?

@parasharrajat updated, please try npm install again.

Thanks, we do in 20 mins.

Error on build
ERROR in [eslint] Plugin "react" was conflicted between "../package.json » eslint-config-expensify » eslint-config-airbnb » /home/anonymous/Documents/Clients-Upwork/react-native-key-command/node_modules/eslint-config-expensify/node_modules/eslint-config-airbnb/rules/react-a11y.js" and "BaseConfig » /home/anonymous/Documents/Clients-Upwork/react-native-key-command/example/node_modules/eslint-config-react-app/base.js".

Error on build
ERROR in [eslint] Plugin "react" was conflicted between "../package.json » eslint-config-expensify » eslint-config-airbnb » /..../react-native-key-command/node_modules/eslint-config-expensify/node_modules/eslint-config-airbnb/rules/react-a11y.js" and "BaseConfig » /..../react-native-key-command/example/node_modules/eslint-config-react-app/base.js".

Please refactor the code where necessary as per the above comments. I tested shortcuts are working now.

+1 is to highlight the previous threads and to tell that, they are still valid.

@luacmartins Question https://github.com/Expensify/react-native-key-command/pull/10#issuecomment-1332350465.
@azimgd  Question: https://github.com/Expensify/react-native-key-command/pull/10#pullrequestreview-1199545226

Is the idea behind implementing the web platform to replace the key handler implementation on newDot with this package?

Yes, this should be possible. I don't think it makes sense to have multiple key handlers in that case.

OK Thanks.

all comments addressed @parasharrajat ?

I am getting this warning on building the example app.

Question: How can we prevent the default event handler on web?

How can we prevent the default event handler on the web?
Are we passing the event down to the handler?

Passing native keyboard event as a second argument to the function now:
KeyCommand.addListener(KEY_COMMAND, (payload, event) => {})

I am getting this warning on building the example app.

Can you clean and re-install node_modules, does that fix ? I'm pretty sure I updated the nested dependencies.

updated.

Still, seeing this error after npm ci?
https://github.com/Expensify/react-native-key-command/pull/10#issuecomment-1336939615

Nope, it used to but not right now. Try setting eslint=false in craco config and let me know

Testing.

Not sure I understand.

What points are we missing here so that CR is complete for you and can be handed over to @luacmartins ?

I think you are not carefully reading the comments or I am not communicating them correctly.
I still haven't got any answers to https://github.com/Expensify/react-native-key-command/pull/10#pullrequestreview-1204085893.

const KEY_COMMAND = {input: 'f', modifierFlags: KeyCommand.constants.keyModifierControl};
return KeyCommand.addListener(KEY_COMMAND, () => handleSearchCommandPress('[Ctrl + F] pressed'));

You are saying that Ctrl doesn't work for you ?

Yeah, I tried this https://github.com/Expensify/react-native-key-command/pull/10#issuecomment-1335694299 for CTRL+SHIFT+F. It didn't work.

This one is working.

What else are we missing ?

@azimgd I understand that you have made the requested changes and you must be feeling excited to get this completed asap. But as you can take time to make the requested changes, we are also busy with other stuff. we can not be focused on a single PR forever and review it as soon as the contributor has pushed new changes.
If you want the review to go faster, we can work together to update daily and I will do my best to share updates regularly or even multiple times a day.

You essentially requested a change for which an update was applied and comment + commit with updates were provided. I truly believe having batched reviews instead of partials will make CR process faster for both parties.

I take that as feedback but I try to cover as much as I can in one go further reviews are things that are found along the way and during testing.
There is no point in explaining my testing approach but this most of the time cover vast areas than the PR is related to.

@luacmartins done.


Fixed the issue that methods return items before the clicked item becomes checked/unchecked

Maybe this change can solve the problem that woemler reported in issue #22?

Hi HectorWon,
Thank you for your PR. I just checked the code and the callback of the change event call the method this.onClickCheckbox which is now weird since it's not the same event. Could you rename onClickCheckbox into onChangeCheckbox?
In addition, I'm not sure to agree with the change of .gitignore in the same PR. I would prefer having different PR/commit.
Btw, did you run the tests as well?
Thank you very much,
Kevin

@Nelrohd
Hi Kevin,
I just started front end programming 2 months ago, and I am not very familiar with git and github. I changed the pull request a little bit, hope this is what you want.
I don't know how to run the test file. I just opened the tests/index.html in the browser, and checked all three options. It reports 0 failed. But I am not sure whether it is the right way to run the tests.
Thanks,
Minxin

Thanks @HectorWon and no problems.
About the tests, yes, it's just that. However it's not the best way to run test but I will improve it soon.
I would accept your PR if you fix your conflict with the current master so I can merge it. You can check the procedure there https://help.github.com/articles/fork-a-repo/#step-3-configure-git-to-sync-your-fork-with-the-original-spoon-knife-repository
Thank you again,
Kevin

Thanks for the link, Kevin. I think I've fixed the conflict. Maybe you can check if it is OK to merge now.
Thanks,
Minxin

Thanks you very much, it's perfect.
Kevin

Just a little thing: too avoid lot of commit (and mainly the ones reverted), you should squash them. http://stackoverflow.com/questions/8213926/git-simplest-way-of-squashing-commits-on-master
So after that, you will only see one big commit or the main commits at least.

Thanks for the link. I'll learn how to squash commits.

@HectorWon No problem and thank you again for the PR. I will add soon the list of every single contributor in the README.md

@Nelrohd
Hi Kevin,
I found the min.js file is not working. Maybe I didn't make it correct.

Did you grunt it?

Yes, but maybe I forgot to grunt it again after the final change yesterday.
And I learned how to squash multiple commits. But it will not take effect on this one, since the PR is already merged, right?

Everything is possible with GIT but it may be complicated and it's not always good to rewrite the history once is done. For the min.js, you will have to create a new PR.


When watching the video, it will enter the lock screen

Don’t want to enter the lock screen while watching a video.
Hope to add a judgment logic.

I don't believe this is a problem with this screensaver perticuarly, but with the way screensavers work in general.
As mentioned by many others online, you'll have to turn your screensaver off or have your mouse move (maybe a Mouse Jiggler app helps you).

I don't know if there is something wrong with the update of Edge browser.
Thank you for your prompt reply anyway

Screensaver doesn't decided when its turn on, windows os is. Most fullscreen apps usually block screensaver activation. FlipIt doesn't control that behavior only when turn off if you move mouse.

Screensaver doesn't decided when its turn on, windows os is. Most fullscreen apps usually block screensaver activation. FlipIt doesn't control that behavior only when turn off if you move mouse.
yea
In fact, when I watch local videos, the screensaver won't appear after the scheduled time.
But when I watch a video online in my browser, the screensaver appears.
A recent update to the Edge browser may have caused this situation, but it didn't happen before.

Screensaver doesn't decided when its turn on, windows os is. Most fullscreen apps usually block screensaver activation. FlipIt doesn't control that behavior only when turn off if you move mouse.

yea
In fact, when I watch local videos, the screensaver won't appear after the scheduled time.
But when I watch a video online in my browser, the screensaver appears.
A recent update to the Edge browser may have caused this situation, but it didn't happen before.


download it when real version.

https://github.com/bazelbuild/setup-bazelisk/issues/120

Closing this PR because this repository is about to be archived.


nginxMainline: 1.25.1 -> 1.25.2

Description of changes
Update Nginx Mainline to version 1.25.2.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

The latest versions of Nginx Mainline do not require QUIC support in OpenSSL. Maybe add HTTP3 support to Nginx Mainline by default and remove Nginx Quic?

But it still requires quictls to enable QUIC, no? So either we build nginxMainline with quictls or we lose this feature?

Hm. Maybe we can keep around nginxQuic then, until nginxMainline has reached feature parity?


Subtraction causes intermittent error

I came across an intermittent issue that took some experimentation to track down. I was using a oneliner function for taring dataframes (or series, I've noticed the issue there as well) based on the last 50 rows:
def tare(df):
    return df - df[-50:].mean()

On rare occasions, this gave me an obviously wrong result (whole columns close to or equal to zero). negating the mean series and then adding
def tare(df):
    return df + (-df[-50:].mean())
# OR
def tare(df):
    return df + (-1.0 * df[-50:].mean())

will not solve the issue either.
Is there any other way I could/should write the function that will not cause the same issue?
Below is a full reproduction that works on my system.
import pandas as pd

def tare(df):
    return df - df[-50:].mean()

df = pd.read_csv('bug.txt')
for i in range(20000):
    try:
        assert tare(df).max().max() > 1.0
    except:
        print 'Failed on iteration {}.'.format(i)
        raise

Requires the file bug.txt containing a subset of my data.
I haven't tried reproducing it using random data, but I guess that should be possible.
INSTALLED VERSIONS
------------------
commit: None
python: 2.7.11.final.0
python-bits: 64
OS: Windows
OS-release: 10
machine: AMD64
processor: Intel64 Family 6 Model 78 Stepping 3, GenuineIntel
byteorder: little
LC_ALL: None
LANG: None

pandas: 0.17.1
nose: 1.3.7
pip: 7.1.2
setuptools: 18.5
Cython: 0.23.4
numpy: 1.10.1
scipy: 0.16.0
statsmodels: 0.6.1
IPython: 4.0.1
sphinx: 1.3.1
patsy: 0.4.0
dateutil: 2.4.2
pytz: 2015.7
blosc: None
bottleneck: 1.0.0
tables: 3.2.2
numexpr: 2.4.4
matplotlib: 1.5.0
openpyxl: 2.2.6
xlrd: 0.9.4
xlwt: 1.0.0
xlsxwriter: 0.7.7
lxml: 3.4.4
bs4: 4.4.1
html5lib: None
httplib2: None
apiclient: None
sqlalchemy: 1.0.9
pymysql: None
psycopg2: None
Jinja2: None

almost certainly this: https://github.com/pydata/pandas/issues/12023
upgrade to numexpr=2.4.6 and all will be ok

Many thanks for the quick response. It seems that upgrading numexpr solved it :smile:


Updated Rust installation instructions

Updated the Rust installation instructions to include shell configuration step.

Travis CI is expected to fail until PR #408 is merged.

@dependabot rebase


Performance: uniqueChars in exportToSVG includes all chars regardless of font faces

While debugging #8677 I noticed that the logic in exportToSvg will result in unnecessary glyphs being included in the SVG file depending on the font faces and the text in the scene. This is because uniqueChars is not calculated by font face but for the whole batch.
@Mrazator Am I missing something?

This will actually cause problems in ExcalidrawFontFace.toCSS
when fonts will be rejected due to characters outside their range... yet those characters were intended for a different font. I can imagine this when mixed latin and cjk text is displayed.
  public toCSS(
    characters: string,
    codePoints: Array<number>,
  ): Promise<string> | undefined {
    // quick exit in case the characters are not within this font face's unicode range
    if (!this.getUnicodeRangeRegex().test(characters)) {
      return;
    }

this is because codePoints here represent codepoints from all text elements, not text elements with this font.

This is because uniqueChars is not calculated by font face but for the whole batch.

Yeah, this was initially on purpose to keep things simple, as we aimed at having a common CJK fallback for any font. Hence including one more "alphabetic" font face when you already had 250 font faces didn't make much difference. Now this further optimization for alphabetic fonts might be actually quite trivial, let me check what we can do.

when fonts will be rejected due to characters outside their range.

Could this happen really? In the worst case, more font faces will be subsetted and included in the SVG, as we have more codepoints to check - but none should really be rejected. In other words, it's enough that just one character matches the regex, it does not matter that there are also characters out of the given range.

Done in https://github.com/excalidraw/excalidraw/pull/8641


MM-51000 fix withBackupValue

Summary
Fix selector. Because limits were getting loaded more than once, when they got cleared, the usage existed, but the limits did not, and the backup value getting picked was 0, when it should have been max number (assumed no limit if we have not yet loaded a limit).
Ticket Link
https://mattermost.atlassian.net/browse/MM-51000
Screenshots
https://user-images.githubusercontent.com/13738432/222208409-4070fdf0-6266-41b9-98b6-f481ab2d6cbd.mp4
Release Note
Fix issue where cloud limits would briefly flash in system console before disappearing.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

thank you Nathan,
the cat section is not appearing now.
https://user-images.githubusercontent.com/15979783/222403433-a961dded-31e0-4e4b-a342-e094b0ed4526.mov


Config additions

Nothing major, just a few ideas that I didn't want to lump in with the other branch too much.
Also, Bottle is now treated like arrows and missiles are, rather than like the sword.

If you're switching the bottles to work like missiles, we can probably delete the multiple bottle images, right?

Yes, but the setup isn't configured to delete images that no longer exist, and this is the easiest way to accomplish that.

Ah, that's right. Fair enough.


Redesign pricing page with 3 tiers

Description
Design update for the pricing page
Related Issue(s)
Closes #713
Checklist

[ ] I have read the contribution guidelines
[ ] I have considered the performance impact of these changes
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

The faded letters, combined with the arrow down makes me click the arrow down. I expected the box to extend down?

The faded letters, combined with the arrow down makes me click the arrow down. I expected the box to extend down?

Hmm... I had my doubts about this. The idea is to convey that those are not all the features, so the user scrolls down, and the chevron was supposed to indicate that the rest of the information is below. But if it made you click it, maybe it would be better to just remove it?

But if it made you click it, maybe it would be better to just remove it?

Or make the screen drop to the feature list? With an anchor?


fix typo

INetworkClient supposed to be NetworkClient

Interface? But there are no interface in rust though, if it is a trait, why not name it something else like TheNetworkClient or something clearer? I think I have seen something like that in rxjs and it is an anti-pattern for angular.

I think part of the point is that there is no good name for it. I agree that in general the IFoo is an anti-pattern and not recommended but that's the point in this case.
It cannot be NetworkClient because that's the name of the struct. TheNetworkClient does not make sense either because it is not THE network client, it is a trait for anyone that can implement a NetworkClient. While I agree that INetworkClient is not ideal, part of the point is that there is no good name for this trait because it doesn't add anything new of value, it just adds abstraction purely for test-sake.

Naming the trait after its (only) function is a Rust pattern. FetchIdMatching?

That's slightly better but I think for the point that the blog is trying to make it doesn't help since in reality this struct (and therefore the trait) would have a lot of methods. The example is showing a very simplified view of it, and I don't think that renaming it to match the only method helps in the clarity of the post.
I understand that it was confusing for you, @pickfire but I am wondering if there is a way to make my intention more clear without renaming the trait, or renaming it to something that still conveys the point of the post clearly. It is not that I am opposed to editing the post, I just really do not think that TheNetworkClient or FetchIdMatching are particularly helpful to understanding what the example is tyring to convey, which is that the trait is unnecessary and in fact causes confusion.

@nrxus I think another solution is to explain I, an interface which does not appear in Rust. Some languages IIRC have that, but not everyone came from those areas. Looking at C, Go, Python, Javascript and PHP, I don't see how I fits in (maybe some of those did but from what I know it is an anti-practice), but of course it will be good if the blog is niche.

Could renaming it to TNetworkingClient be enough? I can then explain why I named it that.

Ah, that would be great. The first thing that came into my mind was Type but after second thought I think it is Trait.


Decided what to do with ALL_OBJ_VER in SuiDataStore

Previously ALL_OBJ_VER is a boolean type template used to control whether to store all historic versions of objects.
However after changing the key to objects to ObjectKey, I think we are storing older versions of objects anyway. This makes ALL_OBJ_VER redundant at the moment. Do we still need it?

Yeah, we should remove it as we store all versions right now.   Need to re-organize object storage a little bit but can definitely do this quickly right now.

Merged and closed


Split up wagtail.core.models

About time, I think. :-)
Everything page-related is still in the top-level module (which will hopefully reduce the number of merge conflicts with current PRs), and 'noqa' imports have been added to ensure that everything is still importable from their old locations. (Third-party code could still potentially break if tries to import things from wagtail.core.models that actually exist in e.g. wagtail.core.utils, but at least it will break in an obvious way...)

non-blocking question: would it help devs to add a note in .audit_log / .view_restrictions that specific implementations are in the relevant modules?

Good idea! The direction of dependencies here (submodules providing the base implementations for the page-specific ones in wagtail.core.models to use) seems fairly obvious now, but it's exactly the sort of thing that's likely to slip over time if we don't document it explicitly... will add that when I merge.


Allow seeds to be passed to the random instance in property tests

This will allow a test to be re-run with the same random data.

Duplicate of #815


Accept Test262 at version 2

Test262 at version 2 includes an additional "phase" for negative tests.
Because this is expressed within the same YAML format used in Test262 at
version 1, no change to the application code is required.
Enable the use of this module with Test262 at both version 1 and 2.

Would close #8.


ReFS support

I've been investigating the possibility of building a custom snapshotter for containerd that can make use of ReFS block cloning to help speed up container start times by reducing IO.
However I'm getting the following error
time="2023-08-31T14:01:19Z" level=info msg="apply failure, attempting cleanup" error="failed to extract layer sha256:e3ed4837ac41531c693a2a70929b7c50ce22997f81268031dabc470345139022: hcsshim::ProcessBaseLayer \\\\?\\D:\\ProgramData\\containerd\\root\\io.containerd.snapshotter.v1.refs\\snapshots\\1: Incorrect function.: unknown" key="extract-957600700-rp30 sha256:e3ed4837ac41531c693a2a70929b7c50ce22997f81268031dabc470345139022"
ctr: failed to extract layer sha256:e3ed4837ac41531c693a2a70929b7c50ce22997f81268031dabc470345139022: hcsshim::ProcessBaseLayer \\?\D:\ProgramData\containerd\root\io.containerd.snapshotter.v1.refs\snapshots\1: Incorrect function.: unknown

Is there a limitation in vmcompute ProcessBaseImage that means it's not able to work on an ReFS filesystem?

@mikenorgate Were you using docker or containerd? Could you please share your repro steps? Thanks

@mikenorgate,  refs volume is not supported by our container filter driver:

@mikenorgate,  Upon returning from the feature team, there is currently no plan to support REFS as the container layer volume. I will update this thread if there are any changes to the plan in the future.


Layers Control on mobile devices is not working as expected with Leaflet 1.9.x

Checklist

[X] I've looked at the documentation to make sure the behavior isn't documented and expected.
[X] I'm sure this is an issue with Leaflet, not with my app or other dependencies (Angular, Cordova, React, etc.).
[X] I've searched through the current issues to make sure this hasn't been reported yet.
[X] I agree to follow the Code of Conduct that this project adheres to.

Steps to reproduce

Open
https://pedrovenancio.github.io/tests/layerscontrol190.html
or
https://pedrovenancio.github.io/tests/layerscontrol193.html
with Google Chrome on a mobile device (tested on Android) or using Chrome desktop simulating mobile viewport (Ctrl+Shift+i and then Ctrl+Shift+m). This is what you will see:

Click in Layers Control icon, to open the layers list. This click changes the default base layer (Satellite) to OSM layer, despite Satellite radio button keeps selected.

This does not happen on Leaflet 1.7.1:
https://pedrovenancio.github.io/tests/layerscontrol171.html

Expected behavior
The click to open the Layers Control should not produce a change in the layer selected, just like happens in this example:
https://pedrovenancio.github.io/tests/layerscontrol171.html
Current behavior
It seems that when clicking to open the Layers Control, that click is at the same time applied to select the first layer in the list. It happens when the click coincides with radio button position.
It also happens on Firefox Beta 109.0b4 and Firefox 108.1.0 running on Android.
Minimal example reproducing the issue
https://pedrovenancio.github.io/tests/layerscontrol193.html
Environment

Leaflet version: Leaflet >= 1.9.0.
Browser (with version): Google Chrome for Android (tested on version 108.0.5359.128); Google Chrome for Windows with mobile viewport (108.0.5359.128); Firefox Beta for Android (109.0b4); Firefox for Android 108.1.0.
OS/Platform (with version): Android 11; Windows 11.

Please let me know if some more information is needed for triage and testing. Thanks!

I can reproduce this issue in Google Chrome for Android, but not using the simulated device through the desktop browser. Not sure of the cause, but this is definitely a bug we need to take a look at.
I am currently overloaded with other work so have no time to look into this right now. If anyone wants to do some deeper investigation into this issue feel free to do so and report back here.

Possibly a regression from https://github.com/Leaflet/Leaflet/pull/8556, maybe??
I'm going to guess that replacing the click event with an input event right here...
https://github.com/Leaflet/Leaflet/blob/5c29d615563835d373a51b91fc3513a17907da96/src/control/Control.Layers.js#L337
... would possibly be an easy fix. In my experience, browsers with touchscreens behave... peculiar when it comes to click/dblclick events, and this looks like one of those moments.

Is this something that would be resolved if we started using Pointer Events everywhere?

No, I don't think so. A click event should be a PointerEvent already; besides, the L.Control.Layers code doesn't use mouse* events anywhere.

The problem is the mouseenter or better mouseover event. It is fired directly before the click event. So the control is expanded when the click is fired at this specific coords.
https://github.com/Leaflet/Leaflet/blob/5c29d615563835d373a51b91fc3513a17907da96/src/control/Control.Layers.js#L189-L192
mousenter will be mapped to mouseover:
https://github.com/Leaflet/Leaflet/blob/5c29d615563835d373a51b91fc3513a17907da96/src/dom/DomEvent.js#L94-L98
https://github.com/Leaflet/Leaflet/blob/5c29d615563835d373a51b91fc3513a17907da96/src/dom/DomEvent.js#L123-L132

Hi all
Do you think this can be fixed soon?
Thanks!


Rewrite ecdsa_signature_parse_der_lax in Swift and eliminate ECC-Helper module

[x] Convert as many ECC Helper module functions as possible from C to Swift. Call LibSECP256k1 directly leveraging interoperability. Eliminate corresponding wrapper functions.
[ ] Rewrite ecdsa_signature_parse_der_lax() in Swift.
[ ] Eliminate ECCHelper swift module from package.

#138 took care of first item


DataTraceEnabled: false does not disable APIGW Log full requests/responses data

The Serverless::Api resource does not disable logging of full requests/responses data when
DataTraceEnabled: false
To reproduce.
Deploy APIGW with logging of full requests/responses data enabled
        Type: AWS::Serverless::Api
        Properties:
            MethodSettings:
            - LoggingLevel: INFO
            MetricsEnabled: true
            ResourcePath: "/*"
            HttpMethod: "*"
            DataTraceEnabled: true

then try to disable
        Type: AWS::Serverless::Api
        Properties:
            MethodSettings:
            - LoggingLevel: INFO
            MetricsEnabled: true
            ResourcePath: "/*"
            HttpMethod: "*"
            DataTraceEnabled: false

Observed result:
logging of full requests/responses data is still enabled
Expected result:
logging of full requests/responses should be disabled
This logging setting is a security sensitive as it will log all post data unencrypted in cloudwatch,  so it's important to explicitly ensure it's disabled in some use cases.

@lmunro Just for clarification, are all of the properties that you're using in the above example supposed to be nested under MethodSettings? The other properties you're using there aren't supported as top-level properties for a Serverless::Api

This looks like an indentation issue. MethodSettings should be formatted like this -
        Type: AWS::Serverless::Api
        Properties:
            MethodSettings:
            - LoggingLevel: INFO
              MetricsEnabled: true
              ResourcePath: "/*"
              HttpMethod: "*"
              DataTraceEnabled: false

You may also consider running cfn-lint on the template.


chat commands

I would like more settings for chat commands.

ability to view what is playing now
viewing your ordered tracks and their positions in the queue
the ability to vote for skipping a track

These are also good ideas, maybe we can have something like an expanded settings menu where it is possible to set these commands to be on or off and maybe set some parameters, such as how many votes are required to skip a song. I'll try to get to these when I have the time. Thanks!


markRegExp highlight individual groups?

Hi!
Sorry to bother, but is it possible to highlight individual groups in a regular expression?
I am trying to make a custom HTML/custom syntax highlighter, and it seems, that the whole regex is highlighted. There is a parameter named ignoreGroups, but it does not help much, since there are also groups after the needed keyword.
Example text: Hello world [%test:value%]
Regex: /(\[%)([a-z_]+):(.+?)(%])/g
As you can see in the example above, it's hard to separately highlight the value and the %] part.
Maybe it is possible to make a separateGroups parameter, so that each callback will receive each group? Thanks in advance!

Hi @DrParanoia!
I think I have a solution in the works for this as well... I still need to add tests and such.

See #136, and this demo.

Oh wow! @Mottie I can't believe you reacted so fast! Really nice job man!

So, when will this feature get merged? :D

@DrParanoia It'll be included in one of the next two releases.

@julmot Nice! Looking forward to it! @Mottie what about group counter, is it possible? ^^

@DrParanoia There's nothing left to do for @Mottie. It's my part now. Hope to have the time soon.

Current implementation seems to be broken if a RegExp has nested groups, such as (A(B)(C)).

Hey! I see this feature is implemented, but it's not present in the latest version. Will it be eventually on master branch?

@evheny0 It's on the master branch, actually. But, it's not released yet. I just haven't had time to take over the development again. However, maybe I'll have the time in the next couple of weeks to release a new major version.


Add option to use a custom yaml file for storing scripts

Currently derry searches for the root directory's pubspec.yaml files and reads the scripts: there. Perhaps there could be an option to pass your own script.yaml or derry.yaml  for maintaining scripts in a separate file.

The first section on README documentation here.

Thanks! Somehow missed that 😅


(Feature)(ui) Download All Images From Board

What type of PR is this? (check all applicable)

[ ] Refactor
[X] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[ ] Yes
[ ] No

Description
Add to boards context menu "Download all Images"
will download images from a board as a zip
needs a new dependency JSZip

Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

[ ] Yes
[ ] No : please replace this line with details on why tests
have not been included

[optional] Are there any post deployment tasks we need to perform?

Clever! But very brute-force-ish haha.
I coincidentally just wrote up a plan for how to implement this in https://github.com/invoke-ai/InvokeAI/issues/4832
This is a task for the back end - if you are interested to work on it, please review the suggested plan in that ticket.

Nevermind

I think what we need to do is send the path where a user wants to save from the frontend to the backend, then do the zipping with python and then just move the zip file to that given folder.


hash spd bucket get - use key without timestamp

this. code is the not updated code of hash_spd
this should be ignore and new pull request will be assign to spdb memtable


test: stop containerd before accessing the stdout

The variable buf is connected to containerd's stdout. So, accessing
the variable before killing containerd can cause a race condition.
Signed-off-by: Kazuyoshi Kato<EMAIL_ADDRESS>

Is Docker Hub unhealthy now?
time="2021-02-03T18:16:41Z" level=info msg="running tests against containerd" revision=2f40b7890ca56e299b494d4d5ccb2cda6a80dc0b runtime=io.containerd.runtime.v1.linux version=2f40b78
time="2021-02-03T18:16:41Z" level=info msg="start to pull seed image" image="docker.io/library/alpine:latest"
failed to copy: httpReadSeeker: failed open: server message: invalid_token: authorization failed: time="2021-02-03T18:16:40.989236363Z" level=info msg="starting containerd" revision=2f40b7890ca56e299b494d4d5ccb2cda6a80dc0b version=2f40b78

Is Docker Hub unhealthy now?

Looks like it was, but I restarted another PR and integration is working properly. Will restart tests


Removed the image from max-age example

Fixes #25848 . The image was showing the wrong value of max-age. As recommended, I am removing the image itself.
Internal Preview

Looks good.  Thanks @ankitwww!

Sorry, accidently hit close button!  Merged now.


CoercionException::withValue() called but not throwed. Is this dead code?

https://github.com/azjezz/psl/blob/62632502a7a2004601ebdfa06b32eff6a33a042e/src/Psl/Type/Internal/PositiveIntType.php#L56-L59
The tests are passing, as the code continues until line 70
https://github.com/azjezz/psl/blob/62632502a7a2004601ebdfa06b32eff6a33a042e/src/Psl/Type/Internal/PositiveIntType.php#L70
Does it make sense to keep that if?

Well spotted! I've provided a PR for this.
The tests pass cause of line 70 indeed, yet we can skip some if checks to speed up the coercion process.


[Bug] A Node.js API is used (fs.readFileSync) which is not supported in the Edge Runtime

Is this a new bug?

[X] I believe this is a new bug
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
Getting error like this:
[0] - error ./node_modules/@pinecone-database/pinecone/dist/utils/user-agent.js:27:22
[0] Module not found: Can't resolve 'fs'
[0]
[0] https://nextjs.org/docs/messages/module-not-found
[0]
[0] Import trace for requested module:
[0]<EMAIL_ADDRESS>[0]<EMAIL_ADDRESS>[0]<EMAIL_ADDRESS>Looks like user-agent assumes fs exists.
Expected Behavior
Pinecone would work even on edge
Steps To Reproduce
Call Pinecone from node:
const pinecone = new Pinecone({
apiKey: process.env.PINECONE_API_KEY,
environment: process.env.PINECONE_ENVIRONMENT
});
const pineconeIndex = pinecone.index(process.env.PINECONE_INDEX).namespace('ns1');
...
const value = await index.query({
topK: topK,
vector: embeddingResponse.data[0].embedding,
filter: filter,
});
Relevant log output
No response
Environment
- **OS**: Mac
- **Language version**: TypeScript
- **Pinecone client version**: 1.0.0

Additional Context
No response

Trying to downgrade to 0.1.6. gives me this error:
[0]  [PineconeError: PineconeClient: Error calling query: PineconeError: PineconeClient: Error calling queryRaw: FetchError: The request failed and the interceptors did not return an alternative response] {
[0]   name: 'PineconeError'
Has the API changed or am I doing something wrong?

Same problem. The only reason im using Pinecone in particular is for the Edge.

Sorry for the trouble, I'll try to get a fix for this up soon.

I have one other feature and some more integration testing I want to finish before cutting a 1.1.0 release this week, but if you want to kick the tires on a dev build with changes from #110 in it then you can temporarily install 1.0.0-dev.20230913190611. I added another CI build using their official test util @edge-runtime/jest-environment to verify the changes, but haven't yet tried them in a real life Edge Runtime situation since.

Thanks! Still not working those. Here's where I'm at. Seems like the fs issue is solved.
<html>
<body>
<!--StartFragment-->

> Using @sveltejs/adapter-vercel
--
23:17:26.331 | ✘ [ERROR] Could not resolve "os"
23:17:26.332 |
23:17:26.332 | node_modules/.pnpm/@pinecone-database+pinecone@**1.0.0-dev.20230913190611**/node_modules/@pinecone-database/pinecone/dist/utils/os.js:27:30:
23:17:26.332 | 27 │ var os = __importStar(require("os"));
23:17:26.332 | │                               ~~~~
23:17:26.333 | ╵                               "./os"
23:17:26.333 |
23:17:26.333 | The package "os" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
23:17:26.333 |
23:17:26.518 | error during build:
23:17:26.518 | Error: Build failed with 1 error:
23:17:26.518 | node_modules/.pnpm/@pinecone-database+pinecone@1.0.0-dev.20230913190611/node_modules/@pinecone-database/pinecone/dist/utils/os.js:27:30: ERROR: Could not resolve "os"
23:17:26.518 | at failureErrorWithLog (/vercel/path0/node_modules/.pnpm/esbuild@0.18.20/node_modules/esbuild/lib/main.js:1649:15)
23:17:26.518 | at /vercel/path0/node_modules/.pnpm/esbuild@0.18.20/node_modules/esbuild/lib/main.js:1058:25
23:17:26.518 | at /vercel/path0/node_modules/.pnpm/esbuild@0.18.20/node_modules/esbuild/lib/main.js:1003:52
23:17:26.519 | at buildResponseToResult (/vercel/path0/node_modules/.pnpm/esbuild@0.18.20/node_modules/esbuild/lib/main.js:1056:7)
23:17:26.519 | at /vercel/path0/node_modules/.pnpm/esbuild@0.18.20/node_modules/esbuild/lib/main.js:1085:16
23:17:26.519 | at responseCallbacks.<computed> (/vercel/path0/node_modules/.pnpm/esbuild@0.18.20/node_modules/esbuild/lib/main.js:703:9)
23:17:26.519 | at handleIncomingPacket (/vercel/path0/node_modules/.pnpm/esbuild@0.18.20/node_modules/esbuild/lib/main.js:762:9)
23:17:26.519 | at Socket.readFromStdout (/vercel/path0/node_modules/.pnpm/esbuild@0.18.20/node_modules/esbuild/lib/main.js:679:7)
23:17:26.519 | at Socket.emit (node:events:514:28)
23:17:26.519 | at addChunk (node:internal/streams/readable:324:12)
23:17:26.602 | ELIFECYCLE  Command failed with exit code 1.
23:17:26.623 | Error: Command "pnpm run build" exited with 1

<!--EndFragment-->
</body>
</html>

Thanks for giving it a go. I'm kind of surprised since the @edge-runtime/jest-environment didn't flag it, but I guess it shows the need for a true integration test in a real environment to have total confidence. I'll add that to my todo list 😂
I'll just rip out the os bits completely for now so I can ship a fix for this along with some fixes on typescript compilation issues.

+1 - this affects https://github.com/pinecone-io/pinecone-vercel-starter

The 1.0.1 release is out. Release notes here. I removed the reference to os so 🤞
Try it out and let me know if you're still having problems.

It works! You're awesome. Thanks for the special thanks :)


Create map of all shortcut keys

This is a general purpose ticket to track all mapped shortcut keys. It should be closed as soon as @mattatgit is satisfied with the mapping (and posts it here definitively).

Have begun this. Still in progress & will need to develop as we add features, but these are my suggestions so far
https://github.com/vizorvr/vizor-create/wiki/Keyboard-&-UI-Shortcuts


Typo correction

Really minor thing, but it was bugging me

Hi @Undo1, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@Undo1 Thanks for the contribution!


Error when using this library in AWS Lambda functions

I am experiencing an error when 'requiring' the requests library using Node3.4 in an AWS Lambda function. I've done A/B testing where I have a known good piece of code that does not use this library and then it can no longer parse and load the module when I add a single line to require this library and redeploy the code to AWS Lambda.
Unable to import module 'MyCode': Error at Function.Module._resolveFilename (module.js:325:15) at Function.Module._load (module.js:276:25) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at Object.<anonymous> (/var/task/MyCode.js:20:15) at Module._compile (module.js:409:26) at Object.Module._extensions..js (module
Unable to import module 'MyCode': Error
at Function.Module._resolveFilename (module.js:325:15)
at Function.Module._load (module.js:276:25)
at Module.require (module.js:353:17)
at require (internal/module.js:12:17)
at Object.<anonymous> (/var/task/MyCode.js:20:15)

^^ This is the line that I define: "var request = require('request');"
at Module._compile (module.js:409:26)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Module.require (module.js:353:17)

I think the issue is something else. If you just added the line to your code and deployed it without installing then it won't work. You have to package the necessary node modules required by your lambda in the deployment.
Check this link Creating a Deployment Package (Node.js)

In your zip file for lambda... look inside a downstream dependency mime-db. There should be 3 files - index.js, db.json & package.json....
I was missing db.json because I only included **/*.js and **/package.json.

I'm also having this issue.
In my directory, I've run npm install request - that downloads requests and all its dependencies. (mime-db is installed without the above errors)
I zip up index.js and node_modules into a single zip file.
I upload to AWS Lambda.
I get the Unable to import module error.

@edent
have you managed to solve this issue ?

Nope. Sorry.

I was having this same issue and realized that it was because some dependent modules were installed globally on my system.  When I used npm install it skipped those already globally installed modules, still worked fine locally, but when zipped up and used in a Lambda function it didn't have access to those modules.
I'm not sure if this is the best approach to fixing it, but when I used npm install --link it added all dependent modules to the local directory (via sym-links), and I was able to zip that all up and resolve my issue.
I couldn't find any help with this online anywhere, so I figured I'd at least reply here in case this helps someone else.

I have solved my issue. It was a missing dependency in my package.json file.

Just to add despite its closed, this fixes for me when I rebuild from scratch, I removed the cached dependencies and reinstalled everything.


transactionId required in completePurchase but already available in POST

The completePurchase method requires that the transactionId is passed to it, but this should already be known and available in the POST data from SagePay.
https://github.com/thephpleague/omnipay-sagepay/issues/34#issuecomment-124151070
https://github.com/academe/OmniPay-SagePay-Demo/blob/master/sagepay-confirm.php#L39

Marking as a bug, though minor with a clear workaround (i.e. got fetch transaction ID from the POST data and give it to the gateway, rather than leaving to gateway to get the transaction ID itself).

This is how Authorize.Net does it:
https://github.com/thephpleague/omnipay-authorizenet/blob/master/src/Message/SIMCompleteAuthorizeRequest.php#L16

This was fixed in https://github.com/thephpleague/omnipay-sagepay/commit/97610c0dac6cc547797b1934a51e84bbfff7eaa1#diff-0f493970ef222c4ff3349841d7227172
The transactionId is actually in the transactionReference that OmniPay provided for storage when the transaction was first created. It no longer needs to be passed into completePurchase  - the transactionReference is enough.


Add- Advanced-Time Lock,Degrading Multi-sig: Need toast on CTA.

In Add wallet- Advanced section we need a Toast on CTA (Time Lock and Degrading Multi-sig) "Coming Soon!!!"

Verified this issue on keeper app v 1.1.11(296)


PT-4754 Allow setting queue args on declare and bind

This shoudl be releaed as new major version when done because breaks interface

благодарю вас

LGTM 👍


Put register node in subprocess

Description
In case of multichannel, if one channel has a issue, the other can not be used. With that PR, it's now possible !
Closes issue(s)
None
Companion PRs
None
How to test / repro
Launch substra e2e test :)
Screenshots / Trace
None
Changes include

[x] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

[x] I have tested this code
[ ] I have updated the Readme

Other comments
None

An issue I see with this change is that the pod readiness will be true regardless of the whether or not the connection to the ledger is successful. That's because the pod gets marked as ready as soon as the function returns: with this PR the function returns immediately.
As a result, the pod will be marked as ready, even though potentially it's not.
One of the potential nefarious impacts is in the context of end to end tests: we use the readiness probe to ensure the backend is ready. So if the connection to the ledger fails, the backend will be marked as ready, the tests will start (and fail).
What about adding a mechanism to ensure all the ledger connections are functional before marking the pod as ready?

An issue I see with this change is that the pod readiness will be true regardless of the whether or not the connection to the ledger is successful. That's because the pod gets marked as ready as soon as the function returns: with this PR the function returns immediately.
As a result, the pod will be marked as ready, even though potentially it's not.
One of the potential nefarious impacts is in the context of end to end tests: we use the readiness probe to ensure the backend is ready. So if the connection to the ledger fails, the backend will be marked as ready, the tests will start (and fail).
What about adding a mechanism to ensure all the ledger connections are functional before marking the pod as ready?

An issue I see with this change is that the pod readiness will be true regardless of the whether or not the connection to the ledger is successful. That's because the pod gets marked as ready as soon as the function returns: with this PR the function returns immediately.

Yes, you're right !

As a result, the pod will be marked as ready, even though potentially it's not.

When the backend-server pod is ready, that means that the backend is ready to serve request. It's true whether the ledger is ready or not, even if the request will surely return an error because of a ledger connection failure.

One of the potential nefarious impacts is in the context of end to end tests: we use the readiness probe to ensure the backend is ready. So if the connection to the ledger fails, the backend will be marked as ready, the tests will start (and fail).

Yes

What about adding a mechanism to ensure all the ledger connections are functional before marking the pod as ready?

This what we want to avoid, because, in case of multi-channels, if one ledger connection fail, all ledger connection are not usable.
Instead, we can make the backend ready if, at least, one ledger connection is functional or we can set a mandatory list of ledger connections to be functional to make the backend ready ! What do you think ?

An issue I see with this change is that the pod readiness will be true regardless of the whether or not the connection to the ledger is successful. That's because the pod gets marked as ready as soon as the function returns: with this PR the function returns immediately.

Yes, you're right !

As a result, the pod will be marked as ready, even though potentially it's not.

When the backend-server pod is ready, that means that the backend is ready to serve request. It's true whether the ledger is ready or not, even if the request will surely return an error because of a ledger connection failure.

One of the potential nefarious impacts is in the context of end to end tests: we use the readiness probe to ensure the backend is ready. So if the connection to the ledger fails, the backend will be marked as ready, the tests will start (and fail).

Yes

What about adding a mechanism to ensure all the ledger connections are functional before marking the pod as ready?

This what we want to avoid, because, in case of multi-channels, if one ledger connection fail, all ledger connection are not usable.
Instead, we can make the backend ready if, at least, one ledger connection is functional or we can set a mandatory list of ledger connections to be functional to make the backend ready ! What do you think ?

@Kelvin-M

we can make the backend ready if, at least, one ledger connection is functional or we can set a mandatory list of ledger connections to be functional to make the backend ready

I think setting a mandatory list of connections to be functional would be best. But isn't that already the case today? Today, if the backend is non-functional because one of the channels is non-functional, then all you have to do to fix it is change the helm values and restrict the number of configured channels.
For instance if the values say
channels: ['mychannel', 'otherchannel']

and otherchannel isn't functional, all you have to do is change the config to
channels: ['mychannel']

In other words, the solution you describe ("set a mandatory list of ledger connections") is already implemented, and I fail to see how adding a new list of channels in the config would solve any problems. What am I missing?

@Kelvin-M

we can make the backend ready if, at least, one ledger connection is functional or we can set a mandatory list of ledger connections to be functional to make the backend ready

I think setting a mandatory list of connections to be functional would be best. But isn't that already the case today? Today, if the backend is non-functional because one of the channels is non-functional, then all you have to do to fix it is change the helm values and restrict the number of configured channels.
For instance if the values say
channels: ['mychannel', 'otherchannel']

and otherchannel isn't functional, all you have to do is change the config to
channels: ['mychannel']

In other words, the solution you describe ("set a mandatory list of ledger connections") is already implemented, and I fail to see how adding a new list of channels in the config would solve any problems. What am I missing?

You're missing solo channel :)

You're missing solo channel :)

@Kelvin-M If I understand correctly, you'd want to configure the backend to connect to all the channels, but only make the solo channel mandatory. Is that correct? If so, I think introducing  a separate "mandatory" list of channels is reasonable. In this case the list would only contain solo channel(s).

@Kelvin-M If I understand correctly, you'd want to configure the backend to connect to all the channels, but only make the solo channel mandatory. Is that correct? If so, I think introducing  a separate "mandatory" list of channels is reasonable. In this case the list would only contain solo channel(s).

To Do : add a health route for hlf connection !

To Do : add a health route for hlf connection !

I've updated the health check to do a get_hfc on each channel :)
As we use the e2e run script with skaffold and the option --status-check=true we do not need to do extra modification !

I've updated the health check to do a get_hfc on each channel :)
As we use the e2e run script with skaffold and the option --status-check=true we do not need to do extra modification !

E2E Tests ✔  (there is also an init container for substra-test pod which curl-wait readiness url of both backends before starting)

E2E Tests ✔  (there is also an init container for substra-test pod which curl-wait readiness url of both backends before starting)


"An item with the same key has already been added" for Indices.Get(...) method

NEST/Elasticsearch.Net version:
7.12.1
Elasticsearch version:
7.x
.NET runtime version:
.NET Framework 4.8
Operating system version:
Windows 10
Description of the problem including expected versus actual behavior:
A clear and concise description of what the bug is.
One of our clients reported following exception:
Elasticsearch.Net.UnexpectedElasticsearchClientException: An item with the same key has already been added. ---> System.ArgumentException: An item with the same key has already been added.
   at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
   at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
   at Nest.DynamicTemplatesFormatter.Deserialize(JsonReader& reader, IJsonFormatterResolver formatterResolver)
   at Deserialize(Object[] , JsonReader& , IJsonFormatterResolver )
   at Nest.ReadAsFormatter`2.Deserialize(JsonReader& reader, IJsonFormatterResolver formatterResolver)
   at Deserialize(Object[] , JsonReader& , IJsonFormatterResolver )
   at Nest.ResolvableDictionaryResponseFormatter`3.Deserialize(JsonReader& reader, IJsonFormatterResolver formatterResolver)
   at Elasticsearch.Net.Utf8Json.JsonSerializer.Deserialize[T](Byte[] bytes, Int32 offset, IJsonFormatterResolver resolver)
   at Elasticsearch.Net.Utf8Json.JsonSerializer.Deserialize[T](Stream stream, IJsonFormatterResolver resolver)
   at Elasticsearch.Net.DiagnosticsSerializerProxy.Deserialize[T](Stream stream)
   at Elasticsearch.Net.ResponseBuilder.SetBody[TResponse](ApiCallDetails details, RequestData requestData, Stream responseStream, String mimeType)
   at Elasticsearch.Net.ResponseBuilder.ToResponse[TResponse](RequestData requestData, Exception ex, Nullable`1 statusCode, IEnumerable`1 warnings, Stream responseStream, String mimeType)
   at Elasticsearch.Net.HttpWebRequestConnection.Request[TResponse](RequestData requestData)
   at Elasticsearch.Net.RequestPipeline.CallElasticsearch[TResponse](RequestData requestData)
   at Elasticsearch.Net.Transport`1.Request[TResponse](HttpMethod method, String path, PostData data, IRequestParameters requestParameters)
   --- End of inner exception stack trace ---
   at Elasticsearch.Net.Transport`1.Request[TResponse](HttpMethod method, String path, PostData data, IRequestParameters requestParameters)
   at Data.Elasticsearch.SynchronizeElasticsearch.CountObjects(xxxxx)

The CountObjects method has following body:
public int CountObjects(string connectionString)
{
    try
    {
        var uri = new Uri(connectionString);
        ConnectionSettings setting = new ConnectionSettings(uri)
            .PingTimeout(TimeSpan.FromSeconds(Timeouts.ElasticsearchTimeout))
            .RequestTimeout(TimeSpan.FromSeconds(Timeouts.ElasticsearchTimeout));

        var client = new ElasticClient(setting);

        var result = client.Indices.Get(new GetIndexRequest(Indices.All));
        var indexes = result.Indices.Keys;
        return indexes.Count()
    }
    catch (Exception ex)
    {
        return -1;
    }
}

The problem is - we have no idea why we get the error that item with same key has already been added, when all we do is actually getting the list of indices and just counting them. Does Indicies.Get() method inserts any new data?
Expected behavior
No error
Provide ConnectionSettings (if relevant):
In snippet
Provide DebugInformation (if relevant):

Hi, @skarpecki.
Apologies for the delay. I have been on extended leave.
This is unexpected and it appears that something the client expects to be unique in the response and therefore deserialisable to a dictionary is not in your case. Based on the stack trace it appears to be an index with dynamic templates defined in the mappings. To investigate this further I'd need to see the response from the server. Are you able to enable debug mode to capture that and share it please?
As it may contain sensitive information about your indices you can email the debug info. Please send it to us at: microsoft @ elastic.co (without spaces) and ping me here so I can check for it.

Hi, @skarpecki. Are you able to provide further information to move this forward?

I am afraid we need to close the issue, as user who reported it haven't answered us since a month. We forwarded your question, but it seems that he ignored it..

No problem @skarpecki. Ping us if you get more information to reproduce this.

Dear team, I finally got the response:

@skarpecki, Can you please provide this as text so we can parse through it more easily?

@stevejgordon
{   "mappings": {     "_doc": {       "properties": {         "buyUnitld": {           "type": "text",           "fields": {             "keyword": {               "type": "keyword",               "ignore_above": 256             }           }         },         "buyUnitTypeName": {           "type": "text",           "fields": {             "keyword": {               "type": "keyword",               "ignore_above": 256             }           }         },         "capacityLocal": {           "type": "long"         },         "capacityNet": {           "type": "long"         },         "channelld": {           "type": "text",           "fields": {             "keyword": {               "type": "keyword",               "ignore_above": 256             }           }         },         "channelName": {           "type": "text",           "fields": {             "keyword": {               "type": "keyword",               "ignore_above": 256             }           }         },         "code": {           "type": "text",           "fields": {             "keyword": {               "type": "keyword",               "ignore_above": 256             }           }         },         "comercial UnitName": {           "type": "text",           "fields": {             "keyword": {               "type": "keyword",               "ignore_above": 256             }           }         },         "date": {           "type": "date"         },         "id": {           "type": "text",           "fields": {             "keyword": {               "type": "keyword",               "ignore_above": 256             }           }         },         "mediaTypeName": {           "type": "text",           "fields": {             "keyword": {               "type": "keyword",               "ignore_above": 256             }           }         },         "name": {           "type": "text",           "fields": {             "keyword": {               "type": "keyword",               "ignore_above": 256             }           }         },         "order": {           "type": "long"         },         "programName": {           "type": "text",           "fields": {             "keyword": {               "type": "keyword",               "ignore_above": 256             }           }         },         "quotas": {           "properties": {             "amount": {               "type": "float"             },             "duration": {               "type": "long"             },             "duration TypeName": {               "type": "text",               "fields": {                 "keyword": {                   "type": "keyword",                   "ignore_above": 256                 }               }             },             "name": {               "type": "text",               "fields": {                 "keyword": {                   "type": "keyword",                   "ignore_above": 256                 }               }             },             "quantity": {               "type": "long"             },             "quotald": {               "type": "text",               "fields": {                 "keyword": {                   "type": "keyword",                   "ignore_above": 256                 }               }             },             "quotaName": {               "type": "text",               "fields": {                 "keyword": {                   "type": "keyword",                   "ignore_above": 256                 }               }             }           }         },         "segmentld": {           "type": "text",           "fields": {             "keyword": {               "type": "keyword",               "ignore_above": 256             }           }         },         "table": {           "type": "text",           "fields": {             "keyword": {               "type": "keyword",               "ignore_above": 256             }           }         },         "unitTypeName": {           "type": "text",           "fields": {             "keyword": {               "type": "keyword",               "ignore_above": 256             }           }         }       }     }   } }

@skarpecki That JSON does not correspond to a complete response from the server for the C# request you previously included.
var result = client.Indices.Get(new GetIndexRequest(Indices.All));

Without the full response, I'll be unable to assist here.

Ok, working on it

Hi! I'm working with skrapecki on this problem. Unfortunately, the client will not send us an entire response from the production server.
We managed to cause such an exception in a test environment. I think it's because dynamic templates can contain multiple template names with the same name.
Steps to reproduce the bug:
`PUT _template/newtemplate
{
"index_patterns": [
"newindex-"
],
"mappings": {
"dynamic_templates": [
{
"firstTemplate": {
"path_match": "myobject.abc.",
"match_mapping_type": "double",
"mapping": {
"type": "long"
}
}
},
{
"firstTemplate": {
"path_match": "myobject.def.*",
"match_mapping_type": "double",
"mapping": {
"type": "long"
}
}
}
]
}
}
 PUT newindex-1`
Response of GET /_all
{
"newindex-1": {
"aliases": {},
"mappings": {
"dynamic_templates": [
{
"newtemplate": {
"path_match": "myobject.abc.",
"match_mapping_type": "double",
"mapping": {
"type": "long"
}
}
},
{
"newtemplate": {
"path_match": "myobject.def.",
"match_mapping_type": "double",
"mapping": {
"type": "long"
}
}
}
]
},
    "settings": {
        "index": {
            "routing": {
                "allocation": {
                    "include": {
                        "_tier_preference": "data_content"
                    }
                }
            },
            "number_of_shards": "1",
            "provided_name": "newindex-1",
            "creation_date": "1673529001857",
            "number_of_replicas": "1",
            "uuid": "eoXH0NWBQYCHvug7375-1g",
            "version": {
                "created": "7100199"
            }
        }
    }
}

}

Thanks, @samuelchmiel. That's really helpful. I'll need to review this further to see what our options are to handle this.

Hi @stevejgordon, do you have any updates on this issue?

@samuelchmiel I'm afraid I didn't get time to work on this around other priorities, so this hasn't progressed. I am no longer maintaining this library so won't be picking this up personally.

@samuelchmiel Hi there, I'm the new maintainer of the library, but NEST currently has low priority for me as well. I'm happy to accept PRs, but besides from that, it might take a good while until I habe time to check this issue.


Async consumer queue

This PR adds a new utility class- AsyncConsumerQueue
AsyncConsumerQueue is a queue of items that are processed when a certain condition is met or when a timer runs out.
Primal usage of this is for cases when we need to periodically flush items (send them to peer or save to hard drive) with a certain interval. But if a certain condition is met we need to flush it right away without waiting.
This will be used in 'BlockStoreSignaled' for announcing new headers.

well then you have different idea than i do :-)
i think you are mixing two things - one is triggering the event, which imho should be done on every add, that's the primary purpose of the (generic) consumer - and the other is sending the headers, but we won't send on each event, but we will process the queue

Since the queue is an inner object adding a new item to it is 'consumption' already.
Adding triggers starting the timer for processing (if not started already) and performs a check if we should process it without waiting for the timer.

we would achieve the same result, just the extra condition you have there would imho make the code harder to read
i am sure we don't need any such thing, so why to have it?

Which condition?

That's a good question if we need it or not.

I believe we don't.

Ofc we can perform that check on the user side before\after we add item to the queue and if true we would use smth like queue.TriggerProcessing but it would look uglier. And imagine if we add item to the queue from different places- we would need to copy that condition.

no, you would not need to copy that condition
it seems that we still fundamentally thing differently about the design, therefore this seems to be to early to make an PR from it

So it's better to have it here just in case it's needed. And if not- ok, just don't set any condition- that's fine.

 If we won't use it, don't implement it.

Closing this because a separate PR for AsyncManualResetEvent is requested. Will split this one in 2 sequential pieces.


W-13631494 "Certificate Checking Strength" is not documented properly

https://github.com/mulesoft/docs-anypoint-security/blob/latest/modules/ROOT/pages/enable-client-authentication.adoc

Allows the application to control whether strict or lax certificate checking is performed during chain-of-trust processing.

What does strict mean? What does lax mean? What do these options actually do?

Hi @lol768 I know that this is a very tardy response, and I apologize for that. Thank you for your feedback. I will look into this and let you know about any updates to the documentation.

Merged documentation after technical review.
https://github.com/mulesoft/docs-anypoint-security/pull/100


There are types at 'isolate-package/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports".

In order to solve problem described in #56,  I built a script to handle my isolation process. However, TypeScript refuses to import the isolate-package types.
Here is the full error:
Could not find a declaration file for module 'isolate-package'<EMAIL_ADDRESS>implicitly has an 'any' type.
  There are types at [workspace]/apps/api/node_modules/isolate-package/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'isolate-package' library may need to update its package.json or typings.ts(7016)

I am using isolate-package v1.10.1.

The script:
import { execSync } from 'node:child_process';
import { readFile, writeFile } from 'node:fs/promises';
import { isolate } from 'isolate-package';
import { rimraf } from 'rimraf';
import { build as tsup } from 'tsup';
import tsupConfig from '../tsup.config';

const isolateDirName = 'isolate';

await rimraf(['dist', isolateDirName]);
await tsup(tsupConfig);
await isolate({
  isolateDirName,
});

// Copy the overrides from the root workspace to the isolate workspace
const rootPackageJson = JSON.parse(await readFile('../../package.json', 'utf-8'));
const isolatePackageJson = JSON.parse(await readFile('package.json', 'utf-8'));
isolatePackageJson.pnpm = { ...isolatePackageJson.pnpm, overrides: rootPackageJson.pnpm.overrides };

await writeFile('isolate/package.json', JSON.stringify(isolatePackageJson, null, 2));
execSync('pnpm install --lockfile-only', { cwd: isolateDirName, stdio: 'inherit' });
execSync('zip -r ../dist/function.zip ./*', { cwd: isolateDirName, stdio: 'inherit' });

await rimraf([isolateDirName]);

My tsconfig.json:
{
  "extends"<EMAIL_ADDRESS>  "compilerOptions": {
    "outDir": "dist",
    "strict": true,

    "allowJs": false,
    "checkJs": false,
    "noEmit": true,
    "allowImportingTsExtensions": true,

    "forceConsistentCasingInFileNames": true,
    "verbatimModuleSyntax": true,
    "esModuleInterop": true,
    "resolveJsonModule": true,
    "isolatedModules": true,
    "allowSyntheticDefaultImports": true,

    "exactOptionalPropertyTypes": false,

    "target": "ES2022",
    "module": "ESNext",
    "moduleResolution": "Bundler",

    "paths": {
      "@/*": ["./src/*"]
    }
  },
  "include": ["**/*.ts"],
  "exclude": ["node_modules"]
}

The fix is fairly easy: add explicit types to the package.json exports:
   "type": "module",
   "types": "./dist/index.d.ts",
   "exports": {
-    ".": "./dist/index.mjs"
+    ".": {
+      "import": "./dist/index.mjs",
+      "types": "./dist/index.d.ts"
+    }
   },
   "files": [
     "dist",

Happy to submit a PR.

Thanks for reporting. I wasn't aware that exports.types was still needed when types is already defined in the root. I will change it soon, and if you like you can also submit a PR.
Do you happen to have a link to some documentation where this requirement is described?

I don't see how this would be related to #56, since that is a runtime error. Can you elaborate on that?

@mathieu-bour what is your setting for "moduleResolution" in Typescript? I'm trying to figure out why you are having trouble with the types, because my applications don't have this problem.

@0x80 my moduleResolution is Bundler. fyi I added the full tsconfig in the first issue.

@mathieu-bour Sorry I missed them. In my browser the code blocks were collapsed and I didn't notice them.

@mathieu-bour I had to change it to something else because your proposal broke the integration in firebase-tools-with-isolate. In the latest version I just do exports: "./dist/index.mjs". I hope this works for you, and seems to be the correct way for pure ESM packages.
If it doesn't work, please tell me more about how you're executing your script.

@mathieu-bour  did you meant to link #55 instead #56? Seems like that's where the confusion came from.


Enable hibernation support, set UI scale nicely, fix validation

Hibernation
With this PR + a few commands, hibernation should be enabled. Fixes #3
After updating config.plist, run the following:
sudo pmset -a sleep 1;
sudo pmset -a hibernatemode 25;
sudo pmset -a disablesleep 0;
sudo pmset restoredefaults;

Reboot, then close the cover on your Surface. Wait about 30-40 seconds, then open the cover back up. Press the power button for like 1-2 seconds, and you'll see the Windows logo. Within about 13 seconds of pressing the power button, it should restore from hibernation, skipping OC completely.
UIScale
The default UI scale looks way too tiny on the Surface Go 2. Changing it to 2 makes it more closely match the hi-DPI look.
Schema validation errors
After opening this up in OCAuxiliaryTools with 0.9.7 loaded, I found ocvalidate reported some schema errors. This PR fixes those schema errors by removing the items that are no longer valid.

I think you forgot to add sudo pmset -a hibernatemode 25 after sudp pmset restoredefaults. In your script, you run sudo pmset -a hibernatemode 25 after calling the togglesleep 1 function.
sudo pmset -a sleep 1;
sudo pmset -a hibernatemode 25;
sudo pmset -a disablesleep 0;
sudo pmset restoredefaults;
sudo pmset -a hibernatemode 25;

You're right, UIScale = 2 looks better, even if I find the OC picker a tad large this way.
Yep, ocvalidate will find at least two errors due to my using MOD-OC instead of the vanilla OC build. MOD-OC needs the EnableForAll = 0 variable in ACPI -> Quirks  and in Booter -> Quirks in order to boot Windows normally, that's the whole point of MOD-OC.
Initially I thought that using MOD-OC would make things easier for most users who dual-boot with Windows. In the same way, I enabled the OpenLinuxBoot.efi and ext4.efi drivers to make things easier for those who dual- or triple-boot with Windows and/or Linux.
But perhaps it would be better to switch this repo back to the official OC builds. I'll merge your PR as is with the removed variable for MOD-OC and update the repo with official OC builds.

I think you forgot to add sudo pmset -a hibernatemode 25 after sudp pmset restoredefaults. In your script, you run sudo pmset -a hibernatemode 25 after calling the togglesleep 1 function.
sudo pmset -a sleep 1;
sudo pmset -a hibernatemode 25;
sudo pmset -a disablesleep 0;
sudo pmset restoredefaults;
sudo pmset -a hibernatemode 25;

Ah, you may be right. I think I incorrectly assembled the list of commands above. Good catch.

You're right, UIScale = 2 looks better, even if I find the OC picker a tad large this way.

Yeah, it's just a touch bigger than it should be, but it's nicer than before.

Yep, ocvalidate will find at least two errors due to my using MOD-OC instead of the vanilla OC build. MOD-OC needs the EnableForAll = 0 variable in ACPI -> Quirks and in Booter -> Quirks in order to boot Windows normally, that's the whole point of MOD-OC. Initially I thought that using MOD-OC would make things easier for most users who dual-boot with Windows. In the same way, I enabled the OpenLinuxBoot.efi and ext4.efi drivers to make things easier for those who dual- or triple-boot with Windows and/or Linux.

Oh, I had no idea! Perhaps that explains why my Windows drive I added in Entries doesn't boot properly. It does boot if I let it scan the drive, though, even with EnableForAll removed.


Markdown content escaped when editing comments

Issue Type: Bug
When editing a PR comment any Markdown content is backslash escaped which removes the formatting when the comment is saved. For example the following markdown text:
- a list
- of things
- that aren't important

is converted to this:
\- a list
\- of things
\- that aren't important

Extension version: 0.34.3
VS Code version: Code 1.63.2 (Universal) (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:37:28.172Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 3

Memory (System)
32.00GB (0.12GB free)

Process Argv
--crash-reporter-id ed50f89e-497f-43cd-86f3-a73119f730ed

Screen Reader
no

VM
0%

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30384385
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dsc:30421290
pythonvs932:30410667
vscop804cf:30404767
vs360cf:30404996
vsrem710:30416614
vsccppwtstudy:30421978

This bug makes editing comments on PRs broken. I see the same issue, and I note that it is particularly bad because backslashes will also be backslashed on repeated save. Which means that after a few edits of a PR comment, you are left with something like:
This is a call to \\\`subprocess\\\`, which then does other thing\\\!

(yes it also backslashes an exclamation mark). It does the same for code blocks, which ends up removing the code block formatting.

Is this a new issue, or has this been going on for a while?

I only noticed it recently and I'm pretty sure I've edited Markdown comments before without issue, so yes I think it's new.

@diminutivesloop could you make a gif/screen capture of what you're seeing? I haven't been able to reproduce it. (https://gifcap.dev/ is made by another member of the VS Code team if you need a way to capture).

@alexr00 here is my recording, which presumably is the same issue @diminutivesloop is seeing
https://user-images.githubusercontent.com/7593028/150583048-be9a248d-69af-4812-a7fd-f79be5db0a94.mov
.

@alexr00 I also noticed that if I create the comment from the extension, it doesn't have this issue, which might be why you couldn't reproduce it(?). It's only when I edit a comment that already exists (that has such characters as above) will the backslashes appear.

@MilesCranmer Yeah your screen capture reflects what I'm seeing.

Thanks @alexr00!


All Azure App Service deploy Tasks Failing with "Not found resource file path"

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: Azure App Service deploy (aka AzureRmWebAppDeploymentV4)
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Server - Azure Pipelines or TFS on-premises? Azure Pipelines

If using TFS on-premises, provide the version:

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:

account name: mseng
team project name: InternalTools
release definition names (task is in release, not build): SendVSFeedback2, VsfEmployeeWebsite, DevCom2

SendVSFeedback2 release numbers: Release-164, Release-165, Release-166, Release-167
VsfEmployeeWebsite release numbers: Release-169, Release-170, Release-171
DevCom2 release numbers: Release-125, Release-126

Agent - Hosted or Private: Hosted

If using Hosted agent, provide agent queue name:

Pool: Azure Pipelines

Agent: Azure Pipelines 17
Agent: Azure Pipelines 3
Agent: Azure Pipelines 2
Agent: Azure Pipelines 25
Agent: Azure Pipelines 20

Pool: VSEng-MicroBuildVS2019

Agent: DDMBLDW204

If using private agent, provide the OS of the machine running the agent and the agent version:

Issue Description
All of the Azure App Service deploy tasks in our release pipelines are failing since 9/10 at ~11:00am. We've tried changing the version of the task, but it doesn't help. Local deployment from Visual Studio works fine. The 3 builds associated with the releases all run as expected.
Task logs
VsfEmployeeWebsite Logs
tasklog_1.log
tasklog_2.log
tasklog_3.log
SendVSFeedback2 Logs
tasklog_4 (3).log
tasklog_5 (4).log
tasklog_6 (5).log
tasklog_7 (6).log
DevCom2 Logs
tasklog_8.log
tasklog_9 (1).log
Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
Error: Not found resource file path: E:\A_work_tasks\AzureRmWebAppDeployment_497d490f-eea7-4f2b-ab94-48d9c1acdcb1\4.175.1\node_modules\azure-pipelines-tasks-azure-arm-rest-v2\module.json

This issue appears to have resolved itself over the weekend. We haven't made any changes to our pipelines. I'll leave the issue open in case there's more investigation that needs to be done, but the issue is resolved from a customer standpoint. Thanks!

yes this was because of bad deployment which happened from our side. some files were missing in the package. we had identified this issue and released fix immediately. #13531


[Bug]: OneHotEncoderTransformer broken with sklearn>1.2.1

What happened?
When trying to transform using this transformer we get an error
AttributeError: 'OneHotEncodingTransformer' object has no attribute '_drop_idx_after_grouping'
This attribute was added in sklearn> 1.2.1 and is set in init for OneHotEncoder.  This should be fine but in OneHotEncoderTransformer it looks like we do not actually persist the initialised object, instead calling
in init
# Set attributes for scikit-learn's OneHotEncoder
        OneHotEncoder.__init__(
            self,
            sparse_output=False,
            handle_unknown="ignore",
            dtype=dtype,
            **kwargs,
        )

in fit
 OneHotEncoder.fit(self, X=X[self.columns], y=y)
and in transform:
 X_transformed = OneHotEncoder.transform(self, X[self.columns])
So the intialisation in this classes init method does not actually persist to he object called in transform. Up to now this has run as just calling the transform method without any initialisation worked ok (however it may not have been functioning as expected!).  However with the newer versions of sklearn the method looks for an attribute which does not exist (a) because it is called within the wrong class so self directs it to OneHotEncoderTransformer and (b) because the OneHotEncoder has not been initialised.
To fix this we should assign an instance of OneHotEncoder to an attribute of OneHotEncoderTransformer, say '_encoder',  and persist this through init, fit and transform.
Environment
sklearn 1.5.2
tubular 1.3.1
Minimum reproducible code
x = OneHotCoderTransformer()

x.transform(X)

Relevant error output
`AttributeError: 'OneHotEncodingTransformer' object has no attribute '_drop_idx_after_grouping'`

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The way it is now relies on the calls to init and fit methods in OneHotEncoder setting attributes in the OneHotEncodeingTransformer.  This is a very unsafe way to do things (as we have just found out!) but has probably been working sort of ok up to now.  Not quite sure why the call to init is not setting the  '_drop_idx_after_grouping' attribute but still expect that swithcing to initialising and persisting a OneHotEncoder object will be a safer way for this to work.

closed with #309


Deprecation warning received regarding RestoreStateData.async_get_instance during Hass 2023.6.0 start-up

2023-06-07 22:19:26.970 WARNING (MainThread) [homeassistant.helpers.frame] Detected integration that restore_state.RestoreStateData.async_get_instance is deprecated, and not intended to be called by custom components; Pleaserefactor your code to use RestoreEntity instead; restore_state.async_get(hass) can be used in the meantime. Please report issue to the custom integration author for pyscript using this method at custom_components/pyscript/init.py, line 83: restore_data = await RestoreStateData.async_get_instance(hass)

@swazrgb could you look at this please?

2023-06-07 22:19:26.970 WARNING (MainThread) [homeassistant.helpers.frame] Detected integration that restore_state.RestoreStateData.async_get_instance is deprecated, and not intended to be called by custom components; Pleaserefactor your code to use RestoreEntity instead; restore_state.async_get(hass) can be used in the meantime. Please report issue to the custom integration author for pyscript using this method at custom_components/pyscript/init.py, line 83: restore_data = await RestoreStateData.async_get_instance(hass)

I have the same issue

I have the same issue - Home Assistant 2023.6.2

Pushed 716ffd7 - a hacky fix.  A better solution would be to re-implement using RestoreEntity or similar.

Released in 1.5.0.


Possible to remove col() from .mutate() etc.?

I know it's just three functions that require col(), but I think users would generally find it more streamlined for use without the existence of col(). Just wondering if it's possible...?

Unfortunately it's not possible to get rid of col(). Building expressions using col() is core to how polars works.
It also has to do with how python interprets variables - it tries to evaluate variables in the context of the environment you evaluate it in (typically the global environment). In R you can tell an expression to evaluate in the context of the data frame (which is how dplyr and data.table work without using something like col()).
One cool advantage of this for polars/tidypolars though is you can build expressions outside of .mutate()/.summarize()/`etc. and then evaluate them.
import tidypolars as tp
from tidypolars import col

df = tp.Tibble(x = range(3), y = range(3))

expr = col('x') * 2

df.mutate(double_x = expr)

┌─────┬─────┬──────────┐
│ x   ┆ y   ┆ double_x │
│ --- ┆ --- ┆ ---      │
│ i64 ┆ i64 ┆ i64      │
╞═════╪═════╪══════════╡
│ 0   ┆ 0   ┆ 0        │
├╌╌╌╌╌┼╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌┤
│ 1   ┆ 1   ┆ 2        │
├╌╌╌╌╌┼╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌┤
│ 2   ┆ 2   ┆ 4        │
└─────┴─────┴──────────┘


Test Node v20.x in test workflow

Recent changes required updating dev dependencies that don't support 14.x. The package should still work just fine but it's not directly tested.


crash in swift concurrency, suspend resume partial function for static

Describe the bug
My app in Linux crashes saying suspend resume partial function for static
Steps To Reproduce
Steps to reproduce the behavior:

Goto hanein.news login, create new post with an image.
click post
...

Expected behavior
A clear and concise description of what you expected to happen.
To run without crash
Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please fill out the following information)

OS: [e.g. macOS 11.0] Linux Ubuntu 22.04
Xcode Version/Tag/Branch: 14

Additional context
Add any other context about the problem here.

Here is the source code
HaneinCode.zip

swift --version
Swift version 5.7 (swift-5.7-RELEASE)
Target: x86_64-unknown-linux-gnu

The crash is pointing to req.fromMobile line, which has the following code:
    var fromMobile: Bool {
        let mobileArray = ["iPhone", "iPad", "iPod", "midp", "ucweb", "windows ce", "windows mobile", "BlackBerry", "IEMobile", "Opera Mini", "Android"]
        var result = false
        NSLog("fromMobile request: \(self)")
        mobileArray.forEach { token in
            if "\(self)".contains(token) {
                result = true
            }
        }
        return result
    }

When I changed it to following code, it doesn't crash anymore:
    var fromMobile: Bool {
        let reqString = "\(self)"
        print("reqString: \(reqString)")
        let mobileArray = ["iPhone", "iPad", "iPod", "midp", "ucweb", "windows ce", "windows mobile", "BlackBerry", "IEMobile", "Opera Mini", "Android"]
        var result = false
        //NSLog("fromMobile request: \(self)")
        mobileArray.forEach { token in
            if reqString.contains(token) {
                result = true
            }
        }
        return result
    }

i.e. the use of "\(self)" inside the forEach loop seem to caused the crash.

Same problem.

Ubuntu 20.04
Swift 5.7
Vapor 4

What is the line / block of code which crashes with you?
mine was here:
mobileArray.forEach { token in
if "(self)".contains(token) {
result = true
}
}
so I changed it to:
let reqString = "(self)"
mobileArray.forEach { token in
if reqString.contains(token) {
result = true
}
}

@amraboelela
Crash while running SwiftShell

function content

@amraboelela
I fixed it.
Use withCheckedContinuation wrapper it.
Reason:
suspend resume partial function for xxx indicates that the method cannot be resumed after being paused.
await withCheckedContinuation { continuation in
    // your crash code written in here.
    // use continuation.resume throw the result
}

In your case, I think it is possible to mark your self (class/struct) as @Sendable or @unchecked Sendable try.
About Sendable see: https://docs.swift.org/swift-book/RevisionHistory/RevisionHistory.html


Azure Service Bus Queues Binding: disable entity management option

Description
Fixes #2018
Also fixes the Servicebus queues binding certification tests

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test

/ok-to-test

Good addition, but I have some feedback on the implementation

If entity management is disabled, we should probably avoid creating the admin clients:

https://github.dev/berndverst/components-contrib/blob/0a6f5cce457407c9b02f4cc617c76f99e04c2df1/bindings/azure/servicebusqueues/servicebusqueues.go#L79-L80
https://github.dev/berndverst/components-contrib/blob/0a6f5cce457407c9b02f4cc617c76f99e04c2df1/bindings/azure/servicebusqueues/servicebusqueues.go#L101-L104

Then we can just change this check to if a.adminClient != nil: https://github.dev/berndverst/components-contrib/blob/0a6f5cce457407c9b02f4cc617c76f99e04c2df1/bindings/azure/servicebusqueues/servicebusqueues.go#L107

Done @ItalyPaleAle

/ok-to-test

Certification: https://github.com/dapr/components-contrib/actions/runs/2937804917
Conformance: https://github.com/dapr/components-contrib/actions/runs/2937804934


Separate error view

Splits out the error middleware into a separate package and brings it in

Codecov Report

Merging #15 into master will increase coverage by 25.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master      #15       +/-   ##
===========================================
+ Coverage      60%   85.04%   +25.04%
===========================================
  Files           4        3        -1
  Lines         170      107       -63
===========================================
- Hits          102       91       -11
+ Misses         68       16       -52

Impacted Files
Coverage Δ

Sources/App/Config+Setup.swift
84.37% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2945d10...2d7f531. Read the comment docs.


Make arguments to initializeModel parameters in run_parameters.json

GUI implementation would benefit from being able to read the arguments of the 'initializeModel' function call. This could be achieved by making the arguments to be parameters of the 'run_parameters.json' file instead. Then the GUI code could read the parameters from that file. The 'initializeModel' function call would get the arguments from the file as well. In addition, the 'initializeModel' function can be simplified to eliminate the 'ParamDir', 'RunParamFile', 'GeoFile', and 'ModelParamFile' arguments and replacing them with hard-coded values. Allowing users to specify values adds no benefit to the user and adds the potential for confusion in setting up a model.

we don't need this anymore since the GUI is parsing and understanding the run script on its own now.


[chart/redis-ha] Add the ability to secure Sentinels with redisPassword

Add the ability to secure Sentinels with redisPassword

if sentinel.auth add requirepass  to config-sentinel.conf
in _configs.tpl

Signed-off-by: JustinStGermain<EMAIL_ADDRESS>What this PR does / why we need it:

Adds the ability to require password authentication to the Sentinels.

Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

@DandyDeveloper Could you please review?

Closing in favor of #37


Player on Sell Group but not active

Hello,
Buyer works fine as far as I See! Thank you!!
One Problem i found. I buy player with bidding and want to sell them directly.
Player is moved to sell group but not going to sell. This happens in most cases but not with every buy.
Can you Help?
Thanks klist

Looks like this

Any ideas how to fix it? @chithakumar13

Issue is fixed now , take the latest release to get the changes


Proper support for multiple NIC IP configs

Adding support for NetworkInterface.withoutIPConfiguration() to address issue https://github.com/Azure/azure-sdk-for-net/issues/3185 and overall fixing eth SDK's support for multiple IP configs on a NIC, which didn't work in Azure originally either, but now does.

Can one of the admins verify this patch?


possible dark footer

Take a look at this and see if it works for dark footer for you. I played around with the footer logo to set it up to be theme based as well.

Looks good to me.


Changes in code are not reflected on AEM instance

Expected Behaviour
Changes in code are reflected on instance.
Actual Behaviour
Changes in code are not deployed on instance after all steps from Wiki.
Steps to Reproduce
I followed all steps in wiki and also got a successful build on github actions.
You can check my repo here: https://github.com/thisisui/simple-theme/actions
Unfortunately on an instance I do not see any changes. Even when I download the theme once again from AEM I am still getting unchanged files.
In wiki it is written that Update theme config will be run after Build and deploy task but I cannot see in the logs any information that Update theme config has been started. Is there any way to debug this as I have no idea how to fix it.
Cheers
Igor

@Hi @thisisui, what version of the Basic Site Template did you use when you followed the steps form the wiki? Please make sure to use the latest pre-release which is available at https://github.com/adobe/aem-site-template-basic/releases

Thank @bpauli
I used the latest but what I see after discussion with my colleagues it's about setting proper permission when you create a Token in Github.
Now in wiki in C.1 we can see check all of "repo" and "workflow" and this is solving the issue of not triggering Update theme config. I will close this issues as this update in wiki now fixes the issue.


Add Harness source and Faros destination's converter

Description

Provide description here

Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change

Related issues

Fix #152

Migration notes

Describe migration notes if any

Extra info

Add any additional information

Is there a test Harness server we can spin up to test, similar to how we do Jenkins, or do we need to test against a live Harness account?

Harness has [delegate](The Harness Delegate is a service). It's service but not Harness's local instance

Yay!
Please update README


Host Settings and Plans: Changes and Updates

We need to update some aspects of the paid plan feature and the Host settings.

[ ] Move Bank Transfers to another place in the settings
[ ] Activate Bank Transfers by default up $1000
[ ] Remove Activate / Deactivate as Host from Advanced to new fiscal hosting setting
[ ] update in the CF: grey out bank transfer after $1000 / Same for PayPal
[ ] Move Stripe outside of connected accounts
[ ] Manual Payments should be Bank Transfers and have the same limitation as added funds

what are we telling users when they try to apply to host with max capacity?
Copy: This host has reached a plan limit. They must upgrade to a new plan to accept new collectives.

Might want to add these detail to the main host settings update issue: #2665

The unchecked items are tracked in  https://github.com/opencollective/opencollective/issues/2665