Fix bash installation on AIX

At the moment the version of bash on new AIX machines (the test-ibm- ones) is causing problems when running some of the builds. It's hitting pipe failures. It's currently unclear whether this is ulimit-related (I did some quick tests but they were not conclusive) therefore I have backed out the version of bash on the AIX 7.1SP5 machine used for building OpenJ9 to the version that's on the old build machines, as per the final bullet point of https://github.com/AdoptOpenJDK/openjdk-build/issues/1733#issue-614108892. This is not repeatable in the playbooks so an alternate solution needs to be found, and the machine updated to reflect the solution we put in place if required.

I have not looked at bash for quite awhile - so I will not say I have the latest, but I do offer an alturnative via: http://www.aixtools.net/index.php/bash
There you will find both bash4 and bash5 - and one of the two can be installed - in parallel - with the AIX Toolbox, Michael Perzl, or Freeware RPM packaged version.
Just need to call /opt/bin/bash rather than their bash.
Iirc, there are no other requirements - if there are - I'll repackage to remove them.

p.s. I just built bash-5.0 patchlevel 18, and checked bash-4.4 patchlevel 23 - both have an error in (sub)test vredir6.sub.
Using an RPM based package - and I expect pre-patchlevel 23 - the error is still there:
BASH_VERSINFO=([0]="4" [1]="4" [2]="0" [3]="1" [4]="release"
[5]="powerpc-ibm-aix<IP_ADDRESS>")
BASH_VERSION='4.4.0(1)-release'
...

_=/usr/bin/bash
aixtools@gcc119:[/home/aixtools]PS1='$ '
$ unset v
$ exec {v}</dev/null
$ echo $v
10
$ exec {v}<&-
$ ulimit -n
2000
$ ulimit -n 6
$ ulimit -n
6
$ exec </dev/null
$ exit
aixtools@gcc119:[/home/aixtools]

The shell should not be responding with an exit after exec </dev/null
Researching...

On 15/10/2020 09:39, Michael Felt wrote:

p.s. I just built bash-5.0 patchlevel 18, and checked bash-4.4
patchlevel 23 - both have an error in (sub)test vredir6.sub.
Using an RPM based package - and I expect pre-patchlevel 23 - the
error is still there:
BASH_VERSINFO=([0]="4" [1]="4" [2]="0" [3]="1" [4]="release"
[5]="powerpc-ibm-aix<IP_ADDRESS>")
BASH_VERSION='4.4.0(1)-release'
...
|_=/usr/bin/bash aixtools@gcc119:[/home/aixtools]PS1='$ ' $ unset v $
exec {v}</dev/null $ echo $v 10 $ exec {v}<&- $ ulimit -n 2000 $
ulimit -n 6 $ ulimit -n 6 $ exec </dev/null $ exit
aixtools@gcc119:[/home/aixtools] |
The shell should not be responding with an |exit| after |exec </dev/null|

|The reply from the bash group:|
|a) from the command-line exec </dev/null closes the current shell -
as stdin - was cli, and is unavailable.
When from from a script this is not the case, and the script continues.
The error message is yet another example of AIX using different
constants for error messages. It appears this test failure may be ignored.|
|b) I have the new packaging for bash - with no added dependencies -
available via: wiki: http://www.aixtools.net/index.php/bash, bff:
http://download.aixtools.net/tools/gnu/aixtools.gnu.bash.<IP_ADDRESS>.I
c) Soon - I hope after PR #1633 merges - I can add a role that can
manage to download and install via ansible.
|

Researching...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1320#issuecomment-708963094,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACSZR5LIX5MCUDDQ6EGW3FTSK2RKBANCNFSM4M6WQ5LA.

I cannot comment on whether my packaging of bash resolves the issue or not. Can someone check?
Here is a playbook that can be used to install 'aixtools' bash - to assist with checking if this bash resolves the issue - rather than re-installing a back-version of bash.
# Install bash when /opt/bin/bash does not exist
# expected to provide definition of target host using --extra-vars
- hosts: "{{ tgt_host | default('nohostname') }}"
  gather_facts: no

  vars:
    tools:  "http://download.aixtools.net/tools/gnu/"
    lpp:    "aixtools.gnu.bash"
    vrmf:   "<IP_ADDRESS>"
    chksum: "md5:E6106A3CF9A82B4E8785003F587ECA13"
    idem:   "/opt/bin/bash"

  tasks:
    - name: "Check for existing {{ lpp }}"
      stat:
        path: "{{ idem }}"
      register: tgt

    - name: "Download and Install {{ lpp }}"
      block:
        - get_url:
            url: "{{ tools }}{{ lpp }}.{{ vrmf }}.I"
            dest: "/tmp"
            checksum: "{{ chksum }}"
        - command: "/usr/sbin/installp -d /tmp/{{ lpp }}.{{ vrmf }}.I -aYX all"
          register: installp
        - file: "path=/tmp/{{ lpp }}.{{ vrmf }}.I state=absent"
        - file: "path=/tmp/.toc state=absent"
        - file:
            src: /opt/bin/bash
            dest: /usr/bin/bash
            state: link
        - debug:
            var: "{{ item }}.stdout_lines"
          with_items:
            - installp
      when: tgt.stat.exists == false

iirc - the IBM hosted systems are running AIX 7.1 TL5 (SP1).
Question: is this still an issue on those systems - if yes, can it be replicated on test-osuosl-aix71-ppc64-1 - which is also AIX 7.1 TL5 (but SP2). If it can be replicated - then I can research further on the OSUOSL node.

Is this still an issue, or can it be closed?

The issue is a special function of bash being used, that opens pipes aka fifo files - that bash does not remove when it finishes.
Now that I am beginning to understand where fixes can be put - I'll try and come up with a fix that does not use this feature - in the way it is currently used - at least.

I went looking for issues of bash using unnamed fifo redirects. That is what I found to be the root cause during earlier research.
In the make files there are re-directs using the bash feature >( ... ) and <( ... ).
During the testing phase I saw many examples of >( tee ... ) - that are not really needed  | tee ... would work just as well.
However, in checking the build scripts I found one example in a .gmk source that might be difficult to re-write.
define generate-preproc-src
        $(call MakeDir, $(@D))
        $(call ExecuteWithLog, $(SUPPORT_OUTPUTDIR)/gensrc/java.base/_$(@F), \
            ( $(AWK) '/@@END_COPYRIGHT@@/{exit}1' $< && \
              $(CPP) $(CPP_FLAGS) $(SYSROOT_CFLAGS) $(CFLAGS_JDKLIB) $(CPP_FILEPREFIX) $< \
                  2> >($(GREP) -v '^$(<F)$$' >&2) \
                  | $(AWK) '/@@START_HERE@@/,0' \
                  |  $(SED) -e 's/@@START_HERE@@/\/\/ AUTOMATICALLY GENERATED FILE - DO NOT EDIT/' \
                  -e 's/PREFIX_//' -e 's/^#.*//' \
            ) > $@ \
        )
endef

The line 2> >($(GREP) -v '^$(<F)$$' >&2) \ is actually doing something other than just copying the output to a file. My gut feeling is that it can be rewritten to not need the unnamed FIFO as a replacement for unnamed pipe (|), but I do not recognize, directly what $(<F)$$ actually is. A little too terse for me, sadly.
Anyone who can help me understand what is happening here (and especially, how).

@sxa - as this started on the ibm-test machines, and they no longer exist - is this still an issue?
Summary of previous findings:
bash has a special syntax to redirect input/output to sub-shells (using one, or both of >( ... ) and <( ... ).
The implementation creates so-called fifo (named) files in /tmp. AIX needs them to be specifically unlink()ed, unlike a pipe() which is not named.
If a feature change in bash attempted to do (more of) this in memory (with fork() used to copy the redirection - that may have been a concern.

My suggestion is to close this ticket as no longer relevant (the systems no longer exist).

Good point - I skipped over this during my last sweep as I hadn't spotted it was specific to those, so yes I'm happy to close it.


CHIP BLE name in raspi cannot be set, it shows ubuntudesktop

CHIP BLE name in raspi cannot be set, it shows ubuntudesktop, instead of showing CHIP-1383 or CHIP-3840

Generally we does not consider this as a issue since it does not block chip device from communicating with other devices, however, this might confuse the user and vendors might want it to be some specific name.
As for this issue, I believe there are some conflicts with ubuntu desktop's bluetooth manager with chip.
I believe this should be documented instead of code change since it works on ubuntu server.


HTTP Error 500

I tried to make the integration worked but I face an issue :
'''
Logger: pygazpar.client
Source: /usr/local/lib/python3.10/site-packages/pygazpar/client.py:131
First occurred: 11:41:39 PM (1 occurrences)
Last logged: 11:41:39 PM
An unexpected error occured while updating the data
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/pygazpar/client.py", line 97, in __updateLiveMode
self.__login(session)
File "/usr/local/lib/python3.10/site-packages/pygazpar/client.py", line 143, in __login
response.raise_for_status()
File "/usr/local/lib/python3.10/site-packages/requests/models.py", line 1021, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 500 Server Error:  for url: https://login.monespace.grdf.fr/sofit-account-api/api/v1/auth
'''
I checked my username and password and it's all correct. The gazpar cyprieng integration worked well with the same username and password and I just used them to login to their website.

Yes, something has changed in GrDF API, and it broke PyGazpar python API (see PyGazpar project for follow up)

The version 1.1.5 fix the issue.


Fix 'attach' method declarations that are ambiguous in Swift 3

TyphoonComponentFactory.attachDefinitionPostProcessor and TyphoonComponentFactory.attachInstancePostProcessor both resolve to TyphoonComponentFactory.attach with Swift's automatic method name generation.
This causes a compilation error with Swift 3 (maybe even earlier versions; all I know is that I wasn't encountering this in Swift 1.x): myAssembly.attach(myPatcher) would fail saying that method attach is ambiguous. Unfortunately, there doesn't seem to be a workaround, so I resorted to NS_SWIFT_NAME to explicitly set the Swift method names.

Wow! Thanks! I'll review and merge that later today


HBASE-26586 The MigrateStoreFileTrackerProcedure should not rely on t…

…he global config when setting SFT implementation for a table

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 24s
Docker mode activated.

 I just think we should change this class name to something like "InitializeStoreFileTrackerProcedure", as its not really migrating existing tables to the new tracker config defined globally, but rather setting the default tracker config.

Done.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.


Can not get font size

Hi @kyamagu ,
I use this document to get font data from psd. I try get font size from  styleSheet but this file don't return FontSize. Could you please help check, thank you.
04a432d844939d0b21bb32fbff75fcf4.psd.zip

Perhaps you can find default setting from document_resources or resource_dict?
I am not familiar with the detail of type layer styling.

thank @kyamagu for your suggestion.

thank @kyamagu for your suggestion.

Have you solved the problem?

@wjykim
here is my way:

parsed = font size from engine_dict → style_run
yy = get yy from transform
font size = parsed*yy

ít work in case layer not rotate

@wjykim
here is my way:

parsed = font size from engine_dict → style_run
yy = get yy from layer transform
font size = parsed*yy

it work in case layer not rotate

It really works. Thank you~

font_size = layer.engine_dict['StyleRun']['RunArray'][0]['StyleSheet']['StyleSheetData']['FontSize']
print("字号：" + str(layer.engine_dict['StyleRun']['RunArray'][0]['StyleSheet']['StyleSheetData']['FontSize']))
        #计算字体大小
        font_size_pt = font_size * math.sqrt(layer.transform[0] * layer.transform[3] - layer.transform[1] * layer.transform[2])
        print("字号pixel：" + str(font_size_pt))


Creating Angle structure

An idea I've got is to have this data type (especially, but not exclusively) in the effect data objects, instead of a double, in order to represent angles.
A potential issue is that the rounding errors that we get when converting from one unit to another could give us false negatives if we want to compare angles of different units for equality. One possibility could be making it a class instead of a struct, and use inheritance to make them unit-safe at the type level, although comparisons would require a prior conversion.
Also, if we make it into a class it would require heap allocations, but this might be fine still.

A couple questions from a first glance:

Is there much need to compare angle values? (the rounding issue you mentioned)
I agree about the type safety - the user of the struct is probably still assuming that the units are in radians / degrees / etc so I'm not sure about the benefit of the struct vs just having some freestanding functions to convert between different units

Are there any examples of places in the code that would be much simpler with this utility?

@cameronwhite I don't know about much simpler, but it would make the intent clear and type-safe.
This is how types are testes in SimpleEffectDialog:
			if (mType == typeof (int) && (caption == "Seed"))
				yield return CreateSeed (localizer.GetString (caption), effectData, mi, attrs);
			else if (mType == typeof (int))
				yield return CreateSlider (localizer.GetString (caption), effectData, mi, attrs);
			else if (mType == typeof (double) && (caption == "Angle" || caption == "Rotation"))
				yield return CreateAnglePicker (localizer.GetString (caption), effectData, mi, attrs);
			else if (mType == typeof (double))
				yield return CreateDoubleSlider (localizer.GetString (caption), effectData, mi, attrs);
			else if (combo && mType == typeof (string))
				yield return CreateComboBox (localizer.GetString (caption), effectData, mi, attrs);
			else if (mType == typeof (bool))
				yield return CreateCheckBox (localizer.GetString (caption), effectData, mi, attrs);
			else if (mType == typeof (PointI))
				yield return CreatePointPicker (localizer.GetString (caption), effectData, mi, attrs);
			else if (mType == typeof (PointD))
				yield return CreateOffsetPicker (localizer.GetString (caption), effectData, mi, attrs);
			else if (mType.IsEnum)
				yield return CreateEnumComboBox (localizer.GetString (caption), effectData, mi, attrs);

As you can see, it's not only the type that is being tested, but the caption, too, which of course limits you to that specific caption.
As for the second point, yes, the user of the class may work under certain assumptions (that the angle is expressed in a certain unit, but then it turns out it's really a different unit). One possible solution I can think of is having a type hierarchy, and making the parent Angle class not give any information about units, and if the user wants to access that information it would have to be done through the appropriate subclass, perhaps through an AngleVisitor, and then handling RadiansAngle and DegreesAngle separately.

Thanks for the explanation!
I'd kinda lean more towards avoiding a generic Angle class and keep it simple, just having separate types for Radians and Degrees? That might require slightly more code in SimpleEffectDialog to handle the different types. But in normal usage, it's then clear what units the code is expecting to use, and there's no uncertainty about whether the code needs to be checking whether the value is using some other units

Yeah, it's a good idea, just like HsvColor and RgbColor can be converted to each other and don't share a common parent, we could have a different type for each unit of the angle.
I've now created separate structs, and there's no way the user will be able to overlook the unit that is being used, because the properties are named Radians, Degrees, or Revolutions, respectively.

Looks good to me now 👍


Always use "dev" environment in PHP's built-in web server

This PR activates the "dev" environment by default when running Sulu on PHP's built-in web server.
Fixes https://github.com/sulu-io/sulu/issues/2069

I would say that's fine to merge, if the tests would be succeeding :-) And I would also add a line to the changelog.

Replaced by sulu/sulu#2377.


bin/plugin -install org.wikimedia.elasticsearch.swift/swift-repository-plugin/ does not work

Hi,
I am not sure what is the problem here, none of the version could be installed (via proxy even).
elasticsearch-1.4.2]# ./bin/plugin -i org.wikimedia.elasticsearch.swift/swift-repository-plugin/0.7 --verbose
-> Installing org.wikimedia.elasticsearch.swift/swift-repository-plugin/0.7...
Trying http://download.elasticsearch.org/org.wikimedia.elasticsearch.swift/swift-repository-plugin/swift-repository-plugin-0.7.zip...
Failed: SocketTimeoutException[connect timed out]
Trying http://search.maven.org/remotecontent?filepath=org/wikimedia/elasticsearch/swift/swift-repository-plugin/0.7/swift-repository-plugin-0.7.zip...
Failed: SocketTimeoutException[connect timed out]
Trying https://oss.sonatype.org/service/local/repositories/releases/content/org/wikimedia/elasticsearch/swift/swift-repository-plugin/0.7/swift-repository-plugin-0.7.zip...
Failed: SocketTimeoutException[connect timed out]
Trying https://github.com/org.wikimedia.elasticsearch.swift/swift-repository-plugin/archive/0.7.zip...
Failed: SocketTimeoutException[connect timed out]
Trying https://github.com/org.wikimedia.elasticsearch.swift/swift-repository-plugin/archive/master.zip...
Failed: SocketTimeoutException[connect timed out]
Failed to install org.wikimedia.elasticsearch.swift/swift-repository-plugin/0.7, reason: failed to download out of all possible locations..., use --verbose to get detailed information
Not sure what is the issue here.
Some help on this would be appreciated.
Best regards,
Abdul Mohammed

Did you fix your issue? Reading the errors I suspect that the box from where you are trying to install the plugin does not have access to internet.

Hi David,
Yes, I already fixed that issue and indeed it was a proxy issue.
Thanks,Abdul
  From: David Causse<EMAIL_ADDRESS>
To: wikimedia/search-repository-swift<EMAIL_ADDRESS>Cc: sajid-raouf<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Sent: Tuesday, June 14, 2016 11:23 AM
Subject: Re: [wikimedia/search-repository-swift] bin/plugin -install org.wikimedia.elasticsearch.swift/swift-repository-plugin/ does not work (#8)
Did you fix your issue? Reading the errors I suspect that the box from where you are trying to install the plugin does not have access to internet.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Importer: displayed title from raw_json and added title check in addition to isbn check

The title from the parsed XML file is now being used instead of the title of the matched document. Now also checks if the title is equal to the matched document to further prevent wrongful matches
closes https://github.com/CERNDocumentServer/cds-ils/issues/613

please edit the commit message to be compliant with the contributing guidelines

I am not sure if you changed the commit message, but it is still too long (should be 55 chars)
fe.
Importer: change document report title source

* check matched title, identifiers pairs


Removed social media sidebar in mobile view

Description
Removed social media sidebar in mobile view as it was not looking good
Please include a summary of the change and which issue is fixed.
Fixes #392
List any dependencies that are required for this change
NA
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
On my local host
UI /UX changes
Attach gif or screenshot for changes.

Before :

- After :
-

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

SOMEONE ALREADY DO THAT .

But I raised the Pr way before she had done that


Pass slack group id with project information api

Coverage remained the same at 94.433% when pulling 28681f90a5e0d0fe85f2e32dcf287f45aefa471d on pass-slack-group-id-project-info-api into 48d8770b9457bf475c92bddc71a4d5143dce72bf on main.


Label management UI has color picker issues on Mac Chrome

Color picker is not working:

Lable filter is not working:

Browser version:

A work around is to zoom in/out the browser, and the color will be shown.

may be need change the code to disappear the color menu when mouseout the menu.

also, after selecting a color, the menu doesn’t go away.

Let's use #4833 to track the all display issues in color picker.

on the mac the dropdown still has issues with a border around the white option. also the default (when no color is specified) is white and its presented with no border


Instrumenting SPA navigations (eg. location history state)

As far as I understand the@opentelemetry/instrumentation-document-load instrumentation only cares about the initial page load.
it will not generate the subsequence page loads or navigations
this means that all of the user navigations will not be tracked. using instrumentation-user-interaction will only track the interactions (clicks, keypress etc)
example of unsupported navigations

next.js router
React router
Any OPA router out there that uses history.pushState behind the scenes to simulate navigation without full page load

I do believe that the document load is pretty difference from subsequence navigations, but I think that's much more important than clicks for comparison.
Is there something that I'm missing? as I couldn't find an example for this kind of instrumentation.

The user-interaction instrumentation does patch history.pushState() and updates the span name to indicate that it was a navigation event.
The Client/RUM SIG has also been working on semantic conventions for browser events. This is not available yet, but there is a proposal to add a page_view event that would capture both hard and soft navigations.
Aside from that, if you are interested in capturing routes from a specific framework, then I think it would be best to write an instrumentation that is specific to that framework. This would be more reliable/accurate than a generic history/navigation instrumentation.

I see, thanks for the answer. 🙏
it would be great to have this as part of the base RUM instrumentation.


How to pass ListItem data to accessoryLeft to access item image URI?

💬 Question
UI Kitten and Eva version

Package
Version

@eva-design/eva
^2.0.0

@ui-kitten/components
^5.0.0

How do I pass item from List rendering to accessory?
  const RenderListItemRight = (props) => (
    <Button size='tiny'>AVAILABLE</Button>
  );
  const RenderItemImage = () => (
    <Image
      style={{ width: 40, height: 40 }}
      source={{ uri: item.IngImageUri }}
      resizeMode={"cover"}
    />
  );
  const RenderItem = ({ item, index }) => (
    <ListItem
      title={`${item.IngName}`}
      description={item.IngPrice > 0 ? `${item.IngPrice.toFixed(2)}` : ''}
      accessoryLeft={RenderItemImage}
      accessoryRight={RenderListItemRight}
      onPress={() => onPressListItem(item)}
    />
  );
  const onPressListItem = (item) => {
    console.log('item: ', item);
  }
  const onRefresh = () => {
    console.log('On Refresh');
    RetrieveData();
    setIsRefreshing(true);
  }
  const RenderList = () => (
    <List
      style={{ flex: 1 }}
      data={FlatData}
      renderItem={RenderItem}
      refreshing={IsRefreshing}
      keyExtractor={FlatData.IngID}
      onRefresh={() => onRefresh}
    />
  )

Before I use URI on accessory left image, it working but using static image from assets folder (using require('')). Now, I want to use live data. The FlatData having image uri from web. I have tried accessoryLeft={RenderItemImage(item)} and const RenderItemImage = (item) =>  but none of it working

I've tried passing data before in accessoryRight. I did it like this
accessoryRight={ () => renderAccessory (info) }

@Charles22219 you have saved me a lot of hand banging. thank you.

Could you give me a hint on how to do that ? I am stil stuck...
const renderItemAccessory = (props) => (
  <Button size='tiny'>Consulter</Button>
);

const renderItemIcon = (props, icon) => (
  <Icon {...props} name={`${icon}`}/>
);

const renderItem = ({ item, index }) => (
  <ListItem
    title={`${item.title}`}
    description={`${item.description}`}
    accessoryLeft={(props) => renderItemIcon(props, item.icon)}
    accessoryRight={renderItemAccessory}
  />
);

I get an error :
React.createElement: type is invalid -- "Expected a string but got : undefined

Hi @LoicC04
I have found a solution hope this helps you
 accessoryLeft={(props) =>             renderIcon({...{iconName: 'search'}, ...props})           }
const renderIcon = (props) => {     return <Icon {...props} name={props.iconName} />;   };

Hi @LoicC04
I have found a solution hope this helps you
accessoryLeft={(props) => renderIcon({...{iconName: 'search'}, ...props}) }
const renderIcon = (props) => { return <Icon {...props} name={props.iconName} />; };

That works for me, I was trying to pass a Text component. Thanks!

Hi @LoicC04
I have found a solution hope this helps you
accessoryLeft={(props) => renderIcon({...{iconName: 'search'}, ...props}) }
const renderIcon = (props) => { return <Icon {...props} name={props.iconName} />; };

That works for me, I was trying to pass a Text component. Thanks!


Fix: Add Workspace member "Invitation message" page appears when accessing via deeplink

Details
Navigate user to the invite members page when they try to access directly invite message page by the link/deeplink without selecting any members.
Fixed Issues

$ https://github.com/Expensify/App/issues/21412
PROPOSAL: https://github.com/Expensify/App/issues/21412#issuecomment-1604367502
Tests

Try to access the invite message page for any workspace with deeplink(eg. https://staging.new.expensify.com/workspace/A34BD39BB220FDF4/invite-message)
Verify that when no new members got selected earlier, it navigates to the members invite page for selection

[X] Verify that no errors appear in the JS console

Offline tests

Try to access the invite message page for any workspace with deeplink(eg. https://staging.new.expensify.com/workspace/A34BD39BB220FDF4/invite-message)
Verify that when no new members got selected earlier, it navigates to the members invite page for selection

QA Steps

Try to access the invite message page for any workspace with deeplink(eg. https://staging.new.expensify.com/workspace/A34BD39BB220FDF4/invite-message)
Verify that when no new members got selected earlier, it navigates to the members invite page for selection

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/14358475/5db34b7a-1175-48bd-9b5d-977bd87ebfb2

Mobile Web - Chrome
avc.webm

Mobile Web - Safari
https://github.com/Expensify/App/assets/14358475/e0da4bad-0f1f-4d57-acd9-c2ed6d21ecfc

Desktop
https://github.com/Expensify/App/assets/14358475/fe684799-52e9-4fd0-ad06-94391a08cbaa

iOS
https://github.com/Expensify/App/assets/14358475/c71d872e-0a27-4ca9-895f-6700e026e0e7

Android
av.webm

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/16493223/2521b973-321a-424f-8d09-73eae9d268b9

Mobile Web - Chrome

https://github.com/Expensify/App/assets/16493223/fc6cbdf2-d227-4288-bf57-c606fac93e13

Mobile Web - Safari

https://github.com/Expensify/App/assets/16493223/19e1b107-dae7-4665-9f8f-b74b3b2872ea

Desktop

https://github.com/Expensify/App/assets/16493223/636f35f4-f620-44c9-8430-8ecc54117704

iOS

https://github.com/Expensify/App/assets/16493223/5dbe2021-c099-43c6-8d9c-e852e7ac5939

Android

https://github.com/Expensify/App/assets/16493223/567dfde1-206d-4374-af4f-2cc158a2cbe0

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.38-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


ui.content missing acHandling property

In Maven archetype 13:
ui.content includes sample content for editable templates that includes rep:policies for permissions. However in the com.day.jcr.vault plugin there is no acHandlingproperty set. As a result the rep:policy nodes are never installed when the package is deployed to AEM and causes issues on the publish environment.
<plugin>
                <groupId>com.day.jcr.vault</groupId>
                <artifactId>content-package-maven-plugin</artifactId>
                <extensions>true</extensions>
                <configuration>
                    <filterSource>src/main/content/META-INF/vault/filter.xml</filterSource>
                    <verbose>true</verbose>
                    <failOnError>true</failOnError>
                    <group>aem-guides/wknd</group>
                  <!-- add acHandling -->
                    <properties>
                        <acHandling>merge_preserve</acHandling>
                    </properties>
                </configuration>
            </plugin>

Thanks @godanny86, we'll look into this.

👍


Add post actix-raft announcement

Please add this post:
Post URL: https://www.reddit.com/r/rust/comments/cwfgqv/announcing_actixraft_raft_distributed_consensus/
Blog Homepage: https://railgun-rs.github.io/actix-raft/overview.html
Author Name: Anthony Dodd
Categories: one or more of: Crates, Tools and Applications, Web and Network Services

Published in 4c028c8


Enhancement: Disable rulerz for first character in line

When the cursor sits on the first character of the line, the ruler clashes with the right border of the gutter, which looks awkward. I don't know how to style this with css and think this should be easier to implement functionally.
This :-(

as oposed to this:

Which Atom/Syntax Themes are you using? I don't see any combination which creates a visible left border on the gutter.

I'm using One Dark UI (Compact) and Base16 Tomorrow for Syntax. I have linter installed which adds a second gutter by default. But disabling the package didn't do any good.

So I've just tried, and it's Base 16 Tomorrow that adds the right border on the gutters.
Could I suggest this snippet of custom CSS which you could put in your user stylesheet to remove that border?
.gutter {
  border-right-style: none;
}

In any event, I'm not sure it's wise to add actual logic specific to Theme variations.

I agree, maintaining a "database" with "bad" themes would be tedious.
@n3dst4 solution is fine with me for the moment. By the way, for my installation (windows @1.0.19) the correct css selector is atom-text-editor::shadow .gutter (Don't know if that's standard for you guys) :+1:
I enabled the "highlight error lines in gutter" option from the linter package again and it does some weird stuff.

(highlight on right, right-border none)

(highlight on left, right-border none)

(highlight on left, left-border none)
What I'm trying to say is, there seems to be no way to style the middle border.

What I'm trying to say is, there seems to be no way to style the middle border.

Ok, did some quick testing and got it "right". Really specific selector from dev tools (I know this might be different for everyone. Depends on themes and packages installed):
atom-text-editor::shadow div > div > div.gutter-container > div:nth-child(2) {
   border-left-style: none;
}

By the way I realize this is not this packages fault. News on update page:

Base16 Tomorrow themes have now a seamless gutter and other minor fixes.
(https://atom.io/releases)

Since you've got a workaround (and I read the 1.1 beta release notes the same way you do - that they're removing the extra gutter border anyway) is it safe to close?

I think yes, go ahead.


swift 6 build fails due to Snapshotting not conforming to sendable

Describe the bug
When I put my package.swift in 6.0 version it no longer compiles and gives this error. I guess I could disable language mode 6.0 but have no clue how to do that in package.swift.
But I was not expecting it not to compile as the readme states it works on 6.0???

To Reproduce
swift-driver version: 1.111.2 Apple Swift version 6.0 (swiftlang-<IP_ADDRESS>.15 clang-16<IP_ADDRESS>)
Target: arm64-apple-macosx14.0
Expected behavior
As it supoers
Screenshots
If applicable, add screenshots to help explain your problem.
Environment

swift-snapshot-testing version [1.17.2]
Xcode [16.0 Beta 3]
Swift [6.0]
OS: [macosx14.0]

Additional context
Will try to make pr to fix it

@doozMen Are you using SnapshotTesting via SPM? Your language mode should be independent of a dependency, so these errors sound like bugs. Wanna share a project that reproduces the problem?

Yes they due sound like bugs not related to snapshot testing and I have them in 1 project and not the other. So I guess I should create bug in swift 6 but as it is in beta I'm hesitant. I enjoy using it in other swift 6 project so will close this issue here as I think you are write and it is a bug. Thanks for the quick reply!


[v6 rc3] Confused about custom props on Field

Reading the docs, it seems like custom props passed into Field (through either <Field component={ MyComponent } props={ { a: 1, b: 2 } }/> or <Field component={ MyComponent } ...{ a: 1, b: 2 } /> should show up directly on props in MyComponent: this.props.a. However, the props are actually being merged into the input prop, and must be accessed with this.props.input.a.
It seems like this is counter to the concept of all keys in props.input being safe to destructure onto a native input: <input type="text" {...props.input}/>. Instead, I have to explicitly omit any custom props I may have applied. It also makes supporting library components more difficult, as discussed in https://github.com/erikras/redux-form/issues/1332
I'm wondering what the justification for this change is -- is there a reason that having these props  on input is preferable to the style originally documented?

oops, this looks like the same thing discussed in https://github.com/erikras/redux-form/issues/1397


Add support for OIDC during prebuild

Secret-less Azure DevOps Prebuilds
It is possible to avoid using PATs entirely and dynamically obtain a token during prebuild using
OIDC. This requires creating a Managed Identity or Service Principal in Entra, and creating a
Federated Identity Credential for the prebuild scenario. The identity you create must also be added
to Azure DevOps and given permission to the repositories and feeds you will be accessing during the
prebuild process. The configuration looks similar to the previous example but adds in new options
for the identity you have created:
{
"image": "mcr.microsoft.com/devcontainers/universal:ubuntu",
"features": {
    "ghcr.io/devcontainers/features/azure-cli:1": {},
    "ghcr.io/microsoft/codespace-features/external-repository:latest": {
        "cloneUrl": "https://dev.azure.com/contoso/_git/reposname",
        "cloneSecret": "ADO_PAT",
        "clientID": "xxxx-yyyy-zzzz",
        "tenantID": "1111-2222-3333",
        "folder": "/workspaces/ado-repos"
    }
},
"workspaceFolder": "/workspaces/ado-repos",
"initializeCommand": "mkdir -p ${localWorkspaceFolder}/../ado-repos",
"onCreateCommand": "external-git clone",
"postStartCommand": "external-git config"
}

In this scenario you do not need to add a Codespaces secret for ADO_PAT. Instead, during
the prebuild process this variable will be created and populated with a token obtained
via OIDC. This token will be used during the git clone process but then is otherwise available
for you to use in your scripts to install dependencies from feeds or anything else you may need.
The variable will only be available during the prebuild process.
You can name the variable anything you want, it does not need to be named ADO_PAT and in this case
it contains an OIDC bearer token, not a PAT.

[!NOTE]
You MUST install the Azure CLI feature in your devcontainer.json if using this option

I need to do some manual testing soon, but the expectation I have is that the code will create an environment variable with the name provided in cloneSecret and this will be populated by the clone command and should still be around for anything that comes after that needs to use it. Such as installing npm packages.
Thanks for the fixes. I let Copilot Workspace write some of the code and still need to look at it more closely obviously

@dmichon-msft I did some research and I do not believe the environment variable will still be set when the clone command ends. I think it would be good if there were a way for it to be usable in the rest of the onCreateCommand processing. Open to ideas

@dmichon-msft I did some research and I do not believe the environment variable will still be set when the clone command ends. I think it would be good if there were a way for it to be usable in the rest of the onCreateCommand processing. Open to ideas

A couple of ideas:

Make a separate CLI command that gets the access token and writes it to stdout (i.e. just abstract away the OIDC interaction from the caller). This command can then just be used to populate an environment variable and pass it into the existing external-git clone command.
Since Azure CLI persists login state if you don't explicitly clear it, currently the caller could get a new token with just another call to az account get-access-token to use for package feed.

So the second option sounds pretty doable. I think we can start with that and as a couple of teams use this we can see if there is something to make it easier.

@dmichon-msft I think I have it now. I was adding the token code in the wrong place anyway. So it is now in a command external-git prebuild that you can run in your scripts and it will echo the token to stdout. This command was already being used as the git credential helper during clone so I moved everything into that and cleaned things up.

I was able to test and verify this all works now. Just doing some final testing of a few error scenarios to make sure they can be diagnosed then will merge and publish


$$.ajax: post data does not get serialized.

I fixed a bug with the post data.

I was too fast. There is a new pull request in a few seconds.


recipes-devtools: add tensorrt recipe

to build TensorRT from source and rename the existing recipe
as tensorrt-prebuilt.
Signed-off-by: Ilies CHERGUI<EMAIL_ADDRESS>

#793


User can configure location of certificates in authentication policy

Describe the feature request
Provide users the option to configure locations of certificates used for configuring the envoy proxy when using mTLS. We want to provide the location of the certificates when configuring the authentication policy.
Right now the authentication policy is using hardcoded paths specific to Kubernetes. In CloudFoundry we put our application instance certs in a different location.
Describe alternatives you've considered
We could move the certificates in our application instances, but our application developers depend on the certs being where they are. We could also symlink them, but that seems dirty. It feels like this should be configurable anyway if Istio is meant to be platform agnostic.
Additional context
Other folks worth asking about this: @christianang @ndhanushkodi @tstannard @jeffpak

https://github.com/istio/istio/pull/12189 already solved it..

Ah... it was merged to master. Last I heard development was happening against release-1.1... thanks.

It's already in master, which will be in 1.2 milestone.


update config index mappings to use correct field types

Description
update config index mappings to use correct field types.
In 2.13, config index mapping was updated with three new fields configuration, type, and last_update_timebut schema version was not bumped. Due to which, the domains which were upgraded to 2.13 from previous versions did not go through update index mapping as they did not detect a schema version bump.
During indexing, these fields got created with wrong types not as specified in the mapping. Now when such domains are going to upgrade to 2.15, with schema_version bump, the index mapping tries to get updated but will throw exception since the field types for the three fields specified above are different. Hence the index initialization fails and indexing into the config index wouldn't be possible.
Hence, the PR tries to add complete new fields(ml_configuration, config_type, last_updated_time while removing the old ones. So whenever mapping is getting updated, since there is no type-conflict for old fields, they get retained in the index as is while new fields get added. It is therefore suggested to start using these new fields from 2.15 while indexing into config index.
Issues Resolved
https://github.com/opensearch-project/ml-commons/issues/2630
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hi @rbhavna , I don't quite get why we change the field names for the type and configuration. Could you explain a little bit?

Hi @rbhavna , I don't quite get why we change the field names for the type and configuration. Could you explain a little bit?

added details to PR description


Fix typo

There was a type where you would read fro instead of for

@Tarluna : Thanks for your contribution! The author(s) have been notified to review your proposed change.

There are two other occurrences of the same typo:
https://github.com/MicrosoftDocs/win32/search?q=fro&unscoped_q=fro


Define thread-safety policy, and implement if necessary

I don't think we've defined whether the Couchbase Lite public API in Java is thread-safe or not, i.e. whether an app can call a single CBL object from multiple threads, and if so whether those calls can be simultaneous. Without a clear statement, I think the default is that the API is assumed to be fully thread-safe, which tends to be the norm in Java.
The current implementation is not thread-safe, so if we decide that the API is partially or fully thread-safe, then we need to make that true. (Here's an example of non-thread-safe code in the public API. The document cache is another example.) In my experience this is a pretty extensive amount of work, since adding synchronization often results in deadlocks that then have to be detected/diagnosed/fixed.
There are also internal thread-safety issues having to do with the replicator, which internally runs on multiple threads. (See #902)

Hey there, trolling through the open issues on both the core and Android libs and came across this ticket.  Sorry if this is raising-the-dead-thread. We very recently came into what seem to be the threading issues described here, as for the first time in our use case we are explicitly attempting to move document updates / creations / reads off the database's creating (source) thread.
It would be a real win for us if we knew we had to explicitly hold work to a single thread, giving us a direction to move forward with. Thing's we'd like to know are along the lines of, "Are you allowed to read and write documents from different thread at all? When you perform a Manager.getDatabase(), is the current expectation to perform all replication, changes, and reads from that same thread serially? Are we supposed to use the Database.runAsync() methods for those changes?"
Really appreciate your time on this - we're hitting hard blocks on a lot of issues recently, and clearing a path around this one would be big win!

With CBL Java/Android v1.x, everyone expects CBL Java/Android is thread-safe. But there are some thread safety issues. Expecting all user's multi-threading scenarios before is challenging. Currently we have patched whenever user reported multi-threading issue.
We should revisit the multi-threading policy of CBL Java/Android when we work for CBL v2.0.

As @hideki said when issues are reported we due our best to take care of them. For 2.0 we will look to publish threading requirements.

We are discussing thread-safety for 2.x with cross platforms. This ticket is only applicable for 1.x CBL Android/Java.


nixos/retroarch: fix package name in example

Closes https://github.com/NixOS/nixpkgs/issues/357663
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Will be superseded by https://github.com/NixOS/nixpkgs/pull/358405 as it renames the package to retroarch-full.

Superseded by https://github.com/NixOS/nixpkgs/pull/358405


moved bexioApi into partial classes

fixes #2
Moved some functions to partial class.
@genyx what do you think about this approach?

Makes sense to me to do it this way!

@genyx what about now?

@ntold I think he already agreed in the discussion on the issue, but stated that he doesn't use partials that way normally but is not against it


Launch configuration STARTED escaping env variables or sub shell calls

Environment data
Version: 1.43.1
Commit: fe22a9645b44368865c0ba92e2fb881ff1afce94
Date: 2020-03-18T07:17:38.324Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.5.8-1-MANJARO
Expected behaviour
On launch of a run configuration, environment variable calls like $(XXX) or ${XXX} defined in the args section are escaped by putting it between quotation marks.
So if for instance --arg-xyz=$(XXX) is put into the args section and should evaluate into
--arg-xyz=WHATEVER_IS_THE_OUTPUT_OF_THE_CALL
Actual behaviour
--arg-xyz=$(XXX) is evaluated to --arg-xyz="$(XXX)" what causes the python program launch to fail.
Steps to reproduce:
Actually I don't know, I used this configuration since months and today it did stop working by some kind of escaping these evaluations by putting it just into the quotation marks.
So the launch.json config:
{
            "name": "Odoo",
            "type": "python",
            "request": "launch",
            "program": "/odoo/odoo-bin",
            "args": [
                "--config",
                "/workspace/.devcontainer/etc/odoo.conf",
                "--addons-path",
                "$(gen_addons_path -d /addons)",       <<<<< THIS IS EVALUATED WRONG!
                "--load",
                "base,web,base_test_db",
                "--dev=xml,qweb",
            ],
            "console": "integratedTerminal",
            "justMyCode": false
        }

will result in this actual call of the program:
env DEBUGPY_LAUNCHER_PORT=40595 /usr/bin/python3 /var/lib/odoo/.vscode-server/extensions/ms-python.python-2020.3.69010/pythonFiles/lib/python/debugpy/wheels/debugpy/launcher /odoo/odoo-bin --config /workspace/.devcontainer/etc/odoo.conf --addons-path "$(gen_addons_path -d /addons)" --load base,web,base_test_db --dev=xml,qweb
Usage: odoo-bin [options]

odoo-bin: error: option --addons-path: no such directory: '$(gen_addons_path -d /addons)'

As you see here, $(gen_addons_path -d /addons) is not evaluated, but just put in a string.
I would be very grateful for any hints to get this working again...
Thanks in advance!

The command line that you see in the Terminal is actually kinda fake, in a sense that all those arguments are ignored by debugpy.launcher - it can see the JSON config directly, and it uses that config to spawn the process.
Which is exactly the problem here - the launcher is spawned using the shell, but then it spawns the debuggee directly using popen() (so that it can redirect stdout/err, track process lifetime etc), passing it "args" from JSON. Thus, regular shell expansion doesn't occur.
For environment variables, the workaround is to use ${env:...} expansion in launch.json. Unfortunately, that doesn't work for advanced expansions like this one, or even for some simple stuff like globs (* and ?).
Another workaround is to opt out of the new debugger until we fix this. @karthiknadig, what's the settings.json verbiage for that?


Majority of the sequence is composed of lysines

Hi,
I noticed that the predicted sequence output consists of mostly lysines (K) for my structures. I am predicting the sequence for the binder outputs from RfDiffusion.
Is this expected? Is there anything to be done to counter this?
Thanks

@ackbar03, see if #87 resolves it.


Update Build Badge Link

Summary
Current badge link is broken since we migrated repos

This changes need to be made on each package readme


Copy FEC

Tried to copy FEC from SD to unit and it says no "signed exception list.txt" found. Realize there's an extra / in the copy fec.sh file. Removed it and it works fine

can you please provide the exact codeline of the files here so we can fix that bug

codeline 4


Intent Not Supported Error in Voice Assistant

Request sent within Voice Assistant:

Response received in websocket

Specification:
HACS Azure OpenAI Conversation Version: v1.1.0
Hardware: Home Assistant Yellow
Home Assistant Core: 2024.11.1
Home Assistant Supervisor: 2024.11.2
Home Assistant Operating System: 13.2
Home Assistant Frontend: 20241106.2

Closed Issue, issue resolved after reconfiguring the voice assistant


Expose new module targets in Project properties and build targets

We have added two new module targets, umd and system, we need to expose both in:

[ ] Project properties in C#/VB project -- Dev12
[x] Project properties in C#/VB project -- Dev14
[ ] Project properties in JSProj project -- Dev12
[ ] Project properties in JSProj project -- Dev14
[ ] build targets -- Dev12
[x] build targets -- Dev14
[ ] tools\options page -- Dev12
[x] tools\options page -- Dev14

One thing to figure out, is if TypeScriptToolsVersion is below 1.5, do we still pass in the module value, should it be an error?

updates to expose new flags tracked by #3034

We allow the user to specify unsupported modules even if they target an older version of the compiler, the compiler will display a useful error when that happens.

Should be in 1.5 RTM for VS 2013 and VS 2015


Check 1.2 - duplicate records

When I'm running check 1.2, I get duplicate records with same user name in the report.
I looked the code, but I have no any idea, why this happen.
So, I corrected the script code (within my understanding):
check12(){
  # "Ensure multi-factor authentication (MFA) is enabled for all IAM users that have a console password (Scored)"
  # List users with password enabled
  textTitle "$ID12" "$TITLE12" "SCORED" "LEVEL1"
  LIST_USERS_WITH_PASSWORD_ENABLED=$(cat $TEMP_REPORT_FILE|awk -F, '{print $1,$4}' | grep true | awk '{print $1}')
  if [[ $LIST_USERS_WITH_PASSWORD_ENABLED ]]; then
	for user in $LIST_USERS_WITH_PASSWORD_ENABLED; do
		MFA=$(cat $TEMP_REPORT_FILE | awk -F, '{print $1,$8}' | grep "$i" | awk '{print $8}')
		if [[ "$MFA" = "true" ]]; then
			textOK "User $user has Password and MFA enabled"
		else
			textWarn "User $user has Password enabled but MFA disabled"
		fi
	done
  else
	textOK "No users found with Password enabled and MFA disabled"
  fi
}

This version of the code on my AWS account works fine.
Can you verify this check and fix it?

thanks @AkiJ5 I'll check it out as soon as I can.

@AkiJ5 you have an old version of Prowler, can you please use the latest version? It was fixed already.

@toniblyx, OK, thank you!


As a CIF user, I want to update Annual Reports fields, so that I don't have to go to the Amendments page

Description:
Broken out from 1158.
Allow users a shortcut to the fields below without following the "New Revision" workflow. In the backend, it would create a new revision of type 'minor revision', apply the change and commit it. This will preserve change history while allowing quick edits to certain fields.
Annual Reports

Report Received Date (date picker)
General Comments (text input)

Acceptance Criteria:
Given I am on the Annual Reports view page
When I update the Report Received Date
Then the changes are saved as a minor revision and committed
Given I am on the Annual Reports view page
When I update the General Comments
Then the changes are saved as a minor revision and committed
Development Checklist:

[ ] The fields should use the widget factory created in #1382
[ ] unit and e2e testing
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

Hey team! Please add your planning poker estimate with Zenhub @BCerki @gurjmatharu @mikevespi @sam-warren @Sepehr-Sobhani @tmastrom @dleard

@LindsayMacfarlane  @Dianadec This is part of routinely updated fields and can be iceboxed/retired for now


add right bracket

Noticed (or rather my linter did) a compile error in one of the recipes.

Thanks :)


Improve help text on settings

https://github.com/jamesatjaminit/AllInOneDiscordBot/blob/main/commands/settings.js#L8-L8

Fixed in b19f4498529b91364814f7efef69e7347a8e6b81


Removes deprecated method

reportError has been removed in the latest SDK.
It appears that it is suggested to use Answers for this type of reporting.

when will this PR push to NPM?

@ajwhite Where did you see that its been removed? I see it in the header file in Crashlytics 3.7.2 and it doesn't mention being deprecated.

@corymsmith you know what - I think i had the wrong Podfile in front of me when I drafted this issue. It does appear to be in the latest versions, it was a 3.4.x release that did not support it.
Moving forward we can close this issue. Is it worth looking into a way to determine if the SDK, since it is defined by the user, has the Crashlytics version that supports this method and perhaps reject the call if it is not supported?

Yeah thats definitely something we may want to do. The biggest thing right now would be making the API consistent between Android and iOS since we have recordError for iOS and logException for Android, I've run into issues myself where I forgot that one is only supported on 1 platform. If you have any thoughts on that or time to dig into it let me know :)

Sounds good @corymsmith. Let's close this since this is indeed supported, just not in legacy versions.


[Fortinet - ResponseOnIP Playbook ] Deployment Fails

Describe the bug
When trying to use SystemAssigned Identity on Fortinet - ResponseOnIP Playbook fails on deployment. Every Pre-requisite is satisfied:
Custom connector
Function App
Deployment prompts:

{       "code": "MissingIdentityIds",       "message": "The identity ids must not be null or empty for 'UserAssigned' identity type."     }
It seems that the template restores the values and doesn't allows you to use SystemAssigned instead of UserAssigned identities. Other playbooks allow you to do it.
To Reproduce
Steps to reproduce the behavior:

Follow the deployment pre-requisites mentioned in fortinet folder
Select the template

Set Name and procced to parameters tab
Insert SystemManaged identity name

See the deployment Error

Hi @melv33n, we are trying to reproduce this issue on our end and will get back to you once there is an update

Hi @melv33n, we are still trying to reproduce this issue on our end and will get back to you once there is an update

Hi @melv33n, we have reached out to concerned team from our end and will get back to you by 17 Oct 2023

Hi @melv33n, we have reached out to concerned team from our end and will get back to you by 23 Oct 2023

Hi @melv33n, sorry for delay, we have reached out to concerned team from our end and will get back to you by 27 Oct 2023

Hi @melv33n, sorry for delay, we have reached out to concerned team from our end and will get back to you by 31 Oct 2023

Hi @melv33n, sorry for delay, we have reached out to concerned team from our end and will get back to you by 03 Nov 2023

@melv33n ,
We've created FortiGate playbooks specifically tailored to operate based on user identity. This is explicitly stated within the playbook's code.

Considering your note about system-assigned managed identity functioning with other playbooks, we attempted a similar approach with a different Fortinet FortiGate playbook, but encountered an error.

Your feedback will be taken into account and added to our backlog for future consideration, although we cannot currently provide an estimated time of resolution.


Add a report/summary for key steps in the run so that all the log files do not need to be checked manually (as currently described in the README)

@jmtsuji Can you update the description for this with more explanation of what to do?

Problem description
The run summary report currently generated by rotary is very basic. To understand what was done to each contig assembled by rotary and why (e.g., was the contig filtered by coverage, and why; how aggressively was it polished), a user currently needs to dig through several log files to find important information. It would be nice if we could generate more informative summary reports for rotary that collect this information for the user. Collecting this information for the user will also allow the user (and us, in end-to-end testing) to sanity-check the performance of rotary.
Proposed solution
I think the following types of reports could be helpful to create:

Read QC report: summary of % reads retained vs. discarded during short and long read polishing
Assembly report: the report already made by Flye could be used for this
Contig stats report from assembly, polishing, and circularization: could include per-contig info on: contig length, whether it is circular, end repair status, changed bases during read polishing (if not too hard to add), coverage filtration status, and whether it was rotated to a start gene like dnaA

the current contig report generated by rotary (at "{sample}/stats/{sample}_contig_info.tsv") already kind of accomplishes this, but it only includes a simple Yes/No summary for each contig of whether it is circular, it was end-repaired successfully, and was retained during coverage filtration. More info could be added to this file to make a better contig report.

Optional: Contig rotation report, to confirm that each contig was rotated to a new start position and then re-polished at least once during the pipeline. (It might actually be better to just confirm this by internal logic... a user might not need to see a report of this.)

After these reports are created, the Post-run tips section at the end of the README can be deleted, because this section summarizes which log files to manually check to obtain the above information.
Possible caveats
Because rotary has a lot of options that can be turned on or off (e.g., short read polishing; users can also just run up until the end of one module), we will need to consider how to make the reports modular so that the user can get reports at a variety of run endpoints. Rather than waiting to summarize all run info until the annotation module, we might need to add report summary rules within each module that summarize the information currently available. The next module can then take the run report from the previous module and add to it. I kind of do this already with "{sample}/stats/{sample}_contig_info.tsv"

@jmtsuji Can you update the description for this with more explanation of what to do?

@LeeBergstrand Done! Thanks for breaking up the to-do file into individual issues.

Quick update about the formats of the reports
To start, I was thinking that TSV files might be the most straightforward way to summarize the results from the different analysis steps. In general, one report could be made for each major bullet point above, with some exceptions (e.g., two reports might work better for read QC: one report for short reads and one report for long reads). In the longer term, we could consider making HTML reports with embedded tables and/or plots to summarize the rotary results (e.g., using info from the TSV files), if it's not too difficult to do this. I personally am happy with TSV files, but I wonder if users of the published version of the tool might appreciate a slightly more polished HTML report... @LeeBergstrand what are your thoughts?

Quick update about the formats of the reports
To start, I was thinking that TSV files might be the most straightforward way to summarize the results from the different analysis steps. In general, one report could be made for each major bullet point above, with some exceptions (e.g., two reports might work better for read QC: one report for short reads and one report for long reads). In the longer term, we could consider making HTML reports with embedded tables and/or plots to summarize the rotary results (e.g., using info from the TSV files), if it's not too difficult to do this. I personally am happy with TSV files, but I wonder if users of the published version of the tool might appreciate a slightly more polished HTML report... @LeeBergstrand what are your thoughts?

Right now I'm looking to use off-the-shelf tools to make the HTML reports. Most of the reports ATLAS makes, for example, could have been generated by third-party tools and aggregated by MultiQC.

@LeeBergstrand Agreed - using off-the-shelf tools for both stats (as much as possible) and HTML reports sounds like a good idea for maintenance etc.. Relevant for #91

QC Reports Generated Thus Far Per https://github.com/rotary-genomics/rotary/pull/214

[ ] Reads stats as generated by FASTQC
[ ] Reads removed before and after QC (short and long)
[ ] Assembly statistics a generated by QUAST
[ ] Aggregate statistics that show changes in assembly stats and qc across samples

Thanks for these additions! We might also consider aggregating the coverage stats for each genome somehow. We might be able to just directly concatenate the coverage tables that are currently generated (via samtools coverage) for each sample.

@jmtsuji That sounds good.

Thanks for these additions! We might also consider aggregating the coverage stats for each genome somehow. We might be able to just directly concatenate the coverage tables that are currently generated (via samtools coverage) for each sample.

@jmtsuji This sounds like a good idea. Can you make a pull request for this?

@Lee PR is now made -- see #223


Error in converting Ithera Scan Data to hdf5 data

Hi! I am trying to convert the raw scan data containing the msot,bir,irf etc files to hdf5 file format using your command below:
patato-import-ithera /path/to/itherastudyfolder /path/to/processeddatafolder
But the result says No Scan is found within the folders. I am using windows 11 and anaconda with separate patato environment.

@anirbanchakraborty96 Did you manage to get everything working with PATATO? I will close the issue if so.
Thanks :)


does LayoutXLM supports Korean also?

I am trying to extract the information from documents with LayoutXLM
however, I could not find any list about all supported 53 languages
I could only find 7 languages that are in XFUND
So, does LayoutXLM supports Korean?
And how about Layoutlmv3? does it support Korean?
Thanks in advance

https://arxiv.org/pdf/2104.08836.pdf
Korean is also supported.

How about the Layoutlmv3? I cannot find it even in paper


App/Fn retirements: date off by 1 in display

Looks like it's a display-only timezone related issue.

+1, I noticed this in the past, but forgot to raise an issue. It's display only, data is always stored correctly.


power-profiles-daemon: init at 0.1, add service module

Motivation for this change
Adds user selected power profile handling through DBus daemon.
nixpkgs issue  #97714
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@jtojnar It doesn't seem to build man pages, but I think that is broken upstream. It also looks like it builds gtk-doc but that directory gets removed in the fixup phase? Maybe there is something wrong with the expression, I don't know how to debug that.

Multiple-outputs hook moves gtk-doc to devdoc output, or to /dev/null if the former is not available. Add outputs = [ "out" "devdoc" ]; between version and src attributes.
It does not look like there are man pages, the command for generating them is not invoked by anything: https://gitlab.freedesktop.org/hadess/power-profiles-daemon/-/blob/7b5321131a7516e1e309f48357fffa2ae909863d/docs/meson.build#L48-60

Thanks. I just did these fixes locally, I didn't know about GitHub's "Commit suggestion," it looks like it credits the commenter, is that the preferred approach? Also, this PR should wait until integration into gnome shell is released, since there is no UI for it right?

For trivial fixes like these, attribution is not necessary (and the extra commits will be squashed onto the original commit anyway).
Merging this is fine just for coverage. And it might be usefult if someone wants to control this using D-Bus or by applying the g-c-c patches to their system.

Added nixos test, should I squash commits?

I would say either is fine. As long as the individual commits evaluate they are okay.

Sorry, I forgot about this, should be good to go. Will merge once the CI succeeds.

One occurrence of stdenv.lib got through.
Closed by #112507

https://github.com/NixOS/nixpkgs/blob/d600f006643e074c2ef1d72e462e218b647a096c/nixos/modules/services/hardware/power-profiles-daemon.nix#L37
I feel this is problematic, because regardless whether user enabled power-profiles-daemon or not, if they use tlp, the assertion fails

Should not that assertion being in mkIf cfg.enable make it only trigger when user enabled p-p-d?

I'm still using TLP on my laptop since this commit, so must be something else going on if you are having a problem.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/cant-enable-tlp-when-upgrading-to-21-05/13435/4


_point_sequential_decrement and Fill_in_bloom

Hello, little problem.
`
P='02504673bb8f9a16e40227b4ee12fb8d940630cb687fbc98c1747493d18e22f39c'
P = ice.pub2upub('02504673bb8f9a16e40227b4ee12fb8d940630cb687fbc98c1747493d18e22f39c')
xx=ice._point_sequential_decrement(15, P)
for t in range(10):
OnePub = xx[t65:t65+65]
print(ice.point_to_cpub(OnePub));
_bits, _hashes, _bf =ice.Fill_in_bloom(xx, _fp = 0.000001)
ice.dump_bloom_file('my_bloom_file3.bin',_bits, _hashes, _bf)
xsxa='023df3506a9994ad4a28bf59a14fecd436a2871d257129d6b3bbd02a9d5cafaef5'
xsxa = ice.pub2upub(xsxa)
print(ice.check_in_bloom(xsxa, _bits, _hashes, _bf))`
the xsxa public key in byte representation is exactly contained in the array passed to the "Fill_in_bloom" function
However, checking for presence in bloom - returns False
PS public keys obtained using the "point_subtraction" function and added to bloom are checked and found.
"check_in_bloom" function returns true

xx should be a List of elements not a byte array.
xsxa is same format as input List elements. Here for example in hex strings.

Hello, little problem. ` P='02504673bb8f9a16e40227b4ee12fb8d940630cb687fbc98c1747493d18e22f39c'
P = ice.pub2upub('02504673bb8f9a16e40227b4ee12fb8d940630cb687fbc98c1747493d18e22f39c') xx=ice._point_sequential_decrement(15, P) for t in range(10): OnePub = xx[t_65:t_65+65] print(ice.point_to_cpub(OnePub)); _bits, _hashes, _bf =ice.Fill_in_bloom(xx, _fp = 0.000001) ice.dump_bloom_file('my_bloom_file3.bin',_bits, _hashes, _bf) xsxa='023df3506a9994ad4a28bf59a14fecd436a2871d257129d6b3bbd02a9d5cafaef5' xsxa = ice.pub2upub(xsxa) print(ice.check_in_bloom(xsxa, _bits, _hashes, _bf))`
the xsxa public key in byte representation is exactly contained in the array passed to the "Fill_in_bloom" function However, checking for presence in bloom - returns False
PS public keys obtained using the "point_subtraction" function and added to bloom are checked and found. "check_in_bloom" function returns true

from where did you find this public key.key 023df3506a9994ad4a28bf59a14fecd436a2871d257129d6b3bbd02a9d5cafaef5 what is the private key from it?


Botkit and graphql

Currently there is a built in feature for using botkit with websockets, is there any plan to do the same with graphql?

Not currently.


fix(Linter/Textbased): account for different path separators in path comparison

The previous code considered two exceptions different if they used different path separators (such as when running on Windows, with the exceptions file being created on a Linux system).
Compare the set of path components instead: this is agnostic to the path separator used.
The mk_all script had a similar issue (see #13845, making the sorting of files platform-independent, in the face of different path separators which sort differently): its solution (sorting module names instead) would also work here, but is less pretty, as it the conversion to module names is in the IO monad. Comparing path components works just fine in our context.

bors merge


Update README.md

changes to help make the install process a little easier by being more comprehensive

fixes #1 and #3


Allow aggregating over *

This is done to provide similar API to Ecto.Query.API.count/0 as
counting over * is faster in some DB than counting over column, even
when column is NOT NULL and indexed.
Close #3175

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


Add versioning to hash_transaction

We need a version before the hash so we can make the state backwards-compatible. See Release v1.1.0.

Closing, we will get rid of the state in the next release thanks to #121


Update roadmap docs

Point to the more detailed planning process.
Remove future items list and point to the eh repo.

@maayanf24 This needs a manual rebase.

Done


Added a react spinner loader

🚀 Pull Request
Description
This pull request introduces a loading feature to enhance user experience during initial data fetching. A Loader component has been added to provide visual feedback while the application is loading. The loading state is managed in the main App component, ensuring that users see a spinner for one second on app startup.
Related Issue
Closes #391

@gauravsingh1281 Kindly check my PR

Hey @PulkitShubham your changes are not visible and your deploy preview has not been generated by netlify please pass all the checks by netlify.


On demand docker customization based on templates.

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?
Regarding the use of Traefik via docker, I noticed that it is necessary to make a number of customizations to the docker-compose.yaml files.  In order to avoid modifying the files and thus "dirtying" the repositories I thought of creating a tool for on-demand docker-compose.yaml customization.
The tool uses templates that can be customized based on the type of docker you are using. The tool was created to simplify the simplest operations and probably won't work for all occasions but it might be an idea and I thought I would share it.
Anyway, in case anyone is interested the tool is open-source and it's called traefik-warden.
I hope this idea can be useful.

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.

@ZappaBoy FYI, there's a typo in the "about" section of your project (s/Warder/Warden/).

@ZappaBoy FYI, there's a typo in the "about" section of your project (s/Warder/Warden/).
My bad, I renamed the repository twice. Thanks for the suggestion. 👍🏼


anytype: 0.43.4 -> 0.43.8

Bug fix updates for Anytype. Fixing issues reported by the community since the major 0.43.0 update and rewriting the underlying database. Changes diff.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 358206

x86_64-linux

:white_check_mark: 1 package built:

anytype


Can I use valgrind to check legion memory safety?

cd examples/circuit;make;valgrind -s --tool=memcheck --leak-check=full --show-leak-kinds=all ./circuit

ERROR SUMMARY: 32 errors from 3 contexts (suppressed: 0 from 0)

Does valgrind detect too much detail? Must the legion gc tool be used for detection?

As long as you're not running with software that valgrind can't check (CUDA, GASNet, etc), then you can use valgrind with Legion just fine. You might get some warnings (errors depending on your valgrind flags) about some leaked data (especially from Realm), but in general that is not anything to worry about as they are singleton data structures that will not cause memory leaks for long-running programs.
The better thing to do with Legion programs is to turn on bounds checks by defining the LEGION_BOUNDS_CHECKS macro. That will be a stronger check than valgrind in that it will actually check that all your accesses through Legion's FieldAccessor class are abiding by the declared privileges for your task (note if you ask for raw pointers from the FieldAccessor then the check is no longer sound). Similar to valgrind, you should expect a considerable performance slow-down when turning on these checks as every memory access done through the FieldAccessor will involve several branches and memory look-ups.

Just FYI: valgrind (usually) does not support all the instructions on your CPU, so if you want to use it, you'll also need to disable the -march=native flag that Legion builds with by default.
But as Mike said, LEGION_BOUNDS_CHECKS is easier and more precise, and will catch a lot of issues.

I also forgot to mention, valgrind is not very good at checking accesses by tasks into physical regions, because Realm usually allocates large chunks of virtual address space for its memories where instances are placed. This means that reads/writes that are out-of-bounds on an instance will look in-bounds to valgrind. Yet another reason that LEGION_BOUNDS_CHECKS (or -fbounds-checks 1 in Regent) is much better at detecting memory errors than valgrind.

Thank you for your patience. I tried a few simple demos and no errors were detected, including some memory leaks. I may try a more complex example later.


Fix for use strict

Inside the final else of the loader section of Hashmap is an innocuous error if 'use strict' is ever added.
	} else {
		// Browser globals (this is window)
		this.HashMap = factory();
	}

With 'use strict' the IIFE actually has no this variable because it is not called via bind/apply. Clearly this was meant as the final fallback to load Hashmap into the global namespace (window) when neither requirejs or amd are used. In a non-strict environment it would do just that, this === window, but with strict we don't get that luxury.
The code to discover "global" is from: https://github.com/purposeindustries/window-or-global/blob/master/lib/index.js
Which technically finds either window/self (browser) or global (node).
I only noticed this problem after running hashmap through a minifier, wherein it also added 'use struct'. I left my fix as optional as possible, so your code flow is unchanged unless this becomes falsey.
I know you aren't using 'use struct' in the project, but it would make it simpler for others if they concat/minify and 'use struct' ever gets added in.

Thank you, I'll take a better look at this asap

TBH I understand the issue but not a big fan of the solution. It seems super verbose and confusing for an issue that, after many years is the first time that is reported. I don't want to belittle your PR, but I always try to make sure the module is better after each PR and not worse (be it the legibility, maintainability, etc).
Also, I'm running jshint which should emulate use strict and it's not complaining about it. How can I reproduce the error/warning?

If you just toss a 'use strict'; at the top of hashmap.js and attempt to load it into any browser you'll see it halt immediately. Here is a very simple jsfiddle sample showing the same.
jshint never was fully es6 compliant (and strict is not optional in es6, it was in es5), which might be why it's not detecting this scenario.
I understand your trepidation, what if I made the PR a lot simpler? I wasn't sure how many other intended environments you were expecting that final else clause to run under so I went the extra paranoid route. We can make it infinitely simpler, as I only see that condition executing in a browser environment.

Please check the diffs now. We can safely pass 'use strict' now, and the library loads the same in pretty much any environment.

Much better now hehe! Two requests:

Rename window to sth that is not a pre-existing prop like scope.
Squash the commits into one with the correct commit message

Thanks

I believe you can control whether to squash the commits when merging on your end? Otherwise I need to open a new PR correct?

Ok, rebased.

Had to make another change. My simpler version of just passing this as parameter into the IIFE wasn't really strict compliant either (for ES6). It will likely just get replaced with void 0, which is useless.
Need to explicitly pass in window/self. The tests just assure that it is in fact an object and has a reference to itself (a common rule for window). This will also make sure when loading via node, you don't get an undefined reference exception.


Random Battle: Reject Aurorus Snow Warning with Hyper Voice

Added a counter that tracks Normal damaging moves for purposes of -ate
Abilities, in case it becomes important later. This counter also
future-proofs Aurorus in case it receives other viable Normal attacks
later.

Or maybe we should have the -ate ability have higher priority than Snow Warning, then reject that instead based on Normal attacks?
Actually, that's a great idea and I'll probably implement it later today since I have to sleep
It'll also let you have things like Cute Charm Sylveon if it's missing Hyper Voice, to truly mess people up. Surprise, your mon is hit by Attract now!

1efd11466f9f570f257e3e62df2308dcffe11d16 buffs -ate abilities. I think you should change this now so that it rejects -ate abilities without normal moves.

That was already my plan since I wanted -ate to have higher priority than Snow Warning, so the check would need to be rejecting that anyways. I'll get to it in a few hours.

@Zarel why did you merge this already...


help

so ive tried the bot ive installed all the packages and i got errors i fixed them but i really dont know what i should put here

You have to put a location to a file called IP2LOCATION-LITE-DB1.BIN that you downloaded from https://lite.ip2location.com/. You can just skip the -c/--check-country argument, but the location of the server won't show up in the results file.


GH-15136: [Python][macOS] Use @rpath for libarrow_python.dylib

Closes: #15136

@github-actions crossbow submit -g python

@github-actions crossbow submit -g python

@github-actions crossbow submit -g python

@github-actions crossbow submit -g wheel

@github-actions crossbow submit -g conda

@wjones127 Could you confirm that this solves #15136 in your environment?

Building off this branch, I can import pyarrow 👍
Looks like it is using @rpath:
> otool pyarrow/lib.cpython-310-darwin.so -L
pyarrow/lib.cpython-310-darwin.so:
        @rpath/libarrow_python.dylib (compatibility version 0.0.0, current version 0.0.0)
        /Users/willjones/mambaforge/envs/arrow-dev/lib/libarrow.1100.dylib (compatibility version 1100.0.0, current version 1100.0.0)
        @rpath/libc++.1.dylib (compatibility version 1.0.0, current version 1.0.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.100.3)

Thanks for confirming this.
I merge this.


labels off

#pri1

#pri2

#pri2

#backlog

#pri1

#backlog

#backlog

#pri1

#backlog

#pri1

#backlog

#pri1

The feedback you logged for labels off has been in our backlog for 90 days. While we try to respond individually to as many feedback items as possible, we are not able to respond to all of them. Since this item has been in the backlog for 90 days, we’re closing it.
For more information about the process by which we handle documentation feedback, see "How we respond to Azure technical documentation feedback" in our public contributor guide.

The feedback you logged for labels off has been in our backlog for 90 days. While we try to respond individually to as many feedback items as possible, we are not able to respond to all of them. Since this item has been in the backlog for 90 days, we’re closing it.
For more information about the process by which we handle documentation feedback, see "How we respond to Azure technical documentation feedback" in our public contributor guide.


more general eigen solver keywords

@jakevdp this should, for example, let you set the verbosity level of lobpcg. Note if method is amg then I check sovler_kwds for ones that are amg and then assume the rest are for lobpcg. Embeddings now accept a solver_kwds parameter as well. I would consider putting this in base_estimator but there may be future embeddings that do not use an eigen solver.


window.opener exploitable & security headers missing?

 Not very serious, but worth doing. Read more
I know, I know. Everybody hates when others tell them they are missing security headers. Is there any reason why the X-XSS-Protection header is not set? There are a few others I'd add too, but these depend on how the site is set up:

Strict-Transport-Security: Require use of HTTPS
Content-Security-Policy: Mitigates some XSS attacks
Public-Key-Pins: Prevents MiTM attacks using rouge X.509 certs if the CA is compromised
X-Frame-Options: Stops clickjacking attacks
X-Content-Type-Options: Stops browser from MIME-sniffing

[ ] window.opener
[ ] strict transport security
[ ] csp
[ ] public key pins
[ ] x-frame-options
[ ] x-content-type-options