Addressing  deprecation wranings in Kinetics (#5787)

See #5787

@bjuncek @pmeier We need to speed up the work on this as we are about to cut the branch for the release. If more work is needed, I would just address the deprecation warning on a different PR.
Concerning the removal of ConvertBHWCtoBCHW, we need to be extra careful with this because it affects how people are doing inference and use their models. See:
https://github.com/pytorch/vision/blob/769ae132152367f73ec71a1c7ab226e3127ae624/torchvision/transforms/_presets.py#L96-L102

Hi @datumbox ,
So what is your proposal for this?
In summary:

Deprication warning can be straight-up removed as it's pointless at the moment. The goal is either to make it less pointless (by re-writing a solid chunk of videoIO), or to have a status quo where users can use whatever they like.
Addressing deprecation of Kinetics, by extension means removing of the BHWC to BCHW transform. I feel as if adding deprecation warning should be plenty, and we can liaison with whomever is in charge of transforms (Victor?) to figure out the best way to handle this on the preset level. I don't understand enough about _presets to have an opinion on it.

@bjuncek I'm OK to removing the deprecation warning until we have a proper video module to recommend.
Concerning the presets, the problem is that the removal of the permutation affects how our users use the existing models to perform inference. This is a big problem and we need to figure it out prior the release. Else we will be looking at a BC breaking change on the near future. Effectively we need to be clear, what is the order of dimensions that the preprocessing (preset) transforms should accept the input and stick with it.
cc @pmeier @vfdev-5

Ok, that makes sense.
So in the short term, should I just add the parameter for the output format to Kinetics class, and set it to legacy by default and add a warning that it's about to be changed?

My current understanding (could be wrong) is that the permutation should not be removed because read_video() returns the output as (T, H, W, C) so the permutation is necessary and should remain in place. Correct me if I'm wrong, but if read_video uses this format then this is no longer about changing the order inside the Kinetics but rather changing the format everywhere in the library. That's a very big discussion to be had so close to the release with major BC-breaking implications.
For more info on using read_video with the new presets see the example at the docs.

Geometric transforms, like Resize, should assume the input data of shape [..., H, W] and for Normalize it should be (..., C, H, W). So we need to adapt input data format before feeding it into transformations and finally readapt it for the model's expected format.

So, you are right, the read_video outputs (t, h, w, c).
In new Kinetics class, we introduce this permutation in order to save the users of going to the trouble of permuting stuff every time they get a sample (see here), which is correctly documented in the Kinetics class and has nothing to do with read_video.
If we want to prevent BC, we can simply comment out the lines referenced above, and return the  transform to the reference.

@datumbox The "BC break", i.e. the changed dimension order, happened in #3680 and more specifically after https://github.com/pytorch/vision/pull/3680#discussion_r646403139 almost a year ago.

Thanks for the info.
I understand the reasons why we wanted to switch to (t, c, h, w) but we could have done better work when we introduced the BC breaking change by ensuring that all usages/references/documentation/examples in the codebase are updated.
To fix things prior the release, I think we need to:

Update the references to adopt the new Kinetics (this PR)
Update all the code examples to do permute the output of read_video immediately after reading it.
Update the presets to remove the (N, T, H, W, C) => (N, T, C, H, W) conversion.

Please let me know if this makes sense to you.


Cow: Watch fmedia.22web.org

Cow requests the watch of the watch_keyword fmedia\.22web\.org. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

fmedia\.22web\.org has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jesse in Charcoal HQ


Include metadata.yaml in release

Closes #55
This should enable use with clusterct.
Reference for the metadata file.
cat << EOF > $HOME/.cluster-api/clusterctl.yaml
providers:
- name: "k3s"
  url: "https://github.com/cluster-api-provider-k3s/cluster-api-k3s/releases/v0.1.7/bootstrap-components.yaml"
  type: "BootstrapProvider"
- name: "k3s"
  url: "https://github.com/cluster-api-provider-k3s/cluster-api-k3s/releases/v0.1.7/control-plane-components.yaml"
  type: "ControlPlaneProvider"
EOF

And init a management cluster with clusterctl init --control-plane k3s:v0.1.7 --bootstrap k3s:v0.1.7.

Thanks @anmazzotti . We should also attach it to the assets of the release.


command+p; command+shift+p; focus issue

Description
command+p; command+shift+p; focus issue
Steps to Reproduce

focus in contents of some file
command+p;
command+shift+p;
not focus is in file instead of dialog; if you type something text is entered in the file where you had focus before.

Expected behavior: [What you expect to happen]
Focus should be (when you type something text should go) in input of "command palette"
Actual behavior: [What actually happens]
Focus should is (when you type something text should goes) in file you had focused before
Reproduces how often: [What percentage of the time does it reproduce?]
Always
Versions
1.20.0 (and in old versions too)
Additional Information

Thanks for taking the time to contribute!
We noticed that this is a duplicate of https://github.com/atom/atom/issues/14325. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Copyright fixes

Fixes a few simple issues. Attempted to fix 32 but failed.
Atom editor seems to remove spaces - hope this isn't an issue.

Thanks for all the fixes, content is a tad drafty.


[BUG] The system cannot find the file specified | NetworkInformationException | at System.Net.NetworkInformation.SystemIPGlobalProperties.GetFixedInfo()

Which service(blob, file, queue, table) does this issue concern?
Azure blob storage
Which version of the SDK was used?
11.1.7
Which platform are you using? (ex: .NET Core 2.1)
.NET Framework 4.7.2
What problem was encountered?
Exception Type:
NetworkInformationException
Message:
The system cannot find the file specified
Stack Trace:
at System.Net.NetworkInformation.SystemIPGlobalProperties.GetFixedInfo()
at System.Net.NetworkInformation.SystemIPGlobalProperties.get_FixedInfo()
at System.Net.NetworkInformation.SystemIPGlobalProperties.get_DomainName()
at System.Net.CookieContainer..ctor()
at System.Net.Http.HttpClientHandler..ctor()
at Microsoft.Azure.Storage.Auth.Protocol.StorageAuthenticationHttpHandler.<>c.<.cctor>b__12_0()
at System.Lazy1.CreateValue()    at System.Lazy1.LazyInitValue()
at System.Lazy1.get_Value()    at Microsoft.Azure.Storage.Auth.Protocol.StorageAuthenticationHttpHandler.get_Instance()    at Microsoft.Azure.Storage.Shared.Protocol.HttpClientFactory.<>c.<.cctor>b__5_0()    at System.Lazy1.CreateValue()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Lazy1.get_Value()    at Microsoft.Azure.Storage.Shared.Protocol.HttpClientFactory.get_Instance()    at Microsoft.Azure.Storage.Core.Executor.Executor.<ExecuteAsync>d__11.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Azure.Storage.Blob.CloudBlockBlob.d__72.MoveNext()
How can we reproduce the problem in the simplest way?
It is happening when running in azure web app, using P1V3 (Dual core specs), only 1 server is encountering this kind of issue out of 3 servers. We are using VNET integration with WEBSITE_VNET_ROUTE_ALL = 1.
Have you found a mitigation/solution?
None.

Thank you for your feedback.  Tagging and routing to the team best able to assist.

@jsquire thank you for responding and looking at my bug. This is a critical bug and its occurring always, I am not sure if there is an bug with azure web app perhaps you could also check and collaborate with azure web app team. Thank you!

Hi @firephantomassasin.  In this case, I'm only acting as first-line triage, routing to the appropriate team for assistance.   The one thing that I'll note is that if you feel this is a critical issue with timing sensitivity, a GitHub issue may not be the best path for support.  Opening a formal support ticket with Azure via the portal will help bring this to the attention of the support team and opens paths for escalation.

@jsquire I also opened a support ticket already with Azure via the Portal as well. But I'm posting this here as well so that the engineers of the SDK could look at it as well. Looking forward to your response.

Hi, I see you created the same issue here https://github.com/Azure/azure-storage-net/issues/1030. That's actually the correct place to create the issue and request feedback, since this repo contains the current and supported version of the library v12.
Marking as duplicate and closing this issue in preference to the other issue. I would encourage you to upgrade if you can to the current latest supported version v12 since v11 is deprecated.
Please reopen or reply if there are further questions.


Extending the objects metadata (API and Consumer) with more attributes

Summary
First of all, the work that you guys have been doing here is great, thanks to all of you.
I'm looking at using Kong for a large project. Its features are really appealing, but I find the objects metadata to be very limited. As the number of APIs grows, more data becomes necessary to describe/categorize/organize them, as well as the consumers.
Implementing a layer on top of Kong would be possible of course, but that would imply duplicated data and possibly out of sync issues between the custom data extension layer and Kong.
Given this I compiled a list of attributes that I think would be really useful to have in Kong's DAO (while keeping them optional, so we wouldn't break compatibility and those who are ok with the current set of attributes will continue to be happy too).
I'm not a Lua programmer but I'm willing to give it a try and implement it, if the community finds that it's worth it.
Bellow I list the current attributes and the ones I would add for each object.
API Object:
Currently:

name
request_host
request_path
strip_request_path
preserve_host
upstream_url

Addition:

tags: Array of tags.
description: A short description (name is not enough I think).
group: The logical/functional group (e.g. network, hosting, billing, etc).
maintainer: The name of the maintainer.
maintainer_contact: The contact of the maintainer (e.g. phone or email).
publisher: The user who published.
repository: The URL of the repository.
version: API version (e.g. v1).
destination_system: The system to which the API connects to (if any).

Consumer Object:
Currently:

username
custom_id

Addition:

type: If the consumer is a system or an end user.
contact: The consumer contact (e.g. phone or email).
contact_name: The contact name.

So what do you think about it? Any other suggestions?

Is there any interest in this from others? I also have a need for something similar

Thanks for the explanation and thought here. Adding this in has been on our radar for quite a while. We're trying to keep GitHub issues reserved for actual problems/bug reports for Kong, so we're closing this, and we'll keep this in mind moving forward. Thank you!


Download images?

There is a download option that comes with the IOS share menu (and it works), is there a way to use this plugin to download images, perhaps with the sharvia method? There's not a super user-friendly way to do this with Cordova right now and if this plugin did that, it would remove some barrier to entry.

Hi, nice idea!
I've just added saveToPhotoAlbum (iOS only for now) which takes an array of images which will be saved to the camera roll.
Please give it a spin if you have time,
Eddy

First off, great plugin. Thanks for creating it.
Are there any plans to support saveToPhotoAlbum on Android?


Provide MPD url and segment durations in JSON

[x] Searched the bugtracker for similar pull requests
[x] New feature

mpv is planning to support segmented dash support that would need potentially both these commits.

Hi, could you split the two changes into two pull requests? The idea of dash_mpds is not so good. I suggest adding a new field, maybe manifest_url, to formats, so that f4m and hls can use it as well. Also, don't forget to document it.

i already proposed to return the mpd_url in #8848 and #9109 the will return the url according to the standard and without in introducing a new field in the info dict.

I see both PRs closed. Are they incomplete yet?

no, #9109 replaces #8848 with more improvments, but maintaining it for a long time was difficult(handle lots of merge conlicts) and also some of the code in the pull request was introduced in the master(handling $Time in media_template) branch which make some of duplication in the functionality.

I don't see the dash mpd urls or segment duration anywhere on -J from master.

mpv needs at least one of these to support http_dash_fragments.

Then could you remove the line dash_mpds? Other changes are less controversial.

i don't think that it's a good idea for mpv to depend on the segement urls in the info dict, in my opinion the only information that should be returned about dash formats is the url of the mpd manifest.

@remitamine I guess your concern is that fields like segment_urls are for youtube-dl internal uses only and may change at any time? Then the way to go is #9109.

I guess your concern is that fields like segment_urls are for youtube-dl internal uses only and may change at any time?

yes.

Then the way to go is #9109.

it should be created again as there was a lot of changes since the #9109 was created, for now i think that #9937 is more important to be processed than #9109 , if it's acceptable i can push the code to return the mpd url directly to master branch, than i will try to open another PR for the other changes after #9937 merged.

OK I'll look at #9937 first. By the way, I've opened a milestone at https://github.com/rg3/youtube-dl/milestone/6 to track all relevant pull requests and issues. Hope that reduces some headaches.

Will be available in the next version as:
"formats" : {
  ...
  "manifest_url": "http://manifest/url.mpd",
  "fragments": [
    {
      "url": "http://fragment1/url",
      "duration": 0,
    },
    {
      "url": "http://fragment2/url",
      "duration": 0,
    },
    ...
  ]
  ...
}


Add kangax compat-table tests

More tests the better, will hopefully help avoid regressions.

From me only Object.getOwnPropertySymbols and Symbol.species. Also, I think be better remove from build step typeofSymbol transformer and enable Object(symbol).

@zloirock I'll probably only add the syntax related tests as all the other stuff doesn't really matter to 6to5.

@sebmck I mean, if somebody will change results of 6to5 tests in table, can add to the results these.


Feature need of datatable and picture in reply

Such a great component! I’m trying to use it to make a QA system, are you planning to add data table and picture in chat?

Will try to implement it ASAP if possible

Will try to implement it ASAP if possible

Yes it will be better if you implement the datatable and a procedure to change the picture of the user and the bot

hello, is there any chance to add this feature?


chore(deps): updates deps

and dev deps

Codecov Report

Merging #125 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #125   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           46        46
  Branches         6         6
=========================================
  Hits            46        46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d0fc5c...85c20b4. Read the comment docs.


feat: add chart for overview data

Closes #5
This pr should add chart below the main overview table.
It uses quickchart.io to generate chart image.

Wow! @shevernitskiy I totally missed this PR but it is really cool! Thank you! :D

@eliassjogreen seems like chart image misplaced, my bad. Could you fix it please?:)

@eliassjogreen seems like chart image misplaced, my bad. Could you fix it please?:)

Yep I realized, tried to fix it yesterday but my fix didn't work and wont be able to fix it until tomorrow now. :)


fvar check proposal: Validate nameID value used in InstanceRecord.subfamilyNameID

Quote from the fvar documentation in OpenType spec v1.9 (my emphasis):

The subfamilyNameID field provides a name ID that can be used to obtain strings from the 'name' table that can be treated as equivalent to name ID 17 (typographic subfamily) strings for the given instance. Values of 2 or 17 can be used; otherwise, values must be greater than 255 and less than 32768.

I hereby propose a new fvar check that validates that the value of subfamilyNameID used by each InstanceRecord be 2, 17, or greater than 255 and less than 32768.
The check should FAIL if the conditions are not met.

Values of 2 or 17 can be used; otherwise, values must be greater than 255 and less than 32768.

FWIW I find this wording problematic. Any value can be used if the corresponding name is what the user desires...

@behdad That's the exact wording in the OT fvar spec.

I understand it is.

@behdad That's the exact wording in the OT fvar spec.

I understand it is.

It's just one of those arbitrary requirements of the spec that is misguided. I'm sure I filed an extensive report about it somewhere but can't find right now.


Project Name - What should it be called?

We might not want to stick with PCO when it comes time to write the PHP extension to submit to PECL. Can we come up with a better one?

For the time being, Php\Crypto is the namespace.


Added missing managers search Query

Created a new search query for fetching "Active identities with missing managers"
I added a new folder to "/home/example-pages/missing-managers". There are 3 changes:

Created a new folder under example-pages and called it "missing-managers".
Added +page.svelte and +page.server.ts to that folder.
Edited the "/routes/home/example-pages/reports.ts" file to include the path/URL to the missing-managers

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Drop unused host and port from low-level server

@fafhrd91 do you remember why these params exist??

+1
I used it before we added aiohttp.web
Sent from my iPhone

On Oct 23, 2015, at 1:13 AM, Andrew Svetlov<EMAIL_ADDRESS>wrote:
@fafhrd91 do you remember why these params exist??
You can view, comment on, or merge this pull request online at:
https://github.com/KeepSafe/aiohttp/pull/586
Commit Summary
Drop unused host and port from low-level server
File Changes
M aiohttp/server.py (4)
Patch Links:
https://github.com/KeepSafe/aiohttp/pull/586.patch
https://github.com/KeepSafe/aiohttp/pull/586.diff
—
Reply to this email directly or view it on GitHub.


fix can not toggle off discord target

when there is a discord target exists(discord id is exists), we always reset the useDiscord to true, even if the user has been toggles off the discord from edit view.
contactInfo?.discord?.active && useDiscord is the logic for showing discord target, useDiscord === true should only be set when user switches on from the toggle button

@marukohao
When the discord is toggled off, the discordTarget in TargetGroup should be empty array. So it should not get into if (discordId) { block and the useDiscord should not be set to turn again. Not sure what issue you are encountering.
I just had a test. It is working normally.

I think we can close this, right?


Feature: using same key to toggle behaviors

The same keybinding should be able to toggle specific behavior.
For example, if m is to mark, I expect m to unmark a file that is already marked.
t should activate -- or deactivate -- the git-diff view.
o should expand all -- or collapse all -- of the directories.
etc.

Great suggestion! I'll look into implementing this for marks. t does this already. On the subject of o, I don't think this is great as a toggle, as you don't need all directories open for it to still do something effective. For example, if you had one directory open and press o, the current behavior is to open all the rest, which I think is best. I can, however, make it so when all the directories are open and o is pressed, it closes everything.

I made it so m toggles marks. It'll be available in v1.1.0!
Thanks again for all your suggestions and feedback - they've already improved projectable a lot!

Wicked!

I can, however, make it so when all the directories are open and o is pressed, it closes everything.

This is reasonable. Generally speaking, if I press a key to do something, but that something is already done, then do the opposite of that something -- where it makes sense, of course.


Google Analytics Consent

Please remove Google Analytics from the github pages there is no reason for it.
Current laws in EU require explicit consent before data Google Analytics collects is allowed.

Hi Lucian, thanks for checking out the package and for raising this. You're right, GA is just unnecessary here. I just pushed a commit to remove it.


basic pip template

this will add a basic pip template to your repository
it is recommended that after you merge this you add a github workflow called python-publish.
How to use this pr before merging
!pip install -qU git+https://github.com/not-lain/moondream.git@pip # my branch name

import moondream
dir(moondream) # to checkout all the attributes and methods related to moondream

Got this set up in clients/python, thanks for the reference!


added austrian "gemeinden" (communities)

This adds sites from austrian communities.
Source: http://www.staedtebund.gv.at/organisation/staedtebund/gvat-gemeindenamen.html
Parser for the site: https://gist.github.com/FireFart/bf8431125750e4ff0597
PS: "Steiermark" was not added because they link to a PDF which is not easy parseable
Also added the files generated by the script to .gitignore

Thank you for the contribution. The Austria page already has quite a few more entries than other pages. My hope is a selection of representative and important sites can be listed that rather than every site there is.

Hi @gutworth, thanks for your reply. So what do you think is your limit of listed sites per country? The generation of the content lasted a few minutes on my computer so I think it should be doable when splitting up the generation process. It surely depends on the rescan interval. I think every week or month would be a good start. If you split all sites over the whole week or month, it should also be not too much traffic.

My concern is not the speed of the checker but the the length of the Austria page. My intention was not to create an exhaustive list of sites for every country but rather highlight important and popular websites. What are the 50-100 sites Austrians are most likely to be visiting?

What do you think about adding the ALEXA top 50/100 on top and the other sites below (collapsed with jquery)? This could be doable for every country

That's a possibility. We don't have the UI for it at the moment. My preference is a nicely curated small list.


Changed the logic for comparing volsize and updatesize when scaling up.

this should fix #220

Closing this since we did not receive any response. Please feel free to reopen this.


Peer authorisation

Some kind of transport-agnostic API or trait that lets you add steps to 'authorise' a peer before it's considered fully connected, but only after a handshake so reliability is ensured. This could be a whole stage in #16.
It should be added during construction of the App, and it's iterated by transport layers before they say "yep, this peer's all good!"
Should the I/O API be distinct from the typed message API exposed to systems? They should probably just directly take in/put out bytes for transmission, which the transport layer will deal with however it chooses.
Other considerations:

Should all authorisation steps need to finish and signal acceptance before the peer is let in?
Should authorisation steps be able to have a 'minimum security level' like described in #14?
The hashing feature flag can probably be implemented as an authorisation step.

On second thought, it's probably better to have a solution where systems can signal to NetworkPeer entities that they're running authentication checks. When that's passed, then other systems are made aware of that and can run as per usual. This allows authentication checks, being systems, to access the World (which a trait solution can't easily do) so extra data can be appended, like state.


Fixed female lastName + added tests for ru_RU Person

This is a better variant of https://github.com/fzaninotto/Faker/pull/1546


L10N: 1.1 new feature and fix

'Unpublished on' dates should be dates in the future. (relate to #104 )

You must set a valid Local file Path. (relate to #122 )

(relate to #110 )
"This app does not have access to your photos or videos.
You can enable access in Privacy Settings."

Uploader - 画像の複数アップロードしている最中の画面

Relate to #164

Custom
Any size

relate to #193

You can upload 8 photos at once.

When you not enter custom size, or enter too small/huge value, you'll get this message.

Please enter a custom size.

再構築を一度もしていないブログ／ウェブサイトにアップロードを行った場合のアップロードエラー文言

Image upload
There is the rest of the items , you sure that you want to upload again?
YES
NO

上記のエラーで、YESをクリックした場合

Upload error

You must set a vaild path.

When you upload untitled Entry/Page

Entry
Page

Upload Error
Do not have permission to create an entry.

When you don't have permission for upload image.

Upload Error
Do not have permission to upload.

When user doesn't have permission for the website.

Do not have permission to retrieve the requested fields.

https://github.com/movabletype/smartphone-app/commit/14c9782b2c8249b2dcb5312c67d29ab7e44cd043

長くて紛らわしくなってきたので、今後のものは #234 へ。
このチケットはクローズ。


Fix typo in AffinityAssistantBehavior

Changes
This commit fixes the typo in AffinityAssitantBehavior to AffinityAssistantBehavior.
/kind cleanup

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/test check-pr-has-kind-label
https://github.com/yaml/pyyaml/pull/702 is merged

/test check-pr-has-kind-label


Add support for filters

Add support for filters:

[ ] :cdata
[ ] :coffee
[ ] :css
[ ] :erb
[ ] :escaped
[ ] :javascript
[ ] :less
[ ] :markdown
[ ] :maruku
[ ] :plain
[ ] :preserve
[ ] :ruby
[ ] :sass
[ ] :scss
[ ] :textile
[ ] Custom filters

Closed via https://github.com/vitallium/tree-sitter-haml/commit/7368cb37a8345c8f05440c1fa2122fcd4439d297


Refactor/straight  build functions

An implementation of what I was suggesting with #659 and #655.
The README will need to be reworded, but I figured we could discuss the viability of such an approach before making substantial edits.
A recipe may specify build steps via the :build keyword.
(Note the original :build keyword has been renamed to :pre-build)
The :build keyword accepts the following values:

nil
No build is executed. :pre-build and :post-build commands are not run.

     (example :build nil)

t
Equivalent to running straight--default-build-steps (see below).

(step...)
Each step in the list is a symbol which represents a function named straight--build-SYMBOL.
The function is passed the recipe as its sole argument.
Steps are executed in the order they are listed.

(example :build (autoloads compile native-compile info))

(:not step...)
If the car of the list is the :not keyword, the build steps are the
set difference of straight--build-default-steps and the cdr of the
recipe's :build list.
e.g. with straight--build-default-steps set to:

(autoloads compile native-compile info)

and the following recipe:
(example :build (:not compile info))

the package is not byte compiled and does not have it's texinfo generated.
Steps may be disabled globally via the customization variable named
straight-disable-SYMBOL. e.g.:
(setq straight-disable-info t)
;;info generation disabled when :build is not explicitly declared
(straight-use-package '(example))
;;or starts with :not
;;Info disabled in addition to compilation.
(straight-use-package '(example :build (:not compile)))

In the absence of a :build keyword, straight--build-default-steps are run.

Yeah, this all sounds perfect! It seems like a much better interface all around. Same with your comments in https://github.com/raxod502/straight.el/pull/655, https://github.com/raxod502/straight.el/issues/654, https://github.com/raxod502/straight.el/issues/659: this all seems great.

Sounds good. I'll add some tests, define-obsolet-variable-aliases for the option name changes, and edit the documentation. How do you prefer to deal with the news of the :build -> :pre-build rename? Is a notice in the README sufficient?

Sounds good. I'll add some tests, define-obsolet-variable-aliases for the option name changes, and edit the documentation. How do you prefer to deal with the news of the :build -> :pre-build rename? Is a notice in the README sufficient?

Added a unit test for straight--build-setps, properly obsoleted changed defcustoms, updated README and made note of the breaking change in the NEWS section.

Added a unit test for straight--build-setps, properly obsoleted changed defcustoms, updated README and made note of the breaking change in the NEWS section.

Is a News entry in the README sufficient?

I think that would be fine, given that :build itself was only added recently.

Is a News entry in the README sufficient?

I think that would be fine, given that :build itself was only added recently.


Working Example

Can you please add a working example of how to connect to tradeovate, get your account balances/positions and place a trade?
I'd be happy to contribute to this library/documentation but I just need to know how to get started.

Yes, I'll be working on this soon. Prob ~2 weeks I'll have those examples and more.

Is there some way I can access this sooner? We have a project that needs to
be completely finished in 2 weeks and would prefer to not have to use
requests.
Any sample code you could share now would be very useful. Just need to
connect, get account info, positions and place trades. I can look through
the code to find details if needed and I’d be happy to help you with the
docs.
On Sat, Nov 12, 2022 at 6:41 PM Antonio Hickey @.***>
wrote:

Yes, I'll be working on this soon. Prob ~2 weeks I'll have those examples
and more.
—
Reply to this email directly, view it on GitHub
https://github.com/antonio-hickey/TradovatePy/issues/3#issuecomment-1312597349,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIYQK3MBTFXJEWU4ECFAXLWIATJRANCNFSM6AAAAAAR5BO7OQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Robert Grzesik<PHONE_NUMBER>

Going to be at least 4 days. I haven't used Tradovate in a few months, but I just transferred in the minimum for API Access waiting for it to clear. I don't have any examples on hand as I bricked the machine I was building this on.
I can't test right now as I fail to connect without API Access, but I feel like something like getting your positions would work roughly something like this:
pip install -r requirements.txt

# a new file at root of the repo, ex: 'application.py'
import asyncio
from TradovatePy.models.session import Session
from TradovatePy.positions import Positions

if __name__ == "__main__":
    session = Session(
        "LIVE",
        "YOUR_USERNAME",
        "YOUR_PASSWORD",
        "YOUR_SECRET_KEY",
        "YOUR_DEVICE_ID",
        "YOUR_APP_VERSION",
        "YOUR_APP_ID",
        123, # YOUR CID
    )
    print(
        asyncio.run(Positions(session).position_list())
    )

then run that new python file, sorry I will be working on this project again soon.

oh it's also worth mentioning that since this project isn't finished you will have to build from source instead of installing using pip, just clone the repo via git clone https://github.com/antonio-hickey/TradovatePy.git

Ok thank you! This is extremely helpful!
On Sun, Nov 13, 2022 at 9:43 AM Antonio Hickey @.***>
wrote:

oh it's also worth mentioning that since this project isn't finished you
will have to build from source instead of installing using pip, just clone
the repo via git clone https://github.com/antonio-hickey/TradovatePy.git
—
Reply to this email directly, view it on GitHub
https://github.com/antonio-hickey/TradovatePy/issues/3#issuecomment-1312747278,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIYQK4L7H3DE3KPNIBZQCLWID5CNANCNFSM6AAAAAAR5BO7OQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Robert Grzesik<PHONE_NUMBER>

So I guess the rules around the API have changed since this project was started, now we have to register with CME and pay them $390 a month + tradovate's monthly API subscription.
I will no longer be maintaining this project, but I'll keep it up as an archive and try to help with any pre-existing code.

Where do you see this? We have clients using tradovate and I’ve never heard
of a $390/mo fee
On Tue, Nov 15, 2022 at 7:03 PM Antonio Hickey @.***>
wrote:

So I guess the rules around the API have changed since this project was
started, now we have to register with CME and pay them $390 a month +
tradovate's monthly API subscription.
I will no longer be maintaining this project, but I'll keep it up as an
archive and try to help with any pre-existing code.
—
Reply to this email directly, view it on GitHub
https://github.com/antonio-hickey/TradovatePy/issues/3#issuecomment-1316056768,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIYQKYSEU2MW4ZHFZ2QWHLWIQQDZANCNFSM6AAAAAAR5BO7OQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Robert Grzesik<PHONE_NUMBER>

They even have a $0/mo plan.
On Wed, Nov 16, 2022 at 2:49 PM Robert Grzesik @.***>
wrote:

Where do you see this? We have clients using tradovate and I’ve never
heard of a $390/mo fee
On Tue, Nov 15, 2022 at 7:03 PM Antonio Hickey @.***>
wrote:

So I guess the rules around the API have changed since this project was
started, now we have to register with CME and pay them $390 a month +
tradovate's monthly API subscription.
I will no longer be maintaining this project, but I'll keep it up as an
archive and try to help with any pre-existing code.
—
Reply to this email directly, view it on GitHub
https://github.com/antonio-hickey/TradovatePy/issues/3#issuecomment-1316056768,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIYQKYSEU2MW4ZHFZ2QWHLWIQQDZANCNFSM6AAAAAAR5BO7OQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Robert Grzesik<PHONE_NUMBER>

--
Robert Grzesik<PHONE_NUMBER>

For API Access, to have an account is free. The Tradovate API Subscription cost $25/mo + you have to register with CME for Non Display Category A license which is $390/mo.
This is a recent change in how it works, was previously just a $25/mo fee to Tradovate.

Could you please point me to where it says this? I can’t seem to find it
anywhere on their website.
On Wed, Nov 16, 2022 at 2:57 PM Antonio Hickey @.***>
wrote:

For API Access, to have an account is free. The Tradovate API Subscription
cost $25/mo + you have to register with CME for Non Display Category A
license which is $390/mo.
This is a recent change in how it works, was previously just a $25/mo fee
to Tradovate.
—
Reply to this email directly, view it on GitHub
https://github.com/antonio-hickey/TradovatePy/issues/3#issuecomment-1317592907,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIYQK46O2OHUOWCMY2I3ODWIU4CVANCNFSM6AAAAAAR5BO7OQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Robert Grzesik<PHONE_NUMBER>

They don't mention it because it's not attractive to their retail customer base, I had to find out via talking to support.
Just to make sure we're on the same page I'm solely talking about API, and NOT just a basic account.
It's $25/mo for access to their API, and $390/mo for User Non-Display Category A to CME (https://www.cmegroup.com/files/download/cme-market-data-fee-list-jan-2022.pdf)
I'll start uploading documentation and examples for all existing code this weekend and fix the SSL bug, I have not paid the $390 monthly fee to CME, so I'll only be maintaining what I actually have access to and can test.

Thank you for building the wrapper. I'm excited to try it! I've recently starting working on a custom wrapper for tradovate when I found this.
About the market data subscriptions, I am not sure if they have changed their pricings, but I was able to only subscribe to the specific CME exchange rather than the CME Group, which was a lot cheaper.

Hey @STW090211 Thanks,
The market data subscription for their API is separate from the regular market data subscriptions. Market data through the Tradovate API falls under User Non-Display Category A according to the last time I inquired Tradovate about it (~ November 2022).
Hopefully they fixed or got rid of this, are you able to get market data from the API?

So far, I haven't been able to get the market data to work. My account is marked true for live data but is giving me errors when trying to retrieve contract information.

@STW090211
You can open a new issue with details on your errors, and I'll try to help ya out :)
I'm closing this issue with installation and example docs in commit: 24efbf19c0391f02d1003f012e81d99ca2ad0fbb


Expired WWDR certificate on Travis with Match

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Seen this issue before and it was marked 'resolved', but the error is still present in the latest versions of fastlane and match. Can't build anything on TravisCI.
Complete output when running fastlane, including the stack trace and command used
+-----------------------+-----------------------------------------+
|                     Summary for match 0.6.1                     |
+-----------------------+-----------------------------------------+
| type                  | appstore                                |
| readonly              | true                                    |
| git_url               | https://github.com/XX/certificates |
| app_identifier        | xx.xx.xx                    |
| username              |<EMAIL_ADDRESS>                  |
| git_branch            | master                                  |
| keychain_name         | login.keychain                          |
| team_id               | XXX                              |
| verbose               | false                                   |
| force                 | false                                   |
| shallow_clone         | false                                   |
| force_for_new_devices | false                                   |
| skip_docs             | false                                   |
+-----------------------+-----------------------------------------+
[10:50:00]: Cloning remote git repo...
[10:50:03]:   Successfully decrypted certificates repo
[10:50:03]: Installing certificate...
security: SecKeychainSearchCopyNext: The specified item could not be found in the keychain.
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1062  100  1062    0     0    759      0  0:00:01  0:00:01 --:--:--   758
[10:50:05]: There are no local code signing identities found. You can run `security find-identity -v -p codesigning` to get this output. This Stack Overflow thread has more information: http://stackoverflow.com/q/35390072/774. (Check in Keychain Access for an expired WWDR certificate: http://stackoverflow.com/a/35409835/774 has more info.)

...

[10:50:13]: ▸ Building Pods/Alamofire [Release]
[10:50:13]: ▸ Check Dependencies
[10:50:13]: ▸ ❌  Code Sign error: No code signing identities found: No valid signing identities (i.e. certificate and private key pair) were found.

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
lane :beta do
    match(type: "appstore", readonly: true)
    gym(
      sdk: "iphoneos9.3",
      clean: true,
      include_bitcode: true,
      include_symbols: true,
      scheme: "XX"
    )
    changelog = sh("git log --graph --pretty=format:'%h -%d %s <%an>' --abbrev-commit #{ENV['GIT_PREVIOUS_SUCCESSFUL_COMMIT'] || 'HEAD^^^^^'}..HEAD")

    pilot(
      changelog: "#{changelog.to_s}"
    )
  end

Environment
Fastlane latest on Travis CI

[10:50:13]: ▸ ❌  Code Sign error: No code signing identities found: No valid signing identities (i.e. certificate and private key pair) were found.

This is not related to the WWDR certificate. Please follow the code signing guide, posted by the bot :+1:

I've done all that. The cocoa pods are set to "don't code sign", is that the issue? Project settings are all correct, went through multiple times.

I've tried pretty much everything now, switching between Xcode Beta 8 and 7.3, code signing the cocoa pods and not signing them, setting everything to Automatic (as described for Match), nuked everything for 5 times now and nothing works, I'm always getting the same message:
[11:42:09]:   Successfully decrypted certificates repo
[11:42:09]: Installing certificate...
security: SecKeychainSearchCopyNext: The specified item could not be found in the keychain.
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1062  100  1062    0     0   1282      0 --:--:-- --:--:-- --:--:--  1282
[11:42:11]: There are no local code signing identities found. You can run `security find-identity -v -p codesigning` to get this output. This Stack Overflow thread has more information: http://stackoverflow.com/q/35390072/774. (Check in Keychain Access for an expired WWDR certificate: http://stackoverflow.com/a/35409835/774 has more info.)
[11:42:11]: Installing provisioning profile...


Make cases/tests fall back to using PHE API

Tests/cases in the PHE API come from the DoH daily data, so no value in doing this


Consider splitting up CLI functionality and/or cutting down on dependencies

Which problem is this feature request solving?
We are using netlify-lambda for Preact's docs and only today did I realize that it has long since been deprecated in favor for netlify-cli. However, upon installing netlify-cli and fixing up the commands, I saw this adds ~1300-odd packages and about 300MB to node_modules (40% of that project's total with this installed, for reference).
This is unfortunately a complete non-starter for that project, way to much of a size increase for such minimal functionality we need. This has a huge negative impact on contributors' and CI time, so we're stuck with netlify-lambda or migrating to our own tooling for serving & building the functions we need.
Describe the solution you'd like
Would love to see some time and attention paid to dependency use and/or cutting the CLI up by feature. I don't imagine many users are fully utilizing the full suite of functionality that this offers all at once, splitting up the CLI (or distributing parts of the CLI separately in addition to what already exists) could be a compelling option.
Pull request (optional)

[ ] I can submit a pull request.

I wanted to use netlify-cli to deploy my doc pages, but then my yarn.lock almost tripled in size. So nope, I gonna implement the deploy API myself.
Which is a shame because splitting this package would even propably ease the maintainance for Netlify teams.

I ended up doing something similar for us: we reduced Netlify usage in general & reimplemented the functionality we still needed via other methods. We simply could not justify adding this massive, massive CLI for the limited functionality that we needed.


feat: add the ability to set specific images via ZeebeClusterBuilder

Description
I've added the convenience methods to set a docker image for the Zeebe container in the cluster.
Related issues

closes #139
Pull Request Checklist

[X] All commit messages match our commit message guidelines
[X] The submitting code follows our code style
[X] If submitting code, please run mvn clean install -DskipTests locally before committing
[ ] Ensure all PR checks are green

Hey @npepinpe! I see that you are the main contributor to this project, can you start workflows? :)

Hey @npepinpe. Can you take another look?


Piping in location

Thanks for this very useful code. Nicely done.
Question: how would I pipe in a text response from a previous Qualtrics question as a parameter for the location shown in the initial map? For example, in an earlier question, I ask respondents to provide their city (or zip code). I would like to use that city name provided by the respondent as input for the autocomplete box in your java script (as a place for the respondent to start on the Google map). Then I can ask the respondent to drop the pin in a more specific place within their city.
Thanks.

While I can see this being useful, more advanced usage of the Qualtrics API is outside the scope of this project. Here is a similar use case on Qualtrics that may be of help. I am closing this issue for now.


Changed logs mappings to be logs-elb

Description
Changes log mapping file names to avoid conflict with other log index patterns
Issues Resolved
#812
Backport comments
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

If #818 goes through this change shouldn't be necessary


Support for /etc/X11/Sessions, /usr/share/xsessions and /usr/share/wayland-sessions

As posted out on Reddit, the /etc/X11/Sessions is a default location for X11 xinit scripts. This should probably also be used as a source location.

After some bugfixes, I will have a look at this as the first feature to add again

That code snippet may help with reading exists xsessions.
use std::fs::read_dir;
use freedesktop_entry_parser::parse_entry;

pub fn search()  {

        let paths = read_dir("/usr/share/xsessions").unwrap();
        for path in paths {
            let session_path = path.unwrap().path();
            println!("Name: {}", session_path.display());
            let entry = parse_entry(session_path).unwrap();
            let name = entry
                .section("Desktop Entry")
                .attr("Name")
                .unwrap();
            let cmd = entry
                .section("Desktop Entry")
                .attr("Exec")
                .unwrap();
            println!("{} -> {:?}", name, cmd);
}

Thank you.
I did look into this. There are two rust crates for parsing Desktop Entries and both use a license incompatible with this project. I wrote a parsing library that I’ll probably end up using.


Pino Signature Changes More Breaking than Indicated in Changelog

In https://github.com/probot/probot/releases/tag/v10.0.0 the breaking changes mention that pino is the logger now, but I worry that maybe it needs to go into a bit more depth on the change, and how that will break your logs.
In bunyan you could have an object before or after text and bunyan would log them all out, like so: context.log.info('we had an error', err, {an: 'object'}) but in pino the "merge object" must come first and there can only be one of them.
Users must update their logs to use child loggers and/or move the merge object to the beginning of the call to have all the context they had in their logs before.
This feels like a reasonable caveat for moving to 10x (though it may be a large amount of work) but I think it definitely needs a large callout in the breaking changes section.
Thanks!

Thanks a lot for bringing that up, I was not aware that bunyan supported passing extra information as last argument.
I added an entry to the v10 changelogs. Does that look good to you?

I think we are good. If anything we can improve the docs


How to apply it on the custom dataset?

Hi, thank you for your great work,
I want to try this on custom dataset, do you have any suggestions on this?
Thanks

Thanks for your interest! See #39.


P2P car rental data model

This PR introduces a renting related data model, p2p car rental. It's developed in co-operation with Shareit Bloxcar Oy. The aim is to provide basic datamodel, which can be modified as needed.

why don't you just use the VehicleModel data model (proposing an extension) to capture the static properties of your vehicle and just define an Entity type named P2PCarRental with the specific renting needs?

why don't you just use the VehicleModel data model (proposing an extension) to capture the static properties of your vehicle and just define an Entity type named P2PCarRental with the specific renting needs?

Ok, sounds like a plan. How do you see the use of "id"? now the rental datamodel has an "id" and then the VehicleModel specifies "id" as mandatory. Should we use same ID for both, like "Rental-car-8f7ewf88ejjnf993jfU83HDJ" ?

how do I reference this schema: https://github.com/FIWARE/dataModels/blob/master/specs/Transportation/Vehicle/VehicleModel/schema.json from my json schema?

I don't understand how this: https://github.com/FIWARE/dataModels/blob/master/specs/Transportation/Vehicle/Vehicle/schema.json and this: https://github.com/FIWARE/dataModels/blob/master/specs/Transportation/Vehicle/VehicleModel/schema.json
play together

be careful, I'm talking about adding extra properties to VehicleModel not to create another VehicleModel schema.
They don't play together they are a different kind of Entity. From Vehicle you point to a Vehicle Model.

be careful, I'm talking about adding extra properties to VehicleModel not to create another VehicleModel schema.
They don't play together they are a different kind of Entity. From Vehicle you point to a Vehicle Model.

Ok, got it. I'll get started so that I just include the current VehicleModel properties and then propose new ones bit later once I get this one sorted.
I notice that you do point from Vehicle to VehicleModel, but I dont understand how (this is my 1st data model, please be patient), since the ref seems to be like this:
"refVehicleModel": {"$ref": "https://fiware.github.io/dataModels/common-schema.json#/definitions/EntityIdentifierType" }
Is this meaning that in this case it points to a particular existing instance on VehicleModel?

build broken
https://travis-ci.org/FIWARE/dataModels/jobs/515171826

"refVehicleModel": {"$ref": "https://fiware.github.io/dataModels/common-schema.json#/definitions/EntityIdentifierType" }
Is this meaning that in this case it points to a particular existing instance on VehicleModel?

Yes it is. Essentially you are going to have an Entity of type FleetVehicle, category carRental, that is going to have a refVehicleModel pointing to a VehicleModel instance.
So, the approach is, make a PR that extends the VehicleModel data model. Then, make another PR that creates the FleetVehicle data model.
So, you are far from the solution, yet :)

build is broken and feedback has not been taken into account, please check all comments again

build broken
https://travis-ci.org/FIWARE/dataModels/jobs/515171826

fix pushes, will hopefully resolve

"refVehicleModel": {"$ref": "https://fiware.github.io/dataModels/common-schema.json#/definitions/EntityIdentifierType" }
Is this meaning that in this case it points to a particular existing instance on VehicleModel?

Yes it is. Essentially you are going to have an Entity of type FleetVehicle, category carRental, that is going to have a refVehicleModel pointing to a VehicleModel instance.
So, the approach is, make a PR that extends the VehicleModel data model. Then, make another PR that creates the FleetVehicle data model.
So, you are far from the solution, yet :)

I think we have some fundamental misunderstanding here. Question: Are all NGSI datamodels designed to work with Context Broker and only context broker?

What I'm trying to also judge here is that there is an existing API producing JSON very close to the one model I initially created. Now if I try to reuse existing NGSI datamodel pieces, (Vehicle, VehicleModel) I need to rethink the whole model, as the existing API relates to renting and the fact that the object for rent happens to be a vehicle is coincidence. That is the reason I created new "Renting" section.
Is the fundamental NGSI philosophy that datamodel contributors should reuse as much existing datamodels as possible? What I mean here is that from effort perspective if there is an existing API producing JSON it is very easy to drop it to a tool and the tool spits out a matching schema. If the datamodel needs to be constructed from pieces of existing datamodels, the effort increases.

Is the fundamental NGSI philosophy that datamodel contributors should reuse as much existing datamodels as possible?

Yes, it is, we want coherency, we are welcoming a lot new contributions but they shall be aligned

What I mean here is that from effort perspective if there is an existing API producing JSON it is very easy to drop it to a tool and the tool spits out a matching schema. If the datamodel needs to be constructed from pieces of existing datamodels, the effort increases.

Yes, but also your visibility and the reuse and impact of your work ...

I'm planning on closing this pull request. Requirements have changed and I don't feel that this makes sense, as it looks like we do not have an active data source for this. @jmcanterafonseca if you still see value in this, I can proceed with this, but otherwise I'd close it.

You can close. Thanks
El martes, 18 de junio de 2019, ilarimikkonen<EMAIL_ADDRESS>escribió:

I'm planning on closing this pull request. Requirements have changed and I
don't feel that this makes sense, as it looks like we do not have an active
data source for this. @jmcanterafonseca
https://github.com/jmcanterafonseca if you still see value in this, I
can proceed with this, but otherwise I'd close it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FIWARE/dataModels/pull/391?email_source=notifications&email_token=AAFJT7VFEIFSCLAEOVLOBO3P3CHWBA5CNFSM4G74GPSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX5QJ6Y#issuecomment-502990075,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFJT7XXM7VWOBV3THPZDMDP3CHWBANCNFSM4G74GPSA
.


Organisation not loaded

HI, my organisation is not loaded, so i'm not able to create a new project
AB#3630

Hi @sen0204  thank you for reaching us.
You might be logged in with different directory than the organization directory. This doc might help you


Distinguish 'serialised' from 'raw' events

Fixes #3305
Fixes #3380
The idea here is to better distinguish between a 'raw' event (as we send over the wire), and the 'serialised' format, as sent in responses to the C-S api and in PUT /_matrix/app/v1/transactions/{txnId}.
It's made more complicated by the fact that there are two serialisation formats, one used by /sync and /notifications, and one by everything else (the difference being whether room_id is included).
In an ideal world, we wouldn't repeat SerialisedEvent every time it's used, and instead just link to the first reference, bit that's a job for another day.

looks like I need to figure out why the validator is failing.


CocoaLumberjack with Carthage

I am trying to install CocoaLumberjack with carthage but unable to build.
Facing some exception on terminal..
*** Fetching CocoaLumberjack
*** Checking out CocoaLumberjack at "2.3.0"
*** xcodebuild output can be found in /var/folders/xs/vjmbpvfd7l33lc7zn3pm030w0000gn/T/carthage-xcodebuild.ymfG4X.log
*** Building scheme "CocoaLumberjackSwift" in Lumberjack.xcworkspace
** BUILD FAILED **
The following build commands failed:
CompileSwift normal arm64 /Downloads/Starter-Swift2/Carthage/Checkouts/CocoaLumberjack/Classes/CocoaLumberjack.swift
CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler
(2 failures)
/Downloads/Starter-Swift2/Carthage/Checkouts/CocoaLumberjack/Classes/CocoaLumberjack.swift:58:128: error: expected initial value after '='
/Downloads/Starter-Swift2/Carthage/Checkouts/CocoaLumberjack/Classes/CocoaLumberjack.swift:58:214: error: expected ',' separator

Please make a search and this https://github.com/CocoaLumberjack/CocoaLumberjack/issues/608#issuecomment-200599251.
I think we should also modify the README to state that people shouldn't rely on precompiled binaries, no only for this library but for any library with Swift code in it.

@umeshjavastar Please note the latest version of Lumberjack requires Xcode 7.3 Do you have this version?

At that time I am not using xcode 7.3 but now I am using..Thanks


Add entity_in_radius entity condition type

This PR adds an entity_in_radius entity condition type, which checks whether there's a specified number of entities that fulfill the specified bi-entity condition within the radius of an area relative to the entity's feet. It accepts these fields:

[!NOTE]
In the context of this entity condition type, the 'actor' is the entity while the 'target' are the entities within the radius of the specified area.

Field
Type
Default
Description

bientity_condition
Bi-entity Condition Type

The bi-entity condition to evaluate on either or both the 'actor' and 'target(s)'

shape
Shape
"cube"
Determines the shape of the area used for checking how many entities fulfill the bi-entity condition. Accepts "cube", "star", or "sphere".

radius
Float

Determines the radius of the area used for checking how many entities fulfill the bi-entity condition.

comparison
Comparison
">="
Determines how the amount of entities that fulfill the bi-entity condition should be compared to a specific value.

compare_to
Integer
1
The value at which the amount of entities that fulfill the bi-entity condition will be compared to.

Nice!


Making current zookeeper nodes hostname configurable & basic jenkins test

Description
This change makes the current zk node's hostname configurable
This means zk is listening on all interfaces, there were /etc/hosts issues on some debian vms, they should set to <IP_ADDRESS>
Also updating the jenkinsfile to run molecule test
Fixes # (issue)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Tested with a 55 molecule scenario, everything came up
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

@JumaX
I've recently noticed that node with <IP_ADDRESS>:2888:3888 can't survive restart
Right after restart, systemd services looks fine and shows running status, but it is impossible to connect to the node and zookeeper-server.log shows:

[2020-05-11 17:04:18,529] WARN Exception causing close of session 0x0: ZooKeeperServer not running (org.apache.zookeeper.server.NIOServerCnxn)
[2020-05-11 17:04:19,545] WARN Exception causing close of session 0x0: ZooKeeperServer not running (org.apache.zookeeper.server.NIOServerCnxn)
[2020-05-11 17:04:19,702] WARN Exception causing close of session 0x0: ZooKeeperServer not running (org.apache.zookeeper.server.NIOServerCnxn)

[2020-05-11 17:06:13,654] WARN Exception causing close of session 0x0: ZooKeeperServer not running (org.apache.zookeeper.server.NIOServerCnxn)
[2020-05-11 17:06:13,750] WARN Exception causing close of session 0x0: ZooKeeperServer not running (org.apache.zookeeper.server.NIOServerCnxn)
[2020-05-11 17:06:15,480] WARN Exception causing close of session 0x0: ZooKeeperServer not running (org.apache.zookeeper.server.NIOServerCnxn)
[2020-05-11 17:06:15,614] WARN Exception causing close of session 0x0: ZooKeeperServer not running (org.apache.zookeeper.server.NIOServerCnxn)

Changing <IP_ADDRESS>:2888:3888  to nodeip:2888:3888 fixes issue immediately.
My current verson is  5.4.1-1
Please confirm the issue and revert this PR ASAP, before anyone's production get hurt.

@AntonSmolkov Can you open a new issue for this please and provide logs from Zookeeper from just before a restart, until after when you hit the problem? This may actually be a bug in Zookeeper itself, so will need to see the logs to confirm the details.


EventGrid Management SDK Samples

Are there samples somewhere on how to properly use the EventGrid Management SDK? Especially the authentication doesn't seem to be as straight forward as the EventGrid data plane SDK.

We have multiple samples for both control and data planes. Here is list:

.NET SDK Samples: https://github.com/Azure-Samples/event-grid-dotnet-publish-consume-events
and here is a list of all .NET Sample for Event Grid: https://github.com/Azure-Samples?utf8=✓&q=event-grid&type=&language=c%23

Here is a full list of all languages:
https://github.com/Azure-Samples?utf8=✓&q=event-grid&type=&language=

@tobiasb, We are closing this issue, but feel free to reopen it if you feel that the documentation provided does not address all of your concerns.

@ahamad-MS, I've looked into the https://github.com/Azure-Samples/event-grid-dotnet-publish-consume-events and it appears to be outdated (both the client and the management packages). Is it no longer maintained?
Raised an issue about it, https://github.com/Azure/azure-sdk-for-net/issues/12246


Add Merkle tree capabilities

CC: @sbillinge I think this will allow us to check if two pipelines are the same by checking the merkle_hash for the pipeline. Additionally each pipeline is hashed via sha256 to give a unique ID to that pipeline. One could then see if those two hashes were the same if both pipelines already existed in the database.

pending pragma: no cover

Codecov Report

Merging #183 into master will decrease coverage by 0.23%.
The diff coverage is 91.48%.

@@            Coverage Diff            @@
##           master    #183      +/-   ##
=========================================
- Coverage   94.53%   94.3%   -0.24%
=========================================
  Files          14      14
  Lines        1776    1914     +138
  Branches      313     339      +26
=========================================
+ Hits         1679    1805     +126
- Misses         58      64       +6
- Partials       39      45       +6

Impacted Files
Coverage Δ

shed/simple_parallel.py
86.95% <ø> (ø)
:arrow_up:

shed/tests/test_simple.py
99.25% <100%> (+0.01%)
:arrow_up:

shed/tests/test_translation.py
99.59% <100%> (+0.11%)
:arrow_up:

shed/translation_parallel.py
86.04% <53.84%> (-13.96%)
:arrow_down:

shed/simple.py
92.15% <80%> (-0.63%)
:arrow_down:

shed/translation.py
92.17% <92.72%> (+0.24%)
:arrow_up:

shed/tests/test_replay.py
98.91% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fc6acc...e42ece5. Read the comment docs.


✨ bring back query tests for node 21

@jonchurch

These appveyor and coverage reports are intermittently broken so often now. Should we just remove then until we can land that other @jonchurch PR to migrate off it? Is it helpful if it is failing for no reason so often?

These appveyor and coverage reports are intermittently broken so often now. Should we just remove then until we can land that other @jonchurch PR to migrate off it? Is it helpful if it is failing for no reason so often?

If they're unreliable, perhaps at least remove them from the required status checks?  Then they can still run but won't block merge.  Although then commits/PRs might still not get the green check mark still, which is annoying.

I would not be opposed to making that change, can we do that in code or is it only done in the config?

I should have checked the setting before sending that. I just looked and do not see a setting to exclude an action run from the required checks. I also did a bit of searching and dont see a clear way to run a job but not make it required.

checks are configured to run via workflows.  the requirement for them to merge PRs is done through repo settings / branch protection

Ah, they are hidden! Thanks of for the tip, I just removed these from the branch protection rules. We should be able to merge in the UI without the override now.

Hmm, I merged this preemptively.
it looks like this still fails on latest 21, which is 21.7.3 currently.
it passes in our CI because we are using 21.6 @ctcpip

why do we pin the versions in CI?


Cannot create click event when three_js used with web application

Hi @madhankumar-ch,
Could you please provide a description.
Thank you


Allowed networks set to wrong IP range by default

Hi,
I've used this dockerfile for a while but recently I had to rebuild it. I also did not have any config prepared. The default config (in Preferences.xml) was set to allowednetworks="<IP_ADDRESS>/16" which was the ip of the docker0 interface but meant that I couldn't configure the server from the web interface and the  container was running on the headless server. I then configured Preferences.xml so that allowednetworks="<IP_ADDRESS>/16" (I also changed PublishServerOnPlexOnlineLineKey="0") and it worked fine. Should the default configuration be this or should some instructions be provided so that people don't have to figure this out? (Or have I made an error following the instructions?)

Hello adampolar,
does this happen with the most recent version?
#45
bb1390dcc8f23d7169e5bad71bae2390e16ecf33

Hi vvhof,
I just pulled the latest from the master branch, f5421 is what I built from. I did not supply the PLEX_ALLOWED_NETWORKS environment variable. Is this now mandatory?

It shouldn't be mandatory under most scenarios:

If you are accessing the container IP from the host, then you should be communicating with it using the bridge interface on the host to communicate with the container which is inside of the default value for allowedNetworks
If you use port forwarding then by default, your source IP is masqueraded to the host machine's IP within the docker bridge which will be accepted by the container's default value for allowedNetworks - same as above
If you are using --net=host it will add all non-default routes (and hence all local subnets) to the allowedNetworks attribute.

How are you trying to access the container? Do you have ip_masq=false or iptables=false set on your docker daemon?
Unless there is an unforeseen issue in one of the cases above it should be working.

Hi flungo,
I'm accessing the container from a remote machine, as it's a headless server. I am using the '-p' port forwarding switch in the run command. I haven't set those flags. My relevant iptables output is as follows;
In my postrouting chain
MASQUERADE  all  --  <IP_ADDRESS>/16        <IP_ADDRESS>/0
MASQUERADE  tcp  --  <IP_ADDRESS>           <IP_ADDRESS>           tcp dpt:32400
And in my docker chain
DNAT       tcp  --  <IP_ADDRESS>/0            <IP_ADDRESS>/0            tcp dpt:32400 to:<IP_ADDRESS>:32400
I haven't really got any special configuration on the box this is on, be it iptables (to be honest I don't know iptables very well at all, I usually use ufw for configuring my firewall rules) or the docker daemon.

Okay, so that does make sense and is correct. DSTNAT won't change the source so from an external PC the default won't allow access (except where using --net=host). In the case of using port forwarding, this matches the default plex configuration (which is localhost only) - but this does bring up two other points for consideration:

A SKIP_PREFERENCES_CONFIG which will allow people to stop any changes being made to Preferences.xml if they wish to manually configure and not have anything overridden automatically at startup. Possibly even a SKIP_X for each individual preference that would otherwise automatically be detected.
Should we match the default configuration exactly such that if --net=host is used, it locks back down to <IP_ADDRESS>/8 so that it is not exposed to the rest of the network unless requested. If so, how do you detect --net=host: initial thought is to use ethtool to detect if there is peer_ifindex on any interface.

In response to the issue here, I would say that in this scenario you will need to set PLEX_ALLOWED_NETWORKS and that this is in-line with the default configuration with Plex running in a normal environment.

@adampolar Are you happy with this behavior and that it actually matches the behavior of the plex distribution?
If so I will look into implementing the two other suggestions I made and see what the other developers think as well as checking that the documentation matches this behaviour.

Hi flungo, sorry for not replying. I've never used Plex outside of this docker container so I didn't realise that this is the usual behaviour of Plex, my personal feeling is that could be useful in the "instructions to run" section, but that's just my opinion and if the typical user already knows Plex behaves like this it may be obvious to them. Happy to close if you are.

@adampolar No worries. I will check the documentation when I get a chance, and see if it can be made any clearer and close this issue with any changes made there. Thanks for the feedback.


vscode insiders cmd+mouse left click cannot work, and vscode works

VSCode Version: Code - Insiders 1.18.0-insider (de68b077b53d6eeafeaf39699d6384c4b8750a19, 2017-10-16T05:11:43.411Z)
OS Version: Darwin x64 16.7.0
Extensions:

Extension
Author (truncated)
Version

solidity
Jua
0.0.29

vscode-docker
Pet
0.0.19

solidity-extended
bea
3.0.2

path-intellisense
chr
1.4.2

githistory
don
0.2.3

python
don
0.7.0

pgsql
dou
0.0.8

code-runner
for
0.7.3

docker-linter
hen
0.4.0

rest-client
hum
0.15.3

Go
luk
0.6.66

azure-account
ms-
0.1.3

vscode-icons
rob
7.15.0

vscode-uppercase
rui
1.0.1

markdown-preview-enhanced
shd
0.2.9

gitblame
wad
2.2.0

vscode-todo-highlight
way
0.5.11

markdown-pdf
yza
0.1.7

(1 theme extensions excluded)

cmd+mouse left click  --->> go to definition

What language are you working in? Does it still happen if you disable extensions?

@mjbvz  Thank You.
settings.json  Comment out this line can work properly.
// "editor.multiCursorModifier": "ctrlCmd",


Add valid certificates generated from Let's Encrypt on vSphere

As a vSphere user and administrator, I want to access the vSphere UI and API with widely trusted certificates (i.e. not obtaining/trust a CA first) so that the system can be used and managed by any authorized users without forcing Trust On First Use behavior that adds friction to the user experience.
*It is difficult to add third-party signed certificates to VCSA.  There seems to be some unresolved issue with the certificate chains causing the certs to fail to be rolled over properly when the machine cert is provided and the certificate chain of intermediate and root CA is provided for the signing key.

When the initial self-signed certificate is replaced, the process will fail if there is not a common Subject Alternative Name (SAN) on the self-signed certificate and the third-party signed certificate.  This makes it difficult to initially provision VCSA with an IP hostname and later add DNS support.
ESXi seem to replace it's certificate with certificates issued by vSphere when joined to the system.  This behavior causes the ESXi to overwrite issued valid Let's Encrypt signed certificates with self-signed certificates issues by the VCSA.
VCSA does not trust the root certificate of Let's Encrypt implicitly.  Among other things, this means the machine certificate for VCSA that would present the end user with valid certs cannot be rotated to a Let's Encrypt certificate until the root CA for Let's Encrypt has been trusted.  A code sample of how to accomplish this is listed below.

#Trust the certificate
/usr/lib/vmware-vmafd/bin/dir-cli trustedcert publish --chain --cert /root/DARootCAX3.pem

Automating the certificate rotation on a newly deployed system is difficult to do via the CLI because you are not initially presented with a bash shell.  Rather, you are presented with a shell that allows you to select a shell and must change the shell after logging in.  This also prevents utilities such as SCP from functioning as intended as they require shell functionality that the default VCSA shell does not provide

#Enter bash shell
shell

#Reset shell to root
chsh -s /bin/bash root

The only automatable way to change the VCSA machine certificate seems to be a TUI provided by /usr/lib/vmware-vmca/bin/certificate-manager.  This would require use of a tool such as pexpect to automate answers.
Allowing default self-signed certificates requires not only the vSphere UI to be trusted, but also the ESXi UI to be trusted as things like datastore uploads via the GUI will fail due to trust issues otherwise.

Some potential solutions:

Run a reverse proxy that trust the certificate authority managed by VCSA.  VCSA seems to want to own the certificate process not only for itself, but also for ESXi hosts that it manages.  This means that even rotating the certificate on the VCSA server would require additional effort to maintain the ESXi host certificates properly.  Given that we can expect entire systems (ESXi + vSphere) to regularly be created and die for the purposes of hosting infrastructure that is cleanly provisioned from code end to end, a widely trusted certificate on the proxy (such as one from Let's Encrypt) could be used to proxy with reencryption to the actual endpoint via a certificate that the proxy and VCSA/ESXi hosts share trust on.  This would require automating the proxy and the hosts, but not all the clients.

In general, this seems be a thorny problem for a fairly simple end user experience desire.

Initial research into this problem seemed to indicate that the best option available was to access the shell in order to perform this operation.  However, it looks like vSphere 7 introduces some new API options that MAY be available in vSphere 6.7 (which is a very common infrastructure target).  https://blogs.vmware.com/vsphere/2020/04/vsphere-7-certificate-management.html
Variations of the CLI technique popped up a lot in blog posts about Let's Encrypt and vSphere: https://blog.krogloth.de/vmware-vcenter-vcsa-ssl-certificates-using-lets-encrypt/ but may (hopefully!) will not be the most reliable option.


Enhancements to website

 I added a hovering effect to the icons so that when a user hovers over them, they change color or become slightly larger to indicate that they can be clicked on. I also added a similar effect to the navbar options so that when a user hovers over them, they become highlighted to indicate which page they will be taken to.
 To improve the user experience, I suggest adding target="_blank" to the links on the website. This would enable users to open links in a new tab with ease, and ensure that the original page remains accessible.
 I also added 'Handbook' button on the mobile view of website.
Improvements are shown in following clip:
@Mr-Sunglasses @akshatcoder-hash   Sir, I solved this..if you need any more changes please mention it.
Screencast from 05-05-2023 02_14_34 AM (3).webm
Screencast from 05-05-2023 02_20_05 AM (2).webm

#165
Thx @anshika0987


Solflare signAndSendTransaction

Implemented sendTransaction in the Solflare adapter using the signAndSendTransaction extension method.

I committed the other fixes, but the type fix to the SDK will need to be made upstream first.


fix small typos in readme (javascrip to javascript, etc)

Awesome! Thanks for letting me contribute.


Map dot key

@secondsun @danielpassos this fix uses the class to see if the field exists when separating on '.' when not it concatenates the string and uses the entire thing as a property. WDYT?

👍  nice, also the android.text.TextUtils usage, @edewit

👍

relate to AGDROID-564


fix #591 add explicit return type for mutationKey in useSignTypedData

Description
This fixes the reference to source files in the production bundle (#591). I don't know the reason for the problem, but this seems to fix it. I also tried to update babel, babel presets, and typescript compiler, but it didn't help
Additional Information

[x] I read the contributing docs (if this is your first contribution)

Your ENS/address: 0xbc2BB26a6d821e69A38016f3858561a1D80d4182

Closing in favor of https://github.com/tmm/wagmi/pull/596

thanks ser


Cuda sources (CriterionUtils.cu,...) compilation failure

Bug Description
Cuda sources (CriterionUtils.cu,...) compilation failure
Reproduction Steps

git pull the very master as today specially the upgrade to cmake 3.10 f5f84c464e63db83ed1bc876c968791bc9c5b20d
cmake with 3.12+
make

Platform and Hardware
ubuntu 16, cuda 10.2
Additional Context
[ 12%] Building CUDA object CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu.o
/usr/local/cuda/bin/nvcc  -DFL_LIBRARIES_USE_CUDA -DFL_LIBRARIES_USE_KENLM -DKENLM_MAX_ORDER=6 -I/home/wtambellini/repos/flashlight -I/usr/include/openblas -I/home/wtambellini/repos/kenlm -I/home/wtambellini/repos/flashlight/release/CUB/src/CUB -I/usr/local/cuda/include   -x cu -c /home/wtambellini/repos/flashlight/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu -o CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu.o
/home/wtambellini/repos/flashlight/flashlight/lib/sequence/criterion/Defines.h(14): warning: scoped enumeration types are a C++11 feature
/home/wtambellini/repos/flashlight/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu(24): error: explicit type is missing ("int" assumed)

As you can see the std=c++11 is not set in the nvcc CLI.
It's because the cmake team has changed their mind several times about how to handle cuda.
Todays FL master is setting a global var in CUDAUtils.cmake:
function (set_cuda_cxx_compile_flags)
  set(CUDA_NVCC_FLAGS "${CUDA_NVCC_FLAGS};-std=c++11" PARENT_SCOPE)
  # Using host flags makes things bad - keep things clean
  set(CUDA_PROPAGATE_HOST_FLAGS OFF)
endfunction()

which does nt work anymore with 'recent' cmake.
The proper way to do is said to set target props:  adding
  target_compile_options(fl-libraries PRIVATE $<$<COMPILE_LANGUAGE:CUDA>:--std=c++11>)

seems to fix the error.
Refs:
https://forums.developer.nvidia.com/t/passing-flags-to-nvcc-via-cmake/75768/2

cc @jacobkahn could you add this fix in cmake or @WilliamTambellini feel free to send PR?

I cannot build for cmake 3.19.1. Context below
[build] make[3]: *** [third/flashlight/CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/ForceAlignmentCriterion.cu.o] Error 1
[build] nvcc fatal   : redefinition of argument 'std'

Delete --std=c++11 seems solveRef

@WilliamTambellini this is what I was talking about :)

Hum, I ve just tried and seems to build correctly with todays master and cmake 3.19:
[ 20%] Building CUDA object CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/ForceAlignmentCriterion.cu.o
/usr/local/cuda/bin/nvcc -forward-unknown-to-host-compiler -DFL_LIBRARIES_USE_CUDA -DFL_LIBRARIES_USE_KENLM -DKENLM_MAX_ORDER=6 -I/home/wtambellini/repos/flashlight -I/usr/include/openblas -I/home/wtambellini/repos/kenlm -I/home/wtambellini/repos/flashlight/release/CUB/src/CUB -I/usr/local/cuda/include -O3 -DNDEBUG --std=c++14 -Xcompiler -pthread -std=c++14 -x cu -c /home/wtambellini/repos/flashlight/flashlight/lib/sequence/criterion/cuda/ForceAlignmentCriterion.cu -o CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/ForceAlignmentCriterion.cu.o

The c++14 flag appears twice but nvcc (10.2) does not seem to care. Perhaps depends on the version of nvcc though.
Status with todays master:

CUDAUtils.cmake does set(CUDA_NVCC_FLAGS "${CUDA_NVCC_FLAGS};-std=c++11" PARENT_SCOPE)
fl lib cmakelists sets target_compile_options(fl-libraries PRIVATE $<$<COMPILE_LANGUAGE:CUDA>:--std=c++14>)

@jacobkahn I see at least these options:
1- I could simply remove the  target_compile_options(fl-libraries PRIVATE $<$<COMPILE_LANGUAGE:CUDA>:--std=c++14>) : only usefull for recent cmake, using cmake 3.10 just simpler. Supporting wide range of cmake versions in FL is anyway quite time consuming and perhaps not that worth it (at least for my usecase).
2- switching to target_compile_options(fl-libraries PRIVATE $<$<COMPILE_LANGUAGE:CUDA>:--std=c++11>), not 14. Safer.
3- I could retouch the CUDAUtils.cmake to upgrade to std to c++14 (not 11): could be usefull in the near futur but worry about old cuda (9 ?) support.
Your call,
W.

@WilliamTambellini I actually think the CUDA_NVCC_FLAGS approach should work fine — I've just found what I think it is the issue: this line was never changed! Testing now with a few different versions of CMake.

@jacobkahn apparently the issue was not because of 2 std c++ flags but indeed because of 2 conflictual std=c++ (11 and 14) in the same command line. Good to see you ve upgraded cuda compilation to std 14.
Though, master does nt compile anymore for me even with cmake 3.10 :
...
[  6%] Building CUDA object CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu.o
/usr/local/cuda/bin/nvcc  -DFL_LIBRARIES_USE_CUDA -DFL_LIBRARIES_USE_KENLM -DKENLM_MAX_ORDER=6 -I/home/wtambellini/repos/flashlight -I/usr/include/openblas -I/home/wtambellini/repos/kenlm -isystem=/usr/include -I/home/wtambellini/repos/flashlight/release/CUB/src/CUB -I/usr/local/cuda/include  -O3 -DNDEBUG   -x cu -c /home/wtambellini/repos/flashlight/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu -o CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu.o
/home/wtambellini/repos/flashlight/flashlight/lib/sequence/criterion/Defines.h(14): warning: scoped enumeration types are a C++11 feature
/home/wtambellini/repos/flashlight/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu(24): error: explicit type is missing ("int" assumed)
...
I ve added a message after the set:
set_cuda_cxx_compile_flags()
message(STATUS "CUDA_NVCC_FLAGS=${CUDA_NVCC_FLAGS}")
and I see that
CUDA_NVCC_FLAGS=;-std=c++14
at cmake init, but is probably reset/cleared later on as it does not appear in the final nvcc commandline.
Hum, I see that I m using cmake 3.10.0 vs 3.10.2 on ubuntu18. ReRe upgrading ...

@jacobkahn  apparently CUDA_NVCC_FLAGS does not seem to do anything anymore even in the FL circle CI jobs:
from
https://app.circleci.com/pipelines/github/facebookresearch/flashlight/755/workflows/c784063f-fe74-40f6-a963-273aeab68f41/jobs/1544/steps
see that there is no std c++ flag but (for some reasons) nvcc (10.0 ?) does not complain:
[ 16%] Building CUDA object CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu.o
/usr/local/cuda/bin/nvcc  -DFL_LIBRARIES_USE_CUDA -DFL_LIBRARIES_USE_KENLM -DFL_LIBRARIES_USE_MKL -DKENLM_MAX_ORDER=6 -I/flashlight -I/opt/intel/mkl/include -I/root/kenlm -I/flashlight/build/CUB/src/CUB -I/usr/local/cuda/include   -x cu -c /flashlight/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu -o CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu.o
[ 16%] Building CUDA object CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/ForceAlignmentCriterion.cu.o
/usr/local/cuda/bin/nvcc  -DFL_LIBRARIES_USE_CUDA -DFL_LIBRARIES_USE_KENLM -DFL_LIBRARIES_USE_MKL -DKENLM_MAX_ORDER=6 -I/flashlight -I/opt/intel/mkl/include -I/root/kenlm -I/flashlight/build/CUB/src/CUB -I/usr/local/cuda/include   -x cu -c /flashlight/flashlight/lib/sequence/criterion/cuda/ForceAlignmentCriterion.cu -o CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/ForceAlignmentCriterion.cu.o
On my side I cannot downgrade to cuda10.0 so as today I cannot compile FL master without
target_compile_options(fl-libraries PRIVATE $<$<COMPILE_LANGUAGE:CUDA>:--std=c++14>)
Kind
W.

@WilliamTambellini aha. That's some good investigation. Let's add that target_compile_options stuff back and kill everything related to CUDA_NVCC_FLAGS.
Seems like nvcc guesses or infers the C++ std to compile with pretty randomly... not great :). I'll send a fix.

Cool, tks. I guess/hope nvidia has good reasons to rely on the host compiler but for FL/AF, it s indeed safer to hard set the std in the cmake, not randomly relying on the local gcc. CU.

@WilliamTambellini I have a fix - turns out
set(CMAKE_CUDA_STANDARD 14)
set(CMAKE_CUDA_STANDARD_REQUIRED ON)

Is the right way to go.  Will send the commit shortly.

Hi @jacobkahn
I ve just repulled/rebased and it sadly still fails :) because no std cpp in the nvcc line:
/usr/local/cuda/bin/nvcc  -DFL_LIBRARIES_USE_CUDA -DFL_LIBRARIES_USE_KENLM -DKENLM_MAX_ORDER=6 -I/home/wtambellini/repos/flashlight -I/usr/include/openblas -I/home/wtambellini/repos/kenlm -I/home/wtambellini/repos/flashlight/release/CUB/src/CUB -I/usr/local/cuda/include  -O3 -DNDEBUG   -x cu -c /home/wtambellini/repos/flashlight/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu -o CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu.o
/home/wtambellini/repos/flashlight/flashlight/lib/sequence/criterion/Defines.h(14): warning: scoped enumeration types are a C++11 feature

But good news, I know why : seen in the cmake doc:
https://cmake.org/cmake/help/v3.10/prop_tgt/CUDA_STANDARD.html#prop_tgt:CUDA_STANDARD
set_property(TARGET tgt PROPERTY CUDA_STANDARD 11)
"This property is initialized by the value of the CMAKE_CUDA_STANDARD variable if it is set when a target is created."
In the fl lib CMakeLists, you create the lib
add_library(  fl-libraries
and then later (too late)
set(CMAKE_CUDA_STANDARD 14)
set(CMAKE_CUDA_STANDARD_REQUIRED ON)
I ve set these global vars at the top of the cmake file (before creating the target), and then it does work:
[ 17%] Building CUDA object CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu.o
/usr/local/cuda/bin/nvcc  -DFL_LIBRARIES_USE_CUDA -DFL_LIBRARIES_USE_KENLM -DKENLM_MAX_ORDER=6 -I/home/wtambellini/repos/flashlight -I/usr/include/openblas -I/home/wtambellini/repos/kenlm -I/home/wtambellini/repos/flashlight/release/CUB/src/CUB -I/usr/local/cuda/include  -O3 -DNDEBUG   -std=c++14 -x cu -c /home/wtambellini/repos/flashlight/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu -o CMakeFiles/fl-libraries.dir/flashlight/lib/sequence/criterion/cuda/CriterionUtils.cu.o
Conclusion: we just have to move these global var sets earlier. Would you like me to ?

@WilliamTambellini I have a commit right now doing this. Another good catch though! WE should do this before we do we do anything else at the configuration stage of the fl build.