You are referencing the Portable version of ReactiveUI in an App. Reference the platform-specific version.

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Android version of the app is crashing with "You are referencing the Portable version of ReactiveUI in an App. Reference the platform-specific version."
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
I'm referencing .netstandard2.0 projects from my pcl android xamarin project, this could be what is causing the issue.  I did not have this problem with reactiveui alpha.
What is the expected behavior?
For the xamarin android version to work just like how the ios xamarin version works without any issues.
What is the motivation / use case for changing the behavior?
N/A
Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and development snapshot
ReactiveUI 8.0(latest stable).
Other information (e.g. stacktraces, related issues, suggestions how to fix)
[MonoDroid] System.TypeInitializationException: The type initializer for 'SmartCap.UI.SplatRegistrar' threw an exception. ---> System.TypeInitializationException: The type initializer for 'ReactiveUI.RxApp' threw an exception. ---> System.Exception: You are referencing the Portable version of ReactiveUI in an App. Reference the platform-specific version.
[MonoDroid]   at ReactiveUI.PlatformRegistrations.Register (System.Action`2[T1,T2] registerFunction) [0x00000] in C:\projects\reactiveui\src\ReactiveUI\Platforms\netstandard2.0\PlatformRegistrations.cs:13
[MonoDroid]   at ReactiveUI.DependencyResolverMixins.InitializeReactiveUI (Splat.IMutableDependencyResolver resolver) [0x00041] in C:\projects\reactiveui\src\ReactiveUI\IDependencyResolver.cs:31
[MonoDroid]   at ReactiveUI.RxApp+<>c.<.cctor>b__0_0 () [0x00008] in C:\projects\reactiveui\src\ReactiveUI\RxApp.cs:51
[MonoDroid]   at Splat.Locator.RegisterResolverCallbackChanged (System.Action callback) [0x00039] in C:\projects\splat\src\Splat\ServiceLocation.cs:87
[MonoDroid]   at ReactiveUI.RxApp..cctor () [0x00006] in C:\projects\reactiveui\src\ReactiveUI\RxApp.cs:49 ```

Ok, so it turns out that I need to use the MonoAndroid8.0 framework not MonoAndroid7.1.  That is why it was referencing the netstandard2.0 dll instead of the MonoAndroid one.


using combined patterns for git-grep to improve performance

Unfortunately scan_history is extremely slow when scanning repositories with a lot of pattern matches. After investigating this issue we found out, that the handover of patterns to git-grep does not work as expected. The number of revisions with pattern matches and the number of patterns are affecting the performance negativly. This PR is a workaround for that problem.
The following script helps to setup an environment to run some performance tests.
#!/bin/bash
for i in {1..100}
do
  for j in {1..100}
  do
    head -c 1000 /dev/urandom | base64 > $j.txt
    git add $j.txt
    git commit -m "${i}-${j}" --no-verify
  done
done

for i in {1..100}
do
  git config --add secrets.patterns "[B-Z0-9]{20}"
done

We did a performance test with git secrets --scan-history before and after the changes included in this PR.
Before: 37m19.848s
After: 1m22.409s

Thanks!

Great, thanks.

Am 09.04.2016 um 00:29 schrieb Michael Dowling<EMAIL_ADDRESS>Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub


Compound keypath not working with sort function

Description: Sorting with a simple keypath (eg. 'name') works as expected; however, when trying to sort with a compound keypath (eg. 'name.first') sorting does not occur and no errors are thrown.
I've tried using name['first'], ractive.get('name.first') and ractive.get('name["first"]') but they (silently) kill the sort feature.
Versions affected:
0.8.1
Platforms affected:
macOS 10.12.1
• Chrome 54.0.2840.71 (64-bit)
• Firefox 32.0
• Safari 10.0.1
Reproduction: https://jsfiddle.net/speasley/kmf7f9L5/3/
Code:
HTML:

JS:
var xmen = [
{ name: 'Nightcrawler', realname: {last:'Wagner',first:'Kurt'},     power: 'Teleportation',    info: 'http://www.superherodb.com/Nightcrawler/10-107/' },
{ name: 'Cyclops',      realname: {last:'Summers',first:'Scott'},   power: 'Optic blast',      info: 'http://www.superherodb.com/Cyclops/10-50/' },
{ name: 'Rogue',        realname: {last:'Marie',first:'Anna'},      power: 'Absorbing powers', info: 'http://www.superherodb.com/Rogue/10-831/' },
{ name: 'Wolverine',    realname: {last:'Howlett',first:'James'},   power: 'Regeneration',     info: 'http://www.superherodb.com/Wolverine/10-161/' }
];
const r = window.r = new Ractive({
el: '#main',
template: '#template',
data: {
superheroes: xmen,
sort: function ( array, column ) {
array = array.slice(); // clone, so we don't modify the underlying data
  return array.sort( function ( a, b ) {
    return a[ column ] < b[ column ] ? -1 : 1;
  });
},
sortColumn: 'realname.first'

}
});

I have some deprecations to catch up on before this is looked at. I apologize for opening it prematurely.

Deprecations addressed. Issue ready for review. Thanks.

I think you may be getting lodash in your vanilla JS :smile:. JS property access doesn't deal with dotted keypaths, so if you switch to a function that returns the sort value, it works as expected: https://jsfiddle.net/kmf7f9L5/4/

Ahh, thank you.
Would the same logic not apply for setting the sort value dynamically? This fails, where column equals 'name.first':
this.set('sortColumn', function(i) {   return i.column; });;

That has the same problem as the original - JS doesn't handle . in properties, so foo['bar.baz'] gets the bar.bazproperty onfoorather than thebazproperty on thebarproperty offoo. Ractive does have a helper that makes this slightly easier than having to handle corner cases on splitting up keypaths yourself: Ractive.splitKeypath('some.dotted.path')which=== ['some','dotted','path']. From there you can use array reduce to read each successive property starting from the root value with pathArray.reduce( (a,c) => a && a[c], startPoint)`. Here's an updated fiddle that does just that: https://jsfiddle.net/kmf7f9L5/5/

That is a great solution and very helpful. Thank you.


Update 0.0.5

Improved type-safety
Improved demo
Remove unnecessary imports

Thanks! Will release this now


Log whether a pkcs11 library was found and if it was loadable.

Signed-off-by: Ying Li<EMAIL_ADDRESS>This unfortunately prints out every time any operation is done on the Yubikey, producing a lot of log output, but perhaps that is better because an operation might fail at any given time.
Current output if no Yubikey:
DEBU[0000] Failed to initialize PKCS11 environment: loaded library /usr/local/lib/libykcs11.dylib, but no HSM slots found
If there is a Yubikey:
DEBU[0000] Initialized PKCS11 library /usr/local/lib/libykcs11.dylib and started HSM session
Fixes #281.

I'm ok with the output for experimental. LGTM


Format support

Description
Fix https://github.com/Azure/autorest.csharp/issues/3384
Fix https://github.com/Azure/autorest.csharp/issues/3343
Fix https://github.com/Azure/autorest.csharp/issues/3340

Use typespec diagnostics for typespec compile issues in emitter
Support string format

Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

Thanks @ArcturusZhang  Do you mean we need to define an type alias, alias stringAndUndefined = string | undefined, and use this for every where we need to apply two types for a parameter?
Yes, if the occurrence of the combine of more types is high, we can do this refactor. for low occurrence, maybe we will not define such alias.

Thanks @ArcturusZhang Do you mean we need to define an type alias, alias stringAndUndefined = string | undefined, and use this for every where we need to apply two types for a parameter? Yes, if the occurrence of the combine of more types is high, we can do this refactor. for low occurrence, maybe we will not define such alias.

Well I mean that since we have quite a few methods that has this signature:
function doSomething(
 ...,
 type: Type,
 format: string | undefined,
 ...
)

and maybe we could have a type or interface like this:
interface FormattedType {
  type: Type,
  format: string | undefined
}

and those methods could be simplified to
function doSomething(
  ...,
  type: FormattedType,
  ...
)

and we could have a method to get this thing:
function getFormattedType(program: Program, type: Type)
{
return {type: type, format: getFormat(program, type)} as FormattedType;
}

I say this because I noticed the pattern when we are calling those method:
// on model.ts L387
getInputType(
    context,
    elementType,
    getFormat(program, elementType),
    models,
    enums
),
// on model.ts L401
KeyType: getInputType(
    context,
    key,
    getFormat(program, key),
    models,
    enums
),
ValueType: getInputType(
    context,
    value,
    getFormat(program, value),
    models,
    enums
),
// on model.ts L455
getInputType(
    context,
    dm,
    getFormat(program, dm),
    models,
    enums
);
// and more

FormattedType

I like this ideal. I will do this.

The code change in regen PR are expected.  @chunyu3,  please follow up with healthInsight team later to decide the right behaviour of the model change


Discrepancies between validation report and UI

Describe the problem
I'm noticing some cases where the validation report information shared through the API doesn't seem to match the actual validation report when I test it through gtfs-validator.org.
https://qa.mobilitydatabase.org/feeds/mdb-5
vs. https://gtfs-validator-results.mobilitydata.org/e988469b-3eed-40a2-b0fd-ded283a828a3/report.html
Proposed solution
We should investigate the reason for the discrepancy.
Alternatives you've considered
No response
Additional context
No response

In this case, the validation reports are not generated. It should be clear in the UI when there are no errors and when the validation reports are not "available".

@davidgamez I'd like to understand why this is happening as well - in this particular case, I don't see why we would've been unable to generate the validation report (e.g it's a real ZIP file).

@cka-y, did we generate all the reports in QA?

It seems the error in QA and DEV is due to the backend services of the validator. The same thing is happening with the validator's web UI: gtfs-validator-staging.mobilitydata.org

@cka-y, can you test the validation workflows as the gtfs web validator is fixed now? Thanks!

@davidgamez it is working now: https://qa.mobilitydatabase.org/feeds/mdb-5


Cyclic dependency in notebook model

This makes our product build fail.
Commented out bad code via https://github.com/microsoft/vscode/commit/0926b534553f3ff2f0cff0a741550a97df199706

Thanks for the quick turnaround!

Fixed via https://github.com/microsoft/vscode/commit/99f39de4af55c642908c4c7e19fb53ace5b58a09


UI: Add transportModeBackgroundColor function and adjust LegView background

#266  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on  Graphite


HBASE-24669 Logging of ppid should be consistent across all occurrences

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 50s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 23s
branch-2 passed

+1 :green_heart:
compile
0m 18s
branch-2 passed

+1 :green_heart:
shadedjars
5m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 17s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 47s
the patch passed

+1 :green_heart:
compile
0m 19s
the patch passed

+1 :green_heart:
javac
0m 19s
the patch passed

+1 :green_heart:
shadedjars
5m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  5s
hbase-procedure in the patch passed.

25m 44s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2017

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0e35c0cece8b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / f834919929

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/testReport/

Max. process+thread count
247 (vs. ulimit of 12500)

modules
C: hbase-procedure U: hbase-procedure

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 55s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
5m 10s
branch-2 passed

+1 :green_heart:
compile
0m 23s
branch-2 passed

+1 :green_heart:
shadedjars
6m 31s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 19s
hbase-procedure in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 38s
the patch passed

+1 :green_heart:
compile
0m 22s
the patch passed

+1 :green_heart:
javac
0m 22s
the patch passed

+1 :green_heart:
shadedjars
6m 35s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-procedure in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 58s
hbase-procedure in the patch passed.

29m 23s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2017

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 11fbfe2dbdc2 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / f834919929

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/testReport/

Max. process+thread count
219 (vs. ulimit of 12500)

modules
C: hbase-procedure U: hbase-procedure

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 21s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  1s
branch-2 passed

+1 :green_heart:
checkstyle
0m 14s
branch-2 passed

+1 :green_heart:
spotbugs
0m 33s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 35s
the patch passed

+1 :green_heart:
checkstyle
0m 13s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 40s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
0m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

31m 18s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2017

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux e031f3664a69 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / f834919929

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-procedure U: hbase-procedure

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 49s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 50s
branch-2 passed

+1 :green_heart:
compile
0m 18s
branch-2 passed

+1 :green_heart:
shadedjars
5m  3s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 19s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
compile
0m 19s
the patch passed

+1 :green_heart:
javac
0m 19s
the patch passed

+1 :green_heart:
shadedjars
5m  3s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 50s
hbase-procedure in the patch passed.

26m 30s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2017

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a27c4d229d31 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ff2951e672

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/2/testReport/

Max. process+thread count
373 (vs. ulimit of 12500)

modules
C: hbase-procedure U: hbase-procedure

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 48s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 28s
branch-2 passed

+1 :green_heart:
compile
0m 22s
branch-2 passed

+1 :green_heart:
shadedjars
6m  0s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 19s
hbase-procedure in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  5s
the patch passed

+1 :green_heart:
compile
0m 21s
the patch passed

+1 :green_heart:
javac
0m 21s
the patch passed

+1 :green_heart:
shadedjars
6m  3s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-procedure in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 44s
hbase-procedure in the patch passed.

29m 47s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2017

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 80a179694483 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ff2951e672

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/2/testReport/

Max. process+thread count
297 (vs. ulimit of 12500)

modules
C: hbase-procedure U: hbase-procedure

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m  3s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  0s
branch-2 passed

+1 :green_heart:
checkstyle
0m 15s
branch-2 passed

+1 :green_heart:
spotbugs
0m 32s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 29s
the patch passed

+1 :green_heart:
checkstyle
0m 13s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 33s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
0m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

36m 33s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2017

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux ea12a296a29f 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ff2951e672

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-procedure U: hbase-procedure

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 58s
branch-2 passed

+1 :green_heart:
checkstyle
0m 15s
branch-2 passed

+1 :green_heart:
spotbugs
0m 32s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
checkstyle
0m 13s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 17s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

29m 27s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2017

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 47ea8a338e05 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / a3567037c6

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-procedure U: hbase-procedure

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 17s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 39s
branch-2 passed

+1 :green_heart:
compile
0m 19s
branch-2 passed

+1 :green_heart:
shadedjars
5m 57s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 19s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
0m 23s
the patch passed

+1 :green_heart:
javac
0m 23s
the patch passed

+1 :green_heart:
shadedjars
6m 16s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 11s
hbase-procedure in the patch passed.

27m 58s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2017

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux af260a7ab87c 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / a3567037c6

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/testReport/

Max. process+thread count
241 (vs. ulimit of 12500)

modules
C: hbase-procedure U: hbase-procedure

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 15s
branch-2 passed

+1 :green_heart:
compile
0m 21s
branch-2 passed

+1 :green_heart:
shadedjars
5m 49s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-procedure in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 56s
the patch passed

+1 :green_heart:
compile
0m 20s
the patch passed

+1 :green_heart:
javac
0m 20s
the patch passed

+1 :green_heart:
shadedjars
5m 48s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-procedure in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 40s
hbase-procedure in the patch passed.

24m 21s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2017

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c2b851588342 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / a3567037c6

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/testReport/

Max. process+thread count
294 (vs. ulimit of 12500)

modules
C: hbase-procedure U: hbase-procedure

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2017/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

I tried to make a patch for master; it looks like the code there logs slightly differently and this patch does not apply.
@saintstack maybe your patch (or addendum) for HBASE-21078 hit master and branch-2 differently? I'd think this kind of thing would be in sync across branches. Maybe check something wasn't missed?
I think @nyl3532016 's patch here (nicely logging both the id of the final child and the identity of the parent) is worth having everywhere. Do you folks agree?

Nice one. +1 on bringing this to all branches.

I have submit a PR to backport HBASE-24669 on branch master.
would you help to review and merge the PR? @ndimiduk @virajjasani

Push manually to branch-2.3+
Removed the parens around pids since we don't have parens elsewhere. Not sure I like dropping the listing of the parent procedure but lets try it
Thanks for the patch @nyl3532016


Add setting to hide diagnostics received from open files that aren't open

For language servers that provide full-project diagnostics at eg. startup, (eg. the julia language server as reported in #67)
TODO:

[ ] verify this improves the experience
[ ] document setting

Does it mean that I can still see the diagonistics of the unopen files in the panel but the panel will not pop up automatically?

No, we'll need even more logic for that :)

Just to summarise: The desired behaviour is to preserve the auto-open-diagnostics behaviour but only when new diagnostics are received for opened files.
Seeing as we currently hold the panel open as long as there are diagnostics, this is a significant amount of logic to add for 1 language server's behaviour.
We can re-open this PR in the future, but for now I would like to focus on issues impacting more users.


fix: minimized warnings generated by macro expanded code

addressed warnings for:

unused container variables with nested decoding
no mutation to encode container variable for enums with internal tagging
unused encode container variable for enum cases without any associated variables to be encoded
availability warning for extensions of type that has @available attribute
unreachable catch clause for untagged enums with fallback case

One warning which results with macro @CodedAs(nil as String?) usage handling not working as expected and being discussed: https://forums.swift.org/t/discrepancy-between-swift-ast-explorer-and-swift-syntax/75103


can display image directly from file path not from uri ?

I got this exception:
UIL doesn't support scheme(protocol) by default [/storage/emulated/0/DCIM/test.jpg]. You should implement this support yourself (BaseImageDownloader.getStreamFromOtherSource(...))

"file:///mnt/sdcard/image.png"
ImageLoader.getInstance().displayImage("file://" + file.getAbsolutePath(),imageView);


⚠ Bofrost.es has degraded performance

In dc412d9, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1356 ms

Resolved: Bofrost.es performance has improved in 0930f26 after 7 minutes.


Added linger struct

Added linger struct like mentioned in #327
I looked up documentations on some platforms, and all look the same in the unix world. Additionally I've tested this with a local setup, building it against this pullrequest, and it works well.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Looks like this is defined the same everywhere, perhaps the definition could go in src/unix/mod.rs?

Fugg, I could have foreseen this^^
I looked for each SO_LINGER to have a linger struct with it, but I failed to recognize this is on each platform. Thanks for the hint! I'll change this as soon as I've got some time.
Thanks @alexcrichton for your patience and guidance through my rust learning experience, even though this are embarrassing problems that don't have anything to do with rust^^

Done the refactoring. Works with my test setup (on a cloud9 machine)

Awesome, and no worries!


feat(Stochastic): Add Histogram column like STOCHh_14_3_3

Emulated from MACD Histogram. Please proofread :)

Probably should change line 119:
    histogram.name = f"STOCHh{_props}"

to use the dynamic name instead like:
    histogram.name = f"{_name}h{_props}"

I think it's easier to modify on your merge approval at this point? Sorry about that.


GroupJoin to parent with no child throws invalid operation exception

I have a query that selects parent records sets all child records to be a property.  This query work in EF Core 1.1 even if it was rather inefficient and performed the matching in memory.  With EF Core 2.0 it is now efficiently running just one query and attempting to build the objects from the one result set.  This works fine so long as all parent records have a child record.  If one of the parents does not have a child record it throws the following error.
System.InvalidOperationException occurred
  HResult=0x80131509
  Message=An exception occurred while reading a database value for property 'Child.ParentId'. The expected type was 'System.Int32' but the actual value was null.
  Source=Microsoft.EntityFrameworkCore
  StackTrace:
   at Microsoft.EntityFrameworkCore.Metadata.Internal.EntityMaterializerSource.ThrowReadValueException[TValue](Exception exception, Object value, IPropertyBase property)
   at Microsoft.EntityFrameworkCore.Metadata.Internal.EntityMaterializerSource.TryReadValue[TValue](ValueBuffer valueBuffer, Int32 index, IPropertyBase property)
   at Microsoft.EntityFrameworkCore.Query.ExpressionVisitors.Internal.ProjectionShaper.TypedProjectionShaper`3.Shape(QueryContext queryContext, ValueBuffer valueBuffer)
   at Microsoft.EntityFrameworkCore.Query.QueryMethodProvider.<_GroupJoin>d__23`4.MoveNext()
   at System.Linq.Enumerable.SelectEnumerableIterator`2.MoveNext()
   at Microsoft.EntityFrameworkCore.Query.Internal.LinqOperatorProvider.ExceptionInterceptor`1.EnumeratorExceptionInterceptor.MoveNext()
   at EFCoreGroupJoin.Program.Main(String[] args) in C:\Git\GitHub\EFCore2GroupJoinIssue\EFCoreGroupJoin\Program.cs:line 42

Inner Exception 1:
NullReferenceException: Object reference not set to an instance of an object.

Steps to reproduce
If have created a sample application (with EF migrations) that exhibits this issue, the repo is available here
The query that is causing the problem is:
var results = context.Parents.GroupJoin(
    context.Children.Select(x => new
    {
        ParentId = x.ParentId,
        OtherParent = x.OtherParent.Name
    }),
    p => p.Id,
    c => c.ParentId,
    (parent, child) => new
    {
        ParentId = parent.Id,
        ParentName = parent.Name,
        Children = child.Select(x => x.OtherParent)
    });

if I materialise the child query and then pass it into the group join, then it works as expected i.e:
var preCalcChildren = context.Children.Select(x => new
{
    ParentId = x.ParentId,
    OtherParent = x.OtherParent.Name
}).ToList();

var results = context.Parents.GroupJoin(
    preCalcChildren,
    p => p.Id,
    c => c.ParentId,
    (parent, child) => new
    {
        ParentId = parent.Id,
        ParentName = parent.Name,
        Children = child.Select(x => x.OtherParent)
    });

I have other very similar queries which work as expected, however they return an EF typed object from the first parameter to the GroupJoin method.  If it is an anonymous type (like here) or another POCO, I get this error.
If have tried the following query
var results = context.Parents.GroupJoin(
    context.Children,
    p => p.Id,
    c => c.ParentId,
    (parent, child) => new
    {
        ParentId = parent.Id,
        ParentName = parent.Name,
        Children = child.Select(x => x.OtherParent.Name)
    });

But this seems to query OtherParent for each Parent that has at least one Child.
Further technical details
EF Core version: 2.0.0
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Win10
IDE: Visual Studio 2017 (15.3.5)

Notes for triage: I was able to reproduce this and the data in the database looks valid. This is reported as a regression, so assigning to @smitpatel to do some initial investigation and putting in 2.0.1 until we know more.

I downloaded zip file from repro. Updated connection strings. Ran 'dotnet ef database update' and 'dotnet run' it passes successfully. What am i missing.

@smitpatel Did you set ensureOneParentHasNoChildren to true in the repro?

I got repro.

@smitpatel Can you write the patch Risk/Justification for this?

Risk: Low
Impact: When EF Core is evaluating a GroupJoin query without DefaultIfEmpty where Inner source is non-entity type, we combine both the queries to generate Left Join but the inner shaper is null safe which would be only generated due to left join now causing exception like above.
Justification: Fix is to identify only those cases when the shaper is not on entitytype and don't combine queries.

This patch bug is approved for the 2.0.x patch. Please send a PR to the rel/2.0.1 branch and get it reviewed and merged.

Hi, we have a public test feed that you can use to try out the ASP.NET/EF Core 2.0.3 patch!
To try out the pre-release patch, please refer to the following guide:

https://github.com/aspnet/Announcements/issues/274 (info)
https://github.com/aspnet/Home/issues/2254 (discussions and questions)

We are looking for feedback on this patch. We'd like to know if you have any issues with this patch by updating your apps and libraries to the latest packages and seeing if it fixes the issues you've had, or if it introduces any new issues. If you have any issues or questions, please reply on this issue to let us know as soon as possible.
Thanks,
Eilon

I can confirm that I no longer get this error.  A little annoyingly it still runs two queries to get the results, but I'll take that over an error.

Still having this issue with 2.0.1 packages (including Microsoft.EntityFrameworkCore.SqlServer 2.0.1)... here is my package reference list
  <ItemGroup>     <PackageReference Include="Microsoft.AspNetCore" Version="2.0.1" />     <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="2.0.1" />     <PackageReference Include="Microsoft.AspNetCore.Identity" Version="2.0.1" />     <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="2.0.1" />     <PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="2.0.1">       <PrivateAssets>All</PrivateAssets>     </PackageReference>     <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.0.1" />     <PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" Version="2.0.1" />     <PackageReference Include="Microsoft.AspNetCore.Server.IISIntegration" Version="2.0.1" />     <PackageReference Include="Microsoft.AspNetCore.StaticFiles" Version="2.0.1" />     <PackageReference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="2.0.1" />     <PackageReference Include="Microsoft.AspNetCore.Cors" Version="2.0.1" />     <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="2.0.0" />     <PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="2.0.0" />     <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.0.0" />     <PackageReference Include="Microsoft.Extensions.Logging" Version="2.0.0" />     <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="2.0.0" />     <PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="2.0.0" />     <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="2.0.0" />     <PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="5.1.5" />     <PackageReference Include="System.Security.Cryptography.Csp" Version="4.3.0" />   </ItemGroup>

@mchenx Can you post a new issue with a runnable project/solution or code listing that reproduces what you are seeing?


Refactored dashboard to use the new JSON schema

Checklist:

[ x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #319

@Code-Victor 👆


Feat/rewards page

Functionality:
Implementation of rewards page
Solution:

Created API's to manage business logic.
Created rewards interface to use it as constructor.
Created Ui including forms to take inputs and cards to show reward info.

WtId:
Risk level:

[ ] high
[x] medium
[ ] low

How to test:
1.Open Emulator
2.  Click on  manage rewards.
4. Click on add reward and create a reward.
5. You will see a reward card added in the page.

this pr needs to got to the rewards branch


KAFKA-13149: fix NPE for record==null when handling a produce request

This code
https://github.com/apache/kafka/blob/bfc57aa4ddcd719fc4a646c2ac09d4979c076455/clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java#L294-L296
returns record=null, and can subsequently cause a null pointer exception in
https://github.com/apache/kafka/blob/bfc57aa4ddcd719fc4a646c2ac09d4979c076455/core/src/main/scala/kafka/log/LogValidator.scala#L191
This PR lets the broker throw an invalid record exception and notify clients. The fix is similar to
https://github.com/apache/kafka/blob/bfc57aa4ddcd719fc4a646c2ac09d4979c076455/clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java#L340-L358
where we throw an invalid record exception when the record's integrity is broken.

This PR is ready for review

@ccding I kicked off a new build since it has been a while since the PR was submitted. Assuming tests are ok, I will merge shortly. Thanks for your patience.


User-editable tests, values and expected results

Updates can be saved to localStorage and exported and viewed raw.  Need an intuitive way to indicate artifacts which are overridden locally vs loaded from GitHub or Server-Side.

This is done except for push to remote.  Also needs to be done for cases.


Ignore representations which use incompatible codecs for TrickMode

Resolves: https://github.com/google/shaka-player/issues/2846

It's not the job of the DASH parser to filter compatible tracks, it should just parse and report the manifest.  This would be better done in shaka.util.StreamUtils, which handles filtering out incompatible streams.  You could just set the stream.trickModeVideo to null.

@TheModMaker In stream https://github.com/google/shaka-player/issues/2846 there are two representations with two different codecs (H264 and H265). Since right now there is only one trickMode track, if I choose H265 (which is the one that comes first) and then filter, I leave the user without that track. With my change this would not happen, since H264 would be chosen. I understand the parser shouldn't do this, but the change would be to add trickMode (https://github.com/google/shaka-player/issues/872) multi-track support and then do filtering (this is much more complex).

In that case, how about just comparing the codec of the trick mode track to match the parent?  We don't support codec switching, so the stream filtering will do this anyway.  Then, you should include a comment referencing #1528.  You can use shaka.util.MimeUtils.getCodecBase to compare the codecs.

@TheModMaker I updated the implementation based on your comment. Can you check again?


Add a fairs root view controller

This adds all the infra to create a new screen in the iOS app.
--
Yep, looks to me like things aren't working like we expect WRT the import/exports

Fails

:no_entry_sign:

Missing Test Files:

src/lib/Scenes/Fair/__tests__/index-tests.tsx

If these files are supposed to not exist, please update your PR body to include "#skip_new_tests".

  Generated by :no_entry_sign: dangerJS

🚢


why does colcon build test packages even if -DBUILD_TESTING=OFF is passed

I'd like to skip building gtest_vendor and friends, so I do:
wruser@a39833e76266:/work/build/ros2/ros2_ws$ colcon build --merge-install --cmake-force-configure --cmake-args -DBUILD_TESTING=OFF --packages-up-to ament_cmake_gen_version_h
Starting >>> ament_package
Starting >>> gtest_vendor
Finished <<< gtest_vendor [0.45s]
Finished <<< ament_package [1.02s]
Starting >>> ament_cmake_core
Finished <<< ament_cmake_core [0.46s]
Starting >>> ament_cmake_python
Finished <<< ament_cmake_python [0.46s]
Starting >>> ament_cmake_test
Finished <<< ament_cmake_test [0.94s]
Starting >>> ament_cmake_gtest
Finished <<< ament_cmake_gtest [0.47s]
Starting >>> ament_cmake_gen_version_h
Finished <<< ament_cmake_gen_version_h [0.48s]

Summary: 7 packages finished [5.06s]

If I explicitly remove test_depend from the package.xml, it works as I expect
  <!-- <test_depend>ament_cmake_gtest</test_depend> -->

wruser@a39833e76266:/work/build/ros2/ros2_ws$ colcon build --merge-install --cmake-force-configure --cmake-args -DBUILD_TESTING=OFF --packages-up-to ament_cmake_gen_version_h
Starting >>> ament_package
Finished <<< ament_package [1.03s]
Starting >>> ament_cmake_core
Finished <<< ament_cmake_core [0.61s]
Starting >>> ament_cmake_gen_version_h
Finished <<< ament_cmake_gen_version_h [0.95s]

Summary: 3 packages finished [3.77s]

Did I miss something?

Setting -DBUILD_TESTING=OFF would prevent CMake from building anything inside:
if (BUILD_TESTING)
   # Testing code
endif()

colcon build is a utility to help you build your package in your workspace in order, using information purely from package.xml, it won't consider anything passed by the cmake-args (and it doesn't make sense to).
You should be able to use --packages-skip ament_cmake_test ament_cmake_gtest to achieve what you want.
I'm not sure if there is a colcon flag that skips all "test_depend" dependencies without explicitly listing them, but if there isn't one that would sound like a good addition to colcon-core to me.

I'm not sure if there is a colcon flag that skips all "test_depend" dependencies without explicitly listing them, but if there isn't one that would sound like a good addition to colcon-core to me.

Colcon's package discovery crushes down test depends to be build depends currently; it would be a pretty major design shift for colcon to begin recognizing tests more explicitly.

Colcon's package discovery crushes down test depends to be build depends currently; it would be a pretty major design shift for colcon to begin recognizing tests more explicitly.

I'm not sure this is accurate. Part of the issue is that not all package formats support discriminating between dependency types at all, and some just lack consistency in how to do it (looking at you, Python).
For example, for packages which use package.xml, the test dependencies are already enumerated separately. The issue is that the build verb implicitly considers all enumerated dependencies, regardless of type, to be build-time dependencies of the package: https://github.com/colcon/colcon-core/blob/64f06cf523cf211934ee608d0c986774b5997349/colcon_core/package_descriptor.py#L74-L75

a colcon flag that skips all "test_depend" dependencies without explicitly listing them

@ijnek I think this is exactly what I was looking for. Another way might be to prepend
if (BUILD_TESTING)
# CMakeLists content of the test package
endif()

to all test packages?


Need to publish new version with latest commits

Hi, it looks like new commits were added to fix issues with v1.0.0. My build was not working with this action until I changed my file to pull the latest from main via
    - name: Run EditorConfig Linter
      uses: editorconfig-checker/action-editorconfig-checker@main

Can you please publish a new version (eg v1.0.1) that contains all the new commits so I can reference that instead of the main branch?

Sorry it took so long, we have v2 now: https://github.com/editorconfig-checker/action-editorconfig-checker/releases/tag/v2.0.0
Related: https://github.com/editorconfig-checker/action-editorconfig-checker/issues/13


TensorMap size argument is based on size of bytes, but treated as size of floats for some places

:octocat: cibot: Thank you for posting issue #1474. The person in charge will reply soon.

resolved with #1473


Importing .blend file results in Roughness texture being used as Metallic texture

Godot version
v4.1.1.stable.official [bd6af8e0e]
System information
Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3070 (NVIDIA; <IP_ADDRESS>13) - AMD Ryzen 7 5800X 8-Core Processor (16 Threads)
Issue description
When importing .blend files, the Roughness texture is used for both the Roughness and the Metallic properties of the imported material. I would expect the imported model to use the Metallic texture that was set up in Blender.

Steps to reproduce
In Blender (3.6.3):

Layout > Add > Mesh > Monkey
Shading > New
Create Metallic texture

Add > Texture > Image Texture
Connect Color to Metallic
Click New on the Image Texture and create image "Metallic"
Change the Image Texture's Color Space to Non-Color
Switch to Texture Paint and draw some shapes on the texture

Create Roughness texture

Similar to steps for Metallic

File > Save
File > External Data > Pack Resources

In Godot (4.1.1):

Create a new Forward+ project
Drag .blend file into FileSystem's "res://" folder.
Select it in the FileSystem, go to Import and click "ReImport"

Note: I had to do this in order to make the material have any textures at all. May be a separate bug.

Create a 3D Node
Drag .blend file from FileSystem to be a child of the 3D Node
Open the imported scene in the editor (Click "Open Anyway")
Inspect the mesh's surface material and observe that the Metallic and Roughness textures are both the Roughness texture that was created earlier.

Minimal reproduction project
Godot project: MetallicImportBugRepro_Godot.zip
Blender project: MetallicImportBugRepro_Blender.zip

Can you reproduce this when exporting a .gltf file and importing it in Godot?

When exporting a .gltf file from Blender and importing it in Godot, I get a combined Metallic/Roughness texture file. This is loaded into the material correctly as the two textures are indeed the same file, just different channels.
I assume this "combine into one texture" behavior is what's intended for the .blend import as well?

I assume this "combine into one texture" behavior is the intention for the .blend import as well?

Yes; I don't know why it's not happening when Godot imports a .blend file directly.

As an aside, I personally find it somewhat unintuitive that the textures are automatically combined instead of just using the two image textures I set up in Blender. I wonder, what's the reason for this being the default?

Using this approach results in better performance (fewer textures need to be used for the material), as you can use ORMMaterial3D instead of StandardMaterial3D.

Using this approach results in better performance (fewer textures need to be used for the material), as you can use ORMMaterial3D instead of StandardMaterial3D. See also godotengine/godot-proposals#2955.

Makes sense. Do you know if it's possible to disable this behavior? I can't seem to find something like that in the import settings. If not, that's totally fine. It's not what this issue is about anyway 😅
Regarding the actual issue, if someone could point me to the right corner of the codebase I would also be happy to look into the issue myself.

Makes sense. Do you know if it's possible to disable this behavior?

Not that I know of.

Regarding the actual issue, if someone could point me to the right corner of the codebase I would also be happy to look into the issue myself.

The Blender importer code is here: https://github.com/godotengine/godot/blob/ec62b8a3ee1d731387a440b4d2abb7961aa28322/modules/gltf/editor/editor_import_blend_runner.cpp

I have been looking into this more over the weekend. This will be a somewhat long post with the details of my findings. I hope it can serve as a jumping-off point for any potential fixes.
Forgive me if some of this is obvious to veterans of the engine, I'm a very recent immigrant from the Unity fiasco. If you have corrects, please let me know!
Blender glTF export
Basic theory
Blender has 3 main modes of exporting gLTF files: Binary (.glb), Embedded (.gltf), and Separate (.gltf + .bin + textures).
Note that by default, whether using embedded textures or not, Blender will combine the Metallic and Roughness into the texture we previously talked about in this thread. It is possible to disable this behavior by toggling the Keep original option when using the Separate mode, but this does come with the following very relevant warning:

If you use more than one texture, where PBR requires only one, only one texture will be used. This can lead to unexpected results.

Godot's settings
When importing a .blend file, Godot will behind the scenes call Blender and perform a gLTF export, just like Calinou said. This export uses the Separate mode, along with Keep original set to True.
To me, this explains the faulty behavior originally described in this issue. Godot seemingly assumes that the Metallic and Roughness textures will be combined, while explicitly telling Blender not to do that.
Testing different formats
So perhaps we can solve the issue by changing export settings. The table below shows the results of importing gLTF files manually exported from Blender, both for projects where the texture files have and have not been packed into the .blend file.

Packed
Unpacked

Binary
✅ †
✅

Embedded
✅ †
✅

Separate
✅ ‡
✅ ‡

Separate + Keep original
❌
❌

Legend
✅ Imported with Metallic and Roughness correctly assigned
❌ Imported with Metallic incorrectly assigned to the same texture file as Roughness
† If Godot's Embedded Image Handling is set to Extract Textures in the scene import settings, you will have to trigger a second import. Otherwise, the imported scene will error due to missing images. I believe this to be a bug.
‡ You of course have to import the exported textures and the .bin file alongside the .gltf file, as they are not embedded inside the project with this export setting.
Attempted fix by changing Godot's export settings
At this point, I thought the fix would be to simply change Godot's Blender export settings to one of the working formats from the table above. This can be easily done here: https://github.com/godotengine/godot/blob/6de34fde27f650f738a1e46992f1b783f2cf9e76/modules/gltf/editor/editor_scene_importer_blend.cpp#L77-L78
However, all approaches I tried had issues.
Separate and Embedded
For Separate and Embedded exports, the scene has no Metallic/Roughness textures assigned at all and Godot produces the following error:
🔴 Can't find file 'res://.godot/imported/Unpacked-ef043bcaf77b3602acfd1d86d08410e3_Metallic-Roughness.png'.
🔴 No loader found for resource: res://.godot/imported/Unpacked-ef043bcaf77b3602acfd1d86d08410e3_Metallic-Roughness.png (expected type: Texture2D)
🟡 modules/gltf/gltf_document.cpp:3233 - glTF: Image index '0' couldn't be loaded with the name: Metallic-Roughness. Skipping it.

After the import has run, .godot/imported will actually contain the combined Metallic/Roughness texture in question, but Godot will not import it due to it being in the .godot folder. I assume this is on purpose to prevent an infinite loop:https://github.com/godotengine/godot/blob/7aff59f0b6920b970454c7608148845619d6cd60/editor/editor_file_system.cpp#L1369-L1371
Additionally, if the Blender project is not packed and you import the textures as well, .godot/imported will also contain a combined Metallic-Roughness.png texture. Note that this will happen despite the export mode being Embedded. There will also be the following error in the log:
🔴 No loader found for resource: res://.godot/imported/Metallic-Roughness.png (expected type: )

Binary
For both packed and unpacked Blender files, the imported scene will completely fail and get a little ❌ icon. The following will be printed in the log:
🔴 modules/gltf/gltf_document.cpp:7580 - Condition "err != OK" is true. Returning: ERR_FILE_CANT_OPEN
🔴 Error importing 'res://Unpacked.blend'.

What now?
Barring abandoning the issue, I see two potential actions to take from here:
A) Make Godot support importing gLTF files with separate textures for Metallic and Roughness. This would help not only with gLTF support in general but also allow the existing Blender file importing to Just Work™.
B) Figure out what goes wrong when importing Embedded gLTF files through the Blender import process and change the export mode to Embedded. With this, Godot would not have to concern itself with separate Metallic/Roughness textures, as they would be combined during the Blender export.
I'm not sure either of these fixes would be easy for me to execute, but I would be willing to take a look if we knew what approach we wanted to go with.
If you've read all this, I thank you. I would love to hear what you think. Perhaps someone would be willing to see if they get similar results and that it's not just me messing something up.
Cheers ✌

glTF does not support separate textures for metal and roughness, they have to be combined into one texture. (Same for base color and alpha.)

Makes sense. So something like approach B from my previous post (changing the export settings Godot sends to Blender), would be the way to go?

@tobloef As an aside, I personally find it somewhat unintuitive that the textures are automatically combined instead of just using the two image textures I set up in Blender. I wonder, what's the reason for this being the default?

This happens because glTF does not support specifying different textures for metallic as roughness, it specifies only a metallicRoughnessTexture for both: https://github.com/KhronosGroup/glTF/blob/main/specification/2.0/schema/material.pbrMetallicRoughness.schema.json#L43 Therefore, "A) Make Godot support importing gLTF files with separate textures for Metallic and Roughness" is not possible. ...uh, sorry, I missed the last part of the discussion where this was mentioned already, but I'll keep this text around instead of deleting it in case the details and link helps.
Anyway, it seems that Blender does not have a way to "unpack" the converted roughness+metallic texture. I've made two PRs to fix this problem: #96778 and #96782. However, note that you will need to uncheck this box:

Reproducible in Godot v4.3.stable and Blender 4.1.1/4.2.2
Here's the model i use to test:
The Cartoon Knight_anim.zip


40039/keepers benchmark test

Add keeper benchmark test contracts

Related PR in chainlink repo - https://github.com/smartcontractkit/chainlink/pull/7066

Codecov Report

Merging #388 (07b25c0) into main (63ea4fd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   40.80%   40.80%
=======================================
  Files           6        6
  Lines         272      272
=======================================
  Hits          111      111
  Misses        153      153
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63ea4fd...07b25c0. Read the comment docs.


types.d.ts exports ReactQuill incorrectly

React-Quill version

[x] 1.2.7

Hi there,
I haven't used ReactQuill before so I can't speak to whether this was working previously or not but I just pulled it down and in typescript am getting the following error:
TS1192: Module '"projectroot/node_modules/react-quill/types"' has no default export.
I am importing it like so
import ReactQuill from 'react-quill';

I am noticing @clinyong made the change the other day from
export default class Component extends React.Component<ComponentProps> {
	focus(): void;
	blur(): void;
	getEditor(): Quill.Quill;
}

to
declare class ReactQuill extends React.Component<ReactQuill.ComponentProps> {
	focus(): void;
	blur(): void;
	getEditor(): Quill.Quill;
}

export = ReactQuill;

When you do export = ReactQuilll, ts doesn't treat it as default. You can fix this by saying
export default ReactQuill

on line 94 - https://github.com/zenoamaro/react-quill/blame/master/types.d.ts#L94
I can make a pr if you guys want but one of the contributors can probably do it faster than me pulling everything down. Let me know.
Cheers,
Igor

https://github.com/zenoamaro/react-quill/blob/master/README.md#import-the-component
Added a TS import example

I can import ReactQuill, but I can't import UnprivilegedEditor, so I can' t add types to my event handlers. Only Quill shows up as a non-default export.

@patrick-jones applying this patch should fix your typing issue: https://github.com/zenoamaro/react-quill/pull/433
@alexkrolick can you take a look?


Absolut easy to understand README

Write a easy to understand documentation of how to use the class. It needs two ways to implement it: Using package-manager composer or for the copy-and-paste users.

Ich Die il
Sent from my Google Pixel XL using FastHub

Ich
Sent from my Google Pixel XL using FastHub


[docs] Write a decrease test execution time article

fixes #5686
Article name pending

local build finished with no errors


Improve confirmation message for namespace/project deletion

What type of PR is this:
/kind improvement
What does this PR do / why we need it:
See https://github.com/redhat-developer/odo/issues/6256#issuecomment-1339630293
Which issue(s) this PR fixes:
Fixes #6256
PR acceptance criteria:

[ ] Unit test

[x] Integration test

[x] Documentation

How to test changes / Special notes to the reviewer:

@rm3l can you also update the helper function DeleteNamespaceProject. Or, maybe update the function to use oc instead. I seem we missed to update the oc_helper.

Thanks for pointing that out - I think it would make sense to use the oc binary in helper_oc, not odo. I ll change that.


Error in 'run_epr' step in qiskit metal with ansys2023

Information

Qiskit Metal version:  0.1.5
Python version:  3.9.19
Operating system:  Window

What is the current behavior?
When runing tutorial code 'https://qiskit-community.github.io/qiskit-metal/tut/4-Analysis/4.02-Eigenmode-and-EPR.html',
I got an error message : "com_error: (-2147352567, 'Eccezione.', (0, None, None, None, 0, -2147024382), None)"
I'm using Ansys2023, Qiskit Metal 0.1.5, python version 3.9.19
I tried the suggested solution in 'https://github.com/zlatko-minev/pyEPR/pull/142'
but after I replace the previous 1579-1587 line, New error by 'if' occurs.
Steps to reproduce the problem
You can simple run one of the example at this page https://qiskit-community.github.io/qiskit-metal/tut/4-Analysis/4.02-Eigenmode-and-EPR.html# and when you arrive to the part of epr simulation you should see the error
What is the expected behavior?
In principle it should gives me the value of epr and chi matrix, instead it starts to write the values and the stop with an error
Suggested solutions

Can you post the error trace? It’s not clear what the error is On Sep 12, 2024, at 8:57 AM, Shawn-Seo93 @.***> wrote:
Information
Qiskit Metal version:  0.1.5
Python version:  3.9.19
Operating system:  Window
What is the current behavior?
When runing tutorial code 'https://qiskit-community.github.io/qiskit-metal/tut/4-Analysis/4.02-Eigenmode-and-EPR.html',
I got an error message : "com_error: (-2147352567, 'Eccezione.', (0, None, None, None, 0, -2147024382), None)"
I'm using Ansys2023, Qiskit Metal 0.1.5, python version 3.9.19
I tried the suggested solution in 'zlatko-minev/pyEPR#142'
but after I replace the previous 1579-1587 line, New error by 'if' occurs.
Steps to reproduce the problem
You can simple run one of the example at this page https://qiskit-community.github.io/qiskit-metal/tut/4-Analysis/4.02-Eigenmode-and-EPR.html# and when you arrive to the part of epr simulation you should see the error
What is the expected behavior?
In principle it should gives me the value of epr and chi matrix, instead it starts to write the values and the stop with an error
Suggested solutions
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Sorry, I have tried many possible combination of software versions, and found it finally working!
My problem was solved in the conditions below.
Maybe it was caused by installation version mixing.,,
Qiskit Metal version:  0.1.5
Python version:  3.9.19
Ansys 2021R1
numpy version : 1.23.2
Operating system:  Window

Great! On Sep 12, 2024, at 3:04 PM, Shawn-Seo93 @.***> wrote:
Sorry, I have tried many possible combination of software versions, and found it finally working!
My problem was solved in the conditions below.
Maybe it was caused by installation version mixing.,,
Qiskit Metal version:  0.1.5
Python version:  3.9.19
Ansys 2021R1
numpy version : 1.23.2
Operating system:  Window
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

I'm encountering a similar issue while using Ansys 2023R2. I've followed the setup as outlined with the same package versions except for Ansys, which is the updated 2023R2 version. Below is the error message I'm receiving when attempting to run the eig_qb.run_epr() function:
com_error                                 Traceback (most recent call last) Cell In[17], line 1 ... com_error: (-2147352567, 'Exception occurred.', (0, None, None, None, 0, -2147024382), None)
Is there any known incompatibility with Ansys 2023R2, or any suggestions for debugging this issue further?


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 10:12:29 on 2023.08.04
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 3, errors out: 0
Original problem ID: 34586
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=34586

Problem has been resolved in 6m 0s at 10:18:29 on 2023.08.04
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 34586


feat/typescript-storyblok

Relevant changes:

Typing: added typescript interfaces (e.g. BlokData) and re-export them so users can access the types, and renamed all files to .ts
Build: added type fields to package.json and tsconfig.json

Review tips:

There are no new API changes or features, it's all typing
Best way to validate is use the playground main.ts file and make sure the typescript autocompletion and type-checking is working

@fgiuliani @christianzoppi excuse us for not adding the right prefix for the first few commits messages (hooks were not working on @edwardz8 PC) but the others are correct so the next version will be calculated properly 👍

thanks for the feedback @thiagosaife !
On Monday, April 25, 2022, 2:05 PM, Thiago Saife @.***> wrote:
@thiagosaife requested changes on this pull request.
Nice job. Just some considerations about names.
In playground/main.ts:

@@ -1,5 +1,13 @@
import { storyblokInit, loadStoryblokBridge } from @.***/js";

+declare global {

interface Window {

I wouldn't set this global variable as Window. Could you set it as something else? SbWindow maybe?
In playground/main.ts:

@@ -1,5 +1,13 @@
import { storyblokInit, loadStoryblokBridge } from @.***/js";

+declare global {

interface Window {
initWithBridge: any;

Can we add strict typing here? Just asking, maybe any is too generic, but it can be necessary. Your call. Same question for the following props.
In lib/types.ts:

@@ -0,0 +1,19 @@
+import { StoryblokConfig, StoryblokComponent } from "storyblok-js-client";

+declare global {

interface Window {
storyblokRegisterEvent: any;
StoryblokBridge: any;
}
+}

+export interface BlokData extends StoryblokComponent {

+}
+
+export interface SDKOptions {
I would suggest to us to follow a pattern for the namespace here. We use Sb for naming our own properties/components, it would be like SbSDKOptions. Sounds good?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@mmatheuspalma Could take a look into this, please?

@thiagosaife @fgiuliani added the Sb prefix, better types and some missing temporary types for Bridge v2


Multiple Select, the selected state not synchronized

https://material-ui-1dab0.firebaseapp.com/demos/selects/
as this demo show, when I click a selected menu item and move out, the background not changed

Duplicate of #5186


Save pdf as png?

Hi, is it possible to save the resulting pdf as an image in nodejs with this library?

Hello @arthabus!
Converting PDF documents to PNG images is not possible to do with pdf-lib. However, you can use pdf.js for this. Here's a NodeJS example they provide.
You'd need to modify lines 53-57 of the example to use the output of PDFDocument.save():
// Create and manipulate your PDF document
var pdfDoc = await PDFDocument.create() // or `PDFDocument.load(...)`
...

// Read the PDF file into a typed array so PDF.js can load it.
var rawData = await pdfDoc.save()

Thanks @Hopding. I tried that before - it doesn't work consistently in node unfortunately - it fails to render text every now and then. Then hopefully ImageMagic could do a better job here.

Hi @Hopding,
Good day!
Similar to @arthabus, I am facing issue with pdfjs in rendering texts (missing fonts) hence I also thought of using pdf-lib and render it to canvas. My current solution was using graphicsmagick but was hoping to make a pure standalone app.
I've been trying to render the page to a canvas but have no success. Was hoping you could allow this behaviour or maybe shed light if this is even possible.
Many thanks
Marc


Remove status channel

Related to https://github.com/frmscoe/General-Issues/issues/323

Waiting for @rtkay123 to rebase from this branch and Squash Merge changes for the major 3 lib version


how to display the buttons on top?

I have adjusted the CSS class for displaying the button group on the top of the wizard content. But it's not compatible for responsive design. how make it display on the top??
.wizard.vertical > .actions {
    display: inline;
    float: right;
    margin: -26% 1.5%;
    width: 95%;
}

No one reply me! this is a bug in your project! not my error!


Issue with creating resources for models not residing in App<

Package
filament/filament
Package Version
2
Laravel Version
10
Livewire Version
v2
PHP Version
php 8.1
Problem description
Hi.
I am having an issue with something very similar to 2920.
We store my models in a package that has a different namespace then App\Models, let's say MyNamespace\Models in order to share them across a few projects.
When I run
php artisan make:filament-resource MyNamespace/Models/User --generate

Filament looks for the User model in App\Models\MyNamespace\Models\User
Expected behavior
If I were to run.
php artisan make:filament-resource /MyNamespace/Models/User --generate;

or
php artisan make:filament-resource \\MyNamespace\\Models\\User --generate

In class files such as UserResource I would expect it to write.
use MyNamespace\Models\User;

instead it writes.
use App\Models\MyNamespace\Models\User;

Steps to reproduce
Clone the repo.
Composer Install, Database Migrate.
Log in using
<EMAIL_ADDRESS>password
Click Posts on left nav
See error.
Reproduction repository
https://github.com/whoacowboy/filament-bug
Relevant log output
Error
PHP 8.1.4
10.14.1
Class "App\Models\MyNamespace\Models\Post" not found

I did figure out a work around for now.
I created a new model that extends my model.
namespace App\Models;

use MyNamespace\Models\Post as MyNamespacePost;

class Post extends MyNamespacePost
{

}

Then when I run
php artisan make:filament-resource Post --generate;

it works as expected.
It works nicely for the User model because then I can add the Filament specific UserFilament implementation methods without bogging down my User model.
    public function canAccessFilament(): bool
    {
        return $this->email ===<EMAIL_ADDRESS>    }

    public function getFilamentAvatarUrl(): ?string
    {
        return $this->user_icon;
    }

It's be nice if we didn't have to go through the extra step but so far I am loving Filament.

There's no need to duplicate model classes, you can use php artisan make:filament-resource Post  and then go into the PostResource.php and just change the import to point towards your real model class. The only thing that wont work is generate. PRing a --model flag as a new feature would be cool, but it is not a bug.
The reason Using/A/Path behaves like that is because that tells Filament which directory to put the resource in, not where to find the model.

Hi @danharrin, I tried that originally and it did not work. Filament will go through the crud index and edit screens but there are no fields.
I updated the repo.

Yeah, generate will not work, but you can just add the columns and inputs yourself?

OK, now I get it.
FYI, when I do run it with an extended model,
App\Models\Post extends MyNamespace\Models\Post
everything works as expected.
Thanks for your help.

And one last trick in case someone is coming here late.
If I extend the model,
App\Models\Post extends MyNamespace\Models\Post
run
php artisan make:filament-resource Post --generate
Then go into PostResource and change App\Models\Post to MyNamespace\Models\Post it works with all of the scaffolding and I can delete App\Models\Post


fix(client): When calling the 'kneigbor' interface and returning the …

When calling the 'kneigbor' interface and returning the result, scenarios where 'withPath' is' true 'and' false 'are incompatible (#643)

Purpose of the PR

close #643

Main Changes

Verifying these changes

[ ] Trivial rework / code cleanup without any test coverage. (No Need)
[ ] Already covered by existing tests, such as (please modify tests here).
[ ] Need tests and can be verified as follows:

xxx

Does this PR potentially affect the following parts?

[ ]  Nope
[ ]  Dependencies (add/update license info)
[ ]  Modify configurations
[ ]  The public API
[ ]  Other affects (typed here)

Documentation Status

[ ]  Doc - TODO
[ ]  Doc - Done
[ ]  Doc - No Need

@imbajin  @VGalaxies   Please help review it


Simpler server example

Instead streaming to an http server, you can just spawn ffmpeg, and get the stream back, then push the data down through websockets.
Here is the gist of it. (incomplete psudocode)
var child = require('child_process')
var spawn = child.spawn

function getScreenStream (deviceIndex = '1') {
  var ffmpegProccess = spawn('ffmpeg', [
    '-loglevel', 'error',
    '-f', 'avfoundation',
    '-i', `${deviceIndex}`,
    '-vf', `scale=${width}x${height}`,
    '-r', frameRate,
    '-f', 'mpeg1video',
    'pipe:1'
  ], { stdio: ['pipe', 'pipe', process.stderr] })
  return ffmpegProccess.stdout
}

const screenStream = getScreenStream()

screenStream.on('readable', () => {
  const data = screenStream.read()
  socketServer.broadcast(data)
})

// from current example
socketServer.broadcast = (data, opts) => {
  for (var i in socketServer.clients) {
    if (socketServer.clients[i].readyState === 1) {
      console.log('broadcasting data!')
      socketServer.clients[i].send(data, opts)
    } else {
      console.log('Error: Client (' + i + ') not connected.')
    }
  }
}

// ... More from current example to setup websockets etc.

Then connect to websockets the same way as with the current example.

could you give the complete sample ? thank you so much.

@szhansen Let me see if i have the code sitting around
I can probably publish it if so

@ericwooley thank you
mail<EMAIL_ADDRESS>

Like  this idea...


Parsing is the farthest from completion.

I think you should have added a description to explain further like what work is left and which thing to be done in what order. A TODO list would good.


[ISSUE #6244]Fix issue template feature request order incorrect

Make sure set the target branch to develop
What is the purpose of the change

fix #6244
Brief changelog

Fix issue template feature request order incorrect

Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #6245 (250fed0) into develop (d5d5a63) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #6245      +/-   ##
=============================================
- Coverage      43.19%   43.18%   -0.01%
  Complexity      8848     8848
=============================================
  Files           1094     1094
  Lines          77193    77193
  Branches       10070    10070
=============================================
- Hits           33342    33336       -6
- Misses         39678    39689      +11
+ Partials        4173     4168       -5

Impacted Files
Coverage Δ

...apache/rocketmq/broker/longpolling/PopRequest.java
31.03% <0.00%> (-13.80%)
:arrow_down:

...a/org/apache/rocketmq/filter/util/BloomFilter.java
60.43% <0.00%> (-2.20%)
:arrow_down:

...e/rocketmq/store/ha/autoswitch/EpochFileCache.java
77.08% <0.00%> (-1.39%)
:arrow_down:

...e/rocketmq/remoting/netty/NettyRemotingServer.java
57.83% <0.00%> (-1.05%)
:arrow_down:

...che/rocketmq/test/lmq/benchmark/BenchLmqStore.java
50.24% <0.00%> (-0.50%)
:arrow_down:

...ent/impl/consumer/DefaultLitePullConsumerImpl.java
67.53% <0.00%> (-0.47%)
:arrow_down:

...a/org/apache/rocketmq/store/StoreStatsService.java
34.53% <0.00%> (ø)

...cketmq/broker/processor/PopBufferMergeService.java
33.33% <0.00%> (ø)

...main/java/org/apache/rocketmq/store/CommitLog.java
65.13% <0.00%> (+0.10%)
:arrow_up:

...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java
76.42% <0.00%> (+0.35%)
:arrow_up:

... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


VW server changes?

I did have a check for my kommision number as chron job for a few months now, but it stopped working today.
I cannot even get the prefix with anymore
python3 -m vwkommi request -f XXYYYY
Anybody else having that issue?

Thanks for the pull request.
I also noticed that you have to accept the terms of use of VW before being able to login with the usual method. The simple fix is to login via browser once.
I added a print to hint at that in 8154acd342840b410ee3af74c5bd14e968298602


feature: add resolve_ip option

We have some special case where we use dc specific Ceph DNS name, but it is not allowed as S3 does not allow multiple DNS names of bucket.
Implement workaround resolve IP of given DNS name.

Resolved by https://github.com/vinted/S3Grabber/commit/9e3f576c07911eb63bd03d93bce84038c33acbf8


chore(component): remove previous Select implementation

Just removing the previous Select implementation after Gil gave his blessing. 😇

@all-contributors please add @shiroinegai for code, ideas, bug and a11y


Fix race while copying ObjectFileInfo

There was a fundamental race that could (and did!) happen while copying / cloning ObjectFileInfo, as we tried to open the file using the original file path, if the file had been removed, re-opening would fail. This commit leverages procfs to reopen a file that might already have been deleted, as long as there are some file descriptors pointing to it, as the kernel won't effectively remove the file until its reference count reaches zero.
Test Plan
Added test to exercise this code path. Also run the profiler while compiling the Linux kernel as this as this triggered the crash in the past.

Note that we don't use this re-opening technique yet for userspace symbolization, so that could still fail if the file is deleted at that point


feat(serve): deploy hardware information collector for worker nodes

Description
This PR introduces a Hardware Information Collector for worker nodes within the cluster. The expected behavior is as follows:

Automatic Execution: When initializing the cluster, the Hardware Information Collector will automatically run on each new worker node.

Roadmap:

[x] Implement the initial script responsible for gathering hardware metrics from worker nodes.
[x] Utilize Ray to execute the hardware collection script on worker nodes remotely.
[x] (Not automated) Ensure the hardware information collector script runs specifically on each newly added worker node.
[x] (Not automated) Save the collected hardware information to the hardware_config.json file on the control node for future reference and scheduling decisions.
[x] Integrated into the controller for automated operation.

Motivation
Collecting detailed hardware profiles of worker nodes is crucial for implementing Storage Aware Scheduling. Accurate and up-to-date hardware information enables the scheduler to make informed decisions, optimizing resource allocation based on each node’s capabilities and current state.
Type of Change

[x] New feature

Checklist

[x] I have read the CONTRIBUTION guide.
[ ] I have updated the tests (if applicable).
[x] I have updated the documentation (if applicable).

I've tested this PR, and it works well for me. Could you please move the Docker Compose file, along with the two configuration JSON files, into an examples directory? This adjustment is necessary because the Docker Compose file is context-sensitive (see example here).
Thanks!

Do you mean create a new directory like examples/storage_aware_scheduling and put model config files and docker compose config in it? In that case the doc could just reference to the config, is that right?

I've tested this PR, and it works well for me. Could you please move the Docker Compose file, along with the two configuration JSON files, into an examples directory? This adjustment is necessary because the Docker Compose file is context-sensitive (see example here).
Thanks!

Do you mean create a new directory like examples/storage_aware_scheduling and put model config files and docker compose config in it? In that case the doc could just reference to the config, is that right?

Yes, exactly! Also, please update the documentation to instruct users to clone the repository and cd into that directory for setup.


What's up with the font?

I just installed revenge because with the latest update vendetta would be stuck on a endless loading screen, and upon opening the app I noticed the font was... Off...
I'd send a screenshot but the GitHub app won't let me. Maybe someone changed the default font with the latest pr?

Ah there we go

what theme are you using? if that's possible, please send the url of it

Ah, I forgot about the theme.
https://raw.githubusercontent.com/VodkaXMartini/VendettaTheme/main/Vision.json
Turning off the theme fixed the font. However on vendetta this theme didn't change the font for some reason.

because vendetta doesn't have custom fonts support, we added it

I investigated real quick, and last week the creator pushed a commit wich made the theme change the font. I'm guessing vendetta didn't support that and just ignored the keys for that? anyhow I'm closing this. Thanks for pointing me in the right direction!


IOU - Back button not working to cancel request

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open any chat
Click + button
Select send money
insert ammount then click next
Tap back arrow.
Tap back arrow to close IOU

Expected Result:
IOU should be closed after back button is clicked in IOU amount tab
Actual Result:
The user gets looped when clicking the back arrow icon on the amount tab under send money IOU
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: v<IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/d475d3ea-d9a5-4ad5-bb4b-517318e95015
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

we're pausing work on Send Money capabilities on the front-end - https://github.com/Expensify/App/issues/21233
closing this for now.


When I click "Login" chrome does not open any popup.

When I click "Login" chrome does not open any popup.

More specifically, I get "POST https://api.twitter.com/oauth/request_token 401 (Authorization Required)" which makes me think that either Chrome has locked down what can be done in an extension, or Twitter is looking for something different in the post.

You have to change the values of consumer_key and consumer_secret in this file:
https://github.com/lambtron/chrome-extension-twitter-oauth-example/blob/master/js/lib/twitter.js#L3-L4

Nothing happens when I click the login button. No errors in the console. Yes, I added the key and secret.

Nothing happens when I click the login button. No errors in the console. Yes, I added the key and secret.


[release-2.7] Manual cherry-pick of GitOps updates

Cherry-pick:

#629
#582
#556

ref: https://issues.redhat.com/browse/ACM-5966
Canary issue:

https://github.com/stolostron/backlog/issues/27321

/hold for reviews and #629

/retest

Looks like I might need to grab the commit to strip Kyverno out of here also?
 • [FAILED] [318.702 seconds]
GRC: [P1][Sev1][policy-grc] Test the kyverno generator policies [policy-collection, stable]
/go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_kyverno_generators_test.go:19
  [It] Install Kyverno on the managed cluster
  /go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_kyverno_generators_test.go:42
  Begin Captured GinkgoWriter Output >>
    STEP: Creating kyverno resources by deploying the community policy 07/08/23 01:59:46.567
    STEP: Checking if the status of the root policy is NonCompliant 07/08/23 01:59:46.954
    STEP: Patching the kyverno subscription's placement rule in the policy 07/08/23 02:00:06.041
    STEP: Patching remediationAction = enforce on the root policy 07/08/23 02:00:11.731
    STEP: Checking if the status of the root policy is Compliant 07/08/23 02:00:11.741
    STEP: Checking that kyverno deployment exists on the managed cluster 07/08/23 02:00:33.845
    Kyverno generator test Kubernetes info:
  << End Captured GinkgoWriter Output
  Timed out after 180.001s.
  Expected
      <*errors.StatusError | 0xc000840aa0>: {
          ErrStatus: {
              TypeMeta: {Kind: "Status", APIVersion: "v1"},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "deployments.apps \"kyverno\" not found",
              Reason: "NotFound",
              Details: {Name: "kyverno", Group: "apps", Kind: "deployments", UID: "", Causes: nil, RetryAfterSeconds: 0},
              Code: 404,
          },
      }
  to be nil
  In [It] at: /go/src/github.com/stolostron/governance-policy-framework/vendor/open-cluster-management.io/governance-policy-propagator/test/utils/utils.go:150

/retest

Waiting for a review on https://github.com/stolostron/governance-policy-framework/pull/629 since it's new code being cherry-picked here.


Promise Rejection Issue (Again)

Hi
I'm getting this when running, any ideas.
(node:10125) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'parent' of undefined
    at Function.exports.update (/Users/tobinharris/.asdf/installs/nodejs/9.6.1/.npm/lib/node_modules/wordpress-gatsby-migrator/node_modules/cheerio/lib/parse.js:69:26)
    at module.exports (/Users/tobinharris/.asdf/installs/nodejs/9.6.1/.npm/lib/node_modules/wordpress-gatsby-migrator/node_modules/cheerio/lib/parse.js:19:11)
    at Function.exports.load (/Users/tobinharris/.asdf/installs/nodejs/9.6.1/.npm/lib/node_modules/wordpress-gatsby-migrator/node_modules/cheerio/lib/static.js:27:14)
    at parseImages (/Users/tobinharris/.asdf/installs/nodejs/9.6.1/.npm/lib/node_modules/wordpress-gatsby-migrator/importer.js:76:34)
    at items.map.item (/Users/tobinharris/.asdf/installs/nodejs/9.6.1/.npm/lib/node_modules/wordpress-gatsby-migrator/importer.js:45:24)
    at Array.map (<anonymous>)
    at Object.importPosts (/Users/tobinharris/.asdf/installs/nodejs/9.6.1/.npm/lib/node_modules/wordpress-gatsby-migrator/importer.js:19:19)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:160:7)
    at Function.Module.runMain (module.js:705:11)
(node:10125) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:10125) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I'm getting this as well, any ideas?

I only built this against my own WordPress XML export so it's likely because it's something that didn't come up in my own use case.
If you're willing to send me your export (privately) or an anonymised portion that also causes this crash I'm happy to have a look.

This could’ve been resolved by #11, can you retry?

Closing, create a new issue if this is still a problem.


[VST] Round integer param values after de-normalizing (fixes #171)

Has the additional (beneficial) effect, that params, which also have kParameterIsBoolean hint, are displayed as 0 and 1, not 0.0 and 1.0.

What about the boolean case too? if it's only raw 0-1 values which enter the callback, it seems suspicious for it to be compared in the min-max domain value.
Probably, unnormalizing should precede even the boolean case.

Yes, you're probably right, though in practice kparameterIsBoolean params are probably always defined with ranges.min = 0.0 and ranges.max = 1.0, so it makes no difference then.
But in case they're not, yes, the value should be unnormalized before comparing it to the min/max range. I'll update the PR.

This makes sense.
But one thing to note is that it is possible to set custom ranges (outside of 0-1) when using integers in vst. Somehow that is not available for floats, beats me why...


optimize ResourceManagerInbound function's parameters into one struct-rm_api.go

What this PR does:
Which issue(s) this PR fixes:

Fixes #184
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

please resolve conflict

pls fix conflict

Codecov Report

Merging #198 (2ef9edf) into master (5e42d8e) will increase coverage by 0.23%.
The diff coverage is 65.21%.

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   61.61%   61.85%   +0.23%
==========================================
  Files          48       48
  Lines        1941     1953      +12
==========================================
+ Hits         1196     1208      +12
  Misses        687      687
  Partials       58       58

Impacted Files
Coverage Δ

pkg/rm/tcc/tcc_resource.go
29.47% <0.00%> (ø)

...ing/processor/client/rm_branch_commit_processor.go
41.81% <100.00%> (+7.12%)
:arrow_up:

...g/processor/client/rm_branch_rollback_processor.go
41.81% <100.00%> (+7.12%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.