Reduce clippy noise from #[Object] macro

At the moment, when I run cargo clippy, I get a huge number of warnings related to “this function has too many arguments”. This mainly happens in fields that have a large number of filters or relay connections.
warning: this function has too many arguments (9/7)
   --> src/graphql/schema/users/user_friend.rs:116:1
    |
116 | #[Object]
    | ^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: this warning originates in the attribute macro `Object` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: this function has too many arguments (11/7)
   --> src/graphql/schema/users/user_log.rs:506:1
    |
506 | #[Object]
    | ^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: this warning originates in the attribute macro `Object` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: this function has too many arguments (8/7)
   --> src/graphql/schema/users/user.rs:644:1
    |
644 | #[Object]
    | ^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: this warning originates in the attribute macro `Object` (in Nightly builds, run with -Z macro-backtrace for more info)

Description of the feature
I suggest adding the following snippet for clippy if the method has more than 4 arguments.
#[allow(clippy::too_many_arguments)]

what version of Rust are you using?

@sunli829 These warrnings are present in several major versions of async-graphql. I just tried not to pay attention to them until the project grew.
async-graphql: 7.0.3
rust: 1.77.0


iframe popover position shifted

popover position being popped at the wrong place occasionally. triggeredBy prop not working as expected

switched to using svelte-smooth-popover. issue resolved


Change the year to the next one or to the previous one with buttons?

How do I change the current year in the calendar to the next one or to the previous one, using buttons? Change the year, but leave the same month. Thank you very much!

you can use the scrollToDate( theDateYouWantToScrollTo ) function to scroll to what ever date you want.


[BEAM-11936] Fix some errorprone warnings

Fixed errorprone warnings listed here:

AssignmentToMock: Fields annotated with /@Mock/ should not be manually assigned to.
AnnotateFormatMethod: Annotate method with @FormatMethod. Doing so gives compile-time rather than run-time protection against malformed format strings.
AutoValueFinalMethods: Make toString(), hashCode() and equals() final in AutoValue classes, so it is clear to readers that AutoValue is not overriding them.
BadImport: Importing nested classes/static methods/static fields with commonly-used names can make code harder to read, because it may not be clear from the context exactly which type is being referred to. Qualifying the name with that of the containing class can make the code clearer.
BigDecimalLiteralDouble: new BigDecimal(double) loses precision in this case.
JodaToSelf: Use of Joda-Time's DateTime.toDateTime(), Duration.toDuration(), Instant.toInstant(), Interval.toInterval(), and Period.toPeriod() are not allowed.
 Consider other methods for positive random numbers.
UnusedMethod: The presence of an unused method may indicate a bug. This check highlights private methods which are unused and can be safely removed without considering the impact on other source files.
UnnecessaryParentheses: These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them.

For reference https://errorprone.info/bugpatterns

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java_Examples_Dataflow PreCommit

Run Java PreCommit

Run GoPortable PreCommit


Stop(), Pause() etc. doesn't seem to work.

class MainView extends Component {
    playSound(stop=0) {
      console.log(stop)
      var s = new Sound('advertising.mp3', Sound.MAIN_BUNDLE, (e) => {
      if(stop === 1) {
        s.pause();
        console.log("Just stop")
        console.log(s);
      }
      else {
        if (e) {
          console.log('error', e);
        } else {
          console.log('duration', s.getDuration());
          s.play();
        }
      }
    });
   }
   render() {
      return
           <View style={styles.container}>
             <TouchableOpacity onPress={() => this.playSound()}>
               <Text style={styles.button}>play</Text>
             </TouchableOpacity>
             <TouchableOpacity onPress={() => this.playSound(1)}>
               <Text style={styles.button}>Stop</Text>
             </TouchableOpacity>
           </View>;
      }
 }

The audio does play(s.play() works). I have no clue how to stop it.
's.stop()' doesn't seem to work(nor does s.pause()).
Am I missing something here?

You're creating and starting a new sound instance each time you click the button, that's why it doesn't stop.
try setting this.sound = new Sound(....) then you can call this.sound.stop() in your button press handler.


Need simpler way to remove labels.

The current method to remove a label looks somewhat convoluted.
label_to_remove = label.replace('/','~1')

patch = [{"op": "remove", "path": label_to_remove}]

client.patch(
                res=ServiceAccount,
                name=resource_name,
                namespace=namespace,
                obj=patch,
                patch_type=PatchType.JSON,
            )

Request is to add a cleaner dedicated api to remove a label on a resource, something akin to
client.remove_label(
                res=ServiceAccount,
                name=resource_name,
                namespace=namespace,
                label=label_full_path_unmodified
            )

Along the same lines, a dedicated api to label a resource would also be useful. For e.g. for labeling a service account
client.set_label(
                res=ServiceAccount,
                name=resource_name,
                namespace=namespace,
                label=label_full_path_unmodified
            )

Thanks @ca-scribner. Sharing the example Andrew mentioned for reference purpose.
r = client.get(res=ServiceAccount, name=resource_name, namespace=namespace)

del r.metadata.labels[label]

client.patch(res=ServiceAccount, obj=r, name=resource_name, namespace=namespace)

r2 = client.get(res=ServiceAccount, name=resource_name, namespace=namespace)

assert label not in r2.metadata.labels

Assertion in the above code block fails which was not expected.

You can use the default patch type (PatchType.STRATEGIC). Example with a config map:
from lightkube import Client
from lightkube.resources.core_v1 import ConfigMap
from lightkube.models.meta_v1 import ObjectMeta

# create a new config map without labels
config = ConfigMap(
    metadata=ObjectMeta(name='my-config', namespace='default'),
    data={'key1': 'value1', 'key2': 'value2'}
)

client = Client()
cm = client.create(config)
assert cm.metadata.labels is None  # no labels right now

To add a label:
patch = {'metadata': {'labels': {'label1': 'value1'}}}
cm = client.patch(ConfigMap, name='my-config', obj=patch)
assert 'label1' in cm.metadata.labels

To remove the label:
patch = {'metadata': {'labels': {'label1': None}}}
cm = client.patch(ConfigMap, name='my-config', obj=patch)
assert cm.metadata.labels is None

Note that  you cannot use del to remove the label as this is a patch and what is not sent is considered unchanged. You need to pass the label with a value of None instead. See documentation.
To me, It seems simple enough to not deserve a dedicated client method. Maybe you want to add an example in the documentation?

I added an example in the documentation, however I'm keeping this open as it could still be nice to design something to easily modify labels and annotations (better even with a single call)


fix(MWPW-148801):Added two New sticky header variants.

sticky-tablet-up which applies the sticky functionality for tablet and desktop.
sticky-desktop-up which applies the sticky functionality only for desktops.

Resolves: MWPW-148801
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/sharathkannan/plans?martech=off
After: https://mwpw-148801--milosh--sharath-kannan.hlx.page/drafts/sharathkannan/plans?martech=off

Hey @sharath-kannan! I see this has the required approvals, is there a QE that can look into getting this tested?

Verified the PR. Button in the table is proper in iPhone device and content is visible.
Completed the regression. Details are there in JIRA: MWPW-157739


Can you amend the LA email please?

can you update LA email to reflect the changes yesterday and to urge that the 5% increase is not nearly enough? We don't want council members to read this email and feel like they already addressed what we are demanding. They need to DO BETTER. Thank you!

Yes, we will take a look! @averymcguirt thoughts?

Hi @JessHannah thanks for flagging this. I've changed some language to reflect this, and will close the issue. Though if you have specific suggestions feel free to draft and reopen or start a new issue.


[4/n] Improve Critical path vizualization

What does this PR do?
In the overlaid trace file we add an option to only show critical path CPU and GPU operators. Also only show edges on the critical path.
Details

Update API, and update notebook documentation
Implement trimming events in the trace.
Update unit tests for this feature

TestPlan
Ran on test trace - only critical path shows up

New unittest
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)

[x] N/A

[x] Did you write any new necessary tests?

[ ] N/A

[ ] Did you make sure to update the docs?

[x] N/A

[ ] Did you update the changelog?

[ ] N/A

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (66e3c54) 0.00% compared to head (2f83e1f) 91.20%.

Additional details and impacted files
@@            Coverage Diff            @@
##           main      #70       +/-   ##
=========================================
+ Coverage      0   91.20%   +91.20%
=========================================
  Files         0       30       +30
  Lines         0     2592     +2592
=========================================
+ Hits          0     2364     +2364
- Misses        0      228      +228

Files
Coverage Δ

hta/trace_analysis.py
96.59% <ø> (ø)

tests/test_trace_analysis.py
99.62% <100.00%> (ø)

hta/analyzers/critical_path_analysis.py
91.97% <95.45%> (ø)

... and 27 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[SPARK-17952][SQL] Nested Java beans support in createDataFrame

What changes were proposed in this pull request?
When constructing a DataFrame from a Java bean, using nested beans throws an error despite documentation stating otherwise. This PR aims to add that support.
This PR does not yet add nested beans support in array or List fields. This can be added later or in another PR.
How was this patch tested?
Nested bean was added to the appropriate unit test.
Also manually tested in Spark shell on code emulating the referenced JIRA:
scala> import scala.beans.BeanProperty
import scala.beans.BeanProperty

scala> class SubCategory(@BeanProperty var id: String, @BeanProperty var name: String) extends Serializable
defined class SubCategory

scala> class Category(@BeanProperty var id: String, @BeanProperty var subCategory: SubCategory) extends Serializable
defined class Category

scala> import scala.collection.JavaConverters._
import scala.collection.JavaConverters._

scala> spark.createDataFrame(Seq(new Category("s-111", new SubCategory("sc-111", "Sub-1"))).asJava, classOf[Category])
java.lang.IllegalArgumentException: The value (SubCategory@65130cf2) of the type (SubCategory) cannot be converted to struct<id:string,name:string>
  at org.apache.spark.sql.catalyst.CatalystTypeConverters$StructConverter.toCatalystImpl(CatalystTypeConverters.scala:262)
  at org.apache.spark.sql.catalyst.CatalystTypeConverters$StructConverter.toCatalystImpl(CatalystTypeConverters.scala:238)
  at org.apache.spark.sql.catalyst.CatalystTypeConverters$CatalystTypeConverter.toCatalyst(CatalystTypeConverters.scala:103)
  at org.apache.spark.sql.catalyst.CatalystTypeConverters$$anonfun$createToCatalystConverter$2.apply(CatalystTypeConverters.scala:396)
  at org.apache.spark.sql.SQLContext$$anonfun$beansToRows$1$$anonfun$apply$1.apply(SQLContext.scala:1108)
  at org.apache.spark.sql.SQLContext$$anonfun$beansToRows$1$$anonfun$apply$1.apply(SQLContext.scala:1108)
  at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
  at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234)
  at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
  at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:186)
  at scala.collection.TraversableLike$class.map(TraversableLike.scala:234)
  at scala.collection.mutable.ArrayOps$ofRef.map(ArrayOps.scala:186)
  at org.apache.spark.sql.SQLContext$$anonfun$beansToRows$1.apply(SQLContext.scala:1108)
  at org.apache.spark.sql.SQLContext$$anonfun$beansToRows$1.apply(SQLContext.scala:1106)
  at scala.collection.Iterator$$anon$11.next(Iterator.scala:410)
  at scala.collection.Iterator$class.toStream(Iterator.scala:1320)
  at scala.collection.AbstractIterator.toStream(Iterator.scala:1334)
  at scala.collection.TraversableOnce$class.toSeq(TraversableOnce.scala:298)
  at scala.collection.AbstractIterator.toSeq(Iterator.scala:1334)
  at org.apache.spark.sql.SparkSession.createDataFrame(SparkSession.scala:423)
  ... 51 elided

New behavior:
scala> spark.createDataFrame(Seq(new Category("s-111", new SubCategory("sc-111", "Sub-1"))).asJava, classOf[Category])
res0: org.apache.spark.sql.DataFrame = [id: string, subCategory: struct<id: string, name: string>]

scala> res0.show()
+-----+---------------+
|   id|    subCategory|
+-----+---------------+
|s-111|[sc-111, Sub-1]|
+-----+---------------+

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Jenkins, ok to test

Test build #96809 has started for PR 22527 at commit d8083cf.

Test build #96809 has finished for PR 22527 at commit d8083cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96809/
Test PASSed.

Test build #96869 has started for PR 22527 at commit 3fe63c8.

Test build #96869 has finished for PR 22527 at commit 3fe63c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96869/
Test PASSed.

@ueshin Yes. I am already working on array/list support. Will add maps as well. It shouldn't require a rewrite now that the code is restructured, just new cases in pattern match. So I think it's ok to do in another PR.

Test build #96901 has started for PR 22527 at commit 3b2a431.

Test build #96901 has finished for PR 22527 at commit 3b2a431.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96901/
Test PASSed.

Test build #96954 has started for PR 22527 at commit e9b5a98.

I'd merge this not to block the following prs to support array/list and map of beans.

Thanks! merging to master.

Sorry, the merge script failed. Let me try again a while later.

Seems like there is a merge commit in apache git https://git-wip-us.apache.org/repos/asf?p=spark.git, but not in GitHub yet.

Thanks! I created a new PR with array, list and map support.

Hey @ueshin, sorry I was late. I'm a bit busy for these couple of weeks so please don't block by me and ignore me. Thank you for asking it to me.

Looks good to me too!


Enable some Stylelint color-related rules to slightly reduce file sizes

Use a consistent format for all alpha-values (this rule didn't require any code changes); see https://stylelint.io/user-guide/rules/alpha-value-notation
Use modern and slightly shorter color notation, since according to MDN that should be supported "everywhere" nowadays; see https://stylelint.io/user-guide/rules/color-function-notation/
Use "short" hexadecimal colors whenever possible; see https://stylelint.io/user-guide/rules/color-hex-length/
Help avoid adding broken hexadecimal colors (this rule didn't require any code changes); see https://stylelint.io/user-guide/rules/color-no-invalid-hex/

/botio-linux preview

Running makeref here, since it recently failed in PR #17075 because the branch was removed too soon.
/botio makeref

arff... my bad, sorry about that.


The extensions dont works

Issue Type: Bug
Installed any extension dont show me than is installed, but dont works. so just i have this problem
VS Code version: Code 1.47.0 (d5e9aa0227e057a60c82568bf31c04730dc15dcd, 2020-07-09T08:30:34.302Z)
OS version: Linux x64 5.4.0-40-generic snap

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-6100U CPU @ 2.30GHz (4 x 2300)

GPU Status
2d_canvas: unavailable_softwareflash_3d: disabled_softwareflash_stage3d: disabled_softwareflash_stage3d_baseline: disabled_softwaregpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: disabled_offrasterization: disabled_softwareskia_renderer: disabled_off_okvideo_decode: disabled_softwareviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
1, 2, 2

Memory (System)
7.67GB (3.03GB free)

Process Argv
--force-user-env --no-sandbox --unity-launch --no-sandbox

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Extensions (2)

Extension
Author (truncated)
Version

setting-backup
liz
0.1.4

material-icon-theme
PKi
4.2.0

Please follow these steps

Help -> Toggle Developer Tools -> Network
Then check for any network failed requests while browsing and installing the extensions if found all requests fails then its probably a proxy or DNS issue at your end.
To confirm its a DNS issue check if you can access this page https://ms-python.gallerycdn.vsassets.io/extensions/ms-python/python/2019.8.29288/1565127378610/Microsoft.VisualStudio.Services.Icons.Default, if you cannot please try configuring your DNS like pointing to <IP_ADDRESS> as suggested here? https://<IP_ADDRESS>/dns/. Otherwise please contact your network administrator.
If it is not a network issue, please share the logs from the following locations

Help -> Toggle Developer Tools -> Console
View -> Command Pallette... -> Toggle Shared Process -> Console
View -> Open View… -> Log (Shared)
View -> Open View… -> Log (Window)

Can you also please confirm if you are seeing the same issue - https://github.com/microsoft/vscode/issues/102082


Having issue in decoding audio chunks properly for fasterWhisper transcribe func

I have a HTML frontend which sends the audio chunks to the FastAPI based backend over websocket in byte form but after decoding and transcribing the result is always empty string. Can somebody help me here?
HTML Frontend

  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>Realtime WebSocket Audio Streaming</title>

Realtime WebSocket Audio Streaming

  <button id="startButton">Start Streaming</button>
  <button id="stopButton">Stop Streaming</button>

FastAPI Backend
from venv import logger
from fastapi import FastAPI, WebSocket
from fastapi.responses import HTMLResponse
from pydantic import BaseModel
from typing import Union
import re
import numpy as np

from faster_whisper import WhisperModel

model_size = "base.en"

app = FastAPI()

class ChatModel(BaseModel):
    messageType: str
    message: Union[str, bytes, None] = None
    history: list[str] = []

model = WhisperModel(model_size, device="cpu", compute_type="int8")
logger.setLevel(10)  # for debugging
# Use the static/index.html
html = open("static/index.html").read()

@app.get("/")
async def get():
    return HTMLResponse(html)

@app.websocket("/ws")
async def websocket_endpoint(websocket: WebSocket):
    await websocket.accept()
    history = list[str]()
    audioBuffer = list[bytes]()
    while True:
        data = await websocket.receive_json()
        # print(data)
        if isinstance(data, dict):  # "EOA" message
            chat = ChatModel(
                history=history,
                message=data["message"],
                messageType=data["messageType"],
            )
            if chat.messageType == "text":
                history.append(chat.message)
                chat.history = history
                await websocket.send_text(
                    f"{chat.messageType}: {chat.message} \n {chat.history}"
                )

            elif chat.message == "EOA":
                # buf = bytes(chat.message.encode("utf-8"))

                # what if this takes so long the client gives up? should send incremental results,
                # or a least pretend results, while we process
                audio_data = b"".join(audioBuffer)

                print(data)
                print(
                    f"audio buffer had {len(data)} segments, final length {len(audio_data)}"
                )

                # Save to file
                with open("audio.wav", "wb") as f:
                    f.write(audio_data)

                audio_np = (
                    np.frombuffer(audio_data, dtype=np.int16).astype(np.float32)
                    / 32768.0
                )
                segments, _ = model.transcribe(audio_np)
                print(f"Info: {_}")
                rr = []
                for segment in segments:
                    print(segment.text)
                    rr.append(segment.text)
                m = " ".join(rr)
                # print("recognition result before strip:", m)
                m = m.strip()
                # sometimes whisper puts in commentary like [soft music] and we strip that out:
                # print("recognition result before bracket re:", m)
                m = re.sub(r"\[.*\]", "", m)
                # print("recognition result after bracket re:", m)
                # was having problems with things like "He said hello" which became He said, "Hello"
                m = re.sub(r'"', '\\"', m)  # convert " to \\"
                # print("recognition result after quoting:", m)
                # send json result to konele client:
                msg = f'{{"status": 0, "result": {{"hypotheses": [{{"transcript": "{m}"}}], "final": true}}}}'
                print("msg is", msg)
                await websocket.send_text(msg)
            else:
                audioBuffer.append(chat.message.encode("utf-8"))
                print(f"audio buf now has {len(audioBuffer)} segments")```

Hello , did you find anything on this ?

I think you don't need to cast bytes to numpy array first. Using io.BytesIO, I have
async def transcript(stream: bytes):
    segments, info = model.transcribe(io.BytesIO(stream))

Also consider that streaming raw wav (i.e. unencoded) will consume a lot of bandwidth.
E.g. if you receive encoded blobparts from the ondataavailable hook, you can write append them to file, then
async def ffmpeg(filename: str):
    pipe = subprocess.run(["ffmpeg", "-i", filename, "-f", "wav", "pipe:1"], stdout=subprocess.PIPE)
    return pipe.stdout

can be piped to whisper simply through
a = await transcript(await ffmpeg(SINKFILE))

works well.


v3.0.3 Error Trying to Upgrade

Hello. I upgraded to<EMAIL_ADDRESS>just now and receive the following error:
Upgrading npm... /

Upgrading npm (fallback method)... \

We encountered an error during installation.
Please consider reporting your trouble to http://aka.ms/npm-issues.

Debug Information:

http_parser: 2.5.2 node: 4.4.7v8: <IP_ADDRESS>uv: 1.8.0 zlib: 1.2.8 ares: 1.10.1-DEVicu: 56.1 modules: 46 openssl: 1.0.2 hos: win32 x64 OS Name: Microsoft Windows 10 Enterprise Insider Preview
OS Version: 10.0.14379 N/A Build 14379

The tool also for the first time ever for me did not let me select a version to install. Please let me know if I can be of any assistance. Thanks!

I would assume that I have the same issue:
npm-windows-upgrade v3.0.3
Upgrading npm... |Checked system for npm installation:
According to PowerShell: C:\Program Files\nodejs
According to npm:        C:\Users\OliverSalzburg\AppData\Roaming\npm
Decided that npm is installed in C:\Program Files\nodejs
Upgrading npm... |? Which version do you want to install? (Use arrow keys)
> 3.10.5
  3.10.4
  3.10.3
  3.10.2
  3.10.1
  3.10.0
  3.9.6
Upgrading npm... \

Upgrading npm (fallback method)... /

We encountered an error during installation.
Please consider reporting your trouble to http://aka.ms/npm-issues.

Debug Information:

http_parser: 2.5.2node: 4.4.7v8: <IP_ADDRESS>uv: 1.8.0zlib: 1.2.8ares: 1.10.1-DEVicu: 56.1modules: 46openssl: 1.0.2hos: wi
n32 x64OS Name: Microsoft Windows 10 Pro
OS Version: 10.0.10586 N/A Build 10586

I went through the steps outlined in https://github.com/felixrieseberg/npm-windows-upgrade#fix-an-attempted-upgrade, but the result is still the same.
It should also be noted (possibly in that exact same location in the README) that deleting those folders completely destroys all your carefully set up npm link work.

I also don't get to perform any keyboard input, as @jwuliger reported. The same operation works perfectly with 2.3.1

@oliversalzburg Yep that is exactly what is happening for me.

Thanks to all of you - this is now fixed!

@felixrieseberg Thanks so much!

Works great :)


Feature: Pre-programmed scales (as in Novation's most recent firmware)

Would be great to have another setup page or something of the sort in "note" mode which provides a scales shortcut setup similar to how the somewhat recent official update provides.  32 scales pre-programmed in and accessible with one easy button.

I have implemented this on my fork, but I need to do some cleanup work before I submit a pull request.


What is the point of the 'externals' folder if we have to install software anyway?

This may be a noob question but I am new to setting up an on-premise agent. Since we have to install the software using either their native executables or by manually adding to the path, what is the point of having the prebundled software in externals like node and node-5.10.0? Because, the agent won't be able to see that software unless its manually added to the path.
I tried adding new software to the externals folder like yarn and phantomjs but it was not able to automatically recognize it. So that means I just have to install it normally, and the externals folder does even get used.
What is the proper way to use externals and for what purpose?
Lastly, externals contains node folder and in that node.exe but it doesn't include npm.cmd - so whats the point of bundling node without npm?
Agent version and platform
Version of your agent? 2.102.0/2.100.1...
2.123.0
OS of the machine running the agent? OSX/Windows/Linux...
windows 10
VSTS type and version
VisualStudio.com or On-Prem TFS?
visual studio online, on premise agent
If On-Prem TFS, which release, 2015 RTM/QU1/QU2?
If VisualStudio.com, what is your account name? http://account.visualstudio.com

The externals folder is an internal implementation detail of the agent. You should not add files there. They will be deleted when the agent updates.

OK, but where is the documentation on that? For example, there is contained node and node-5.10.1. How and when do I choose to use the correct version of node? Secondly, if I am installed node and setting the path, why does the agent require another copy of node.exe within externals? Same with git. What is the reason for having a second copy of git?

The agent internally uses node and bundles the version it uses.
On Windows the agent carries a copy of git (actually mingit or portable, i forgot). It simply reduces the setup cost. Download the agent and core dependencies are included in the download (accounts for internet disconnected scenarios).

If you need to use a specific version of node in your custom scripts then you will need to download node - note there is a Node Tool build/release task that will download a specific version of Node and add it to your PATH for the duration of the job.

@ericsciple that is incorrect, having nodejs installed (nodejs windows installer in programfiles) in the wanted version has no effect, neither does it have any effect installing a specific one with task: NodeTool@0 in yaml and even though the Agent's capabilities sections says node.js = C:\Program Files\Nodejs, tasks like gulp and grunt will use the externals node16.

@brunis Did you ever find a workaround for getting the agent to use the correct version of node? UseNode@1 doesn't seem to do anything at all.


Exception incorrectly being thrown when using SetBufferContents with a Rectangle

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
When using the Host's $host.UI.RawUI.SetBufferContents method, an exception is thrown when using a Rectangle, but not when using a Coordinate. The exception notes that an overload cannot be found with an argument count of 2, but both overloads for SetBufferContents use 2 arguments.
From what I've seen, this happens in 5.1, 7.2.6, and the newest 7.3.0-preview.8.
Expected behavior
#test message before clearing buffer
PS> $rec=[System.Management.Automation.Host.Rectangle]::new(0,0,0,10)
PS> $buffer=$host.ui.RawUI.GetBufferContents($rec)
PS> Clear-Host
PS> $host.ui.RawUI.SetBufferContents($rec,$buffer)

The exact text "PS>#test m" should be overlaid on the first line in the buffer.

Actual behavior
#test message before clearing buffer
PS> $rec=[System.Management.Automation.Host.Rectangle]::new(0,0,0,10)
PS> $buffer=$host.ui.RawUI.GetBufferContents($rec)
PS> Clear-Host
PS> $host.ui.RawUI.SetBufferContents($rec,$buffer)
MethodException: Cannot find an overload for "SetBufferContents" and the argument count: "2".

Error details
Exception             :
    Type        : System.Management.Automation.MethodException
    ErrorRecord :
        Exception             :
            Type    : System.Management.Automation.ParentContainsErrorRecordException
            Message : Cannot find an overload for "SetBufferContents" and the argument count: "2".
            HResult : -2146233087
        CategoryInfo          : NotSpecified: (:) [], ParentContainsErrorRecordException
        FullyQualifiedErrorId : MethodCountCouldNotFindBest
        InvocationInfo        :
            ScriptLineNumber : 1
            OffsetInLine     : 1
            HistoryId        : -1
            Line             : $host.ui.RawUI.SetBufferContents($rec,$buffer)
            PositionMessage  : At line:1 char:1
                               + $host.ui.RawUI.SetBufferContents($rec,$buffer)
                               + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            CommandOrigin    : Internal
        ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1
    TargetSite  : System.Object CallSite.Target(System.Runtime.CompilerServices.Closure, System.Runtime.CompilerServices.CallSite, System.Object, System.Object, System.Object)
    Message     : Cannot find an overload for "SetBufferContents" and the argument count: "2".
    Data        : System.Collections.ListDictionaryInternal
    Source      : Anonymously Hosted DynamicMethods Assembly
    HResult     : -2146233087
    StackTrace  :
   at CallSite.Target(Closure, CallSite, Object, Object, Object)
   at System.Dynamic.UpdateDelegates.UpdateAndExecute3[T0,T1,T2,TRet](CallSite site, T0 arg0, T1 arg1, T2 arg2)
   at System.Management.Automation.Interpreter.DynamicInstruction`4.Run(InterpretedFrame frame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
CategoryInfo          : NotSpecified: (:) [], MethodException
FullyQualifiedErrorId : MethodCountCouldNotFindBest
InvocationInfo        :
    ScriptLineNumber : 1
    OffsetInLine     : 1
    HistoryId        : -1
    Line             : $host.ui.RawUI.SetBufferContents($rec,$buffer)
    PositionMessage  : At line:1 char:1
                       + $host.ui.RawUI.SetBufferContents($rec,$buffer)
                       + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    CommandOrigin    : Internal
ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1

Environment data
Name                           Value
----                           -----
PSVersion                      7.3.0-preview.8
PSEdition                      Core
GitCommitId                    7.3.0-preview.8
OS                             Microsoft Windows 10.0.19044
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0ΓÇª}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals

Because $Host.UI.RawUI.GetBufferContents() is not implemented
$rec=[System.Management.Automation.Host.Rectangle]::new(0,0,10,0)
$host.ui.RawUI.GetBufferContents($rec)

MethodInvocationException:
Line |
   3 |  $host.ui.RawUI.GetBufferContents($rec)
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Exception calling "GetBufferContents" with "1" argument(s): "The method or operation is not implemented."

Because $Host.UI.RawUI.GetBufferContents() is not implemented
$Host.UI.RawUI.GetBufferContents() is not implemented on the Unix platform, this will only apply to Windows. I'll amend the description to note that.

It's good that this overload works:
void SetBufferContents(System.Management.Automation.Host.Coordinates origin, System.Management.Automation.Host.BufferCell[,] contents)

Clear-Host
Write-Host "aaaaaa`nbbbbbb`ncccccc" -F Green

$rec=[System.Management.Automation.Host.Rectangle]::new(0,0,2,2)
$buffer = $Host.UI.RawUI.GetBufferContents($rec)
$coord = [System.Management.Automation.Host.Coordinates]::new(0,0)

Clear-Host

$Host.UI.RawUI.SetBufferContents($coord, $buffer)
[console]::CursorTop = 5

It's good that this overload works (on Windows)

Yes, that's mentioned in the description and shown in one of the screenshots. The Rectangle overload not working is still unexpected behavior.

It's working as intended. SetBufferContents has 2 overloads, one that takes Coordinates + BufferCell[,] and one that takes Rectangle + BufferCell you are attempting to call it with a Rectangle + BufferCell[,] so that obviously won't work.
If your goal is to save some content, clear the screen and then reapply it then you can do it like this:
$UpperLeft        = [System.Management.Automation.Host.Coordinates]::new(0, 0)
$LowerRight       = [System.Management.Automation.Host.Coordinates]::new($Host.UI.RawUI.BufferSize.Width, 0)
$TopLineRectangle = [System.Management.Automation.Host.Rectangle]::new($UpperLeft, $LowerRight)
$TopLineContent   = $Host.UI.RawUI.GetBufferContents($TopLineRectangle)
$Host.UI.RawUI.SetBufferContents($UpperLeft, $TopLineContent)


Mirror configuration from other repos for the PR flow

Make sure you have proper setting in PR flow:

for mandatory review requirement,
ci status requirement
cla sign up requirement

Introduced changes in repo settings:
Options:

Disable Wikis feature
Disable Allow merge commits and Allow rebase merging buttons.

Colaborators:

Add for all people from CODEOWNER the Write permission.

Branches:

Require pull request reviews before merging (1 approving person and he/she needs to be a code owner)
Require status checks to pass before merging (Travis CI - Pull Request and license/cla) - also including administrators

NOTE: Currently it's configured only for master branch. When we go with the release branches then we need to add new rule for them (we can use regex for branch name e.g. release-*, and then the rules will be added for all new releases automatically)

Introduced chagnes were tested on this PR: https://github.com/kyma-project/bundles/pull/20


Implement fallback to exit() when MinGW is being used

MinGW does not have a complete libc implementation and fails to recognize quick_exit(). Just like with Apple in #25, exit() should be used instead if MinGW is detected.

Looks good, thanks!


Invalid JSON in India-Cities-Json file

First of all thanks for your work.
In the "cities.json", there seems to be some error from line# 6082 to 6095, due to which its failing JSON validator test.

Hello @jyotendra  - Track PR #11 .


Use Tray popUpContextMenu on macOS/Windows only

Description

I noticed popUpContextMenu and the right-click event are only available on macOS/Windows, so I refactored the code to use popUpContextMenu on macOS/Windows and setContextMenu on Linux. It still has the expected behavior on macOS but I haven't been able to test on Linux.
Motivation and Context

I ran into https://github.com/getferdi/ferdi/issues/484 while doing some triage and reviewed it. Reviewing the pull request @vantezzen hinted at made me double check the documentation.
Checklist:

[x] My pull request is properly named
[x] The changes respect the code style of the project ($ npm run lint)
[x] I tested/previewed my changes locally

I also note that the docs says:

If you want to keep exact same behaviors on all platforms, you should not rely on the click event and always attach a context menu to the tray icon.

We still handle the click event to implement the show/hide quickaction. I'm wondering if the click event would conflict with the context menu on Linux.

@kytwb : Makes sense !!


Preserve appropriate zoom level for search

Just a feature request, it would be nice if geosearch could get the accuracy of the search and zoom to the appropriate level if the geolocator returns that data. For example, if I search for a city name, it should show the city and not a street at the center.
Awesome work!

Current version should do just that. Although, the provider being used have to support this. The Google provider (for example) does.
Thanks for the request.


Port to plugin architecture

It was decided that probably this plugin will be a third party/runtime loaded plugin so we're beginning import to that format

Initial version up now

Initial version up now


Allow Babel experimental plugins using package.json create-react-app.…

fix for #3481
test by adding Babel Function bind transform:

run create-react-app
npm i --save-dev babel-plugin-transform-function-bind
add to package.json:

  "create-react-app": {
    "babel": {
      "plugins": [
        "transform-function-bind"
      ]
    }
  },

modify src/App.js to use the experimental bind operator:

class App extends Component {
  constructor(o) {
    super(o)

    const thisf = ::this.f // this.f.bind(this) in ancient ECMAScript 2017
    const actualThis = thisf() // if bind no work: undefined

    const isCorrect = this.isCorrect = this === actualThis
    console.log(`this correct: ${isCorrect}`)
  }

  f() {
    return this
  }

  render() {
    return (
      <div className="App">bind operator working: {String(this.isCorrect)}

verify that npm t and npm start still works…
Awesome!

Tell me how great this pull request is: ES.Next everywhere! @Timer @gaearon

conciliatory statement:
This can actually be done with less configuration.
It is clear that all experimental plugins should not always be included, because some of them have at times been known to crash Node.js or take away the super keyword. So there will be plugins that people would like to add.
Instead of having a key in Package.json, one could scan devDependencies for known BabelJS plugins and use those that are found. Zero configuration. This is similar to how one extract external values for Rollup.
Somehow this is like selling a mobile system to Vodafone: you lower your price until they call back

Please see: https://github.com/facebookincubator/create-react-app/issues/3505#issuecomment-350299866
Thanks for your contribution!


MS 365 Communications Provider

Build a provider that can send and receive emails in the context of the Communications Framework within MJ using Microsoft 365.

Note, need the component to include send and receive capabilities

This is complete with https://github.com/MemberJunction/MJ/pull/532


Run distance_transform_edt tests on all types

The existing tests for distance_transform_edt only test the function using numpy.float64 input arrays.
The arrays for other numeric types are being created in the tests, but are never passed to distance_transform_edt due to the lack of indentation after the for loops. This PR adds indentation so that distance_transform_edt is tested with all of the defined numerical types in self.types.

Nice catch! LGTM, merged.
Some of these might be worth refactoring (_edt02 test, wow), but that's separate.


[BUG] division by zero

Describe the bug
detect() fails with ZeroDivisionError
To Reproduce
from charset_normalizer import detect
detect(b'\xfe\xff')

# Traceback (most recent call last):
# ...
# File "/testvirtualenv/lib/python3.7/site-packages/charset_normalizer/probe_chaos.py", line 253, in ratio
# r_ = self.total_upper_accent_encountered if self.total_unaccented_letter_encountered / self.total_letter_encountered < 0.5 else 0
# ZeroDivisionError: division by zero

Expected behavior
from charset_normalizer import detect
assert detect(b'\xfe\xff') == {'encoding': None, 'language': '', 'confidence': None}

Desktop (please complete the following information):

OS: Debain stretch 9.11, ArchLinux
Python version 3.7

Hi,
Thank, will be fixed it next minor release. (1.3.1)

Need to change
r_ = self.total_upper_accent_encountered if self.total_unaccented_letter_encountered / self.total_letter_encountered < 0.5 else 0
#by
r_ = self.total_upper_accent_encountered if self.total_letter_encountered > 0 and self.total_unaccented_letter_encountered / self.total_letter_encountered < 0.5 else 0

len(b'\xfe\xff'.decode('utf_16'))  # print 0. I think this should raise UnicodeDecodeError


Module not found

keeps saying module not found after Ive typed in node index.js

You need to install dependencies first
npm install all

You need to install dependencies first
npm install all

I ran this command still it isnt working...the program ended with module not found again

You need to install dependencies first
npm install all

I ran this command still it isnt working...the program ended with module not found again

you need to uninstall node.js and install the latest version

not the recommended version but the newest

then you need to download latest version of python from microsoft store (its free)
then you need to download visual studio installer and install desktop development c++

ive been trouble shooting this on google all day following this error code down the rabbit hole

once youve done that npm install should work and then you run this in the terminal..
npm install -g node-gyp
and then run this in the terminal
node-gyp rebuild

last error i run into is MODULE NOT FOUND "CANVAS"

Thanks for the reply i did what you told me to when i ran node-gyp rebuild i got this:

thats where i am as well.
i believe we need to have the correct dependencies installed for the canvas
https://github.com/HashLips/hashlips_art_engine/issues/36#issuecomment-923603336

heres the wiki on installing node-gyp
https://github.com/Automattic/node-canvas/wiki/Installation:-Windows

@bengalsgrowl @divisx did you fix this?


Added nginx PHP-FPM configuration

Updated nginx config to correctly include upstream configuration for php-fpm.
I can't see any reason to give instructions for both with and without SSL, it should be easy enough to remove it if someone really wanted to for testing reasons.
Apologies for missing this.

I think there is one location rule to be added. eg. /setup returns a 404.

@iMstr is there documentation on what locations the app needs? I didn't see anything specified for apache?

@sammcj there is a .htaccess in Public/ but I found out what is needed.


Integrate with ICE

See https://jira-bsse.ethz.ch/browse/OPSK-1876

Not needed as alternative used


Fix broken version metadata

This MR fixes the -ldflags argument that is used to set metadata variables (for pelican --version).

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.


Problems w/ Implementing Crystal Graph Convolution

❓ Questions & Help
Hi!
I am doing some testing with cyrstal graph convolutions by Xie and Grossman and I just want to migrate over to PyG for more flexibility instead of using the original author's code. However I am having some trouble getting the model to train (with the identical dataset that does properly train using the author's code [I am quite sure I constructed the graphs properly, but could be wrong]). I tried looked at how the weights of the linear layers within the CGConv layers are updating and noticed that they don't seem to be updating, or with very small updates, I am not sure if this is cause of the issue but it does seem abnormal. Any other suggestions for where to look for bugs? Thanks!

This is how I implemented the CGConv and overall model (same architecture as the original paper)
class CGConv(MessagePassing):
    def __init__(self, orig_atom_fea_len, nbr_fea_len, atom_fea_len=64,
                 aggr: str = 'add', bias: bool = True, **kwargs):
        super(CGConv, self).__init__(aggr=aggr, flow='target_to_source', **kwargs)
        self.atom_fea_len = atom_fea_len
        self.nbr_fea_len = nbr_fea_len
        self.orig_atom_fea_len = orig_atom_fea_len

        self.BatchNorm1 = BatchNorm(atom_fea_len)
        self.BatchNorm2 = BatchNorm(atom_fea_len)
        self.embedding = Linear(orig_atom_fea_len, atom_fea_len)
        self.lin_f = Linear(2*atom_fea_len + nbr_fea_len, atom_fea_len, bias=bias)
        self.lin_s = Linear(2*atom_fea_len + nbr_fea_len, atom_fea_len, bias=bias)
        self.sigmoid = nn.Sigmoid()
        self.softplus1 = nn.Softplus()
        self.softplus2 = nn.Softplus()

        self.reset_parameters()

    def reset_parameters(self):
        self.lin_f.reset_parameters()
        self.lin_s.reset_parameters()

    def forward(self, x: Union[Tensor, PairTensor], edge_index: Adj,
                edge_attr: OptTensor = None, size: Size = None):
        """"""
        if x.shape[1] == self.orig_atom_fea_len:
            x = self.embedding(x)
        x = self.BatchNorm1(x)
        if isinstance(x, Tensor):
            x: PairTensor = (x, x)
        # propagate_type: (x: PairTensor, edge_attr: OptTensor)
        out = self.BatchNorm2(self.propagate(edge_index, x=x, edge_attr=edge_attr, size=size))
        out = out + x[1]
        return self.softplus1(out)

    def message(self, x_i, x_j, edge_attr: OptTensor):
        z = torch.cat([x_i, x_j, edge_attr], dim=-1)
        # print(z.shape)
        return self.sigmoid(self.lin_f(z)) * self.softplus2(self.lin_s(z))

class CrystalGraphConvNet(nn.Module):

    def __init__(self, orig_atom_fea_len, nbr_fea_len,
                 atom_fea_len=64, n_conv=3, n_conv_transfer = 2, h_fea_len=128, n_h=1,
                 classification=False, transfer = False):

        super(CrystalGraphConvNet, self).__init__()
        self.classification = classification
        self.transfer = transfer
        self.convs = nn.ModuleList([CGConv(orig_atom_fea_len=orig_atom_fea_len
                                   ,atom_fea_len=atom_fea_len,
                                    nbr_fea_len=nbr_fea_len)
                                    for _ in range(n_conv)])

        self.conv_to_fc_softplus = nn.Softplus()
        if n_h > 1:
            self.fcs = nn.ModuleList([nn.Linear(h_fea_len, h_fea_len)
                                      for _ in range(n_h-1)])
            self.softpluses = nn.ModuleList([nn.Softplus()
                                             for _ in range(n_h-1)])

        if self.classification:
            self.fc_out = nn.Linear(h_fea_len, 2)
            self.logsoftmax = nn.LogSoftmax(dim=1)
            self.dropout = nn.Dropout()
        else:
            self.fc_out = nn.Linear(h_fea_len, 1)
            self.conv_to_fc = nn.Linear(2*atom_fea_len, h_fea_len)

    def forward(self, data):
        atom_fea, bond_index, bond_attr, batch = data.x, data.edge_index, data.edge_attr, data.batch
        for conv_func in self.convs:
            atom_fea = conv_func(x=atom_fea, edge_index=bond_index, edge_attr=bond_attr)

        crys_fea = torch.cat([gap(atom_fea, batch), gmp(atom_fea, batch)], dim=1)
        crys_fea_inter = crys_fea

        crys_fea = self.conv_to_fc(self.conv_to_fc_softplus(crys_fea))
        crys_fea = self.conv_to_fc_softplus(crys_fea)

        if self.classification:
            crys_fea = self.dropout(crys_fea)

        if hasattr(self, 'fcs') and hasattr(self, 'softpluses'):
            for fc, softplus in zip(self.fcs, self.softpluses):
                crys_fea = softplus(fc(crys_fea))

        out = self.fc_out(crys_fea)
        if self.classification:
            out = self.logsoftmax(out)

        return out, crys_fea_inter

Your implementation looks correct to me, except for that the official implementation only performs global mean pooling, see here. Otherwise, it's quite hard for me to say what may go wrong here without looking at the data.

Thanks for the reply! Yeah I was playing around with the pooling method, and that isn't the thing causing the issue :(
sample_data.zip - I included two pickled lists (or do you prefer another way for me to share?), one corresponding to the graph data I constructed and the other to the original author's data format i.e

so that original_data[i][0][0] would give the node features

Let me know if you spot anything wrong with my graph data construction! Also if you need any other snippets of code, info, etc. Thanks you again!

The data is equal. However, there are many duplicated edges in there which might get filtered out in the official implementation?

Hmm, I am pretty sure the official one would just add everything up together, there isn't any further processing of the data once you input it into the model. The duplicate edges are supposed to represent the periodicity within a crystal, i.e. the edge attribute which encode the distance to the neighboring atom would be different from each parallel edge.
class ConvLayer(nn.Module):
    """
    Convolutional operation on graphs
    """
    def __init__(self, atom_fea_len, nbr_fea_len):
        """
        Initialize ConvLayer.

        Parameters
        ----------

        atom_fea_len: int
          Number of atom hidden features.
        nbr_fea_len: int
          Number of bond features.
        """
        super(ConvLayer, self).__init__()
        self.atom_fea_len = atom_fea_len
        self.nbr_fea_len = nbr_fea_len
        self.fc_full = nn.Linear(2*self.atom_fea_len+self.nbr_fea_len,
                                 2*self.atom_fea_len)
        self.sigmoid = nn.Sigmoid()
        self.softplus1 = nn.Softplus()
        self.bn1 = nn.BatchNorm1d(2*self.atom_fea_len)
        self.bn2 = nn.BatchNorm1d(self.atom_fea_len)
        self.softplus2 = nn.Softplus()

    def forward(self, atom_in_fea, nbr_fea, nbr_fea_idx):
        """
        Forward pass

        N: Total number of atoms in the batch
        M: Max number of neighbors

        Parameters
        ----------

        atom_in_fea: Variable(torch.Tensor) shape (N, atom_fea_len)
          Atom hidden features before convolution
        nbr_fea: Variable(torch.Tensor) shape (N, M, nbr_fea_len)
          Bond features of each atom's M neighbors
        nbr_fea_idx: torch.LongTensor shape (N, M)
          Indices of M neighbors of each atom

        Returns
        -------

        atom_out_fea: nn.Variable shape (N, atom_fea_len)
          Atom hidden features after convolution

        """
        # TODO will there be problems with the index zero padding?
        N, M = nbr_fea_idx.shape
        # convolution
        atom_nbr_fea = atom_in_fea[nbr_fea_idx, :]
        total_nbr_fea = torch.cat(
            [atom_in_fea.unsqueeze(1).expand(N, M, self.atom_fea_len),
             atom_nbr_fea, nbr_fea], dim=2)
        total_gated_fea = self.fc_full(total_nbr_fea)
        total_gated_fea = self.bn1(total_gated_fea.view(
            -1, self.atom_fea_len*2)).view(N, M, self.atom_fea_len*2)
        nbr_filter, nbr_core = total_gated_fea.chunk(2, dim=2)
        nbr_filter = self.sigmoid(nbr_filter)
        nbr_core = self.softplus1(nbr_core)
        nbr_sumed = torch.sum(nbr_filter * nbr_core, dim=1)
        nbr_sumed = self.bn2(nbr_sumed)
        out = self.softplus2(atom_in_fea + nbr_sumed)
        return out

I managed to solve the issue (after way too long looking at the wrong place :sweat_smile:) - everything with the convolution layer and model architecture was fine, I just wasn't careful inspecting the shape of the tensors coming out of data.y so it was messing up the loss function output and the original author's helper functions. Anyways, thanks for taking the time to help me! Greatly appreciate it.


ROX-21521: add cluster metadata for GKE and AKS

Description
This PR extends the metadata field of the cluster status by a ClusterMetadata type. It contains information that connects the secured cluster to the infrastructure resources known to the cloud provider. I've opted for a new field instead of adding it to the existing ProviderMetadata.Provider proto to allow for easier querying of the cluster type. The ProviderMetadata.Provider type (see e.g. the existing GKE name ProviderMetadata.google.clusterName) is also a bit awkward for OpenShift clusters, which may be hosted on google, but are not GKE clusters. For this reason, the cluster metadata is separated from the provider metadata. ProviderMetadata.google.clusterName is kept for backwards compatibility, and may eventually be deprecated in favor of ProviderMetadata.cluster.name.
This starts off with GKE and AKS cluster metadata, because it is the most straight forward to query from the metadata service and node labels respectively. OpenShift metadata based on the ClusterVersion/Infrastructure CRD will be added as a follow up. For EKS, there is no known method to consistently identify the cluster name. We may choose to determine it on a best effort basis.
Checklist

[ ] Investigated and inspected CI test results
[x] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
Tested metadata response on AKS and GKE.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/retest

Current dependencies on/for this PR:

master

PR #9299   👈

PR #9368

This stack of pull requests is managed by Graphite.

I verified that the cluster metadata is loaded dynamically when doing the following:

Central + Sensor deployed on version 4.3.2
Central + Sensor upgrade to PR version
/v1/clusters returns status.providerMetadata.cluster once Sensor re-connects.


Revise the add trusted network for Cloud SQL dialog.

I think that we should split the dialog into two dialogs. One dialog will contain just the list of networks, with buttons to add, delete etc... Then another dialog will allow the user to enter a new network, and will validate the entry and if it succeeds it will add the network to the list.
The current dialog is a bit confusing to use, not clear that you need two different clicks to add the network. Same with deleting a network.

Better described in #301


Wall of Browser Bugs: Stop mentioning IE11

Sounds like IE11 isn't getting non-critical fixes anymore, so there's no point in mentioning it (just like there's no point in mentioning IE10).
Help us, Edge-Wan Kenobi! You're our only hope.

Not sure this is so cut and dry:
https://support.microsoft.com/en-us/lifecycle#gp/Microsoft-Internet-Explorer
"As an example, Windows 7 SP1 running Internet Explorer with Enterprise Mode will be supported through January 14, 2020. Microsoft will also continue to invest in tools and other resources to help customers upgrade and stay up-to-date on the latest version of Internet Explorer."
I wasn't able to find a concrete source for what level of updates would still be coming down the pipe (critical vs non-critical).
I am all for Internet Explorer dying but I can see IE11 remaining in the field for a while and ignoring it may not be in the best interest of the project and/or our users.
Or I could be completely off-base with what this commit addresses and in such a case feel free to slap me around a bit with a large trout ;)

Please note that IE feature bugs are not being work on at this time unless they are security related.

From https://connect.microsoft.com/IE/feedback/details/2445370 (and I got similar comments from other IE + Edge bugs I filed in the past few months)

Roger that, thank you for the link... As you were gentlemen =)


Allow referencing a prefixed library identifier

In AngularDart, we introduced a metadata list called exports to allow top-level and static constants, methods to be used directly in an HTML template, in a type-safe way. For example:
import 'dart:math' as math;

@Component(
  selector: 'comp',
  exports: const [
    math.max,
  ],
  template: 'The biggest number is: {{math.max(10, 20)}}', // Should output "20"
)
class Comp {}

Especially with internationalization, it's common to want to create a bunch of helper methods:
class MyMessages {
    static String get categories => Intl.message(
        'Categories',
        desc: 'Label text for the title');
}

This runs against the Dart style guide (creating a class just for having static methods), but is the only declarative way a user can use our exports: [...] field:
import 'my_messages.dart' as my_messages;

@Component(
  selector: 'comp',
  exports: const [
    my_messages.MyMessages,
  ],
  template: '{my_messages.MyMessages.categories}',
)
class Comp {}

Proposal
Allow the limited use of a prefixed library identifier, perhaps just as a Symbol for now:
// my_messages.dart
String get categories => Intl.message('Categories', desc: 'Label text for the title');

import 'my_messages.dart' as my_messages;

@Component(
  selector: 'comp',
  exports: const [
    my_messages, // <-- Same as #my_messages, but valid Dart.
  ],
  template: '{my_messages.categories}',
)
class Comp {}

/cc @hterkelsen

Why don't you just use #my_messages? It's valid dart and means the same thing.
Is it because you don't get any checking that there actually is a my_messages declaration in scope?
Because ensuring that is a more general feature that I'd be quite a lot more inclined to consider :)
I would also like to have a way to write a symbol representing a program entity, so, say, #!my_messages would refer to the specific my_messages in scope, and it's an error if there isn't one (and refactoring can properly rename it).
That's a very different featrue, though. Just allowing the use of a prefix object as a value in ... some cases? Which? Always when used as a value? ... is not really a feature that's worth its own weight.
(Syntax needs more work, obviously.  Heck, I'd accept the entity-reference as the meaning of #foo, and require you to write const Symbol('foo') to get the arbitrary (and non-private only) symbol).

I think with reflection availability being that limited, it would be a great feature.
Often I add metadata to classes so that I can get classes, constructors, methods, ... by name
without depending on reflection.
Often I use code generation for this if its for a bigger set of classes, but also often I do it manually.
I think the feature carries its weight.


fix: added field roles in notifications for alert configurations, add…

Reformat code in alert configurations and its test.
Added field roles in notifications
Added field roles in tests for read, create and update

LGTM - please ensure at least one DoU approval before merging.  Thank you!!


Stop including all [storage-req] tests in lanes

Signed-off-by: Alex Kalenyuk<EMAIL_ADDRESS>
What this PR does / why we need it:
Tests that require advanced/special storage capabilities are marked with [storage-req];
Currently, [storage-req] tests from all SIGs are added to each lane that uses rook-ceph.
We might want to revisit that, as it does not make much sense for sig-migrations (for example)
to run sig-storage tests.
The sig-migrations tests which have [storage-req] will continue to run as these are a subset.
If and when we introduce other less "advanced" storage lanes
we could capitalize on [storage-req] to skip these.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/approve /hold Feel free to remove the hold once you check we are running desired tests on each lane.

Yeah going to need some help with coming up with a plan for that; is there a way to diff the test report xmls?

Are the [storage-req] skipped when ceph is not available?

/lgtm

Are the [storage-req] skipped when ceph is not available?

At the moment, no
I am hesitant to add skips now since if we ever add another fancy storage we'll likely forget about this and end up skipping loads of tests without noticing

Are the [storage-req] skipped when ceph is not available?

At the moment (and also prior to this PR) - no Since they are nested under SIGs, they get picked up regardless if == rook-ceph-default or not I am hesitant to add skips now since if we ever add another fancy storage we'll likely forget about this and end up skipping loads of tests without noticing

I don't completely understand why we have this tag... Would anybody know?

Are the [storage-req] skipped when ceph is not available?

At the moment (and also prior to this PR) - no Since they are nested under SIGs, they get picked up regardless if == rook-ceph-default or not I am hesitant to add skips now since if we ever add another fancy storage we'll likely forget about this and end up skipping loads of tests without noticing

So it looks like the way we use the label [storage-req] makes no sense. ;) Good that you remove the code.

Are the [storage-req] skipped when ceph is not available?

At the moment (and also prior to this PR) - no Since they are nested under SIGs, they get picked up regardless if == rook-ceph-default or not I am hesitant to add skips now since if we ever add another fancy storage we'll likely forget about this and end up skipping loads of tests without noticing

I don't completely understand why we have this tag... Would anybody know?

Very good question. Maybe historical reasons? Maybe some idea not implemented yet?
Anyway it is bad to have tag/label that is not used and we do not understand.

/approve /hold Feel free to remove the hold once you check we are running desired tests on each lane.

So I altered the junit merger a bit to diff junit XMLs
This is the set difference between PR #8242 and this one:
https://pastebin.mozilla.org/H3hPYvEi/raw
Sources:
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/8240/pull-kubevirt-e2e-k8s-1.23-sig-compute-migrations/1555137487230210048
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/8242/pull-kubevirt-e2e-k8s-1.23-sig-compute-migrations/1555115140918022144
As you can see, as expected we only see the [storage-req] ones there (84)
plus two extra cases that apparently don't have a fixed test name (I plan to handle this in a following commit)
/hold cancel

/test pull-kubevirt-unit-test

/approve /hold Feel free to remove the hold once you check we are running desired tests on each lane.

So I altered the junit merger a bit to diff junit XMLs This is the set difference between PR #8242 and this one: https://pastebin.mozilla.org/H3hPYvEi/raw Sources: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/8240/pull-kubevirt-e2e-k8s-1.23-sig-compute-migrations/1555137487230210048 https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/8242/pull-kubevirt-e2e-k8s-1.23-sig-compute-migrations/1555115140918022144
As you can see, as expected, we only see the [storage-req] ones there (84) plus two extra cases that apparently don't have a fixed test name (I plan to handle this in a following commit)
/hold cancel

50 minutes less! Good.
I did a look into the diff and it looks like it contains a dozen sig-compute tests, does it mean we are not running these sig-compute tests now?
Tests Suite: [rfe_id:1177][crit:medium][vendor:cnv-qe@redhat.com][level:component][sig-compute]VirtualMachine A valid VirtualMachine given [test_id:1525]should stop VirtualMachineInstance if running set to false with ContainerDisk | 0s
-- | --
Tests Suite: [rfe_id:1177][crit:medium][vendor:cnv-qe@redhat.com][level:component][sig-compute]VirtualMachine A valid VirtualMachine given [test_id:1525]should stop VirtualMachineInstance if running set to false [Serial][storage-req]with Filesystem Disk | 0s
Tests Suite: [rfe_id:1177][crit:medium][vendor:cnv-qe@redhat.com][level:component][sig-compute]VirtualMachine A valid VirtualMachine given [test_id:1525]should stop VirtualMachineInstance if running set to false [Serial][storage-req]with Block Disk

/approve /hold Feel free to remove the hold once you check we are running desired tests on each lane.

So I altered the junit merger a bit to diff junit XMLs This is the set difference between PR #8242 and this one: https://pastebin.mozilla.org/H3hPYvEi/raw Sources: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/8240/pull-kubevirt-e2e-k8s-1.23-sig-compute-migrations/1555137487230210048 https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/8242/pull-kubevirt-e2e-k8s-1.23-sig-compute-migrations/1555115140918022144
As you can see, as expected, we only see the [storage-req] ones there (84) plus two extra cases that apparently don't have a fixed test name (I plan to handle this in a following commit)
/hold cancel

50 minutes less! Good. I did a look into the diff and it looks like it contains a dozen sig-compute tests, does it mean we are not running these sig-compute tests now?
Tests Suite: [rfe_id:1177][crit:medium][vendor:cnv-qe@redhat.com][level:component][sig-compute]VirtualMachine A valid VirtualMachine given [test_id:1525]should stop VirtualMachineInstance if running set to false with ContainerDisk | 0s
-- | --
Tests Suite: [rfe_id:1177][crit:medium][vendor:cnv-qe@redhat.com][level:component][sig-compute]VirtualMachine A valid VirtualMachine given [test_id:1525]should stop VirtualMachineInstance if running set to false [Serial][storage-req]with Filesystem Disk | 0s
Tests Suite: [rfe_id:1177][crit:medium][vendor:cnv-qe@redhat.com][level:component][sig-compute]VirtualMachine A valid VirtualMachine given [test_id:1525]should stop VirtualMachineInstance if running set to false [Serial][storage-req]with Block Disk

We are comparing sig-compute-migrations vs sig-compute-migration so yeah we don't need all sig-compute tests there

I just looked at the [sig-compute] label, forgot about Migration keyword. I think we can/should simplify the script even more.
/lgtm

@xpivarc Now that I think about it, maybe we should drop storage-req from sig-storage as well?

@akalenyu  Yeah, I am not sure what the usage is right now... I can see the filtering capability of ginkgov2...


TST: bump pandas and fix resulting test failures

Turns out the windows CI doesn't respect PIP_CONSTRAINT so it started failing when pandas/numpy got updated.
This bumps everything in requirements_locked.txt to the newest version and fixes the resulting test failures.
Need to come up with a better dependabot based workflow for these.

Will cut a new release when this gets merged.

Ack turns out this is still very broken for XTAE and XKRX, will find some time to sort out what's wrong there.

Ah I need to fix my XTAE change so it works with older pandas as well.

This is great - Thanks! You can ignore the CI error, that will be fixed via https://github.com/gerrymanoim/exchange_calendars/pull/146.


Delete deprecated code

Ensure all directories, files, scripts, etc. unused by the redesigned data portal are deleted

Files/Directories related to

Processing
API layer have been addressed in PRs.

Remaining files/directories to deprecate or clean-up:

Deprecated Backend files (corpora_orm, deprecated backend.common.entities, etc)
Deprecated backend.common.utils, if any

@nayib-jose-gloria / @Bento007 : Can/should this issue be closed?

Not yet--still have a few things to clean up:

Deprecated Backend files (corpora_orm, deprecated backend.common.entities, etc)
Deprecated backend.common.utils, if any

Could spin those off into separate tickets if you prefer

If we can easily complete the remaining work this week, cool. If not, please split off into a separate issue that can be picked up by a future on-call shift.

replacing this with #4086 and #4085


Remove basePersistDirectory from tuning configs.

Since the removal of CliRealtime, the basePersistDirectory configuration serves no purpose, since it is always overridden in production using withBasePersistDirectory given some subdirectory of the task work directory.
Removing this from the tuning config has a benefit beyond removing no-longer-needed logic: it also avoids the side effect of empty "druid-realtime-persist" directories getting created in the systemwide temp directory.

while reviewing this i started to wonder if basePersistDirectory should be on the AppenderatorConfig at all anymore since its never set directly so seems a bit strange as part of the base class, but looking into how painful that would be to move somewhere for not much gain it doesn't really seem worth the effort

That was my thinking as well.


skipping ping check for registry ci

Also the ci registry does not support ping:

Thus, added a more generic mechanism to support skippings checks, with currently  an hard-coded configuration for the ping check (with some code simplifications)

Required by https://github.com/openshift/installer/pull/6898

/test images

/retest-required

/lgtm


Does is support RTL languages like arabic?

above
thanks

The sokol headers don't provide a "proper" text rendering system, they are just low level building blocks. So the answer is probably "no".
You'd need to use a special text rendering library like FreeType, and a text shaping library like Harfbuzz. Those could use sokol-gfx for the low-level triangle rendering, but everything above that us "out of scope" for the sokol headers.


[BACKLOG-14877] Adding RowHandler to BaseStep, to allow overriding

getRow/putRow/putError behavior within AEL Spark functions.

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/Trans.java
  engine/src/org/pentaho/di/trans/step/BaseStep.java
  engine/src/org/pentaho/di/trans/step/RowHandler.java
  engine/test-src/org/pentaho/di/trans/step/BaseStepTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change:  + .39%
Complexity Change:  + .51%
Instruction Change:  + .08%

org.pentaho.di.trans.step.BaseStep

Branch Change:  + .19%
Complexity Change:  + .69%
Instruction Change:  + .38%
Line Change:  + .43%
Method Change:  + 1.00%

org.pentaho.di.trans.step.BaseStep.DefaultRowHandler

Complexity New Coverage: 75.00%
Instruction New Coverage: 61.54%
Line New Coverage: 66.67%
Method New Coverage: 75.00%

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change:  + 3.12%
Complexity Change:  + 3.16%

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change:  + 2.00%
Complexity Change:  + 1.89%
Instruction Change:  + .17%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 2.35%
Complexity Change:  + 2.70%
Instruction Change:  + .18%
Line Change:  + .48%

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change:  + .18%

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change:  + 1.79%
Complexity Change:  + 1.19%
Instruction Change:  + .07%


Set unique PDF for each Actor

Add a button into the Actor title bar where you can choose a PDF file for that specific Actor which is different to the default PDF.
You could then set the default PDF to the NPC sheet, and choose the PC sheet for specific Actors.

It might be easier to add it as a popup in the context menu in the Actor sidebar.
Ask for a file, and store that in a flag on the actor.
If the file is blank, then the flag is removed.
In the PDFActorSheet check for the local flag before using the global flag.

Implemented in 0.23.0


Fix bookmarks

bookmarks are missing '""', for example
that in file dependency-injection.md contains the content: Options Model whose bookmark is invalid in file configuration.md’s output page.
If you check the content in configuration.md you can find there’s some content like the following shows:

I guess the purpose is that user want to define his own bookmark. However, the syntax is wrong, it should be

... because apparently DocFX isn't really following HTML specs. Unquoted attribute values that have values without spaces have been supported since HTML 2.0, so these should work fine for browsers.


DBZ-4641 DBZ-706 Extend external_table_clause syntax

https://issues.redhat.com/browse/DBZ-4641
https://issues.redhat.com/browse/DBZ-4706

@Naros, you had one remark; is it good to now from your PoV?

@gunnarmorling I am still working on this. And I had one question for the reporter which is not answered yet.

@Naros Could you check if the rules align properly with 19c. I haven't added any tests as some of them started failing. I will add tests after you review the syntax rules. Thanks.

I haven't added any tests as some of them started failing.

Do you have any examples of what types of SQL syntax failed?

@Naros I have added some examples of each driver as per my understanding. Mainly it fails in the LOCATION, LOAD WHEN and et_field_list rules. Also please check the et_oracle_hdfs_hive clause and its corresponding example as I am not 100% sure about its syntax rules; so it is also failing.
I have taken the examples from this documentation.

@ani-sha Here might be an exmaple too https://issues.redhat.com/browse/DBZ-4706

Here might be an exmaple too https://issues.redhat.com/browse/DBZ-4706

Yes, @jpechane, it will be fixed in this PR.

@Naros Two of the commented examples (fails in et_field_list, et_oracle_hdfs_hive clauses) don't work now, the rest all worked fine.

@Naros, that's with you for one last review, IIUC?

@ani-sha, this could need a rebase.
@Naros, this could need a review.
Thanks :)

Hi @gunnarmorling and @ani-sha I am looking at this now.  Sorry I put this off, I this is a pretty intense change and wanted to make sure I had the mindset and bandwidth to give it the proper attention.


is onViewFilter supposed to work with navigation in the Grid?

Hi
does anybody have experience with onViewFilter?
I managed for it to work and add further filtering, but it does not update number or rows, nor pages, that are displayed in the grid.
IS this suppose to work, and I found a bug, or is this a feature?

onViewFilter is for client side in memory filtering and it never updates paging which is server side.


[Feature] Support truncate(field, width) for CDC computed column

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
Currently, the cdc sync table action support add computed column. We can support truncate(field, width) expression now.
This expression can truncate a field value to specified width.
Solution
No response
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Hi, @yuzelin , I would like to take this. Thanks.


New diary UI

Is there an existing issue for this?

[X] I have searched the existing issues

What kind of idea is it?
Add or revise existing page
Who is it for?
User (Learn)
Which area (SuperOffice entity) is this related to?
Diary
Description
Update content to match new look-and-feel.
Include month, week, day, next day side-panel changes.

Would this be a good time to discuss automating screenshot capture using scripting?
--
Christian Mogensen
Product Developer
SuperOffice AS
"Any fool can write code that a computer can understand.
Good programmers write code that humans can understand."
--Martin Fowler

From: digitaldiina @.>
Sent: 14 November 2024 09:46
To: SuperOfficeDocs/superoffice-docs @.>
Cc: Subscribed @.***>
Subject: [SuperOfficeDocs/superoffice-docs] New diary UI (Issue #1493)
Is there an existing issue for this?

I have searched the existing issues

What kind of idea is it?
Add or revise existing page
Who is it for?
User (Learn)
Which area (SuperOffice entity) is this related to?
Diary
Description
Update content to match new look-and-feel.
Include month, week, day, next day side-panel changes.
—
Reply to this email directly, view it on GitHubhttps://github.com/SuperOfficeDocs/superoffice-docs/issues/1493, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA5EUBP466DEOBRKYB6ADC32ARPPRAVCNFSM6AAAAABRYLFP4OVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2TQMBXGM2DSNY.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Make data file sampling portable

Standard does not guarantee portability of <random>. While by some luck random engines are portable (except for the default_random_engine), uniform_int_distribution is not.
The problem is then that when we sample a dataset on different platforms/compilers, we get a different data. It is problematic for reproduciblity.
While it is possible to use something like boost random, I opted instead to use Lehmer random generator in place, as it is fast, easy to implement, and does what we need.

Standard does not guarantee performance portability of <random>. While by some luck random engines are portable (except for the default_random_engine), uniform_int_distribution is not.
The problem is then that when we sample a dataset on different platforms/compilers, we get a different data. It is problematic for reproduciblity.

What does that have to do with the performance portability of the standard library random number generators?  This is only about reproducibility across platforms right?

What does that have to do with the performance portability of the standard library random number generators? This is only about reproducibility across platforms right?

... and compilers. g++ and clang++ give different results.

My point was there is nothing to do with "performance portability"

Sorry. Yes, you are right, this is portability. I'm sorry, I didn't notice I wrote performance portability, my fingers are used to typing that phrase.

I forgot to ask.  Why does it matter more with the sampling and not with the generation of random cloud of points to have reproducibility?

I forgot to ask. Why does it matter more with the sampling and not with the generation of random cloud of points to have reproducibility?

We don't use random point clouds for comparing different codes, only in the unit tests/benchmarks. You could argue that the benchmarks also depend on it. That is true, but with the uniform random sampling we do it matters little.
An argument can be made for Gan-Tao generator. But I don't think we use it for cross-platform comparison. Instead, we tend to use binary files.

GCC-12 build killed (OOM?), HIP and SYLC not started (queue). All others pass with no warnings.


Seems to require Chefdk 0.2.1 or ealier...

Just downloaded Chefdk 0.2.2, and received the attached error, indicating a

Moved the dep on Chef to be a development dep as per other knife-* plugins https://github.com/chef-partners/knife-vcair/pull/25

Fixed! ce8e713b61119415a43e79e458d380b1954bc93b


added quotes around python version in README examples

I got an error running the example code:
Version 3.1 was not found in the local cache
Error: Version 3.1 with arch x64 not found
It basically treated the python version 3.10 as a float which is equivalent to 3.1 which cannot be found. I added the quotation marks to make sure it is treated as a string.

Cheers @rgerum


Provide a user-friendly interface within Backstage for editing devfile-based application configurations.

[x] #7106
[ ] #7107

/remove-lifecycle stale
/lifecycle frozen


the image field is not working

Thanks for trying the extension!
What exactly is not working with the image field?  Are you not able to save a URL?  Is the image not appearing?

it says unable to load the image beside the url box heres a screen shot


updated anthony's story to have use cases + interactors

blah

Do not merge yet, work in progress


Apply idPrefix to references in aria-labelledby

To make svgs more accessible to people with screen readers, we can make
use of a few elements and attributes:

 to set a title for the image

 to describe the image
@aria-labelledby to tell screen readers where the title and description are located in the tree

Here's some more info on how to best use them:
https://css-tricks.com/accessible-svgs/#article-header-id-6
We're using svg-inline-loader over at brigade.com to make sure every svg has unique ids, but after adding accessibility markup we noticed that the references weren't right:
Share IconPaper airline silhouette.
(I've manually removed some stuff from the above svg to make it shorter).
Notice how the references in aria-labelledby are now referencing missing ids. To fix this, we can apply the prefix here as well.

Apart from the above fix, I modified an assertion made in tests to be more robust.

Test failures seem unrelated to my changes (they work locally).


Add ability to register new static routes to add recorder client on the page

@inikulin
I suggest to create a public function like this:
testcafe.injectResource('path.js', {content, contentType});

it will be useful for these guys:
https://testcafe-discuss.devexpress.com/t/tests-using-mock-data/159
https://testcafe-discuss.devexpress.com/t/how-do-i-inject-javascript-on-dom/213/2


removes os.sep from index file path

addresses #122

Is this causing problems? Usually multiple separators are just ignored by the os

Yes. I encountered this issue while testing the package with cloud i/o: multiple separators aren't ignored by default in s3 URIs to my knowledge


⚠ Bofrost.es has degraded performance

In a384cec, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1631 ms

Resolved: Bofrost.es performance has improved in d4f6814 after 10 minutes.


CardHeader de-centered avatar

Styling in CardHeader.js de-centers avatar.
  /* Styles applied to the avatar element. */
  avatar: {
    flex: '0 0 auto',
    marginRight: 16,
  },

Current workaround (TypeScript):
const theme = createTheme({
  components: {
    MuiCardHeader: {
      styleOverrides: {
        avatar: {
          marginRight: "unset",
        },
      },
    },
  },
});

It doesn't look like this bug report has enough info for one of us to reproduce it.
Please provide a CodeSandbox (https://material-ui.com/r/issue-template-next), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve


Add v-cloak support on some components

At the moment, v-cloak doesn't work on components like Notification (because the top element is <transition> I think).
Would be nice to have it working.

This one is actually tricky, if I add an element as root the animations are gonna need a timeout to work correctly, and the root element will always have to be rendered even when closing the message/notification. I've research and every other component library also use <transition> as root. I'm probably gonna leave this way.
If you REALLY need the v-cloak I suggest that you use the native html elements with bulma classes: http://bulma.io/documentation/components/message/ and http://bulma.io/documentation/elements/notification/


Adds Filter Callback (IncomingDicomInstanceFilter)

Adds a bit of code to register an incoming dicom instance filter using FilterCallback as the callback function. Also adds a blank Anonymize function with comments explaining what to implement later.

We should try to implement an exception that we can throw for the error on FilterCallback instead of just returning -1

We should try to implement an exception that we can throw for the error on FilterCallback instead of just returning -1

I disagree, because the filter callback is supposed to return an error code. So we should presume that throwing an exception will not be caught by the caller of the filter callback. If it is we have no way of telling where or how safely the server can continue. Besides both those reasons, we shouldn't even experience server crashing errors (which might require exceptions). If we identify one then we should log an error, and potentially throw an exception if it can't be recovered from any other way.
Exception handling is expensive, so C/C++ both have a tendency of using error prevention over handling and cheap handling over exception handling. I'm sure there is some modern C++ programmer who'd argue with me, but this exemplifies my experience.

binary parsing was worked out here<EMAIL_ADDRESS>

orthanc-server  | E1107 12:39:43.419896 PluginsManager.cpp:164] Parse dicom data
orthanc-server  | E1107 12:39:43.419910 PluginsManager.cpp:164] Filter: read tag (2,0)=>2
orthanc-server  | E1107 12:39:43.419920 PluginsManager.cpp:164] Filter: read tag (2,1)=>65538
orthanc-server  | E1107 12:39:43.419926 PluginsManager.cpp:164] Filter: read tag (2,2)=>131074
orthanc-server  | E1107 12:39:43.419932 PluginsManager.cpp:164] Filter: read tag (2,3)=>196610
orthanc-server  | E1107 12:39:43.419938 PluginsManager.cpp:164] Filter: read tag (2,10)=>1048578
orthanc-server  | E1107 12:39:43.419943 PluginsManager.cpp:164] Filter: read tag (2,12)=>1179650
orthanc-server  | E1107 12:39:43.419948 PluginsManager.cpp:164] Filter: read tag (8,8)=>524296
orthanc-server  | E1107 12:39:43.419953 PluginsManager.cpp:164] Filter: read tag (8,16)=>1441800
orthanc-server  | E1107 12:39:43.419959 PluginsManager.cpp:164] Filter: read tag (8,18)=>1572872
orthanc-server  | E1107 12:39:43.419965 PluginsManager.cpp:164] Filter: read tag (8,20)=>2097160
orthanc-server  | E1107 12:39:43.419973 PluginsManager.cpp:164] Filter: read tag (8,30)=>3145736
orthanc-server  | E1107 12:39:43.419977 PluginsManager.cpp:164] Filter: read tag (8,50)=>5242888
orthanc-server  | E1107 12:39:43.419982 PluginsManager.cpp:164] Filter: read tag (8,60)=>6291464
orthanc-server  | E1107 12:39:43.419987 PluginsManager.cpp:164] Filter: read tag (8,70)=>7340040
orthanc-server  | E1107 12:39:43.419992 PluginsManager.cpp:164] Filter: read tag (8,80)=>8388616
orthanc-server  | E1107 12:39:43.419997 PluginsManager.cpp:164] Filter: read tag (8,81)=>8454152
orthanc-server  | E1107 12:39:43.420001 PluginsManager.cpp:164] Filter: read tag (8,90)=>9437192
orthanc-server  | E1107 12:39:43.420007 PluginsManager.cpp:164] Filter: read tag (8,1030)=>271581192
orthanc-server  | E1107 12:39:43.420013 PluginsManager.cpp:164] Filter: read tag (8,1050)=>273678344
orthanc-server  | E1107 12:39:43.420018 PluginsManager.cpp:164] Filter: read tag (8,2110)=>554696712
orthanc-server  | E1107 12:39:43.420023 PluginsManager.cpp:164] Filter: read tag (8,2112)=>554827784
orthanc-server  | E1107 12:39:43.420026 PluginsManager.cpp:164] Filter: nothing to do

I tested on docker, and as it turns out the parser does not get all of the data elements of the dicom file. I think because (based on the data for the elements where it stops) the dicom file nests tags under (8,2112).
Gonna need to return the the replit test code.

Okay, so the filter "works"
orthanc-server  | E1108 16:12:41.603301 PluginsManager.cpp:164] Filter: receiving dicom
orthanc-server  | E1108 16:12:41.603322 PluginsManager.cpp:164] Parse dicom data
orthanc-server  | E1108 16:12:41.603497 PluginsManager.cpp:164] filtering tag: 0010,0010
orthanc-server  | E1108 16:12:41.603514 PluginsManager.cpp:164] filtering tag: 0010,0020
orthanc-server  | E1108 16:12:41.603525 PluginsManager.cpp:164] filtering tag: 0010,0030
orthanc-server  | E1108 16:12:41.603537 PluginsManager.cpp:164] filtering tag: 0010,0040
orthanc-server  | E1108 16:12:41.604204 PluginsManager.cpp:164] Filter: compile new dicom
orthanc-server  | E1108 16:12:41.604781 PluginsManager.cpp:164] Filter: saving filtered dicom
orthanc-server  | E1108 16:12:41.605329 PluginsManager.cpp:164] Filter: cleanup

It does not, as it seems.. save anything to disk (I think, if it does I don't know where; I only checked the orthanc mount directory)


feat(tutorial): complete step 1 - Hursley

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

@asfordmatt  Looks good 💯! I've recorded your completion of step 1.


chore: make analyzer happy

fix(lint): Remove the Scrollable SemanticsNode.isMergedIntoParent assignment, now it's readonly

Thanks. Some changes because as mentioned in issuecomment-1682222117.


Don't abort installation on pressing only enter to confirm

Currently we abort because fmt.Scanln is used in a way that it requires at least one value, which newline (enter) is not.

good catch, thanks!


[BSO] missing mystery box

🐛 Bug Report
I did a daily, reward said said i got a tradable mystery box, didnt get a tradeable mystery box. I had an untradable mystery box before i opened that and then tried to open my tradable and it just wasnt there https://i.imgur.com/YfVXHRz.png https://i.imgur.com/zqQw4V8.png

resolved, if need further refund reach out to Magnaboy or a moderator.


Scenarios with Double quotes in the title do not run correctly

When I have a word quoted in my Scenario name, a "Empty test suite" error is thrown by cucumber.

Scenario: I have "quoted" text in my scenario title
Given I have a scenario title
When there are double quotes surrounding a word in my title
Then I see an error "Empty test suite" in my output log

When multiple words are quoted, a "No such file or directory - " error is thrown instead.

Scenario: Scenarios with "many quoted words" throws a completely different error
Given I have a scenario title
When there are double quotes surrounding multiple words in my title
Then I see an error "No such file or directory - quoted. You can use cucumber --init to get started." in my output log.

Please provide a stacktrace as well as what versions of cucumber and gherkin you have.

Also please provide a Gherkin document that will let us reproduce the error.
Gherkin doesn't open files, so the "No such file or directory" error is not from Gherkin. Please open a separate ticket about that in the cucumber-ruby project.

No stack trace was generated for either of these errors.
Testing started at 2:17 PM ...
See http://www.oracle.com/technetwork/database/enterprise-edition/jdbc-faq-090281.html#01_03 for supported versions
0 scenarios
0 steps
0m0.001s
Process finished with exit code 0
Empty test suite.

Testing started at 3:16 PM ...
See http://www.oracle.com/technetwork/database/enterprise-edition/jdbc-faq-090281.html#01_03 for supported versions
No such file or directory - Loan. You can use cucumber --init to get started.
Process finished with exit code 2
Empty test suite.

gem 'activerecord', '4.1.4'
gem 'activerecord-oracle_enhanced-adapter', '1.5.5'
gem 'cucumber', '2.1.0'
gem 'ffi', '1.9.9'
gem 'jruby-openssl', '0.9.12'
gem 'gherkin3', '3.1.2'
gem 'jruby-win32ole'
gem 'page-object', '0.9.6'
gem 'pdf-reader', '1.3.3'
gem 'rspec', '2.14.1'
gem 'ruby-ole', '<IP_ADDRESS>'
gem 'rubyzip', '1.1.0'
gem 'selenium-webdriver', '2.47.1'
gem 'spreadsheet'
gem 'savon', '2.3.3'

I will also contact cucumber-ruby about the file missing issue.  Also, do you need me to provide step definitions and a directory structure to run the scenarios described above?

Thanks for the versions. Now, please provide a minimal, but complete gherkin document that will reproduce this behaviour.

Running the scenarios at the feature level has made be start to think that this is related to Rubymine seven, rather than Gherkin.  However, I have attached the feature file that I used in my testing to this message, if you would like to look into it further.
quotes_error.feature.txt

The attached document parses just fine with Gherkin, so this is probably a bug in some other tool you're using (maybe rubymine)


Cannot select item.

I use adapter.setHasStableIds(true)
but when I long click on item, this happens:
Java.lang.IllegalStateException: Two different ViewHolders have the same stable ID. Stable IDs in your adapter MUST BE unique and SHOULD NOT change.      ViewHolder 1:ViewHolder{936d7aa position=0 id=-1, oldPos=-1, pLpos:-1}       View Holder 2:ViewHolder{4f3bd32 position=2 id=-1, oldPos=-1, pLpos:-1} android.support.v7.widget.RecyclerView{aaa160c VFED..... .F....ID 0,0-850,768 #7f08007f app:id/product_list_recycler_view}, adapter:com.github.ajalt.flexadapter.FlexAdapter@66b3b55, layout:android.support.v7.widget.StaggeredGridLayoutManager@7a596a
this is my item:
data class ProductItem(
    private val model: ProductItemModel,
    private val onLongClickListener: OnLongClickListener? = null
) : FlexAdapterSelectableExtensionItem(R.layout.product_item_view) {

    override fun bindItemView(itemView: View, selected: Boolean, position: Int) {
        itemView.setOnLongClickListener {
            onLongClickListener?.onLongClick(this)
            true
        }
        if (selected) {
            itemView.alpha = 0.5f
        } else {
            itemView.alpha = 1f
        }
        itemView.price.text = model.productPrice
        itemView.price_usd.text = model.productPriceUSD
        if (itemView.product_image.drawable == null){
            Picasso.get().load(model.productPicture).into(itemView.product_image)
        }
        itemView.name.text = model.productName
    }
}

I cannot figure out how this adapter is supposed to work.
All I need is to make the item selectable, show that it is selected when long click, and possibly move item around to change the product order.
I tried to use setStableIds because I had issues of items jumping around whenever trying to select them and change their background alpha, so I set this to true, but it didn't help.
I don't see any special code in your sample but it works, and my code doesnt.
any suggestions?

Support for stable ids is not in the latest release. You can use a snapshot build to get that functionality:
implementation 'com.github.ajalt:flexadapter:25191c2edc'

Let me know if it's still a problem in the snapshot.