Unable to run TGI following the instructions on the readme

System Info
uname -a
Linux a3eb1d6a21b4 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
cargo --version
cargo 1.78.0 (54d8815d0 2024-03-26)
nvidia-smi
Wed Jun 12 07:26:30 2024
+-----------------------------------------------------------------------------------------+
| NVIDIA-SMI 550.67                 Driver Version: 550.67         CUDA Version: 12.4     |
|-----------------------------------------+------------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id          Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |           Memory-Usage | GPU-Util  Compute M. |
|                                         |                        |               MIG M. |
|=========================================+========================+======================|
|   0  NVIDIA GeForce RTX 4090        On  |   00000000:81:00.0 Off |                  Off |
| 30%   28C    P8             17W /  450W |       1MiB /  24564MiB |      0%      Default |
|                                         |                        |                  N/A |
+-----------------------------------------+------------------------+----------------------+
+-----------------------------------------------------------------------------------------+
| Processes:                                                                              |
|  GPU   GI   CI        PID   Type   Process name                              GPU Memory |
|        ID   ID                                                               Usage      |
|=========================================================================================|
|  No running processes found                                                             |
+-----------------------------------------------------------------------------------------+
Information

[ ] Docker
[X] The CLI directly

Tasks

[ ] An officially supported command
[ ] My own modifications

Reproduction
(base) root@C.11121520:~$ which conda
/root/miniconda3/bin/conda
(base) root@C.11121520:~$ conda conda create -n text-generation-inference python=3.11
usage: conda [-h] [-v] [--no-plugins] [-V] COMMAND ...
conda: error: argument COMMAND: invalid choice: 'conda' (choose from 'activate', 'deactivate', 'clean', 'compare'
, 'config', 'create', 'env', 'export', 'info', 'init', 'install', 'list', 'notices', 'package', 'remove', 'uninst
all', 'rename', 'run', 'search', 'update', 'upgrade', 'content-trust', 'doctor', 'repoquery', 'build', 'develop',
 'metapackage', 'render', 'index', 'debug', 'inspect', 'convert', 'skeleton')
(base) root@C.11121520:~$ conda create -n text-generation-inference python=3.11
Channels:
 - defaults
Platform: linux-64
Collecting package metadata (repodata.json): done
Solving environment: done

## Package Plan ##

  environment location: /root/miniconda3/envs/text-generation-inference

  added / updated specs:
    - python=3.11

The following packages will be downloaded:

    package                    |            build
    ---------------------------|-----------------
    openssl-3.0.13             |       h7f8727e_2         5.2 MB
    pip-24.0                   |  py311h06a4308_0         3.3 MB
    python-3.11.9              |       h955ad1f_0        32.9 MB
    setuptools-69.5.1          |  py311h06a4308_0         1.3 MB
    wheel-0.43.0               |  py311h06a4308_0         146 KB
    ------------------------------------------------------------
                                           Total:        42.9 MB

The following NEW packages will be INSTALLED:

  _libgcc_mutex      pkgs/main/linux-64::_libgcc_mutex-0.1-main
  _openmp_mutex      pkgs/main/linux-64::_openmp_mutex-5.1-1_gnu
  bzip2              pkgs/main/linux-64::bzip2-1.0.8-h5eee18b_6
  ca-certificates    pkgs/main/linux-64::ca-certificates-2024.3.11-h06a4308_0
  ld_impl_linux-64   pkgs/main/linux-64::ld_impl_linux-64-2.38-h1181459_1
  libffi             pkgs/main/linux-64::libffi-3.4.4-h6a678d5_1
  libgcc-ng          pkgs/main/linux-64::libgcc-ng-11.2.0-h1234567_1
  libgomp            pkgs/main/linux-64::libgomp-11.2.0-h1234567_1
  libstdcxx-ng       pkgs/main/linux-64::libstdcxx-ng-11.2.0-h1234567_1
  libuuid            pkgs/main/linux-64::libuuid-1.41.5-h5eee18b_0
  ncurses            pkgs/main/linux-64::ncurses-6.4-h6a678d5_0
  openssl            pkgs/main/linux-64::openssl-3.0.13-h7f8727e_2
  pip                pkgs/main/linux-64::pip-24.0-py311h06a4308_0
  python             pkgs/main/linux-64::python-3.11.9-h955ad1f_0
  readline           pkgs/main/linux-64::readline-8.2-h5eee18b_0
  setuptools         pkgs/main/linux-64::setuptools-69.5.1-py311h06a4308_0
  sqlite             pkgs/main/linux-64::sqlite-3.45.3-h5eee18b_0
  tk                 pkgs/main/linux-64::tk-8.6.14-h39e8969_0
  tzdata             pkgs/main/noarch::tzdata-2024a-h04d1e81_0
  wheel              pkgs/main/linux-64::wheel-0.43.0-py311h06a4308_0
  xz                 pkgs/main/linux-64::xz-5.4.6-h5eee18b_1
  zlib               pkgs/main/linux-64::zlib-1.2.13-h5eee18b_1

Proceed ([y]/n)? y

Downloading and Extracting Packages:

Preparing transaction: done

Verifying transaction: done
Executing transaction: done
#
# To activate this environment, use
#
#     $ conda activate text-generation-inference
#
# To deactivate an active environment, use
#
#     $ conda deactivate

<!--- This is the problem -->

(base) root@C.11121520:~$ conda activate text-generation-inference
(text-generation-inference) root@C.11121520:~$ text-generation-launcher --model-id mistralai/Mistral-7B-Instruct-
v0.2
bash: text-generation-launcher: command not found

Expected behavior
expects TGI to be running correctly without issues since the above is copied from installation section in the readme.md

Hey @xianbaoqian, could you share a bit about what is the exact problem you're seeing? I see two problems above, and
I'm unsure of which one is affecting you, I see this one first:
(base) root@C.11121520:$ conda conda create -n text-generation-inference python=3.11
usage: conda [-h] [-v] [--no-plugins] [-V] COMMAND ...
conda: error: argument COMMAND: invalid choice: 'conda' (choose from 'activate', 'deactivate', 'clean', 'compare'
, 'config', 'create', 'env', 'export', 'info', 'init', 'install', 'list', 'notices', 'package', 'remove', 'uninst
all', 'rename', 'run', 'search', 'update', 'upgrade', 'content-trust', 'doctor', 'repoquery', 'build', 'develop',
'metapackage', 'render', 'index', 'debug', 'inspect', 'convert', 'skeleton')

Here it seems like you're calling conda twice.
I'm happy to help out, but it would be helpful if the formatting of the issue was easier to parse :hugs: thanks!

Hi @LysandreJik    the problem is that after conda activate I still can't use text-generation-launcher as the binary file can't be found:
(base) root@C.11121520:$ conda activate text-generation-inference
(text-generation-inference) root@C.11121520:$ text-generation-launcher --model-id mistralai/Mistral-7B-Instruct-
v0.2
bash: text-generation-launcher: command not found

I updated the style (surrending it with a code block) to make it easier to read. The original format is indeed a bit misleading!

Hey @xianbaoqian, thanks for clearing the style. There is definitely an issue in the code you run:
$ conda create -n text-generation-inference python=3.11
$ conda activate text-generation-inference
$ text-generation-launcher --model-id mistralai/Mistral-7B-Instruct-v0.2
bash: text-generation-launcher: command not found

Here you're only creating a new conda environment and activating it. You named it text-generation-inference, but that doesn't mean that it's installed.
If you took the example from this part of the README, it seems that you forgot this line:
+ BUILD_EXTENSIONS=True make install # Install repository and HF/transformer fork with CUDA kernels
text-generation-launcher --model-id mistralai/Mistral-7B-Instruct-v0.2

Beware: it's a long installation. Using TGI with the docker image is recommended as much faster.

I had the same issue. Resolved by adding "$HOME/text-generation-inference/target/release-opt/" to PATH.
Change $HOME to whatever your text-generation-inference directory is.


PLAT-1083 Use edx-sphinx-theme for docs

Switch the docs to use edx-sphinx-theme
Fix the Travis conditions for uploading a PyPI release
More badges on the README, and don't let them vanish on PyPI (which strips the title line)
Upgrade assorted dependencies (and ignore one of the 2 mutually exclusive new pydocstyle warnings about starting a multi-line comment)

Current coverage is 100% (diff: 100%)

Merging #4 into master will not change coverage

@@           master    #4   diff @@
===================================
  Files          12    12
  Lines         416   416
  Methods         0     0
  Messages        0     0
  Branches       48    48
===================================
  Hits          416   416
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 976078c...7d780b7

@nedbat @doctoryes Up for a review of this?

:+1:


Update init.py

Update the init.py to remove the warning of duplicated registration of the environment MujocoHandBlockEnv
Note: Very Minor change no major impact.
Description
Gym throws a user warning of duplicated registration of the environment.
Fixes # (issue)

Just removed duplicated code
Please delete options that are not relevant.

[ X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Screenshots
Please attach before and after screenshots of the change if applicable.

Checklist:

[ ] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Thank you @leonasting


fix(dsp): update imports after mistral migration update

Removing unused imports and updating the imports in the mistral module file to make sure it can be run successfully after the current mistral migration updates.

Thanks @arcAman07 !


HDFS-15795. Fix returning wrong checksum when reconstruction was fail…

…ed by exception.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
39m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 38s

trunk passed

+1 :green_heart:
compile
1m 38s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 40s

trunk passed

-1 :x:
shadedclient
6m 49s

branch has errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 37s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
3m 57s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 54s

trunk passed

-0 :warning:
patch
4m 14s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 28s

the patch passed

+1 :green_heart:
compile
1m 30s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 30s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
1m 18s

the patch passed

-0 :warning:
checkstyle
1m  1s
/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
1m 23s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 33s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
findbugs
3m  8s

the patch passed

_ Other Tests _

-1 :x:
unit
194m 20s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

319m 41s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestFsck

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2657

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 62bd850a1482 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f8769e0f4b9

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/1/testReport/

Max. process+thread count
3191 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/1/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
39m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 38s

trunk passed

+1 :green_heart:
compile
1m 38s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 40s

trunk passed

-1 :x:
shadedclient
6m 49s

branch has errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 37s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
3m 57s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 54s

trunk passed

-0 :warning:
patch
4m 14s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 28s

the patch passed

+1 :green_heart:
compile
1m 30s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 30s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
1m 18s

the patch passed

-0 :warning:
checkstyle
1m  1s
/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
1m 23s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 33s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
findbugs
3m  8s

the patch passed

_ Other Tests _

-1 :x:
unit
194m 20s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

319m 41s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestFsck

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2657

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 62bd850a1482 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f8769e0f4b9

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/1/testReport/

Max. process+thread count
3191 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/1/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
2m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 54s

trunk passed

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
0m 58s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
shadedclient
16m 13s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
3m 17s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 15s

trunk passed

-0 :warning:
patch
3m 33s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
1m  8s

the patch passed

-0 :warning:
checkstyle
0m 52s
/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 10s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 18s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
findbugs
3m  7s

the patch passed

_ Other Tests _

-1 :x:
unit
241m 23s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

332m 34s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2657

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 77a2118f48f3 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f8769e0f4b9

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/2/testReport/

Max. process+thread count
2871 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/2/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
2m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 54s

trunk passed

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
0m 58s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
shadedclient
16m 13s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
3m 17s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 15s

trunk passed

-0 :warning:
patch
3m 33s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
1m  8s

the patch passed

-0 :warning:
checkstyle
0m 52s
/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 10s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 18s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
findbugs
3m  7s

the patch passed

_ Other Tests _

-1 :x:
unit
241m 23s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

332m 34s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2657

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 77a2118f48f3 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f8769e0f4b9

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/2/testReport/

Max. process+thread count
2871 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/2/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@sodonnel Thanks for taking a look! It sounds good.
Let me fix this.

@sodonnel Thanks for taking a look! It sounds good.
Let me fix this.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 24s

trunk passed

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
shadedclient
15m 40s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
3m  4s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  1s

trunk passed

-0 :warning:
patch
3m 20s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
checkstyle
0m 53s

the patch passed

+1 :green_heart:
mvnsite
1m 10s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
12m 48s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
findbugs
3m  6s

the patch passed

_ Other Tests _

-1 :x:
unit
189m 18s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

274m 21s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2657

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 158449faff31 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fa15594ae60

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/3/testReport/

Max. process+thread count
3427 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/3/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 24s

trunk passed

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
shadedclient
15m 40s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
3m  4s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  1s

trunk passed

-0 :warning:
patch
3m 20s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
checkstyle
0m 53s

the patch passed

+1 :green_heart:
mvnsite
1m 10s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
12m 48s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
findbugs
3m  6s

the patch passed

_ Other Tests _

-1 :x:
unit
189m 18s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

274m 21s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2657

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 158449faff31 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fa15594ae60

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/3/testReport/

Max. process+thread count
3427 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2657/3/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Updated. I think the failed test is not related to this change.

Updated. I think the failed test is not related to this change.


Updating versions workflow to Java 17

What: Upgrade versions workflow to Java 17
Why: Specmatic 1.1.0 onwards works with Java 17
How: Added setups to setup-java instead of relying on the default Java versions in MacOS, Ubuntu and Windows runners since MacOS latest is picking up 12 instead of 13 (which has Java 17). Also Ubuntu and Windows still seem to be on Java 8 or 11. Runner image reference.
closes: #259

Thank you for contributing and I'm sorry for the delay!

Just released new version https://github.com/airslate-oss/setup-specmatic/releases/tag/v1.6.3

Thank you for contributing and I'm sorry for the delay!

Thanks @sergeyklay


Don't return Permerror on no host or empty TXT record

Fix for #3. But don't know if it's a good way to solve it...
The problem is that net.LookupTXT does not return a specific error if there was no TXT record. It just returns "no such host".

Why not just return the underlying error?
record, err := spf.dns.GetSPFRecord(domain)
if err != nil {
    return nil, err
}

When err is nil, you should expect a valid SPF record. Policy about what to do when there is an SPF lookup error could be implemented on a higher level.
In any case, testing for error strings is bad practice. See this post and this post about inspecting errors.

Ye you are right, thats what I thought when reading #3. I just created this fix without considering whether this is something that should be fixed :). That's why I assigned @DenBeke to validate it.
So this pull request can be deleted if @DenBeke agrees with it.


Connection refused

I have the following error :
----------Can't set data--------
REASON: connection refused
--------------------------------

I have tried with both databaseURL and authDomain from the config.
const firebaseConfig = {
  apiKey: "secret",
  authDomain: "myproject.firebaseapp.com",
  databaseURL: "https://myproject-default-rtdb.europe-west1.firebasedatabase.app",
  projectId: "myproject",
  storageBucket: "myproject.appspot.com",
  messagingSenderId: "secret",
  appId: "secret"
};

I have used the database secret :

Firmware is updated. Do I need to add a SSL certificate as well ?

The FIREBAE_HOST value is only host name without https:// scheme and back slash.
In your case it might be myproject-default-rtdb.europe-west1.firebasedatabase.app
Please make sure by go to your Firebase RTDB console and you will find the url above your database tree.
For example, if the database url is https://xxxxxxxxxxx.firebaseio.com/ then the FIREBASE_HOST will be xxxxxxxxxxx.firebaseio.com
FIREBASE_AUTH is your database secret as in your post image.
No server SSL cert required if you already update the Firmware.

You may try to renew the database secret and use the new database secret.

Thanks it works !
I have remove https:// and back slash so in my case i end up with myproject-default-rtdb.europe-west1.firebasedatabase.app.
And I have also renew the db secret.


Option to issue an MQTT message when a device is set to X%

Describe the solution you'd like
I’d like to be able to send one of many MQTT messages based on the percentage I specify in the command. If I say, “Alexa, set {device} to 17%”, then MQTT_msg_17 is sent. When MQTT_msg_17 is received, any number of actions could then be triggered. Using an Alexa routine, I could then use a descriptive trigger phrase to do what I want by executing the “set device to X%” command, resulting in locally executed commands with almost unlimited flexibility.
Describe alternatives you've considered
I believe I’ve looked at every conceivable way of sending a variety of MQTT messages via Alexa commands - both locally or with cloud usage.

I'm not sure this is a malfunction or feature request related to this module, but you can always use "mqtt out" node multiple times after each device.


batch update?

Hi Team,
i was wondering if there is a batch version for update. for example, i am using batch insert as follow
Future insertMultipleEntries(List income2) async{
await batch((batch) {
batch.insertAll(income, income2);
});
}
income is my table name and income2 is my list of income.
this insert is working nice.
now, I have a List of income with different values in their fields(every income in the list is unique) and i want to be able to do a batch update.
how do i perform the batch update?  i could not find updateAll batch procedure.  can someone show me how to do?
i dont want to loop for all element in the list and all the update function to update.
thanks in advance

i dont want to loop for all element in the list and all the update function to update

Why not? That's a valid approach to solve this. Multiple statements don't have much of a performance impact in a batch. In fact, methods like insertAll also use a for loop internally.
If every income in the list is unique, you might be able to use replaceAll.

Thanks for the quick response. Can you give me an example of how to call
replaceAll?  I updated moor to the latest version in pubspec.yaml and call
replace all like this: update(income).replaceAll(dataList)
This is giving me an error: the method replaceAll isn't defined for the
type update statement
I will appreciate if you can show me how to call replaceAll. Am I doing
something wrong?
Thanks
On Sun, Aug 23, 2020, 3:18 PM Simon Binder<EMAIL_ADDRESS>wrote:

i dont want to loop for all element in the list and all the update
function to update
Why not? That's a valid approach to solve this. Multiple statements don't
have much of a performance impact in a batch. In fact, methods like
insertAll also use a for loop internally.
If every income in the list is unique, you might be able to use replaceAll
https://pub.dev/documentation/moor/latest/moor/Batch/replaceAll.html.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/simolus3/moor/issues/782#issuecomment-678813366, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALZUB3ZJSFWYQUBREI3LCQLSCFTRFANCNFSM4QIXQCRQ
.

Inside a batch, you have to use
await batch((batch) {
  batch.replaceAll(income, dataList);
});

I'm closing question issues that are older than a year.
This is one of them.


sparse matrix element-wise multiplying dense matrix returns dense matrix

When a scipy sparse matrix element-wise multiples a dense ndarray, the returned matrix is of type matrix, which seems very inefficient, given that it is obviously a sparse matrix.
In [90]: A = scipy.sparse.csr_matrix((5, 5))

In [93]: B = np.random.randn(5, 5)

In [96]: C = A.multiply(B)

In [98]: type(C)
Out[98]: numpy.matrixlib.defmatrix.matrix

In [100]: C
Out[100]:
matrix([[-0., -0.,  0.,  0.,  0.],
        [ 0.,  0., -0., -0., -0.],
        [ 0., -0.,  0.,  0., -0.],
        [-0., -0.,  0.,  0.,  0.],
        [ 0.,  0.,  0., -0., -0.]])

Is there any reason behind this that I am missing?

I had a pull request aimed at solving this problem, but I forgot to follow up on it: #4133.
I'll look into fixing it now.

Ok, PR #5057 is pending with a fix.

That's awesome. Thanks a lot!

The thing is that a sparse-dense matrix product is not "obviously" sparse:
>>> A = csr_matrix(np.diag(np.arange(4) + 1))
>>> B = np.random.randn(4, 4)
>>> A * B
array([[ 0.52486115, -0.10865103, -1.20444296,  0.04722824],
       [-1.65310597,  1.30730895, -0.84056326, -1.15086646],
       [ 1.04445601,  5.14768672, -2.13246767, -0.10959839],
       [-1.54380663, -1.02258375, -1.81889132, -2.52211866]])

What I mean is element-wise multiplication which is obviously sparse, not matrix multiplication.

Ah! Sorry for the noise, missed that in your original post.

PR #5057 merged, so this issue can be closed now.

Great. Thanks for the help!

I don't think this issue has been fixed when broadcasting occurs. I'm running SciPy 0.18.1 and I get the following outputs:
>>> from scipy import sparse

>>> sparse.eye(4,3).multiply(np.ones((4,3)))
<4x3 sparse matrix of type '<class 'numpy.float64'>'
	with 3 stored elements in COOrdinate format>

>>> sparse.eye(4,1).multiply(np.ones((4,3)))
matrix([[ 1.,  1.,  1.],
        [ 0.,  0.,  0.],
        [ 0.,  0.,  0.],
        [ 0.,  0.,  0.]])

sparse.eye(4,1).multiply(np.ones((1,3)))
matrix([[ 1.,  1.,  1.],
        [ 0.,  0.,  0.],
        [ 0.,  0.,  0.],
        [ 0.,  0.,  0.]])

I think all these should return sparse matrix results.

@jluttine there's a proposed fix in gh-6750. Can you please check that things work as expected with that PR?


Add support to selectively generate openAPI contract for a subset of resources in the service implementation

Description:
This requirement is originally raised in this SO question https://stackoverflow.com/questions/77024253/how-can-i-tag-a-specific-resource-in-ballerina.
It will be better to have a resource level annotation support or any other mechanism to address the below use cases

selectively generate a swagger contract only for a subset of resources in the service implementation.
generate the swagger contract with tags, which users can add using resource-level openAPI annotations in their service implementation.

Describe your problem(s)
Describe your solution(s)
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Any update on this

@eyoel-fikadu Thanks for reaching out!  The current OpenAPI tool provides a well-documented Swagger for the provided service. In cases where additional details, such as capturing tags not directly obtainable from Ballerina resources, need to be manually added to the Swagger for now, we appreciate your patience with this temporary deprioritization. However, we want to reassure you that we have plans on our roadmap to address this and will make it available in a future release.


Re-enable ARMv6 builds (for Raspberry and other portable devices)

Resolve #1708

aaah the endpoint for the tests was broken due to the new website, fixed and testing again

thanks again!


Cloud Functions broken by security fix for default Cloud Build SA

Issue:
Cloud Functions v2 relies on Cloud Build in the background to deploy AR resources, so it is silently impacted by the recent platform-wide security fix with the Cloud Build Service Account Change.
Many customers also use the org policy iam.automaticIamGrantsForDefaultServiceAccounts, which is a recommended security best practice, and also now enforced by default for all new customer orgs.
The combination of these two policies means that this terraform module will always fail. Deploying Cloud Functions depends on a Cloud Build job in the background, using the default compute SA, which must havepermissions like Storage Object Viewer to the the bucket gcf-v2-sources-$PROJECTNUMBER-$REGION. See example issue at https://github.com/terraform-google-modules/terraform-example-foundation/issues/1269
Recommend Fix:

Document the dependency and troubleshooting guidance
Expose a control for the user to specify which service account is used for the underlying cloud build job. (Not sure whether the Functions API itself already supports that, or if it would require an API-level fix

Actually on further testing, this might be an issue with the upstream Functions gen 2 API rather than the terraform modules.
Trying to deploy on console with both policies in place will consistently fail., with error messages like the following:

This function has failed to deploy and will not work correctly. Please edit and redeploy.
Cloud Run service projects/$PROJECTID/locations/us-central1/services/function-1 for the function was not found. The function will not work correctly. Please redeploy.
Build failed with status: FAILURE and message: failed to Fetch: failed to download archive gs://gcf-v2-sources-$NUMBER-us-central1/function-1/function-source.zip: Access to bucket gcf-v2-sources-$NUMBER-us-central1 denied. You must grant Storage Object Viewer permission to<EMAIL_ADDRESS>. For more details see the logs at https://console.cloud.google.com/cloud-build/builds;region=us-central1/a5ed7bdf-db90-4578-97fe-1c54a713eb44?project=$NUMBER.

Fixed in #132

@prabhu34 The fix unblocks the technical issue, but I think there's still a big challenge for usage and understanding.
Going forward, this module will fail by default for all new customers (the overlapping result of changes to default IAM grants to compute service account + changes to default Cloud Build service account.  So an extra and non-intuitive step is required to make this work, even if the user thinks that the principal running the module has all the necessary permissions, one of:

add permissions to default compute SA
override org policies to use legacy behavior for cloud build SA
manually specify a build service account with sufficient privilege

I've suggested #133 , WDYT?


Added Color-game

🛠 Fixes Issue 492
fixed issue #492
👨💻 Changes proposed

✅ Check List (Check all the applicable boxes)

[ ✅] My code doesn't break any part of the project (Zero Octave-Javascript-Projects).

[✅ ] This PR does not contain plagiarized content.

[ ✅] My Addition/Changes works prop

[✅ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
📷 Screenshots

erly and matches the overall repo pattern.

same goes for this pr too as said in prev


[Misc] Move print_*_once from utils to logger

Clean up the vllm.utils file a bit by moving the print_*_once functions to the logger itself.
I'm planning further changes to the vllm.utils file. It has become quite disorganized over time.

Oh, transformers patches in this method...

@mfournioux can you take a look at this PR when you have time? I have no idea why the helm chart CI is failing.


RMT driver no longer works for some chips after updating PACs to use svd2rust 0.24

For whatever reason this update seems to have broken this driver for some of the chips. I have verified it still works on the ESP32-S2, but it has stopped working on the ESP32-C3 and ESP32-S3 for me. I do not have an ESP32 board with a neopixel on it so I cannot test this.
This obviously needs to be fixed.

[ ] ESP32
[ ] ESP32-C3
[x] ESP32-S2
[ ] ESP32-S3

@bjoernQ whenever you get a chance would you be able to test the esp32-hal/examples/hello_rgb.rs example please?

checked on ESP32 ... it lights up three random RGBs in colors that totally don't make sense .... so, I'd say it's broken

After some investigation it pretty much looks like a bug in svd2rust to me.
https://github.com/rust-embedded/svd2rust/issues/616

OK - seems that - w.ch_tx_thr_event_int_clr::<7>().set_bit()  is not the same as w.ch_tx_thr_event_int_clr(7).set_bit()
I'll look into taking this into account and fix the issue on our side


Eslint remaining fixes

@chriddyp these were the last ESLint problems in the code base. I thought activating the no-trailing-spaces rule would be nice, so I did. In case we don't need it, let's just discard the commit.

awesome stuff @rmoestl , thank you! 💃

now we can finally add eslint to our tests?

Thx @chriddyp.
Yes, I guess we can add ESLint to tests now.

FYI @chriddyp: got my hands dirty enabling ESLint in tests, see https://github.com/plotly/falcon-sql-client/commit/16683236cf6b13dddd2b78eb5cd59f88824716e8


WebSocket: send message to specific user

I'm using websocket with asyncio so my question is :

how can I send message to specific user ?

Example :
I have 1 Server using websocket and I have 2 clients using websocket. so I want to send message to first client when the second connect.
I think it should be something like : self.sendMessage(user, "some one joined!")

@deounix - This is an issue tracker, not a support forum. You should post questions like this at https://groups.google.com/forum/#!forum/autobahnws
If you're using plain WebSockets (not WAMP, which Autobahn|Python also provides) then it's entirely up to you how you do this. WebSocket does not provide any sugar here - you just send on the socket connection to the respective user.
When you use WAMP, then you can post to a topic which is specific to the user (e.g. "com.myapp.user1234.topci"), or use subscriber black- and whitelisting - http://crossbar.io/docs/Subscriber-Black-and-Whitelisting/


How to individually configure reporters output?

I just migrated from karma-remap-istanbul-reporter, and in the configuration I could configure output for istanbul reporters like this:
      reports: {
        html: 'reports/coverage',
        lcovonly: './reports/coverage/coverage.lcov',
        'text-summary': ''
      },

while it seems that I can only specify which reporters to use in your tool:
      reports: ['html', 'lcovonly', 'text-summary'],

Is there a way to configure reporters output?

Sorry the documentation on this is pretty lacking, I will go through and sort it at some point. As this is just a very thin wrapper across the istanbul-reports lib, any config that can be passed to that lib is valid. Unfortunately the docs for that don't exist either 😞
This is extracted from reading the source for each of the reports here, it should match the config you were using with karma-remap-istanbul
coverageIstanbulReporter: {
  reports: ['html', 'lcovonly', 'text-summary'],
  dir: './reports/coverage', // base output directory
  'report-config': {
    html: { // any options here are valid: https://github.com/istanbuljs/istanbul-reports/blob/master/lib/html/index.js#L134-L139
   },
   lcovonly: {
     // options from here are valid: https://github.com/istanbuljs/istanbul-reports/blob/master/lib/lcovonly/index.js#L7-L10
     file: 'coverage.lcov'
   }
  },
  fixWebpackSourcePaths: true
}

Hope that helps! 😄

Thanks, that was exactly was I was looking for!

@mattlewis92 Thanks - I just pulled this up because a similar option, karma-remap-coverage was blowing up trying to write the cobertura report whereas yours does not.
A problem I'm seeing is that the subdir option of the html reporter is not being honored. It seems no matter what I do, the html reports go to the coverage folder as a sibling to my src folder (which is actually one level up from my karma config. Furthermore, even when I don't list html in my reports list, it STILL does this. Any chance there is an issue with this?
coverageIstanbulReporter: {
      reports: ['text-summary', 'html', 'cobertura'],

      // base output directory
      dir: REPORTS_PATH,

      // if using webpack and pre-loaders, work around webpack breaking the source path
      fixWebpackSourcePaths: true,

      // Most reporters accept additional config options. You can pass these through the `report-config` option
      'report-config': {
        html: {
          subdir: 'html'
        },
        cobertura: {
          file: 'coverage.xml'
        },
        'text-summary': {
          file: null
        }
      }
    }

It's worth noting that the file property for the cobertura reporter is working just fine

What's the value of the reports_path variable? Would you be able to share a repo that demonstrates your problem that I can clone and hack about with to see if I can find a solution?

On 1 Mar 2017, at 22:12, Alex White<EMAIL_ADDRESS>wrote:
It's worth noting that the file property for the cobertura reporter is working just fine
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks @mattlewis92
REPORTS_PATH = `${__dirname}/../../build/jasmine-reports`
My project structure:

project/
++ build/
+++ jasmine-reports/ (WHERE I EXPECT the html folder)
++ api/
++ ui/
+++ src/
+++ test/
++++karma.conf.js

This variable worked fine for other reporters such as karma-remap-coverage I mentioned above

If nothing pops out for you, I can make a sample repo for you.

UPDATE: What I mentioned above is what happens without adding 'html' to reports. If I DO add it, then it's worse. It tries to do it but then it blows up with the following error:
ERROR [karma]: Error: Cannot write to absolute path: C:/Git/project/ui/src/app/index.html

I can't see anything obviously wrong with that, if you can give me a minimal sample repo I can try and debug more. I suspect it's probably an issue with the underlying Istanbul API and windows compatibility , rather than this lib specifically which is a very tiny integration between Istanbul and karma.

On 1 Mar 2017, at 22:42, Alex White<EMAIL_ADDRESS>wrote:
UPDATE: What I mentioned above is what happens without adding 'html' to reports. If I DO add it, then it's worse. It tries to do it but then it blows up with the following error:
ERROR [karma]: Error: Cannot write to absolute path: C:/Git/project/ui/src/app/index.html
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks, @mattlewis92 that's what I'm suspecting too. I bet it's the good ole / vs \ issue. If I can't figure it out, i'll create a new issue with a minimal example repo for you

Awesome, thanks 👍🏻

On 1 Mar 2017, at 22:59, Alex White<EMAIL_ADDRESS>wrote:
Thanks, @mattlewis92 that's what I'm suspecting too. I bet it's the good ole / vs \ issue. If I can't figure it out, i'll create a new issue with a minimal example repo for you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


cannot compile your code

crab-game-server-mod-main\user\Chat.cpp(104,24): error C7664: '>': ordered comparison of pointer and integer zero ('Player *' and 'int')

You have to compile in release mod and you might have to compile yourself the lib MinHook

closed #19


Improve support for multiline string

Hello, congrats for the project! I suggest that the TypeScript multiline string using ` (backticks) do get converted to Lua's multi line string using [[ ]].
Also a call to a module method like module.funcname() was improperly being translated as module:funcname()

Thanks for the issue, using [[ ]] strings is an interesting suggestion leading to potentially more readable generated code. TypeScript strings with ` are more than just multi-line strings, since they also allow string interpolation (`abc ${myVar}`), and it seems Lua's [[ ]] strings ignore any escape sequences (like \t or \n), while in TS these are considered as what they represent (a tab and a newline), so 1:1 is not possible.
Regarding your module method comment, that is probably intended behavior (on the side of the transpiler) resulting from the module's declarations. Have a look at this page: https://typescripttolua.github.io/docs/advanced/functions-and-the-self-parameter

I suggest that the TypeScript multiline string using ` (backticks) do get converted to Lua's multi line string using [[ ]].

See #667. IMO it adds a bunch of extra complexity to the code base, for something that isn't that important for readability.

@Perryvw thanks Perry, I imagined there was a method ("this: void") to deal with this situation.
@ark120202 @Perryvw "something that isn't that important for readability." now I strongly disagree. One of the strengths of Lua is code readability and simplicity and the transpiled code for multilines is just making this feature to be lost. Perhaps we can find a way to enable the Lua multiline string support

One of the strengths of Lua is code readability and simplicity and the transpiled code for multilines is just making this feature to be lost

What I mean is that multiline string literals isn't going to be the biggest problem when you'd try to measure readability of generated Lua code. There still would be nil context in all function calls, IIFEs, ____ identifiers and more patterns that are required for functional equivalence. With sourcemaps you don't really have to read generated code that often anyway.

Perhaps we can find a way to enable the Lua multiline string support from within TypeScript

It's not that hard technically, but it would be quite limited. For example, it would have to fallback to regular strings every time when there is an escaped char. There were some related discussions in the Discord channel at the time of #667.

@ark120202 To give an example on how it affects readability, I'm considering using TypeScriptToLua as part of the evolving Underscript project. Check this code example using multilines  https://github.com/felipedaragon/underscript#run-script

@ark120202 @Perryvw I just remembered there is also multiline comments in Lua: --[[ ... ]]


Check position before computing index, add const's

Thanks! I'll check why the tests fail when I get around to it.


ARMA multiyear (2019 EOFY HERON branch)

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #991
Initial Improvements
The modifications list under this heading is up to date through commit af7f4fc. More are added below.
ND ARMAs
Adds the option for the ARMA to produce higher-dimensional data on request, representing the ARMA re-evaluated for consecutive years, potentially also applying a growth factor. These realizations must be placed into a DataSet to be used effectively.
As a result of ND ARMA data, also puts the mechanics in place for the DataSet to accept ND data. As explained in the extended documentation of DataSet.addRealization, a realization with an ND variable should pass information as a ND array, and add the special key _indexMap to the realization defining the order of dimensions in the variable ND array.
As per usual, these ND arrays are only really useful to pass to another model in the EnsembleModel framework, as other entities in raven are not suitably prepared to accept ND data.
However, this paves the way for other Model entities to produce ND data in a meaningful manner and pass it to a DataSet.
ARMA Clusterability
The Clustering features accessible to the ARMA were extended to include hierarchal lists of clusterable features that can be enabled a la carte by the user. The families of features are currently global, fourier, arma, and peak.
Additionally, ClusteredROM objects can be swapped from "full" to "truncated" mode (or vice versa) both at training time and at unpickling time.
Pickled ROM Parameters
Extends the pickledROM functionality to accept fairly arbitrary inputs as parameters to its corresponding SupervisedLearning Engine, and that Engine can decide what to do with them. Right now, only the ARMA is using the mechanics, and it takes both a "reseed" value as well as Multiyear settings, so that after training, the ARMA can be sampled with multiyear settings that correspond to analysis needs.
Periodic Peaks
Documentation and clustering functionality has been added for period peak picker preprocessing performance.
Index Map
As noted in the ND ARMAs section, RAVEN now uses the hidden variable _indexMap to track the dimensionality of ND variables. This is standard throughout the DataObjects and the ARMA, and should be used when extended to other entities.
Realization Averager PostProcessor
An ND-inclusive postprocessor, the RealizationAverager takes the average of samples over the RAVEN_sample_ID variable and returns them as a single realization. When the BasicStatistics PostProcessor becomes ND-friendly, this postprocessor can be removed.
Interpolated ROMs
Functionality has been extended to make Interpolated ROMs possible. These ROMs use statepoint ROMs to determine fundamental behavior, then interpolate this fundamental behavior for missing data points. For instance, an ARMA can be trained on statepoint years, and missing years can be created through interpolation. While only applied to the ARMA thus far, the mechanics are implemented generically and can be extended to other ROMs. Note that the InterpolatedROM currently is an extension of the Clustered ROM, and so expects clustering to be present to be trained.
Property-Based ROM Construction
Mechanics have been put into place to construct a ROM from its fundamental properties, rather than training through data. The mechanics are in place generally but only used by the ARMA thus far.
RrR Tests Minor Rework
The RrR tests were renamed ("simple", "code", "rom") for brevity, and a qsub test was added to test RrR with a Code in the inner.
Minor Improvements

The RAVENparser in the RAVEN code interface was modified with the "exists_ok=True" argument in os.makedirs, preventing an occasional negligible error turning into a crash.
The RAVENparser in the RAVEN code interface was modified with the "zeroDOk=True" argument as defalut option in utils.isSingleValued(), preventing reading variable as a zero D array from custom sampler in a csv file.
Commentary added to the DataSet to explain what a "realization" should look like.
MessageHandler instances are now passed to newly-unpickled Models, and should replace any pickled instances.
A findAll method has been added to the InputData type to allow finding all subnodes of a particular name.
A renamed "simple" test for the Raven-Runs-Raven was extended to test bringing along auxiliary files to the "inner" raven running a code.
The ARMA ZeroFilter masks were swapped for more clarity in naming. Functionality remains unchanged.
Fourier calculations were moved outside the ARMA for extensibility in other modules.
Many InputData specs (including the Enum type) check xml text quality before setting values, and raise an error if it is not suitable.

Milestone-driven feature development in August
This covers after commit af7f4fc, starting with 660c15b and going through commit 347e6eb.
Optimizer

Improves functional constraint handling. Previously the rotation towards perpendicular (boundary constraint) was not behaving as expected for functional constraints; this fixes that. Note that this probably isn't the final form for the functional constraint handling, as it assumes the boundary is a plane in one dimension (a "wall") rather than a more complex constraint.
Increased number of debug statements for constraint handling and new point selection
Modularized constraint handling behavior
Improved functional constraint test model to more consistently hit constraint
Added a rotational constraint test -> this may be redundant or incomplete, needs to be checked before reviewing.

ARMA

(work by @JiaZhou-PU) masks extended to work consistently in segments, global, local
Extended zerofilter masks to apply to variables correlated with the zerofilter variable (needs cleanup before reviewing)
Allowed segmentation of multiyear scaling factors (different factors for different year ranges)
Vectorized scaling application to apply in one operation
Fixed a zerofilter bug that had it failing on the global ROM when segmenting
Now using numpy to provide VARMA state shocks instead of a multidimensional Crow dist

Pending

DMD segmenting PR, @Jimmy-INL

Checklists

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

The tests in this PR require #993 to be resolved, specifically for the mac test of Multiyear.

I discovered a further need in multiyear for interpolating clustered years based on statepoints, so I'm working on adding that to this branch.

RealizationAverager is failing for reasons that currently escape me, but I'm working on it.

Job Test CentOS 6 on 9a50877 : canceled by @JiaZhou-PU
Reach almost 4 hrs

Job Test CentOS 7 on 9a50877 : canceled by @JiaZhou-PU

Job Test Fedora 28 on 9a50877 : canceled by @JiaZhou-PU

Job Test Fedora 29 on 9a50877 : canceled by @JiaZhou-PU

Job Test OpenSUSE Leap 15 on 9a50877 : canceled by @JiaZhou-PU

Job Test Ubuntu 16 on 9a50877 : canceled by @JiaZhou-PU

Job Test linux on 9a50877 : canceled by @JiaZhou-PU

@alfoa tests are passing; ready for review.

All jobs on 0529d12 : invalidated by @PaulTalbot-INL
CIVET was undergoing a python3 migration; restarting testing.

@PaulTalbot-INL Addressed the comments.Unfortunately the test is failing.

Job Test OpenSUSE Leap 15 on 0aaf0b1 : invalidated by @PaulTalbot-INL
spurious library install failure

Checklist passed...
Closure approved.


Fix bugs for find command, Edit List command message

now able to properly search keywords across different fields
Change List Command message
Now sends message notifying user if either no person or no module has been added.

Codecov Report
Base: 62.83% // Head: 62.03% // Decreases project coverage by -0.80% :warning:

Coverage data is based on head (b32e520) compared to base (12c1bd6).
Patch coverage: 92.30% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #150      +/-   ##
============================================
- Coverage     62.83%   62.03%   -0.81%
+ Complexity      557      537      -20
============================================
  Files           103       98       -5
  Lines          1959     1907      -52
  Branches        230      219      -11
============================================
- Hits           1231     1183      -48
+ Misses          646      640       -6
- Partials         82       84       +2

Impacted Files
Coverage Δ

...java/seedu/address/logic/commands/ListCommand.java
77.77% <60.00%> (-22.23%)
:arrow_down:

...eedu/address/logic/commands/FindModuleCommand.java
100.00% <100.00%> (ø)

...eedu/address/logic/commands/FindPersonCommand.java
100.00% <100.00%> (ø)

...module/ModuleDetailsContainsKeywordsPredicate.java
100.00% <100.00%> (ø)

...person/PersonDetailsContainsKeywordsPredicate.java
100.00% <100.00%> (ø)

...odel/person/TelegramContainsKeywordsPredicate.java
0.00% <0.00%> (-71.43%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


When pressing a button before Emacs finishes loading, a letter appears

Please use the following bug reporting template to help produce actionable and reproducible issues. Please try to ensure that the reproduction is minimal so that the team can go through more bugs!

A brief description
When using Emacs (the nox version at least), pressing the arrow key during the loading sequence
makes a letter added where it shouldn't be. This causes many headaches when trying to
find compilation errors. Not sure if bug on Bash on Windows or on Emacs.

Expected results
Pressing the arrow keys should not have letters added.

Actual results (with terminal output if applicable)
Pressing an arrow key makes a letter appear. For example, the down key appends 'B' to the beginning
of the file.

Your Windows build number
14393.479

Steps / All commands required to reproduce the error from a brand new installation

Open a file in Emacs
While it's loading, press an arrow key

Strace of the failing command
n/a

Required packages and commands to install
emacs24-nox
"emacs (anything.txt)" to open a file

See our contributing instructions for assistance.

@ArchKevin22 If I'm not mistaken, is this not the same behavior you'd normally get in emacs on pure Ubuntu?

That's what I got by spamming the right arrow on loading emacs. Which is pretty similar to what I got with my WSL emacs (albeit, with more escape sequences on Ubuntu).

Yeah that looks like what I'm talking about (if the 'C' wasn't already there)
Here is a picture that makes the bug more obvious (I think it appears when pressing before vc-git is loaded?).

Who would I take this bug report to if it's not a bug with WSL? I have a very difficult time reproducing the bug on the Mac, so it leads me to believe that it's not a problem on the Mac version.

Thanks for the discussion.
Closing this issue since:

This issue is very old and has likely been fixed in recent Win10 builds
This is the WSL issues repo, but this is an issue in Console which has its own Console GitHub Repo
GitHub doesn't allow issues to be moved between repos, preserving posters' identity :(

If you have further asks/issues, please file new issues on our Console GitHub Repo.


Constructor to create UTXOInput from OutputId

Description of change
Adds the ability to create a UTXOInput from an OutputId.
Links to any relevant issues
fixes #760
Type of change
Choose a type of change, and delete any options that are not relevant.

Enhancement (a non-breaking change which adds functionality)

Closing in favour of https://github.com/iotaledger/iota-sdk/pull/847


Add external_aliases which get no cnames created for them

what

allow for aliases in Cloudfront which do not get the corresponding CNAME record created in Route53

why

Not all Cloudfront'd domains are managed in Route53
This is similar to dns_alias_enabled, but allows for a mixture of DNS providers for a single Cloudfront Distribution

@mburns are you able to please add BridgeCrew exceptions for the failing checks outlined in this PR?

Hey @mburns — I see that you reverted the BridgeCrew exceptions, was there a particular reason why?

HI @korenyoni, just troubleshooting, sorry. It looked like the errors were fixed with merging the latest master.

/test all

@mburns I'm honestly not sure why the BridgeCrew check is still failing — I will have to take a closer look tomorrow.

/test all

I'm still not sure why BC is failing in the GitHub checks API.
Originally, it was because examples/complete's module instantiation was showing up in BridgeCrew without the suppressions:

I'm not sure why it's still happening though. As you can see, it's passing in BC itself.

@mburns I've also taken over your PR and just expanded the suppression comments and moved the suppressions to the top of the resource definition blocks.
Anyways, I'm going to merge this in and hope the BC errors do not keep happening in subsequent PRs.


Allow some Endpoints to listen to messages based on a filter

Filtering would be made on routing function - it would allow an endpoint to even listen all messages, even those not meant for it.
A practical example would be LogEndpoints: a filter would avoid then receiving any messages not meant for logging.

Is there any progress on this?

This is a feature idea we had a long time ago. It would be very welcome, but AFAIK no one is working on ti.

Filtering would be really appreaciated on message id.
e.g. with the implementation of UTM_GLOBAL_POSITION message https://github.com/mavlink/mavlink/pull/1009 we have a message to report vehicle positions to air traffic management / UTM systems.
Currently all mavlink messages are forwarded to the UTM system which causes a lot of overhead.
Therefore filtering only needed messages in such a case would reduce the traffic a lot.

@dk7xe This has been implemented on #167

@Jaeyoung-Lim thank you!


Podman cp does not work when stdin is a pipe

In accordance with the Podman cp documentation

If "-" is specified for either the SRC_PATH or DEST_PATH, you can also stream a tar archive from STDIN or to STDOUT.

Works great when the file is redirected directly
podman cp - cnt:/tmp < archive.tar
But ends with an error when the archive is redirected from the pipe
cat archive.tar | podman cp - cnt:/tmp Error: error evaluating symlinks "": lstat /proc/6771/fd/pipe:[11662070]: no such file or directory
Copying from the pipe is useful when you have for example some long running process and you don’t want to save the archive locally, but stream it directly from the process to podman.
Fix if trivial. Because the error is not in reading from the pipe, but in resolving the symbolic link.

/approve
@AlekseyChudov Thanks any chance you can add a tests?

I played with this and have a concern that I'll let others weigh in on.  If the passed in file is itself a symlink, we don't evaluate it with this change.  I.e. if I do:  podman cp -  423f1b401c3d:/tmp < mylink.  In this instance we just take the symlink 'mylink' at face value and process it.  Any security or other concerns here?
It does fix the issue if everyone is playing nicely though.

@TomSweeneyRedHat This will pass in an open file descriptor to the file pointed to by the symlink.  Bash is doing all the work, and podman is only seeing the stdin fd.

@mheon @QiWang19 @vrothberg @giuseppe PTAL

LGTM once things go green

@edsantiago, are you cool if I add a system test for this one?

@vrothberg how could I complain about someone writing tests? Thank you!


tcllib: 1.18 -> 1.19

Semi-automatic update. These checks were performed:

built on NixOS
found 1.19 with grep in /nix/store/6125kc5ryhd9vxwf6j7bbdv57ajsi2hs-tcllib-1.19

Success on x86_64-darwin (full log)
Partial log (click to expand)
stripping (with command strip and flags -S) in /nix/store/9ldysxd86flmj78xq02642wq4d2kcwv1-tcllib-1.19/lib  /nix/store/9ldysxd86flmj78xq02642wq4d2kcwv1-tcllib-1.19/bin
patching script interpreter paths in /nix/store/9ldysxd86flmj78xq02642wq4d2kcwv1-tcllib-1.19
/nix/store/9ldysxd86flmj78xq02642wq4d2kcwv1-tcllib-1.19/bin/page: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/l898cxpg4rh1ba6bkm6j7qhs3rxp6jxb-tcl-8.6.6/bin/tclsh"
/nix/store/9ldysxd86flmj78xq02642wq4d2kcwv1-tcllib-1.19/bin/tcldocstrip: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/l898cxpg4rh1ba6bkm6j7qhs3rxp6jxb-tcl-8.6.6/bin/tclsh"
/nix/store/9ldysxd86flmj78xq02642wq4d2kcwv1-tcllib-1.19/bin/pt: interpreter directive changed from "/usr/bin/env tclsh" to "/nix/store/l898cxpg4rh1ba6bkm6j7qhs3rxp6jxb-tcl-8.6.6/bin/tclsh"
/nix/store/9ldysxd86flmj78xq02642wq4d2kcwv1-tcllib-1.19/bin/nnslog: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/l898cxpg4rh1ba6bkm6j7qhs3rxp6jxb-tcl-8.6.6/bin/tclsh"
/nix/store/9ldysxd86flmj78xq02642wq4d2kcwv1-tcllib-1.19/bin/nnsd: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/l898cxpg4rh1ba6bkm6j7qhs3rxp6jxb-tcl-8.6.6/bin/tclsh"
/nix/store/9ldysxd86flmj78xq02642wq4d2kcwv1-tcllib-1.19/bin/dtplite: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/l898cxpg4rh1ba6bkm6j7qhs3rxp6jxb-tcl-8.6.6/bin/tclsh"
/nix/store/9ldysxd86flmj78xq02642wq4d2kcwv1-tcllib-1.19/bin/nns: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/l898cxpg4rh1ba6bkm6j7qhs3rxp6jxb-tcl-8.6.6/bin/tclsh"
/nix/store/9ldysxd86flmj78xq02642wq4d2kcwv1-tcllib-1.19

Success on x86_64-linux (full log)
Partial log (click to expand)
patching script interpreter paths in /nix/store/6125kc5ryhd9vxwf6j7bbdv57ajsi2hs-tcllib-1.19
/nix/store/6125kc5ryhd9vxwf6j7bbdv57ajsi2hs-tcllib-1.19/bin/nnslog: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/srn388g09hjfikkq8721x5qgdsr0fb07-tcl-8.6.6/bin/tclsh"
/nix/store/6125kc5ryhd9vxwf6j7bbdv57ajsi2hs-tcllib-1.19/bin/tcldocstrip: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/srn388g09hjfikkq8721x5qgdsr0fb07-tcl-8.6.6/bin/tclsh"
/nix/store/6125kc5ryhd9vxwf6j7bbdv57ajsi2hs-tcllib-1.19/bin/nns: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/srn388g09hjfikkq8721x5qgdsr0fb07-tcl-8.6.6/bin/tclsh"
/nix/store/6125kc5ryhd9vxwf6j7bbdv57ajsi2hs-tcllib-1.19/bin/pt: interpreter directive changed from "/usr/bin/env tclsh" to "/nix/store/srn388g09hjfikkq8721x5qgdsr0fb07-tcl-8.6.6/bin/tclsh"
/nix/store/6125kc5ryhd9vxwf6j7bbdv57ajsi2hs-tcllib-1.19/bin/dtplite: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/srn388g09hjfikkq8721x5qgdsr0fb07-tcl-8.6.6/bin/tclsh"
/nix/store/6125kc5ryhd9vxwf6j7bbdv57ajsi2hs-tcllib-1.19/bin/page: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/srn388g09hjfikkq8721x5qgdsr0fb07-tcl-8.6.6/bin/tclsh"
/nix/store/6125kc5ryhd9vxwf6j7bbdv57ajsi2hs-tcllib-1.19/bin/nnsd: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/srn388g09hjfikkq8721x5qgdsr0fb07-tcl-8.6.6/bin/tclsh"
checking for references to /tmp/nix-build-tcllib-1.19.drv-0 in /nix/store/6125kc5ryhd9vxwf6j7bbdv57ajsi2hs-tcllib-1.19...
/nix/store/6125kc5ryhd9vxwf6j7bbdv57ajsi2hs-tcllib-1.19

Success on aarch64-linux (full log)
Partial log (click to expand)
patching script interpreter paths in /nix/store/jc6y8ghmqnp7w7gjl2fxjadrmg50phx3-tcllib-1.19
/nix/store/jc6y8ghmqnp7w7gjl2fxjadrmg50phx3-tcllib-1.19/bin/tcldocstrip: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/39k90lmf0bmg81vpas281xf048g6bbfz-tcl-8.6.6/bin/tclsh"
/nix/store/jc6y8ghmqnp7w7gjl2fxjadrmg50phx3-tcllib-1.19/bin/pt: interpreter directive changed from "/usr/bin/env tclsh" to "/nix/store/39k90lmf0bmg81vpas281xf048g6bbfz-tcl-8.6.6/bin/tclsh"
/nix/store/jc6y8ghmqnp7w7gjl2fxjadrmg50phx3-tcllib-1.19/bin/page: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/39k90lmf0bmg81vpas281xf048g6bbfz-tcl-8.6.6/bin/tclsh"
/nix/store/jc6y8ghmqnp7w7gjl2fxjadrmg50phx3-tcllib-1.19/bin/nnslog: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/39k90lmf0bmg81vpas281xf048g6bbfz-tcl-8.6.6/bin/tclsh"
/nix/store/jc6y8ghmqnp7w7gjl2fxjadrmg50phx3-tcllib-1.19/bin/nnsd: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/39k90lmf0bmg81vpas281xf048g6bbfz-tcl-8.6.6/bin/tclsh"
/nix/store/jc6y8ghmqnp7w7gjl2fxjadrmg50phx3-tcllib-1.19/bin/nns: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/39k90lmf0bmg81vpas281xf048g6bbfz-tcl-8.6.6/bin/tclsh"
/nix/store/jc6y8ghmqnp7w7gjl2fxjadrmg50phx3-tcllib-1.19/bin/dtplite: interpreter directive changed from " /usr/bin/env tclsh" to "/nix/store/39k90lmf0bmg81vpas281xf048g6bbfz-tcl-8.6.6/bin/tclsh"
checking for references to /build in /nix/store/jc6y8ghmqnp7w7gjl2fxjadrmg50phx3-tcllib-1.19...
/nix/store/jc6y8ghmqnp7w7gjl2fxjadrmg50phx3-tcllib-1.19


[FLINK-36622] Remove the dependency of StateBenchmark on RocksDBKeyedStateBackend APIs.

What is the purpose of the change
Currently, flink-benchmarks relies on non-public APIs in Flink. For example, in StateBackendBenchmarkUtils.java, the function compactState takes RocksDBKeyedStateBackend as its first argument.
This requires explicit type conversion in flink-benchmark(from KeyedStateBackend to RocksDBKeyedStateBackend). Moreover, this means that once the signature of RocksDBKeyedStateBackend changes, we need to modify flink-benchmark correspondingly.
Therefore, we should avoid exposing non-public APIs in StateBackendBenchmarkUtils.
Brief change log
Change the 1st argument of StateBackendBenchmarkUtils#compactState from RocksDBKeyedStateBackend to KeyedStateBackend.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@Zakelly Thanks for the comments. I've resolved them.

@flinkbot run azure

@flinkbot run azure


Use glob instead of looping over every folder

on your src/index.js
you loop over every folder inside commands manually
looping over 5 times and not being able to just add a new category on the fly would be the disadvantage for this
i'd suggest you use a package like glob
the usage part should explain you how to use it

Hi @Murky-MoMo ,
I checked the glob documentation but I would say that in this case it is not necessary to use another package unless there is absolutely no way around, but as I said this is not the case.
A possible solution could be the following:
const Path = require("path");
const FS   = require("fs");
let Files  = [];

function ThroughDirectory(Directory) {
    FS.readdirSync(Directory).forEach(File => {
        const Absolute = Path.join(Directory, File);
        if (FS.statSync(Absolute).isDirectory()) return ThroughDirectory(Absolute);
        else return Files.push(Absolute);
    });
}

ThroughDirectory("./input/directory/");

It's pretty self-explanatory. There's an input directory, and it iterates through that. If one of the items is also a directory, go through that and so on. If it's a file, add the absolute path to the array.


Disable the failover testcase

Purpose
$Subject
Issue #22992
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #23791 into ballerina-1.2.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.2.x   #23791   +/-   ##
================================================
  Coverage            14.59%   14.59%
================================================
  Files                   51       51
  Lines                 1411     1411
  Branches               219      219
================================================
  Hits                   206      206
  Misses                1189     1189
  Partials                16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf38d31...408f79d. Read the comment docs.


doc - fix instruction on removing +org-cycle-only-current-subtree-h

+org-cycle-only-current-subtree-h is being added to hook in evil-org  config, not in org's one.
Also snippet wouldn't work with local flag (last arg of  remove-hook).

Good catch! Thanks for the help!


The last line is being overwritten when width of the buffer exceeds screen width

The last line seems to be overwritten when width of the buffer exceeds screen width:

Code:
package main

import (
    "fmt"
    "time"

    "github.com/gosuri/uilive"
)

func main() {
    writer := uilive.New()

    // start listening for updates and render
    writer.Start()

    str := ""
    for i := 0; i <= 100; i++ {
        str = str + "s"
    }
    str = str + "[end]"

    for i := 0; i <= 100; i++ {
        fmt.Fprintf(writer, "%d %s\n", i, str)
        time.Sleep(time.Second)
    }

    writer.Stop() // flush and stop rendering
}

(Ref #2)

This commit on my fork works for windows too. It has a dependency on github.com/nsf/termbox-go.
Example code which works with this forked package:
package main

import (
	"fmt"
	"time"

	"github.com/apoorva/uilive"
)

func main() {
	writer := uilive.New()

	// start listening for updates and render
	writer.Start()
	uilive.InitializeTerminalWidth()

	str := ""
	for i:=0; i<200; i++ {
		str += "s"
	}

	str += "[end]"

	for i := 0; i <= 100; i++ {
		fmt.Fprintf(writer, "%d %s\n", i, str)
		time.Sleep(time.Second)
	}

	fmt.Fprintln(writer, "Finished: Downloaded 100GB")
	writer.Stop() // flush and stop rendering
}

This might be late for you but I think this could be helpful for you or someone else who might stumble over this issue:
I have made a fork of this library and have managed to fix most of the issues. I would gladly do a PR here if @gosuri is interested in reviving this package. Until then, we could collaborate and keep this wonderful package alive right here: https://github.com/asahasrabuddhe/uilive


Allow Domains in deployment plans to resync with referenced based domain

Issue and tracking information
As of now, if one were to add information such as an additional node to a domain, domains in a deployment plan that reference the modified domain will not update to include the additional node. The domain must be brought into the deployment plan and reconfigured. This is inconvenient and time consuming to do when deployment plans contain many domain configurations. It would be convenient for the domains in the deployment plan to update with the new/deleted nodes on a Repair Deployment command
Developer's time Estimated effort to fix (hours):
Developer's Actual time spent on fix (hours)
Issue reporter to provide a detailed description of the issue in the space below

We would like this fix added to both the head of papyrus and the streams/2.1.0 branch

We would like this fix added to both the head of papyrus and the streams/2.1.0 branch

papyrus and streams/2.1.x_maintenance is what we meant.

Will work on this next. Thanks

Fix merged to papyrus branch.

I verified this on our end, you can close it. Thank you


[BUG] Getting error for FormRecognizerClient StartRecognizeCustomFormsFromUri for Azure SAS Uri

Describe the bug
I was trying to FormRecognizerClient.StartRecognizeCustomFormsFromUri() using a valid model id and SAS Uri, But getting BadRequest. But the same uri can be processed by form recognizer api.
Note that, Uri is valid and if I download data using WebClient and pass it as stream content to StartRecognizeCustomForms() then it works.
Expected behavior
It should return the processed result.
Actual behavior (include Exception or Stack Trace)
Service request failed.
Status: 400 (Bad Request)
Content:
{"error":{"code":"1003","message":"Parameter 'Source' is not a valid Uri."}}
Headers:
Transfer-Encoding: chunked
x-envoy-upstream-service-time: REDACTED
apim-request-id: REDACTED
Strict-Transport-Security: REDACTED
X-Content-Type-Options: REDACTED
Date: Fri, 24 Apr 2020 12:16:36 GMT
Content-Type: application/json; charset=utf-8
| StackTrace | "   at Azure.AI.FormRecognizer.ServiceRestClient.AnalyzeWithCustomModel(Guid modelId, Nullable`1 includeTextDetails, SourcePath_internal fileStream, CancellationToken cancellationToken)\r\n   at Azure.AI.FormRecognizer.FormRecognizerClient.StartRecognizeCustomFormsFromUri(String modelId, Uri formFileUri, RecognizeOptions recognizeOptions, CancellationToken cancellationToken)\r\n   at FormV2Console.Program.d__3.MoveNext() in C:\Users\Samrat Alamgir\Desktop\Azure Congnitive\FormV2Console\FormV2Console\Program.cs:line 36" | string
To Reproduce
Steps to reproduce the behavior (include a code snippet, screenshot, or any additional information that might help us reproduce the issue)

Recognize custom forms from a URI by follow  https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/formrecognizer/Azure.AI.FormRecognizer/samples/Sample3_RecognizeCustomForms.md
Use trained modelId and a valid SAS Uri

Environment:

Azure.AI.FormRecognizer  1.0.0-preview.1
.Net Core 3.1
Visual Studio 16.4.3

Hello, @SamratAlamgir. Thanks for bringing this issue to our attention.
I have a SAS URI that points to an image stored in a blob container, but I couldn't reproduce the behavior. There could be something very particular to yours that's making it fail. What's the format of the URI you are using? Mine is something like:
https://{storageaccount}.blob.core.windows.net/images/{filename}?sp={...}&st={...}&se={...}&spr={...}&sv={...}&sr={...}&sig={...}

Also, is your model trained with labels or with forms only?
Additional information that could be helpful:
Did you happen to use other similar URIs and got the same result?
Did you happen to use other client methods with the same URI (StartRecognizeContentFromUri or StartRecognizeReceiptsFromUri)?

Hello @kinelski , Thanks for your prompt response.

I can assure you that the URI I use is correct since I could use the same URI to download the image file using WebClient and the same URI works when I use direct API call via Postman.

Here is my sample file URI after where I just replaced the storage account portion. I hope this might help you. https://{{storageaccount}}.blob.core.windows.net/kyc/01014d19-6884-4e11-9b60-ec4523dbd279/id%203.jpg?st=2020-04-24T12%3A26%3A44Z&se=2020-05-25T12%3A26%3A00Z&sp=rl&sv=2018-03-28&sr=b&sig=oc%2FPUDFKM3rXpUNEi0W8Ps%2F1b0dJf1HqPhmGwwPfQ24%3D

My model is traned with labels using the labeling tool and my OS is Windows 10 Pro.

I have tride with two different storage account and different URI and got the same.

The same URI works for StartRecognizeContentFromUri and StartRecognizeReceiptsFromUri

The same URI works if I download and pass as stream content to StartRecognizeCustomForms

Not works for the same model and URI:
Response<IReadOnlyList<RecognizedForm>> forms = await client.StartRecognizeCustomFormsFromUri(modelId, new Uri(formUri)).WaitForCompletionAsync();
Works for the same model and URI:
WebClient wc = new WebClient();
                    byte[] imageBytes = wc.DownloadData(formUri);
                    var stream = new MemoryStream(imageBytes);

Response<IReadOnlyList<RecognizedForm>> forms = await client.StartRecognizeCustomForms(modelId, stream).WaitForCompletionAsync();

I think I found a particular reason when it is not working. If the filename contains white space then it is not working. For example, id 3.jpg, id test.jpg not works but id_3.jpg and id_test.jpg works.
As this problem is occurring only for the StartRecognizeCustomFormsFromUri I hope we will get a fix for that.

@SamratAlamgir
Thanks once again for your feedback and for finding what's triggering the problem. I can confirm I'm able to reproduce it and it's in fact a bug.
I have labeled it as a bug and added it to one of our milestones. I'll post an update here and let you know once it's fixed.

I believe the issue is here:
https://github.com/Azure/azure-sdk-for-net/blob/5ab80ac686b2db2be33d3b4aa4aba72b255f4f67/sdk/formrecognizer/Azure.AI.FormRecognizer/src/FormRecognizerClient.cs#L340
The method System.Uri.ToString() returns the unescaped URL.  The property System.Uri.AbsoluteUri should be used instead.

@SamratAlamgir Thanks once again for reporting this issue. Preview 3 will be released soon and will contain the fix (#12192).

You are welcome and thanks for letting me know about the update.


Need new Icon for psake

Something that can be used on NuGet.org and Chocolatey.org, and anywhere else that psake is published.
Any ideas?

With the mention of publishing on PSGallery i thought i'd give this a shot. I pulled some colors off of the original logo. simple sake cups (with PowerShell logo), stacked (kinda representing the stacking of tasks in PSake).

Ooo, I really like this idea!  This would get a thumbs up from me!
@damianh @dlwyatt what are your thoughts on these?

I'm exactly the wrong person to ask about aesthetics.  I have the artistic judgment and skills of a blind, drunk yak.  :P

Ha ha :smile:
Let's put it this way, The above is far better than anything I would be able to come up with.  So if there are no other takers, I am happy to run with them.  I prefer the left hand side one.

@gep13 I'll put together an set of images with common sizes for chocolatey, nuget, psgallery, etc. Is there a place I should upload this collateral to?

@sweeneyrobb yes, let's put these over here:
https://github.com/psake/graphics

@sweeneyrobb perhaps something like this:
https://github.com/cake-build/graphics
Where we separate out the source files, with the usable media.  What do you think?

@gep13 yep, that's the goal.

@gep13
i just added a PR (https://github.com/psake/graphics/pull/1) in the psake/graphics repo. Let me know if there are any issues.

I like! :)
On 3 Mar 2016 9:22 p.m., "Gary Ewan Park"<EMAIL_ADDRESS>wrote:

Ooo, I really like this idea! This would get a thumbs up from me!
@damianh https://github.com/damianh @dlwyatt
https://github.com/dlwyatt what are your thoughts on these?
—
Reply to this email directly or view it on GitHub
https://github.com/psake/psake/issues/148#issuecomment-191946338.

Looks awesome !!

@sweeneyrobb thanks again for doing this! I really like the new icons :smile:


Overnight benchmarks - find a valid issue assignee

🚀 Pull Request
Description

Fixes a problem where the benchmark action attempts to assign the issue it is creating to a non-existent user (e.g. github-actions as in this example).

Consult Iris pull request check list

Thanks @stephenworsley!