Add link to the Apache Confluence wiki

Should also add topic info the Slack channel.

https://cwiki.apache.org/confluence/display/OPENWHISK/OpenWhisk+Home

@mrutkows What sort of text should we add describing the purpose of this wiki and its intent relative to other channels of info?


[gha] Require add/remove fields to hyuperjump-labels

Small actions fix

@bors-libra r+

:pushpin: Commit 64f6aea has been approved by bmwill

:hourglass: Testing commit 64f6aea1402d7922965d3b74cb2e00aae816c6db with merge 307c1f91892db6c737c01e8953cf3031c1dd6ec0...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: bmwill
Pushing 307c1f91892db6c737c01e8953cf3031c1dd6ec0 to master...


KeyError: 'YJFragmentList get has multiple matches

This has worked mostly well with the books I have attempted, except for this one: B0BPX4YJ8V
Microsoft Windows [Version 10.0.22631.3085]
(c) Microsoft Corporation. All rights reserved.

D:\comix-main>python unkindle.py B0BPX4YJ8V
Authenticating . . .
Logged in with saved state
Authenticated!
Download size: 124MB
Downloading the book . . . 97%
Extracting . . .
Traceback (most recent call last):
  File "D:\comix-main\unkindle.py", line 188, in <module>
    kindle.download(args.output, args.keep_temp)
  File "D:\comix-main\unkindle.py", line 138, in download
    metadata = self.book.get_metadata()
               ^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\comix-main\third_party\kfxlib\yj_book.py", line 156, in get_metadata
    if self.has_metadata() and self.has_cover_data():
       ^^^^^^^^^^^^^^^^^^^
  File "D:\comix-main\third_party\kfxlib\yj_metadata.py", line 246, in has_metadata
    self.fragments.get(YJFragmentKey(ftype="$258")) is not None)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\comix-main\third_party\kfxlib\yj_container.py", line 322, in get
    raise KeyError("YJFragmentList get has multiple matches for %s: %s" % (repr(key), list_symbols(matches)))
KeyError: 'YJFragmentList get has multiple matches for $258::: $258::, $258::'

D:\comix-main>

I have tried to delete the output folder it created, then retrying the process from the start, but continue to get the same error each time. It seems to always happen after the "download" gets to 97% and begins to extract, then error.
Other books before this one and after, have not received any errors on my end. My script knowledge is extremely limited so I don't know how to troubleshoot.

I received the same error (on a different book), and like you, the error always appeared after the downloading was complete and the extraction process started.  I never found a solution, but I was able to successfully grab the book by using the less elegant method discussed in a previous thread (use an Android emulator, import into Calibre, then use the terminal to extract).  Obviously that doesn't solve this problem, but I was able to grab the book I was after!

For what it's worth, I ran into this issue on a few books now.  Luckily, on failure, even without --keep_temp, the tool leaves the downloaded files in the temp folder. I was able to import the KFX into Calibre by adding just one of the KFX files in the temp folder.
I hit a second issue using Calibre to convert the KFX due to noDRM/DeDRM_tools#1818 in each of my cases of the first error. Maybe it is correlated?
Thankfully, I was able to convert it successfully using the KFX Input plugin CLI, as the conversion error message suggests.
These were the affected ASIN I have encountered so far:

B01GT6BLX8
B00F3HK6TA
B071NX66W6

Weirdly, books in the same series worked fine, so it seems kinda random. Hopefully this context is helpful.

For what it's worth, I ran into this issue on a few books now. Luckily, on failure, even without --keep_temp, the tool leaves the downloaded files in the temp folder. I was able to import the KFX into Calibre by adding just one of the KFX files in the temp folder.
For each case of the first issue, I hit a second issue using Calibre to convert the KFX due to noDRM/DeDRM_tools#1818. ~Maybe related?~ Edit: I realize now Calibre simply does not support converting fixed-layout KFX books directly, i.e. comics.
To work around the Calibre conversion limitations, I was able to use the KFX Input plugin CLI, as the conversion error message suggests.
These were the affected ASIN I have encountered so far:

B01GT6BLX8
B00F3HK6TA
B071NX66W6

Weirdly, books in the same series worked fine, so it seems kinda random. Hopefully this context is helpful.

can you explain how you did this? I am having the same issue now

can you explain how you did this? I am having the same issue now

If you have Calibre and the KFX Input plug-in installed on your computer, then you should be able to use the command line to decrypt the book into any supported format of your choosing.
Take a look at the Command Line Interface section here.
As a tip, you only need to specify any one single kfx, azw, etc. file from the folder that contains the files, and it will properly detect the related files and decrypt them into a single book.

can you explain how you did this? I am having the same issue now

If you have Calibre and the KFX Input plug-in installed on your computer, then you should be able to use the command line to decrypt the book into any supported format of your choosing.
Take a look at the Command Line Interface section here.
As a tip, you only need to specify any one single kfx, azw, etc. file from the folder that contains the files, and it will properly detect the related files and decrypt them into a single book.


Update sbt-site to 1.4.0

Updates com.typesafe.sbt:sbt-site from 1.3.3 to 1.4.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.sbt", artifactId = "sbt-site" } ]

labels: sbt-plugin-update, semver-minor

This inlined syntax is valid even in Verilog 95, according to IEEE Std 1364-1995
"IEEE Standard Hardware Description Language Based on the Verilog® Hardware Description Language"
(See page 37)


Changing the default theme?

What package is this for?

[X] React
[ ] Angular
[ ] Both

Summary
Hi all! First, thanks for an awesome set of components. They cover just about everything imaginable and make creating an app so much easier.
TL;DR: how do we use a theme other than G10? The guides at carbondesignsystem.com do not seem to work and we haven't found a good pointer online for using SCSS. We've tried a bunch of different approaches with no success.

I'm trying to switch a project from carbon-components-react to carbon-addons-iot-react and noted that the default theme is G10 inside styles.scss.
@import '~@carbon/themes/scss/themes';
$carbon--theme: $carbon--theme--g10;
// Use the gray 10 theme
@include carbon--theme();

Reviewing https://www.carbondesignsystem.com/guidelines/themes/code, I haven't been able to figure out a way to override the G10 theme back to white. If I bring in theme above the styles.scss import in our project's index.scss, it gets ignored. If I try to inline it like their examples, it doesn't make a difference. My short term workaround was to copy the contents of styles.scss into my index.scss, but that doesn't work well in the long run. I also rebuilt node-sass at a few points to see if it'd make a difference, but didn't succeed.
Thanks!

I would ask why you need this... what designer is not using the Grey10 theme in our business unit?

@chad-ithreat   Can you give me some examples of what design you are attempting to achieve?  If you are just trying to render a "white" style component (perhaps because the background of your page is white, and many Grey10 components lacks contrast with white backgrounds), you can try to use the "light" and "dark" properties, which will change the background contrast colors. However, we do not want to support the darker themes (Grey 100 or Grey 90) in the PAL repo at this time.


Bug: Consult narrowing is broken due to recent Selectrum refactoring

The offending commit is https://github.com/raxod502/selectrum/commit/b4629202d7336d0eeda20b24686401ad696e1db2, found via bisect. It worked before that commit and it still works with icomplete. Some problem with the predicate. My suggestion would be to revert b4629202d7336d0eeda20b24686401ad696e1db2 at first.

Okay now I understand the problem - my predicate relies on being executed in the minibuffer :(

Okay now I understand the problem - my predicate relies on being executed in the minibuffer :(

The commit was to speed up for describe-variable, why does narrowing need the minibuffer buffer to be current?

The commit was to speed up for describe-variable, why does narrowing need the minibuffer buffer to be current?

@clemera It relies on minibuffer local variables.

@clemera It relies on minibuffer local variables.

I agree the buffer switch can always be unexpected. Ivy does compute the candidates before even entering the minibuffer. In the light of this I think special casing is probably the best here.

I agree the buffer switch can always be unexpected. Ivy does compute the candidates before even entering the minibuffer. In the light of this I think special casing is probably the best here.

Maybe it makes sense to special case the exact predicate function. I guess it is a named predicate for describe-variable, not a lambda?

Maybe it makes sense to special case the exact predicate function. I guess it is a named predicate for describe-variable, not a lambda?

No, it is a lambda I think we can do it for #'help--symbol-completion-table

No, it is a lambda I think we can do it for #'help--symbol-completion-table

@clemera Okay, that's also good!

@clemera Okay, that's also good!

The other commands that use it are describe-function and describe-symbol and they do no buffer switching so they wouldn't be slowed down by this

The other commands that use it are describe-function and describe-symbol and they do no buffer switching so they wouldn't be slowed down by this

Can be closed?

Can be closed?


Set exist_ok = True while creating the backend

We would like to add a feature to continue search in autoPyTorch. For this to function, we need to be able to create a backend without an error being raised, which is done here. This PR aims to remove this bottleneck. Still, an error will be raised if the user attempts to call search again, see here.

Hi Ravin, just to make sure we do not somehow affect auto-sklearn, can you make it so that this is an argument to the backend? Like exist_ok by default false, and then we can also make sure that within autopytorch, the continue search method assert this flags when needed.
Maybe also auto-sklearn sees a benefit of the backend being able to see another configuration search re-start, but @mfeurer would have to confirm.

Hi Ravin, just to make sure we do not somehow affect auto-sklearn, can you make it so that this is an argument to the backend? Like exist_ok by default false, and then we can also make sure that within autopytorch, the continue search method assert this flags when needed.
Maybe also auto-sklearn sees a benefit of the backend being able to see another configuration search re-start, but @mfeurer would have to confirm.

sure

Hi, I did not notice this PR and this PR overlaps with PR#8.
I do not know how we should handle, but this PR overwrites the existing files without warning and mine asks if we should delete the existing files and create a new one.
Which one is better?
I think it is better to at least warn if the users are ok with overwriting files.

I think it can be merged


MSS620 - Multi channel device not functioning

What issue do you have? Please be as thorough and explicit as possible.
MSS620 switch stopped functioning after recent update
Details of your setup.

Do you use (1) Homebridge UI-X (2) Homebridge CLI or (3) HOOBS?

(1)

Which version of Homebridge/HOOBS do you have?

Homebridge v1.3.4

Which platform do you run Homebridge/HOOBS on (e.g. Raspberry Pi/Windows/HOOBS Box)? Please also mention your version of Node.js/NPM if known.

VirtualBox - Ubuntu
Linux homebridge 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Which version of this plugin (homebridge-meross) do you have? Has the issue started since upgrading from a previous version?

homebridge-meross v6.8.0
Yes, issue started after upgrading from v6.7.1 or v6.7.2 (didn't noticed but was functional on v6.x)

Which Meross devices do you have that are causing issues? Please include product models if applicable.

MSS620
Please paste any relevant logs below.

[8/24/2021, 10:00:10 PM] [Meross] [Insect Trap SW1] has been added to Homebridge.
[8/24/2021, 10:00:10 PM] [Meross] [Insect Trap SW1] initialising with options {"connection":"local","hideChannels":"0","logging":"standard","showAs":"outlet"}.
[8/24/2021, 10:00:11 PM] [Meross] [Insect Trap SW2] has been added to Homebridge.
[8/24/2021, 10:00:11 PM] [Meross] [Insect Trap SW2] initialising with options {"connection":"local","hideChannels":"0","logging":"standard","showAs":"outlet"}.
[8/24/2021, 10:00:11 PM] [Meross] [Insect Trap SW2] could not be initialised as Cannot read property 'displayName' of undefined at MerossPlatform.initialiseDevice (/usr/lib/node_modules/homebridge-meross/lib/index.js:699:43).

Hi @aralam thanks for this.
Should be fixed in v6.9.0!


Support adding roles for PowerMax

Description
This PR adds support for creating a role for a PowerMax system.
This also fixes an issue if you create PowerMax storage and then Powerflex storage, the PowerMax systems would be listed under PowerFlex storage.
To validate a PowerMax role, we verify that the system ID exists as an authorized storage system and verify that the specified Storage Resrouce Pool exists on the PowerMax.
The cobra commands have been refactored in favor of contstructors rather than global variables. This fixes an issue in test runs where we want to update/set various flags on the commands.
Issues
List the issues impacted by this PR:

Issue ID

#83

Checklist:

[x] I have performed a self-review of my own changes.

# make test
docker run --rm -it -v /git/karavi-authorization/policies:/policies/ openpolicyagent/opa test -v /policies/
data.karavi.authz.url.test_get_api_login_allowed: PASS (1.792405ms)
data.karavi.authz.url.test_post_proxy_refresh_token_allowed: PASS (711.846µs)
data.karavi.authz.url.test_get_api_version_allowed: PASS (1.538507ms)
data.karavi.authz.url.test_get_system_instances_allowed: PASS (1.241773ms)
data.karavi.authz.url.test_get_storagpool_instances_allowed: PASS (944.188µs)
data.karavi.authz.url.test_post_volume_instances_allowed: PASS (880.791µs)
data.karavi.authz.url.test_get_volume_instance_allowed: PASS (829.917µs)
data.karavi.authz.url.test_post_volume_instances_queryIdByKey_allowed: PASS (1.043505ms)
data.karavi.authz.url.test_get_system_sdc_allowed: PASS (946.403µs)
data.karavi.authz.url.test_post_volume_add_sdc_allowed: PASS (762.907µs)
data.karavi.authz.url.test_post_volume_remove_sdc_allowed: PASS (5.866155ms)
data.karavi.authz.url.test_post_volume_remove_allowed: PASS (628.847µs)
data.karavi.volumes.create.test_small_request_allowed: PASS (2.035073ms)
data.karavi.volumes.create.test_large_request_not_allowed: PASS (375.062µs)
--------------------------------------------------------------------------------
PASS: 14/14
go test -count=1 -cover -race -timeout 30s -short ./...
?       karavi-authorization/cmd/karavictl      [no test files]
ok      karavi-authorization/cmd/karavictl/cmd  5.007s  coverage: 60.2% of statements
ok      karavi-authorization/cmd/proxy-server   0.068s  coverage: 0.7% of statements
?       karavi-authorization/cmd/sidecar-proxy  [no test files]
?       karavi-authorization/cmd/tenant-service [no test files]
ok      karavi-authorization/deploy     0.096s  coverage: 84.6% of statements
?       karavi-authorization/internal/decision  [no test files]
ok      karavi-authorization/internal/powerflex 9.083s  coverage: 88.9% of statements
ok      karavi-authorization/internal/proxy     6.579s  coverage: 68.0% of statements
ok      karavi-authorization/internal/quota     0.405s  coverage: 92.6% of statements
ok      karavi-authorization/internal/roles     0.037s  coverage: 96.0% of statements
ok      karavi-authorization/internal/tenantsvc 1.814s  coverage: 82.9% of statements
ok      karavi-authorization/internal/token     0.029s  coverage: 90.0% of statements
ok      karavi-authorization/internal/web       0.053s  coverage: 24.1% of statements
?       karavi-authorization/pb [no test files]

@atye: Thank you for submitting your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at<EMAIL_ADDRESS>

LGTM. Please look in to failed tests.

Tests have been fixed via refactoring of the cobra commands with constructors rather than global variables.

Changes look good. There are some failing checks that just need to be addressed, e.g. gosec.

Fixed the gosec issue. There is also a security issue in jwt-go which is fixed in https://github.com/dgrijalva/jwt-go/releases/tag/v4.0.0-preview1. I'll update the package.


Sever crashes if request comes in before packager server starts

It is a race. We could swallow the exception which is not ideal. I'd rather wait till both the webpack and packager servers start before the main server is started. To do that we'll need https://github.com/facebook/react-native/issues/2518

Hmm, I've just noticed that the react package does provide a .middleware() function we could use instead of shelling out packager.sh: https://github.com/facebook/react-native/tree/master/packager#reactpackagermiddlewareoptions
That could be what we need

@elliottsj the middleware is nice but we it excludes quite a bit of functionality like opening stack frame in editor and opening the dev tools,

Fixed by #60


V2 Beta11 ion-content background-color

I just upgraded to nightly(Beta11) and discovered some page show "black" background. It only happen in IOS
Have to add this into CSS.

ion-page.show-page scroll-content {
   background-color: white;
}

Hello, thanks for opening an issue with us! I am having trouble reproducing this issue with the latest nightly. Could you share a repo that demonstrates this issue? Thanks for using Ionic!

It seems related to scss for this page. If I removed all CSS, the page is regular white background
SCSS

.projects {

  ion-card {
    position: relative;
    text-align: center;

  }

  ion-card img {
      height: 169px;
  }

  .card-title {
   position: absolute;
    top: 40%;
    font-size: 20px;
    width: 100%;
    font-weight: bold;
    color: #fff;
  }

  .card-subtitle {
   font-size: 20px;
    position: absolute;
    bottom: 0%;
    width: 100%;
    color: #fff;
  }

}

HTML  - Note: I remove all content to simplify trouleshooting.With above SCSS, the page is black
<!--
  Generated template for the ProjectsPage page.

  See http://ionicframework.com/docs/v2/components/#navigation for more info on
  Ionic pages and navigation.
-->
<ion-header>
<ion-navbar >
  <!--<button menuToggle>
    <ion-icon name="menu"></ion-icon>
  </button>-->
  <ion-title>Project</ion-title>
</ion-navbar>
</ion-header>

<ion-content padding class="projects">

</ion-content>

More specific. If I removed this, the page is normal

  // .card-title {
  //  position: absolute;
  //   top: 40%;
  //   font-size: 20px;
  //   width: 100%;
  //   font-weight: bold;
  //   color: #fff;
  // }

It took me really a while to find the trigger. I played around CSS/HTML. Remove all and leave basic HTML page. It has black background. The trigger is "preload=true".
In beta10, there is bug. With preload=true, tab doesn't switch. It appears nightly(beta 11) fix the issue. But there appears this issue

<!--<ion-tabs #mcTabs [selectedIndex]="mySelectedIndex" [preloadTabs]="preload">-->
<ion-tabs #mcTabs [selectedIndex]="mySelectedIndex" >


CTLIO 1324 Release Notes 072618

Major updates to July 26 Release Notes - I accidentally transcribed the wrong Trello board into a Word doc which was sent to James Green. He published the board i sent, but it was the wrong board. I’ve pulled the info from the correct board - basically its a new Release Notes.
Minor updates to June 5 - spell fix and minor formatting

@davidgardner11 there are conflicts.  I cannot merge

replaced this PR with a new one: https://github.com/CenturyLinkCloud/PublicKB/pull/2391


geomerty2_python3: 0.6.9-2 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository geomerty2_python3 to 0.6.9-2:

upstream repository: https://github.com/jsk-ros-pkg/geometry2_python3.git
release repository: https://github.com/tork-a/geometry2_python3-release.git
distro file: melodic/distribution.yaml
bloom version: 0.11.1
previous version for package: null

this will release jsk_tf2_py_python3
https://github.com/ros/rosdistro/blob/5ceb34c3e5fb63c0d3078634f2a7dfc2fddb49db/melodic/distribution.yaml#L3807-L3814
closes #33330

@sloretz thanks for comments, added license file https://github.com/jsk-ros-pkg/geometry2_python3/pull/2

Will wait for merge

https://github.com/jsk-ros-pkg/geometry2_python3/pull/2

Also, is this typo-ed?
Did you mean to do geometry2_python3 instead of geomerty2_python3?

@methylDragon thanks, merged and fix typo

Hmm, I'm not sure why the nosetests are failing..

@k-okada try rebasing and/or running rosdistro_reformat index.yaml.
That may fix CI.


Revert "Remove unnecesary ^nil in Mongo>>queryOne:"

Reverts pharo-nosql/mongotalk#11

reverting, sorry for the noise :P


Feature/azure app service (from Peter)

PR comments for peter.

Closing - re-open once we're ready for it.


Training Time

HI, can you share your training speed with A100, such as the time cost for each 10k step.
i'm training ms-istft-vits, and find it is slower than original vits.

Hi! Even In the case of my training model with A100, I confirmed that the total training time of the ms-istft-vits is slow...

Hi @MasayaKawamura, VITS model suffered from mispronunciation, so it usually has a large CER or WER when compared to other models. Did you see any pronunciation improvements for this model?
Anyway, thank you for your amazing work.

Hi @MasayaKawamura , how many steps would the model get a relative good effect in your experiments ?
I see in the paper that you trained 800k steps.

Hi @leminhnguyen, thank you for the question.
I have not done any comparisons on WER, etc., so I don't know for sure. From the few samples (you can check audio sample on this demo page), I think there are few critical word errors. However, WER depends on the input text length, so I think a detailed analysis is needed.
This paper may be helpful about VITS and WER.

Hi @FanhuaandLuomu, thank you for the question.
In the paper, all models were trained at 800k steps to match experimental conditions. I think It is a difficult problem because the hyperparameters and dataset are also related to how many steps are needed to obtain relatively good quality. This is just my opinion, I think you can synthesize a relatively good speech under 800k (I'll have to evaluate the specific number of steps with MOS to be sure).

Hi, thanks for your great work.
Can you open source your small version model structure，thanks again. @MasayaKawamura

Hi, @guoyingying432
I think the computation time depends on the hyperparameters, GPU, etc...
In the conditions of the paper, it takes about two weeks.


[PR][CLOSED] [Doxygen] Add an exception case.

 Issue by sewon-oh
Monday Jul 16, 2018 at 09:19 GMT
Originally opened as https://github.sec.samsung.net/STAR/TAOS-CI/pull/130

When check comment begin with '/**', add exception case that single line comment without doxygen tag.

Resolves: #127

Signed-off-by: sewon.oh<EMAIL_ADDRESS>Self evaluation:

Build test: [ ]Passed [ ]Failed [*]Skipped
Run test: [*]Passed [ ]Failed []Skipped

sewon-oh included the following code: https://github.sec.samsung.net/STAR/TAOS-CI/pull/130/commits

:octocat: cibot: Thank you for posting issue #154. The person in charge will reply soon.

 Comment by git-bot-sec
Monday Jul 16, 2018 at 09:19 GMT

Thank you for submitting PR #130. Your PR has to pass all verificiation processes of cibot before getting a review process from reviewers. We recommend that you read instruction manual in . If you want to monitor the progress status of your PR in detail, visit http://aaci.mooo.com/.

 Comment by geunsik-lim
Monday Jul 16, 2018 at 23:32 GMT

When check comment begin with '/**', add exception case that single line comment without doxygen tag.

@sewon-oh Please append the below statement in the commit body (=description)

Resolves: #127


feat(vscode/client): loader during prep

@moT01 Could you outline what you were thinking here, please?

Not really sure on the loader, but when I run course, the simple browser opens with a white screen while everything installs - which can take a decent amount of time. I dunno, I would have to play with - could we somehow load a static index.html file with a css loader until the server starts? Then redirect to that or something. That's all that comes to mind at the moment.

could we somehow load a static index.html file with a css loader until the server starts?

@moT01 Yes. Quite easily. I will try to get something out, and you can comment specific implementation on the PR.


Pull requests

@LGNDDOLLABOUTIQUE , I'll take for granted this is a false submitted, please reopen with more details if that is not the case, thank you


python3Packages.fountains: 0.2.1 -> 1.0.0, python3Packages.bitlist: 0.4.0 -> 0.5.1

Motivation for this change
Update to latest upstream release
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 139300 run on x86_64-linux 1

8 packages built:

python38Packages.bitlist
python38Packages.fe25519
python38Packages.fountains
python38Packages.ge25519
python39Packages.bitlist
python39Packages.fe25519
python39Packages.fountains
python39Packages.ge25519


Received runtime error that should be thrown at component build time

Received the below error when running spin up. I incorrectly capitalized the variables in my spin.toml file, and this caused some delays when the app succeeded after spin build, but failed at runtime. Can we have this error at build time, rather than runtime?
Error: invalid variable name: "DB_URL": invalid character 'D'. Variable names may contain only lower-case letters, numbers, and underscores.

We used to fully load the manifest at build time, but it threw up a lot of irrelevant “you need to fix this completely different thing before you can find out why the borrow checker is mad” errors.  It was derailing so we made it more forgiving.  That said:

Spin 2 introduced a better pipeline for manifest loading. Spin 1 had a monolithic loader which meant anything wrong would fail the load.  So reading the whole manifest may be less derailing now.
We could rearrange things so that spin build does the build regardless and also does a validation pass on the manifest. This would allow us to report validation failures at build time without them being derailing.


修正错误指令

【内容】：
修正错误的Docker Compose指令

THX for your good intention, but as docs mentioned at beginging, I recommend using Docker Compose to replace Docker-Compose, it is maybe the feature direction.


feat: Add logic to change default branch for git connected application

Description
We are opening the appsmith default application when the user clicks on edit. But when the app is connected to git we should always bring up the default application of the default branch.
Fixes #11541 #11223 #11651
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Locally
Junit tests

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

I did not follow this can you please elaborate on this further.

Some questions:

Have we tested the flow for already available applications where defaultBranch in remote is different than what we have in DB? Asking this because there are certain fields that we only store in the defaultApplication but with this implementation, we are requesting the remoteDefaultBranchedApplication always
Should we apply migration so that applications where defaultApplication and remote default branch are not same and insert the fields which are present in the gitApplicationMetadata of DB default application like gitAuth etc?
When we are running the sync flow are we creating the remoteDefaultBranchedApplication if the default branch is altered from remote?
Are we maintaining the gitApplicationMetadata for both DBDefaultApplication and remoteBranchedDefaultApplication henceforth? Is there any need for this, asking this because we have findApplicationByDefaultApplicationIdAndBranchName method present in quite a lot of places which needs to be addressed

Yes this tested on the scenarios you are referring to.
No we do not need migration here, as the logic takes care of updating the these fields on refresh/sync workflow. On the change in defaultBranch all the details needed are copied to the respective application.
Yes we are doing that. There is oneError handler at L.1574 which is doing the same
I am not fully confident on removing the gitApplicationMetadata from the defaultBranch app yet, for the same reason you mentioned. But i don't see any harm in doing so as the majority cases are in GitService class and that is handled already via the newly created method in ApplicationService to handle this scenario.

@abhvsn

Yes this tested on the scenarios you are referring to.
No we do not need migration here, as the logic takes care of updating the these fields on refresh/sync workflow. On the change in defaultBranch all the details needed are copied to the respective application.
Yes we are doing that. There is oneError handler at L.1574 which is doing the same
I am not fully confident on removing the gitApplicationMetadata from the defaultBranch app yet, for the same reason you mentioned. But i don't see any harm in doing so as the majority cases are in GitService class and that is handled already via the newly created method in ApplicationService to handle this scenario.

If possible can you also add a testcase for getAllApplications /new API?

/ok-to-test sha=96725cc

/ok-to-test sha=96598b3

/ok-to-test sha=8f68e42


Add support of throwing error when benchmark option is not appropriately set

So far, when the configuration file is not specified in the option, the program hung.

Implemented this in commit 1f8b3ce42b8e3537e7cb5517255338489599aff0


Add admin notification for new reservations

This has been requested by ITG. It's probably a subset of #914 but should be easy enough to implement on its own if we want to try and get it into v5.1.0 or v5.2.0. We'd definitely want to have this default to not sending e-mails, since the volume for most of our clients would be impractical, but we can offer it as an option. The e-mail itself can be similar to those for reservation requests. Wish list for now!

wait is this not already implemented as reservation_created_admin ? it sends emails from the cart if notify_admin_on_create is true.

I think this was resolved in #1284

Haha, they must have requested this earlier and I didn't check for duplicate issues. Closing!


Add help option to run command

This would fix https://github.com/kennethreitz/pipenv/issues/1145 (neither -h or --help work with pipenv run)
The help message for run was explictly disabled in commit
934d83e86de4cf036872a3dd2e68ada8a82fb1cb, but the behaviour introduced by that commit has since changed.
Currently if you run pipenv run --help or -h, pipenv treats the
option as a command and tries to run it. Unless you have something on
your path called --help or -h, this will fail with a simple error
saying it's not on the path. It doesn't give you any information about
what the command does.

This is because short_help is only shown in the help for the
parent command, and the actual help string defaults to None.   Other
subcommands also have this issue, so if this PR is accepted maybe we
should add help strings for them too.
Proposed output:
$ pipenv run --help
Usage: pipenv run [OPTIONS] COMMAND [ARGS]...

  Run a command inside the virtualenv. This makes all your installed
  packages available to the command.

Options:
  --three / --two  Use Python 3/2 when creating virtualenv.
  --python TEXT    Specify which version of Python virtualenv should
use.
  -h, --help       Show this message and exit.

and
$ pipenv --help
Usage: pipenv [OPTIONS] COMMAND [ARGS]...

Options:
  [...]

Commands:
  check      Checks for security vulnerabilities and against PEP 508
markers
             provided in Pipfile.
  graph      Displays currently–installed dependency graph information.
  install    Installs provided packages and adds them to Pipfile, or (if
none
             is given), installs all packages.
  lock       Generates Pipfile.lock.
  open       View a given module in your editor.
  run        Run a single command inside the virtualenv.
  shell      Spawns a shell within the virtualenv.
  uninstall  Un-installs a provided package and removes it from Pipfile.
  update     Uninstalls all packages, and re-installs package(s) in
[packages]
             to latest compatible versions.

Isn't there any chance that running pipenv run mypythonscript --help will call pipenv run --help instead?
/cc @erinxocon

@vphilippon not that I'm aware of.
I'm not familiar with click so I may be missing something, but when I tested it, the --help was correctly added to args, and it worked as expected.

Maybe it’s better to parse the help option manually, since IMO the help option is only desired when it’s the first argument? Something like
if command == '--help':
    click.echo(ctx.get_help(), color=ctx.color)
    ctx.exit()

so
$ pipenv run --help
Usage: pipenv run [OPTIONS] COMMAND [ARGS]...

Options:
  --three / --two  Use Python 3/2 when creating virtualenv.
  --python TEXT    Specify which version of Python virtualenv should use.

but
$ pipenv run pip --help

Usage:
  pip <command> [options]

Commands:
[snipped]

@uranusjr that's what I mean; that behaviour is already working on this branch.

Was closing this intentional? It looks like a nice fix for the help issue.


Update 09_00_ARC09_4B.txt

Prefer 'too hard on Hisui' over 'hard on Hisui'. The current feels inappropriate. Here, Shiki is referring to Akiha not hitting Hisui. Scolding her for her mistake is one thing, but hitting her would be too hard
Add 'of'

See #1383


fix: resolve property assignments in object literals

Might be a simpler alternative to #256
This follows the implementation I found in the TypeScript goToDefinition service https://github.com/microsoft/TypeScript/blob/88809467e8761e71483e2f4948ef411d8e447188/src/services/goToDefinition.ts#L307-L316
Not meant to be merged as is, just wanted a basis for discussing how to go about the issue
@olafurpg I know it's been a while, but do you remember if this getContextualType existed when you we're looking at this, and if so do you remember why you went with a different route?
Test plan
Ports all tests from #256 and adds some basic new ones. Check the updated snapshot output to gauge the improvement or if there are any regressions.

@olafurpg Could you PTAL? I inlined some more internal definitions from the TypeScript compiler to be more in-line with how they use the getContextualType API.
I ported all the tests from #256, and after manually inspecting the snapshot outputs for a while I think things are looking good.


chore: import repository https://github.com/jenkins-x-bot-lab/jenkins-x-lab.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


remove quotes on sec.version

CI: No IaC security warnings found

CI: No IaC security warnings found


Question answering

Now we can (finally) use our context and prompt GPT3

Yes, I wrote this code so it is good for now. It's super slow though, in the future we will need to work on speeding this up!


fix(v1): mobile safari search input misalignment in header

Resolves #254
Motivation
The thing was that the search input was sized differently on Mobile Safari / Chrome browsers which caused in a misalignment like described in the #254 bug report. I've unified the height of the input and aligned it properly, so it looks good on Chrome/Firefox as well as on Safari / Mobile Safari.
Have you read the [Contributing Guidelines on pull requests]
Yes.
Test Plan
I've tested locally on given browsers:
Chrome desktop:

Firefox desktop:

Safari desktop:

Chrome iPhone 8

Safari iPhone 8

Chrome Google Pixel 3

@yangshun You're welcome! 😄


[docs] API reference layout overflow

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Because of the layout/styling of pages in MUI docs, when there is overflow content, it's annoying to have to scroll to read when there is so much empty space.
https://user-images.githubusercontent.com/107882367/186991172-73a74b8b-4a6c-43bc-a7d7-3834d3d7c75f.mov
Expected behavior 🤔
I shouldn't have to scroll if the dimensions of my browser are large enough
Steps to reproduce 🕹
Steps:

Go to https://mui.com/x/api/data-grid/data-grid-pro/#props (same with most other pages, cross projects).
Resize window, look at Props documentation

Context 🔦
Trying to read the docs
Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Benchmarks

Each prop with a long description: https://js.devexpress.com/Documentation/ApiReference/UI_Components/dxDataGrid/Configuration/#onEditCanceling and a demo or a link to a demo. Comment: It feels too much like a guide at the level of a prop, which doesn't make sense. However, the links to demo could be great:

Using https://typedoc.org/ - https://youtu.be/Y07edRJd5QM?t=407. Comment: Cagatay is unsecured about this move, see his body language. So typedoc is probably not a  good option. MUI X started to use its API and then moved one level lower as it was mostly bloat.

@oliviertassinari Currently, the section has max-width of 105ch, should it increase for widescreen monitor?

@siriwatknp I would propose this solution for the problem: https://github.com/mui/material-ui/issues/31745#issuecomment-1121095958.
I think that we should be careful about the max width. As far as I know, the value of a small max width is to limits the amount of horizontal distance the eye has to travel before it has to go to the next line. The longer the distance is, the more likely our eye will land on the wrong next line. It's why the blog post area has a small max width than the docs, it's mostly content.

There are also discussions about this problem in https://www.figma.com/file/MfirV6NOFAp2xxAZX1QU1V/Documentation?node-id=924%3A6631&t=ofIIr63jvuMAGcqP-0.

The latest shape of the proposed solution on this:


Does not allow variables for path name?

The builtin {% include %} and {% include_relative %} tags support the use of variables for specifying the path, but this plugin appears to require a string literal for the path parameter. Can it be modified to support {{ expressions }} for variable values the way the builtin tags do?

It seems like you need to include an extra pair of single quotes to make this work.
{% include_absolute '{{ variable_path }}' %}


Added CodeFactor

Affected Issues

Fixes #

Proposed Changes

Coverage remained the same at 100.0% when pulling f237c6943acae2db99721c4394023e658f7af991 on nnadeau-patch-1 into 8b37c8672c55945a5ab6f5bb951715f212fcea9f on master.

Codecov Report

Merging #445 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #445   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          12     12
  Lines         499    499
  Branches       28     28
=====================================
  Hits          499    499


Changing :slug page url parameter name breaks the setUrl methods.

All the four components of this plugin use model helper methods setUrl on Post and Category models which generate the blog or category url from the corresponding page passed in parameter of the method:
https://github.com/wintercms/wn-blog-plugin/blob/3fba60378b6ebdef0e69ffdf2af6adbbc6dbcbb2/models/Category.php#L87-L94
https://github.com/wintercms/wn-blog-plugin/blob/3fba60378b6ebdef0e69ffdf2af6adbbc6dbcbb2/models/Post.php#L157-L176
The problem is that as you can see, the slug page's param is hard-coded in the url generation, which make this page url generation to fail:
// post.htm
title = "Blog post"
url = "/blog/:notSlug"
layout = "default"
is_hidden = 0

[blogPost]
slug = "{{ :notSlug }}"
categoryPage = 404
==
{% component 'blogPost' %}

Same is true for the page integrating the blogPosts, blogCategories and blogRssFeed components.
As of today, I don't see any easy way to fix this without adding a new property that would refer the target page url parameter name.
Something like this in Categories component:
// components/Categories.php

public function defineProperties()
{
    return [
        'slug' => [
            // ...
        ],
        'displayEmpty' => [
            // ...
        ],
        'categoryPage' => [
            'title'       => 'winter.blog::lang.settings.category_page',
            'description' => 'winter.blog::lang.settings.category_page_description',
            'type'        => 'dropdown',
            'default'     => 'blog/category',
            'group'       => 'winter.blog::lang.settings.group_links',
        ],
        'categoryPageSlugParam' => [
            'title'       => 'winter.blog::lang.settings.category_page_slug_param',
            'description' => 'winter.blog::lang.settings.category_page_slug_param_description',
            'default'     => 'slug',
            'type'        => 'string',
        ],
    ];
}

This property value could be passed to the setUrl method and generate the good url structure like this:
public function setUrl($pageName, $controller, $slugProp)
{
    $params = [
        'id'   => $this->id,
        $slugProp => $this->slug
    ];

    return $this->url = $controller->pageUrl($pageName, $params, false);
}

Ok, I've found how to solve this issue properly without any modification to the setUrl method, here is the example from blogPosts component:
/*
 * Add a "url" helper attribute for linking to each post and category
 */
// Load post and category pages
$activeTheme = Theme::getActiveTheme();
$postPage = Page::loadCached($activeTheme, $this->property('postPage'));
$categoryPage = Page::loadCached($activeTheme, $this->property('categoryPage'));

// Retrieve the post slug property name
if ($postPage && $postPage->hasComponent('blogPost')) {
    $postPageSlugParam = $postPage->getComponent('blogPost')->property('slug');
    if (preg_match('/^\{\{([^\}]+)\}\}$/', $postPageSlugParam, $postMatches)) {
        $postPageSlugParam = substr(trim($postMatches[1]), 1);
    }
}

// Retrieve the category slug property name
if ($categoryPage && $categoryPage->hasComponent('blogPosts')) {
    $categoryPageSlugParam = $categoryPage->getComponent('blogPosts')->property('slug');
    if (preg_match('/^\{\{([^\}]+)\}\}$/', $categoryPageSlugParam, $categoryMatches)) {
        $categoryPageSlugParam = substr(trim($categoryMatches[1]), 1);
    }
}

// Default to slug if not found
$postPageSlugParam ??= 'slug';
$categoryPageSlugParam ??= 'slug';

$posts->each(function($post) use ($postPageSlugParam, $categoryPageSlugParam, $categorySlug) {
    // Pass them as $params parameter of setUrl method
    $post->setUrl($this->postPage, $this->controller, ['category' => $categorySlug, $postPageSlugParam => $post->slug]);

    $post->categories->each(function($category) use ($categoryPageSlugParam) {
        $category->setUrl($this->categoryPage, $this->controller, [$categoryPageSlugParam => $category->slug]);
    });
});

Basically, I apply the same logic as the sitemap plugin support does here:
https://github.com/wintercms/wn-blog-plugin/blob/3fba60378b6ebdef0e69ffdf2af6adbbc6dbcbb2/models/Post.php#L672-L682
I did this directly at the component level to avoid to load 20 times the post and category page object.
If this looks good to @LukeTowers @bennothommo, I could reproduce these steps on all the blog and forum plugin's components.

@RomainMazB happy for you to provide a PR with that fix - just change the ??= operators to $variable = $variable ?? 'slug' if you can, so that we can still support Winter 1.1 with these plugins as that operator only works with PHP 7.4 and up - no need to phase out support for that branch yet if we don't need to :)

@RomainMazB are you still interested in submitting a PR?


MetalDock Setup -- Package Download Issue

When trying to install required packages for MetalDock, I get the error:
xtb-6.5.1| Program python3 found: YES (/opt/anaconda3/envs/MetalDock/bin/python3.8)
xtb-6.5.1| Configuring xtb_version.fh using configuration
xtb-6.5.1| ../subprojects/xtb-6.5.1/meson/meson.build:22: WARNING: FC and CC are not from the same vendor
  ../subprojects/xtb-6.5.1/meson/meson.build:115:23: ERROR: C shared or static library 'mkl_gf_lp64' not found

  A full log can be found at /private/var/folders/sx/h7hs9s3n34585fqlkghj8zpr0000gn/T/pip-install-zvvzvqml/xtb_5a574d05568c49199a5b1f69955a2c0e/.mesonpy-ujedlo4m/meson-logs/meson-log.txt
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
I also cannot find the full log file in /private/var/folders/...
Thanks.

Hi,
I am sorry, but I cannot help you with installation issues of other packages. I would recommend you to post this problem on the xtb github page.


[Font] Fix glyph bitmap alignment from SDF fonts

PR Details

Fix horizontal/vertical alignment of glyphs from generated SDF bitmaps.
According to the original author -autoframe more meant for previewing rather than actual usage due to it centering the glyph to fit exactly centered on the bitmap rather than how it should be fitted on the bitmap (ie. snapped to the top-right corner).
Other change is debug build, dump the SDF bitmaps in into a sub-folder in the temp directory instead of straight into the temp directory so it's easier to delete. This does not affect the release build.
Related Issue

#2172 Only fixes the vertical alignment, not the kerning issue (which I have no clue about).
Merely an FYI, but this is the original logic for autoframe:
https://github.com/stride3d/msdfgen/blob/1af188c77822e447fe8e412420fe0fe05b782b38/main.cpp#L684-L709
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[X] I have built and run the editor to try this change out.

Thanks !


Issue 54 merge

This has the multi-threaded project creation.  Also made a few of the settings.py things we always change in development pull values from env vars now and use the prod values as defaults.  Also added a path in the bucket so we can keep our dev files more clearly separate from the prod stuff

PS Edwin this should not have broken anything but I don't have a test for your API code so please take a look at this too


Avoid adding space after tab

Codecov Report

Merging #84 (1256867) into main (bd66f72) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main      #84   +/-   ##
=========================================
  Coverage     99.91%   99.91%
  Complexity      448      448
=========================================
  Files            30       30
  Lines          1180     1180
=========================================
  Hits           1179     1179
  Misses            1        1

Impacted Files
Coverage Δ

src/Token/Token.php
100.00% <ø> (ø)

src/Sniff/AbstractSpacingSniff.php
100.00% <100.00%> (ø)

src/Sniff/TrailingSpaceSniff.php
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


chore: Release-plz is not working correctly

Currently whenever a new change is merged into main release-plz opens a PR setting the version to 0.1.0
The desired behavior is that it will detect the version in the main branch and it's pr will bump the version to the next minor release and amend changes to the change log from the last time it was merged in.

This isn't really unintended. The crate isn't released!! It can't find a version to compare against. We just need to release the crate.

That true but it should still be able to compare semver on main when the publish flag is set to false right?

No, what will it semver against? Semver is a different check entirely than release-plz, though release-plz uses cargo-semver prior to releasing.


Coastlines

Description:
OpenStreetPad currently has no reasonable way to deal with natural=coastline ways that delimit landmass.
Steps to reproduce:

scroll to an area with coast line in it.

Expected results:
The sea and land are correctly rendered.
Actual results:
There is no way to tell sea and land apart.

Quoting from http://wiki.openstreetmap.org/wiki/Coastline :
"The sea is delineated using natural=coastline with the direction of coastline organised so that land is always on the left of the way in the direction it is drawn."
Should you be able to draw land always to the right of a coastline way and closing it as a polygon at the viewport border?

Yep, that works, as long as there's at least one coastline way in the area being rendered.  The bigger problem is how to deal with polygons with no coastline – are they under water, or on land?


Note sustain strums look a bit ugly at high BPMs. This is how to fix it.

What feature do you want to get added on the base engine?
What's going on?
The following seems to be affected by the tempo/BPM of the song:

How often the note strums' light-up loop seem to be tied to the BPM of the song.

https://user-images.githubusercontent.com/31808925/148288717-3ae00f0d-829b-471b-83bc-91e587d20681.mp4
This may be due to how sustains are created in the first place. It makes sustain notes "blink" at high BPM levels, which makes it less satisfying to look at. Perhaps how strum sustains are animated may have to change a bit, from reacting to sustain pieces to just looping whenever a key is held down.
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

The quality of this video is too low for understanding but i think i got what you mean, this is just how note glow animations play when you hit a note.


Improve error handling at the server level

If an error occurs during a service invocation, clients should get proper error messages with context.  E.g. Http status code 500.
At the moment clients won't get a response if an error occurs at the server side.

Fixed with https://github.com/ballerinalang/ballerina/pull/2468


Print the ARC version number on startup

This would make it unnecessary for me to ask anyone how they upgraded ARC or which ARC version they are running when providing user support.

Just a simple const that we set manually each update that print at the start of init/main function call or is there an internal version handling that should be called instead?
This is low hanging enough for me to do 🤣

This has been resolved via #1659.
Thank you so much for your contribution @ViktorLindgren95!!


Fix linting

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 20 (30.0%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 28.795%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

build.go
0
1
0.0%

config.go
0
2
0.0%

local_bundle_watcher.go
0
2
0.0%

options.go
0
9
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
258

Relevant Lines:
896

💛  - Coveralls


Add the IAggregateAudioAdjustment interface to ITrack

Exposes the Aggregate[Adjustment] bindables in ITrack.
Closes #4208

It might be fine to have IAdjustableAudioComponent : IAggregateAudioAdjustment. I can't see much reason to not do that instead, except interface separation, maybe. Would be nice to get more opinions on this.

Was thinking the same thing. If we're going to start exposing these on each component that implements them there's no reason not to.

I've made the change. There are no actual code changes, just shuffling interfaces around, so this seems a harmless enough change.


review def for chip_io

The DEF writer had previously had issues but the current version of chip_io.def in the caravel-gf180mcu repository looks correct to me.


Tweaks to write K8s as proper noun

I saw #12969 and wondered if the same change applied elsewhere. Here's where I think it does.

/lgtm

@sftim looks good to me, although my vote doesn't help (for now) moving this PR ;)

@sftim Nice, thanks!
/lgtm
/approve

@DanyC97 Are you not an org member yet? If you want to join, I'll sponsor you. You'll need to get another member to co-sponsor, but you can link your PR record to #sig-docs and ask for one.


Set rootDirectory to current working directory so imports work.

I started with a 'simple' TODO that I found in main.c
The rootDirectory was not set if the scriptname did not have a '/'.
There is no test yet, but the following works now:

scenario 1:
cd example/import-module
../../wren lovecraft.wren
Ph'nglui mglw'nafh Cthulhu R'lyeh wgah'nagl fhtagn

scenario 2:
./wrend example/import-module/lovecraft.wren
Ph'nglui mglw'nafh Cthulhu R'lyeh wgah'nagl fhtagn

See #186 .


Getting Swagger error when specifying "file" as response type

My API can return either JSON or compressed files. I set the following top-level producesspec:
produces:
  - application/json
  - application/x-gzip

However, when on one of my endpoints I specify the following:
responses:
  "200":
    description: Success
      schema:
        type: file

I get the following Swagger Error: Validation error: enum, with an error path pointing to the type: file above.
The specs are not entirely clear to me as to how I should format an endpoint that returns a compressed file, but the above was the result of my understanding. Is this a bug or was my understanding incorrect? If the latter, could someone enlighten me?

There's a bug in the json schema which doesn't allow file as a response (and both swagger-tools and swagger-editor depend on it). There isn't an open issue about it yet, so let's keep it here (I have it in my own todo list).
But to put your mind at ease - your declaration is indeed correct.
If you have any suggestions on how to make the spec clearer with regards to it, I'd love the input. I'm in the process of adding the examples, clarifications, and fixing the json schema, so the feedback would be great at this point.

Thanks. I think the spec is clear enough if it goes with an example. So my only suggestion would be to add an example, but I see that's already flagged as a TODO.

Oops, sorry, I created an issue over there.  Here's my example schema btw:
swagger: '2.0'
info:
  version: "0.0.0"
  title: Example
paths:
  /test:
    get:
      responses:
        200:
          description: OK
          schema:
            type: file

This seems like the sort of bug that will affect virtually everybody.  I'm currently working around it by deleting the schema from any routes that serve up files as responses.

I created a pull request that should handle this.
https://github.com/swagger-api/swagger-spec/pull/293
Not sure how to test it or try it in the editor though.

@nickretallack - Thanks for the PR but I'm not going to merge it yet. Changing the schema is a bit delicate as it affects several tools, and I'm going to do a bulk update rather than several small ones.
If you're looking to solve the issue for yourself for now, you should look into swagger-tools on which the editor depends on - @whitlockjc may be able to assist there.

:+1:  on this - ran into it today and was like - of course it does "file" as a return type... nope... ended up on this thread - glad someone already submitted PR, next time you suck in changes in your batch, please do include this.  :-)

Is there any progress on this? "file" is still not supported.

This should be fixed in the schema now.

I still get this error using editor.swagger.io:
0: Object
    code:  "ENUM_MISMATCH"
    message:  "No enum match for: file"
    path: Array [2]
        0:  "schema"
        1:  "type"

And my schema file:
      responses:
        '200':
          schema:
            type: file
          headers:
            Content-type:
              type: string
              description: text/csv; charset=utf-8
            Content-Disposition:
              type: string
              description: attachment; filename=myfile.csv
          description: Export data into a CSV file

Should I do something in particular to benefit from the bugfix?
My current workaround is to use type string

It will take a bit for the schema updates to propagate to the different projects.

Ok thank you for the fast answer @webron, I can indeed totally live with(out) it for now :) sorry for the disturbance, I was assuming it was instantaneous

While type: file seems to be recognized if directly under schema, it's still not usable behind a reference.
Swagger Editor 2.10.2

Hi, this issue seems to be unsolved yet. Are there any plans to solve it?

Why was this closed, even though it is not fixed?

Because the issue with the schema has been resolved. Any outstanding issues with specific tools should be raised / followed up on the appropriate repositories.


[FEATURE] Combine create and provision APIs

If we add validation by default as a prerequisite to saving a WIP template, that could be a frustrating experience for a builder. In that regard, I think it should be a separate capability and having an optional dry-run param for the RestCreateWorkflowAction to validate prior to saving makes sense.
I think validation goes more with the "execution" portion, but we should be able to do the validation before saving.  Which means we sort of need a "save-and-execute" single API call.
Which brings back up the possibility of combining APIs.
We have
POST _plugins/_flow_framework/workflow
{
    // use case template
}

followed by
POST _plugins/_flow_framework/workflow/<workflow_id>/_provision
{}

This works well for a "save WIP and finally execute when done" but in the case we have a completed/debugged template that we always want to execute, we could do that all-in-one with:
POST _plugins/_flow_framework/workflow/_provision
{
    // use case template
}

Now, throw a validation param in there and we have a one-liner just like we want:
POST _plugins/_flow_framework/workflow/_provision?dryrun=true
{
    // use case template
}

(or similar)

Originally posted by @dbwiddis in https://github.com/opensearch-project/flow-framework/issues/88#issuecomment-1765403845

It's also possible to add provision=true as a param to the existing create API rather than having a new API.

It's also possible to add provision=true as a param to the existing create API rather than having a new API.

+1 to this approach :
// Request
POST _plugins/_flow_framework/workflow?provision=true
{
    // use case template
}

// Response
{"workflow_id":"<workflowId>"}

From what I can gather, the sequence would be as follows :

User invokes the above API with provision=true
This hits our RestCreateWorkflowAction, which passes the request to the CreateWorkflowTransportAction
The CreateWorkflowTransportAction indexes the template into the Global Context index and responds to the action listener with a workflow_id
Once we get the response back in the ResCreateWorkflowAction, we check if provision param is true and then invoke ProvisionWokflowTransportAction, which will handle validation/executing the workflow
The ProvisionWorkflowTrasportAction will respond with a workflow_id or an error if validation/execution fails

CC : @jackiehanyang


Improve install instructions

Fixes #40

Hmm, is your @google email associated with your GitHub account? Usually this only comes up for external contributors.

@babbush I use my @gmail email for github.

That is okay, see what I sent you in gchat. There is an alternative way for Googlers to be recognized by the Google CLA bot.

@babbush you can use the view button to get here.


test: add golden file tests

Currently, the boa tool is not tested.
Add golden file tests that check the generated files are as expected

fixed by #10


Provide ability to create object from array

Discussed in https://github.com/Azure/bicep/discussions/4093

Originally posted by miqm August 20, 2021
Question - is it possible in ARM runtime to create an object (in fact I'd like to have a key-vault map) from an array?
I'm thinking of having a module where I can pass a list of unique names and as an output get an object where to that name will be added the resourceId of created resource, so I can use concrete resourceId referencing by name and not an array index (less error prone).

Support for #4691 (req for #4153) would allow for a syntax like:

createObject(items, keyLambda) - to create an object with keys selected by the lambda
createObject(items, keyLambda, valueLambda) - create an object with keys & values selected by lambdas

e.g.:
var elements = [
  {
    id: 'abc'
    name: 'foo'
  }
  {
    id: 'def'
    name: 'bar'
  }
]

var keyedById = createObject(elements, x => x.id)
// equivalent to:
// {
//   abc: {
//     id: 'abc'
//     name: 'foo'
//   }
// ...

var nameById = createObject(elements, x => x.id, x => x.name)
// equivalent to:
// {
//   abc: 'foo'
//   def: 'bar'
// }

Note that creating a dictionary from an array can be achieved with reduce, it's just not very readable:
// equivalent to the above proposed: createObject(elements, x => x.id)
var keyedById = reduce(elements, {}, (prev, cur) => union(prev, { '${cur.id}': cur }))

// equivalent to the above proposed: createObject(elements, x => x.id, x => x.name)
var nameById = reduce(elements, {}, (prev, cur) => union(prev, { '${cur.id}': cur.name }))

Now, we have toObject(). Should this issue be closed?

@TomasMalecek thanks for reminding me. Here's the working syntax that was implemented:
var elements = [
  {
    id: 'abc'
    name: 'foo'
  }
  {
    id: 'def'
    name: 'bar'
  }
]

output keyedById object = toObject(elements, x => x.id)
/* returns the following output:
{
  "abc": {
    "id": "abc",
    "name": "foo"
  },
  "def": {
    "id": "def",
    "name": "bar"
  }
}
*/

output nameById object = toObject(elements, x => x.id, x => x.name)
/* returns the following output:
{
  "abc": "foo",
  "def": "bar"
}
*/

Public documentation: https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/bicep-functions-lambda#toobject


Check on Amendment M503 Availability

Hi Team,
Please check this statement for accuracy.
"If an Amendment M503 is signed, you can move any agreement from any frequency to monthly billing. "
I do not believe this is available any longer.
thanks,
Lori

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 94a62bd7-4779-c4af-4ec0-b4bb64ff3a2e
Version Independent ID: 4b01ab8f-d98a-a8d8-51cb-65fbdcd4025c
Content: Azure Enterprise enrollment invoices - Microsoft Cost Management
Content Source: articles/cost-management-billing/manage/ea-portal-enrollment-invoices.md
Service: cost-management-billing
Sub-service: enterprise
GitHub Login: @bandersmsft
Microsoft Alias: banders

@Lorifiis
Thanks for your feedback! We will investigate and update as appropriate.

@bandersmsft FYI

@Lorifiis I spoke with the EA billing engineering team. It looks like the M503 amendment is no longer offered, so I removed the reference to it from the article.
Thanks for letting us know about this issue.
#please-close


Add support for data constructors attributes

Hi,
This PR adds support for decorating data constructors (and records) with attributes, as @TWal was suggesting a few days ago on Slack.
The syntax follows the one for binders, that is:
type test0 =
  | [@@@ someAttribute1; someAttribute2] A
  | ...
type test1 = [@@@ someAttribute] { foo: int; }

This PR also adds prettyprinting for attributes on binders & constructors.
It also adds two test modules: one functional test ConstructorAttributes and one prettyprinting test.
Most of the changes are about adding a _ to TyconRecord or constructors.
Is there a reason attributes on binders are typechecked as unit specifically, while top-level attributes are just untyped terms?
~For now, I didn't add any such checks for binders on constructors. Should I change that?~
EDIT: the CI fail, but that's because I changed parse.mly. I'll push an ocaml snapshot, but I guess that's not ideal for merging afterward.

Thanks for the PR @W95Psp! I have left some comments, the main one is for the AST change in FStar.Syntax.Syntax, wonder if we can do without it.

Thanks @aseemr!
I rewrote the desugaring part to use the sigattrs field, it is indeed way simpler.
However, type checking attributes on sigelt breaks some things:

attributes with universe polymorphic terms (here in Steel for instance) cannot be typechecked;
I had to add an unpleasant hack for the attribute Substitute that gets inserted before being declared (see my comment on https://fstar.typechecker.tc/)

Hi Lucas,

in Typechecker.Normalize, deep_compress was actually not enough, after testing more thoroughly. So, as you suggested @mtzguido, I dropped the useless deep_compress and kept only elim_uvars_aux_t.

Sounds good. Actually, I hadn't really paid attention to the fact this is introducing typechecking of all attributes for sigelts. If uvars can appear and be resolved in the attributes, then this is indeed the right to thing to do.

12794d4 drops most of the code of handle_postprocess_with_attr, which I think is now useless since every attributes are elaborated and typechecked.
@guido I saw you added that code because of Failure("Impossible: missing universe instantiation on unroll") #2132, do you think my change is okay?

Yes, I think it's great. If all attributes are typechecked then all the better IMO. I don't remember if there was a rationale for not checking them, though.

In the same theme, this PR solves Failure("Impossible: missing universe instantiation on unroll") #2132, and more particularly, now this passes, uncommented: https://github.com/FStarLang/FStar/blob/1601c00aed53cf38baae5744ebde8704a7d8a7a9/tests/bug-reports/Bug2132.fst#L26-L27

Awesome. I can't really explain why that is.. since the tactic was already being checked, but all the better!


Format JS code

Отформатировал исходники

Надо ещё версию поднять на патч, чтобы собралось нормально, и в readme дописать, как проверять форматирование
Поднято же, инструкция в codestyle лежит

Поднято же, инструкция в codestyle лежит

Каюсь, дифф changelog не нашёл в этом списке

Я у себя вызвал prettier и что-то пошло не так
$ npx prettier -c  .
 Forgot to run Prettier?

Скопировал prettierrc из codestyle, получилось такое
$ npx prettier -c  .
Checking formatting...
[warn] jsxBracketSameLine is deprecated.
[warn] .prettierrc
[warn] app/scripts/react-directives/network-connections/actions/ConnectionsActions.js
[warn] app/scripts/react-directives/network-connections/stores/SwitcherEditorStore.js
[warn] app/scripts/react-directives/network-connections/switcher.js
[warn] app/scripts/services/devicedata.js
[warn] Code style issues found in 5 files. Forgot to run Prettier?

jsxBracketSameLine

А поменяй jsxBracketSameLine на bracketSameLine

bracketSameLine

Поменял, первый ворнинг изчез, остальные остались. prettier 2.8.8

Ещё я удалил в этом PR .editorconfig, возможно, ещё он влияет

Ещё я удалил в этом PR .editorconfig, возможно, ещё он влияет

У меня его нет

Скопировал prettierrc из codestyle, получилось такое

Так, это в основном мои левые испорченные файлы, но один маленький недочёт просочился, уже обсудили

Rebase https://github.com/wirenboard/homeui/pull/453


Add ability to poll device status

We should add the ability to the RgbLedSequencer class to poll the current status of the device (Awake, Sleeping, Busy, PortClosed, Unreachable). We would need to evaluate the difficulty or even possibility of detecting some of these states.

Decided that doing this adds little value and isn't easily implemented in a meaningful way.

Changed mind and finally decided that a simple status check of the sleep status and current sequence being played could have value and is easily implemented.


chore: flaky reduce e2e tests

Signed-off-by: Yashash H L<EMAIL_ADDRESS>

what was the reason for flakyness?

what was the reason for flakyness?

we used to publish 300 messages and check the sink to see if the expected output is present instead, we should keep on publishing messages until we see the output in the sink.

Got another flaky reduce test failure: https://github.com/numaproj/numaflow/actions/runs/3735319201/jobs/6339041738 Not sure if it's related.

Interestingly I see the expected output in the logs 😄

Right. The failure seems coming from the test clean up. reduce_test.go:256: Timeout after 1m0s waiting for pipeline pods terminating. Maybe 1m is too short for terminating all pods. Let's see if such case happens more frequently and if so, adjust the timeout value.


Improve registration email

[x] First link does not work
[x] update link text so it does not look so messy

Disabled tracking in Sendgrid remove the redirection and links now looks normal.


Review add graceful shutdown

What this PR does / why we need it: adds graceful shutdown capability and addresses review comments.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #101
Special notes for your reviewer: see also https://github.com/kubermatic/machine-controller/pull/110

@metalmatze, @mrIncompetent comments addressed, is this something we want ?
I've opened a new pull so that we can easily compare the changes.

@metalmatze, @mrIncompetent thanks for your input, comments addressed.

@metalmatze what do you think, is this ready to be merged ?:)


example bitorrent v2 initial parsing

https://blog.libtorrent.org/2020/09/bittorrent-v2/
Tested using the v2 torrent linked there.
Ideally the hybrid torrent would be used to validate support. Monotorrent should be able to load that and use the v1 metadata to download, and then (eventually) transition to using the v2 metadata


Header is not visible

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: Chrome Version 115.0.5790.110 (Official Build) (64-bit)
Operating system and its version: Windows version 10 enterprise
PDF.js version: Latest
Is a browser extension: No

Steps to reproduce the problem:

Load the attached document through the solution added or from https://mozilla.github.io/pdf.js/examples/ ->  interactive example
Headers are not visible fully

What is the expected behavior? (add screenshot)

What went wrong? (add screenshot)

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
https://mozilla.github.io/pdf.js/examples/ ->  interactive example
or
PDFJSSampleZip.zip

Duplicate of #16747

As mentioned in https://github.com/mozilla/pdf.js/issues/16747#issuecomment-1651801786 it works in the default viewer, please see https://github.com/mozilla/pdf.js#online-demo

Load the attached document through the solution added or from https://mozilla.github.io/pdf.js/examples/ ->  interactive example

That's purposely a very simple example, and it's thus possible that you need to provide additional API-parameter(s) in the getDocument-call in order it to work. Please look in the web-console for any error- and/or warning-messages.

PDFJSSampleZip.zip

Unfortunately that's not possible for anyone else to run directly; please see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.

It seems that your PDF document uses CMaps, hence you need to provide the path to them when calling getDocument; please see https://github.com/mozilla/pdf.js/blob/611acf52c46ab78a30f6b600fa15ff61cdd7fe24/src/display/api.js#L148-L149
Basically, change your code into something along the following lines. (If that's not enough help, then you must provide a directly runnable example.)
pdfjsLib.getDocument({
 url: /* PDF document URL goes here. */,
 cMapUrl: /* CMap path goes here.*/,
});

I was able to load document header with below change
var loadingTask = pdfjsLib.getDocument({
url: parameters.url,
cMapUrl<EMAIL_ADDRESS>cMapPacked: true
});
But when I tried to use local files like below, it is showing me error as "Error: fetch Built In CMap: failed to fetch file "../web/cmap/UniKS-UTF16-H.cmap" with "Not Found".".
var loadingTask = pdfjsLib.getDocument({
url: parameters.url,
cMapUrl: '../web/cmaps/',
cMapPacked: true
});
Do you know why it is not accessing local files?

do we need to do extra settings to access local file successfully?


Centrifuges not multiplying outputs in All The Mods 6 1.16.5

Tested in a creative world that Creative Centrifuge, Diamond Centrifuge, and Basic Centrifuge are all outputting around 256 ores given a stack of 64 uranium honeycomb blocks (50% chance to drop 9 ores)
I'm assuming this is not expected. Read through the tile entity code and the configs from all the mods and there doesn't seem to be anything obvious.
Ctiers version - 1.121
Resoureful Bees Version - ResourcefulBees-1.16.5-0.6.2b

Download newest Version of Centrifuge Tiers. The Version that ATM 6 currently has is buggy.

Verified this solved my problem locally. However getting the server owner to update it might be another problem ;)

Then good luck ;)


get access to audio stream

Hello,
I have request to implement siprec server which will stream Audio to external endpoint (MS, Google) for STT (Speech to text) .
Can you please point me where in server code I can get access to media stream ?
Thanks

you would need to connect the call through freeswitch, like this app does, but then you would need to use a freeswitch plugin (like my mod_audio_fork to get access the audio stream.
Not that difficult, but not a feature that is current implemented in this repo


I want to modify the sdkconfig configuration by automatically using a custom script (e.g. python) before compiling, how do I modify the cmake implementation? I tried to use add_custom_command PRE_BUILD stage, but it was still relatively backward

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
I want to modify the sdkconfig configuration by automatically using a custom script (e.g. python) before compiling, how do I modify the cmake implementation? I tried to use add_custom_command PRE_BUILD stage, but it was still relatively backward

Thanks for reporting, would you please provide details per the issue template? Thanks.

Thanks for reporting, would you please provide details per the issue template? Thanks.

I use idf5,only want to invoke custom scripts before compiling


specific_position_31s using optimal power item setting produces incredibly wrong, worse results

Testing with a 6IV male and 5IV (missing last slot) female for 5 specific slots. When using the power_item_setting = True setting, the results become dramatically worse, when expectation is results should improve.

Fixed. This is because it used the normal logic for finding the optimal slot for a power item (find a slot where there's a 31 in one parent but not the other), but with the specific slots simulation, the optimal slot is the leftmost viable slot by design. There is now a separate helper function for this version of the simulations.


Consider how to interact with GitHub Government database

Related: GitHub and Government mini-site: Who's Using GitHub
Perhaps we could consider submitting a PR to the data and website to distinguish between levels of gov?
https://github.com/github/government.github.com/blob/gh-pages/_data/governments.yml
Then we could still have this awesome list, but auto-generate it from that file?
Thoughts?

Related: https://github.com/github/government.github.com/issues/75


lt_cred support for TURN REST format

Description
This adds support for the format timestamp:username used with the TURN REST API (https://tools.ietf.org/search/rfc5389#section-10.2).

Hi! We're experiencing a challenge with Pion using REST API compatible (ephemeral) authentication. This may well be in our implementation, but just to make sure we're not chasing ghosts: Has the change mentioned in this PR made it into any release to date? The commit references are a bit tricky to follow through the Github UI.

My changes were removed with the force-push mentioned in this PR. I'm not sure what happened, I might be missing something from the github flow.
I had a GenerateLonTermTURNRESTCredentials() and LongTermTURNRESTAuthHandler() functions to handle the long term credentials support, with an example.
If this is still needed I can try and create a new PR?
Otherwise you can retrieve the missing code from the diff of the forced push.

The functionality is still desirable. As I'm not familiar with the code base (or even the programming language), I'd prefer you (instead of me) recreating the commit.

I agree: this is still a useful feature to have. We have implemented this functionality in STUNner, with the twist that we consider the first thing that parses as a valid unsigned integer as a UNIX timestamp, so we accept both timestamp:username and username:timestamp, and also a plain timestamp (without a user name) or even x:y:z:timestamp as well. This is completely upward compatible with the handler generated by the default NewLongTermAuthHandler, so you don't even need to introduce a separate LongTermTURNRESTAuthHandler.
Please submit as a new PR, I'd be happy to review.

Sounds good; it's been more than a year not using this code base so I'll need a little more time than just recreating the PR (also based on @rg0now 's information).

I've raised https://github.com/pion/turn/pull/370 - CI checks are pending but for the people interested in this feature please take a look and review.


M1 Support

Monitor Control starts on new M1 MacBooks, but the external monitor is not recognized anymore:

I used to see there "LG 4K monitor"

Same problem here with iMac M1. The volume keys work on the keyboard but not the brightness.

Same problem here with iMac M1. The volume keys work on the keyboard but not the brightness.

Duplicate #323

Duplicate #323


Implement sparse image flashing (yet another)

Hi,
unfortunately I didn't see https://github.com/andersson/qdl/pull/5 until I was almost done implementing sparse image flashing as well. However, I thought as I anyway already invested the time I might just open another PR so you can choose what ever solution you prefer.
As far as I can see https://github.com/andersson/qdl/pull/5 does not use the API provided in (include/sparse/sparse.h) which I did. So the only thing that needed to be done was handling input provided by the callback function sparse_file_callback().

Hi,
are there any specific dependencies? Because i cannot build it.
make cc -O2 -Wall -gxml2-config --cflags-I libsparse/include   -c -o firehose.o firehose.c cc -O2 -Wall -gxml2-config --cflags-I libsparse/include   -c -o qdl.o qdl.c cc -O2 -Wall -gxml2-config --cflags-I libsparse/include   -c -o sahara.o sahara.c cc -O2 -Wall -gxml2-config --cflags-I libsparse/include   -c -o util.o util.c cc -O2 -Wall -gxml2-config --cflags-I libsparse/include   -c -o patch.o patch.c cc -O2 -Wall -gxml2-config --cflags-I libsparse/include   -c -o program.o program.c cc -O2 -Wall -gxml2-config --cflags-I libsparse/include   -c -o ufs.o ufs.c make -C libsparse make[1]: Entering directory '/home/c_abozhi/projects/qdl2/libsparse' g++ -O2 -Wall -I include   -c -o backed_block.o backed_block.cpp g++ -O2 -Wall -I include   -c -o output_file.o output_file.cpp g++ -O2 -Wall -I include   -c -o sparse.o sparse.cpp g++ -O2 -Wall -I include   -c -o sparse_crc32.o sparse_crc32.cpp g++ -O2 -Wall -I include   -c -o sparse_err.o sparse_err.cpp g++ -O2 -Wall -I include   -c -o sparse_read.o sparse_read.cpp g++ -O2 -Wall -I include   -c -o stringprintf.o stringprintf.cpp ar rcs libsparse.a backed_block.o output_file.o sparse.o sparse_crc32.o sparse_err.o sparse_read.o stringprintf.o  make[1]: Leaving directory '/home/c_abozhi/projects/qdl2/libsparse' g++ -o qdl firehose.o qdl.o sahara.o util.o patch.o program.o ufs.o libsparse/libsparse.a libsparse/libsparse.axml2-config --libs-ludev /usr/bin/ld: libsparse/libsparse.a(output_file.o): undefined reference to symbol 'gzerror' //lib/x86_64-linux-gnu/libz.so.1: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status Makefile:11: recipe for target 'qdl' failed make: *** [qdl] Error 1

Hi,
are there any specific dependencies? Because i cannot build it.
` make
cc -O2 -Wall -g xml2-config --cflags -I libsparse/include -c -o firehose.o firehose.c
cc -O2 -Wall -g xml2-config --cflags -I libsparse/include -c -o qdl.o qdl.c
cc -O2 -Wall -g xml2-config --cflags -I libsparse/include -c -o sahara.o sahara.c
cc -O2 -Wall -g xml2-config --cflags -I libsparse/include -c -o util.o util.c
cc -O2 -Wall -g xml2-config --cflags -I libsparse/include -c -o patch.o patch.c
cc -O2 -Wall -g xml2-config --cflags -I libsparse/include -c -o program.o program.c
cc -O2 -Wall -g xml2-config --cflags -I libsparse/include -c -o ufs.o ufs.c
make -C libsparse
make[1]: Entering directory '/home/c_abozhi/projects/qdl2/libsparse'
g++ -O2 -Wall -I include -c -o backed_block.o backed_block.cpp
g++ -O2 -Wall -I include -c -o output_file.o output_file.cpp
g++ -O2 -Wall -I include -c -o sparse.o sparse.cpp
g++ -O2 -Wall -I include -c -o sparse_crc32.o sparse_crc32.cpp
g++ -O2 -Wall -I include -c -o sparse_err.o sparse_err.cpp
g++ -O2 -Wall -I include -c -o sparse_read.o sparse_read.cpp
g++ -O2 -Wall -I include -c -o stringprintf.o stringprintf.cpp
ar rcs libsparse.a backed_block.o output_file.o sparse.o sparse_crc32.o sparse_err.o sparse_read.o stringprintf.o
make[1]: Leaving directory '/home/c_abozhi/projects/qdl2/libsparse'
g++ -o qdl firehose.o qdl.o sahara.o util.o patch.o program.o ufs.o libsparse/libsparse.a libsparse/libsparse.a xml2-config --libs -ludev
/usr/bin/ld: libsparse/libsparse.a(output_file.o): undefined reference to symbol 'gzerror'
//lib/x86_64-linux-gnu/libz.so.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
Makefile:11: recipe for target 'qdl' failed
make: *** [qdl] Error 1
`

My bad.. seems like I didn't specfiy -lz. I updated that... For some reason works for me without...
Thanks for the hint ;-)
Could you try again?

Now it works. I have tried to flash some images, but after first sparse image it exits. How is it verified?
[PROGRAM] flashed "abootbak" successfully
LOG: start 790528, num 16384
LOG: Finished sector address 806912
LOG: start 806912, num 28216
LOG: Finished sector address 835128
LOG: start 835128, num 0
LOG: Finished sector address 835128
qdl: failed to read: Connection timed out
[PROGRAM] failed
[PROGRAM] flashed "boot" successfully at 417kB/s
I am trying to flash boot, system, systemrw and user images. They work with my solution. Now i am debugging. Will report back, again.

Now it works. I have tried to flash some images, but after first sparse image it exits. How is it verified?
[PROGRAM] flashed "abootbak" successfully
LOG: start 790528, num 16384
LOG: Finished sector address 806912
LOG: start 806912, num 28216
LOG: Finished sector address 835128
LOG: start 835128, num 0
LOG: Finished sector address 835128
qdl: failed to read: Connection timed out
[PROGRAM] failed
[PROGRAM] flashed "boot" successfully at 417kB/s
I am trying to flash boot, system, systemrw and user images. They work with my solution. Now i am debugging. Will report back, again.

hmm do you have any kind of additional info you can give me? e.g. xmls, or at best also the images? (I flashed some devices and it never failed)
But as I said, I'm fine with your solution as well. Seems to also work for me... I'm not sure if it is then worth spending too much time to debug this here...

Sorry, but i could not share xml and images, because of "Company Policies" .
Why you call firehose_program_sparse_callback at line 544, again? It brokes things on my device.

Sorry, but i could not share xml and images, because of "Company Policies" .
Why you call firehose_program_sparse_callback at line 544, again? It brokes things on my device.

Well if there is still data in the buffer this also needs to be flashed. Flashing is always  performed if a don't care block is reached or the buffer is full. Maybe the buffer is already empty ? That should be checked for sure... Could you retry?

I will retry tomorrow. But what i understand when i read the libsparse code is that sparse_file_callback() process all the file at one pass with don't care chunks. Did you remember where was bug in my code before? This function should write "skip" chunks.

I will retry tomorrow. But what i understand when i read the libsparse code is that sparse_file_callback() process all the file at one pass with don't care chunks. Did you remember where was bug in my code before? This function should write "skip" chunks.

Not sure, if this is what you mean.. But I'd argue that it depends on the use-case if "don't care chunks" have to be written.. Actually, I would even argue if chunks are "don't care", then the image really shouldn't care what kind of data there is (which means for me there I don't have to overwrite existing data).  Am I missing something here?

I mean that all "don't care chunk" are written during sparse_file_callback() and last call of firehose_program_sparse_callback() is not needed. Function that writes it is named callback_file_skip().  Also all data should be overwritten, i didn't mean anything else.

I mean that all "don't care chunk" are written during sparse_file_callback() and last call of firehose_program_sparse_callback() is not needed. Function that writes it is named callback_file_skip(). Also all data should be overwritten, i didn't mean anything else.

I just checked your implementation, and from what i saw you are doing the exact same thing, not write the don't care chunks (as they obviously do not contain data). From what I see the don't care chunks are not written during the flash (i expect the data agrument of firehose_program_sparse_callback() to be NULL in that case).
Also I figured out why it's failing, increasing the timeout fixed it for me. Maybe you also want to retry... The last call is indeed needed because the buffer may still contain data that hasn't been flashed yet. That, however, depends on the sparse image itself.

No, i am writing, i just modified source to pass zero filled buffer. So in my callback i do not process NULL case.
For the second paragraph, i think it is better just to send data on 1 megabyte chunk like in my code. Because sparse callback returns a lot 4096kb buffers and when they are send rapidly fast as Host PC is times faster device programmer fails. This with timeouts is workaround for me, because if image is bigger then usual, writing will fail again.

we have got this patch now in production for more than 6 months. Images have increased in size quite some and we haven't seen any issues (with quite some flashes of different images per day), so I don't think that the timeout thing is an actual issue. From my point this is certainly well-tested.

@andersson what are your thoughts on merging this?  Happy to help


oe_mount has an access violation when fed an invalid file system name

In oe_mount mount_point_t is not initialized.
If line 142 fails  "device = oe_device_table_find(filesystemtype, OE_DEVICE_TYPE_FILE_SYSTEM); "
then we go to done:
if (mount_point.path)
oe_free(mount_point.path);
But since mount_point.path was not initialized to null, it has an access violation.

Good find Radhika


Add bootscore_container_class() function

Allows you to optionally create fluid layouts.
If constant BOOTSCORE_CONTAINER_FLUID is true, the  'container-fluid' class is output in all current templates

The reason for using the constant was so that people would have to very deliberately choose to use fluid layouts. If it's made too "easy", then the project maintainers are likely to get more complaints that the default styling looks odd on fluid layouts and hence creates more work...
But if you'd prefer it's made pluggable I'm happy to do that.

Refactored to be pluggable as requested.
If that's ok will create a pull request for bs-loop-templates

https://bootscore.me/documentation/fluid-layout/


Add schema validation to config files

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3029
Originally created by @kgpayne on 2021-10-28 09:58:07

Problem to solve
Today, config is loaded from YAML into a dict and passed directly to the Canonical class to create an object representation. This approach is naive - no validation is done on the input YAML file. This is even more important to add after #2456 as 'subfiles' support a subset of config that is definable in meltano.yml (i.e. they have different schemas).
Target audience
Anyone using the Meltano.
Further details
This is somewhat related to

https://github.com/meltano/meltano/issues/2925 and
https://github.com/meltano/meltano/issues/2133

on refactoring the way we handle and represent config internally.
Proposal

define schemas for each config type
check the shape of config dictionaries against their expected schema on load and dump

What does success look like, and how can we measure that?
Invalid config manifests as config load errors, rather than either 'unexpected parameter' errors or silent ignores of added config in unexpected places.
Regression test
(Ensure the feature doesn't cause any regressions)

[ ] Write adequate test cases and submit test results
[ ] Test results should be reviewed by a person from the team

Links / references
Please note that this was taken from GitLab, to be changed accordingly

View 6 previous comments from the original issue on GitLab

Here are some recommendations after thinking about this a bit:
Here are a couple of recommendations:

implement the validation as a warning first (don't fail). There may be some things that your schema validation would fail on, but are working today. Erroring on new validation errors should be considered a breaking change.
Validate opportunistically. You can obviously dictate the overall schema of the file, but I believe it will be impossible to dictate the schema of the plugins. Therefore, the schema validation should support a plugin model where each of the taps/targets can provide a schema validation file and if present the schema validation process will use it. If such file is not present for a tap/target then the schema validation process will ignore that portion of the meltano.yml file.
Validate fully. The validation process should validate the entire file and then report all of the issues found rather than erroring and quitting on the first issue.
meltano cli override. The cli needs a flag to either skip validation or just ignore any errors. As this is an open source project, it's entirely likely a plugin contributor could make a mistake in validation schema and it should be super easy for someone running the CLI to ignore errors. Perhaps the best bet to handle #1 and #4 is a new argument --validation with possible values of "disabled" and "strict" where

by default if the argument is not used, validation runs and issues are reported as warnings, but the process continues
"disabled" - skips the validation entirely (doesn't run, no output)
"strict" - issues are reported as errors and the process stops after completing the validation
This should also be supported in the meltano.yml file as default_validation. I don't want to have to remember every time how to a particular project should be run. However, if I use the cli argument or an env variable, it will override the default behavior specified in the file - I believe this is just how default_environment works.

Per plugin override. There also needs to be a way to specify the "--validation" behavior on a per plugin-basis. Just because one plugin has broken validation, I don't want to disable or ignore all other validation. I believe this should be configured in each plugin's section of the meltano.yml.

This is still relevant.

still relevant stalebot 😑


Add ability to overwrite the architecture used when installing

This uses a similar environment variable override supported by asdf-hashicorp for overriding the target architecture used to download the binary, which is useful when installing older versions of terragrunt that did not publish darwin/arm64 binaries.

This would be a really useful feature to add. Is there anything blocking this? Or another workaround?

+1 @ohmer can you merge that?

+1

This PR has been around for forever. I think it's time we fork and move on.

This PR has been around for forever. Unfortunately Ohmer might have a lot going on, so I think it's time we fork and move on.

So sorry folks, forgot about this and I don't use terragrunt anymore. Happy to merge without testing. Please take ownership of this if you want to.

This PR has been around for forever. Unfortunately Ohmer might have a lot going on, so I think it's time we fork and move on.

So sorry folks, forgot about this and I don't use terragrunt anymore. Happy to merge without testing. Please take ownership of this if you want to.

No worries! That actually might be something the community might be open to doing since you don't use the tool anymore.
FWIW, I did verify it worked, installing the plugin from the fork. So it should be good to go.

Please take ownership of this if you want to.

I'll ask around internally (I work at Gruntwork, maintainer of Terragrunt) to see if there is interest in having a gruntwork-io/asdf-terragrunt repo. If not, I'll maintain a fork personally since I use this everyday.

@yorinasub17 reviving an old thread but please see #3. Anyone at Gruntwork keen?

Heya! Unfortunately, I've moved on from Gruntwork since I opened this, and I was the only one using asdf there, so there wasn't a lot of interest in maintaining this outside of me. I would take it up if I was still using terragrunt, but I currently am not using it...
Sorry I can't be of help here!

all good, thanks for the update @yorinasub17!


Issue with authentication

I am encountering an authentication issue while attempting to pass the username and password via an .env file:
GOTENBERG_ENDPOINT=http://gotenberg:3000
GOTENBERG_API_BASIC_AUTH_USERNAME=user
GOTENBERG_API_BASIC_AUTH_PASSWORD=pass
My docker-compose.yml file:
gotenberg:
image: gotenberg/gotenberg:8.6.0
environment:
GOTENBERG_API_BASIC_AUTH_USERNAME: user
GOTENBERG_API_BASIC_AUTH_PASSWORD: pass
command: gotenberg --api-enable-basic-auth
networks:
- internal
Despite correctly setting up the environment variables, I consistently receive a 401 Unauthorized error when the application attempts to authenticate using these credentials.
But It works when I change the files like this:
GOTENBERG_ENDPOINT=http://gotenberg:3000
GOTENBERG_API_BASIC_AUTH_USERNAME=user
GOTENBERG_API_BASIC_AUTH_PASSWORD=user
docker-compose.yml:
gotenberg:
image: gotenberg/gotenberg:8.6.0
environment:
GOTENBERG_API_BASIC_AUTH_USERNAME: user
GOTENBERG_API_BASIC_AUTH_PASSWORD: user
command: gotenberg --api-enable-basic-auth
networks:
- internal

@forg002-ctrl Thank you for reporting the bug. I will release a fix shortly.

@forg002-ctrl version 3.3.2 has been released with the fix included 🚀  Thanks again and please try it and let me know if it resolves the issue 👍

@cherfia It works, thanks a lot for quick fix.