jsnext:main should point to a distributable ES6 bundle

It's not currently spelt out in the wiki page, but jsnext:main is apparently meant to point to a distributable ES6 bundle rather than to the source code. For example, see:

Unfortunately, Redux's jsnext:main points to its source code, not a distributable ES6 bundle. Because of that, the build process for this repo needs to transpile Redux's source code. Redux uses Babel 5, this repo uses Babel 6, causing the build to fail. These kinds of incompatibilities are why jsnext:main should not be used to point to source code.

taken from this comment.

Hmm. What is a “distributable ES6 bundle”? Something that doesn’t have import and export statements?

@dchambers So basically what we need is to run babel on src to most of the transforms, but exclude the module transforms so that import and export remain in the transpiled src directory?

Hmm. What is a “distributable ES6 bundle”? Something that doesn’t have import and export statements?

Good question! I did wonder myself, but assumed it was only me that didn't quite get it :-). @Rich-Harris, can you clarify please?

Other than that possibility, it could either mean that it needs to be bundled in to a single file (which I think defeats the purpose of Rollup, so I imagine it is not that case) or that the es7 features used in the codebase are the blocker. There isn't extensive usage of es7 but the object spread operation would probably be enough to make it "not es6 distributable"
I'm sure Rich-Harris can provide a solid answer, though.

Sure, I'll try and clarify – but with the caveat that this is my interpretation! Unfortunately as a community we haven't quite figured out a consensus on how to transition to ES6 modules – there's lots of room for different views on how exactly to go about it. There's a thread over here though if you'd like to participate --> https://github.com/jsforum/jsforum/issues/5
'Distributable ES6 bundle' is a poorly-chosen phrase but I meant code that is runnable except for the import/export statements. I've found that packages exposing untranspiled source code causes all sorts of problems, because any consuming code needs to take care of that package's transpilation (for example, if I'm consuming Redux via its jsnext:main, I need to transpile stage 0 features). Apart from the extra work this entails (in the form of longer builds for the consuming package, etc) this causes all sorts of headaches when (for example) the consuming package is running a different version of Babel from the consumed package.
You might reasonably ask what's so special about import and export – aren't they just ES6 language features like any other? Personally I think it makes sense to draw a distinction, because import and export are about how code gets into your app or library, whereas everything else is about what it does once it's there (another way of looking at it: you can only transpile arrow functions one way, but you can transpile import and export to AMD, CommonJS, or whatever else depending on the target environment).
In an ideal world we wouldn't need jsnext:main because we'd be able to have a UMD block that encompassed all the different formats – AMD, CommonJS, browser globals, ES6 – but unfortunately import and export can't coexist with the other forms. Because of that, the only way we'll ever be able to transition JavaScript away from legacy module formats is if we have a transitional measure that allows package authors to distribute UMD and ES6 simultaneously, and jsnext:main is the best candidate I've come across yet. But if it's used to mean 'any upcoming JavaScript syntax' then I believe it creates more problems than it solves.
Apologies for the long answer, I didn't have time to write a shorter one :wink:

So it sounds like there are few options:

Don't add jsnext:main
In the npm publish process, compile the src directory with all but the module transforms and add jsnext:main pointing to this compiled src dir.
Expose the src directory as is(es6/es7) and add jsnext:main pointing to it( which puts the burden on the consumer)

Did I miss any options?

Also, how does this relate to #964? It seems like that PR wouldn't work without this issue being handled, right?

Did I miss any options?

The fourth option – let's call it 2b – is to create a single file containing the whole of Redux, but as an ES6 module. It would look like this: https://gist.github.com/Rich-Harris/d3269558c4cd30a3f41b This is basically the same as the current UMD build, but, well, without the UMD. There isn't really any advantage in this case to exposing a directory that mirrored the structure of src but with transpiled-except-modules JavaScript – bundling is better.
It's orthogonal to #964, which is purely about a faster/leaner UMD build. That PR is ready to go – it's entirely up to @gaearon and the other contributors whether they want to use it or not.

BTW, this is how we're considering setting things up for React Router: https://github.com/rackt/react-router/pull/2530.
By my understanding, jsnext:main should point to just another transpiled build, but one targeting ES6 modules rather than CJS modules.

@taion Yea, that looks to be about what I was thinking would work too. To be candid about this though: I probably wouldn't have suggested adding jsnext:main if I had known/understood about this aspect of it.

I'm coming at this from the sidelines a bit - I think for a package like React Router where most users will use most of the exported things, the practical benefit of adding an ES6 build is pretty minimal. My vague understanding of Redux is that it's in the same boat.
Packages that would help their users by distributing a build in this format would be more like history or React-Bootstrap, where any given user will only use a small subset of what is exported - it's much cleaner to just do a named export from the top-level package directly, rather than e.g. reaching into history/lib just to get around the impossibility of tree-shaking when using transpiled CJS modules.

@danmartinez101
I'm curious why you'd recommend against adding that jsnext:main, though. When using Babel 5, it's easy enough to just blacklist the es6.modules transform for a separate build. It seems like an easy enough win to me.

I don't mean that I would recommend against it; I just mean that I wouldn't have initially suggested it in https://github.com/rackt/react-redux/pull/186 (which I now realize isn't even in this project). Basically, I have no strong opinion for or against it.

Hah. Okay. Yes, we turned down a PR on React Router to the same effect: https://github.com/rackt/react-router/pull/2523
I'd assert that https://github.com/rackt/react-redux/pull/186 is incorrect - but there is an easy solution, one that I think as many libraries as possible should try to take.

I'm coming at this from the sidelines a bit - I think for a package like React Router where most users will use most of the exported things, the practical benefit of adding an ES6 build is pretty minimal. My vague understanding of Redux is that it's in the same boat.

It's not just about whether the user only uses parts of your library, it's also about whether you only use parts of the libraries you use, etc, because this benefit will be transitive.

@gaearon Do you want this set up per https://github.com/rackt/react-router/pull/2530? I can put together a PR. About to update both React Router and history to do this shortly.

So any consensus here?

IMO the best/easiest build setup available is something like what we have on the React Router and history repos. It's a little harder with Babel 6, because you can't just blacklist the module transform and instead have to make an "es2015-without-module-transform" preset, but you don't need rollup to build an ES6 module build.

Who does this benefit?

Almost nobody - in theory rollup and webpack 2 users, but you can't really bundle an application with rollup, and the webpack 2 beta isn't quite usable yet.
More importantly, the tree-shaking benefit is almost non-existent here, too, given how small Redux is.
Especially if you're looking at moving to Babel 6 soon, IMO just drop the jsnext:main and we all stop worrying about this for now :p

Hi I'm using rollup and would love to rollup redux in my app. Since you use jsnext:main please distributable an ES6 bundle

Please give your comments on https://github.com/rackt/redux/pull/1369.

Fixed in 3.3.0.


Base line traffic analysis and alerts

Given that we have about a week of traffic data, we should start baselining our alerts to detect significant variances (ex. traffic drops 50%).
Risk: We could be alerted to frequently or not frequently enough because the alerts are not calibrated to reflect the current reality.
AC:

[ ] analyze traffic
[ ] update alerts

This should be done periodically to refine alerts.

We are more or less already doing this regularly


Trojan -- Coin Miner -- Severe Threat

I'm submitting a  Trojan --Coin Miner -- Severe Threat

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
[x ] Other: <!-- Please describe: -->

Current behavior

Expected behavior

Environment
Browser:

- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:

- Live Server: <!-- Check which version is installed -->
- Platform:  <!-- Mac, Linux, Windows -->
- Visual Studio Code: <!-- `code --version` -->

Others
I did a full scan of my PC with Windows Defender on 7/7/2019 and it found this Trojan on my PC.  It was linked to vscode-live-server.  Just letting you know.  SEE THE FOLLOWING:
Log Name:      Microsoft-Windows-Windows Defender/Operational
Source:        Microsoft-Windows-Windows Defender
Date:          7/7/2019 9:01:23 PM
Event ID:      1116
Task Category: None
Level:         Warning
Keywords:
User:          SYSTEM
Computer:      DESKTOP-MOGD7TL
Description:
Windows Defender Antivirus has detected malware or other potentially unwanted software.
For more information please see the following:
https://go.microsoft.com/fwlink/?linkid=37020&name=Trojan:JS/CoinMiner&threatid=2147727229&enterprise=0
Name: Trojan:JS/CoinMiner
ID:<PHONE_NUMBER>
Severity: Severe
Category: Trojan
Path: file:_G:\FileHistory\walter\DESKTOP-1NF9UKV\Data\C\Users\walter.vscode\extensions\ritwickdey.liveserver-5.2.0\node_modules\flatmap-stream\index.min (2018_11_18 16_52_35 UTC).js; file:_G:\FileHistory\walter\DESKTOP-1NF9UKV\Data\C\Users\walter.vscode\extensions\ritwickdey.liveserver-5.2.0\node_modules\flatmap-stream\test\data (2018_11_18 16_52_35 UTC).js
Detection Origin: Local machine
Detection Type: Concrete
Detection Source: User
User: DESKTOP-MOGD7TL\jf201
Process Name: Unknown
Security intelligence Version: AV: 1.297.610.0, AS: 1.297.610.0, NIS: 1.297.610.0
Engine Version: AM: 1.1.16100.4, NIS: 1.1.16100.4
Event Xml:

1116
0
3
0
0
0x8000000000000000

566

Microsoft-Windows-Windows Defender/Operational
DESKTOP-MOGD7TL

%%827
4.18.1905.4
{95208A7C-9E69-4DB4-9879-6D65DB1F0F8F}
2019-07-08T02:01:16.741Z

2147727229
Trojan:JS/CoinMiner
5
Severe
8
Trojan
https://go.microsoft.com/fwlink/?linkid=37020&name=Trojan:JS/CoinMiner&threatid=2147727229&enterprise=0
1

1
1
%%815
Unknown
DESKTOP-MOGD7TL\jf201

file:_G:\FileHistory\walter\DESKTOP-1NF9UKV\Data\C\Users\walter.vscode\extensions\ritwickdey.liveserver-5.2.0\node_modules\flatmap-stream\index.min (2018_11_18 16_52_35 UTC).js; file:_G:\FileHistory\walter\DESKTOP-1NF9UKV\Data\C\Users\walter.vscode\extensions\ritwickdey.liveserver-5.2.0\node_modules\flatmap-stream\test\data (2018_11_18 16_52_35 UTC).js
1
%%845
0
%%812
0
%%822
0
9
%%887

0x00000000
The operation completed successfully.

0
0
No additional actions required

AV: 1.297.610.0, AS: 1.297.610.0, NIS: 1.297.610.0
AM: 1.1.16100.4, NIS: 1.1.16100.4

FYI, there was a security issue with one of the dependencies.
This was apparently dealt with by the npm people back in November of 2018.
The hack was targeted, and only affected people using the Copay app.
Regardless, the issue has been dealt with, so we can close the issue now.


Fix: Home Assistant 2023.8 MQTT

This PR:

Adds changes required to be compatible with MQTT requirements of Home Assistant 2023.8 and up (https://github.com/LAB02-Research/HASS.Agent/issues/337)

adds "object_id" property support to the discovery message (which is used by HA to generate entity ids)
modifies the MQTT topic to use the "object_id" instead of "name" property (details below)

"object_id" will be composed of device name and sensor name if not explicitly assigned (details below)

removes all explicit device name additions in Multi Value Sensors
adds a warning message when a new sensor/command is to be created with name containing the device name, and the HASS.Agent is connected to HA version 2023.8 and up

Adds "compat_names" launch argument which will

convert all compatible sensors and commands to use new naming scheme (details below)
republish the MQTT discovery topics
exit

Modifies HassApiManager to expose public HaVersion property
Adds CompatHelper class which should contain all compatibility related functions
Adds "Compatibility Task" interface and form to easily handle any future compatibility tasks

"object_id" logic:
Unless explicitly assigned in given sensor's or command's code, it will follow "_" scheme
Sensor/command conversion logic:

if the current sensor/command doesn't contain device name it will be skipped and has to be renamed manually
if the current sensor/command contains device name and uses pre 2023.8 naming i.e. "SOME-PC_cpuload" it will be converted to "cpuload"
if the current sensor/command contains device name and uses custom naming i.e. "someprefix_SOME-PC_cpuload" it will be skipped and has to be renamed manually

Compatibility interface running the name change task:

Warning message when trying to add a sensor/command containing the device name, and HASS.Agent is connected to HA version 2023.8 and up:

Comparison between "normal" and converted sensors/commands:
Before:

After:

Since the entity IDs stay the same (conversion task has a check for this) the entity history is preserved for HA:
(examples are taken after conversion task was run on 11.08.2023)

(please note that the "cpuload" sensor values are garbage due to performance counter bug - https://github.com/LAB02-Research/HASS.Agent.Staging/pull/16)

Will this EVER make its way into a stable HASS agent release (still following https://github.com/LAB02-Research/HASS.Agent/issues/337) ?

As this is my PR I'll allow myself to answer.
With our best knowledge, not soon? Sam is currently MIA - we have a fork that we try to keep updated and put a new feature here and there: https://github.com/hass-agent/HASS.Agent?tab=readme-ov-file#fork

As this is my PR I'll allow myself to answer. With our best knowledge, not soon? Sam is currently MIA - we have a fork that we try to keep updated and put a new feature here and there: https://github.com/hass-agent/HASS.Agent?tab=readme-ov-file#fork

Got it, started migrating already an hour ago, still on the first client. I now have plenty of MQTT topics: many with the old naming and few already with the new naming (formerly: Devicename_sensorname, now: DeviceUniqueID_sensorname). A bit of a mess in MQTT and therefore doubled entities (with _2 suffix) in Home Assistant... so it's a lot of work to clean everything and I still don't know if there's a more efficient way to do so (how to get rid of the old/original integrations' MQTT topics?).


Drawing heatmap view with Metal

I'm searching for this issue slowly. https://stackoverflow.com/questions/61154192/are-there-recommended-ways-for-drawing-2d-array-in-fast-time

Thanks for the great repo!
Any updates on this issue??

Here it is! @jsharp83 made the optimized post-process logic using Metal and it's really fast!
https://github.com/jsharp83/MetalCamera
I plan to adapt it to this repo later.

Logic flow of MetalCamera's segmentation example

https://github.com/jsharp83/MetalCamera/blob/master/Example/MetalCamera/SegmentationSampleViewController.swift


Add SyncFinished message to the network protocol

This PR changes the following:

Removes passing an information about a node being a joiner at the moment the connection is established

Introduces the ChainSynchronizerAnnouncement with SyncFinished variant. It is announced in two cases

when node is not configured to sync_to_genesis it is sent immediately after the participating reactor spins up the chain synchronize component
otherwise, it is sent after the sync_to_genesis is completed

Makes the small_network component aware of whether the node is in the sync state (chain_sync_in_progress flag, by default set to true)

Makes the small_network react to the SyncFinished event, setting the above flag to false and broadcasting the SyncFinished message to all connected peers

After the connection between peers is established and node already finished syncing, it'll also send the SyncFinished message to the peer

Closes #3173

Adding the do not merge label, because some housekeeping needs to be done after https://github.com/casper-network/casper-node/pull/3167 is merged.

In the meantime, is it possible to have the small_network not advertise itself as syncing when constructed inside the participating reactor where sync-to-genesis is disabled?

It could, it'd just add more logic. The current approach just reused the functionality we need anyway, and the savings is a 1-second reconnection cycle from clients, so we opted for that. As a nice side effect, we exercise the otherwise rarely hit code path :)

bors r+


Release v4.4.0

Process bug for preparing 4.4.0 release.
Mostly just here to serve as a comment thread for discussing the release...

@mdengler @jcrowgey @insanum @michaelmhoffman FYI

I've finished all the tasks I'd planned for the 4.4 release except for any straightforward auth improvements (and getting more PRs merged). @mdengler could you look through my 2 PRs I sent you #694 and #700?
Then @insanum @jcrowgey we'll need permission to push an update to PyPI. Is it doable to grant me access to that?
And then my focus for remaining changes will be revisiting auth, #692. I'll be digging in to investigate how it's currently set up and possible directions, but I could use more eyes on that discussion.

I've now landed all the changes I was hoping to get into a 4.4 release!
Just figuring out publishing logistics now...

@jcrowgey can you grant me access to push gcalcli to testpypi and pypi? Looks like you and @tresni are the only ones with access. Some details at https://pypi.org/help/#project-name.

I'm certainly not opposed to doing so!  It may take a minute to dig up my own credentials, tho.
On August 27, 2024 1:28:32 PM PDT, David Barnett @.***> wrote:

@jcrowgey can you grant me access to push gcalcli to testpypi and pypi? Looks like you and @tresni are the only ones with access. Some details at https://pypi.org/help/#project-name.
--
Reply to this email directly or view it on GitHub:
https://github.com/insanum/gcalcli/issues/706#issuecomment-2313451832
You are receiving this because you were mentioned.
Message ID: @.***>

It took me a minute, but I was able to recovery my pypi account.  What
is your pypi identity?
On Tue, Aug 27, 2024 at 01:28:32PM -0700, David Barnett wrote:

@jcrowgey can you grant me access to push gcalcli to testpypi and pypi? Looks like you and @tresni are the only ones with access. Some details at https://pypi.org/help/#project-name.
--
Reply to this email directly or view it on GitHub:
https://github.com/insanum/gcalcli/issues/706#issuecomment-2313451832
You are receiving this because you were mentioned.
Message ID: @.***>

It's https://pypi.org/user/dbarnett/ + https://test.pypi.org/user/mu_mind/. Thanks!

Release is live on PyPI! https://pypi.org/project/gcalcli/4.4.0/
Now to get to work on the real fun in the next milestone, 4.5: https://github.com/insanum/gcalcli/milestone/10

Hi @dbarnett, I have not been able to look at this until now. Two things of note that I added earlier are:

new agendaupdate subcommand (#550/#557/#577): this allows bulk changes with a whole TSV full of events to be updated
As part of this, agendaupdate --tsv now has a header row (97e21b17d8e2e9bc682eccd9cdba9ce6cbc0161a). This enables easier editing with agendaupdate which requires it. But it's also a breaking change for anything that expected to use the TSV output without a header row. I intended that the next version might be a major release because of this but of course have not been able to keep up.

I have some scripts I could post somewhere to demonstrate how to use these, but they were designed entirely for my own use and do not meet the usual standard for gcalcli code (that is not sarcasm—despite frequent complaints in the issue tracker, I use gcalcli daily, and it works quite well for me), so probably don't belong in the main repo.

Also, please accept my personal thanks for taking on the leadership of this project. Very much appreciated.

Couldn't agree more. Much appreciation. David, you've been a machine! :-)
On Mon, Sep 16, 2024 at 11:37 AM Michael Hoffman @.***>
wrote:

Also, please accept my personal thanks for taking on the leadership of
this project. Very much appreciated.
—
Reply to this email directly, view it on GitHub
https://github.com/insanum/gcalcli/issues/706#issuecomment-2353642410,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD55I5IP7VOWNSMWTZZ7R3ZW4QOFAVCNFSM6AAAAABNCBYIF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJTGY2DENBRGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Aww, thank you! It's been really cool being able to jump into the gcalcli project you've built and revitalize things. :heart:
@michaelmhoffman happy to help get your agendaupdate changes moving again. I'm still trying to get my head around the changes there and current status. Shall I follow up on #550 with general questions/clarifications, or is there a different place to discuss that'd work better?

I am much more responsive over email. My GitHub notifications are overwhelming, frankly.


:arrow_up: increase total results to 10

Description

Related Issue

Motivation and Context

Checklist

[ ] An ADR
[ ] New and/or updated tests
[ ] Changes log in CHANGELOG

Superseded by #419


Add nice search urls

This redirects search results from /?s=query to /search/query/ so that we can better handle DOS attacks through better targeted CloudFront rules.
Compatibility is enabled for Yoast SEO in case the plugin is activated in the future.
@serena-piccioni I would appreciate help with the test writing. In particular, testing the successful redirection and the Yoast compatibility.

Thanks for your help with the test @serena-piccioni. I've also tidied up the commit history.


Re-Configure renovate bot for devfile/registry

Which area is this issue related to?
/area ci
/area registry
Issue Description
After our onboarding to konflux we are receiving a slightly bigger number of PRs opened by the konflux bot. We might want to configure the new bot in a way that brings less noise with new updates
Acceptance Criteria

[ ] The old redhat renovate bot has been removed
[ ] The konflux renovate bot follow the same configuration with the old bot

Regarding the case that the new bot creates two PRs for the same image, I noticed it was coming from two different bots. Example:

https://github.com/devfile/registry/pull/517
https://github.com/devfile/registry/pull/519

Regarding the case that the new bot creates two PRs for the same image, I noticed it was coming from two different bots. Example:
* [chore(deps): update registry.access.redhat.com/ubi9/python-39 docker tag to v9 registry#517](https://github.com/devfile/registry/pull/517)

* [chore(deps): update registry.access.redhat.com/ubi9/python-39 docker tag to v1-1733173511 registry#519](https://github.com/devfile/registry/pull/519)

@thepetk First one is renovate bot, second one is Konflux bot

Regarding the case that the new bot creates two PRs for the same image, I noticed it was coming from two different bots. Example:
* [chore(deps): update registry.access.redhat.com/ubi9/python-39 docker tag to v9 registry#517](https://github.com/devfile/registry/pull/517)

* [chore(deps): update registry.access.redhat.com/ubi9/python-39 docker tag to v1-1733173511 registry#519](https://github.com/devfile/registry/pull/519)

@thepetk First one is renovate bot, second one is Konflux bot

yeap exactly!

Regarding the case that the new bot creates two PRs for the same image, I noticed it was coming from two different bots. Example:
* [chore(deps): update registry.access.redhat.com/ubi9/python-39 docker tag to v9 registry#517](https://github.com/devfile/registry/pull/517)

* [chore(deps): update registry.access.redhat.com/ubi9/python-39 docker tag to v1-1733173511 registry#519](https://github.com/devfile/registry/pull/519)

@thepetk First one is renovate bot, second one is Konflux bot

yeap exactly!

What's interesting is that the Konflux bot change seems more what I'd expect, the renovate bot one is trying to leap to a much higher version tag :thinking:


Ayomide/testsuit

@Wizdave97 All requested changes have been resolved. Please look into it.

Update the branch

@Wizdave97  Branch updated


Roll Flutter Engine from 7e8fefe4a084 to 7667c8a12ce6 (4 revisions)

https://github.com/flutter/engine/compare/7e8fefe4a084...7667c8a12ce6
2024-02-29<EMAIL_ADDRESS>[Impeller] remove warning about device transient depth+stencil. (flutter/engine#51033)
2024-02-29<EMAIL_ADDRESS>Refactor GL rendering to prepare for GTK4 (flutter/engine#50754)
2024-02-29<EMAIL_ADDRESS>Reland "[skwasm] Clip pictures if they go beyond the bounds of the window." (flutter/engine#51077)
2024-02-29<EMAIL_ADDRESS>Revert "[macOS] Use CVDisplayLink to drive repaint (#49159)" (flutter/engine#51095)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Encountered the following questions, how do you solve the problem

[root@localhost ~]# zabbix_get -s <IP_ADDRESS> -k docker.containers[3960a2551658,memory]
Traceback (most recent call last):
File "/etc/zabbix/scripts/docker/discover.py", line 256, in
memory(args)
File "/etc/zabbix/scripts/docker/discover.py", line 213, in memory
memory_usage_last = single_stat_update(args, container_dir, "memory.usage_in_bytes")
File "/etc/zabbix/scripts/docker/discover.py", line 163, in single_stat_update
os.mkdir(args.container)
OSError: [Errno 13] Permission denied: '3960a2551658'
Error as shown above, I have tried to add zabbix to sudo, but have been prompted for the error, trouble you helping me

Can you provide more details? How do you run the container? what changes did you make with it after launch? As can be seen from the error, the program can not create (no permissions) the collection directory where the statistics will be temporarily stored.
PS I am not the developer of this program, but I actively use it without problems

I did not do anything on my docker is running through the root user.And zabbix added to the root group and docker group, from the error analysis, I would like to be underridden, your Python is 2 or 3?

most likely the problem is not in the version of the program, try to change the owner of the directory /etc/zabbix/scripts/docker/ to zabbix, like : sudo chown zabbix /etc/zabbix/scripts/docker/

Thank you, have been able to work properly.


Cannot run tunnelmole

Despite having no tunnels open, no instances of tunnel mole running on the computer, after restarting, and after reinstalling tunnel mole, I am getting this message at every run:

Hey there 👋

It looks like you're liking Tunnelmole enough that you've tried to scale things up by opening more than one connection simultaneously - fantastic!

However, as a free user, you are currently limited to one connection at a time. But, we have a solution! Our paid plans offer the freedom of multiple concurrent connections - simply perfect for your needs.

Explore our range of plans and boost your productivity by keeping multiple connections active all at once.

Ready to upgrade your user experience and streamline your workflows? Visit https://t.ly/TrtJz

Please either provide a way to downgrade, provide a way to cancel the tunnel from the server side, or some other way to rectify the situation.

Temporarily circumvented by dropping to version 2.0
(I assume)
curl https://install.tunnelmole.com/n20d0/install && sudo bash install

You could potentially have stale connections on the server side. In which case, waiting one hour will clear them out so you can try again.


Refactor linalg module

I want to use this issue to share a heads-up on a big refactoring that I plan for the linalg module.
During last couple of month I've seen on multiple occasions limitations and shortcomings imposed by the current design of the BaseVector and BaseMatrix. To mention a couple here:

It is not possible to define an instance of BaseMatrix that holds string, integer type values.
BaseMatrix is not designed to hold values that belong to multiple types
Some algorithms, e.g. RandomForest, does not use most methods defined in the BaseMatrix and BaseVector. Some preprocessing methods that we plan for future, like LabelEncoder will not need linear algebra routines defined for both classes.
Some basic operations, like get row or get column, perform unnecessary copy. This problem stems from the fact that both structs do not provide views or iterators that lets developer access an internal structure of the data.
All operations are defined as functions. While this is not a big deal it leads to a clumsy looking code. Instead it would be nice to use more traits defined in std::ops

As a result, I'd like to see how can we use Rust's type system to design a better container for data that solves all these shortcomings.
I am open to any suggestions you have. Feel free to post your ideas here.

As for the multi-type,
Perhaps we can use something like Apache Arraow's arrays to construct a multi-type dataframe  (https://docs.rs/arrow/3.0.0/arrow/record_batch/struct.RecordBatch.html)

@gaxler I like the idea of building 2- and 1- dimensional array on top of Apache Arrow, but I'd like it to be optional. The linalg module provides an abstraction layer around data, it should not force developers to use any concrete libraries like ndarray, nalgebra or apache arrow to hold the data. I'd like to keep it this way to make sure we can add new array types as easy as possible.
Btw, last time  I've checked Arrow's Arrays are immutable. Not sure how we will use immutable array in algorithms that need to change a small portion of the data while leaving every other cell intact.

@VolodymyrOrlov I agree on Arrow being optional, I meant to use Arrow as some form of reference for multi-datatpye structures.
BaseDataFrame trait will be the general API.
As for mutability, you are right. We won't be able to do something like in place decomposition and will need to produce a new matrix. I don't mean for the DataFrame to replace Matrix<RealNumner>, in this case I guess Arrow will be used to preprocess and cast to a real metrix.


I am crating a PR that will fix both the issues by moving both import and actual tach execution inside a Try Catch. This is done by creating another file start.py and moving the entry from main class of cli.py to start class of start.py
From now onward's this is how execution will exit.

This is how our start.py will look like:
from __future__ import annotations

import sys

def start():
    try:
        from tach.cli import main
        main()
    except KeyboardInterrupt:
        print("Exiting...")
        sys.exit(1)

if __name__ == "__main__":
    start()

This looks good! It just looks like it needs to be formatted by ruff to pass the CI check, and the tach.yml configuration should be updated.


Extra extra large screen support (xxl)

There was an issue with the screen breaking at resolutions over 1400px.

Thanks buddy, will be added in the next release


Update TemporaryKey.pfx

Updated with new self-signed certificate since the old one has expired.
The certificate was generated following the same procedure as in #354
New-SelfSignedCertificate -Type Custom -Subject "CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" -KeyUsage DigitalSignature -FriendlyName "Calculator (Dev)" -CertStoreLocation "Cert:\LocalMachine\My" -TextExtension @("<IP_ADDRESS>={text}<IP_ADDRESS>.<IP_ADDRESS>.3", "<IP_ADDRESS>={text}")
Export-PfxCertificate -cert "Cert:\LocalMachine\My\<thumbprint>" -FilePath C:\TemporaryKey.pfx -Password (new-object System.Security.SecureString)

I thought Microsoft needed to sign it?

All our public CI builds use a self-signed certificate. When we release the app to the Store, we have an internal process which signs the app with a trusted certificate.

Thank you


Rewrite the query evaluator

The current query evaluator is pull-base and quite naive.
We could maybe explore query compilation. This SIGMOD'18 paper seems quite interesting on this topic.
If we do that, we would have at least a simple Rust interpreter to support WebAssembly and simple installation and maybe an optional JIT/compiler based on cranelift or LLVM.

See also #780


Remove OpenAPI from onboarding flow

Please remove the Generate OpenAPI page from the onboarding instructions. You'll need to update @appland/components to most recent version for this change.

Testing:
The webview part can't be tested with our JUnit tests. A tester has to ensure that

the install instructions webview doesn't show the OpenAPI page anymore
the action to manually create OpenAPI is still working as before (Tools > AppMap > Generate OpenAPI)


merged v.0.6.2

I've added small but useful changes, such as suggesting a name when writing to HTML, and filtering before displaying with regular expressions. I have no experience with C#, so you can close this pull request without an answer.

back to previous pull request


Fix copyright date

Signed-off-by: Taras Drozdovskyi<EMAIL_ADDRESS>Description
The correction concerns the copyright date. Since according to the rules, after changing the file, the year of change is added and not corrected. for example the file was created in 2016, in 2019 and in 2020 was edited then the entry should be 2016, 2019-2020.
This must be strictly followed as this can lead to ownership disputes.
P.S. If you know more files where this was fixed from 2019 to 2020, please make the edits.
Type of change

[x] Code cleanup/refactoring

Checklist:

[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@tdrozdovsky Thank you. Will back to you soon after our Coconut release.


[stable/kube2iam] daemonset not updating after upgrade

Describe the bug
After upgrading kube2iam using Helm 3 the daemonset was not updating:
$ helm history kube2iam -n kube-system
REVISION	UPDATED                 	STATUS    	CHART         	APP VERSION	DESCRIPTION
1       	Mon Mar 30 09:54:03 2020	superseded	kube2iam-2.1.0	0.10.7     	Install complete
2       	Tue Mar 31 17:58:09 2020	superseded	kube2iam-2.1.0	0.10.7     	Upgrade complete
3       	Fri May 29 16:06:48 2020	superseded	kube2iam-2.1.0	0.10.7     	Upgrade complete
4       	Tue Jun 23 17:18:22 2020	superseded	kube2iam-2.1.0	0.10.7     	Upgrade complete
5       	Thu Aug 13 15:23:53 2020	deployed  	kube2iam-2.5.1	0.10.9     	Upgrade complete

Wait a couple of minutes (20 minutes should be enough to be sure...) and ...
$ k get daemonset kube2iam -n kube-system
NAMESPACE     NAME                                      DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR       AGE
kube-system   daemonset.apps/kube2iam                   7         7         7       0            7           specialty=default   136d

No pod was updated.
Version of Helm and Kubernetes:
$ helm version
version.BuildInfo{Version:"v3.2.1", GitCommit:"fe51cd1e31e6a202cba7dead9552a6d418ded79a", GitTreeState:"clean", GoVersion:"go1.13.10"}
$ k version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-21T14:51:23Z", GoVersion:"go1.14.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.8-eks-e16311", GitCommit:"e163110a04dcb2f39c3325af96d019b4925419eb", GitTreeState:"clean", BuildDate:"2020-03-27T22:37:12Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
kube2iam-2.5.1
What happened:
Pod were not updated after deployment of a new chart version although kube2iam image was bumped from 0.10.7 to 0.10.9.
What you expected to happen:
All pods being restarted / updated and new kube2iam version being deployed.
How to reproduce it (as minimally and precisely as possible):
Deploy kube2iam-2.1.0 to a cluster and then upgrade to kube2iam-2.5.1
Anything else we need to know:
I tried this on 2 different EKS clusters (v1.16.8-eks-e16311 and v1.16.13-eks-2ba888) with different worker instance nodes. Same result.
I also checked for missing resources, but that wasn't the reason (example of one node, not updating kube2iam):
Allocated resources:
  (Total limits may be over 100 percent, i.e., overcommitted.)
  Resource                    Requests      Limits
  --------                    --------      ------
  cpu                         2200m (56%)   4970m (126%)
  memory                      4676Mi (32%)  5480Mi (37%)

A work-around is to delete every old pod manually. They come back online with the new spec.

@spommerening The chart's default updateStrategy is onDelete, which differs from the kube default of RollingUpdate.
From kube docs:

With OnDelete update strategy, after you update a DaemonSet template, new DaemonSet pods will only be created when you manually delete old DaemonSet pods

You can see the setting here.  Changing it to updateStrategy: RollingUpdate should get you the behavior you're looking for.

@elordahl Thanks a lot!
Sometimes it helps when you know where you have to look. Thanks to you I learned something new. Very thankful!


Failed to local RAG and Webpage load after Upgrade to 0.3.4

Bug Report
Description
Bug Summary:
After I upgrade open-webui to 0.3.4, it fails to load local documents and also cannot load any webpage anymore.
Steps to Reproduce:
[Outline the steps to reproduce the bug. Be as detailed as possible.]
Expected Behavior:
[Describe what you expected to happen.]
Actual Behavior:
[Describe what actually happened.]
Environment

Open WebUI Version: 0.3.4

Ollama (if applicable): [e.g., 0.1.30, 0.1.32-rc1]

Operating System: Win11

Browser (if applicable): Brave latest

Reproduction Details
Confirmation:

[ ] I have read and followed all the instructions provided in the README.md.
[ ] I am on the latest version of both Open WebUI and Ollama.
[ ] I have included the browser console logs.
[ ] I have included the Docker container logs.

Logs and Screenshots

Browser Console Logs:
[Include relevant browser console logs, if applicable]
Docker Container Logs:
[Include relevant Docker container logs, if applicable]
Screenshots (if applicable):

Installation Method
pip install open-webui
Additional Information
[Include any additional details that may help in understanding and reproducing the issue. This could include specific configurations, error messages, or anything else relevant to the bug.]
Note
If the bug report is incomplete or does not follow the provided instructions, it may not be addressed. Please ensure that you have followed the steps outlined in the README.md and troubleshooting.md documents, and provide all necessary information for us to reproduce and address the issue. Thank you!

Unable to reproduce the issue here, I'd suggest you try using other documents and see if you experience the same issue. Also try resetting vector DB as well.

Unable to reproduce the issue here, I'd suggest you try using other documents and see if you experience the same issue. Also try resetting vector DB as well.

I have tried all you told. It didn't work.


why struct Cache contains pointer to cache?

it looks like struct cache is unnecessary in the code. I notice the comment // If this is confusing, see the comment at the bottom of New(), but i didn't find any explaination

https://github.com/patrickmn/go-cache/blob/46f407853014144407b6c2ec7ccc76bf67958d93/cache.go#L1115

IMO, Since, the janitor is working in a go routine on cache , c object. It will never be available for garbage collection. Hence, Cache struct is designed to have cache as a field. If Cache struct is garbage collected, stopJanitor is called using the runtime.setFinalizer. runtime.setFinalizer is used to call a function, here stopJanitor, when the first operand , here C, is garbage collected.


Plan Import/Export UI Improvements

resolves #1401
To test import:

Create a plan
Export the plan via the plans table icons column in the right most column
Verify that the plan file is downloaded
Click the newly moved "Import" button on the plans page and upload the downloaded plan file from step 3
Verify that the input fields are pre-populated with the correct values from the plan file
Attempt to upload a non .json file
Verify that an error is displayed stating that an incorrect file is selected
Attempt to upload a JSON file with invalid JSON
Verify that an error is displayed

To test export:

Create a plan
Navigate to the plan by first selecting the plan from the table and clicking the "Open plan" button that appears on the left of the page in place of the "Create" button
Once navigated to the plan page, click on the name of the plan in the nav bar
Verify that a new "Export as .json" button is presented
Verify that clicking on the new button results in a plan JSON download

@AaronPlave I've pushed a couple more changes to address your ProgressRadial background and visibility comments if you don't mind taking one last look at it

One last issue - if you are importing a large plan it can take several seconds or longer. We should probably disable the Create from .json button during import, and change it to something like "Creating...".


fix: change project layout to correct package work

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (70af798) 69.59% compared to head (f833790) 73.43%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   69.59%   73.43%   +3.84%
==========================================
  Files           6        9       +3
  Lines         661      670       +9
==========================================
+ Hits          460      492      +32
+ Misses        201      178      -23

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


compile cosmic-applets individually?

Would it be possible to have each applet build as it own job to lower the ram requirements when compiling locally? This would make it convenient to add flags for the ones that you want as well.

Yeah this could probably technically be done! Just curious, are you building the applets yourself because you aren't using the binary cache? (e.g. all binaries here should be cached for x86_64-linux and aarch64-linux on cosmic.cachix.org and once this is merged back into nixpkgs, cache.nixos.org)

The cache works great. I just tried to build without it and I ran out of ram with 32GB of it. I tried limiting the jobs to 1 and still ran out. It is not a priority but it would be nice for someone who wants to build locally.

The cache works great. I just tried to build without it and I ran out of ram with 32GB of it. I tried limiting the jobs to 1 and still ran out. It is not a priority but it would be nice for someone who wants to build locally.

Limiting jobs likely won't help, but using --cores 1 or some similar number to reduce build parallelism probably will help
But either way, making the derivation take a list argument or something to define which applets to build is probably doable

But either way, making the derivation take a list argument or something to define which applets to build is probably doable
Would it be possible to build each as an individual job?

Possibly? Idk, it would be a lot more wasted compiling (especially compared to --cores 1). But I'm not too opposed

had same issue testing #64 . I'm for whatever helps the cache work best since 99% of the time that's what I'll be using too, but it was an unpleasant surprise to OOM while testing a one line nix-side change :smile:

had same issue testing #64 . I'm for whatever helps the cache work best since 99% of the time that's what I'll be using too, but it was an unpleasant surprise to OOM while testing a one line nix-side change 😄

I'm still not too opposed to doing thiz. It's just a tradeoff between wasting shared compilation unit by splitting it up versus just setting a parallelism amount (--cores [n]) that won't OOM for however much RAM you do have on your system (which is just a general Nix thing not necessarily specific to Rust or COSMIC, e.g. highly templated C++ apps do it too which is why they actually have a separate set of systems in Hydra with tons of RAM to build some derivations with "big-parallel" set)
Alternatively we could just disable parallel compilation just for cosmic-applets too in the derivation, which would solve the OOM problem and just be a little slower for people who do have enough RAM (but tbh not much slower, so it's definitely viable)

But either way, making the derivation take a list argument or something to define which applets to build is probably doable

Could we use separate outputs like <drv>.share or .doc (but replaced with applet names) to separate what gets built?

Could we use separate outputs like <drv>.share or .doc (but replaced with applet names) to separate what gets built?

If you have some motivation that is worth the somewhat increased maintenance cost maybe. What would that help you do?

It was just an implementation idea, I don't really need to select applets.

It was just an implementation idea, I don't really need to select applets.

To reduce confusion, I'll just close this for now unless someone brings forward a need for this :)
(Also separate outputs does not change compilation and would not help the original request)


Azure AD Graph has been depreciated.

Can you please revise this to reference Microsoft Graph instead? Caused me a bit of confusion :-(
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 49643811-ee04-ae88-8153-aad4cc009b73
Version Independent ID: d1e1f15d-d988-7951-e453-f10ed6bb20bf
Content: Use a Windows VM system-assigned managed identity to access Azure AD Graph API
Content Source: articles/active-directory/managed-identities-azure-resources/tutorial-windows-vm-access-azure-ad-graph.md
Service: active-directory
Sub-service: msi
GitHub Login: @MarkusVi
Microsoft Alias: markvi

I have created a backlog item to track this.
#please-close


Typo "Mysql"→"MySQL"

https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/mysql-deployment-on-machine-group-v1?view=azure-pipelines
https://github.com/MicrosoftDocs/azure-devops-yaml-schema/blob/main/task-reference/mysql-deployment-on-machine-group-v1.md
#PingMSFTDocs
Thank you for your contribution. Please see the README.MD in this repo for details on how to contribute.

[ ] Are you creating a new task article? If yes, STOP. New task articles are auto-generated when the new task is deployed to an Azure DevOps sprint, including all task inputs, aliases, defaults, and allowed values. Once the task deploys and the article is generated, you can make a PR to add examples, remarks, and descriptions. If you have a readme.md file in the tasks repo for your new task, that content will be picked up as well. If you have a section in the readme.md file that explains what makes this new version of the task different than the previous version, that is greatly appreciated.
[ ] Are you editing a task or YAML schema definition article? We welcome your contributions to content that is contained within "editable-content" tags. Any contributions outside of an "editable-content" tag won't be merged as these articles are auto-generated (and auto-updated when new properties or inputs are deployed), with the exception of the content inside "editable-content" tags.

@hyoshioka0128 Thank you for this PR. That part of the task input documentation of the task article are auto-generated from the label field in the task source code, so if I merge this PR, they will just get overwritten the next time the task documentation tooling is run. This label is what is displayed in the task assistant when that task is used.

https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/MysqlDeploymentOnMachineGroupV1/task.json#L79
        {
            "name": "SqlUsername",
            "type": "string",
            "label": "Mysql User Name",
            "required": true,
            "defaultValue": "",
            "helpMarkDown": "When you connect using MySQL Workbench, this is the same value that is used for 'Username' in 'Parameters'."
        },

I will make a PR into that repo, and when it is merged and the updated task deployed, the documentation will automatically update,
https://github.com/microsoft/azure-pipelines-tasks/pull/18231


Document the x-consumer-timeout consumer argument

Is your feature request related to a problem? Please describe.
See this discussion:
https://github.com/rabbitmq/rabbitmq-dotnet-client/discussions/1433#discussioncomment-7731223
Describe the solution you'd like
Document the setting on this page:
https://www.rabbitmq.com/consumers.html#acknowledgement-timeout
Describe alternatives you've considered
N/A
Additional context
No response

Per-consumer timeouts were removed in https://github.com/rabbitmq/rabbitmq-server/pull/8260, so there is nothing to document.


add documentation for using Matchers w/ Typescript

as mentioned in #36 - documents usage for typescript user.
could expand to its own thing in future if theres more typescript use cases required, but for now i just stuck it in the extend-expect section to limit the scope.

Would you like to add yourself to the contributors table?


Foxx Microservice module.context.collection returns null for existing collection

My Environment

ArangoDB Version:        3.3.10
Storage Engine:
Deployment Mode:       Single Server
Configuration:               None
Infrastructure:               own
Operating System:        Ubuntu 16.02
Used Package:              Ubuntu.deb

Component, Query & Data
Affected feature: Foxx

Dataset:
If you create a collection using db._createDocumentCollection and try to fetch it using module.context.collection right after, instead of returning the ArangoCollection, it returns null.
This does not happen if you use db._collection, where it successfully returns the expected ArangoCollection.
Example code:
const testCollectionName = module.context.collectionName('test');
const testCollection = db._createDocumentCollection(testCollectionName);
const testCollectionFromModule = module.context.collection(testCollectionName); // null
const testCollectionFromDatabase = db._collection(testCollectionName); // ArangoCollection

Steps to reproduce

Create a Foxx microservice that creates a collection
Fetch the collection right after using module.context.collection
Be sad about null instead of ArangoCollection

Problem: It should return the ArangoCollection since all of it is synchronous.
Expected result: ArangoCollection

collectionName() prefixes the given name with the collectionPrefix for this service, which is derived from the service's mount point, e.g. /my-foxx becomes my_foxx.
module.context.collectionName('test') returns the string my_foxx_test. A collection with that name is created and reference stored in testCollection.
module.context.collection(testCollectionName) passes the given name to collectionName(), then looks up the collection with the prefixed name. That means, it will try to return a reference for a collection my_foxx_my_foxx_test which does not exist. You have to use db._collection() if you want to find a collection by name which is already prefixed with the collection prefix.
Relevant documentation:

https://docs.arangodb.com/3.3/Manual/Foxx/Context.html#collection
https://docs.arangodb.com/3.3/Manual/Foxx/GettingStarted.html#accessing-collections

Hi @KevinExtremo
has the previous comment of Simran been helpful to you?

Yes. Thank you very much. It makes sense :) It was not clear to me that one had a sideeffect over the other and produced the prefixed name itself.

Thanks for your reply. I am closing this issue as solved.


Failed to mount component: template or render function not defined

Hello,
I've try to use vue3-mermaid component, I have tried to install vue3-mermaid in combination with vue.js 2.6.12.
Following the readme I have used: npm install --save vue3-mermaid
Then I added the following lines to my main.js file:
import Vue3Mermaid from "vue3-mermaid";
Vue.use(Vue3Mermaid);
When I am starting vue with: npm run serve
it results in the following Warning message on the terminal console :
warning  in ./node_modules/vue3-mermaid/src/vue3-mermaid.js
"export 'h' was not found in 'vue
and i getting an error on navigator:
[Vue warn]: Failed to mount component: template or render function not defined.
Help please.

Same issue

@ayoubgm @saturnonfire Please note this package is using for Vue3 only.

I am using Vue3 I have same issue


fix build on macos

fixes https://github.com/kahing/catfs/issues/10

most missing syscalls (like fdopendir) are fixed by updating libc crate, that's why Cargo.lock is updated to latest
some other syscalls are emulated (like splice)
type errors (u16 vs u32) are fixed by adding castings.

@yjh0502 can you rebase this?  It will require some work to use the correct libc calls, e.g., the non-64-bit variants.

Superseded by #45.

Fix via #45.  Please test with the latest master.


CI for azps-9.2.0

[x] Descriptive Title: This PR's title is a synopsis of the changes it proposes.
[x] Summary: This PR's summary describes the scope and intent of the change.
[x] Contributor's Guide: I have read the [contributors guide][contrib].
[x] Style: This PR adheres to the [style guide][style].

Learn Build status updates of commit 525aa83:
:warning: Validation status: warnings

File
Status
Preview URL
Details

azps-9.2.0/Az.CosmosDB/New-AzCosmosDBMongoDBPrivilege.md
:warning:Warning
View (azps-9.2.0)
Details

azps-9.2.0/Az.CosmosDB/New-AzCosmosDBMongoDBPrivilegeResource.md
:warning:Warning
View (azps-9.2.0)
Details

azps-9.2.0/Az.CosmosDB/New-AzCosmosDBMongoDBRole.md
:warning:Warning
View (azps-9.2.0)
Details

Az/Az.Accounts/Add-AzEnvironment.md
:white_check_mark:Succeeded

Az/Az.Accounts/Az.Accounts.md
:white_check_mark:Succeeded

Az/Az.Accounts/Clear-AzConfig.md
:white_check_mark:Succeeded

Az/Az.Accounts/Clear-AzContext.md
:white_check_mark:Succeeded

Az/Az.Accounts/Clear-AzDefault.md
:white_check_mark:Succeeded

Az/Az.Accounts/Connect-AzAccount.md
:white_check_mark:Succeeded

Az/Az.Accounts/Disable-AzContextAutosave.md
:white_check_mark:Succeeded

Az/Az.Accounts/Disable-AzDataCollection.md
:white_check_mark:Succeeded

Az/Az.Accounts/Disable-AzureRmAlias.md
:white_check_mark:Succeeded

Az/Az.Accounts/Disconnect-AzAccount.md
:white_check_mark:Succeeded

Az/Az.Accounts/Enable-AzContextAutosave.md
:white_check_mark:Succeeded

Az/Az.Accounts/Enable-AzDataCollection.md
:white_check_mark:Succeeded

Az/Az.Accounts/Enable-AzureRmAlias.md
:white_check_mark:Succeeded

Az/Az.Accounts/Export-AzConfig.md
:white_check_mark:Succeeded

Az/Az.Accounts/Get-AzAccessToken.md
:white_check_mark:Succeeded

Az/Az.Accounts/Get-AzConfig.md
:white_check_mark:Succeeded

Az/Az.Accounts/Get-AzContext.md
:white_check_mark:Succeeded

Az/Az.Accounts/Get-AzContextAutosaveSetting.md
:white_check_mark:Succeeded

Az/Az.Accounts/Get-AzDefault.md
:white_check_mark:Succeeded

Az/Az.Accounts/Get-AzEnvironment.md
:white_check_mark:Succeeded

Az/Az.Accounts/Get-AzSubscription.md
:white_check_mark:Succeeded

Az/Az.Accounts/Get-AzTenant.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.

azps-9.2.0/Az.CosmosDB/New-AzCosmosDBMongoDBPrivilege.md

Line 0, Column 0: [Warning: file-not-found - See documentation] Invalid file link: './Update-AzCosmosDBMongoDBPrivilegeResource.md'.

azps-9.2.0/Az.CosmosDB/New-AzCosmosDBMongoDBPrivilegeResource.md

Line 0, Column 0: [Warning: file-not-found - See documentation] Invalid file link: './Update-AzCosmosDBMongoDBPrivilege.md'.

azps-9.2.0/Az.CosmosDB/New-AzCosmosDBMongoDBRole.md

Line 0, Column 0: [Warning: file-not-found - See documentation] Invalid file link: './Update-AzCosmosDBMongoDBPrivilege.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@mikefrobbins
Could you please review this? I think once you proved the failure will be gone as previous

@mikefrobbins  Thanks!


ENS.sol gives warnings about interface using public modifier

Change to ENS.sol use external functions only.

This will be fixed with


replaced usages of deprecated getPath() and getPath(boolean disabled)…

replaced usages of deprecated getPath() and getPath(boolean disabled) methods


Fork angularjs-nvd3-directives for X15 compatibility

Fork the angularjs-nvd3-directives repo into X15 Software's organization for bug fixes and improvements. Create an initial commit for the fixes and changes we've added so far.

Completed in #2.


insert_id_before doesn't detach the inserted node

Calling insert_id_before or insert_id_after with a node that is already a child doesn't remove it from the parent's list of children.
I came across this while trying to replace a node with its children.
If this is unexpected behavior, I'd be happy to make a PR.
Reproducible example:
//! ```cargo
//! [dependencies]
//! ego-tree = "=0.6.2"
//! scraper = "=0.16.0"
//! ```
use scraper::{ElementRef, Html, Selector};

fn main() {
    let html = r#"

 Some text that includes
        several
        relative links
    and
        an absolute link
    .

    "#;

    let anchors = Selector::parse("a").unwrap();

    let mut document = Html::parse_fragment(html);

    let links: Vec<_> = document
        .select(&anchors)
        .map(|el| el.id())
        .collect();

    for id in links {
        let Some(mut node) = document.tree.get_mut(id) else { continue };

        while let Some(mut child) = node.first_child() {
            let child_id = child.id();
            eprintln!("Reparenting node {:?}", child_id);
            child.detach(); // <---- comment this for infinite loop
            node.insert_id_before(child_id);
            // node.insert_id_after(child_id);
        }

        node.detach();
    }
}

you’re right, this is a bug. insert_id_before and insert_id_after should call detach() like prepend_id and append_id do.


how do nodeController used in nginx-ingress?

I do not find any related code use
nodeController cache.Controller

they have ListerWatcher but without ResourceEventHandlerFuncs registered.
Then my issue is how do node informer being used?

I checked history introduced by Added a Node StoreLister type . But at that time used eventHandler.  But now eventHandler not exist. And node informer has no resource event handler.

@hzxuzhonghu the node controller is used in the update of the status of ingress rules. This operation does not uses the event handlers, just the lister.
https://github.com/kubernetes/ingress/blob/master/core/pkg/ingress/status/status.go#L279

@aledbf In func GetNodeIP, I find it get node directly from apiserver by send a GET request, not from lister.
// GetNodeIP returns the IP address of a node in the cluster
func GetNodeIP(kubeClient clientset.Interface, name string) string {
	var externalIP string
	node, err := kubeClient.Core().Nodes().Get(name, meta_v1.GetOptions{})
	if err != nil {
		return externalIP
	}

	for _, address := range node.Status.Addresses {
		if address.Type == api.NodeExternalIP {
			if address.Address != "" {
				externalIP = address.Address
				break
			}
		}

		if externalIP == "" && address.Type == api.NodeInternalIP {
			externalIP = address.Address
		}
	}
	return externalIP
}


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
<EMAIL_ADDRESS>Major Changes

#4261 cab40a729fae5009c40b028befc0108e7fd98f2b Thanks @angelinastavniiciuc!
remove totalCount and totalCountLoading props from Query Builder. Add runQueryButtonContent prop to Query Builder.
In order to allow consumers to add the desired functionality for the Run Query button, we added runQueryButtonContent prop.
totalCount and totalCountLoading are properties that should not be defined at the library level.
Instead they will be implemented in the consumer.

remove deprecation of hideControls propery.

[ ] ⚠ If major release, don't forget to check if peerDependencies needs to be also updated

@toptal-anvil ping reviewers


Example of a One Drive Sync Conditional Access Policy

I am not able to locate any specifics around actually creating a policy to specifically control the syncing of the OneDrive sync client to AzureAD managed devices. Can someone demonstrate how the policy might be created and applied?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: efd1a047-ff5f-48bd-1a9a-87024d3cbe70
Version Independent ID: 23ae844e-35df-0d4f-50d5-021a5ba9bdf9
Content: Enable conditional access support in the OneDrive sync app - OneDrive
Content Source: OneDrive/enable-conditional-access.md
Service: one-drive
GitHub Login: @adeejoseph
Microsoft Alias: adjoseph

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


TEP-0091: Trusted Resources TODO work before Beta

This issue is tracking relevant features before we could promo trusted resources to Beta.
If you have any other requirements, feel free to leave comments on this issue.
/kind feature
Background: In this PR https://github.com/tektoncd/community/pull/949, we proposed several features for trusted resources. Those could help the project to meet more users need.
Checklist:

[x]  Feature flag change from resources-verificaiton-mode to trusted-resources-verification-no-match-policy.
https://github.com/tektoncd/pipeline/pull/6324
[ ]  Add condition to reflect verification failure/success.
[x]  Add a new field "mode" with "warn" and "enforce" as available values.

Add mode field in api: https://github.com/tektoncd/pipeline/pull/6328
Use mode in reconciler, if mode if empty, it should be treated as enforce: https://github.com/tektoncd/pipeline/pull/6406

[ ]  Support v1 Tasks&Pipelines

support in remote resolution: https://github.com/tektoncd/pipeline/pull/6254
support in trusted resources in task and pipeline

[ ] Support local tasks and pipelines

/area s3c

There's no open pr getting trusted resources to beta, so moving this item to the next milestone
@Yongxuanzhang please let me know if I missed something

There's no open pr getting trusted resources to beta, so moving this item to the next milestone
@Yongxuanzhang please let me know if I missed something

Thanks!

Pipelines WG - @Yongxuanzhang breaking this into smaller PRs. @Yongxuanzhang to move to the next milestone if we don't make it.

The left items all have their dedicated issues:

[TEP-0091] Support local resources verification  #6666
Clean up code: https://github.com/tektoncd/pipeline/issues/5820

Close this one since all feature PRs are merged


Adding the xsv behead command that drop a CSV file's header

Hello again,
This PR adds a new command named behead and whose goal is to drop a CSV file's header. This is basically a glorified tail -n +2 but has the advantage of being CSV-aware. I personally need this because I often work with CSV files given to me by mindless researchers that love having carriage returns in their column names.
Here is some cases when this command is useful:

Sometimes, you need to drop a CSV header from a CSV file to conform to some other program or script that expects a headless CSV file.
It can be quite useful in conjunction with xsv select so you can pipe to xargs or other unix tools that won't be expecting a header:

xsv select filepath files.csv | xsv behead | xargs -n 1 rm

Sorry for the gloomy command name. Must be my French atavism. I can of course change it if you have a better one in mind.

given to me by mindless researchers that love having carriage returns in their column names

Wow!

Why was this not merged?


Unable to move items in edit mode.

Maybe I did not understood something.  With v2.0.2, I press F7 to enter edit mode and I understood I can then use the mouse to select and move the item with the left mouse button, but the mouse move and mouse button make my characters react, not the editor.
Good work by the way (except this bug, or the instructions if it is not a bug ;-))

You need to have your mouse usable when editing the UI.
The main issue is that if you don't have your mouse "free" you are unable to edit they UI, as the mouse moves the camera.
To control your mouse:
press ESC to open the menu then F7 to edit the UI
or
Open your inventory and then F7 to edit the UI.


derive Hash on Community

Can you elaborate what's the use case here?

i'm processing some bmp data and need to make a HashMap with the community as a key


How to configure lock_timeout in gorm?

Your issue may already be reported! Please search on the issue track before creating one.
What version of Go are you using (go version)?
go version go1.13.6 linux/amd64
Which database and its version are you using?
postgresql-12
Please provide a complete runnable program to reproduce your issue. IMPORTANT
Need to runnable with GORM's docker compose config or please provides your config.
package main

import (
	"fmt"
	"github.com/jinzhu/gorm"
	_ "github.com/jinzhu/gorm/dialects/postgres"
	"time"
)

func main() {
	db, err := gorm.Open("postgres", "host=database user=postgres dbname=testdb sslmode=disable password=123456")
	if err != nil {
		panic("failed to connect database")
	}
	defer db.Close()

	db.Create(&Product{Code: "L1", Price: 1000})

	db.InstantSet("db:lock_timeout", 1000)
	db.InstantSet("gorm:query_option", "FOR UPDATE")

	tx := db.Begin()
	var p Product
	err = tx.First(&p, 1).Error
	if err != nil {
		tx.Rollback()
		return
	}

	v, e := db.Get("lock_timeout")
	fmt.Println(v, e)
	go func() {
		// read
		fmt.Println("read start")
		var product Product
		db.First(&product, 1) //
		fmt.Println(product)
		fmt.Println("read end.")
	}()

	time.Sleep(time.Second * 5)
	fmt.Println("commit.")
	tx.Commit()
	time.Sleep(time.Second * 1)
}

type Product struct {
	gorm.Model
	Code  string
	Price uint
}

i tried to configure this way but it didn't work.

👎

Have a look here:
https://github.com/jinzhu/gorm/issues/1009


Improve User Experience: Change 'Registering' to 'Creating Account' and Enhance Button Visibility

Describe the feature
Hey @anuragverma108 . Enhance the user experience on our login page by making two key changes:

Change the text from "Registering" to "Creating Account" to make it clearer and more inviting for new users.
Adjust the button colors for better visibility, ensuring that the button text is easily readable.

These changes are intended to improve clarity and usability for our users, ultimately leading to a more seamless registration and login process.
Please add the gssoc labels and I would like to work on it under GSSOC'24. Thank you!!
Add ScreenShots
Before making the changes:

After making the changes:

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assigned!
Make sure to attach before & after screenshots in your PR. Also, star the repo before working on it. While creating your PR, ensure you pull all existing changes beforehand to avoid conflicts.
Happy open-source contributing!


[Feature]: Add the github action workflow for greeting contributors

Description:
The current project lacks an automated action to greet contributors. GitHub Actions can significantly enhance project automation. I propose adding a GitHub Action workflow to greet new pull request (PR) and issue creators, fostering a welcoming environment.
Proposed Changes:
Implement a GitHub Action workflow that triggers on new PRs and issues. The workflow should include a greeting message to acknowledge and appreciate the contributors for their efforts.

Please assign me this @LegendSumeet under iwoc24

go for it

Hey @LegendSumeet please add the difficulty level before assigning.  Coz when a PR comes even we as contributir tend to forget about that tag.


OpenZwave newer Versions in Docker Image [question] [featurerequest]

Is there

A way of identifying with the docker module the openzwave version, for instance on the dev docker image? Zwave2mqtt does not report the minor version such eg 1.6.0 instead of 1.6.1843
Could the Docker image not have a flag for the version of openzw to utilise? An example like the plex linuxserver.io, that on run pulls and complies the fixed or latest version dependant on the docker command.

Hi @jamesarbrown, have you tried to swith to https://github.com/zwave-js/zwavejs2mqtt ?
I don't plan to maintain this anymore

I will migrate this afternoon


Fix issue template links to the contributing guidelines

the previous links were 404's, this fixes them to be correct

Thanks!


PHP 8.1 support

Hi,
Any plans to support PHP 8.1 ?
The locked version of vlucas/phpdotenv has some deprecated functions.

any updates on this?

Thank!
The latest master branch has been updated and will be released later.


Update dependencies script to not exclude six

Remove six from list of excluded dependencies in get-secureli-dependencies.py. This needs to be handled after the R4 demo and ensure that brew install still works. Line in question is here.

The brew script was manually updated in the homebrew repo here, but that will get clobbered by the next release.


Hide checked item icons when checked checks are hidden

This seems to be the current behavior, unless I'm misunderstanding what I meant.


fix(rpc): Improve missing pynvim exception handling

I noticed while running on mac testing something else that it wasn't handling all missing pynvim cases, which broke other things. There could be others, but I didn't hunt yet.

You might want to re-open and check the diff as it contains <<<<<

It wasn't letting me reopen so I sent another one


fix: #7614 - rebuild every time on macos because of Info.plist changes

According to macos documentation
This key is a machine-readable string composed of one to three period-separated integers, such as 10.14.1. The string can only contain numeric characters (0-9) and periods.

Each integer provides information about the build version in the format [Major].[Minor].[Patch]:

Major: A major revision number.

Minor: A minor revision number.

Patch: A maintenance release number.

You can include more integers but the system ignores them.

Current logic of the build prepare Info.plist with added timestamp at the end, this cause rebuild each restart even if not needed. Because You can include more integers but the system ignores them it does not make any sense to add timestamp
I also have to check Info.plist content from previous build with new build. If no changes just skip the write
This should solve https://github.com/tauri-apps/tauri/issues/7614

Hey @olexiyb, while reviewing your PR, I'd suggest the following code changes:
👉 Code Suggestion for #9878

https://github.com/tauri-apps/tauri/pull/9878

You can also review and apply these suggestions locally on your machine.
Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.


Restructure plotting methods

Is your feature request related to a problem?
The interface of plotting methods is inconsistent. Some take a table + column names, others take a column.
Desired solution
Normalize the interface. Also think about whether it makes sense to have the plotting stuff as methods of the Table or Column class (or both).
Possible alternatives (optional)
No response
Screenshots (optional)
No response
Additional Context (optional)
No response

:tada: This issue has been resolved in version 0.5.0 :tada:
The release is available on:

v0.5.0
GitHub release

Your semantic-release bot :package::rocket:


stable/kafka-manager

I was not able to deploy stable/kafka-manager to Kuberenetes v1.16 and v1.17 due to the deprecated API Versions, which was caused by the Zookeeper dependency not being updated.
This PR updates Zookeeper dependency for stable/kafka-manager to resolve the above deployment issue.
Checklist

[x] DCO signed
[x] Chart Version bumped
~Variables are documented in the README.md~ note applicable
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test

/lgtm


Consolidate E2E environment variables with integration varaibles

What this PR does / why we need it:
Source E2E test environment setup variables from the same utility package used for integration. Align E2E variables with their integration counterparts.
E2E now uses separate TEST_(KONG|CONTROLLER)_(IMAGE|TAG) variables where it previously used a single TEST_KONG(_CONTROLLER)_IMAGE_OVERRIDE variable with both the repo and tag.
CI inputs still use a single value that the CI scripts split.
Which issue this PR fixes:
Fix #4593
Special notes for your reviewer:
GKE-related variables are defined by the related KTF module, and have not been changed.
License data was also using a KTF-defined variable from the Kong addon, although it isn't actually using the Kong addon. Integration does use the same var AFAIK, however, since it does use the Kong addon. I left this unchanged.
https://github.com/rainest/kubernetes-ingress-controller/actions/runs/6305128682/job/17117913357 and https://github.com/rainest/kubernetes-ingress-controller/actions/runs/6305130237/job/17119050768 have debug-enabled CI runs on a fork. GKE and Enterprise license failures are expected for the fork.
This is mostly to confirm the split script is populating the expected variables, since those variable names actually changed in E2E:
2023-09-25T22:23:58.5265037Z   TEST_CONTROLLER_IMAGE: kong/kubernetes-ingress-controller
2023-09-25T22:23:58.5265441Z   TEST_CONTROLLER_TAG: sha-d140eb7
2023-09-25T22:23:58.5265766Z   TEST_KONG_LOAD_IMAGES: true
2023-09-25T22:23:58.5266116Z   TEST_KONG_IMAGE: kong/kong-gateway-dev
2023-09-25T22:23:58.5266440Z   TEST_KONG_TAG: nightly

Other variables just got redefined at a new location.
PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[ ] ~the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR~

More conflicts. https://github.com/Kong/kubernetes-ingress-controller/pull/4766 removed some generic E2E utilities that weren't specific to <3.4 gates. While we chose a required version newer than any of the extant gates now, we probably will have similar gates in the future, so keeping the generic functions around with nolint:unused.

istio tests failed in e2e suite: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6566314300/job/17836886646

https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6592767672/job/17914168070 Istio run now happy. Do we have a way to run GKE tests off a branch? It hopefully just needs the same thing with a static controller image (I'd neglected to add the new input splitter to both it and Istio), but https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6592767672 just skips it.
It shouldn't have additional complications given that it's just the main E2E job with GKE flipped on, but if we can run it, may as well.


feat: add support for Pebble custom notices

Adds support for Pebble custom notices:

A new PebbleNotice class, which is essentially the same as an ops.pebble.Notice but has default values to make it easier to work with in a testing context.
Containers have a new notices attribute, which is a list of notices that have been seen prior to the event.
Containers have a new custom_notice_event property, which is sugar for creating a -pebble-custom-notice event.

It seems like having the custom_notice_event property on the notice (and corresponding changes, like Event would have a notice attribute) would be nicer, but (pebble) Notices don't know which container they are in, but PebbleCustomNoticeEvent does have the container as an attribute. We can't have the PebbleNotice know which container it is in and also have the container be passed the list of notices because that's circular. A PebbleNotice could take the Container as an argument, and could 'register' itself on the container, but that doesn't seem like the Scenario way.
This also forces the sugar to be for the most recent notice (more precisely: the last one in the list) in the container, but that does seem reasonable - it seems like this would be the behaviour in Juju as well.
Another option would to not have the sugar (and Event could take a notice), but it does seem like it's both nicer and more Scenario if it is there. Happy to get feedback on this!
The required version of ops is bumped to 2.10 to get the Pebble custom notices support there (particularly in the mock Pebble client).
There are a few small adjustments to support a second type of pebble/workload event.
I had hoped to have PebbleNotice inherit from ops.pebble.Notice (and _DCBase) They are both frozen dataclasses, but in Scenario it's better if there are suitable default values for everything except the key, but the key isn't the first argument for a pebble Notice, so this generates errors if done simply. Nothing else in Scenario is currently doing this, so it seems ok, but let me know if you want me to explore that more.

@benhoyt it would be great to get your feedback on this as well, since you're the Pebble King (tm) and also did the custom notices in Juju/ops/Harness.

By the way, I have every expectation that this might take a few rounds of review since it's my first non-trivial contribution to Scenario :smile:.

Thanks @tonyandrewmeyer. Something came up so I have a busy day tomorrow, but I hope to be able to review this Thursday or Friday.

Shall we get this moving forward again?

Shall we get this moving forward again?

Yes! Ben was keen on pausing until we had progressed the 7.0 discussions, but I think we are far enough along with those now.
If this aligns with the 7.0 style, then it would be:
notice1 = Notice(...)
notice2 = Notice(...)
container = Container("my-container", can_connect=True, notices={notice1, notice2})
state_in = State(containers={container})

state_out = ctx.run(ctx.on.my_container_pebble_custom_notice(notice=notice2), state_in)

# Presumably you would not ever want to get existing notices, since the charm can't change them, but
# could in theory call `notify()`, although it seems like the workload ought to be doing that, not the charm.
new_notice = state_out.get_container(container).get_notice(key=...)

But for the current main, then it would be:
notice1 = Notice(...)
notice2 = Notice(...)
container = Container("my-container", can_connect=True, notices=[notice1, notice2])
state_in = State(containers=[container])

state_out = ctx.run(container.get_notice(notice2.key), state_in)

new_notice = state_out.containers["my-container].get_notice(...)

I think it would be worth having this PR implement the latter (there are a couple of fixes I need to make, most of which I have locally but haven't pushed), and then a separate PR for the 7.0 branch (probably the same one that changes everything else).

@PietroPasotti could you please give this a fresh review?


[libpng] remove broken patch

Hi @cenit, I see that qt5-3d failed on x86-windows from the current CI system.
The error likes this:
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:56 (message):
Command failed: C:/vsts/_work/2/s/downloads/tools/jom/jom-1.1.3/jom.exe
Working Directory: C:/vsts/_work/2/s/buildtrees/qt5-3d/x86-windows-rel
Error code: 2
See logs for more information:
C:\vsts_work\2\s\buildtrees\qt5-3d\package-build-x86-windows-rel-out.log
C:\vsts_work\2\s\buildtrees\qt5-3d\package-build-x86-windows-rel-err.log
failureLogs.zip

This one is really curious, I will investigate it soon (I didn’t open the zip as of now): this PR technically should not change anything, since it adds “unused” targets (make the port more future-proof) and removes a patch that was impossible to apply because it was broken with recent sources... I was expecting an “easy” green mark!

@cenit were you able to get a repro?
I was unable to get one locally.

@vicroms No sorry. Too much busy


Display Work Item List - Retaining the user's view position

Opening the work item detail view and returning to the work item list retains the current view position in the list.
The UI needs to scroll to the selected work item's ID

Closing this task, as the Detail View would be on the same page as the list view.


Initializate the app

Start the expo project
Do the conections with de pokemon-api (https://pokeapi.co/docs/v2)


Fix issues with Tags pages

We have a few known issues with the Workspace Tags Page that need to be addressed:

Padding issues - https://github.com/Expensify/App/pull/37755#issuecomment-1989486161
Pages are still accessible via deeplink - https://github.com/Expensify/App/pull/37755#issuecomment-1989498179
Toggle reverts to previous state - https://github.com/Expensify/App/issues/38188

cc @waterim @mkhutornyi
Issue OwnerCurrent Issue Owner: @luacmartins

We're still working on this

Retesting

Fixed:

https://github.com/Expensify/App/pull/37755#issuecomment-1989486161

Still reproducible:

https://github.com/Expensify/App/pull/37755#issuecomment-1989498179
https://github.com/Expensify/App/issues/38188

@waterim could you please take a look at the reproducible issues above?

@luacmartins https://github.com/Expensify/App/pull/37755#issuecomment-1989498179 - this one is will be fixed here

@luacmartins Regarding this https://github.com/Expensify/App/issues/38188 - looks like this is an issue with backend, because response is empty and requiresTag is not updating in policy
Request for SetWorkspaceRequiresCategory:

Request for SetPolicyRequiresTag:

Response for SetWorkspaceRequiresCategory:

Response for SetPolicyRequiresTag:

@waterim are we not optimistically setting requiresCategory to true when calling SetPolicyRequiresTag? I don't think we need the response to have data if we do that.

@luacmartins we set it, but after refresh policy will be the same as before switch toggle

Optimistically it works

but after refresh policy will be the same as before switch toggle

Why is that? When we refresh the page we should fetch the details for the policy and if the data was saved in the DB it should be the same as the optimistic data we have locally, no?

Ok, I'll investigate!

Thank you!

We have PRs up for all the issues listed here

PRs have been merged. Just waiting on the deploy

We're all good here. Closing.


CI - Use bot token for maven repo

Use the pyansys bot token to pull the client-template from our maven repository

There seems to be no guidance on using bots to pull packages from maven, closing in the mean time.


Remove unnecessary code.

已经包含aclnn接口匹配校验 外部无需做额外的cann版本校验。

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.wangyicheng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Check all for invite-only stream after filtering users, checks ALL users

So I discovered this making an invite only stream, I copy and pasted a list of emails from a private message thread (to make a stream out of it). That filtered the user list to those I wanted to be invited, but then when I clicked check all (because only those I filtered out where there) I inadvertently invited everyone to the invite only thread (which besides being deeply ironic, was slightly awkward).
I realize this is how the check all feature works, it checks all, so instead of changing that, maybe one could check if an invite only stream really needs to invite ALL users (similar to before you @mention all, there is a little warning). Or perhaps the check all feature should indeed only check those who are filtered out? I've got some time in my hand (but not much javascript under my belt), so I'll take marching orders 😸

There's actually an open issue with some ongoing work on prompting the user in https://github.com/zulip/zulip/pull/2592; but the "check all" thing should probably most coherently only check all the things that are visible; I'm guessing that might actually be a regression...

Closed with #2617


Add heavier locking to the FinalizePartition() function

When running ConsumerGroup.CommitUpTo(msg) in a goroutine, I get a race condition between FinalizePartition and CommitUpTo
Below is the race condition that I get when running with the race detector:
2015/11/18 13:03:59 Started the kafka consumer service, peers: [<IP_ADDRESS>:2181], topics: [telegraf_test_topic_1447877039]
==================
WARNING: DATA RACE
Read by goroutine 36:
  github.com/wvanbergen/kafka/consumergroup.(*zookeeperOffsetManager).FinalizePartition()
      /Users/csparr/ws/go/src/github.com/influxdb/telegraf/Godeps/_workspace/src/github.com/wvanbergen/kafka/consumergroup/offset_manager.go:130 +0x162
  github.com/wvanbergen/kafka/consumergroup.(*ConsumerGroup).partitionConsumer()
      /Users/csparr/ws/go/src/github.com/influxdb/telegraf/Godeps/_workspace/src/github.com/wvanbergen/kafka/consumergroup/consumer_group.go:416 +0x1688

Previous write by goroutine 41:
  github.com/wvanbergen/kafka/consumergroup.(*partitionOffsetTracker).markAsProcessed()
      /Users/csparr/ws/go/src/github.com/influxdb/telegraf/Godeps/_workspace/src/github.com/wvanbergen/kafka/consumergroup/offset_manager.go:226 +0xb1
  github.com/wvanbergen/kafka/consumergroup.(*zookeeperOffsetManager).MarkAsProcessed()
      /Users/csparr/ws/go/src/github.com/influxdb/telegraf/Godeps/_workspace/src/github.com/wvanbergen/kafka/consumergroup/offset_manager.go:152 +0x153
  github.com/wvanbergen/kafka/consumergroup.(*ConsumerGroup).CommitUpto()
      /Users/csparr/ws/go/src/github.com/influxdb/telegraf/Godeps/_workspace/src/github.com/wvanbergen/kafka/consumergroup/consumer_group.go:235 +0xde
  github.com/influxdb/telegraf/plugins/kafka_consumer.(*Kafka).parser()
      /Users/csparr/ws/go/src/github.com/influxdb/telegraf/plugins/kafka_consumer/kafka_consumer.go:132 +0x78c

Goroutine 36 (running) created at:
  github.com/wvanbergen/kafka/consumergroup.(*ConsumerGroup).topicConsumer()
      /Users/csparr/ws/go/src/github.com/influxdb/telegraf/Godeps/_workspace/src/github.com/wvanbergen/kafka/consumergroup/consumer_group.go:319 +0xec7

Goroutine 41 (finished) created at:
  github.com/influxdb/telegraf/plugins/kafka_consumer.(*Kafka).Start()
      /Users/csparr/ws/go/src/github.com/influxdb/telegraf/plugins/kafka_consumer/kafka_consumer.go:99 +0x33c
  github.com/influxdb/telegraf/plugins/kafka_consumer.TestReadsMetricsFromKafka()
      /Users/csparr/ws/go/src/github.com/influxdb/telegraf/plugins/kafka_consumer/kafka_consumer_integration_test.go:43 +0x9af
  testing.tRunner()
      /usr/local/Cellar/go/1.5.1/libexec/src/testing/testing.go:456 +0xdc
==================
2015/11/18 13:03:59 Could not parse kafka message: cpu_load_short,host=server01<PHONE_NUMBER>702900257, error: unable to parse 'cpu_load_short,host=server01<PHONE_NUMBER>702900257': invalid field format
2015/11/18 13:03:59 Kafka Consumer buffer is full, dropping a point. You may want to increase the point_buffer setting
PASS
Found 1 data race(s)

I don't have a very concise example I can show to reproduce this, but you can see from the output that Goroutine 36 is being spun up within the consumergroup and is not something I have control over. My code spins up Goroutine 41 and calls CommitUpTo which eventually calls pOT.markAsProcessed().
The markAsProcessed call has a conflict with a read that is performed by the FinalizePartition() call. Adding a heavier lock to this function really shouldn't have a strong impact on performance because this function only gets called once per partition.

:+1: on this, I'm reproducing the same issue

@wvanbergen What do you think of this PR? Any thoughts?

I have to spend some time on a good review. I remember making the locking more granular like this, to prevent potential deadlocks. This is a while ago though, so that may no longer be true or relevant.

closing this because it doesn't appear to be getting merged


optimize srv broker and executor logic

What problem does this PR solve?
Optimize task broker and executor for reduce memory usage and deployment complexity.
Type of change

[ ] Performance Improvement
[ ] Some code optimize

Change Log

Enhance redis utils for message queue(use stream)
Modify task broker logic via message queue (1.get parse event from message queue 2.use ThreadPoolExecutor async executor )
Modify the table column name of document and task  (process_duation -> process_duration maybe just a spelling mistake)
Reformat some code style(just what i see)
Add requirement_dev.txt for developer
Add redis container on docker compose

Supper fantastic! Appreciate for your contribution!
A concern: if the name 'process_duation' refined, how to update it to the existing users who have already deployed locally.

Supper fantastic! Appreciate for your contribution! A concern: if the name 'process_duation' is refined, how to update it to the existing users easily and smoothly, who have already deployed locally? Do you have any opionion?

I think the best solution is manually change column of existing table. and i will provider two sql statements to fix it.

Supper fantastic! Appreciate for your contribution! A concern: if the name 'process_duation' is refined, how to update it to the existing users easily and smoothly, who have already deployed locally? Do you have any opionion?

I think the best solution is manually change column of existing table. If the change merge to main, I will open an issue to record how to fix it. SQL: ALTER TABLE rag_flow.task CHANGE COLUMN process_duation process_duration FLOAT;; ALTER TABLE rag_flow.document CHANGE COLUMN process_duation process_duration FLOAT

What about letting it be. There're bunch of users or developers who do not even know how to execute SQL.
How about letting it be.


[SPARK-26161][SQL] Ignore empty files in load

What changes were proposed in this pull request?
In the PR, I propose filtering out all empty files inside of FileSourceScanExec and exclude them from file splits. It should reduce overhead of opening and reading files without any data, and as consequence datasources will not produce empty partitions for such files.
How was this patch tested?
Added a test which creates an empty and non-empty files. If empty files are ignored in load, Text datasource in the wholetext mode must create only one partition for non-empty file.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5317/
Test PASSed.

Test build #99227 has started for PR 23130 at commit b200a50.

@cloud-fan @HyukjinKwon Please, take a look at the PR.

Can one of the admins verify this patch?

Test build #99227 has finished for PR 23130 at commit b200a50.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99227/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5327/
Test PASSed.

Test build #99239 has started for PR 23130 at commit e7871f3.

Test build #99239 has finished for PR 23130 at commit e7871f3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99239/
Test PASSed.

The code change LGTM. There is a mistake in PR description: we updated FileSourceScanExec not DataSourceScanExec. Let's also mention that this fixed a behavior change introduced by https://github.com/apache/spark/pull/22938 mistakenly.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5413/
Test PASSed.

Test build #99335 has started for PR 23130 at commit 7057f8b.

Test build #99335 has finished for PR 23130 at commit 7057f8b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99335/
Test PASSed.

I think this change makes sense, at least it's good for performance. My only concern is, shall we ask all the parsers to return Nil for empty files? AFAIK JSON doesn't follow it.

Test build #99465 has started for PR 23130 at commit 1f58cc1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5534/
Test PASSed.

Test build #99465 has finished for PR 23130 at commit 1f58cc1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99465/
Test PASSed.


Simplify installation instructions

Merely a suggestion, but I figured this might scan better.
PS: I was made aware of Globalize by @alolita's presentation. 🙇

Thanks for your PR and for sharing @alolita's presentation. I just added a small ask so that I can merge it. Also, please sign the CLA (instructions above)

Thanks!


Sync between web app and obsidian seems not to work.

Dear Jonas,
thanks for this awesome idea and repo, much appreciated!
I have set up the plugin and the AudioPen settings according to the documentation in the readme, but have trouble with the sync of the web app and Obsidian. Here is a video, which shows what happens.
https://github.com/jonashaefele/audiopen-obsidian/assets/120744129/bb9d9cb5-b2b6-40d3-af34-f83bb96a79c3
Am I doing anything wrong?
Thanks again for your time and work,
Nico

Okay, I now know what has caused this. On Linux, it seems like the Destination folder is not allowed to be empty.
So, within the plugin settings, specify any folder of vault as Destination folder. If you want to save it in the root directory, use /.

Thanks for the nice words @nengelmann and sorry, somehow I didn't get pinged about this issue. I just found it.
Yes, as you noticed, if you don't add a folder, it'll default to + Inbox/AudioPen and you have to overwrite that with the folder you want. In your case that's /
I'll look at changing the default to / because that should work for every vault.