Fix p5js library, so that it uses the same version ArtBlocks uses.

This library uses an incorrect p5js version, because, due to the mistake made by p5js team, 1.0.0 p5js is different in different distributions.
(See https://github.com/processing/p5.js/issues/5728 issue for more).
I fixed it so that this library takes p5js from the same place as AB does.

By the way, if you want the library to be local, just write here and I will correct the PR taking p5.js file from the correct place.


Using unsloth mode gradient checkpointing without LoRA

Currently unsloth offers a customized version of gradient checkpointing that claims to be better. The only way I'm aware of using it is with the below code.
model = FastLanguageModel.get_peft_model(
    model,
    use_gradient_checkpointing = "unsloth", # <<<<<<<
)

But using FastLanguageModel.get_peft_model will patch the model with LoRA.  Is there any way to use the unsloth customized gradient checkpointing without LoRA? Or does it even make sense to use it without? Are the customized tricks specific to pefts?

We'll be adding all model support in a future release which will enable Unsloth GC for other models! Unsure on normal full finetuning or pretraining - I would suggest using Deepspeed to offload stuff, and not Unsloth

Great to know its on the todo list. I'm not looking for offloading techniques as the performance drop is quite significant, I'm rather trying to do gradient checkpointing during pretraining. The pytorch version should be good enough for the time being.


MRD-1042 Enhance e2e tests to include SPO journey

Merge this PR when the trigger/SPO feature gets enabled.
If possible, ensure this branch is regularly rebased with master and ensure the tests are passing.


chore: fix cognitive service tests

Related Issues/PRs

#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?

[ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

[ ] No. You can skip this section.
[ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

[ ] No. You can skip this section.
[ ] Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

/azp run

Codecov Report

Merging #2092 (e0d104c) into master (21cff04) will decrease coverage by 83.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #2092       +/-   ##
==========================================
- Coverage   87.02%   4.03%   -83.00%
==========================================
  Files         306     306
  Lines       16162   16162
  Branches      824     824
==========================================
- Hits        14065     652    -13413
- Misses       2097   15510    +13413

Files
Coverage Δ

...zure/synapse/ml/cognitive/text/TextAnalytics.scala
0.00% <ø> (-84.34%)
:arrow_down:

... and 295 files with indirect coverage changes

/azp run


base argument deprecated?

Thanks so much for this package, the argument base seems to be unused in the current version of this function and only appears in commented lines...
https://github.com/ecmwf-projects/thermofeel/blob/c5c18ce60466dfe91e2cf54087f560253106ca95/thermofeel/thermofeel.py#L164

Latest version in develop uses a different algorithm for computation that does not use base.
It relies on the exact definition of a time interval.

This will be available in the next release version


use latest image version for CVM base image

What type of PR is this?
This PR translates to using the "latest" available image version as the base image for CVM VHD.
We had pinned to an older image because of package issues with nullboot which have since been fixed by the Canonical team. Hence bumping the image version being used to be latest.
Successful VHD build with this change: https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=70230599&view=logs&j=796f8d7f-3985-5b50-4a3d-916efdb74087&t=4634bd36-5f3b-5fd4-245a-9d512d1f4f47

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.017%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2091

Relevant Lines:
2715

💛  - Coveralls


How to update my already installed soundcleod to 1.3.3?

I have an soundcleod installed and asked myself how to update to the new version without downloading the new installer? Is that even possible?

It automatically updates itself to the latest version in the background. Nothing needs to be done, except restarting the app.


Housemate, same behaviors, no way to select that condition

My husband and I only go out occasionally for curbside grocery pickup. My risk when doing that is minimal. If I look at the risk of being cooped up with him most of the day and night, every day and night, my risk skyrockets.
There needs to be a selection for "housemate practices exactly the same precautions that I do." He's actually more cautious.
The selections also did not make any sense to him, so either there need to be more options, or the descriptive language should be changed.

@machiyag can you link to the scenario where you risk skyrockets so we can know what you put in as variables?
Also, can you say more about specifically which selections didn't make sense?
Thanks!

Thanks for the quick response. I'll replicate it when I'm off work this
evening, so I can quote the language as written.
mh
On Fri, Nov 13, 2020, 12:54 PM Jeremy Blanchard<EMAIL_ADDRESS>wrote:

@machiyag https://github.com/machiyag can you link to the scenario
where you risk skyrockets so we can know what you put in as variables?
Also, can you say more about specifically which selections didn't make
sense?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microcovid/microcovid/issues/502#issuecomment-727025276,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKOO6V4OSUTEZIKQDCCAQXDSPWMHVANCNFSM4TT6FT3A
.

OK, I chose my husband. By that alone, microCOVID determines I am at high
risk.
Then I have to choose his risk profile.
None of the options is correct. Yes, he lives with his partner and both
only grocery shop, however his partner is me, so I guess I have to say
"lives alone and only grocery shops," in order to not accumulate three
people's risk. And each of us grocery shops by choosing curbside pickup,
and we mostly get to the "curb" by bike, so entirely outdoors, the store's
shopper dumps our groceries in bike trailer or car, we leave. Does your
scenario assume we're walking into the store?
Here's <https://www.microcovid.org/
?interaction=partner&personCount=1&riskBudget=1000&riskProfile=livingAlone&subLocation=US_41051&topLocation=US_41>
what
seems the best fit. Our risk tolerance is low - my husband is 69, I'm 59
and both a Type 1 diabetic and cancer survivor, so I definitely chose the
"high caution budget." The result looks like I'm doomed, even though we
continue to let our mail "dry out" for two days, wash everything washable
that comes into the house, wash any mask that went outside the house when
it comes back in. I'm even running a HEPA air cleaner that I bought because
of the smoke, and run because anything in the air makes me sneeze.
Tell me how to model all of that with the existing options. I did notice
what seems to be the addition of "uses microCOVID to maintain a risk of xx%
a year" to the behavioral choices. It's circular reasoning, but that's all
that I can find to make my home environment appear to be survivable.
My grocery shopping <https://www.microcovid.org/
?distance=sixFt&duration=5&interaction=oneTime&personCount=1&riskBudget=1000&riskProfile=frontline&setting=outdoor&subLocation=US_41051&theirMask=basic&topLocation=US_41&voice=normal&yourMask=basic>
interaction
seems intuitively about right.
mh
On Fri, Nov 13, 2020 at 12:54 PM Jeremy Blanchard<EMAIL_ADDRESS>wrote:

@machiyag https://github.com/machiyag can you link to the scenario
where you risk skyrockets so we can know what you put in as variables?
Also, can you say more about specifically which selections didn't make
sense?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microcovid/microcovid/issues/502#issuecomment-727025276,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKOO6V4OSUTEZIKQDCCAQXDSPWMHVANCNFSM4TT6FT3A
.

Hi @machiyag, it sounds like you are being exceptionally cautious. I'd suggest using the "0.1% annual risk" category for your housemate.
Another trick is, if you happen to know your husband's microcCOVID risk, just divide it by 2 to get his risk to you.
If you want to be more precise, we recommend using the spreadsheet - that allows you to model multiple people and see their effects on you.
That said, given what you have described, your risk is really quite minimal, and unless you're trying to interact with more people the spreadsheet is probably overkill.

I was more testing the app than actually trying to estimate my risk. I am
fearfully cautious (lots of underlying conditions), and my husband is so
cautious as to appear almost paranoid.
Thanks for the response,
mh
On Mon, Nov 16, 2020, 6:34 PM Benjamin Shaya<EMAIL_ADDRESS>wrote:

Hi @machiyag https://github.com/machiyag, it sounds like you are being
exceptionally cautious. I'd suggest using the "0.1% annual risk" category
for your housemate.
Another trick is, if you happen to know your husband's microcCOVID risk,
just divide it by 2 to get his risk to you.
If you want to be more precise, we recommend using the spreadsheet - that
allows you to model multiple people and see their effects on you.
That said, given what you have described, your risk is really quite
minimal, and unless you're trying to interact with more people the
spreadsheet is probably overkill.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microcovid/microcovid/issues/502#issuecomment-728647245,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKOO6V5VEEE7HT2JUEJMTW3SQHOKXANCNFSM4TT6FT3A
.

@beshaya do you wanna keep this one open as part of logging common user feedback or is there another next step here?

Lets keep it since it would get addressed as part of the partner overhaul I
proposed.
On Mon, Nov 16, 2020 at 8:52 PM Jeremy Blanchard<EMAIL_ADDRESS>wrote:

@beshaya https://github.com/beshaya do you wanna keep this one open as
part of logging common user feedback or is there another next step here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microcovid/microcovid/issues/502#issuecomment-728684616,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABM25LKVWLVKCX4KSCYYFILSQH6RPANCNFSM4TT6FT3A
.


Change deploy script

This change has simplified the deploy script.

Remove extra line
Change 'foobar' to $TARGET_NAMESPACE

Thanks!


ENH/BUG: Sparse now supports comparison op

[x] no open issue
[x] tests added / passed
[x] passes git diff upstream/master | flake8 --diff
[x] whatsnew entry

on current master
pd.SparseArray([1, 2, np.nan]) > 0
# [True, True, nan]
# Fill: nan
# IntIndex
# Indices: array([0, 1], dtype=int32)

# Expected
# [True, True, False]

a = pd.SparseArray([1, 2, 0])
b = pd.SparseArray([0, 1, np.nan])
a > b
# ValueError: operands could not be broadcast together with shapes (3,) (2,)

Ok, fixed and now green.

thank you sir!


Finalize naming conventions in guidance doc and code

To ship a stable NuGet package, our API must be stable. That means we need to agree on a fully-spec'd proposal for naming conventions and make sure they are consistently applied in the actual code.

I did a fast pass in the code, the things that seem to need renaming are :

[ ] CreateFileFlags members
[ ] CreationDisposition members
[ ] FileAccess members
[ ] FileShare members
[ ] SecurityImpersonationLevel (The native version is named SECURITY_IMPERSONATION_LEVEL)
[ ] FileAttribute members
[ ] FindFirstFileExFlags members
[ ] FormatMessageFlags members
[ ] WindowShowStyle members

Thanks, @vbfox.
I've never seen a checklist in markdown before. Cool.

It's a github specific feature, if you include it in the issue text it'll show when the issue is referenced with how many of the points are checked.
Also you can check the points by clicking on the checkbox and it update the text of the comment/issue to change [ ] to [x]

I'll attempt a rename of the points I listed in my comment and will report on what remains if I didn't completely finish.

Is there anything else to fix for this in the code, @vbfox and @jmelosegui ? Or should we close this?

I didn't see anything more about naming itself, but the uint -> int conversion remains I think (Don't know if it should be in this issue or another one)

Opened #88 to track


Add openshift oauth token support to KFP runtime

Is your feature request related to a problem? Please describe.
In the near future in ODH, the KFP API will be protected by an openshift oauth proxy sidecar, which will require any request to have a valid bearer token to proceed.
Describe the solution you'd like
openshift oauth token support added, changes needed in

kfp metadata schema
kfp runtime processor
tests updated

Describe alternatives you've considered
N/A
Additional context
Metadata section:

Thanks @akchinSTC for creating this issue! @humairak can you add any additional context that might be useful around how we're adding auth in front of the KFP API? Will the user need to be able to do anything beyond simply providing their OpenShift auth token? Do we require it in any specific format to to be passed via any specific header?

A bearer token as authentication type should be sufficient for us.
To make the ui future proof and more flexible, I would add an "add your own custom headers/values" section that you can tag onto the request to the api server. For instance KFP api server accepts a KUBEFLOW_USERID_HEADER that can be customized for multi-user isolation mode, so you can't hard code it. We intend to use an oauth proxy to add this header, but someone else might not.

@HumairAK - Thanks! As far as a test environment goes, do you have personal or test branch of the deployment manifests I need to test my changes or can I just use the master branch of odh-manifests?

@akchinSTC I set up branch here for you to try out: https://github.com/HumairAK/odh-manifests/blob/odh-dsp-auth-demo/data-science-pipelines/base/auth/AUTH_NOTES.md you should be able to follow these instructions and try querying the api server accordingly with auth header. Let me know if there are any issues.

thank you!


Representation of JWT Bearer grant in allowed grant types is not consistent with the rest of the grants

Describe the issue:
Create an app that uses OAuth/OIDC and note that the 'allowed grant types' listing is as below, where JWT bearer grant is not represented in a consistent way with the rest

How to reproduce:

Create an app that uses OAuth/OIDC
Go to protocol section
Note the above view

Expected behavior:
This should be listed similar to SAML2 as "JWT"
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

Impacts product quality aspects


Conda-build failing with partial circular import

Strangely "import xdem" works in the xdem CI with the base environment (along with all tests with the dev environment), but in conda-forge/xdem-feedstock for v0.0.11 the build fails with a circular import error in coreg/.

Finally found it!!! Needed to declare xdem/coreg as a package in setup.py now that it is a subfolder. Strangely, not having this didn't bother pip at all, but failed for our conda-forge recipe.
Solved by #398


glob() failed with return value 3

how can i fix this error: glob() failed with return value 3?
It appears after launching the program, and there is just an empty search bar, which does not actually work

Hello there. At least on my Linux machine return value 3 from glob() function is GLOB_NOMATCH error, meaning that no entries that match *.gpg are found from your password store. This could mean couple of things.

Your password store is located somewhere else than in ~/.password-store. In this case you should set environment variable PASSWORD_STORE_DIR to point to the location of your password store.
Your password entries use some other file extension than .gpg. (I highly doubt this is the case.)
The glob pattern used by this application cannot find the entries as they are not stored into subdirectories.

I will look at the glob pattern issue, as I have a hunch that globbing **/*.gpg does not detect entries that are not stored under a subdirectory.


Record Transaction/Upsert

Continuing from #149
I would like a transaction/upsert api to perform atomic updates against the server:
myRecord.transaction(function(localValue, remoteValue, remoteVersion, callback) {
    //do your merging, then retry
    callback( error, mergedVersion );
}, function(err) {
  if (err) {
    // Failed
  } else {
   // Accepted by server
  }
})

This is similar to setMergeStrategy but I need to be able to do it on a per operation basis, not per record basis and also know when it has been properly applied on the server

#458


removed all usages of numpy.compat

Reference issue
#13880
What does this implement/fix?
This fix removes all usages of numpy.compat.

@sanre3 please read our contributor guide (http://scipy.github.io/devdocs/dev/contributor/contributor_toc.html) and try to make this work locally, don't just push random commits. Your changes are very obviously incorrect.

@rgommers  can you please guide where to implement the functionality of asstr and asbytes

Seems like the user deleted his/her GitHub account...  As the PR does not solve the issue, we can close this in a few days if we don't have any news then.

IMO deleting their account is a clear indication they don't plan to continue so I'll close now.  If they reopen the account, they can always reopen the PR as well.


run options and native semantics

The run command takes a whole slew of options and they may or may not all be relevant to the driver. Here's from the official documentation:
=============
Run a query on a connection, returning either a single JSON result or a cursor, depending on the query.
The options can be:

use_outdated: whether or not outdated reads are OK (default: false).
time_format: what format to return times in (default: 'native'). Set this to 'raw' if you want times returned as JSON objects for exporting.
profile: whether or not to return a profile of the query’s execution (default: false).
durability: possible values are 'hard' and 'soft'. In soft durability mode RethinkDB will acknowledge the write immediately after receiving it, but before the write has been committed to disk.
group_format: what format to return grouped_data and grouped_streams in (default: 'native'). Set this to 'raw' if you want the raw pseudotype.
noreply: set to true to not receive the result object or cursor and return immediately.
db: the database to run this query against, specified with the db command. The default is the database specified in the db parameter to connect (which defaults to test). The database may also be specified separately with the db command.
array_limit: the maximum numbers of array elements that can be returned by a query (default: 100,000). This affects all ReQL commands that return arrays. Note that it has no effect on the size of arrays being written to the database; those always have an upper limit of 100,000 elements.
binary_format: what format to return binary data in (default: 'native'). Set this to 'raw' if you want the raw pseudotype.
min_batch_rows: minimum number of rows to wait for before batching a result set (default: 8). This is an integer.
max_batch_rows: maximum number of rows to wait for before batching a result set (default: unlimited). This is an integer.
max_batch_bytes: maximum number of bytes to wait for before batching a result set (default: 1024). This is an integer.
max_batch_seconds: maximum number of seconds to wait before batching a result set (default: 0.5). This is a float (not an integer) and may be specified to the microsecond.
first_batch_scaledown_factor: factor to scale the other parameters down by on the first batch (default: 4). For example, with this set to 8 and max_batch_rows set to 80, on the first batch max_batch_rows will be adjusted to 10 (80 / 8). This allows the first batch to return faster.

==============
Some of these options deal with 'native' and 'raw' forms for pseudotypes. I'm not sure whether this is something we want to support directly or not.

Run supports options, but there's a whitelist. only :db is supported right now.

Client side implementations needed for:

time_format
group_format
binary_format

Everything but the formats above should be in master

group_format isn't useful, time_format isn't really worth doing until Elixir 1.3, binary_format not worth doing... i think we're done here.


Slow operations reported by Atlas

Using Hangfire.Mongo v1.9.14 in production, on a Mongo Atlas M40 cluster.
The Atlas Profiler reports a lot of slow operations for the jobGraph collection (5-6 seconds to complete):

Most of those slow operations are reported for this query:
    "find": "Contents.jobGraph",
    "filter": {
      "_t": "ListDto"
    },
    "projection": {
      "_id": 1
    },

Which in my case returns 227k documents.
An explain on this query shows:

I believe that this long query is invoked by this code:
https://github.com/Hangfire-Mongo/Hangfire.Mongo/blob/b411aa164573c455e3b8670abb8019ee6c462d2e/src/Hangfire.Mongo/MongoWriteOnlyTransaction.cs#L338-L344
The enclosing method, TrimList(), has a key argument which is not used as a predicate in the Mongo query, but rather as a Where clause in a code manipulation of the returned list.
I wonder if refactoring the code to include the key in the Mongo query would help?

I have created the following index, and it seems to help (anecdotal evidence by explaining a few manual queries, will have to let it run for a few hours to see what Atlas Profiler has to report):
{
  _t: 1,
  _id: 1
}

Adding _id to the index makes the query/projection covered by the index, meaning there is no need for a FETCH stage:

I'll get back to you in a few hours with Atlas Profiler results!

So far so good!

The index definitely helps! (last 12 hours):

@bourquep,
Thank you for the analysis!
While I Definity will be adding the index, I'm curious as to why there are so many ListDto items (227K) in the first place. My expectation was that they would be removed as they should expire.
Would it be possible for you to share your ListDto's with me? The 227K ListDto's only should be fine.
Also I will be looking into doing this in an aggregation pipeline instead. It has always been a bit of a quick and dirty solution. :)
Thanks!

I'm curious as to why there are so many ListDto items (227K) in the first place. My expectation was that they would be removed as they should expire.

We use batches a lot, maybe it is related? They do expire and they are removed.

Would it be possible for you to share your ListDto's with me?

Sure, here they are!
studyo-hangfire.Contents.jobGraph.json.zip

@bourquep,
Looking at the ids query.
https://github.com/Hangfire-Mongo/Hangfire.Mongo/blob/b411aa164573c455e3b8670abb8019ee6c462d2e/src/Hangfire.Mongo/MongoWriteOnlyTransaction.cs#L338-L343
there seems to be room for further improvement in the filter as I did not take the key into account. so instead of fetching ALL ids, I can limit the count to the context of the given key like so:
 // get all ids for given key
 var filter = new BsonDocument
{
    ["_t"] = nameof(ListDto),
    [nameof(ListDto.Item)] = key
};
 var allIds = DbContext.JobGraph
      .Find(filter)
      .Project(new BsonDocument("_id", 1))
      .ToList()
      .Select(b => b["_id"].AsObjectId)
      .ToList();

looking at your collection the max returned documents would be 5 for a given key.

@gottscj Nice find! Then make sure to have an index on _t, key, _id

@bourquep,
I released a patch. please let me know if it works for you.
Thanks!

Looks like you forgot to create the index 😉

Yes, since you're projecting _id, including the field in the index will make the query "covered", meaning Mongo won't have to fetch the documents in order to project the _id.

Great!
Thank you for the help!

I haven't updated to 1.9.15 yet, was waiting for the index but I'll deploy the update in the coming days and let you know.

thanks! :pray:

I have updated to 1.9.15 at 11:00 this morning, and it makes a huge difference!

@bourquep,
Thank you for the feedback!
I will close this issue then. :)


Fix hue mixing for Lcha and Oklcha

Objective
Fix bad hue mixing in Lcha and Oklcha. Purple + Red == Green is the current behavior.
Solution
Use crate::color_ops::lerp_hue to handle the wrap-around at 360 degrees, the same way that Hsla, Hsva, and Hwba do it.
Testing
No tests, game jamming.

Sharing my workaround in the meantime:
/// Copy-pasted from bevy's `pub(crate)` version of this.
fn lerp_hue(a: f32, b: f32, t: f32) -> f32 {
    let diff = (b - a + 180.0).rem_euclid(360.0) - 180.0;
    (a + diff * t).rem_euclid(360.0)
}

// TODO: Workaround for https://github.com/bevyengine/bevy/pull/14468.
pub trait ColorExtBetterMix {
    fn better_mix(&self, other: &Self, factor: f32) -> Self;
}

impl ColorExtBetterMix for Color {
    fn better_mix(&self, other: &Self, factor: f32) -> Self {
        let mut new = *self;

        match &mut new {
            Color::Srgba(x) => *x = x.mix(&(*other).into(), factor),
            Color::LinearRgba(x) => *x = x.mix(&(*other).into(), factor),
            Color::Hsla(x) => *x = x.mix(&(*other).into(), factor),
            Color::Hsva(x) => *x = x.mix(&(*other).into(), factor),
            Color::Hwba(x) => *x = x.mix(&(*other).into(), factor),
            Color::Laba(x) => *x = x.mix(&(*other).into(), factor),
            Color::Lcha(x) => {
                *x = {
                    let other: Lcha = (*other).into();
                    let n_factor = 1.0 - factor;
                    Lcha {
                        lightness: x.lightness * n_factor + other.lightness * factor,
                        chroma: x.chroma * n_factor + other.chroma * factor,
                        hue: lerp_hue(x.hue, other.hue, factor),
                        alpha: x.alpha * n_factor + other.alpha * factor,
                    }
                };
            },
            Color::Oklaba(x) => *x = x.mix(&(*other).into(), factor),
            Color::Oklcha(x) => {
                *x = {
                    let other: Oklcha = (*other).into();
                    let n_factor = 1.0 - factor;
                    Oklcha {
                        lightness: x.lightness * n_factor + other.lightness * factor,
                        chroma: x.chroma * n_factor + other.chroma * factor,
                        hue: lerp_hue(x.hue, other.hue, factor),
                        alpha: x.alpha * n_factor + other.alpha * factor,
                    }
                };
            },
            Color::Xyza(x) => *x = x.mix(&(*other).into(), factor),
        }

        new
    }
}

This could be simplified for sure, but it was easiest to copy/paste and do this.


Added ES2015/16 alternative to _.object

Just rewrote a bunch of old calls to _.object in my codebase, so I thought I'd share this.
I don't think any of these calls were specifically in the format of _.object(objectLikeArray). They were more like _(array.map(functionToTurnIntoObject)).object(). But this is still useful.

Thanks!


Issue with backslash escaping in Laravel Blade templates

Laravel Version
10
PHP Version
8.1
Database Driver & Version
No response
Description
I encountered an issue while using localization in Laravel Blade templates involving the escaping of backslash characters (). When attempting to include a JavaScript string containing a backslash in a Blade template using the {!! !!} directive, the backslash is not properly rendered, leading to unexpected behavior.
Steps To Reproduce
1 - I have a localization file (en/messages.php) where I define a translated message containing a backslash
alert_message' => 'The message translate text\\'

2 - In my Blade template, I attempt to include this translated message in a JavaScript string using the {!! !!} directive
<script>alert("{!! __('alert_message') !!}");</script>

3 - However, the backslash in the translated message is not properly escaped, causing issues with the JavaScript string

After investigating, I found a workaround using the addcslashes helper function:
<script>alert("{{ addcslashes('\\','\\') }}")</script>

This workaround effectively resolves the issue by ensuring that the backslash is properly escaped in the JavaScript string.

While this workaround works for my case, it would be beneficial if Laravel could handle backslash escaping more gracefully in Blade templates, especially when using the {!! !!} directive.

I believe this issue could be addressed by improving the handling of backslashes in the Blade templating engine, ensuring that they are properly escaped in JavaScript strings when using the {!! !!} directive.

Thank you for your attention to this matter.

This is happening because your are manually creating a string in JS and not doing any escaping.
This is what's happening now:
"{!! 'Foo \\' !!}" = "Foo \"
Double escaping (once for PHP and once for JS) would work in this case, but I still wouldn't recommend it:
"{!! 'Foo \\\\' !!}" = "Foo \\"
It would probably be safer to use json_encode with the correct flags, or even better use the built in Illuminate\Support\Js::from helper:
{{ Illuminate\Support\Js::from('Foo \\') }} = 'Foo \\'
See: https://laravel.com/docs/10.x/blade#rendering-json

Thanks @rojtjo


A YAML way of defining a null value without removing the key

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Describe the Feature
There isn't a way to null a value in YAML other than to remove the key by deleting the key or commenting it out.
I'd like to use some kind of null value like <NULL> in atmos YAML without having to remove the key
e.g.
components:
  terraform:
    ecr:
      vars:
        some_input: <NULL>

Expected Behavior
The some_input: <NULL> should omit some_input when the tfvars is generated
Use Case
See above
Describe Ideal Solution
See above
Alternatives Considered
Removing the key or commenting it out
Additional Context
N/A

I think @nitrocode means a way to not pass a variable, versus passing the variable as null.

I think we ccould do something using !.
E.g.
some_input: !unset


Question: How can I extend a custom errorFormatter with additional parameters?

Hi Christoph,
I have question, on how to pass additional parameters to a custom errorFormatter.
I have written a custom errorFormatter to a different error format.
I want to extend the error message with another parameter but how can I do this?
My idea:
  req.checkBody("channel", "Enter a channel.", "message.missing.channel").notEmpty();

where "message.missing.channel" is a additional parameter i want to pass the error formatter.
desired result
{
      "code": 400,
      "message": "Enter a channel."
      "translation": "message.missing.channel"
}

But this it's not clear how I can pass the parameter to my customer errorFormatter.
Any tips or pointers to get me started?
Regards,
Tim

What if you pass objects instead of error messages?
req.checkBody( "channel", {
  message: "Enter a channel.",
  translation: "message.missing.channel"
}).notEmpty();

https://runkit.com/gustavohenke/5810ed6c36ace80014c85b40

Closing due to inactivity.


Add missing docs for InventoryPollIntervalSeconds.

Signed-off-by: Kristian Amlie<EMAIL_ADDRESS>

Good catch :+1:

Cherry-picked to 1.6.x and 1.7.x as well.


12 free downloadable programming e-books

What does this PR do?
Add resource(s)
For resources
Description
Include a collection of 12 free programming books ordered in the alphabetical order and official Secure (https) URLs
Why is this valuable (or not)?
A free downloadable collection of e-books related to programming
How do we know it's really free?
The site does not require any working email or an email to download the books
For book lists, is it a book? For course lists, is it a course? etc.
a list of books
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Please read docs/CONTRIBUTING.md guidelines!


remove bacalhau install from install script

https://github.com/labdao/plex/issues/89

merging this


Fix bugs so we can roundtrip certificates

This gets us to the point where the byte-for-byte encoding is equiavalent
to what bouncycastle was producing.
This shook out some bugs:

We weren't boxing the version
We weren't clearing the constructed bit on boxed extensions
We weren't encoding null when we needed to be

LGTM


CRUD publishes into "resources\config" folder instead of "app\config"

php artisan vendor:publish --provider="Backpack\CRUD\CrudServiceProvider" --tag="config"

Thank you @RamiMustaklem ,
You're totally right. It's now fixed in 3.1.34. A composer update should fix that for you.
Cheers!


Update natural-language-inference-attention.md

typo

Job d2l-zh/PR-1073/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-1073/


chore(deps): update tsjs to version 4

Proposed Changes
Update tsjs to version 4 and run lintfix
Potential Breaking Changes
None
Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

A lot easier to review if you hide whitespaces changes https://github.com/coveo/plasma/pull/2789/files?diff=split&w=1


feat: solve Simple Command & global variables

[OK] → Simple Command & global variables
Simple Command & global variables

[x]  → Test an empty command
[x]  → Test only spaces or tabs.
[x]  → run /bin/ls or other commands without args

Execute a simple command with an absolute path like /bin/ls, or any other command without any
options.
How many global variables are used? Why? Ask the evaluated student to give you a concrete example
of why it feels mandatory or logical.
If something crashes, select the "crash" flag.
If something doesn't work, select the "incomplete work" flag

all tests passed


Serious issues - Black screen for local recording and external camera streaming failure

Thank you to everyone who helped me.
Describe the bug
I downloaded the android project and go deployment, both from the May 2023 version.
android: 1.2.0
go: 1.4.2
I didn't make any changes, just the url and token. Run sample-app-record-local, either push the stream, the other party can not see, or save the local is no picture only sound.
To Reproduce

Samsung android10 device can push the stream, but when saved locally, there is no picture only sound.

The Hongmeng 2 system can crash directly when pushing disconnectRoom, and there is no picture only sound when saved locally. When I combine room.disconnect() and videoFileRenderer? When the.release() lines were swapped, an error was reported, but the video was saved

Customized devices based on android 12 use usb external camera, run sample-app, you can see the camera screen on the app page, and the other end (https://meet.livekit.io/? tab=custom) can not be seen, only see someone join, but the screen is black. And save local video is no picture only sound.

Expected behavior
Push the other party can see, save the video has a picture。I think the 8000 star project, demo should run directly without too much configuration can be learned. There shouldn't be so many problems.
Screenshots
The reproduction step corresponds to the screenshot
Device Info:

Device: Three devices as described above
LiveKit SDK version: [e.g. 1.4.2]     android demo [e.g:1.2.0]

please do NOT file dupe issues across repos


Clarify the job naming strategy

We need a spec similar to the dataset naming strategy for jobs

Here is the proposal:
https://github.com/OpenLineage/OpenLineage/pull/113


Exit stealth mode and add /about/foundation page to materialsproject.org

Problem
As discussed in this morning's foundation meeting, we think the foundation has become established enough to exit stealth mode and become more visible, partially with the intent of attracting a more diverse set of future members from the MP community.
Proposed Solution
Create a dedicated page at materialsproject.com/about/foundation introducing visitors to its objectives, current members and how to get involved.
I opened a PR with a proposal for what such a page might look like. Feedback welcome!
https://github.com/materialsproject/web/pull/895

Alternatives
No response

Could we add text about how to potentially get involved? I know this might also need a decision from our side first. This might also help with the diversity point that @mkhorton raised.

Yes, that's perhaps the most important content. This issue is to solicit input from everyone on how we want to phrase that.

@janosh I feel very disrespected that I am not included in the member list as a core infra member of MP, which is ironic considering this is raised along the topic of diversity. Could you clarify your intent behind this? Thank you.

No disrespect intended. My understanding is MP staff member and foundation member are two separate things, one doesn't imply the other. I wasn't aware you are or want to be part of the foundation. This PR is a draft and just includes everyone who was in today's Zoom meeting to get started.

@yang-ruoxi Just to be clear - Foundation and MP staff are two separate things. Foundation members and software maintainers are also two separate things. For example, I am lead maintainer for pymatgen but @janosh did not include me in the list of foundation members. There is no reason to feel "disrespected". If you want to be part of the foundation, you just have to ask. But if you are part of the foundation, be prepared to participate and contribute. So be clear on whether you want in or out.

@shyuep Thank you for your input. For context I have been participating in all past foundation meetings except for today (as I didn't feel well), I consider that as "I am part of it", hence the sense of being ignored. But do let me know if this is not obvious enough and I can further clarify. Thanks!

@yang-ruoxi In that case, by all means add yourself to the page... :-) Good luck. I hope you know what you signed up for.

In any case, we should, of course, include everyone that is involved in the foundation. I think a few other people from inside MP are missing as well (maybe, the mailing list that Alex used for the invitation helps)

I'd like to echo Ruoxi's point. She has been involved in almost every meeting so far and I would very much consider her a member of the Foundation.
I'm sure her omission was a simple mistake with no bad intentions. That said, we want the foundation to be a welcoming place for all members and personally I found the subsequent discussion questioning her involvement and commitment inappropriate.

@utf I don't recall anyone questioning her involvement or commitment.  I guess it is now fashionable to just call out simple clarifications for being "inappropriate"?

Just to further clarify, there was no ill will on my part. I felt the urge to get this PR opened before my next meeting yesterday to get the ball rolling and start gathering feedback. I now regret rushing it and not being more deliberate about the member list.
Following @JaGeo's advice I looked at the email list for the meeting reminder @utf sent out:
Alex Ganose
Anubhav Jain
Andrew Rosen
<EMAIL_ADDRESS>Janine George
Jason Munro
Kristin Persson
Karlo Berket
Ryan Kingsbury
Matthew Horton
Shyue Ping Ong
Patrick Huck
<EMAIL_ADDRESS><EMAIL_ADDRESS>Jimmy-Xuan Shen
Looks like we may also be missing @espottesmith<EMAIL_ADDRESS>Karlo Berket, Anubhav, Kristin and Shyue. I'll leave it to others to clarify who is involved to what extent.
@yang-ruoxi In any case, I feel like your concern would have been better served by an email rather than a heated discussion in public.

@janosh Let me get this clear: I understand this PR is a draft and I am sure the omission was a simple mistake with no bad intention. What frustrated me is when I raised the question, instead of simply being added, I wasn’t acknowledged well, and that I had to “prove” I am part of it, and to be educated the difference between the foundation and the staff, something I was well aware of.  I feel I had to go through this while other members don’t.
Ironically, this exact issue was created as an effort to address diversity and inclusivity.
So back to the topic of this thread, maybe we could reflect more on how we can be more inclusive towards collaborators? I doubt creating another web page that lists all current members would do it; after all, seeing the skewed gender ratio there may not be that helpful, not to mention there already exists such a section on web from a year ago. Maybe we could stress more on the code of conduct, our values and our principles instead.
I initially asked the question publicly because I feel inclusion is important and should be discussed publicly. However as the discussion drags on I find it unproductive and emotionally taxing, so I will stop responding from here.


Updated Readme

Readme looks even better now :)
Changes proposed along with screenshots
Added banner to readme.

Added bullet points to contributing guidelines section

I think https://github.com/kubesimplify/website/pull/127 is better and we don't require a banner. Thoughts?

I think #127 is better and we don't require a banner. Thoughts?

Yes #127 is better, we don't need it actually right now.


Pull based catchup

Currently, nodes will send catchup block data if they don't receive state updates from peers. This aggressive catchup routine is very error prone, because state messages are far from instant. Especially when the network is congested and state messages take longer to be received. Not only that, but if the peer is actually behind due to congestion, the congestion will only get worse as all of their peers will each send them block data.
Instead, nodes should request data from specific peers when they notice they are behind.
While slightly more conservative, it should significantly improve congestion.
This is related to the other efforts for faster recovery and compact blocks https://github.com/celestiaorg/celestia-core/issues/1334

Will this pull-based block part mechanism also replace block propagation or just catchup?

closing in favor of https://github.com/celestiaorg/celestia-core/issues/1532


Compilation database support across all platforms

This file is from mongodb and the tooling Automatically generates the compilation database across all platforms.
Thanks to acmarrow for a simple solution
https://github.com/SCons/scons/issues/3355
For the uninitiated this supports IDE symbol lookup, refactoring tools, documentation tools:
This means we can support intelisense style technologies with reliable type lookup.
For example:

CLion symbols (https://www.jetbrains.com/help/clion/compilation-database.html)
VSCode symbols / refactoring (https://devblogs.microsoft.com/cppblog/visual-studio-code-cc-extension-october-2017-update/)
QTcreator (https://doc.qt.io/qtcreator/creator-clang-codemodel.html#using-compilation-databases)
atom (https://atom.io/packages/linter-clang)
neovim
vim https://github.com/ycm-core/YouCompleteMe
anything which supports compilation db
etc

Co-authored-by: K. S. Ernest (iFire) Lee<EMAIL_ADDRESS>

Python 2.7 justification for upgrade:

Python 2.7 is going to be depreciated very soon in scons. (next release)

Scons would not build without this update with the compilation db on windows, due to a bug they have not fixed.
Simplifies osx path code.
Updated platform install to use sudo to install scons to prevent us having to modify path.
Since the VM image is thrown away this doesn't matter.

I have tested it on macOS (10.14.6) with CLion (2019.2.4).
While testing I found one issue, Objective-C files found in /platform/osx are not recorded to the compilation database.

I was able to fix it (quick and dirty) by adding , '.mm' to the _CXXSuffixes array.
https://github.com/godotengine/godot/blob/fb8bb2dcd4db1ece6bb25aabd52837b2f363b984/site_scons/site_tools/compilation_db.py#L39

P.S. Thank you @RevoluPowered and @fire for making this PR. I am incredibly grateful, happy, and overall ecstatic to have this.

I have tested it on macOS (10.14.6) with VSCode.
VSCode detected the compile_commands.json and generated the config c_cpp_properties.json. There are no false positives anymore!
However, same Objective-C issues as explained in https://github.com/godotengine/godot/pull/32848#issuecomment-544287242.

Side Note: I do not know if the generated c_cpp_properties.json file is correct or needs manual changes.

Hello, I will update the PR tomorrow as we are all returning from GodotCon

Note: @akien-mga please do not merge this yet travis is not building this PR anymore and I am not sure why.

not got access to apple hw, will delay this until tomorrow

@IAmActuallyCthulhu updated the suffixes properly so should be platform agnostic now
Adding the method to the cxxsuffix as requested would have broken it, so I have made it retrieve this directly from scons, on osx it will make it available and linux, but on windows it will not as this made appveyor break.

Doesn't seem to work on Windows, VS2017, Python 3.6.4, Scons v3.0.5.
[ 96%] Building compilation database compile_commands.json
...
[100%] scons: done building targets.

It simply produces an empty array in compile_commands.json.
scons platform=windows tools=yes target=release_debug bits=64 -j8

Same thing with target=debug debug_symbols=yes.

Doesn't seem to work on Windows, VS2017, Python 3.6.4, Scons v3.0.5.
[ 96%] Building compilation database compile_commands.json
...
[100%] scons: done building targets.

It simply produces an empty array in compile_commands.json.
scons platform=windows tools=yes target=release_debug bits=64 -j8

Same thing with target=debug debug_symbols=yes.

This will only work with scons 3.1.1 the stable release

@akien-mga I have updated with those changes requested and squashed into a single commit

Just leaving a note here before closing:

we are going to attempt getting this merged with scons.

This tooling is compatible easily with 4.0 if you need a solution (now) for compilation databases this is still the most efficient method of producing the compilation db. it seriously outperforms bear, and intercept-build as the list is already stored in scons data.
We will hopefully get support for the msvc compiler, this may require upstream fixes in scons to get right.
So hopefully in a month or two you will recieve a scons update with this functionality built into it.

Thanks for all your work :)
I plan on running MinGW periodically to update my compilation database in the meantime.

Thanks for all your work :)
I plan on running MinGW periodically to update my compilation database in the meantime.

Ach, can only take a minor part of credit, was team effort between me and @fire :)
also, acmarrow from mongodb :) and mongodb themselves

Force pushed an amend that fixes Python style issues (we now use black for formatting), and moves the script to misc/scons/site_tools as I found a workaround to override the default site_scons path. (Basically reimplementing what SCons' --site-dir command line option would do by using a private method - Thanks Python for not having real private methods :P).

Thanks!

Thanks for your help merging I had little time to pull away from FBX. That's great I am so happy, I use this regularly! <3

Getting the following error after this merge:
[ 98%] scons: done building targets.
TypeError: changed_since_last_build_node() missing 1 required positional argument: 'node':
  File "/usr/lib/scons/SCons/Script/Main.py", line 1376:
    _exec_main(parser, values)
  File "/usr/lib/scons/SCons/Script/Main.py", line 1339:
    _main(parser)
  File "/usr/lib/scons/SCons/Script/Main.py", line 1103:
    nodes = _build_targets(fs, options, targets, target_top)
  File "/usr/lib/scons/SCons/Script/Main.py", line 1313:
    jobs.run(postfunc = jobs_postfunc)
  File "/usr/lib/scons/SCons/Job.py", line 111:
    self.job.start()
  File "/usr/lib/scons/SCons/Job.py", line 423:
    task.executed()
  File "/usr/lib/scons/SCons/Script/Main.py", line 237:
    SCons.Taskmaster.OutOfDateTask.executed(self)
  File "/usr/lib/scons/SCons/Taskmaster.py", line 317:
    t.release_target_info()
  File "/usr/lib/scons/SCons/Node/FS.py", line 2980:
    self.changed(allowcache=True)
  File "/usr/lib/scons/SCons/Node/FS.py", line 3223:
    has_changed = SCons.Node.Node.changed(self, node)
  File "/usr/lib/scons/SCons/Node/__init__.py", line 1455:
    if _decider_map[child.changed_since_last_build](child, self, prev_ni):

Tested with both pip version:
SCons by Steven Knight et al.:
	script: v3.1.2.bee7caf9defd6e108fc2998a2520ddb36a967691, 2019-12-17 02:07:09, by bdeegan on octodog
	engine: v3.1.2.bee7caf9defd6e108fc2998a2520ddb36a967691, 2019-12-17 02:07:09, by bdeegan on octodog

and distro version:
SCons by Steven Knight et al.:
	script: v<IP_ADDRESS>b2c53bc42290e911b334a6b44f187da698a668, 2017/11/14 13:16:53, by bdbaddog on hpmicrodog
	engine: v<IP_ADDRESS>b2c53bc42290e911b334a6b44f187da698a668, 2017/11/14 13:16:53, by bdbaddog on hpmicrodog

@Faless The backtrace is from your distro version (/usr/lib/scons), so make sure that the pip version is not using the wrong SCons lib from the distro.

We should likely increase EnsureSConsVersion to the version needed for the compile DB, or alternatively disable generation of the compile DB on older SCons versions (might be more user-friendly).

@akien-mga right, my bash alias tricked me -.- . It works with the pip version, so yeah, scons 3.0.1 doesn't seem to work, scons 3.1.2 is fine.

Cherry-picked for 3.2.2. (Together with #38830 to fix build on older SCons versions.)


Code Execution with Gemini

https://ai.google.dev/gemini-api/docs/code-execution?lang=python

We've put this on hold now as the response structure for code execution is completely different from a regular tool calling response or chat response


Please add aarch64 version FreeBSD 13

Hello!
Arm is extremely trending nowadays.
aarch64 is now Tier 1 support in FreeBSD 13.
Please add such vm.
https://download.freebsd.org/ftp/releases/VM-IMAGES/13.0-RELEASE/aarch64/Latest/

I don't find a way to emulate ARM64 on x86.

But Github Actions has arm64 runners

Please have a look for instance this:
https://github.com/ivan-volnov/keybr/runs/2427605016

But Github Actions has arm64 runners

Since when?

Yep, you are right. I see now. It hasn't yet


Update cluster-management.md

modify "some node is not needed" to "some nodes are not needed"

This change is

I don't agree with this change. It can be only one node. So "some node" is fine. "Cluster autoscaler also scales down the cluster if it notices that some node is not needed anymore ..."

@steveperry-53  Thanks for your suggestion

LGTM


book/snippets/python

fixes:

Thanks, cherry-picked and squashed at 7edfd6717472c9e2f74ca3a12afea4a579555483

i am glad to contribute - you are doing awesome work!


Both ConnectCallback and DisconnectCallback are not called in adapters/libuv

I find it, when I try to use example-libuv connect an unopened port, It directly exit without call each of ConnectCallback and DisconnectCallback.
I check the code and find uv_run returned.

If the connection fails, there's no connection, so no connect callback, and no disconnection, so no disconnect callback.


Check for specpol.out to plot master spectra

Coverage remained the same at 71.275% when pulling 7d91f613bb9892b7bdea0bd4568daeaa9fe5be53 on master_spectra into 7d8f180a25376fa2994c914fcfa3aec4fb14ca13 on master.


Use desiredLRPSchedulingInfos instead of desiredLRPs

reduces amount of data fetched from bbs when syncing

[#145945785]
Signed-off-by: Swetha Repakula<EMAIL_ADDRESS>

@swetharepakula Could you please provide instructions for acceptance?

Since the change is in the underlying implementation and not the functionality the easiest way to verify the change is through the logs:
Once the change has been implemented you should be able to verify with the following log lines:
On the tcp-emitter you should eventually see a debug line: getting-desired-lrps. Shortly you should also see a log from the bbs-client on the tcp-emitter that is similar to:
{"session": "tcp-emitter...do-request", "message": "creating-request", "data": {"request_name": "DesiredLRPSchedulingInfos"}...}. Without this change the request_name would be DesiredLRPs_r2.
Additionally you should be able to find a corresponding logs on the bbs with the session: desired-lrp-scheduling-infos showing that request was received by the bbs.
Otherwise acceptance should include that no functionality/behavior has changed with this PR.
Thanks,
@swetharepakula


Add elasticsearch_major_version

The updated ansible role from elastic.co does checking on the
es_major_version, we need to set it to the correct major version in
order to pull from the appropriate repository.
Fixes: RO-3952
Issue: RO-3952

Do we use the elasticsearch_* variables other than to set es_* variables?  I'm just trying to determine if we need the additional layer of indirection or not.

@prometheanfire we do, so I just followed the pattern. It's probably not necessary and I may clean that up in the future.

recheck_cit_xenial_no_artifacts_swift_deploy now that https://github.com/rcbops/rpc-openstack/pull/2839 has merged


Singleton services

Is your feature request related to a problem? Please describe.
I have a service that manages the configuration data for my application. This configuration data is loaded from a file when the service is created, and is saved whenever a value is changed. These changes can be sent to the service from any other service/actor, but only one instance of the ConfigService should ever exist because it holds a handle to the config file and multiple instances would override each others' changes and potentially lose config data.
I've used ServiceConcurrency::None to have only a single instance of the service, but it still requires that the data is wrapped in a Mutex. It's possible to make a singleton this way, but not very convenient/user-friendly for something where I should be able to assume concurrent access will not happen (because messages are processed one by one).
Describe the solution you'd like
A Singleton trait, similar to Service, that guarantees only a single instance of the service exists, that doesn't require me to use a Mutex for its state, and that uses &mut self for its Listen & Serve traits.
Example (pseudocode):
struct ConfigService {
    file_handle: File,
}

impl Singleton for ConfigService {
    async fn initialize(system) -> Self {
        ConfigService {
            file: File::Open().await,
        }
    }
}

struct SetConfig(String);

impl Listen<SetConfig> for ConfigService {
    async fn handle(&mut self, data: SetConfig) {
        self.file.write_all(data.0).await;
    }
}

Hi!
This is something I will explore. Right now I'm updating the internals (no api change hopefully) so it is more flexible.
If I find the way to make this feature happen, I will do it! It sounds like a nice thing to have for people using the framework.

Just as a note: https://github.com/DavidBM/acteur-rs/issues/1#issuecomment-1005160614


not ready after istio-ingressgateway recreated

Hello,
After recreating the pod of istio-ingressgateway, the gateway pod is down
kubectl.exe delete pods istio-ingressgateway-xxx-xxx -n istio-system
NAME                                    READY   STATUS    RESTARTS   AGE
grafana-5984b44fcf-mt4hn                1/1     Running   0          106s
istio-ingressgateway-6f86b4785f-fcdr5   0/1     Running   0          110s
istio-tracing-55d747dbd-lvqcz           1/1     Running   0          106s
istiod-5cfb74fbfc-k8zmk                 1/1     Running   0          116s
kiali-65cd9df4c7-92czh                  1/1     Running   0          105s
prometheus-68767bf768-5twbr             1/1     Running   0          105s

the logs of the gateway pods:
2021-06-02T15:58:32.392140Z     warn    Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 9 successful, 0 rejected; lds updates: 0 successful, 9 rejected
Any suggestions please?

post the full logs please

post the full logs please, the error will be further up.

hello here is the full logs, do you have any suggestions please?
2021-06-02T19:11:04.260100Z     info    Proxy role: &model.Proxy{Type:"router", IPAddresses:[]string{"<IP_ADDRESS>", "fe80::50dc:f4ff:fec7:862"}, ID:"istio-ingressgateway-6f86b4785f-4qksw.istio-system", Locality:(*envoy_config_core_v3.Locality)(nil), DNSDomain:"istio-system.svc.cluster.local", ConfigNamespace:"", Metadata:(*model.NodeMetadata)(nil), SidecarScope:(*model.SidecarScope)(nil), PrevSidecarScope:(*model.SidecarScope)(nil), MergedGateway:(*model.MergedGateway)(nil), ServiceInstances:[]*model.ServiceInstance(nil), IstioVersion:(*model.IstioVersion)(nil), ipv6Support:false, ipv4Support:false, GlobalUnicastIP:"", XdsResourceGenerator:model.XdsResourceGenerator(nil), Active:map[string]*model.WatchedResource(nil), ActiveExperimental:map[string]*model.WatchedResource(nil), RequestedTypes:struct { CDS string; EDS string; RDS string; LDS string }{CDS:"", EDS:"", RDS:"", LDS:""}}
2021-06-02T19:11:04.260105Z     info    JWT policy is third-party-jwt
2021-06-02T19:11:04.260159Z     info    PilotSAN []string{"istiod.istio-system.svc"}
2021-06-02T19:11:04.260167Z     info    MixerSAN []string{"spiffe://cluster.local/ns/istio-system/sa/istio-mixer-service-account"}
2021-06-02T19:11:04.260220Z     info    sa.serverOptions.CAEndpoint == istiod.istio-system.svc:15012
2021-06-02T19:11:04.260232Z     info    Using user-configured CA istiod.istio-system.svc:15012
2021-06-02T19:11:04.260236Z     info    istiod uses self-issued certificate
2021-06-02T19:11:04.260285Z     info    the CA cert of istiod is: -----BEGIN CERTIFICATE-----
MIIC3TCCAcWgAwIBAgIQCBGvWKMXBaExRdmNlufJPTANBgkqhkiG9w0BAQsFADAY
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
OTE3Mjc1OVowGDEWMBQGA1UEChMNY2x1c3Rlci5sb2NhbDCCASIwDQYJKoZIhvcN
AQEBBQADggEPADCCAQoCggEBAMimzm4I3isgerOifiPb4OPdWENRLOOKwZjgLOHR
5rq/WOIfGsomaeShVVkjSIlSje4pYMxSKUpAa8pkrtVlangVPikyAocnzj0JykvL
VXxLqijsnR8gb3VULAYVN3dbpZNArhxOSPjDzE7B2b/ViLgVRf3tl5EeFN2Q/zd3
CQAlsOw8S/fmvtDT1qWolvlQjCKVnHB8tO5k/R8gRl+Kpi5un0FFjCJW26uCAkev
DCZv8h20e2/Lto4xxPK2aDWr3PU6kxLW6MdDKwiRMIWrto48Zl9bl/qb6jZ/UKza
NScneiNtZFxdg5KAbnd/KfA4xczDS5wgs/XGA3+YbnzmHE0CAwEAAaMjMCEwDgYD
r4sQUQZL7Sfn+cGy17Y6n3U5bY6DMObjNN5YkXeO1ybR1KpA+H3GrEDxVR4pfGnT
n0oSIe+WfNdw39cdq+he2HVicNgb5UpzmnJoFDIs4PZ5yp1KipLlgpJoyICKbHlC
mNHnd20lE0H427ndv+dw3kvVZLh5PRvaiBt9GyobTjzicMjGl6C5tOqu5geHMrWK
X/kMue5XDAiOEfLCAIUm0sE=
-----END CERTIFICATE-----
2021-06-02T19:11:04.353338Z     info    Starting gateway SDS
2021-06-02T19:11:04.387736Z     warn    secretfetcher   skip loading secret. Kubernetes secret aks-istio-secret contains a server certificate that fails to parse: failed to parse certificate: asn1: structure error: tags don't match (2 vs {class:0 tag:6 length:9 isCompound:false}) {optional:false explicit:false application:false private:false defaultValue: tag: stringType:0 timeType:0 set:false omitEmpty:false}  @2
2021-06-02T19:11:04.387823Z     warn    secretfetcher   skip loading secret. Kubernetes secret ingressistio contains a server certificate that fails to parse: failed to parse certificate: asn1: structure error: tags don't match (2 vs {class:0 tag:6 length:9 isCompound:false}) {optional:false explicit:false application:false private:false defaultValue: tag: stringType:0 timeType:0 set:false omitEmpty:false}  @2
2021-06-02T19:11:04.456110Z     info    sds     SDS gRPC server for workload UDS starts, listening on "./etc/istio/proxy/SDS"
2021-06-02T19:11:04.456281Z     info    sds     SDS gRPC server for gateway controller starts, listening on "./var/run/ingress_gateway/sds"
2021-06-02T19:11:04.456482Z     info    Starting proxy agent
2021-06-02T19:11:04.456319Z     info    sds     Start SDS grpc server
2021-06-02T19:11:04.456492Z     info    sds     Start SDS grpc server for ingress gateway proxy
2021-06-02T19:11:04.456676Z     info    Received new config, creating new Envoy epoch 0
2021-06-02T19:11:04.456701Z     info    Opening status port 15020
2021-06-02T19:11:04.456747Z     info    Epoch 0 starting
2021-06-02T19:11:05.494880Z     info    Envoy command: [-c etc/istio/proxy/envoy-rev0.json --restart-epoch 0 --drain-time-s 45 --parent-shutdown-time-s 60 --service-cluster istio-ingressgateway --service-node router~<IP_ADDRESS>~istio-ingressgateway-6f86b4785f-4qksw.istio-system~istio-system.svc.cluster.local --local-address-ip-version v4 --log-format-prefix-with-location 0 --log-format %Y-%m-%dT%T.%fZ  %l      envoy %n        %v -l warning --component-log-level misc:error]
2021-06-02T19:11:05.570801Z     warning envoy runtime   Unable to use runtime singleton for feature envoy.reloadable_features.activate_fds_next_event_loop
2021-06-02T19:11:05.614584Z     warning envoy config    StreamAggregatedResources gRPC config stream closed: 14, no healthy upstream
2021-06-02T19:11:05.614620Z     warning envoy config    Unable to establish new stream
2021-06-02T19:11:05.625517Z     info    sds     resource:default new connection
2021-06-02T19:11:05.625613Z     info    sds     Skipping waiting for gateway secret
2021-06-02T19:11:05.830593Z     info    cache   Root cert has changed, start rotating root cert for SDS clients
2021-06-02T19:11:05.830636Z     info    cache   GenerateSecret default
2021-06-02T19:11:05.831340Z     info    sds     resource:default pushed key/cert pair to proxy
2021-06-02T19:11:05.834800Z     warning envoy main      there is no configured limit to the number of allowed active connections. Set a limit via the runtime key overload.global_downstream_max_connections
2021-06-02T19:11:06.641147Z     info    sds     resource:ROOTCA new connection
2021-06-02T19:11:06.641267Z     info    sds     Skipping waiting for gateway secret
2021-06-02T19:11:06.641424Z     info    cache   Loaded root cert from certificate ROOTCA
2021-06-02T19:11:06.641640Z     info    sds     resource:ROOTCA pushed root cert to proxy
2021-06-02T19:11:06.730981Z     warning envoy config    gRPC config for type.googleapis.com/envoy.config.listener.v3.Listener rejected: Error adding/updating listener(s) <IP_ADDRESS>_8443: Invalid path: /etc/istio/ingressgateway-certs/tls.crt
2021-06-02T19:11:08.075339Z     warn    Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2021-06-02T19:11:10.053148Z     warn    Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2021-06-02T19:11:12.052713Z     warn    Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2021-06-02T19:11:14.052546Z     warn    Envoy proxy is NOT ready: config not rece

Sounds like you have a Gateway referencing an invalid file: /etc/istio/ingressgateway-certs/tls.crt
Also you are on an unsupported version, this has changed a lot. SEe https://istio.io/latest/news/support/announcing-1.8-eol-final/.

Sounds like you have a Gateway referencing an invalid file: /etc/istio/ingressgateway-certs/tls.crt
Also you are on an unsupported version, this has changed a lot. SEe https://istio.io/latest/news/support/announcing-1.8-eol-final/.

Thanks, but how it references always the file /etc/istio/ingressgateway-certs/tls.crt, I have deleted the gateway configuration and i used CredentialName in the deleted gateway configuration as below, why it still search the certificat in the wrong file /etc/istio/ingressgateway-certs/tls.crt?
kind: Gateway
metadata:
  name: app-gateway
spec:
  selector:
    istio: ingressgateway
  servers:
  - port:
      number: 443
      name: https
      protocol: HTTPS
    tls:
      mode: SIMPLE
      credentialName: ingressistio

You probably have some other gateway somewhere
On Wed, Jun 2, 2021 at 12:53 PM calvinShan @.***> wrote:

Sounds like you have a Gateway referencing an invalid file:
/etc/istio/ingressgateway-certs/tls.crt
Also you are on an unsupported version, this has changed a lot. SEe
https://istio.io/latest/news/support/announcing-1.8-eol-final/.
Thanks, but how it references always the file
/etc/istio/ingressgateway-certs/tls.crt, I have deleted the gateway
configuration and i used CredentialName in the deleted gateway
configuration as below, why it still search the certificat in the wrong
file /etc/istio/ingressgateway-certs/tls.crt?
kind: Gateway
metadata:
name: app-gateway
spec:
selector:
istio: ingressgateway
servers:

port:
number: 443
name: https
protocol: HTTPS
tls:
mode: SIMPLE
credentialName: ingressistio

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/33227#issuecomment-853340457, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXOTVCZXBKFOIPMLQXDTQ2D4JANCNFSM457BBCAA
.

You probably have some other gateway somewhere
…
On Wed, Jun 2, 2021 at 12:53 PM calvinShan @.***> wrote: Sounds like you have a Gateway referencing an invalid file: /etc/istio/ingressgateway-certs/tls.crt Also you are on an unsupported version, this has changed a lot. SEe https://istio.io/latest/news/support/announcing-1.8-eol-final/. Thanks, but how it references always the file /etc/istio/ingressgateway-certs/tls.crt, I have deleted the gateway configuration and i used CredentialName in the deleted gateway configuration as below, why it still search the certificat in the wrong file /etc/istio/ingressgateway-certs/tls.crt? kind: Gateway metadata: name: app-gateway spec: selector: istio: ingressgateway servers: - port: number: 443 name: https protocol: HTTPS tls: mode: SIMPLE credentialName: ingressistio — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#33227 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEYGXOTVCZXBKFOIPMLQXDTQ2D4JANCNFSM457BBCAA .

Yes, I understand, there is another gateway that uses the file /etc/istio/ingressgateway-certs/tls.crt
However, when I tried to create the gateway bu using credentialName, it does not work. So credentialName is not supported in my version 1.7.3?
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: app-gateway
spec:
  selector:
    istio: ingressgateway
  servers:
  - port:
      number: 443
      name: https
      protocol: HTTPS
    tls:
      mode: SIMPLE
      credentialName: istio-ingressgateway

PS C:\Users\swu> .\istioctl.exe version
client version: 1.10.0-rc.1
control plane version: 1.7.3
data plane version: 1.7.3 (2 proxies)


v0.3.0 & lapce 0.2.5

I have installed the plugin but code completion not working
I have maven project  ut nothing work is there any additional configuration needed to LSP work

I can confirm: Currently it does nothing i can see


Issue.488 - Updating Kitura Docs

Description
Updated the Jazzy Docs for Kitura including a usage example for each class. This involves no changes to the code since it is only changing comments. The new Docs require review to ensure they properly describe the classes as well as general wording and grammar checks.

Codecov Report

Merging #1189 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
- Coverage   85.41%   85.37%   -0.04%
==========================================
  Files          58       58
  Lines        8253     8251       -2
  Branches      770      770
==========================================
- Hits         7049     7044       -5
- Misses        921      922       +1
- Partials      283      285       +2

Flag
Coverage Δ

#Kitura
85.37% <100%> (-0.04%)
:arrow_down:

Impacted Files
Coverage Δ

Sources/Kitura/RouteRegex.swift
96.26% <ø> (ø)
:arrow_up:

Sources/Kitura/bodyParser/ParsedBody.swift
93.75% <ø> (ø)
:arrow_up:

Sources/Kitura/RouterMiddlewareGenerator.swift
100% <ø> (ø)
:arrow_up:

Sources/Kitura/RouterMethod.swift
100% <ø> (ø)
:arrow_up:

Sources/Kitura/JSONPError.swift
0% <ø> (ø)
:arrow_up:

Sources/Kitura/CodableRouter.swift
73.9% <ø> (ø)
:arrow_up:

Sources/Kitura/contentType/ContentType.swift
91.57% <ø> (-0.18%)
:arrow_down:

Sources/Kitura/RouterRequest.swift
93.61% <ø> (ø)
:arrow_up:

Sources/Kitura/Kitura.swift
100% <ø> (ø)
:arrow_up:

...ces/Kitura/staticFileServer/StaticFileServer.swift
95.65% <ø> (ø)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d36213...e04de1e. Read the comment docs.

Andy, please can you fix the fact that the contributing guidelines link in the README.md file doesn't work from the context of the API reference site (it does work when used directly from the README.md file on github). I realise that this isn't one of the files you've changed but to my mind it forms part of this documentation work so should be fixed as part of this changeset.

@Andrew-Lees11 this is stale - what's the status?

Closing after discussion: this is being split into smaller updates.

Do we need to keep the branch around?


pull request for e2e test at 01/29/2017 17:45:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add GET method for http tunneling

Hello .
could you add a HTTP tunneling via GET method , please ? because my firewall blocks my connection if the HTTP request beging with CONNECT method.
I will wait your answer.

Hi,
The latest commit https://github.com/tingtingths/tunnel.go/commit/c08d75e94574ae2ef5fe94e8904a520c767db877 add a new --method argument to allows the use of different methods.
E.g. to allow using GET & CONNECT methods
--method get,connect
However, I would recommand you to enable encryption between the proxy client and the tunnel server. That way the firewall shouldn't be able to tell the method in use.
Tony


[infra] HINT.UNREACHABLE_SWITCH_CASE is treated as an error by the test runner

I got the following output from the test runner.
/========================================================================================================================\
| co19/LanguageFeatures/Extension-types/exhaustiveness_variable_A04_t01 is new and failed (StaticWarning, expected Pass) |
\========================================================================================================================/

--- Command "dart2analyzer" (took 51ms):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart out/ReleaseX64/gen/dartanalyzer.dart.snapshot -Dtest_runner.configuration=analyzer-asserts-linux --enable-experiment=inline-class --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json --format=json /b/s/w/ir/cache/builder/sdk/tests/co19/src/LanguageFeatures/Extension-types/exhaustiveness_variable_A04_t01.dart

unexpected analysis errors in exhaustiveness_variable_A04_t01.dart:
- Line 24, column 5: HINT.UNREACHABLE_SWITCH_CASE
  This case is covered by the previous cases.

- Line 32, column 5: HINT.UNREACHABLE_SWITCH_CASE
  This case is covered by the previous cases.

--- Re-run this test:
python3 tools/test.py -n analyzer-asserts-linux co19/LanguageFeatures/Extension-types/exhaustiveness_variable_A04_t01

Why hint is treated as an error by the test runner? The test itself is the following
// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// @assertion Exhaustiveness of a variable pattern is determined by the static
/// type of the corresponding variable.
///
/// @description Check static type of a variable pattern
/// @author<EMAIL_ADDRESS>
// SharedOptions=--enable-experiment=inline-class

import '../../Utils/static_type_helper.dart';

extension type ET(int i) {}
extension type TO(int i) implements ET {}

main() {
  ET x = ET(1);
  switch (x) {
    case int y:
      x.expectStaticType<Exactly<ET>>;
      y.expectStaticType<Exactly<int>>;
    case TO z: // Unreachable, it's Ok // Line 24, column 5: HINT.UNREACHABLE_SWITCH_CASE
      x.expectStaticType<Exactly<TO>>;
      z.expectStaticType<Exactly<TO>>;
  }
  switch (42) {
    case ET y:
      x.expectStaticType<Exactly<ET>>;
      y.expectStaticType<Exactly<ET>>;
    case TO z: // Unreachable, it's Ok // Line 32, column 5: HINT.UNREACHABLE_SWITCH_CASE
      x.expectStaticType<Exactly<ET>>;
      z.expectStaticType<Exactly<TO>>;
  }
}

Not an issue. Please see https://github.com/dart-lang/sdk/blob/main/pkg/test_runner/lib/src/command_output.dart
  /// The set of hints which must be expected in a test. Any hint not specified
  /// here which is reported by the analyzer does not need to be expected, and
  /// never causes a test to fail.
  static const Set<String> _specifiedHints = {
    'unreachable_switch_case',
  };


:construction_worker: feat(docs): Switch docs site to docs-beta

Description
Make docs-beta the official docs site in anticipation of beta release.

make it build correctly
switch vercel to using docs-beta

Testing
Builds correctly
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Current dependencies on/for this PR:

main

PR #77   👈

This comment was auto-generated by Graphite.


Display#draw(Buffer $buffer) can no longer render widgets easily

The (old) public API for drawing frames can no longer easily render widgets as it requires the widget rendering service.
We can:

Remove this API: but need to get some confidence that everything can be done without it
Pass the widget renderer to the closure
Add a context class to encapsulate the buffer and renderer in the same parameter

I'm tempted to remove it as we now have the RawWidget which allows writing to the buffer directly.

API removed


GitHub App

Look into using GitHub App for authentication instead of PAT. Could also enable webhooks for more efficient re-triggering.

APP_ID
PRIVATE_KEY or PRIVATE_KEY_PATH

https://github.com/actions/create-github-app-token

Possible issue:

These endpoints only support authentication using a personal access token (classic). For more information, see "Managing your personal access tokens."

https://docs.github.com/en/rest/activity/notifications?apiVersion=2022-11-28


feat: Implement to use a 👍icon next to approved report preview.

Explanation of Change

Fixed Issues
$ https://github.com/Expensify/App/issues/49847
PROPOSAL: https://github.com/Expensify/App/issues/49847#issuecomment-2379422035
Tests

[Employee] Submit a expense as a employee
[Approver] Approve the request
[Approver] Verify the animation after approving the request.
Pay the approved expense and verify 👍 animates out and ✅ animates in

[x] Verify that no errors appear in the JS console

Offline tests

[Employee] Submit a expense as a employee
[Approver] Approve the request
[Approver] Verify the animation after approving the request.
Pay the approved expense and verify 👍 animates out and ✅ animates in

QA Steps

[Employee] Submit a expense as a employee
[Approver] Approve the request
[Approver] Verify the animation after approving the request.
Pay the approved expense and verify 👍 animates out and ✅ animates in
// TODO: These must be filled out, or the issue title must include "[No QA]."

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/2b3777ba-08d9-4163-b6d4-b7403d973a52

Android: mWeb Chrome
https://github.com/user-attachments/assets/75ca31c9-4155-4ac5-9c67-08403a52330c

iOS: Native
https://github.com/user-attachments/assets/a8adcc0e-7573-48fb-aa9b-56a4f148a004

iOS: mWeb Safari
https://github.com/user-attachments/assets/cb496aa5-b997-4c7c-8f6c-3bf69bbbef87

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/0b3761cf-5189-4f10-8954-97af55480e5e

MacOS: Desktop
https://github.com/user-attachments/assets/917d497c-7fb6-4c08-b1c2-d92b9663d273

@Krishna2323 Please help to confirm

This PR is the same as the previous PR
After you apply this PR, you can't reproduce the regression bug

Its mostly the same with some minor changes.

@Krishna2323 Could you detail changes?

@Krishna2323 Could you also explain why the regression bug is resolved on this PR?

Hmmm, So weird, I also don't understand why this bug happen in the previous PR

@Krishna2323 Please test again this PR and upload videos again.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/a7a2d4ab-ee04-4306-825b-26ccb50c7831

Android: mWeb Chrome

https://github.com/user-attachments/assets/9969c375-7b5c-4404-b574-6749b9668dc3

iOS: Native
https://github.com/user-attachments/assets/34908118-e725-4e33-8f1c-4861f6338a12

iOS: mWeb Safari

https://github.com/user-attachments/assets/ddd2ba32-923e-4238-893f-1e0c8d7b42f0

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/1f77d43a-9719-41eb-b046-bf4f8b65f631

MacOS: Desktop

https://github.com/user-attachments/assets/63ce043e-d4dd-4e8a-b29d-2d05242bc0e0

Just FYI the Reanimated library version has changed since the previous PR, so that may have contributed to the fix as well.

@youssef-lr Friendly bump

I've started testing this one today and got caught up with a bug. I'm on it again today.

@youssef-lr Is it ready to merge?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


#parent and #children should raise for full identifiers

When attempting to get the parent or children (using #parent resp. #children) of an item/layout that has a full identifier (e.g. /foo.md rather than the legacy /foo/), an exception should be thrown. These two methods do not yield useful results for non-legacy identifiers.

Potential fix in #710.


Add error message for shape mismatch

Address for #14 , catch the shape mismatch before PyTorch throws RuntimeError.
Returns an error message as below:
AssertionError: Two tensors have a different shapes
 Spec:
	Expect: torch.Size([5])
	Got: torch.Size([1, 5])

Sorry, this unfortunately breaks broadcasting. You could try catching the runtime error.

Sorry, I didn't notice this would break broadcasting.
I've changed the assertion only for this particular runtime error.


IPF meta-analysis study

Add IPF study https://doi.org/10.1164/rccm.201905-1017OC

I thiiink it should be fine now. I remember now that I saw that the alleles were switched and reflected that on the betas but forgot to fix the ref/alt.


Requsting a new Sign Up/Log In method

Preflight Checklist

[x] I could not find a solution in the existing issues, docs, nor discussions
[ ] I have joined the ZITADEL chat

Describe your problem
While doing a login we get 3 options ->

Google
Github
Zitadel account

Describe your ideal solution
I think Zitadel should have a GitHub login option because I belive GitHub is more widely used then GitLab.
Version
No response
Environment
ZITADEL Cloud
Additional Context
No response

Hi @SaunakNandi
Thanks for adding the issue.
Just to verify we are talking about the same.
You want to have the Github login for the customer portal of ZITADEL?
E.g. the login on zitadel.com?

as i didnt get any answer on the issue, i will close it for now.
I can reopen if we get some more information


(Rasa core, Rasa nlu) Button are not working for payload as no actions are being called against the buttons in action_default_ask_affirmation. Also I can see the button's text in the command line but are not being displayed on the UI

Rasa Core version: 0.12.3
Python: 3.6.7
Operating system: Ubuntu
Issue: Button are not working for payload as no actions are being called against the buttons in action_default_ask_affirmation. Also I can see the button's text in the command line but are not being displayed on the UI
Custom action

class ActionDefaultAskAffirmation(Action):
    """Asks for an affirmation of the intent if NLU threshold is not met."""
    def name(self):
        return "action_default_ask_affirmation"

    def run(self, dispatcher, tracker, domain):
        absFilePath = os.path.abspath("IntentMappings.csv")
        self.intent_mappings = {}

        with open(absFilePath, newline='', encoding='utf-8') as file:
            csv_reader = csv.reader(file)
            for row in csv_reader:
                self.intent_mappings[row[0]] = row[1]

        # get the most likely intent
        last_intent_name = tracker.latest_message['intent']['name']

        if last_intent_name == None or last_intent_name == "None" or last_intent_name == "":
            intent_prompt = "Oh! Its seems like I didn’t get that. Let’s try again or you can call at our UAN 111 456 789"

        else:
            # get the prompt for the intent
            intent_prompt =  self.intent_mappings[last_intent_name]

        # Create the affirmation message and add two buttons to it.
        # Use '/<intent_name>' as payload to directly trigger '<intent_name>'
        # when the button is clicked.
        message = "***** '{}'?".format(intent_prompt)
        button = [{'title': 'Yes',
                    'payload': '/{}'.format(last_intent_name)},
                    {'title': 'No',
                    'payload': '/out_of_scope'}]

        dispatcher.utter_button_message(message, buttons = button)

        return []

i'm not sure i understand the problem, where are buttons not being displayed? Could you show some examples?

I have customized the 'action_default_ask_affirmation' action and i have two buttons there to affirm and deny the intents, below is the code:
button = [{'title': 'Yes',
'payload': '/{}'.format(last_intent_name)},
{'title': 'No',
'payload': '/out_of_scope'}]
and
Now the problem is that, when i enter '/out_of_scope' in the command line to deny, or '/suggested_intent_name to affirm it doesn't call the action related to these two intents.
And when i run my bot on the user interface it doesn't even display the buttons on the interface.
I have attached a screen shot for the clarity as well.

Hm I don't see the screen shot, but @wochinge can you look at this? You're more familiar with this policy :D

Sorry i forgot to attach the screen shot, but i think there is no need of it as the problem is clear. Thanks

Also how can we use/implement two stage fall back policy on the User Interface?

Alright, I'll close this issue then.
Please ask usage questions in the forum


Added FTDatetime

Fixes #54

Codecov Report

Merging #55 (daccbaf) into main (170eab9) will decrease coverage by 66.7%.
The diff coverage is 100.0%.

:exclamation: Current head daccbaf differs from pull request most recent head 8d560a8. Consider uploading reports for the commit 8d560a8 to get more accurate results

@@           Coverage Diff            @@
##            main     #55      +/-   ##
========================================
- Coverage   99.5%   32.8%   -66.6%
========================================
  Files         86      88       +2
  Lines       2120    2245     +125
========================================
- Hits        2108     735    -1373
- Misses        12    1510    +1498

Impacted Files
Coverage Δ

...ilyst/preprocessors/datetime/aggregate_datetime.py
100.0% <ø> (ø)

...sts/preprocessing_tests/test_aggregate_datetime.py
100.0% <ø> (ø)

facilyst/preprocessors/__init__.py
100.0% <100.0%> (ø)

facilyst/preprocessors/datetime/__init__.py
100.0% <100.0%> (ø)

facilyst/preprocessors/datetime/ft_datetime.py
100.0% <100.0%> (ø)

...lyst/tests/preprocessing_tests/test_ft_datetime.py
100.0% <100.0%> (ø)

facilyst/models/utils.py
0.0% <0.0%> (-100.0%)
:arrow_down:

facilyst/tests/test_version.py
0.0% <0.0%> (-100.0%)
:arrow_down:

facilyst/models/optimizers/hyperopt.py
0.0% <0.0%> (-100.0%)
:arrow_down:

facilyst/tests/mock_tests/test_wave.py
0.0% <0.0%> (-100.0%)
:arrow_down:

... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 170eab9...8d560a8. Read the comment docs.


Small enhancement on addr2line.py

if can't parse function name with dwarf information, use "name section" instead
add introduction about using custom section

@eloparco please be aware of.