Missing "else" changes branch percentage

When a script contains an "if" without an "else" the file is flagged for not having covered the "else" that isn't there. This changes the total coverage of the branches incorrectly when the contents of the "if" are fully covered. The lone "if" should be detected correctly.

how do you test
          Eif (defaultValues.hasOwnProperty(property)) {
            $window.s[property] = defaultValues[property];
          }
        }``` ?

var parent = { key: 'value' };
var child = Object.create(parent);
child.key2 = 'value2';
// ...
expect($window.s.key).toBeUndefined();
expect($window.s.key2).toBe('value2');

@tomasdev  - these are the hard-to-test cases where you can use /* istanbul ignore else */ to signal that the else path is hard to test or untestable.

why istanbul show warning only on first IF (on line 35) but ignore second IF (on line 42)
!(https://i.imgur.com/Hm26ar6.png)
result in htmlview
!(https://i.imgur.com/rZUHQdr.png)

@jt3k Probably you have not tested the 4 possibilities of your if.

@robsonbittencourt why did you write this text? can't you see my question?

Yes it can. I replied because I think the warning refers to you don't have covered the four possibilities of first if. Already the second if must have had his two possibilities covered.

If I can contribute to this at all, I think the error could use a more explicit description.
We just started using istanbul and didn't understand the output. Initially the developer assumed the test wasn't getting into the if block (because it indicated it wasn't covered).  That led to some crazy misunderstandings of how istanbul was evaluating code.
After reading the error completely, the developer realized it was complaining about an else not being run, but when we looked at the source, there was no else statement at all.  The developer was pretty confused, a lot of random things seemed to be occurring.
At this point, the first assumption was that for some reason istanbul required if statements to have else statements, which seemed crazy.  Eventually we uncovered this github issue and figured out what is really happening.
After seeing this happen, it seems reasonable that it would happen to others. I believe making the user aware that this coverage test requires if statements to eval as true and false will help save some headaches.

var isEmptys = function() {
    var obj = this;
    for (key in obj) {
        E if (typeof(obj[key]) !== 'function' && obj[key]) {
            return false;
        }
    }
    return true;
}

The disturbing "else path not taken" occurs when I test the code in all cases:
            (isEmptys.call({})).should.be.true();
            (isEmptys.call({9:1})).should.be.false()

THAT MAKES ME MAD!!!

@lifeich1 I agree with you.
That is idiotism :(

I found I made a mistake. There is an another testcase:
            (isEmptys.call({1:function() {}})).should.be.true();

I am sorry for ignoring that case.

Just contributing with a practical example of how to get rid of this problem. I have the following:
async updateTravelInfo(newLocation) {
  if (!isEqual(newLocation, this.props.location)) {
    // update location accordingly
  }
  // Nothing to do
}

In other words, the update location stuff only needs to be called if the location changes. To test this, I have the following:
test("fetches travel info when location changes", () => {
  const travelTime = jest.spyOn(baseProps.locationsService, "getTravelInfo");

  travelTime.mockResolvedValue({ time: "100 anos", from: "Madrid" });

  const wrapper = shallowWithContext(
    <Home {...baseProps} />,
  );

  wrapper.setProps({
    location: {
      location: {
        latitude: 12,
        longitude: 21,
      },
    },
  });

  // FUNCTION called the first time (if taken)
  expect(travelTime)
    .toHaveBeenCalledWith({
      lat: 12,
      lng: 21,
    });

  // Set the same props as before
  wrapper.setProps({
    location: {
      location: {
        latitude: 12,
        longitude: 21,
      },
    },
  });

  // The function should have been called just once!
  // The error disappeared from coverage report.
  expect(travelTime)
    .toHaveBeenCalledTimes(1);
});

With this I have no uncovered branches.

So I understand your philosophy now that I've read through this thread, but you have to admit this is hella confusing if you're just looking at the reports. 100% of statements, 100% of functions, and 100% of lines covered, with line 12 uncovered. Mmmk.

File                 |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
---------------------|----------|----------|----------|----------|-------------------|
  logger.js          |      100 |       75 |      100 |      100 |                12 |

Instanbul is a great tool; it would be nice if it supported more use cases.

I disagree. This is not a "feature."
In order to "test" the "empty else block that notionally exists" I actually have to add something to the script that does nothing. That doesn't lint well, and it is just plain poor programming practice. Can you at least provide a configuration option to turn this off?

It simply means you have to provide a spec that tests the else case. There's no need to add useless code.

Ok, now let me give you an example of why istanbul is not working correctly. Let's say that we want to display temperatures in celsius if and only if our visitor is from a non-US country, and we have a function that does the checking for us, like so:
var foo, ab;
ab = "32 Degrees";
foo = visitorIsNotUSBased();
if (foo) {
ab = convertFarenheightToCelsius(ab);
}
$('#waterfreezes').val(ab);
In the example above there is no else because we don't want to do anything to ab if foo is not true. Running this code through istanbul with the appropriate tests, it will nag at me for an else that not only does not exist but does not have to or need to exist. Why is that correct?

in this example, ab can have one of two possible values. But, you are only testing it for one of the values. Technically, your coverage is incomplete.
What happens when you call expect($.val).toHaveBeenCalledWith(?), you should cover all the ways the val can be called.

My question is, if there is nothing at all after the if statement, where the if statement is the only thing inside a function.
public set initialData(value: string) {
      if (value) {
        this.form.get('selection').setValue(value);
      }
   }

What's the advantage of mocking the else case and having that coverage?

HI Can you please assist the below test cases in angular?
Here i have written one test case
it('productSelection', async(() => {
spyOn(component, 'productSelection');
const btn = fixture.debugElement.query(By.css('.BPNormal'));
btn.triggerEventHandler('click', 'productSelection');
fixture.whenStable().then(() => {
expect(component.productSelection).toHaveBeenCalled();
});
}));
still in code coverage showing  conditional 50 % (1/2).
Could you please please provide me the expecting test cases example.
Thanks in advance.

I just encountered this.  I still don't understand why this is considered a "feature".  Take for example the following:
if (typeof x !== "number") {
  ...
} else if (x > 2) {
  ...
} else if (x <= 2) {
 ...
}

Why mark that as else path not taken - it is logically impossible for the else path to be taken, provably so.  Why should I get less than 100% coverage here when under no system of logic could the else path ever be taken let alone need to be coded let alone need to be tested?
I don't understand ... :-(

The last else if in the above code can be else. That should solve the problem.
Your code could also be rewritten in this way:
if (typeof x !== "number") {
    ...
    return
} else if (x > 2) {
    ...
    return
}
...

This way all the cases can be covered. It's my opinion that the else path coverage rules are designed to force us to write if-else statements this way. I'm still trying to understand the coverage rules.

@joelgetaction I think there is actually an implicit else that is possible, even though Istanbul isn't "smart" enough to know whether or not that is the case (I think).
$ node
> x = NaN
NaN
> typeof x
'number'
> x > 2
false
> x <= 2
false

I dont really understand why this is a feature and has no config options, because of the following example
(context: this is inside an function that assembles an mongoose Schema)
// interface BaseVirtual {
//   options?: {
//     [key: string]: any;
//     overwrite: boolean;
//   };
//   get?(): any;
//   set?(toSet: any): any;
// }
// getterSetters is of type Map<string, BaseVirtual>
// sch is of type mongoose.Schema<any>
for (const [key, virtual] of getterSetters) {
  if (virtual.options && virtual.options.overwrite) {
    sch.virtual(key, virtual.options);
  } else {
    if (virtual.get) { // else path not taken
      sch.virtual(key, virtual.options).get(virtual.get);
    }

    if (virtual.set) { // else path not taken
      sch.virtual(key, virtual.options).set(virtual.set);
    }
  }
}

why is this marked as "else path not taken" when there is simply nothing todo in an else path (because sch.virtual(key, virtual.options).set(undefined); or "null" would not be accepted by the function)

My workaround is doing like this:
function handleChange() {
  if (!props.onChange) return;

  props.onChange('value');
}

And then I test it without the onChange prop.

it is sad
Does anyone here know about the existence of a plugin that could add sorting capability to Atom?

I was pretty annoyed with this error and the debate in the thread until I read this comment https://github.com/gotwarlost/istanbul/issues/35#issuecomment-397301354 from @andreyluiz .
Since most linters I've used do not want you to have unnecessary return statements, doing something like:
if (isTrue) {
  doSomething()
}
return

is not feasible. I thought that was what was being advised until the previous comment, when I realized I'm just supposed to actually test the event in which the if statement does not pass (e.g. isTrue === false). This makes a lot more sense to me, and I find the rule very helpful so thank you to everyone who debated about this.

Change something with only if statement to
 onKeyDown={event => {                             if (this.state.shouldClose && event.keyCode === ECS_KEY) {                                 this.setState({                                     toShow: false,                                 });                             }                         }}
To this with shortand
 onKeyDown={event => {                              (this.state.shouldClose && event.keyCode === ECS_KEY) &&                                   this.setState({                                      toShow: false,                                  })                         }}

I've read through this entire discussion trying to understand why this makes sense and why my branch coverage wasn't 100% regardless of how many tests I wrote. like @Jimmydalecleveland said about the former comment. it really is just about explicitly testing the "branches" in your code. even if it does nothing explicitly testing that, is necessary.

Consider this as a jest bug and add /* istanbul ignore else */ on top of your if


sudden value csfle.configs.visible

Hello
For gcs sink we're getting sudden change introduced from Confluent side trying to change csfle.configs.visible from null to false

There's zero documentation about this
Thanks

@marcinkubica thanks for creating the issue! We reached out to the Connect API owners internally, and they identified it as a backend bug. They've created a Jira ticket (CC-29530) to resolve the issue.

@marcinkubica
Update: I just spoke with the Connect team, and they informed me that the fix has already been released. Could you check whether the issue has been resolved? Thank you!

@marcinkubica, can you please confirm if the fix is working fine?

@marcinkubica, we are going to resolve this bug, as another user reported that the issue was resolved in the duplicate issue: https://github.com/confluentinc/terraform-provider-confluent/issues/466#issuecomment-2443142676


Code is very slow on Google Colab

Hi. Your code is very slow on Google Colab but on my personal laptop with a GTX1050ti it runs pretty fast. Below I am attaching a picture that shows your progress bar on Google Colab:

Nevermind, it only seemed slow in the beginning but sped up afterwards.


Dual screenshots

I see these screenshots sometimes.... it's screenshotName and referenceName

Sorry for the delay.
Sometimes? Sounds weird.
What's the real height of the page? Does it match with the screenshot height? Or is it some kind of FOUC where the page isn't fully loaded before taking screenshots?

Sometimes?

Actually, I haven't seen the problem for a log time :)

Does it match with the screenshot height?

Nope

What's the real height of the page?

I did't use width/height params with browser.checkDocument, so I don't know

Or is it some kind of FOUC where the page isn't fully loaded before taking screenshots?

Nope
I think we can close this issue and reopen when I'll reproduce it again

I think we can close this issue and reopen when I'll reproduce it again

Ok


timedelta64[D] is always coerced to timedelta64[ns]

Hi guys, the following snippets show the issue...
xarray.DataArray([1,2,3,4]).astype('timedelta64[D]')

#output is
"""
<xarray.DataArray (dim_0: 4)>
array([<PHONE_NUMBER>0000,<PHONE_NUMBER>00000,<PHONE_NUMBER>00000,<PHONE_NUMBER>00000], dtype='timedelta64[ns]')
Coordinates:
  * dim_0    (dim_0) int64 0 1 2 3
"""

Compare this with Pandas:
pandas.Series([1,2,3,4]).astype('timedelta64[D]')

#output is
"""
0   1 days
1   2 days
2   3 days
3   4 days
dtype: timedelta64[D]
"""

This behvaiour becomes more problematic when trying to convert from timedelta[ns] to e.g. days as ints:
xarray.DataArray(pandas.Series([1,2,3,4]).astype('timedelta64[D]')).astype(int)

#output is
"""
<xarray.DataArray (dim_0: 4)>
array([<PHONE_NUMBER>0000,<PHONE_NUMBER>00000,<PHONE_NUMBER>00000,<PHONE_NUMBER>00000])
Coordinates:
  * dim_0    (dim_0) int64 0 1 2 3
"""

Again contrast that with pandas:
pandas.Series([1,2,3,4]).astype('timedelta64[D]').astype(int)

#output is
"""
0    1
1    2
2    3
3    4
dtype: int64
"""

Other variations of timedelta e.g. timedelta64[s], timedelta64[W] etc suffer from the same problem.
Thanks

The conversion to timedelta64[ns] is done on this line of code:
https://github.com/pydata/xarray/blob/d66f673ab25fe0fc0483bd5d67479fc94a14e46d/xarray/core/variable.py#L169
Is there a reason behind the conversion, or could it be removed?

Interesting. Pandas always uses nanosecond precision for TimedeltaIndex but not Series:
In [13]: s = pandas.Series([1,2,3,4]).astype('timedelta64[D]')

In [14]: s
Out[14]:
0   1 days
1   2 days
2   3 days
3   4 days
dtype: timedelta64[D]

In [16]: pandas.Index(s)
Out[16]: TimedeltaIndex(['1 days', '2 days', '3 days', '4 days'], dtype='timedelta64[ns]', freq=None)

This might actually be a pandas bug -- as far as I recall, this goes against the documented behavior.

The pandas docs do seem to say that conversion to timedelta64[D] (or other frequencies) is possible - see: http://pandas.pydata.org/pandas-docs/stable/timedeltas.html#frequency-conversion
Also here's a more realistic example of why this is problematic for me - I have a sequence of dates and I want to calculate the difference between them in days: possible in pandas, but not possible in xarray without first reverting to pandas/numpy types
dates = pandas.Series([datetime.date(2016, 01, 10), datetime.date(2016, 01, 20), datetime.date(2016, 01, 25)]).astype('datetime64[ns]')

dates.diff().astype('timedelta64[D]').astype(float)
#returns
#0     NaN
#1    10.0
#2     5.0
#dtype: float6

xarray.DataArray(dates).diff(dim = 'dim_0').astype('timedelta64[D]').astype(float)
#returns
#<xarray.DataArray (dim_0: 2)>
#array([  8.64000000e+14,   4.32000000e+14])
#Coordinates:
#  * dim_0    (dim_0) int64 1 2

Again the xarray result is in ns rather than days.
Thanks

df_trans['DELTA'].dt.days should work, in both pandas in xarray.


Fix link to Guards page at bottom

Just fixing a broken link. I copied the convention from other pages here in the docs where you links to an internal page using ./pagename.md

Thanks so much!


Windows cookbook does not support two packages with the same package name

Version:
Chef Client 12.1.0
Windows Cookbook 1.36.3
Environment:
Windows 7 64-bit
Windows Cookbook 1.36.3
Scenario:
Install two Microsoft Visual C++ 2005 Redistributable Packages
Both packages install with a package_name of "Microsoft Visual C++ 2005 Redistributable" but with different version numbers.
Steps to Reproduce:

Download vcredist packages

version 8.0.56336 http://www.microsoft.com/en-us/download/details.aspx?id=5638
version 8.0.59193 http://www.microsoft.com/en-us/download/details.aspx?id=14431

Run the following recipe twice
windows_package 'Microsoft Visual C++ 2005 Redistributable 8.0.56336' do
action :install
package_name 'Microsoft Visual C++ 2005 Redistributable'
source <path_to_vcredist_8.0.56336>
version '8.0.56336'
installer_type :custom
options '/Q'
end
windows_package 'Microsoft Visual C++ 2005 Redistributable 8.0.59193' do
action :install
package_name 'Microsoft Visual C++ 2005 Redistributable'
source <path_to_vcredist_8.0.59193>
version '8.0.59193'
installer_type :custom
options '/Q'
end

Expected Result:
Both packages to install and report "up to date" on subsequent runs.
Actual Result:
Both packages install, but one package always reinstalls in subsequent runs.
I believe this is because the installed_packages function uses a hash with the package_name as the key. This drops one of the packages since they have the same package_name. The chef client the doesn't know that the package is installed and attempts to install it.
Running puts installed_packages returns only one "Microsoft Visual C++ 2005 Redistributable" listed.
{
    ...
    "Microsoft Visual C++ 2005 Redistributable" => {: name => "Microsoft Visual C++ 2005 Redistributable", : version => "8.0.59193", : uninstall_string => "MsiExec.exe /X{837b34e3-7c30-493c-8f6a-2b0f04e2912c}" },
    "Chef Client v12.1.0" => {: name => "Chef Client v12.1.0", : version => "<IP_ADDRESS>", : uninstall_string => "MsiExec.exe /I{8693C589-4430-4E92-9241-87FF9B52C8C5}" }
}

Have you tried this using the "package" resource (which would use the windows_package provider in core Chef)?

My understanding is that the built in package resource only supports MSIs.

@Tech356 yeah, you're correct, I missed that. What are these?
I think we're going to end up putting our effort into expanding the core resource rather than rewriting how the windows cookbook differentiates between installed packages (core does it in a more reliable way already too)

@btm I am pretty sure they are self extracting installers. They have a cab and a MSI inside.
From my basic knowledge it seems that when using the windows cookbook it overrides the core windows_package resource. So I can either use the windows cookbook XOR the core windows_package resource. Is that correct? Is there a plan to make the core windows_package resource able to co-exist with the windows cookbook?

@Tech356 yeah, you can use the core windows package even when the windows cookbook is in the runlist by using package (this functionality was provided by https://www.chef.io/blog/2015/02/10/chef-12-provider-resolver/).

We've just come across the same problem. We're installing the C Redistributable packages for 2010, 2012 & 2013. They all have the same name (vcredist_x86.exe). This seems to be the cause of the problem because the files get cached in the same directory %userprofile%.chef\local-mode-cache\cache. Hence each version overwrites the previous one.

This scenario is addressed via https://github.com/chef/chef/pull/4193 however there is something to be aware of with this particular installer.
While it is certainly possible, as observed here, for two packages to have the exact same display name to be installed together, many packages may not install "side by side" but will detect other existing packages and uninstall them prior to install.
For example even after the new package resource is added released in an upcoming chef client, installing the above to installers in the order you have them will cause the following sequence of events:

First C++ runtime is installed
Second runtime will install and uninstall the first.
Next client run
First installer will install again
second installer will not install because it will be seen as already installed
all subsequent runs will not converge either resource

So things are better but you still will have one "unexpected" converged resource. You will be able to avoid that by simply flipping the order in which these resources sit in the recipe.

We've removed the windows_package provider in this cookbook in favor of the package provider that is built into chef now. I'm going to close this issue out. If you're still seeing the problem with that modernized code please open an issue up against chef/chef.


Update testcontainers-scala-mssqlserver, ... to 0.40.15

About this PR
📦 Updates

com.dimafeng:testcontainers-scala-mssqlserver
com.dimafeng:testcontainers-scala-mysql
com.dimafeng:testcontainers-scala-oracle-xe
com.dimafeng:testcontainers-scala-postgresql

from 0.40.11 to 0.40.15
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.dimafeng" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.dimafeng" }
}]

labels: test-library-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #861.


Labeled loops

Description
Loops should be possible to label, so they can be broken or continued from an inner loop.
I am unsure of the best syntax for this, we can go for the classic:
label: while true {}

Or we can go for a different syntax:
while:label true {}

Use Cases
var x = 0;
outer: while x < 100 {
    var y = 0;
    while y < 100 {
        if my_condition {
            break outer;
        }
        y = y + 1;
    }
    x = x + 1;
}

It's decided, we're using the label: while condition {} syntax.


capture(cdc): do not pass context to the etcd client to prevent etcd operation does not take effects

What problem does this PR solve?

Issue Number: ref #4757
What is changed and how it works?
At the moment, we pass the ctx to create the etcd client, it may happen that the context was canceled when the client was processing some internal operation, such as resigning the campaign key;
This is fixed by remove the ctx passed to the etcd client.
Before

Now

Check List
Tests

manual test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.

Codecov Report

Merging #6284 (1ff7f25) into master (bcb773a) will decrease coverage by 0.0376%.
The diff coverage is 62.8205%.

Flag
Coverage Δ

cdc
65.7796% <62.8205%> (-0.0944%)
:arrow_down:

dm
51.8880% <ø> (+0.0151%)
:arrow_up:

engine
63.0424% <ø> (-0.0544%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #6284        +/-   ##
================================================
- Coverage   59.0443%   59.0067%   -0.0377%
================================================
  Files           736        736
  Lines         85346      85353         +7
================================================
- Hits          50392      50364        -28
- Misses        30483      30522        +39
+ Partials       4471       4467         -4

/run-all-tests

/run-all-tests

/run-integration-test
/run-kafka-integration-test

/merge

/run-all-tests


Bug? libmamba error: cannot install both pin-1-1 and pin-1-1

Hi guys,
Thanks a lot for making your research available.
I'm trying to install it locally, following the installation instructions in your readme file. However, in the next-to-last step, I get this weird error:
$ conda install --file requirements.txt -c conda-forge
Channels:
 - conda-forge
 - bioconda
 - defaults
 - https://repo.anaconda.com/pkgs/free
 - nvidia
 - pytorch
Platform: linux-64
Collecting package metadata (repodata.json): done
Solving environment: \ warning  libmamba Added empty dependency for problem type SOLVER_RULE_UPDATE                                                                                failed

LibMambaUnsatisfiableError: Encountered problems while solving:
  - cannot install both pin-1-1 and pin-1-1

Could not solve for environment specs
The following packages are incompatible
└─ pin-1 is installable with the potential options
   ├─ pin-1 1, which can be installed;
   └─ pin-1 1 conflicts with any installable versions previously reported.

Pins seem to be involved in the conflict. Currently pinned specs:
 - python 3.8.* (labeled as 'pin-1')

Have you seen this before? Do you know how I could solve that?
Thanks!

Hi,
Thanks for your interest in our work!
We haven't experienced this issue before and I cannot reproduce it locally. So, I can only make an "educated guess" based suggestion.
I see that you're using mamba as the dependency solver. Switching to the default conda solver might help, despite being slower. To do that, you can use the command conda install --file requirements.txt -c conda-forge --solver classic
If this doesn't solve the issue, could you share the list of installed packages in the environment? To do so, you can run conda activate s4_for_dd; conda list.
Let me know how this goes. I wouldn't want Conda standing in your way 🙂
Cheers.


Add Workspace support introduced in Code 1.18. Fixes #29

This is moving from workspace.rootPath to supporting multiple folders in a workspace. This was introduced in VS Code 1.18. More information in the issue #29.

Hey @Telokis do you mind giving this a quick review?

This has one known bug atm that seems to be a bug in VS Code. When the picker is opened to choose a workspace folder, it is always returning the same one. You can track the status of the issue in https://github.com/Microsoft/vscode/issues/38059
Cheers,
Dominik

Will take a look at this in exactly 8 hours from now!

Currently testing on VSCode 1.18.0 (commit dcee22022709a4f223185514b9275aa4229841aa7) on Windows 10 x64 and I get this error:
[dkundel.vscode-new-file] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for 'newFile.defaultBaseFileName', provide the URI of a resource or 'null' for any resource.
extensionHostProcess.js:4
[dkundel.vscode-new-file] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for 'newFile.defaultFileExtension', provide the URI of a resource or 'null' for any resource.
extensionHostProcess.js:4
[dkundel.vscode-new-file] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for 'newFile.expandBraces', provide the URI of a resource or 'null' for any resource.
extensionHostProcess.js:4
[dkundel.vscode-new-file] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for 'newFile.fileTemplates', provide the URI of a resource or 'null' for any resource.
extensionHostProcess.js:4
[dkundel.vscode-new-file] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for 'newFile.relativeTo', provide the URI of a resource or 'null' for any resource.
extensionHostProcess.js:4
[dkundel.vscode-new-file] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for 'newFile.rootDirectory', provide the URI of a resource or 'null' for any resource.
extensionHostProcess.js:4
[dkundel.vscode-new-file] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for 'newFile.showPathRelativeTo', provide the URI of a resource or 'null' for any resource.
extensionHostProcess.js:4
[dkundel.vscode-new-file] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for 'newFile.useFileTemplates', provide the URI of a resource or 'null' for any resource.

Seems like there is a new way to get config. I'll investigate a bit further.

Looks good to me. I don't know how to trigger your showWorkspace stuff, though.
It worked out of the box for my own settings:
  "newFile.showPathRelativeTo": "root",
  "newFile.relativeTo": "file"

You can reach it by opening two folders in a workspace and then not having an active editor window (i.e. no file open). This should trigger the dialog.

The issue seemed to be in my insiders build and has been fixed since.

Alright, I just tried it and it works fine for me.


support RUNNER_TRACKING_ID background job

Feature Description
ref: https://github.com/actions/runner/issues/598#issuecomment-721151364
Screenshots
No response

The act_runner has no process tree kill mechanism, so it always behave like setting RUNNER_TRACKING_ID to ""

Setup an unsecure runner using mybackgroundjobs:host as label

the only possible mode of actions/runner, default docker container are a gitea/act extension
to bypass creating a docker container that would kill any background job

Just start the background process and act_runner doesn't care about it

you can set RUNNER_TRACKING_ID="" like described in the referenced issue if you want to support both GitHub and Gitea Actions

thx for your help,I have got a way use systemd-run cmd run backgroud


I love it but I just can't get it verified 1.0.1 on etherscan.

It just gives me an error all the time. To make it worse, I also now deplyed it two times... ;( on the test network rinkeby).
yarn run v1.22.15
warning package.json: No license field
warning ../../../../../../../package.json: No license field
$ hardhat verify --constructor-args config/ContractArguments.ts 0xE621f8C8D9219D11c5a0Cb70bD6c4B04fAC6caEE --network rinkeby
Nothing to compile
No need to generate any newer typings.
Compiling 1 file with 0.8.9
Successfully submitted source code for contract
contracts/GoodGoldNFT.sol:GoodGoldNFT at 0xE621f8C8D9219D11c5a0Cb70bD6c4B04fAC6caEE
for verification on Etherscan. Waiting for verification result...
We tried verifying your contract GoodGoldNFT without including any unrelated one, but it failed.
Trying again with the full solc input used to compile and deploy it.
This means that unrelated contracts may be displayed on Etherscan...
Successfully submitted source code for contract
contracts/GoodGoldNFT.sol:GoodGoldNFT at 0xE621f8C8D9219D11c5a0Cb70bD6c4B04fAC6caEE
for verification on Etherscan. Waiting for verification result...
Error in plugin @nomiclabs/hardhat-etherscan: The contract verification failed.
Reason: Fail - Unable to verify
For more info run Hardhat with --show-stack-traces
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Hi @GoodGoldDev,
first of all, you should not call the yarn deploy command twice, that would deploy a new instance of the same contract on the chain. The verification step is completely independent and you can call it many times (if needed), but deploying just once.
There are many possible reasons for the verification steps to fail, please take a look at #17 and let me know if it helps.

@GoodGoldDev unfortunately not, any transaction on the blockchain is final as soon as it's confirmed by the nodes. 😉
I'm gonna leave this issue open, waiting for some updates about the validation studd. Thank you.

I find it hard to see if I changed some of the variables you mentioned.
Maybe it is best to start all over again as a test? Deploy it and after that verify it asap. ;)
For example, I did change the whitelist price and amount opened and closed it while not being verified.

@GoodGoldDev that's understandable, if you changed the whitelist price then that might the problem (at least one of them), because that's exactly one of the constructor arguments used during deployment and they must match during verification.
Testing multiple times is fine, just make sure you rename your contract (e.g. if you want to call you final contract MyNft you may go for MyNftTest1, MyNftTest2 and so on until you reach to the final testing... this is required in order to avoid #7).
I'm gonna close this now, but feel free to reply if you need anything about the same topic.

It works flawless! Thanks a million it is a true piece of art you made!


Resolve updating progress after restarting downloading issue

Description
LEARNER-6870

Resolve download icon is not updating progress after restarting downloading.
Issue fixed for orientation change.

Notes

[ ] Test by changing screen orientation.
[ ] Test by changing screen.
[ ] Test by restarting download.

@farhan , @miankhalid Please have a look on this PR.


Peer Review Milestone2

Hi Team-Rocket,
The Wiki was a great read and gave me a clean overview of what the team is trying to achieve.
Can you share the username and password for Jenkins which can help me check the deployment of various services? You can mail it to me at sbaranwa@iu.

Hi @BBaggines ,
We have dropped an email to you with Jenkins credentials.
Thanks.

Can you mail me them too @sairohithA007

sure @tylerthedeveloper.

Hey @sairohithA007,
I logged in through the account I had created in the morning. On hitting submit, it gives a pop up saying logged in. However, the page did not redirect anywhere. I am not sure if this is expected or I am missing something.
Below is the screenshot of the screen:

As you an see, i am logged in but i am not sure of how to proceed to the dashboard to search for music. Clicking on Utopia symbol does not redirect too.
Regards,
Shradha Baranwal

I was able to log in again after logging out and reach the dashboard. However, clicking on Utopia from dashboard leads me back to the above page where I am kind of stuck and unable to go the dashboard.
Also, there is an option of signing up even if you are logged in which I feel is unnecessary.
Apart from that, the look and feel of the app is great. I would definitely use it. It is intuitive. The dummy commit triggered the build as expected. I am convinced of the architecture that has been implemented for the project. I am not clear on the need of APIBroker which i will hopefully understand during the presentation.
Great work!!
Regards,
Shradha Baranwal

Thanks for your feedback, @BBaggines ! I have raised an issue for the same #123
The sign up button even when logged in shouldn't be showing up. Hopefully, it'll get fixed when the incorrect redirection error is fixed.
APIBroker is the intermediary for all Spotify related tasks.  The UI doesn't make any spotify calls directly, rather it is directed to the APIGateway and from there to the APIBroker, whose sole task is to make requests to Spotify API


Error while deploying

Error
{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.","details":[{"code":"VMExtensionProvisioningError","message":"VM has reported a failure when processing extension 'AzureStackHCIHost'. Error message: "DSC Configuration 'AzureStackHCIHost' completed with error(s). Following are the first few: The term 'Choco' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. The PowerShell DSC resource '[cChocoInstaller]InstallChoco' with SourceInfo 'C:\Packages\Plugins\Microsoft.Powershell.DSC\<IP_ADDRESS>\DSCWork\AzureStackHCIHost.0\AzureStackHCIHost.ps1::842::9::cChocoInstaller' threw one or more non-terminating errors while running the Set-TargetResource functionality. These errors are logged to the ETW channel called Microsoft-Windows-DSC/Operational. Refer to this channel for more details. The SendConfigurationApply function did not succeed."\r\n\r\nMore information on troubleshooting is available at https://aka.ms/VMExtensionDSCWindowsTroubleshoot "}]}

Thanks @billcurtis I am looking into it.

@billcurtis I have updated the DSC cchoco module to latest version. Seems like this has been fixed by the update. Please confirm and let me know if you still have the issue.

@yagmurs , I still see the error. Can you confirm if the issue is closed?
{
"code": "DeploymentFailed",
"message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.",
"details": [
{
"code": "VMExtensionProvisioningError",
"message": "VM has reported a failure when processing extension 'AzureStackHCIHost'. Error message: "DSC Configuration 'AzureStackHCIHost' completed with error(s). Following are the first few: WinRM cannot process the request. The following error with errorcode 0x80090350 occurred while using Negotiate authentication: An unknown security error occurred.  \r\n Possible causes are:\r\n  -The user name or password specified are invalid.\r\n  -Kerberos is used when no authentication method and no user name are specified.\r\n  -Kerberos accepts domain user names, but not local user names.\r\n  -The Service Principal Name (SPN) for the remote computer name and port does not exist.\r\n  -The client and remote computers are in different domains and there is no trust between the two domains.\r\n After checking for the above issues, try the following:\r\n  -Check the Event Viewer for events related to authentication.\r\n  -Change the authentication method; add the destination computer to the WinRM TrustedHosts configuration setting or use HTTPS transport.\r\n Note that computers in the TrustedHosts list might not be authenticated.\r\n   -For more information about WinRM configuration, run the following command: winrm help config."\r\n\r\nMore information on troubleshooting is available at https://aka.ms/VMExtensionDSCWindowsTroubleshoot "
}
]
}


Wrong memory layout when handle virtual inheritance

Consider the test case in virtual_inheritance.hpp, C++ will generate memory layout as
&d = 0x7fff566a88b0
offset_of(A::foo)=32
offset_of(B::foo=32
offset_of(C::foo=32
offset_of(B::bar)=24
offset_of(C::baz)=8
offset_of(D::bazz)=28
a = 0x7fff566a88d0
offset_of(A::foo)=0
b = 0x7fff566a88c0
offset_of(A::foo)=16
offset_of(C::baz)=8
c = 0x7fff566a88b0
offset_of(A::foo)=32
offset_of(C::baz)=8

#include <stdio.h>
#include <stdint.h>
#include <stddef.h>

class A {
public:
  int foo;
};

class B: public virtual A {
public:
  int bar;
};

class C: public virtual A {
public:
  int baz;
};

class D: public C, public B {
public:
  int bazz;
};

int main() {
    D d;

int main() {
    D d;

    printf("&d = %p\n", &d);

    printf("offset_of(A::foo)=%lu\n", (uintptr_t)&d.foo - (uintptr_t)&d);
    printf("offset_of(B::foo=%lu\n", (uintptr_t)&((B *)&d)->foo - (uintptr_t)&d);
    printf("offset_of(C::foo=%lu\n", (uintptr_t)&((C *)&d)->foo - (uintptr_t)&d);
    printf("offset_of(B::bar)=%lu\n", (uintptr_t)&d.bar - (uintptr_t)&d);
    printf("offset_of(C::baz)=%lu\n", (uintptr_t)&d.baz - (uintptr_t)&d);
    printf("offset_of(D::bazz)=%lu\n", (uintptr_t)&d.bazz - (uintptr_t)&d);

    A *a = &d;

    printf("a = %p\n", a);

    printf("offset_of(A::foo)=%lu\n", (uintptr_t)&a->foo - (uintptr_t)a);

    B *b = &d;

    printf("b = %p\n", b);

    printf("offset_of(A::foo)=%lu\n", (uintptr_t)&b->foo - (uintptr_t)b);
    printf("offset_of(C::baz)=%lu\n", (uintptr_t)&b->bar - (uintptr_t)b);

    C *c = &d;

    printf("c = %p\n", c);

    printf("offset_of(A::foo)=%lu\n", (uintptr_t)&c->foo - (uintptr_t)c);
    printf("offset_of(C::baz)=%lu\n", (uintptr_t)&c->baz - (uintptr_t)c);
}

bindgen will generate memory layout as
#[repr(C)]
#[derive(Debug, Copy)]
pub struct B {
    pub vtable_: *const B__bindgen_vtable,
    pub bar: ::std::os::raw::c_int,
}

#[repr(C)]
#[derive(Debug, Copy)]
pub struct C {
    pub vtable_: *const C__bindgen_vtable,
    pub baz: ::std::os::raw::c_int,
}

#[repr(C)]
#[derive(Debug, Copy)]
pub struct D {
    pub _base: C,
    pub _base_1: B,
    pub bazz: ::std::os::raw::c_int,
}

First, both C and B will be aligned to 16 bytes, it cause D::bazz be aligned to 32 bytes rather than 28 bytes.
Second, A::foo should be generated and following D::bazz.
#[repr(C)]
#[derive(Debug, Copy)]
pub struct D {
    pub vtable_c: *const C__bindgen_vtable,
    pub baz: ::std::os::raw::c_int,
    pub vtable_b: *const B__bindgen_vtable,
    pub bar: ::std::os::raw::c_int,
    pub bazz: ::std::os::raw::c_int,
    pub foo: ::std::os::raw::c_int,
}

Yeah, I believe this partially a dupe of #380, though the foo thing is of course right.

This is clearly a bug btw, and thanks for the report (it's deeply appreciated, as usual :))

No problem, I'm working on the alignment issue, the layout test cases failed on it, just disable all the alignment tests when two or more virtual inheritances

That's awesome, thanks for working on that! :)


fix: platform check on set_show_menu_on_left_click

The platform check was broken after a merge I'm afraid. It needs to spell out target_os in the check.
This is regression caused by changes in #11726 compared to the changes merged from #11729.

windows is a shortcut for target_family = "windows" and should work. (there's another unix shortcut but that includes macos and linux so we don't use it often)

Right... I would swear I had issues that went away with changing this but changing it back now it's still all ok. Sorry for my lack of knowledge here.


Fix sample code for dynamic imports

See https://github.com/eyereasoner/eye-js/issues/36#issuecomment-1403555238

:tada: This issue has been resolved in version 2.5.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v2.5.1

Your semantic-release bot :package::rocket:


feat: Add 'open-namespaces' feature

What does this PR try to resolve?
This is a step towards #13576
How should we test and review this PR?
Additional information

@bors r+

:pushpin: Commit de5ac272334889230161daccc9dcfeae63a8c0da has been approved by weihanglo
It is now in the queue for this repository.

@bors r+

:pushpin: Commit 9ea3f260a80da949c47197ccdc43fe781426de07 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 9ea3f260a80da949c47197ccdc43fe781426de07 with merge 2fe739fcf16c5bf8c2064ab9d357f4a0e6c8539b...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 2fe739fcf16c5bf8c2064ab9d357f4a0e6c8539b to master...

@epage @weihanglo Is there an easy way I enable this feature in a workspace? Now it seems I need to add cargo-features = ["open-namespaces"] to each crates in the workspace and I have more than 20 crates in the workspace ..

No.
Just note that at this moment this feature is not useful at all.

To add, only enough has been implemented to unblock compiler work.

Thank you! Yes I see https://github.com/rust-lang/rust/issues/122349#issuecomment-2002208868 and hit exactly the same now.


Error using fromJSON with own property

If you run fromJSON(D("my").pe(2).ow("s").toJSON(), 'en') you will get the error 'Constituent.fromJSON: illegal prop:own'. The issue seems to be with the definition of the own option at https://github.com/rali-udem/jsRealB/blob/master/src/Constituent.js#L643 where, unlike any other property, own gets an optionName different from its option. I think this issue could be fixed by moving https://github.com/rali-udem/jsRealB/blob/master/src/Constituent.js#L578 earlier, but I haven't checked this.

Simon
I have fix this with a few other things that came up when I tested other examples.
thanks for your feedback
Guy


Update LinkShrink.net

Here is a new fix for LinkShrink.net.
Please, note that this involves the evaluation of untrusted code through a call to vm.runInNewContext. However, this should be rather safe since the execution is sandboxed and limited to 100ms (a shorter limit might be fine too).

@connesc hi there, this change looks scary IMHO, current linkshrink implementation doesn't work?

@thangngoc89 : no, the current implementation does not work anymore.
However, I was a little too hurried to fix this: what I took for a JavaScript challenge was a simple base64 encoding function :innocent: . I will clean this in minutes.

@connesc Thank you for your fix.


Should selection.{enter,exit} be fields or methods?

Methods allow them to return a lazily-constructed empty selection by default, which is nice. And it’s backwards-compatible and consistent with the rest of the D3 API, so I think this is a good idea.


Added Python resources

Description
added resources for python language
resolved #32
Type of change
Please check options that are relevant to your PR.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:

[x] I have pulled the latest changes in the repository
[x] I have squashed my commits
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Resolve merge conflicts!

resolved

Thamks :)


Use RabbitMQ with Testcontainers for testing.

Updated the test to use ZIO-Testcontainers instead of relying on a separately running instance of RabbitMQ.

I was trying to get the CircleCI tests to pass, but the problems there are more involved.
For a different PR...

I added Github Actions for linting and testing as a replacement for CircleCI, if that's alright.
It is just easier when using Testcontainers and it runs faster.

Thanks! I'm happy to accept the TestContainer changes, but I want to stick to CircleCI for now as I'm also using that in other projects and maintaining two build systems would be too much trouble.

Ok, I will try again to get it working in CircleCI.

What's the problem you run into with circleci? Maybe I can help

Done in https://github.com/zio/zio-amqp/pull/362
Please re-open if that is not the case


clean up initial conditions to ensure directive is applied on page load as well as resize

Currently, directive does not seem to apply in some cases on first page load.
Directive is loaded before the page has finished loading, so first call to onWindowResize fails to set size correctly.
Also no need for debounce on page load.

doesn't run on pageload in circumstances where element is created by ng-repeat.


Marking each test in a suite as a test on Sauce Labs

From @kandarp1691 on May 24, 2018 20:40
The problem
I have a suite of test which has 10 tests. Each suite starts with a describe() and each test starts with an it() as shown below:
describe('Suite of test', function(){
  it('Test 1', function(){

  }),

  it('Test 2', function(){

  }),

  it('Test 3', function(){

  })
})

Now in a case where Test 3 fails, sauce shows status failed with
Test Failed : Test 1
Is there any way to make sure that the failure message shows the correct message ?
Environment

WebdriverIO version: 4.12.0
Node.js version: 10.0.0
Standalone mode or wdio testrunner: wdio testrunner
if wdio testrunner, running synchronous or asynchronous tests: synchronous
Additional wdio packages used (if applicable):

Copied from original issue: webdriverio/webdriverio#2750

sauce shows status failed with

What do you mean by that? Screenshots? Do you use wdio-sauce-service?

From @kandarp1691 on May 25, 2018 15:27
￼￼￼

I am using wdio-sauce-service 0.4.8. Even though the first test case doesnt fail, it bubbles it up on the failure message.

Seems that the suite title is not quite correct. Could be a service issue or an adapter issue. PRs welcome!

Also, I had sauce labs come for training and tell us that each test was supposed to be run individually and not as a suite. I am unsure if thats the case or not.


JSON types: remove "_path must be first column" check

This commit removes the validation check that ensured that _path was
present as the first field of descriptors. This check is a reflection of our
zeek-onlyness back when this feature was first introduced. Now with the
impending arrival of Suricata and other data types, this hardcoded
check no longer belongs.
If we find ourselves needing such a validation, we can re-introduce
something more general once we have a few more ingest types under our
belt.

@mattnibs not unless I'm missing something: when ingesting pcap logs, we'll use a json type schema for suricata thta has no _path (the motivation for this PR), and the zeek logs will continue to go from zeek to zng without any json involved.


Add Wordpress button (btn-wordpress)

Also added composer.son file for packages.org

Just a nitpick, but WordPress should have the P capitalized. They are quite particular about it, so far as there is even a function to fix it: https://codex.wordpress.org/Function_Reference/capital_P_dangit

Corrected :)


[dv] Add options to improve VCS runtime

Add waves_off build options to supply options when waves is
disabled
Add 3 VCS options to improve runtime perf. Stats:
Test flash_ctrl_hw_rma runtime: 5hr -> 14min (95%+ improvement)
related to #10857
Test chip_sw_uart_tx_rx runtime: 489s -> 405s (17% improvement)

Signed-off-by: Weicai Yang<EMAIL_ADDRESS>

@cindychip we didn't run the entire regression with this update, but with this PR, our nightly may finish a few hours earlier.

Oh, also: you give some stats for the total change. Do you know which bits are from the 3 VCS options and which bits are from disabling waves? If disabling waves at buildtime is only a minor change, we could even drop that part entirely.

Oh, also: you give some stats for the total change. Do you know which bits are from the 3 VCS options and which bits are from disabling waves? If disabling waves at buildtime is only a minor change, we could even drop that part entirely.

all the stats are based on disabling waves.
these options (-assert dbgopt+novpi) will affect waves dump on assertion. Since we use debug_access+f, they will improve the performance.
Here are the details of these 2 options. I guess it's still good to have them as we have a lot of assertions in our blocks.

-assert dbgopt
Enables the assertion optimization in the presence of higher debug caps. This compile time option is useful in the presence of -debug_access option and helps in generating optimal code for runtime performance. All the optimizations that are not part of the full debug flow are enabled under this switch. When this option is used at compile time, success callback is disabled and only failures are dumped. This option improves performance when the design is compiled with -debug_access+f or CLI level greater than 2 or -debug_access+all. You can enable success dumping by giving the switch -assert dumpsuccess at runtime, which can potentially degrade runtime performance.
-assert novpi
Disables all vpi based callback access for assertions and dumping of assertion. This compile time option is useful in the presence of -debug_access option. It helps to reduce assertion debug overhead, when the design is compiled with higher debug capabilities.
Note: If a combination of -assert dbgopt+novpi is given, you can have the access to perform the following:
-Ability to iterate over all the assertions.
-Mark the assertions for dynamically enabling or disabling them
            This option sis not compatible with -cm assert option; the optimization will be disabled in the presence of -cm assert option.

Oh, also: you give some stats for the total change. Do you know which bits are from the 3 VCS options and which bits are from disabling waves? If disabling waves at buildtime is only a minor change, we could even drop that part entirely.

all the stats are based on disabling waves.
these options (-assert dbgopt+novpi) will affect waves dump on assertion. Since we use debug_access+f, they will improve the performance.
Here are the details of these 2 options. I guess it's still good to have them as we have a lot of assertions in our blocks.

-assert dbgopt
Enables the assertion optimization in the presence of higher debug caps. This compile time option is useful in the presence of -debug_access option and helps in generating optimal code for runtime performance. All the optimizations that are not part of the full debug flow are enabled under this switch. When this option is used at compile time, success callback is disabled and only failures are dumped. This option improves performance when the design is compiled with -debug_access+f or CLI level greater than 2 or -debug_access+all. You can enable success dumping by giving the switch -assert dumpsuccess at runtime, which can potentially degrade runtime performance.
-assert novpi
Disables all vpi based callback access for assertions and dumping of assertion. This compile time option is useful in the presence of -debug_access option. It helps to reduce assertion debug overhead, when the design is compiled with higher debug capabilities.
Note: If a combination of -assert dbgopt+novpi is given, you can have the access to perform the following:
-Ability to iterate over all the assertions.
-Mark the assertions for dynamically enabling or disabling them
            This option sis not compatible with -cm assert option; the optimization will be disabled in the presence of -cm assert option.

Could we just remove the debug_access+f so that this change is not required? There is a TODO on line 51 of vcs.hjson.

Could we just remove the debug_access+f so that this change is not required? There is a TODO on line 51 of vcs.hjson.

It's needed as we use uvm_hdl_*, unless we enable VCS Dynamic Performance Optimization which provides all the paths in a cfg file for VCS. But we don't want to do this right now, as there are extra works to set up the flow and maintain the cfg files
               // This option enables the following: (needed for uvm_hdl_*)
               //  - Read capability on registers, variables, and nets
               //  - Write (deposit) capability on registers and variables
               //  - Force capability on registers, variables, and nets
               // TODO Trim this flag since +f hurts performance.
               "-debug_access+f",

Could we just remove the debug_access+f so that this change is not required? There is a TODO on line 51 of vcs.hjson.

It's needed as we use uvm_hdl_*, unless we enable VCS Dynamic Performance Optimization which provides all the paths in a cfg file for VCS. But we don't want to do this right now, as there are extra works to set up the flow and maintain the cfg files
               // This option enables the following: (needed for uvm_hdl_*)
               //  - Read capability on registers, variables, and nets
               //  - Write (deposit) capability on registers and variables
               //  - Force capability on registers, variables, and nets
               // TODO Trim this flag since +f hurts performance.
               "-debug_access+f",

Aah right - i knew we kept it for something.

Ideally, simulators should run in fully optimized mode by default. As we increase observability for debug with our modes, simulators should provide the necessary switches so that we can dump all the information sought.
VCS instead works the other way around, by providing switches to enable optimizations, which need to be removed when we need to debug. We have provided feedback to Snps that this is inconvenient for us.
Though, from their point of view, they are adding experimental switches all the time that do various things, especially runtime optimizations that are not always enabled by default.  With that in mind, I propose the following instead:
Create a dvsim switch called --optimized and wire it up to build mode called optimized. We create this build mode for each tool, which would then add these optimization flags. We enable it when running regressions.

Actually, we don't need a dvsim switch - we could enable the optimized build mode for smoke and nightly regressions instead.

Not sure if this works for @rswarbrick
if we run smoke with no waves and then rerun it to dump waves without re-build, the waves will lose the the assertion dump.

If I understand Sri's suggestion, the "optimized" build would only be used if I did something like util/dvsim/dvsim.py path/to/my/sim_cfg.hjson -i smoke. That's fine with me! :-D

Since these options doesn't affect @rswarbrick's use case, let me get them in for all modes if -w is not used. WDYT? @sriyerg

Since these options doesn't affect @rswarbrick's use case, let me get them in for all modes if -w is not used. WDYT? @sriyerg

You mean make those opts 'permanent? Fine by me.

Since these options doesn't affect @rswarbrick's use case, let me get them in for all modes if -w is not used. WDYT? @sriyerg

You mean make those opts 'permanent? Fine by me.

our discuss is on the option -assert dbgopt+novpi. It will be enabled when -w isn't supplied.


Authorized Publish and View Model Binding From Message Payload

This repository seems to be the most actively developed of all forks, so i think there may be a few ways where the library can be improved more.
Describe the feature request
For the routes, i think it will be nice to have something like ASP.NET Core's [Authorize] attribute which client validation method can be specified, and some way to deserialize the json payload in a action parameter decorated with [FromPayload] automatically if Authorize is successful or not present
Describe the solution you'd like
in ASP.NET Core we can have
[Route("{someNumber:int}"]
public async Task<IActionResult> SomeAction(int someNumber, [FromForm] viewModel) {
  return Ok();
}

I think it's nice and streamlined way for the part to do stuff in a manner that is very similar to AspNet Core, so I'd imagine something like
[Authorize(Policy = "AuthorizedDevices")]
[MqttRoute("{someNumber:int}"]
public async Task SomeAction(int someNumber, [FromPayload] viewModel) {
  // do something
  await Ok();
  return;
}

FromPayload  is     good idea!

I'm looking to implement it. Not a very experienced C# programmer but will give it a try.

I have tried to implement FromPayload in this pull request https://github.com/IoTSharp/MQTTnet.AspNetCore.Routing/pull/5 . Would you mind to take a look at it?

lgtm .

Thanks a lot.
However, for the Authorize part, i don't see where it can fit without too many changes. Maybe for now will leave the Authorized part.
Will this changes be pushed to the NuGet package?

I test the related project and then push it to Nuget

Okay then, I think this issue can now be closed


upload video can not play

Hi, i uploaded videos, the videos can not play

Did it upload successfully if you check from the server side?
What format and size of the video file?

Issue should be fixed with 0.1.2


Move Provable (formerly Circuit) to JS

companion of https://github.com/o1-labs/snarkyjs/pull/889
this adds a new exported module snarky to the OCaml side of snarkyjs, which is much simpler and closer to the OCaml API than the previous circuit export. circuit is deleted, along with a few other unused parts of the bindings_lib.
the github PR view makes the changes hard to see -- I recommend reviewing the implementation of the new module here:
https://github.com/o1-labs/snarkyjs-bindings/blob/8b40c9a3eb82f9852e913da390284643f65d2bff/ocaml/lib/snarky_js_bindings_lib.ml#L1244-L1355

Should we generally try to (maybe not now, in a follow up PR) cleanup this massive snarky_js_bindings_lib.ml OCaml file into its own subsections, e.g. snarky.ml, pickles.ml, .. or would that be too annoying?


user guide: format Gitpod note in docs contrib guide (using Gitpod)

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

â Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
ð Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.
Please chose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. ð

This is a Gitpod test. Seems to work. This is @jorgeorpinel BTW

Except for those weird characters haha


Do a remapping of the code coverage using sourcemaps to support ES6

Again no source changes, just fixed the coveralls.io service to retrieve correct ES6 coverage data by using remap-istanbul in the build process.


Update uwuify.py

Fixed the new extras (mat is not allowed to deny this)

oops i misclicked and closed the issue my bad please don't reopen it :trollface:


Implement the homepage layout

This has been split out from https://github.com/AusDTO/dto-design-guide/issues/39
Work remaining:

[ ] hero design
[ ] FAQ section — chat with Jools re. this section
[ ] license & credit content — maybe move off the homepage?

Todos:

Chat to jools re. FAQ and licensing section
If we agree to move these out of the homepage, create separate tickets for them.


unstable NITE (OpenNI Compliant Middleware Binaries)

I want unstable NITE (OpenNI Compliant Middleware Binaries) . Kindly upload

hello
I want unstable NITE

The PrimeSense NITE binaries are not a component of OpenNI2.


ROOTFS_DIR always set on armel.

For arm, if ArmEnvironmentVariables is set, the ROOTFS_DIR won't explicitly be set by the build. However, on armel, this unconditionally happens. Instead the checks should check for ArmEnvironmentVairables, and if not set then decide to set for armel and arm
https://github.com/dotnet/source-build/blob/release/3.0/dir.props#L123

arm is not officially supported yet, but if you have changes for this, please submit a PR.

If you have changes.  If you want to submit a PR, feel free to reopen.


Carthage support is not documented in the "Getting started" view for macOS

Carthage support was added in https://github.com/microsoft/appcenter-sdk-apple/issues/1226, and it's documented in https://docs.microsoft.com/en-us/appcenter/sdk/getting-started/macos, but there's no mention of it in the AppCenter UI in https://appcenter.ms/users/<username>/apps/<AppName>/
It only mentions Cocoapods:

Thank you! We are improving our landing experience and will take this into consideration.

@blparr What is the current status of this issue? Nine months gone already, unfortunately there is no change. The landing page still shows only CocoaPods integration.

Hi @phranck and @sindresorhus
Currently getting started page for all applications on Portal contains a single option of integration (the most popular). All other options you can find in AppCenter Docs.
Do you feel it is still worth displaying all integration options on the application page?

I think it's useful to display all options, but if there can only be a single option there, I would definitely show SwiftPM.

Hi all! We appreciate your feedback. This helps us shape the product to better serve our mobile developers. For the time being, we want to take this idea into the yellow pad findings as this could potentially need an entire redesign of the landing page.
Currently, we support Cocoapods, Carthage, and SwiftPM integration for Swift and Objective-C. We want to provide the best landing experience without complicating tabs, yet with enough information. We didn't want to bombard with too much information for those who're completely new. However, we definitely heard you and want to come up with a better UX for all demographics. Thanks again for sharing your feedback with us!


LHN - Public room disappears from LHN after opening a thread and navigating away

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4481714
Issue reported by: Applause - Internal Team
Action Performed:

Log in to New Expensify
Navigate to a public room, e. g. https://staging.new.expensify.com/r/2652281908731856
Navigate to any other chat, note that the public room remains in LHN
Return to the public room
Open any thread
Navigate to any other chat

Expected Result:
Public room should remain in LHN
Actual Result:
Public room disappears from the LHN
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/8982f5ec-7649-4b94-8e73-b39f0dcfbfb3
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01be0cfb5ce7163400
Upwork Job ID:<PHONE_NUMBER>496879104
Last Price Increase: 2024-04-17

We think that this bug might be related to #vip-vsp

@muttmuure  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Still waiting for proposals

https://expensify.slack.com/archives/C066HJM2CAZ/p1714127987228399

Still waiting for internal proposals

waiting for proposals

bumped VSB room: https://expensify.slack.com/archives/C066HJM2CAZ/p1715086192645379

Making this low

Waiting for proposals

Waiting for proposals

Seems like this isn't important enough to pick up


Try local jobs first in wait_until_cold

If a worker thread has jobs in its own queue, then it's not really
headed for an inactive / sleepy state yet, so we can avoid modifying the
registry-wide sleep state.

bors r+


feat(core) added select

[ ] Simplify placeholder Prop. there should be only one and that prop should set the placeholder.
[ ] remove render choice limit for now
[ ] fuse options need to be gone entirely. basically, we want this simple behavior: search input is split by whitespace, then perform a case-insensitive contains search and combine results using AND
[ ] component needs to support a disabled input prob. methods for enable and disable should be removed
[ ] searchresultlimit should be set to some high value (e.g. 24) and Prop is removed
[ ] options that have the default value should be removed from the settings object

undefined shows as description in all selects


IOptionsSnapshot not reloading when configured with lambda

From @PaulTrampert on March 11, 2017 15:16
IOptionsSnapshot doesn't reload configuration when an associated config file changes if the strongly typed options were configured with IServiceCollection.Configure<T>((T cfgType) => { //section translation }).
To Reproduce
Configure a strongly typed configuration section using the lambda form of IServiceCollection.Configure<T>(). In my code, I had this in Startup.ConfigureServices
            services.Configure<WebpackHelperOptions>(opts =>
            {
                var webpackAssets = config.GetSection("webpackAssets");
                foreach (var section in webpackAssets.GetChildren())
                {
                    if (section.GetChildren().Any(c => c.Key == "js"))
                    {
                        opts.Scripts.Add(section.Key, section.GetSection("js").Value);
                    }
                }
            });
            services.Add(ServiceDescriptor.Scoped(typeof(WebpackHelper), typeof(WebpackHelper)));

Config class:
    public class WebpackHelperOptions
    {
        public IDictionary<string, string> Scripts { get; set; }
    }

Consuming class:
    public class WebpackHelper
    {
        private WebpackHelperOptions opts;
        private ILogger<WebpackHelper> logger;

        public WebpackHelper(IOptionsSnapshot<WebpackHelperOptions> opts, ILoggerFactory logFactory)
        {
            this.opts = opts.Value;
        }

        public string WebpackScript(string bundleKey)
        {
            return opts.Scripts[bundleKey];
        }
    }

Expected Behavior
When a config file changes, this lambda is re-evaluated and the correct config is passed to the consumer.
Actual Behavior
The lambda is not re-evaluated, and the old config is passed to the consumer.

I did. Here's the relevant part of Startup.cs:
private IConfiguration config;

public Startup(IHostingEnvironment env)
{
    var cfgBuilder = new ConfigurationBuilder();
    config = cfgBuilder
        .SetBasePath(env.ContentRootPath)
        .AddJsonFile("webpack.assets.json", optional: false, reloadOnChange: true)
        .Build();
}

Also, may be relevant:
When I configure with services.Configure<WebpackHelperOptions>(config.GetSection("webpackAssets"));, it works as expected. So I've got a workaround, but I would expect the lambda version of the configuration to work the same.

Oh, yeah this is expected behavior, since something needs to actually wire up the thing that listens to the config reload and triggers the options reload, that logic needs the configuration object:
https://github.com/aspnet/Options/blob/dev/src/Microsoft.Extensions.Options.ConfigurationExtensions/OptionsConfigurationServiceCollectionExtensions.cs#L35
You can probably just manually add that yourself if you aren't calling the Configure(IConfiguration)overload

Ah ok. Thanks for the info! In that case I guess this can probably be closed then.


Fix bug where tests groups can be deleted without deleting associated test group results

Motivation and Context

When test specs are updated for the autotester, previous test groups are deleted but the associated test group results are not because of a delete_all call which doesn't trigger callbacks.
This causes additional problems when test groups are deleted but the test scripts themselves fail to update. For example, if a test group is deleted and there is a schema error, any subsequent tests that are run will have results associated with a non-existent test group. The test results will fail to save but the test run will have completed so there will be an empty test run with no results (in the instructor/TA view) and an error raised (in the student view) because of an error (comparing a nil value to a timestamp when finding the latest test results to display).
In order to fix this, I moved the code that updates the test groups into a transaction with the call to update the scripts on the autotester. If one fails, now the other is not committed/run. I also changed the delete_all call to a destroy_all call but since it is now running in a background job it shouldn't cause a problematic delay.
This means that if the test settings are changed after a test is run, previous test group results associated with now deleted test groups will be deleted as well. I believe this was the original intention of the code. Please note:

tests results will no longer be displayed to instructors or students (since they have been deleted)
marks that were created by running a test whose result has now been deleted will not be removed.
this occurs whether the results have already been released to the student or not

Because of this... Although this probably was how the code was supposed to be, the current behaviour is not ideal. We should either:

not delete test group results when the associated test group is deleted (not ideal because we don't keep a record of old test groups so old test group results look out of date and may cause confusion if they don't match the test settings)
not delete old test groups when updating the test settings and instead mark them as active/inactive and show test results that are associated with an inactive test group differently in the test runs table.
warn before deleting test groups if tests have already been run and don't allow deleting test groups if marks have been released (like we do with criteria)

DO THIS ONE:

[x] warn before updating settings if test runs exist and then keep the old test groups. Don't differentiate between active/inactive test groups unless necessary.

Your Changes

Description:
Type of change (select all that apply):

[x] Bug fix (non-breaking change which fixes an issue)

Testing

Questions and Comments (if applicable)

See description
Checklist

[x] I have performed a self-review of my own code.
[x] I have verified that the pre-commit.ci checks have passed.
[x] I have verified that the CI tests have passed.
[x] I have reviewed the test coverage changes reported on Coveralls.
[x] I have added tests for my changes.
[x] I have updated the Changelog.md file.

Pull request to make documentation changes (if applicable)

@david-yz-liu thanks for catching that. I've added a fix in https://github.com/MarkUsProject/Markus/pull/6337


pre-check should also include the expected answer in the same place

currently, it only shows the model output but not the expected answer (from qna.yaml)

Duplicate of #220 Fixed by #269


Error response from daemon: Cannot restart container weather411: permission denied

Problem Description
Hello! New to docker and trying to install Powerwall-Dashboard. I've gotten to running the setup.sh command but it keeps giving an error (Error response from daemon: Cannot restart container weather411: permission denied) when I go through the setup.
System Details
Describe the host system you are trying to use for the Dashboard: Desktop

Hardware I think a Pentium and 4GB of RAM
OS Version Ubuntu 22.04.02
Other Specifics

Verify Tool Output
Checking pypowerwall

Config File pypowerwall.env: GOOD
Container (pypowerwall): GOOD
Service (port 8675): ERROR: Not Listening
Version: Unknown
Powerwall State: ERROR: Not Connected - Firmware Version: Unknown

Checking telegraf

Config File telegraf.conf: GOOD
Local Config File telegraf.local: GOOD
Container (telegraf): GOOD
Version: Telegraf 1.26.0 (git: HEAD@064650c8)

Checking influxdb

Config File pypowerwall.env: GOOD
Container (influxdb): GOOD
Service (port 8086): GOOD
Version: InfluxDB shell version: 1.8.10

Checking grafana

Config File grafana.env: GOOD
Container (grafana): GOOD
Service (port 9000): ERROR: Not Listening - Logs:

Error: ✗ Get "https://grafana.com/api/plugins/repo/grafana-piechart-panel": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Error: ✗ Get "https://grafana.com/api/plugins/repo/grafana-piechart-panel": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Error: ✗ Get "https://grafana.com/api/plugins/repo/grafana-piechart-panel": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Error: ✗ Get "https://grafana.com/api/plugins/repo/grafana-piechart-panel": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Error: ✗ Get "https://grafana.com/api/plugins/repo/grafana-piechart-panel": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Error: ✗ Get "https://grafana.com/api/plugins/repo/grafana-piechart-panel": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Error: ✗ Get "https://grafana.com/api/plugins/repo/grafana-piechart-panel": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Error: ✗ Get "https://grafana.com/api/plugins/repo/grafana-piechart-panel": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Error: ✗ Get "https://grafana.com/api/plugins/repo/grafana-piechart-panel": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Error: ✗ Get "https://grafana.com/api/plugins/repo/grafana-piechart-panel": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
Error: ✗ Get "https://grafana.com/api/plugins/repo/grafana-piechart-panel": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Version: Grafana CLI version 9.1.2

Checking weather411

Config File weather/weather411.conf: GOOD
Container (weather411): GOOD
Service (port 8676): GOOD
Weather: {"temperature": null}
Version: 0.2.1

Error: ✗ Get "https://grafana.com/api/plugins/repo/grafana-piechart-panel": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

This seems to indicate a routing problem with your linux host, or something in the docker setup that is not allowing it to open traffic to the public internet or even to your local network.  Do you have a firewall or have you set up iptables on your host?  This would explain the errors in Grafana and the reason that pypowerwall is not listening (it can't reach your Powerwall).
Can you run a few command from your host to help troubleshoot?
# pypowerwall - verify tool shows that it is running but not listening
docker logs pypowerwall

# install pypowerwall and run a scan to see if connectivity works
pip install pypowerwall
python -m pypowerwall scan

# grafana - check to see if you can access public internet
curl -is https://grafana.com/api/plugins/repo/grafana-piechart-panel | head -12

# weather411 - check logs then manually try to restart to see if you get same permission error
docker logs weather411
docker stop weather411
docker start weather411

Nope, no firewall or iptables.
Here's the logs from "docker logs pypowerwall"
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 703, in urlopen
httplib_response = self._make_request(
File "/usr/local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 386, in _make_request
self._validate_conn(conn)
File "/usr/local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 1042, in _validate_conn
conn.connect()
File "/usr/local/lib/python3.10/site-packages/urllib3/connection.py", line 363, in connect
self.sock = conn = self._new_conn()
File "/usr/local/lib/python3.10/site-packages/urllib3/connection.py", line 179, in _new_conn
raise ConnectTimeoutError(
urllib3.exceptions.ConnectTimeoutError: (<urllib3.connection.HTTPSConnection object at 0x7f7e857e4ca0>, 'Connection to <IP_ADDRESS> timed out. (connect timeout=10)')
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/requests/adapters.py", line 489, in send
resp = conn.urlopen(
File "/usr/local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 787, in urlopen
retries = retries.increment(
File "/usr/local/lib/python3.10/site-packages/urllib3/util/retry.py", line 592, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='<IP_ADDRESS>', port=443): Max retries exceeded with url: /api/login/Basic (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x7f7e857e4ca0>, 'Connection to <IP_ADDRESS> timed out. (connect timeout=10)'))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/pypowerwall/init.py", line 146, in _get_session
r = self.session.post(url,data = pload, verify=False, timeout=self.timeout)
File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 635, in post
return self.request("POST", url, data=data, json=json, **kwargs)
File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 587, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 701, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python3.10/site-packages/requests/adapters.py", line 553, in send
raise ConnectTimeout(e, request=request)
requests.exceptions.ConnectTimeout: HTTPSConnectionPool(host='<IP_ADDRESS>', port=443): Max retries exceeded with url: /api/login/Basic (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x7f7e857e4ca0>, 'Connection to <IP_ADDRESS> timed out. (connect timeout=10)'))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/app/server.py", line 107, in
pw = pypowerwall.Powerwall(host,password,email,timezone,cache_expire,timeout,pool_maxsize)
File "/usr/local/lib/python3.10/site-packages/pypowerwall/init.py", line 138, in init
self._get_session()
File "/usr/local/lib/python3.10/site-packages/pypowerwall/init.py", line 151, in _get_session
raise ConnectionError(err)
pypowerwall.ConnectionError: Unable to connect to Powerwall at https://<IP_ADDRESS>
03/19/2023 12:10:19 AM [proxy] [INFO] pyPowerwall [0.6.1] Proxy Server [t24] - HTTP Port 8675
03/19/2023 12:10:19 AM [proxy] [INFO] pyPowerwall Proxy Started
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/urllib3/connection.py", line 174, in _new_conn
conn = connection.create_connection(
File "/usr/local/lib/python3.10/site-packages/urllib3/util/connection.py", line 95, in create_connection
raise err
File "/usr/local/lib/python3.10/site-packages/urllib3/util/connection.py", line 85, in create_connection
sock.connect(sa)
TimeoutError: timed out
When I tried to run the install command it responded with this,
Command 'pip' not found, but can be installed with:
apt install python3-pip
Please ask your administrator.
(I tried to install it with sudo before the command as well, but it returned a different error)
Python command resulted in this
Command 'python' not found, did you mean:
command 'python3' from deb python3
command 'python' from deb python-is-python3
However, grafanna resulted in a positive connection.
When running the commands for weather411, I got the following output:
Error response from daemon: cannot stop container: weather411: permission denied
Sorry, I'm sure there are a lot of beginner-level mistakes in all of this - I'm really new to all of this. Thanks so much for trying to help!

urllib3.exceptions.ConnectTimeoutError

This means that pypowerwall is not able to connect to your Powerwall.  A few things to try
# Ping your Powerwall from the Ubuntu system - change the IP to the address of the Powerwall
ping 10.0.1.x

# Install python
sudo apt install python3
sudo apt install python3-pip
sudo pip install pypowerwall
python -m pypowerwall scan

Error response from daemon: cannot stop container: weather411

I wonder if you have docker permission on your user account. You can try this:
# Add your user to docker group
sudo usermod -aG docker $USER

# reboot or log out and log back in
exit

The biggest issue I see is the connectivity (pypowerwall not seeing the Powerwall) which of course does cause problems with other containers also needing connectivity.


Track planets and starbases

From Fortress in the Pardus Forum:

I have one suggestion for the script, make it possible to add planets or SBs to the Bookkeeper. Possibly in its own table so that it doesn't interfere with the commodities of the buildings???

From AC:

is there anyway I can track f/w on a starbase with bookie?
I would love to have a projection mode on just the f/w/e stocks in bases.
so that I know when I have to upkeep bases
and maybe have a message window that pops up if the projection indicates < 2 ticks of f/w left
Yeah, or better yet, if I could select what I want to track on the base. So suppose on some bases I want f/w/e + droids + bots and on others I want f/w/e + HW + BWP

Implemented (mostly) by 73725e20afbf4494ee3f5e71c588a60c581477ac


Electron update

This PR updates Electron to v1.8.2 and builds with Node v8.2.1.
@krystophv Anything else that we need to change? Do you know what we should be testing here?

This seems to hit all the things I think are necessary for the version update. Testing might come down to "smoke test a bit of everything", as nothing should change, but everything could have. I'm wondering if it'd be worth it to take the opportunity to do some other dependency updates at the same time since testing is likely to be similar? Maybe a couple quality of life improvements like limiting Rollbar to production builds?

@krystophv Yep, totally agree. I'm thinking we could tackle both https://trello.com/c/LLQU6QaX/29-new-card-uploader-dependency-updates and https://trello.com/c/144Btqt7/344-uploader-improve-rollbar-logging as part of this.

@krystophv OK, this one is ready for a second round of code review.

The second and third round of updates that @krystophv made LGTM :ship:

 NEW CARD: Uploader Dependency Updates

Note: @BecCooney found an issue where Verio and Verio Flex uploads would fail on El Capitan. Turns out the description field was missing, where we check if it contains LifeScan Media. This is a bug in the drivelist module that was fixed in the most recent version only 5 days ago (https://github.com/resin-io-modules/drivelist/blame/143ebbe84a6c1e534d689836d1cfb1d7cae328ff/lib/diskutil.js#L110) so I bumped the version number to the latest version.


CMock SPI driver (IDFGH-10749)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v4.4.5
Operating System used.
Windows
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
CMD
What is the expected behavior?
I want to use the SPI mock driver provided by ESP-IDF to test one of my components that uses the SPI. For that, I added it in the "CMakeLists.txt" of my project.
What is the actual behavior?
Unfortunately, during compilation it seems that some dependencies are missing.
In file included from D:/Espressif/frameworks/esp-idf-v4.4.5/components/spi_flash/include/esp_flash_internal.h:19,
                 from D:/Espressif/frameworks/esp-idf-v4.4.5/components/spi_flash/esp_flash_api.c:24:
D:/Espressif/frameworks/esp-idf-v4.4.5/components/driver/include/driver/spi_common_internal.h:15:10: fatal error: esp_pm.h: No such file or directory
 #include "esp_pm.h"
          ^~~~~~~~~~
compilation terminated.
[115/1339] Building C object esp-idf/spi_flash/CMakeFiles/__idf_spi_flash.dir/esp_flash_spi_init.c.obj

Steps to reproduce.

Create a new project/example
Add "list(APPEND EXTRA_COMPONENT_DIRS "$ENV{IDF_PATH}/tools/mocks/driver")" in the project "CMakeLists.txt"
Run "idf.py build"

Build or installation Logs.
No response
More Information.
Here is my project "CMakeLists.txt"
# This is the project CMakeLists.txt file for the test subproject
cmake_minimum_required(VERSION 3.5)

set(EXTRA_COMPONENT_DIRS "../components/schedule"
                        "../components/log"
                        "../components/nvs"
)

list(APPEND EXTRA_COMPONENT_DIRS "../mocks/nvs") # My mock OK
list(APPEND EXTRA_COMPONENT_DIRS "$ENV{IDF_PATH}/tools/mocks/driver") # ESP-IDF Mock NOK

set(TEST_COMPONENTS "schedule" CACHE STRING "List of components to test")

include($ENV{IDF_PATH}/tools/cmake/project.cmake)
project(test)

@Steven35700 Please note that CMock only works on Linux. This means you need to change the target to "linux":
idf.py --preview set-target linux

This needs to be done before idf.py build is called.
Furthermore, it is necessary to set the COMPONENTS to main in the CMakeLists.txt file. This is to avoid drawing in incompatible components when building for Linux.
Your CMakeLists.txt file should look like this:
# This is the project CMakeLists.txt file for the test subproject
cmake_minimum_required(VERSION 3.5)

include($ENV{IDF_PATH}/tools/cmake/project.cmake)
set(COMPONENTS main)

set(EXTRA_COMPONENT_DIRS "../components/schedule"
                        "../components/log"
                        "../components/nvs"
)

list(APPEND EXTRA_COMPONENT_DIRS "../mocks/nvs") # My mock OK
list(APPEND EXTRA_COMPONENT_DIRS "$ENV{IDF_PATH}/tools/mocks/driver") # ESP-IDF Mock NOK

set(TEST_COMPONENTS "schedule" CACHE STRING "List of components to test")

project(test)

If you want to run unity unit tests as in IDF, you need to enable CONFIG_UNITY_ENABLE_IDF_TEST_RUNNER in menuconfig, too.

@Steven35700 Happy to hear it works! Yes, I forgot to mention that the Linux target works much more seamlessly since IDF v5.0.


linuxPackages.splLegacyCrypto: fix build

Motivation for this change
linuxPackages.splLegacyCrypto didn't build. Add missing patch (same as splUnstable).
Please backport to 18.03.
/cc @Mic92
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

18.03:
[detached HEAD e695a743370] splLegacyCrypto: fix build
Author: xeji<EMAIL_ADDRESS>Date: Sat Apr 14 18:48:19 2018 +0200
1 file changed, 1 insertion(+)


missing 1st letter of DATA in REQUESTED FILES (URLS) on error page

On the localhost:7880/error page the 1st letter of the data within the REQUESTED FILES (URLS) panel are missing.

Same here. Attached screenshot - redacted

This has been corrected in xavierh/goaccess-for-nginxproxymanager:develop. It should be in the latest tag within the week. Actually, it wasn't even showing the correct information.

Fixed in v1.1.25


Add further description to VM settings

Extended list of VM settings if you run into the problem of booting into a black screen when starting the VM. I had this issue with your original tutorial and found some settings that might be helpful for others as well to prevent those problems :-)
Thanks a lot for your work!

With the numbering changes, it's hard to see what's different in GitHub's UI... what are the main differences in this PR?

Thanks for your fast response!
I reverted the number changes and chose a format that makes differences clearer. Main differences is the check list with VM settings to prevent VirtualBox not booting the ISO image. Found those settings here http://webcache.googleusercontent.com/search?q=cache:-HetrOnSp5sJ:appledigg.com/t/install-mac-os-x-el-capitan-yosemite-in-virtualbox-in-mac-os-x-tutorial/147+&cd=1&hl=en&ct=clnk&gl=de (non-cached page is no longer available as it seems...).

@geerlingguy @michaellihs is this PR still valid or should it be closed?

@geerlingguy @michaellihs is this PR still valid or should it be closed?

Yeah I think it can be closed for now.


<EMAIL_ADDRESS>might be incompatible with Storybook 7

See Storybook #20529
Attention: We've detected that you're using the following addons in versions which are known to be incompatible with Storybook 7:

-<EMAIL_ADDRESS>
Please be aware they might not work in Storybook 7. Reach out to their maintainers for updates and check the following Github issue for more information:
https://github.com/storybookjs/storybook/issues/20529

Hey @justintemps 👋
Storybook contributor here. While addon-postcss is deprecated, we plan to continue PostCSS through @storybook/addon-styling


Upgrade pytest-codspeed to 1.2.0

This will fix the benchmark results variability seen in #330 and #336.
It will probably create some regression since the core calling logic has been changed but this kind of refactoring affecting the results should be the last since the internal structure is now more modular.

Thanks so much.


Added support in WIX to install chef-client as a scheduled task.

Issue ref: https://github.com/chef/chef/issues/4042
In-progress.
Signed-off-by: aliasgar16<EMAIL_ADDRESS>

@btm I will make the required changes.

@btm I have made the required changes.

@btm @mwrock I supposed to test these new changes with newly built MSI (which @btm will supply me). So, I think this should not be merged until I test the changes.


Add Twig profiler

This adds the Twig collector so we can see the views.

Related: #48

Nice! Thanks

Saw an error about a missing widget
Uncaught TypeError: PhpDebugBar.Widgets.TemplatesWidget is not a constructor

Suspect this is because the beforeDisplay event does not fire during the route that compiles the necessary JS. So, instead,  in 741c7d34a474f85d6d77188a9925aa402e9e7d2d the collector is always registered for frontend routes and we only link up the profiler during the event. The App::runningInBackend() method can tell us if the route is front-end or back-end.
Seems to work fine now

Thanks!