[link-quality] explicitly clear link quality for new child/router

The child/router entries are generally cleared using memset() to avoid
explicitly setting all fields to zero.  As a result, it is necessary to
explicitly clear the link quality state to properly initialize the last
RSSI reading.  The user-specific constructors are also removed.

@abtink, good point.  Updated this PR to explicitly call mCcaSuccessRateTracker.Reset().


Initial implementation

Provides the implementation of HTTP streaming to allow port-forwarding
from firewalled server to the Platform.
The implementation is based on Kubernetes project source code, specifically k8s.io/apimachinery/pkg/util/httpstream package.
Main changes are:

support for port forwarding in reverse direction
all k8s apimachinery and dependencies removed
no klog logging - the logging is delegated to client of this package

Q: Instead of copying all this code in an own package (which leads to maintaining it), can't we import the code from the k8s project itself instead? If not, LGTM (small remark only about makefile)

Surely was thinking about it. But there are few problems:

I had to adjust k8s implementation a bit to support forwarding in reverse direction. There was no option to handle new HTTP stream on server side.
k8s impl has many references to other k8s staff, like apimachinery API, meta API package and other. That does not make sense to have as a dependency for migration service.
k8s impl uses klog which will result in two types of logging output by the services who use portforward-helper.


Replace int with SupportsIndex in indexing methods hints

Resolves https://github.com/data-apis/array-api/issues/383

Thanks @honno.
Adding a quick clarifying example:
>>> import numpy as np
>>> import torch
>>>
>>> x = np.arange(1, 4)
>>> y = torch.arange(1, 4)
>>>
>>> class Ix:
...     def __index__(self):
...         return 1
...
>>> x[Ix()]
2
>>> y[Ix()]
tensor(2)

@honno would you be able to open a PR with a test for this to array-api-tests? Doesn't have to be merged before this will be merged, but that will help smoke out if any known/tested library does not yet support this feature.

@honno would you be able to open a PR with a test for this to array-api-tests? Doesn't have to be merged before this will be merged, but that will help smoke out if any known/tested library does not yet support this feature.

Good shout, I opened https://github.com/data-apis/array-api-tests/pull/247 to check this all out. From the looks of it:

NumPy (+ array_api_strict), PyTorch
JAX doesn't support, has a general note to open a feature requests on indexing modes (... that's prob refering to advance integer indexing).
cupy seems to support advance integer indexing, but doesn't play nice with 0-D integer arrays as indexes.arrays used as indices must be of integer (or boolean) type
Dask at least accepts 0-D integer input, but array_api_compat.dask not playing nice with the test suite so I'll have to triage that and explore further.

but array_api_compat.dask not playing nice with the test suite so I'll have to triage that and explore further.

Let me know what you find out. We do run it on CI with some skips and xfails, and also the max-examples is set to 5. I haven't looked at the Dask xfails too closely, and obviously if we can remove any of those that would be great. CC @lithomas1

@honno Were you able to triage the Dask issues with the test suite?

By the way, for implementers, the generally correct behavior is to operator.index() to normalize index objects that aren't one of the other supported index types like Ellipsis, slice, or array. My guess is that dask.array isn't doing that.

@honno Is there anything more that we need to do with this PR?

@honno Is there anything more that we need to do with this PR?

PR I think I'm happy with, just be mindful that last I checked in March it was only NumPy and PyTorch that supported "indexables", whereas JAX/CuPy/Dask didn't, so they'd need updating to support this.
Example of what I mean by an indexable:
class AwkwardIndexable:
    def __init__(self, value: int):
        self._value = value

    def __int__(self):
        raise TypeError("__int__() should not be called")

    def __index__(self):
        return self._value
``


Development

Mostly refactoring to conform to galois-field and not many new features. Will update dependencies and versions once galois-field is stable.

This is ready to be reviewed.


modify fees to be able monthly prorated amounts

I do not see any issues, so I am merging it. Thank you @terapyon


pytest-flakes doesn't respect PEP 263 encoding markers

I noticed pytest-flakes doesn't respect PEP 263 encoding markers.
This means with a non-UTF8 aware locale (e.g. LC_ALL=C) or with an OS which doesn't use UTF-8 by default (e.g. latin1 on Windows), files containing UTF-8 won't be checkable:
$ LC_ALL=C ./venv/bin/py.test --flakes snowman.py -rs
[...]
platform linux -- Python 3.4.3 -- py-1.4.27 -- pytest-2.7.1
[...]
venv/lib/python3.4/site-packages/pytest_flakes.py:75: in runtest
    found_errors, out = check_file(self.fspath, self.flakesignore)
venv/lib/python3.4/site-packages/pytest_flakes.py:124: in check_file
    codeString = path.read()
venv/lib/python3.4/site-packages/py/_path/common.py:133: in read
    return f.read()
venv/lib/python3.4/encodings/ascii.py:26: in decode
    return codecs.ascii_decode(input, self.errors)[0]
E   UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 29: ordinal not in range(128)

snowman.py:
# encoding=utf-8

snowman = "☃"

A normal flake8 snowman.py works fine.
This breaks pytest's tests with tox >= 2.0.0 as it isolates environment variables by default.
A possible fix would be to use tokenize.open:
--- pytest_flakes.py.ori	2015-05-22 07:46:50.005433885 +0200
+++ pytest_flakes.py	2015-05-22 07:47:35.018767377 +0200
@@ -4,6 +4,7 @@
 import py
 import pytest
 import sys
+import tokenize

 def assignment_monkeypatched_init(self, name, source):
@@ -121,7 +122,8 @@

 def check_file(path, flakesignore):
-    codeString = path.read()
+    with tokenize.open(str(path)) as f:
+        codeString = f.read()
     filename = py.builtin._totext(path)
     errors = []
     try:

That seems to fix it for Python 3 - but I haven't tested Python 2 yet. Maybe it's enough to just use normal reading there, or maybe tokenize.open has to be backported, like coverage.py did.

Can you check the PR I made?

Fix released with 1.0.0.


[vcpkg_find_acquire_program(NINJA).cmake] Update to 1.11.1

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

I was getting some build discrepancies between my CI builds, which use this ninja, and my dev builds, which use the ninja that comes with Visual Studio which uses version 1.11.1.
I might not have the time to progress this from the draft stage if many ports need fixes, but we'll see.

Implements https://github.com/microsoft/vcpkg/pull/34433#issuecomment-1762032317.

It looks like the CI succeeded so I imagine this should be fine.
Note: I came across additional discrepancies between my CI and Dev so this change may not be necessary to fix errors, but here all the same.

Please fix the conflict and CI error.

Please get failure logs here. Please ping me if you need any help.

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

Please get failure logs here. Please ping me if you need any help.

x64_android

Building<EMAIL_ADDRESS>-- Fetching https://git.code.sf.net/p/tinyfiledialogs/code master...
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: /usr/bin/git fetch https://git.code.sf.net/p/tinyfiledialogs/code master -n
    Working Directory: /vcpkg/downloads/git-tmp
    Error code: 128
    See logs for more information:
      /mnt/vcpkg-ci/b/tinyfiledialogs/git-fetch-x64-android-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_from_git.cmake:86 (vcpkg_execute_required_process)
  ports/tinyfiledialogs/portfile.cmake:3 (vcpkg_from_git)
  scripts/ports.cmake:170 (include)

error: building tinyfiledialogs:x64-android failed with: BUILD_FAILED
Elapsed time to handle tinyfiledialogs:x64-android: 174 ms

arm64_android

Building<EMAIL_ADDRESS>-- Fetching https://git.code.sf.net/p/tinyfiledialogs/code master...
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: /usr/bin/git fetch https://git.code.sf.net/p/tinyfiledialogs/code master -n
    Working Directory: /vcpkg/downloads/git-tmp
    Error code: 128
    See logs for more information:
      /mnt/vcpkg-ci/b/tinyfiledialogs/git-fetch-arm64-android-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_from_git.cmake:86 (vcpkg_execute_required_process)
  ports/tinyfiledialogs/portfile.cmake:3 (vcpkg_from_git)
  scripts/ports.cmake:170 (include)

error: building tinyfiledialogs:arm64-android failed with: BUILD_FAILED
Elapsed time to handle tinyfiledialogs:arm64-android: 196 ms

@Adela0814 These look like intermittent network failures to me, is there a way to re-run just those jobs?

/azp run

It looks like the failures are due to Windows build machine timeouts.

/azp run

1.12.0 seems to be more attractive:
https://github.com/ninja-build/ninja/releases/v1.12.0
https://github.com/microsoft/vcpkg/issues/38494

1.12.0 seems to be more attractive: https://github.com/ninja-build/ninja/releases/v1.12.0 #38494

#38538

Hi there, thanks for the update. I'm closing this in favor of the other PR which updates to 1.12. (Which I also have to resurrect :) )


Error with yarn encore dev

Hi,
Can anybody help me with this error:
Running webpack ...
ERROR  Failed to compile with 1 errors                                                                   12:47:54 PM
error  in ./vendor/bitbag/cms-plugin/src/Resources/assets/admin/js/index.js
Module parse failed: Unexpected token (7:68)
File was processed with these loaders:

./node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
| }
|

if (document.querySelectorAll('[data-bb-target="cms-slug-update"]')?.length > 0) {
|   new HandleSlugUpdate().init();
| }

@ ./vendor/bitbag/cms-plugin/src/Resources/assets/admin/entry.js 1:0-14
DONE  Compiled successfully in 2135ms                                                                    12:47:54 PM
I  2 files written to public/build/bitbag/cms/shop
ERROR  Failed to compile with 1 errors                                                                   12:47:56 PM
error  in ./vendor/bitbag/cms-plugin/src/Resources/assets/admin/js/index.js
Module parse failed: Unexpected token (7:68)
File was processed with these loaders:

./node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
| }
|

if (document.querySelectorAll('[data-bb-target="cms-slug-update"]')?.length > 0) {
|   new HandleSlugUpdate().init();
| }

@ ./vendor/bitbag/cms-plugin/src/Resources/assets/admin/entry.js 1:0-14
ERROR  Failed to compile with 1 errors                                                                   12:47:57 PM
error  in ./vendor/bitbag/cms-plugin/src/Resources/assets/admin/js/index.js
Module parse failed: Unexpected token (7:68)
File was processed with these loaders:

./node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
| }
|

if (document.querySelectorAll('[data-bb-target="cms-slug-update"]')?.length > 0) {
|   new HandleSlugUpdate().init();
| }

@ ./vendor/bitbag/cms-plugin/src/Resources/assets/admin/entry.js 1:0-14
@ ./assets/admin/entry.js
When I start the server I also have this error 500 - An exception has been thrown during the rendering of a template ("Asset manifest file "/home/sylius/MyFirstShop/public/build/manifest.json" does not exist. Did you forget to build the assets with npm or yarn?").

Same problem here !

Same here. I fixed it by removing the .babelrc file.

Hello, you need to upgrade symfony/webpack-encore in package.json to version: "@symfony/webpack-encore": "^1.7.0"
The second problem related to the missing manifest is due to your webpack configuration.

Should be fixed in newest releases. If not, please reopen with info about used version.


Update signatures to pull from chrome extension instead of github

Since the wappalyzer github repo is now closed-source, this PR pulls the signatures from the chrome extension instead. 😉

Thanks for this contribution @TheTechromancer !
Closes #69

Perhaps it would be better to upload the JSON files to a new ProjectDiscovery's GitHub repo and allow the community to maintain them (and pull the files from that repository instead of from the Chrome extension). Wdyt?

Perhaps it would be better to upload the JSON files to a new ProjectDiscovery's GitHub repo and allow the community to maintain them (and pull the files from that repository instead of from the Chrome extension). Wdyt?

Not a bad idea. But you'd need a way to reconcile the changes between the community fork and the "upstream" closed-source version. According to the author, 90% of the signature contributions were made by himself (I'm not sure this is true), but at any rate we wouldn't want to fork the signatures and miss out on new updates from the original author.

Yes, but I'm now thinking that there might be legal issues regarding extracting files from a Chrome extension, given that the solution has become closed-source, or no? 🤔. That's why it might be better to start from the last available version of the JSON files, create a repository, and give the community the chance to maintain it (as it was before). Project Discovery has a lot of support from the community (at least for Nuclei); I'd give it a try if they agree 🙏

Agreed that ProjectDiscovery is in a good position to take this over. The chrome extension is public information so personally I don't see an issue, but I'm not a lawyer. I also doubt that legal issues will prevent future wappalyzer clones from periodically pulling from the official repo ;)
Either way, this code will tide us over until a good alternative emerges. It's been three months since the signatures were updated, so it's much needed.
@olearycrew what are your thoughts

@ehsandeep is working on a longer-term strategy for how we update our technology detection - and we've also recently added hybrid detection using templates: https://github.com/projectdiscovery/nuclei/pull/4656
I don't think we should make derivative works of any ongoing development from wappalyzer itself as it is now closed source

@TheTechromancer thank you for the PR, with change pushed in https://github.com/projectdiscovery/wappalyzergo/pull/74, wappalyzergo now using Lissy93/wapalyzer as source of information and not making any manual updates.


docs(samples): Fix code style for line more than 120 character and add explanation for setting up environment variable

There's several files that contains code with more than 120 characters
within single row. I think it will be more easier to read if we separate
those long lines into multiple lines. Also I add how to export a PROJECT_ID
since it will be easier to do so if one's opening the google shell.
Fixes #issue

It's a good idea to open an issue first for discussion.

[x] I have followed Sample Format Guide
[x] pom.xml parent set to latest shared-configuration
[x] Appropriate changes to README are included in PR
[x] API's need to be enabled to test (tell us)
[ ] Environment Variables need to be set (ask us to set them)
[x] Tests pass (mvn -P lint clean verify)

(Note- Checkstyle passing is required; Spotbugs, ErrorProne, PMD, etc. ERROR's are advisory only)

[ ] Please merge this PR for me once it is approved.

I'll keep this open for someone on the Firestore team to comment.  I think your changes are making the sample a bit less friendly.  In the future it might be better to open an issue to discuss what you want to do.

@BenWhitehead owns firestore

@BenWhitehead PTAL

Thank you for the interest in contributing to the Firestore code snippets.
However, this PR unfortunately does not include changes that benefit the display of the code snippets on https://cloud.google.com/firestore/docs or https://firebase.google.com/docs/firestore .


Create LICENSE

This pull request is part of an initiative to make the licensing information about OBO Foundry ontologies more actionable.
While this ontology contains licensing information in its metadata, GitHub is not aware of the license unless you create a LICENSE file with standardized text. This PR creates a LICENSE file with the standard text for the CC BY 4.0 license.
More information about this initiative and further discussion is taking place here: https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1840.

Hi Charles,
I am not exactly sure what needs to be done. Could you help clarify a bit?
Thanks!
Jingshan
From: Charles Tapley Hoyt @.>
Sent: 2023年3月20日 18:18
To: OmniSearch/ncro @.>
Cc: Jingshan Huang @.>; Mention <
@.>
Subject: Re: [OmniSearch/ncro] Create LICENSE (PR #39)
@Huang-OMIT https://github.com/Huang-OMIT can you please take a look at
this?
—
Reply to this email directly, view it on GitHub
https://github.com/OmniSearch/ncro/pull/39#issuecomment-1477076390, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AC67EAEQ3KE5T4VQRMQAWEDW5DQSTANCNFSM5TYFMIHA
.
You are receiving this because you were mentioned.Message ID: <
@.***>

Hi Charles,
Sorry to bug you again. Where is the link/button to accept or merge the
pull request? Thanks a lot!
Jingshan
From: Charles Tapley Hoyt @.***
Sent: Tuesday, March 21, 2023 3:46 AM
To: OmniSearch/ncro @.>
Cc: Jingshan Huang @.>; Mention <
@.***>
Subject: Re: [OmniSearch/ncro] Create LICENSE (PR #39)
All you have to do is accept/merge this PR - it corresponds to the license
already annotated for this ontology.
—
Reply to this email directly, view it on GitHub
https://github.com/OmniSearch/ncro/pull/39#issuecomment-1477456515, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AC67EAGSUKUNBJSO3Q7NLQ3W5FTFTANCNFSM5TYFMIHA
.
You are receiving this because you were mentioned.[image: Image removed by
sender.]Message ID: @.***>

@cthoyt Thanks a lot! The issue was taken care of just now.


pull request for e2e test at 11/14/2016 18:26:11

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


PrimitiveObjectFormatter eagerly reads integer where double could be preferred.

A bug in PrimitiveObjectFormatter which is used when deserializing
object was eagerly reading doubles as integers. This was flagged in
failing yaml test reproduce:

./build.sh rest-spec-tests xpack -f analytics -t t_test.yml -s "heteroscedastic t-test"

Scrollbars now also collapse when running the yaml tests now that
ShellProgressbar properly scrolls children into view this got to be a
tad excessive

1 failing test not related:
[xUnit.net 00:14:30.6164584]     Tests.Ingest.PutPipeline.PutPipelineApiTests.ReturnsExpectedIsValid [FAIL]
[2020-04-21T20:07:29,326][INFO ][o.e.x.s.a.r.TransportPutRoleAction] [xpack-node-7bea8e9200] added role [role-nest-initializer-96b8dc0e]
[2020-04-21T20:07:29,356][INFO ][o.e.x.s.a.r.TransportPutRoleAction] [xpack-node-7bea8e9200] added role [role-ois-baae57e0-role]
  X Tests.Ingest.PutPipeline.PutPipelineApiTests.ReturnsExpectedResponse [7s 187ms]
  Error Message:
   Tests.Framework.EndpointTests.ResponseAssertionException : Expected response.Acknowledged to be true, but found False.
Response Under Test:
Invalid NEST response built from a unsuccessful (400) low level call on PUT: /_ingest/pipeline/pipeline-1?pretty=true&error_trace=true
# Audit trail of this API call:
 - [1] BadResponse: Node: https://localhost:9200/ Took: 00:00:01.2789750
# OriginalException: Elasticsearch.Net.ElasticsearchClientException: Request failed to execute. Call: Status code 400 from: PUT /_ingest/pipeline/pipeline-1?pretty=true&error_trace=true. ServerError: Type: parse_exception Reason: "processor [csv] doesn't support one or more provided configuration parameters [empty_value]"
# Request:
{"description":"My test pipeline","processors":[{"append":{"field":"state","value":["Stable","VeryActive"]}},{"csv":{"field":"name","target_fields":["targetField1","targetField2"],"trim":true,"empty_value":"empty"}},{"convert":{"field":"numberOfCommits","target_field":"targetField","type":"string"}},{"date":{"field":"startedOn","formats":["dd/MM/yyyy hh:mm:ss"],"target_field":"timestamp","timezone":"Europe/Amsterdam"}},{"enrich":{"field":"name","policy_name":"enrich_processor_policy","target_field":"target_field"}},{"fail":{"message":"an error message"}},{"foreach":{"field":"tags","processor":{"uppercase":{"field":"_value.name"}}}},{"grok":{"field":"description","pattern_definitions":{"FAVORITE_DOG":"border collie","RGB":"RED|BLUE|GREEN"},"patterns":["my %{FAVORITE_DOG:dog} is colored %{RGB:color}"]}},{"gsub":{"field":"name","pattern":"-","replacement":"_"}},{"join":{"field":"branches","separator":","}},{"lowercase":{"field":"name"}},{"remove":{"field":["suggest"]}},{"rename":{"field":"leadDeveloper","target_field":"projectLead"}},{"set":{"field":"name","value":"foo"}},{"split":{"field":"description","separator":"."}},{"trim":{"field":"name"}},{"uppercase":{"field":"name"}},{"dot_expander":{"field":"field.withDots"}},{"script":{"source":"ctx.numberOfCommits++"}},{"urldecode":{"field":"description","ignore_missing":true}},{"attachment":{"field":"description","ignore_missing":true,"indexed_chars":100000,"properties":["title","author"]}},{"circle":{"field":"description","target_field":"arbitraryShape","ignore_missing":true,"error_distance":10.0,"shape_type":"shape"}},{"bytes":{"field":"description","ignore_missing":true}},{"dissect":{"field":"description","pattern":"%{clientip} %{ident} %{auth} [%{@timestamp}] \"%{verb} %{request} HTTP/%{httpversion}\" %{status} %{size}","ignore_missing":true,"append_separator":" "}},{"drop":{"if":"true"}},{"kv":{"field":"description","field_split":"_","ignore_missing":true,"value_split":" "}},{"kv":{"field":"description","field_split":"_","ignore_missing":true,"strip_brackets":true,"trim_key":"xyz","trim_value":"abc","value_split":" "}},{"set_security_user":{"field":"name"}},{"pipeline":{"name":"x"}}]}
# Response:
{
  "error" : {
    "root_cause" : [
      {
        "type" : "parse_exception",
        "reason" : "processor [csv] doesn't support one or more provided configuration parameters [empty_value]",
        "processor_type" : "csv",
        "stack_trace" : "org.elasticsearch.ElasticsearchParseException: processor [csv] doesn't support one or more provided configuration parameters [empty_value]\r\n\tat .... "
  },
  "status" : 400
}


Add solution for leetcode #146

Pull Request Template
Description
This PR adds solution for leetcode #146 in Javascript.
Make sure all below guidelines are followed else PR will get Reject:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code so that it is easy to understand
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

@lokendra1704 updated.

Readme is not formatted correctly @ongzx

@GouravRusiya30 possible to tag it with hacktoberfest-accepted?


Cached and disk zone files renamed

Renaming files:
ZoneFile instead of ZoneFileDns
ZoneFileCache instead of ZoneFile
Signed-off-by: Diana Teplits<EMAIL_ADDRESS>Release note:
NONE

/lgtm
/approve

/release-note-none


add hidden input for netlify forms

Fixed with solution here https://community.netlify.com/t/netlify-forms-invalid-html-of-the-hidden-input-element/1573
Caused by invalid markup on netlify's side when adding the form.


Output latency with Jack backend doesn't seem to work

see #293

The change in #293  works around timestamp.playback.duration_since(&timestamp.callback) returning None.
Checking https://docs.rs/cpal/latest/cpal/struct.StreamInstant.html this can only happen when callback is later than playback (docs: https://docs.rs/cpal/latest/cpal/struct.OutputStreamTimestamp.html ).  Which is indeed puzzling and requires some further investigation of cpal+jack

The playback timestamp is not update and remains behind the callback timestamp on the second invocation:
[2023-06-19T11:10:26Z INFO  web_audio_api::io::cpal] Output device: Ok("cpal_client_out")
[2023-06-19T11:10:26Z DEBUG web_audio_api::io::cpal] Attempt output stream with prefered config: StreamConfig { channels: 2, sample_rate: SampleRate(48000), buffer_size: Fixed(1024) }
[2023-06-19T11:10:26Z DEBUG web_audio_api::io::cpal] Determining output latency for callback OutputCallbackInfo { timestamp: OutputStreamTimestamp { callback: StreamInstant { secs: 5929, nanos: 915391332 }, playback: StreamInstant { secs: 5929, nanos: 936641333 } } }
[2023-06-19T11:10:26Z DEBUG web_audio_api::io::cpal] Output stream set up successfully
stereo
[2023-06-19T11:10:27Z DEBUG web_audio_api::io::cpal] Determining output latency for callback OutputCallbackInfo { timestamp: OutputStreamTimestamp { callback: StreamInstant { secs: 5930, nanos: 455891332 }, playback: StreamInstant { secs: 5929, nanos: 936641333 } } }
thread '<unnamed>' panicked at 'assertion failed: timestamp.callback <= timestamp.playback', src/io/cpal.rs:429:5

Probably best to report it to cpal then.
There's similar (but different) shenanigans happening for ALSA timestamps: https://github.com/RustAudio/cpal/issues/710


Settings: widgets

I was thinking that maybe it would be nice if we could add widget settings to the settings app, instead of having separate "apps" just to configure a widget?
Something like

A widget can set WIDGETS["mywidget"].settings to a function to handle settings
The settings app gets a new submenu "Widgets", containing (only) all widgets that have a settings property
Ideally widgets also set name, which is used as menu entry

If not set, fall back to the WIDGETS key? So it would just show as "mywidget"
Or should .settings contain both a name and a callback?
Maybe we could get the name from apps.json? Seems like not all widgets use their  id as WIDGETS key though

So you'd have something like this:
  function settings(back) {
    const mySettingsMenu = {
        '': { 'title': 'My Widget' },
        'Sound': {
            value: false,
            onchange: s => {s ? Bangle.beep() : false} // TODO: save new value
        },
        '< Back': back // provided by caller (settings app)
    };
    E.showMenu(mySettingsMenu)
  }
  WIDGETS["mywidget"]={
    /* other properties go here */
    name:"My widget",
    settings:settings,
  };

That sounds like a good idea. Maybe this could be more general though?
For instance if there was an app.settings.json it could be shown and loaded up. It's not just widgets that could benefit from this.
In terms of implementation there's appname.info that's auto-generated by the app loader, so we could add an entry in there if a settings file exists on upload.

That does seem a better solution, I'll give implementing something like that a try.

Nice - thanks! For detecting settings and setting the relevant bit in the app.info, just copy/paste this:
https://github.com/espruino/BangleApps/blob/master/js/appinfo.js#L61,L62
Then finding a list of apps with settings would look a lot like:
var apps = s.list(/\.info$/).map(app=>s.readJSON(app,1)).filter(app=>app&&app.settings);


Precondition to web components

Towards "Make web components" #261:
Web Components rely on class syntax, and Babel transpilation gets in the way. We can turn it off, like in the this PR, but we'll lose some support for older browsers... Or we could put any Web Component work we do in a separate repo, or in some other way kept away from Babel.

How likely are our users to be using older browsers?
How important is it that this be in a single repo?

Thinking about it

Losing backwards compatibility is never a good thing
Keeping web components in a separate project is actually a good thing: Web component users really don't want to be bothered with everything else we might export, and a separate project can get its own developer demo page.

Closing.


USB C Speed 2.0

the usb type C not have the correct speed.
I don't have this laptop, but I follow and help a Spanish community in Telegram.
It is possible that you try to fix with https://www.tonymacx86.com/threads/guide-creating-a-custom-ssdt-for-usbinjectall-kext.211311/ and https://www.tonymacx86.com/threads/guide-usb-power-property-injection-for-sierra-and-later.222266/
Thank your for your all work

@johnnync13 If you are using my release, you will have full speed type C.

The Spanish community will be super grateful. I do not have money to buy this laptop but if I have knowledge about hackintosh, I have tried to contribute as much as possible, thanks to people who use beta-testers.


Bonus guide: Mempool

What
This is a proposal to add a bonus guide to install Mempool.
Why
It is a popular Bitcoin blockchain explorer and mempool visualizer and can be used as an alternative or complement to the BTC RPC Explorer which is installed in the main guide.
Fixes #840 and #651
How

Bonus guide at /bonus/+bitcoin/mempool.md

Updated /bonus/+bitcoin/index.md to add a reference to the Mempool guide (under 'Privacy', would another heading be more suitable?)

The guide requires in-depth review, in particular the nginx configuration section. See Issue #840 for a list of on-going questions and things to review/sort out.

Scope

[ ] significant change to core configuration
[x] independent bonus guide
[ ] simple bug fix

Fixes #840 and #651
Test & maintenance
Test:

Follow the guide and run Mempool in your browser
Check nginx config, is it secure?

Maintenance: Checking breaking changes at each Mempool update. Update of the 'Upgrade' section.
Maintenance:
Animated GIF (optional)

Made some minor recommendations

Thanks for the recommendations! I ammended accordingly, PTAL. Also, see replies above, I have a couple of questions.

@Stadicus: the Mempool guide is now ready for final review after a very helpful review and improvement suggestions by @RooSoft.
The whole guide needs to be reviewed and will benefit from your suggestions, but I think the nginx config section needs particular/extra attention as I'm not entirely sure it's optimally configured as it is now.

Great work. I'll try to finish the SCB/GitHub backup pr first and then will give this guide a go.

This guide works well except this:

/etc/nginx/snippets/nginx-mempool.conf
allow <IP_ADDRESS>/16;
deny all;

Having problems on language change to EN (Forbidden 403) and logo of mempool not loading.
In official mempool installation guide this not mentioned. So I think best option is delete this from guide.

This guide works well except this:

/etc/nginx/snippets/nginx-mempool.conf
allow <IP_ADDRESS>/16;
deny all;

Having problems on language change to EN (Forbidden 403) and logo of mempool not loading. In official mempool installation guide this not mentioned. So I think best option is delete this from guide.

Well spotted, thanks! that was something I added as a test and forgot to remove later when I realised it was not needed. I've now removed that entire section. PTAL.

Also tested this guide with mempool v2.3.1. All works well.

Great to know. I've updated the guide to v2.3.1(basically git checkout v2.3.1 instead of git checkout v2.2) but didn't test it.

Let4s go to master! :)


Configure explicit Java module descriptors

Use the ModiTect plugin to add module descriptors while retaining Java 8 compatibility.
Fix for #358
NOTE: The release must be run with Java9+ or else it will fail to generate module descriptors. The CI workflow runs tests with 8, 11, and 17 which is fine as long as the package phase is not invoked.

$ jarviz bytecode show --file core/target/failsafe-3.3.1-SNAPSHOT.jar
subject: failsafe-3.3.1-SNAPSHOT.jar
Unversioned classes. Bytecode version: 52 (Java 8) total: 114
Versioned classes 9. Bytecode version: 53 (Java 9) total: 1

$ jarviz module descriptor --file core/target/failsafe-3.3.1-SNAPSHOT.jar
subject: failsafe-3.3.1-SNAPSHOT.jar
name: dev.failsafe.core
version: 3.3.1-SNAPSHOT
open: false
automatic: false
exports:
  dev.failsafe
  dev.failsafe.event
  dev.failsafe.function
  dev.failsafe.internal
  dev.failsafe.internal.util
  dev.failsafe.spi
requires:
  java.base mandated

$ jarviz module descriptor --file modules/okhttp/target/failsafe-okhttp-3.3.1-SNAPSHOT.jar
subject: failsafe-okhttp-3.3.1-SNAPSHOT.jar
name: dev.failsafe.okhttp
version: 3.3.1-SNAPSHOT
open: false
automatic: false
exports:
  dev.failsafe.okhttp
requires:
  dev.failsafe.core
  java.base mandated
  okhttp3

$ jarviz module descriptor --file modules/retrofit/target/failsafe-retrofit-3.3.1-SNAPSHOT.jar
subject: failsafe-retrofit-3.3.1-SNAPSHOT.jar
name: dev.failsafe.retrofit
version: 3.3.1-SNAPSHOT
open: false
automatic: false
exports:
  dev.failsafe.retrofit
requires:
  dev.failsafe.core
  java.base mandated
  retrofit2

Thanks for this @aalmiray. Just to confirm, binary backwards compatibility with 1.8 runtimes should still be fine since we're targeting 1.8, it's just that the tooling needed to generate the module descriptors requires 9+?

Thanks for this @aalmiray. My only comment (above) is wanting to ensure that we don't break 1.8 compatibility.

Understood. This is how classes would look like once packaged:
$ jarviz bytecode show --file core/target/failsafe-3.3.1-SNAPSHOT.jar
subject: failsafe-3.3.1-SNAPSHOT.jar
Unversioned classes. Bytecode version: 52 (Java 8) total: 114
Versioned classes 9. Bytecode version: 53 (Java 9) total: 1

The build was run with Java 11. The single class with bytecode 53 is module-info.class which is placed in the versioned space:
$ unzip -l core/target/failsafe-3.3.1-SNAPSHOT.jar
Archive:  core/target/failsafe-3.3.1-SNAPSHOT.jar
  Length      Date    Time    Name
---------  ---------- -----   ----
     1359  03-16-2023 08:07   META-INF/MANIFEST.MF
        0  03-16-2023 08:07   META-INF/
        0  03-16-2023 08:07   dev/
        0  03-16-2023 08:07   dev/failsafe/
        0  03-16-2023 08:07   dev/failsafe/internal/
        0  03-16-2023 08:07   dev/failsafe/internal/util/
        0  03-16-2023 08:07   dev/failsafe/function/
        0  03-16-2023 08:07   dev/failsafe/spi/
        0  03-16-2023 08:07   dev/failsafe/event/
        0  03-16-2023 08:07   META-INF/maven/
        0  03-16-2023 08:07   META-INF/maven/dev.failsafe/
        0  03-16-2023 08:07   META-INF/maven/dev.failsafe/failsafe/
     1511  03-16-2023 08:07   dev/failsafe/RateLimiterConfig.class
...
     1845  03-16-2023 08:07   dev/failsafe/Failsafe.class
     1371  03-16-2023 08:07   dev/failsafe/FailurePolicyConfig.class
        0  03-16-2023 08:07   META-INF/versions/
        0  03-16-2023 08:07   META-INF/versions/9/
      319  03-16-2023 08:07   META-INF/versions/9/module-info.class

I don't know enough about Maven pom files to give an authoritative answer, but here's the line I had to change in my ivy.xml file (for the StreamEx library):
    <dependency org="one.util" name="streamex" rev="0.8.1"/>

This stopped working until I changed it to:
    <dependency org="one.util" name="streamex" rev="0.8.1">
      <!-- Distributed as multi-release-jar; ask for jar explicitly -->
      <artifact name="streamex" type="jar" />
    </dependency>

You could reasonably say that it's not such a big deal, but it took me a long time to figure this out, and until I did, I was shut out of updating to the latest release of StreamEx.
I am reasonably confident that a similar transformation would work if Failsafe goes this route, but I don't know for sure. There are probably others who, for various reasons, are stuck on Java 8 and who don't directly use Maven but depend on its ecosystem.

It looks like streamex-0.8.0 explicitly changed its packaging go "multirelease-jar" https://central.sonatype.com/artifact/one.util/streamex/0.8.0
Version 0.8.1 went back to default "jar" packaging.
This was a conscious decision of the author to modify the companion metadata (pom.xml) and has nothing to do with the actual JAR contents.
ModiTect does not alter in any way the chosen packaging, rest assured the fix you had to put in place for streamex was explicit for that version alone.

Fingers crossed.

This was released in Failsafe 3.3.1.

Thank you for merging and releasing 😁


Add support for more selectors

Hello! As part of my work on Happybara, I've implemented a CSS selector parser and a converter from CSS to XPath:
https://github.com/cstrahan/happybara/blob/to-query/happybara/src/Happybara/XPath.hs#L40
https://github.com/cstrahan/happybara/blob/to-query/happybara/src/Happybara/CSS.hs
If you're interested, I'd like to fold my implementation into HandsomeSoup.
If you wouldn't mind taking a dependency on hxt-xpath, I think we should be able to use my css-to-xpath conversion directly, using getXPathTreesInDoc.
Thoughts?

Hmm, did anything happen with this? Sorry it took me so long to get to, and I don't see any changes anymore.

@egonSchiele No worries; I got caught up in other things. I'd still like to take a stab at this, but it will probably be a couple weeks before I can dive back in.

It's fine...I have a lot of other stuff on my plate right now anyway :)


Node 20 Dependencies Concern with Homebridge

I do apologize in advance if I misunderstood the situation. I'm on Pi4 with Rasp OS Lite 64bit, apt installed the homebridge.
Current newest release Blocks update-node from updating to version 20 on versions of Linux that don't support it.
https://github.com/homebridge/homebridge-config-ui-x/releases/tag/4.51.1
Anything to concern about this deCONZ plugin is now requiring node ^20?
There is an open issue with people getting stuck with node ^20: https://github.com/homebridge/homebridge/issues/3453 and it seems like related to node 20 above. A few revert the node back to 18 work around.

deCONZ plugin is now requiring node ^20?

It’s not.  https://github.com/ebaauw/homebridge-deconz/blob/ac70edbb7ad4a26c86de18a12a902ceeb97295db/package.json#L27
Note that I develop and test my plugins against the latest LTS release of NodeJS.  I issue a warning on startup when you’re using another version; the plugin might or might not run on this other version; I simply don’t have the time to test this.


Bump version in Project.toml

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 72.684%

Totals

Change from base Build<PHONE_NUMBER>:
1.0%

Covered Lines:
306

Relevant Lines:
421

💛  - Coveralls


Game crashes if you switch worlds too fast

If you leave one world and join another straight away the game will freeze, not respond and force you to quit the game and reopen it.

This is most likely caused by one of your mods being incompatible with the "Allow multiple running Worlds" option.
Please send a list of your mods so I can figure out the incompatibility, in the meantime you can set "Allow multiple running Worlds" to OFF.

https://www.mediafire.com/file/o93gx3btxqpw08w/mods.rar/file Apoligise for the delay

Okay I'm fairly sure this is an incompatibility between Fast Backups and the "Allow multiple running Worlds" option, could you confirm a couple things for me?

The issue also happens with only FastQuit, Fast Backups and their necessary dependencies installed.
The issue does not happen with FastQuits "Allow multiple running Worlds" option turned off.
If this fixes the issue i will add Fast Backups to the list of mods that automatically disable this option in the next release.

Testing with a fresh instance of 1.21 Fabric 0.16.7
Mods:
Cloth Config V15 15.0.140
Fabric API 0.102.0+ 1.21
Fast Back 0.19.0+1.21-fabric
FastQuit 3.0.0+1.20.6

Can confirm the game still stops responding and forces you to close when loading a new world whilst another is saving. (This
was repeated 3 times to make sure)

The issue is fixed with the "Allow multiple running worlds"  option is toggled off.

And to make sure i removed FastBackup and renabled "Allow Multiple running worlds" and the issue does not occur.

Thank you for testing, will be fixed in the next release, for now just disable "Allow multiple running worlds"


feat: run dependencies even when no route matches

Currently the following test fails:
def test_app_dependency_no_route_match() -> None:
    log: List[str] = []

    async def dep() -> None:
        log.append("called")

    app = App(routes=[], dependencies=[Depends(dep)])

    client = TestClient(app=app)

    resp = client.get("/")
    assert resp.status_code == 404, resp.content
    assert log == ["called"]

The reason for this is that the dependency DAG is not executed until a route is found.
The same applies to FastAPI.
This is a bit confusing, and prevents implementing logging, tracing, etc. as a dependency (usually you'd want to log 404s).
I think it should be possible to change this: we'd run each App's and Rotuer's dependencies as the request traverses through them.
It'd be roughly the same as what we are doing in Operation:
https://github.com/adriangb/xpresso/blob/bf71495c8050af574810bd13b926cb8050ea8a59/xpresso/routing/operation.py#L50-L58
Ideally this change would mean that anything you do with ASGI middleware you can do with dependencies (there's still a good reason to support both: there is generic ASGI middleware but not generic Xpresso dependencies).
The main con is that I expect this to have a relatively large impact on performance and make the implementation a lot messier.
These are two very good arguments for not supporting this usage.

I'm thinking what might work is for Router and Path to build their own dependency graph (all of the dependencies of the routing nodes traversed to get to them). Then if Router doesn't match any routes it can run its own dependency graph, if Path doesn't match any methods (i.e. if it returns a PartialMatch and then handle gets called) it can run its dependency graph and otherwise Operations dependency graph will be called.

So after a bit of testing, it looks like https://github.com/adriangb/xpresso/issues/66#issuecomment-1079967427 will work if we want it to, but there is a big con: we need to dive into the routing and HTTP method matching, which are currently things that Starlette just handles, and provides no real hooks into. So this would mean a lot more code in Xpresso 😞


1360620 rajidocenhancement

Please review

Docs Build status updates of commit 2a11261:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/deep-links.md
:warning:Warning
View
Details

msteams-platform/concepts/build-and-test/deep-links.md

Line 14, Column 1: [Warning-invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to <blockquote>

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 4e8cf50:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/deep-links.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 60bae9b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/deep-links.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


WIP: tslint migration guide

@jonaskello I got this started but I'm not really sure what to put in it. Do you want to take over writing it?

I think you have done a very good job on getting this started! IMO this is good enough for 1.0.0 and we can add more as we get issues with questions about migrations.


Office.context.mailbox.item.SaveAsync throws an error in Onsend Addin if Send Later option is used on OWA

Article URL

Issue

Hi Everyone,
I am facing issue in our OnSend office addin in OWA. When we use send later option in OWA there is an error in the office. js for Office.context.mailbox.item.SaveAync Method. The error states " Connection error occurred while trying to save the item on the serve".  If send later option is not used then SaveAync works fine. Anyone has faced this issue before?
Please let me know your views or recommendations.


⚠ Bofrost.be has degraded performance

In d21b938, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 910 ms

Resolved: Bofrost.be performance has improved in 5403715 after 7 hours, 38 minutes.


Unknown Cmake Command "add_compile_definitions"

I think this issue is with using the Latest CMake commands.
My Configuration is :
OS - Linux LTS 18.04
Cmake version -  3.10.2
Just a suggestion : can we configure the CI to use some older CMake version (3.8, for example) so these issues get caught early enough?

Upgrading to CMake 3.15 works. I think , the  minimum version of CMake required to build should be mentioned in the README


Get total value of a bundle

Calculate the total value of the bundle base on the original pricing of the bundled products.

You can now get total value of a bundle using $bundle->totalvalue().
NOTE: you must include the brackets totalvalue(), otherwise Laravel will think that it's a relationship model and will prompt an error.


Hide unsupported media types

Hello,
There is any way to hide all unsupported media types?
If my mimeSet, contains only Gif, I want the user to see only the gif files instead of all the photos,
Thanks in advance

hi there is:
            val mimeTypes = mutableSetOf<MimeType>()
            mimeTypes.addAll(MimeType.ofImage())
            mimeTypes.addAll(MimeType.ofVideo())

It's still shows me all files (but disabled..)

...
.showSingleMediaType(true)
.forResult(PICK_IMAGE_REQUEST);


Negative Decimal pad

A button to make the number negative or positive would be nice.

You can use NumbersAndPunctuation in the meantime.


[Feature] Neon Glowing Sign up form

Description
I will add a new Neon Glowing Sign up form.
I will create it using HTML and CSS.
Kindly assign this to me under IWOC2024
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Rakesh9100
I had completed this work also kindly assign this to me so that I open PR for this.

@Rakesh9100
Done sir.

@Rakesh9100
Sir kindly check my all previous tasks are completed and PR is also merged.
Kindly assign this issue to me.

Go ahead @Prince-kushwaha-2004


Add data-get/prow+netlify.org

@devaii these docs will help with ensuring the data generated for PRs and for Merges into master is in sync with the Netlify configuration in netlify.yaml.

@hh: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [hh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 2115d663b7229ae58623a27f196d8954e6bf85a4

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: devaii, hh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [devaii,hh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Additional AD properties

Description
Add additional AD properties and pre-defined searches
Motivation and Context
This PR addresses: BP-792
Enables more to find more non-path security issues.
Should be merged and included in a release simultaneously or after this SharpHound change: https://github.com/BloodHoundAD/SharpHoundCommon/pull/150
How Has This Been Tested?
Locally.
Screenshots (optional):

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

[x] I have met the contributing prerequisites

Assigned myself to this PR
Added the appropriate labels
Associated an issue: https://github.com/SpecterOps/BloodHound/issues/672
Read the Contributing guide: https://github.com/SpecterOps/BloodHound/wiki/Contributing

[x] I have ensured that related documentation is up-to-date

Open API docs
Code comments (GoDocs / JSDocs)

[x] I have followed proper test practices

Added/updated tests to cover my changes
All new and existing tests passed

Hello @JonasBK  thanks for improvements, I'm curious as to which SharpHound version/release will we have to use to benefit from : https://github.com/BloodHoundAD/SharpHoundCommon/pull/150 since this looks like a library for SharpHound, I'm not sure if the v4 is used at the moment for the latest release of SharpHound.

Hello @JonasBK thanks for improvements, I'm curious as to which SharpHound version/release will we have to use to benefit from : BloodHoundAD/SharpHoundCommon#150 since this looks like a library for SharpHound, I'm not sure if the v4 is used at the moment for the latest release of SharpHound.
I see that the latest release is v4.0.4 beta from 2 weeks ago, I take it that this additional AD properties will come in the next release that will be made for the library but for upstream (SharpHound collector), we're still using v3 which is stable.

This should be included, not in our next release, but the one following of BloodHound / SharpHound, tentatively scheduled for the week of September 9th.


Fix typos in CONTRIBUTING.md

I found this through mastodon and found the typos jarring.

Thanks!
You're also welcome to note typos you found at https://github.com/crate-ci/typos/issues/1051 for everyone (using that tool) to benefit


Unable to set default user

I'm pretty new to linux and wsl in general. I did successfully install ArchWSL with the method 1 installation method from this repo few weeks ago. I was running into some problems so I decided to reinstall it again from scratch but somehow I keep getting stuck on this step.

I made sure the path environment variables are set in the wsl as well

The /usr/bin/id command also runs fine from the root.

Any suggestion ?

I did some searching and found a closed issue in the microsoft/wsl repo and followed the instructions. It fixed it.
Turns out it was a path environment issue for wsl in general.


Only change the state if current and target states differ

This PR fixes #6 and adds prettier and lint-staged to the project.

Most relevant commit is https://github.com/jptaranto/homebridge-roon-outputs/pull/7/commits/7694b8dc0a6b590c6108ce205584aa1f0ad2deb2

Thanks @okonet, bit late to the game I know! No idea why I didn't see this earlier, but I am alive.

Could you cut a release? I'm still using my local version afaik :)

Will do yeah, just gotta test it locally.


Connect plugin - Update Instructions

Some parts (like that mentioning Fabric8) are outdated.

I updated the instructions.
https://github.com/hawtio/hawtio-jmx/commit/4ec6d9c97e7f6cacc8e16045d0fb5bc7f295ddce


checking "Re-using existing connection" does not include proxy port

By using this gem in our project. Revealed is a problem if you use multiple proxies, differing only in the port - it uses the previous proxy. Example:
First request:
irb(main):008:0> Typhoeus::Request.new("https://api.ipify.org?format=json", proxy: "http://xxx.xxx.xxx.xx:1025").run.body
Rebuilt URL to: https://api.ipify.org/?format=json
Connection 4 seems to be dead!
Closing connection 4
TLSv1.2 (OUT), TLS alert, Client hello (1):
  Trying xxx.xxx.xxx.xx...
Connected to xxx.xxx.xxx.xx (xxx.xxx.xxx.xx) port 1025 (#5)
Establish HTTP proxy tunnel to api.ipify.org:443
CONNECT api.ipify.org:443 HTTP/1.1
Host: api.ipify.org:443
Proxy-Connection: Keep-Alive

HTTP/1.0 200 Connection established

Proxy replied OK to CONNECT request
ALPN, offering http/1.1
Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
successfully set certificate verify locations:
  CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs
TLSv1.2 (OUT), TLS header, Certificate Status (22):
TLSv1.2 (OUT), TLS handshake, Client hello (1):
...
 SSL connection using TLSv1.2 / ECDHE-RSA-AES128-GCM-SHA256
ALPN, server accepted to use http/1.1
Server certificate:
	 subject: OU=Domain Control Validated; OU=EssentialSSL; CN=api.ipify.org
	 start date: Oct 22 00:00:00 2015 GMT
	 expire date: Nov 20 23:59:59 2016 GMT
	 subjectAltName: api.ipify.org matched
	 issuer: C=GB; ST=Greater Manchester; L=Salford; O=COMODO CA Limited; CN=COMODO RSA Domain Validation Secure Server CA
	 SSL certificate verify ok.
�GET /?format=json HTTP/1.1
Host: api.ipify.org
Accept: */*
User-Agent: Typhoeus - https://github.com/typhoeus/typhoeus

�HTTP/1.1 200 OK
Server: Cowboy
Connection: keep-alive
Content-Type: application/json
Date: Tue, 02 Aug 2016 12:29:39 GMT
Content-Length: 23
Via: 1.1 vegur

Connection #5 to host xxx.xxx.xxx.xx left intact
ETHON: performed EASY effective_url=https://api.ipify.org/?format=json response_code=200 return_code=ok total_time=1.280609
=> "{\"ip\":\"<IP_ADDRESS>\"}"

Second request:
irb(main):009:0> Typhoeus::Request.new("https://api.ipify.org?format=json", proxy: "http://xxx.xxx.xxx.xx:1026").run.body
Rebuilt URL to: https://api.ipify.org/?format=json
Found bundle for host api.ipify.org: 0x6a72050 [can pipeline]
Re-using existing connection! (#5) with proxy xxx.xxx.xxx.xx
Connected to xxx.xxx.xxx.xx (xxx.xxx.xxx.xx) port 1025 (#5)
�GET /?format=json HTTP/1.1
Host: api.ipify.org
Accept: */*
User-Agent: Typhoeus - https://github.com/typhoeus/typhoeus

�HTTP/1.1 200 OK
Server: Cowboy
Connection: keep-alive
Content-Type: application/json
Date: Tue, 02 Aug 2016 12:29:45 GMT
Content-Length: 23
Via: 1.1 vegur

Connection #5 to host xxx.xxx.xxx.xx left intact
ETHON: performed EASY effective_url=https://api.ipify.org/?format=json response_code=200 return_code=ok total_time=0.220008
=> "{\"ip\":\"<IP_ADDRESS>\"}"

if I add forbid_reuse: true, then it opens a new connection for each request. However, this method is slower.

typhoeus version 1.1.0


ERRINFO_INVALID_INPUT_PDU_MOUSE and exit on middle mouse button click

Describe the bug
When connected to any client, if I use the middle mouse button, the program forcibly disconnects from the remote host.
[10:43:01:915] [8258:8259] [INFO][com.freerdp.core] - ERRINFO_INVALID_INPUT_PDU_MOUSE (0x000010D0):(a) A Slow-Path Mouse Event (section <IP_ADDRESS>.<IP_ADDRESS>.3) or Extended Mouse Event (section <IP_ADDRESS>.<IP_ADDRESS>.4) has been received with an invalid pointerFlags field.
(b) A Fast-Path Mouse Event (section <IP_ADDRESS>.2.2.3) or Fast-Path Extended Mouse Event (section <IP_ADDRESS>.2.2.4) has been received with an invalid pointerFlags field.
[10:43:01:917] [8258:8259] [ERROR][com.freerdp.core.transport] - BIO_read returned a system error 104: Connection reset by peer
[10:43:01:917] [8258:8259] [ERROR][com.freerdp.core] - freerdp_check_fds() failed - 0
[10:43:01:917] [8258:8259] [ERROR][com.freerdp.client.x11] - Failed to check FreeRDP file descriptor

I can live without it, but it would be nice to have a work-around that doesn't close the connection.
To Reproduce
Steps to reproduce the behavior:

open a connection from linux to a local windows VM.
click the middle mouse button

Expected behavior
Either nothing should happen, or the middle mouse button should be passed through to the remote host.
** Application details

Version of FreeRDP
This is FreeRDP version 2.0.0-dev (git n/a)

Command line used

xfreerdp /size:1724x960 /v:davek-win /sec:rdp /u:davek -grab-keyboard

output of /buildconfig

This is FreeRDP version 2.0.0-dev (git n/a)
Build configuration: BUILD_TESTING=OFF BUILTIN_CHANNELS=ON HAVE_AIO_H=1 HAVE_EVENTFD_H=1 HAVE_EXECINFO_H=1 HAVE_FCNTL_H=1 HAVE_INTTYPES_H=1 HAVE_JOURNALD_H=TRUE HAVE_MATH_C99_LONG_DOUBLE=1 HAVE_POLL_H=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK=ON HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL= HAVE_SYSLOG_H=1 HAVE_SYS_FILIO_H= HAVE_SYS_MODEM_H= HAVE_SYS_SELECT_H=1 HAVE_SYS_SOCKIO_H= HAVE_SYS_STRTIO_H= HAVE_TIMERFD_H=1 HAVE_TM_GMTOFF=1 HAVE_UNISTD_H=1 HAVE_XI_TOUCH_CLASS=1 WITH_ALSA=ON WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CUPS=ON WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DIRECTFB=OFF WITH_EVENTFD_READ_WRITE=1 WITH_FFMPEG=OFF WITH_GFX_H264=OFF WITH_GPROF=OFF WITH_GSM=OFF WITH_GSTREAMER_0_10=OFF WITH_GSTREAMER_1_0=ON WITH_IPP=OFF WITH_JPEG=ON WITH_KRB5=OFF WITH_LIBRARY_VERSIONING=ON WITH_LIBSYSTEMD=ON WITH_MACAUDIO=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_OPENH264=OFF WITH_OPENSLES=OFF WITH_OPENSSL=ON WITH_OSS=ON WITH_PAM=ON WITH_PCSC=ON WITH_PROFILER=OFF WITH_PULSE=ON WITH_SAMPLE=OFF WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_LEAK=OFF WITH_SANITIZE_LEAK_AVAILABLE=1 WITH_SERVER=ON WITH_SERVER_CHANNELS=ON WITH_SERVER_INTERFACE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SSE2=ON WITH_THIRD_PARTY=OFF WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_WAYLAND=ON WITH_X11=ON WITH_X264=OFF WITH_XCURSOR=ON WITH_XDAMAGE=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XKBFILE=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XSHM=ON WITH_XTEST=ON WITH_XV=ON WITH_ZLIB=ON
Build type:          RELWITHDEBINFO
CFLAGS:              -g -O2 -fdebug-prefix-map=/build/freerdp2-jffv_t/freerdp2-2.0.0~git20170725.1.1648deb+dfsg1=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -Wall -Wno-unused-result -Wno-unused-but-set-variable -Wno-deprecated-declarations -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -g -msse2
Compiler:            GNU, 7.3.0
Target architecture: x64

OS version connecting to
windows 7

Desktop (please complete the following information):

OS: ubuntu 18.04

Could you check if it works with current nightlies?
Working with these daily (and remmina uses them too) so this seems to be already resolved.

https://ci.freerdp.com/job/freerdp-nightly-binaries/ you find the nightly builds for testing there.

nightly builds will not run for me, as installed by apt.
/opt/freerdp-nightly/bin/xfreerdp --help
==20631==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD.

I tried fudging LD_LIBRARY_PATH with /opt/freerdp-nightly/lib/ but that didn't work.  Don't know what else to try.

After specifying the environment, it fails with the same error on middle click:
LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libasan.so.4 /opt/freerdp-nightly/bin/xfreerdp /size:1724x960 /v:davek-win /sec:rdp /u:davek -grab-keyboard
[06:37:42:187] [20880:20881] [INFO][com.freerdp.client.common.cmdline] - loading channelEx cliprdr
[06:37:42:189] [20880:20881] [ERROR][com.freerdp.client.x11] - Mouse physical button 1 is mapped to logical button 0
[06:37:42:290] [20880:20881] [INFO][com.freerdp.gdi] - Local framebuffer format  PIXEL_FORMAT_BGRX32
[06:37:42:290] [20880:20881] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL_FORMAT_RGB16
[06:37:42:307] [20880:20881] [INFO][com.winpr.clipboard] - initialized POSIX local file subsystem
[06:37:47:304] [20880:20881] [INFO][com.freerdp.core] - ERRINFO_INVALID_INPUT_PDU_MOUSE (0x000010D0):(a) A Slow-Path Mouse Event (section <IP_ADDRESS>.<IP_ADDRESS>.3) or Extended Mouse Event (section <IP_ADDRESS>.<IP_ADDRESS>.4) has been received with an invalid pointerFlags field.
(b) A Fast-Path Mouse Event (section <IP_ADDRESS>.2.2.3) or Fast-Path Extended Mouse Event (section <IP_ADDRESS>.2.2.4) has been received with an invalid pointerFlags field.
[06:37:47:304] [20880:20881] [ERROR][com.freerdp.core.transport] - BIO_read returned a system error 104: Connection reset by peer

This is FreeRDP version 2.0.0-dev5 (fc12b9336)

@ddombrowsky Ok, the line [06:37:42:189] [20880:20881] [ERROR][com.freerdp.client.x11] - Mouse physical button 1 is mapped to logical button 0 is interesting.
You have some local mouse button mapping magic activated?

@akallabeth I use a logi marble mouse, with a defined button mapping, yes.  I use xinput to map the left "page down" button to the middle button.
xinput set-button-map "Logitech USB Trackball" 1 0 3 4 5 6 7 2 9

@ddombrowsky Are you sure a button id of 0 is allowed? This seems to cause the problems.

@akallabeth yes. From the manpage:
      --set-button-map device map_button_1 [map_button_2 [...]]
               Change the button mapping of device. The buttons are specified in physical order (starting with button 1) and are mapped to the logical button provided. 0 disables a
               button. The default button mapping for a device is 1 2 3 4 5 6 etc.

I also tried mapping it to "8" and that fails with a similar error message.

@ddombrowsky would you test with xfreerdp without the mapping? That could help to pin down the problem.

@bmiklautz Yes, if I change the xinput mapping to default, xfreerdp does not disconnect.  The button defaults to the "back" button and works as designed (which, in my opinion is a bug not a feature, but that's my complaint to logitech).  Without the mapping I have no middle mouse button, so I can't test that.

@ddombrowsky @akallabeth 's fix is already merged and should be in tomorrows nightly build. Would nice if you can verify if your problem is fixes with it and close the issue.

Fix was merged and is working here.
Reopen if still not fixed.

I can confirm this fixed.  The button now doesn't do anything, but that's better than a disconnect.
Thank you all for your help.

@ddombrowsky thx for the feedback.
The button you mean your second one set to 0? Isn't that what it is supposed to do as 0 stands for deactivated?

@akallabeth The logi marble mouse has no "middle" mouse button.  You need to use software to decide which button to use (if any) as the middle one.  On windows, there's a separate hook in the driver (I think).  On linux, which I use, it's an xinput setting which tells X11 to return the code for button "2" when button 8 is clicked.  I'm not sure why that code isn't being sent through to xfreerdp when it works in all other programs.
A very specific use case, I understand.  It really affects only the universe of people using this specific mouse on linux, which is probably just me :)

@akallabeth Sure enough, right after I posted that, I tried +unmap-buttons which does exactly what I was looking for.  Now that the disconnect is fixed, that flag works and everything is right with the world!


Fix bug

No error message is shown when "add ingredient ingree /qty 10 /expiry 20" is input.

Codecov Report

Merging #86 into master will increase coverage by 1.88%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
+ Coverage     54.34%   56.22%   +1.88%
- Complexity      837      889      +52
============================================
  Files           169      170       +1
  Lines          3259     3379     +120
  Branches        328      346      +18
============================================
+ Hits           1771     1900     +129
+ Misses         1351     1331      -20
- Partials        137      148      +11

Impacted Files
Coverage Δ
Complexity Δ

...opchop/logic/parser/commands/AddCommandParser.java
62.31% <77.77%> (-1.87%)
19.00 <3.00> (ø)

...ain/java/chopchop/model/attributes/ExpiryDate.java
77.77% <0.00%> (-3.48%)
8.00% <0.00%> (+1.00%)
:arrow_down:

...ain/java/chopchop/model/ingredient/Ingredient.java
72.00% <0.00%> (-2.08%)
33.00% <0.00%> (+18.00%)
:arrow_down:

...n/java/chopchop/storage/JsonAdaptedIngredient.java
93.18% <0.00%> (-0.16%)
13.00% <0.00%> (+4.00%)
:arrow_down:

src/main/java/chopchop/util/Pair.java
50.00% <0.00%> (ø)
8.00% <0.00%> (+3.00%)

...ava/chopchop/storage/JsonAdaptedIngredientSet.java
90.47% <0.00%> (ø)
5.00% <0.00%> (?%)

src/main/java/chopchop/commons/util/JsonUtil.java
94.11% <0.00%> (+5.88%)
8.00% <0.00%> (ø%)

...in/java/chopchop/model/attributes/units/Count.java
100.00% <0.00%> (+7.69%)
10.00% <0.00%> (+1.00%)

...ain/java/chopchop/commons/util/CollectionUtil.java
87.50% <0.00%> (+12.50%)
5.00% <0.00%> (+3.00%)

src/main/java/chopchop/commons/util/FileUtil.java
77.27% <0.00%> (+22.72%)
9.00% <0.00%> (+1.00%)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7469ad5...c53af6f. Read the comment docs.

oops


Channel, direct message or private group not found/User ID?

I'm running
slack-cleaner --token xx-xxx-xxx --message --direct U000000 --user U000001 --before 2018-08-01
user U000000 is my user ID (copied from slack, under user "userID") and the U000001 person I have direct message with, this channel definitely exists but I'm getting direct message not found. Am I using the wrong userID? ie. should I use their email, not sure because there is no username on my slack channel ie "johndoe" the format is "john doe" and is a first/last name string

I see that slack deprecated usernames for UserIDs... I'm using userID's and it doesnt seem to be able to find direct messages

I'm not even able to delete private messages when specifying the user who i've chatted with. It just says user not found.

+1

I keep getting user not found error, it doesn't work on strings like "Joe Blow"

@rajinder-yadav perform the same call with --info at the end.
That will list you all the usernames.
This way I found the directmessage channel I tried to find on a string like "Joe Blow".

Same problem here, when trying to delete a direct messages I get Channel, direct message or private group not found.
@davidseek --info just gives me slack-cleaner: error: unrecognized arguments: --info


[BUG]: Admin | Sync Template v2 (Apps) and Admin | Sync Template v2 (Flows) start twice and flow one fails

Describe the bug
First:
The two flows:

Admin | Sync Template v2 (Apps)
Admin | Sync Template v2 (Flows)
Are triggered by Admin | Sync Template v2. This triggering flow updates 9 environments.
The two other flows are started 18 times each, so double.

Second:
The flow Admin | Sync Template v2 (Flows) "throws multiple errors: (I removed the guid's to not make them public)

Connection Reference

Could not find flow:

admin_FlowResource does not exist

Third:
The flow Admin | Sync Template v2 (Apps) throws an error for SharePoint form apps:

This happened after upgrading to v1.70.6 .
Component (please tell us which flow or app you are experiencing issues with):

Solution: Core
Version: v1.70.6
App or Flow: Admin | Sync Template v2, Admin | Sync Template v2 (Apps) and Admin | Sync Template v2 (Flows)

To Reproduce
Steps to reproduce the behavior:

Go to the Admin | Sync Template v2 run history. See that it updates every environment.
Go to the Sync Template v2 (Apps) and Admin | Sync Template v2 (Flows) run history and see that they start double.

Expected behavior
The Flow and App flows should only start for every environment. If you have 9 environments, they should start each 9 times, not 18.
I don't know why the others errors for Sync Template v2 (Apps) and Admin | Sync Template v2 (Flows) occur.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Multiple runs - my assumption is that the main sync flow ran twice. This can happen on upgrade/install for people. Turning the flow on runs it, and then if you hit run manually that would be a second run.

Will investigate

We have this local fixed in our tenant, please see if this resolves the issue for you?
AppSyncFlowwithEmbeddedFix_20201028131318.zip

For item 2, can you please share which action is failing.

1. The main sync flow only runs one time a day:

The others run twice. We don't installed them recently or didn't turn them on or off.

2. See below the actions that throw the errors. We haven't customized the CoE, just upgraded once to the last version...
Connection reference:

Could not find flow:

admin_FlowResource does not exist

3. Thanks, I'll try

I believe you are saying that you see 2 sync flows started for each envt, for each object type. And that may be more now if the main sync flow has run again. This would cause you to be accessing/deleting objects at the same time from different flows and hence be in a bad state.
If so, this is likely the long running issue caused by recent changes to throttling.
And if you tried to upgrade to 70_6 which fixed, then that did not work as it no longer does an overwrite.
Can you please upgrade in the following manner?

Switch to classic (this could take some time)

Import

Choose 70_6 CenterofExcellenceCoreComponents_1_70_6_managed.zip

Next & Next

Chose Overwrite and Import

I've followed the steps you mentioned and I have overwritten the solution package using the classic import.
The "Admin | Sync Template v2 (Flows)" flow keeps being triggered twice. We have 9 environments, should it start 9 times. Now it is started 18 times.
The flow seems to work correctly for all environments except "Personal Productivity" - the default one.

This is the error:
{   "status": 404,   "message": "admin_ConnectionReference With Id = [hided] Does Not Exist",   "error": {     "message": "admin_ConnectionReference With Id = [hided] Does Not Exist"   },   "source": "[hided].crm4.dynamics.com",   "errors": [],   "debugInfo": "clientRequestId: [hided]" }

The (flows) sync flow is triggered when the CoE record for the environment it touched.
If this isnt happening from the main sync flow being called twice, it could be due to one of these other flows running.
Can you validate:

Were these flows running during that time? They do also touch those records.

If so, are all 3 now finished?

Were the other objects sync flows also run multiple times? (apps/PVAs/etc)

If you wait until tomorrows sync flow to run, do you see these happening only once?

Hi,
Thanks for the info. See below for answers to the questions:

None of these flows were running. Only the "Check Deleted" one ran on October 31. The other two are turned off.

Yes they are all finished

The "Admin | Sync Template v2 (RPA)" does not run double. The sync apps, flows, PVA run double.

I waited until this morning and as in point 3, only the PVA sync flows not run double.

Do you possibly have a saved version of the sync flow running somewhere else?
Ways to check

turn off the main sync flow we are seeing here, and then see if the object flows (flow/PVA/etc) run tomorrow
open your PBI and look in your CoE envt for a duplicate. Something you did a save-on from the past most likely

I checked if I have duplicates. There seem to be no duplicates.
What is very strange, is that in the PPAC and CoE Dashboard, I don't see all flows in my environment.
For example the CLEANUP - Admin | Sync Template v2 (Orphaned Makers) & CLEANUP - Admin | Sync Template v2 (Power Apps User Shared With) are not showed at all in the PPAC but exist in the Core solution... It seems like there is a bug in the Power Platform or am I wrong? Maybe there is a sync flow running that I don't see because of the bug?
See screenshots below.

More mysteries! For the admin pages, I know sometimes I have to say "load more" even if the item I'm looking for should be showing from a sort POV. Otherwise let's put a pin in those two to see if the double run is whats causing all this drama for us.
Can you please try turning off the Admin | Sync Template v2 we see in Core here and then see if you still get a single run of each object?

Hi @JeneferM-MSFT can you advise (at least roughly) what was done for issue#3 as the zip package provided doesn't allow connectors to be specified and errors out.
I have added a condition to check the app type prior to getting the apps sharing settings and bypass checking the Role Assignments if the app is of type SharepointFormApp and would just like to be sure that I'm not missing any extra required details.

@JeneferM-MSFT , In the PPAC I clicked on "load more" but it is still not showing all flows/apps in an environment. Anyways, this is not for here but I will log a support ticket for that...
I turned the "Admin | Sync Template v2" flow off on Thursday. The other flows haven't ran anymore after turning this main flow off.
So this morning I turned it on again, ran the flow (it ran only 1 time) and again the other flows are running twice while the main flow only updates 11 environments and not 22...

Hello folks. The fix to issue 3 (SP Embedded Apps failure) looks like this. Sorry about the package, it appears that we cannot release individual flows to you anymore now that we use connection references.

Where the left side of that condition is : items('Apply_to_each_App')?['properties']?['embeddedApp']?['type']

On the double run issue, I'm afraid I'm out of ideas. We do not repro and have not heard this from anyone else.
There are ways to track and monitor what edits occur in an entity in the CDS, I would recommend exploring that feature set. I am not familiar with it to walk you through it unfortunately.

Hi @JeneferM-MSFT,
I've the same error reported by @WouterF:
We've upgraded the CoE-Core Components version and since then, we have similar issues:

"Admin | Sync Template v2" flow runs once and we have 15 environments.
"Admin | Sync Template v2 (Apps)" and "Admin | Sync Template v2 (Flows)" are triggered twice per environment, so we have 30 instances of each
Other flows as PVA or RPA run once per environment.
Double instances are likely to cause data inconsistency errors to occur, such as those provided above that also occur to us, for example the "admin_ConnectionReference With Id = XXXX Does Not Exist" in the 'Delete_a_record' action.
Please, if you need more information about or you find a possible solution we can test, please tell us.
Thanks!

Can you please turn off your main sync flow (Admin | Sync Template v2) and see if these two still run?
Admin | Sync Template v2 (Apps) and Admin | Sync Template v2 (Flows)

A couple more follow ups. Putting them all here for ease of reading

See if it repros outside of the context of our sync flows
A. Turn off the main sync flow and ensure no (flow) sync flows are running
B. Make a flow that listens to the flows table and which does something simple like a compose

You can use this one if you'd like: Checknumberoftriggers_20201112150629.zip
C.  Manually edit an environment
There are many ways to do this, but here is one. Edit something that you can change back after we are done

D. See if our test from from B, and the (flows) sync flow ran once or twice.

Turn off sync flow and see if it runs
Can you please turn off your main sync flow (Admin | Sync Template v2) and see if these two still run?
Admin | Sync Template v2 (Apps) and Admin | Sync Template v2 (Flows)
(Wouter checked this for his repro already)

See number of environtments in the loop
Can you please check in the main Sync Template flow the number of environments that were looped?
(Wouter checked this for his repro already)

Hello @JeneferM-MSFT !
I've already performed the tests you requested:
1.	See if it repros outside of the context of our sync flows
A. Turn off the main sync flow and ensure no (flow) sync flows are running:

B. Make a flow that listens to the flows table and which does something simple like a compose:

C. Manually edit an environment:

D. See if our test from from B, and the (flows) sync flow ran once or twice:

Sync flow ran twice when I edited the environment record:

Test flow from B has not been launched by modifying the environment record, but it has been launched before:

2.	Turn off sync flow and see if it runs
Can you please turn off your main sync flow (Admin | Sync Template v2) and see if these two still run?
Admin | Sync Template v2 (Apps) and Admin | Sync Template v2 (Flows)

Yesterday (Nov 12) I turned off the main sync Flow, so this morning (Nov 13) they have not launched (last executions are from yesterday):

Admin Sync Template v2 (Apps) and (Flows) are active, but have not been launched since yesterday:

3.	See number of environments in the loop
Can you please check in the main Sync Template flow the number of environments that were looped?

Yes, we have 15 environments:

If you need any other test, do not hesitate to tell us.
Thanks!

Thanks for posting these findings.
Oh and shoot I totally messed up the test flow in B. Can you please change it to be the Environment entity? It should match the below image.
Even without test B, I now feel confident that this is either something with the trigger in these flows, or something configured in the entity. Since most people dont repro, I suspect its the latter, but can you please:

Change the trigger in the test flow (your step B) to be as shown below. You'll also need to change the field being called in the compose.
Share what your trigger looks like in the (flow) sync flow? It should look like this:

I tested with the new flow and updating an environment record:

I updated one of the environment records (the region from "europe" to "test", I cannot change other fields as I cannot open it in Excel, it's blocked in our organization)
Flow runnedonce:

Share what your trigger looks like in the (flow) sync flow:

When you click "peek code" there are differences between the trigger of the sync flow (flow) & the test flow we created:
{     "inputs": {         "host": {             "connectionName": "shared_commondataservice",             "operationId": "SubscribeOnUpdatedItems",             "apiId": "/providers/Microsoft.PowerApps/apis/shared_commondataservice"         },         "parameters": {             "dataset": "default.cds",             "table": "admin_environments",             "scope": "Organization"         },         "authentication": "@parameters('$authentication')"     } }
{     "inputs": {         "host": {             "connection": {                 "name": "@parameters('$connections')['shared_commondataservice_1']['connectionId']"             }         },         "body": {             "NotificationUrl": "@{listCallbackUrl()}"         },         "path": "/datasets/@{encodeURIComponent(encodeURIComponent('default.cds'))}/tables/@{encodeURIComponent(encodeURIComponent('admin_environments'))}/onupdateditemswebhook",         "queries": {             "scope": "Organization"         },         "authentication": "@parameters('$authentication')"     },     "metadata": {         "flowSystemMetadata": {             "swaggerOperationId": "SubscribeOnUpdatedItems"         }     } }

Hi @JeneferM-MSFT ,
On our side we have also carried out the test that you indicate:

I changed the entity name in the test Flow to: Environments:

I have modified again a record in the environment entity, and the test flow ran only once (same as @WouterF  said):

But Admin | Sync Template v2 (Flows) and Admin | Sync Template v2 (Apps) ran also twice with this change:

Thanks!

Reviewing the triggers "peek code", as @WouterF said before, I have seen that there are some differences between the triggers of the CoE Sync Flows, although I don't know if they can have anything to do with the problem we have:

Admin | Sync Template v2 (Apps) -> ran twice and Admin | Sync Template v2 (PVA) -> ran once, have exactly the same code on the trigger:
{
"inputs": {
"host": {
"connection": {
"name": "@parameters('$connections')['shared_commondataservice']['connectionId']"
}
},
"body": {
"NotificationUrl": "@{listCallbackUrl()}"
},
"path": "/datasets/@{encodeURIComponent(encodeURIComponent('default.cds'))}/tables/@{encodeURIComponent(encodeURIComponent('admin_environments'))}/onupdateditemswebhook",
"queries": {
"scope": "Organization"
},
"authentication": "@parameters('$authentication')"
},
"metadata": {
"flowSystemMetadata": {
"swaggerOperationId": "SubscribeOnUpdatedItems"
}
}
}
Admin | Sync Template v2 (Flows) -> ran twice has a little difference in the trigger, because the shared common data service connection ends with _1:
{
"inputs": {
"host": {
"connection": {
"name": "@parameters('$connections')['shared_commondataservice_1']['connectionId']"
}
},
"body": {
"NotificationUrl": "@{listCallbackUrl()}"
},
"path": "/datasets/@{encodeURIComponent(encodeURIComponent('default.cds'))}/tables/@{encodeURIComponent(encodeURIComponent('admin_environments'))}/onupdateditemswebhook",
"queries": {
"scope": "Organization"
},
"authentication": "@parameters('$authentication')"
},
"metadata": {
"flowSystemMetadata": {
"swaggerOperationId": "SubscribeOnUpdatedItems"
}
}
}

Thanks!

Good idea to look at peek! We match though for the flow triggers in the (flow) sync flow between your envt's and mine, so its correct as we dont repro.
Would it be possible for you to create a clean environment, install the Core solution and see if you repro in a new environment?

@JeneferM-MSFT , sorry but this is not possible for me to install it again. I work for a client and I have unfortunately no time to debug the CoE...
For your information, MS support is investigating if something is going wrong with the triggers and CDS:

Wonderful. Please let me know what they find so that I can point anyone else in the future who sees this issue.

Hello,
By our side, we have managed to solve the issue with the duplicated instances of flows. We followed these steps:

First, we try to uninstall the upgraded version of "Center of Excellence – Core Components" solution in our environment, but  we had some solution dependencies errors because some hidden Power Apps of the first test CoE installation used some entities.

We reviewed the environment Power Apps from PowerShell and removed those that gave error and were not being used:
Get-AdminPowerApp -EnvironmentName [GUID]
Remove-AdminPowerApp -AppName [GUID] -EnvironmentName [GUID]

Once removed, we ran again the CoE Core Components solution uninstall, this time in a satisfactory way, but before reinstalling the solution, we checked the environment Flows through PowerShell, since we saw that there was a duplicate Flow of previous installations that had not been removed: we had before uninstalling the solution two "Admin | Sync Template v2 (Flows)" flows in the same environment!
Get-AdminFlow -EnvironmentName [GUID]
Then remove the duplicated Flow from PS:
Remove-AdminFlow -EnvironmentName [GUID] -FlowName [GUID]

Finally, once we have a clean environment we installed the last version of "Center of Excellence – Core Components" solution (v 1.71.1) and now we no longer have duplicated instances of the flows, just one per environment!

Thanks!
Regards,

@JeneferM-MSFT , I checked using PowerShell, but for me there are no two "Admin | Sync Template v2 (Flows)" flows.
However, with the investigation of @mpinuel , it is clear that there are unwanted duplicate flows & apps in environments that are not visible in the UI.
Can you contact the product team and ask them to investigate because it seems to me that this is a bug.

Good to hear you are fixed up @mpinuel.
@WouterF, I will pass along as well, but given that you have support on the line, I think that will be the most likely solution since they will have access to your tenant.
I will close this issue now and hope that product team can address.


🚀 Typst export

Convert markdown files into typst for PDF creation.

[ ] Need better templating
[ ] Remove unknown cross-references
[ ] Tables
[ ] Render

@fwkoch could you take a look at this tomorrow? I mostly want to know if you have any tips for the exports!

In general, no tips - I think you are right to reuse the tex export since this has similar "zip or not" functionality. Beyond that though, I'd just have to dig in a bit and refactor away some of the repetition.

Goign to break this into a few different PRs!


feat: enable passing a full instance of web3 as provider

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
feature
What is the current behaviour (you can also link to an open issue here)?
So far, it is required to instantiate web3.js in the following way so to give the provider when creating an instance of erc725.js.
// important statement..

// Parameters for ERC725 Instance
const provider = new Web3.providers.HttpProvider("https://rpc.l14.lukso.network");  // require to use an Http Provider
const config = { ipfsGateway: "https://2eff.lukso.dev/ipfs" };

const universalProfile = new ERC725(UniversalProfileSchema, SAMPLE_PROFILE_ADDRESS, provider, config);

This require either to instantiate Web3.js as an HTTP Provider (not recommended, as the HTTP provider from web3.js does not support subscriptions. Or to grab the .currentProvider from the web3 instance, as shown below.
// important statement..

// Parameters for ERC725 Instance
const web3 = new Web3("https://rpc.l14.lukso.network");
const config = { ipfsGateway: "https://2eff.lukso.dev/ipfs" };

// need to grab the .currentProvider so to instantiate
const universalProfile = new ERC725(UniversalProfileSchema, SAMPLE_PROFILE_ADDRESS, web3.currentProvider, config);

What is the new behaviour (if this is a feature change)?
Offer the possibility to provide a complete web3 instance, and let the library grab the .currentProvider automatically under the hood by default.
// important statement..

// Parameters for ERC725 Instance
const web3 = new Web3("https://rpc.l14.lukso.network");
const config = { ipfsGateway: "https://2eff.lukso.dev/ipfs" };

// let erc725.js grab the .currentProvider by default if passing a full instance of web3
const universalProfile = new ERC725(UniversalProfileSchema, SAMPLE_PROFILE_ADDRESS, web3, config);

Other information:
This PR is missing some tests to ensure the new behaviour correctly. 🧪
To be discussed on how to test this new instantiation method correctly (if accepted).

We are closing for this:
https://github.com/ERC725Alliance/erc725.js/issues/232
The specs are different - we simplified the process. Maxime is working on it atm.


Add doc build

Lots of autogen, but only real changes are in tox.ini. Adds an environment so you can update the API docs with tox -e doc.

Is there a way to turn it off for certain docs? Or add exceptions for print statements and rounding for numerical outputs? Otherwise it may be too picky

@paroma  there are a couple examples of this in label_model.py

@paroma also did you mean to post that on #1294?


Docusaurus 2.0.0-beta.0, dynamic imports using backticks not working

I recently installed the docusaurus starter project using npx @docusaurus/init@latest init my-website classic and i tried using dynamic imports with the loadable/component package using backticks to dynamically import different SVG files, but it is not working, when I add a static path without backticks it works.
I have the latest node and docusaurus. I also tried creating a repro with https://new.docusaurus.io and the same issue appears.
Can anyone help with this?
Any suggestion is appreciated.
Thank you.

Hi
Please respect the issue template

I also tried creating a repro with https://new.docusaurus.io and the same issue appears.

Then why not post the link to the sandbox repro


ModernGL has no attribute create_context

Got this while executing on Linux:
python3 main.py
Traceback (most recent call last):
File "main.py", line 10, in
ctx = ModernGL.create_context()
AttributeError: module 'ModernGL' has no attribute 'create_context'
And what to do about the GLWindow since it is not supported in Linux?

Hi!
This example is using ModernGL4 and GLWindow
You have a folder called ModernGL probably because you had ModernGL4 installed.
If you upgraded to ModernGL5 you should have a folder called moderngl.
To run this example you may need a virtualenv with ModernGL4 and GLWindow
GLWindow is not yet ported to linux: https://github.com/cprogrammer1994/GLWindow/issues/2
Here are some code that may help with porting.
Unfortunately I have no time right now to port it. You can also try to replace the GLWindow with any other window implementation. Here are a couple of examples.

Probably related: https://github.com/cprogrammer1994/ModernGL/issues/165 and https://github.com/cprogrammer1994/ModernGL/issues/166.


fix: return undefined when Page.evaluate encounters circular JSON

The new behavior of page.evaluate to convert to JSON makes it difficult to use if you don't care about the return value of your function. Consider
await page.evaluate(() => window.open('about:blank'));
await page.evaluate(() => $('body').hide());

I don't want to be paranoid about whether or not my evaluations unintentionally return circular json.

Let's update documentation


Remove unnecessary dependency on yarn

Not sure why this is in our devdeps, but it was caught by a scan of dependencies.

It was originally being used in ms-rest-js and ms-rest-azure-js but I don't think we do anything now that depends on it.

I couldn't find anything that referenced it 🤞


GET /users/{username}/repos: per_page has wrong max value

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
URL https://docs.github.com/en/rest/reference/repos#list-repositories-for-a-user
Currently that max value 100 is not right.

In some reason the request with param per_page=100 I got only 62 repos, but my account has 71

Codesandbox example – https://codesandbox.io/s/distracted-cookies-28w0i?file=/src/index.js
What part(s) of the article would you like to see updated?
I want to updated that part – List repositories for a user parameters and that text (max 100)
Screenshot:

Additional information
Maybe I use API in a wrong way, not sure.

Hi @shapkarin, thanks for opening this! I think I can see what's happening with the request.
When you make an unauthenticated request to our API, we'll only return items that are publicly accessible. In the case of GET /users/{username}/repos, that means only public repositories owned by the account. If I take a look at your account, the number of public repositories you own matches the number returned by the API.
If you want the endpoint to return your private repositories too, I'd suggest creating a personal access token with the repo scope and using that to authenticate the request. You'll find some examples for authenticating the request here:
https://docs.github.com/en/rest/guides/getting-started-with-the-rest-api#authentication
I hope that's helpful! I'm going to close this issue now. Let me know if I've misunderstood and if you have any questions about authenticating, I'd suggest reaching out on community forums :cat:

@stevecat thank! make sense I have 63 public repos. UI prints: 63 results for public repositories sorted by last updated


[Bug] Cannot choose which local port for the panel to use

When running through the CLI installer on my server, I found that I was unable to customize which port I want to have the Moonlight Panel use when communicating with the internet. Since port 80 and 443 on my server are already occupied, the installer fails with this stack trace:
Unhandled exception. System.Exception: docker: Error response from daemon: driver failed programming external connectivity on endpoint moonlight (5c86aa1a3e3738402bfca5ed5cd2369e9c497f0b2b8a3d72921788a17534d1d7): Error starting userland proxy: listen tcp4 <IP_ADDRESS>:80: bind: address already in use.

   at Installer.Helpers.BashHelper.ExecuteCommand(String command, Boolean ignoreErrors, Boolean showOutput)
   at Installer.Installers.PanelInstaller.<>c__DisplayClass0_0.<<Install>b__6>d.MoveNext()
--- End of stack trace from previous location ---
   at Installer.Helpers.DisplayHelper.<>c__DisplayClass0_0.<<RunAsStatus>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at Spectre.Console.Status.<>c__DisplayClass16_0.<<StartAsync>b__0>d.MoveNext() in /_/src/Spectre.Console/Live/Status/Status.cs:line 79
--- End of stack trace from previous location ---
   at Spectre.Console.Status.<>c__DisplayClass17_0`1.<<StartAsync>b__0>d.MoveNext() in /_/src/Spectre.Console/Live/Status/Status.cs:line 120
--- End of stack trace from previous location ---
   at Spectre.Console.Progress.<>c__DisplayClass28_0`1.<<StartAsync>b__0>d.MoveNext() in /_/src/Spectre.Console/Live/Progress/Progress.cs:line 133
--- End of stack trace from previous location ---
   at Spectre.Console.Internal.DefaultExclusivityMode.RunAsync[T](Func`1 func) in /_/src/Spectre.Console/Internal/DefaultExclusivityMode.cs:line 40
   at Spectre.Console.Progress.StartAsync[T](Func`2 action) in /_/src/Spectre.Console/Live/Progress/Progress.cs:line 116
   at Spectre.Console.Status.StartAsync[T](String status, Func`2 func) in /_/src/Spectre.Console/Live/Status/Status.cs:line 117
   at Spectre.Console.Status.StartAsync(String status, Func`2 action) in /_/src/Spectre.Console/Live/Status/Status.cs:line 77
   at Installer.Helpers.DisplayHelper.RunAsStatus(String statusText, Func`1 work)
   at Installer.Installers.PanelInstaller.Install()
   at Program.<Main>$(String[] args)
   at Program.<Main>(String[] args)
install.sh: line 6: 213804 Aborted                 sudo ./Installer

It would be better if the user could input which local port they want to use for HTTP/HTTPS during the configuration phase, before running the docker container.

Closed as v2 has implemented this option


Add yolo-unipose

yolo-unipose, which is a pre-processing tool, is used to to get the main creature in the image, judge its kind, and then return the bounding box of the creature.

Good job! You can add a pytest script to show that your module works.

The merge is quite a shortcut and sooner than it should be. Since #4 requires YOLO urgently for data preprocessing, automated annotation and such, this pull request is merged at a pre-mature state. More YOLO-related patches will come to dev branch.


Symbols for pal version

Hello
I have identified the offsets of the PAL version based on the NTSC offsets. I have also updated the buildList.txt files with the offsets of the PAL version. In the case of Kaizoman mod it's necessary to change more things than the offsets because in the PAL version the strings are not hardcoded.
Regards

Hi! Wow, thanks a lot for adding these! I never expected to be able to support the PAL version as well.
Kaizoman will indeed not work, but that's no big deal since it's for a rom-hack with modified levels which would anyway only work on the NTSC version.
I also believe you can use the special keyword common in the build files to specify if a build action is for all versions. That's probably preferable in cases where the address is specified by a label rather than a pointer. So for example this:
ntsc-u, exe, FntPrint, 0x0, src/dummy.c // Blank out FntPrint
pal-e, exe, FntPrint, 0x0, src/dummy.c // Blank out FntPrint

could probably be merged into:
common, exe, FntPrint, 0x0, src/dummy.c // Blank out FntPrint

But that's no big deal and I'll probably go through and change that myself later.