onAudioPositionchanged

Checklist

[x] I read the troubleshooting guide before raising this issue
[x] I made sure that the issue I am raising doesn't already exist

Current bug behaviour

Expected behaviour

Steps to reproduce

Execute flutter run on the code sample
...
...

Code sample

void main() {
}

Logs

my relevant logs

Full Logs

my full logs or a link to a gist

Flutter doctor:
Output of: flutter doctor -v

Audio Files/URLs/Sources

Sample Url: https://luan.xyz/files/audio/coins.wav
Sample Stream: https://example.com/my_stream.m3u8

Screenshots

Environment information

audioplayers version:

Platform 1:

OS name and version:
Device:

build mode: debug

error peculiarities (optional):

Platforms tested without any issue (optional):

test peculiarities:

More information

Je veux savoir si le onAudioPositionchanged marche

@18BG

Plz try to ask your questions in english
Fill the issue template with all the information asked in there. Otherwise we cannot help.
You most likely don't use the current version of Audioplayers. Try to upgrade it.

Okay I'll send it tomorrow

@18BG marking as stale

@18BG marking as stale

what , don't understand !


Clean up Metadata

Clean up the metadata header.
Especially, refactor
https://github.com/constantinpape/zarr_pp/blob/master/include/zarr%2B%2B/metadata.hxx#L74
and
https://github.com/constantinpape/zarr_pp/blob/master/include/zarr%2B%2B/metadata.hxx#L114
These should be members / constructors of the ArrayMetadata.

Solved with 2bb4068


[Relay][FastMath] Relay pass to use fast exp/tanh

As Title, dependent on the following PR - https://github.com/apache/incubator-tvm/pull/4790
@alexgl-github @zhiics @masahi

Thanks @zhiics for quick review. I will incorporate your comments once the parent PR gets merged in.

I have rebased.
I am not sure if opt_level=4 is the right way. There are other optimizations as well at opt_level=4, which I might not want to use. At the same time, it does not look like opt_level=3 candidate as well because it approximates. @zhiics

@tqchen any thoughts on this?

I agree with @zhiics .

@tqchen you mean to add a fast_math config option, right?
I will add one

While we cannot add a config option for every new chocies of optimizations, fastmath seems to be a quite common one that I think might  be OK

I agree.

I investigated more. I am also little uncomfortable about adding another Relay build config option. It changes API of PassContext/BuildConfig object.
Our goal is to make the pass user-friendly. We can use required_pass (current way) to do that. For a TVM user, there is no difference between the two options
Current way
with relay.build_config(opt_level=3, required_pass=['FastMath']):

Alternative
If we decide to add enable_fast_math build config option.
with relay.build_config(opt_level=3, enable_fast_math=True):

Since both are same from TVM user perspective, and current way does not change PassContext API, I feel more comfortable with current design.
@zhiics @tqchen Let me know if this is ok.

Adding it to required_pass sounds good to me as well since users definitely need to know what they do exactly in this scenario.
The only concern I have is that I am not sure if we want to require passes from the higher level? Also, what's the relationship among the passes at opt_level=4? should we run it with other two passes when opt_level=4 is provided? This is not specific to this PR, but I think we probably want a better documentation for the choice of different opt levels.

Seems with relay.build_config(opt_level=3, required_pass=['FastMath']) is simple enough that we can go with that for now

@zhiics I agree we need more clarity over the usage of opt_level=4. Thinking more about this, I feel that opt_level=4 is more like a placeholder for all the passes, that will not be a part of default Relay build pipeline. I don't think we intend to use opt_level=4 to call these passes. Calling these passes should be either from outside or by using required_pass. If that is truly the case, maybe we should not even have an opt_level for such passes.
As far as this PR is concerned, I think we are ok.

It is a bit pre-mature to introduce additional opt levels as we add passes. how about we only support the required_pass option for now

Yes, I am okay to use required_pass for now.


Disabled warnings for MSC complilier are not handled consistently

The following files disable warnings:

gendebug.cc
genjit.cc
genopt.cc
host.cc
codegen.cc

But the list of warnings is slightly different and also gendebug.cc
is not doing a warning pop using the code sequence below.
#ifdef _MSC_VER
#  pragma warning(pop)
#endif

All other file do have that code sequence.
I have a PR that provides a fix coming.

Closed with #2802


cannot create directory at 'aux'

When git wants to checkout it will show this error: fatal: cannot create directory at 'aux': Invalid argument. That's because aux is a reserved name on Windows.

Unfortunately I don't have and I don't use windows, but adding support for it would be great. Are you interested in contributing by adding support for win?
I think currently "aux" issue is the problem, and https://github.com/ivpusic/go-hotreload/blob/master/hr/pm.go#L21 "fuser" Unix specific command used by "go-hotreload" package.

http://stackoverflow.com/questions/48198/how-can-you-find-out-which-process-is-listening-on-a-port-on-windows -> this may be solution for "fuser" Unix command. And renaming aux and testing it should be trivial.

Thanks for the nice neo! I've already forked neo and as soon as I feel happy about it (naturally restricted to my mind-frame & abilities) I'll make a pull request. The problem is the only way around it (AFAIK) is to use a name like _aux or misc instead of aux.

I refactored aux package. Look at https://github.com/ivpusic/neo/commit/c810caf4bcb013516921fd6342012f91e80c51e7. So next step is to solve "fuser" thing on win.

Thanks; I was thinking not everybody would be comfortable with renaming.

I am not experiencing any problem with neo. But I've not tested the command line (thanks to the stork in charge of delivering me, around my area internet is a messed up thing - i.e. no access to gopkg; in this case, on the other end. But I'm on it). So this issue should be closed and fuser should be handled on another issue. I'll follow up the thing, but fuser should be handled in a very different way on Windows - watchers and the like; I've not used it ever either.

Yes, fuser issue is related to Neo hotreload (neo run main.go).
Thanks for reporting this one!


Add respect for extension property in options file

#63 resolved. Previously, it was not possible to define the extension in an options file.

Failing tests are a result of pug dependencies:
 /home/travis/build/pugjs/pug-cli/node_modules/pug/node_modules/pug-parser/index.js:391       const expr = this.parseExpr();       ^^^^^ SyntaxError: Use of const in strict mode.

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #64   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines         145    146    +1
=====================================
+ Hits          145    146    +1

Impacted Files
Coverage Δ

index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21bab2e...06833d3. Read the comment docs.

https://github.com/pugjs/pug-parser/issues/31
Issue causing failing builds

The const/var in strict mode issue has been resolved, but is not pushed to NPM yet:
https://github.com/pugjs/pug/commit/e9dbadd0b392dce56bcb0b75aafff9e9dd90ed96
This pull request should solve these build issues.


Revert changes for Solidus/TaxCategoryDeprecated

This pattern would result to a false positive.

Could you please update the PR description, adding the example I sent you in Linear? In this case, it will be more clear why we need this


set tTaskResponce = %request.Content.Task Raises Property Does Not Exist

Located within PostTask, we're getting a PropertyDNE on *Task.  We have the other service behaving as expected in our REST client but we're now at the point where we'd like to perform updates.
{
	"errors":[ {
			"code":5002,
			"domain":"%ObjectErrors",
			"error":"ERROR #5002: Cache error: <PROPERTY DOES NOT EXIST>zPostTask+5^eReferral.REST.Services.1 *Task,%CSP.BinaryStream",
			"id":"CacheError",
			"params":["<PROPERTY DOES NOT EXIST>zPostTask+5^eReferral.REST.Services.1 *Task,%CSP.BinaryStream"
			]
		}
	],
	"summary":"ERROR #5002: Cache error: <PROPERTY DOES NOT EXIST>zPostTask+5^eReferral.REST.Services.1 *Task,%CSP.BinaryStream"
}

%request.Content is a CSP.BinaryStream, what I don't understand is how %request.Content.Task gets populated.  I can understand what's getting passed in will directly influence the Content but I don't even see how this Task serialization happens within the service (as I try to debug this).
Here's my input to the service which is JSON valid and appears to be schema valid based on the sample input provided in the readme:
{
	"_class": "EnsLib.Workflow.Worklist",
	"_id": "1208||ereferraladmin",
	"Task": {
		"_class": "EnsLib.Workflow.TaskResponse",
		"_id": 1208,
		"%Action": "$Accept",
		"%Priority": 3,
		"%UserName": "",
		"%UserTitle": "",
		"%UserRanking": "",
		"%RoleName": "eReferral.WF.ClinicianReview",
		"%Subject": "Clinician review required for referral 12",
		"%Message": "Some sample message",
		"%Actions": "Reviewed,Return",
		"%FormTemplate": "",
		"%FormFields": "Comments",
		"%FormValues": {

		},
		"%Status": "Unassigned",
		"%TaskStatus": {
			"_class": "EnsLib.Workflow.TaskStatus",
			"Role": {
				"_class": "EnsLib.Workflow.RoleDefinition",
				"_id": "eReferral.WF.ClinicianReview",
				"Name": "eReferral.WF.ClinicianReview",
				"Description": "",
				"Capacity": 100
			},
			"AssignedTo": "",
			"TimeCreated": "2017-03-15 14:17:00.463",
			"TimeCompleted": "",
			"SessionId": 1563,
			"Source": "EnsLib.Testing.Process",
			"ResponseToken": "1564|EREFERRALPKG.EdgeGatewayProduction",
			"IsComplete": false,
			"Request": {
				"_class": "EnsLib.Workflow.TaskRequest",
				"_id": 1206,
				"%Actions": "Reviewed,Return",
				"%Subject": "Clinician review required for referral 12",
				"%Message": "Some sample message",
				"%Priority": 3,
				"%UserName": "",
				"%Title": "",
				"%TaskHandler": "",
				"%Command": "",
				"%FormTemplate": "",
				"%FormFields": "Comments",
				"%FormValues": {

				}
			}
		}
	},
	"User": {
		"_class": "EnsLib.Workflow.UserDefinition",
		"_id": "ereferraladmin",
		"Name": "ereferraladmin",
		"FullName": "ereferral admin",
		"IsActive": true
	},
	"Role": null,
	"TimeCreated": "2017-03-15 14:17:00.465",
	"IsNew": true,
	"Age": "00w 0d 01h 08m 47s"
}

I even passed in the JSON from the readme (which I knew wouldn't find the task referenced) but it failed in the same place before it could even look it up.

You're getting an error here because %request.Content is %CSP.BinaryStream but EnsLib.Workflow.Worklist is expected. Conversion from %CSP.BinaryStream is done in ConvertRequestBody. Seems like it's not hit for you.
Please provide:
1.$zv
2. Does adding do ..ConvertRequestBody() before set tTaskResponce = %request.Content.Task and recompiling helps?
3. Does Workflow.AbstractREST compile without problems?

You're exactly right!  I was cherry picking into my preexisting service and simply missed this line.  Sorry for the noise and thanks for the quick response!


marshmallow schema in post body

Very impressed with hug and how it uses typing annotation. Fits great with our python 3.5 development stack.
However I have hard time trying to use a marshmallow schema as an argument to a post.
I have something like:
@hug.post() def stores(new_store: fields.Nested(NewStoreSchema)):
I tried with new_store: NewStoreSchema but that did not work - when using fields.Nested I now need to post with {"new_store":{....}} in the json body but I still cannot seem to extract the content of my schema
I wanted to know if I am missing something obvious before trying to fix it

I did find:
hug.types.MarshmallowSchema(NewStoreSchema)
However, it still needs the data to have a new_store envelope

I think I figured it out:

the schema argument must be an instance, not the schema class

the argument name must be 'body'

new_store_schema = NewStoreSchema()
body: hug.types.MarshmallowSchema(new_store_schema)


Error when executing after recent updates

I've run into issues after the recent updates were pushed, resulting in either an error or a complete lack of coherence from frame to frame as if just generating a batch.
I've tried: all modules and schedulers, the standard and included empty latent image node, with and without the new context options, the recent workflow examples and custom workflows, and even a fresh install of comfy without other extensions.
Error received from example txt2img workflow:
Error occurred when executing ADE_AnimateDiffLoaderWithContext:

expected str, bytes or os.PathLike object, not NoneType

  File "/home/b/SD/ComfyUI/execution.py", line 152, in recursive_execute
    output_data, output_ui = get_output_data(obj, input_data_all)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/b/SD/ComfyUI/execution.py", line 82, in get_output_data
    return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/b/SD/ComfyUI/execution.py", line 75, in map_node_over_list
    results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/b/SD/ComfyUI/custom_nodes/ComfyUI-AnimateDiff-Evolved/animatediff/nodes.py", line 62, in load_mm_and_inject_params
    load_motion_module(model_name)
  File "/home/b/SD/ComfyUI/custom_nodes/ComfyUI-AnimateDiff-Evolved/animatediff/motion_module.py", line 51, in load_motion_module
    model_hash = calculate_file_hash(model_path)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/b/SD/ComfyUI/custom_nodes/ComfyUI-AnimateDiff-Evolved/animatediff/model_utils.py", line 194, in calculate_file_hash
    with open(filename, 'rb', buffering=0) as f:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Queue size: 0
Extra options

I don't receive the error from a nearly identical workflow that functioned before, but as stated previously it doesn't seem to use the motion modules.
Here's the workflow that functions without error, and the output:

Using python venv
OS: Arch Linux

Thanks for the report, looks like it's getting None for the filename object for some reason. I'll look into the code real quick and see where something has the potential to go wrong. If looking through doesn't give me hints, would you mind trying to run a custom branch that will have some extra print statements?

Sure thing!

I made the bughunt-motionmodelpath branch with an alternate, built-in way to get a model's full path that I probably should have done from the get-go but didn't understand. It's odd that the update caused that to break on your end when my code didn't change it, but maybe this will fix it. If it does not fix it on your end, I will add a crapton of print statements and we can try again.
You can git checkout bughunt-motionmodelpath to change your branch to that one, and then you can switch back to the main branch with git checkout main later (explaining just in case, but you likely already know). Let me know how it goes!

I also just merged those changes into main, so in case you look at this in a bit, you won't need to use that branch to test that change.

Sadly, no dice. Getting identical results.
Error occurred when executing ADE_AnimateDiffLoaderWithContext:

expected str, bytes or os.PathLike object, not NoneType

  File "/home/b/SD/ComfyUI/execution.py", line 152, in recursive_execute
    output_data, output_ui = get_output_data(obj, input_data_all)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/b/SD/ComfyUI/execution.py", line 82, in get_output_data
    return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/b/SD/ComfyUI/execution.py", line 75, in map_node_over_list
    results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/b/SD/ComfyUI/custom_nodes/ComfyUI-AnimateDiff-Evolved/animatediff/nodes.py", line 62, in load_mm_and_inject_params
    load_motion_module(model_name)
  File "/home/b/SD/ComfyUI/custom_nodes/ComfyUI-AnimateDiff-Evolved/animatediff/motion_module.py", line 51, in load_motion_module
    model_hash = calculate_file_hash(model_path)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/b/SD/ComfyUI/custom_nodes/ComfyUI-AnimateDiff-Evolved/animatediff/model_utils.py", line 194, in calculate_file_hash
    with open(filename, 'rb', buffering=0) as f:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Queue size: 0
Extra options

Interesting, I don't think I've seen anyone else have this issue, but at least we know what didn't cause the problem. I'm gonna use that branch I mentioned a bit ago to add a metric caption of print statements and we can do some sleuthing, I'll let you know when it's ready!

Combine node is red for me, doesnt work, it wont feed frames to animatediff

Combine node is red for me, doesnt work, it wont feed frames to animatediff

Post the error that is in the console, and/or a screenshot. Also, start a new issue so we don't clutter the messages of this one that is specific to this loading issue Rassilon is experiencing.

Update:
Decided to try another install of ComfyUI elsewhere, and leave the one in question intact, but was receiving the same error. I removed the repo from custom_nodes and installed again via ComfyUI-Manager, and noticed the following output in console:
FETCH DATA from: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
Install custom node 'AnimateDiff (Kosinkadink version)'
install: ['https://github.com/Kosinkadink/ComfyUI-AnimateDiff-Evolved']
Download: git clone 'https://github.com/Kosinkadink/ComfyUI-AnimateDiff-Evolved'
Installation was successful.

## ComfyUI-Manager: EXECUTE => ['/home/b/Documents/ComfyUI/venv/bin/python', '-m', 'pip', 'install', 'flash_attn']
 Collecting flash_attn
   Using cached flash_attn-2.2.4.post1.tar.gz (2.3 MB)
   Preparing metadata (setup.py): started
   Preparing metadata (setup.py): finished with status 'error'
[!]   error: subprocess-exited-with-error
[!]
[!]   × python setup.py egg_info did not run successfully.
[!]   │ exit code: 1
[!]   ╰─> [23 lines of output]
[!]       fatal: not a git repository (or any parent up to mount point /)
[!]       Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
[!]       /tmp/pip-install-1r6hu5kd/flash-attn_142ab282918f4c97a91374ba201f24f0/setup.py:79: UserWarning: flash_attn was requested, but nvcc was not found.  Are you sure your environment has nvcc available?  If you're installing within a container from https://hub.docker.com/r/pytorch/pytorch, only images whose names contain 'devel' will provide nvcc.
[!]         warnings.warn(
[!]       Traceback (most recent call last):
[!]         File "<string>", line 2, in <module>
[!]         File "<pip-setuptools-caller>", line 34, in <module>
[!]         File "/tmp/pip-install-1r6hu5kd/flash-attn_142ab282918f4c97a91374ba201f24f0/setup.py", line 136, in <module>
[!]           CUDAExtension(
[!]         File "/home/b/Documents/ComfyUI/venv/lib/python3.11/site-packages/torch/utils/cpp_extension.py", line 1048, in CUDAExtension
[!]           library_dirs += library_paths(cuda=True)
[!]                           ^^^^^^^^^^^^^^^^^^^^^^^^
[!]         File "/home/b/Documents/ComfyUI/venv/lib/python3.11/site-packages/torch/utils/cpp_extension.py", line 1179, in library_paths
[!]           if (not os.path.exists(_join_cuda_home(lib_dir)) and
[!]                                  ^^^^^^^^^^^^^^^^^^^^^^^^
[!]         File "/home/b/Documents/ComfyUI/venv/lib/python3.11/site-packages/torch/utils/cpp_extension.py", line 2223, in _join_cuda_home
[!]           raise EnvironmentError('CUDA_HOME environment variable is not set. '
[!]       OSError: CUDA_HOME environment variable is not set. Please set it to your CUDA install root.
[!]
[!]
[!]       torch.__version__  = 2.0.1+cu118
[!]
[!]
[!]       [end of output]
[!]
[!]   note: This error originates from a subprocess, and is likely not a problem with pip.
[!] error: metadata-generation-failed
[!]
[!] × Encountered error while generating package metadata.
[!] ╰─> See above for output.
[!]
[!] note: This is an issue with the package mentioned above, not pip.
[!] hint: See above for details.
[!]
[!] [notice] A new release of pip is available: 23.1.2 -> 23.2.1
[!] [notice] To update, run: pip install --upgrade pip
install script failed: https://github.com/Kosinkadink/ComfyUI-AnimateDiff-Evolved

I thought this was weird, as I'd never gotten these dependency issues before. I tried reinstalling all requirements after clearing the pip cache, but still the same.
Anyways, before trying to just install them as system packages I decided to just try bypassing ComfyUI-Manager and git clone the repo into custom_nodes.
Lo and behold! It worked just fine, ran without error and used the motion module as expected.
So it seems to be something about the way ComfyUI-Manager is installing it, at least on my system.

I've actually had a few people complain about nodes not working when installing through comfyui manager, either that or not pulling the most recent version. This has happened for both this repo and my other Advanced-ControlNet repo. I think I am going to open an issue with ComfyManager because I truly have no idea what is going wrong there lol. Thanks for checking it out!

Of course!
Anyways, I appreciate your time looking into it. Keep up the great work, can't wait for prompt travel!

Thanks, fingers crossed prompt travel will be ready by the end of the weekend. By the way, if you remove your comfy manager entirely and reinstall it back from scratch, does that fix the issue as well?

When I did a second install elsewhere I used a fresh clone of the manager repo, and it still produced the install error.


Most commonly used settings cause workspace problems

VSCode Version: Code - Insiders 1.8.0-insider (0d65ced0fa7398dc9d50c39a23a2a8cc8406ff18, 2016-12-07T07:05:09.124Z)
OS Version: Darwin x64 15.6.0
Extensions:

Extension
Author
Version

vscode-docker
PeterJausovec
0.0.8

theme-toothpaste
aalaap
0.0.1

vscode-eslint
dbaeumer
1.2.0

githistory
donjayamanne
0.1.2

tslint
eg2
0.6.7

vscode-npm-script
eg2
0.1.2

vsc-travis-ci-status
felixrieseberg
1.0.5

csharp
ms-vscode
1.5.3

debugger-for-chrome
msjsdiag
2.3.2

Ruby
rebornix
0.10.3

java
redhat
0.0.7

kustovscode
seanmcbreen
0.0.1

autoimport
steoates
1.2.2

gitblame
waderyan
1.3.0

vscode-open-in-github
ziyasal
1.2.2

Steps to Reproduce:

Open View>Problems
Open Code Insiders>Preferences>User Settings

All keys that are in the Most Commonly Used section are reported as duplicated keys.

Duplicates #16674


i18n(zh-cn): Update nav.ts

What kind of changes does this PR include?

Translated content

Description

add view-transitions zh-cn language translation

LGTM. please update title as 'i18n(zh-cn): Update nav.ts'

Done


$ENV{FORCE_FILTER_SIGNATURES} gives warning with empty ()

If I force the use of Filter::signatures in Helpers.pm with
BEGIN {
   # force use of Filter::signatures
   no warnings 'experimental::signatures';
   $ENV{FORCE_FILTER_SIGNATURES} = 1;
}

And then
use Filter::signatures;
no warnings 'experimental::signatures';
use feature 'signatures';

I get the following warnings printed

perl -c Helpers.pm
The signatures feature is experimental at Helpers.pm line 122.
The signatures feature is experimental at Helpers.pm line 128.
Helpers.pm syntax OK

where the routines on lines 122 and 128 have parens with nothing inside:
sub glGetVersion_p() {
    my $glVersion = glGetString(GL_VERSION);
    ($glVersion) = ($glVersion =~ m!^(\d+\.\d+)!g);
    $glVersion
}

sub croak_on_gl_error() {
    my $error = glGetError();
    if( $error != GL_NO_ERROR ) {
        croak $glErrorStrings{ $error } || "Unknown OpenGL error: $error"
    };
}

If I don't set the environment variable, then no warnings are printed.

Whoops - that's what I get for only testing with the native Perl implementation
instead of also properly (resp. only) testing with the filter enabled. The above
two changes fix the issue for me. If they work for you as well, I'll upload them to CPAN soonish.

I've just released v0.07 with the (hopefully) fix for this onto CPAN.

I didn't get the warnings but I did get lots and lots of:

Subroutine  called with parameters. at scripts/shadertoy.pl line 643.
Subroutine  called with parameters. at scripts/shadertoy.pl line 758.
Subroutine  called with parameters. at scripts/shadertoy.pl line 643.
Subroutine  called with parameters. at scripts/shadertoy.pl line 758.
Subroutine  called with parameters. at scripts/shadertoy.pl line 643.
Subroutine  called with parameters. at scripts/shadertoy.pl line 758.
Subroutine  called with parameters. at scripts/shadertoy.pl line 735.
Subroutine DESTROY called with parameters. at /cygdrive/e/chm/pogl/app-shadertoy/blib/lib/OpenGL/Shader/OpenGL4.pm line 82.
Subroutine DESTROY called with parameters. at /cygdrive/e/chm/pogl/app-shadertoy/blib/lib/OpenGL/Shader/OpenGL4.pm line 82 during global destruction.

until I quit the application.  Is this some leftover debug stuff or do I need to re-pull app-shadertoy?

No, this is likely a mistake that I didn't clean up.
Am 18. Dezember 2016 15:39:25 MEZ, schrieb devel-chm<EMAIL_ADDRESS>
I didn't get the warnings but I did get lots and lots of:

Subroutine  called with parameters. at scripts/shadertoy.pl line 643.
Subroutine  called with parameters. at scripts/shadertoy.pl line 758.
Subroutine  called with parameters. at scripts/shadertoy.pl line 643.
Subroutine  called with parameters. at scripts/shadertoy.pl line 758.
Subroutine  called with parameters. at scripts/shadertoy.pl line 643.
Subroutine  called with parameters. at scripts/shadertoy.pl line 758.
Subroutine  called with parameters. at scripts/shadertoy.pl line 735.
Subroutine DESTROY called with parameters. at
/cygdrive/e/chm/pogl/app-shadertoy/blib/lib/OpenGL/Shader/OpenGL4.pm
line 82.
Subroutine DESTROY called with parameters. at
/cygdrive/e/chm/pogl/app-shadertoy/blib/lib/OpenGL/Shader/OpenGL4.pm
line 82 during global destruction.

until I quit the application.  Is this some leftover debug stuff or do
I need to re-pull app-shadertoy?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/Corion/filter-signatures/issues/1#issuecomment-267824817

--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

This should be fixed by v0.08 of Filter::signatures, which reinstates signature-less functions
https://github.com/Corion/filter-signatures/commit/2ff4a2dc196415254306b1ab6331badbf19f875d


version: post-release bump

Signed-off-by: Lars Holm Nielsen<EMAIL_ADDRESS>

Coverage remained the same at 67.516% when pulling 76ffadd114b564e2e0a5c720d96887d7233ab3df on lnielsen:postrel into c7f71c7853b61581a9fc1dd3c133be47ae3284b0 on inveniosoftware:master.


Run script AFTER daemons start

I have a situation in which I want to mount an nfs drive however this means that I have to hack the my_init script so that it will allow for loading after the daemons are started. Does anyone have a way that does not involve modifying my_init. If this is something others would find useful i'll push it back upstream.

The main command is run after daemons are started.


Support mark default version for CRD with multiple versions

Feature Request
Support mark default version for CRD with multiple versions.
If an operator owns a CRD with multiple versions, the csv will have the CRD kind with different versions. It will cause users could not determin which CRD version to use, missing the storage version defined in the CRD object.
The OLM should enable marking which CRD version is the storage version, then the user could use the CRD vesion as default
version to create the CRs.
Is your feature request related to a problem? Please describe.
Example: I have an CRD MySQLCluster, it has versions v1alpha, v1beta and v1. The storage version is v1.
The csv file will have 3 MySQLCluster definitions as follows:
...
  customresourcedefinitions:
    owned:
      - description: Instance of a MySQL Cluster
        displayName: MySQL Custer
        kind: MySQLCluster
        name: mysqlclusters.example.com
        version: v1
      - description: Instance of a MySQL Cluster
        displayName: MySQL Custer
        kind: MySQLCluster
        name: mysqlclusters.example.com
        version: v1alpha
      - description: Instance of a MySQL Cluster
        displayName: MySQL Custer
        kind: MySQLCluster
        name: mysqlclusters.example.com
        version: v1beta
...

The user don't know which version is the preferred MySQLCluster version, and will be confused on such versions.
Describe the solution you'd like
Add a field in CRDDescription to describe if the CRD is the default, and validate the field if there are multiple CRD versions of one kind.

We would recommend that users check the CRD on-cluster to determine the storage version and then version their CRs appropriately. The current tenancy model makes it harder to accurately gauge the stored version based on the CSV itself, as there can be multiple CSVs managing multiple CRDs with different versions.
With the v2 APIs, this tenant problem will go away (along with the CSV resource) as operators will be cluster scoped.

Thanks for you reply!


Add a notebook that can be used to generate workspace projects for a new user.

Note: can only be run by someone with the proper permissions on the parent workspace projects.

Pull Request Test Coverage Report for Build 150

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.415%

Totals

Change from base Build 132:
0.0%

Covered Lines:
2416

Relevant Lines:
2702

💛  - Coveralls


Rest arguement is mishandled when controlFlowFlattening is enabled

Expected Behavior

Expected output:
function f(e, h, i, j) {
    console['log'](e, h, i, j);
}
function g(...b) {
    const c = {
        'vtpEA': function (d, ...e) {
            return d(...e);
        }
    };
    c['vtpEA'](f, ...b, 0x5);
}
const a = [
    0x1,
    0x2,
    0x3
];
g(...a, 0x4);

Current Behavior

Current output:
function f(e, h, i, j) {
    console['log'](e, h, i, j);
}
function g(...b) {
    const c = {
        'vtpEA': function (d, ...e, h) {
            return d(...e, h);
        }
    };
    c['vtpEA'](f, ...b, 0x5);
}
const a = [
    0x1,
    0x2,
    0x3
];
g(...a, 0x4);

Your Environment

Obfuscator version used: 2.12.0
Node version used: 14.10.1

Stack trace

Minimal working example that will help to reproduce issue

function f(a, b, c, d) {
  console.log(a, b, c, d)
}

function g(...args) {
  f(...args, 5)
}
const a = [1, 2, 3]
g(...a, 4)

Hi. Will try to fix it today.

So, seems we can always suppose that if we have a rest argument in the start/middle of call arguments then in the function parameters this argument will always be used as the last parameter.

PR:
https://github.com/javascript-obfuscator/javascript-obfuscator/pull/921

Released as 2.13.0, please try it.


disable two factor authentication, i can no longer login as admin ph7cms .. how can I log in as admin now?

Describe the bug
(a clear and concise description of what the bug is.)
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected Behavior
(a clear and concise description of what you expected to happen.)
Screenshots / Screencasts
(if applicable, add screenshots or screencast the scenario to help explain your issue the best you can.)

To deactivate two-factor authentication, go in the database to the admin account on your host and to isTwoFactorAuth put 0. You must have access to phpmyadmin from the database.


Hotfix - Do not display ad in inbox

Temporary fix for #209
Short description of what this resolves:
The inbox used to display a big ad on login.
Changes proposed in this pull request:
The ad is now hidden by default.

Test fail on some localization test:
Chrome Headless 80.0.3987.0 (Linux x86_64) i18n loader should load french i18n translations on a browser set to fr FAILED

However, it was already failing on 93d6a228a, so I'll assume that it's not my fault.

There appears to be no more checks on this pull request. Is there anything else that is required by the maintainers for this pull request to be merged?


Add annotation to manually specify project command line arguments. (Needed for AWS Lambda support)

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.
We are looking into how we can support adding a AWS Lambda Function to the DistributedApplicationBuilder. A Lambda function can be written as an executable or as a class library. The class library programming model being the more common approach.
The executable approach is not an issue for Aspire but for the class library we need to customize the execution arguments. Lambda functions coded as a class library are started with a host executable and the depsfile and runtimeconfig are overriden at startup. The class library is passed in as an argument to the host executable. For example if we had .NET project called "ClassLibraryLambdaFunction" that contained a Lambda function it would be executed using the following:
dotnet exec --depsfile ./ClassLibraryLambdaFunction.deps.json --runtimeconfig ./ClassLibraryLambdaFunction.runtimeconfig.json ../../../../AspireExtensions/LambdaHost/Amazon.Lambda.RuntimeSupport.dll ClassLibraryLambdaFunction::ClassLibraryLambdaFunction.Function::FunctionHandler

Having this configured in the launchSettings.json file by the user is not practical and as part of an AddAWSLambdaFunction method I want to be able to setup all of these command line arguments for the user and return a LambdaProjectResource that is a subclass of ProjectResource.
Describe the solution you'd like
When adding project to the DistributedApplicationBuilder you can only specify the launchSettings profile name for configuring how the project should be started. I would like to propose adding a LaunchSettingsOverrideAnnotation annotation where all of the command line arguments for the "dotnet" command can be specified. The ApplicationExecutor would look for the annotation and if exists use it for setting up the parameters for the process.
Additional context
I'm happy to contribute this work if the team agrees on it.

@normj - have you considered making the "class library" dotnet run-able? This can be done by adding MSBuild logic to set

RunCommand
RunArguments

See https://github.com/dotnet/sdk/blob/f7a5c4e3dc7f7ac35a2684192413530a43877a05/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets#L1111-L1171
These MSBuild properties are used by dotnet run and by VS (and thus by the Aspire AppHost) to launch projects.
In .NET 9, we added functionality to allow MSBuild <Target>s to set these properties, so you can run any logic to determine these values. See Extend dotnet run to invoke a run-command-producing Target (dotnet/sdk#42240).

@eerhardt That is an interesting idea. If this was launched via the IDE would the IDE attach the debugger to it?
I do have the challenge that within a class library there could me multiple Lambda functions that need to be started up separately with different argument to identity the .NET method to call. Imagine in an Aspire AppHost the same project being added multiple times to the distributed application but with a different "handler" string that identifies what method to call. Maybe what I could do is have the MSBuild targets for running the class library look at an environment variable that the Aspire AppHost sets on the process. I'll play around and see what I can do.

If this was launched via the IDE would the IDE attach the debugger to it?

Yes. That is my understanding (although I have much less experience in the IDE tooling parts).
Look at the '$(UseAppHost)' != 'true' path:
https://github.com/dotnet/sdk/blob/f7a5c4e3dc7f7ac35a2684192413530a43877a05/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets#L1134-L1138
        <RunCommand Condition="'$(RunCommand)' == ''">dotnet</RunCommand>

        <_NetCoreRunArguments>exec "$(TargetPath)"</_NetCoreRunArguments>
        <RunArguments Condition="'$(RunArguments)' == '' and '$(StartArguments)' != ''">$(_NetCoreRunArguments) $(StartArguments)</RunArguments>
        <RunArguments Condition="'$(RunArguments)' == ''">$(_NetCoreRunArguments)</RunArguments>

This is basically the same thing you have. dotnet exec <some .dll>

@davidfowl @eerhardt Has something changed with the IDE integration with Aspire. I my previous hack of using the launchsettings.json to configure a class library to be runnable fails. It shows running in the dashboard but I know it must have failed quickly and the PID is 0 in the dashboard. When I run this AppHost from the commandline dotnet run. I get the following error which I'm pretty sure I didn't get before but not a hundred percent I tried before.
2024-12-05T18:06:58.8810000
 Unable to run your project.
2024-12-05T18:06:58.8810000
 Ensure you have a runnable project type and ensure 'dotnet run' supports this project.
2024-12-05T18:06:58.8810000
 A runnable project should target a runnable TFM (for instance, net5.0) and have OutputType 'Exe'.
2024-12-05T18:06:58.8810000
 The current OutputType is 'Library'.

@eerhardt I did try your trick of setting the RunCommand and RunArguments instead of relying on the launchSettings.json file and that got things working for running the AppHost outside of the IDE but within it fails like I described above.

cc @vijayrkn @tlmii

The only thing that has changed around that area (that I know of) is the dotnet run functionality that @baronfel added in 9.0 -
[release/9.0.1xx] Extend dotnet run to invoke a run-command-producing Target (dotnet/sdk#42987)
Don't forward along binlog arguments to runnable applications (dotnet/sdk#43430)

You can reproduce the error using my Lambda Aspire proof of concept (POC). It doesn't require an AWS account or credentials to run. The POC was made back in September and using a class library worked using the launchsettings.json file. We are picking the project back up now turning the POC into a real product and now using the latest bits the class library no longer seems to work.
To repo:

Clone https://github.com/normj/LambdaAspirePOC
checkout branch classlibrary-failure
In VS launch the AppHost
Notice the PID for ToLowerLambdaFunction project resource is 0 and there is nothing written to the logs. My guess is Aspire didn't even try to run the project because the output type was not an executable. Similar to the error we saw when using dotnet run complaining about the output type. "A runnable project should target a runnable TFM (for instance, net5.0) and have OutputType 'Exe'."

What is supposed to happen is the ClassLibraryLambdaFunction project has a profile in the launchSettings.json that provides the actual executable entry point that should be used.
{
  "profiles": {
    "LambdaRuntimeClient_FunctionHandler": {
      "commandName": "Executable",
      "commandLineArgs": "exec --depsfile ./ClassLibraryLambdaFunction.deps.json --runtimeconfig ./ClassLibraryLambdaFunction.runtimeconfig.json ../../../../AspireExtensions/LambdaHost/Amazon.Lambda.RuntimeSupport.dll ClassLibraryLambdaFunction::ClassLibraryLambdaFunction.Function::FunctionHandler",
      "workingDirectory": ".\\bin\\$(Configuration)\\net8.0",
      "executablePath": "dotnet"
    }
  }
}

In the AddAWSLambdaFunction extension method you can see I set the launch setting profile. https://github.com/normj/LambdaAspirePOC/blob/classlibrary-failure/AspireExtensions/Aspire.Hosting.AWS.Lambda/LambdaExtensions.cs#L22
If you make the ClassLibraryLambdaFunction the startup project you can confirm the profile actually starts up till you get an expected error about "Invalid URI". Through the AppHost it makes sure that URI is correctly set up.
Keep in mind my ultimate goal and the original reason for this issue is I want to get rid of dealing with the launchsettings.json file and from my AddAWSLambdaFunction extension method tell Aspire all of the command line arguments needed to run the class library.

Keep in mind my ultimate goal and the original reason for this issue is I want to get rid of dealing with the launchsettings.json file

The best way to do this is to make the project dotnet run-able. We did just that for Azure Functions support in 9.0. Check out:
https://github.com/Azure/azure-functions-dotnet-worker/blob/6338dc2e08d04a78956dd48dd6738888ab215bde/sdk/Sdk/Targets/Microsoft.Azure.Functions.Worker.Sdk.targets#L83-L90
  <!-- This target is used to set up the run arguments for the function app, supporting `dotnet run` -->
  <Target Name="_FunctionsComputeRunArguments" BeforeTargets="ComputeRunArguments">
    <PropertyGroup>
      <RunCommand>func</RunCommand>
      <RunArguments>host start $(RunArguments)</RunArguments>
      <RunWorkingDirectory>$(OutDir)</RunWorkingDirectory>
    </PropertyGroup>
  </Target>

You don't even need to use the ComputeRunArguments target if the RunCommand and RunArguments are static - you can just set the properties directly in a .targets file.

@eerhardt I tried making it runnable basically taking what is in the launchsettings into the run properties
  <Target Name="_FunctionsComputeRunArguments" BeforeTargets="ComputeRunArguments">
    <PropertyGroup>
      <RunCommand>dotnet</RunCommand>
      <RunArguments>exec --depsfile ./ClassLibraryLambdaFunction.deps.json --runtimeconfig ./ClassLibraryLambdaFunction.runtimeconfig.json ../../../../AspireExtensions/LambdaHost/Amazon.Lambda.RuntimeSupport.dll ClassLibraryLambdaFunction::ClassLibraryLambdaFunction.Function::FunctionHandler</RunArguments>
      <RunWorkingDirectory>$(OutDir)</RunWorkingDirectory>
    </PropertyGroup>
  </Target>

and it works when I run the AppHost from the commandline outside of the IDE. But when I run it from the IDE I get the following error complaining about the project being a class library.
fail: Aspire.Hosting.Dcp.dcpctrl.ExecutableReconciler[0]
      run session could not be started: IDE returned a response indicating failure      {"Executable": {"name":"ToLowerLambdaFunction-ccvsfwhd"}, "Reconciliation": 2, "Status": "500 Internal Server Error", "Body": "A project with an Output Type of Class Library cannot be started directly.\r\n\r\nIn order to debug this project, add an executable project to this solution which references the library project. Set the executable project as the startup project."}

@tlmii Were you able to try by POC and reproduce the problem? Let me know if I need to create a simpler repo case.

@normj I can repro the problem with your repo above (thanks for making that easy!) and I can see what appears to be the issue, including the change that caused it.
Trying to track down the reason for the change (it appears to have been a bug fix in coordinating profile information between DCP and the IDE) to determine the best path forward. More soon...

@tlmii Thanks for the update

We're pretty sure we've identified the fix and have the first of a couple PRs out needed to flow it through to VS. There's an issue with the API definition between DCP and the IDE that has been there for a while, but it was only exposed recently when another fix was made in VS to more closely adhere to the rules in the spec around the invocation arguments.
At the moment I'm not aware of a workaround. @karolz-ms would there be any way to force DCP to pass these same arguments so that VS effectively overrides them with themselves? Obviously it'd be a short term hack, but just until we were able to flow the real fix to a public/preview build?

Thanks for the update @tlmii. Trying to understand what is going on the PR. The arguments in being talked about in the PR are the commandline arguments specified in the launchSettings.json file? Looking at the spec and the code for Aspire.Hosting it doesn't look like the application model has been expanded for Aspire resources to be able to specify the command line arguments which is my ideal solution.

I think that @normj is right; there does not seem to be a way to override Executable invocation arguments in app host code. What Norm proposed originally (an annotation to override invocation arguments) makes a lot of sense to me.
@mitchdenny toughts?


Allow <newline> to escape the newline away

It's often desirable to use raw strings when declaring regular expressions. When raw strings are used, the standard Rust escapes are not in effect.
The regex syntax defines its own escapes, which are especially catered for escaping the regex puncuation characters, and some other characters that are difficult to include in the source code as-they-are. Raw strings are useful, because we don't have to double-escape the regex escapes, and can express characters like " freely.
However, because we can't use Rust escapes, we can't escape newlines either, like we can with normal strings:

Line-break characters are allowed in string literals. Normally they represent themselves (i.e. no translation), but as a special exception, when a U+005C character () occurs immediately before the newline, the U+005C character, the newline, and all whitespace at the beginning of the next line are ignored. Thus a and b are equal:

As far as I know, the regex crate doesn't have syntax that'd allow splitting the expression to multiple lines with escapable newlines: if there are newlines, they stand for themselves.
It would be nice to have an escape that allows that; backslash followed by newline character. It would help splitting raw string regexes to multiple lines for clarity. It would also help to follow coding conventions with regards to line length.
What do you think?

Btw. currently backslash followed by newline just throws a parsing error, so I think that implementing that escape would be non-breaking change.

Is there a reason why the x flag isn't suitable? See an example here: http://doc.rust-lang.org/regex/regex/index.html#example:-replacement-with-named-capture-groups and documented here: http://doc.rust-lang.org/regex/regex/index.html#grouping-and-flags

Ah, I see, my premise that there isn't a way to ignore newline was wrong. Thanks for the info!
The x flag seems to provide the functionality I was missing - and more.
I'd still argue that supporting the backslash newline escape would be good, because it's simple and intuitive to use (in the sense that Rust strings, and many other languages support the same feature). I'd consider it as an additional ergonomic bonus - it's immediately clear what it does, and it's syntactically lightweight.

That's not a bad point. I don't feel too strongly about it either way.

I made a pull request that implements the feature. No pressure to accept it if there's some controversy about it, or if it needs further thought, wider acceptance, review etc.

Quite a lot of time has passed. Any opinions on the <newline> enhancement? Others than @BurntSushi ? Is there other heavy users and/or contributors that could provide their input?

I can see that at least @Manishearth and @alexcrichton and @flying-sheep have frequently contributed here. What are your views on this?

(I only basically contribute rustups, I don't have strong opinions about the crate itself or understand how it works)

The implementation was trivial, it's just that if we want to have one-to-one correspondence with RE2's syntax, this change is against that goal because RE2 doesn't implement this escape. However, my argument is that supporting \ newline escaping is something that 1) is nice and ergonomic 2) average user would expect to work 3) doesn't break anything and doesn't cause any further ramifications.

I don't think a precise correspondence with RE2 syntax is a goal. I do think it is wise to be conservative and examine what other regex engines do. Do other regex engines support the type of newline escape being proposed here?
My concern is that we already have a solution to this problem using a technique established by several other regex engines (the x flag). Why add another?

Some other thoughts:

I believe the current PR (#108) supports escaped new lines by simply dropping them. Isn't this at odds with other implementations, where escaped new lines are treated as themselves?
Rust has support for line continuation in normal strings, and that seems like the thing that is desired here. If we add something similar to regexes, shouldn't it function like Rust's existing line continuation?

These goals do seem at odds with each other.
Another related issue is #93, which suggests we should permit more escape sequences.

Yes, they are at odds. The common theme in regex implementations seems to be that <newline> represents . In the normal Rust strings <newline> represents a null substring, it's simply dropped. This is for ergonomics, to allow long lines to be embedded in the source code. Of course, in raw strings, <newline> always represents <newline>, so the string is read as-is.
I was thinking in the lines of the following reasoning:

If in the regex crate, <newline> drops the newline, that's different from how most other implementations do. That's a slight inconsistency.
However, is there any reason to have <newline> to represent ? I don't think so. It seems to be simply the accepted default. I can't think any situation where it would be sensible to use <newline> to represent . If people want to write newline, they just write newline itself, or use the escape specially meant to represent newline.
Instead, there seems to be clear reason to have <newline> to represent a null substring; to be able to end lines without affecting the string contents. Raw strings are often used with regexes, so it's good for ergonomics to implement this. Because <newline> for  doesn't seem to stand for any useful purpose, it would be more valuable if used for this.

So yes, I think it should behave like Rust's existing line continuation. (Does the current PR have some inconsistencies with that? If it does, I'm happy to fix it.)
Another way to think about it, is that when using raw strings, Rust basically delegates all decisions of escape sequences and such to the library that processes the string. If we want to give the users a "rusty" and ergonomic experience, we've got to re-implement ourselves some of the features Rust strings have. Of course, only those that make sense in the context of regexes.

However, is there any reason to have  to represent ? I don't think so. It seems to be simply the accepted default. I can't think any situation where it would be sensible to use  to represent . If people want to write newline, they just write newline itself, or use the escape specially meant to represent newline.

I feel like you're papering over (1). You're advocating for changing what is today a loud failure mode to a silent failure mode if someone is trying to port a regex over from another engine.

Instead, there seems to be clear reason to have  to represent a null substring; to be able to end lines without affecting the string contents.

I don't think that's a clear reason at all. In particular, the x flag already allows one to do this. You have of course pointed out cases where the x flag isn't quite ideal, for example, when one wants to match on significant whitespace. This makes the need for newline escapes a bit more niche IMO.

So yes, I think it should behave like Rust's existing line continuation. (Does the current PR have some inconsistencies with that? If it does, I'm happy to fix it.)

Indeed. Rust's existing line continuation drops the \n and all proceeding whitespace up to the first non-whitespace character.
To sum up, I think my primary concern here is that dropping escaped new lines will create a silent divergence from other regex engines. If we diverge, I'd rather it be in the form of an error returned to the caller. Alternatively, we could diverge if we thought it was important to do so. I'm not quite entirely convinced it's worth it in this case.

Ah, I see. That's indeed a valid concern.
To me, the possibility that regexes that would be ported over to rust contain \<newline> seems very small, since it doesn't actually do anything worthwhile. (And fails to compile in some, like in RE2.)
Also, I have encountered quite a many large (not necessarily complicated) regexes that would greatly benefit from the simple way to "reformat" them a bit. (The x flag does that indeed, but it's visually heavier, eating away the niceness gained.) That's why I keep thinking this would be a worthwhile feature.
All in all, to me, the cons seem to be quite small, and pros large enough to outweigh them.
P.S. Thanks for pointing out the inconsistency with Rust's strings. That brings to mind: which would be more desirable kind of functionality for regexes, just dropping the newline, or doing it the Rust way? And again, then there would be a question about consistency with Rust's conventions. But that's a minor point compared to the main one.

I like consistency better. Without it, you end up having to dedent your regex.


Update obsolete varargs example that uses __va_argsave

The portable syntax has been supported on the main platforms since 2.067 or earlier.

OK :)

Thanks!


iroh::net::Endpoint::close should not be fallible nor async

I was advised to open an issue in https://github.com/n0-computer/iroh/discussions/2860. The problem is that Endpoint::close is async and fallible.
Fallible. I investigated, the method cannot fail unless sending Shutdown to the Actor fails, but this isn't actually a failure: this send can only fail if all recievers are dropped, and the receiver is owned by Actor::run. Logically, if this method fails, the socket is already technically shut down.
Further, the Actor::run method cannot fail except via panicking or if the network monitor fails to initialize. It seems clear to me that having initialization code fail after the MagicSock is initialized is a different bug: either the error shouldn't stop the entire Actor, or the fallible code should have happened before the initializer returned Ok. The only other way this function can return is by receiving ActorMessage::Shutdown.
Also, if the method fails, self gets dropped anyways, so there's no way to handle the error.
Async. Quinn's API for closing endpoints is better, and I think would cleanly apply to Iroh: close can be called from anywhere and wait_idle can be called from my main server task to gracefully shut down.
It's also unclear what happens if you cancel the close. Does the endpoint stay open? Does it close itself in the background?
Also, it's strange that Connection::close is sync, and that works just fine.

Also, it's strange that Connection::close is sync, and that works just fine.

IMO this is a pitfall: If you call close, then drop the Endpoint, you might not have actually closed the connection gracefully, because the close frame could be lost in transit.
Endpoint::wait_idle (is badly named and) makes sure that there's no more open connections (including connections where we're just waiting for an ACK for a close frame).
I see a major footgun in having iroh_net::Endpoint::close be synchronous without a call to quinn::Endpoint::wait_idle, as then people will expect this to work and just drop the endpoint. And now connection closes are flaky.
IMO it makes sense that a call to Endpoint::close, which does things on the network, is async.

It's also unclear what happens if you cancel the close. Does the endpoint stay open? Does it close itself in the background?

The close call may or may not go through.
It will close in the background iff you don't drop the Endpoint before it manages to finish ACKing.

The cancelation story is weird and is why I don't think having this method be async makes sense. If you call close on an Endpoint, and cancel the future midway through (during the wait_idle period), the Endpoint is going to be in an inconsistent state. The server will already be disabled but some connections will still be alive. The state transition from "operational" to "closing" happens in the first poll; after this point the server stops accepting new connections and existing connections are already in the process of being closed. All tasks that were working with this connection will stop themselves now (LocallyClosed error), because they see the graceful shutdown has started. But here msock.close will never get called, just dropped later on (this may lead to a task / memory leak depending on the implementation; I haven't checked).
As a user of the library, I have some task that is accepting connections on this endpoint, and it's conceptually the "manager" of the endpoint. When my application receives a command to shut down, I need to do so gracefully for a time, and then forcefully. Right now, calling close does accomplish this goal, for the reasons above, but the fact that it works feels like an accident rather than by design, and (I haven't tested, but) it might be holding on to the socket, preventing rebinding. The only safe way to do it is to implement an out-of-band stop signal that goes to my "manager" task.
I propose making two methods, one which synchronously transitions the endpoint to "closing", and a second that waits for the endpoint to actually be closed. If this were the case, my shutdown command would call the synchronous method, then the "manager" task, as part of its orderly shutdown, would wait for the connection to be fully closed before exiting.
It seems like we are in agreement that the method shouldn't be fallible, at least. I also think it's very strange for a cheaply-cloned object to move self in an async method. It should probably take &self instead: if the logic of the shutdown process doesn't work with &self, then it also doesn't work with clones of the object.

Right now, calling close does accomplish this goal, for the reasons above, but the fact that it works feels like an accident rather than by design

Gracefully shutting down is exactly what the Endpoint::close method is designed for.

I propose making two methods, one which synchronously transitions the endpoint to "closing", and a second that waits for the endpoint to actually be closed. If this were the case, my shutdown command would call the synchronous method, then the "manager" task, as part of its orderly shutdown, would wait for the connection to be fully closed before exiting.

We are intentionally avoiding exposing a synchronous Endpoint::close method, because most people will just not know that they need to have another "manager" task that waits for orderly shutdown before dropping the Endpoint.

Well, ultimately I think that this is a minor inconvenience (Iroh can easily do something, but doesn't expose the API, but I can semi-easily recreate the behavior), so no need to push on it. I've removed the async portion from the issue description.
I do think the fallibility issue, move-self semantics issue, and cancel safety issue still stand, but feel free to close this if the team disagrees.

The move-self is odd because Endpoint is Clone anyway, so it doesn't really achieve anything.  I think it was put in there as a guidance more than anything else.
I also think the fallibility analysis is interesting.  I think normally this would never fail, unless there was a bug in the implementation already.  So the fallibility is only there to catch implementation bugs.  Question is whether you want the application to know there was an implementation bug or not?  It can't do much about it, it may sometimes result in a bug report but I guess in the vast majority of cases that wouldn't be the case.
I guess cancel-safety needs to be documented clearly so users can understand the semantics.

Question is whether you want the application to know there was an implementation bug or not?

I would think that anyone interested in detecting implementation bugs would have a panic handler set up to catch them.


S3 Ingestion from non-default endpoints

Description

S3InputSource presently provides an option to override the default S3 credentials which is useful to read from different buckets, but it has to be in the same endpoint. This PR adds functionality to specify a different endpoint and associated client properties as part of the S3InputSource spec. This can be helpful for operators looking to migrate data from one store to another. This is implemented only for S3 at the moment, but we can support other cloud providers as a followup.
Key changed/added classes in this PR

S3InputSource

This PR has:

[x] been self-reviewed.
[x] added documentation for new or modified features or behaviors.
[x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[x] been tested in a test Druid cluster.

@a2l007 Approved. Looks like there is a test failure in intellij inspections.

Thanks @maytasm for the review. I've fixed the build failure.
@cryptoe Did you have any other comments before this is merged?


[Resolves #101] Pass-thru Shenzhen Crashlytics ENV vars

This allows the environment variables to be used in place of some parameters.

Perfect, thanks for also providing tests :+1:


add details of 123377 to thompson Creek

[ ] We should add  a note that the site was revisited in 2022 (upstream of 198066 and downstream of 123377), add the site to the hab con spreadsheet (leave it in 2022 though) and summarize the site that was done there (surveyed in a downsteam direction from the bridge (123378) to the start of the agricultural fields) and add the UAV imagery.
[ ] Note in the background about Fishpan Lake
[ ] Map link should be switched to this one manually https://hillcrestgeo.ca/outgoing/fishpassage/projects/bulk/FishPassage_093L.114.pdf
[ ] note that downstream of lowest culvert was surveyed to the confluence with bulkley side channel
[ ] Have a peak at the above map when writing the following detail in the background. Need to note that the main flow of the stream is actually through an open bottomed culvert at 123376.
[ ] For upstream of 123378 - Add the culvert summary table and photos for 123376.  Also add 123381 (or 123380) - not sure which one is in the system as the culvert but it should be noted in the text that the other one doesn't exist
[ ] Note that surveyors could not access 123381 or 123380 as they were on private land behind gates however these sites are not expected to have much influence on connectivity in the watershed as the main body of flow in Thompson Creek actually flows to the east of there and through the channel that connects with 123376
[ ] note that 123382 was also assessed and add the culvert summary

Can you post links of the UAV imagery you did last year so I can put in memo?

We should definitely pull the recommendation to move that stream to the north.

Text to potentially include:
The lidar shows evidence of extensive machine work to prevent the channel from flooding the rangelands that are on the floodplain of the Bulkley River as well as to drain the water that appears to inundate the wetlands to the south of the property.  During field assessments it was noted that there was significant clearing of mature cottonwood forest adjacent to the side channel of the Bulkley River adjacent to 198066.
Recommendations (in addition to other ones that still make sense):

work with landowner and regulators to develop a plan for removing range area from sections of the floodplain, re-establishing riparian forest adjacent to Thompson Creek as well as the Bulkley River and side channels. Additionally, retention of water within floodplain wetland complexes should be encouraged.
Electrofishing above and below crossing 123377 and tagging with Passive Integrated Transponders (PIT tags) to gather baseline data before a potential replacement of the structure, track the movement of fish in the system over time and to give an indication of whether anadromous species are able to ascend through the rangelands adjacent to the Bulkley River floodplain.

Other notes to add

[ ] in 2022, in addition to surveying the wetted channel from the bridge (insert PSCIS id) to where the stream directs to the south and the agricultural fields begin, surveyors walked the north edge of the field towards the Bulkley river for (insert approximate distance from track) then circled back south through the shrub dominated areas to the hay fields to scope for evidence that a defined historic channel was located in this area.  Although some low lying areas were observed no defined channel was located which is not surprising since this area is all within the floodplain of the Bulkley River so channels/wetland complexes would historically shift throughout the floodplain based on beaver activity and flows in both Thompson Creek and the Bulkley River.

[ ] Fishpan Lake size (whse_basemapping.fwa_lakes_poly) should be mentioned along with its location in relation to the crossings we assessed. in the last PR it said it was downstream of 123383 but that site is not discussed elsewhere and really it is upstream of that crossing.  it is the job of the GIS tech to take complicated settings and simplify them into a relevant context for the user.
[ ] when talking about areas it is best to include general locations of things (ie. east of Highway 16) vs just upstream of pscis crossing ids alone as it is much easier for the reader to understand where we are talking about without them needing to leave the text and reference figures and external maps
[ ] need description of where hwy 16 crossing is in site location section
[ ] when possible we will now always reference chris_culvert_ids to tie our work to MoTi database IDs.
[ ] details of the OBS on highway 16 belongs in the section about habitat upstreawm of Walcott road culvert and details about the crossing way up by the lake should go in section about area above walcott or section about hab upstream of the hwy CBS.
[ ] photos should be referenced in order of appearance. First photo referenced is the first photo on the page.
[ ] use functions to pull data from the habitat_confirmations.xls spreadsheet vs handbombing and populate missing data from photos. Add a disclaimer to the comments when data needs to be populated from photos. site2 and site3 have no info on how big the channel is and gradients are not included or not correct while the data is sitting there.  there are numerous examples of functions that pull out the data without needing to rely on fpr_my_habitat_paragraph

closing in favour of #47


Mutations from graphql file not being generated in a mutations package.

Not sure what is going on, just started using apollo-android.  I noticed that when I added my graphql file with a mutation the mutation class was made outside of a package preventing me from accessing it.  Not sure if this is something I did wrong or a bug in the gen.

Did you put your mutation file inside of graphqlfolder nested inside folders of what you wanted package to be? Usually this is due to not having proper package folder inside of your GraphQL folder. See sample in repo ☺

@digitalbuddha You are a stud!  Thank you, I completely overlooked that.


Allow non-superusers to run ALTER TABLE REROUTE commands

Problem Statement
In CrateDB Cloud and other security-sensitive setups, database admins may not routinely have access to the crate superuser account.
The ALTER TABLE ... REROUTE MOVE SHARD commands are useful to move around "hot shards" as described in the documentation.
Currently these operations are not allowed even when a user account has AL and DDL permissions at cluster level.
Possible Solutions

Allow the operations for accounts with certain permissions so that the task can be delegated and run without connecting as crate
Cover REROUTE use cases in some other way so that manual rerouting is not necessary

Considered Alternatives
Get an admin with access to the CrateDB nodes to connect locally as crate and run the required commands.

Also related https://github.com/crate/crate/issues/11283

TBD which option to use:

Let users with AL permission execute it
Go alternative path and support GRANT role crate to ..., to grant users all superuser privileges
Others?

Imho, users with AL should be able to execute this. The ability to inherit superuser to a role/user, would be a way to do that, but I believe explicit granting of AL should also work.

As discussed, we should allow ALTER TABLE <table> REROUTE... for DDL privs on the table.
Since you can already do other admin actions with DDL on a table (increase, decrease shards, change settings that affect the shard distribution), it makes sense to also allow REROUTE.
We decided also to treat this as a bug, as according to our current docs, we allow users to DDL to perform any ALTER TABLE operation.

Thank you @hlcianfagna for reporting this. It has been addressed a bug fix and will be available with the next hotfix release.


AnimatedGIFPanel_SPIFFS

Hey when I try to verify the code from the example I get the error 'class fs::File' has no member named 'path'
does anyone have an idea?

 They just haven't had the time to learn


Unhelpful error message when defining a value

I found an unhelpful error message when I tried to create a variable/value whilst not remembering the grammar:

That's a tough one. The unbox operation (not visible) is inferred by PreTyper to fix the otherwise syntax incorrect program.
The problem is that sometimes this is the desired behavior (for instance when the result of addOne would be a function).
Do you have a suggestion on how to fix this?


Need permission

Describe your bug here.
I need permission in order to even use Psych engine for some reason. I was just working with 5.0 then with 5.1 It just stopped working and the actual game uninstalled itself.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Yes I am currently changing characters.

Was there any errors on the console while compiling? Show me the command prompt/whatever you used lime test windows on.

Windows defender moment

Fixed it! Just had to restart computer!

Then close the issue lol.


Optimizing gas for swaps

Background
Currently with SwapExactAmountIn the gas goes over 50M with ~1K liquidity in a pool with over 100 positions initialized. The reason why the cost is so high is becasue we are crossing a lot of ticks. We can have more liquidity in ticks so that we dont cross tick with smaller swaps as well as figure out a way to optimize out swap functions to be more gas efficient
Suggested Design
@ValarDragon suggestion;

The first thing that comes to mind for me, is measuring gas cost for just getting a pool from state with all the spread accums / uptime accums in it.

Theres one trivial extra GetPool call we can eliminate from all swaps by making compute swap methods take in a pool instead of poolID
EDIT: I think its maybe two GetPools eliminatable, including the one in updatePoolForSwap? This one not as clear

Similarly we can use the multi-send api's from bank to optimize the final fund transfers

Acceptance Criteria

Swap functions should cost a lot less gas (numbers tbd)

Closing this for now, were revisiting this problem lately under a different lens


D&B change-requests

Description of change
The following endpoint was added to the Data Hub API for submitting change requests to D&B:

POST /dnb/company-change-request/

The endpoint requires a json payload with a valid duns_number for a company that exists in Data Hub and requested changes like so:
{
   'duns_number': '123456789',
   'changes': {
       'website': 'example.com',
   },
},

Checklist

[x] If this is a releasable change, has a news fragment been added?

Explanation
A news fragment is required for any releasable change (i.e. code that runs in or affects production) so that a corresponding changelog entry is added when releasing.
Check changelog/README.md for instructions.

[ ] Has this branch been rebased on top of the current develop branch?

Explanation
The branch should not be stale or have conflicts at the time reviews are requested.

[ ] Is the CircleCI build passing?

General points

Other things to check

Make sure fixtures/test_data.yaml is maintained when updating models
Consider the admin site when making changes to models
Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

This got too long for my liking. I am closing it and would put up at least 2 separate PRs for the same work.


Add Description for bind syscall in eBPF and Interpret IP/Port in Userspace Go Program

Problem Statement
At the moment, our eBPF probe for syscall monitoring doesn't offer a comprehensive description for the bind syscall. When this syscall data is conveyed to our userspace Go program, the IP and port details are not interpreted in a user-friendly manner.
Expected Behavior

When the bind syscall is executed, the eBPF probe should capture all relevant details.
The userspace Go program should then process and present the raw IP and port information in a more intuitive format.

Current Behavior

The data related to the bind syscall that's captured by eBPF lacks an in-depth description.
The raw IP and port details are passed directly to userspace without interpretation, complicating the user's understanding.

Steps to Reproduce

Deploy the existing monitoring system.
Initiate a bind syscall (this can be done using various networking tools or by running appropriate software).
Examine the logs or outputs from the userspace Go program.

Solution Proposal

eBPF Changes: Improve the eBPF probe to aptly capture and describe the bind syscall. This encompasses capturing details like the IP address, port, and any other relevant information.

Go Program Changes: Update the Go program to:

Decode the raw IP and port information.
Translate it into a user-friendly format, for instance: <IP_ADDRESS>:8080.
Display or log this processed data for the convenience of the user.

Additional Context
Implementing this feature will greatly enhance the usability of our monitoring application. With clear and interpretable connection details, users can more easily understand and diagnose potential networking issues.

added event description and IP and family extration in kernel program
added event description and families , IP and port , interpertation
added event translation in the main
@AnamikaSanjay


(Neo)vim configuration

Hi,
I've been able to get the settings for (Neo)vim for the Fortran Language Server using
LanguageClient
let g:LanguageClient_serverCommands = {
    \   'fortran': ['fortls', '--symbol_skip_mem', '--incrmental_sync', '--autocomplete_no_prefix']
    \ }

Is it possible to add them to the Wiki/ Readme? Btw. I think that 'incrmental_sync' should be named
'incremental_sync' or? Atleast the help/ vscode repository both state that way.

Thanks for the contribution! I have added a page to the wiki for using the language server with vim. I also corrected the typo you mentioned. The server will also continue to accept the old spelling.


doc(cn): add request-validation doc

What this PR does / why we need it:

Add plugin of request-validation Chinese doc.

this PR is duplicated with https://github.com/apache/incubator-apisix/pull/1932

@shuaijinchao do you have time to take a look at this PR?

I took a look, #1932 is still the old document translation, this pr is based on the latest master branch document translation. about #1933 @membphis

I took a look, #1932 is still the old document translation, this pr is based on the latest master branch document translation. about #1933 @membphis

hello, I don't understand what you mean by the old document, what is the difference?

@shuaijinchao You can look #1926

@scaat  Generally, you need to request this job before dealing with this issue #1882. I think you should update on the #1932 basis after the #1932 merger instead of a new PR.

@scaat many sorry for this. I think we can close this PR.
and please leave a message when you want to fix one issue next time.


istructsmem: errors wrap

Motivation
Now, in current architecture
In the current implementation, error wrapping has the following disadvantages:

the text of wrapping errors often repeats the errors being wrapped, which just clutters the text without adding any new information
the text of the wrapping error may be located far from where it is used, which makes code inspection difficult

Proposal
All error wrapping is performed uniformly according to the scheme:
enriched-error = wrapped-error ’: ’ enrichment
The enrichment should include only new information, things that were not yet in the wrapped error.

This work was started during issue #2785.
Commits from PR #2823

use enrichError: ErrNameNotFound 7d64a77
use enrichError: ErrInvalidName 0cee05a
use enrichError: ErrIDNotFound cc83f02
use enrichError: ErrMinOccurs and ErrMaxOccurs 8492f02
use enrichError: ErrFieldIsEmpty / ErrFieldMissed a8fc13d
use enrichError: ErrInvalidVerification 7fe5e05
use enrichError: ErrCUDsMissed 4b32e72
use enrichError: ErrRawRecordIDRequired f9888ba
use enrichError: ErrUnexpectedRawRecordID f70d9b5
use enrichError: ErrWrongRecordID / ErrWrongRecordIDTarget 6515370
use enrichError: ErrUnableToUpdateSystemField 4337f50


Bad request error when clicking the Archived button in the Blueprints page

See screenshot:

Fixed in #119


Compiler error: call to 'print_to_stream' is ambiguous

Environment
toml++ version and/or commit hash:
501a80e
Compiler:
Apple clang version 13.1.6 (clang-13<IP_ADDRESS>.5)
Xcode 13.4.1 (13F100)
C++ standard mode:
Compiler default (i.e. GCC_C_LANGUAGE_STANDARD Xcode project env var defined as empty)
Target arch:
arm64
Library configuration overrides:
Nothing
Relevant compilation flags:
N/A
Describe the bug
I'm seeing the following compiler error when building most of the examples, including the parse_benchmark target:
In file included from ~/Sources/third_party/toml/tomlplusplus/tomlplusplus/examples/toml_to_json_transcoder.cpp:9:
In file included from ~/Sources/third_party/toml/tomlplusplus/tomlplusplus/include/toml++/toml.h:68:
~/Sources/third_party/toml/tomlplusplus/tomlplusplus/include/toml++/impl/path.inl:242:5: error: call to 'print_to_stream' is ambiguous
                                impl::print_to_stream(os, component.index());
                                ^~~~~~~~~~~~~~~~~~~~~

Steps to reproduce (or a small repro code sample)

Generate the project with the examples enabled:

cmake -B ../build --install-prefix=$HOME/Sources/third_party/toml/tomlplusplus/install -G Xcode -D BUILD_EXAMPLES=ON

Open the tomlplusplus.xcodeproj Xcode project.

Select the ALL_BUILD target and build.

Additional information
Not pretty, but I've worked around this by type coercing the index value:
impl::print_to_stream(os, (uint64_t)component.index());

Ah, interesting, thanks for the report! I detect ARM shenanigans. Time to bust out the RPi and give it a look.

Thanks for the quick response!
But I don't think this is arm specific. I see the same problem when building the x86_64 slice of a universal Apple Silicon binary.
It's probably related to the version of clang that Apple included with Xcode. It used to be that Apple's versioning obscured the underlying LLVM version. But according to the Xcode Wikipedia page, it is using LLVM 13 and clang 13.1.6. So at least for the moment Xcode's versioning and LLVM's match.
Have you tested with clang 13?
Of course I don't want to discourage you from breaking out your RPi ;-) Those are great little systems. I have way too many of them.

Have you tested with clang 13?

Yup, I test with clang 13 on my x86-64 dev machine. I think you're right in that it's down to Apple-clang. I've just identified some weirdness and am about to push some tentative fixes :)

Right, I think that's got it. If you're still having issues feel free to re-open this and I'll revisit it again tomorrow.

That fix works! Thanks so much for fixing this so quickly! It's much better than my hack work around.
Hopefully this comment doesn't reopen the issue.
On the RPi sub-thread, we've got a PiHole too! And Home Assistant, and OctoPi, and nodejs-poolController (all on their own RPis). Great stuff...


Finalize selected wireframes in collaboration with business area

Describe the task
We need to collaborate with IRC and finalize the certain screens, through the spreadsheet and within the wireframe. Collaboration will happen in Giraffe Collab as well as through the SME channel. Notes will be captured and shared with the group. There may be need to collab with Moose and this ticket can get quite big
Acceptance Criteria

[x] Verify fields for Production Data
[x] Verify workflow for supplementary/corrected reports with John
[x] Verify fields for Non-attributable emissions
[x] Verify fields for captured emissions
[x] Verify fields for Operation information (part 1 & 2)
[x] Verify fields for facility information
[ ] Clarify Allocations of Emissions - 100%, where to display this (emissions summary?)
[ ] Verify fields for verification
[x] Verify fields for Emissions Summary
[x] Verify fields for Annual report section 2
[x] verify LFO report data

Additional context

Add any other context about the task here.
Or here

'Verify workflow for supplementary/corrected reports with John' completed as part of #176

Need to verify BCGHG ID column needed or not in reporting

Updated Person responsible, Non-attributable emissions, Captured emissions, production data wireframe. Waiting on BA to confirm the wireframe implementation

Verification - This has been put on hold until we verification templates are made.

Allocation of emissions is also put on hold till we receive direction from IRC about where it will be. LFO Report Data has been converted to Operation Reporting Data.

@suhafa I am prepping the emails now so will close this ticket.


Unknown named module: 'react-native-fetch-blob' when doing npm install on specific branch

I have forked the project and created my own branch
However when I try to perform npm install on my own branch like:
npm install https://github.com/9gag-open-source/react-native-fetch-blob#feature/1-9gagReactNativeIntegration/
It doesn't work. When I start the app, it just show the error
Unknown named module: 'react-native-fetch-blob'
I noticed that there's a difference in node_modules/react-native-fetch-blob folder. if I just install it normally, I get everything inside the project's src folder. However, if I want to install with the command above, I get the project's root. Is there any possible ways to do npm install on a specific branch?
Thanks!

I'll close this issue, as I have tried to replaced with the package.json in src folder to root folder


Remove ignoreUnsupportedConstraintTraits from integration test models

Now that constraint traits are supported in server SDKs (with some
corner case caveats, see
https://github.com/awslabs/smithy-rs/issues/1401), we can remove
ignoreUnsupportedConstraintTraits from the codegen config of the
integration test models.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Worth implementing a check in ValidateUnsupportedConstraints that aborts codegen if the flag is enabled but all constraint traits in the model are supported. I'll do this in a separate PR, since it's a breaking change that will have to wait to be merged in until the next merge window.


Option to remove default Touch Bar controls but leave it enabled for plugins

Please make these buttons optional. I'd like to either create a plugin myself, or use one of the available Touch Bar plugins, and have access to all available space.

via https://github.com/microsoft/vscode/pull/70174

Verification: you can hide individual commands (e.g. "workbench.action.debug.start") from the macOS touchbar via "keyboard.touchbar.ignored": [] setting. Possible IDs:


Is It possible to implement data-picker in column of Reactabular ?

Hi
Is It possible to implement data-picker in column of Reactabular ?

See Implementing Custom Cell Operations. You can do whatever customizations you need through that interface.

Could you plz provide some example.?

Can you link to the data picker you are familiar with? I'm not exactly sure what you need.
The simplest way for you to get started would be to copy the contents of dropdown to your project. Rename that to datapicker or such and attach it to some cell. Once you get that working, you can try something more custom. Replace that render() method with something else. See the other editors for inspiration. It should be doable. :+1:

Hello Sir,
Please find the link
http://chrisharrington.github.io/demos/react/date-picker/
http://vitalets.github.io/bootstrap-datepicker/

@ranjan653 If you can integrate one of those within the interface I provide that should work.

I am trying to implement, In case of react it is very difficult for me. But in Jquery it is easy. You are familiar with react that's why I am asking you. I am new to react just started development from this month.
If you will be part of this it like
http://chrisharrington.github.io/demos/react/date-picker/
Then would be grateful.
Thanks

I can understand it should be like editors.dropdown==editors.datepicker...But

I'm too busy with paying work at the moment.
If you can copy one of the existing editors and get it work first, that's a good starting point. After that you have to render the date picker you want through it.
The simplest way would be to go through the standard solution. Just set input type to date and let browser handle it. This won't work for old browsers though a polyfill may help.

Sir,
That should be mention in Reactabular.min.js.
I am only using Reactabular.min.js to achieve editor.input . So in which file i will write the code.

@ranjan653 You can have a custom editor amongst your application code. All you need to do is to follow the interface as instructed at the README. A cell operation receives value and onValue through props. The former contains the value you should show at the editor. You should call the latter once done and pass the new value to it.

Hello sir,
Can I convert the date format in Reactabular
my json data is like "EFF_DT":"2013-01-01"  and I want to show the result in UI
as mm/dd/YYYY in Reactabular.

@ranjan653 Sure, go through cell:
cell: function(date) {
  // format date now. for example
  return (new Date(date)).toLocaleDateString();
}

You can apply the formatting you want there. toLocaleDateString is a standard method and should work for most browsers. You can check exact support online.

Sir,
{
"property": "EFF_DT",
"header": "Effective Date",
cell: [editable({editor: editors.input(),}),highlighter("EFF_DT")]
}
How can I implement in this ?

Perhaps
cell: [editable({editor: editors.input(),}), dateFormatter, highlighter("EFF_DT")]

...

function dateFormatter(date) {
  // format date now. for example
  return (new Date(date)).toLocaleDateString();
}

This is the point of the cell definition. Imagine it as a pipe. That will give you the correct order. See the demos for more examples.

SIr,
Here dateFormatter contains no parameter in cell but
function dateFormatter(date) {
// format date now. for example
return (new Date(date)).toLocaleDateString();
}
contains parameter.
Its throwing error.

hello sir,
Any solution...?

Its throwing error. ReferenceError: dateFormatter is not defined

Make sure you have dateFormatter in the correct scope. You can also write the function inline (replace dateFormatter with the function itself).
In case you run into problems with Date, look into Moment.js.


Changing versions in the editor to fast after a change leads to the version overwriting the latest version

Describe the bug
In the process editor we use a debounce to save the new xml only if there are no new changes in the last two seconds.
This timeout is a problem when a user makes a change and then changes to another version before the timeout runs out.
In that case the xml of the version will be saved as the new editable version xml.
To Reproduce
Steps to reproduce the behavior:

Go to the modeling view of a process that has a version
Make changes to the xml
Change to some version in the timespan of two seconds
Wait
Go back to the latest version

Expected behavior
If the user changes to another version shortly after making changes the changes should be written to the server and the timeout should be canceled.
Desktop (please complete the following information):

OS: Ubuntu 22.04.3
Browser: chromium
Version 118.0.5993.70

This bug has been reintroduced as it seems
https://github.com/PROCEED-Labs/proceed/assets/58050428/0baa8c05-3841-447b-906f-340e43304609


How to calculate virtual array in the code

Thank you for your great research. I have read your paper and I am reading the code. I have a question on how to calculate the “virtual speakers” when making pseudo binaural sound.
In your paper, you calculate the “virtual array” in equation (7).

I think the same calculation is performed by costruct_stereo_ambi function in data/Pseudo_dataset.py in your code.
I understand that variables in this function correspond to equation (7) as follows.

Here, in data/Pseudo_dataset.py line 123, we have
array_speakers_sound = np.dot(ambisonic, self.sph_mat.T)
but I cannot understand how  Is taken into account.
I would like to know how you reflect the calculation of equation (7) in your code.
Regards.

Hi, @310mo  In the below line (line 124), we had tried to use the pseudo inverse to represent the item (D^T D)^{-1} D^T. In the implementation, we found that the performance was not affected if we replaced the pseudo inverse with a simpler transpose item. Therefore, we commented line 124 out and just used line 123 to accelerate the training.

Thank you very much!
I see the point.


PATCH 0017-fix-Adding-back-in-removeAddons.patch

Tracking context on upstream patch 0017-fix-Adding-back-in-removeAddons.patch here.

edit Create method to add removeAddons

This patch has been rebased and is no longer there.


[bug] Loyalty cards not opening

After calling power menu, when tapping on loyalty card menu just goes away and nothing happens (instead of showing card barcode or qr code). When tapping payment card Wallet is opening, controlling of home devices also working fine.
I'm using Pixel 4 and PixelExperience rom, latest build, android 13 with December patch. Using lsposed and magisk.

Just noticed "Show loyalty card preview option" at the bottom of settings page. Don't remember to change it earlier, but preview is showing up now, my fault


Fix potential major:minor conflicts during device updates

The way the agent updates device and resource entries one by one for guest versus host information can lead to it incorrectly updating devices because of major:minor collisions, either between host and guest numbering (issue #834) or between block and character devices (issue #835).
This PR fixes both of them.

/test-ubuntu

/test

Only change in the latest push is a rebase.

/test-ubuntu

/test-ubuntu

@dgibson we'll need this for 2.0 as well ..

@bpradipt - yep, I've raised https://github.com/kata-containers/kata-containers/issues/703 for this. Adding labels too...

I think it needs to be backported to stable too.

@jodh-intel, for future reference, is there a way I can set the porting tags myself?  I couldn't see how to do it.

@dgibson - labels are only visible if you are a "member" of the repo. I've sent you a few requests so if you accept you should be able to see them on the rhs of the page.

/test-ubuntu

@dgibson - labels are only visible if you are a "member" of the repo. I've sent you a few requests so if you accept you should be able to see them on the rhs of the page.

Aha!  Thanks.

@jodh-intel, it's not clear to me what needs to be done now to move this forward.
Of the two failing tests, the first I'm not sure why it is failing, since the porting labels are applied now.
The other one appears to be complaining that the memory footprint has increased - which makes sense since I've added a new data structure.  I don't see any easy way to avoid that while fixing the bug though.

Hi @dgibson - well, we don't see the usual green merge button due to the failing porting check. However, that is failing due to https://github.com/kata-containers/agent/pull/844 still not being landed. That said, all the other checks have passed (aside from the metrics which is a known issue), so... let's merge this!


kprove: OutOfMemoryError during parsing

This commit is causing OutOfMemoryError when parsing the spec rule in kprove:
https://github.com/kframework/k/commit/025a57225d967fa4601e94183b6ed8a03cecd44e
VSC PR that tests it: https://github.com/runtimeverification/verified-smart-contracts/pull/190
I use K branch gnosis2 with commit above reverted. Test passes. If commit above is not reverted test fails.
Error appears on a specific test that uses 6 spec rules - one rule to prove and 5 trusted rules. 12 GB heap. So it likely appears because there are many complex rules to parse. Smaller tests pass but parsing still takes an unusually long time. On my local computer with 8 GB heap allocated the test surprisingly passes, but GC is thrashing a lot during parsing.
spec file attached:
checkSignatures-loop-failure-spec.k.txt

PR #333 fixed the issue.


Parser: Check that ref is followed by enum keyword

Fixes https://github.com/SerenityOS/jakt/issues/268

looks good, thanks!