[$1000] Web - Secondary contact method transition bug - clicking on a contact method that has yet to be validated opens the magic code input (validation) page with a sped up animation

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to settings > profile > contact method
Click on new contact method
Enter an email address
Click add
Click on the email address you just entered
Observe how the transition animation to the magic code input (validation) page is sped up/doesn’t work properly. If you look closely you can see that the text (sometimes) wobbles

Expected Result:
The page transition should be animated like other page transitions, without it being sped up.
Actual Result:
The page transition appears to not be animated/is sped up.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/d508a806-8032-4764-b653-18391f9abfbd
Expensify/Expensify Issue URL:
Issue reported by: @joh42
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690229176544109
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b86e6c6c9fa20453
Upwork Job ID:<PHONE_NUMBER>954917376
        2023-07-26Automatic offers:

joh42 | Contributor | 25814019
joh42 | Reporter | 25814020

Proposal: @joh42
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690229176544109
Proposal
Please re-state the problem that we are trying to solve in this issue.
We are trying to solve the sped up animation when the secondary contact method validation page is opened.
What is the root cause of that problem?
The root cause of the problem is that focus is given to the magic code text input instantly, before the transition animation has finished.
What changes do you think we should make in order to solve the problem?
The solution requiring the least amount of changes to the codebase would be to always pass shouldDelayFocus={true} from the BaseValidateCodeForm component to the MagicCodeInput component. Currently that is only passed as true for Android. Alternatively we could pass it as true for only Android and Chrome, but that would be more complex.
https://github.com/Expensify/App/blob/beebb67612cea0201f4fb1b6b17840cb5893d754/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js#L142
That would be enough to solve this issue. However, while we're at it, we might want to improve the code a bit:
We can simplify the MagicCodeInput component by removing the following useEffect
https://github.com/Expensify/App/blob/2c15e9758c081563eb755156680342f1cfbb74e4/src/components/MagicCodeInput.js#L156-L176
Instead we could pass shouldDelayFocus along to the first TextInput component, as opposed to not passing autoFocus if shouldDelayFocus is true:
https://github.com/Expensify/App/blob/2c15e9758c081563eb755156680342f1cfbb74e4/src/components/MagicCodeInput.js#L327-L329
The TextInput component already supports the shouldDelayFocus prop, so removing that redundant functionality from MagicCodeInput would make the code a bit DRYer.
https://github.com/Expensify/App/blob/a656c82d0ebf1d3954575084555a004efc47035b/src/components/TextInput/BaseTextInput.js#L67-L70
What alternative solutions did you explore? (Optional)
There is currently an ongoing Slack discussion regarding a general approach to solving this issue. The two alternate solutions to knowing when we should set focus is to use either InteractionManager.runAfterInteractions or onTransitionEnd. Both of those would require more changes than using the already implemented shouldDelayFocus. I nonetheless think we should wait for that discussion to conclude, and then consider if we should go with the solution that is deemed optimal even if it is more complex to implement.

Tested on newest version and yes, it is more sped up compared to the default contact method transition.

Thanks for reposting my proposal from Slack! I'm just going to append the following to the alternative solutions section:
At present the discussion in Slack is leaning towards standardizing focusing using the ScreenWrapper component's onEntryTransitionEnd prop. If we do decide that it should be implemented for this issue, I think it should be done in the TextInput component to make sure the code is as DRY as possible. The tradeoff to keep in mind is that if we keep using shouldDelayFocus, we would not have to change that component at all.

Bumo @parasharrajat got some proposals!

So that issue is more related to the alternative solution I mentioned rather than the animation issue

@parasharrajat I'm a bit confused, what part of that proposal was not covered by my proposal already? According to the contributing guidelines:
Note: Before submitting a proposal on an issue, be sure to read any other existing proposals. ALL NEW PROPOSALS MUST BE DIFFERENT FROM EXISTING PROPOSALS. The difference should be important, meaningful or considerable.
I clearly mentioned using transitionEnd, and while I agree that the edit I made there is incorrect, per https://expensify.slack.com/archives/C01GTK53T8Q/p1690295235023339?thread_ts=1690291230.607589&cid=C01GTK53T8Q proposals should not get into the nitty gritty, but rather identify the root cause and propose a solution, which I thought I did by mentioning onTransitionEnd in my original proposal.

Also, I'm new here, so I'm genuinely curious: should proposals contain high-level solutions, or should they actually delve into what I would consider the nitty gritty, implementation details?

To give further clarification here, in my comment I explicitly wrote:

Thanks for reposting my proposal from Slack! I'm just going to append the following to the alternative solutions section: At present the discussion in Slack is leaning towards standardizing focusing using the ScreenWrapper component's onEntryTransitionEnd prop.

After that, I posited that we could perhaps use didScreenTransitionEnd. This was in no way meant to remove the alternate solution of using onEntryTransitionEnd.

Reading through this, I realize it's quite hard to follow my multiple comments. As such, I'm going to summarize everything below.
I fail to see how explaining how to focus using onEntryTransitionEnd fulfills ALL NEW PROPOSALS MUST BE DIFFERENT FROM EXISTING PROPOSALS. The difference should be important, meaningful or considerable. Focusing using onEntryTransitionEnd has already been implemented 7 times already by different contributors, I did not think I needed to explain how to do it once more, but that mentioning it on a high level would be enough. Here are the existing implementations:
https://github.com/Expensify/App/blob/975146fa30bc65a19df8e0cca525af32ce2ceda5/src/pages/EditRequestDescriptionPage.js#L30
https://github.com/Expensify/App/blob/975146fa30bc65a19df8e0cca525af32ce2ceda5/src/pages/tasks/NewTaskDetailsPage.js#L76
https://github.com/Expensify/App/blob/975146fa30bc65a19df8e0cca525af32ce2ceda5/src/pages/settings/Payments/AddPayPalMePage.js#L68
https://github.com/Expensify/App/blob/975146fa30bc65a19df8e0cca525af32ce2ceda5/src/pages/iou/MoneyRequestDescriptionPage.js#L96
https://github.com/Expensify/App/blob/975146fa30bc65a19df8e0cca525af32ce2ceda5/src/pages/settings/Report/RoomNamePage.js#L82
https://github.com/Expensify/App/blob/975146fa30bc65a19df8e0cca525af32ce2ceda5/src/pages/settings/Payments/AddDebitCardPage.js#L102
https://github.com/Expensify/App/blob/975146fa30bc65a19df8e0cca525af32ce2ceda5/src/pages/tasks/TaskTitlePage.js#L66
Rather, it seems like that contributor is just getting into the nitty gritty
It seems like the C+ member might have missed that I wrote the line below:

At present the discussion in Slack is leaning towards standardizing focusing using the ScreenWrapper component's onEntryTransitionEnd prop.

And instead only saw another (incorrect) alternate solution that I posited. I might be mistaken, but I thought that since it's worded 'alternative solutionS' in the proposal template, you could post more than one, and if one is incorrect that would not discard the others.

Thank you both for the proposals and discussion for this issue - these types of situations are always tricky, and unfortunately there isn't a great way to handle this.
Tienifr has handled this situation before in previous issues and has had a proven method that has worked before.
However, joh42 mentioned it briefly in the original proposal. Since you're a newer contributor here, I'd recommend for future issues, delving deeper into one or two solutions that you know will work and then the C+ can be more confident on recommending your proposal.
I'm going to go with @joh42 for this issue because I think you had the general idea correct, but are still figuring out the process and working on refining your future proposals.
I hope that's alright with everyone cc @tienifr / @parasharrajat

Thanks for the guidance @parasharrajat / @thienlnam , I appreciate it. Going forward I’ll zero-in on one or two solutions per proposal, and make sure I clearly state what I mean with each one. As for this issue, you can expect a PR to be ready for review tomorrow.

Regarding a compensation split, I would like to mention the following:
Unless I’m mistaken, the so-called ‘exact solution’ is incorrect. The SignInPage does not and should not use shouldDelayFocus as there is no transition animation. Rather, it should be focused as soon as it mounts. Default focusing using autoFocus is not impacted by this issue.
Besides, relying on onEntryTransitionEnd to delay focusing on the SigninPage would not work, as the BaseValidateCodeForm component, which contains the MagicCodeInput, is conditionally rendered, which means that onEntryTransitionEnd is not fired after that component is shown. If that page required delayed focusing, we would have to check didScreenTransitionEnd when the MagicCodeInput component mounts.
https://github.com/Expensify/App/blob/8cdb506e97e8382f4bc55b0f48784f576fbb2789/src/pages/signin/SignInPage.js#L153
To be clear, this issue is only related to shouldDelayFocus, and the only change required to fix the issue at hand for the affected pages is removing shouldDelayFocus in favor of focusing using onEntryTransitionEnd.
As such, the ‘exact solution’ is incorrect as it involves a page that does not have this issue, is not affected by the solution to this issue, and said solution would not even work for that page.
It’s also worth noting that this is not the first time you submit a proposal that is similar to an existing one and then ask for a compensation split. In issue https://github.com/Expensify/App/issues/16582 your request for a compensation split was rebuffed by an Expensify employee with the following motivation:
Quote from comment 1:

The extra details in your proposal were good, but IMO both proposals were suggesting the same solution. So a 50/50 split doesn't seem that fair to me, given that your proposal followed an existing one and you didn't have to complete the checklist.

Quote from comment 2:

Typically I might go with a more detailed proposal, but I don't want to encourage contributors to 'swipe' existing proposals just by adding more details, or to add the full diff to the prosal [sic] when it isn't necessary.

That being said, if @thienlnam disagrees with me here and thinks a compensation split is appropriate I’ll go along with it, but I think there is a case to be made against it.

There are plenty of opportunities for more work here, and I've already made my decision. Let's work on other bugs rather than continuing to go back and fourth on this issue which wastes everyone's time.
We'll continue on in this issue as planned - thanks!

I just noticed that the Storybook stories for the MagicCodeInput is broken on main. Should I write that in Slack? Or should I report that as a bug? @parasharrajat / @thienlnam

Checking off the Storybook checkbox even though I cannot actually test it, thanks for responding in Slack

Ok, here's a payment summary:

Bug Reporter / Contributor: @joh42 $250 + $1000
C+: @parasharrajat $1000 - request on New.Dot

Upwork job

@joh42 can you add your full name (Johannes Idarsson) to your GH profile as well? Cheers!

Added, thanks @jliexpensify

Hmm, looks like it was just deployed so we'd wait another 7 days to pay this one

Hmm it was actually deployed to production last week...odd. @parasharrajat let me know if there's a regression test you want GH'd.

Paid Johannes, job closed. Just awaiting checklist.

Cheers, done!

Reviewed the details for @parasharrajat. This $1,000 payment is approved for NewDot based on the BZ summary above.


PHOENIX-5231 Configurable Stats Cache

Initial approach to handling configurable stats cache.
High level the approach taken is to provide a client side property to java type name which should exist on the classpath that implements a GuidePostsCacheFactory interface.  The this class will be used it to get a cache instance.  Long term this can handle JVM based or memcached interfaces as well as keep the current behavior of stats cache per connection.

@karanmehta93 @swaroopak Updated please review.

Merged by @karanmehta93 closing.


[WIP] Improve course test on html

Purpose
Plugin section lacking of tests around rendering and Course details
test is not relevant enough. Also template render algorithm is bugged
with draft organizations, some organizations are displayed twice and
not filtered yet against user role.
Proposal
Plugin section tests should be improved to correctly test nested
content and header level in its markup. Course detail test should use
'assertInHTML' and its template should be improved to fit to expected
behavior for draft items and user role.

This is under work and WIP stuff since i put some pointers to try to understand issues with draft stuff.
Some related organization items show twice when page is published, maybe because of draft mechanic with djangocms.
I have to find bug cause and after see if it would be better to have some Organization method from model or manager, or even template filter to get the right content loop instead of doing it from template.

Also, i see Person plugin test should be improved with the same stuff than for Section plugin, but it depend of #285 validation before.

Paused this PR until we find a solution around CMSTestCase. Probably trying to make our own mixin to get a functional context/request/rendered which is needed to correctly build placeholder and plugin content.

Getting ride of assertInHtml in profit of assertContain except from HTML fragment for plugins

The issue around CMSTestCase encountered in this PR was submitted to Django CMS with a proposal for fixing it: https://github.com/divio/django-cms/issues/6451

Fixed docstring and rebase from last master


Implement antialiasing

Fixes #79
Before:

After:

The above images use a synthetic devicePixelRatio of 0.1 so that it takes 10 logical pixels to fill 1 synthetic device pixel.
They also have artificially set the canvas's image-rendering attribute to pixelated. Without this, the browser would soften the rendered canvas image with bilinear resampling.

Per offline conversation, eventually it would be better to have the antialiasing factor be a sprite attribute. This would allow, say, glyphs to have  a different antialiasing factor from scatter plot points.
Currently, Megaplot does not have a good story around non-zero default values. Since the default antialiasing factor really ought to be 0.5, it makes sense to hold off on adding one until there's general support for non-zero defaults. See #81


Add a initContainer wait-for PingDirectory when starting a PingFederate container

Currently, PIngFederate Admin cannot start until the PingDirectory is running.  An init container with a wait-for on the PingDirectory server needs to be added if pingdirectory.enabled = true.
In the case where it's not dependent, it will add a little delay on PingFederate Admin in starting up.
The work around today is to simply bounce the PF Admin server after PD is up and running.

This will be released in v0.3.4

This has partially been completed in release 0.3.4.  There has been a request to make this an option for the deployer.
Thought is to provide a generic mechanism for any product to wait on another product to start.  Proposal is something like this at the product level in the values.yaml.
pingfederate-admin:
  container:
    waitFor:
      pingdirectory: ldaps
      pingdatagovernance: https

This would imply that the pingfederate-admin container would wait for the:

pingdirectory:(ldaps service port) and
pingdatatovernance:(https service port)

to come up, only if those services are also enabled.


Make configurable helm tiller image version, and use 2.9.0 by default

Fixes #470

I have changed the description according to: https://blog.github.com/2013-05-14-closing-issues-via-pull-requests/ (sorry :) )


Added GroupEntity:: setProducts(array)

Features

Added GroupEntity:: setProducts(array)

Part of 127177411

@00eadeyemi please preReview

@wnowicki Happy with the changes


UPDATE BADGE REQUEST [Ritzy#1608]

What is your Discord Tag?
Ritzy#1608
What is your UID (User ID)?
505432621086670872
What is the image for the badge that you want? Please make sure that the image is hosted on a trusted domain, such as i.imgur or cdn.discordapp.
https://i.imgur.com/VFSB2kJ.png
Additional Confirmation:

[x] My badge does not contain any NSFW material.
[x] My badge is not a badge that signifies that I am an official developer / staff for Discord or client mod communities.

done!


Fix error message

Questions
Answers

Description?
Do not use Tools method, it's useless here.

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes PrestaShop/Prestashop#15475

How to test?
Try to save a feature value with a wrong URL. See error message.

This change is

Hi @PierreRambaud,
It is ok :heavy_check_mark:

Thank you!

Hi @PierreRambaud,
It is ok :heavy_check_mark:

Thank you!


Fixed assets removed just before sprint 3 finished

This pull fixes the assets which were deleted from the config files when the new game map config files were added to main.

too many changes

😢


simplify and fix sensitivites, add test

Closes #1060
@whoburg, ready for review.

test models please

Added comments per review.


Use pointers for boolean fields in Access Applications

Description
Converts Access Application bool values to be pointers. These fields are omitted when set to false which is not the intended behavior.
Relates to: https://github.com/cloudflare/terraform-provider-cloudflare/issues/1364
Types of changes
What sort of change does your code introduce/modify?

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Codecov Report

Merging #1006 (61ba72f) into master (6c5ea4a) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 61ba72f differs from pull request most recent head cd82560. Consider uploading reports for the commit cd82560 to get more accurate results

@@           Coverage Diff           @@
##           master    #1006   +/-   ##
=======================================
  Coverage   49.06%   49.06%
=======================================
  Files         108      108
  Lines       10428    10428
=======================================
  Hits         5116     5116
  Misses       4200     4200
  Partials     1112     1112

Impacted Files
Coverage Δ

access_application.go
76.52% <ø> (ø)

access_bookmark.go
72.44% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.


[Bug] The dialog asking for delete when playback stop isn't showing up

Steps to Reproduce (for bugs)

I check it for example in Trakt -> Progress (Also from Trakt -> TVShow Collection)
Select an episode.
The download start and the playback start.
While the playback running I'm stopping the playback

Usually a dialog was popup as I set it in the settings, that asking if continue the download or stop.
But now it doesn't show up, instead there is the 'busy' icon for few seconds. One time when I stopped the torrent was even deleted from the torrents list. (And there is strange thing that one item is disappearing from the list)

It also happens when press on "TAB" key in order to return to the menu.

I have noticed also that after restart kodi, the download suddenlt resume and when I check the torrents list, the torrent was back there. So I don't understand what's actually going on.

Kodi Log:
https://paste.ubuntu.com/p/YTmjJ3RBNs
Video for illustartion:
https://f2h.io/uzhc47nq9nu8
These are my settings:

Your Environment
Elementum: 0.1.44 (It wasn't with 0.1.43)
Kodi 17.6
Skin: Titan 3.7.x
Windows 10, 64bit

This bug I didn't success to reproduce in Estuary skin
Log: https://paste.ubuntu.com/p/vvN4mz6mqj
So I still need to figure it out what is the difference.

@elgatito
It seems to be solved somehow in 0.1.47
Thanks.


Check for 0 roll influence

Just checking if roll influence is set to zero to prevent a divide by zero. While zero roll influence probably makes no sense at all anyway, at least this prevents things from really messing up.
Fixed #18605

Cherry picked into 3.0.3


Histogram Simulator

Includes a simulator for latency statistics.
The histogram simulator code is all isolated in the package org.terracotta.statistics.simulation.latency.
To run the simulator, run: LatencyHistogramSimulator. It will:

generate some fake operation latencies over 90mins
insert them in the histogram
simulate a statistic collector each 10 sec
simulate data reduction to generate a graph over different time frames and points, based on collected statistic values

When running the simulator, it generates over 1000 graphs for different values of Phi, Bucket count, window, time frame and points.
You can analyse the data by launching the HTML file Latencies.html.
The histogram has been quite intensively tested and Chris fixed a couple of issues lately.
Now with these simulations, we need to choose the right values to use in Ehcache.
Here are the trade-offs and things to consider when choosing the right "settings":
For the histogram:

window: related to the rate of operations. If window is too small, then no statistics. If too large, then different collect will end up returning the same value always and the graph will be a line
Phi: a lower Phi is more precise when asking for higher percentiles (i.e. 99th, 995th). A higher Phi gives better results for lower percentiles
bucket count: number of elements to hold in each bucket. The higher the more details we have but the more memory we consume

For the graph:

points: too few points mean low resolution because more aggregation
time frame: if time frame is lower than the histogram window, the display will be a sort of line because values won't change a lot over time
knowing that collector runs each 10sec, then a time frame of 5mins with 40 points would aggregate points over 7.5sec, so some points will have the same value as the previous point because of a lack of data

Examples of generated graphs:
Shows all the operation latencies in 1 graph. This is the truth.

Representation of a histogram:

Representation of a graph from collected statistics from histogram each 10 sec:

as long as it's in the test source folder, I'm all good

thank you @mathieucarbou !


Remove main branch

What type of enhancement is this?
Other
What does the enhancement do?
We use develop branch mainly, and the main branch is simply unused.
Perhaps we should remove it to avod confusion. I personally checkout to main wrongly multiple times in these days.
And although I can remove the branch locally and use an alias like git symbolic-ref refs/heads/main refs/heads/develop, an upstream main is still confusing.
Implementation challenges
A maintaine should be able to remove it from GitHub Web UI.
cc @waynexia @fengjiachun @lfc

I personally checkout to main wrongly multiple times in these days.

Same with you.
We are considering to switch to main recently. But it might take some time. What do you think @fengjiachun @killme2008 ?

In our next release, we'll switch to the main branch.  cc @waynexia @evenyag

Good to know. Then this issue is invalid.
Closing..

@fengjiachun do we have an estimate for this? I've heard that we may cut 0.5 in these days.


Improve HtmlToReact conversion

Closed in favor of https://github.com/frontity/saturn-theme/issues/8


Consider streaming content html

document.write() AND iframe? We have to add this!

This question is available on Nuxt.js community (#c113)

We will leave this kind of optimization to vue and the userland (programmer).

Vue isn't concerned with massive chunks of preformatted text, and userland cannot be trusted

I still think this is fall into the overoptimization problem and will take way to much work and not that much of a benefit for most developers and users using nuxtent. However you are welcome to discuss on gitter or discord. And if you would like to contribute implementing this feature I would suggest to wait unitl we release 3.0.


Do not set priorityClassName for hooks

Description

Reverting previous changes for hooks. cluster-critical priority could
be set only for kube-system resources and this could break existing
pre-update hooks for applications.
Type of change

Regression fix (non-breaking change which fixes a regression)

TODOs

[x] Perform manual testing
[ ] Address review feedback

Implementation

Testing done

Additional information

For monitoring components, we set their own priorities declared in monitoring app resources.

Can you explain how this breaks stuff?
Any hooks in non-kube-system namespaces will fail and they must be rewritten to use kube-system namespace, which is an unexpected change from a user perspective in the middle of LTS release cycle.
We could leave it light that for master branch, but for the LTS branches I would like to remove this change for now.

Also setting our own priority class will not work for pre-update hook which I explored as another solution for the problem.


serde generated code triggers new clippy::type_repetition_in_bounds warning

Clippy has recently introduced new lint type_repetition_in_bounds and apparently serde-generated code (#[derive(Serialize, Deserialize)]) triggers this lint in some cases.
   Checking playground v0.0.1 (/playground)
warning: this type has already been used as a bound predicate
 --> src/main.rs:8:17
  |
8 | #[derive(Debug, Serialize, Deserialize)]
  |                 ^^^^^^^^^
  |
note: lint level defined here
 --> src/main.rs:1:9
  |
1 | #![warn(clippy::type_repetition_in_bounds)]
  |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  = help: consider combining the bounds: `S: Foo + _serde::Serialize`
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds

warning: this type has already been used as a bound predicate
 --> src/main.rs:8:28
  |
8 | #[derive(Debug, Serialize, Deserialize)]
  |                            ^^^^^^^^^^^
  |
  = help: consider combining the bounds: `S: Foo + _serde::Deserialize`
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_repetition_in_bounds

    Finished dev [unoptimized + debuginfo] target(s) in 0.61s

Code example

Thanks, I reported this as a Clippy false positive in https://github.com/rust-lang/rust-clippy/issues/4326.


JFXTextField Skin not working on mobile device

The JFXTextField has a different skin on mobile devices (with javafxports).
Desktop:

compared to desktop:

Well, it seems that javafxports is forcing Java textfieldSkin on android. i believe this issue should be directed to JavaFXPorts

I didn't check what JavaFXPorts does, but created an issue: https://bitbucket.org/javafxports/android/issues/79/textfield-overrides-custom-skin

we fixed this issue as we added custom JFXTextFieldSkin for android, Note that: NO changes need to be applied to your code.
however you need to use the android version of JFoenix, you can either rebuild the library or download it using the following link:
http://www.jfoenix.com/download/jfoenix-0.0.0-SNAPSHOT-retrolambda.jar
plz confirm if the problem is fixed, thanks.

Your fix works. It would be better if JavaFXPorts solves such problems, but there was no response to the ticket... So thanks for your solution.


Doesn't work on windows

I tried installing it on windows, and there are several problems.
Running npm install -g sqlx-ts gives an error saying unzip is required, which isn't a powershell command.
I used gitbash to install it there, and then the command worked in powershell.
But when I tried to run it with sqlx-ts . in my project directory, I got this error
PS C:\Users\peyto\pnw-microgreens\crm-app> sqlx-ts.cmd .
thread 'main' panicked at src/ts_generator/sql_parser/expressions/translate_expr.rs:189:59:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Is there a way that you can rewrite the install program to use windows-specific commands such as Expand-Archive which is the equivalent to unzip? I really want to use this library for my project. Thank you.

Hi, let me have a think about this. I can potentially just utilise an NPM module for unzipping, which should provide cross platform compatibility


It still works

If you've recently paid a decoded invoice, please write a comment below so that others could see that it still works.

Still works :)

Works.

Can you add ETH ?

Still works ;)
Thanks guys

Still works!!

still works, why is bitpay so annoying

still working, thanks for making this. Why is bitpay so annoying

still working

Working well

It still works.

Yep, still works.

Does this still work? I can't find a bitcoin: URL on any of the bitpay payment options... The invoice url doesn't seem to work either.


[#noissue] fix log message

fix invalid log message

Codecov Report

Merging #3563 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3563      +/-   ##
==========================================
- Coverage   40.09%   40.08%   -0.01%
==========================================
  Files        2186     2186
  Lines       71517    71517
  Branches     9830     9830
==========================================
- Hits        28673    28666       -7
- Misses      40101    40106       +5
- Partials     2743     2745       +2

Impacted Files
Coverage Δ

...rp/pinpoint/collector/receiver/DispatchWorker.java
62.79% <100%> (ø)
:arrow_up:

...pinpoint/profiler/instrument/AccessorAnalyzer.java
57.14% <0%> (-8.58%)
:arrow_down:

...tor/metric/datasource/DefaultDataSourceMetric.java
75.75% <0%> (-3.04%)
:arrow_down:

...p/pinpoint/profiler/sender/AbstractDataSender.java
97.05% <0%> (-2.95%)
:arrow_down:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
82.92% <0%> (-2.44%)
:arrow_down:

...m/navercorp/pinpoint/test/OrderedSpanRecorder.java
70.19% <0%> (-1.93%)
:arrow_down:

...corp/pinpoint/rpc/stream/StreamChannelManager.java
70.68% <0%> (-1.73%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
70.37% <0%> (-0.93%)
:arrow_down:

...inpoint/profiler/sender/AsyncQueueingExecutor.java
77.17% <0%> (+1.08%)
:arrow_up:

.../pinpoint/rpc/client/PinpointClientHandshaker.java
66.42% <0%> (+1.42%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdfbb09...009e06e. Read the comment docs.


Incorrect detectron2 version in README

This line tries to import RandomSubsetTrainingSampler from detectron2, but this sampler is only available in detectron2 v0.6 (see here), whereas in README instructions the version of detectron2 is 0.5

OK~I will fix it.


[Suggestion] Display the difference since a previous collection log export

Hi, I would basically like to be able to "reset" my collection log, and only see what drops/kc I've gotten since a given export. I imagine this could be achieved by substracting the specified collection log export from the current state. I was thinking in-game, but it would be equally useful if I could just do it from the website using two of the json exports, if that is easier for you. If it's in-game, I imagine it could be enabled with a checkbox+a string specifying the filename of the json export you wish to "start from" within the data folder.
Why? A few days ago I liquidated my bank on my main, and started playing as ironman. Just for fun, wasn't willing to start a whole new account to play ironman. Would be nice to have an accurate collection log. Although, my bank essentially serves as that for now so it's really just a QOL (also, I can use Ring of Wealth/Slayer ring "streaks" for kc). A lot of youtubers do similar "challenges" with their accounts where they wipe their banks & do something from scratch, so I'm sure it could be used for some of those as well. I created an export for myself shortly after starting this just in case this does become a feature.
I imagine this is pretty tedious to implement, so I completely understand if you aren't interested in working on it. Looking forward to your response!

I'm always looking for suggestions/ideas for the plugin, so first off, thank you! This is something that could be done, and shouldn't be too terrible to put together. I'll definitely take a look into it. I'll let you know when I have something thrown together if you're familiar with building Runelite plugins and wanted to test it out.

Happy to hear! I am familiar yes, but it's no rush for me, I don't mind waiting until full release. Happy to help test or give feedback if you need. I'm progressing pretty slowly in game so I won't have much new collection log data to work with x)


Add compile time /etc/eve-hv-type file

Set eve virttype in /run/eve-virt-type based on /run/eve-release
Add "eve virttype" option to return the virtualization type

This PR is a split from PR https://github.com/lf-edge/eve/pull/3210/
Testing done with kubevirt image
0e55274f-a647-4756-9e7f-bb6bbdcad366:~# cat /run/eve-virt-type
kubevirt
0e55274f-a647-4756-9e7f-bb6bbdcad366:~# eve
Welcome to EVE!
commands: enter [service] [command (assumed sh)]
enter-user-app
exec [service] command
list
status
start
pause
resume
destroy
persist list
persist attach
config mount
config unmount
firewall drop
verbose on|off
version
uuid
virttype
0e55274f-a647-4756-9e7f-bb6bbdcad366:~# eve virttype
kubevirt

Looks like pkg/grub/rootfs.cfg reads /etc/eve-release just to get eve-flavor. Then we can replace that code to read value from /etc/eve-hv-type.  Coming to storage-init.sh I do not see the need for that code anymore. That seems to be legacy code to debug zfs eve image. We can just delete it.


Add Dependabot setting for GitHub Actions

This pull request adds a Dependabot setting for GitHub Actions. The setting ensures that weekly updates are scheduled for the package ecosystem and directory specified. This will help keep the dependencies up to date and improve the overall security and stability of the project.

@coderabbitai review


workflows: Holding Pen list view

New Holding Pen list view based on small flightJS components instead of DataTables.
PR is ready for integration.

As I mentioned in https://github.com/inveniosoftware/invenio/pull/2628#issuecomment-130555086, please move it to Invenio-Workflows package. I can help you with conflict resolution in *.py files and the rest should be mergeable without major conflicts.


Query inactivity timeout

{
"stack": "Error: Query inactivity timeout\n
at Query.\u003Canonymous> (/usr/local/services/nodejs_pilot-1.0/node_modules/mysql/lib/protocol/Protocol.js:164:17)\n
at Query.emit (events.js:180:13)\n
at Query.emit (domain.js:440:23)\n
at Query._onTimeout (/usr/local/services/nodejs_pilot-1.0/node_modules/mysql/lib/protocol/sequences/Sequence.js:129:8)\n
at ontimeout (timers.js:466:11)\n
at tryOnTimeout (timers.js:304:5)\n
at Timer.listOnTimeout (timers.js:267:5)\n
--------------------\n
at Protocol._enqueue (/usr/local/services/nodejs_pilot-1.0/node_modules/mysql/lib/protocol/Protocol.js:145:48)\n
at PoolConnection.query (/usr/local/services/nodejs_pilot-1.0/node_modules/mysql/lib/Connection.js:208:25)\n
at pool.getConnection (/usr/local/services/nodejs_pilot-1.0/lib/mysql/index.js:105:22)\n
at Ping.onOperationComplete (/usr/local/services/nodejs_pilot-1.0/node_modules/mysql/lib/Pool.js:110:5)\n
at bound (domain.js:376:14)\n
at Ping.runBound [as _callback] (domain.js:389:12)\n
at Ping.Sequence.end (/usr/local/services/nodejs_pilot-1.0/node_modules/mysql/lib/protocol/sequences/Sequence.js:88:24)\n
at Ping.Sequence.OkPacket (/usr/local/services/nodejs_pilot-1.0/node_modules/mysql/lib/protocol/sequences/Sequence.js:97:8)\n
at Protocol._parsePacket (/usr/local/services/nodejs_pilot-1.0/node_modules/mysql/lib/protocol/Protocol.js:279:23)\n
at Parser.write (/usr/local/services/nodejs_pilot-1.0/node_modules/mysql/lib/protocol/Parser.js:76:12)\n
at Protocol.write (/usr/local/services/nodejs_pilot-1.0/node_modules/mysql/lib/protocol/Protocol.js:39:16)\n
at Socket.\u003Canonymous> (/usr/local/services/nodejs_pilot-1.0/node_modules/mysql/lib/Connection.js:103:28)\n
at Socket.emit (events.js:180:13)\n
at Socket.emit (domain.js:440:23)\n
at addChunk (_stream_readable.js:274:12)\n
at readableAddChunk (_stream_readable.js:261:11)",
"message": "Query inactivity timeout"
}
What does "Query inactivity timeout" mean ? Why causes this question?  How can I resolve it?

That error should mean that your code did a query and specified a timeout value and the query took longer than that value. Are you passing a timeout in your query?

Closing due to no response.


Firmware missing for Intel 7260 wlan adapter under ResinOS 1.16.0

Problem
We had an issue today with our WLAN adapter not working, it is an Intel 7260 and we were on ResinOS 1.16.0 when the issue happened. I was able to resolve it by getting firmware that the driver was looking for onto the filesystem.
(applicable) dmesg output:
[    2.254392] iwlwifi 0000:02:00.0: enabling device (0000 -> 0002)                                                                                [    2.255065] iwlwifi 0000:02:00.0: Direct firmware load for iwlwifi-7260-13.ucode failed with error -2
Steps taken to resolve:
cd /lib/firmware
wget https://github.com/OpenELEC/iwlwifi-firmware/raw/master/firmware/iwlwifi-7260-13.ucode
rmmod iwlwifi
modprobe iwlwifi

Hello @Johnsel . Thank you for your bug report. We are going to look into this and make sure this will be included in the next releases.

I confirm that this is missing - Ran into the same issue just now.

I just added this supported in morty flavor of resin. We will switch to morty pretty soon so this will bring in the firmware requested above.
https://github.com/resin-os/meta-resin/pull/545

Issue fixed in latest rsinOS release. Closing


Update cats-effect to 3.5.2

About this PR
📦 Updates org.typelevel:cats-effect from 2.5.5 to 3.5.2 ⚠
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

💡 Applied Scalafix Migrations

org.typelevel:{cats-effect,cats-effect-laws}:3.0.0

github:typelevel/cats-effect/v3_0_0?sha=v3.0.0

org.typelevel:{cats-effect,cats-effect-laws}:3.3.0 (created no change)

github:typelevel/cats-effect/v3_3_0?sha=series/3.x

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "cats-effect" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.typelevel", artifactId = "cats-effect" }
}]

labels: library-update, early-semver-major, semver-spec-major, version-scheme:early-semver, scalafix-migrations, commit-count:n:2

Superseded by #533.


add x-ms-identifiers for iothub

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify
About this Change
APIs will need to start indicating item uniqueness in arrays. By default, uniqueness is the string property called "id" of items in an array. When that property does not exist, the x-ms-identifiers extension property must be used to specify the identifying property(s) or lack thereof. This pull request is my best guess effort to ease resource providers into the new requirement before it becomes enforced. Compliance and accuracy will need to be owned and maintained by the resource provider going forward.

See https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.
You can also make changes after this PR is checked in. At this point, this annotation is only used by Change Analysis for change computation, so making changes afterwards shouldn’t be a breaking change.
2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- [ ] SDK of .NET (need service team to ensure code readiness)
- [ ] SDK of Python
- [ ] SDK of Java
- [ ] SDK of Js
- [ ] SDK of Go
- [ ] PowerShell
- [ ] CLI
- [ ] Terraform
- [x] No refresh required for updates in this PR
Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Hello @honghr Coud you please review this pr? This should not be a breaking change

Hi @rkmanda could you please review this pr? This code change is not breaking

Hello @honghr Coud you please review this pr? This should not be a breaking change

Could you resolve "Swagger ModelValidation" issue firstly?

Hello @honghr Coud you please review this pr? This should not be a breaking change

Could you resolve "Swagger ModelValidation" issue firstly?

Hi @honghr it seems the model validation errors are not from this change

Hi @honghr could you please help get this pr merged? Thanks! The error should not come from the code change

/azp run

Hi @honghr could you please help get this pr merged? Thanks! The error should not come from the code change

Hi @j-zhong-ms  You still have model validation error not fixed. Please resolve this issue and then I can merge it.


wrapper.vm.hasFocus returns opposite value starting in v1.1.3

Subject of the issue
We have a very simple test that makes the following assertion
it('Shows options when component is focused', async () => {
    const input = wrapper.find('input');
    await input.trigger('focus');

    expect(wrapper.vm.hasFocus).toBe(true);
});

With<EMAIL_ADDRESS>this assertion pass. Starting from 1.1.3 and all the way to 1.2.0 (I tested all releases in between) the wrapper.vm.hasFocus assertion returns false.
Steps to reproduce
Shallow mount a component that has an input, then try to focus it:
it('Shows options when component is focused', async () => {
    const input = wrapper.find('input');
    await input.trigger('focus');

    expect(wrapper.vm.hasFocus).toBe(true);
});

Expected behaviour
What should happen?
hasFocus should return a consistent result from v1.1.2 to v1.1.3
Actual behaviour
What happens instead?
hasFocus now returns the opposite value without the test changing
Possible Solution
None of the changes in the release note ring a bell to me about why this may occur :(
What are the alternative solutions? Please describe what else you have considered?

This same up recently, please see this https://github.com/vuejs/vue-test-utils/pull/1848 and this https://github.com/vuejs/vue-test-utils/pull/1777#issuecomment-840938988.

Did the above links fix your problem?

Adding attachTo: document.body effectively fixed this. Thank you!! 🎉


Added fido.identityserver.com

fido.identityserver.com is the demo page for FIDO2 for ASP.NET

Closed for same reason as #30


Fix for window animations for undecorated Win32 window

What does the pull request do?
https://github.com/AvaloniaUI/Avalonia/pull/3221 describes the original problem and solution.
Back when Windows did not have multi-screen support, maximized windows were supported by simply placing the window at negative x/y screen coordinates and extending the size of the window slightly, so that the window border would be off-screen and invisible to the user.
To maintain compatibility, Windows still uses this positioning behavior for maximized windows, even though DWM will exclude the "off-screen" parts of the window from rendering.
Notably, this only applies to a maximized window. If a window is instead docked to the sides of the screen, Windows will not place it at negative screen coordinates.
This PR fixes this issue by adjusting the client area of a maximized window such that it matches the visible screen area by subtracting the "off-screen" border.
Known issues
When a maximized window is resized manually via IWindowImpl.BeginResizeDrag, it doesn't seem to lose the maximized state. This results in receiving WM_SIZE with the SIZE_MAXIMIZED flag still set. In this case, GetWindowPlacement will also continue to report SW_SHOWMAXIMIZED.
As a result, the client area will not be updated to the correct size (remember, this PR adjusted the client area specifially for the maximized state). The client area will remain offset from the window until the maximized state is removed from the window.
It seems to me that the issue here is that it's possible to resize a maximized window. I think window sizing should be left to the operating system.
For Windows, this means that rather than invoking window sizing manually, the WM_NCHITTEST message should be handled by enabling a user-configurable callback to classify which coordinates correspond to each of the window parts (title bar, four corners, four edges).
Correctly implementing WM_NCHITTEST also enables missing window interactions like double-clicking the titlebar to maximize or restore the window.

We could simply disable BeginResizeDrag when window is in maximized state, since that operation is invalid anyway.

I removed Window.BeginMoveDrag and Window.BeginResizeDrag in favor of
Func<Point, WindowRegion> IWindowImpl.ClassifyWindowRegion { get; set; }

This function should be provided for an undecorated window that wants to show custom move/size decorators. If the function is provided, the windowing platforms will use it to trigger platform-specific move/resize behavior. A simple implementation might look like this:
PlatformImpl.ClassifyWindowRegion = point =>
{
    if (this.InputHitTest(point) == this.FindControl<Control>("TitleBar"))
    {
        return WindowRegion.TitleBar;
    }
    return WindowRegion.ClientArea;
};

This will allow a window to be moved, but not resized. Correctly classifying all window regions will enable moving and resizing behavior.
For Win32, WM_NCHITTEST is now fully implemented, which also enables the system-provided default window interactions (e.g. double-click to maximize or restore a window).
The weird Win32 corner case where an undecorated window is resized with using custom resize grips while it is still maximized is now handled by restoring the window to normal state.
I did test the changes on OSX and Linux, and as far as I can tell, the behavior is unchanged.

Double-click to maximize/restore is now also working for the macOS platform.
Tested on macOS Catalina.

We could simply disable BeginResizeDrag when window is in maximized state, since that operation is invalid anyway.

I know this is an ancient issue, but...just for future reference, I'd like to point out that no, that operation is not invalid. As of Windows 7, a maximized window can be dragged around by its titlebar, and initiating this drag also un-maximizes the window.

Closing this PR for inactivity. Ping me if this is updated accordingly.


[BUG] - empty nested records with keep_nulls=False produce a record with no fields

Summary
When we remove nulls we are only removing inner nulls and not the case where a record has all fields removed during this process. This produces the following error when attempting to load into BigQuery with the generated schema:
Field outer_nested_record is type RECORD but has no schema.
Example input
test_data.json
{"test": "thing", "empty_record": {}, "outer_nested_record": {"inner_empty_record": {}}}

Command Ran
generate-schema --input_format json --quoted_values_are_strings < test_file.json

Current Output
[
  {
    "fields": [],
    "mode": "NULLABLE",
    "name": "outer_nested_record",
    "type": "RECORD"
  },
  {
    "mode": "NULLABLE",
    "name": "test",
    "type": "STRING"
  }
]

Expected Output
[
  {
    "mode": "NULLABLE",
    "name": "test",
    "type": "STRING"
  }
]

Some additional info, I believe this is caused by the outer_nested_record being marked as "status": "hard" since it contains an inner record
https://github.com/bxparks/bigquery-schema-generator/blob/develop/bigquery_schema_generator/generate_schema.py#L744
I think for this we basically need to check if every inner record has a "filled": false then if so, we can mark this outer as "status": "soft" and "filled": false

Created pull request #56 to remediate this. @bxparks please help take a look at that when you get a chance :)

At this time this doesn't actually load into BigQuery as the empty record exists in the JSON but not the schema. I will think about this a little as it pertains to my data and potentially close this issues/associated PR

I recall that the handling of null, empty record {}, and empty array [] (and nested combinations of those) in the bq load command seemed inconsistent to me, or at least the pattern was not obvious to me.  I don't actually know what the proper handling of your example should be.

Closed #56 with

I have found that removing those in the schema generator will not allow bigquery to load the JSON data as there will be an empty record in the JSON but not the schema. Thus I believe this is working as intended and I can close this PR as not needed. If I want those removed I need to perform data cleaning prior to running the schema generator.

Closing this as well.

Instead of running a data cleansing preprocessor, you might be able to generate the schema using bigquery-schema-generator, without --keep_nulls, then import using bq load --ignore_unknown_values, which will ignore those null values. At least, that's my vague recollection from similar problems that I ran into a few years ago when I created this.


Make tables in the Blazor and Angular example apps consistent with each other

Pull Request
🤨 Rationale
With #1519, we can re-introduce initial rows to the table in the Angular example app without failing the Lighthouse accessibility check. I decided that this was also a good chance to make the tables in the Blazor and Angular example apps consistent with each other.
Resolves #1195
Resolves #978
👩💻 Implementation
Updated the Blazor and Angular example tables to:

Use consistent models to represent the table data

As part of this, I made the Blazor example app have deterministic data and removed the use of Faker

Have the same set of columns and column configuration
Load initially with 10 rows
Add 10 more rows to the table when the Add rows button is pressed

🧪 Testing

Ran both example apps and make sure the tables behave identically and have the same data
Verified that the Lighthouse accessibility check passes (part of the pipeline)

✅ Checklist

[ ] I have updated the project documentation to reflect my changes or determined no changes are needed.

@atmgrifter00, will you buddy this for me?


Uncaught Error: The specified module could not be found./?~\AppData\Local\atom\app-1.24.0\res...

[Enter steps to reproduce:]

...
...

Atom: 1.24.0 ia32
Electron: 1.6.16
OS: Unknown Windows version
Thrown From: Atom Core
Stack Trace
Uncaught Error: The specified module could not be found.
\?\C:\Users\Computer\AppData\Local\atom\app-1.24.0\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
At ELECTRON_ASAR.js:173

Error: The specified module could not be found.
\\?\C:\Users\Computer\AppData\Local\atom\app-1.24.0\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:173:20)
    at Object.Module._extensions..node (module.js:598:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:187:18)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (internal/module.js:20:19)
    at customRequire (~/AppData/Local/atom/app-1.24.0/resources/app/static/<embedded>:96:26)
    at get_KeyboardLayoutManager (~/AppData/Local/atom/app-1.24.0/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:7:65)
    at get_manager (~/AppData/Local/atom/app-1.24.0/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:16:42)
    at Object.getCurrentKeyboardLayout (~/AppData/Local/atom/app-1.24.0/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:32:17)
    at exports.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.24.0/resources/app/node_modules/atom-keymap/lib/helpers.js:201:42)
    at KeymapManager.module.exports.KeymapManager.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.24.0/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:467:20)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (~/AppData/Local/atom/app-1.24.0/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:347:30)
    at WindowEventHandler.handleDocumentKeyEvent (~/AppData/Local/atom/app-1.24.0/resources/app/src/window-event-handler.js:108:40)

Commands
  2x -2:39.2.0 tree-view:add-file (span.name.icon.icon-file-directory)
     -1:08.7.0 atom-live-server:startServer (atom-pane.pane.active)
     -0:44 tree-view:add-file (span.name.icon.icon-file-directory)

Non-Core Packages
atom-live-server 2.2.0
emmet 2.4.3
minimap 4.29.7
w3c-validation 0.4.0

I think this is a duplicate of issues like #15722. If you have any anti-virus software running, please check if there are any messages about quarantining this file and then see if you can restore it, or try to re-install with your anti-virus temporarily disabled. If you don't have any anti-virus software running, let me know.


Add unique constraint to public_value

Is it possible that users' existing setups have duplicated values for the field we are applying the constraint  to?

@alena1108 we talked about that here, though I never got an answer.  If it's recoverable I think it can just be put in as a footnote in the release notes because the only people with anything other than 20-char random strings in the publicValue are probably us.

@vincent99 yes, I remember that, just wanted to bring up the question up again. We should for sure release note it.

As discussed this currently isn't possible due to registry credentials.


added myself under gif

What type of PR is this? (check all applicable)

[x] 🚀 Added Name
[ ] ✨ Feature
[ ] ✅ Joined Community
[x] 🌟 ed the repo
[x] 🐛 Grammatical Error
[ ] 📝 Documentation Update
[ ] 🚩 Other

Description
Add Link of GitHub Profile

Love the repo! 💖


Javascript angular 7 Actions are not getting rendered

Platform  JavaScript
Author or host both
Version of SDK 1.2
Issue
I am using Angular 7 and trying to render card as mentioned in documents . Strangely , the generated HTML doesn't contain any Action related items. I am trying to use 'Show Card' which contains Factset .  Both textblocks are visible though
Attaching html generated . Please let me know if this is a bug or something to with angular or my code.
issue.zip

Just to make sure the string concat is working can you JSON.parse(json), and then JSON.stringify it again and paste it into the Adaptive Cards Designer and make sure it renders as you expected?

i tried that  it is showing properly and verified with card designer. I also printed this.adaptiveCard after parsing json and i can see _actionCollection object . PFA the screenshot

but the rendered item list only shows 2 textblocks

infact i tried with multiple json available in samples and every where there is no actions only textblocks are visible in rendered html
Please help

Hi @nibinki, I'm not familiar enough with Angular 7 to help with this without a repro. Can you include a small repro project or include any other information? If the DOM is inspected has the elements then it seems the Adaptive Card Renderer is working is correctly, and something is getting dropped in Angular?

@nibinki, ShowCard ActionItems' contents are added in the DOM only when such action actually happens (say, button click). Not sure how you are adding the card to DOM in your Angular app, but when i tried, the JSON you shared works -> able to see the fact set card on click of show details button.
Example: https://stackblitz.com/edit/angular-7-master-euwiqu

@BalajiR thanks for the help ..i am using angular 7.2.0. my problem is because of ( i think) zone.js . i debugged ur code and i can see entire execution of rendering is happening in card.element.js of adaptivecards , however in my case during rendering of action items it reaches this point
ActionButton.prototype.render = function (alignment) {
var _this = this;
this.action.render();
this.action.renderedElement.style.flex = alignment === Enums.ActionAlignment.Stretch ? "0 1 100%" : "0 1 auto";
this.action.renderedElement.onclick = function (e) {
e.preventDefault();
e.cancelBubble = true;
_this.click();
};
this.updateCssStyle();
};
and while enabling onclick it is going to zone.js
desc.set = function (newValue) {
// in some of windows's onproperty callback, this is undefined
// so we need to check it
var target = this;
if (!target && obj === _global) {
target = _global;
}
if (!target) {
After reaching this point only button is rendered while the whole factset is removed. Zone.js is by default added to angular projects , i am also using other dependencies but still not able to figure it out why factset is not rendered

Hi @nibinki, as @BalajiR explained, the initial render() of your card will not actually render the FactSet because the FactSet belongs to the card of a ShowCard action. The card of a ShowCard action is rendered "just in time" as the end user clicks the associated button. In your case, that hasn't happened, therefore you will not see the DOM for the FactSet in the innerHtml.

Hello @nibinki, closing this out for now. Please reopen if you continue to have questions for us.. Thanks!


ctrl-h should be the default keymapping of deleting one charactor

ctrl-h is also the default keymapping of deleting one charactor in shell,  emacs and many other software

Feel free to open up a PR, vim-clap is still in a very early stage.

CTRL-H is done in #36.


fallback pid lookup when application list is empty

better solution for #145 and #146
cc @kxynos @xbiei

I agree, this is a better solution.
I think it's better if you requested changes on the existing PR instead of making a new one.


make createLayoutRequestDTO' fields required

Background
Currently nothing is stopping us from sending a request which omits all the fields in metadata

Work Required

all fields in metadata to be required except for screenshot (might have to create a new Dto if the current one is also used for updates)

might have to create a new Dto if the current one is also used for updates

Why would updates not have the same constraints?

Actually yes. You can ignore that comment. We had a separate ticket for reworking the layout updates (either always send the whole entity or change to PATCH) and this will address that too.

Testing in Postman, the API changes seem fine. There is a general bug with the remote implementation (#131) that is stopping me from testing from the UI.


[docs]In the docs/README_EN.md, the X-share button is not displayed correctly.

Overview
In the README, the X-share button is not displayed correctly.

The relevant code is on lines 13 and 393.
We need to modify the x-share button by referring to README.md, which is written in Japanese.
Task list

[ ] Compare README.md and docs/README_EN.md.
[ ] Fix the X-share button.

Others
If you find another correction, please create an issue!
This way we can avoid multiple contributors making the same correction.
For more information, check out the following

#292

If anyone would like to challenge this Issue, please add a comment!
Thank you for your interest in this issue 🚀.

Hii @kazzyfrog.I would like to work on this issue.Can you assign me this issue?

Hii @PAVAN507-STAR.
Just now assigned!
If you need help, please add a comment!
Thank you ;)

Hii  sir @kazzyfrog.Solved the issue and raised the PR

Thank you!
I just added a review comment ;)

@kazzyfrog should i raise a pr again with suggested changes

Essentially, you can just add the change, within the same PR 👍


Fix missing handling of DD.MM.YY

Also ensures that we parse dates with two-digit years to the 20th century by default, so long
as it is 80 years or less in the past. Otherwise, dates will be set to the 21st century.

@henninghaakonsen @ninakjek


Rename State.config to widget everywhere

#7015
For your viewing pleasure.
https://travis-ci.org/flutter/flutter/builds/219488495 tested things ran ok without adding back the backward compatibility shim.

There are many, many places where we have a "widget" local variable today, where with this patch there's now shadowing going on, where the local variable is shadowing the property previously known as "config". I think we should make sure all such cases are fixed before checking this in (that was the problem that had stopped Adam from doing it when he tried).

Ya you're right. I thought Adam just had an IDE refactor issue. Wish there would be an analyzer check for it :S
There's 37 of them. I'll rename them.

Thanks for reviewing.
Turns out on closer inspection, for subclasses of State that also has any field named 'widget', there are only 3 left. Renamed.

I wouldn't bother with the @deprecation, yeah.

Looking into this it seems there are still many cases of identifiers called "widget" that shadow the new getter, or that are in parts of the codebase where it's now confusing that they have the same name.
For example, the following files are examples of files with build functions with a local lambda whose parameter is named widget which shadows the State.widget getter:

examples/flutter_gallery/lib/demo/material/chip_demo.dart
packages/flutter/lib/src/material/paginated_data_table.dart
there's lots of others

Also the DataCell class has a widget property that should probably be renamed child for consistency now.

Thanks for going through them again.
Hoping you caught the last 2 cases :)
I don't think there were any variables called 'widget' in paginated_data_table.
Went through the declarations of a 'widget' variable in the codebase again. As far as I can tell, besides those 2, all remaining variables called 'widget' are in tests, the testing framework (as static methods), stateless widgets and lower level renderers.


Workspace symbols quick open do not highlight all query words

Version: 1.44.0-insider
Commit: d7d1147d6b764a48b789000c03088ee9afabcd8a
Date: 2020-03-31T08:22:34.682Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.6.0
Ref: #93645
Steps to Reproduce:

In vscode repo
Type query #foo actions platform
I would expect both actions and platform highlighted.

Does this issue occur when all extensions are disabled?: Yes/No

Quite a large change, needs verification. Now both workspace and editor symbol search will take each query input after the first to match on the container, e.g. a query like foo bar xyz more will  match foo on the symbol name and individually bar, xyz and more on the container.


Icons doesn't work in android 4.2 built-in browser.

I'm using Android 4.2. And I found the icon of materialize  can't display at all in the built-in browser of Android 4.2. It would be great if the compatibility to android browser could be supported..

If can confirm it doesn't work, you can open an issue https://github.com/google/material-design-icons

@Dogfalo I think It is not the issue of "material-design-icons".
In previous versions, materialize used "CSS classes" to draw icons, font-awesome also uses this way and it works perfect in android browser.
However, materiallize use "icon-font" to replace "CSS font class" later. Maybe it is more convenient, but icon-font is not supported in Android built-in browser. (at least not supported in android 4.2).
It seems that google doesn't use "icon-font" themselves. They just use "png" for icons. As can be seen in the link below..
https://plus.google.com/+anilsabharwal/stories/e39549b6-120c-3653-b456-2457c19f8e56

The icon font is made by google, http://google.github.io/material-design-icons/#icon-font-for-the-web


Upgrade Microsoft.Azure.WebJobs.Extentions.Storage and Microsoft.Communication.Sms Packages

1.Upgrade this project with the latest version of the package Microsoft.Azure.WebJobs.Extentions.Storage.
2.Upgrade this project with the latest version of the package Microsoft.Communication.Sms.

Removing the class Azure.Communication.PhoneNumber, and using type string to replace it.

@scottaddie, @AlexGhiondea, @kyle-patterson , @tg-msft, @amishra-dev for notification

@JoshLove-msft - Update according to your comments, please re-review it, thanks!

@jongio Please help merge this PR. Thanks.

@jongio Please help merge this PR. Thanks.

@isaacrlevin Do you have permission to merge this PR? If you have, help merge this PR. Thanks a lot.

@jemed Do you have permission to merge this PR? If you have, help merge this PR. Thanks a lot.

@jemed Do you have permission to merge this PR? If you have, help merge this PR. Thanks a lot.

@jemed Do you have permission to merge this PR? If you have, help merge this PR. Thanks a lot.

@jongio I have contacted Jemed on Teams, he does not have permission to merge this PR.
So, who should we ask to help merge?

@bradygaster - Could you please review/merge?  Thanks!

done, sir!


Move scripts to /scripts directory | PSP Airkeeper

There are files load-secrets-env.js and export-aws-env.sh that should be moved to the /scripts directory.
As part of this move, both should be rewritten in TypeScript.

Yeah, I guess it's fine keeping it in JS :slightly_smiling_face:


[AMQP Python] AMQP Error Handling + Retry Policy

error handling should include

standard amqp error
non-standard amqp error

azure specific

retry policy which is extendable for customized logic

think EH/SB as an application library

there're TODOs in the amqp code/comments in error retry PR -- will spawn new issues based on the feedbacks.


Enhancement: support more tokio-postgres types

Goal-State/What/Result
Support the next most important data types.
Why/Purpose
More supported data types mean more supported datasets.
Spec
Newly supported types should fit arrow_sql_gen/src/postgres.rs.
How/MAP
A list of tokio-postgres to arrow types, testing strategy and remarks.
Implementation (issues)

[ ] TIMESTAMPTZ to Timestamp(TimeUnit::Millisecond, None), testing TBD, not sure if tokio-postgres chrono handles TZ automagically, draft
[ ] UUID to FixedSizeBinary(16), testing TBD, draft

QA
The issue would remain open for some feedback on test strategy and more desired types.

@ahirner , thanks for your drafts, I am looking at this one now. Will do some tests.


Storage misc changes

Biggest change here is to increase memorypipe buffer so that if sender fails before sending anything, we can close the sender side and still allow the recv side to send a close signal even if they have already sent opening message.

Testsuite passed


do not take interrupts when single stepping

I don't understand this PR. Doesn't this do the oppsite of the title? Also, seems it is reverted by #157

Hi @christian-herber-nxp , ideally this and #157 would have been the same PR by I wanted to keep them separated to mimic the history of Ibex's commits. So this PR removes the debug_single_step_i from the handle_irq signal. That means that if the debug_single_step_i is high and you receive an interrupt, you ignore the interrupt request.
#157 instead depends on this PR as written in its message box, so once this one is merged, I will solve the conflict of #157, and what that PR will look like is simply to ingore the MIE in U-mode, which means that if you are in U-mode, you always take an interrupt

I think i would suggest to retarget this PR here to the other PR, and to squash merge it. Then we have a cleaner history in my opinion

Hi @christian-herber-nxp , ideally this and #157 would have been the same PR by I wanted to keep them separated to mimic the history of Ibex's commits. So this PR removes the debug_single_step_i from the handle_irq signal. That means that if the debug_single_step_i is high and you receive an interrupt, you ignore the interrupt request.
#157 instead depends on this PR as written in its message box, so once this one is merged, I will solve the conflict of #157, and what that PR will look like is simply to ingore the MIE in U-mode, which means that if you are in U-mode, you always take an interrupt

I think i would suggest to retarget this PR here to the other PR, and to squash merge it. Then we have a cleaner history in my opinion

done @christian-herber-nxp


get versioning moved to async

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]

METRIC
VALUE

NEW DUPLICATED LINES DENSITY
0.0

NEW SECURITY HOTSPOTS
0

NEW CODE SMELLS
0

NEW VULNERABILITIES
0

NEW BUGS
0

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-4116

METRIC
VALUE

NEW DUPLICATED LINES DENSITY
0.0

NEW SECURITY HOTSPOTS
0

NEW CODE SMELLS
0

NEW VULNERABILITIES
0

NEW BUGS
0

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-4116


Adding Uploading and Publishing section

Hi @ladinesa @ndaelman-hu @JFRudzinski
I've been working on the Uploading and Publishing section. The structure is the one in the document.
I have a few remarks:

I felt we need to define a ''Glossary of terms'' for all these terms we go back all the time. I will keep it simple for now, and simply define the names of things we want to define, without defining them.
I am pretty much enforcing myself to follow a step-by-step format for the Howtos, but in ''How-to upload data'' I also felt the need to give a schematic explanation of what the sections in the uploads page are.

I am still working on the documents, specially for the References and to add a phrase for each of the normalizers, but you can maybe take a look? I'd like comments on the content, as well as on the English, so feel free to take your time, there is no pressure to review this in the incoming days.

Once this is merged, we can start merging styles across sections, and come up with a global and yet very specific style for the whole documentation (for example, on how we cross-reference things).
Closes #8

@JosePizarro3 I will see to add my review this evening, in case you need a 2nd one.

Hi @ndaelman-hu @JFRudzinski , thanks a lot for the effort in commenting on the changes. I will work on integrating the suggestions.
I'll keep it simple and resolve conversations when these are minor changes on the syntax, while commenting back when needed and leave the conversations open until they are fully resolved.
I will wait also for @ladinesa comments, as he is on sick leave, it will take a bit of time. But no problem, we just wait.

Hello again,
Thanks once more for the feedback. I think the page now reads much better. I will be happy if you can do another quick read (once more, there is no pressure or deadline for this, you can leave it for later next week) and see whether we missed something. I will keep working on the sections that are now "under construction" (with the exception of the Glossary).
Check out the new Contact section too.
I wanted to further comment: it will be nice if we can enforce certain style criteria using this section. This can be then transfer to other sections, so we can quickly work on them without caring about different styles. For example, titles of sections with "How-to ..." and "Explanation - ...", the fact that there might be always a "Overview" and a "References".

Hello @JFRudzinski @ndaelman-hu @ladinesa ,
Final round of reviews. The changes:

Change names of sections according to our meeting. Please, bear in mind I had to also change the names of folders, so references might be broken (if you do mkdocs serve you could see which ones).
Added Glossary and Contact pages.
Name Overview all first pages of sections.

Feel free to drop reviews whenever you feel it. Let's also keep the same organization (if possible) of "Overview", "How-tos", "Explanation - ..." and "References".

@ladinesa @ndaelman-hu @JFRudzinski thanks a lot for the help!
I think it might be a good idea to merge this. I added your feedback and suggestions, and I think we can move on into other sections and keep working in this documentation. After the feedback from Markus, I think this is a good idea, even if we end up deprecating this doc, most of what we are writing here will be probably saved into the general NOMAD doc.
Are you all OK with this? A simple approval or emoji would work for me to merge this.


[core-http] Adding documentation to everything undocumented

Here I am trying to document everything that is not yet documented in core-http.
There’s some context-overflow for me since I’m not very familiar with Autorest. Feedback appreciated!
Eventually:
Fixes #10734

@jeremymeng Please review

API changes have been detected in @azure/core-http. You can review API changes here

@xirzec requested me to hide the FetchHttpClient from the public API in a separate PR.

I have followed up on all of the feedback so far, and I have enabled auto-merge. I will make a separate PR removing the FetchHttpClient right after this one.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/91064

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/92396

Registration pull request created: JuliaRegistries/General/111222
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.6.0 -m "<description of version>" 804447d196a3d749ff28ca3d33fd0a162a09b137
git push origin v0.6.0


Compiling error

I am using Arduino IDE and ESP8266.

Previous version is compiling, but latest is producing the following error :
'UnSubscribe_sMQTTEventType' was not declared in this scope.

With previous version everything is working nicely only issue is the broker is able to receive short messages from cloud (though no such issue with local clients).   The below message is not received properly

"Timer1": {  "Enable": 0,  "Mode": 0,  "Time": "10:10",  "Window": 0,  "Days": "1000000", "Repeat": 1, "Output": 1, "Action": 0 }
but if length is  reduced then no issue while  receiving   Timer1{"Enable":0,"Mode":0,"Time":"10:10"}

What Arduino IDE are you using?
Can you tell me more about messages from the cloud? Something is lost or does not come at all, and what is written in the broker when logging? Thanks

I am using Arduino 1.8.19
It receives truncated message

Hello.

I don't have Arduino 1.8.19, I checked on Arduino 2, on version 0.1.7 there are no compilation errors.
Write a compilation log.
If a message comes from local clients in its entirety, then I think that we need to see if there are any restrictions on messages in the cloud.

i have Installed Arduino 2.0.2 and updated all the libraries
while compiling advance example getting the following error:
C:\Users\ss\Documents\Arduino\libraries\sMQTTBroker\examples\advancebroker\advancebroker.ino: In member function 'virtual bool MyBroker::onEvent(sMQTTEvent*)':
C:\Users\ss\Documents\Arduino\libraries\sMQTTBroker\examples\advancebroker\advancebroker.ino:23:45: error: cannot convert 'sMQTTNewClientEvent*' to 'sMQTTSubUnSubClientEvent*' in initialization
23 |                 sMQTTSubUnSubClientEvent e=(sMQTTNewClientEvent)event;
|                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
|                                             |
|                                             sMQTTNewClientEvent*
exit status 1
Compilation error: cannot convert 'sMQTTNewClientEvent*' to 'sMQTTSubUnSubClientEvent*' in initialization

Yes, you're right, it's a bug, I'll fix it. Thanks

Thanks, example advancebroker.ino is compiling without errors, but if publish is added in the sketch      broker.publish("Topic" , "message" );       getting the following error in Arduino
c:/users/s/appdata/local/arduino15/packages/esp8266/tools/xtensa-lx106-elf-gcc/3.0.4-gcc10.3-1757bed/bin/../lib/gcc/xtensa-lx106-elf/10.3.0/../../../../xtensa-lx106-elf/bin/ld.exe: c:/users/s/appdata/local/arduino15/packages/esp8266/tools/xtensa-lx106-elf-gcc/3.0.4-gcc10.3-1757bed/bin/../lib/gcc/xtensa-lx106-elf/10.3.0/../../../../xtensa-lx106-elf/lib\libc.a(lib_a-clock.o):(.literal+0x4): undefined reference to _times_r' c:/users/s/appdata/local/arduino15/packages/esp8266/tools/xtensa-lx106-elf-gcc/3.0.4-gcc10.3-1757bed/bin/../lib/gcc/xtensa-lx106-elf/10.3.0/../../../../xtensa-lx106-elf/bin/ld.exe: c:/users/s/appdata/local/arduino15/packages/esp8266/tools/xtensa-lx106-elf-gcc/3.0.4-gcc10.3-1757bed/bin/../lib/gcc/xtensa-lx106-elf/10.3.0/../../../../xtensa-lx106-elf/lib\libc.a(lib_a-clock.o): in function clock':
/workdir/repo/newlib/newlib/libc/time/clock.c:58: undefined reference to `_times_r'
collect2.exe: error: ld returned 1 exit status
exit status 1
Compilation error: exit status 1

hello, I compiled an example for esp8266 in arduino 2 and there were no linking errors

Hi,
i have  updated Arduino to 2.0.3, download and reinstall the latest library, while compiling the following sketch and gotting the same error
#include<sMQTTBroker.h>
class MyBroker:public sMQTTBroker
{
public:
bool onEvent(sMQTTEvent *event) override
{
switch(event->Type())
{
case NewClient_sMQTTEventType:
{
sMQTTNewClientEvent e=(sMQTTNewClientEvent)event;
e->Login();
e->Password();
}
break;
case LostConnect_sMQTTEventType:
WiFi.reconnect();
break;
case UnSubscribe_sMQTTEventType:
case Subscribe_sMQTTEventType:
{
sMQTTSubUnSubClientEvent e=(sMQTTSubUnSubClientEvent)event;
}
break;
}
return true;
}
};
MyBroker broker;
unsigned long Time;
unsigned long freeRam;
void setup()
{
Serial.begin(115200);
const char* ssid = "";         // The SSID (name) of the Wi-Fi network you want to connect to
const char* password = ""; // The password of the Wi-Fi network
WiFi.begin(ssid, password);
while (WiFi.status() != WL_CONNECTED) { // Wait for the Wi-Fi to connect
delay(1000);
}
Serial.println("Connection established!");
Serial.print("IP address:\t");
Serial.println(WiFi.localIP());
const unsigned short mqttPort=1883;
broker.init(mqttPort);
// all done
// your magic code
Time=millis();
freeRam=ESP.getFreeHeap();

};
void loop()
{
broker.update();
// your magic code
if(millis()-Time>1000)
{
Time=millis();
if(ESP.getFreeHeap()!=freeRam)
{
freeRam=ESP.getFreeHeap();
Serial.print("RAM:");
Serial.println(freeRam);
broker.publish("Topic", "message");     // added publish here
}
}
};

#include<sMQTTBroker.h>

class MyBroker:public sMQTTBroker
{
public:
bool onEvent(sMQTTEvent *event) override
{
switch(event->Type())
{
case NewClient_sMQTTEventType:
{
sMQTTNewClientEvent *e=(sMQTTNewClientEvent*)event;
e->Login();
e->Password();
}
break;
case LostConnect_sMQTTEventType:
WiFi.reconnect();
break;
case UnSubscribe_sMQTTEventType:
case Subscribe_sMQTTEventType:
{
sMQTTSubUnSubClientEvent *e=(sMQTTSubUnSubClientEvent*)event;
}
break;
}
return true;
}
};

MyBroker broker;
unsigned long Time;
unsigned long freeRam;

void setup()
{
Serial.begin(115200);
const char* ssid = ""; // The SSID (name) of the Wi-Fi network you want to connect to
const char* password = ""; // The password of the Wi-Fi network
WiFi.begin(ssid, password);
while (WiFi.status() != WL_CONNECTED) { // Wait for the Wi-Fi to connect
delay(1000);
}
Serial.println("Connection established!");
Serial.print("IP address:\t");
Serial.println(WiFi.localIP());

const unsigned short mqttPort=1883;
broker.init(mqttPort);
// all done
// your magic code
Time=millis();
freeRam=ESP.getFreeHeap();

};
void loop()
{
broker.update();
// your magic code
if(millis()-Time>1000)
{
Time=millis();
if(ESP.getFreeHeap()!=freeRam)
{
freeRam=ESP.getFreeHeap();
Serial.print("RAM:");
Serial.println(freeRam);
broker.publish("Topic", "message"); // added publish here
}
}
};


Setting the viewing angle of the image when displayed

Is it possible to make 2 settings (hfov, pitch, yaw) on one image?  For example, if we want to click the button to move forward (hotspot), the initial viewpoint of the image remains forward, and if we want to return to the previous image, the viewpoint of the image is from behind the image, such as when accessing Google Street View. Thank you in advance

You can use the targetPitch / targetYaw / targetHfov parameters on your hot spots. By setting these, you'll override the defaults for the scene. Or if you're using the API, loadScene method has optional parameters for setting the pitch, yaw, and hfov.


After closing the minimap, the cursor misbehave

After closing the minimap with :MinimapClose (or the mapping), the cursor in the main buffer can only move downwards (ie, j is the only working motion).

Fixed by #29


GH-43296: [C++][FlightRPC] Remove Flight UCX transport

Rationale for this change
This was experimental and we should not encourage it's use.
What changes are included in this PR?
Removal of UCX transport for Flight
Are these changes tested?
Via CI
Are there any user-facing changes?
Yes, we do remove UCX as a possible transport for Flight.
If users want something similar we should encourage the Dissassociated IPC protocol implementation

GitHub Issue: #43296

@kou @lidavidm should we just remove it, as proposed here, or do we have to announce the deprecation on one release and then do it on a follow up?
I did directly remove it because it was supposed to be experimental but let me know if you think it would be best to do it as a more "planned" deprecation process

Good idea, I added a suggestion to the PR

We currently utilize the UCX ArrowFlight transport, which provides significant benefits, particularly in reducing CPU utilization. I understand that with Arrow 18, we'll need to implement this transport ourselves to maintain our current functionality.
However, I have several concerns and questions regarding this decision:

Rationale for Removal: It's unclear why the UCX ArrowFlight transport is being removed and discouraged. As this feature was distributed as part of Arrow, we didn't anticipate it being discontinued.

Recommended Alternative: If Disassociated IPC is now the recommended approach, why isn't the UCX ArrowFlight transport being reimplemented using Disassociated IPC and distributed as part of Arrow?

User Abstraction: From a user perspective, the ability to choose a transport by simply prefixing the URL (e.g., ucx: or grpc+tcp:) provides a convenient abstraction. What's the motivation behind removing this abstraction and requiring users to implement protocol details themselves?

Impact on Existing Users: Given that this feature is already in use and providing benefits, have you considered the impact on existing users who rely on this functionality?

Migration Path: Could you provide guidance or a migration path for users who need to transition away from the UCX ArrowFlight transport?

We would appreciate more clarity on these points and any considerations for maintaining similar functionality within the Arrow project.

Hi,
It is great that you shared your concerns. Thanks for doing that I am happy to have a discussion around this as this was the expectation when I sent the initial email to the Mailing list over a month ago (See: https://lists.apache.org/thread/g89x2y6pvlq6gyf0d1jnxfl2onsrkyt8)
@amirgon I am not an expert on UCX but as the one proposing the removal after some discussions with other maintainers, I am going to answer here. I would love to move the conversation to the mailing list to give more visibility to the issue and so other experts can join the conversation too.

1. **Rationale for Removal**: It's unclear why the UCX ArrowFlight transport is being removed and discouraged. As this feature was distributed as part of Arrow, we didn't anticipate it being discontinued.

Since the beginning this was an experimental proof of concept. Quoting from the Mailing list:

Replacing gRPC was not the intent.
The disassociated protocol is worded very generically, but works over UCX and libfabric, so it is essentially equivalent but does not force you to use the predefined Flight RPC method names so it is more flexible in that recard.

As you comment, this was distributed as part of Arrow but as experimental. Usually there is a discussion on the mailing list and sometimes those experimental features might be deprecated in favour of other alternatives, from the documentation we can see it was always experimental:
The standard transport for Arrow Flight is gRPC_. The C++
implementation also experimentally supports a transport based on
UCX_. To use it, use the protocol scheme ``ucx:`` when starting a
server or creating a client.

Non-experimental features require a more strict deprecation method in case we as a community decide to do so, that's what happened with Plasma, for example.

2. **Recommended Alternative**: If Disassociated IPC is now the recommended approach, why isn't the UCX ArrowFlight transport being reimplemented using Disassociated IPC and distributed as part of Arrow?

As shared on the ML, this can be done but the Disassociated IPC protocol also allows a more flexible approach without having to use the same methods Flight RPC methods so being more flexible. Whether we want to reimplement ArrowFlight UCX using Dissassociated IPC is something that can be proposed / requested and done. I don't see an impediment to that.

3. **User Abstraction**: From a user perspective, the ability to choose a transport by simply prefixing the URL (e.g., `ucx:` or `grpc+tcp:`) provides a convenient abstraction. What's the motivation behind removing this abstraction and requiring users to implement protocol details themselves?

I don't have context about this and I am sure this could be discussed with experts on that area on the ML thread.

4. **Impact on Existing Users**: Given that this feature is already in use and providing benefits, have you considered the impact on existing users who rely on this functionality?

Yes, that's why we sent the mail to the mailing list to get feedback and where development discussion should happen. We also were going to add information to the blog post of the 17.0.0 release and I was suggesting whether a two release process for announcing the deprecation vs removing it was necessary or not, as we did for example for Plasma.

5. **Migration Path**: Could you provide guidance or a migration path for users who need to transition away from the UCX ArrowFlight transport?

In the past we've done similar guides for example when plasma was deprecated, see this mailing list thread here: https://lists.apache.org/thread/lk277x3b9gjol42sjg27bst2ggm5s0j2
I suppose we could try and do something like this.

We would appreciate more clarity on these points and any considerations for maintaining similar functionality within the Arrow project.

Please @lidavidm @zeroshade as the subject matter experts let me know if you want me to clarify something around that.

(3) is the same argument: it may be convenient but it locks you into those methods, and I at least have come around to thinking that is a mistake for non-trivial applications. The disassociated IPC proposal is more flexible than that, and eventually I would like to make the base gRPC transport equally flexible.
For (4), if there's people willing to maintain it's possible the conversation may be different. Note that the tests were never fully enabled in CI because of flakiness, so there were already known issues in the implementation.

I plan to merge this if no more concerns are raised. @kou @lidavidm should I update the blog post for 17.0.0 release, send an email to the Mailing List (dev + user) announcing we are removing it or do we want to hold this until 19.0.0?

That said given the known deadlocks I'm surprised it actually works in practice :sweat_smile:

That said given the known deadlocks I'm surprised it actually works in practice 😅

@lidavidm Could you elaborate on these "known deadlocks"? Where are they documented?

I agree with David. Can we defer this after the 18.0.0 release?

@amirgon
https://github.com/apache/arrow/issues/35742
https://github.com/apache/arrow/issues/35587
https://github.com/apache/arrow/issues/31543

We did add the following to the 18.0.0 blog post: Flight UCX is deprecated. We plan to remove this experiment in the next couple of releases.
https://arrow.apache.org/blog/2024/10/28/18.0.0-release/
We haven't added explicit deprecation methods. What should be the plan going forward here? Should we remove it targeting 20.0.0?

If we can we should add deprecations then remove the code in the following release.

I think we only need to deprecate InitializeFlightUcx

I've created an issue to add the deprecation:

https://github.com/apache/arrow/issues/45079


Update sbt-ci-release to 1.5.7

Updates com.geirsson:sbt-ci-release from 1.5.6 to 1.5.7.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.geirsson", artifactId = "sbt-ci-release" } ]

labels: sbt-plugin-update, semver-patch

Unclear why GHA is wedged on "Delete Artifacts" ... merge anyway?

It look like the "Delete Artifacts" requirement was a leftover from the Travis build. I've removed it and it looks like we're good :smile:


Getting NetworkOnMainThreadException

Caused by: com.goebl.david.WebbException: android.os.NetworkOnMainThreadException
This is my method:
public JSONObject getPopularMovies() {
Response jsonResponse = reqObj.get("https://api.themoviedb.org/3/movie/popular")
.param("api_key", API_KEY).ensureSuccess().asJsonObject();
JSONObject movieData = jsonResponse.getBody();
    return movieData;
}

Thanks for creating an issue. There are many Android programmers who stumble over NetworkOnMainThreadException.
This is not a problem caused by DavidWebb itself. Please have a look at http://stackoverflow.com/questions/6343166/android-os-networkonmainthreadexception
If it's too cumbersome to wrap all http access code in things like AsyncTask, then you could consider using another library like Volley.


Update the typo in init.py

I cleared a small typo in this file
as as to as a

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Only show visits for the current trust on trust overview metrics

What
Update retrieveWardVisitTotals to accept an optional trustId parameter and modify trust-admin to pass the trustId.
Why
The function will now return data for all trusts if no trustId is passed or filter the visit data to include only that for the specified trust.
Screenshots
Notes

Picking up this PR and will add in a contract test.


[Bug] When English is selected, chinese masks should not be shown

📦 Deployment Method
Docker
📌 Version
2.15.3
💻 Operating System
Ubuntu
📌 System Version
22.04
🌐 Browser
Firefox
📌 Browser Version
latest stable
🐛 Bug Description
We are very happy with using NextChat as our OpenAI API Webinterface and we use it in English.
When we use it all of the CN and TW masks show up, which is confusing for our users because we are european and can't read it.
Currently we have to manually adjust the source code, so the tw and cn masks are not included.
📷 Recurrence Steps
No response
🚦 Expected Behavior
It would be great to have one of two options:

Define the types of masks to include in the .env-File
Enable/Disable the correct masks based on the language selected

📝 Additional Information
No response

在masks页面中可另外选择语言，如选择english来筛选对应语言的mask

Thank you for the suggestion.
We have many users and if I understand correctly, every user would have to do this.
Can this be made configurable with a variable in the .env file?
That would be great!