Build failure on osx

As per the README
brew install gpgme
git clone https://github.com/projectatomic/skopeo $GOPATH/src/github.com/projectatomic/skopeo
cd $GOPATH/src/github.com/projectatomic/skopeo && make binary-local

Output:
go build -ldflags "-X main.gitCommit=91606d49f2f7d17c226940e98b5f42500a4c3efb" -gcflags "" -tags "btrfs_noversion libdm_no_deferred_remove" -o skopeo ./cmd/skopeo
# pkg-config --cflags ostree-1 ostree-1 ostree-1 ostree-1 ostree-1 ostree-1
Package ostree-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `ostree-1.pc'
to the PKG_CONFIG_PATH environment variable
No package 'ostree-1' found
Package ostree-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `ostree-1.pc'
to the PKG_CONFIG_PATH environment variable
No package 'ostree-1' found
Package ostree-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `ostree-1.pc'
to the PKG_CONFIG_PATH environment variable
No package 'ostree-1' found
Package ostree-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `ostree-1.pc'
to the PKG_CONFIG_PATH environment variable
No package 'ostree-1' found
Package ostree-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `ostree-1.pc'
to the PKG_CONFIG_PATH environment variable
No package 'ostree-1' found
Package ostree-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `ostree-1.pc'
to the PKG_CONFIG_PATH environment variable
No package 'ostree-1' found
pkg-config: exit status 1
make: *** [binary-local] Error 2

Looks like we need  a way to compile out the ostree support in containers/image for platforms that do not support it.

Thanks for your report.
Could you test and report back whether
make binary-local BUILDTAGS=containers_image_ostree_stub

works, please? If so, we can at least update the README, or a tested PR automating this for macOS would be also welcome.
(I can’t find a brew recipe for libostree, and with https://github.com/ostreedev/ostree/blob/master/src/libostree/ostree-linuxfsutil.c it seems unlikely that it would easily build for macOS, so compiling it out seems to be the right thing to do.)

Should we just add an ostree tag, and then only build ostree if this is specified?  Then we can get all of our Linux packages to specify ostree?

make binary-local BUILDTAGS=containers_image_ostree_stub

does indeed work

Great, thanks for testing. #381 is a minimal README update; autodetecting macOS in Makefile and adding the tag to LOCAL_BUILD_TAGS would be nice but I’ll leave that up to someone with a macOS development environment set up.

Is this fixed by #382?


Remove AMP not working

Describe the bug
The privacy option "AMP entfernen" (German edition) is enabled. Opening Links through Google search still shows the AMP version of the website.
Additionally the AMP version does not load (blank Screen).
To Reproduce
Steps to reproduce the behavior:

update to latest Release
enable AMP removal in privacy options

Expected behavior
Instead of AMP version, the original website should be loaded
Screenshots

Smartphone (please complete the following information):

Device: POCO F3
Android Version : 13
Kiwi Browser Version 116.0.5845.61

Additional context
This issue appears since updating to 116.0.5845.61.

Same problem for me. Poco X3, MIUI 14, Android 12.

Same problem on my Pixel 7 Pro.

You can use "disable amp" user script from Adguard as temporary solution.

Bug!
Temp fix - chrome extension Redirect AMP to HTML.


Correct PUG-Filters incorrectly marked as syntax--invalid and syntax--illegal

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

...
Description
Correct PUG-Code with filters defined at PUG filters incorrectly marked as .syntax--invalid and .syntax--illegal

Steps to Reproduce

Type into any .pug-file:

div
  :markdown-it(html typographer plugins=['markdown-it-sup', 'markdown-it-deflist', 'markdown-it-attrs'])

and see wrong syntax-highlighting.
Versions
Microsoft Windows [Version 10.0.14393]

$ atom --version

Atom    : 1.13.0
Electron: 1.3.13
Chrome  : 52.0.2743.82
Node    : 6.5.0

Thanks for contributing!
It appears that this is being caused by the language-pug package, not Atom itself. It may be that there is still a bug in Atom. If so, we'll need the maintainer of the package that is causing the problem to help track that down. You should file this issue on their repository so they can either fix the problem or tell us where the problem is coming from. The Atom FAQ has information on how to contact the maintainers of any Atom community package or theme.


Config file is parsed every minute and "WARNING failed to parse /etc/keyd/default.conf"

I have two laptops with similar hardware and almost the same software. They share exactly the same keyd configuration. I am using both /etc/keyd/default.conf and ~/.config/keyd/app.conf.
On one device keyd works perfectly fine, on the other the Application Specific Remapping often fails. It will work, then 30 seconds later my custom keyd key bindings aren't picked up, then 30 seconds later it will work again.
Running journalctl -b /usr/bin/keyd on the good device displays just a couple of lines, showing the configuration file is parsed at boot time. Running the same command on the bad device shows something completely different: there is a warning WARNING failed to parse /etc/keyd/default.conf and the config file is parsed every minute.
I have tried to remove and reinstall keyd several times.  Do you have keyd reload present in any of your custom scripts?

I just noticed your logs suggest you are running an older commit (eeea96a) than what you originally posted. Can you pull and build from the latest version and make sure the issue is still reproducible?


Update for azure synapse analytics rebranding

Azure SQL Data Warehouse is now called azure synapse analytics

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d863ab39-0b6a-eb81-9dde-5eb25b46cc33
Version Independent ID: 655abadf-5f9e-a65b-0109-c5166f956c4d
Content: Tutorial - Perform ETL operations using Azure Databricks
Content Source: articles/azure-databricks/databricks-extract-load-sql-data-warehouse.md
Service: azure-databricks
GitHub Login: @mamccrea
Microsoft Alias: mamccrea

Hi @Balfa. Thanks for bringing this to our attention. We will be updating docs to coincide with portal updates targeted for mid-January.
#please-close

@mamccrea Thanks for the update. :+1:


Allow :meth:.VGroup.add to use iterables of VMobjects

Closes #3540
Allows for statements like:
VGroup(
    Square(),
    [Circle()],
    (x.shift(RIGHT) for x in [Star(), Triangle()])
)

Also added a test for this.
As MrDiver said, it's annoying to have to unpack iterables with the * operator.

Closing this as the performance hit for checking if an object is not a VMobject is a bit excessive.


Update Fedora Docker files from master branches in dist-git.

Master branch should have the latest images.

I have no idea what happened on RHEL8 when I change only Fedora images.

[test]

More general error, great.
+ rsync -avzP -e 'ssh -F ssh_config' /var/lib/jenkins/workspace/rhscl-images-s2i-rh-rhel8/ host:sources
ssh: connect to host <IP_ADDRESS> port 22: No route to host
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: unexplained error (code 255) at io.c(226) [sender=3.1.2]

Looking for help here @phracek @pkubatrh

This looks like some CI mishap. Going to try rerunning the job

[test]

[test-openshift]

I have no idea what is happening there:
14:05:42 + docker run -d --rm --cidfile=/tmp/tmp.icphybhmHr/cid centos/ruby-26-centos7-testapp
14:05:42 Unable to find image 'centos/ruby-26-centos7-testapp:latest' locally
14:05:42 Trying to pull repository docker.io/centos/ruby-26-centos7-testapp ...
14:05:42 /usr/bin/docker-current: repository docker.io/centos/ruby-26-centos7-testapp not found: does not exist or no pull access.

[test]

Looks like a bug that will eventually be fixed by https://github.com/sclorg/s2i-ruby-container/pull/247
rhel7 specific, so we can ignore the failure for this PR


Please allow changing order by format

Hi please allow us to do it by order for example webm and ogv should be like this
webm
360p
480p
and so on
and ogv should look like
ogv
360p
480p

I'm not really understanding what you are asking here. Could you provide an example of what you are hoping to achieve?

Ok an example is for example
webm
360p
460p
so that the resolutions are under there correct video or audio format.

Umm, that just looks like your original post again. Are you saying that in the menu that is generated, you want the resolution options broken down by file type? So you user can choose either the 360p webm file or the 360p mp4 file?

Yes but like currently it dosent say webm only shows resolutions it would be greate if the resolutions were organised into the formats they are for.

Ok, I think I understand what you're looking for now. I don't think I want to head down that road with this plugin. As a user, I don't really care what the file format is, I just want the video to play. So, I want to keep the options as simple as possible on this plugin.
I'm going to go ahead and close this for now, but feel free to add any other thoughts you had.

Ok but what about adding a option.

Probably not given the added complexity it would bring to the project. For example, there would probably need to be some way to determine if the browser supports a given file type (otherwise the UX would be pretty bad when the user tries to select a resolution that his browser doesn't support). So we're left with reinventing some core Video.js functionality or trying access low level details about the files.


think about access rights

https://github.com/mylims/backend/blob/68e0d8dd6d998bb849cc088b3036b79e5f813fed/src/experiment/experiment.schema.ts#L17-L17

Add groups
Read, write and rw


[Feature]:  change the video component

Is your feature request related to a problem? Please describe.
No response
Describe the solution you'd like

change the whole video component like above image
Describe alternatives you've considered
No response
Additional context
No response

@mnnkhndlwl , I would like to work on this issue under jwoc. Can you please assign it to me?

@Laxmankohar assigned

@mnnkhndlwl  bro, Can you explain a little bit more. I am getting confuse like on which part should i work.

you have to change like , dislike button share button subscribe button or any other ui change that you think look good you can do

@mnnkhndlwl bro, Have a look .

looks great

looks great

I have changed the position of subscribe button, is it ok?? Can I make a PR?

Haan bro


Portfolio website and update ProjectList Fixes #58

Describe your change:

[X] Add a Project?
[ ] Fix a bug or typo in an existing Projects?
[ ] Documentation change?

Checklist:

[X] I have read CONTRIBUTING.md.
[X] This pull request is all my own work -- I have not plagiarized.
[X] I know that pull requests will not be merged if they fail the automated tests.
[X] This PR only changes one Project folder.  To ease review, please open separate PRs for separate algorithms.
[X] All new Project files are placed inside an existing directory.
[X] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings
[X] The title of my pull request is a short description of the requested changes.
[X] I have made corresponding changes to the documentation
[X] My PR needs documentation change

ATTACH SCREEN-SHOTS

Before
After

< After Image >

Sir i have raised the PR, please review it.
Thanks.

The PR from this repo is being accepted in hacktoberfest2023

Thanks sir for accepting my PR, it was nice contributing in this repo. Sir i just want to confirm if this repo is still in hacktoberfest 2023, because i checked on the website it showed that this repo is excluded.vPlease confirm sir.
Thanks once again.

This repo has been recently excluded from hacktoberfest
But Idea-Arca is being accepted


feat:typescript migration

baseline for the migration efforts

@cjpillsbury I got permissions errors when trying to commit to this branch, or create a new one, so I copied all of this over to my fork and used it as a base for https://github.com/muxinc/media-chrome/pull/931.

closed by https://github.com/muxinc/media-chrome/pull/931


‘Adjust Date’ screen is displayed for a while when the user launches the application after changing the date from the phone setting.

Frequency: 80%
Repro App version: Test Flight build v1.2.0 (26)
Repro on devices: iPhone 11 (14.0)
Does not repro on devices: Samsung Galaxy A50s(10.0) , Samsung Galaxy A3(5.0.2) , iPhone Xs max (13.0)
Repro Steps:

Change date from setting.
Launch the application.
Refresh the application.
Observed that Adjust date screen is displaying for a short period.

Current Behavior: ‘Adjust Date’ screen is displayed for a while.
Expected Behavior: Screen should be displayed until the user taps on the ‘Adjust Date’ button.
Impact: User is not able to understand whether the date is correct or not.
Attachment: AdjustDateNotDisplaying.mp4

Hi @jeanregisser  I have verified this issue using latest android internal build v1.3.0(1004294316) using lower end devices & observed that issue is still reproduced.
Repro on devices: Samsung Galaxy A3(5.0.2) , Samsung Galaxy A5(7.0)
Observation: Also it is observed that on lower end devices 'Adjust Date' screen is not displaying for short time also. Instead of that 'Unable to load your feed. Please try again later' massage is displaying continuously even though there is strong network connection.

Hi @jeanregisser I have verified this issue using latest android internal build v1.3.0(1004294316) using lower end devices & observed following.
Observation:
Background & foreground app:-

All months activity are merged in Recent section If user change date from phone setting while app running in background.

Kill & Relaunch app:

'Unable to load your feed. Please try again later' massage is displaying If user kill & relaunch app after changing date from phone setting.

Repro on devices: Samsung Galaxy A5(7.0)

Hi @jeanregisser I have verified this issue using latest android internal build v1.5.5(1004294326) & observed following.
Observation:
Background & foreground app:-

All months activity are merged in Recent section If user change date from phone setting while app running in background.

Kill & Relaunch app:

'Unable to load your feed. Please try again later' massage is displaying If user kill & relaunch app after changing date from phone setting.

Repro on devices: Samsung Galaxy A5(7.0)

Hi @jeanregisser I have verified this issue using latest android internal build v1.7.2(1004294329) on lower end devices with low internet connection & observed following.
Verified on devices: Samsung Galaxy S4(4.4.2)
Observation:

User not able to gate Adjust Date screen
Also it is observed that vice versa screens are displayed with 'all activities are merged in Recent section' & 'Unable to load your feed. Please try again later' massage.

Hi @jeanregisser I have verified this issue using latest Android internal build v1.8.0(1004294330) & Test Flight Build V1.8.0(40) observed following.
Observation:

It is observed that all activity are merged in Recent section when user warm launch the app after chnaging date.
Also it is observed that 'Unable to load your feed. Please try again later' massage displayed when user refresh application on home screen after warm launch.
Repro on devices: Samsung Galaxy A5(7.0),iPhone XR(13.1.3)

Hi @jeanregisser I have verified this issue using latest Android internal build v1.8.0(1004294330) & Test Flight Build V1.8.0(40) observed following.
Observation:

It is observed that all activity are merged in Recent section when user warm launch the app after chnaging date.
Also it is observed that 'Unable to load your feed. Please try again later' massage displayed when user refresh application on home screen after warm launch.
Repro on devices: Samsung Galaxy A5(7.0),iPhone XR(13.1.3)

Hi @jeanregisser I have verified this issue using latest Android internal build v1.9.2(1004294333) & Test Flight Build V1.9.2(43) observed following.
Observation:

User not able to gate Adjust Date screen after changing date from phone settings.

It is observed that all activity are merged in Recent section when user warm launch the app after changing date.

Also it is observed that 'Unable to load your feed. Please try again later' massage displayed when user refresh application on home screen after warm launch.

Repro on devices: Samsung Galaxy A5(7.0),iPhone XR(13.1.3)

Hi @jeanregisser I have verified this issue using latest Android internal build v1.9.2(1004294333) & Test Flight Build V1.9.2(43) observed following.
Observation:

User not able to gate Adjust Date screen after changing date from phone settings.

It is observed that all activity are merged in Recent section when user warm launch the app after changing date.

Also it is observed that 'Unable to load your feed. Please try again later' massage displayed when user refresh application on home screen after warm launch.

Repro on devices: Samsung Galaxy A5(7.0),iPhone XR(13.1.3)

Hi @jeanregisser I have verified this issue using  latest  Android Internal Build V1.11.0(1004294337) & Test Flight Build V1.11.0(47) & observed that issue is still reproduced.
Repro on devices: Samsung Galaxy A5(7.0),iPhone XR(13.1.3)


docs: support dark theme

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information
Ref https://github.com/ant-design/ant-design/pull/18855

This is cool!


Change Style of Header and Footer

I am trying to change the style of the header and footer in my word document using pydocx. However, after going through the documentation of section, header and footer objects I noticed there is no style attribute present. However in normal word I am able to change the style manually. Is there anyway to change the header and footer style using pydocx.

PyDocx is a different package from python-docx. Please direct questions for that project to its support site.
Support questions for python-docx are directed to StackOverflow using the python-docx tag.


docs: cleanup formatting and comment typos

Fix typo in LualineNotices
Rename misspelled function parameter diff
Cleanup minor typos and wording in comments
Cleanup minor typos and wording in docs, i.e. README, CONTRIBUTING, THEMES

Initially I spotted a small misspelling in the LualineNotices output: paris -> pairs
https://github.com/nvim-lualine/lualine.nvim/blob/c12b1673107c181e32ce54f2dc4c76a2a884d7ba/lua/lualine/utils/loader.lua#L113
But I took the plunge on improving spelling and readability where I spotted issues across most files.
A few changes might be a bit pedantic, like spellcapcheck errors but excluding those, I think a bit of cleanup here and there makes the project more presentable and easier to navigate.
Themes
A lot of theme files had the same misspelled comments, I believe Line 85 of the theme conversion tool has a single typo that likely propagates to any themes that are created using the script.
Genarated -> Generated
lightline2lualine_theme_converter.lua
https://github.com/nvim-lualine/lualine.nvim/blob/c12b1673107c181e32ce54f2dc4c76a2a884d7ba/lua/lualine/themes/ayu_dark.lua#L3
I can't make a PR on a gist, so fixing this should prevent new themes from introducing more misspellings.

Pushed the suggestions and a few more things I spotted.
Let me know if there's anything else 👍

Well, that was a decent excuse to read through a bit on how the plugin functions.
For now, I don't see anything else worth worrying about.

Thanks a lot. The docs definitely needed some work.


Lock ng2-ckeditor and @types/jasmine minor versions

Please read and mark the following check list before creating a pull request (check one with "x"):

[x] I read and followed the CONTRIBUTING.md guide.
[x] I read and followed the New Feature Checklist guide.

Short description of what this resolves:
Fixes #5897 by locking the dependency versions on the current minor version. (I compared the minor version of masters package-lock.json with the package.json. Through the ^, npm installed a minor version that is not compatible with the codebase)

Note: In Order to get rm package-lock.json && npm i --legacy-peer-deps && ng serve working again the following MRs must be merged:
#5894 #5896 #5898
(=> i let the package-lock.json untouched, so merging the MRs independently should not destroy anything and new users should be able to clone and start the project in every merge state. Only for web-developers who need a fresh package installation this will have an impact)
To see all changes of the three MRs together, see comparison in my fork: https://github.com/MaaxGr/ngx-admin/compare/cabe4bd71aa63374c5e3588a0a3c08ae976829b4...910b4c4c6aa2003ea3d651cc65012db2cd140aa7

It must be merged asap,
ref: https://github.com/akveo/ngx-admin/issues/5893

👍


Show name, instead of description, when adding preseed to a machine

The drop-down menu only displays the "Description" which, if empty, is omitted and looks weird.
Either show just the name (which is compulsory), or show both name and description, but not just description.

Name and description sounds good.


💡[FEATURE]: Pension Fund Optimization

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Description: Optimize the allocation of pension funds to maximize returns and minimize risk.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Key Techniques: LSTM for predicting asset returns, DNN for risk assessment, and reinforcement learning for portfolio optimization.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@Akshat111111 pls assign it me


Ex Nihilo Sieve Recipes

It would be nice if you exposed unregisterRewardFromAllBlocks and unregisterAllRewardsFromBlock, possibly as removeFromAll(outputstack) and removeAllFrom(inputstack). And please update the wiki to reflect the new method signatures :)
Also reloading isn't quite working. Any removed sieve recipes get stuck when reloading.

Second this, also heat sources dont seem to register as well.

Check the latest build please!


fix: IK bugs

What does this PR change?
Fixes #566
Fixes #695
How to test the changes?

Bump into a wall, hands should react in a proper position,
Put your character over the edge of any mesh, feet should reposition properly.
Put your character over the edge of any mesh, the character should not lean backward.
Trigger an emote, all IK's should get disabled.

Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

At some point we will need to implement pole targets for the knees so this doesnt happen. The rest is working like a charm for me

At some point we will need to implement pole targets for the knees so this doesnt happen. The rest is working like a charm for me

well they are implemented, we probably need to tweak them a bit


Upvoting pin hides it from "Local Places"

To replicate:

Go to Local Places
Upvote a pin
Close Local Places and open it again

It could be that our query that sorts these pins are a bit off (my understanding is that the most up voted pins appear at the top). I modified a pin to have likes at -5 and it appeared at the top, so perhaps we're sorting them in increasing order.

The places view currently sorts by ascending number of votes. Will tackle this ASAP.


verbose stack dump when ICAT server tries restaging data object via resource server lacking proper configuration

Setup

Configure two systems, producer and consumer , as ICAT and resource server respectively.
Follow directions in UGM 2018 Storage Tiering advanced training slides, specifically pp 20-24, making sure that the storage and coordinating resources (st_ufs[0-5] and rnd[0-2]) are located on consumer.
However, leave out the configuration stanza for the storage tiering plugin on the consumer's /etc/irods/server_config.json

Execution

Set up an icommands client environment on consumer, under the non-irods Linux login, that points to the rods admin account on producer
In that environment, do a put -R rnd0 testfile (testfile can be small, even zero-length)
Verify with imeta ls -d testfile that an access time has been set by producer's instance of the storage tiering, then wait until the output of date +%s  is at least 30 seconds greater than that access time.
Again within the environment pointed at producer , execute:
irule -F ~irods/example_tiering_invocation.r

What Happens

ICAT server, producer, attempts to restage testfile from rnd0 to rnd1 ; but, it cannot because the plugin is not configured on resource server, consumer. The evidence will be found in the rodsLog file on both ICAT server, as shown below. Please note the producer and consumer are <IP_ADDRESS> and <IP_ADDRESS> respectively.
On the ICAT we see:

irods@producer:~$ cat log/rodsLog.2018.08.26
Aug 30 17:32:12 pid:1834 remote addresses: <IP_ADDRESS>, ::1 ERROR: apply_storage_tiering_policy :: no resources found for group [example_group_g2]
Aug 30 17:32:12 pid:1834 remote addresses: <IP_ADDRESS>, <IP_ADDRESS>, ::1 ERROR: iRODS Exception:
    file: /tmp/tmptUX32X/irods_storage_tiering.cpp
    function: void irods::storage_tiering::migrate_violating_objects_for_resource(const std::string &, const std::string &, ruleExecInfo_t *)
    line: 593
    code: -1201000
    message:
        restage failed for object [/tempZone/home/rods/testfile] from [rnd0] to [rnd1]
stack trace:
--------------

Dumping stack trace
<0>	Offset: 0x65  	Address: 0x7f36aa2072f5	irods::exception::exception(long, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
<1>	Offset: 0x43  	Address: 0x7f36aa207473	irods::exception::exception(long, boost::basic_format<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
<2>	Offset: 0x62c 	Address: 0x7f36a8c15a6c	irods::storage_tiering::migrate_violating_objects_for_resource(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, RuleExecInfo*)
<3>	Offset: 0x8b  	Address: 0x7f36a8c188eb	irods::storage_tiering::apply_storage_tiering_policy(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, RuleExecInfo*)
<4>	Offset: 0x76d 	Address: 0x7f36a8bf0c9d	exec_rule_expression(std::__1::tuple<>&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, MsParamArray*, irods::callback)
<5>	Offset: 0x2f  	Address: 0x7f36a8c065df	std::__1::__function::__func<irods::error (*)(std::__1::tuple<>&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, MsParamArray*, irods::callback), std::__1::allocator<irods::error (*)(std::__1::tuple<>&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, MsParamArray*, irods::callback)>, irods::error (std::__1::tuple<>&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, MsParamArray*, irods::callback)>::operator()(std::__1::tuple<>&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, MsParamArray*&&, irods::callback&&)
<6>	Offset: 0xf0  	Address: 0x7f36ad240280	irods::pluggable_rule_engine<std::__1::tuple<> >::exec_rule_expression(std::__1::tuple<>&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, MsParamArray*, irods::callback)
<7>	Offset: 0x354 	Address: 0x7f36ad240114	irods::rule_engine_context_manager<std::__1::tuple<>, RuleExecInfo*, (irods::rule_execution_manager_pack)0>::exec_rule_expression(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, MsParamArray*)
<8>	Offset: 0x25e 	Address: 0x7f36ad23faee	rsExecRuleExpression(rsComm_t*, exec_rule_expression_t*)
<9>	Offset: 0x44  	Address: 0x7f36ad4440e4	irods::api_call_adaptor<exec_rule_expression_t*>::operator()(irods::plugin_context&, rsComm_t*, exec_rule_expression_t*)
<10>	Offset: 0x13  	Address: 0x7f36ad444063	std::__1::__function::__func<irods::api_call_adaptor<exec_rule_expression_t*>, std::__1::allocator<irods::api_call_adaptor<exec_rule_expression_t*> >, irods::error (irods::plugin_context&, rsComm_t*, exec_rule_expression_t*)>::operator()(irods::plugin_context&, rsComm_t*&&, exec_rule_expression_t*&&)
<11>	Offset: 0xf0d 	Address: 0x7f36ad35ec4d	int irods::api_entry::call_handler<exec_rule_expression_t*>(rsComm_t*, exec_rule_expression_t*)
<12>	Offset: 0x75b 	Address: 0x7f36ad4c473b	rsApiHandler(rsComm_t*, int, BytesBuf*, BytesBuf*)
<13>	Offset: 0x8f2 	Address: 0x7f36ad4c64b2	readAndProcClientMsg(rsComm_t*, int)
<14>	Offset: 0x9c7 	Address: 0x7f36ad4ba8c7	agentMain(rsComm_t*)
<15>	Offset: 0x1b6f	Address: 0x7f36ad4b91bf	runIrodsAgent(sockaddr_un)
<16>	Offset:       	Address: 0x42138d	/usr/sbin/irodsServer(main+0x4cd) [0x42138d]
<17>	Offset:       	Address: 0x7f36a9909830	/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0) [0x7f36a9909830]
<18>	Offset:       	Address: 0x420de9	/usr/sbin/irodsServer(_start+0x29) [0x420de9]

and on the resource server:
danielm@consumer:~$ cat ~irods/log/rodsLog.2018.08.26
Aug 30 17:32:12 pid:2207 DEBUG: parseRuleSet: error parsing rule.
line 0, col 1
{"destination-resource":"rnd1","object-path":"/tempZone/home/rods/testfile","preserve-replicas":false,"rule-engine-instance-name":"irods_rule_engine_plugin-storage_tiering-instance","rule-engine-operation":"migrate_object_to_resource","source-resource":"rnd0","verification-type":"catalog"}
 ^

Aug 30 17:32:12 pid:2207 NOTICE: execMyRule {"destination-resource":"rnd1","object-path":"/tempZone/home/rods/testfile","preserve-replicas":false,"rule-engine-instance-name":"irods_rule_engine_plugin-storage_tiering-instance","rule-engine-operation":"migrate_object_to_resource","source-resource":"rnd0","verification-type":"catalog"} Failed with status -1201000
Aug 30 17:32:12 pid:2207 remote addresses: <IP_ADDRESS> ERROR: rsExecMyRule : -1201000, [-]	/tmp/tmpLnowvJ/plugins/rule_engines/irods_rule_engine_plugin-irods_rule_language/libirods_rule_engine_plugin-irods_rule_language.cpp:391:irods::error exec_rule_text(irods::default_re_ctx &, const std::string &, msParamArray_t *, const std::string &, irods::callback) :  status [RE_PARSER_ERROR]  errno [] -- message [execMyRule failed for rule {"destination-resource":"rnd1","object-path":"/tempZone/home/rods/testfile","preserve-replicas":false,"rule-engine-instance-name":"irods_rule_engine_plugin-storage_tiering-instance","rule-engine-operation":"migrate_object_to_resource","source-resource":"rnd0","verification-type":"catalog"}]

danielm@consumer:~$

As expected, the object is not successfully restaged:
danielm@consumer:~$ ils -L
/tempZone/home/rods:
  rods              0 rnd0;st_ufs1            1 2018-08-30.17:31 & testfile
        generic    /tmp/irods/st_ufs1/home/rods/testfile

What Should Happen
The exception should be trapped more meaningfully, with an accompanying hint printed in the log(s) reminding administrators that the storage tiering plugin needs to be installed and configured everywhere it could possibly execute.

There is currently no way for the delay server to know that the migration failed due to a missing or incorrectly configured plugin on a remote server.


What is the input video feature dimension?

when you use vit to extract the video feature, may I know what is the input video feature dimension?

Video input resolution is 256 x 256.


CachePoolTest::testDeferredExpired() fails

There was 1 failure:

1) CachePoolTest::testDeferredExpired
Cache should not have expired deferred item
Failed asserting that true is false.

/home/runner/work/cache/cache/vendor/cache/integration-tests/src/CachePoolTest.php:421

FAILURES!
Tests: 323, Assertions: 468, Failures: 1.

https://github.com/codeigniter4/cache/actions/runs/8019239564/job/21906727217?pr=33

There was 1 failure:

1) CachePoolTest::testDeferredExpired
Cache should not have expired deferred item
Failed asserting that true is false.

/home/runner/work/cache/cache/vendor/cache/integration-tests/src/CachePoolTest.php:421

FAILURES!
Tests: 323, Assertions: 468, Failures: 1.

https://github.com/codeigniter4/cache/actions/runs/9032646470/job/24821237396

There was 1 failure:

1) CachePoolTest::testDeferredExpired
Cache should not have expired deferred item
Failed asserting that true is false.

/home/runner/work/cache/cache/vendor/cache/integration-tests/src/CachePoolTest.php:421

https://github.com/codeigniter4/cache/actions/runs/9613906703/job/26517607627


Plugin could not be activated because it triggered a fatal error.

How would all your code look as a function for the functions.php file? I tried copy pasting it all in a functions file and it works like a gem with performance, but when editing posts no author is returned, its just blank.
I cant activate the plugin as it returns the titled error, I have tried disabling every other plugin, still not luck. 54k users with role "customer" causing the slow admin issue on my clients site, what can I do :(?

Please reopen issue if needed.


Request: Fire a connect/disconnect Laravel event.

Hi,
I'm trying to use Laravel Websockets to create something similar to the Google Analytics Realtime.
All I need to do is log when someone connects and when they disconnect.
Now, obviously I can use presence channels, but as I understand it these are for authorized users only. I want to find out when any user (authorized or otherwise) connects/disconnects.
I tried hooking into Echo and can send an Ajax request when they connect, this works but obviously the disconnect event doesn't fire when they, say, close the window/tab.
So I looked into doing this on the server side. From what I can see Laravel Websockets doesn't have any Laravel events we can hook into with a listener which would probably work. So I tried adding a rudimentary event call in Websockets\WebSocketHandler\WebSocketHandler.php which works:
onClose method:
public function onClose(ConnectionInterface $connection)
{
    $this->channelManager->removeFromAllChannels($connection);

    DashboardLogger::disconnection($connection);

    StatisticsLogger::disconnection($connection);

    // Fire event for tracking status.
    event(new \App\Events\WebsocketsStatusEvent('disconnected'));
}

establishConnection method:
protected function establishConnection(ConnectionInterface $connection)
{
    $connection->send(json_encode([
        'event' => 'pusher:connection_established',
        'data' => json_encode([
            'socket_id' => $connection->socketId,
            'activity_timeout' => 30,
        ]),
    ]));

    DashboardLogger::connection($connection);

    StatisticsLogger::connection($connection);

    // Fire event for tracking status.
    event(new \App\Events\WebsocketsStatusEvent('connected'));

    return $this;
}

This example is pretty basic but I'm assuming we can send the socket ID and status to event which we could hook into with the EventServiceProvider.
Is this something that could be added or am I just being stupid here?

Bump, i'm actively looking for this

@pislaru @dellow do u guys get error while broadcasting inside onclose event? Do u guys override the websocket handler? My error is broadcasting exception thrown ''(no message)

Why closed issue?


kms client no SetContext() methos

`# github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/kms/v20190118
../../vendor/github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/kms/v20190118/client.go:104:12: request.SetContext undefined (type *ArchiveKeyRequest has no field or method SetContext)
../../vendor/github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/kms/v20190118/client.go:166:12: request.SetContext undefined (type *AsymmetricRsaDecryptRequest has no field or method SetContext)
../../vendor/github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/kms/v20190118/client.go:230:12: request.SetContext undefined (type *AsymmetricSm2DecryptRequest has no field or method SetContext)
../../vendor/github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/kms/v20190118/client.go:290:12: request.SetContext undefined (type *BindCloudResourceRequest has no field or method SetContext)
../../vendor/github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/kms/v20190118/client.go:352:12: request.SetContext undefined (type *CancelKeyArchiveRequest has no field or method SetContext)
../../vendor/github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/kms/v20190118/client.go:410:12: request.SetContext undefined (type *CancelKeyDeletionRequest has no field or method SetContext)
../../vendor/github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/kms/v20190118/client.go:480:12: request.SetContext undefined (type *CreateKeyRequest has no field or method SetContext)
../../vendor/github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/kms/v20190118/client.go:544:12: request.SetContext undefined (type *CreateWhiteBoxKeyRequest has no field or method SetContext)
../../vendor/github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/kms/v20190118/client.go:604:12: request.SetContext undefined (type *DecryptRequest has no field or method SetContext)
../../vendor/github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/kms/v20190118/client.go:666:12: request.SetContext undefined (type *DeleteImportedKeyMaterialRequest has no field or method SetContext)
../../vendor/github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/kms/v20190118/client.go:666:12: too many errors
Compilation finished with exit code 2`

PS
github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/kms v1.0.326

fixed, just go get -v -u ...

sorry, it is caused by our mistake, a pr should be merged before autogen code is pushed, it is already fixed in newer version


Upgrade babashka.curl, babashka.fs, and deps-new

Resolves #66.
It might be better to structure the tests so we can run all the tests in both Babashka and Clojure. Since that will require more effort, I just did one test for now. The current test will at least ensure that the command is always runnable in Clojure.

@rads Instead of testing through the generated script, we might just test through the src/babashka/neil.clj code without shelling out. Also I'm considering moving away from checking in the generated script since in PRs this is confusing. WDTY?

@borkdude:

@rads Instead of testing through the generated script, we might just test through the src/babashka/neil.clj code without shelling out. Also I'm considering moving away from checking in the generated script since in PRs this is confusing. WDTY?

That all sounds reasonable to me. Is it OK if we take care of that in follow-up PRs?

Yes


ST(version0.14.0b1) has problem with anndata, which causes func read_h5ad failed in anndata,scanpy and stereopy itself.

Downgrading st to version 13 is a temporary solution. It is an applicable way that using version 13 and anndata0.9.2, helping read_h5ad works in above 3 packages.

Up to now, we find stereopy version 0.14.0b1 may not support scanpy 1.9.5, but scanpy 1.9.1 works well. Stereopy version 0.13.0b1 has no compatibility issues with scanpy version, at least it support scanpy 1.9.5.


Weird confetti or snow "falling" on welcome/setup screen

GitLens Version: 11

Steps to Reproduce:

Install extension
look at screen

The "stuff" falling from the top of the screen is incredibly distracting and disorienting. The description of the plugin sounded useful but I couldn't make it through setup before I had to uninstall it.

Click the little snow man and it will stop. I will be removing it in the next release as it was a holiday thing.

Click the little snow man and it will stop. I will be removing it in the next release as it was a holiday thing.


Package cannot be installed

I tried to install a clone of this but it failed. I guess some of your packages are too old
><EMAIL_ADDRESS>install /Users/Documents/workspace/lab/carbon-components-angular/node_modules/@angular-devkit/build-angular/node_modules/node-sass
> node scripts/install.js

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.12.0/darwin-x64-83_binding.node
Cannot download "https://github.com/sass/node-sass/releases/download/v4.12.0/darwin-x64-83_binding.node":

HTTP error 404 Not Found

it doesn't exist  https://github.com/sass/node-sass/releases

We don't depend on node-sass 🙂 v4.12.0 definitely exists on the releases page - https://github.com/sass/node-sass/releases/tag/v4.12.0, and locally everything install fine for me ... The binary downloaded is system dependent, so we need some more information:

which version of node are you using? (I recommend 12)
which version of MacOS are you using?

And of course, make sure you're using an up to date version of npm to install dependencies - we don't use yarn for our development.

node-sass 4.12.0 exists indeed, it's just the binary "darwin-x64-83_binding.node"  that is not there for this version of node_sass for the mac i'm using, there are a couple of git tickets around this
i  don't want to investigate too much into this  issue.. i'm converting my existing angular site to carbon and i'm using
angular 10.x , typescript 3.9.7 on node 14.8.. it all works nice.
I just wanted to see if i could do any contribution if needed. So far it all works fine except the toggle typescript warning i'm getting and the onpush i'm missing for the radio..But i'm sure we'll get there

Okay, all else being equal I'm going to close this issue then 👍 Totally happy to reopen and work through this to get it functional for your setup.


Verification results are not published to Pact Broker for maven project

Hi, I updated the pact to version 3.5.5 for our Gradle project,  and the verification results are sent back to pact broker successfully. However,  it seems that this feature is not working on Maven project.
Do I need to do extra configuration on our project to be able to have the function?
Could you please provide more information in your documentation?
Thanks :)

It should be automatic if you are loading the pacts from the pact broker. Can you run the verification with debug level logging enabled?

Yes, I can run the verification in debug mode, and I added the <pact.verifier.publishResults>true</pact.verifier.publishResults> into our configuration block. But the Last Verified value is still not sent to Pact Broker.
Is there a specific value that I should look for in the debug mode if the Last Verified value is returned?

I just helped another person with this problem (but with Gradle), and their issue is they has configured the verifier to load the pact from a URL (to the pact in the broker) instead of configuring it just to query the broker.
Check that you have configured a <pactBrokerUrl>http://pact-broker.....</pactBrokerUrl> or a <pactBroker> element and not a <pactUrl>

Thanks!!! It works. The problem is that we did not put the <pactBrokerUrl> in the right place.
Our <pactBrokerUrl> used to sit outside of the <serviceProviders>. After we move it into the <serviceProviders> to replace the <pactUrl>, the verification results are picked up by Pact broker successfully.
Thanks for your help :)

You're welcome.
But I agree it is confusing. The <pactBrokerUrl> outside is for publishing pacts.

I'm opening this again to track fixing up the confusing configuration tags.

I clicked the wrong button and closed this question by accident.  Anyway thanks! :)
Yes. I realised it just now.

I'm having the same problem. The plugin seems to have no issues finding and verifying pacts but "Last verified" is never updated in the broker. I'm running the mvn pact:verify goal and my pom looks like this:
<build>         <plugins>             <plugin>                 <groupId>au.com.dius</groupId>                 <artifactId>pact-jvm-provider-maven_2.11</artifactId>                 <version>3.3.8</version>                 <configuration>                     <serviceProviders>                         <serviceProvider>                             <name>customerportalapi</name>                             <pactBrokerUrl>http://localhost</pactBrokerUrl>                         </serviceProvider>                     </serviceProviders>                 </configuration>             </plugin>         </plugins> </build>

@LucasAndersson you need to run the latest version of the Maven plugin.


staging->main v4.1.0

Description

Merge to Main for v4.1.0 release:

Added support for chaining related events.
Release script updates for consistency.
Added scripts for updating version.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Do not merge, pending pod lock update


Opt to avoid round precision

https://github.com/jonathanpmartins/v-money3/blob/d307fec9cc39e4da938d9b440a61a9cfa367547d/src/BigNumber.js#L44-L60
I need to show only 2 precision points from a big decimal number, but it must not round when shrinking the precision.
It'd be a good feature to have and option to avoid rounding and just slice the numbers.

Feature released on 3.17.6. Thanks for helping improve the package!

@jonathanpmartins well, ok you added the option into the BigNumber class.
But as a user, we don't actually use class directly.
It's still needed to add the shouldRound option then the format function might use this config.

Sorry, I really tried to speed up your request, but I failed understanding it all!
I did publish a commit with some changes. Can you take a look on it before I release a new version?
What are you trying to accomplish? Is this change made in format function enough?

@jonathanpmartins Sorry, I didn't want to rush you.
I'm building an application to handle data from B3(Brazilian's Stock Exchange), and there are some calculation in which they simply cut the number precision instead of rounding it.
So I was always getting a plus 0.01 when presenting the data.
I was looking for replicate that behavior of simply cutting the precision portion.
Example:
The calculation results to 137.9972
B3 uses: 137.99
But the lib default behavior is rounding the exceeded precision points, resulting in 138.00

Is this good enough, if this feature is available in the format function?
Or do you wish to have it present in the directive/component modules too?

@jonathanpmartins in the format function works for me so far.
But shouldn't it be easy to add to component too?
Like, it's just a new prop, right?

Please, test out 3.18.0 and reopen this issue if necessary.
Thanks


Make conventional commits more "friendly"

...

Fixed by https://github.com/phase2/outline/pull/207


chore: remove FSM

This will be replaced by a workflow engine at a later date
Fixes: #3196

Glorious!


Proper syntax for scope= entries in 'Request an access token' section

I see here in the example, and I've seen the same on other pages, the scopes are including "https://graph.microsoft.com", and with the HTTP safe characters (%3A%2F%2F).  However, over on this device code page, the scopes are simply entered as, for example, Mail.Read.  In my testing, Mail.Read (no "https://....") works fine, but I have only tested with device code, not anything else (well client credentials, but in that case the scope is always just the /.default and permissions are manually added in the tenant in advance).
I'm wondering - is it that both options work (i.e. just 'Mail.Read', and/or 'https://graph.microsoft.com/Mail.Read'), or are the examples on this page and other pages where the https://*** is included incorrect?
Thanks in advance.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fef99ca3-72bb-2c48-a62b-9ff9c314d72b
Version Independent ID: e58fd3a1-0af8-6e16-3d78-3dc748992593
Content: Microsoft identity platform and OAuth 2.0 authorization code flow - Microsoft identity platform
Content Source: articles/active-directory/develop/v2-oauth2-auth-code-flow.md
Service: active-directory
Sub-service: develop
GitHub Login: @hpsin
Microsoft Alias: hirsin

@JeremyTBradshaw Thank you for your feedback! We will review and update as appropriate.

@JeremyTBradshaw  For Graph API, scopes can be passed as either 'Mail.Read' or 'https://graph.microsoft.com/Mail.Read'. Both are valid. However, for other APIs, such as your custom API, you need to specify complete URI as scope e.g., https://example.com/api/read.

Thank you @amanmcse .  Makes sense to me now as well.  I hadn't thought about the use case where the resource being accessed is not one of Microsoft's.


add txn.GetOutEdgeIterator(src, dst, lid) and txn.GetInEdgeIterator(src, dst, lid)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[WIP] Target .NET 5.0 and C# 9

Resolves
Fixes #365
Description
Target .NET 5.0 and C# 9

@Brett-Parker this is ready to review

You'll need the .NET 5 SDK and the latest Visual Studio version to run it locally.

I'm investigating the failing integration test

The failing test DeployModel_GivenACompleteRun_ShouldDeployModelToContainer passes locally. It fail on the Linux agent due to the path to image/ML.NET.Embedded.csproj during the dotnet add command.

I'm very surprised, but it looks like the failing test that has been hindering this PR is due to the fact that running dotnet new returns before it is actually finished when running it through the CLI Wrapper package. This causes the following step to fail. I discovered this by adding some Thread.Sleeps but that's not a long term solution so I'm going to think about what to do next.

@Brett-Parker this is ready for review. I had to introduce a Thread.Sleep in one place which I hate, but not sure how to get around that dotnet new --install seems to return prior to the template package being installed.

I figured out a more robust version where we loop and check if the template is installed before proceeding :)

Thanks @Brett-Parker, good catch! 👍
I'm planning to prep a release tonight or tomorrow including this change and also Gregor's SQLite path change.


Fix for svg checkmark on es answer pages

Fix for svg checkmark on es answer pages
Changes

Modified code to fix issue with svg on es-ask pages. I had to minimize some of the imports because they were affecting the layout on some es pages. I included the color vars from cf but not cf-notification, because cf-notification includes cf-core.

Testing

Visit http://localhost:8000/es/obtener-respuestas/como-puedo-encontrar-a-un-abogado-que-me-represente-ante-la-demanda-de-un-acreedor-o-cobrador-es-1433/ and compare to production.

Screenshots
Notes

I'm not sure in which scenario the notification is visible.

Todos

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the development playbook
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Browsers

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Internet Explorer 8, 9, 10, and 11
[ ] Edge
[ ] iOS Safari
[ ] Chrome for Android

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Flexible from small to large screens
[ ] No linting errors or warnings
[ ] JavaScript tests are passing

I am also unsure how the icon gets shown. I think it's when you answer whether or not the page was helpful (the "Sí" and "No" radio buttons), but when I click one of those locally, nothing happens. Let's get @virginiacc's expertise when she gets in.

.  I am also unsure how the icon gets shown. I think it's when you answer whether or not the page was helpful (the "Sí" and "No" radio buttons), but when I click one of those locally, nothing happens. Let's get @virginiacc's expertise when she gets in.

yeah, it looks like this was broken at some point.  Fix is coming for that.

@Scotchester , please give it another look. It turns out the notification was within the feedback form, so it wouldn't display when then form was being hidden.


Bitmap font text can't align vertical center in the button

**Godot version:3.0.6

OS/device including version:

Issue description:

It seems like the bottom of the text is at the vertical center of the button, it's impossible to place the center of the text at the center of the button. When use DynamicFont, the center of the text is at the vertical center.
Please check the image and the font file for detail.
Steps to reproduce:
Add a button
Set Align to Center. (I know this determine the horizontal align, but the vertical can't align center for bitmap font text)
font.zip
Minimal reproduction project:

Also, bitmap font for Label can't work well, the Auto wrap can not place correct margin between lines.

Can't reproduce either on master (970b58148f579f741934f64af437d01b985df15d) or 3.0.6 (8314054) with the provided .fnt sample.
Screenshot (same from both versions, the button and both labels have the same height):

(Note: Please try to give full sample projects for reproduction, not just one or two files)

I found what the problem was.
The *.fnt file is not included in the All Recognized file type when load file for the font property.
I made a new BitmapFont and set the fnt file as the Fallback but forgot to set the Height.
I think the *.fnt file type should include in the All Recognized file type.

Looks like this has been fixed. I am closing now. If there is a different issue we can reopen, or open a new issue.


Loader has length 0 when batch_size > len(indices)

Initializing the loader as follows:
from ffcv.loader import Loader

loader = Loader(train_dataset,
                batch_size=batch_size,
                num_workers=num_workers,
                indices=indices)

results in a loader of length 0 when batch_size > len(indices).
I think a warning, an error, or returning a length 1 loader containing exactly len(indices) elements in the loader would all be reasonable behaviors that are more intuitive than returning a length 0 loader.

@kaixiao it seems that in your example you have drop_last=True. We aim to maximize compatibility with the pytorch dataloader and it seems that we have exactly the same behavior
In [3]: ch.utils.data.TensorDataset(ch.Tensor([(0, 1), (1, 2)]))
Out[3]: <torch.utils.data.dataset.TensorDataset at 0x7f824f9a47c0>

In [4]: dataset = ch.utils.data.TensorDataset(ch.Tensor([(0, 1), (1, 2)]))

In [5]: loader = ch.utils.data.DataLoader(dataset, batch_size=3, drop_last=True)

In [6]: len(loader)
Out[6]: 0

Feel free to reopen if you see a discrepancy with pytorch's DataLoader!

Thanks for the clarification, @GuillaumeLeclerc! In that case, I'm wondering if the default behavior for ffcv loaders should be drop_last=False instead, since that seems to be the pytorch default. But it's helpful to know that this is an easy fix.
Default drop_last behavior in Pytorch:
`In [2]: dataset = ch.utils.data.TensorDataset(ch.Tensor([(0, 1), (1, 2)]))
In [3]: loader = ch.utils.data.DataLoader(dataset, batch_size=3)
In [4]: len(loader)
Out[4]: 1`

That's definitely an oversight from us. I'm not sure changing now as people might be already relying on the default value is the thing to do though.


using codeblocks in if condition?

Hi,
ist there any wayto get nested logical blocks (such as an AND or OR) within the if block, as it is possible in scratch?
sorry for my bad english...here's what i mean:
a block:

    A OR B

    A OR B

and i would like to be able to drag this logic block into the IF block's condition.
if A or B {}
many thanks for any reply and help!!!

Hi infantilo,
Thank you for try to use mameblock.
mameblock is not support building expressions or conditions like Scrath yet.
My temporary solution is using IF-AND block like this:

	if((i % 3 === 0) AND (i % 5 === 0)) {

	if((i % 3 === 0) && (i % 5 === 0)) {

				/** comment */

				/** comment */

		}

		}

If some one send patch for express builder use mameblock, I will merge it.
regards


Reduce plugins install output

The output in the terminal when installing a plugin from pub is unbearable. We should not show the verbose output of pub global activate to the users

Fixed in sidekick_core:0.12.0


WIP: Add suffix to Kind names to avoid name conflict on simple words

fixed #41
NOTE: Awaiting https://github.com/almighty/almighty-core/pull/45 to avoid format changes to clutter the diff

This change is

When working with auto-completion it is much nicer to have KindUser rather than UserKind.  When you don't remember the type of numbers available you can just type Kind and see what is there.

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Good point

Comments from Reviewable


Differentiate Font Sizes and Colors for Date and Description on Blog Page

Currently, the font sizes and colors for the date and description on the blog page are the same, which may impact the visual hierarchy and readability of the content. To improve the user experience, the font sizes and colors should be adjusted to create a clearer distinction between the date and the description text. Referring to this page: http://blackpythondevs.com/blog/
Suggested Changes:
Date Font:

Reduce the font size slightly for the date, making it smaller than the description text.

Description Font:

Maintain the current font size or make it slightly larger to ensure it stands out as the primary information.

@Ngazetungue - thank you for taking this on! I think that is great

The PR is ready for review, find it here: https://github.com/BlackPythonDevs/blackpythondevs.github.io/pull/593


id: illegal option -- -

Keep receiving the following after every command only when Pure is installed:
id: illegal option -- - usage: id [user]        id -A        id -F [user]        id -G [-n] [user]        id -M        id -P [user]        id -g [-nr] [user]        id -p [user]        id -u [-nr] [user] ~

Env
Pure
3.4.1

Fish
fish, version 3.1.2

OS/distribution
MacOS Big Sur 11.1

Thank for the feedback @nicktfried.
This is due to macOS id command missing the long format option. Until I fix this, you can revert to 3.3.5:
fisher install<EMAIL_ADDRESS>

fisher install does not exist in my version of fisher (3.2.11), but fisher add<EMAIL_ADDRESS>worked.

fisher install does not exist in my version of fisher (3.2.11), but fisher add<EMAIL_ADDRESS>worked.

Update fisher to 4.1

Thanks!

@nicktfried you can install
fisher install<EMAIL_ADDRESS>


Domains are subjects

What it does
This commit changes the Domain class such that it extends from the Subject prototype. A subject is kind of like a stream of values over time. They are a special kind of observable that makes it easier to send updates to multiple subscribers.
Subjects have their own state, which allows a couple of nice things:

Domains can serialize their own state. Microcosm doesn't need to dispatch anything. The toJSON method can just return this.domains. JSON.stringify should take care of everything else by calling the subsequent toJSON methods on domains.
Domains can be tested on their own.  You can instantiate a domain as a stand-alone instance, calling dispatch directly on the domain itself. This isn't quite true yet, as Domains require a microcosm history object, but one idea is to give each domain their own unique history.
Presenter data subscriptions become more powerful. Presenters in Microcosm 13 can subscribe to observables (so also subjects). This means we can replace our data-binding callbacks with references to the domains themselves, which is both cleaner and significantly faster.

This means the repo.answers namespace can be removed. You can now get updates to a domain simply by accessing the domain itself. This required some Presenter tests to be updated:
// Before
class UsersList extends Presenter {
  getModel() {
    return {
      users: state => state.users
    }
  }
}

// After
class UsersList extends Presenter {
  getModel(repo) {
    return {
      users: repo.domains.users
    }
  }
}

Before this change, there was an additional answers namespace on repo. You'd have to subscribe to a domain update via repo.answers["domain-key"]. This commit consolidates that namespace while also simplify some serialization techniques because domains now fully track their own state.
Long term, I'd like to add some new methods to observables, like map. That would let you do stuff like:
function prepareUsersList(users) {
  // return a list of users based on what the presenter needs
}

class UsersList extends Presenter {
  getModel(repo) {
    return {
      users: repo.domains.users.map(prepareUsersList)
    }
  }
}

It also means that you can build more complicated view models by composing domains into an object:
class UsersList extends Presenter {
  getModel(repo) {
    return {
      users: {
        total: repo.domains.users.map(users => users.length)
        data: repo.domains.users.map(users => users.slice(0, 10)) // only show the first ten users
    }
  }
}

This is sort of the next step for getModel. Long term, I can see how this could start to term into a more sophisticated query language. One that could probably also handle data fetching.

Codecov Report

Merging #484 into master will decrease coverage by 0.33%.
The diff coverage is 81.81%.

@@            Coverage Diff            @@
##           master    #484      +/-   ##
=========================================
- Coverage   98.54%   98.2%   -0.34%
=========================================
  Files          29      28       -1
  Lines         686     669      -17
  Branches      134     128       -6
=========================================
- Hits          676     657      -19
- Misses          8      10       +2
  Partials        2       2

Impacted Files
Coverage Δ

packages/microcosm/src/ledger.js
88.88% <0%> (-11.12%)
:arrow_down:

packages/microcosm/src/microcosm.js
100% <100%> (ø)
:arrow_up:

packages/microcosm/src/domain.js
97.95% <100%> (+0.04%)
:arrow_up:

packages/microcosm-dom/src/utilities.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba83ce...20d17a8. Read the comment docs.


Add faq anchor #eu_dcc_export_error to Cypress test for release 2.24

This PR adds a new link
#eu_dcc_export_error
to be tested by cypress/integration/app_to_web.js

The link was added to CWA Android release/2.24.x through PR https://github.com/corona-warn-app/cwa-app-android/pull/5271 and is included in v2.24.0-rc.1.

Verification
The pre-requisite for a successful test is the creation of the FAQ articles to be finally published under:

https://www.coronawarn.app/en/faq/#eu_dcc_export_error
https://www.coronawarn.app/de/faq/#eu_dcc_export_error

Verify pre-release
On branch cwa-website/tree/release/2.24
npm run test:open
select test app_to_web.js
Verify post release
npx cypress run -s 'cypress/integration/app_to_web.js' -c baseUrl=https://coronawarn.app

This PR should not be merged until the FAQ articles #eu_dcc_export_error are available.

I successfully tested this PR against the branch 2.24/eu_dcc_export_error.

Thanks for your PR @MikeMcC399!


Rename import to solve conflicting usage of Error constructor

In the sentry-simple-test example, next's error component is imported like this:
import Error from 'next/error'
In another, unrelated line a generic javascript Error is supposed to be thrown.
I've renamed the error component import to avoid a conflict in case the Error constructor branch is hit.

Builds seem to be failing because of GitHubs current incident.
Pipeline configuration error: Could not get the latest source version for repository zeit/next.js hosted on https://github.com/ using ref b59682f273b53aae8a0a033028e4ab16bd71588e. GitHub reported the error, "Internal Server Error"
https://www.githubstatus.com/incidents/6tcfpztf6j9m

Actually, the error component is still not fully functioning. I've noticed in a serverless environment that the captureException does not pass the error event to Sentry. I assume this is because the serverless function is destroyed as soon as the error occurs, and so the sentry client does not have enough time to send over the event.
To fix this, an Sentry.flush must be awaited upon after capturing the exception to ensure the event makes it to Sentry.


Typescript pulling all MUI files - super slow compilation

[X] This is a v1.x issue (v0.x is no longer maintained).
[X] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
TSC should compile in about 3-8 seconds.
Current Behavior
TSC takes over 1 minute to compile, because it's pulling the entire library, with over half a million types.
running tsc --extendedDiagnostics --listFiles --noEmit

and it goes on...

If I remove the MUI folder (resulting in lots of errors of course)

Context
I'm only using 10 components in the entire app, all imported like this:
import CircularProgress from '@material-ui/core/CircularProgress/CircularProgress';
It should only import the relevant files and types.
My tsconfig:
{
  "compilerOptions": {
    "baseUrl": "./src",
    "outDir": "build/dist",
    "target": "es5",
    "lib": ["es6", "es7", "dom"],
    "sourceMap": true,
    "allowJs": false,
    "jsx": "react",
    "esModuleInterop": true,
    "skipLibCheck": true,
    "moduleResolution": "node",
    "allowSyntheticDefaultImports": true,
    "rootDir": "./src",
    "noEmitOnError": false,
    "isolatedModules": true,
    "strictPropertyInitialization": false,
    "forceConsistentCasingInFileNames": true,
    "noFallthroughCasesInSwitch": true,
    "noErrorTruncation": true,
    "noImplicitReturns": true,
    "noImplicitAny": true,
    "noImplicitThis": true,
    "strictNullChecks": true,
    "diagnostics": true,
    "suppressImplicitAnyIndexErrors": true,
    "noUnusedLocals": true
  },
  "include": [
    "src/**/*"
  ],
  "exclude": [
    "dist",
    "build",
    "node_modules",
    "src/**/__tests__"
  ],
  "defaultSeverity": "warning"
}

My @types folder:

Any ideas why this happens?
Thank you for your help!!!
Your Environment

Tech
Version

Material-UI
v1.2.2

React
latest

browser

etc

This is an issue with Typescript, not with MUI. There is nothing MUI can do about this

May I ask you to expand a bit on that thought? Have you come across
something similar before?
On Tue, 19 Jun 2018, 12:02 Rasmus Eneman<EMAIL_ADDRESS>wrote:

This is an issue with Typescript, not with MUI. There is nothing MUI can
do about this
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/issues/11916#issuecomment-398345551,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHdk5-rU0KaHFNzTxM4-V9Oe4ZHcoT8oks5t-Mw3gaJpZM4UtG9x
.

MUI only provides types for its components, it can not control how the TS compiler chooses to load and parse any files. It is a big library which is why you might see bigger impact from MUI than other libraries but it is big because it provides a lot of things, not because of an error.
More clever loading of files, improved handling of many files etc. is up to the compiler.

If this was the case for other people, then this repo would be swamped with people complaining about astronomical build times. It seems this is a fringe case. Maybe someone has come across this before... or can spot something with my config that I'm missing.

I'm getting assistance on this issue:
https://github.com/Microsoft/TypeScript/issues/25085

This is an issue with Typescript, not with MUI. There is nothing MUI can do about this

Actually while we definitely do (did? we should be publishing a fix on nightlies tonight) have a perf problem, there's an issue in MUI that is causing us to do more work than we should for a given deep import, too! Specifically, you have imports like this one:
import { StandardProps } from '..';

That import references the root index.d.ts - your root index.d.ts imports all components (to reexport them), causing us to load every type definition in MUI. If you moved your utilitity types like StandardProps into a separate file from the root index.d.ts and did a direct import of them, it would cut down on the fileset loaded for a given component fairly significantly.

@weswigham
First of all, just so it's clear. I'm not involved in MUI, I'm just a pretty active user of it.
Secondly, awesome track down and fix in TS! I did not mean anything negative against you or anyone on the TS team.
What I did mean was that even if the imports were more cautious that would only delay the problem until you use more of MUI. However that's still a good optimization for people not using the majority of the MUI components.
I was under the impression though that you still had to parse all distributed .d.ts file to find out if there are declare global declarations in them. But that might very well be completely false.

closing the issue, as it has been addressed. More details are in the ticket linked above.

@rpmonteiro What did you do to fix this issue?

@manpreetnarang instead of
  AppBar,
  Button,
  Hidden,
  IconButton,
  Toolbar,
} from '@material-ui/core';
import { Menu } from '@material-ui/icons';```

Do this:

```import AppBar from '@material-ui/core/AppBar';
import Button from '@material-ui/core/Button';
import Hidden from '@material-ui/core/Hidden';
import IconButton from '@material-ui/core/IconButton';
import Toolbar from '@material-ui/core/Toolbar';

import Menu from '@material-ui/icons/Menu';```

For anyone still having this issue with VS Code, I had to disable typescript.tsserver.experimental.enableProjectDiagnostics. Turns out that setting just pulls all of node_modules typescript files constantly including MUI's which slowed my machine to a crawl.


Using merdian in the format option causes the calendar to initialise as December 1899

If you use the merdian (p) in the date format, after selecting a date and time and then closing the selector, if you then select the input again the calendar initialises as December 1899. I expected it to open on the date currently in the input.
Am I doing something incorrectly?
I've created this JS Fiddle to replicate the problem.
http://jsfiddle.net/akkrnnu2/6/

To be more specific it breaks if the 'p' is hard against the minutes.
format: 'yyyy-mm-dd H:ii p', // OK
format: 'yyyy-mm-dd H:iip', //  Not OK

Okay @gregbryantnz I can tell you that the problem lies in the parsing of the date. To be more precise this line is the problem.
var parts = date && date.toString().match(this.nonpunctuation) || [],
Set a breakpoint there and see that the merdian is not separeted in the parts array. Unfortunately I don't have time to fix this. Maybe you want to give it a go ;)

@gregbryantnz  try setting your format to: dd MM yyyy - HH:ii P

and you can not use any chinese character, like 年月日


Typo

On the "Use service workers to cache the forecast data (step 7)" page, you'll find this line statement "Opening the data cache should should the data stored for each city." I feel this is a typographic error because should is repeated twice; I believe the second 'should' is meant to be 'show' or some other synonym.

Hi!
Thanks for the feedback. I've rewritten the codelab from scratch and believe I have fixed this issue. The code has been updated, and the new guide is now live.
If you find any issues with the new codelab, please let us know!
Thanks!


Remove @inline annotations and enable Scala 2 inliner

This PR is a conservative continuation of https://github.com/apache/incubator-pekko/pull/305, specifically

All of the @inline annotations have been removed. As stated by @jrudolph , these annotations were added a long time ago when Akka was targeting older versions of Scala 2 backend which didn't produce optimal bytecode. Currently the @inline annotations are creating confusion as its giving the implication that this code should be inlined due to an impediment in the Scala 2 inliner/compiler (and to make things worse the Scala 2 inliner isn't even enabled).

Currently the @inline annotation doesn't do anything in the Pekko codebase because the Scala 2 inliner isn't enabled anyways (this PR enables that)
The Scala 2 inliner has gotten to a point where its heuristics should be inlining anything that needs to be inlined automatically without the @inline annotation. If this is not the case then it should be tackled explicitly
There is an exception for the various converter util methods in org.apache.pekko.util.*, this is explained in the next point

For the org.apache.pekko.util.* converter functions i.e. OptionConverters/FutureConverters/FunctionConverters/PartialFunction the @inline annotation has been kept in place and for Scala 3 specifically the inline keyword is used (which achieves the same effect).

This is because there is no reason NOT to inline these functions as they are just delegation wrappers
All this code will be dropped when Scala 2.12 support is removed anyways

The general idea is that once this is merged into Pekko 1.1.x series we can start enabling the inliner in the other Pekko modules. Of particular import, aside from the standard inline settings would be addingSeq(
  "-opt-inline-from:org.apache.pekko.util.OptionConverters**",
  "-opt-inline-from:org.apache.pekko.util.FutureConverters**",
  "-opt-inline-from:org.apache.pekko.util.FunctionConverters**",
  "-opt-inline-from:org.apache.pekko.util.PartialFunction**"
)

To the other Pekko modules in the 1.1.x series for Scala 2 inliner settings (with Scala 3 this is not necessary). What this
will essentially do is that for Scala 2.12 any calls to the converters (i.e. lets say org.apache.pekko.util.OptionConverters.toScala) will directly call the method from scala-collection-compat and for Scala 2.13+ it will directly call the Scala stdlib version. This means that aside from a possible performance improvement, when Scala 2.12 support is dropped there won't be any difference in bytecode because @inline final def toScala[A](o: Optional[A]): Option[A] = scala.jdk.javaapi.OptionConverters.toScala(o)/inline final def toScala[A](o: Optional[A]): Option[A] = scala.jdk.javaapi.OptionConverters.toScala(o) will be inlined away.

It may be that for the Pekko module 1.1.x series they will have to build against Pekko core 1.1.x because while the
@inline annotations existed in Pekko 1.0.x, the inline keyword for Scala 3 in various places was only added in Scala 3. This however shouldn't cause any issues because a Pekko module built against Pekko core 1.1.x would inline all relevant code, so even if a Pekko core 1.0.x is linked at runtime in a Pekko 1.1.x module, all it means is that the Pekko 1.0.x will bring in some unused code.
This is considered safe because all of this converter code won't be changed and is considered entirely stable and when Scala 2.12 is dropped its just going to be calling the exact same method from stdlib anyways.

@noinline had to be added in a few places because it caused a test regression, specifically there are tests which call testNameFromCallStack which (as the name implies) inspects the call stack and the Scala 2 inlining will obviously effect the call stack if it inlines something (there is no Scala 3 inlining here because Scala 3 will only inline if you use the inline keyword). Generally speaking its a bit fishy to rely on the call stack for anything but this is testkit related so it gets a free pass. There is a low risk chance that similar issues may be revealed in downstream pekko modules but if it comes up its quite easy to fix this (i.e. need to sprinkle @noinline in a few more places).
There is an argument that the default of inlining (i.e. pekko.no.inline) should be off rather than on because it can mess with local incremental compilation (although in practice this rarely happens). The reason why I opted for it to be on by default (aside from other Scala projects having inlining on by default) is that since we are doing manual releasing, it would be very easy to forget the inliner flag when making a build. When we get to the point of being able to build release artifacts in CI then I think is a good time to revisit this (i.e. the github action to make a release build would have the inliner flag enabled and locally it will be disabled by default).

lgtm

Thanks, ill wait till the end of the month to get some more reviews.

I remain skeptical about this. The perf gains are unproven and mainly seem to target the Java user conversions (when most users use Scala).
So my vote is -0. If we end up getting build failures in other Pakko modules, I will be arguing for this to be reverted or partially reverted as needed.

I remain skeptical about this. The perf gains are unproven and mainly seem to target the Java user conversions (when most users use Scala).

There definitely are performance improvements as it has inlined code that wasn't inlined before, its just a question of whether the code is in a hotspot or not (I am talking about the inliner in general here, not the org.apache.pekko.util.* specifically. The scala 2 inliner will automatically inline any code that it sees as slow as long as its considered safe)
Also afaik, historically most Akka/Pekko users have been Java and not Scala

So my vote is -0. If we end up getting build failures in other Pakko modules, I will be arguing for this to be reverted or partially reverted as needed.

Sure, Im happy with that.

Ok. I'm ok with this being merged as long as we revert anything that causes build issues - if those happen - in other Pekko repos.

I will merge this so we can get to testing it out in the wild to see if there are any regressions


x/sys/windows: AdjustTokenPrivileges does not return error when ERROR_NOT_ALL_ASSIGNED occurs

What version of Go are you using (go version)?

$ go version
go version go1.21.4 windows/amd64

Does this issue reproduce with the latest release?
Yes, it reproduces with the latest release as of 15 Nov 2023.
What operating system and processor architecture are you using (go env)?
Windows 11 Pro Version 22H2 (OS Build 22621.2715)
go env Output
$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\--OMITED--\AppData\Local\go-build
set GOENV=C:\Users\--OMITED--\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=--OMITED--
set GONOPROXY=--OMITED--
set GONOSUMDB=--OMITED--
set GOOS=windows
set GOPATH=D:\packages\go
set GOPRIVATE=--OMITED--
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLCHAIN=auto
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.21.4
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=0
set GOMOD=NUL
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=

What did you do?

Here is link to Go Playground (but note that this will not run on the Go Playground because it requires Windows environment). I also provided a full listing below.
https://go.dev/play/p/G2J2te4l-4q
The program is attempting to call AdjustTokenPrivileges to enable the SeSecurityPrivilege. When I run the program elevated (as Administrator), the program runs as expected without an issue. The issue occurs when running as a normal user (non elevated privilege) where it also completes without any error, where it was supposed to panic at line 32.
package main

import (
	"golang.org/x/sys/windows"
	"unsafe"
)

func main() {
	var token windows.Token
	err := windows.OpenProcessToken(windows.CurrentProcess(), windows.TOKEN_ADJUST_PRIVILEGES|windows.TOKEN_QUERY, &token)
	if err != nil {
		panic(err)
	}

	var luid windows.LUID

	privilegeName := "SeSecurityPrivilege"
	err = windows.LookupPrivilegeValue(nil, windows.StringToUTF16Ptr(privilegeName), &luid)
	if err != nil {
		panic(err)
	}

	newStateBuffer := make([]byte, 4+unsafe.Sizeof(windows.LUIDAndAttributes{}))
	newState := (*windows.Tokenprivileges)(unsafe.Pointer(&newStateBuffer[0]))
	newState.PrivilegeCount = 1
	newState.Privileges[0].Luid = luid
	newState.Privileges[0].Attributes = windows.SE_PRIVILEGE_ENABLED

	err = windows.AdjustTokenPrivileges(token, false, newState, uint32(len(newStateBuffer)), nil, nil)
	// When elevated this should succeed, but when not elevated ERROR_NOT_ALL_ASSIGNED should be returned, but it succeeds instead.
	if err != nil {
		panic(err)
	}
}

What did you expect to see?
When I run the program as a normal user (not administrator), I expect the windows.AdjustTokenPrivileges call at line 29 to fail with and return error ERROR_NOT_ALL_ASSIGNED error, since the privilege that was requested to be enable was not enabled.
What did you see instead?
windows.AdjustTokenPrivileges returns null instead of returning an error.

CC @golang/windows

When I run the program as a normal user (not administrator), I expect the windows.AdjustTokenPrivileges call at line 29 to fail with and return error ERROR_NOT_ALL_ASSIGNED error, since the privilege that was requested to be enable was not enabled.

I am not an expert in Windows security, but
https://learn.microsoft.com/en-us/windows/win32/api/securitybaseapi/nf-securitybaseapi-adjusttokenprivileges
only mentions ERROR_NOT_ALL_ASSIGNED when SE_PRIVILEGE_REMOVED parameter is used. So perhaps your reasoning is wrong.
I suggest you ask your question somewhere else where you can find at least some Windows security experts. I doubt many experts read your question here.
You can try https://github.com/golang/go/wiki/Questions or https://stackoverflow.com
Alex

@alexbrainman
Thanks for taking the time to check and explain the issue.

only mentions ERROR_NOT_ALL_ASSIGNED when SE_PRIVILEGE_REMOVED parameter is used. So perhaps your reasoning is wrong.

Believe me, it does occur when SE_PRIVILEGE_ENABLED parameter is used, I tested this many times and I am sure. May be the wording of Microsoft's documentation is confusing, but in the same documentation you linked it says under "return value" section that ERROR_NOT_ALL_ASSIGNED occurs when (and I quote):

The token does not have one or more of the privileges specified in the NewState parameter. The function may succeed with this error value even if no privileges were adjusted. The PreviousState parameter indicates the privileges that were adjusted.

As you see the Windows function call can indicate success, even when ERROR_NOT_ALL_ASSIGNED occurs (That's because it could have succeeded with other privileges, but in my case I am enabling just one and it failed, so it did nothing). The Golang's implementation doesn't check for this scenario and just returns no error at all when this condition happens. It completely ignores the error value if the Windows function returns TRUE.
As for a solution to my problem, I didn't feel the need to ask around as I already knew exactly what was happening. I already worked around the problem by calling the Windows API directly using NewLazySystemDLL and NewProc functions and instead of using the AdjustTokenPrivileges  function in Go's ``golang.org/x/sys/windowspackage. So basically I created my own version ofAdjustTokenPrivileges` function.
I wanted it fixed so that others don't face the same issue. I thought of actually fixing the code myself and submitting a pull request, but I was discouraged by having to create a Gerrit account then going through several steps, and I also didn't have enough time to setup an environment on my local machine where I can build the source and run tests as it required installing some stuff and changing some git settings that may affect my other work, so I needed to setup a VM specifically for that. In short it was a long process for just updating 2-3 lines of code for something that could be rejected as it is a breaking change and I didn't have time. I also realize that this is a niche scenario, and not a lot of developers are affected by it.

I wanted it fixed so that others don't face the same issue. I thought of actually fixing the code myself and submitting a pull request, but I was discouraged by having to create a Gerrit account then going through several steps, and I also didn't have enough time ...

It is also fine just to point to the problem in the code, and perhaps others will be willing to implement the fix.
Alex

It is also fine just to point to the problem in the code, and perhaps others will be willing to implement the fix.

You are right.
Here is a link to the code code:
https://cs.opensource.google/go/x/sys/+/master:windows/zsyscall_windows.go;drc=11eadc05e9bfbaaf23ac6ebc28595a9a12f607f4;l=553
original code: for some reason this is different from the code on this repo.

func AdjustTokenPrivileges(token Token, disableAllPrivileges bool, newstate *Tokenprivileges, buflen uint32, prevstate *Tokenprivileges, returnlen *uint32) (err error) {
	var _p0 uint32
	if disableAllPrivileges {
		_p0 = 1
	}
	r1, _, e1 := syscall.Syscall6(procAdjustTokenPrivileges.Addr(), 6, uintptr(token), uintptr(_p0), uintptr(unsafe.Pointer(newstate)), uintptr(buflen), uintptr(unsafe.Pointer(prevstate)), uintptr(unsafe.Pointer(returnlen)))
	if r1 == 0 {
		err = errnoErr(e1)
	}
	return
}

suggested fix: This is what I would do to fix:
func AdjustTokenPrivileges(token Token, disableAllPrivileges bool, newstate *Tokenprivileges, buflen uint32, prevstate *Tokenprivileges, returnlen *uint32) (err error) {
	var _p0 uint32
	if disableAllPrivileges {
		_p0 = 1
	}
	r1, _, e1 := syscall.Syscall6(procAdjustTokenPrivileges.Addr(), 6, uintptr(token), uintptr(_p0), uintptr(unsafe.Pointer(newstate)), uintptr(buflen), uintptr(unsafe.Pointer(prevstate)), uintptr(unsafe.Pointer(returnlen)))
	if r1 == 0 || e1 == ERROR_NOT_ALL_ASSIGNED { // <-- additional check here.
		err = errnoErr(e1)
	}
	return
}
```

I've submitted CL 566036 which contains the fix proposed by @sherif-elmetainy. The problem I now see is that this is a breaking change.
For example, the following code from https://github.com/Azure/azure-storage-azcopy would no longer report a useful error, at it is a shame because it is trying to sidestep our AdjustTokenPrivileges issue.
err = windows.AdjustTokenPrivileges(procToken, false, &tokenPrivs, oldPrivsSize, &oldPrivs, &requiredReturnLen)
if err != nil {
     return err
}
if oldPrivs.PrivilegeCount != 1 {
     // Only the successful changes are returned in the old state
     // If there were none, that means it didn't work
     return errors.New("could not activate '" + BackupModeFlagName + "' mode.  Probably the account running AzCopy does not have " +
          privName + " so AzCopy could not activate that privilege. Administrators usually have that privilege, but only when they are in an elevated command prompt. " +
          "Members of the 'Backup Operators' security group also have that privilege. To check which privileges an account has, run this from a command line: whoami /priv")
}

There are many other AdjustTokenPrivileges uses uses that are wrong, see this query. Most of them are just expecting windows.AdjustTokenPrivileges to return an error when ERROR_NOT_ALL_ASSIGNED happens. A few try to call GetLastError right after, not realizing that that function is also broken (see #41220). From https://github.com/harryeetsource:
err = windows.AdjustTokenPrivileges(token, false, &tokenPrivs, 1024, nil, nil)
if err != nil || windows.GetLastError() != nil {
	return false
}

@bcmills suggested a few solutions to this issue in https://go-review.googlesource.com/c/sys/+/566036/comment/3e705da4_cddd965a/:

Return ERROR_NOT_ALL_ASSIGNED even on success, and document that the Go AdjustTokenPrivileges function may return it.

Add an AdjustTokenPrivileges variant that returns (bool, error) instead of just error, bundling together the results of AdjustTokenPrivileges and GetLastError.

Make no change to the return value, but add an example illustrating how to use the PreviousState parameter to determine whether all requested privileges were assigned.

Fix #41220 by making GetLastError actually work in limited cases (per https://go.dev/issue/41220#issuecomment-1959940374), and add an example for AdjustTokenPrivileges illustrating how to lock and unlock the OS thread in order to check for ERROR_NOT_ALL_ASSIGNED.

Of those, (1) is technically an incompatible change (but may be ok as a bug-fix), (2) is a new API, (3) may be tricky to use, and (4) seems a bit fragile.

I would lean towards having a new API (option 2 in previous comment):
// AdjustTokenPrivileges2 enables or disables privileges in the specified token
// by calling AdjustTokenPrivileges.
// Note that err can be [ERROR_NOT_ALL_ASSIGNED] even if success is true,
// which means that one or more privileges were not adjusted.
func AdjustTokenPrivileges2(...) (success bool, err error)

I would also deprecate windows.AdjustTokenPrivileges. It would make no sense to use it once AdjustTokenPrivileges2 exists.

Perhaps I don't understand the problem, but this is how AdjustTokenPrivileges is designed by Microsoft.

The function designed by Microsoft returns a bool in addition to the to the error value returned from GetLastError. So Option 2 with signature func AdjustTokenPrivileges2(...) (success bool, err error) suggested by @qmuntal would match the Microsoft behavior in case the success is true and ERROR_NOT_ALL_ASSIGNED is still returned. The signature of the current API and that suggested as Option 1 has only 1 return value (the error) and no bool return value, so can't possibly match Microsoft's design.

The signature of the current API and that suggested as Option 1 has only 1 return value (the error) and no bool return value, so can't possibly match Microsoft's design.

Maybe? But I'm not sure from the documentation whether it is ever possible to get ERROR_NOT_ALL_ASSIGNED in the “failure” case. If it is only possible in the “success” case, then returning only the error value still provides sufficient information, which callers can use like:
	err := windows.AdjustTokenPrivileges(…)
	switch err {
	case nil:
		// Adjusted all specified privileges.
	case windows.ERROR_NOT_ALL_ASSIGNED:
		// Partial success, but “[t]he token does not have one or more of the privileges
		// specified in the NewState parameter.”
	default:
		// Failure.
		return err
	}

That is: maybe the bool return value is just there to save callers the expense of a call to GetLastError in the trivial success case?

maybe the bool return value is just there to save callers the expense of a call to GetLastError in the trivial success case?

Could be, but this assumption is not written in the AdjustTokenPrivileges docs. I think that it is safer and future-proof to return (sucess bool, err error) so we don't have to create a AdjustTokenPrivileges3 in 5 years.

@qmuntal what would your proposed new AdjustTokenPrivileges2 function do? How would it calculate the success return value?

Like in here: https://go-review.googlesource.com/c/sys/+/566036

@qmuntal

maybe the bool return value is just there to save callers the expense of a call to GetLastError in the trivial success case?

Could be, but this assumption is not written in the AdjustTokenPrivileges docs. I think that it is safer and future-proof to return (sucess bool, err error) so we don't have to create a AdjustTokenPrivileges3 in 5 years.

Do you have a repro that demonstrates the problem with the current Go implementation of the AdjustTokenPrivileges?
If you do not have, then I would not vote for implementing AdjustTokenPrivileges2 just because you or others read Microsoft AdjustTokenPrivileges documentation in a particular way.
Perhaps Go implementation does not match Microsoft documentation. But as long as users programs are not broken in any way, why change anything?

@qmuntal what would your proposed new AdjustTokenPrivileges2 function do? How would it calculate the success return value?

Like in here: https://go-review.googlesource.com/c/sys/+/566036

Your https://go-review.googlesource.com/c/sys/+/566036 change does not contain AdjustTokenPrivileges2 function. If you propose we add new AdjustTokenPrivileges2 function, then we should see what the function will do. I would also like to see if new AdjustTokenPrivileges2 solves the problem in the repro that you will provide.
Thank you.
Alex

Do you have a repro that demonstrates the problem with the current Go implementation of the AdjustTokenPrivileges?

The issue description contains a reproducer. When running as no-admin, windows.AdjustTokenPrivileges returns no error, but the privilege hasn't been granted. It should return ERROR_NOT_ALL_ASSIGNED.
CL 566036 also contains a test case that fails with the current Go implementation.

Perhaps Go implementation does not match Microsoft documentation. But as long as users programs are not broken in any way, why change anything?

The point is that programs that use windows.AdjustTokenPrivileges are probably broken, because they can't detect when a privilege hasn't been granted. This is why some projects that know about this issue don't use that function, but define their own. For example, microsoft/go-winio.

@qmuntal

CL 566036 also contains a test case that fails with the current Go implementation.

Thanks for the test case. I was able to reproduce the problem.
I agree with your suggestion to add

// AdjustTokenPrivileges2 enables or disables privileges in the specified token
// by calling AdjustTokenPrivileges.
// Note that err can be [ERROR_NOT_ALL_ASSIGNED] even if success is true,
// which means that one or more privileges were not adjusted.
func AdjustTokenPrivileges2(...) (success bool, err error)

Alex


{Bug}Can't find the used version for this target. Or the target: IP is offline.

HI
all site online but send offline can check file.
Can't find the used version for this target. Or the target:  is offline.
thanks.

same issue

You may using http version. So, you should modify code at the line 21 "https" -> "http" and line no. 44


mgmt, revert the rename from swagger

Though the updated class name is more appropriate, changing them causing too much downstream effect to dependencies.
Hence revert back to the previous class name.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


is there a way to use it as a function?

so is it possible to like import it
and use it as a function for one of my project?
if not is there a rest Api that I can use o
when I host it?

@Kolhax I don't think there's a ready to use SDK. I feel it won't be hard to build a SDK on top of the rest API by your own.

@Kolhax I don't think there's a ready to use SDK. I feel it won't be hard to build a SDK on top of the rest API by your own.

honestly I dint got time to test it, but how do I use The Api?