LVGL & WIFI = Crash

We use GitHub issues for development related discussions.
Describe the issue
The problem only happens when I integrate a task that connects the esp32 to a wifi access point. In fact, the task is not even executed yet that I get a “Panic Core dump (LoadStore Error)”.
So the error does not come from an error in the task itself.
Code to reproduce the issue
lv_port_esp32 (lv_demo_widget) with wifi station connect task
ESP32 Chip version
ESP32 devkit (4 MB flash, chip revision 1, ESP32-D0WDQ6)
ESP-IDF version
version : 4.3
Compilation warnings/errors (if available)
Console terminal result :

I (26) boot: ESP-IDF v4.3.1-dirty 2nd stage bootloader
I (26) boot: compile time 16:37:41
I (27) boot: chip revision: 1
I (30) boot_comm: chip revision: 1, min. bootloader chip revision: 0
I (37) boot.esp32: SPI Speed : 80MHz
I (41) boot.esp32: SPI Mode : DIO
I (46) boot.esp32: SPI Flash Size : 4MB
I (51) boot: Enabling RNG early entropy source…
I (56) boot: Partition Table:
I (60) boot: ## Label Usage Type ST Offset Length
I (67) boot: 0 nvs WiFi data 01 02 00009000 00006000
I (74) boot: 1 phy_init RF data 01 01 0000f000 00001000
I (82) boot: 2 factory factory app 00 00 00010000 00100000
I (89) boot: End of partition table
I (93) boot_comm: chip revision: 1, min. application chip revision: 0
I (100) esp_image: segment 0: paddr=00010020 vaddr=3f400020 size=9c1b0h (639408) map
I (302) esp_image: segment 1: paddr=000ac1d8 vaddr=3ffb0000 size=02f3ch ( 12092) load
I (306) esp_image: segment 2: paddr=000af11c vaddr=40080000 size=00efch ( 3836) load
I (309) esp_image: segment 3: paddr=000b0020 vaddr=400d0020 size=4a088h (303240) map
I (408) esp_image: segment 4: paddr=000fa0b0 vaddr=40080efc size=0e2b4h ( 58036) load
I (428) esp_image: segment 5: paddr=0010836c vaddr=50000000 size=00010h ( 16) load
I (436) boot: Loaded app from partition at offset 0x10000
I (436) boot: Disabling RNG early entropy source…
I (449) cpu_start: Pro cpu up.
I (449) cpu_start: Starting app cpu, entry point is 0x400813ec
0x400813ec: call_start_cpu1 at C:/Users/Utilisateur/esp/esp-idf/components/esp_system/port/cpu_start.c:141
I (0) cpu_start: App cpu up.
I (463) cpu_start: Pro cpu start user code
I (463) cpu_start: cpu freq: 240000000
I (463) cpu_start: Application information:
I (467) cpu_start: Project name: lvgl-demo
I (473) cpu_start: App version: <IP_ADDRESS>
I (478) cpu_start: Compile time: May 3 2022 08:59:31
I (484) cpu_start: ELF file SHA256: 6721320b3e46e617…
I (490) cpu_start: ESP-IDF: v4.3.1-dirty
I (495) heap_init: Initializing. RAM available for dynamic allocation:
I (502) heap_init: At 3FFAE6E0 len 00001920 (6 KiB): DRAM
I (508) heap_init: At 3FFB3FE8 len 0002C018 (176 KiB): DRAM
I (515) heap_init: At 3FFE0440 len 00003AE0 (14 KiB): D/IRAM
I (521) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (527) heap_init: At 4008F1B0 len 00010E50 (67 KiB): IRAM
I (534) spi_flash: detected chip: generic
I (538) spi_flash: flash io: dio
I (543) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.
 Done
Reading restart counter from NVS …
intervalle_lavage= 100
The value is not initialized yet!
I (633) lvgl_helpers: Display buffer size: 53248
I (633) lvgl_helpers: Initializing SPI master for FT81X
I (643) lvgl_helpers: Configuring SPI host VSPI_HOST (2)
I (643) lvgl_helpers: MISO pin: 19, MOSI pin: 23, SCLK pin: 18, IO2/WP pin: 16, IO3/HD pin: 4
I (663) lvgl_helpers: Max transfer size: 212992 (bytes)
I (663) lvgl_helpers: Initializing SPI bus…
I (663) disp_spi: Adding SPI device
I (673) disp_spi: Clock speed: 23000000Hz, mode: 0, CS pin: 5
I (753) FT81X: Switching to QIO mode
I (773) FT81X: DummyReadBits = 2
I (1773) FT81X: CHIP ID (Display EVE3) = 124
REG_FREQUENCY = 72000000
Guru Meditation Error: Core 0 panic’ed (LoadStoreError). Exception was unhandled.
Core 0 register dump:
PC : 0x40118fc0 PS : 0x00060f30 A0 : 0x800e0d4c A1 : 0x3ffbace0
0x40118fc0: lv_style_get_prop_inlined at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/misc/lv_style.h:373
(inlined by) lv_style_get_prop at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/misc/lv_style.c:214
A2 : 0x3f4867b8 A3 : 0x00001032 A4 : 0x3ffbad00 A5 : 0x00000000
A6 : 0x00000010 A7 : 0x00000001 A8 : 0x00000100 A9 : 0x00000000
A10 : 0x400f43d8 A11 : 0x400f43d8 A12 : 0x400f42d8 A13 : 0x00000040
0x400f43d8: lv_disp_draw_buf_init at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/hal/lv_hal_disp.c:108
0x400f43d8: lv_disp_draw_buf_init at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/hal/lv_hal_disp.c:108
0x400f42d8: lv_font_get_glyph_dsc_fmt_txt at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/font/lv_font_fmt_txt.c:150
A14 : 0x00001001 A15 : 0x00000000 SAR : 0x0000001d EXCCAUSE: 0x00000003
EXCVADDR: 0x400f43d8 LBEG : 0x400013f9 LEND : 0x4000140d LCOUNT : 0xfffffffa
0x400f43d8: lv_disp_draw_buf_init at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/hal/lv_hal_disp.c:108
Backtrace:0x40118fbd:0x3ffbace0 0x400e0d49:0x3ffbad00 0x400e0dac:0x3ffbad50 0x400de437:0x3ffbad80 0x400fb929:0x3ffbada0 0x400fc42e:0x3ffbae40 0x40117bb9:0x3ffbae80 0x400da9a3:0x3f
0x400e115d:0x3ffbaf20 0x400d82ae:0x3ffbaf40 0x400d979b:0x3ffbb050 0x400d987b:0x3ffbb070 0x400d6d37:0x3ffbb090 0x400d6df3:0x3ffbb0b0 0x4008afbd:0x3ffbb140
0x40118fbd: lv_style_get_prop_inlined at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/misc/lv_style.h:373
(inlined by) lv_style_get_prop at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/misc/lv_style.c:214
0x400e0d49: get_prop_core at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/core/lv_obj_style.c:587
0x400e0dac: lv_obj_get_style_prop at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/core/lv_obj_style.c:220
0x400de437: lv_obj_get_style_border_width at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/core/lv_obj_style_gen.h:298
(inlined by) lv_obj_get_content_coords at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/core/lv_obj_pos.c:573
0x400fb929: lv_label_refr_text at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/widgets/lv_label.c:891
0x400fc42e: lv_label_event at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/widgets/lv_label.c:758
0x40117bb9: lv_obj_event_base at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/core/lv_event.c:96
0x400da9a3: event_send_core at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/core/lv_event.c:414
0x400daa52: lv_event_send at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/core/lv_event.c:73
0x400e103d: lv_obj_refresh_style at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/core/lv_obj_style.c:182
0x400e115d: lv_obj_add_style at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lvgl/src/core/lv_obj_style.c:103
0x400d82ae: infos_create at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lv_examples/lv_examples/src/lv_confortum/lv_confortum.c:370
0x400d979b: main_page at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lv_examples/lv_examples/src/lv_confortum/lv_confortum.c:222
0x400d987b: lv_confortum at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/components/lv_examples/lv_examples/src/lv_confortum/lv_confortum.c:192
0x400d6d37: create_demo_application at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/main/main.c:552
0x400d6df3: guiTask at C:\Users\Utilisateur\esp\esp-idf\lv_port_esp32_9\build/…/main/main.c:526 (discriminator 2)
0x4008afbd: vPortTaskWrapper at C:/Users/Utilisateur/esp/esp-idf/components/freertos/port/xtensa/port.c:168
ELF file SHA256: 6721320b3e46e617
Rebooting…

LOG LVGL DETAILS

[...]
[Trace] (17.592, +8)     event_send_core: Sending event 34 to 0x3ffb6070 with 0x3ffb6218 param  (in lv_event.c line #403)
[Trace] (17.603, +11)    event_send_core: Sending event ended   (in lv_event.c line #437)
[Trace] (17.610, +7)     event_send_core: Sending event 38 to 0x3ffb6218 with 0x3ffdf590 param  (in lv_event.c line #403)
[Trace] (17.621, +11)    event_send_core: Sending event ended   (in lv_event.c line #437)
[Trace] (17.628, +7)     event_send_core: Sending event 38 to 0x3ffb6218 with 0x3ffdf590 param  (in lv_event.c line #403)
[Trace] (17.639, +11)    event_send_core: Sending event ended   (in lv_event.c line #437)
Guru Meditation Error: Core  0 panic'ed (LoadStoreError). Exception was unhandled.
If possible, copy the compilation log into a file and attach it here

I have based my example off this repo and I have spent EXTREMELY LONG TIME and nights debugging a similar issue. In short, this is fixed by two following things:

Adding IRAM_ATTR attribute to the lv_tick_task
Adding -DLV_ATTRIBUTE_TICK_INC=IRAM_ATTR to the platformio.ini build_flags (or applying LV_ATTRIBUTE_TICK_INC=IRAM_ATTR in your lvgl config).

When it manifests:

Your lvgl is running in one task
In the other task, you are performing some actions which require disabling memory access and cores, including but not limited to:

starting/stopping wireless connection Wifi.begin(...)
writing to flash memory, for example with Preferences.

During that time, interrupt is fired and CPU jumps to the code. Without IRAM_ATTR the code is not in the cache, it's impossible to exec interruption handler
If you try to work around with noInterrupts() and interrupts(), you might reduce  the scope of the problem, but instead you get some severe watchdog problems which cause unexpected restarts.

Hope it helps some people. I will try to create a PR to this repo a bit shortly after (but if someone wants to do that first, feel free to do so).

Hmm, we saw a MemFault/BusFault after executing lv_font_get_glyph_dsc_fmt_txt() in one of our nightly tests.
We never saw this kind of error before and we yet couldn't reproduce the issue.
I just saw you also mention "lv_font_get_glyph_dsc_fmt_txt" in your logs and we also use the the cache options of the microcontroller. But we are running on a STM32H7 so a really different platform...

and we also use the the cache options of the microcontroller.

@Viatorus if that's the same issue, you can relatively easy rule it out:

Modify your application so that crash occurs every single time. In my case I had a function which saved settings to flash every minute. Instead I modified it to run 10 times a second, so random crash occured almost instantly after boot. That will help you identify the cause later.
Remove the timer which calls lv_tick_task. LVGL will be effectively broken, but all function calls will continue working as normal. If the application has stopped crashing, then you have the same issue as I had.
If you still have crashes, disable parts of your application one by one, until it stops crashing.

I just saw you also mention "lv_font_get_glyph_dsc_fmt_txt" in your logs

In my case stacktraces were basically useless, because the program memmory was not accessible. Therefore the execution jumped to random addresses of the code. Ideally debugger is needed to find a cause for such an issue, but unfortunately I didn't have any access to it.

I have a same problem.
void scanWifi(void *parameter) {
    lv_obj_t *display = (lv_obj_t *) parameter;
    lv_obj_t *list = lv_list_create(display);
    lv_obj_set_size(list, LV_PCT(100), LV_PCT(100));
    WiFi.begin();
    int n = WiFi.scanNetworks();
    Serial.println("[*] Scan done");
    if (n < 0) {
        Serial.println("[-] No WiFi networks found");
    } else {
        Serial.println((String) "[+] " + n + " WiFi networks found\n");
        for (int i = 0; i < n; ++i) {
            lv_list_add_btn(list, NULL, WiFi.SSID(i).c_str());
            vTaskDelay(10 / portTICK_PERIOD_MS);
        }
    }

    vTaskDelete(TaskHandle_2);
}

xTaskCreate(scanWifi, "scanWifi", 1024 * 10, (void *) display, 10, &TaskHandle_2);

Exactly the same issue. It simply crash and crash and took me long time trying to solve the problem by increasing stack amount,adding some vTaskDelay, some sort like that,but these did nothing good...as @derlaft 's advice,adding iram attr actually helps a lot. Now my issue is like random wdt reset. Working hard on it.

@Potak0 btw I wrote a sligthly more detailed writeup here, it might contain a bit more details and debugging steps which could help you

@derlaft that does increased my understanding.thanks a lot.

@axlb97 I've just checked my platformio.ini and it has also:

-DLV_ATTRIBUTE_TIMER_HANDLER=IRAM_ATTR
-DLV_ATTRIBUTE_FLUSH_READY=IRAM_ATTR
I don't remember why I added them (likely for performance), but double-checking if they help you should not hurt

What else comes to my mind:

Do you (or maybe the display) use ADC2? (It's shared with Wi-Fi)
Try changing the drawing loop RTOS priority to a higher value (maybe weird issues are called by interrupts in the drawing routines; to avoid that I slightly raise the priority of the lvgl task while a draw is in progress)
Would generally be interesting to look at your display driver func.

@derlaft

@axlb97 I've just checked my platformio.ini and it has also:

-DLV_ATTRIBUTE_TIMER_HANDLER=IRAM_ATTR
-DLV_ATTRIBUTE_FLUSH_READY=IRAM_ATTR
I don't remember why I added them (likely for performance), but double-checking if they help you should not hurt

I'm going to remove the call to tft.init() and add those attributes to platformio.ini to see if it improves. Calling tft.init() makes the display go black for a second and it's annoying.
If the device doesn't have a connection, it retries the reconnection every 20 seconds, so every 20 seconds  tft.init() is called.
In setup(), i disabled the auto-reconnection with WiFi.setAutoreconnect(false).
But seeing that calling a function of tft to resolve the issue makes me suspect that it's maybe a problem with that library and not with lvgl, idk.
Since i need to have them finished soon since these devices are required in the laboratories where i work i started working on a parallel code where i use sprites to shape the interface, after all, it's a very simple design. But i haven't made much progress yet. i wasn't very happy with that because that way I can't use the Montserrat font.

What else comes to my mind:

Do you (or maybe the display) use ADC2? (It's shared with Wi-Fi)

Now that I notice, something like that. I don't use ADC2, but the DC pin of the display is connected to GPIO2 (ADC2_2), maybe causing issues.

Try changing the drawing loop RTOS priority to a higher value (maybe weird issues are called by interrupts in the drawing routines; example how I do that (sorry, that code is not very high quality, but should give an example))
Would generally be interesting to look at your display driver func.

Since the code related to lvgl is generated by Squareline Studio when exporting the project (I don't have any previous experience with lvgl before this. In fact, I came to know lvgl thanks to squareline studio while looking for an easy way to design my interfaces.)  I couldn't find where the tasks are declared and what priority they are assigned. A similar function to the one you showed me is this one (also generated by Squareline Studio).
void my_disp_flush(lv_disp_drv_t *disp, const lv_area_t *area, lv_color_t *color_p)
{
    uint32_t w = (area->x2 - area->x1 + 1);
    uint32_t h = (area->y2 - area->y1 + 1);

    tft.startWrite();
    tft.setAddrWindow(area->x1, area->y1, w, h);
    tft.pushColors((uint16_t *)&color_p->full, w * h, true);
    tft.endWrite();

    lv_disp_flush_ready(disp);
}

I've created another task to execute the lv_timer_handler() function every 5ms
xTaskCreatePinnedToCore(taskDisplayHandler, "TaskDisplayHandler", 4096, NULL, 20, NULL, 1);
Its definition:

 LV_ATTRIBUTE_TIMER_HANDLER uint32_t lv_timer_handler(void)
{
    TIMER_TRACE("begin");

    /*Avoid concurrent running of the timer handler*/
    static bool already_running = false;
    if(already_running) {
        TIMER_TRACE("already running, concurrent calls are not allow, returning");
        return 1;
    }
    already_running = true;

    if(lv_timer_run == false) {
        already_running = false; /*Release mutex*/
        return 1;
    }

    static uint32_t idle_period_start = 0;
    static uint32_t busy_time         = 0;

    uint32_t handler_start = lv_tick_get();

    if(handler_start == 0) {
        static uint32_t run_cnt = 0;
        run_cnt++;
        if(run_cnt > 100) {
            run_cnt = 0;
            LV_LOG_WARN("It seems lv_tick_inc() is not called.");
        }
    }

    /*Run all timer from the list*/
    lv_timer_t * next;
    do {
        timer_deleted             = false;
        timer_created             = false;
        LV_GC_ROOT(_lv_timer_act) = _lv_ll_get_head(&LV_GC_ROOT(_lv_timer_ll));
        while(LV_GC_ROOT(_lv_timer_act)) {
            /*The timer might be deleted if it runs only once ('repeat_count = 1')
             *So get next element until the current is surely valid*/
            next = _lv_ll_get_next(&LV_GC_ROOT(_lv_timer_ll), LV_GC_ROOT(_lv_timer_act));

            if(lv_timer_exec(LV_GC_ROOT(_lv_timer_act))) {
                /*If a timer was created or deleted then this or the next item might be corrupted*/
                if(timer_created || timer_deleted) {
                    TIMER_TRACE("Start from the first timer again because a timer was created or deleted");
                    break;
                }
            }

            LV_GC_ROOT(_lv_timer_act) = next; /*Load the next timer*/
        }
    } while(LV_GC_ROOT(_lv_timer_act));

    uint32_t time_till_next = LV_NO_TIMER_READY;
    next = _lv_ll_get_head(&LV_GC_ROOT(_lv_timer_ll));
    while(next) {
        if(!next->paused) {
            uint32_t delay = lv_timer_time_remaining(next);
            if(delay < time_till_next)
                time_till_next = delay;
        }

        next = _lv_ll_get_next(&LV_GC_ROOT(_lv_timer_ll), next); /*Find the next timer*/
    }

    busy_time += lv_tick_elaps(handler_start);
    uint32_t idle_period_time = lv_tick_elaps(idle_period_start);
    if(idle_period_time >= IDLE_MEAS_PERIOD) {
        idle_last         = (busy_time * 100) / idle_period_time;  /*Calculate the busy percentage*/
        idle_last         = idle_last > 100 ? 0 : 100 - idle_last; /*But we need idle time*/
        busy_time         = 0;
        idle_period_start = lv_tick_get();
    }

    already_running = false; /*Release the mutex*/

    TIMER_TRACE("finished (%d ms until the next timer call)", time_till_next);
    return time_till_next;
}


Fix locking in safeconfig

What does this PR do?

Fix locking logic in safeConfig.
Motivation

Two functions didn't lock while they should, one read-locked instead of write, and a lot write-locked instead of read.
Additional Notes

GetEnvVars and GetAllSources didn't lock at all
SetEnvKeyReplacer called RLock instead of Lock
IsKnown, GetKnownKeys, UnmarshalKey, Unmarshal , UnmarshalExact, AllSettings , AllSettingsWithoutDefault, AllFileSettingsWithoutDefault, AllEnvVarSettingsWithoutDefault, and ConfigFileUsed called Lock instead of RLock

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


All pages should correctly render both unordered lists AND download buttons

Currently the pages under /install (all the pages linked to from the buttons on https://konghq.com/install/) have special handling for Markdown unordered lists - if you edit a page like https://github.com/Kong/docs.konghq.com/blob/master/app/install/kubernetes.md to add an unordered list without links:
## Table of Contents

- foo
- bar
- bang

It will be rendered strangely:

and if you make the unordered list contain links:
## Table of Contents

- [foo](http://www.konghq.com)
- [bar](http://www.konghq.com)
- [bang](http://www.konghq.com)

it will be rendered as download buttons:

Note that entering the same unordered list Markdown on pages outside of /install works as expected, and renders correctly as an unordered list.
To resolve this issue, we need a way to have a choice of showing download buttons, or unordered lists, on all pages in the site - note that this approach not only allows display of unordered lists on /install pages, but it also allows inclusion of download buttons on pages that are not in /install
Suggested Resolution
There seem to be various options to resolve this https://stackoverflow.com/questions/40688633/how-can-i-add-a-button-in-a-md-file-with-jekyll - I think I prefer option 2, and I like https://stackoverflow.com/a/40753294

@coopr I think I did what you wantted in https://github.com/Kong/docs.konghq.com/pull/918 but would appreciate it if others could review for me

I did an ugly hack to make https://docs.konghq.com/install/kubernetes/ display a Table of Contents - I used an ordered list:


Add events from History to Admin Comments tab to match comments with events

Description:
Add events from History to Admin Comments tab to match comments with events:

a request is not a product.

I believe the Description was about Edit and Delete Requests.

@funtigr can you explain more about the requirement? I cannot picture of what it needs to be done.

Sure.
On History Tab we
display the Rejected Request events and comments for Edit and Delete Request. The comments displayed, are made by Reviewers for the users in the modal with heading 'Are you sure you want to reject this edit product request?'.

Olena wanted the events to be displayed in the Admin Comments tab (the feature implemented by Amritpal) in chronological order. For Admins to be able to see the Rejections made by other Admins (because sometimes they reject the quota increase without leaving comment on Admin Comments tab).


Mada

Feature or enhancement
Check spelling of Maga Buryatdan. Should be Magadan
https://sfg.taxonworks.org/geographic_areas/20860
Location
geographic area
Screenshot, napkin sketch of interface, or conceptual description
No response
Your role
No response

@Omias thanks for thie issue, welcome here.
You can and this spelling via annotation with an alternate value.  See the radial annotator.


Write pytests for training functionality

Feature Request
Remove this section if your issue is not a feature request. Make sure to add the Type: Enhancement label if it is.
Feature Description
Please describe the feature you'd like implemented.
The project needs pytests for all training elements: optimizers, metrics, model training pipeline, etc., which currently don't exist.
Feature Request: Changes to API
If your feature request includes changes to the solaris API, describe that here. Note that any changes to required arguments or argument order in the API will only be made at a major version release. See the contributing guidelines for additional details.

Final steps
References to other issues/PRs
If you did not already include references above, list references to relevant PRs, issues, or other pages here.
Labels
Make sure to select a Type label for your issue. The repo maintainers will add other labels, milestones, and projects (if applicable).

Resolved with #76


feat: Added a try catch block to check the size of array.

Description
Added a try catch block to catch the error of wrong sizes of the array for multiplicaiton.
If the issue is on Github, simply link to it using the '#' symbol):

resolves #6

Type of change

feat: A new feature

Updaeted the exception message. And comment.


Files or folders uploaded to a blob container do not show in workspace view for a local emulator

v2 Forward compat
When you open the blob container in the explorer the uploaded files and folders show there but not in the workspace view.

I'm having trouble reproducing this. Could you provide more details repro steps?
What I've tried and got working:

Viewing uploaded files/folders in an Attached Storage Account
Uploading and viewing things to emulated blob containers

Do you mean that when you upload a file/folder to a blob container, the Resources view is refreshed and shows the newly uploaded items, but the workspace view does not?

Repro steps in the workspace view:
Under the Local Emulator node I right clicked on Blob Container and created a blob container. After that I right clicked and uploaded a file/folder.
I receive a message that the upload succeeded but the file does not show under the blob container in the workspace view even if I refresh the view.
If I click open in explorer under the blob container in the workspace view the explorer shows the uploaded files/folders. This tells me it seems to have uploaded correctly but isn't being shown for some reason?

Got it. I might have accidentally been testing with #554 so that could explain why I couldn't repro.

I have verified that https://github.com/microsoft/vscode-azureresourcegroups/pull/554 fixes this.


Latest release is wrongly tagged

Super minor detail. But title says 0.1.41331 but the tag says 0.1.4331 :)

Latest release is now https://github.com/microsoft/winget-cli/releases/tag/v0.1.41821-preview


'NoneType' object has no attribute 'tags'

I am getting the attached when i am adding  PRECIPITANTS ,please help sir

getting in campaigns/forms.py at line number 76
"colossus\apps\campaigns\forms.py", line 76, in init
self.fields['tag'].queryset = self.instance.mailing_list.tags.order_by('name')"
AttributeError: 'NoneType' object has no attribute 'tags'

@NayabKhan2019Mar03 Fixed with PR https://github.com/vitorfs/colossus/pull/32


tmux terminal resizes randomly

VSCode Version: 1.31
OS Version: macOS 10.14.3

Steps to Reproduce:

have tmux running in the integrated terminal, looking good
launch debugging with the setting "console": "integratedTerminal",
Now the tmux terminal seems to be temporarily resized, so that it displays as if the terminal had a much smaller size.  See image below.

If I issue the tmux refresh-client command (ctrl-b r) tmux resizes and displays correctly again.
This was not an issue before 1.30. The behaviour is not consistent, sometimes tmux renders fine, sometimes it does not. I think the problem has happened on other occasions than debugging.

Does this issue occur when all extensions are disabled?: Yes

Could you see if this reproduces in the Insiders build? https://code.visualstudio.com/insiders

The problem is a lot less pronounced in insiders. It still manifests sometimes, but much less than in stable.

Might be related to reflow

It might be a good idea not to use tmux as a debug shell? There's a new setting "automationShell" which lets you use a more stripped down one for debug and tasks.

I like it a lot having debug in one of my tmux panes. It lets me do things in other panes while I see the result of test debugging in the separate pane.


qdl: Allow user to decide USB OUT buffer multiplier

Due to issue related in 760b3df qdl is not sending big chunk of data at once to USB driver. That affects performance of flashing.
This change allows user to set multiplier of buffer size. If may cause issues on some machines but gives huge speed gain.

Very useful feature and improvement, it saves me a lot of time, instead of 15 minutes I can flash devices in 2 minutes max! Thank you!

Can confirm this works quite well. With this flashing goes from ~14MiB/s without this PR to about ~44MiB/s with --multiplier 2048

multiplier
flashing speed

128
38262kB/s

256
40948kB/s

512
42437kB/s

1024
43222kB/s

2048
44038kB/s

When rebasing on master there's some minor conflicts, struct qdl_device has moved to the file qdl.h

Looking at that problem description again, I am puzzled to the exact details and why this wasn't fixed in the kernel instead - it seems unreasonable to allow user space to DOS the kernel like that. And indeed, there is a comment in the kernel documenting that the length can be "almost arbitrarily large". I also don't understand why I accepted changing this to 512 bytes.
With that in mind, I think the proposed multiplier-based mechanism favors user control over user friendliness, and I instead suggest that we clamp the value to e.g 128KB and if that breaks people's systems we 1) debug the kernel 2) consider our options for knobs etc.

Replaced with #73, thanks for pushing for this!

It's taken me a while to test the new version, but flashing without any extra arguments now take 2.6 minutes for my device, with flashing speed for super partition being around 41000kB/s to 42000kB/s, so being very close to what I tested at https://github.com/linux-msm/qdl/pull/39#issuecomment-2061451681, and I have a bit different USB connections now compared to when I last tested.
Thanks @andersson!


Investigate building a docker container officially vs. local make instructions.

This is a Feature Request
With the adoption of the theme Docsy, running Hugo locally has been known to cause bugs. The most common bug is a "too many open files" error.
To remediate these challenges, SIG Docs is updating the README.md and k/website contributor guides on how to use a Docker container for testing website changes.
Today, the plan involves describing how to run a make file to build the container and instructions on how to use that container to preview website changes.
What would you like to be added
Create a periodic job that publishes a k/websites docker image (based on a Dockerfile) in Kubernetes' official docker repository.
Why is this needed
If we had a periodic job that built and published an "official" container using Kubernetes infrastructure, the end user would not have to run make to build a container. In addition, instructions would be more cross-platform friendly as make is not available on Windows.
Comments
The entire scope of this issue is for me to investigate how hard will it be to create, schedule, maintain, and support a k/website docker image.
After investing our options, we may ultimately decide to take no action if the efforts are unsustainable.
/assign
/cc @kbarnard10 @zacharysarah
/cc @celestehorgan @sftim @kbhawkey @onlydole @adambkaplan
Related:
https://github.com/kubernetes/website/issues/22586
https://github.com/kubernetes/website/pull/22518

/priority important-longterm
/kind feature

The Dockerfile already exists, and has had at least informal testing with both Docker and Podman.

https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action ?

The tricky bit, I think, is authorizing the image push to the official repository.

I don't know under what circumstances there are too many open files. I guess I missed the details and explanation.
To recap, the reason for creating this issue is to investigate creating a "standard" build image, containing the accepted
version of Hugo, Linux, and related libraries? Also, contributors can skip the container image build step?
Contributors can always download a version of Hugo to test their changes locally (hopefully the instructions will remain in the docs).
Occasionally, I use (x86)/GnuWin32/bin/make on Windows. Though, not for building the site.
Typically I build and run the container targets on a Linux installation on the same machine.
Recently the targets changed to be container engine neutral. How will this be impacted?

I do like the base image direction to make this easier, and +1 on @kbhawkey's question around impacts for Docker and Podman (how would we want to set that up for success?)

If you have a container image that you build locally and that works, building the same thing in CI and then fetching that from a container registry is very likely to also work fine when you use it on your PC.

I do like the base image direction to make this easier, and +1 on @kbhawkey's question around impacts for Docker and Podman (how would we want to set that up for success?)

Using CONTAINER_ENGINE as an arg in the Makefile is pretty common. Defaulting to docker is the safest choice - so many podman users alias docker that there is now a podman-docker RPM to do it for you.
I can't speak for other container engines - perhaps we need a note that the CONTAINER_ENGINE must implement the pull, build, and run command line interfaces?

I don't have a problem with the current container targets in the Makefile. If an image is provided, I will use it.
I do most of my build/test on Linux (found Hugo runs best there) and split between building the site from the cmd line, and building/running the site in a container. I noticed that my local builds started to slow down around the time of the parser upgrade. And more so now with the addition of the theme. Is there a way to get data about the average build time for production builds of the site?
Thanks @jimangel .

get data about the average build time for production builds of the site?

Nice idea. There are a few ways we can get that data. Either grab it from the Netlify logs (which are public) or run a separate deploy in a container, time it, and publish a metric.
Maybe Netlify already tracks this for us?

I was actually planning to look at rewriting the makefile to automatically rebuild the image as a dependency of the other targets when the image changes, which might be worth considering still.
One issue with hosting pre-built is that Kubernetes provides GCR registries, which are not available in china AIUI, which seems extra problematic for k/website.

That's OK @BenTheElder I think
Anyone affected by state-level censorship can still build the container image locally if they have a tool such as Docker or Podman that knows how to do that.

If that's the case and we're fine with that ...
/assign
We have tooling & processes for CI build Kubernetes images on official project GCR.

@BenTheElder thanks! I would be happy to work with you on this. Let me know how I can help!

Great! I sent you a brain-dump on slack, will sync more when you're on next!
On Thu, Jul 16, 2020 at 5:09 PM Jim Angel<EMAIL_ADDRESS>wrote:

@BenTheElder https://github.com/BenTheElder thanks! I would be happy to
work with you on this. Let me know how I can help!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/issues/22515#issuecomment-659746399,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHADKYWAK6FHSMCG27E4BTR36JFJANCNFSM4OZYRREA
.

Request for a staging registry from wg-k8s-infra submitted in https://github.com/kubernetes/k8s.io/issues/1033
The process is normally to have auto-pushed images from CI go into a staging registry per-project (so we'll get one for kubernetes/website), and then you can file PRs to k8s.io to promote a digest from staging to a tag in the prod registry.
https://github.com/kubernetes/website/pull/22554 updates the image to have an automatic :v$(HUGO_VERSION)-$(DOCKERFILE_VERSION) tag, since we'd normally promote specific versions (and since they're normally never mutated you don't need to pull repeatedly when running them).
Next up we'll need the cloudbuild.yaml spec and prow trusted image build job.
See also the TODO comment in https://github.com/kubernetes/website/pull/22554
Once they're promoted users can just run make container-build w/o any pull and it will pull the missing image if the tag isn't already present. The auto-tag should change when the image changes (and therefore be pulled)

For more on k8s.gcr.io, see: https://github.com/kubernetes/k8s.io/tree/master/k8s.gcr.io, this has pretty good documentation now.
This coming monday we should be able to actually publish under k8s.gcr.io alongside the other kubernetes images via community infra :-)

The entire scope of this issue is for me to investigate how hard will it be to create, schedule, maintain, and support a k/website docker image.

eep. I've definitely jumped the gun on this, sorry 😞

Er so, I don't think it will be mucher harder than the existing image, basically we'll leverage the community infra to host it the same way other projects are doing it, the main maintenance work will be submitting / possibly approving PRs to promote new image versions.
Those are pretty low effort: basically you just grab the digest for the new image either from the CI log or from browsing the staging registry and file a PR to some yaml adding a line ~ like "sha256:abcdef": ["v0.70.0-0"] (digest: tags to publish it as).
Even if we don't pre-publish images, the Dockerfile also needs to be looked after, and the makefile.
All of the tooling for the image hosting, building, etc. is shared across the project, so k/website won't need to maintain that.
We will need to add the cloudbuild.yaml here initially, for the build pipeline, but that shouldn't require ongoing changes, it will just be a simple wrapper around the makefile so we can run it in the secure staging pipeline.
Builds will automatically trigger in prow, and that config typically doesn't require ongoing changes either and will be owned by the prow team (because it runs in the "trusted" cluster).

TLDR: It mostly requires some initial setup (well trodden already), minimal ongoing extra maintenance (filing simple PRs to specify which auto-built images should be promoted to production).
technically we can also use the staging registry directly and not ever promote to production, though it's not "best practice".
The image promotion setup also comes with a community-wide backup & disaster recover plan / management, so we get that for free. There is work to add other goodies like vulnerability scanning.

@BenTheElder for the record, you didn't jump the gun. I wasn't sure of what's possible and you know what is possible. Really happy to see the work you've done on this.
We will need to document some of these ongoing maintenance items in k/website somewhere (contributor guide?).
Catching up now... Thanks!

/lifecycle active
The image has automated versions now, which imho is/was a pre-requesite for this to work well.

following up on https://github.com/kubernetes/k8s.io/issues/1033
sorry this fell behind.

/triage accepted

/lifecycle active
back from vacation. go away fejta-bot

/lifecycle active
back from vacation. go away fejta-bot

Just a reminder that originally

The entire scope of this issue is for [@jimangel] to investigate how hard will it be to create, schedule, maintain, and support a k/website docker image.

Just a reminder that originally

The entire scope of this issue is for [@jimangel] to investigate how hard will it be to create, schedule, maintain, and support a k/website docker image.

(anyone can investigate, but beyond that feels like it wants a new issue)

(anyone can investigate, but beyond that feels like it wants a new issue)

/remove-lifecycle rotten

Sorry about this : (
I will sync with @jimangel at the earliest convenience and see what we can do to round this out / at least braindump any relevant info I can help with.


Any example for h264 encoding？

Is there any example for h264?  or any plan?
thank you !

Sorry, we don't have this.


Added added ormqr! and orgqr!

This adds ormqr! support for QRPivotedWs and orgqr! for both QRWs and QRPivotedWs.
See #18
PS: don't mind the wrong commit, it is indeed orgqr! that's added :sweat_smile:

Codecov Report

Merging #24 (0346468) into main (e0d7661) will decrease coverage by 0.19%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   92.43%   92.23%   -0.20%
==========================================
  Files           8        8
  Lines         502      515      +13
==========================================
+ Hits          464      475      +11
- Misses         38       40       +2

Impacted Files
Coverage Δ

src/qr.jl
91.93% <84.21%> (-0.86%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@louisponet should the doc or README.md be updated?

I don't think so, it's a fix to the behavior rather than a new one.


Editable cells are not allowd to edit some times

Hi,
I am facing a new issue, while editing editable fields, some time it is not allowed to edit input fields. it is throwing console error like:
Error in v-on handler: "TypeError: Cannot set properties of undefined (setting 'isEdit')"

I am using filter to filter fields based on items category, while applying the filter the editable fields are disabled sometimes.
please let me know how can i fix this?
Thank you.

Hi,
Yeah, editing cells working normally if i did not apply filter rows...

Thanks for sharing. I'm playing around with the demo and trying to reproduce the issue.
Basically, when filtering a category, the editable fields are disabled sometimes? Is there a specific scenario when this happens, or it's just random?

Hi,
Thank you for your reply,
Yeah, the editable fields are randomly disabled (not every time) when filtering the category.  And once the editable fields are disabled after filtering the category will be worked again after clearing the filter.
Thank you.

Hi there, I wasn't able to reproduce the specific issue you're having, however I found a different bug related to filtering and editing the wrong cells. Not sure if that will fix your issue but please install latest release "1.0.2" and let me know how it goes.

Hi,
Thank you very much for your response and your valuable time!!
I have updated the package to the latest and tried.
But my issue still exists.

Hi there, there is a new release v1.0.3, it has some new fixes. Please install and let me know if your issue still persists.

Hi,
After testing it for a long time, i confirm that the issue has been resolved in the latest version v1.0.3! (Editable fields disabled sometimes on filter applied)
Thank you very much for all your effort.

Hi,
After testing it for a long time, i confirm that the issue has been resolved in the latest version v1.0.3! (Editable fields disabled sometimes on filter applied)
Thank you very much for all your effort.


TokenPlacement.place() expects prototype token to have a parent, but it (probably) won't

With a change in 3.2.1:
- if ( placement ) placements.push(placement);
- else obj.clear();
+ if ( placement ) {
+   const actorId = placement.prototypeToken.parent.id;
+   uniqueTokens.set(actorId, (uniqueTokens.get(actorId) ?? -1) + 1);
+   placement.index = { total: total++, unique: uniqueTokens.get(actorId) };
+   placements.push(placement);
+ } else obj.clear();

placement.prototypeToken.parent.id is expected to return the actor id. I think this can just be placement.prototypeToken.actorId - I don't think placement.prototypeToken will have a non-null parent property if it's created using an Actor's getTokenDocument() function.

Upon further investigation, this may actually be an issue with the getTokenDocument() stripping out parent, as actor.prototypeToken will have a parent property, but actor.getTokenDocument() won't.

Which (again, probably most specifically) is in the toObject() function of the PrototypeToken class - it already has a data["actorId"] = this.document?.id; - might make sense (if deemed useful) to add data["parent"] = this.parent;

Upon further investigation, this may actually be an issue with the getTokenDocument() stripping out parent, as actor.prototypeToken will have a parent property, but actor.getTokenDocument() won't.

Config on TokenPlacement accepts an array of PrototypeTokens, but getTokenDocument returns a TokenDocument, which has a lot of the similar data but isn't the same. You should just be using actor.prototypeToken to get the data sent to token placement not getTokenDocument. The expected workflow is to use this system to get the placement, and then used the returned data as an input into getTokenDocument (so actor.getTokenDocument(placement)) which will return the token document with the correct position and rotation set.

Gotcha, perfect that makes sense. Thanks for the follow-up!


feat(bug): Fix key name for contribution role in the OrganizationSearchQuery

fixes #1791

In the future we should find a solution so that TypeScript highlights this error. Using the as  does not seem to be sufficient.

@tschaffter I agree. Instead of using as ChallengeSearchQuery|as OrganizationSearchQuery which will ignore the invalid properties in VSCodes, I have replaced them across multiple pages by using specific type to define the variables. For example:
// before
 const defaultQuery = {
       challengeContributionRoles: this.selectedContributionRoles,
      } as OrganizationSearchQuery
// now
 const defaultQuery OrganizationSearchQuery = {
       challengeContributionRoles: this.selectedContributionRoles,
      }
where `selectedContributionRoles` is declared as `ChallengeContributionRole[];`

If there is an invalid property, the error will occur in VSCodes, like:

I think using as ... will help us to escape the typescript errors while developing in VSCodes, but we should be careful using it if we do need to capture these mismatch/invalid properties of data type in the future.


Evaluation Endpoint

Evaluation endpoint and tests.
@dialelo Can you please review? thanks!

:+1:


850 avoid search by id before every server mode download

download info is stored in instance of EODataAccessGateway with key composed of product type, provider and id
if download is attempted for product where id is not in download info and search by id is available for provider and product type, it will be executed; if search by id is not possible an error will be raised to do a search

updated based on input from @alambare-csgroup

closed because change requests were implemented on new branch -> new PR: https://github.com/CS-SI/eodag/pull/1012


Detected by Twitter

Hi,
I used the code to login tw after my account was logged out. But it seems twitter has discovered something.
After a few attempts, my account was suspended.
Can someone give me advice?
I've used: js_click and send_keys.
Thank you very much!

I apologize, but I can't provide guidance or assistance with creating Twitter accounts.


⚠ Bofrost.lu has degraded performance

In e6b2262, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1319 ms

Resolved: Bofrost.lu performance has improved in 47773ef after 16 minutes.


enhancement(sysadvisor): set headroom into metaCache

What type of PR is this?

Enhancements
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:

@luomingmeng pls have a look for this pr, since we can already get headroom info from meta-sever; would be better if this logic can be aligned


[Documentation] Document the configuration of Project JDK and Maven JDK in IntelliJ

Motivation
Currently Java 8 is recommended for Pulsar development. The IntelliJ setup instructions don't currently include the configuration of the Project JDK. It would be helpful to document this.
Java 11 support for building Pulsar in currently being improved. The side effect of this is that some of the configuration is dynamically chosen based on the JDK version. If the JDK version used for importing in IntelliJ is Java 11, and development is done on Java 8, this will lead to inconsistencies and errors about invalid parameters --add-opens java.base/jdk.internal.loader=ALL-UNNAMED in tests since the parameters were chosen at import time when running on Java 11.
Modifications

update IntelliJ IDE setup instructions in README.md
remove duplicated IDE setup instructions in site2/website/contributing.md

/pulsarbot run-failure-checks

@Anonymitaet @Huanli-Meng Thanks for the review feedback and edit suggestions. PTAL

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


BrainBot repeater

Pretty simple, but I think a lot of users would enjoy this. The cool down is shared with the "someone tell me to" auto response as they are somewhat similar.

When we've been testing this, I notice that a lot of people try to configure their wording with the "someone tell me to" command, and I think that it would be nice just to have a repeat function.

Note: If this is accepted the wiki commands should be updated @LukeG294 @bsoyka


rework configuration to be more flexible, fixes #43

@saylorsd let me know what you think.

I like it a lot. I see now I see what you were getting at.  However, I think what I was failing to express before was that the top level, in this case "staging", primarily reflects the loaders.  That is, regardless of which one of our servers we're running this on ('staging', 'live', or my local instance), I'm going to keep the connectors exactly the same, and only change the loaders.  However, now thinking about how these configs are going to be stored in separate physical locations, my idea of having shared config data makes no sense :laughing:.  Along with this I think we can remove the top layer of the config assuming there will be only be one settings.json per server.
i.e.:
{
  "general": {
    "statusdb": ":memory:"
  },
  "connector": {
    "sftp": {
      "county_sftp": {
        "username": "my_username",
        "password": "my_password"
      }
    }
  },
  "loader": {
    "ckan": {
      "ckan_api_key": "your ckan api key",
      "ckan_root_url": "your ckan root url",
      "ckan_organization": {
        "Name": "ckan-generated-hash"
      }
    }
  }
}

Does this sound right?
I think it'll only involve a small change to Pipeline.set_config_from_file() and maybe splitting up test configs into two.

Want to take a pass at it?
On Feb 5, 2016 4:18 PM, "Steven Saylor"<EMAIL_ADDRESS>wrote:

I like it a lot. I see now I see what you were getting at. However, I
think what I was failing to express before was that the top level, in this
case "staging", primarily reflects the loaders. That is, regardless of
which one of our servers we're running this on ('staging', 'live', or my
local instance), I'm going to keep the connectors exactly the same, and
only change the loaders. However, now thinking about how these configs are
going to be stored in separate physical locations, my idea of having shared
config data makes no sense [image: :laughing:]. Along with this I think
we can remove the top layer of the config assuming there will be only be
one settings.json per server.
i.e.:
{
"general": {
"statusdb": ":memory:"
},
"connector": {
"sftp": {
"county_sftp": {
"username": "my_username",
"password": "my_password"
}
}
},
"loader": {
"ckan": {
"ckan_api_key": "your ckan api key",
"ckan_root_url": "your ckan root url",
"ckan_organization": {
"Name": "ckan-generated-hash"
}
}
}
}
Does this sound right?
I think it'll only involve a small change to
Pipeline.set_config_from_file() and maybe splitting up test configs into
two.
—
Reply to this email directly or view it on GitHub
https://github.com/UCSUR-Pitt/wprdc-etl/pull/44#issuecomment-180557224.

Yeah, no prob.

I'm heading out, but I think I completely refactored it to not use the "server" key.  You can check it out here: 519391e241dc3dd32f8a5b8a46a1d5fe623974e1.  I still need to go through and double check the documentation for references to it.  I'll probably look at that tomorrow morning.


Fix wrong movieclip being created

On android we hit a very weird issue where sometimes the movieclip would be empty (or have the wrong number of children), digging and digging we couldn't figure out why, it didn't makes sense. Turns out that while debugging, I notice that the wrong symbol was used during the movieclip creation but the parent definitely had the correct symbol when it tried to create the child.
Somehow we must have one of our extension that use thread on android, a callback is called, some movieclip get created at the same time and that static variable get changed.
I think it's much simpler like that and less error prone, was there a reason why it was using static variable?

Now that I think about it if our extension is having the callback called from another thread, that's a much bigger issue and we wouldn't need that PR haha, anyway maybe that would fix this issue? #1451 ??

The reason for the static variable is to make the MovieClip children already created in the MovieClip constructor.
For example:
class MyCustomMovieClipBaseClass extends MovieClip {

    public function new () {

        super ();
        trace (numChildren);
        trace (getChildByName ("foo"));

    }

}

This only works if we can execute the initialization code for the SWF symbol inside of super(), this static variable is the workaround to implement it :smile:

I see! Makes sense! Anyway the bigger issue was that we somehow was having code being called on a separate thread and we were able to figure this out because of this haha


fix hang after Target.detachedFromTarget event with nested iframes

Description
Fix for chrome UI hang after receiving Target.detachedFromTarget event when working with nested iframes.

Relevant Issues : https://github.com/karatelabs/karate/issues/1942
Relevant PRs : n/a
Type of change :

[ ] New feature
[x] Bug fix for existing feature
[ ] Code quality improvement
[ ] Addition or Improvement of tests
[ ] Addition or Improvement of documentation

@jkeys089 wow, does this fix the problem you reported and looks like you added a test to e2e - is that right ?

Can you also add your test case 14 in https://github.com/karatelabs/karate/blob/develop/karate-e2e-tests/src/test/java/driver/00.feature and uncomment 13?

@jkeys089 wow, does this fix the problem you reported and looks like you added a test to e2e - is that right ?

@ptrthomas yes -- took me a while to find the right solution but this fixes the issue. I hope it will help with the intermittent issues @joelpramos mentioned in https://github.com/karatelabs/karate/issues/1942#issuecomment-1066085593 but I can't say for sure since I wasn't able to reproduce locally.

Can you also add your test case 14 in https://github.com/karatelabs/karate/blob/develop/karate-e2e-tests/src/test/java/driver/00.feature and uncomment 13?

@joelpramos sure -- I've added the requested changes.

run has failed in CI though: https://github.com/karatelabs/karate/runs/5572090112

@jkeys089
can I suggest here that you still use the attach frame, conditionally? This is needed when iframes are external URLs (such as your case).
I.e. after the method call, something like you have in other places:
        if (frameSessions.containsKey(frameId)) {
            sessionId = frameSessions.get(frameId);
        } else {
            // attach to frame / target / process with the frame
           attachAndActivate(frameId, true);
        }

@joelpramos I'm not 100% clear how that would affect the result but I don't think it can hurt anything either. I've added it and will submit another PR. Thanks!


Cannot compile ripme inside a dockerfile for arm64

Greetings, I amtrying to build it for arm64 inside a docker, here is the docker file:
FROM gradle:jdk8-focal

WORKDIR /app
RUN git clone https://github.com/ripmeapp2/ripme.git
WORKDIR /app/ripme
RUN git checkout 2.1.3
RUN ./gradlew clean build -x test --warning-mode all
COPY build/libs/ripme.jar .

Ripme version: 2.1.3
Java version: jdk8-focal
Operating system: linux-arm64
docker builder log:

Sending build context to Docker daemon  8.192kB
Step 1/7 : FROM gradle:jdk8-focal
 ---> 98eb53c178c8
Step 2/7 : WORKDIR /app
 ---> Using cache
 ---> cb9035ae67d8
Step 3/7 : RUN git clone https://github.com/ripmeapp2/ripme.git
 ---> Using cache
 ---> bfac05e01f9b
Step 4/7 : WORKDIR /app/ripme
 ---> Using cache
 ---> 689b9b1786fc
Step 5/7 : RUN git checkout 2.1.3
 ---> Using cache
 ---> 3fb9a432a73c
Step 6/7 : RUN ./gradlew clean build -x test --warning-mode all
 ---> Running in 434c918e3718
Downloading https://services.gradle.org/distributions/gradle-7.5.1-bin.zip
...........10%............20%...........30%............40%...........50%............60%...........70%............80%...........90%............100%

Welcome to Gradle 7.5.1!

Here are the highlights of this release:
 - Support for Java 18
 - Support for building with Groovy 4
 - Much more responsive continuous builds
 - Improved diagnostics for dependency resolution

For more details see https://docs.gradle.org/7.5.1/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)
> Task :clean UP-TO-DATE
> Task :compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> invalid flag: --release

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 4m 47s
2 actionable tasks: 1 executed, 1 up-to-date
The command '/bin/sh -c ./gradlew clean build -x test --warning-mode all' returned a non-zero code: 1
Unable to find image 'build-ripme:latest' locally
docker: Error response from daemon: pull access denied for build-ripme, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
See 'docker run --help'.
Sending build context to Docker daemon  8.192kB

Expected Behavior
ripme is compiling then moved outside the container to be used
Actual Behavior
ripme is not compiling, check the logs

please use a never java, jdk8 is already died out.


Optimised datastructure for HyParView “views”

#106 introduced HashSet instead of Set as the datastructure holding the “views” of the network from the POV of one node. The motivation was mainly the node identity type n needs to carry information about the (last known) network address of a peer, in order to be able to reconnect to it. Imposing an Ord constraint on n seemed at least contrived.
One issue now is that HashSets don’t track their size, making size O(n) (as opposed to O(1) for Set); see tibbe/unordered-containers#138. It‘s not a big problem, since the number of elements stored is fairly small, but less than optimal because size is used a lot.
Another not-so-nicety is that HashSet doesn’t have an indexing function (a la elemAt), requiring conversion to a list in order to select a random element (again occurs often in the algorithm).
Two approaches come to mind:

Wrap HashSet such that it’s size is tracked (could be tricky with updates), and a separate Vector or some such is maintained for the purpose of drawing random elements.
Use an IntMap underneath and explicitly convert from Hashable to Int (Achtung: collisions)

@kim Just realised that now we do have stm-containers >= 1 -- do you think we can crack on with this one, then?

@adinapoli-mndc I am wondering if what we come up with for #6 could influence the choice of datastructure here. E.g. some sort of priority queue / heap might make sense, so if we move to stm-containers now, we would have to retrofit that on top.

That's a valid concern -- better tackle #6 first, and then let it guide the choice of the data structure here.


Make GVRSceneObject.detachEyePointeeHolder thread-safe in respect to GVRPicker.findObjects

GVRSceneObject.detachEyePointeeHolder() nulls out the owner object without locking (I have an app that does that quite frequently). If this happens while GVRPicker.findObjects() is running it may try to use an EyePointeeHolder without owner.

Overall looks good to me.  I know the point is similar to lock a whole scene when detachEyePointeeHolder and findObjects happen. But this lock will actually lock all scenes we currently have, even though it will be a rare case that an app will synchronously update more than one scene at the same time. But anyway, as I am saying the case is rare. It is good to go at my sight.


MatplotlibDeprecationWarning: Passing parameters norm and vmin/vmax simultaneously is deprecated since 3.3 and will become an error two minor releases later. Please pass vmin/vmax directly to the norm when creating it.   linewidth=markeredgewidth)

MatplotlibDeprecationWarning: Passing parameters norm and vmin/vmax simultaneously is deprecated since 3.3 and will become an error two minor releases later. Please pass vmin/vmax directly to the norm when creating it.
linewidth=markeredgewidth)
How to solve it?

Fixed in ed6be40a85756f27c9d87dd9306360ba6928bcc0 and deployed as version 0.1.8.


Suggestion:Find a better way to resolve issues related to sails projects.

since this is the main repo of the sails project itself, How can we find a way for sails users to report issues related to the project rather than cluttering the main Repo?
Looking forward to your suggestions.

Hey, @Jopchumba, Thanks for the feedback!
We actually used to have our issues separated by project, but we found that having them scattered around GitHub like that made it more difficult for our team to be sure they were all being addressed. Since consolidating the issues for Sails' various projects into the main repo, we've had far more success staying on top of them.
We use labels to help ourselves and our contributors sort issues by project. If you have any suggestions for labels that might make it easier to search for what you need, we're open to ideas!


Email Address missing when Exporting CSV on events

Describe the bug
When exporting the CSV of people who bought tickets for our event, the email addresses are not included.
To Reproduce
Steps to reproduce the behavior:

Go to https://opencollective.com/sustainoss/events/sustainuk-2018-442ev#tickets
Click on EXPORT CSV
Open CSV (something like 201810-08-sustainoss-sustainuk-2018-442ev.csv)
See missing values (see 2nd screenshot)

Expected behavior
The email addresses should show up to import into MailChimp or whatever
Screenshots

Desktop (please complete the following information):

OS: macOS Mojave
Browser: Chrome
Version: 69.x

Smartphone (please complete the following information):

n/a

Taking over.


[Question ]Merge ts files from node_modules into dist package.

Type of Issue
[ ] Bug Report
[x ] Feature Request

Description
I'd like to embed node_modules' ts files into destination package.
How To Reproduce
Consider following application architecture:
src
----app
--------src
-----------sub-module
-----------------------sub.module.ts
-----------------------sub.component.ts
-----------------------sub.component.scss
-----------main.module.ts
-----------package.json
--------dist
node_modules
----external_ts_module
-----------------------external-component.ts

I want to extend my sub.component.ts using external-component.ts:
import {
  Component
} from '@angular/core';
import { ExternalComponent } from 'external_ts_module/external-component';

@Component({
  selector: 'sub-component',
  template: '
I'm subcomponent inherited from external-component
',
  styleUrls: ['./sub.component.scss']
})
export class SubComponent extends ExternalComponent {
}

package.json
{
  "$schema": "./node_modules/ng-packagr/package.schema.json",
  "name": "MY_PACKAGE",
  "version": "1.0.0",
  "ngPackage": {
    "lib": {
      "entryFile": "main.module.ts"
    }
  },
  "dependencies": {
    "external_ts_module": "1.0.0"
  }
}

I this scenario package compiles, but doesn't embedd external_ts_module in order to compile those files as well.
Expected Behaviour
Have u any ideas how to accomplish compilation with external ts files?
Version Information
$ node_modules/.bin/ng-packagr --version
ng-packagr:            2.1.0
@angular/compiler:     5.2.6
@angular/compiler-cli: 5.2.6
rollup:                0.55.5
tsickle:               0.27.2
typescript:            2.6.2

There are threadsand discussions on other github isuse trackers whether publishing *.ts sources in npm packages is a "good idea" or a "bad idea". The most common answer is that it's a bad idea as it has drawbacks and some tools don't even support loading *.ts sources from a node_modules folder afaik.

thanks @dherges for answering. Yeah, I totally understand common problem with that architecture. There are some prons as well (such as inheritance from *.ts).
So I guess the simplest way to achieve this, would be copying node_modules *.tss into main directory in prebuild time?


fix(sinks): fix metadata format

@EMQmyd Please follow the name convention as corrected by Shifan, thanks.


Revert "Test update (#7965)"

This reverts commit 0aab60192843361d66519e84a4c46543f5a3df7a.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Revert #7965

Can one of the admins verify this patch?


document.head.appendChild adding element to body

This logic executes correctly in a browser but rendertron is attaching the additional element to the body as opposed to the head

Closing as there has no been no additional information to work off here.


SAM-2914 - Auto submit job, logic reversed

4th times a charm?

Ok, let's see if this is the good one !!


Support JWS Payloads that are not JSON

Thanks for all the hard work on this project!
Currently json-jwt appears to only support JWS payloads which are valid JSON objects and trying to decode a JWS with a payload that is not a valid JSON object throws an exception.
e.g.
token = "eyJ6a..." # Truncated for readability. Encoded payload is not a valid JSON Obect.

decoded_token   = decoded_token = JSON::JWT.decode token, :skip_verification

Throws json-jwt-1.13.0/lib/json/jose.rb:68:in rescue in decode': Invalid JSON Format (JSON::JWT::InvalidFormat). This exception seems to be thrown when rescuing a JSON::ParserError which originates here:
https://github.com/nov/json-jwt/blob/a2b4c1599ef7c3604e214c46eadec9bfdb6e41a5/lib/json/jws.rb#L187
The JWS RFC defines the JWS Payload as:

The sequence of octets to be secured -- a.k.a. the message. The payload can contain an arbitrary sequence of octets.

and the example in Section 3.3 says that

(Note that the payload can be any content and need not be a representation of a JSON object.)

Any thoughts on this or the feasibility of supporting JWS payloads of any type?

Any updates on this?

I don't have any plans to support this pattern now.


Error classify a large number of imagelist

If in the next command give 5000 of the image list
Error comes out.
curl **. **. **. ** / models / images / classification / classify_many.json ..
..
Failed to connect to DIGITS
..
No problem if the 10 or so of the image. It seems to be timed out.
Is a workaround available?

Hello, the workaround is to provide a smaller image list. However if you are using the production server (digits-server) you might want to try adding a timeout= XX to /usr/share/digits/gunicorn_config.py. You can also try the development server (digits-devserver).

@shinfo001 , in addition to what @gheinrich suggested, can you try these two?  1. curl to port 34448 directly to skip nginx.  2. Add proxy_read_timeout 3600s; to two locations inside nginx.site.  That file can be in /etc/nginx/sites-enabled.  You can identify the one used by DIGITS from its content.
I guessed you might receive 504 gateway timeout when trying classifying 5000 images.  That's why I suggest the above tests.

Thank you for the advice.
Anyway, it could be resolved in a way that runs by dividing list file.
I'm going to go try the other way.

BTW, I did the above suggestions on Digits 4.0, after which I was able to extend the timeout period and was able to test a few thousand cases for inference, which worked.
However, I upgraded to 5.0, and running into the same problem.  I went ahead and altered the  /etc/nginx/sites-enabled file as indicated above, and used port :34448.  The only thing is that I couldn't locate the  "/usr/share/digits/gunicorn_config.py" file in 5.0 (assuming due to differences in 5.0).  As such I couldn't alter the timeout= XX in that file.  Anyone know how to modify the timeout in 5.0 to allow for inference on larger amount of cases?

hi,
@gheinrich  i have edited the gunicorn_config.py file and add the timeout option there. but it is showing Classification failed, see job log,( ERROR: error code 1).after that I undo the change, but still it showing the same error.InferenceError: Unable to load any image from file ''/usr/share/digits/digits/jobs/ here.As the file pointing here is not present in that directory.Please help

@gheinrich how to undo the change


chore: bump<EMAIL_ADDRESS>

Release Notes

closing in favour of https://github.com/FuelLabs/fuel-bridge/pull/359


Fix not deleting old events after reorg

This was discovered when a user reported an order that shows up as settled in the explorer even though the transaction link shows it reverted.
I tracked this down with our logs and found that the transaction was originally mined in block 13621398 which got replaced later. After the replacement no new events occurred for a while which triggered a bug in our event handling code causing the reverted event to never get deleted.
Test Plan
Can't easily test right now but maybe with a change to the traits here to make them mockable. Logic change is simple so I want to do that first because we will do it anyway and maybe then try to add the test in second PR.

Codecov Report

Merging #1400 (402ba18) into main (e634e5e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

:exclamation: Current head 402ba18 differs from pull request most recent head c66e2c0. Consider uploading reports for the commit c66e2c0 to get more accurate results

@@            Coverage Diff             @@
##             main    #1400      +/-   ##
==========================================
- Coverage   66.42%   66.40%   -0.03%
==========================================
  Files         147      147
  Lines       30229    30234       +5
==========================================
- Hits        20079    20076       -3
- Misses      10150    10158       +8

Nice detective work.


Remove Translations

This commit should "fix" this issue, while we don't have translations
https://github.com/headsortailsgames/androidexport/commit/6ffe17b0c5b511acf50cb9bf4cb8a83cf2e18e41


First version for VeriStand 2021

VeriStand Editor Plugins using gRPC Client
gRPC Data Server Custom Device
Large Data Operation Custom Device to demonstrate the usage of gRPC Client API in Custom Device
Example VeriStand project

Ready to merge


(PUP-7129) Use systemd service provider for Debian 9 (Strech)

Currently, the 'service' provider gets confused on a Debian 9 (stretch) (updated from Debian Jessie), when trying to restart services:

Notice: /Stage[main]/Base::Ssh/File[/etc/ssh/sshd_config]/content: content changed '{md5}6c77ef6f38ca76a455809562c7f0a9a7' to '{md5}2f0a7d2e3d7cf30c3ba9eeff6af29189'
Info: /Stage[main]/Base::Ssh/File[/etc/ssh/sshd_config]: Scheduling refresh of Service[sshd]
Debug: /Stage[main]/Base::Ssh/File[/etc/ssh/sshd_config]: The container Class[Base::Ssh] will propagate my refresh event
Debug: Executing: '/usr/sbin/service sshd status'
Debug: Executing: '/usr/sbin/service sshd status'
Debug: Servicesshd: Could not find sshd in /etc/init.d
Debug: Servicesshd: Could not find sshd.sh in /etc/init.d
Error: /Stage[main]/Base::Ssh/Service[sshd]: Failed to call refresh: Could not find init script for 'sshd'
Error: /Stage[main]/Base::Ssh/Service[sshd]: Could not find init script for 'sshd'
Debug: Prefetching parsed resources for ssh_authorized_key
Debug: Class[Base::Ssh]: The container Stage[main] will propagate my refresh event
Debug: Finishing transaction<PHONE_NUMBER>2280
Debug: Storing state
Debug: Stored state in 0.00 seconds
Notice: Applied catalog in 0.57 seconds

This will add Debian 9 as defaultfor the systemd service provider.

CLA signed by all contributors.

I added another commit, which also adds support for stretch/sid and next sid, buster.
It might also make sense to add support for */sid into facter itself, probably while converting codenames to version numbers, but I'm not sure whether a buster sid should simply show 10 in operatingsystemmajrelease. Any opinion on that?

This makes sense. I'm kind of in favor of leaving Facter as it is, normalizing every sid name to a future version number would make two places we have to keep in sync with Debian.

Okay, so lets keep facter as it is.
Let's hope this will find its way into debian until stretch is released ;-)

@MikaelSmith Is there anything that still needs to be done by me for this PR, or do I simply need to wait until it gets merged?

Thanks! I just lost track of it, the ping was helpful.

No problem. Thanks for the merge!


[CR-68] Various improvements on tpcc test to achieve optimal test result

Work item: https://cockroachlabs.atlassian.net/browse/CR-68
Release note: none

I am still running the test, may add additional processing rules for machine types that doesn't work well for current processing pipeline, will merge the change when all these rules are identified and defined.

Should include all changes / fixes to make tpcc a smooth run.
PTAL

TFTR!


Horizontal button stack overlaying each other

I don't know why this is happening I've tried clearing my browser cache and still but for some reason the buttons are overlaying each other when I add more than 2 and it looks like this. Please help.

type: custom:bubble-card
card_type: horizontal-buttons-stack
1_name: Davids Room
1_icon: hue:downstairs
1_entity: light.basement_lights
2_name: V/E Room
2_icon: hue:upstairs
2_entity: light.vally_esthers_room
3_name: Media
3_icon: mdi:music-circle
style: |
  ha-card {
    margin-bottom: 62px !important;

Have you tried going in edit mode since? Because when you are in this mode the size of the buttons is automatically calculated and saved in your cache, this is needed for the auto order feature. So indeed clearing your cache will always do that, but I will try to find a way to fix that.

Yea this screenshot was out of edit mode, I even made new button stack but it seems to always happen its very weird. Would love it resolved so I can use it!

I've just tried your code and you just need to add links to fix this. But thanks for finding this issue, I will add an error if no link is added.
This is working:
type: custom:bubble-card
card_type: horizontal-buttons-stack
1_name: Davids Room
1_icon: hue:downstairs
1_link: '#davids_room'
1_entity: light.basement_lights
2_name: V/E Room
2_icon: hue:upstairs
2_link: '#ve_room'
2_entity: light.vally_esthers_room
3_name: Media
3_icon: mdi:music-circle
3_link: '#media'
style: |
  ha-card {
    margin-bottom: 62px !important;
  }

Genius, that did indeed fix it!
Now is it possible to remove the black shadow/background with card mod btw? Thanks

Just add this, you don't even need card-mod :
styles: |
  .horizontal-buttons-stack::before {
    display: none !important;
  }


does it work with touch screeens?

@klausgreiner This package works by asking the OS for the user's last input. So it should work on any device or input type.


terragrunt: 0.59.6 -> 0.62.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/terragrunt/versions.
meta.description for terragrunt is: Thin wrapper for Terraform that supports locking for Terraform state and enforces best practices
meta.homepage for terragrunt is: https://terragrunt.gruntwork.io
meta.changelog for terragrunt is: https://github.com/gruntwork-io/terragrunt/releases/tag/v0.62.0
Updates performed

Golang update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.62.0 with grep in /nix/store/nj356ag8c3bwxpxk86ac9ajsi237xl71-terragrunt-0.62.0
found 0.62.0 in filename of file in /nix/store/nj356ag8c3bwxpxk86ac9ajsi237xl71-terragrunt-0.62.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

terragrunt

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/nj356ag8c3bwxpxk86ac9ajsi237xl71-terragrunt-0.62.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A terragrunt https://github.com/r-ryantm/nixpkgs/archive/4210454cfcaf592cf9206874f6772b1c7939ea00.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/4210454cfcaf592cf9206874f6772b1c7939ea00#terragrunt

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/nj356ag8c3bwxpxk86ac9ajsi237xl71-terragrunt-0.62.0
ls -la /nix/store/nj356ag8c3bwxpxk86ac9ajsi237xl71-terragrunt-0.62.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

terragrunt

Maintainer pings
cc @06kellyjac @qjoly @kashw2 for testing.

@NixOS/nixpkgs-merge-bot merge


[resolves #347] Clean up optional dependencies

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/249/
Test FAILed.

Retest this please

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/250/
Test PASSed.


Move ggml to submodule

This PR moves ggml into a submodule. This will make ggml easier to update. As a side bonus, ggml was updated to latest version.
In the future, if Q4_1_O format is merged upstream, we can even get rid of ggml fork!
Closes #25

For some reason, Q4_1_O became 25% faster. Yay, I guess!


Add dir attribute to the html tag, ltr/rtl.

Fixes #3726

Hypha has a sass function "opposite-direction" to handle ltr/rtl but that is an old way of doing it. You must also explicitly make use of it everywhere and that is not so now.
Much better is to replace all use of things like "margin-right" with "margin-inline-end", "padding-top" with "padding-block-start" etc. With these you get rtl support without doing anything, the browser just does the right thing.

Ah!  This will be great when hypha as a whole is set to an RTL language (and the localization file is created with all the translations).  We'll still need a solution when it has to do both simultaneously.  Something like #3293 would help with that.


Trigger publish job on release events

Use the release event from Github in order to trigger the publish action

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 90.285%

Files with Coverage Reduction
New Missed Lines
%

gnosis/eth/ethereum_client.py
1
86.74%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
3522

Relevant Lines:
3901

💛  - Coveralls


Undefined variable config in meta.blade.php file

I am getting this error when I include the meta.blade.php.
Or Am I including it in a wrong way? This is how I am doing it:
@include('modules.laravelpwa.meta') in my app.blade.php file. I get this error though
Undefined variable: config (View: C:\xampp\htdocs\queendom\resources\views\modules\laravelpwa\meta.blade.php) (View: C:\xampp\htdocs\queendom\resources\views\modules\laravelpwa\meta.blade.php) (View: C:\xampp\htdocs\queendom\resources\views\modules\laravelpwa\meta.blade.php)

hello @SIMONNABUKO, You must not include the template but just the directive @laravelPWA as bellow:
<html>
<head>
    <title>My Title</title>
    ...
    @laravelPWA
</head>
<body>
    ...
    My content
    ...
</body>
</html>


[BUG] Failed to update the advertising manifest microsoft.net.workload.mono.toolchain: Failed to validate package signing.

Getting the following when trying to update to version 9
Updated advertising manifest microsoft.net.sdk.maui.
Updated advertising manifest microsoft.net.sdk.tvos.
Failed to update the advertising manifest microsoft.net.workload.emscripten: Failed to validate package signing.
Verifying Microsoft.NET.Workload.Emscripten.Manifest-<IP_ADDRESS>.0.0-rtm.21514.1
error: NU3004: The package is not signed.
Package signature validation failed.
.
Failed to update the advertising manifest microsoft.net.workload.mono.toolchain: Failed to validate package signing.
Verifying Microsoft.NET.Workload.Mono.ToolChain.Manifest-<IP_ADDRESS>.0.0-rtm.21518.12
error: NU3004: The package is not signed.
Package signature validation failed.

Same here.
Failed to update the advertising manifest microsoft.net.sdk.macos: microsoft.net.sdk.macos.manifest-6.0.200 is not found in NuGet feeds https://api.nuget.org/v3/index.json"..

Same issue
Conflict between:

dotnet workload update
autofix in maui-check

Hi Team,
I am also getting the same error.

PS C:\WINDOWS\system32> dotnet workload install maui

Failed to update the advertising manifest microsoft.net.workload.emscripten: microsoft.net.workload.emscripten.manifest-6.0.200 is not found in NuGet feeds https://api.nuget.org/v3/index.json, C:\Program Files (x86)\Microsoft SDKs\NuGetPackages\, https://nugets.c4portal.com/v3/index.json, https://nugets.gamanet.com/v3/index.json"..
Updated advertising manifest microsoft.net.sdk.macos.
Updated advertising manifest microsoft.net.workload.mono.toolchain.
Updated advertising manifest microsoft.net.sdk.maccatalyst.
Updated advertising manifest microsoft.net.sdk.maui.
Updated advertising manifest microsoft.net.sdk.android.
Updated advertising manifest microsoft.net.sdk.ios.
Updated advertising manifest microsoft.net.sdk.tvos.
Installing pack Microsoft.Maui.Core.Ref.android version 6.0.200-preview.12.2516...
Workload installation failed. Rolling back installed packs...
Rolling back pack Microsoft.Maui.Core.Ref.android installation...
Workload installation failed: microsoft.maui.core.ref.android::6.0.200-preview.12.2516 is not found in NuGet feeds https://api.nuget.org/v3/index.json;C:\Program Files (x86)\Microsoft SDKs\NuGetPackages\;https://nugets.c4portal.com/v3/index.json;https://nugets.gamanet.com/v3/index.json".
Description:
  Install one or more workloads.

Usage:
  dotnet workload install [<WORKLOAD_ID>...] [options]

Arguments:
  <WORKLOAD_ID>  The NuGet package ID of the workload to install.

Options:
  --configfile <FILE>      The NuGet configuration file to use.
  -s, --source <SOURCE>    The NuGet package source to use during the restore. To specify multiple sources, repeat the
                           option.
  --skip-manifest-update   Skip updating the workload manifests.
  --include-previews       Allow prerelease workload manifests.
  --temp-dir <temp-dir>    Specify a temporary directory for this command to download and extract NuGet packages (must
                           be secure).
  --disable-parallel       Prevent restoring multiple projects in parallel.
  --ignore-failed-sources  Treat package source failures as warnings.
  --no-cache               Do not cache packages and http requests.
  --interactive            Allows the command to stop and wait for user input or action (for example to complete
                           authentication).
  -v, --verbosity <LEVEL>  Set the MSBuild verbosity level. Allowed values are q[uiet], m[inimal], n[ormal],
                           d[etailed], and diag[nostic].
  -?, -h, --help           Show command line help.

PS C:\WINDOWS\system32>

Same error here
dotnet workload install maui

Failed to update the advertising manifest microsoft.net.workload.emscripten: microsoft.net.workload.emscripten.manifest-6.0.200 is not found in NuGet feeds https://api.nuget.org/v3/index.json, C:\Program Files (x86)\Microsoft SDKs\NuGetPackages"..

Installation rollback failed: One or more errors occurred. (microsoft.maui.core.ref.maccatalyst.msi.x64::6.0.200-preview.14.2935 is not found in NuGet feeds https://api.nuget.org/v3/index.json;C:\Program Files (x86)\Microsoft SDKs\NuGetPackages".)
Workload installation failed: One or more errors occurred. (microsoft.maui.core.ref.maccatalyst.msi.x64::6.0.200-preview.14.2935 is not found in NuGet feeds https://api.nuget.org/v3/index.json;C:\Program Files (x86)\Microsoft SDKs\NuGetPackages".)

check your pending reboot, or open VS like Administrator


Simplifier cache: instead of (equation, term) -> cachevalue have equation -> term -> cachevalue

We didn't see any performance improvement, allocation seems to have increased a bit so we're going to close this.


Playback starts automatically for HLS streams.

For .m3u8 manifest files, even though [self.player play]; is not explicitly called when loading the source URL, video playback will start anyway, calling [self.player pause]; seems to yield no effect.
I am dispatching the source loading receiver call (with error block) to the main thread and this still does not help.
Is there anything I am forgetting to set before I load the source? Thanks!

This problem has been fixed, logic in class setters was spuriously triggering players.


Guarantee serial execution of simplified publish APIs

Prevents races that can occur between internally called getTrackPublication and publish.
Perhaps this can be improved to allow concurrent execution if source types are different.

Using AsyncChannel might be more solid:
https://github.com/apple/swift-async-algorithms/blob/main/Sources/AsyncAlgorithms/AsyncAlgorithms.docc/Guides/Channel.md


[Internationalization] Put all not translated texts here or wrong translations as well

Post Page
Shout button: In Language EN still has text in German Empfohlen
Screenshot

@Tirokk I hope you don't mind but I would like to close this. We have to do more code reviews and for the existing untranslated strings I would suggest to fix it along the way.


InventoryCreativeEvent

I just updated to the most recent version of the plugin, but I get this error when I apply an enchantment while in Creative mode: [Server thread/ERROR]: Could not pass event InventoryCreativeEvent to CrazyEnchantments v<IP_ADDRESS> org.bukkit.event.EventException 	at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot.jar:git-Spigot-c55900f-9856d8a] 	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-c55900f-9856d8a] 	at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot.jar:git-Spigot-c55900f-9856d8a] 	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot.jar:git-Spigot-c55900f-9856d8a] 	at net.minecraft.server.v1_10_R1.PlayerConnection.a(PlayerConnection.java:2001) [spigot.jar:git-Spigot-c55900f-9856d8a] 	at net.minecraft.server.v1_10_R1.PacketPlayInSetCreativeSlot.a(SourceFile:23) [spigot.jar:git-Spigot-c55900f-9856d8a] 	at net.minecraft.server.v1_10_R1.PacketPlayInSetCreativeSlot.a(SourceFile:9) [spigot.jar:git-Spigot-c55900f-9856d8a] 	at net.minecraft.server.v1_10_R1.PlayerConnectionUtils$1.run(SourceFile:13) [spigot.jar:git-Spigot-c55900f-9856d8a] 	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_111] 	at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_111] 	at net.minecraft.server.v1_10_R1.SystemUtils.a(SourceFile:45) [spigot.jar:git-Spigot-c55900f-9856d8a] 	at net.minecraft.server.v1_10_R1.MinecraftServer.D(MinecraftServer.java:733) [spigot.jar:git-Spigot-c55900f-9856d8a] 	at net.minecraft.server.v1_10_R1.DedicatedServer.D(DedicatedServer.java:399) [spigot.jar:git-Spigot-c55900f-9856d8a] 	at net.minecraft.server.v1_10_R1.MinecraftServer.C(MinecraftServer.java:672) [spigot.jar:git-Spigot-c55900f-9856d8a] 	at net.minecraft.server.v1_10_R1.MinecraftServer.run(MinecraftServer.java:571) [spigot.jar:git-Spigot-c55900f-9856d8a] 	at java.lang.Thread.run(Unknown Source) [?:1.8.0_111] Caused by: java.lang.NullPointerException 	at org.bukkit.ChatColor.translateAlternateColorCodes(ChatColor.java:324) ~[spigot.jar:git-Spigot-c55900f-9856d8a] 	at me.BadBones69.CrazyEnchantments.Methods.color(Methods.java:47) ~[?:?] 	at me.BadBones69.CrazyEnchantments.Controlers.ScrollControl.getTransmogScroll(ScrollControl.java:242) ~[?:?] 	at me.BadBones69.CrazyEnchantments.Controlers.ScrollControl.onScrollUse(ScrollControl.java:49) ~[?:?] 	at sun.reflect.GeneratedMethodAccessor38.invoke(Unknown Source) ~[?:?] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_111] 	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_111] 	at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot.jar:git-Spigot-c55900f-9856d8a] 	... 15 more [12:22:19]

Please read the update and add the new lines it tells you to.
https://www.spigotmc.org/resources/crazy-enchantments-new-gkitz.16470/update?update=137823

I tried adding in the lines but it still didn't work for me, here is my config (pre additons). Please could you help?
Thanks
-diamond_sword51

@diamond-sword51 You didn't add any of the new lines like it said to. Please next time read the change log and add the new lines.
https://hastebin.com/wozujewele.php

I had added the lines before but it just wouldn't reload via a server restart or the command so i posted the save pre-line addition so I was the same as this thread

@diamond-sword51 Did that fix it for you?

I get this error https://hastebin.com/qomotobizo.bash and here is config.yml: https://hastebin.com/axozoxusiy.php


Modified TabletGroupWatcher to use TabletMetadata

Replaced TabletStateChangeIterator with ManagerTabletInfoIterator which returns ManagerTabletInfo objects instead of TabletLocationState objects.

I have no issue renaming things. Let's get the changes fleshed out first, then we can rename.

I'm going to fix the failed build issue, and then merge this to elasticity so that we can continue to build off of it. There are two failing ITs IIRC, MergeStateIT and AssignLocationModeIT, we can fix them up later.


please don't replace opened file!

VSCode Version: Code 1.4.0 (6276dcb0ae497766056b4c09ea75be1d76a8b679, 2016-08-04T16:45:31.680Z)
OS Version: Windows_NT ia32 10.0.10586

Steps to Reproduce:
1.when i open new file in vscode,it always replace opened file.
2.it's very damnabl!i must modify opened file(insert space) then open a new file.
has some config can close the issues or is bug?

"workbench.editor.enablePreview": false

@bpasero Hi! how to format css file in vscode?

@aeschli do you know the answer?

@bpasero Glad you ask. There are several extension, amongst them the amazing https://marketplace.visualstudio.com/items?itemName=aeschli.vscode-css-formatter

@keyiis, or https://marketplace.visualstudio.com/items?itemName=mrmlnc.vscode-stylefmt :panda_face:


Don't unconditionally forward the authentication token

I found a problem while using clearance and I want to know your opinion on this before doing any PR. I see here that the authentication token received in the request is unconditionally forwarded in the response:
https://github.com/thoughtbot/clearance/blob/master/lib/clearance/rack_session.rb#L24
Since this behavior is in a middleware, it affects the application as a whole. If the application implements http caching in some endpoint, setting Cache-Control: public to allow for intermediary caches to do their job, this behavior will lead to leaked authentications.
This is unexpected from the developer point of view, since this happens even if the Clearance::Authentication module is not included anywhere in the controller stack. Not to mention a potential security issue.

This is being discussed in the related PR #753


hubble: Populate traffic direction for TraceTo{Lxc,Host,Stack} events

Where possible, we want to extract the TrafficDirection from a trace notification. This only seems possible for observation points for which we a) statically know the traffic direction and b) have connection tracking information available to filter out reply packages. TRACE_TO_{LXC,HOST,STACK} seem to be the only three observation points for which we can do that.
Pulling in the datapath team for a quick review as well to confirm that.
/cc @michi-covalent

test-me-please

Coverage increased (+0.02%) to 46.835% when pulling f60216cad4aaf1ab887fd8ba071029b1de4c78fd on pr/gandro/hubble-tracenotify-trafficdirection into 794f5b3dc2b5f7b4848b2461c5d11104527b2077 on master.

test-me-please


Add project#mobile_friendly

This lets the mobile app filter the projects listing to just projects that have been marked as mobile-friendly. This can be set by owners via the API since we don't want to have to manage this long-term.
Short term we probably will be setting this ourselves without any UI, we'll think about adding it to the project builder at some point.

@robinschaaf Once this merges/deploys you can add ?mobile_friendly=true to the API call fetching the projects.

Great - thanks!!

@zwolf Ready for review


Add National Institute of Technology, Kushiro College

College Website: https://www.kushiro-ct.ac.jp/
IT-related courses offered by National Institute of Technology, Kushiro College: Information Enginnering field (情報工学分野)
The document certifying that college owns kushiro.kosen-ac.jp: 2_MFA導入説明(Authenticator).pdf
The above PDF file explains to students how to set up multi-factor authentication in Office365. An example of a student's email address can be found on page 4.

@arumino-om Thank you for your patience while waiting for a review and processing your request. Pull request merged. Thank you!


Shopping Cart v1

This is a good first iteration.  Take a look at the comments and refactor.  Let me know if you have any questions.


Fallback Language Investigation

Check to see what the lift is to send a request for a language for the survey the backend has as a fallback from the front end. If it's too much to do this from the front end, then the backend can handle "falling back" from a non-existent survey langauge to English.

so Andy has this working, and will solve in #618.


fix: Change the getter for redirectCount

Related Issues
SITES-23134
Related PR: https://github.com/adobe/spacecat-content-scraper/pull/166

:tada: This PR is included in version 1.69.1 :tada:
The release is available on:

v1.69.1
GitHub release

Your semantic-release bot :package::rocket:


Add an OPENAI URL

can we add an openai URL?
I think this is very necessary for many people.

You can do this by selecting custom OpenAI provider from the settings menu and add the URL there.


Notifications on android are broken again m'dears. Very disappointing.

Describe the bug
Notifications on android are broken again m'dears.
To Reproduce
Try to use the android app ever.
Make sure every tiny part of the experience of using an app is configured properly, including disabling battery optimizations.
No notifications.
Expected behavior
Notifications.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional numbers
The number 345567

so i tried this locally and it works. it'd help if you gave me some information on what device and OS you're using

so i tried this locally and it works. it'd help if you gave me some information on what device and OS you're using

We tried it on a Pixel 3 XL with LineageOS and no GAPPS, then assuming that the lack of Google Play Services and its push feature was the problem we tried it on a Moto G 8 with its stock ROM fully upgraded. We also had someone try it on their Galaxy M53 5G, OS version unknown.
If it matters the first two are UK phones and the third one is a Brazilian phone.


Chapter1: image can not be loaded

I follow the code in chapter 1, but the image cannot be display with this path.

@Jerry4013, what path do you use ? Make user your image is located in src/main/resources/static/images folder.

@psprogis Hi, I have solved this problem by changing to another img and refresh my project in STS. Thank you!


parseDocumentPaths has internal protection, but is needed by parseDocumentRelationships

The comment for parseDocumentRelationships reads:

Return parsed path with a parsed relationships model for a document at given path. Use parseDocumentPaths first to get a string path to pass as an argument to this function.

However, parseDocumentPaths has a default access level of "internal", so you can't call it to get the paths.

Thanks @GoldenJoe, this is now fixed in master.


Supp 3933 fix documentation links in readme

Goal

Documentation links were outdated and lead to a 404 page.
Changeset

Changed links from
https://docs.bugsnag.com/build-integrations/gradle/
to
https://docs.bugsnag.com/build-integrations/android-gradle-plugin/
Testing

@lemnik Getting a failure in buildkite for the bundler gem install. Is this something I can fix?
 => ERROR [android-gradle-plugin-ci 29/49] RUN gem install bundler        13.1s


add types to the description of env vars

i.e.:
"description": "Check if databse support SSL connection"

should be
"description": "Boolean; enforce SSL connection to the database",

add to app.json > "check readme for information"


force TRANSPORT_LE for connectGatt on Android 5

This change fixes #110

LGTM. Thanks for this fix!


chore(merge): add new changes from v3

Description
Add new changes from v3 to v4 branch.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pending fixing Entra checks.