Feat/50699 loading state for provisioning policy

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/50699
PROPOSAL: -
Tests

Go to a workspace, enable Expensify Card in More Features
Go to Expensify Card, click Issue New Card, add a new bank account if you don't have any
Choose the bank account from the list
Verify that you see a loader with "Verifying bank account" title - refer to this comment
After successful verification you should see the Success screen
Repeat steps 1-3, choose the same bank account
Verify that loading screen is also shown
After loading you should see One more step screen.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to a workspace, enable Expensify Card in More Features
Go to Expensify Card, click Issue New Card, add a new bank account if you don't have any
Choose the bank account from the list
Verify that you see a loader with "Verifying bank account" title - refer to this comment
After successful verification you should see the Success screen
Clicking Got it button should redirect you to the issue new card flow
Repeat steps 1-3, choose the same bank account
Verify that loading screen is also shown
After loading you should see One more step screen
Clicking Go to Concierge should navigate to the Concierge chat

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

https://github.com/user-attachments/assets/d5c5300c-ecdd-458f-a01b-9704703bce02

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/b1a18b6d-3025-45fd-8d37-4a39128bfcbc
https://github.com/user-attachments/assets/c8afb1e9-b9de-4a86-8802-c962d5b781b4

MacOS: Desktop

https://github.com/user-attachments/assets/62a1a37e-6a7c-4794-be4f-3b9133e53d0f
https://github.com/user-attachments/assets/f936692a-7673-4090-8475-d99e14fbc3a5

I'm having a problem with building native (ios and android) but I don't want to block the review, I'll add recordings later, if necessary.

Screenshots look good to me from a design perspective 👍

@DylanDylann friendly bump 🙏🏻

I will try to complete my reviewing for these issues on Wed

Bug: After settling bank account on workspace A, create new workspace and go to bank account settlement page. Click on bank account, see that the API is triggered but the UI isn't changed
https://github.com/user-attachments/assets/e37852e0-5863-4f2f-a4ad-a67cc5421f02

@DylanDylann looking into this shortly

ok I was able to repro this - looks like for these cases workspaceAccountID is not properly updated (by the previous API call for enabling ECard)

and as we don't have a proper workspaceAccountID we cannot get the verification status right. It doesn't happen when you enable Ecard, do some other stuff and come back to choose an account or refresh the page.

that's a tough one - I thought that showing a loader when workspaceAccountID is 0 is a good idea but I've just got the second workspace that after a successful enablement the workspaceAccountID is not updated in the Onyx - so loading state is forever

but whatever the root cause of it - I think we shouldn't allow the user to start the flow by clicking "Issue New Card" when there's no workspaceAccountID
cc @mountiny

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/6add7828-091c-417f-ab9a-269c520fdc4b

Android: mWeb Chrome

https://github.com/user-attachments/assets/8f50b22b-3a3d-432f-b428-a849f40fbc68

iOS: Native

https://github.com/user-attachments/assets/96b2a674-1983-4a67-aaf3-c11e5d22ab7b

iOS: mWeb Safari
https://github.com/user-attachments/assets/add3d721-a3a1-457f-b214-8522d64629a5

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/63556ac3-b7b5-4995-8cac-f7eba9c5cf1a

MacOS: Desktop
https://github.com/user-attachments/assets/27d43ffc-86a8-4d44-a8e2-516b88d3c52e

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Question: Simulating SDR impulse response

Some SDRs have an impulse response such that the noise floor droops at the edges.
How can we simulate this?
So far i've passed the noise floor (generated using AWGN) through a firfilt object using a cutoff frequency of 0.9 and a filter of size 13, so has pretty slow rolloff.
Is this a sensible thing to do? Is this physically meaningful? Should i use an iirfilt instead? In which case, what are good parameters for the iirfilt (it seems to have way more configuration than firfilt). Is a windowed sinc filter even a good thing to use? Can we more accurately determine the impulse response of a typical SDR without doing tons of measurements?
Thanks!!!

Great question! I think it depends on what the SDR itself is doing. The shape of the roll-off might look similar between a FIR and IIR filter; however the group delay will absolutely be different. Lumped components (capacitors, inductors, etc.) have digital IIR equivalents, but many SDRs use a digital filter basically embedded in the ADC itself. If you can generate a known wide-band input into the SDR's receiver, it's not too difficult to determine its linear response. But, as you point out, this can be a pain to measure.
I think your best bed would be to use a FIR filter with a windowed sinc (bandwidth of 0.9 is probably sufficient).

Cheers. I will do that then.


Add CIFAR100 to built-in datasets

See this tutorial for more information.

@julianser This is your ticket.

Fixed by #124.


separate privacy sharing saves

Fixes #3441
The major change is that change-privacy-view and share-view are separated to two separate modals, because they now have separated flows for privacy vs. permission changes. The share-banner also changed to indicate the different sharing state for the map/dataset:

I'll add inline comments to explain some refactoring details.

Frontend tests were OK :+1: (details)

Please review @xavijam, since you probably want this merged before you start to deprecate the old dashboard stuff. cc @alonsogarciapablo since you changed the sharing view recently and there are some (minor) changes done to the view model, among other things, can probably use another set of :eyeglasses: for review just in case
cc @saleiva and @javierarce for :sparkles:
Deployed on staging ded02 (ETA 10 min from when you read this :))

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Looks really good!
I found something weird here:

You can see how "blablabla" was enabled, then I toggled "whole organization" twice, enable "blablabla" again, but then it doesn't seem to save changes...

@alonsogarciapablo should be fixed with https://github.com/CartoDB/cartodb/commit/0f6748a4e6899b1afe5a8fee7bbee7d2b4d1f367

Frontend tests were OK :+1: (details)

If we agree with the last change made by @viddo, ready to go! :)

Frontend tests were OK :+1: (details)


Disable Microsoft Office 2019 telemetry

Disable the following scheduled tasks responsible for scanning and uploading
user data to Microsoft.
Office ClickToRun Service Monitor: This task monitors the state of your
Microsoft Office ClickToRunSvc and sends crash and error logs to Microsoft.
OfficeTelemetryAgentLogOn2016: This task initiates Office Telemetry Agent,
which scans and uploads usage and error information for Office solutions when
a user logs on to the computer.
OfficeTelemetryAgentFallBack2016: This task initiates the background task for
Office Telemetry Agent, which scans and uploads usage and error information
for Office solutions.
Signed-off-by: Tomasz Wilczyński<EMAIL_ADDRESS>

Strictly speaking, Office is not a part of Windows, so I will definitely understand if you decide not to include the scripts related to it in Win10-Initial-Setup-Script. However, Office is used and installed together with Windows in many environments, and I believe that having their telemetry bound together will be useful for quite a large number of users.
Also, do not be misled by "2016" in the names, as these tasks are created by Office 2019 upon its installation.

I often use similar tweak (it also contains GPOs and it's Office 2013-2019 compatible). It's one of the tweaks in my separate library module designed as an extension for this project, but I haven't polished and released it yet, as I'm kinda waiting for version 4, so I wouldn't do things (i.e. adopting to project's conventions etc.) twice. :)
But if @Disassembler0 would say he's not gonna make it let's say in the next few months or even at all, I might look at it sooner.

Out of curiosity what is the status of the PR ?

@tomasz1986 Thanks for this awesome tweak 🙏🏿. Took a a while and googling before I found this PR. I integrated it in privacy.sexy, I'm also working on reverting toggle functionality once it's done I'll add way to enable it as well.
Btw I couldn't not find any well-maintained & open source tool dealing with applications on OS either and that's why I built privacy.sexy. Feel free to check out for more telemetry disabling for applications, and also I'm accepting PR refugees if anyone wants to contribute anything 😊

@tomasz1986 Thanks for this awesome tweak 🙏🏿. Took a a while and googling before I found this PR. I integrated it in privacy.sexy, I'm currently working on reverting toggle functionality once it's done I'll add way to enable it as well.
Btw I couldn't not find any well-maintained & open source tool dealing with applications on OS either and that's why I built privacy.sexy. Feel free to check out for more telemetry disabling for applications, and also I'm accepting PR refugees if anyone wants to contribute anything 😊


chore: update to reflect that codestar is now preferred for github sources

what

Updated docs and resource names to reflect the fact that Codestar connections are now AWS's preferred source option

why

To avoid giving users the impression that the older, slightly more risky option is the only one available for GitHub sources.

references

Closes #51

/test all

I don't think we should change the names of the resources as that would cause recreations of resources which breaks backwards compatibility.

backwards compatibility doesn't seem like it's much of a concern in other modules though? major changes to input vars on other cloudposse repos get the release labelled as a breaking change and put out with a minor version bump. eg: https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/releases/tag/0.57.0
these changes don't even change the input vars. it would trigger a rebuild yes, but it also wouldn't require code changes on the user's part.
since this is a permanent change in the way aws treats github repos going forward, i think that getting prepared for a move away from webhooks being the default would be good to do before it becomes a last minute thing.


Create CODEOWNERS

GH is complaining about this not being valid, the only thing I can suspect is that it is due to this being a forked repo? Suggest we try merging and we can back it out if it doesn't work


. notation keys in datafield don't work

{             text: 'Assignee Name',             dataField: 'assignee.combo_name'         }
I am reading data directly from the backend api. They keys in the JSON are as like they are in the sample above.
I tried it with a key that I had no intention of using and it worked fine. _id
These type of keys use to work in the original bootstrap table.
I know I could remap that keys myself, but I think a better solution would to not have to do that in the UI code if it can be avoided. I also can't control the way it is presented to me from the back end (external api).

@dstone1983 please follow the instruction to report a question or a bug.  demo work well.


Passphrase consideration docs [#263]

@initfortherekt this repo is not the place to discuss/document passphrase length tradeoffs. How about keeping the recovery.md but making the passphrase consideration doc a tweet that we link to in the recovery.md doc?


Grammar corrections

Removed not necessary words and added corrections to punctuation.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@thefrontendwizard, @fabiotp91, @marceloazambuja,@jefferson2z  Can one of you please QA this older PR?
There are many other older PRs like this one which need to be reviewed.  Just use the following filter on Github and you can see all of them.
is:pr is:open sort:created-asc label:"scope: guide" label:"language: Portuguese"
Thanks,

Thank you for contributing to the FreeCodeCamp Portuguese Translation.
With contributions like yours we can help millions of people learn to program in their native language.
Hope you continue to help us with more contributions!


Manpage fixes

Looks good, but please look at Creating a man page and make your changes in the iohyve.8.txt

Thanks, will do!

This is way too huge to implement all at once. If you'd prefer not to open separate PR's for each new change I can save your diff and go over the changes another time. I'd hate to see all that work go to waste.

I think the most important part of it is that [ -z $foo ] needs "" around the variable name. If you don't use "" and the variable is empty you get an error. That prevents a lot of errors when you run iohyve without the right amount of arguments.


Update fs2-io to 2.5.4

Updates co.fs2:fs2-io from 2.5.0 to 2.5.4.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2", artifactId = "fs2-io" } ]

labels: test-library-update, semver-patch

Superseded by #52.


git hooks using wrong Ruby when hub aliased to git

To reproduce
git clone deivid-rodriguez/byebug
cd byebug
gem install bundler
bundle install
bundle exec overcommit --install
sed -i '/enabled: false/d' .overcommit.yml
sed -i '/fast_finish/d' .travis.yml
git add .travis.yml
git commit

And I get
Running pre-commit hooks
Checking for trailing whitespace.................[TrailingWhitespace] OK
Checking Travis CI configuration.........................[TravisLint] FAILED
/home/davidr/.gem/ruby/2.2.1/gems/bundler-1.9.1/lib/bundler/spec_set.rb:92:in `block in materialize': Could not find rake-10.4.2 in any of the sources (Bundler::GemNotFound)
    from /home/davidr/.gem/ruby/2.2.1/gems/bundler-1.9.1/lib/bundler/spec_set.rb:85:in `map!'
    from /home/davidr/.gem/ruby/2.2.1/gems/bundler-1.9.1/lib/bundler/spec_set.rb:85:in `materialize'
    from /home/davidr/.gem/ruby/2.2.1/gems/bundler-1.9.1/lib/bundler/definition.rb:132:in `specs'
    from /home/davidr/.gem/ruby/2.2.1/gems/bundler-1.9.1/lib/bundler/definition.rb:177:in `specs_for'
    from /home/davidr/.gem/ruby/2.2.1/gems/bundler-1.9.1/lib/bundler/definition.rb:166:in `requested_specs'
    from /home/davidr/.gem/ruby/2.2.1/gems/bundler-1.9.1/lib/bundler/environment.rb:18:in `requested_specs'
    from /home/davidr/.gem/ruby/2.2.1/gems/bundler-1.9.1/lib/bundler/runtime.rb:13:in `setup'
    from /home/davidr/.gem/ruby/2.2.1/gems/bundler-1.9.1/lib/bundler.rb:122:in `setup'
    from /home/davidr/.gem/ruby/2.2.1/gems/bundler-1.9.1/lib/bundler/setup.rb:18:in `<top (required)>'
    from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    Checking YAML syntax.....................................[YamlSyntax] OK

If I disable the hub -> git alias, it works fine.
I've reproduced this with both chruby and rvm.
Thanks!!
Originally reported to overcommit but I don't think the issue belongs there.

How did you install hub? Check its shebang:
file `which hub` | grep text && head -1 `which hub`

I installed it with brew install hub, but with brew provided by linuxbrew. This is the output of your command.
$ file `which hub` | grep text && head -1 `which hub`
$ file `which hub`
/home/davidr/.linuxbrew/bin/hub: symbolic link to `../Cellar/hub/2.2.0/bin/hub'
$ file ~/.linuxbrew/Cellar/hub/2.2.0/bin/hub | grep text
$ file ~/.linuxbrew/Cellar/hub/2.2.0/bin/hub
/home/davidr/.linuxbrew/Cellar/hub/2.2.0/bin/hub: ELF 64-bit LSB  executable, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), not stripped

If I uninstall it and reinstall using the https://github.com/github/hub#standalone method, I get basically the same thing.
$ file `which hub` | grep text && head -1 `which hub`
$ file `which hub`
/usr/local/bin/hub: ELF 64-bit LSB  executable, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), not stripped

Thanks for your help!

OK, so it's latest Go hub on Linux. Good to know.
Which Ruby version did you expect to get activated instead of 2.2.1? Are you using chruby or rvm, or both at the same time (not sure if that's even possible)? When using chruby, I trust that the desired version of Ruby is pushed onto PATH automatically when you enter a directory, right? Are you saying that running git hooks through hub (aliased as git) somehow manage to pick a version that is not on current PATH?

Which Ruby version did you expect to get activated instead of 2.2.1?

I actually expected 2.2.1 but it seems system's Ruby (1.9), look at the first two lines of the backtrace.

Are you using chruby or rvm, or both at the same time (not sure if that's even possible)?

I was using rvm. Then I removed rvm and installed chruby to see if it was related to the version manager but I got the same results.

When using chruby, I trust that the desired version of Ruby is pushed onto PATH automatically when you enter a directory, right? Are you saying that running git hooks through hub (aliased as git) somehow manage to pick a version that is not on current PATH?

Not sure how chruby works internally...
Can you reproduce the bug yourself of this is something with my environment?
Thanks.

@mislav Not sure if it's relevant but this happens with all hooks overcommit installs, which is actually a single one (all hook types are symlinked to it)  and starts with the shebang:
#!/usr/bin/env ruby

Can you reproduce the bug yourself of this is something with my environment?

I will try.

Thanks! I found an easier reproduction (independent from overcommit). The following assumes you're currently not using 1.9.3 and your system Ruby is 1.9.3
$ mkdir hub_issue_855
$ cd hub_issue_855
$ git init
$ echo '#!/usr/bin/env ruby' > .git/hooks/pre-commit
$ echo 'fail("Oops") if RUBY_VERSION == "1.9.3"' >> .git/hooks/pre-commit
$ chmod +x .git/hooks/pre-commit
$ echo "First readme" > README.txt
$ git add .
$ git commit
.git/hooks/pre-commit:2:in `<main>': Oops (RuntimeError)

@mislav Did you have time to have a look or reproduce this? Thanks!

I can't reproduce using rbenv. Git hooks behave the same regardless of whether git is running hub or plain git.

Can't reproduce using latest chruby either. In order to support RVM in hooks, you can configure their shebang to run them through an RVM wrapper script. I have no idea why you get different results going through hub.

Me neither... :disappointed: Did you try it in linux?
I'll try to setup a fresh VM and see what happens. I'll post my results when I do.

Hi again @mislav, I got some time to investigate this.
This is certainly not a bug in hub, but a bug in git in my opinion. The problem is that, when called with an absolute path (/usr/bin/git),  git prepends /usr/bin to the path. I can't think of any good reason why git would do that and I'm assuming it's not intentional. So I'll report it as an issue to git and see what they say.
hub actually calls git with an absolute path because syscall.exec requires an absolute path to be passed in. In Windows systems, hub uses spawn when delegating execution to git, so there the bug is not reproduced. I actually fixed my problem by forcing hub to use always spawn:
diff --git a/cmd/cmd.go b/cmd/cmd.go
index 55e7b8c..ebe229b 100644
--- a/cmd/cmd.go
+++ b/cmd/cmd.go
@@ -4,9 +4,7 @@ import (
        "fmt"
        "os"
        "os/exec"
-       "runtime"
        "strings"
-       "syscall"

        "github.com/github/hub/Godeps/_workspace/src/github.com/kballard/go-shellquote"
        "github.com/github/hub/utils"
@@ -41,16 +39,6 @@ func (cmd *Cmd) CombinedOutput() (string, error) {
        return string(output), err
 }

-// Run runs command with `Exec` on platforms except Windows
-// which only supports `Spawn`
-func (cmd *Cmd) Run() error {
-       if runtime.GOOS == "windows" {
-               return cmd.Spawn()
-       } else {
-               return cmd.Exec()
-       }
-}
-
 // Spawn runs command with spawn(3)
 func (cmd *Cmd) Spawn() error {
        c := exec.Command(cmd.Name, cmd.Args...)
@@ -61,20 +49,6 @@ func (cmd *Cmd) Spawn() error {
        return c.Run()
 }

-// Exec runs command with exec(3)
-// Note that Windows doesn't support exec(3): http://golang.org/src/pkg/syscall/exec_windows.go#L339
-func (cmd *Cmd) Exec() error {
-       binary, err := exec.LookPath(cmd.Name)
-       if err != nil {
-               return fmt.Errorf("command not found: %s", cmd.Name)
-       }
-
-       args := []string{binary}
-       args = append(args, cmd.Args...)
-
-       return syscall.Exec(binary, args, os.Environ())
-}
-
 func New(cmd string) *Cmd {
        cmds, err := shellquote.Split(cmd)
        utils.Check(err)
diff --git a/commands/runner.go b/commands/runner.go
index f449413..27f8c4d 100644
--- a/commands/runner.go
+++ b/commands/runner.go
@@ -112,14 +112,9 @@ func printCommands(cmds []*cmd.Cmd) {
 }

 func executeCommands(cmds []*cmd.Cmd) error {
-       for i, c := range cmds {
+       for _, c := range cmds {
                var err error
-               // Run with `Exec` for the last command in chain
-               if i == len(cmds)-1 {
-                       err = c.Run()
-               } else {
-                       err = c.Spawn()
-               }
+               err = c.Spawn()

                if err != nil {
                        return err
diff --git a/git/git.go b/git/git.go
index 51ebe3d..7e52ffd 100644
--- a/git/git.go
+++ b/git/git.go
@@ -206,7 +206,7 @@ func Run(command string, args ...string) error {
                cmd.WithArg(a)
        }

-       return cmd.Run()
+       return cmd.Spawn()
 }

 func gitOutput(input ...string) (outputs []string, err error) {

This has been causing issues with git hooks implemented in Ruby for a while. See https://github.com/sstephenson/rbenv/issues/374, for example.

Thanks for the diff above about changing Exec to Spawn, but I don't get how it fixes things. How does /usr/bin/git know whether it has been called with an absolute path or not?

The use of Exec instead of Spawn where possible is to fix pagination issue in #708.

Thanks for the diff above about changing Exec to Spawn, but I don't get how it fixes things. How does /usr/bin/git know whether it has been called with an absolute path or not?

You are welcome. I just added the patch for reference, it's not meant to be merged. I'm sure (and @jingweno confirmed) there's good reasons to prefer Exec when available.
I guess git parses argv[0] to know that, but reading the source code or asking some familiarized with it will better answer that question.
As I said, I'll open an issue in git and get back here when I have answers.

It seems that this will be fixed in git in the next major version. Closing.

Thanks for the investigation!

No problem! :smiley:

For completeness, the fix for this has been merged into git's master and, I guess, will be released with git 2.5.0.


CLI

What's your ideas on adding a command-line interface for Shipwright?
The initial thoughts on it is a command-line interface (like shp), which provides access to all resources provided by the operator, and provides easy means to consume those resources and create automation for them.
We should be inspired by the upstream examples like tkn, oc and kubectl, and we should keep in mind the plugins use-case, where our new CLI could dub as a plugin or as a standalone binary.

I prefer plugin way, there are too much command lines for end-user. :)

I prefer plugin way, there are too much command lines for end-user. :)

Obligatory "why not both?" meme [1]. The Krew project provides an easy way for us to package and distribute CLIs as a kubectl plugin [2]. We do not have to name our command line kubectl-xxx - the Krew manifests system takes care of symlinking across platforms [3].
The shorthand shp may run afoul of their naming practices [4]. I will reach out to sig-cli to see if this is acceptable.
[1] https://media.giphy.com/media/3ohfFhG5VDtDTzQv2o/giphy.gif
[2] https://krew.sigs.k8s.io/
[3] https://krew.sigs.k8s.io/docs/developer-guide/plugin-manifest/
[4] https://krew.sigs.k8s.io/docs/developer-guide/develop/naming-guide/

Update from the Krew community - shp/kubectl-shp is acceptable.


text too narrow in firefox

https://webpack.js.org/plugins/mini-css-extract-plugin/

There is a <div class="gitter"> which takes up lots of space

seems to be fixed now

seems to be fixed now

I still see this in Firefox 84.  The layout fixes if I hard-reload the page.

I still see this in Firefox 84.  The layout fixes if I hard-reload the page.


Add new supported SIXAXIS names

The name PLAYSTATION(R)3Controller-ghic (without the spelling mistake) is also out there in the wild and works, add to INF in next update.

Add Sony PLAYSTATION(R)3 Controller (reported by Bilious on Discord).


Update for uframe changes

@DanielJMaher @oceanzus changes for the uframe ...76 port, also fixed the new_end_time i didnt see it?
the https://github.com/asascience-open/ooi-ui-services/commit/c8c9ebca2342873aaaf0d91308055e37087e95a2 change, ignores the last row of data as it contains some content we dont need, and now we are using pk>stream as stream name is not available on the ...76 port version...

@DanielJMaher @oceanzus can we close this then?

@DanielJMaher bump

@DanielJMaher going to close this as we dont need it now


Add unit tests for sandboxes

What problem or use case are you trying to solve?
I found DockerSSHBox does not work well with multi-line commands, we should add unit tests to cover these cases.
Describe the UX of the solution you'd like
tests/unit/test_sandbox.py
Do you have thoughts on the technical implementation?
Adding tests is pretty straight forward, but we should better handle how to starts each unit test with the correct config (i.e., correct UID, correct workspace to mount to, etc).
Describe alternatives you've considered
Additional context

We have unit tests now! Thanks Xingyao!


Unobserved exception

Broker: Mosquitto v1.4.14
MQTTnet: v2.6.0
Both the connection and server are stable but exceptions like these happen alot.

 System.AggregateException: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. ---> MQTTnet.Exceptions.MqttCommunicationTimedOutException: Exception of type 'MQTTnet.Exceptions.MqttCommunicationTimedOutException' was thrown.

   at MQTTnet.Internal.TaskExtensions.<TimeoutAfter>d__1`1.MoveNext()

--- End of stack trace from previous location where exception was thrown ---

   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)

   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

   at MQTTnet.Client.MqttPacketDispatcher.<WaitForPacketAsync>d__4.MoveNext()

   --- End of inner exception stack trace ---

   at System.Threading.Tasks.TaskExceptionHolder.Finalize()

---> (Inner Exception #0) MQTTnet.Exceptions.MqttCommunicationTimedOutException: Exception of type 'MQTTnet.Exceptions.MqttCommunicationTimedOutException' was thrown.

   at MQTTnet.Internal.TaskExtensions.<TimeoutAfter>d__1`1.MoveNext()

--- End of stack trace from previous location where exception was thrown ---

   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)

   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

   at MQTTnet.Client.MqttPacketDispatcher.<WaitForPacketAsync>d__4.MoveNext()<---

Hi,
please test this again with version 2.7.3. Several connection handling issues are fixed in this version.
Best regards
Christian

Will do, thanks for the effort.

   at MQTTnet.Internal.TaskExtensions.<TimeoutAfter>d__1`1.MoveNext()

--- End of stack trace from previous location where exception was thrown ---

   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()

   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

   at MQTTnet.Client.MqttPacketDispatcher.<WaitForPacketAsync>d__3.MoveNext()

   --- End of inner exception stack trace ---

   at System.Threading.Tasks.TaskExceptionHolder.Finalize()

---> (Inner Exception #0) MQTTnet.Exceptions.MqttCommunicationTimedOutException: Exception of type 'MQTTnet.Exceptions.MqttCommunicationTimedOutException' was thrown.

   at MQTTnet.Internal.TaskExtensions.<TimeoutAfter>d__1`1.MoveNext()

--- End of stack trace from previous location where exception was thrown ---

   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()

   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

   at MQTTnet.Client.MqttPacketDispatcher.<WaitForPacketAsync>d__3.MoveNext()<---```

I have it boiled down fairly consistent reproducable situation in VS2017, I could remove the dll and load the source if that would help.

Yes please provide some more details. Do you have a snipped which causes this issue? I need to test this on my own machine.

 System.AggregateException: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. ---> MQTTnet.Exceptions.MqttCommunicationTimedOutException: Exception of type 'MQTTnet.Exceptions.MqttCommunicationTimedOutException' was thrown.

   at MQTTnet.Internal.TaskExtensions.<TimeoutAfter>d__1`1.MoveNext() in X:\FYN Retail\ClassLibrary1\Internal\TaskExtensions.cs:line 56

--- End of stack trace from previous location where exception was thrown ---

   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)

   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()

   at MQTTnet.Client.MqttPacketDispatcher.<WaitForPacketAsync>d__3.MoveNext() in X:\FYN Retail\ClassLibrary1\Client\MqttPacketDispatcher.cs:line 31

   --- End of inner exception stack trace ---

   at System.Threading.Tasks.TaskExceptionHolder.Finalize()

---> (Inner Exception #0) MQTTnet.Exceptions.MqttCommunicationTimedOutException: Exception of type 'MQTTnet.Exceptions.MqttCommunicationTimedOutException' was thrown.

   at MQTTnet.Internal.TaskExtensions.<TimeoutAfter>d__1`1.MoveNext() in X:\FYN Retail\ClassLibrary1\Internal\TaskExtensions.cs:line 56

--- End of stack trace from previous location where exception was thrown ---

   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)

   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()

   at MQTTnet.Client.MqttPacketDispatcher.<WaitForPacketAsync>d__3.MoveNext() in X:\FYN Retail\ClassLibrary1\Client\MqttPacketDispatcher.cs:line 31<---

Recently a new exception has started appearing:

There are no context policies.

 System.AggregateException: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. ---> System.InvalidOperationException: An attempt was made to transition a task to a final state when it had already completed.

   at System.Threading.Tasks.TaskCompletionSource`1.SetResult(TResult result)

   at MQTTnet.Client.MqttPacketDispatcher.<>c__DisplayClass2_0.<Dispatch>b__0()

   at System.Threading.Tasks.Task.InnerInvoke()

   at System.Threading.Tasks.Task.Execute()

   --- End of inner exception stack trace ---

   at System.Threading.Tasks.TaskExceptionHolder.Finalize()

---> (Inner Exception #0) System.InvalidOperationException: An attempt was made to transition a task to a final state when it had already completed.

   at System.Threading.Tasks.TaskCompletionSource`1.SetResult(TResult result)

   at MQTTnet.Client.MqttPacketDispatcher.<>c__DisplayClass2_0.<Dispatch>b__0()

   at System.Threading.Tasks.Task.InnerInvoke()

   at System.Threading.Tasks.Task.Execute()<---

It seems that the whole of Client\MqttPacketDispatcher.cs is missing the proper task exception handling, the latest patches in develop branch made things much worse for this problem.
Also why is "awaiter.SetResult(packet);" called twice, once within the Task.Run on line 36 and once on line 35.
@chkr1011 please let me know if I can help run some tests, this bug is really starting to annoy me.

Probably fixed with the latests commits in development, thanks for the effort.


Show the correct amount of items when navigating to previous page

I have a Slider with 21 Items and show 6 slides per page. When navigating to a previous Page initially only 3 items are displayed. Because finalSlide becomes 18 and not 15 like it should be.

I can't find the reason this extra clause existed in the slideHandle function, I have tracked it back via git blame to this commit https://github.com/akiran/react-slick/commit/86b721896f1edbcac3c602fb6c28caf9047670c2 But there isn't much explanation why.
With this change the correct amount of items are displayed.

This isn't done. I have noticed a bug after 4 page switches, the animation glitches out and the items rapidly change after switching the page. Will come back later


Add Link to Release History

It's a minor detail, but I didn't find any reference to the release history in the repository.

That's a helpful change, especially as the most recent version mentioned in "RELEASE-NOTE.md" is 2.11.0, from 2018.

@KristjanESPERANTO, thanks for the contribution! This update needs to go into announcement.vm in release-2.x branch.

Hrm... I will do it myself. :+1:

When will the changes be transferred from the release-2.x branch to the master branch?
The RELEASE-NOTES.md in the master branch is still outdated.

When will the changes be transferred from the release-2.x branch to the master branch?

Never, since every release will have its own content.

Then you will never find a reference to the current release notes in the master branch. If that's the way you want it, I don't understand it, but that's okay too :slightly_smiling_face:
Thank you very much for your patience and your work on log4j! 🎆

I see your point @KristjanESPERANTO, maybe we should set the default branch to release-2.x. I guess this addresses your concern, right?

Yes, that would address my point. The master branch is now the entry point for people who want to start dealing with the code. Since I can also see current changes this branch, it seems a bit inconsistent to find old release notes in there.
I have no idea about best practice, I'm just trying to give some feedback here :-)


intelliJ cli support

Adding IntelliJ cli support.

Codecov Report

Merging #57 (7fcff89) into main (1438e2e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   35.74%   35.74%
=======================================
  Files          23       23
  Lines         831      831
=======================================
  Hits          297      297
  Misses        506      506
  Partials       28       28

Impacted Files
Coverage Δ

cmd/validators.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1438e2e...7fcff89. Read the comment docs.


chore: zeebe-operator to 0.0.19

chore: Promote zeebe-operator to version 0.0.19

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Allow multiple prompts to be supplied via --input-file to GenAI-Perf

Allow multiple prompts to be passed in via --input-file as a JSONL file. Each one should be on a separate JSON object (on a new line) with the field "text_input".

Has this been tested in conjunction with multi LoRA?
Is it possible to add a test to ensure that functionality behaves the way we expect with this new feature?
Also, great job on this! You turned it around quickly.

Has this been tested in conjunction with multi LoRA? Is it possible to add a test to ensure that functionality behaves the way we expect with this new feature?
Also, great job on this! You turned it around quickly.

Thanks, Elias! The multi-LoRA fix is a separate ticket (TPA-132) that Ganesh said you had committed to for this week. If not, I can do take it on but as a separate PR. This isn't going to fix multi-LORA/multi-model with an input file. It'll generate multiple prompts for the first model, but I don't think that's a behavior worth testing. If it's okay with you, let's leave that change to its own PR that tests for correct behavior (the multiple payloads are generated for each model).

Has this been tested in conjunction with multi LoRA? Is it possible to add a test to ensure that functionality behaves the way we expect with this new feature?
Also, great job on this! You turned it around quickly.

Thanks, Elias! The multi-LoRA fix is a separate ticket (TPA-132) that Ganesh said you had committed to for this week. If not, I can do take it on but as a separate PR. This isn't going to fix multi-LORA/multi-model with an input file. It'll generate multiple prompts for the first model, but I don't think that's a behavior worth testing. If it's okay with you, let's leave that change to its own PR that tests for correct behavior (the multiple payloads are generated for each model).

I am happy to leave this as is. Great work.
For context, my thought around the multi lora functionality not working with the input file was due to not allowing more than 1 prompt. I suspect you fixed it already which was why I wanted to check.
Lets leave this as is, and maybe we have an easy ticket when we check later.


Grammar and simplified explanation with examples

Fixed the grammar in a few places and added a simplified explanation with examples

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi @Pergamon256 . Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


[docs] Update the Xcode page.

Removed a misleading note, saying that the library needs to be built from source if using coroutines.
Documentation change checklist

[x] My documentation changes follow the docs style guide and any code examples follow the coding style guide.
[x] I tested that my change works before raising the PR (via running doxygen, and testing examples).
[x] I have not moved any existing pages or changed any existing URLs without strong justification as to why.
[x] I have not generated content using AI or a desktop utility such as grammarly.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Folo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Right, sorry, I didn't have my email set in git and now it can't get the CLA signed.  I will open a new pull request, this time with the email.

No worries! Take your time :)


Questions about broker

Broker is not a process or a pod. What is it? How to understand its implementation more commonly?

Please refer to the architecture documentation.


Adding verbiage about chaining AppGW and AzFW

Adding verbiage about chaining AppGW and AzFW

@JackStromberg : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Update cctalk to 0.8.1-223,2017-05-17.21.49

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

@gobinathm The sha256 appears to have changed:
==> Downloading http://f1.ct.hjfile.cn/api/AutoUpdate/newupdate/out/mac/cctalk/archive/<IP_ADDRESS>/CCtalk-0.8.1-223-hujiang-2017-05-17.21.49.dmg
######################################################################## 100.0%
==> Verifying checksum for Cask cctalk
==> Note: running "brew update" may fix sha256 checksum errors
audit for cctalk: failed
 - download not possible: sha256 mismatch
Expected: 638bcee0c4b983969db1efa79b94e8e623a90fc8c91ff62f627b47853c7f49a9
Actual: cb57ea0dd82ced44c006eceaee8979784c532650248a91ff3cd14ba2730eb579
File: /Volumes/GTM-USBX/Cask/cctalk--0.8.1-223,2017-05-17.21.49.dmg
To retry an incomplete download, remove the file above.

 - appcast checkpoint mismatch
Expected: 44e6ba955040ae82c895f41f47c29146f3bf191f50b3904f27d0de12260626ee
Actual: 5af68358c49fcb4be9db0f185dc174d8c09beac13ca710d8141cafaf6162de70
Error: audit failed for casks: cctalk

@giannitm  Yes those are changed and it updates. Travis passed the checks too.


Feature/upgrade to net60

Closes #6

Codecov Report

Merging #9 (0038147) into main (d63b682) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   54.68%   54.68%
=======================================
  Files           3        3
  Lines         256      256
=======================================
  Hits          140      140
  Misses        116      116

Flag
Coverage Δ

unittests
54.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63b682...0038147. Read the comment docs.


Added 'rCSSmin' filter

Hi,
I added a filter for rCSSmin, this is related to #424.

Thanks!

No, thanks to you for webassets ;)


gvim spamming console from which it was started

So many repetitions of this they literally fill my 2xHD-height terminal window:
(gvim:600): Gtk-WARNING **: GtkNotebook 0x55923d87f190 is mapped but visible child GtkEventBox 0x55923d8841c0 is not mapped

I often invoke gvim from the command line and leave the process running for an extended period of time, and I do this many times over.  Unfortunately, due to this console spam, this effectively leaves my terminal useless.  So even though I have the file of interest right at my fingertips in the terminal, I jump through hoops to run gvim from some other context, if I want to continue using that terminal.  I love you vim but this is an unacceptable CLI.

These messages may be useful (e.g. for debugging purposes), so rather than killing them altogether (by invoking gvim as gvim > /dev/null on Unix-like or as gvim > NUL on Windows) I'd rather log them (by invoking gvim as (date; gvim || echo 'exit status' $? ; date) >> gvim.log on Unix-like and something similar, perhaps less fancy if CMD.EXE isn't as powerful as bash, on Windows).
A simple way to "run gvim from some other context" is to launch it from a desktop icon. If you don't already have one, making one takes 5 minutes once and for all, or 10 if you haven't yet made shortcut icons: I'd hardly call this "jumping through hoops".
Best regards,
Tony.

Thank you Tony for your constructive feedback.  I'm not interested in logging the messages, and I'm simply not willing to add in > /dev/null every single time I just want to type gvim filename, which is something I do many, many times a day.
Debugging messages should be disabled for end users.  In low volume I could see them being useful, but I'm pretty sure this constitutes spam:

Thanks again Tony.
I do use the equivalent of alt+f2 (win/meta+r on my system). But it's still annoying.
Having to gather the target filename in my terminal is probably the biggest hoop to jump through, bigger than how gvim is launched.
This is a terrible distraction from my terminal flow, and a disappointing command line user experience from vim.

On 2018-11-21, F. Eugene Aumson wrote:

Thanks again Tony.
I do use the equivalent of alt+f2 (win/meta+r on my system). But it's still
annoying.
Having to gather the target filename in my terminal is probably the biggest
hoop to jump through, bigger than how gvim is launched.
This is a terrible distraction from my terminal flow, and a disappointing
command line user experience from vim.

A simple workaround would be to put this in your ~/.bashrc (assuming
your shell is bash):
alias gvim='&>/dev/null gvim'

HTH,
Gary

Similar issues: #1149, #1328, #2543

Having to gather the target filename in my terminal is probably the biggest hoop to jump through, bigger than how gvim is launched.

As a workaround: when I want to use gvim from a terminal, and continue using that terminal, I usually launch gvim separately and then use "vim --remote-tab-silent file.x" or similar to send the file to an existing Vim instead of launching gvim directly on the file.

Any computer interactive application, whatever it is - like for example online banking or purchases like eBay, that sprouted rafts of warnings every now and then alarming its end users and forcing them to stop doing productive work to research the source, would be regarded as a low-usability UI.
The developers of said application would feel ashamed and would take pride in fixing the issue ASAP. Or at least this is what I would do, instead of arguing along the years.
We developers, as vim end users, should not see these warnings, and those of us who used part of our time in this thread (and its duplicates), should instead be doing productive work.


Comment out NetworkPolicy which is optional

/override ci/prow/scorecard ci/prow/e2e-kind  ci/prow/e2e-ocp-4-15 ci/prow/e2e-ocp-4-15-arm ci/prow/e2e-ocp-4-16


[5.2] Migration tags

as discussed in https://github.com/laravel/framework/issues/12558 this adds the ability to "tag" locations for migrations.
By no means the finished product, but i think theres enough here to get feedback.
In its current state all existing migration tests pass, which is key to BC. Ive modified the test mock objects slightly, only to expect and return the right values, not the functionality of the tests.
usage without "tagging" is exactly the same, usage with "tags" is like this:
Register a "tagged" migration location (probably called in package service providers)
Migrator::tag('tagname', __DIR__ . '../migrations');

Links "mytag" to that location
Migrate Command
php artisan migrate // same as before

php artisan migrate --tag=mytag // runs all migrations registered for "mytag"

php artisan migrate --tags //runs all migrations for all registered tags by internally calling the migrate command with --tag=xx

Migrate Rollback
Doesnt have --tags option as would be confusing, can use --tag=xxx to rollback specific tag
Migrate Reset
Has both --tag=xx and --tags options, and works just like the migrate command
Migrate Refresh
Calls reset and migrate internally so wasnt much work, has both --tag=xx and --tags options.
As i said above all current tests work as expected, admittedly i havent created new test methods to test the new functionality *yet but wanted to gather a little feedback before proceeding any further.

:+1: this could be useful for multi-tenant setups where you have a seperate shared/tenant databases. right now you have to provide paths to each set of migrations and set their database in the call as well.
Maybe this tagging could also set the database connection the tag should use?

i agree it adds more flexibility, but i think we should take it one step at a time.
multi tenancy talk has already caused alot of confusion and i dont really want it to take over the core reason for this pull request.
if it gets intergrated it would already simplifiy your use case anyway, you could just do
php artisan migrate --database=xyz --tag=tenant
and im sure there are loads of other wonderful uses for migration tags well see get used if/when its part of the core.

Agreed, its out of the scope of this PR, just wanted to throw a real life use case behind this.

thats cool, all good info.
my use case behind it was to allow "plugins" to an app to handle there own migrations independant of the core migrations.
plus it makes composer packages easier to seperate from the "app", more of a seperation of concerns keeping package migrations out of the apps migrations folder.

also on this subject i think it would make sense to at least "propose" the --path option gets removed in 5.3.
currently if you run a migration with the --path option, you cant rollback that migration EVER as the rollback command doesnt have a path option and the way the migrator logs batches right now you couldnt even add the path option to allow it, so in reality its a feature that if used can just get you into trouble.

:+1:
Definitely could use this in the app I'm working on now. I've had to resort to getting an instance of the migrator manually and calling the runUp and runDown methods on a list of migrations within a given path. Not ideal, so being able to tag migrations would be awesome!

currently if you run a migration with the --path option, you cant rollback that migration EVER as the rollback command doesnt have a path option and the way the migrator logs batches right now you couldnt even add the path option to allow it, so in reality its a feature that if used can just get you into trouble.

yup, this is exactly why I'm excited about this for the multi-tenant setup.
The plugins idea is great as well. Could really help some of the CMSs built on L5 or if someone was building their app to be more modular chunks.
I also just saw you are the one who created the tenantable package. Great work! Its the same setup I have at work but that wasn't made as a package. Migrating everything over to a version of yours. :)

Where in the PR are you adding the new column to the database. Could we even do that in a backward compatible way?

Looks like he is doing it here https://github.com/laravel/framework/pull/12569/files#diff-239b1bf64a82973fb3285dcb59a8103cR150
One idea to do it in a BC way would be to prefix the migration name in the db with the tag...
tag/2016_01_01_migrationname

@leemason any further thoughts on this? Looks like it left off at the backwards compatibility discussion which could be accomplished by prefixing the migration name instead of creating a new column...

Holding off on this.


Can't remove Banner

could someone tell me how to remove banner

2023-02-18 20:57:48.369  INFO 64482 --- [           main] Hibernate Types                          : Check out the README page for more info about the Hypersistence Optimizer banner https://github.com/vladmihalcea/hibernate-types#how-to-remove-the-hypersistence-optimizer-banner-from-the-log
I can't find instruction how to do it :)

If you see any banner, it means you are using a very old version.
If you upgrade, there will be no banner anymore.

If you see any banner, it means you are using a very old version.
If you upgrade, there will be no banner anymore.

thanks

You're welcome


HACKTOBERFEST 2020

Hacktoberfest 2020

 Hacktoberfest 2020 🎉
So, the festive season for OPEN SOURCE is back guys and we are here to help you contribute (and grab the swags :tada: ).
🗣 Hacktoberfest encourages participation in the open source community, which grows bigger every year. Complete the 2020 challenge and earn a limited edition T-shirt.
📢 Register here for Hacktoberfest and make four pull requests (PRs) between October 1st-31st to grab free SWAGS 🔥.

GOAL
To help you contribute to OPEN SOURCE REALM.
WHAT YOU NEED TO DO

Go and open README.
Follow the steps there :rocket: :tada:.

Hacktoberfest 2020

Hacktoberfest 2020 tada
So, the festive season for OPEN SOURCE is back guys and we are here to help you contribute (and grab the swags tada ).
speaking_head Hacktoberfest encourages participation in the open source community, which grows bigger every year. Complete the 2020 challenge and earn a limited edition T-shirt.
loudspeaker Register here for Hacktoberfest and make four pull requests (PRs) between October 1st-31st to grab free SWAGS fire.
GOAL
To help you contribute to OPEN SOURCE REALM.
WHAT YOU NEED TO DO
* Go and open **[README](https://github.com/BitByte-TPC/first-bit/blob/master/README.md)**.

* Follow the steps there rocket tada.

Hey @avats-dev I also want to contribute thanks for complete guide for how to make your first PR on github.

@avats-dev This is great!, would definitely submit a pr.


CTRL+ALT+Space shortcut broken in Chrome

Hi,
We're currently having an issue in Chrome where using Mousetrap.bindGlobal(['ctrl+alt+space'] no longer works, when it did previously. We tested in Chrome 77-70 and it still did not work
This shortcut works on Firefox but not chrome. Changing the shortcut to CTRL+ALT+F fixes the issue but we'd like to keep our original shortcut to keep our users muscle memory
Demo here:
https://codepen.io/aidanbiggs/pen/VwZRWyZ
Any help would be appreciated, thanks!

We're having this too.
It started after update to Chrome 77.0.3865.90 and seems to be reproducible only in windows version.
In previous Chrome version the shortcut still works, and it also works in Chrome for linux 77.0.3865.90.

See also Chrome bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1008821&can=2&q=hotkey#makechanges

Sorry to hear that it is broken in Chrome 77!  I think this is the core problem, which has just been fixed for upcoming Chrome 78.  Can someone please verify if latest Chrome Canary works?

Just confirmed that the bug has been fixed for Chrome 78.

@mustaqahmed are there plans to backport this fix to Chrome 77?

Unfortunately the Chromium bug was reported a bit too late to catch 77.

Anyway thank you @mustaqahmed! :) Will wait for Chrome 78 to release.


[QUERY] Is it possible to stop ServiceBusProcessor from within ProcessMessageAsync callback?

Library name and version
Azure.Messaging.ServiceBus
Query/Question
I need to be able to stop ServiceBusProcessor from receiving messages from within the ProcessMessageAsync callback.
Calling processor.StopProcessingAsync() from within the handler doesn't seem to work. Is this scenario supported?
Environment
No response

Hi @SeanFeldman.   We don't recommend doing so.  The processor awaits the handlers when stopping and the call does not return until all handlers are complete.   If you call StopProcessingAsync from a handler and await the call, you'll end up in a deadlock.   From the docs:

It is not recommended that the state of the processor be managed directly from within this handler; requesting to start or stop the processor may result in a deadlock scenario.

That said, while it is not an supported scenario, it is technically possible so long as you do not await the stop call.

@jsquire l, let me ask it differently. The assumption with the processor that an external decision is made wherever the processor should stop or not. What I'm looking at is a scenario where the pump has the information and needs to decide wherever the processor should be signalled to stop or not. Would having an option to signal via args passed in help? The expectation is not to drop everything immediately but rather to kick off stopping.

@SeanFeldman, we generally advise a pattern where the handler signals to the application owning the processor that it should be stopped.  For example, something like:
using var cts = new CancellationTokenSource();

await using var client = new ServiceBusClient("<< CONNECTION STRING >>");
await using var processor = client.CreateProcessor(queueName, options);

processor.ProcessMessageAsync += MessageHandler;
processor.ProcessErrorAsync += ErrorHandler;

async Task MessageHandler(ProcessMessageEventArgs args)
{
    var body = args.Message.Body.ToString();

    if (string.IsNullOrEmpty(body))
    {
        cts.Cancel();
    }
    else
    {
        Console.WriteLine(body);
        await args.CompleteMessageAsync(args.Message);
    }
}

Task ErrorHandler(ProcessErrorEventArgs args) => Task.CompletedTask;

// start processing
await processor.StartProcessingAsync();

try
{
    await Task.Delay(Timeout.Infinite, cts.Token);
}
catch
{
    await processor.StopProcessingAsync();
}
finally
{
    processor.ProcessMessageAsync -= MessageHandler;
    processor.ProcessErrorAsync -= ErrorHandler;
}

During the initial design, we had prototyped and tested a few different patterns and ways to enable handlers to assert control or signal to stop.  Ultimately, it was decided against because it caused confusion and encouraged the wrong usage patterns where developers thought it was appropriate to stop and restart the processor for every error ping rather than allowing the processor to recover on its own.

That looks good and is aligned with what I'm looking at - controlling when the processor should stop from the handler. Thank you, @jsquire.
BTW, this could be a good snippet to add to the documentation.

Thanks for the suggestion, @SeanFeldman.   We'll take a look at adding this to the samples.
//fyi: @m-redding, @JoshLove-msft


Tidy up the test userinterface

The test userinterface is shit at the moment, make it better. ;)

Done with commit fdc423b9


"Get-CA -Name $CAName | Get-EnterprisePKIHealthStatus" returns error "Method invocation failed because [SysadminsLV.Asn1Parser.Asn1Utils] does not contain a method named 'DecodeInteger' "

I'm getting this error when trying to run Get-EnterprisePKIHealthStatus on the Get-CA command after looking up our FAS server's CA certificate. I'm using version 4.2.0 of PSPKI.
"Method invocation failed because [SysadminsLV.Asn1Parser.Asn1Utils] does not contain a method named 'DecodeInteger' "
The command works fine on the Secondary CA server up the chain that the FAS servers use to get their certificates so I'm not sure what I'm doing wrong?
Also the primary root CA just returns null.
Primary CA (null)
Secondary CA (working)
Tertiary CAs [FAS machines] (error)

This has been fixed and added to next release.


Can't update a lock file in some cases

I tried to update the deno.json and deno.lock by molt deno.json -w --unstable-lock and molt-action. It says this and outputs an error.
Can't update a lockfile for an import map including any URL that can'be imported as is.

These might be the factors that reproduce this.

deno.json includes:

non-official URL import like https://esm.sh/<EMAIL_ADDRESS>or a special version specified import like jsr<EMAIL_ADDRESS>

deno.lock exists (if not, it runs correctly even if deno.json has the above imports.)

ref:

success: https://github.com/5ouma/opml-generator/actions/runs/9557327375/job/26344469161
failed: https://github.com/5ouma/reproxy/actions/runs/9557174831/job/26343806710

The code that outputs this message is here.
https://github.com/hasundue/molt/blob/dfe31680d2ef102bab2d4867d2631e7178598623/core/update.ts#L421-L436

I'm aware of the issue, and was just working on it today, but your additional information helps a lot! Thanks for reporting.


change the screen refresh rate without touching the screen？

Thank you for allowing me to switch the screen refresh rate by modifying the dfps.txt file. However, I found that after modifying dfps.txt, I need to touch the screen for the refresh rate change to take effect. Is there a way to successfully change the screen refresh rate without touching the screen?

I don't think so, cos this module works based on touch, means device go into idle state when no touch on the screen and vice versa.


Update the docs for V2 Changes

Update the docs to be fully updated for V2 and finish HA documentation

Fix https://github.com/Pirate-Weather/pirateweather/issues/214
Fix https://github.com/Pirate-Weather/pirate-weather-ha/issues/146
Fix https://github.com/Pirate-Weather/pirate-weather-ha/issues/211
Fix https://github.com/Pirate-Weather/pirate-weather-ha/issues/231
Fix https://github.com/Pirate-Weather/pirate-weather-ha/issues/213
Fix https://github.com/Pirate-Weather/pirateweather/issues/215

Great, just pushed another set of additions to the V2.0 docs branch, which should round out all those updates.
One thing I was thinking about was what sort of stuff should go in the HA docs that isn't already included? I added some stuff on alerts, but are there more FAQ's that should be added? Or something more fundamental?

Was looking through the changes and I don't see anything specific in the HA docs about the alerts sensor. Maybe I missed it but it looks like it's not there? For the HA docs I'd include a link to the data points section in the API documentation. I would document any specific HA things in there that don't apply to the regular API. Be it as FAQs or just regular documentation.
The only other thing that is needed here is updating the OpenAPI specification as it looks like it was missed in these changes.

Also as per this comment maybe you should clarify where the storm distance is measured from?

Incredible notes, these are great! I'll go through them and double check each one.
Also, note for myself- smoke is ins kg/m3 (the model default), but ug/m3 makes way more sense. Need the docs to report ug/m3 and multiply the response by 10^9

I fixed the missed spelling change and I updated a few items in the table that I'm sure of but you should double check and make sure.

Like I said earlier, amazing edits!!! I went through and put them all in, as well as updating the data pipeline page with the new times. I'm going to supersede that page with the details on the new V2 processing flow, but since that's just for general interest I want to get this out first.
Also added some more details on the storm distance, and updated the changelog/ roadmap.
Also really good comment on the OpenAPI specs. Apiable really likes having those, and it's good practice, so I'll add those in before we push this.

@alexander0042 I added in the new sensors to the HA page and did some minor updates to the OpenAPI spec (mainly change data types on some items which were incorrect). Also the DataSources.md page will need to be added to the menu.

@alexander0042 I've updated the OpenAPI spec if you want to double check and make sure everything is good there. I also added in the new sensors into the HA docs page. Is there anything from my last comment that you want to add or is it good to merge?

I added the new sensors which I added yesterday and the template from the templating issue in HA. @alexander0042 I think things are good now if you could review so we can get this merged in.

Ok,  with that fire out I finally had a chance to review this! Read through it all and it's looking good, so I'm going to push to main and see how everything formats

Was just about to go and fix the changelog version but you beat me to it and added 2.0.6 and 2.0.7. The OpenAPI spec will need to have the versions changed but that's pretty minor.


replace simple reassign with  _.merge

The following code will override some properties that is an Object, like config.client.
this.set = function(newConfig) {
    Object.keys(newConfig).forEach(function(key) {
      config[key] = newConfig[key];
    });
};

If someone want to  pass an custom property to client, He has to also pass all the properties:useIframe,args,and captureConsole, or they will be lost.
So I suggest replacing this with following:
   this.set = function(newConfig) {
     config = _.merge(config, newConfig);
   };

Closing due to inactivity.


Added responsiveness

responsiveness of the page is not working #91
I have worked on the responsiveness of the page could you please review it onec

responsiveness of the page is not working #91
I have worked on the responsiveness of the page could you please review it onec

There is conflicts. Check and resolve it.


Add styles to svg output sprite

I'm using stack sprites and when using them as a background image it's possible to change the color with css filters, as explained in this article: https://css-tricks.com/solved-with-css-colorizing-svg-backgrounds/
However, I need to add fill:#fff; to the sprite to make it work.
Is it possible to add an option to add custom styles? would it be hard to implement?

@Mantish It is beyond svg-sprite's scope to do SVG manipulation in general, and adding an option for your specific task would be way too specific. You could, however, leverage a custom post-processing transformation to modify the resulting sprite SVG after compilation. Please refer to the docs for some help.

thanks! I think that would work


Quaternion definition in BLE Header and SDK differ

I noticed that the quaternion definition in this header and in the Myo SDK is different:
/// Orientation data, represented as a unit quaternion. Values are multiplied by MYOHW_ORIENTATION_SCALE.
    struct MYOHW_PACKED {
        int16_t w, x, y, z;
    } orientation;

While the SDK defines it as
/// Index into orientation data, which is provided as a quaternion.
/// Orientation data is returned as a unit quaternion of floats, represented as `w + x * i + y * j + z * k`.
typedef enum {
    libmyo_orientation_x = 0, ///< First component of the quaternion's vector part
    libmyo_orientation_y = 1, ///< Second component of the quaternion's vector part
    libmyo_orientation_z = 2, ///< Third component of the quaternion's vector part
    libmyo_orientation_w = 3, ///< Scalar component of the quaternion.
} libmyo_orientation_index;

This is either inconsistent or a even a bug, because using the SDK definition with the Bluetooth data instead gives reasonable results while using the BLE header definition seems to result in wrong data for me.

Closing this out for now, further discussion about this can be found on the forums here. This is likely down to the specific matrix construction, as the order is correct in both places. Admittedly the fact that it's different between the BLE standard and the SDK can be confusing, but the documentation is correct.


chore: drop order dependency from Data.Nat.Defs

There's an import chain Order.Nat → Order.BoundedOrder → Order.Lattice → { Order.Monotone.Basic, Order.RelClasses } which means none of these can use the LinearOrder instance anymore.

[x] depends on: #13082

I tried to limit the scope as much as possible here; there's more in https://github.com/leanprover-community/mathlib4/compare/Nat-LinearOrder-2 and https://github.com/leanprover-community/mathlib4/compare/List.Basic-no-algebra

I must say I've toyed with the idea myself but I'm not yet sure I like it.
The lemmas you're removing the dependencies on are very basic and boil down to easy-but-annoying-to-prove-on-the-fly tautologies.
I suspect the correct solution is to upstream those lemmas to Batteries using Batteries-specific typeclasses

That's certainly not a project I want to start on :)

I still think this is useful; it's a blocker for Data.List.Basic, among other things.


LIKE operator produces different result than in T-SQL, leaks implementation detail

Run the following query on Microsoft SQL Server and in NQuery:
SELECT CASE WHEN '2.10.1' LIKE '2.1.%' THEN 1 ELSE 0 END
SQL produces 0, because '2.1.' doesn't match '2.10' as '.' differs from '0'. Unfortunately NQuery produces 1, because it compiles the match string to a regular expression and doesn't escape the dot character. So NQuery leaks an implementation detail to the user.
There's a workaround until the bug is fixed: Manually escape the match string with REGEX_ESCAPE. With this workaround the query looks as follows:
SELECT CASE WHEN '2.10.1' LIKE REGEX_ESCAPE('2.1.%') THEN 1 ELSE 0 END
Not great, but at least it works.

Fixed in NQuery v.Next PR # 3.


Bind Serenity Widget to jQuery element

Hi all!
In a partial view xyz.cshtml, if I find jQuery elements by Id, is there a way to bind it to a Serenity Widget, from the input element, in this case, the MultipleImageUploadEditor?
new Serenity.MultipleImageUploadEditor($('#Attachments'), {}).init();

the code above binds the element but only the temporary file gets uploaded, what needs to be called the get the object array for the attached files before actually posting to the endpoint

@volkanceylan where is the object array stored that has all the attached files?

yourEditor.value

Thanks @volkanceylan, it was actually $('yourEditor').data().Serenity_MultipleImageUploadEditor.entities, and you'd still have to use the saverequesthandler as it processes the file from temp storage

You should assign your editor widget to a variable first:
var yourEditor = new Serenity.MultipleImageUploadEditor($('#Attachments'), {})

If you somehow didn't have widget reference, you could get it with:
$('#Attachments').getWidget<Serenity.MultipleImageUploadEditor>()

Thanks @thechadc and @volkanceylan! Works out both ways


route prefix and regex match priority

NGINX route priority:  it puts the prefix on the first place but KONG do the opposite(kong treats the regex match as the first one). I want to know why
sorry for my poor english

Nginx has:

= for exact match, e.g. location = /
^~ for the longest matching prefix, e.g. location ^~ /
`` (no prefix) for prefix match, e.g. location /
~ for regex match, e.g. location ~ /.*
~* for case-insensitive regex match,  e.g. location ~* /.*

What Nginx does is:

Check if there is = exact match, if found, use that. done.
Check if there is ^~ longest matching prefix, if found, use the longest of those that was matching. done.

This is simple so far. But only with those.
What happens next is:
3. nginx searches all the prefix matches `` (no prefix) (we do it too). if found it remembers the longest, but it does not stop there.
4. nginx searches all the regexes in order they appear in config file (and in Kong we search according to regex priority), if any of the regexes match, nginx will use it.
5. if none of the regexes matched, nginx will use the remembered prefix (see Nginx uses regexes before prefixes).
So depending on what you mean we can endup with conclusion:

Nginx uses exact match
Nginx uses longest matching prefix
Nginx uses regex
Nginx uses prefix

All that said, you can consider Kong implementing:

regex (~)
prefix (`` — no prefix)

In that sense Kong works exactly as Nginx. If you are asking why we don't have longest matching prefix OR exact match, the answer is that we just haven't implemented them. Of course, in addition to those, there are a lot of other possibilities for matching.

I'd be willing to pick this up and try to implement

@Kerl1310 sorry for not having answered more quickly. The file you are pointing at is the correct one - router.lua is where most, if not all, of these changes are made. However, depending on what you want to implement, you might need to edit things in more than one place on that file, not in a single line or section.
You will likely also need to modify or add tests. Those are here:
spec/02-integration/05-proxy/02-router_spec.lua
spec/01-unit/08-router_spec.lua

Is this issue fixed? Can I start to work on it? @Kerl1310, @kikito

@cvaram96 do you mean have we implemented:
longest matching prefix OR exact match?
The last one can be done with regex, but we have not implemented exact_match. The another is also missing. But that is just what Nginx provides, that is by no means complete or the truth. We are considering implementing a more flexible routing with 3.0, but nothing has been decided so far. Suggestions are welcomed!

I am closing this for now. The PR for adding longest matching prefix is welcomed.


Specify pyaaf2 requirement as a minimum version

Summarize your change.
bb60a6f9784b7cc05291c5df6c107a3f00f6c11f loosened the versions of packages that are required, and changed the specification of dependency versions from being exact versions to being minimum versions. However the same change was not applied to the pyaaf2 version specification. Given that pyaaf2 versions have remained backwards compatible, at least so far, it should be safe to allow users to use different versions of pyaaf2 than what is required in the setup.py currently. Therefore this change makes the version requirement of pyaaf2 also be a minimum version specification rather than an exact one.
Reference associated tests.
None required.

Codecov Report

Merging #906 (435a5e3) into master (3c1e28e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #906   +/-   ##
=======================================
  Coverage   85.97%   85.97%
=======================================
  Files         184      184
  Lines       17883    17883
  Branches     1992     1992
=======================================
  Hits        15375    15375
  Misses       2000     2000
  Partials      508      508

Flag
Coverage Δ

unittests
85.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1e28e...435a5e3. Read the comment docs.

In the past, breaking changes to PyAAF versions created mysterious errors in PR unit test runs.  Locking the version was an attempt to prevent that.  I think if we were going to unlock it in this way we'd want to enable a nightly build or similar thing so that we could catch failures related to dependencies changing outside of PRs breaking because of upstream libraries changing.

@ssteinbach In those previous cases would semver have signaled those issues? If so, maybe we could do something like: pyaaf2~=1.4.0 to pick up patch releases but make sure we stay in the 1.4.x version series.

I think they were the middle digit changing.  I'd have to go and look through the history to confirm that.  To be honest, I don't think PyAAF2 releases all that often (I think the most recent release is still 1.4.0 from last january), but if the pattern you're suggesting means 1.4.x that seems relatively safe.  I think there are also GitHub ways of detecting that a dependency has made a release and if the unit tests pass automatically landing a PR that bumps the version up.  I'd love a solution like that.

I agree. I think we could accept this PR by having it use ~= instead of >=. The re-build thing would be a great nice-to-have, but if someone is having pain because of our stale specific version pinning, I'd hate for them to be stuck. @AWhetter how does this sound to you?

Seems sensible to me. I've made the change to ~=.

Just for future reference, this was the service I was mentioning: https://github.com/dependabot

better docs: https://docs.github.com/en/code-security/supply-chain-security/enabling-and-disabling-version-updates#enabling-github-dependabot-version-updates

Thanks @AWhetter!


fix(Input): add multiple to propNames

Fixes #1386.

Codecov Report

Merging #1422 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
+ Coverage   99.74%   99.75%   +<.01%
==========================================
  Files         141      140       -1
  Lines        2354     2402      +48
==========================================
+ Hits         2348     2396      +48
  Misses          6        6

Impacted Files
Coverage Δ

src/elements/Input/Input.js
100% <ø> (ø)
:white_check_mark:

src/modules/Dropdown/DropdownItem.js
100% <0%> (ø)
:white_check_mark:

src/collections/Table/Table.js
100% <0%> (ø)
:white_check_mark:

src/modules/Dropdown/DropdownDivider.js
100% <0%> (ø)
:white_check_mark:

src/modules/Modal/ModalActions.js
100% <0%> (ø)
:white_check_mark:

src/collections/Form/FormButton.js
100% <0%> (ø)
:white_check_mark:

src/views/Comment/CommentGroup.js
100% <0%> (ø)
:white_check_mark:

src/collections/Form/FormField.js
100% <0%> (ø)
:white_check_mark:

src/views/Card/Card.js
100% <0%> (ø)
:white_check_mark:

src/modules/Modal/ModalDescription.js
100% <0%> (ø)
:white_check_mark:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 169332f...cfe19bf. Read the comment docs.

Thanks much!

Released in<EMAIL_ADDRESS>


Oodify group

This removes the system group requirement from the app for use on systems without that functionality.
After committing this, I think that this is actually a very aggressive cut. Maybe too aggressive.
We can actually probably leave the group in the views. On systems where group isn't available a blank string is send to the frontend and there would then just be a blank space under the column.
I think that users not having a primary linux group may be an edge case and we're losing that functionality for something that might happen.

My other concern with this is that I'm not happy with the .sort_by! method in the controller, the priority sort should be updated to sort by username after bubbling the current user to the top of the stack. I can revisit that when I get another moment.

Not doing. https://github.com/OSC/osc-jobstatus/pull/75 was the solution to this.


merge from template-browser-ava

.github/workflows/ci.yml

chore: (jobs.test-node.strategy)
chore: add<EMAIL_ADDRESS>(jobs.test-browser.steps.uses)

.github/workflows/update_readme_api.yml

chore: add<EMAIL_ADDRESS>(jobs.update_readme_api.steps.uses)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.007%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
911

Relevant Lines:
983

💛  - Coveralls


How to support touchscreen?

I have a window pad，I running app on that，App is very simple just a LazyColumn，It can use mouse wheel scroll，but not use touchscreen scroll.

I see  Modifier extensions function has a mouseScroll and mouseTouch，How to use it ? Thx~

Hi @akurasov, Do you know how to solve this problem? I saw that you mentioned relevant problems and tried to solve the problem of unable to drag and scroll on the touch screen.

val scrollState = rememberLazyListState()
val data = (0 until 1000).map { "Item $it" }
LazyColumn(
    modifier = Modifier.draggable(rememberDraggableState { delta ->
        println("delta=$delta")
        runBlocking {
            scrollState.scrollBy(-delta)
        }
    }, orientation = Orientation.Vertical),
    state = scrollState
) {
    items(data) { i ->
        Text(
            i,
            Modifier
                .padding(14.dp)
                .fillMaxWidth()
        )
    }
}

See above code:
Maybe, I has solve the problem.

Yes, if you want to handle dragging gesture, you should use this API.
There is no explicit touch screen support, Compose relies on OS level conversion of touch Screen events to mouse events.

Is there a plan to implement proper touch screen support? I actually attempted to pass through touch events while trying out compose, using the ComposeScene, but found that certain components such as TextField are hard coded to only work properly for mouse on desktop.

There are no immediate plans for it. Could you please describe some scenarios, where current support is not enough?

There's no fling behaviour when scrolling with the above method, and no way to differentiate between mouse and touch gestures.

There are no immediate plans for it. Could you please describe some scenarios, where current support is not enough?

My use case is a GUI client that includes 2D and 3D mapping functionality. It can be run on any Windows or Linux multitouch-enabled device. Examples include laptops and desktops with monitors having multitouch support, Microsoft Surface and Linux tablet devices, and similar. For 2D maps (think Google Maps) it supports simultaneous pinch-to-zoom, drag-to-pan, and twist-to-rotate two-finger gestures. For 3D maps (think Google Earth) it's the same, with the addition that switching to three-fingered gestures changes drag-to-pan to drag-to-pan-horizontally-and-tilt-vertically. The client can sometimes be used in high-criticality (i.e. potential loss of life) situations, so precise, performant touch and gesture control is vital.
Currently we use OpenJFX for this, in particular its TouchEvent and GestureEvent multitouch support. See also "Handling JavaFX Events: Working with Events from Touch-Enabled Devices" and "Handling JavaFX Events: Working with Touch Events".
I'd like to consider porting to Compose Multiplatform in the future to support Windows and Linux desktop, Android, and WASM targets all from a single client, but multitouch support would be required for each.
I could also see gaming and 3D modelling applications being two other use cases.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


GAT tutorial

Here is a link to a Google Colab. The tutorial implements a Graph Attention Network (GAT) for node classification. Relatively similar to the GNN tutorial but a different type of GNN.

Thanks for the feedback! The tutorial has now been modified according to your feedback. (Some minor additional changes were made too.)

I messed up the commit history (some random merges)... Let me know if we should close this pull request and make a new one.


/users/login to /login

Description

correct folder structure for [walletOrHandle] and [wallet] user endpoints
move /login out of /users

These routes are not used in the UI yet. Right?

They are actually yea, when authenticating in Carbonmark

These routes are not used in the UI yet. Right?

They are actually yea, when authenticating in Carbonmark

Sorry for my noobness but can you explain how it works? When I reviewed the PR, I put some console logs in those API routes, logged in with metamask and tor and I could not see the browser requests nor the API logs.

No noobness at all, I realised that we had manual functions calling the api end points directly (thereby skipping the api sdk).
If you pull the latest changes you should see your logs firing (assuming everything builds this run)

@0xtapi when you get a chance can you QA the auth aspects of carbonmark please? login, sign up, create account etc

Tested, errors found:

Trying to create a profile returns "Something went wrong. Please try again. TypeError: Failed to fetch"

Console screenshot:

Logging in and out and switching accounts works.

Tested, errors found:

Trying to create a profile returns "Something went wrong. Please try again. TypeError: Failed to fetch"

Console screenshot:

Logging in and out and switching accounts works.

@0xtapi can you re-confirm in here that the create issue is fixed plz?


Blog post: How we built page feedback

Write a blog post about how we made the page feedback widget for covid19.ca.gov. Once Clara and Aaron decide what level of content support they'd like, I'll put milestones in this summary.

Cancelling incomplete blog post tasks assigned to me

Rought notes for this post