QR Scanner - Can't send tokens from payment data

Current behavior
Scanning QR codes for multitoken support is throwing errors in Sentry.
Desired behavior
No unexpected errors during multi-token send flow.
Steps to Reproduce
WIP
Versions
iPhone 7 on iOS 13.3 - Valora v1.25.1

Hey @MuckT, We have verified this issue using Latest Test flight release build V1.25.1 & observed that user is able to send all tokens by scanning QR code from the account having valid balance of tokens and "Send" button appears disabled for the account having zero balance.
Device: iPhone 7 (13.3)
Attachments:
Send flow of account having valid balance.mp4
Send button for zero balance acc.jpg
Thanks..!!


Internal Error when i do "/papi ecloud download LuckPerms"

Placeholder says it loads the extension, the in red text says "an internal error occurred while attempting to perform this command"

Please give us the actual error which is located in the console.
If the error contains something like net.java.ClassDefNotFoundException (or something like that) then try updating to lates version of LuckPerms as you're most likely using an outdated version.

Sorry, (btw idk how to understand logs)
this is what i got
[23:46:01] [Server thread/INFO]: LeEpicCheese issued server command: /papi ecloud download luckperms
[23:46:01] [Server thread/INFO]: [PlaceholderAPI] Attempting download of expansion: LuckPerms by user: LeEpicCheese from url: http://api.extendedclip.com/media/Expansion-LuckPerms_IaULsEO.jar
[23:46:01] [Server thread/INFO]: [PlaceholderAPI] Fetching available expansion information...
[23:46:01] [Craft Scheduler Thread - 251/INFO]: [PlaceholderAPI] Download of expansion: LuckPerms complete!
[23:46:02] [Craft Scheduler Thread - 250/INFO]: [PlaceholderAPI] 169 placeholder expansions are available on the cloud.
[23:46:06] [Server thread/INFO]: LeEpicCheese issued server command: /papi reload
[23:46:06] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: statistic
[23:46:06] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: player
[23:46:06] [Server thread/ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'papi' in plugin PlaceholderAPI v2.10.5
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[spigot.jar:git-Paper-155]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:159) ~[spigot.jar:git-Paper-155]
at org.bukkit.craftbukkit.v1_15_R1.CraftServer.dispatchCommand(CraftServer.java:752) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.PlayerConnection.handleCommand(PlayerConnection.java:1825) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.PlayerConnection.a(PlayerConnection.java:1633) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.PacketPlayInChat.a(PacketPlayInChat.java:47) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.PacketPlayInChat.a(PacketPlayInChat.java:5) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:23) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.TickTask.run(SourceFile:18) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.MinecraftServer.ba(MinecraftServer.java:1038) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.MinecraftServer.executeNext(MinecraftServer.java:1031) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:119) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.MinecraftServer.sleepForTick(MinecraftServer.java:1015) ~[spigot.jar:git-Paper-155]
at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:938) ~[spigot.jar:git-Paper-155]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]
Caused by: java.lang.NoClassDefFoundError: net/luckperms/api/LuckPerms
at me.lucko.luckperms.placeholders.LuckPermsExpansion.canRegister(LuckPermsExpansion.java:48) ~[?:?]
at me.clip.placeholderapi.expansion.ExpansionManager.registerExpansion(ExpansionManager.java:110) ~[?:?]
at me.clip.placeholderapi.expansion.ExpansionManager.registerAllExpansions(ExpansionManager.java:173) ~[?:?]
at me.clip.placeholderapi.PlaceholderAPIPlugin.reloadConf(PlaceholderAPIPlugin.java:186) ~[?:?]
at me.clip.placeholderapi.commands.PlaceholderAPICommands.onCommand(PlaceholderAPICommands.java:263) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[spigot.jar:git-Paper-155]
... 17 more
Caused by: java.lang.ClassNotFoundException: net.luckperms.api.LuckPerms
at java.net.URLClassLoader.findClass(URLClassLoader.java:382) ~[?:1.8.0_212]
at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_212]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_212]
at me.lucko.luckperms.placeholders.LuckPermsExpansion.canRegister(LuckPermsExpansion.java:48) ~[?:?]
at me.clip.placeholderapi.expansion.ExpansionManager.registerExpansion(ExpansionManager.java:110) ~[?:?]
at me.clip.placeholderapi.expansion.ExpansionManager.registerAllExpansions(ExpansionManager.java:173) ~[?:?]
at me.clip.placeholderapi.PlaceholderAPIPlugin.reloadConf(PlaceholderAPIPlugin.java:186) ~[?:?]
at me.clip.placeholderapi.commands.PlaceholderAPICommands.onCommand(PlaceholderAPICommands.java:263) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[spigot.jar:git-Paper-155]
... 17 more

If the error contains something like net.java.ClassDefNotFoundException (or something like that) then try updating to lates version of LuckPerms as you're most likely using an outdated version.

Caused by: java.lang.NoClassDefFoundError: net/luckperms/api/LuckPerms

Sorry and thanks!


workflow: add binary build and publish action

This PR adds an action to create binaries once a release is crafted.
As a follow up, an addition to the readme is needed, but  it would make sense to ensure the workflow is working as expected, before adding the corresponding readme section.
This fixes #6

The zip and tar archive should just be a single line essentially, so that could be added to the run section.
Maybe the folder should then be renamed.
We can point to a release version of the actions as well. I can dig up which are the current stable releases.
The token is a built in of GitHub that's generated at the start of a run: https://docs.github.com/en/actions/security-guides/automatic-token-authentication

Okay cool! I'm going to try to see how rough it is to just call curl directly from the script to upload the asset. Doesn't seem too bad

https://docs.github.com/en/rest/reference/releases#get-a-release
https://docs.github.com/en/rest/reference/releases#upload-a-release-asset

Closed via https://github.com/google/log4jscanner/pull/11 https://github.com/google/log4jscanner/pull/14


rhcos_sync: Improve docs and parameter descriptions

Thanks for your feedback! Think it should be better now :)

/lgtm


GridSelect: border colour and vertically centring text

Description
2 small changes to XMonad.Actions.GridSelect:

Allow border colour to be specified
This required an extra field on GSConfig so it is a breaking change.

Improve the vertical centring of text
(I cut and pasted the code from XMonad.Utils.Prompt.)

Before:

After:

Checklist

[x] I've read CONTRIBUTING.md

[ ] I tested my changes with xmonad-testing

[x] I updated the CHANGES.md file

LGTM

Thanks!


Wrong Command Posted on an SQL Database Properties MS Docs Site

Is your feature request related to a problem? Please describe.
This is a request to correct/update certain article, related to SQL Server Database Properties and in particular to Auto Update Statistics.
The article references a wrong command and article (CREATE STATISTICS (Transact-SQL)) when it comes to the Auto Update Statistics (should be Update STATISTICS (Transact-SQL))
Describe the solution you'd like
Under the section Auto Update Statitstics replace (CREATE STATISTICS (Transact-SQL)) with (UPDATE STATISTICS (Transact-SQL))
Describe alternatives you've considered
No alternatives, the procedure should be corrected/updated.
Additional context
Linkl to the article:
https://docs.microsoft.com/en-us/sql/relational-databases/databases/database-properties-options-page?view=sql-server-ver15

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 82ff5f89-39e8-2526-9f4c-fd03c8674fdc
Version Independent ID: d27b5731-f02e-c33c-5a6e-86a0a7ea0522
Content: Database Properties (Options Page) - SQL Server
Content Source: docs/relational-databases/databases/database-properties-options-page.md
Product: sql
Technology: configuration
GitHub Login: @WilliamDAssafMSFT
Microsoft Alias: wiassaf

Thanks @StoyanChalakov for contacting Microsoft with feedback about our product documentation. A doc update is in flight to correct this link and one like it for AUTO CREATE as well. Thanks again for this feedback, your suggestions help improve our documentation.

@WilliamDAssafMSFT  Glad to help, thanks for the update!


Knative RabbitMQ broker not generating URL.

Describe the bug
Rabbitmq broker do not generate URL.
soareslo:~$kubectl get brokers
NAME             URL                                                                                AGE    READY   REASON
lasbroker        http://kafka-broker-ingress.knative-eventing.svc.cluster.local/default/lasbroker   7d2h   True
rabbitmqbroker                                                                                46m

Expected behavior
Generate URL like Kafka Broker generated.
To Reproduce
I'm trying to create a RabbitMQ broker to use against my Azure Service bus.
So, I have done the following,:
I used this docs https://knative.dev/development/eventing/broker/rabbitmq-broker/
and this one as well https://github.com/knative-sandbox/eventing-rabbitmq/blob/main/broker/standalone.md
So I have the following:
I have Kafka broker configured and working nicely.
However now I want to add the RabbitMQ broker as well.

With the help of this Microsoft tool https://red-mushroom-0f7446a0f.azurestaticapps.net/
I managed to convert Azure Service Bus string to RabbitMQ amqp.
kubectl create secret --namespace knative-eventing generic azureservicebus --from-literal=brokerURL="I PLACED THE STRING HERE"
and then created RabbitMQ broker:
soareslo:~$cat create-rabbitmq-broker.yaml
apiVersion: eventing.knative.dev/v1
kind: Broker
metadata:
  annotations:
    eventing.knative.dev/broker.class: RabbitMQBroker
  name: rabbitmqbroker
  namespace: default
spec:
  # Configuration specific to this broker.
  config:
    apiVersion: v1
    kind: Secret
    name: azureservicebus
    namespace: knative-eventing

However as you can see, the RabbitMQ Broker is not generating the URL.
soareslo:~$kubectl get brokers

NAME             URL                                                                                AGE     READY   REASON

lasbroker        http://kafka-broker-ingress.knative-eventing.svc.cluster.local/default/lasbroker   7d2h    True

rabbitmqbroker                                                                                2m54s

Below you can see the broker description without errors.
soareslo:~$kubectl describe broker rabbitmqbroker

Name:         rabbitmqbroker

Namespace:    default

Labels:       <none>

Annotations:  eventing.knative.dev/broker.class: RabbitMQBroker

              eventing.knative.dev/creator: masterclient

              eventing.knative.dev/lastModifier: masterclient

API Version:  eventing.knative.dev/v1

Kind:         Broker

Metadata:

  Creation Timestamp:  2021-11-25T12:24:49Z

  Generation:          1

  Managed Fields:

    API Version:  eventing.knative.dev/v1

    Fields Type:  FieldsV1

    fieldsV1:

      f:metadata:

        f:annotations:

          .:

          f:eventing.knative.dev/broker.class:

          f:kubectl.kubernetes.io/last-applied-configuration:

      f:spec:

        .:

        f:config:

          .:

          f:apiVersion:

          f:kind:

          f:name:

          f:namespace:

    Manager:         kubectl-client-side-apply

    Operation:       Update

    Time:            2021-11-25T12:24:48Z

  Resource Version:  13195895

  UID:               003cf445-af3c-4519-8237-78e301f505f6

Spec:

  Config:

    API Version:  v1

    Kind:         Secret

    Name:         azureservicebus

    Namespace:    knative-eventing

Events:           <none>

soareslo:~$

Knative release version
v1.0
Additional context
High priority

Hey @andersonsoares-tomtom
Thanks for reporting the issue. Are you able to reproduce the issue using the RabbitMQ operator based Broker ?
After a discussion in the community, we are considering removing support for the Standalone Broker.

Hey @andersonsoares-tomtom going to close this issue since its been so long.
Please feel free to create an issue if you're still experiencing problems. In case you don't hear from someone on github, you can also reach us on eventing-rabbitmq on Slack


Update guestbook tutorial for k8s-1.8

Update to use apps/v1beta2
Update spec.selector which is now required
The rest of the tutorial is up-to-date.
cc @kubernetes/sig-apps-pr-reviews @kow3ns

This change is

/lgtm
@foxish Question: what happens if we don't update this? Will the existing v1beta1 type work on 1.8?

Yes, extensions/v1beta1 and apps/v1beta1 will continue to work.
We're encouraging people to move over to v1beta2 because it has better defaults and selector behavior.


Refreshing the page highlights the Commits tab as active

Refreshing the page reloads the Commits tab highlighted, as if it is the currently selected tab. This was tested on Firefox:

This seems to only be present if the page is refreshed while the Issues tab is selected. It doesn't seem to be present with any other tab.

Great find! I was aware there were bugs with the commits button selection logic, but didn't know how and what cases exactly. Will try fixing this soon. 😄

This has been fixed. Will be out with the next version release.


Added ?utm_source=github to links in README.md

Shiiit. The idea was that this is for links from GitHub and NPM, going to sdk.apify.com (we have GA and GTM there).

Moved here - https://github.com/apifytech/apify-js/issues/653


feature request - have no quotes as one of the toggle options

It would be great if it was possible to have no quotes as an option for the toggle sequence.
If I add an empty string to togglequotes.chars as follows:
    "togglequotes.chars": ["\"", "'", "`", ""],

I should be able to toggle between different quote types and have no quotes as one of the toggle options. Then I'd have a really easy way toggle or remove quotes around any text in vscode, all in one extension.
However, when I do this and it reaches the unquoted option, I lose the ability to continue toggling.

This is a good idea, but yes, then, it will end the cycle.
But anyway, this should be a possible option for the user to set if it wishes to.


Correct spelling mistakes

Add/Edit question, spelling of Positive. Also call it Positive Score maybe.

Pagination, spelling of questions in No more questions.

This is done.

Can only see No. 2 as being done. Did you do No. 1 too?

Yes, https://github.com/dgraph-io/gru/commit/3febd0a51e93d4d1221c191c156b3fa8a08a41a3

This is Done.


fixed content overlapping & contact us image overflow bug.

I have fixed the context overlapping issue and contact us image overflow issue. Kindly check and merge.
Before fix :

After fix:

please mention the issue no in description

@rohansx can you please put assigned label with my name, without that this PR is not counting in leaderboard.

@Devil1205 You can check now, it should be visible over there


Add noUnusedLocals to tsconfig to improve type checks.

Update relevant import to support noUnusedLocals.

It looks like something is wrong with ngc, I'll relaunch the CI tests.

I also had problems with that locally even with the untouched master branch. It appeared when running npm install.

It's probably coming from this PR, I had another yesterday and it went fine

It looks like there is a breaking change with ngc... I don't have time to look at it this week end, so it'll we next week.

Ok, I actually found it. It's coming from Typescript 2.1 not working with ngc. I fixed the version of typescript to 2.0.8.


TypeError: explode() expects parameter 2 to be string, integer given

Hi,
After the composer update, the phpunit tests started to fail. Full log:
TypeError: explode() expects parameter 2 to be string, integer given

/htdocs/php-app/vendor/greg-md/php-orm/vendor/sebastian/object-reflector/src/ObjectReflector.php:34
/htdocs/php-app/vendor/greg-md/php-orm/vendor/sebastian/object-enumerator/src/Enumerator.php:71
/htdocs/php-app/vendor/greg-md/php-orm/vendor/sebastian/object-enumerator/src/Enumerator.php:78
/htdocs/php-app/vendor/greg-md/php-orm/vendor/sebastian/object-enumerator/src/Enumerator.php:78
/htdocs/php-app/vendor/greg-md/php-orm/vendor/sebastian/object-enumerator/src/Enumerator.php:63
/htdocs/php-app/vendor/greg-md/php-orm/vendor/sebastian/object-enumerator/src/Enumerator.php:78
/htdocs/php-app/vendor/greg-md/php-orm/vendor/sebastian/object-enumerator/src/Enumerator.php:78
/htdocs/php-app/vendor/greg-md/php-orm/vendor/sebastian/object-enumerator/src/Enumerator.php:78

PHP Version: 7.1

Thank you for your report.
Please provide a minimal, self-contained, reproducing test case that shows the problem you are reporting.
Without such a minimal, self-contained, reproducing test case I will not be able to investigate this issue.

The error you report can only occur, at least as far as I can see, when $name is not a string. In your case it seems to be an integer. This implies that your object has an attribute with an integer as its name. Such an attribute cannot be declared (syntax error) or assigned dynamically (syntax error).
Only through the use of variable variables can such an object be constructed:
<?php
class C
{
    public function __construct()
    {
        $i = 1;
        $this->$i = 2;
    }
}

$o = new C;

var_dump($o);

class C#1 (1) {
  public $1 =>
  int(2)
}

Thank you Sebastian for your fast response. Here is a test case that reproduce this error:
<?php

class Select
{

}

interface DriverStrategy
{
    public function select(): Select;
}

class ObjectReflectorTest extends \PHPUnit\Framework\TestCase
{
    public function testCase()
    {
        $mock = $this->createMock(DriverStrategy::class);

        $mock->method('select')->willReturnCallback(function () {
            return new Select();
        });

        $class = new class($mock) {
            protected $mock;

            public function __construct($mock)
            {
                $this->mock = $mock;
            }
        };

        return $class;
    }
}


How respond in json to API Gateway Proxy Events??

No examples

Hi @livzz,
If you intend to use API Gateway Proxy please refer to https://github.com/eawsy/aws-lambda-go-net which provides full featured http server capability behind API Gateway.
Otherwise here is a very simple example for API Gateway Proxy:
package main

import (
	"github.com/eawsy/aws-lambda-go-core/service/lambda/runtime"
	"github.com/eawsy/aws-lambda-go-event/service/lambda/runtime/event/apigatewayproxyevt"
)

func Handle(evt *apigatewayproxyevt.Event, ctx *runtime.Context) (interface{}, error) {
	return map[string]interface{}{
		"statusCode": 200,
		"body":       "Helo, World!",
	}, nil
}


Discuss Hexagonal Architecture Guidance for Serverless Apps

Great suggestion here @rohanmeh :) Although all of .NET samples already follow Hexagonal architecture. This is an important part of testable software though.

Closing, added to pattern inventory.


Log warning if (unsupported) xpath/fast query is used with transparent sync

Currently, when you use an xpath or fast query and transparent sync is enabled, nothing is returned from Unicorn.
This is ok, as we know that this is unsupported by Unicorn and this method of using Sitecore's content API is generally regarded as a bad practice anyway.
But it would be nice if Unicorn could log a warning, so that we can see that this is happening. It could help us determine the cause of problems related to this.

Added in 1ab802c. Because you can't really tell if a query will match items under a transparent sync easily, I made it warn on any usage of Fast Query. Which I'm totally fine with!
There is also a setting to turn off the logging if you are running something fast query heavy and can't live without it or transparent sync.

This will be in the next Unicorn release.

This will be in 4.0.


Prevent reimports for TF

Motivation and context

Updated TF import check so that TF couldn't be re-imported with default import expression if an import error happens

How has this been tested?

Manual test
Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- datumaro/datumaro/util/tf_util.py  2

See the complete overview on Codacy

Pull Request Test Coverage Report for Build 5760

6 of 10 (60.0%)  changed or added relevant lines in 1 file are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 65.756%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

datumaro/datumaro/util/tf_util.py
6
10
60.0%

Files with Coverage Reduction
New Missed Lines
%

cvat/apps/engine/media_extractors.py
7
75.59%

Totals

Change from base Build 5743:
-0.04%

Covered Lines:
10920

Relevant Lines:
16214

💛  - Coveralls


Undefined variable padawan#enabled

NeoVim complains about undefined variable.  It would be nice if it was mentioned in README.md or there was a default value set for it.
Vim(if):E121: Undefined variable: g:padawan#enabled

NVIM 0.1.4.

hm, strange. Looks like I forgot about it :scream:


Allow newer nokogiris

Context
I'd like to use a later version of Nokogiri to test a fix for sparklemotion/nokogiri#1426
Change
Relax nokogiri version

Do I need to do anything else to get this merged, @ChrisBAshton?

Hi @johnsyweb - sorry for the slow reply on this.
Are you sure this is what you're intending? Merging this PR will install newer versions of Nokogiri up-to-and-NOT-including 1.7.0 (according to http://guides.rubygems.org/patterns/ - "Had we said ~> 2.2.0, that would have been equivalent to ['>= 2.2.0', '< 2.3.0'].")
EDIT: Looking more closely at the linked issue, you're looking at Nokogiri version gem 'nokogiri', '<IP_ADDRESS>' so this PR should be sufficient.
Happy to merge 👍

Thank you.
We bumped Nokogiri to 1.6.8.rc3 and the number of segmentation faults in our Rails application dropped by about 50%!

And now they're all gone: https://github.com/sparklemotion/nokogiri/issues/1426#issuecomment-220180137


TAXIICollectionSource.get()/all_versions() - check id of returned objects

Add simple sanity check for the TAXIICollectionSource.get()/all_versions() calls, where the id of the STIX objects returned from the TAXII endpoint are checked to match

Have this implemented locally. Was going to wait(?) for Brets external server to work.; or can just push.

Go ahead and push/make a PR now. I'm not sure the best way to test (and if there's a good way without an external server), but we should at least start thinking about it.

Ignoring Travis, are you using the cti_taxii_server to test in your own environment?

I was not but I can.

Thanks, @rpiazza . Using medallion for local testing is 100% the way to go; testing via Travis will be a bit harder. We may need to set up some mock responses.


do not download chromedriver

No idea why we were downloading this. It's not used.

:+1: must be some odd legacy thing at this point.


feat: support custom initializationOptions

This lets consumers provide custom initializationOptions for all workspaces.
This subsumes https://github.com/sourcegraph/lsp-client/pull/11 which included workarounds for go-langserver prior to https://github.com/sourcegraph/go-langserver/pull/373

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   65.18%   65.18%
=======================================
  Files          11       11
  Lines         293      293
  Branches       20       20
=======================================
  Hits          191      191
  Misses        102      102

Impacted Files
Coverage Δ

src/index.ts
62.04% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e394a11...3d60ad3. Read the comment docs.

@felixfbecker Do I need to bump the beta branch to trigger CI to make a release?

yep

1.1.0-beta.2 doesn't seem right. The latest is 2.0.0-beta.1. Is there another branch I need to update?

That's weird indeed. Will investigate

Filed https://github.com/semantic-release/semantic-release/issues/1191

I released 2.0.0-beta.2 manually

Ok, thanks. I'm seeing a source map warning, not sure if it's related:

[serve] ⚠  Could not load source file "../../src/features/feature.ts" in source map of<EMAIL_ADDRESS>

Well sources are not published nor inlined, but that doesn't sound related to the release issue?

Gotcha, yeah it's not related.


no_logging_test encounters infinite loop when building with cmake

What version of gRPC and what language are you using?
v1.59.1
What operating system (Linux, Windows,...) and version?
Linux
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc version 9.4.0
python 3.8.10
What did you do?

Test passed if the server is started, or failed because the server is not started.
What did you see instead?
The process is hanging because of a infinite loop
Anything else we should know about your project / environment?
In the CMakeFile, all tests are linked to both grpc_test_util and grpc_unsecure. grpc_test_util already links to grpc. Therefore, many .cc files will be linked twice. Some of those files declare global variables of type TraceFlag, thus theose variables will also be created twice at the same memory address. The constructor of this class will add the object itself to a linked list. Since some of them are created twice, the ctor are invoked twice, thus they are added to the linkedlist twice, which will result in cyclic linkedlist. (Example: TraceFlag is defined at src/core/ext/filters/backend_metrics/backend_metric_filter.cc:55,  and the ctor is called twice, and the program will eventually enter infinite loop at src/core/lib/debug/trace.cc:80 when running no_logging_test)

Can you try removing -DBUILD_SHARED_LIBS=ON please?

We need to build shared library, but I can give it a shot.
I tried removing two linked library from no_logging_test and it builds and passed the test.
target_link_libraries(no_logging_test   ${_gRPC_ALLTARGETS_LIBRARIES}   gtest   grpc_test_util )

gRPC doesn't support shared library officially so I added disposition/help wanted label here.


About performance of byol

According to the above table, the results of byol are not fully reproduced. Do you have a duplicate result?

BYOL in openselfsup is trained for 300 epoch. Though this table did not show 300 epoch, our result (72.35) is reasonable, I think.

I think this is more meaningful. The same epoch and batch size.

byol paper reported results with 300 epochs.


Add documentation for new instance tests

[ ] TempdbConfiguration
[ ] LockPagesInMemoryEnabled
[ ] SQLServicesStartup
[ ] IFIEnabled
[ ] SQLEndpoints
[ ] ResourceGovernorPools
[ ] ResourceGovernorSetting
[ ] SQLAgentAlerts
[ ] SQLAgentOperators

Might be worth revisiting the IFI name (vs. InstantFileInitilization to be explicit).

/cc @andrewalumkal

Fixed in the DBTrenches repo


Implement collider logic on projectiles

Really Parker did most of the math work here with the circle collider class, most of the work I did on collisions concerned the gamestate and gameobjects, which I counted in the GameState issue. So I'm not sure how much time to put in here. Half an hour? but then I put a similar amount of time for the tanks too


Icons

As discussed in #29, here is the MR.
This comes in two parts.
I've included your first comments (from my repo).
Thanks for the response!
I've tested it some, but another test and set of eyes would be helpful.
First part
This MR with three commits:

Add icons to to the project
Use the new icons
Deprecate util::include_cdn_icons

The last is only a logical followup of the first, it can be moved into part two (or just some time later) if you prefer.
Second part
A commit with breaking changes:
https://github.com/alexkazik/yew-bootstrap/commit/5368bba8b0de6ace1aa9f8b11b6846d852a2f77d
Since this is a breaking change, it requires a version bump to 0.6 (currently it's 0.5.18).
And that is why it will be a separate MR.
(Edit: if yew 0.21 has some breaking changes then the the version of yew-bootstrap has also to be raised to at least 0.6.)

After thinking about it a bit more: Should I just delete icons2 since it's less helpful than I thought?

I just noticed that icons v1.11.0 is out, should I update the first commit, add a new one with the update or ignore it for now?

I just noticed that icons v1.11.0 is out, should I update the first commit, add a new one with the update or ignore it for now?

I'd just ignore it for now; there are some new icons there, but we don't need to be in a rush to support them

Yew 0.21 is out, and the icons require another impl, which is not available in 0.20.
Should I add it to this MR or should be merged for 0.20 first?

Given than you introduce a breaking change, we might as well update this to Yew 0.21. Better one big expected change than two.
I swear I edited your README.md somewhere to clarify it for new users/quick start, but I can't find that anywhere. Does this ring a bell to you? 😅.

I've updated this RP and added the yew update and also ToHtml for BI.
Yes it rings a bell, it's here: https://github.com/alexkazik/yew-bootstrap-icons/pull/1 and I've included many things but not all since it's now structured a bit different.
Should I remove the example icons2 (and rename icons1 to icons) since it's as helpful as I initially thought?

I've tucked into your branch here, but it looks like I can't get your examples/icons1 to compile:
   Compiling icons1 v0.1.0 (C:\Users\Matt\Documents\Development\Rust\yew-bootstrap\examples\icons1)
error[E0277]: `yew_bootstrap::icons::BI` doesn't implement `std::fmt::Display`
 --> icons1\src\main.rs:7:44
  |
7 |
{"I"}{BI::HEART_FILL}{BI::GEAR_FILL}

  |                                            --^^^^^^^^^^^^
  |                                            |
  |                                            `yew_bootstrap::icons::BI` cannot be formatted with the default formatter
  |                                            required by a bound introduced by this call
  |
  = help: the trait `std::fmt::Display` is not implemented for `yew_bootstrap::icons::BI`
  = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
  = note: required for `yew_bootstrap::icons::BI` to implement `ToString`
  = note: required for `VNode` to implement `From<yew_bootstrap::icons::BI>`
  = note: required for `yew_bootstrap::icons::BI` to implement `Into<VNode>`
  = note: 2 redundant requirements hidden
  = note: required for `yew_bootstrap::icons::BI` to implement `Into<NodeSeq<yew_bootstrap::icons::BI, VNode>>`

error[E0277]: `yew_bootstrap::icons::BI` doesn't implement `std::fmt::Display`
 --> icons1\src\main.rs:7:67
  |
7 |
{"I"}{BI::HEART_FILL}{BI::GEAR_FILL}

  |                                                                   --^^^^^^^^^^^
  |                                                                   |
  |                                                                   `yew_bootstrap::icons::BI` cannot be formatted with the default formatter
  |                                                                   required by a bound introduced by this call
  |
  = help: the trait `std::fmt::Display` is not implemented for `yew_bootstrap::icons::BI`
  = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
  = note: required for `yew_bootstrap::icons::BI` to implement `ToString`
  = note: required for `VNode` to implement `From<yew_bootstrap::icons::BI>`
  = note: required for `yew_bootstrap::icons::BI` to implement `Into<VNode>`
  = note: 2 redundant requirements hidden
  = note: required for `yew_bootstrap::icons::BI` to implement `Into<NodeSeq<yew_bootstrap::icons::BI, VNode>>`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `icons1` (bin "icons1") due to 2 previous errors
2023-10-03T23:16:19.760046Z ERROR  error
error from HTML pipeline

Caused by:
    0: error from asset pipeline
    1: error during cargo build execution
    2: cargo call returned a bad status

Your icons2 also fails to compile, for a different reason (use of relative paths, I think):
   Compiling icons1 v0.1.0 (C:\Users\Matt\Documents\Development\Rust\yew-bootstrap\examples\icons1)
error[E0277]: `yew_bootstrap::icons::BI` doesn't implement `std::fmt::Display`
 --> icons1\src\main.rs:7:44
  |
7 |
{"I"}{BI::HEART_FILL}{BI::GEAR_FILL}

  |                                            --^^^^^^^^^^^^
  |                                            |
  |                                            `yew_bootstrap::icons::BI` cannot be formatted with the default formatter
  |                                            required by a bound introduced by this call
  |
  = help: the trait `std::fmt::Display` is not implemented for `yew_bootstrap::icons::BI`
  = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
  = note: required for `yew_bootstrap::icons::BI` to implement `ToString`
  = note: required for `VNode` to implement `From<yew_bootstrap::icons::BI>`
  = note: required for `yew_bootstrap::icons::BI` to implement `Into<VNode>`
  = note: 2 redundant requirements hidden
  = note: required for `yew_bootstrap::icons::BI` to implement `Into<NodeSeq<yew_bootstrap::icons::BI, VNode>>`

error[E0277]: `yew_bootstrap::icons::BI` doesn't implement `std::fmt::Display`
 --> icons1\src\main.rs:7:67
  |
7 |
{"I"}{BI::HEART_FILL}{BI::GEAR_FILL}

  |                                                                   --^^^^^^^^^^^
  |                                                                   |
  |                                                                   `yew_bootstrap::icons::BI` cannot be formatted with the default formatter
  |                                                                   required by a bound introduced by this call
  |
  = help: the trait `std::fmt::Display` is not implemented for `yew_bootstrap::icons::BI`
  = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
  = note: required for `yew_bootstrap::icons::BI` to implement `ToString`
  = note: required for `VNode` to implement `From<yew_bootstrap::icons::BI>`
  = note: required for `yew_bootstrap::icons::BI` to implement `Into<VNode>`
  = note: 2 redundant requirements hidden
  = note: required for `yew_bootstrap::icons::BI` to implement `Into<NodeSeq<yew_bootstrap::icons::BI, VNode>>`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `icons1` (bin "icons1") due to 2 previous errors
2023-10-03T23:16:19.760046Z ERROR  error
error from HTML pipeline

Caused by:
    0: error from asset pipeline
    1: error during cargo build execution
    2: cargo call returned a bad status

I'm going to push the Yew 0.21 change immediately as 0.6.0. I am happy to jump right to 0.7.0 immediately after we do that with limited delay; I think this is best for our end-users using semantic versioning.

I had a different problem (couldn't build yew-0.21) first (all examples).
Then I did a cargo update.
And afterwards I had no problem building all examples (including mine).
Since the Cargo.lock file is not in the repo I can't reproduce your problem.
It is recommended to add the lock file for binaries (the examples) to repos.
And jonhoo also adds then to his libraries so that the CI jobs can work with it. Which is what I have adopted.
I've pushed the changes on the new main.
Also I've removed the icons2 example (I'll re-add it if you want, but I think it's not a good idea).

I'm sorry - I'm used to fix it until it's right.

Hey @alexkazik; I've made some edits. Please review my changes and correct me if necessary. Otherwise, I'd be happy to proceed with merging and releasing as 0.7.0.

Looks good. Though now I'm wondering if the LICENSE should be added to BIFiles as well (and thus also be in the dist of the application)?
If yes, I can put a commit with that together.

Looks good. Though now I'm wondering if the LICENSE should be added to BIFiles as well (and thus also be in the dist of the application)?
If yes, I can put a commit with that together.

I think you're right; binary distributions must have the license as well.
We might have to include several licenses one day, I wonder how we can do that without losing clarity about why each license is included. Folders, I guess?

I've added a few things to a new branch, and are happy to move them here if you want:
https://github.com/alexkazik/yew-bootstrap/commits/icons-license

add license to BIFiles (and copy)
fix clippy warnings
remove BI::empty/default

I've added BI::empty as a shortcut for myself. I don't know if it's a good idea to support an icon and no icon in one.
When removed you have to use Option which looks more matching but probably makes it harder to work with: you have to unwrap_or yourself.
Alternative: feature flag to enable empty
Alternative: support a second type, one with one without empty (BI+BINonEmpty or BI+BIE(mpty))
As removing empty is a breaking change I wanted to bring it up now.

I've added a few more commits to the icons-license branch:

Fix typo
TESTING! use upcoming yew !TESTING
Replace ToHtml implementation with IntoPropValue

The first is just to remove an unbalanced backtick.
Then yew is removing the ToHtml trait (already in master).
The one commit uses the current version and the other fixes the icons implementation for it.
Please tell me which I should add to this PR (or you can pick them yourself).

I've added a few more commits to the icons-license branch:
* Fix typo

* TESTING! use upcoming yew !TESTING

* Replace ToHtml implementation with IntoPropValue

The first is just to remove an unbalanced backtick.
Then yew is removing the ToHtml trait (already in master). The one commit uses the current version and the other fixes the icons implementation for it.
Please tell me which I should add to this PR (or you can pick them yourself).

Please do not add a change in the yew dependency to this PR; one PR per "thing" please. The license change, clippy warnings, typo fixes, and the removal of BI::empty seem worthy.

I've added the mentioned commits to this RP.
The upcoming yew changes are now on icons-upcoming-yew, for later.

I've added the mentioned commits to this RP.

The latest commits I see attached to this PR are on Oct 29, 2023; might have forgotten to push?

The latest commits I see attached to this PR are on Oct 29, 2023;

Thats all right - they are that old ;-)

Thank you for your contribution! This has been published as version 0.7.0.


Update README

Closes #149
Demo

Thank you for doing this. As I said in my reply to #149, I prefer the README as it is for now.


Issues when build android project.

Hey guys, I'm in toubles after add the admob-free.
I'm using Ionic Framework 3.20.0
See errors.
UP-TO-DATE
:app:compileDebugJavaWithJavac
C:\projects\ConcursosParaiba\platforms\android\app\src\main\java\name\ratson\cordova\admob\rewardvideo\RewardVideoListener.java:90: error: method does not override or implement a method from a supertype
    @Override
    ^
Note: Some input files use or override a deprecated API.

Note: Recompile with -Xlint:deprecation for details.
1 error

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 7s
FAILED
27 actionable tasks: 1 executed, 26 up-to-date
(node:2292) UnhandledPromiseRejectionWarning: Error: cmd: Command failed with exit code 1 Error output:
C:\projects\ConcursosParaiba\platforms\android\app\src\main\java\name\ratson\cordova\admob\rewardvideo\RewardVideoListener.java:90: error: method does not override or implement a method from a supertype
    @Override
    ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 7s
    at ChildProcess.whenDone (C:\projects\ConcursosParaiba\platforms\android\cordova\node_modules\cordova-common\src\superspawn.js:169:23)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at maybeClose (internal/child_process.js:925:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
(node:2292) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:2292) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I'm having the same issue too

@wish4129 If you remove the @Override on the line 90 from:
C:\projects\ConcursosParaiba\platforms\android\app\src\main\java\name\ratson\cordova\admob\rewardvideo\RewardVideoListener.java:
The build works fine but my ads appear only in test mode, if I remove IsTesting and set id of the admob, the ads doesn't appears, both banner, interstitial and video.

Same here

Having the exact same issue, my ionic info:
cli packages: (C:\Users\altic\AppData\Roaming\npm\node_modules)

    @ionic/cli-utils  : 1.19.2
    ionic (Ionic CLI) : 3.20.0

global packages:

    cordova (Cordova CLI) : 8.0.0

local packages:

    @ionic/app-scripts : 3.1.10
    Cordova Platforms  : android 7.1.0 browser 5.0.3
    Ionic Framework    : ionic-angular 3.9.2

System:

    Node : v8.11.2
    npm  : 6.1.0
    OS   : Windows 10

Environment Variables:

    ANDROID_HOME : not set

Misc:

    backend : pro

same here

Same here, is there any fix yet ?

Remove new version and install old version to resolve problem ,
ionic cordova plugin add<EMAIL_ADDRESS>its work

Ok, I’ve got a solution to solve this. It’s not as clean as I wanted but it works.
It looks like there is a problem with older versions of google play service.
It’s currently using 11.0.4 but we need something more recent.
I try to update config.xml with the PLAY_SERVICES_VERSION variable but I couldn’t make it work.
So, at the end, I simply edited project.properties and changed these 2 lines:
cordova.system.library.1=com.google.android.gms:play-services-base:11.0.4
cordova.system.library.2=com.google.android.gms:play-services-ads: 11.0.4
to those ones:
cordova.system.library.1=com.google.android.gms:play-services-base:15.0.1
cordova.system.library.2=com.google.android.gms:play-services-ads:15.0.1
15.0.1 is the latest versions at the time of writing. I had to change both lines or it wouldn’t work. I don’t know what the consequences of using a more recent version. Hopefully nothing else is breaking.

@JeanClaudeCottier ur project are showing the ads in production mode?
setting id with ca-app-pub-xxx and isTesting = false?

Getting same Issue With Latest Verison of this plugin any fix available ?

+1

@rafaelblink The problem had nothing to do with production or testing setup. Yes, I'm in production and live. I'm using cordova directly not a 3rd party tool like ionic.

After deleting 90th line from code: C:\projects\ConcursosParaiba\platforms\android\app\src\main\java\name\ratson\cordova\admob\rewardvideo\RewardVideoListener.java This works for me

@ajaymalik14 Good luck getting rewarded videos to work now :)

Remove cast from file src in ionic project:
/plugins/cordova-plugin-admob-free/src/android/rewardvideo/RewardVideoListener.java
Line: 90
@Override in last function
I removed this in the ionic plugins and also in the node_modules,
then removed the android platform and added again, so far so good;

@nilesh52 It worked thanks....

@nilesh52 It worked thanks....

Ok, I’ve got a solution to solve this. It’s not as clean as I wanted but it works.
It looks like there is a problem with older versions of google play service.
It’s currently using 11.0.4 but we need something more recent.
I try to update config.xml with the PLAY_SERVICES_VERSION variable but I couldn’t make it work.
So, at the end, I simply edited project.properties and changed these 2 lines:
cordova.system.library.1=com.google.android.gms:play-services-base:11.0.4
cordova.system.library.2=com.google.android.gms:play-services-ads: 11.0.4
to those ones:
cordova.system.library.1=com.google.android.gms:play-services-base:15.0.1
cordova.system.library.2=com.google.android.gms:play-services-ads:15.0.1
15.0.1 is the latest versions at the time of writing. I had to change both lines or it wouldn’t work. I don’t know what the consequences of using a more recent version. Hopefully nothing else is breaking.

I changed in project.properties, and works for me. thx


Track_Mobile_Phone

Title and Issue number

Title : Track_Mobile_Phone
Issue No. : 23
Code Stack : Basically I use Python and HTML for doing this project....
Close #<issue_no>

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md
[X] I have updated the Index.html file for my contribution

@paulsuryanshu Please add README.md file with your project
Add your project to index.html.md file in your branch
& also please change your PR name to your project name


Don't build components only appearing in test_depends of others as part of world

If a component is only pulled in by an <test_depend> of other components, don't build it as part of world.

@andre-rosa < This issue can be closed, right?

Yes. Actually it didn’t pick up my comment “Fixes #197” at #198 . Thank you!


Dev

Added notebook to create folders and parameter files

Coverage remained the same at 60.487% when pulling 97754b685d1203ffd21f49264b2d7f4b2f8d09d3 on joerischasfoort:dev into 75d557885ff15e49d9fcc82b47ae9763b7cc031c on LCfP:dev.


remove trailing slash

Fix the trailing slash error during auto builds of RPM containers. This problem was introduced by the auth PR.

ACK


Ask for elastic transform support

Elastic transform do well on MNIST and some other image datasets.
However, it is not supported in torchvision.transforms , which make it difficult for me to compose an ideal transformation.
Could u please add this to torchvision.transforms in next verision ?

@fmassa If this is to be added then can I take this up?

@ekagra-ranjan yes, this is on the plans to be added, a PR adding it would be awesome!

A PR adding elastic transform got merged today, so this issue and the other PR can be closed I guess.


Error in post-command-hook (selectrum--minibuffer-post-command-hook): (wrong-type-argument number-or-marker-p nil)

I'm using selectrum with precient.  When I do C-x C-f . (that is, find-file and entering a dot at the prompt so that the complete input is ~/.), I get the following error:
Error in post-command-hook (selectrum--minibuffer-post-command-hook): (wrong-type-argument number-or-marker-p nil)

Inputs such as ~, -, or _ trigger the same error.
This seems to happen only if selectrum-prescient-mode is enabled and I can track it down to the prefix prescient-filter-method.  This is a minimal config for triggering the error.
(use-package selectrum
  :ensure t
  :init
  (selectrum-mode 1)
  :config
  (use-package selectrum-prescient
    :ensure t
    :config
    (setq prescient-filter-method '(prefix))
    :init
    (selectrum-prescient-mode 1)))

GNU Emacs 28.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.23, cairo version 1.17.3) of 2020-11-27

I accidentally used = instead of eql when updating the prefix filter. This should be fixed in #81. Please test that change and report any other problems.
I apologize for this inconvenience.

@okamsn Yes, with your fix in PR #81, the prefix filter works again.  Thanks!


FAPI-4 ci test exec

Validating that pipeline stops execution if any test case fails
Updated the test shell script wrapper to capture the return code of poetry run pytest and return that value

Successful CI run


[ISSUE #436] set JVM options according to JDK version

What is the purpose of the change
Fix for ISSUE #436
Brief changelog
Add the java version check logic in tools.sh and runserver.sh
Verifying this change
verified in macbook and Linux(centos)
To run the following cmds:
sh bin/mqnamesvr
sh bin/mqadmin

Coverage increased (+0.06%) to 42.398% when pulling 16f3f58509e97238a1c1be4443539e8aa5aa197e on walking98:master into 289f0d2ed85d598a7bc84f7fee39c374d55b816d on apache:master.


Fix buildDirectory

Follow up of #28900
Specifically, this change missing a .get(): https://github.com/apache/beam/pull/28900/files#diff-f6fd92149aed337db34a59ef88ca8ed1c7d9aa2371d48e4eb592c36b453eadceR49
causing "${sourceOverridesBase}/main/java" generates a very long directory
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @ahmedabu98

tested locally - let me merge it as it is currently affecting spotless precommit (not triggered in this PR)


[Fix #1062] Correct rake tasks with arguments

When auto-correcting rake tasks to include the :environment prerequisite, account for rake tasks that accept arguments.
closes #1062

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
[x] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Looks good to me. Can you squash your commits into one?

Looks good to me. Can you squash your commits into one?

I was hoping that you would ask! I have squashed my fixes back into the original commit.

Thanks!


[REQUEST] EBNF parsing

This library is amazing and I'm currently using it in TabbyAPI to constrain JSON generation. However, it would also be great if this library can parse EBNF format. This should allow for the ability to specify an abstract grammar, opening for more flexibility.
Currently, I'm using Outlines to accomplish this (it uses the Lark parser under the hood), but it's extremely heavy and slow (and requires another dependency).
Relevant information:
Lark: Grammar documentation (with examples)
Outlines: CFG FSM
Transformers: Pull Request

This could indeed be a great contribution. If someone would create a PR I would review and accept it. Until then, I am leaving this open to see how much demand for it there is. Vote with your emojis!

@noamgat it's been a couple of months, and it looks like there's a lot of demand for this feature. I took a closer look at the implementations I linked in the first issue and it turns out that the creator of the transformers PR created a library here. It would be best to implement the concepts of this library into LMFE since it parses GBNF formatting (which is what most grammars use anyway).
Even though grammars aren't used too much (I personally recommend migrating to JSON schemas), implementing GBNF style formatting from here rather than Outlines EBNF makes most grammar files and tools compatible without rewrites.

Thanks for looking into it. From what I see in the library you posted, that library is token-centric, while LMFE's CharacterLevelParser API is character-centric. I don't know how easy it will be to convert between the two. However, if someone is to find a way to do it and implement it with the CharacterLevelParser API, I will happily approve the PR.

@bdashore3 - Syncode can handle EBNF (full Python grammar, for example)
https://github.com/uiuc-focal-lab/syncode


Activity Dashboard to give insights into plugin quality

Summary
We plan to surface metrics on the activity related to usage and support of plugins on an “Activity Dashboard” for each plugin on the napari hub so that users can gain insight into the Quality of a plugin as evidenced through these metrics.
Outcome
Users will be able to gain insight into the quality of napari plugins better understanding how plugins are used and supported.
How it will work
We will aggregate metrics from public sources, such as PyPI, Github, and image.sc, and display certain metrics on plugin listings under an "Activity" section. Where relevant, we will also surface prioritized metrics in other parts of the napari hub, such as plugin cards, sort and filter, or the revised landing page (e.g. a “trending” section)
Assets

PRD

Tasks
Frontend

[ ] https://github.com/chanzuckerberg/napari-hub/issues/586

Backend

[ ] https://github.com/chanzuckerberg/napari-hub/issues/638

Consider adding condastats as data source as well. The picture drawn from conda download statistics and pypistats is not 100% consistent -> scientifically very interesting ;-)
See also

https://github.com/haesleinhuepf/napari-pypistats/blob/main/conda_download_stats.ipynb

thanks @haesleinhuepf !! that's a great callout. tracking it here: https://github.com/chanzuckerberg/napari-hub/discussions/805


refactor: use TypeScript custom transformers for resource inlining

I'm submitting a...
[ ] Bug Fix
[ ] Feature
[x] Other (Refactoring, Added tests, Documentation, ...)

Checklist

[ ] Commit Messages follow the Conventional Commits pattern

A feature commit message is prefixed "feat:"
A bugfix commit message is prefixed "fix:"

[ ] Tests for the changes have been added

Description
See #261
Does this PR introduce a breaking change?
[ ] Yes
[x] No

IDEA: I can still use the TypeScript AST to do the resource inlining.
Then have a ts.TransformationResult<ts.SourceFile> and then ... create a new ng.Program
  ng.createProgram({
    host: ng.createCompilerHost({
      options: tsConfig.options,
      tsHost: /* XXX aCustomCompilerHostThatReadsSourcefilesFromTransformationResult */
    }),
    rootNames: [ ...tsConfig.rootNames ],
    options: tsConfig.options
  })

Bonus: I can limit resource inlining to project files included in the library (do not traverse AST for source files from node_modules)
Bonus: check for correct imports from @angular/core like import { Component as foo } ... or import * as ng

valuable source: ast-util.ts in angular devkit: https://github.com/angular/devkit/blob/master/packages/schematics/angular/utility/ast-utils.ts#L127-L128

Current workaround: explicitly call ts.transform() and apply AST transformation for templateUrl (still TODO: styleUrls). Then create a custom ts.CompilerHost that reads ts.SourceFile from ts.TransformationResult<ts.SourceFile> generated in previous step.

Current Status / TODOs:

[ ] fix secondary entrypoint package.json output
[ ] filter *.ts source files from node_modules / from outside source directory before traversing the AST

source map<EMAIL_ADDRESS>...

Travis stuck for unknown.


Translate into Polish

files Required translation:

def/pl/about.cson
def/pl/context.cson
def/pl/menu_darwin.cson
def/pl/menu_linux.cson
def/pl/menu_win32.cson
def/pl/settings.cson

for more info please checkout CONTRIBUTING.md

@Jeplaa I am so glad that you notice Polish.
It's really welcome to contribute even it's little.

NOTE for myself:

[ ] add locale pl in validation.js after this PR is merged


Disable tls verification

How do I disable the tls verification?
I'm getting this error:
tls: failed to verify certificate: x509: certificate signed by unknown authority

@guilhermelff did you find a solution to this issue yet?

based on this issue within the imported go-gitlab repo, you can use a custom WithHTTPClient ClientOptionFunc (code) to set the SSL options you want.
Im not native to GoLang, but I believe it could look something like this...
func New(logger *log.Logger, gitlabToken string, gitlabBaseURL *url.URL, committerName, committerEmail string,
) (*App, error) {
    customTransport := &(*http.DefaultTransport.(*http.Transport)) // make shallow copy
    customTransport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
    client := &http.Client{Transport: customTransport}

    gitlabClient, err := goGitlab.NewClient(gitlabToken, goGitlab.WithBaseURL(gitlabBaseURL.String()), **goGitlab.WithHttpClient(client)**)
    if err != nil {
        return nil, fmt.Errorf("create GitLab client: %w", err)
    }
...


cancelOperationAndDiscardItemWithCompletion: does not work as expected

initWithSerializedItem: (https://github.com/Azure/azure-mobile-apps-ios-client/blob/f0c4b229dcab29cb5d75c1cb7a201c81c862a8df/sdk/src/MSTableOperationError.m#L82) does not set self.operationId and as as a result, operationId is always 0.
This means cancelling operations never works!

Hello,
Are there any plans for fixing this problem? In our project we try to cancel operation, when sync to server fails due to, for example, data validation error. We catch such error and call cancelOperationAndDiscardItem which ends successfully (without errors), but as stated above, canceling and discarding is not really happening. As result a faulty item is still present in local DB and during next sync server throws validation error again. And it continues in a loop.
Best regards,
Sergej Semeniaka

@adrianhall where was this issue transferred to?

@yumoraby This issue was transferred TO GitHub when we went full open source.  It's still an open issue.  I, however, am no longer involved with this project.

@yumoraby This issue was transferred TO GitHub when we went full open source. It's still an open issue. I, however, am no longer involved with this project.

Thanks Adrian who now maintains this repo, as it has not been updated for a while. I am new to GitHub and Open Source world.

@elamalani, could you provide a reply when you have a chance?

@yumoraby Thanks for using Azure Mobile Apps. Unfortunately, we are not doing any active development or changes in this product. I'm sad to say that it's not in our top priority to fix this issue at this time. I'd recommend you to please fork this repository and fix it if you would like.


Can one do transactions with this?

Warthog appears very suitable for a project I am focusing, however I need support for transactional mutation of the database when adding data to it programmatically (not through the GraphQL API). Is this possible, if so how?

See https://github.com/goldcaddy77/warthog/issues/94 .  This should be possible - need to determine how many tough points there would be porting to TransactionRepository

What kind of project are you kicking off?

Here are docs to how typeorm (and therefore Warthog) does Transactions: https://github.com/typeorm/typeorm/blob/master/docs/transactions.md#transaction-decorators
I'll work on getting an example in place.

Thank you for the very fast response, really appreciate it.
We are building a query server for a blockchain project (https://github.com/Joystream/), and we are looking for a database/GraphQL API infrastructure that limits the amount of boilerplate we have to maintain. I have been trying out Prisma (1) the last week. Its OpenCrud API and generated CRUD ORM were excellent, but in the end, it is missing database transactions. They have some longstanding open issues on this, but they have not been tended to in a very long time, and in general, there is a great deal of uncertainty around Prisma 2 arrival and eventual transactional support.
An example would be really wonderful because there are a lot of moving parts here, and I am new to just about all of them (TypeORM, TypeGraphQL, etc.).
Have you ever considered opening up a Gitter channel or something similar? It would make it even easier for people to get started, and third parties to help each other.

Very cool - yeah this sounds like a perfect use case for you. I do have a Gitter - you can find me here: https://gitter.im/warthog-graphql/community?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge

All set, see https://github.com/goldcaddy77/warthog/pull/319/files#diff-0ef73fed426f71bd2379b3f18e90243aR1 for first-class support in Warthog.  Note that you can always drop down to using TypeORM directly and use the tools here: https://github.com/typeorm/typeorm/blob/master/docs/transactions.md .  Note that you would need to do your own validations, though (something that BaseClass handles).

Fantastic, I really appreciate it. Looking forward to trying this out, will let you know how it turns out.

Perfect, sounds good.

Fix merged and documentation added to README.


Which string passing method has less overhead?

I would appreciate if someone could clear this for me.
I wonder which one of these two ways of passing strings from Rust has less overhead?
I'd assume call_2/example_2 is more expensive do to allocation on the Rust side (.to_string()) and then a second allocation on c++ side (auto str = std::string(s)).
call_1/example_1 on the other hand creates a C++ string on stack according to the docs, does it mean there's not allocation happening at all? Even for &[u8] ?
#[cxx::bridge]
mod ffi {
    unsafe extern "C++" {
        fn example_1(s: &CxxString);
        fn example_2(s: &str);
    }
}

fn call_1(s: &str) {
    let_cxx_string!(cxx_s = s);
     ffi::example_1(&cxx_s);
}
fn call_2(s: &str) {
    let s = s.to_string();
     ffi::example_2(&s);
}

Use on the other side:
void example_1(std::string &str) {
    some_func(str);
}

void example_1(rust::Str str) {
     auto _str = std::string(str);
     some_func(str);
}

Thanks!

If this matters for your use case, then you would need to benchmark on data that is representative of your personal use case. This sort of thing depends on the data and the build flags being used.

In call_2, there's no need to call .to_string() at all, as example_2 takes &str to begin with. For let_cxx_string!, it constructs a std::string on the Rust stack, but that std::string may itself contain a heap allocation if its small string optimization does not apply. Thus, with a properly written
#[cxx::bridge]
mod ffi {
    unsafe extern "C++" {
        fn example_1(s: Pin<&mut CxxString>);
        fn example_2(s: &str);
    }
}

fn call_1(s: &str) {
    let_cxx_string!(cxx_s = s);
    ffi::example_1(cxx_s);
}
fn call_2(s: &str) {
    ffi::example_2(s);
}

void example_1(std::string &str) {
    some_func(str);
}

void example_2(rust::Str str) {
     auto _str = std::string(str);
     some_func(_str);
}

there are the same number of copies/allocations: one, to go from &strRust to std::stringC++.
Generally, if you have full control over the FFI border, it's probably better to send &strRust, as that gives the C++ side more options what to do with it.

There is one case where using &str is definitely going to be better, though: if some_func accepts std::string&& (an rvalue "move" reference). Then, by writing example_2 as
void example_2(rust::Str str) {
     some_func(std::string(str));
}

you allow the C++ code to effectively take ownership of the std::string constructed here.

Of course, this is exclusively looking at copies/allocations, and this may not actually be the correct answer depending on your exact configuration and workload. Get something that works first, then benchmark and see if it's even worth spending effort optimizing.

I ended up using both methods. Whenever possible, I call methods directly on extern types ( those which take self: & Type, s: &CxxString) I use let_cxx_string!, otherwise &str which is generally more convenient.
It's not a hot loop in my case so in the end it really doesn't matter which method is more optimal.
P.S. Couldn't property benchmark it coz I'm wrapping a network library and it's to much hassle to do.
Thanks guys!


Inner/outer attribute confusion in the parser

related https://github.com/rust-analyzer/rust-analyzer/issues/8126


Add SharedFuture

Mostly just a wrapper around Async++'s shared_task: https://github.com/Amanieu/asyncplusplus/wiki/Tasks#shared-tasks
This is needed for the raster overlay changes, and is a useful capability in general.
Builds on #285 so merge that first.

Thanks @kring! this looks good to me overall. There is a compiling error when tracing enables. Once it's fixes, I think we can merge this

@baothientran I fixed the compile errors. Tracing is not going to work very well with shared futures, though, because the multiple continuations will all run in the same "track" and chrome://tracing will get confused. Solving this will be tricky, and I don't think it needs to hold up this PR.

@kring is that happening even with regular Future without using another track (e.g when we call CESIUM_TRACE_USE_TRACK_SET(loadingSlot))? Below is the test case when using two tracks ( CESIUM_TRACE_USE_TRACK_SET is used twice for two different futures)
class MockTaskProcessor : public ITaskProcessor {
public:
  std::atomic<int32_t> tasksStarted = 0;

  virtual void startTask(std::function<void()> f) {
    ++tasksStarted;
    std::thread(f).detach();
  }
};

TEST_CASE("AsyncSystem") {
  std::shared_ptr<MockTaskProcessor> pTaskProcessor =
      std::make_shared<MockTaskProcessor>();
  AsyncSystem asyncSystem(pTaskProcessor);

  SECTION("conversion to SharedFuture") {
    CESIUM_TRACE_INIT("C:\\Users\\bao\\Documents\\trace.json");
    {
      CESIUM_TRACE_DECLARE_TRACK_SET(loadingSlots, "Future");
      CESIUM_TRACE_USE_TRACK_SET(loadingSlots);
      auto firstPromise = asyncSystem.createPromise<int>();
      auto firstFuture = firstPromise.getFuture();

      bool executed1 = false;
      auto one = std::move(firstFuture)
                     .thenInWorkerThread([&executed1](int value) {
                       CESIUM_TRACE_BEGIN_IN_TRACK("Future One")
                       CHECK(value == 1);
                       CHECK(!executed1);
                       return 2;
                     })
                     .thenImmediately([](int value) {
                       CESIUM_TRACE_END_IN_TRACK("Future One");
                       return value;
                     })
                     .thenInWorkerThread([](int value) {
                       CESIUM_TRACE_BEGIN_IN_TRACK("Future One 2nd")
                       return value;
                     })
                     .thenImmediately([](int) {
                       CESIUM_TRACE_END_IN_TRACK("Future One 2nd")
                     });

      CESIUM_TRACE_USE_TRACK_SET(loadingSlots);
      bool executed2 = false;
      auto secondPromise = asyncSystem.createPromise<int>();
      auto secondFuture = secondPromise.getFuture();
      auto two = std::move(secondFuture)
                     .thenInWorkerThread([&executed2](int value) {
                       CESIUM_TRACE_BEGIN_IN_TRACK("Future Two")
                       CHECK(value == 1);
                       CHECK(!executed2);
                       return 2;
                     })
                     .thenImmediately([](int value) {
                       CESIUM_TRACE_END_IN_TRACK("Future Two");
                       return value;
                     })
                     .thenInWorkerThread([](int value) {
                       CESIUM_TRACE_BEGIN_IN_TRACK("Future Two 2nd")
                       return value;
                     })
                     .thenImmediately([](int) {
                       CESIUM_TRACE_END_IN_TRACK("Future Two 2nd")
                     });
      firstPromise.resolve(1);
      secondPromise.resolve(1);

      one.wait();
      two.wait();
    }

    CESIUM_TRACE_SHUTDOWN();
  }
}

With this test, I got the tracer to produce two different tracks like below (trace.json.txt):

Then, I try to use one track only by comment out the second use of CESIUM_TRACE_USE_TRACK_SET in the test below, and chrome produces a different input which seems to make less sense compared to the one above (trace.json.txt):

For the second one, I would expect the order of: waiting for worker thread...Future One...waiting for worker thread...Future One Two for the first continuation. The second continuation is similar. But in the second one, the order is a little mixed. Not sure if I miss something
I modify the test above to use the share future and give the same results as well

Right, you have two threads of work happening in one track. A track is a single sequential flow, like a thread (but it's allowed to cross threads). Chrome will try to interpret the events in this light, leading to something between weirdness and total brokenness. SharedFuture just makes it a little easier to accidentally end up in this situation.


Window - Pass winit results

Based on Mouse grab issue thread 'main' panicked #112
This change makes usage a bit less friendly, but give us options to react on errors.
It have some breaking changes.

closes #112


Templates use lower filter on values where it should not

Describe the bug
Within some of the templates the lower filter is used where it should not be.
The affect components are:

Exit this page
Select

In the "Exist this page" component, the lower filter is being applied to the attributes tag:
{{ attribute }}="{{ value | lower }}"{% endfor %}

As the user passes in the attributes we should not mutate what they are otherwise there could be unexpected consequences.
I realises this was required to pass a test but perhaps the test needs to be updated (can be extended as part of my work in https://github.com/LandRegistry/govuk-frontend-jinja/pull/81)
In the "Select" component, the lower filter is being applied to the value:
<option {%- if item.value is not undefined %} value="{{ item.value | lower }}"{% endif %}

Again, as the user passes in the values we should not mutate them are otherwise there could be unexpected consequences (which is how I discovered this bug).
Expected behavior

The "Exit this page" component should not lower the attributes passed by the user
The "Subject" component should not lower the values passed by the user

Additional context
I'm happy to help and contribute to this project so if you want to make changes I can

Any updates on this? We also require the removal of 'lower' from the options tag as it affects how we process the user selections for certain data sets


Image: unified cropping constructor

Instead of 4 different cropping constructors, unify them into a single constructor.  This simplifies the code and also "flattens" the image structure when different sides of the image have been cropped.
Note: this is not intended as a performance optimisation and I have not measured the performance impact.  Rather, I was wanting to learn more about vty internals and noticed this cleanup opportunity.  I humbly submit the current patch for your consideration but no hard feelings if you prefer to leave things as they are.

Thanks!


Improve apply method

Problem description
Code using the widget apply method get's very verbose very quickly. It's also error-prone.
Expected behavior
Some API changes could help.

Consider supporting a new signature: apply(property, {[selector]: propertyValues});
Allow excluding selected properties from being affected by apply, such as those set by JSX or constructor

However, we should also consider that the apply method may not be the best solution for what we are using it for. Using factories/JSX with stateless functional components (https://github.com/eclipsesource/tabris-js/issues/1680), global defaults/aliases (https://github.com/eclipsesource/tabris-js/issues/1674) and other improvements in layout API (https://github.com/eclipsesource/tabris-js/issues/1677) we may also want to consider leaving the method alone for now.
Environment
any
Code snippet
this.apply('textColor', {'#widgetA': 'red', '#widgetB': 'blue'});

Close this issue in favor of improving selector API.


Add benchmark script

Closes #44

Codecov Report

Merging #46 (f40cc5b) into master (05df374) will decrease coverage by 3.54%.
The diff coverage is 65.00%.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   60.93%   57.38%   -3.55%
==========================================
  Files          11       16       +5
  Lines         919     1279     +360
  Branches      198      259      +61
==========================================
+ Hits          560      734     +174
- Misses        302      474     +172
- Partials       57       71      +14

Impacted Files
Coverage Δ

andersoncd/tests/test_docstring_parameters.py
75.36% <ø> (+10.86%)
:arrow_up:

andersoncd/logreg.py
37.97% <28.12%> (-18.71%)
:arrow_down:

andersoncd/lasso.py
37.33% <37.50%> (-21.52%)
:arrow_down:

andersoncd/group.py
62.40% <39.28%> (-11.79%)
:arrow_down:

andersoncd/penalties.py
40.17% <40.17%> (ø)

andersoncd/utils.py
32.87% <52.38%> (+12.66%)
:arrow_up:

andersoncd/data/synthetic.py
72.41% <69.23%> (-18.50%)
:arrow_down:

andersoncd/solver.py
79.50% <79.50%> (ø)

andersoncd/plot_utils.py
64.44% <87.50%> (+26.94%)
:arrow_up:

andersoncd/__init__.py
100.00% <100.00%> (ø)

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edafde8...f40cc5b. Read the comment docs.


Fix database corruption problem on ddev rm

The Problem/Issue/Bug:
In the recent Drupal-2-geddon updates I noted that a few of my sites (perhaps with larger dbs) would fail to start after ddev start, ddev import-db, ddev rm, ddev start. After further investigation I found that there was database corruption as described in https://github.com/drud/ddev/issues/748 (which is about the situation of a reboot or docker exiting).
How this PR Solves The Problem:

We weren't stopping containers before forcing their removal, so db container didn't get a chance to clean up and exit correctly. I'm sure we used to, but in our effort to clean up when docker-compose.yaml is missing, we apparently removed that.
Added to docker-compose.yaml an increased exit timeout for the db container (default is 10s, that normally is totally adequate, but it doesn't do any harm to have it higher).

Manual Testing Instructions:
With a larger site (larger db) do ddev start, ddev import-db, ddev rm, ddev start. It should work without trouble.
Automated Testing Overview:

I can write a test for this, but it seems quite heavyweight. Not sure.
Related Issue Link(s):
Definitely relates to #748, which is about corruption when docker goes away (like at reboot of host). This PR does not solve #748.
https://github.com/drud/mariadb-local/pull/52 was a PR aimed at fixing #748 (it failed, but was interesting).
Release/Deployment notes:

@rfay I see the @cweagans approved. I can't manually test until tomorrow or Monday... or I can wait for the end-user testing on v0.17.0 review.

I'll probably need to use devel to bloat up the DB to a certain threshold and then I can test.


⚠ Jenkins Plugins Artifactory has degraded performance

In 991a35b, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1287 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 2d1f1b5 after 17 minutes.


Tasks of common modules appear repeatedly

Extension Name: vscode-gradle
Extension Version: 3.6.1
OS Version: Windows_NT x64 10.0.17134
VSCode version: 1.57.0-insider (system setup)
Describe the bug
Tasks of common modules appear repeatedly
To Reproduce

common module ampub
main moudle fa dependent ampub

Expected behavior
The task of the common module only appears once
Screenshots

Output from "Gradle Tasks"
You can find this by clicking on the "Output" panel, then selecting the "Gradle Tasks" channel from the dropdown.
Does the bug still exist if you disable all other extensions?
Yes
Additional context
Add any other context about the problem here.

I encounter this earlier.  While i trying to recall how i solved that, can i ask if u are using nested gradle projects

could you provide a sample project to help us reproduce this issue?

could you provide a sample project to help us reproduce this issue?

@CsCherrYY I modify project construct . No problems! Thanks for your notice!


SWITCHYARD-2865 : Remove obsoleted DoubleCheckedLocking Checkstyle check

Remove obsoleted DoubleCheckedLocking Checkstyle check.    Also fixed a minor checkstyle issue.
https://issues.jboss.org/browse/SWITCHYARD-2865

ok to test

Pushed.


First() and RecordNotFound() error

if i write like this:
db.Where("openid = ? ", "222").First(&user).RecordNotFound() {

the sql is
 SELECT * FROMusers WHEREusers.deleted_atIS NULL ANDusers.id= '1' AND ((openid = '222')) ORDER BYusers.idASC LIMIT 1
it is error
when i change it like this:
tmp := db.Where("openid = ? ", "222").First(&user)
tmp.RecordNotFound()

the sql is
SELECT * FROM `users`  WHERE `users`.`deleted_at` IS NULL AND `users`.`id` = '2' AND ((openid = '222')) ORDER BY `users`.`id` ASC LIMIT 1

it's right.
it seem this is a bug. I use the code from master

Hey there, @georgehao . Could you post some more context (e.g: a runnable demo code snippet that reproduces your issue) of the bug you're facing? What DBMS (PostgreSQL,MySQL, etc) you're running on might be useful to know, too. It would be helpful for the debugging process.
I'm assuming the error is that the query should have search for a user with the id of 2, and not a user of the id of 1? Have you already populated the fields of the user variable, or is it just a blank struct when you're running these code snippets?
Note that the First method will consider the argument that you're passing to it (user, in this case) as a query condition.
So if user had an "id" field of a value of 1, it would produce the first query that you showed us (SELECT * FROM users WHERE users.deleted_at IS NULL AND users.id= '1' AND ((openid = '222')) ORDER BY users.id ASC LIMIT 1 ).
Likewise  if user had an "id" value of 2, it would produce the second query you showed us (SELECT * FROM `users`  WHERE `users`.`deleted_at` IS NULL AND `users`.`id` = '2' AND ((openid = '222')) ORDER BY `users`.`id` ASC LIMIT 1).

seems the user you passed into First already contains a primary key?


Can I upload a file to specific folder on google drive? Old command is gdrive upload -p

Not yet, but will be implemented soon.

v3.0.0-alpha8 supports --parent <id>


python312Packages.rdkit: 2023.09.5 -> 2024.09.1

Diff: https://github.com/rdkit/rdkit/compare/Release_2023_09_5...Release_2024_09_1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 349694 at 47104b52 run on x86_64-linux 1

:white_check_mark: 4 packages built:

python311Packages.meeko
python311Packages.rdkit
python312Packages.meeko
python312Packages.rdkit


Text should be resizable

It should be possible to change the font size.

I think it would have something to do with the style parameter for the add method used to create ui elements.  Takes a string or a LuaStyle object.
I've never worked in lua before, much less modding factorio, but I've been wanting to get into it. Maybe I'll try to tackle this as a first project.

Sure :) feel free to open a pull request :)
Am 26.07.2018 6:53 nachm. schrieb "Michael D. Hoyle" <
<EMAIL_ADDRESS>I think it would have something to do with the style
https://lua-api.factorio.com/latest/LuaGuiElement.html#LuaGuiElement.style
parameter for the add method used to create ui elements. Takes a string or
a LuaStyle https://lua-api.factorio.com/latest/LuaStyle.html object.
I've never worked in lua before, much less modding factorio, but I've been
wanting to get into it. Maybe I'll try to tackle this as a first project.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JonasJurczok/factorio-todo-list/issues/41#issuecomment-408163270,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFsdF4m9dj_hGB-fP5vwilaluOCz_aaks5uKfQfgaJpZM4Vfl8C
.

in #44, I just tweaked the styles a bit, but I'm thinking this could be implemented with a setting: Choose a UI style: normal (what it is now, or what is is in #44) or compact (smaller font size/padding etc)

Initially I thought about a text box to choose a font size. But maybe
that's too much/not possible?!
Michael D. Hoyle<EMAIL_ADDRESS>schrieb am Di., 7. Aug. 2018,
20:15:

in #44 https://github.com/JonasJurczok/factorio-todo-list/pull/44, I
just tweaked the styles a bit, but I'm thinking this could be implemented
with a setting: Choose a UI style: normal (what it is now, or what is is in
#44 https://github.com/JonasJurczok/factorio-todo-list/pull/44) or
compact (smaller font size/padding etc)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JonasJurczok/factorio-todo-list/issues/41#issuecomment-411151708,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFsdJAM7CmNP-kfBdi21tTvzZpNgi1Lks5uOdk2gaJpZM4Vfl8C
.

That would work, but there's a couple different text sizes in use (So headings look like headings), and things like button height may need to adjust with it.  So all of that would have to be computed from the user-selected font size, which really expands the potential error space.  We could allow each value to be set individually, but that's a lot to ask of the average user.
But if we just had say, 3 UI sizes that we've chosen and tested, They just have to pick one and they're good to go.

That's a good point. I thought about leaving all the headings as they are
and just make the normal text size adjustable. If I understood the button
documentation correctly it should automatically change size with the font.

The work to do here is just to get a way to choose which style to use, right ?

Yeah, you could have a setting to choose a size, and then have that setting determine which style to use when creating UI elements.

Yep. This was requested by a user. Maybe for really high/low resolutions the current default might be a problem.

Then @JonasJurczok can you add a pririty tag so we'll fix this quickly.

I don't know if this is actually urgent :) I view it more as a "nice to have"


Add game streaming compatibility API

Intended to be merged with a similar pull request against the extension (tfedor/AugmentedSteam#779).
cron/streaming.php will need to be added to cron.
E: keeping the endpoint a "secret" as it seems that you do that for the other endpoints listed. You can find the URL by navigating to the "find a game" page and inspecting outgoing XHRs for a static.nvidiagrid.com URL.

I think the "secret" is out

Not the point. The code has all of the third-party endpoints listed in a configuration file to be filled in. I'm just following the example given, if the maintainer wants it a different way I can do that.


Typo in mesher.py & added dependencies to aeroprint_setup.bash

Not going to merge the dependency stuff, just fix the typo for practice using pull requests and closing out my personal branch.

These changes can be ignored

Meant to put this under just aeroprint_setup.bash


BDC Dashboard: Show error message if cluster is down

Version 1.13.0-insider (today's)
After downloading latest insiders, a cluster was down, and the entry for the controller endpoint persisted in the BDC viewlet. When I clicked right-click manage, there wasn't an indication that there was an error. Let's show an indication if user is unable to open dashboard.

Dupe of https://github.com/microsoft/azuredatastudio/issues/7721


Typo?

https://github.com/wechaty/python-wechaty/blob/0eaebb04826cd45031802b4dd76137f48d8a13c6/src/wechaty/user/contact.py#L293
Maybe it is:
if self.payload is None or self.payload.friend is None:
It doesn't affect the result of the method but not beautiful.

 It will be improved later. Thanks for your issue to describe it.

Fixed in Master Branch.


Message not sent to multiple users

Hello folks,
I am trying to send a user to more than one user, like this:

I also tried without the pipe and with line breaks, no luck. Is this a bug or I just don't know how to use it?

@leandroBorgesFerreira  are you using a webhook by any chance? That has to be created for specific channels in mind and will only work for those. In case you are using a bot token, is it working for channels or not at all?

Yes, I am using webhooks. It works for channels as long as you don't have more than one. It also works for users as long as you don't have more than one.
The problem I see is: It works for single users/channels, but it doesn't work for more than one.
Sorry for the late response!

Could you send us examples of this happening? As this shouldn't be expected, according to the official Slack documentation here, webhooks are created for specific channels and users and will only work for that channel or use it was created for.


Update to lockfile version 2 (npm 7).

https://github.blog/2021-02-02-npm-7-is-now-generally-available/

Codecov Report

Merging #197 (c6dd238) into master (3973756) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   84.14%   84.14%
=======================================
  Files          15       15
  Lines         473      473
  Branches       49       49
=======================================
  Hits          398      398
  Misses         75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3973756...c6dd238. Read the comment docs.


Updating the board does not properly recalculate the encoded board

Start with an empty 10x10 board: the encoding is KKya
Set the upper left corner to a wall: the encoding is KKAnGA
Set the upper left corner back to empty: the encoding is KKAjGA rather than KKya

The issue is likely in encodeRle where the current tile is compared to the previous tile using !==. This will be false if the compared objects are not referentially equivalent, which they are unlikely to be. encodeRle should take a comparison function.

Fixed by #11


Image size compression

Image size compression

I'm going to close this PR as it seems stale, @Skdahale feel free to reopen if you are still working on this PR


Upgrade to Go 1.18+

Generics!

Done in https://github.com/binwiederhier/ntfy/commit/bddde5c637c470dc6297751294571843ba5990fd


Add --arch when running podman to allow running on ARM machines

As suggested by @jschuler add a --arch=amd64 flag to allow running the console pod using podman on an ARM machine, such as macos

cc:// @sgratch @jschuler

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.16%. Comparing base (13484d0) to head (7e9b367).
Report is 114 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1380      +/-   ##
==========================================
- Coverage   36.81%   36.16%   -0.65%
==========================================
  Files         158      158
  Lines        2548     2577      +29
  Branches      599      601       +2
==========================================
- Hits          938      932       -6
- Misses       1428     1630     +202
+ Partials      182       15     -167

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LGTM! Thanks @yaacov


Fix examples

closes #110

Yay now it correctly fails. Still gotta actually fix the examples though...

@drnimbusrain any new features to highlight in the 1-D examples?

@drnimbusrain any new features to highlight in the 1-D examples?

@zmoon Thank you for working on these updates!  Most recently we have been working on the biogenic emissions, and have added a number of new options that I think could be added and useful for 1-D examples.  See the new biogenic options, loss_opt,  leafage_opt,hist_opt, and soim_opt.

@drnimbusrain I think we can address that in a separate PR, keep this one simple.


Migrate deployment method from the blog repo

It migrates deployment method from the blog repo, but also allows to start server locally (for debugging purposes)

@fabiosantoscode I'm not sure that ESLint can check it. Do you know such rule?

This here rule checks for usage of undefined variables: https://eslint.org/docs/rules/no-undef#top

I think we need to get rid off express server as a backend, SSR and custom scripts for deployment. So deployment method will be based on CI orb

@JIoJIaJIu due to the long-expiring cache headers, the express server only serves the requests once, and then cloudflare handles revalidation from clients.


Support headers in SubscriptionDataSource

It is not uncommon that a web service would require some form of authentication headers to be provided. This change aims to enable this by adding the header information to the source. This design
allows a user's custom data type to return the source properly hydrated with the required header values before being sent back through the rest of the LEAN infrastructure.

@Jay-Jay-D


Seroter branch

This branch is 350 commits behind master, hence the build failures.
https://github.com/CenturyLinkCloud/PublicKB#merging-an-upstream-repository-into-your-fork


Transformando as strings de posições e status em unicode

Coverage remained the same at 96.377% when pulling 560573bb4954bd6f5c90dca8d0d30c642d3eb74e on dev into ea4f617914be0f3a947969bce8f4be15ee9cf287 on master.


Show plan in assertion message if test fails

This PR simply updates an assertion message to include the plan that caused the assertion to fail. This will hopefully help us better understand what is causing https://github.com/NVIDIA/spark-rapids/issues/473

I have signed the commits now.

build


Netsh technical reference is obsolete

I am reopening #6951.
The link to the netsh technical reference now points to obsolete information from 2012, related to past versions of Windows:

Netsh Command Reference
Article • 07/02/2012 • 2 minutes to read
Applies To: Windows 7, Windows Server 2008, Windows Server 2008 R2, Windows Vista

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cdf15d6d-c63e-6ec4-d1c0-bb800eec7f12
Version Independent ID: 595b6b57-f169-e38d-35d7-91eaa3b33610
Content: Network Shell (Netsh)
Content Source: WindowsServerDocs/networking/technologies/netsh/netsh.md
Product: windows-server
Technology: networking
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


"As long as your datasets do not exceed this value"- context

I think this statement may be technically correct, but does not send the most useful message to the end user since it does not make any reference to refreshing the data. A full refresh of an imported dataset will cause the size of the dataset to double during the refresh process (source: https://learn.microsoft.com/en-us/power-bi/connect-data/refresh-data#datasets-in-import-mode)
Evaluating a dataset's size using the method recommended in this article will not show that the dataset size will double on refresh. I've heard the argument that not all import data needs to be refreshed, but I would argue that those situations are outliers and not typical.
If I followed the instructions in this article to get dataset size and took the statement "As long as your datasets do not exceed this value" at face value, I would not account for refresh and could end up under sizing the capacity. Of course, you can always increase the capacity, but this can be an issue if $5k was budgeted per month and now you need to go back and ask for $10k or more.
Is there a way to make it more clear that if you need refresh capability on import data (which I would argue many if not most organizations need), you cannot have a model size that goes up to the limit of the capacity? In my experience, this issue is confusing to users looking at Microsoft documentation to try to understand what capacity they might need.

For example, if you have a P1 SKU, datasets are supported up to a limit of 25Gb. As long as your datasets do not exceed this value, the SKU should meet your needs.
...
You can evaluate a typical dataset’s size by measuring the memory footprint of the Power BI Desktop tool.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f728b16f-4072-f818-5b3d-9ce27968e7df
Version Independent ID: f728b16f-4072-f818-5b3d-9ce27968e7df
Content: Manage Microsoft Power BI Premium Gen2 capacities - Power BI
Content Source: powerbi-docs/enterprise/service-premium-capacity-manage-gen2.md
Service: powerbi
Sub-service: powerbi-premium
GitHub Login: @KesemSharabi
Microsoft Alias: kesharab

Thanks for your comment, @djurecic0. This issue has been assigned to the doc author for review.

Hi @djurecic0,
I made some changes to Planning your capacity size in advance to reflect the issue that you raised.
Thanks,
Kesem

Hi @KesemSharabi ,
Thank you for making the changes. This recent blog post makes it even more explicit:
https://powerbi.microsoft.com/en-us/blog/announcing-the-public-preview-of-power-bi-dataset-scale-out/
"When selecting a Premium SKU, the amount of memory required to refresh a dataset must be accounted for in addition to the target dataset size in memory. This typically limits the dataset size to approximately 50% of the max. available memory per dataset. "