fix: typos in challenge description

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #47738

This issue already has a PR open, so I am closing this PR

Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 🎉


Revert "fix(chat): fix 'Not Found' error during lib publishing(Issue #1270)"

Reverts epam/ai-dial-chat#1374

Hey there and thank you for opening this pull request! 👋🏼
We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
No release type found in pull request title "Revert "fix(chat): fix 'Not Found' error during lib publishing(Issue #1270)"". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - fix
 - hotfix
 - feat
 - feature
 - chore


ISSUE-24 Fix property name and have parser catch it

The BuildDocument call was not checking against the set package comment
property. This property was additionally set incorrectly to "Comment:"
instead of "PackageComment:"
This still outputs
The following verifications failed for the SpdxDocument:
	Invalid date format: Unparseable date: "2015-06-16 12:09:53.533268"
	Missing required license text for LicenseRef-CCPL
	Missing required license text for LicenseRef-ZPL
	Missing required license text for LicenseRef-MIT-style
	Missing required license text for LicenseRef-MIT-possibility
	Missing required license text for LicenseRef-Python
	Missing required license text for LicenseRef-MPL

but appears to generate a valid RDF file. This will resolve issue #24
Unfortunately I had issues trying to set up a unit test to parse a file and prevent this from being broken in the future - any pointers towards existing tests which attempt to parse "*.tag" files would be welcome
My contributions are provided under the Apache 2.0 license as required for contributions to this project

Also, I have no idea why my Eclipse insisted on "changing" so many lines in BuildDocument - some sort of source formatting which I could not track down. The only thing actually changed in that file was the addition of 3 lines to parse the package comment

Merged into git.spdx.org - should be sync'd up soon.
Thanks for the fix!


Edit the empty dashboard's text

Iteration on the dashboard's empty state. The text has been iterated to:
"Start a new application, applications can be saved and edited until the intake closes on YYYY/MM/DD"
This sets the expectation that applications do not need to be finished in 1 go and a reminder of when the intake closes
The button and text placement have been swapped so that the order of the page is page title, page description, button, to be consistent with all of the other pages.

@MarsRomer Would it be possible to move this improvement ticket into one of the sprints?

@zoeyli-46 yes lets add it to the dashboard ticket


Suggestion for addition features to roadmap

Vapor need to be reactive or could integrate Vue.js that has works on Laravel and Meteor.js.
Faker data for unit testing
VaporChannel for video tutorials and discussion
Are there any performance improvement if we compile vapor with -fast0 ?

These are great additions. http://qutheory.io is actually running using Vapor + Vue. It's a great combo.
I'll add these to the roadmap.

Nice surprise! And I hope the benchmark will indicate CPU usage and memory consumption for a comprehensive comparison, I need to convince my team to adopt Vapor or Node.js in the near future and yet Node.js 6.0 has boosted its performance recently. I would love to see how its stack up again JS.

I believe you'd see better performance in Vapor over anything in JS. Swift is a very fast language, and JS is a very slow one.

The benchmarks I completed (which I hope to release soon) simply show requests/second. We blow any PHP, Ruby, etc out of the water. And we are head to head against Node.js. Node is surprisingly fast given it's JavaScript. I believe it's because a lot of their core is written in C. I'm sure Node apps start to slow down as the application gets heavier in JS.
Either way, if we're already head to head with Node.js this early in the game, I have really high hopes for beating them by good margins when we start spending time actually optimizing the framework.

Thanks, and probably it's a good time to integrate Venice if it could brings extra boost?
https://github.com/VeniceX/Venice

Venice is S4 compatible so Vapor should already work with that. If it's considerably faster, we could consider bringing it in as the default server.

These items have been added. Let me know if you come up with any more ideas, thanks!


Border issue

I am sorry, have a little problem in using github.
On resizing it's going up and down 1-2px; it irritated me and I found the problem.
But here is a little fix:
$resize_clone = $this.clone().attr('style', '').css({
visibility: 'hidden',
height: 0,
overflow: 'hidden',
paddingTop: 0,
paddingBottom: 0,
marginTop: 0,
marginBottom: 0
});
should be like this
$resize_clone = $this.clone().attr('style', '').css({
visibility: 'hidden',
height: 0,
overflow: 'hidden',
paddingTop: 0,
paddingBottom: 0,
borderTop: 0,
borderBottom: 0,
marginTop: 0,
marginBottom: 0
});

Obsolete. New major version available.


Godot 4.0.dev editor behaves weird while using i3wm (and maybe other tilling wm's)

Godot version: 4.0.dev
OS/device including version: Manjaro + i3
Issue description: The new editor behaves weird while using i3wm (and maybe other tilling wm's). I know version 4 is still in development, i just wanted to report that!

The image below is when clicking the "Editor"

The image below is when click the 3 vertical dots

Steps to reproduce: Use i3
Minimal reproduction project: I don't need to provide a project because its not a project specific

It's because of the refactor of the window backend: now every "subwindow" in Godot is it's own window, and i3wm tiles them like any other.
Run Godot with godot --single-window until a solution is made.

It looks like it's properly setting them as floating but not keeping their sizes and positions.

It looks like it's properly setting them as floating but not keeping their sizes and positions.
Nope, on tabbed mode it adds another tab with the popup as if it were a normal window.

@Ev1lbl0w Is there anything we can do about it? I wonder if we should detect tiling WMs and force single window mode by default in this case.

@Ev1lbl0w Is there anything we can do about it? I wonder if we should detect tiling WMs and force single window mode by default in this case.

I think we can set some window hints and hope the most popular tiling WM's abide to them. And if that's not the case, there's still the single window option that could be easily toggled (I think there was already an issue/request to make it toggable from the editor settings..?)

@Ev1lbl0w An editor setting was already added in #37391.

Looking at both bspwm and i3wm, they set the window to a "floating" state if the windows have the atom _NET_WM_WINDOW_TYPE_DIALOG set. I'll try implementing this and test if it works properly.
If it does, boy, does it save a ton of headaches :stuck_out_tongue:

So, after fiddling with the code for windows, I can't pinpoint the exact problem. In my setup (bspwm), the window seems to randomly work: sometimes it works fine, other times it becomes tiled, and fill the entire screen. I tried debugging and looking at xprop info, but couldn't pinpoint anything in particular.
But either way, I believe it's best for Godot to act as a single window for tilling WM's. To make Godot work well in this new scenario, I have to write some configs for it. And even them, they only apply to the current game/project I'm working on, and have to redo all them for other projects :stuck_out_tongue:
So, I agree with you @Calinou; it's probably best to detect a tilling WM and set Godot to single-window mode. But still retaining the option for floating docks (like Gimp).

the window seems to randomly work: sometimes it works fine, other times it becomes tiled

This exactly happens to me too!

It looks like in this function it's creating the window then setting it's flags. Maybe i3wm is tiling the window before it knows it should have been floating? I'm really not sure, I'm very new to this.
DisplayServer::WindowID DisplayServerX11::create_sub_window(WindowMode p_mode, uint32_t p_flags, const Rect2i &p_rect) {

	_THREAD_SAFE_METHOD_

	WindowID id = _create_window(p_mode, p_flags, p_rect);
	for (int i = 0; i < WINDOW_FLAG_MAX; i++) {
		if (p_flags & (1 << i)) {
			window_set_flag(WindowFlags(i), true, id);
		}
	}

	return id;
}

In DWM, some dialogs/popups are working well, for example: project settings, editor settings and the exit confirmation.
The problem seems to be with menu dialogs, which are not tiled but they take up to 60% of the screen. With DWM in floating mode, they spawn with correct size but in random positions.
godot --single-window does not solve anything for me

I got this from xprop:
(there are some differences in the ATOMs and minimun sizes)
Menu (takes up 60% of the screen)
WM_TRANSIENT_FOR(WINDOW): window id # 0x4200002
_NET_WM_NAME(UTF8_STRING) =
_VARIABLE_REFRESH(CARDINAL) = 1
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_UTILITY
WM_STATE(WM_STATE):
window state: Normal
icon window: 0x0
_MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x2, 0x50d3d100, 0x0, 0x57e, 0xecd559d0
WM_NORMAL_HINTS(WM_SIZE_HINTS):
WM_CLASS(STRING) = "Godot_Engine", "godot-test"
XdndAware(ATOM) = BITMAP
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW
WM_NAME(STRING) =
_NET_WM_PID(CARDINAL) = 26071
Exit confirmation (works well)
WM_TRANSIENT_FOR(WINDOW): window id # 0x4200002
_NET_WM_NAME(UTF8_STRING) = "Please Confirm..."
_VARIABLE_REFRESH(CARDINAL) = 1
WM_NORMAL_HINTS(WM_SIZE_HINTS):
program specified minimum size: 200 by 76
program specified maximum size: 200 by 76
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_NORMAL
WM_CLASS(STRING) = "Godot_Engine", "godot-test"
WM_STATE(WM_STATE):
window state: Normal
icon window: 0x0
XdndAware(ATOM) = BITMAP
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW
WM_NAME(STRING) = "Please Confirm..."
_NET_WM_PID(CARDINAL) = 26071
Settings (works well)
WM_TRANSIENT_FOR(WINDOW): window id # 0x4200002
_NET_WM_NAME(UTF8_STRING) = "Project Settings (project.godot)"
_VARIABLE_REFRESH(CARDINAL) = 1
WM_STATE(WM_STATE):
window state: Normal
icon window: 0x0
WM_NORMAL_HINTS(WM_SIZE_HINTS):
program specified minimum size: 900 by 700
program specified maximum size: 900 by 700
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_NORMAL
WM_CLASS(STRING) = "Godot_Engine", "godot-test"
XdndAware(ATOM) = BITMAP
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW
WM_NAME(STRING) = "Project Settings (project.godot)"
_NET_WM_PID(CARDINAL) = 26071

godot --single-window does not solve anything for me

That's probably because the flag is only passed to the first instance, which is the project manager if you don't specify a path to a project. godot --single-window -e --path /to/some/project should open the editor in single window mode.
There's also a project setting that you can enable to force it.

Did a quick test changing here the _NET_WM_WINDOW_TYPE_UTILITY atom to _NET_WM_WINDOW_TYPE_DIALOG
Now the menu boxes get the correct size but they are floating in wrong positions (Seems like it does the wrong calculations with my dual monitor setup).
This change broke some tooltips, so maybe we should allow to choose between the two Atoms (utilities and dialogs)

That's probably because the flag is only passed to the first instance, which is the project manager if you don't specify a path to a project. godot --single-window -e --path /to/some/project should open the editor in single window mode.
There's also a project setting that you can enable to force it.

Thank you, it works

We can probably pass --single-window to the editor execution call from the project manager, like we already do with flags such as --verbose.

I did some research using i3 a while ago, here's what i got from that.
The main issue seems related to the way DisplayServerX11::_create_window works. It:

Creates the window (XCreateWindow)
Maps the window (XMapWindow)
Configures the window(attributes, properties ecc.)

The issue is that mapping the window makes it immediately known to the WM which, at least in the case of i3, can clears some of it properties and resizes the window if there isn't the right atom set.
Now, why does it work randomly? Reading through the debug logs, i found this section, which gives me some hints:

09/05/2020 03:01:22 - WM_CLASS changed to Godot_Engine (instance), [PROJECT_NAME] (class)
09/05/2020 03:01:22 - WM_NAME changed to "Godot"
09/05/2020 03:01:22 - Using legacy window title. Note that in order to get Unicode window titles in i3, the application has to set _NET_WM_NAME (UTF-8)
09/05/2020 03:01:22 - window.c:window_update_name:64 - _NET_WM_NAME not specified, not changing
09/05/2020 03:01:22 - window.c:window_update_leader:139 - CLIENT_LEADER not set on window 0x05a00053.
09/05/2020 03:01:22 - window.c:window_update_transient_for:164 - TRANSIENT_FOR not set on window 0x05a00053.
09/05/2020 03:01:22 - window.c:window_update_strut_partial:189 - _NET_WM_STRUT_PARTIAL not set.
09/05/2020 03:01:22 - window.c:window_update_role:214 - WM_WINDOW_ROLE not set.
09/05/2020 03:01:22 - window.c:window_update_hints:377 - WM_HINTS not set.
09/05/2020 03:01:22 - window.c:window_update_normal_hints:291 - Clearing maximum size
09/05/2020 03:01:22 - window.c:window_update_normal_hints:312 - Clearing size increments
09/05/2020 03:01:22 - window.c:window_update_normal_hints:326 - Clearing base size
09/05/2020 03:01:22 - window.c:window_update_normal_hints:335 - Setting geometry x=1616 y=87 w=294 h=218
09/05/2020 03:01:22 - window.c:window_update_normal_hints:359 - Clearing aspect ratios

It seems that right after mapping most of the times i3 managed Godot's popup instantly, not finding any atoms since they weren't set yet.
I tried moving the mapping to a later stage in that function In my messy fork, effectively swapping step 2 and 3, and it fixed all tooltips and simple popups.
My hypotesis for this last part of the issue with those popups is that, maybe they inherit from Window and then they may set their properties after getting shown, but i haven't looked further into this.

Ok, so I tried making changes into the generic display server itself which for now I implemented only for the "linuxbsd" platform in my messy fork.
Now a window has to be shown with the show_window() function, but it doesn't seem too difficult to implement(I don't know if there are any other windows to be shown, for now i only added this call into Window and DisplayServerX11 for the main window, there shouldn't be other needed but i'm not sure).
At this point almost everything works with the exception of a few popups (like one which goes "Play current scene" > "Would you like to save the current scene?" > "yes" > popup which closes almost instantly) and some warning in other ones("out of date").
There are also some position issues, are those related to this problem regarding tiling WMs or is it a more general one?
Also, should i start making a pull request?

There are also some position issues, are those related to this problem regarding tiling WMs or is it a more general one?

I think it's a general one: #38591

Lately I've been busy, but I've made some tests and can confirm that the positional issues i got were related to that issue and got fixed by the pull request in its comments.


CLI incompatibility with Werkzeug 2 LocalProxy

LocalProxy has been changed in Werkzeug 2:

LocalProxy matches the current Python data model special methods, including all r-ops, in-place ops, and async. class is proxied, so the proxy will look like the object in more cases, including isinstance. Use issubclass(type(obj), LocalProxy) to check if an object is actually a proxy. :issue:1754

The Flask CLI can fail to run if the following conditions are met:

A LocalProxy is defined that requires an app context.
FLASK_APP is not defined.
The app is not named app or application or an app factory is used.

A simple app.py to reproduce:
from flask import current_app, Flask
from werkzeug.local import LocalProxy

log = LocalProxy(lambda: current_app.logger)

def create_app():
    app = Flask(__name__)
    return app

Then, running flask shell should drop nicely into the console. Instead, the result is RuntimeError: Working outside of application context.
Environment:

Python version: 3.9
Flask version: 1.1.2
Werkzeug version: 2.0.0rc1

The issue is with this line:
https://github.com/pallets/flask/blob/adeaf27e767f7bd37996d999eba135d63e890408/src/flask/cli.py#L51
and the aforementioned "the proxy will look like the object in more cases, including isinstance."
We can wrap the isinstance check in a try/except to ignore failing objects.

It looks like this is the same underling issue as I hit with building Sphinx docs against a Flask project with Werkzeug 2. Adding this comment mostly in case others hit this via that route.
Specifically my case was that I have flask.g imported and it was that usage of LocalProxy which was hitting this error.
I've got fuller details in https://gist.github.com/PeterJCLaw/b017b2869590036d3d05a427fd9f34d0, though it looks like there's a fix on the way already - thanks :)

My RTD doc builds are also now failing as a result of this, though for me I traced it to itsdangerous 2.0.0rc1, not Werkzeug. I think it's because Flask pins itsdangerous>=0.24, though it does something similar with Werkzeug. In either case, seems Flask either needs to pin the high end of these as well so the latest 1.1.2 doesn't continue to have issues, or these RC candidates need to be made compatible with the existing released version (preferable so existing Flask builds with 1.1.2 pinned start working again).

If your code pulls in prereleases without --pre being used something is wrong on your site. Very outdated pip/setuptools maybe, or python setup.py install instead of pip?

Yup, I raised that in the RTD issue, it's unclear why that happens (only in their env).

Try adding this to your .readthedocs.yml:
python:
  setup_py_install: false
  pip_install: true

Possibly set the version in there as well. By default RTD uses the legacy setup.py commands.

That fixed it, thanks so much!

RTD should probably switch to that by default instead of using legacy tools that are likely to break things nowadays...

Fixed by https://github.com/pallets/werkzeug/pull/2042/commits/352cd7167984f805daf226966f38f8dfeb991313


Slim down permissions

We might be asking for more permissions than we need.
I will be experimenting with removing more and more permissions from app to see how far we can go without affecting functionality.

@chris-mosley in engines/chromium/manifest.json the permissions are activeTab and storage, whereas we have a lot more for engines/gecko/manifest.json - do we need webRequest, scripting and tabs for firefox addons?

I actually removed activetab from the chrome one and it continued to work. but forgot to slim down the gecko manifest :|
I'm checking on that now.

so i did the same for firefox, removed all but storage and the addon continued to work.  Though I do wonder if my environment is screwed up from all the past testing. I've pushed it for now.

i think it might be better to preserve the activeTab permission, as we may want to be able to interact with the user's page in different ways in the future (like injecting styles, other scripts, etc.), and it avoids having to use host permissions, specifically this. we definitely don't need any of the others, however.
the changes to the "matches" pattern is also better for permissions. we can now remove the include_globs key as well so i'll make a pr for this (i previously thought this would mean not specifying a matches pattern but it's too generous). i'll also clean up the patterns so that we only have to define them once.
when testing i fully uninstalled the addon/extension and then re-installed and it was working

@barrymun  I added activeTab back in specifically to grab the url and see if we're on *.amazon.*
If we find any other uses for it then it's ready to go.


Nodes[c].components returns empty

Issue: Nodes in ExperimentTopology have empty components when topology is built from a graph_string or file
Scenario:
• Create ExperimentTopology as “topology” object
• Add Nodes and attach components to each nodes
• Serialize the topology as a file
• Reload the topology from the saved file as “topology2” object
• topology2.nodes[“n1”].components returns an empty dictionary
Possible solution:
File: networkx_mixin.py
Function: NetworkXMixin::_get_first_neighbors_via line 128 the if statement uses an incorrect constant NetworkXMixin.NETWORKX_LABEL which is defined as Class Passing label instead in the following statement fixes the issue.
if graph.edges[(real_node, n)].get(NetworkXMixin.NETWORKX_LABEL, None) != rel:

So I ran the following test:
    def testSerDes1(self):
        # more thorough serialization-deserialization test
        self.topo.add_node(name='n1', site='RENC')
        self.topo.nodes['n1'].add_component(ctype=f.ComponentType.SharedNIC, model='ConnectX-6', name='nic1')
        self.topo.add_node(name='n2', site='UKY')
        self.topo.nodes['n2'].add_component(ctype=f.ComponentType.SharedNIC, model='ConnectX-6', name='nic1')
        self.topo.add_network_service(name='s1', nstype=f.ServiceType.L2STS, interfaces=self.topo.interface_list)
        gs = self.topo.serialize()
        self.topo.graph_model.importer.delete_all_graphs()
        t1 = f.ExperimentTopology(graph_string=gs)
        self.assertEqual(t1.graph_model.graph_id, self.topo.graph_model.graph_id)
        self.assertTrue('n1' in t1.nodes.keys())
        self.assertTrue('nic1' in t1.nodes['n1'].components.keys())
        print(f'LIST COMPONENTS of n1 {t1.nodes["n1"].components}')
        print(f'LIST COMPONENTS of n2 {t1.nodes["n2"].components}')

and I got this output:
LIST COMPONENTS of n1 {'nic1': {'details': 'Mellanox ConnectX-6 VPI MCX653 dual port 100Gbps', 'model': 'ConnectX-6', 'name': 'nic1', 'type': 'SharedNIC'}}
LIST COMPONENTS of n2 {'nic1': {'details': 'Mellanox ConnectX-6 VPI MCX653 dual port 100Gbps', 'model': 'ConnectX-6', 'name': 'nic1', 'type': 'SharedNIC'}}

which seems correct. Sorry, I'm not understanding this @kthare10

I think the missing piece is that Orchestrator loads the Experiment Topology and converts into Neo4jASM. It then sends out the serialized Neo4JASM back to the user. Following test captures the failure, I am observing:
    def testSerDes1(self):
        # more thorough serialization-deserialization test
        topo = fu.ExperimentTopology()
        topo.add_node(name='n1', site='RENC')
        topo.nodes['n1'].add_component(ctype=fu.ComponentType.SharedNIC, model='ConnectX-6', name='nic1')
        topo.add_node(name='n2', site='UKY')
        topo.nodes['n2'].add_component(ctype=fu.ComponentType.SharedNIC, model='ConnectX-6', name='nic1')
        topo.add_network_service(name='s1', nstype=fu.ServiceType.L2STS, interfaces=topo.interface_list)
        slice_graph = topo.serialize()

        # Import it in the neo4j as ASM
        generic_graph = self.n4j_imp.import_graph_from_string(graph_string=slice_graph)
        asm_graph = Neo4jASMFactory.create(generic_graph)

        # Serialize ASM
        orch_graph = asm_graph.serialize_graph()

        # Reload Experiment topology from serialized ASM
        t1 = fu.ExperimentTopology(graph_string=orch_graph)

        self.assertTrue('n1' in t1.nodes.keys())
        self.assertTrue('nic1' in t1.nodes['n1'].components.keys())
        print(f'LIST COMPONENTS of n1 {t1.nodes["n1"].components}')
        print(f'LIST COMPONENTS of n2 {t1.nodes["n2"].components}')

Ah, I'm wondering if the other issue with capacities is also because of some difference in Neo4j vs. NetworkX. I will investigate.


Support multi-line search patterns

bump-my-version version: 0.11.0
Python version: 3.10.12
Operating System: Ubuntu 22.04 LTS

Description
This is more of a question, than a problem: I am trying to use bump-my-version to automate versioning for helm-charts. The files I want to bump look like this:
apiVersion: v2
appVersion: "11.2.1"
description: Intershop Commerce Management - ICM
# name and version must be in this exact order, otherwise bump2version won't work
name: icm
version: 1.4.0
# test related annotations
annotations:
  requestedMemoryQuota: 5900Mi
  requestedCpuQuotaInMinutes: "2500"
dependencies:
  - name: icm-as
    version: 1.3.0
    repository: file://../icm-as
  - name: icm-web
    version: 0.8.0
    repository: file://../icm-web
    condition: icm-web.enabled
  - name: mailhog
    version: 5.2.0
    repository: https://codecentric.github.io/helm-charts
    condition: mailhog.enabled
  - name: redis
    version: 17.15.2
    repository: https://charts.bitnami.com/bitnami
    condition: redis.enabled
  - name: redis-cluster
    version: 8.6.12
    repository: https://charts.bitnami.com/bitnami
    condition: redis-cluster.enabled

Note that there are many versions in this file, and using search/replace I can't simply look for the version, instead I also need to take the name as "context". Additionally, a single version may affect multiple files since we have multiple subcharts which depend on each other.
I was trying to achieve this behavior with this .bumpversion.cfg file in bump2version:
[bumpversion]
current_version = 1.4.0

[bumpversion:file:Chart.yaml]
search = name: icm
	version: {current_version}
replace = {new_version}

[bumpversion:file:../icm-replication/Chart.yaml]
search = name: icm
	version: {current_version}
replace = {new_version}

This didn't work though, because for some reason bump2version treats the first search pattern differently than the second (for the first pattern it replaces the whole search with the new version, in the second pattern only the {current_version} part).
When I tried this config with bump-my-version I simply got an error:
Bumping version of 'icm-as' to next 'minor' value.
Could not execute version bump.
Return code 1
STDERR:
Traceback (most recent call last):
  File "/home/cortlepp/.local/bin/bump-my-version", line 8, in <module>
    sys.exit(cli())
  File "/usr/lib/python3/dist-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "/home/cortlepp/.local/lib/python3.10/site-packages/rich_click/rich_command.py", line 126, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3/dist-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python3/dist-packages/click/core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3/dist-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/home/cortlepp/.local/lib/python3.10/site-packages/bumpversion/cli.py", line 283, in bump
    config = get_configuration(found_config_file, **overrides)
  File "/home/cortlepp/.local/lib/python3.10/site-packages/bumpversion/config.py", line 194, in get_configuration
    config_dict["files"] = get_all_file_configs(config_dict)
  File "/home/cortlepp/.local/lib/python3.10/site-packages/bumpversion/config.py", line 165, in get_all_file_configs
    return [FileConfig(**f) for f in files]
  File "/home/cortlepp/.local/lib/python3.10/site-packages/bumpversion/config.py", line 165, in <listcomp>
    return [FileConfig(**f) for f in files]
  File "/home/cortlepp/.local/lib/python3.10/site-packages/pydantic/main.py", line 164, in __init__
    __pydantic_self__.__pydantic_validator__.validate_python(data, self_instance=__pydantic_self__)
pydantic_core._pydantic_core.ValidationError: 1 validation error for FileConfig
search
  Input should be a valid string [type=string_type, input_value=['name: icm-as', 'version: {current_version}'], input_type=list]
    For further information visit https://errors.pydantic.dev/2.4/v/string_type

STDOUT:

WARNING:

Calling bumpversion without a subcommand is deprecated. Please use `bumpversion bump` instead

WARNING:

The .cfg file format is deprecated. Please use .toml instead.

Now my question: Can I get this to work with bump-my-version (and if so, how)? I couldn't find any information on how to match more than the simple version in your repo.
What I Did
Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

[bumpversion]
current_version = 1.4.0

# note: the indent after "search" is required to signal bump2version that the pattern continues
[bumpversion:file:Chart.yaml]
search = name: icm
	version: {current_version}
replace = name: icm
	version: {new_version}

[bumpversion:file:../icm-replication/Chart.yaml]
search = name: icm
	version: {current_version}
replace = {new_version}

We were able to fix our issue with the above cfg. Hopefully this multi-line-search-pattern feature will also work with .toml.

The search and replace docs demonstrate multi-line behavior.
The issues with indenting and type-checking is one of the reasons we deprecated .cfg files. They are tricky to get right.


Query frontend: large step queries are shifted

Thanos, Prometheus and Golang version used:
thanos, version 0.15.0 (branch: HEAD, revision: fbd14b49f95e7543883fedf9381a21127d4dda2b)
build user:       circleci@b18149728583
build date:       20200907-09:47:14
go version:       go1.14.2
(docker image: quay.io/thanos/thanos:v0.15.0)
prometheus: prom/prometheus:v2.20.1

Object Storage Provider:
s3
What happened:
When I use large step on queries, points are shifted.
Examples using with:

thanos-query 7200s step (ok):

curl http://<IP_ADDRESS>:10902/api/v1/query_range -d 'end=1603353600&query=count(push_time_seconds)&start=1602748800&step=7200' | jq '.data.result[]|.values|.[0]'
[
<PHONE_NUMBER>,
  "1043"
]

thanos-query-frontend 7200s step (ok):

curl http://<IP_ADDRESS>:10903/api/v1/query_range -d 'end=1603353600&query=count(push_time_seconds)&start=1602748800&step=7200' | jq '.data.result[]|.values|.[0]'
[
<PHONE_NUMBER>,
  "1043"
]

Then with larger step:

thanos-query 10800s step (ok):

curl http://<IP_ADDRESS>:10902/api/v1/query_range -d 'end=1603353600&query=count(push_time_seconds)&start=1602748800&step=10800' | jq '.data.result[]|.values|.[0]'
[
<PHONE_NUMBER>,
  "1043"
]

thanos-query-frontend 10800s step (ko):

curl http://<IP_ADDRESS>:10903/api/v1/query_range -d 'end=1603353600&query=count(push_time_seconds)&start=1602748800&step=10800' | jq '.data.result[]|.values|.[0]'
[
<PHONE_NUMBER>,
  "1019"
]

What you expected to happen:
I would expect to have the same answers between queries on thanos query and query frontend :-)
How to reproduce it (as minimally and precisely as possible):
cf. queries above
Full logs to relevant components:

Anything else we need to know:

Many thanks :-)

Hello, thanks for the issue.
How do you set up query frontend? Do you use cache?
If you use cache, then this is expected because the query result will be cached at the frontend when you query. This is fine because there is a cache validation time.

Hello thanks for your reply :-)
My query frontend is setup this way (a POD in my K8S):
      containers:
      - args:
        - query-frontend
        - --query-frontend.compress-responses
        - --http-address=<IP_ADDRESS>:10902
        - --query-frontend.downstream-url=http://thanos-query.pilot.svc.cluster.local.:10902
        - --query-range.split-interval=24h
        - --query-range.max-retries-per-request=5
        - --query-frontend.log_queries_longer_than=5s
        - |-
          --query-range.response-cache-config="config":
            "max_size": "512MB"
            "max_size_items": 0
            "validity": "6h"
          "type": "in-memory"
        image: quay.io/thanos/thanos:v0.15.0

I use in-memory cache but when I disable it I've exactly the same behavior.

OK. After checking the code I think this is caused by the step align middleware. It re-calculates the start and end time based on your step so that the requests can be better cached.
The code is https://github.com/cortexproject/cortex/blob/master/pkg/querier/queryrange/step_align.go#L19-L22.
So the start time of your last query becomes<PHONE_NUMBER>/10800*10800 =<PHONE_NUMBER> while other queries' start time is<PHONE_NUMBER>.
It is not a 100% accurate result but I think it is acceptable. This alignment might add 1 more sample in the query result, but when you look at your dashboard, the results should be almost the same.

Thanks for pointing this :-)
Well it seems that the shit increase with the step (with or without cache):

step 7200s -> shift = 0s
step 10800s -> shift = 7200s
step 86400s -> shift = 28800s

On 7 days, 8 hours begins to be observable :-)

Yes, the shift is related to your step as pointed out in the code https://github.com/cortexproject/cortex/blob/master/pkg/querier/queryrange/step_align.go#L19-L22.
So if you want to do a range query for 7d, then why do you use such a large step value? For a standard 7d query, the step should be 2419s which is 40m. What's your use case of using 86400s (1d) as your resolution?

But anyway, if this step alignment is not what you want, as it returns more data than expected, then we can provide a flag to disable this middleware. Users can make their choice to choose whether they want to disable this or not because the cacheability will be impacted without this middleware.
Does this sound good to you?

Actually I'm embedding those graphs (this is not this query but anyway) in a webapp with a JS lib for graphing which consumes more CPU to each point to plot :-/ and my client doesn't want a good definition but 1 point per day for a month and 1 point every 6 hours for a week.
What you propose seems to be a good compromise :-)

Thanks, I will open a pr soon.

Many thanks :-)
I understand this can be a special way of using the frontend :-)

Agree, let's expose it. Thanks, Ben and @darkweaver87 for investigation :+1:


Send transactions later when sources are not available yet

When sources are not available in the current block, no error should be thrown. Instead, cutecoin should save the transaction and send it as soon as a new block is mined.

https://github.com/ucoin-io/cutecoin/commit/bc3e23a4ba7749bcfef84bab8a9d9bb303264934


Fix minor memleak in Go bindings

The allocated C strings that were being passed to fopen were never being freed. I thought these were casts.

Call defer free for the two strings right after allocating them.
Change mode from "rb" to "r" because the trusted setup shouldn't be binary.

Nice find. Maybe we suffer from a similar file descriptor leak in the nodejs bindings: https://github.com/ethereum/c-kzg-4844/blob/main/bindings/node.js/src/kzg.cxx#L142
Should we fix it as part of this PR or open a new one?

Merged this one. Opened https://github.com/ethereum/c-kzg-4844/issues/246 for the nodejs issue.


Update bson to 4.9.1

About this PR
📦 Updates org.mongodb:bson from 4.2.3 to 4.9.1
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.mongodb", artifactId = "bson" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.mongodb", artifactId = "bson" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #170.


character ">" when colon key typed in a portuguese keyboard

Atom latest version installed an hour ago, on a Win 10 64bit with Portuguese layout keyboard
Typing : displays > on code window
Colon punctuation mark in PT keyboards is SHIFT+period

This is a duplicate of atom/atom-keymap#35 - feel free to subscribe there for updates.


luci-app-temp-status doesn't work with current main OpenWrt luci status page

luci-app-temp-status doesn't work with current main OpenWrt snapshot luci status page.
I've used this for quite a long time but yesterday I've updated the firmware of my router and then installed it but it doesn't show at all on Luci Status page.
OpenWrt SNAPSHOT, r27200+1-35819ca69a
 -----------------------------------------------------
root@QNAP:~# opkg info luci-app-temp-status
Package: luci-app-temp-status
Version: 0.4.1-r1
Depends: libc, lua, luci-lib-nixio, luci-lib-jsonc
Status: install user installed
Section: luci
Architecture: all
Size: 3702
Filename: luci-app-temp-status_0.4.1-r1_all.ipk
Description: Temperature sensors data for the LuCI status page
Installed-Time:<PHONE_NUMBER>

root@QNAP:~# ls /sys/class/thermal
cooling_device0  cooling_device2  thermal_zone1    thermal_zone11   thermal_zone3    thermal_zone5    thermal_zone7    thermal_zone9
cooling_device1  thermal_zone0    thermal_zone10   thermal_zone2    thermal_zone4    thermal_zone6    thermal_zone8
root@QNAP:~# ls /sys/class/hwmon
hwmon0  hwmon1  hwmon2  hwmon3
root@QNAP:~# ls /sys/class/hwmon/hwmon0
device             of_node            subsystem          temp1_crit_alarm   temp1_lcrit        temp1_max          temp1_min          uevent
name               power              temp1_crit         temp1_input        temp1_lcrit_alarm  temp1_max_alarm    temp1_min_alarm
root@QNAP:~# lua /usr/libexec/rpcd/luci.temp-status call getTempStatus
{"1":[{"number":2,"sources":[{"number":0,"temp":67100,"tpoints":{"0":{"temp":110000,"type":"critical"}}}],"item":"thermal_zone2","title":"nss1-thermal"},{"number":0,"sources":[{"number":0,"temp":65800,"tpoints":{"0":{"temp":110000,"type":"critical"}}}],"item":"thermal_zone0","title":"nss-top-thermal"},{"number":9,"sources":[{"number":0,"temp":66100,"tpoints":{"1":{"temp":95000,"type":"passive"},"2":{"temp":100000,"type":"passive"},"0":{"temp":110000,"type":"critical"}}}],"item":"thermal_zone9","title":"cluster-thermal"},{"number":7,"sources":[{"number":0,"temp":66100,"tpoints":{"1":{"temp":95000,"type":"passive"},"2":{"temp":100000,"type":"passive"},"0":{"temp":110000,"type":"critical"}}}],"item":"thermal_zone7","title":"cpu2-thermal"},{"number":10,"sources":[{"number":0,"temp":66100,"tpoints":{"0":{"temp":110000,"type":"critical"}}}],"item":"thermal_zone10","title":"wcss-phyb0-thermal"},{"number":5,"sources":[{"number":0,"temp":65200,"tpoints":{"1":{"temp":95000,"type":"passive"},"2":{"temp":100000,"type":"passive"},"0":{"temp":110000,"type":"critical"}}}],"item":"thermal_zone5","title":"cpu0-thermal"},{"number":3,"sources":[{"number":0,"temp":64200,"tpoints":{"0":{"temp":110000,"type":"critical"}}}],"item":"thermal_zone3","title":"wcss-phya0-thermal"},{"number":1,"sources":[{"number":0,"temp":67400,"tpoints":{"0":{"temp":110000,"type":"critical"}}}],"item":"thermal_zone1","title":"nss0-thermal"},{"number":8,"sources":[{"number":0,"temp":66100,"tpoints":{"1":{"temp":95000,"type":"passive"},"2":{"temp":100000,"type":"passive"},"0":{"temp":110000,"type":"critical"}}}],"item":"thermal_zone8","title":"cpu3-thermal"},{"number":11,"sources":[{"number":0,"temp":65200,"tpoints":{"0":{"temp":110000,"type":"critical"}}}],"item":"thermal_zone11","title":"wcss-phyb1-thermal"},{"number":6,"sources":[{"number":0,"temp":66500,"tpoints":{"1":{"temp":95000,"type":"passive"},"2":{"temp":100000,"type":"passive"},"0":{"temp":110000,"type":"critical"}}}],"item":"thermal_zone6","title":"cpu1-thermal"},{"number":4,"sources":[{"number":0,"temp":64500,"tpoints":{"0":{"temp":110000,"type":"critical"}}}],"item":"thermal_zone4","title":"wcss-phya1-thermal"}],"0":[{"number":2,"sources":[{"number":1,"item":"temp1_input","temp":70000}],"item":"hwmon2","title":"ath11k_hwmon"},{"number":0,"sources":[{"number":1,"item":"temp1_input","temp":66546,"tpoints":{"1":{"temp":"70000","type":"critical"},"2":{"temp":"60000","type":"max"}}}],"item":"hwmon0","title":"90000mdio100"},{"number":3,"sources":[{"number":1,"item":"temp1_input","temp":59000}],"item":"hwmon3","title":"ath11k_hwmon"},{"number":1,"sources":[{"number":1,"item":"temp1_input","temp":63910,"tpoints":{"1":{"temp":"70000","type":"critical"},"2":{"temp":"60000","type":"max"}}}],"item":"hwmon1","title":"90000mdio108"}]}root@QNAP:~#

Try clearing your browser cache.
Yesterday's snapshot + luci-app-temp-status v0.4.1-r1 with your data works fine:

Try clearing your browser cache. Yesterday's snapshot + luci-app-temp-status v0.4.1-r1 with your data works fine:

Probably another issue because I cleared several times, Doesn't work no matter the browser.

It's OK. I close this.


Fix sign() for torch and cupy

Neither propagate nans correctly, and torch does not support complex numbers.
Fixes https://github.com/data-apis/array-api-compat/issues/136

https://github.com/data-apis/array-api-compat/issues/136 should be resolved before this is merged, specifically, we should decide if it's worth fixing the sign(nan) special case, and if we want to keep that special case at all. Regardless of that, though, we should keep the torch complex handling, as it's very straightforward to implement.

It seems that torch has gained quite a few new test failures since the last time we ran them. I don't know if that's because of a test suite update or a torch update.

It sounds like this will be useful, so I'm going to merge.


java-openliberty:keystore.xml perms not set correctly

Signed-off-by: Steven Groeger<EMAIL_ADDRESS>Checklist:

[x] Read the Code of Conduct and Contributing Guidelines.

[x] Followed the commit message guidelines.

Updates to the collections

Related Issues:

Commit has been cherry picked from release-0.6 branch


jQuery Validation Plugin considers multiple empty space as valid to pass required field validation

Subject of the issue
Required fields should mean user need to input something. Just putting spaces should not pass required validation.
Your environment

version of jquery-validate： 1.15.0
All browser.

Steps to reproduce
https://jqueryvalidation.org/files/demo/ Try in the demo, when put name field with only a few spaces, then click "submit" no error message showed. It thinks input with spaces only pass the required validation.
Expected behaviour
jQuery validation should not pass for just blank spaces input.
Actual behaviour
jQuery validation considers a pass for just blank spaces input.

@cheonhyangzhang
Trimming white spaces was dropped from core in 2ad0ca82daf091fc692018b38e01e896fd304015 as part of a fix for issue #1498, also see this comment https://github.com/jzaefferer/jquery-validation/issues/1354#issuecomment-67168988.
As a solution, a normalization layer was added in #1609 (docs) that can be used to transform the value of an element before validation. This feature was available since 1.15.0. In other words, you can do something like this:
$("#myForm").validate({
  rules: {
    username: {
      required: true,
      // Using the normalizer to trim the value of the element
      // before validating it.
      normalizer: function(value) {
        // Note: the value of `this` inside the `normalizer` is the corresponding
        // DOMElement. In this example, `this` reference the `username` element.
        // Trim the value of the input
        return $.trim(value);
      }
    }
  }
});

@Arkni Thanks for the info.

@Arkni
In the code snippet above, the normalizer is defined inside of rule for a certain field, is there a way to apply a normalizer for all required fields?  Instead of having normalizer function individually for each field

I'm afraid you cannot do that in the main time, as the normalization layer is bound to the element level (as if it was a rule).

@Arkni
I think I can use jQuery.validator.addClassRules() as a workaround. However, this requires all the required field has the same class 'required'.
https://jqueryvalidation.org/jQuery.validator.addClassRules/
jQuery.validator.addClassRules("required", {
  required: true,
  normalizer: function(value) {
    return $.trim(value);
  }
});

That might work.
I think we may change the behaviour of the normalization layer to run for all fields if it's present in the top level (the same level as rules) without affecting the current behaviour, that way you can transform the values of a set of elements without attaching the same normalizer to the aforementioned elements, and you can override it on element level by specifying a normalizer for the specific element that you want to transform differently.
In pseudo code, this will look like:
$("#myForm").validate({
  normalizer: function(value) {
    // Trim the value of every element
    return $.trim(value);
  },
  rules: {
    username: {
      required: true,
      // Here, we override the global normalizer
      normalizer: function(value) {
        value = value.replace("something", "new thing");
        return $.trim(value);
      }
    }
  }
});

What do you think ?

Yes. I think this makes much more sense.
Are you saying this is already working in the current version or it will be planned to be implemented in future version?

Not implemented yet, but I hope it well be planned for the next release.
I will try to implement it when time allows, as currently don't have the bandwidth to work on it.
/cc @staabm

@Arkni
That sounds great.
Thanks for the help.

lets discuss the topic on a PR.

@cheonhyangzhang @staabm
I've opened #1905 to address this.

 rules: {       username: {         required: true,         normalizer: function(value) {           return $.trim(value);         }       }     },
its worked ...


[DO NOT MERGE] feat: add mlops bundle definition

This bundle definition integrates Charmed Kubeflow, MLFlow and the resource-dispatcher needed for a full MLOps deployment.
Changes in this PR:

Added a mlops/ directory in releases/1.7/edge to host the mlops bundle definition for both regular and airgap deployments. Left arigap/ directory as a placeholder.
Moved files in releases/latest/edge to a kubeflow/ directory
Added a mlops/ directory in releases/latest/edge to host the mlops bundle definition for both regular and airgap deployments. Left arigap/ directory as a placeholder.

Relates to #705
TODO:

[ ] add airgap bundle definitions

Closing this PR as the mlops bundle is not required anymore.


FEFAST - How to use?

Hi, first of all, thank you very much for your effort on making this library!
Send me your wallet so I can buy you a pizza 🍕 🍺 .
So, I'm trying to use this library to read data from the Brazillian Stock Exchange (B3), but I'm kinda of new in the Wayne's Rust World.
Could you help me pointing out with an example that uses fefast?

Hi @cesarvargas00! Thank you a lot for your interest in FerrumFIX :smiley:
fefast is still in development and I'm afraid there's nothing I can help you with for now. I've been focusing on FIX as that's by far the most requested protocol. You can take a look at the fefast sources to get an idea on how to roll your own, but you'll only find bits and pieces.
You can still send me a tip if you feel like it. I'm waiting for the Sponsor status by GitHub so that I can make this easier for those interested!
For now, you can send an Algorand tip at DQTRAXCXQM5GGQ65VESJ5ZYQHXXVBOJQJZBLZZSWC6YCFAERIBWRICUSFY :pray:


Support valibot (lightweight version of zod)

Consider Valibot over Zod: achieves lighter bundles & modularity, enhancing performance & flexibility.
<EMAIL_ADDRESS>It's 57KB gziped.
See: https://github.com/fabian-hiller/valibot

@lopezjurip Hi!
I agree adding valibot support to this plugin.
Could you send me PR for this? Thanks!

@Code-Hex @lopezjurip
I am a fan of graphql-codegen-typescript-validation-schema and valibot. I would like to submit a PR because I would like to use these two in a project I am working on! May I assign this issue to me?

@MH4GF Sure! I'm looking forward your PR!

@Code-Hex Please let me confirm about the definedNonNullAny that is zod's temporary hack.
Surprisingly, valibot seems to compile the following code:
import * as v from 'valibot'

type A = {
  foo: any;
};

function AParser(): v.ObjectSchema<A> {
  return v.object({
    foo: v.any()
  });
}

type InferA = v.Input<ReturnType<typeof AParser>>;
// =>
// type InferA = {
//   foo: any;
// }

ref: https://github.com/colinhacks/zod/discussions/951
So, is the schema to be generated correct with the intention of v.object({ foo: v.any() }) ?

@MH4GF Thank you for your question.
In zod, I employed a hack to define a schema for the any type that excludes undefined and null. I hope to create something that aligns with this intention.
Does this answer your question?

@MH4GF Big Thanks!!
I just published valibot support version!
https://github.com/Code-Hex/graphql-codegen-typescript-validation-schema/releases/tag/v0.15.0


Null Object Reference upon using "FlxG.mouse.overlaps"

Describe your problem here.
When I use FlxG.mouse.overlaps(aspritenamehere), it seems to give a null object ref. The object that I used in the code is visible and present, and appears just fine without the script enabled (commented), but when I click on the object (FlxG.mouse.justPressed is used too), it gives a null object reference. Any help?
Code in question:
     if (FlxG.mouse.justPressed && FlxG.mouse.overlaps(discord_icon)) {
	       CoolUtil.browserLoad('https://ninja-muffin24.itch.io/funkin'); //placeholder
        }
}

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, many menus have been heavily modified, but they act just normal with or without this script.

Try

if (FlxG.mouse.justPressed && FlxG.mouse.overlaps(discord_icon) && discord_icon != null) {
	       CoolUtil.browserLoad('https://ninja-muffin24.itch.io/funkin'); //placeholder
        }
}

Maybe?

Unfortunately, gives same error. I have confirmed it is something with FlxG.mouse.overlap() as if I only use the FlxG.mouse.justPressed, it does everything just fine (besides that if you click at all it sends you to a site)

What is on line 241 in in mainmenustate?

Describe your problem here.
When I use FlxG.mouse.overlaps(aspritenamehere), it seems to give a null object ref. The object that I used in the code is visible and present, and appears just fine without the script enabled (commented), but when I click on the object (FlxG.mouse.justPressed is used too), it gives a null object reference. Any help?
Code in question:
     if (FlxG.mouse.justPressed && FlxG.mouse.overlaps(discord_icon)) {
	       CoolUtil.browserLoad('https://ninja-muffin24.itch.io/funkin'); //placeholder
        }
}

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, many menus have been heavily modified, but they act just normal with or without this script.

I can help about that. So basically you can't if (FlxG.mouse.justPressed && FlxG.mouse.overlaps(spriteName) in same time, but try this instead:
`if (FlxG.mouse.overlaps(github))
{
github.alpha = 1;
github.scale.x = (FlxMath.lerp(github.scale.x, 0.12, 0.1));
github.scale.y = (FlxMath.lerp(github.scale.y, 0.12, 0.1));
		if (FlxG.mouse.justPressed)
		CoolUtil.browserLoad("https://ninja-muffin24.itch.io/funkin");
	}
	else
	{
		github.alpha = 0.5;
		github.scale.x = (FlxMath.lerp(github.scale.x, 0.098, 0.1));
		github.scale.y = (FlxMath.lerp(github.scale.y, 0.098, 0.1));
	}`

You can remove the scale and alpha shit if you don't need it on your modified Psych build. I just showed an fixed code for you if you need it. If you got an Null Object Reference again, then i can't help. It works for me perfectly fine

Describe your problem here.
When I use FlxG.mouse.overlaps(aspritenamehere), it seems to give a null object ref. The object that I used in the code is visible and present, and appears just fine without the script enabled (commented), but when I click on the object (FlxG.mouse.justPressed is used too), it gives a null object reference. Any help?
Code in question:
     if (FlxG.mouse.justPressed && FlxG.mouse.overlaps(discord_icon)) {
	       CoolUtil.browserLoad('https://ninja-muffin24.itch.io/funkin'); //placeholder
        }
}

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, many menus have been heavily modified, but they act just normal with or without this script.

I can help about that. So basically you can't if (FlxG.mouse.justPressed && FlxG.mouse.overlaps(spriteName) in same time, but try this instead:
`if (FlxG.mouse.overlaps(github)) { github.alpha = 1; github.scale.x = (FlxMath.lerp(github.scale.x, 0.12, 0.1)); github.scale.y = (FlxMath.lerp(github.scale.y, 0.12, 0.1));
		if (FlxG.mouse.justPressed)
		CoolUtil.browserLoad("https://ninja-muffin24.itch.io/funkin");
	}
	else
	{
		github.alpha = 0.5;
		github.scale.x = (FlxMath.lerp(github.scale.x, 0.098, 0.1));
		github.scale.y = (FlxMath.lerp(github.scale.y, 0.098, 0.1));
	}`

You can remove the scale and alpha shit if you don't need it on your modified Psych build. I just showed an fixed code for you if you need it. If you got an Null Object Reference again, then i can't help. It works for me perfectly fine

Thank You this worked


Fix -Werror=nonnull-compare and -Werror=format-truncation=

Summary
The change is split from PR: https://github.com/apache/incubator-nuttx/pull/5476
Error: module/mod_insmod.c:203:3: error: 'strncpy' specified bound 16 equals destination size [-Werror=stringop-truncation]
  203 |   strncpy(modp->modname, modname, MODLIB_NAMEMAX);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

wqueue/kwork_thread.c: In function 'work_start_lowpri':
Error: wqueue/kwork_thread.c:212:22: error: '%lx' directive output may be truncated writing between 1 and 16 bytes into a region of size 14 [-Werror=format-truncation=]
  212 |   snprintf(args, 16, "0x%" PRIxPTR, (uintptr_t)wqueue);

local/local_sockif.c: In function 'local_getsockname':
Error: local/local_sockif.c:392:11: error: 'strncpy' specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
  392 |           strncpy(unaddr->sun_path, conn->lc_path, namelen);
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

chip/esp32_wifi_utils.c: In function 'esp_wifi_scan_event_parse':
Error: chip/esp32_wifi_utils.c:373:37: error: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to dereference it? [-Werror=sizeof-pointer-memaccess]
   memset(ap_list_buffer, 0x0, sizeof(ap_list_buffer));
                                     ^

stdio/lib_fputs.c: In function 'fputs':
Error: stdio/lib_fputs.c:99:9: error: nonnull argument 's' compared to NULL [-Werror=nonnull-compare]
   if (s == NULL || stream == NULL)
         ^
Error: stdio/lib_fputs.c:99:27: error: nonnull argument 'stream' compared to NULL [-Werror=nonnull-compare]
   if (s == NULL || stream == NULL)
                           ^

stdio/lib_vfprintf.c: In function 'vfprintf':
Error: stdio/lib_vfprintf.c:40:6: error: nonnull argument 'stream' compared to NULL [-Werror=nonnull-compare]
   if (stream)
      ^

string/lib_strdup.c: In function 'strdup':
Error: string/lib_strdup.c:39:6: error: nonnull argument 's' compared to NULL [-Werror=nonnull-compare]
   if (s)
      ^

string/lib_strndup.c: In function 'strndup':
Error: string/lib_strndup.c:56:6: error: nonnull argument 's' compared to NULL [-Werror=nonnull-compare]
   if (s)
      ^

string/lib_strpbrk.c: In function 'strpbrk':
Error: string/lib_strpbrk.c:39:7: error: nonnull argument 'str' compared to NULL [-Werror=nonnull-compare]
   if (!str || !charset)
       ^~~~
Error: string/lib_strpbrk.c:39:15: error: nonnull argument 'charset' compared to NULL [-Werror=nonnull-compare]
   if (!str || !charset)
               ^~~~~~~~

string/lib_strrchr.c: In function 'strrchr':
Error: string/lib_strrchr.c:40:6: error: nonnull argument 's' compared to NULL [-Werror=nonnull-compare]
   if (s)
      ^

Error: time/lib_asctimer.c:73:50: error: '%d' directive output may be truncated writing between 1 and 11 bytes into a region of size between 0 and 12 [-Werror=format-truncation=]
   snprintf(buf, 26, "%.3s %.3s%3d %.2d:%.2d:%.2d %d\n",
                                                  ^~
time/lib_asctimer.c:73:21: note: directive argument in the range [-2147481748,<PHONE_NUMBER>]
   snprintf(buf, 26, "%.3s %.3s%3d %.2d:%.2d:%.2d %d\n",
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
time/lib_asctimer.c:73:3: note: 'snprintf' output between 17 and 68 bytes into a destination of size 26
   snprintf(buf, 26, "%.3s %.3s%3d %.2d:%.2d:%.2d %d\n",
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            g_wday_name[tp->tm_wday], g_mon_name[tp->tm_mon],
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            tp->tm_mday, tp->tm_hour, tp->tm_min, tp->tm_sec,
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            1900 + tp->tm_year);
            ~~~~~~~~~~~~~~~~~~~

Impact
Compiler warning
Testing
Pass CI.

Do we have -Wnonnull enabled?

Do we have -Werror=nonnull enabled?

We enable -Wall in all Make.defs and enable -Werror int tools/ci/cibuild.sh.

I recognize that by having the various NULL checks, some compilers may issue warnings about impossible code paths, etc. However I feel it is safer to have the NULL checks. One idea could be to make '-Werror=nonnull-compare' and '-Werror=format-truncation' dependent on (yet another) Kconfig and make the compiler warnings and the NULL pointer checks mutually exclusive. So either you have compiler warnings or NULL checks, but not both or neither. My 2 cents. :-)

Do you propose leave error checks and suppress compiler warnings?

I recognize that by having the various NULL checks, some compilers may issue warnings about impossible code paths, etc.

Yes, but this is just for some special functions(e.g. strcpy) which is known by compiler internally.

However I feel it is safer to have the NULL checks. One idea could be to make '-Werror=nonnull-compare' and '-Werror=format-truncation' dependent on (yet another) Kconfig and make the compiler warnings and the NULL pointer checks mutually exclusive. So either you have compiler warnings or NULL checks, but not both or neither. My 2 cents. :-)

Kconfig means user can enable it, and then the compiler throw many warning. Here is my thought:

Compiler will throw warning if caller pass NULL pointer to these special function
NULL pointer access normally generate the hardware exception by MPU or MMU
The affected functions are very small and simple

So, the side effect is minor.

@hartmannathan what you opinion?

ping @hartmannathan


Unable to Map List<List

Hi Team,
I tried to Map a Class :
public class PaymentOption {
private int num;
private List<List> combinations;
}
public class PaymentOptionDTO {
private int num;
private List<List> combinations;
}
but it fails for  'combinations' property.

@Getter
@Setter
public class Page implements Serializable {
private boolean isNext;

private int page;

private long total;

private int pageSize = 20;

private List<T> rows;

rows always null


[Feature Request]: (Auth0 integration) Add missing fields to Auth0User

Description
The type Auth0User is quite poor compared to what Auth0 can provide.
Auth0 guarantees at least 5 values (see https://auth0.com/docs/secure/tokens/id-tokens/id-token-structure), two of them are missing in the type Auth0User: email and email_verified. I guess at least email is a must-have.
Moreover, the field list that are provided by Auth0 depends on the configuration of the latter: it would be great, in addition to these two missing fields, to have the possibility of dynamically retrieving other values provided by Auth0.
For example, such a Auth0User definition might do the trick:
type Auth0User = {
	id: string;
	nickname: string;
	name: string;
	picture: string;
	updated_at: string;
	email: string;
	email_verified: boolean;
} & Record<string, unknown>;

Thank you again for the great job, I am already integrating Lucia 2!

Do you know where they mention email is guaranteed? They only say it's just a common standard claim.

Moreover, getting the email (if provided) is required to do OAuth account linking.

Thanks!


"Vicovu de Jos" is listed in the drop-down menu

Description:
"Vicovu de Jos" is listed in the drop-down menu alongside its corresponding county according to the law
Precondition:
The website is up an running.

Step 1
Type "Vicovu de Jos" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Vicovu de Jos, SUCEAVA".


Update README.md use correct command

The command is add-policy,
Using add_policy gives the error unknown command 'add_policy', did you mean 'add-policy'?

Thanks


Unable to play stream

I'm not able to play this stream with Clappr:
http://rtmonenews.secureswiftcontent.com/Origin02/ngrp:RTM2/chunklist_b3696000.m3u8
However this site can play it:
http://yoursports.stream/live?v=rtmsports
Where is the trick?

https://github.com/clappr/clappr/blob/master/doc/TROUBLESHOOTING.md#common-steps-to-verify-issues

Does not work from CDN, hls.js page or flashls page.
Also I have have enabled "Cors on Apache" (https://enable-cors.org/server_apache.html)
Installing: sudo a2enmod headers & adding to .htaccess: Header set Access-Control-Allow-Origin "*"
Same error code: hls:networkError_manifestLoadError

For me it's returning 403!

I know Leandro... my question is how http://yoursports.stream/live?v=rtmsports can play it with Clappr.

@hijuuijj because they know how to deal with the needed authorization and authentication for the stream.


Add Apache license template to settings and make it the default.

Fixes #4

Notes:

(minor) The '(c)' after 'Copyright' is not needed as per http://www.apache.org/licenses/LICENSE-2.0

(minor) I don't know if *.iml files are needed under version control in general (I usually ignored them for Android projects) and why they change here specifically. I replicated the update to the copyright folder and only misc.xml changed for me as a result. But I guess we can gitignore them anytime later if needed, so it's not important.

Looks okay for me and IntelliJ found and applied the Apache copyright automatically as expected.

Good point. The .gitignore file is based on some template for IntelliJ. Looks like the Android Studio templates for .gitignore don't include *.iml files and some directories in .idea.

@lemonboston please review again.

Checked, looks good, .iml files disappeared.

Removing iml files just broke the project in my IDE. It can't open the modules anymore :-(

According to this: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839-How-to-manage-projects-under-Version-Control-Systems the iml files need to be shared.


The performance difference between the validation set and the test validation set

In your released paper, I find that the performance difference between the validation set and the test validation set is quite large, which is not normal. Could you explain why?

Thank you! Good question. The test set contains images bigger than 640x640 while the validation set contains images that have a width or height smaller than 640 and have similar size distribution with the training set.


Set localhost as default base_url (instead of prod link)

set localhost as default base_url (instead of prod link) + remove unnecessary unittest

Did you commit poetry.lock on purpose ? Also what are all the tests that you removed ?

The tests I removed are such that not relevant anymore (from the time we adjust the validation to be just like in the GO-sdk (its just leftovers).

poetry is going through some lockfile updates, will handle it in a different issue, for now aligned the lockfile to reduce noise - the updates you see are to underlying deps updating


denoise-paired: expose matchIDs parameter

Improvement Description
Expose the matchIDs argument of the filterAndTrim() function
Current Behavior
The matchIDs argument of the filterAndTrim() function is False by default.
Proposed Behavior
A flag would be added to qiime2 so users could optionally set the matchIDs argument of the filterAndTrim() to True
Questions
Should we just change this to True by default and not expose the setting?
References
User story:
https://forum.qiime2.org/t/mismatched-forwward-and-reverse-sequence-files-sequences-imported-by-casava-1-8-paired-end-demultiplexed-fastq-format/10181/2

I'm gamely interested in working on this issue.

Should we just change this to True by default and not expose the setting?

I would not recommend this because the behavior is non-robust and will probably lead to errors if the id lines are in non-standard-illumina format, even slight modifications can break the parsing.
This is definitely a useful flag when paired Illumina fastqs have been inconsistently modified upstream, but it is a bit of a niche case. I wonder, is there a Q2 plugin focused on filtering fastq files at this point? Something like this functionality would fit there. But adding a flag to denoise-paired would probably be OK too.

We are currently thinking that https://github.com/qiime2/q2-types/issues/207 is perhaps a better way to address this issue in 99% of the cases where it will come up (we're not aware of anything that shuffles the reads, so we're assuming that it's a result of filtering in a non-paired-end aware way). These read mismatches cause issues elsewhere, so it would be best to just disallow them in the format.
Now that importing validates the entire contents of the archive, we think we can realistically prevent this situation.
Feel free to re-open if there's other reasons that matchIDs would be useful.


[202] Fix REDIS_URL and REDIS_CACHE_URL

Context
The REDIS_URL and REDIS_CACHE_URL were updated to point to the same Azure Redis Cache instance. They should point to the queue and cache instances respectively.
Also we want to enforce SSL connection to redis.
Changes proposed in this pull request

Ensure these two values point to the correct Azure Redis Caches. Cache to cache and URL to queue.
Disable non-SSL redis port

Guidance to review

Confirm the references are correct in the REDIS_URL and REDIS_CACHE_URL app_secrets.
Confirm the app connects to redis

Link to Trello card
https://trello.com/c/lfv7xZNH
Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] Required environment variables have been updated added to the Azure KeyVault

 Disable Redis non SSL port


Got MiioException while fetching the state: Unable to discover the device

Device model / 设备型号
cgllc.airm.cgd1st
Component version / 插件版本
0.7.13
HA core version / HA版本
2023.11.1
Integrated mode / 集成方式
Local (本地模式)
The problem / 问题详情
One of my 5 air monitor lite became unavailable some time ago, after a reboot (power outage in the house).
Before this, all devices worked.
I did not install updates or change the location of the devices.
Ping to the device from the HA server is successful.
The device is available in MiHome app.
There are such entries in the logs:
2023-11-10 10:28:54.118 ERROR (MainThread) [custom_components.xiaomi_miot.sensor] Air ChildRoom(cgllc.airm.cgd1st): Got MiioException while fetching the state: Unable to discover the device <IP_ADDRESS>, mapping: {'environment.relative_humidity': {'siid': 3, 'piid': 1}, 'environment.pm2_5_density': {'siid': 3, 'piid': 4}, 'environment.pm10_density': {'siid': 3, 'piid': 5}, 'environment.temperature': {'siid': 3, 'piid': 7}, 'environment.co2_density': {'siid': 3, 'piid': 8}, 'battery_level': {'siid': 4, 'piid': 1}, 'battery.charging_state': {'siid': 4, 'piid': 2}, 'battery.voltage': {'siid': 4, 'piid': 3}}, max_properties: 9/8
Entity attributes / 实体属性
sensor.cgllc_cgd1st_42d4_battery_level
Air ChildRoom Battery Level
unavailable	restored: true
state_class: measurement
device_class: battery
friendly_name: Air ChildRoom Battery Level
supported_features: 0
unit_of_measurement: %
sensor.cgllc_cgd1st_42d4_charging_state
Air ChildRoom Battery Charging State
unavailable	restored: true
friendly_name: Air ChildRoom Battery Charging State
supported_features: 0
sensor.cgllc_cgd1st_42d4_co2_density
Air ChildRoom Environment CO2 Density
unavailable	restored: true
state_class: measurement
device_class: carbon_dioxide
icon: mdi:molecule-co2
friendly_name: Air ChildRoom Environment CO2 Density
supported_features: 0
unit_of_measurement: ppm
sensor.cgllc_cgd1st_42d4_environment
Air ChildRoom Environment Relative Humidity
unavailable	state_class: measurement
unit_of_measurement: %
device_class: humidity
friendly_name: Air ChildRoom Environment Relative Humidity
supported_features: 0
sensor.cgllc_cgd1st_42d4_pm10_density
Air ChildRoom Environment PM10 Density
unavailable	restored: true
device_class: pm10
friendly_name: Air ChildRoom Environment PM10 Density
supported_features: 0
unit_of_measurement: µg/m³
sensor.cgllc_cgd1st_42d4_pm25_density
Air ChildRoom Environment PM2.5 Density
unavailable	restored: true
state_class: measurement
device_class: pm25
icon: mdi:air-filter
friendly_name: Air ChildRoom Environment PM2.5 Density
supported_features: 0
unit_of_measurement: µg/m³
sensor.cgllc_cgd1st_42d4_temperature
Air ChildRoom Environment Temperature
unavailable	restored: true
state_class: measurement
device_class: temperature
friendly_name: Air ChildRoom Environment Temperature
supported_features: 0
unit_of_measurement: °C
sensor.cgllc_cgd1st_42d4_voltage
Air ChildRoom Battery Voltage
unavailable	restored: true
device_class: voltage
friendly_name: Air ChildRoom Battery Voltage
supported_features: 0
unit_of_measurement: V
Home Assistant Logs / 系统日志
2023-11-10 10:28:54.118 ERROR (MainThread) [custom_components.xiaomi_miot.sensor] Air ChildRoom(cgllc.airm.cgd1st): Got MiioException while fetching the state: Unable to discover the device <IP_ADDRESS>, mapping: {'environment.relative_humidity': {'siid': 3, 'piid': 1}, 'environment.pm2_5_density': {'siid': 3, 'piid': 4}, 'environment.pm10_density': {'siid': 3, 'piid': 5}, 'environment.temperature': {'siid': 3, 'piid': 7}, 'environment.co2_density': {'siid': 3, 'piid': 8}, 'battery_level': {'siid': 4, 'piid': 1}, 'battery.charging_state': {'siid': 4, 'piid': 2}, 'battery.voltage': {'siid': 4, 'piid': 3}}, max_properties: 9/8

Devices offline
Some devices cannot be connected in the LAN, please check their IP and make sure they are in the same subnet as the HA.
一些设备无法通过局域网连接，请检查它们的IP，并确保它们和HA在同一子网。
Qingping Air(cgllc.airmonitor.s1): <IP_ADDRESS>


[Bug] [SubWorkflowLogicTask] missing scheduleTime param during schedule or run complement in sub-workflow

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
SubWorkflowLogicTask.triggerNewSubWorkflow only use WorkflowManualTriggerRequest to build request, the sub-workflow instance's scheduleTime param will be missing in schedule run.
https://github.com/apache/dolphinscheduler/blob/071994933b05850e7dd5f7bccbf45d867640e244/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/subworkflow/SubWorkflowLogicTask.java#L175-L206
What you expected to happen
may use WorkflowScheduleTriggerRequest when the parent workflow instance's scheduleTime is not null ?
How to reproduce
schedule or complement run  a workflow with sub process, which with dependent node (the DependentAsyncTaskExecuteFunction will got a wrong dependentDate)
Anything else
No response
Version
dev
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I've assigned to you. Looking forward to your contribution.

I've assigned to you. Looking forward to your contribution.

OK


Whole screen is zoomed in

Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
Environment:
OS: macOS High Sierra 10.13.2
Node: 9.5.0
Yarn: Not Found
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: Not Found
Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.53.0 => 0.53.0
Expected Behavior
Keyboard and text is like native apps.
Actual Behavior
The whole screen is slightly zoomed in.
Taskbar is zoomed in.
Keyboard is bigger.
All text is blurry.

Native app
React Native app

I have found the problem: one of my launch images was of an incorrect size.


Thank's plugin.. start ruler view?

not using button ...
start auto ruler view can?
thank's

You can run editor.runCommand('ruler-visibility') after init to show rulers, and editor.stopCommand('ruler-visibility') to hide rulers.


mobile - declaration summary

I could do some mistake during my declaration, so a button to see a summary of my declaration for the day and all the declaration made to come (vacation) could be very helpful.
UseCase :
I declare myself for the day in remote then I want to declare my future holidays.
But i just made a mistake and select today for the start.
So I modify my declaration by clicking on the button CHANGE to say that I will go on vacation next week.
The current backend mobile will save all my declaration, so only the last declaration made will override the previous one if they have the same declaration time : so my error will override my declaration for the day. And my captain will se me as absent for the day.
Add a possibility to clear a declaration in this summary.

mobile front + fetch
nodejs query

I think we already did this with the new query

Not in the bastiUI design


Linkedin Recruiter

Hello There!
Is there a way to make the dark mode of this extension function with LinkedIn Recruiter?
Thank you!

I'd need access to a linkedin recruiter account. Could you help us make this a reality? It'd likely require a few rounds of testing.


CB-8302 - Add additional logging around DH - DL attaching

CB-8302 - Add additional logging around DH - DL attaching

I think this can go 2.28 line because it is not really a blocker

I think this can go 2.28 line because it is not really a blocker

Have changed it to master


Add support for XOAUTH2 and OAUTHBEARER

[ ] Merge https://github.com/duesee/imap-codec/pull/491
[ ] Test OAUTHBEARER auth mechanism with a real provider

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.616%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
893

Relevant Lines:
1382

💛  - Coveralls

Ready for review!

Update: While rewriting a bit, I discovered that we are missing a few cases. This is why the review takes a bit longer. Have you integrated this already in imap-client? If so, we could proceed from there.

Update: While rewriting a bit, I discovered that we are missing a few cases. This is why the review takes a bit longer. Have you integrated this already in imap-client? If so, we could proceed from there.

I propose to continue and merge this PR first, then let me know your decision about where should be the tasks workspace (either inlined inside imap-client as a temporary solution, stay here, move in another dedicated repo etc).
As I said, I just initiated the inline solution with imap-client to wire up everything in email-lib. If you decide sth else I will adjust the code and rewrite git history :slightly_smiling_face:

Since you agreed to move tasks to imap-client, I close this PR. The code has already been merged here, feel free to open issues or pull requests to adjust.


MGDSTRM-10039 elevating the priority of broker and zookeeper pods

also adding some trivial instance profiler changes.

I'm not sure what a good naming convention is here.  We already have kas-fleetshard-high.  I went with core, but you could also go with standard, moderate, medium high, etc.
The choice of 10 for the priority value is also arbitrary.  We can of course space that out more if desired - high is 1000000

Since "high" name already set precedent, I like the @shawkins idea of going with "standard, moderate, medium high, etc." then there is no ambiguity when referred in conjunction with other class types.


feature(kcp): kcp2k V1.42 [2024-05-03] - Unreliable channel is now unreliable-sequenced

Make things easier for studios.

issues in a production game. closing for now


InspectLedger instance for Shelley

Fixes #2452 and #2471.

I'll take over this PR.

Closing this in favour of #2627. Leaving this as a separate PR just in case we want to compare to what was done here.


SCM placeholder is soo long that input widget wraps

I would not expect that the input box wrap when it shows a placeholder, only when I type something

https://github.com/microsoft/vscode/issues/79029
OK you guys discuss, let me know who wins.

I don't mind that we do not wrap, however this:

Looks broken. If we do not wrap then we should really not wrap and show 1 line with "..." in that input field.


julia-actions org

Just an FYI because you might be interested in adding/using things in https://github.com/julia-actions

btw @odow this works now. At the moment it checks diff matches the formatted output.

Cool! Thanks again for working on this.

added workflows that use this setup so gonna close this


Fix setting "value" attributes.

When setting an input element's value attribute via el.setAttribute(),
the displayed value is not updated, and the original value returned by
el.value instead of the new value.  To fix this, assign the value attribute
both ways.
Also, add tests to catch this problem.
Closes #359.

PTAL @rviscomi

LGTM thanks for the fix


Sofia's Edits

Install additional packages -  install.packages("knitr"), install.packages("devtools"), BiocManager::install("limma"), BiocManager::install("GEOquery"), BiocManager::install("ComplexHeatmap"),
The rest of the code runs.
Based on this code, it is hard to understand what is the result and what the original question was. I also do not clearly understand the logic behind arranging the code in this order.

I agree with Paige on this. Everything else looks good


Added fixes so that dummy docs build locally and on readthedocs. In n…

…o particular order, these include:

recommonmark sphinx extension is deprecated, replace with myst_parser ((https://github.com/readthedocs/recommonmark/issues/221)
fixed dummy module name in api.rst (dummy -> dummy_module) so that build does not fail
fixed indenting, replaced '-' with '=', add '*' so that api.rst does not cause build to fail
replaced emoji in title of notebook so that build does not fail (is this related to emoji encoding issue?)
introduced hack in index.rst (mulitple '=' symbols) as build seems to fail if project name is greater than the default number of '='. With this hack, build will only fail if project name is > 50 characters long (unlikely...)
added srclinks to conf.py to prevent build warning
updated readthedocs.yml according to latest best practice on readthedocs site
added instructions in README to install package prior to local build (otherwise build will fail)
fixed layout of cookiecutter README so that docs badge displays correctly
applied precommit default linting (end-of-file fixer etc)
added _static and _template subdirectories so that build successful on readthedocs

Hey. This pull request is so that the default docs will build locally and on readthedocs (as of August '21 on a machine with Ubuntu at least).
In my experience, it seems like there is always some small issue that will prevent the docs from building successfully. And dependencies seem to get updated regularly enough (and often can lead to docs failing to build again), that perhaps this pull request is a little pointless!
Let me know if you think it's helpful, and what further changes I should make if it is.


Incorrect handling of line breaks in bibtex files

Description
The following typst code:
#cite("foo")
#bibliography("test.bib")

together with the following bibtex file:
@misc{foo,
author="Smith, John
and Smith, Jane"}

render as follows:

This is clearly not what was intended. I'd expect it to render the same as the version without newlines, which looks like this:

Reproduction URL
No response
Operating system
macOS
Typst version

[X] I am using the latest version of Typst

This is now fixed.


Display only owned ERC-20 tokens on the assets list

The list of ETH assets should be narrowed to the tokens that user owns (has the balance greater than 0).

I also added new field in the token details: the name of the token:

@onvisions what do you think about this?

Good improvement. Approved on my side. Other wallets also display the full token name. We should apply the same for coins as well.

LGTM


[Feature] Counter Effect to Numbers in the Landing Page

Description
I want to give the counting effect to the numbers on the homepage. Like when user scrolls to that section, the numbers starts to count from zero till it reaches that particular number.
Screenshots

Additional Information
I am a GSSoC'23 contributor and I really want to contribute to this project.
@Susmita-Dey

go for it @mohammadshaad assigning you :rocket:

Thank you so much

Please add the GSSoC tag as well @himanshu1221


Add ShimmerLayout to GUI list

@JStumpp is there something wrong with the format of the pull request or with the library?


Firefox scrollbar styling

Since Firefox 64 the following CSS properties are available:
https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-width
https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-color
Before:

This PR:

Looks like the tests are failing because the used version of known-css-properties doesn't include these properties (they are included in the 0.12.0 release).
The latest version of stylelint uses 0.11.0, waiting for https://github.com/stylelint/stylelint/issues/3973 before updating the dependency here.


Updates from GregSweats part1

Hello @lorenzodalaqua - sorry for the poor PR Title and Description. I'll write something better up if you think that there is any value in what I've done here.
🙏♥ what you made, as well as new-to-me JSON Resume Schema that may have just kept the roof over my head as I struggle to write a concise resume w/o too much playing around creating my own schemas, apps, fully-featured MS Word Tempaltes, Power BI Dashboards, etc. Nice to be focused.

All the best new friend! Well..maybe..you may not like that I turned 6660 into 8888. Wasn't until now I though that it was like the Asian 666, which sounds like ha, so that is ha-ha-ha. However, 666 in my world is 😈 territory. Not religious, more spiritual, but I am superstitious, haha-ha ;)

Mmmm, look at those sexy emoji commits eh? Ya...Canadian.


Include the Multicall2 version of the contracts

This PR provides fixes #8.
The issue was related to contracts probably pointing to a v1 for the Multicall that was failing when accessed with the tryAggregate functionality. As there aren't official deployments of M2 in the Maker team's repo, I've deployed and verified new contracts for both polygon networks.
Matic: 0x275617327c958bD06b5D6b871E7f491D76113dd8
Mumbai: 0xe9939e7Ea7D7fb619Ac57f648Da7B1D425832631

Hey thanks for this, can you just update the readme at the bottom to be the new addresses!

Sure thing! I've added the new contracts and formatted the section to look as a table.

You legend thanks a lot! Will merge now and deploy tomorrow! 👍


some error occurred when following the usage steps - Please note that karateFeaturesDir has to be relative to perfiz.yml location.

@auto110 Thank you for reporting the issue. This was indeed a bug in error logging and it has been fixed in this commit.
Please delete your current release of Perfiz in your PERFIZ_HOME location and download the latest release Perfiz 0.0.4 and this error message should go away.
Not sure why I see there is a exit status 1 after the "Starting Perfiz Docker Containers..." in your screenshot. Can you please confirm you have Docker running and docker-compose setup? Also please share the OS you are using.
Please feel free to report any other issues you run into. Thanks.

@harikrishnan83     Thanks for your quickly replay. Yes, I faild to run this, it exits with status 1.
I test this on centos 7 server within my company before getting off work. Now I am at home, so  I need to verify it next week.
By the way, I remember the Docker and docker-compose are already setup and running.

@harikrishnan83
Test environment

CentOS Linux release 7.7.1908 (Core)
Docker version 19.03.12, build 48a66213fe
docker-compose version 1.24.1, build 4667896b

The error

I set the version to 3.3, then it says "networks.perfiz-network value Additional properties are not allowed ('name' was unexpected)"

@bitlin Thanks for reporting this. Appreciate your effort taking time to provide screenshots. It really helps.
About the first error message, looks like you may need to upgrade your docker-compose version. I tested the docker-compose.yml with below version.
$ docker-compose version docker-compose version 1.28.5, build c4eb3a1f docker-py version: 4.4.4 CPython version: 3.9.0 OpenSSL version: OpenSSL 1.1.1h  22 Sep 2020
Setting docker-compose.yml version to 3.3 will not work because, "network" capability was added in docker-compose yml version 3.4.
I suggest you upgrade your docker-compose cli to a more recent version. Or alternatively (if you are unable to upgrade immediately) can you please try setting docker-compose version to 3.4 or more?
Please do report any other issues you run into.

It's the same issue if only just only setting docker-compose version to 3.4.  Then, I upgrade the docker-compose cli to the latest version, it works.
However, it's blocked by pulling cadvisor timeout.

@auto110 Many thanks for checking, I will update documentation with docker-compose cli version in pre-requisites.
On the cadvisor issue it can happen when there are network blips. Can you retry running perfiz.sh start, it should pick up where it left of and pull the cadvisor.

@auto110 May I know from which Geography you are located? Docker pulls can be slow in some locations as mentioned in this thread https://stackoverflow.com/questions/28957330/acclerate-docker-pull-in-china-asia

@harikrishnan83

:)  My machine is located in China.

@auto110 Thanks for confirming that Docker version 19.03.12 works and only docker-compose required the update.
About the timeouts on the docker images, it is interesting that it is getting stuck at cadvisor. I just retested this by deleting my local copy of cadvisor image and it downloaded without any issues. Please check if you need to make any changes to your Docker setup like setting up a mirror etc.
Maybe just to get past this problem for the moment, you can comment out below lines in $PERFIZ_HOME/docker-compose.yml
cadvisor:
    image: gcr.io/cadvisor/cadvisor:latest
    container_name: cadvisor
    ports:
      - 8082:8080
    volumes:
      - /:/rootfs:ro
      - /var/run/docker.sock:/var/run/docker.sock:rw # This works on Mac
#      - /var/run:/var/run:ro # This may work on Linux
      - /sys:/sys:ro
      - /var/lib/docker/:/var/lib/docker:ro
    networks:
      - perfiz-network

You will still see some interesting Gatling graphs on Grafana even without cadvisor.

Closing this issue as we resolved the perfiz.sh start related issues. @auto110 and @bitlin, please feel free to report any other issues you run into separately. Thanks.


Numbergen RandomBytes Update

Create an interface operation to allow users to generate a random number based on a defined input to indicate the number of bytes.
It is currently cumbersome to generate random numbers that are more than 32 Bytes. This operation will make it simple for a user to do so without chaining Numbergen calls.
Related PR
There will be a related PR in wasmcloud-otp repo for Numbergen builtin. Will update the description when it is created.
Release Information

Consumer Impact
As this is an addition and does not change any existing operations, there should be no impact to end users currently using the Numbergen provider.
Testing

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin
[ ] x86_64-windows

Tested on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin
[ ] x86_64-windows

Unit Test(s)

Acceptance or Integration

Manual Verification

I will do DCO signoff at the end in case I forget for more PR's

The consensus from WasmCloud Wed on 26 Apr 2023 is to use a provider to generate cryptographically secure numbers, as the numbergen builtin can't and should not be used for crypto purposes.


LongWord  stored a 64 bit ?

In the code you write :

Idera redefined the "fundamental" LongWord type to no longer be 32-bits. It is now 32-bits on 16-bit platforms, 32-bits on 32-bit platforms, and 64-bits on 64-bit platforms. And Cardinal, the "generic" type, as been changed to be 16-bits on 16-bit platforms, 32-bits on 32-bit platforms, and 32-bits on 64-bit platforms. This means they violated the contract of correctly written code - retroactively breaking all existing code.

but that not true ? where did you see that ?

but that not true ? where did you see that ?

The Delphi documentation

Changes in LongInt and LongWord Size for 64-bit iOS Platforms
LongInt and LongWord are now platform-dependent integer types.
On 64-bit iOS platforms, LongInt and LongWord are double the size that is supported on 32-bit platforms

So if you have code that assumed that LongInt and LongWord were "Fundamental types", that assumption is no longer true.
| Type        | 16-bit platform | 32-bit platform | 64-bit platform  |
|-------------|-----------------|---------------- |------------------|
| Integer     | 16-bit signed   |            32-bit signed           | "generic type"
| Cardinal    | 16-bit unsigned |            32-bit unsigned         | "generic type"

| Longint     | 32-bit signed   | 32-bit signed   | 64-bit signed    | "fundamental type"
| Longword    | n/a             | 32-bit unsigned | 64-bit unsigned  | "fundamental type"
| Int64       | n/a             | 64-bit signed   | 64-bit signed    | "fundamental type"
| UInt64      | n/a             | 64-bit unsigned | 64-bit unsigned  | "fundamental type"
| Int32       | n/a             |            32-bit signed           |
| UInt32      | n/a             |            32-bit unsigned         |

| NativeInt   | n/a             | 32-bit signed   | 64-bit signed    |
| NativeUInt  | n/a             | 32-bit unsigned | 64-bit unsigned  |

| FixedInt    | n/a             |            32-bit signed           |
| FixedUInt   | n/a             |            32-bit unsigned         |

BCrypt was written to the Delphi language standard, which made certain promises.
Those promises were broken; hence the need to change.


Update branding to match ESLint

I'd like to see if we can update the visuals to be more in line with the overall branding of the ESLint project.
Here is our color palette:
https://github.com/eslint/eslint.org/blob/main/src/assets/scss/tokens/themes.scss
Here is our typography:
https://github.com/eslint/eslint.org/blob/main/src/assets/scss/tokens/typography.scss
Also, I'd like to see some of the iconography we use on the rules page incorporated:
https://eslint.org/docs/next/rules/
What do you think?

I will try to see how I can align with the colors and fonts.
For the icons, I am not so sure, because:

In docs, it uses emojis, which will render different on different OS
The recommended uses ✅, which is visually a bit too prominent compared to the other elements. Meanwhile, the "check" seems to have a strong connection with "enabled" to me, which I am a bit worried might cause confusion.

I agree with the alignment and consistency. But instead, maybe we could change the docs to use some monochrome icons from an icon set that we could align better with good visual hints. If so, we could decide the icons for each concept and I am happy to contribute them back to the docs site if needed.
Currently, the inspector uses Phosphor (https://icones.js.org/collection/ph), the Duetone variant. I am not 100% insistent on using it, but I found it looks quite nice and has a wide range of icons to choose from. Unless you have a strong opinion about the icons, otherwise, I guess we could pick some from it.

In docs, it uses emojis, which will render different on different OS

Right, but it will be consistent to the user -- they'll be viewing the website and config inspector in the same browser. We don't need to worry about consistency across browsers.

The recommended uses ✅, which is visually a bit too prominent compared to the other elements. Meanwhile, the "check" seems to have a strong connection with "enabled" to me, which I am a bit worried might cause confusion.

I understand your point. My thought is that because people are already seeing the green checkmark on the docs, then this will be logically consistent from their point of view vs. introducing a new icon.

But instead, maybe we could change the docs to use some monochrome icons from an icon set that we could align better with good visual hints. If so, we could decide the icons for each concept and I am happy to contribute them back to the docs site if needed.

The icons are actually used throughout the ecosystem, for instance typescript-eslint uses the same set as does the ESLint doc generator tool.
I'm not opposed to suggesting a change, but whenever we have something spread throughout the ecosystem, it's a much more of an uphill battle to change and get everything aligned.

Yeah, that's true. We can't have non-emoji icons in the GitHub readme either.
I think the situation in the docs is a bit different from the inspector, as in the docs we don't have the concept of "enabled", and we don't always control how the icons are rendered. I still find the green checkbox would be too visually prominent in the context of the inspector, while the enable/disable rule should be much more important information that users need to care about.
I tried an middle ground as https://github.com/eslint/config-inspector/pull/16 - let me know WDYT

I think that's a fair compromise -- looks more aligned with the docs, so I'm happy. Thanks!


How to update Unity Editor UI after receiving data from server

I am trying to update the texutre on Editor UI after receiving the path from server side. The C# code is shown as below. After triggering the event, I can successfully get the lastImagePath, but cannot execute the code inside  UnityThread.executeInUpdate. Do you know how to fix this?
socket.On("generationResult", (response)=>
                {
                    JArray jarray = JArray.Parse(response.ToString());
                    JToken jtoken = jarray[0];
                    string basename = (string)jtoken["url"];
                    lastImagePath = Path.Combine(installationFolder, basename);
                    Debug.Log(lastImagePath);
                    UnityThread.executeInUpdate(() =>
                    {
                        Debug.Log("test1");
                        // load texture from file
                        resultsTexture = new Texture2D(2, 2);
                        ImageConversion.LoadImage(resultsTexture, File.ReadAllBytes(lastImagePath));
                    });
                });

as in the README if you want to play with unity game objects (eg: rotating an object) or saving data using PlayerPrefs system use this instead:
socket.OnUnityThread("spin", (response) =>
{
    objectToSpin.transform.Rotate(0, 45, 0);
});

replace spin with your event generationResult


refactor: replace strings.Replace with strings.ReplaceAll

PR Details

Description
Replace strings.Replace(s, old, new, -1) with strings.ReplaceAll(s, old, new). strings.ReplaceAll is a wrapper function for strings.Replace, but strings.ReplaceAll is more readable and removes the hardcoded -1.
Related Issue

Motivation and Context

We have been using strings.ReplaceAll in other files already before this PR. This PR just makes the code more explicit when we want to do a full string replacement.

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #1250 (a59f390) into master (f5d3d59) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1250   +/-   ##
=======================================
  Coverage   98.42%   98.42%
=======================================
  Files          31       31
  Lines       22761    22761
=======================================
  Hits        22403    22403
  Misses        239      239
  Partials      119      119

Flag
Coverage Δ

unittests
98.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

calc.go
98.93% <100.00%> (ø)

chart.go
100.00% <100.00%> (ø)

comment.go
100.00% <100.00%> (ø)

drawing.go
99.65% <100.00%> (ø)

lib.go
98.35% <100.00%> (ø)

picture.go
98.36% <100.00%> (ø)

pivotTable.go
98.72% <100.00%> (ø)

shape.go
100.00% <100.00%> (ø)

sheet.go
100.00% <100.00%> (ø)

stream.go
89.59% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5d3d59...a59f390. Read the comment docs.

LGTM, thanks for your contribution.


How to query all logs within a certain "Category"

Lets say I have two Models (among other models):

NewsItem
Category

Each newsItem has only 1 category.
I've your beautiful package up and running and its perfectly logging all changes to NewsItem.
However, on the category page, I want to display all changes that where logged for all the newsitems within that category. How can I do that? Can you point me in the right direction?
Thanks, and thanks for this package.

In #526 the question is already answered.
If you have any additional questions: just ask.