[3.x] Make blinn and phong specular consider albedo and specular amount

Fixes: https://github.com/godotengine/godot/issues/50455 and fixes https://github.com/godotengine/godot/issues/34257
4.0 version: https://github.com/godotengine/godot/pull/51411
This PR adds in the specular amount and albedo into the calculation of specular lighting for Blinn and Phong modes. This is not physically based, however, it comes close to mirroring the old Specular/Diffuse lighting that was around before PBR. In discussions with other contributors it is clear that we want to maintain the Blinn and Phong modes for performance reasons and for compatibility with older workflows. The main difference between this and the old Specular/Diffuse lighting model is that this only provides one albedo colour. The older workflow always specified a specular colour and a diffuse colour, here we use albedo for specular and diffuse. Essentially we have gone from:
diffuse_color = albedo;
specular_color = vec3(1,1,1);

to:
diffuse_color = specular_color = albedo;

This PR should be slightly improve performance in theory. But in practice there will be a negligible difference.
Visual comparison
All comparisons use the same layout. GGX in the upper right, Blinn in the lower left, and Phong in the lower right
Smooth metal
old

new: note the color around the specular highlight

0.5 rough metal
old

new: note the colored specular highlight

rough metal
old

new

This PR should result in as little change as possible for existing materials while allowing more cohesiveness when using Blinn and Phong. Users that appreciated having the overblown specular on darker materials can still achieve the same look by boosting specular with the specular property.
Old notes
This PR adds a Fresnel term and geometric term to both the Blinn and Phong specular modes. The Fresnel term scales the specular intensity quite strongly and removes the overbright specular reflections when roughness is high.
By way of background, BRDF's typically share 3 terms D (normalized density function) G (geometric term) F (Fresnel term). The Blinn BRDF is D*G*F / 4 * NdotL * nDotV (see https://www.cs.cornell.edu/~srm/publications/EGSR07-btdf.pdf) . Godot has been using a more simplified model which ignored the G and F terms (and had a mistake in the D term): D` / 4 * NdotL * nDotV. This simplified model is naturally simpler to compute, but was totally broken (hence https://github.com/godotengine/godot/pull/33836 which didn't actually fully fix Blinn).
This PR restores the G and F terms. The G term for Blinn-Phong is equal to NdotL * nDotV and so it cancels out the NdotL * nDotV in the BRDF. We are left with D * F / 4 which is what this PR uses.
Visual comparison
All comparisons use the same layout. GGX in the upper right, Blinn in the lower left, and Phong in the lower right
Smooth metal
old

new: note the color around the specular highlight

0.5 rough metal
old

new: note the colored specular highlight

rough metal
old

new

edit: references for future reference
http://www.thetenthplanet.de/archives/255
https://seblagarde.wordpress.com/2011/08/17/hello-world/
https://www.cs.cornell.edu/~srm/publications/EGSR07-btdf.pdf
https://slideplayer.com/slide/1507561/

I missed the discussion last night as it was late here, but I'd also say give it a try in some betas, and see if we get anyone complaining.
Aside from the backward compatibility, my only concern (being a performance guy) is when you say it runs slower, is to make sure we always have a cheap and cheerful diffuse and specular mode available that runs as fast as humanly possible, and doesn't care about PBR accuracy etc. Because that's what it boils down to in most cases, people want to be able to choose between 'looks good' and 'runs fast'. Myself I try and tweak the settings to have as fast as possible, or often just run an entirely custom shader for this reason.

From my perspective, having shaders that are more realistic, or do things as normal light, is quite important . .

if they become exactly the same, in terms of visuals, why even have them . .
if speed becomes significantly lower, that might be a draw-back . .

I often wondered why they were there, I just use the default one, assuming it's best . . . maybe they are important shaders, for historical purposes . . reg. speed, it's an issue whether current hardware is optimized for one, or the other, about speed . . .
I sort-of rather wish, there was an explanation for why even to use them . . . one down-side for them looking is identical is, why not just delete the two slower one's, and have the fastest / best one . . .
The pre-view images are amazing, one can see how the color of the reflection light, becomes more like GGX ( accurate ? ) . . Amazing, hope you can make it run fast, and look good . . . .

Aside from the backward compatibility, my only concern (being a performance guy) is when you say it runs slower, is to make sure we always have a cheap and cheerful diffuse and specular mode available that runs as fast as humanly possible, and doesn't care about PBR accuracy etc. Because that's what it boils down to in most cases, people want to be able to choose between 'looks good' and 'runs fast'. Myself I try and tweak the settings to have as fast as possible, or often just run an entirely custom shader for this reason.

Blinn and Phong are still cheaper than the GGX mode, they just aren't as cheap as they were before (this PR adds a handful of multiplications and 2 lerps). For most cases, they probably won't be slower because the difference is so small, but in theory more instructions leads to worse performance.
One problem with the current implementation is that it is halfway between old Diffuse/Specular and PBR. Without this change, specular ignores albedo. Since Godot materials cannot specify diffuse_color and specular_color, all materials using Blinn/Phong implicitly use a pure white specular_color. Which is of course a huge problem both for a PBR workflow and for a Diffuse/Specular workflow.
IMO the workflow that makes sense is having Blinn and Phong look like simplified versions of GGX (but cheaper of course). That is the workflow that this PR enforces.

@lawnjelly Another option would be to meet in the middle. We could remove the Fresnel term completely and make the assumption that diffuse_color = specular_color = albedo.
Actually, that may be the best option here. If we do that we can substantially reduce the instruction count while maintaining a consistent behaviour
Code below for reference (tested in the online editor while I am at work :P)
void light() {
//Blinn
	vec3 H = normalize(VIEW + LIGHT);
	float cNdotH = max(dot(NORMAL, H), 0.0);
	float shininess = exp2(15.0 * (1.0 - ROUGHNESS) + 1.0) * 0.25;
	float blinn = pow(cNdotH, shininess);
	blinn *= (shininess + 2.0) * (1.0 / (8.0 * 3.14159)); // Normalized NDF and Geometric term
	SPECULAR_LIGHT += LIGHT_COLOR * ATTENUATION * blinn *ALBEDO * specular;

        // Lambertian
	float NdotL = dot(NORMAL, LIGHT);
	float cNdotL = max(NdotL, 0.0); // clamped NdotL
	DIFFUSE_LIGHT = cNdotL * (1.0 / 3.14159) * LIGHT_COLOR * ALBEDO;
}

void light() {
//Blinn
	vec3 R = normalize(-reflect(LIGHT, NORMAL));
	float cRdotV = max(0.0, dot(R, VIEW));
	float shininess = exp2(15.0 * (1.0 - ROUGHNESS) + 1.0) * 0.25;
	float phong = pow(cRdotV, shininess);
	phong *= (shininess + 1.0) * (1.0 / (8.0 * 3.14159));
	SPECULAR_LIGHT += LIGHT_COLOR * ATTENUATION * phong *ALBEDO * specular;

        // Lambertian
	float NdotL = dot(NORMAL, LIGHT);
	float cNdotL = max(NdotL, 0.0); // clamped NdotL
	DIFFUSE_LIGHT = cNdotL * (1.0 / 3.14159) * LIGHT_COLOR * ALBEDO;
}

This removes the Fresnel term completely (the Fresnel term is responsible for making all surfaces appear reflective at a glancing angle) and introduces albedo and specular amount into the terms. This way the materials will behave consistently (but not physically correct) and it introduces minimal calculations, thus keeping them as cheap as possible.

Okay, I have updated the PR to not go full-PBR. Instead it maintains some aspects of the old Diffuse/Specular model. Results are similar but not quite as close to GGX as they were before. I suggest we approve and merge like this as it should impact existing users less and still provides the same benefits.

Thanks!


Regarding bounding box values during training and testing.

During training, we fit in batches of images of the same dimensions for training, 512 in code by default. During training the position of activated pixels to the rotated box boundaries is limited to the range [0, 512] due to the use of a sigmoid activation function. However, during testing, the model input is not restricted to the size of images used during training, instead, only resized to be divisible by 32. I'm wondering what's the effect of this when the test image dimensions are very different than the training image dimensions. Do you think it's better to squashed resized images to 512 during testing? @SakuraRiven

I guess "dimensions" is actually "scale" ? The scales in ICDAR2015 train/test are similar so we could directly inference. In fact, we can adjust the train scale and test scale to align them for better performance.


REMOVED FINISH BUTTON

KYE CHANGES

Removed any logic or UI elements related to the Finish button in the UI component that uses these API services, focused on the component where we have the form and button rendering.

Also ensured that the API methods (saveBotCapability, updateBotCapability, and deleteBotCapability) are still in use without relying on a Finish button

@PartishtaP  can you include a screenshot after running this, since im getting a error after running this
at same time i can see ther is some a new Save button added, which we are not intended to

@PartishtaP don't save anything in capacity service file (services/Capacity). Just remove the "Finish" Button in capacity tab(In bot configuration page)
Also include a screenshot

@PartishtaP  Could you provide an update on this PR?

Closing this issue as there has been no follow-up. It has been reassigned to another contributor


Minor fixes and support for Subject

registry: disable cookies
schema: the subject element consists is an object (if present)
provider: add argument to pass a subject

@dev-zero this looks good - a few tweaks:

you'll need black  black-23.3.0 for pre-commit to run locally and fix the formatting errors
please bump the version in oras/version.py
add a corresponding note about the changes in CHANGELOG.md

@vsoch do you mind if I "fix" pre-commit to install the tools isolated rather than trying to run locally?
flake8 fails here as well due to typing issues and may need to be pinned to an older version.

... and while being at it, switch from flake8 to ruff?

I think I’d prefer keeping the current linting for now - at least for this PR. I’m open to changes but it’s out of scope for the work here.

done

I found yet another issue when working on/with Subject: the referrer API gives back digests for the referenced manifests, but manifest_uri() did not consider digests.

I found yet another issue when working on/with Subject: the referrer API gives back digests for the referenced manifests, but manifest_uri() did not consider digests.

The specs are changing and the registries differ in implementations, so definitely there could be missing pieces. Shall we finish up the work here and work on this in another scoped PR?  Either way, you'll still need to bump the version and update the CHANGELOG.md as I mentioned earlier. Thanks!

done, @vsoch

Also - if formatting keeps failing I'd be happy to push a commit for you (just let me know).

Ok, merged and rebased @vsoch


zkvm: encapsulate bulletproofs dependencies

Fixes #210 - uses capacity of 256 for bulletprooofs generator.

We should probably simply do pub use bulletproofs; in the lib.rs to allow users pick various bulletproofs types (such as generators) directly via zkvm::bulletproofs::... to avoid adding BP as a dependency.


[ask] Is launcher ready for running?

Hi, may i ask you, Is launcher ready for running?
I compiled launcher and hook, and I tried to run it, but it ended with 0xc0000142.

It seems like you should put dfint_config.toml to DF dir.

Ok, it seems running.
And I would like to ask, what should the format of dfint dictionary.csv be? I received such an error
[13:55:03.899] [info] trying to load dictionary from csv file dfint_dictionary.csv
[13:55:39.514] [info] logger init

It is generated by df-gettext-toolkit.
Bassicaly, it is  csv with 2 columns and many rows - original line in cp437 | translated line in any 1 byte encoding (maybe the same 437). For example, for RU we use cp1251.
So, just pust that dfint_dictionary.csv in the DF folder. Hook will fill dictionary from it on startup.

Hi! you can send to me the files compiled? Or you can explain how compile this? I tried a lot but I couldn't.

Hi! you can send to me the files compiled? Or you can explain how compile this? I tried a lot but I couldn't.

I'll do release later this day

Oi! você pode me enviar os arquivos compilados? Ou você pode explicar como compilar isso? Eu tentei muito, mas não consegui.

Farei o lançamento ainda hoje

Ok, thanks!

Oh, maybe I used the csv file with CJK characters. And this program support CJK characters? (such as load a font lib, and use the CJK font)

Oh, maybe I used the csv file with CJK characters. And this program support CJK characters? (such as load a font lib, and use the CJK font)

You need curses png according your enconding. TTF enjection not used for now. So use any 1-byte ecnoding csv + curses charmap

@JoaoVictor834 @all, here is a prerelease. "Pre-" because it doesn't have any description or instructions yet, but it's usable.

any plan for support ttf to load 2-byte encoding ( like Chinese, Japanese ) translation?

@JoaoVictor834, aqui está um pré-lançamento (você precisa do pacote dfint-steam-hook-0.1.0.zip dos ativos de lançamento)
https://github.com/dfint/df-steam-hook/releases/tag/0.1.0
"Pré-" porque ainda não tem nenhuma descrição ou instruções, mas é utilizável.

Thanks! I will already use


Home Assistant 0.96 breaks everything...

Not that I have even installed HA 0.96 yet but it is clear from the release notes that its going to break all the existing climate integrations. What is probably going to happen is that I will split this code into two seperate projects - this will remain as the generic library, and I will create a seperate project for the HA integration.
Likely will use the current Daikin component as the basis for rebuilding the component. Thanks for all the additional work HA Devs! :-)

Upgraded this morning to 0.96 and discovered (too late) that this integration was broken.
Looks like you're onto it! Thanks for that.
Happy to help with some testing if required.

Updated custom config is ready for testing

Legend! Thanks for sorting that out so quickly. Works for me now on 0.96.3.

working for @gcorgnet and now me in production so closing issue


Update Cosmos DB python package

This change updates the azure-mgmt.-cosmosdb package to use the most recent version (0.11.0). This version uses "patch" to update accounts instead of "put", which helps prevent unwanted updates.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

/azp run

add to S163.


Allow to add custom tag

Hi, Thanks for this gem,
What about if some one wants to add custom tags as this yabeda-sidekiq gem is allowing.

Hi @hannan228, I think it could be done to some extent.
The main difference between yabeda-sidekiq and this exporter is a collector (shared storage used to expose metrics later). We don't have it; hence, there is no way to have exactly the same functionality (assign custom labels from the local code). Instead, as a trade-off – this exporter offers a very straightforward and fast way to bet all the essential metrics out of the sidekiq.
What could be done - we can add a configuration option to add any labels to the metrics, which could be configured in your config.ru or so, but I think it will duplicate the correct way of doing so – a Prometheus configuration.


fix: typo in payment notification

This PR fixes a small typo in the payment notification.

Thanks for the contribution. 👍


Don't set CLOEXEC on Fuchsia

The CLOEXEC flag is currently set for the Fuchsia platform, e.g. in accept.
Even though the flag is supported on Fuchsia, the flag doesn't do anything because Fuchsia doesn't really have exec as a concept. As a result, it would seem wise to pretend that this flag doesn't exist on Fuchsia.

I don't know enough about Fuchsia to say whether or not this makes sense, @tamird any thoughts?

Everything @ttttcrngyblflpp says is correct. The flag is supported - it can be set and queried - but doesn't do anything because exec doesn't exist in Fuchsia by design.
Whether or not this justifies conditional logic is less clear to me.
There's an issue tracking this in Fuchsia, which may be useful to cite when making changes in this area.


Migrate types unit tests for BString

Purpose

Related issue https://github.com/ballerina-platform/ballerina-lang/issues/21987

Approach

Migrate existing types unit tests for BString

Samples

N/A

Remarks

N/A

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #22268 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22268   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 596a465...d23f5c0. Read the comment docs.


Component tidb's GitHash not right after patched

Bug Report
Please answer these questions before submitting your issue. Thanks!
What did you do?

Deployed a v5.4.0 cluster using tiup
Patched tidb component with a local-built binary A (built from a forked branch with GitHashA)
Did some benchmarks
Patched tidb component with another local-built binary B (built from a forked branch with GitHashB)
Did some benchmarks

What did you expect to see?

When I pathed tidb with A or B, the GitHash in Cluster Info should change

What did you see instead?

The GitHash unchanged after patched with B
Not sure it changed or not when I patched with A
I checked the binary tidb-server in tidb deploy-dir, it's md5 changed after patched everytime, that confirmed the patchings were success.

What version of TiDB Dashboard are you using (./tidb-dashboard --version)?

Update: figured out why, I used --offline flag
Close now


swc-windows-installer.py: Install GNU Make from gnuwin32

The Make binary in msysGit doesn't work with the MSys2-based Git for
Windows, raising:
The program can't start because msys-1.0.dll is missing from your
computer.

The gnuwin32 binaries are built from GNU Make v3.81
(2006-04-01), but they run without crashing.

I'm still getting:
ethanwhite@IF-WEC-EW1 MINGW64 ~
$ make
/c/Users/ethanwhite/.swc/lib/make/bin/make.exe: error while loading shared libra
ries: ?: cannot open shared object file: No such file or directory

with the associated
The program can't start because libintl3.dll is missing from your computer.
This is a different missing dependency than before. I wonder if we may need the dependencies zip as well?

If you download the package as Zip files, then you must download and install the dependencies zip file yourself.

On Thu, Nov 19, 2015 at 10:36:31AM -0800, Ethan White wrote:

If you download the package as Zip files, then you must download
and install the dependencies zip file yourself.

Ah, that's probably what's going on.  Do we have to unpack that
dependencies zip somewhere special?  If you unpack it to the same
make_dir (so libintl3.dll and libiconv2.dll are in the same directory
as the new make.exe), does that work?

If you unpack it to the same make_dir (so libintl3.dll and libiconv2.dll are in the same directory as the new make.exe), does that work?

Yep, looks like that took care of it.

On Thu, Nov 19, 2015 at 10:53:16AM -0800, Ethan White wrote:

If you unpack it to the same make_dir (so libintl3.dll and
libiconv2.dll are in the same directory as the new make.exe), does
that work?

Yep, looks like that took care of it.

Ok, should be fixed in 87d509d (although note that the security on the
dependency tarball is questionable.  See the commit message for
details).

Now getting:
ethanwhite@IF-WEC-EW1 MINGW64 ~
$ python swc-windows-installer.py
Preparing your Software Carpentry awesomeness!
installer version 0.2
create nosetests entrypoint C:\Users\ethanwhite\.swc\bin\nosetests
installing http://downloads.sourceforge.net/project/gnuwin32/make/3.81/make-3.81
-bin.zip into C:\Users\ethanwhite\.swc\lib\make
installing http://downloads.sourceforge.net/project/gnuwin32/make/3.81/make-3.81
-dep.zip into C:\Users\ethanwhite\.swc\lib\make
Traceback (most recent call last):
  File "swc-windows-installer.py", line 324, in <module>
    main()
  File "swc-windows-installer.py", line 290, in main
    install_make(install_directory=make_dir)
  File "swc-windows-installer.py", line 163, in install_make
    path=os.path.join(install_directory, 'bin', 'libiconv2.dll'))
  File "swc-windows-installer.py", line 145, in zip_install
    except FileExistsError:
NameError: global name 'FileExistsError' is not defined

That error is on Python 2.7.10.

On Thu, Nov 19, 2015 at 11:58:45AM -0800, Ethan White wrote:

NameError: global name 'FileExistsError' is not defined

Thanks, I'd only tested with Python 3.  Should be fixed with 5b74c6c
(and the Python 3 docs only mention the super-class OSError 1, even
though I get the subclass FileExistsError with my local 3.4.3).

ethanwhite@IF-WEC-EW1 MINGW64 ~
$ python swc-windows-installer.py
  File "swc-windows-installer.py", line 54
    if sys.version_info >imp= (3, 0):  # Python 3
                            ^
SyntaxError: invalid syntax

On Fri, Nov 20, 2015 at 06:07:50AM -0800, Ethan White wrote:

if sys.version_info >imp= (3, 0):  # Python 3

Grr, sloppy, sloppy.  Should be fixed with 8107c0d.

That one did it. Thanks. I'll try to find time to get a new release rolled in the next couple of days

On Fri, Nov 20, 2015 at 08:13:37AM -0800, Ethan White wrote:

That one did it. Thanks. I'll try to find time to get a new release
rolled in the next couple of days

Merging the python branch into master should be easy to do now, and I
can handle that and tagging if you want.  I'll leave building a new
Inno Setup installer and attaching it to the release to you ;).

Sounds good.

On Fri, Nov 20, 2015 at 10:56:19AM -0800, Ethan White wrote:

Sounds good.

Version bumped to v0.3, merged to master, and master is tagged.  Once
you've got the installer built, attach it here 1.


Runner failed to start with custom Pod spec

with version 0.4.0 (PR #7), Runner failed to start with custom Pod spec
apiVersion: actions.summerwind.dev/v1alpha1
kind: RunnerDeployment
metadata:
  name: my-runner
  annotations:
    iam.amazonaws.com/role: my-role
spec:
  replicas: 1
  template:
    spec:
      repository: example/repo
      containers:
        - name: runner
          image: example/custom-action-runner:latest
          imagePullPolicy: Always

Error log

kubectl logs muy-runner-8gcph-v7plj -f
RUNNER_NAME must be set

a fix PR will follow up soon.

Hmmmm, for me when you choose to override containers, you should be responsible to override all fields including env, field. BTW, my bad I'm completely forget to add README about new feature.

@alexandrst88 Hey! Thanks for chiming in. Yeah - I thought so initially, but that feature turned out to be unusable at all without the ability to inject the required env.
The env includes a dynamically generated runner token that is required by the runner in the first place. Can we somehow generate the runner token out of the band and provide it via containers so that the runner controller can use it as-is? That seemed to defeat the purpose of the controller.

Oh I see

Any updates on this? I'm also stuck on this issue of the runner name not being set.
How can we pass in the proper environment name?

Unfortunately, there's no update as I don't use this specific feature!
Do you have a hard requirement that needs RUNNER_NAME? Then my best bet is adding support for merging spec.template.containers[] by container name. spec.template.containers[].env should also be merged by environment name. It should be like how K8s strategic-merge patches work.

I'm just trying to get a runner up with the deployment in a custom runner.
Which file would I put that merging support in?

Where can I read up more on how "K8s strategic-merge patches work."?

@avik-so Unfortunately I have no reference to share. AFAIK it isn't well-documented as a reusable library.
I believe kustomize uses it for merging K8s resource manifests locally. So instead, I can suggest consuling kustomize codebase to see how it works.

Apparently references below help:

https://kubernetes.io/docs/tasks/manage-kubernetes-objects/update-api-object-kubectl-patch/
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-api-machinery/strategic-merge-patch.md

If I am understanding correctly, you are suggesting that I create a new yaml file and do a patch with the missing environment variables/config maps, rather than making a PR which allows the RunnerDeployment file to patch the custom pods/images?

@avik-so Hey! Well, so you don't need to use env or even set RUNNER_NAME(what is it?) to use this controller to manage a set of GitHub runners. The documentation has been updated and it should really be straightforward to use it now. Closing as resolved.


Adding Sidekiq middleware

I'm having an issue setting up prosopite with sidekiq.
I added the same snippet in the docs but getting uninitialized constant Sidekiq::ServerMiddleware.
I'm using Sidekiq 4.2.10
I tried checking if Prosopite needs a certain version for that but no luck. Any help?

Sidekiq::ServerMiddleware was introduced in version 6.5.0 so you'll need to check when adding the middleware.
You can wrap the snippet with the following condition
 if Sidekiq::VERSION >= '6.5.0' && (Rails.env.development? || Rails.env.test?)

I've made a PR to add this to the documentation

Thank you! This was very helpful. Closing this now.


handlePastedText is listed in docs but not in npm code yet.

I had to fork, build and copy over editOnPaste to get DraftEditor.handlePastedText.  However, this is listed in the docs https://facebook.github.io/draft-js/docs/api-reference-editor.html#handlepastedtext at the moment.  Curious when the next npm bump is going to be as I need to access the html onPaste to clean up some things (i.e. tables, pasted code from github, etc.).
*Side note: Whats the recommended way to use the latest versions in our npm packages?  Basically to skirt this issue and further similar ones in the future.

I've generally been doing releases on Tuesday afternoons to allow all released changes to already be live in production on FB, as that is when our major weekly release occurs. I'll see about doing one a little sooner than that.
Sorry for the confusion re: docs -- this is an unfortunate drawback of our auto-syncing docs without also pushing a release.
I'm pretty new to npm, so I'm not actually sure of the best way to get the freshest changes without waiting for the next release. @spicyj, @zpao?

Makes sense re: Tuesdays. For upcoming releases you can use npm's dist-tag feature I believe, to create another tag other than latest (which is the default) with the current source on master (you'd need to bump in package.json). The other tag tends to be called next. For an example of a library in the wild that uses that practice, check out Koa.

We've been doing next for React as well. When the release cycle is as fast as draft is going, I'm not sure how valuable publishing an alpha as next would really be. 0.3 is a week old and there have been 2(?) commits to src/ since then. If you absolutely need the latest before it ships anywhere, you can always build locally.


could not use PowerShell to find Visual Studio 2017 or newer

Node Version: v14.17.3, 6.14.13
Platform: Windows 10 Enterprise
Compiler: Microsoft (R) Build Engine version 16.10.2+857e5a733 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

<IP_ADDRESS>804Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30038.1 for x86
Copyright (C) Microsoft Corporation.  All rights reserved.

Module<EMAIL_ADDRESS>
Verbose output (from npm or node-gyp):
C:\projects\browser\build\src\Browser\T_GSPWebsite\node_modules\fibers>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild --release )  else (node "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild --release )
gyp ERR! find VS
gyp ERR! find VS msvs_version was set from command line or npm config
gyp ERR! find VS - looking for Visual Studio version 2019
gyp ERR! find VS running in VS Command Prompt, installation path is:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional"
gyp ERR! find VS - will only use this version
gyp ERR! find VS could not use PowerShell to find Visual Studio 2017 or newer
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - found in "C:\Program Files (x86)\Microsoft Visual Studio 14.0"
gyp ERR! find VS - could not find MSBuild in registry for this version
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS msvs_version does not match this VS Command Prompt or the
gyp ERR! find VS installation cannot be used.
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:74:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:70:14
gyp ERR! stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:384:20
gyp ERR! stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:326:5)
gyp ERR! stack     at ChildProcess.emit (events.js:375:28)
gyp ERR! stack     at maybeClose (internal/child_process.js:1055:16)
gyp ERR! System Windows_NT 10.0.18363
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--release"
gyp ERR! cwd C:\projects\browser\build\src\Browser\T_GSPWebsite\node_modules\fibers
gyp ERR! node -v v14.17.3
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
node-gyp exited with code: 1
Please make sure you are using a supported platform and node version. If you
would like to compile fibers on this machine please make sure you have setup your
build environment--
Windows + OS X instructions here: https://github.com/nodejs/node-gyp
Ubuntu users please run: `sudo apt-get install g++ build-essential`
RHEL users please run: `yum install gcc-c++` and `yum groupinstall 'Development Tools'`
Alpine users please run: `sudo apk add python make g++`
'nodejs' is not recognized as an internal or external command,
operable program or batch file.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\glob-watcher\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node build.js || nodejs build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\ingemar.pertl\AppData\Roaming\npm-cache\_logs\2021-07-20T08_11_27_367Z-debug.log

I tried so many things, it took me hours but without any success ...

The current release of node-gyp is v8.1.0 but the log output above says:

gyp ERR! node-gyp -v v5.1.0

Please use https://github.com/nodejs/node-gyp/blob/master/docs/Updating-npm-bundled-node-gyp.md to upgrade to the current version of node-gyp.
The log output also says that several modules are deprecated and should be upgraded as well.

thanks for the fast response! I upgraded now to gyp ERR! node-gyp -v v8.1.0, but I still see the same issue!

looks like I found the root cause =>  PS stderr = "Add-Type : Cannot add type. Definition of new types is not supported in this language mode.
If I check the language mode, it shows: ConstrainedLanguage
I guess I have to ask my admin to change this to FullLanguage, verify it then again and if the problem was solved, I'll close this issue.

yep, this was the problem. you must have fulllanguage configured!


Vite + Web3 : "TypeError: Cannot read properties of undefined (reading 'call')"

Describe the bug
I am running a vite.js app with web3 installed.
When I run the app in dev mode, all works fine but when I run it in production mode (build + preview) it fails in the console with:
"TypeError: Cannot read properties of undefined (reading 'call')".
The build itself goes through fine.
I can confirm that the error comes from the contract method generated from my ABI:
contract.methods.isOwner(sender).call({from: sender}, function (err, res)
If I comment it out I wont get the error.
Reproduction
https://github.com/nybroe/web3_vite_call_of_undefined/tree/main
System Info
System:
    OS: Windows 10 10.0.19044
    CPU: (16) x64 11th Gen Intel(R) Core(TM) i9-11900K @ 3.50GHz
    Memory: 35.34 GB / 63.73 GB
  Binaries:
    Node: 16.13.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.17 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.1.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (100.0.1185.50)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    vite: ^2.7.2 => 2.9.6

Used Package Manager
npm
Logs
Uncaught TypeError: Cannot read properties of undefined (reading 'call')
    at ny.p1 (index.27fc2391.js:49:31237)
    at new V1 (index.27fc2391.js:49:52721)
    at new ny (index.27fc2391.js:49:55508)
    at index.27fc2391.js:49:57785
    at index.27fc2391.js:49:62620
    at index.27fc2391.js:49:9991
    at b (index.27fc2391.js:49:84520)
    at Object.o (index.27fc2391.js:49:84703)
    at M4 (index.27fc2391.js:50:20041)
    at By (index.27fc2391.js:50:16758)

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I have the same problem as you

Let's keep it as a discussion:

https://github.com/vitejs/vite/discussions/7938

I don't think there is something to solve in Vite, web3 should provide a package that works in the browser. There are some workarounds listed in https://github.com/ChainSafe/web3.js#troubleshooting-and-known-issues, that don't include Vite. Probably other users have encountered this, and they may be able to help.


Codes of September Long

Can anyone assign me this issue ?
I can add the solutions (probably 6 qs out of 8 ) that I have solved here.

Okay assigned,
Happy contributing

Compleed by @KuSantosh100

Thank you @swoyam2609


routes are not loaded when using bootstrap

Information

Version: 5.27.3
Type: Issue

Description
I'm trying to make simple request to server accordingly to example: http://tsed.io/docs/testing.html#test-your-rest-api
However, it returns instead of expected status code just 404, not found.
When I have printed routes, it states, that it's an empty array:
  console.log test/controllers/Test.test.ts:25
      routes []

  ● test › should be forbidden

    expected 403 "Forbidden", got 404 "Not Found"

      at Test.Object.<anonymous>.Test._assertStatus (node_modules/supertest/lib/test.js:268:12)
      at Test.Object.<anonymous>.Test._assertFunction (node_modules/supertest/lib/test.js:283:11)
      at Test.Object.<anonymous>.Test.assert (node_modules/supertest/lib/test.js:173:18)
      at Server.localAssert (node_modules/supertest/lib/test.js:131:12)

Example
import 'jest'
import { TestContext, inject, bootstrap } from '@tsed/testing'
import * as SuperTest from 'supertest'
import {ExpressApplication, RouteService} from "@tsed/common"
import server from './../../src/server'

describe('test', () => {
  let request: SuperTest.SuperTest<SuperTest.Test>
  beforeAll(bootstrap(server))
  let routeService: RouteService

  beforeAll(inject([ExpressApplication, RouteService], (expressApplication: ExpressApplication, routeSvc) => {
    request = SuperTest(expressApplication)
    routeService = routeSvc
  }))

  beforeEach(TestContext.create)
  afterEach(TestContext.reset)

  it('should be forbidden', async () => {
    console.log('routes', routeService.getRoutes())
    await request.get('/test').expect(403)
  })
})

Acceptance criteria

[ ] Routes should be printed
[ ] Test should pass

Hello @vichugunov,
The example work for me and you can checkout getting-started example here: https://github.com/TypedProject/tsed-getting-started/blob/master/test/integration/controllers/calendars/Calendars.spec.ts
Can you remove beforeEach(TestContext.create). Isn't used in the given examle :)
If you routes aren't loaded, you have to check glob pattern set to the mount options in your Server.
See you
Romain

@Romakita I tried to removed it - and it didn't help at all.
I created sandbox project and this error is reproduced: https://github.com/vichugunov/tsed-supertest-sample

just run npm start to see that it's alive and npm test to reveal that problem

Ok the problem come from jest. Dynamic import doesn't work in jest context after typescript compilation (ts-jest override module,fs etc...)
So to solve it have differents options:

import manually Controller/Service/etc... and use mount: {'/': [MyController]}
use mocha instead of jest
find a way to tell jest how it have to load typescript file dynamically.

Unfortunately, I can't help you to configure jest correctly jest for this usecase.
See you
Romain

@Romakita thanks, first variant works for me.
As far, as I understood, that I need to find a way to require all files like that's done here: https://github.com/TypedProject/ts-express-decorators/blob/master/test/mocha.opts
If I find a way to do that - I will post that here.
Thanks for quick response and for help

I think, jest or ts-jest should have a part dedicated to resolve module with the import() syntax.
If you find solution, yes I'll take it and create a new example repo about jest configuration :)
Thanks  ;)

And the easiest way is to require precompiled version of server within tests =)
But yes, that's definitely not clean solution.


docs: how to test component library locally

Impact: minor
Type: docs
Adding instructions on how to use a local version of the component library inside storefront and the operator UI. Instructions taken, and slightly modified per repo, from here: https://github.com/reactioncommerce/reaction-component-library/pull/395

🚀 Preview deployed
Built with commit b0aa1e1bb015e6313557640c804baeb6d3efbbcd
https://deploy-preview-401--stoic-hodgkin-c0179e.netlify.com

:tada: This PR is included in version 0.65.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[feature] Continuous, unattended Google Cloud Storage collection

Hi,
In this PR https://github.com/guacsec/guac/pull/989, we exposed the GCS collector via the guacone CLI, this means that an user can on-demand collect SBOMs and other pieces of metadata form a GCS bucket.
This issue is about being able to configure such process but in such as way that is run periodically and unattended.
Describe the solution you'd like
I want to be able to configure Guac with tuples of bucket + credentials that the system could use to fetch periodically data from those data sources.
Describe alternatives you've considered
I've considered using guacone itself with a cron-like daemon, but I wanted to explore if this could become a first-class feature, since some of the foundations seems to be there (oci+git datasources)
Additional context
Our goal is to allow Chainloop users to be able to send SBOMs end to end automatically.
The first leg of the journey (CI -> GCS bucket) is fully automated but the last leg (GCS -> Guac) requires manual intervention via guacone collect #989. And it is this last leg what we want to automate too.

Note: it might be possible that this feature might exist already and I am just not able to figure out how to configure it.

Thanks!
Refs https://github.com/chainloop-dev/chainloop/issues/209

Ah yes - we have collectors that can run as daemons - which I believe should do exactly what you're asking for.
We have this being done for files, would something like this work?
https://github.com/guacsec/guac/blob/main/cmd/guaccollect/cmd/files.go
$ bin/guaccollect files --help
take a folder of files and create a GUAC graph utilizing Nats pubsub

Usage:
  guaccollect files [flags] file_path

Flags:
  -h, --help   help for files

Global Flags:
      --csub-addr string   address to connect to collect-sub service (default "localhost:2782")
      --nats-addr string   address to connect to NATs Server (default "nats://<IP_ADDRESS>:4222")
      --service-poll       sets the collector or certifier to polling mode (default true)
      --use-csub           use collectsub server for datasource (default true)

The only one caveat about this (for now) is there's a current known issue for large document files #731, which I am currently working on in the coming weeks.

+1 to @lumjjb, the GCS (and all the other collectors) are already set up to do polling to fetch periodically.


dune_3: 3.7.1 -> 3.8.0

Description of changes
Diff: https://github.com/ocaml/dune/compare/3.7.1...3.8.0
Changelog: https://github.com/ocaml/dune/blob/3.8.0/CHANGES.md

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

It seems that 3.8.1 is out, addressing the regressions in 3.8.0.

Superseded by #233595.


accounts ui: List of accounts doesn't scroll when more than a screenful

I would like to work on this issue!
My work so far:

Before
After

Sure — please go ahead. That behavior looks good.


Language Client services has not been installed

Running the follow code would throw the Language Client services has not been installed
MonacoServices.install(monaco);

how can i solve this problem?
versions:
monaco-editor: 0.24.0
monaco-languageclient: 0.14.0
@codingame/monaco-jsonrpc: 0.3.1

Is there a reason you're still using very old versions?

because in my project, i use vscode theme in monaco-editor,  the vscode theme could not work when i try to upgrade the monaco-editor versions. That is why the monaco-editor versions is old.
the second reason is there has another error when i try to use the monaco-languageclient v4.0.0, so i choised the v0.14.0.
i’m not very good at english, i hope i made myself clear, thanks.

We won't be able to provide support for old version of this library
Btw, you may have a look at monaco-vscode-api (which is used by this library) that allows to use vscode themes and textmate (but I'm not sure what you are doing with vscode themes exactly)

We won't be able to provide support for old version of this library
Btw, you may have a look at monaco-vscode-api (which is used by this library) that allows to use vscode themes and textmate (but I'm not sure what you are doing with vscode themes exactly)
we can't probably help you on the error you get with the last version though

I have just upgraded monaco-languageclient to version 4.0, in the old version, i need write the follow code to void the.Can not find module 'vscode' ,
vscode: require.resolve('monaco-languageclient/lib/vscode-compatibility')
but now the version 4.0 not support that, so the error about Can not find module 'vscode' throw again. how can i solve this problem in the 4.0 version?

You should not try to resolve it by hands with the last version, it's supposed to work because monaco-vscode-api is installed as vscode (npm install vscode@npm:@codingame/monaco-vscode-api)
I don't know what's wrong with your project, you can try removing the package-lock and running npm install again

it works for me now. thanks very much!


Enhanced CI/CD for release 0.7.0

CI/CD needs to be enhanced to include more test-cases

CICD automation has been huge improved and all status can be found here . For all new-features CICD will be continuously strengthened.


Can not run python3 -m pip install -r requirements.txt or pip3 install manimlib

I was following along with the installation video by @Elteoremadebeethoven and was not able to python3 -m pip install -r requirements.txt. The error says ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'requirements.txt' even though the file does exist in the download folder and in the ManimInstall folder I made (from installation tutorial video).
I then looked at the official manim page and the README says to do that for direct install, but I can also do pip3 install manimlib. When I try this I get the following errors:
ERROR: Could not find a version that satisfies the requirement opencv-python==<IP_ADDRESS> (from manimlib) (from versions: <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>)
ERROR: No matching distribution found for opencv-python==<IP_ADDRESS> (from manimlib)

What is your python version ?

I'm seeing this when running pip install manimlib also. Info:
$ python --version
Python 3.8.0
$ pip --version
pip 20.0.2

Have you checked your directory whether in the manim-master folder or not?
use cd to direct to the manim-master folder and run the python3 -m pip install -r requirements.txt

Or you can upgrade your pip

The issue with the opencv-python version complaining was for me just because I was using 3.8 instead of 3.7. Changing Python version using pyenv or similar fixes this.

Great. I fixed it by upgrading pip and python. Thanks!


Implement UserAddressModal

Features

Introduced react-qr-code
Fixed AppButton classname handling
Implemented UserAddressModal
Adapt model and display when user clicks on Receive shortcut button

Screenshots

Desktop
Mobile

based on #73
refs #58

not sure if keplr has api for this but can we make a option to trigger hardware wallets to show addr on-device?

plz rebase 🙏


Request to add our code to repository

Thanks for the great repository!
We've released code for "Category-Aware Allocation Transformer for Weakly Supervised Object Localization" (Recognition: Detection). Please consider adding our repo: https://github.com/zhiweichen0012/CATR.

Hi @zhiweichen0012,
Repository added successfully. Thanks for sharing!


C3D features

could you release the c3d features for charades?

You can refer to the README here: https://github.com/zmzhang2000/MIGCN

they only  provide i3d features for charades


publish cell_census package on pypi

cell-census package needs changes to enable publishing on PyPi
Dependent on single-cell-data/TileDB-SOMA#494

Resolved by #50


Update Node docs to change iOS to Android for NOTIFICATION_WM_GO_BACK_REQUEST

In the documentation for NOTIFICATION_WM_GO_BACK_REQUEST, it says
(e.g., pressing the 'Back' button on Android).
However, below it says that it's only implemented on iOS. Since iOS doesn't have a back button like Android, this should say that it's implemented only on Android.

Thanks! And congrats for your first merged Godot contribution :tada:


Out of memory when running model.cuda()

I got a strange problem when training SECOND and PointPillars:
Traceback (most recent call last):
  File "tools/train.py", line 243, in <module>
    main()
  File "tools/train.py", line 227, in main
    meta=meta)
  File "mmdet3d/apis/train.py", line 34, in train_model
    meta=meta)
  File "/root/.pyenv/versions/3.6.8/lib/python3.6/site-packages/mmdet/apis/train.py", line 79, in train_detector
    model.cuda(),
  File "/root/.pyenv/versions/3.6.8/lib/python3.6/site-packages/torch/nn/modules/module.py", line 637, in cuda
    return self._apply(lambda t: t.cuda(device))
  File "/root/.pyenv/versions/3.6.8/lib/python3.6/site-packages/torch/nn/modules/module.py", line 530, in _apply
    module._apply(fn)
  File "/root/.pyenv/versions/3.6.8/lib/python3.6/site-packages/torch/nn/modules/module.py", line 530, in _apply
    module._apply(fn)
  File "/root/.pyenv/versions/3.6.8/lib/python3.6/site-packages/torch/nn/modules/module.py", line 530, in _apply
    module._apply(fn)
  [Previous line repeated 1 more time]
  File "/root/.pyenv/versions/3.6.8/lib/python3.6/site-packages/torch/nn/modules/module.py", line 552, in _apply
    param_applied = fn(param)
  File "/root/.pyenv/versions/3.6.8/lib/python3.6/site-packages/torch/nn/modules/module.py", line 637, in <lambda>
    return self._apply(lambda t: t.cuda(device))
RuntimeError: CUDA error: out of memory

The OOM error is raised when moving the model to GPU (model.cuda()). There is no GPU resources competition.
Since I use the standard training config, it is impossible to produce such a model large enough to consume ~11 GB of memory.
The issue seems related to the running environment, because it disappears after switching to another server (with the same image).
Though it is solved, I have no idea for the real reasons. I can't understand it at all.
Does anyone know the reasons?

Please provide more information following the issue template for reimplementation and also your used config. The current cues are far not enough for us to help you find the reason.

@Tai-Wang Thanks for reply. I find this issue is not related to MMDetection3D. A simple code snippet can reproduce this error.
>>> import torch
>>> torch.rand(1).cuda(0)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
RuntimeError: CUDA error: out of memory
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
>>> torch.rand(1).cuda(1)
tensor([0.7275], device='cuda:1')

It seems that this issue is not related to MMDetection3D, so I close this issue. You are definitely welcome to comment on this strange problem.


Migrate from nose to pytest for unit tests

nose is not being developed anymore and we should probably migrate to pytest for unit tests (as most packages in the Python ecosystem have done or are in the process of doing).
This would allow to greatly simplify writing of unit tests, e.g. instead of
self.assertTrue(np.allclose(res, np.array([0.98, 1.05]), 0.01, 0.01))

one could simply write
assert np.allclose(res, np.array([0.98, 1.05]), 0.01, 0.01)

and pytest would handle everything. Actually in this case,
from numpy.testing import assert_allclose

assert_allclose(res, np.array([0.98, 1.05]), 0.01, 0.01)

would be even better.
Note: numpy.testing might still require to install nose (particularly for older numpy versions).

I didn't know nose was no longer being supported... seemed like that was all the rage in Python testing when I started this a few years ago... anyways, sounds good, as we work on updates lets change the corresponding tests, that way eventually they'll all get updated
(unless someone wants to just take out a PR to change them all at once... but I think for now, with everything else going on, changing the tests as we work on related things might be best)


Remove duplicates

Automatically remove duplicated lines in txt proxy files.

Hi. They are already being removed.

How can I make it fetch more?

Set higher TIMEOUT in the config.

But will the proxies be working? I use the proxies in puppeteer


Identity server is not retrying for failed db calls

Please only use the issue tracker for bug reports and/or feature requests. For general security questions, or free or commercial support options do not use the issue tracker and instead see here for more details.
For bug reports,  include the relevant log files related to your issue. See here how to enable logging. Delete this line once you have.
Finally, please keep the issue concise and to the point. If you paste in more code than the text for the issue you are reporting then we will most likely not read it.
Issue / Steps to reproduce the problem
Relevant parts of the log file
<log goes here>

Hi,
I am using IdentityServer3.EntityFramework. Identity server is not retrying for failed database calls. It should retry again if  database call fails.

https://github.com/IdentityServer/IdentityServer3#note-this-repository-is-no-longer-in-active-development-or-maintenance-other-than-reported-security-vulnerabilities

Hi  brockallen
Thanks for quick response.
Is retry possible for failed identity database  calls in IdentityServer4.EntityFramework?

It's possible, but we don't currently do that. What's the use-case or scenario you're trying to address?

For cases when database is down for a particular instance of time, some transient issues occur due to connection establishment failure. By implementing retry logic, we want to avoid such transient issues.

Well, we don't have anything like that built-in, but if you need that you can implement any of the store interfaces and add that logic.


Intro image has a slight different color?

Hi there,
Do you have any idea why the intro image has a slightly different color?
The website
The original jpeg
Thank you
Weiming

That's correct, there is a an overlay to unify the colors. Here's the relevant CSS line if you want to remove it.
At some point I'll add a toggle to disable.

Awesome.  Thank you!

This is now fixed on master. Add the following to your CSS to disable the color overlay:
$intro-image-color-overlay: false;

Thank you!


[$1000] IOU - When performing an invoice division in a group, the amount of this is set to zero

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

First login to different accounts which two different users, one as user A and the other as user B
Create a group that includes user A and user B.
[user A] Start chat in the group.
[user B] Enter in the group
[user A] Click plus sign and select Split bill.
[user A] Write a number, click Next button and Split button

Expected Result:
Group members should see the split bill amount
Actual Result:
Split invoice amount is set to zero
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome

Version Number: 1.3.57-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/44fb2977-3da5-4490-bc6b-6db38461a5b3
https://github.com/Expensify/App/assets/78819774/015e82ed-86d1-4b0c-a2e4-dd668d3a64b2
Expensify/Expensify Issue URL:
Issue reported by: @Mauri-salazar)
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692290507391009
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018591b88c96d0a9bb
Upwork Job ID:<PHONE_NUMBER>472058368
Last Price Increase: 2023-09-04

Waiting for proposals.

Proposal
Please re-state the problem that we are trying to solve in this issue.
While sending a "Split bill" request in a group, other participants see the MoneyRequestPreview with $0
What is the root cause of that problem?
While executing the splitBill, the transaction is created optimistically:
https://github.com/Expensify/App/blob/575524c47efd78cdf1f18a3a40f04a54dcbfb036/src/libs/actions/IOU.js#L910
This leads to the transaction not yet being accessible in Onyx when the MoneyRequestPreview component is rendering: https://github.com/Expensify/App/blob/0343bfeda5bdb45140fa5464ca4a9e9390ad30c8/src/components/ReportActionItem/MoneyRequestPreview.js#L340
Therefore, both the currency and amount are set to default: $0.
What changes do you think we should make in order to solve the problem?

When rendering MoneyRequestPreview:
if (_.isEmpty(props.transaction)) -> force Report.openReport(props.chatReportID) in order to fetch the updated data

What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01998fcb3ca1e361ed

Proposal
Please re-state the problem that we are trying to solve in this issue.
When users split a bill in a group, the amount of the split is set to zero.
What is the root cause of that problem?
The root cause of this problem can be traced to specific lines of code:
https://github.com/Expensify/App/blob/bb432aa6d787c6ba95faed521286cd169cbcade6/src/components/ReportActionItem/MoneyRequestPreview.js#L151
https://github.com/Expensify/App/blob/bb432aa6d787c6ba95faed521286cd169cbcade6/src/components/ReportActionItem/MoneyRequestPreview.js#L344-L346
In these code snippets, action.originalMessage.IOUTransactionID contains the correct value, but the transaction data isn't present in the OnyxDB. This is due to the fact that only the report and reportAction are being updated, while the transaction is not. As a result, when props.transaction is accessed, it returns an empty object ({ }), leading to the displayed transaction amount being zero.

What changes do you think we should make in order to solve the problem?
To resolve this issue, I suggest the following approach:
https://github.com/Expensify/App/blob/bb432aa6d787c6ba95faed521286cd169cbcade6/src/pages/home/ReportScreen.js#L279-L283
https://github.com/Expensify/App/blob/6e17b64be0e571773bed42446346045c659640d6/src/pages/home/ReportScreen.js#L208-L224
In this code snippet, the changes involve:

Ensuring that the report fetch is triggered only if specific conditions are met.
Adding the ability to force fetch data without adhering to these conditions.

if (onyxReportID === prevReport.reportID && (!onyxReportID || onyxReportID === routeReportID) && !ReportUtils.isUnread(report)) {
  return;
}

fetchReportIfNeeded(true);

The function ReportUtils.isUnread determines whether a report has been read or remains unread.
The function fetchReportIfNeeded should also be updated as follows:
const fetchReportIfNeeded = useCallback((shouldFetch = false) => {
    const reportIDFromPath = getReportID(route);
    if (!reportIDFromPath) {
        return;
    }
    if (!shouldFetch && report.reportID && report.reportID === getReportID(route)) {
        return;
    }
    Report.openReport(reportIDFromPath);
}, [report.reportID, route]);

In this updated function, the shouldFetch parameter enables a forced fetch without meeting the usual conditions.
Additionally, we should modify the code as follows:
https://github.com/Expensify/App/blob/bb432aa6d787c6ba95faed521286cd169cbcade6/src/components/ReportActionItem/MoneyRequestPreview.js#L151
const {
        amount: requestAmount,
        currency: requestCurrency,
        comment: requestComment,
        merchant: requestMerchant,
    } = _.isEmpty(props.transaction) ? lodashGet(props.action, 'originalMessage', {}) : ReportUtils.getTransactionDetails(props.transaction);

This modification temporarily uses props.action.originalMessage when props.transaction is empty, providing a workaround to populate the transaction data.

Lastly, in the section of code related to handling the report action item press, adjustments are necessary to ensure that the component is unavailable to press when props.transaction is empty:
https://github.com/Expensify/App/blob/bb432aa6d787c6ba95faed521286cd169cbcade6/src/components/ReportActionItem/MoneyRequestPreview.js#L307-L309
if (!props.onPreviewPressed || _.isEmpty(props.transaction)) {
  return childContainer;
}

Result
https://github.com/Expensify/App/assets/136437976/6ff6c830-aac7-4e20-97a3-82a05850f0a2
What alternative solutions did you explore? (Optional)
Initially, I attempted to modify the fetchReportIfNeeded function to fetch the report, but this approach didn't provide the desired behavior. The amount in the MoneyRequestPreview component was briefly set to zero before displaying the correct value. This wasn't the desired behavior.
Subsequently, I made modifications to the MoneyRequestPreview component, preventing rendering when props.transaction is empty. However, this resulted in the manager's split bill information being displayed without any visible element, which was also undesirable.
The final solution, as proposed, was achieved by modifying the MoneyRequestPreview component to display temporary split bill information while fetching and updating the OnyxDB to include transaction data.
This approach addressed the issue effectively while considering user interaction scenarios.

Could you review the proposals here @aimane-chnaif?

@lschurr even though an idea of getting paid for this issue seems appealing, I think it will be mostly handled now in https://github.com/Expensify/App/issues/26270
However, the skeleton will still be visible for about a minute (until the next Ping request comes), as the inexistent transaction issue will still be in place.
Taking that into consideration, I would modify my proposal by only keeping the part about calling Report.openReport() if we receive such a request with a not-yet-existing transaction ID.

Agreed. I would close this report.

https://github.com/Expensify/App/issues/26518#issuecomment-1703287836
Perhaps, the team don't want to add skeleton UI.

Huh, I was unaware of that. In this case I'm keeping my initial proposal🙂

@aimane-chnaif could you please review?

Bump @aimane-chnaif

Proposal
Updated proposal https://github.com/Expensify/App/issues/26020#issuecomment-1698344130

@lschurr @aimane-chnaif I've updated my initial proposal.
However, if you think that "skeleton view is stuck" is now a different issue that the one stated in this issue, I have reported it here: https://expensify.slack.com/archives/C049HHMV9SM/p1694182124123539

Bump @aimane-chnaif

Bumped in Slack as well - https://expensify.slack.com/archives/C01GTK53T8Q/p1694947661478389

Proposal
Please re-state the problem that we are trying to solve in this issue.
When users split a bill in a group, the amount of the split is set to zero.
What is the root cause of that problem?
The root cause of this problem can be traced to specific lines of code:
https://github.com/Expensify/App/blob/bb432aa6d787c6ba95faed521286cd169cbcade6/src/components/ReportActionItem/MoneyRequestPreview.js#L151
https://github.com/Expensify/App/blob/bb432aa6d787c6ba95faed521286cd169cbcade6/src/components/ReportActionItem/MoneyRequestPreview.js#L344-L346
In these code snippets, action.originalMessage.IOUTransactionID contains the correct value, but the transaction data isn't present in the OnyxDB. This is due to the fact that only the report and reportAction are being updated, while the transaction is not. As a result, when props.transaction is accessed, it returns an empty object ({ }), leading to the displayed transaction amount being zero.
What changes do you think we should make in order to solve the problem?
To resolve this issue, I suggest the following approach:
https://github.com/Expensify/App/blob/bb432aa6d787c6ba95faed521286cd169cbcade6/src/pages/home/ReportScreen.js#L279-L283
https://github.com/Expensify/App/blob/6e17b64be0e571773bed42446346045c659640d6/src/pages/home/ReportScreen.js#L208-L224
In this code snippet, the changes involve:

Ensuring that the report fetch is triggered only if specific conditions are met.
Adding the ability to force fetch data without adhering to these conditions.

if (onyxReportID === prevReport.reportID && (!onyxReportID || onyxReportID === routeReportID) && !ReportUtils.isUnread(report)) {
  return;
}

fetchReportIfNeeded(true);

The function ReportUtils.isUnread determines whether a report has been read or remains unread.
The function fetchReportIfNeeded should also be updated as follows:
const fetchReportIfNeeded = useCallback((shouldFetch = false) => {
    const reportIDFromPath = getReportID(route);
    if (!reportIDFromPath) {
        return;
    }
    if (!shouldFetch && report.reportID && report.reportID === getReportID(route)) {
        return;
    }
    Report.openReport(reportIDFromPath);
}, [report.reportID, route]);

In this updated function, the shouldFetch parameter enables a forced fetch without meeting the usual conditions.
Additionally, we should modify the code as follows:
https://github.com/Expensify/App/blob/bb432aa6d787c6ba95faed521286cd169cbcade6/src/components/ReportActionItem/MoneyRequestPreview.js#L151
const {
        amount: requestAmount,
        currency: requestCurrency,
        comment: requestComment,
        merchant: requestMerchant,
    } = _.isEmpty(props.transaction) ? lodashGet(props.action, 'originalMessage', {}) : ReportUtils.getTransactionDetails(props.transaction);

This modification temporarily uses props.action.originalMessage when props.transaction is empty, providing a workaround to populate the transaction data.

Lastly, in the section of code related to handling the report action item press, adjustments are necessary to ensure that the component is unavailable to press when props.transaction is empty:
https://github.com/Expensify/App/blob/bb432aa6d787c6ba95faed521286cd169cbcade6/src/components/ReportActionItem/MoneyRequestPreview.js#L307-L309
if (!props.onPreviewPressed || _.isEmpty(props.transaction)) {
  return childContainer;
}

Result
https://github.com/Expensify/App/assets/136437976/6ff6c830-aac7-4e20-97a3-82a05850f0a2
What alternative solutions did you explore? (Optional)
N/A

Any update @aimane-chnaif?

Bumped in Slack - https://expensify.slack.com/archives/C01GTK53T8Q/p1695790942443119

@aimane-chnaif the root cause is different, it's a regression from https://github.com/Expensify/App/pull/25629
But in order to propose a solution I need to understand, what is the expected text to be displayed for such scenario?

Proposal
Please re-state the problem that we are trying to solve in this issue.
After a split bill request is created in a group, the group's text in LHN shows "owes $0.00"
What is the root cause of that problem?
The root cause lies here:
https://github.com/Expensify/App/blob/0c49b1198357f33f443543d6873badafd009b093/src/libs/OptionsListUtils.js#L392-L393
We are checking if the last report action is a money request action. However, we do not check if the report itself is an IOU report.
The group chat is not an IOU report, but the split action is the MoneyRequest action, therefore we proceed to calculate the last message as if the report was an IOU one.
What changes do you think we should make in order to solve the problem?
We need to check if the report is an IOU report.
+} else if (ReportUtils.isIOUReport(report) && ReportActionUtils.isMoneyRequestAction(lastReportAction)) {
-} else if (ReportActionUtils.isMoneyRequestAction(lastReportAction)) {

What alternative solutions did you explore? (Optional)

@aimane-chnaif please see the proposal above and share your thoughts on the mentioned localization matters.

Bump @aimane-chnaif

Would the LNH last message fix still be necessary if the backend is fixed? 🤔

Got it, thanks for the review- let's move forward with @paultsimura's second proposal

@robertjchen for some reason, the automation was not triggered after the assignment – could you please trigger it?

Any update @paultsimura?

@aimane-chnaif could you work through the checklist?

Payment summary:

Bug reporter: @Mauri-salazar $50
Contributor: @paultsimura $1500
Contributor+: @aimane-chnaif $1500

This is done!


Fails to build with latest version of three.js

I have had to use the latest version of three.js in my project as a dependency. Since upgrade my project fails to build with the following error:
Failed to compile.

/MyProject/node_modules/three-glow-mesh/dist/index.module.js
Attempted import error: 'Face3' is not exported from 'three' (imported as 'o').

error Command failed with exit code 1.

It looks like three.js made a breaking change and it requires your library to be updated.
My dependency on three-glow-mesh is because I am using react-globe.
Thanks!

found same problem

found same problem. Face3 was remove in r126 and now the latest is r128

any solution for this?

Still facing this issue! Any fix for this?


fixed: duplicate mail user bug

📋 Description
Enforce Unique Email Addresses in User Registration
🔨 Changes Made
Updated the user registration logic to check for the uniqueness of the email address in addition to the username.
Added appropriate error handling to inform the user when attempting to register with an already used email.

Added a unique property to email in user schema in models.
Created a schema for username in user schema in models.

✅ Checklist
Before submitting the PR, please make sure you have completed the following:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation (if applicable).
[x] My changes generate no new warnings.
[x] I have tested it locally and it works fine.
[x] Any dependent changes have been merged and published in downstream modules.

🏷 Types of Changes
What type of changes does your code introduce? (Check all that apply)

[x] Bug fix (non-breaking change which fixes an issue) 🐛
[ ] New feature (non-breaking change which adds functionality) ✨
[ ] UI enhancement (non-breaking change which enhances UI) 🎨
[ ] Documentation update 📚

🤝 Related Issues

Fixes #181

Reminder:
Please ensure your pull request is made to the test branch, not main.
Thank you for contributing to VigneshDevHub! We look forward to reviewing your PR and getting it merged!

Hey, It does not work!

Hey @Gobinath-B, are you working on this issue?


Replace deprecated word-break by overflow-wrap

word-break is deprecated, overflow-wrap is the correct method to break words.

What is the impact on browser compatibility?

Compatibility is not perfect so it seems. But word-break: break-word has an even worse browser support. The best solution can be using the unofficial but better supported word-wrap: break-word.
https://caniuse.com/#feat=mdn-css_properties_overflow-wrap
https://caniuse.com/#feat=mdn-css_properties_word-break_break-word
https://caniuse.com/#feat=mdn-css_properties_word-wrap

Compatibility is really great actually. Word-wrap is supported even in IE6, whereas word-break is not.

The CSS declaration word-break: break-word is the equivalent of overflow-wrap: anywhere, and not the equivalent of overflow-wrap: break-word.
From the MDN docs for word-break:

break-word
Has the same effect as word-break: normal and overflow-wrap: anywhere, regardless of the actual value of the overflow-wrap property.

From the MDN docs for overflow-wrap:

anywhere
To prevent overflow, an otherwise unbreakable string of characters — like a long word or URL — may be broken at any point if there are no otherwise-acceptable break points in the line. No hyphenation character is inserted at the break point. Soft wrap opportunities introduced by the word break are considered when calculating min-content intrinsic sizes.
break-word
The same as the anywhere value, with normally unbreakable words allowed to be broken at arbitrary points if there are no otherwise acceptable break points in the line, but soft wrap opportunities introduced by the word break are NOT considered when calculating min-content intrinsic sizes.

Unfortunately, overflow: anywhere is not supported in Internet Explorer. Therefore, I will not commit this change to the standard version of sanitize.css, but I will make change the declaration to overflow-wrap: anywhere in the upcoming evergreen version.


AlertDialog documentation needs small update

Describe the bug
The call const cancelRef = React.useRef() in the sample AlertDialog documentation (https://chakra-ui.com/docs/components/alert-dialog) needs to be updated to
const cancelRef = useRef<HTMLButtonElement>(null); to avoid TypeScript errors
Your minimal, reproducible example
https://chakra-ui.com/docs/components/alert-dialog
Steps to reproduce

Copy paste the code from the example into your code
Run the typescript compiler
Error:
Type 'MutableRefObject<undefined>' is not assignable to type 'RefObject<FocusableElement>'. Types of property 'current' are incompatible.  Type 'undefined' is not assignable to type 'FocusableElement | null'.ts(2322) alert-dialog.d.ts(18, 5): The expected type comes from property 'leastDestructiveRef' which is declared here on type 'IntrinsicAttributes & AlertDialogProps'

Expected behavior
Make the minor update to the documentation and many users will be cheering.
How often does this bug happen?
Every time
Screenshots or Videos

Platform
OS: MacOS
Chrome Version 114.0.5735.198 (Official Build) (arm64)
Tanstack Query adapter
react-query
TanStack Query version
"@tanstack/react-query": "^4.29.12",
TypeScript version
"typescript": "^5.0.2",
Additional context
No response

okay?

Hello @TkDodo. Your response is brief and not sure what you are asking for. I trust this request simple and would help users.

Ahm, why exactly did you open an issue about chakra-ui in TanStack/query ?

Now I understand. Please accept my apologies for creating this bug report in the wrong category. Please consider this closed and I will create the bug in the correct place. Have a great day.


Parse lat long

Resolution of Github Taxonworks Issue #103: New Task: Stepwise lat long extraction from collecting events
Added files:

controllers/tasks/collecting_events/parse/stepwise/lat_long_controller.rb
helpers/tasks/collecting_events/parse/stepwise/lat_long_helper.rb
views/tasks/collecting_events/parse/stepwise/lat_long/index.html.erb
assets/javascript/views/tasks/collecting_events/parse/stepwise/lat_long/index.js
views/tasks/collecting_events/parse/stepwise/lat_long/_matching_table.html.erb
lib/queries/collecting_event_lat_long_extractor_query.rb
RSpecs for controller and helper

Coverage decreased (-0.2%) to 89.622% when pulling 8c7e463aaba0d520434865ae0927be9452ec5cb6 on parse_lat_long into 056c47001a071324960d49a937989cd599a4016d on development.

My bad, didn't see the return json, it stays.
On Mar 31, 2017 8:50 AM, "James Tucker"<EMAIL_ADDRESS>wrote:

@TuckerJD commented on this pull request.
In app/controllers/tasks/collecting_events/parse/
stepwise/lat_long_controller.rb
https://github.com/SpeciesFileGroup/taxonworks/pull/110#discussion_r109163843
:

   end

   message += 'the collecting event.'

end

if success

 flash['notice'] = 'Updated.' unless no_flash # if we skipped, there is no flash

else

 flash['alert'] = message

 next_id        = current_collecting_event.id

end

where do we go from here?

redirect_to collecting_event_lat_long_task_path(collecting_event_id: next_id,

                                               filters:             parse_filters(params))

end

def convert

It's a landing point (route). Where does it belong?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SpeciesFileGroup/taxonworks/pull/110#discussion_r109163843,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABYSNFHdDEQnuPKsd-Rqc76-FjGlNJLks5rrQSwgaJpZM4Ms7S3
.

Is it a route as well?
M
On Fri, Mar 31, 2017 at 10:55 AM, James Tucker<EMAIL_ADDRESS>wrote:

@TuckerJD commented on this pull request.
In app/controllers/tasks/collecting_events/parse/
stepwise/lat_long_controller.rb
https://github.com/SpeciesFileGroup/taxonworks/pull/110#discussion_r109192301
:

end

TODO: deprecate for valud from view/helper

def next_collecting_event_id
filters = parse_filters(params)
Queries::CollectingEventLatLongExtractorQuery.new(

 collecting_event_id: collecting_event_id_param,

 filters:             filters)

 .all

 .with_project_id(sessions_current_project_id)

 .order(:id)

 .limit(1)

 .pluck(:id)[0]

end

def current_collecting_event

That's odd; you were the one who put it in the controller....
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SpeciesFileGroup/taxonworks/pull/110#discussion_r109192301,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABYSOcDbA2fqo_kUB8CpD1QI-cwUX7sks5rrSHogaJpZM4Ms7S3
.

No

James Tucker, Programmer
Species File Group,
Illinois Natural History Survey,
Prairie Research Institute at the University of Illinois, Urbana-Champaign.
TuckerJD<EMAIL_ADDRESS>217-244-9416
From: Matt <notifications<EMAIL_ADDRESS>Reply-To: SpeciesFileGroup/taxonworks <reply<EMAIL_ADDRESS>Date: Friday, March 31, 2017 at 11:01
To: SpeciesFileGroup/taxonworks <taxonworks<EMAIL_ADDRESS>Cc: James Tucker <TuckerJD<EMAIL_ADDRESS>Mention <mention<EMAIL_ADDRESS>Subject: Re: [SpeciesFileGroup/taxonworks] Parse lat long (#110)
Is it a route as well?
M
On Fri, Mar 31, 2017 at 10:55 AM, James Tucker <notifications<EMAIL_ADDRESS>wrote:

@TuckerJD commented on this pull request.
In app/controllers/tasks/collecting_events/parse/
stepwise/lat_long_controller.rb
https://github.com/SpeciesFileGroup/taxonworks/pull/110#discussion_r109192301
:

end

TODO: deprecate for valud from view/helper

def next_collecting_event_id
filters = parse_filters(params)
Queries::CollectingEventLatLongExtractorQuery.new(
collecting_event_id: collecting_event_id_param,
filters: filters)
.all
.with_project_id(sessions_current_project_id)
.order(:id)
.limit(1)
.pluck(:id)[0]
end

def current_collecting_event

That's odd; you were the one who put it in the controller....
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SpeciesFileGroup/taxonworks/pull/110#discussion_r109192301,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABYSOcDbA2fqo_kUB8CpD1QI-cwUX7sks5rrSHogaJpZM4Ms7S3
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SpeciesFileGroup/taxonworks/pull/110#issuecomment-290753980, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABwOEjY6oPKEXAhhFHQXQFrjQ6GgOM7hks5rrSNPgaJpZM4Ms7S3.

Coverage decreased (-0.2%) to 89.628% when pulling 73f0b05d87cb7b88fd4a74fb4ddcccfdcabcdfa4 on parse_lat_long into 7964a66826e467fc684a32b123bb2bf050881884 on development.

Changes Unknown when pulling 72ef1abd092182fa704ef3ce0863f3bd803b8b12 on parse_lat_long into ** on development**.

Coverage decreased (-0.2%) to 89.628% when pulling 9e89b99faf13a35fa28793cc1ee5d673f689be7d on parse_lat_long into 2f90a1a80c1e69416eebc0584fda904c1fcadab9 on development.

Coverage decreased (-0.2%) to 89.63% when pulling 17c54367681001b8632ddf09a8a37926e58c2e5a on parse_lat_long into 2f90a1a80c1e69416eebc0584fda904c1fcadab9 on development.

Coverage decreased (-0.2%) to 89.629% when pulling d20b8ffa0a1c55e8f93d312c7c1e197421940294 on parse_lat_long into 2f90a1a80c1e69416eebc0584fda904c1fcadab9 on development.

Coverage decreased (-0.1%) to 89.629% when pulling ed4e49c2151827238c74940ceed480873342b666 on parse_lat_long into 7dfecf7063389a6ea4c90342ca1c87ee811510e6 on development.

Changes Unknown when pulling 8d51cb0eaedd32f3cd2476a21e84a4e8253905c8 on parse_lat_long into ** on development**.

All issues explained or fixed.


Joel's capstone data

@liljfrk3 do you not have direct access to push directly to your repository? I'm happy to merge this pull request on your behalf, but I won't be checking anything. Let me know what you want to do; and if I need to give you direct access to the repo.

Ben,
I pushed it to the GT edx-insights repository already
Joel
On Tuesday, December 22, 2015 1:36 PM, Benjamin Bengfort<EMAIL_ADDRESS>wrote:

@liljfrk3 do you not have direct access to push directly to your repository? I'm happy to merge this pull request on your behalf, but I won't be checking anything. Let me know what you want to do; and if I need to give you direct access to the repo. —
Reply to this email directly or view it on GitHub.

Alright - then I'll go ahead and close this pull request.


Organizations management page

Summary
First version of the Organization management page, showing how to use the Portal and explaining concepts.
Checklist

[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking,
as they show up in the changelog
[ ] Update tests.
[ ] Link this PR to related issues.

Ready for review @corvus-ch @tobru !

Merging!


🐛 when browsing by subject area sort alphabetically

Describe the bug.
🐛 when browsing by subject area sort alphabetically
To Reproduce
No response
Expected Behaviour
No response
Additional context
No response

talk about with tochi


Typescript for Validation of Attributes

I am reading the documentation and see that a large part of the validation logic for attributes is to create a Javascript object that basically has the same information that Typescript would have.
I am curious if there is a goal to create a Typescript plugin or better built-in support for Typescript? As you can imagine, writing all that code is tedious, and Typescript is a very powerful and widely adopted tool to convey that same information.

@JitPackJoyride the custom attribute types actually are quite different from TypeScript ones. They allow users to add a custom message for validation, which can be surfaced during linting or CI, for example. Custom attribute types also allow for custom transform functions, which let you mutate/transform the attribute value itself at runtime.
We do have plans to create a VSCode extension that can surface these validation errors in your editor (similar to what you can see here: https://markdoc.io/sandbox).
As far as TypeScript support goes, @markdoc/markdoc is fully written in TypeScript, so you should be able to use the exported types to type everything you need in your application.


Fix regex

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.418%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
651

Relevant Lines:
955

💛  - Coveralls


add delete_secret_thread

The delete_secret_thread will run after the service is started, every 6 hours, to delete the secret according to the planned deletion time
When calling the delete secret api, after selecting the scheduled time to delete the secret, it will directly strat delete secret task
pass the python test
Signed-off-by: yidingluo1<EMAIL_ADDRESS>

@syan10 all comments changed

add secret delete timer
it will scan the database every 6 hours and delete items that have reached the deletion time.
passed the python test
Signed-off-by: yidingluo1<EMAIL_ADDRESS>

commit changed

add secret delete timer
it will scan the database every 6 hours and delete items that have reached the deletion time.
passed the python test Signed-off-by: yidingluo1<EMAIL_ADDRESS>
commit changed


any plan on developing GQL based API

@SanskarSans perhaps you can elaborate what you mean by this - the use case that you have in mind, the features/functionality that this would add, and the reasons why you think this should be supported by Oscar?

Closing due to lack of feedback from OP - feel free to reopen with details.


[ocean-marketplace] Add other networks for ocean-marketplace strategy

Updating ocean subgraph routes for BSC & Poly network.

Enables us to expand marketplace strategy support for BSC & Poly

Hi @idiom-bytes Can you remove these functions in the next PR https://github.com/snapshot-labs/snapshot-strategies/blob/master/src/strategies/ocean-marketplace/oceanUtils.ts There are just for logs right?


estimatedRowSize not passed from List to Grid

It seems that the estimatedRowSize prop is not used anywhere in List. Shouldn't this be passed down to the Grid? https://github.com/bvaughn/react-virtualized/blob/master/source/List/List.js#L136

It is passed here with all of the other same-name props.

@bvaughn ah i see. my bad. thanks for clarifying :)

No prob!


Adding a preview link of App

It will be great to have a preview link of the app, so that others can explore the app easily without downloading and installing.
We can have appetize.io for now.

Added via #160


D at start of line moves the cursor up

Pressing D at the start of a line deletes everything in the line and then moves the cursor up. vim doesn't do this.

#555 addresses this one

Yep, this appears fixed (0.200.0 / 0.48.0).  Close?


Checks running while client being restarted -> status == 15?

Current Behavior
I'm seeing checks that have no output and a status of 15. This seems to happen around the time when the client is being restarted.
Possible Solution
Suppress sending out this message at all - is there any value in this?
Steps to Reproduce (for bugs)
This isn't deterministic.

have (standalone) checks that might be running a bit longer
keep restarting the client
see if the check turns into "no output" and status 15

Context
I'm trying to reliably rely on a few checks that are very important but have very low occurrences (basically 1). I'm going to ignore status code 15 for now, but I guess there is a slight design improvement potential around here somewhere.
Your Environment

Sensu version used: old. :) sensu 0.22
Active Sensu extensions (e.g. WizardVan 0.1.0): -
Operating System and version (e.g. Ubuntu 14.04): NixOS 15.09
Transport and runtime versions (e.g. RabbitMQ 3.6.2 on Erlang 18.2): Rabbitmq 3.6.5 Erlang 18.0

@ctheune curious, if you run one of checks/plugins manually and send it a SIGTERM, does it return status 15?

I'm sorry, I didn't take enough info to reproduce this and can't find the logs any longer. I'll reopen this if that happens again ... :/


Organize examples

Closes #100

Reorganizes doc/examples so that each example goes by framework/example-name
Removed Dockerfile for examples which no longer need it, ie. Solara (previously those frameworks needed to be deployed as Docker apps but now we support them natively)
Once this is merged, will open a PR to cloud-frontend to update the locations of a few example apps. Once that is merged, will open another PR to doc to delete the old examples that were moved

📚 Documentation preview 📚: https://ploomber-doc--126.org.readthedocs.build/en/126/

@edublancas ready for review
Moved most of the examples out of the Docker folder, and into a folder for their own framework, ie. examples/docker/example-name -> examples/framework/example-name.
Removed Dockerfile from projects that no longer need it. Made sure those which had Dockerfiles removed will still deploy correctly (had to edit/create a requirements.txt for those apps)
The only app for which I couldn't remove the Dockerfile for was solara/keyword-extraction, because it requires some additional commands to be run in the Dockerfile (apart from just installing the requirements).


.NET 6 and 7 miscompile .Razor file (uppercase r) as page instead of component

Describe the bug:
In .NET 5, a Foo.Razor file in a Razor Class Library would work fine. In .NET 6+, it's compiled as a Razor Page instead of a Razor Component and produces the wrong output. Here's the problem:
https://github.com/dotnet/razor/blob/15beb6a1253f078c8cc35ffca091fc475a584ed6/src/Compiler/Microsoft.NET.Sdk.Razor.SourceGenerators/RazorSourceGenerator.RazorProviders.cs#L91
The call to EndsWith does not use StringComparisonMode.OrdinalIgnoreCase, unlike other comparisons in the compiler. I suggest abstracting this check rather than having to get it right every time.
Version used:
.NET SDK 6.0.100 or later.
To reproduce:
Steps to reproduce the behavior:

Clone https://github.com/gulbanana-bugs/repro-razor-casesensitivity
dotnet build

Expected behavior:
The project should build.
Actual behavior:
16 CS0234 errors. This is quite misleading and took some time to track down.

@jjonescz Can you take a look at this please?


Filters apply to absolute paths not relative paths

Expected Behavior
Filters apply only to relative paths.
Current Behavior
Filters apply to absolute paths.
Steps to Reproduce (for bugs)
Identified investigating #1158 (relevant build log: https://travis-ci.org/arturbosch/detekt/jobs/432263468)
Context
The filters set when Travis build runs includes .*/build/*.. Travis checks out the build at /home/travis/build/arturbosch/detekt which is also detekt's working directory when it runs. I'd expected that it's filtering based on the relative path, but it appears to be filtering based on the absolute path. Since all Kotlin files have /build/ in their absolute paths, everything is filtered.
Your Environment

Version used: master
Operating System and version: Ubunty Trusty 14.04 (running on Travis)
Link to your project: See #1158 and build log: https://travis-ci.org/arturbosch/detekt/jobs/432263468

This behavior is defined in PathFilter and I agree it would be good to only apply the filters on relative paths to the project root.

Reminder to anyone reading: before closing, ensure that any fix is effective in fixing the original issue reported at #1158 - the same set of files that are scanned in AppVeyor should be scanned in Travis.


MetricsRestTemplateConfiguration creates a BeanPostProcessor used t…

MetricsRestTemplateConfiguration creates a BeanPostProcessor used to configure RestTemplate instances when added to the application context. It should be made @ConditionalOnClass(RestTemplate) instead of @ConditionalOnBean(RestTemplate) since it should be present before any RestTemplate bean instance is created.
See https://github.com/spring-cloud/spring-cloud-netflix/issues/1153

Codecov Report

Merging #1747 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1747   +/-   ##
=======================================
  Coverage   75.23%   75.23%
=======================================
  Files         200      200
  Lines        6210     6210
  Branches      777      777
=======================================
  Hits         4672     4672
  Misses       1199     1199
  Partials      339      339

Impacted Files
Coverage Δ

...tflix/metrics/MetricsInterceptorConfiguration.java
100% <ø> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c89645e...242cac9. Read the comment docs.


[Autocomplete/TextField] dropdown closes on mouseup over textfields

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example:
https://codesandbox.io/s/infallible-mccarthy-bg665h?file=/demo.tsx
Steps:

Mousedown on whitespace in autocomplete (avoid whitespace within bounds of the clear option): dropdown should appear
Slide cursor over a textfield
Mouseup: dropdown disappears

Current behavior 😯
On mouseup, the dropdown closes instead of remaining open.
Expected behavior 🤔
The dropdown should remain open.
Context 🔦
In our system, on mousedown the pills change size and become larger (the pill delete icon is only shown when entering the autocomplete). The pills slide underneath the mouse frequently, making the dropdowns flash open/closed instead of remaining open.
Initially thought it may be related to: https://github.com/mui/material-ui/pull/36892, but problem occurs in the enabled state.

  Output from `npx @mui/envinfo` goes here.

@nathanielohler-wf I'm not able to reproduce the issue, can you add screen recording?
Btw, #36892 is not released yet so probably it's not causing the issue

https://user-images.githubusercontent.com/16782272/235261048-10e6cc77-d119-4912-8801-f0b1c685cc1e.mov
It's not obvious, but the mouse down occurs in the blank space, slide the mouse over the pill, then mouseup.

Your use case is pretty unusual, so I'm not keen on changing the logic for everyone. You may work around this issue by using pointer capture in the text field's onPointerDown:
<Autocomplete
  multiple
  id="tags-standard"
  options={top100Films}
  getOptionLabel={(option) => option.title}
  defaultValue={[top100Films[13]]}
  renderInput={(params) => (
    <TextField
      {...params}
      variant="standard"
      label="Multiple values"
      placeholder="Favorites"
      onPointerDown={(e) => e.currentTarget.setPointerCapture(e.pointerId)}
    />
  )}
/>

Let me know if it helps.


Sanitized data in the models

Added some properties like trim, lowercase and unique in mongoose models. "unique" is used with email so that it checks whether the same mail is already present in the database or not if it is already there then it shows error.

Thank you for your contributions !