chunkwmrc help

I was quite happy with my kwmrc settings. But on chunkwm, I am not able to get the same look and feel. I am guessing that I need help in editing the settings.
I have dual monitor setup on my system. One of the monitors tiles the windows. The other one does not. On KWM, I was able to get tiling windows on both monitors and a multiple number of workspaces. But on this I can't... Can someone explain...
Here is my kwmrc for reference...
kwmrc.pdf

Monitor issue: You need to restart chunkwm after (dis-)connecting monitors. This was not necessary with Kwm.
As for your settings, please just paste them here in a codeblock instead of uploading as a pdf file.

Kwm settings:
`/*
This is a sample config for Kwm
The following statements can be used to set Kwms internal directory structure.
This is the root folder for Kwms files, the only thing this actually
specifies is the location of the 'init' script which Kwm runs upon startup.
Defaults to $HOME/.kwm

    kwm_home /path/to/.kwm

This is the root folder in which all files included using 'include' must reside.
Defaults to $HOME/.kwm

    kwm_include /path/to/.kwm/include

This is the folder in which all bsp-layouts managed by 'tree load' and 'tree save'
is loaded from / saved to. Defaults to $HOME/.kwm/layouts

    kwm_layouts /path/to/.kwm/layouts

Commands prefixed with 'kwmc' will call
local functions corresponding to the
kwmc syntax.
To run an external program or command,
use the prefix 'exec' followed by command.
e.g 'exec mvim' would open macvim
Read file and execute commands as
if they were written inside kwmrc.
include filename
e.g: window-rules in a separate file called 'rules'
include rules
*/
Set default values for screen padding
kwmc config padding 1 1 1 1
Set default values for container gaps
kwmc config gap 1 1
Default tiling mode for Kwm (bsp | monocle | float)
kwmc config tiling bsp
Automatically float windows that fail to resize
kwmc config float-non-resizable on
Automatically resize the window to its container
kwmc config lock-to-container off
Set focus-follows-mouse-mode to autoraise
kwmc config focus-follows-mouse on
/*
Focus-follows-mouse is temporarily disabled when
a floating window has focus
*/
kwmc config standby-on-float on
Center window when made floating
kwmc config center-on-float on
/*
The mouse will automatically move to the center
of the focused window
*/
kwmc config mouse-follows-focus on
/*
Allows a window to be moved by dragging,
when a modifier key and left-click is held down.
Allows a window to be resized by dragging
when a modifier key and right-click is held down.

*/
kwmc config mouse-drag on
The modifier keys to be held down to initiate mouse-drag
kwmc config mouse-drag mod shift+ctrl
Allow window focus to wrap-around
kwmc config cycle-focus on
/*
Override default settings for space 1 on screen 0
kwmc config space 0 1 mode monocle
kwmc config space 0 1 padding 100 100 100 100
kwmc config space 0 1 gap 40 40
*/
/*
Override default settings for screen 1
kwmc config display 1 mode bsp
kwmc config display 1 padding 100 100 100 100
kwmc config display 1 gap 40 40
*/
Set default container split-ratio
kwmc config optimal-ratio 1.6
New splits become the left leaf-node
kwmc config spawn left
/*
Add custom tiling rules for applications that
does not get tiled by Kwm by default.
This is because some applications do not have the
AXWindowRole and AXStandardWindowSubRole
*/
kwmc rule owner="iTerm2" properties={role="AXDialog"}
/*
The following commands create rules that
blacklists an application from Kwms tiling
kwmc rule owner="Steam" properties={float="true"}
kwmc rule owner="Photoshop" properties={float="true"}

*/
/*
The following command creates a rule that
captures an application to the given screen,
if the screen exists.
kwmc rule owner="iTunes" properties={display="1"}
*/
Enable border for focused window
kwmc config border focused off
kwmc config border focused size 2
kwmc config border focused color 0xFFBDD322
kwmc config border focused radius 6
Enable border for marked window
kwmc config border marked off
kwmc config border marked size 2
kwmc config border marked color 0xFFCC5577
kwmc config border marked radius 6
`

`/*
This is a sample config for Kwm
The following statements can be used to set Kwms internal directory structure.
This is the root folder for Kwms files, the only thing this actually
specifies is the location of the 'init' script which Kwm runs upon startup.
Defaults to $HOME/.kwm

    kwm_home /path/to/.kwm

This is the root folder in which all files included using 'include' must reside.
Defaults to $HOME/.kwm

    kwm_include /path/to/.kwm/include

This is the folder in which all bsp-layouts managed by 'tree load' and 'tree save'
is loaded from / saved to. Defaults to $HOME/.kwm/layouts

    kwm_layouts /path/to/.kwm/layouts

Commands prefixed with 'kwmc' will call
local functions corresponding to the
kwmc syntax.
To run an external program or command,
use the prefix 'exec' followed by command.
e.g 'exec mvim' would open macvim
Read file and execute commands as
if they were written inside kwmrc.
include filename
e.g: window-rules in a separate file called 'rules'
include rules
*/
Set default values for screen padding
kwmc config padding 1 1 1 1
Set default values for container gaps
kwmc config gap 1 1
Default tiling mode for Kwm (bsp | monocle | float)
kwmc config tiling bsp
Automatically float windows that fail to resize
kwmc config float-non-resizable on
Automatically resize the window to its container
kwmc config lock-to-container off
Set focus-follows-mouse-mode to autoraise
kwmc config focus-follows-mouse on
/*
Focus-follows-mouse is temporarily disabled when
a floating window has focus
*/
kwmc config standby-on-float on
Center window when made floating
kwmc config center-on-float on
/*
The mouse will automatically move to the center
of the focused window
*/
kwmc config mouse-follows-focus on
/*
Allows a window to be moved by dragging,
when a modifier key and left-click is held down.
Allows a window to be resized by dragging
when a modifier key and right-click is held down.

*/
kwmc config mouse-drag on
The modifier keys to be held down to initiate mouse-drag
kwmc config mouse-drag mod shift+ctrl
Allow window focus to wrap-around
kwmc config cycle-focus on
/*
Override default settings for space 1 on screen 0
kwmc config space 0 1 mode monocle
kwmc config space 0 1 padding 100 100 100 100
kwmc config space 0 1 gap 40 40
*/
/*
Override default settings for screen 1
kwmc config display 1 mode bsp
kwmc config display 1 padding 100 100 100 100
kwmc config display 1 gap 40 40
*/
Set default container split-ratio
kwmc config optimal-ratio 1.6
New splits become the left leaf-node
kwmc config spawn left
/*
Add custom tiling rules for applications that
does not get tiled by Kwm by default.
This is because some applications do not have the
AXWindowRole and AXStandardWindowSubRole
*/
kwmc rule owner="iTerm2" properties={role="AXDialog"}
/*
The following commands create rules that
blacklists an application from Kwms tiling
kwmc rule owner="Steam" properties={float="true"}
kwmc rule owner="Photoshop" properties={float="true"}

*/
/*
The following command creates a rule that
captures an application to the given screen,
if the screen exists.
kwmc rule owner="iTunes" properties={display="1"}
*/
Enable border for focused window
kwmc config border focused off
kwmc config border focused size 2
kwmc config border focused color 0xFFBDD322
kwmc config border focused radius 6
Enable border for marked window
kwmc config border marked off
kwmc config border marked size 2
kwmc config border marked color 0xFFCC5577
kwmc config border marked radius 6
`

@knightjp
You need to use triple ` to create a code paragraph. Single ` only works on one-liners.
```
code here
```
Regarding the issue at hand, you probably want to customize the settings and not run the default chunkwm config, as it is a copy of my own personal one.
In particular, https://github.com/koekeishiya/chunkwm/blob/master/examples/chunkwmrc#L23 makes desktop 5 float. If desktop 5 is on your secondary monitor, that is probably why.
Otherwise, as @dominiklohmann said, you need to restart chunkwm (the tiling plugin) if you have disconnected a monitor and reconnected it. Hoping to start work on live monitor changes soon.

@koekeishiya why does chunkwm have many setting for different desktops? Why not just the one
chunkc set global_desktop_mode           bsp..?
To be honest, this wasn't the only issue for me. I also noticed that some of the standard Mac OS keyboard shortcuts like "Cmd+Shilft-H" didn't take me to the Home folder like it usually does. There were other that weren't working as well.

@koekeishiya why does chunkwm have many setting for different desktops? Why not just the one
chunkc set global_desktop_mode bsp..?

I don't want bsp-tiling on all desktops, so I override the setting for a few specific ones.
You need to figure out what you want and configure it so. Nothing in the config file is necessary, and so you need to spend some time to make it work the way you want.

To be honest, this wasn't the only issue for me. I also noticed that some of the standard Mac OS keyboard shortcuts like "Cmd+Shilft-H" didn't take me to the Home folder like it usually does. There were other that weren't working as well.

Same as above. I assume you copied the .khdrc file that came with brew. This is just my keybindings, and you need to edit this to suit your needs. Remove what you don't use etc.

What I want is actually the same settings as what I have on KWM. So I guess I need to spend some time and figure out the chunkwmrc file properly. Thank you.

chunkc set preselect_border_color        0xffffff00 chunkc set preselect_border_width        none chunkc set preselect_border_radius       none
How do I remove the focused window borders?

Just don't load the border  plugin.
remove or comment the chunkc core::load border.so line at the bottom of the config

Remove the border plugin from your configuration.
Remove the line
chunkc core::load border.so

@knightjp

Since I'm just an ordinary user. Do you think that chunkwm is ready for someone like me to use?

I just want to make clear that the current complexity is intended. My tools are meant for (mainly developers) and power users, thus the reason for the amount of configurability that is there.
I very much understand that this is a lot to take in for regular users that are interested in trying this sort of a setup. Ideally, there would be a user-guide like the one i3 provides, but I'm not very good at, nor do I really have the time to write a proper guide.

@koekeishiya Thank you for the assistance. I have actually gotten chunkwm running exactly the way that I want it.
To be honest I am rather impressed with the performance. Window movements are extremely snappy.
Although it took a bit of doing for me to get it right, I would say that this is a worthy successor to kwm.


Missing RPC documentation

We are currently missing a central location to view all RPC methods implemented by Helios. The rpc.rs file defines the methods but we do not have documentation.

closed by #136


line must be greater than 0 error happens with ssrFixStacktrace when same error happens the second time

Describe the bug
When a same error happened during rendering in SSR twice, Vite crashes with the following error.

Error: line must be greater than 0 (lines start at line 1)

Reproduction
https://stackblitz.com/edit/github-mxjv5s?file=src%2Ffoo.js
Steps to reproduce

Open reproduction
npm i (will run automatically in stackblitz)
npm run dev (will run automatically in stackblitz)
Open in browser (is already open in stackblitz)
Reload page
Error happens

System Info
System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    vite: ^3.2.3 => 3.2.4

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

For the first time, the stacktrace before rewriting is at /src/foo.js:3:20.
For the second time, it's at /src/foo.js:1:20.
Maybe the stacktrace is saved somewhere.

The error is cached here. I think because ssrFixStacktrace mutates the error, the cached error has it's stacktrace already re-written, causing a similar issue to https://github.com/vitejs/vite/issues/7045 where ssrFixStacktrace isn't idempotent.


scripts: Remove cargo install to avoid a feature error

This fix is intended for resolving the below error in AnalysisHub.
$ ./scripts/deps/rust.sh
...
   Compiling tempfile v3.10.1
   Compiling serde_derive v1.0.201
error[E0658]: use of unstable library feature 'saturating_int_impl'
   --> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serde-1.0.201/src/lib.rs:280:13
    |
280 |     pub use self::core::num::Saturating;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #87920 <https://github.com/rust-lang/rust/issues/87920> for more information
    = help: add `#![feature(saturating_int_impl)]` to the crate attributes to enable
...

I close this in favor of https://github.com/islet-project/islet/pull/323

I've reopend this PR for quick fixing the issue, as the alternative solution (https://github.com/islet-project/islet/pull/323) has another issue in clippy.


Add 'get_recursive' option for legacy whois to RIPE NCC

This patch adds an argument get_recursive to lookup_whois(). The
argument default is True, which causes no change to the behavior. If
the user passes get_recursive=False, and the IP is allocated to
RIPE, this causes the -r flag to be included in the query string.
The -r flag asks RIPE WHOIS servers not to perform recursive
queries, such as for related "person" or "role" objects. This helps
users avoid IP blacklisting by RIPE.
The -r flag is only supported by RIPE, so this patch only affects
queries to RIPE servers.
Resolves #292

Coverage decreased (-0.07%) to 99.576% when pulling 57eb0566759f09165a23bf5d3c581c29ab53033a on wiki-ST47:norecursive-dev into 915a907f253e93d1a796c6a78a27585a05289662 on secynic:dev.


type 'Null' is not a subtype of type 'String'

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
I suggest to have the file name and the line where is error occured. It's very complicated to know directly where to fixe the type when you face this error.
Proposal

This is not a flutter issue. This will have to be done in dart.
Kindly file an issue on the dart repo instead.
Closing from here.
Thank you


[WIP] Proof of concept for C# spec

Try to incorporate the markdown version from the csharplang repo
Uses both dependent repositories, and markdown includes in a new way.

closing and reopening to restart the build.

closing and reopening to restart the build.


Add release o1 support

Description
OpenAI has finally released the full o1 on the API:

https://openai.com/index/o1-and-new-tools-for-developers/
https://platform.openai.com/docs/guides/reasoning

Mostly the same as old o1-preview, with some changes:

[x] Vision support is back (yay), function calling, structured outputs
[x] 100k max output tokens instead of 32k
[ ] New field reasoning_effort with values "low", "medium", "high" to control for how many tokens (roughly) the model will "reason".
[x] New role "developer" which is supposed to replace "system" on their API completely, so now o1 finally supports developer (system) messages again.
[ ] Now o1 doesn't force Markdown by default, OpenAI says to add "Formatting re-enabled" to the first line of the developer (system) message if you want it back.

The only thing that'll require a UI change is the reasoning effort switch, it defaults to "medium" but of course it should be nice to be able to easily change it.

Thanks for the well written ticket @hourianto .
I'm tier 5 in OpenAI but don't have the o1 model yet available to implement and test the changes.
Do you know if the API changes are applied to o1-preview also?

@hourianto I look forward to it and I should be able to implement the reasoning switch quickly

@hourianto no need for the proxy, I'll prob get access soon and perform the updates. Thanks for asking!

Thanks @hourianto - question for you. With what granularity would you change the reasoning quantity switch? (the low/mid/high switch)
Could be changed per message, per chat, per model (so that all requests from that model come with a preset level of reasoning).
This is to figure out the right trade-off of UX and space.

@hourianto added some code yesterday to support the parameter and UI configuration. But haven't yet finished the work (very close) as I still don't have o1 for testing (and wasn't a priority). However it's gonna be done soon!

@hourianto thx, I just need to find the time to finish that setting.

@hourianto you can now set per-model reasoning effort (shortcut to change: shift + ctrl + o).
Setting:

With "high" setting:

With "low" setting:

And with Medium (or even better, unspecified) it's exactly in the middle. 👍

@zubus could be #4 but the most likely is that the models have not been reloaded yet.
I've changed the data format to enable this, and the field indicating configurability may no be present until a models refresh.

@zubus confirmed, just reload the models so the UI knows about the new capability.


example of use in typical gruntfile structure

I can't figure out how to use this in my gruntfile. I have a series of dependencies in my project.json file, and a series of grunt.loadNpmTasks() calls at the top of my Gruntfile.js with a series of  grunt.registerTask() calls at the bottom.
My attempts at using grunt-npm-install seem to have me in a chicken-and-egg situation.
Do I need the dependencies in package.json?  Do I even need grunt-npm-install in package.json? How do I load the tasks if they're not even installed...do I need to install npm-install first, then when that is complete I can load the tasks and only then register new ones?
Any pointers welcome. Thanks.

You probably don’t need grunt-npm-install at all. If you already have your dependencies listed in package.json, just run npm install and that should install them. Then you can use them in your Gruntfile.js.

well, yes, of course - that's what I have now. I'm trying to avoid the 'npm install && bower install && grunt build' sequence and just do a single 'grunt build', so the user doesn't neglect a step and wonder what's gone wrong.
is this not supposed to help in this way? perhaps I've misunderstood its whole purpose...

I wonder if you have an example of a project that uses this grunt task, so I can see it in use and perhaps understand how I might use it in my own projects.


added support for manage.py compress

The concatenation and compressing process can also be jump started outside of the request/response cycle by using the Django management command manage.py compress and the file names are stored in manifest.json. This json file and related css/javascript files can then be deployed manually to production. The code is copied from django-compressor (https://github.com/django-compressor/django-compressor). Updated license file to reflect the same.

Why don't you just use django-compressor? Or django-pipeline?

I don't work on django-static any more. If you want to you use the code you wrote, I suggest you use your own fork. Sorry. But django-pipeline is so much better.

I tried both django-compressor and django-pipeline and didn't like them. Found it weird that we have to define all files in settings.py for pipeline to compress. That was deal breaker. Also django-compressor didn't work well for my requirement. django-static meets most of my requirement and the only part missing for me was to create static compressed files similar to manage.py collectstatic which I would than upload to S3.
Thanks for creating django-static :+1: .


Feature Request: Background Colour Customization

One of the things that annoys me and makes looking at the site harder is the flat colour of the background and the tweets. The ability to set a different colour in the background to add contrast would be good.
Otherwise I will say I love the add-on as it is and it's a total lifesaver for me <3

Thanks for the issue @Firedingo! Definitely would be a good customization, I'll look into it when I have some time.

No plans to do this for now, but this can potentially be done with userstyles (https://userstyles.org/) or something like Ublock Origin https://github.com/gorhill/uBlock :)


Add character: Gaki

Hero Description
Gaki is a demon that uses the hungry and pain to grow up his own power.

Concept Art

Inspiration
Inspired by Japanese Culture, Gaki is a demon called by Preta and is considered one of five culture entities
Moves
Idle

[STICK] Walk
Gaki floats around.

[LEFT] Forked Spikes
Creates black spines from the ground that move at a high speed by applying damage and a slight slow, this spine is directed in a straight line to a medium range in relation to Gaki, when it separates into 2 branches, forming a "Y" . The spines that remain behind as the skill is performed will disappear after a short delay)
[MIDDLE] Drain all of them!
Gaki cast and creates a circular area of energy with high range, which constantly applies damage as long as enemies remain in contact with this skill. The damage done to enemies, returns in healing form to Gaki.
[RIGHT] Hungry Orb
Gaki casts and creates an energy orb, in the shape of an energy black hole. This orb has a low speed, but very high range, this orb does damage and stun all enemies it passes through
(If it is implementable, this orb would gradually increase in size, but not infinitely, something like the Q of Aurelion Sol from League Of Legends)
[Q] *Ultimate: Fighting against my demons
Gaki stops gliding and walks slowly on the ground, while remaining unwavering for 1 second and heals until he has 100% of HP instantly
[E] TAUNT
Gaki begins to laugh
[SPACE] Pain-power
A new sword is stuck in his back and Gaki is pushed forward a little, and starts to catch blue fire. Gaki loses a % of his life, earning a damage bonus on the next skill.
If gaki summons this skill again, he points to the sky, and summons a sword in the desired place. This is a quick skill and has moderate damage.
This skill has low cooldown
Tasks

[x] Walkcycle
[x] Idle
[ ] [LEFT] Forked Spikes_cast
[ ] [LEFT] Forked Spikes_spike_row
[ ] [LEFT] Forked Spikes_spike_fork
[ ] [MIDDLE] Drain all of them!_pool
[ ] [MIDDLE] Drain all of them!_cast
[ ] [RIGHT] Hungry Orb_cast
[ ] [RIGHT] Hungry Orb_orb
[ ] [Q] Fighting against my demons _walkcycle
[ ] [Q] Fighting against my demons _taunt
[ ] [Q] Fighting against my demons _idle
[ ] [Q] Fighting against my demons _cast
[ ] [Q] Fighting against my demons _return
[ ] [E] TAUNT
[ ] [SPACE] Pain-power_cast
[ ] [SPACE] Pain-power_fire
[ ] [SPACE] Pain-power_falling_sword

wip_01
hours worked: 14 hours and 11 minutes
resume:

Concept
Model
Idle
Walkcycle
[Q] Fighting against my demons _walkcycle (wip)
[Q] Fighting against my demons _taunt (wip)
[Q] Fighting against my demons _idle (wip)

all the content has been updated at the main comment.

wip_02
hours worked: 19 hours and 8 minutes
resume:

[Q] Fighting against my demons _walkcycle
[Q] Fighting against my demons _taunt

all the content has been updated at the main comment.

wip_03
hours worked: 29 hours and 28 minutes
resume:

Idle (update)
Walkcycle (update)
[Q] Fighting against my demons _idle
[Q] Fighting against my demons _cast
[Q] Fighting against my demons _return
[SPACE] Pain-power_cast
[SPACE] Pain-power_falling_sword_cast

all the content has been updated at the main comment.

wip_04
hours worked: 37 hours and 30 minutes
resume:

[RIGHT] Hungry Orb_orb
[LEFT] Forked Spikes_cast
[LEFT] Forked Spikes_spikes

all the content has been updated at the main comment.

wip_05
hours worked: 40 hours and 45 minutes
resume:

[SPACE] Pain-power_cast (update)
[SPACE] Pain-power_fire
[SPACE] Pain-power_blood

all the content has been updated at the main comment.

wip_06
hours worked: 44 hours and 49 minutes
resume:

[RIGHT] Hungry Orb_orb (increment)
[RIGHT] Hungry Orb_collision
[SPACE] Pain-power_falling_sword
[SPACE] Pain-power_falling_sword_idle

all the content has been updated at the main comment.

wip_07
hours worked: 56 hours and 12 minutes
resume:

[MIDDLE] Drain all of them!_pool
[RIGHT] Hungry Orb_cast

all the content has been updated at the main comment.

wip_08
hours worked: 60 hours and 27 minutes
resume:

[RIGHT] Hungry Orb_collision
[E] TAUNT
[Q] Fighting against my demons _taunt
[MIDDLE] Drain all of them!_cast

all the content has been updated at the main comment.


Windows desktop app completely losing keyboard focus

Steps to reproduce
Rarely it happens with windows desktop app, that the application completely stops being responsive to any hardware keyboard input. I managed to discover only one scenario where the issue can be reliably reproduced.

create a new project, e.g. flutter create test_app --platforms windows
add a new TextField widget
build and run
press Win+D to minimize all apps
press Win + D to regain focus
try writting into the TextField

Expected results
Input appears in the TextField
Actual results
No input appears. Also the windows alert beeping sound is triggered. Note, that the app is not responsive to the keyboard at all (e.g. Tab behavior)
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.22.2, on Microsoft Windows [Version 10.0.19045.4598], locale en-US)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Enterprise 2022 17.5.4)
[√] VS Code, 64-bit edition (version 1.87.2)
[√] VS Code (version 1.92.0-insider)
[√] Connected device (3 available)
[√] Network resources

• No issues found!
PS C:\Users\admin\source\repos\test_app> flutter doctor -v
[√] Flutter (Channel stable, 3.22.2, on Microsoft Windows [Version 10.0.19045.4598], locale en-US)
    • Flutter version 3.22.2 on channel stable at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (5 weeks ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Enterprise 2022 17.5.4)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Enterprise
    • Visual Studio Enterprise 2022 version 17.5.33530.505
    • Windows 10 SDK version 10.0.22000.0

[√] VS Code, 64-bit edition (version 1.87.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.88.0

[√] VS Code (version 1.92.0-insider)
    • VS Code at C:\Users\admin\AppData\Local\Programs\Microsoft VS Code Insiders
    • Flutter extension version 3.92.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.4598]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 125.0.6422.142
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 126.0.2592.87

[√] Network resources
    • All expected network resources are available.

• No issues found!

Thank you for the report. I also can reproduce this issue on my end.

Demo video
https://github.com/flutter/flutter/assets/104349824/0f65dbb5-09bc-4066-b0f6-5d5fb20e84eb

flutter doctor -v (stable & master)
[√] Flutter (Channel stable, 3.22.2, on Microsoft Windows [Version 10.0.19045.4412], locale en-US)
    • Flutter version 3.22.2 on channel stable at C:\WIP\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (11 days ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\AndroidSDK
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio Hedgehog\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.4.4)
    • Visual Studio at D:\DOWNLOADWORK\VS2022
    • Visual Studio Community 2022 version 17.4.33213.308
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2022.3)
    • Android Studio at C:\Program Files\Android\Android StudioGiraffe
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)

[√] Android Studio (version 2023.1)
    • Android Studio at C:\Program Files\Android\Android Studio Hedgehog
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)

[√] VS Code (version 1.89.1)
    • VS Code at C:\Users\ADMIN\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.90.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.4412]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 125.0.6422.141
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 124.0.2478.67

[√] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.23.0-14.0.pre.118, on Microsoft Windows [Version 10.0.19045.4529], locale en-US)
    • Flutter version 3.23.0-14.0.pre.118 on channel master at C:\WIP\flutter_master
    ! Warning: `flutter` on your path resolves to C:\WIP\flutter\bin\flutter, which is not inside your current Flutter
      SDK checkout at C:\WIP\flutter_master. Consider adding C:\WIP\flutter_master\bin to the front of your path.
    ! Warning: `dart` on your path resolves to C:\WIP\flutter\bin\dart, which is not inside your current Flutter SDK
      checkout at C:\WIP\flutter_master. Consider adding C:\WIP\flutter_master\bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision aa179bdc01 (in the future), 2024-07-03 02:34:15 -0400
    • Engine revision a02e3f673d
    • Dart version 3.5.0 (build 3.5.0-323.0.dev)
    • DevTools version 2.37.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly
      to perform update checks and upgrades.

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\AndroidSDK
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio Hedgehog\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.4.4)
    • Visual Studio at D:\DOWNLOADWORK\VS2022
    • Visual Studio Community 2022 version 17.4.33213.308
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2022.3)
    • Android Studio at C:\Program Files\Android\Android StudioGiraffe
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)

[√] Android Studio (version 2023.1)
    • Android Studio at C:\Program Files\Android\Android Studio Hedgehog
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)

[√] VS Code (version 1.90.1)
    • VS Code at C:\Users\ADMIN\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.90.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.4529]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 126.0.6478.127
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 124.0.2478.67

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

/cc @dkwingsmt

I have a very similar issue. In my case the total focus lost happens in Windows when I minimize the window via the package window_manager. When I do it via the buttons on the Window is works normally.
It is also strange that I can type after restore, but the first Enter or Esc get eaten and only the second one (and following key strokes) go through to my code.

@dkwingsmt any thoughts on what might be going on here?


Remove component library

To help customize the application the library of components has been merged to the template https://github.com/liteflow-labs/marketplace-template/pull/48
Please ignore storybook builds as they are not available anymore and will be removed once this PR is merged

good catch, npmrc removed


combined coverage

Codecov Report
Base: 76.57% // Head: 76.13% // Decreases project coverage by -0.43% :warning:

Coverage data is based on head (0bba1b1) compared to base (0941b11).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   76.57%   76.13%   -0.44%
==========================================
  Files          11       12       +1
  Lines         828      838      +10
==========================================
+ Hits          634      638       +4
- Misses        142      146       +4
- Partials       52       54       +2

Impacted Files
Coverage Δ

test/integration/test.go
40.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


SOAP 1.2 charset resolve

Hello, there is an issue with charset resolving for SOAP 1.2 requests.
In SOAP 1.2 specification you have action defined in ContentType header and it could have value:
text/xml; charset=utf-8; action="someaction".
Moco use HttpUtil class from netty-codec-http to resolve and set encoding. HttpUtil class has method getCharsetAsSequence(CharSequence contentTypeValue) which finds word charset and take whole line from charset to the end. So from example above you will receive the following string:
utf-8; action="someaction" and then exception java.nio.charset.IllegalCharsetNameException: utf-8; action...

the moco-runner recognized that your charset is not 'utf-8' but 'utf-8;' , so it throw a exception named 'illegalchasetnameexception'. it means your charset name is wrong .

the moco-runner recognized that your charset is not 'utf-8' but 'utf-8;' , so it throw a exception named 'illegalchasetnameexception'. it means your charset name is wrong .

Please read problem description again. I checked where was a problem, and it's netty bug. I already report it(https://github.com/netty/netty/issues/8273) and looks like it's fixed now.
So you need to upgrade netty version. To fix this issue in moco.


docs: change code refs of Mac M1 to Apple Silicon

The Issue
There are references to Mac M1 in the code, but with Apple's release of M2, it is probably wise to change those references to a more general "Apple Silicon", when checking architectures.
How This PR Solves The Issue
This simply updates the function name and all of the references to it.
Manual Testing Instructions
Start up a DDEV project on a device using Apple Silicon, particularly one using Docker Desktop, as this code is required due to compat quirks with that.
Automated Testing Overview
This change should included updated tests where necessary.
Related Issue Link(s)
https://github.com/ddev/ddev/issues/5125
Release/Deployment Notes
This should be fairly self-contained and not affect other code to a large degree.

Thanks and congrats!


HTML snippets not working

We have written the needed data into your clipboard because it was too large to send. Please paste.
Issue Type: Performance Issue
My VSCode does not show suggestions, emmets and snippets anymore and i dont know why. I formated my PC months ago and when i was coding again this feature just does not worked.  I searched everywhere how to fix this but without success. Please help?
VS Code version: Code 1.44.0 (2aae1f26c72891c399f860409176fe435a154b13, 2020-04-08T11:22:13.689Z)
OS version: Linux x64 4.15.0-1076-oem

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz (8 x 1900)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_off_okvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
4, 5, 4

Memory (System)
7.67GB (0.23GB free)

Process Argv
--no-sandbox --unity-launch

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    0	    94	 25743	code main
    0	     0	 25746	   zygote
    0	    39	 25770	   gpu-process
    0	    71	 25783	   utility
    0	   291	 25794	   window (● index.html.twig - dealersites - Visual Studio Code)
    0	     0	 25838	     /bin/bash
    0	   220	 25865	     watcherService
    0	    16	 25944	     searchService
   12	    47	 25878	   shared-process
    0	     0	 29830	     /bin/sh -c /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0	     0	 29831	       /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0	   102	 29800	   window (Issue Reporter)

Workspace Info
|  Window (● index.html.twig - dealersites - Visual Studio Code)
|    Folder (dealersites): more than 40767 files
|      File types: png(2955) jpg(2731) js(2208) css(1893) php(1635) data(503)
|                  svg(319) scss(290) log(264) twig(228)
|      Conf files: package.json(5) gulp.js(3) makefile(2) settings.json(1);

Extensions (11)

Extension
Author (truncated)
Version

html-snippets
abu
0.2.1

html-class-suggestions
And
1.0.7

jquerysnippets
don
0.0.1

gitlens
eam
10.2.1

vscode-html-css
ecm
0.2.3

twig-language-2
mbl
0.9.1

vscode-language-babel
mgm
0.0.27

vscode-docker
ms-
1.0.0

sublime-keybindings
ms-
4.0.6

highlight-matching-tag
vin
0.9.6

twig
wha
1.0.2

In the Output panel please review the log from the Extension Host. Any evidence of errors?

@davidgms We've seen a number of reports of antivirus software interfering with the latest release, if you're using Quick Heal, please see the discussion here on how to solve this: https://github.com/microsoft/vscode/issues/94858#issuecomment-611905765
If not, has this problem only started happening with the upgrade to 1.44? Can you try temporarily disabling all extensions with the Developer: Reload with Extensions Disabled command?

I just rolled back to Feb release (v1.44) - and the custom CSS snippets are now working but HTML snippets are still no good...

I see index.html.twig file. HTML snippets won't work in TWIG files, unless you mark them as html files with files.associations.


ES6 Class: asserts this is Type raises error when variable containing instance is type narrowed

Bug Report
🔎 Search Terms

Error: "Assertions require every name in the call target to be declared with an explicit type annotation"
Assertation function as class method
Type narrowing class and then calling assertation method

🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about this

⏯ Playground Link
Playground link with relevant code
💻 Code

class MyClass {
	public assertIsMyClass(): asserts this is MyClass {
		if (!(this instanceof MyClass)) {
			throw new Error('this was not of type MyClass');
		}
	}
}

const maybeMyClass: MyClass | undefined = new MyClass();

if (maybeMyClass) {
	// This fails with error:
	// Assertions require every name in the call target to be declared with an explicit type annotation.(2775)
	maybeMyClass.assertIsMyClass();

	// But if we simply assign to a new variable without the optionality, it's fine:

	// this line works because we have narrowed the type through the if statement above
	const definitelyMyClass: MyClass = maybeMyClass;
	// This raises no error even though it's equivalent to the first attempt
	definitelyMyClass.assertIsMyClass();
}

🙁 Actual behavior
Calling the class method assertation function raises error: "Assertions require every name in the call target to be declared with an explicit type annotation.(2775)"
🙂 Expected behavior
It should pass validation and narrow to the type given in the assertation.
This is because it will have this behavior if you simply assign to a new variable with a new type annotation (but which is equivalent to the narrowed type at that point).

Duplicate of #36931, not sure why your search terms didn't discover it

Essentially a duplicate of #36931


Version number in plugin does not match repo release version

AdiIRC reports the plugin version as being 1.0, but the release reports that it is version 1.2. This is completely unusable, please fix immediately >:(

Fixed in release v1.3


Custom Guava module

Problem
Guava is a very helpful library, however it's a huge dependency that adds 13K methods.
Solution
There is now a custom module in the project with only the packages that we are using. We are using ProGuard to only keep the dependencies that are needed.
Fixes
https://github.com/googlesamples/android-architecture/issues/22

As agreed offline, we're going back to proguard and the new shrinker. It makes the build faster using guava reducing method count from 34413 to 10118. The custom module is a better solution but distracting for a sample.


Type mismatch error when running runqlen.bt

I received the following error when running runqlen.bt:
bpftrace  /usr/local/share/bpftrace/tools/runqlen.bt
Type mismatch for $len: trying to assign value of type 'integer'
when variable already contains a value of type 'integer'
As it turned out the faulty line is this one:
$len = $len > 0 ? $len - 1 : 0;	// subtract currently runing task
It seems that the same variable can't be on both side of an assignment. I couldn't find anything about it in the reference guide, so I'm not sure if that's a language limitation or an implementation error. Anyway, the following patch fixes the problem:
diff --git a/tools/runqlen.bt b/tools/runqlen.bt
index 117f026..9d7f048 100644
--- a/tools/runqlen.bt
+++ b/tools/runqlen.bt
@@ -31,8 +31,8 @@ profile:hz:99
 {
        $task = (task_struct *)curtask;
        $my_q = (cfs_rq_partial *)$task->se.cfs_rq;
-       $len = $my_q->nr_running;
-       $len = $len > 0 ? $len - 1 : 0; // subtract currently runing task
+       $tmp = $my_q->nr_running;
+       $len = $tmp > 0 ? $tmp - 1 : 0; // subtract currently runing task
        @runqlen = lhist($len, 0, 100, 1);
 }

Thanks for debugging, this is a bpftrace bug -- that tool should work as is. What's your kernel and llvm version? I developed the tool on llvm 5, and my guess is that llvm has extra checks by the later versions.

This was a bug in the semantic analyser introduced after runqlat was written. Fixed in 4efac77775229def94b97c9ef804423baa497dc8


Deformation union

The pipeline object allows for cascading of multiple deformers into a single chain.
Sometimes, we just want to apply a set of deformations independently, but there's no direct way to do that currently.
It would be easy to implement something analogous to a sklearn feature union that does round-robin sampling from each deformer.

From the itertools recipes page:

def roundrobin(*iterables):
    "roundrobin('ABC', 'D', 'EF') --> A D E B F C"
    # Recipe credited to George Sakkis
    pending = len(iterables)
    nexts = cycle(iter(it).next for it in iterables)
    while pending:
        try:
            for next in nexts:
                yield next()
        except StopIteration:
            pending -= 1
            nexts = cycle(islice(nexts, pending))


Modified Geospatial TSQL Syntax Support

Description

This commit contains a few changes from https://github.com/babelfish-for-postgresql/babelfish_extensions/pull/2271 :

Moved Duplicated Code to common helper functions for Exit functions handling Geospatial functional call in both TSQLBuilder and TSQLCommonMutator.

Replaced Check for hard Space with generalised isspace() to check for other whitespace characters as well.

To handle local id's we are now quoting them in the geospatial handling itself rather than modifying their start positions, so as to remove the possibility of multiple rewrites within a single context.

Authored-by: Anikait Agrawal<EMAIL_ADDRESS>Signed-off-by: Anikait Agrawal<EMAIL_ADDRESS>Test Scenarios Covered

Use case based -

Boundary conditions -

Arbitrary inputs -

Negative test cases -

Minor version upgrade tests -

Major version upgrade tests -

Performance tests -

Tooling impact -

Client tests -

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

-6 of 105 (94.29%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.007%) to 72.829%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contrib/babelfishpg_tsql/src/tsqlIface.cpp
99
105
94.29%

Totals

Change from base Build<PHONE_NUMBER>:
-0.007%

Covered Lines:
40927

Relevant Lines:
56196

💛  - Coveralls

LGTM


UI for the application launch screen

Could you provide more information here? Is this the same as https://github.com/vector-im/vector-ios/issues/615

Ben,
No this is not related to #615.
We need a UI for the screen displayed when the application is launched from a cold start.

I see. Ok here is the Launch Screen design. https://zpl.io/Z1crIXi

Fine for me, assign the issue to Matthew to sign off the design

Presume we now need to replace Vector logo with Riot?

We have now an animation with the Riot logo.


Security breach: email invitation link allows accept invitation and login/create account

Created by: @bayegan Apr 13 2022 at 02:11 CET
Last updated: May 07 2022 at 22:00 CET
ClickUp ID: IK-2692
Given
From @natalia.bakos via Slack message
And now I have a bigger issue. (this is still staging):
I sent out an invitation to the test user (mailto:test@indykite.com|test@indykite.com), I clicked on the link in the email, but I logged in with wonka (and not the mailto:test@indykite.com|test@indykite.com). I saw the slide-in notification, that the invitation has been accepted, but when I wanted to check the permissions on the  Account settings  page I can see 2 exactly same customer page, since they are the same, both are selected at the same time. And I don’t see the invitation to my test user on either of the spaces.
When
Since, anyone can accept the invitation and anyone with the link can login/create account.
Then
It seems that it’s a serious security issue,

Commented by: @bayegan Apr 13 2022 at 02:12 CET
@indyboox @hanny21 @kilimandzsaro @marvinkite : does this issue affect DB, or FE, or DB, and/or all?

Commented by: @marvinkite Apr 13 2022 at 06:45 CET
@bakkelim mentioned he will look into the double accept permissions assignment. That's a backend bug. About the invitation send to one email and someone process that link we have a debate with Natalia. Is it a security issue or not. How exactly the email is highjacked which raise this issue?  What can we do to mitigate? We know the email where we sent the invitation but do we know the email of user who is accepting it? Not always so what other reliable  source we can verify? I can't think of anything reliable. We can document how to write a Switch expression in the flow which in case do some minimal check but nothing is 100% reliable to enforce such thing.

Commented by: @bayegan May 07 2022 at 22:00 CET
Per huddle on 4/28/22 - this is not considered a security breach or issue.

Closed: May 07 2022 at 22:00 CET


docs: add documentation about update policy annotation

Signed-off-by: Javier López Barba<EMAIL_ADDRESS>Adds documentation about the update policy annotation on compose

@jLopezbarb could you update this PR to address the pending comments?

@jLopezbarb is this ready to be merged?

Yes, I was waiting for an approval


fix: removing disabled state when loading for git commit button

Description

Fixes initial loading color for the commit button in protected branches
Adds loading state when discard and pull is triggered

PR fixes following issue(s)
Fixes #29485
Media

Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>


Does the battery also get charged if the module is plugged in to a USB?

I am curious if  https://www.lilygo.cc/products/t-display-rp2040 also re-charges the battery?
Thank you!

According to the schematic, there is an onboard charger chip present [TP5054] powered by the USB +5V. Didn't try it yet though.


Updated RANS3PSed module with correct vos scaling

@adimako thanks for catching this. Your change  looks correct  to me. Does it address #913 ?

Nope still looking at it


Information on the page having issues in the Error Tracker

Add the name (path?) of the page having an issue in the Error Tracker.
For example, having 600 pages, I can't get which page is having issues when looking at this Error Report:
http://i.imgur.com/xpxH69C.png
http://i.imgur.com/qASafsRh.jpg
Thank you very much for you great work!

Sounds like a great addition.  Definitely going to look at adding this soon.  Thanks!

On another similar note, somehow, would it be possible to don't crash the whole website when only one (not essential) variable is messed in one header. When I mean not essential, I mean all the variables that are set by the user and no the system itself to work (the one you put).
For example, if two-points ( : ) are not put after a variable. I know that as you're parsing the header it might be difficult to avoid those kind of "skipping issues alternatives" but it's quite annoying when a whole website is down because of a small mistake in one of the pages (not even the one we are trying to reach).

I understand what your saying, but if we 'skipped' this page because there was an error with it, how would you really know that there was a problem with it?  We could of course log the error, but if you didn't check your logs you wouldn't see that.
The main problem is that if the header is effectively corrupted, we cannot parse it.  If we cannot parse it, we can't load anything related to the page because the header sets the page up.  If we can't load the page at all, we can't display a message about it even in the admin.
Really the only option is to skip the page, and log the error.  Your site would continue to work, but you could be left with wandering why your page is not displaying.

What about this solution:
If someone tries to actually reach this famous page (with the problem), he is redirected to a specific error page. If the person wants to see the home page but it's the contact page which has a problem in the header, he doesn't really care that he has no error message to say it - because he doesn't want this page anyway :)

Hmm.. I can't do that, but it does give me an idea.  When there is an error with the header data, it might be possible to set some standard 'error' type header values for the page.. so the page will exist, and have  some very basic info (like title: slug) and content containing error message about the failed parsing of the header.
The page will probably look very broken, but at least it wont break the whole site, and you would get valuable information as to what happened when you visit the site.
Sound like a solution?

Sounds like a good idea. I see that a bit like an error page in fact, as you've got an error message when you try to reach this particular page :)
It works for me then!

This is with invalid YAML that would of thrown the whole site into fits..

I've improved it!

Rhukster. You're awesome!


custom Blynk port not working for BlynkSimpleEsp32_Async_WM.h

Describe the bug
Custom blynkport from Credentials.h is not being used, instead it looks like the hard coded value is.
This work fine for ESP8266 but not ESP32. The code looks different.
Steps to Reproduce
Blynk port changed to 8082 in Credentials.h
Expected behavior
Blynk should connect to on 8082.
Actual behavior
Blynk tries to connect to port 8080.

`
//existing line 2068 in BlynkSimpleEsp32_Async_WM.h
BlynkESP32_WM_config.Blynk_Creds[i].blynk_server, BLYNK_SERVER_HARDWARE_PORT);
 //works if I change to this
BlynkESP32_WM_config.Blynk_Creds[i].blynk_server, BlynkESP32_WM_config.blynk_port);`
The above change seems consistent with the ESP8266 file which does work properly.

Thanks to point out the bug. I'll update in next release.

Just published the new Blynk_Async_WM releases v1.4.1 to fix the issue. Your contribution is noted in Contributions and Thanks.
Thanks and Regards,

Your contribution is also noted in Contributions and Thanks of this library's twin Blynk_WM


[CWS] send CWS events directly to the new track when using the direct sender

What does this PR do?
We send CWS to the new track by default when using the regular security agent model, but the direct sender was missed and is still sending to the logs track. This PR fixes this issue by sending to the new track as well, when using the direct sender.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge

/merge


cmd/cover: improve html coverage report

This is an issue for discussing the feature suggested in #25267 (111647)
I think the current html coverage report has two problems.

It's hard to navigate through pages.
It's hard to get the overview of the entire coverage.

These are caused by the fact that we use the select box for navigating through pages. I think that is not a standard way to organize the multiple report pages.
My suggestion is that we should have the index page for the html coverage reports. The demo is available at https://kt3k.github.io/go-cover-html-improve-demo/coverage.html
This idea is inspired by the tools like istanbul, JaCoCo or simplecov. They all have the index page of the coverage report.
/cc @ianlancetaylor

CC @robpike

I think it's fine as is, so you need to ask someone else's opinion to support a change. We don't need visual wonder, we need accurate information in simple form without mounds of Javascript and CSS. The current situation is just fine.

OK. This is probably something should be done in a 3rd party tool.


Add Haskell-Language-Server as a build input to the shell environment.

Adds the Haskell-Language-Server currently at version 1.1.0 (not yet released
in Hackage) through a niv dependency.
For a final user, adding this is fine because it is cached by Hydra so it will
just download the whole shell.
Incidentally:

Using the same set of nixpkgs as for the rest of the build when providing
it to Niv for non-builtin fetchers.
Replaced the sources.nix file with a newer generated version (probably this
should actually be updated each time we update the niv version).
Also rephrase how stylish-haskell was being built as we can just point
to the repository at a specific branch with niv.
Adding .envrc to .gitignore as not everybody uses lorri.

Co-authored-by: Pawel Szulc<EMAIL_ADDRESS>

@dcoutts @coot @karknu
This PR adds the haskell-language-server to our nix-shell environment. That is not a small dependency, but the recommendations we're received and others' experience has been that the Hydra cache mitigates the potential build-delays.
Are you three (Network Team) OK with this addition to the repositories nix-shell?

@dcoutts @coot @karknu
This PR adds the haskell-language-server to our nix-shell environment. That is not a small dependency, but the recommendations we're received and others' experience has been that the Hydra cache mitigates the potential build-delays.
Are you three (Network Team) OK with this addition to the repositories nix-shell?

I don't think any of us use nix-shell.

After confirming locally that (almost) everything was copied from caches after the hydra evaluation of native.shell succeeded:
these derivations will be built:
  /nix/store/in3kpaw7kd7ns959fhl0j44dd6xb3nv1-builder.pl.drv
  /nix/store/4jp06k9xm6wv99mcxiwrs9xjziasdbad-cddl-0.8.9.drv
  /nix/store/29hl3ikkyzwcjdlipk7g6bxn6mdackic-cddl-0.8.9.drv
  /nix/store/7hlhy17pr1hn31dn2dvah6fz8k6b2a68-cbor-diag-0.5.6.drv
  /nix/store/i1nypbj1r3qslsz1xy87pgvgwj1hdnk4-ghc-shell-for-packages-ghc-8.10.4-env.drv
  /nix/store/pnbdbgjpi9z1vyhfyw5lzz9x6fngljxd-cbor-diag-0.5.6.drv
these paths will be fetched (443.06 MiB download, 5228.94 MiB unpacked):
...

I then proceed to merge this PR

bors merge


Error in Running Causal Model

@tanujdhiman you need to provide the column names of treatment and outcome, not the actual values. Try,
CausalModel(data=x_test, treatment="Oldpeak", outcome="flag_pred")

Yeah @amit-sharma Got it.


graphql-relay ignores node definitions

My node definitions looks like this:
class Store {}
class Video {}
let store = new Store()
let video = new Video()

let nodeDefs = nodeDefinitions(
  (globalId) => {
    let type = fromGlobalId(globalId).type
    let id = fromGlobalId(globalId).id
    if (type === 'Store') {
      return store
    }
    if (type === 'Video') {
      return video
    }
    return null
  },
  (obj) => {
    if (obj instanceof Store) {
      return storeType
    }
    if (obj instanceof Video) {
      return videoType
    }
    return null
  }
)

The problem is that video node is always null, even when actual video is being returned from the database, because for it to not be null I need to look it up based on id or somehow fetch it from database.
This is the video node I am referring to:
video: {
  type: videoType,
  args: Object.assign(
    {},
    connectionArgs,
    {id: {type: GraphQLString}}
  ),
  resolve: (_, args) => {

    return docClient.query(
      Object.assign(
        {},
        {TableName: pokemonTable},
        {KeyConditionExpression: 'id = :id'},
        {ExpressionAttributeValues: { ':id': args.id }},
        paginationToParams(args)
      )
    ).promise().then(dataToConnection)

  }

},

I tried doing database query directly inside node definitions, but that didn't work.
dataToConnection just converts the output of dynamoDB:
video DATA!!  { Items:
   [ { id: 'f4623d92-3b48-4e1a-bfcc-01ff3c8cf754',
       url: 'http://www.pokkentournament.com/assets/img/characters/char-detail/detail-pikachuLibre.png',
       name: 'YAHOO' } ],
  Count: 1,
  ScannedCount: 1 }

into something that graphql relay understands:
video dataToConnection!!  { edges:
   [ { cursor: 'ZHluYW1vZGJjb25uZWN0aW9uOmY0NjIzZDkyLTNiNDgtNGUxYS1iZmNjLTAxZmYzYzhjZjc1NA==',
       node: [Object] } ],
  pageInfo:
   { startCursor: 'ZHluYW1vZGJjb25uZWN0aW9uOmY0NjIzZDkyLTNiNDgtNGUxYS1iZmNjLTAxZmYzYzhjZjc1NA==',
     endCursor: 'ZHluYW1vZGJjb25uZWN0aW9uOmY0NjIzZDkyLTNiNDgtNGUxYS1iZmNjLTAxZmYzYzhjZjc1NA==',
     hasPreviousPage: false,
     hasNextPage: false } }

and the function itself can be found here: https://github.com/dowjones/graphql-dynamodb-connections/pull/3/files
It is definitely NOT the problem here, but just FYI.
Also, asking/querying for id makes the whole video object null:

But omitting id from the query returns something, whether querying with relay id:

or database id

and querying for all of the videos works:

The interesting part is that I get exactly same problem even if I delete the video part from node definitions:
let nodeDefs = nodeDefinitions(
  (globalId) => {
    let type = fromGlobalId(globalId).type
    let id = fromGlobalId(globalId).id
    if (type === 'Store') {
      return store
    }
    return null
  },
  (obj) => {
    if (obj instanceof Store) {
      return storeType
    }
    return null
  }
)

even if I replace return video with return 'bla', still nothing and all the console logs I put in there are ignored.
@wincent

I did some digging and found that interfaces in fact is undefined
const storeType = new GraphQLObjectType({
  name: 'Store',
  fields: () => ({
    id: globalIdField('Store'),

    allVideosConnection: {
      type: allVideosConnection.connectionType,
      args: Object.assign(
        {},
        connectionArgs
      ),
      resolve: (_, args) => {

        return docClient.scan(
          Object.assign(
            {},
            {TableName: pokemonTable},
            paginationToParams(args)
          )
        ).promise().then(dataToConnection)
      }
    },

    video: {
      type: videoType,
      args: Object.assign(
        {},
        connectionArgs,
        {id: {type: GraphQLString}}
      ),
      resolve: (_, args) => {

        return docClient.query(
          Object.assign(
            {},
            {TableName: pokemonTable},
            {KeyConditionExpression: 'id = :id'},
            {ExpressionAttributeValues: { ':id': args.id }},
            paginationToParams(args)
          )
        ).promise().then(dataToConnection)

      }

    }

  }),

  interfaces: [nodeDefs.nodeInterface]

})

console.dir(storeType.interfaces, { depth: null })

prints undefined

Some more digging:

and

Do you have a definition for videoType? Could you craft a minimal example of the issue?

@mattecapu of course
const videoType = new GraphQLObjectType({
  name: 'Video',
  fields: () => ({
    id: {
      type: new GraphQLNonNull(GraphQLID),
      resolve: (obj) => obj.id
    },
    name: { type: GraphQLString },
    url: { type: GraphQLString }
  }),
  interfaces: [nodeDefs.nodeInterface]
})

The type definition explains why it only complains about Video being null when you explicitly ask for its id (you declared it non-null, while the other fields will happily return null as you can see from your tests).
Yet it still doesn't explain why you get a null object in the first place.
How do you pass around your node definitions interfaces? Do you have a separated module?

@mattecapu everything you see in here (all my code samples) are all in the same file.

This is what is being returned in video: {} resolve:
{ edges:
   [ { cursor: 'ZHluYW1vZGJjb25uZWN0aW9uOmY0NjIzZDkyLTNiNDgtNGUxYS1iZmNjLTAxZmYzYzhjZjc1NA==',
       node:
        { id: 'f4623d92-3b48-4e1a-bfcc-01ff3c8cf754',
          url: 'http://www.pokkentournament.com/assets/img/characters/char-detail/detail-pikachuLibre.png',
          name: 'YAHOO' } } ],
  pageInfo:
   { startCursor: 'ZHluYW1vZGJjb25uZWN0aW9uOmY0NjIzZDkyLTNiNDgtNGUxYS1iZmNjLTAxZmYzYzhjZjc1NA==',
     endCursor: 'ZHluYW1vZGJjb25uZWN0aW9uOmY0NjIzZDkyLTNiNDgtNGUxYS1iZmNjLTAxZmYzYzhjZjc1NA==',
     hasPreviousPage: false,
     hasNextPage: false } }

Somehow that's okay for allVideosConnection, but not okay (ends up null) for video
Do I need to convert ids of nodes to global IDs? using toGlobalId ? Just for video ?
Because another thing I noticed is that if I
console.log('fromGlobalId', fromGlobalId(globalId))

inside my node definitions, this query:
{
  node(id: "f4623d92-3b48-4e1a-bfcc-01ff3c8cf754") {
    id
    ...F1
  }
}

fragment F1 on Video {
  url
  name
}

becomes this:
fromGlobalId { type: '', id: '\u000e6]_v{vxsn\u001eU/\u001b}G>SW_]O\u001c>x' }

So to make node definitions work, all I had to do was this:
class Video {}
let video = new Video()
return Object.assign(video, data.Items[0])

i.e. create class with the same name as type name
and then Object.assign to it
Just doing this, doesn't work:
return {Video: data.Items[0]}

I also need to create IDs in the database like that: Video:f4623d92-3b48-4e1a-bfcc-01ff3c8cf754, where I am essentially putting type and randomly generated unique id together separated by a colon (:) and then encode it with toGlobalId function of graphql-relay-js library (so I end up with VmlkZW86ZjQ2MjNkOTItM2I0OC00ZTFhLWJmY2MtMDFmZjNjOGNmNzU0Og==), so then I can decode it with fromGlobalId so that node definitions can retrieve both type and id({ type: 'Video', id: 'f4623d92-3b48-4e1a-bfcc-01ff3c8cf754:' }), after which I still need to add fromGlobalId(globalId).id.replace(/\:$/, '')) to remove the trailing colon (:).
Also, interfaces are not meant to be accessible, they are just for configuration.


Adam vs AdamW - request to simplify the configuration

As a follow up to: https://github.com/microsoft/DeepSpeed/issues/666
It's clear that AdamW is supported since this is actually the default, unless I set:
    "optimizer": {
        "type": "Adam",
        "params": {
            "adam_w_mode": false,

though the user has no idea it's the case.
Why then do I have to set:
   "zero_allow_untested_optimizer": true,

If I want to use:
    "optimizer": {
        "type": "AdamW",

Why not make it simple for the user and just let them specify the exact optimizer they want? Moreover, it's not just switching:
            "adam_w_mode": false,

to true/false, but also needing to adjust weight decay, so it'd be much simpler to have separate full section for Adam and AdamW with the recommended defaults of all the other params.
Otherwise it's more error-prone if you see what I mean (changing one param, but not the others)
Currently, since HF Trainer uses AdamW by default, the config I used is:
   "zero_allow_untested_optimizer": true,
   "optimizer": {
     "type": "AdamW",
     "params": {
       "lr": 3e-5,
       "betas": [
         0.8,
         0.999
       ],
       "eps": 1e-8,
       "weight_decay": 3e-7
     }
   },

I'm also not sure why the user can't set explicitly DeepSpeedCPUAdam so it's loud and clear that this is what they want to use and not rely on magic combinations of:
            # zero-offload  torch-adam  adam_w_mode optimizer
            # T|F           T           T           torch.optim.AdamW
            # T|F           T           F           torch.optim.Adam
            # T             F           T|F         DeepSpeedCPUAdam(adam_w_mode)
            # F             F           T|F         FusedAdam(adam_w_mode)

The behind-the-scenes magic is probably great for general use, but there is a lot of power in knowing exactly what you're using and not second-guessing yourself. The runtime log does help to see which optimizer was magically selected out of these 4.
This secondary issue is not a strong need, since I have the log to tell me what optimizer was picked for me. Just a curiosity of why the explicit selection power is not given to the user.
Thank you.

@stas00 Thanks for reporting this issue. To respond to your main question, it is because of an oversight on our part that
"zero_allow_untested_optimizer": true, is currently required for  "optimizer": {  "type": "AdamW",.
A fix is in the works that makes "AdamW" as an optimizer type.

@stas00 Thanks for reporting this issue. To respond to your main question, it is because of an oversight on our part that
"zero_allow_untested_optimizer": true, is currently required for  "optimizer": {  "type": "AdamW",.
A fix is in the works that makes "AdamW" as an optimizer type.


fixed updating players

What does this implement/fix? Explain your changes.
Fixed the update players event, now the event visually displays updates, and fixed a few other previously unknown bugs.
Does this reference any currently open issues?
…
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. This is simply a reminder of what we are going to look for before merging your code.

[x] I have linted my code and I have run tests locally that pass
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

Any other comments?
…

References #152


new hook post-receive dont accept python

hi,
On last release v1.1.0,
the new hook post-receive does not allow we to execute scripts in python.
L6  : sh "$SHELL_FOLDER/post-receive.d/$i"
If we delete sh it's ok

+1 to remove the sh call.
Hooks can be in any language, as long as they are executables, they
should be executed.

So anyone could send a PR to fix that?

Please anyone doing a PR: wrap the execution in a function as there
are currently 3 different places where that overcomplex shell script
is executed

anything wrong with #1257?
(see also #1250 )

Let's move that issue and PR to discuss continue.


Change copyright year to 2020

Quick change of copyright year from 2010 to 2020

I will open a separate PR for that separate update.


tflite micro mbed image recognition example accuracy difference for custom model

@tensorflow/micro
System information

Host OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
TensorFlow installed from (source or binary): source
Tensorflow version (commit SHA if source): 2.1
Target platform (e.g. Arm Mbed OS, Arduino Nano 33 etc.): Arm mbed os Disco F746NG

When running tests for custom model,getting different results as compared to using python(floating point model)
1.Convert model to tflite :
converter = tf.lite.TFLiteConverter.from_keras_model(tf_model)
tflite_model = converter.convert()
open('./converted_model_v1.tflite', 'wb').write(tflite_model)

2.created image header with test images 18 :
for i,j in enumerate(image_list[:]):
print(j)
im = Image.open(j)
im = im.resize((32,32))
im = (np.array(im))
r = im[:,:,0].flatten()
g = im[:,:,1].flatten()
b = im[:,:,2].flatten()
label = [i//6]
if i==0:
    out = np.array(list(label)+list(b)+list(g)+list(r),np.uint8)

else:
    out=np.append(out,np.array(list(label)+list(b)+list(g)+list(r),np.uint8))

out.tofile("tflite_sliced_images.bin")
xxd -i tflite_sliced_images.bin test_image.h
3.Accessing outputs using :
data.f[0],
data.f[1],
data.f[2]

@fran203
Please share complete stand alone code such that we could replicate your issue or please share colab gist with issue faced for us to analyse

Image recognition example :
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/micro/examples/image_recognition_experimental
modifications made to main:
[main.zip]
(https://github.com/tensorflow/tensorflow/files/4851720/main.zip)
other changes :
1.replaced image model with a custom model
2.replaced data in image_header.
I'm not sure whether while creating the image binary input has to be set to float32/uint8 and whether that is causing the difference in predictions.

@Saduf2019 let me know if any other details are required

I have also tried with quantized model.When using quantized model,the interpreter call gives a hardfault error.
Conversion :
converter = tf.lite.TFLiteConverter.from_keras_model(model)
converter.optimizations = [tf.lite.Optimize.DEFAULT]
# This ensures that if any ops can't be quantized, the converter throws an error
converter.target_spec.supported_ops = [tf.lite.OpsSet.TFLITE_BUILTINS_INT8]
# These set the input and output tensors to uint8
converter.inference_input_type = tf.uint8
converter.inference_output_type = tf.uint8
# And this sets the representative dataset so we can quantize the activations
converter.representative_dataset = representative_data_gen
tflite_model = converter.convert()

Ops register : (quantize and dequantize ops added and versions specified based on error message received when running)
  static tflite::MicroOpResolver<8> micro_op_resolver;

  micro_op_resolver.AddBuiltin(tflite::BuiltinOperator_QUANTIZE,
                               tflite::ops::micro::Register_QUANTIZE());
  micro_op_resolver.AddBuiltin(tflite::BuiltinOperator_CONV_2D,
                               tflite::ops::micro::Register_CONV_2D(),3);
  micro_op_resolver.AddBuiltin(tflite::BuiltinOperator_RELU,
                               tflite::ops::micro::Register_RELU());
    micro_op_resolver.AddBuiltin(tflite::BuiltinOperator_RESHAPE,
                              tflite::ops::micro::Register_RESHAPE());
  micro_op_resolver.AddBuiltin(tflite::BuiltinOperator_MAX_POOL_2D,
                               tflite::ops::micro::Register_MAX_POOL_2D(),2);
  micro_op_resolver.AddBuiltin(tflite::BuiltinOperator_FULLY_CONNECTED,
                               tflite::ops::micro::Register_FULLY_CONNECTED(),4);
  micro_op_resolver.AddBuiltin(tflite::BuiltinOperator_SOFTMAX,
                               tflite::ops::micro::Register_SOFTMAX(),2);
  micro_op_resolver.AddBuiltin(tflite::BuiltinOperator_DEQUANTIZE,
                               tflite::ops::micro::Register_DEQUANTIZE(),2);

@jvishnuvardhan @Saduf2019 is there anywhere i can find the model details(tf version used for training...and conversion to tflite) that gets downloaded in currently in the image_recognition example?
The model input and output in the sample model has uint8 as input and output type,but there are no quantize/dequantize ops in it.So if details about it can be provided, I can use the same versions and steps for my tflite generation.

Did you find the file "image_recognition_model.cc"? Or train the model by yoursefl?
I would like to run "image_recognition_test" but I did not find the data of trained model, only headfile.
Thank you!

cifar model and cifar test bin gets downloaded and the model.cc and image header is created with xxd when you run make for micro recognition tests..

@uf19414
you can find the urls here:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/micro/tools/make/third_party_downloads.inc
IMAGE_RECOGNITION_MODEL_URL := "https://storage.googleapis.com/download.tensorflow.org/models/tflite/cifar_image_recognition_model_2020_05_27.zip"

I'd like to check a few things:

Micro for now only support post-training quantization (the one with representative dataset) with int8 input and output for now.

When you feed the data in C++, you need to quantize the data from float to int8.

Another common issue is the quality of representative dataset. The quantization process will calibrate the min and max value for each tensor, if your dataset is ordered and biased (towards large value/small values) are fed in the representative dataset, then you have a bad quantization quality.

Let me know if it helps.

@fran203  This is a micro related issue,Please post this in micro repository and move this issue to closed status  ..Thanks!


No longer compiles

Because net2 was updated and no longer compiles with the version of Rust I'm using, I can no longer build mio.
In my Cargo.toml I tried to force a specific SHA for net2 so an earlier version would be used:
net2 = { git = "https://github.com/rust-lang-nursery/net2-rs.git", rev = "b9d0c2d5dc187265e1d13130c3b1c4a69d01da6a" }
Since mio is relaxed about the net2 version, mio will still try to build against the latest/broken net2.
I could fork mio and force the dependency on mio to be something that will work.
But, I'd rather not do that.
Does anyone know of an easier way? (upgrading rustc is not possible for me atm)
Thanks!

Hi @MarkSwanson I ran into this with my PR (https://github.com/carllerche/mio/pull/414) as well and things are left in a bit of a sticky place.  I think we need to upstream some changes to net2 to avoid the unnecessary breakage due to Cargo.toml updates.

For now you can manually edit the Cargo.lock file to only reference that
sha. As long as you don't cargo update net2 it should work fine.
On Fri, Jul 8, 2016 at 1:30 AM, Paul Osborne<EMAIL_ADDRESS>wrote:

Hi @MarkSwanson https://github.com/MarkSwanson I ran into this with my
PR (#414 https://github.com/carllerche/mio/pull/414) as well and things
are left in a bit of a sticky place. I think we need to upstream some
changes to net2 to avoid the unnecessary breakage due to Cargo.toml updates.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/carllerche/mio/issues/424#issuecomment-231278416, or mute
the thread
https://github.com/notifications/unsubscribe/AAcf-cRgaVh5wJan6KGtD_0tOFhAz-fGks5qTeBsgaJpZM4JHuuf
.

I've pushed an updated net2 which I believe should be compatible, so I'm gonna close. Sorry for the breakage!


Continue removing custom fixed width integer aliases

Description
Building on what I started in #2192.

SFMLBuildMaster: Build this please.

Functional casts (which are only a C++ feature) would drastically cut down on verbosity which still having identical behavior. No need to resort to C-style casts.

Two things:

I am generally happy with this change and removing sf::*Int* typedefs, but is there any drawback in doing so? I cannot think of any off the top of my head, but just wondering if there's something we're missing.

<cstdint> needs to be explicitly included everywhere these fixed aliases are used, otherwise we're relying on transitive inclusions.

The main drawback is verbosity since we're insisting on using std:: everywhere.
How about I wait until the last PR in this series to remove  from Config.hpp and add that to all other files which need it? We already heavily rely on transitive inclusions and I've never once seen it be a problem.

We already heavily rely on transitive inclusions and I've never once seen it be a problem.

Also, don't we have CIs for various platforms to precisely test things like this? We already support more configurations than many C++ projects, and if someone has yet another setup, they can help us configure it with a PR.
If it's easy to write code to follow best-practices, why not. But lately we lose a lot of time with theoretical issues that have absolutely zero impact on any user (and don't get me wrong, I'm fully part of that)... 😉

Also, don't we have CIs for various platforms to precisely test things like this?

Exactly. As long as there are no CI failures and as long as the contributors aren't annoyed by transitive inclusions, I see no problem that needs to be fixed. We're just creating work for ourselves which will present an ongoing maintenance burden. In my time working on SFML, I've never once seen a complaint about our use of transitive inclusions nor have I personally thought twice about it. Everything works and I'm happy that I don't have to add #include statements all over the place.

If it's easy to write code to follow best-practices, why not.

I do not think this constitutes best practice.

But lately we lose a lot of time with theoretical issues that have absolutely zero impact on any user (and don't get me wrong, I'm fully part of that)... 😉

Establishing precedent is good and this is yet another precedent which (as far as I'm aware) has not be established.

I've used include-what-you-use in the past but came away annoyed at its recommendation to include non-standard headers. It provided some useful feedback (which I actually used to remove unnecessary #include statements) but I had to careful cherry-pick advice to make use of it.
If someone can successfully integrate IWYU up to the standards of our clang-format integration, I'm happy to revisit the idea of potentially following the include-what-you-use philosophy. For today given our lack of tooling support, I'd much prefer we continue to rely on transitive inclusions and I'm confident they won't present a problem in the future.

Some stuff like
const auto uint16Result = static_cast<std::uint16_t>(
    static_cast<std::uint16_t>(lhs) * static_cast<std::uint16_t>(rhs));

is now excessively verbose.

@Bromeon Drastically less verbose options exist without needing any C features. I hope we give this more consideration since it stands to let us remove a lot of code while perfectly maintaining existing behavior. It's also an easy find-replace command so the writing of a PR won't take much time either. Topic for another PR but think about it.
const auto uint16Result = std::uint16_t(std::uint16_t(lhs) * std::uint16_t(rhs));

@Bromeon Drastically less verbose options exist without needing any C features. I hope we give this more consideration since it stands to let us remove a lot of code while perfectly maintaining existing behavior. It's also an easy find-replace command so the writing of a PR won't take much time either. Topic for another PR but think about it.
const auto uint16Result = std::uint16_t(std::uint16_t(lhs) * std::uint16_t(rhs));

Function-style casts in particular suffer from the same problem as C casts -- namely not that they are C (even if that alone were ground for religious aversion to some C++ developers 😛), but rather that they are less type-safe than static_cast. They can be accidentally used to do pointer-casts or const-casts, for example.
A better solution in my opinion would be named functions:
const auto uint16Result = toUint16(toUint16(lhs) * toUint16(rhs));

People will still argue that this confuses everyone because it takes 10 seconds to look at the definition once... but we can't have everything.

For me it's somewhat interesting that we always argue about issues that are solved problems in any modern language.
Examples:

no language needs std:: before every identifier
no language has such an excessive cast syntax
no language has variable-sized basic types and requires the standard library just to express something as basic as "16-bit int"
no language has 4 different initialization syntaxes

Reality is that C++ allows many different styles, and even something as simple as declaring a variable needs trade-offs. I do think however we can learn from other languages how to do things more pragmatically. For me the best way is not necessarily "the standard way" (if that exists) but one that gets the job done equally well but is also readable. I think people underestimate how important readability is -- not just to understand what the code is doing, but it can also pose an entry barrier for new contributors, for example. Readability is of course subjective, and we need to think who our target audience is -- is it people with lots of years of C++ experience? Or people who have used other languages and are relatively new?
Anyway, this just some brainstorming 🙂 I think in the end we should use one style that most of us are comforable with and go with it.

Function-style casts in particular suffer from the same problem as C casts

I'm fully aware and recommend functional casts with all of that in mind. The nature of their syntax makes them meaningfully harder to abuse than C-style casts. You can't write code like float*(&i) whereas you can easily write (float*)&i. When we're annoyed by how verbose static_cast is, let's consider an alternative already baked into the language. It has big potential to improve readability.

we need to think who our target audience is -- is it people with lots of years of C++ experience?

For PRs like this yes it is. We have no obligation to make the implementation of SFML itself be understandable to novices and we should not be afraid to use sophisticated solutions where appropriate. For the API itself, the audience includes those with exceedingly little C++ experience.


Add support for RHEL 9

[ ] Provide/Create RHEL 9 Image & documentation for hetzner servers
[ ] Test hetzner-ocp4 Playbooks

Tried to create an image based on https://keithtenzer.com/cloud/how-to-create-a-rhel-8-image-for-hetzner-root-servers/
After creating an image and installation if failed,  there is still the device uuid 432d61fd-26f4-... in /boot and /etc in use. It looks like the installer doesn't cleanup / replaced it very well.
My current steps for image creation:
Install RHEL 9 minimal, custom partitioning without lvm.

Run those commands:
ln -s /usr/bin/dracut /sbin/dracut
dnf install -y mdadm lvm2
subscription-manager remove --all
cd /
tar cJvf CentOS-80-stream-amd64-base.tar.xz --exclude=/dev \
--exclude=/proc --exclude=/sys --exclude=/CentOS-75-el-x86_64-minimal.tar.xz /

An RHEL 9 installation via KVM & ISO was successful.

Error message at rhel 9 boot:

will upgrading from rhel8 to rhel9 work on a working installation?

@lucamaf never tested, it's possible to upgrade an installation from rhel8 to rhel9?

Is there any network-script included in the current configuration? or any
python2 library ? cause those 2 things might be the only preventing a
correct upgrade.
I would assume RHEV should be working without any major difference between
RHEL8 and RHEL9
On Fri, Jul 22, 2022 at 10:09 AM Robert Bohne @.***>
wrote:

@lucamaf https://github.com/lucamaf never tested, it's possible to
upgrade an installation from rhel8 to rhel9?
—
Reply to this email directly, view it on GitHub
https://github.com/RedHat-EMEA-SSA-Team/hetzner-ocp4/issues/219#issuecomment-1192303055,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANFTI2NZTWUNG4DOHUUEYDVVJJK5ANCNFSM5YCMZ5CQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
LUCA MATTIA FERRARI
EMEA SENIOR EDGE SOLUTION ARCHITECT, ITILV3
Red Hat Spain https://www.redhat.com/
travessera de Gracia, 11
08021, Barcelona
@.***    M: +34-653-225-181
http://redhatemailsignature-marketing.itos.redhat.com/
https://red.ht/sig

What? I'm lost... RHEV? hetzner-ocp4 use plain kvm. no ovirt no rhev just kvm.

sorry, just meant kvm (got confused for a second)
On Fri, Jul 22, 2022 at 11:56 AM Robert Bohne @.***>
wrote:

What? I'm lost... RHEV? hetzner-ocp4 use plain kvm. no ovirt no rhev just
kvm.
—
Reply to this email directly, view it on GitHub
https://github.com/RedHat-EMEA-SSA-Team/hetzner-ocp4/issues/219#issuecomment-1192398452,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANFTIZW3NLC422OF327K53VVJV5JANCNFSM5YCMZ5CQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
LUCA MATTIA FERRARI
EMEA SENIOR EDGE SOLUTION ARCHITECT, ITILV3
Red Hat Spain https://www.redhat.com/
travessera de Gracia, 11
08021, Barcelona
@.***    M: +34-653-225-181
http://redhatemailsignature-marketing.itos.redhat.com/
https://red.ht/sig

Lucamaf yes you can update to RHEL 9 from RHEL 8

Lucamaf yes you can update to RHEL 9 from RHEL 8

@kborup-redhat  Do you have any how-to / information for us?

Added base image introduction with #234 - thanks to @knumskull


Update Installation guide

I hope this makes the installation process of python and ASReview a bit more smooth!
The main things I propose to change:

[x] replace installing Anaconda by installing Python
[x] add screenshots on Python installation for windows users
[x] split the installation guide into two: one for windows and one for macos/unix users
[x] add instruction on how to launch ASReview at the end of the installation instruction
[x] add an extra error to the troubleshoot section
[ ] add screenshots on Python installation for macos users

FYI: On GitHub it looks like some links are broken but I can't seem to get them right, maybe this is only related to GitHub and will be gone once this document is on rtd?

Thanks for the PR. Very welcome.

FYI: On GitHub it looks like some links are broken but I can't seem to get them right, maybe this is only related to GitHub and will be gone once this document is on rtd?

Extensions on Github end with .rst, in Sphinx, this will be .html. However, links are also broken in the PDF. So the following is preferred: https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#cross-referencing-arbitrary-locations.

@J535D165 I want my links to open in a new window, but for my quicktour link for example, adding target = "_blank" doesn't make the hyperlink open in a new window 👎
Please follow the steps in our |quicktour| on how to carry out your first Automated Systematic Review!

.. |quicktour| raw:: html

    <a href="https://asreview.readthedocs.io/en/latest/quicktour.html" target="_blank">Quick Tour </a>

But I expect this problem to fix itself once it gets to .html?


Bot not working

Very helpful hello world example. But you're missing an important step on the bot setup:
Set the "Bot endpoint address" to: https://[yourdomain].ngrok.io/api/messages
Otherwise the bot and the messaging extension wont work. It took me an hour to figure it out.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 98cd21c7-e87c-3c5b-7574-998a355f9f08
Version Independent ID: 5e312707-facc-03fc-af59-90267d0c7b8a
Content: Get started with C#/.NET - Teams
Content Source: msteams-platform/get-started/get-started-dotnet-app-studio.md
Product: msteams
GitHub Login: @o365devx
Microsoft Alias: o365devx

Came across the same key peice of info missing from the doco. I went to update this page in the Git Repo but found the page in the Master branch is significantly different and doesn't contain anywhere near as much detail? https://github.com/MicrosoftDocs/msteams-docs/blob/master/msteams-platform/get-started/get-started-dotnet-app-studio.md

The documentation has been updated with the missing step. Thanks for letting us know.


Homogenize file (batch) Operation using Snapshots

It is more than confusing how to manage file / file shares. Especially when using snapshots!
Creating snapshots for shares and files: az storage share .... --> Available
Restore share snapshots: not available.
Delete share snapshot: not available.
Restore File from snapshot in the same share and storage: az storage file copy ... --> Available
Restore Files from snapshot in the same share and storage:  not available
Download file from Snapshot: Available
Download files from Snapshot: Not available.
Restore Files from Snapshot to another storage / share: Not available
I know that Share and files in a share are two topics. But the current functional overview for share and files is confusing:

The both have some common functions (Snapshots are done by the share functionalities)
There is a lack of Snapshot Management regarding Files and Shares as described above.
Snapshot Management of a share should also include delete and restore of the complete snapshot.

Environment summary
Install Method (e.g. pip, interactive script, apt-get, Docker, MSI, edge build) / CLI version (az --version) / OS version / Shell Type (e.g. bash, cmd.exe, Bash on Windows)

@williexu, can you please comment?

@dtissen I apologize for your troubles. Please look at https://docs.microsoft.com/en-us/azure/storage/files/storage-how-to-use-files-cli#create-and-manage-share-snapshots for in depth information on using share snapshots.
For the scenarios you mentioned:
Creating snapshots for shares and files: az storage share snapshot
Restore share snapshots: not available (this is not supported by the service)
Delete share snapshot: az storage share delete --snapshot
Downloading multiple files from a share snapshot: I've opened a PR to add this: https://github.com/Azure/azure-cli/pull/8718
The copy file from one snapshot to another is more complicated as the service supports this through a source-file url. I've opened another issue to address that: https://github.com/Azure/azure-cli/issues/8719


cargo-dist GH Action job "upload-local-artifacts" failing on Windows

I am trying to adopt cargo-dist for the release of our app "pigg".
The GH Action job "upload-local-artifacts" is failing on Windows, and I'm not sure what I should do to fix it.
See GH Action log here

Updated to latest cargo dist and will re-try


fix(cleanup): run partprobe commands only on block files

Signed-off-by: Akhil Mohan<EMAIL_ADDRESS>Why is this PR required? What issue does it fix?:
After cleaning up the device, partprobe was run on the device to reload the changes into the kernel. But running partprobe on sparse blockdevices can error out.
What this PR does?:

Added an additional check to run partprobe only if the device is a block file.

Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Yes. The following 2 cases were tested.

Run the cleanup job on a sparse file
Run the cleanup job on a regular disk

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Fix bug introduced in  #445
Checklist:

[x] Fixes #3084
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[x] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Codecov Report

Merging #463 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
- Coverage   44.74%   44.58%   -0.17%
==========================================
  Files          64       64
  Lines        2990     2990
==========================================
- Hits         1338     1333       -5
- Misses       1548     1551       +3
- Partials      104      106       +2

Impacted Files
Coverage Δ

cmd/ndm_daemonset/probe/eventhandler.go
42.85% <0.00%> (-6.13%)
:arrow_down:

cmd/ndm_daemonset/probe/udevprobe.go
58.44% <0.00%> (-1.30%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fac128...0068bfc. Read the comment docs.

@kmova PTAL, all the required comments have been added.


Compile error

Hi
what are the warnings bro?
keyhunt.c: In function ‘int main(int, char**)’:                                                                         keyhunt.c:668:47: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=]                                                                                668 |     fprintf(stderr,"[E] error bloom_init for %u elements.\n",N);                                                      |                                              ~^              ~                                                        |                                               |              |                                                        |                                               unsigned int   uint64_t {aka long unsigned int}                         |                                              %lu

is about format printing is OK work with that warning, i will solve it later.

thx bro!!!!