ds:Signature data not coming in saml request

I am using java onelogin toolkit in my project. I am able to send the SAML request and is getting response
But only thing which is not working for me is that the signed SAML request is not coming. Please help.
If 'strict' is True, then the Java Toolkit will reject unsigned
or unencrypted messages if it expects them signed or encrypted
Also will reject the messages if not strictly follow the SAML
onelogin.saml2.strict = true

Enable debug mode (to print errors)
onelogin.saml2.debug = true

Identifier of the SP entity (must be a URI)
onelogin.saml2.sp.entityid = https://installs.mycompany.com/start/metadata.jsp

Specifies info about where and how the message MUST be
returned to the requester, in this case our SP.
URL Location where the from the IdP will be returned
onelogin.saml2.sp.assertion_consumer_service.url = http://installs.mycompany/start/login.jsp

SAML protocol binding to be used when returning the
message. Onelogin Toolkit supports for this endpoint the
HTTP-POST binding only
onelogin.saml2.sp.assertion_consumer_service.binding = urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect

Specifies info about where and how the message MUST be
returned to the requester, in this case our SP.
onelogin.saml2.sp.single_logout_service.url = http://installs.mycompany/start/Logout.jsp

SAML protocol binding to be used when returning the or sending the
message. Onelogin Toolkit supports for this endpoint the
HTTP-Redirect binding only
onelogin.saml2.sp.single_logout_service.binding = urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect

Specifies constraints on the name identifier to be used to
represent the requested subject.
Take a look on lib/Saml2/Constants.php to see the NameIdFormat supported
onelogin.saml2.sp.nameidformat = urn:oasis:names:tc:SAML:1.1:nameid-format:unspecified
Usually x509cert and privateKey of the SP are provided by files placed at
the certs folder. But we can also provide them with the following parameters
onelogin.saml2.sp.x509cert = MIIDyzCCArKgA..................

Requires Format PKCS#8 BEGIN PRIVATE KEY
If you have PKCS#1 BEGIN RSA PRIVATE KEY convert it by openssl pkcs8 -topk8 -inform pem -nocrypt -in sp.rsa_key -outform pem -out sp.pem
onelogin.saml2.sp.privatekey = MIIEwQI................

Identity Provider Data that we want connect with our SP
Identifier of the IdP entity (must be a URI)
onelogin.saml2.idp.entityid = https://testIdp.com/

SSO endpoint info of the IdP. (Authentication Request protocol)
URL Target of the IdP where the SP will send the Authentication Request Message
onelogin.saml2.idp.single_sign_on_service.url = https://testIdp/nidp/saml2/sso

SAML protocol binding to be used when returning the
message. Onelogin Toolkit supports for this endpoint the
HTTP-Redirect binding only
onelogin.saml2.idp.single_sign_on_service.binding = urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect

SLO endpoint info of the IdP.
URL Location of the IdP where the SP will send the SLO Request
onelogin.saml2.idp.single_logout_service.url =

Optional SLO Response endpoint info of the IdP.
URL Location of the IdP where the SP will send the SLO Response. If left blank, same URL as onelogin.saml2.idp.single_logout_service.url will be used.
Some IdPs use a separate URL for sending a logout request and response, use this property to set the separate response url
onelogin.saml2.idp.single_logout_service.response.url =

SAML protocol binding to be used when returning the
message. Onelogin Toolkit supports for this endpoint the
HTTP-Redirect binding only
onelogin.saml2.idp.single_logout_service.binding = urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect

Public x509 certificate of the IdP
onelogin.saml2.idp.x509cert = MIIFJDCC..................

Instead of use the whole x509cert you can use a fingerprint
(openssl x509 -noout -fingerprint -in "idp.crt" to generate it,
or add for example the -sha256 , -sha384 or -sha512 parameter)
If a fingerprint is provided, then the certFingerprintAlgorithm is required in order to
let the toolkit know which Algorithm was used. Possible values: sha1, sha256, sha384 or sha512
'sha1' is the default value.
onelogin.saml2.idp.certfingerprint = 14:F3:42:DC:0A:DF:8A:6A:F8:6E:E3:F7:06:47:11:46:A9:2B:0A:73
onelogin.saml2.idp.certfingerprint_algorithm = sha256

Security settings
Indicates that the nameID of the samlp:logoutRequest sent by this SP
will be encrypted.
onelogin.saml2.security.nameid_encrypted = true

Indicates whether the samlp:AuthnRequest messages sent by this SP
will be signed. [The Metadata of the SP will offer this info]
onelogin.saml2.security.authnrequest_signed = true

Indicates whether the samlp:logoutRequest messages sent by this SP
will be signed.
onelogin.saml2.security.logoutrequest_signed = false

Indicates whether the samlp:logoutResponse messages sent by this SP
will be signed.
onelogin.saml2.security.logoutresponse_signed = false

Sign the Metadata
Empty means no signature, or comma separate the keyFileName and the certFileName
onelogin.saml2.security.want_messages_signed =

Indicates a requirement for the samlp:Response, samlp:LogoutRequest and
samlp:LogoutResponse elements received by this SP to be signed.
onelogin.saml2.security.want_assertions_signed = true

Indicates a requirement for the Metadata of this SP to be signed.
Right now supported null (in order to not sign) or true (sign using SP private key)
onelogin.saml2.security.sign_metadata = false

Indicates a requirement for the Assertions received by this SP to be encrypted
onelogin.saml2.security.want_assertions_encrypted = false

Indicates a requirement for the NameID received by this SP to be encrypted
onelogin.saml2.security.want_nameid_encrypted = false

Authentication context.
Set Empty and no AuthContext will be sent in the AuthNRequest,
Set comma separated values urn:oasis:names:tc:SAML:2.0:ac:classes:urn:oasis:names:tc:SAML:2.0:ac:classes:Password
#onelogin.saml2.security.requested_authncontext = urn:oasis:names:tc:SAML:2.0:ac:classes:urn:oasis:names:tc:SAML:2.0:ac:classes:Password

Indicates if the SP will validate all received xmls.
(In order to validate the xml, 'strict' and 'wantXMLValidation' must be true).
onelogin.saml2.security.want_xml_validation = true

Algorithm that the toolkit will use on signing process. Options:
'http://www.w3.org/2000/09/xmldsig#rsa-sha1'
'http://www.w3.org/2000/09/xmldsig#dsa-sha1'
'http://www.w3.org/2001/04/xmldsig-more#rsa-sha256'
'http://www.w3.org/2001/04/xmldsig-more#rsa-sha384'
'http://www.w3.org/2001/04/xmldsig-more#rsa-sha512'
onelogin.saml2.security.signature_algorithm = http://www.w3.org/2000/09/xmldsig#rsa-sha256

Generated Saml request as below:
<samlp:AuthnRequest xmlns:samlp="urn:oasis:names:tc:SAML:2.0:protocol"
xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion"
ID="ONELOGIN_50826410-f003-4df5-854a-6440b185c628"
Version="2.0" IssueInstant="2018-01-18T06:50:30Z"
Destination="https://testIdp.com/nidp/saml2/sso"
ProtocolBinding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST"
AssertionConsumerServiceURL="http://installs.mycompany/dpc/start/login.jsp">
saml:Issuerhttps://installs.mycompany/start/metadata.jsp</saml:Issuer>
<samlp:NameIDPolicy Format="urn:oasis:names:tc:SAML:1.1:nameid-format:unspecified" AllowCreate="true" />
<samlp:RequestedAuthnContext Comparison="exact">
saml:AuthnContextClassRefurn:oasis:names:tc:SAML:2.0:ac:classes:urn:oasis:names:tc:SAML:2.0:ac:classes:Password</saml:AuthnContextClassRef>
</samlp:RequestedAuthnContext>
</samlp:AuthnRequest>

@pitbulk
Is Java-SAML safe from this Vulnerability ( https://www.kb.cert.org/vuls/id/475445 ), however blog has not reported about 'java-saml' but still need confirmation from your end. Please confirm. Thanks.

@mandeep5299 if you have a new issue on java-saml you should create a new one instead of reply on other not related issue thread.
java-saml is not listed on that report because was not vulnerable.


Convert numbered pinyin to pinyin with tone marks

Hello!
Is it possible to convert a pinyin string using numbers to the one with tone marks?
ni3hao3 => nǐhǎo
Thank you for the help!

try this one for that feature: https://pub.dev/packages/pinyinizer

Perfect! Thank you for the suggestion!


Releasing RNNoise version 0.2

This new release brings many improvements, including improved training, SSE4.1 and AVX2 optimizations, and run-time CPU detection (RTCD).
The distributed models are now trained using only publicly available datasets.

This release expects the build process to execute a arbitrary-shellscript to download an arbitrary file as part of the build process; outside of cmake, in a potentially privileged environment.
If I can find the time, I will PR fix for your Cmake or alike; I'm sorry I'm not doing it now - because it's very exciting to me this project is moving again.
But as it stands, this is a pretty big hole for practical secure CI-pipelines and reliability in isolated or secure environments.
In short - do not do this.
THAT SAID:
I'm honestly glad this project is getting some much needed attention; but please remember that it's been relied upon for various uses, on various platforms for a very long time now.
If your not considering the need to build this as a standalone Risc-V library for a non-linux operating-system; You should be.
It may need to be built without internet access.
And on windows XP; to support cable TV stations using it with Gstreamer.
And many, many more that I'm aware of.
Keep up the good work, do good things, and have pride - just don't forget the use-cases beyond your own. ;)

[John Bargman]

This release expects the build process to execute a
arbitrary-shellscript to download an arbitrary file as part of the
build process; outside of cmake, in a potentially privileged
environment.

This sound like a prospective xz disaster, indeed.  Where is the code
causing this?  At least the Debian build servers do not all have
Internet access during build, so it would fail at least some
architectures.
--
Happy hacking
Petter Reinholdtsen

So there's two things here: one is the download script and the other is the actual content being fetched. In terms of the script itself, it's fairly simple to audit and see that it's not doing anything bad. It's also in git and signed, so I don't really see a trust issue compared to trusting the rest of the source code.
When it comes the the actual model data being fetched, I can see how it's not as safe as the rest of the Git content (sha1 and signature). One possible way to solve that would be the equivalent to what was just added to Opus:
https://github.com/xiph/opus/commit/9faf6f071
The idea Is that Git will hold the sha256 of the downloaded content and thus it can check that the checksums actually match before using it. That way compromising the server will just result in a build failure.

The idea Is that Git will hold the sha256 of the downloaded content and thus it can check that the checksums actually match before using it. That way compromising the server will just result in a build failure.

This is without question an acceptable solution - I come from a version of linux called NixOS; our package manager does this for all external downloads as part of the build step; ( which is how I came to be here: https://github.com/NixOS/nixpkgs/issues/304433 )
The shellscript itself is an acceptable compromise if an external download is absolutely required; in my personal ideal external data would be fetched by git submodule (providing a solid revision control), or the dependency treated as such.
It seems the model for RNNoise has always been a dependency;

[Jean-Marc Valin]

So there's two things here: one is the download script and the other
is the actual content being fetched. In terms of the script itself,
it's fairly simple to audit and see that it's not doing anything
bad. It's also in git and signed, so I don't really see a trust issue
compared to trusting the rest of the source code.

Most Linux distributions block package building from downloading stuff
from the Internet, to ensure reproducibility, consistency and
completeness, and I would strongly suggest to not base the RNNoise build
on such practice for rnnoise.
--
Happy hacking
Petter Reinholdtsen

@petterreinholdtsen Do you have alternatives to suggest for distributing a 20 MB binary file? In version 0.1, the model was much smaller (and it still wasn't great) and didn't include the binary model (which is the preferred form for making modifications in that case).

[Jean-Marc Valin]

@petterreinholdtsen Do you have alternatives to suggest for
distributing a 20 MB binary file? In version 0.1, the model was much
smaller (and it still wasn't great) and didn't include the binary
model (which is the preferred form for making modifications in that
case).

I would suggest to include it in the git repository and release
tarballs.
--
Happy hacking
Petter Reinholdtsen

All package managers I know of have the ability to specify multiple source packages - I'd expect them to specify the model data as one of the sources. The nixpkgs approach seems good.
Having a hash of the data in git should be enough for revision control to ensure that it has the same version of the model as the code was designed for. Submodules remain tricky to use, especially because the model is large and most people would want a shallow clone of it.

OK, the download process should be safer now as the download script will verify the sha256 before using the downloaded binary file.

[Thomas Daede]

Having a hash of the data in git should be enough for revision control
to ensure that it has the same version of the model as the code was
designed for.

Note, for release tarballs, such approach will break the deserted island
test of free software.  Those bringing the tarball and all its build
dependencies with you to a computer on a deserted island with no
Internet connectivity would not be able to build it as the build require
Internet connectivity and the abililty to download the model without
interferrence.
I heard a variant of the deserted island a few years ago, where the
people gathering together at AfricaSource, a free software development
confernece in the middle of a savannah, with no Internet connectivity,
used a collecting of Debian DVDs as their source of build dependencies.
--
Happy hacking
Petter Reinholdtsen

[Thomas Daede]
[SNIP]
Note, for release tarballs, such approach will break the deserted island test of free software.
[SNIP]
-- Happy hacking Petter Reinholdtsen

I have to agree with this statement - although one would hope that the dependency will find it's way onto a debian disk too ;)

Unless I missed something, the RNNoise 0.2 passes the desert island test fine. The download mechanism only applies to Git.

[Jean-Marc Valin]

Unless I missed something, the RNNoise 0.2 passes the desert island
test fine. The download mechanism only applies to Git.

Sound good.  From where can I download a tarball with the model
included, to verify no download from Internet take place during build?
--
Happy hacking
Petter Reinholdtsen

On the Releases page: https://github.com/xiph/rnnoise/releases/download/v0.2/rnnoise-0.2.tar.gz


Fixing trailing non-numerical character parsing issue

Improved parsing code for prerelease comparison so that trailing non-numerical characters do not cause NFEs; Reworked some code in Comparator to reduce "exceptions as flow control" occurrences; Inlined some one-line functions in Comparator to reduce code base size; Memoized regex patterns in Comparator
Fixes #234

Suggestions on additional test cases to add would be welcome

LGTM.


Update README to indicate that we're dead.

Don't bother voting, the bot is down.

Don't bother voting, the bot is down.

I'd prefer to vote anyway, we can still merge the PR and it's nice to get a consensus first.

I agree with @PlasmaPower. We should at least require reviews & allow some time for voting before merging while the bot is sleeping.

Can we make it say  "... dead for now ..." instead? This makes it sound as if people shouldn't try to contribute.

@mark-i-m I think when we restart it will be with a new code base.

Ah, got it


Add policy annotations to all GKE hardening related polices

Based on go/policy-bundles - the recommended annotations would look something like:
bundles.validator.forsetisecurity.org/[bundle_key]: [control]
Please add details for all GKE Hardening Policies
Example:
description: Disable the Kubernetes web UI (Dashboard)
bundles.validator.forsetisecurity.org/gke-hardening-guideline:

@joecheuk we might to define  some method for the [control] value related to GKE hardening guidelines or leave it blank

@dekuhn I recommend not leaving the control value blank, but instead come up with a control name for each guideline. Ex.
bundles.validator.forsetisecurity.org/gke-hardening-guideline: DISABLE_WEB_UI

@morgante @ryanismert @blueandgold - FYI
@joecheuk lets move forward with the following annotation format for GKE Hardening Guidelines
bundles.validator.forsetisecurity.org/gke-hardening-v2019.11.11: DISABLE_DASHBOARD_UI
It will be up to the engineer when adding these annotations to determine the text control name e.g. DISABLE_DASHBOARD_UI for each GKE hardening guideline.

I spent a little time starting to update a few rules today.
https://github.com/forseti-security/policy-library/pull/199
https://github.com/forseti-security/policy-library/pull/200


no module named 'traitlets'

fter running "sudo python3 setup.py install" and got no apparent error message
ModuleNotFoudError: No module named 'traitlets'

Use the below cmd to install
pip install traitlets


opengl core profile

i tried to do the version 3.2 core profile version on openfl by doing this #version 150 core but i don't thing sdl supports the core aspect even tho my machine supports 150 core

my macos is monterey and my graphics are intel HD Graphics 6000


Proposed Update to Colt.py

Environment

Python version: <3.9>
circuit_maintenance_parser version: <2.0.3>

Expected Behavior
Colt email subject Colt Service Affecting Maintenance Notification - CRQ1-xxxxx [20/8/2022 20:00:00 GMT - 21/8/2022 01:00:00 GMT] for YYYYY, XYZ is not properly handle by the parser.
Colt email doesn't start with [ EXTERNAL ], this field could have been add by the email platform used during the first tests.
The regex in SubjectParserColt1 and SubjectParserColt2 should be modify to not enforce the presence of brackets at the beginning of the email.
Observed Behavior
Colt Parser is expecting COLT email to start with [ .* ], the 2 brackets should be see as facultative as well.

Should have been resolved by #179


Option for disable any time frame

Hi,
Thanks for the card, is working great and is a nice help to manage timers.
Would be nice to have the option in settings to disable any of the saved time frames without deleting it.
Sometimes I need to change the irrigation (as sample) in spring/summer/autumn or any illumination and would like to use the same timer for all seasons.
What do you think?
(BTW: why the seconds are not available in settings? Any missed option from my side?)
Thanks!

Thanks @michapr for the feedback!
It's possible to add a "disable-range" option. It'll require also changes in the daily-schedule integration component (the backend) for saving this new option, and not only this card element (the frontend).
The main concern is that it might complicate the user experience of the dialog with a feature that is not used so often. BTW, this is also the reason that seconds are not displayed. Seconds are supported by the backend, so adding them is a frontend-only change.
Can you elaborate why it's better to use the same timer for all seasons, versus having a few fixed timers for the different seasons and picking the correct one as needed?
Here is a design option for making the select process more convenient:

Create a Dropbox helper entity (e.g. "input_select.irrigation_timer") where the options are the entity IDs of the per-season daily-schedule entities. (note: It's possible to create a more descriptive options by adding more logic in the template below, but not sure if it's really needed).
Create the following template entity, which should be the only one used in the automation rule(s) ("sensor.irrigation_timer"):

template:
  - sensor:
    - name: irrigation timer
      state: "{{ states(states('input_select.irrigation_timer')) }}"

Hi,
thanks for your answer.
I have a big number of switches / valves and would be fine to have for every device one timer only - it's more logical (for me ;-) ..)
I'm coming from Domoticz (3 years ago) what I was using a long time - here every switch have a device "property"
As sample:

It's very comfortable and good for an overview - what time frame is active - and it is easy to enable/disable any action.
I do not think "that it might complicate the user experience of the dialog" - if to add an option field "disable" and grey it out.
In overview (card element) it will not be shown - so no confusion, I think so.
It would allow to add one scheduler for each element/group for different situations/seasons.
Thanks!
Michael

Added the option to disable / enable a time range.
The minimum versions for this feature are:

Daily-schedule integration: v1.5.1
Daily-schedule lovelace card: v1.4.0


Migrate low prio release3 docs (various)

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/AutoPyFactory

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/AutoPyFactoryConfiguration

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/AutoPyFactoryDeployment

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/BanningUsersAtSite

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/BestmanGridftpPathPlugin

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/CertificateUserGet

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/GetHostServiceCertificatesWeb

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/GlexecPilotCert

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/GlideinWMSCampusGrid

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/GratiaTransferProbe

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/HadoopDebug

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/HadoopRecovery

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/InstallGlideinWMSFactory

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/InstallGridFtpXrootd

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/InstallHadoopSE

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/LocalStorageConfiguration

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/NetworkPerformanceToolkit

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/OsgCaManage

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/ReleaseNotes

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

https://twiki.opensciencegrid.org/bin/view/Documentation/Release3/SrmTester

[ ] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

Could you actually delete the following docs:

docs/other/autopy-factor.md
docs/other/autopy-factory-config.md
docs/other/autopy-factory-deployment.md

I'm still working out how we want to handle all the AutoPyFactory* docs (we still want to archive them so you can keep what's in archive/

I don't understand this PR.
For archive-only docs, I'm OK with big giant PRs moving them from point-A to point-B.
But if we're going to add content and expect real reviews, we should do things one-at-a-time.  Seems like some of these docs aren't converted as much as simply run through pandoc and committed.
Even low-priority docs should render well and be included in the mkdocs.yml.  If they're low-priority enough to not put them in the table of contents, then they don't need to be converted to markdown -- they can just live in the archive.
(Hm -- we should probably have a Travis-CI check to verify that all *.md docs are listed in mkdocs.yml.)

@brianhlin had asked to just get all these low-prio docs into a single big PR, though it was understood that this initial migration of them would not yet be tidied up.  @brianhlin, please clarify if you have any thoughts on this...

@edquist there have been some developments on the Oct 1 deadline, namely that we will be able to add migration headers after the fact so this mass migration isn't pressing (I would still like the migration/archival tools that do not perform any git actions).


Proposal: Allow type elision for struct fields in composite literals.

This is intended as a limited version of #12854 for potential consideration in Go 1.X.
The intent is to allow code like https://play.golang.org/p/btPLucof0o.
This was added to an earlier version of the spec in 5f49456, but removed in https://codereview.appspot.com/5451099 due to contention at the time (see https://groups.google.com/forum/#!topic/golang-dev/aWw7b-_FCF8). Based on #12854, I believe it is worth reviving this proposal.
The primary issue with this is that it requires stylistic rules to avoid code becoming extremely difficult to read. Consider the case of multiple nested structs from different packages: determining the type of a field that is nested inside four anonymous initializers may be too much. But on the other hand,
My personal experience is that it often leads to stutter, particularly with small types whose purpose is merely to act as a tuple (e.g. pair structs or testcase arrays), or when defining a large number of structs of the same type. A good starting guideline may be that you should only elide types whose name is qualified the same as the outer type---that is, they are either from the same package, or one is dot-imported and the other is from the current package. Ultimately, good judgement will still be required, however.
It is worth noting that one can already make difficult to read nested composite literals by naming a slice or map type: https://play.golang.org/p/tCvYU1T50R. That said, such nesting in named types is rare and so the threshold for supporting this behaviour should be much higher.

I forgot to mention: one case where this is especially egregious is with embedded fields, since the name is the same as the type the result is always going to be stutter.

#12854 is still open and will be considered when we start thinking about language changes again (which is why it's tagged Go2). We're not going to make non-essential incremental language changes until that time, even backwards compatible ones.
I'm going to close this issue, because it's a subset of (and now linked from) #12854, which remains open.


increase definition of Europe to be more inclusive

Increase definition of Europe to those countries in the European Political Community + Monaco, Andorra, San Marino and the Vatican City
https://upload.wikimedia.org/wikipedia/commons/6/6a/Supranational_European_Bodies.svg

Small update: I added the dependencies/territories of European countries that themselves are in Europe (thus no French Guyana or Antarctic territories or Caribbean dependencies).
	# The ISO 3166-1 alpha-2 codes for the countries in the European Political Community (EPC)
	# https://en.wikipedia.org/wiki/European_Political_Community
	epc_codes = ["AL", "AD", "AM", "AT", "AZ", "BE", "BA", "BG", "HR", "CY", "CZ", "DK", "EE", "FI",
				 "FR", "GE", "DE", "GR", "HU", "IS", "IE", "IT", "LV", "LI", "LT", "LU", "MT", "MD",
				 "MC", "ME", "NL", "MK", "NO", "PL", "PT", "RO", "SM", "RS", "SK", "SI", "ES", "SE",
				 "CH", "TR", "UA", "GB",
				 "XK", #temporary ISO code for Kosovo, used by the European Commsion and others (incl GBIF):
					  # https://geonames.wordpress.com/2010/03/08/xk-country-code-for-kosovo/
				 "VA", # Vatican City, not part of the EPC
				 # dependencies
				 "GG", #Guernsey
				 "JE", #Jersey
				 "IM", #Isle of Man
				 "GI", #Gibraltar
				 "SJ", #Svalbard and Jan Mayen
				 "AX", #Åland
				 "FO" #Faroe Islands
				 ]

@melanie-de-nolf @DavidFichtmueller
Can this issue be resolved?
I'm not keen to include Belarus and I think we have covered all other geographic issues


[Namings] Update job names

This commit unified gcc/clanf build/tests.

@leshikus can you comment?


[core] Export ThemeOptions

I added export for ThemeOptions.
Like import { createMuiTheme, ThemeOptions } from '@material-ui/core/styles'; and also changed the path in documentation.
@oliviertassinari, let me know if something went wrong

[x] I have followed (at least) the PR section of the contributing guide.

@dbarabashdev Much appreciated, thanks!


Include relevant social media logos in the page

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

okay i will


Make PRINT Macros act like c statements

Use the print and debug macros as shown in our c lecture.

Implement PRINT like
#define PRINT(str,...) \
    do {  \
        ... \
    } while (false)

-> requires ; after macro call

Use if to distinguish if debug should be executed
-> compiler sees code => prevends unexpected behaviour
-> compiler will remove statments on optimization


add open telemetry tracing

Closes: https://github.com/nitrictech/node-sdk/issues/149

Codecov Report
Patch coverage: 87.42% and project coverage change: +0.08 :tada:

Comparison is base (13a77b3) 85.81% compared to head (b8e447f) 85.90%.

:exclamation: Current head b8e447f differs from pull request most recent head 6052bdb. Consider uploading reports for the commit 6052bdb to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
+ Coverage    85.81%   85.90%   +0.08%
===========================================
  Files           82       83       +1
  Lines         1445     1518      +73
  Branches       143      207      +64
===========================================
+ Hits          1240     1304      +64
- Misses         203      208       +5
- Partials         2        6       +4

Impacted Files
Coverage Δ

src/api/documents/v0/collection-group-ref.ts
89.65% <ø> (ø)

src/api/documents/v0/documents.ts
100.00% <ø> (ø)

src/api/queues/v0/queues.ts
96.34% <ø> (+0.18%)
:arrow_up:

src/api/secrets/v0/secrets.ts
97.26% <ø> (+0.07%)
:arrow_up:

src/resources/bucket.ts
74.35% <0.00%> (+0.67%)
:arrow_up:

src/api/errors/deadline-exceeded.ts
25.00% <25.00%> (ø)

src/resources/topic.ts
86.95% <33.33%> (+0.28%)
:arrow_up:

src/resources/secret.ts
78.37% <45.45%> (+0.60%)
:arrow_up:

src/faas/v0/start.ts
33.60% <57.14%> (+1.10%)
:arrow_up:

src/resources/collection.ts
77.77% <66.66%> (+1.03%)
:arrow_up:

... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


remove @-mention URL e2e test (experimental feature)

Test plan
CI

@sqs It would be great if the PR had a brief justification of why we're removing this test. I feel weird asking #3480 to add tests if we've just been taking the tests out. We can also disable tests and the blame gives some clues about why the test is disabled...


PHP Deprecated:  str_replace()

To fix:
2022/10/31 17:49:37 [error] 15#15: *45 FastCGI sent in stderr: "PHP message: PHP Deprecated:  str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in /var/www/app/app/Core/Http/Route.php on line 155
Just need to add a empty parameter, when I or you get a chance. Just a annoying deprecated message.

To fix:
2022/10/31 17:49:37 [error] 15#15: *45 FastCGI sent in stderr: "PHP message: PHP Deprecated: str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in /var/www/app/app/Core/Http/Route.php on line 155
Just need to add a empty parameter, when I or you get a chance. Just a annoying deprecated message.

put it where though? in the core kanboard file? str_replace() isnt found in the plugin... or am I looking in the wrong place probably...

no no, its a deprecated warning. in php 7.4 you could have a null param, in php 8 and above you have to send all parameters if listed,  so just need to add all the parameters, its in our controller, I only sent the parameters I needed.

might be in the addroute, which I don't even need anymore, don't worry about it, I'll take care of it.


Hypercat compliance

To enable Hypercat compliance this datastore needs to implement:
A /cat endpoint that returns a valid Hypercat catalog. This must be app facing
A /register/datasource endpoint that is driver facing to enable a driver to add their sources

Implemented in f579b4df09e06638c7bab43a551c73e96d485007


First Hornet K8s StatefulSet PoC Working. Left to make peering persistent

Just a PoC of an alternative design which is more elegant and compact than #59 .
The config maps can be created just using kubectl through the existing hornet.sh utility functions.
More work pending on testing this on a real K8s environment, such us GKS, or AWS.
Tested on MicroK8s for MacOS.

closing and opening #67


Refactor and clean IR module

I've refactored the IR module so it's easier to maintain and read. I have renamed some functions for more Julia-like names. Also, I have added some missing methods in IR which use functionality from the C-API.
One of the biggest changes is that I've renamed MLIRType to Type. I found out that if we use Core.Type inside the IR module instead of the implicit Type, then there is no symbol clash. In order to avoid other clashes, this type is not exported so we need to access it like MLIR.IR.Type.
Some of these changes are opinionated, some of them not. Please, tell me your opinion.
New features

Added Identifier, SymbolTable, IntegerSet, AffineExpr, AffineMap types
MLIRType renamed to Type with no clash with Core.Type

To do

[x] Refactor Type
[x] Refactor Attribute
[x] Refactor examples
[ ] Refactor pass infrastructure
[x] Add @affinemap #35

To do list for other PRs

Implement simplify(::AffineMap)
Add MemRefDescriptor

This is super cool, thank you for this. I'll look into this and try it out the coming days but on cursory glance I don't see anything I would personally object to.
I believe you forgot to check in Type.jl and Attribute.jl or are you still working on it?

I believe you forgot to check in Type.jl and Attribute.jl or are you still working on it?

Yes, I'm still working on them.

@jumerckx Type and Attribute now submitted!

As a side note, I think we should not rely so much on asserts to throw errors since I discovered (since writing the initial MLIR.IR) that they can be removed depending on the optimization level so I think we should always perform the checks instead.

@Pangoraw ahh I thought you wanted asserts specifically because of that: because they can be deactivated. I can replace them for exceptions. Should we throw ArgumentError?
I just discovered that the C-API also changes in different versions, so I need to revise and add some checks for each LLVM version. Since we are all using very-up-to-date LLVM builds, maintaing version checks is a bit of a burden and looks like 1.10 will be the next LTS, what do you think about ditching LLVM 14 (Julia 1.9) support?

The Brutus example works now with this PR on both Julia 1.10 and 1.11

Codecov Report
Attention: Patch coverage is 1.07256% with 3136 lines in your changes are missing coverage. Please review.

Project coverage is 1.81%. Comparing base (c740c8b) to head (d17e76b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #62      +/-   ##
========================================
- Coverage   3.03%   1.81%   -1.23%
========================================
  Files        107     124      +17
  Lines      27923   28489     +566
========================================
- Hits         848     516     -332
- Misses     27075   27973     +898

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create fkggoettingen.txt

@Omdihar I'm sorry for the delay with my reply,
http://www.fkggoettingen.edu/ somehow won't open and the university website according to
Google is www.fkg-goettingen.de/ - please confirm with relevant link or document that http://www.fkggoettingen.edu/ also belongs to university. Thank you!

@Omdihar Actually, fkggoettingen.edu domain does not exist. Please change the path accordingly.

@Omdihar I am sorry, but this request does not seem relevant. I am closing it. Please make a new one with correct domain name, if necessary. Thank you for your understanding.


Python3.4 issue

File "/home/s/webapps/appt/lib/python3.4/site-packages/pyelliptic/ecc.py", line 89, in init
self.privkey, self.pubkey_x, self.pubkey_y = self._generate()
File "/home/s/webapps/appt/lib/python3.4/site-packages/pyelliptic/ecc.py", line 223, in _generate
raise Exception("[OpenSSL] EC_KEY_generate_key FAIL ... " + OpenSSL.get_error())
TypeError: Can't convert 'bytes' object to str implicitly

I am getting kind of same exception for Python2.7. Don't think this to be python issue.
(Ref Issue Link: https://github.com/yann2192/pyelliptic/issues/48)

May be OpenSSL.get_error() returns bytes.

How is this method called from your python code ?


chore: Increase maximum supported Kubernetes version for KEDA v2.14

chore: Increase maximum supported Kubernetes version for KEDA v2.14
Checklist

[X] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to https://github.com/kedacore/keda/issues/5671

/run-e2e internal


Implement Linux OS layer

As far as I understand, a OS layer for Linux (apart from native) does not exist. Having an OS layer is beneficial if, for example, a VM guest is running on Linux.

Hi, thanks for the request! It is an open research problem to autodetect kernel structure offsets, and it is crucial for one-shot Linux system analysis. It has been on our roadmap for years, and it should ideally be tackled over the next 1-2 years.
I suppose in the meantime, it might be worth to expose a Linux OS layer with hardcoded offsets. It would not be pretty from user perspective, but it would also not deviate much from existing practices. What do you think @ko1N?

Could we use a similiar solution as in memflow-win32 where we parse offsets from a binary and use those? We could force the user supply those beforehand even.

There is a way maybe can solve autodetect kernel structure offsets .
https://volatility3.readthedocs.io/en/latest/symbol-tables.html


Create docker-compose development environment

Description
To develop, we need a development environment. We have need to create a development environment for the Wazuh Dashboard app to run, tests and build the source code of the app and the security plugin.
We'll follow the same approach as in our Wazuh Kibana app environments.
Tasks

[x] Create a docker compose environment, following our Docker strategy

Considerations

Create the docker folder and add the new files there (scripts, configuration files, ...).

Re-opened in #52
See https://github.com/wazuh/wazuh-dashboard/issues/1#issuecomment-1516555068 for details.


[PanModal] Round frame positions for comparison

Summary

Speculative fix for floating point precision issue when comparing presentedView & user determined anchored y position

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Love the theme of terminal in README, could you tell me the theme name?

:), thanks, although not related.

It's a theme Ramon made! He's gonna release it sometime— so keep an eye out for it on Twitter. We'll also let you know when he release it. He's @RamonGilabert on there :)

Here it is y'all!
https://github.com/RamonGilabert/Terminal

thanks~


Merge with PokeTrainer

Hi!
Awesome tool you've made! Works like a charm. :-) May I suggest that you merge your capability with this Python tool: https://github.com/j-e-k/poketrainer ?
Would be awesome if we were able to utilize the sniper function from the website while running that bot. Shouldn't be too hard, it's nearly identical and you're using the same lib.

I'm leaving town for 4 days to go to a family reunion. Unfortunately I won't have the time to do this. I'm not opposed to the idea, though, if somebody else wants to do it ;).


fix for Sinject::DependencyContractInvalidParametersException

fix for Sinject::DependencyContractInvalidParametersException: The method signature of method: 'get' does not match the contract parameters: 'block'

What was this supposed to address? The description does not contain enough detail to evaluate that.
Besides that, I believe that this change introduces a bug. If a contract class specifies keyrest args, and the concrete class doesn't, then the concrete class is not implementing the contract.
This contract states that #foo must accept any number of keyword arguments:
class Contract
  def foo(bar:, **kwargs); end
end

This class does not satisfy the contract because it does not accept any number of keyword arguments, it accepts precisely two:
class Concrete
  def foo(bar:, kwargs: nil); end
end

However, with this change the contract validation will now accept the class!
On the other hand, it will not accept this one because kwargs is keyreq:
class Concrete
  def foo(bar:, kwargs:); end
end

I'm raising a bug for this, but if you're now depending on this behaviour, it's going to be difficult to fix it.


Create dotnet-desktop.yml

.github/workflows/dotnet-desktop.yml

@thicha10 I couldn't follow. What's the purpose of this PR?


Bitfinex API version upgrade

Latest bug fixes https://github.com/bitfinexcom/bitfinex-api-node

I think you forgot to update the package-lock.json

Do we need that lock?


Removal of faulty regex

In ref to
https://github.com/openstreetmap/iD/issues/2892

Looks great, thank you!

@kepta nice :boom:

FYI: In 1c9e7ff1dd5ef866a1856e2fed74b9ca65080e9c I've also removed the analogous regexp from the email "cleanup" code a few lines below.


fix(CacheService): clean crashed flight🐛

I have done a small fix for your CacheService, please check it out.
The problem is when a key got added to inFlightObservables and it's corresponding fallback got thrown, any consequences request with same key will never got it's response.
You can see my demo for this problem at
https://stackblitz.com/edit/angular-simple-cache-service-with-rxjs-lqmx3k?file=app%2Fhackernews.service.ts

Thanks a lot @tronghiant !! Really appreciate it.


Find out IP of Dyson fan (TP04)

Hello everybody,
I was able to setup everything so far. The only thing I'm missing is my Dyson's IP address. My router tells me that for the Dyson 'no IP address is required'.
So, now a Dyson button is showing up in my HomeKit, but understandingly it doesn't do anything as I haven't specified any IP address.
Is there a way to find out my Dyson's IP?
Thanks in advance for pointing me in the right direction.
EDIT: I eventually found my IP address by using Wireshark. But I still have a non-functioning single Dyson button in HomeKit. So, something doesn't seem to be quite right yet. I attached you my config.json file.
Could somebody be so kind to take a look at it and figure out any obvious mistake?
Thank you. Your help is greatly appreciated. :)
I used Homebridge to set everything up. As an accessory type I picked 'NetworkDevice' but I'm not too sure whether that's correct.
{
"accessories" : [
{
"serialNumber" : "XXX-EU-XXXXXXXX",
"accessory" : "NetworkDevice",
"displayName" : "Dyson",
"ip" : "xxx.xxx.x.xxx",
"pingInterval" : "15",
"wakeGraceTime" : "20",
"name" : "Dyson",
"shutdownGraceTime" : "45"
},
{
"name" : "Pi Temp",
"accessory" : "RaspberryPiTemperature"
}
],
"bridge" : {
"username" : "XX:XX:XX:XX:XX:XX",
"name" : "Homebridge",
"pin" : "XXX-XX-XXX",
"port" : 51826
},
"platforms" : [
{
"email"<EMAIL_ADDRESS>"password" : "XXXXXXXXX",
"country" : "DE",
"name" : "DysonPlatform",
"platform" : "DysonPlatform"
}
]
}

Finally, I was able to get everything set up. Please find my working config.json file below. Maye it will help out somebody else. :)
{
"bridge" : {
"username" : "XX:XX:XX:XX:XX:XX",
"name" : "Homebridge",
"pin" : "XXX-XX-XXX",
"port" : 51826
},
"platforms" : [
{
"email"<EMAIL_ADDRESS>"password" : "passwprd",
"country" : "DE",
"name" : "DysonPlatform",
"accessories" : [
{
"serialNumber" : "XXX-EU-XXXXXXXX",
"displayName" : "Dyson",
"name" : "Dyson",
"ip" : "192.168.1.xxx"
}
],
"platform" : "DysonPlatform"
}
]
}


Publish java11 entry point to Maven Central

Expected Behaviour

The java11 template's entry point can be published to Maven Central as a pre-compiled jar, instead of compiling on each iteration. This will speed up local testing.
Current Behaviour

Built as part of the function project upon faas-cli build
Possible Solution

Introduce an abstract class for the function handler - https://github.com/openfaas/template-sdks/pull/2
Update the entry point to use ServiceLoader - TBD
Delete the entry point project from this project,. and move it to template-sdk
Publish the entrypoint project in template-sdk to Maven Central
Reference the template-sdk package from the Gradle build for the function

Fixed in https://github.com/openfaas/templates/pull/214


⚠ Bofrost.de has degraded performance

In be36562, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1336 ms

Resolved: Bofrost.de performance has improved in 0a14e4a after 6 minutes.


README.md example does not work

The following errors occur attempting to use the example code in the README.md:

Client error: Call to a member function write() on unknown.
Fatal error: Uncaught TypeError: Argument 1 passed to {closure}() must be an instance of Exception, instance of Error given in ...

Thanks for catching my typos. I've fallen behind on updating the examples because I'm preparing more complete docs that will be hosted on icicle.io. You can view them now at http://icicleio.github.io/docs and contribute at https://github.com/icicleio/docs.
The TypeError was being thrown because an Error was thrown from $client being undefined. Otherwise Exception is correct for PHP 5.x. It could be changed to Throwable for PHP 7. The docs will be split into v1.x for PHP 5.x and v2.x for PHP 7, so this should be less of a problem going forward.


fix possible index out of range error in origin detection

What does this PR do?
Fix a possible index out of range panic in Dogstatsd origin detection.
In some cases (process currently stopping?) gopsutil can return nil, nil, making us panic. Check the length of the returned slice before accessing items.

Force-merging: appveyor was green: https://ci.appveyor.com/project/Datadog/datadog-agent/build/master.9532


[CORE] Pub/Sub interfaces

Pub/sub implementation could vary quite a lot and depend on whether an application is running as one-only instance or multiple. If

one: then it is possible to broadcast events manually between worker threads.
multiple: then it requries some external broker (rabbitmq, cloud pub/sub, etc..).

Done with 75deb57233ff0391052bb8f0959ab85324d04864


[FEATURE] Allow for external database options

Description
Since removing redis as a datastore my company can no longer use hemmelig on on-demand web service providers like Google Cloud Run or AWS Fargate, as the local datastore wont be present on any dynamically spun up instances.
It would be nice to at least allow me to pass in a SQL instance URI to use as the datastore.
Screenshots
No response
Additional information
No response

Hi
That is a fair point. Looked into this earlier, but not any good approach for this using Prisma. I guess we can use a workaround like this: https://zach.codes/multiple-prisma-clients-one-app/


Upgrade to webdoc 1.2.1, remove bug workarounds

No need for explicit @protected tags on protected methods.
Fixed @method tag with PIXI.Graphics#drawMethod inferring it as static instead of instanced scoped.

In a follow-up, you can also strip out the explicit @type tag applied on interface properties.

Thanks @SukantPal


uninitialized constant Chef::Resource::IisSection

Cookbook version
6.2.0
Chef-client version
13.0.188
Platform Details
Windows 2008 R2
Scenario:
I am trying to execute this recipie:
include_recipe 'iis::mod_auth_windows'
Steps to Reproduce:
Just include 'iis::mod_auth_windows' in a cookbook
Expected Result:
Same behaviour as for chef-client 12
Actual Result:
NameError
uninitialized constant Chef::Resource::IisSection
Resource Declaration:
In C:/chef/cache/cookbooks/iis/recipes/mod_auth_windows.rb
33: iis_section 'unlocks windows authentication control in web.config' do
34:   section 'system.webServer/security/authentication/windowsAuthentication'
35:   action :unlock
36: end

@thpert this is because iis_section isn't updated to the latest custom resource

Hit the same issue... Is there a workaround? I've tried downgrading as low as version 5.0.5 with the same result. Maybe this is a Chef-Client 13 issue? Trying to upgrade from 12 to 13.

@nhudacin it is chef 13, this cookbook isn't fully functional on Chef 13.
This is in progress:
#335
#331
#327
#325
#322
Currrently i'm rewriting this resource to be Chef 13 compatible, but i also have to write the inspec testing library.  I imagine this will be done tonight...feel free to put in some PRs:
Both:
iis_root
iis_section
are still not complete but they are re-written here:
https://github.com/chef-cookbooks/iis/tree/enhancement-new_LWRP_style
This code isn't production ready and that is why we are re-writing and reviewing them one at a time with actual inspec tests

@EasyAsABC123: Any update on iis_section resource development?

@thpert i uploaded the current development branch https://github.com/chef-cookbooks/iis/tree/enhancement-section_custom_resource but haven't finished the inspec resource yet

@thpert latest update now is that the PR is open and being reviewed.  hopefully this can go in today so this bug can be resolved.  there are still 2 more resources that i need to update and write valid testing systems for so that bugs can be detected and resolved quickly in the future.

resolved in #347


Initialization from API with cURL

Hi,
I have to initialize the InfluxDB system from my other product deploy automatically.
For User Org Pass and Bucket creation i use cUrl request, which do the frontend:
curl 'http://IP:PORT/api/v2/setup'
-X POST -H 'Referer: http://IP:PORT/onboarding/1'
-H 'content-type: application/json'
-H 'Origin: http://IP:PORT'
-H 'Connection: keep-alive'
--data-raw '{"username":"","password":"","org":"","bucket":"*"}'
and get valid response with token, org and bucket info insilde:
{
.
.
auth: {
.
.
token: "**********************************************************************"
}
}|
but when i try to login in browser to the admin console with specified username and password,
page just refresh without any error message, so i can't login.
What i do wrong?
Is there some valid method to make initialisation with API?
Thank you

Ok, I found the point,
I think it's bug.
If install influxdb deb package, start systemd service and curl successful "setup" API method, it's OK.
In other way, if I after starting systemd unit send any other curl (for example "login") and then curl "setup", the last one finished success, but now I can't login from frontback.
I'm sorry for my english and minimum details, I haven't so many time. Thank you for help!


Segfault issues in latest commit

I don't know where the problem was introduced, but testing at 6aa9afa produces a lot of issues for me. Running some of the tests produces segfaults as in alignment.sil while others throw other errors like a "double free or corruption" dump from centering.sil or invalid UTF8 sequence errors from bug-124_upstream.sil or "realloc(): invalid next size" from bug-76.sil.

 I wonder if there is an ICU dependency version mismatch or something.

I think it's more likely there are bugs in my ICU code.

What would be useful for me to provide in the way of debug information?

Commit 1896a8f does indeed fix the issue for me.


QUIC Multi-Stream Multi-Thread (MSMT)

New commits on top of MSST:
5014f02b9a QUIC APL: Make SSL_get_error per-stream, error raising refactor
b1f760f05c QUIC MSMT TESTS: Add tests to exercise MAX_STREAMS
5dceb7c5c4 QUIC RXDP: Ensure all stream-related frames autocreate a stream
d00bd10318 QUIC FC: Correct operation of stream count mode
ea38c5fcd5 QUIC QSM: Correct the logic for determining stream count limits
9f0f6e2f30 QUIC QSM: Allow QSM to know if we are in the server role
51fddf2e2b QUIC MSMT: Stress tests, support for repeating test opoerations
0c2e71375e QUIC MSMT: Add a basic multithreading test
35410e9cd7 QUIC MSMT: Revise tests to support multithreading
df54063991 QUIC TSERVER: Allow detection of new incoming streams

Since the thread-assisted PR already resulted in adding locking everywhere, surprisingly little was needed to get MT working. This is mostly tests, though we do have to be careful with how we handle SSL_get_error.

Rebased now that MSST has merged.

Updated. Bug fixes to no-threads build. This adds no-threads CI builds since it turns out this was a massive gap in our CI coverage and uncovered several bugs.

Updated.

tsan's caught something. On it.

Updated.
TIL DJGPP defines functions lock and unlock. :raised_eyebrow:

This pull request is ready to merge

Merged to master. Thanks for the reviews!


Automated cherry pick of #2723: region: fix create params cdrom missing

Cherry pick of #2723 on release/2.11.
#2723: region: fix create params cdrom missing

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@c66e8cf). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.11   #2725   +/-   ##
==============================================
  Coverage                ?   7.22%
==============================================
  Files                   ?     470
  Lines                   ?   74368
  Branches                ?       0
==============================================
  Hits                    ?    5374
  Misses                  ?   68542
  Partials                ?     452

Flag
Coverage Δ

#aFlag
7.22% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/guests.go
0.67% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c66e8cf...35a6d13. Read the comment docs.


Does not work on multi root workspaces.

Thanks for the EXT. very handy.
That said, I believe it does not work on multi-root workspaces. (@see: VsCode Multi-root Workspaces )e.g.:

To which I tried all the possible combinations and the only way the EXT. does not complain is the following syntax:
my-project.code-workspace
{
  "folders": [
    {
      "path": "/rootA"
    },
    {
      "path": "/rootB"
    }
  ],
  "settings": {
    "cssvar.files": {
      "path": "${workspaceFolder}/.../styles/base/pollen/colors.scss"
    }
  }
}

This also works on your main user-settings.json to remove the notification error popup on vscode. But it still makes the EXT to provide no intellisense/autocompletions.
With that explained, I'll love to ask if I may:

Implement this capability if it is not currently supported as I assume.
IF` this works but it needs a special config/syntax, could you please document it?

Thank you.
Best,

Thanks, @Esteban-Rocha for opening this issue.
Support for Multi Root workspaces is broken as of now.
I need to revisit the code for a fix 👍🏾

Thanks for the heads-up @phoenisx 👍🏻

@phoenisx  Any updates on this really would love to use this with my monorepos?

Hi @Esteban-Rocha
Apologies for the delay, was a bit burned out from coding 😅
Anyways, I have started to work on this again and would love to push this change by 18th Jul. I wanted to know your use cases and how you use this plugin in a Multi Root project.
Please help me answer the following questions to add support for them:

Do you use this ext in a Mono Repo project, which uses VSCode Multi Root setup? If yes:

Do you have a global set of CSS variables that need to be used across every folder in the Multi Root Setup?
Do you have different CSS variables for each folder root?

The problem I am trying to solve here is, how to support Multi Root projects for CSS variables because every user can have a different way of setting up their projects.

Some may want to use locally available CSS variables per folder for each Root in Multi Root setup
Some may want to use a single set of CSS variables across the entire Multi Root project.

I don't want to make this project complicated and wanted to understand which kind of setup would fit most of the users?
Any ideas?

Or should I just populate all the CSS variables from each root into a single dropdown across folders, irrespective of which active root a dev is working on?
Just thinking out loud here 🤔
Would love to get more opinions here

Hi Folks!!
Multi Root Workspace support has been added to this extension. Apologies for the delay.
Please check Examples for reference.
Also, to keep things simple, each root folder is kept isolated, which means CSS variables present in one root folder won't be accessible in another root folder.
If you need IntelliSense support for CSS variables list from all root folders, please raise a separate ticket 🙇🏾

@phoenisx Hey, hope you're doing better, thanks a lot for this, I wasn't able to give you some feedback as I had been a bit busy. But I'll test it for sure, and I think it covers most scenarios.
Thanks again, take care.


srcOnly does not pass through

Issue description
The srcOnly utility function accepts additional attributes in its parameter set, but does nothing with them.
One might expect the below example to work, since the attribute sourceRoot is not accepted, but it does not. It fails with unpacker produced multiple directories.
pkgs.srcOnly {
  name = "tar-with-multiple-dirs";
  src = ./example.tar.gz;
  sourceRoot = ".";
}

It seems sensible that this function should either:

pass the attributes through to mkDerivation, or
not accept them in the first place, as it is confusing.

This is still an issue. The most correct fix would probably be to explicitly look for attributes related to the source (like sourceRoot) and add them to the derivation. This should be fairly quick so I should do this really 🙄


Pairs

I have my cost function:
C: qubovert.PUBO = x[0] * x[1] * x[2]
I am testing Qubovert to force pair 0, 2 rather than the default it does, which is 0, 1
so I call it as following:
Q: qubovert.utils._qubomatrix.QUBOMatrix = C.to_qubo(pairs=((0, 2),))
However, I still get the following answer:
6 x(3) + 2 x(0) x(1) - 4 x(0) x(3) - 4 x(1) x(3) + x(2) x(3)
I was expecting last part to be x(1) x(3).
Am I doing something wrong?  Full code follows:
import qubovert
from qubovert import boolean_var
from sympy import Symbol

x = [boolean_var("x%d" % i) for i in range(5)]
C: qubovert.PUBO = x[0] * x[1] * x[2]
lam = Symbol("lam", real=True, positive=True)
Q: qubovert.utils._qubomatrix.QUBOMatrix = C.to_qubo(pairs=((0, 2),))

print("num PUBO variables", C.num_binary_variables)
print("num QUBO variables", Q.num_binary_variables)
print(Q.pretty_str())

OK managed.  The correct format is:
Q: qubovert.utils._qubomatrix.QUBOMatrix = C.to_qubo(pairs={('x0', 'x2')})


Update Format Validator to support Title links

Supporting Commit to PR #728.
This moves the validation logic onto the Title segment rather than the (now-defunct) Link segment.

Looks good 👍

Covered in e2b66cea263d77107000855ce66fb3554922dd02


SetupAssist create Temp Directory

Describe The Request
For files that are created with ldifde.exe we should place them in a temp folder and delete at the end if no issues are present, to avoid any confusion.

Not going to create a temp directory, just going to clean up the files.


LightGBM 2.0.4 is "better" than all further versions

I am seeing lot of complaints about LightGBM 2.0.4 being better than any further versions of LightGBM.
Example: https://www.kaggle.com/c/porto-seguro-safe-driver-prediction/discussion/41165#237078

Also I have tried all version of lgb (from 2.04 to 2.0.10) and agree with man who declare that 2.0.4 is the best. This version give me best score (in the same testing conditions).

Is there any reason the 2.0.4 version is giving better results in most scenarii?
ping @guolinke

@Laurae2 I just check the code.
I think the main different is the missing value handle.
In v2.0.4, zeros and nan are both treated as missing values.


Always return a number from table.getn and table.getsize

The assembly-based functions made by @KionX two years ago were left unused because they were incompatible with the previously existing functions. The Lua implementations would always return a number, regardless of the input type. For non-table types, it would simply return 0.
This is crucial for backwards compatibility. We can't use the faster alternatives until they always return a number.

I don't understand what the problem is.
This function cannot be compatible with getn for performance reasons.
It is imported as getsize2 and empty2. Use them directly.

I was mistaken - I was referring to table.getsize and table.empty. We can't use the new functions across the code base if they do not have the same behavior. It needs to be backwards compatible.


Could not find InAppBrowser plugin

I've an issue with ng-cordova-oauth that throw an error every time I want to use one of the provider (I tried with facebook and linkedin). Looking at the code, I believe this line is wrong:
if (cordovaMetadata.hasOwnProperty("org.apache.cordova.inappbrowser") === true)

Not sure why this is happening but it looks like the correct slug should be cordova-plugin-inappbrowser now (output given by $> ionic plugin list).
Let me know if I can help :)

So for some reasons I had to install the plugin by doing:
cordova plugin add https://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser.git

instead of
cordova plugin add org.apache.cordova.inappbrowser

that was giving me an error (repo down?) ...
Issue can be closed since, the cordova plugin add org.apache.cordova.inappbrowser is working again =)

even if i install the inappbrowser pugin the other way i still get this exact error message.
the plugin lists with 'cordova plugin list' just fine but the ng0auth returns for every provider with a "Could not find InAppBrowser plugin"

Sounds like something is broken in the plugin repository.  You may want to open a ticket with Apache Cordova because both are suppose to point to the same place.
Regards,

It's not a Cordova fault:
Installing with cordova plugin add https://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser.git
Gives version 1.0.1-dev.
Installing with cordova plugin add org.apache.cordova.inappbrowser
or the new cordova plugin add cordova-plugin-inappbrowser
Gives version 1.0.0
ngCordova Oauth isn't able to find any of both.
Problem is on check plugin existence:
it checks for org.apache.cordova.inappbrowser while, right now, it's named cordova-plugin-inappbrowser
Changing those lines on ngcordova.js solves the issue.

+1
I've had to create a fork.

I'm aware of this, but I haven't had a chance to jump in and fix it.  This is only a side project of mine.  Should have time this weekend.

No problem, mate. :wink:

Don't worry... Just sayin' it because I'm a beginner on GitHub. :stuck_out_tongue_winking_eye: Thanks.

Latest version of InAppBrowser Plugin was causing issues for me also. Installing as @Takkuz suggested resolved my issues.

I pushed a fix to the master.

Thanks a bunch, @nraboy.

Hi all I have to do to run me I still get the error console InAppBrowser Could not find plugin

How are you installing the InAppBrowser plugin?

cordova plugin add https://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser.git

Does it work if you do this instead?:
cordova plugin add org.apache.cordova.inappbrowser

Thanks,

o.k I try to be like me going

hello, now displays an error when you press the button

I'm wondering if you're running to the problem people are reporting with the latest Apache Cordova release.  Some have reported that they are blocking remote hosts if you don't use their plugin.
Can you tell me if you get the same results when you copy the link from the simulator and paste it into your web browser?
Thanks,

Had the same issue, finally @nraboy s last suggested command worked :+1:
cordova plugin add org.apache.cordova.inappbrowser
thanks heaps for all.. :smile:

WARNING: org.apache.cordova.inappbrowser has been renamed to cordova-plugin-inappbrowser. You may not be getting the latest version! We suggest you cordova plugin rm org.apache.cordova.inappbrowser and cordova plugin add cordova-plugin-inappbrowser.
Waiting for ngCordova Update?

It seems<EMAIL_ADDRESS>already fixed it.

I have installed from bower
"name": "ngCordova",
"version": "0.1.17-alpha",
"homepage": "http://ngCordova.com/",

but it seems that the source code differs form ng-cordova release of v0.1.17-alpha
The release is behind 10 commits of master branch and it looks like the code that checks inappbrowser is installed has changed since then.
in the release of 0.1.17-alpha it is still
if (cordovaMetadata.hasOwnProperty("org.apache.cordova.inappbrowser") === true) {

instead of the line that checks for the new name of the plugin and also for the old one
if($cordovaOauthUtility.isInAppBrowserInstalled(cordovaMetadata) === true) {

Hey @manudefrutosvila,
I have no control over Ionic's versioning cycle since I have no affiliation with them.  I encourage you do one of three things:

Use ng-cordova-oauth
Use the master branch of ng-cordova
Ask Ionic to tag a new version on ng-cordova

Regards,

So I was trying this project out after going to your blog, https://github.com/nraboy/ng-cordova-facebook-example. The ng-cordova.min.js (0.1.20-alpha) included within the project threw a "Could not find InAppBrowser plugin" error. I updated to the latest https://github.com/driftyco/ng-cordova (v0.1.23-alpha) & it is still throwing an error.
throughout the ng-cordova.js
var cordovaMetadata.cordova.require("cordova/plugin_list").metadata;

is returning an empty object, so
 if(cordovaMetadata.hasOwnProperty("cordova-plugin-inappbrowser") === true)

is returning the error message 'InAppBrowser could not find plugin'.
cordovaMetadata.cordova.require("cordova/plugin_list")

contains the plugin in an array however. Is this an ng-cordova issue then?

@vgport is right on - I changed
                    var cordovaMetadata = cordova.require("cordova/plugin_list").metadata;
                    if(cordovaMetadata.hasOwnProperty("cordova-plugin-inappbrowser") === true) {

to
                    if(cordova.InAppBrowser) {

and I'm back up and running. The code I had was working and fine, but when I updated cordova last week it all went wonky. My cordova version is 5.4.0.
And thanks @nraboy for the project - Very useful.

This issue is being looked into.

Hi. @EdHubbell solution works here, but only on Android 6-.
On Marshmallow, browser opens but "webage not available"
https://cloud.githubusercontent.com/assets/4220068/7539122/52435222-f56a-11e4-8209-07c497475a32.png

however,  var cordovaMetadata = cordova.require("cordova/plugin_list").metadata;
cordovaMetaddata does not contains the inappbrowser, as a result, auth broke everytime.
Does anyone know why?
thanks

@matheusrocha89 and I are working on a fix.  This is an issue introduced in the latest version of Apache Cordova.  Earlier versions should not be suffering from this.
Regards,

thanks a lot!!!

@nraboy a, also running thru the same issue. Could not find inappbroswer plugin in IOS..am awaiting for your response on the fix...

@xunxdd , @cabbabu We are testing a new version with this fix to release. You will download this version soon.

thanks a lot, really appreciated!

Just FYI, the " if(cordova.InAppBrowser)" solution works for me on Cordova 5.4.0 and Android Lollipop 5.1.1.

Maybe everyone can clear something up for me because I honestly don't know the answer to this.
Must cordova.InAppBrowser be wrapped in an onDeviceReady or IonicPlatform.ready first?  My approach with the meta that worked in previous versions did not require plugins to be ready.  It just checked the meta to see if they were installed.
Requiring the plugin to be ready to check if it exists is probably not a good long term solution to this.  However, maybe cordova.InAppBrowser doesn't fall victim to this.
Thanks,

Hi @nraboy, from my tests cordova.InAppBrowser does need to be wrapped in IonicPlatform.ready first. Though I also found that cordova.require("cordova/plugin_list") needs to be wrapped in that as well (i.e., if I call it from outside I get an error).

Temporary solution : using old version of cordova
npm uninstall cordova -g
npm install -g<EMAIL_ADDRESS>

+1 @spartan1234 that works for me.

+1 to downgrading to cordova 5.3.3
$cordovaOauth.instagram begun working again
thx :)

+1 to downgrading to cordova 5.3.3

This should be corrected in staging version 0.2.0 found in https://github.com/nraboy/ng-cordova-oauth/issues/167.
I encourage you to test it out.


Async onEnter hook can lead to inconsistent state

Version
2.4.0
Test Case
http://codepen.io/hoschi/pen/wGbZWo?editors=0010
Steps to reproduce

click on "Users" link, shows still "Home"
click on "Widgets" link, shows Widgets component
wait

Expected Behavior

Widgets component stays visible
url is still "/widgets"

Actual Behavior

Users component shows up
url is still "/widgets", which doesn't match the component on the screen

Description
The example has an onEnter hook which calls the callback after two seconds. When you move away from the "Users" route to "Widgets" all works fine. After the delay finishes you get an inconsistent state, as described above.
I think the problem lies in async management of hooks, where waiting callbacks should be dismissed on a location change.

Should be fixed in #4063


Soft-delete cascades

It would be good to be able to setup soft delete cascades, either through the existing Prisma schema cascades or through a custom API.
Due to the nature of nested operations it probably won't be possible to produce single queries that do this, however some will be able to. In the cases where it is simply not possible to do with a single query a second operation and a transaction will probably be needed.
This was requested in the soft delete Prisma issue

Hey @olivierwilkinson
Please see my comment in the discussion you mentioned.
The logic there might be helpful for implementing cascading soft deletes.


fix bug: No confirmation is announced by the narrator after activating 'Remove equation' button #1386

Fixes #1386 .
Changing AutomationNotificationProcessing from MostRecent to ImportantMostRecent to prevent this confirmation messages being superseded by the incoming announcement requests.
Target issue: #1386
Description of the changes:

Uses ImportantMostRecent instead of MostRecent for function removing announcement.

How changes were validated:

Launch Calculator app.
Turn on the narrator.
Navigate Open navigation button and activate it.
Navigate to graphing calculator list item and activate it.
Navigate to Enter a expression edit box.
Enter any expression say "7+8".
Now open context menu and activate "Remove equation" button.
Check that the confirmation - 'Function Removed' - is announced by Narrator.

Hi @joseartrivera,
I've proposed an additional PR(#1469 ) to add some UT cases for NarratorAnnouncement.
Could you help take a look at it?
Many thanks!

Hi @joseartrivera,
I've proposed an additional PR(#1469 ) to add some UT cases for NarratorAnnouncement.
Could you help take a look at it?
Many thanks!


[WIP] ✨ Refactor Menu, Popover and Tooltip to use Popper (Old Spike PR)

Resolves #1112, resolves #673, resolves #952, resolves #984
Spiking react-popper, a lightweight placement hook for tooltips / popovers / menus / etc
So this PR started as a spike and evolved to become a giant change PR instead.. Sorry about that!
Popper was pretty straight forward and easy to use, and it's helping us by a lot by outsourcing all the placement calculations that gave us a lot of headaches! It's lightweight and I think it gives us a lot of value.
Some quick notes
Why not use CSS or naive JS tooltip:

Clipping in regard to viewport
No automatic flipping possible
Interactive HTML difficult to create without UX issues
No virtual positioning (mouse cursor, context menu)
Lack of extensibility
Scrolling containers (hard to ensure the tooltip stays with the reference while scrolling)
Often require tooltips outside of its original DOM
Often lack advanced configurability
Relatively large in size
Runtime performance issues

Why use Popper:

Popper solves all the problems listed above
Lightweight, ~7kB regular popper and ~3 kB library if we use popper-lite @popperjs/core/lib/popper-lite'
Used by Bootstrap, Foundation, Material UI
35M/monthly downloads
Used by 1.4m users on Github
Active Github community
React wrapper react-popper https://popper.js.org/react-popper/v2/
Type definitions

Some notes along the way:

Created a hook for reusability and less code
Popper automatically repositions popovers when users scroll the page, this is a neat feature!
Simplified our components by deprecating the old popover placement logic
State from inside the components are moved to outside control
Tooltips are now supported inside Table Cells!
The only extra prop we needed to add to our components was the anchor ref (MutableRefObject type)
Placement prop is optional in Popper, because Popper uses auto placement (calculates the placement best for the window), but it's added to give the users more options (i.e Menu didn't have this prop before)

Some roadblocks along the way:

Had to rewrite the components to fit Popper properly
Popper didn't support SVG arrows (Old logic used arrows from figma), so we had to make a HTML arrow instead (arrow placement calculations by Popper needed, Popper only supported HTML elements). These arrows aren't 100% identical to Figma design at the moment.
Arrow positioning is not 100% consistent in all the different placements (Tooltip, Popover)
Popover arrow had a drop-shadow filter to make the arrow more visible on a white background, it doesn't work as expected with Popper. Will need to find a way this shadow doesn't overlap the actual popover
Had to do a workaround by wrapping divs around disabled elements that doesn't trigger mouse events (Tooltip example)
Need to rewrite the tests to fit the refactoring

Breaking changes, need to inform users before release:

the deprecation of PopoverAnchor component
change in Tooltip, Menu and Popover that users need to add refs to their anchor elements, and to send it as anchorEl prop in the respective components
changed old placement values (in Tooltip and Popover) to fit Popper, users already using this prop will have to change the value
added forwardRef to the Cell consumer, was needed to forward refs to TableHeaderCell and TableDataCell correctly

Tests finally complete and successful ✅
Just a couple of things before this is ready for review:

check why eds-core-react build fails
Popover should use Paper instead of Card
maybe a few more tests on Tooltip

Build finally resolved ✅
@equinor/eds-dev You can look over the PR while I rewrite Popover to use Paper instead of Card..
Also let me know if you have any suggestions to add more tests. Tooltip tests are kind of scarce. Testing Popper positioning is tricky because it's not hardcoded anywhere (ref. old tests)

We can't review it when its still a draft @pomfrida :)

You can't or won't? @mimarz 😅

🤔  Working with Menu stories and was just thinking if we really need MenuProvider logic at the top of the component, or if we could move it. Would be really neat to utilize Storybook's dynamic control functionalities and expose the Menu props.. MenuProvider kind of ruins this possibility the way it's used at the moment.
Popover and Tooltip stories both have dynamic story where users can play around with the placement prop. We can add an example in Menu with hard coded examples of all the placement values but it's not as neat.

🤔 Working with Menu stories and was just thinking if we really need MenuProvider logic at the top of the component, or if we could move it. Would be really neat to utilize Storybook's dynamic control functionalities and expose the Menu props.. MenuProvider kind of ruins this possibility the way it's used at the moment.
Popover and Tooltip stories both have dynamic story where users can play around with the placement prop. We can add an example in Menu with hard coded examples of all the placement values but it's not as neat.

MenuProvider is just a provider for the context, and it shouldn't be in the way of dynamic control functionality, so not sure how its in the way?

Updated Menu story with an example with SingleSelect for users to play around with the new placement prop. This is just a temporary workaround because Storybook doesn't support controlled subcomponents. Look into issue https://github.com/equinor/design-system/issues/1149 at some time later to utilize this functionality.

Snippets from our testing earlier @pomfrida
hook
import { useEffect, MutableRefObject } from 'react'

export const useOutsideClick = (
  ref: MutableRefObject<HTMLElement>,
  callback: (e: MouseEvent) => void,
): void => {
  const handleClick = (e: MouseEvent) => {
    if (ref.current && !ref.current.contains(e.target as Node)) {
      callback(e)
    }
  }

  useEffect(() => {
    document.addEventListener('click', handleClick)

    return () => {
      document.removeEventListener('click', handleClick)
    }
  })
}

usage
useOutsideClick(popperRef, (e) => {
  if (open && onClose !== null && !anchorEl.contains(e.target as Node)) {
    onClose()
  }
})


src/mod.rs is weird and should probably be removed

https://github.com/ChainSafe/forest/blob/77d6b2b128d73900b0162e3f573ff8d63e6324b3/src/mod.rs#L4
Which isn't true - it's only referenced in the build script. It should move out of src.

@aatifsyed It is used in test_load_actor_bundles and I did plan to move some shared CAR concat util functions into it : )

https://github.com/ChainSafe/forest/blob/77d6b2b128d73900b0162e3f573ff8d63e6324b3/src/lib.rs#L53-L55
!

https://github.com/ChainSafe/forest/pull/3325


Add Ability to set delay for stage start and completion messages

What does your feature do?
It's the same as the Delay & Delay message feature, but for start and completion messages.
This allows you to set delays for start messages and completion messages of stages.
They shouldn't be required to be entered though.
start message delay: Delay in seconds after player enters the stage before start message is shown.
completion message delay: Delay in seconds after the player completes the stage before message is shown.
Having the message delay option for start and finish messages allows you to space out the messages from the objective completion messages, as well as allows you to space out the 'delay message' message and the start message from the next stage.
While denizen can provide this type of needs, it would be so much easier if quests came with that option. It's way quicker being able to select those delays in quests itself, rather than having to learn how to script using a whole other plugin. It saves a lot of time not just because it would be available from the quest menu, but it also saves a lot of time having to test the quests.
How would people use it?
It would allow the quest designer to space out the messages more, making it so the player won't be overwhelmed with long sentences when trying to read the story the quest provides.
Or just information in general, mainly the objective display together with the start messages should be able to be split up. The player should be able to read every bit of information at a good pace.

Problem is that the start and finish messages indicate just that - when a stage can be started or finished. Introducing a delay might ease the amount of text on-screen, but could potentially break the user experience.
For example, Jane is very proficient at quests. She flies through a 4-stage mining quest in 2 minutes, but the start/finish messages have delays of 3 minutes. Jane starts another quest, but is confused about why she's still getting messages from the other quest she just completed. We could decide to just not send her the messages if the quest/stage is already finished, but then Jane might miss out on important story elements.
I think the proper solution here is to just delay the stages themselves entirely, so that messages aren't shown until the stage is "ready" to get attempted.

If you believe delaying the whole stage would achieve the same thing, then that could work.
And it's true that the aspect could potentially break form the user experience, but everything in the quests plugin, or quests in general could. Depending on how the quests designer works with its tools.

Block breaking > If too many blocks quests get bland.
If stages are all the same > quests get bland and boring.
If quests are too difficult > players get bored.
Talk to npcs 100+ blocks away from each other 10 times > annoying.
etc.
And that's why it would be optional, and that's also something the quest designer would have to keep in mind.
With quests you're able to tell a story, and with story telling timing is of great importance. Immersion can depend on it, and jokes themselves often heavily depend on timing as well.
It's all part of the execution, and it's up to the designer to optimise it's potential.

Sure in some cases it could break the user experience depending on the execution.
But in many other places it would greatly enhance it.
I still think it would be a good feature to add, so please reconsider it.


Method for ending all calls

This should solve the problem of callKit not closing due to the following error:
Error Domain=com.apple.CallKit.error.requesttransaction Code=4 ( issue #3 )
As far as I know the error with code 4 means that no call matching the callUUID that user requested was found. And it's impossible to get this error if we just end all of them :)

Hi, @ianlin ! Could you, please, review this one?

Thanks!

@aarkalyk @ianlin this issue is still there.My uuid is constant but callkit is not always closing the view after calling the RNCallKit.endCall(uuid)


Android x86 build: linker fails (libuv_la-stream.o): relocation R_386_GOTOFF

Hello everyone.
I've been compiling libuv for the 4 android architectures (arm-v7a, arm64-v8a, x86 and x86_64), because i need this dependency to compile libwebsockets for Android. The latest libuv version compiles fine for ARM architectures but fails for x86 architectures with the following error:
<I have removed some unnecessary parts of the output, containing other libraries>

/Users/vitorfernandes/Library/Android/sdk/ndk/20.0.5594570/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang  --target=i686-none-linux-android24 --gcc-toolchain=/Users/vitorfernandes/Library/Android/sdk/ndk/20.0.5594570/toolchains/llvm/prebuilt/darwin-x86_64 --sysroot=/Users/vitorfernandes/Library/Android/sdk/ndk/20.0.5594570/toolchains/llvm/prebuilt/darwin-x86_64/sysroot -fPIC -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -fno-addrsig -Wa,--noexecstack -Wformat -Werror=format-security  -O0 -fno-limit-debug-info  -Wl,--exclude-libs,libgcc.a -Wl,--exclude-libs,libatomic.a -static-libstdc++ -Wl,--build-id -Wl,--warn-shared-textrel -Wl,--fatal-warnings -Wl,--no-undefined -Qunused-arguments -Wl,-z,noexecstack -shared -Wl,-soname ...... -llog -landroid -latomic -lm && :
/Users/vitorfernandes/Library/Android/sdk/ndk/20.0.5594570/toolchains/llvm/prebuilt/darwin-x86_64/lib/gcc/i686-linux-android/4.9.x/../../../../i686-linux-android/bin/ld: error: ...libwebsockets/x86/lib/libuv.a(libuv_la-stream.o): relocation R_386_GOTOFF against preemptible symbol uv_try_write_cb cannot be used when making a shared object
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

Libuv Version: v1.33.1 and probably others
Platform: Android x86 and Android x86_64
Android API version: 24 and below
Compiler: clang
Using a toolchain generated by NDK 18 to compile the library. Then the  linking to my project is done with NDK 20 I don't think this could be an issue. It works for arm and arm64.

However, I've tested compiling libuv version 1.9.1 and it worked, this error didn't show on the linking stage. Any clue what this might be? This is possibly a bug for the latest releases.
Thanks in advance.

1.9.1 is really really old. Many things have changed since... IIRC someone recently compiled it with NDK r19. Any chance you can try that?

1.9.1 is really really old. Many things have changed since... IIRC someone recently compiled it with NDK r19. Any chance you can try that?

I have tried compiling with Android NDK 20, but the same error shown. This is a linking failure, the library compiles fine for x86. But at the time of linking this error comes up. I will try to build it with NDK r19

Can you show the exact (and full) output of a clean build? Thanks.

Closing, no follow-up.


Ctrl-Tab doesn't switch between Editor files in macOS

Description of your problem
I cannot switch between editor files/tabs using Ctrl-Tab or Ctrl-Shift-Tab. Nothing happens at all. I don't think there's anything weird with my OS/keyboard settings, because I use the same shortcut in many other applications just fine.
Please provide any additional information below
Here are my shortcut settings:

Versions and main components

Spyder Version: 3.2.4
Python Version: Python 3.6.3 64bits, Qt 5.6.2,
Qt Version: Qt 5.6.2,
PyQt Version: PyQt5 5.6 on Darwin
Operating system: macOS Sierra 10.12.6

Dependencies
Please go to the menu entry Help > Optional Dependencies (or
Help > Dependencies), press the button Copy to clipboard
and paste the contents below:
IPython >=4.0    :  6.1.0 (OK)
cython >=0.21    :  0.26.1 (OK)
jedi >=0.9.0     :  0.10.2 (OK)
nbconvert >=4.0  :  5.3.1 (OK)
numpy >=1.7      :  1.13.3 (OK)
pandas >=0.13.1  :  0.20.3 (OK)
psutil >=0.3     :  5.4.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pyflakes >=0.6.0 :  1.6.0 (OK)
pygments >=2.0   :  2.2.0 (OK)
pylint >=0.25    :  1.7.4 (OK)
qtconsole >=4.2.0:  4.3.1 (OK)
rope >=0.9.4     :  0.10.5 (OK)
sphinx >=0.6.6   :  1.6.3 (OK)
sympy >=0.7.3    :  1.1.1 (OK)

Thanks for reporting. Are you able to reproduce this on another macOS machine?At the moment I don't have one immediately handy to test it on...

I have tried the shortcut on two macOS computers. I've also found a few more things, all identical on both machines, which are very confusing:

The default shortcut is Cmd-Tab. This is also the shortcut for "alt-tab" behavior in macOS. If I don't modify the shortcut in spyder, the OS shortcut is executed and nothing happens in spyder.

Setting the 'go to next file' shortcut to Ctrl-Tab does not work every time. I open the dialog box for changing the shortcut, press Ctrl-Tab, and perhaps 10% of the time it will register the shortcut. Otherwise nothing happens, the dialog box stays open as if I have pressed nothing yet. If I press Ctrl-Tab repeatedly, eventually it is registered properly. Sometimes, it registers the first time I press Ctrl-Tab, but more often after 5 - 15 presses, seemingly randomly.

If I set the 'go to next file' shortcut to something else, e.g. Cmd-Alt-Shift-N, then I do get a response from spyder, but I don't think it is the intended one. A bubble pops up with a list of tabs, and I can cycle through which tab is highlighted by pressing the shortcut again. However, I can't select the highlighted tab and switch to it. Any key I press (such as return) just gets typed into the editor like normal and the bubble stays up:

If I click in the Editor, the bubble goes away. But then if I press Cmd-Alt-Shift-N again, nothing happens. To bring up the bubble again, I must first focus a different window than the spyder main window, such as the spyder preferences window or a web browser.

Thanks for your response; really appreciate the detailed followup. It sounds like we have a few issues here:

Ctrl seems to be getting mapped to Cmd on macOS (as it generally should), which is conflicting with the system app switcher. Not entirely sure what can be done about this, but maybe with some improvements we're working on to the shortcuts mapper we can just assign an second, macOS appropriate shortcut as at least a workaround?
Using Ctrl-Tab (or maybe just Ctrl-something) as a manually mapped shortcut may be buggy on macOS...perhaps due to the specific behavior (right click, etc) of the Ctrl key there? I couldn't reproduce this on Windows either (as one would expect), so I can either find someone a colleague with macOS and Spyder to test this, or someone else on here can explore it more to try to isolate the issue.
• Using arbitrary shortcuts doesn't actually go to the file, just selects it in the switcher...I can't reproduce this either, so I'm not sure what's going on, and I can't immediately think of how it might be related to macOS. This will probably need to be tested as well, but I would think a lower priority than the others since its mostly relevant because of them.

@ccordoba12 Any thoughts? Have we seen this before (couldn't find anything too relevant in the issue tracker)? Do we have any current macOS users among us to explore this further?

Maybe it's related to https://github.com/spyder-ide/spyder/pull/5768

@jnsebgosselin Actually I considered that but as both the PR and the fix its referring to were specifically stated to be in master and not 3.x (described as a regression from the latter, in fact), I figured that couldn't have anything directly to do with it...

I felt Ctrl-Tab should be the standard for switching tab on macOS. Any update on this bug?

@louis925 Sorry this is a problem for you; we certainly want to resolve this if we can. Unfortunately, this is rather difficult for us to test and fix on our own, since none of the developers have ready access to Macs, and we're not 100% sure why this happens.
@jnsebgosselin You're the shortcut master; any way you're able to fix this as part of your work tracked in #7894 ?

I'll see what I can do, but no promise. Without a mean to test it, that is going to be tough to fix.

Let's assign this to @juanis2112 since she can easily test it.
@juanis2112, please look at what shortcut is used for this in VSCode/macOS and (if possible) use that one in Spyder too. If not, please mention here what conflict that shortcut has with our other ones to see what we could do about it.

You can also check Firefox, as I know it has a tab switcher. IIRC, its Option-Tab which shouldn't pose a conflict.

@juanis2112 ping me for testing when you have a PR :-)

It seems there is a bug on the Qt side that is causing this. The work around is to register the shortcuts as menu actions, and in that circumstance the shortcut does work.
However we would need to create a "hidden" menu, or figure a menu where adding these options makes sense and add them for MAC, so that the shortcut works.

The same issue appears to have returned in Spyder 5 :(

@ccordoba12 Can you or a developer with macOS repro this?


BIWI dataset has 536 vertices_npy and 532 wav?

After BIWI processed, found BIWI dataset has 536 vertices_npy and 532 wav. Is the number of BIWI dataset right? Thx.

I also encountered the data missing problem. But I think it is OK as you only need to make sure all the BIWI TestA and TestB train
/val/test data exist and complete.

The acutal BIWI dataset for train, val, test is 190, 32, 24.
Loaded data: Train-190, Val-24, Test-32
But in paper, the BIWI dataset for train, val, test is 192, 32, 24.

Yeap I just check it and it should be 190.


🐛 [cloud_firestore_odm] update functions doesn't include complex fields

I have modified the [movies model class] as below. The comments field is a nested list now.
(https://github.com/firebase/flutterfire/blob/master/packages/cloud_firestore_odm/cloud_firestore_odm/example/lib/movie.dart)
import 'package:cloud_firestore/cloud_firestore.dart';
import 'package:cloud_firestore_odm/cloud_firestore_odm.dart';
import 'package:json_annotation/json_annotation.dart';

part 'movie.g.dart';

@JsonSerializable()
class Movie {
  Movie({
    this.genre,
    required this.likes,
    required this.poster,
    required this.rated,
    required this.runtime,
    required this.title,
    required this.year,
    this.comments,
  }) {
    _$assertMovie(this);
  }

  final String poster;
  @Min(0)
  final int likes;
  final String title;
  @Min(0)
  final int year;
  final String runtime;
  final String rated;
  final List<String>? genre;
  final List<Comment>? comments;
}

@Collection<Movie>('firestore-example-app')
final moviesRef = MovieCollectionReference();

@JsonSerializable()
class Comment {
  Comment({
    required this.authorName,
    required this.message,
  });

  final String authorName;
  final String message;

  factory Comment.fromJson(Map<String, dynamic> json) =>
      _$CommentFromJson(json);

  Map<String, dynamic> toJson() => _$CommentToJson(this);
}

as you can see, the update function doesn't include the comments field
  Future<void> update({
    String poster,
    int likes,
    String title,
    int year,
    String runtime,
    String rated,
    List<String>? genre,
  });```

Thanks for the report. Using the code sample provided above, seeing the same behavior as reported.
/cc @rrousselGit

I have same issue. Any timeline when this issue might be fixed?

This isn't supported for now. We'll see what can be done. But the logic for serializing those complex objects is a bit advanced.
For now, you can do:
moviesRef.doc(...).reference.update({'comments': [...]});

This allows invoking update without the ODM.

Moved to: https://github.com/FirebaseExtended/firestoreodm-flutter/issues/27


Fix bug introduce in a recent change

Updating the status of the pool CR object was
incorrectly moved to after the object is "pushed"
to k8s

bors try


Correct link for Software License shield

Would you mind fixing the link in README.md too? :smile:


Add Parameter 6 for ramp/instant for setlevel cmds

SetLevel commands do not follow zwave delay/steps param. changing param 6 from 0(default) to 1 allows zwave dim commands to follow zwave delay/step configs. This PR is just for example, I could not get the 0/1 to actually send to the device. I've confirmed this working in "Tweaker" but creating PR for review.

Reminder original commit is just boiler plate and doesn't change the parameter for some reason. I'll eventually debug and figure it out, I just used tweaker to change the value. For more info on change see this
https://community.smartthings.com/t/ge-jasco-14294-smooth-dimming-to-a-specific-level/130049/3?u=patrickacollier

@patrickacollier I no longer use SmartThings (I switched to Home Assistant) so I have no way of testing or verifying.  If you get this figured out let me know and I can merge it.


Find in Mountain Array

Link of the question
https://leetcode.com/problems/find-in-mountain-array/

Coding platform

[ ] Hackerrank
[ ] HackerEarth
[ ] Codechef
[ ] Codeforces
[x] Leetcode
[ ] InterviewBit
[ ] AtCoder
[ ] 450 DSA Sheet

Programming language

[ ] C
[ ] C++
[x] Java
[ ] Python.

Kindly assign me this issue @avinash201199 under Hacktoberfest'21.

@2000shivam659
don't forget to add problem statement on the code file :)


[AM-195] User reports

AM-195

Add new admin/reports endpoint
Reports per user
CSV concatenate script

@davidJudge-SLNSW reckons it's OK, but we should follow up with some changes:

Remove duplicate headers from CSV
Filter by Institution
Hide debug info
Render progressive output to HTML?


[Resolve] async ResolvePolicy "RXWAIT" does not behave as expected

When returning an errored observable from a resolve factory the state transition never happens (state home.observable-that-throws). Furthermore, the items that are emitted after the first item don't seem to be passed on to the stream that is resolved (home.observable).
Plunker: http://plnkr.co/edit/x2mTrhH3RQuNV4fcXSrO?p=preview
Expected: http://plnkr.co/edit/MXMAAWLDD6jGUz99SDlG?p=preview

Moved to https://github.com/ui-router/ng2/issues/20