Crash on AMD graphics card on Windows

Describe the bug
Crash with abort when trying to use AMD graphics card in editor
Model is mistral-7b-instruct-v0.2.Q4_K_M.gguf
ggml_cuda_init: found 1 ROCm devices:
Device 0: AMD Radeon RX 6800 XT, compute capability 10.3, VMM: no
llm_load_tensors: ggml ctx size =    0.30 MiB
d3d12: upload buffer was full! Waited for COPY queue for 1.118 ms.
d3d12: upload buffer was full! Waited for COPY queue for 0.902 ms.
d3d12: upload buffer was full! Waited for COPY queue for 0.897 ms.
d3d12: upload buffer was full! Waited for COPY queue for 0.896 ms.
d3d12: upload buffer was full! Waited for COPY queue for 0.901 ms.
[Licensing::Client] Successfully resolved entitlement details
llm_load_tensors: offloading 32 repeating layers to GPU
llm_load_tensors: offloading non-repeating layers to GPU
llm_load_tensors: offloaded 33/33 layers to GPU
llm_load_tensors:      ROCm0 buffer size =  4095.05 MiB
llm_load_tensors:        CPU buffer size =    70.31 MiB
..............................................................................................
llama_new_context_with_model: n_ctx      = 4096
llama_new_context_with_model: n_batch    = 512
llama_new_context_with_model: n_ubatch   = 512
llama_new_context_with_model: flash_attn = 0
llama_new_context_with_model: freq_base  = 1000000.0
llama_new_context_with_model: freq_scale = 1
llama_kv_cache_init:      ROCm0 KV buffer size =   512.00 MiB
llama_new_context_with_model: KV self size  =  512.00 MiB, K (f16):  256.00 MiB, V (f16):  256.00 MiB
llama_new_context_with_model:  ROCm_Host  output buffer size =     0.24 MiB
llama_new_context_with_model:      ROCm0 compute buffer size =   296.00 MiB
llama_new_context_with_model:  ROCm_Host compute buffer size =    16.01 MiB
llama_new_context_with_model: graph nodes  = 1030
llama_new_context_with_model: graph splits = 2
[1722650470] warming up the model with an empty run
ggml_cuda_compute_forward: RMS_NORM failed
CUDA error: invalid device function
current device: 0, in function ggml_cuda_compute_forward at D:/a/LlamaLib/LlamaLib/llama.cpp/ggml-cuda.cu:13061
err
Asset Pipeline Refresh (id=5fe1348313ec9e4439edb8aa2e9d608c): Total: 0.010 seconds - Initiated by RefreshV2(NoUpdateAssetOptions)
Asset Pipeline Refresh (id=a398558039bd1ba4a8f2fc04f6154810): Total: 0.007 seconds - Initiated by RefreshV2(NoUpdateAssetOptions)
Steps to reproduce
No response
LLMUnity version
2.0.3
Operating System
Windows

It seems to be an open llama.cpp issue (issue 1, issue 2)

@tempstudio could you check if the issue remains with the latest release (v2.2.0)?

I see the same issue with 2.2.1
`
(Filename<EMAIL_ADDRESS>Line: 137)
INFO [                    init] build info | tid="27560" timestamp=1725497899 build=3623 commit="436787f1"
INFO [                    init] system info | tid="27560" timestamp=1725497899 n_threads=12 n_threads_batch=-1 total_threads=24 system_info="AVX = 1 | AVX_VNNI = 0 | AVX2 = 1 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | AVX512_BF16 = 0 | FMA = 1 | NEON = 0 | SVE = 0 | ARM_FMA = 0 | F16C = 1 | FP16_VA = 0 | WASM_SIMD = 0 | BLAS = 1 | SSE3 = 1 | SSSE3 = 1 | VSX = 0 | MATMUL_INT8 = 0 | LLAMAFILE = 1 | "
llama_model_loader: loaded meta data with 24 key-value pairs and 291 tensors from E:/Project9/MusclePose/Assets/StreamingAssets/mistral-7b-instruct-v0.2.Q4_K_M.gguf (version GGUF V3 (latest))
llama_model_loader: Dumping metadata keys/values. Note: KV overrides do not apply in this output.
llama_model_loader: - kv   0:                       general.architecture str              = llama
llama_model_loader: - kv   1:                               general.name str              = mistralai_mistral-7b-instruct-v0.2
llama_model_loader: - kv   2:                       llama.context_length u32              = 32768
llama_model_loader: - kv   3:                     llama.embedding_length u32              = 4096
llama_model_loader: - kv   4:                          llama.block_count u32              = 32
llama_model_loader: - kv   5:                  llama.feed_forward_length u32              = 14336
llama_model_loader: - kv   6:                 llama.rope.dimension_count u32              = 128
llama_model_loader: - kv   7:                 llama.attention.head_count u32              = 32
llama_model_loader: - kv   8:              llama.attention.head_count_kv u32              = 8
llama_model_loader: - kv   9:     llama.attention.layer_norm_rms_epsilon f32              = 0.000010
llama_model_loader: - kv  10:                       llama.rope.freq_base f32              = 1000000.000000
llama_model_loader: - kv  11:                          general.file_type u32              = 15
llama_model_loader: - kv  12:                       tokenizer.ggml.model str              = llama
Loaded scene 'Temp/__Backupscenes/0.backup'
Deserialize:            5.726 ms
Integration:            341.064 ms
Integration of assets:  0.002 ms
Thread Wait Time:       0.004 ms
Total Operation Time:   346.796 ms
llama_model_loader: - kv  13:                      tokenizer.ggml.tokens arr[str,32000]   = ["", "", "", "<0x00>", "<...
llama_model_loader: - kv  14:                      tokenizer.ggml.scores arr[f32,32000]   = [0.000000, 0.000000, 0.000000, 0.0000...
llama_model_loader: - kv  15:                  tokenizer.ggml.token_type arr[i32,32000]   = [2, 3, 3, 6, 6, 6, 6, 6, 6, 6, 6, 6, ...
llama_model_loader: - kv  16:                tokenizer.ggml.bos_token_id u32              = 1
llama_model_loader: - kv  17:                tokenizer.ggml.eos_token_id u32              = 2
llama_model_loader: - kv  18:            tokenizer.ggml.unknown_token_id u32              = 0
llama_model_loader: - kv  19:            tokenizer.ggml.padding_token_id u32              = 0
llama_model_loader: - kv  20:               tokenizer.ggml.add_bos_token bool             = true
llama_model_loader: - kv  21:               tokenizer.ggml.add_eos_token bool             = false
llama_model_loader: - kv  22:                    tokenizer.chat_template str              = {{ bos_token }}{% for message in mess...
llama_model_loader: - kv  23:               general.quantization_version u32              = 2
llama_model_loader: - type  f32:   65 tensors
llama_model_loader: - type q4_K:  193 tensors
llama_model_loader: - type q6_K:   33 tensors
llm_load_vocab: special tokens cache size = 3
INFO [                    init] build info | tid="27560" timestamp=1725497899 build=3623 commit="436787f1"
INFO [                    init] system info | tid="27560" timestamp=1725497899 n_threads=12 n_threads_batch=-1 total_threads=24 system_info="AVX = 1 | AVX_VNNI = 0 | AVX2 = 1 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | AVX512_BF16 = 0 | FMA = 1 | NEON = 0 | SVE = 0 | ARM_FMA = 0 | F16C = 1 | FP16_VA = 0 | WASM_SIMD = 0 | BLAS = 1 | SSE3 = 1 | SSSE3 = 1 | VSX = 0 | MATMUL_INT8 = 0 | LLAMAFILE = 1 | "
UnityEngine.StackTraceUtility:ExtractStackTrace ()
UnityEngine.DebugLogHandler:LogFormat (UnityEngine.LogType,UnityEngine.Object,string,object[])
UnityEngine.Logger:Log (UnityEngine.LogType,object)
UnityEngine.Debug:LogWarning (object)
LLMUnity.LLMUnitySetup:LogWarning (string) (at ./Library/PackageCache/ai.undream.llm@d3d5d7fd31/Runtime/LLMUnitySetup.cs:143)
LLMUnity.StreamWrapper:Update () (at ./Library/PackageCache/ai.undream.llm@d3d5d7fd31/Runtime/LLMLib.cs:66)
LLMUnity.LLM:Update () (at ./Library/PackageCache/ai.undream.llm@d3d5d7fd31/Runtime/LLM.cs:483)
(Filename<EMAIL_ADDRESS>Line: 143)
llm_load_vocab: token to piece cache size = 0.1637 MB
llm_load_print_meta: format           = GGUF V3 (latest)
llm_load_print_meta: arch             = llama
llm_load_print_meta: vocab type       = SPM
llm_load_print_meta: n_vocab          = 32000
llm_load_print_meta: n_merges         = 0
llm_load_print_meta: vocab_only       = 0
llm_load_print_meta: n_ctx_train      = 32768
llm_load_print_meta: n_embd           = 4096
llm_load_print_meta: n_layer          = 32
llm_load_print_meta: n_head           = 32
llm_load_print_meta: n_head_kv        = 8
llm_load_print_meta: n_rot            = 128
llm_load_print_meta: n_swa            = 0
llm_load_print_meta: n_embd_head_k    = 128
llm_load_print_meta: n_embd_head_v    = 128
llm_load_print_meta: n_gqa            = 4
llm_load_print_meta: n_embd_k_gqa     = 1024
llm_load_print_meta: n_embd_v_gqa     = 1024
llm_load_print_meta: f_norm_eps       = 0.0e+00
llm_load_print_meta: f_norm_rms_eps   = 1.0e-05
llm_load_print_meta: f_clamp_kqv      = 0.0e+00
llm_load_print_meta: f_max_alibi_bias = 0.0e+00
llm_load_print_meta: f_logit_scale    = 0.0e+00
llm_load_print_meta: n_ff             = 14336
llm_load_print_meta: n_expert         = 0
llm_load_print_meta: n_expert_used    = 0
llm_load_print_meta: causal attn      = 1
llm_load_print_meta: pooling type     = 0
llm_load_print_meta: rope type        = 0
llm_load_print_meta: rope scaling     = linear
llm_load_print_meta: freq_base_train  = 1000000.0
llm_load_print_meta: freq_scale_train = 1
llm_load_print_meta: n_ctx_orig_yarn  = 32768
llm_load_print_meta: rope_finetuned   = unknown
llm_load_print_meta: ssm_d_conv       = 0
llm_load_print_meta: ssm_d_inner      = 0
llm_load_print_meta: ssm_d_state      = 0
llm_load_print_meta: ssm_dt_rank      = 0
llm_load_print_meta: ssm_dt_b_c_rms   = 0
llm_load_print_meta: model type       = 7B
llm_load_print_meta: model ftype      = Q4_K - Medium
llm_load_print_meta: model params     = 7.24 B
llm_load_print_meta: model size       = 4.07 GiB (4.83 BPW)
llm_load_print_meta: general.name     = mistralai_mistral-7b-instruct-v0.2
llm_load_print_meta: BOS token        = 1 ''
llm_load_print_meta: EOS token        = 2 ''
llm_load_print_meta: UNK token        = 0 ''
llm_load_print_meta: PAD token        = 0 ''
llm_load_print_meta: LF token         = 13 '<0x0A>'
llm_load_print_meta: max token length = 48
ggml_cuda_init: GGML_CUDA_FORCE_MMQ:    no
ggml_cuda_init: GGML_CUDA_FORCE_CUBLAS: no
ggml_cuda_init: found 1 ROCm devices:
Device 0: AMD Radeon RX 6800 XT, compute capability 10.3, VMM: no
llm_load_tensors: ggml ctx size =    0.27 MiB
d3d12: upload buffer was full! Waited for COPY queue for 1.133 ms.
d3d12: upload buffer was full! Waited for COPY queue for 0.901 ms.
d3d12: upload buffer was full! Waited for COPY queue for 0.895 ms.
d3d12: upload buffer was full! Waited for COPY queue for 0.905 ms.
d3d12: upload buffer was full! Waited for COPY queue for 0.899 ms.
llm_load_tensors: offloading 32 repeating layers to GPU
llm_load_tensors: offloading non-repeating layers to GPU
llm_load_tensors: offloaded 33/33 layers to GPU
llm_load_tensors:      ROCm0 buffer size =  4095.05 MiB
llm_load_tensors:        CPU buffer size =    70.31 MiB
...........[Licensing::Client] Successfully resolved entitlement details
...................................................................................
llama_new_context_with_model: n_ctx      = 4096
llama_new_context_with_model: n_batch    = 512
llama_new_context_with_model: n_ubatch   = 512
llama_new_context_with_model: flash_attn = 0
llama_new_context_with_model: freq_base  = 1000000.0
llama_new_context_with_model: freq_scale = 1
llama_kv_cache_init:      ROCm0 KV buffer size =   512.00 MiB
llama_new_context_with_model: KV self size  =  512.00 MiB, K (f16):  256.00 MiB, V (f16):  256.00 MiB
llama_new_context_with_model:  ROCm_Host  output buffer size =     0.24 MiB
llama_new_context_with_model:      ROCm0 compute buffer size =   296.00 MiB
llama_new_context_with_model:  ROCm_Host compute buffer size =    16.01 MiB
llama_new_context_with_model: graph nodes  = 1030
llama_new_context_with_model: graph splits = 2
ggml_cuda_compute_forward: RMS_NORM failed
CUDA error: invalid device function
current device: 0, in function ggml_cuda_compute_forward at D:/a/LlamaLib/LlamaLib/llama.cpp/ggml/src/ggml-cuda.cu:16369
err
D:/a/LlamaLib/LlamaLib/llama.cpp/ggml/src/ggml-cuda.cu:14155: CUDA error
Asset Pipeline Refresh (id=2eaefcb7421ebc541b64109c390c5c15): Total: 0.008 seconds - Initiated by RefreshV2(NoUpdateAssetOptions)
`

Thank you for testing!
I can't implement support for this card because it is down to llama.cpp.
I'll see if I can wrap around the error however so that Unity doesn't crash and you can use the GPU with Vulkan.
I'll send you later a build to try 🙏

Could you try the new build by changing the LlamaLib version here from v1.1.10 to v1.1.10-dev?
You will also need to delete the undreamai-v1.1.10-llamacpp folder from Assets/StreamingAssets.
With this build it should skip the HIP build and use the Vulkan instead 🤞

Apologies:
I was using the wrong binaries yesterday. I deleted the "StreamingAssets" directory and tried it again.
It didn't crash this time, after I deleted things from StreamingAssets and reinstalled the package. but I'm pretty sure it's using the CPU, with very slow speed, high CPU usage.
Server command: -m "C:/Users/.../AppData/Roaming/LLMUnity/models/Meta-Llama-3.1-8B-Instruct-Q4_K_M.gguf" -c 4096 -b 512 --log-disable -np 1 -ngl -1
UnityEngine.StackTraceUtility:ExtractStackTrace ()
UnityEngine.DebugLogHandler:LogFormat (UnityEngine.LogType,UnityEngine.Object,string,object[])
UnityEngine.Logger:Log (UnityEngine.LogType,object)
UnityEngine.Debug:Log (object)
LLMUnity.LLMUnitySetup:Log (string) (at ./Library/PackageCache/ai.undream.llm@d3d5d7fd31/Runtime/LLMUnitySetup.cs:137)
LLMUnity.LLM:StartLLMServer (string) (at ./Library/PackageCache/ai.undream.llm@d3d5d7fd31/Runtime/LLM.cs:373)
LLMUnity.LLM/<>c__DisplayClass45_0:b__0 () (at ./Library/PackageCache/ai.undream.llm@d3d5d7fd31/Runtime/LLM.cs:119)
System.Threading.Tasks.Task:InnerInvoke ()
System.Threading.Tasks.Task:Execute ()
System.Threading.Tasks.Task:ExecutionContextCallback (object)
System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.Tasks.Task:ExecuteWithThreadLocal (System.Threading.Tasks.Task&)
System.Threading.Tasks.Task:ExecuteEntry (bool)
System.Threading.Tasks.Task:System.Threading.IThreadPoolWorkItem.ExecuteWorkItem ()
System.Threading.ThreadPoolWorkQueue:Dispatch ()
System.Threading._ThreadPoolWaitCallback:PerformWaitCallback ()
(Filename<EMAIL_ADDRESS>Line: 137)
warning: not compiled with GPU offload support, --gpu-layers option will be ignored
warning: see main README.md for information on enabling GPU BLAS support
...
llm_load_tensors:        CPU buffer size =  4685.30 MiB
........................................................................................
llama_new_context_with_model: n_ctx      = 4096
llama_new_context_with_model: n_batch    = 512
llama_new_context_with_model: n_ubatch   = 512
llama_new_context_with_model: flash_attn = 0
llama_new_context_with_model: freq_base  = 500000.0
llama_new_context_with_model: freq_scale = 1
llama_kv_cache_init:        CPU KV buffer size =   512.00 MiB
llama_new_context_with_model: KV self size  =  512.00 MiB, K (f16):  256.00 MiB, V (f16):  256.00 MiB
llama_new_context_with_model:        CPU  output buffer size =     0.98 MiB
llama_new_context_with_model:        CPU compute buffer size =   296.01 MiB
llama_new_context_with_model: graph nodes  = 1030
llama_new_context_with_model: graph splits = 1
Giving the 1.1.0-dev a try now

The behavior is the same with 1.1.0-dev.

You are using num GPU layers -1 which will not use the GPU. Could you try e.g. with 10?
There should be debug messages that start with "Tried architecture", can you post those as well?

I thought -1 would mean all / max?
With 9999 GPU Layers it crashed with the same error even on 1.1.10-dev :/
I think it's been the same issue.
ggml_cuda_init: GGML_CUDA_FORCE_MMQ:    no
ggml_cuda_init: GGML_CUDA_FORCE_CUBLAS: no
ggml_cuda_init: found 1 ROCm devices:
Device 0: AMD Radeon RX 6800 XT, compute capability 10.3, VMM: no
llm_load_tensors: ggml ctx size =    0.27 MiB
llm_load_tensors: offloading 32 repeating layers to GPU
llm_load_tensors: offloading non-repeating layers to GPU
llm_load_tensors: offloaded 33/33 layers to GPU
llm_load_tensors:      ROCm0 buffer size =  4403.50 MiB
llm_load_tensors:        CPU buffer size =   281.81 MiB
........................................Asset Pipeline Refresh (id=2020b226d14d319468ddb810101aa4ca): Total: 0.008 seconds - Initiated by RefreshV2(NoUpdateAssetOptions)
...............................................
llama_new_context_with_model: n_ctx      = 4096
llama_new_context_with_model: n_batch    = 512
llama_new_context_with_model: n_ubatch   = 512
llama_new_context_with_model: flash_attn = 1
llama_new_context_with_model: freq_base  = 500000.0
llama_new_context_with_model: freq_scale = 1
llama_kv_cache_init:      ROCm0 KV buffer size =   512.00 MiB
llama_new_context_with_model: KV self size  =  512.00 MiB, K (f16):  256.00 MiB, V (f16):  256.00 MiB
llama_new_context_with_model:  ROCm_Host  output buffer size =     0.98 MiB
llama_new_context_with_model:      ROCm0 compute buffer size =   258.50 MiB
llama_new_context_with_model:  ROCm_Host compute buffer size =    16.01 MiB
llama_new_context_with_model: graph nodes  = 903
llama_new_context_with_model: graph splits = 2
ggml_cuda_compute_forward: RMS_NORM failed
CUDA error: invalid device function
current device: 0, in function ggml_cuda_compute_forward at D:/a/LlamaLib/LlamaLib/llama.cpp/ggml/src/ggml-cuda.cu:16369
err
D:/a/LlamaLib/LlamaLib/llama.cpp/ggml/src/ggml-cuda.cu:14155: CUDA error
Asset Pipeline Refresh (id=7f5d46cd6ec704f4ba373546e19f8732): Total: 0.006 seconds - Initiated by RefreshV2(NoUpdateAssetOptions)

Tried it with flash attention OFF and it's the same:
ggml_cuda_init: found 1 ROCm devices:
Device 0: AMD Radeon RX 6800 XT, compute capability 10.3, VMM: no
llm_load_tensors: ggml ctx size =    0.27 MiB
llm_load_tensors: offloading 32 repeating layers to GPU
llm_load_tensors: offloading non-repeating layers to GPU
llm_load_tensors: offloaded 33/33 layers to GPU
llm_load_tensors:      ROCm0 buffer size =  4403.50 MiB
llm_load_tensors:        CPU buffer size =   281.81 MiB
.......................................................................................
llama_new_context_with_model: n_ctx      = 4096
llama_new_context_with_model: n_batch    = 512
llama_new_context_with_model: n_ubatch   = 512
llama_new_context_with_model: flash_attn = 0
llama_new_context_with_model: freq_base  = 500000.0
llama_new_context_with_model: freq_scale = 1
llama_kv_cache_init:      ROCm0 KV buffer size =   512.00 MiB
llama_new_context_with_model: KV self size  =  512.00 MiB, K (f16):  256.00 MiB, V (f16):  256.00 MiB
llama_new_context_with_model:  ROCm_Host  output buffer size =     0.98 MiB
llama_new_context_with_model:      ROCm0 compute buffer size =   296.00 MiB
llama_new_context_with_model:  ROCm_Host compute buffer size =    16.01 MiB
llama_new_context_with_model: graph nodes  = 1030
llama_new_context_with_model: graph splits = 2
ggml_cuda_compute_forward: RMS_NORM failed
CUDA error: invalid device function
current device: 0, in function ggml_cuda_compute_forward at D:/a/LlamaLib/LlamaLib/llama.cpp/ggml/src/ggml-cuda.cu:16369
err
D:/a/LlamaLib/LlamaLib/llama.cpp/ggml/src/ggml-cuda.cu:14155: CUDA error
Unable to find style 'TemplatesPromo' in skin 'DarkSkin' Layout

Thanks a lot!
Could you do one more test with v1.1.10-dev2?

Couple problems I encounted with 1.1.0-dev2:
First, the install didn't work, it just installed an empty folder. I manually downloaded the entire zip and unzipped into the streaming assets folder.
After that, the same error happens.
Third, I deleted the two "windows-cuda" folders from the directory. It crashed again.
Finally, I deleted the "windows-hip" folder from the directory, it doesn't crash anymore, but it doesn't use the GPU. It seems it's not even going to try Vulkan.

Thanks a lot.
I have fixed the issue with the empty folder in v2.2.2.
It seems I can't do much at the moment for the specific GPU unfortunately.
I'll keep an eye on the llama.cpp updates and let you know once I find a solution.

I'm going through some issues and I have an idea.
I may have to specify your GPU architecture in the HIP build.

Could you try the v1.1.11 build?
I have specifically set AMD architectures included the one of your GPU (gfx1030).

The good news is that it doesn't crash anymore.
The bad news is that the performance is much worse than CPU only. running the chat pegs GPU usage to 100% and it stutters. It also took extremely long to generate anything.
I recall having with llamafile and it was running at least 20x faster than this (this is with only 1 layer on the GPU; using all layers makes the OS unresponsive):
INFO [           print_timings] prompt eval time     =  192189.92 ms /   399 tokens (  481.68 ms per token,     2.08 tokens per second) | tid="5292" timestamp=1725926634 id_slot=0 id_task=1 t_prompt_processing=192189.92 n_prompt_tokens_processed=399 t_token=481.67899749373436 n_tokens_second=2.0760714193543555
INFO [           print_timings] generation eval time =   24258.31 ms /    41 runs   (  591.67 ms per token,     1.69 tokens per second) | tid="5292" timestamp=1725926634 id_slot=0 id_task=1 t_token_generation=24258.305 n_decoded=41 t_token=591.6659756097561 n_tokens_second=1.6901428191293661
INFO [           print_timings]           total time =  216448.23 ms | tid="5292" timestamp=1725926634 id_slot=0 id_task=1 t_prompt_processing=192189.92 t_token_generation=24258.305 t_total=216448.225
INFO [            update_slots] slot released | tid="5292" timestamp=1725926634 id_slot=0 id_task=1 n_ctx=2048 n_past=439 n_system_tokens=0 n_cache_tokens=439 truncated=false
INFO [            update_slots] all slots are idle | tid="5292" timestamp=1725926634
INFO [            update_slots] all slots are idle | tid="5292" timestamp=1725926634
I have updated to the latest drivers and also just restarted my system.

Yes! That works!
What happens if you use more layers but not extreme ones e.g. 10, 25, 50?

Performance is equally bad with 10/30 layers.
10 layers:
prompt processing 2tk/s generation 1tk/s
30 layers:
prompt processing 2tk/s generation 0.5tk/s

Is there any possibility of the performance issue being fixed in llamalib?
If not, is it possible to provide a 2.x build that uses llamafile as a backend?

I really doubt it is a problem of LlamaLib because I use and extend code directly from llama.cpp and llamafile.
This is an overview of the different libraries:

llama.cpp
it is the main implementation that all libraries use.
Specifically for GPU it uses CUDA (Nvidia) and CUDA+HIP (AMD).
This is the fastest but including CUDA in the builds increases the build size to 1GB / build.
To support most Nvidia GPUs I include both CUDA 11 and 12 builds that would mean 2 GBs.
llamafile
It packages and serves llama.cpp in just a single file for all OSes.
Specifically for GPUs, it uses CUDA (Nvidia) and CUDA+HIP (AMD) if the system has them already installed (rare, unless you are into AI).
Otherwise it uses its own tinyBLAS implementation which has speed lower or equal to CUDA (from version 0.7 onwards).
The benefit is that it needs less than 100MB to include in the build.
LlamaLib
It extends llama.cpp with functionality needed to use as a Unity / C# library and builds binaries for the different architectures.
I use the llama.cpp implementation but specifically for GPUs I hack it and use tinyBLAS to keep the build size small.

The source of the speed issue is most probably on the tinyBLAS implementation of llamafile.
If you have CUDA installed or use llamafile with a version earlier than 0.7, llamafile will still use CUDA which will give you the speed boost.

There are reasons why I don't use llamafile anymore, although I love the project:

it has antivirus issues (false positives). This is because it builds llama.cpp on the fly directly on the system that uses it.
I actually whitelisted it myself for McAfee antivirus.
it can only be included as a server, not as DLL.
This can only be used in IL2CPP builds.
Also someone could create a similar server locally and take over your game.
I have spent a lot of time for workarounds to try and prevent that.
It can't be used for mobile deployment (Android / iOS).

For these reasons I can't bring it back to the project.
The issue that you have could be resolved if I include full CUDA builds for an extra 2 GBs as an option.

I will give those a try. Can you build llamalib into a command line standalone so that I can test that too, just in case there's something wonky going on with gpu resource sharing between the ai and unity?

Here is the performance with tinyBLAS. I don't believe the CUDA run is needed as I'm using an AMD system and it doesn't support CUDA. I will be very happy if I can get this type of performance inside Unity.
.\llamafile-0.8.13.exe -m .\Meta-Llama-3.1-8B-Instruct-Q4_K_M.gguf -ngl 99 -p "to be or" --nocompile --tinyblas -c 2048
llama_print_timings:        load time =    2364.86 ms
llama_print_timings:      sample time =      55.42 ms /   773 runs   (    0.07 ms per token, 13948.79 tokens per second)
llama_print_timings: prompt eval time =      36.01 ms /     4 tokens (    9.00 ms per token,   111.08 tokens per second)
llama_print_timings:        eval time =   22152.88 ms /   772 runs   (   28.70 ms per token,    34.85 tokens per second)
llama_print_timings:       total time =   22420.02 ms /   776 tokens
Log end
More logs that might be helpful:
import_cuda_impl: initializing gpu module...
get_rocm_bin_path: note: amdclang++.exe not found on $PATH
get_rocm_bin_path: note: /D/Drivers/ROCM/5.7//bin/amdclang++.exe does not exist
get_rocm_bin_path: note: clang++.exe not found on $PATH
link_cuda_dso: note: dynamically linking /C/Users/Tony/.llamafile/v/0.8.13/ggml-rocm.dll
ggml_cuda_link: welcome to ROCm SDK with tinyBLAS
link_cuda_dso: GPU support loaded
llm_load_print_meta: model size       = 4.58 GiB (4.89 BPW)
llm_load_print_meta: general.name     = Meta Llama 3.1 8B Instruct
llm_load_print_meta: BOS token        = 128000 '<|begin_of_text|>'
llm_load_print_meta: EOS token        = 128009 '<|eot_id|>'
llm_load_print_meta: LF token         = 128 'Ä'
llm_load_print_meta: EOT token        = 128009 '<|eot_id|>'
llm_load_print_meta: max token length = 256
...
ggml_cuda_init: GGML_CUDA_FORCE_MMQ:    yes
ggml_cuda_init: GGML_CUDA_FORCE_CUBLAS: no
ggml_cuda_init: found 1 ROCm devices:
Device 0: AMD Radeon RX 6800 XT, compute capability 10.3, VMM: no
llm_load_tensors: ggml ctx size =    0.32 MiB
llm_load_tensors: offloading 32 repeating layers to GPU
llm_load_tensors: offloaded 32/33 layers to GPU
llm_load_tensors:      ROCm0 buffer size =  3992.51 MiB
llm_load_tensors:        CPU buffer size =  4685.30 MiB
.......................................................................................
llama_new_context_with_model: n_ctx      = 2048
llama_new_context_with_model: n_batch    = 2048
llama_new_context_with_model: n_ubatch   = 512
llama_new_context_with_model: flash_attn = 0
llama_new_context_with_model: freq_base  = 500000.0
llama_new_context_with_model: freq_scale = 1
llama_kv_cache_init:      ROCm0 KV buffer size =   256.00 MiB
llama_new_context_with_model: KV self size  =  256.00 MiB, K (f16):  128.00 MiB, V (f16):  128.00 MiB
llama_new_context_with_model:  ROCm_Host  output buffer size =     0.49 MiB
llama_new_context_with_model:      ROCm0 compute buffer size =   669.48 MiB
llama_new_context_with_model:  ROCm_Host compute buffer size =    12.01 MiB
llama_new_context_with_model: graph nodes  = 1030
llama_new_context_with_model: graph splits = 4
Another piece of info: during the execution I see that the GPU usage is at 1% instead of 99% that I see when using llamalib in task manager. This might be inaccurate.

FYI I got llama.cpp's vulkan build to work (need to set GGML_VK_VISIBLE_DEVICES=0) and timing is like this:
llama_perf_sampler_print:    sampling time =      63.40 ms /   780 runs   (    0.08 ms per token, 12303.03 tokens per second)
llama_perf_context_print:        load time =    2719.64 ms
llama_perf_context_print: prompt eval time =     184.44 ms /     4 tokens (   46.11 ms per token,    21.69 tokens per second)
llama_perf_context_print:        eval time =   12409.56 ms /   775 runs   (   16.01 ms per token,    62.45 tokens per second)
llama_perf_context_print:       total time =   12738.39 ms /   779 tokens
So it's (potentially) faster to run vulkan than HIP w./ tinyBLAS.
Maybe that's an easier thing to get working than HIP?

Thanks for all the testing!
I have already included Vulkan as a fallback but is called if HIP doesn't work.
You can switch to that if you disable these 2 lines:
https://github.com/undreamai/LLMUnity/blob/main/Runtime/LLMLib.cs#L368
https://github.com/undreamai/LLMUnity/blob/main/Runtime/LLMLib.cs#L374
Could you try if that works better?

Could you also try the following to see if the build works at the same speed as tinyBLAS?

Setup

download the LLM DLLs and server binaries using the DLLs
unzip them in the same directory

from command line:

cd inside the directory, and inside the windows-hip directory
run undreamai_server.exe -m <path_to_Llama-3.1> -ngl 99 -c 2048 --port 13333 --template "llama3 chat"

You can then use it from Unity as a remote server

Open the SimpleInteraction sample
Delete the LLM GameObject
Enable the LLMCharacter GameObject Remote flag
Run the scene and start a chat

Check from command line the timings

Could we maybe have a call to resolve this? It would be really helpful!
You can find me at the Discord server.

(1) Vulkan doesn't work because of this problem, it detects the same graphics card twice and then fails to load:
https://github.com/ggerganov/llama.cpp/issues/9516
I tried to use C# API to set ENV variables but that seems to behave very strangely. It seems to take effect after a full restart of the editor. So it doesn't work and will refuse to work despite
UnityEngine.Debug.Log(Environment.GetEnvironmentVariable("GGML_VK_VISIBLE_DEVICES"));

prints 0 - until the editor and the unity hub is restarted.
This isn't going to fly for a production build.
(2) The performance for hip server is as bad as it is in editor:
INFO [           print_timings] prompt eval time     =   90492.37 ms /   195 tokens (  464.06 ms per token,     2.15 tokens per second) | tid="2696" timestamp=1726616971 id_slot=0 id_task=0 t_prompt_processing=90492.37 n_prompt_tokens_processed=195 t_token=464.06343589743585 n_tokens_second=2.154877809035171
INFO [           print_timings] generation eval time =   72538.86 ms /    45 runs   ( 1611.97 ms per token,     0.62 tokens per second) | tid="2696" timestamp=1726616971 id_slot=0 id_task=0 t_token_generation=72538.859 n_decoded=45 t_token=1611.9746444444443 n_tokens_second=0.6203571522954339
(3) The vulkan server works with the right env variable. The performance of vulkan server matches llama.cpp

@tempstudio I visited the issue again.
I checked the open llamafile issues and found an issue about using HIP > 5.5.
I recompiled the llama.cpp library with HIP 5.5.
Could you try the latest LLMUnity version and change this line:
https://github.com/undreamai/LLMUnity/blob/main/Runtime/LLMUnitySetup.cs#L105
to
public static string LlamaLibVersion = "v1.1.12-dev";
to see if it works with your AMD card?


No beacon sent on HTTPS pages

When my page is on HTTP, beacon fires as expected at every page load.
But once my page is on HTTPS, no beacon is sent.
My beacon url is to my own server, using relative path, as such:
BOOMR.init({
    beacon_url: "/boomerang"
});

In browser console, I have this error
Mixed Content: The page at 'https://......' was loaded over HTTPS, but requested an insecure form action 'http://........./boomerang?rt.start=......'. This request has been blocked; the content must be served over HTTPS.
What could be the problem?

This is strange.  A relative beacon URL should use the protocol of the page.
Which browser are you using?
Also, can you set a breakpoint in sendData and inspect the value of urls at the top level and form.action inside the submit() inner function?
Is there a public website where we can see this happening?

I'm using latest Chrome on Mac (Version 49.0.2623.87 (64-bit)), and FireFox 44.0.2 on Mac.
In sendData(), urls is ["/boomerang"].
In submit(), form.action is "https://.../boomerang"
They both look correct to me.
Unfortunately I have not put boomerang on a public site. It is only on my devbox.

ok, then I don't understand why you're getting the error since it is submitting to https.  Is your beacon endpoint by any chance redirecting from https to http for the beacon?  Can you look at the chrome web dev network panel and see what happens?

Yes, you are right. It is my server forcing http.
Sorry to bother.

No problem May.  Let us know if you have any other issues.


fragmentShaderBarycentric reports as true without complete SPIR-V to MSL support

When testing the fragment_shader_barycentric sample from the official Khronos Vulkan Sample repository (https://github.com/KhronosGroup/Vulkan-Samples), I receive the following errors:
[mvk-error] SPIR-V to MSL conversion error: Cannot declare both BaryCoordNV and BaryCoordNoPerspNV in same shader in MSL.
[mvk-error] SPIR-V to MSL conversion error: PerVertexKHR decoration is not supported in MSL.
My device reports fragmentShaderBarycentric = true, and while it allows the sample to startup it eventually fails on the above MSL conversion errors.  The spec says the following:
fragmentShaderBarycentric indicates that the implementation supports the BaryCoordKHR and BaryCoordNoPerspKHR SPIR-V fragment shader built-ins and supports the PerVertexKHR SPIR-V decoration on fragment shader input variables.
So my question is why does MoltenVK report fragmentShaderBarycentric = true, when the implementation is incomplete and violates the spec?  Perhaps this should instead return false, and let the developer choose to proceed only based on known limitations of this feature on MoltenVK.  Or have you taken the opposite approach, i.e. return true but expect the developer to investigate the known limitations on MoltenVK and write code to support only the working cases?

Have the same issue, code using this extension needs to have a driver ID check currently to not use PerVertexKHR since it's not actually supported. Would be nice if it could be supported but also not sure its a good idea to report to applications the extension works when it doesn't.


Azure Linux support

Tell us about your request
I would like to be able to deploy Azure Linux nodes with Karpenter
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
it's not supported
Are you currently working around this issue?
i'm not using Karpenter until Azure Linux is supported
Additional Context
No response
Attachments
No response
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Hi @flbla thanks for considering karpenter! I merged in azure linux support https://github.com/Azure/karpenter-provider-azure/pull/72 here.
This will go out in the next release so should be available within the next 2-3 weeks for you to leverage in managed karpenter.

@Bryce-Soghigian thank you!


[WIP] Message edit closing animations

This deals with Issue #4240 and adds nicer effects to the closing of the "edit message" box.
Here's a gif demonstrating what it looks like currently.

Some comments here: https://chat.zulip.org/#narrow/stream/frontend/topic/.234240.3A.20Message.20edit.20closing.20animations
Recording here so easier to keep track of.
Thanks for your work on this!

This is an example of the updated animation, with special attention payed to a fix for a previous bug wherein the animation wouldn't play upon saving an edit if an edit to the same message had been canceled immediately before.

I've updated this pull request with a commit to play the 'hide edit box' animation after the edited message's contents have been updated. Here's an example of what that looks like.

@cakleimeier did you intend to close this?

@timabbott Yes, I did. The branch is behind and its code wasn't working as intended and didn't solve the issue.

Sounds good!  Just wanted to check since folks do that by accident sometimes :)


New Configuration Implementation

Describe what this PR does and why we need it:
Implementation of the configuration proposal.
Changes proposed in this pull request

New Config Package
Updating the application start to use the new configuration
half removed the configuration structs that did not seem to be needed

This is feeling a little half baked still, would love some feedback.

Closing because not something we can bring in for a while now.


[MAUI] First Tab ist not showing

Platform (please complete the following information):

OS: Android
Device: [AndroidEmulator &  Amazon Fire Tablet]
Sdk vervion: [Android SDK 29+]
MAUI: [6.0.552]

Describe the bug
I am using DelayedViews in my TabSwitcher. When i am changing the layout from a FlexLayout to a Grid inside the DelayedView, the first tab will display nothing. When i open the next tab which is displaying the same kind of DelayedView(a new object from the same type) it gets displayed correctly.
only the first Tab with its content will not be displayed. There is no exception being thrown or displayed in the logcat
To Reproduce
Tabviewswitcher
`<tabs:ViewSwitcher x:Name="Switcher"
Animate="True"
SelectedIndex="{Binding SelectedViewModelIndex, Mode=TwoWay}">
                <tabs:DelayedView x:TypeArguments="contentViews:LobiPageView"
                                  AccentColor="White"
                                  BindingContext="{Binding Page1ViewModel}"
                                  Animate="True"
                                  UseActivityIndicator="True" />
                <tabs:DelayedView x:TypeArguments="contentViews:LobiPageView"
                                  BindingContext="{Binding Page2ViewModel}"
                                  AccentColor="{StaticResource Primary}"
                                  Animate="True"
                                  UseActivityIndicator="True" />
                <tabs:DelayedView x:TypeArguments="contentViews:LobiPageView"
                                  BindingContext="{Binding Page3ViewModel}"
                                  AccentColor="{StaticResource Primary}"
                                  Animate="True"
                                  UseActivityIndicator="True" />
                <tabs:DelayedView x:TypeArguments="contentViews:LobiPageView"
                                  BindingContext="{Binding Page4ViewModel}"
                                  AccentColor="{StaticResource Primary}"
                                  Animate="True"
                                  UseActivityIndicator="True" />
                <tabs:DelayedView x:TypeArguments="contentViews:LobiPageView"
                                  BindingContext="{Binding Page5ViewModel}"
                                  AccentColor="{StaticResource Primary}"
                                  Animate="True"
                                  UseActivityIndicator="True" />

            </tabs:ViewSwitcher>`

DelayedView ContentView
`

    <Grid.RowDefinitions>
        <RowDefinition></RowDefinition>
        <RowDefinition></RowDefinition>
        <RowDefinition></RowDefinition>
        <RowDefinition></RowDefinition>
    </Grid.RowDefinitions>
    <Grid.ColumnDefinitions>
        <ColumnDefinition></ColumnDefinition>
        <ColumnDefinition></ColumnDefinition>
        <ColumnDefinition></ColumnDefinition>
        <ColumnDefinition></ColumnDefinition>
        <ColumnDefinition></ColumnDefinition>
    </Grid.ColumnDefinitions>
    <BindableLayout.ItemTemplate>
        <DataTemplate>

....

`
Screenshots (if applicable)
First Page is not displayed

Scond Tab is displayed correctly with the same contentview

ah , the curious thing is. This only occurs in release mode. When i am debugging, everything is displaying correct

Try increasing the delay then

I increased it, now the loading symbol of the delayedview is at least showing. but the view itself won´t show. Seems like i will try to use a lazyview at least for the first tab

@roubachof it seems that this only occur when i am using a UnderLineTabItem. i changed it to a BottomTabItem. and now the first page is displayed even without a delay

Workaround is to put an empty and hidden StackLayout in first Position of the ViewSwitcher and handle the selectedTabIndex by myself

I solved this by adding an empty view in ViewSwitcher and an empty tab in the TabHostView. Problem now is the empty tab, even though it is hidden and has a width of 0, it still takes up space. Any ideas how to shrink the width to zero so it only fully "shows" 3 tabs?

Hey I have a similar problem and want to share some insights.
OS: iOS
Device: iOS Simulator
Sdk vervion: iOS v16.2
MAUI: 7.0.92/7.0.100
I have a ViewSwitcher in my MainPage. The first tab in the switcher is being shown however the View Model seems not to be loaded correctly. All the fields / areas are showing even though they should not - based on code in the View Model. It is working in Android. Within my code there seems to be no change in behaviour on how the VM is generated etc. if compared to Android. My workaround is to change the first tab to LazyView which works on Android and iOS.

Please this at your code behind
SelectedViewModelIndex = -1;

Hey, same problem here, maybe a different cause ; but here is what I have and for me the solution is rather straight forward :
In the xaml page file :
<tabs:ViewSwitcher x:Name="Switcher">
    <tabs:LazyView x:TypeArguments="views:MyView"
                    AccentColor="{StaticResource Primary}"
                    UseActivityIndicator="True">
    </tabs:LazyView>

And in the Page implementation :
    protected override void OnAppearing()
    {
        base.OnAppearing();

        // Forces the ViewSwitcher to trigger the SelectedIndexPropertyChanged event
        Switcher.SelectedIndex = -1;
        Switcher.SelectedIndex = _viewModel.SelectedViewModelIndex;
    }

The event is triggered like this in the codebase : SelectedIndexPropertyChanged
This happens because when adding children in ViewSwitcher, by default they are hidden :
protected override void OnChildAdded(Element child)
{
    base.OnChildAdded(child);

    if (child is View view)
    {
        HideView(view, Children.Count - 1);
    }
}

Original code can be found here.
I don't know if that's the only reason for the tab not to show in the first place, flickering it like I'm doing is probably not the thing to do here, but for me it solved the issue quite well :smile:
Shouldn't the first child tab be loaded and visible by default whenever the TabSwitcher is loaded (and displayed) ?

I have a similar issue on iOS only. First tab never gets the binding context set. Second one does. If I put a the following code in my ContentView, with a break point, the breakpoint gets hit when I change the tab but never for the first tab.
    protected override void OnBindingContextChanged() {       base.OnBindingContextChanged();     }
I had to set my default value of the view model SelectedViewModelIndex to -1 and then add
 protected override void OnAppearing() {    base.OnAppearing();    Switcher.SelectedIndex = -1;    Switcher.SelectedIndex = Math.Max( _viewModel.SelectedViewModelIndex, 0 );  } to the tab content page.

Hey I have a similar problem and want to share some insights.
OS: iOS Device: iOS Simulator Sdk vervion: iOS v16.2 MAUI: 7.0.92/7.0.100
I have a ViewSwitcher in my MainPage. The first tab in the switcher is being shown however the View Model seems not to be loaded correctly. All the fields / areas are showing even though they should not - based on code in the View Model. It is working in Android. Within my code there seems to be no change in behaviour on how the VM is generated etc. if compared to Android. My workaround is to change the first tab to LazyView which works on Android and iOS.

Thanks for the tip, this workaround is working for me without messing with index -1

My dudes in the ViewSwitcher the  SelectedIndexProperty already default to -1.
So you only have to set the SelectedIndex in your view model to whichever index you want.
for example:
public class BottomTabsPageViewModel : ANavigableViewModel
{
    private int _selectedViewModelIndex = 0;

    public BottomTabsPageViewModel(
        INavigationService navigationService,
        ISillyDudeService sillyDudeService,
        ErrorEmulator errorEmulator)
        : base(navigationService)
    {
        HomePageViewModel = new HomePageViewModel(navigationService, sillyDudeService);
        GridPageViewModel = new GridPageViewModel(navigationService, sillyDudeService);
        SelectedViewModelIndex = 2;
    }

will start the app with the 3rd bottom tabs selected (and lazy loaded).


Areas not visible due to clip-path are not handled correctly when moving pressed pointer off of, or back onto, element

Provide a general summary of the issue here
When using clip-path on an element enhanced using usePress, the non-visible parts of the element still result in press events from react-aria, when moving off of the element while continuing to press, and moving back onto the element while continuing to press.
Another way to word it (closer to the cause of the issue, I think):
When using usePress for an element with clip-path, once the first press on the element is registered, the element's bounding box is used to determine events instead of the area visible after applying the clip-path.
The spec (https://www.w3.org/TR/css-masking-1/#clipping-paths) says the following:

By default, pointer-events must not be dispatched on the clipped-out (non-visible) regions of a shape. For example, an element with a dimension of 10px to 10px which is clipped to a circle with a radius of 5px will not receive click events outside the clipping region.

🤔 Expected Behavior?
When moving a pressed curser off the visible area of an element into the non-visible, clipped area of the element, react-aria considers the element to be pressed.
😯 Current Behavior
When moving a pressed curser off the visible area of an element into the non-visible, clipped area of the element, react-aria considers the element to not be pressed.
💁 Possible Solution
I think the only possible solution is avoid doing any bounding box calculations, and instead solely rely on browser events. I don't know how feasible this is though, unfortunately.
🔦 Context
I am currently building a button in the shape of an "elongated hexagon" (the corners are clipped). I use clip-path to clip the corners for interactions.
Luckily, since the issue only occurs in the move off / back on case, the issue isn't too bad for me, because the clipped areas are minimal enough for it to be barely noticeable.
🖥 Steps to Reproduce
Follow the steps in this codesandbox
Version
react-aria 3.32.0
What browsers are you seeing the problem on?
Firefox, Chrome
If other, please specify.
No response
What operating system are you using?
Linux
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

This is a tricky one since usePress does hit target testing for some old browser bugs if I remember correctly: https://github.com/adobe/react-spectrum/issues/1720. I'll talk to the team about picking this work back up potentially but we'll need to be extra careful that removing the hit detection doesn't break anything since this press code is used extensively in the repo.

Closing this out in favor of https://github.com/adobe/react-spectrum/issues/2506, will link


Updates for SDK 3.0.0

@abehaskins @Resonantjacket5 I just did some major edits in this PR: https://github.com/firebase/firechat/pull/61  I am not sure what is going to happen, but there were quite a few changes that needed updating to work with the latest account/console in Firebase, also including the new SDK release.  @firebase-ops You may want to look into this.

@abehaskins - Ping on this PR. There seem to be lots of people asking about this on GitHub and the Google Group. Would be awesome to get this upgraded 🏭

Thanks for the ping! I thought this had gotten pushed out, will take a look this week :)

I pretty much fixed it all for you in the PR
On Mon, Jul 18, 2016 at 4:44 PM Abe Haskins<EMAIL_ADDRESS>wrote:

Thanks for the ping! I thought this had gotten pushed out, will take a
look this week :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/firebase/firechat/pull/60#issuecomment-233491965, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABmUXgPn21cfKrpQ5jeddhfhtOS__iCNks5qXA_wgaJpZM4InwMH
.

Thanks for doing that @cmosguy!

Okay, I'll take this over and get it done. This PR (and #61) both still need a fair amount of work to get all the examples working and making sure the code is correct. I've started on that with a new branch here. Hopefully will get this updated by the end of next weekend.
Thanks for your patience.

Closing in favor of #66.


Alignment of the icons

The book and the cross icons are not aligned vertically.

Hey @legendarykamal I have worked on fix. Please review it: https://github.com/legendarykamal/Lets-go-shop/pull/13

@karancoder  done reviewing :smiley:  , congratulations on being amongst the most earliest contributors :confetti_ball:

Thanks, in case there are more bugs/features that I can help with, would be really happy to help!


Don't crash on server shutdown

Coverage increased (+0.05%) to 84.942% when pulling c2a484cf936e8c5aa4b6bf1724c74e767c54d2b6 on feature/disconnect into 2fd87c7be0180aeca0e3d125fad8e5dda50057fa on master.

Coverage increased (+0.05%) to 84.942% when pulling c2a484cf936e8c5aa4b6bf1724c74e767c54d2b6 on feature/disconnect into 2fd87c7be0180aeca0e3d125fad8e5dda50057fa on master.


SELinux : support enforcing mode

run packaging-tests

run skydive-functional-tests-backend-elasticsearch

nit: Please don't put space after the first word in the commit message (or convince the others to do so :-) )


R&D servers can connect over maps

Description

You can connect unpowered servers and servers located on other maps to the R&D console.
Reproduction

Create the R&D console
Create an R&D server on a different map
Connect to the server through the console.

Additional context

should probably have a cvar to limit these servers to grid/map/session


WSL Support

Hi i commonly use WSL because i'm a Windows user, could you guys please add destreamer support for WSL? Thanks

It should work out of the box there, just follow the README! :D
Btw on windows there's a powershell script you can use to launch Destreamer


turn on the existing n_iter= parameter in multicore tsne

[X] Additional function parameters / changed functionality / changed defaults?
[X] New analysis tool: A simple analysis tool you have been using and are missing in sc.tools?
[ ] New plotting function: A kind of plot you would like to seein sc.pl?
[X] External tools: Do you know an existing package that should go into sc.external.*?
[ ] Other?

t-SNE is an interative algorithm, and takes numerous iterations to converge, particularly on larger datasets. For example, if MulticoreTSNE is installed, it accepts n_iter=30000 as opposed to the default n_iter=1000. It would be nice to have this parameter exposed. For larger datasets of say 200K cells, 1000 iterations isn't enough to fully converge to its final compact cluster shapes.
Alternatively, is it possible to pass in a kwargs to scanpy tools that wrap other algorithms, so that the advanced user can flexibly look up additional MulticoreTSNE parameters to modify, without needing to exhaustively enumerate all parameters in the scanpy wrapper?
Finally, it would be even better to have the faster FFT-based tsne to generalize to millions of cells, the most recent re-implementation being https://github.com/pavlin-policar/openTSNE
In the mean time, one has to overwrite the .X_tsne attribute after running these other tools separately.

Adding either more parameters or passing **kwargs arguments to an underlying tone library sounds reasonable. A PR would be welcome 😄
So you don't have to overwrite the "X_tsne" key, you can write the coordinates to whatever key in obsm you want, then call sc.pl.embedding(adata, basis={key})


Streamline tests

Some parts of the test seem at best sub-optimal. This change does the following:

Removes the now unhandled "-s bookinfo".
Additional parameters are now passed to make e2e_all.  There's probably a more elegant way to handle E2E_ARGS than what I came up with.
I also set ISTIO_DOCKER_HUB so istioctl is built to point to the HUB that's used.  I'm not sure if this really helps but it seems like this is the direction that other tests have been headed.  I suppose it's getting worthwhile to just have bin/get_workspace_status use HUB instead of the more special-purpose ISTIO_DOCKER_HUB.
Replace bin/init.sh with "make depend" (or remove it entirely if the top-level Makefile is being used, as it has appropriate dependencies set).

@mattdelco: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
0de18100f833485091963d6a890528ef1be4e27c
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
a382cc1c0474dcf2a2a794d6f3749c0c8abfd85c
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@mattdelco: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
a382cc1c0474dcf2a2a794d6f3749c0c8abfd85c
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
a382cc1c0474dcf2a2a794d6f3749c0c8abfd85c
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e

@mattdelco: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a382cc1c0474dcf2a2a794d6f3749c0c8abfd85c
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

/test istio-pilot-e2e

/lgtm
/approve


Question GO:0140274    repair of kinetochore microtubule attachment defect

Once this is addressed
https://github.com/geneontology/go-ontology/issues/25613
has 2 children
GO:1904967    regulation of monopolar spindle attachment to meiosis I kinetochore | is_a
GO:0140273    repair of mitotic kinetochore microtubule attachment defect
Need to standardize.
I need a non-regulation term for
monopolar spindle attachment to meiosis I kinetochore
but hopefully this term will be renamed to
spindle attachment to meiosis I kinetochore
becaue otherwise it's really confusing in this context, where the erroneous attachements could be either syntelic attachment, where both sister kinetochores interact with microtubules emanating from the same spindle pole, and merotelic attachment, where a single kinetochore is connected to both spindle poles.

This isn't actually inconsistent - we don't have all of the terms in both branches (mitosis/meiosis), and  it is possible that when these pathways are modelled  in GO_CAM some of the regulation terms/annotations will  be surplus  but for now, this is fine.


Add LoginButton presentation component

Release Type: Dev Improvements
Fixes https://x-team-internal.atlassian.net/browse/XP-3296
Description
This change adds a presentational component - LoginButton. It presents a ui/button specifically for the admin login page.
Checklist

[x] set yourself as an assignee
[x] set appropriate labels for a PR (In Review or In Progress depending on its status)
[x] move respective JIRA issue to the IN REVIEW column
[x] make sure your code lints (npm run lint)
[x] Flow typechecks passed (npm run flow)
[x] Snapshots tests passed (npm run jest)
[x] check cleanup tasks (https://github.com/x-team/xp/labels/cleanup) and take a suitable small one (if exists) in a related area of the current changes
[x] component's documentation (.stories.js file) is changed or added accordingly to reflect any new or updated use cases or variants usage
[x] if any snapshots have been changed, verify that component still works and looks as expected and update the changed snapshot
[x] manually tested the app by running it in several different browsers (Firefox, Chrome, Opera, Safari, MS IE/Edge, etc.) and checked nothing is broken and operates as expected!

Related PRs

branch
PR

XP-3296-use-xp-ui-button
XP

Steps to Test or Reproduce

Open storybook
Search for LoginButton
Observe basic and fallback story

Screenshots

@rayepps @nicksp I pushed the required changes in this PR https://github.com/x-team/xp-ui/pull/445/commits/48fb31a1fa8a8352e97f4e8a79e0d05b155c33c8 and https://github.com/x-team/xp-ui/pull/445/commits/84c0508a4dc3c1abf7e16313d2fe615b33ad3771

@bernardodiasc @rayepps Please notice that npm t fails on the branch so could we please resolve that?

@bernardodiasc @rayepps I resolved tests. They now pass fine.

@nicksp @bernardodiasc For the font issue. This happens as a pseudo feature of using xp-ui. The xp-ui styles have an additional font family applied (Montserrat, Arial, sans-serif) that the xp styles did not.
Prod:

This PR Branch:

^^ inside xp-ui an AutoUI... style is generated and used and its applying this extra font specification. Prod falls all the way back to the system-ui font.

Just as a note, on my machine/browser I don't see this by default. I see the correct font. Like I said above this is a fallback font thats used whey your machine/browser can't display OpenSans or Raleway. I had to remove those styles in the browser to get to the unwanted font.

hey @rayepps, this makes sense, good catch. I took a look and this seems to be something existing in the Button component here https://github.com/x-team/xp-ui/blob/develop/src/components/ui/Button.js#L76, if you check the what typo.labelText represents you see https://github.com/x-team/xp-ui/blob/develop/src/styles/typo.js#L135-L143, then https://github.com/x-team/xp-ui/blob/develop/src/styles/typo.js#L29-L32.
Checking further I found something that even I wasn't aware of that might fix this problem:

Can you try using the contentStyle='openSans' and see if fix this problem?

Great info @bernardodiasc - let me give that a try...

@rayepps alternatively you can try forcing the styles like this:
const cx = {
  button: cmz(
    typeface.strongHeading,
    `
      & {
        border-radius: 3px
        border: 2px solid transparent
        cursor: pointer
        display: inline-block
        line-height: 1.5
        outline: none
        min-width: 290px
        margin: .15em auto
        text-decoration: none
        text-transform: uppercase
        transition: all .3s ease-out
        white-space: nowrap
        border-width: 2px
        font-size: 1rem
        padding: .75em 2.4em
      }

      & span {
        font-family: inherit
        font-weight: inherit
      }
    `
  )
}

@bernardodiasc that didn't work for me. The style for the Montserrat is still used in the contentStyle='openSans' and when I change the button style its still getting set on top of that base extra style in typo that will eventually fallback to Montserrat.

Right now were trying to figure out a way to make this one button have a different base style than all the other buttons in the app. We should consider that the xp-ui styles are shared/global and thoughtfully set. So, instead of trying to make this button behave differently in fallback than the others I think we should:
a) Remove this base style that causes this unwanted fallback font. All buttons will behave the same and not show this font. They will instead fallback to system-ui. i.e. remove: https://github.com/x-team/xp-ui/blob/6a38a3f000a825bb6fc8be9f8e5ab5f80f7e7115/src/styles/typo.js#L137
b) Update the same line to instead refer to a fallback font we want. i.e. system-ui or just sans-serif. This seems to be the desired behavior... this would keep it the same for all buttons.
c) Accept that this is ok... again, was xp-ui not created with intention? I understand that this fallback font is not the same as its also my understanding that xp-ui is supposed to be the repo that sets the global standard for style in xp-... so possibly this isn't wrong its better.
I'm open to solutions that aren't hacking in a specialized style tree that bypassing a fallback font in typo.js for a single button on the login screen.
@bernardodiasc @nicksp @mccrodp

@rayepps I guess you need to use this:

const cx = {
  button: cmz(
    typeface.strongHeading,
    `
      & {
        border-radius: 3px
        border: 2px solid transparent
        cursor: pointer
        display: inline-block
        line-height: 1.5
        outline: none
        min-width: 290px
        margin: .15em auto
        text-decoration: none
        text-transform: uppercase
        transition: all .3s ease-out
        white-space: nowrap
        border-width: 2px
        font-size: 1rem
        padding: .75em 2.4em
      }

      & span {
        font-family: "Open Sans", "Helvetica Neue", Helvetica, Arial, sans-serif;
        font-weight: 700;
      }
    `
  )
}

it should work, I guess...

Hey @rayepps There're merge conflicts left. Do you need my help with resolving those? Usually, a way to go is to run npm run build to rebuild those files and merge them back.

@rayepps remember to update PR label to appropriate status to indicate whether it's finished and ready for re-review 😏

@rayepps FYI: PR contained linting errors:


⚠ Bofrost.be has degraded performance

In 24eeead, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1153 ms

Resolved: Bofrost.be performance has improved in 9dec705.


Radius does not work from second Hub

Tuned the same Radius Server for 2 Virtual Hub
When I connect via SSTP to default Hub using simple username ALL fine.
When I connect via SSTP to default Hub using username@hub I get Radius reject
When I connect via SSTP to second Hub using username@hub2 even request to Radius does not send.
Listened by tcpdump on Radius interface.

I've tested this and it works as expected with multiple hubs to same radius server.

You can try EAP if the radius server supports, with #1775
It's hard to fix it with MSCHAPv2 only.

Might be duplicate of #1103


Add Papyrus mode

Adds a highlighting mode for Papyrus, a scripting language by Bethesda
for video games mods (Skyrim and the Fallout series).
Documentation on the syntax is bit all over the place, but the
CreationKit wiki has lots of examples scattered around:
https://www.creationkit.com/index.php?title=Arrays_(Papyrus)
https://www.creationkit.com/index.php?title=Literals_Reference
Credit to the authors of the Lua mode, which acted as a good base to
work up from.

Hi. Thanks, but we aren't adding any new modes to the main distribution. The recommended way to distribute new modes is as separate npm packages (see for example the Elixir mode).


Flutter run web application says app is undefined

1- flutter run -d chrome
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following JSNoSuchMethodError was thrown building MyApp(dirty):
TypeError: Cannot read property 'app' of undefined

The relevant error-causing widget was:
MyApp org-dartlang-app:///packages/flutter_instagram/main.dart:8:23

When the exception was thrown, this was the stack:
package:firebase/src/top_level.dart 77:35                                        app$
package:firebase_auth_web/firebase_auth_web.dart 19:30                           [_getAuth]
package:firebase_auth_web/firebase_auth_web.dart 196:32                          onAuthStateChanged
package:firebase_auth/src/firebase_auth.dart 24:71                               get onAuthStateChanged
package:flutter_instagram/main.dart 13:39                                        [_getScreenId]
package:flutter_instagram/main.dart 28:13                                        build
package:flutter/src/widgets/framework.dart 4291:28                               build
package:flutter/src/widgets/framework.dart 4223:15                               performRebuild
package:flutter/src/widgets/framework.dart 3947:5                                rebuild
package:flutter/src/widgets/framework.dart 4206:5                                [_firstBuild]
package:flutter/src/widgets/framework.dart 4201:5                                mount
package:flutter/src/widgets/framework.dart 3194:13                               inflateWidget
package:flutter/src/widgets/framework.dart 2988:12                               updateChild
package:flutter/src/widgets/binding.dart 1028:16                                 [_rebuild]
package:flutter/src/widgets/binding.dart 999:5                                   mount
package:flutter/src/widgets/binding.dart 942:16                                  <fn>
package:flutter/src/widgets/framework.dart 2412:19                               buildScope
package:flutter/src/widgets/binding.dart 941:12                                  attachToRenderTree
package:flutter/src/widgets/binding.dart 818:24                                  attachRootWidget
package:flutter/src/widgets/binding.dart 804:7                                   <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 50:19  internalCallback

flutter run -d chrome --verbose
[  +13 ms] executing: [/home/bhaskar/flutter/] git -c log.showSignature=false log -n
1 --pretty=format:%H
[  +21 ms] Exit code 0 from: git -c log.showSignature=false log -n 1
--pretty=format:%H
[        ] 18cd7a3601bcffb36fdf2f679f763b5e827c2e8e
[        ] executing: [/home/bhaskar/flutter/] git describe --match v*.*.*
--first-parent --long --tags
[   +5 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[        ] v1.12.13+hotfix.6-0-g18cd7a360
[   +5 ms] executing: [/home/bhaskar/flutter/] git rev-parse --abbrev-ref --symbolic
@{u}
[   +5 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/beta
[        ] executing: [/home/bhaskar/flutter/] git ls-remote --get-url origin
[   +3 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +29 ms] executing: [/home/bhaskar/flutter/] git rev-parse --abbrev-ref HEAD
[   +6 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] beta
[  +62 ms] executing: /home/bhaskar/Android/Sdk/platform-tools/adb devices -l
[   +5 ms] Exit code 0 from: /home/bhaskar/Android/Sdk/platform-tools/adb devices -l
[        ] List of devices attached
           bf4a07f77d15           device usb:1-5 product:riva model:Redmi_5A
           device:riva transport_id:1
[  +16 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping
update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required,
skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required,
skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping
update.
[   +1 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping
update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping
update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping
update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping
update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping
update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping
update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping
update.
[  +14 ms] Found plugin cloud_firestore at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/cloud_firestore-0.13.0+1/
[   +5 ms] Found plugin firebase_analytics at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_analytics-5.0.9/
[   +1 ms] Found plugin firebase_auth at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_auth-0.15.3/
[   +1 ms] Found plugin firebase_auth_web at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_auth_web-0.1.1+1/
[   +1 ms] Found plugin firebase_core at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_core-0.4.3+1/
[   +1 ms] Found plugin firebase_core_web at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_core_web-0.1.1+1/
[  +13 ms] Found plugin url_launcher at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher-5.4.1/
[        ] Found plugin url_launcher_macos at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_macos-0.0.1+2/
[   +1 ms] Found plugin url_launcher_web at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_web-0.1.0+2/
[  +16 ms] Found plugin cloud_firestore at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/cloud_firestore-0.13.0+1/
[   +2 ms] Found plugin firebase_analytics at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_analytics-5.0.9/
[        ] Found plugin firebase_auth at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_auth-0.15.3/
[   +1 ms] Found plugin firebase_auth_web at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_auth_web-0.1.1+1/
[        ] Found plugin firebase_core at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_core-0.4.3+1/
[   +1 ms] Found plugin firebase_core_web at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_core_web-0.1.1+1/
[  +12 ms] Found plugin url_launcher at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher-5.4.1/
[        ] Found plugin url_launcher_macos at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_macos-0.0.1+2/
[   +1 ms] Found plugin url_launcher_web at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_web-0.1.0+2/
[  +25 ms] Generating
/home/bhaskar/Documents/learn/flutter/flutter_instagram/android/app/src/main/java/io/
flutter/plugins/GeneratedPluginRegistrant.java
[ +105 ms] Launching lib/main.dart on Chrome in debug mode...
[        ] Building application for the web...
[  +71 ms] Found plugin cloud_firestore at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/cloud_firestore-0.13.0+1/
[   +2 ms] Found plugin firebase_analytics at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_analytics-5.0.9/
[        ] Found plugin firebase_auth at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_auth-0.15.3/
[        ] Found plugin firebase_auth_web at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_auth_web-0.1.1+1/
[        ] Found plugin firebase_core at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_core-0.4.3+1/
[   +1 ms] Found plugin firebase_core_web at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_core_web-0.1.1+1/
[   +7 ms] Found plugin url_launcher at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher-5.4.1/
[        ] Found plugin url_launcher_macos at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_macos-0.0.1+2/
[        ] Found plugin url_launcher_web at
/home/bhaskar/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_web-0.1.0+2/
[+5826 ms] Starting daemon...
[  +88 ms] Initializing inputs
[   +6 ms] Reading cached asset graph...
[ +129 ms] Reading cached asset graph completed, took 126ms

[ +119 ms] Checking for updates since last build...
[ +330 ms] Checking for updates since last build completed, took 330ms

[   +5 ms] Initializing inputs
[   +1 ms] Reading cached asset graph...
[        ] Reading cached asset graph completed, took 126ms
[        ] Checking for updates since last build...
[        ] Checking for updates since last build completed, took 330ms
[  +84 ms] Serving DevTools at http://<IP_ADDRESS>:36997

[ +495 ms] About to build [web]...
[   +4 ms] Running build...
[ +118 ms] Running build completed, took 57ms

[        ] Caching finalized dependency graph...
[   +4 ms] Caching finalized dependency graph completed, took 80ms

[   +4 ms] Succeeded after 143ms with 0 outputs (0 actions)

[   +7 ms] Building application for the web... (completed in 7.3s)
[        ] Attempting to connect to browser instance..
[+1867 ms] Debug service listening on ws://<IP_ADDRESS>:40717/wsSkWTkdNOk=

[ +302 ms]       Failed to load asset at path:
packages/build_web_compilers/src/dev_compiler/dart_sdk.js.

                          Status code: 404

                          Headers:
                          {
                      "date": "Tue, 07 Jan 2020 17:11:52 GMT",
                      "content-length": "9",
                      "x-frame-options": "SAMEORIGIN",
                      "content-type": "text/plain; charset=utf-8",
                      "x-xss-protection": "1; mode=block",
                      "x-content-type-options": "nosniff",
                      "server": "dart:io with Shelf",
                      "via": "1.1 shelf_proxy"
                    }

                          Content:
                          Not Found}

[  +22 ms] Attempting to connect to browser instance.. (completed in 2.2s)
[   +1 ms] Warning: Flutter's support for web development is not stable yet and
hasn't
[        ] been thoroughly tested in production environments.
[        ] For more information see https://flutter.dev/web
[   +1 ms] 🔥  To hot restart changes while running, press "r". To hot restart (and
refresh the
           browser), press "R".
[   +1 ms] For a more detailed help message, press "h". To quit, press "q".
[   +5 ms] Debug service listening on ws://<IP_ADDRESS>:40717/wsSkWTkdNOk=
[ +789 ms] ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY
                    ╞═══════════════════════════════════════════════════════════
[   +3 ms] The following JSNoSuchMethodError was thrown building MyApp(dirty):
[        ] TypeError: Cannot read property 'app' of undefined
[   +1 ms] The relevant error-causing widget was:
[        ] MyApp org-dartlang-app:///packages/flutter_instagram/main.dart:8:23
[        ] When the exception was thrown, this was the stack:
[        ] package:firebase/src/top_level.dart 77:35
app$
[        ] package:firebase_auth_web/firebase_auth_web.dart 19:30
           [_getAuth]
[   +2 ms] package:firebase_auth_web/firebase_auth_web.dart 196:32
           onAuthStateChanged
[        ] package:firebase_auth/src/firebase_auth.dart 24:71
get
           onAuthStateChanged
[        ] package:flutter_instagram/main.dart 13:39
           [_getScreenId]
[        ] package:flutter_instagram/main.dart 28:13
           build
[        ] package:flutter/src/widgets/framework.dart 4291:28
           build
[        ] package:flutter/src/widgets/framework.dart 4223:15
           performRebuild
[        ] package:flutter/src/widgets/framework.dart 3947:5
           rebuild
[        ] package:flutter/src/widgets/framework.dart 4206:5
           [_firstBuild]
[        ] package:flutter/src/widgets/framework.dart 4201:5
           mount
[        ] package:flutter/src/widgets/framework.dart 3194:13
           inflateWidget
[        ] package:flutter/src/widgets/framework.dart 2988:12
           updateChild
[        ] package:flutter/src/widgets/binding.dart 1028:16
           [_rebuild]
[        ] package:flutter/src/widgets/binding.dart 999:5
           mount
[        ] package:flutter/src/widgets/binding.dart 942:16
<fn>
[        ] package:flutter/src/widgets/framework.dart 2412:19
           buildScope
[        ] package:flutter/src/widgets/binding.dart 941:12
           attachToRenderTree
[        ] package:flutter/src/widgets/binding.dart 818:24
           attachRootWidget
[        ] package:flutter/src/widgets/binding.dart 804:7
<fn>
[        ] package:dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart
50:19
           internalCallback
[        ]

flutter doctor
[✓] Flutter (Channel beta, v1.12.13+hotfix.6, on Linux, locale en_GB.UTF-8)
    • Flutter version 1.12.13+hotfix.6 at /home/bhaskar/flutter
    • Framework revision 18cd7a3601 (4 weeks ago), 2019-12-11 06:35:39 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /home/bhaskar/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling
      support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /home/bhaskar/Android/Sdk
    • Java binary at: /home/bhaskar/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[!] Android Studio (version 3.5)
    • Android Studio at /home/bhaskar/android-studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_202-release-1483-b49-5587405)

[✓] Connected device (3 available)
    • Redmi 5A   • bf4a07f77d15 • android-arm64  • Android 8.1.0 (API 27)
    • Chrome     • chrome       • web-javascript • Google Chrome 79.0.3945.88
    • Web Server • web-server   • web-javascript • Flutter Tools

! Doctor found issues in 1 category.

MyApp org-dartlang-app:///packages/flutter_instagram/main.dart:8:23

This is the code where this error is coming from, without it we won't be able to help

@bhaskar-nair2
I hope you've solved the issue.
Could everyone who still has this problem please file a new issue with the exact descriptions what happens, minimal reproducible sample code (if related), logs and the output of 'flutter doctor -v'  please.


Not able to build Notation project from source

What is the areas you experience the issue in?
Notation CLI
What is not working as expected?
After following the instructions to install notary from source. I'm unable to view the new changes while running docker --help.
What did you expect to happen?
I'm failing to see the following in docker --help
Management Commands:
  generate*   Generate artifacts (CNCF Notary Project, 0.1.0)
  notation*   Manage signatures on Docker images (CNCF Notary Project, 0.5.3-alpha)

How can we reproduce it?
Follow the instructions to build from source
Describe your environment
Installation method:Git
OS:  Ubuntu 22.04
Shell: bash
Golang Version : 20.1
What is the version of your Notation CLI or Notation Library?
Notation: Notary v2, A tool to sign, store, and verify artifacts.

Version:     v1.0.0-rc.1+unreleased
Go version:  go1.20
Git commit:  f463f0cb16753d5e398b3bb2d6e26a0e23e519c7

go.mod file
module github.com/notaryproject/notation

go 1.19

require (
	github.com/docker/docker-credential-helpers v0.7.0
	github.com/notaryproject/notation-core-go v1.0.0-rc.1
	github.com/notaryproject/notation-go v1.0.0-rc.1.0.20230203031935-510def1a3f48
	github.com/opencontainers/go-digest v1.0.0
	github.com/opencontainers/image-spec v1.1.0-rc2
	github.com/sirupsen/logrus v1.9.0
	github.com/spf13/cobra v1.6.1
	github.com/spf13/pflag v1.0.5
	oras.land/oras-go/v2 v2.0.0
)

require (
	github.com/Azure/go-ntlmssp v0.0.0-20221128193559-754e69321358 // indirect
	github.com/fxamacker/cbor/v2 v2.4.0 // indirect
	github.com/go-asn1-ber/asn1-ber v1.5.4 // indirect
	github.com/go-ldap/ldap/v3 v3.4.4 // indirect
	github.com/golang-jwt/jwt/v4 v4.4.3 // indirect
	github.com/inconshreveable/mousetrap v1.1.0 // indirect
	github.com/veraison/go-cose v1.0.0 // indirect
	github.com/x448/float16 v0.8.4 // indirect
	golang.org/x/crypto v0.5.0 // indirect
	golang.org/x/mod v0.7.0 // indirect
	golang.org/x/sync v0.1.0 // indirect
	golang.org/x/sys v0.4.0 // indirect
)

Hi Manas, building.md is obsolete. You don't need to run docker --help. As long as you can call notation command, you can use it directly. Thanks for your issue, we will update the installation guide later.


Confirmation speed

I'm currently wondering why it takes so long for the txSig to be returned when sending a transaction, takes around 5 secs for me currently. Is the txSig only returned once the max number of confirmations have been reached? I'm wondering a bit because serum and other solana based apps feel very snappy, while my application is slow. Or are these apps taking an optimistic approach, updating the local application once the tx simulation has passed?  Tried this on localnet and devnet. Any insight would be greatly appreciated!

You can use a more optimistic ConfirmOptions parameter when constructing your Provider or making an RPC via Context.


Pull in certs to jail

Problem:
Additional certs passed to rancher are not pulled into the jail
Solution:
Pull in optional rancher cert files to stop issues with self signed and
internal CAs
Issue: https://github.com/rancher/rancher/issues/21306

(LGTM)


Feature request: Add a way to return topic with message

When subscribing to wildcards a way to identify the particular topic which sent the message would be useful.  If the asyncIterator returned two arguments message, topic, you could implement pubSubs that use this.

private onMessage(topic: string, message: Buffer) {
    const subscribers = [].concat(
        ...Object.keys(this.subsRefsMap)
        .filter((key) => MQTTPubSub.matches(key, topic))
        .map((key) => this.subsRefsMap[key]),
    );

    // Don't work for nothing..
    if (!subscribers || !subscribers.length) {
      return;
    }
    const messageString = message.toString(this.parseMessageWithEncoding);
    let parsedMessage;
    try {
      parsedMessage = JSON.parse(messageString);
      parsedMessage = { ...parsedMessage, topic };
    } catch (e) {
      parsedMessage = messageString;
    }

    for (const subId of subscribers) {
      const listener = this.subscriptionMap[subId][1];
      listener(parsedMessage);
    }
  }

Any progress on this?

I've implemented this feature in an up to date fork of this repository.  If you would like, I can submit a merge request.

Hey will this pull request ever be added to main branch.  It passes all tests, adds a useful feature, and has been idle for over a year?


Add option to customize server response payload and status code

In some scenarios, it would be amazing to customize what the server returns. For example:

Customize what the server replies with, adding a custom JSON payload.
Customize the Status Code, for example 204, 401, 404, 500, etc.

Is that what you need?

Yes, exactly! Sorry, I didn't see that in the docs. That works great.


Treat "Reconnecting" hosts as "Inactive" on Scheduling process

As you may know, some of my hosts are being stuck into a "Reconnecting" state (#2196). Problem is that most of my experimental deployments are getting stuck because Containers are being scheduled into those hosts.
In the future, to avoid scheduling containers on machines that went down (maybe because of a machine failure), scheduler shouldn't deploy containers on those.

This is a duplicate of https://github.com/rancher/rancher/issues/1173

@deniseschannon


Add an examples / recipes section in the doc ?

Hey,
I was just thinking (yes it happens), looking at the issues raised lately most of them are "how to do X", "how to achieve Y" style of issues, wouldn't be wise to add a section to the doc where we can add examples that answer those questions ? That would help to point others to them.
While I'm at it, you used to have a "playground" section in the doc, any reason this is gone ? Was it too much to maintain or something ?
Again thanks for all the gooood work ^^

This is a good idea, maybe a "How to..." section in the GUIDE.md file.
Any help is appreciated!

any reason this is gone ? Was it too much to maintain or something ?

Actually yes, due to the increasing number of my repos, I found difficult to keep in sync the playgrounds with the code (not to mention having to maintain different versions). Instead I made the choice to improve the docs, which were awful in the past :)


Proposal to add a cuda_test rule

When using the cc_test rule, tests that are using cuda are compiled with cc compilers and not with nvcc. An easy solution for this is to provide a rule cuda_test that delegates everything to the cuda_libary and finally uses a cc_test depending on the cuda target. Something like
def cuda_test(name, srcs = [], ...):
    cuda_library_name = "_" + name

    cuda_library(
        name = cuda_library_name,
        srcs = srcs,
        ...
    )

    cc_test(
        name = name,
        deps = [cuda_library_name],
        ...
    )

I think it is generally good, contribution are welcomed.


No version information of boldigger3. Please check if the package name correct.

Hi @DominikBuchner,
Sorry to bother you again. I hadn't used BOLDigger3 for the past two weeks as I was away on a break. All of a sudden, I've started getting the below error when I attempted to use the tool this morning. Any idea as to what might be happening here? Thank you very much.
Successfully uninstalled boldigger3-1.2.4
Successfully installed boldigger3-1.2.5
(/home/user/tools/conda_python3.11_env) user@XXXXX:/data$ boldigger3 identify ASVs.fasta --db 3 --mode 3
Installing dependencies...
Switching to root user to install dependencies...
[sudo] password for user:
Traceback (most recent call last):
  File "/home/user/tools/conda_python3.11_env/bin/boldigger3", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/user/tools/conda_python3.11_env/lib/python3.11/site-packages/boldigger3/__main__.py", line 68, in main
    latest_version = obtainer("boldigger3")
                     ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/tools/conda_python3.11_env/lib/python3.11/site-packages/get_pypi_latest_version/main.py", line 40, in __call__
    raise e
  File "/home/user/tools/conda_python3.11_env/lib/python3.11/site-packages/get_pypi_latest_version/main.py", line 38, in __call__
    all_versions_web = self.get_by_spider_web(package_name)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/tools/conda_python3.11_env/lib/python3.11/site-packages/get_pypi_latest_version/main.py", line 83, in get_by_spider_web
    raise ValueError(f'No version information of {package_name}. '
ValueError: No version information of boldigger3. Please check if the package name correct.

Hi there,
Pip install --upgrade get-pypi-latest-version
Best
Dominik
Jant007 @.***> schrieb am So., 29. Dez. 2024, 07:35:

Hi @DominikBuchner https://github.com/DominikBuchner,
Sorry to bother you again. I hadn't used BOLDigger3 for the past two weeks
as I was away on a break. All of a sudden, I've started getting the below
error when I attempted to use the tool this morning. Any idea as to what
might be happening here? Thank you very much.
Successfully uninstalled boldigger3-1.2.4
Successfully installed boldigger3-1.2.5
(/home/user/tools/conda_python3.11_env) @.***:/data$ boldigger3 identify ASVs.fasta --db 3 --mode 3
Installing dependencies...
Switching to root user to install dependencies...
[sudo] password for user:
Traceback (most recent call last):
File "/home/user/tools/conda_python3.11_env/bin/boldigger3", line 8, in
sys.exit(main())
^^^^^^
File "/home/user/tools/conda_python3.11_env/lib/python3.11/site-packages/boldigger3/main.py", line 68, in main
latest_version = obtainer("boldigger3")
^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/tools/conda_python3.11_env/lib/python3.11/site-packages/get_pypi_latest_version/main.py", line 40, in call
raise e
File "/home/user/tools/conda_python3.11_env/lib/python3.11/site-packages/get_pypi_latest_version/main.py", line 38, in call
all_versions_web = self.get_by_spider_web(package_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/tools/conda_python3.11_env/lib/python3.11/site-packages/get_pypi_latest_version/main.py", line 83, in get_by_spider_web
raise ValueError(f'No version information of {package_name}. '
ValueError: No version information of boldigger3. Please check if the package name correct.
—
Reply to this email directly, view it on GitHub
https://github.com/DominikBuchner/BOLDigger3/issues/18, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJH6ILGAI2K33DYKLI7VWJL2H6J2LAVCNFSM6AAAAABUKQKBJ6VHI2DSMVQWIX3LMV43ASLTON2WKOZSG43DEMJSG42TKNA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank your very much @DominikBuchner ; that fixed it!


Source code edit? Insert

Hi
I am looking for an editor for a blog site and time to time the users need to insert

You can insert/modify raw HTML, including script tags by clicking on a HTML tag in the editors tags path (e.g P or UL > LI) (bottom left), then selecting the source tab in the window that appears.
However, out of the box that's about it there not a first class element type you can edit with CT.

sorry I did not understand.. So it it possible or not?
Actually I want to insert and then edit the

Yes - it is possible since you can edit the underlying HTML via the editor - you'll likely find this is the case with most editors.


Remove Covalent dependencies

Category: enhancement
Severity: Medium
As the Angular Material data table is fully functional we can remove the current Covalent one that does not add any extra feature and use this one. In the same process we can remove layouts and other components.
With this update this template would be independent of future Covalent changes.

Solved in #10


add cjxl option --keep_invisible

Allows preserving the color of invisible pixels in lossy mode (--keep_invisible=1) or forgetting the color of invisible pixels in lossless mode (--keep_invisible=0). For now just sets invisible pixels to black in lossless mode (probably something better is possible, but the smearing we're doing in lossy mode is not it).

I'll rebase once the other one lands, trying to avoid merge conflicts.


/cache API Can't use

Why /cache Admin API Can't use ?
[root@local12 ~]# curl -i -X GET --url http://<IP_ADDRESS>:8001/cache/
HTTP/1.1 405 Not Allowed
Date: Thu, 27 Sep 2018 16:53:46 GMT
Content-Type: application/json; charset=utf-8
Transfer-Encoding: chunked
Connection: keep-alive
Access-Control-Allow-Origin: *
Server: kong/0.13.1

{"message":"Method not allowed"}

Cache Reference

Hi @maxiaoxian,
As documented in the page you linked to, GET /cache is not a valid request. The supported endpoints are:
GET/cache/:key
DELETE /cache/:key
DELETE /cache

Because DELETE is the only method supported on the /cache endpoint, you are getting this HTTP 405 status code. Kong does not (yet) provide a "high-level overview" of the state of the database cache as you might think when seeing the /cache endpoint. Hence, GET is not supported on this endpoint. You must query a particular cache key (and you must know how such keys are built before requesting any, which relegates this endpoint to debugging purposes only).

think you so much ,but how to know those keys ?


Added Not and Peek parsers

Allows previewing the next input without consuming it.
Added tests for the above.

Peek has been updated to return the Upstream.Output value when successful.

Thanks!

Great work @randomeizer :)


use python 3.10

Fixes ModuleNotFoundError: No module named 'distutils' in macos github action run.
The module was removed in python 3.12.
Checklist

[x] All tests pass in CI
[X] There are enough tests for the new fix/feature
[X] Grammar rules have not been renamed unless absolutely necessary (x rules renamed)
[X] The conflicts section hasn't grown too much (x new conflicts)
[X] The parser size hasn't grown too much (master: STATE_COUNT, PR: STATE_COUNT)
(check the value of STATE_COUNT in src/parser.c)

Is 3.12 not required for gyp?
https://github.com/tree-sitter/tree-sitter-php/pull/192#issuecomment-1817606240

@calebdw no. 3.12 removes one of the dependencies required by gyp.
I went with a solution used in https://github.com/tree-sitter/node-tree-sitter/commit/723de6e2e4a27d15cb30f8ca7710a508e5ba59a4 to enforce usage of python 3.10 on all runners.

Ok now we're on python 3.12 on all runners and I updated node-gyp to 10.0.1 which properly solves distutils issue.


Fix absent resque keys

If there is no key present, this integration dies on trying to cast None to an int
Fix this by defaulting to 0
R? @gphat

👍


Terminating TLS at a reverse proxy doesn't work

Ideally when reverse proxying you'd terminate TLS at the proxy layer and send pump.io plain HTTP. However, this doesn't seem to work.

Note: Apache can't do ssl passthrough, you need nginx or haproxy.

Yeah, the title is a little misleading since what I end up telling people to do is still terminate HTTPS at the Apache layer, but then start a new TLS session with the backend process. Which is usually on localhost. :/
That's pretty unfortunate, so that's what this issue is about.


Got 'spotify' ready for Apple Silicon

'spotify' is now ready for Apple Silicon

 $ sudo zsh Installomator.zsh spotify DEBUG=0

2021-09-06 16:13:29 spotify setting variable from argument DEBUG=0
2021-09-06 16:13:29 spotify ################## Start Installomator v. 0.6.0
2021-09-06 16:13:29 spotify ################## spotify
2021-09-06 16:13:29 spotify BLOCKING_PROCESS_ACTION=prompt_user
2021-09-06 16:13:29 spotify NOTIFY=success
2021-09-06 16:13:29 spotify LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2021-09-06 16:13:29 spotify no blocking processes defined, using Spotify as default
2021-09-06 16:13:29 spotify Changing directory to /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.pPwKHaBN
2021-09-06 16:13:29 spotify App(s) found: /Applications/Spotify.app
2021-09-06 16:13:29 spotify found app at /Applications/Spotify.app, version <IP_ADDRESS>6.gbb5ef64e
2021-09-06 16:13:29 spotify appversion: <IP_ADDRESS>6.gbb5ef64e
2021-09-06 16:13:29 spotify Latest version not specified.
2021-09-06 16:13:29 spotify Downloading https://download.scdn.co/SpotifyARM64.dmg to Spotify.dmg
2021-09-06 16:13:33 spotify no more blocking processes, continue with update
2021-09-06 16:13:33 spotify Installing Spotify
2021-09-06 16:13:33 spotify Mounting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.pPwKHaBN/Spotify.dmg
2021-09-06 16:13:41 spotify Mounted: /Volumes/Spotify
2021-09-06 16:13:41 spotify Verifying: /Volumes/Spotify/Spotify.app
2021-09-06 16:13:49 spotify Team ID matching: 2FNC3A47ZF (expected: 2FNC3A47ZF )
2021-09-06 16:13:50 spotify Downloaded version of Spotify is <IP_ADDRESS>6.gbb5ef64e, same as installed.
2021-09-06 16:13:50 spotify Deleting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.pPwKHaBN
2021-09-06 16:13:50 spotify Unmounting /Volumes/Spotify
"disk4" ejected.
2021-09-06 16:13:50 spotify App not closed, so no reopen.
2021-09-06 16:13:50 spotify ################## End Installomator, exit code 0

Thanks!


Wallet 1.4. 1 - Payment Failure

I'm attempting to send Ripple to an exchange. I'm getting an error message Payment Failed.
I can easily deposit Ripple into the wallet, but it seems I cannot send it out.
What do I do?

Fixed. I re-downloaded the wallet and was able to successfully transfer funds.

Had the bug, redownloaded, still have the bug.

and after 15 retries it went trough!

Ditto.  Same is happening for me right now.


Garmin RVR315 not able to detect objects coming from left and right

Folks I am getting data using ANT+ protocol to detect objetcs on road using Garmin RVR315 and it is not able to identify objects coming from left and right, it always says for all the objects approaching from behind even if it is coming from left or right. Is it working fine for everyone else? Is it only me who is facing this issue? What do I do?

Hi, I did some quick tests my on Varia RTL515 and I am also getting "THREAT_SIDE_NO_SIDE" every time. It seems like that Varia does not support threatSide attribute.

Thanks :)


Want to add Todolist Project

go ahead 🚀

already added to-do-list to my repo. please assign this to me @irshadmd


Revert "fix: add padding to artworks"

Reverts denoland/deno_website2#1210
A unrelated change in this PR that changedmax-h-56 to h-56 in makes wide image look squashed images on small screens:

cc @ry @Qu4k

My bad. I was experimenting a bit with the layout and forgot to revert.

The change was made to align “An animated Deno logo” in the grid. Maybe we should look into aligning in better.


do you think it would be doable in other languages like python for a linked list?

Hi @xihajun, closing this since it’s a question that’s specific to Python and at the same time goes beyond the scope of this project.
That said, here’s my take.
Python does not have a pointer construct and as such, double pointer “implementations” in Python likely are educational at best.
If you are interested in the actual list type implementation in cpython (which is in C and makes use of pointers), I recommended you check the source.

Thanks @mkirchner
On Thu, May 12, 2022, 4:41 PM mkirchner @.***> wrote:

Hi @xihajun https://github.com/xihajun, closing this since it’s a
question that’s specific to Python and at the same time goes beyond the
scope of this project.
That said, here’s my take.
Python does not have a pointer construct and as such, double pointer
“implementations” in Python likely are educational at best.
If you are interested in the actual list type implementation in cpython
(which is in C and makes use of pointers), I recommended you check the
source
https://github.com/python/cpython/blob/main/Include/cpython/listobject.h
.
—
Reply to this email directly, view it on GitHub
https://github.com/mkirchner/linked-list-good-taste/issues/13#issuecomment-1125149813,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGDRXGLCQUDVOOLKI34YGR3VJURDVANCNFSM5VUEJMCA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Bump up version for applicationinsights

Reviewed and tested on OSX and Linux. Good to go for me.

@kieferrm On second thoughts, since all the extensions use asimov already and not AI, we don't need to make any changes to the package.json and shrink-wraps for extensions here.

@ramya-rao-a that's correct. No changes are needed for the extensions.