Create variable promtail_systemd_service_environment

Add promtail_systemd_service_environment to allow the Environment= line in a systemd service file to be used. For example,
Environment=HOSTNAME=%H
is needed to make the HOSTNAME environment variable of systemd available to the promtail configuration file for expansion.
Default value is blank and will not harm anyone who chooses not to use it.

I am very hesitant to expose every possible combinations of variables directly.
Instead have you considered overriding the template file yourself for your use-case ? Just copy the role template locally and provide an absolute/relative path for your template promtail_systemd_service_template_file

I could, but this seems reasonably fundamental -- and I'd like to stay in sync with your repo. I am also planning to use this role in various AMIs so a custom service file is a minor headache, especially if the base one ever changes. Is there is any reason not to have it, with a pull request ready to go? Thanks for your consideration.

Is there is any reason not to have it, with a pull request ready to go?

It's not a feasible model to pass through all possible combinations of systemd unit file sections and parameters. And if allowing to override / add one parameter now - it's not feasible to argument why parameter X was accepted and not parameter Y. I don't see much value in adding all of these parameters and increasing also the complexity of documenting parameters to users of the role.
It is possible to fully override the service template and thus providing all flexibility needed to accomplish what you desire

I am also planning to use this role in various AMIs so a custom service file is a minor headache, especially if the base one ever changes.

That is why, you have the possibility to override the template location and provide your own template instead of needing to maintain a fork of the role. Additionally, it would be possible to wrap the role and create a custom role of yours that only contains the new service definition and an overridden default, staying in sync with upstream.

Seems to me if someone is willing to write the pull request for it, it does no harm to take it. I originally updated the README (and would be willing to do that if that is the issue) but you did not have documentation for several other systemd flags in there and I decided to keep it consistent. It's kind of obvious how to use it if you care about it, right there in the template.
As far as "one variable and not another" I do indeed see you took some others before this so that's already an issue. That is why I took the time to write the pull request. systemd is rather important for many of us...
I truly don't understand your objection, but no point arguing, thank you for writing the role and I'll keep my repo separate.

As far as "one variable and not another" I do indeed see you took some others before this so that's already an issue. That is why I took the time to write the pull request. systemd is rather important for many of us...

There seems to be a misconception on what I am referring to. I was referring to creating additional variables for passing through individual systemd unit/service file parameters.
When allowing to set Environment=variable another person will ask to set EnvironmentFile. On top of that, the directive Environment is not a single directive but can be defined several times ( as does EnvironmentFile ).
You see, the amount of parameters a systemd unit can have grows and is different per use-case. Instead of now passing through all variables, I've provided the option to specify your own template, which you can customize to your use-case without requiring to add additional variables to the role. The role will take your customized template specified via promtail_systemd_service_template_file - all additional variables you create and specify will be templated as usual.
I am closing this PR now, as the use-case of customizing the systemd unit file is possible


Kubernetes alongside mesos in one cluster

Dedicated workers for kubernetes kubelets.
The most itchy problem is of interface: how to "turn on" kube in ansible and tf, in the most simple fashion. Now, in order to have kube alongside mesos, one has to:

increase number of kubeworkers in terraform file
add kube roles into playbook
use kubernetes_vars.yml when running ansible-playbook

Status
Tested on:

GCE: works
AWS: -
OS: -

Is there a way we can make the host terraform definitions more generic, so that they can be used for different roles?
for example:
module "mesos-worker" {
   source = "tf/gce"
   metadata = "role=worker"
}

module "mesos-worker" {
   source = "tf/gce"
   metadata = "role=k8s-worker"
}
``

@stevendborrelli I'll try to get the abstracted modules into dedicated PR/issue.

@Zogg what's the status of this PR?

Closing this since it is out of sync and there haven't been any updates. Please reopen when this is ready to be merged!


Request: Add Docs on What the Color Override Options Corrrespond to

Is your feature request related to a problem? Please describe.
I love the customizability of Catppuccin, but I wish that there was documentation on what each of the color override options (mantle, crust, subtext, etc) correspond to.
Describe the solution you'd like
A document explaining what each of the color override options correspond to. This will make it easier to customize the colorscheme.
Describe alternatives you've considered
I found the general Catppuccin style guide. Though it is great, it is not specific enough for neovim, and it is inaccurate when it comes to neovim. It describes "surface2" field as one for surface background elements. When I changed it, it affected the comment text color.

See also: https://www.reddit.com/r/catppuccin/comments/yemffz/code_coloration_style_guide/ityusdc/


Add missing uuid for GitHubMergeQueueCheckPass

Otherwise, there'd weird issues, like:
The build is triggered on Master pipeline but the build url points to Experimental pipeline:

And it redirects to Master pipeline.

The merge queue build has started. Click here to see all failures if any.


fix lso issue

Fixes:
Allocate available pv for LSO workloads.
Currently we skipping available pv and that the reason that LSO workload is failed.

We need to delete mount path when pv deleted


adding one sentence regarding the lowpass filter

Reference issue
Example: Fixes #8882 .
What does this implement/fix?
Adding one sentence to the doc under 'lowpass'
Additional information
Any additional information you think is important.

@ChristinaZhao you need to fix flake8 errors


Bug report for trillium-api: Doesn't call before_send functions

Describe the bug
trillium_api::ApiHandler only calls run on the returned Handler; it never calls before_send. This prevents the returned Handler type from being able to do its own error handling or other before_send functionality.
I think, since ApiHandler is wrapping a handler, it should call run on that handler and then immediately call before_send on the same handler.
To Reproduce
Steps to reproduce the behavior:
Run a server using trillium_api::api wrapped around a function returning a Handler that provides a before_send function. Note that the function never gets called.

While this makes sense, I'm not sure if this is a bug or a failure of documentation. Could you describe how you're using trillium_api?

@jbr I'm using api as normal, but I'd like to override the default error handler so that I can send something other than JSON errors, for compatibility with an existing interface.

Ahh! I do think that's either a matter of documentation or a poor design decision about the default error handler, which is why it's probably best to start with intent instead of code requests. Adding the before_send handler (which is addressed on main) does not in fact solve this concern, as the before_send is not run if the handler is not run, for example if the body fails to deserialize.
My intent was as follows, and this either needs to be substantially better documented:

async fn post(_conn: &mut Conn, Body(_): Body<Vec<String>>) -> impl Handler {
    trillium::Status::Ok
}

struct HandleErrors;

#[trillium::async_trait]
impl Handler for HandleErrors {
    async fn run(&self, conn: Conn) -> Conn {
        conn
    }
    async fn before_send(&self, mut conn: Conn) -> Conn {
        if let Some(error) = conn.take_state::<Error>() {
            conn.with_json(&json!({ "custom": "error", "here": error }))
        } else {
            conn
        }
    }
}

fn main() {
    trillium_smol::run((api(post), HandleErrors));
}

In general, a pattern that I expect will be common enough that it's worth documenting is for an application to have an error-catching handler that runs at the end of the stack and that checks for the presence of any number of errors in state and formats the response appropriately.
As a real-world example of exactly this pattern, see https://github.com/divviup/divviup-api/blob/main/src/handler/error.rs

@jbr Ah, I see; thank you for clarifying that!
And if I'm understanding how before_send gets sequenced, it should suffice to have a single before_send-based error Handler after the entire router, rather than repeating one at the end of every endpoint.
It wasn't obvious to me, when first using Trillium, when I'd ever want to not halt at the end of a handler, and I'm now starting to get an idea of why not to.
Right now, my approach to error handling looks like this:
#[trillium::async_trait]
impl Handler for ApiError {
    async fn run(&self, mut conn: Conn) -> Conn {
        match self {
            ApiError::Visible(status, err) => {
                tracing::Span::current().record("error", &tracing::field::debug(err));
                conn.set_status(*status);
                conn.set_body(err.to_string())
            }
            ApiError::Invisible(err) => {
                tracing::Span::current().record("error", &tracing::field::debug(err));
                conn.set_status(Status::InternalServerError);
                conn.set_body(Status::InternalServerError.canonical_reason())
            }
        }
        conn.halt()
    }
}

type ApiResult<T> = Result<T, ApiError>;

/// Convert any `Result` to an `ApiResult` to define user visibility
trait ApiResultExt {
    type R;
    fn invis(self) -> Self::R;
    fn visible(self) -> Self::R;
    fn visible_s(self, status: impl TryInto<Status>) -> Self::R;
}

Then, I can write api(handle_foo_post) where:
async fn handle_foo_post(
    conn: &mut Conn,
    (State(x), Body(y)): (State<TypeX>, Body<TypeY>),
) -> ApiResult<Body<SomeStruct>> {
    ...
}

And then use ? freely within handle_foo_post as long as I use either .invis() (for errors that should be hidden behind "Internal Server Error") or .visible() (for errors whose text is suitable for human consumption) first.
This works great, except that it doesn't let me avoid the default error handler. Sounds like I should be putting the ApiError into the Conn as state, and then putting in my own error handler at the end that handles both that and trillium_api's Error type.

Closing this as it now seems fairly clear how to avoid the default error handling.


Initial PR for RSM domains migration

Context

Changes proposed in this pull request

Guidance to review

Link to Trello card

Checklist

[ ] Attach to Trello card
[ ] Rebased main
[ ] Cleaned commit history
[ ] Tested by running locally

 RSM: migrate domains to s189


disabling panHandlers

Can you provide some guidance on how to disable panHandlers in this new version of react-native-router-flux?
The current swipe right to dismiss feature is very disruptive to my app flow.
If you could provide some guidance on how to implement a CustomNavigator etc, I would be glad to submit a PR to show this could be done in Example.

panHandlers set to null should work for beta.7

10 июля 2017 г., в 18:51, Alexander Chia<EMAIL_ADDRESS>написал(а):
Can you provide some guidance on how to disable panHandlers in this new version of react-native-router-flux?
The current swipe right to dismiss feature is very disruptive to my app flow.
If you could provide some guidance on how to implement a CustomNavigator etc, I would be glad to submit a PR to show this could be done in Example.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

okay i can confirm that works.
please include in future documentation.


Expose Docker Layer Caching option during builds

Context
Adds the docker-layer-caching parameter to docker-publish; the default is still false, but at least users can opt-in if they'd like
Open Questions

[ ] - Figure out if this will actually work, or not! I haven't tested and to be honest I'm not sure what the correct testing strategy is

Don't think I have permissions to request reviews for this repo -- cc @bendrucker

I've updated permissions (https://github.com/TakeScoop/artifactory-orb/commit/ec4ab8c6f127d52523091074f7830244ef3b8bc1) and enabled building of forks in Circle so you can get checks here. Secrets are not enabled and so the E2E test probably still won't run. But at least you get validation that the definitions are valid (via the pack job).

Looks like publish-dev will always fail until approved by an "authorized user" (you?) so with the other tests passing it looks like this might be ready?


Constraint checking

This issue is a placeholder for discussions around constraint checking of needs and needs fields.
Currently I 'misuse' the needs_functions to achieve that:
needs_extra_links = [
    {
        "option": "parent_chap",
        "incoming": "contains",
        "outgoing": "part of chapter",
        "copy": True,
    },
    {
        "option": "parent_req",
        "incoming": "sub-requirements",
        "outgoing": "part of requirement",
        "copy": True,
    },
]

def gen_style_field(app, need, needs, *args, **kwargs):
    """
    :param app: sphinx app
    :param need: current need
    :param needs: dictionary of all needs. Key is the need id
    :return: str,int,float or list of elements of type str,int,float
    """
    indent_lvl = 0
    tmp_need = need
    while 'parent_req' in tmp_need:
        if not tmp_need['parent_req']:
            break
        cnt = len(tmp_need['parent_req'])
        if cnt != 1:
            raise Exception(f'parent_req of need {tmp_need["id"]} has {cnt} entries. Must be exactly 1.')
        indent_lvl += 1
        tmp_need = needs[tmp_need['parent_req'][0]]
    while 'parent_chap' in tmp_need:
        if not tmp_need['parent_chap']:
            break
        cnt = len(tmp_need['parent_chap'])
        if cnt != 1:
            raise Exception(f'parent_chap of need {tmp_need["id"]} has {cnt} entries. Must be exactly 1.')
        indent_lvl += 1
        tmp_need = needs[tmp_need['parent_chap'][0]]
    return "indent_lvl_" + str(indent_lvl)

needs_functions = [gen_style_field]

As a main feature, the code returns the nesting level of a need by evaluating the link structure for CSS highlighting in a hidden need field. As a side feature it also raises exceptions if several parents are given for a given custom defined link type.
I propose to add a feature to needs for common constraint checks on needs. I'm thinking of

the title must follow a regex
a field must always be given
a field must not be empty / empty string
a field must follow a given regex
a field must be given for a specific need type (bigger topic, currently fields are availabe for all need types)
a field must have a specific multiplicity (e.g. 1 for a single element, 2 for 2 elements)
a field must match the same field of a linked need (user defines the link type to look for) if a link is given

More complex checks can also be performed using the hidden dynamic function or custom hidden functions named differently.

I think we can use the "filter-string" to define constraints.
If a filter returns true for a need, then a warning/error is raised.
needs_constraints = {
  'req_with_status': "type == 'req' and status is None or len(status) == 0",
  'valid_staatus' : "status not in ['open', 'closed']",
  ...
}

These constraints are checked after all needs got read in and dync. functions got executed.
If a need raises a constraint, a sphinx-warning is printed.
One could use -W during sphinx-build to stop build with failure.

Good idea. Does this support more sophisticated checks which uses imports (like re)?

Filter strings already Support re.search().
Everything what is needed by user must be provided by us. So the user can not decide to use new filter functions by importing stuff.
However, if there is a good use case, we can support it.

I'm happy with the proposal for the new needs_constraints configuration variable.
What do the keys in the dictionary mean. Just for logging?

Yes just for logging and maybe someday also as reference, e.g. show needtable with findings of given constraint.

Done, see https://sphinxcontrib-needs.readthedocs.io/en/latest/configuration.html#needs-constraints


Log errors and connection establishment to the GELF server

Previously, connecting to the wrong IP address or port would fail
silently. Now, it's at least logged (to some other logging interface,
should one be registered).
Also move the logging suppression to the inner sending loop, there
should be no harm in logging the connection establishment phase.

Diff without whitespace changes: https://github.com/hlb8122/tracing-gelf/pull/16/files?w=1.
We stumbled upon this problem when trying to set up a graylog server backend here: https://github.com/nimiq/core-rs-albatross/pull/650.

@glebpom @overhacked As valued contributors, do you have any objections to something along these lines?

This would be a breaking change but I think would provide a better API in general.

If you're doing a breaking change anyway, I'd also add a std::fmt::Debug bound to the address passed into the builder so you can also log that.

Is there any blocker for this? Or are you generally just waiting for more feedback?
Once this is merged, a new version on crates.io would be amazing. :)

@hrxi I've pushed a 0.6.1 for you, I'm going to go ahead with the API design and publish it under 0.7 so you can adopt in your own time.

@hrxi Great news. If you have any strong opinions please share them in https://github.com/hlb8122/tracing-gelf/pull/20. The PR is a bit large, but to see the new API take a look at examples/reconnect.rs


glazier-react haddock failure

glazier-react: BuildFailureException Process exited with ExitFailure 1: ./Setup haddock --haddock-options=--read-interface=../Cabal-<IP_ADDRESS>/,/var/stackage/work/builds/nightly/doc/Cabal-<IP_ADDRESS>/Cabal.haddock --haddock-options=--read-interface=../StateVar-<IP_ADDRESS>/,/var/stackage/work/builds/nightly/doc/StateVar-<IP_ADDRESS>/StateVar.haddock --haddock-options=--read-interface=../adjunctions-4.3/,/var/stackage/work/builds/nightly/doc/adjunctions-4.3/adjunctions.haddock --haddock-options=--read-interface=../aeson-1.1.0

src/Glazier/React/Markup.hs:44:5: error: parse error on input <E2><80><98>[<E2>
<80><99>

Not sure if @DanBurton pinged you @louispan (maintainer of glazier-react), so just following up on that.

looking at it now

Should be fixed now (v.<IP_ADDRESS>)

Thanks! That just missed tonights nightly but will be sorted for tomorrow :+1:


Reconnection

How is reconnection supposed to work?
When I disconnect player (close browser tab or refresh browser) player stay in player list with status "disconnected".
When I open client in a new tab or refresh browser, server generate a new player with new ID.
When I do this 10 times, I get 10 hanged users in waiting timeout, which I cannot reconnect.

What the sense of it and how can I reconnect ?
Problem persists in all clients. The only difference is agar.io client - using it I can hang no more then 2 instances, if I repeat disconnections, older users disappear from player list.
As I think, we have mix of two tasks:

"Keep connection" timeout - while player is not active.
Reconnection timeout - while we store user data for reconnection, which doesn't work at all.

As reconnection doesn't work - player list should be cleaned from dead records immidiately when socket connection is lost.  So-so...

@Gimmo What clients have you tested this on? I've tried each client from the list in the README and the [DISCONNECTED] message dissapeared after two instances on all of them.

Cigar and Alis.
Server on Deb7  VM.
MultiOgar - last version "from the box".
Check one more time right now. F5->Play button on client ->F5.......skip...... pl on console

@Gimmo I also checked with said clients, I could not reproduce it. Also the server clears everything regarding the player once they've disconnected.

@Megabyte918
the server clears everything regarding the player once they've disconnected
Sorry to say, but no. I found this problem while working on other things ( track client object life to modify code) . Objects stay in memory and erased at the same time when erased from list. My own problem was on multiply erase of object and, as a consequence, multiply callback.   Server really have hanging objects in timeout loops.
I check clean (fresh install) server just to be sure the reason of problem not in my code.

@Gimmo Fixed the leaderboard thing, turns out they get removed in vanilla too. Also what do you want me to do about the timeout? That's how its supposed to work, the player's cells stay where they were once they disconnected until the timeout ends, then it is removed.

@Megabyte918
Re: Timeout:
It's a security hole. It's easy to make script, which will reconnect fast enough to cause server overhead.
Player object should be destroyed at disconnection. If you like to see disconnected player in Player List - there is nothing wrong to keep this as record in Player List, but player object definitely should be removed from memory.

@Gimmo It clears the player by removing all of its cells, and it can only do that by waiting for playerDisconnectTime to pass.

@Megabyte918  one cell by one tick, right?

@Gimmo
Socket is destroyed on disconnect here. It then removes the player from this.socketCount, and then marks them as "disconnected" by using ws.isConnected = false;
If the isConnected variable is false, playertracker waits for disconnect time to pass here, after it has passes, it removes all of their cells, then marks them as "removed" by using this.isRemoved = true;
if this.isRemoved = true; from playertracker, the following things happen:

update is skipped here and here
spectate target is cleared here
they are cleared from the list of client's here

And that's pretty much it.

Why we can't simply do something like this.player = null on disconnection ?  All operations you point are good for game dynamics, but not necessarily for total destroy. Where I'm wrong?

@Gimmo Where do you suggest I put that variable? There's no point because isConnected and isRemoved are basically the same thing. Same thing with this.socket.remoteAddress == null

@Megabyte918  I'll try to think about it.  :)

It already does this though

It does this after timeout at  PlayerTracker about line 254. During if (this.cells.length == 0 || dt >= this.gameServer.config.playerDisconnectTime) timeout time object hangs in memory.
I place callback here and get it with zeroed size and mass after timeout. From every instance of disconnected player.

ok

Timeout 0 did the trick :)


PHP mangles large numbers

gapple\Tests\StructuredHeaders\RulesetNumberGeneratedTest needs to skip two rules when testing serialization due to PHP rounding / truncating values.

'15 digit, 3 fractional small decimal'
'15 digit, 3 fractional large decimal'

https://3v4l.org/hGX94
$ php -a
php > var_dump(111111111111.111);
double(111111111111.11)
php > var_dump(999999999999.999);
double(1000000000000)
php > var_dump(999999999999.995);
double(999999999999.99)

The same rules don't fail parsing because the parsed and expected values receive the same truncation.

Looks like the php-master branch parses these numbers with the correct precision, so this may not be an issue in PHP 8+?
https://3v4l.org/hGX94/rfc#git-php-master

These tests currently fail on PHP 8.0.0-dev in Actions.
https://github.com/gapple/structured-headers/runs/740498789?check_suite_focus=true

even though var_dump appears to lose a digit on PHP 7, json_encode still outputs 3 decimal digits
json_decode loses precision in PHP 7
round loses precision on both PHP 7 and 8

https://3v4l.org/teeYU

Fixed by replacing (string) $result with json_encode($result)


Unexpected behavior in Advanced Paste > Enable Paste with AI

Description of the new feature / enhancement
I had some repetitive work to do:

copy values in my German Excel file with comma as decimal separator
paste those values in Visual Studio as C# 2D array

So, I used "Advanced Paste" with "Enable Paste with AI". On the first time, I prompted "paste as C# 2D Array. Replace the comma decimal separator with the new decimal separator point".
I copied this prompt to a text file.
On the second time, I copied Excel values, opened Advanced Paste, copied the prompt and did not get my values as C# array but just the prompt.
I can fully understand, why this happens, but it is not what I expected. And I do not see a workaround for this kind of repetitive work.
What do you think about a "Prompt history"? This would make repetitive work just
Shift + Windows + V --> click
Scenario when this would be used?
repetitive work
Supporting information
No response

Custom actions were added for exactly this use-case. I'm currently working on improving the documentation to explain this better. Please let us know if this fixes your issue! /needinfo

Nice. I was not aware of this feature.
I still think a prompt history could be helpful, but yes, the custom action feature fixes my issue.


Refract login command from logic manager

Pull Request Test Coverage Report for Build 149

27 of 54 (50.0%)  changed or added relevant lines in 8 files are covered.
18 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.3%) to 80.69%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/parser/EmployeeParser.java
0
1
0.0%

src/main/java/seedu/address/logic/parser/ManagerParser.java
0
1
0.0%

src/main/java/seedu/address/logic/parser/ProManageParser.java
6
7
85.71%

src/main/java/seedu/address/logic/parser/LoginCommandParser.java
0
6
0.0%

src/main/java/seedu/address/logic/commands/LoginCommand.java
0
8
0.0%

src/main/java/seedu/address/logic/parser/DefaultParser.java
18
28
64.29%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/address/logic/parser/ManagerParser.java
18
0.0%

Totals

Change from base Build 141:
-1.3%

Covered Lines:
2081

Relevant Lines:
2579

💛  - Coveralls

Nice work. Remember to update tests.


:bug: fix(modal): backdrop is too dark

Current Behavior
On the bal-modal component we would like to see a property to customise the backdrop color.
Right now it's set to the primary brand color (#000d6e) with 0.8 opacity.
Business found that the use of modals in our lead generation apps is good but the backdrop is a little too dark.
They would like to see it lighter.
Expected Behavior
Additional property to customise either the entire color of the backdrop but this might not be desired from a design standpoint.
So maybe a property to allow different opacity levels of the primary brand color?
My proposal for this one:

Find a global solution for consistency reasons (proposing different opacities will lead to different user experience)
In order to find a compromise I would suggest to set the opacity to 0.6 (as I agree that 0.8 might be a little too dark)

Steps to Reproduce

Version
12
Browsers
No response
Device
No response
Code Reproduction URL
No response
Additional Information
created by @j
Code of Conduct

[X] I agree to follow this project's Code of Conduct

/cib


Change Listen IP and port

I have found in webpack.config.js I can change the port the server listens on, however it always starts up with <IP_ADDRESS> (localhost) as the IP to listen on. Where is the setting so I change that to another IP or <IP_ADDRESS> for all IPs?

Hi @jared-bloomer! You're right to look in webpack.config.js! Currently I'm taking advantage of a custom port setting  on line 47, this devServer block is where you could specify the host per the webpack dev server configuration: https://webpack.js.org/configuration/dev-server/ If memory serves the property can be specified there as host: '<IP_ADDRESS>' or whatever IP you desire. Then when you npm start webpack devServer should respect that setting within the devServer block just as it does for the port :+1:

Also, feel free to re-open if this doesn't work for you; the version of devServer in this project is quite old and in need of an upgrade anyway.


fix: include messages for CLA

This PR should fix the CLA signature flow.
Example: https://github.com/splunk/addonfactory-ucc-generator/pull/901

:tada: This PR is included in version 1.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Implement Sigstore TUF Client Spec

Description
The TUF client in sigstore-go is very much an MVP, and we would like to enhance it to accomplish a variety of goals:

Add the TUF Options specified in the Sigstore TUF Client specification. This includes controls for caching behavior and trusted repository mapping.
Add support for fetching arbitrary targets, including delegate targets. Notably, this client should support the npm TUF delegation.
Add API/ability to initialize multiple TUF repos in their own namespaces, given a URL and root.json, which can be used by private Sigstore instances with their own fully-contained TUF repos.

This is done in #41.

@codysoyland To confirm, "Add API/ability to initialize multiple TUF repos in their own namespaces, given a URL and root.json, which can be used by private Sigstore instances with their own fully-contained TUF repos." is supported? Slightly separate question, is concurrent multi-TUF-repo supported?

@codysoyland To confirm, "Add API/ability to initialize multiple TUF repos in their own namespaces, given a URL and root.json, which can be used by private Sigstore instances with their own fully-contained TUF repos." is supported? Slightly separate question, is concurrent multi-TUF-repo supported?

Missed your message until now! Yes, that bullet point should be supported here. If you supply a trust anchor (TUF root.json contents) to Options.Root, you can initialize your own TUF repo.
As for multi-TUF-repo, I think the answer is no -- we're not using the multirepo package, but to be honest, I'm not sure how that works exactly.

As for multi-TUF-repo, I think the answer is no -- we're not using the multirepo package, but to be honest, I'm not sure how that works exactly.

Hey @codysoyland and @haydentherapper 👋
So in general it aims to implement the following TAP - https://github.com/theupdateframework/taps/blob/master/tap4.md
The idea is that you set up your TUF client with a map.json file where you list all TUF repositories and the consensus you want them to have.
This allows you to configure various scenarios, some of which are:

For example I'd like at least <this> number of <these> TUF repos to agree on <target-file-X> before I can trust/fetch it. Assuming you have 2 Sigstore TUF repos, you can create a client that fetches a trusted-root.json as long as both of the TUF repos serve the same file. If one ends up serving different file your TUF client will consider this a vulnerability and fail to fetch it.
Another example can be having a single TUF client that fetches different target files from different TUF repositories, i.e. download all <my-vendor>-* targets from <this> TUF repo and everything else from <another>.

I don't have any information if it has been used that much yet (perhaps not), but I decided to implement it back then as it allows for some interesting configurations and use cases.

Thanks @codysoyland and @rdimitrov. For my first question, https://github.com/sigstore/sigstore-go/blob/main/pkg/tuf/client.go#L39 confirms that we cache metadata per repo URL, so we can initialize multiple repositories given a client. This should cover the use case where I want to load in a TUF from multiple sources, eg one from the public instance, one from a private instance.
Given this, I don't think we'll need to integrate with TAP-4 yet, but I am really happy to see it implemented as a standardized solution to this problem.


fix: sort and filter for every entity and pagination

Filter and sorting as well are now individual for every entity by adding the key to the table. Beforehand the filter and sorting were active for every entity.
The pagination element is now loaded when changing the entity. Beforehand it disappeared when the reset button wasn't clicked.

@mholthausen

LGTM


Uncaught TypeError w/ GRPC

The following error is occurring sporadically, and causing an unrecoverable error in our production process:
/.../node_modules/grpc/src/node/src/credentials.js:108
     callback(code, message, metadata._getCoreRepresentation());
     ^
TypeError: The callback's first argument must be a status code
   at TypeError (native)
   at /.../node_modules/grpc/src/node/src/credentials.js:108:7
   at /.../node_modules/grpc/src/node/src/credentials.js:124:9
   at /.../node_modules/google-auth-library/lib/auth/oauth2client.js:286:14
   at /.../node_modules/google-auth-library/lib/auth/jwtclient.js:138:16
   at Request._callback (/.../node_modules/gtoken/lib/index.js:220:9)
   at self.callback (/.../node_modules/request/request.js:200:22)
   at emitOne (events.js:90:13)
   at Request.emit (events.js:182:7)
   at Request.onRequestError (/.../node_modules/request/request.js:831:8)

We're using v0.33

Is there a chance you've manually installed grpc as your own dependency? It seems like a version conflict must have occurred; gcloud-node is being given the wrong version of grpc.
It might not hurt to try upgrading to the latest gcloud, v0.36.0: https://github.com/GoogleCloudPlatform/gcloud-node/releases

@NawarA I'm going to close as I can't reproduce. Please reply back if there are still issues.

Feel free to close, if issue arises in the future, we can then reopen

The same thing happens for my production environment. Am using<EMAIL_ADDRESS>and what I found odd was that two modules inside the library were using completely differenr grpc versions as follows:
+--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| | +--<EMAIL_ADDRESS>| | | +--<EMAIL_ADDRESS>| | | +--<EMAIL_ADDRESS>| | | +--<EMAIL_ADDRESS>| | | +--<EMAIL_ADDRESS>
and
| +--<EMAIL_ADDRESS>| | +--<EMAIL_ADDRESS>| | +--<EMAIL_ADDRESS>| | | +--<EMAIL_ADDRESS>| | | +--<EMAIL_ADDRESS>
How would you advice to address this issue best ?

Can you try upgrading google-cloud? We've worked to mitigate duplicate dependencies as much as possible.

Yeap, will do. Any suggestion on how issues like this could be addressed on higher application level if they arrasie in the future? My express application crashes irrecoverably and the process ends up being restarted. Maybe there's a better way of handling such errors?

I'm not sure, but I think that's a question on Express best practices, which is probably best posed to that community.


Fix connection closed on pause

Hi,
I suggest you add these two lines of code to avoid closing the ssh connection every time the application loses focus.
In my case, I used your application to test a Python code using the USB host mode API. The use of this API requires the permission of the user, so Android displays a dialog box to ask for it. And when this dialog box appears, the application is paused and this causes the connection reset.

I am confused. This got merged or not?


Document port change command

Found this after a couple hours of struggling:
react-native start --port <port_number>
Why is this not documented here? When adb reverse can be documented here, I believe this command needs to be too!

If you'd like to submit a PR adjusting the docs that would be greatly appreciated! :smile:

Omg this is a thing?!? What version was this added in?

I don't think it really makes sense for that to be in Android guide (in fact it applies to both and Simulator as well). However there's no documentation for react-native commands in one place, maybe we should add such section entirely & add links in all places?
I could submit a proposal if that makes sense to anyone.

@grabbou I'm looking for a first task and can lend a hand.  I'm compiling the flags for each command now.

Along with adding to the docs, why not add a help command to the CLI to see flags and more detailed usage information about a command?  Usage: react-native help [command].
I can take that on if it seems like a good idea.
Also, pulled all of the arguments for each command from the source:  https://gist.github.com/hedgerh/0178fe3ace33b1161949491fd0e5b649

I would say it could be --help and [command] --help if that's doable.
Gist looks good - if we can somehow get these from each command and build an interface on top of that, I think it would be really great!

How about showing it on both help and --help?  Also, when trying to figure out how to use a command, I feel like I would naturally try --help [command] or help [command].  What do you think?  I'm in favor of implementing all of our syntaxes, if that'd be okay.

if we can somehow get these from each command dynamically (so that it works in the future) and build an interface on top of that, I think it would be really great!

had the same thought, and it should be no problem :)

How about showing it on both help and --help?

I have no opinion on that to be fair, I'd say let's wait for others. I think the former approach is slightly more standardised since that's what FB follows in e.g. flowtype

Any idea how I can go about running the local-cli/react-native-cli in a local environment?

Good question. I think you can just:

clone the project into myTestApp/node_modules/react-native and just use it normally
https://github.com/facebook/react-native/tree/master/react-native-cli#running-cli-with-local-modifications
https://github.com/facebook/react-native/blob/master/react-native-cli/index.js#L80-L88

I made a first pass at this.  The following syntaxes work:
help [command]
--help [command]
[command] --help

I still need to get the output to display in a nice format, and I want to do some cleanup on some of the descriptions.  Will get back at it tomorrow.
I opened a PR on my fork for previewing:  https://github.com/hedgerh/react-native/pull/1

@hedgerh looks good!

Hey @ShashankaNataraj and @grabbou, I implemented the pretty formatting for the help printout.  I'm not sure what to put for the test plan when I open the PR, or if i need to write tests and how.  I will read up on it the next time I get a chance, but it would help move things along if someone could give me a little direction.

@hedgerh Just explain briefly how you tested it and show images of the input / output.

I think that's enough. You can also record a small video with QuickTime (if you are on Mac) to show all the possible use-cases for that command :)

Any more updates on this?

@ShashankaNataraj: The react-native CLI now has a --help command that can be used to show the different options for each command.
Usage: react-native start --help
To whom it may concern:  This issue can now be closed!e


Loading large dataset

Hello,
I have a question about loading a dataset. I have a very large dataset. A class has the dimensions 946, 2000 where a time series has a length of 2000 and the dataset has 946 trials. I also want to combine several classes with the same dimensions into one dataset. Is the to_time_series_dataset suitable for this or is there another possibility?

Hi @mmar30
Sorry for the delay in the answer. Basically, to_time_series_dataset is the only way to cast your data to an array with the correct shape. However, if the data cannot fit in memory, it is likely that you will have to work per-batch or select another toolbox, since tslearn relies on data stored in memory.
Best regards,
Romain


Change ConnOpenTry logic per ibc-rs

In ConnOpenTry handling, migrate verification logic per ibc-rs.

Possible to optimize the code snippet below?
                let mut new_connection_end;
                if Connections::contains_key(&connection_id) {
                    let old_conn_end = Connections::get(&connection_id);
                    let state_is_consistent = old_conn_end.state.eq(&ConnectionState::Init)
                        && old_conn_end.counterparty_connection_id.eq(&counterparty_connection_id)
                        && old_conn_end.counterparty_client_id.eq(&counterparty_client_id);

                    ensure!(state_is_consistent, "Local connection corrupted!");

                    new_connection_end = old_conn_end.clone();
                } else {
                    new_connection_end = ConnectionEnd {
                        state: ConnectionState::Init,
                        counterparty_connection_id,
                        counterparty_prefix: vec![],
                        client_id,
                        counterparty_client_id,
                        version: vec![],
                    };
                }


Expand and collapse menu is not working in demo and also not working in predix seed project

Is this stable plugin? if not, Please let me know

@Varunprakas - please resubmit this issue following our template, and be sure to read our contribution guidelines (https://github.com/PredixDev/px-app-nav/blob/master/CONTRIBUTING.md) before submitting an issue.


Updates to build Python 3.7

This gets Python 3.7 built using CMake, without breaking builds for 3.6, 3.5 and 2.7.
It's mainly been mainly under macOS but I've also successfully built 3.7.4 under Ubuntu 18.04 and Windows 10 (although I suspect more work is needed for Windows...).

@dand-oss, I've now merged your PR #254 into this PR.

@dand-oss, I've now merged your PR #254 into this PR.

Great, I will switch and try it out...

Closing. Changes in this PR have been integrated in #257


Remove the words "tax disc" from titles of sections and links

Tax discs aren't used anymore!
Remove the words on Make a SORN and Vehicle Tax pages.

:sunny:


chore(chat): Scroll fixes, a11y updates, colored code

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

going to merge in so we don't hold people up, but should clean up the extra examples.json file in the next PR


Adding Generic "Authorization" support for Config Client

Adds the Cloud Config Property "authorization" to the Config Client Properties
Adds a GenericAuthorization header to the restTemplate
Inspired by the Basic Authorization support
ResourceLocator uses the generic HTTP Authorization header to connect to the config server uri.
Users won't be able to set both the "password" and "authorization" at the same time.

When set, the client will use the value to create a generic Authorization header with the value provided, instead of the Basic Auth.
Discussions about this at https://github.com/spring-cloud/spring-cloud-config/issues/177#issuecomment-239076005
Client Setup

Client configuration is provided using authorization.

spring:
  cloud:
    config:
      uri: http://config.platform.company.net:8888
      authorization: Company_IAM_Authorization appid=myapp,appsecret=preprddtWGsk4WpFdL

This is very similar to the following:
curl -H "Authorization: Company_IAM_Authorization appid=myapp,appsecret=preprddtWGsk4WpFdL" \
    http://config.platform.company.net:8888/admin/env | jq

@marcellodesales Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@marcellodesales Thank you for signing the Contributor License Agreement!


fix(slice): ensure slice configure is preserved

LGTM! We can worry about the case where the image data changes later.


[WIP] feat: Pending Transaction RPC

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ X] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Testing
[ ] Other (please describe):

What is the current behavior?

Issue Number: #204
What is the new behavior?

Add starknet_pendingTransactions rpc endpoint

Does this introduce a breaking change?

[ ] Yes
[X] No

Other information

This is still a WIP, its not on its final state and its missing tests and documentation.12

I'm taking up this work


Move code out of init.py

Fixes #4552
Proposed changes:

Move code out of init.py

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Kishan Mohanbhai Sagathiya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Serial VISA device fails to open: TypeError: init() got an unexpected keyword argument 'writeTimeout'

On Ubuntu 14.04, fresh install:
pip3 install pyvisa pyvisa-py pyserial
>>> import visa
>>> rm = visa.ResourceManager("@py")
>>> rm.list_resources()
('ASRL/dev/ttyUSB0::INSTR',)
>>> dev = rm.open_resource(rm.list_resources()[0])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.4/dist-packages/pyvisa/highlevel.py", line 1644, in open_resource
    res.open(access_mode, open_timeout)
  File "/usr/local/lib/python3.4/dist-packages/pyvisa/resources/resource.py", line 203, in open
    self.session, status = self._resource_manager.open_bare_resource(self._resource_name, access_mode, open_timeout)
  File "/usr/local/lib/python3.4/dist-packages/pyvisa/highlevel.py", line 1601, in open_bare_resource
    return self.visalib.open(self.session, resource_name, access_mode, open_timeout)
  File "/usr/local/lib/python3.4/dist-packages/pyvisa-py/highlevel.py", line 191, in open
    sess = cls(session, resource_name, parsed)
  File "/usr/local/lib/python3.4/dist-packages/pyvisa-py/sessions.py", line 184, in __init__
    self.after_parsing()
  File "/usr/local/lib/python3.4/dist-packages/pyvisa-py/serial.py", line 68, in after_parsing
    self.interface = cls(port=self.parsed.board, timeout=2000, writeTimeout=2000)
TypeError: __init__() got an unexpected keyword argument 'writeTimeout'

Looking at the pyserial docs, writeTimeout has been renamed to write_timeout.

Oh, as an aside, is there a reason the timeout member is in milliseconds, rather then the float seconds value that's used in pyserial? It basically only serves to be very confusing as it is.


[Feature] partial screencapture

It would be great to select a part of the screen to record (to get it into another CLI or with within this app > for gif output)

As this is a cli program, I still haven't figured out how to do that best to still be user friendly, but also not make too much use of the mouse.
Any recommendations for how it should be done are welcome... use window id or select window via mouse or select portion of screen via mouse...
Best would be an option to tell the program via parameter what to do... Any hints?

hi, thanks for your reply.. the point is i have found similar programs such as your in the past, but never got them working due to X11 (always gave me errors while executing make).
See:

https://github.com/lolilolicon/FFcast (the original I believe)
https://github.com/minos-org/ffcast

I believe they have an option to select a screen region using the mouse or select a running application and crop the region to it (with or without padding).

Looks like there is still some work to be done on it. The cases I have identified so far are:

Record the whole monitor
Record all monitors
Record a selection (selectable via mouse)
Record a window (click on a window via the mouse)

The examples you posted (especially, the original) are pretty good to get some ideas from.
Anyway I guess the whole thing will be a major change and requires some time for planning, as I also want to support others operating systems like osx, linux and bsd.

Hi I thought back to this project when i saw a perfect implementation of this concept by cloudapp. This is ultimately how it should be ;)
see the following screencast!

btw is there an error with ffscreencast not casting the mouse?
output to gif would be incredible!

Added for future reference:
Get window dimensions:

Linux: xwininfo
OSX: TODO
BSD: xwininfo

@cytopia btw if you can figure out how to get xrectsel installed on osx, you could use this: https://github.com/lolilolicon/xrectsel
it has problems with libx11

@dimitrieh I guess it has to be something native on OSX, otherwise it will be too bothering for users to deal with it.
If somebody is willing to help with osascript or other native osx stuff, I can implement at least the select-window task.

@dimitrieh This will be addressed in #23. Please have a look there.


feat: pushList must be per request, not per object

Currently pushList is created and stored as an instance variable from
preprocessRequest(). But the list must be created for each request. To
fix that, make preprocessRequest() return a push function that is to
be used by the middleware later. And make the push() function private.
Also update README about this change. And add a link to
fastify-auto-push as an example.

This fixes #5.

Codecov Report

Merging #6 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage    92.8%   92.74%   -0.06%
==========================================
  Files           3        3
  Lines         125      124       -1
  Branches       24       24
==========================================
- Hits          116      115       -1
  Misses          9        9

Impacted Files
Coverage Δ

ts/src/index.ts
88.52% <100%> (-0.19%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd46a83...67c393b. Read the comment docs.


Implement a function collecting intervals between stack samples

Bug: http://b/240253740
Test: Unit

LGTM. In general, I prefer 1-sentence or something to describe what this will be used for in the commit message though.


Unable to create detox build for the iOS app since upgrading to 1.4.3

Hello!
I've upgraded the library from v1.4.2 and now the detox build is not working anymore.
Normal CLI build still works fine and also the build from XCode.
I'm running on a Mac Mini with M1 chip, using React Native v 0.64.2
Libtool /Documents/selfapy-mobile/ios/build/Build/Products/Staging.Release-iphonesimulator/react-native-config/libreact-native-config.a normal (in target 'react-native-config' from project 'Pods')
    cd /Documents/selfapy-mobile/ios/Pods
    export IPHONEOS_DEPLOYMENT_TARGET\=12.0
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static -arch_only x86_64 -D -syslibroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk -LDocuments/selfapy-mobile/ios/build/Build/Products/Staging.Release-iphonesimulator/react-native-config -filelist /Documents/selfapy-mobile/ios/build/Build/Intermediates.noindex/Pods.build/Staging.Release-iphonesimulator/react-native-config.build/Objects-normal/x86_64/react-native-config.LinkFileList -dependency_info /Documents/selfapy-mobile/ios/build/Build/Intermediates.noindex/Pods.build/Staging.Release-iphonesimulator/react-native-config.build/Objects-normal/x86_64/react-native-config_libtool_dependency_info.dat -o /Documents/selfapy-mobile/ios/build/Build/Products/Staging.Release-iphonesimulator/react-native-config/libreact-native-config.a
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: file: /Documents/selfapy-mobile/ios/build/Build/Intermediates.noindex/Pods.build/Staging.Release-iphonesimulator/react-native-config.build/Objects-normal/x86_64/GeneratedDotEnv.o has no symbols

** BUILD FAILED **

The following build commands failed:
        PhaseScriptExecution [CP-User]\ Generate\ Specs /Documents/selfapy-mobile/ios/build/Build/Intermediates.noindex/Pods.build/Staging.Release-iphonesimulator/FBReactNativeSpec.build/Script-1DAC18DB65FCBF8E34582CEE2E2ECEFD.sh
        CompileSwift normal x86_64
(2 failures)
detox[37119] WARN:  [build.js]

Important: 'detox build' is a convenience shortcut for calling your own build command, as provided in the config file.
Failures in this build command are not the responsibility of Detox. You are responsible for maintaining this command.

detox[37119] ERROR: [cli.js] Command failed: ENVFILE=.env.staging xcodebuild -workspace ios/Selfapy.xcworkspace -scheme SelfapyStaging -configuration Staging.Release -sdk iphonesimulator -derivedDataPath ios/build

@luancurti this issue is only happening on the ARM cpu architecture. I can confirm that the build succeeds on x86_64.

Any solution for now?

Found a solution that install Rosetta in Apple Silicon Mac
run this command to install Rosetta
softwareupdate --install-rosetta

https://osxdaily.com/2020/12/04/how-install-rosetta-2-apple-silicon-mac/
and finally it works! 👍🏻


fix: cached symlinks causing cache misses

In trying to use turborepo with a CDK app, I noticed that I never got remote cache hits for my cdk.out assets. After some digging I discovered that the issue was due to some symlink edge cases not being handled.
My changes boil down to:

Creating any nested directories for symlinks (in the same way we handle normal files)
Allowing for the overwriting of existing symlinks (by first removing any that already exist)
Keeping track of any symlinks that are attempted before the destination file has been copied out of the archive; we then loop through the missing links at the end and create them once all the normal files have been copied.

Another note: currently all of these error cases result in a silent cache miss, due to cache.go:
func (mplex cacheMultiplexer) Fetch(target string, key string, files []string) (bool, []string, error) {
	// Retrieve from caches sequentially; if we did them simultaneously we could
	// easily write the same file from two goroutines at once.
	for i, cache := range mplex.caches {
		if ok, actualFiles, _ := cache.Fetch(target, key, files); ok {
			// Store this into other caches
			mplex.storeUntil(target, key, 0, actualFiles, i)
			return ok, actualFiles, nil
		}
	}
	return false, files, nil // <------- we always drop errors from the underlying caches
}

Not sure if that's desired, but I left it as is; I wasn't entirely sure how to handle it properly anyway.

Need anything from me on this one, @jaredpalmer?


Fix authentication with integer as useridentifier

Fix authentication with integer as useridentifier caused argument type error with UserBadge (Maybe only with Symfony >= 6.0)

Good catch, mostly it will affect Symfony >= 5.2 with new authenticator system enabled.

Thank you @Floruzus.


fix: selectionLimit assets return on android

Thanks for submitting a PR! Please read these instructions carefully:

[x] Explain the motivation for making this change.
[ ] Provide a test plan demonstrating that the code is solid.
[x] Match the code formatting of the rest of the codebase.
[x] Target the master branch, NOT a "stable" branch.

Motivation (required)
Hai, im using the selectionLimit options on to limit the maximum selection file that user can do. On ios, this work fine as video below.
https://user-images.githubusercontent.com/16449020/143539168-ba2e0f49-4805-47f9-80fb-047c9a85bd72.mp4
it block the user from select more than the limit and return the selection as the limit. But on android, user can select as much as possible and the return is all the user selection.
https://user-images.githubusercontent.com/16449020/143539308-57e1b796-a018-4453-bad4-e585ed896fa0.mp4
as what i read from SO https://stackoverflow.com/questions/33604951/maximum-image-selection-limit-from-gallery-android, it need to validate again the selection file as the limit. In this PR, im improve to return only the amount of selected image as set in selectionLimit options. Please see the video below.
https://user-images.githubusercontent.com/16449020/143539552-04f9907c-8fb0-43c0-a8fd-b8b2bda32d18.mp4
Test Plan (required)

confused on how to add test

Hey, thanks for the detailed PR.
I have initial concerns about this, but more than happy to discuss.

This PR introduces a soft limit (i.e. a user will still be able to select more than the limit hit)
The code/app will only get the limit, can we guarantee order of images, etc?
User will see something different to what they selected (causing confusion)

Thoughts?

Hi, thanks for the feedbck @Johan-dutoit

yes, this pr will act as soft limit from the user selection.

For order of the image, it should be same, since im only limit the returned size without doing any sort.

For point number 3, im agree that this will lead to bad ux for the user, im looking for other native android library, and they implement their own limit on the picker. Im happy to try implement it but will take some times, since im not fluent  enough with android and java, so this is the current help that i can do.

I think this is out of scope, the Android library doesn't let you limit the number of picker images, you should do results.slice when you get the result back from the picker.


Add ability to redact specified fields in when serializing models

Feature Request
It would be extremely useful to be able to redact fields when serializing data models.  This is something that would typically be used for logging purposes when handling sensitive data and it does not appear that there is an easy way to handle this right now.  The mapping to determine excluded fields during model exporting seems like a good way to specify keys that need to be redacted, so that logic could be reused to overwrite values with redacted values.
Below is an example of how I might expect this to work
import pydantic

class Person(BaseModel):
    title: str = None
    prefix: str = None
    firstName: str
    middleName: str = None
    lastName: str
    suffix: str = None
    dateOfBirth: datetime.date = None

person = Person(firstName='Johnny', lastName='Appleseed', dateOfBirth='2000-01-01')
person.json(redacted={'dateOfBirth'})

and the output would look something like this:
{
  "firstName": "Johnny",
  "lastName": "Appleseed",
  "dateOfBirth": "REDACTED-datetime.date"
}

I am happy to work on this PR as well.

Thanks for creating the issue.
I think between SecretStr, SecretBytes and the exclude kwarg, we have this covered.
We don't need another feature.


Oauth for both enterprise install and Workspace install

Description
App install that is publicly distributed works for enterprise install using the "Add to slack" button enabled in /slack/install path of the service.
However the same does not work for workspace install.
I get a invalid signature error.
What type of issue is this? (place an x in one of the [ ])

[x] bug
[ ] enhancement (feature request)
[x] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
package version: 3.8.1
node version: 14.12.1
OS version(s): ubuntu linux
Steps to reproduce:

click the button that is displayed on /slack/install path
choose the workspace in next screen and click allow.

Expected result:
What you expected to happen
Success
Actual result:
It works fine when installed on an Organization.
But fails below when installed on workspace.
What actually happened
Oops error comes
Attachments:
Logs, screenshots, screencast, sample project, funny gif, etc.
Error stack as below...
[ERROR] OAuth:InstallProvider:0 Error: Failed to load the data represented by the state parameter (error: JsonWebTokenError: invalid signature)
at new InvalidStateError (/home/node/app/node_modules/@slack/oauth/dist/errors.js:65:47)
at ClearStateStore.<anonymous> (/home/node/app/node_modules/@slack/oauth/dist/state-stores/clear-state-store.js:70:27)
at step (/home/node/app/node_modules/@slack/oauth/dist/state-stores/clear-state-store.js:33:23)
at Object.next (/home/node/app/node_modules/@slack/oauth/dist/state-stores/clear-state-store.js:14:53)
at /home/node/app/node_modules/@slack/oauth/dist/state-stores/clear-state-store.js:8:71
at new WrappedPromise (/home/node/app/node_modules/async-listener/es6-wrapped-promise.js:13:18)
at __awaiter (/home/node/app/node_modules/@slack/oauth/dist/state-stores/clear-state-store.js:4:12)
at ClearStateStore.verifyStateParam (/home/node/app/node_modules/@slack/oauth/dist/state-stores/clear-state-store.js:62:16)
at InstallProvider.<anonymous> (/home/node/app/node_modules/@slack/oauth/dist/install-provider.js:473:62)
at step (/home/node/app/node_modules/@slack/oauth/dist/install-provider.js:44:23)
at Object.next (/home/node/app/node_modules/@slack/oauth/dist/install-provider.js:25:53)
at /home/node/app/node_modules/@slack/oauth/dist/install-provider.js:19:71

at new WrappedPromise (/home/node/app/node_modules/async-listener/es6-wrapped-promise.js:13:18)

at __awaiter (/home/node/app/node_modules/@slack/oauth/dist/install-provider.js:15:12)

at InstallProvider.handleCallback (/home/node/app/node_modules/@slack/oauth/dist/install-provider.js:433:16)

at /home/node/app/node_modules/@slack/bolt/dist/receivers/ExpressReceiver.js:175:41

at Layer.handle [as handle_request] (/home/node/app/node_modules/express/lib/router/layer.js:95:5)

at trim_prefix (/home/node/app/node_modules/express/lib/router/index.js:317:13)

at /home/node/app/node_modules/express/lib/router/index.js:284:7

at Function.process_params (/home/node/app/node_modules/express/lib/router/index.js:335:12)

at next (/home/node/app/node_modules/express/lib/router/index.js:275:10)

at Function.handle (/home/node/app/node_modules/express/lib/router/index.js:174:3)

here is the code that is used for this
const receiver = new ExpressReceiver({
	signingSecret,
	logLevel,
	clientId,
	clientSecret,
	scopes,
	stateSecret,
	installerOptions: {
		stateVerification: true,
		callbackOptions: {
			success: (installation, installOptions, req, res) => {
				// Do custom success logic here
				// console.log(installation)
				const teamId = installation.team?.id || installation.enterprise?.id
				let url
				if (installation.isEnterpriseInstall) {
					url = `https://app.slack.com/manage/${installation.enterprise?.id}/integrations/profile/${installation.appId}/workspaces/add`
				} else url = `https://slack.com/app_redirect?app=${installation.appId}&team=${installation.team?.id}`

				// <meta http-equiv="refresh" content="0; URL=https://app.slack.com/client/${teamId}/${installation.appId}">
				let html = `

Success! Redirecting to the Slack App...

				<button onClick="window.location = '${url}'">Click here to redirect</button>
				`
				res.end(html)
			},
			failure: (error, installOptions, req, res) => {
				// Do custom failure logic here
				let msg = 'Oops, Something Went Wrong! Please Try Again or contact'
				res.end(msg)
			},
		},
	},
	// redirectUri: '/slack/oauth_redirect',
	installationStore: {
		storeInstallation: async installation => {
// store to db
			// return id;
		},
		fetchInstallation: async InstallQuery => {
			try {
				// return db.getData(`/token/${InstallQuery.teamId}`);
                               // get from db and return

				}
			} catch (e) {
				logger.error(`Error in fetching ${e}`)
			}
		},
	},
})

const app = new App({
	stateSecret,
	port: PORT,
	scopes: scopes,
	signingSecret,
	clientId,
	clientSecret,
	receiver,
	logLevel,
})

Hi @udaya-reddy,
Thanks for providing the details, including the code sample and Bolt-JS version (3.8.1).
I've noticed that the error is related to JsonWebTokenError. To help us out, are you trying to authenticate with a Workspace that's part of an Enterprise organization? Or, is this a regular standalone Workspace?

This is a Org Install enabled app, trying to install for workspace.
stateVerification: false setting made it work. Hence closing this issue.

This may not be the cause of the issue that you experienced but generally speaking, we recommend using the latest version of bolt-js along with the latest underlying oauth package. If you can use more of your time for this, I would recommend upgrading bolt-js and seeing if the state verification works.

Well, even though package.json had 3.8.1 the packaga-lock.json has 3.11.0. so the latest modules were used.
The issue was the url generated had the state param that was signed by the signing secret and while verifying it was verifying with the stateSecret. this is the bug in the module.. This happened only for this app. dont know why though.

@udaya-reddy Thanks for your reply.

The issue was the url generated had the state param that was signed by the signing secret and while verifying it was verifying with the stateSecret.

This never happens as long as you go with common settings. The signing secret is used outside the OAuth installation flow. It can be used only for verifying event data requests from the Slack API server.
I tried to reproduce your situation with the following simple ExpressReceiver app. I went through both workspace-level and org-wide installations but the OAuth flow succeeded without any issues.
const { LogLevel } = require("@slack/logger");
const { App, FileInstallationStore, ExpressReceiver } = require("@slack/bolt");

const receiver = new ExpressReceiver({
  signingSecret: process.env.SLACK_SIGNING_SECRET,
  clientId: process.env.SLACK_CLIENT_ID,
  clientSecret: process.env.SLACK_CLIENT_SECRET,
  stateSecret: 'my-state-secret',
  scopes: ['commands', 'chat:write'],
  installationStore: new FileInstallationStore({}),
});

const app = new App({
  logLevel: process.env.SLACK_LOG_LEVEL || LogLevel.DEBUG,
  receiver,
});

(async () => {
  await app.start(process.env.PORT || 3000);
  console.log("⚡ Bolt app is running!");
})();

If you find the steps to reproduce the situation, sharing it with us would be appreciated.


e2e: WithOffset -> GinkgoHelper

rather than use WithOffset variants, which composes badly, let's leverage ginkgo.GinkgoHelper() to achieve the same result in a more composable and easier way.

/lgtm

/test ci-install-e2e

/lgtm


Add schema link, and fix #1380 and #1381

Fixes #1380
Fixes #1381

Hi David- thanks! Looks good to me


alt-da devnet with eigenda proxy

#1 was not working for me, so I updated the develop branch here to latest optimism develop branch (which has some fixes for the devnet), and cherry-picked @epociask's commits.
Updates:
Added grafana panels for batcher in 031ae0c:

Closing in favor of #4


Increment version for servicebus releases

Increment package version after release of Azure.ResourceManager.ServiceBus

/check-enforcer override

Failure is unrelated to these changes.  Merging.


Add isort

isort is a linter that complements black and helps keeps imports nicely formatted: https://pycqa.github.io/isort/
Mainly, it splits imports into 3 groups: builtins, third party (e.g. torch), first party (i.e. nerfstudio). It enforces proper spacing between these groups, combines multiple imports from the same module into one line, alphabetizes them, and respects line-length by splitting long import statements into multiple lines.

Can we use ruff's import sorting instead? I think this is the more future-proof option.
(similarly, we could drop black in favor of ruff format)


Remove docs for enrichmentFpdModule

enrichmentFpdModule was moved into core in 7.29 with a blank module left for backwards compatibility. With 9, it was removed entirely.

Ah damn. I didn't see it was on hold @ChrisHuie . Any reason for that?

@muuki88 just didn't know if we wanted to delete the file or somehow archive it. No big deal

If the module was irrelevant for two major versions, it's okay to remove it, I guess 😁


Fix building of qmake based projects on linux (including qt5 modules)

This PR should fix #5362.

this PR needs #5293 because of qt5.12.1 in the modular script file

Will close this since #5624 should include the changes made here


"utils" import problem

There's a small issue in the RAIL evaluation demo with the first cell of imports:
"from utils import ... " does't work, & as discussed with Alex & Prof. Mandelbaum, it should be either rail.core.utils or rail.evaluation.utils .

I think there is a chance it is actually a utils module that was in the examples area.On Jun 30, 2023, at 7:46 PM, alice-crafford @.***> wrote:
There's a small issue in the RAIL evaluation demo with the first cell of imports:
"from utils import ... " does't work, & as discussed with Alex & Prof. Mandelbaum, it should be either rail.core.utils or rail.evaluation.utils .
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

To fill in some context, there are several modules in src/rail/* called "utils", which isn't a great practice in general and can make it confusing for users to troubleshoot errors and import issues. The fix will be for us to make sure those modules have distinct and descriptive names.

rail/examples/evaluation_examples/utils.py (This seems to have a lot of overlap with rail_base/src/rail/evaluation/metrics/pointestimates.py so could maybe be trimmed down to just be rail/examples/evaluation_examples/dc1_shortcut.py or something like that.)
rail_base/src/rail/evaluation/utils.py (I think it would be fair to call this rail_base/src/rail/evaluation/aggregators.py since it's just about combining outputs of closely related metrics into single objects so stages can write them to a single file, yes? It would not be unreasonable to use something like that to reconcile wanting the freedom to not calculate every single metric and wanting multiple metrics written to a single output file.)
rail_base/src/rail/core/utils.py (I think it would be appropriate to call this rail_base/src/rail/core/path_utils.py since that's what's in it, but that would have implications for the next one.)
rail_bpz/src/rail/bpz/utils.py (This lives in one of those inconsistent paths I mentioned in #23 BTW. In any case, unless the namespace magic interprets two files of the same name at the same path in different packages to be the union of their contents, if we expect different standalone packages to have to define something like this, then the above proposal should instead be rail_base/src/rail/core/path_utils/find_rail_file.py and this one should be moved to rail_bpz/src/rail/core/path_utils/bpz_path.py.)
rail_base/src/rail/core/utilStages.py (This is good but should be changed to rail_base/src/rail/core/util_stages.py for consistency.)
rail_base/src/rail/core/algo_utils.py (Not problematic, although I still don't understand why this and the files at the paths it specifies aren't in rail_base/tests because it only pertains to functionality needed for unit tests.)
rail_gpz_v1/src/rail/estimation/algos/_gpz_util.py (I induced this one but can rename it rail_gpz_v1/src/rail/estimation/algos/_gpz_utils.py for consistency with the others.)

Ok, I've made new issues for the things that ones that aren't particularly disruptive.

Can we close this now?

Thanks @eacharles for working through this while I was out! Please tell me if my understanding of the current status is correct:

[ ] rail/examples/evaluation_examples/utils.py sounds like it's no problem to rename (or merge into the one notebook that uses it, although it might be a lot of function definitions to put into a demo); it makes sense for this to be a part of LSSTDESC/rail_base#14 since the one demo that uses it will undergo some refactoring for that anyway, but it could just as easily be a separate issue if you prefer
[X] rail_base/src/rail/evaluation/utils.py -> rail_base/src/rail/evaluation/stats_groups.py  is completed
[ ] rail_base/src/rail/core/utils.py and rail_base/src/rail/bpz/utils.py seem tangled up with #23 so would be better discussed there
[X] rail_base/src/rail/core/utilStages.py -> rail_base/src/rail/core/util_stages.py is completed
[X] rail_base/src/rail/core/algo_utils.py needs no change -- thanks for the explanation!
[ ] rail_gpz_v1/src/rail/estimation/algos/_gpz_util.py -> rail_gpz_v1/src/rail/estimation/algos/_gpz_utils.py can move forward with a fresh issue
[X] rail_astro_tools/src/rail/tools/utilPhotometry.py -> rail_astro_tools/src/rail/tools/photometry_utils.py is completed

Is that accurate? If so, I'll fix the rail_gpz_v1 one and close this issue.

yes, that is accurate.


[HUDI-3251] Add HoodieFlinkSource for flink datastream api

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
Add Call Produce Command for spark sql
link: HUDI-3251
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

hi @danny0405 Have time to help me review this PR?

hi @danny0405 Have time to help me review this PR?

Thanks for the contribution, why we change HoodieTableSource into HoodieTableSourceContext ?

hi @danny0405 Have time to help me review this PR?

Thanks for the contribution, why we change HoodieTableSource into HoodieTableSourceContext ?

Because I need to use some methods in HoodieTableSource to construct HoodieFlinkSource to use.

@danny0405 : A reminder to review the patch whenever you can.

Generally i'm not in favor of this change very much, what is the general purpose of this patch ? Do we want to add a tool to construct the pipelines for datastream users ? If that is the goal, can add a builder to Pipelines meet your requests ?

hi @nsivabalan @danny0405 I will resubmit this patch at a later time, I will temporarily close it.

@XuQianJin-Stars can you post here when you resubmit a pr to address this?  we use flink w/ datastream api, and need/want to read/write with hudi in those streams.


[WIP]add full communicator factory class

implemented obtaining IP(which is at Nov3(getClientInfo)) and port functionality

Done changing Communicator factory class
which Fixes convict-git/KoraKaagaz#79

As discussed ClientInfo class is added on the same PR, this also Fixes convict-git/KoraKaagaz#81

 ICommunicator


Add save prompt when closing requests from tab context menu

I have checked the following:

[X] I've searched existing issues and found nothing related to my issue.

Describe the feature you want to add
In current version of Bruno (1.30.1), when closing a tab of a request with unsaved changes, that request is saved automatically. Other parts of the app show a different behavior though: when closing requests with pending changes clicking the close icon or trying to close the entire app, the user is prompted if wishes to save these changes before continuing.
I think Bruno could keep this behavior consistent throughout the application.
Mockups or Images of the feature
When closing a single request:

When closing multiple requests:

+1


[docs] Fix composition render prop example for internalState naming

Fixes render prop example to match variable and naming from other examples.

[X] I have followed (at least) the PR section of the contributing guide.

Thanks @ericchernuka. First contribution goes to you 🥇
Can you change it to state on both lines?

You bet. I saw some other internalState naming. Want me to change them all?


flutter run on MacOS for iOS appears to hang (but eventually completes)

The first time I build an app, flutter run just seems to hang after giving some obscure error message (something from FlutterDynamicsServiceLoader.mm). Eventually though (after I have up waiting) it completes and everything is fine.
We should make it faster.
We should also give progress while it's doing whatever it's doing so that you don't time out while waiting.
Steps:
flutter create testapp
cd testapp
flutter run

Actually I'm wrong. It's just hanging.

duplicate of #5398
d2b3976110508016a9dbaf73d94145b2163a3b06 is the commit this started happening

Thanks drew.


Windows support

For windows support, we need a maintainer that uses Windows, that can take care of the windows implementation of aperture.
From @CodeTheory comment

For now, I don't think we can maintain this without a contributor that has windows. I'll be building a PC at some point this year and then I can maintain it, but for now I don't think we can support it properly. 😢
There are people who want this (see our most popular Kap issue) but no one interested in maintaining it. It has to go hand-in-hand.

Apps like kap would use this to become cross-platform.
Here's a PR which could be used as a starting point

Hello, i recently came across Kap, as i was browsing @sindresorhus projects and saw that it was macOS only (i undestand why, windows is trash for developing). I started looking for libraries that could be used to record screen but apparently all of  them for some reason use 90% CPU and record only like 10FPS.
I have started implementing a similar screen recorder as aperture, and once i finish it, i would be glad to maintain the Windows side of things..

+1

Hey, I'm not sure if this helps in any way to this project but I faced the same performance troubles with generic screen capture methods (on Windows) and decided to roll my own code for capturing screenshots and recording/encoding the screen.
It's all on the Captain app but I'm planning to move all the capture/recording/encoding code to a homonymous C# library that could be more or less easy to integrate with Node.js.
For achieving extra performance, it uses DXGI Desktop Duplication on modern Windows and falls back to Direct3D 9 or GDI (which are less performant but still working). Video encoding is done using native Media Foundation which is hardware accelerated and very performant in many cases (i.e. capturing and encoding is all done on the GPU whenever possible)
However, it all requires a lot of work and polish, but it works.

Closing as it's not something we intend to do. Just make a different npm package.


Add new 'Modernization & Migration' category

Signed-off-by: mrizzi<EMAIL_ADDRESS>Thanks submitting your Operator. Please check below list before you create your Pull Request.

Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.

My team is going to submit the Migration Toolkit for Applications (https://github.com/windup/windup-operator) community-operator.
It belongs to the category of tools that support product/project managers, developers and operational teams to modernize and migrate their resources (VMs, containers, applications).
So we would like to have the Modernization & Migration category added.
New Submissions

[ ] Does your operator have nested directory structure?
[ ] Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
[x] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want use semantic versioning order?
[x] Is your submission signed?

Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Submit operators to both upstream-community-operators and community-operators at once
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description about the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

@J0zi and @mvalarh wdyt about adding this new category?
We're looking forward to get your opinions before opening the PR to add our operator

This functionality (adding more categories) will be available soon. Watch out for an update next week.

@mrizzi, we are blocked by https://github.com/operator-framework/operator-registry/issues/538

@mrizzi, please do not edit file from docs. We recently added custom category feature. Please change this PR to edit categories.json. In the next PR, you can change category in your operator.

@mrizzi, please do not edit file from docs. We recently added custom category feature. Please change this PR to edit categories.json. In the next PR, you can change category in your operator.

Thanks @J0zi for the update: I'm going to open a new PR following the new approach.

Thanks @J0zi for the update: I'm going to open a new PR following the new approach.


Assert that Runnable does not throw exception.

Summary
Create an assertion type that takes a Runnable and validates that the Runnable does not throw an exception.
Current solution
@Test
public void whenZeroDoesNothing() {
    try {
        throwExceptionIfHigherThanZero(0);
    } catch (Exception e) {
        fail("Should not throw exception");
    }
}

@Test
public void whenHigherThanZeroThrowsException() {
    assertThatThrownBy(() -> throwExceptionIfHigherThanZero(1));
}

private void throwExceptionIfHigherThanZero(int i) {
    if(i > 0) {
        throw new RuntimeException();
    }
}

Proposed (naming is not permanent)
I am not sure about the naming of such method, below is just a proposed naming.
@Test
public void doesNothingWhenZero() throws Exception {
    assertThatCallable(() -> throwExceptionIfHigherThanZero(0)).doesNotThrow();
}

#901 has just been integrated providing this feature:
// obviously fails:
assertThatCode(() -> { throw new Exception("boom!"); }).doesNotThrowAnyException();

this will be available in the next release

I guess I can close this one then.

Yes, thanks for the information.


Spelling mistake in codestyle guidelines

"Use spaces before the argument list of a function definition.
E.g. fuction func ( var1, var2 )."
A "n" is missing.

To add to this there is also this part:
local tbl2 = { "Multi-line", 2, lastVal }
which is not in a code block.

Wondered how long until somebody noticed it in an issue. It's been known for a while, not too critical.


"Done" button is blocked with (0/0) followed. The "Done" button is at the top of filteredMap page

When I right-click the link between user and tomcat, choose "Filter Transaction", I would be blocked at "Done", which is the button at the top of page. Behind the "Done" element is " (0/0)". Who can tell me why is ‘(0/0)’ here?
Many thanks.

I solved the above problem by building with the latest code in git, not in releases. But I got another problem:
When I right-click the link between user and tomcat, choose "Filter Transaction", but I was blocked at "Done". Behind the "Done" element is " (0/0)". Who can tell me why is ‘(0/0)’ here?

Hi guzy, thanks for the detailed explanation.
We'll take a look at the issue and follow up if we find out anything.

Seems like a bug on our end.
Issue reported to @denzels, he'll push a fix for it soon.
Thank you very much for reporting!

loading icon bug fixed, closing issue.
If you've more questions, feel free to reopen the issue.
Thanks again.


fix: update to eye v10.2.12

fix: update to eye v10.2.12

:tada: This PR is included in version 15.2.12 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v15.2.12

Your semantic-release bot :package::rocket:


Copy editing :)

Thanks for your PR!
Spaces are kinda important in the doc.txt. Especially in tables, assembly snippets and different tables. Can you please fix those?

I think I've fixed it :)


Undo nightly fix

Nightly builds are now working again, so I undid the fix mentioned here:
https://github.com/pandas-dev/pandas-stubs/pull/515/files#r1082764369
But the new builds uncovered additional issues, which this PR now fixes.

Thanks @Dr-Irv


labels do not match images in the cropping results (UNETER-BTCV tutorial)

Describe the bug
I visualize the image-label patch pairs in the following tutorial.
https://github.com/Project-MONAI/tutorials/blob/master/3d_segmentation/unetr_btcv_segmentation_3d.ipynb
It seems that the label does not match the images. Some examples are provided as follows

To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/Project-MONAI/tutorials/blob/master/3d_segmentation/unetr_btcv_segmentation_3d.ipynb
After finishing the data loading, run commands

case_num = 0
crop_id = 1
img_name = os.path.split(train_ds[case_num][crop_id]["image_meta_dict"]["filename_or_obj"])[1]
label_name = os.path.split(train_ds[case_num][crop_id]["label_meta_dict"]["filename_or_obj"])[1]
img = train_ds[case_num][crop_id]["image"]
label = train_ds[case_num][crop_id]["label"]

img_shape = img.shape
label_shape = label.shape
print(f"image shape: {img_shape}, label shape: {label_shape}")
plt.figure("image", (18, 6))
plt.subplot(1, 2, 1)
plt.title(img_name)
plt.imshow(img[0, :, :, 36].detach().cpu(), cmap="gray")
plt.subplot(1, 2, 2)
plt.title(label_name)
plt.imshow(label[0, :, :, 36].detach().cpu())
plt.show()

Probably you run into this issue https://github.com/Project-MONAI/MONAI/discussions/2827

Hi @wyli ,
The problem has been fixed! Thanks for your help very much:)
I started to learn MONAI during the past few months. It is extremely flexible and I enjoy using it very much.
Thank you and your colleagues for this awesome work!
Kindest regards,
Jun


Feat:Add the hover effects  for images on the get started page

Describe the feature
@dakshsinghrathore I want to add the hover effects for images on the get started page to make it attractive!!
Add ScreenShots
Like This....!!
https://github.com/dakshsinghrathore/Brighter-Beginnings/assets/120392487/0b9dc5c2-c15b-49ac-8fa0-26ce164d724a
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a SWOC24 contributor
[X] I want to work on this issue

Hey @dakshsinghrathore can you please assign this issue to me??

@Tanishka023 we as project admins have been instructed to assign issue on first come first serve basis, kindly create new issues to work on or wait for a while will be creating beginner friendly issues soon.

Assigned this issue to @Prutha-Upadhyay , kindly drop a star on this repo
HAPPY CODING !

@Tanishka023 we as project admins have been instructed to assign issue on first come first serve basis, kindly create new issues to work on or wait for a while will be creating beginner friendly issues soon.

Okay! @dakshsinghrathore