Contract, Deployment and Code Formatting updates

What does this pull request do? Explain your changes. (required)

Specific updates (required)

changed migrate function in L1Migrator to be payable
fixed deployment scripts for L1Escrow
redeployed contracts and updated deployment data
added migrate script for e2e testing of migration

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

[x] README and other documentation updated
[x] All tests using yarn test pass

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
129

Relevant Lines:
129

💛  - Coveralls

For future reference:
When there are formatting changes i.e. because we ran a formatting tool like prettier, I recommend having a commit specifically for formatting changes and then logical changes in additional commits. This commit structure can help a reviewer quickly distinguish between formatting changes vs. logical changes since the reviewer can skim a formatting change knowing that its only supposed to have formatting changes and then dig into additional commits with the actual logical changes.


Add s2_l2a_c1 product for indexing on Prod

I don't think docker-compose needs to be installed - it was working previously. But looks like it's migrated to v2 since April 2024
just modify docker-compose to docker compose and it should work
https://github.com/orgs/community/discussions/116610
https://docs.docker.com/compose/migrate/


fix: Make Background Size Flexible

This PR Resolves #42, It makes the size of the background flexible to the content and sets it minimum to 100vh to avoid the multi-background color issue.
Before (At Bottom)

After

Next time I will raise my standards and contribute something more meaningful. :)


Automatic release

create and push a new release every time a PR is merged
some kind of github action?

https://gist.github.com/UVLabs/b5c3fc41eabee38b0601824aec0e97a0


Math is difficult to implement

In Python it's possible to write just this:
3 * x**2 - 4*x + 5
With Candle it currently looks like this, which is difficult to read and write:
Ok((&(&(&x.powf(2.0)? * 3.0)? - &x * 4.0)? + 5.0)?)

Why does everything return a Result? I assume the reason is that the GPU connection might fail, but in that case maybe it's okay to panic the whole application?
Why is Tensor not Copy? It's an Arc, so it would be okay in theory.
A few more traits can be implemented to make it look like this: 3.0 * x * x - 4.0 * x - 5.0

I wrote an example here:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=e5abf73c9e38fb6cef2c17b5a1898a29

Yes the syntax is cumbersome, we have some ideas that should slightly improve it though it will not be as simple as the version you suggest. To answer your points:

All the ops may indeed fail, the most common thing is not really the GPU going down but more the GPU running out of memory, using invalid shape, etc.
I don't think a Tensor could be copy, copy implies that you can just do copy the immediate memory representation (see here) which isn't the case for Arc. Hence Tensor is only clone - and the clone op is pretty inexpensive.

Both of these are actually already done :)

Oh that's great, maybe I was using an old version, or it only worked one way.

It looks like Tensor + Result is implemented, but not Result + Tensor or Result + Result.
I have another related problem: I'm unable to write a rusty variant for modifying a single index:
var[2, 3] += 1, is there a method that can help me with that?

Re Result + Result I think this is because of the foreign trait limitation of rust so not much that we can do here.
Re assigning single values in place, we don't really have an op to do this and it's on purpose as these tend to be really inefficient so we prefer favoring more functional approaches and avoiding accessing data by index. I don't think this has been an issue for all the models we've been looking at so far but if there are some specific models for which this would be a limitation, certainly curious to hear about them.

Sorry, you are correct on the Result+Result, but the other combinations will work, as you can see in my example. An idea to even allow result+result is to have all operations return Tensor, but hide the Result internally and only expose it with some getter methods.
I am redoing the "Neural networks from zero to hero" with Candle and one of the first things is building a character combination count matrix (https://youtu.be/PaCmpygFfXo?feature=shared&t=574).
Anyway, thanks for your quick answers!

most common thing is not really the GPU going down but more the GPU running out of memory, using invalid shape

These sound like unrecoverable errors, so it could be okay to panic in these cases?

Just to chime in some ideas/opinions:
To somewhat alleviate the trouble with rusts foreign trait limitation it's possible to create create a wrapper type that can be used to wrap any type we want to be able to use as the lhs of an operation, for example like this
use candle::Result;

struct Wrapper<T>(T);

trait Wrap: Sized {
    fn w(self) -> Wrapper<Self> {
        Wrapper(self)
    }
}

impl Wrap for f64 {}

impl<T> Add<Tensor> for Wrapper<T>
where
    Tensor: Add<T, Output = Result<Tensor>>,
{
    type Output = Result<Tensor>;
    fn add(self, rhs: Tensor) -> Self::Output {
        rhs + self.0
    }
}

let t = Tensor::new(&[2f32], &Device::Cpu).unwrap();
let result = 1.0.w() + t;

this still isn't very ergonomic because after the first operation you get a Result so
let result = 2.0.a() + t + 3.0;

doesn't work. Instead you would need to do
(2.0.a() + t)? + 3.0;

or you also implement Wrap for Result<Tensor>, which doesn't gain us much though:
(2.0.a() + t).a() + 3.0;

I do like this idea:

hide the Result internally and only expose it with some getter methods.

this would allow for more ergonomic math and allow users to choose when they want to return early due to an error (if at all). I believe Rust's track_caller can be used to track the location of where the error actually happened, so we wouldn't lose that information
I haven't felt the need for tensors being Copy personally, but it could be achieved by having some global state hold all the information of the tensors and making the tensors themselves ids for retrieving that information. This is commonly done in rust whenever you want a type to be Copy for ergonomic reasons, for example in sycamore's reactive systems.

Making tensors Copy could be achieved by having some global state hold all the information of the tensors and making the tensors themselves ids for retrieving that information. This is commonly done in rust whenever you want a type to be Copy for ergonomic reasons, for example in sycamore's reactive systems. Of course this comes along with all of the caveats of dealing with global state.
I do like this idea:

hide the Result internally and only expose it with some getter methods.

this would allow for more ergonomic math and allow users to choose when they want to return early due to an error (if at all). I believe Rust's track_caller can be used to track the location of where the error actually happened, so we wouldn't lose that information.

100% on this. Having implemented a few servers, panicking is not great !

Trying my first hand at math with candle, and just ran into something... is Add only available really for f64? Not u32, etc?

Trying my first hand at math with candle, and just ran into something... is Add only available really for f64? Not u32, etc?

Right, it's just a convenient shortcut. If you want to add an u32, you can do something like tensor.broadcast_add(&Tensor::new(42u32, tensor.device())?)?.

 I’m so confused… completely forgetting I could just create a single value tensor lol

Oh, I currently use tensor.affine(1., 42.)? lol.

I've worked on a wrapper type around Result called MTensor ("Maybe Tensor") that allows simpler math: https://github.com/timokoesters/candle/blob/f457844f6f0435f748a2967b9b04d0f554adfd37/candle-core/src/mtensor.rs#L211-L222
@LaurentMazare Can you take a look? Is that something that could be merged into Candle?
PS: It relies on this unstable feature https://github.com/rust-lang/rust/issues/84277, hopefully it will work in stable rust soon.


bug in megengine

when ./scripts/cmake-build/host_build.sh -c
CMake Error at cmake/cudnn.cmake:31 (message):
  Can not find CuDNN Library

Did you install CuDNN library and configure your environ in the right way?


HTTP 404 Error on arte.tv

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2022.04.08 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
Tried to download Video, URL:
https://www.arte.tv/de/videos/108825-000-A/heller-weg/
gives this verbose error:
Verbose log
yt-dlp "https://www.arte.tv/de/videos/108825-000-A/heller-weg/" -vU
[debug] Command-line config: ['https://www.arte.tv/de/videos/108825-000-A/heller-weg/', '-vU']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2022.04.08 [7884ade65]
[debug] Python version 3.10.4 (CPython 64bit) - Linux-5.15.0-27-generic-x86_64-with-glibc2.35
[debug] Checking exe version: ffmpeg -bsfs
[debug] Checking exe version: ffprobe -bsfs
[debug] exe versions: ffmpeg 4.4.1 (setts), ffprobe 4.4.1, rtmpdump 2.4
[debug] Optional libraries: brotli, certifi, Cryptodome, secretstorage, mutagen, sqlite, websockets
[debug] Proxy map: {}
Latest version: 2<IP_ADDRESS>, Current version: 2022.04.08
yt-dlp is up to date (2022.04.08)
[debug] [ArteTV] Extracting URL: https://www.arte.tv/de/videos/108825-000-A/heller-weg/
[ArteTV] 108825-000-A: Downloading JSON metadata
ERROR: [ArteTV] 108825-000-A: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "/home/eugen/.local/lib/python3.10/site-packages/yt_dlp/extractor/common.py", line 641, in extract
    ie_result = self._real_extract(url)
  File "/home/eugen/.local/lib/python3.10/site-packages/yt_dlp/extractor/arte.py", line 57, in _real_extract
    info = self._download_json(
  File "/home/eugen/.local/lib/python3.10/site-packages/yt_dlp/extractor/common.py", line 1029, in _download_json
    res = self._download_json_handle(
  File "/home/eugen/.local/lib/python3.10/site-packages/yt_dlp/extractor/common.py", line 1008, in _download_json_handle
    res = self._download_webpage_handle(
  File "/home/eugen/.local/lib/python3.10/site-packages/yt_dlp/extractor/common.py", line 800, in _download_webpage_handle
    urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data, headers=headers, query=query, expected_status=expected_status)
  File "/home/eugen/.local/lib/python3.10/site-packages/yt_dlp/extractor/common.py", line 785, in _request_webpage
    raise ExtractorError(errmsg, cause=err)

  File "/home/eugen/.local/lib/python3.10/site-packages/yt_dlp/extractor/common.py", line 767, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/home/eugen/.local/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 3601, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python3.10/urllib/request.py", line 525, in open
    response = meth(req, response)
  File "/usr/lib/python3.10/urllib/request.py", line 634, in http_response
    response = self.parent.error(
  File "/usr/lib/python3.10/urllib/request.py", line 563, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.10/urllib/request.py", line 496, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.10/urllib/request.py", line 643, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found
`

#3622

Duplicate of #3622


Update README.md

Updated the README.md file with info about the project & how to contribute.
For a quick view of the updated file, check out my forked repo.

Glad someone finally did this. I had considered doing it last weekend, but I didn't want to make any assumptions about what @JesseRWeigel would want. I'm happy that you took on the task @kukiron after he asked for help with it.
One suggestion would be to add a link to the docs that were in the README.md originally.

Added the link to Create React App user guide.
Thanks for the suggestion.

Thanks @kukiron ! This is awesome!


Document the update process

We need to document the process of backporting resources from chef/chef to compat_resource.

right now its best just to ask me or thom, and i'd like to change everything about it


Fix command for running tests

Output for composer test:
> ./vendor/bin/phpunit
'.' is not recognized as an internal or external command,
operable program or batch file.
Script ./vendor/bin/phpunit handling the test event returned with error code 1

The ./ part is not necessary on any platform, and the / cause problems on Windows, and in any case, none are required due to Composer's PATH handling

Great catch. Thanks @cookieguru!


RA reports incorrect-ident-case on extern C fn declarations

RA will report that functions in an extern "C" block should have a camel case name. Eg: that you should rename SDL_Init to s_d_l_init.
Clearly this is just a completely wrong thing to suggest.

Rust-analyzer doesn't yet fully support #[allow].

This isn't an issue of allow. This should not generate a message even with no allows at all.
Changing the name of the function in the extern block changes what external function is searched for and linked against. You'd just get link errors for trying to link against functions that don't exist. It's just plain an incorrect suggestion for RA to make at all.


Swish, Exponential, Hard Sigmoid Activation Functions

Pull Request Overview
Improvment in adding more activation functions from tensorflow
Is this a breaking change?
No
Are all new or changed code paths covered by unit testing?
Yes
A complete listing of issues addressed or closed with this change.
None
A complete listing of any enhancements provided by this change.
Implementation of the follwing activation functions:

Swish
Exp
Hard Sigmoid

Any usage details developers may need to make use of this new functionality.
No additional usage details
Does additional documentation need to be developed beyond what is listed in your Pull Request?
No additional documentation needed
Any other salient points of interest.
No

@SheepSeb Thank you for your contribution, we'll review it as soon as possible and merge soon.


advance Search add on search page

References

Fixes DSpace/DSpace#8431 (if this fixes an issue ticket)

Description
The operator drop-down list should have four values: Contains, Not Contains, Equals, and Not Equals.
The operator drop-down list should move above the text field in the Advanced Search section.
The advanced search options should be removed from individual facets (Author, Subject, etc)
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:

First, ...
Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[ ] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

@GauravD2t : Was this PR created on purpose or accidentally?  Please make sure to add a description to all PRs (this PR has no description or details on how it works or how to test it).  Also please make sure to link all PRs back to the issue they fix.  Is this maybe related to part of the work in https://github.com/DSpace/DSpace/issues/8431??  It's unclear to me.

i had update PR of https://github.com/DSpace/dspace-angular/pull/2222

@GauravD2t : Just an quick note... this is failing all tests cause of a build error.  Here's the error reported from our GitHub CI build process when yarn test is run:
Error: Error: src/environments/environment.test.ts:316:3 - error TS[23](https://github.com/DSpace/dspace-angular/actions/runs/5155319426/jobs/9284845360?pr=2222#step:11:24)22: Type '{ production: false; universal: { preboot: true; async: true; time: false; }; ui: { ssl: false; host: string; port: number; nameSpace: string; baseUrl: string; rateLimiter: { windowMs: number; max: number; }; useProxies: true; }; ... 22 more ...; advancefilter: { ...; }[]; }' is not assignable to type 'BuildConfig'.
  Object literal may only specify known properties, and 'advancefilter' does not exist in type 'BuildConfig'.

316   advancefilter: [
      ~~~~~~~~~~~~~~~~
317     { filter: 'title' },
    ~~~~~~~~~~~~~~~~~~~~~~~~
...
320     { filter: 'entityType' }
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
321   ]
    ~~~

https://github.com/DSpace/dspace-angular/pull/2608


Clean up pages to improve memory use

Codecov Report

Merging #25 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   91.51%   91.52%   +0.01%
==========================================
  Files          19       19
  Lines         790      791       +1
==========================================
+ Hits          723      724       +1
  Misses         67       67

Impacted Files
Coverage Δ

src/formats/pdf.js
75.00% <100.00%> (+0.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4add51e...50954fd. Read the comment docs.


Gym fails code signing on jenkins, works fine on my local mac

Gym fails code signing on jenkins, works fine on my local mac
match works fine and i have confirmed that the certs and provisioning profiles are downloaded on the jenkins machine. here is the output from jenkins
[Fastlane Beta] $ /bin/bash -l /Users/Shared/Jenkins/tmp/hudson6564499071906493283.sh
[07:50:45]: -----------------------------
[07:50:45]: --- Step: update_fastlane ---
[07:50:45]: -----------------------------
[07:50:45]: Looking for updates for fastlane...
[07:50:51]: Nothing to update ✅
[07:50:51]:
[07:50:51]: Please help us test early releases of fastlane by opting into nightly builds 🌃
[07:50:51]: Just replace your update_fastlane call with
[07:50:51]:
[07:50:51]: ▸ update_fastlane(nightly: true)
[07:50:51]:
[07:50:51]: Nightly builds are reviewed and tested just like the public releases 🚂
[07:50:51]:
[07:50:51]: -------------------------------------------------
[07:50:51]: --- Step: Verifying required fastlane version ---
[07:50:51]: -------------------------------------------------
[07:50:51]: Your fastlane version 2.41.0 matches the minimum requirement of 2.39.2  ✅
[07:50:51]: ------------------------------
[07:50:51]: --- Step: default_platform ---
[07:50:51]: ------------------------------
[07:50:51]: Driving the lane 'ios beta_jenkins' 🚀
[07:50:51]: ---------------------------
[07:50:51]: --- Step: setup_jenkins ---
[07:50:51]: ---------------------------
+-----------------------------+---------------+
|      Summary for Setup Jenkins Action       |
+-----------------------------+---------------+
| result_bundle               | false         |
| force                       | true          |
| unlock_keychain             | true          |
| add_keychain_to_search_list | replace       |
| set_default_keychain        | true          |
| set_code_signing_identity   | true          |
| output_directory            | ./output      |
| derived_data_path           | ./derivedData |
+-----------------------------+---------------+
[07:50:51]: Set output directory path to: "/Users/Shared/Jenkins/Home/workspace/Fastlane Beta/output".
[07:50:51]: Set derived data path to: "/Users/Shared/Jenkins/Home/workspace/Fastlane Beta/derivedData".
[07:50:51]: -------------------------------------
[07:50:51]: --- Step: Switch to ios test lane ---
[07:50:51]: -------------------------------------
[07:50:51]: Cruising over to lane 'ios test' 🚖
[07:50:51]: ------------------
[07:50:51]: --- Step: scan ---
[07:50:51]: ------------------
[07:50:51]: $ xcodebuild -list -project ./WRHPS.xcodeproj
[07:50:52]: $ xcodebuild -showBuildSettings -scheme WRHPS -project ./WRHPS.xcodeproj
[07:50:52]: Found simulator "iPhone 5s (10.3)"
[07:50:52]: $ xcodebuild -list -project ./WRHPS.xcodeproj
[07:50:53]: $ xcodebuild -showBuildSettings -scheme WRHPS -project ./WRHPS.xcodeproj
[07:50:54]: Found simulator "iPhone 5s (10.3)"
+------------------------+----------------------------------------------------------------+
|                                 Summary for scan 2.41.0                                 |
+------------------------+----------------------------------------------------------------+
| clean                  | true                                                           |
| project                | ./WRHPS.xcodeproj                                              |
| scheme                 | WRHPS                                                          |
| skip_build             | false                                                          |
| output_directory       | /Users/Shared/Jenkins/Home/workspace/Fastlane Beta/output      |
| output_types           | html,junit                                                     |
| buildlog_path          | ~/Library/Logs/scan                                            |
| include_simulator_logs | false                                                          |
| derived_data_path      | /Users/Shared/Jenkins/Home/workspace/Fastlane Beta/derivedData |
| open_report            | false                                                          |
| skip_slack             | false                                                          |
| slack_only_on_failure  | false                                                          |
| use_clang_report_name  | false                                                          |
| fail_build             | true                                                           |
| xcode_path             | /Applications/Xcode.app                                        |
+------------------------+----------------------------------------------------------------+
[07:50:54]: $ set -o pipefail && env NSUnbufferedIO=YES xcodebuild -scheme WRHPS -project ./WRHPS.xcodeproj -destination 'platform=iOS Simulator,id=AF751CFB-3BE4-421B-B818-5A0050C60780' -derivedDataPath '/Users/Shared/Jenkins/Home/workspace/Fastlane Beta/derivedData' clean build test | tee '/Users/Shared/Jenkins/Library/Logs/scan/WRHPS-WRHPS.log' | xcpretty  --report html --output '/Users/Shared/Jenkins/Home/workspace/Fastlane Beta/output/report.html' --report junit --output '/Users/Shared/Jenkins/Home/workspace/Fastlane Beta/output/report.junit' --report junit --output '/var/folders/jk/8pldnhmx4n1drwgmfq_stxq0000086/T/junit_report20170623-5181-1s66ko1'
[07:50:54]: ▸ Loading...
[07:50:54]: ▸ Cleaning WRHPS/WRHPS [Debug]
[07:50:54]: ▸ Check Dependencies
[07:50:54]: ▸ Clean Succeeded
[07:50:54]: ▸ Building WRHPS/WRHPS [Debug]
[07:50:54]: ▸ Check Dependencies
[07:50:54]: ▸ Compiling AppDelegate.swift
[07:50:55]: ▸ Compiling MasterViewController.swift
[07:50:55]: ▸ Compiling DetailViewController.swift
[07:50:55]: ▸ Compiling Event+CoreDataClass.swift
[07:50:55]: ▸ Compiling Event+CoreDataProperties.swift
[07:50:55]: ▸ Compiling WRHPS+CoreDataModel.swift
[07:50:55]: ▸ Compiling WRHPS_vers.c
[07:50:55]: ▸ Linking WRHPS
[07:50:55]: ▸ Compiling LaunchScreen.storyboard
[07:50:56]: ▸ Compiling Main.storyboard
[07:50:56]: ▸ Processing Info.plist
[07:50:56]: Running Tests: ▸ Touching WRHPS.app
[07:50:56]: ▸ Signing derivedData/Build/Products/Debug-iphonesimulator/WRHPS.app
[07:50:56]: ▸ Build Succeeded
[07:50:57]: ▸ 2017-06-23 07:50:57.040 xcodebuild[5231:205339]  IDETestOperationsObserverDebug: Writing diagnostic log for test session to:
[07:50:57]: ▸ /Users/Shared/Jenkins/Home/workspace/Fastlane Beta/derivedData/Logs/Test/2EC30EB8-0029-4916-BA93-2DFA96810F69/Session-WRHPSUITests-2017-06-23_075057-kwJh6N.log
[07:50:57]: ▸ 2017-06-23 07:50:57.041 xcodebuild[5231:205117] [MT] IDETestOperationsObserverDebug: (24E9A699-79EE-45AB-9328-F4A4418D4F8B) Beginning test session WRHPSUITests-24E9A699-79EE-45AB-9328-F4A4418D4F8B at 2017-06-23 07:50:57.041 with Xcode 8E3004b on target <DVTiPhoneSimulator: 0x7fb727779be0> {
[07:50:57]: ▸ SimDevice: SimDevice : iPhone 5s (AF751CFB-3BE4-421B-B818-5A0050C60780) : state={ Shutdown } deviceType={ SimDeviceType : com.apple.CoreSimulator.SimDeviceType.iPhone-5s } runtime={ SimRuntime : 10.3.1 (14E8301) - com.apple.CoreSimulator.SimRuntime.iOS-10-3 }
[07:50:57]: ▸ } (10.3.1 (14E8301))
[07:50:57]: ▸ 2017-06-23 07:50:57.055 xcodebuild[5231:205165]  IDETestOperationsObserverDebug: Writing diagnostic log for test session to:
[07:50:57]: ▸ /Users/Shared/Jenkins/Home/workspace/Fastlane Beta/derivedData/Logs/Test/2EC30EB8-0029-4916-BA93-2DFA96810F69/Session-WRHPSTests-2017-06-23_075057-HAjTcK.log
[07:50:57]: ▸ 2017-06-23 07:50:57.055 xcodebuild[5231:205117] [MT] IDETestOperationsObserverDebug: (3924A727-58F3-4767-B93C-7B542DA402DB) Beginning test session WRHPSTests-3924A727-58F3-4767-B93C-7B542DA402DB at 2017-06-23 07:50:57.055 with Xcode 8E3004b on target <DVTiPhoneSimulator: 0x7fb727779be0> {
[07:50:57]: ▸ SimDevice: SimDevice : iPhone 5s (AF751CFB-3BE4-421B-B818-5A0050C60780) : state={ Shutdown } deviceType={ SimDeviceType : com.apple.CoreSimulator.SimDeviceType.iPhone-5s } runtime={ SimRuntime : 10.3.1 (14E8301) - com.apple.CoreSimulator.SimRuntime.iOS-10-3 }
[07:50:57]: ▸ } (10.3.1 (14E8301))
[07:50:57]: ▸ Building WRHPS/WRHPS [Debug]
[07:50:57]: ▸ Check Dependencies
[07:50:57]: ▸ Building WRHPS/WRHPSTests [Debug]
[07:50:57]: ▸ Check Dependencies
[07:50:57]: ▸ Processing Info.plist
[07:50:57]: ▸ Compiling WRHPSTests.swift
[07:50:58]: ▸ Linking WRHPSTests
[07:50:59]: Running Tests: ▸ Touching WRHPSTests.xctest
[07:50:59]: ▸ Signing derivedData/Build/Products/Debug-iphonesimulator/WRHPS.app/PlugIns/WRHPSTests.xctest
[07:50:59]: ▸ Building WRHPS/WRHPSUITests [Debug]
[07:50:59]: ▸ Check Dependencies
[07:50:59]: ▸ Processing Info.plist
[07:50:59]: ▸ Preprocessing /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Xcode/Agents/XCTRunner.app/Info.plist
[07:50:59]: ▸ Compiling WRHPSUITests.swift
[07:50:59]: ▸ Compiling WRHPSUITests.swift
[07:50:59]: ▸ Linking WRHPSUITests
[07:50:59]: Running Tests: ▸ Touching WRHPSUITests.xctest
[07:50:59]: ▸ Signing derivedData/Build/Products/Debug-iphonesimulator/WRHPSUITests-Runner.app/PlugIns/WRHPSUITests.xctest
[07:51:14]: ▸ All tests
[07:51:14]: ▸ Test Suite WRHPSUITests.xctest started
[07:51:14]: ▸ WRHPSUITests
[07:51:20]: ▸ ✓ testExample (6.737 seconds)
[07:51:20]: ▸ 	 Executed 1 test, with 0 failures (0 unexpected) in 6.737 (6.738) seconds
[07:51:20]: ▸
[07:51:26]: ▸ All tests
[07:51:26]: ▸ Test Suite WRHPSTests.xctest started
[07:51:26]: ▸ WRHPSTests
[07:51:26]: ▸ ✓ testExample (0.009 seconds)
[07:51:26]: ▸ ◷ testPerformanceExample measured (0.000 seconds)
[07:51:26]: ▸ ✓ testPerformanceExample (0.287 seconds)
[07:51:26]: ▸ 	 Executed 2 tests, with 0 failures (0 unexpected) in 0.296 (0.296) seconds
[07:51:26]: ▸
[07:51:26]: ▸ Test Succeeded
[07:51:27]: Successfully sent Slack notification
+--------------------+---+
|      Test Results      |
+--------------------+---+
| Number of tests    | 3 |
| Number of failures | 0 |
+--------------------+---+
[07:51:27]: Cruising back to lane 'ios beta_jenkins' 🚘
[07:51:27]: -------------------
[07:51:27]: --- Step: match ---
[07:51:27]: -------------------
[07:51:27]: Successfully loaded '/Users/Shared/Jenkins/Home/workspace/Fastlane Beta/fastlane/Matchfile' 📄
+---------+-------------------------------------------------------------------------------+
|                       Detected Values from './fastlane/Matchfile'                       |
+---------+-------------------------------------------------------------------------------+
| git_url |<EMAIL_ADDRESS>|
+---------+-------------------------------------------------------------------------------+
+-----------------------+-------------------------------------------------------------------------------+
|                                       Summary for match 2.41.0                                        |
+-----------------------+-------------------------------------------------------------------------------+
| type                  | appstore                                                                      |
| git_url               |<EMAIL_ADDRESS>|
| git_branch            | master                                                                        |
| app_identifier        | com.wrhps.WRHPS                                                               |
| username              |<EMAIL_ADDRESS>                                                    |
| keychain_name         | login.keychain                                                                |
| readonly              | false                                                                         |
| team_id               | GP3L96Q2RE                                                                    |
| verbose               | false                                                                         |
| force                 | false                                                                         |
| skip_confirmation     | false                                                                         |
| shallow_clone         | false                                                                         |
| clone_branch_directly | false                                                                         |
| force_for_new_devices | false                                                                         |
| skip_docs             | false                                                                         |
| platform              | ios                                                                           |
+-----------------------+-------------------------------------------------------------------------------+
[07:51:27]: Cloning remote git repo...
[07:51:27]: If cloning the repo takes too long, you can use the clone_branch_directly option in match.
[07:51:28]: 🔓  Successfully decrypted certificates repo
[07:51:28]: Verifying that the certificate and profile are still valid on the Dev Portal...
[07:51:30]: Installing certificate...
+-------------------+----------------------------------------------------------------------+
|                                  Installed Certificate                                   |
+-------------------+----------------------------------------------------------------------+
| User ID           | GP3L96Q2RE                                                           |
| Common Name       | iPhone Distribution: W. R. Henderson Construction, Inc. (GP3L96Q2RE) |
| Organisation Unit | GP3L96Q2RE                                                           |
| Organisation      | W. R. Henderson Construction, Inc.                                   |
| Country           | US                                                                   |
| Start Datetime    | Jun 21 17:36:47 2017 GMT                                             |
| End Datetime      | Jun 21 17:36:47 2018 GMT                                             |
+-------------------+----------------------------------------------------------------------+
[07:51:31]: Installing provisioning profile...
+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------------------------------+
|                                                                              Installed Provisioning Profile                                                                              |
+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------------------------------+
| Parameter           | Environment Variable                       | Value                                                                                |
+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------------------------------+
| App Identifier      |                                            | com.wrhps.WRHPS                                                                                |
| Type                |                                            | appstore                                                                                |
| Platform            |                                            | ios                                                                                |
| Profile UUID        | sigh_com.wrhps.WRHPS_appstore              | daa66000-d5b1-441e-b23e-1dc6cdc12d1a                                                                                |
| Profile Name        | sigh_com.wrhps.WRHPS_appstore_profile-name | match AppStore com.wrhps.WRHPS                                                                                |
| Profile Path        | sigh_com.wrhps.WRHPS_appstore_profile-path | /Users/Shared/Jenkins/Library/MobileDevice/Provisioning Profiles/daa66000-d5b1-441e-b23e-1dc6cdc12d1a.mobileprovision |
| Development Team ID | sigh_com.wrhps.WRHPS_appstore_team-id      | GP3L96Q2RE                                                                                |
+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------------------------------+
[07:51:31]: All required keys, certificates and provisioning profiles are installed 🙌
[07:51:31]: Setting Provisioning Profile type to 'app-store'
[07:51:31]: ------------------------------------
[07:51:31]: --- Step: increment_build_number ---
[07:51:31]: ------------------------------------
Current version of project WRHPS is:
2
/Users/Shared/Jenkins/Home/workspace/Fastlane Beta
[07:51:32]: $ cd /Users/Shared/Jenkins/Home/workspace/Fastlane\ Beta && agvtool next-version -all && cd -
[07:51:32]: ▸ Setting version of project WRHPS to:
[07:51:32]: ▸ 3.
[07:51:32]: ▸ Also setting CFBundleVersion key (assuming it exists)
[07:51:32]: ▸ Updating CFBundleVersion in Info.plist(s)...
[07:51:32]: ▸ Updated CFBundleVersion in "WRHPS.xcodeproj/../WRHPS/Info.plist" to 3
[07:51:32]: ▸ Updated CFBundleVersion in "WRHPS.xcodeproj/../WRHPSTests/Info.plist" to 3
[07:51:32]: ▸ Updated CFBundleVersion in "WRHPS.xcodeproj/../WRHPSUITests/Info.plist" to 3
[07:51:32]: ▸ /Users/Shared/Jenkins/Home/workspace/Fastlane Beta
[07:51:32]: -----------------
[07:51:32]: --- Step: gym ---
[07:51:32]: -----------------
[07:51:32]: $ xcodebuild -list -project ./WRHPS.xcodeproj
[07:51:33]: $ xcodebuild -showBuildSettings -scheme WRHPS -project ./WRHPS.xcodeproj
+-----------------------------------------------------+----------------------------------------------------------------+
|                                                Summary for gym 2.41.0                                                |
+-----------------------------------------------------+----------------------------------------------------------------+
| export_method                                       | app-store                                                      |
| export_options.provisioningProfiles.com.wrhps.WRHPS | match AppStore com.wrhps.WRHPS                                 |
| project                                             | ./WRHPS.xcodeproj                                              |
| scheme                                              | WRHPS                                                          |
| destination                                         | generic/platform=iOS                                           |
| output_name                                         | WRHPS                                                          |
| clean                                               | false                                                          |
| output_directory                                    | /Users/Shared/Jenkins/Home/workspace/Fastlane Beta/output      |
| silent                                              | false                                                          |
| skip_package_ipa                                    | false                                                          |
| use_legacy_build_api                                | false                                                          |
| build_path                                          | /Users/Shared/Jenkins/Home/workspace/Fastlane Beta/output      |
| derived_data_path                                   | /Users/Shared/Jenkins/Home/workspace/Fastlane Beta/derivedData |
| buildlog_path                                       | ~/Library/Logs/gym                                             |
| xcode_path                                          | /Applications/Xcode.app                                        |
+-----------------------------------------------------+----------------------------------------------------------------+
[07:51:33]: $ set -o pipefail && xcodebuild -scheme WRHPS -project ./WRHPS.xcodeproj -destination 'generic/platform=iOS' -archivePath /Users/Shared/Jenkins/Home/workspace/Fastlane\ Beta/output/WRHPS\ 2017-06-23\ 07.51.33.xcarchive -derivedDataPath '/Users/Shared/Jenkins/Home/workspace/Fastlane Beta/derivedData' archive | tee /Users/Shared/Jenkins/Library/Logs/gym/WRHPS-WRHPS.log | xcpretty
07:51:34: ▸ Building WRHPS/WRHPS [Release]
07:51:34: ▸ Check Dependencies
07:51:34: ▸ ❌  Code signing is required for product type 'Application' in SDK 'iOS 10.3'
07:51:34: ▸ ** ARCHIVE FAILED **
07:51:34: ▸ The following build commands failed:
07:51:34: ▸ Check dependencies
07:51:34: ▸ (1 failure)
▸ Building WRHPS/WRHPS [Release]
▸ Check Dependencies
❌  Code signing is required for product type 'Application' in SDK 'iOS 10.3'
** ARCHIVE FAILED **
The following build commands failed:
Check dependencies
(1 failure)
07:51:34: Exit status: 65
07:51:34: 📋  For a more detailed error log, check the full log at:
07:51:34: 📋  /Users/Shared/Jenkins/Library/Logs/gym/WRHPS-WRHPS.log
+-------------+-------------------------+
|           Build environment           |
+-------------+-------------------------+
| xcode_path  | /Applications/Xcode.app |
| gym_version | 2.41.0                  |
| sdk         | iPhoneOS10.3.sdk        |
+-------------+-------------------------+
07:51:34: --- Step: slack ---
07:51:34: -------------------
07:51:34: Successfully sent Slack notification
+------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------+
|                                                                                Lane Context                                                                                |
+------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------+
| DEFAULT_PLATFORM                   | ios                                                                                |
| PLATFORM_NAME                      | ios                                                                                |
| LANE_NAME                          | ios beta_jenkins                                                                                |
| SCAN_DERIVED_DATA_PATH             | /Users/Shared/Jenkins/Home/workspace/Fastlane Beta/derivedData                                                                        |
| SCAN_GENERATED_PLIST_FILES         | ["/Users/Shared/Jenkins/Home/workspace/Fastlane Beta/derivedData/Logs/Test/2EC30EB8-0029-4916-BA93-2DFA96810F69_TestSummaries.plist"] |
| SCAN_GENERATED_PLIST_FILE          | /Users/Shared/Jenkins/Home/workspace/Fastlane Beta/derivedData/Logs/Test/2EC30EB8-0029-4916-BA93-2DFA96810F69_TestSummaries.plist     |
| SIGH_PROFILE_TYPE                  | app-store                                                                                |
| MATCH_PROVISIONING_PROFILE_MAPPING | {"com.wrhps.WRHPS"=>"match AppStore com.wrhps.WRHPS"}                                                                                |
| BUILD_NUMBER                       | 3                                                                                |
+------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------+
07:51:34: Error building the application - see the log above
+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | update_fastlane                     | 5           |
| 2    | Verifying required fastlane version | 0           |
| 3    | default_platform                    | 0           |
| 4    | setup_jenkins                       | 0           |
| 5    | Switch to ios test lane             | 0           |
| 6    | scan                                | 36          |
| 7    | match                               | 4           |
| 8    | increment_build_number              | 0           |
| 💥   | gym                                 | 1           |
| 10   | slack                               | 0           |
+------+-------------------------------------+-------------+
07:51:34: fastlane finished with errors
[!] Error building the application - see the log above
Build step 'Execute shell' marked build as failure
Finished: FAILURE

i just ran the fastlane env command from the home directory, should i run it in the project directory on jenkins?

here is the output when i run fastlane env in the projects directory on the jenkins machine
✅ fastlane environment ✅
Stack

Key
Value

OS
10.12.5

Ruby
2.2.4

Bundler?
false

Git
git version 2.11.0 (Apple Git-81)

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.12.5 (16F2073)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
true

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.3.3

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
`./fastlane/Fastfile`
# Customise this file, documentation can be found here:
# https://github.com/fastlane/fastlane/tree/master/fastlane/docs
# All available actions: https://docs.fastlane.tools/actions
# can also be listed using the `fastlane actions` command

# Change the syntax highlighting to Ruby
# All lines starting with a # are ignored when running `fastlane`

# If you want to automatically update fastlane if a new version is available:
update_fastlane

# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "2.39.2"

default_platform :ios

platform :ios do
  before_all do
    ENV["SLACK_URL"] = "https://hooks.slack.com/services/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"
  end
    ENV['FASTLANE_PASSWORD'] = "3060Cal!"
    ENV['MATCH_PASSWORD'] = "3060Cal!"

  desc "Runs all the tests"
  lane :test do
  scan(clean: true)
  end

  desc "Submit a new Beta Build to Apple TestFlight"
  desc "This will also make sure the profile is up to date"
  lane :beta do
    test
    match(type: "appstore") # more information: https://codesigning.guide
    increment_build_number
    gym(export_method: "app-store") # Build your app - more options available
    pilot

    # sh "your_script.sh"
    # You can also use other beta testing services here (run `fastlane actions`)
  end

  desc "Submit a new Beta Build to Apple TestFlight"
    desc "This will also make sure the profile is up to date"
    lane :beta_jenkins do
    setup_jenkins(result_bundle: false, force: true)
    test
    match(type: "appstore") # more information: https://codesigning.guide
    increment_build_number
    gym(export_method: "app-store") # Build your app - more options available
    pilot

    # sh "your_script.sh"
    # You can also use other beta testing services here (run `fastlane actions`)
  end

  desc "Deploy a new version to the App Store"
  lane :release do
    match(type: "appstore")
    # snapshot
    gym(export_method: "app-store") # Build your app - more options available
    deliver(force: true)
    # frameit
  end

  # You can define as many lanes as you want

  after_all do |lane|
    # This block is called, only if the executed lane was successful
    slack( message: "Successfully deployed new App Update." )
  end

  error do |lane, exception|
     slack(
       message: exception.message,
       success: false
     )
  end
end

# More information about multiple platforms in fastlane: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Platforms.md
# All available actions: https://docs.fastlane.tools/actions

# fastlane reports which actions are used. No personal data is recorded.
# Learn more at https://github.com/fastlane/fastlane#metrics

`./fastlane/Appfile`
app_identifier "com.wrhps.WRHPS" # The bundle identifier of your app
apple_id<EMAIL_ADDRESS># Your Apple email address

team_id "GP3L96Q2RE" # Developer Portal Team ID

# you can even provide different app identifiers, Apple IDs and team names per lane:
# More information: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Appfile.md

fastlane gems

Gem
Version
Update-Status

fastlane
2.41.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

CFPropertyList
2.3.5

addressable
2.5.1

babosa
1.0.2

bigdecimal
1.2.6

bundler
1.14.6

claide
1.0.1

colored
1.2

colored2
3.1.2

commander-fastlane
4.4.4

declarative
0.0.9

declarative-option
0.1.0

domain_name
0.5.20170404

dotenv
2.2.0

excon
0.55.0

faraday
0.12.1

faraday-cookie_jar
0.0.6

faraday_middleware
<IP_ADDRESS>

fastimage
2.1.0

gh_inspector
1.0.3

google-api-client
0.12.0

googleauth
0.5.1

highline
1.7.8

http-cookie
1.0.3

httpclient
2.8.3

hurley
0.2

io-console
0.4.3

json
1.8.1

jwt
1.5.6

libxml-ruby
3.0.0

little-plugger
1.1.4

logging
2.2.2

memoist
0.15.0

mime-types
3.1

mime-types-data
3.2016.0521

mini_magick
4.5.1

minitest
5.4.3

multi_json
1.12.1

multi_xml
0.6.0

multipart-post
2.0.0

nanaimo
0.2.3

nokogiri
1.5.6

os
0.9.6

plist
3.2.0

power_assert
0.2.2

psych
2.0.8

public_suffix
2.0.5

rake
10.4.2

rdoc
4.2.0

representable
3.0.4

retriable
2.1.0

rouge
1.11.1

rubygems-update
2.5.2

rubyzip
1.2.1

security
0.1.3

signet
0.7.3

slack-notifier
1.5.1

sqlite3
1.3.13

terminal-notifier
1.7.1

terminal-table
1.7.3

test-unit
3.0.8

tty-screen
0.5.0

uber
0.0.15

unf
0.1.4

unf_ext
<IP_ADDRESS>

unicode-display_width
1.1.3

word_wrap
1.0.0

xcodeproj
1.4.4

xcpretty
0.2.6

xcpretty-travis-formatter
0.0.4

generated on: 2017-06-23

@drkhannah note that your iTunesconnect username and password is found in your post... probably want to edit that out. Cheers!

bump

@drkhannah
xcpretty is known for swallowing some important error messages.
What is exact output in your xcodebuild log? I guess it would be the WRHPS-WRHPS.log file.
It may have some valuable info under Check Dependencies section.
What kind of code signing are you using? Manual or automatic?

And not just disregards, but gets totally confused by that option.
The whole point of automatic code signing seems to be that Xcode will manage entitlements and profiles.
From https://developer.apple.com/library/content/qa/qa1814/_index.html

Xcode automatically configures your provisioning profiles for you, updates (or creates) a supporting entitlements file as needed, adds technology-specific frameworks as needed, creates code signing and provisioning assets for your team and sets your code signing build settings for you.

More insights in Bitrise blog: http://blog.bitrise.io/2016/09/21/xcode-8-and-automatic-code-signing.html
For example:

The second step is to remove every previous, now incompatible code signing input from the Xcode Archive step. In general you should try to reset every code signing related input option of the Xcode Archive step, e.g. "Force code signing with Identity" and "Force code signing with Provisioning Profile Specifier".

Or

Compare this with the previous solution, where you had to either create multiple Schemes in Xcode to be able to control where to use which code signing settings, or you had to specify "Force Identity / Provisioning Profile" options

@drkhannah i had a similar problem. Check your certificate trust settings on Jenkins. As far as I know, fastlane uses systems default as trust level for new certificates so a popup  like this appears the first time using it. I am currently searching for a way to bypass that. It can be done if you import the certificate with add-trusted-cert but not with security import like fastlane does.

I'm just going to keep the app manually signed instead of Xcode managing
signing
On Jun 30, 2017 7:49 AM, "vspac"<EMAIL_ADDRESS>wrote:

@drkhannah https://github.com/drkhannah i had a similar problem. Check
your certificate trust settings on Jenkins. As far as I know, fastlane uses
systems default as trust level for new certificates so a popup like this
https://www.phusionpassenger.com/library/admin/keychain/popup-7275c0d0.png
appears the first time using it. I am currently searching for a way to
bypass that. It can be done if you import the certificate with
add-trusted-cert but not with security import like fastlane does.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fastlane/fastlane/issues/9569#issuecomment-312247350,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGZY8wa1MJSaBc2dTz8pk0deQsxeUsMNks5sJODigaJpZM4ODp1Y
.

@drkhannah, I just had this problem with Jenkins today, as well. My solution was: Clean Derived Data-Folder on the Jenkins Mac (Via XCode: File -> Workspace Settings) and afterwards run the fastlane Script again and confirm the popup @vspac mentioned above. (Why this helped.. who knows.. Perhaps some build was aborted before and Derived Data contained incomplete information.. I don't know.)

I'm having this problem with Gitlab CI :/ Any updates on this?

@giridharvc7 For GitLab make sure to follow our gitlab guide


Still includes react-json-view when not using DevTools

I've noticed, even when building without <DevTools />, react-json-view is still bundled in the application. Perhaps this is intentional, but seems unnecessary. When bundled it takes up about 149KB uncompressed.

hey @ururk what's the bundle tool that you are using? definitely not intentional.

create-react-app - not ejected

may i know which version?

3.4.1

I'm not sure it's create-react app's fault - in the dist folder for little-state-machine, index.js, line 425-429:
const clone = require('lodash.clonedeep');
let ReactJson = (props) => React.createElement("div", Object.assign({}, props));
if (typeof window !== 'undefined' && typeof document !== 'undefined') {
    ReactJson = require('react-json-view').default;
}

I'm not as well-versed on the build/bundling side of things, but it looks to me like require will always be called when run in-browser.

looks like that's a bug at little state machine.

Yep - sorry if I wasn't clear enough!

nah all good, i think the reason little state machine did that because of SSR: https://github.com/mac-s-g/react-json-view/issues/121

i may have to switch to another lib...

can you try this version: 3.0.0-beta.1

Trying it out - need to do a few tests.

core codebase is not changed @ururk only that dev tool with json view.

I know - just wanted to try running it locally to see the new tree view, and build my app to see if it included the new library (react-json-tree).
It now includes the new library, although it is smaller in size.

sounds good to me :) so it's still in the prod build? 🤔

Yes - still in prod build. I even tried removing the import dev and {process.env.NODE_ENV !== 'production' && <DevTool />}.

can i see a snapshot of the build result?

looks like this one is CRA related? https://github.com/facebook/create-react-app/issues/2748

Here is the index.ts file
import {
  setStorageType,
  createStore,
  StateMachineProvider,
  useStateMachine,
} from './stateMachine';
import { DevTool } from './components/DevTool';
import StateMachineContext from './StateMachineContext';

export {
  setStorageType,
  createStore,
  StateMachineProvider,
  useStateMachine,
  StateMachineContext,
  DevTool,
};

It looks likely to be a CRA/webpack config issue.
I'm not sure if this helps, but at the top of the beta dist/index.js file for little-state-machine, it gets included like so:
var React = require('react');
var JSONTree = _interopDefault(require('react-json-tree'));
var reactSimpleAnimate = require('react-simple-animate');

I removed the reference to JSONTree inside of DevToolStateTree, and it still included the library, so at this point CRA/webpack must not be detecting that JSONTree is never referenced.

Thanks for helping @ururk
i have sent a StackOverflow question around this as well: https://stackoverflow.com/questions/61471907/export-module-with-node-env-with-ts

Thanks! FYI - it is using index.es.js - not index.js from the dist folder.
I did a quick test and commented out the createElement calls in DevToolStateTree and it still included react-json-tree, so this feels like a webpack/CRA bug like you suspected.

Yea, and it's difficult with TS as well, it probably doesn't support dynamic export. I will publish v3 anyhow later tonight, it's better than what we got right.

Yep! With the new library, I noticed you cannot scroll the tree when it is expanded past the browser window, can't recall now what the old behavior was, and if it is my app or not :P

@ururk i will fix that :)

I'm also seeing react-hook-form in my parcel 2 builds. Am I right in understanding that this is fixed on the master branch? Also little-state-machine is showing as 16.01KB?
$ NODE_ENV=production parcel build src/index.html --experimental-scope-hoisting --detailed-report 20
✨  Built in 6.62s.

dist/src.eb090cc8.js                                             545.78 KB    6.54s
├── node_modules/react-json-view/dist/main.js                    147.96 KB     11ms
├── node_modules/react-hook-form/dist/react-hook-form.es.js        33.8 KB     71ms
├── node_modules/jss/dist/jss.esm.js                              25.36 KB     23ms
├── node_modules/little-state-machine/dist/index.es.js            16.01 KB      5ms

I think i know the fix now, i will sort out in the next couple days.

i will have to move dev tool out from the main repo.


[EventHubs]: Adding Testcases to EventHub and ServiceBus Track2 SDK's

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

@damodaravadhani  can you fix the test failures?

/azp run net - mgmt - ci

/azp run

/azp run *

/azp run net - servicebus - mgmt

/azp run net - servicebus - mgmt - ci

/check-enforce override

/azp run net - resourcemanager - mgmt - ci

Thanks for the merge @ArthurMa1978


Update content on complaints landing page

Update content on complaints landing page. Captured in GHE/CFGOV/platform/issues/437
Review

@cfarm
@rosskarchner

Preview this PR without the whitespace changes

👍


Consolidate CI and add Bors config

Merges some of the CI job definitions to be more concise
Adds Bors config for merging

bors ping

Closing, need to reopen on an upstream branch


PLNSRVCE-482: Allow the overriding of the analyzer image in CI runs

We need to override the used dependency analyzer image in order to properly run the CI tests. This PR provides a mechanism that achieves that by:

cloning the build-definitions repo
overriding the image reference in the task where its being used
creating a new Tekton bundle
pushing it to a target repository
creating a configmap to override the bundle used by Appstudio
starting the e2e tests

/test jvm-build-service-e2e

/test jvm-build-service-e2e

we will retest after https://github.com/redhat-appstudio/jvm-build-service/pull/107 merges

/test jvm-build-service-e2e

/test jvm-build-service-e2e

/test jvm-build-service-e2e

the images error is interesting @brunoapimentel
gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
error: build error: error building at STEP "RUN wget https://github.com/mikefarah/yq/releases/download/v4.25.1/yq_linux_amd64 -O /usr/local/bin/yq &&     chmod +x /usr/local/bin/yq && yq --version &&     curl -LO https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl &&     chmod +x ./kubectl &&     mv ./kubectl /usr/local/bin &&     curl -LO https://github.com/tektoncd/cli/releases/download/v0.24.0/tkn_0.24.0_Linux_x86_64.tar.gz &&     tar xvzf tkn_0.24.0_Linux_x86_64.tar.gz --no-same-owner -C /usr/local/bin/ tkn": error while running runtime: exit status 2

I wonder if something has changed with the registry.ci.openshift.org/openshift/release:golang-1.17 used as the base when your PR running https://github.com/redhat-appstudio/jvm-build-service/blob/main/.ci/openshift-ci/Dockerfile#L16 presumably succeeded.
My best guess if the file permissions has changed and the curl is not actually storing on disk, or we can no longer assume permission writing to /usr/local/bin.  Or there was a networking hiccup.
Trying again in case it was a networking hiccup.
/test images

it does look like there were some github.com throttling hiccups yesterday with RH repos ... could have been that

ok image building again
/test jvm-build-service-e2e

/test jvm-build-service-e2e

clean run, but still getting those auth errors pushing to bundle @psturc @brunoapimentel :+1:
Error: could not push image to registry as "quay.io/repository/redhat-appstudio-qe/test-images:task-bundle-6595aefcf9d9a3445c1efdcc17b84d9352ae3598-1": HEAD https://quay.io/v2/repository/redhat-appstudio-qe/test-images/blobs/sha256:726f445a325fc72e713d6569f26185acee0005db89c008b51f38613539482cbe: unexpected status code 401 Unauthorized (HEAD responses have no body, use GET for details)
Is that image URL correct?  should it not be something like quay.io/redhat-appstudio-qe/test-images:task-bundle-6595aefcf9d9a3445c1efdcc17b84d9352ae3598-1 instead, where you've removed /respository/ from that URL?

clean run, but still getting those auth errors pushing to bundle @psturc @brunoapimentel Error: could not push image to registry as "quay.io/repository/redhat-appstudio-qe/test-images:task-bundle-6595aefcf9d9a3445c1efdcc17b84d9352ae3598-1": HEAD https://quay.io/v2/repository/redhat-appstudio-qe/test-images/blobs/sha256:726f445a325fc72e713d6569f26185acee0005db89c008b51f38613539482cbe: unexpected status code 401 Unauthorized (HEAD responses have no body, use GET for details)
Is that image URL correct? should it not be something like quay.io/redhat-appstudio-qe/test-images:task-bundle-6595aefcf9d9a3445c1efdcc17b84d9352ae3598-1 instead, where you've removed /respository/ from that URL?

You're absolutely right, Gabe! Removing the repository part solved it :facepalm:

let's re-run with @psturc 's commenting out of the various tests while we wait on minimally https://github.com/redhat-appstudio/infra-deployments/pull/513

/retest

ok we now are hitting the issue tracked by https://github.com/redhat-appstudio/e2e-tests/pull/152 https://github.com/redhat-appstudio/e2e-tests/pull/153

/retest

/retest

From https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/redhat-appstudio_jvm-build-service/103/pull-ci-redhat-appstudio-jvm-build-service-main-jvm-build-service-e2e/1550825338118868992/artifacts/jvm-build-service-e2e/jvm-build-service-e2e/build-log.txt
New build bundle will be created based on quay.io/redhat-appstudio/build-templates-bundle:0e0b28716550e1adc50443084adecec67f1748ef
jvm-build-service analyzer image set to registry.build01.ci.openshift.org/ci-op-gx2kkl51/pipeline
Creating quay.io/redhat-appstudio-qe/test-images:task-bundle-af9cd7b6d2f757bec2de5cdf963b3043574aa813
Creating Tekton Bundle:
	- Added Task: s2i-java to image

Pushed Tekton Bundle to quay.io/redhat-appstudio-qe/test-images@sha256:a5400cbac91d21b88c49df02788d641daca8797872538f0020695e08c9cfd186
Creating quay.io/redhat-appstudio-qe/test-images:pipeline-bundle-af9cd7b6d2f757bec2de5cdf963b3043574aa813
Creating Tekton Bundle:
	- Added Pipeline: docker-build to image
	- Added Pipeline: java-builder to image
	- Added Pipeline: nodejs-builder to image
	- Added Pipeline: noop to image
	- Added Pipeline: prototype-compliance to image

Pushed Tekton Bundle to quay.io/redhat-appstudio-qe/test-images@sha256:23d001a24032ab760fba28d893294e8d81ae97b2c4bad9478479c8bed8ebeb3f

That seems to meet the criteria here.  Unless I am missing something or you have other observactions @Michkov I want to merge this to possibly facilitate https://github.com/openshift/release/pull/30600

We can also move toward doing the similar update of the sidecar image in the bundle.

btw https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/redhat-appstudio_jvm-build-service/103/pull-ci-redhat-appstudio-jvm-build-service-main-jvm-build-service-in-repo-e2e/1551585375418322944 will fail until I can debug / fix the problem I noted Friday with https://coreos.slack.com/archives/C03KN2B47GU/p1658585506731059?thread_ts=1658531778.074429&cid=C03KN2B47GU
Starting off with pulling in one by one a few of @stuartwdouglas 's fix PRs .... I think I am minimally hitting some of those.
When I have something passing again locally I will push a PR and reference it here.

/retest

So https://github.com/redhat-appstudio/jvm-build-service/pull/129 moves the boulder up the hill some, but I'm either going to need help or another day or so of study to sort out why at least some of the artifactbuilds / dependencybuilds are not getting to complete state.

in repo is now green with #129
/retest

/retest

/retest

another tekton-chanins ns not created in https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/redhat-appstudio_jvm-build-service/103/pull-ci-redhat-appstudio-jvm-build-service-main-jvm-build-service-in-repo-e2e/1551867931309117440
going to try @Michkov 's test in  https://coreos.slack.com/archives/C02FTKEMBU1/p1658726783159679?thread_ts=1658499647.682389&cid=C02FTKEMBU1 and see if the unveils anything

@gabemontero I can see -> fatal: unable to access 'https://github.com/redhat-appstudio-qe/infra-deployments.git/': The requested URL returned error: 429, it was not able to push changes, branch did not exists so the argocd was not able to download it and apply.

@gabemontero I can see -> fatal: unable to access 'https://github.com/redhat-appstudio-qe/infra-deployments.git/': The requested URL returned error: 429, it was not able to push changes, branch did not exists so the argocd was not able to download it and apply.

good eye @Michkov - yep in hindsight I do not recall that message in earlier incarnations of this
and certainly @brunoapimentel 's changes here introduce the repo redhat-appstudio-qe though it is in relation to the bundle image ref.
Is it possible the consumption of the new bundle at https://github.com/redhat-appstudio/infra-deployments/blob/main/hack/preview.sh#L101 leads to this ref to  'https://github.com/redhat-appstudio-qe/infra-deployments.git/' ??

/retest

@gabemontero I can see -> fatal: unable to access 'https://github.com/redhat-appstudio-qe/infra-deployments.git/': The requested URL returned error: 429, it was not able to push changes, branch did not exists so the argocd was not able to download it and apply.

good eye @Michkov - yep in hindsight I do not recall that message in earlier incarnations of this
and certainly @brunoapimentel 's changes here introduce the repo redhat-appstudio-qe though it is in relation to the bundle image ref.
Is it possible the consumption of the new bundle at https://github.com/redhat-appstudio/infra-deployments/blob/main/hack/preview.sh#L101 leads to this ref to 'https://github.com/redhat-appstudio-qe/infra-deployments.git/' ??

oh it was an intermittent thing ... from the succeeding run:
Each component above is set to the following repositories
if you do not see your component in the list, please send a PR update to argo-cd-apps/overlays/development/repo-overlay.yaml
https://github.com/redhat-appstudio-qe/infra-deployments.git
---
https://github.com/redhat-appstudio-qe/infra-deployments.git
---
https://github.com/redhat-appstudio-qe/infra-deployments.git
---
https://github.com/redhat-appstudio-qe/infra-deployments.git
---
https://github.com/redhat-appstudio-qe/infra-deployments.git
---
https://github.com/redhat-appstudio-qe/infra-deployments.git
---
https://github.com/redhat-appstudio-qe/infra-deployments.git
---
https://github.com/redhat-appstudio-qe/infra-deployments.git
---
https://github.com/redhat-appstudio-qe/infra-deployments.git
---
https://github.com/redhat-appstudio-qe/infra-deployments.git
Changing AppStudio Gitlab Org to "redhat-appstudio-qe"


Where could I find the guidebook for beginners?

thanks for your work, and I am a newbie with this tool, and I want to get useful information from official tutorials.

I found this tutorial on steam, hopely will help you.
https://steamcommunity.com/sharedfiles/filedetails/?id=1522748339


Update mrlearning-base-ch4.md

Docs Build status updates of commit 17714cc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/mrlearning-base-ch4.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add storybooks for components with badges

As I've been working with badges, I've realized it's hard to know how a change will affect badges throughout the apps. A big part of this is due to the fact that most components that use badges aren't in our storybook. #12673 would add a Badge component storybook entry, but wouldn't give us the context we really need to see how badges look in the different places they're used.
This PR aims to add entries for every component that uses a badge (if there wasn't already one that existed). A search through the codebase led me to the following places:
Shared

Inbox dividers: Big teams and "show more/less"
Files
Team List
Team Tab

Desktop

Desktop Tab Bar
Menubar

Mobile

Mobile Tab Bar
Back buttons, both in a chat conversations and on screens
Settings screen

The italicized components already had stories, the bolded components got stories in the PR, and the non-bolded, non-italicized components do not have stories implemented yet.
The files row storybook already existed, but I added an extra row to demo the badge. The team list storybook also already existed and tested the badge, so I didn't touch that.
The settings screen storybook is implemented in #12673.
Currently, the inbox related components are not included in this PR. After talking with @thebearjew, we decided that it'd be best to wait until his revamp of the inbox storybooks (#12718) was merged in before I tackled those. I plan on removing the [WIP] once those changes happen, but the rest of the code should be ready for review.
I changed a couple of things in some components in order to fix some errors and/or weird behavior I was getting in the storybook. I know that it isn't really super preferred to do this, so I've tried to note where and why in a self-review. If you know a better way to do something, please lmk.

Modified the inbox story to include tests for the Big teams divider and show more/less!

probably ready for another review @keybase/react-hackers


Windows: Focus with mouse highlights text

Operating System: Windows
Pretty sure this doesn't happen in Linux.
Behavior summary
When focusing the window with a mouse click, all characters are highlighted up until the character clicked on.
Expectation
The window is simply focused, no extra selection occurs.
Extra
This is especially irritating in combination with #2050.
(selection: save_to_clipboard: false doesn't seem to work, resulting in pasting half the terminal screen back into the prompt)

This issue was already raised for macOS here where it was initially implemented for all platforms.
The behavior was then reverted for Linux/BSD because it's not expected there in this PR.
This was all before Windows support was added, so it made sense back then to just check if the platform is not macOS. It seems like all that is needed here, would be to add another check to make sure that this behavior is also present on Windows to match macOS.
I've created a PR to fix this issue, I'd appreciate help with testing: https://github.com/jwilm/alacritty/pull/2172

I built from this PR (with the build fix) and I'm still getting the same behaviour.
Just to verify, I built this with cargo build --release. Is this correct?
(Not sure if you can/how to download binaries build by TravisCI?)

You can not download binaries build by travis. However you do build using cargo build, the release is optional in this case.
Please make sure you have the right branch selected. Please let me know if you can't make it work and I'll have to test myself.

I can confirm the issue is not yet fixed.

I've just tested this on my Windows test system and can not reproduce it.
Could someone confirm that this issue still exists when running powershell in both ConPTY and WinPTY?

How would I do that? If it's just toggling "Use legacy console" in Powershell: nothing changed, unfortunately. I also tried toggling every possible setting in options, but there was no change.
Running it from cmd and doing the same things exhibits the same behavior. Windows 10 Version 1803 (OS Build 17134.648) -- from winver, if it helps.

Your Windows 10 version seems extremely outdated (about 1 year?). Could you try updating to see if that fixes the problem?

I'm on version 1809, build 17763.379.
Unfortunately still the same with both Winpty and Conpty (didn't know this was a thing).
I'm definitely running the correct build, I checked that the PR changed lines exist in my source, and changed the window title to be sure it's a fresh build.

ConPTY does not exist until version 1810. Please make sure you're using the latest version of Windows to ensure that this is not caused by some issues with the outdated WinPTY.

Thanks for the tip on 1809. Dunno why I never got it. However, issue is the same and I can't find any mention of an 1810 update. I assume your system is part of the Insider program, then?

I believe 1809 is actually the latest.
I am experiencing this issue as well, however I am on an older windows version 1803 build 17134.523 as this is my work laptop. Tonight I would be able to test this at home on my own PC.

Thanks for the tip on 1809. Dunno why I never got it. However, issue is the same and I can't find any mention of an 1810 update. I assume your system is part of the Insider program, then?

That was my mistake actually, sorry. Since this was the October update, I thought the version number would be 1810 (2018.10).
If that version is present (1809), then the ConPTY option will work and is available.
Could the people who are able to reproduce share a bit more information about how to reproduce this? I feel like this would be a pretty simple bug to fix, but unfortunately I can not reproduce it. It would be interesting to get some information about the system, is this reproducible with both mouse and touchpad? Does it matter which other application is open?
Since it might not be trivial for me to fix it, this would probably be a great issue for someone interested in trying to contribute to Alacritty. I can help with getting started if someone is willing to dive in.

Turns out I've managed to reproduce it. The issue is that the Focused event comes after the MouseInput event, so when clicking the window it will always be focused.

Well that would explain it. I tried some different commits. Issue was introduced in 104b866cb6fa1b0674abdd2bdd3668f280939ca8 I think.

Turns out a straight-forward and simple fix for this issue is currently not possible with the window library Alacritty is using.
I've opened a bug upstream to discuss this issue and possible solutions for it:
https://github.com/tomaka/winit/issues/817

Thanks to Osspial, this just got fixed upstream.
Can anyone recompile Alacritty against the latest winit git version to confirm this works?
The easiest way to test that is probably to put the following in Alacritty's Cargo.toml:
[dependencies.winit]
git = 'https://github.com/tomaka/winit'

Confirmed fixed! Woohoo! 🎉

Yep, it also works on my macine!

Nice, going to close this once a new version is released. Thanks for testing and thanks to Osspial for testing.

Fixed for me as well! Feel free to close whenever.


Need a new sample project to demonstrate ISerializable/IParceable

We need examples showing context propagation for ISerializable and IParceable WizardState objects

Use of ISerializable and IParceable is not recommended due to GC performance issues. The latest code supports automatic serialization via Newtonsoft Json.Net. a sample project illustrating this is also included.


cmd/compile: not-deterministic output

cmd/compile fails on the following program printing current time, which makes output non-deterministic and not amenable for automatic checking. Also a line number would be nice.
Program in hex:
00000000  70 61 63 6b 61 67 65 20  70 0a 0a 66 75 6e 63 20  |package p..func |
00000010  ef ef 0a                                          |...|

output of go tool compile:
2015/11/16 14:09:06 getc: peeking: EOF

go version devel +25a28da Sun Nov 15 23:41:28 2015 +0000 linux/amd64

This is unrelated to the new parser.
More generally, there's a question as to what to do with this and other fatal errors in the compiler.

Filed a fix for this particular issue (https://go-review.googlesource.com/17047). Filed a separate issue #13320 for log.Fatal calls.


CMD command

Create a Dockerfile showing the use of CMD command in Dockerfile

Thanks @mclay
Closing this issue 👍


Admin chat feature

Hello,
I'm not sure if this is generally wanted, but I would love to use your plugin as kind of an admin chat:
In the configuration I would specify another Slack channel which is used as "admin chat" and ingame there would be a new command (/admin <msg> or whatever) to send messages into this channel.
And all messages sent from that given channel out of Slack show up for the people with the permission slack.admin.
Let me know what do you think about this.

I think this is outside the scope of this plugin and would be more suited for another plugin to hook into this one's API.

@mastercoms Yeah, I already thought so. Unfortunately my development skills are not that great (sys admin in full time) so I can't do that. :/
Perhaps someone wants this as badly as I do and is indeed able to write an own plugin for this.
Thanks for your quick response, though!

I'll write a plugin for you. No one will use my API except for me anyway :)

@mastercoms Woah! That would be really awesome. Let me know if you need any more information. I do my best to help you out during the development of the plugin! :astonished:

Well, I'm sorry, but until 1.5.x is released and stable, I won't be able to work on the admin chat plugin.

@mastercoms No worries! I'm already happy because of your offer :)
Regarding the name: I'm not quite sure, perhaps something simple like "SlackAdminChat"?

Your idea gave me a new idea. SlackMC channels. So you can have multiple webhook URLs and then a plugin using the API can specify a certain channel. Kind of like permission groups.

That would be even more perfect!


Wrong accaunt

Good afternoon. When using a project from the "src" folder, when entering a phone number, the activation code does not come to the telegram client. However, if you enter it incorrectly, it comes in the form of SMS to your phone. I drive it, but after that it connects to someone else's John Doe account. How to connect your account?

https://github.com/wiz0u/WTelegramClient/blob/master/FAQ.md#wrong-server


MNT: Re-rendered with conda-build 3.18.11, conda-smithy 3.6.6, and co…

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

I believe this is out of date; closing.


Remove parent pom file and split modules in separate projects

This fixes #373
For this we merged all details contained in the parent POM directly into the modules, making them independent maven projects.

I would really like to see this merged too — @jan-molak I would also be able to assist with anything else needed to get this in the next release

Hi guys and thanks for your contribution! I wonder, is it better to split the modules into separate maven projects and risk duplication, or publish the parent pom?

Hi @jan-molak , sure if you want to avoid the duplication we introduced here, a fine & quick solution would be to publish to parent POM. Please go ahead if you prefer that, we can then close this PR.

Hi @jan-molak , sure if you want to avoid the duplication we introduced here, a fine & quick solution would be to publish to parent POM. Please go ahead if you prefer that, we can then close this PR.

#373 was fixed another way, and this PR has conflicts. If this is still needed for some reason, please file a new PR.


union type cannot be self-referential in a recursive structure

I am writing a simple recursive Tag class to represent an HTML tag, which triggers a type checking error:
type Node = Tag | string; // 94: string is incompatible with Tag
class Tag {
  name: string;
  children: Array<Node>;

  constructor(name: string) {
    this.name = name;
    this.children = [];
  }

  walk(f:(node:Node) => void) {
    f(this);
    for (var i = 0; i < this.children.length; i++) {
      var node = this.children[i];
      if(node instanceof Tag) {
        node.walk(f);
      } else if(typeof node == 'string') {
        f(node);
      }
    };
  }
}

/*
94:19,24: string
This type is incompatible with
  95:7,9: Tag
*/

The minimal case that triggers the same type checking error that I could produce is this:
class Tag {
  constructor() {
    var a1: Array<Tag|string> = [];
    var a2: Array<Tag|string> = a1;
  }
}

The same code rewritten with typealias also doesn't work:
type Node = Tag | string;
class Tag {
  constructor() {
    var a1: Array<Node> = [];
    var a2: Array<Node> = a1;
  }
}

But it works if the type alias is moved after the Tag definition...
// no type checking error!
class Tag {
  constructor() {
    var a1: Array<Node> = [];
    var a2: Array<Node> = a1;
  }
}
type Node = Tag | string;

Should be fixed in the next release, will close when it lands.

@hayea: Can you confirm if the 0.7.0 release fixed this issue for you?

Reopen if this is still an issue, thanks :)


VLEN 2048 tests size

I've virtual platform which supports the VLEN=2048b, when I tried to generate tests for 2048. The size of the executable files is way too large. Is there something we can configure to make it smaller?

Yes, there is an undocumented option called SPLIT, see Makefile#L4, you can try to make it smaller to get a smaller per file size. I'll document that option later.

Yes, there is an undocumented option called SPLIT, see Makefile#L4, you can try to make it smaller to get a smaller per file size. I'll document that option later.

in general, is this the number of lines of code? or is it something else?

I've added documentation for all available option, use make help to see all of them.


fix(deduper): use ptr to sync.RWMutex, fix panic during concurrent use

Resolves: #15559
As accurately noted in the issue description, the map is shared among child loggers that get created when WithAttr()/WithGroup() are called on the underlying handler, which happens via log.With() and log.WithGroup() respectively.
The RW mutex was a value in the previous implementation that used go-kit/log, and I should've updated it to use a pointer when I converted the deduper.
Also adds a test.

This was a bug in 3.0.0; should it be backported to the 3.0 branch?


Native Experience - Consider showing Data Viewer if table is double clicked (like plot viewer)

This is a lot of work. We need semantic analysis of the code written to understand the table is tied to a variable of some sort. Unless we just support it working on df.head or something small like that.

If would be nice to have at least with run

df

to display content of dataframe as embedded viewer.
It should not involve complecated semantic analysis, and would be very useful to have filtering and sorting in the table


Read an account from the service

name: Read account
about: using service
title: "service''
labels: 'client'
assignees: 'admin'

As a [Admin]
I need  microservice using Docker containers [function]
So that we can scale easily [benefit]
Details and Assumptions

[We need to satisfy our clients and this is our topmost priority]

Acceptance Criteria
The service is running as expected
Given [that we are using Docker containers]
When [we deploy our applications]
Then [it should work as expected]


Fulltext search with phonetic index on artist names

Hey @colagrosso, I was talking about some ideas for a more forgiving search functionality on an earlier PR; here's an implementation of one of those ideas. It uses the metaphone function to generate a phonetic representation for the artist name, which in theory would cover some typos and minor alternative spellings. It also uses mysql/mariadb fulltext indices for query matching.
This is mostly experimental so I would be interested to hear your thoughts -- definitely not set on merging this exactly as it is now. My first impressions are that it returns a lot more results, so it's good if you don't know exactly what you're searching for. On the other hand, if you have a specific query it will return a lot of less specific results - for example, searching 'portrait woman' will return all images that match either 'portrait' or 'woman'.
You can also try different phonetic keys which give somewhat different results (just replace references to metaphone with soundex). In general I found that soundex gives more false positives (it matches 'childe' and 'claude'), but metaphone has more false negatives ('ilia' and 'illia' match, but not 'ilya').
Migration scripts:
ALTER TABLE Artists
	ADD PhoneticName varchar(255) NOT NULL;

ALTER TABLE Artists
	ADD FULLTEXT ArtistsFullText (Name, UrlName, PhoneticName);

ALTER TABLE AlternateSpellings
	ADD FULLTEXT AlternateSpellingsFullText (AlternateSpelling);

ALTER TABLE Artworks
	ADD FULLTEXT ArtworksFullText (Name, UrlName);

ALTER TABLE Tags
	ADD FULLTEXT TagsFullText (Name);

{
	/** @var Artist $artist */
	foreach (Artist::GetAll() as $artist) {
		$metaphone = explode(separator: '-', string: $artist->UrlName);
		$metaphone = array_map(callback: 'metaphone', array: $metaphone);
		$metaphone = implode(separator: ' ', array: $metaphone);
		Db::Query('
			UPDATE Artists
			SET PhoneticName = ?
			WHERE ArtistId = ?;
		', [$metaphone, $artist->ArtistId]);
	}
}

Great work, Job! Way to prototype your idea. You know database features that I don't.
Here are my thoughts:

I vote to delay changes to search until we get, say, 500 approved images. Once the list of artwork spans multiple pages, we can collect feedback from users, i.e., book producers. We could ask broadly on the mailing list or tap specific people whose opinion we trust. I'd like to hear from book producers how important it is to cover some typos and minor alternative spellings. While it sounds useful, the need may be small and be obviated by sites like Wikipedia. Moreover, the consequence of returning too many non-matching results might mean the search is too hard to understand what it's doing.

(Side note: I bet we'll get more feedback about too many images having too few tags. I expect book producers to browse by tag just as often searching by artwork title and artist name.)

When it's time to revisit search, I think we should consider your two PR's two contributions separately:

a. Replace the current approach of loading all artwork and filtering it (Artwork::GetBrowsable(), Artwork::Contains(), and Library::FilterArtwork()) with a direct SQL query
Here are the pros/cons I see of replacing the current approach with a direct SQL query:

Pro: Probably the "right" way to do it
Pro: Slightly fewer lines of code
Pro: Might be easier to test in MySQL directly

Con: The implementation in this PR has a gnarly query with a large number of joins. (The current approach also has a large number of lookups. They're just behind PropertiesBase methods.). Performance is not a serious concern, but we should at least run EXPLAIN on the query to ensure it behaves as expected. I'd be more concerned about maintaining the query if we needed to add more search parameters or sort orders.

One possible pro of the current approach:

The code works like ebooks search, which might be easier to maintain

b. Adding phonetic matches
I'm skeptical that we'll need this, but I'd be convinced if our users ask for it.

One immediate improvement that your PR uncovered: We should move Library::FilterArtwork() out of lib/Library.php into lib/Artwork.php. Now that we're not using APCu for artwork (317bac2), it doesn't need to be near the other APCu functions.
This probably isn't the response you were expecting or looking for, but I do appreciate you and your willingness to prototype. Great initiative!

My suggestion is not to overengineer this project at this stage. The important thing is getting an MVP out so we can make sure the basics work and that it meets user expectations. Then, we can go back and chew on things like improved queries, indexes, making sure phonetics work, etc.

Thanks both for your feedback. Closing this PR now. I agree that this type of stuff isn't entirely necessary at this stage -- maybe something to come back to in the future.


Serializable Bonzai Tree Support

In a video long ago, Bart De Smet talked about the integration of serializable bonzai tree support in rx.net. https://vimeo.com/132192255
I'd really like to be able to pass expressions in their serialized forms over the wire, additionally persisting the expressions themselves to disk (and be able to load).
Gitter discussion about it:
https://gitter.im/Reactive-Extensions/Rx.NET/archives/2015/07/01
Now that it's been > 1yr, and many of the other rx libraries (for other languages RxJs : https://github.com/Reactive-Extensions/RxJS/commit/9a813e4dea7ce488422a90cf9b84adc4f4763db9) are starting to support this, is there any chance of seeing this in rx.net as something I can consume without having to worry about licensing or ability to distribute binaries that were bundled with windows 10?

Is this something that could be contributed by community? I realize something exists, but if plans are not to have this stuff in place any time soon, wondering if some of the pre-made libraries to support serializing linq expressions could be integrated or something.

cc @bartdesmet @mattpodwysocki

This is something we want to look into publishing, pending a transfer of these components to OSS. One tricky part is the dependency on an internal JSON framework, which we may need to get out as well. I'm having sync meetings with the .NET team on some of these libraries and our plan going forward. It's much more generic than just Rx, so it really belongs in the corefx or corefxlabs area.

+1  I'm also interested in this.

We would make a REALLY good use of it in Orleans :)
Looking forward for progress on this issue...

Any progress to report?

Also, what is the exact serialization format for expression trees? Is it source code? Will this finally allow for full scripting with expression trees from text?

Is there any actionable change with this request?

@bartdesmet @akarnokd any updates with regards this? can this move forward given publication of System.Text.Json or is this still dependent on a different internal Json framework ?

@bartdesmet any updates regards this ?

also hoping that an update for https://github.com/dotnet/reactive/issues/181 may come given these may be interlinked ?

This was published in May 2021 in the https://github.com/reaqtive/reaqtor repo.
The Bonsai bits are in https://github.com/reaqtive/reaqtor/tree/main/Nuqleon/Core/LINQ