FloatingActionButtonAnimator getRotationAnimation issue

Issue #25123 already open but @NBTX is unable to reopen it, please make sure to check it out.

Steps to Reproduce

Create a MaterialApp and Scaffold
Try to apply a floatingActionButtonAnimation
The results are ignored.

Logs
[        ] Connected to _flutterView/0x7336838c18.
[   +3 ms] 🔥  To hot reload changes while running, press "r". To hot restart (and rebuild state), press "R".
[        ] An Observatory debugger and profiler on Pixel 2 is available at: http://<IP_ADDRESS>:49684/
[        ] For a more detailed help message, press "h". To detach, press "d"; to quit, press "q".

No analysis errors.
[✓] Flutter (Channel beta, v1.0.0, on Mac OS X 10.14 18A391, locale en-GB)
    • Flutter version 1.0.0 at /Users/NBTX/development/flutter
    • Framework revision 5391447fae (9 days ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/NBTX/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 2.0.0
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 29.0.2
    • Dart plugin version 181.5540.11
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] IntelliJ IDEA Ultimate Edition (version 2018.2.4)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 29.1.3
    • Dart plugin version 182.4999

[✓] Connected device (1 available)
    • ...

• No issues found!

And here is @cohortor's suggested solution.

I would kindly like to revisit and reopen this issue. IMHO the problem is in scaffold.dart -> _FloatingActionButtonTransitionState -> _updateAnimations().
In particular, _entranceTurnTween is always applied, rotating the FAB by kFloatingActionButtonTurnInterval (currently 0.125, i.e. 45 degrees). Changing this value to 0.0 stops FAB rotation.
DISCUSSION:
The previously suggested "solution":
  @override
  Animation<double> getRotationAnimation({Animation<double> parent}) {
    return Tween<double>(begin: 0.0, end: 1.0).animate(parent);
  }

should actually result in a rotation animation that rotates the FAB through a full circle,
in my case (FAB placed horizontally centered) results in a 45deg FAB rotation the first time the FAB is shown, followed by no rotation during subsequent hides/shows.

The final value of the rotation is determined by the FAB's current and previous locations, the animation controller's state, and also the final TrainHopping animation, which right now is responsible for chaining the previously mentioned _entranceTurnTween's hardcoded values.
PROPOSED SOLUTION:
Fix/remove the application of _entranceTurnTween on the FAB.

I personally think the whole floatingActionButtonAnimator class needs a huge refactor.
There is not a single log message shown when something goes wrong, it just sets to default.

Reproduces with current master 1.20.0-3.0.pre.163.
Animation<double> getRotationAnimation({Animation<double> parent}) {
    return Tween<double>(begin: 0.5, end: 0).animate(parent);
  }

Setting 0 to end leads to rotation only if begin is set to 0.

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Issue #25123',
      home: FlutterDemo(),
    );
  }
}

class FlutterDemo extends StatefulWidget {
  FlutterDemo({Key key}) : super(key: key);

  @override
  FlutterDemoState createState() => FlutterDemoState();
}

class FlutterDemoState extends State<FlutterDemo> {

  bool toggle = false;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          title: const Text("Flutter Issue #25123"),
        ),
        body: Center(
            child: Text("Hello world.")
        ),
        floatingActionButton: FloatingActionButton(
          onPressed:(){
            setState(() {
              toggle = !toggle;
            });
            print("FAB pressed.");
          },
          tooltip: 'Add',
          child: const Icon(Icons.accessibility),
        ),
        floatingActionButtonLocation: toggle ? FloatingActionButtonLocation.centerDocked : FloatingActionButtonLocation.startDocked,
        floatingActionButtonAnimator: AnimationToolkit.floatingButtonAnimator,
    );
  }
}

// AnimationToolkit.dart
class AnimationToolkit {
  // ...
  static const FloatingActionButtonAnimator floatingButtonAnimator = _FloatingButtonAnimator();
}

class _FloatingButtonAnimator extends FloatingActionButtonAnimator {
  const _FloatingButtonAnimator();

  @override
  Animation<double> getScaleAnimation({Animation<double> parent}) {
    return Tween<double>(begin: 1.0, end: 1.0).animate(parent);
  }

  @override
  Animation<double> getRotationAnimation({Animation<double> parent}) {
    return Tween<double>(begin: 0.5, end: 0).animate(parent);
  }

  @override
  Offset getOffset({Offset begin, Offset end, double progress}) {
    return end;
  }
}

@VladyslavBondarenko I think you mean that setting the end to 0 only leads to a rotation if begin is set to 1.0.

Setting 0 to end leads to rotation only if begin is set to 0.

@Zeswen, @cohortor, @NBTX - I just started looking at this. The scaffold code is trying, and sometimes failing, to blend the automatic rotation that occurs when a new FAB appears or disappears with the one provided by FloatingActionButtonAnimator with a TrainHoppingAnimation. It's not necessary in this case (nor does it work correctly), since a FAB isn't appearing or disappearing.
Can you-all explain what the desired FAB animation is?  I assume that the example, https://github.com/flutter/flutter/issues/61099#issuecomment-655540811, isn't exactly what you want since the FAB jumps between positions and jumps to 0.5 when the rotation animation begins?

@HansMuller Thank you for looking into this issue (and #25123).
My original problem (which still appears to be a problem on the latest stable branch) was that I was unable to stop the FAB button from rotating when re-appearing as a result of a state ($COND) change in the enclosing Scaffold:
Scaffold(
  floatingActionButton: $COND ? MyFabWidget() : null,
  floatingActionButtonLocation: FloatingActionButtonLocation.centerDocked,
  floatingActionButtonAnimator: const FabRotationStoppingAnimator(),
)

I.e.: what should the FabRotationStoppingAnimator() above look like if the default Scaffold behavior is to apply rotation to the FAB (IMO the default animation should only deal with scaling and opacity, not rotation, but who am I to say whats tasteful)?:
MyFabWidget is just a StatelessWidget that builds/returns a:
Material(
  shape: const StadiumBorder(),
  color:SomeColorOtherThanScaffoldBg,
  child: Container(
      height: 36.0,
      width: 52.0,
      child: Icon(...),
  ),
)

I suppose the only reason I noticed the rotating FAB bug was due to the rectangular StadiumBorder shape, which makes rotation look very unnatural and unpleasant.
Let me know if there was anything else I could help with.

@cohortor - thanks for the update. There's a cluster of problems here. One of them is that the FAB enter/exit animations can't be overridden.  Scaffold recognizes FloatingActionButton.extended classes as a special case and turns off the rotation part of the entrance animation. However, if you use another widget for the Scaffold's floatingActionButton, you can't avoid the entrance animation and it doesn't look good - as you pointed out.

Here's the corresponding test case
import 'package:flutter/scheduler.dart' show timeDilation;
import 'package:flutter/material.dart';

class Home extends StatefulWidget {
  Home({ Key key }) : super(key: key);

  @override
  _HomeState createState() => _HomeState();
}

class _HomeState extends State<Home> {
  bool toggle = false;

  @override
  Widget build(BuildContext context) {
    // Scaffold recogizes FloatingActionButton.extended classes as a special
    // case and turns off roation part of the entrance animation.
    /*
    final Widget floatingActionButton = FloatingActionButton.extended(
      backgroundColor: Colors.pink,
      onPressed: () {  },
      label: Text('wide wide wide'),
      icon: Icon(Icons.thumb_up),
    );
    */

    final Widget floatingActionButton = RawMaterialButton(
      fillColor: Colors.pink,
      onPressed: () {  },
      shape: StadiumBorder(),
      textStyle: Theme.of(context).textTheme.button.copyWith(
        color: Colors.white,
        letterSpacing: 1.2,
      ),
      child: Row(
        mainAxisSize: MainAxisSize.min,
        children: <Widget>[
          SizedBox(width: 16.0),
          Icon(Icons.thumb_up),
          SizedBox(width: 8.0),
          Text('wide wide wide'),
          SizedBox(width: 20.0),
        ],
      ),
    );

    return Scaffold(
      body: Center(
        child: RaisedButton(
          onPressed: () { setState(() { toggle = !toggle; }); },
          child: Text('toggle FAB'),
        ),
      ),
      floatingActionButton: toggle ? null : floatingActionButton,
    );
  }
}

void main() {
  timeDilation = 5.0;
  runApp(MaterialApp(home: Home()));
}

We could make it possible to avoid this problem by providing another Scaffold flag, or by extending FloatingActionButtonAnimator with entrance and exit animations. IMHO, the latter makes more sense.
All that said, this issue has not come up very often, and it sounded like you'd already routed around it. Is a fix still worthwhile?

@HansMuller I would have gladly used FloatingActionButton.extended() to avoid rotation, but the problem with that is its strictly enforced layout of the FAB's content/child. In my case I would like to show only an icon, without a label. Even if I passed in say a SizedBox.shrink() as label, the FAB.extended() layout (and size) is still unacceptable with a Row containing fixed paddings using SizedBoxes. Hence my need for a custom widget.
Extending FloatingActionButtonAnimator with entrance and exit animations probably does make sense. However, I would be grateful for any other fix as well, which would get me the desired outcome without having to update upstream flutter SDK code in floating_action_button_location.dart before release builds, which is my workaround for now:
// changing
const double kFloatingActionButtonTurnInterval = 0.125;
// to
const double kFloatingActionButtonTurnInterval = 0.0;

As of Master (3.6.0-3.0.pre.54), I can still reproduce this issue. Updating labels to reflect the same.

Code Sample
import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart';

void main() {
  timeDilation = 5;
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  bool _showFab = true;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      floatingActionButtonAnimator: CustomAnimation(),
      body: Center(
        child: TextButton(
          onPressed: () => setState(() => _showFab = !_showFab),
          child: const Text('Toggle FAB'),
        ),
      ),
      floatingActionButton: _showFab
          ? FloatingActionButton(
              onPressed: () {},
              tooltip: 'Increment',
              child: const Icon(Icons.add),
            )
          : null,
    );
  }
}

class CustomAnimation extends FloatingActionButtonAnimator {
  @override
  Offset getOffset({
    required Offset begin,
    required Offset end,
    required double progress,
  }) {
    return end;
  }

  @override
  Animation<double> getRotationAnimation({required Animation<double> parent}) {
    return Tween(begin: 0.5, end: 1.0).animate(parent);
  }

  @override
  Animation<double> getScaleAnimation({required Animation<double> parent}) {
    return Tween(begin: 1.0, end: 1.0).animate(parent);
  }
}

I can still reproduce this in v3.13.4.
Not sure if tags need to be updated?

@cohortor
another temp fix is to use the Stack and Positioned Widget Combo (in the Scaffold body argument) to display a the custom button at the bottom of the screen:
@override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample Code'),
      ),
      body:
      Stack(
        children: [
          Positioned(bottom: 16,
                     left: 0,
                     right: 0,
                     child:
                     CustomFAB(...)
          ),
          Column(...)
        ],
      ),
    );
  }


Fix rea

After a lot of thought (and agony), I unfortunately will have to reject this hack from being merged to QFAPI. While yes, QFAPI should do its best to support the most common usecases, even the wrong ones, I believe that the wrong usecases being "fixed" by this are more niche and the "fix" itself feels radioactive.
I'd rather recommend Silver's shiv mod than having such a hack integrated to QFAPI, even if it had a config option of some sorts. Considering the existence of that alternative solution (which is still a massive hack! but it is a third-party one and it is specialized on that), I'll have to reject this PR. Mod authors should consider fixing their mods anyway because yes, it can blow up on Fabric too, it just needs the right poke


Page 45 indent

shouldn't ob.select_set(False) be indented?

Hi, that's correct and I have reported the Erratum. I have added code for chapter 2 where the correct snippet is used
https://github.com/PacktPublishing/Python-Scripting-in-Blender/blob/main/ch2/0500_understanding_user_context.py#L55
thanks,
p.


Change the default module to commonjs

Fix #6807

Opened a little too fast. Close for now and will reopen later.


Update CLI extensions available doc

Update CLI extensions available doc.
Triggered by Azure/azure-cli-extensions - TRAVIS_BUILD_ID=397544588
https://github.com/Azure/azure-cli-extensions/commit/2e87e93b3a67ff52b6132cc9edfbbef7edd091ec

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update support.go to address nil pointer exception on error

Fixes a panic caused by nil pointer dereference encountered when e.supportClient.DescribeServiceLimitsCheckResult(checkID) errors and returns a nil result.
This can be observed in the following output:
I1012 22:10:16.090589       1 main.go:26] AWS Limits Exporter v0.3.0 started.
I1012 22:10:16.090904       1 support.go:172] Refreshing Trusted Advisor check 'fW7HH0l7J9'...
E1012 22:10:16.226973       1 support.go:233] Cannot retrieve Trusted Advisor check results data: SubscriptionRequiredException: AWS Premium Support Subscription is required to use this service.
        status code: 400, request id: 22a0ec40-7c20-4858-b40f-5b27d4c21ede
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x92a213]
goroutine 19 [running]:
github.com/danielfm/aws-limits-exporter/core.(*SupportExporter).Describe(0xc0001e57a0, 0xc0000da4e0)
        /build/core/support.go:236 +0x5a3
github.com/prometheus/client_golang/prometheus.(*Registry).Register.func1(0xc14680, 0xc0001e57a0, 0xc0000da4e0)
        /go/pkg/mod/github.com/prometheus/client_golang@v1.2.1/prometheus/registry.go:274 +0x3b
created by github.com/prometheus/client_golang/prometheus.(*Registry).Register
        /go/pkg/mod/github.com/prometheus/client_golang@v1.2.1/prometheus/registry.go:273 +0x154

Thanks!


New driver: st7567s

Hi, please list a new driver supporting embedded-graphics:
https://crates.io/crates/st7567s

Please open a PR if you want to add this driver to the list of supported drivers. Note that the source for the list is located in the doc comment at the top of src/lib.rs and duplicated in the README.

https://github.com/embedded-graphics/embedded-graphics/pull/752


Extends 'spo list get' command with support for retrieving any default list in a given site

Closes #5856
Please note that I was rebasing the branch after my last commit.

Seems like something went wrong with this PR, can you have a look @tmaestrini?

Yes, of course @milanholemans - sorry for that! 🤦♂

I will create a new PR, @milanholemans


accessing the server from a private ip

having troube here.. i can consistently set up a openbaraar2.x  server in either the clear net, tor, or dualstack mode on a virtual private server no problem.. But when i try to set up the server on my netwrok the only mode i can get working is the clear net version. I cant get a server on my network to run in tor. Why is this? i uncommented
#SOCKSPolicy accept <IP_ADDRESS>/16
in my torrc file and configured the ip address range to accept the client i was trying to use. and still noting..
First i tried this in a raspberry pi 3 running raspberrian but when that didnt work i threw debian on an old tower i had lying around and installed the server on that.. the same os the vps use and the some settings with the same client yet it dont work. any thoughts guys?

my java console logs have this error
fs.js:652 Uncaught Error: ENOENT: no such file or directory, open '/home/user/openbazaar-desktop/js/templates/modals/TorExternalLinkWarning.html'
at Object.fs.openSync (fs.js:652:18)
at Object.module.(anonymous function) [as openSync] (ELECTRON_ASAR.js:172:20)
at Object.fs.readFileSync (fs.js:553:33)
at Object.fs.readFileSync (ELECTRON_ASAR.js:508:29)
at loadTemplate (/home/isellcoolshit/openbazaar-desktop/js/utils/loadTemplate.js:18:21)
at _class.render (/home/user/openbazaar-desktop/js/views/modals/TorExternalLinkWarning.js:49:5)
at openExternal (/home/user/openbazaar-desktop/js/utils/dom.js:85:8)
at HTMLAnchorElement. (/home/user/openbazaar-desktop/js/utils/dom.js:120:9)
at HTMLDocument.dispatch (/home/user/openbazaar-desktop/node_modules/jquery/dist/jquery.js:5183:27)
at HTMLDocument.elemData.handle (/home/user/openbazaar-desktop/node_modules/jquery/dist/jquery.js:4991:28)
any ideas?

Pinging @cpacia @tyler-smith


New issue with recently updated Direwolf20 1.12.2 pack

umm, I disabled the mod but left it in the pack (using Twitch app) and the mod pack is running fine now, but I'd like to use this mod too...
crash-2018-07-19_21.11.15-client.txt

also, after posting that, I was redirected to another site for shoes?! wtf? lol...

You didn't need to open an issue on CB's repo, he doesn't get emails from it anymore, plus i have direct communication to him. As for me not replying in 1 day before you opened that issue, i have a life outside modding. As for your issue report. The crash report contains no stack trace, meaning i have absolutely no way of seeing whats wrong. Please upload your latest.log file.

crash-2018-07-25_14.39.29-client.txt
latest.log
debug.log

Sorry, I did not know bout the email thing, as for not replying, I know, I wasn't really expecting a timely reply, I know people have lives away from games, that is one of the issues for me is that I rarely have time for games these days myself... as you can see, I just now posted all that I have on the game, yes I posted aa crash report again but it's a new one, who knows, might contain something different...

Please try http://chickenbones.net/maven/codechicken/NotEnoughItems/1.12.2-<IP_ADDRESS>/ and post your debug.log & crashreport (if applicable)

hey, that fixed it, thanks! I didn't know there was an update, the last I looked the 233 was the latest...
debug.log
latest.log

Cool, Thanks.


Fix pointer signedness comparison issues.

Wherever possible, I've cast NSUInteger back to NSInteger as we're not using any values large enough for this to be an issue. This will need careful checking, as it does make assumptions about the size of potential values.

looks good to me, thanks!


Release a new version compatible with Micronaut 3.0

Please follow the instructions in https://github.com/micronaut-projects/micronaut-core/issues/5607 and update that core issue with the information related to the upgrade.

Closed by #158


JsonSerializationWriter.WriteNonParsableObjectValue does not support anonymous objects

I was passing values into the AdditionalData property on the type generated in my Kiota client and I noticed that anonymous object values were being passed as empty objects.
{ "myAdditionalDataProperty": { } }

From debugging I can see that here https://github.com/microsoft/kiota-dotnet/blob/42ea74edf45d473462dd050661b1972ce14c15e1/src/serialization/json/JsonSerializationWriter.cs#L447 T comes through as "Object" so get properties returns no results.
No error is thrown, the properties just never show up. It's possible this affects other types but I only tested with anonymous objects.

In trying to work around this issue, it seems the problem is worse than I thought.
I made a my own class for the data and that also failed to serialize properly, then I tried to use a Dictionary<string, object> and that didn't work either.
The PR I submitted should work for custom non parseable classes but for dictionary should probably have it's own method. I will try to make a more extensive PR.

Hi @greg-ww
Thanks for using kiota and for reaching out.
I have reviewed the PR before I saw this issue (orders of notifications on GitHub)
I'm curious to understand in what scenario do you feel like you need to rely on anonymous types?
For context, the serialization interface here was never meant to be used by humans, just to support the generated code.
Code that is generated from a schema, and should give us enough context not to have to rely on anonymous types.

Thanks for the additional context here.
Yes, it's a limitation today. https://github.com/microsoft/kiota/issues/62

Have you considered making the types that you pass as values of the additional properties implement IParsable instead?

Have you considered making the types that you pass as values of the additional properties implement IParsable instead?

Yeah that's my next workaround, I only know I need to do that because I debugged into JsonSerializationWriter though. At minimum I'd expect an error if the types I tried to use are unsupported.

This is probably a good situation for other cases. Can you tweak this exception message as part of your PR please?
https://github.com/microsoft/kiota-dotnet/pull/307/files#diff-0f94b98a554904a6aea6e2d994e76fd110b76d2c96fd51d29e30ddad644ac620R552


Taylor/type array test

:tada: This PR is included in version 1.0.14 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


SLF4J2

Bump SLF4J 2.0.0
Avoid error reported in LOG4J2-3139
Fix test about SLF4J-421

Hi @terrettaz,
Thank you for you contribution. Since the SLF4J binding should go in the log4j-slf4j20-impl module, I have merged the slf4j-2.0 branch into release-2.0. Can you rewrite your contribution in the new Maven module?
Regarding the stack-valued MDC implementation, there is an ongoing thread on the dev mailing list regarding the proper course of action. This is something that requires a consensus among devs and you are more than welcome to express your opinion.

I have two concerns with this:

Because this upgrades log4j-slf4j18-impl to SLF4J 2.0 anyone using SLF4J 1.8 might have problems. That said, 1.8 never had a GA release. So I believe we should release the 2.0 module and remove the 1.8 module.
From what I can tell the NDC queue is private to Log4jMdcAdapter. Thus log4j has no knowledge of it at all, which means it might as well have been implemented as a no-op.

Hi, thanks for the comments!
I agree this is much better to use the new module and probably delete the slf4j18, I can include the deletion in this PR.
I've checked the code of slf4j-reload4j or logback and I didn't really see the use of these new methods added in MDC. So in order to benefit from this new SLF4J api, I added the option to wire the top of the stack to the MDC of log4j. I added a unit-test to emphase the idea.
I also prepare and option to activate this behaviour but didn't find the way to get options from the config. Any suggestion from the core developers on how to properly configure log4j-slf4j20-impl

As a user agree with @rgoers's 1). I found found the "18" artifact useful for migration, as it works nicely with SLF4J2, but it's confusing, because there was no such release of SLF4J.
Feedback: I ended up here, because I wanted to PR a doc fix for this page:
https://logging.apache.org/log4j/2.x/log4j-slf4j-impl/index.html
again, it's confusing it refers to "1.8" when there's no such stable release. I believe this should be also included in this PR or a following one.

@terrettaz,
I modified your original PR to work with the current pattern converters (#1025). What name should I put in the release notes?

@terrettaz,
I modified your original PR to work with the current pattern converters (#1025). What name should I put in the release notes?

I am still working on this PR to include all your comment, should be finish soon.
About my name: Pierrick Terrettaz
Thanks

@terrettaz, if the rest of the team agrees, we'll merge #1025 instead (which contains your initial contribution and my remarks), so no need to improve this PR.
Thank you for your contribution.
Taking account of the recent changes the log4j-slf4j20-impl bridge is almost complete, but the log4j-to-slf4j bridge probably needs an SLF4J2 version (module) to profit from the new SLF4J 2.0 features.

@ppkarwasz Thanks you for your comments!
I still pushed one commit in my branch you might be interested in. I added several unit tests to cover different corner cases especially when Log4j NDC is used along with MDC.pushByKey(null, "value")


Add oauth scope (for entra id)

When using Entra ID as identity provider, we need to specify the correct scope when retrieving a token (see https://docs.camunda.io/docs/8.5/self-managed/setup/guides/connect-to-an-oidc-provider/)
I've added it to the java client and spring properties.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Don't use CUDA base image for CPU-only build

We can do this for the individual CPU images as well but I would question whether we even need CPU individual images


Implementation of GetUsers view, viewmodel and testing

Addition of UsersPanel Class:
Created a new UsersPanel class to display user information in a tabular format.
The panel is initialized with columns for user details like First Name, Last Name, Email, Tags, Desired Compensation, and Is Owner.

Integration of UsersPanel into MyProjectsPanel:
Added a JButton to MyProjectsPanel to fetch and display user information.
Included a UsersPanel instance in MyProjectsPanel.
Updated the actionPerformed method to handle the button click event, fetch user data, and display it in a new frame containing the UsersPanel.

Enhancements to MyProjectsPanelViewModel:
Added methods to handle user data (setUsersData) and to store and retrieve the selected project ID.

Adjustments to the MyProjectsPanel Layout and Behavior:
Modified the addProjects method to include a hidden project ID column, essential for internal logic but not visible to users.
Updated property change handling to manage new user data updates and project selections.

New Unit Tests for MyProjectsPanel:
Added tests to verify the new functionality, including handling user data updates, displaying user information, and managing project data.

I've made adjustments based on Rawq's suggestions. Thank you for the feedback!


MP-89 Fixes column types in projects table

This fixes column data type in projects table, so that they're represented as integers or integer arrays.
The way it is done has 3 objectives in mind - to be able to apply this in staging and production without messeing up, to be able to rollback easily, and to not further mess up schema.rb. For every affected column it:

adds a _tmp suffix to old column name
adds a new column with target name and correct type (integer or integer[])
if the old column was already correct type, copies the value to the new column as is
if the old column was a string, copies the value to the new column cast to integer or integer[]

To roll this back, we drop the new column and remove the _tmp suffix from the old column, whose content is unchanged
To clean the mess up when this is tested to be correct, in a later migration we will just drop all _tmp columns and all is good again, except for
https://vizzuality.atlassian.net/browse/MP-89

tested locally with dumps from both staging and prod, seems to work just fine!!! <3


[BUG] After you delete the cluster network and network configuration, you can no longer select the released NIC

Describe the bug
After you delete the cluster network and network configuration, you can no longer select the released NIC
To Reproduce
Steps to reproduce the behavior:
1.Create a cluster network
2.Create a network configuration
3.Select an available NIC , Created successfully
4. then delete the cluster network and network configuration
5. Repeat step 123, but the previously available NIC is grayed out and cannot be selected
Expected behavior
After deletion, I can select it again
Environment

Harvester ISO version:  1.1.0
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context
Add any other context about the problem here.

Hi @techstudio-project, as a workaround, could you please try bringing up the interface manually and creating the "cluster network" and "network config" again?
It seems the network controller only set no master for the uplink interface while removing Vlanconfig. The interface becomes "down," so the UI grays out the option.
cc @yaocw2020

Duplicated with https://github.com/harvester/harvester/issues/3166


bugtool: Capture memory fragmentation info from /proc

This information can be useful to understand why memory allocation in the kernel may fail (ex. for maps or for XFRM). I've checked that these two files are accessible from a typical cilium-agent deployment (on GKE).

LGTM, sorry for the delay

No worries at all. I figured it wasn't pressing and could wait for you to be back.


delete CILogon staged certificate

@minrk I am wondering whether it would be useful to delete the staged certificate and only keep the encrypted version.
While the user is connected, poll is probably continuously using the certificate.
Is there a way to detect if the user is not connected, maybe with a timeout, and delete the staged certificate at that point?

In what context? The cert isn't used for anything at all, here.  You can check the last_activity of a user, to see how long it's been since they've been seen. The resolution isn't better than about 5 minutes, though.

in the context of a spawner that uses the CILogon certificate.
It would be useful to have an unstage method that the spawner can call once jupyterhub-singleuser exits. This way we do not keep around an unencrypted cert if not needed (let's assume TPM encryption).
So here the timeline:

user authenticates with oauthenticator and gets a certificate stored encrypted with TPM or some other way
CILogonSpawnerMixin stages the certificate
the spawner starts jupyterhub-singleuser
when jupyterhub-singleuser exits, the certificate it still around, I'd rather delete it for security

#20 unstages the certificate file after it stops.

Awesome, thanks!
On Sat, Oct 10, 2015, 03:25 Min RK<EMAIL_ADDRESS>wrote:

#20 https://github.com/jupyter/oauthenticator/pull/20 unstages the
certificate file after it stops.
—
Reply to this email directly or view it on GitHub
https://github.com/jupyter/oauthenticator/issues/18#issuecomment-147071716
.


ace: power: replace pseudo-assembly movi

When switching off memory banks we cannot use movi with arbitrary immediate arguments, they will be converted by the compiler to memory accesses. Only constants within the allowed range should be used.

As we've verified, this PR doesn't fix https://github.com/thesofproject/sof/issues/9268 but the code that it replaces does seem to be dangerous, as identified by @andyross

This change causes failures in all power flows on MTL/LNL/PTL. Considering that it wasn't a fix for any known issue, I suggest simply reverting it https://github.com/zephyrproject-rtos/zephyr/pull/75689.


Add support for Github tokens

Add support for Github tokens in addition to basic auth
Change config so passwords come in from separate environment variables.
Repos and authors still come in from the CONFIG variable.
Update godeps
Add Dockerfile and docker-compose.yml for local development

@brentdrich Can you take a look at this? I also want to follow up with some UI changes, but I'll do that in a separate PR.

Taking a look, thanks!

LGTM except I'd like to keep specific prmonitor instance configs out of the repository.

Thanks for the contribution!


feat: add TestLessThanOrEqual hint

Hi @zmalatrax
Changes made:

Implemented and tested the TestLessThanOrEqual hint

Here are the test results:

Please let me know if any additional modifications are needed, and I appreciate any possible feedback.

Hi @zmalatrax
Fixed the documentation and the program comparison. I changed the PR to ready for review but if there's any modification needed please let me know.

Forgot to mention that this closes #133


Convert an image in README to table

This should better support accessibility features,
including screen readers. It also allows for the
searching of the text in this table.

Is there a reason this was closed? Is it not an improvement? Could I change something to make it so?


MWPW-144821: Load media from content root

Resolves: MWPW-144821
Updates elements with paths starting with ./media_ to use the base path defined in CONFIG.contentRoot
Test URLs
Before: https://main--dc--adobecom.hlx.page/documentcloud
After: https://mwpw-144821--dc--adobecom.hlx.page/documentcloud

Codecov Report
Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.97%. Comparing base (34ca8f4) to head (abf6b6c).
Report is 5 commits behind head on stage.

Files
Patch %
Lines

acrobat/scripts/scripts.js
88.23%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #658      +/-   ##
==========================================
- Coverage   98.01%   97.97%   -0.05%
==========================================
  Files          34       34
  Lines        4135     4152      +17
==========================================
+ Hits         4053     4068      +15
- Misses         82       84       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Feature] Snapshots should respect generate schema/database name macro

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature
Historically, snapshots require you set set an explicit target_schema and target_database - meaning by default, regardless of what environment you're in (dev, ci, prod, etc.), when you run dbt snapshot it will build to the same table.
This can be problematic when trying to test out changes to existing snapshot or develop a new snapshot. Now that we have deferral and dbt clone, it no longer makes sense that snapshots wouldn't respect generate_schema_name / generate_database_name like other resources (models, seeds, etc.).
We need to consider backwards compatibility for this change. Perhaps we makes these configs optional and if you don't set a target_schema or target_database, we default to using the generate_x_name macros.
Describe alternatives you've considered
Our pal @dbeatty10 often configured his snapshots as so:
{% snapshot my_snapshot %}

{{
    config(
      target_database=target.database,
      target_schema=target.schema,
      …

Our pal @jeremyyeo often does:
{% snapshot snappy %}

{{
    config(
        target_schema=generate_schema_name('snapshots'),
        ...

Relevant docs / discussions

Why is there only one target_schema for snapshots?
Using dynamic schemas for snapshots

From the snapshots github discussion:

@jtcohen6 do you happen to know why snapshots were originally built with this explicit required override for target_schema? Was this implemented before deferral existed?

Here's the history I was able to Indiana Jones real quick:

dbt 0.5.1 Raiders of the Lost Archive -- version your raw data to make historical queries more accurate

target_schema: where to archive the data to

dbt 0.18.0 Added --defer and --state flags to dbt run, to defer to a previously generated manifest for unselected nodes in a run. (#2527, #2656)

@QMalcolm this feels like something we should have some tests to capture. And for future features, should we consider adding some guidelines of adding new features?

Opened a new issue in dbt-labs/docs.getdbt.com: https://github.com/dbt-labs/docs.getdbt.com/issues/5806


test(parser): test for the parser-> Rules

Would like to have some suggestions regarding the testing.
Q. Is the current approach of writing test is correct?
Q. Shall I write unit test or e2e test for parser?
Q. Any best practice.
cc @IvanGoncharov @acao

@pranshuchittora Thanks for the effort 👍
But covering parser with tests is a part of the GSoC project and I don't think it's a good idea to start working on it ahead of GSoC.
Please focus on your "GSoC proposal" instead, where you can include your proposals on how to better test this code.


Update @nx/workspace to 19.6.1

Update Nx from 19.6.0 to 19.6.1

Auto-generated by create-pull-request

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.63%. Comparing base (82cd8ae) to head (2c6e3ab).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   97.63%   97.63%
=======================================
  Files          17       17
  Lines         211      211
  Branches       30       30
=======================================
  Hits          206      206
  Misses          5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix compilation errors and warnings for UE 4.26

Fixes issues for UE 4.26.
Thought it's a right branch.

Unfortunately just fixing the compilation errors and warnings isn't enough to get the integration working with UE4 4.26, these changes also can't be made to the 4.25+ branch because they will break it. Our February release will include an updated version of the integration for UE4 4.26 which will also be pushed to a new branch on GitHub.

Unfortunately just fixing the compilation errors and warnings isn't enough to get the integration working with UE4 4.26, these changes also can't be made to the 4.25+ branch because they will break it. Our February release will include an updated version of the integration for UE4 4.26 which will also be pushed to a new branch on GitHub.


One shot deploy fails for AWS deployment

Problem: When running the aws.sh deploy script the following error occurs...

unless deploying locally, either --dynamic-etcd-nodes or --static-etcd-volume needs to be provided

It seems like the script is missing the etcd info.
https://github.com/pachyderm/pachyderm/blob/master/etc/deploy/aws.sh#L257
It should most likely add the following flag...
--dynamic-etcd-nodes=3

nvm ... looks like it is handled here https://github.com/pachyderm/pachyderm/pull/2478


[Hack-together] Reservations are not displayed correctly

Are you accessing the project from the GitHub Codespaces?

[ ] No, I am running the project on my local machine (I will fill in the OS section below)
[x] Yes, I am using GitHub Codespaces.

Note: The project is optimized to run on Codespaces. We welcome contributions to enhance it for cross-platform local development, but it's not something we will prioritize right now. Thank you!

Describe the bug
On the Reservations page of the portal, the list of reservations is not displayed correctly and some content is cut off.
To Reproduce
Steps to reproduce the behavior:

Run the application with npm run start
Open the portal app
Click on Welcome, Guest on the top right side of the home page, and then Login
Sign in
Go to the home page, select a listing, and create one or more reservations
Navigate to the Reservations page (/me/reservations)
The list of reservations is not displayed correctly

Expected behavior
The reservations should be shown correctly and all content should be visible.
Screenshots

OS (please complete the following information):

OS: Linux
OS Version: codespaces-a87b53 5.15.0-1042-azure
npm version: 9.8.1
Node.js version: v18.15.0
output of azd version: azd version 1.2.0 (commit 99ea7577f0df0df2ba34b677da189fafba18c0f7)

Additional context
None.

This issue is already addressed in #242.

Thanks for pointing that out @Tanmai2002 - Closing this issue now


Yoshioka/test get angle2

余分な箇所を削除しました

LGTM

This was not a test of "get angle", so I'll close it.


godecl -i: print internal declarations

Codecov Report

Merging #103 (8b6efe4) into main (5c63111) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   93.89%   93.89%
=======================================
  Files          14       14
  Lines        5572     5572
=======================================
  Hits         5232     5232
  Misses        261      261
  Partials       79       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c63111...8b6efe4. Read the comment docs.


Be able to simulate arbitrary solidity code

Is your feature request related to a problem? Please describe.
Right now the README makes it easy to get smart contracts running in ganache by leveraging github.com/oceanprotocol/contracts. This has a friendly fork of Balancer V2, and other Ocean code.
But there are many scenarios where we want other smart contracts, or even to vary those.
Describe the solution you'd like
Make it easy to simulate arbitrary solidity code, rather than bias to the Ocean contracts.
Prerequisites:

first #63 - conda -> pip
then #71 - .sol into assets/, use brownie

#63 Might help here as it offers an alternative installation without conda, thus enabling brownie.

#63 Might help here as it offers an alternative installation without conda, thus enabling brownie.

I've updated #63. It's now "replace conda with pip". Not as an alternative installation, as the installation. Therefore solving #63 will help a lot for this issue.

Changed from high -> mid priority to help others understand what issues are even higher priority than this

It's now easy to have arbitrary solidity code! :)
#71 took care of it. This comment has more details.


[Bug] Standalone color picker not working with Hex alpha

Does this issue occur when all extensions are disabled?: Yes

The standalone color picker don't works well with hexadecimal alpha. No matter how much alpha you select, the color picker totally ignores it.
There is two possible solutions:

Fix it and make the color picker use correctly the alpha level.
Add hexadecimal with alpha to the supported color system and disable the alpha option in the normal hexadecimal.

VS Code Version:  1.80.2     2ccd690cbff1569e4a83d7c43d45101f817401dc     x64
OS Version: Windows 11 pro

Steps to Reproduce:

Open color picker
select any hexadecimal value with alpha
press replace

This if fixed


Included Azure CLI script to install LAD 3.0 extension for VMSS instance

I found it very difficult to find the document to install LAD 3.0 extension for VMSS instance because all of the document talked about VM only. Even customer felt the same thing. So I took time to modify update the script to install LAD 3.0 extension for VMSS instance as well as this will empower our end users to do it themselves.

@samueljamkhandi-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @samueljamkhandi-MSFT Your pull request has been assigned to the author for review. Would you take a moment to link your GitHub & Microsoft accounts and join the MicrosoftDocs organization per the Docs contributor guide? Thanks!

#assign: @mimckitt

#unassign @axayjo

#sing-off

#sign-off


Add CI for testing compatibility of antrea with previous four K8s versions

Add CI for testing compatibility with previous four K8s versions using Cluster API, with provider as AWS.

/test-rancher-e2e

/test-rancher-e2e

/test-rancher-e2e

@jainpulkit22 ,
Need to resolve conflicting files on the PR

Our cloud CI has been migrated to jenkins.antrea.io, please continue verifying the job changes on it.

@jainpulkit22 are you still actively working on this? please help to estimate your bandwidth and make sure you deliver this in Antrea 2.0, or please remove it from the milestone if it's not a must-have.
cc @XinShuYang @rajnkamr

@luolanzone ,
It is good to have candidate and aligned with cloud Jenkins goals wrt CAPA. We are considering this for 2.0
It was initially part of 1.15 however was moved out.

Paused for now, shifting to CAPV testbeds or GCP testbeds.


Can PMP differentiate between M and U once PMP entry was locked?

Hi,
Similar to #476 , when pmpcfg.L=1, it seems can't differentiate M and U(S) mode.
Imagine the following case(M mode and U mode only):
For an address block, we would like it to be
-RW for M-mode
-no access for U-mode
It seems we can't achieve this goal directly by using PMP.
Yes, similar function can be achieved by setting lower indexed PMP entry for U-mode before changing from M-mode to U-mode.
But it also creates a moment  M-mode have all access privileges(RWX) at the transition from M-mode to U-mode.
Regards.

Your interpretation appears to be correct.
There is a proposal being made for an enhanced PMP (with several other
features) that fixes this problem.
Join the Trusted Execution Environment TG to find out more:
https://lists.riscv.org/g/tech-tee/
On Thu, Apr 9, 2020 at 1:07 AM tsaiyenting<EMAIL_ADDRESS>wrote:

Hi,
Similar to #476 https://github.com/riscv/riscv-isa-manual/issues/476 ,
when pmpcfg.L=1, it seems can't differentiate M and U(S) mode.
Imagine the following case(M mode and U mode only):
For an address block, we would like it to be
-RW for M-mode
-no access for U-mode
It seems we can't achieve this goal directly by using PMP.
Yes, similar function can be achieved by setting lower indexed PMP entry
for U-mode before changing from M-mode to U-mode.
But it also creates a moment M-mode have all access privileges(RWX) at the
transition from M-mode to U-mode.
Regards.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-isa-manual/issues/505, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJU7VNTYSNPZJYL4JKLRLV623ANCNFSM4MERBUZQ
.


HP Chromebook 14a g5(Grunt) no wifi

Tested ubuntu and debian builds on my chromebook and the wifi adapter is not being detected. On the back of the laptop it says the network card is Qualcomm Atheros QCNFA344A which i think needs the ath10k driver which is currently not included in the kernel.

Can confirm that wifi is working properly now, thanks.


Make switch network instance sharable

See https://wiki.lfedge.org/display/EVE/K3S+flat+network+in+EVE
When deploying e.g., K3S on EVE it would be nice if we can avoid the NAT we get with the Local network instance by

Using a switch network instance, yet having it be a management port, so that each App Instance gets its own external IP address
Picking MAC addresses for the app instances which are not likely to conflict with app instances running on different edge nodes

The plumbing is different in that the ethN devices managed by nim are renamed to kethN, and nim sets up ethN bridges. Then the IP configuration happens on ethN.
When a switch network instance is configured it goes and finds the ethN bridge instead of creating a bnX bridge. We still support bnX bridges for switch network instances which have no external ports, but the code seems to have grown checks elsewhere which prevent such switch NIs from being deployed.
The reporting of the AllocatedIPAddress for an app instance using a switch NI now uses the DHCP snooping and the code has moved to zedrouter to make sure we always update AppNetworkStatus correctly. @naiming-zededa
@cshari-zededa the MAC address algorithm applies to all switch network instances, thus might help even if we run a switch network instance on eth1 for application traffic

Is this ready for a proper review now @eriknordmark -- or should we wait for the traffic on ML around your proposal?

Is this ready for a proper review now @eriknordmark -- or should we wait for the traffic on ML around your proposal?

Is this ready for a proper review now @eriknordmark -- or should we wait for the traffic on ML around your proposal?

It's ready for review.

Is this ready for a proper review now @eriknordmark -- or should we wait for the traffic on ML around your proposal?

It's ready for review.


Incompatible with Ledger in gameversion 1.17.1

I still have this issue with the latest 1.17.1 FabricProxy-Lite-1.1.5.jar and ledger-1.1.1.jar
Should this fix have been applied to the 1.17.1 builds, or was the fix only for 1.18.x?

You can use 1.1.6.

Will 1.1.6 work with game version 1.17.1?
On CurseForge it only states 1.18


Generated code should not import its types

This can lead to ambiguity and thus compilation failure.
Here is an example with generateBuilderPackage=true, not sure if it also applies to runtime-dep (I guess it does) that also uses @Inline of Bar, so the problem may stem from the combination of all this.
For type Foo, builderPackage="my.pkg" you'll get:
import my.pkg.Function;
import io.Bar;

public class BarFoo extends FooFluentImpl<BarFoo> implements Bar<Foo>{

    private final FooBuilder builder;
    private final my.pkg.Function<Foo,Foo> function;

    public BarFoo(my.pkg.Function<Foo,Foo> function){
            super();this.builder=new FooBuilder(this);this.function=function;
    }
    public BarFoo(Foo item,my.pkg.Function<Foo,Foo> function){
            super(item);this.builder=new FooBuilder(this, item);this.function=function;
    }
    public BarFoo(Foo item){
            super(item);this.builder=new FooBuilder(this, item);this.function=new Function<Foo, Foo>() {
    public Foo apply(Foo item) {
        return item;
    }

Now this is all fine, until Foo is actually the name of a type of this project like ... Function.
Then the compiler complains that the constructors have the same erasure.
This is really a shame, as this could be fixed by just removing the import statements (as the framework types like my.pkg.Function are used with their fully qualified name throughout).
I hope this makes sense (and also that adding imports is an explicit choice of yours and that it can be removed, ie it's not the codegen library that tries to be smart :( )

As of 0.40.0 we have the following changes:

All Classes (included internal ones) are referenced by fully qualified name (I intend to exclude generated and user classes in the future, but I am not really sure).
Classes like Predicate and Function have been dropped in favor of the java.util.function ones.

So, I think that these two changes should deal with the issue. I am closing, with apologies for the insanely long time it took. And we can reopen if these are not enough.


peripheral: "safer" API like the one svd2rust generates?

right now you can write any u32 in the peripherals' registers. This is bad because you may write 1s to reserved bits that are supposed to always be set to 0.
svd2rust generates a "safer" API that prevents this kind of problem. But it generates the API from SVD files and I don't if there are SVD files for these core peripherals.
Should we manually implement an API like that? Or, perhaps, should we be more conservative and just provide bit masks (as consts -- think const SCB_CPACR_CP10: u32 = 0b11 << 20) to begin with? (the bit masks would save you the trouble of having to look into the documentation for the right bit offset of each bit field but they are not fool proof as you can still write to reserved bits)
cc @thejpster

I'm OK with having bitmasks available as const to start off with.
I've sometimes wondered (when writing C) if a stronger type system would help ensure I only use the correct bitmasks with the correct registers. Perhaps newtype and judicious use of the Ops traits could achieve that. But would register |= bitmask be better that just inlining a register.set_foo(bar) function call?

I'm OK with having bitmasks available as const to start off with.

Do you know if we can get the bitmasks from somewhere like a SVD file? Extracting them manually from the reference manual sounds pretty boring.
I personally consider register |= 0b01 where 0b01 is a 2-bit bitfield (not two disjoint flags) actually evaluating to register.inner = (register.inner & !0b11) | 0b01 an abuse of the operator or at least would deem it too magical.

Briefly:
Humm, I don't know.
It really is.
I was probably thinking of a scenario where I knew the bits in the field
were currently at zero (like power on). I would fully expect the user to
clear the field if required as per your example, but the important thing is
that the compiler would reject the operation if you used the wrong bit
field. Maybe.
On 1 Nov 2016 22:19, "Jorge Aparicio"<EMAIL_ADDRESS>wrote:

I'm OK with having bitmasks available as const to start off with.
Do you know if we can get the bitmasks from somewhere like a SVD file?
Extracting them manually from the reference manual sounds pretty boring.
I personally consider register |= 0b01 where 0b01 is a 2-bit bitfield
(not two disjoint flags) actually evaluating to register.inner =
(register.inner & !0b11) | 0b01 an abuse of the operator or at least
would deem it too magical.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/japaric/cortex-m/issues/7#issuecomment-257716296, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA6lj0nz6I_PzucSdFLTeFQQw9fEeXBiks5q57rrgaJpZM4KXwI-
.

Do you know if we can get the bitmasks from somewhere like a SVD file? Extracting them manually from the reference manual sounds pretty boring.

I've been curious about this for some time. Frustratingly and bafflingly this appears to have never been published, neither by ARM nor by any other vendor, they all write the core support code manually.
Someone did do the legwork and assemble all the system control registers in a machine-readable format (see this) but unfortunately it's not really easily convertible to SVD because there is no equivalent of the <name> field of <enumeratedValue>. It seems like an okay starting point but still an enormous amount of grunt work.

Do you know if we can get the bitmasks from somewhere like a SVD file?

Well, and there's always the option of extracting them from the CMSIS headers with the help of a few regexps.

Frustratingly and bafflingly this appears to have never been published, neither by ARM nor by any other vendor, they all write the core support code manually.

To my surprise, I just discovered that this is not the case. The register definitions for TM4C that I've been converting include registers and fields of NVIC, MPU, FPU, DBG and SYST (confusingly, all grouped under "NVIC"), in other words, the entire 0xE000E000 block. We are missing FPB, DWT, ITM, ETM and TPIU, but that doesn't seem like a major loss anyhow.
So we have those in SVD format, see https://github.com/m-labs/dslite2svd/blob/master/svd/tm4c129x.xml (not linking to the range for obvious reasons). It's not obvious that all of them should be used, or used as-is (the NVIC registers are not declared as arrays, limiting their usefulness) but I think that's an excellent starting point.

There are SVD files in the CMSIS 5 repository: https://github.com/ARM-software/CMSIS_5/tree/develop/Device/ARM/SVD
They seem rather incomplete, though.

These are basically useless, I don't know why ARM even publishes them.

There is also some discussion about this over in rust-lang-nursery/embedded-wg#46.

An update:
@docbrown has been working on an SVD file. He doesn't plan to continue working on this in the foreseeable future, so anyone who's interested, feel free to pick this up. He's given permission to use the SVD file in any way we see fit.


ffprobe error trying to use ffmpeg-location option

I am working on a python program
I have the options as
ydl_opts = {
'format': 'bestaudio/best', # choice of quality
'postprocessors': [{
'key': 'FFmpegExtractAudio',
'preferredcodec': 'mp3',
'preferredquality': bitrate
}], # only keep the audio
'logger': loggerWindow(),
'audioformat' : "mp3",      # convert to mp3
'noplaylist' : playlist,    # only download single song, not playlist
'ffmpeg-location': programDir
}
The program directory:
C:\Users\My_User\Documents\Python Projects\SongDownloader\src\downloader
and in the downloader folder is ffmpeg.exe and ffprobe.exe
it gives me an error saying
Traceback (most recent call last):
File "C:\Program Files\Anaconda3\lib\threading.py", line 914, in _bootstrap_inner
self.run()
File "C:\Program Files\Anaconda3\lib\threading.py", line 862, in run
self._target(*self._args, **self._kwargs)
File "C:\Users\mitchell\Documents\Python Projects\SongDownloader\src\downloader\functions.py", line 126, in download
ydl.download(url)
File "C:\Program Files\Anaconda3\lib\site-packages\youtube_dl\YoutubeDL.py", line 1791, in download
url, force_generic_extractor=self.params.get('force_generic_extractor', False))
File "C:\Program Files\Anaconda3\lib\site-packages\youtube_dl\YoutubeDL.py", line 705, in extract_info
return self.process_ie_result(ie_result, download, extra_info)
File "C:\Program Files\Anaconda3\lib\site-packages\youtube_dl\YoutubeDL.py", line 751, in process_ie_result
return self.process_video_result(ie_result, download=download)
File "C:\Program Files\Anaconda3\lib\site-packages\youtube_dl\YoutubeDL.py", line 1435, in process_video_result
self.process_info(new_info)
File "C:\Program Files\Anaconda3\lib\site-packages\youtube_dl\YoutubeDL.py", line 1773, in process_info
self.post_process(filename, info_dict)
File "C:\Program Files\Anaconda3\lib\site-packages\youtube_dl\YoutubeDL.py", line 1839, in post_process
self.report_error(e.msg)
File "C:\Program Files\Anaconda3\lib\site-packages\youtube_dl\YoutubeDL.py", line 568, in report_error
self.trouble(error_message, tb)
File "C:\Program Files\Anaconda3\lib\site-packages\youtube_dl\YoutubeDL.py", line 538, in trouble
raise DownloadError(message, exc_info)
youtube_dl.utils.DownloadError: ERROR: WARNING: unable to obtain file audio codec with ffprobe

The opts key is ffmpeg_location not ffmpeg-location. The error is saying that ffprobe found via PATH is broken.

oh I see... will this option work if i give it a string for ffmpeg and ffprobes directory?

will this option work if i give it a string for ffmpeg and ffprobes directory?

yes

I am sorry for the late response. I am a bit confused in terms of the error in my code above. I am passing the directory in the dictionary using ProgramDir


angular 4

Hi, will you add support for angular 4?

No, this library won't be updated for newer versions of Angular.


GHSA-ghmj-crg5-xw2j/GHSA-ghmj-crg5-xw2j.json is missing aliases CVE-2020-7608

https://github.com/github/advisory-database/blob/main/advisories/unreviewed/2022/02/GHSA-ghmj-crg5-xw2j/GHSA-ghmj-crg5-xw2j.json
lists https://nvd.nist.gov/vuln/detail/CVE-2020-7608
but doesn't have a CVE in aliases?
Also, "nvd_published_at": null should be the date: Published: March 16, 2020; 4:15:12 PM -0400

👋 Hi @kurtseifried, as mentioned in the description of GHSA-ghmj-crg5-xw2j, GHSA-ghmj-crg5-xw2j is a duplicate of GHSA-p9pc-299p-vxgp, and GHSA-p9pc-299p-vxgp does have CVE-2020-7608 attached as a CVE alias, as seen at https://github.com/github/advisory-database/blob/fb7446606d5b06bd1ba498f9436428bf1d4f605e/advisories/github-reviewed/2020/09/GHSA-p9pc-299p-vxgp/GHSA-p9pc-299p-vxgp.json.
GHSA-ghmj-crg5-xw2j doesn't have an entry for nvd_published_at because GHSA-ghmj-crg5-xw2j's advisory database entry didn't originate from an NVD import. GHSA-p9pc-299p-vxgp has an nvd_published_at entry of "2020-03-16T20:15:00Z" because that advisory originates from an NVD import.
Thank you for your interest in GHSA-ghmj-crg5-xw2j and have a great week!


Tesseract.Pix.Image.LoadFromFile : never finishing on published release ....

I have a very strange bug with function Tesseract.Pix.Image.LoadFromFile :
On debug : Perfect
On release : Perfect, but only on my PC, on other PC -> function never finish (no error ... just .... call never teminate ...)
On installation from pushing : function never finish (no error ... just .... call never teminate ...)
My code :
`            Bitmap bmp = LoadPicture(bmpFile.FullName);
        if (debugMode)
        {
            debugWindow.writeDebugLine($"Open Bitmap for OCR : {bmpFile.Name}");
        }

        //TesseractOCR.Pix.Image img = TesseractOCR.Pix.Image.LoadFromFile(bmpFile.FullName);
        Pix img = Pix.LoadFromFile(bmpFile.FullName);

        if (debugMode)
        {
            debugWindow.writeDebugLine($"OCR processing started on {bmpFile.Name}");
        }

`

On my console window, I have the first debug message, but never the 2nd one ... And application doesn't crash ... just ... waiting ...

Tesseract : 5.2.0
Target application : .net Framework 4.8
Output Type : Windows Application
And ... I tried to used another Tesseract nuget Package (Named TesseractOCR), and I have exactly the same result !
Have you any idea ?

OK, it is the same issue than ticket #636  ... Just copy folder x86 and x64 from Packages/tesseract to project root and add it to compilation in "always copy"


"switchSourceHeader" but instead open the other file in a split/vsplit

A usual development workflow is having the header and the source file side-by-side (vsplit). Consider jumping to a definition first, and that brings you to the implementation. Now you want to change the interface a little, which needs modifying a header file. It would be nice if there was a command (or an option to the command) which doesn't change the current window to the other buffer, but opens them in a split or vsplit.

You can set coc.preferences.jumpCommand in your coc-settings.json to change the jump behavior, default is edit, valid options: "edit", "split", "vsplit", "tabe", "drop", "tab drop".

That is true, but that changes the behaviour for every jump, not letting me assign different keybinds to this and that.
(via http://github.com/neoclide/coc.nvim/issues/318#issuecomment-451409604)

To change all location jump behavior, set "coc.preferences.jumpCommand": "drop"
For definition only, use :call CocAction('jumpDefinition', 'drop')

However, switchSourceHeader is a command, not an action. Is an action version available?

Try :CocUpdate to coc-clangd v0.14.0, now you can :CocCommand clangd.switchSourceHeader vsplit, by default will use edit if no open command provided.

Thank you very much!


Is Chai still the right testing framework/library?

Just asking
https://blog.logrocket.com/comparing-best-node-js-unit-testing-frameworks/
Related https://github.com/Innablr/revolver/issues/82

The testing framework we use is Jest. On top of it Chai provides a neat assertion language, which makes test-cases a lot more comprehendable and functional. Even though Chai is not TS-native (neither is Jest btw), it still has decent TS support. Alternatives for TS would pretty much only be Earl and assertive-ts, which are not nearly as functional as Chai. So unless there is a specific reason we want to get rid of Chai, I think the best choice is to keep it.


Cow: Watch fractalsystems.ae

Cow requests the watch of the watch_keyword fractalsystems\.ae. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

fractalsystems\.ae has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


Khilone (Mac)

Some outgoing transactions aren't showing in latest transactions and history.
Sometimes a window pops open out of nothing, and it contains no information besides the logo.

same issue here. First 3 transactions were fine, then the tbtc sent to Khilone were not recorded in history or displayed on the dashboard.  The balance was adjusted.
Windows10

 [Wallet-GUI] Blank pop-up

Resolved


IE9 and elements created after the DOM loads

Basically, I need to append a heading derived from an image alt attribute.
$('.child-container img').each(function(i, ele) {
var alt = this.alt;
$(this).closest('.container-parent').append('<h5>'+alt+'</h5>');
});

This loads fine on initialization. Once the more/lessLink is clicked I have the <h5> translating out of view using transform: -ms-translateY(-100%); transform: translateY(-100%). When the more/lessLink is clicked once again, the <h5> should appear back in view, like it does in every browser. Not IE9.
I've also appended a toggling class name to the parent div when the more/lessLink is clicked.
.container-parent {
min-height: 30px;
position: relative;
}

.container-parent h5 {
position: absolute;
left: 0;
top: 0;
width: 100%;
height: 30px;
transform: -ms-translateY(0);
transform: translateY(0)
}

.container-parent.is-open h5 {
transform: -ms-translateY(-100%);
transform: translateY(-100%)
}

I'm sorry, I am not supporting IE 9.


Image sequence support

Sometimes the media for a clip is a sequence of images.

We've only been using image sequences. I have been simply storing the root directory in "target_url" and then handle loading the sequence in my own logic.

I've seen someone else use a %d or * in place of frame number, like many VFX apps do. These all work fine for the moment in a closed workflow, but some of the adapters, media linkers and cross-company workflows will require that we formalize this more. We should formalize the syntax of the target_url to make it clear how this works.

fcp xml 7 urls for image sequences are simply a url to the first frame. Though...that doesn't really work all that well, because if I do premiere > xml > premiere, the result is that I only see that first frame. It seems to have forgotten that it was an image sequence. I guess thatll also make it a bit harder to reliably discern whether were dealing with a single image or an image sequence.
But on the topic of frame wildcard, our preference for otio would be in the form of "%04d".

Has this been discussed any further? I'm used to and like variations of the "%04d" format my self.
Some alternative ways of indicating sequences (just throwing them out there):
target_url='/path/to/sequence.1001.ext[1001-1050]'
target_url='/path/to/sequence.%04d.ext[1001-1050]'

The following would probably fit in the best to the current code:
target_url='/path/to/sequence.%04d.ext'
start_time=1001
duration=50

And perhaps add an attribute in the ExternalReference class that indicates an image sequence or not. In my work on the Hiero plugin I looked at the MediaSource and MediaFileInfo documentation which gives you an indicator if source is a video container or an image sequence. I would assume other applications supporting image sequences have similar logic so OTIO media_linkers, adapters and plugins could set the "is_image_sequence" flag to True or False accordingly.
In addition to this there's always the option to write functions/methods that analyze the media_reference and determine whether or not it's dealing with a sequence, but not sure if that should be a part of creating a timeline or not. Might slow things down a bit and demands robust I/O routines for all supported platforms.

Thought about this some more and threw together a quick suggestion on one way of doing it. It's based on known regex patterns for frame substitutions. So when asking if a media_reference is a sequence it checks for a known pattern in target_url.
It's still up to each user to actually convert the target_url into a valid path based on available_range for instance.
Please look at this gist and give it a try.
>>> import opentimelineio as otio
>>> media_ref = otio.schema.ExternalReference()
>>> media_ref.is_sequence
>>> True
>>> media_ref.target_url='/path/to/sequence.%04d.exr'
>>> media_ref.is_sequence
>>> True
>>> media_ref.target_url='/path/to/sequence.1001.exr'
>>> media_ref.is_sequence
>>> False
>>> media_ref.is_sequence = True
>>> True

There's a slight problem with using the available range to map to frame numbers, (which I've recently discovered to my cost as I came up with the same solution).
Basically we've got Arriraw files and these have embedded timecodes, (.exr can have the same thing), which is a problem as the available range should hold the timecode, which means I've got no where to store the frames.
I think we definitely need to come up with a proper solution for this as currently we're all rolling our own.

Here's a python module that might come in handy for summarizing sequences of filenames: https://github.com/rsgalloway/pyseq

Also, we're looking into OpenClip, which may be a more full featured approach to handling media: http://robmoggach.github.io/python-openclip/

Here's another python module that might help: https://github.com/sqlboy/fileseq

Thanks @meshula, that sounds also related to #68.

@jminor in the open clip case, would you expect that there would be  special "OpenClipMediaReference" as a schema?  or that there would be an openclip data blob in the metadata?

@jminor @ssteinbach I might be missing something, but personally I'd like to avoid having to deal with XML objects. Wouldn't it be possible to define some sort of simple media container where we can specify if it's a single or a sequence of files etc?
Also, we need to support files like R3D that potentially come in "sequences" as well.

For now we're just researching OpenClip and talking to the people at Autodesk to see how it could work together with OTIO. I agree that putting XML inside JSON would be awkward.

Hey!
I'm playing around with solving this with a new SequentialReference type which is a subclass of MediaReference. It's just a variation of ExternalReference but contains a frame_range field that stores frame numbers in an opentime.TimeRange.
This way we keep the original source Timecode in the available_range and whatever frame numbers the files have in the frame_range
I'm not that happy with my naming of the class, but other than that what do you think about this approach?

@ssteinbach  @jminor  Hello again!
I've put together a proof of concept plugin for this here.
It consists of a schemadef for an ImageReference which is based in ExternalReference and imagesequence_linker media linker. I've added an example file for inspiration. You'll need to dig up an EDL and some images to test it. I can see if I'm able to produce a small sample pack if needed.
I used the rv_session adapter as a test case for output to see how it might work in a real life situation. This quickly revealed that we should consider making the ImageReference type a first class citizen if you feel this is a good direction to go so it may be supported in other adapters. In the RV adapter for instance it needs to detect the ImageReference and ask for frames instead of the "normal" source_range. The map_source_range_to_frame_range method compensates for the potential difference between frame numbers and "TimeCode" and should be called in this case.
Please let me know if this doesn't make any sense at all. I've tried to illustrate this in the example file.
Let me know what you think.

FWIF, I know Baselight uses the OpenClip Schema as well

Yay! Thanks for the collaboration on this everyone!


ViewSlot firstChild null not being checked

i'm getting an exception when i run a todo sample.  it looks like ViewSlot is not checking if .firstChild is null before referencing its properties.
typescript repo containing sample
todo project within repo
running code illustrating exception
no check for firstChild null

if i edit the code like this, the sample works:
      removeAll: {
        value: function removeAll() {
          var _this = this;

          var children = this.children,
              ii = children.length,
              i;

          var rmPromises = [];

          children.forEach(function (child) {
            if (child.firstChild !== undefined && child.firstChild !== null && child.firstChild.nodeType === 8 && element !== undefined && element.nodeType === 1 && element.classList.contains("au-animate")) {
              var element = child.firstChild.nextElementSibling;
              rmPromises.push(_this.animator.leave(element).then(function () {
                child.removeNodes();
              }));
            } else {
              child.removeNodes();
            }
          });

Hey Mike would you mind sending in a PR for your fix? Also thanks for the detailed explanation and showcase of the error

i thought about that, but i'm worried i don't know what should happen when it is actually null or why its null in my case.  can you give me a little guidance? :)

like could it be because there's only one route?
or something specific to the view?  i don't know...

we had something similar before with other parts. It was my mistake to think that elements/siblings could be undefined, as I was expecting. Seems though most of the time they are null.
The way you did it, testing for both of them, is definitely the safest route.

ok - so just look for those places in ViewSlot and add some checks?  i'll give it a go :)

i can validate within the typescript world.  how would you suggest validating out in the real world?  just a couple of suggestions if you have em


Allow specifying workflow by path

Previously, workflow-dispatch only allows specifying the workflow by ID (as returned by the API) or by name (as specified in the YAML). Specifying by ID is problematic because the ID is auto-generated by Github, so we don't know what the ID is before we push, and the ID can differ per repository fork. Specifying by name (in the YAML) is also problematic because the until you've pushed this workflow to the main branch, Github doesn't read its name, and thus workflow-dispatch fails to find a workflow with that name.
This pull request allows specifying a workflow by path. This always works even when introducing a workflow for the first time in a branch.
Closes #18.

This is great, can you post a few examples of what the workflow path would look like?

It's in the docs. Example: .github/workflows/ci.yml

@benc-uk is there a reason we can get some of these PRs merged? :)

Fixed in v1.2 and master


Adding way to construct old segment upload endpoint

We want a migration path from the old segment endpoint to the new one. Adding the method back to use the old segment endpoint. Also added a new method to use the call the new endpoint.
Changed all references in open source to use the new endpoint as well.

@fx19880617

@Jackie-Jiang I think it may be nice to help users construct the request (in case other people wanted to migrate as well), thoughts? Maybe I can rename my new one

@jenniferdai I would rather rename the old one instead, because the whole code base uses the new one.

Codecov Report

Merging #3343 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #3343      +/-   ##
============================================
- Coverage     70.68%   70.65%   -0.04%
  Complexity        4        4
============================================
  Files           985      985
  Lines         45450    45451       +1
  Branches       6100     6100
============================================
- Hits          32128    32113      -15
- Misses        11210    11226      +16
  Partials       2112     2112

Impacted Files
Coverage Δ
Complexity Δ

...n/pinot/common/utils/FileUploadDownloadClient.java
73.04% <100%> (+0.19%)
0 <0> (ø)
:arrow_down:

...in/pinot/core/query/pruner/ValidSegmentPruner.java
57.14% <0%> (-28.58%)
0% <0%> (ø)

...egation/function/customobject/MinMaxRangePair.java
75.86% <0%> (-24.14%)
0% <0%> (ø)

...e/impl/dictionary/LongOnHeapMutableDictionary.java
88.88% <0%> (-6.67%)
0% <0%> (ø)

.../impl/dictionary/FloatOnHeapMutableDictionary.java
86.66% <0%> (-6.67%)
0% <0%> (ø)

...impl/dictionary/FloatOffHeapMutableDictionary.java
87.27% <0%> (-5.46%)
0% <0%> (ø)

...ore/startree/v2/builder/BaseSingleTreeBuilder.java
90.38% <0%> (-4.81%)
0% <0%> (ø)

.../controller/helix/core/SegmentDeletionManager.java
76.72% <0%> (-2.59%)
0% <0%> (ø)

...inot/core/operator/docidsets/AndBlockDocIdSet.java
55.55% <0%> (-2.09%)
0% <0%> (ø)

...core/startree/operator/StarTreeFilterOperator.java
95.15% <0%> (-1.82%)
0% <0%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d99814...80e9941. Read the comment docs.

@Jackie-Jiang makes sense, how about this most recent approach?

@jenniferdai We should keep the new one as default. We can bring back the old one with name like getDeprecatedUploadSegmentHttpURI(). @fx19880617 Any thoughts?

@jenniferdai We should keep the new one as default. We can bring back the old one with name like getDeprecatedUploadSegmentHttpURI(). @fx19880617 Any thoughts?

I think my major concern is that if people blindly upgrade both server and client. Then segment URI push will still fail since v2 api on controller is not backward compatible with v1 api.
I'm open to change my code to use the old api, however not sure if this will break other users.


add test for get_chrom_genes(), and remove def peek() from pubmedScore

Coverage increased (+0.3%) to 26.381% when pulling df1d5bbfbc716b840196b8a51f48a36e8daa03a1 on logust79:master into 52c40ce8146cddc8ee654367bb1218ffe6cbc07f on pontikos:master.


Add tun/tap support which is removed now

Readd tun/tap support to kernel which was removed in c2b60ab21080d15148948fc6536078251dcfa842
With you latest update in c2b60ab21080d15148948fc6536078251dcfa842 you've removed the tun/tap support entirely - which is very bad if someone use the docker container with openvpn.

Nice catch, thanks!


Adding additional option to manage several schemas

Hi @crossroad0201 !
Sorry to bother you again, I need another PR for this, this time I'm adding another option to select the schemas that flyway should manage. I'm not very proficient in Scala, so I'm not completely sure if I am split the schemas string correctly or if the class for schema has the proper type on it's constructor, I do know that the setSchemas should accept a String array. Let me know if I'm doing something wrong and I hope this can be merged soon. Thanks!

Mm... compile error...
I fix it. Please wait...

Fixed it, and released.
To apply arrays to variable arity method, had to expand them using _: * syntax.

Thanks!


Leaked global in api_client.js

When running hapi/lab tests on an application using notifications-node-client[1] the tests were reporting the following error:
The following leaks were detected:version
This error is flagging leaked globals.
debugging lead me to this line in client/api_client.js:
var restClient = require('axios').default,
   _ = require('underscore'),
     createGovukNotifyToken = require('../client/authentication.js'),
      notifyProductionAPI = 'https://api.notifications.service.gov.uk'
     version = require('../package.json').version;

i believe there is a comma missing on the penultimate line (adding the comma resolves the test run error for me). I have a workaround but wanted to flag my findings.
[1] https://github.com/NeXt-Warning-System/xws-contact-web

Just upgraded to 5.0.1 and can confirm this resolves the error reported by the hapi/lab test runner.
Thanks!


Image.trim() Converts Image Backgrounds To Black

Here is the code in question that yielded this:
with Image(blob=image_bytes) as img:
    img.save(filename="original")
    width_before, height_before = img.width, img.height
    img.trim()
    width_after, height_after = img.width, img.height
    if width_before == width_after and height_before == height_after:
        logging.warning("Image " + filename + " failed to trim.")
    img.save(filename="trimmed")
    # return img.make_blob() # this was for exports to S3 via boto3

I didn't do enough QA/testing, so I almost overwrote my entire S3 bucket with messed up backgrounds.
Config info:

<EMAIL_ADDRESS>(newer versions broke Wand)
Python 3.6.0 :: Anaconda custom (x86_64)
macOS Sierra Version 10.12.5 (16F73)

Could you try changing img.save(filename="original") to i.save(filename="original." + i.format)?  It maybe related to #349.

Preposterous thing: some of these images have RGBA color profiles, but are merely saved as .jpg.
I might have missed this in docs, but is there a flag to render alpha as white?

I might have missed this in docs, but is there a flag to render alpha as white?

Try setting img.background_color to white, e.g.:
with Color('white') as white:
    img.background_color = white
    img.save(filename='original.' + i.format)

This was my solution.
if img.format.lower() != file_format: # Fallback for three-channel image formats.
	img.background_color = Color('white')
	img.alpha_channel = 'remove'

I sacrifice the alpha channel, but it was the easiest way to go. Sorry for the confusion. Thanks for the help!


Empty state following/followers list not displayed properly on ios

Steps to Reproduce

Go to profile with 0 following or followers
View following/follower list
Text is missing but Go Back button works

Attachments

What platform(s) does this occur on?
iOS
Device Info
No response
What version of the app are you using?
1.93
Additional Information
No response

Nevermind, i think #6236 fixes this


Fix Task Lists Element dragability

We discovered that in the PR #35 creating SVG elements requires createElementNS instead of createElement. This PR replaces createElement with createElementNS and returns the draggable behavior.
Fixes https://github.com/github/primer/issues/1787

:wave: Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

:art: If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
:fast_forward: If this is a PR that includes changes to an interaction, please include a video recording in the description.
:warning: If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.


Fails with CUDA7.0

The current release is TF 1.7 which supports CUDA7.0 as per the GitHub.
When I build tensorflow_cc, however, it fails (says cuda_f16.h missing, which I think is in later versions of CUDA). I have not tried building TF directly.
Any idea why? -- I checked some forums and apparently, TF support for CUDA-7.0 is not guaranteed.
I am trying to install TF 0.8.0 following your set-up. Did you try it?

@FloopCZ Thanks for the reply. I tried few of the past versions going as far back as 0.8.0 with your set-up.
I think it was 1.2.0, where the set-up failed because TF install procedure changed. Unfortunately, in my case, nothing worked as my CUDA version is 7.0, which is not well supported.
I think your set-up is quite robust, and at least past few versions of TF work, but many old versions have a lot of problems (incompatibilities like Bazel and others).

You should really consider an update (or Docker). :-)


Specify desired app name for symlink: feature request

Before Cask, I often renamed applications, for ease of use and aesthetic appeal.
'Google Chrome.app' -> 'Chrome.app'
'Alfred 2.app' -> 'Alfred.app'
'1Password 6.app' -> '1Password.app'
A 'nice to have' feature would be to specify the desired name of the application as an argument.

You can always edit the Cask formula to your needs - local taps/files will always be preferred over Caskroom ones if explicitly installed. All of the apps you mentioned have automatic updates as well, so I don't know if you're losing anything by not using caskroom for those, anyway.

See https://github.com/caskroom/homebrew-cask/issues/5101.
This garnered no interest whatsoever. We might entertain a PR, but otherwise, there’s simply no interest.

Thank you @adidalal.


[Feature Request] Add a config option to only ride (tamable mobs) if they are tamed.

Sorry for yet another feature request, though I just have many ideas and wanted to share.
Feature Description:
There could be a configurable option that is added per tamable mob which could be called "ridable-only-if-tamed" to allow riding mobs only if they are tamed. This could be useful (for example), if you wanted to restrict players from riding wolves/moving them somewhere if they haven't tamed them yet. Not sure if it's "needed" though. It's up to you.

https://github.com/pl3xgaming/Purpur/blob/ver/1.16.2/patches/server/0119-Ridables.patch#L2293-L2298

I  think what they are asking for is actually a bit different. I think what they want is for this line to be changed from
if (tameable.isTamed() && !tameable.isOwner(entityhuman)) {
to
if (!tameable.isTamed() || !tameable.isOwner(entityhuman)) {
I tested myself, and right now I can ride a wild wolf, or my own wolf, but I cannot ride a wolf tamed by another player. The requested behavior is that you can only ride the wolf if you have tamed it yourself. This could maybe be a config option for all tamable mobs, or a toggle for each? There are a couple different ways this could be implemented, but I don't think it's a bad idea.

Correct, yes that's what I meant jmanpenilla.


[Feature] supported java sdk

Most web applications are developed using Java, and may we need Java SDK

I am currently working on a Java version of langchain. It is currently only MVP: only PDF loader, splitting, pinecone store/retrieval, openai embeddings, openai chat api, prompt templates, conversation history, etc... Will make repo public tomorrow and continue working on it in the coming days.

@laglangyue @quxiucheng https://github.com/ai-for-java/ai4j
Please feel free to use and/or contribute and suggest improvements and request features

In Java, you can use LangChain: https://github.com/HamaWhiteGG/langchain-java
@laglangyue


Support .otf by default

Any reason why open-type is not supported by default? Would you be open to a PR adding this?

Just because it's not a very common format for web fonts, and woff is generally the recommend standard. Happy to accept a PR adding support though

@seaneking could you tag a new release and push it to npm?


chore: Add example calls for all the methods the SDK will implement

What does this PR do?
Related ticket
Fixes #255 and #172
Type of change

[x] Chore
[ ] Bug fix
[ ] New feature
[ ] Documentation update

Check list

[x] Unit tests for any smart contract change
[ ] Contracts and functions are documented

Codecov Report

Merging #268 (a159aac) into dev (1be2180) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #268   +/-   ##
=======================================
  Coverage   93.40%   93.40%
=======================================
  Files          13       13
  Lines         197      197
  Branches       46       46
=======================================
  Hits          184      184
  Misses          8        8
  Partials        5        5

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Unrecoverable error when searching some non-existent subreddits

When searching for some subreddits that doesn't exist, the app throws an error. Additionally, the non-existent subreddit gets added to the "recent visits" list, and there is no option to remove it. Clicking on this item causes the app to fail again, resulting in a broken experience.
Steps to Reproduce:
Open the search modal.
Search for a non-existent subreddit (e.g., "espania", "espaniol").
Observe that the app throws an error, having to refresh the app to return to a working state.
Expected Behavior:
The app should handle non-existent subreddit searches gracefully, having a way to return to a working state.
Non-existent subreddits searches may not be added to the "recent visits" list.
Actual Behavior:
The app thows an error when searching for a non-existent subreddit.
The non-existent subreddit is added to "recent visits".
Clicking on it results in the same error, preventing proper app usage.
Screenshots or Logs:

@Rafacv23 Nice work BTW!

Fixed, now the user will have a not found page and the subreddit searched it's not added to the recently added section.


Support SARIF format

Github has the capabilitiy to integrate third-party static analysis tools. The official documentation can be found here which requires static analysis tools to produce [SARIF] format.
This issue is already picked up in

Android Lint - See https://issuetracker.google.com/issues/167593732
Detekt - https://github.com/detekt/detekt/issues/3045
Checkstyle - https://github.com/checkstyle/checkstyle/issues/8905 This is working in progress for me.

I would like to seek your opinion on supporting SARIF format as first-class for ktlint. (We already have json format https://github.com/pinterest/ktlint/tree/master/ktlint-reporter-json).
If approved, I would be happy to contribute as well.

So it is basically adding another reporter that will produce report  in SARIF format?

That's correct.

Because SARIF is officially supported by Github code action, we could show the violations inline (https://github.com/chao2zhang/detekt/pull/9/files)

Then it makes sense to add such reporter. Feel free to contribute :+1:

@chao2zhang do you plan to further improve SARIF format support or it is fine as it is?

We can close this issue since we have basic support. Further improvements can be done in separate issues:

[ ]  SarifSchema210.runs[0].tool.driver.rules is empty for now. Ideally, this should be a list of rules that were active in the current run. I will address this in a follow-up PR since this requires refactoring.
[ ]  I have not yet added other information like autoCorrected or autoCorrectible in the output.
[ ]  Potentially we can also add github workflow setup in the documentation. There are other community projects that does this so this is optional to me.

@chao2zhang have you tested ktlint reports in GitHub? It looks like the calculation of URI paths is incorrect
Any examples, where it works?

Got it working somehow. But definitely need to customise plugins properly for it. Github is not able to work with absolute paths and that is a big problem for us.

@akuleshov7 send PR?

@akuleshov7 send PR?

Roma, we are supporting it in maven and gradle plugins for our diktat rule-set. Here is some small test:
https://github.com/analysis-dev/diktat/pull/1205/files
see: diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter1/FileNaming.kt
The idea is the following: the user adds a special flag githubActions to the plugin and get everything out of the box.
So I guess this logic should be copied to your plugins as well.
As soon as I will finish with diktat - I will move the logic to your plugins.


Creating buy order with a lightning address

Reference https://mostro.network/protocol/new_buy_order_ln_address.html

@grunch i would like to work on this project seems exciting! can you assign me this issue?

i think the link is down

i think the link is down

Sorry, I just updated the link, try it again 😅


Create apt sofacy.txt

Ok, I'll figure that out :-). I made some tests:
Folderpath search for --> C:\Windows\System32\conhost.exe
where FolderPath matches regex @'conhos.' -->match
where FolderPath matches regex @'conhos.' -->match
where FolderPath matches regex @'.*Windows.*conhost.exe' -->match
where FolderPath matches regex @'Windows.*conhost.exe' -->match
where FolderPath matches regex @'Wind.System32.' -->match
where FolderPath matches regex @'Wind.*System32' -->match

So as you suggested: I removed the .* at the end
I replaced . with . in rundll32.exe
I decided to just remove the \ from %APPDATA%


Digital Journeys Application Load Testing

All issues and tasks related to an on-going system load testing of the Digital Journeys Platform

not relevant


In CSS files "../" is replaced with "" (empty string)

Seems that this issue was introduced sometimes between v3.1.2 and v3.2.1, but most likely v3.2.1 exactly, this commit: https://github.com/ember-cli/ember-cli-preprocess-registry/commit/59aeb88ef6b9f4580018bf2d97440fe063753125
I will work on polishing this bug/issue report, but that's all I've got for now (going to sleep, 1:23 am here).

It's caused by a new version of clean-css (4.x.x) that ships with the new broccoli-clean-css (2.x.x)  from a7d2eeba3edf06d3639bf54833a3398c6b91cd84
Quick work around: update ember-cli-build.js accordingly
var app = new EmberApp(defaults,{
  minifyCSS: {
    enabled: true,
    options: {
      rebase: false
    }
  }
});

This will probably minify your test and development builds as well.
I'll create a pull request with an actual fix later today.

this was fixed by reverting to the old clean-css (https://github.com/ember-cli/ember-cli-preprocess-registry/pull/55). sorry about that 😞
will release it in the next few minutes.

released as v3.2.2