Add roles to credentials

:+1:  for great use of promises, and seamless integrating this new feature!
Please see my comments, which are mostly style-related.
Also, linting fails pretty hard ATM...

Also, I get quite a few failing tests when I attempt to run the tests on this branch. All tests still pass on develop though, so I'm pretty sure it has something to do with changes to auth or cookies in this branch.

Turns out my tests were failing because I had some bad data in my Redis datastore. This fixed it:
/opt/redis/bin/redis-cli
FLUSHALL

Ross is not getting any linting errors on his computer, so there's some config difference there. We will need to investigate further.

At long last! Sorry for the extended CR period.


element-replacer-onload replaces element by noop node?

https://github.com/uBlock-user/uBO-Scriptlets/blob/eb4b020cd665ec73f7de34eddd41e71a08054999/scriptlets.txt#L395
	let div = document.createElement('div');
	let replace = function() {
		let elements = document.querySelectorAll(selector);
		for ( let element of elements ) {
		      element.replaceWith(noop);
		}
};

This may work because replaceWith accepts strings.

That was dumb mistake not to change noop to div at that line when I made the change in the first place. Thanks for noticing

https://old.reddit.com/r/uBlockOrigin/comments/b86bs6/help_needed_with_scriptlet_for_replacing_html/


[Select] Allow range selection using shift key

[x] I have followed (at least) the PR section of the contributing guide.

I've added a feature to the Select component (multiple-values variant) which allows the user to use the shift key in order to select multiple options.

Is it related to #19654?

@oliviertassinari Haven't seen this issue before but it's the same issue I tried to solve here.

@eps1lon Will work on adding tests.
As for the behavior- shift is the common key for selecting multiple items (as a range) while ctrl key used for multiple select but not as a range.
The ctrl behavior is not relevant for MuiSelect as the menu is not closed once one option selected. It would have been useful if the default behavior is closing the menu once one option selected but when using ctrl, it would skip the closing of the menu.

As for the behavior- shift is the common key for selecting multiple items (as a range) while ctrl key used for multiple select but not as a range.

Thanks. It wasn't clear to me that you implemented range selection.

@eps1lon Is that something you guys want to push or wait with it?

Do we really need to implement the range feature, like the one we have with the tree view?

Native select has it built-in. The purpose of a custom Select is to have a customizable native select.  I haven't seen a custom Select that's worth giving up native UX.

It seems that such behavior will be frustrating considering how easily the popup can close. What about we aim for simplicity?

Seems like we have an issue with the close trigger.

consistency with Autocomplete

What makes the Autocomplete the source of truth for perfect UI here? This argument is not constructive. Why not implement this behavior in Select and Autocomplete instead?

We restore the current multiple "keep popup open when value selected" behavior when the ctrl or meta keys are pressed.

This PR is about range-selection with SHIFT not arbitrary multi select with CTRL.

Native select has it built-in.

I was wondering about the requirement for it as, so far, the custom multi-selects or combo boxes I could benchmark don't have it. I don't know if it's because most people don't ask for it, or if it's because the UX isn't great or because it's too costly to implement.
Do we have an opportunity to abstract the ctrl, meta selection into a hook, and share it with the Autocomplete? It's the 4th time I encounter this potential need: 1st time at onepixel for an image gallery, 2nd for the tree view, 3rd time for the select, 4th time for the autocomplete.

if it's because the UX isn't great or because it's too costly/hard to implement.

Or because users can't rely on the same UX between pages because every component looks (basically) the same but works different. Falling back to multi-click select after shift click is most likely not measured because most devs are ignorant about the existence of shift-select in UIs.

the custom multi-selects or combo boxes I could benchmark don't have it.

Benchmarking is a misleading technique to collect requirements. This is one of the many reasons.

because users can't rely on the same UX between pages

Very possible, I find this argument convincing.
My assumption is that the request vs cost ratio is low, making this feature a high opportunity cost for the design system teams in the industry.

Benchmarking is a misleading technique to collect requirements

I was using the following reasoning: by the absurd. We are in a mature industry with a lot of legacies. Let's assume the range feature is something important, then we should see it implemented in at least a couple of popular web interfaces, users being used to it. If it's not the case, then it means that the UX/UI/developer teams out there have better problems to solve. Also, assuming our aim is to replace these teams, we should have close priorities for them. Hence, it's probably not a feature we should value a lot.

@dvh91 We appreciate the contribution, however, it has been stale for a while now. If you want to push forward with it, I would recommend moving the logic to the combo box (Autocomplete). The current UX of our Select component is not as great as it could be.  We pay the cost of React's component, we have often 10 layers when having fewer would be faster to render. We need to at least stop the MenuItem > ListItem inheritance.
Locking the scroll when the popup opens is a strong move. It works well on mobile but not that much on desktop.
The UX on mobile could be improved by displaying a bottom sheet. It would make customizations a bit harder but probably work better
The UX of multi-selection with sub-header is broken

Hi guys,
Hope I find you well!
Can I ask if this problem was ever solved or will be looked at again?
My original request was #5302.
I would have thought the shift/range select option would be useful - it would certainly reduce the risk of RSI that people like me are currently facing from constant mouse clicking to select things.
Many thanks!
Henry

would the work on this feature ever finished? very important behavior. Or can you give me some tips on how can i customize autocomplete to implemet it myself?

@tihuan Right, there are two different dimensions here:

Is there a key to keep the popup open after one option is selected?

The Autocomplete uses event.metaKey (⌘ on macOS and ⊞ on Windows) or event.ctrlKey (control on macOS and ctrl on Windows). This was implemented in #22696
The Select behave differently, it doesn't close the popup on multi-selection mode, this is likely a mistake. I have added item 5. in https://github.com/mui-org/material-ui/issues/18136#issuecomment-549059199.

Is there a key to select a range? This is won't fix.

Got it! Really appreciate the clarification 😀 Have a wonderful day!

@oliviertassinari I see that you said

Is there a key to select a range of options? This is won't fix.

Does that mean that this kind of behavior will never be built in?
As it has been a few years is this still the current position Mui has?


MVP gene set DB selection

Description of new feature
What should the new feature do?  For visual features, include an image/mockup of the expected output.
We need to select a gene set DB for the algorithm so that users don't have to choose one.

For the MVP, choose a good default for user, human only
The user can't change which DB is used.  It's fixed
Current one: Human_GOBP_AllPathways_no_GO_iea_June_01_2022_symbol.gmt
Human, gene symbols, pathway subset
Include name of DB in service JSON output

Motivation for new feature
Describe your use case for this new feature.
Required for the algorithm.  Users don't want to or know how to choose one.

@veroniquevoisin & @risserlin, would you please give us a suggestion of the best human DB to use as a default?

Is it static or can it be updated to the latest gmt file on the fly?

I think Mike made it static for now, right @mikekucera?

I always use the latest release for each new analysis: http://download.baderlab.org/EM_Genesets/current_release/Human/symbol/Human_GOBP_AllPathways_no_GO_iea_August_03_2022_symbol.gmt
Therefore it would make more sense in my opinion that it is not static, however I don't know the technical efforts required for it.

It would be a major feature to make the DB dynamic.
One approach would be to somehow notify all the services when there's a new DB, and they would all have to download it. Another approach would be to make it part of the build process to bundle a new DB with the services, then create and push new versions of the services.
We would also need UI for allowing the user to select a DB, or at least show which DB was used.

Another approach would be to make it part of the build process to bundle a new DB with the services, then create and push new versions of the services.

This seems like the simplest solution.  If the services are updated in lockstep frequently enough, then they'll be new enough for users without them having to make selections.
Eventually, this could be automated with GitHub Actions with whatever release cadence we prefer.
The build approach is preferable when considering citations and reproducibility.  Build versions can be cited by version and DOI.  Dynamic, automatically-updated-on-the-fly services can not.

We would also need UI for allowing the user to select a DB, or at least show which DB was used.

This could fit well into both the front query page and the export.

I think this is done for MVP
Let's keep this open until we create a new issue for longterm discussion of updating and maintenance for the gene set DB.


PTFE-693: api authentication

Codecov Report

Merging #322 (ac2d835) into main (87c4ac4) will decrease coverage by 3.55%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
- Coverage   91.77%   88.23%   -3.55%
==========================================
  Files          14       14
  Lines         304      323      +19
==========================================
+ Hits          279      285       +6
- Misses         25       38      +13

Flag
Coverage Δ

api
17.02% <54.54%> (+1.89%)
:arrow_up:

unit
79.56% <9.09%> (-5.64%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

runner_manager/main.py
60.00% <50.00%> (-16.48%)
:arrow_down:

runner_manager/models/settings.py
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Status of the library

Hi there, thanks first of all for such a framework. I see that the last changes were done for a while ago, so is this still production usable or not? 😄

Hi, thank you for your kind words.
The initial idea was to save time by adding some magic so that a developer can save few lines of code. It works just perfect for a short distance but can be harmful in a long running project.
Technically it should work fine, even though I didn't touch it for a while, neither I used it for a couple of years.
However, over time I've got few reports when the library didn't shine: people used it in a way that I didn't expect them to use it. That said, I suggest you weighing all pros and cons and make the decision based on your use case rather on usability if a particular library.

@AlexDenisov thanks for the response, it's really helpful 👍


Slow down in inspector with 'ShowIf'

I really love Naughty Attributes!
Lately, I started a new project, I noticed that when adding one  'ShowIf' "[ShowIf("IsAnimated")]"
The whole script is getting slower, like typing, characters/numbers in any string field takes longer, like more time to process (slight delay but noticeable and annoying) compare to when removing the 'ShowIf' it works much smoother.
Is that expected behavior with 'ShowIf'?
Note that the script is kinda big with many parameters.
I am using Unity 2019.3.11

@ColorTwist check out issue #133 .. seems to be the same problem. Easy quick fix workaround would be to remove the ShowIf usage , use Header instead or labels. Check out my answer in the other thread which explains roughly how I fixed it for myself

oh, i see, yeah the same issue.
Currently, I am removing Naughty Attributes as for me, the inspector becomes too slow and annoying.
I use the  'ShowIf' pretty much, one of my favorites.

Same as #133
I know about this issue. The problem is that I am not doing any caching at all. I need to go through the attributes one by one, check what is slow and fix it. I will try to fix it in the next release.

Thanks for the asset @dbrizov !
I'm on v2, ShowIf+Box, and experiencing the same issue on a gaming rig!
Using Unity 2019.4.2f1 (LTS)
I would gladly pay in the Asset Store to support you in the development.
At this point some caching is really mandatory I guess (I believe ODIN is already doing that).


Nginx dependency removal

I want to use this cookbook in conjunction with chef_nginx cookbook, which is a fork of nginx cookbook. However, since certbot declares a dependency on nginx, it confuses some resources provided by chef_nginx.
Is there any plan to remove nginx from its dependencies? It seems there is no problem just removing the line in metadata.rb, like in qnighy/chef-certbot@b8d6271cb58cf1ff3f463cbe2ac55ed1166bcafa. Currently I'm using this patched version.

I guess this one is probably no longer necessary since chef_nginx has been deprecated and the nginx cookbook is alive and well once again.


Remove PropTypes from Modal.js

This PR converts the Prop Types in Modal to Flow Types, and fills out the callback types a bit more.
Context Types are left in for now.
Test Plan:
flow check passes.
Release Notes:
[GENERAL] [ENHANCEMENT] [Libraries/Modal/Modal.js] - Converted Prop Types to Flow Types

This caught a few invalid callsites internally that will have to get fixed for this to land.


Configuration missing in HOOBS

I had been using this when running Homebridge from my iMac. However, I recently purchased a Raspberry Pi 4B and installed HOOBS on it. When I installed this plug-in, the configuration options to add devices seem to be missing. Is there something I need to do to get it to work, or am I going to have to type it in manually in the advanced section? To clarify some things. I only entered the MAC addresses, since IP addresses can sometimes change. It still worked perfectly in the original setup.

I copy/pasted it from my Homebridge setup on my iMac into the HOOBS Advanced setup, and while it added all of the presence sensors, none of them triggered.

I finally figured out what was happening. I wasn't able to get the configuration to appear correctly in the HOOBS desktop app, but I was able to get my devices to connect. I was running HOOBS on a brand new Raspberry Pi 4B. Somehow net-tools were not installed, so the arp command was not present on my device. I noticed it while trying to use one of the other apps called People Pro, and the missing command came up in the log. As soon as I installed net-tools, this plugin started working.

I have the same issue on my raspberry pi so you are saying you got the options to show up in the configuration in visual mode after installing net-tools? How did you install net-tools?


Merging change from AddStorageSync branch to master.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-ruby

Automation for azure-libraries-for-java

Automation for azure-sdk-for-node

    AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.
File: specification/storagesync/resource-manager/readme.md

:warning:8 new Warnings.(8 total)

Code
Id
Source
Message

TrackedResourceListByImmediateParent
R3010
Link
The child tracked resource, 'syncGroups' with immediate parent 'StorageSyncService', must have a list by immediate parent operation.

TrackedResourceListByImmediateParent
R3010
Link
The child tracked resource, 'cloudEndpoints' with immediate parent 'SyncGroup', must have a list by immediate parent operation.

TrackedResourceListByImmediateParent
R3010
Link
The child tracked resource, 'serverEndpoints' with immediate parent 'SyncGroup', must have a list by immediate parent operation.

TrackedResourceListByImmediateParent
R3010
Link
The child tracked resource, 'registeredServers' with immediate parent 'StorageSyncService', must have a list by immediate parent operation.

TrackedResourceListByImmediateParent
R3010
Link
The child tracked resource, 'workflows' with immediate parent 'StorageSyncService', must have a list by immediate parent operation.

EnumInsteadOfBoolean
R3018
Link
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: istransitioning

EnumInsteadOfBoolean
R3018
Link
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isdir

EnumInsteadOfBoolean
R3018
Link
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: backupEnabled

:x:0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback
Thanks for your co-operation.

    AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.
File: specification/storagesync/resource-manager/readme.md

:warning:7 new Warnings.(7 total)

Code
Id
Source
Message

PostOperationIdContainsUrlVerb
R2066
Link
OperationId should contain the verb: 'prebackup' in:'CloudEndpointPreBackup_Post'. Consider updating the operationId

PostOperationIdContainsUrlVerb
R2066
Link
OperationId should contain the verb: 'postbackup' in:'CloudEndpointPostBackup_Post'. Consider updating the operationId

PostOperationIdContainsUrlVerb
R2066
Link
OperationId should contain the verb: 'prerestore' in:'CloudEndpointPreRestore_Post'. Consider updating the operationId

PostOperationIdContainsUrlVerb
R2066
Link
OperationId should contain the verb: 'restoreheartbeat' in:'CloudEndpointRestoreHeatbeat_Post'. Consider updating the operationId

PostOperationIdContainsUrlVerb
R2066
Link
OperationId should contain the verb: 'postrestore' in:'CloudEndpointPostRestore_Post'. Consider updating the operationId

PostOperationIdContainsUrlVerb
R2066
Link
OperationId should contain the verb: 'recallaction' in:'ServerEndpointRecall_Post'. Consider updating the operationId

PostOperationIdContainsUrlVerb
R2066
Link
OperationId should contain the verb: 'abort' in:'AbortWorkflows_Post'. Consider updating the operationId

:x:0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback
Thanks for your co-operation.

Yes, this is the previous version, just merging to master
Get Outlook for iOShttps://aka.ms/o0ukef

From: annatisch<EMAIL_ADDRESS>Sent: Thursday, June 7, 2018 7:22:16 PM
To: Azure/azure-rest-api-specs
Cc: Ankush Bindlish (AZURE); Mention
Subject: Re: [Azure/azure-rest-api-specs] Merging change from AddStorageSync branch to master. (#3196)
Thanks @ankushbindlish2https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fankushbindlish2&data=02|01|ankushb%40microsoft.com|5ee73a97b8384585663708d5cce6a7b6|72f988bf86f141af91ab2d7cd011db47|1|0|636640213383963994&sdata=g6jTvRNAPtp5z76EQ2usGEoZI1%2BIMmN1%2FHlJVa3iY50%3D&reserved=0! Do you know whether the commits here been review previously? Including ARM signoff?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F3196%23issuecomment-395625276&data=02|01|ankushb%40microsoft.com|5ee73a97b8384585663708d5cce6a7b6|72f988bf86f141af91ab2d7cd011db47|1|0|636640213383973998&sdata=ydYzRPgjFgZpV37WvDf6eHTBQiW6fXnuDQ5P8Njwo8U%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAhR6h1zWU9Hib6Y7ZM3_yY78RSDgg064ks5t6d_YgaJpZM4UfRYz&data=02|01|ankushb%40microsoft.com|5ee73a97b8384585663708d5cce6a7b6|72f988bf86f141af91ab2d7cd011db47|1|0|636640213383984015&sdata=0zBgk%2FcA33gqvDiT1YiQId%2BLQ11BK4s1vH38bf%2BmMlM%3D&reserved=0.

Thanks @ankushbindlish2 - could you please include links to any previous PR reviews? (or you could foward me emails if review happened offline).
Additionally could you take a look at this syntax error:
/home/travis/build/Azure/azure-rest-api-specs/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2017-03-01/apimapis.json has references that cannot be resolved. They are as follows:
'Error resolving $ref pointer "/home/travis/build/Azure/azure-rest-api-specs/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2017-03-01/apimapis.json#/definitions/Resource". \nToken "Resource" does not exist.'

@annatisch  This error is not introduced by our resource provider.
https://github.com/Azure/azure-rest-api-specs-pr/pull/109

Thanks @ankushbindlish2 - did you rebase against master?

for simplicity, I have created another PR just with the changes we need  : https://github.com/Azure/azure-rest-api-specs/pull/3211 after consulting with Anu

Closing this in favor of this:
https://github.com/Azure/azure-rest-api-specs/pull/3211


Add doc site

Summary of Changes
Include a summary of changes then remove this line
Tests
What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes make test

Codecov Report

Merging #243 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   76.22%   75.97%   -0.26%
==========================================
  Files          95       95
  Lines        3954     3954
  Branches      363      345      -18
==========================================
- Hits         3014     3004      -10
- Misses        844      847       +3
- Partials       96      103       +7

Impacted Files
Coverage Δ

databuilder/loader/file_system_neo4j_csv_loader.py
84.33% <0.00%> (-4.82%)
:arrow_down:

...ilder/transformer/regex_str_replace_transformer.py
91.66% <0.00%> (-4.17%)
:arrow_down:

...abuilder/extractor/snowflake_metadata_extractor.py
93.44% <0.00%> (-1.64%)
:arrow_down:

...tabuilder/extractor/postgres_metadata_extractor.py
93.54% <0.00%> (-1.62%)
:arrow_down:

databuilder/publisher/neo4j_csv_publisher.py
84.15% <0.00%> (-1.00%)
:arrow_down:

databuilder/task/neo4j_staleness_removal_task.py
83.62% <0.00%> (-0.87%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975a59a...2c13e25. Read the comment docs.


Added Code Exchange Reqs

@zoykhan please review this PR - its has the required files for this to be submitted to Code Exchange.
Thanks!

Thanks @zoykhan please merge changes if you are ok with the new files. Thank you.


cargo install sqlx-cli fails when compiling sqlx-cli

Howdy all! Noticed my CI starting failing with 35 errors some time this afternoon when installing sqlx-cli. The exact errors all vary, but they all make reference to the the derive macro Clap. Comparing my most recent successful logs, it looks like the CLI is now pulling in clap_derive v3.0.0-beta.4 when it was using v3.0.0-beta.2.
I was able to reproduce this on my local machine after uninstalling and attempting to reinstall.

@sand-head how were you able to get around this?

For anyone else that might be experiencing the same problem,
I resolved the issue on my end using the locked one e.g.
rather than
cargo install sqlx-cli

I used:
cargo install sqlx-cli --locked

I had just started to forget about this horrible cargo behavior: https://github.com/rust-lang/cargo/issues/7169, but then I just wasted the better part of an hour over here scratching my head. Kinda funny, but I'm also a bit irritated right now too.
Anyway, I wonder if this will become an issue for the developers during an update soon, or not.

Also running into this issue. Hoping this gets resolved soon

Will look at this today, we apparently need to fix the version of clap-derive as well as long as we're on the beta and subject to breaking changes.

Please, release this version of sqlx-cli


LPAL-1074 Allow ON keyword in JSON body

Purpose
Allow the ON keyword in JSON body requests
Fixes LPAL-1074
Approach
Add an exception for requests matching the request .[oO][nN].=.*$
Learning
https://support.console.aws.amazon.com/support/home#/case/?displayId=11374935181
Checklist

[X] I have performed a self-review of my own code
[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
[ ] I have added tests to prove my work
[ ] I have added mandatory tags to terraformed resources, where possible
[ ] If I have a new OPG component dependency, I have updated the metadata.json with the repo location.
[ ] If I added a package.json or composer.json, I also made sure this is included in the script in .github/workflows/dependabot-update.yml
[ ] The product team have tested these changes

Note that these rules cover standard multipart form encoded POST requests, rather than JSON requests.

Is there any way we can test this before it goes to live? I wonder if we should do the ticket to enable WAF in dev first?

This isn't possible until the AWS provider version is updated to 4.29.0. This is not yet released.
https://github.com/hashicorp/terraform-provider-aws/blob/v4.29.0/CHANGELOG.md


ETCD-202: bump etcd v3.5.0

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

/retest

/retest

Quorum guard failures fixed by
https://github.com/openshift/cluster-etcd-operator/pull/636

/retest

/retest

/retest

unit tests should pass with https://github.com/openshift/release/pull/20773. they pass locally so the issue is with CI config.

/retest
PR was merged.


VSColorOutput for Visual Studio 2015 no longer available?

Hi,
Awesome extension, great work!
In https://www.visualstudiogallery.msdn.microsoft.com/f4d9c2b5-d6d7-4543-a7a5-2d7ebabc2496 I can only find that it supports 'Visual Studio 2017".
Is there any way to get the older version that worked on Visual Studio 2015?  I just got a new laptop and I'm still working with some older VS 2015 projects that are maintained by some other teams.
Thanks,
Emmanuel

https://github.com/mike-ward/VSColorOutput/releases/tag/v2.5-Release


Connection saturation with 1.23.1 version using unix socket

Bug Description
Using a configuration like this in a k8s deployment
- name: cloud-sql-proxy
          image: gcr.io/cloudsql-docker/gce-proxy:latest
          command: [ "/cloud_sql_proxy",  "-dir", "/cloudsql", "--quiet", "-instances", "my-project-id:europe-west1:my-instance-id=unix:/cloudsql/socket", "-credential_file", "/tmp/account.json" ]

lead to a saturation of available postgres connection.
I observed this in a simple but navigated django web project (with or without using application connection pooling).
Switching to TCP solves the problem.

This is a detail of the number of active connections after and before the switch from unix socket to tcp.
There was no leak with the previous proxy version.

Thanks for the report @faxioman.
So to summarize:

Connect a web app to a Cloud SQL database using a Unix socket
Send traffic to that web app for some period of time
Observe connection leak
Switch to TCP listener and the leak goes away.

How long do you find it takes for this leak to manifest? Is this hours, days, longer?

I see that switching to TCP mitigate the leak but in order to completely solve the leak I need to use 1.23.0 version.
I can see the leak in about 2 or 3 minute.

OK. Just to help me reproduce this, what are you using the manage SQL connections?
Also, as a side note, we recommend running the latest proxy version. :-)

Ok but the problem was because of the use of the latest proxy version ;)
In my k8s deployment I was using gcr.io/cloudsql-docker/gce-proxy:latest instead of gcr.io/cloudsql-docker/gce-proxy:1.23.0 (shame on me :D).
My web project is Django 2.1.2 powered. I'm using the default behaviour of opening/closing a connection for every request. With 1.23.1 version, using a connection pooling (CON_MAX_AGE setting) leads to the same connection leak.

Ok but the problem was because of the use of the latest proxy version ;)

Ha. OK. I see. I misread. So in other words, it seems v1.23.1 might have introduced this issue?
Let me spin up a Django app and reproduce this problem. I'll report back here with my results.

Here's what I did:

Deployed three replicas to my Kubernetes cluster of a small Go app that responds to HTTP requests with the current time from the database, connected to the Cloud SQL proxy (v1.23.1) over a Unix socket, along with a load balancer
Sent a steady load to my app using hey with this command: hey -n 1000000 -c 10 -q 1 http://$MY_LOAD_BALANCER_IP (that's 1,000,000 requests, sent by 10 works, each rate limited at 1 qps).
Watched the number of connections in Cloud Monitoring to my database (graph is below)

From the graph, it's clear that the number of connections stays constant.
So, I suspect you're running into a connection management problem in your application code. I would double check that you're properly releasing connections after a request. I'm going to close this issue for now.
If you're still convinced that this is an issue in the proxy, please re-open this and provide a minimal reproduction (either pushing an app to GitHub, or pasting code and K8s config here). Hope this information helps.

thanks @enocom. I think that is an issue in the proxy because the previous version is working fine. Anyway, I'll check again the 1.23.1 version in few days. Bye!

@faxioman I'll re-open this in the meantime. If you do see the same error after checking connecting handling, a minimal reproduction would be greatly appreciated.

Any additional insight into this @faxioman?

Friendly ping. If you'd be willing to share a minimal reproduction, I'd be happy to try to find any bug that might be hiding.

@enocom sorry for the delay 🙏🙏🙏
I was using n1-standard-1 vm in my k8s cluster and, under load, I see that a lot of db connection where left open.
In a django web project, the db connections are opened when a request starts and closed at the request end.
There was slow requests with consequent opened db connections.
I can’t say why switching to older version of proxy mitigate the problem but after some day the problem occurred again.
After switching to n2-standard-2 (but using 3 nodes instead of the previous 6 n1-standard-1) I can’t observe any leak in db connection
Thanks for your support… and sorry for the delay.

Thanks for the update, @faxioman. If you see this issue pop up again, feel free to re-open with a minimal reproduction.


Issue with grouped options menu

Hi there. I have another one issue. I have a group of menu items:
<menu xmlns:android="http://schemas.android.com/apk/res/android">

	<item
		android:id="@+id/im_sort"
		android:icon="@drawable/ic_action_sort"
		android:title="Sort by..."
		android:showAsAction="ifRoom"
		android:orderInCategory="1">
		<menu>

			<group
				android:id="@+id/im_sort_group"
				android:checkableBehavior="single">
				<item
					android:id="@+id/im_sort_artistic"
					android:checked="true"
					android:title="Artistic" />
				<item
					android:id="@+id/im_sort_original"
					android:title="Original" />
				<item
					android:id="@+id/im_sort_technic"
					android:title="Technic" />
			</group>
		</menu>
	</item>

</menu>

Note that group have android:checkableBehavior="single" attribute. That means if I choose one of items from that group and check it in the code, another items should to be unchecked automatically:
public boolean onOptionsItemSelected(MenuItem item) {
		int index = -1;
		switch (item.getItemId()) {
		case R.id.im_sort_artistic:
			index = SORT_ARTISTIC;
			break;
		case R.id.im_sort_original:
			index = SORT_ORIGINAL;
			break;
		case R.id.im_sort_technic:
			index = SORT_TECHNICAL;
			break;

		}
		if (index != -1) {
			item.setChecked(true);
		}

		return super.onOptionsItemSelected(item);
	}

On device with 2.3.3 this code works fine, But on Emulator with ICS items do not unchecks.
Here is screenshot:
Also I have a problem with appearing action items on emulator 2.1, but I think I should post another issue here

I can reproduce. Investigating...

This deals with the fact that setExclusiveChecked is a method on MenuItemImpl so when we are inflating to the native version we were unable to set it properly. Now we just call on the native menu inflater to inflate directly to the native menu. This is better anyways since it will enable new features on new APIs automatically.
Get the latest 4.0-wip branch for the fix.

Awesome! Now it works perfect. Thank you for quick response.


Progress indicator revisited.

It would also be helpful to have ipfs-pack serve show how far it is with verifying the pack integrity. My 30+ GB pack takes about 7-8 minutes - and unless I am actively monitoring the console there is no way to really know when it starts...
Could there be a way to add something like a webhook in the config, that the daemon pings when it is up - or sends a heartbeat to? Sometimes the daemon will not be accessible via NAT traversal and for some use-cases it would be great to be able to have it report to a monitoring endpoint.

It's probably simpler to just do this outside of ipfs-pack. You can call ipfs-pack verify yourself, ping the webhook with curl, and then call ipfs-pack serve --verify=false to serve the pack without verifying.

Ok, thanks. I can confirm that --verify=false works as expected.


Venues not being cleared in time

Venues are currently set the clear at the end of every week. Existing code is confirmed to set this appropriately. I will clear dining caches on the server to see if that helps


Add support for separate audio tracks for the iqiy extractor.

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
This adds support to download separate audio tracks from iq.com. Without using this feature it's not possible to download audio other than the default which is provided with the video data. For example in this link: https://www.iq.com/play/the-spy-dad-2003-19ruth8vp4?lang=en_us there is a Mandarin and Cantonese dub. With this change it's possible to download the Mandarin and Cantonese audio separately.
The audio data is downloaded as fragments. A custom downloader is used to gzip decompress the first fragment as it is downloaded.

@Lesmiscore Would #3048 be useful for this?

@pukkandan Don't think so, where does background task comes in?

The point of #3048 is to provide sufficient generalization that the need for custom downloaders can be removed. We need to think about how this can integrated into it

I'm not sure about that. If it didn't have to be decompressed, which downloader can download it? hls/dash? (there doesnt seem to be a manifest)

Ah, yeah I guess so actually. Is there a downloader that'd be able to download a plain list of urls?

The extractor could generate it's own m3u8 file I suppose, but not sure if that'd be a good idea.

That may not be a terrible idea. This is roughly what I had in mind before I realized hlsFD/dashFD can't download it https://github.com/pukkandan/yt-dlp-dev/tree/features/fragment-packing
The primary issue with both this method, and your PR is that a lot of json requests are being made irrespective of whether the user wants that format or not.
On second thought, it's probably best to stick to a custom downloader, but move the json requests into the downloader

I actually tried that at some point but had some blocker and moved them over to the extractor just to get it working, I'll give it another shot since it would be considerably faster for checking formats and what not.

Also, it would be nice (but not a must) if we can keep --downloader aria2c and -N working

I found some time to work on this a bit more. I moved resolving the urls for the audio fragments to the IqAudioFragmentFD class so that querying the formats took less time.
I tested it with --downloader aria2c and -N and everything seems to work fine. I'm guessing that's because of the FragmentFD base class for IqAudioFragmentFD?


MacBook bug

Every time I open microsoft.github.io/SandDance from Microsoft website my MacBook screen stops working properly

Hello, thanks for posting. Are you able to view the examples at https://deck.gl/examples or https://deck.gl/showcase ?

Hello, yes I can, I only have a problem with Sanddance

Do these examples load?:
https://microsoft.github.io/SandDance/examples/

Do these examples load?:
https://microsoft.github.io/SandDance/examples/

Yes, thank you

Can you provide your machine specs? I will see if I can repro on a similar Mac.


Remove sanity.perf from JDK8 pipelines (and other stuff...)

Splitting this out from slack thread on the subject
I've been doing some analysis on the performance of the overnight builds and there are some things which are causing notable slowdowns which we should consider removing from the daily runs.
One of the biggest issues is with platforms which do not have a JIT. Now that we have enabled JIT on the AdoptOpenJDK arm32 JDK8 builds, the only ones build without an active JIT are OpenJ9 RISC-V (Still in development, not a full release platform yet) and JDK8 on Linux/s/390x for HotSpot. There are some others that are problematic too though - here is a list of ones we should consider modifying or removing:

JDK8/HS/s390x sanity.perf runs take around 9 hours, so I propose removing this, or trying to reduce the time of it via other means
JDK8/HS/xLinux sanity.external tomee test regularly hits 10 hour timeout (Although on the packet machine it can pass in 7 hours)
JDK11/J9/Linux-aarch64 extended.functional - takes 5 hours so is a lot longer than most other tests (although today it had another issue and hit the 10hr timeout)
JDK8/J9/s390x sanity.external - this has occasionally taken over 10 hours although today it seemed to get through most of the process then got stuck waiting for another executor near the end) - If this stays under about 90 minutes I'm ok to leave it in but we should keep an eye on it :-)

Linux/s390x JDK8 pipeline timings
I have run some new JDK8/s390x pipelines today and J9xl completed in about 2h31, j9 (non-XL) tool 4h30 but the difference to XL is likely just how it got scheduled around HotSpot as it has completed in about 2h31 in the past. I expect HotSpot will take about 10 hours including the build time and the sanity.perf run (Note that sanity.system takes over 4 hours for HotSpot so that will potentially be the limiting factor if we remove sanity.perf)

New related issue: systemtests on OpenJ9 have started running slowly over the weekend - raised at https://github.com/eclipse/openj9/issues/11080

Since we seem to be sprawling issues here:

Determing test schedule: https://github.com/AdoptOpenJDK/openjdk-tests/issues/2037
JDK8: https://github.com/AdoptOpenJDK/openjdk-tests/issues/2050
JDK11: https://github.com/AdoptOpenJDK/openjdk-tests/issues/2051


addresses replicating-kicking race condition in minion

Currently, failing a minion triggers a large number of replicating tasks, many which become errored due to failed kicks.
I believe this is due to a race condition where the kick message is sent to spawn while the task is idle, then a minion
failure causes spawn to send a task-replicate message to the same minion before the kick message in processesd, the minion
handles the replicate message, finally the minion tries to handle the kick message but fails because the task isnt idle.
This change essentially demotes the non-idle failure to a warning, similar to the minions response when it tries to kick
a task it doesnt have run-capacity for.

Just so it's on the record, there's a problem with this branch in that went spawn receives the cant-begin-task message, it tries to set the task state to idle (assuming it was previously in allocated state).
So, this shouldnt be merged until I push a fix.  Still trying to decide how I want to handle this, probably send back a different message type when the task is replicating/non-idle.

I implemented your suggestion of adding the current task state to the exception message.  The job and task ids would already be logged in Minion where it catches the exception, but not in the exception message itself.
As for the sending the ignored kick message back to spawn, I dont think there's any benefit operationally, and there is some cost in terms of code size (new message type, new case in the if/else chain of message type handlers).
The yammer metrics are already centralized, and I think it would almost always be easier to check for the ignored-kick problem happening via metrics rather than searching the spawn logs.  Furthermore, once you do see that a kick is ignored, you will probably want to find the specific minion that had the problem and go to its logs from that time period - I don't think there's any avoiding that.

While it may be easier to check metrics than spawn log, convention is still spawn log. I never look at hydra metrics.


Highlights with trailing spaces is buggy

https://stackoverflow.com/questions/26962323/what-is-this-insane-space-character-google-chrome


Adds Chicago Bike Demo

Adds the Chicago Bike Demo to the docs.

Predict Bike Trips

@thehomebrewnerd thanks for the great feedback! The PR has been updated and is ready for another review.

I also updated the other notebooks based on the same feedback.

I think it would be helpful to have the notebooks on google colab.

@thehomebrewnerd the section for making predictions has been updated and is ready for review.

@jeff-hernandez Another thought in terms of the discussion - instead of using the term "future data", maybe we should call this "new data" instead, if we are going to use this approach. The word "future" could be a little confusing. How could we obtain future data to make predictions?
Instead, I think what we are trying to illustrate is that after we have built a model we might acquire additional data, and we can combine this "new" data with the old data to create a new feature matrix that we can then be used to make predictions.


Omitting "else" from an if statement

Hi all,
Please close this issue if this is already possible - it doesn't seem to work currently
When using an if statement, an else block must be present
foo myarg:
  echo {{ if myarg != "" { "myarg is present" } else { "" } }}

Would it be possible to default to "" is an else block is omitted?
foo myarg:
  echo {{ if myarg != "" { "myarg is present" } }}

Thanks!

I think this is probably reasonable. I don't really like defaulting to "", it just seems inelegant, but I don't see a better alternative.

I'm taking a look at this issue because it looks relatively simple to implement, where exactly is the implementation for conditionals?

It's in a few places, but you can start with Parser::parse_conditional, and make Expression::Conditional::otherwise an Option.


Convert monitor module (take 2)

Overlay my conversion changes on top of the current ones.

View a preview at https://prompt.ws/r/Azure/azure-cli/5143
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.


Handling m97 agent dependency by checking the new parameter existence…

… in the cmdlet

L0 tests are green now

Looks fine.

Looks fine.


Setup PostgreSQL

Configure Django to work with PostgreSQL
Setup a Postgre Database
Setup pgAdmin

still todo: pgadmin
this will take 1-2 hours


mobile/app: call the Start callback in x11.go

I had it in a client but just deleted it by accident. Easy to recreate if you have a working linux desktop.

You should probably call the Stop too.
Maybe something along this (before closing the X11 window):
https://github.com/capnm/mobile/blob/patch-1/app/x11.c#L161
https://github.com/capnm/mobile/blob/patch-1/app/x11.c#L121

If you would like to mail a CL, please do. It will be a few days before I have a working linux machine to get to this.

Not calling the start callback breaks the basic example on X11, which segfaults in eglDrawArrays().
@capnm: have you gotten around to submitting a CL? If not, I'll gladly do it.

Please mail a CL, I'll review it.

Here you go:  https://go-review.googlesource.com/6262 mobile/app: call the Start/Stop callbacks in x11.go

@capnm: have you gotten around to submitting a CL? If not, I'll gladly do it.

@db47h Thanks for doing this. I missed the bug notification and deleted the cloned archive,
FWIW here is a copy: https://gist.github.com/capnm/9de3a3aab7bd1acdd13d
An another issue I had, was that the current event handling eats without a vsync 100% cpu.
I don't have currently the time to setup things and submit a CL myself, if you'd like, you can
take a look what I did and go ahead :-)
https://gist.github.com/capnm/9de3a3aab7bd1acdd13d#file-x11-c-L194

Yeah, I think I saw vsync's ignored on intel but not nvidia, on linux. Or maybe vice versa, I forget. It could be a mesa bug but I don't know. I intend to investigate but it hasn't been high-priority for me.

Well, it used to be a PITA to get VSync working at all on Linux. It does work at least with the proprietary nvidia drivers. Programmers cannot however expect that enabling VSync will have any effect. This  applies to all OSes: if the user has globally disabled VSync in the driver settings, enabling it on the application side will do nothing. IMHO, the best approach to this is to try to enable it, but never expect it to be enabled, and in any case, this should not be dealt with in the mobile/app since this is related to application timing (where requirements differ greatly from one app to another). #9413 seems to be a good place to debate about this.
@capnm I opened a new issue against the X11 event-loop in #10054 where your rewrite of the event loop looks to be a good fix. I will however leave the VSync related stuff and frame clamping out of it ;)

Thanks for the fix, I can use the start callback now.
That said, I noticed geom.Width and geom.Height are not initialized when start is invoked. Is this fixable ?

I propose to add an "onResize" callback. I did that for desktop, but could be probably used for setting glViewport (for landscape/portrait mode) on mobile too.

We definitely need more event notifications or callbacks as well as a hook into the underlying windowing system, at least to set window properties (size, fullscreen, enable vsync based on user preferences, etc).  ;)

I believe this issue, as described, is now obsolete. There are however some other good points that have been mentioned. I believe the X11 port doesn't have all the lifecycle events plumbed through, and we have no notion of window size hinting or explicit resizing events. These are probably worth their own issues, if anyone feels like filing them.

Yes, should have been closed a while back (my fault, I messed up the Fixes line in the CL). Regarding the missing X11 events, I'll give it another go after the 1.5 release.


chore: merge develop into master for v0.4.3 release

Pull Request doc
Purpose
With #507 and #512, we moved functionality from PostREISE into PowerSimData. With https://github.com/Breakthrough-Energy/PostREISE/pull/310, we remove this functionality from PostREISE and import these functions directly from PowerSimData. If we create a v0.4.3 release of PowerSimData that includes these functions, then we can specify that the upcoming v0.5.0 release of PostREISE requires PowerSimData >= v0.4.3, so that anyone using the latest PostREISE will know that they need a compatible version of PowerSimData.
What the code is doing
All code has been previously reviewed.
Proposed release notes
Closed Issues

Refactor Mock objects to make it capable to take alias calls for scenario object (#434)

Merged pull requests (features)

feat: add substation transmission capacity calculation (#500) (@danielolsen)
feat: enable retrieval of pf and dcline_pf from MockAnalyze (#502) (@danielolsen)
feat: allow state method passthrough in MockScenario objects (#503) (@danielolsen)
feat: calculate interzone capacity (#504) (@ywang303)
feat: add base_grid input to investment cost calculation functions (#506) (@danielolsen)
feat: deduplicate interconnect passed to grid constructor (#510) (@jon-hagg)

Merged pull requests (fixes, etc.)

chore: add pf input to MockAnalyze (#501) (@danielolsen)
refactor: add compare module, move Grid/Scenario check functions from PostREISE to PowerSimData (#507) (@danielolsen)
ci: code coverage reporting (#508) (@jon-hagg)
ci: fix yaml and add codecov badge (#509) (@jon-hagg)
refactor: move PostREISE helper functions to PowerSimData (#512) (@danielolsen)
doc: add docstring for kind param in export_transformed_profile (#515) (@danielolsen)
chore: bump version number to v0.4.3 (#516) (@danielolsen)

Time estimate
5 minutes.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@122516d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #514   +/-   ##
=========================================
  Coverage          ?   74.08%
=========================================
  Files             ?       98
  Lines             ?     7602
  Branches          ?      983
=========================================
  Hits              ?     5632
  Misses            ?     1790
  Partials          ?      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 122516d...f0bdcf2. Read the comment docs.


Updating GetClrDbg.sh script to accept switch arguments.

Added functionality to remove existing installation, skip downloads and launch clrdbg after installation.
And some refactoring.

@chuckries  @gregg-miskelly  @wesrupert
Tested with Linux. Will test it on mac.

LGTM

:+1:

LGTM! :shipit:


jdk22: 22.0.1-ga -> 22.0.2-ga

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for jdk22 is: Open-source Java Development Kit
meta.homepage for jdk22 is: https://openjdk.java.net/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 22.0.2-ga with grep in /nix/store/677pxbfqzp5d9i1049yzhmpchhfz0jsw-openjdk-22.0.2-ga
found 22.0.2-ga in filename of file in /nix/store/677pxbfqzp5d9i1049yzhmpchhfz0jsw-openjdk-22.0.2-ga

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

8 package rebuild(s)

First fifty rebuilds by attrpath

cryptomator
jdk22
jdk22_headless
jextract
moneydance
openjdk22
openjdk22_headless

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/677pxbfqzp5d9i1049yzhmpchhfz0jsw-openjdk-22.0.2-ga \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jdk22 https://github.com/r-ryantm/nixpkgs/archive/1af9acb57f4c4a1d3e30c6d63855059f81563196.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1af9acb57f4c4a1d3e30c6d63855059f81563196#jdk22

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/677pxbfqzp5d9i1049yzhmpchhfz0jsw-openjdk-22.0.2-ga
ls -la /nix/store/677pxbfqzp5d9i1049yzhmpchhfz0jsw-openjdk-22.0.2-ga/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

7 packages built:

cryptomator
jdk22
jdk22.debug
jdk22_headless
jdk22_headless.debug
jextract
moneydance

Maintainer pings
cc @edwtjo @Infinidoge for testing.

Result of nixpkgs-review pr 328278 run on x86_64-linux 1

7 packages built:

cryptomator
jdk22 (openjdk22)
jdk22.debug (openjdk22.debug)
jdk22_headless (openjdk22_headless)
jdk22_headless.debug (openjdk22_headless.debug)
jextract
moneydance


Use environment variable to specify protractor location

Hi,
In some situations, it's useful to be able to specify one protractor install location to use.
For instance, one of my clients prevents any .cmd or .bat file to be executed outside of a specific directory (where global npm packages are installed). Thus, I needed to tell gulp-protractor to use the globally installed protractor.
This PR introduces the PROTRACTOR_DIR environment variable to specify the directory where the protractor and webdriver-manager binaries / wrappers are located.

+1

+1

gulp-protractor doesn't work with --no-bin-links as .bin doesn't exist. This could be a good work around for this. Can this be merged?
@AdamSelene - can you resolve the conflicts?

@jfstephe done


fix serialized name issue in deserialization

A follow up for https://github.com/microsoft/typespec/pull/3755

API change check
API changes are not detected in this pull request.


unity: add cue/stats info to Unity output

Is your feature request related to a problem? Please describe.
The execution time difference currently displayed in Unity seem a bit unreliable.
Describe the solution you'd like
I would like Unity to use cue/stats metrics to get more detailed and accurate performance metrics between implementations.
Note that accessing these stats is mostly still internal, but could probably be exposed as a command line tool flag.
Describe alternatives you've considered
Using running time, which seems inaccurate.
Additional context
See cue/stats package.

Closing as a duplicate of https://github.com/cue-unity/unity/issues/37 per @myitcv. Also a reminder that Unity has its own issue tracker :)


Is it possible to add Multiple credentials?

Is it possible to add multiple credentials file or json array , which have to work randomly when run the program.
Actually i want to download multiple apk by running it with an api request which gonna hold upto 100 apps.
Random (multiple) credentials required to stay unban from google.

@Croodo are you able to run it with single credential? for the past 4 days there is an issue with login to playstore api. are you not facing it?

Nop can’t fetch ,  login failed , didn’t noticed that before. 😑

Is it possible to add multiple credentials file or json array , which have to work randomly when run the program.

Currently it's not implemented, but it could be a good enhancement. The json configuration file is already an array, but currently contains only one credential. I think you could add more credentials to the json configuration and then change this line of code to take a random credential from the list (instead of the first one):
https://github.com/ClaudiuGeorgiu/PlaystoreDownloader/blob/58a74a9ab2749f932c32bc8204a3a323d115629e/playstoredownloader/playstore/playstore.py#L112

Hello Gabriel,
Thanks for the tip. I guess you are aware that i the past few days there is an issue with anything related to login on the gplayapi.
Are you able to login? can you please help with that?

I guess you are aware that i the past few days there is an issue with anything related to login

I just tried and I confirm that login is not working also for me. I'm sorry, but I don't have a solution and I don't think I will be able to spend time working on this issue in the near future.


[201]

Info
Reported by: Guest<EMAIL_ADDRESS>- Open in Gleap
Location: AR
Type: 🚨 BUG
🔗 Open share link
🌍 Open ticket in Gleap
Metadata
browserName: Chrome(<IP_ADDRESS>)
userAgent: Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Mobile Safari/537.36
browser: Chrome
systemName: Android
sessionDuration: 205
devicePixelRatio: 2.625
screenWidth: 412
screenHeight: 915
innerWidth: 412
innerHeight: 773
currentUrl: https://docs.near.org/concepts/basics/tokens
language: es-US
mobile: true
sdkVersion: 10.1.0
sdkType: javascript
environment: prod

Hi, could you explain what kind of issue you are having with Near Docs? thanks!


Risingwave doesn't throw error when server.id in mysql cdc is incorrect.

Describe the bug
When creating a mysql cdc table, user fills in an incorrect server.id, risingwave failed silently in background, but didn't report any error.
Error message/log
No response
To Reproduce
No response
Expected behavior
It's expected to report this error to user explicitly when server.id is misconfigured rather forcing user to find it in connector log.
How did you deploy RisingWave?
No response
The version of RisingWave
No response
Additional context
No response

@StrikeW Any updates?

@StrikeW Any updates?

No yet.

https://github.com/risingwavelabs/risingwave/pull/13031#discussion_r1372777527

Done by #13031


Python -m grpc_tools.protoc fails on Raspberry Pi Zero W

What version of gRPC and what language are you using?
sudo pip3 install grpcio-tools
grpcio-tools (1.23.0)
grpcio>=1.23.0 (1.23.0)
protobuf>=3.5.0.post1 (3.9.1)
six>=1.5.2 (1.12.0)
setuptools (41.2.0)
What operating system (Linux, Windows,...) and version?
Linux, stretch
What runtime / compiler are you using (e.g. python version or version of gcc)
python 3.7
What did you do?
$ python3.7 -m grpc_tools.protoc -I. --python_out=. --grpc_python_out=. calculator.proto
What did you expect to see?
I expected code files to be generated
What did you see instead?
Traceback (most recent call last):
File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.7/dist-packages/grpc_tools/protoc.py", line 20, in
from grpc_tools import _protoc_compiler
ImportError: /usr/local/lib/python3.7/dist-packages/grpc_tools/_protoc_compiler.cpython-37m-arm-linux-gnueabihf.so: undefined symbol: __atomic_fetch_add_8
Anything else we should know about your project / environment?
It seems protobuf had the same issue and fixed it by linking to atomic, see https://github.com/protocolbuffers/protobuf/commit/55ed1d427ccc0d200927746329ac9b811dee77b9
https://github.com/protocolbuffers/protobuf/issues/5219

I tried to install it again on another Raspberry Pi Zero. The installation was frozen and I got the message :
cc1plus: warning: command line option ‘-std=gnu99’ is valid for C/ObjC but not for C++

@Fox5150 pip is trying to compile gRPC from source, and it does take some time. Alternatively, you can check https://www.piwheels.org/project/grpcio/ for precompiled wheels made for Raspberry Pi.
This issue should be fixed by #20414. If your issue persists, please consider open a new issue.

@lidizheng Thanks very much ! It worked. I installed this version :
1.26.0 | cp37m | grpcio-1.26.0-cp37-cp37m-linux_armv7l.whl
Thanks again !


feat(module:datapicker): add [nzInputReadOnly] (#4534)

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:#4534
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

感谢 PR！如果能加上测试用例就更好了。

感觉您的建议！我将继续完善


update heapless and hash32

Thanks!
Could you make the CI happy on the tests & linting?

I'm not really sure what it is about the linker errors in the Test.
Using it in, for example, ublox-cellular-rs it is just fine building.

The commit fixes the linking issue but not the tests itself which fail. But they don't seem to be related to the changes

Fair enough. Should we maybe change the CI to run that as tests instead?

Yes, I think that's a sensible solution.

I don't understand why these tests are suddenly failing ...

I tried to fix the tests on a logic level, but please take a look if they are still what they supposed to be.

Ahh, Yeah.. I now see that the issue was originally on me, as I never actually ran the tests on this WIP async branch.
What you have done here seems super reasonable! Thanks!
I am sorry!


Native image build fails with Micronaut 4.2.1

Expected Behavior
Building native-image of Micronaut 4.2.1 with tracing-opentelemetry-jaeger dependency succeeds.
Actual Behaviour
Builds fails with:

[1/8] Initializing...                                                                                (4.9s @ 0.33GB)
Java version: 17.0.7+8-LTS, vendor version: Oracle GraalVM 17.0.7+8.1
Graal compiler: optimization level: b, target machine: x86-64-v3, PGO: off
C compiler: gcc (linux, x86_64, 9.4.0)
Garbage collector: G1 GC (max heap size: 25.0% of RAM)
2 user-specific feature(s)

io.micronaut.cache.caffeine.graal.CaffeineFeature
io.micronaut.core.io.service.ServiceLoaderFeature
[2/8] Performing analysis...  [*]                                                                       (37.7s @ 3.03GB)
20,125 (90.34%) of 22,278 types reachable
30,898 (62.72%) of 49,262 fields reachable
111,996 (65.06%) of 172,153 methods reachable
6,980 types,   602 fields, and 5,535 methods registered for reflection
5 native libraries: dl, g1gc-cr, m, pthread, stdc++

Error: Classes that should be initialized at run time got initialized during image building:
kotlin.coroutines.intrinsics.CoroutineSingletons was unintentionally initialized at build time. To see why kotlin.coroutines.intrinsics.CoroutineSingletons got initialized use --trace-class-initialization=kotlin.coroutines.intrinsics.CoroutineSingletons
To see how the classes got initialized, use --trace-class-initialization=kotlin.coroutines.intrinsics.CoroutineSingletons
Error: Use -H:+ReportExceptionStackTraces to print stacktrace of underlying exception

Works with Micronaut 4.1.6, discussed on Discord "Micronaut Framework 4.2.0 updates to Kotlin 1.9.2 so it appears something broke."
https://discord.com/channels/1121511613250412714/1182711987310960670
Steps To Reproduce

Create micronaut service with graalvm / tracing-opentelemetry-jaeger via Launch
run /mvnw  -Dpackaging=native-image  package -P graalvm

Environment Information
OS: Ubuntu
Java version: 17.0.7+8-LTS, vendor version: Oracle GraalVM 17.0.7+8.1
Example Application
Here is the sample project https://github.com/msixta/native-image
Version
4.2.1

Hi,
I'm not sure that this behaviour is micronaut-tracing related. I experience the same with Micronaut 4.2.1 w/o any dependency to micronaut-tracing. My guess is that this must be something general in combination with Gradle Kotlin builds.

something broke / changed in Kotlin 1.9, downgrading to 1.8 will fix it

I'm not sure that this behaviour is micronaut-tracing related. I experience the same with Micronaut 4.2.1 w/o any dependency to micronaut-tracing. My guess is that this must be something general in combination with Kotlin.

It compiles fine if I remove io.opentelemetry:opentelemetry-exporter-jaeger dependency. So yes it seems to be more general problem, but on the other hand it affects specifically micronaut-tracing with jaeger exporter


Add support for Vim commands, #eval calls #connect if it hasn't been already

Adding Vim support to the plugin. Largely just if has('nvim') as necessary, though new is moved as Vim's term_start opens a new buffer.
Also having scheme#eval call scheme#connect, so users can start the REPL from the cp* commands. That could be put behind a g: variable if it isn't desired as default behavior.

I haven't been using this for a while now but the changes make sense to me! Thank you very much for the contribution! :tada:


Adding multiple operations loses metadata on the way

Hi there,
another similar one to the previous, for example this roll /r (10d10 #f<=2)kl2. Adding the kl2 to count the lowest 2 works fine, but it loses the info about "failures" from the #f<=2 . The counting needs to be done from the original roll, so adding it after the kl2 would already have dropped some information.
Cheers

I'll have to review the code to figure out how best to handle it. But... maybe this points to the current API's clunkiness and lack of usability from an app.
These counting operations are probably silly to expose only through the metadata in the result or logging.
It'll probably depend on the app / use-case for how a client wants to expose that metadata to the end user.
As in... maybe part of the API should include a way for the client to register callbacks on dice rolls or evaluation of expressions. Then at each level of the evaluation graph, the client might get an events and let it do interesting things. e.g. render a dice roll, remove dice from previous roll, etc.

as to my comments on other issue, here's how the results from that roll look in my in-progress work:
❯ dart run example/main.dart -r 1234 -o pretty '(10d10 #f<=2)kl2'
(((10d10) #f<= 2) kl 2) ===> RollSummary(total: 4, results: [1, 3], metadata: {rolled: [1, 3, 3, 4, 6, 6, 7, 7, 8, 9], discarded: [3, 4, 6, 6, 7, 7, 8, 9], score: {failures: [1]}})
  (((10d10) #f<= 2) kl 2) =drop=> RollResult(total: 4, results: [1, 3], metadata: {discarded: [3, 4, 6, 6, 7, 7, 8, 9]})
      ((10d10) #f<= 2) =count=> RollResult(total: 54, results: [1, 3, 3, 4, 6, 6, 7, 7, 8, 9], metadata: {score: {failures: [1]}})
          (10d10) =rollDice=> RollResult(total: 54, results: [1, 3, 3, 4, 6, 6, 7, 7, 8, 9], metadata: {rolled: [1, 3, 3, 4, 6, 6, 7, 7, 8, 9]})

Hey @stevesea - that's awesome, definitely beyond what the issue was about originally but this increases the power of the library as a whole :)
As per the original report, the goal was that in the very end, the metadata of the final roll would keep the in intermediate step metadata, which is awesome to see in your example. I guess the only possible concern is if there are "multiple" formulas that get "discarded" dice key which could then overwrite or conflict.
I haven't tried but not sure what happens if you discard highest and then discard lowest, will it add up all discarded altogether?

Hey @stevesea  - that's awesome, definitely beyond what the issue was about originally but this increases the power of the library as a whole :)
As per the original report, the goal was that in the very end, the metadata of the final roll would keep the in intermediate step metadata, which is awesome to see in your example. I guess the only possible concern is if there are "multiple" formulas that get "discarded" dice key which could then overwrite or conflict.
I haven't tried but not sure what happens if you discard highest and then discard lowest, will it add up all discarded altogether?

yes, each drop is its own RollREsult in the graph. But, the summary will accumulate both the drop-high and drop-low
((((4d6) -h ) -l ) #s= 3) ===> RollSummary(total: 7, results: [3, 4], metadata: {rolled: [1, 3, 4, 4], discarded: [4, 1], score: {successes: [3]}})
  ((((4d6) -h ) -l ) #s= 3) =count=> RollResult(total: 7, results: [3, 4], metadata: {score: {successes: [3]}})
      (((4d6) -h ) -l ) =drop=> RollResult(total: 7, results: [3, 4], metadata: {discarded: [1]})
          ((4d6) -h ) =drop=> RollResult(total: 8, results: [1, 3, 4], metadata: {discarded: [4]})
              (4d6) =rollDice=> RollResult(total: 12, results: [1, 3, 4, 4], metadata: {rolled: [1, 3, 4, 4]})

my thinking was that a client could look at the summary to render the results.
e.g. from 4d6 -h -l #s=3 it rolled it rolled a 1,3,4,4.
a 4 and a 1 were discarded, and it determined '3' was success
so you could render the rolls in a way that crossed out the discards, and highlighted success:

1, ^3 , 4, 4

or, the clients could traverse the result graph to give other feedback to the user, or just have the roll listeners trigger rendering 3d dice flying across their app.
But, I am hoping the summary itself would be usable & self-contained so clients wouldn't have to mess with the graph unless they choose to

fixed in v7.0.0

Testing, so far working really great, still for now using the toJson() to get all entries, but I like the new API.


Replace RFC 2616 references with new RFC 7231

In June the HTTP 1.1 spec RFC 2616 got replaced by a bunch of new updated revision, RFC 7230 to 7235: https://www.mnot.net/blog/2014/06/07/rfc2616_is_dead
The one related to status codes is RFC 7231 which also references a new status code registry at http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
Currently status codes like 503, http://httpstatus.es/503, references the old RFC 2616 and even though there in most cases are no differences (the Appendix B of RFC 7231 outlines which status code that has seen changes) it would be good to have the references updated so that one can know for sure that the description is an up to date one.

I'd also like to see this. Reading the new RFC cleared a lot of things up for me, as a lot of the web still references the old RFC.
A good example is the description for error 403 as described in RFC 7231 is much much more informative than it is in RFC 2616.

I'm over a year and a half late on this... my bad. There's a new project branch which includes all the descriptions updated to the latest, the new site will be deployed in the next few days. You can see progress on the metalsmith branch and in the #23 issue.


Update docker composes

Changelog entry
check if all docker-composes are up to date
Changelog category
Additional information
...

Here is some big change in yt code. Is it intentional or a mistake during rebase?


segfault from wasm-bindgen CLI on OSX with recent rust nightlies

The wasm-bindgen command is reliably giving me a segfault on OSX 10.10.5 when I install with recent rust nightlies. I'm seeing an older rust version fix the issue, so I'm guessing this is a recent nightly regression. I figured I'd give my report in case it helps ID the issue.
The symptom:
Macintosh:~ roberthambourger$ wasm-bindgen --help
Segmentation fault: 11
Macintosh:~ roberthambourger$ wasm-bindgen --version
Segmentation fault: 11
Macintosh:~ roberthambourger$ wasm-bindgen path/to/my/wasm.wasm --out-dir .
Segmentation fault: 11

Sample rustup show output:
Macintosh:~ roberthambourger$ rustup show
Default host: x86_64-apple-darwin

installed toolchains
--------------------

stable-x86_64-apple-darwin
nightly-2018-01-01-x86_64-apple-darwin
nightly-2018-04-30-x86_64-apple-darwin
nightly-x86_64-apple-darwin (default)

installed targets for active toolchain
--------------------------------------

wasm32-unknown-unknown
x86_64-apple-darwin

active toolchain
----------------

nightly-x86_64-apple-darwin (default)
rustc 1.27.0-nightly (91db9dcf3 2018-05-04)

I've tried different combos of wasm-bindgen-cli versions installed with various rust nightly versions. My observations are that

wasm-bindgen-cli 0.2.8 is bad when installed with nightly 2018-05-04, 2018-05-03, and 2018-04-30, but good with 2018-01-01.

wasm-bindgen-cli 0.2.4 through 0.2.8 are all bad with nightly 2018-05-03

Also note that wasm2es6js works for me as expected with all combos tested:
Macintosh:~ roberthambourger$ wasm2es6js --help
Converts a wasm file to an ES6 JS module

Usage:
    wasm2es6js [options] <input>
    wasm2es6js -h | --help

etc.
Thanks as always for the great work and let me know if I can provide more info.

Oh dear this sounds bad! Are you able to attach a debugger and see where the fault is happening?
This doesn't reproduce locally for me unfortunately :(

Hmm, ok. The callstack apparently passes through thread_local via regex via docopt. It makes sense that docopt is involved since this is affecting every wasm-bindgen option.
Here's my rust-lldb output (this is after re-installing wasm-bindgen-cli with the --debug option with nightly 2018-05-04):
Process 2273 stopped
* thread #1: tid = 0x407f, 0x000000010051db92 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] core::ptr::swap_nonoverlapping_bytes::h6df82f8d5ea7e526 + 28 at ptr.rs:237, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT)
    frame #0: 0x000000010051db92 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] core::ptr::swap_nonoverlapping_bytes::h6df82f8d5ea7e526 + 28 at ptr.rs:237
(lldb) bt
* thread #1: tid = 0x407f, 0x000000010051db92 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] core::ptr::swap_nonoverlapping_bytes::h6df82f8d5ea7e526 + 28 at ptr.rs:237, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT)
  * frame #0: 0x000000010051db92 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] core::ptr::swap_nonoverlapping_bytes::h6df82f8d5ea7e526 + 28 at ptr.rs:237
    frame #1: 0x000000010051db76 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] core::ptr::swap_nonoverlapping::hdae0ad8ddd3a4807 at ptr.rs:187
    frame #2: 0x000000010051db76 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] core::mem::swap::h079abbed39293f6c at mem.rs:634
    frame #3: 0x000000010051db76 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] core::mem::replace::h33caec918b20cf74 at mem.rs:691
    frame #4: 0x000000010051db76 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::init::hf29d791cc8dc2c2f at local.rs:270
    frame #5: 0x000000010051db76 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::try_with::hf4098ad3d27e0fb7 + 34 at local.rs:296
    frame #6: 0x000000010051db54 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::with::h07ea88e18fd4e1fd at local.rs:248
    frame #7: 0x000000010051db54 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] std::panicking::update_panic_count::h96721aee7d30548f at panicking.rs:240
    frame #8: 0x000000010051db54 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec + 4 at panicking.rs:317
    frame #9: 0x000000010020824d wasm-bindgen`std::thread::panicking::hf2650f0279c3587b + 13
    frame #10: 0x0000000100209381 wasm-bindgen`std::sys_common::poison::Flag::borrow::h6a204c3cf5f3e9a0 + 17
    frame #11: 0x00000001002062d7 wasm-bindgen`_$LT$std..sync..mutex..MutexGuard$LT$$u27$mutex$C$$u20$T$GT$$GT$::new::h61ce00daf227bcd8 + 39
    frame #12: 0x00000001002062a3 wasm-bindgen`_$LT$std..sync..mutex..Mutex$LT$T$GT$$GT$::lock::h7159199f04e5e3d7 + 51
    frame #13: 0x00000001002095f8 wasm-bindgen`thread_local::thread_id::ThreadId::new::h6921b80d28b8a599 + 40
    frame #14: 0x00000001002097bd wasm-bindgen`thread_local::thread_id::THREAD_ID::__init::h5478d05251a82a10 + 13
    frame #15: 0x0000000100206b85 wasm-bindgen`_$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::init::hc377c97075f0478c + 37
    frame #16: 0x0000000100206dee wasm-bindgen`_$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::try_with::he41f193bcfa8bc26 + 334
    frame #17: 0x0000000100206c65 wasm-bindgen`_$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::with::h3dea01a5e8940192 + 21
    frame #18: 0x0000000100209727 wasm-bindgen`thread_local::thread_id::get::hfa631e905ee35447 + 23
    frame #19: 0x00000001000cc90d wasm-bindgen`_$LT$thread_local..CachedThreadLocal$LT$T$GT$$GT$::get_or_try::hc8f09a6d92b53fc9 + 29
    frame #20: 0x0000000100155e48 wasm-bindgen`regex::re_unicode::Regex::locations::he5308b7fe79a3196 + 104
    frame #21: 0x000000010014ccef wasm-bindgen`regex::re_unicode::Regex::captures::h3f9d5d85220d7ec1 + 79
    frame #22: 0x000000010000c678 wasm-bindgen`docopt::parse::Parser::parse::hd4f1e73726c69527 + 120
    frame #23: 0x000000010000be5b wasm-bindgen`docopt::parse::Parser::new::h08a1db9f339f3acf + 523
    frame #24: 0x00000001000050ce wasm-bindgen`docopt::dopt::Docopt::new::h999d56b70313ae9b + 110
    frame #25: 0x0000000100000d28 wasm-bindgen`wasm_bindgen::main::h2ac10bbd516a199d + 40
    frame #26: 0x0000000100005472 wasm-bindgen`std::rt::lang_start::_$u7b$$u7b$closure$u7d$$u7d$::h4eac75b514bea9ce + 18
    frame #27: 0x000000010051db38 wasm-bindgen`std::panicking::try::do_call::h0f8a789012cd34c6 [inlined] std::rt::lang_start_internal::_$u7b$$u7b$closure$u7d$$u7d$::h3e3d4117cb482f1c + 24 at rt.rs:59
    frame #28: 0x000000010051db2c wasm-bindgen`std::panicking::try::do_call::h0f8a789012cd34c6 + 12 at panicking.rs:310
    frame #29: 0x000000010052981f wasm-bindgen`__rust_maybe_catch_panic + 31 at lib.rs:105
    frame #30: 0x00000001005140e2 wasm-bindgen`std::rt::lang_start_internal::h775766efcbaa9c6c [inlined] std::panicking::try::h5a637b8342249be1 + 51 at panicking.rs:289
    frame #31: 0x00000001005140af wasm-bindgen`std::rt::lang_start_internal::h775766efcbaa9c6c [inlined] std::panic::catch_unwind::h095eff007ddeac63 at panic.rs:374
    frame #32: 0x00000001005140af wasm-bindgen`std::rt::lang_start_internal::h775766efcbaa9c6c + 191 at rt.rs:58
    frame #33: 0x0000000100005452 wasm-bindgen`std::rt::lang_start::heb39064736550b2c + 66
    frame #34: 0x0000000100003805 wasm-bindgen`main + 37
    frame #35: 0x00007fff889415c9 libdyld.dylib`start + 1

If I'm reading that right, there's a panic from trying to lock a poisoned mutex, but then the panic code hits an EXC_BAD_ACCESS which is what actually crashes the app. Is that what you're seeing too? If so, it seems like there are two separate issues, the poisoned mutex and the EXC_BAD_ACCESS, no?
And wasm-bindgen and wasm2es6js both call Docopt::new, so the reason this is only affecting wasm-bindgen is... some non-obvious difference in their usage strings??
There's more I'd like to debug on my end. But in the meantime, this all looks pretty far removed from wasm-bindgen. So I'd be fine closing this issue. Do you have any advice on where to file this instead? It's not clear to me if the fault lies in libstd, thread_local, regex, or some combo.
Thanks for your help!

cc @BurntSushi have you ever seen a segfault like this? I can't really explain what's going on :(
@TimHambourger can you get a diassembly of precisely what the faulting instruction is?

@alexcrichton Sure thing. Does this give you what you need?
Process 2080 stopped
* thread #1: tid = 0x34c2, 0x000000010051db92 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] core::ptr::swap_nonoverlapping_bytes::h6df82f8d5ea7e526 + 28 at ptr.rs:237, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT)
    frame #0: 0x000000010051db92 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] core::ptr::swap_nonoverlapping_bytes::h6df82f8d5ea7e526 + 28 at ptr.rs:237
(lldb) disassemble --frame
wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec at panicking.rs:316:
   0x10051db50:  pushq  %rbp
   0x10051db51:  movq   %rsp, %rbp
   0x10051db54:  subq   $0x10, %rsp
   0x10051db58:  leaq   0x22e701(%rip), %rdi      ; std::panicking::update_panic_count::PANIC_COUNT::__getit::__KEY::h0d46fda1cd45c9ae
   0x10051db5f:  callq  *(%rdi)
   0x10051db61:  cmpq   $0x1, (%rax)
   0x10051db65:  jne    0x10051db76               ; std::panicking::panicking::hba52d83258fa66ec + 38 [inlined] core::ptr::swap_nonoverlapping_bytes::h6df82f8d5ea7e526 at ptr.rs:187
std::panicking::panicking::hba52d83258fa66ec + 38 [inlined] core::ptr::swap_nonoverlapping::hdae0ad8ddd3a4807 at mem.rs:634
std::panicking::panicking::hba52d83258fa66ec + 38 [inlined] core::mem::swap::h079abbed39293f6c at mem.rs:691
std::panicking::panicking::hba52d83258fa66ec + 38 [inlined] core::mem::replace::h33caec918b20cf74 at local.rs:270
std::panicking::panicking::hba52d83258fa66ec + 38 [inlined] _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::init::hf29d791cc8dc2c2f at local.rs:296
std::panicking::panicking::hba52d83258fa66ec + 38 [inlined] _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::try_with::hf4098ad3d27e0fb7 + 34 at local.rs:248
std::panicking::panicking::hba52d83258fa66ec + 4 [inlined] _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::with::h07ea88e18fd4e1fd at panicking.rs:240
std::panicking::panicking::hba52d83258fa66ec + 4 [inlined] std::panicking::update_panic_count::h96721aee7d30548f at panicking.rs:317
std::panicking::panicking::hba52d83258fa66ec + 4 at panicking.rs:317
   0x10051db67:  leaq   0x22e6f2(%rip), %rdi      ; std::panicking::update_panic_count::PANIC_COUNT::__getit::__KEY::h0d46fda1cd45c9ae
   0x10051db6e:  callq  *(%rdi)
   0x10051db70:  movq   0x8(%rax), %rcx
   0x10051db74:  jmp    0x10051db97               ; std::panicking::panicking::hba52d83258fa66ec + 71 [inlined] core::ptr::swap_nonoverlapping_bytes::h6df82f8d5ea7e526 at ptr.rs:187
std::panicking::panicking::hba52d83258fa66ec + 71 [inlined] core::ptr::swap_nonoverlapping::h68a2b8a25e0adf7d at mem.rs:634
std::panicking::panicking::hba52d83258fa66ec + 71 [inlined] core::mem::swap::h5da607e8df09307d at mem.rs:691
std::panicking::panicking::hba52d83258fa66ec + 71 [inlined] core::mem::replace::ha2d91b19f1abcf93 at cell.rs:480
std::panicking::panicking::hba52d83258fa66ec + 71 [inlined] _$LT$core..cell..Cell$LT$T$GT$$GT$::replace::h7d512da2f3effa47 at cell.rs:437
std::panicking::panicking::hba52d83258fa66ec + 71 [inlined] _$LT$core..cell..Cell$LT$T$GT$$GT$::set::h44a09895ea8d28b8 at panicking.rs:242
std::panicking::panicking::hba52d83258fa66ec + 71 [inlined] std::panicking::update_panic_count::_$u7b$$u7b$closure$u7d$$u7d$::h8e6b5150de66179a at local.rs:294
std::panicking::panicking::hba52d83258fa66ec + 71 [inlined] _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::try_with::hf4098ad3d27e0fb7 + 67 at local.rs:248
std::panicking::panicking::hba52d83258fa66ec + 4 [inlined] _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::with::h07ea88e18fd4e1fd at panicking.rs:240
std::panicking::panicking::hba52d83258fa66ec + 4 [inlined] std::panicking::update_panic_count::h96721aee7d30548f at panicking.rs:317
std::panicking::panicking::hba52d83258fa66ec + 4 at panicking.rs:317
   0x10051db76:  movl   $0x1, %eax
   0x10051db7b:  movd   %rax, %xmm0
   0x10051db80:  movdqa %xmm0, -0x10(%rbp)
   0x10051db85:  leaq   0x22e6d4(%rip), %rdi      ; std::panicking::update_panic_count::PANIC_COUNT::__getit::__KEY::h0d46fda1cd45c9ae
   0x10051db8c:  callq  *(%rdi)
   0x10051db8e:  movaps -0x10(%rbp), %xmm0
-> 0x10051db92:  movaps %xmm0, (%rax)
   0x10051db95:  xorl   %ecx, %ecx
   0x10051db97:  leaq   0x22e6c2(%rip), %rdi      ; std::panicking::update_panic_count::PANIC_COUNT::__getit::__KEY::h0d46fda1cd45c9ae
   0x10051db9e:  callq  *(%rdi)
   0x10051dba0:  movq   %rcx, 0x8(%rax)
   0x10051dba4:  testq  %rcx, %rcx
   0x10051dba7:  setne  %al
   0x10051dbaa:  addq   $0x10, %rsp
   0x10051dbae:  popq   %rbp
   0x10051dbaf:  retq
(lldb) disassemble --line
wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec + 38 [inlined] core::ptr::swap_nonoverlapping_bytes::h6df82f8d5ea7e526 at ptr.rs:187
   0x10051db76:  movl   $0x1, %eax
   0x10051db7b:  movd   %rax, %xmm0
   0x10051db80:  movdqa %xmm0, -0x10(%rbp)
   0x10051db85:  leaq   0x22e6d4(%rip), %rdi      ; std::panicking::update_panic_count::PANIC_COUNT::__getit::__KEY::h0d46fda1cd45c9ae
   0x10051db8c:  callq  *(%rdi)
   0x10051db8e:  movaps -0x10(%rbp), %xmm0
-> 0x10051db92:  movaps %xmm0, (%rax)
   0x10051db95:  xorl   %ecx, %ecx

FYI, I'll be traveling for the next few days and won't have the computer where I've been repro'ing this.

Ok thanks! That's a little suspicious... If you get a chance can you see what the value of %rax is? I'm curious if it's a valid pointer or if it's aligned properly

@alexcrichton Sadly, no, I haven't seen this particular blend before. I have seen segfaults with thread_local! on darwin, but not with the thread_local crate. cc @Amanieu

I've run this through a gauntlet of OSX releases on Travis and unfortunately none of them turned up segfaults :(
@TimHambourger in all likelihood this is either a linker bug, a compiler bug, or a libc runtime bug. In that sense the "fix" here would be figuring out how to just flat out avoid whatever is triggering the bug. The wasm-bindgen crate doesn't otherwise use the regex crate so we could switch to something like clap perhaps, but I'm otherwise not entirely sure what to do about this :(

@alexcrichton Thanks for the gauntlet of tests! I'm more than willing to believe that this is particular to this box. I tested on my newer mac w/ OSX 10.12 and saw no problems there.
So I don't see any reason to refactor wasm-bindgen for this. I have a few workarounds available (including sticking to the newer box or installing with the version of rust that I know works). I'll go ahead and close this issue.
But, if you're curious, I did check %rax. I get 0x0000000100f04e58:
Process 1517 stopped
* thread #1: tid = 0x4ee6, 0x000000010051ef32 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] core::ptr::swap_nonoverlapping_bytes::h6df82f8d5ea7e526 + 28 at ptr.rs:237, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT)
    frame #0: 0x000000010051ef32 wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec [inlined] core::ptr::swap_nonoverlapping_bytes::h6df82f8d5ea7e526 + 28 at ptr.rs:237
(lldb) disassemble --line
wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec + 38 [inlined] core::ptr::swap_nonoverlapping_bytes::h6df82f8d5ea7e526 at ptr.rs:187
   0x10051ef16:  movl   $0x1, %eax
   0x10051ef1b:  movd   %rax, %xmm0
   0x10051ef20:  movdqa %xmm0, -0x10(%rbp)
   0x10051ef25:  leaq   0x22f404(%rip), %rdi      ; std::panicking::update_panic_count::PANIC_COUNT::__getit::__KEY::h0d46fda1cd45c9ae
   0x10051ef2c:  callq  *(%rdi)
   0x10051ef2e:  movaps -0x10(%rbp), %xmm0
-> 0x10051ef32:  movaps %xmm0, (%rax)
   0x10051ef35:  xorl   %ecx, %ecx
(lldb) register read
General Purpose Registers:
       rax = 0x0000000100f04e58
       rbx = 0x00007fff5fbff7b0
       rcx = 0x0000000000000000
       rdx = 0x0000000000000000
       rdi = 0x000000010074e330  wasm-bindgen`std::panicking::update_panic_count::PANIC_COUNT::__getit::__KEY::h0d46fda1cd45c9ae
       rsi = 0x0000000101a18068
       rbp = 0x00007fff5fbfd9b0
       rsp = 0x00007fff5fbfd9a0
        r8 = 0x0000000101a18060
        r9 = 0x00007fff5fbfd8f0
       r10 = 0x0000000101a0d008
       r11 = 0xffff8001a1e1a770
       r12 = 0x0000000000000000
       r13 = 0x0000000000000000
       r14 = 0x00007fff5fbff7e8
       r15 = 0x00007fff5fbff7a8
       rip = 0x000000010051ef32  wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec + 66 [inlined] core::ptr::swap_nonoverlapping_bytes::h6df82f8d5ea7e526 + 28 at ptr.rs:187
  wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec + 38 [inlined] core::ptr::swap_nonoverlapping::hdae0ad8ddd3a4807 at mem.rs:634
  wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec + 38 [inlined] core::mem::swap::h079abbed39293f6c at mem.rs:691
  wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec + 38 [inlined] core::mem::replace::h33caec918b20cf74 at local.rs:270
  wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec + 38 [inlined] _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::init::hf29d791cc8dc2c2f at local.rs:296
  wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec + 38 [inlined] _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::try_with::hf4098ad3d27e0fb7 + 34 at local.rs:248
  wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec + 4 [inlined] _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::with::h07ea88e18fd4e1fd at panicking.rs:240
  wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec + 4 [inlined] std::panicking::update_panic_count::h96721aee7d30548f at panicking.rs:317
  wasm-bindgen`std::panicking::panicking::hba52d83258fa66ec + 4 at panicking.rs:317
    rflags = 0x0000000000010202
        cs = 0x000000000000002b
        fs = 0x0000000000000000
        gs = 0x0000000000000000

Ok so the specific cause of this segfault is a misaligned value. The faulting instruction is movaps %xmm0, (%rax) which seems to require that the memory location has a 16-byte alignment, but the destination %rax does not (0x0100f04e58).
The return value of the previous indirect call to the __getit function this is returning the address of a #[thread_local] in memory which means I think this is basically a bog-standard misaligned TLS value on OSX. We've seen this in a number of locations unfortunately, and it looks like it was a bug in Xcode's linker from long ago (since been fixed).
In that sense it looks like upgrading fixed the issue for you which is indeed expected!

Ah, makes sense. That was very informative, thanks! Yes, I saw that one of your Travis CI tests hit the same OSX version as me but had a slightly newer XCode version (6.4 vs 6.2). So could be consistent with XCode being the culprit.

This seems potentially related to a thread_local issue that we are seeing on older OSX versions. We reproduce on travis's images for xcode6.4 and xcode7.3 (OSX 10.10 and 10.11, respectively): see the stack from https://github.com/pantsbuild/pants/pull/5803#issuecomment-389171758 (although ignore the forking diagnosis, as there is no forking happening in this case).

FWIW I'm seeing similar problems on OSX 10.9 w/ rust 1.27.

@inferiorhumanorgans can you try reinstalling wasm-bindgen-cli with:
$ MACOSX_DEPLOYMENT_TARGET=10.6 cargo install wasm-bindgen-cli

and see if that fixes the issue for you?


@OptionValues for enum typed options should be supported or error out

If you have an enum-typed @Option, always all values of the enum are considered valid arguments.
If an @OptionValues exist, it is simply ignored with Gradle 5.6.3.
Either - and I'd prefer this option - this should be supported, so that you can mark only a subset of the enum values as valid arguments for an option, or alternatively this should throw an error.

Still the same with 6.7.1


[XAML Controls Gallery(debug)->Media->AnimatedVisualPlayer] : Name of the button is not announced by narrator for Play button( 'Playback of a lottie animation').

Tags
Accessibility, A11yCT, A11yMAS, MAS4.2.1, A11yLowImpact, ScreenReader,
A11ySev3, XAMLControlsGallery, WinUI, Win32, Wipro
Test Environment
XAML Controls Gallery(debug) version - <IP_ADDRESS>
Win 32/ OS build- 21343.rs_Prerelease.210320-1757
Steps to reproduce the bug
Launch the XAML Controls Gallery (Debug) App
Go to the Media-> AnimatedVisualPlayer.
Hit on Tab key to traverse the "AnimatedVisualPlayer(Carousals)".
Navigate to play button under 'Playback of a lottie animation' and invoke it.
Listen the narrator announcement.
Actual behavior
When navigated to play button narrator is announcing simply as Button instead of announcing as Play button. After button is invoked then narrator is announcing as play button as recorded in the attachment.
Expected
All components need an accessible name, ideally using semantic elements and attributes. In rare cases, aria-label or aria-labelled by may be needed to alter the name. Learn more by reading about the accessible name property.
User Impact
When interactive elements have an incorrect name, it is difficult for people using assistive technology (like screen readers) to understand the purpose of control and its relationship to other content.
MAS Reference
MAS 4.2.1 – Object Information
Attachments
Play button name property is not announced.zip

@anawishnoff fixed this


Improve frame rate for live video

I have tried your demo with live video stream,but the delay is badly,I think I can't use this demo to process image in real time.
Although the video has 10 fps , I think the video is too stable to lead to the severe delay.
How should I do to let it be a little bit instability to improve real timing.

The level of stability of the input video has no effect on processing time; just the number of frames being processed.
To decrease the delay while processing a live video you can change the smoothing_window* parameter which has a default value of 30.  Lowering this number will lower the delay.  I will admit the speed of processing for live video is not great, but you can make the call if it's good enough for you use case after lowering this value.
*The smoothing_window parameter adjusts the window size for a moving average of the stabilizing transforms.  To do a moving average across 30 frames, the output needs to be delayed 30 frames.

OK, thank you anyway , I will have a try later ! @AdamSpannbauer

I have tried your method,changing the value of smoothing_window to 1 satisfies my needs.But the video only has 10 fps,before applying this method,it has 30 fps.

To clarify. Could you confirm if I understand the issue correctly?

Your input video is 10fps
You use vidstab to process it
The output video is 30fps
The desired output is 10fps

This is my code:
stabilizer = VidStab()
vidcap = cv2.VideoCapture(0)
start_time = timer()
while True:
grabbed_frame, frame = vidcap.read()
 if frame is not None:

    pass

 stabilized_frame = stabilizer.stabilize_frame(input_frame=frame,
                                               smoothing_window=1)
 curr_time = timer()
 fps = int(1/(curr_time-start_time))
 img = cv2.putText(stabilized_frame,str(fps),(20,30),cv2.FONT_HERSHEY_COMPLEX,1.2,(0,0,255),2)
 if stabilized_frame is None:
     # There are no more frames available to stabilize
     break

 # Perform any post-processing of stabilized frame here
 cv2.imshow('Test',stabilized_frame)
 start_time = timer()
 if cv2.waitKey(1) & 0xFF == ord('q'):
     break

If I only use cv2.VideoCapture,the rate of processing is 30fps.
If I add the VidStab,the rate of processing is 10fps.

Thank you for providing code. I’ll look into this and see if there’s a way to speed things up.

Please let me know if there are any issues with this new feature.  If I don't get back any feedback, I think I plan to merge the feature and release within about a week.
/remind me to check in on feedback in 1 week

I have not returned to my lab , so I have no issue.


[e2e]: container-based schedule main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/10713151408
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container-based.schedule.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container-based.schedule.main.default.slsa3.yml
Trigger: schedule
Branch: main
Date: Thu Sep  5 03:19:07 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/10731737994
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container-based.schedule.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container-based.schedule.main.default.slsa3.yml
Trigger: schedule
Branch: main
Date: Fri Sep  6 03:23:44 UTC 2024
Tests are passing now. Closing this issue.