Request for more baseline modes for mne.epoch's apply_baseline

Hi there,
Is it possible to implement more baseline mode methods for https://mne.tools/stable/generated/mne.Epochs.html#mne.Epochs.apply_baseline as with those available in https://mne.tools/stable/generated/mne.time_frequency.EpochsTFR.html#mne.time_frequency.EpochsTFR.apply_baseline ?

I am bit worried if we allow this unless we find a way to keep track of
what baseline method was used.
Currently epochs does not have a way to remember this.

I see. So the next closest available option would be the 'combine' option under viz.plot_compare_evokeds? Which only works for more than 1 sensor for non-mean modes?
https://mne.tools/dev/generated/mne.viz.plot_compare_evokeds.html#mne.viz.plot_compare_evokeds

can you clarify what you would like to obtain? doing the same as
evoked.plot but with z-score baseline for example?

Yes, z-score baseline. As I am also using z-score for TFR plotting, it would be nice to see the z-score equivalent activity for the epochs as well to get them as closely matched as possible.

the main reason why you want to use z-score on TFR is the 1/f power
spectral. If you don't do such things you pretty
much only see low frequencies. The situation  is very different for epochs
traces that don't suffer from this issue.


.lua scripts not loading

Describe your problem here.
i put an lua script in one of my songs and after a day it stopped working plz fix
function onCreate()
makeLuaText('watermark', songName .. " | Created By BalloonBoyXd", 0, 25, 500); -- You can edit the created by Prisma Text just dont change anything else
setTextSize('watermark', 20);
addLuaText('watermark');
end
plus
local allowCountdown = false
function onStartCountdown()
-- Block the first countdown and start a timer of 0.8 seconds to play the dialogue
if not allowCountdown and isStoryMode and not seenCutscene then
setProperty('inCutscene', true);
runTimer('startDialogue', 0.8);
allowCountdown = true;
return Function_Stop;
end
return Function_Continue;
end
function onTimerCompleted(tag, loops, loopsLeft)
if tag == 'startDialogue' then -- Timer completed, play dialogue
startDialogue('dialogue', 'breakfast');
end
end
-- Dialogue (When a dialogue is finished, it calls startCountdown again)
function onNextDialogue(count)
-- triggered when the next dialogue line starts, 'line' starts with 1
end
function onSkipDialogue(count)
-- triggered when you press Enter and skip a dialogue line that was still being typed, dialogue line starts with 1
end
local allowEndShit = false
function onEndSong()
if not allowEndShit and isStoryMode and not seenCutscene then
setProperty('inCutscene', true);
startDialogue('dialogue2', 'breakfast');
allowEndShit = true;
return Function_Stop;
end
return Function_Continue;
end
plus
function opponentNoteHit() -- Code for the opponent to drain your health when he sings
health = getProperty('health')
if getProperty('health') > 0.4 then -- This is the maximum that the enemy will drain your health, then do nothing.
setProperty('health', health- 0.017); -- How much health does the enemy drain from you, the more, the more health and the less, the less health
end
end
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build?

@Wither362 ?

Yeah?

Ok, ok, let me rewrite the code for better review

function onCreate()
	  makeLuaText('watermark', songName .. " | Created By BalloonBoyXd", 0, 25, 500); -- You can edit the created by Prisma Text just dont change anything else
	  setTextSize('watermark', 20);
	  addLuaText('watermark');
end
--plus
local allowCountdown = false
function onStartCountdown()
	 -- Block the first countdown and start a timer of 0.8 seconds to play the dialogue
	  if not allowCountdown and isStoryMode and not seenCutscene then
	  	  setProperty('inCutscene', true);
	  	  runTimer('startDialogue', 0.8);
	  	  allowCountdown = true;
	  	  return Function_Stop;
	  end
	  return Function_Continue;
end

function onTimerCompleted(tag, loops, loopsLeft)
	  if tag == 'startDialogue' then -- Timer completed, 	  	  	play dialogue
	  	  startDialogue('dialogue', 'breakfast');
	  end
end
--[[
-- Dialogue (When a dialogue is finished, it calls startCountdown again)
function onNextDialogue(count)
-- triggered when the next dialogue line starts, 'line' starts with 1
end

function onSkipDialogue(count)
-- triggered when you press Enter and skip a dialogue line that was still being typed, dialogue line starts with 1
end
]]--

local allowEndShit = false

function onEndSong()
	  if not allowEndShit and isStoryMode and not seenCutscene then
	  	  setProperty('inCutscene', true);
	  	  startDialogue('dialogue2', 'breakfast');
	  	  allowEndShit = true;
	  	  return Function_Stop;
	  end
	  return Function_Continue;
end
--plus
function opponentNoteHit() -- Code for the opponent to drain your health when he sings
	  health = getProperty('health')
	  if getProperty('health') > 0.4 then -- This is the maximum that the enemy will drain your health, then do nothing.
	  	  setProperty('health', health- 0.017); -- How much health does the enemy drain from you, the more, the more health and the less, the less health
	  end
end

Try using that code


Synchronous notifications

Provide an option to send notifications synchronously to endpoints. If enabled then any event generated as a result of processing a HTTP request is sent before the associated HTTP response is returned. If event sending fails the the HTTP request will also fail. This is useful if processing certain type of events are critical to functioning of the system. It is possible to lose events if there are many events pending in the memory queue and the registry instance crashes or restarts for some reason. This will also increase the latency of processing HTTP requests and hence should be used carefully for important events.

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "sync-notif" git@github.com:manishtomar/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353944800
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@dmcgowan I've updated logrus and a dependency package to use WithError.
@caervs I've addressed nit comments. I've also added note in the doc about partial failure.
LMK if you've questions.

Overall this looks good, 2 concerns about error handling though. The first is that the eventQueue is going to be logging an additional warning after the error log after this change for non-sync cases. The second is related to what gets sent back to the client. I think this should be obvious from the error sent back to the client, ideally typed. If the request should be retried then a 503 may also be a better response code.

I thought about this some more and realize that the failure scenario is not worth having this feature Closing. LMK if anyone has other opinions. Happy to talk through.


nm, ovs: Remove translate {port, bridge} options step

The OVS {port, bridge} options translation step has no added value at the moment and
can be dropped.
Depends on #761, #760

Coverage increased (+0.2%) to 66.161% when pulling 6c7b7c38bda5502e14130c644da0e6af7d519255 on EdDev:ovs-nm-remove-translate into 7b0f97dc461407e1565323e66e8d55f6e359ed2d on nmstate:master.

Coverage increased (+0.2%) to 66.161% when pulling 6c7b7c38bda5502e14130c644da0e6af7d519255 on EdDev:ovs-nm-remove-translate into 7b0f97dc461407e1565323e66e8d55f6e359ed2d on nmstate:master.


Measured templates disappearing for players

For the last week or so my players canvas goes completely blank when they go to place a measured template, all tokens disappear and they can’t see where they are placing it. No problems on GM side. Turing of 5e helpers stops this issue.

This may be related to #130 and is quite concerning. Any further reproduction details (number of players, template type, template scaling settings) are highly appreciated.
Extremely sorry for these oddities -- they are very surprising...

I may be on to something. I'm not getting the canvas issues, but the templates are disappearing. Going to elevate this and try to push out a fix.

Awesome thank you!

Does this happen with template scaling turned off? There is a dnd5e system bug that might be interfering.

Yes it happens regardless of that feature being on. I did notice the core bug when spinning templates so maybe that has something to do with it.

I am unable to reproduce this error. Can you please check with dnd5e 1.3.5, which contains the ability template preview fix to see if this still occurs. If so, detailed reproduction steps with no other modules enabled would be greatly appreciated. Leaving this issue open for now.

Closing this issue as it continues to be unconfirmed with no additional reports.


Can I initiate Flight App?

can I initiate \Flight::app? I know I can't, but is there any workaround to do that?

sorry I can. I have to initiate $app = new \flight\Engine() like this


CAN I USE  VideoView or any other video player instead  Exoplayer

I need to use video view as a player ...how can I initialize it ??? please

@thealpha Here is the demo that use the normal VideoView and MediaPlayer. It requires you to extend VideoView, but no big deal. Please take a look.

@eneim thanks ..but I am facing a new unknown problem I can't able to see video ..

@thealpha Please give more information. At least the video Uri, Toro version, Android version, Device name, Logcat stack.

@eneim  the demo code that u have shown as Class named  LegacyVideoViewHelper should I copy all the code ...??? ..Cause I am There is lot of errors LIKE OnErrorLIstner AND Lambda expression are not allowed  in language 1.7 ....PLEASE HELP

@thealpha Please answer my previous question first.
Also, in your build.gradle inside app module, put the following inside the android block
 compileOptions {
    sourceCompatibility JavaVersion.VERSION_1_8
    targetCompatibility JavaVersion.VERSION_1_8
  }

Sorry but I will close this issue if you cannot answer my question above.

No its was working before while I was using exoplayer...but I need to use video view instead ..please help

@thealpha This is the version of LegacyHelper that compatible to Java 7:
https://gist.github.com/eneim/b36c84fcd108eaf2361bd26cfb2c044e
If you want to copy paste the demo code of Legacy, you need to have your project compatible to Java 8 by adding the lines I comment above. Please google it yourself if it doesn't help yet, there is things you need to learn that my library has nothing to do with.

@eneim THANKS  ...U CAN CLOSE THIS ISSUE NOW..I NEED TO LEARN A LOT...THAT I KNOW ..I WILL BUILD MY OWN....

@thealpha I need the Video URL to test this. Please co-operate with my questions or else I cannot help you further: I need the video Uri, Toro version, Android version, Device name, Logcat stack.

Please Close this issue I am not using toro library now ..I am facing lot issue with this ...

its playing in video view ....BY the way its not issue of your library its the issue of exoplayer ..I saw u have some other video view libraries can exFLoppyVideoView can this support toro


Use built time as refresh default

this is depending on the last pull request. Please merge that first.

I think PR #244 is newer right? Closing.


Use theme.title instead of theme.variant in the theme switcher

Signed-off-by: Mike Cripps<EMAIL_ADDRESS>Hey, I just made a Pull Request!
We (@footballradar) are implementing our own theme and adding it to the list of themes in the app (retaining the existing light and dark themes). However, when we view the User Settings page, we are unable to determine which 'light' theme is ours (without hovering over the button).
The SidebarThemeSwitcher renders the theme title in the theme switcher, but the existing User Settings card renders the theme variant. As theme variant can only be one of light or dark (by the TS types) this doesn't seem to the appropriate value.
After this PR, the toggle buttons now look like this:

There is, I guess, an argument that you should only have two styles in your app, but this page seems to suggest that you can have as many as you like, and we want a way of testing changes to the theme without impacting the existing, working, light theme. If this is the case I'm happy to drop this PR (although I think keeping the theme switchers in sync is probably worthwhile anyway).
It's also not particularly clear what 'Auto' theme will do in the case where you have two light themes?
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hi! Thanks. All changes that affect deployed code need to have a changeset as well.


opendistro-for-elasticsearch-kibana version 1.13.3

Hello,
I was checking the documentation to update to version 1.13.3 and I found that the docker image is not uploaded for kibana:
https://hub.docker.com/r/amazon/opendistro-for-elasticsearch-kibana/tags
However in the documentation I could find that the version of Kibana is set to 1.13.3
https://opendistro.github.io/for-elasticsearch-docs/docs/install/docker/
docker pull amazon/opendistro-for-elasticsearch:1.13.3
docker pull amazon/opendistro-for-elasticsearch-kibana:1.13.3

Is this a problem in the documentation or maybe kibana version is not pushed to docker hub? Would it be possible to use elasticsearch 1.13.3 and kibana 1.13.2?
Regards.

@huertalv - yeah, there is no opendistro-for-elasticsearch-kibana:1.13.3. Looks like that change was made in error. Also see response on #511


rain: 1.4.0 -> 1.4.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/aws-cloudformation/rain/releases.
meta.description for rain is: A development workflow tool for working with AWS CloudFormation
meta.homepage for rain is: https://github.com/aws-cloudformation/rain
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.4.2 with grep in /nix/store/1al0pl4451h3b6l4ifc20nwc0968qhvj-rain-1.4.2
found 1.4.2 in filename of file in /nix/store/1al0pl4451h3b6l4ifc20nwc0968qhvj-rain-1.4.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
rain

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1al0pl4451h3b6l4ifc20nwc0968qhvj-rain-1.4.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A rain https://github.com/r-ryantm/nixpkgs/archive/3b2874a847c98ccfcb64bf943e61a8db468718f9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1al0pl4451h3b6l4ifc20nwc0968qhvj-rain-1.4.2
ls -la /nix/store/1al0pl4451h3b6l4ifc20nwc0968qhvj-rain-1.4.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

rain

Maintainer pings
cc @jiegec for testing.

Result of nixpkgs-review pr 238283 run on aarch64-darwin 1

1 package built:

rain


addition of computer generated reality dataset to torchvision

🚀 Feature

in the current scenario, all the datasets that torchvision has are of physical reality, there is no dataset of computer generated reality, I think a bit more priority needs to be given to computer generated reality dataset.
Motivation

computer generated reality resolution is doubling, so people spend more and more time in such realities, for example, game reality or watching animated movie.
so, we can predict that datasets of the future would be of these computer generated realities.
Pitch

atleast one such dataset should be added to torchvision.
I do not suggest any specific dataset, but I think there should be atleast one, and keep increasing number of computer generated reality datasets in the upcoming years.

In general, we only feature datasets (and models) that have established themselves as standard for their specific case and are widely used.
I'm not familiar with the datasets you are describing, which makes it hard to assess if its worth to add them. Please provide some links for such datasets and in the same breath citations for prominent papers of this field that use them.


Dark theme card/button issues

The way we apply custom variable changes to specific components in light/dark themes doesn't work when the component is nested in the other theme.
For example, the login component uses %pf-t-dark, then the main section uses %pf-t-light, but since we set custom variable changes for the pf-c-button component in %pf-t-dark, those changes are persisting when the button is used in %pf-t-light.
Exhibit A:

:tada: This issue has been resolved in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Question: Is the projects still running?

Just curious to understand if the project it still running and how I can contribute to it.

Seems not to be active anymore?

It’s on pause while we finish our SDK and Zombiechain. We will revisit it later this year

Hi there, Any updates? thanks


Improvement Improve performance of parquet reader filter calculation.

Proposed changes
Improve performance of parquet reader filter calculation.
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...


exception exit: noproc on OTP 21.0-rc1

I can't wait to use OTP 21.0 which is looking delicious bringing in a lot of long-awaited features. I tried Yaws (built on 20.3.2) with 21.0-rc1 with no luck. Run yaws:start_embedded(Dir) to immediately get a crash dump. Looks like yaws_log is having a hard time on OTP 21.0.
** When Server state == {state,undefined,[],true}
** Reason for termination ==
** {{noproc,
        {gen_server,call,
            [yaws_log,
             {setup,
                 {gconf,
                     "/Users/leo/sources/testapp/_build/default/lib/yaws",
                     false,612,".",
                     ["/Users/leo/sources/testapp/_build/default/lib/yaws/examples/ebin"],
                     [],[],30000,nolimit,400,1000000,8000,nolimit,[],10240,[],
                     10000000,30,
                     ["/Users/leo/sources/testapp/_build/default/lib/yaws/examples/include"],
                     "/usr/bin/php-cgi","Yaws 2.0.5","default",false,[],8,
                     undefined,
                     [inet],
                     yaws_session_server,undefined,120000,3600000,disable},
                 []},
             infinity]}},
    [{gen_server,call,3,[{file,"gen_server.erl"},{line,223}]},
     {yaws_server,init2,5,[{file,"yaws_server.erl"},{line,243}]},
     {yaws_server,handle_call,3,[{file,"yaws_server.erl"},{line,305}]},
     {gen_server,try_handle_call,4,[{file,"gen_server.erl"},{line,661}]},
     {gen_server,handle_msg,6,[{file,"gen_server.erl"},{line,690}]},
     {proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,249}]}]}

Currently working on this with rc2.

Fixed at commit ba31d14.


chore: check why badge is outdated

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nrwl/nx?version=dev:9bec5d8fbf0eb9748fb9117cd18ae47e881d90d0


⚠ ClamAV has degraded performance

In 3e42c8d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 116 ms

Resolved: ClamAV performance has improved in e1438e4 after 535 days, 15 hours, 30 minutes.


allow users to choose their own username

I know it's standard IndieWeb practice to have only one user on the domain, but that doesn't necessarily mean their name is "me", and it's misleading to return (for example) WebFinger data that claims it's for<EMAIL_ADDRESS>when that address doesn't exist.
For example, on my site, I've provided an email address in my representative h-card. When this is done, I think it would be appropriate for Bridgy Fed to use that email address to construct the acct: identifier for the user.

sure! understood.
a few thoughts:

OStatus/ActivityPub addresses only look like email addresses. they're not actually email addresses, nor do they interact with email at all, so technically it doesn't matter whether the corresponding email address exists.
the username in an OStatus/ActivityPub address is part of its identity, so if it ever changes, your identity on federated social networks will change, which will surprise other users, and maybe you too.
me is intended to imply that you're the site example.com itself, not just a single user on example.com, which another username might imply. (that also means that we'd need to figure something out for multi-user sites. ¯\_(ツ)_/¯)
on a related note, what should we do if your representative h-card's email address isn't on 00dani.me? we need an @00dani.me AP/OStatus address. should we still extract and use the username from the email address? unclear.
how should conflicts be resolved? e.g. if your representative h-card has u-email<EMAIL_ADDRESS>and p-nickname xyz (generally interpreted as preferred username), which should we choose?

having said all that, this still is reasonable, at least for email addresses on the same domain. i can definitely consider it.

Hmm, good points.

I did know that OStatus/AP subjects aren't necessarily email addresses - none of my six (!) Mastodon handles are email addresses for example - but sources like https://webfinger.net seem to assume they might be? That client expects you to enter an "Email or URL", and if given an email address it uses the acct: scheme to look it up. It might just be that https://webfinger.net is misleading though. :wink:
If the username changes under this suggestion, it'd be because your email address changed, which is already part of your identity, right? Although, if Bridgy Fed's behaviour changed, that'd change existing users' identities as perceived from the fediverse. Hmm.
Using<EMAIL_ADDRESS>to convey "I'm the site example.com" is really good actually. I'm starting to think I should set up<EMAIL_ADDRESS>at least as an alias. Still, that won't work for multi-user sites, which still need another solution.
The representative h-card's email address should only be taken as the username if it's on the same domain, I think. More specifically, I think it should work like this:
If your representative h-card has a u-email on the correct domain, use that. If it doesn't, use p-nickname. If it has neither, fall back on me@domain.

Thoughts?

thanks! good feedback.
another argument against me is that mastodon largely prioritizes username over domain when rendering remote users, just like local users, so you'll often see just me in toots, notifications, etc. not so useful. :/

@aaronpk out of curiosity, how would you ideally want to tell bridgy fed to use<EMAIL_ADDRESS>p-nickname in representative h-card, which wouldn't include domain? u-email, which is overloaded and would have false positives? other?

i'm tentatively changing the username from me to the source site's domain. we can still consider more sophisticated approaches like p-nickname etc, but this fixes an interop bug with mastodon and also improves username rendering there.

The site's domain is an excellent default and I think mostly mitigates this issue in a very appropriate way. Want a different username? use a different domain. E.g. if @aaronpk wants something like "aaronpk" as his user name, he can choose to use his aaronpk.com domain as the domain he federates from to Mastodon.
Given this point from @snarfed:

username in an OStatus/ActivityPub address is part of its identity, so if it ever changes, your identity on federated social networks will change, which will surprise other users, and maybe you too.

It may be the right answer to "wont fix" the rest of this issue, or rather, close as "fixed" by being domain@domain centric and pushing the "choose your username" question to "choose your domain", since frankly, it's about "choose your identity" (per the point above) more than "choose your username" and that's your domain on IndieWeb anyway.

domain@domain works for me. 👍

Ooh, wait, idea: the AP/OStatus identity could be customised on your h-card by adding a u-url property that uses the acct: protocol. False positives are unlikely, and the identifier that Bridgy Fed outputs would simply exactly match the appropriate u-url, if one's provided. Thoughts?

Alternatively, a specialised property could be devised, like u-bridgy-fed-acct, but I think matching the u-url values against acct: would be just as reliable.

+1 for hcard url (or rel=me ?) of acct: to set username

fyi all, @singpolyma's #27 implements this by looking for an acct: u-url in the representative h-card, as descibed earlier here, which seems pretty safe and likely to only be used by people who know what they're doing.
i'm still a bit reluctant, but i think it addresses all the main concerns, so i'm ok with merging it. feel free to weigh in if you disagree.

@singpolyma true! agreed, no user-visible impact of this right now afaik, but it could definitely use the acct: value too, or instead.

I know we can use u-url to change the fediverse username by setting it to<EMAIL_ADDRESS>and then presumably the fediverse ID would be<EMAIL_ADDRESS>but is it possible to have multiple "users" and so havr a fediverse user as<EMAIL_ADDRESS>and another as<EMAIL_ADDRESS>and so on.

@damianbrown no, sorry, and I don't expect that any time soon. That would require #491, which wouldn't be easy, since "one account per domain" for web sites is pretty baked into BF's current design.


fix/README.md

Remove leading snippet tabs
casing *
add link to execution policy

Thanks @leongross!


ARROW-3762: [C++] manage ChunkedArrayBuilder capacity explicitly

ChunkedArrayBuilder should never request BinaryBuilder reserve space for more strings than it can hold (kListMaximumElements); with this change it will instead of begin a new chunk

I'll add some tests to src/arrow/array-binary-test.cc

@pitrou @wesm This new test is pretty minimal but still takes ~4 minutes to pass on my machine

Hm. Can we make the 2GB limit something that's configurable rather than hard-coded? In theory that's the purpose of the max chunk size. We can't have such a long-running test in CI

max_chunk_size_ is a restriction on the character data (string_array.buffer[2]); the test I added appends 2 ** 31 empty strings so chunk_data_size_ never rises from 0.
We could certainly add another to apply to the # of strings in the string_array, or alternatively use max_chunk_size_ / sizeof(int32_t) as that limit

Oh okay, sorry for my confusion. Can we make the number of elements per chunk configurable, then? I can see a use case for having no more than 64K elements per chunk, no matter what their size. Then this is much easier to test

Will do

Merging, the failure is the cloud.r-project.org DNS issue


[MariaDB] Error on generatechangelog due to sequence error

Environment
Liquibase Version: 3.8.9
Liquibase Integration & Version: CLI
Liquibase Extension(s) & Version: none
Database Vendor & Version: MariaDB Skysql
Operating System Type & Version: N/A
Description
C:\dev\skysql>liquibase generatechangelog
Liquibase Community 3.8.9 by Datical
Unexpected error running Liquibase: liquibase.exception.UnexpectedLiquibaseException: Don't know how to query for sequences on <username> @ jdbc:mariadb://<domain>:<port>/mysql?useSSL=true&serverSslCert=/<path>/skysql_chain.pem (Default Schema: mysql)
For more information, please use the --logLevel flag

Steps To Reproduce

Create account at https://cloud.mariadb.com/skysql
Create a Skysql database.
Get the connection information and run snapshot or generatechangelog.

Actual Behavior
See above.
Expected/Desired Behavior
Generates a changelog.
Additional Context
note the two params at the end of the url: useSSL and serverSslCert. You'll need those to connect...
Workaround
This error can be avoided by excluding any sequences when running any diff commands, for example:
liquibase --diffTypes=catalog,tables,functions,views,columns,indexes,foreignkeys,primarykeys,uniqueconstraints,storedprocedure,triggers --changeLogFile=newChangeLog.xml generateChangeLog
┆Issue is synchronized with this Jira Bug by Unito
┆Fix Versions: Liquibase 3.10.2

Same problem over here I think, as far as I know the problem did not occur on an older MariaDB version (10.1.24) but occurs on 10.4.12
Caused by: liquibase.exception.UnexpectedLiquibaseException: Don't know how to query for sequences on xxx @ jdbc:mariadb://url:3306?autoReconnect=true (Default Schema: xxx)
    at liquibase.snapshot.jvm.SequenceSnapshotGenerator.getSelectSequenceSql(SequenceSnapshotGenerator.java:247)
    at liquibase.snapshot.jvm.SequenceSnapshotGenerator.addTo(SequenceSnapshotGenerator.java:43)
    at liquibase.snapshot.jvm.JdbcSnapshotGenerator.snapshot(JdbcSnapshotGenerator.java:79)
    at liquibase.snapshot.SnapshotGeneratorChain.snapshot(SnapshotGeneratorChain.java:49)
    at liquibase.snapshot.DatabaseSnapshot.include(DatabaseSnapshot.java:316)
    at liquibase.snapshot.DatabaseSnapshot.replaceObject(DatabaseSnapshot.java:417)
    at liquibase.snapshot.DatabaseSnapshot.includeNestedObjects(DatabaseSnapshot.java:365)
    at liquibase.snapshot.DatabaseSnapshot.include(DatabaseSnapshot.java:339)
    at liquibase.snapshot.DatabaseSnapshot.init(DatabaseSnapshot.java:107)
    at liquibase.snapshot.DatabaseSnapshot.<init>(DatabaseSnapshot.java:60)
    at liquibase.snapshot.JdbcDatabaseSnapshot.<init>(JdbcDatabaseSnapshot.java:39)
    at liquibase.snapshot.SnapshotGeneratorFactory.createSnapshot(SnapshotGeneratorFactory.java:217)
    at liquibase.snapshot.SnapshotGeneratorFactory.createSnapshot(SnapshotGeneratorFactory.java:246)
    at liquibase.snapshot.SnapshotGeneratorFactory.createSnapshot(SnapshotGeneratorFactory.java:230)
    at liquibase.lockservice.StandardLockService.destroy(StandardLockService.java:446)
    at liquibase.command.core.DropAllCommand.run(DropAllCommand.java:96)
    at liquibase.command.AbstractCommand.execute(AbstractCommand.java:19)

Hi @r2datical .  Thanks for taking the time to write this up and the detailed reproduction steps with the workaround.  We will add this to our issues list to consider.

Bug also occurs with MariaDB 10.5.3

It should be the same effort for both. We just have to find the query for pulling sequence information from the database. Any mariadb versions of at least 10.3 will support sequences.


[Feature request] improve performance handling iterm2 image protocol in --preview

Checklist

[X] I have read through the manual page (man fzf)
[X] I have searched through the existing issues
[x] For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version
0.55.0 (v0.55.0)
OS

[X] Linux
[ ] macOS
[ ] Windows
[ ] Etc.

Shell

[X] bash
[ ] zsh
[X] fish

Problem / Steps to reproduce
I noticed that fzf preview takes quite a long time when showing big images with iterm protocol. This gets annoying when browsing filesystem. My measurements has shown that without fzf rendering takes around 25ms and with fzf it gets up to 400ms.
measurement with fzf
# to make sure chafa is not the issue
chafa -f iterm --view-size 91x44 a.png > a.chafa
# fzf preview loads ~400ms
echo foo bar | fzf --preview '/bin/cat a.chafa'

https://github.com/user-attachments/assets/0897dc27-7348-4e82-ae46-7e5cb13806a6
fzf opened at 11th frame 0.7333s till preview rendered at 18th frame 1.20s -> 0.4666s
baseline measurement
❯ hyperfine '/bin/cat a.chafa' --show-output
...
  Time (mean ± σ):      25.2 ms ±   1.0 ms    [User: 0.4 ms, System: 10.0 ms]
  Range (min … max):    22.5 ms …  27.9 ms    129 runs

image used
![a](https://github.com/user-attachments/assets/c3a81edd-476d-4b6a-93ac-cb95045eecf7)

Since without fzf the rendering takes much less time, it seems like fzf has quite a lot of overhead somewhere. It would be great to optimize it

3b0c86e should fix it. Please test it.

3b0c86e should fix it. Please test it.

Works, thank you!


[firebase_dynamic_links] queryParameters added to generated ShortDynamicLink are not received in FirebaseDynamicLinks.instance.onLink callback

Future createDynamicLink(String shareId) async {
final DynamicLinkParameters parameters = DynamicLinkParameters(
uriPrefix: '',
link: Uri.parse(''),
androidParameters: AndroidParameters(
packageName: '',
minimumVersion: 0,
),
dynamicLinkParametersOptions: DynamicLinkParametersOptions(
shortDynamicLinkPathLength: ShortDynamicLinkPathLength.short,
),
);
final ShortDynamicLink shortLink = await parameters.buildShortLink();
Uri    url = shortLink.shortUrl;
url = Uri.https(url.authority, url.path, {shareIdLabelInDynamicLink: shareId});
return url.toString();
}
Else where when the link is clicked and app gets launched, sharedListId below is not populated.
FirebaseDynamicLinks.instance.onLink(onSuccess: (PendingDynamicLinkData dynamicLink) async {
  final Uri deepLink = dynamicLink?.link;
  print("Received a new dynamic link request in running app : " + deepLink.toString());

  if (deepLink != null) {
    String sharedListId = deepLink.queryParameters[shareIdLabelInDynamicLink];
    linkToNewSharedList(sharedListId);
  }
}, onError: (OnLinkErrorException e) async {
  print('onLinkError');
  print(e.message);
});

I'm going to try to check this this week.

I've checked on iOS and Android and I was able to retrieve the whole link with query params included.
Can you try to build the dynamic link via Firebase console to verify it is not a problem on the creation process?

Hi,
This is happening when a parameters is added to the ShortLinkURL, AFTER it has been generated.
Aka
a) Generate/Create a ShortDynamicLink.trasform it to a URI.
b) Take that URI and add some additional parameters. In my case it was going to be a more secure list id.
c) On receivers phone, when a user clicks on this "updated" URI ..the app gets launched, BUT these additional fields are not there, though no reason for them to be passed along.

@simpleapps4goodlife
Why are you adding the query params to the short link generated? I think that is not the way to go, you should pass the query params to the link before the short link is generated so Firebase returns those params in the URL resolved.
You have two ways to generate dynamic links:

Short link
Long links: https://firebase.google.com/docs/dynamic-links/create-manually

in both cases you can add query params to the link, in long links you have to URL encode the link in the link query param.
I think this is not a bug, we could add the original link the user clicks to PendingDynamicLinkData structure as a feature request, but I do not see any use case in which this is needed so I think we should not make the effort.

Thanks for quick response.
Here is the context:
I needed to make the link secure. I had a shared secret token which in short link was turning into 5-6 character token and was worried about it being hacked.
After creating this bug I found out about this attribute and started using that.
dynamicLinkParametersOptions: DynamicLinkParametersOptions(
shortDynamicLinkPathLength: ShortDynamicLinkPathLength.unguessable,
),
However I was still not sure if it was secure enough. As the new token though longer was around 17 characters (128 bit +  1 byte checksum?) so, I left the bug/feature request open in hope of being able to add additional longer token at end to be, doubly sure.
https://*.page.link/thPML8T8T9wqOers7
I will depend on your judgement about if it is secure enough to mark this issue close.
Thanks.

@simpleapps4goodlife
Hi, I understand your need to add some kind of security to your application, but I think the layer to do so is not in the link generation which is not secure enough, I think the way to go is once you have the dynamic link handled, combine the work in the app and server side to guarantee the user which is going to use the dynamic link can do the action the dynamic link represents.
I think you are trying to add security in a layer which is pretty issue to skip.
What do you think?

Yes.
The dynamics of the app would not allow for the mechanics of doing extra check in the app on receiving end.
 Passing of link among them via messaging or email is the only way to permission the sharing of resource between them.
The issue is not a show stopper after I transitioned to "ShortDynamicLinkPathLength.unguessable". I also added extra time checks for validity of shared URL, so am more ok with what I have right now.
There could be alternate solution like adding few more bytes to the link generated to make it crypotgraphically secure. Will leave it to your discretion to close it.

Ok, I know understand your use case, I've added an attribute to PendingDynamicLinkData sourceLink with the URL the user clicked which launched the event.
Try this
  firebase_dynamic_links:
    git:
      url: https://github.com/mrmilu/flutterfire.git
      path: packages/firebase_dynamic_links
      ref: firebase_dynamic_links-0.5.0+5

Hello @jherencia @simpleapps4goodlife
I am facing the similar issue for passing and fetching query parameters for firebase dynamic links. Can you please answer me at stackoverflow question

Any help would be useful.
Thanks.

@JayM96 I would like to not spread the information in two channels: stackoverflow and here.
I'd be happy to help if you bring the communication here.

@jherencia I have opened an issue in the same package here. You can answer [Here] (https://github.com/FirebaseExtended/flutterfire/issues/1289)

I'm going to close this as it is two major versions removed from latest, and the issue creator no longer exists.


--is-encrypted, and probably --encrypted, are problematic: the example file I am aware of

Consider https://download.brother.com/welcome/doc100417/cv_mfc880dw_uke_oug.pdf .
$ qpdf --is-encrypted cv_mfc880dw_uke_oug.pdf  # 0 exit status
$ qpdf --encrypt 123 123 256 -- cv_mfc880dw_uke_oug.pdf encrypted_cv_mfc880dw_uke_oug.pdf  # 0 exit status
$ qpdf --is-encrypted encrypted_cv_mfc880dw_uke_oug.pdf  # 0 exit status

encrypted_cv_mfc880dw_uke_oug.pdf is encrypted in the sense that I am asked for a password when opening it. I don't know if it is actually encrypted.
$ file cv_mfc880dw_uke_oug.pdf
cv_mfc880dw_uke_oug.pdf: PDF document, version 1.6
$ file encrypted_cv_mfc880dw_uke_oug.pdf
encrypted_cv_mfc880dw_uke_oug.pdf: PDF document, version 1.7, 1 pages

After opening it, encrypted_cv_mfc880dw_uke_oug.pdf has much more then 1 page. Skimming it, it looks like the expected content.
$ qpdf --version                                  ~
qpdf version 10.5.0
Run qpdf --copyright to see copyright and license information.

I haven't tried other documents from brother.com. http://support.brother.com/g/b/manuallist.aspx?c=as_ot&lang=en&prod=mfcj480dw_us_eu_as&flang=English&type3=10103&type2=5 -> Click to choose -> English, upper line, states the release date (version) of the file I tested is 03/06/2015 (0).

This appears to be operating as designed. What are you trying to achieve, and what are you expecting?

$  qpdf --help | grep -A1 ^--is-encrypted
--is-encrypted          silently exit 0 if the file is encrypted or 2
                        if not; useful for shell scripts

I downloaded https://download.brother.com/welcome/doc100417/cv_mfc880dw_uke_oug.pdf. If it is not encrypted, why do I get a 0 exit code when using --is-encrypted? If it is encrypted, why am I not asked for a password? And what is its password?

Password-protection is not the same as encryption. You can have an encrypted file without a password. In brief, a PDF file has a user password and an owner password. With a conforming reader such as Acrobat Reader, you need the owner password to bypass or modify security restrictions on the file, and you need the user password to open the file subject to its limitations. It's common to apply restrictions to a file, such as disallowing printing or text extraction, without requiring a password by creating a file with an empty user password and a non-empty owner password. When you see a file that is encrypted but doesn't require a password, this is what is happening.
For a technical explanation, I refer you to https://qpdf.readthedocs.io/en/stable/encryption.html which I actually just put up a few days ago.

As explained above. I misunderstood what is behind --is-encrypted.


C++ SDK

This is the tracking issue for our initial high-level C++ SDK
Goals

High-level API
Easy to use
Easy to install
For developers on their own machines

Non-goals

C
Embedded machines
Header-only

We will save this for later.
Approach
Low-level C SDK
We wrap our Rust SDK with a minimal set of functions for:

init
connect, save
log a DataRow

The Rust side is responsible for:

Batching
TCP communication
Streaming logs to disk

Low-level C++ SDK
Basically a C++-friendly wrapper around the C SDK
Code-generated classes

https://github.com/rerun-io/rerun/issues/2647

We use re_types (#2241) to generate classes for datatypes, components, and archetypes.
These are converted to Arrow-messages using the official Arrow C++ SDK.
Integrations
Finally, we have opt-in integrations with various libraries such as:

OpenCV
Eigen
…

Distribution
The C SDK will consist of a single rerun.h header, and then a dynamic and/or static library of the rerun_c crate.
The C++ SDK will have a CMakelists.txt for ease of use in cmake build systems. We can maybe set up a system where cmake downloads and install the Rerun C++ SDK for users, including dependencies (Arrow).
TODO

[ ] https://github.com/rerun-io/rerun/issues/2647
[ ] https://github.com/rerun-io/rerun/issues/2662
[ ] #2797
[ ] #2798
What C++ version to target

The Arrow C++ SDK requires C++17, but that should only affect the version for building our C++ SDK binaries

Figure out the API
Generate API docs
Write high-level C++ docs
Write C++ examples
Library distribution
…

Discussed today in the standup the many perils of shipping C++ binaries. Since we depend on Arrow C++ SDK right now, any source distribution would enforce C++17. We came up with various solutions (use Arrow C library, build out C SDK and forward to that, isolate Arrow code behind a C interface, etc. etc.) but concluded that this is very low priority for us right now: It seems that all known early adopters are (while reportedly not using C++17) are on compiler versions that supports C++17. So as long as our interface isn't C++17 requiring, our implementations can despite shipping as source.


RunDistributedTests task issue with TestAdaptersPath

Hi,
In the documentation of this task, it indicates that "The task automatically searches for "packages" directory that exists in the same folder as the .sln file (nuget restored directory structure)" but there is not nuget restore on the machine where the distributed tests are run. You must explicity set up the TestAdaptersPath with a runsettings file and copy the TestAdapters dll on the machine.
Can you add a field to set the TestAdaptersPath and avoid the use of a runsettings file please ?

Thanks for pointing out the documentation bug. We will fix it.
I have added the feature request to our backlog.
Atin.


Dselans/improve jetstream

Added pull consumer support for reading nats-jetstream requested in #289 .
I've added a few new flags for plumber read nats-jetstream:
      --consumer-name=STRING              Consumer name (default: random consumer name; has no effect if
                                          create_durable_consumer or existing_durable_consumer is not set)
                                          ($PLUMBER_RELAY_NATS_JETSTREAM_CONSUMER_NAME)
      --create-durable-consumer           Create a new durable consumer (default: use ephemeral consumer)
                                          ($PLUMBER_RELAY_NATS_JETSTREAM_CREATE_DURABLE_CONSUMER)
      --existing-durable-consumer         Use an existing durable consumer (default: use ephemeral consumer)
                                          ($PLUMBER_RELAY_NATS_JETSTREAM_EXISTING_DURABLE_CONSUMER)
      --keep-consumer                     Do not delete consumer after operation is done (default: delete on exit)
                                          ($PLUMBER_RELAY_NATS_JETSTREAM_KEEP_CONSUMER)
      --consumer-start-sequence=INT-64    Where to start read in stream (default: from start)
                                          ($PLUMBER_RELAY_NATS_JETSTREAM_CONSUMER_START_SEQUENCE)
      --consumer-start-time=STRING        At what time to start stream (RFC3339 format, Ex: 2016-06-20T12:41:45.14Z)
                                          ($PLUMBER_RELAY_NATS_JETSTREAM_CONSUMER_START_TIME)
      --consumer-filter-subject=STRING    Only receive a subset of messages from the Stream based on the subject
                                          ($PLUMBER_RELAY_NATS_JETSTREAM_CONSUMER_FILTER_SUBJECT)

By default, plumber will use an ephemeral consumer (which does not track stream sequence bits). To track sequence numbers/offsets, use create-durable-consumer or create one by hand and specify it via existing-durable-consumer and consumer-name.
NOTE: If you specify consumer-start-sequence - this applies to the consumer config so once the consumer consumes from sequence XYZ, a follow-up consume won't produce the same results. If you want to always consume from a given position - do create-durable-consumer every time.
I've updated the env and example docs with nats-jetstream info.

I'll clean this up a little so codeclimate doesn't yell at me.

On second thought - pass. Will do this another time :)


GIT and Missing tree / MissingObjectException

Running the Spring Cloud Config server it sometimes gives an exception and display the error page. We reboot the server to make it recover, but as we get it in production it would be nice to find the reason. It's valid calls that fails, rebooting will make the calls respond with correct config data.
2016-10-08 21:35:30.083 ERROR 7128 --- [nio-8080-exec-7] o.a.c.c.C.[.[.[/].[dispatcherServlet]    : Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is java.lang.IllegalStateException: Cannot load environment] with root cause

org.eclipse.jgit.errors.MissingObjectException: Missing tree b0fb112b1cc6e7e490bf049e1c037ab1b8d9bcb3
    at org.eclipse.jgit.internal.storage.file.WindowCursor.open(WindowCursor.java:149) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar!/:<IP_ADDRESS>412180710-r]
    at org.eclipse.jgit.treewalk.CanonicalTreeParser.reset(CanonicalTreeParser.java:202) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar!/:<IP_ADDRESS>412180710-r]
    at org.eclipse.jgit.treewalk.CanonicalTreeParser.createSubtreeIterator0(CanonicalTreeParser.java:236) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar!/:<IP_ADDRESS>412180710-r]
    at org.eclipse.jgit.treewalk.CanonicalTreeParser.createSubtreeIterator(CanonicalTreeParser.java:214) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar!/:<IP_ADDRESS>412180710-r]
    at org.eclipse.jgit.treewalk.CanonicalTreeParser.createSubtreeIterator(CanonicalTreeParser.java:60) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar!/:<IP_ADDRESS>412180710-r]
    at org.eclipse.jgit.treewalk.TreeWalk.enterSubtree(TreeWalk.java:912) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar!/:<IP_ADDRESS>412180710-r]
    at org.eclipse.jgit.dircache.DirCacheCheckout.preScanTwoTrees(DirCacheCheckout.java:259) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar!/:<IP_ADDRESS>412180710-r]
    at org.eclipse.jgit.dircache.DirCacheCheckout.doCheckout(DirCacheCheckout.java:410) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar!/:<IP_ADDRESS>412180710-r]
    at org.eclipse.jgit.dircache.DirCacheCheckout.checkout(DirCacheCheckout.java:397) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar!/:<IP_ADDRESS>412180710-r]
    at org.eclipse.jgit.api.CheckoutCommand.call(CheckoutCommand.java:261) ~[org.eclipse.jgit-<IP_ADDRESS>412180710-r.jar!/:<IP_ADDRESS>412180710-r]
    at org.springframework.cloud.config.server.environment.JGitEnvironmentRepository.checkout(JGitEnvironmentRepository.java:204) ~[spring-cloud-config-server-1.1.3.RELEASE.jar!/:1.1.3.RELEASE]
    at org.springframework.cloud.config.server.environment.JGitEnvironmentRepository.refresh(JGitEnvironmentRepository.java:148) ~[spring-cloud-config-server-1.1.3.RELEASE.jar!/:1.1.3.RELEASE]
    at org.springframework.cloud.config.server.environment.JGitEnvironmentRepository.getLocations(JGitEnvironmentRepository.java:121) ~[spring-cloud-config-server-1.1.3.RELEASE.jar!/:1.1.3.RELEASE]
    at org.springframework.cloud.config.server.environment.MultipleJGitEnvironmentRepository.getLocations(MultipleJGitEnvironmentRepository.java:111) ~[spring-cloud-config-server-1.1.3.RELEASE.jar!/:1.1.3.RELEASE]
    at org.springframework.cloud.config.server.environment.AbstractScmEnvironmentRepository.findOne(AbstractScmEnvironmentRepository.java:40) ~[spring-cloud-config-server-1.1.3.RELEASE.jar!/:1.1.3.RELEASE]
    at org.springframework.cloud.config.server.environment.MultipleJGitEnvironmentRepository.findOne(MultipleJGitEnvironmentRepository.java:146) ~[spring-cloud-config-server-1.1.3.RELEASE.jar!/:1.1.3.RELEASE]
    at org.springframework.cloud.config.server.environment.EnvironmentEncryptorEnvironmentRepository.findOne(EnvironmentEncryptorEnvironmentRepository.java:53) ~[spring-cloud-config-server-1.1.3.RELEASE.jar!/:1.1.3.RELEASE]
    at org.springframework.cloud.config.server.environment.EnvironmentController.labelled(EnvironmentController.java:112) ~[spring-cloud-config-server-1.1.3.RELEASE.jar!/:1.1.3.RELEASE]
.
.
.

What version are you using? Googling leads me to this https://www.eclipse.org/forums/index.php/t/205022/

We are using the 1.1.3.RELEASE, but it also happened with 1.1.2.RELEASE... Note that there was no changes to the repository, so it's not a matter of merging as in the Eclipse issue. We do frequently fetch different branches/labels from our systems tho, maybe some kind of hint? The repository is placed at GitLab, but I don't see that as an issue.

You're using the same org.eclipse.jgit version, <IP_ADDRESS>412180710-r, on both 1.1.3.RELEASE and 1.2.0.RELEASE... I think there is a chance that we might see the problem in the newest release too.

Just a following up... I updated to 1.2, but the problem continued... Finally set up a loadbalanced setup in AWS with two nodes, each in different availability zone, made the problem happen less often and are now very rare. Second, if errors and health check fails, the instance is replaced by automatic. My guess is, that two requests to the cloud config server on different labels/branches, on the "same" time, could corrupt the local git checkout.

I have a similar issue. But I'm not sure whether it's the same.
In my case, I use a git as a backend and a commit number as a label.
When Spring Cloud Config server is running and new commit is created, that exception occurs.
If I make a request with the commit number to get a config data, it fails calling JGitEnvironmentRepository#checkout.
As I guess, it wants to checkout to "label" but it can't find the label.
That's because new commit is not fetched or pulled yet from remote that time.
We tried to fetch new commit from remote before calling JGitEnvironmentRepository#refresh and it worked. But I'm curious about this solution. Is the "detour" right to solve that issue?

Try upgrading to 1.2.2 as this was hopefully fixed by #538.

@rlynch It works for me :-) Thanks!


Remove flakeheaven and use plain flake8

Looks like flakeheaven pre-commit is a mess and only works sometimes without clear behavior

Looks like with flake8 I still have the same issues with pre-commit not picking the correct configuration and not failing. So, for now, I switched to use the local version of flakeheaven in 4b14188 and so far it kind of works. Still needs more investigation and select a sensible set of rules!


Add v2 server config support with plugin URIs

Closes #3210
Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

Windows: invalid plugin key URI "linux"
failed to dial "\\\\.\\pipe\\containerd-containerd-test": context deadline exceeded: containerd: invalid plugin key URI "linux"
exit status 1
FAIL	github.com/containerd/containerd	10.168s

I think the config used during the CRI testsuite probably needs some update--we don't have the logs, but given the output on every CRI test that it can't get to the containerd socket, I assume containerd didn't start because of some mismatch with the new scheme/config?

Codecov Report

Merging #3322 into master will decrease coverage by 4.65%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3322      +/-   ##
==========================================
- Coverage   44.86%   40.21%   -4.66%
==========================================
  Files         113       76      -37
  Lines       12338    10276    -2062
==========================================
- Hits         5535     4132    -1403
+ Misses       5953     5566     -387
+ Partials      850      578     -272

Flag
Coverage Δ

#linux
?

#windows
40.21% <0%> (-0.05%)
:arrow_down:

Impacted Files
Coverage Δ

services/server/server.go
1.23% <0%> (-0.04%)
:arrow_down:

snapshots/native/native.go
1.79% <0%> (-41.26%)
:arrow_down:

archive/tar.go
16.99% <0%> (-26.8%)
:arrow_down:

metadata/snapshot.go
21.53% <0%> (-24.28%)
:arrow_down:

cio/io.go
1.52% <0%> (-21.38%)
:arrow_down:

content/local/writer.go
57.69% <0%> (-0.97%)
:arrow_down:

gc/scheduler/scheduler.go
66.34% <0%> (-0.97%)
:arrow_down:

oci/spec_opts.go
30.33% <0%> (-0.25%)
:arrow_down:

content/local/store.go
49.51% <0%> (-0.02%)
:arrow_down:

mount/temp_unix.go

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f4bb9...9547d26. Read the comment docs.

This is good to review now.  I fixed the issues with the default config for the tests.

This is still a breaking change. Containerd won't start with old configurations. One good thing is that users can just add a version = 1 in the config to make it work.
We should emphasize this change in the 1.3 release note.


Create upload endpoint

Pull Request
Description
Creates an upload endpoint with (uploadthing)[https://uploadthing.com/] for profile pictures
Adds uploadFiles utility that ProfileEditor uses during handleSubmit to update profile details.
Notes:

uploadthings added as a dependency, yarn install required
No authentication, will add in after integration
File verification done by uploadthing, might be sufficient

Related Issue(s)

Screenshots (if applicable)

Checklist

[X] I have checked that the changes included in the PR are intended to merge to master or any destination branch.
[X] I have verified that the new changes do not break any existing functionalities, unless the new changes are intended and have approved by the team.
[X] I will take care of the merging and delete the side-branch after the PR is merged.

Additional Notes/References

I have tested the upload image function, and it is working. However, I think you need to wait until @hhchinh2002 completed his user service integration, and you also want to polish the upload modal, can consider using the FileUpload component that I created, and also set and check the expected file types, and ensure the file image is less than, said 5MB.

And another thing is the current branch is actually not working due to merge conflict and the database schema structure is accidentally changed by someone... Hence when you debug, please only run the user service and frontend. I will fix the problems when the user service integration is done.

Tested uploading a profile pic, the upload is functioning correctly, but perhaps you forgot to update the SideBar to also include the new avatar update.

Tested uploading a profile pic, the upload is functioning correctly, but perhaps you forgot to update the SideBar to also include the new avatar update.

actually yall can merge this first and I'll update the sidebar to update user new avatar later in my PR

actually yall can merge this first and I'll update the sidebar to update user new avatar later in my PR

Ermm sure, @WillCWX can you pull from master and resolve the merge conflicts before merging the PR :)

actually yall can merge this first and I'll update the sidebar to update user new avatar later in my PR

Ermm sure, @WillCWX can you pull from master and resolve the merge conflicts before merging the PR :)

done, need approval, thanks


A bug in the latest version of keras: bias is not updated

Hi guys, I have some problems with the latest version of keras. This is a simple autoencoder code:
import numpy as np
from keras.models import Sequential
from keras.layers.core import Dense, Activation, AutoEncoder
from keras.optimizers import SGD
from keras.layers import containers
train_feature = np.zeros((1,4))
for i in range(1):
train_feature[i,] = [0.5, 0.3, 0.2, 0.1]
model = Sequential()
encoder = containers.Sequential([Dense(4,2,activation='tanh')])
decoder = containers.Sequential([Dense(2,4,activation='tanh')])
autoencoder = AutoEncoder(encoder=encoder,decoder=decoder)
model.add(autoencoder)
sgd = SGD(lr = 1)
model.compile(loss='mse', optimizer=sgd)
weights_org = model.get_weights()
model.fit(train_feature, train_feature, nb_epoch=1, batch_size=1, shuffle=False)
weights_now = model.get_weights()
print "Weights and bias before trainning is"
print weights_org
print "Weights and bias after trainning is"
print weights_now
If I use the past version, the result is fine, which looks like:
Epoch 0
1/1 [==============================] - 0s - loss: 0.1271
Weights and bias before trainning is
[array([[-0.92038186,  0.05200247],
[ 0.46043892, -0.82942702],
[-0.57505271, -0.25431725],
[ 0.03477517, -0.10212894]]), array([ 0.,  0.]), array([[-0.16022001, -0.06501606, -0.68613223,  0.96541306],
[ 0.15240795, -0.41876942,  0.50621491,  0.11618159]]), array([ 0.,  0.,  0.,  0.])]
Weights and bias after trainning is
[array([[-0.86223659,  0.07199206],
[ 0.49532608, -0.81743327],
[-0.5517946 , -0.24632141],
[ 0.04640422, -0.09813102]]), array([ 0.11629053,  0.03997918]), array([[-0.25749549, -0.09675063, -0.69828947,  0.87946589],
[ 0.08653298, -0.44026008,  0.49798202,  0.05797814]]), array([ 0.23823399,  0.07772003,  0.02977387,  0.21049024])]
However, if I use the latest version of keras, then the result will be:
Epoch 0
1/1 [==============================] - 0s - loss: 0.0328
Weights and bias before trainning is
[array([[ 0.99807841, -0.0321337 ],
[-0.34120891,  0.31954411],
[ 0.61708271,  0.51410343],
[-0.68198998,  0.58714997]]), array([ 0.,  0.]), array([[ 0.69201076,  0.3782278 ,  0.95140293,  0.22793627],
[ 0.16048078,  0.68251729,  0.26576419, -0.86654349]]), array([ 0.,  0.,  0.,  0.])]
Weights and bias after trainning is
[array([[ 0.99807841, -0.0321337 ],
[-0.34120891,  0.31954411],
[ 0.61708271,  0.51410343],
[-0.68198998,  0.58714997]]), array([ 0.,  0.]), array([[ 0.69201076,  0.3782278 ,  0.95140293,  0.22793627],
[ 0.16048078,  0.68251729,  0.26576419, -0.86654349]]), array([ 0.,  0.,  0.,  0.])]
Basically, the bias of the neural network is not updating. Could someone help to fix it?

Same thing happens with check_autoencoder.py for instance
...
Training Classical AutoEncoder
...
Epoch 0
5000/5000 [==============================] - 0s - loss: 0.2017
Epoch 1
5000/5000 [==============================] - 0s - loss: 0.2017
Epoch 2
5000/5000 [==============================] - 0s - loss: 0.2017
...

I think the problem has to do with the following:
Commit "Incorporate regularization into loss function" f04fdec9e61eabe9750af00f56c18bdde8972045 changed

Dense's regularizers list will only contain non-None regularizers pass in the initializer, ie. by default the regularizers list is empty.
Layer's get_params() just returns the regularizers list, instead of doing some logic which ensures there's a (identity) regularizer for each parameter.

Then commit "Remove weight tying in autoencoder" 94c930e99e8908d2188213672bed050b54ebdb5a changed AutoEncoder's initializer like
-            self.params += layer.params
-            if hasattr(layer, 'regularizers'):
-                self.regularizers += layer.regularizers
-            if hasattr(layer, 'constraints'):
-                self.constraints += layer.constraints
+            params, regularizers, constraints = layer.get_params()
+            self.constraints += constraints
+            for p, r in zip(params, regularizers):
+                if p not in self.params:
+                    self.params.append(p)
+                    self.regularizers.append(r)

which does a zip(params, regularizers) between two lists which now can have different lengths.
In the case of the default Dense encoder/decoder (i.e. with no regularizers), this means the parameter list will be empty and nothing will be updated during training.
See also #455.

Seemed like an issue indeed. I fixed it.


Resource Labels Pod ID and Namespace ID are using the Name not the ID properties

The following values are incorrectly populated by MonitoredResourceUtil

resoure.labels.pod_id
resoure.labels.namespace_id

The values being used are the name value of the respective entities, not the ID properties.
This is inconsistent with the Kubernetes API, and with other appenders used within GKE (e.g. the Fluentd appender), which properly populate the pod_name and namespace_name labels with the metadata.name property.
Expected Behavior

resoure.labels.pod_id <- pod.metadata.uid
resoure.labels.namespace_id <- namespace.metadata.uid
resoure.labels.pod_name <- pod.metadata.name
resoure.labels.namespace_name <- namespace.metadata.name

Impact
The present bug means that you must search in cloud logging with extra factually incorrect predicates like
resource.labels.pod_name="my-pod-name" OR resource.labels.pod_id="my-pod-name"

and means certain Stackdriver log based metrics and filters are not possible due to this inaccuracy.
Since other GKE tools like the built in Fluentd appender properly set resource.labels.pod_name, example Fluentd output below:

Environment details

Specify the API: Cloud Logging, e.g. used with the Google Logback Cloud Appender
OS type and version: all
Java version: all
logging version(s): all

Steps to reproduce

Emit Java log line
View results in Cloud Logging

External references such as API reference guides

Kubernetes Object Metadata Spec

Any additional information below
While changing the pod_id value to the correct entity.metadata.uid property would possibly impact library users, adding the pod_name and namespace_name labels, with the correct values, would allow Cloud Logging users to properly search by the name labels across all logging sources.

@twistedpair,Thanks for filling issue.For a Kubernetes API container instance k8s_container is used as monitored resourceType.
I have been already submitted PR for this future which is under review.Please follow here java-logging-206  for progress/work related to your request.

Thanks, @suraj-qlogic . Glad to see your PR merged.
Looks like namespace_id will still be the wrong value though, but that seems to be a bug in the underlying GCE metadata server. I'll update this issue.

@twistedpair should renaming pod_id to pod_name and namespace_id to namespace_name be sufficient to resolve the problem? from the report it looks like the current label naming is misleading and does not match the logging that is captured from STDOUT by Logging agent. however, i would like to confirm it before applying the change.

I see that the code uses pod_id and namespace_id labels with the old resource type name: container. The k8s_container resource type is populated with the expected labels (pod_name and namespace_name). There is PR #641 that handles the change of the resource type name. After the merge, the expected set of label names will be populate.


[BUG] Search Item is broken

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to Search Item tab
Theres nothing here

Expected behavior
You should see all items in here and be able to search for them
Versions (DO NOT USE "LATEST"! I STEAL YOUR KNEE CAPS!):

Minecraft Version:
Modloader

[ ] Forge
[X] Fabric
[ ] Quilt

Mod Loader Version: 1.20.1
Mod Version: 1.2.1

Additional context
I do not use the base language

To be fixed by #9 when I get time to review and test it. But thanks for reporting
As a work around, the mct reload command fixes the search tab while in game, but it needs to be executed each time you join the game

I started working on this mod again, after working up some courage. I rewrote about 90% of the internal logic, and during testing, everything seemed to work like it should (even the damn search tab....)
Here is a test build if anyone is willing to help test: https://nightbloom.cc/project/morecreativetabs/files


ImportError: No module named _implementation with Python 2.7.14

hello.
Here is the stacktrace I get:
$ awssec.py --help                                                                             [80/9726]
Traceback (most recent call last):
  File "/home/lucas_cimon/bin/awssec.py", line 4, in <module>
    import boto3
  File "/home/lucas_cimon/.local/lib/python2.7/site-packages/boto3/__init__.py", line 16, in <module>
    from boto3.session import Session
  File "/home/lucas_cimon/.local/lib/python2.7/site-packages/boto3/session.py", line 17, in <module>
    import botocore.session
  File "/home/lucas_cimon/.local/lib/python2.7/site-packages/botocore/session.py", line 27, in <module>
    import botocore.configloader
  File "/home/lucas_cimon/.local/lib/python2.7/site-packages/botocore/configloader.py", line 19, in <module>
    from botocore.compat import six
  File "/home/lucas_cimon/.local/lib/python2.7/site-packages/botocore/compat.py", line 26, in <module>
    from urllib3 import exceptions
  File "/usr/lib/python2.7/site-packages/urllib3/__init__.py", line 8, in <module>
    from .connectionpool import (
  File "/usr/lib/python2.7/site-packages/urllib3/connectionpool.py", line 11, in <module>
    from .exceptions import (
  File "/usr/lib/python2.7/site-packages/urllib3/exceptions.py", line 2, in <module>
    from .packages.six.moves.http_client import (
  File "/usr/lib/python2.7/site-packages/urllib3/packages/__init__.py", line 3, in <module>
    from . import ssl_match_hostname
  File "/usr/lib/python2.7/site-packages/urllib3/packages/ssl_match_hostname/__init__.py", line 16, in <module>
    from ._implementation import CertificateError, match_hostname
ImportError: No module named _implementation

I tried upgrading urllib3 manually:
$ pip install urllib3==1.21
...

$ awssec.py --help
Traceback (most recent call last):
  File "/home/lucas_cimon/bin/awssec.py", line 5, in <module>
    import requests
  File "/usr/lib/python2.7/site-packages/requests/__init__.py", line 60, in <module>
    from .packages.urllib3.exceptions import DependencyWarning
ImportError: cannot import name DependencyWarning

$ pip install urllib3==1.22
...

$ awssec.py --help.
...
ImportError: cannot import name DependencyWarning

$ pip install urllib3==1.23
...

$ awssec.py --help.
OK !

Hence I deduced that in order to please both botocore/compat.py & requests on needs a version of urllib>=1.23
Maybe this should be reflected in setup.py

My bad : this error wasn't due to a urllib3 version incompatibility,
but much more likely to an erroneous mixed installation of Python libs through pip2 / pip3
Closing this ticket now


CAMEL-19742: created base test class in camel-test-infra-core

added dependencies to pom files

Still working on it. Created PR to avoid loosing code

Still working on it. Created PR to avoid loosing code

Thanks for kicking it off.
FYI, I marked it as a draft, as this is a WIP and we want to avoid this merging inadvertently.


Text highlighting seems wrong

Would it be possible to change it so that when you highlight part of a word, only the selected characters gets highlighted? This theme seems to be the only one to highlight the whole word regardless of what you select. For example in the attached screenshot, I only selected the text "UniqueID" but all of "generateUniqueID" is highlighted.

Otherwise, great theme!

Hello, @alexleduc76 !
Thank you for reporting this issue. Also, sorry for the late reply.
I will do some work on this and release a minor update soon.

Awesome!

Hi @alexleduc76 !
I fixed this just yesterday. Let me know what you think about the updated text/selection highlighting :)
Thx!

Great, thank you!
Le ven. 28 juin 2019 22:53, Heron Silva<EMAIL_ADDRESS>a écrit :

Hi @alexleduc76 https://github.com/alexleduc76 !
I fixed this just yesterday. Let me know what you think about the updated
text/selection highlighting :)
Thx!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/firefox-theme/visual-studio-code/issues/15?email_source=notifications&email_token=ADD7AJBSGMHTOAL6PJZJMKDP43FBJA5CNFSM4HXTRLSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3P67Y#issuecomment-506920831,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADD7AJAOXI47NBPHNGZNE5TP43FBJANCNFSM4HXTRLSA
.


Inconsistent simulation before and after yosys synthesis(3)

Version
Yosys 0.44 (git sha1 80ba43d26, g++ 11.4.0-2ubuntu1~20.04 -fPIC -O3)
On which OS did this happen?
Linux
Reproduction Steps

Install the necessary dependencies (skip this step if you have already installed verilator and zip):

sudo apt-get install zip verilator

Download the attached .zip archive. Then change to the directory where this archive is located and unpack it:

unzip files.zip

Go to files directory:

cd files

Launch yosys like this:

yosys -p"read_verilog usbf_crc16.v usbf_ep_rf.v usbf_pd.v usbf_wb.v usbf_crc5.v usbf_idma.v usbf_pe.v usbf_mem_arb.v usbf_pl.v usbf_utmi_if.v usbf_ep_rf_dummy.v usbf_pa.v usbf_rf.v usbf_utmi_ls.v usbf_top.v; proc; opt -nodffe; memory; pmuxtree; flatten -scopename; opt -nodffe -fast; write_verilog usbf_top_dut.v"

Change the top module name of the synthesized module:

sed -i 's/module usbf_top/module usbf_top_dut/g' usbf_top_dut.v

Launch verilator like this:

verilator usbf_crc16.v usbf_ep_rf.v usbf_pd.v usbf_wb.v usbf_crc5.v usbf_idma.v usbf_pe.v usbf_mem_arb.v usbf_pl.v usbf_utmi_if.v usbf_ep_rf_dummy.v usbf_pa.v usbf_rf.v usbf_utmi_ls.v usbf_top.v usbf_top_dut.v usbf_top_testbench.sv -Wno-fatal +1364-2005ext+v +1800-2017ext+sv --binary --top-module usbf_top_testbench

Launch the simulation:

./obj_dir/Vusbf_top_testbench

files.zip
Expected Behavior
The expected behavior is the successful simulation result (without any discrepancies between the source model and the synthesized model).
Actual Behavior
verilator gives the following output:
INFO: USB Function core instantiated (TOP.usbf_top_testbench.gold)
      Supported Endpoints: 4 (0 through 3)
      WISHBONE Address bus size: A17:0
      SSRAM Address bus size: A14:0
      Buffer Memory Size: 131072 bytes

 \clk_i_gold = 1
 \rst_i_gold = 0
 \wb_addr_i_gold =     22
 \wb_data_i_gold =<PHONE_NUMBER>
 \wb_we_i_gold = 1
 \wb_stb_i_gold = 1
 \wb_cyc_i_gold = 0
 \dma_ack_i_gold = 56087
 \resume_req_i_gold = 0
 \phy_clk_pad_i_gold = 1
 \TxReady_pad_i_gold = 0
 \RxValid_pad_i_gold = 0
 \RxActive_pad_i_gold = 1
 \RxError_pad_i_gold = 1
 \DataIn_pad_i_gold = 206
 \LineState_pad_i_gold = 1
 \usb_vbus_pad_i_gold = 0
 \VStatus_pad_i_gold =  54
 \sram_data_i_gold =<PHONE_NUMBER>
DUT Error at time                  630
 \wb_data_o :
Expected value          0, Got Value          8
[63500] %Fatal: usbf_top_testbench.sv:263: Assertion failed in TOP.usbf_top_testbench
%Error: usbf_top_testbench.sv:263: Verilog $stop
Aborting...
Aborted (core dumped)

See my response to #4748


Lock 0.4.0

This addresses issue #397
I already tested locally and it worked just fine (including build command)

Where did my commit 051deb9 go? PR #403? Let's use that.
As is on main and deployed the Quickstart is not using the right versions.

Resolved in f2ac3102dc4ebe2f534c9adf3dbb45d7a4be5e5c


Release 2.0

resolve #3 , resolve #15 , resolve #21 , resolve #22 , resolve #23 , resolve #32 , resolve #33 , resolve #37 , resolve #39 , resolve #40

closes #40 #42

closes #43


Add doc content

Addresses #178 and  #165
Adds:

Learn More section
learn_more/column to list performance

Examples section

Usage section

Inline links to the API reference

@jeffbrennan - this looks great, can you please resolve the conflicts, so I can merge?


[Feature Request] Multiview/custom RenderPass

I want to make a render pass utilizing VK_KHR_multiview extension, but the current RenderPass implementation doesn't support it.
Since RenderPass is a structure, it's also not possible to create custom one as every function in vulkano expects the concrete type.
Are there any plans to implement multiview support or at least an unsafe constructor to create RenderPass from raw parts?

I have no experience with the feature, but I can see if I can implement it once I've finished working on better support for Vulkan versions/extensions in general. Do you have particular points of design that you think should be taken into account?

It seems there are 3 structures that can extend render pass 1 2 3. It could probably be handled similarly to device's extensions/features. Also if we are going to use concrete types instead of traits, ability to unsafely construct structures like RenderPass from raw parts would be good for future proofing. Also if multiview extension is requested it could be checked if device has VK_KHR_multiview extension enabled.
However I'm not very knowledgeable about vulkan and vulkano's internals, so it's just a suggestion. I'll implement this feature in my fork, but it's not going to be pretty or implement any other extension except multiview, but it could act as a working example.

I've actually partially implemented VK_KHR_multiview two weeks ago. I just opened a PR (#1598) for it. Some validation is still missing but it's already functional and includes a new example. I will probably finish it in the next few days or so.


[midend][tests] Add broadcast BatchMatMul optimization pass and tests.

Add "-batchmatmul-optimize" option in buddy-opt, the Matmul part is similar to MatMulBroadcast.mlir in buddy-benchmark. The A[batch_idx, 0, 0] which broadcasts in the Matmul will use affine.prefetch to prefetch in the outer loop. It could make the Op slightly faster. There's a bug, if (A_elementType.isIntOrFloat()) cannot work properly. Even if the input type is floating-point, the integer branch will still execute. So I modified to if (A_elementType.isIntOrFloat() && 0) to skip the branch. So far the integer matrix is unavailable,

Thanks! @EllisLambda I have left some suggestions to make it better, and I think these are enough for this PR. More verifications in real scenarios(e.g. simultaneously process linalg.batch_matmul of multiple sizes) may be needed in the future.
@zhanghb97 you may also see https://github.com/buddy-compiler/buddy-benchmark/pull/73.

@EllisLambda Why add batch_matmul pass to opt? I think it is inappropriate to add a certain op pass in opt.

batch_matmul is a typical opertion which is widely used in transformer models, so I think it is reasonable to provide a tailor-made pass for it.
Nevertheless, it would be better if matmul-optimize pass can incorporate the lowering optimizations of both linalg.matmul and linalg.batch_matmul. WDYT @EllisLambda ?

In fact, there is some truth to this, but I think this PR should explain what optimizations have been made? Where has the optimization been made?

In fact, there is some truth to this, but I think this PR should explain what optimizations have been made? Where has the optimization been made?

I tried to

WDYT

The optimization styles between Matmul and BatchMatmul are quite distinct. On different hardware, the performance of these two operations may differ. Separating might be better?

In fact, there is some truth to this, but I think this PR should explain what optimizations have been made? Where has the optimization been made?

@EllisLambda Why add batch_matmul pass to opt? I think it is inappropriate to add a certain op pass in opt.

batch_matmul is a typical opertion which is widely used in transformer models, so I think it is reasonable to provide a tailor-made pass for it.
Nevertheless, it would be better if matmul-optimize pass can incorporate the lowering optimizations of both linalg.matmul and linalg.batch_matmul. WDYT @EllisLambda ?

The optimization styles between Matmul and BatchMatmul are quite distinct. On different hardware, the performance of these two operations may differ. Separating might be better?

In fact, there is some truth to this, but I think this PR should explain what optimizations have been made? Where has the optimization been made?

Ok, I will add the explanation.

Separating might be better?
Yes, we decide to develop batchmatmul-optimize pass specifically for linalg.batch_matmul right now.

Yumin@EllisLambda , about the "bug" you mention in your description, we can unify the support of floating point and integer with another interface. If not, starting a new discussion about integer operations would be more appropriate so that the relevant comments in your description could be removed, as this PR just needs to take floating point operations into account.

Separating might be better?

Yes, we decide to develop batchmatmul-optimize pass specifically for linalg.batch_matmul right now.
Yumin @EllisLambda , about the "bug" you mention in your description, we can unify the support of floating point and integer with another interface. If not, starting a new discussion about integer operations would be more appropriate so that the relevant comments in your description could be removed, as this PR just needs to take floating point operations into account.

Ok! I see.

@xlinsist I have amended my PR.


update readme

📦 Published PR as canary version: 0.0.3-canary.3.107.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in v0.0.3 :rocket:


[SPARK-16868][Web Ui] Fix executor be both dead and alive on executor ui.

What changes were proposed in this pull request?
In a heavy pressure of the spark application, since the executor will register it to driver block manager twice(because of heart beats), the executor will show as picture show:

How was this patch tested?
NA
Details in: SPARK-16868

Test build #63335 has started for PR 14530 at commit 85b385f.

Test build #63335 has finished for PR 14530 at commit 85b385f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class ShuffleIndexInformation
public class ShuffleIndexRecord

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63335/
Test PASSed.

Test build #63355 has started for PR 14530 at commit c065661.

Test build #63355 has finished for PR 14530 at commit c065661.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63355/
Test PASSed.

Merged build finished. Test PASSed.

\cc  @srowen

As to the actual logic of the change, I don't feel that confident about reviewing it. Suggest looking at 'blame' output here to see who might have written it?

Looks fine (small style nit but not worth another review round). I'm a little curious about why it happens - I thought that the driver would kill executors that failed a heartbeat, but that's a separate discussion.
Merging to master.

I will re-run this case, and dig into why the executor will double register.


fix: run on act

Bleah, needs new act release with this in: https://github.com/nektos/act/pull/793


merge master

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e6cd47a). Click here to learn what that means.
The diff coverage is 99.03%.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   99.39%
=========================================
  Files             ?       41
  Lines             ?     1990
  Branches          ?        0
=========================================
  Hits              ?     1978
  Misses            ?        9
  Partials          ?        3

Impacted Files
Coverage Δ

fs.go
100% <ø> (ø)

render/render.go
100% <ø> (ø)

response_writer_1.8.go
0% <0%> (ø)

errors.go
100% <100%> (ø)

auth.go
100% <100%> (ø)

render/protobuf.go
100% <100%> (ø)

binding/form_mapping.go
100% <100%> (ø)

render/redirect.go
100% <100%> (ø)

render/html.go
100% <100%> (ø)

render/data.go
100% <100%> (ø)

... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6cd47a...465ead4. Read the comment docs.


[Flow] Refactor MessageQueue

Looking to address a few new FlowFixMes I had to do some minor refactoring of MessageQueue. Has the advantage of (IMO) making things clearer by removing a redundant counter and some gratuitous bitwise operations.
Previously _callbacks was an array of ?Functions where even elements were failure callbacks and odd elements were successes. Each new call incremented _callID by one and _callbackID by two. I've changed this to use a _callbacksForCall array of ?[?Function, ?Function] tuples indexed by callID. That made the _callbackID counter unnecessary and reduced the need for computed indices.
Tested with flow and a quick play with UIExplorer.

@mkonicek do you know who the original author of the message queue is? I am thinking they may have wanted to avoid GCs by using the odd/even indices instead of creating small arrays/objects... maybe Jordan wrote this?

Good point regardless that the tuples are unnecessarily resource heavy. I'll modify to use two flat arrays of success / failure callbacks.

@ide Done, PR updated and retested

Looks like Pieter (javache) knows about the MessageQueue.

From internal history like it was written by @sahrens.

All done. Thanks for your patience with this one.


You can choose alternative names in manual mode but not in command line

Title explains it, every time I need to update my certificate I need to go and run letsencrypt application manually to be able to type out my alternative names, a.k.a www.,.
This option is NOT available in command line, and needs to be!
Using --san causes the program to crash with index out of bounds errors as I am not using IIS but I am using Apache

Duplicate of #151


Bump rand to 0.8 and remove rand_xorshift

Description
As all the upstream repos have been modified to use ark_std::rand, this PR is ready.
This is related to #24.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (master)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer

N/A:

[ ] Wrote unit tests
[ ] Updated relevant documentation in the code

This PR is ready for review.


iOS Bug

Hello,
I found small bug when sharing non media files on iOS:
Please check https://github.com/bhagat-techind/flutter_sharing_intent/blob/main/ios/Classes/SwiftFlutterSharingIntentPlugin.swift line
157 and compare with line 134.
Actually I just removed the whole "else if url.fragment == "file" as it is redundant
using if url.fragment == "media" || url.fragment == "file"
Is just fine.
I am not sure I have to make a pull request for something that simple?
Best regards:
V

When is this going to be merged?


Issue with the reference genome files

Hi,
Could you provide a link to the reference genome files or a way to create them ? I am missing several files,
Thanks !
Jean

Hi,
To be more specific I cannot find these:
*.full.len
*.genomesize.txt
*.len
*.len.genome
Could you provide us with an example of the first lines of the following files?
Thanks !

Hi
Thanks for checking out PTATO. We are still improving the pipeline. I see that not all files are needed, we will test this soon and remove all unnecessary genome files (from the README). You can ignore the *.genomesize.txt file for now, because this is an inhouse create file, with the information about the genome size. To be sure I have add below a small version of the content of each files. Some of the files are duplicates.
*.full.len
1	chr1	248956422
2	chr2	242193529
3	chr3	198295559
...
Un_JTFH01001996v1_decoy	chrUn_JTFH01001996v1_decoy	2009
Un_JTFH01001997v1_decoy	chrUn_JTFH01001997v1_decoy	2003
Un_JTFH01001998v1_decoy	chrUn_JTFH01001998v1_decoy	2001

*.len
1	chr1	248956422
2	chr2	242193529
3	chr3	198295559
...
22	chr22	50818468
X	chrX	156040895
Y	chrY	57227415

*.len.genome
1	248956422
2	242193529
3	198295559
...
20	64444167
21	46709983
22	50818468

*genomesize.txt
Autosomal non N genome size:<PHONE_NUMBER>
Autosomal genome size:<PHONE_NUMBER>
Autosomal and XY non N genome size:<PHONE_NUMBER>
Autosomal and XY genome size:<PHONE_NUMBER>
Autosomal and XYMT non N genome size:<PHONE_NUMBER>
Autosomal and XYMT genome size:<PHONE_NUMBER>
Full (incl decoy)  non N genome size:<PHONE_NUMBER>
Full (incl decoy) genome size:<PHONE_NUMBER>

Thank you very much !


fix: adding relevant platform suffix to ignore errors in windows

Reason for Change:

Adding platform suffix for some linux only files, so when we open IDE in windows everything is green.
Issue Fixed:

Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests

Notes:

/azp run


Support tilde character (~) in Razor links

Code does translate correctly the tilde ~ as a proper path reference when the code runs (but that may be mono or core-clr doing that magic, or roslyn), but when I cmd-click the link, Code offers to create a new folder in the path that literally includes the tilde as the folder name in that path, when it should convert it to the proper path of wwwroot...this is in the _Layout.cshtml file. I'm unsure where to look in the code so I can see what it's doing to offer a fix.

@rhires Are you Ctrl+Clicking on a "detected link" inside an HTML block?
Something like:
<a href="~/some/path/to/something.txt">

Yes, for example this item in _Layout.cshtml: <link rel="stylesheet" href="~/css/bootstrap.css" /> - even though it's properly found when I run the app (dnx web from the command line in Mac OS X) when I cmd-click, I get an offer to create the file with the tilde in it: File not found ([$PATH-to-project-root/Views/Shared/~/css/bootstrap.css) If I create the file, then I have a new folder called ~ with the rest of the path in it below.

Ok, I think I understand. In your _Layout.cshtml you use:
<link rel="stylesheet" href="~/css/bootstrap.css" />

~ is something Razor understands and resolves it at runtime to an actual path (possibly something that is configurable). Probably in this case at runtime it will be:
<link rel="stylesheet" href="/css/bootstrap.css" />

When you Ctrl+click on the detected link, VSCode wants to open the file but VSCode fails to understand the special meaning of ~.

To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.
If you disagree and feel that this issue is crucial: We're happy to listen and to reconsider.
Maybe you want to give it a try yourself and provide the feature through an extension or a PR: We're happy to give advise and get you started.
Thanks for your understanding. Thanks for helping and happy coding!

I added code to detect the '~' and remove it. So the URL will resolve to the current workspace folder. That's IMO the best we can do as we don't know the Razor application root.


GC-1369 - Item names appear to be truncated too soon

https://share.getcloudapp.com/qGu6Ol8r

Is the screenshot how it looks on prod or how the fix looks in this PR?

Is the screenshot how it looks on prod or how the fix looks in this PR?

That's how it looked before @timbryandev. Sorry wasn't clean, should be like this after this merged


Sarif support for integration with GitHub security

Can you add Sarif export support to the export of the scans so the data can be uploaded to GitHub Advanced Security? This would give us a consolidated view of all the code quality issues.

Usually I would prefer to not implement it in Robocop (since we would now need to support it). But after quick look at sarif I see it would be easier to implement it in our core code. So we can do this - hovewer could you help with testing the output? I don't have anything that uses sarif output, I can cover the export with unit test but it would be nice to have someone to actually test it live.
I think it could be implemented as a report class, creating the file after the run.

Leaving some resources for me:
Sarif docs: https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning
Validate sarif file: https://sarifweb.azurewebsites.net/

I would be glad to help when you are ready. Unfortunately due to the fact, that our code is proprietary I can't run this against a public repo.
I can however create the GitHub action and have it upload the results to our test repo and then share the output with you.
I would just need some assistance on the parameters to run against the existing code and the parameters for running using the sarif output. Then I can provide the output of both.

Sure, I will let you know - when I learn more about the format I could figure out the best way of using it (testing) as well. I could also try to setup github action on our repo as well. I can see that there are lot of optional fields so we can do it iteratively, starting from required ones.

Sounds great. Thank you

I've created early POC (not yet mergable) in #653 together with example Github action that runs the Robocop and uploads Sarif file. You can see it's able to detect the issues from the file:

More details on single issue:

It appears to work, I will now focus on tweaking and improving the code and adding the tests.

BTW thanks for this issue - now I've learned about this format and it looks like good way to solve some of our issues (like #414 which is on hold due to issues with native github API) or creating html reports (thanks to tools handling sarif output).

Merged the PR with sarif report. It will be included in the next release (2.4.0) in the next few days.
I have also created new page in our docs - CI - that will include information how to integrate Robocop with various CI/CD platforms (hopefully it will grow over the time). There is open PR with first addition - how to configure Github workflow to use SARIF to register issues in Github Code Scanning - #657 .

Looks like it is not quite working. Here is what I have in my github action:
python -m robocop --reports sarif.json .
However, when I look at the directory the sarif file is not there
Run pwd
pwd
ls -lha
shell: /usr/bin/bash -e {0}
shell: /usr/bin/bash -e {0}
/home/runner/work/qa-testing-robocop/qa-testing-robocop
total 64K
drwxr-xr-x 10 runner docker 4.0K Aug 24 18:22 .
drwxr-xr-x 3 runner docker 4.0K Aug 24 18:22 ..
drwxr-xr-x 8 runner docker 4.0K Aug 24 18:22 .git
drwxr-xr-x 3 runner docker 4.0K Aug 24 18:22 .github
drwxr-xr-x 3 runner docker 4.0K Aug 24 18:22 .idea
drwxr-xr-x 4 runner docker 4.0K Aug 24 18:22 Data
-rw-r--r-- 1 runner docker 175 Aug 24 18:22 Dockerfile
drwxr-xr-x 4 runner docker 4.0K Aug 24 18:22 Library
-rw-r--r-- 1 runner docker 80 Aug 24 18:22 README.md
drwxr-xr-x 5 runner docker 4.0K Aug 24 18:22 Resources
drwxr-xr-x 7 runner docker 4.0K Aug 24 18:22 Tests
drwxr-xr-x 2 runner docker 4.0K Aug 24 18:22 Tools
-rw-r--r-- 1 runner docker 1.5K Aug 24 18:22 execution_order.dat
-rw-r--r-- 1 runner docker 519 Aug 24 18:22 main.py
-rw-r--r-- 1 runner docker 296 Aug 24 18:22 requirements.txt
-rwxr-xr-x 1 runner docker 944 Aug 24 18:22 rfdocker

You need to pass sarif to reports:
python -m robocop --reports sarif .

The report will be generated in .sarif.json file. You can configure the output directory or filename by configuring the report:
robocop --reports sarif --configure sarif:output_dir=C:/sarif_reports --configure sarif:report_filename=.sarif

But I think it's possible bug - it should fail on unrecognized report name (such as sarif.json instead of sarif).

I changed it and the file is still not there
run: |
python -m robocop --reports sarif .
- name: List dir
run: |
pwd
ls -lha
shell: /usr/bin/bash -e {0}
/home/runner/work/qa-testing-robocop/qa-testing-robocop
total 64K
drwxr-xr-x 10 runner docker 4.0K Aug 24 18:43 .
drwxr-xr-x  3 runner docker 4.0K Aug 24 18:43 ..
drwxr-xr-x  8 runner docker 4.0K Aug 24 18:43 .git
drwxr-xr-x  3 runner docker 4.0K Aug 24 18:43 .github
drwxr-xr-x  3 runner docker 4.0K Aug 24 18:43 .idea
drwxr-xr-x  4 runner docker 4.0K Aug 24 18:43 Data
-rw-r--r--  1 runner docker  175 Aug 24 18:43 Dockerfile
drwxr-xr-x  4 runner docker 4.0K Aug 24 18:43 Library
-rw-r--r--  1 runner docker   80 Aug 24 18:43 README.md
drwxr-xr-x  5 runner docker 4.0K Aug 24 18:43 Resources
drwxr-xr-x  7 runner docker 4.0K Aug 24 18:43 Tests
drwxr-xr-x  2 runner docker 4.0K Aug 24 18:43 Tools
-rw-r--r--  1 runner docker 1.5K Aug 24 18:43 execution_order.dat
-rw-r--r--  1 runner docker  519 Aug 24 18:43 main.py
-rw-r--r--  1 runner docker  296 Aug 24 18:43 requirements.txt
-rwxr-xr-x  1 runner docker  944 Aug 24 18:43 rfdocker

Duh..it looks like I forgot to make release! Now it makes sense why it didnt fail on unknown report -since failing on unknown names was added aro7bd the same timer as sarif report. I aoologise for that, I will release the changes tommorow and let you known in this issue.

Did you know when the commit will be part of the release? I just tried again this morning and I am still not seeing the file on the GH runner file system.

I had some issues but it is now resolved and sarif report is now part of 2.4.0 release. Thank you for your patience!

It did work now. Thank you. I am still seeing an exit code 255 after the scan but the sarif did get uploaded to GitHub Security.


:arrow_up: Update musl-dev to 1.1.20-r4

Proposed Changes
Update musl-dev to 1.1.20-r4

Cancelling these for now