should improve the representations behavior

hjc 6 hours ago
Couple things. First off, to handle a missing content type from representations we should either throw a specific exception or provide the usage of like a default key in the representations dictionary that is a catch-all function that can always be used. Alternatively, we should just return the data we were given. I don't like using the first key in the dictionary, because dictionary ordering isn't guaranteed until Py3.6, in earlier versions you'd get a random key every time and that sounds SUPER frustrating.

from: https://github.com/teracyhq/flask-classful/pull/71/files#r141177560

Also, can we define "find the best match"? For example, if I pass it application/json as my content type, will it look for application/json, json, and application in that order? Or just application/json?

from https://github.com/teracyhq/flask-classful/pull/71/files#r141177560

@hjc let's continue to improve the representations behavior here.

Alternatively, we should just return the data we were given. I don't like using the first key in the dictionary, because dictionary ordering isn't guaranteed until Py3.6, in earlier versions you'd get a random key every time and that sounds SUPER frustrating.

I agree, let's just return the data we were given.
...
Otherwise, ``Flask-Classful`` will try to find the best match between the accepted content
type and the keys in the ``representations`` dictionary, and call the associated output proxy
function to create a ``flask.wrappers.ResponseBase`` instance.
...

=>
...
Otherwise, ``Flask-Classful`` will try to find the best match between the accepted content
type and the keys in the ``representations`` dictionary, and call the associated output proxy
function to create a ``flask.wrappers.ResponseBase`` instance. The best match finding is the
behavior of `werkzeug.datastructures.Accept#best_match`:  "Returns the best match from a
list of possible matches based on the quality of the client. If two items have the same quality,
the one is returned that comes first."
...

Is this doc ok?

@hjc if you could create a PR for this, it would be fantastic :-)

@hjc btw, I added you as a collaborator for this project, hopefully, you can help to boost this project development. We need more collaborators for the project.

@hoatle - totally agreed about just returning what we were given. Re: the docs from Werkzeug itself, I'm not sure those are clear enough. I'm going to play with that method and see what it really does and then define that. With the way it's written it mentions "quality of the client" but then never really defines what it means by that. The way I read that is that it will try progressively more permissive mime types based on what the client accepts. E.g., if we try to return application/json but the client doesn't accept that, then this will probably try to return text/html or something like that. I also don't know how or when that method is used... so, I could be completely wrong.
I'll take a look at this either tomorrow or over the weekend and open a PR with docs, tests, and a fix. I've also accepted the collaborator invitation and am happy to help out as I can!

@hoatle - see #74 for this work.

Hi! I noted that this fix broke backwards compatibility with the tests of my app. I wrote the following code to demonstrate the issue:
import json
from flask import Flask, make_response
from flask_classful import FlaskView

app = Flask(__name__)

def output_json(data, code, headers=None):
    content_type = 'application/json'
    dumped = json.dumps(data)
    if headers:
        headers.update({'Content-Type': content_type})
    else:
        headers = {'Content-Type': content_type}
    response = make_response(dumped, code, headers)
    return response

class QuotesView(FlaskView):
    representations = {
        'application/json': output_json,
        # 'flask-classful/default': output_json,  # I had to add this to fix it
    }
    def index(self):
        return {"hello": "world"}

QuotesView.register(app)

if __name__ == '__main__':

    # app.run(debug=True)

    client = app.test_client()
    res = client.get('/quotes/')
    assert res.status_code == 200
    assert res.headers['Content-Type'] == 'application/json'
    assert json.loads(res.data) == {'hello': 'world'}
    print 'ALL OK'

This will print ALL OK before this commit, and cause and ugly exception after this commit.
Because now it doesn't use the first representation by default, it makes a response with a dict instead of a string with the encoded JSON. This caused a really ugly bug that (strangely) only showed up in the test cases, and was quite difficult to debug. I had to get in flask and werkzeugs internals, and to do a git bisect to the flask-classful repo in order to find the cause of the bug.
The fix was to add a flask-classful/default representation with output_json, as commented in the code above. I think that this change should be better documented in the changelog or in a migration guide to avoid others to have problems with this.
This could also be fixed on the second code block of this section in the docs: http://flask-classful.teracy.org/#adding-resource-representations-get-real-classy-and-put-on-a-top-hat, since that example code has the issue I detailed above. It comments the fix a few paragraphs below, but in my opinion this isn't enough.

@sh4r3m4n thank you for your information, let me find all the breaking changes and add to the migration sections on docs and change log then. There are two breaking changes that I can see:

https://github.com/teracyhq/flask-classful/issues/47
and this one.

this issue should fix the problem: https://github.com/teracyhq/flask-classful/issues/79


Interface Improvements

Make the page look better!

Looking good! Perhaps we can also look at how to reformat the layers and voxels pages? Seems like all the squares get too crowded now. Perhaps they are all the same size, and we can expand them by clicking on them?


temporary variables turbowarp version bug

delete all runtime variables block doesnt delete any variables, and when you click the checkbox on the active runtime variables reporter it doesnt show anything but when you click the block it does

getting error
TypeError: Cannot read properties of undefined (reading 'delete')
for delete runtime var block
and error
TypeError: Cannot read properties of undefined (reading 'has')
using runtime var exists?
im getting both these errors while trying to use these blocks in a custom block, pls fix ur stuff penguinmod 😭

tf

wait, do your variable names invlove periods

oh well um erm its um its well its um complicated um maybe um yes

wat do u mean by loss of tiny bit of simplicity

dangerouz optimizations worked :D

 dangerouz optimizations worked :D

yay!

wat do u mean by loss of tiny bit of simplicity

as in instead of get (baz) in (get (bar) in (get (foo) in (get (tempvar)))) you can just do get (tempvar.foo.bar.baz) (assuming tempvar contains {"foo":{"bar":{"baz":"hellorld!"}}}) for this feature to work it is important that it is an obejct/map-like and not a json string that is inside the tempvar, a map-like would be something like the pm "objects" extension in the extension gallery

why is it closed when the main issue is still present

@RedMan13 REDMANNNNNN!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! REOPEN ITTTTTTTTTTTTTTTT!!!!!!!!!!

why is it closed when the main issue from the original comment is still present

which one

ehh both need fixed anyways

lol

so, tf ?
what on skidi was making the second set of errors
also fixed the bug this thread was orignally for

NOOOOOOOOOOO!!!!!!!!!! WAAAAAAAAAAAIIIIIIIIITTTTTTTTT!!!!!!! THERES ONE LAST BUGGGGGGGGGGGGGG!!!!!!!!!


Enforce go fmt in CI (errors are present).

Test plan

All unit tests and new fmt test must pass.

Simplify can lead to breaking changes. Investigate for later.


fix(gatsby-source-strapi): catch logging in fetchEntity

Description
Improved logging in fetchEntity catch. We do not log 404 because strapi returns this status if there are no changes since the last download.
Related Issues
According to https://github.com/gatsby-uc/plugins/issues/410

@laurenskling Thanks for review and changes 😀

@xSyki this has been released in 3.1.4, please give it a try


filterMatrixContextVar leads to panic: runtime error: index out of range [2] with length 1

Expected Behavior
No issues should be observed. At least we had no such issues for the same pipelines on Pipeline version v0.53.0
Actual Behavior
pipeline-controller restarts because of a panic issue
panic: runtime error: index out of range [2] with length 1

goroutine 197 [running]:
github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun/resources.filterMatrixContextVar({0xc001244e10?, 0x1, 0x2874a6a?})
	github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun/resources/apply.go:163 +0x335
github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun/resources.ApplyPipelineTaskContexts(0xc000a0b5e0?, {{0x0, {0xc0003f42a0, 0x1, 0x1}, 0x0}, {0xc000de6588, 0x0, {0x0, 0x0, ...}, ...}}, ...)
	github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun/resources/apply.go:185 +0x165
github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun.(*Reconciler).createTaskRun(0xc0004e2000, {0x2c656e0, 0xc0007df200}, {0xc000e87f80, 0x31}, {0x0, 0x0, 0x0}, 0xc000bab320, 0xc0004a6b40, ...)
	github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun/pipelinerun.go:890 +0x205
github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun.(*Reconciler).createTaskRuns(0xc0004e2000, {0x2c656e0, 0xc0007df050}, 0xc000bab320, 0x1?, 0x0?)
	github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun/pipelinerun.go:876 +0x385
github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun.(*Reconciler).runNextSchedulableTask(0xc0004e2000, {0x2c656e0, 0xc000df1560}, 0xc0004a6b40, 0xc0010c1028)
	github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun/pipelinerun.go:841 +0x9de
github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun.(*Reconciler).reconcile(0xc0004e2000, {0x2c656e0, 0xc000df14d0}, 0xc0004a6b40, 0x41184c8?, 0xc0003f4700)
	github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun/pipelinerun.go:725 +0x3892
github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun.(*Reconciler).ReconcileKind(0xc0004e2000, {0x2c656e0, 0xc000df1140}, 0xc0004a6b40)
	github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun/pipelinerun.go:264 +0xf8b
github.com/tektoncd/pipeline/pkg/client/injection/reconciler/pipeline/v1/pipelinerun.(*reconcilerImpl).Reconcile(0xc0007e8140, {0x2c656e0, 0xc000df1080}, {0xc000e86d80, 0x3e})
	github.com/tektoncd/pipeline/pkg/client/injection/reconciler/pipeline/v1/pipelinerun/reconciler.go:236 +0x582
knative.dev/pkg/controller.(*Impl).processNextWorkItem(0xc0002d4fc0)
	knative.dev/pkg@v0.0.0-20231011193800-bd99f2f98be7/controller/controller.go:542 +0x58d
knative.dev/pkg/controller.(*Impl).RunContext.func3()
	knative.dev/pkg@v0.0.0-20231011193800-bd99f2f98be7/controller/controller.go:491 +0x68
created by knative.dev/pkg/controller.(*Impl).RunContext
	knative.dev/pkg@v0.0.0-20231011193800-bd99f2f98be7/controller/controller.go:489 +0x312

Steps to Reproduce the Problem
It is rather hard to reproduce the issue since we have hundreds of pipelines

Use tekton pipeline version v0.51.0
Upgrade tekton pipeline to v0.53.0
Periodically observe panic

Additional Info

Kubernetes version:
Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.2", GitCommit:"7f6f68fdabc4df88cfea2dcf9a19b2b830f1e647", GitTreeState:"clean", BuildDate:"2023-05-17T14:20:07Z", GoVersion:"go1.20.4", Compiler:"gc", Platform:"darwin/arm64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"26+", GitVersion:"v1.26.10-eks-4f4795d", GitCommit:"164dfb62db432c0b28a1fced3956256af68533b6", GitTreeState:"clean", BuildDate:"2023-10-20T23:21:27Z", GoVersion:"go1.20.10", Compiler:"gc", Platform:"linux/amd64"}

Tekton Pipeline version:
Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

Client version: 0.33.0
Chains version: v0.19.0
Pipeline version: v0.53.0
Triggers version: v0.25.2

Will try to find the root cause with pipeline example, that produce such behaviour

/assign @pratap0007
Hey, I am interested in this issue and am assigning to me

I have the same issue. When I trigger a pipelineRun from event listener
Client version: 0.32.2
Pipeline version: v0.54.0
Triggers version: v0.25.3
Dashboard version: v0.41.0
I start a pipelineRun directly , the issue will not occur. But when start the same pipelineRun from event Listener ,the bug will definitely appear

I have tried this version all have the same issue
Pipeline version: v0.54.0/v0.53.0
Triggers version:v0.25.3/v0.25.2

Hey 👋 any update on this? I just got this today and it does not seem to be random. It happens when a param's value is set referencing another param's values. It is easy to reproduce in the tests, just add another parameter to this test like:
     params:
     - name: foo
       value: somethingfun
+    - name: foo2
+      value: $(params.foo)
     - name: bar
       value: $(params.bar)
     - name: contextRunParam

It seems like the controller does not check if the parameter exists or not and leaves this for the matrix evaluation, which then tries to split by . and access index 2 which does not exist.

/assign @pratap0007 Hey, I am interested in this issue and am assigning to me

@pratap0007 any progress on this? It's important to fix this ASAP. Please let us know if you need any assistance.
If you don't have the bandwidth anymore please un-assign yourself so that we can identify someone else to provide a fix.
Thanks 🙏

I was sniffing around a bit more and here is what I found:

The test that I posted above will break with any parameter not found because the reconcile is not calling the validate that tests for parameters not defined. But when trying to apply it to the cluster the conditions change because the pipelinerun validation looks for it.
I could reproduce this in the cluster using task parameter values in other task parameter values.
This happens because the param names for the tasks are being appended to the validation dict for later checking and so task parameters using other task parameters name pass this test.
Later in parameter substitution these parameters are not replaced and then enter that if for the matrix evaluation, causing the panic.

What is the behaviour intended with the task params? Should it be possible to reference other parameters in a parameter's value? Or should this be checked and denied?
Despite all this, I believe this split should be checked to prevent the panic. I can create a PR to fix the panic and/or the parameter validation on the tasks

Thanks for the investigation @joaosilva15 !
I think from your example, its more like that value params.param1 should be coming from one level above, i.e. params defined under pipelineSpec or pippelineRun (and propagated) and that would be perfectly valid.
This is valid:
apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  name: pipeline1
spec:
  params:
    - name: param1
      value: "HELLO"
  pipelineSpec:
    params:
      - name: param1
    tasks:
      - name: test-params
        taskSpec:
          params:
            - name: param1
            - name: param2
          steps:
            - name: build
              image: public.ecr.aws/docker/library/golang:1.18.1-alpine
              script: |
                echo $(params.param1)
                echo $(params.param2)
        params:
          - name: param1
            value: "foo"
          - name: param2
            value: "$(params.param1)"

lets discuss the validation topic separately.
I think for now, we should fix the panic error by checking the length before the conditional
if len(subExpressions) >= 4 {
        if subExpressions[2]...
}

@joaosilva15 did you want to create a PR for the panic fix? I can review it.

Yeah, I also saw that the behaviour would be to let it through it is not found in the scripts but the vars it always fails on validation, the problem is that the reconcile does not call the validate for the pipelinerun, which is the one validating the values of the params.
Sure, let me create the PR.

comment for tracking 👀


Type-checks for spread operator are failing

flow-try link:
snippet:
type Identifiable<T> = {
  id: T,
};

function convertIdentifier2(x: Identifiable<number>): Identifiable<string> {
  // this should succeed since we override id to be of string type, but generates type errors
  return { ...x, id: x.id.toString() };
}

8:   return { ...x, id: x.id.toString() };
            ^ Cannot return object literal because number [1] is incompatible with string [2] in property `id`.
References:
7: function convertIdentifier2(x: Identifiable<number>): Identifiable<string> {
                                               ^ [1]
7: function convertIdentifier2(x: Identifiable<number>): Identifiable<string> {
                                                                      ^ [2]

Here's another example. We basically take one object and transform it into another object, changing a few properties along the way. We have a property that is the same key on both objects, but different types. The spread operator should override the first property and replace it with the second, but flow doesn't support it.

This no longer errors in master


How to animate the Precipitation component when using "disableRender" on the TresCanvas

Describe the bug
Hi!
TLDR;
I was wondering if there is a way to make the Precipitation component animate after using disableRender on the main TresCanvas.
Whole story:
I currently playing with custom shaders and wanted to try them inside Tres, I created a function that extracts the context of the TresCanvas component from a ref to create the RenderPass:
  // render pass
  const renderPass = new RenderPass(
    tresCanvas.value.context.scene.value,
    tresCanvas.value.context.camera.value
  )

  // Distortion pass
  distortPass.value = new ShaderPass(LensDistortionShader)
  distortPass.value.material.defines.CHROMA_SAMPLES = 10

  // compopser
  composer.value = new EffectComposer(tresCanvas.value.context.renderer.value)
  composer.value.setSize(window.innerWidth, window.innerHeight)
  composer.value.setPixelRatio(window.devicePixelRatio * 1.3)

  // output pass
  const outputPass = new OutputPass()

  // add the passes
  composer.value.addPass(renderPass)
  composer.value.addPass(distortPass.value)
  composer.value.addPass(outputPass)
}

The thing here is that for me to apply the RenderPass to the TresCanvas we need to disable the default renderer, which means that the Precipitation component from cientos no longer animates, I'm no master at three.js,  but if you can guide me on where to thinker, I might be able to sort this. If you have any ideas or advice on how to make this run I am all ears! Other than that, I'm loving Tres.js and its companion libraries (Cientos, Leches and Post Processing)!
Let me know if you need more context or info!
Cheers!
Reproduction
https://stackblitz.com/edit/tresjs-basic-5sm94z
Steps to reproduce
Described above and clear on the stackblitz example
System Info
Using Stackblitz

Used Package Manager
npm
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

Hello!
You don't need to access the renderer directly if you're using Tresjs/post-processing. Here's a short-ish component from the playground with a post-processing step that shows how this can be done.
Barring that, you can do post-processing via the renderer directly, like in your linked example, but you should use useTresContext() in a subcomponent of the TresCanvas to access the renderer. (Here's a recent discussion where that approach was suggested by Tino.) He's on the core team and working on post-processing.

You might have better luck getting answers over on the Discord as this is more of a post-processing question, it seems, rather than a Cientos question: https://discord.com/invite/three-js-685241246557667386
But I'll see if anyone on the Discord wants to chime in over here or make corrections to what I wrote.

Thank you for the references! I'll surely sign up for the discord!


Remove TLS support from k8s namer.

Starting a local kubectl proxy is the recommended way to securely talk to the k8s cluster API.  See https://github.com/BuoyantIO/linkerd-examples/pull/12

⭐ 🐼  I like it -- just had that one documentation nit.

:star: we'll to update the examples repo as well (we can do this before the next release)


VS Code not reading jsconfig.json

I also have the issue the jsconfig.json is not being read (see old/closed issue #703)
Tested with Visual Studio Code v1.5.3 and v1.7.0 insider, on Windows x64 (version 1607). No 3rd party antivirus, just Windows defender.
When using Sysinternals process monitor, I see that VS Code is getting some information about jsconfig.json (QueryAllInformationFile), but does NOT read the file (ReadFile).
Log when opening VS Code (with the current project) (reduced to jsconfig.json and my test file)
http://pastebin.com/GTKHPCZC
Log when actually opening jsconfig.json inside VS Code (so something like that should also happen when launching VS Code):
http://pastebin.com/je8Y3p4C
Not reading jsconfig.json unfortunately means that "go to definition" doesn't work for me with my own js files, what hinders me from switching from Netbeans to VS Code :(
I would really appreciate if this issue could be fixed. If you need further information, or my stripped down example, just let me know!

vscode-test-prj-root.zip
In case it helps, here is my stripped down example.
It has a complex folder hierarchy because it's part of a larger project. I tried using open folders with prj-root as well as with prj-root\ui\apps\com.mydomain\mycomponent for testing purpose, that's why there are two jsconfig.json files.
Problem 1:
When editing prj-root\ui\apps\com.mydomain\mycomponent\baseframework\app\baseapplication.js, it's not possible to go to the definition of Utils.doSomething()
Possible root cause: jsconfig.json not used
Problem 2:
Quick-Open (Ctrl+P) utils.js only ignores the copies in "node_modules" (default), but nit in "ignore" (configured as exclude in jsconfig.json)
Possible root cause: jsconfig.json not used

@malte-timmermann thank you for opening this issue.
@bowdenk7 can I get your eyes on this one? OP seems to have set everything up correctly (see his zip file). If I try to trigger IntelliSense in node_modules/utils.js I get nothing.

Hey @malte-timmermann, unfortunately we are unable to resolve AMD modules at the moment. To resolve this, you would need to update your codebase to use either ES6 modules or commonjs modules.
The other issue with this specific code sample is that we can't resolve the expando pattern either. For example:
var Utils = {};
Utils.foo = function(bar) {return bar};

Utils.    //<------ we don't know function foo exists

To resolve this one, you would just need to declare object properties at declaration time as opposed to tacking them on later. Like this:
var Utils = {
    foo: function(bar) {return bar};
}

Like Wade said, we really appreciate you taking the time to open this issue. It helps us a lot. If you are interested in chatting more or trying to convert some of your code, I would be happy to help.

Hi bowdenk7,
thanks for looking into this.
Too bad that VS Code wont support this, as this works fine in Netbeans, and changing code is not an option.
Given that ES6 is currently not used by most people developing web apps - really no chance to support it?
At least you wrote "at the moment" - so there is hope?
Best regards
Malte.

Amd module support is being tracked here: https://github.com/Microsoft/TypeScript/issues/6942
I believe the properties issues is now being tracked here: https://github.com/Microsoft/TypeScript/issues/7632
Closing as upstream


PP: UX Discovery User Research Plan

Type
UX Discovery
Objectives
To draw up a research objectives and plan
Tasks

[x] Brainstorm on what we want to investigate
[x] Discuss the methods with James
[x] Work with Tomi to prepare the comps

We will discuss the prototype plan during the team planning meeting on 26 July.


upgrade chart versions

change jenkins-x/jenkins-x-platform to version 0.0.3845
change jenkins-x/prow to version 0.0.476

/test all

/test all


Update to GREL script to incorporate other columns in Remarks table in Specify

When adding data from Notes field in the App to the Remarks field in Specify, need to also fill in data into the other two columns in the Remarks table (these are "Source" and "Date"). In the source column we should add "DaSSCo digitisation" and in the date column, the date the data was added to the app. The data for these two columns therefore needs to be incorporated into the GREL script. Theoretically, we should make it so that multiple rows in the remarks field is possible.

Yes, I had a talk with @AstridBVW about how notes are currently lumped into the base specimen "Remarks" field, circumventing the "tabular" Remarks records related to the specimen. I had specifically designed for DaSSCo purposes following @PipBrewer 's specifications, but these have until now not been put to use. There should be a clear way to funnel data into these fields, otherwise the GREL script won't know how to tease out this information. Perhaps even we should make additions to the UI for a controlled entry of this information.

No need to adapt the UI. The GREL script can do the trick.

Adding these columns to new exports is now part of the post processing.


file is overwritten in temp path

After we crop the image, it is stored in tmp path but older image is replaced. So if we want to cancel the event after cropping, we cannot pull image from storage since it gives new replaced file
on line 30 can you change it to
this.outputUri = Uri.fromFile(new File(getTempDirectoryPath() + "/" + System.currentTimeMillis()+ "-cropped.jpg"));
so that every image will be new.
Thanks in advance.

Send a PR with this and I'll merge

@jeduan there ya go


Weird error when installing requirements

Did what your instructions said:
Microsoft Windows [Version 10.0.22631.2792]
(c) Microsoft Corporation. All rights reserved.

(venv) E:\Temporary Media\o-an-quan>python3 --version
Python 3.11.7

(venv) E:\Temporary Media\o-an-quan>pip3 install -r requirements.txt
Collecting pygame (from -r requirements.txt (line 1))
  Obtaining dependency information for pygame from https://files.pythonhosted.org/packages/82/61/93ae7afbd931a70510cfdf0a7bb0007540020b8d80bc1d8762ebdc46479b/pygame-2.5.2-cp311-cp311-win_amd64.whl.metadata
  Downloading pygame-2.5.2-cp311-cp311-win_amd64.whl.metadata (13 kB)
ERROR: Could not find a version that satisfies the requirement subprocess (from versions: none)
ERROR: No matching distribution found for subprocess

[notice] A new release of pip is available: 23.2.1 -> 23.3.2
[notice] To update, run: python.exe -m pip install --upgrade pip

Seems like there is no such package as subprocess. subprocess seems to be a built-in Python module, so it should not be installed using pip.
Removing subprocess from requirements.txt works.

Many thanks for the report, I have updated the file accordingly.


Cb/pg results

[x] align windowing with results periods
[x] print summary stats of results
[x] make kwargs args in load_results
[x] load_simulation_results -> load_results
[ ] remove results_timestamps # what about the store reads?
[ ] add timestamps to dfs
[x] get_values -> read ... in op_problem_results too
[x] pre-allocate array or df in realized_results #copycols = false

@jd-lara I will merge now so that I can integrate this with my export changes. You can still review the final result.


Cleanup sim/battle.ts

Final part of my 'post Typescript-ification cleanup' (yay!). This is a big class, I got tired and probably missed some more cleanup opportunities, but I was only willing to make so many passes...
Trying to make things easier on you as a reviewer, so instead of squashing all the commits together I tried to keep each operation I did separate so that you could review each consecutive commit and see exactly what is happening at each step. Let me know if approach helps at all.
I know we discussed merging scripts.js into battle.ts instead of all the throwing methods, but I ran into trouble when I tried that due to the mismatched types between globals and battle (fixed in this CL), and also I wanted to take a step back and think more about what the end goal should look like (no point in merging scripts.js and causing churn and making git blame harder if we're just going to create a mechanics.ts file or something soon anyway).

Travis tests have failed
Hey @scheibo,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
TravisBuddy Request Identifier: 41e5d070-4b39-11e9-b5c5-a3cccb953e66


improve: tests

Phew, this was pretty big already.
As @Olyno mentioned, this project needs a good test system, right now. If we do this now, we won't have to go through all this hassle later on.
The test system was completely revamped to mimic Skript test system a bit. Most of the information can be found in the README.md file I added in the resource folder.
Furthermore, this system can handle 'multiple errors' (currently only when testing syntax, but we can surely expand this further across all tests if needed). This means that one error in one test will not stop the whole system: it will be saved and thrown later as a MultipleFailureException.
In the Discord channel, I created a small TODO list for this PR to be finished. This includes but is not limited to:

Finishing all tests
Replacing LiteralParserTest completely with script files and adding variable tests.

The highest priority currently is to finish all syntax tests, and some help would be highly appreciated. Again, read the README file first.
Many changes to the core system will probably need to be made, since I'm actually not experienced at all with testing systems, so I don't know the best way of performing it. Feedback early on would be appreciated as well.

Fixes #73


Issue on page /clay-v1-wall-to-wall.html

I am trying to run the clay v1 model on my Mac and faced an issue with installing one of the libraries. When I run the code 'from stacchip.processors.prechip import normalize_timestamp', I run into an issue. The library wasn't installed as part of the dependencies, and I tried installing it manually, but it doesn't seem to exist. Can you please tell me how I can install this particular library?

Hi @ritwikvashistha can you try pip install stacchip?
I think we could also port the normalize function into the notebook and remove the library, this is a very simple function, see
https://github.com/Clay-foundation/stacchip/blob/main/stacchip/processors/prechip.py#L45

Thanks, defining the function directly worked.
But I encountered another issue later. When I run with torch.no_grad():     unmsk_patch, unmsk_idx, msk_idx, msk_matrix = model.model.encoder(datacube), I get the error "RuntimeError: Expected all tensors to be on the same device, but found at least two devices, mps:0 and cpu!". I checked datacube and all the values have 'mps:0' as device so I don't know why the issue is coming up.

I have not tested this script with MacOS devices. Try changing device="cpu" on cell 16 and see if it runs. For this size of data the model is fast even of CPU so hopefully you can run the notebook to the end with that change.

You can run it onmps fine, although I did have to change from float64 to float32 for it to work with the mps backend, and just looped through the datacube's items and moved them to mps to make it work. It did give a decent speed up compared to CPU!

Thanks, @yellowcap and @jacobbieker. I just went with cpu and it worked. It wasn't very slow for me!


Implement user identity using uPort

lock.aquire()

Given that we're focussing on ERC725, I'm assuming we can close this out?

Yes, deprecated.
On Wed, Apr 11, 2018 at 9:33 AM, Stan James<EMAIL_ADDRESS>wrote:

Given that we're focussing on ERC725, I'm assuming we can close this out?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/OriginProtocol/platform/issues/14#issuecomment-380515891,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEuxN5PXQYyTssgAeolTQKSUdtkLH1DCks5tnjBlgaJpZM4SP3wx
.

--
Cofounder of Origin http://www.originprotocol.com
Join our Telegram http://t.me/originprotocol.com


[stable/redis-ha] Add network policy

Signed-off-by: Naseem<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Copied from other charts... this implementation seen in many charts and introduced here does not allow for the case of some pods from other namespace(s) as per https://github.com/ahmetb/kubernetes-network-policy-recipes/blob/master/07-allow-traffic-from-some-pods-in-another-namespace.md#allow-traffic-from-some-pods-in-another-namespace
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

I don't think this is actually applicable as we expose all the pods via a service anyway.
This chart does not require or need pod-to-pod communication. All traffic is exposed and LB'd via a service.
@naseemkullah Can you verify whether this actually solves a problem? I think for now it's unnecessary and unnecessary bloat for the chart (Network Policies can be detrimental for some people too).
Wiling to be overwritten here by someone else though.


Chore: Update Gonzales-PE

What do the changes you have made achieve? Update the AST dep to resolve bugs.
Are there any new warning messages? no
Have you written tests? N/A
Have you included relevant documentation N/A
Which issues does this resolve? https://github.com/sasstools/sass-lint/issues/1248
Might also resolve https://github.com/sasstools/sass-lint/issues/877 and potentially others.
<DCO 1.1 Signed-off-by: TheJaredWilcurt<EMAIL_ADDRESS>

This new Gonzales release was due to a security vulnerability fix. It also includes the "custom properties" fix. https://github.com/tonyganch/gonzales-pe/pull/295#issuecomment-593304274

Coverage remained the same at 97.532% when pulling a2b16e68efe0e056f81a527a0f6c9eaade3aecb4 on TheJaredWilcurt:update-gonzales-pe into 52ccf2e1fa3e4d17d9f8f7bd748f7caf20830f30 on sasstools:develop.

Hi, any update about when this fix will get merged?


BUG: vorpal.exec never fires callback with piped commands when using promises

Looks like it affects promises only. The first command resolves, subsequent piped commands promise doesn't seem to be seen as resolved.

This issue is this block in command-instance.js
var res = fn.call(self.downstream, self.downstream.args, function () {
  self.session.completeCommand();
});

It's assuming that the command will return a callback instead of a promise. In other places, both types are accounted for. The fix is pretty simple:
var onComplete = function () {
  self.session.completeCommand();
};
var res = fn.call(self.downstream, self.downstream.args, onComplete);
if (res && res.then) {
  res.then(onComplete, onComplete);
}

Good find. Would you mind throwing in a PR for that?

Done. If you wouldn't mind doing a release after you've verified, I would appreciate it.

Thanks! :+1:
Path v1.3.27 published for you :)


Fix links for the IsFloat and IsInt validators

Currently the links are not displaying correctly and some of the rst code is showing on the page:
http://framework.zend.com/manual/current/en/modules/zend.validator.set.html

Duplicates #1464

Oh! Sorry, I don't understand how I missed that...
There still seems to be an issue with that pull request though, shouldn't the line 33 be :ref:IsInt <zend.i18n.validator.set.int>instead of:ref:IsInt <zend.i18n.validator.int> ?
Without the set the link doesn't work.

Without the set the link doesn't work.

"set" is wrong. See ac2ef1f45aefe06702b08f201f57ec67c3e1d488


unit testing with vitest

Details
i want something like this https://github.com/justinribeiro/lighthouse-jest-example but vitest with unlighthouse to test all of my pages

Hey, thanks for the suggestion.
This isn't something I'm looking to implement at this stage, community contributions more than welcome :)


Contact page UI implementation

Issue Type:
UI related
Description:
Address head line should be in center
EditText view should be improved
ScreenShots / Video:
https://user-images.githubusercontent.com/70429079/161413995-06996369-2560-48b8-bb33-2a9fa1d1e4cb.mp4

I would like to work on this issue. Please assign me

yes bro and also try to place it at the center of the joining line

I would like to work on this issue

I already fixed this issue.But Unfortunately by mistake I remove myself from the assignment .please assign me again .so I can create pull request.

Please assign me this issue under GSSOC'23.


ci: pin golang image to 1.19.4-bullseye

There's an issue caused by the 1.19.5-bullseye image: https://github.com/docker-library/golang/issues/452
This will allow CI to succeed while the underlying issue is sorted out

Codecov Report

Merging #627 (3cc6e0d) into main (b933a66) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   15.43%   15.43%
=======================================
  Files          13       13
  Lines        1600     1600
=======================================
  Hits          247      247
  Misses       1325     1325
  Partials       28       28

Flag
Coverage Δ

unittests
15.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


a0c0d65b-412d-4261-9f88-bc6453aa5a88

this is for automated testing

ed4568db-e79f-44cb-8284-4764d62eac66


GoogleUtilities repo-relative imports

Output of the scripts/change_headers.swift
The GoogleUtilities clients are updated in the subsequent #5824
scripts/change_headers.swift will be updated to a fully commented import verification step later in this series of PRs.

Merging now and will address any additional feedback in #5824


(#914) document level editor key bindings

Solve #914

@kolumb looks good to me! :+1: Thanks for the contribution!


at_c: matrix CI on multiple platforms

linux / macos
clang / gcc

To be discussed in arch

This is actually not 1 story point... because we don't run any of the actual e2e tests in the GitHub actions runners. We could run the c build steps as a sanity check, but we wouldn't be able to do much else without major changes to the e2e test environment.

For this reason, I am going to close this ticket. We haven't even committed to a standard set of builds yet for the C daemon, so any effort here is most likely pointless, and definitely time consuming.


scipy.optimize.dual_annealing can't admit parameter visit=1

scipy.optimize.dual_annealing parameters
Reproducing code example:

import numpy as np
from scipy.optimize import dual_annealing
boundsP=[(-4,4),(-4,4)] #Variable search space
maxiter=100
initial_temp=1000
visit=1.001 #The value range is (0, 3]. The value 1 is classic SA and 2 is fast SA.
accept=-5 #Default value is -5.0 with a range (-1e4, -5].
#Result for the  Peaks function
result = dual_annealing(Peack,boundsP,maxiter=maxiter, initial_temp=initial_temp, visit=visit,accept=accept,no_local_search=True)

Error message:

  File "/media/yarilis/Datos/TRABAJO/2_Pyton/2_Dif_evol_Scipy/Todos_YE_3/Validacion_Dual_Annealing/Sin título0.py", line 98, in <module>
    visit=visit,accept=accept,no_local_search=no_local_search,x0=x0)

  File "/usr/local/lib/python3.6/dist-packages/scipy/optimize/_dual_annealing.py", line 636, in dual_annealing
    visit_dist = VisitingDistribution(lower, upper, visit, rand_state)

  File "/usr/local/lib/python3.6/dist-packages/scipy/optimize/_dual_annealing.py", line 69, in __init__
    self._factor5 = 1.0 / (self._visiting_param - 1.0) - 0.5

ZeroDivisionError: float division by zero

Scipy/Numpy/Python version information:

1.4.1 1.18.1 sys.version_info(major=3, minor=6, micro=9, releaselevel='final', serial=0)

I found an easy solution just putting np.divide() instead of / in the corresponding line:
self._factor5 = np.divide(1.0 , (self._visiting_param - 1.0) ) - 0.5
################### Allow np.inf values ###################

Thanks @Yarapy . gh-13603 updates the docs for the currently correct range; gh-12384 will be kept open for investigating in more detail.

I found an easy solution just putting np.divide() instead of / in the corresponding line:

I had a brief look at this, but it doesn't seem like the right solution to propagate infs here.


Consider support for more platforms

wasmtime now has the Pulley interpreter https://github.com/bytecodealliance/wasmtime/issues/1980#issuecomment-2557607967 so it is able to run anywhere Rust runs. I have no idea how it compares with WAMR, but this could allow us to easily add support for more platforms and would be great for the downstream extism sdks.

I would really prefer to cut Wasmtime out completely if possible. But this is worth exploring.


An additional empty is restored when launching window from command line

re https://github.com/Microsoft/vscode/issues/29249

Set window.reopenWindows  to all
Launch VS Code from Spotlight/Alfred
An empty window is launched.
Open a folder from command line, a window with target folder is opened
Quit VSCode
Launch VS Code again, now three windows launch, two empty windows and a window with folder.

@rebornix that would be quite bad but I cannot reproduce this, see video below:

Are you sure you did not have dirty files in one of the windows?

I was testing against all option values so I might have some dirty state at that time. But after rebooting the machine, I can no longer reproduce this issue any more. Close it first and will reopen if I can run into this again.


fix instanceOf error in searchResults component.

already have a fix for this. just wanted a ticket for tracking.

Pull Requests:

https://github.com/Senzing/sdk-components-ng/pull/101


Drop to upload component for images

Based on react-dropzone?

yup, react-dropzone is the one we've got in streambed now


Building System doesn't work case there are space or special characters in the directory name

Petro reported that IDF didn't work inside his Mac "/Volumes/Macintosh HD (CS)/" then I suspected of spaces in the name of Volume name and then I decided to test similar thing on NuttX building system:
alan@dev:/tmp/New Space NuttX/nuttx$ ./tools/configure.sh sim:nsh
./tools/configure.sh: line 137: [: too many arguments
./tools/configure.sh: line 156: [: too many arguments
./tools/configure.sh: line 176: [: too many arguments
./tools/configure.sh: line 181: [: too many arguments
grep: /tmp/New: No such file or directory
grep: Space: No such file or directory
grep: NuttX/nuttx/tools/../boards///sim/configs/nsh/defconfig: No such file or directory
grep: /tmp/New: No such file or directory
grep: Space: No such file or directory
grep: NuttX/nuttx/tools/../boards///sim/configs/nsh/defconfig: No such file or directory
Copy files
install: target '/tmp/New Space NuttX/nuttx/tools/../Make.defs' is not a directory
Failed to copy /tmp/New Space NuttX/nuttx/tools/../boards///sim/configs/nsh/Make.defs

Having built NuttX a lot, I've had to deal with this often.  Spaces in files and directory names are typcial in the Windows enviroment.  It is not unusual at all.
Here some ways that I have dealt with it:

Enclose the path in quotes:  Like  "/tmp/New Space NuttX". That only works for local changes since bash peels off one set of quotes each time that the path appears on the bash command line.  So it does not work for pass file names that are passed around.  Look at the breakage that was done to the Cygwin build in #3799.  That STILL has not been fixed.

Quote the spaces with a backslash like:  /tmp/New\ Space\ NuttX.  I have done that with sed like:
newpath = `echo $oldpath | sed -e "s/ /\ /g"

Use a symbolic link:
ln -s "/tmp/New Space NuttX/" /tmp/NuttXSpace/"


allow to use the username for login as well

Detects if login is an email or not, validates as email or not and uses the according user table field to authenticate.

LGTM 👍


[MOD = 3.6][MC = 1.11.2][Questions about pre-generation]

Sorry, I know you have written extensive details on the usage of this mod, but there are still a couple things I'm curious about regarding the mechanics of this mod.

Does anything undesirable happen if you use the pre-generator on the same chunks multiple times?  Like does it register that it's already added buildings in that area, or does it ignore that fact and try to place more?
I'm getting a moderate amount of cascading generation lag (in pre-generation).  Does your pre-generator normally cause that, or is that more likely caused by mods I have installed that may have poor (runaway) generation code?  If the latter is true then do you know which types of terrain generation assets are the usual culprits?  Mods that add large batches of assets that overlap?  I mean, I've got the Coral reef mod that spawns in glowing coral in patches, Quark, which manipulates the placement of underground stone and adds huge underground caves/biomes.  (I'm willing to bet it's one of those two).  Better Bedrock Gen, which makes all the bedrock flat.  BOP which does a lot in and of itself.  And then the rest are just mods that add small amounts of ore here and there (probably not the cause).  Or could it be that I simply have too much crap generating? hahahaha
If you start the pre-generator and select a size without selecting a starting point, where does it start?

Of course it does not. It generates one time per one chunk population. All structures that started in specific chunk will be spawned during chunk generation. Each chunk generation always happens one time. So you can pre-generate multiple times, but any chunk in such range has already been generated it just loads into memory, not generate it again.
Go to server.properties and set max-tick-time=-1. It happens because of structpro because pasting large structures cause processing of falling gravel, sand, water, lava, mobs etc. But I'm not totally sure that everything is absolutely correct.
It starts in (0, 0) chunk

Yeah, I read just about everything in your information section.  Got the max tickrate set at -1 already... that's why I asked if it was being caused by other mods.  Might just be the amount of mods I've got generating stuff...  https://www.reddit.com/r/feedthebeast/comments/5x0twz/investigating_extreme_worldgen_lag/

I have to say that I additionally save and unload all redudant chunks each time I generate or load it to the memory, so I believe the process can be a lil bit optimized by checking if chunk has already been generated and skip it. But the main problem is why genberation start stuttering is opened.

Given how long the pre-generation process can take, having an option to "skip already generated chunks" would be great!  To your other question, I don't know, but I'm getting cascading generation, and there's a good chance that it's not your mod, but somebody else's that isn't optimised.  I might have to slowly take off mods and play with it to see if I can find the culprit.  Your mod is brilliant by the way, not being critical here at all... just want to get it working right while taking off the least amount of other mods as possible haha.

I checked out one of my previous 4097x4097 blocks (size =128 chunks radius) world pre-generation and what I realize:

Cascading generation cause some rare third-party mods, because for my mod pack with ic2, biomes o plenty et all was ok and not cascading happened. To reproduce I need list of your mods.
Generation consume server tick thread to generate and force populate chunk, so it generates (X,Z), (X+1, Z), (X, Z+1), (X+1,Z+1) blocks immidiatly so no problems caused.
Before determination that structure spawns in certain chunk starts surface roughness calibrator to detect roughness, liquid depth, biomes etc to say about spawing permitions. That cause also some chunks ahead to load, but it's not a lot. Big structures like deathstar spawns in 20 seconds that extreemly fast. And if spawn conditions not permit, next time it will recalculates much faster because all in RAM.
After some time after pre-generation starts (for me it started on ~63000/66000 chunks progress) Massive lags appears and It's because statistically one of structures with lots of sand and gravel spawned in the sky and start falling down that stutter server for a while.

Quark and Galacticraft, those are the two culprits I found thus far... I notified them.  Farseek was also posting a lot of activity during the pregen... though I don't know why I even had that mod installed (it doesn't show up as a dependency anywhere).  Let me run some more tests, I'm resorting mods at the moment.  Oh well, here's a mods list (crash report) for shits and giggles...  https://gist.github.com/Endmateria/19b081faa7ec6bfe82cd9c2203b111f4#file-crash-2017-05-06_16-24-58-server-txt

java.lang exceptions happens when you trying to stop server and thread stops asynhronous

I was in game, the server forcefully stopped itself, or in so many words... crashed.  It's done that multiple times.  I'm of the opinion that your mod, Quark, and Galacticraft don't get along hahaha.

Here's radfast's response (from Galacticraft)... https://github.com/micdoodle8/Galacticraft/issues/2689#issuecomment-299665741

I read carefully what radfas says and I can say that structpro not cause runaway worldgen even when density is crazy overcap, because of next features:
Structpro generates all structures that start in (x,z) chunk that growth only in positive axis directions (+x, +z), so you can see how appears rectangle (x,z) - (x + width, z + length) in the world. And such process not begins to populate border chunks. That means that newly generated chunks fires only direct neighbours to generate (not populate) and the process stop there. To continue the process players move forward and newly generated chunk that is not already populated populates itself and process continues.

Well, I took off some of the mods that cause cascading world gen... Coral reef and Tinker's construct.  Astral Sorcery has corrected the problem, just waiting for him to release the updated version.  Your mod alone is still getting cascading world gen during pregen though.  I'm running more tests this morning.  Here's a short log excerpt of me pre-generating a 100 chunk radius (40000 chunks) on a new world map.  In this short log, your mod has 18 hits worth of cascading world gen lag.  Could it be the structures you chose, and not necessarily the mod itself?  https://gist.github.com/Endmateria/99b4a59ebcdb10e1c0abcb2195142f4b#file-fml-server-latest-log

I saw your gist and that's totally not related to structpro.

Cascading world gen not happens except rectangle zone where schematics pasts.

You can see rectangles on edges that not cascading generation, that's forced generation by mod to check area for spawning conditions as I said before.

Yeah, this is what I got... similar.  https://ibb.co/mwFtMQ

This small squares is space that schematics required to spawn or to check spawn conditions. Everything is correct. Nothing critical, that's the way how the mod works. There is not other way to implement or improove logic.

I gotcha, makes sense.  The cascading worldgen was mainly from other mods, whom I've opened up issues with.  My major issue was with the server crashing ingame.... but that only seems to happen when you go near the edges of the world that have not been pre-generated.  Have you considered adding a world borders option to prevent the server from crashing?

Hey man, saw the options that you added to the /structpro help menu.  Very nice.  And thanks for troubleshooting all of this with me.  It's a very temperamental mod, but once you know all the rules, it works like a charm.  I would recommend specifically warning people on your webpage that the server will crash if you don't pre-gen properly (since crashing seems to be everyone's primary complaint in your issue tracker), and I also recommend telling people to put a world border around the pre-generated area.  Hopefully that will help you avoid having to address all of these concerns for someone else.  Anyways, thanks again... great mod!

Ok, so the last two times I've run the pre-generator with large sizes (1000+ chunks), I've gotten an "out of memory error" that crashes the server.  It ran for about an hour before crashing.  I've already given the server 8 gigs of ram.  Do I give it more, or is there a memory leak somewhere?  https://gist.github.com/Endmateria/02e99417a3816172e34ab9c89490c021#file-crash-2017-05-09_01-29-27-server-txt

Hmmm, seems the memory problem could've been a Forge 2294 issue.  I updated to 2296 and I'm not getting out of memory errors anymore, but they've been replaced with "tick out of sync" errors.  Here's two crashes in a row using Forge 2296.  My launch command was /spro gen size=1250 world=0 step=16 world=0 progress=241000 skip=true
https://gist.github.com/Endmateria/12b502f6011949eb62b8ee1f638d71e7#file-crash-2017-05-09_04-06-22-server-txt
https://gist.github.com/Endmateria/996f471ede9236b36c05ce5c9db6c547#file-crash-2017-05-09_10-32-33-server-txt
And here's the log leading up to the 2nd crash so you can see what was going on...
I did delete some of the OP schematics from the custom village files which is causing a null when those villages search for their pieces.... if that's gonna be a problem then I'll just delete all the custom (Autortown) village schematics.

Could the memory issue be causing the tickrate desync?  I'm watching the memory allocation for javascript in my task manager and it just keeps growing, meanwhile the generation gets slower and slower (testing at default step=32).  When this crashes, I'll test using step=16 again.

Yeah, even at step 16 the generator slowly eats up the memory till the generator is crawling (really slow)... then eventually crashes with a "TickNextTick list out of synch" error... https://gist.github.com/Endmateria/442944648b49b3264c369b668ca78228#file-crash-2017-05-09_15-53-18-server-txt

Also I get this error occasionally while generating using the "progress" feature.  If it's just getting this error because the generator is passing by a structure that it already placed that is no longer loaded into memory, then that makes sense and I'm disregard.  (only happens after using progress/resume).   https://gist.github.com/Endmateria/b5aa25206a4635db045cc2b861ef15b0#file-gistfile1-txt

I think the "java.util.ConcurrentModificationException" is someone else's mods conflicting, cuz I was still getting that error after removing your mod... so I would ignore that one.  Also, I guess the memory issue with pregenerators is a common problem... not singular to your mod.  Maybe if the step size was smaller, it wouldn't crash so much, I don't know, I'm not an expert on the subject.


[tbb] explicitly disable hwloc feature for UWP

Actually, TBB should support UWP according to https://www.intel.com/content/www/us/en/developer/articles/technical/using-intel-performance-libraries-in-universal-windows-drivers.html, so I will create an issue for TBB team to fix it.
Once it's fixed, hwloc should still be disabled for UWP as it does not support this platform.

[X] Changes comply with the maintainer guide
[ ] SHA512s are updated for each updated download
[X] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

All features passed with following triplets:
x86-windows
x64-windows


Single cell style

Currently rows can have highlights & text color and cells can be formatted either as a date, currency, &c — but is there any easy way of highlighting / stylizing single cells?

This looks like it no longer works in the current 1.5rc1.  Is this something that will get added back in?

@nbsynch please look at https://github.com/vitmalina/w2ui/issues/1387 and https://github.com/vitmalina/w2ui/issues/1351#issuecomment-255384351
Cheers =)

@mpf82
Thanks for your quick reply, it works now.


Ubuntu 14.04.02 vmhgfs compile failure (VMwareTools-9.9.2-2496486)

Hello!
I cannot compile the latest VMwareTools-9.9.2-2496486 (neither patched not original) on Ubuntu 14.04.02 with latest  Linux kernel (3.13.0-46). It raises the following error:
 from /tmp/modconfig-qqjwHn/vmhgfs-only/inode.c:29:
/tmp/modconfig-qqjwHn/vmhgfs-only/inode.c: In function ‘HgfsPermission’:
include/linux/kernel.h:793:27: error: ‘struct dentry’ has no member named ‘d_alias’
  const typeof( ((type *)0)->member ) *__mptr = (ptr); \

The complete output can be found here https://gist.github.com/eborshch/cd6f430bf6771e33e5cf. I've noticed that there is a recent fix (https://github.com/rasa/vmware-tools-patches/pull/27) for the similar issue, though it does not solve this particular issue as it has been already merged into the master when I've tried it.
Any hints?
Thank you in advance!
Best,
Eugene
p.s. it looks like this issue has been already reported to VMWare https://communities.vmware.com/message/2477575

I'm looking into this now, and will let you know what I discover.

Same issue for me on Linux 3.2.0-4-amd64 #1 SMP Debian 3.2.65-1+deb7u2 x86_64 GNU/Linux
I try to use your patch install but the problem still persist.
(I already commented for another issue)

Ok so I succeed with hgfs installation.
I uncompressed the "vmware-tools-distrib/lib/modules/source/vmhgfs.tar" with "tar cvf" command
then I used this command in my vim editor : ":%s/d_alias/d_u.d_alias/g" to replace any d_alias with his own new structure.
And finally just compress back the folder with : "tar cvf vmhgfs.tar vmhgfs-only" command
I restart the installer from the vmware-tools-distrib folder and now I can access to my folder.
The VMwareTools version is : VMwareTools-9.9.2-2496486.tar.gz
Hope It could help some of you :)

I have the same here problem  Kubuntu 14.04 (3.13.0-46-generic) & VMWare Workstation 11.1 & VMwareTools-9.9.2-2496486.tar.gz
With the previous kernel 3.13.0-45 & VMwareTools-9.9.0 hgfs was working just fine (having applied the patch back in December).

@vschoener thanks a bunch! It works!

@eborshch You're welcome, I forgot to mention the file to edit "inode.c" But you found out :)

@vschoener

I used this command in my vim editor : ":%s/d_alias/d_u.d_alias/g" to replace any d_alias with his own new structure. The file to edit is 'inode.c'

Can you please elaborate with his own new structure ? What string did you replace d_alias with ?

I replaced d_alias to d_u.d_alias because this variable has been moved the "dentry" structure.

Following @vschoener instructions worked for me on Ubuntu 14.10.

Thanks @vschoener - it worked great!
FYI I did it on Kubuntu 14.10 x64 with kernel 3.16.0-31-generic.

@vschoener thanks for the tip and it works!

Thank you. This fixes shared folders for me on Ubuntu 14.04 with VMwareTools-9.9.0-2304977 on Workstation 11.0.0.

Thanks you all, I'm glad this fix is helping everyone :)

It works fine for me too.
I run this
#!/bin/sh -x
cd /usr/lib/vmware-tools/modules/source
tar xf vmhgfs.tar
grep -q d_u.d_alias vmhgfs-only/inode.c && echo "already patched" && exit 0
sed -i -e s/d_alias/d_u.d_alias/ vmhgfs-only/inode.c
cp -p vmhgfs.tar vmhgfs.tar.orig
tar cf vmhgfs.tar vmhgfs-only
vmware-config-tools.pl -d -m
NOTE: this makes the tools incompatible with older kernel versions, i.e. 3.13.0-45.

@eborshch: How did you get kernel 3.13.0, as 3.16.0 is the default, per https://wiki.ubuntu.com/TrustyTahr/ReleaseNotes#Linux_kernel_3.16 .
Also, I've installed both
http://releases.ubuntu.com/trusty/ubuntu-14.04.2-server-amd64.iso and
http://cdimage.ubuntu.com/ubuntu-server/trusty/daily/current/trusty-server-amd64.iso
using VMwareTools-9.9.2-2496486.tar.gz, and always get kernel 3.16.0 and did not encounter any issues.

This fix still didn't work for me on Ubuntu 12.02 with linux-generic-lts-trusty (kernel 3.13.0-46) and I had to just hack the patch by adding a custom patch like this:
cat > patches/vmhgfs/99-vmhgfs-inode-hack-hack-bodge.patch   <<EOF
--- vmhgfs-only/inode.c.oirg    2015-03-06 14:56:04.344130628 +0000
+++ vmhgfs-only/inode.c 2015-03-06 14:56:14.583830707 +0000
@@ -1922,11 +1922,7 @@
                            p,
 #endif
                            &inode->i_dentry,
-#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 18, 1) && !defined(__GENKSYMS__) && !defined(D_ALIAS_IS_A_MEMBER_OF_UNION_D_U)
-                           d_alias) {
-#else
                            d_u.d_alias) {
-#endif
          int dcount = hgfs_d_count(dentry);
          if (dcount) {
             LOG(4, ("Found %s %d \n", dentry->d_name.name, dcount));
@@ -1979,11 +1975,7 @@
       /* Find a dentry with valid d_count. Refer bug 587879. */
       list_for_each(pos, &inode->i_dentry) {
          int dcount;
-#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 18, 1) && !defined(__GENKSYMS__) && !defined(D_ALIAS_IS_A_MEMBER_OF_UNION_D_U)
-         struct dentry *dentry = list_entry(pos, struct dentry, d_alias);
-#else
          struct dentry *dentry = list_entry(pos, struct dentry, d_u.d_alias);
-#endif
          dcount = hgfs_d_count(dentry);
          if (dcount) {
             LOG(4, ("Found %s %d \n", (dentry)->d_name.name, dcount));
EOF

With this done I get teh vmhgfs module compiled and loaded.

@ashb That's weird. What VMware Tools version did you use?

I thought it was 9.6.2, but vmware-toolbox-cmd --version says 9.9.2 so I'm trying again.

@vschoener
So just replace the 'd_alias' will be fine? Do I have to patch the code using the patch provided in this repo first?
Many thanks.

@rasa It seems that Ubuntu team has backported some features from 3.17+ to LTS kernels (3.13.0-46, 3.16.0-31 and probably some other). I can confirm that applying the patch without a check for 3.18.1 kernel works for me on 3.13.0-46 (3.13.0-45 worker well without the patch).

@cty12 I didn't patch anything according to the available patch here.
I just replaced the 'd_alias' and everything works fine.
(My kernel is 3.2.X)

Fixed in https://github.com/rasa/vmware-tools-patches/commit/192e3b78b94cfa872d45043d671fe0cb4572b714#

Confirmed that 192e3b7 works. Thank you for the work @rasa and all.
3.13.0-46-generic
Host: Ubuntu 14.04 64b
Guest: Ubuntu 12.04 64b

@vschoener, you're great! Thank you for saving my Ubuntu 14.10 LTS!

Thank you @vschoener, works great for
VMwareTools-9.9.2-2496486 for
guest: Ubuntu 14.10
under VMware Workstation for Windows v<IP_ADDRESS>6824

@vschoener -
Many thanks for this ... your fix saved me time ... and a headache ! ...
This fix works perfectly for
VMware Tools <IP_ADDRESS>837 (build-1688356)
guest Ubuntu 12.04.5 LTS
with kernel 3.13.0-48-generic x86_64
under VMware Player 6.0.4 build-2249910 for Windows 7 Ultimate

@vschoener -
Further note ...
This fix works also works perfectly for:
VMware Tools <IP_ADDRESS>837 (build-1688356)
guest Ubuntu 14.04.2 LTS (trusty)
with kernel 3.13.0-48-generic x86_64
under VMware Player 6.0.4 build-2249910 for Windows 7 Ultimate
... thanks again!

@tuongngoc thx! Yout shell script works for me.

@tuongngoc: many thanks! Your shell script worked for me too! Great job!

@tuongngoc Thanks! The script worked fine for me too!

Is everyone implying that master is broken?

@vschoener
Great stuff. Fix works fine! Shame on VMWare for not fixing this immediately. Really: 2 replaces in one inode.c file?

@jverhoeven : You're welcome :) Indeed, it's shame to let this broken.. But now there is a great community to fix the problem and make people happy :)

@vschoener  Thanks a lot. It helped!

Hopefully this works for me when I get home.  Have to reinstall my entire VM after screwing up the boot trying to fox this problem.  Using Ubuntu 15.04

Thanks a lot! It worked for me! I was getting crazy!!

Using lubuntu 14.04.2 and replacing d_alias does not work for me.

@tuongngoc and @vschoener  Your tweak worked great for me with this guest setup
$ uname -a
Linux desktop 3.2.0-85-generic #122-Ubuntu SMP Tue May 26 16:15:25 UTC 2015 i686 i686 i386 GNU/Linux
Thanks!

I am glad I found this thread of discussion. It worked for me.

Happened the same to me today.
My configurations:
Windows 7 Host
Ubuntu 14.04 w/ 3.13.0-52 kernel
Vmware 10.0.6 with Tools 9.6.5
I had the "d_alias" issue but the patches on the "patches" directory didn't solve the problem.
Instead I got a new problem saying that there was a problem with a structure called DENTRY.
I ended up looking for a patch that had to do with the DENTRY struct and copied to the same patch directory with a name that matched my vmware tools version. I don't know how if that's the proper way to do it but it appears to be working now.
This is my two cents just in case anyone bumps into the same problem.
cd patches/vmhgfs
cp -p 16-vmhgfs-f_dentry-kernel-3.19.0-15-tools-9.6.2.patch 16-vmhgfs-f_dentry-kernel-3.13.0-15-tools-9.6.5.patch

And I can now see the windows drive mounted at /mnt
Thanks for all the hard work!!

Wow. Running
cp -p 16-vmhgfs-f_dentry-kernel-3.19.0-15-tools-9.6.2.patch 16-vmhgfs-f_dentry-kernel-3.13.0-15-tools-9.6.5.patch

should not have fixed your issue as the filenames are meaningless, other than the sort order. I have no idea how that fixed your issue.

Hi @rasa I thought that was what solved my problem but It seems that I was wrong. I just assumed that the script would patch depending on the vmware tools version so I decided to copy that patch. I was in a rush trying to make it work so I might have not payed full attention to it.
I see that you're the owner of the project so feel free to disregard/delete my comment if you find it inappropriate. Anyway, thanks for sharing this.

I ran into this issue today with the following:
Ubuntu 12.04 w/ 3.5.0-41
VMware Fusion 7.1.2 and Tools 9.9.3-2759765
The included dalias patches weren't being applied because VMware's moved the relevant d_alias lines to a #define hgfs_d_alias() statement which caused shared/autoconf/dalias.c to fail to be patched.
I created a new patch, I've pasted it below so hopefully someone else will get some use out of it. It can probably be rewritten to just replace the file outright without caring about old contents, but it works for me as is...
patches/vmhgfs/18-vmhgfs-d_alias-kernel-3.18.1-tools-9.9.3.patch
diff -uwNr vmhgfs-only.orig/shared/autoconf/dalias.c vmhgfs-only/shared/autoconf/dalias.c
--- vmhgfs-only.orig/shared/autoconf/dalias.c   1969-12-31 16:00:00.000000000 -0800
+++ vmhgfs-only/shared/autoconf/dalias.c        2015-03-18 19:14:44.751231007 -0700
@@ -1,45 +1,21 @@
 /*********************************************************
- * Copyright (C) 2015 VMware, Inc. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License as published by the
- * Free Software Foundation version 2 and no later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
- * or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
- * for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ * Copyright (C) 2015 Ross Smith II. MIT Licensed.
  *
  *********************************************************/

 #include "compat_version.h"
 #include "compat_autoconf.h"

-#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 19, 0)
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 2, 0)
 #include <linux/dcache.h>
-#include <linux/list.h>

 /*
- * After 3.19.0, the dentry d_alias field was moved. Fedora
- * backported this behavior into a 3.18.0 kernel.
+ * After 3.18.1, the dentry d_alias field was moved to struct d_u.
  *
  * This test will fail on a kernel with such a patch.
  */
 void test(void)
 {
-   struct dentry aliasDentry;
+   struct dentry dentry;

-   INIT_HLIST_NODE(&aliasDentry.d_alias);
+   dentry.d_alias.next = NULL;
 }
-
-#else
-/* Intentionally passes for earlier than 3.9.0 kernels as d_alias is valid. */
-#endif
-#else
-#error "This test intentionally fails on 3.19.0 or newer kernels."
-#endif

I added your patch in https://github.com/rasa/vmware-tools-patches/commit/cb6bce50f6b3a4e9e8ccc104fca405b0a1dedcdc, but I haven't tested it yet.

@tuongngoc Thanks! Used your script to patch debian 8.1.0, VMwareTools-9.9.2-2496486.tar.gz
I had to re-run vmware-config-tools.pl manually to re-select hgfs option, compiled fine the second time.

@asoc - Thanks, your patch to dalias.c also works for debian wheezy (3.2.0-4-amd64) and VMwareTools <IP_ADDRESS>419 (build-2759765)

@vschoener - thanks for the sinple solution - workes for me with
Windows 7 (Host)
Xubuntu 14.04.03 LTS (Guest)
Kernel 3.13.0-65-generic
VMWare 10.0.3
VMWareTools <IP_ADDRESS>837

@vschoener  thanks a lot, it works !

You're welcome :)


Breakpoints fail to be hit when 'Native Code Debugging' is enabled.

Describe the bug

Python installed from VS.
Steps to Reproduce

Create a Python Application project, add simple Python code.

from math import cos, radians

# Create a string with spaces proportional to a cosine of x in degrees
def make_dot_string(x):
	rad = radians(x)                             # cos works with radians
	numspaces = int(20 * cos(radians(x)) + 20)   # scale to 0-40 spaces
	st = ' ' * numspaces + 'o'                   # place 'o' after the spaces
	return st

def main():
	for i in range(0, 1800, 12):
		s = make_dot_string(i)
		print(s)
main()

Enable "Native Code Debugging" in project settings / debug page.
Set breakpoint and start debugging.

Expected behavior
Breakpoint should be hit.
Additional context and screenshots
Breakpoint can not be hit.

Logs

Output for Debug in the Output panel

'python.exe' (Win32): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\python.exe'. Symbols loaded.
'python.exe' (Win32): Loaded 'C:\Windows\System32\ntdll.dll'.
'python.exe' (Win32): Loaded 'C:\Windows\System32\kernel32.dll'.
'python.exe' (Win32): Loaded 'C:\Windows\System32\KernelBase.dll'.
'python.exe' (Win32): Loaded 'C:\Windows\System32\ucrtbase.dll'.
'python.exe' (Win32): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\vcruntime140.dll'.
'python.exe' (Win32): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\python39.dll'. Symbols loaded.
'python.exe' (Win32): Loaded 'C:\Windows\System32\ws2_32.dll'.
'python.exe' (Win32): Loaded 'C:\Windows\System32\version.dll'.
'python.exe' (Win32): Loaded 'C:\Windows\System32\rpcrt4.dll'.
'python.exe' (Win32): Loaded 'C:\Windows\System32\msvcrt.dll'.
'python.exe' (Win32): Loaded 'C:\Windows\System32\advapi32.dll'.
'python.exe' (Win32): Loaded 'C:\Windows\System32\sechost.dll'.
'python.exe' (Win32): Loaded 'C:\Windows\System32\bcrypt.dll'.
'python.exe' (Win32): Loaded 'C:\Program Files\Microsoft Visual Studio\2022\Preview\Common7\IDE\Extensions\Microsoft\Python\Core\Microsoft.PythonTools.Debugger.Helper.x64.dll'. Symbols loaded.
'python.exe' (Python): Loaded ''. Module was built without symbols.
'python.exe' (Win32): Loaded 'C:\Windows\System32\cryptsp.dll'.
The thread 13480 has exited with code<PHONE_NUMBER> (0x6a9f0000).
'python.exe' (Win32): Loaded 'C:\Windows\System32\rsaenh.dll'.
'python.exe' (Win32): Loaded 'C:\Windows\System32\cryptbase.dll'.
'python.exe' (Win32): Loaded 'C:\Windows\System32\bcryptprimitives.dll'.
'python.exe' (Python): Loaded '<frozen importlib._bootstrap>'. Module was built without symbols.
'python.exe' (Python): Loaded '<frozen importlib._bootstrap_external>'. Module was built without symbols.
'python.exe' (Python): Loaded '<frozen zipimport>'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\encodings\__init__.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\codecs.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\encodings\aliases.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\encodings\utf_8.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\encodings\cp1252.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\encodings\latin_1.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\io.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\abc.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\site.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\os.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\stat.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\_collections_abc.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\ntpath.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\genericpath.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\_sitebuiltins.py'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\Lib\_bootlocale.py'. Module was built without symbols.
'python.exe' (Python): Loaded '<string>'. Module was built without symbols.
'python.exe' (Python): Loaded 'C:\Users\vting\source\repos\PythonApplication1\PythonApplication1\PythonApplication1.py'. Module was built without symbols.

This is a dupe of https://github.com/microsoft/PTVS/issues/6900


Besu fails to create db if --data-path is a symlink and there is no existing db

➜  eth mkdir /mnt/eth3/besu-symlink-test
➜  eth ln -s /mnt/eth3/besu-symlink-test besu-symlink
➜  eth ~/Downloads/merge-testnets/ropsten-beacon-chain/besu/build/install/besu/bin/besu --data-path=/home/seamonkey/eth/besu-symlink
2022-07-01 20:09:51.676-04:00 | main | INFO  | Besu | Using LibEthPairings native alt bn128
2022-07-01 20:09:51.677-04:00 | main | INFO  | Besu | Using the native implementation of the signature algorithm
2022-07-01 20:09:51.680-04:00 | main | INFO  | Besu | Starting Besu version: besu/v22.7.RC1-dev-043191a4/linux-x86_64/openjdk-java-11
2022-07-01 20:09:51.962-04:00 | main | INFO  | Besu | Engine API authentication enabled without key file. Expect ephemeral jwt.hex file in datadir
2022-07-01 20:09:51.964-04:00 | main | INFO  | Besu | Static Nodes file = /home/seamonkey/eth/besu-symlink/static-nodes.json
2022-07-01 20:09:51.965-04:00 | main | INFO  | StaticNodesParser | StaticNodes file /home/seamonkey/eth/besu-symlink/static-nodes.json does not exist, no static connections will be created.
2022-07-01 20:09:51.965-04:00 | main | INFO  | Besu | Connecting to 0 static nodes.
2022-07-01 20:09:51.967-04:00 | main | INFO  | Besu | Security Module: localfile
2022-07-01 20:09:51.976-04:00 | main | INFO  | RocksDBKeyValueStorageFactory | No existing database detected at /home/seamonkey/eth/besu-symlink. Using version 1
Failed to retrieve the RocksDB database meta version: /home/seamonkey/eth/besu-symlink

To display full help:
besu [COMMAND] --help
➜  eth

Thank you for reporting the issue. We will look into it.

I thought I'd take a look a this and it looks like Java document the behaviour of Files.createDirectories() as throwing FileAlreadyExistsException if the directory exists but is not a directory: https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#createDirectories
The discussion in https://bugs.openjdk.org/browse/JDK-8130464 confirms that a symlink to a directory is considered "not a directory" and as such a FileAlreadyExistsException is expected behaviour.
I've raised PR https://github.com/hyperledger/besu/pull/5453 which resolves the issue on my system.


Implement windows installer

What happened (or feature request):
We need a windows installer. NSIS is quite popular, and can be executed from Linux or macOS, so can be integrated into our CI system.
What you expected to happen:
How to reproduce this:
Version: Please include the output of ddev version, docker version and the project's .ddev/config.yaml.
Anything else do we need to know:
Related source links or issues:
Please use a complexity rating of 1-5 (5 is high) for a feature request. (High complexity implies more PR planning)

Added this to v0.18.0 milestone, it's close enough to workable already that we should be able to do it.


Azure SQL - SQL Lab Query Error

Make sure these boxes are checked before submitting your issue - thank you!

[x ] I have checked the superset logs for python stacktraces and included it here as text if any
[x ] I have reproduced the issue with at least the latest released version of superset
[x ] I have checked the issue tracker for the same issue and I haven't found one similar (see notes below)

Superset version
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Superset 0.18.5
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

mssql+pyodbc==4.0.17
Database is Azure hosted database
Expected results
When executing a query in the SQL Editor against a successfully added table, I expect to see the results of the query and no error.
Actual results
HTML formatted stacktrace appears in the results tab below the query editor when selecting from dbo.CashOperations.

HTML formatted error appears in the results tab below the query editor when selecting from CashOperations.

Full stacktrace from server when executing the dbo.CashOperations query.
2017-07-04 06:05:52,677:INFO:root:[stats_logger] (incr) sql_json
2017-07-04 06:05:52,679:INFO:root:Parsing with sqlparse statement SELECT TOP 100 [Id],
           [Asset],
           [ClientId],
           [DateTime],
           [Volume]
FROM dbo.CashOperations
2017-07-04 06:05:52,750:INFO:root:Triggering query_id: 26
2017-07-04 06:05:52,755:INFO:root:Parsing with sqlparse statement SELECT TOP 100 [Id],
           [Asset],
           [ClientId],
           [DateTime],
           [Volume]
FROM dbo.CashOperations
2017-07-04 06:05:52,794:INFO:root:Set query to 'running'
2017-07-04 06:05:52,847:INFO:root:Running query:
SELECT TOP 100 [Id],
           [Asset],
           [ClientId],
           [DateTime],
           [Volume]
FROM dbo.CashOperations
2017-07-04 06:05:52,847:INFO:root:SELECT TOP 100 [Id],
           [Asset],
           [ClientId],
           [DateTime],
           [Volume]
FROM dbo.CashOperations
2017-07-04 06:05:52,850:INFO:root:Handling cursor
2017-07-04 06:05:52,854:INFO:root:Fetching data: {u'changedOn': datetime.datetime(2017, 7, 4, 6, 5, 52, 758616), u'tempTable': u'', u'userId': 1, u'executedSql': u'SELECT TOP 100 [Id],\n           [Asset],\n           [ClientId],\n           [DateTime],\n           [Volume]\nFROM dbo.CashOperations', u'ctas': False, u'tab': u'Untitled Query', u'sqlEditorId': u'BkYvKs_4-', u'id': u'Syjte3_4Z', u'changed_on': '2017-07-04T06:05:52.758616', u'rows': None, u'endDttm': None, u'limit_reached': False, u'state': u'running', u'progress': 0, u'schema': u'dbo', u'dbId': 2, u'errorMessage': None, u'db': u'jasonwallet', u'user': u'admin', u'sql': u'SELECT TOP 100 [Id],\r\n           [Asset],\r\n           [ClientId],\r\n           [DateTime],\r\n           [Volume]\r\nFROM dbo.CashOperations', u'startDttm': Decimal('1499148352702.784912'), u'limit': 1000000, u'serverId': 26, u'resultsKey': None}
2017-07-04 06:05:52,859:ERROR:root:Shape of passed values is (1, 100), indices imply (5, 100)
Traceback (most recent call last):
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/superset/sql_lab.py", line 91, in get_sql_results
    ctask, query_id, return_results, store_results)
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/superset/sql_lab.py", line 210, in execute_sql
    list(data), columns=column_names))
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/pandas/core/frame.py", line 330, in __init__
    copy=copy)
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/pandas/core/frame.py", line 483, in _init_ndarray
    return create_block_manager_from_blocks([values], [columns, index])
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/pandas/core/internals.py", line 4303, in create_block_manager_from_blocks
    construction_error(tot_items, blocks[0].shape[1:], axes, e)
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/pandas/core/internals.py", line 4280, in construction_error
    passed, implied))
ValueError: Shape of passed values is (1, 100), indices imply (5, 100)
2017-07-04 06:05:52,860:INFO:root:[stats_logger] (incr) error_sqllab_unhandled
[2017-07-04 06:05:52,908] ERROR in app: Exception on /superset/sql_json/ [POST]
Traceback (most recent call last):
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/flask_appbuilder/security/decorators.py", line 52, in wraps
    return f(self, *args, **kwargs)
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/superset/models/core.py", line 759, in wrapper
    value = f(*args, **kwargs)
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/superset/views/core.py", line 2055, in sql_json
    if data.get('status') == QueryStatus.FAILED:
AttributeError: 'NoneType' object has no attribute 'get'
Exception on /superset/sql_json/ [POST]
Traceback (most recent call last):
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/flask_appbuilder/security/decorators.py", line 52, in wraps
    return f(self, *args, **kwargs)
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/superset/models/core.py", line 759, in wrapper
    value = f(*args, **kwargs)
  File "/home/jasonx/venv/local/lib/python2.7/site-packages/superset/views/core.py", line 2055, in sql_json
    if data.get('status') == QueryStatus.FAILED:
AttributeError: 'NoneType' object has no attribute 'get'

Steps to reproduce

Add database to Superset successfully
Add table to Superset successfully
Select the database, schema and table from the query options on the left of the SQL Lab (columns of table load successfully)
Run preview query

I found a thread referencing this issue on a Google group here however it seemed to reference an earlier version of Superset (0.17.5). The responder mentionss "for Azure we currently don't have an entry for it in the docs as and in the module db_engine_specs.py where we specify specific logic or configuration that Superset requires" however there is a MssqlEngineSpec(BaseEngineSpec) class.
Curious if this is indication there is no support of if this is an issue. It should be noted I can create visualization slices with no errors using the same datasource.

I think the issue here is that sql_lab.get_sql_results should raise again the exception after doing the cleanup so that the callers can handle the failure too. Then i have no clue for the pandas exception though.


chore: Use prefix op_ for every instruction in avm_trace.hpp

Benchmark results
Metrics with a significant change:

proof_construction_time_sha256_30_ms (16): 1,774 (+28%)
avm_simulation_time_ms (Token:mint_public): 627 (+894%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 60.1 (-71%)
app_circuit_proving_time_in_ms (AuthRegistry:set_authorized (avm)): 1,581 (+16%)
app_circuit_proving_time_in_ms (FPC:pay_refund (avm)): 8,757 (-22%)
protocol_circuit_witness_generation_time_in_ms (root-rollup): 72.2 (-36%)
protocol_circuit_proving_time_in_ms (private-kernel-tail): 45,626 (-19%)
protocol_circuit_proving_time_in_ms (private-kernel-tail-to-public): 84,590 (-19%)
protocol_circuit_proving_time_in_ms (root-parity): 34,023 (-17%)
protocol_circuit_proving_time_in_ms (public-kernel-teardown): 40,015 (-17%)
protocol_circuit_proving_time_in_ms (root-rollup): 19,650 (-21%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_30_ms
11,401 (-1%)
3,096
:warning: 1,774 (+28%)
1,557 (-6%)
1,462

proof_construction_time_sha256_100_ms
43,968 (-1%)
11,784
5,476 (+1%)
5,446 (+1%)
5,359

proof_construction_time_poseidon_hash_ms
79.0
34.0
34.0
58.0 (+2%)
88.0 (+1%)

proof_construction_time_poseidon_hash_30_ms
1,518 (-1%)
415 (-1%)
200
220
267

proof_construction_time_poseidon_hash_100_ms
5,753 (-1%)
1,559 (-1%)
723 (+1%)
781
796

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,464
9,456
9,452

l1_rollup_execution_gas
610,285
610,277
610,273

l2_block_processing_time_in_ms
758 (+1%)
1,413 (+1%)
2,706

l2_block_building_time_in_ms
25,199
50,633
99,088

l2_block_rollup_simulation_time_in_ms
25,198
50,633
99,088

l2_block_public_tx_process_time_in_ms
21,648
46,881
95,354

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
7,039
9,861

node_database_size_in_bytes
12,157,008
16,121,936

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms
bytecode_size_in_bytes

GasToken:_increase_public_balance
70.4 (+3%)
13,873

GasToken:set_portal
16.5 (-3%)
3,495

Token:constructor
93.1 (+1%)
24,207

FPC:constructor
64.4 (-2%)
13,893

GasToken:mint_public
53.0 (+1%)
10,241

Token:mint_public
:warning: 627 (+894%)
19,216

Token:assert_minter_and_mint
:warning: 60.1 (-71%)
13,034

AuthRegistry:set_authorized
31.5 (-2%)
7,869

FPC:prepare_fee
146 (-27%)
15,187

Token:transfer_public
37.1 (+6%)
31,425

FPC:pay_refund
137 (+5%)
20,080

Benchmarking:increment_balance
2,674
15,465

Token:_increase_public_balance
56.1
15,089

FPC:pay_refund_with_shielded_rebate
148
21,167

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.146 (-6%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.4 (+1%)
16.8 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.602 (+1%)
0.516 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
48.5
76.4 (+1%)
131
244
469

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.496
0.468 (+1%)
0.450
0.442
0.438

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
59.9 (+1%)
113 (+1%)
182
352
694

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.507 (+1%)
0.507 (+1%)
0.483
0.476
0.475

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
73.3 (+1%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
133
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.522 (+1%)
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
85,672
670,983

Transaction size based on fee payment method
| Metric |  |
| - |  |


Add Unison 3rd party repo to CHANGES.md

Changes

Checklist

[x] Added markup tests, or they don't apply here because...
[x] Updated the changelog at CHANGES.md

https://github.com/highlightjs/highlightjs-unison
404

Right, so it was my understanding that once the project is hosted (see #4004) this would be good to go. Please let me know if I need to do something differently.


Importing library?

Hi - I've followed the instructions here exactly and the project is not compiling for me - gradle is building without errors (meaning it's pulling in the library), but the project isn't finding it at all:

Every other repo I use works fine. Thoughts?

Hi, can you please share your app's build.gradle?
It should look like this:
apply plugin: 'com.android.application'

repositories{
    maven { url "https://jitpack.io" }
}

android {
    compileSdkVersion 23
    buildToolsVersion "23.0.2"

    defaultConfig {
        applicationId "com.github.rubensousa.bottomsheetbuilder.sample"
        minSdkVersion 14
        targetSdkVersion 23
        versionCode 1
        versionName "1.0"
    }
    buildTypes {
        release {
            minifyEnabled false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
    }
}

dependencies {
    compile fileTree(dir: 'libs', include: ['*.jar'])
    compile 'com.android.support:appcompat-v7:23.2.0'
    compile 'com.android.support:design:23.2.0'
    compile 'com.github.rubensousa:BottomSheetBuilder:0.3'
}

Thanks. I ended up cleaning and rebuilding and that fixed it. Silly Android Studio! Sorry for the false alarm!

On Mar 23, 2016, at 6:13 PM, Rúben Sousa<EMAIL_ADDRESS>wrote:
Hi, can you please share your app's build.gradle?
It should look like this:
apply plugin: 'com.android.application'
repositories{
maven { url "https://jitpack.io" }
}
android {
compileSdkVersion 23
buildToolsVersion "23.0.2"
defaultConfig {
    applicationId "com.github.rubensousa.bottomsheetbuilder.sample"
    minSdkVersion 14
    targetSdkVersion 23
    versionCode 1
    versionName "1.0"
}
buildTypes {
    release {
        minifyEnabled false
        proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
    }
}

}
dependencies {
compile fileTree(dir: 'libs', include: ['*.jar'])
compile 'com.android.support:appcompat-v7:23.2.0'
compile 'com.android.support:design:23.2.0'
compile 'com.github.rubensousa:BottomSheetBuilder:0.3'
}
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

I'm glad you fixed it :)


Temporarily build colcon-lcov-result from source

See https://github.com/colcon/colcon-lcov-result/pull/30

This won't be necessary once https://github.com/colcon/colcon-lcov-result/issues/31 is resolved.

https://github.com/colcon/colcon-lcov-result/issues/31 has been resolved; colcon-lcov-result version 0.5.2 is available, so we don't need this anymore.


Remove nextPageURL from OMRS REST API

Is there an existing issue for this?

[X] I have searched the existing issues

Please describe the new behavior that that will improve Egeria
We are going to remove the nextPageURL from all paged API responses. This feature is not working at the moment since it is not completely implemented and requires more attention.
It not used and it is not on the priority list so we will remove it and not leave dead code behind.
Alternatives
/
Any Further Information?
Related work #6215
Would you be prepared to be assigned this issue to work on?

[X] I can work on this

Fixed with #6215


new multi agent  flow with terminate agent

Better for prompts where user is only asking for the code but not for the execution.

Now GroupManager decides whether code execution is needed or not based on # execution: VALUE tag coming from code generator agent.

Now Group manager has capability of terminating the chat as soon as user request is met. It's done by selecting the next agent as 'terminate_agent'.

This termination process can be extended to detecting repetitive errors in the agents' conversation. If Group manager decides that there has been repetitive/unsolvable errors in the chat history, it can decide to terminate the chat.

Based on current h2ogpte agents pytest, it shows similar results to the other agent types. The most distinctive success comes with the question "Write a code to show an image in matplotlib.  Do not execute any code." Because this new flow is the only flow that does not even call 'code_execution_agent'.

[ ] testing

Write a code to show an image in matplotlib. Do not execute any code. works normally for the 2 agent case.

Write a code to show an image in matplotlib. Do not execute any code. works normally for the 2 agent case. It does not execute the code.

Yeah, but, with 2agent, the code execution agent is called anyways like in this example: (even code generation is called once more though it's not needed)
2agent
https://github.com/user-attachments/assets/48ee5cd5-8533-40ef-a6c4-8052f7c41e0f
I'm aiming not even calling code_executor agent with the new flow (because # execution: false information is out there anyway, thought the manager could make use of it during agent selection)
PR multiagent
https://github.com/user-attachments/assets/7276743c-89db-4c8d-b4f7-611e46706994


get_manifest should handle when response is None

OSBS-8600

Signed-off-by: Robert Cerven<EMAIL_ADDRESS>Maintainers will complete the following section:

[x] Commit messages are descriptive enough
[x] "Signed-off-by:" line is present in each commit
[x] Code coverage from testing does not decrease and new code is covered
[x] JSON/YAML configuration changes are updated in the relevant schema
[x] Changes to metadata also update the documentation for the metadata
[x] Pull request includes link to an osbs-docs PR for user documentation updates
[x] New feature can be disabled from a configuration file

Waiving feature togle and docs PR requirements. Bug fixing internal change

rn updated: get_manifest should handle when response is None


Use BUILD_TEST CMake option to allow skipping building all tests

Is your feature request related to a problem? Please describe.
It'd be nice to have a single option to skip building all tests.
Describe the solution you'd like
Luckily CMake CTest module has already the solution: the BUILD_TESTING option.  You only need to actually use it.

For what is worth, my troubles are solved by #5697, but I still think that a general (and standard) option may be useful next to more piecemeal options like RDK_BUILD_CPP_TESTS and RDK_TEST_MULTITHREADED.

There’s only one option which actually changes what is built: RDK_BUILD_CPP_TESTS
So I’m not sure what benefit this would bring

I’m closing this because I think the existing option does what this requests. Please reopen if I have missed something


Unable to configure Kibana visualization with Jaeger CR (production strategy) using ElasticSearch as persistence

Latest ElasticSearch operator supports Kibana visualization also, no placeholder to configure currently. Examples or steps needed.
Environment: OCP 4.5
Expected behavior: Kibana instance created successfully and connected to Elastic instance and traces visible in KIBANA UI
NO configuration available to pass kibana parameters in Jaeger CR Instance.
# This CR deploys Jaeger and Elasticsearch
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: simple-prod
spec:
  strategy: production
  storage:
    type: elasticsearch
    elasticsearch:
      nodeCount: 1
      resources:
        requests:
          cpu: 200m
          memory: 1Gi
        limits:
          memory: 1Gi

The Jaeger Operator only provisions an Elasticsearch instance using the ECL operator. For anything fancier, you'll need to provision the ES instance yourself and point your Jaeger CR to it.

ok. Thanks. Any tentative date of having this feature integrated in near future?

No.

ok. Thanks for the confirmation. Any idea of supporting dashboards in JAEGER UI?

There was a discussion about it during the last bi-weekly, but there are no concrete plans at the moment that I'm aware of.

Thanks..Yes you got my question correct, it was on building dashboards for tracing.
That's one of the reasons we wanted to check the feasibility of integrating Kibana to customize dashboards.