contrail-status warns about k8s environment lack of pod/service name

Cosmetic issue, most likely, this is docker based, no k8s pods.
root@juju-0a8009-default-14:/home/ubuntu# contrail-status
Pod              Service         Original Name                          State       Status
                 redis           contrail-external-redis                running     Up 13 minutes
config           api             contrail-controller-config-api         running     Up 14 minutes
config           device-manager  contrail-controller-config-devicemgr   running     Up 14 minutes
config           nodemgr         contrail-nodemgr                       running     Up 1 second
config           schema          contrail-controller-config-schema      running     Up Less than a second
config           svc-monitor     contrail-controller-config-svcmonitor  restarting  Restarting (1) 54 seconds ago
config-database  cassandra       contrail-external-cassandra            running     Up 14 minutes
config-database  nodemgr         contrail-nodemgr                       running     Up 14 minutes
config-database  rabbitmq        contrail-external-rabbitmq             running     Up 14 minutes
config-database  zookeeper       contrail-external-zookeeper            running     Up 14 minutes
control          control         contrail-controller-control-control    running     Up 14 minutes
control          dns             contrail-controller-control-dns        running     Up 14 minutes
control          named           contrail-controller-control-named      running     Up 14 minutes
control          nodemgr         contrail-nodemgr                       running     Up About a minute
webui            job             contrail-controller-webui-job          running     Up 13 minutes
webui            web             contrail-controller-webui-web          running     Up 13 minutes

WARNING: container with original name 'contrail-external-redis' have Pod or Service empty. Pod: '' / Service: 'redis'. Please pass NODE_TYPE with pod name to container's env

== Contrail control ==
control: initializing (No BGP configuration for self)
nodemgr: initializing
named: active
dns: active

== Contrail config-database ==
nodemgr: initializing (NTP state unsynchronized. )
zookeeper: active
rabbitmq: active
cassandra: active

== Contrail config ==
svc-monitor: inactive
nodemgr: initializing
device-manager: active
api: active
schema: backup

== Contrail webui ==
web: active
job: active

root@juju-0a8009-default-14:/home/ubuntu# docker images
REPOSITORY                                                       TAG                  IMAGE ID            CREATED             SIZE
hub.juniper.net/contrail/contrail-status                         5.0.2-0.360-queens   0d4c16bed89b        8 months ago        780MB
hub.juniper.net/contrail/contrail-nodemgr                        5.0.2-0.360-queens   f54f27748520        8 months ago        794MB
hub.juniper.net/contrail/contrail-node-init                      5.0.2-0.360-queens   84fdf6094a00        8 months ago        779MB
hub.juniper.net/contrail/contrail-external-zookeeper             5.0.2-0.360-queens   f1f44b12947b        8 months ago        144MB
hub.juniper.net/contrail/contrail-external-redis                 5.0.2-0.360-queens   5847046c6781        8 months ago        107MB
hub.juniper.net/contrail/contrail-external-rabbitmq              5.0.2-0.360-queens   21871e76bfe8        8 months ago        189MB
hub.juniper.net/contrail/contrail-external-cassandra             5.0.2-0.360-queens<PHONE_NUMBER>00        8 months ago        323MB
hub.juniper.net/contrail/contrail-controller-webui-web           5.0.2-0.360-queens   d3ece31ba7e5        8 months ago        998MB
hub.juniper.net/contrail/contrail-controller-webui-job           5.0.2-0.360-queens   8511cd2a827e        8 months ago        998MB
hub.juniper.net/contrail/contrail-controller-control-named       5.0.2-0.360-queens   7cd1d79561d2        8 months ago        847MB
hub.juniper.net/contrail/contrail-controller-control-dns         5.0.2-0.360-queens   1c5dbdf80f2b        8 months ago        847MB
hub.juniper.net/contrail/contrail-controller-control-control     5.0.2-0.360-queens   1603de590ccf        8 months ago        847MB
hub.juniper.net/contrail/contrail-controller-config-svcmonitor   5.0.2-0.360-queens   2029c140dbb4        8 months ago        1.07GB
hub.juniper.net/contrail/contrail-controller-config-schema       5.0.2-0.360-queens   e965cbf5d6dd        8 months ago        1.07GB
hub.juniper.net/contrail/contrail-controller-config-devicemgr    5.0.2-0.360-queens   0139d9b9bf6e        8 months ago        1.07GB
hub.juniper.net/contrail/contrail-controller-config-api          5.0.2-0.360-queens   7d065313f991        8 months ago        1.13GB
root@juju-0a8009-default-14:/home/ubuntu#

this is an issue in 5.0.2 and was fixed in 5.1

thank you


Dashboards enhancements

Are there any plans to enhance the dashboards? Or maybe someone can share their modified dashboards.
Things that I seen missing:

Bandwidth
Bytes column should be human readable
List of top 10 protocols
Support for selecting sources in the traffic dashboard (for when sending flows from different sources)

You are more than welcome to share the Grafana dashboards with PRs. This is much appreciated.
For information: the compose stacks are not the main priority inside this repository. They provide a quick way to get started but are only a suggestion on how to build your flow collection pipeline.
Other projects focus on the front-end more.

I currently don't have any other dashboards. If anyone else does and doesnt mind sharing that would be great. :-)
Or if there's a list of repos container pipelines/dashboards that also works

@gaby I published some dashboards earlier today for OpenObserve - https://github.com/openobserve/dashboards/tree/main/Netflow . I am working on a blog and will publish soon.

@gaby I published some dashboards earlier today for OpenObserve - https://github.com/openobserve/dashboards/tree/main/Netflow . I am working on a blog and will publish soon.

@prabhatsharma Thank you! That looks awesome! 💪


normalise: Save errors attached to normalised data

https://github.com/openactive/conformance-services/issues/38

 When normalising, how to log errors properly


How to specify the database, when dropping measurements via Chronograph query

Im sorry to ask this question here, but i cant find information on this topic in the Influxdb docs.
I want do delete a measurement using the Chronograph query interface.
How do i specify the database i want to affect ?
The suggested syntax
DROP MEASUREMENT "weather"
returns
Database not found
In the Influx Interface i can see, that there is no database specified
POST /query?db=&epoch=ms&q=DROP+MEASUREMENT+weather&rp= HTTP/1.1"
Using
DROP MEASUREMENT "therm"."autogen"."weather"
returns
found . ,expected ; at line 1 char 25
suggesting, that no further input is required after the first string.
The same error comes up when specifying
DROP MEASUREMENT "weather" FROM "therm"."autogen"

It looks like we do not support ON <db> for this type of query. I'll mark this down as something for us to talk about at the next planning meeting.

Any progress on this?

mark

Any updates on this please :(

Is there any workaround ? Temporarily, I couldn't drop the measurement.

same problem here

reopen, this is important

Hi @tonylee2016, here is what I did to drop certain measurement (in your case weather):
use therm.autogen
drop measurement weather
It's gone - It works!

/reopen please.
Or at least give some reason why this won't be addressed. Is there some way the community could help out with this?

@bm2u how can you do that in chronograf? This is pretty frustrating as I don't have direct access to this database.

@optimuspaul I don't think so. I've used the command line interface (influx) to drop data.

same here.. its pretty frustrating in fact...

same here.. its pretty frustrating in fact...

Same here, having to use the command line is a limitation.
Please reopen this or have someone tag it as won't fix, at least some kind of feedback please

+1

This would be very useful.

I do upvote. Right now I am playing around with dump measurements for few days.

If I
use database foo
drop measurement bar

It appears that this drops all measurements named "bar", regardless of database? How can I drop a measurement for just one database?

You can add the database as extra parameter like
curl -v -XPOST https://[YOUR-HOST]/query -u [USER]:[PASSWORD]  --data-urlencode 'db=[YOUR-DB]' --data-urlencode 'q=DROP MEASUREMENT "[YOUR-MEASUREMENT]"'


Status Tag - Missing properties

Summary
Add appearance prop to status tag component.
💬 Description
Add appearance property including options for 'Default', 'Light' and 'Dark'.
Check component to confirm which prop options are required.
Additional notes: Incorrect use of appearance for 'style'
💰 User value
Provide consistent functionality across all ICDS components
📚 User Stories
If relevant, describe the high-level functionality as user stories.
As an ICDS user:
I need
So that
📝 Acceptance Criteria
If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.
Given
When
Then
✏ Designs
If there's a Figma design file (or other mock-up), include it here.
## 🧾 Guidance
If there's written guidance or documentation, include a link to it here.
Additional info
Tell us anything else useful to help us understand your suggestion.

There are no designs for this variant yet, or acceptance criteria. Therefore is blocked until this is defined

Doing as part of https://github.com/mi6/ic-ui-kit/issues/2060


95% of shares rejected

Windows 7 64-bit
(6) AMD R9 380X GPUs (4GB)
Crimson 15.12 driver
Mining ZEC at Suprnova
nheqminer_suprnova.exe -u a.1 -p pwd -t 0 -od 0
Nearly all shares are rejected after submission:
[13:52:36][0x00000a08] stratum | Authorized worker acm.115
 binsize = 215872 bytes
[13:54:05][0x00001564] Speed [300 sec]: 3.86538 I/s, 7.31978 Sols/s
[13:54:08][0x00001270] stratum | Submitting share #4, nonce<PHONE_NUMBER>0000000000000000000115
[13:54:09][0x00000a08] stratum | Rejected share #4 (low difficulty share of 0.062499046325683594)
Same result with 0.3a and newly-released 0.3b
Does anyone have any thoughts?

I should clarify, this is direct to suprnova and not via nicehash.

For test - run nheqminer v0.3b on nicehash pool

try flypool or nicehash. Sounds like a suprnova issue

Miner issue - invalid share

Using 0.4a resolved my issues, thank you all.


FMC Task - Create Runtime shell

Dummy runtime module initially for use in development and testing of FMC but can be built out into the real runtime module as well.

runtime crate checked in main.


Incremental Model interval_unit > cron

We'd like to batch updates to a daily model every 15 minutes, but I think we are limited currently to interval_unit < cron period
I put together this example
Model Definition
MODEL (
  name sqlmesh_example.incremental_model,
  kind INCREMENTAL_BY_TIME_RANGE (
    time_column ds
  ),
  start '2020-09-01',
  interval_unit 'day',
  cron '*/15 * * * *',
  grain ARRAY[id, ds]
);

Error Message
Interval unit of 'IntervalUnit.DAY' is larger than cron period of '*/5 * * * *' at '/sqlmesh/vaweb/models/incremental_model.sql'

cc @izeigerman

Interval Unit in SQLMesh is a measure of data completeness for your model.
In other words, when you set the interval unit to hour, SQLMesh ensures that data for hour X will only be processed when that hour is over. Therefore if hour X is still ongoing, the model will not run for that X. Only at timestamp >= X + 1 the hour X can be processed.
When you set cron to */15 * * * * with the intent to execute your model every 15 minutes, you expect it to run at X:15, X:30 and X:45. Though since the interval unit is set to hourly, SQLMesh concludes that hour X can't be processed at these timestamps since the data for this hour is still incomplete. Only starting at X + 1:00 can hour X be processed.
Since such configuration doesn't make sense from SQLMesh's perspective it raises an error.


Remark visualization with big boxes

The remarks column show online a small part of the text inside the field even if the box is bigger:

The content of that box, in this specific case is: "PPL-H Check Ride"

This will be fixed with upcoming changes with sync option https://github.com/vsimakhin/web-logbook/pull/117/files#diff-99a4bc6006bb72b9ad9b95b23646565a8f97191f64f1e62394bf6db1ea81ee1dL51


 :D

I've been doing the actual work for the last two days :)


[docs] add scql_status doc in chinese

[docs] add scql_status doc in chinese

I have read the CLA Document and I hereby sign the CLA

LGTM


swift: cannot import Foundation

Issue description
import Foundation in a REPL of Swift 4.2.3 results in error: could not build C module 'CoreFoundation'. It worked with Swift 4.1 in NixOS 18.09.
Steps to reproduce
https://gist.github.com/taku0/b1e7bf8c10da6b780ad0812442591b47
Technical details
Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.

system: "x86_64-linux"
host os: Linux 4.14.109, NixOS, 18.09.2436.395a543f360 (Jellyfish)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.1.3
channels(root): "nixos-18.09.2436.395a543f360"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

5.1.1 works without the problem. Closing.


Feature: Introduce "Radio" field

What
Need to introduce a Field.Radio component.
Why
Although <Field.Input type="radio" /> would look proper, the onChange handler of default text input and radio input would differ. Radio inputs essentially have the same name, and are selected based on their value. This is not how Field.Input should behave, whereas it has a unique name, and its value is updated correspondingly upon onChange.
How

Introduce new component extending generic Field
Write proper renderField method
Add any additional handlers in order for Field.Radio to work and serialize properly

Introduced basic functionality of Field.Radio. Merged under #61.
Should any other changes be required, they must be listed as separate change requests. Closing.


 : Adding swiftlint uninstall to fix builds.

 : fix/config
Checklist

[ ] New Extension
[ ] New Test
[ ] Changed more than one extension, but all changes are related
[x] Trivial change (doesn't require changelog)

          1 Message

:book:
Executed 169 tests, with 0 failures (0 unexpected) in 4.436 (4.673) seconds

  Generated by :no_entry_sign: Danger

I want to merge this ASAP. @lfarah Would you mind taking a quick look at this.
I am not very comfy with devops stuff and the travis CI stack.

Codecov Report

Merging #415 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   39.83%   39.83%
=======================================
  Files          48       48
  Lines        2179     2179
=======================================
  Hits          868      868
  Misses       1311     1311

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ff192...4eae52b. Read the comment docs.

I am merging without approvals this in since it is blocking every other build for every PR.


Support different crystal frequencies bootloader

Add bootloarder for ESP32 26MHz and ESP32-C2 26MHz
When using flash use the target xtal_freq to choose the bootloader
When using save-image add a -x/--xtal-freq arg to choose the bootloader.
Add a XtalFrequency enum to avoid hardcoded values.

As usual, I forgot to update the changelog, so I just did it and also formatted other changelog entries

Maybe you can steal our CI config on esp-hal and esp-wifi to make sure we add entries. That can wait for another PR though, if you wish!

As usual, I forgot to update the changelog, so I just did it and also formatted other changelog entries

Maybe you can steal our CI config on esp-hal and esp-wifi to make sure we add entries. That can wait for another PR though, if you wish!

This was discussed when we added the changelog, https://github.com/esp-rs/espflash/pull/416#discussion_r1210376372, but we decided not to add it as it also has drawbacks

I think that was before we fixed the fork issue around skip-changelog, @jessebraham will be able to confirm. Either way just a suggestion, feel free to ignore! Let's get this merged :).


Store management with createStore

What's done

New createStore function

Used internally for handling Stores for App instances

Dropped redux
Fully backwards compatible with deprecated methods
Full test coverage
Minified/gzipped dist file down to ~7kB from ~13kB

Preview
Both examples in the repo working, and here's a screenshot for Multiple Widgets:

Coverage remained the same at 100.0% when pulling 66548eaab5da8c8abdef76252f8c78b6ff7548e7 on store into e61aa26c19aca6d031d1bd60a35a20b7d89e0760 on master.

Coverage remained the same at 100.0% when pulling 70acc5c9d98be2a5e71049390893190f76321af1 on store into 1ccbc1224826e84ef61a90c4bf31012b96615628 on master.

The couple of deleted test files, like appendAction, and async: why aren't those needed anymore?
And just to make sure I understand correctly: instead of depending on redux, you implemented a small part of its functionality in createStore.js?

@markvincze: they are deleted because they were middlewares for Redux, not they are supported directly via createStore function, in the form of passed options.
See these options in createStore.js:

thunkArgument: for deleted async.js middleware
appendAction: for deleted appendAction.js middleware
enableLogger: for deleted logger.js middleware

Coverage remained the same at 100.0% when pulling d72a158eba3bca37a6c266b72ba72efa2786bb0e on store into 1ccbc1224826e84ef61a90c4bf31012b96615628 on master.


Release 2.0 version

Would it be possible to release the 2.0 version on crates.io or is it still missing some stuff?
We have to use cargo install --force --git https://github.com/TimNN/cargo-lipo to get a proper version of cargo lipo, which is not super obvious for new contributors.
Thank you!

Yeah, that probably makes sense, I'll put it on the to-do list for the weekend :)

Awesome thanks!

I've released 2.0.0.


Raw string associated to DEFCIRCUIT pseudo-instructions is invalid

Here is some output from a current pyQuil session:
>>> print(Program("DEFCIRCUIT ABC(%a, %b, %c) q0 q1:\n    CPHASE(%a) q0 q1\n\nABC(0.1, 0.2, 0.3) 0 1").instructions[0])
DEFCIRCUITABC(%a,%b,%c)q0q1:
    CPHASE(%a)q0q1

This is missing a bunch of spaces, which in general prevents the reconstruction of the actual circuit definition. As far as I can tell, this is a faithful representation of the "raw string" being stored as the internal representation of the DEFCIRCUIT pseudo-instruction. Presumably there's a minor error in the parser, where the tokenized circuit definition is being agglutinated without interleaving spaces between relevant tokens.

Closed by #513


Gem packager

This is a first stab at a gem packager. The contents of the gem need more work, but it takes what we’re currently defining as the contents and builds them correctly.

This works for me, but only if if the build task has run first, it might be worth making that explicit by including it at the start of the sequence of packaging tasks.


Trying to update but there's a number of missing resources

I've tried to update this locally (me and my daughter playing Pokémon Legends Arceus for instance couldn't find Rowlet), but there's a number of issues.
Two that stand out:

src/js/shared/data/monsterSummaries.json isn't synced or updated from the data anywhere I could find. I mostly managed to generate it using the following jq command: [.. | .docs? | select(.)[] ] | map({ name, types, national_id }) based on slurped data from src/assets/skim-monsters.txt - but I'm not sure if it's right (as it doesn't include the resource_uri - but searching the codebase, I couldn't see that prop being used).
More importantly, the base64 encoded images in sprites.css - I can't find where or if this file is regenerated. I gather it comes from the front_default from the pokeapi, but I can't see where this is being built.

I'd be happy to upgrade and update, I just want to rule out that I've missed these things before I write them myself.

This project is not really maintained; I'm sorry about that. You might try https://bulbapedia.bulbagarden.net or one of the other online pokedexes.

I've actually managed to make a bit of progress (but sorry, I only noticed the "not maintained" badge after I posted the issue!).
I've got the database updated and returning in results. I've also managed to scrape down the missing images and am in the progress of converting to base64 (kinda find it odd that there's a number of webp images that come up larger than png… it's not something I expected).
I've got one final bug to squash where the entire monster page is blank in some of the newer pokemon (my guess is that there's some other data missing, but there's no errors).
If I managed to get a working PR, would you want to release it to pokedex.org? If not, totally cool - I've got enough hosted under my own belt (and like I said, it was for me and my girl anyway).
Cheers chap.

Hmm, just noting for myself mostly, but I've found code that actually did handle all the 802 pokemon - since it's a limit on a for loop in the build scripts - but for some reason the pokedex conked out at 649. I'm not quite sure why, but I suspect the source monsterSummaries had been built with the 649 pokemon.
I've nearly solved the empty pages for pokemon 764 and upwards (nothing like digging around 8 year old code from someone else :D )


Ensure persistent connections between peers

Task
Make other bootnodes immune to kicking-out behavior of current bootnode implementation.
Problem
Currently, bootnodes are getting restarted from time to time. We are still investigating this, but in order to mitigate the problem, we need a way in which we can ensure the bootnodes are connected to other bootnodes/gateway nodes/storer nodes all the time. This is required so that the nodes connect to each other everytime on restart and hence get better information about the topology faster.
As the bootnodes don't dial out, we always prefer newer connections to older ones. This is a problem when one of these older connections is to the other bootnodes. So we need to protect certain nodes from this kicking-out behavior.
Solution
The solution envisioned is to have a configurable list of nodes that would be used to dial out and protect certain peers. This is similar to what IPFS does with peering
Steps:

Configure the list of peers using option/config file
Dial to the list on start and mark the peers protected
Hook into kademlia logic to prevent kicking out of these protected peers
On restart, go to step 2

This can be useful going ahead to other node operators as well. Users who operate multiple nodes can ensure they are always connected to each other. Also, users can configure list of already-known and trusted nodes to access data etc faster.

solved by #2512

solved by #2512

@acud I might have missed it, but I don't see anywhere in the changed files of #2512 where it implements step 2 to "Dial to the list on start"?

@ldeffenb we eventually decided to go with a smaller subset and additional external tooling that ensures that the nodes get the connection initiation between them, since doing it by providing the actual underlays through cli flags is a bit more clunky and also error prone. Having the overlays only provides us with minimal functionality we need right now on production. Eventually this stuff should be possible to toggle manually through the debug api.


accessing router initialize parameters from the route callback?

I saw you can pass parameters to your subroute like so
var mySubRouteInstance = new BooksRouter("books", {locale: "en_US", isVIP: true));

Then retrieve it from the SubRoute like so
initialize: function(options) {
    this.locale = options.locale;
    this.isVIP = options.isVIP;
}

Now given my subroute, how can I access locale and isVIP from my subroute callback mycallback()?
var BooksRouter = Backbone.SubRoute.extend({
    initialize: function(options) {
         this.locale = options.locale;
    }
    routes: {
        "myroute"   : "mycallback",
    },
    mycallback: function() {
         //###### how can I get the value of locale here??
    },
});

You should be able access it with:
this.locale

Here's a functional example in CoffeeScript - different syntax, same principle:
App.Routers.Shop = Backbone.SubRoute.extend

  initialize: (options) ->
    @locale = options.locale

  routes:
    'books(/*subroute)'   : 'books'

  books: ->
    new App.Routers.Shop.Books("#{ @prefix }/books", { locale: @locale, createTrailingSlashRoutes: true })

Hi @aeksco, sorry I got carried away and forgot critical details that I'm both using marionette and Marionette.Subrouter https://github.com/pushchris/backbone.marionette.subrouter ... which both are supposed to be extensions but anyways, I understand why this works in your example and also see now why it doesn't work in mine (below) but I still would love to find a solution.
Backbone.Router > Marionne.AppRouter > Marionette.SubRouter
Marionette Router derived from Backbone Router and Marionette SubRouter derives from AppRouter but clearly there's a ton of more things happening.
In my case using appRoutes this from inside my callback just gives me back the actual controller passed to the router or in this case below API which is an object with keys representing the functions
API =
myPath: ->
// debugger
Marionette.SubRouter extends directly from
class MyApp.Router extends Marionette.SubRouter
controller: API
initialize: (options) ->
{ @myvar } = options
appRoutes:
"my-path" : "myPath"
I guess this is a Marionette question

Interesting - wasn't familiar with Marionette.Subrouter. Learning new things everyday :D
Superficially the issue you're experiencing appears to be a result of your method not being properly bound to the subrouter instance.
For example, you have:
  myCallback: function() {
    console.log(this.foo);
  }

Where you really need:
  myCallback: (function(_this) {
    return function() {
      console.log(_this.foo);
    };
  })(this)

If I'm not mistaken, the above is typically going to be used when the method you're defining is a callback that references instance fields in the parent object.
The distinction in CoffeeScript is terse and fails to clarify the underlying principles, though researching the nuances between thin arrows and fat arrows will shed some light on your dilemma, given of course that the rest of the code is functioning well.
    myCallback: ->
    	console.log @foo

VS
    myBoundCallback: =>
      console.log @foo

Hope this helps - good luck!


Added support multiple .NET versions

Nice work. I like the simplicity compared to some other projects.
The changes I made are sweeping, but simple:

I upgraded the project and solution files to Visual Studio 2017/2019 formats.
I added support for .NET 2.0, 3.5, 4.0, 4.5, .NET Standard 2.0 and .NET Core 2.0 and 2.1. This was done through some minor code changes and adding the Theraot.Core NuGet package.
I also ran the code through CodeMaid to provide syntax and style consistency.

LGTM

Will you merge and then push the updated NuGet package?

It's available here now: https://www.nuget.org/packages/Bmbsqd.Async/0.3.0

Thank you for the very quick turn-around!


Remove tox from e2e testing

Fixes #417

tox was introduced to the repo in #320
A clear article on why tox is useful: https://christophergs.com/python/2020/04/12/python-tox-why-use-it-and-tutorial/
tl/dr

Test against different versions of Python (which would have alerted Kyle that the library hadn’t been tested against his install version).
Test against different dependency versions
Capture and run setup steps/ad hoc commands (which Kyle could have made a mistake on / not known about)
Isolate environment variables - By design, tox does not pass any evars from the system. Instead you are asked to explicitly declare them (which would have alerted Kyle to any environment variable requirements).
Do all the above across Windows / macOS / Linux (which would have saved Kyle if the issue had been due to the OS)

#417 requests that e2e tests use the locally installed packages.  By definition, this is impossible with tox.
tox cannot install a dependency from github unless it is in a requirements file. This file is not cached.
I believe the tox advantage is minimal as we:

Are not testing against multiple python versions locally
Have only a few extra dependencies for e2e testing
Do not use Environment variables
Have consistent scripts that can be run

Disadvantage of not using tox:

Not being able to cleanly pass arguments into the pytest command. However, this can be done with environment variables

This can be mitigated by using an environment variable FILE. Ex, test the e2e/outputs: make e2e FILE=e2e/outputs

Looks good. I'll merge, but a couple of comments:

The top-level README should have info about how to set up a venv.
If make e2e FILE=e2e/async is too cumbersome, we could just add small shell script that lets us do e2e e2e/async.


v3.0 bump from es2019 to es2021 causes bundling issues

Which package(s) are affected?
Lit Core (lit / lit-html / lit-element / reactive-element)
Description
When testing an upgrade to<EMAIL_ADDRESS>for MGT I encountered an interesting issue.
We have a monorepo with components built on lit and a some dependent packages. One of our dependent packages uses webpack as a bundler. After installing the preview package and trying to build the webpack based package failed to build with errors like this:
[20:17:17] Error - [webpack] 'dist':
/home/gavinb/dev/mgt/node_modules/lit/node_modules/lit-html/directives/class-map.js 6:106
Module parse failed: Unexpected token (6:106)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|  * Copyright 2018 Google LLC
|  * SPDX-License-Identifier: BSD-3-Clause
>  */const e=s(class extends i{constructor(t){if(super(t),t.type!==r.ATTRIBUTE||"class"!==t.name||t.strings?.length>2)throw Error("`classMap()` can only be used in the `class` attribute and must be the only part in the attribute.")}render(t){return" "+Object.keys(t).filter((s=>t[s])).join(" ")+" "}update(s,[i]){if(void 0===this.it){this.it=new Set,void 0!==s.strings&&(this.st=new Set(s.strings.join(" ").split(/\s/).filter((t=>""!==t))));for(const t in i)i[t]&&!this.st?.has(t)&&this.it.add(t);return this.render(i)}const r=s.element.classList;for(const t of this.it)t in i||(r.remove(t),this.it.delete(t));for(const t in i){const s=!!i[t];s===this.it.has(t)||this.st?.has(t)||(s?(r.add(t),this.it.add(t)):(r.remove(t),this.it.delete(t)))}return t}});export{e as classMap};
| //# sourceMappingURL=class-map.js.map
|
 @ /home/gavinb/dev/mgt/node_modules/lit/directives/class-map.js 1:0-46 1:0-46
 @ ../mgt-components/dist/es6/components/mgt-agenda/mgt-agenda.js
 @ ../mgt-components/dist/es6/components/components.js
 @ ../mgt-components/dist/es6/index.js
 @ ./lib/index.js

This is because of this change: https://github.com/lit/lit/commit/85ca81a7e935e554b2f40303b7956b638edb3176
The move from es2019 to es2020 introduces optional chaining and nullish coalescing operators which the existing webpack config does not know how to process. I'm reasonably confident that I can update the webpack config to handle this change, but it might be useful to call this change out in the upgrading documentation.
Reproduction
git clone https://github.com/microsoftgraph/microsoft-graph-toolkit.git mgt
cd mgt
git checkout chore/lit-upgrade
yarn && yarn build
Observe the errors when building the mgt-spfx package
Workaround
I'm working on a fix, to add new loaders into the webpack config to handle the es2021 code
Is this a regression?
Yes. This used to work, but now it doesn't.
Affected versions
failing in 3.0.0-pre.0 working in 2.7.5
Browser/OS/Node environment
Browser: N/A
OS: Ubuntu 20.04
node: 16.19.1
yarn: 1.22.19
npm: 6.14.17 (although we don't use npm on this project)

Thanks for the report!
This is a good callout to mention in the upgrade guide that existing project build tools might also need updating or additional configuring to handle newer syntax.
cc: @AndrewJakubowicz

With regards to webpack, it looks like webpack v5 should have support for optional chaining without loaders. https://github.com/webpack/webpack/releases/tag/v5.0.0-beta.25
This might need updating on @microsoft/sp-build-web depended by the mgt-spfx package which appears to be using webpack v4. https://unpkg.com/browse/<EMAIL_ADDRESS>

Yeah it's 100% the SPFx build chain.
On Wed, Jun 14, 2023, 4:43 PM Augustine Kim @.***>
wrote:

With regards to webpack, it looks like webpack v5 should have support for
optional chaining without loaders.
https://github.com/webpack/webpack/releases/tag/v5.0.0-beta.25
This might need updating on @microsoft/sp-build-web depended by the
mgt-spfx package which appears to be using webpack v4.
<EMAIL_ADDRESS>—
Reply to this email directly, view it on GitHub
https://github.com/lit/lit/issues/3955#issuecomment-1592130584, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWK6HF6YOCBUEMVE7UUNZTXLJEBFANCNFSM6AAAAAAZG53IAU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Taking this as a documentation issue


Healthcheck for Linux Container WebApp

The preview healthCheckPath feature doesn't seem to be respected when configured on a Linux Container WebApp.
It's quite possible I'm misunderstanding or even abusing this feature, as I'm not really looking for health metrics collected by the platform, but instead am looking to bypass EasyAuth for an external monitor to query for health metrics. As I understand it, bypassing EasyAuth is more of a side-effect of this feature, rather than a direct feature.
Repro steps.

Create Linux WebApp (AppService sku: B1), using a Docker container as the app source
Configure EasyAuth (in my specific case using Azure AD)
Set healthCheckPath using resources.azure.com under /config/web properties node (in my specific case using /heath-status)
Restart WebApp
Ensure Container logs show site is started
Visit https://the-site.azurewebsites.net, observe EasyAuth in effect, redirecting to authentication flow
Visit https://the-site.azurewebsites.net/health-status, observe EasyAuth still in effect

Expected outcome: EasyAuth is not in effect when visiting https://the-site.azurewebsites.net/heath-status.
Workaround
To achieve my goal (hosting an unauthenticated endpoint in an Linux Container WebApp with EasyAuth enabled) it seems I'm able to use WEBSITE_WARMUP_PATH, which also has a side-effect of bypassing EasyAuth for the defined route. Given that technically neither the Healthcheck preview nor the Warmup feature seem designed to deliver this auth bypass behavior, perhaps using WEBSITE_WARMUP_PATH is the best approach, until the broader platform can deliver other mechanisms explicitly designed to disable EasyAuth for specific routes.

Add WEBSITE_WARMUP_PATH as an appsetting (in my specific case using /health-status)
Restart site
Visit https://the-site.azurewebsites.net/health-status, observe EasyAuth is bypassed

Project structures.
I don't have a sharable sample project at this time - hope that isn't a blocker here.
The log/error given by the failure.
No specific log/error, more of an undesired behavior (302 to authentication flow).
Debug your Azure website remotely.
Unable to share at this time - hope that isn't a blocker here.
Mention any other details that might be useful.
Should this issue simply be closed, as unauthenticated health-status endpoints isn't an explicit goal of The healthcheck preview?
Thanks for taking the time to review! 💙
P.S. tagging in @JasonFreeberg who seems to be the primary driver for Healthcheck preview. 👋

Hi @bengreenier, the health check feature was not originally designed to expose the specified path as an EasyAuth bypass externally. The healthcheck ping originates from within the App Service system, but any external request hitting that endpoint will first go through Easy Auth.
We are discussing this scenario internally and I will reply back on this thread with an update.

Thanks @JasonFreeberg! To keep this issue relevant for other folks as well, can you comment on the expected availability of the overall feature for Linux Container Webapp nodes?
Should the platform-driven monitoring be working and visible via the metrics pages as documented for these type of apps?

@bengreenier We actually have a bugfix deploying right now. So by the end of the month the deployment should roll through all regions. The deployment will fix the monitoring and metrics for Linux apps (including custom container apps).

Oh, Great! Thanks for sharing.

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


Power Toys will not open/run/or respond at all

Microsoft PowerToys version
0.58.0
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
Download powertoys, install, try to run, open settings, or interact in any way.
✔ Expected Behavior
Something to open
❌ Actual Behavior
Nothing opens, it does not even appear to attempt to open other than a loading wheel for a few seconds. The ribbon widget it there it just does not do anything.
I have tried:

uninstalling and reinstalling (both from git hub and the windows package manager) several times
installing from microsoft store (it wont download)
updating my windows desktop 3.1 runtime
restarting my computer
running as both administrator and normally
task manager force closing app and reopening.

Other Software
No response

Same issue here. Came here to check. On Windows 10 Pro.

Same issue here. Came here to check. On Windows 10 Pro.

This fixed it for me after searching. Issue with Riva
https://github.com/microsoft/PowerToys/issues/18019#issuecomment-1117046201

/dup #18019


Fix missing imports during development mode

We need to have cabal build -f development in CI

Hold on - there's a failing test. I'll fix that.

Here's something subtle: Any function that uses tracing in its dependency chain (ptraceError, ptrace etc.), needs finer attention in the test suite if comparing script outputs directly. Of course, the trace builtin function call is only present in the script in development mode.
So the compiled script will be different in the two modes. Hence, when testing against compiled output - be careful of the difference.

And having to use CPP in test files is a pain..... I wish backpack worked.
I'm having a hard time getting fourmolu to not die on a file with CPP

Alright, that should work.
Sorry for butchering up your test file @blamario :(


First HikariCP implementation

For now tests are failing because of too much connections. Which surprise
me since the HikariCP have maximum pool of 10 connections, and a default
postgis/postgis docker image have a 100 connections hard limit.

I wonder if the problem may come from github action. When the pool is greater than the number of core available, we get an exception.
config.setMaximumPoolSize(Runtime.getRuntime().availableProcessors()); // success
config.setMaximumPoolSize(Runtime.getRuntime().availableProcessors() * 2); // failure

Nice work on the try-with-resource work !! And nice work too on the pool size !
I just add a "parametrize" way of specifying the pool size.

Can you squash the last commit or the PR before merging?


Bicep version 0.29 support

Bicep version 0.29 support

As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing.
[x] Verified build scripts work.
[x] Updated relevant and associated documentation.

CLI tool gitversion has been updated to Major version 6, which came with some breaking changes. I took the opportunity to change the GitVersion.yml for the module, and to ensure that preview versions based on main properly increment per commit.


Typescript Discussion

Hi all,
I'd like to start by saying thank you to all the maintainers and contributors of this package 💯 and also apologies for not using the issue template format, wasn't quite sure if this was a bug or a feature request.
I've been trialling the v7 branch, and overall its really really impressive 🙌 The only part that seemed a little ... lacking was the Typescript types. This was not a huge issue, as I was able to create my own types file that the compiler merges with the types provided by react-table (using declaration merging)
I noticed that beta 12 has recently been released, and I updated (from beta 10). Unfortunately, it seems that the situation has somewhat worsened from a developer experience perspective. I'm assuming the changes were made in order to better handle the fact that any number of plugin hooks might be specified by a user. However, these changes seem to have come at the cost of requiring users to include a custom types file in their projects (which is a little unusual, even for Typescript projects).
In an ideal world, it'd be great to see react-table written natively in Typescript to avoid situations where the code and types are not in sync, but I do understand that might not be what the maintainers/contributors want. That said, the procedure in beta 12 seems like it could be improved, and I'm happy to help 😄 I'm including my additions to the types file from beta 10 that mostly fixed the plugin issues, as well as adding a few other missing types. There are some definite improvements in the beta 12 types, so it'd be good to see if we can find some middle ground.
import {
  Row,
  TableInstance,
  TableOptions,
  useGroupBy,
  useFilters,
  useSortBy,
  useExpanded,
  usePagination,
  useRowSelect,
  useRowState,
  useColumnOrder,
  useBlockLayout,
  useAbsoluteLayout,
  useResizeColumns,
  Column,
} from "react-table";

declare module 'react-table' {
  export interface TableInstance<D = {}> extends TableOptions<D> {
    getTableBodyProps: (userProps?: any) => any
    selectedFlatRows: Row<D>[]
  }

  export interface HeaderColumn<D> {
    disableFilters?: boolean;
  }

  export interface EnhancedColumn<D>
    extends Omit<Column<D>, 'columns'>,
      TableInstance<D> {
    canFilter?: boolean
  }

  export interface UsePaginationValues<D = {}> {
    pageOptions: number[]
  }

  export type Plugin<D> = useGroupBy<D> |
    useFilters<D> |
    useSortBy<D> |
    useExpanded<D> |
    usePagination<D> |
    useRowSelect<D> |
    useRowState<D> |
    useColumnOrder<D> |
    useBlockLayout<D> |
    useAbsoluteLayout<D> |
    useResizeColumns<D>

  export function useTable<D = {}, P = Plugin<D>>(
    props: TableOptions<D>,
    ...plugins: P[]
  ): TableInstance<D> & ReturnType<typeof P>

  export function useRowSelect<D = {}>(
    props: TableOptions<D>
  ): TableOptions<D>
}

I'm confused as to what you're saying is missing/worse?
canFilter, disableFilter are still in a PR. I added getTableBodyProps and can't remember if selectedFlatRows was added off the top of my head. (I'm away from my computer)

Hi @stramel, the part I was referring to as worsened is the instructions in TYPESCRIPT.md, specifically the idea of copying a types file from react-table into my project.
I was unaware that there were PRs for the missing types, thanks for letting me know 😀

I found this file here: https://gist.github.com/Grsmto/1ac3a7ddb8ad8288660784a37bff1798
// Type definitions for react-table 7
// Project: https://github.com/tannerlinsley/react-table#readme
// Definitions by: Adrien Denat <https://github.com/grsmto>
//                 Artem Berdyshev <https://github.com/berdyshev>
//                 Christian Murphy <https://github.com/ChristianMurphy>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// TypeScript Version: 3.0
declare module 'react-table' {
  import { Dispatch, SetStateAction, ReactNode } from 'react'

  export interface Cell<D> {
    render: (type: string) => any
    getCellProps: () => any
    column: Column<D>
    row: Row<D>
    state: any
    value: any
  }

  export interface Row<D> {
    index: number
    cells: Cell<D>[]
    getRowProps: () => any
    original: any
  }

  export interface HeaderColumn<D, A extends keyof D = never> {
    /**
     * This string/function is used to build the data model for your column.
     */
    accessor: A | ((originalRow: D) => string)
    Header?: string | ((props: TableInstance<D>) => ReactNode)
    Filter?: string | ((props: TableInstance<D>) => ReactNode)
    Cell?: string | ((cell: Cell<D>) => ReactNode)

    /**
     * This is the unique ID for the column. It is used by reference in things like sorting, grouping, filtering etc.
     */
    id?: string | number
    minWidth?: string | number
    maxWidth?: string | number
    width?: string | number
    canSortBy?: boolean
    sortByFn?: (a: any, b: any, desc: boolean) => 0 | 1 | -1
    defaultSortDesc?: boolean
  }

  export interface Column<D, A extends keyof D = never> extends HeaderColumn<D, A> {
    id: string | number
  }

  export type Page<D> = Row<D>[]

  export interface EnhancedColumn<D, A extends keyof D = never> extends Column<D, A> {
    render: (type: string) => any
    getHeaderProps: (userProps?: any) => any
    getSortByToggleProps: (userProps?: any) => any
    sorted: boolean
    sortedDesc: boolean
    sortedIndex: number
  }

  export type HeaderGroup<D, A extends keyof D = never> = {
    headers: EnhancedColumn<D, A>[]
    getRowProps: (userProps?: any) => any
  }

  export interface Hooks<D> {
    beforeRender: []
    columns: []
    headerGroups: []
    headers: []
    rows: Row<D>[]
    row: []
    renderableRows: []
    getTableProps: []
    getRowProps: []
    getHeaderRowProps: []
    getHeaderProps: []
    getCellProps: []
  }

  export interface TableInstance<D>
    extends TableOptions<D>,
      UseRowsValues<D>,
      UseFiltersValues,
      UsePaginationValues<D>,
      UseColumnsValues<D> {
    hooks: Hooks<D>
    rows: Row<D>[]
    columns: EnhancedColumn<D>[]
    getTableProps: (userProps?: any) => any
    getRowProps: (userProps?: any) => any
    prepareRow: (row: Row<D>) => any
    getSelectRowToggleProps: (userProps?: any) => any
    toggleSelectAll: (forcedState: boolean) => any
  }

  export interface TableOptions<D> {
    data: D[]
    columns: HeaderColumn<D>[]
    state?: [any, Dispatch<SetStateAction<any>>]
    debug?: boolean
    sortByFn?: (a: any, b: any, desc: boolean) => 0 | 1 | -1
    manualSorting?: boolean
    disableSorting?: boolean
    defaultSortDesc?: boolean
    disableMultiSort?: boolean
  }

  export interface RowsProps {
    subRowsKey: string
  }

  export interface FiltersProps {
    filterFn: () => void
    manualFilters: boolean
    disableFilters: boolean
    setFilter: () => any
    setAllFilters: () => any
  }

  export interface UsePaginationValues<D> {
    nextPage: () => any
    previousPage: () => any
    setPageSize: (size: number) => any
    gotoPage: (page: number) => any
    canPreviousPage: boolean
    canNextPage: boolean
    page: Page<D>
    pageOptions: []
  }

  export interface UseRowsValues<D> {
    rows: Row<D>[]
  }

  export interface UseColumnsValues<D> {
    columns: EnhancedColumn<D>[]
    headerGroups: HeaderGroup<D>[]
    headers: EnhancedColumn<D>[]
  }

  export interface UseFiltersValues {
    setFilter: () => any
    setAllFilters: () => any
  }

  export function useTable<D>(props: TableOptions<D>, ...plugins: any[]): TableInstance<D>

  export function useColumns<D>(props: TableOptions<D>): TableOptions<D> & UseColumnsValues<D>

  export function useRows<D>(props: TableOptions<D>): TableOptions<D> & UseRowsValues<D>

  export function useFilters<D>(
    props: TableOptions<D>,
  ): TableOptions<D> & {
    rows: Row<D>[]
  }

  export function useSortBy<D>(
    props: TableOptions<D>,
  ): TableOptions<D> & {
    rows: Row<D>[]
  }

  export function useGroupBy<D>(props: TableOptions<D>): TableOptions<D> & { rows: Row<D>[] }

  export function usePagination<D>(props: TableOptions<D>): UsePaginationValues<D>

  export function useFlexLayout<D>(props: TableOptions<D>): TableOptions<D>

  export function useExpanded<D>(
    props: TableOptions<D>,
  ): TableOptions<D> & {
    toggleExpandedByPath: () => any
    expandedDepth: []
    rows: []
  }

  export function useTableState(
    initialState?: any,
    overriddenState?: any,
    options?: {
      reducer?: (oldState: any, newState: any, type: string) => any
      useState?: [any, Dispatch<SetStateAction<any>>]
    },
  ): any

  export const actions: any
}

@hassankhan That document is very new and still needs some revisions. We don't generally copying types except for maybe to use in an example or as a starting point.
@tsujp That gist is very out of date and incompatible with the types that are going to be supported.

Beta 12 doesn't work as-is with Types though, why can't the repo be redone with Typescript inline instead of separation of concerns that is currently the focus? Isn't this the perfect time?
I'd love to help out if I wasn't so average at Typescript, I only just started using it two months ago unfortunately.

What exactly do you mean by "separation of concerns"?  Do you mean that the types don't just lump in every hooks behavior?  How do you deal with external hooks?  How do you deal with hooks that are standard, but aren't included in the configuration of the table?  These are all separate right now so that each user can tailor the interface so match what's supported.
I'll admit that this is a bit awkward, I don't think that anyone is particularly happy with it, but until we get a better solution that works for those use cases, I don't really see an alternative.
As a separate point, the interface is huge and changing (it is a beta after all), it's been very easy to miss stuff, so yes, there are apis that have been missing.  But again, they can easily be added locally (using the same declaration merging technique) until they get added to the main types.
I'm not saying that we don't want this to be easier, we do, it's just not obvious what the right solution is and so we went with something that works until we can get something better.

Chiming in here with a typing issue. I'm getting Property 'getSortByToggleProps' does not exist on type 'ColumnInstance<any>'. when trying to implement sortable columns in TypeScript. I've essentially copy/pasting the sorting example to get started here.
react-table version: 7.0.0-beta.12

CodeSandbox here: https://codesandbox.io/s/react-table-beta-12-typings-xculv

@kpollich I had the same issue. What you have to do, is to copy the file react-table-config.d.ts, inside a directory (I recommend copying it inside the directory as your table component).
Then remove the interface you do not need or the extends you won't use.
Everything is explained here : https://github.com/tannerlinsley/react-table/blob/master/TYPESCRIPT.md
I hope this helps 😃

The types at https://github.com/tannerlinsley/react-table/blob/master/TYPESCRIPT.md do not function properly.
prepareRow() is of type void and so the statement prepareRow(row) || ... is invalid. Attempting to workaround this by turning it into (prepareRow(row),( ...) is also invalid.
I haven't been able to use this library with the types present in the repo yet.

yeah, the problem is that the examples all do prepareRow() || ..., but prepareRow is actually void, you can check the code, it has no return.
That said, while it's a bit misleading, it is valid javascript so perhaps we should have defined prepareRow as returning undefined. It's not exactly what's going on, but it would have keep the usage in the examples working in typescript.

Indeed I was just a bit thrown off as I am newly getting into TypeScript. All the examples are Javascript too, but it's no bother now I think as the example in my previous comment is valid TypeScript as per:

https://eslint.org/docs/rules/no-sequences
https://github.com/Microsoft/TypeScript/issues/28248#issuecomment-434693307

Chiming in here with a typing issue. I'm getting Property 'getSortByToggleProps' does not exist on type 'ColumnInstance<any>'. when trying to implement sortable columns in TypeScript. I've essentially copy/pasting the sorting example to get started here.
react-table version: 7.0.0-beta.12

CodeSandbox here: https://codesandbox.io/s/react-table-beta-12-typings-xculv

Facing the same issue.. any solution for this??

I'm specifically seeing a couple other bugs in the beta-12 types:

In UseRowSelectState, the selectedRows field is wrong.  The code has a selectedRowPaths field
In UseRowSelectInstanceProps, the toggleRowSelected method appears to expect an array that it can call .join() on, not a single string

My hacky local fixes in our types customization file:
    // FIX The R-T type claims this is selectedRows, not selectedRowPaths
    export interface UseRowSelectState<D extends object> {
        selectedRowPaths: IdType<D>[];
    }

    // FIX The R-T type for toggleRowSelected says it takes a string, not an array
    export type UseRowSelectInstancePropsFixed<D extends object> = Omit<
        UseRowSelectInstanceProps,
        "toggleRowSelected"
    > & {
        toggleRowSelected: (rowPath: (string | number)[], set?: boolean) => void;
    };

a) that's exactly how I fix these in my project.
b) the selectedRowPaths change actually matches what's in master, by not shipped yet.
c) the toggleRowSelected fix is new to me and looks like an unreported bug.  I'll try to keep track of it.

I'm getting the following error:
Object literal may only specify known properties, and 'disableMultiSort' does not exist in type 'TableOptions<object>'.

Same for selectedFlatRows, isAllRowsSelected atm, no type definitions. @hassankhan can you link here the PRs that have these kind of missing types please?

Same for selectedFlatRows, isAllRowsSelected atm, no type definitions. @hassankhan can you link here the PRs that have these kind of missing types please?

Look on UseRowSelectInstanceProps for those two, they are there.

You mean here @ggascoigne ? https://github.com/tannerlinsley/react-table/blob/master/index.d.ts#L452
My index.d.ts is a bit different from that 🤔

I'm guessing that you're using beta.12 or earlier, that definition was added for beta.13 or later.

Yap, that's it @ggascoigne thanks! 👍

I'm using beta.12 and this is how I include plugins to react-table types, it's really simple:
declare module 'react-table' {
  interface Row<D> extends UseExpandedRowProps<D> { }
  interface Column<D extends object = {}> extends UseSortByColumnOptions<D> {}
  interface ColumnInstance<D extends object = {}> extends UseSortByColumnProps<D> { }
  interface TableOptions<D extends object = {}> extends UseSortByOptions<D> { }
}

Using beta.20 and getting this error:
Object literal may only specify known properties, and 'getResetPageDeps' does not exist in type 'TableOptions<any>'.ts(2345)

Yeah, there was a significant amount of refactoring in beta.20. Types are most definitely out of sync.

This has been itching me for a last few weeks and I think I've decided I want to move the types out of this repo and into the Definitely Typed repo. Until React Table is inevitably rewritten in Typescript itself, I would like to move the discussions/issues/expectations around types over to DT.
I'm not sure what is required here, but I'm assuming it should be pretty simple to PR the types over to DT. As soon as that's done, I have no problem adding a dependency on the external types.
Thanks for all of your work guys. Keep it up, please! There are a lot of TS users that are benefiting from this :)

I'll admit that I'm in two minds about this.  Obviously they belong there in the long run, but as long as the interface keeps changing in some pretty substantial ways, there's some convenience in having them here.  Also, you don't work in typescript (and that's OK), but how do you hope to understand the api issues around typing this api if you aren't part of that conversation.

Yeah, and honestly, the api could be changing even more in the coming days, but I don't see any more convenience in having them colocated. As of today in beta, they will likely continue to get out-of-date as we refactor, write tests, move towards an RC, etc, and the last thing I want for people is a false sense of security to see that there are "native" looking types in the repo that don't actually have any guarantees around them. With that said, I understand that "changes" and "refactors" sound scary to after-the-fact type-defs, but at the same time, I don't plan on turning the library upside down for those same type-defs until I'm ready to go all-in on TS. For now, I hope I would still be including in the discussions around types with a simple @tannerlinsley 😃.

Understandable.  One thing that I do notice looking at the definitely typed docs, it will be hard to publish types for the v7 betas until the version number follows semantic versioning, at least unless I'm missing something there.

Yeah, I'm not totally versed in how DT works with prereleases and tags. As of today though, the default install for react-table is now v7 (it was actually a CI accident) and I just decided to keep it (still beta though, like Fortnite! 😉 ).

As of right now today, the API still has a lot of non-type related things that will be changing under the hood, including refactors of the internal "instance" architecture, footer support, global filters, etc, then not to mention tests... lots of them.

Porting my comment to here to continue the discussion. https://github.com/tannerlinsley/react-table/pull/1534#issuecomment-560533319

So I have felt some burnout on trying to keep up with the definitions with lots of rework being thrown in and no chance to get the types updated before the release. Essentially by having them in the repo, it should be part of the release process to update the types before a release is cut.
I second @ggascoigne, and think that without some major API changes, that converting to typescript/coming up with a good external typescript definition, will be very difficult.
Personally, I think the easiest solution would be to rewrite it with typescript. This would allow us to see pain points as they come up and rework the API to allow nice typings.

@tannerlinsley I think your last change broke my app. I'm getting node_modules/react-table/index.d.ts' is not a module.  Any idea?

@bnbarak I would open a new issue with more info like the version you're using, etc. This is more of a long-term discussion on types.

FYI I posted a PR with the latest types to DT https://github.com/DefinitelyTyped/DefinitelyTyped/pull/40816 - note that these still require declaration merging but at least this gives us a place to discuss things.

fwiw i would rather see types in this repo and kept up to date, esp. once 7 goes stable. Having them here means you can expect/request PRs to include the relevant typing updates, and they should be up to date (and tested in CI, I could maybe contribute here) for stable releases.
I'm pretty understanding that prereleases might have the definitions slip, but for stable releases there shouldn't be a huge maintenance burden here, should there?
Sincerely,
just some guy who uses this great library.

@bnbarak I've had to pin react-table 6.10.3 and @types/react-able 6.8.3 to fix that error. We're waiting until v7 is stable to upgrade our table implementation, so will probably just keep those versions pinned for now.

FWIW, I can say that as a Redux maintainer, even types for a tiny and very stable lib can be a "maintenance burden".  I talked about my experience in my post Learning and Using TypeScript as an App Dev and a Library Maintainer.
There's strong and valid arguments for all 3 scenarios (keep types in DT, keep types in repo, rewrite lib in TS entirely).  Since Tanner's the maintainer, he gets to pick what approach he wants.

Agreed. Even if they were 100% community driven, there is still a fair amount of "chores" work. I'm not saying it's hard by any means, but it is noise that ends up being a distraction (even in the short time the typings were in this repo, the conversations, PRs, and issues around them were already pretty distracting for me). At this point, it's just a countermeasure to keep myself pumped about the project and excited to work on it.

@kpollich I had the same issue. What you have to do, is to copy the file react-table-config.d.ts, inside a directory (I recommend copying it inside the directory as your table component).
Then remove the interface you do not need or the extends you won't use.
Everything is explained here : https://github.com/tannerlinsley/react-table/blob/master/TYPESCRIPT.md
I hope this helps 😃

Thanks! This solution works, will this be a one time fix or it requires regular update that depends on definitely typed / react table ?

Hey, typescript developers, would you donate typescript example please... :heart:

Agreed. I'm still getting this type error using typescript<EMAIL_ADDRESS>& respective type version v7.0.17)

I am also using useSortBy
const { getTableProps, getTableBodyProps, headerGroups, rows, prepareRow } = useTable(
    {
        columns,
        data,
    },
    useSortBy
);

@bsell93 make sure to include sort options in your types..

@lishine Found an example here:
https://github.com/tannerlinsley/react-table/pull/1585/files/d80305deb5d4653c49222f750941d78a9b9da9a9
I personally solved this issue by using the interface defined in the above link
interface TableColumn<D extends object = {}>
  extends ColumnInstance<D>,
    UseSortByColumnProps<D>,
    UseResizeColumnsColumnProps<D>,
    UseFiltersColumnProps<D> {}

and casting the column like so:
const column = (c as unknown) as TableColumn<object>;
@gargroh I don't follow. They type of the column is inferred based on the type definition. Are you suggesting I cast like I did above?

Casting should not be needed, this example would help https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-table#example-type-file

@gargroh that did the trick!
Although it does seem silly to have to re-declare/define the interfaces in the module. My first thought is that the type would change when I added useSortBy.
Either way, thanks for your help!

Casting should not be needed, this example would help https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-table#example-type-file

maybe it's an issue with v7.6.0 (types v7.0.24) but getting errors on all of those definitions in react-table-config.d.ts:

All declarations of 'ColumnInstance' must have identical type parameters. ts(2428)

For anyone else facing issues after copy/pasting the react-table-config.d.ts, this CodeSandbox (referenced here) was super useful.

It's probably worth pointing out that that there is a readme for the typescript types https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-table/Readme.md which also includes that react-table-config.d.ts.
Sadly there's no good standard place to document types that live outside of a project and that was the best that we came up with.  Easy to miss though :(

to give my 2 cents:
transition to typescript is not that hard as it seems. If you setup the tooling right, you can just rename js(x) files to ts(x), start to annotate some functions one by one, without rewriting the whole library. E.g. you can just annotate the files you touch.
it will eventually fall into place like a jigsaw (and you will usually find a bug or two!). 🧩  This is especially true with hooks which are just functions, and functions are simple to annotate.
and all of sudden your public api is properly annotated 😃

I hear you, and I even tried to do that at the start of 2020. However, I quickly learned a few things:

Incrementally adding TS to a JS project like you said is easy to start, but quickly results in a massive amount of anys and unknowns. This is fine, but not in the long run. At some point, the work/time will be better spent in a rewrite.
With public gradual migration, it's inevitable that you will eventually have to make breaking changes to get rid of the untypable dynamisms in the library to get full TS intellisense and holistically correct types. This isn't a very good experience to have a public api that is always slowly, but constantly, breaking.
TypeScript is simple, but not easy. A library like this requires a massive amount of generics, a highly sophisticated plugin system with multiple plugin points (22+ actually) and a very rich I/O model that permeates just about every corner of the library.

With all of that said, you'll be happy to know that I'm currently writing v8 natively in TypeScript. I assure you, it's a beast, but it's also awesome. Take it from me, with what I know about the internals and current API in v7, there's no way to backport accurate types to v7 that will even come close to v8.

I hear you, and I even tried to do that at the start of 2020. However, I quickly learned a few things:

Incrementally adding TS to a JS project like you said is easy to start, but quickly results in a massive amount of anys and unknowns. This is fine, but not in the long run. At some point, the work/time will be better spent in a rewrite.
With public gradual migration, it's inevitable that you will eventually have to make breaking changes to get rid of the untypable dynamisms in the library to get full TS intellisense and holistically correct types. This isn't a very good experience to have a public api that is always slowly, but constantly, breaking.
TypeScript is simple, but not easy. A library like this requires a massive amount of generics, a highly sophisticated plugin system with multiple plugin points (22+ actually) and a very rich I/O model that permeates just about every corner of the library.

With all of that said, you'll be happy to know that I'm currently writing v8 natively in TypeScript. I assure you, it's a beast, but it's also awesome. Take it from me, with what I know about the internals and current API in v7, there's no way to backport accurate types to v7 that will even come close to v8.

that's good to hear, so we'll wait for v8 to adopt!

@ggascoigne  Are there any simple typescript table examples with sorting and a filter?
I went through the getting started guide in js, then I found a simple typescript example, but then I tried to add filtering from what I saw in https://github.com/ggascoigne/react-table-example and haven't gotten it to work.  More simple typescript examples would help a lot.
@tannerlinsley  Any target for when v8 would be ready?

@AgustinBrst
Thanks alot, It solved my problem

Hello All,
I need some help. I have followed this this but still not able to use react-table with typescript

can anybody give me a solution.

@tannerlinsley just wondering if you had some time to work on the TS v8? Thank you for the great work!

Working on it right now. ETA 2021

@tannerlinsley Is there a way that I (or we) could contribute to v8? I understand that the process of a rewrite is delicate, so a "no" is perfectly understandable.

Currently no. I’m still crafting the plug-in system which is indeed complex and delicate. After that, things will open up much more.

Good luck @tannerlinsley, it must really tough.
And is there something that we can help with?

Issue can be temporarily solved by adding the react-table-config.d.ts file into a dedicated types folder in the root src folder: /src/types/react-table-config.d.ts
In case you use NX or mono-repo-tools the file and folder structured must be added in the lib using the table component as well as in the app.

Is there any updates on v8?

Still working actively on it.
Tanner Linsley
On Jul 20, 2021, 8:22 AM -0600, Nubami SQReder @.***>, wrote:

Is there any updates on v8?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Still working actively on it. Tanner Linsley

ETA still 2021 ?
V8 means major release means breaking change. Will migration be possible or we'll need to rewrite "everything" ?
I send you some good vibes from France 🌼

Okay I am waiting too.

Eagerly waiting for v8 💪

@tannerlinsley any ETA on this? :)

Are you referring to an ETA on v8?  I'm working on row selection logic right now. You can find the todo list in the main README.md. I'll be cutting a new alpha release very soon.


Implement the program

Hello, I would like to implement the program created by you on two ESP32 Wroom boards. In which program did you write the code? I wanted to put it in the Arduino IDE, do you think it works? Thank you!

Hello, I would like to implement the program created by you on two ESP32 Wroom boards. In which program did you write the code? I wanted to put it in the Arduino IDE, do you think it works? Thank you!

Hi, each folder is an ESP-IDF project, created with VSCODE and Espressif extension for VSCODE. As the GOOSE protocol of IEC 61850 has some time requirements regarding the packets, i created the HAL to send or receive these packets through ethernet only. So, each project should be flashed on a esp32 with ethernet (ESP32-Ethernet-Kit, WT32-ETH01, T-ETH-Lite, etc..). Since each board has its own ethernet pin config, you should edit the project "sdkconfig" (through menuconfig or editing directly inside the project folder) to match your ethernet pin configuration.
I don't know how to export the project to arduino IDE, but i think you would have to start with the "CMakeLists.txt" file inside the "main" folder of each project. This file contains the directory of the source files and the include files necessary to build each program. I think it would work, but don't know how long can take.

Thank you for your answer. Can you please tell me if on the HW connection side you connected each ESP32 board to the computer via the micro usb cable, or if you did it differently? Also after you connected the boards, in order to use enthernet to transmit data you just have to edit the "sdkconfig" project to put the pin configuration in the program, or should I do something else? Thanks a lot!!!

Thank you for your answer. Can you please tell me if on the HW connection side you connected each ESP32 board to the computer via the micro usb cable, or if you did it differently? Also after you connected the boards, in order to use enthernet to transmit data you just have to edit the "sdkconfig" project to put the pin configuration in the program, or should I do something else? Thanks a lot!!!

The boards i used didn't come with usb port, it was necessary to use a USB to TTL converter to flash the code on each esp. After flashing the code, it's not necessary for the boards to be connected to a pc, but they have to be powered on and in the same network with the PLC's used.
In order to use ethernet, it's only necessary to modify the pin config of the project "sdkconfig" (note that each folder is a project).


Add documentation groups/nesting

Attempts to make the hex docs sidebar a bit more readable

@davydog187 thanks!


Add a new memory type: Hierarchy

This PR adds a new memory type called Hierarchy, which exploits power-law degree distribution in graph to reduce inter-node communication.

Hierarchy WholeMemory has the same storage pattern as Distributed WholeMemory and only optimizes the gather function.
Hierarchy WholeMemory can achieve 1.5x-2.0x speedup in multi-node gather, compared with Distributed.
For intra-node host memory location, Hierarchy can still achieve 1.5x-2.0x speedup.

/okay to test

/okay to test

/merge


278

The patch make sure that we do not overrides the configuration files in  common.make_cassandra_env and fix the wrong JMX configuration that was made for Windows in node.__update_envfile.

-1. This patch does not work on OSX, and I suspect Linux.

Thanks for the fix.


Revert ":robot: Package update"

Reverts mandiant/VM-Packages#287
CI failed on merge

The problem is that sysinternals (the dependency) uses a url that doesn't include the version: https://download.sysinternals.com/files/SysinternalsSuite.zip A new update to this url broke the package after vm-packages sent the PR. But this break both the new and the old package. The community package has already released a new version to fix this. So I have trigger the package update manually in https://github.com/mandiant/VM-Packages/actions/runs/4721610932. The resulting PR https://github.com/mandiant/VM-Packages/pull/289 fixes the issue.

Great, thanks!


Notarize Mac app using ESRP

We are moving the app in Apple from the legacy Kinvolk developer account to Microsoft's.
For that, we have to use the ESRP tool that is also used to sign the Windows binaries.

[X] Replace the Mac signing mechanism by ESRP
[X] Use just one ESRP script for Windows and Mac signing

How to test:

In the actions, run the Windows and Mac artifacts with the Sign/Notarize option checked: install the resulting binaries and verify that the OS doesn't complain about them being unsigned

👍 lgtm
note: I didn't test the binary (but I saw Chris did?).

Yup, he has.


IsDirectory is not set correctly

I am using "DokanNet 1.1.0-rc4" and the Dokan Library with version number <IP_ADDRESS>00.
I am implementing a virtual file system where I only allow to copy files into the root folder (no subdirectories allowed).
My test case is copying a directory called "NewFolder" that has one single file in it, "file1.txt".
I successfully deny writing the file, however there is a CreateFile callback for "NewFolder", with "Create" mode, with info.IsDirectory == false. Since this is asking me to create a FILE, and not a folder, it will result in an empty file called 'NewFolder'.
To make it worse, CloseFile is never called on this file handle.
Please take a look at the output:
mvx: Diagnostic:   0.33 Mounted()
mvx: Diagnostic:   0.34 Running command: COPY "C:\Users\csaba.fabian\AppData\Local\Temp\tmp54A4.fldr\" T:\NewFolder\
mvx: Diagnostic:   0.37 Command line: C:\Users\csaba.fabian\AppData\Local\Temp\tmp54A4.fldr\file1.txt
mvx: Diagnostic:   0.38 CreateFile(filePath: "\NewFolder\*", access: ReadAttributes, share: ReadWrite, Delete, mode: Open, options: 00000000, attributes: 0, info.IsDirectory: False ) => ObjectNameNotFound
mvx: Diagnostic:   0.38 CreateFile(filePath: "\NewFolder\file1.txt", access: ReadAttributes, share: ReadWrite, Delete, mode: Open, options: 00000000, attributes: 0, info.IsDirectory: False ) => ObjectNameNotFound
mvx: Diagnostic:   0.38 GetVolumeInformation(out string volumeLabel: Qtalk, out FileSystemFeatures features: CaseSensitiveSearch, CasePreservedNames, UnicodeOnDisk, PersistentAcls, SupportsRemoteStorage, out string fileSystemName: NTFS)
mvx: Diagnostic:   0.38 CreateFile(filePath: "\NewFolder\file1.txt", access: ReadData, WriteData, AppendData, ReadExtendedAttributes, WriteExtendedAttributes, ReadAttributes, WriteAttributes, Delete, ReadPermissions, ChangePermissions, Synchronize, share: None, mode: Create, options: 08000000, attributes: Archive, info.IsDirectory: False ) => AccessDenied
mvx: Diagnostic:   0.40 CreateFile(filePath: "\NewFolder", access: 65, share: None, mode: Create, options: 08000000, attributes: Archive, info.IsDirectory: False ) => Success
mvx: Diagnostic:   0.40 GetFileInformation("\NewFolder\file1.txt", out fileInformation: (FileName: '', Length: 0, Attributes: '0', CreationTime: )) => ObjectNameNotFound
mvx: Diagnostic:   0.40 GetFileInformation("\NewFolder\file1.txt", out fileInformation: (FileName: '', Length: 0, Attributes: '0', CreationTime: )) => ObjectNameNotFound
mvx: Diagnostic:   0.40 GetFileInformation("\NewFolder\file1.txt", out fileInformation: (FileName: '', Length: 0, Attributes: '0', CreationTime: )) => ObjectNameNotFound
mvx: Diagnostic:   0.40 GetFileInformation("\NewFolder\file1.txt", out fileInformation: (FileName: '', Length: 0, Attributes: '0', CreationTime: )) => ObjectNameNotFound
mvx: Diagnostic:   0.40 GetFileInformation("\NewFolder\file1.txt", out fileInformation: (FileName: '', Length: 0, Attributes: '0', CreationTime: )) => ObjectNameNotFound
mvx: Diagnostic:   0.40 Cleanup("\NewFolder\file1.txt")
mvx: Diagnostic:   0.40 CloseFile("\NewFolder\file1.txt")
mvx: Diagnostic:   0.40 CreateFile(filePath: "\NewFolder\file1.txt", access: ReadData, WriteData, AppendData, ReadExtendedAttributes, WriteExtendedAttributes, ReadAttributes, WriteAttributes, Delete, ReadPermissions, ChangePermissions, Synchronize, share: None, mode: OpenOrCreate, options: 08000000, attributes: Archive, info.IsDirectory: False ) => AccessDenied
mvx: Diagnostic:   0.40 CreateFile(filePath: "\NewFolder", access: 65, share: None, mode: OpenOrCreate, options: 08000000, attributes: Archive, info.IsDirectory: False ) => Success
mvx: Diagnostic:   0.40 GetFileInformation("\NewFolder\file1.txt", out fileInformation: (FileName: '', Length: 0, Attributes: '0', CreationTime: )) => ObjectNameNotFound
mvx: Diagnostic:   0.40 GetFileInformation("\NewFolder\file1.txt", out fileInformation: (FileName: '', Length: 0, Attributes: '0', CreationTime: )) => ObjectNameNotFound
mvx: Diagnostic:   0.40 GetFileInformation("\NewFolder\file1.txt", out fileInformation: (FileName: '', Length: 0, Attributes: '0', CreationTime: )) => ObjectNameNotFound
mvx: Diagnostic:   0.40 GetVolumeInformation(out string volumeLabel: Qtalk, out FileSystemFeatures features: CaseSensitiveSearch, CasePreservedNames, UnicodeOnDisk, PersistentAcls, SupportsRemoteStorage, out string fileSystemName: NTFS)
mvx: Diagnostic:   0.40 GetFileInformation("\NewFolder\file1.txt", out fileInformation: (FileName: '', Length: 0, Attributes: '0', CreationTime: )) => ObjectNameNotFound
mvx: Diagnostic:   0.41 SetEndOfFile("\NewFolder\file1.txt") => AccessDenied
mvx: Diagnostic:   0.41 WriteFile("\NewFolder\file1.txt", buffer: byte[10], bytesWritten: 0, offset: 0) => AccessDenied
mvx: Diagnostic:   0.41 GetFileInformation("\NewFolder\file1.txt", out fileInformation: (FileName: '', Length: 0, Attributes: '0', CreationTime: )) => ObjectNameNotFound
mvx: Diagnostic:   0.41 GetFileInformation("\NewFolder\file1.txt", out fileInformation: (FileName: '', Length: 0, Attributes: '0', CreationTime: )) => ObjectNameNotFound
mvx: Diagnostic:   0.41 DeleteFile("\NewFolder\file1.txt")
mvx: Diagnostic:   0.41 GetFileInformation("\NewFolder\file1.txt", out fileInformation: (FileName: '', Length: 0, Attributes: '0', CreationTime: )) => ObjectNameNotFound
mvx: Diagnostic:   0.41 Cleanup("\NewFolder\file1.txt")
mvx: Diagnostic:   0.41 CloseFile("\NewFolder\file1.txt")
mvx: Diagnostic:   0.41 Command line:         0 file(s) copied.
mvx: Error:   0.41 Command line: The parameter is incorrect.
mvx: Diagnostic:   0.42 Command line:
mvx: Error:   0.42 Command line:
mvx: Diagnostic:   3.28 Unmounted()

There is one thing I wonder about, the value of the FileAccess of 65 sent, but I can't find what the flag x40 (64) stands for? Maybe that's what I should filter on?

There is one thing I wonder about, the value of the FileAccess of 65 sent, but I can't find what the flag x40 (64) stands for? Maybe that's what I should filter on?

If I understand everything right, 65 is the same as FILE_DELETE_CHILD | FILE_READ_DATA (see winnt.h)
But in FileAccess, only Read, Write and ReadWrite is defined.
A lot of flags is missing in FileAccess. Question is if we should create our own FileAccess?

Hi @TheFabFab ,
Can you add a logger at the mount ? this will show the correct value before the flag are converted to C#
https://dokan-dev.github.io/dokan-dotnet-doc/html/class_dokan_net_1_1_dokan.html#ac5166c38bbe42cb737aac4e09b117503
There is different logger that you can use already or create your own:
https://dokan-dev.github.io/dokan-dotnet-doc/html/interface_dokan_net_1_1_logging_1_1_i_logger.html
@magol I don't think we should create a FileAccess, the goal of the library is to convert win32 flags to C# like that it can be directly used by FileStream

@Liryna You're right, it was a bad idea to create a new FileAccess.
But then we should do as @TheFabFab proposed, to filter out unused flags the same way we already do for FileAttributes and FileOptions.

:+1: @magol I agree with you !

Oh, apparently I was not entirely wrong. There is already a DokanNet.FileAccess. It have almost all flags that are missing in System.IO.FileAccess.
The only flags that is missing is FILE_DELETE_CHILD(0x0040), MAXIMUM_ALLOWED(0x02000000) and GENERIC_ALL (0x10000000). So the question is whether they should be added, or whether it should be filtered?

Sorry guys, it looks like the command I was running was actually a file copy and not a folder copy. I think my test case was completely wrong. I will test again when I have a working backend (right now I'm running unit tests).

I redid my test scenario using ROBOCOPY and it works perfectly... I am getting the IsDirectory flag.
So... my fault, sorry guys, thanks for your time!

:disappointed:
Ok :+1:


Updates MC documentation towards updates

Towards https://github.com/giantswarm/giantswarm/issues/15700
Please remember to

[x] Give the PR a meaningful title -- it will be shown in the release notes
[x] Add (or remove) user questions associated with any updated docs

I could use a hint on:
ERROR 2021/02/19 11:28:15 [en] REF_NOT_FOUND: Ref "/ui-api/management-api/crd/releases.release.giantswarm.io": "/docs/src/content/general/management-clusters/index.md:28:86": page not found

as that looks correct to me, for https://docs.giantswarm.io/ui-api/management-api/crd/releases.release.giantswarm.io/


Possible enhancement

I wanted to highlight the project here
https://github.com/ArthurHeitmann/reddit_site_stats
https://blackout.photon-reddit.com/
to mention that perhaps as an enhancement to support all of these statuses: restricted, private, public, archived.
Some of the subs on the list in the sticky issue #146 are archived now and have all of the status options supported might be an enhancement to consider.
From the linked production site,

if you’re referring to my fork of reddark (https://reddark.io), i’ve already built in functionality to support the archived status — it displays such subs in red as ‘mods purged’ as that seems to be the reason the subs find themselves in that status.
apologies if i’m misunderstanding what you’re referring to - let me know if so.

Ah, ok, I am new to this language and did not get to that part of the code yet! Yes, and I suppose to clarify, it might be simpler on you if it fits your strategy to report 'Archived' as it's just the data and perhaps easier to automate? Feel free to close this one.

don’t worry! i admit it can be slightly confusing as well with the way i’m dealing with things over multiple repositories.
thankfully, finding out the subs that have ‘archived’ status is fully automatable - it’s something that the reddit api tells me without having to do any manual work.
and although technically it’s not guaranteed tnat a sub with status: archived would be that way because of a purged modteam, i’m feeling fairly comfortable leaving the status text that way for the moment. the reason for this is that ‘archived’ status (to the best of my knowledge) is something that subreddit mods can’t apply to their own sub — i believe a subreddit can only be set to ‘archived’ by the admins. therefore, if a sub is detected as ‘archived’, i think it’s fair to say that the admins have done something with it.
(if i notice that a sub gets set to ‘archived’ in the future but the modteam is left intact, i’ll probably have to change the text of the status label.)

(also, i’m gonna transfer this issue to my reddark fork at username-is-required/reddark, as i believe it refers more to an enhancement to the site - let me know if you think it’s wrong there though)


Replace Apache LICENCE to WTFPL LICENCE

Use WTFPL LICENCE replace apache LICENSE

I've change licence name and licence email to yours. can you merge my pr?@kelseyhightower


[DO NOT MANUAL MERGE] Release Qualification

Trigger release qualification jobs
none

@silverdev: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-cluster_wide-auth.sh
b0eff4b9771a57f2cfe37b3fbe9ba8aecab6af65
link
/test daily-e2e-cluster_wide-auth

prow/daily-e2e-cluster_wide-auth-default.sh
b0eff4b9771a57f2cfe37b3fbe9ba8aecab6af65
link
/test daily-e2e-cluster_wide-auth-default

prow/daily-e2e-rbac-no_auth-default.sh
b0eff4b9771a57f2cfe37b3fbe9ba8aecab6af65
link
/test daily-e2e-rbac-no_auth-default

prow/daily-e2e-rbac-auth-default.sh
b0eff4b9771a57f2cfe37b3fbe9ba8aecab6af65
link
/test daily-e2e-rbac-auth-default

prow/daily-e2e-rbac-no_auth.sh
b0eff4b9771a57f2cfe37b3fbe9ba8aecab6af65
link
/test daily-e2e-rbac-no_auth

prow/daily-e2e-rbac-auth.sh
b0eff4b9771a57f2cfe37b3fbe9ba8aecab6af65
link
/test daily-e2e-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


integrate with libclang to not have to dump to an intermediate file

clang may be magical enough to allow us to integrate with it and pretend that we're a Real Compiler (tm)

Further reading:
https://eli.thegreenplace.net/2011/07/03/parsing-c-in-python-with-clang
https://github.com/eliben/pycparser


Fixes and optimizations

Optimize terrain building by using Sodium's ChunkModelBuilder directly; Resolve #9
Fix compatibility with Sodium's "animate only visible textures" option; Fix #83, fix #64
Port recent Indigo bug fixes
Other optimizations
Rename all occurrences of Indigo to Indium
Make all indentation use tabs
Update Gradle and build dependencies
Update gitignore to support Eclipse

Oooh, this looks very interesting, thank you!

Hmm, ideally I'd cache the sprite at some point so it doesn't have to run SpriteFinder every frame (buffer) / chunk build (terrain). The code seems to also pass fallback BakedQuads through that same code, even though they already contain the sprite so it doesn't need to be looked up. From a bit of profiling though it doesn't seem to have much of an impact.
Animations in buffer (non-terrain) quads don't seem to work properly; I don't think this causes a problem with BakedModel fallback instances since those will have SpriteUtil.markSpriteActive called at some point, but FRAPI Meshes won't do so. The easiest way I've found to observe this is to break a Magma block with a Bits and Chisels chisel to get a Magma Block Bit, then ensure there are no Magma blocks in rendered terrain (might need a low render distance).

Only the TerrainQuadRenderer uses the SpriteFinder.

I meant that TerrainFallbackConsumer is a subclass which has the BakedQuad instance... but I just realised that a QuadTransform can change sprite atlas coordinates, so it isn't safe to reuse the sprite in that BakedQuad anyway.

... but I'm not sure how the caching would work. Do you have ideas?

For dynamic quads using QuadEmitter directly at runtime, I don't think you'd be able to cache anything; but with Mesh you could store a list of Sprites, like ChunkModelBuilder.addSprite. In https://github.com/comp500/Indium/issues/83#issuecomment-899659106 I was thinking you could make it part of the QuadViewImpl/EncodingFormat vertex format but then you wouldn't be able to use a direct object reference; a single list per Mesh is more efficient anyway.

Hmm yeah, I guess you could add a sprite reference (hashmap index? I seem to remember Canvas doing something similar) to the QuadViewImpl vertex format instead? Then if the QuadTransform changes the texture coordinates the cached sprite reference can be removed/regenerated.
I think on resource reload the renderer is recreated?

Neither the renderer nor the meshes are recreated on resource reload. I don't know how changing the vertex format would help but perhaps retrieving all UV values before and after the transform would work. I think doing this would negate any benefit gained from using the sprite array, which was probably negligible in the first place.

Neither the renderer nor the meshes are recreated on resource reload.

Ah I was wrong there, but meshes from all mods still need to be recreated on resource reload otherwise their textures will break. Most mods will cache Mesh instances as part of their block models, which should be recreated on resource reload as they're supplied to the game through ModelResourceProvider. So we can rely on having constant Sprite references in the same way as the Mesh vertex data relies on constant UV coordinates.

I don't know how changing the vertex format would help but perhaps retrieving all UV values before and after the transform would work.

MutableQuadView keeps the vertex int[] data opaque to the caller, so you can store the MeshImpl Sprite[] array index in the vertex format header without affecting any other code, just by adding a field in EncodingFormat (the toVanilla code does an array copy, but only looks at data past the header). There's no need to keep track of UV values before/after QuadTransforms, just set the cached index to an invalid marker value in MutableQuadViewImpl.sprite. Then in TerrainMeshConsumer.renderQuad/BufferMeshConsumer.renderQuad you can index the array and mark the sprite as active, if there is a cached index (after quad transforms are processed) - so you'd at least be able to cache quads that have QuadTransforms that don't modify the texture coordinates.

Alright, this should work, however there is one more issue. What happens if a mesh is built before the atlas is created? Should it be classified as undefined behavior that might crash the game?

I think so, especially since spriteBake would need to use the atlas too.


Return kubernetes errors for a workflow.

Is your request related to a problem? Please describe.
If an error happens at the workflow level or for a task that never actually runs these errors are not surfaced to the user and means there is no problem resolution available to the end user
Describe the solution you'd like
The Flow Activity and Detail to have the ability to surface a workflow level error.
Describe the benefits or justification for this request
This will allow resolution of an issue potentially by an user for example if the wrong container or arguments are specified as part of Run Custom Task
Additional context
FYI: @simon-harris-ibm

@BenjaminRuby now returning error property on invidual task activity or workflow to surface these errors
"steps" : [ {
"activityId" : "60a3e01a20efeb0455304caf",
"duration" : 145,
"flowTaskStatus" : "failure",
"id" : "60a3e01b20efeb0455304cb0",
"order" : 1,
"startTime" :<PHONE_NUMBER>514,
"taskId" : "d2a7ba29-c3a7-4fef-9476-ccb9242d08be",
"taskName" : "Echo Test",
"taskType" : "template",
"preApproved" : false,
"error" : {
"code" : "001",
"message" : "This is a special error"
}
}

@marcusdroy @tlawrie from the UI side I believe this should be in to verify state


how to training on custom dataset?

how to training on custom dataset?

Hi. @jinfagang
We will provide tensorflow2-based training, test and frozen_model codes later.

Hi. @jinfagang
We will provide tensorflow2-based training, test and frozen_model codes later.

how can i have frozen model? please

@vancuonghoang
We already uploaded frozen models.
https://github.com/navervision/mlsd/tree/master/tflite_models

@vancuonghoang   There is a Pytorch version with training code, but a little bit lower result than in the paper and here.
https://github.com/lhwcv/mlsd_pytorch

@jinfagang    There is a Pytorch version with training code, but a little bit lower result than in the paper and here.
https://github.com/lhwcv/mlsd_pytorch

@geonm any update on the tensorflow2-based training code? Great work btw :)

@geonm are there any updates on the TF-2 custom trainings?

@geonm any updates on tensorflow2-based training code? Thanks

@geonm any updates on tensorflow2-based training code? Thanks


[C++][Parquet] Use simd to improve BYTE_STREAM_SPLIT decoding performance

BYTE_STREAM_SPLIT essentially does a scatter/gather operation in the encode/decoder paths. Unfortunately, it is not as fast as memcpy when the data is cached. That can be improved through using simd intrinsics.
Reporter: Martin Radev / @martinradev
Assignee: Martin Radev](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=martinradev) / @martinradev
PRs and other links:

GitHub Pull Request #6679

Note: This issue was originally created as PARQUET-1786. Please see the migration documentation for further details.

Antoine Pitrou / @pitrou:
Issue resolved by pull request 6679
https://github.com/apache/arrow/pull/6679

Martin Radev / @martinradev:
I need to submit also the encoder improvement.

Martin Radev / @martinradev:
Will do.

Wes McKinney / @wesm:
Please leave resolved issues in "Resolved" state otherwise they will not show up in changelogs

Antoine Pitrou / @pitrou:
Can you please open a separate issue for the encoder?

Martin Radev / @martinradev:
Closing.


Add no header/ph fixtures

Together with #273 will close #223.

Discussed on the WG call of the 10th of July. Will rebase and merge afterwards.

Discussed on the WG call on the 10th of July. Approved. Vectors are cross validated! Merging


LinearProjector getNextSegments

Hello, I found a problem LinearProjector#getNextSegments. It seems to concatenate the path segments without separating them with ".", so subsequent paths don't get split up correctly, and the document can't be further queried.
I'd propose changing
    private String getNextSegments(String[] pathSegments) {
        return Arrays.stream(pathSegments).skip(1).reduce("", (a, b) -> a + b);
    }

to
    private String getNextSegments(String[] pathSegments) {
        return Arrays.stream(pathSegments).skip(1).collect(Collectors.joining("."));
    }

I think that will fix the problem; if I fixed the path being returned from this method in my debugger, my tests succeeded just the same as when I run them with an actual mapr connection. I'd make the change myself, but the project doesn't build for me, and I know nothing about sbt to try to fix it.

That is fine, I think. Do a PR and I will publish a new version


Working example with all the files?

Hi,
I am trying to set up my new app and I am not able to find a working example.
Can you please share a demo link with all its source code?
Thanks

I'm facing the same problem however I was able to get the line and doughnut/pie charts to work.
What I did is that i opened the source file called Chart.js found in bower_components/chartjs/Chart.js and searched for the required attribute names and tried to figure out the format of data. There are also files for each type of chart called Chart.Bar.js etc.. however modifying them would have no effect, they're just used as some sort of archiving.
The thing is this module is using an old version of Chart.js, I'll try to post my working examples soon, however I'm really busy these couple of days because of my bachelor thesis :)
@adityasingh-ruckus

Hi @alyakan
Thanks for your response.
Even I was able to get it working, unfortunately I can't get it to work in my template files, except for application.hbs.
To give a small example, I am using mirage to populate dummy data, if I want to populate the same data in charts for my templates, I can't do that. I will really appreciate your help!

There is a link from the chartjs docs to the old version docs: https://github.com/chartjs/Chart.js/tree/v1.1.1/docs

Oh my god thanks :)

Hi,
I was able to get it working, but now I am facing a new issue.This never seems to end :)
So my problem is that instead of requesting data from the controller, I need the same data which is in routes. I am not able to use the ''client_details'' variable. Any help will be appreciated.
Below is what my routes code snippet looks like.
export default Ember.Route.extend({
model: function(){
var client_details = this.store.findAll('client');
return client_details;
},
pieData: Ember.computed(client_details, function(){
return [
{
value: parseInt(200),
color:"#F7464A",
highlight: "#FF5A5E",
label: "Red"
},
{
value: parseInt(50),
color: "#46BFBD",
highlight: "#5AD3D1",
label: "Green"
},
{
value: parseInt(20),
color: "#FDB45C",
highlight: "#FFC870",
label: "Yellow"
}
];
})
});


Write guidance on how to avoid memory leak in client projection

We throw exception message which has some details and a fwlink https://go.microsoft.com/fwlink/?linkid=2103067
Write a page to use for fwlink.

Pending task here is to update fwlink to point to right location after docs are published.
cc: @ajcvickers

@smitpatel Where should it point to?

https://docs.microsoft.com/en-us/ef/core/querying/client-eval#potential-memory-leak-in-client-evaluation


change Client to keep connector as a Box

This removes the generics from Client, letting people use a Client easily without caring what connecting and streaming business is going on underneath.

cc #346