It works with a Roamer series two battery (200SMART2)

Hi,
Just to confirm that I've tried this with a Roamer series two battery (model: 200SMART2) and it appears to be working fine.  It only has four cells (from the BMS's point of view) so I just removed all but four from the config.  I also need to figure out which one of the four temperatures is the one that the Android app displays (it's showing 0, 25, 25, and 4, so it's not simply the case that the irrelevant ones are 0).
A small tangent - how straightforward would it be to take the information in the sources of this module and turn it into a Python script that I can run on a Raspberry Pi, do you think?  I like esphome but I'm not using it where I have this battery, and don't usually have a suitable wi-fi access point for the esp to connect to (I set one up just to test this).
Thanks for creating this.
Rob.

Thanks for your feedback! I've added your battery to the list of supported devices. If you are familiar with python and BLE communication it should take a day to add the BMS support to the mpp-solar project for example.

Thanks for the pointer to mpp-solar, I hadn't come across that, will take a look.


German Scheme Feedback: Cloud Equivalence Considerations

Last sentence.
"However, if cloud authorizations exist for multiple regions or datacenters in which a CSO is found to meet similar requirements constistently this may be leveraged as equivalency rationale. In addition, each CC scheme has the option to define a policy
for acceptance criteria." Suggestion: "[...] policy for acceptance criteria of  equivalence classes." Otherwise it might sound as if acceptance criteria for cloud authorizations are meant.
In addition, please fix the spelling of consistently (noted by Josh)

Assigned for spelling error.
Response: We do mean acceptance criteria for cloud authorizations.  We will update the existing sentence to state this explicitly.


Init next.js for frontend and add Kakao map sample

introduce next.js framework for frontend
Kakao map sample page (/map-sample) is added

API key might be put in .env.local, or set within AWS build setting

URL: https://main.d3v99qhrbr5x1m.amplifyapp.com/map-sample
screenshot:


can't enter text using keyboard

I have a problem with my Lilygo T-Keyboard. When I got the device I installed the firmware (v2.5.5.e182ae7) and I could happily type on the keyboard. Then I connected through Bluetooth and used the device from the phone. Now I don't seem to be able to use the keyboard anymore. The only actions I can perform on the keyboard is Alt-B to activate the backlit keyboard and click any button to wake up the monitor. I cannot enter text.

@marimes This repository is for the LILYGO T-Deck: https://www.lilygo.cc/products/t-deck
I'm not familiar with the version of firmware you mentioned. If you're looking for the official repository for the LILYGO T-Keyboard, its here: https://github.com/Xinyuan-LilyGO/T-keyboard/issues
If I've misunderstood, please let me know and I'll re-open this issue.


(569a) Restore E2E tests

We disabled the E2E tests on the UI in https://github.com/ministryofjustice/hmpps-accredited-programmes-ui/pull/98. We want to re-enable them, but first we need to update the tests to match the current dev data. This does that

 Re-enable E2E CI step


Feature Request: Ability to configure what generated file types get pulled into the project

As a rules_ios user I've noticed that some generated files that are an implementation detail of rules_ios are being pulled into Xcode. I'd appreciate the ability to filter those out.
When generating a project, I noticed some performance issues while editing code in a big codebase with many rules_ios frameworks and filtering out unneeded file types has improved the experience for me.
As an example, run this from this repo's root:
cd examples/rules_ios
bazel run //:xcodeproj-incremental

and note how you can cmd+shift+o and find *_vfs.yaml or *.extended.modulemap files:

We could introduce a global setting here that allows consumers to configure this (say by specifying which generated files .extension types are allowed/not allowed to be processed). That could be a feature consumers are supposed to set in their rc files or a setting specified at the xcodeproj macro level? For example:
xcodeproj(
  ...
  allowed_generated_file_extensions = [".h", ".m"],
  # or
  exclude_generated_file_extensions = [".yaml", ".modulemap"],
)

Thoughts? cc @brentleyjones.

Alternatively we can simply not process any generated file here.

Perhaps a combination of both in which some generated files are automatically not processed and also ability to specify additional file types?

Perhaps a combination of both in which some generated files are automatically not processed and also ability to specify additional file types?

@dnkoutso one thing @brentleyjones and I are considering is to use .is_source and avoid over collecting here. The problem is that that would also stop collecting potentially desirable .h files (say generated headers consumers do want to see in Xcode).
So one idea I'm proposing is to not collect any generated file by default, but allow consumers to set a flag at the xcodeproj macro level that "allows generated headers". I think trying to handle file types more generically is probably a feature nobody wants atm since this code path is about headers processing, hence my suggestion to focus on headers collection configuration only.
But, open for suggestions here, I'm trying to keep this small so we don't try to cover more use cases than needed here until there's a real need. Does that make sense?

Perhaps a combination of both in which some generated files are automatically not processed and also ability to specify additional file types?

@dnkoutso We're considering to stop processing generated files and effectively stop over collecting here instead of trying to come up with a way to expose something configurable to users.
This is a lot simpler than what I suggested and we can ensure that generated source files continue to be collected somewhere else. We'll keep this issue updated.

For future reference, this branch illustrates my use case btw: https://github.com/MobileNativeFoundation/rules_xcodeproj/compare/thiago/generated-file-extensions
cd examples/rules_ios
bazel run //:xcodeproj-incremental

My intent is to continue to allow such a project to index *.pbobjc.m and *.pbobjc.h files since those are relevant to developers and they might want to cmd+shift+o these and inspect APIs and types. But, most other files rules_ios generates (including but not limited to some .h files) are implementation details and not necessary in Xcode.

I think #3017 addresses this.

I think #3017 addresses this.

It does, thank you!


Smarter 1559 // Chain Utils // Caching

PR-Codex overview
The focus of this PR is to enhance gas fee estimation and caching mechanisms for Thirdweb transactions.
Detailed summary

Updated EstimateGasFees method to return max fee per gas and max priority fee per gas
Added caching for chain data and EIP-155 enforcement status
Implemented methods to check EIP-1559 support and enforce status
Improved error handling for chain data fetching and EIP-155 enforcement detection

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Codecov Report
Attention: Patch coverage is 84.50704% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.81%. Comparing base (9e3cbce) to head (bb8c2e7).

Files
Patch %
Lines

Thirdweb/Thirdweb.Utils/Utils.cs
89.83%
3 Missing and 3 partials :warning:

...rdweb/Thirdweb.Transactions/ThirdwebTransaction.cs
58.33%
4 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   82.71%   82.81%   +0.10%
==========================================
  Files          25       25
  Lines        3158     3218      +60
  Branches      414      423       +9
==========================================
+ Hits         2612     2665      +53
- Misses        464      468       +4
- Partials       82       85       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Dedicated branch for Pull Requests

Hello.
There will be definitely more pull requests as the project grows. I think it looks cleaner just to have a dedicated branch for pull requests. Then, later on, it can be merged into master.
Maybe call it nightly or something.
Cheers.

I think this repo will be forked and then made read-only after the series comes to a halt. The newer fork can be put out for being further developed by the community

As the project is growing, having 1 commit/PR isn't that bad, and it is also handy to look back at the commits to see what happened between the episodes on the series. Closing this for now, if we need it in the future, we can always add a new branch. For big features, of course we can still create new branches until it is fine tuned, or when the series come to a halt (touch wood, hopefully not any time soon).


EPIC: Docs v2 — tutorials

[ ] https://github.com/rollchains/spawn/issues/66
[ ] https://github.com/rollchains/spawn/issues/168
[x] nextra site, like https://docs.ignite.com/welcome/install

New docs site is up. Going to add more blog like content to explain things + sdk context, then will do videos over each section as a direct walk through for what is going on.

Completed


Safari: React-Intl warning

Fix this:
Safari: React-Intl warning
"Invariant Violation: [React Intl] The Intl APIs must be available in the runtime, and do not appear to be built-in. An Intl polyfill should be loaded.
See: http://formatjs.io/guides/runtime-environments/"

http://formatjs.io/guides/runtime-environments/#polyfill-browsers
"The Intl APIs are currently available on all modern browsers except Safari"
"It is recommended that you separate the Intl polyfill from your app's JavaScript code bundle so the polyfill is only loaded in the browsers which need it."
Polyfill can be found here:
https://github.com/andyearnshaw/Intl.js
Plan to fix: server can detect if the Client browser is Safari, then include the polyfill as a script tag.


ERR_CONNECTION_REFUSED 8125/UDP

When I try and connect to the dd-agent remotely through the 8125/udp port.  I get an ERR_CONNECTION_REFUSED.
From Docker Shipyard I verified that they port is mapped
Exposed <IP_ADDRESS>:8125 → 8125/udp
Here portion of the docker-compose.yml file that I am using to start the docker-dd-agent.
dd-agent:
image: datadog/docker-dd-agent
container_name: dd-agent
volumes:
- /var/run/docker.sock:/var/run/docker.sock:ro
- /proc/:/host/proc/:ro
- /sys/fs/cgroup/:/host/sys/fs/cgroup:ro
ports:
- "8125:8125/UDP"
- "9001:9001"
environment:
- VIRTUAL_HOST=dd.uorder.us
- API_KEY={my key}
If you want to see the full yml file. At https://github.com/moltra/Docker_Nginx_Nginx-Proxy_LetsEncrypt_Shipyard_composer/blob/master/Docker_Nginx_Nginx-Proxy_Shipyard_Datadog.yml

Hi @moltra
Thanks for the feedback. Can you detail a little bit how you attempt to use this port? 8125 is used by dogstatsd in UDP mode so it's simply waiting for dogstatsd metrics and not expecting any connection.
If you aren't already familiar with dogstatsd you can learn more about it here, about how to use it here and about how it works in containerized environments here.

I am learning how to use dockers, and I have a docker-compose.yml created to setup multiple docker containers and when those docker containers are setup.
I was hoping to be able to see the graphs  right on the web server.  I might have miss understood the way your agent works,

To see graphs you will need to connect to the website, the agent is only there collect metrics and act as a dogstatsd server to forward to our backend metrics you send to it (through port 8125 by default).
I'll close this issue as the behavior is expected, but feel free to open a new one if you find unexpected behavior or to reach out to support if you need help with using Datadog.


fix #1268

Additionally to fixing that issue in the study description page (delete), I also fixed the edit page and found that qiita_pet/templates/study_description.html was a leftover from previous GUI versions (thus, remove it).

Coverage decreased (-0.06%) to 84.012% when pulling 4cce0d3e45aa0b2540a37616bb60f75b84057848 on antgonza:fix-1268 into 5ab58d49261d0e56fdf3b5436b36219773787735 on biocore:master.

So if I'm understanding, the study_description page is now obselete, which is why you are deleting it.
If so, think this ok 👍

@mortonjt Yes, that's one thing the other is that I'm fixing #1268 (JS errors due to single ' ")

👍


If uploading to s3, is it possible to set the file as public?

I'm very new to using s3 storage—but I cannot figure out a way to set the uploaded image permission. I'm hoping to not have the entire bucket set as public.
EnhancedMarkdown::make('Body')
  ->hideFromIndex()
  ->alwaysShow()
  ->disk('s3')
  ->path('posts')

Would I need to use the parseFile() function somehow?
Thanks! I love the file up loads with the markdown field!

Hi @nathangross, you should be able to use any disk driver, including the s3 one (I just tested it, and it works).
You may need to google how to configure the s3 server on AWS to be secure, etc, but on laravel side you just need to ensure that the s3 driver has set the visibility to public (on the config/filesystems.php` file), you can also create another disk driver for that purpose (is what I usually do)
For example:

closing this as the above should work for it and no further interaction has occurred since

Yep, thank your for the detailed response. Sorry for the late reply—that worked great!


German Translation

German Translation for bitcoincash.org
First time using GitHub do I don't know if I did this pull stuff correctly

Haha saw it too late that you already did it. Was also 3/4 through.. fast germans

Unlucky haha. If you have something that you find sounds better than mine be free to criticize, I'm in no way a professional writer :)

I like your translations.  Händler sowie Nutzer sind durch dieses in der Lage schnelle, günstige und zuverlässige Transaktionen zu tätigen. Vor uns liegt eine vielversprechende Zukunft - ohne künstlich eingeschränktes Wachstum - mit zugangsfreier Innovation und dezentralisierter Weiterenwicklung von Bitcoin Cash."

Thank you very much for the fixes. I wrote it in Notepad++, which didn't highlight my fatfinger errors. As for the close to the source translation, do you think it sounds forced, or is it natural? I wasn't sure how close to the source it should be.

I'm sure my translations didn't contain less errors. I think it's fine to be a bit closer to the english version as I was.

A german translation was provided in the main repo at https://github.com/bitcoincashorg/website. This now has conflicts but I would love if you would go over the existing translation and provide updates/comments. Thank you for your help!

Sorry, but that translation is horrible. This guy also seems to have skipped every german lesson in school because he uses no commas. Enjoy a subpar translation, that was added later than mine.

Since you both worked on this together I am happy to use the updated version. Seems more work was done on it. Could you just repost on the actual site? Technically I shouldn't be merging PR's here, this is just my work area.
I just didn't see this one yet because I always check the main repo for submissions first. Didn't mean to be rude.

I hope I added it correctly this time I'm new to github. Sorry if I was rude, I was just a bit dumbfounded because this translation was "reviewed" by tbrannt and had things changed.


Does the dependencies field support directories/blobs?

I have a ./nix/ folder in a project, and I would like hie-bios to reload components if any file in this directory changes.

Does hie-bios support directories? E.g. nix/
Does hie-bios support blobs? E.g. nix/*.nix

I propose this issue is also used to track adding this information to the readme, if you agree?
Thank you!

Does hie-bios support directories? E.g. nix/

Yes

Does hie-bios support blobs? E.g. nix/*.nix

No

I propose this issue is also used to track adding this information to the readme, if you agree?

Of course!

Thanks for the quick answer :pray: I'll try to find some time to propose a PR to update the readme.
By the way, how am I to test this feature? Say, if I modify a file of dependencies, then hie-bios (and HLS?) should auto-reload the project?

Actually, I am very sorry, I confused the question and thought it was asked what the path syntax is supporting
The dependency field itself only supports files, so no directories, or globbing! Again, very sorry for the confusion.

By the way, how am I to test this feature?

Yeah, in ghcide and HLS, if these files change in any way, it should cause an auto-reload of the project, iirc

Oh, so hie-bios itself doesn't use this field, but merely communicates it to the consumer (Ghcide, HLS, etc.)?

Yeah, exactly!


Improved Json support

Rewrite Json to rely more heavily on the builtin JSONSerialization. All it would do is handle subscripting and retrieving values.
JsonBuilder and JsonProperty would still be available.
JsonBuilder would support tuples as well:
Json {
    ("key", "value")
}

Provide optionals for .string, .int, etc. Possible named .stringOptional?

See #9


Upgrade VstsTaskLib to 0.11.0 everywhere to fix fails on logging when any filenames contain [ or ]

Required Information
I recently ran into the same issue as microsoft/azure-pipelines-tasks#6314, but for the MSBuild task with:

Azure DevOps Server Dev17.M153.5 (This is an Azure DevOps Server 2019 Update 1.1)
Agent 2.153.1
MSBuild task 1.151.1 (which seems to use vsts-task-lib 2.2.1 and VstsTaskSdk 0.8.2)

Question, Bug, or Feature?
Type: Bug
Enter Task Name: MSBuild, and more
Environment

Azure DevOps Server

Dev17.M153.5 (This is an Azure DevOps Server 2019 Update 1.1)

On Premise Agent

Agent 2.153.1,  MSBuild task 1.151.1

Windows 10

Issue Description
Same issue as https://github.com/microsoft/azure-pipelines-tasks/issues/6314, but for the MSBuild task
It seems that the fix was done in the powershell VstsTaskSdk 0.10.1, but that never ended up in the release notes: https://github.com/microsoft/azure-pipelines-task-lib/issues/651
Since the MSBuild task, and others, still use older versions of the VstsTaskSdk, they still all have that issue

The issue is still valid, but it is unclear to me who the product owner is for this (and why it’s not being picked up)

The issue is still valid, but it is unclear to me who the product owner is for this (and why it’s not being picked up)

@damccorm do you happen to know who owns the MSBuild task? This issue is still relevant since VstsTaskSdk has not been updated yet in the MSBuild task

I added the appropriate team's label, its now on their backlog to address as appropriate

Hi @japj we have already updated azure-pipelines-task-lib dependency for MSBuild task (which includes VstsTaskSdk dependency) - I think you just need to update Azure DevOps Server to receive last updates.

@anatolybolshakov we have recently updated to AzureDevOps Server 2020.
With the server upgraded we now have:

MSBuild Task 1.166.2

which (still) includes VstsTaskSdk 0.8.2

In which version of the server is this expected to be fixed?

0.8.2 is still mentioned in https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/MSBuildV1/make.json
so that might explain it

please note there are several other make.json files containing a nuget external reference to an old version of the VstsTaskSdk

@anatolybolshakov any update on this?

Hi @japj we are working on testing of these changes at the moment.

@japj we merged related fix, will let you know once these changes are rolled out to production.

@anatolybolshakov please note that we are on Azure DevOps Server (2020 atm). Is this fix target for inclusion in an Update 1 RC2? Or will it be in Update 2?

@japj I can't say exactly at the moment, but this should be available in the next release.
As another option to get these changes quickly - you can build MSBuild task from source and upload it to your organization via tfx-cli tool.

Hi @japj the fix for this version has been already rolled out for cloud, so I'm closing this at the moment - but it could take some time for this change to be rolled out for on-prem.


Error: fatal: could not create work tree dir 'technowlogger': Read-only file system

Describe the Error

Expected behavior

Additional context

┌──(kali㉿kali)-[~]
└─$ git clone https://github.com/PushpenderIndia/technowlogger.git
fatal: could not create work tree dir 'technowlogger': Read-only file system
┌──(kali㉿kali)-[~]
└─$ cd /opt/
┌──(kali㉿kali)-[/opt]
└─$ git clone https://github.com/PushpenderIndia/technowlogger.git
fatal: could not create work tree dir 'technowlogger': Read-only file system

It has nothing to do with this tool, there is some permission error in your
linux
On Wed, 8 Mar, 2023, 7:07 pm sj1702, @.***> wrote:

Describe the Error Expected behavior Additional context
┌──(kali㉿kali)-[~]
└─$ git clone https://github.com/PushpenderIndia/technowlogger.git
fatal: could not create work tree dir 'technowlogger': Read-only file
system
┌──(kali㉿kali)-[~]
└─$ cd /opt/
┌──(kali㉿kali)-[/opt]
└─$ git clone https://github.com/PushpenderIndia/technowlogger.git
fatal: could not create work tree dir 'technowlogger': Read-only file
system
—
Reply to this email directly, view it on GitHub
https://github.com/PushpenderIndia/technowlogger/issues/67, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANORYIXYKFJNVXR4YZMSS43W3CDQFANCNFSM6AAAAAAVTY54J4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Expose nonce parameter

What I did

changed transfer, deploy and transact functionality to expose the nonce parameter
minor clarification in error messages
added test cases for manual nonce

Related issue: #484
How I did it
Added nonce as kwarg or dict element when creating a transaction. E.g.:
accounts[0].transfer(accounts[1], nonce=5)
tester.doNothing({"from": accounts[0], "nonce": 5})
How to verify it
run tests
Checklist

[ ] I have confirmed that my PR passes all linting checks
[x] I have included test cases
[x] I have updated the documentation
[x] I have added an entry to the changelog

Codecov Report

Merging #488 into master will decrease coverage by 26.37%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #488       +/-   ##
===========================================
- Coverage   78.89%   52.52%   -26.38%
===========================================
  Files          56       56
  Lines        6089     6087        -2
  Branches     1338     1338
===========================================
- Hits         4804     3197     -1607
- Misses       1086     2568     +1482
- Partials      199      322      +123

Impacted Files
Coverage Δ

brownie/network/account.py
50.00% <ø> (-41.82%)
:arrow_down:

brownie/network/contract.py
47.88% <100.00%> (-42.89%)
:arrow_down:

brownie/_cli/bake.py
0.00% <0.00%> (-100.00%)
:arrow_down:

brownie/_cli/init.py
0.00% <0.00%> (-100.00%)
:arrow_down:

brownie/_cli/compile.py
0.00% <0.00%> (-100.00%)
:arrow_down:

brownie/_cli/run.py
0.00% <0.00%> (-88.89%)
:arrow_down:

brownie/_cli/test.py
0.00% <0.00%> (-85.00%)
:arrow_down:

brownie/_cli/ethpm.py
16.10% <0.00%> (-74.58%)
:arrow_down:

brownie/network/alert.py
25.80% <0.00%> (-72.59%)
:arrow_down:

brownie/_cli/networks.py
11.85% <0.00%> (-65.47%)
:arrow_down:

... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2878bb...c89e9b8. Read the comment docs.


add latest consume test

Codecov Report

Merging #28 (45ee0b7) into main (19406e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   32.86%   32.86%
=======================================
  Files           8        8
  Lines         572      572
=======================================
  Hits          188      188
  Misses        365      365
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19406e5...45ee0b7. Read the comment docs.


Designing the algorithm for generating invoice no for the invoice

To create the invoice report (here), we would need the following items

Invoice number: It will have the format - Client Type - Client ID - Project ID - Invoice sequence
for example(IN-001-001-0001  for international it is EX-001-001-0001). Client ID, Client Type, and Project ID would be available in the database. To get the invoice sequence, we would have to add 1 to the count for each client and its project, how many invoices have been sent. The invoice number will be a different column in the invoices table, with a text/Varchar data type. It would be calculated and stored at the time an invoice is created.

IGST, CGST, SGST -  Currently, we have Haryana as the billing state, that we can store in the config of invoices module. Upon invoice details listing, we will have to see if the client's state is the same as the billing state, the CGST value should be 9%(picked from config) and SGST value should be 9%(picked from config), IGST will remain null in this case. If the client's state is different from the billing state, the IGST value would be 18% (picked from config), and CGST and SGST will remain null in this case. The client's state can be picked from the database.

To create the invoice report (here), we would need the following items

Invoice number: It will have the format - Client Type - Client ID - Project ID - Invoice sequence
for example(IN-001-001-0001  for international it is EX-001-001-0001). Client ID, Client Type, and Project ID would be available in the database. To get the invoice sequence, we would have to add 1 to the count for each client and its project, how many invoices have been sent. The invoice number will be a different column in the invoices table, with a text/Varchar data type. It would be calculated and stored at the time an invoice is created.

IGST, CGST, SGST -  Currently, we have Haryana as the billing state, that we can store in the config of invoices module. Upon invoice details listing, we will have to see if client's state is same as the billing state, the CGST value should be 9%(picked from config) and SGST value should be 9%(picked from config), IGST will remain null in this case. If the client's state is different from billing state, the IGST value would be 18% (picked from config), CGST and SGST will remain null in this case. Client's state can be picked from the database.

clarified Requirements

Invoice Number format - <IN/EX>

<IN/EX> - IN for indian clients, EX For international clients
Client Id - Id of client stored in DB
Project Id - Reference ID (client_project_id) of projects stored in DB
Invoice Id - Invoice sequecne number. If it is the first invoice then it should be 000001, If it is 10th invoice then it should be 000010

We need to store Haryana in Config and check if the client state matches the config value. If yes then the CGST, IGST should be 9% (picked from config), For other states it should be 18% (picked from config).

For international client it should 0

The feature is implemented as per requirement
Refer screenshot


Fix #101, Add ties to v2/v3

In addition to adding Ties recognition, I also changed it to where only competitive calls ask for games_played, losses, and win_ratio.
Blizzard's site for Quickplay doesn't show total games anymore, just games_won.
Example, a v2 call to stats/general:
"overall_stats": {
    "games": 0,
    "wins": 374,
    "avatar": "https://blzgdapipro-a.akamaihd.net/game/unlocks/0x0250000000000BBA.png",
    "comprank": 2395,
    "prestige": 1,
    "losses": 0,
    "level": 20,
    "win_rate": 0
}

nice merge commit

Yeh, problems of working 8 hours a day. Accidentally pushed before pulling.


How to export the decoder of MedSAM as ONNX file?

Hi, I recently introduced with Segment Anything Model and then about MedSAM. It really works fine when I set it up locally and the segmentation outputs looks great on different medical images.
I want to export the model checkpoint as ONNX standard. Can anyone please guide me how to do it or share any reference/scripts via which I will be able to do the aforementioned? Thanks in advance.

Hi @iamskab001 ,
Great question. Unfortunately, we don't have experience in ONNX yet. Any contributions are welcome!


Comparing free energies of training/validaton sets while training

Hi. Great work on this project.  I was just wondering if you've done any work on calculation of free energies of the model.  The Hinton paper warns against using the reconstruction cost function as a guide and suggests using the ratio of average free energies from training and validation sets.   Any direction in this area?

Hi, I don't work with RBM for more than 2 years, so I don't have any advice for it. But if you have time it will be great to implement it.


Checkboxes on Step 2.2 not clickable

Step2.1 has been completed:

we should disable refresh button when go to 2.2 and back to 2.1.

Progress status display to improve.

refresh -> regenerate


Disable failed REST API tests

Motivation and context

How has this been tested?

Checklist

[ ] I submit my changes into the develop branch
[ ] I have added a description of my changes into the CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

@azhavoro, @Marishka17, I suggest disabling these tests while we fix them.


pwarp renaming inssufficiant permmision

Describe the bug
whenever you try and rename your pwarp and put the new name in chat you don't have permission to change it
To Reproduce
Steps to reproduce the behavior:
go into pwarp menu
edit your pwarp
change the name
put the name in chat
get denied
Screenshots

Username:
REDJEFF
Server name (all applicable):
atlas

Closing, Duplicate of #1902


Ability to add a local code reviewer JSON file

I would like to be able to reference a local JSON file that contains groups of reviewers in the URL to json field in Reviewer Groups via a file URI. For example, file:///folder/reviewers.json.
This would also help resolve, though not entirely, issue #24 because that file could be put into a shared repo.

Just to be clear, if this is what the "Allow access to file URLs" checkbox in Chrome is for, it does not work for me. The result is "Error: TypeError: Failed to fetch"

As a workaround, you could use the raw url to the file in source control. I.e http://git.mycompany.com/projects/PROJ/repo/path/to/file.json, or whatever the url is. As an added bonus, you wouldn't have to git pull / git fetch the branch if someone made changes to the file.

That's a good suggestion. Unfortunately, I tried it and got this error - "Error: SyntaxError: Unexpected token < in JSON at position 0". Any thoughts on why that might happen? Perhaps because of the company firewall?
I added a screenshot too.

The link you have it looks like a regular bitbucket file browser link, so
it's likely giving you html, not the raw file. Go to that link, click the
raw button and use that link. The firewall won't be an issue as long as
your computer is networked, since it's just an ajax call.
On Fri, Apr 21, 2017, 4:02 PM rtrr<EMAIL_ADDRESS>wrote:

That's a good suggestion. Unfortunately, I tried it and got this error -
"Error: SyntaxError: Unexpected token < in JSON at position 0". Any
thoughts on why that might happen? Perhaps because of the company firewall?
I added a screenshot too.
[image: extension_via_git]
https://cloud.githubusercontent.com/assets/23665454/25295996/ec31fc4a-269a-11e7-8856-ad8769ef8fc8.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dragouf/Stash-Reviewers-Chrome-Extension/issues/39#issuecomment-296304956,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGn44GM17eYREJWw-PNfwhgIhNvyPtgWks5ryRligaJpZM4MgCxc
.

Good catch. But using the raw link I get the same error.
Link path: https://[MyGitPathHere]/raw/reviewer_groups.json?at=refs%2Fheads%2Fmaster
I also tried at a specific commit in case it didn't like the path formatters:
https://[MyGitPathHere]/raw/reviewer_groups.json?at=ebdcf33a7095571dc4b0126f0f004fa3649a35a7
It feels like I'm missing something obvious, but it's Friday and multi-tasking is not making me smarter.

Maybe the problem is, that extension (background task) doesn't have access to your repository, as fetching is done without credentials.


Expired root metadata blocks updating current root metadata

When attempting to get the most up to date root metadata, the client rebuilds the chain of trust, but in doing so, expired metadata will return an error and prevent the update from happening.

Good point. I thought I had specified this with step 0.2 in the client update workflow, but it looks like I missed saying the same for step 1.5.
However, we should be careful here, because I think at least the last (or at least, the last one that an attacker may make available) root metadata file should not have expired.
@JustinCappos: what do you think?

I agree with your assessment.  Please update the document to make it
clearer.
On Tue, May 30, 2017 at 9:28 PM, Trishank Karthik Kuppusamy <
<EMAIL_ADDRESS>wrote:

Good point. I thought I had specified this with step 0.2 in the client
update workflow
https://github.com/theupdateframework/tuf/blob/c1e72e0fdd092c5d71d52ffa345893b4a8013a25/docs/tuf-spec.txt#L942-L943,
but it looks like I missed saying the same for step 1.5.
However, we should be careful here, because I think at least the last (or
at least, the last one that an attacker may make available) root metadata
file should not have expired.
@JustinCappos https://github.com/justincappos: what do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/heartsucker/rust-tuf/issues/49#issuecomment-305056005,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0XD0ggKG8LpwGb0HEDlg15aHtCAAvLks5r_MJQgaJpZM4Np9bV
.


SQL Agent with single step set to go to the next step and wont change - Multiple issues

Version: 1.5.1-insider (user setup)
Commit: 31614247cf341abc9194080d0ab7eb720257fb06
Date: 2019-03-13T21:24:09.603Z
VS Code 1.30.1
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Windows_NT x64 6.1.7601
There was several bugs found when trying to create a job ( didnt know if should have raised seperate tickets)

summarised below

Jobs missing steps that had been created

Deleted job still showing even after refresh and alllowing access to edit

Couldn't save change to job step on success action - stayed the same

Job owner was showing incorrectly between Azure Data Studio and management studio

Steps to Reproduce:

Create a new SQL Agent Job - Click + New Job

2 Add new step add details and click OK

[Note can't use the Run As box will not select anything]
3 Click ok

4 I realised at this point I should have gone into and edited the job to step to complete. Filter the job and Edit job
5 I noticed recreating these steps another issue has occurred, going back into edit the job it shows as there are 0 steps

Management studio disagrees

6 Click on Edit Job the job owner i set as SA is showing as my AD account (obfuscated to remove company details)

however as you can see management studio shows correctly

7 I delete the job through management studio, refresh and it is no longer there. I go back in Azure Data studio and hit refresh and it still shows the job.  I redo the filter to "test job" and it still appears. I can click on it and it allows me to edit it, however it wont let me save it.
Microsoft.SqlServer.Management.Smo.FailedOperationException: Attempt to retrieve data for object failed for Server 'FCL-SQL-VC200A'. ---> Microsoft.SqlServer.Management.Smo.MissingObjectException: The Job 'Test Job' does not exist on the server. at Microsoft.SqlServer.Management.Smo.Server.GetSmoObjectRec(Urn urn) at Microsoft.SqlServer.Management.Smo.Server.GetSmoObject(Urn urn) --- End of inner exception stack trace --- at Microsoft.SqlServer.Management.Smo.Server.GetSmoObject(Urn urn) at Microsoft.SqlTools.ServiceLayer.Agent.JobData.get_Job() in D:\a\1\s\src\Microsoft.SqlTools.ServiceLayer\Agent\Jobs\JobData.cs:line 688 at Microsoft.SqlTools.ServiceLayer.Agent.JobData.CheckAndLoadGeneralData() in D:\a\1\s\src\Microsoft.SqlTools.ServiceLayer\Agent\Jobs\JobData.cs:line 762 at Microsoft.SqlTools.ServiceLayer.Agent.JobData..ctor(CDataContainer data, AgentJobInfo jobInfo, ConfigAction configAction) in D:\a\1\s\src\Microsoft.SqlTools.Service...
I try and recreate the job and the same thing occurs.
My original issue was I was unable to change the job step to quite the job reporting success as each time I did it did not save the change.

Thanks for this report!
@abist tagging you in this in case you're working on any of these or have more info about any of them

These should be fixed in the next release of the extension.


Translate temporary object expressions as constructor invocations

Translate
X create_X()
{
    return X(1, 3.14f);
}

as
X create_X()
{
    return new X(1, 3.14f);
}

Sorry that this was missed, entirely my fault.
The general support seems sensible but the PR has a number of conflicts that would need to be resolved at this point.
I'm going to close the PR as is, but you should feel free to open a new PR that does the same or I will look at doing the same shortly.


Rf bridge on hoobs

Is it possible to setup sensors from rf bridge in hoobs?
...
Rf Bridge
Anything else?
...

Hi, do you mean set them up as a different type to motion, eg a contact sensor? Yes you should definitely be able to

In hoobs there is no settings section for this.. i only see them as motion sensors in home app.

Could you attach a screenshot of the plugin settings screen you can see? Please delete any ewelink credentials first!

11

Also i have 11 devices in rf bridge and i only see 9 of them in homeapp and none of them are working when i trigger..

You'll need to edit the last section, the Sensors box. You can refer to the configuration page in the wiki for more information (near the bottom, the bridgeSensors section).
The example given is:
[
   {
      "deviceId": "10009553c8",
      "type": "water",
      "fullDeviceId": "10009553c8SW1"
   },
   {
      "deviceId": "10009553c8",
      "type": "contact",
      "fullDeviceId": "10009553c8SW2"
   }
]

replacing the deviceId with the ewelink device id of your rf bridge, the type can be water, smoke, co, co2, contact, occupancy or motion. The fullDeviceId is the serial number of the device in HOOBS which is the serial number of the rf bridge with SW# on the end where # is a digit.

Also i have 11 devices in rf bridge and i only see 9 of them in homeapp

When you restart HOOBS and look in the logs you'll see a list of devices that have been added to HOOBS. Do the two missing ones appear there?

none of them are working when i trigger..

If this is still happening then I can look into this further. Let's get the other two things above sorted first 👍

Ok, thank's for the sensor box exemple, it worked now and i can assign the types.
i still have 9 out of 11 rf sensors and none it's working in home app
i looked in log and i have this error:
[eWeLink]  → [RF bridge01] could not be initialised as Cannot read property 'name' of undefined.
maybe it's related to something..
and also i found this:
[eWeLink] [12] eWeLink devices loaded from the Homebridge cache.
25/10/2020, 18:40:28 [eWeLink] [4] primary devices loaded from your eWeLink account.
were the 4 primary are the ip devices i use - basic relays
thank you

If you have 4 basic relays and an RF bridge then it should say [5] primary devices loaded...?
The two devices that aren't showing in HOOBS, which device type are they? Are they RF remote buttons as opposed to sensors?

sorry i have 3 relays and one rf online..
in rf i have only alarms..sensors like

Would you be happy to share your rf bridge with my ewelink account so I can try sort this out much more quickly than constant going back and forth?

Yes, sure thing

Awesome. Which country are you based? (not a random question - need to know for sharing purposes!)

Romania EU

Please share to country code 44 (UK)
Email<EMAIL_ADDRESS>

done

got it thanks. ill get back to you!

The issue is that you have more than 9 devices connected to your rf bridge. a situation i have never encountered so never realised there was an issue here.
Nothing irreparable, I'll get this sorted 👍

Could you activate one of the sensors for me to check something?

Working!

Cool

I'll release an update in a few minutes but the update will take some time to appear in HOOBS. Then you'll be able to update and it should be working for you :) I'd like to suggest keeping the rf bridge shared with me, until you're happy its working. then feel free to unshare!

Perfect! You're awesome!

How many devices are now possible in rf bridge?

No limit from the plugin perspective now, but I'm not sure if there is a limit through ewelink?

Cool!

Once you've updated to v3.8.3, please confirm if it's working or not and I can look to close this issue.
Thanks!

Ok, can't wait :) it's a matter of minutes, hours, days..until
It will be available in hoobs? Or is there a workaround to manually update? Maybe uninstall..and install again?

That's a question you'll have to ask to HOOBS directly as this im unsure about and completely out of my control

Ok, i updated now and it's working almost perfect.. but.. I added another 4 sensors and deleted 'my remote' in ewe app. In home app 'my remote'device is still visible, first new device added is not visible at all and the other 3 are not updating the status.

Have you tried restarting HOOBS?

Yes

Okay, in this situation the solution might be to uninstall and reinstall the plugin. The plugin doesn't deal very well with changes in devices to the RF bridge, something I have never worked on because generally people don't remove and add devices on the go.
But if you uninstall and reinstall remember that your config for the plugin might get wiped so take a copy and paste.

i just did this and it's the same.. actualy when i uninstalled the plugin the devices where still in home app..i rebut twice the hoobs and same thing.. i reinstalled after and they started to work..but with the same thing in rf bridge.

Ok, i solve it..i disable the plugin and enable it from dropdown section.. it worked! But now the triggers are messed up.the ewe app show correctly the trigger but the home app is showing other sensor.. exemple i expose no11 sensor and in home app is trggered no3. When i expose no12 nothing triggers in home app. When i expose no13 in home app no7. When i expose no 14 in home app is no1.. the rest of them are ok aparently..

Please try v3.8.4 once it appears in HOOBS

It's working perfectly! Super! Nice job! Thank you very much for your time!

Super. I'm happy it's working for you 🙂

Don't forget to unshare the device!

Ok..another issue..i put a new sensor in rf bridge and is not triggering..maybe is an issue related to new sensors.
also it will be nice in the future that you can separate the sensor lenght time  input in config related with the sensor type.. for ex a water sensor can stay more time and a door sensor less..

Ok..another issue..i put a new sensor in rf bridge and is not triggering..maybe is an issue related to new sensors.

Best to set up all the sensors you want and then do a plugin reset, ie, set disablePluginto true, then to false again. As I mentioned before, the plugin doesn't deal with changes to the RF bridge very well.
In a future update I'll add an option that if true will just remove and readd the rf bridge, rather than removing and readding all devices.

also it will be nice in the future that you can separate the sensor lenght time input in config related with the sensor type.. for ex a water sensor can stay more time and a door sensor less..

And i'll look into this too

Ok! Thanks a lot

Ideally I'd like to test some changes I've made. Any chance you could share the bridge with me again? And could we message on the Homebridge Discord?


findBySlugOrFail to scope

What would you think about making this method a scope so we can eager-load relationships while using it like this:
Items::with('things')->findBySlugOrFail($slug);
Now I'm not sure if that's the way laravel handles findOrFail but I think it's pretty useful.

Yes please! I just spent a bunch of time reworking this for my non-laravel CMS so that my laravel sites can use it, only to be greeted with an exception screen after all my work.

Eloquent's findOrFail methods are not scopes, though.  If you think about it, scopes are meant to be chainable, but findOrFail needs to be terminal (either you find something, or you fail). So chaining isn't possible.
You can always do Items::with('things')->whereSlug($slug)->get() and then just check the return value.

Then we could make it a nonstatic function just like Laravel and use magic methods to allow it to be called as static.

Well I think I'm just gonna go for the whereSlug so we don't make the code of Eloquent-sluggable a mess, or make it harder to read. :)

I ended up going the whereSlug route. I'm not familiar enough yet with the under the hood setup to know scopes vs. not scopes etc. but I was quite surprised to find that the function mimicking findOrFail doesn't actually work the same way and can't accomplish the same things.

@cviebrock: findOrFail might not be chainable, but it's on the Builder and can hence be called statically or dynamically. I often abuse scopes and make them do this. Yes, it somewhat violates what a scope should do, but it serves the end-user better.


Check unique ids for employee, project and assignment

Assignment unique id doesn't work, I can add assignments with the same id


django code in comment field does not get escaped

I had a ticket where I had to post some django code. The exact comment was:
"commented out the {% if new %} check for the forms, since we don't use this button anyway"
When I try to submit this comment, I get a crash, because 'endif' is not found:
TemplateSyntaxError: Unclosed tags: else, endif

Was this happening in the ticket description, or in a followup?

in a followup.

commenting out line 198 in staff.py (comment = loader.get_template_from_string(comment).render(Context(context))) "fixes" the problem.
Why do we need to "allow the 'ticket' and 'queue' contexts to be applied to the comment", as stated in line 195?

I confirmed this issue still exists in 0.2.0, and can potentially even be a security concern. Will take a look at a better way for template processing.


15642 - Updating Add to channel modal

Summary
15642 - Updating Add to channel modal
Ticket Link
https://github.com/mattermost/mattermost-server/issues/15642
Screenshots

Thanks @asaadmahmood, minor nit, I think we decided on the design pattern that the autocomplete would overlap the input fields slightly? See this ticket for example: https://mattermost.atlassian.net/browse/MM-30898
Looks like this may have also broken for the regular autocomplete as I believe it used to work that way? Would you be open to submitted a fix?

@esethna The design that we have in the Figma file does not have it overlapping the input.
I think the overlapping input was only for the post area input, and I think it would be better if we tackle that in a separate ticket.
Also can you point out what is broken because of this? I don't think we have the overlapping thing implemented yet.

@asaadmahmood it was implemented in the past as part of: https://mattermost.atlassian.net/browse/MM-22956 (but it is no longer overlapping on community or daily it seems)
I think we should be consistent here too, but I'll let @michaelgamble comment on that.

@asaadmahmood it was implemented in the past as part of: https://mattermost.atlassian.net/browse/MM-22956 (but it is no longer overlapping on community or daily it seems)
I think we should be consistent here too, but I'll let @michaelgamble comment on that.

This PR contribution implements the autocomplete positioning update (not merged yet): https://github.com/mattermost/mattermost-webapp/pull/7082#issuecomment-740828480

@matthewbirtch So from what I see, we're not overlapping it vertically right?

To be honest, I kind of forgot about the input overlapping. That PR is more about the horizontal positioning.
I'd love to see it overlap the message input field, but we can do that as a later enhancement

Then do we overlap the suggestion list over the input in this ticket too, or keep it at the edge like the way it is?

Then do we overlap the suggestion list over the input in this ticket too, or keep it at the edge like the way it is?

I don't think we can be consistent everywhere. For example, the search input uses an autocomplete popover, but it won't look right if the popover overlaps the input since it's a smaller input.
So, I say we leave it for now as-is (not overlapping) since it's not overlapping anywhere yet. We can look at whether we actually want to overlap the post draft input later in a separate PR

I agree. I don't think we can have them overlap everywhere.
@esethna So we will keep it as is for now, and the input overlapping can be done as a separate ticket as well as Matt pointed out.

@matthewbirtch @asaadmahmood works for me, can we open a follow-up ticket to look into that. Agree it may not be a global pattern in places like search, but with the larger input fields it could certainly make sense (ie post input, edit post, this modal etc)

@nevyangelova Which ones? Can you comment them again?

@devinbinnie @nevyangelova Can we approve this PR, or talk about how we do the ternary properties for React Select?
This PR has been waiting for that quite a while.

Setup Old Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Test server creation failed. See the logs for more information.

@michaelgamble for a UX review

@asaadmahmood are we adding in the statuses to this PR as per conversation in https://github.com/mattermost/mattermost-webapp/pull/7194
We should match the style of the other autocomplete statuses I would think

@asaadmahmood are we adding in the statuses to this PR as per conversation in https://github.com/mattermost/mattermost-webapp/pull/7194
We should match the style of the other autocomplete statuses I would think

@esethna These are done from my end, I'm waiting for @michaelgamble to review it.
I plan on adding the statuses in another PR, to avoid multiple features in a single PR. It allows us to every back then if there are issues without reverting the whole thing.

@esethna These are done from my end, I'm waiting for @michaelgamble to review it.
I plan on adding the statuses in another PR, to avoid multiple features in a single PR. It allows us to every back then if there are issues without reverting the whole thing.

1, 2, will fix that.
3. @michaelgamble Any thoughts on the text?

1, 2, will fix that.
3. @michaelgamble Any thoughts on the text?

@ogi-m Fixed 1 and 2.
If those are fine, we can approve the PR.
I can update the text for 3 later when I get a confirmation from some of the designers.

@ogi-m Fixed 1 and 2.
If those are fine, we can approve the PR.
I can update the text for 3 later when I get a confirmation from some of the designers.

Retested issues 1 and 2 and they're fixed 👍

Retested issues 1 and 2 and they're fixed 👍

Hi, this PR failed in master with a failing snapshot. Do we just have to update the snapshot or could there be something wrong?

Hi, this PR failed in master with a failing snapshot. Do we just have to update the snapshot or could there be something wrong?

@saturninoabril Thoughts?

@saturninoabril Thoughts?

I think it just need to update the snapshot. It's a merge conflict from the other PR - https://github.com/mattermost/mattermost-webapp/pull/7338 - which added the new snapshot on the said failing component. PR submitted - https://github.com/mattermost/mattermost-webapp/pull/7387

I think it just need to update the snapshot. It's a merge conflict from the other PR - https://github.com/mattermost/mattermost-webapp/pull/7338 - which added the new snapshot on the said failing component. PR submitted - https://github.com/mattermost/mattermost-webapp/pull/7387


Excluding the last child of a folder in SQL Projects also hides the parent folder.

Steps:

Create a new SDK-style project (Framework-style projects work fine because they explicitly list each folder)
Create a new folder Folder1 in the project - the empty folder is visible
Create a new file Script.sql in Folder1
Exclude or Delete Script.sql from the project

Expected:
Folder1 is still visible in the project tree
Reality:
Folder1 is automatically removed/excluded from the project because it's empty, even though this is the same state as at the end of Step 2.
This can result in confusing behavior if the user wants to put something back into that folder.  Attempts to create a new Folder1 fails because the folder already exists on disk.  Folder1 cannot be re-added to the project using "Add Existing Item..." because that only allows selection of files, not folders.

Should get addressed in the current project xml parsing work in DacFx

@Benjin is this fixed now with the DacFx.Projects library?

Yeah, it should be.  It'll keep the (empty) folder around if there's a <Folder Include> entry in the .sqlproj, but it'll disappear if it's the last file.  I'll verify that randomly adding and deleting entries doesn't result in any "error: folder already exists" messages.

Confirmed fixed.


HL7 EDI Connector - Correct prerequisite text regarding the required license

Accidentally pulled in an LDAP topic so I am closing this PR


Adds support for sidekiq 6.2.2

https://github.com/mperham/sidekiq/issues/4955

I'm still seeing :queued for all jobs' status.

Aside from running master in my Gemfile, anything else I should do to get this PR + sidekiq 6.2.2 working?
gem "sidekiq-status", github: "kenaniah/sidekiq-status"


DEMO-CONFLICT2

change step name
make change

Description
Some PR template.
Base Checklist

[ ] Docs have been updated

@mergify queue


Port to GQLAlchemy 1.1

My plan is to actually implement memgraph/gqlalchmey/main.py (in addition to the query files) based on the latest GQLAlchemy capabilities 😄


[usecase-cordova] Add usecase about CrosswalkVersion

Impacted tests(approved): new 1, update 0, delete 0
Unit test platform: Crosswalk Project for Android 15.44.382.0
Unit test result summary: pass 1, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/XWALK-4570
https://crosswalk-project.org/jira/browse/XWALK-4930

Pending this PR since there's an issue https://crosswalk-project.org/jira/browse/XWALK-4466 blocks this test.

@zhuyongyong, a new feature https://crosswalk-project.org/jira/browse/XWALK-4930 is just filed for this test, we may need more tests. Let's sync it offline.

LGTM


Do not ignore KUBECONFIG if no connection

Expected behaviour: if KUBECONFIG was explicitly set, then dapp should fail on kube-connection-error.
#362 #668

Dapp already fail on kube-connection-error.
The problem is: KUBECONFIG was explicitly set, file from KUBECONFIG is not exists. For now dapp will be silent and delete images in cleanup repo without checking in kube.

https://github.com/flant/dapp/pull/717

https://github.com/flant/dapp/releases/tag/0.30.0


Optimized math and advanced examples

On my machine the advanced 3d examples (balls-3d for example) run at 2 fps in Firefox. With these optimizations I got it up to 12 fps, which looks a lot better. They also improve the performance of the native version, but I didn't measure the frame rate.
The most important changes come in the first commit, where I made two changes. First, some profiling of the native balls-3d example (with 500 instead of 50 spheres) revealed that GLFW/glfwGetFramebufferSize is shockingly expensive to call. So I refactored the example code to call it only once per frame instead of twice per object per frame. Secondly, I converted the indices data in the shape entity to an array so that the set-buffers function doesn't repeatedly converted it to an array once per object per frame. That had a significant impact on both native and web performance, bringing the frame rate of balls-3d up to 6 fps in Firefox.
The rest of the changes I made were to multiply-matrices and inverse-matrix. The idea is that since we're only dealing with 2x2, 3x3, and 4x4 matrices, it's a lot faster to have branchless functions specifically for those sizes instead of having functions that work for arbitrary sizes using a lot of loops and conditionals. But instead of hand writing 6 different repetitive functions, I wrote two macros, one to produce matrix multiplication functions, and one to produce matrix inversion functions. You just tell them the matrix size and they produce function code for that size. That way, all the loops and logic get run at compile time so that at runtime all that needs to be done is some floating point math. Based on benchmarking done on the JVM using Criterium, the new multiply-matrices function is more than 10x faster than the old one and the new inverse-matrix function is more than 20x faster than the old one. On the web version, these changes brought the balls-3d frame rate up to 12 fps from 6 fps.
Let me know if any adjustments need to be made. I think there's still room for improvement (for comparison, https://webgl2fundamentals.org/ runs at 20 fps on my machine in Firefox) so I will probably put up a draft PR soon discussing some more ideas.

This is fantastic work. The matrix macro is a great idea. I'm on a work trip right now but i will look over it and merge when i have time.


Appsee integration

Would it be possible to extend the plugin to include the Appsee kit?
https://fabric.io/kits/android/appsee
https://fabric.io/kits/ios/appsee

Yes it is possible. Do you want to create a PR?


Plan for ci/infra/release

I am starting this discussion to consolidate our thoughts/ideas and prepare a plan ahead. I have a couple of questions in my mind that I think should be brought up. Do we eventually migrate all components from this polyglot repo to their respective SIGs main/contrib repos or does this remain as a stand alone project? (I am inclined towards for moving pieces slowly to main/contrib repos). Or is it a mix of both where certain parts remain in this and everything else will be integrated with instrumentations? If we have all or some parts of Sqlcommenter that lives in this repo we will have to take care of bunch of things including CI, Clear contribution guidelines, and release management. Alternatively we can make use already available infra from language SIGs. These are some things on top of my mind. Please share their thoughts and suggestions.

Thanks @lonewolf3739 for starting the discussion thread. All these questions are quite important and needs some good discussion.
This is the initial discussion that happened regarding bringing in SQLCommenter  into OpenTelemetry: https://github.com/open-telemetry/community/issues/783.
I am new to OpenTelemetry. So, maybe will be missing few complexities the OpenTelemetry project might have. Will try to summarise my thought process.
I am more inclined towards having certain parts integrated into OTel and certain parts be in an independent repository.

The instrumentation part seems to be better if integrated into respective SIGs. That would help in seamless integration without adding extra code to initialise SQLCommenter. There can be configurations to control whether the Database queries will be instrumented or not.
Now, regarding the exporter part, maybe we should separate it.

The reason being there might be multiple (in-process/out-of-process) plugins/extensions which can be created to export metrics/tracing information from each of the DB engines. Adding them into OpenTelemetry would really bloat it up.
Also from my limited experience database code have their own set of complexities and may need a different set of testing mechanism, failure handling, handling performance based issues, etc.

I am more inclined towards having certain parts integrated into OTel and certain parts be in an independent repository.

What parts do you think should be reside in this independent repository?
I will take python as an example to share my thoughts and believe same applies to other languages. As you rightly pointed out, instrumentation functionality is better integrated directly with instrumentations provided by opentelemetry. This leaves us with only few parts such as get_flask_info, get_opentelemetry_values, and generate_sql_comment. IMO it is an overkill to maintain them separately. In contrib repos we have separate package where we maintain cross instrumentation helpers, which I think is perfect place to move these definitions.

Now, regarding the exporter part, maybe we should separate it.

I am not quite sure I understand this part. Can you elaborate where do you think exporters come into picture?

@aabmass I agree that sqlcommenter don't need opentelemetry, but as @lonewolf3739 made a valid point that its living inside opentelemetry org and logically opentelemetry should be a first party support. I am inclined towards this point.
So, as a start maybe we should aim to make it compliant with opentelemetry only. That will give more traction to the feature/database instrumentation and provide better observability to users. @aabmass what are your thoughts on this ?


Snap is not defined when use SidePanel component

i run pizza-app-with-vue project under examples and add sidePanel component, then get the console error: Uncaught ReferenceError: Snap is not defined

Thanks for reporting this issue!
This error has been fixed for the latest release v1.5.0.
Hence I'm closing this ticket.


will CanPotentiallyCoerceTo align with PVA?

I am from PVA team and I want to use CanPotentiallyCoerceTo to replace our validation logic. I found that we support the following conversions:

Number to Time: via TimeSpan
String to Time: via TimeSpan
String to Date: via Convert.ToDateTime
String to DateTimeNoTimeZone: via Convert.ToDateTime

I already know the 1st is not supported yet via https://github.com/microsoft/Power-Fx/issues/1653
Will we plan to support them in the future? Thanks!

@nguhoa please help to answer~


which parameters should i used if i want to use rocksdb mode

hi
i am trying to run spfresh with rocksdb mode with "UseKV=true". But i am not clear about the parameters sets i need to use.
would you please advise?

Hello, please refer to the issue #5 for the parameters setting
Note that Our SPDK-based BlockController has a very different performance in terms of read & write (especially in write) compared to RocksDB, the AppendThreadNum should be set much higher than InsertThreadNum to make sure the background split&merge&reassign can catch up with the foreground insertion:)

Thanks for your reply.
Now i can run RocksDB on 1m dataset. but the code failed when i tried 100m datassets.
Would you please advise any debug idea?
Error in Put: While open a file for random read: index/output_100m_u8/kv_data/006834.blob: Too many open files, key: 9297970
[4] Error in Put: While open a file for random read: index/output_100m_u8/kv_data/006834.blob: Too many open files, key: 9297979
[4] Error in Put: While open a file for random read: index/output_100m_u8/kv_data/006834.blob: Too many open files, key: 9297980

Hello, you need to grow the maximum number of open file descriptors of your machine since RocksDB need to open all the blob/sst files, please google "ulimit" command to find out how to change the number:)

Let me try.
Thanks so much.

Thanks. It works.
Please close this issue.


Improve logs for duplicate extension additions

Purpose

Fixes #1480

Codecov Report

Merging #1521 into master will increase coverage by <.01%.
The diff coverage is 57.14%.

@@             Coverage Diff             @@
##             master   #1521      +/-   ##
===========================================
+ Coverage        68%     68%   +<.01%
  Complexity       45      45
===========================================
  Files           648     648
  Lines         27210   27210
  Branches       4277    4277
===========================================
+ Hits          18503   18504       +1
  Misses         6917    6917
+ Partials       1790    1789       -1

Impacted Files
Coverage Δ
Complexity Δ

...re/src/main/java/io/siddhi/core/SiddhiManager.java
63.85% <100%> (+0.89%)
0 <0> (ø)
:arrow_down:

...ava/io/siddhi/core/util/SiddhiExtensionLoader.java
37.33% <25%> (-0.33%)
0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0011f28...40af434. Read the comment docs.


VEX-7619: bring changes used for memory tweaking to the current fork

Add changes from upstream related to
targetFps
libassMemoryLimit
prescaleFactor

+1 Minor


doc update and improve doc of multi catalog

Proposed changes
Update the document of multi catalog feature.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM

run buildall

LGTM


Can't launch / Signing in?

Hey!
I just installed this but there's no info on how to use it.
I tried "wine photoshop" and it gave this:

Could not find Wine Gecko. HTML rendering will be disabled.
Could not find Wine Gecko. HTML rendering will be disabled.
wine: configuration in L"/home/folium/.wine" has been updated.
0009:err:module:__wine_process_init L"C:\windows\system32\photoshop.exe" not found

I'm also wondering if there could be any legal issues with using this. Can I login with my PSCC credentials and be ok or could they detect I'm using it through wine?

There's no desktop entry for me.
And I can't find "~/.WineApps/Adobe-Photoshop/launcher.sh"
I'm not an advanced user so it's possible I'm missing something obvious. But the installation did finish properly as far as I could tell and I did install all the requirements before installation.

Well up to you. but if you want I can check what's wrong if you launch the launcher.sh in a terminal so you can see  the logs.
Maybe you're not the only one with this issue so it could help other people.
If you need alternatives, Gimp is a great one. and you can use photogimp to make it look more like photoshop.


Update olympia folder/module structure and remove sys.path hacks

This is unfortunately a requirement for django 1.7 as well.
Right now we're doing everything we can to avoid an apps module for imports, this now breaks things and imho is unreasonable as well.
(breaking: E   RuntimeError: Conflicting 'translatedmodel' models in application 'testapp': <class 'translations.tests.testapp.models.TranslatedModel'> and <class 'apps.translations.tests.testapp.models.TranslatedModel'>.
Thus I'd like to rename the apps module to olympia and use the new names olympia.abuse, olympia.core, olympia.devhub etc. everywhere.
Imho this makes it clear where a module is coming from and avoids any hacks on the PYTHONPATH.
Opinions about that?

I'd say go for it ;) I personally don't see any good reason to keep this hack around (even though I'm sure there would be ways to make this hack work with django 1.7). Even more, I'd rather get rid of this hack which did bite me a few times already ;)

Do you need to rename apps to olympia or is that a nice to have?

Generally it's nice to have but while I'm at it I'd love to update the general structure to be more django-like again and not as wild as it is right now (imho).

There is a WIP branch: https://github.com/EnTeQuAk/olympia/tree/feature/restructure-modules
And this is basically what I planned:
 - /
 ---- olympia/
 -------------- {access,accounts,amo,addons,...}
 -------------- wsgi.py
 -------------- urls.py
 -------------- migrations/
 -------------- libs/
--------------- conf/ (past 'sites' module)

(https://github.com/EnTeQuAk/olympia/commit/0e0685ccfe4db77ec212dc8959de2a276a545db3)

This will be using https://github.com/mozilla/sugardough/ as an general inspiration.

+1

This got finally merged and will probably be deployed tomorrow.


(PUP 8973) add catalog compilation to pal

This adds the ability to compile a catalog and render it as JSON to the Puppet PAL API.
An example using this:
result = Puppet::Pal.in_tmp_environment('pal_env', modulepath: modulepath, facts: node_facts) do |pal|
  pal.with_catalog_compiler do |c|
    c.evaluate_string("notify {'test': message => /a regexp/}")  # add a resource to the catalog (after main manifest has been evaluated)
    c.with_json_encoding() {|encoder| encoder.encode } # results in pretty json
  end
end

CLA signed by all contributors.

@adreyer I merged this - the added API is very small; almost everything is defined by what have been added for ScriptCompiler. Happy to make changes as needed.


Update root view

What
Updates the view returned by the root url, to remove the Hello World message, and replace it with a link to the ONS home page.
How to test

Checkout the branch
Run the app
Visit home page and verify the "Hello World" message has been replaced.

Who can test
Anybody except @weapdiv-david

I think this page should be our generic error page. No one should access eQ via the root page, that is an invalid action. We have error page on our backlog for this Sprint....

This can be researched as part of the error page stuff in future. This was the story in this Sprint: https://trello.com/c/iLfxqu3u

This has arisen out of a conversation with Steve, but I agree it needs to be researched further.  With regard to using an error page though, the elasticbeanstalk deployment seems to check the status of the root url before signalling whether a deployment was successful or not.  Treating the access of the root url as an erro may cause more problems than it solves.

Yeah maybe return 200 code but same page?

So to clarify, we're going to display the error page but return a 200?

That's what I would suggest; if we agree this is an error condition (hitting eQ directly); my expectation it's the same as going to any URL without a valid token

Error pages are now in place, so we should be able to progress this now.

Displaying an error page with a 200 code (needed for Elastic beanstalk)

Ready for review


It can reason, but it can't understand. Why？

struct.error: unpack_from requires a buffer of at least 5 bytes for unpacking 5 bytes at offset 0 (actual buffer size is 0)

Hi @bxhsort , could you please share additional details about when this error is seen as requested in the issue template. Once we receive these details the team will be able to better investigate this behavior. Without any details I'd guess this is either a disconnect/timeout or data processing issue.


get the state of hamburger menu. If the menu is open or closed currently?

How to get the state of hamburger menu. If the menu is open or closed currently?

There is no public API for monitoring this.
But you could grab the toggle property from the header
import { ClrHeader } from "@clr/angular";

// ...

@ViewChild(ClrHeader) header;

ngAfterViewChecked() {
  console.log(this.header.openNavLevel);  /* 1 is open, null is close */
}


Convert any numeric textureIds to a hexadecimal string while loading a rendermaterial element.

itwinjs-core: https://github.com/iTwin/itwinjs-core/pull/6933

I could move this logic over to a private function like CheckRenderMaterialTextureIds... but not sure if thats the correct thing to do?
One issue I see with this is that LoadElement is considered const which means I would also need to make CheckRenderMaterialTextureIds const, but it feels wrong considering I am explicitly modifying the jsonProps in this case. That also means that maybe LoadElement is the wrong place for me to be doing this.
Open to any suggestions.

Consider fixing it up in _OnLoadedJsonProperties instead. Apparently I made just the same sort of fix for display styles years ago.

Thanks for the suggestion, pushed the changes.

@ColinKerr @rschili or @calebmshafer please review.


chore(package): update nanoid to version 2.1.6

Hey @toxic-johann,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: 4e2607b0-fb88-11e9-94d3-31634e859ee1


32). Add topic files 95 to 98

This PR is for user story #1576037.
It adds four article files, makes corresponding deletions from the C# and VB folders, and adds redirection entries. It also makes minor fixes to a number of topic files.
Please merge #18197, #18259, and #18299 before merging this.
cc: @BillWagner @mairaw @tfosmark @marteeleigh
Contributes to #4728

Can you fix the merge conflicts here @jameshkramer?


ci: fix composer extension build

copilot:all

Current dependencies on/for this PR:

main

PR #3224   👈

This comment was auto-generated by Graphite.


export your environment using --no-build flag

Creating a new environment from the current environment.yml file creating issues in my system.
can you provide the environment.yml with the no-build flag, which will export every package in the YAML, but leave out the build specifiers.
conda env export --no-builds -f environment.yml

What system are you running on?
In our experience with onboarding new students, Mujoco causes most of the issues. Happy to try and help.


feat: Add alert role mapping ONETEAM-1823

See: https://registry.terraform.io/providers/phillbaker/elasticsearch/latest/docs/resources/opendistro_roles_mapping

and: https://opensearch.org/docs/latest/monitoring-plugins/alerting/security/


Downgrade iso and trn to ref when replacing this in a box method.

Fixes #1887

This has been stalled for a while, and I'd like to see it move forward to fix the soundness issue.
@plietar - can you add the requested ast_free, or if you don't have time to do it, let us know that and maybe someone else can take over bringing this to completion?

@plietar due to the recent releases and their related changes to the CHANGELOG file, please merge or rebase onto master and adjust your CHANGELOG entries into the appropriate area of "unreleased" in the CHANGELOG file.

Discussed this in today's sync call. @sylvanc reasoned that this does not cause problems with auto-recovery, and ratified the change.
All this needs is the missing ast_free, then it can be merged.

I took the freedom to rebase this branch onto current master and add the ast_free @Praetonus mentioned and pushed that to your form @plietar

Fixed the CHANGELOG merge conflict. Letting the CI run to see how it does against latest masterchanges, then this is ready to merge.

Thanks @jemc !
Everything is green, merging.


consider try/catch blocks when inlining functions

This issue was imported from Closure Compiler's previous home at http://closure-compiler.googlecode.com
The original discussion is archived at:
http://blickly.github.io/closure-compiler-issues/#1078

@concavelenz I think TurboFan will be fine with those.


Travis CI is not caching sbt launcher

Currently, Travis CI takes an additional 2+ minutes per build because it redownloads the jars for the 0.13.9 sbt launcher. I need to figure out how to cache this to improve build times and stability.

Turns out that I just needed to run the build on master (meaning enabling build on push). This is because a new branch (via pull request) downloads the cache from master for the first time. Whatever cache is published for a branch (pull request) is not used in another branch. So, to get updated caching, I need to run the code in master.


Add version: ShiningLight.OpenSSL.Light version 3.0.11

Pull request has been created with Komac v1.11.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Command: komac --update --id ShiningLight.OpenSSL.Light --version 3.0.11 --urls https://slproweb.com/download/Win64OpenSSL_Light-3_0_11.msi,https://slproweb.com/download/Win32OpenSSL_Light-3_0_11.msi
Note: Komac does not play very nicely with mixed installers, and exe installer sometimes require dependency.


[AutoPR] datamigration/resource-manager

Created to accumulate context: datamigration/resource-manager

(message created by the CI based on PR content)

@AutorestCI rebase

Rebase done and pushed to the branch

Codecov Report

Merging #2521 into master will decrease coverage by 0.49%.
The diff coverage is 45.72%.

@@            Coverage Diff             @@
##           master    #2521      +/-   ##
==========================================
- Coverage   55.24%   54.74%    -0.5%
==========================================
  Files        6837     7563     +726
  Lines      147791   162956   +15165
==========================================
+ Hits        81642    89214    +7572
- Misses      66149    73742    +7593

Impacted Files
Coverage Δ

...t/datamigration/models/data_migration_error_py3.py
62.5% <ø> (ø)
:arrow_up:

...migrate_sql_server_sql_db_task_output_error_py3.py
62.5% <ø> (ø)
:arrow_up:

...els/connect_to_source_sql_server_task_input_py3.py
50% <ø> (ø)
:arrow_up:

.../mgmt/datamigration/models/data_migration_error.py
62.5% <ø> (ø)
:arrow_up:

...e_sql_server_sql_db_task_output_table_level_py3.py
31.25% <ø> (ø)
:arrow_up:

...ion/azure/mgmt/datamigration/models/project_py3.py
100% <ø> (ø)
:arrow_up:

...grate_sql_server_sql_db_task_output_table_level.py
31.25% <ø> (ø)
:arrow_up:

...els/migrate_sql_server_sql_db_task_output_error.py
62.5% <ø> (ø)
:arrow_up:

...ls/connect_to_source_sql_server_task_properties.py
55.55% <ø> (ø)
:arrow_up:

...start_migration_scenario_server_role_result_py3.py
55.55% <ø> (ø)
:arrow_up:

... and 1263 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9860e9...2d74fec. Read the comment docs.


gui_file_dialog: Fix warning

This change fixes a type warning in gui_file_dialog.h...
examples/custom_file_dialog/gui_file_dialog.h: In function ‘GuiFileDialog’:
examples/custom_file_dialog/gui_file_dialog.h:313:198: warning: passing argument 2 of ‘GuiListViewEx’ from incompatible pointer type [-Wincompatible-pointer-types]
  313 | dowBounds.y + 48 + 20, state->windowBounds.width - 16, state->windowBounds.height - 60 - 16 - 68 }, dirFilesIcon, state->dirFiles.count, &state->itemFocused, &state->filesListScrollIndex, state->filesListActive);
      |                                                                                ^~~~~~~~~~~~
      |                                                                                |
      |                                                                                char **

In file included from examples/custom_file_dialog/gui_file_dialog.h:120
examples/custom_file_dialog/../../src/raygui.h:2762:50: note: expected ‘const char **’ but argument is of type ‘char **’
 2762 | int GuiListViewEx(Rectangle bounds, const char **text, int count, int *focus, int *scrollIndex, int active)

@RobLoach thanks for the review! 😄


Go To Definition does not work

Hi,
After right click on the function or F12, I get an error sound and nothing happened. I am using Microsoft Visual Studio Community 2015 version <IP_ADDRESS>.25123.00 Update 2 and R Tools for Visual Studio 0.3.20427.2043.
Thanks in advance,
David

Couple of suggestions:

Please update RTVS - 0.3 is very old. Current is 0.5 with 0.6 incoming. https://aka.ms/rtvs-current
Goto definition working within single file only. It does not take you to other file or to code in packages.

Thanks

Mikhail, thanks for your rapid response...I updated the MVS and RTools and
it works!!! thanks. David
___________________________
*David Leal, MBA,PMP®, *CSM®
<EMAIL_ADDRESS>+1<PHONE_NUMBER>
https://www.linkedin.com/in/davidlealvalmana
On Fri, Jan 6, 2017 at 2:37 PM, Mikhail Arkhipov<EMAIL_ADDRESS>wrote:

Couple of suggestions:

Please update RTVS - 0.3 is very old. Current is 0.5 with 0.6
incoming. https://aka.ms/rtvs-current
Goto definition working within single file only. It does not take
you to other file or to code in packages.

Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/RTVS/issues/2969#issuecomment-270986477,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJPYLdjN1uY1nexyh6DQ_SUiI19sOJMIks5rPpgGgaJpZM4LdBiA
.


User Stories: Friends

[x] As an author, I want to befriend local authors
[x] As an author, I want to befriend remote authors
[x] As an author, I want un-befriend local and remote authors
[x] As an author, When I befriend someone it follows them, only when the other authors befriends me do I count as a real friend.
[x] As an author, I want to know if I have friend requests.
[x] As an author, my server will know about my friends

1

friend - all done


Fix ApplyAnimatedValues is not defined

Fix #504
Using eslint/tslint could help with this kind of bug

I wish we could somehow introduce types at some point.


Add doorsense sensor for August 3rd Gen Smart Lock Pro

Description:
The August 3rd Gen Smart Lock Pro comes with a DoorSense sensor to identify if the door is open or closed.
I added a new binary sensor within the august component to expose the sensor to HASS. A binary sensor will be created for each lock that has the doorsense sensor available as well. During initialization it checks if the status returned is not Unknown and only if it is Unknown it will add the device, otherwise the binary sensor will not be added.
I further also added debug logging in various areas of the coding for both locks and doorbells.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Checklist:

[X ] The code change is tested and works locally.
[X ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[X] New dependencies are only imported inside functions that use them ([example][ex-import]).

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @ehendrix23,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Thank you for all the comments in the review. I went through and believe to have addressed all of them. I also checked and after changes it is still working locally on my HASS. :-)

This PR is borked with commits that have nothing to do with it. Recommend you redo.

This PR is borked with commits that have nothing to do with it. Recommend you redo.

WOW, I can see that. Any idea what I might have done wrong to caused this?
I know I did a rebase of my branch which I thought all came back clean.  Want to ensure that this does not happen again. :-)

There are full instructions here for rebasing: https://developers.home-assistant.io/docs/en/development_catching_up.html Most importantly, after you rebase, you need to force push to your branch on GitHub, and be sure NOT to pull first as git suggests.
You can fix this branch by running git rebase -i upstream/dev for interactive mode, then delete any commits that aren't related to your change. Once you're done force push up to GitHub.

Going back through my command history, looks like I indeed did a pull as git suggested. :-(
I still have the update files. Might it be better/easier instead to close this PR instead, delete the branch and then create a new branch and a new PR?

Yeah, that works


Add documentation for Project Services and Paid Tooling

@openwallet-foundation/tac : Let's review this here and see if we can get approvals on the PR so that we can merge it.


Fix onnx.GatherND and onnx.ScatterND issues with dynamic indices

This PR fixes the following onnx.GatherND and onnx.ScatterND issues with dynamic indices.
With the following two lit tests, latest onnx-mlir causes internal errors while onnx-to-kernel conversion, this PR fixes them.
TODOs
[  ] Enable backend tests
// RUN: onnx-mlir-opt --shape-inference --convert-onnx-to-krnl %s -split-input-file | FileCheck %s

// COM: Test GatherND with dynamic shape
func.func @test_gather_nd_with_dynamic_shape(%arg0 : tensor<2x2xf32>, %arg1 : tensor<?x2xi64>) -> tensor<?xf32> {
  %0 = "onnx.GatherND"(%arg0, %arg1) {batch_dims = 0 : si64} : (tensor<2x2xf32>, tensor<?x2xi64>) -> tensor<?xf32>
  "func.return"(%0) : (tensor<?xf32>) -> ()
}

// COM: Test GatherND with dynamic shape
func.func @test_scatter_nd_with_dynamic_indices(%arg0: tensor<2x1xi64>, %arg1: tensor<?x2xi64>, %arg2: tensor<2xi64>) -> tensor<2x1xi64> {
  %0 = "onnx.ScatterND"(%arg0, %arg1, %arg2) {reduction = "none"} : (tensor<2x1xi64>, tensor<?x2xi64>, tensor<2xi64>) -> tensor<2x1xi64>]
  return %0 : tensor<2x1xi64>
}

Is there also a backend test that we could activate to test this feature through execution of an operation?
Thanks for the comments. I am preparing a bachend test.

Is there also a backend test that we could activate to test this feature through execution of an operation?
Thanks for the comments. I am preparing a bachend test.

I added backend tests for  onnx.GatherND with dynamic indices cases. Thanks.

Jenkins Linux s390x Build #13132 [push] Fix onnx.GatherND and on... started at 00:02

Jenkins Linux ppc64le Build #12125 [push] Fix onnx.GatherND and on... started at 00:09

Jenkins Linux amd64 Build #13108 [push] Fix onnx.GatherND and on... started at 23:02

Jenkins Linux amd64 Build #13108 [push] Fix onnx.GatherND and on... passed after 1 hr 17 min

Jenkins Linux s390x Build #13132 [push] Fix onnx.GatherND and on... passed after 1 hr 27 min

Jenkins Linux ppc64le Build #12125 [push] Fix onnx.GatherND and on... passed after 1 hr 36 min


Closing websocket connection due to internal error.

I deployed the juno node v0.7.1 and v0.7.2 in the docker container.
I saw errors in the log after enabling the web socket.
19:50:54.481 31/10/2023 +03:00  INFO    sync/sync.go:201        Stored Block    {"number": 366168, "hash": "0x49d7...85d7", "root": "0x27ad...51e4"}
19:51:09.883 31/10/2023 +03:00  WARN    jsonrpc/websocket.go:81 Closing websocket connection due to internal error      {"err": "failed to get reader: failed to read frame header: EOF"}
19:51:09.883 31/10/2023 +03:00  ERROR   jsonrpc/websocket.go:91 Failed to close websocket connection    {"err": "failed to close WebSocket: failed to write control frame opClose: WebSocket closed: failed to read frame header: EOF"}
github.com/NethermindEth/juno/jsonrpc.(*Websocket).ServeHTTP
        /app/jsonrpc/websocket.go:91
github.com/NethermindEth/juno/node.makeRPCOverWebsocket.exactPathServer.func1
        /app/node/http.go:71
net/http.HandlerFunc.ServeHTTP
        /usr/lib/go-1.21/src/net/http/server.go:2136
net/http.(*ServeMux).ServeHTTP
        /usr/lib/go-1.21/src/net/http/server.go:2514
github.com/NethermindEth/juno/node.makeRPCOverWebsocket.(*Cors).Handler.func3
        /root/go/pkg/mod/github.com/rs/cors@v1.10.1/cors.go:281
net/http.HandlerFunc.ServeHTTP
        /usr/lib/go-1.21/src/net/http/server.go:2136
net/http.serverHandler.ServeHTTP
        /usr/lib/go-1.21/src/net/http/server.go:2938
net/http.(*conn).serve
        /usr/lib/go-1.21/src/net/http/server.go:2009

My docker-compose.yaml
---
version: '3.9'
services:
  juno:
    image: nethermind/juno:v0.7.2
    command:
      - '--http'
      - '--http-host=<IP_ADDRESS>'
      - '--http-port=6060'
      - '--db-path=/var/lib/juno'
      - '--eth-node=ws://eth-node-ip:8548'
      - '--metrics'
      - '--metrics-host=<IP_ADDRESS>'
      - '--metrics-port=9090'
      - '--ws'
      - '--ws-host=<IP_ADDRESS>'
      - '--ws-port=6061'
    ports:
      - '6060:6060'
      - '9090:9090'
      - '6061:6061'
    volumes:
      - ./data:/var/lib/juno
    restart: unless-stopped

Hey, thanks for reporting.
I don't think this is an "internal error" like the error message states. Juno is just not properly acknowledging that the remote closed the connection and fails when trying to close an already closed connection. Will dig deeper into it to verify my hypothesis.

Juno is just not properly acknowledging that the remote closed the connection and fails when trying to close an already closed connection.

Sounds reasonable. The weird thing is this error:
failed to get reader: failed to read frame header: EOF

The connection should close gracefully, not with a sudden EOF.
Another hypothesis: the TCP connection closed before the client wrote a close frame.

@MichaelLLC If you don't mind sharing the websocket client you used, that could be really helpful.
I haven't been able to reproduce the problem with your docker-compose.yml and wscat.

@MichaelLLC If you don't mind sharing the websocket client you used, that could be really helpful.
I haven't been able to reproduce the problem with wscat.

I deployed the lava rpc provider (https://www.lavanet.xyz/) and enabled websocket parameter.
I also observed the problem with disconnecting the connection with http.

I deployed the lava rpc provider (https://www.lavanet.xyz/) and enabled websocket parameter.

Do you mind describing what you did here? I tried the following with no success:
When I set up a Starknet node through the managed Lava RPC service, it doesn't allow me to enable websocket connections.

Lava's documentation for "Running a Starknet RPC Node" uses Pathfinder and doesn't describe websocket connections.

Try my docker-compose.yaml
---
version: '3.9'
services:
  provider:
    image: svetekllc/lava:v0.26.1-provider
    environment:
      - CHAIN_ID=lava-testnet-2
      - CONFIG_PATH="/root/.lava"
      - GEOLOCATION=2
      - KEY=juno
      - KEYRING=test
      - KEYALGO=eth_secp256k1
      - RPC="https://public-rpc-testnet2.lavanet.xyz:443/rpc/"
      - LOGLEVEL=info
      - MONIKER=Juno
      - REWARDS_STORAGE_DIR="rewards-storage"
      - PROMETHEUS_PORT=23002
      - TOTAL_CONNECTIONS=50
    ports:
      - '23002:23002'
    volumes:
      - ./lava:/root/.lava
      - /etc/localtime:/etc/localtime:ro
      - /etc/timezone:/etc/timezone:ro
    logging:
      driver: "json-file"
      options:
        max-size: "100m"
        max-file: "1"
    deploy:
      resources:
        limits:
          cpus: '2'
          memory: '4gb'
    networks:
      - starknet
    restart: unless-stopped

  juno:
    image: nethermind/juno:v0.7.2
    command:
      - '--http'
      - '--http-host=<IP_ADDRESS>'
      - '--http-port=6060'
      - '--db-path=/var/lib/juno'
      - '--eth-node=ws://x.x.x.x:yyyy'
      - '--metrics'
      - '--metrics-host=<IP_ADDRESS>'
      - '--metrics-port=9090'
      - '--ws'
      - '--ws-host=<IP_ADDRESS>'
      - '--ws-port=6061'
    ports:
      - '9090:9090'
    volumes:
      - ./juno:/var/lib/juno
      - /etc/localtime:/etc/localtime:ro
      - /etc/timezone:/etc/timezone:ro
    logging:
      driver: "json-file"
      options:
        max-size: "100m"
        max-file: "1"
    networks:
      - starknet
    restart: unless-stopped

networks:
  starknet:
    name: starknet

In ./lava/config you need to add:
  #### Starknet mainnet (STRK) ####
  - api-interface: jsonrpc
    chain-id: STRK
    network-address:
      address: <IP_ADDRESS>:22002
      disable-tls: true
    node-urls:
      - url: http://xxx-juno-1:6060

Consumers send requests to providers

To announce your provider, you need to have test tokens and register the chain

You need to run the command: lavap keys show $KEY in the lava container to get the lava address

I sent

The command to register:
lavap tx pairing stake-provider "STRK" \
    "50000000000ulava" \
    "strk.your-site.com:443,2" 2 \
    --from $KEY \
    --provider-moniker $MONIKER \
    --keyring-backend "$KEYRING" \
    --chain-id "$CHAIN_ID" \
    --gas auto \
    --gas-adjustment "1.5" \
    --gas-prices "0.000000001ulava" \
    --node "$RPC" \
    -y

Thanks for the information. I'm not very familiar with Lava, but based on the docs it seems Lava proxies user requests to my local Juno node. Is that correct?
The Lava codebase uses the go-ethereum websocket client. If my understanding is correct, we can probably diagnose the issue faster by using that client to query Juno.

Thanks for the information. I'm not very familiar with Lava, but based on the docs it seems Lava proxies user requests to my local Juno node. Is that correct?
YES

Pasting here for future reference: test case between go-ethereum's websocket RPC client and our RPC server succeeds.
package main

import (
	"context"
	"errors"
	"fmt"
	"net/http"
	"os"
	"os/signal"
	"syscall"

	"github.com/NethermindEth/juno/jsonrpc"
	"github.com/NethermindEth/juno/utils"
	"github.com/ethereum/go-ethereum/rpc"
	"github.com/sourcegraph/conc"
)

func main() {
	quit := make(chan os.Signal, 1)
	signal.Notify(quit, os.Interrupt, syscall.SIGTERM)

	ctx, cancel := context.WithCancel(context.Background())
	go func() {
		<-quit
		cancel()
	}()

	addr := "localhost:6061"
	log := utils.NewNopZapLogger()
	server := jsonrpc.NewServer(1, log)
	server.RegisterMethods(jsonrpc.Method{
		Name:   "echo",
		Params: []jsonrpc.Parameter{{Name: "msg"}},
		Handler: func(msg string) (string, *jsonrpc.Error) {
			return msg, nil
		},
	})

	errCh := make(chan error)
	defer close(errCh)

	mux := http.NewServeMux()
	mux.Handle("/", jsonrpc.NewWebsocket(server, log))
	httpSrv := &http.Server{
		Addr:    addr,
		Handler: mux,
	}
	var wg conc.WaitGroup
	defer wg.Wait()
	wg.Go(func() {
		if err := httpSrv.ListenAndServe(); !errors.Is(err, http.ErrServerClosed) {
			errCh <- err
		}
	})

	// Client requests here //

	client, err := rpc.DialContext(ctx, "ws://"+addr)
	if err != nil {
		panic(err)
	}
	var result string
	if err := client.CallContext(ctx, &result, "echo", "abc123"); err != nil {
		panic(err)
	}
	fmt.Println(result)
	client.Close()

	/////////////////////////////

	fmt.Println("finished!")
	select {
	case <-ctx.Done():
		if err := httpSrv.Shutdown(context.Background()); err != nil {
			panic(err)
		}
	case err := <-errCh:
		if err != nil {
			panic(err)
		}
	}
}

Reproduced this by creating a connection with wscat and then sending kill -9 to wscat. That means this is almost certainly the cause:

the TCP connection closed before the client initiated the close handshake.

It also means that Juno is behaving as expected. I'll modify the log messages to reflect this.
Thanks again for reporting @MichaelLLC! Note that whenever this ERROR appears in the logs, you are safe to ignore it. Juno will continue normal operation unaffected.

@joshklop, thanks a lot. I like your product. I will continue to look forward to the development of the product in the future.