Outline for a demo script CI workflow

We should hold off on this until the website is up and running all the way since the url path name will change slightly.

But the old one should still be working? Adding a CNAME should remove the original A record?

Yes, the old one will still work.  Here are the instructions for the CNAME setup.


12H format

IS there anyway to show the day view in 12H instead of 24H format?

I would also like to know this....

Just merged that few minuts ago.


Update release note

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   75.89%   75.89%
=======================================
  Files          26       26
  Lines         560      560
=======================================
  Hits          425      425
  Misses        135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 018d260...3de6f2e. Read the comment docs.

Thanks for even adding release notes!!


create user login

username: user
password: password
OR
username: student
password: webrtc

login fixed by jimmy


Iphone/IOS not available to test in current build

Tested with: Iphone X and ipad pro
I tried to run https://github.com/iden3/polygonid-flutter-sdk/tree/develop/example with Xcode.. But devices are not available to run the app..

Set minimum deployment target to 14.0. Running using flutter in terminal or android studio. Just cloned the repository from develop branch, followed the readme instructions and successfully run the example app in debug mode on ios simulator and in release mode on real device. Closing issue.


API demo accept connection invitation using the URL

I was wondering to be able to accept the invitation generated by Faber on Alice Swagger using its API (running docker) not using the invitation struct, just using the URL that contains the invitation encoded.
Is it possible?

This is done in the Alice/Faber demo controller code, but I don’t think it is supported in ACA-Py. E.g. the controller accepts the URL, extracts the invitation, and then passes it to ACA-Py. ACA-Py can’t (and probably shouldn’t?) process the URL itself.  On the other hand, that would definitely lock in the format of the URL.


Displaying on Apple devices

During development the component has only been tested on Internet Explorer, Edge, Chrome, and Firefox browser on Windows.
Recently, we found that groups (stories) aren't displayed the same as on PC on Safari browser on Apple devices.
This is probably due to relying on two DIVs displayed on top of each other for groups (stories) and items (tasks):

one that shows read only content, used while dragging too;
one that displays the editors (input and select elements), vertically relative and overlaying on top of the read only DIV (using relative positioning and top negative value).

Resolved in release 1.0.2.


allow setting a timeout on script actions

fixes https://github.com/openshift/origin/issues/14765

@stevekuznetsov ptal and then point me to where these script actions are created so i can go update some of them to pass real timeout values.  (guessing at least some of them are going to need more than an hour).

@stevekuznetsov to make this less risky, i've made the default 6 hours.  we can just go enforce lower timeouts as we find good places to introduce them.

Thanks for the work @bparees -- actions are labeled script: or host_script: and look like this

@stevekuznetsov i found them, added a second commit w/ a few first proposals.

@stevekuznetsov updated.  if there are other low hanging fruit you can think of for me to slap timeouts on, let me know.

@stevekuznetsov test job running here:
https://ci.openshift.redhat.com/jenkins/view/All/job/zzz_test_branch_origin_extended_conformance_install_update/1/
any other comments?

Once the job passes I'll merge and you can push up the changes.

@stevekuznetsov job passed:
https://ci.openshift.redhat.com/jenkins/view/All/job/zzz_test_branch_origin_extended_conformance_install_update/1/


Make the version of Laravel configurable in starter.ini

Problem this feature will solve
Users should be able to set their version of Laravel to any valid sematic version between 5, 6, 7 or 8
Background
Laravel changes pretty radically between major versions so users should be advised to stick with the default version 8.* unless they really need a different version. Some features such as examples and front end scaffolding like react/Vue/Bootstrap with or without auth may not work with older version of Laravel such as version 5. Examples currently only work for Laravel 8.*
Proposed Solution

[x] Add version directive for laravel to starter.ini
[x] Wire starter.ini to scaffold-project.sh in regards to laravel version.
[x] Handle the proper version of laravel/ui based on the version directive for laravel in starter.ini

Constraints and Assumptions
This level of flexibility can potentially create some incompatibilities. Users should be warned to use Laravel versions other than 8.* at their own risk.
Alternatives or Workarounds
Manually configure what you want
Additional context
Add any other context or screenshots about the feature request here.

depends on https://github.com/apolopena/gitpod-laravel-starter/issues/101

Dropping support for specifying Laravel Minor and Patch versions in starter.ini since by design Laravel writes ^Major into composer.json so the latest/stable Minor and Patch version is always used.
Added strict validation for the only supported values for laravel version in starter ini
8.*
7.*
6.*


Switch VCR record mode to :none

This avoids recording cassettes when we run our tests in CI in case the PR author didn't already record them. This also helps us catch instances where the cassette itself might be poorly recorded; a test with the :vcr annotation can have its cassette change in subsequent runs if the test doesn't contain a description
This may reveal that we have other poorly recorded tests in our codebase

I cleaned up a few more unpinned cassettes in https://github.com/dependabot/dependabot-core/pull/4953

Maybe :once is still useful locally to get cassettes automatically generated when writing new specs. Then CI can have a more strict mode.
Periodically regenerating cassettes also sounds good.
Finally, we could also add a CI check that rejects unused cassettes. For example, when you write a spec, generate cassette, then rename the spec, a differently named cassette is generated, and you commit everything, including an empty cassettes. Here's a blog post on that: https://www.jdeen.com/blog/detecting-unused-vcr-cassettes.

Maybe :once is still useful locally to get cassettes automatically generated when writing new specs.

The :once VCR mode can still be set locally with an environment variable!
When running a spec you can do something like VCR=once bundle exec rspec spec/... and it will capture a recording.

Periodically regenerating cassettes also sounds good.

Finally, we could also add a CI check that rejects unused cassettes. For example, when you write a spec, generate cassette, then rename the spec, a differently named cassette is generated, and you commit everything, including an empty cassettes. Here's a blog post on that: https://www.jdeen.com/blog/detecting-unused-vcr-cassettes.

I like these ideas, but I think we should do them as a follow up PR?

Yep, that sounds great!


Handle vera remote controls, and devices without a last_scene_time

Description:
Fixes issues with vera remote control devices so they properly report their button status as sensor

Hi Alan, any progress?

Hi @villanyibalint,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!


Add Oleg Dreyman's blog

Haha don't worry, you had, I just changed where I publish so added another link. Thanks Dave!


chore: remove semantic-release

Description

remove release: semantic-release from script
remove release object from package.json
update package-lock.json file for corresponding changes

Related issue(s) see #174

Update Node-based GitHub Actions

update actions/checkout to v3
update actions/setup-node to v3
update derberg/npm-dependency-manager-for-your-github-org to latest
update peter-evans/create-pull-request to latest

cc: @derberg

Hey does this solve the issue? I am not familiar with workflows so i cant tell. Could you try complete the other steps in the link derberg has provided to completely fix the issue so that we can keep pr's more compact.

@akkshitgupta good job. i will need some time to check the changes cause i dont really know how these things work


Add indexing,search BwC tests for type mapping removal changes

Signed-off-by: Kunal Kotwani<EMAIL_ADDRESS>Description

Add backwards compatibility tests for testing type mapping changes from OS2.0

Issues Resolved

https://github.com/opensearch-project/OpenSearch/issues/2240

Check List

[ ] New functionality includes testing.
[x] All tests pass
[ ] New functionality has been documented.
[ ] New functionality has javadoc added
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Gradle check failure.
> Task :qa:rolling-upgrade:v1.3.1#upgradedClusterTest

REPRODUCE WITH: ./gradlew ':qa:rolling-upgrade:v1.3.1#upgradedClusterTest' --tests "org.opensearch.upgrades.IndexingIT.testTypeRemovalIndexing" -Dtests.seed=A00E1BB3E539D943 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en-PH -Dtests.timezone=Europe/Helsinki -Druntime.java=17

org.opensearch.upgrades.IndexingIT > testTypeRemovalIndexing FAILED
    java.lang.ExceptionInInitializerError
        at __randomizedtesting.SeedInfo.seed([A00E1BB3E539D943:21AD8924DEBE40D]:0)
        at org.opensearch.upgrades.IndexingIT.assertNumHits(IndexingIT.java:307)
        at org.opensearch.upgrades.IndexingIT.testTypeRemovalIndexing(IndexingIT.java:232)

        Caused by:
        java.lang.IllegalArgumentException: Failed to parse value [null] as only [true] or [false] are allowed.
            at org.opensearch.common.Booleans.parseBoolean(Booleans.java:86)
            at org.opensearch.upgrades.AbstractFullClusterRestartTestCase.<clinit>(AbstractFullClusterRestartTestCase.java:45)
            ... 2 more

Failure doesn't belong to code changes. Re-firing

start gradle check

Another unrelated test failure -
REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=DB8B6E2943623CFB -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=mt-MT -Dtests.timezone=SystemV/AST4 -Druntime.java=17

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([DB8B6E2943623CFB:DCFDBBE278E44AA6]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

start gradle check

There is already issue opened for testHAProxyModeConnectionWorks
https://github.com/opensearch-project/OpenSearch/issues/1703

start gradle check

Tests are passing.
Seeing the following failure -
* What went wrong:
Execution failed for task ':distribution:bwc:bugfix:buildBwcLinuxTar'.
> Building 1.3.1 didn't generate expected file /var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/distribution/bwc/bugfix/build/bwc/checkout-1.3/distribution/archives/linux-tar/build/distributions/opensearch-min-1.3.1-SNAPSHOT-linux-x64.tar.gz

Seeing the following failure -
* What went wrong:
Execution failed for task ':distribution:bwc:bugfix:buildBwcLinuxTar'.
> Building 1.3.1 didn't generate expected file /var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/distribution/bwc/bugfix/build/bwc/checkout-1.3/distribution/archives/linux-tar/build/distributions/opensearch-min-1.3.1-SNAPSHOT-linux-x64.tar.gz

There was version bump from 1.3.1 -> 1.3.2 here. Not sure, why it impacts this PR running against main.

start gradle check

I think we need to add 1.3.2 in main branch as well.

start gradle check

Congratulations that you got the 4000th Gradle check runs in CI 😄 🎉

Error in the logs -
REPRODUCE WITH: ./gradlew ':qa:rolling-upgrade:v1.3.2#upgradedClusterTest' --tests "org.opensearch.upgrades.IndexingIT.testTypeRemovalSnapshots" -Dtests.seed=7455B1B271CECBC9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sr-Latn-BA -Dtests.timezone=CET -Druntime.java=17

org.opensearch.upgrades.IndexingIT > testTypeRemovalSnapshots FAILED
    org.opensearch.client.ResponseException: method [POST], host [http://[::1]:41251], URI [_snapshot/test_repository/test_snapshot/_restore?wait_for_completion=true], status line [HTTP/1.1 500 Internal Server Error]
    {"error":{"root_cause":[{"type":"snapshot_restore_exception","reason":"[test_repository:test_snapshot] snapshot does not exist"}],"type":"snapshot_restore_exception","reason":"[test_repository:test_snapshot] snapshot does not exist"},"status":500}
        at __randomizedtesting.SeedInfo.seed([7455B1B271CECBC9:A68E597FC445E45E]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:350)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.restoreSnapshot(OpenSearchRestTestCase.java:1120)
        at app//org.opensearch.upgrades.IndexingIT.testTypeRemovalSnapshots(IndexingIT.java:353)

Retrying on my local

Local run works as expected.
Retrying the check
dev-dsk-kkotwani % ./gradlew :qa:rolling-upgrade:v1.3.2#upgradedClusterTest -Dtests.class=org.opensearch.upgrades.IndexingIT -Dtests.seed=7455B1B271CECBC9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sr-Latn-BA -Dtests.timezone=CET -Druntime.java=17

> Configure project :qa:os
Cannot add task 'destructiveDistroTest.docker' as a task with that name already exists.
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.4.2
  OS Info               : Linux 5.4.181-109.354.amzn2int.x86_64 (amd64)
  Runtime JDK Version   : 17 (Amazon Corretto JDK)
  Runtime java.home     : /home/kkotwani/.sdkman/candidates/java/<IP_ADDRESS>.1-amzn
  Gradle JDK Version    : 11 (Amazon Corretto JDK)
  Gradle java.home      : /local/home/kkotwani/.sdkman/candidates/java/<IP_ADDRESS>.1-amzn
  Random Testing Seed   : 7455B1B271CECBC9
  In FIPS 140 mode      : false
=======================================

> Task :distribution:bwc:bugfix:checkoutBwcBranch
Performing checkout of opensearch-project/1.3...
Checkout hash for :distribution:bwc:bugfix is 83d51ae2f63edbc4e43b927b208bd6cccd85f788

> Task :qa:rolling-upgrade:v1.3.2#oldClusterTest
OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=warn; support was removed in 17.0
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.opensearch.bootstrap.BootstrapForTesting (file:/local/home/kkotwani/workspace/OpenSearch/test/framework/build/distributions/framework-2.0.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.opensearch.bootstrap.BootstrapForTesting
WARNING: System::setSecurityManager will be removed in a future release
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/local/home/kkotwani/.gradle/wrapper/dists/gradle-7.4.2-all/9uukhhbclvbegdvsww0j0cr3p/gradle-7.4.2/lib/plugins/gradle-testing-base-7.4.2.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

> Task :qa:rolling-upgrade:v1.3.2#oneThirdUpgradedTest
OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=warn; support was removed in 17.0
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.opensearch.bootstrap.BootstrapForTesting (file:/local/home/kkotwani/workspace/OpenSearch/test/framework/build/distributions/framework-2.0.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.opensearch.bootstrap.BootstrapForTesting
WARNING: System::setSecurityManager will be removed in a future release
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/local/home/kkotwani/.gradle/wrapper/dists/gradle-7.4.2-all/9uukhhbclvbegdvsww0j0cr3p/gradle-7.4.2/lib/plugins/gradle-testing-base-7.4.2.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

> Task :qa:rolling-upgrade:v1.3.2#twoThirdsUpgradedTest
OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=warn; support was removed in 17.0
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.opensearch.bootstrap.BootstrapForTesting (file:/local/home/kkotwani/workspace/OpenSearch/test/framework/build/distributions/framework-2.0.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.opensearch.bootstrap.BootstrapForTesting
WARNING: System::setSecurityManager will be removed in a future release
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/local/home/kkotwani/.gradle/wrapper/dists/gradle-7.4.2-all/9uukhhbclvbegdvsww0j0cr3p/gradle-7.4.2/lib/plugins/gradle-testing-base-7.4.2.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

> Task :qa:rolling-upgrade:v1.3.2#upgradedClusterTest
OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=warn; support was removed in 17.0
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.opensearch.bootstrap.BootstrapForTesting (file:/local/home/kkotwani/workspace/OpenSearch/test/framework/build/distributions/framework-2.0.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.opensearch.bootstrap.BootstrapForTesting
WARNING: System::setSecurityManager will be removed in a future release
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/local/home/kkotwani/.gradle/wrapper/dists/gradle-7.4.2-all/9uukhhbclvbegdvsww0j0cr3p/gradle-7.4.2/lib/plugins/gradle-testing-base-7.4.2.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

BUILD SUCCESSFUL in 1m 16s
182 actionable tasks: 10 executed, 172 up-to-date

start gradle check

Unrelated test failure:
REPRODUCE WITH: ./gradlew ':plugins:repository-azure:internalClusterTest' --tests "org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotWithLargeSegmentFiles" -Dtests.seed=A319369D69EB94AA -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-DO -Dtests.timezone=America/Fort_Nelson -Druntime.java=17

org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests > testSnapshotWithLargeSegmentFiles FAILED
    java.lang.AssertionError:
    Expected: a value greater than <0>
         but: <0> was equal to <0>
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.repositories.blobstore.OpenSearchBlobStoreRepositoryIntegTestCase.assertSuccessfulRestore(OpenSearchBlobStoreRepositoryIntegTestCase.java:532)
        at org.opensearch.repositories.blobstore.OpenSearchBlobStoreRepositoryIntegTestCase.assertSuccessfulRestore(OpenSearchBlobStoreRepositoryIntegTestCase.java:528)
        at org.opensearch.repositories.blobstore.OpenSearchMockAPIBasedRepositoryIntegTestCase.testSnapshotWithLargeSegmentFiles(OpenSearchMockAPIBasedRepositoryIntegTestCase.java:182)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
        at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
        at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
        at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
        at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
        at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
        at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
        at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
        at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
        at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
        at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
        at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
        at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
        at java.base/java.lang.Thread.run(Thread.java:833

start gradle check

Will re run tests after https://github.com/opensearch-project/OpenSearch/pull/2795 gets merged in.

Closing this in favor of https://github.com/opensearch-project/OpenSearch/pull/2901


Download v1 release of Mage for building

I just cut a release of mage (finally, I know), so there are official v1 binaries that will give you repeatable builds.
https://github.com/magefile/mage/releases/tag/v1

Is there a good reason why you didn't include the checksums in the release? I can download and calculate myself, but it would help with automation (and reduce work) if you just included that file.

I uploaded them after.... they're there

OK; Goreleaser can generate these for you as well, if you did not know.

yeah, it was just easier to do it manually this time, than try to figure out goreleaser (since I already had the script to create the binaries).  I'll do that for next time.

I will update CircleCi (used for the release), but the rest will have to use go get for a while longer.

That goroot problem is now fixed in v1.0.1 - https://github.com/magefile/mage/releases/tag/v1.0.1 and I use goreleaser to put the binary & license in a tar.gz

nevermind, no it's not

For real, fixed this time, checked by two different people in docker and not.
https://github.com/magefile/mage/releases/tag/v1.0.2

I would like to work on this. Would someone assign me?

This is not relevant anymore. We use Go Modules and get the correct version that way.


requestMatcher field not found while retrieving all active expectation created using openAPI

When i retrive active expectations created using OpenAPI the resulting JSON object does not contain "requesterMatcher"
field under "httpRequest"
It only contains "operationId" and  "specUrlOrPayload" fields

but if i look at the active expectaion using dashboard console it contains another field Namely "requestMatcher"....

What you are trying to do
Want to retrive request matcher filed from all active expectation
MockServer version
5.13.2
To Reproduce
Steps to reproduce the issue:

Using mockserver-node
expectation created using OpenApi
While retriving active expectation using node client as well as REST API "requestMatcher" field is missing under "httpRequest"

Expected behaviour
retriving all active expectation must contain "requestMatcher" field under "httpRequest"
MockServer Log
Log output, as INFO level (or lower)

@jamesdbloom @DavidTanner @hennr @micahwood Pls look into this issue

closing as duplicate of #129


merge from arlac77/npm-package-template-esm-only

package.json

chore(scripts): cover@#overwrite c8 -x 'tests/**/*' --temp-directory build/tmp ava && c8 report -r lcov -o build/coverage --temp-directory build/tmp
chore(package): add sideEffects from template

Codecov Report

Merging #625 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #625   +/-   ##
=======================================
  Coverage   90.18%   90.18%
=======================================
  Files          10       10
  Lines         744      744
  Branches       72       72
=======================================
  Hits          671      671
  Misses         73       73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0008ebd...645379d. Read the comment docs.

:tada: This PR is included in version 6.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


qscintilla: cleanup

Motivation for this change

followup to https://github.com/NixOS/nixpkgs/pull/150595
I noticed we forgot to drop pkgs/development/python-modules/qscintilla/default.nix + I did other small refactoring
file pkgs/development/python-modules/qscintilla-qt4/default.nix should be reviewed with whitespace changes hidden

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Looks good to me -- working on nixpkgs-review now.
Sorry for not catching most of this before -- it was my first PR and I'm still getting the hang of the idioms!

I discovered more errors in pkgs/development/python-modules/qscintilla-qt4/default.nix - we need to use qscintilla-qt4, not qscintilla. Also python3Packages.qscintilla-qt4 builts fine with Python3 so I removed that from disabled.


Differences in calculated times between machines.

Astroplan sometimes gives different calculated times for the same calculation on different machines:
>>> sunset_tonight.iso
Expected:
    '2015-06-16 04:59:11.267'
Got:
    '2015-06-16 04:59:10.593'

Could be due to differences in local IERS tables/interpolation used to calculate rise/set times, etc?
See comment here for existing discussion, and here for original source.

This is almost certainly related to the precision limitations discussed on the FAQ page, not a bug.


Can the infercnvpy output observation.txt file like inferCNV(R)?

Description of feature
Hello,
I am attempting to reconstruct a function from R to Python that can differentiate between malignant and benign tumor cells recently, and it seems that the infercnvpy does not generate this output file as the R package.
In R, the function that I'm trying to reconstruct utilies a direct output file named infercnv.observations.txt, which is the tumor cell matrix data values. This file is automatically generated by running infercnv_obj <- infercnv::run(infercnv_obj, ...). In the R version of inferCNV, this generation of the file is determined by the parameter write_expr_matrix=T, which appears in the function plot_cnv that is written in the R script inferCNV_heatmap.R.
It could be seen from the code that this file is generated from the<EMAIL_ADDRESS>, then passed to obs_data in the function plot_cnv:
obs_data <-<EMAIL_ADDRESS>and is finally processed by the function heatmap.cnv that begins from line 1,373, before written into the txt file as follow:
if ("matrix" %in% is(obs_data)) {
    if (write_expr_matrix) {
        flog.info(paste("plot_cnv_observations:Writing observation data to", observation_file_base, sep=" "))
        row.names(obs_data) <- orig_row_names
        write.table(as.matrix(t(obs_data[data_observations$rowInd, data_observations$colInd])), file=observation_file_base)
    }
}

As I am new to the python version of inferCNV, I am wondering does the infercnvpy contains the same data as the observations.txt after the analysis process is compelete?  If it does exist, how could I extract it?
Thanks a lot for answering this question, it would really help me a lot with my study.
Sincerely yours.

Hi @XinheG,
not sure if I correctly understood the question, but the expression values are usually available from
adata.X

or if you store raw value separately in
adata.raw.X

Hi @XinheG,
not sure if I correctly understood the question, but the expression values are usually available from
adata.X

or if you store raw value separately in
adata.raw.X

Thank you so much for answering. I'll go check. That would really help me a lot.


Folder is the document name - NOT the title

The title is the packageId

Downloaded folder will now use the document name.

This is now broken again?
Folder name should be the active document name
Files should be:
imagename.ext
imagename.xml
Currently, an imagename.ome.tif has an xml file named iamgename.ome.xml

Multiple file extensions within the same file name are now taken into account for uploaded files.


Update aptible to 0.11.0

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 08b64b3d325153d5962694a439a7641dd39d01c3. Your contribution is still credited to you.


ADFS 3.0 Service Communications Certificate requirements

You may want to add to the certificate requirements that a legacy key is required for ADFS 3.0. Using CNG which is the default under Windows Server 2012 R2 is not supported.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd1b178e-91f4-9eea-80f5-00f42ee5f6bf
Version Independent ID: e06ee7f7-61af-341e-e5dc-264fc3a9f0b0
Content: Service Communications Certificates
Content Source: WindowsServerDocs/identity/ad-fs/design/Service-Communications-Certificates.md
Product: windows-server-threshold
GitHub Login: @billmath
Microsoft Alias: billmath

#assign:IngridAtMicrosoft


make UDF0 not require NC_NETCDF4

Offered as an alternative to #2585 this PR frees NC_UDF0 of the NC_NETCDF4 requirement and
addresses the issue in #2582.   Note that I did not change the NC_UDF1.

@DennisHeimbigner For some reason I can't tag you as a reviewer, so I'll ask more informally, any thoughts on this? :)

Basically we have two options:

remove the |= NC_NETCDF4 in libdispatch for UDF0 &/or UDF1 in dinfermodel.c
add a new UDF2 that has no NC_NETCDF4 flag set.

I am not sure which option is the best.

What is the status of this PR?  I can modify UDF1 as well if you like?   I've been continuing parallelio development based on this branch - just want some reassurance this will be accepted.

I think the right solution is to remove the NC_NETCDF4 flag from both UDF0 and UDF1 in ddispatch.c.,
and forget about adding UDF2.
Given the PIO situation, I think the possibility of back incompatibility is extremely small.

While adding the UFD1 I discovered a problem in the magic number test.  I chose to handle this by not allowing user defined magic numbers with netcdf3 formats.  parallelio doesn't need any special magic numbers and other users of udf are probably defining new formats and not simply using a new dispatch table with the existing formats as I am.

I see that a lot of the changes are spacing changes,
which is unfortunate since it clutters up the diffs
and makes reading difficult.

Sorry, I'll try to clean that up.

The failing tests here are in dap.   I'm going to assume that my changes are not the cause - can you confirm?

Probably. They look like they are all caused by timeouts,
which probably means the remotetest server is slow.
You might try running the tests again to see if it goes away.

I don't think that I have permission to rerun in your repo - can you trigger them please?

The simplest way is make a minor change in some file, RELEASENOTES.md for example
and then push that change. That will trigger a rebuild.

I'll retrigger, no need to run all 78 jobs.

Thanks @jedwards4b for the PR, thanks @DennisHeimbigner and @dopplershift for the help!


markdown formatting on labels for choices?

From @danbjoseph on April 10, 2018 21:58
@pierregrandidier noted in this ODK forum post that formatting on the labels for choices doesn't appear to work

Copied from original issue: kobotoolbox/enketo-express#983

From @MartijnR on April 10, 2018 23:16
Thanks!
It would be feasible for inline choice labels (i.e. in the XForm body), but not for all labels because Enketo doesn't do the markdown transformation on the client. It does this on the server (and external data is not known at that time, internal data may also present an issue). The negative performance impact of moving that transformation to the client would be significant. Will consider this further.

I do miss this when building forms for Enketo.
What I miss even more is formatting of dynamic content used as a label or hint. For example, it can be helpful to output a summary of data entered by the user. For ODK Collect it's possible to build up a string with formatting using a calculate with concat. I believe that styling is applied before dynamic content is injected for the same reason. Does that sound right or is that a separate issue?

I believe that styling is applied before dynamic content is injected for the same reason. Does that sound right or is that a separate issue?

I think that issue is different but with a similar solution. The original issue requires moving markdown process to the client and including this in the itemset.update. And the solution for your issue above would do the same but for output.update.
The performance problem I referred to above would be mostly with initial loading of forms (and perhaps with updating huge choice lists), unless you can somehow avoid checking every single text string for markdown syntax. A consequence of not having a real concept of pages (compared to Collect).


Ollama support from Intellij

What happened?
Trying to configure Ollama from intellij. Two problems:

UI is looking for API key
Once putting API key it failed in text connection

Relevant log output or stack trace
No response
Steps to reproduce
Install codegpt on Intellij. Try to configure it with CustomOpenAI and Ollama. Put API key and test connection
CodeGPT version
2.6.3-241
Operating System
macOS

First of all Ollama doesn't offer the possibility to define an Api-Key, I think its only possible if you use a proxy (see https://github.com/ollama/ollama/issues/849)
The error messages seems to be coming from OpenAi instead of your Ollama Server, I noticed a bug that the Test Connectionuses the stored settings instead of what is currently selected/entered in the settings UI. I have opened a PR fixing that (#531)
What happens if you click Apply and then hit Test Connection?


⚠ Bofrost.fr has degraded performance

In a7f7b77, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1561 ms

Resolved: Bofrost.fr performance has improved in c3b9efe.


SonarQube extension installation does not use HTTP proxy settings

During the installation process of SonarQube support for Visual Studio Code, it appears that the HTTP(S) proxy settings, located in the user settings settings.json file, are ignored. Due to this issue, installation of the SonarLint CLI hangs.

Hi, @jpeffer!
Could you provide you settings.json (the proxy-part)?
I'll add the support of it.
Workaround:

download this zip and place it in %USERPROFILE%\.vscode\extensions\silverbulleters.sonarqube-inject-1.1.1\tools with sonarlint-cli.zip name
extract this archive to %USERPROFILE%\.vscode\extensions\silverbulleters.sonarqube-inject-1.1.1\tools\sonarlint-cli

You need to get the following structure:
silverbulleters.sonarqube-inject-1.1.1
└───tools
              │   .gitkeep
              │   sonarlint-cli.zip
              │
              └───sonarlint-cli
                         ├───bin
                         │              sonarlint
                         │              sonarlint.bat
                         │
                         ├───lib
                         │              sonarlint-cli-2.1-SNAPSHOT.jar
                         │              sonarlint-client-api-2.4.jar
                         │
                         └───plugins
                                          sonar-java-plugin-4.0.jar
                                          sonar-javascript-plugin-2.14.jar
                                         sonar-php-plugin-2.8.jar

Here are example settings I found from this blog. I was connected through a corporate VPN, so I simply disconnected and completed the installation, but the workaround may be useful for others. Thanks!
{  "http.proxy": "http://my.proxy.address:8080",  "https.proxy": "http://my.proxy.address:8080",  "http.proxyStrictSSL": false }

I'll add it to our roadmap.
P.S. You are the first non-local user of this extension. Does it suit your needs? Do you have any problems with setup (console encoding, glob patterns or whatever)? Any feedback is appreciated!

With my limited use so far, It's working perfectly! Only have used it for Java / JS applications, but no issues to report other than the proxy hiccup. Great stuff. I have contacted SonarSource, suggesting they include a reference to your extension from the SonarLint page.

@jpeffer I spoke with sonarsource some time ago.
https://groups.google.com/forum/m/#!searchin/sonarlint/Vsc/sonarlint/SAelrKay438
The main idea - if we want a sonarsource support, we need to change the way this extension works.
Now it runs through modified version of sonarlint cli and parses the stdout. SonarSource want a new non-comand line daemon and some kind of request-respond method via sockets or smth.
So I decided to release this plugin in cli-mode and refactor it, when the new daemon will be released.
Thanks for the respond!
P. S. You can update the included support for Java and JS, if you run analysis in non-connected mode. Just download new versions of jars from sonarsource and put them in the plugins folder at tools/sonarlint-cli/plugins folder.

@jpeffer may i ask you to try new develop version?
Delete the installed plugin, unpack file, open VSC, open the extension tab, click on small menu in the top-right corner of the extension tab and select install from VSIX. Than reopen the editor.
sonarqube-inject-1.1.1.zip

No luck, still hangs while attempting to install SonarLint. Is there a log I can capture that might help?

@jpeffer hm...
open dev tools, console tab. there must be an error message from plugin.

Here is the error I am receiving. Do you have a URL I could test with wget just to ensure our corporate firewall is not blocking the request? I would not expect it to result in a timeout, but it might be worth at least confirming I can reach the target.

@jpeffer here is URL - https://github.com/nixel2007/sonarlint-cli/releases/download/console-report-1.0/sonarlint-cli.zip
Note: github use some redirects to final destination
/cc @kardanovir

maybe i should try to repack it as node module... if vsc marketplace have no limit on node_modules folder (it does on extension folder itself :( )

Yea pulling from github is no issue. It appears the proxy settings just are not being honored? Happy to try any other suggestions.

Looks like the Java plugin struggled with similar issues:
https://github.com/redhat-developer/vscode-java/commit/6599e69e9636e3898eef23f1b726d950cdf6e846
https://github.com/redhat-developer/vscode-java/issues/42

sonarqube-inject-1.1.1.zip
Check this out. I've added the strictSSL -> rejectUnauthorized setting, as mentioned at vscode-java

sonarqube-inject-1.1.1.zip
one more ninja-edit. change https.proxy -> http.proxy

No luck :/

I am having the same issue.
I took a deep look into the extension and I see you guys put a https_proxy attribute into the parameter options which get passed to http.get(), this won't work...
This solution works:
http://stackoverflow.com/a/6781592/553073
However, almost everyone live with a proxy has to deal with the SSL certificates issue.
See more details here:
http://stackoverflow.com/questions/13913941/how-to-fix-ssl-certificate-error-when-running-npm-on-windows
the build-in http library doesn't support this feature in an elegant way.
I am thinking to create a pull request to switch to the request library (https://github.com/request/request), which solves this issue perfectly.
The only concern I got is that this library is a 3rd library which means more dependency.
Are you guys OK with this?
Thanks for the great pulgin, it is working perfectly with the workaround provided as above.

@atwayne hi! I am very glad to hear someone solved this issue!
Sure, one more dep is not a problem and I appreciate any help :)

:ship: in 1.1.4

Validated that this is now working on our end. Thanks!

:+1:


check_ceph_osd not working after upgrade to ceph version 14.2.20

Hi there,
since the upgrade I get the following error:
check_ceph_osd --id nagios --keyring /etc/icinga/objects/credstore/ceph.client.nagios.keyring -H '10.20.0.XXX' -I '0'
OSD ERROR: 2021-05-05 15:29:38.125135 7f10f0853700  0 monclient: hunting for new mon

Despite the warning about "mons are allowing insecure global_id reclaim" the ceph cluster is healthy. This warning is related to
https://docs.ceph.com/en/latest/security/CVE-2021-20288/
The MON check check_ceph_mon is runnig without any issues for all hosts:
check_ceph_mon --id nagios --keyring /etc/icinga/objects/credstore/ceph.client.nagios.keyring -I 'XXXXXXX'
MON OK

The check version is 1.5.2
Thank you in advance
Greetings
Leo

What is the output of this command?
/usr/bin/ceph --id nagios --keyring /etc/icinga/objects/credstore/ceph.client.nagios.keyring osd dump

Output is:
2021-05-05 18:11:29.053002 7f2a30ed1700  0 monclient: hunting for new mon
epoch 1396
fsid 222a1bde-9373-483f-831e-494610c00659
created 2017-03-15 13:03:00.566591
modified 2021-05-05 13:41:32.525889
flags sortbitwise,recovery_deletes,purged_snapdirs,pglog_hardlimit
crush_version 5
full_ratio 0.95
backfillfull_ratio 0.9
nearfull_ratio 0.85
require_min_compat_client jewel
min_compat_client hammer
require_osd_release nautilus
...
...
...

First line looks wierd.
The Icinga ceph version is Debian 9 stock -> 10.2.11.
"ceph osd dump" on the cluster is not showing the first line.
I guess I just have to update Icinga Ceph to a newer version?

Quick update:
I upgraded ceph on the Icinga server.
ceph -v
ceph version 12.2.11 (26dc3775efc7bb286a1d6d66faee0ba30ea23eee) luminous (stable)

Problem solved.
Thank you for your support und this nice check.
Greetings
Leo


Remove read_analogies() from word2vec class initialization

Fix inconsistent between word2vec and word2vec_optimized.
Remove read_analogies() from word2vec class initialization.

When I used word2vec model for training my target words directly, it lacked of analogies file for evaluation. Thus, it would raise file not found exception when model initialization. So I made read_analogies() public and called it after initialization.

Can one of the admins verify this patch?

Is there any suggestions?

It looks good to me.

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please

Thanks for the pull request!


Typo "cloud explorer"→"Cloud Explorer"

https://docs.microsoft.com/en-us/azure/iot-edge/tutorial-csharp-module-windows

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @hyoshioka0128 - If you refer to Cloud Explorer or Visual Studio Cloud Explorer, you also need to make a revision to delete the article "the". You can use either the cloud explorer or Cloud Explorer without an article. Thanks.

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thank you for making those edits. #sign-off


Transforms run even for Extractors with no Transformations defined

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1681
Originally created by @iroussos on 2020-02-07 19:45:43

Before our update to remove the Load and Transform configuration steps from the UI, we had released an update (@derek-knox) that properly identified when a Tap had Transforms defined for it or not and switched the defaults for the Transform step to run or skip accordingly.
With the removal of the Transform configuration step, we have also removed that part of the code and we always run the Transform step.
That means that Transformations also run for Taps without ones (like tap-csv or, currently, the Google Ads one).
This is really minor cause we try to make available only Extractors with Transformations available, but we have discussions on bringing back the CSV extractor or even enable an Extractor for Postgres.
In those cases, it will be really confusing to show that we run Transforms without really running anything (dbt runs and then complains that there is nothing to do there). It also slows down considerably a very fast Extractor like the CSV one (which does not have to reach out of the server to a 3rd party API)
Also, I think that bringing this back should be pretty trivial cause we were already doing this check successfully, so there should be tested, ready to be used code in our repo's history.

View 3 previous comments from the original issue on GitLab


Revert "optimization client build path (#2172)"

The Paths.get api will use different FileSystemProvider, windows start with \ , Unix like start with /, but URI path must use /.

Codecov Report

Merging #2185 (37293a2) into master (02b2999) will decrease coverage by 0.17%.
The diff coverage is 7.14%.

@@             Coverage Diff              @@
##             master    #2185      +/-   ##
============================================
- Coverage     60.82%   60.64%   -0.18%
+ Complexity     4079     4071       -8
============================================
  Files           607      607
  Lines         18097    18096       -1
  Branches       1734     1734
============================================
- Hits          11008    10975      -33
- Misses         6191     6223      +32
  Partials        898      898

Impacted Files
Coverage Δ

...alibaba/dubbo/AlibabaDubboServiceBeanListener.java
0.00% <0.00%> (ø)

...t/apache/dubbo/ApacheDubboServiceBeanListener.java
0.00% <0.00%> (ø)

...ient/springcloud/init/ContextRegisterListener.java
21.95% <0.00%> (-0.55%)
:arrow_down:

...enyu/client/tars/TarsServiceBeanPostProcessor.java
36.76% <0.00%> (-19.12%)
:arrow_down:

...cloud/init/SpringCloudClientBeanPostProcessor.java
75.40% <50.00%> (+2.39%)
:arrow_up:

...ache/shenyu/client/tars/common/dto/TarsRpcExt.java
0.00% <0.00%> (-30.77%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
64.70% <0.00%> (-29.42%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
58.94% <0.00%> (-4.22%)
:arrow_down:

...henyu/plugin/httpclient/NettyHttpClientPlugin.java
58.00% <0.00%> (-2.00%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02b2999...37293a2. Read the comment docs.


Custom package priority

redo of:
https://github.com/nerdvegas/rez/pull/207
...to set target branch to master.
Original desc:
This branch provides a way to specify a custom solver prioritization order for the versions of specific packages.

Hey Paul,
I'm just about to start work on a rez feature that we have need of at Method. I've realised that it is actually a generalisation of your per-package version priority work. I wanted to describe it to see if you might find it useful also. I'm thinking that it will probably make sense to reimplement this PR in terms of this new feature.
So I wanted to introduce the idea of a "soft timestamp". The idea is that if a soft timestamp is set, rez will prefer to use packages released before this time (as with a usual timestamp), but if necessary, will use packages released after (contrast with a standard timestamp, where newer packages are ignored completely).
The reason we want this is because I'm looking for a good compromise between 'pushing' packages to production (ie, overseeing every package version update before it goes to production) and 'pulling' packages (ie, do resolves at runtime, get whatever latest packages match the request). Both have their downsides - the former requires a lot of maintenance, and there's generally just too much info for a person to take in (they can see that say, 10 packages have newer versions, but it's too much for one person to quantify what they are); the latter isn't stable enough, because newer packages often match a current request, and they get consumed automatically.
Soft timestamps are the compromise. You might, say, set a soft timestamp at the start of each week. That gives stability during the week, but specific requests can be made for newer packages if and when necessary. Certain developers can be chosen to test the latest packages (they would turn the soft timestamp off). A slightly different flavor of soft timestamp - a soft patch timestamp - would let new patches past the timestamp, but not minor or major versions.
In order to implement this, I think we just need to introduce the general idea of a "version priority function". I think you can see that this is only slightly different to what you've done in this PR.
Thx
A

Hmm... yeah, I could totally add the ability to specify a custom function to use in sorting.  Only question would be how to allow specification - via a module and function name, ie python:myModule.myFunc, that would then be imported? Or would we want to allow specification of the function body itself somehow, within the config?
Another idea occurs to me, though, which would probably fit your needs and mine, and re-use a paradigm already introduced: what if we just made it take filter "rules"?
Those would allow us to specify both version ranges (like the current implementation uses), and timestamps (like you want).  We'd also get support for globs + regexes for free, which I can see being potentially helpful.  We could do this in addition to custom functions if you still feel we need the full flexibility that would offer.
Lemme know what you think...

I thought about combining filters and 'orderers', but I think it complicates things. And it doesn't really match how we think about things. For example, we use a glob package filter to turn 'dev' packages on/off - but we do that entirely independently of changing the package version order. If those were combined it would be harder to manage.
I've had to start on this already because we need this feature asap, but I have your current implementation in mind and I think it'll transfer over just fine.
In terms of configuration, I was going to keep it simple, very similar to how the package_filters works currently - just a simple name lookup for each class, and each config entry is a dict used to initialise the orderer instance(s). Like package filters, I'm not sure that people will ever want to extend this, and we can make it fancier later if need be.
I also have it so you can set multiple orderers at once, and the orderer class has the option to define a package's versions order or to pass on to potentially the next orderer. I can't think off the top of my head where multiple orderers would be useful but it's essentially free to add this support. If I didn't have that then we'd have to decide which orderer has precendence, and there's not really any right answer to that.

Oh I meant to say also, there may also be unforseen consequences in the solver. Meaning, it may be possible to apply filters to packages in the solve earlier than reordering, which could have important implications for resolve speeds. There are still changes to the solver I want to investigate (resolve speed / minimising package loads is extremely important to us) and something tells me that keeping these separate may make that easier also.

I don't mean combining filters and prioritization into one entity - they would be separate things / concepts, with separate configurations. I just meant that, for configuration, they would accept the same sort of things - ie, speak the same language.  In other words, the same logic for processing filter configuration - the "filter rules" system - would be used for processing the prioritization configuration.  ie, so we might do:
version_priority:
mypackage:
- glob(*.AwesomeEdition)
- after(1429830188)
- range(8+)
...which looks similar to the configuration for filter rules, because it's using the same processing backend.

Oh ok I misunderstood.
So you mean, by using the same 'language' in the config as filters, you can
apply reordering to only certain packages? Perhaps we'd have something like:
reorderers:

myexample:
class: TimestampPackageOrderFunction
timestamp: 3012854
filter:

glob(foo_*)

So here we would be applying my 'soft' timestamp reordering only to foo_*
packages.
?
A
On Tue, Dec 8, 2015 at 9:29 AM, Paul Molodowitch<EMAIL_ADDRESS>wrote:

I don't mean combining filters and prioritization into one entity - they
would be separate things / concepts, with separate configurations. I just
meant that, for configuration, they would accept the same sort of things -
ie, speak the same language. In other words, the same logic for processing
filter configuration - the "filter rules" system - would be used for
processing the prioritization configuration. ie, so we might do:
version_priority:
mypackage:

glob(*.AwesomeEdition)
after(1429830188)
range(8+)

...which looks similar to the configuration for filter rules, because it's
using the same processing backend.
—
Reply to this email directly or view it on GitHub
https://github.com/nerdvegas/rez/pull/265#issuecomment-162953404.

What I was originally imagining was something more like this:
reorderers:
# items at the top level are explicit package family names
    foo:
        # list memebrs beneath the package are matches against versions
        # within a package family.
        - before(3012854)

This would set the "foo" package to use your soft-timestamp behavior, because anything which doesn't match an explicity priority group is automatically added to a priority group at the end - ie, it would be equivalent to:
reorderers:
    foo:
        - before(3012854)
        - regex(*)

If we wanted to have a "default" reorderer / version_priority for all packages, we could do something like this:
reorderers:
    True:
        - before(3012854)

Of course, this doesn't support matching against a package name - if we wanted to do that, we could go with something like this:
reorderers:
    - family: glob(foo_*)
      priority_groups:
          - before(3012854)

If we wanted to expand to allow arbitrary functions, we could do:
reorderers:
    - family: glob(foo_*)
      priority_func: mymodule.orderByPopularity
    - family: glob(*)
      priority_groups:
          - before(3012854)

I do feel that, even if we allow custom functions, we should have syntax to handle "common" reordering scenariors, such as by version range or timestamp.

So you mean that you just want to be able to utilise filters more
generally, and in this case within a reorderer class. I think that's what
you mean. In the soft timestamp case it doesn't really apply - the behavior
is not as simple as taking all packages before a time and prioritising them
(and using any filter other than 'before' wouldn't make sense). So I think
that's why I was confused.
In any case yes I can see how that would be useful in other cases.  We'd just have to add that as a validator
in config.py. I'll keep this in mind.
In terms of arbitrary priority functions, there's not much point in this,
unless it's a proper plugin. I don't want to introduce package.py
attributes that the standalone rez installation can't consume. At the same
time, I'm not sure people would be interested enough in extending the
default filters to make it a plugin in its own right - but happy to change
later if I'm wrong.
A
On Tue, Dec 8, 2015 at 1:52 PM, Paul Molodowitch<EMAIL_ADDRESS>wrote:

What I was originally imagining was something more like this:
reorderers:
items at the top level are explicit package family names
foo:
    # list memebrs beneath the package are matches against versions
    # within a package family.
    - before(3012854)

This would set the "foo" package to use your soft-timestamp behavior,
because anything which doesn't match an explicity priority group is
automatically added to a priority group at the end - ie, it would be
equivalent to:
reorderers:
foo:
- before(3012854)
- regex(*)
If we wanted to have a "default" reorderer / version_priority for all
packages, we could do something like this:
reorderers:
True:
- before(3012854)
Of course, this doesn't support matching against a package name - if we
wanted to do that, we could go with something like this:
reorderers:
- family: glob(foo_*)
priority_groups:
- before(3012854)
If we wanted to expand to allow arbitrary functions, we could do:
reorderers:
- family: glob(foo_)
priority_func: mymodule.orderByPopularity
- family: glob()
priority_groups:
- before(3012854)
I do feel that, even if we allow custom functions, we should have syntax
to handle "common" reordering scenariors, such as by version range or
timestamp.
—
Reply to this email directly or view it on GitHub
https://github.com/nerdvegas/rez/pull/265#issuecomment-163029810.

So you mean that you just want to be able to utilise filters more
generally, and in this case within a reorderer class.

Exactly!

In the soft timestamp case it doesn't really apply - the behavior
is not as simple as taking all packages before a time and prioritising them

Hmm... the basic scenario seems to fit, but you have a point about your "let patch revisions through, but not minor or major" ability - that would certainly require more complexity.

and using any filter other than 'before' wouldn't make sense

I disagree - our original implementation essentially is using the "range" filter... and I can see uses for the text-matching ones, ie:
`regex((?<!\.beta)$)`

In terms of arbitrary priority functions, there's not much point in this,
unless it's a proper plugin. I don't want to introduce package.py
attributes that the standalone rez installation can't consume.

Ok, good point.  As long as one of the "standard" reorderers allows reordering based on explicit versions, we're covered.
One last request, though - if we are going with different class based reorderers, I suggest that each reorderer be allowed to determine for itself whether it applies to a given package family - ie, there would be a method like:
ReordererClass.applies_to_family(family_name)

that would return a True / False value if it should be used for a given package family.  The reason why is because, if not, our use case - of wanting to explicitly specify "soft maximum" versions per package - becomes much more cumbersome.  It would look something like:
reorderers:
- class: ExplicitVersionOrderFunction
  filter: [maya]
  version_groups: ['<2016']
- class: ExplicitVersionOrderFunction
  filter: [nuke]
  version_groups: ['<9']
- class: ExplicitVersionOrderFunction
  filter: [other_package]
  version_groups: ['<30']

...whereas if each reorderer can have different methods for determining applicability, it could look like:
reorderers:
- class: ExplicitVersionOrderFunction
  version_groups:
     maya: ["<2016"]
     nuke: ["<9"]
     other_package: ["<30"]

...which is both much tidier, and more efficient (ie, we woldn't have to do a series of checks for applicability, but just a single test for dict membership).

Cool, see below.
On Tue, Dec 8, 2015 at 3:33 PM, Paul Molodowitch<EMAIL_ADDRESS>wrote:

So you mean that you just want to be able to utilise filters more
generally, and in this case within a reorderer class.
Exactly!
In the soft timestamp case it doesn't really apply - the behavior
is not as simple as taking all packages before a time and prioritising them
Hmm... the basic scenario seems to fit, but you have a point about your
"let patch revisions through, but not minor or major" ability - that would
certainly require more complexity.
and using any filter other than 'before' wouldn't make sense
I disagree - our original implementation essentially is using the "range"
filter... and I can see uses for the text-matching ones, ie:

I meant that other filters don't make sense specifically for the soft
timestamp reorderer.

regex((?<!\.beta)$)
In terms of arbitrary priority functions, there's not much point in this,
unless it's a proper plugin. I don't want to introduce package.py
attributes that the standalone rez installation can't consume.
Ok, good point. As long as one of the "standard" reorderers allows
reordering based on explicit versions, we're covered.

Yep that was my intention.

One last request, though - if we are going with different class based
reorderers, I suggest that each reorderer be allowed to determine for
itself whether it applies to a given package family - ie, there would be a
method like:
ReordererClass.applies_to_family(family_name)
Ah yeah they can already do that. Each reorderer has a reorder() function
that can either return a reordered package list, or None. If None, the
package list is passed to the next reorderer, if there is one. As an aside

there's no such thing as multiple reorders on a package - I think this
would just be confusing and I can't see the use case.

that would return a True / False value if it should be used for a given
package family. The reason why is because, if not, our use case - of
wanting to explicitly specify "soft maximum" versions per package - becomes
much more cumbersome. It would look something like:
reorderers:

class: ExplicitVersionOrderFunction
filter: [maya]
version_groups: ['<2016']
class: ExplicitVersionOrderFunction
filter: [nuke]
version_groups: ['<9']
class: ExplicitVersionOrderFunction
filter: [other_package]
version_groups: ['<30']

...whereas if each reorderer can have different methods for determining
applicability, it could look like:
reorderers:

class: ExplicitVersionOrderFunction
version_groups:
maya: ["<2016"]
nuke: ["<9"]
other_package: ["<30"]

...which is both much tidier, and more efficient (ie, we woldn't have to
do a series of checks for applicability, but just a single test for dict
membership).
—
Reply to this email directly or view it on GitHub
https://github.com/nerdvegas/rez/pull/265#issuecomment-163056682.

Ah yeah they can already do that. Each reorderer has a reorder() function
that can either return a reordered package list, or None. If None, the
package list is passed to the next reorderer, if there is one. As an aside

there's no such thing as multiple reorders on a package - I think this
would just be confusing and I can't see the use case.

Awesome, makes sense.  And yeah, totally agree on multiple reorders - should stop at the first that applies.

Closing, since we've talked about implementing this in terms of the new package orderer functionality. Superseded by the issue: https://github.com/nerdvegas/rez/issues/329


added the description for StorageClass dropdown in Add Capacity modal

Added the SecondaryTextGenerator field in the StorageClassDropdown which provides the description for the storage class headings.

Signed-off-by: Rishabh Bhandari<EMAIL_ADDRESS>

/test odf-console-e2e-aws

/cherry-pick release-4.11

/cherry-pick release-4.11-compatibility


[Bug]: Crash to Desktop when generating preset as dimension using modded ores on Forge 1.12.2

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Crash to desktop when generating preset as the dimension using modded ores on Forge 1.12.2. Specifically, I get this crash using the Just Stargate Mod version v<IP_ADDRESS>. If this is an issue that has to be fixed with that mod, tell me and I'll open an issue over there.
Expected Behavior
The mod to not crash?
Which platforms have you reproduced this issue using?
Forge Single Player, Forge Multiplayer
OTG Version
OTG 1.12.2 v9.5
Platform Version
No response
Steps To Reproduce

Install the Just Stargate Mod and Open Terrain Generator
Using the OTG O menu, create a new dimension using any OTG preset that doesn't modify ore generation
TP to the dimension
Crash to desktop

Log file
2023-06-30-1.log
Anything else?
The game doesn't crash when re-opening the world after the game crashes. I have tried disabling JSG ore generation but it doesn't seem to change anything at all.

Please note that 1.12.2 is EOL and unlikely to receive support. This issue may be caused by a mod conflict and we recommend attempting to reproduce it with other mods to identify whether it is an OTG issue or an issue with a different mod, as no other reports of issues in this category have been submitted in quite some time.

Additionally, the actual error here appears to be caused by the ore mod, not by OTG. We can't provide targeted support for modpacks on 1.12 at this point and you'll need to isolate the issue to demonstrate it is an OTG problem.

Log for ease of access: https://paste.denizenscript.com/View/111739


Error running 'bash install.sh': option --use-feature: invalid choice: 'in-tree-build'

When running the bash install.sh I'm getting this error:
Usage:
pip install [options]  [package-index-options] ...
pip install [options] -r  [package-index-options] ...
pip install [options] [-e]  ...
pip install [options] [-e]  ...
pip install [options] <archive url/path> ...
option --use-feature: invalid choice: 'in-tree-build' (choose from 'fast-deps', 'truststore', 'no-binary-enable-wheel-cache')
install.sh: line 22:  1225 Segmentation fault      python setup.py build_ext --inplace

It's related to this line within the install.sh file:
pip install . --use-feature=in-tree-build
The error message is indicating that --use-feature=in-tree-build is not a valid option for the pip install command. The valid choices for --use-feature are fast-deps, truststore, and no-binary-enable-wheel-cache.
The in-tree-build feature was used in pip version 21.3 to allow building packages in their own directory, but I'm using a newer version "pip 24.0".
If I directly run that line, I get the same error:

Looks like a bug/issue in the bash install.sh script to be fixed?
Or is there any workaround/fix for this?

I believe the fix should be to replace that line to this:
pip install .
Since in newer versions of pip the "in-tree-build" feature should be integrated by default in your pip version.


Make responsible for mobile phones

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Yes

I will be responsible about this issue.

I was thinking it shouldn't be available on mobile phones since it is an OS based on desktops, so if visited on mobile phones, a pages should show up that it can only be viewed on desktops

@CyberDevv Exactly, I had a idea about posting a joke when opened in mobile, "Even Microsoft couldn't make it far with windows on phone then how could I?"

@CyberDevv Exactly, I had a idea about posting a joke when opened in mobile, "Even Microsoft couldn't make it far with windows on phone then how could I?"

That is great! I would love to see this ;)

@CyberDevv Exactly, I had a idea about posting a joke when opened in mobile, "Even Microsoft couldn't make it far with windows on phone then how could I?"

Yeah, that will make sense also

When will this be added? It still loads on my iPhone in Firefox... I would use the booting screen, and replace the losing spinner, with just non-animated text (in the correct font, obviously), that says the error you want to.

@Lukas-Batema I added this in previous update but for the development I disabled it and forgot to enable in production.
Will do asap

done


Upgrading from 1.17.0 to 1.17.1 fails git fetch

Hi,
We are using versionize tool in our GitLab CI/CD steps like this:
versioning:
  stage: release
  variables:
    # Force a deep/non-shallow fetch
    GIT_STRATEGY: fetch
    GIT_DEPTH: 0
  image: mcr.microsoft.com/dotnet/sdk:6.0-alpine
  script:
    - echo 'export PATH="$PATH:/root/.dotnet/tools"' >> ~/.bash_profile
    - source ~/.bash_profile
    - dotnet tool install --global Versionize --version 1.17.0
    - versionize

and after upgrading to from 1.17.0 to 1.17.1 we receiving an error
Error: LibGit2Sharp.NotFoundException
This is most likely caused by running versionize against a git repository cloned with depth --1.
In case you're using the actions/checkout@v2 in github actions you could specify fetch-depth: '1'.
For more detail see  https://github.com/actions/checkout
Exception detail:
LibGit2Sharp.NotFoundException: object not found - no match for id (ff1a6a984a775d514190534b8ffe0e9f0dbf1641)
   at LibGit2Sharp.Core.Ensure.HandleError(Int32 result) in /_/LibGit2Sharp/Core/Ensure.cs:line 154
   at LibGit2Sharp.Core.Ensure.ZeroResult(Int32 result) in /_/LibGit2Sharp/Core/Ensure.cs:line 172
   at LibGit2Sharp.Core.Proxy.git_revwalk_next(RevWalkerHandle walker) in /_/LibGit2Sharp/Core/Proxy.cs:line 2770
   at LibGit2Sharp.CommitLog.CommitEnumerator.MoveNext() in /_/LibGit2Sharp/CommitLog.cs:line 140
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Versionize.RespositoryExtensions.GetCommitsSinceLastVersion(Repository repository, Tag versionTag) in /home/runner/work/versionize/versionize/Versionize/RepositoryExtensions.cs:line 50
   at Versionize.WorkingCopy.Versionize(VersionizeOptions options) in /home/runner/work/versionize/versionize/Versionize/WorkingCopy.cs:line [46](https://gitlab.dev.clover.tech/iqsoft/coreplatform/-/jobs/364530#L46)
   at Versionize.Program.<>c__DisplayClass0_0.<Main>b__1() in /home/runner/work/versionize/versionize/Versionize/Program.cs:line 72
   at McMaster.Extensions.CommandLineUtils.CommandLineApplication.<>c__DisplayClass143_0.<OnExecute>b__0(CancellationToken _)
   at McMaster.Extensions.CommandLineUtils.CommandLineApplication.ExecuteAsync(String[] args, CancellationToken cancellationToken)
   at McMaster.Extensions.CommandLineUtils.CommandLineApplication.Execute(String[] args)
   at Versionize.Program.Main(String[] args) in /home/runner/work/versionize/versionize/Versionize/Program.cs:line 81

I tried to change GIT_STRATEGY to clone, adding  --unshallow flag, and setting GIT_DEPTH: to 0 / 1 / 10000 (max depth of our repo) and nothing helped.
Could you assist please, is it a bug or something fundamentally changed that we need to reconfigure the CI/CD steps now?

Doesn't seem to be related since you said it works with the previous version, but I'll ask anyways: so, you use GitLab configuration like specified here?
GIT_STRATEGY: fetch
GIT_FETCH_EXTRA_FLAGS: --unshallow
GIT_DEPTH: 0

There's only a one commit (one file) difference between the two versions which is related to working directory. Does anything stand out? I'll see if I can reproduce the issue with GitHub when I get some time.

was this resolved? I am facing the same issue with azure devops pipeline with github actions

This was mentioned in #42
Setting the git fetch depth to 0 has just worked for my pipeline in ado:
stages:
- stage: conventionalcommit
  displayName: conventional commit
  jobs:
  - job: conventionalcommit
    pool:
      vmImage: "ubuntu-latest"
    steps:
      - checkout: self
        fetchDepth: 0
        persistCredentials: "true"

cc @swarooprooney

For me this in worked in GitLab
variables:
    GIT_STRATEGY: fetch
    GIT_DEPTH: 1000

Having this parameter there caused some error about depth and unshallow not being compatible.
GIT_FETCH_EXTRA_FLAGS: --unshallow

GitLab has default git depth of 20 or 50:
https://microfluidics.utoronto.ca/gitlab/help/ci/pipelines/settings.md#limit-the-number-of-changes-fetched-during-clone

Going to close this in response to the shared resolutions. Feel free to create another issue is this becomes a problem again.


upgrade go version to 1.22

Which issue this PR addresses:
Fixes: https://issues.redhat.com/browse/ARO-9866
What this PR does / why we need it:
This PR upgrades go version from 1.21 to 1.22 and pulls the Golang container image mcr.microsoft.com/oss/go/microsoft/golang:1.22.6-fips-cbl-mariner2.0 from Microsoft container registry.
Test plan for issue:

Ensure E2E is success.
Build and Deploy ARO-RP image with new go version in INT.

Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?


Suggestion: Patterns

The addition of patterns would allow for de-duplication of modifier blocks.
An example of their usage is as follows:
@pattern_name = (color=#000000, bold, hover_text=<Basically /clone>)
Here is some [modified text](@pattern_name)

In this case, [modified text](@pattern_name) is equivalent to [modified text](color=#000000, bold, hover_text=<Basically /clone>).
However, merging patterns and other modifiers is valid:
@pattern1 = (bold, italic)
@pattern2 = (underlined, bold=false)

More [text](@pattern1, @pattern2, link="https://example.com")

Patterns should be applied in order that they are listed in, from left to right.
In this case, [text](@pattern1, @pattern2, https://example.com) is equivalent to [text](italic, underlined, link="https://example.com"), as the bold modifier in @pattern1 is overridden by @pattern2.

Done


Add launchctl gui troubleshooting note

As discovered in https://github.com/buildkite/docs/issues/353, when you're using launchctl to start your Agents on macos, you can run into issues if you're not logged in to the launchctl GUI.
This PR adds a troubleshooting note to the 'Starting on Login' section of the macos Agent page, including the text of the resulting error:

@lox does the content of the note make sense? Do we need any further steps other than just being logged in and restarting?
Closes #353

Except without that rogue backtick in the end of the launchctl code bizzo.

Should be "Ensure that you have a user logged in to the macOS host"


Multiple subscription delete

I have about 700 subscriptions that I need to delete. I first tried to delete the parent folder that contained them all, but that somehow only deleted the parent folder, and not the subscriptions. Now there's 700 subs under the "ALL" folder and I can't find a way to delete the subs easily. Am I missing something?

I have the same problem too. I would love to see a way to delete multiple subscriptions too.


spdlog: enable static build through arguments

Description of changes
Like OpenSSL and libgit2, I would like to make spdlog support the staticBuild argument.
Related to https://github.com/NixOS/nixpkgs/pull/181754, https://github.com/NixOS/nixpkgs/pull/178258, and https://github.com/NixOS/nixpkgs/pull/178258/checks?check_run_id=7373649988.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

LGTM


[Suggestion] More Pieces (angles)

Love the mod! Would it be possible to added some inverted roof triangle pieces and 45deg corner stairs (stone and wood) so it is easier to build chamfered corners?

Agree with this, roof angles with 1 point at the top and 2 at the bottom would be very helpful.
I would also like to see 1m roof pieces to help fill in small areas where the default 2m size have to overlap to fill. (or even 1m wide by 2m long if its necessary to keep the pattern repeating properly for the shingles)
If we do get the 1mx2m roofs i would love them to also have the angled flavours to help with less extreme roof overhangs than is necessary with the 45 degree ones.
One piece i think is straight up missing is a piece that matches the roof topper that joins at the center of a tile, instead of on the edges, so the inside of the roof doesn't look janky when it sticks through
Half size angle wood pieces. They are all currently a 2m size, but having some that fit the 1m template would help a lot with creativity IMO. (the angle pieces and the angle pieces combined with walls at least for the 45 degree one)

I like the wooden wall idea, but I will approach that use case a bit differently. Currently working on new quarter and half walls that line up with the top of the regular 2x2 wooden wall upper beam. Then combining the existing quarter wall and the new one will result in the "tall" half wall.

Closing this thread, will post an update in the new issue: https://github.com/OrianaVenture/Valheim-MissingPieces/issues/14


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v3.6 to before v5.4.162",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=ac800140c20e7ae51117e71289065bedd4930fc2",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=52affc201fc22a1ab9a59ef0ed641a9adfcb8d13"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "ac800140c20e7ae51117e71289065bedd4930fc2",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "52affc201fc22a1ab9a59ef0ed641a9adfcb8d13",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "cfg80211: call cfg80211_stop_ap when switch from P2P_GO type\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.4.162 by commit 52affc201fc22a1ab9a59ef0ed641a9adfcb8d13, it was introduced in version v3.6 by commit ac800140c20e7ae51117e71289065bedd4930fc2. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1002256


[kudu1] Keeps being told "Enter passphrase for key '/home/rosbasta/.ssh/id_rsa': " upon "git { fetch, push }"

rosbasta@kudu1:~/link/ROS/indigo_trusty/cws_planning/src/ros-planning/moveit_core$ git fetch origin
Enter passphrase for key '/home/n130s/.ssh/id_rsa':

And kudu1 was just booted before the error message above so https://github.com/130s/compenv_ubuntu/issues/53#issuecomment-228990970 shouldn't be a workaround here.

Seems to be fixed by using ssh-agent and ssh-add (that I thought I'd already done, but may not have done for kudu1).
Needs to be integrated into install script.

Fixed by https://github.com/130s/compenv_ubuntu/pull/65


http: reinstating prior connect timeout behavior

https://github.com/envoyproxy/envoy/pull/10854 inadvertently changed the behavior of connect timeouts.  This reinstates prior behavior.
Risk Level: Low (reinstating prior behavior)
Testing: added regression test
Docs Changes: n/a
Release Notes: inline
Fixes #14394

I think the only question for me is if we should runtime guard - it is reinstating prior behavior but the prior behavior was changed last spring.  I'll leave it up to reviewers - it's easy enough to slap on a guard and copy-paste-runtime-flip the test.

I think the only question for me is if we should runtime guard - it is reinstating prior behavior but the prior behavior was changed last spring.  I'll leave it up to reviewers - it's easy enough to slap on a guard and copy-paste-runtime-flip the test.

Since runtime guarding is so easy I think there's no reason not to? Seems like the safe thing to do since we're changing behavior here

Since runtime guarding is so easy I think there's no reason not to? Seems like the safe thing to do since we're changing behavior here

/backport
Apparently, this breaks retries. cc @howardjohn @lambdai

impact version v1.15 (included)

@PiotrSikora @alyssawilk  I think that makes sense to backport this. But I have a pretty concern to treat envoy.reloadable_features.treat_upstream_connect_timeout_as_connect_failure as enabled by default because It is an unexpected breaking change.

Almost all bug fixes are breaking changes. This fixes a regression that happened a while ago, but I don't think this could break anybody.


tor-browser: 12.5.5 -> 12.5.6

Description of changes
https://blog.torproject.org/new-release-tor-browser-1256/
Security update:

Bug tor-browser#42135: Backport security fixes from Firefox 115.3.1 to 102.15.1
Bug tor-browser-build#40957: Update subkey expiration date for Tor Browser gpg key

Fixes the VP8 encoder bug. #258048.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 258116 run on x86_64-linux 1

1 package built:

tor-browser

@panicgh Btw, I've just noticed that Mullvad Browser 12.5.6 is also already available on torproject.org:
https://dist.torproject.org/mullvadbrowser/
https://archive.torproject.org/tor-package-archive/mullvadbrowser/12.5.6/
I've added those & some other mirrors to the list of urls in #256935.
If they publish Tor Browser & Mullvad Browser releases on those pages simultaneously, we could even update them in a single PR in the future.


No module named modules.my_rules

Hi !
First of all, thank you for Elastalert. It does work wonderfully (at least with default rules and alerts).
I've been trying to write custom rules and alerts, using the documentation. However even while following religiously the documentation, when trying my rules or alerts, I get the No module named modules.my_rules error.
Here is my modules folder :
modules
├── __init__.py
├── my_alerts.py
└── my_rules.py

My rules folder :
rules
└── rule.yaml

Attached are the sample rule I'm using, and the two .py files. Those are pretty basics, my_rules.py is basically taken from the documentation.
my_alerts.py.txt
my_rules.py.txt
rule.yaml.txt
I can import them perfectly fine from the Python REPL while being at /opt/elastalert. But when running elastalert either from /opt/elastalert and running elastalert, with elastalert-test-rule or via supervisor, the import fails.
Would anyone have any idea of what might be causing this ?
Thanks!

Hmm, your code looks fine.  Does the alert module work if you remove my_rules type?

Hi,
As you can see in my tree command, those are .py files.
My rule does not make use of the my_rules.py file. It uses a default rule with the alerter in my_alerts.py.
I do wonder why it is not working, seeing I followed meticulously the tutorial examples.
By the way this is on Ubuntu 14.04 with Python 2.7.6, and what I think of as a pretty recent version of elastalert (September 10th).

To confirm, just running python -m modules.my_alerts works?

Well, there is no particular output. But it does work :
elastalert@wks:/opt/elastalert$ python -m modules.my_alerts
elastalert@wks:/opt/elastalert$

OK so I think I figured it out.
When installing Elastalert, I git clone'd the repo, and python setup.py install.
However when testing and running my modules with Elastalert, I was using
$ elastalert-test-rule
$ which elastalert-test-rule
/usr/local/bin/elastalert-test-rule

Furthermore when invoking components such as config.py and test_rule, we see in the log that Elastalert invokes those of /usr/local/lib/python2.7/dist-packages/elastalert-0.0.96-py2.7.egg/
Running in my folder (/opt/elastalert) python -m elastalert.test_rule or python -m elastalert.elastalert does seem to do the trick.
I thought I had read throughly the documentation, and therefore think there may be some things left unclear.
Now I just have to debug my alerting rule.
Thanks again for the help and for the project !

@Qmando
Thank you Qmando, As per your suggestion i have written any type rule file by using regular expression. Inside rule file we are using customized alert for which we have writen python script when i run the command it is giving error message:
command is /usr/bin/elastalert --config /etc/elastalert/conf.d/config.yaml --verbose
below us the rule file:
num_events: 5
timeframe:
hours: 72
filter:

query:
query_string:
query: "sp-stackTrace: org.apache.hadoop.hbase OR sp-message: org.apache.hadoop.hbase"
max_query_size: 1000
alert:
"new_modules.compass_alerter.CompassAlerter"
alert_subject: "HBase Related Error(s) for CDAP running in Titan {0}"

command that i am ruuning is: /usr/bin/elastalert --config /etc/elastalert/conf.d/config.yaml --verbose
Error details:
Traceback (most recent call last):
File "/usr/bin/elastalert", line 11, in
sys.exit(main())
File "/usr/lib/python2.7/site-packages/elastalert/elastalert.py", line 1897, in main
client = ElastAlerter(args)
File "/usr/lib/python2.7/site-packages/elastalert/elastalert.py", line 130, in init
self.conf = load_rules(self.args)
File "/usr/lib/python2.7/site-packages/elastalert/config.py", line 485, in load_rules
raise EAException('Error loading file %s: %s' % (rule_file, e))
elastalert.util.EAException: Error loading file /etc/elastalert/conf.d/rules/rule.yaml: Error initiating alert ['email', 'compass_alerter.CompassAlerter']: Could not import module compass_alerter.CompassAlerter: No module named compass_alerter
I am not sure where to import the file that shows in error message could you please suggest me on this.

Try going to the directory where new_modules folder is, then running ElastAlert via python -m elastalert.elastalert. I think one common issue is that when you install elastalert and run it via /usr/bin/elastalert, it changes your working directory and it can't import from right place. Adding the current directory to PYTHONPATH may also help.

Thank you so much @Qmando python command works for me.


Ensure lock is per-directory rather than global tmp

/cc @olorin
Dumb question - should it be a hidden file, or in a subdir?

At the moment the lockfile is going to be uploaded along with the data, so either a hidden file or a subdir would be good. The rest of the code is structured around ignoring hidden files/subdirectories, so a dotfile might be the easiest option.
It'd be nice to have a test for the locking as well, ensuring multiple processes can run against different directories.


[FancyZones] [Windows Terminal] can't snap window if it's from other admin account

ℹ Computer information

PowerToys version: 0.20.1
PowerToy Utility: FancyZons
Running PowerToys as Admin: no
Windows build number: 19041.450

📝 Provide detailed reproduction steps (if any)

Run Windows Terminal as Admin (separate account
try to snap it with shift button or non primary mouse button
voila!

✔ Expected result
What is the expected result of the above steps?
able to snap elevated windows terminal using separate account
❌ Actual result
What is the actual result of the above steps?
not able to snap it
📷 Screenshots
Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form

.
.
.
.
Video version

You said PT wasn't running as admin, Try running PT under admin.
TLDR: Non-elevated apps can't move/resize elevated windows.  The different user scenario I'm unsure of but i do know you'll have to elevate PT to get FZ to be able to snap an elevated CMD prompt without a doubt.

You said PT wasn't running as admin, Try running PT under admin.
TLDR: Non-elevated apps can't move/resize elevated windows. The different user scenario I'm unsure of but i do know you'll have to elevate PT to get FZ to be able to snap an elevated CMD prompt without a doubt.

i don't want everytime i sign in the UAC popping up asking password

If PT (by proxy FancyZones) cannot adjust a non-elevated window if itself isn't elevated.  Please see: https://github.com/microsoft/PowerToys/wiki/PowerToys-and-running-as-Administrator#when-does-powertoys-need-this
With PT running as admin and auto starting it, it won't prompt you on startup.  I just restarted with these settings to verify.

If PT (by proxy FancyZones) cannot adjust a non-elevated window if itself isn't elevated. Please see: https://github.com/microsoft/PowerToys/wiki/PowerToys-and-running-as-Administrator#when-does-powertoys-need-this
With PT running as admin and auto starting it, it won't prompt you on startup. I just restarted with these settings to verify.

did you using different account (admin account for this issue) ?

@pc-v2
if your user accounts is not a member of the administrator group, the option to always run PowerToys as administrator won't work.
May I ask you why you need to run Terminal with an administrator account?

@pc-v2
if your user accounts is not a member of the administrator group, the option to always run PowerToys as administrator won't work.
May I ask you why you need to run Terminal with an administrator account?

i want to separate accessing simplednscrypt so i can be lazy enough to not watch some weird stuff

Closing the issue since it's by design that FZ cannot snap an elevated window when running in user mode.


Line Magic Linting

Issue Type: Bug
When using Jupyer linemagic in an .ipynb notebook cell in VSCode there is a visual linting bug:
%load_ext autoreload
%autoreload 2
%matplotlib inline
appears to have a linting error with red lines under each %, with the hover text: "Expected expression Pylance".
This linting red line also shows up under %%timeit for an arbitrary code cell, but ONLY for the first %, not the second nor the whole term "%%timeit".
All of these magic commands appear to work correctly, it is just a weird linting interaction. I am not certain of the details behind linting so this may not be the most appropriate place to report this "bug"; but VSCode previously asked me for interactive Jupyter notebook feedback so I figured this may be relevant.
Extension version: 2021.6.999662501
VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:07.755Z)
OS version: Windows_NT x64 10.0.18363
Restricted Mode: No
Remote OS version: Linux x64 5.4.0-74-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8600K CPU @ 3.60GHz (6 x 3600)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.93GB (7.59GB free)

Process Argv
--crash-reporter-id 6f39a52d-4364-4c01-bf77-267708478eb0

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: Dawn

OS
Linux x64 5.4.0-74-generic

CPUs
AMD Ryzen Threadripper 2920X 12-Core Processor (24 x 1712)

Memory (System)
62.67GB (31.51GB free)

VM
0%

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspyt653:30270858
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255:30323308
vscorehov:30309549
vscod805cf:30301675
pythonvspyt200cf:30329804
binariesv615:30325510
vsccppwtct:30329789

This should be handled if we fix this bug here:
https://github.com/microsoft/vscode-jupyter/issues/1497

Additionally pylance has an issue to handle this as well:
https://github.com/microsoft/pylance-release/issues/894