Fatal error: Could not load sails

Every command i run results in an error:
grunt db:migrate:create --name add-some-fooz --force
Error:
Warning: Task "add-some-fooz" not found. Used --force, continuing.

Running "db:migrate:create" (db:migrate) task
Fatal error: Could not load sails

I'm afraid I won't be able to help much. I don't use either Sails or Grunt any more, so I won't be able to look into this issue.
I'll gladly accept a PR if anyone can provide a fix for it, though.

I had this problem when migrating to sails v1. It seems that sails-db-migrate uses session.
After I added config/session.js with secret: 'my-secret', this error was gone.

even doing the commented above, the issue still remains


After task is selected in DM-Grafana, non-target source or instance will be displayed

Is your feature request related to a problem?

After task is selected in DM-Grafana, non-target source or instance will be displayed. For example, there are two tasks in the DM cluster:
1. task name is dm-test-task01, and the sources are shop-shard00, shop-shard01, shop-shard02, shop-shard03

2. task name is dm-test-task02, and the sources are order-shard00, order-shard01, order-shard02, order-shard03

After dm-test-task01 is selected in DM-Grafana, you will see order-shard00~order-shard03, shop-shard00~shop-shard03 in the source list
In fact, it should only display shop-shard00~shop-shard03.
Describe the feature you'd like
After task is selected in DM-Grafana, only the corresponding target source or instance is displayed, and non-target source and instance are not displayed
Describe alternatives you've considered
No response
Teachability, Documentation, Adoption, Migration Strategy
No response

@zhenjiaogao Can you give me the version of the DM you are using?

ping @Ehco1996 @zhenjiaogao


You should be able to cd! into a Symbol or String

And it should turn into a useful, relative/absolute path depending on the format of the string. Symbols should always be relative.
All the load.module, load.exec, etc. functions should behave similarly

Fixed in master


batch: ask for confirmation before delete all

Its right next to "run all"

Added, close pending test

fix is merged


return no content status (204) for succesful write

since write returns nothing in the body of the response, return 204
related to #2266

i got caught... for some reason i can't get the tests running locally :smile: (looking at it now)

I suspect we'll end up soon outputting some data in response to a write, so this might be premature.

this might be premature.

no problem.  if determining what to provide in the response is something you think you will get around to doing later but don't have time for now, then maybe having an open issue will help make sure it doesn't get overlooked.  i had opened #2266 to try and determine what you might like to respond with because if you can give some direction, i might be able to implement it.  however, when #2266 was closed, i was left the impression that an empty response is what it will be for now so i made this PR to do the right thing for an empty response.
maybe this PR could be merged in case you don't get around to deciding what to respond with before you release 0.9.0?  maybe you don't agree with these changes for an empty response?  i don't mind closing this PR but i'd like to help on providing some kind of better response than what is currently provided.

@neonstalwart would you mind rebasing this?

@toddboom rebased.

@neonstalwart awesome - thanks!

This seems to now to be broken according to RFC7320

A server MUST NOT send a Transfer-Encoding header field in any response with a status code of 1xx (Informational) or 204 (No Content).

The server still seems to be sending back the header transfer-encoding: chunked which it should not. This can cause problems with many HTTP libraries as well as several servers. Visit this stackoverflow question for more info.

Could someone update docs here?
https://influxdb.com/docs/v0.9/concepts/reading_and_writing_data.html
At the moment it says successful write would return HTTP 200 OK

@romikk Thanks for the note, I opened an issue on the website repo: https://github.com/influxdb/influxdb.com/issues/62

No longer sending a transfer-encoding value:
$  curl -iv -XPOST 'http://localhost:8086/write?db=mydb' --data-binary 'foo value=12';
*   Trying ::1...
* Connected to localhost (::1) port 8086 (#0)
> POST /write?db=mydb HTTP/1.1
> Host: localhost:8086
> User-Agent: curl/7.43.0
> Accept: */*
> Content-Length: 12
> Content-Type: application/x-www-form-urlencoded
>
* upload completely sent off: 12 out of 12 bytes
< HTTP/1.1 204 No Content
HTTP/1.1 204 No Content
< Request-Id: 6162708c-5d8f-11e5-8771-000000000000
Request-Id: 6162708c-5d8f-11e5-8771-000000000000
< X-Influxdb-Version: <IP_ADDRESS>
X-Influxdb-Version: <IP_ADDRESS>
< Date: Thu, 17 Sep 2015 22:56:50 GMT
Date: Thu, 17 Sep 2015 22:56:50 GMT

<
* Connection #0 to host localhost left intact


Swift motd step fails deploying from source

Because of the changes in PR 1428, swift will fail when appending to the motd file. Workaround is to change destination from /etc/motd.tail to /etc/ursula-release

Good catch. Are you preparing a PR for this?

yep, should be up once @CullenTaylor confirms.

@epwn :thumbsup: good to make the PR.

This was fixed.

Refer to fix: https://github.com/blueboxgroup/ursula/pull/1440 for future reference


chore: Import export application refactor

Description
First draft for Import export flow refactor
Steps for refactoring the application import flow to context agnostic flow
/**
* Step 1: Schema Migration
* Step 2: Validation of context Json
* Step 3: create placeholder objects for internal stuffs
* Step 4: set schema version and other stuffs common misc
* Step 5: get workspace and user with right set of permission
* Step 6: get application specific import entities
* Step 7: get allImportEntities like plugins, datasource, action and other stuffs
* Step 8: get update page and new action with already created references.
*/
fixes: https://github.com/appsmithorg/appsmith/issues/29748, #29819 , #29820, #29821, #29822

Summary by CodeRabbit

New Features

Introduced comprehensive application import functionality, enabling users to import applications and their components seamlessly.
Added support for various JSON artifact types, enhancing the flexibility of import operations.
Implemented new interfaces and services for managing artifact permissions and import processes.

Enhancements

Expanded the import service capabilities to include plugins, themes, pages, custom JavaScript libraries, datasources, actions, and action collections.
Improved import logic to handle artifact version syncing and JSON schema migrations.

Refactor

Updated internal naming conventions to align with the broader scope of importable artifacts.
Streamlined artifact import and permission handling by introducing new interfaces and classes.

Bug Fixes

Addressed issues with artifact importing, ensuring consistent and reliable import experiences for users.

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test<EMAIL_ADDRESS>

/ok-to-test<EMAIL_ADDRESS>@tag.Datasource @tag.Fork, @tag.ImportExport @tag.Templates"


When the app is started with wait-for-debugger request, it will wait unt...

...il the debugger is connected and brake in the bootstrapper

I had made some comments on memory managing blocks, but I hadn't realized at the time that the TNSDebugging target is built with ARC enabled. Since those comments are inapplicable in this case I have removed them.


Fix possible race condition in condition_variable

This PR fixes a race condition between condition_variable::notify_one and wait_impl.
To trigger the race condition the following events need to occur:

Suppose we have a condition_variable cv and at least 2 threads.
Thread A enters wait_impl and stops at WaitForSingleObject with a finite timeout, mNumWaiters==1 at this point
Thread B enters notify_one, checks !mNumWaiters and the scheduler stops it before executing mNumWaiters.load()
WaitForSingleObject times out at Thread A and wait_impl returns. mNumWaiters==0
Thread B continues and sets targetWaiters to -1, causing an infinite loop while waiting for mNumWaiters to become -1

The fix is simple, only read mNumWaiters once during setup, so timeouts won't cause problems.

Good find, tyank you!

It's been a while since I wrote this code, but looking at it now, I think the race condition should not actually happen - simply because both notify_xxx methods hold mMutex and wait till the target number of waiters is reached. This implies that no semaphore wait other than the required one should ever complete while mMutex is locked. Still it's a good fix to make the code robust. Or did you actually observe the race condition in practice?

This race condition can be reproduced if we force a particular scheduling
by using a 1 millisecond timeout in wait_for and inserting a bit longer
Sleep (30 milliseconds for example). Timing has to be just right, but I can
reproduce it pretty steadily with the added Sleep. The mMutex lock doesn't
help with this issue, since it only protects the conditional_variable from
adding a new waiter while a notify_xxx is in progress. It doesn't help with
a single wait_impl timing out and decrementing mNumWaiters just before
mNumWaiters.load() is called in notify_one.
I actually haven't observed this race condition in practice without adding
Sleeps, I've noticed it while hunting for a bug found in stress testing,.
That bug turned out to be a too long timeout in my test (off by a few
hundred years), but with a review of all possible parallel code paths
through notify_one and wait_impl we uncovered this race condition.
On Fri, Nov 10, 2017 at 1:30 PM, Alexander Vassilev <
<EMAIL_ADDRESS>wrote:

It's been a while since I wrote this code, but looking at it now, I think
the race condition should not actually happen - simply because both
notify_xxx methods hold mMutex and wait till the target number of waiters
is reached. This implies that no semaphore wait other than the required one
should ever complete while mMutex is locked. Still it's a good fix to make
the code robust. Or did you actually observe the race condition in practice?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/meganz/mingw-std-threads/pull/20#issuecomment-343461524,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUT-X6b7RDUn62LohZm6xU9SKaE4qeswks5s1EHtgaJpZM4QNr1y
.


Compute Node only works with gridgaincompute.jar < <IP_ADDRESS>

Computes that include HEC-ResSim fails to successfully return results when using a gridgaincompute.jar >= <IP_ADDRESS> on the compute node.

Closed by
https://github.com/HydrologicEngineeringCenter/WAT_Configs/pull/19


Python Extension can't find pip

VSCode Version: 1.57.1 507ce72a4466fbb27b715c3722558bb15afa9f48 x64
Local OS Version: Pop!_Os 21.04
Name of Dev Container Definition with Issue: python-3

Steps to Reproduce:

Have pytest enabled in config:"python.testing.pytestEnabled": true,

Open Devcontainer
Prompt appears, press yes:

Following error appears:

This does not occur when running outside of the devcontainer.

@jyooru pytest is not in the images, so this is expected. See https://github.com/microsoft/vscode-dev-containers/pull/353
The python extension needs it to be installed as a part of the project rather than as a global pipx-based utility.

@Chuxel the issue is not related to the fact that pytest is not preinstalled - this is just how I have come across this issue.

Following error appears:

The issue is that the Python Extension can not find pip.


nodePackages.vercel: it's not using the system Go for Go cloud functions on vercel dev

Describe the bug
I am doing a project and running it locally using vercel dev.
This project uses a Golang cloud function on the API folder
Instead of using the system Go or reference it as a dependency it's using the provided go from @vercel/go so it triggers that problem when you run a binary that expects a FHS system but it's NixOS
Steps To Reproduce
Steps to reproduce the behavior:

Create a simple project with an HTML file or something like this
Add at least one cloud function (using the api folder using go
vercel dev

Expected behavior
vercel uses the system available Go, or the one declared as dependency
Screenshots
[nix-shell:~/WORKSPACE/irrigationProject]$ vercel dev                                                                             [28/919]
Vercel CLI 24.0.0
> Running Dev Command “react-scripts start”
ℹ ｢wds｣: Project is running at http://<IP_ADDRESS>/
ℹ ｢wds｣: webpack output is served from
ℹ ｢wds｣: Content not from webpack is served from /home/lucasew/WORKSPACE/irrigationProject/public
ℹ ｢wds｣: 404s will fallback to /
Starting the development server...

> Ready! Available at http://localhost:3000
Error! Command failed: go build -ldflags -s -w -o /nix/store/wqmssw3p3khlf4sp4g14m73kfmqpjdpk-vercel-24.0.0/lib/node_modules/vercel/node_m
odules/@vercel/go/dist/analyze /nix/store/wqmssw3p3khlf4sp4g14m73kfmqpjdpk-vercel-24.0.0/lib/node_modules/vercel/node_modules/@vercel/go/d
ist/analyze.go

Additional context

Vercel 24.0.0
NixOS
nixpkgs: github:NixOS/nixpkgs/73ad5f9e147c0d2a2061f1d4bd91e05078dc0b58 nixos-unstable

Notify maintainers

@kidonng
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.16.14, NixOS, 22.05 (Quokka)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.7.0`
 - nixpkgs: `/nix/store/f71alr07xb2swc37fiqjr5h416qcs6wr-source`

LOL

Please also convert the package to using buildNpmPackage when fixing this issue.

I think I found out the issue.
vercel dev looks for the go version in go.mod to know which go version to get. So the ideal here is to wrap vercel in a FHS environment so it works. Sometimes it's intentional using an older version.

They are doing it wrong. The go keyword denotes the language version to use, not the compiler. They should just use the go version from PATH.


How to start using it?

Can you please provide a simple tutorial on how to start using it.
After installation, I found only an option "Scheme REPL" in right click menus with all suboptions grey.
Thank you for your help.

Hey, the highlighting feature may work. But many features may not work, or not work properly.


docs(@toss/utils): fix code example of formatToKRW

Overview
shouldHaveSpaceBeforeWon is not provided as options. so it will returned ${formattedVal}원.
Also ceilUnit are not working. pr on fix(@toss/utils): ceilUnit parameter was missing #371
PR Checklist

[✅] I read and included theses actions below

I have read the Contributing Guide
I have written documents and tests, if needed.

English

한국어


bug: metamask does not connect when both metamask and metamask institutional are installed

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
0.6.0
Current Behavior
No response
Expected Behavior
No response
Steps To Reproduce
No response
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

Thanks for reporting. This issue is temporarily closed due to lack of information. Please provide a minimal reproducible example via a CodeSandbox (feel free to use this template) and reopen this issue.


Issue with /docs/getting-started-guides/aws/

Please can team create document step by step installation independent of Linux distribution.
Is very confusing how the installation process takes place and what and how is installed.
This is a...

[X] Feature Request
[ ] Bug Report

Problem:
Missing Steps documentation in installation process
Proposed Solution:
Document step by step kubernetes installation
Page to Update:
http://kubernetes.io/...

I have a PR in that will change this a ton.

https://github.com/kubernetes/kubernetes.github.io/pull/1562

#1562 has been merged.


DrawNode::drawPoly()  and  DrawNode::drawPolygon()  drawing different results with the same Vec2 list

        auto draw4Clipper = DrawNode::create();
        draw4Clipper->setPosition(50, 100);
        addChild(draw4Clipper);

        auto drawIntersect = DrawNode::create();
        drawIntersect->setPosition(550, 100);
        addChild(drawIntersect);

        float scaleFactor = 5.0;

        Vec2 vertices2[] = {{98, 63}, {4, 68}, {77, 8}, {52, 100}, {19, 12}};
        for (size_t i = 0; i < sizeof(vertices2) / sizeof(vertices2[0]); ++i)
        {
            vertices2[i] *= scaleFactor;
        }
        draw4Clipper->drawPoly(vertices2, sizeof(vertices2) / sizeof(vertices2[0]), true, Color4F::ORANGE);

        drawIntersect->drawPolygon(vertices2, sizeof(vertices2) / sizeof(vertices2[0]), Color4B(254, 201, 181, 200), 1,
                                   Color4B(248, 237, 237, `200));`

Sorry. Its my mistake (using the Clipper2 examples wrong with axys)
closed it.


Ignores changes in built css files (keeps the ones in source)

Description

Did not make an issue

Right now, every build changes the built css files and those changes aren't ignored. That means they show up in status and get added unintentionally all the time. This should fix that.
List of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] This pull request relates to a ticket.
[x] This code is tested.
[x] I want my code added to the response theme.

We can't delete those files. This is a Jekyll theme and the response sites read directly from those CSS files.

So I check their changes in every time?

I just figured it would build them when it ran on the server.

The answer is yes, do commit all built changes caused by source code changes. Don't commit changes made by watch when switching branches.


Add WP8.x support

Add support for WP8.x plz..

+1

+1

Hello. I've modified ratchet to added WP8 touch handlers. I'd also have to add IE9/10 polyfill for CustomEvent(), otherwise push wouldn't work. I'd have to clean out some other customizations I've made, but i can submit it for review if people are still interested. I'd consider it "alpha" at best, as I have not tested this on all phones/environments. Just on a crappy 8.1 phone I have. But the code changes are pretty straightforward.

Ratchet is died..  Dev migrated to ionic/framework7/etc

Fair enough. Figured I'd post since this was one of the bigger things people were concerned about.


Remote database settings cannot be edited anymore

All 4 fields in the Remote database settings cannot be edited anymore. Single click into the textfield -> no edit cursor, value can't be changed.

Since 0.1.16, these settings are locked while any synchronization is enabled to avoid corrupting the database.
All synchronization is disabled?

Ah, I wasn't aware that I had to disable sync in order to change these values.


Update Troubleshooting.md

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/Troubleshooting.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


hitting ON key during READ instruction should cause READ to re-execute

Currently, when running the ZEMU debugger, hitting ON causes the entire program to exit. Greatly improved behavior would cause the PC to be reset to the beginning of the READ instruction and it should put the debugger in step mode.

Implemented in commit 483d2cc..e1676b8


letsencrypt acme providers : move providers settings from envar to the main traefik config file

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?
Hi,
When using letsencrypt acme with dnsChallenge, we need to use an API from our registrar/dns provider to create some DNS records for the challenge work.
In case of having multiples domain names, on the same registrar/dns provder BUT on differents "administratives" accounts, we a have a problem because we have more than one API keys.
My feature request is to move dnsChallenge providers settings documented here : https://doc.traefik.io/traefik/https/acme/#providers
To the main traefik config file like this example :
certificatesResolvers:
  letsencrypt-ovh-1:
    acme:
      email<EMAIL_ADDRESS>      storage: /traefik-certs/letsencrypt-ovh-1.json
      caServer: https://acme-v02.api.letsencrypt.org/directory
      keyType: RSA4096
      dnsChallenge:
        provider: ovh
        OVH_APPLICATION_KEY: 111111
        OVH_APPLICATION_SECRET: 111111
        OVH_CONSUMER_KEY: 111111
        OVH_ENDPOINT: ovh-eu
        OVH_HTTP_TIMEOUT: 300
        OVH_POLLING_INTERVAL: 20
        OVH_PROPAGATION_TIMEOUT: 600
        OVH_TTL: 3600
        delayBeforeCheck: 20
        resolvers:
          - dns113.ovh.net:53
          - ns113.ovh.net:53
  letsencrypt-ovh-2:
    acme:
      email<EMAIL_ADDRESS>      storage: /traefik-certs/letsencrypt-ovh-2.json
      caServer: https://acme-v02.api.letsencrypt.org/directory
      keyType: RSA4096
      dnsChallenge:
        provider: ovh
        OVH_APPLICATION_KEY: 222222
        OVH_APPLICATION_SECRET: 222222
        OVH_CONSUMER_KEY: 222222
        OVH_ENDPOINT: ovh-eu
        OVH_HTTP_TIMEOUT: 300
        OVH_POLLING_INTERVAL: 20
        OVH_PROPAGATION_TIMEOUT: 600
        OVH_TTL: 3600
        delayBeforeCheck: 20
        resolvers:
          - dns113.ovh.net:53
          - ns113.ovh.net:53

Duplicate of #5472

You can close this issue, i haven't used "per resolver" or  "per provider" in my search, i use somes keywords like  "letsencypt multiple provider account"


Python project structure bootstrapping

After #269
For a Library project we can just bootstrap with
── project_name (or src; undecided)
        └──  __init__.py

For an application
── project_name (or src; undecided)
        ├── __init__.py
        └──  main.py

With main.py containing
def main():
    ...

Related to https://github.com/cnpryer/huak/issues/128#issuecomment-1264741108

I'll take a look at this.

MVP


Update nf-ntddk-rtlincrementcorrelationvector.md

Adding link to correlation vector implementation. The link will help customers to navigate to Microsoft implementation of correlation vector used for diagnostic purposes.

See comments in #233


runtime-sdk/modules/contracts: Propagate errors in WASM lib calls

question about this PR though: we do a lot of error propagation through Results, whereas here it's an Option in a context structure. Is it better this way? Maybe are there limitations with having it as part of an error type? It looks like, for one thing, we're locked into a wasm3-specific error enum.

The problem is that this is about propagating errors from inside functions that are called from within WASM (e.g. imported WASM modules provided by the Oasis ABI). You cannot directly propagate an error as you can only trigger an interpreter abort. So we need to store the error in the execution context structure that can be inspected after the overall call into WASM returns.


Incorrect Response content-type for nodes.hot_threads

The response of nodes.hot_threads:
make validate stack-version=8.0.0-SNAPSHOT type=response api=nodes.hot_threads

Text instead of JSON is returned. Can you confirm that the correct header is emitted?

According to the API the response is always string: https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-nodes-hot-threads.html
I tried to send a request with ?format=json but I'm still getting back a text/plain.
Not sure why we have a structured definition, I suspect a nestism, maybe @stevejgordon knows more?

Apparently this is causing an issue with the Java client: https://github.com/elastic/elasticsearch-java/issues/865


Add developer onboarding docs

Update documentation providing information relevant for developers/engineering onboarding.

@jortel Thanks for your feedback! Updated.

It's a good idea to onboarding documentations for developers but this would need to be adjusted now, so I'm closing this one and I'll add an issue on kubev2v/forklift that references this. thanks @aufi !


Improvement/no issue

Reason for the Pull request:

Update dependency Pillow Library to fix security issue
Update Jenkins file because the build failed due to an update of the nodes


_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 50s
the patch passed

-0 :warning:
javadoc
0m 19s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 15s
root in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
178m  0s
root in the patch passed.

193m 19s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1747

Optional Tests
javac javadoc unit

uname
Linux bb1d0ce51e9a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 86a2692dc4

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/1/testReport/

Max. process+thread count
6643 (vs. ulimit of 12500)

modules
C: hbase-common . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
4m 46s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 43s
master passed

+0 :ok:
refguide
4m 59s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+0 :ok:
mvndep
2m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 45s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
5m 47s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

28m  7s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1747

Optional Tests
dupname asflicense refguide xml

uname
Linux 11caa0cbf1c7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 80b64ef4dc

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/2/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/2/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-common . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
4m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 37s
master passed

+0 :ok:
refguide
4m 51s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+0 :ok:
mvndep
2m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 18s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 43s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 30s
The patch does not generate ASF License warnings.

25m 40s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1747

Optional Tests
dupname asflicense refguide xml

uname
Linux 05fced85d4ed 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9d9f07be36

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/3/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/3/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
79 (vs. ulimit of 12500)

modules
C: hbase-common . U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
2m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 56s
the patch passed

-0 :warning:
javadoc
0m 18s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 17s
root in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
179m 30s
root in the patch passed.

200m 27s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1747

Optional Tests
javac javadoc unit

uname
Linux f9406fe76893 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 80b64ef4dc

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/2/testReport/

Max. process+thread count
7754 (vs. ulimit of 12500)

modules
C: hbase-common . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
4m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 38s
master passed

+0 :ok:
refguide
4m 51s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+0 :ok:
mvndep
2m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
4m 48s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

25m 50s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1747

Optional Tests
dupname asflicense refguide xml

uname
Linux 02e6634a6a6e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9d9f07be36

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/4/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/4/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
78 (vs. ulimit of 12500)

modules
C: hbase-common . U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
2m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 48s
the patch passed

-0 :warning:
javadoc
0m 21s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 18s
root in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
162m 32s
root in the patch passed.

186m 19s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1747

Optional Tests
javac javadoc unit

uname
Linux 45e2c8a15cd6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9d9f07be36

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/4/testReport/

Max. process+thread count
7852 (vs. ulimit of 12500)

modules
C: hbase-common . U: .

 U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1747/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Create createCard endpoint

Is your feature request related to a problem? Please describe.
Create a new endpoint (or adjust existing one) that receive the user data from the self service portal
Describe the solution you'd like

add a function that receives user data: Name, Aktenzeichen and Birthday
Hash this data and check if the user is permitted or not
if not permitted throw an error
if permitted send the cardData (Name, Aktenzeichen, Birthday, StartDate, and the other general needed data)
rate limiting: since this endpoint is not protected, it should be ensured that IPs with too many requests should be blocked, especially because the argon2id calculation is expensive.

Describe alternatives you've considered
We could extend the current createCard mutation and allow creating without jwt token if its a particular projectId (not sure if that is secure enough)
blocked by https://github.com/digitalfabrik/entitlementcard/pull/1499

add a function that receives user data: Name, Aktenzeichen and Birthday

@f1sh1918 I guess the user would also need to select a region, wouldn't they?

rate limiting: since this endpoint is not protected, it should be ensured that IPs with too many requests should be blocked, especially because the argon2id calculation is expensive.

just got a sudden idea.
what if instead of a web form to issue a card, we create such form in the flutter app?
I believe this would solve the issue above and may also be more convenient for users because there would be no need to download and scan pdfs

Its a good idea but we have lots of existing functionality in the "administration" like the card extensions, deeplinks which we can reuse. Further more we could also provide additionally a pdf if a service user supports a user that can not create the card by him/herself and just pass the pdf to him/her.
Normal use case is that the user doesn't have to scan or download the pdf but just create the card and then click a button with a custom_scheme deeplink which opens the app and activates the card.

@f1sh1918 is a BUT that doesn't make sense to discuss or doch? :)

which we can reuse
but is it bad if we don't have to?

the card extensions
is it applicable to Koblenz? is it something that an unauthorized user does? (I'm not familiar with this process)

Normal use case is that the user doesn't have to scan or download the pdf
right, but still an extra action and extra browser interaction.

@f1sh1918 is a no-way but or to be discussed?

which we can reuse

is it bad if we won't have to? I assumed it could mean for us to do less, not more

the card extensions

is it applicable to Koblenz? is it something that an unauthorized user does? (I'm not familiar with this process)

if a service user supports a user that can not create the card

is it a plausible case when the form has 3 fields?

Normal use case is that the user doesn't have to scan or download the pdf

right, but still an extra action and extra browser interaction.

is it bad if we won't have to? I assumed it could mean for us to do less, not more (or am I missing something?)

Just found an answer here and it seems to me that both actions could be done through the app
https://github.com/digitalfabrik/entitlementcard/issues/1430

I think we discussed the process we gonna go with the customer. All projects have a separate "beantragen" function in the browser. But anyway:
If we move the function in the app we can not easily use the pdf creation and we might need that.
Additionally we have an easy extendable card configuration in the administration where we already have All fields with validation except the referenceNumber.
We had a quite strict budget for this project and i don't see that the improvement is that huge that it's worth the additional effort

Ah and one thing I forgot was that we should keep the possibility to create a static printed pass

Do we want to have a column userentitlements_id (or any-better-name) in the cards table?


[ALLUXIO-2020] Adding cp command for the Alluxio shell.

Addresses https://alluxio.atlassian.net/browse/ALLUXIO-2020

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10355/
Test PASSed.

Thanks @jsimsa for adding the new command. I left a few comments.

@ifcharming addressed your comments, PTAL

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10356/
Test PASSed.

@jsimsa Thanks, I left some comment on tests.

@jsimsa thanks for the PR. I left a bunch comments.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10361/
Test PASSed.

@apc999 @ifcharming @uronce-cc @aaudiber addressed your comments, PTAL

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10362/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10365/Build result: FAILURE[...truncated 2346 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/client/pom.xml to org.alluxio/alluxio-keyvalue-client/1.2.0-SNAPSHOT/alluxio-keyvalue-client-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/client/target/alluxio-keyvalue-client-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-keyvalue-client/1.2.0-SNAPSHOT/alluxio-keyvalue-client-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/client/target/alluxio-keyvalue-client-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-keyvalue-client/1.2.0-SNAPSHOT/alluxio-keyvalue-client-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/pom.xml to org.alluxio/alluxio-underfs-hdfs/1.2.0-SNAPSHOT/alluxio-underfs-hdfs-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-hdfs/1.2.0-SNAPSHOT/alluxio-underfs-hdfs-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-hdfs/1.2.0-SNAPSHOT/alluxio-underfs-hdfs-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/pom.xml to org.alluxio/alluxio-underfs-swift/1.2.0-SNAPSHOT/alluxio-underfs-swift-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-swift/1.2.0-SNAPSHOT/alluxio-underfs-swift-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-swift/1.2.0-SNAPSHOT/alluxio-underfs-swift-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.2.0-SNAPSHOT/alluxio-examples-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/pom.xml to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.2.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/pom.xml to org.alluxio/alluxio-keyvalue-common/1.2.0-SNAPSHOT/alluxio-keyvalue-common-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-keyvalue-common/1.2.0-SNAPSHOT/alluxio-keyvalue-common-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-keyvalue-common/1.2.0-SNAPSHOT/alluxio-keyvalue-common-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/pom.xml to org.alluxio/alluxio-underfs/1.2.0-SNAPSHOT/alluxio-underfs-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/pom.xml to org.alluxio/alluxio-underfs-glusterfs/1.2.0-SNAPSHOT/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-glusterfs/1.2.0-SNAPSHOT/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-glusterfs/1.2.0-SNAPSHOT/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/pom.xml to org.alluxio/alluxio-integration/1.2.0-SNAPSHOT/alluxio-integration-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/pom.xml to org.alluxio/alluxio-keyvalue/1.2.0-SNAPSHOT/alluxio-keyvalue-1.2.0-SNAPSHOT.pomchannel stopped
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10367/Build result: FAILURE[...truncated 2626 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/client/target/alluxio-keyvalue-client-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-keyvalue-client/1.2.0-SNAPSHOT/alluxio-keyvalue-client-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/pom.xml to org.alluxio/alluxio-underfs-hdfs/1.2.0-SNAPSHOT/alluxio-underfs-hdfs-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-hdfs/1.2.0-SNAPSHOT/alluxio-underfs-hdfs-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-hdfs/1.2.0-SNAPSHOT/alluxio-underfs-hdfs-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/pom.xml to org.alluxio/alluxio-underfs-swift/1.2.0-SNAPSHOT/alluxio-underfs-swift-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-swift/1.2.0-SNAPSHOT/alluxio-underfs-swift-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-swift/1.2.0-SNAPSHOT/alluxio-underfs-swift-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.2.0-SNAPSHOT/alluxio-examples-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-examples/1.2.0-SNAPSHOT/alluxio-examples-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-examples/1.2.0-SNAPSHOT/alluxio-examples-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/pom.xml to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.2.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-server/1.2.0-SNAPSHOT/alluxio-core-server-1.2.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/pom.xml to org.alluxio/alluxio-keyvalue-common/1.2.0-SNAPSHOT/alluxio-keyvalue-common-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-keyvalue-common/1.2.0-SNAPSHOT/alluxio-keyvalue-common-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-keyvalue-common/1.2.0-SNAPSHOT/alluxio-keyvalue-common-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/pom.xml to org.alluxio/alluxio-underfs/1.2.0-SNAPSHOT/alluxio-underfs-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/pom.xml to org.alluxio/alluxio-underfs-glusterfs/1.2.0-SNAPSHOT/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-glusterfs/1.2.0-SNAPSHOT/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-glusterfs/1.2.0-SNAPSHOT/alluxio-underfs-glusterfs-1.2.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/pom.xml to org.alluxio/alluxio-integration/1.2.0-SNAPSHOT/alluxio-integration-1.2.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/pom.xml to org.alluxio/alluxio-keyvalue/1.2.0-SNAPSHOT/alluxio-keyvalue-1.2.0-SNAPSHOT.pomchannel stopped
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10369/
Test PASSed.

Merged build finished. Test PASSed.

LGTM

@jsimsa I put my comment on having "-R" to make cp consistent with mv and ls and etc. Otherwise, I am fine with this PR. Let me know if you feel strong about not having -R, and we could discuss offline.

LGTM

LGTM

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10377/
Test PASSed.

@apc999 I added support for -R and more tests (and also did some additional test cleanup)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10383/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.shell.command.TailCommandTest.tailWildcardTest
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10384/
Test PASSed.

@yupeng9 thanks for your review ... addressed your comment

LGTM thanks for the new command!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10387/
Test PASSed.

LGTM


Possible to remove songs individually?

Hi! I was just wondering if there is a command to remove like the 5th song in a queue? And if not, is it something that could be added? :)

Take a look at this
#486

I have no Idea how that work lmao :joy:

Go to this link and download the musicbot from there. When you've done that you should have a !remove function

We do not provide support for modifying the bot beyond what is written on this page: https://github.com/Just-Some-Bots/MusicBot/wiki/Modification. A feature request already exists here: #91


Sudo stopped working inside of toolbox containers

Recently, sudo stopped working inside my toolbox containers. It complains that the sudoers.d file is world writeable. I am not exactly sure of the root cause of this, as it seems to come from somewhere outside of this repo.
This PR resolves the issue for me, but I am not sure if that is the best way to solve it.
https://github.com/cgwalters/coretoolbox/pull/11

fixed by https://github.com/cgwalters/coretoolbox/pull/11


json unmarshal error when calling client.ListQueries

Calling client.ListQueries(ctx) (using ksqldb server v0.17.0) returns the following error:
unable to decode JSON response '<JSON_RESP>': json: cannot unmarshal array into Go value of type client.ExecResult

An example of a json response that causes this error is below:
[
    {
        "@type": "queries",
        "statementText": "LIST QUERIES;",
        "queries": [
            {
                "queryString": "CREATE OR REPLACE TABLE SOME_TABLE WITH (KAFKA_TOPIC='SOME_TABLE', PARTITIONS=3, REPLICAS=1) AS SELECT * FROM SOME_OTHER_TABLE EMIT CHANGES;",
                "sinks": [
                    "SOME_TABLE"
                ],
                "sinkKafkaTopics": [
                    "SOME_TABLE"
                ],
                "id": "CTAS_SOME_TABLE_69",
                "statusCount": {
                    "RUNNING": 1
                },
                "queryType": "PERSISTENT",
                "state": "RUNNING"
            }
        ],
        "warnings": []
    }
]

Looking at the source code for client.ListQueries I've pinpointed the error to be in exec.go#L92. The json decode fails due to the following error:
json: cannot unmarshal array into Go struct field Query.queries.sinks of type string

This error is then ignored, and the code then proceeds to try to decode in to a single ExecResult instead, which also fails and returns the original error message above.
I believe that the problem is that although descriptions.go#L23 sets the type of Query.Sinks to be string (as per ksqldb docs), the actual response is returning an array of strings, so the Query.Sinks type should be []string instead. Making this change resolves the error.
Interestingly, the above example respose also has some extra fields not included in the ksqldb docs which only mention queryString, sinks and id.

Thanks for reporting this. Would you be comfortable preparing a PR with the fix you mentioned?
@swist maybe you could also look into fixing the ksqldb docs?

#9


Import initial AU data to Specify

This task is currently blocked by #551

I imported the first ten records to Specify. Side note: I manually synonymized the synonyms for this first round. I'll now send them to Birgitte and Finn for review.


Update huggingface_hub version to 0.13

Needed to use new list_repo_commits() function, see https://github.com/huggingface/datasets-server/pull/985#discussion_r1160664348

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Codecov Report
Patch coverage has no change and project coverage change: -10.15 :warning:

Comparison is base (9f7edde) 98.13% compared to head (83c847f) 87.98%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1039       +/-   ##
===========================================
- Coverage   98.13%   87.98%   -10.15%
===========================================
  Files           6       99       +93
  Lines         107     4227     +4120
===========================================
+ Hits          105     3719     +3614
- Misses          2      508      +506

Flag
Coverage Δ

jobs_cache_maintenance
98.13% <ø> (ø)

jobs_mongodb_migration
80.84% <ø> (?)

libs_libcommon
93.35% <ø> (?)

services_admin
88.30% <ø> (?)

services_api
84.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 93 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


blockadblock.js is not blocked by Adblocker

Important notice,
that blockadblock.js is not blocked bacause it's not in the easylist (check https://easylist-downloads.adblockplus.org/easylist.txt).
However, the script named fuckadblock.js script gets blocked when Adblock & ABP is present in users' browser!
Unfortunately, fuckadblock.js is not so convenient name in production code, but you can use a js file called abdetect.js instead.

Indeed, this makes detection more efficient if the file is blocked, but the detection via Javascript works quite. So in the end, it should not have any impact.
In the worst case, you can rename "blockadblock.js" to "ads.js" ;)

Renaming to "ads.js" would just trigger a different filter.


Generate releases on Travis

We could use Travis to manage our releases, every tag created automatically triggers a build on Travis which can then build and deploy our frameworks to GitHub.
Reference: GitHub Releases Uploading.

@RuiAAPeres What do you think about doing this?

Oh that's pretty awesome!

:+1:


Playerbot console commands cause server crash due to SQL malformed query.

Console commands such as:

playerbot rndbot teleport [name]
playerbot rndbot refresh [name]
playerbot rndbot change_strategy [name]

causes a worldserver crash due to a SQL statement error.
This is due to:
RandomPlayerbotMgr.cpp line ~1714 in method HandlePlayerbotConsoleCommand:
if (QueryResult results = CharacterDatabase.Query("SELECT guid FROM characters WHERE account = {} AND name like {}", account, name.c_str()))
missing quote around the 'name' field.  The code should read like this:
if (QueryResult results = CharacterDatabase.Query("SELECT guid FROM characters WHERE account = {} AND name like '{}'", account, name.c_str()))

im looking and a number of difference query's and a number of them don't have those quests. don't know anything about sql how do you know when you need them or don't

Well if it's a text you need the quotes like a char name but if its a number it's optional.
So in this case account = # is OK but name like needs a quote.

does this effect read and write or just one or the other? i only ask cause i'm following 2 bots xp one my own alt and a random bot my alt does update xp but the random bot has been at 6250 for an hour... only thing i can figure is either 1 the update is written wrong or 2 i don't have permission to update those random bot accounts

Thank you so much for report this issue and detailing the fix. Fix is committed in https://github.com/ZhengPeiRu21/mod-playerbots/commit/7c16f2ae48926be0af20f921774dc335f1b74124.


feature req: connecting social oauth profiles

Would be very useful to enable a user to connect multiple social oauth profiles to one account.
Is this on the roadmap?

I know the metadata supports multiple auth methods per user, but I don't know how we can actually do it. I'm pretty sure doing OAuth creates a branch new user. @Tryneus how should this work?

Firebase allows you to "link" multiple auth providers to a account (see docs). Once the user is already signed in to one of their accounts you can then link others by doing:
firebase.auth.currentUser.link(<firebase.auth.AuthCredential>).then(function(user) {
  console.log("Account linking success", user);
});

I think the existing behavior of the OAuth flow always creating a new user by default should remain. I like how linking additional providers is all part of their client API.


[Task #2680] Add integration test for more dubbo api DubboTestService

#2680

add integrated test for DubboTestService in shenyu-examples-apache-dubbo-service
add integrated test for DubboTestService in shenyu-examples-alibaba-dubbo-service

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #2741 (e95d8e9) into master (9727565) will decrease coverage by 0.54%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2741      +/-   ##
============================================
- Coverage     60.18%   59.64%   -0.55%
+ Complexity     4413     4376      -37
============================================
  Files           681      681
  Lines         19614    19614
  Branches       1743     1743
============================================
- Hits          11804    11698     -106
- Misses         6814     6928     +114
+ Partials        996      988       -8

Impacted Files
Coverage Δ

...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java
43.75% <0.00%> (-31.25%)
:arrow_down:

...gin/apache/dubbo/cache/ApacheDubboConfigCache.java
43.03% <0.00%> (-29.12%)
:arrow_down:

...yu/sync/data/http/refresh/AbstractDataRefresh.java
70.00% <0.00%> (-13.34%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
70.58% <0.00%> (-13.24%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
52.12% <0.00%> (-10.64%)
:arrow_down:

...apache/shenyu/admin/utils/ShenyuDictH2Trigger.java
63.63% <0.00%> (-9.10%)
:arrow_down:

...ache/shenyu/admin/utils/PluginHandleH2Trigger.java
63.63% <0.00%> (-9.10%)
:arrow_down:

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java
57.14% <0.00%> (-7.15%)
:arrow_down:

...org/apache/shenyu/admin/model/dto/AuthPathDTO.java
58.82% <0.00%> (-5.89%)
:arrow_down:

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9727565...e95d8e9. Read the comment docs.


Run bsz > allocated cache bsz

https://github.com/turboderp/exllama/issues/182#issuecomment-1646595220
Based on turboderps suggestion, allows one to allocate a cache (with for example batch size 20) but run a for example single batch at full speed

I accidentally put this into main on my side, will do a new PR from a different branch of mine.

I just saw you already pushed that change on your own

Yeah, it was always intended behavior. I just couldn't push the change before because of some other things in the pipeline.


Typo in exports  in /selectors/nodes file

I wanted to create custom expadable component based on the docs example.I have encountered typo in mentioned file.It is weird for me that i have different content inside of my node_module/react-virtualized-tree compare to github master branch.
I have installed it through npm by npm install react-virtualized-tree.And i can see that it is 1.2.5 version
You can check this codesandbox example for clarification.

Hi @smoleniuch.
That's easy to explain, master has @next and not @1.2.5 code, is imminent and master has the code that will be released as part of version 2.0.0, that will happen later this week.
I'm not sure what's the problem in your code, but take note that react-virtualized-tree has a peer dependency with react-virtualized, to use it you should install react-virtualized too as part of your application.
The mentioned issue was fixed at https://github.com/diogofcunha/react-virtualized-tree/pull/24/files.
I would recommend you to run npm install react-virtualized-tree@next, that version should be stable enough now and has several improvements over the version your using

Thanks @diogofcunha for clarification.
Cheers!


Possible bug embedding using module inside a method call

From @rjmholt on January 11, 2017 2:12
Was deleting a using module Foo statement inside a [powershell]::AddStatement(...) method call. Screenshot attached:

Copied from original issue: lzybkr/PSReadLine#489

I can't reproduce (for both WindowsPowershell and Powershell Core):
PS C:\temp> $a=[powershell]::Create()
PS C:\temp> $a.AddStatement(using module f)
>>
At line:1 char:17
+ $a.AddStatement(using module f)
+                 ~
Missing ')' in method call.
At line:1 char:17
+ $a.AddStatement(using module f)
+                 ~~~~~
Unexpected token 'using' in expression or statement.
At line:1 char:31
+ $a.AddStatement(using module f)
+                               ~
Missing a newline or semicolon.
At line:1 char:17
+ $a.AddStatement(using module f)
+                 ~~~~~~~~~~~~~~
A 'using' statement must appear before any other statements in a script.
At line:1 char:31
+ $a.AddStatement(using module f)
+                               ~
Unexpected token ')' in expression or statement.
At line:1 char:17
+ $a.AddStatement(using module f)
+                 ~~~~~~~~~~~~~~
Could not find the module 'f'.
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : MissingEndParenthesisInMethodCall

PS C:\temp>

I repro'd the problem at the console in Windows PowerShell - there might be something about how PSReadline is invoking the parser, but I moved the bug from PSReadline because the call stack makes it clear it's an engine problem, not a PSReadline problem.

@lzybkr Could you post the exact code to reproduce the problem? (Then I'll try to debug and fix).
Please clarify - Is there the problem in Powershell Core too or only in Windows Powershell?

Interactive repo - just typing in from the screen shot. I think it was both, will need to double check.

Confirmed, repros in full and core, just type $foo.bar(using module), you'll get the exception after typing the closing paren.

Oh, yes.  I'll try to debug on next week.

Apologies — I saw the reference to my PR appear here and thought that was enough; I know for next time.
It looks like your fix is considerably more useful.

@rjmholt The cross-references don't cause notifications to be sent by mail, only posts.


added bundleIdentifier for IOS

I also needed to check the bundleIdentifier when using this library so I added it in this pull request.

Released https://github.com/APSL/react-native-version-number/releases/tag/v0.1.3


Delete vendor/swap vendor issue

In the vendor table there were two instances of "STEMCELL Technologies".
One instance had only 1 antibody record. The other instance had hundreds of records.
I swapped the vendor with 1 antibody record to the one with hundreds of records.
I looked at the remaining vendor and it said there was only one antibody record!!!!
Then I did a search on the main page for "STEMCELL Technologies" and it returned 517 records.
But the vendor name was "ERROR".

I was using the following site: https://www.areg.metacell.us/

the same with two vendors with a similar but not exact vendor name did work


Content: Context for error message styling

As a user of the design system I want to know why required fields no longer take an asterisk and red colour.
GC Design System uses colour in a systematic way, so that it's consistent across user interface elements. We red is reserve for high attention items that need immediate attention.
A visual language supports accessibility by providing clear visual cues that match the behaviours and textual content of the components. This predictability helps make components and their related tasks be more perceivable, operable, understandable, and robust.

Example from client:
Based on the latest WET recommendations, the field should have a star and
(required) in red: <https://wet-boew.github.io/v4.0-ci/demos/formvalid/formvalid-en.html|
https://wet-boew.github.io/v4.0-ci/demos/formvalid/formvalid-en.html>
The red required and asterisk are not mandatory elements of Canada.ca, and no pattern has been standardized, we hope to do that as GC Design System grows. Here is our rationale for going with this design.
Visual Consistency Across Form Fields
When all required indicators are presented in primary text colour, it creates a consistent look across the form. This approach reduces the chance of fields appearing differently styled or emphasized more than others.
Clear Differentiation between Required and Error States
By displaying the “(required)” text in primary text colour instead of red, users can more easily distinguish between required fields and fields with validation errors. When error messages are displayed in red, it clearly indicates an issue that needs to be addressed, whereas primary coloured “(required)” text serves as neutral information. This reduces confusion and ensures that users don’t mistake a required field for one that has an error, improving the overall validation process.
In GC Design System, red is reserved for errors, danger, or branding (FIP, heading 1 underline).
Reference:
https://www.w3.org/WAI/test-evaluate/easy-checks/required-fields/#:~:text=The best way to indicat[…]ause it's considered punctuation


View button panel

This PR adresses #1227 .
ellipses directive has been changed. All buttons now belong to btn-primary class.
File Changed:

chaise/common/templates/ellipses.html

Example

@amitjha21:
Ah thank you. So in the case that glyphicon-trash is NOT being used in a button, we are changing it to blue. And then when we want to use it as a button, we change it back to white, but that's assuming the button is a color where white would show well.
We should adjust .glyphicon-trash { color: #428bca; } to be a styling on a class we created like glyphicon-trash-link or change it to a .glyphicon-trash { color: #428bca; }. Look at delete-link.html. And then we should remove button .glyphicon-trash { color: #fff; } from app.css.

Not sure if you saw that comment chained on to your previous one because of it being collapsed.

Added a tag for class and default #fff has been removed.


This branch got some sickness and we bailed to pull request #61. That got merged so we are closing this one.


HBASE-27539 Unify reference count in StoreFileReader and StoreFileInfo

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.


Chapter1/homework/7

Pass in all 32 tests.
I think my code is a real mess, but I think I will wait for feedback.

Thanks for the feedback.


Regression on smoke_catalina_* benchmarks

smoke_catalina_hot_mode_dev_cycle_ios__benchmark hotReloadMillisecondsToFrameAfterChange
smoke_catalina_hot_mode_dev_cycle_ios__benchmark hotRestartMillisecondsToFrame
smoke_catalina_start_up_ios timeToFirstFrameMicros
smoke_catalina_start_up_ios timeToFirstFrameRasterizedMicros
They all started at https://github.com/flutter/flutter/commit/a665393a0d5ebb591a502b28689d19ca1f5ed8be

@keyonghan

@godofredoc was helping check this issue yesterday, and didn't seem to find any related cause. Will sync with him today.

I think I know what could be affecting this metric, when we moved the phones we place them in a different orientation and rotation may not be locked down. @digiter @keyonghan if you are already at the office can you please try to disable rotation and lock the phones on portrait mode?

That's possible! Just locked the ios one on portrait mode. The android phone has already been locked. @franciscojma86 Please retry and let us know. Thanks.

Ran this benchmark on device lab with red and green commits, all yielding similar results even after factory-resetting the phone.
We are not really sure how the device lab migration could affect this benchmark, but it's when the problem started. The infra team is working on IP address issues and will try running the tests again to see if anything changes.
For now it's safe to remove the TODAY label and re-baseline the benchmark

Results from running tests
Commit | hotReloadMillisecondsToFrameAfterChange | hotReloadMillisecondsToFrame | hotRestartMillisecondsToFrame

HEAD (1982a5c3ec4e8bed39b90d536002c7597c127036) | 571 | 418 | 1,236
357d02c87b75d74382db212812e85a5d7d93dd7f | 538 | 415 | 1,215
HEAD (1982a5c3ec4e8bed39b90d536002c7597c127036) After phone reset | 498 | 422 | 1,193

Regression data is not showing up in the dashboard anymore.


[bug] Select - floating-ui autoUpdate runs continuously after closing select

Last seen on: 1.0.4
Describe the bug
In the web implementation of the Select component, after opening the select once and closing it, floating-ui's autoUpdate() function gets called continuously from that point onwards, despite the select's popover being closed.
To Reproduce

Open any page with a <Select> component on it, such as the docs page for the Select component.

Run this snippet in devtools console to add logging to all requestAnimationFrame/cancelAnimationFrame calls:

(() => {
  const RAF = window.requestAnimationFrame;
  // just in case, get native cancelAnimationFrame implementation:
  const iframe = document.createElement('iframe');
  iframe.style.display = 'none';
  document.body.appendChild(iframe);
  const CAF = iframe.contentWindow.cancelAnimationFrame;

  // add logging wrappers:
  window.requestAnimationFrame = (callback) => {
    const frame = RAF(callback);
    console.log('RAF', frame, callback);
    return frame;
  };

  window.cancelAnimationFrame = (frame) => {
    console.log('CAF', frame);
    return CAF(frame);
  };
})();

Open the select

Close the select

See autoUpdate still getting called continuously

Let me know if this improved it: https://github.com/tamagui/tamagui/commit/cf2951a6c6aab70d1361e71c20126f725407fec9 out in 1.0.5

Let me know if this improved it

It didn't seem to make any difference 😭  ...but I think I found the solution: #525 (this also fixes the issue I saw in #514 with the scroll buttons never terminating)


Added demo video to landing page

The video is a little large. But I wanted to add something in for now. We can replace this with a compressed version later. We can also change the content of the video, and show collaboration across machines as well.

I uploaded a version of the video to Vimeo as well, but I think most modern browsers should support HTML5 video playback.

Here's a screenshot of how it looks as well:


Wrong comment

In the GpioChip class (file), in the comments of the string label it says:
 /// This is the hardware label of the underlying GPIO device.
 /// The main GPIO chip of the Raspberry Pi 4 has the label
 /// `brcm2835-pinctrl` for example.

But the label of of the main GPIO chip is pinctrl-bcm2835.

Updated it, thanks

Updated it, thanks


Added Fast Platform Switch

Switching between platforms on Unity is pretty slow, when developing for example on iOS and Android, switching between targets takes longer and longer as the project's assets grow.
Fast Platform Switch caches the modified assets state to make switching between targets pretty fast.
It's a must have if you are targeting more than one platform

+!

This package doesn't seem to have been updated in quite a while. Is it still supported in Unity 5?

@RyanNielson I've been using it on Unity 5 with no issues, but I just tried to contact the developer to confirm, I'll post back when/if I get a reply

Thanks for looking into it. Looking forward to hearing back from you. It seems like an incredibly useful asset.

@RyanNielson It's been a week and I got no reply from the developer, not sure if the tool is still being developed or not [even though it does support Unity 5 as far as I know].
Feel free to merge or reject this PR.


All instances of acmCreate and Create need to be renamed as Design or Design Team

This issue seems to have been resolved in #518.


strand information is missed in GTF output

My output gtf from stringtie contains 3630 gene models with "." strand (i.e. unstranded). So I followed @mpertea previous suggestion and checked my BAM file. I found the reads aligned to these gene model do have strand information, either "+" or "-". but I still got the unstranded gene model. Could anyone shed the light on this?
As I understand, once a read aligns to genome, it must have strand information, either + or -. Are there any exceptions for it without strand?

As I replied in the other thread, this was supposed to be fixed in the latest version. Could you please clarify if the StringTie version that produced these un-stranded transcripts for you was v1.2.2 ?

yes, I used the latest version v1.2.2.

There may be some confusion there - in the BAM file, where did you look for "strand information"?
The alignment strand information (available in the flag field of a SAM record) is not the same with the transcription strand information that StringTie needs (which is generally given by the spliced aligner by looking at the splice sites and made available in the XS tag in a SAM record). So for example a single-exon read may align to the reverse (-) strand of the genome, but this has nothing to do with the transcription strand, which is generally unknown for such un-spliced reads.
So are you saying that you found reads that have the XS tag with transcription strand info in the BAM file, but StringTie assembled them into transcripts without assigning them a strand (i.e. '.' in the strand column) ?

Thanks, Geo @gpertea . I misunderstood the strand issue at the beginning. now I got it. Thank you again for the prompt explanation.


Add Host Configuration option

This PR adds the ability to add a host configuration that takes president over conn.host
Tested within our application and it works.
ex: links: %{self: "http://www.not_example.com/api/user/535937“}

Couldn't find an elegant way to make this application wide. Any suggestions are appreciated.
Also not a fan of the case statements and open to suggestions to clean this up as well.

Also, this is opened to attempt to close #66

I think this PR can simplified down quite a bit.  To achieve the same goal, and allow for scheme to be configurable as well, we should only need to change about four lines:
      def url_for(data, %Plug.Conn{}=conn) when is_list(data) do
        "#{scheme(conn)}://#{host(conn)}#{@namespace}/#{type()}"
      end

      def url_for(data, %Plug.Conn{}=conn) do
        "#{scheme(conn)}://#{host(conn)}#{@namespace}/#{type()}/#{id(data)}"
      end

      defp host(conn), do: Application.get_env(:jsonapi, :host) || conn.host

      defp scheme(conn), do: Application.get_env(:jsonapi, :scheme) || to_string(conn.scheme)

@bmrsny Thank you so much for the contribution. I think we should go with something similar to what @doomspork did in his branch here. https://github.com/doomspork/jsonapi/tree/feature/configurable-host-and-scheme could you make similar changes?

Updated the PR with changes that reflect @doomspork 's branch. I had to add an Application.delete_env to the test because the test would fail intermittently depending on the order that they ran in.
I did not incorporate the underscore_to_dash portions. I felt like it was out of scope with dealing with  url_for and was dealing with attributes data. I can include it if we want to move forward with that functionality, however.
Let me know your thoughts. Thanks all for your help and the opportunity to contribute to this awesome library!

These changes look good to me @bmrsny, thanks for the contribution!  I'll defer to @jeregrine for the merge 👍

Thank you so muh ❤💖


charts/osdfir-infrastructure update osdfir charts to 0.3.2

Description of the change
Need to bump versions as well in OSDFIR Infra (annoying will change in osdfir rearch) . Will wait to push charts into registry until this is merged
Checklist

[X ] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
[ X] Variables are documented in the values.yaml and added to the README.md usingreadme-generator-for-helm
[ X] Title of the pull request follows this pattern [charts/<name_of_the_chart>] Descriptive title

FYI will merge this after #72 (if it checks out) to see if its WAI


[$500] Web - Task - Can't find user email results when assigning tasks in group chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Create a group chat with several participants (new users)
Click "+" button and choose Assign task
Input title -> click "Next" -> Click "Assignee"
Enter the email of the member in the group

Expected Result:
User email search results can be found
Actual Result:
No results found
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-capture - 2023-09-05T045157.755.webm
https://github.com/Expensify/App/assets/93399543/38a2e9f3-5c07-4d65-971e-404150de4abf
Expensify/Expensify Issue URL:
Issue reported by: @thuyle04
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693917317156359
View all open jobs on GitHub

Could be a duplicate https://github.com/Expensify/App/issues/26072, please check and confirm. Thank you

Checking in with the engineers working on https://github.com/Expensify/App/issues/26072 to check if the proposal there will also solve for this

Suggestion in https://github.com/Expensify/App/issues/26072#issuecomment-1713797230 is that this won't be solved by that issue. Sending this external

Thanks for the input @namhihi237 - it looks like https://github.com/Expensify/App/pull/25806 issue involves not being able to assign a task to a new user. Can you tell me why you think that's the same as this issue, I might be missing something


Tests are not being run with NODE_ENV=test

Describe the bug
I had two problems when testing my Express server with supertest with the pre-release of the extension, this was one of them. I'm aware of process.env.VITEST_VSCODE, but that's not how this problem should be solved, NODE_ENV should still be set to test just like Vitest does.
I wasn't able to figure out the other problem, I keep getting "WebSocket server error: Port is already in use" in my logs and all of my server tests fail through the extension with 404 status instead of the expected one, even though I made sure not to start my server. But I suppose without a repro it's hard to tell what could've gone wrong.
Reproduction
For NODE_ENV it's not necessary, it just isn't available in v0.5.6.
For WebSocket I'll file a separate issue.
System Info
System:
    OS: macOS 14.4
    CPU: (8) arm64 Apple M1 Pro
    Memory: 51.06 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.19.1 - ~/.n/bin/node
    npm: 10.2.4 - ~/.n/bin/npm
    pnpm: 8.6.10 - /opt/homebrew/bin/pnpm
    bun: 1.0.31 - ~/.bun/bin/bun
  IDEs:
    VSCode: 1.87.2 - /usr/local/bin/code
    Vim: 9.0 - /usr/bin/vim
    Xcode: /undefined - /usr/bin/xcodebuild
  Browsers:
    Chrome: 122.0.6261.129
    Edge: 122.0.2365.92
    Safari: 17.4
  npmPackages:
    @vitejs/plugin-react: ^4.2.0 => 4.2.0
    @vitest/ui: ^1.2.2 => 1.4.0
    vite: ^5.0.0 => 5.0.0
    vitest: ^1.4.0 => 1.4.0

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

NODE_ENV is set to test.

Not while running tests via the extension, because my tests that rely on this are failing (because of that). Running the same tests via the Vitest CLI works.

In fact, logging process.env.NODE_ENV in beforeAll ends up being development to me 😮

Here's the repro: https://github.com/silvenon/repro/tree/vitest-extension-node-env

It looks like NODE_ENV ??= 'test' happens in startVitest API which is a wrapper of createVitest API used by vscode extension:
https://github.com/vitest-dev/vitest/blob/5c7e9ca05491aeda225ce4616f06eefcd068c0b4/packages/vitest/src/node/cli/cli-api.ts#L31-L55
export async function startVitest(...): Promise<Vitest | undefined> {
  process.env.TEST = 'true'
  process.env.VITEST = 'true'
  process.env.NODE_ENV ??= 'test'

  ...

  const ctx = await createVitest(mode, options, viteOverrides, vitestOptions)

When NODE_ENV is empty, if I remember correctly, Vite injects "development" by default, so probably that's what's happening currently.
For the time being, I think using vitest.nodeEnv should work (at least for test code, but maybe not if it's globalSetup etc...).
// .vscode/settings.json
{
  "vitest.nodeEnv": {
    "NODE_ENV": "test"
  }
}

I'm not sure where the fix should belong to. Whether adding the same process.env.... routine to vscode extension worker or createVitest should have this routine instead of startVitest wrapper.
I'm thinking we can fix createVitest side on Vitest, but maybe we should do both since users might not upgrade Vitest.

When NODE_ENV is empty, if I remember correctly, Vite injects "development" by default, so probably that's what's happening currently.

If that was the case, it wouldn’t have worked in a CLI. I think the problem is that we spread process.env when spawning Vitest API.


IndexError while scrolling and moving between subreddits

Didn't have a chance to figure this out myself. I was scrolling through a page and when I wanted to move out, I got the exception.
Connecting...
Traceback (most recent call last):
  File "/home/xavier/code/rtvtest/bin/rtv", line 7, in <module>
    from rtv.__main__ import main
  File "/home/xavier/code/rtvtest/local/lib/python2.7/site-packages/rtv/__main__.py", line 135, in <module>
    sys.exit(main())
  File "/home/xavier/code/rtvtest/local/lib/python2.7/site-packages/rtv/__main__.py", line 118, in main
    page.loop()
  File "/home/xavier/code/rtvtest/local/lib/python2.7/site-packages/rtv/subreddit.py", line 43, in loop
    self.draw()
  File "/home/xavier/code/rtvtest/local/lib/python2.7/site-packages/rtv/page.py", line 405, in draw
    self._add_cursor()
  File "/home/xavier/code/rtvtest/local/lib/python2.7/site-packages/rtv/page.py", line 471, in _add_cursor
    self._edit_cursor(curses.A_REVERSE)
  File "/home/xavier/code/rtvtest/local/lib/python2.7/site-packages/rtv/page.py", line 495, in _edit_cursor
    window, attr = self._subwindows[self.nav.cursor_index]
IndexError: list index out of range

I've tried to recreate it without success.
In [2]: rtv.__version__
Out[2]: '1.3'

Thanks for the heads up! I recently discovered a similar bug (same stack trace). I found that the problem was resizing the terminal window to be smaller, which was in some cases pushing the cursor off of the screen and out-of-bounds. There is a fix for this in b375fb71e7f34cd67be080ff0db7e1daa4ce184c, hopefully this fixes whatever you saw too!


fix(Immediate): Use global Math

Description:
This library does not work properly inside of a Firefox addon. See related issue.
Related issue (if exists):
https://github.com/ReactiveX/rxjs/issues/2446

And this change actually makes one of our test case fails, cause by not looking correct global context resolved via root module. I'm feeling it is quite exceptional cases some environment can resolve its own global but global function is not defined in there - rather ask code runs under such environment fulfills object correctly. But that's my 5 cent, I'll leave this opened bit to see other opinion. /cc @benlesh for review.

We can probably just change the test to temporarily monkey-patch Math.random.

Immediate is no longer a thing.


Add LocalizedError extenstion back to Linux as SR-3565 is fixed

Hm. Bug fixed on Feb 28th and the snapshot Travis is running against is 3.1-March 1, so this should have worked? Don't have the resources to test this against a current 3.1 snapshot locally.

Well this I don't understand. The PR supposedly fixing this was merged into Swift on March 2, Swift-3.1-RELEASE was cut on March 27 or thereabouts, Travis is testing against Swift-3.1-RELEASE and still failing 🤔 . Anyone have any ideas what might be going wrong?

I have no idea. 😕

While https://github.com/apple/swift-corelibs-foundation/pull/861 was merged, NSError does not conform to LocalizedError protocol so (nsError as Error).localizedDescription does not return expected value unfortunately: https://github.com/apple/swift-corelibs-foundation/blob/swift-3.1-branch/Foundation/NSError.swift#L291-L314

NSError does not conform to LocalizedError protocol so (nsError as Error).localizedDescription does not return expected value unfortunately

https://github.com/apple/swift-corelibs-foundation/pull/967 has been merged, so that should be fixed in Swift 4.0.

Closing this in favor of #227. Thanks for the pull request anyway!


Localization of interactive markers

Hi, I'm implementing this package to my own robot and to-be-processed workpiece. Since the pose of my workpiece would be changed frequently, I set the collision_mesh_frame as well as points_frame for target_pose_generator as my workpiece link(object_link) in config file. However, the interactive markers based on point cloud still remain at the base frame of robot (link_0), they are not aligned with my mesh model which is located correctly for robot processing. Could you please tell me how to fix this? Thanks in advance!
Here is my config file:
# Anchors
planning_group: &planning_group arm
collision_mesh_filename: &collision_mesh_filename package://reach_ros/iiwa/config/chair_seat_col.ply

optimization:
  radius: 0.2
  max_steps: 10
  step_improvement_threshold: 0.01

ik_solver:
  name: MoveItIKSolver
  distance_threshold: 0.0
  planning_group: *planning_group
  collision_mesh_frame: object_link
  collision_mesh_filename: *collision_mesh_filename
  touch_links: []

evaluator:
  name: MultiplicativeEvaluator
  plugins:
    - name: ManipulabilityMoveIt
      planning_group: *planning_group
    - name: DistancePenaltyMoveIt
      planning_group: *planning_group
      distance_threshold: 0.025
      exponent: 2
      collision_mesh_filename: *collision_mesh_filename
      touch_links: []

display:
  name: ROSDisplay
  collision_mesh_filename: *collision_mesh_filename
  collision_mesh_frame: object_link
  kinematic_base_frame: link_0
  marker_scale: 0.05

target_pose_generator:
  name: PointCloudTargetPoseGenerator
  pcd_file: package://reach_ros/iiwa/config/chair_seat_col.pcd
  points_frame: object_link
  target_frame: link_0

logger:
  name: BoostProgressConsoleLogger

Here is the visualization in Rviz:

Try using the TransformedPointCloudTargetPoseGenerator class instead. The poses for the reach study ultimately need to be defined relative to the base frame of the kinematic chain that you are using to solve IK, so this plugin will use TF to transform points defined in an arbitrary frame (object_link) to the defined kinematic base frame (link0). The PointCloudTargetPoseGenerator just assumes the point cloud file is already defined in the kinematic base frame.
target_pose_generator:
-  name: PointCloudTargetPoseGenerator
+  name: TransformedPointCloudTargetPoseGenerator
  pcd_file: package://reach_ros/iiwa/config/chair_seat_col.pcd
  points_frame: object_link
  target_frame: link_0

Thanks for quick reply. Unfortunately I switched to TransformedPointCloudTargetPoseGenerator but it still didn't work.
P.S. the origin frame of my mesh model and the corresponding point cloud are initially aligned with robot base frame, I created object_link in urdf in order to localize my mesh model to the desired place, then I set collision_mesh_frame as object_link. Seems that only the displayed mesh was transformed correctly, but those interactive markers derived from point cloud are not transformed.


Structure of redirections.xml file

It's not clear if VALUE must be defined as something or if it's just part of the schema:
<FrxProfileFolderRedirection ExcludeCommonFolders="<VALUE>">
If it has to be a value, what would it be and can we have better examples explaining this feature please?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 960d3cdb-4c5a-7c10-a78e-127b1216a547
Version Independent ID: a1bf2ff6-41a6-e840-676e-0eb4b9feed72
Content: Profile Container content - FSLogix
Content Source: fslogix-docs/manage-profile-content-cncpt.md
Product: fslogix
GitHub Login: @DougCoombs
Microsoft Alias: docoombs

nevermind - just scrolled to the bottom and it is explained :-)

This will be addressed in future documentation updates later this month.


HDDS-4561: We should support suggested Ratis Server Leader in OM HA.

What changes were proposed in this pull request?
Now the OM HA not support suggested Leader, we should support it.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4561
How was this patch tested?
Later will add unit test.

@qizhu-lucas , thanks for this improvement.  I have following general questions,

Is Ratis Leader hint supported in ratis now?
If Ratis Leader hint is supported, what's the use case that "ozone.om.ratis.suggested.leader.enable" should be set as false?

@ChenSammi

Ratis Leader suggested,  supported in ratis .
I just added false option for test, if we need roll back to original retry OMs based.

We had previously removed failover to suggested leader because the nodeId is guaranteed consistency across servers and clients. For example, in server nodeId1 could point to OM1 and in client nodeId1 could be pointing to OM2. In this scenario, when the client is told to failover to nodeId1, it will keep retrying the request on OM2 and never reach the actual leader OM1.
So instead of using the nodeId to failover, I think we should utilize the OM address to decide which node to failover to.

/pending "instead of using the nodeId to failover, I think we should utilize the OM address to decide which node to failover to"


An error occurs in the "rouge 1.9.1"

when i used the "rouge 1.9.1", an error occured.
events.js:72
        throw er; // Unhandled 'error' event
              ^
Error in plugin 'gulp-hologram'
/Library/Ruby/Gems/2.0.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:20: warning: already initialized constant Rouge::Lexers::Shell::KEYWORDS
/Library/Ruby/Gems/2.0.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:20: warning: previous definition of KEYWORDS was here
/Library/Ruby/Gems/2.0.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:25: warning: already initialized constant Rouge::Lexers::Shell::BUILTINS
/Library/Ruby/Gems/2.0.0/gems/rouge-1.9.1/lib/rouge/lexers/shell.rb:25: warning: previous definition of BUILTINS was here

    at Socket.<anonymous> (/Users/....../....../node_modules/gulp-hologram/index.js:96:30)
    at Socket.emit (events.js:117:20)
    at _stream_readable.js:943:16
    at process._tickCallback (node.js:419:13)

@usagi-f
I had the same problem:

gem uninstall rouge
gem install rouge -v 1.9.0

Then I changed the gemfile.lock to use this version.
Worked for me.

Worked for me to.


Text flows outside modal window

What was the reasoning behind removing the overflow-y on the modal content in this commit? It caused a regression in my project.
Commit: https://github.com/carbon-design-system/carbon-components/commit/2612b2da591d7840c17bc9ad705e693a2ed70c8a#diff-d662c14c5dcd7e4b41028bf60b9bc77bL94
For example:

Sorry about this regression, at the time it looked like overflow-y: auto wasn't needed and was removed but I didn't resize the browser drastically enough to see it was preventing that text flow from happening. I'll have a patch out really soon.

Merged the fix. Should be available in v7.10.3 once master branch is done with Travis CI build


Config for JitPack.io

Make the project can be automatically compiled on jitpack.io by judging whether there is a JITPACK variable.

@domesticmouse any thoughts?

@ipcjs can you describe what this achieves?

@stephenmcd I updated this description.

My understanding is that JitPack serves as a "maven central" for projects compiled directly from GitHub commits/releases.
@ipcjs in this projects case, I think the main benefit of enabling JitPack is that it would allow users of the library to use any branch or commit as their dependency. So users could use the current master branch head commit as a direct dependency for their project from JitPack, without having to depend on a release or build the project locally themselves. Is this right? Are there other benefits?

@barbeau Yes, you are right, that is all.

Ok that seems very worthwhile - thanks all for the input.


Add RT-7.9 BGP Policy - Import/Export Policy Action Using Extended Communities

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 52.298%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1673

Relevant Lines:
3199

💛  - Coveralls

@cfernanz this is ready for review