Modern code in the repo

"php": "^7.0"

Although we plan to support PHP 7.0 we could write PHP 7.4 code and use Rector in the release process.
What do you think?

I didn't mean using fart (=>) anywhere in Timber!

Personally I'm inclined to bump the PHP requirement up to 7.3 or 7.4, given that even 7.2 is about to get EOL'd. And 7.4 is not a very big leap from 7.3.
Rector looks pretty swanky, and if I'm understanding correctly, it wouldn't be a runtime dependency, nor even a permanent dev dependency - we'd only need it for the duration of a hypothetical migration. (Of course we could keep it around for more ongoing/sustainable maintenance, but the point is that we don't really have to think about it outside the context of migrations.) Is that right?
My only reservation is some potential subtlety in an automated change breaking the API in a hard-to-detect way. So once the 2.x is totally solidified, I'd want to run Rector in at least two phases - first for production code (lib) and then make sure all the completely unchanged tests still pass. Then and only then would we run a migration on tests. Seems like it's designed for that kind of incremental migration so I don't see this being a problem in theory.
All that is to say, I'm open to it, and Rector seems like it could be a game-changer in terms of the feasibility of actually getting such a migration done. That said, this should be part of the discussion already happening on #1863.

if I'm understanding correctly,

No @acobster, we would write code in PHP 7.4 and commit in the repo.
At release time we would run Rector and downgrade the code to PHP 7.0, so Composer and GitHub releases would only contain code that runs on PHP 7.0+
Sorry for not being clear.

Please see it action: https://blog.logrocket.com/coding-in-php-7-4-and-deploying-to-7-1-via-rector-and-github-actions/


Turing.jl error with AdvancedHMC

using Turing, Enzyme

@model function hmcmatrixsup()
    return v ~ Wishart(7, [1 0.5; 0.5 1])
end

model_f = hmcmatrixsup()
rng = Turing.Random.default_rng()
alg = HMC(0.15, 7; adtype=Turing.ADTypes.AutoEnzyme())
spl = Turing.Sampler(alg, model_f)
vi = Turing.DynamicPPL.default_varinfo(rng, model_f, spl)

DynamicPPL.initialstep(rng, model_f, spl, vi)

fails on https://github.com/TuringLang/Turing.jl/blob/4766fdde20ca9502472afcb991bd05f984d3ad35/src/mcmc/hmc.jl#L184
error msg
ERROR: Enzyme execution failed.
Mismatched activity for:   store {} addrspace(10)* %8, {} addrspace(10)** %.repack, align 8, !dbg !285, !noalias !234 const val:   %8 = load atomic {} addrspace(10)*, {} addrspace(10)* addrspace(11)* %7 unordered, align 8, !dbg !193, !tbaa !200, !nonnull !4, !dereferenceable !204, !align !191
Type tree: {[-1]:Pointer, [-1,0]:Pointer, [-1,0,0]:Pointer, [-1,0,0,-1]:Integer, [-1,0,8]:Integer, [-1,0,9]:Integer, [-1,0,10]:Integer, [-1,0,11]:Integer, [-1,0,12]:Integer, [-1,0,13]:Integer, [-1,0,14]:Integer, [-1,0,15]:Integer, [-1,0,16]:Integer, [-1,0,17]:Integer, [-1,0,18]:Integer, [-1,0,19]:Integer, [-1,0,20]:Integer, [-1,0,21]:Integer, [-1,0,22]:Integer, [-1,0,23]:Integer, [-1,0,24]:Integer, [-1,0,25]:Integer, [-1,0,26]:Integer, [-1,0,27]:Integer, [-1,0,28]:Integer, [-1,0,29]:Integer, [-1,0,30]:Integer, [-1,0,31]:Integer, [-1,0,32]:Integer, [-1,0,33]:Integer, [-1,0,34]:Integer, [-1,0,35]:Integer, [-1,0,36]:Integer, [-1,0,37]:Integer, [-1,0,38]:Integer, [-1,0,39]:Integer, [-1,8]:Pointer, [-1,8,0]:Pointer, [-1,8,8]:Integer, [-1,8,9]:Integer, [-1,8,10]:Integer, [-1,8,11]:Integer, [-1,8,12]:Integer, [-1,8,13]:Integer, [-1,8,14]:Integer, [-1,8,15]:Integer, [-1,8,16]:Integer, [-1,8,17]:Integer, [-1,8,18]:Integer, [-1,8,19]:Integer, [-1,8,20]:Integer, [-1,8,21]:Integer, [-1,8,22]:Integer, [-1,8,23]:Integer, [-1,8,24]:Integer, [-1,8,25]:Integer, [-1,8,26]:Integer, [-1,8,27]:Integer, [-1,8,28]:Integer, [-1,8,29]:Integer, [-1,8,30]:Integer, [-1,8,31]:Integer, [-1,8,32]:Integer, [-1,8,33]:Integer, [-1,8,34]:Integer, [-1,8,35]:Integer, [-1,8,36]:Integer, [-1,8,37]:Integer, [-1,8,38]:Integer, [-1,8,39]:Integer, [-1,16]:Pointer, [-1,16,0]:Pointer, [-1,16,0,-1]:Integer, [-1,16,8]:Integer, [-1,16,9]:Integer, [-1,16,10]:Integer, [-1,16,11]:Integer, [-1,16,12]:Integer, [-1,16,13]:Integer, [-1,16,14]:Integer, [-1,16,15]:Integer, [-1,16,16]:Integer, [-1,16,17]:Integer, [-1,16,18]:Integer, [-1,16,19]:Integer, [-1,16,20]:Integer, [-1,16,21]:Integer, [-1,16,22]:Integer, [-1,16,23]:Integer, [-1,16,24]:Integer, [-1,16,25]:Integer, [-1,16,26]:Integer, [-1,16,27]:Integer, [-1,16,28]:Integer, [-1,16,29]:Integer, [-1,16,30]:Integer, [-1,16,31]:Integer, [-1,16,32]:Integer, [-1,16,33]:Integer, [-1,16,34]:Integer, [-1,16,35]:Integer, [-1,16,36]:Integer, [-1,16,37]:Integer, [-1,16,38]:Integer, [-1,16,39]:Integer, [-1,24]:Integer, [-1,25]:Integer, [-1,26]:Integer, [-1,27]:Integer, [-1,28]:Integer, [-1,29]:Integer, [-1,30]:Integer, [-1,31]:Integer, [-1,32]:Integer, [-1,33]:Integer, [-1,34]:Integer, [-1,35]:Integer, [-1,36]:Integer, [-1,37]:Integer, [-1,38]:Integer, [-1,39]:Integer, [-1,40]:Integer, [-1,41]:Integer, [-1,42]:Integer, [-1,43]:Integer, [-1,44]:Integer, [-1,45]:Integer, [-1,46]:Integer, [-1,47]:Integer, [-1,48]:Integer, [-1,49]:Integer, [-1,50]:Integer, [-1,51]:Integer, [-1,52]:Integer, [-1,53]:Integer, [-1,54]:Integer, [-1,55]:Integer, [-1,56]:Integer, [-1,57]:Integer, [-1,58]:Integer, [-1,59]:Integer, [-1,60]:Integer, [-1,61]:Integer, [-1,62]:Integer, [-1,63]:Integer}
 llvalue=  %8 = load atomic {} addrspace(10)*, {} addrspace(10)* addrspace(11)* %7 unordered, align 8, !dbg !193, !tbaa !200, !nonnull !4, !dereferenceable !204, !align !191
You may be using a constant variable as temporary storage for active memory (https://enzyme.mit.edu/julia/stable/faq/#Activity-of-temporary-storage). If not, please open an issue, and either rewrite this variable to not be conditionally active or use Enzyme.API.runtimeActivity!(true) as a workaround for now

Stacktrace:
 [1] VarInfo
   @ ~/.julia/packages/DynamicPPL/93t4P/src/varinfo.jl:117

Stacktrace:
 [1] throwerr(cstr::Cstring)
   @ Enzyme.Compiler ~/.julia/packages/Enzyme/r8mFE/src/compiler.jl:1797

versions:
Julia Version 1.7.3
[7da242da] Enzyme v0.12.26
[fce5fe82] Turing v0.33.3

What happens if you set Enzyme.API.runtimeActivity!(true) as the error message says?
Turing already does this automatically so this isn't the cause of the issue at hand.

Uh maybe but also likely not. 1.7 and older Julia had a bunch of GC issues
that we fixed in later versions of Julia.
If you can make a much smaller MWE (eg without external packages and as
simplified as possible), we can investigate
On Fri, Aug 2, 2024 at 11:01 AM Hong Ge @.***> wrote:

Likely related: #1649 https://github.com/EnzymeAD/Enzyme.jl/issues/1649
#1081 https://github.com/EnzymeAD/Enzyme.jl/issues/1081
—
Reply to this email directly, view it on GitHub
https://github.com/EnzymeAD/Enzyme.jl/issues/1696#issuecomment-2265597446,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJTUXCYYNSCGU4SZKR6EITZPONMHAVCNFSM6AAAAABL4FY6KOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVGU4TONBUGY
.
You are receiving this because you commented.Message ID: <EnzymeAD/Enzyme.
@.***>

That latter issue again indicates you did not set runtime activity to true
(see the error message). This must be done shortly after loading Enzyme
On Fri, Aug 2, 2024 at 11:04 AM Xianda Sun @.***> wrote:

On 1.10.4, it also fails (on my machine MacOS)
Gives
ERROR: Enzyme execution failed.
Mismatched activity for:   store {} addrspace(10)* %getfield.i, {} addrspace(10)** %.fca.0.0.0.gep5, align 8, !dbg !359, !noalias !174 const val:   %getfield.i = load atomic {} addrspace(10), {} addrspace(10)** %.fca.<IP_ADDRESS>.gep unordered, align 8, !dbg !191, !alias.scope !206, !noalias !209, !nonnull !0, !dereferenceable !214, !align !215
Type tree: {[-1]:Pointer, [-1,0]:Pointer, [-1,0,0]:Pointer, [-1,0,0,-1]:Integer, [-1,0,8]:Integer, [-1,0,9]:Integer, [-1,0,10]:Integer, [-1,0,11]:Integer, [-1,0,12]:Integer, [-1,0,13]:Integer, [-1,0,14]:Integer, [-1,0,15]:Integer, [-1,0,16]:Integer, [-1,0,17]:Integer, [-1,0,18]:Integer, [-1,0,19]:Integer, [-1,0,20]:Integer, [-1,0,21]:Integer, [-1,0,22]:Integer, [-1,0,23]:Integer, [-1,0,24]:Integer, [-1,0,25]:Integer, [-1,0,26]:Integer, [-1,0,27]:Integer, [-1,0,28]:Integer, [-1,0,29]:Integer, [-1,0,30]:Integer, [-1,0,31]:Integer, [-1,0,32]:Integer, [-1,0,33]:Integer, [-1,0,34]:Integer, [-1,0,35]:Integer, [-1,0,36]:Integer, [-1,0,37]:Integer, [-1,0,38]:Integer, [-1,0,39]:Integer, [-1,8]:Pointer, [-1,8,0]:Pointer, [-1,8,8]:Integer, [-1,8,9]:Integer, [-1,8,10]:Integer, [-1,8,11]:Integer, [-1,8,12]:Integer, [-1,8,13]:Integer, [-1,8,14]:Integer, [-1,8,15]:Integer, [-1,8,16]:Integer, [-1,8,17]:Integer, [-1,8,18]:Integer, [-1,8,19]:Integer, [-1,8,20]:Integer, [-1,8,21]:Integer, [-1,8,22]:Integer, [-1,8,23]:Integer, [-1,8,24]:Integer, [-1,8,25]:Integer, [-1,8,26]:Integer, [-1,8,27]:Integer, [-1,8,28]:Integer, [-1,8,29]:Integer, [-1,8,30]:Integer, [-1,8,31]:Integer, [-1,8,32]:Integer, [-1,8,33]:Integer, [-1,8,34]:Integer, [-1,8,35]:Integer, [-1,8,36]:Integer, [-1,8,37]:Integer, [-1,8,38]:Integer, [-1,8,39]:Integer, [-1,16]:Pointer, [-1,16,0]:Pointer, [-1,16,0,-1]:Integer, [-1,16,8]:Integer, [-1,16,9]:Integer, [-1,16,10]:Integer, [-1,16,11]:Integer, [-1,16,12]:Integer, [-1,16,13]:Integer, [-1,16,14]:Integer, [-1,16,15]:Integer, [-1,16,16]:Integer, [-1,16,17]:Integer, [-1,16,18]:Integer, [-1,16,19]:Integer, [-1,16,20]:Integer, [-1,16,21]:Integer, [-1,16,22]:Integer, [-1,16,23]:Integer, [-1,16,24]:Integer, [-1,16,25]:Integer, [-1,16,26]:Integer, [-1,16,27]:Integer, [-1,16,28]:Integer, [-1,16,29]:Integer, [-1,16,30]:Integer, [-1,16,31]:Integer, [-1,16,32]:Integer, [-1,16,33]:Integer, [-1,16,34]:Integer, [-1,16,35]:Integer, [-1,16,36]:Integer, [-1,16,37]:Integer, [-1,16,38]:Integer, [-1,16,39]:Integer, [-1,24]:Integer, [-1,25]:Integer, [-1,26]:Integer, [-1,27]:Integer, [-1,28]:Integer, [-1,29]:Integer, [-1,30]:Integer, [-1,31]:Integer, [-1,32]:Integer, [-1,33]:Integer, [-1,34]:Integer, [-1,35]:Integer, [-1,36]:Integer, [-1,37]:Integer, [-1,38]:Integer, [-1,39]:Integer, [-1,40]:Integer, [-1,41]:Integer, [-1,42]:Integer, [-1,43]:Integer, [-1,44]:Integer, [-1,45]:Integer, [-1,46]:Integer, [-1,47]:Integer, [-1,48]:Integer, [-1,49]:Integer, [-1,50]:Integer, [-1,51]:Integer, [-1,52]:Integer, [-1,53]:Integer, [-1,54]:Integer, [-1,55]:Integer, [-1,56]:Integer, [-1,57]:Integer, [-1,58]:Integer, [-1,59]:Integer, [-1,60]:Integer, [-1,61]:Integer, [-1,62]:Integer, [-1,63]:Integer}
llvalue=  %getfield.i = load atomic {} addrspace(10), {} addrspace(10)** %.fca.<IP_ADDRESS>.gep unordered, align 8, !dbg !191, !alias.scope !206, !noalias !209, !nonnull !0, !dereferenceable !214, !align !215
You may be using a constant variable as temporary storage for active memory (https://enzyme.mit.edu/julia/stable/faq/#Activity-of-temporary-storage). If not, please open an issue, and either rewrite this variable to not be conditionally active or use Enzyme.API.runtimeActivity!(true) as a workaround for now
Stacktrace:
[1] _evaluate!!
@ ~/.julia/packages/DynamicPPL/93t4P/src/model.jl:973
[2] evaluate_threadunsafe!!
@ ~/.julia/packages/DynamicPPL/93t4P/src/model.jl:946
[3] evaluate!!
@ ~/.julia/packages/DynamicPPL/93t4P/src/model.jl:894
[4] logdensity
@ ~/.julia/packages/DynamicPPL/93t4P/src/logdensityfunction.jl:140
[5] logdensity
@ ~/.julia/packages/DynamicPPL/93t4P/src/logdensityfunction.jl:0
Stacktrace:
[1] throwerr(cstr::Cstring)
@ Enzyme.Compiler ~/.julia/packages/Enzyme/r8mFE/src/compiler.jl:1797
[2] _evaluate!!
@ ~/.julia/packages/DynamicPPL/93t4P/src/model.jl:973 [inlined]
[3] evaluate_threadunsafe!!
@ ~/.julia/packages/DynamicPPL/93t4P/src/model.jl:946 [inlined]
[4] evaluate!!
@ ~/.julia/packages/DynamicPPL/93t4P/src/model.jl:894 [inlined]
[5] logdensity
@ ~/.julia/packages/DynamicPPL/93t4P/src/logdensityfunction.jl:140 [inlined]
[6] logdensity
@ ~/.julia/packages/DynamicPPL/93t4P/src/logdensityfunction.jl:0 [inlined]
[7] diffejulia_logdensity_7234_inner_2wrap
@ ~/.julia/packages/DynamicPPL/93t4P/src/logdensityfunction.jl:0
[8] macro expansion
@ ~/.julia/packages/Enzyme/r8mFE/src/compiler.jl:6819 [inlined]
[9] enzyme_call
@ ~/.julia/packages/Enzyme/r8mFE/src/compiler.jl:6419 [inlined]
[10] CombinedAdjointThunk
@ ~/.julia/packages/Enzyme/r8mFE/src/compiler.jl:6296 [inlined]
[11] autodiff
@ ~/.julia/packages/Enzyme/r8mFE/src/Enzyme.jl:314 [inlined]
[12] autodiff
@ ~/.julia/packages/Enzyme/r8mFE/src/Enzyme.jl:326 [inlined]
[13] logdensity_and_gradient
@ ~/.julia/packages/LogDensityProblemsAD/rBlLq/ext/LogDensityProblemsADEnzymeExt.jl:73 [inlined]
[14] ∂logπ∂θ
@ ~/.julia/packages/Turing/r3Hmj/src/mcmc/hmc.jl:180 [inlined]
[15] ∂H∂θ(h::AdvancedHMC.Hamiltonian{…}, θ::Vector{…})
@ AdvancedHMC ~/.julia/packages/AdvancedHMC/AlvV4/src/hamiltonian.jl:38
[16] phasepoint(h::AdvancedHMC.Hamiltonian{…}, θ::Vector{…}, r::Vector{…})
@ AdvancedHMC ~/.julia/packages/AdvancedHMC/AlvV4/src/hamiltonian.jl:74
[17] phasepoint
@ ~/.julia/packages/AdvancedHMC/AlvV4/src/hamiltonian.jl:155 [inlined]
[18] initialstep(rng::Random.TaskLocalRNG, model::DynamicPPL.Model{…}, spl::DynamicPPL.Sampler{…}, vi_original::DynamicPPL.TypedVarInfo{…}; initial_params::Nothing, nadapts::Int64, @.***{})
@ Turing.Inference ~/.julia/packages/Turing/r3Hmj/src/mcmc/hmc.jl:184
[19] initialstep(rng::Random.TaskLocalRNG, model::DynamicPPL.Model{…}, spl::DynamicPPL.Sampler{…}, vi_original::DynamicPPL.TypedVarInfo{…})
@ Turing.Inference ~/.julia/packages/Turing/r3Hmj/src/mcmc/hmc.jl:151
[20] top-level scope
@ ~/Turing.jl/test/temp.jl:13
Some type information was truncated. Use show(err) to see complete types.
—
Reply to this email directly, view it on GitHub
https://github.com/EnzymeAD/Enzyme.jl/issues/1696#issuecomment-2265603157,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJTUXAUFYJASVWMTSPGVJDZPONXPAVCNFSM6AAAAABL4FY6KOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVGYYDGMJVG4
.
You are receiving this because you commented.Message ID: <EnzymeAD/Enzyme.
@.***>

bump @mhauru @sunxd3 and or @yebai

On my todo list, just haven't gotten to it yet, sorry. May still take a week or two to find time.

bump here @mhauru

@mhauru we've dropped Julia before 1.10, so I presume this error is moot and no longer applies. Reopen with a MWE if there's still an issue.


Fix sigma states corrupted when disconnect block

This PR also convert indentation for src/zerocoin_v3.cpp from tabs to spaces too. So try to review each commit will be more easy to read.

@psolstice you can click on each commit to review it one by one.

Still I don't like the idea of tabs/spaces fixes mixed with the relevant changes

@psolstice what is the problems with that? There is 2 choices if we want to go that way:

Discard the latest commit and force push to this PR. This will make it harder for other people that already review due to they cannot continue review just a new commits, they need to review the whole PR again. This also make PR history look weird too when someone take a look on this PR later.
Close this PR and open a new one. Other people that already review also need to review the whole PR again.


Add Python definition

Fixes Issue #111

Can you add some more features to make this a complete language definition?
On a quick look, it's missing: multi-line string literals; and maybe some keywords (e.g. nonlocal).

Sure...
Can you provide a sample .py file with the missing features
On Mar 12, 2017 9:07 AM, "Daniel Grunwald"<EMAIL_ADDRESS>wrote:
Can you add some more features to make this a complete language definition?
On a quick look, it's missing: multi-line string literals; and maybe some
keywords (e.g. nonlocal).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/icsharpcode/AvalonEdit/pull/112#issuecomment-285943493,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhSwj0W2d9bnuz8l950F1Nxb9caoY4Sks5rk-4sgaJpZM4MVrp4
.

@dgrunwald Not sure why the checks are failing...
the details does not show much that info either, Do you know what could be wrong?

Closing this PR will reopen a new one


[release-v0.24] SRVKE-936: Add dispatcher monitoring support

targets Serverless 1.18
adds support for monitoring the kafka dispacther
monitoring is updated when eventing CR observability part changes eg. user disables monitoring. Tested cases where user disabled monitoring and then enables it again via the Eventing CR.
once this is approved we can make a patch although its a very big due to the vendor changes
split into several commits to separate the vendor noise

To be used in conjunction with: https://github.com/openshift-knative/serverless-operator/pull/1204
To test:

Build controller image with ko publish cmd/channel/consolidated/controller/main.go
Use that in the S-O csv.
Launch the S-O using the PR above.
Create a kafka channel and link to an apiserversource and observe metrics:

cat <<-EOF | kubectl apply -f -
---
apiVersion: messaging.knative.dev/v1beta1
kind: KafkaChannel
metadata:
  name: my-kafka-channel
spec:
  numPartitions: 3
  replicationFactor: 1
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: events-sa
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: event-watcher
rules:
  - apiGroups:
      - ""
    resources:
      - events
    verbs:
      - get
      - list
      - watch
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: k8s-ra-event-watcher
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: event-watcher
subjects:
  - kind: ServiceAccount
    name: events-sa
    namespace: default
---
apiVersion: sources.knative.dev/v1
kind: ApiServerSource
metadata:
  name: testevents
spec:
  serviceAccountName: events-sa
  mode: Resource
  resources:
    - apiVersion: v1
      kind: Event
  sink:
    ref:
      apiVersion: messaging.knative.dev/v1beta1
      kind: KafkaChannel
      name: my-kafka-channel
---
apiVersion: messaging.knative.dev/v1
kind: Subscription
metadata:
  name: my-subscription
  namespace: default
spec:
  channel:
    apiVersion: messaging.knative.dev/v1beta1
    kind: KafkaChannel
    name: my-kafka-channel
  delivery:
    deadLetterSink:
      ref:
        apiVersion: serving.knative.dev/v1
        kind: Service
        name: event-display
  subscriber:
    ref:
      apiVersion: serving.knative.dev/v1
      kind: Service
      name: event-display
---
apiVersion: serving.knative.dev/v1
kind: Service
metadata:
  name: event-display
spec:
  template:
    spec:
      containers:
        - # This corresponds to
          # https://github.com/knative/eventing-contrib/tree/master/cmd/event_display/main.go
          image: quay.io/openshift-knative/knative-eventing-sources-event-display

EOF

Metrics shown in the OCP related dashboard: xxxx.dev.openshift.com/monitoring/dashboards/grafana-dashboard-definition-knative-eventing-channel

LGTM
But, I have 2 questions:

Do we add sidecars in other components as well? Can we somehow create a library or something which allows us to reuse code?
How much of this PR can we move upstream? I feel this is too much code to maintain downstream and carry into future branches.

Do we add sidecars in other components as well? Can we somehow create a library or something which allows us to reuse code?
Yes side cars are injected for all eventing and serving control plane resources as we modify the manifests at the knative operator side (the only pending exception is resources are there is an upstream issue to add support for sidecars).

How much of this PR can we move upstream? I feel this is too much code to maintain downstream and carry into future branches.
I dont think we can move this part upstream. Upstream stuff are not Prometheus based and are kept neutral for many reasons including lack of maintainance. Some part are also OCP specific.

knative.dev.KafkaChannel","knative.dev/traceid":"4db101cb-6eb5-4f48-832b-f0359e6efeb6","knative.dev/key":"eventing-e2e27/kafkachannel-kne-trigger","error":"Reconciling dispatcher Deployment failed with: Deployment.apps \"kafka-ch-dispatcher\" is invalid: spec.template.spec.containers[1].image: Required value","stacktrace":"knative.dev/eventing-kafka/pkg/channel/consolidated/reconciler/controller.

Need to set the rbac proxy image for tests. Will pass a default value.

Probably will need to add integration tests for scraping the metrics as we have at the S-O side.

@skonto what about 0.25 or later branches?

@skonto what about 0.25 or later branches?
@matzew the plan is to create a patch from this that can be applied in future release branches. Although it is a bit large.
One question would be do I need to include the vendor files in the patch?

@matzew now the correct ci file is generated with make RELEASE=v0.24.3 generate-release

LGTM

/unhold


Missing strings to be able to translate to PT-BR

Hi,
Missing strings to be able to translate to PT-BR


feat: add shadow to toast for better contrast

Description
Issues
Closes
DEV-XXX:
Related
Testing
Automated tests
Manual testing
Screenshots
Additional notes

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr214.dev.hel.ninja :rocket::rocket::rocket:

Sports-Helsinki branch is deployed to platta: https://liikunta-pr214.dev.hel.ninja :rocket::rocket::rocket:

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr214.dev.hel.ninja :rocket::rocket::rocket:

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr214.dev.hel.ninja :rocket::rocket::rocket:

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr214.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://liikunta-pr214.dev.hel.ninja :laughing::tada::tada::tada:

TestCafe result is success for https://tapahtumat-pr214.dev.hel.ninja :laughing::tada::tada::tada:

TestCafe result is success for https://harrastukset-pr214.dev.hel.ninja :laughing::tada::tada::tada:


PHOENIX-7367 - Snapshot based mapreduce jobs fails after HBASE-28401

Jira: PHOENIX-7367

Disable mslab for region created within snapshot (by setting hbase.hregion.memstore.mslab.enabled set to false)
In TableSnapshotResultIterator - Remove the the SnapshotScanner's close (via ScanningResultIterator) called within next method. It would anyways be closed by the mapper at the end while closing the record reader

Previous build has expired, triggered new build: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1941/

@ujjawal4046 several test failures on the latest build seem relevant? https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1941/3/testReport/

e.g.
java.lang.Exception: java.lang.NullPointerException
	at org.apache.hadoop.mapred.LocalJobRunner$Job.runTasks(LocalJobRunner.java:492) ~[hadoop-mapreduce-client-common-3.2.4.jar:?]
	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:552) ~[hadoop-mapreduce-client-common-3.2.4.jar:?]
Caused by: java.lang.NullPointerException
	at org.apache.phoenix.iterate.SnapshotScanner.next(SnapshotScanner.java:163) ~[phoenix-core-server-5.3.0-SNAPSHOT.jar:5.3.0-SNAPSHOT]
	at org.apache.phoenix.iterate.ScanningResultIterator.next(ScanningResultIterator.java:204) ~[phoenix-core-client-5.3.0-SNAPSHOT.jar:5.3.0-SNAPSHOT]
	at org.apache.phoenix.iterate.TableSnapshotResultIterator.next(TableSnapshotResultIterator.java:179) ~[phoenix-core-server-5.3.0-SNAPSHOT.jar:5.3.0-SNAPSHOT]
	at org.apache.phoenix.iterate.LookAheadResultIterator$1.advance(LookAheadResultIterator.java:55) ~[phoenix-core-client-5.3.0-SNAPSHOT.jar:5.3.0-SNAPSHOT]
	at org.apache.phoenix.iterate.LookAheadResultIterator.next(LookAheadResultIterator.java:75) ~[phoenix-core-client-5.3.0-SNAPSHOT.jar:5.3.0-SNAPSHOT]
	at org.apache.phoenix.jdbc.PhoenixResultSet.next(PhoenixResultSet.java:884) ~[phoenix-core-client-5.3.0-SNAPSHOT.jar:?]
	at org.apache.phoenix.mapreduce.PhoenixRecordReader.nextKeyValue(PhoenixRecordReader.java:185) ~[phoenix-core-server-5.3.0-SNAPSHOT.jar:5.3.0-SNAPSHOT]
	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.nextKeyValue(MapTask.java:569) ~[hadoop-mapreduce-client-core-3.2.4.jar:?]
	at org.apache.hadoop.mapreduce.task.MapContextImpl.nextKeyValue(MapContextImpl.java:80) ~[hadoop-mapreduce-client-core-3.2.4.jar:?]
	at org.apache.hadoop.mapreduce.lib.map.WrappedMapper$Context.nextKeyValue(WrappedMapper.java:91) ~[hadoop-mapreduce-client-core-3.2.4.jar:?]
	at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:145) ~[hadoop-mapreduce-client-core-3.2.4.jar:?]
...
...

@virajjasani I have reverted the change for TableSnapshotResultIterator which was causing the test failure due to same optimization of closing early being applied by ScanningResultIterator (which is used outside of MR based snapshot jobs) as well. Fixing it across both iterators isn't feasible without more extensive refactor so parking that.
Disabling mslab should be sufficient to fix the snapshot issue.


Can Storage Bus Cache be applied to an existing storage pool?

I came to this page looking for info on how to use Storage Bus Cache with an existing storage pool, to add caching.
I did not find the answer, nor did I find out if that is possible or not.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 38dc8bb9-ed5d-935c-2509-21871bed0749
Version Independent ID: a17de18e-0ed2-68c1-5729-d76f493dbfea
Content: Storage bus cache on Storage Spaces
Content Source: WindowsServerDocs/storage/storage-spaces/storage-spaces-storage-bus-cache.md
Product: windows-server
Technology: storage-spaces
GitHub Login: @TinaWu-Msft
Microsoft Alias: tinawu

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


#842 case insensitive search

closes #842

found this in the docs under operators. Let me know if this is a good way to do this
https://sequelize.org/v3/docs/querying/

Looks good to me! That operator only works on postgres, and our integration tests run on SQLite, but i haven't written tests for name changes, so it's a problem for another day.
Thanks!


Ship the examples/profiles

Rework examples and profiles so that they are shipped with the helm chart so the recommendations match the chart version.

Found out that all files shipped in the package are also uploaded to k8s in the release secret, bloating it. Therefore, only the profiles should be included, but no documentation/examples. This needs to be reworked a bit. marking as draft for now.

@kfox1111 Please clean up this PR, or decide it's time to retire it.  It's been in draft status for three weeks.
Personally, I think shipping the examples in some manner is a good idea, but that "some manner" might just be a "user manual / howto guide".  Without such a guide, it seems like concrete examples are only going to be useful to those who already understand our environment / approach.

Its on my todo list. We've been getting lots of other pr's updated/merged, and this one hasn't been the highest priority in the last few days. Its marked as Draft to deal with the fact it bitrotted a bit. Please give it a little time to make it back to the top of the pile. it should be soon at this rate.
Thanks for the reviews. I appreciate it.

Its only been in draft status for a week due to https://github.com/spiffe/helm-charts/pull/246#issuecomment-1540814092

Its only been in draft status for a week due to #246 (comment)

Ok.  I guess I imagined it was in draft status from the beginning.    The reason I'm mentioning this one is more because I have a goal of reviewing all the PRs with an eye to get the number down to 15.  Yes, that was 20 just a week ago, but that's the idea, fewer PRs in the pipeline (sometimes) helps efficiency.
I'm ok with a little waiting.

This needs such a thorough reworking I think I'm just going to close this one for now and restart in a new pr.


swapped out ember-try directive for ember-release scenario because of v6 bug

Refs https://github.com/ilios/ember-simple-charts/commit/c9ef3e414739691ffc464db4db80a1dc624be03d
Started seeing the same issue as the scenarios in the referenced commit for ember-release, so followed suit for it, too.

Still getting the same error. Any ideas @jrjohnson ?


Fixed fav icon href

i'm ok if their in there @hazmeister :P you dont need to close, i'm just wondering.  i'll reread to see if it's correct

Some extra commits snuck in on this branch, so I started a new branch and raised #103 instead.


[WIP][SPARK-14629][SPARK-14630][Build] Add support for custom scala style rules & Add rule PublicAbstractMethodsHaveTypeChecker

What changes were proposed in this pull request?

[ ] automatically build and install custom rules
[x] added a custom rule PublicAbstractMethodsHaveTypeChecker implementation, which would ensure public abstract methods have explicit return types

How was this patch tested?
the list of changes-to-make found by this PublicAbstractMethodsHaveTypeChecker rule is here: https://github.com/apache/spark/pull/12389/files

Test build #55821 has started for PR 12396 at commit fb54cde.

Test build #55821 has finished for PR 12396 at commit fb54cde.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55821/
Test FAILed.

Merged build finished. Test FAILed.

Test build #55823 has started for PR 12396 at commit 460efd3.

As per Scalastyle - Custom rules, I installed the jar on my local machine, and verified that the added rule works.
Now I'm not sure how to pre-install the jar for every Spark build on Jenkins's machine -- should some build scripts be modified? @rxin could you give some hints? Thank you!

Test build #55823 has finished for PR 12396 at commit 460efd3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55823/
Test FAILed.

hi @vanzin
I'm not sure how to build and pre-install some jar for every Spark build on Jenkins's machine -- should some build scripts be modified? Could you give some hints when you have time? Thanks! :-)
(with some custom being built and pre-installed, we then can enable custom code style checks, please see http://www.scalastyle.org/custom-rules.html)

we can push this into scalastyle and then upgrade the version.

@lw-lin I don't know either, but that sounds like too much work for style rules. I suggest following Reynold's advice and posting a PR to the scalastyle project; they're a little slow to update things, though.

I see; will follow @rxin 's advise. So I'm closing this.
@rxin @vanzin @srowen thank you all for the comments! :-)


Minecraft v1.20.6 Commands dont work

Describe the bug
The 'Waypoint' command does not work, and produces an server error log.
Havent used the plugin prior to this and didnt have previously existing beacons to test other commands, but seen the videos and read the instructions so I know that this is the very first step / command that needs to be executed.
To Reproduce
Steps to reproduce the behavior:

Load into world
Place Beacon and stand on it
Enter command /waypoint <name> <public | private>
See error in Server log

Expected behavior
Create a new waypoint
Desktop (please complete the following information):

OS: Windows
Minecraft Version: Java Edition v1.20.6

Additional context
I assume this is simply because its out of date after Minecraft was updated from previously supported version 1.20.4 -> 1.20.6

The log says the plugin is disabled, so it might have had an error when initializing. Do you have more info/logs from when it starts up? And have you tried using version 1.7?


Add support for open-webui provider

Is your feature request related to a problem? Please describe.
I've got a local Ollama install and have also installed Open-WebUI as a front end for it.  I was able to get the VS Code extension named Continue to access my Open-WebUI by configuring it as provider openai and specifying my apiBase as http://open-webui.k3s.mydomain.com/ollama/v1 so I tried this with ha-llmvision as a custom-openai provier but it could not connect.
Describe the solution you'd like
I'd like either the custom openai option to work or even more clearly open-webui to be listed as a config option
Additional context
I see from some other issues that you're in the process of rewriting the connection logic for other uses of custom openai, so this might be solved along with those, I just wanted to open this issue to make Open-WebUI an explicit goal.

OpenWebUI is not a provider itself. As you mentioned it is a frontend for Ollama. You can use Ollama as provider directly. See the instructions in the docs to set up Ollama as provider: https://llm-vision.gitbook.io/getting-started/self-hosted-providers#ollama

That's what I thought at first too, but it seems there's more to it than that.  In open webui you can define models with added knowledge bases and tool support, so there is considerable value in going through the front end, also webui can issue APi keys whereas Ollama itself has no authentication.  The Continue vs code extension connects via the OpenAPI interface that open webui provides for ollama.

I see. I'll take a look at it. Thanks for suggesting this!


chore(codegen): allow using maven local for to test Smithy changes

Description of changes

Add the local maven to the list of repositories that allows to test changes to Smithy libraries, without this the build fails with something like:
FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':tests:benchmarks:serde-benchmarks'.
> Could not resolve all files for configuration ':tests:benchmarks:serde-benchmarks:classpath'.
   > Could not find software.amazon.smithy:smithy-cli:1.27.0-SNAPSHOT.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/software/amazon/smithy/smithy-cli/1.27.0-SNAPSHOT/maven-metadata.xml
       - https://repo.maven.apache.org/maven2/software/amazon/smithy/smithy-cli/1.27.0-SNAPSHOT/smithy-cli-1.27.0-SNAPSHOT.pom
       - https://plugins.gradle.org/m2/software/amazon/smithy/smithy-cli/1.27.0-SNAPSHOT/maven-metadata.xml
       - https://plugins.gradle.org/m2/software/amazon/smithy/smithy-cli/1.27.0-SNAPSHOT/smithy-cli-1.27.0-SNAPSHOT.pom
       - https://dl.google.com/dl/android/maven2/software/amazon/smithy/smithy-cli/1.27.0-SNAPSHOT/maven-metadata.xml
       - https://dl.google.com/dl/android/maven2/software/amazon/smithy/smithy-cli/1.27.0-SNAPSHOT/smithy-cli-1.27.0-SNAPSHOT.pom
     Required by:
         project :tests:benchmarks:serde-benchmarks

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Add the local maven to the list of repositories that allows to test changes to Smithy libraries

Your changes affect plugins only, not (library) dependency resolution.
The changes are fine but can you clarify what are you trying to do? Test plugin changes? Test library changes? Every project already depends on mavenCentral.

Add the local maven to the list of repositories that allows to test changes to Smithy libraries

Your changes affect plugins only, not (library) dependency resolution.
The changes are fine but can you clarify what are you trying to do? Test plugin changes? Test library changes? Every project already depends on mavenCentral.

I'm trying to test changes to Smithy itself, without this some of the tests that depend transitively on smithy-cli fail with the error shown in the description, adding mavenLocal to pluginManagement -> repositories, solves the issue.


Book Store website

Book Store
Tech stack used - HTML CSS JS

Hey, I would like to work on this issue, can you please assign this to me?

@Hexman07 issue is already assigned to @aytida0606. You can make a new issue for yourself if you want to contribute to the repo :)


Unfilled polygon support

It should be possible to create an open and closed line loop. Filled polygons can be added in a separate issue.

Should this also replace the current Triangle primitive?

Yeah probably, although it might be worth keeping a thin Triangle wrapper so it's not removed from the crate's API (one less breaking change - yay!), and as a convenience method for those wanting a simple graphics API.
When filled polygons are a thing, I think they'll be drawn with filled triangles anyway, so there'll be a lot of overlap there.
What would the polygon API look like? Something simple like this:
impl Polygon {
    fn new(points: &[Point]) -> Self {
        // ...
    }
}

This would require points to live for as long as the Polygon does which is fine, just a departure from the other primitives. Images also take references so it's not so bad. We could use const generics here I think, but that requires nightly which is unfortunate. Tracking issue: rust-lang/rust#44580.

Const generics would be useful in some places but it doesn't seem they will be stable soon. But using a slice for the points is OK.
How would this API handle open vs. closed polygons?

How would this API handle open vs. closed polygons?

Maybe with a method on Polygon?:
let points = [Point::new(1, 2), Point::new(3, 4), Point::new(5, 6), Point::new(7, 8)];

let poly = new Polygon(&points).closed(true);
let poly = new Polygon(&points).closed(false);

Did you write any C++ recently? :smile:
But regardless of the syntax this would be an option. Another option would be to have two constructors:
let poly = Polygon::new_closed(&points);
let poly = Polygon::new_open(&points);

Or to different structs, like in SVG:
let poly = Polygon::new(&points);
let poly = Polyline::new(&points);

Did you write any C++ recently?

Worse! 😬 Javascript! 🤢 😂

Or to different structs, like in SVG:

That makes a lot of sense to me, particularly as Polyline wouldn't support a fill, but Polygon would. Let's go with that.


[FancyZones] feature to create zone layouts spanning multiple monitors

Summary of the Pull Request
This PR adds an option to FZ to run it in Multi-monitor mode. In this mode, you can create/use layouts which span all active monitors.
Known issues:

Using this mode with monitors with different DPIs could result in some glitches.
Changing the DPI when using a canvas (custom) layout also resizes that layout, until it's applied again in the editor. However, this doesn't even work right in single-monitor mode, so 🤷

PR Checklist

[x] Applies to #480
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[x] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
A new FZ settings switch, code which handles this use case.
Validation Steps Performed
Tested some basic functionality of FZ when using two 1440p monitors at 100% scaling.
If you're testing, also please ensure that everything works as usual with the option turned off.

Updating layout does not re-arange zoned windows into new positions. Probably we're missing implementation in  FancyZones::UpdateWindowsPositions().

Feature works only if monitors have same scaling. Is that what was intended? It would make more sense to work if monitors have same (resolution x scaling)

@stefansjfw

Feature works nicely only if monitors have same scaling. Is that what was intended?

Yes, it's impossible to guarantee this to work with different scaling. We will eventually force to not run if the DPI is different.

@vldmr11080

Updating layout does not re-arange zoned windows into new positions.

Shouldn't block the PR, we want a first implementation to provide the feature to the users. We will fix that type of issue later, also based on the community feedback.

Regarding the use of NULL for the monitor handle, it's fine, maybe not ideal but good enough for now.

Updating layout does not re-arange zoned windows into new positions. Probably we're missing implementation in FancyZones::UpdateWindowsPositions().

@vldmr11080
Thanks for finding this, I've fixed it with this commit.


TypeScript Typings

Hi there
I found some TypeScript typings really useful :)

I'd even do a PR, I already have written a tying for it

Sorry, what you mean by TypeScript Typings.

A d.t.s file which represents what methods are available. Something like this (not tested!):
interface NavigoHooks {
    before?: ((done: () => void) => void);
    after?: () => void;
}
type Route = string | RegExp;

declare class Navigo {

    /**
     * Constructs the router
     * @param root The main URL of your application.
     * @param useHash If useHash set to true then the router uses an old routing approach with hash in the URL. Navigo anyways falls back to this mode if there is no History API supported.
     */
    constructor(root?: string, useHash?: boolean);

    on(location: Route, handler: (...parameters: string[]) => void): Navigo;
    on(routes: { [key: string]: (...parameters: string[]) => void }): Navigo;
    on(handler: (...parameters: string[]) => void): Navigo;
    notFound(handler: ((query: string) => void)): void;
    navigate(path: string, absolute?: boolean): void;
    updatePageLinks(): void;
    generate(path: string, params?: any): string;
    resolve(currentURL?: string): void;

    link(path: string): string;

    disableIfAPINotAvailable(): void;

    pause(): void;
    resume(): void;

    destroy(): void;
}
export = Navigo;
export as namespace Navigo;

Another example: https://github.com/moment/moment/blob/develop/moment.d.ts
For all those using TypeScript, this is really useful :)

An one has to add an entry to package.json: https://github.com/moment/moment/blob/develop/package.json#L27

@aersamkull could you add this please to DefinetelyTyped aka @types?

I'm closing this one. Please prepare a PR.


Soft delete gives 404 now, instead of a 403.

The 403 error no longer represents a group that's been soft deleted. We throw a 404 error instead. It was 403 some time ago, but engineering has decided to change to a 404.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 22c9b1f8-635e-cbc2-6927-9f2d7767bbc6
Version Independent ID: c2abc72f-0007-1ed1-803e-ce85f7e87d4f
Content: Restore a deleted Office 365 Group
Content Source: Office365-Admin/create-groups/restore-deleted-group.md
Service: o365-administration
GitHub Login: @dianef77
Microsoft Alias: dianef

@AndreaBarr - This issue can be closed.


python310Packages.motionblinds: 0.6.16 -> 0.6.17

Changelog: https://github.com/starkillerOG/motion-blinds/releases/tag/0.6.17
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 217212 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.motion_blinds
python310Packages.motionblinds
python311Packages.motionblinds


warning on react 15.2.0

With react 15.2.0 version we have got the new warning:
Warning: Unknown prop componentIsLeaving on  tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
in div (created by HeadlessModal)
in div (created by ModalBackground)

Happy to take a PR like https://github.com/qimingweng/react-modal-dialog/pull/21


Kafka - offset at server start

We've seen a number of instances where we have a 'split cohort' scenario, ie multiple servers in a cohort have joined that cohort, and are subscribed to the omrs topic, but are not aware of each other. If a new server is added or removed, the re-configuration messages cause the cohort to be resynced and each server is then aware of the other members.
Kafka typically manages offsets on behalf of an application by consumer group. By default each of our servers use their own consumer group which is generated randomly at restart, though this can be overriden via properties to facilitate HA use cases. This means that when a server restarts no offset is stored
When a consumer subscribes to a topic it will normally pick up the offset previously stored for that group id. However no offset is stored in this case as it's a new consumer group, so kafka makes use of a property 'auto.offset.reset'. Our kafka topic connector does not specify 'auto.offset.reset', and the default value for this is latest. (unless overriden in properties)
See explanation: https://docs.confluent.io/current/clients/consumer.html
The consequence of this is that by default egeria will only pick up new messages when a server is started, and won't see anything prior to that time. This makes startup ordering crucial, and a little more fragile.
that being said, to a large extent egeria will generally 'catch up' as events occur within the cohort -- so it's actually the lack of cohort membership that is a worst-case.
We need to (re)consider how we make use of consumer groups and auto offset reset.

Starting from the beginning would allow catchup, but we could have a massive amount of stored messages to catch up with
In development use cases replaying old messages could cause confusion (ie from prior tests)
Starting 'a little bit back' is very inprecise - how far would we go to (we could use seek() )

One option is to leave as-is. If a particular use case requires different behaviour, they can specify the required consumer group, and also are able to override auto.reset.offset. In this case documenting the behaviour may be appropriate
This is likely the root cause of #2119 and also led to the suggestion of #2475 whilst likely cause had previously been assigned to #1876 and it's prior related issues
Opening for discussion and explanation.
cc: @mandy-chessell @cmgrote @grahamwallis @danielaotelea

Given that we're keen to keep this agnostic to the underlying event bus (ie. not Kafka-specific) it's probably worth considering what we might expect the default behaviour for other back-ends to exhibit...  Would they be more likely to behave in the "pickup all events, from the beginning, when I subscribe" way, or in the way it behaves now ("pickup only any new events that arrive after I've subscribed")?

@cmgrote - Good point about maintaining portability.
General comment: From looking at the code yesterday I am under the impression that when we create the consumer we actually assign the consumer group id to be the serverId. If that is genuinely random (from Nigel's comment above) then it seems that perhaps we should not use it, because it would prevent recognition that a restarted server is the same server as was previously running. The ideal would be for a server with a known name (e.g. 'cocoMDS2') to be recognisable on restart; so if the topic consumer were created in a consumer group for 'cocoMDS2' it could pick up where it left off prior to being shutdown - i.e. it would pick up the first message after the last committed message it previously consumed. Is that the behaviour we would like? If so using a random group seems odd, if indeed serverId is random.
Separate comment: I don't think we should leave this as is - it is confusing and unreliable. A cohort heartbeat may alleviate the problem, but I would like to understand why the current cohort registration processing is not sufficient. If on restart a server (re-)joins a cohort, it should send out a cohort registration; which should be sufficient for the existing cohort members to spot the new member and to reciprocate with their registration details. We seem to be missing that registration trigger, but it's not clear why that's the case.

The localServerId used as the consumer group id comes from the server configuration document.  Each time a server is started, it continues in the same consumer group.  It is only if the configuration document is recreated on each start up that there is a change in consumer group because effectively this is a new server.
A server that has joined a cohort keeps information about the other members of the cohort in its cohort registry file.  This is used on restart as the initial list of remote members.  It means that even if registration messages are missed, it will start with the same list of remote members as were in the cohort when the server went down.  The cohort registry file should only be deleted if the server is being destroyed.  If it is deleted between server restarts then the server is completley reliant on receiving the registration requests via the cohort topic.

Thanks for the clarification. This helps explain why I see the issue regularly, since for testing k8s deployments, or indeed running/testinc code locally I start off clean every time - no config, and hence a different consumer group.
This is quite unlike a production environment with a more stable configuration

What is the proposed next step on this one?

In my view we just need to ensure the current behaviour is adequately documented, both in the detailed docs for the kafka topic connector, but also ensure it is linked to from any info we have more generally that talks about the event bus/cohorts.
We could add a note in the understanding cohorts notebook.
We should add notes in our API def that (ie instance create) would result in launching a new topic listener to clarify the behaviour - though we don't have API docs to hook off currently.
When we write up anything about HA we should add it.
I've not reviewed the current docs in sufficient detail to consider exactly where.
I don't see the need for any code changes, other than the separate issue we still have open for the heartbeat

@wbittles I'm wondering if it makes sense to combine this with your fixes for our kafka topic connector as your insight will result in better docs around how exactly egeria behaves with kafka - both normally and in error conditions, of which the above is a small note?

@planetf1 I wouldn't hold up that fix for the extra documentation, however it makes perfect sense to provide that documentation as part of the new kafka connector

Given our recent changes to perform some retry during bringup, and that in terms of getting messages the concern is only where a new server is added it will only get messages from that point (which seems entirely reasonable and obvious) it's difficult to see what specific action is to be taken for this issue. It was originally noticed since we didn't have retry and create the cluster clean every time, but in a real world scenario messages will be picked up once servers are configured - which is the normal case
More general architecture info may be useful but at this point I think closing this issue is the correct action.
Please reopen with reasoning if you disagree


Problems with AdultSwim

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.06.05. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x ] I've verified and I assure that I'm running youtube-dl 2017.06.05

Before submitting an issue make sure you have:

[x ] At least skimmed through README and most notably FAQ and BUGS sections
[ x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ x] Bug report (encountered problems with youtube-dl)
[x ] Site support request (request for adding support for a new site)
[x ] Feature request (request for a new functionality)
[ ] Question
[x ] Other

So attempting to fetch from Adult Swim does not work. (Big surprise). Here's what I found when I tried, and some thoughts/ideas -- and, a feature request that comes out of this.
keybounceMBP:AdultSwim michael$ ./yt-dl -v http://www.adultswim.com/videos/dragon-ball-z-kai/stunning-youngsters-no-18s-uphill-battle/
[debug] System config: []
[debug] User config: ['-k', '-o', '%(title)s-%(timestamp)6i.%(ext)s', '-f', '\nbest[ext=mp4][height>431][height<=576]/\nbestvideo[ext=mp4][height=480]+bestaudio[ext=m4a]/\nbest[ext=mp4][height>340][height<=431]/\nbestvideo[ext=mp4][height>360][height<=576]+bestaudio/\nbest[height>340][height<=576]/\nbestvideo[height>360][height<=576]+bestaudio/\nbestvideo[height=360]+bestaudio/\nbest[ext=mp4][height>=280][height<=360]/\nbest[height<=576]/\nworst', '--ap-mso', 'Dish', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', '--write-sub', '--write-auto-sub', '--sub-lang', 'en,enUS,en-us', '--sub-format', 'ass/srt/best', '--convert-subs', 'ass', '--embed-subs', '--recode-video', 'mp4', '--mark-watched', '--download-archive', 'downloaded-videos.txt']
[debug] Custom config: []
[debug] Command-line args: ['-o', '%(series)s/s%(season_number)02d-e%(episode_number)02d-%(title)s.%(ext)s', '-v', 'http://www.adultswim.com/videos/dragon-ball-z-kai/stunning-youngsters-no-18s-uphill-battle/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.06.05
[debug] Python version 3.6.1 - Darwin-13.4.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.2.4, ffprobe 3.2.4, rtmpdump 2.4
[debug] Proxy map: {}
[AdultSwim] stunning-youngsters-no-18s-uphill-battle: Downloading webpage
[AdultSwim] yg6tkv1KS3yUltXY4HS5zA: Downloading XML
[AdultSwim] 1400176: Retrieving Media Token
[AdultSwim] 1400176: Downloading XML
[AdultSwim] 1400176: Downloading m3u8 information
[AdultSwim] 1400176: Downloading m3u8 information
[debug] Invoking downloader on 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6_vod.m3u8'
[download] Destination: Dragon Ball Z Kai/s01-e118-Dragon Ball Z Kai - DBZ Kai 118.mp4
[debug] ffmpeg command line: ffmpeg -y -loglevel verbose -seekable 0 -headers 'User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20150101 Firefox/47.0 (Chrome)
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Encoding: gzip, deflate
Accept-Language: en-us,en;q=0.5
Cookie: hdnea2=expires=1496864785~access=/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/*~md5=6166f27139b0a703f8fd454c80cf48de
' -i http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6_vod.m3u8 -c copy -f mp4 'file:Dragon Ball Z Kai/s01-e118-Dragon Ball Z Kai - DBZ Kai 118.mp4.part'
ffmpeg version 3.2.4 Copyright (c) 2000-2017 the FFmpeg developers
  built with Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn)
  configuration: --prefix=/opt/local --enable-swscale --enable-avfilter --enable-avresample --enable-libmp3lame --enable-libvorbis --enable-libopus --enable-libtheora --enable-libschroedinger --enable-libopenjpeg --enable-libmodplug --enable-libvpx --enable-libsoxr --enable-libspeex --enable-libass --enable-libbluray --enable-lzma --enable-gnutls --enable-fontconfig --enable-libfreetype --enable-libfribidi --disable-libxcb --disable-libxcb-shm --disable-libxcb-xfixes --disable-indev=jack --disable-outdev=xv --enable-audiotoolbox --enable-sdl2 --mandir=/opt/local/share/man --enable-shared --enable-pthreads --cc=/usr/bin/clang --enable-vda --enable-videotoolbox --arch=x86_64 --enable-yasm --enable-libx265 --enable-gpl --enable-postproc --enable-libx264 --enable-libxvid
  libavutil      55. 34.101 / 55. 34.101
  libavcodec     57. 64.101 / 57. 64.101
  libavformat    57. 56.101 / 57. 56.101
  libavdevice    57.  1.100 / 57.  1.100
  libavfilter     6. 65.100 /  6. 65.100
  libavresample   3.  1.  0 /  3.  1.  0
  libswscale      4.  2.100 /  4.  2.100
  libswresample   2.  3.100 /  2.  3.100
  libpostproc    54.  1.100 / 54.  1.100
[hls,applehttp @ 0x7fcc42000000] HLS request for url 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6/8996_Period1/segment0.ts', offset 0, playlist 0
[h264 @ 0x7fcc4200d000] Reinit context to 848x480, pix_fmt: yuv420p
Input #0, hls,applehttp, from 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6_vod.m3u8':
  Duration: 00:21:45.98, start: 0.750000, bitrate: 0 kb/s
  Program 0
    Metadata:
      variant_bitrate : 0
    Stream #0:0: Video: h264 (Constrained Baseline), 1 reference frame ([27][0][0][0] / 0x001B), yuv420p(tv, left), 848x480, Closed Captions, 29.97 fps, 29.97 tbr, 90k tbn, 59.94 tbc
    Metadata:
      variant_bitrate : 0
    Stream #0:1: Audio: aac (HE-AAC) ([15][0][0][0] / 0x000F), 44100 Hz, stereo, fltp
    Metadata:
      variant_bitrate : 0
Output #0, mp4, to 'file:Dragon Ball Z Kai/s01-e118-Dragon Ball Z Kai - DBZ Kai 118.mp4.part':
  Metadata:
    encoder         : Lavf57.56.101
    Stream #0:0: Video: h264 (Constrained Baseline), 1 reference frame ([33][0][0][0] / 0x0021), yuv420p(tv, left), 848x480 (0x0), q=2-31, 29.97 fps, 29.97 tbr, 90k tbn, 90k tbc
    Metadata:
      variant_bitrate : 0
    Stream #0:1: Audio: aac (HE-AAC) ([64][0][0][0] / 0x0040), 44100 Hz, stereo
    Metadata:
      variant_bitrate : 0
Stream mapping:
  Stream #0:0 -> #0:0 (copy)
  Stream #0:1 -> #0:1 (copy)
Press [q] to stop, [?] for help
Automatically inserted bitstream filter 'aac_adtstoasc'; args=''
[hls,applehttp @ 0x7fcc42000000] HLS request for url 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6/8996_Period1/segment1.ts', offset 0, playlist 0
[hls,applehttp @ 0x7fcc42000000] HLS request for url 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6/8996_Period1/segment2.ts', offset 0, playlist 0
[hls,applehttp @ 0x7fcc42000000] HLS request for url 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6/8996_Period1/segment3.ts', offset 0, playlist 0
[hls,applehttp @ 0x7fcc42000000] HLS request for url 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6/8996_Period1/segment4.ts', offset 0, playlist 0
[hls,applehttp @ 0x7fcc42000000] HLS request for url 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6/8996_Period1/segment5.ts', offset 0, playlist 0
[hls,applehttp @ 0x7fcc42000000] HLS request for url 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6/8996_Period1/segment6.ts', offset 0, playlist 0
[hls,applehttp @ 0x7fcc42000000] HLS request for url 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6/8996_Period1/segment7.ts', offset 0, playlist 0
[hls,applehttp @ 0x7fcc42000000] HLS request for url 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6/8996_Period1/segment8.ts', offset 0, playlist 0
[hls,applehttp @ 0x7fcc42000000] HLS request for url 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6/8996_Period1/segment9.ts', offset 0, playlist 0
[hls,applehttp @ 0x7fcc42000000] HLS request for url 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6/8996_Period1/segment10.ts', offset 0, playlist 0
[hls,applehttp @ 0x7fcc42000000] HLS request for url 'http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6/8996_Period1/segment11.ts', offset 0, playlist 0
^C^C[crypto @ 0x7fcc43012fa0] Unable to open resource: http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6/8996_Period1/segment11.ts
av_interleaved_write_frame(): Immediate exit requested
Error writing trailer of file:Dragon Ball Z Kai/s01-e118-Dragon Ball Z Kai - DBZ Kai 118.mp4.part: Immediate exit requestedframe= 3296 fps=163 q=-1.0 Lsize=   25239kB time=00:01:50.01 bitrate=1879.4kbits/s speed=5.43x
video:24448kB audio:877kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: unknown
Input file #0 (http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6_vod.m3u8):
  Input stream #0:0 (video): 3296 packets read (25034783 bytes);
  Input stream #0:1 (audio): 2370 packets read (897579 bytes);
  Total: 5666 packets (25932362 bytes) demuxed
Output file #0 (file:Dragon Ball Z Kai/s01-e118-Dragon Ball Z Kai - DBZ Kai 118.mp4.part):
  Output stream #0:0 (video): 3296 packets muxed (25034783 bytes);
  Output stream #0:1 (audio): 2370 packets muxed (897579 bytes);
  Total: 5666 packets (25932362 bytes) muxed

ERROR: Interrupted by user
Exiting normally, received signal 2.
keybounceMBP:AdultSwim michael$

Now, the things to note:
First, it works for a while, and then fails.
Second, a big difference between this and watching in a browser: This is downloading much faster than watching in a browser.
Third, I decided to try to play around. I read up on the docs for ffmpeg, and found, among other things, both "seekable" and "-re".
Seekable is interesting -- you specify seekable of 0, so every time ffmpeg starts up, it has to start from the beginning. It never has a chance to say "lets resume from where we left off", which would allow the file to eventually complete.
-re is an ffmpeg option for, essentially, "real time" downloading -- instead of trying to fetch the file as fast as possible, about 8 times faster than watching speed, fetch at watching speed. Now, this will make things slow, but it will make things look like watching in a browser.
Fourth, and the feature request: I decided to try to plop that ffmpeg command line into a file, and try executing it. This was step 1 to trying to play around with the command line options.
What happened?
keybounceMBP:AdultSwim michael$ ./test
+ ffmpeg -y -loglevel verbose -seekable -1 -headers 'User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20150101 Firefox/47.0 (Chrome)
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Encoding: gzip, deflate
Accept-Language: en-us,en;q=0.5
Cookie: hdnea2=expires=1496864785~access=/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/*~md5=6166f27139b0a703f8fd454c80cf48de
' -i http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6_vod.m3u8 -c copy -f mp4 'file:Dragon Ball Z Kai/s01-e118-Dragon Ball Z Kai - DBZ Kai 118.mp4.part'
ffmpeg version 3.2.4 Copyright (c) 2000-2017 the FFmpeg developers
  built with Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn)
  configuration: --prefix=/opt/local --enable-swscale --enable-avfilter --enable-avresample --enable-libmp3lame --enable-libvorbis --enable-libopus --enable-libtheora --enable-libschroedinger --enable-libopenjpeg --enable-libmodplug --enable-libvpx --enable-libsoxr --enable-libspeex --enable-libass --enable-libbluray --enable-lzma --enable-gnutls --enable-fontconfig --enable-libfreetype --enable-libfribidi --disable-libxcb --disable-libxcb-shm --disable-libxcb-xfixes --disable-indev=jack --disable-outdev=xv --enable-audiotoolbox --enable-sdl2 --mandir=/opt/local/share/man --enable-shared --enable-pthreads --cc=/usr/bin/clang --enable-vda --enable-videotoolbox --arch=x86_64 --enable-yasm --enable-libx265 --enable-gpl --enable-postproc --enable-libx264 --enable-libxvid
  libavutil      55. 34.101 / 55. 34.101
  libavcodec     57. 64.101 / 57. 64.101
  libavformat    57. 56.101 / 57. 56.101
  libavdevice    57.  1.100 / 57.  1.100
  libavfilter     6. 65.100 /  6. 65.100
  libavresample   3.  1.  0 /  3.  1.  0
  libswscale      4.  2.100 /  4.  2.100
  libswresample   2.  3.100 /  2.  3.100
  libpostproc    54.  1.100 / 54.  1.100
[http @ 0x7fa112d2a4e0] HTTP error 403 Forbidden
http://androidhls-secure.cdn.turner.com/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/ASOE1004271700075224_Layer6_vod.m3u8: Server returned 403 Forbidden (access denied)
keybounceMBP:AdultSwim michael$

So what happened? It looks like this --
Cookie: hdnea2=expires=1496864785~access=/adultswim/big/secure/tve/2017-05/ASOE1004271700075224_HLS/*~md5=6166f27139b0a703f8fd454c80cf48de

is a one-use cookie. Since you pass it to ffmpeg, and ffmpeg fails, I cannot reuse it.
So a feature request: Prepare an ffmpeg command, but instead of executing it, either output it, or put it into a file, so that the user can play around / alter it to test things out.

Dish MSO is not supported.
As per request: everything needed for ffmpeg command construction is in --dump-json.

dump-json? Thank you, now to figure out how to use that.
Re: Dish MSO: Pull request #12000 works wonders and is ready for merging.


exception on loading : An item with the same key has already been added.

Hello
Got some issue with the next file:
optax_price_xiaomi_obnov_1707 (2).xlsx
any way how to "try catch" such an error and to read this file till the end?

which version of NPOI are you using?

I used 2.5.6

but I tested with 2.6.1
it has the same Error

Can you share the code to reproduce the issue?

Can you share the code to reproduce the issue?

A simple loading file will raise the exception.
const string path = @"d:\whatever\optax_price_xiaomi_obnov_1707.2.xlsx";
var wb = new XSSFWorkbook(path);

As for the file, there're duplicated entries in xl/drawings/_rels/drawing1.xml.rels referencing the same file.
<Relationship Id="rId4" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/image" Target="../media/image4.jpeg"/>
...
<Relationship Id="rId91" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/image" Target="../media/image4.jpeg"/>

I think it's because of image reuse (i.e. copy & paste inside Excel).
I tried to implement a quick fix in NPOI.OpenXml4Net.Core/OPC/PackageRelationshipCollection.cs and found no side effects so far. Maybe someone, who is more familar with OOXML, can explain if anything different is gonna happen.
        if (targetMode == TargetMode.Internal)
        {
            var uriOriginalString = targetUri.OriginalString;

            if (!internalRelationshipsByTargetName.ContainsKey(uriOriginalString))
            {
                internalRelationshipsByTargetName.Add(uriOriginalString, rel);
            }
        }

This file I get for a supplier via loading from a website url.
I cannot open it and resave if in Microsoft Office as you suggested.
From my point of view is a bug because I can open this file in Microsoft Office and there is no any exception
but when I open file via c# code using NPOI it calls exception, so it is a bug.

I suppose that NPOI should have a policy on whether to fix issues relating to malformed but Excel-readable files.

Fair enough. I'll fix this issue and see if we can suppress the exception without breaking anything

wow, many thanks! you are the best!


Solution does not support Live Unit Testing in Visual Studio Enterprise

This is only for developer comfort, not an issue using the SDK itself.
I did try to reproduce this behavior on a clean project, but it seems very specific to the Dapr .NET SDK solution.
Expected Behavior
When enabling Live Unit Testing in Visual Studio Enterprise, it should work.
Actual Behavior
Fails with the message

[15:40:32.665 Error] System.IO.FileNotFoundException: Could not find file 'D:\github\eNeRGy164\dapr\dotnet-sdk.vs\all.sln\v16\lut\7304\i\Dapr.Client\netcoreapp3.1\dapr\proto\common\v1\CommonGrpc.cs'.

A normal build generates an empty CommonGrpc.cs, but a LUT build apparently does not.
I'm not sure if this is a Visual Studio LUT or a Grpc.Tools bug. Or maybe just the combination of both.
A workaround is to generate the empty file if it is a LUT build.
After this LUT works:

Steps to Reproduce the Problem
Press play in a Visual Studio Enterprise.
Release Note

RELEASE NOTE:
FIX Support Live Unit Testing in Visual Studio Enterprise.

@jamesnk - are you familiar with this problem?

No. I don’t have live unit tests enabled

Can you try it on an empty grpc project? I don't have Windows/VS easily available. If there's a bug here its in Grpc.Tools - we're not doing anything fancy in this repo.

I couldn't reproduce it on an empty solution, even using the Dapr proto files, including shared files and targets.


Files are way too big on disk

Describe the bug
I believe 1.6.0 RC1 caused this issue. I cannot verify it as downgrading is impossible. OrbStack complains about some configs being version 2 instead of 3, and keeps prompting me to upgrade.
In the screenshot below, "msr-data" is the directory mounted into the Postgres container's /var/lib/postgresql/data. I then stream files into this database, and the size quickly baloons and fills my entire SSD. It's making working on this project impossible, and I cannot downgrade.

To Reproduce

Init a Postgres database
Stream data into Postgres database
File size might be a few hundred megabytes while size on disk is many gigabytes.

Expected behavior
Same or at least similar size of files.
Diagnostic report (REQUIRED)
OrbStack info:
Version: 1.6.0-rc1
Commit: 932a523a3e455516178ac5c35f345965de2138de (v1.6.0-rc1)
System info:
macOS: 14.4.1 (23E224)
CPU: arm64, 11 cores
CPU model: Apple M3 Pro
Model: Mac15,6
Memory: 36 GiB
Full report: https://orbstack.dev/_admin/diag/orbstack-diagreport_2024-05-14T08-18-42.565842Z.zip

Screenshots and additional context (optional)
No response

I can confirm it does not happen with Docker Desktop.

I believe 1.6.0 RC1 caused this issue. I cannot verify it as downgrading is impossible. OrbStack complains about some configs being version 2 instead of 3, and keeps prompting me to upgrade.

This is due to an incompatible upgrade in 1.6.0 but you can work around it without losing data by editing ~/.orbstack/vmstate.json and changing the version from 3 to 2.

Thank you very much for the swift response, I appreciate it a lot. This worked and I'm back on version 1.5.1. The file size issue does not happen on version 1.5.1.

Fixed for the next canary.

That's great, thank you. If you don't mind elaborating, what caused this issue? It was a curious bug.

That's great, thank you. If you don't mind elaborating, what caused this issue? It was a curious bug.

Misunderstanding of some differences between the Linux and macOS APIs for allocating file sizes.

Released in v1.6.0.
New: Truly fast container filesystems on macOS: 2–10x faster, within 75-95% of native


Moving LMS loadtest to the public repo.

Also, I had to add a second '-e' requirement to the base.txt for opaque-keys
since that repo's versions are not properly managed right now.
@e0d  @benpatterson @nedbat @jbarciauskas

I'll fix the PEP* violations when I have some free time but if one of you has bandwidth please feel free to push the fixes onto this branch.

:+1: pending pylint

I've fixed the violations, though, I had to ignore a rule to do so. The violation we're ignoring is:
lms/lms.py:13:1: E402 module level import not at top of file.
It's hacky to begin with, so I don't feel great about disabling it. However, I don't have time to ensure a change to the file will/will-not impact how locust is run, so I'm leaving it. Someone else can feel free to tackle that one or we can leave it as a TODO.

@benpatterson @nedbat second thumb?

Oh. :+1:


Automatically infer WinExe output type for WPF and Winforms applications

Automatically infer WinExe output type for WPF and Winforms applications
We are now automatically setting the OutputType to WinExe if the application is WPF or WindowsForms.  This will suppress any console windows that would start up if the OutputType was set to exe. https://github.com/dotnet/sdk/pull/12448
Version introduced
.NET 5 Preview 8
Old behavior
We would use the value set in the project.
New behavior
Default the OutputType value to WinExe
Reason for change
We assume most users do not want a console window coming up during execution of a WPF or WindowsForms and with these application types using the .NET sdk instead of the WindowsDesktop SDK, we wanted to ensure the right default was set.  Further, when add support for targeting iOS and Android in .NET Core, it will make it easier to multi-target between multiple platforms if they all use the same output type.
Recommended action
Set <DisableWinExeOutputInference>true</DisableWinExeOutputInference> in your project file to revert to the old behavior.

Issue metadata

Issue type: breaking-change

@marcpopMSFT I've updated the description with my suggestions, most importantly by fixing a typo from not to now.

Ahhh .... this explains the bug I am having.
(and which an other user has too: https://developercommunity.visualstudio.com/content/problem/1176945/console-app-broken-when-using-usewindowsforms-in-n.html)

@marcpopMSFT Was this change intended to apply to projects that target .NET Framework as well? See #21952.


Update README.md

Please do proper indentation.
Putting links in an improper way.
Suggestion:
Check the previous contribution on this repository.


Vertical position of the lightbox

@sanjinc lightbox is not centred vertically. Can you please help with this when you find time?
Thanks

@dejanstojanovic what should the desired look be? This screenshot is from 23" screen

I switched off comments to show you the issue


Apply content amends

Amend copy for the following areas of the application:

The invitation email
The log in screen
The set password screen(screen visited when accepting
the invite)
The search for a PER page(i.e the current home page)

This commit also improves the formatting of some of the
text in the i18n files.

Testing

Testing again..


[DOC-2126] restructure bulk ops page

Address DOC-2126:

Changed the bulk ops page to only include backups and restores
Moved import / export examples to their statement pages
Changed URL links to incorporate new page names

Preview:

Customer-Owned Backups
Managed-Service Backups
IMPORT
EXPORT

@ashleykwtam I haven't looked through the PR much just commenting here on the titling as requested!
We'll want to confirm the titling with Liv, but I think as placeholders so that the PR can be reviewed perhaps we want to go with something like the following:
Restore Data from a Backup --> Use Managed-Service Backups
My thinking for keeping this more generic with "Use" is that there will be more features in the Cloud Console shortly beyond just restoring a managed-service backup.
Run Bulk Operations --> Take and Restore Customer-Owned Backups
I'm not wholly convinced with "customer-owned" here, but since that is now the feature name, it probably makes sense to have it in the title.
Again, Liv will probably have more ideas here—though let's incorporate these ^ titles and change up the links and nav for so we can get a good view of what everything looks like.
Once you feel ready, you can tag me for an initial review, or let me know if you want me to take a look at anything else in draft view.

On this page https://deploy-preview-15808--cockroachdb-docs.netlify.app/docs/cockroachcloud/take-and-restore-customer-owned-backups.html
We describe Backup and Restore -- but only the basics. However, they can essentially support more functionality i.e. encrypted backups, scheduled backups, locality aware backups, etc.
I think it might make more sense to organize by FEature first and then by product type. @ashleykwtam @kathancox

@livlobo @ashleykwtam I think it is a good idea for us all to restructure the nav according to product type intersected with feature. However, I think we should discuss this in more depth (possible iterations) and Ashley merge this PR as a "first fix" and then we can iterate. The main reason is that the docs for v23.1 will be cut on Feb 7, anything we don't merge will have to be copied over... And that will make way more work on this PR. So, I'm going to open an issue, set it highest priority to be completed in the Feb sprint to rearrange according to what we decide. https://cockroachlabs.atlassian.net/browse/DOC-6675


[BEAM-1928] Add ReadTranslator

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify.
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

This translates Read transforms to ReadPayloads and back

R: @kennknowles

Coverage decreased (-0.03%) to 70.641% when pulling 7f35c98b5f77069bd21dc7dea4a7d046883d13a6 on tgroh:read_translator into b633abe2c8efd3ac607a0be14980315e5f0d9fa6 on apache:master.

retest this please

Looks like we hit job quota, but the actual new code and its unit tests passed. Again, this is just utility code that will be used to register a translator.

Coverage decreased (-0.03%) to 70.637% when pulling 7f35c98b5f77069bd21dc7dea4a7d046883d13a6 on tgroh:read_translator into b633abe2c8efd3ac607a0be14980315e5f0d9fa6 on apache:master.


Add support for more snippet languages

Should we rebase this?

@lorensr I'm happy to rebase this PR myself, if you'd like.  Though (as this PR was opened before GitHub turned it on by default for new PRs) I'd need you to check the "Allow edits from maintainers" checkbox, which should be over there ➡➡➡ somewhere.
(This thing:
)
😄

Oh, thanks! Sorry, I saw your comment last week, but had no idea it was my PR 😆 Totally forgot I did this

Thanks to toggling that for me, @lorensr!
Upon trying to rebase this, it has come to my attention that we've diverged from this method of defining out own syntax highlighting and Hexo now supports it natively.
I've added a syntax highlighting example to the example docs repository via https://github.com/meteor/theme-example/commit/06a4b7a70bc469dc26fe64384c1dcc7163954098, and it looks like the syntax highlighting options you added should work out of the box now, as long as they are one of the classes supported by Highlight.js.  Unfortunately, it looks like GraphQL still isn't quite supported, but should hopefully be supported soon.
The Apollo theme example, demonstrating the syntax highlighting working can be seen on this page!
I'll close this, but happy to reopen if you disagree.  Thanks for looking at this originally, even if it may have fell into the abyss.  (Sorry about that! We'll try not to let that happen again!)


error with .trk files

I have my .tck file and i convert it to .vtk and .trk for testing purposes with TractConverter (https://github.com/MarcCote/tractconverter). When i execute tract_querier with using as input the .vtk file, it works, but when i use as input the .trk file, i get the following error:
Loading files
Traceback (most recent call last):
File "/Users/glazar0/Library/Enthought/Canopy_64bit/User/bin/tract_querier", line 284, in
main()
File "/Users/glazar0/Library/Enthought/Canopy_64bit/User/bin/tract_querier", line 139, in main
options.tractography_file_name
File "/Users/glazar0/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/tract_querier/tractography/init.py", line 46, in tractography_from_file
return tractography_from_trackvis_file(filename)
File "/Users/glazar0/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/tract_querier/tractography/trackvis.py", line 78, in tractography_from_trackvis_file
tracts_and_data, header = trackvis.read(filename, points_space='rasmm')
File "/Users/glazar0/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/nibabel/trackvis.py", line 173, in read
_check_hdr_points_space(hdr, points_space)
File "/Users/glazar0/Library/Enthought/Canopy_64bit/User/lib/python2.7/site-packages/nibabel/trackvis.py", line 473, in _check_hdr_points_space
'field value %s' % (aff_zooms, zooms))
Using separately the nibabel.trackvis.read(), i can read the .trk file though. Any suggestions?

Yes it is a compatibility issue on the trackvis reader of Nibabel. The thing is that, in the current nibabel implementation, without the RASMM option you can read the data but not be sure of the space encoding of the tracts.
Maybe @MarcCote has an idea of how to force tractconverter to produce TRK files that are in RASMM space encoding.
--
Demian Wassermann, PhD
<EMAIL_ADDRESS>Research Scientist
Athena Project Team
INRIA Sophia Antipolis - Méditerranée
2004 route des lucioles - FR-06902

@gelazari you did specified the option -anat when converting from tck to trk?

Yes i did specify an anatomy to get the trk file and then i perform the tract_querier by using the same anatomy

fixed it. It was just a simple scripting mistake that had nothing to do with the integrity of the used programs.

:D


failed to cherry pick PR 2968 from weizhoublue, to branch release-v0.7

commits 0ac439b243994490a3bd12572303cc7218edbb5d of weizhoublue conflict when merging to branch release-v0.7, please manually cherry pick it by yourself.
PR https://github.com/spidernet-io/spiderpool/pull/2968 ,  action https://github.com/spidernet-io/spiderpool/actions/runs/7284052307
Auto-merging README-zh_CN.md
CONFLICT (content): Merge conflict in README-zh_CN.md
Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
Auto-merging docs/README-zh_CN.md
CONFLICT (content): Merge conflict in docs/README-zh_CN.md
Auto-merging docs/README.md
CONFLICT (content): Merge conflict in docs/README.md
error: could not apply 0ac439b2... Merge pull request #2968 from spidernet-io/pr/welan/ibo
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

The issue with release-0.7 is too old. If only a certain part of the PR is modified to release-0.7 through cherry pick, it will cause layout confusion. Therefore, this PR has no meaning for chrry pick.


Modernize pyjq build process, achieving Python 3.12 compatibility.

Merge this or explain it only supports up to 3.11.


[deliver] support metdata update of live_version

as discussed here: https://github.com/fastlane/fastlane/issues/7156
adds option edit_live - supports updating of:

:description, :release_notes, :support_url, :marketing_url
:privacy_url

enabling new languages is disabled, it actually works via itc api - but it fails later on - as :keywords are protected.
asset, pricetier,screenshots are forced to be disabled.
test with:
deliver -E
or from fastfile:
deliver(edit_live: true)

@JustinJiaDev awesome! thx - addressed your feedback.
any chance you can try the PR, and confirm it works on your machine/setup too?

If I have time I'll try it tonight.

@JustinJiaDev Did you get a chance to try it? Unfortunately I don't have a live app where I would want to try this out.

@milch I couldn't get this work. But it seems like the issue is not related to this patch.
+------------------------+-----------------------+
| Detected Values from './fastlane/Deliverfile'  |
+------------------------+-----------------------+
| app_review_information |                       |
| submission_information |                       |
| app_rating_config_path | fastlane/Ratings.json |
| app_icon               | fastlane/Icon.png     |
| price_tier             | 510                   |
| automatic_release      | true                  |
+------------------------+-----------------------+

[20:05:26]: Login to iTunes Connect (xxxxxxxxx)
[20:05:28]: Login successful

+--------------------------------------------------------------------+-----------------------------+
|                                      deliver 1.16.1 Summary                                      |
+--------------------------------------------------------------------+-----------------------------+
| edit_live                                                          | true                        |
| app_review_information.first_name                                  | xxxxxxxxx                      |
| app_review_information.last_name                                   | xxxxxxxxx                         |
| app_review_information.phone_number                                | xxxxxxxxx           |
| app_review_information.email_address                               | xxxxxxxxx |
| submission_information.export_compliance_uses_encryption           | false                       |
| submission_information.export_compliance_encryption_updated        | false                       |
| submission_information.content_rights_contains_third_party_content | false                       |
| submission_information.add_id_info_uses_idfa                       | false                       |
| app_rating_config_path                                             | fastlane/Ratings.json       |
| app_icon                                                           | fastlane/Icon.png           |
| price_tier                                                         | 510                         |
| automatic_release                                                  | true                        |
| screenshots_path                                                   | ./fastlane/screenshots      |
| metadata_path                                                      | ./fastlane/metadata         |
| username                                                           | xxxxxxxxx        |
| app_identifier                                                     | xxxxxxxxx... |
| platform                                                           | ios                         |
| skip_binary_upload                                                 | false                       |
| skip_screenshots                                                   | false                       |
| skip_metadata                                                      | false                       |
| force                                                              | false                       |
| submit_for_review                                                  | false                       |
| dev_portal_team_id                                                 | xxxxxxxxx                  |
| overwrite_screenshots                                              | false                       |
+--------------------------------------------------------------------+-----------------------------+

[20:05:29]: Loading './fastlane/metadata/en-US/description.txt'...
[20:05:29]: Loading './fastlane/metadata/en-US/keywords.txt'...
[20:05:29]: Loading './fastlane/metadata/en-US/release_notes.txt'...
[20:05:29]: Loading './fastlane/metadata/en-US/support_url.txt'...
[20:05:29]: Loading './fastlane/metadata/en-US/marketing_url.txt'...
[20:05:29]: Loading './fastlane/metadata/en-US/name.txt'...
[20:05:29]: Loading './fastlane/metadata/en-US/privacy_url.txt'...
[20:05:29]: Loading './fastlane/metadata/copyright.txt'...
[20:05:29]: Loading './fastlane/metadata/primary_category.txt'...
[20:05:29]: Loading './fastlane/metadata/secondary_category.txt'...
[20:05:29]: Loading './fastlane/metadata/primary_first_sub_category.txt'...
[20:05:29]: Loading './fastlane/metadata/primary_second_sub_category.txt'...
[20:05:29]: Loading './fastlane/metadata/secondary_first_sub_category.txt'...
[20:05:29]: Loading './fastlane/metadata/secondary_second_sub_category.txt'...
[20:05:29]: Verifying the upload via the HTML file can be disabled by either adding
[20:05:29]: `force true` to your Deliverfile or using `deliver --force`
Does the Preview on path './Preview.html' look okay for you? (y/n)
y
[20:05:32]: HTML file confirmed...
[20:05:35]: Uploading metadata to iTunes Connect

Looking for related GitHub issues on fastlane/fastlane...

Found no similar issues. To create a new issue, please visit:
https://github.com/fastlane/fastlane/issues/new
Run `fastlane env` to append the fastlane environment to your issue

[!] The request could not be completed because:
	You can't select the stickers category unless your app is made exclusively for iMessage. You can't select the stickers category unless your app is made exclusively for iMessage.

But I'm testing with an iMessage only app.

@milch @hjanuschka Actually, my app's description was successfully updated, although it gave me the weird error. I guess my issue is not related to the PR. This PR works as expected!

@hjanuschka Thanks for your contribution! 🚀
Since users reported this as working, and it's a new feature that shouldn't affect any existing users I'll merge it.

Shouldn't edit_live be default off?

@pedro380085 it should be off by default! - can you share your fastfile?

#!/bin/env ruby
# encoding: utf-8

# Global Information
username "{{email}}"
app_identifier "{{namespace}}"
force true

# Release notes
release_notes({ "{{language}}" => "{{defaultRelease}}" })

# Version Release
automatic_release true
submit_for_review true

# Additional Information
submission_information({
    add_id_info_uses_idfa: false,
    export_compliance_uses_encryption: false,
    export_compliance_encryption_updated: false
})

# Skip files
skip_binary_upload true
skip_screenshots   true

If I add edit_live false, it works without a problem.

@pedro380085 that's your Deliverfile, do you also have a Fastfile? Also, did you set the environment variable?

fastlane_version "1.30.0"

before_all do
    # Setup all environment
    ENV["FASTLANE_USER"] = "{{email}}"
    ENV["DELIVER_USER"] = "{{email}}"
    ENV["DELIVER_PASSWORD"] = "{{password}}"

    ENV["DELIVER_APP_IDENTIFIER"] = "{{namespace}}"

    ENV["DELIVER_BETA_FEEDBACK_EMAIL"] =<EMAIL_ADDRESS>    ENV["DELIVER_WHAT_TO_TEST"] = "Adição de novas features"
    ENV["DELIVER_BETA_DESCRIPTION"] = "Aplicativo de testes - versão para aprovação"
    ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"] = "-t DAV"

    ENV["FASTLANE_SKIP_UPDATE_CHECK"] = "true"

    # cocoapods
    # increment_build_number
    # ipa
    # xctool
end

desc "Submits to review"
lane :review do
    deliver
end

Yes, here it is @KrauseFx. Which environment variable do you refer to? Since fastlane has so many 😹

Solved here: https://github.com/fastlane/fastlane/pull/7684

Um, I just got this after updating fastlane and running fastlane appstore which uses deliver action:
[16:40:25]: Loading './fastlane/metadata/en-US/description.txt'...
[16:40:25]: Loading './fastlane/metadata/en-US/keywords.txt'...
[16:40:25]: Loading './fastlane/metadata/en-US/release_notes.txt'...
[16:40:25]: Loading './fastlane/metadata/en-US/support_url.txt'...
[16:40:25]: Loading './fastlane/metadata/en-US/marketing_url.txt'...
[16:40:25]: Loading './fastlane/metadata/en-US/name.txt'...
[16:40:25]: Loading './fastlane/metadata/en-US/privacy_url.txt'...
[16:40:25]: Loading './fastlane/metadata/copyright.txt'...
[16:40:25]: Loading './fastlane/metadata/primary_category.txt'...
[16:40:25]: Loading './fastlane/metadata/secondary_category.txt'...
[16:40:25]: Loading './fastlane/metadata/primary_first_sub_category.txt'...
[16:40:25]: Loading './fastlane/metadata/primary_second_sub_category.txt'...
[16:40:25]: Loading './fastlane/metadata/secondary_first_sub_category.txt'...
[16:40:25]: Loading './fastlane/metadata/secondary_second_sub_category.txt'...
[16:40:25]: To not be asked about this value, you can specify it using 'edit_live'
Modify live metadata, this option disables ipa upload and screenshot upload:

Not sure what I'm supposed to write there? Am I modifying live medatada? What medatada? More detailed description would be helpful.

@tomaskraina It has been fixed on 2.4.0, make sure you have this version fastlane -v

Updated to 2.4.0 and all is good. Thanks.

Yeah, great to hear 👍


fix: incorrect column pruning in sql with window operations

Which issue does this PR close?

Closes #6001 .
Rationale for this change

What changes are included in this PR?

If the node that window's child has outputs not in referenced inputs, then add a projection
Are these changes tested?

Are there any user-facing changes?

@jackwener Thanks for your suggestion. I modified the variable naming, but I don't understand the modification here   https://github.com/apache/arrow-datafusion/pull/6039#discussion_r1170046496 as it results in a clone LogicalPlan instead of a pointer, I expect to know your thoughts.

@jackwener Thanks for your suggestion. I modified the variable naming, but I don't understand the modification here #6039 (comment) as it results in a clone LogicalPlan instead of a pointer, I expect to know your thoughts.

Oh, It's my fault, I don't notice it. Thank you. @yukkit


Table output for bundle outdated

Currently bundler displays outdated info one line per gem, with no consistent spacing / alignment for each item of information. Having used yarn a while, I have grown fond of the table format it uses to declare outdated gems, and would like to see something similar for bundle:

while I won't make the argument the colours are super useful here (imo they are a bit confusing), the table format seems more legible than the text blob that bundler outputs by default. Would there be any interest in a patch that adds a new output format?

I would like to work on this!

We'd welcome a PR that improves the bundle outdated UI. I don't think there is much more to add to this issue, so i'm closing it.


Improving JUnit HTML Report

Hey @ptrthomas.
I found this issue listed in the "Challenge 2018" sheet and would like to try contributing to this. Being a beginner to Java, the Karate repository seems quite huge to self-read from. If you don't mind, can you please refer me to what'd be the 'important" files/snippets to change?

@athityakumar sure. you should be able to do this by changing one single file, this one: https://github.com/intuit/karate/blob/master/karate-core/src/main/java/com/intuit/karate/cucumber/KarateHtmlReporter.java
It uses a home-grown approach to emit HTML, which actually uses the Karate XML support behind the scenes. The reason for this is to reduce the library "footprint" of Karate.
I hope you were able to build the project from the command-line at least ref #304 - then all you need to do is run any of the tests from the command line and keep tweaking.

@ptrthomas - Yes, I've been able to build the project from command line. I'm currently working on the tweaking part. I am able to consider 2 ways of doing this task of sidebar + collapsible accordions:

Purely Java and org.w3c.dom Nodes : Inserting more XML nodes with repetitive data / color-codes, and saving it all into the HTML file.
Javascript: Using Javascript to generate the sidebar on-the-fly (while viewing the HTML files), from the existing XML node set. In fact, collapsible accordions would have to be done with Javascript for "interactivity".

IMO, it'd also be DRYier to implement (2) rather than (1). But I just wanted to know your opinion before proceeding further. 😄

@athityakumar (2) is A-OK :) if you want to use a lib - to start with you can use a CDN like this example (JQuery here, but feel free to pick whatever works for you) https://github.com/intuit/karate/blob/develop/karate-demo/src/test/java/mock/web/cats.html
does that help ?

Thanks for assigning this issue to me, @ptrthomas. 😄
I definitely considered using a CDN like JQuery, but making a request to JQuery each time while opening the report seemed a bit unnecessary to me - especially when the functionality could be delivered by a few more lines of CSS & JS. So, I've opened PR #316 (WIP) that adds support to the left sidebar for navigating across different test cases. Next, I'll try to get "accordion"-like view for the raw logs, so that they can be disclosed when required.
Please have a look at the above PR when you're free and let me know if any changes (regarding color, ordering of data, etc.) are required in the sidebar part.

@athityakumar

especially when the functionality could be delivered by a few more lines of CSS & JS
couldn't agree more !

so you will see my commit that has just gone in, I think these should be self explanatory:
https://github.com/intuit/karate/blob/19d2b7d44042dd085daecfd18815bd4b40f569b1/karate-core/src/main/resources/report-template.html
https://github.com/intuit/karate/blob/19d2b7d44042dd085daecfd18815bd4b40f569b1/karate-core/src/main/resources/report-template.js
This is great, please proceed.

Thanks a lot for refactoring the CSS & JS codes into separate files - Yes, they were quite self-explanatory and much more easier to write too!
I've submitted PR #317 to handle the accordion-view of raw logs. Please review when you're free. 😄


Link issue on https://opencollective.com/open-web-docs

The link points at https://github.com/openwebdoc instead of https://github.com/openwebdocs (plural).

Thanks, I made it point to https://github.com/openwebdocs/project which seems most useful right now. (website coming soon).