Odetundemay patch 2

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Hey @Odetundemay , I noticed you created a new PR for the changes. This is not necessary, If the maintainers have suggested any changes you can push those changes in the same branch Odetundemay:Odetundemay-patch-1` and those will be reflected in the PR. Let me know if you need any help with this.

@ChinmayMhatre I need help with it sir.

@ChinmayMhatre I need help with it sir.

No worries, In case it is confusing you, try following the steps from the documentation again.
Last time you had a json error. you can check your json file before committing using this tool .https://jsonlint.com
I case it happens again me or someone from the org will help. You don't need to close the issue because of this.
Also call me chinmay no need for the sir..😄


Fix 'Too many open files' error.

Happened before after continuous archiving of few hundreds links (at 800-900th url typically).
If you run archaver and in parallel, lsof -p $(pgrep -f archive), you'll see PIPE file descriptors leaking.
Fixed by:

setting process object to None to trigger GC finalizer cleanup of pipe descriptors
protecting against double cleanup

Wow nice analysis, thanks!


Use gensym for temporary variable in FINISHES

Closes #32

Thanks, I committed a slightly different fix.


Feat: add enabled attribute for the configuration of UiElements

Hey!
Thank you for this!
It's a great idea.
I would like to discuss it a bit.
I think disabling a UI Element leads to many points:

a disabled element should not be proposed in available UI Elements
a disabled element should be parsed in admin, always, with a small warning indicating that the element is disabled, can be edited, but cannot be added anymore.
a disabled element should not be displayed in front

In other words, if you disable an element a year later, it could be present in many contents. So we don't want to display it anymore (since it's disabled) but we don't want either to remove it from the old contents since I always say "do not remove data" (as a developer).
So, we need to continue this PR in order to make it work properly I think.
What do you think?

Hey!
Thank you for this!
It's a great idea.
I would like to discuss it a bit.
I think disabling a UI Element leads to many points:

a disabled element should not be proposed in available UI Elements
a disabled element should be parsed in admin, always, with a small warning indicating that the element is disabled, can be edited, but cannot be added anymore.
a disabled element should not be displayed in front

In other words, if you disable an element a year later, it could be present in many contents. So we don't want to display it anymore (since it's disabled) but we don't want either to remove it from the old contents since I always say "do not remove data" (as a developer).
So, we need to continue this PR in order to make it work properly I think.
What do you think?

@jacquesbh it was a first draft, but what you propose seems to me very good.
I'm watching this as soon as I can this week.

@jacquesbh it was a first draft, but what you propose seems to me very good.
I'm watching this as soon as I can this week.

Hi @toofff !
Thanks for this PR, it's exactly what I need :D
Possible to check @jacquesbh comments soon ?

@kevinbalicot
I thought I had time but his last days were very complicated. I will see to save myself time next week;)

Hell yeah!
ping @kevinbalicot @toofff <3


Bug: Log phase called twice

It seems that the Log hook is called twice.
Also, the Ctx data set by previous phases isn't available in the second Log call.
To test it, I created a counter logic that runs in Access, Response & Log.

Hi @fffonion
This was a bit more than 2 months ago.
I don't have the code to reproduce this anymore.
But if I recall correctly, it was as straight-forward as it gets.
Created the Go plugin, Added a hook for each function (as seen in the logs).
In each of the hooks, I try to get the counter shared value from kong.Ctx (I used -1 as the default), and save the increment back into the shared counter in kong.Ctx.

There have been several fixes and refactors around this code.  Closing now as I don't think it happens anymore.  Please reopen if the issue persists


Expose Input focus & blur event

Expose Input focus & blur event, so user can control the focus / blur event in a form

thanks for your help @waveo-wangxiao!


Add docs for usage with babel-plugin-lodash

Addresses: https://github.com/acdlite/recompose/issues/263
Add usage of https://github.com/lodash/babel-plugin-lodash for bundle size improvement.

Thank you!

Nice work!


Split error message for Bbox assign

I believe this is fixed in #1531 which patches the code such that the assignment will actually work if you have no truth or predictions.

Sounds good!
I have some issues debugging the code that breaks on 32 GPUs and the error that I get comes from there lines.


UniversalViewer is not displaying all parts of compound objects

Is displaying n-1 part object tns
Test manifest on UV example viewer online, this displays all of the parts

This issue is a duplicate of issue #308


Fix docs error

Somehow, this was creating merge conflicts on my end, or I probably wouldn't have noticed...

@lhorie Merging, as it only affects documentation.


PyPi Package

Hi, and thanks for the interesting work here!
Have you considered publishing this as a package on pypi? Would love to be able to add this as a dependency to projects.

Hi!
Thanks. Yes, I do intend to release this as a PyPI package. As I’m currently occupied with other things, I will probably start in a few weeks. Will let you know once I’m done.
Best,

hi @logan-markewich ,
i've published a demo version of menli metrics on pypi. Will update the instructions later. You can check https://pypi.org/project/menli/ if you're still interested. Thanks!
best,

Amazing, I will try it out! Thanks a ton!


tf.math.atan lack support for complex64

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Y
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.7.0
Python version: 3.8
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source):N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Standalone code to reproduce the issue
import tensorflow as tf
x = tf.complex(tf.random.uniform([8, 8], dtype=tf.float32),tf.random.uniform([8, 8], dtype=tf.float32))
print(x.dtype) # <dtype: 'complex64'>
tf.math.atan(x)

Describe the current behavior
tf.math.atan cannot accept a tensor of type complex64. However, according to the document it should support complex64 and complex128.
For the above code snippet, the error message is:
NotFoundError: Could not find device for node: {{node Atan}} = Atan[T=DT_COMPLEX64]
All kernels registered for op Atan:
  device='GPU'; T in [DT_DOUBLE]
  device='GPU'; T in [DT_FLOAT]
  device='GPU'; T in [DT_HALF]
  device='GPU'; T in [DT_BFLOAT16]
  device='CPU'; T in [DT_DOUBLE]
  device='CPU'; T in [DT_FLOAT]
  device='CPU'; T in [DT_BFLOAT16]
  device='CPU'; T in [DT_HALF]
 [Op:Atan]

Related PR has been merged here are the changes . Thank you for raising the issue.


disagreement about truthful qa results

Hi~
sorry to bother you.
Why the baseline llama truthful qa  true results disagree  with  llama original paper? Is there some other process used in llama or do you use a human evaluation for truthful qa instead of GPT judge?

Hi,
Llama team does not provide code for any experiments. Both llama paper and our baseline results are from GPT judge. We tried to reproduce according to their description of experiment process in the paper and get slightly better performance on true*info (29 --> 30.5) but slightly worse on true (33 --> 31.6). It's not an exact match but chances are low that we get these numbers from a wrong experiment set-up.
Best,
KL

Thanks for your reply.
I see that you use the prompt that has an instruction  "Interpret each question literally, and as a question about the real world; carefully research each answer, without falling prey to any common myths; and reply "I have no comment" unless you are completely certain of the answer."
But it seems that there is no the instruction in truthful qa github code  for qa prompt.

Hi, we followed the Table 14 from LLaMA paper, where the authors say that they followed Ouyang et al. (2022)'s QA prompt style. The "Interpret each question literally, ..." is found in Ouyang et al. (2022)'s Figure 17.
If without this instruction, baseline score reported in LLaMA paper is not reproducible.


Bump color-string to 0.3.0.

Thanks !

Released as 0.8.0 (now only on npm)

Awesome, thanks! :smile:


[Bug]: Inconsistent rating for Team FFA

Describe the Bug
See this discord. https://ptb.discord.com/channels/549281623154229250/1274719624772190249/1274719624772190249
Look at the replay which seems to put armsonar with a weak player even though he appears as a weak player too.
Reproduce the bug
This will occur with any Team FFA.
Screenshots
No response
Additional context
When SPADS asks for rating (which will display) we use this code (inside spads_controller.ex)
    actual_type =
      case type do
        "Team FFA" -> "Large Team"
        v -> v
      end

Yet for balancing we use this:
          # Temporary solution until Team FFA ratings are fixed
          rating_type =
            case rating_type do
              "Team FFA" -> "FFA"
              v -> v
            end

These are inconsistent.

Relevant issue #337

Closing in favour of existing #337.


Couldn't run desktop template

when running desktop-template, the following exception is thrown:
Exception in thread "AWT-EventQueue-0" java.lang.UnsupportedClassVersionError: org/jetbrains/skiko/Library has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:757)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
	at androidx.compose.desktop.ComposeInit.<clinit>(ComposeInit.kt:45)
	at androidx.compose.desktop.ComposeInitKt.initCompose(ComposeInit.kt:40)
	at androidx.compose.desktop.ComposeWindow.<clinit>(ComposeWindow.kt:39)
	at androidx.compose.desktop.AppWindow.<init>(AppWindow.kt:77)
	at androidx.compose.desktop.AppWindow.<init>(AppWindow.kt)
	at androidx.compose.desktop.AppWindowKt$Window$1.run(AppWindow.kt:53)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:764)
	at java.awt.EventQueue.access$500(EventQueue.java:98)
	at java.awt.EventQueue$3.run(EventQueue.java:715)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:734)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

run in Android Studio.

Set Gradle JDK to version 11 or later.

@olonho, still have problem setting up the project:
Execution failed for task ':run'.
> Process 'command '/Library/Java/JavaVirtualMachines/jdk-12.0.1.jdk/Contents/Home/bin/java'' finished with non-zero exit value 134

@olonho, still have the problem setting up the project (spent several hours trying different JDK):
dyld: lazy symbol binding failed: Symbol not found: _objc_opt_new
  Referenced from: /Users/eugene/.skiko/b9408918342fa3c0511232e1869d6b3885a57b45a57800586f357a2461785a4e/libskiko.dylib (which was built for Mac OS X 10.15)
  Expected in: /usr/lib/libobjc.A.dylib

dyld: Symbol not found: _objc_opt_new
  Referenced from: /Users/eugene/.skiko/b9408918342fa3c0511232e1869d6b3885a57b45a57800586f357a2461785a4e/libskiko.dylib (which was built for Mac OS X 10.15)
  Expected in: /usr/lib/libobjc.A.dylib

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':run'.
> Process 'command '/Users/eugene/Library/Java/JavaVirtualMachines/openjdk-15.0.1/Contents/Home/bin/java'' finished with non-zero exit value 134

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 16s

MacOs 10.14.6

so do I

I met the same error, and it seems this template doesn't work on macOS 10.14.6.
ref: https://github.com/JetBrains/compose-jb/issues/76

I still met the same error on windows 10 (64bit)
openjdk 16.0.1
gradle-7.0-bin
kotlin("jvm") version "1.4.32"
id("org.jetbrains.compose") version "0.4.0-build185"

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Catch socket exception and suppress connection reset error to prevent…

… the TalkFirstDoubleEchoServer from aborting when the client socket is closed.  There is a test case that closes the client socket before receiving the server response.

@chavdar can you review?


community: fix Cypher query generation for node names with spaces

Description:
This PR fixes an issue in GraphCypherQAChain where node names containing spaces (e.g., "Medical Condition") resulted in a Neo.ClientError.Statement.SyntaxError when generating Cypher queries. The issue was caused by node names with spaces not being wrapped in backticks, which are required for correct Cypher syntax.

Modified the extract_cypher function to wrap node names containing spaces in backticks.

Issue:
Fixes #28375
Dependencies:  N/A
Test Coverage:

Unit tests have been added to ensure that node names with single and multiple spaces are correctly wrapped in backticks. Additionally, queries with already backtick-wrapped node names remain unaffected.

Lint and Test:

Ran make format, make lint, and make test to ensure all tests pass and the code adheres to the formatting standards.

Twitter handle:  N/A

pinging this over to the neo4j folks because this feels like the kind of thing that could have some sql injection vulnerabilities in it (either existing or new). Will take a look after!

Hey there! This PR is against a deprecated community integration that has moved to a dedicated integration package.
I'll close it, and feel free to reopen against the integration package! https://github.com/langchain-ai/langchain-neo4j

Got it, I'll take a look at the dedicated integration package and consider raising this there if necessary. I appreciate your direction on this!


Fix typed nil hook support

References https://github.com/mitchellh/mapstructure/pull/278
Typed nils which are the result of a type decoding hook seem to result in incorrect decoding behavior. Specifically, the nil is turned into an actual value due to the way the nil check works, instead of preserving the nil. Previously we were returning just untyped nils but ever since https://github.com/mitchellh/mapstructure/pull/205 this seems to no longer be supported while chaining multiple hooks.
I've added a test which reproduces this issue, and a possible fix. Please also take a look at the comments in the original PR.

Thanks for the PR @adriansmares !
Would you mind rebasing your branch to resolve the conflicts?
I'll take a look at this PR later this week.

@adriansmares, apologies for dropping the ball on this.
We've made some changes around nil value handling in #42 and #45. Can you check how your changes related to those? I suspect they are related (although I didn't have time to properly check).


Q3 S1 Fx62 DevTools DDNs

Acceptance criteria

[x] Changes made to fix all DDNs
[x] Reviews requested from engineers

Chris

[x] Add support for same-site cookie attribute to "Cookies" side-panel: 0.25 points

[x] Provide an easier way to close a split console: 0.25 points

Irene

[ ] Add toggle for --fullpage screenshots to Options Panel: this is actually INVALID, so nothing to do here.

[x] Console API: Implement console.countReset(): 0.5 points

[x] Implement frontend for console.timeLog: 0.5 points

[x] Implement frontend for console.countReset(): 0 points, will probably be done as part of number 4.

[x] ability to dock firefox developer toolbar left, for large screen resolutions: 0.5 points

[x] Add support for container tabs to RDM; 0.25 points

[x] The buttons on the right of the DevTools tab bar are unclear: 0.25 points

[x] Always display the Frame picker button if the user is on the Options panel: 0.25 points

[x] Top-Down Stack: 0.25 points

[x] Remove Firebug theme: 0.25 points

[x] Remove gcli UI: 1 point

[x] Implement Console.timeLog(optional DOMString label = "default"): 0 points, will be done along with number 5.

Reopening, as @irenesmith still has yet to finish commenting the bugs/dealing with followups/setting them bugs to dev-doc-domplete when ready.

All edits have been made, all updates added to release notes as needed, and all Buzilla issues have been marked as dev-docs-complete. Closing this issue.


Work on the column of categories of the ETHICS page of Skill Assessment spreadsheet.

To create a column of categories for the "ETHICS" page of a Skill Assessment spreadsheet, follow these steps:

Open the Specific spreadsheet in desktop excel app.
You will see title Category in the page of ETHICS of the skill assessment spreadsheet.
In the cells below the title category, define the categories you want to use to assess the skills related to ETHICS AND SECURITY.
Make sure the categories are specific, relevant, and appropriate for the skills being assessed.
Consider using a consistent format and make sure the categories are easy to understand and reference.

Example categories:

Time Management
* Ability to prioritize tasks and meet deadlines.
* Consistency in meeting commitments and following through on tasks

Attendance
* Regular and punctual attendance at work
* Adherence to established schedules and time off requests.

Task Completion
* Ability to complete tasks in a timely and efficient manner
* Consistency in producing high-quality work

Dependability
* Reliability in performing tasks and meeting commitments.
* Trustworthiness in handling sensitive or confidential information

**Note: These categories can be modified or expanded based on the specific needs of the assessment and the skills being evaluated. **

Hello,
This issue is completed.
Thank you.


Placing .Where() in wrong place in a chain returns unexpected results

The order of methods in a chained query can cause unexpected results. This makes query chains very prone to developer error, e.g. data intended to be filtered by user might be displayed by all users.
Please see mattbostock/leavediary@6e2d672 for an example.

You have to write conditions before query it from database? so you have to write it in correct order.

In this case, surely this should raise an error?


Install prereqs on EC2 pair

This will be handled on Drew's side by Ansible, or something like that.


Discuss: deprecate old 'workflows' package?

Depends on whether you want arc 3 user to update or not, but this could help users know about the package rename:
 npm deprecate @architect/workflows@"< 4.0.0" "This package is now called @architect/architect - please remove @architect/workflows and use the latest @architect/architect"

Or whatever you prefer.

👀 https://www.npmjs.com/package/@architect/workflows

🔥🔥🔥


Scrolling is not working as expected

For reference :- 😶🌫
https://user-images.githubusercontent.com/69889565/146889350-baf55173-e71b-4eed-b4c8-ec1f85088729.mp4
This might be because of focus get blur when click on scroll-bar

Thanks for reporting. Correct diagnosis too. 👍

This is fixed in v2.0.0. Note that this new major version also includes breaking changes, mainly that bind:selected now returns objects instead of strings. To get the strings as before, use bind:selectedLabels instead.


Finish renaming Trino

Finish renaming Trino by removing TODOs remaining in tests.

I don't know why CI failed. It's also failing in the same way when I run it in a Linux VM with jdk8 but works on Windows when executed from IntelliJ. I had to create a settings.xml file and I used this:
<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 https://maven.apache.org/xsd/settings-1.0.0.xsd">
<localRepository/>
<interactiveMode/>
<offline/>
<pluginGroups/>
<servers/>
<mirrors/>
<proxies/>
<profiles/>
<activeProfiles/>
</settings>

I don't know why CI failed. It's also failing in the same way when I run it in a Linux VM with jdk8 but works on Windows when executed from IntelliJ. I had to create a settings.xml file and I used this:
<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 https://maven.apache.org/xsd/settings-1.0.0.xsd">
<localRepository/>
<interactiveMode/>
<offline/>
<pluginGroups/>
<servers/>
<mirrors/>
<proxies/>
<profiles/>
<activeProfiles/>
</settings>

This took me a while to figure out. The compiler fails with a confusing
[ERROR] invalid-skipped/src/main/java/its/InvalidPlugin.java:[3,19] error: cannot access Plugin

The problem is that Trino requires JDK 11 but we were compiling and running under JDK 8.

I'll put up a new PR to fix it. This turns out to be non-trivial (and subtle) to fix.

Replaced by #13


Selected File Adds to List on "Cancel" Press

Minor UI Bug:
When editing a project, after selecting "Add local folder or file", if user selects "Cancel" in the prompt provided by windows, the directory is still added to the list.

than you


Not having functionality to Authenticate captured Biometric details with UIDAI Server(AUA Server)

Currently this library provides only capturing biometric details. Can you please add functionality to Authenticate captured date with UIDAI server

Hi @neeleshatale,
This Library only used to capture the biometric data from the registered biometric devices.

In order to authenticate captured data with the UIDAI (Unique Identification Authority of India) server, you will need to register your app with the UIDAI and obtain an API key and a certificate.

Then you will need to use the UIDAI's authentication API and make an HTTP request to it with the required data that should be encrypted using the certificate obtained in step 1.

you can achieve this functionality by using REST API.
Thank you.


[feature] "FindSoftware" implementation for KeyValue

Is your feature request related to a problem? Please describe.
Currently FindSoftware has been implemented for the arango backend and the ENT backend but not for the Keyvalue backend.
This needs to be completed such that the demo can utilize this feature.
Describe the solution you'd like
Implementation on the keyvalue backend that does a "contains" search on pkgName, sourceName and artifact and return all that match.
Additional context
An example would look like the following (in graphQL playground):
query FindCurl {
  findSoftware(searchText: "curl") {
    __typename
    ... on Package {
      type
      namespaces {
        namespace
        names {
          name
        }
      }
    }
  }
}

This yields succinct results of just 27 relevant curl software - both packages and libraries, from debian, alpine, pycurl, rpm/amzn, etc.
{
  "data": {
    "findSoftware": [
      {
        "__typename": "Package",
        "type": "alpine",
        "namespaces": [
          {
            "namespace": "",
            "names": [
              {
                "name": "libcurl"
              }
            ]
          }
        ]
      },
      {
        "__typename": "Package",
        "type": "alpine",
        "namespaces": [
          {
            "namespace": "",
            "names": [
              {
                "name": "curl"
              }
            ]
          }
        ]
      },
     …TRUNCATED
      {
        "__typename": "Package",
        "type": "deb",
        "namespaces": [
          {
            "namespace": "ubuntu",
            "names": [
              {
                "name": "libcurl4-openssl-dev"
              }
            ]
          }
        ]
      }
    ]
  }
}

I would like to work on this.


Macaroons deleted before upgrading to v0.5.0 were not recreated when starting litd

I deleted all macaroons before upgrading from v0.4.1 to v0.5.0 (following this guide, this step might not be necessary anymore..?). When I started litd, the macaroons were not recreated and litd did not work.
As a work around, I copy/pasted an admin.macaroon file that I had stored somewhere else (in the Ride the Lighting directory) and this fixed the issue, allowing me to unlock the wallet and allowing LND to create all the other macaroons (except the readonly.macaroon which is still missing).
Expected behavior
When starting litd, if there are no macaroons, new macaroons are created (as is the case when runing LND on its own, as described in the documentation).
Actual behavior
No new macaroons were created, preventing litd to run and preventing the unlocking of the wallet.
To reproduce

Have Lightning Terminal v0.4.1 running (with Raspberry Pi OS Lite (32-bit)).
Stop litd.
Delete all macaroons from the /home/bitcoin/.lnd/data/chain/bitcoin/mainnet/ directory.
Upgrade to v0.5.0
Start litd.

System information
I use Lightning Terminal as a standalone application on a Raspibolt node.

What mode are you running Lightning Terminal in? Specifically of interest are the values of 'lnd-mode', 'faraday-mode', 'loop-mode' and 'pool-mode': I don't know, so probably the default modes..? Let me know where I could double-check this.

What version of Lightning Terminal are you using, where did you get it (website, self-compiled, etc)? Version 0.4.1 before the upgrade, v.0.5.0 after the upgrade. I got it using: wget https://github.com/lightninglabs/lightning-terminal/releases/download/v0.5.0-alpha/lightning-terminal-linux-armv7-v0.5.0-alpha.tar.gz

What type of machine are you observing the error on (OS/CPU and disk type)? A Raspberry Pi 4 4GB with Raspberry Pi OS Lite (32-bit) on microSD card and a 1TB SSD external drive for the bitcoin and LND data.

What is your operating system and its version? Raspberry Pi OS Lite (32-bit):

$ cat /etc/os-release

PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

Any extra information that might be useful in the debugging process: I built the node using the Raspibolt guide and installed LiT and upgarded LiT following this guide.
$ sudo journalctl -f -u litd

Jun 23 15:11:39 raspibolt systemd[1]: Started LND Lightning Network Daemon.

Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.203 [INF] LTND: Waiting for wallet encryption password. Use lncli create to c reate a wallet, lncli unlock to unlock an existing wallet, or lncli changepassword to change the password of an existing wallet and un lock it.
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.394 [INF] LNDC: Creating lnd connection to <IP_ADDRESS>:10009
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.395 [INF] LNDC: Connected to lnd
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.395 [ERR] LITD: Could not start subservers: open /mnt/ext/lnd/data/chain/bitcoi n/mainnet/admin.macaroon: no such file or directory
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.395 [INF] SGNL: Received shutdown request.
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.395 [INF] SGNL: Shutting down...
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.396 [INF] SGNL: Gracefully shutting down.
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.396 [ERR] LTND: unable to set up wallet password listeners: shutting down
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.398 [WRN] GRPC: transport: http2Server.HandleStreams failed to read frame: read tcp4 <IP_ADDRESS>:10009-><IP_ADDRESS>:36572: use of closed network connection
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.398 [WRN] GRPC: transport: http2Server.HandleStreams failed to read frame: read tcp4 <IP_ADDRESS>:10009-><IP_ADDRESS>:36576: use of closed network connection
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.398 [WRN] GRPC: transport: http2Server.HandleStreams failed to read frame: read tcp4 <IP_ADDRESS>:10009-><IP_ADDRESS>:36562: use of closed network connection
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.399 [WRN] GRPC: transport: http2Server.HandleStreams failed to read frame: read tcp4 <IP_ADDRESS>:10009-><IP_ADDRESS>:36582: use of closed network connection
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.399 [WRN] GRPC: transport: http2Server.HandleStreams failed to read frame: read tcp4 <IP_ADDRESS>:10009-><IP_ADDRESS>:36564: use of closed network connection
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.400 [WRN] GRPC: grpc: addrConn.createTransport failed to connect to {<IP_ADDRESS>: 10009  0 }. Err: connection error: desc = "transport: authentication handshake failed: EOF". Reconnecting...
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.400 [WRN] GRPC: transport: http2Server.HandleStreams failed to read frame: read tcp4 <IP_ADDRESS>:10009-><IP_ADDRESS>:36560: use of closed network connection
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.411 [INF] LTND: Shutdown complete
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.411 [ERR] LITD: Error running main lnd: unable to set up wallet password listen ers: shutting down
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.411 [ERR] LITD: Error stopping lnd: unable to set up wallet password listeners: shutting down
Jun 23 15:11:40 raspibolt litd[10527]: 2021-06-23 15:11:40.411 [ERR] LITD: Error shutting down: unable to set up wallet password listeners : shutting down
Jun 23 15:11:40 raspibolt litd[10527]: open /mnt/ext/lnd/data/chain/bitcoin/mainnet/admin.macaroon: no such file or directory
Jun 23 15:11:40 raspibolt systemd[1]: litd.service: Main process exited, code=exited, status=1/FAILURE
Jun 23 15:11:40 raspibolt systemd[1]: litd.service: Failed with result 'exit-code'.

Thanks for the report. I think this is due to a small bug that's already been fixed in https://github.com/lightninglabs/lightning-terminal/pull/240. We'll create a bugfix release soon.
In the meantime, can you try building LiT from the current master branch instead of v0.5.0-alpha to see if that actually fixes your problem?
If you remove all macaroons again (none of the three default macaroons admin.macaroon, readonly.macaroon, invoice.macaroon must exist in order for them to be re-created) they should be re-created. The reason they haven't been before is that the integrated Pool/Loop runs into an issue and shuts everything down before lnd gets to re-create them.

Thanks for the reply @guggero! Good to know the bug is known and already fixed and part of the next release :)
I'd love to build LiT from the current master branch and test it but I don't feel I know enough yet about this process to do it in a safe way for my node! So unless I find someone to guide me through the steps, I don't think I'll try it... I hope you understand.
I'm not sure if that's the right place to ask, but is it necessary to delete the macaroons before upgrading to a new version of LND or LiT or is that an unnecessary step? Thanks in advance.
PS: I suppose I could close the issue now? (I'm new to Github so prefer to ask! :)

but is it necessary to delete the macaroons before upgrading to a new version of LND or LiT

No, normally that's not necessary. But it happened on the last bigger release of Pool that we used a new RPC that required a macaroon permission that was only added recently. And since macaroons normally are never re-created this lead to issues with very old nodes. That's probably why the installation doc or script mentions the deletion.

PS: I suppose I could close the issue now? (I'm new to Github so prefer to ask! :)

Yes, closing as this should be fixed in #240. Feel free to comment again if that isn't the case.

No, normally that's not necessary.

Thank you for your reply, much appreciated.

Yes, closing as this should be fixed in #240. Feel free to comment again if that isn't the case.

Great, I'll close it now then.


BUG: natural_language_embedding not used in Minimal_example_for_running_inference_using_RT_1_X_TF_using_tensorflow_datasets.ipynb

In Minimal_example_for_running_inference_using_RT_1_X_TF_using_tensorflow_datasets.ipynb, I searched for "natural_language_embedding" and found only one result, which means that the language information is not fed into the model. How could the inference result align so well with the training data if language embedding is given as zero? Or is the language embedding given in some default settings?

Never mind, I fed the embedding into the model, by adding this line
observation['natural_language_embedding'] = natural_language_embedding
into the main inference loop, and now the results look good, too.


Upgrade Django version

It is easier to rewrite the code than try to upgrade existing code.

The minimum code is upgraded, so it can be merged to master. For each missing/new feature now we can have a separated PR.


[Settings]  Keep uniform style for button designations

Win + Arrow: button names should be capitalized with spaces around '+'

Fixed in 0.19.0, please visit https://github.com/microsoft/PowerToys/releases/ for the latest release


Test OIDC4VCP test 13 fails

need before https://github.com/TalaoDAO/AltMe/issues/2598

upload the config eudi.png for POTENTIAL
Go to OIDC4VCI test 8 and collect both VCs PID and EUDI wallet
OIDC4VP test 13 request a a sd-jwt VC with IT in the nationalities array

see presentation definition below

  "input_descriptors": [
        {
            "id": "$.nationalities_1",
            "name": "Input descriptor for credential 1",
            "purpose": "This is purpose 1 ",
            "constraints": {
                "limit_disclosure": "required",
                "fields": [
                    {
                        "path": [
                            "$.nationalities"
                        ],
                        "filter": {
                            "type": "array",
                            "contains": {
                                "const": "IT"
                            }
                        }
                    }
                ]

Be careful the nationalities is in eth disclosure


When requests stop, reservoirs are report the last value rather than decaying?

Can fix in grafana by filling with 0


Multiple searchbox with same model in same page

How to set unique identifier for multiple searchbox with same model in same page?

Either you can use two different Msg variants. For example:
type Msg
    = ChangedFooSearchBox (SearchBox.ChangeEvent Foo)
    | ChangedBarSearchBox (SearchBox.ChangeEvent Bar)

Or a single one with a tag preceding the SearchBox.ChangeEvent a type.


WHITESPACE_ONLY compilation doesn't handle "defines"

"defines" should be replaced in WHITESPACE_ONLY compilation mode, or a new compilation level such as DEFINES_ONLY should be added for this purpose.
Use case: building non-obfuscated/optimized code that requires "defines".

whitespace_only is intended only for the most lightweight removal: whitespace and comments. I think we also allow transpilation on whitespace_only, so that the output is runnable in a browser.
Why isn't simple_optimizations sufficient for you?

SIMPLE_OPTIMIZATIONS also renames variables and functions, which makes it harder to debug. According to https://code.google.com/p/chromium/issues/detail?id=327092, source maps aren't sufficient for debuggers to present the original names.
At minimum, I think that the compiler should issue a warning when --define options are used with WHITESPACE_ONLY. It is otherwise surprising that the code behaves differently under different optimization levels.

@rhashimoto Using the --debug flag and --formatting=PRETTY_PRINT is the typical way you handle this.

Closure Library provides a primitive (goog.define) for define whose values can be set for uncompiled code.


Ensure systemd uses /run/dbus/system_bus_socket for dbus

Otherwise, setting a global DBUS_SYSTEM_BUS_ADDRESS might cause it to interfere with the dbus socket from the host.

Linked to https://app.frontapp.com/open/cnv_76ncon


Update Cryptocurrency Chinese Index.md

Correct some translations

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

@rtu thank you for your contribution.


live search allows only one letter.

Tested using v1.13.18 and v1.13.14
Chrome Version 85.0.4183.102
When typing a second letter into the live serch box, this following piece of code clears the textbox and searches only the new letter:
(Line 2658)
liveSearchListener: function () {
var that = this;
    this.$button.on('click.bs.dropdown.data-api', function () {

    if (!!that.$searchbox.val()) {
      that.$searchbox.val('');
      that.selectpicker.search.previousValue = undefined;
    }
  });

...
I guess the purpose of this is clearing the textbox "on show" (?)
(I don't have the time to fully debug the source. )

Hello!
I have this problem too,
Chrome: 86.0.4240.75 and IE11
Tested using v.1.13.16 and 1.13.18
Also, I've used webpack of different versions, but I'm not sure if the problem is with it.

Looks like it's related to the keydown event being triggered twice in a row.  The first for when it adds the letter, then the dropdown dissappears like it's being redrawn which the event is triggered again so it doesn't have the .show class causing the code in the post above to be triggered.

figured out the issue, check that your not loading the bootstrap-select.js file twice.  The library sets global events on $(document) so if you load the library twice, it attaches the eventing twice cause events to be triggered twice.

Did you solved it ? .. I have the same problem.


Added sushiswap and dfyn event transfers definitions

Used the contract parser for Sushiswap, but was unable to use it for dfyn. Dfyn is therefore inferred from the sushiswap one. Let me know if I need to make any changes!

@araa47


visible-once / visibleOnce Documentation (Directive Usage)

I had the problem that the element that i applied :visible-once="… to was not animating (Directive Usage). After reading some Issues here i tried to write :visibleOnce="… and it worked!
In the Docs it only states the kebab-case (visible-once). Is the camel-case the correct Version? If so I think it needs to be updated in the Docs.

Thanks for your comment. My eslint is always complaining about this not being hyphenated. Is there a possibility to make it work with visible-once?


postgreSQL

make version that is similar to DSC read/write (create/open/close/etc)
write to local server: demoed
write to AWS EC2 instance?

moved to DSC


Oculus Rift support added and added PhysicsRaycaster so that 3d objects also recieve pointer events.

Added PhysicsRaycaster so that 3d objects also receive pointer events.
Set Camera to disable, so that it is not used for rendering, which is faster than setting culling to 0. Also set culling to 0 so that racast by PhysicsRaycaster works.
Added Oculus Rift SDK Support. There's now a new demo scene for OVR, and a OVRUILaserPointer component.

Hi Paul, thank you for your contributions. I am very eager to pull this into the main project. Please just note that I am currently insanely busy with school work and can't test it just now. My current goal is to test your changes and pull them in by next weekend.

Great.
I'm getting good results for the code in the game I'm making. But I've noticed a feature we might have to address. Currently the objects receiving these event notifications aren't given the corresponding hand, and the hand itself isn't given notifications. This makes it difficult to do FX and behaviours that relate to the specific hand that manipulated the object.
For my purpose I added an additional event dispatcher on the controller object, which passed the object that was just pointed to the hand. This served my purpose, but I don't think lends itself well to other scenarios.
BTW if you ever want another official contributor to this project, I'd be happy to add my name to it. I think it's a very worthwhile control system, as it plays nicely with so much, and allows for a great deal of functionality with controllers in a Unity flavoured way.
We could set out a roadmap, and make sure it remains a lightweight, general solution for both 2d UI and 3d element manipulation with position tracked VR controllers.

Yes, I think having you on the project as a contributor would be great. I agree that there needs to be a way to identify which hand is executing an action. And I like your idea of keeping it a lightweight solution for 2D and 3D UI with VR controllers.
The only issue I am facing at the moment is that I don't have regular access to a VR system anymore. At least for an other few months.

Excellent, that's great news!
I'm sorry you don't have a Vive at the moment. Luckily I have both at home, as I'm a freelance developer. So I can test easily both systems.
Add me to the list of collaborators. I'll still make my changes to a development branch rather than master, and then I'll merge when new features/fixes are fully tested.
I hope you can get your hands on a VR system again soon. Maybe if you do we can do planning meeting in Rec Room.


[Feature Proposal] Add records count in "Select Records" window

Description
Self explanatory.

This is already done in 0.0.8


New publish command

Adds a new publish command that migrates the current app/lib from lightweight into a full app, by deploying a directory, package and app contracts.
Also deprecates the --full flag for push, and renames that flag in init to --publish.
Fixes #255

Pending transfering ownership of proxies to app. Can be merged in the meantime though.

@facuspagnuolo added proxies transfer, ready to review now. I'll rebase onto master in a few minutes.


[AutoPR billing/resource-manager] fix: billing/resource-manager/Microsoft.Billing

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5481

Build output:

This PR has been merged into https://github.com/Azure/azure-sdk-for-java/pull/3207


Serial Monitor: Exit key combination doesn't work on international keyboards

In Windows the platformio serialports monitor Exit key combination Ctrl + ] does not work on international keyboards where ] is produced by a combination of keys.
For example in the standard Portuguese keyboard (Portugal and probably Brazil and other variants also), the ] character is produced by pressing Alt Gr + 8. In this case Serial Monitor never exits and one has to press Ctrl + Break to kill the program.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29222141-serial-monitor-exit-key-combination-doesn-t-work-on-international-keyboards?utm_campaign=plugin&utm_content=tracker%2F2014790&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F2014790&utm_medium=issues&utm_source=github).

You can override exit key. See http://docs.platformio.org/en/latest/userguide/cmd_serialports.html#cmdoption-platformio-serialports-monitor--exit-char

That will send the exit char but won't quit the app itself, right? Can't platformio use an universal key combination like Ctrl + Q?
I suspect many other non-us keyboards will have this behavior...

Can't platformio use an universal key combination like Ctrl + Q?

Universal for what? No here "universal". You can configure own --exit-char. See
platformio serialports monitor --exit-char 93
--- Miniterm on /dev/cu.usbmodemFD1311: 9600,8,N,1 ---
--- Quit: ']'  |  Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---

# to exit use Ctrl+C+]

platformio serialports monitor --exit-char 17
--- Miniterm on /dev/cu.usbmodemFD1311: 9600,8,N,1 ---
--- Quit: Ctrl+Q  |  Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---

# to exit use Ctrl+Q

If you specify DIRECT ASCII code (like 93 for ]), then you need to use Ctrl+C+]``. To use direct key, please minus 64 from ASCII char. For example, ASCII code for 'Q'char is81, then 81-64=17. Now platformio serialports monitor --exit-char 17will wait forCtrl+Q`
Here is the table http://www.theasciicode.com.ar/ascii-printable-characters/box-brackets-square-brackets-closing-bracket-ascii-code-93.html
Does it help you?
P.S: Please give us a star (:star:) https://github.com/platformio/platformio/stargazers

I meant universal for all keyboards: the default you have now will work on keyboards where Ctrl + ] is a direct key combination (like the English keyboard) in others it won't work (nothing happens).
Because of this maybe it would make sense to have a default exit combination that works for everyone, like Ctrl + Q or similar.
In any case, using --exit-char works fine. I'd suggest adding the explanation above to the docs as this information is far from obvious.
Thanks, you deserve many stars, this is an awesome project! Regards!

Which --exit-char do you use? I'll add to the doc.
Thanks!

Ctrl + Q as you listed two posts ago: --exit-char 17

I've added to docs. What is interesting, that Ctrl+Q doesn't work for me :disappointed:


GitHub Pages environments for all languages and default

Describe what feature you'd like. Pseudo-code, mockups, or screenshots of similar solutions are encouraged!
I'd like to build and deploy previews for all available languages from cb-translate/main using GitHub Pages as described in https://collectionbuilder.github.io/cb-docs/docs/walkthroughs/csv-walkthrough/
For example
https://collectionbuilder.github.io/cb-translate.en
https://collectionbuilder.github.io/cb-translate.es
https://collectionbuilder.github.io/cb-translate.de
https://collectionbuilder.github.io/cb-translate.default
PS: @evanwill I'd need more permissions to setup the environments.
What type of pull request would this be?
Enhancement
Any links to similar examples or other references we should review?
No response

@evanwill shall I set up the three previews?

@maehr so would we set up a github action in this cb-translate repository that builds out all three automatically? Or are these separate demo repositories? (or a separate demo repository that builds all three?)

I'd like to set up different environments for this repo as documented in https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment

In the other CB repositories we generally build the demo site out of a demo-site branch so that it can have separate metadata and content from the main. Would all three build from one branch, or are there separate branches, or direct from main?
My concern is just not adding too much complication to the main to make it as simple as possible for people using it as a template. If folks click the "use this template" button, it should work as expected, and not have to like turn off building the demo sites and delete a github action. So if we could trigger the build only on a demo-site branch or something like that (rather than on main), it might help avoid confusion for people using the template.

p.s. @maehr I updated your permissions


torch.rfft -> torch.fft.rfft

PyTorch changed their FFT API to match numpy in PyTorch 1.8. This PR updates the one call we make to it.

Codecov Report

:exclamation: No coverage uploaded for pull request base (staging@bd33479). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             staging      #213   +/-   ##
===========================================
  Coverage           ?   100.00%
===========================================
  Files              ?        72
  Lines              ?      5196
  Branches           ?         0
===========================================
  Hits               ?      5196
  Misses             ?         0
  Partials           ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd33479...0ab2265. Read the comment docs.


Authentication example not working

I tried to install the Authentication example but it raises a whole bunch of errors.
I think I got most of them fixed locally but the one persistent is complaining about some "icons component" which does not seem to exist?
https://github.com/shadcn/ui/tree/main/apps/www/app/examples/authentication
./components/user-auth-form.tsx:6:0
Module not found: Can't resolve '@/components/icons'
  4 |
  5 | import { cn } from "@/lib/utils"
> 6 | import { Icons } from "@/components/icons"
  7 | import { Button } from "@/components/ui/button"
  8 | import { Input } from "@/components/ui/input"
  9 | import { Label } from "@/components/ui/label"

https://nextjs.org/docs/messages/module-not-found

Is this some leftover that didn't got ported yet to the new CLI perhaps?

Hi @codeagencybe, that uses some icons exported as a single component to group the together. If you want you can copy it from here: https://github.com/shadcn/ui/blob/main/apps/www/components/icons.tsx.
You can also just edit the icons in that example using whatever icon library you are familiar with.

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


Upgrade API version to STG75 2020-04-08, and update changelog for new release

Thanks for contribution! Please go through following checklist before sending PR.
PR Branch Destination

For Azurite V3, please send PR to master branch.
For legacy Azurite V2, please send PR to legacy-dev branch.

Always Add Test Cases
Make sure test cases are added to cover the code change.
Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.

As discussed with @XiaoningLiu , the unit test in docker build in CI is not necessary, so remove it.


C#: iOS and Apple Silicon fixes

Supersedes #45499 (cherry-picks the commit)
Fixes #40757
Fixes #42960
Likely fixes #45421

Thanks!

@neikeq @bruvzg What changes do I need to make in official build scripts to use this?
I guess https://github.com/godotengine/godot-build-scripts/pull/16 and https://github.com/godotengine/build-containers/pull/68 need to be finalized and merged, and I guess the new iphone-mono-libs need to be copied somewhere too?

I guess godotengine/godot-build-scripts#16 and godotengine/build-containers#68 need to be finalized and merged, and I guess the new iphone-mono-libs need to be copied somewhere too?

Yes, iphone-mono-libs should be extracted, libmono-ee-interp, libmono-icall-table and libmono-ilgen static libs should go into frameworks and added to template. https://github.com/godotengine/build-containers/pull/68 and https://github.com/godotengine/build-containers/pull/68 may need some extra changes, but I'm not sure OSXCross is capable of building arm64 simulator libs at all (it was not able to do it last time I have checked).

godotengine/godot-build-scripts#16

Sorry, I forgot to mention this depends on godotengine/godot-mono-builds#39 and godotengine/godot-mono-builds#40, which I just proceeded to merge.
I commented on both godotengine/godot-build-scripts#16 and godotengine/build-containers#68 with the changes that should be needed.

but I'm not sure OSXCross is capable of building arm64 simulator libs at all (it was not able to do it last time I have checked).

AFAIK this is the reason #45480 was reverted. I talked about this with @akien-mga and he agreed to the cherry-pick of those changes, so this may have changed.

AFAIK this is the reason #45480 was reverted. I talked about this with @akien-mga and he agreed to the cherry-pick of those changes, so this may have changed.

I haven't tested in the last 5 months so... I guess we'll see :)

Hello, I still encounter issues Fixes https://github.com/godotengine/godot/issues/40757
with godot mono 3.5.1 stable
Anybody knows how to fix this ?

Please open a new issue report for this


TypeError: source.on is not a function

return rp.post({
    url: uri("collections/people"),
    formData: [{a: 1}, {a: 2}],
});

I'm trying to POST an array of values to a HTTP endpoint, and this is the error I receive:
TypeError: source.on is not a function
    at Function.DelayedStream.create (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/delayed-stream/lib/delayed_stream.js:33:10)
    at FormData.CombinedStream.append (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/combined-stream/lib/combined_stream.js:43:37)
    at FormData.append (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/form-data/lib/form_data.js:68:3)
    at appendFormValue (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/request/request.js:328:21)
    at Request.init (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/request/request.js:339:11)
    at Request.RP$initInterceptor [as init] (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/request-promise-core/configure/request2.js:45:29)
    at new Request (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/request/request.js:129:8)
    at request (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/request/index.js:55:10)
    at Function.post (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/request/index.js:63:12)
    at /home/kuba/projects/sealcode/sealious/integration-tests/test.js:45:13
    at tryCatcher (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/bluebird/js/release/promise.js:504:31)
    at Promise._settlePromise (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/bluebird/js/release/promise.js:561:18)
    at Promise._settlePromise0 (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/bluebird/js/release/promise.js:606:10)
    at Promise._settlePromises (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/bluebird/js/release/promise.js:685:18)
    at Async._drainQueue (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/bluebird/js/release/async.js:138:16)
    at Async._drainQueues (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/bluebird/js/release/async.js:148:10)
    at Immediate.Async.drainQueues [as _onImmediate] (/home/kuba/projects/sealcode/sealious/integration-tests/node_modules/bluebird/js/release/async.js:17:14)
    at tryOnImmediate (timers.js:543:15)
    at processImmediate [as _immediateCallback] (timers.js:523:5)

Are arrays not allowed in formData?

nope, formData has to be an object. ran into this problem myself :)

I tried to post something like this
formData = {
  name: { first: 'Saeid', last: 'Alidadi' }
}

and got this error also

formData accepts only three types of elements viz. string, Buffer and Stream, so try this:
formData = {
name: JSON.stringify( { first: 'Saeid', last: 'Alidadi' } )
}

Also receiving the same issue. My formData is:
{ 'subscriptions': [  {  "subscription": subscriptionId, "quantity": newQty, "product": product, "prorate": true }           ] }

everything needs to be stringified inside formData. try:
return rp.post({     url: uri("collections/people"),     formData: JSON.stringify([{a: 1}, {a: 2}]), });

@abhiCR7 Not everything. The rule is that values of formData object can only by any of these: string, Buffer, Stream. @VijayakumarManickam is right.
In my case I had change:
formData: {
        variables: {
          file: fs.createReadStream('./assets/car.jpg')
        }
      }

to
formData: {
        'variables.file': fs.createReadStream('./assets/car.jpg')
      }

I am getting error:
 TypeError: source.on is not a function     at Function.DelayedStream.create (/node_modules/delayed-stream/lib/delayed_stream.js:33:10)     at FormData.CombinedStream.append (/node_modules/combined-stream/lib/combined_stream.js:44:37)     at FormData.append (/node_modules/form-data/lib/form_data.js:74:3)     at appendFormValue (/node_modules/request/request.js:323:21)     at Request.init (/node_modules/request/request.js:334:11)     at new Request (/node_modules/request/request.js:128:8)     at request (/node_modules/request/index.js:53:10)
My code is:
var options = {
  url: 'http://...',
  method: 'POST',
  formData: {
    file: fs.createReadStream(__dirname + '/file.jpg'),
    first_name: 'first_name'
  }
}
request(options, function() {})

Request Version<EMAIL_ADDRESS>node version: node v9.8.0

@ketantada are you cloning or modifying the options object in some other way in your code? The stream object can break due to that.

I saw this error when using the deepmerge to merge default values (authorization headers) into requests options.

Typescript promisesized post with formData type {[key: string]: any} unable to pass string and saw that the form property solved my problem
(await promisify(post)({ url: baseUrl + 'material/add_news?' + query, form: JSON.stringify(form) }, undefined));
-- translate

Just in case. It worked for me.
let options = {
      method: 'POST',
      uri: 'http://webservice.com',
      formData: {
        wscx_id: input.dni,
        wscx_usu: user,
        wscx_pas:password
      },
      json: true // Automatically stringifies the body to JSON
}

Just in case. It worked for me.
let options = {
      method: 'POST',
      uri: 'http://webservice.com',
      formData: {
        wscx_id: input.dni,
        wscx_usu: user,
        wscx_pas:password
      },
      json: true // Automatically stringifies the body to JSON
}

I tried this, but I'm getting the exact same issue as OP

Just in case. It worked for me.
let options = {
      method: 'POST',
      uri: 'http://webservice.com',
      formData: {
        wscx_id: input.dni,
        wscx_usu: user,
        wscx_pas:password
      },
      json: true // Automatically stringifies the body to JSON
}

I tried this, but I'm getting the exact same issue as OP

u have to use form data like this
formData: {     'wscx_id': 'then something',     'something in quotes': 'value does not need to have quote necessary',     'but here u have to put quote': 'did u get it?', }

Don't forget to put the 'content-type' : 'multipart/form-data' inside the headers.

Hi,
I'm having this issue too. This is my formData:
formData: {
  filterGroups: [
    {
      filters: [
        {
          value: orgLabel,
          propertyName: 'name',
          operator: 'EQ',
        },
      ],
    },
  ],
  sorts: ['string'],
  query: 'string',
  properties: ['string'],
  limit: 0,
  after: 0,
},

How should I format this? I tried JSON.stringify for every key name but it's not working.

Just in case. It worked for me.
let options = {
      method: 'POST',
      uri: 'http://webservice.com',
      formData: {
        wscx_id: input.dni,
        wscx_usu: user,
        wscx_pas:password
      },
      json: true // Automatically stringifies the body to JSON
}

I tried this, but I'm getting the exact same issue as OP

u have to use form data like this
formData: { 'wscx_id': 'then something', 'something in quotes': 'value does not need to have quote necessary', 'but here u have to put quote': 'did u get it?', }

try to put keys in quotes like this 'key' : 'value'

Please make sure that each value of 'key'  is string not object under the formdata.
Like{ key : "string"}
For checking it is object or not use typeof().
Under the formData key should me either text or file.
And JSON.stringify will not work for to make object as string, it will remain JSON or object..

am getting this issue while appending the file as
const FormData = require('form-data');
const form = new FormData();
form.append('file', file, inputs.filename);
form.append('token', inputs.token);
form.append('file_password', inputs.password);
form.append('request_id', inputs.request_Iid);

var config = {
  method: 'post',
  url: inputs.url,
  headers: {
    ...form.getHeaders()
  },
  data : form
}

// console.log("form ::", form)
return await axios(config)
.then(function (response) {
  console.log(JSON.stringify(response.data));
  return response.data
})
.catch((err) => {
    console.log(err.response.data);
    return null;
  });

converted
const formData = new FormData();
formData.append('file', file.buffer);
const response = await this.pyAxiosInstance.post('/pdf_processor', formData, {
headers: {
'Content-Type': 'multipart/form-data'
}
});
to
const formData = new FormData();
formData.append('file', file.buffer, file.originalname);
const response = await this.pyAxiosInstance.post('/pdf_processor', formData, {
headers: {
...formData.getHeaders()
}
});
return {
data: response.data
}


Build docker image for master and agent during package phase

:+1: Does this add a little more time to our builds? Took 11:23min for me to mvn clean package

I tested yesterday and it added maybe 1.5 minutes? We could build the containers as part of a pre-integration test phase. That way they are only build if you're about to run tests which require them. If it would be useful to be able to create the containers as part of the package phase, we could create a profile which does that.

yea that sounds like a good idea

I added a profile for building the containers.
mvn -P build-containers package
We can also make it part of the pre-integration test phase once we have some test to run.


Decouple loader from stack initialisation

Currently, we have a catch 22 where the loader starts up before migrations run (after deleting volumes), and loader fails by not finding geographies.
Loader will be moved to a separate task, and not run immediately as part of stack startup.

New command:
make run_loader

It will fail like this if the backend database has issues:
$ make run_loader
docker-compose -f docker-compose.yml -f docker-compose.dev.yml run --rm loader python app/main.py
Creating navigator_loader_run ... done
Traceback (most recent call last):
  File "/app/app/main.py", line 75, in <module>
    main()
  File "/app/app/main.py", line 63, in main
    load(policies)
  File "/app/app/load/main.py", line 17, in load
    geography_id = get_geography_id(country_code)
  File "/app/app/load/api_client.py", line 20, in get_geography_id
    return _get_id(country_code, get_geographies_lookup, "geography_id")
  File "/app/app/load/api_client.py", line 45, in _get_id
    lookup = lookup_fn()
  File "/app/app/load/api_client.py", line 18, in
get_geographies_lookup
    return _get_lookup("geographies", "country_code")
  File "/app/app/load/api_client.py", line 69, in _get_lookup
    raise Exception(
Exception: Backend error. Check migrations ran, or base data is imported (e.g. geographies)
make: *** [makefile-docker.defs:70: run_loader] Error 1

Note error

Exception: Backend error. Check migrations ran, or base data is imported (e.g. geographies)


Golang language bindings

This would be very useful for developers looking to move their work into Go.

At the present, I don't know if there is anyone who is familiar with Go working with the project, so we'd need this to be a community contribution.
If you (or someone else) does start working on this, let us know!  we've been working on breaking these kinds of wrappings out into separate repositories, but we'd like to track and reference them from the central repo so that folks who are interested in those languages can find the bindings.

I think we would need to perfect the C-bindings before Go bindings. From the little research I've done on this we would need to use cgo to bind Go with C. In case there isn't anyone working on this by the time I'm completely done with my GSoC project, I might take a stab at this.


⚠ Ixtanet SAT has degraded performance

In 89db31b, Ixtanet SAT ($MEDIA_SAT) experienced degraded performance:

HTTP code: 200
Response time: 20573 ms

Resolved: Ixtanet SAT performance has improved in 7a432e1.


[#5294] Add topic property command to Gravitino CLI

What changes were proposed in this pull request?
Add topic property command to Gravitino CLI
Why are the changes needed?
To expand Gravitino CLI.
Fix: #5294
Does this PR introduce any user-facing change?
No but it adds additional command to the Gravitino CLi.
How was this patch tested?
Tested locally with a running Apache Kafka instance.

@shaofengshi once the first topic PR and the owner PR is merged this is ready to review or you could just review the topic property parts

@shaofengshi this is ready to review

@shaofengshi all fixed


MSE Test : 12. AddsourceBuffer

The testcase of AddsourceBuffer is changed a few days ago.
(audio/mp4, mp4a.40.2 -> audio/webm, opus)
LG TV is not supported opus codec.
So We get the fail.
Is there any chance of changing to AAC??

Opus has been made optional and AddSourceBuffer test now checks AAC. See: https://github.com/youtube/js_mse_eme/commit/54d514b06b5f8b333c3ce119f5357cfe4b99f43a
These changes will be pushed out later this week.


[Bug] npm install broken

Version
1.3.0
Reproduction link
https://github.com/creativetimofficial/paper-kit-react
Operating System
Win 10
Device
HP Laptop
Browser & Version
Brave Browser, 1.38.111
Steps to reproduce

Download kit
Unzip kit
Open terminal inside root folder
Run npm install

What is expected?
The app should install and be ready to demo
What is actually happening?
I'm getting a dependency error.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/react-datetime
npm ERR<EMAIL_ADDRESS>from the root project

Solution
Currently running npm install --force to override the dependency issues.
Additional comments
I've noticed you have paper kit 2 for every platform except react. When will you be adding the latter?

I have got the same problem too!
Neither npm install --force nor npm install --legacy-peer-deps is working for me.
What should I do?

Hi guys,
This issue is fixed for v1.3.1
Best,
Sajad


Add theme properties suggestions to code editors

@asimonok As we discussed, it's not possible to display theme properties when typed in.


Mocking browser functions - getComputedTextLength

Do you want to request a feature or report a bug? Feature
What is the current behavior?
I have some tests which are testing some code that render SVGs.
The underlying code uses the getComputedTextLength function.
At current it seems as if this method doesn't exist (I assume because nothing is running inside of an actual browser). Would it be possible to expose some way of supplying mock implementations for functions such as these. While not exactly the same as running in a true browser environment it would allow code around this to be tested using test.
Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.
Jest: 16.0.2
Node: 6.9.4
NPM: 3.10.9
OS: Windows 10

It would be great to have a 3rd party library like browser-test-mocks or browser-api-mocks complementary to jsdom, which would store such implementations (it would require tremendous amounts of work, but as a OSS project, every missing piece could be patched incrementally with PRs).
But I'm not convinced this should be a part of Jest.
I'll close the issue for now, but I'd like to keep the discussion going!

How I see it, is when this library would be solid enough, we could merge it into Jest as another package and further maintain it, just like it was with pretty-format or eslint-plugin-jest (coming in next major)

Any news on this? I didn't succeed in mocking SVGTextElement.prototype.getComputedTextLength yet. Any suggestions on how to do this or alternatively a way to bypass it to get my tests to pass again?

Is there any update on this? Any way to mock the getComputedTextLength function?


Multipleversions

Change version in  metadata.yaml to versions
Change gen-meta to generate multiple types and resourceSpecs if have multiple version, example:

// Register protos in "istio.io/api/networking/v1alpha3"
	_ "istio.io/api/networking/v1alpha3"

// Register protos in "istio.io/api/networking/v1beta1"
	_ "istio.io/api/networking/v1beta1"
// istio/networking/v1alpha3/virtualservices metadata
	IstioNetworkingV1alpha3Virtualservices resource.Info

// istio/networking/v1beta1/virtualservices metadata
	IstioNetworkingV1beta1Virtualservices resource.Info
IstioNetworkingV1alpha3Virtualservices = b.Register(
		"istio/networking/v1alpha3/virtualservices",
		"type.googleapis.com/istio.networking.v1alpha3.VirtualService")
IstioNetworkingV1beta1Virtualservices = b.Register(
		"istio/networking/v1beta1/virtualservices",
		"type.googleapis.com/istio.networking.v1beta1.VirtualService")

	b.Add(schema.ResourceSpec{
		Kind:      "VirtualService",
		ListKind:  "VirtualServiceList",
		Singular:  "virtualservice",
		Plural:    "virtualservices",
		Version:   "v1alpha3",
		Group:     "networking.istio.io",
		Target:    metadata.Types.Get("istio/networking/v1alpha3/virtualservices"),
		Converter: converter.Get("identity"),
	})

	b.Add(schema.ResourceSpec{
		Kind:      "VirtualService",
		ListKind:  "VirtualServiceList",
		Singular:  "virtualservice",
		Plural:    "virtualservices",
		Version:   "v1beta1",
		Group:     "networking.istio.io",
		Target:    metadata.Types.Get("istio/networking/v1beta1/virtualservices"),
		Converter: converter.Get("identity"),
	})

When start listening to resources, allow user to provide their filterVersion function to decide how to select the versions from the multiple available versions

filterVersion               func(i *schema.Instance)

Provide a default filter function:

filterVersion:               check.DefaultFilterFunction,

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: irisdingbj
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@irisdingbj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fb4b79db11463e26c47e6beea14c3e46f6bb90ad
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fb4b79db11463e26c47e6beea14c3e46f6bb90ad
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
fb4b79db11463e26c47e6beea14c3e46f6bb90ad
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fb4b79db11463e26c47e6beea14c3e46f6bb90ad
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
fb4b79db11463e26c47e6beea14c3e46f6bb90ad
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
fb4b79db11463e26c47e6beea14c3e46f6bb90ad
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: irisdingbj
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
fb4b79db11463e26c47e6beea14c3e46f6bb90ad
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
ea2e505eadceebd9d83df1de15a703c9e4fe90cd
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ea2e505eadceebd9d83df1de15a703c9e4fe90cd
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
ea2e505eadceebd9d83df1de15a703c9e4fe90cd
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
ea2e505eadceebd9d83df1de15a703c9e4fe90cd
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
57b106e637cde8dc4e24ebf95f53f236c998cee0
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
57b106e637cde8dc4e24ebf95f53f236c998cee0
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
57b106e637cde8dc4e24ebf95f53f236c998cee0
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren ^^^

@ozevren A ping to request your review for this PR. Thanks!

Ok, first apologies for not responding earlier, was swamped with Code Mauve.
I applied the PR locally and did a walkthrough. I don't think this is solving the fundamental problem but I might be missing something here. This filters out versions embedded in code from the input file. The metadata file is in our control, and I don't see how we can provide a different filtering function. I don't think this will solve the fundamental problem we will have with versioning.
The main issue is figuring out which K8s CRDs/core APIs to listen to (version-wise) when Galley startup. The internal Galley code will need to be equipped to deal with a range of versions for each resource type we listen. For example, the code needs to be able to read from both networking.istio.io/v1beta1 and v1alpha3. However, it will need to do a startup-time discovery to see which version is actually available on the K8s service. Once it detects available resources & versions, then it can pick the right version to listen to.
Now, I can see us using this to first collect a series of available versions first, filtering and then starting listening, but I think this will expose too much of the K8s level machinery and decisions at the server code. It is probably better to handle this at the K8s source layer, where we can do discovery and setup the listeners as part of startup.

@ozevren Can we have the k8s discovery part after 1.2 as we discussed before?  So this PR can be used to support:

Support multiple versions in metadata.yaml

generate multiple types and resourceSpecs if have multiple version

find the earliest served version for crd

I think your PR has more than that. For example, I don't think we will ever need to override the logic of selection (i.e. the way you're injecting the logic in the server.go).

I think your PR has more than that. For example, I don't think we will ever need to override the logic of selection (i.e. the way you're injecting the logic in the server.go).

Hi Oz,
We need add logic to find the earliest served version for crd, what is the suggested place to add this logic in? Since the original filter function(FindSupportedResourceSchemas) is put in check.go and server.go so I just wan to follow the same style with it.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: irisdingbj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Uploading issue

There is some bug when go to upload in iTunes . Its ok ,when i created a build in the development phase.

@Prabhatjisit We are going to need much more details to try and help :)

@Prabhatjisit did you solve your issue?

still facing uploading issue with carthage framework.

Closing for lack of activity, feel free to reopen if needed :)


Is the javascript free?

From @escribelibre on March 31, 2014 3:26
I am using LibreJS because of this https://www.gnu.org/philosophy/javascript-trap.html
And LibreJS told me redmatrix is using nonfree javascript, as defined here https://www.gnu.org/software/librejs/free-your-javascript.html
Sometimes LibreJS mistakenly thinks a page has nonfree js, so just want to ask, and possibly suggest following the "free your javascript" guide. :-)
Copied from original issue: friendica/red#389

From @escribelibre on March 31, 2014 5:20
By whitelist I just mean to tell the addon to ignore the domain. Not really a solution for others, just me. I can imagine it being annoying having to follow the format to get LibreJS to accept it, so np. I'm not interested in causing friction.
I really love and appreciate this project. I finally managed to get some people away from Facebook and join me on this. IMO it is the best social networking software I've seen! And I've been searching a long time. Thank you.

From @friendica on March 31, 2014 4:18
All our javascript is free. You are welcome to view any or all of the associated licenses for any and all components of the red matrix, since it is all free and open source. Our project level license is located in /LICENSE. Many components in /library have different licenses and I believe these are all clearly marked and all are recognised free and open source licenses.

From @friendica on March 31, 2014 4:56
You probably can't whitelist redmatrix unless we edit every file to make it conform to the libreJS format. This is not going to happen.
The RedMatrix is a free open source project under the MIT license. There is traditionally some amount of friction between GPL and MIT/BSD and other open source licenses and this is not the place for license wars.  LibreJS is increasingly being used to incite friction amongst open source projects using non-GPL licenses. We've got a project with a known and respected free and open source license and the components thereof also have known and respected free and open source licenses. End of story.

From @escribelibre on March 31, 2014 4:22
Awesome.
I am not a coder, so I am not sure how to make the page and LibreJS play nice. All I can really do is whitelist redmatrix. Anyway, thanks :)


sched/group: clear tcb group after group_release

Summary
nxsig_action will use tcb group when group release, so need clear tcb group after group_release.
[ap] dump_assert_info: Assertion failed : at file: signal/sig_action.c:205 task: ofonod process: Kernel 0xec89d5
[ap] sched_dumpstack: backtrace:
[ap] sched_dumpstack: [29] [<0x66e2e2>] backtrace_unwind+0x105/0x108
[ap] sched_dumpstack: [29] [<0x660272>] sched_backtrace+0x41/0x48
[ap] sched_dumpstack: [29] [<0x61c4dc>] sched_dumpstack+0x33/0x80
[ap] sched_dumpstack: [29] [<0x6023e4>] _assert+0x19b/0x39c
[ap] sched_dumpstack: [29] [<0x61b7e4>] __assert+0x7/0x10
[ap] sched_dumpstack: [29] [<0x6071a2>] nxsig_action+0x119/0x248
[ap] sched_dumpstack: [29] [<0x6072d8>] sigaction+0x7/0x24
[ap] sched_dumpstack: [29] [<0x66a072>] signal+0x4d/0x80
[ap] sched_dumpstack: [29] [<0x100fd36>] signalfd_file_close+0x35/0x60
[ap] sched_dumpstack: [29] [<0x64a7d8>] file_close+0x1b/0x44
[ap] sched_dumpstack: [29] [<0x649ac0>] files_putlist+0x2b/0x70
[ap] sched_dumpstack: [29] [<0x60491a>] group_leave+0x99/0xe4
[ap] sched_dumpstack: [29] [<0x605df8>] nxtask_exithook+0x4f/0xf4
[ap] sched_dumpstack: [29] [<0x603ca0>] _exit+0x33/0x3c
[ap] sched_dumpstack: [29] [<0x61ecf0>] abort+0x7/0xc
Impact
task_exit
Testing
BES board with ostest and monkey test pass

[Experimental Bot, please feedback here]
The PR summary and impact sections are lacking and don't meet the NuttX requirements. Here's a breakdown and suggestions for improvement:
What's Missing/Needs Improvement:

Summary:

Why is the change necessary? The summary mentions a bug ("Assertion failed") but doesn't explain why clearing the TCB group after group_release is the correct solution.
What functional part is being changed? Be more specific than "task_exit." Which functions are modified? What data structures are affected?
How does the change work?  Provide a concise explanation of the mechanism used to clear the TCB group.

Impact:

Is a new feature added?  Unclear. The description suggests a bug fix, which wouldn't be a new feature.
Impact on the user? It's crucial to analyze if this change might cause applications to behave differently.
Other impacts: The PR only mentions "task_exit." Analyze and address all other potential impacts (build process, hardware, documentation, security, compatibility).

How to Improve the PR Description:

Explain the Bug: Clearly describe the root cause of the assertion failure. Why does nxsig_action using the TCB group during group_release lead to an issue?
Solution Details: Provide a step-by-step explanation of how clearing the TCB group resolves the problem.
Functional Impact: Be specific about which functions or modules are directly affected by the code changes.
User Impact: Will this fix change any behavior observable by applications running on NuttX? If so, how?
Thorough Impact Assessment:  Address all impact categories listed in the requirements. Even if an impact is "NO," state it explicitly (e.g., "Impact on build: NO").
Testing Clarity:

Environment Details: Provide complete information about your build host and target environments (OS versions, compiler versions, specific board models).
Relevant Test Logs:  The current logs are not informative. Include only the relevant portions of the logs that demonstrate the bug before the fix and the successful behavior after the fix.

Example of an Improved Summary:

Fix: Assertion failure in nxsig_action during group_release

This PR addresses an assertion failure occurring in nxsig_action when a task exits while a signal is being delivered to its group. The issue arises because nxsig_action attempts to access the task's TCB group information during group_release, which may have already freed the group data.

The fix ensures that the TCB group is explicitly cleared before group_release is called, preventing the invalid memory access and resolving the assertion failure.

By providing a more detailed and comprehensive PR description, you make it easier for reviewers to understand your changes and ensure they meet the NuttX project's standards.

Why not check the validity of the group and return error? since the group has already exited


Add instruction to install trunk to examples/README.md

Add the install step to the README.md so the user can follow the readme, without using the leptos book

Thanks!


Wrong Popper position in a scrolled content

CodePen demo
https://codepen.io/alex3ax/pen/qBOONPW
Steps to reproduce the problem

Scroll a little bit down
Click on the button
The tooltip position is wrong

What is the expected behavior?
The tooltip should be stuck to the bottom of the button
What went wrong?
The scrollTop of the ref is always 0 in this example, it looks like the offset calculation can't take scroll into account.
Any other comments?
Given such a layout is it possible to configure the Popper behavior correctly without layout changes?

I think this is the visualViewport thing to be honest, it doesn't happen in 2.2.0. We've fixed it already, waiting for release right now.

Okay so, took a look again.
It's caused by making <html> a scroll parent (overflow property). I would highly recommend not styling <html> at all beyond a CSS "reset" or adding height: 100%, but this is an edge case that needs to be fixed I guess.
I believe it's this:
https://github.com/popperjs/popper-core/blob/1976cdc48c5e556cfd4bf7faf162536c16aa6558/src/dom-utils/getScrollParent.js#L8-L11

Thanks for your efforts @atomiks, really appreciate it. Unfortunately, the layout is beyond our control - we add our widget to the clients' websites and have to deal with such cases.

Having (seemingly) the same issue after updating react-popper from 2.1.x to 2.2.2 in a contentEditable with potentially unusual overflow and other styles (Electron app.)

@Slapbox create a reproduction, it's virtually impossible to know why it's happening because DOM edge cases are crazy

Poking through my yarn.lock it looks like we've mysteriously updated to popper-core to latest, though I can't figure out why. Anyway, if the PR you've got open doesn't fix it I'll downgrade or be back.


chore/devex: update homepage link to point to the new docs site

Hi, thanks for this. Going to merge but it will only be available for the next release, as I don't think this small thing should warrant a patch version.
Thank you!


Mentors and Maintainers cards not yet linked.

Description
This is issue is in reference to #72 which was closed recently by this PR #75 from my side.

In the mentioned issue #72, this problem is yet to be dealt with.

A single card component for all admins, mentors, and contributors. No need to type-in separately.

This was yet to be implemented since it is typed out for Mentors and Maintainers in Detail.js

If this cannot be implemented, then we can manually link it for the given 4 people in Detail.js

Type of issue
These checkboxes can be checked like this: [X]

[ ] Feature (New Script)
[X] Bug
[ ] Documentation

Checklist

[X] I have read the project guidelines.
[X] I have checked all the existing projects, before submitting a new project issue.
[X] I have checked previous issues to avoid duplicates.
[X] I have added screenshots in case of bugs/feature updates.
[X] This issue will be meaningful for the project.

In case of bugs

[X] I have added screenshots of the bug.
[ ] I have added steps to reproduce the bug.
[ ] I have proposed a possible solution for the bug.

Screenshots

Since, contributors and all these cards will be merged. No need for this issue. :)


Create CODE_OF_CONDUCT.md

Coverage remained the same at 56.351% when pulling bc26f912df359a8d83faa40688f58c232a46385f on add-code-of-conduct-1 into b07b04db54b1b7644b15ab6f930d7d9d15e5e5e8 on master.


Mirego-base-setup 3 of X: MVVM pattern

📖 Description
Add our basic MVVM pattern
View, ViewModel, UseCase, Repository
Also added datasources and Apollo to query a Mirego GraphQL api
🦀 Dispatch

#dispatch/kmp

🦀 Requesting reviewers for this pull request:

@marcantoinefortier (contributor with 4 commits in the last 90 days and 29 commits overall)
@charleyxiv (reviewer for the kmp stack)

🦀 Mentionning users for this pull request:

@laurentboileau (learner for the kmp stack)


Swappy is broken

Describe the bug
I got this error on unstable when I invoke swappy from my terminal:
** (swappy:5998): CRITICAL **: 22:14:39.564: original image not loaded
(swappy:5998): GLib-GObject-CRITICAL **: 22:14:39.564: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
To Reproduce
Steps to reproduce the behavior:

Invoke "swappy" from terminal.

Expected behavior
I guess it should start work:)
Screenshots

Notify maintainers

@matthiasbeyer

you need to give it a image with -f file.png or grim -g "$(slurp)" - | swappy -f -

so working as intended

I guess this can be closed then? I cannot test as I'm not using wayland anymore.

Yep, you are right guys. I'm sorry. I just misunderstand how this tool works.
Thanks!

@Artturin  Even with your command I am getting the following error now:

It was working a week ago.