crop the image with the right area

While i crop the image like this:

But i get a new image like this below:

I don't know why. Could you help me , please? Thank you.

It looks like your croppie might be in a modal?  Make sure you call bind() after the modal has completed it's animation and/or is visible.

Thanks for your answer!  But I have called bind() method, maybe not at the right place? Here is my code, could you please take a time to look at it?  thanks again. : )

                <button type="button" class="close" data-dismiss="modal" aria-label="Close">×</button>

修改您的头像

                选择文件
                    <input type="file" id="upload" value="" accept="image/*" alt="选择图片">

                <button type="button" class="btn btn-secondary" data-dismiss="modal">取消</button>
                <button type="button" class="btn btn-success btn-submit">确定</button>

$(document).ready(function(){
    // avatar on the page.
    $('.member-avatar').on('click', function(){
        $('#modal-image-edit').modal('show');
    });

    var $uploadCrop;

    function readFile(input) {
        if (input.files && input.files[0]) {
            var reader = new FileReader();
            reader.onload = function (e) {
                $uploadCrop.croppie('bind', {
                    url: e.target.result
                });
                $('#upload-avatar').addClass('ready');
            }
            reader.readAsDataURL(input.files[0]);
        }
    }

    $uploadCrop = $('#upload-avatar').croppie({
        viewport: {
            width: 300,
            height: 300,
            type: 'circle'
        },
        boundary: {
            width: 300,
            height: 300
        }
    });

    $('#upload').on('change', function () { readFile(this); });
    $('.btn-submit').on('click', function (ev) {
        $uploadCrop.croppie('result', {
            type: 'canvas',
            size: 'viewport',
        }).then(function (image_data) {
            $.post(
                    'path/to/upload',
                    JSON.stringify({
                        image_data:image_data,
                    }),
                    function(json) {
                        if (json.ok) {
                            location.href = 'path/to/page';
                        } else {
                            alert(json.errmsg);
                        }
                    }, 'json'
                  );
        });
        return false;
    });
});

The key to your code is the .modal('show').  It's not obvious what library you're using for your modals, but most of them perform some sort of animation to bring the modal into visibility.  The problem this causes with croppie is the positioning.  Croppie is very dependent upon knowing it position.
Most of these modal libraries have an option to execute a function after the modal is shown ... something like the following:
$('.my-element').modal({
    onShown: function () {
        // you don't even need to pass parameters to bind if you've already called bind before
        $uploadCrop.bind();
    }
});

The library is bootstrap v4, I'll try it when i'm back to the office tomorrow. Thank you very much!

Finally, I get the reason: I had setted a img: {width: 100%} globally, then fixed it with img:{max-width: 100%} . Maybe it does not work well with the bootstrap's grid.
Thank you very much!


Autocomplete not working with chip input (does with regular input)

I get folowing error when using autocompleteoptions for chip input

Uncaught TypeError: r.autocomplete is not a function
at w.fn.init.chips (materialize.min.js:6)
at HTMLElement. (materialize.min.js:6)
at Function.each (jquery.min.js:2)
at w.fn.init.each (jquery.min.js:2)
at w.fn.init.init (materialize.min.js:6)
at w.fn.init.t.fn.material_chip (materialize.min.js:6)
at ngx-materialize.js:899
at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:421)
at Zone.push../node_modules/zone.js/dist/zone.js.Zone.runTask (zone.js:188)
at push../node_modules/zone.js/dist/zone.js.ZoneTask.invokeTask (zone.js:496)

Steps to Reproduce (for bugs)
copy and paste from the demo page. When using the regular input, autocomplete does work without a problem.
<mz-chip-input [placeholder]="'Start typing'" [autocompleteOptions]="autocompleteOptions"></mz-chip-input>
My code:
// autocomplete autocompleteOptions: Materialize.AutoCompleteOptions = {   data: {     'Apple': null,     'Microsoft': null,     'Google': 'assets/google_g_logo.png',   } };
Package.json:
{   "name": "zvo-ultimate",   "version": "0.0.0",   "scripts": {     "ng": "ng",     "start": "ng serve",     "build": "ng build",     "test": "ng test",     "lint": "ng lint",     "e2e": "ng e2e"   },   "private": true,   "dependencies": {     "@angular/animations": "^6.1.9",     "@angular/common": "^6.0.3",     "@angular/compiler": "^6.0.3",     "@angular/core": "^6.0.3",     "@angular/forms": "^6.0.3",     "@angular/http": "^6.0.3",     "@angular/platform-browser": "^6.0.3",     "@angular/platform-browser-dynamic": "^6.0.3",     "@angular/router": "^6.0.3",     "core-js": "^2.5.4",     "ngx-materialize": "^6.1.3",     "rxjs": "^6.0.0",     "zone.js": "^0.8.26"   },   "devDependencies": {     "@angular/compiler-cli": "^6.0.3",     "@angular-devkit/build-angular": "~0.6.6",     "typescript": "~2.7.2",     "@angular/cli": "~6.0.7",     "@angular/language-service": "^6.0.3",     "@types/jasmine": "~2.8.6",     "@types/jasminewd2": "~2.0.3",     "@types/node": "~8.9.4",     "codelyzer": "~4.2.1",     "jasmine-core": "~2.99.1",     "jasmine-spec-reporter": "~4.2.1",     "karma": "~1.7.1",     "karma-chrome-launcher": "~2.2.0",     "karma-coverage-istanbul-reporter": "~2.0.0",     "karma-jasmine": "~1.1.1",     "karma-jasmine-html-reporter": "^0.2.2",     "protractor": "~5.3.0",     "ts-node": "~5.0.1",     "tslint": "~5.9.1"   } }
Your Environment
Version used: ^6.1.3
Angular version used: ^6.1.0
Browser Name and version: Google Chrome Version 69.0.3497.100
Operating System and version (desktop or mobile): Windows 10
Anyone else got this issue?
Thank you.

I figured out that when I load jquery 2.2.4 in my index.html, the chips autocomplete does work.
jQuery version 3.3.1 that I loaded via node_modules/jquery/dist/jquery.min.js in angular.json seems te be not compatible.
 <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/2.2.4/jquery.min.js"></script>


Try Runic formatting again

@fredrikekre
Seems much better now

Hmm seems to have introduced another parsing error

Seems great now! Thanks @fredrikekre for the help / fixing the issues. Going to close this and re-format later after some other changes I'm doing, but I really like the tool.

Thanks for beta-testing and reporting issues! Keep pinging me if you find stuff.


Change enum declaration to more idiomatic

At the moment enum column are defined
val type = enum("type", object : TypeReference<AccountType>() {})

It will be more idiomatic to have it like
val type = enum<AccountType>("type")

Use the typeRef function:
val type by enum("type", typeRef<AccountType>())

Thank you. Can you please add this example in the documentation?


Error while creating react app

Is this a bug report?
YES
error An unexpected error occurred: "https://registry.yarnpkg.com/react-dev-utils/-/react-dev-utils-5.0.2.tgz: Request failed \"404 Not Found\"".
info If you think this is a bug, please open a bug report with the information provided in "/Manivel Workspace/Sample projects/helloreactweb/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

Aborting installation.
  yarnpkg add --exact react react-dom react-scripts --cwd /Manivel Workspace/Sample projects/helloreactweb has failed.

Deleting generated file... package.json
Deleting generated file... yarn-error.log
Deleting helloreactweb / from /Manivel Workspace/Sample projects
Done.

Did you try recovering your dependencies?
Have you done all these steps and still see the issue?
Please paste the output of npm --version and/or yarn --version to confirm.
--> npm --version
6.4.1

(Write your answer here if relevant.)
Environment

Environment:
  OS:  macOS High Sierra 10.13.3
  Node:  10.4.1
  Yarn:  1.7.0
  npm:  6.4.1
  Watchman:  4.9.0
  Xcode:  Xcode 9.3 Build version 9E145
  Android Studio:  3.1 AI-173.4720617

Packages: (wanted => installed)
  react: ^16.4.2 => 16.4.2

Duplicate of #4938

See https://github.com/facebook/create-react-app/issues/4938#issuecomment-417274452.


[Removal]:

Hotspot Name
Huge Alabaster Raccoon
Hotspot b58 Address
1127T5uhwQU8Aqz4F6MQEDhAV7ATeXRNvRtor56Qa43aHGRDXeU4
Discord Handle
Ken1993#7183
Hotspot Manufacturer
PANTHER X1
Removal Reason
I have been placing this hot spot in my warehouse to maintain a stable network state. Occasionally check it out and it was fine until recently when it was added to the rejected list. I rechecked the network to make sure everything was working.please run the test algrothim again and check it, thanks a lot.
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
Hi the helium team,
Thanks for all you have done to maintain a health and honest network.I've always deployed it in the right place as part of the network to serve local devices.Please confirm the location again and remove my hot spot from the denied list.

1127T5uhwQU8Aqz4F6MQEDhAV7ATeXRNvRtor56Qa43aHGRDXeU4 isn't on the denylist.
And neither is Huge Alabaster Raccoon.
This issue should be closed.


password store changes to adjust for arrays

https://github.com/rancher/rancher/issues/19053

LGTM

LGTM


[feat] remove prefix v of engine version

Remove prefix v of engine version from deploy-quick.md of v1.3.2 and v1.4.0.
移除了v1.3.2和v1.4.0单机部署文档中引擎版本名的前缀v。
Related issues: https://github.com/apache/linkis/issues/4669

Global search and modify

Global search and modify

Thanks, I will do it later.

Done.I only modify those files of v1.3.2 and v1.4.0 because I find the engine version name still starts with prefix v below v1.3.2. @aiceflower

Done.I only modify those files of v1.3.2 and v1.4.0 because I find the engine version name still starts with prefix v below v1.3.2. @aiceflower

Yes

LGTM.


⚠ Samsung has degraded performance

In 617a21a, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2427 ms

Resolved: Samsung performance has improved in 88ef05c.


Question: getting a Lora which crashed at sample generation step

Hey, I've trained multiple loras in last few weeks and the latest one crashed at sample generation.


Bump: 0.16.0-next -> 0.17.0

Proposed changes
This PR bumps FIWARE Big Bang version from 0.16.0-next -> 0.17.0.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update only documentation, not any source code.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[X] I have read the CONTRIBUTING doc
[ ] I have signed the CLA
[X] I have updated the change log (CHANGELOG.md)
[ ] I send this pull request to the v0.16.0-next branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

Codecov Report

Merging #198 (e74552b) into v0.16.0-next (92b2000) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           v0.16.0-next      #198   +/-   ##
==============================================
  Coverage        100.00%   100.00%
==============================================
  Files                 2         2
  Lines              1746      1746
==============================================
  Hits               1746      1746

Impacted Files
Coverage Δ

config.sh
100.00% <100.00%> (ø)

lets-fiware.sh
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b2000...e74552b. Read the comment docs.


Simplify serializerbase

What do you think about reducing the scope of some of the helper methods like append, prepend, etc to protected or private in SerializerBase?

Sounds good.

I couldn't reduce the visibility of prepend/append/insert since they're called in some of the Templates classes.


Typescript support?

Is there any plan for typescript support?

I, personally, don't have enough experience with it to add the support, but, PRs are always welcome


Posting message doesn't work in build version

I noticed that in both build versions of the application when you call slackSvc.chat.postMessage it is not calling the correct API method.  It calls a method that will return channel info.  I've corrected it in both versions and will submit a pull request, but just wanted to open an issue for tracking purposes.
 // CHAT
        function postMessage(channeId, message, callback, token) {
            var params = {
                token: token || slackConfig.DefaultToken,
                channel: channeId,
                text: message
            };
            executeApiCall("channels.info", params, callback);
        }

Thank you for fixing the method call, I have merged your pull request!


Compute ANIm & dnadiff by column via subprocess (as done for ANIb and fastANI)

Follow up from #190 which did this for fastANI and ANIb, although here this is essentially a loop and still does each query-vs-subject individually.
To be followed up a similar set of changes for dnadiff.
This means with N genomes we only expect N tasks via snakemake (e.g. N jobs on SLURM), rather than N² tasks or jobs.
Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)
[ ] This change requires a documentation update
[ ] This is a documentation update

Action Checklist

[x] Work on a single issue/concept (if there are multiple separate issues to address, please use a separate pull request for each)
[ ] Fork the pyani-plus repository under your own account (please allow write access for repository maintainers)
[x] Set up an appropriate development environment (please see CONTRIBUTING.md for this repository)
[x] Create a new branch with a short, descriptive name
[x] Work on this branch

[x] style guidelines have been followed (please see CONTRIBUTING.md for this repository)
[x] new code is commented, especially in hard-to-understand areas
[x] corresponding changes to documentation have been made
[x] tests for the change have been added that demonstrate the fix or feature works

[x] Test locally with pytest-plus -v non-passing code will not be merged
[x] Rebase against origin/master
[x] Check changes with linting/formatting tools before submission (please see CONTRIBUTING.md for this repository)
[x] Commit branch
[x] Submit pull request, describing the content and intent of the pull request
[x] Request a code review
[x] Continue the discussion at Pull requests section in the pyan-plus repository

Also longer term I think the method specific code for computation by column ought really to be moved into the method specific Python modules.

Some cluster testing notes using this branch.
This is my current snakemake-profile-archie-west/config.yaml file:
executor: slurm
jobs: 40
cores: 1
precommand: "module purge && module load miniconda && conda activate pyani-plus_py312 && python --version"

# Default 5s
latency-wait: 3

# Default 10s
queue-input-wait-time: 3

# Default 10s
seconds-between-status-checks: 3

# See https://snakemake.github.io/snakemake-plugin-catalog/plugins/executor/slurm.html#advanced-resource-specifications
default-resources:
    # Default seems to be 40s, which is ages for test jobs
    slurm_init_seconds_before_status_checks: 3

    # If not specified, get a warning (in purple) then this error (in red):
    # SLURM job submission failed. The error message was
    # sbatch error: Batch job submission failed: No partition specified
    # or system default partition
    slurm_partition: dev

    # If not specified, get the following warning (in purple):
    # No SLURM account given, trying to guess.
    # Guessed SLURM account: pritchard-grxiv
    slurm_account: pritchard-grxiv

    # If not specified, get the following warning (in purple):
    # No wall time information given. This might or might not work
    # on your cluster. If not, specify the resource runtime in your
    # rule or as a reasonable default via --default-resources.
    runtime: 10

This is the simple test script slurm_test.sh:
#!/bin/bash
set -euo pipefail

rm -rf slurm_test.db

export SNAKEMAKE_PROFILE=$PWD/snakemake-profile-archie-west

if [ ! -f $SNAKEMAKE_PROFILE/config.yaml ]; then
    echo "Missing snakemake profile"
    exit 1
fi

touch slurm_test.db
for N in 10 25; do
    for M in branchwater sourmash fastani anim dnadiff anib; do
        echo
        echo "Starting $N genomes using $M"
        # Not setting --temp as want it to use node-specific system default
        time pyani-plus $M --database slurm_test.db --executor slurm pecto_md5_$N
        echo "Finished $N genomes using $M"
    done
done

And this was the output with 10 genomes only:
$ ./slurm_test.sh

Starting 10 genomes using branchwater
Indexing FASTAs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00 10/10
branchwater run setup with 10 genomes in database
Database already has 0 of 10²=100 comparisons, 100 needed
Using profile /users/wkb24128/repositories/pyani-plus/snakemake-profile-archie-west for setting default command line arguments.
host: archie-e.hpc.strath.ac.uk
Comparing pairs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:01:25 1/1
Completed run-id 1 with 10 genomes in database slurm_test.db

real	1m43.109s
user	0m20.791s
sys	0m1.210s
Finished 10 genomes using branchwater

Starting 10 genomes using sourmash
Indexing FASTAs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00 10/10
sourmash run setup with 10 genomes in database
Database already has 0 of 10²=100 comparisons, 100 needed
Using profile /users/wkb24128/repositories/pyani-plus/snakemake-profile-archie-west for setting default command line arguments.
host: archie-e.hpc.strath.ac.uk
Comparing pairs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:01:22 1/1
Completed run-id 2 with 10 genomes in database slurm_test.db

real	1m26.924s
user	0m18.331s
sys	0m1.003s
Finished 10 genomes using sourmash

Starting 10 genomes using fastani
Indexing FASTAs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00 10/10
fastANI run setup with 10 genomes in database
Database already has 0 of 10²=100 comparisons, 100 needed
Using profile /users/wkb24128/repositories/pyani-plus/snakemake-profile-archie-west for setting default command line arguments.
host: archie-e.hpc.strath.ac.uk
Comparing pairs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:23 100/100
Completed run-id 3 with 10 genomes in database slurm_test.db

real	0m58.937s
user	0m13.371s
sys	0m0.656s
Finished 10 genomes using fastani

Starting 10 genomes using anim
Indexing FASTAs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00 10/10
ANIm run setup with 10 genomes in database
Database already has 0 of 10²=100 comparisons, 100 needed
Using profile /users/wkb24128/repositories/pyani-plus/snakemake-profile-archie-west for setting default command line arguments.
host: archie-e.hpc.strath.ac.uk
Comparing pairs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:03:17 100/100
Completed run-id 4 with 10 genomes in database slurm_test.db

real	3m32.916s
user	0m11.105s
sys	0m0.653s
Finished 10 genomes using anim

Starting 10 genomes using dnadiff
Indexing FASTAs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00 10/10
dnadiff run setup with 10 genomes in database
Database already has 0 of 10²=100 comparisons, 100 needed
Using profile /users/wkb24128/repositories/pyani-plus/snakemake-profile-archie-west for setting default command line arguments.
host: archie-e.hpc.strath.ac.uk
Comparing pairs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:03:47 100/100
Completed run-id 5 with 10 genomes in database slurm_test.db

real	4m7.436s
user	0m10.428s
sys	0m0.629s
Finished 10 genomes using dnadiff

Starting 10 genomes using anib
Indexing FASTAs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00 10/10
ANIb run setup with 10 genomes in database
Database already has 0 of 10²=100 comparisons, 100 needed
Using profile /users/wkb24128/repositories/pyani-plus/snakemake-profile-archie-west for setting default command line arguments.
host: archie-e.hpc.strath.ac.uk
Comparing pairs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:04:14 100/100
Completed run-id 6 with 10 genomes in database slurm_test.db

real	4m27.182s
user	0m8.229s
sys	0m0.677s
Finished 10 genomes using anib

Meanwhile in another session, pulling out the (start of) the unique hash label which snakemake generates, comments added by hand:
$ sacct | grep " dev " | cut -c "14-24,59-68" | uniq -c
     11 7e36e7eb-+ COMPLETED  # 1m43.109s branchwater (10 signatures plus 1 all-vs-all)
     11 07a85328-+ COMPLETED  # 1m26.924s sourmash (10 signatures plus 1 all-vs-all)
     10 bb1967fc-+ COMPLETED  # 0m58.937s fastani (10 columns)
     10 844cae80-+ COMPLETED  # 3m32.916s anim (10 columns)
     10 7281d4f6-+ COMPLETED  # 4m07.436s dnadiff (10 columns)
     10 b0ac2859-+ COMPLETED  # 4m27.182s anib (10 columns)

So not a fair test as this is just the real time including all the waiting for slots on the cluster, not just the raw compute and associated overheads.
However, proof that this has "worked" in dropping us to just one slurm job per genome with computation of the matrix by column.

The local version of that little test running on the 48 core Aphrodite server (which means therefore that we're not fully exploiting it with only 10 jobs):

5.759s branchwater vs 1m43.109s via SLURM
5.122s sourmash vs 1m26.924s via SLURM
18.557s fastani vs 0m58.937s via SLURM
3m3.624s anim vs 3m32.916s via SLURM
3m33.817s dnadiff vs 4m07.436s via SLURM
4m2.702s anib vs 4m27.182s via SLURM

Surprisingly close I thought. For a fairer test, running on a single cluster node (tried 1GB first but out of memory during ANIm):
$ sbatch --mem 2G -c 10 --partition dev local_test.sh
Submitted batch job 11614041

where local_test.sh is:
#!/bin/bash

# So SLURM finds our stuff
module purge && module load miniconda && conda activate pyani-plus_py312 && python --version

set -euo pipefail

rm -rf local_test.db

export SNAKEMAKE_PROFILE=

touch local_test.db
for N in 10; do
    for M in branchwater sourmash fastani anim dnadiff anib; do
        echo
        echo "Starting $N genomes using $M"
        # Not setting --temp as want it to use node-specific system default
        time pyani-plus $M --database local_test.db --executor local pecto_md5_$N
        echo "Finished $N genomes using $M"
    done
done

0m7.675s branchwater vs 1m43.109s via SLURM executor
0m5.467s sourmash vs 1m26.924s via SLURM executor
0m18.575s fastANI vs 0m58.937s via SLURM executor
6m26.007s anim vs 3m32.916s via SLURM executor
8m23.964s dnadiff vs 4m07.436s via SLURM executor
4m7.754s anib vs 4m27.182s via SLURM executor

So this is one SLURM job with 10 cores (local executor), versus 10 jobs with 1 core each (slurm executor).
This started off close to the Aphrodite numbers, but then took about twice as long on ANIm and dnadiff! Perhaps the node was busy at that point?

Sorry, @peterjc! I just managed to get to this. I understand these changes will probably need to be discussed on Monday anyway, so my input isn't going to add much here. However, I have one question (if it was mentioned earlier and I missed it, I apologise). How much faster is it to compute ANIm and dnadiff by column compared to our previous method?

I have not (yet) done the before/after benchmarking. My feeling is it will be a lot faster on SLURM, but that is harder to prove as cluster wait times are unpredictable. I would also expect it to be a tiny bit faster with the local runner.
[I am currently using Aphrodite to try to reproduce a recently reported pyANI bug report]

OK, local testing on the 48 core Aphrodite server, using this branch (with only 10 column-based jobs) we had:

5.759s branchwater
5.122s sourmash
18.557s fastani <-- already 10 column jobs
3m3.624s anim <-- changed on the branch, now 10 column jobs
3m33.817s dnadiff <-- changed on the branch, now 10 column jobs
4m2.702s anib <-- already 10 column jobs

(repeated and timings consistent).
In more detail:
real	3m5.428s
user	25m44.547s
sys	0m28.375s
Finished 10 genomes using anim

real	3m34.330s
user	31m35.473s
sys	0m34.922s
Finished 10 genomes using dnadiff

On the other hand, using the main branch - commit f117e40ce0813c9e1a9bc9cb5e1342a0604e98fe specifically:

5.835s branchwater
5.059s sourmash
18.598s fastani <-- already 10 column jobs
1m10.586s anim <-- still using 100 pairwise jobs, nearly x3 faster
1m15.677s dnadiff <-- still using 100 pairwise jobs, nearly x3 faster
4m2.541s anib <-- already 10 column jobs

And the detailed timing:
real	1m10.586s
user	39m27.202s
sys	0m47.957s
Finished 10 genomes using anim

real	1m15.677s
user	49m1.014s
sys	0m56.431s
Finished 10 genomes using dnadiff

On this small example, restricting it to 10 larger jobs (one per column) versus 100 smaller jobs (one per pair) means only using about fifth of the CPUs (this is a 48 core machine), so it is to be expected that the wall time goes up (although more like a factor of three). It is interesting that on the other hand the "user" and "sys" times has gone down substantially with the changes, perhaps with less tasks running there is less competition for disk IO?
Where the column-based approach should pay off is on larger jobs - 100 genome test underway...

Still on the 48-core Aphrodite server, but with 100 genomes. Main branch using 10,000 pairwise jobs:
$ time pyani-plus anim --database local_test.db --executor local pecto_md5_100
Indexing FASTAs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00 100/100
ANIm run setup with 100 genomes in database
Database already has 0 of 100²=10000 comparisons, 10000 needed
host: n23-48-192-aphrodite
Comparing pairs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 1:41:20 10000/10000
Completed run-id 4 with 100 genomes in database local_test.db

real	101m25.533s
user	4637m6.339s
sys	90m25.435s

The anim_by_column branch, using 100 column based jobs:
$ time pyani-plus anim --database local_test.db --executor local pecto_md5_100
Indexing FASTAs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:02 100/100
ANIm run setup with 100 genomes in database
Database already has 0 of 100²=10000 comparisons, 10000 needed
host: n23-48-192-aphrodite
Comparing pairs ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 1:44:48 10000/10000
Completed run-id 1 with 100 genomes in database local_test.db

real	104m53.792s
user	3926m54.074s
sys	62m36.752s

Slightly slower, but no real difference. Perhaps 96 genomes would have shown a slight win (with 48 cores)?

We released v0.0.1a1.dev1 with the distribution of all comparisons in order to continue to have a comparison point for column-wise (constant reference) comparison distribution, as we merge this into main.


Error loading Python DLL

Please check this before posting an issue

[ ] I've made sure my issue isn't related to / fixed by #1
[ ] I know that some features don't work in the latest beta
[ ] I'm using the correct version of the client (0.0.2 for the version 2020.9.9s of the game and 0.0.3 for the version 2020.9.22s )
[ ] I've checked that my antivirus is not causing any of my problem

If you can check all of the following, you can create your issue
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Game Version: [e.g. v2020.9.22s]
Client Version [e.g. 0.0.2]

Additional context
Add any other context about the problem here.

Please describe the problem more precisely instead of posting a blank post with just a title

Since you didn't respond for more than almost 2 months, I'm closing this issue for now


Add better exception handling in transition list input - in particular make the FileModifiedException more informative

In response to https://skyline.ms/announcements/home/issues/exceptions/thread.view?entityId=96760a55-6efc-103d-a666-22f53556a042&_anchor=66300
I don't have a repro for the problem, unfortunately

@brendanx67 do you still want to change this? I could add two sets of error handling (UI and commandline) if you feel strongly about it.


[Event Modification] codeunit 12 "Gen. Jnl.-Post Line" -

Describe the request
    OnAfterCalcPmtDiscToleranceProc(DtldCVLedgEntryBuf, OldCVLedgEntryBuf, PmtDiscTol, PmtDiscTolLCY);
    OnAfterCalcPmtDiscToleranceProc(DtldCVLedgEntryBuf, OldCVLedgEntryBuf, PmtDiscTol, PmtDiscTolLCY, GenJnlLine); //CustPub

[IntegrationEvent(false, false)]
local procedure OnAfterCalcPmtDiscToleranceProc(var DtldCVLedgEntryBuf: Record "Detailed CV Ledg. Entry Buffer"; OldCVLedgEntryBuf: Record "CV Ledger Entry Buffer"; var PmtDiscTol: Decimal; var PmtDiscTolLCY: Decimal; var GenJournalLine: Record "Gen. Journal Line") //DCustPub
begin
end;

Additional context
Publisher request marked with //CustPub tag.
Additional parameter GenJournalLine by referenceInternal work item: AB#494248

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 14819.


Shortcuts for common but time consuming traffic rules (separate turning lanes | fix roundabout rules | auto timed traffic lights | minor roads joining main avenue with continues junction barrier)

Hi,
when fixing traffic jams in my cities using TMPE I believe adding shortcuts for the following common scenarios can save a lot of time:
A) separate turning lanes. This is particularly useful in gridlocks to help cars who want to go toward directions without traffic jams avoid waiting behind cars who want to go towards directions where traffic is jammed.

Selecting every segment and then modifying every lane can be time consuming I have created a mod that separates turning lanes with by ctrl+click or alt-click.
B) fixing roundabout rules with one click: people use a lot of roundabouts in their cities. the vanilla roundabout can get a massive boost if pimped by traffic manager. while the roundabout mod automatically adds TMPE rules when creating them, I still want to be able to add traffic rules after creating roundabouts for example because I might modify my roundabout or I am trying to fix other peoples cities.
I am planning to add a simple shortcut to fix all the traffic rules for a roundabout with one click.
I prefer to avoid adding a roundabout tool to traffic manager. I think its best to use the already existing junction priority tool. select the tool and then press alt+shift+click on  a round about to do all of the following:
give way entering the roundabout
enter blocked junctions if you are already on the roundabout
enter blocked junctions if you are entering the roundabout
separate turning lanes on the roundabout
choose lanes when entering the roundabout in cases where highway rules apply.
no lane changing in the nodes in the roundabout (using lane connection tool).
etc
I also wish to add options so that people can individually choose any of these features.
C)add automatic timed traffic lights:
people spend a tone of time to add timed traffic lights. i suggest to add a default time traffic lights which allows one road to go through at a time and automatically modifies the turning lanes all with one click would be a massive help.
D) in real life and also in simcity when a small road joins a main avenue, the separation barrier in the middle remains unbroken and people can only turn right (the only advantage of simcity over cities skylines!!!). we already have an asset that visually conserves the junction barrier in such situations

But TMPE is required to make it function as it should. It can be a bit tedious to apply all the traffic rules particularly when fixing other peoples cities where many minor roads are joining one avenue. so i suggest a shortcut. choose junction priority  tool then hold ctrl to set all rules regarding the above scenario:
remove zebra crossings on the avenue
cars on the avenue can enter block junctions
no left turns
give way entering the avenue

This would go into Usability section.
But each of your suggestions are not trivial, so if this is accepted we will have to go through each suggestion, make one ticket per each suggestion, discuss UX where the GUI for that will go, and discuss desired behaviour, and then you or one of us can implement.
For example separate turning lanes will have to check if there are enough lanes for all outgoing roads, otherwise it will try to combine some arrows in one lane. And knowing the direction is not trivial either, each direction is an arc approx. 90° but there's logic for that somewhere in the code, for those arcs.

@kvakvs I am going to fix all of these myself. I opened this issue mainly for discussions. I spoke on discord with @krzychu124 and he told me to open issue[s] and make pull requests.

separate turning lanes will have to check if there are enough lanes for all outgoing roads
sure. I already have fixed the lane arrow thing and am about to make a pull request. I even went as far as distributing the number of lanes in each direction in proportion to the sizes of the roads attached in my fix and consideration to left hand and right hand drive as well. if there are left over lanes (when dividing by proportions) then the right lane gets less lanes because its easy to turn right.

One Issue is of there are more source lanes than target lanes in which case there is not much I can do to avoid lanes merging. giving more lanes to the left turn means there is possibility for u turn [i think].

Can you assign this to me please

Please make as small pull requests as possible one per feature.

Yes, I said that would be good to open issue before you create pull request and I thought you will create one for each suggested features :grin:
As @kvakvs said you should split this issue, so extract everything which is not related to your current pull request to a new issue[s] :smiley:
It will be easier for us to track progress, discuss about changes and it will help to organize all info in one place.
Keep PR as small as possible and KISS :wink:


Mache

Hello,
if I use Mache, the multiplayerunlimiter works fine but i cant use my Keyboard anymore for Chat or Worldname / Servername and the menu Bugs too.
Would it be possible change the Hotkey to custom one ? I cant use the debug console anymore cause its same Key F1
Best Regards
Gladiator1337

I would also be for a custom keybind if possible.

@Gladiator1337 Can you provide steps to reproduce the keyboard lock issue?

@willis81808 start to host a game name it and start to chat

You can't write messages in the chat

Identified the issue as a problem with the UniverseLib config taken from their documentation. Resolved now in my testing


Add possibility to use regex in exclude

Is this a request for help?:

Is this a BUG REPORT or FEATURE REQUEST? (choose one):  FEATURE REQUEST

Environment (plugin version, maven version, OS, ...):
Plugin Version: 4.7
Maven Version: 3.5.3
OS: Linux/MacOs
What happened:
We have multiple sub-charts that we want to exclude them from package and lint
ls -1 istio/charts/
certmanager
istiocoredns
kiali

For exclude every chart we need to pass this
<excludes>
<exclude>${project.basedir}/charts/istio/charts/certmanager</exclude>
<exclude>${project.basedir}/charts/istio/charts/istiocoredns</exclude>
<exclude>${project.basedir}/charts/istio/charts/kiali</exclude>
</excludes>

What you expected to happen:
It's will be cool if we can pass regexp and make it like this(we tried with "", ".", "**" nothing help us)
<excludes>
<exclude>${project.basedir}/charts/istio/charts/*</exclude>
</excludes>

How to reproduce it (as minimally and precisely as possible):
Anything else we need to know:
We must do it because of glibal istio variables
https://github.com/istio/istio/blob/master/install/kubernetes/helm/istio/values.yaml#L106
When we make helm lint, in the main Istio helm chart everything works well, but when we trying to do it in Istio sub chart we reach error because these global variables using in sub chart
https://github.com/istio/istio/blob/master/install/kubernetes/helm/istio/charts/tracing/templates/tests/test-tracing-connection.yaml#L1
That's why we want to exclude all these sub-charts in maven plugin
==> Linting .
[ERROR] templates/: render error in "pilot/templates/serviceaccount.yaml": template: pilot/templates/serviceaccount.yaml:3:14: executing "pilot/templates/serviceaccount.yaml" at <.Values.global.image...>: can't evaluate field imagePullSecrets in type interface {}```

Hi, thanks for this proposal.
We would glad to receive a PR for this.

@axdotl PR is created, can we get it reviewed, merged and released?

4.8 released - will become available within next two hours at maven central.


Add concept of Keyboard & Keypad contents to solve alignment issues in some screens

Description
The goal of this PR is to simplify the management of screens containing keyboard or keypad.
These screen also often contain a title, some control to display entered text or digits, and some controls to validate or interact. All these controls have currently to be added one by one, and their vertical aligment is tricky.
The idea of this PR is to add the concepts of keypad content and keyboard content to handle all these control as a single area (like in Figma).
The old API is kept but depracated
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[*] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[ ] Documentation
[ ] Other (for changes that might not fit in any category)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.66%. Comparing base (780c13e) to head (d6ff89d).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #605   +/-   ##
=======================================
  Coverage   59.66%   59.66%
=======================================
  Files          12       12
  Lines        1676     1676
=======================================
  Hits         1000     1000
  Misses        676      676

Flag
Coverage Δ

unittests
59.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat(telemetry): list operators not responding on finishTaskTrace

Description
Once the finishTaskTrace is called, the trace should show a list with the operators that did not respond the task

Addressed here.


It seems that reverse proxy settings is wrong

Is a strong error now:

Clicking in More Info button, i'm redirected to this page: https://wiki.jenkins-ci.org/display/JENKINS/Jenkins+says+my+reverse+proxy+setup+is+broken
Which the problem with the settings?
I'm using the basic configuration files from this repository. Thanks.

This should be fixed in the latest blog updates and on master (Jenkins should not be complaining about a bad reverse proxy), when using the out of box setup.  Please feel free to re-open if you encoutner this or other new isseus.


Update installation yaml to include CRD for templates

What this PR does / why we need it:
Add CRD for apikey and servicecontrolreport templates.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

NONE

resolved by other PR, closing for now


Cant find in app store

My friend just sent this to me because I was looking for a way to be able to show my heart rate on stream without having to get a pulsoid.  I am getting zero search results in the fitbit app store for Heart of Frogg, so I don't know how to go about getting this to work.  I have a Versa lite.

Check the README file. There's instructions and links.

I was following that, but it takes me to a webpage and tells me to find it in the fitbit app on my device, which I can't do.  There isn't a way to install it from my PC.

There's a link to two versions of the app. Gotta click one of those depending on your device. Go to the link on your phone.

Ah ok!  I didn't realize it needed to be done via phone to get it to work.  Sometimes my brain doesn't fully work.  :)

Nah. That's less a "you" problem and more an issue with my documentation. Docs are supposed to be clear! Apologies for closing this issue without considering there was room for improvement on my part. I updated the README just now to mention the need to open the link on your phone.


Turkish lira has incorrect conversion

If you check, for example, the following link: https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>The trl has a 1 euro - 37509273.61916009 liras conversion rate. Which is quite far from true (at least right now), it should be aprox 37.45

Oh, I see, thank you!
But still it's strange that TRL is in the currencies list: https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>And in all conversion rates:
https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>Can it be removed if it does not correct?


Update Across-V2

Resolves L2B-3262
OptimisticGovernor got discovered as a GnosisSafe module.
Smaller values for bonds in the OptimisticGovernor.
New owner added to the EmergencyProposalExecutor.

it's weird that we don't have that contract listed and those owners shown on the project page :/


Get 500 Error "Unable to find target address" when running $appPrincipal = Get-MgServicePrincipal -Filter "AppId eq '$clientId'"

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
SharePoint Add-ins
Developer environment
Windows
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[X] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version
SPFx version
Node.js version
etc

Describe the bug / error
The secret of our SharePoint Add-in was expired and I follow here to renew it: https://learn.microsoft.com/en-us/sharepoint/dev/sp-add-ins/replace-an-expiring-client-secret-in-a-sharepoint-add-in.
At step 3 when running  $appPrincipal = Get-MgServicePrincipal -Filter "AppId eq '$clientId'" it shows me the error:
PS C:\Windows\System32> $appPrincipal = Get-MgServicePrincipal -Filter "AppId eq '$clientId'"
Get-MgServicePrincipal_List: Unable to find target address
Status: 500 (InternalServerError)
ErrorCode: InternalServerError
Date: 2024-11-19T22:51:42
Headers:
Vary                          : Accept-Encoding
Strict-Transport-Security     : max-age=31536000
request-id                    : 26bba0ca-22bc-444f-a9d8-380386a6e453
client-request-id             : 9e5d6277-4e7e-4ee6-91d2-aa37fb1a3755
x-ms-ags-diagnostic           : {"ServerInfo":{"DataCenter":"Canada East","Slice":"E","Ring":"3","ScaleUnit":"001","RoleInstance":"QB1PEPF000057A2"}}
Date                          : Tue, 19 Nov 2024 22:51:41 GMT
Steps to reproduce

As above described.

Expected behavior
Should get principal id by AppId

Issue resolved after changing to use a work/school account.


Add shell tool

We can't use say $(nf-config -flibs) as option for a linker (since we are not invoking subprocess with a separate shell).
So a linker might need to run the above command to get the right set of options required. ATM in various build scripts in lfric_atm-fab we have a shell tool to do that, it would be good if this could just become part of the ToolBox to remove duplicated code.

PR already ready, don't bother with migrating to new repo.


[App Request] Unifi Network Application

App Information

Name: Unifi Network Application
Short Description: Replacement for Unifi Controller (deprecated)
Official Website: https://docs.linuxserver.io/images/docker-unifi-network-application/
GitHub Repository: https://github.com/linuxserver/docker-unifi-network-application
Docker Image: linuxserver/unifi-network-application

Why do you want this app?
I noticed that CasaOS Appstore currenty delivers Unifi Controller as linuxserver/unifi-controller:8.0.7, however this container wll not be mantained starting from 01/01/2024, you can read more about it here
The replacement is linuxserver/unifi-network-application.
This contaner however requires quite a bit more configuration compared to before, anyone willing to take a look at it? Thanks!

I'm trying to work on this issue, however I'm encountering issues while deploying the mongodb container, I'm using version 3.6.
I'm getting this issue Unable to determine status of lock file in the data directory /data/db: boost::filesystem::status: Permission denied: "/data/db/mongod.lock", terminating
I would normaly would try to solve it by changing permissions on the target folder manually, however given that i'm trying to create a compose file to share, this is not viable.
Any idea on how to solve it?


selfhosted  login faild  connection reset by peer

Describe the problem
connection reset by peer
To Reproduce
Steps to reproduce the behavior:

Click on Connect
See error

Are you using NetBird Cloud?
self-host
NetBird version
0.29.4
NetBird status -dA output:
If applicable, add the `netbird status -dA' command output.
❯ netbird debug for 1m -AS
Error: failed to up: up already in progress: current status LoginFailed

Screenshots

Perhaps it's an ISP issue


rescaler in NormAwareEmbedding

Hi, I'am wondering why there is a rescaler in class NormAwareEmbedding with affine=True? Thanks in advance!

affine=True is the default value of nn.BatchNorm1d

Thanks!


Annotations from Database

Hi everybody,
i want to know if it's possible to store annotations in Mysql, because with the downloadable source, there are only json files (rashomon.json and annotations.json) and it stores all the annotations in the same file and whatever the page i open it shows me the same annotations. i want the annotations to be linked to each file , and i think MYSQL would be perfect for it. But if i can do it with Json too, i would like to know how.
Thanks !

+1

Yes, you can store your data in a database. That's the purpose of databases. How you create regions from that data is a problem of your application. Use the API described in the README. If something specific is unclear or missing, ask/create a PR. Otherwise, buy a book or ask on StackOverflow.

Lol wow. Okay thx


Soil Tests:  Defining the Requested Tests

Extending the discussion from #148 specific to test identification in this issue.
We've discussed examples where tests may be requested variously by package name, group of analytes or single analyte.   Test package seems to me to fit well inside of the Product concept, but individual analytes are more of a stretch.   @aferreyra and I discussed extending our Variable object with statuses (e.g., Requested/Reported) as in the example below.
Where Variable Status is Reported, there is a corresponding column in the Geoparquet.  Where it is Requested, there is no accompanying data.

If the request is simply by package, we could render the same request as such.    Omission of Variable Status would default to Reported:

In the past we've allowed multiple methods of modeling data when there is a varying degree of detail (e.g., Summary Values vs. Spatial Detail).   I would ask the question whether there are ever workflow situations where the requesting party cannot define the constituent tests in a package, or if the receiving party requires requests by package name (perhaps there are different tests for the same analyte in different packages)?   If so, we may want to consider supporting both methods.

In the 4 September 2024 meeting we started to discuss the pros and cons of modeling a requested test as a product vs. collection of variables in a requested status.
Speaking for myself, I can see it both ways.  One the one hand, an agronomic service is a product, and someone may wish to consider services as per-field investments alongside seed, fertilizer and crop protection costs.  We can model a service's constituent attributes either on top of the existing ProductComponent object (really designed for tank mixes, but arguably extensible to seed treatments) or else make a new Product Type of "Service" and make a collection of "ServiceAttributes" on it.   On the other hand, Product is already unwieldy.   I anticipate confusion from some that we model seed, tank mixes and harvested produce on the same object.   Also, machinery use carries measurable per-field costs, but to the extent we model that at all, it is not on Product.
Re putting a status on a variable, this correlates well to what we are already doing in Field Operations.  Seed Singulation at a point on a field is a variable, so why wouldn't we handle soil Ph similarly?  We've discussed that ISO11783-10 has both requested tasks and data log triggers on individual variables.   Then again, how well are Data Log Triggers really supported in the industry; should we view that as a cautionary tale?


Passing a list of brokers as an environment variable?

Due to deployment constraints, I would like to configure the list of brokers via an environment variable.
I have passed --expand-env to topicctl and set BROKERS as an environment variable.
What I am not sure on is:

What format to put for the BROKERS value?

Should it look like a.example.org:9092,b.example.org:9092?

What I should put in the cluster.yaml file?

Currently I have this:
spec:
  bootstrapAddrs: ${BROKERS}

Thanks for your help!

I found the magic incantation. It is:
docker run -e 'BROKERS=[ abc, def ]' --expand-env ...

This will expand to YAML like this:
spec:
  bootstrapAddrs: [ abc, def ]


Harbor tile does not support certs signed with none ops manager root ca

None ops manager root ca can not be passed to harbor instance and then the status checking script will be failed.
curl -s --cacert /var/vcap/jobs/harbor/config/ca.crt https://testing.harbor.vmware.com/api/systeminfo

Will add a ca inputting area in the harbor tile configuration form and corresponding property to let user input the none-ops manager ca if needed.

Done! MR merged. See https://gitlab.eng.vmware.com/harbor/harbor-tile/merge_requests/5


Add dedicated websockets package

Description
Ref: https://github.com/encode/uvicorn/issues/797
There used to be a package automatically installed; not anymore I guess. This came from a separate package and not cookiecutter-django, but the installation was similar.
Rationale
For websockets to work, you need a package like wsproto or websockets (which is not as maintained). Uvicorn at some point might have dropped the auto installation of one of these packages that made websockets unavailable to work with.

@browniebroke It may be necessary to add these packages as well: https://github.com/encode/uvicorn/pull/666/files#diff-2eeaed663bd0d25b7e608891384b7298R53-R54
Those used to come with the standard installation of uvicorn. Although, without them, uvicorn seems to be running properly, I somewhat have my doubts for production mode.


Unary Ops: Adds log1p to the api

This PR adds unary operator log1p to the api.
https://docs.scipy.org/doc/numpy-dev/reference/generated/numpy.log1p.html#numpy.log1p

This change is

Awesome stuff! One minor comment.

Review status: 0 of 8 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

src/ops/unary_ops.ts, line 144 at r1 (raw file):

  static log1p<T extends Tensor>(x: T): T {
    const grad = (dy: T) => {
      return {x: () => dy.divStrict(x.add(ops.scalar(1).toFloat()))};

do you need to call toFloat() here?

Comments from Reviewable


[SPARK-10820][SQL] Support for the continuous execution of structured queries

This is a follow up to 9aadcffabd226557174f3ff566927f873c71672e that extends Spark SQL to allow users to repeatedly optimize and execute structured queries.  A ContinuousQuery can be expressed using SQL, DataFrames or Datasets.  The purpose of this PR is only to add some initial infrastructure which will be extended in subsequent PRs.
User-facing API

sqlContext.streamFrom and df.streamTo return builder objects that are analogous to the read/write interfaces already available to executing queries in a batch-oriented fashion.
ContinuousQuery provides an interface for interacting with a query that is currently executing in the background.

Internal Interfaces

StreamExecution - executes streaming queries in micro-batches

The following are currently internal, but public APIs will be provided in a future release.

Source - an interface for providers of continually arriving data.  A source must have a notion of an Offset that monotonically tracks what data has arrived.  For fault tolerance, a source must be able to replay data given a start offset.
Sink - an interface that accepts the results of a continuously executing query.  Also responsible for tracking the offset that should be resumed from in the case of a failure.

Testing

MemoryStream and MemorySink - simple implementations of source and sink that keep all data in memory and have methods for simulating durability failures
StreamTest - a framework for performing actions and checking invariants on a continuous query

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50496/
Test FAILed.

test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50497/
Test FAILed.

Test build #50498 has started for PR 11006 at commit 7147b3f.

Test build #50498 has finished for PR 11006 at commit 7147b3f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50498/
Test PASSed.

Looks great! Just some minor comments.

Test build #50509 has started for PR 11006 at commit 5220ea8.

LGTM, other than the naming issues (StandingQuery, etc. in the code)

Test build #50509 has finished for PR 11006 at commit 5220ea8.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StreamProgress

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50509/
Test PASSed.

Test build #50527 has started for PR 11006 at commit 735e113.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50526/
Test FAILed.

Merged build finished. Test FAILed.

test this please

Test build #50529 has started for PR 11006 at commit 735e113.

Test build #50527 has finished for PR 11006 at commit 735e113.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50527/
Test FAILed.

Test build #50529 has finished for PR 11006 at commit 735e113.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50529/
Test FAILed.

Merged build finished. Test FAILed.

Test this please

test this please

Test build #2488 has started for PR 11006 at commit 735e113.

Test build #50540 has started for PR 11006 at commit 735e113.

Test build #2488 has finished for PR 11006 at commit 735e113.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #50540 has finished for PR 11006 at commit 735e113.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50540/
Test PASSed.

LGTM

Thanks! Merging to master.


Optional field annotated as NoneType if field name is equal to class name

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
I have a model where class names are reused as field names. (See example code below).
When this occurs, and the field is made optional, pydantic annotates the field as NoneType.
Note that this doesn't occur if the field is mandatory.
Example Code
from typing import Optional

from pydantic import BaseModel

class Bar(BaseModel):
    Baz: str

class Foo1(BaseModel):
    Bar: Optional[Bar] = None

class Foo2(BaseModel):
    Bar: Bar

# prints: annotation=NoneType required=False
print(Foo1.model_fields["Bar"])

# prints: annotation=Bar required=True
print(Foo2.model_fields["Bar"])

# Fails with ValidationError "Input should be None"
Foo1(Bar=Bar(Baz="z"))

Python, Pydantic & OS Version
pydantic version: 2.2.1
        pydantic-core version: 2.6.1
          pydantic-core build: profile=release pgo=false
                 install path: C:\src\apps\miniconda3\envs\env\Lib\site-packages\pydantic
               python version: 3.11.4 | packaged by conda-forge | (main, Jun 10 2023, 17:59:51) [MSC v.1935 64 bit (AMD64)]
                     platform: Windows-10-10.0.22000-SP0
     optional deps. installed: ['email-validator', 'typing-extensions']

Selected Assignee: @Kludex

I can reproduce it to the following issue:
from typing_extensions import TypeAlias

A: TypeAlias = int
B: TypeAlias = int

class F:
    A: Optional[A]
    B: Optional[B] = None

print(F.__annotations__)
#> {'A': typing.Optional[int], 'B': <class 'NoneType'>}

That is, having the assignment = None is interfering with evaluation of annotations by using that as the value of B instead of the outer scope.
This also blows up using 3.10 union syntax:
from typing_extensions import TypeAlias

A: TypeAlias = int
B: TypeAlias = int

class F:
    A: A | None
    B: B | None = None  # TypeError: unsupported operand type(s) for |: 'NoneType' and 'NoneType'

It looks like a possible typing bug to me, I'll report to CPython and see what the response is.

Reported upstream in https://github.com/python/cpython/issues/108437
The more I think about it, this seems like an expected consequence of scoping rules. I don't think there's anything we can do about this; either it gets fixed upstream of this is an edge case of the Python type system. Will therefore close as wontfix.

From the upstream discussion, this is clearly Python language behaviour. A workaround is to split the annotation and assignment into two statements:
from typing import Optional

from pydantic import BaseModel

class Bar(BaseModel):
    Baz: str

class Foo1(BaseModel):
    Bar: Optional[Bar]; Bar = None    # <-- note this line is split into two with a semicolon

# prints: annotation=Union[Bar, NoneType] required=False
print(Foo1.model_fields["Bar"])

# Succeeds
Foo1(Bar=Bar(Baz="z"))

The repetition of Bar in Bar: Optional[Bar]; Bar = None is a bit unfortunate, it seems like the best that can be done at present.


help me!

Describe your problem here.
When i use this code it works properly, but then the game crashes, someone know how to fix it?
Here's the code:
function drainHealth(config)
    if config == 1 then
        return 0.4 -- -10% (0.2 / 2) health per second
    elseif config == 0 then
        return
    end
end

function onEvent(name, value1, value2)
    if name == 'Technophobia Health Drain' then
        health = getHealth()
        choice = tonumber(value1)

        function onUpdate(elapsed)
            health = health - drainHealth(choice) * elapsed
            setHealth(health)
        end
    end

    -- print('Event triggered: ', name, value1, value2);
end

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No

You can't put a function inside another function.

Try this!
drainEnabled = false
function onEvent(name, value1, value2)
    if name == 'Technophobia Health Drain' then
        choice = tonumber(value1)
        drainEnabled = (choice > 0)
    end
    -- print('Event triggered: ', name, value1, value2);
end

function onUpdate(elapsed)
    if drainEnabled > 0 then
        health = getHealth()
        health = health - 0.4  * elapsed -- -10% (0.2 / 2) health per second
        setHealth(health)
    end
end


Hierarchical graph layout

=> just saw Group Node after suggesting this.

Describe the solution you'd like
When the number of nodes getting too many, it would make sense to group them into groups each represented by a SINGLE Group Node BUT same size has single Non-group node. When click on it, it expands OR a side window appears, showing the nodes layout of the nodes within the clicked module.

Excellent work!!!

Hi!
Is the Grouping Node what you are looking for?
Thanks for contributing!

@miroiu
I see lot of potential of your work.

ideally we need some sort of hierarchical layout algorithm from Graphivz involving your existing Grouping Node
Even better (for me) is to encapsulate the Grouping Node into ONE single Node, without seeing the child nodes. To hide complexity of Grouping Node. So we can present HIGH level view of the workflow, without seeing the individual nodes but encapsulating parent "group" nodes.

@miroiu
I see lot of potential of your work.

ideally we need some sort of hierarchical layout algorithm from Graphivz involving your existing Grouping Node
Even better (for me) is to encapsulate the Grouping Node into ONE single Node, without seeing the child nodes. To hide the complexity and larger size of Grouping Node. So we can present HIGH level view of the workflow, without seeing the individual nodes but encapsulating parent "group" nodes.

@miroiu
I see lot of potential of your work.

ideally we need some sort of hierarchical layout algorithm from Graphivz involving your existing Grouping Node
Even better (for me) is to encapsulate the Grouping Node into ONE single Node, without seeing the child nodes. To hide the complexity of Grouping Node. So we can present HIGH level view of the workflow, without seeing the individual nodes but encapsulating parent "group" nodes.

@GeorgeS2019
A general idea would be to move the group of nodes into another graph and have a node that links to it (similar to how Unreal Engine does it when collapsing graphs)
This can be achieved with the current features and a good viewmodel hierarchy.

@GeorgeS2019
I've added an example of a node that can hold a graph inside. (see Calculator app)
I hope this helps!

@miroiu I know, U are faster than I can check and then make suggestions :-)

Hi @GeorgeS2019, is there anything else you'd like to know or can I close this issue?

@miroiu HI I just checked, the new calculator node is a group node. Fantastic!!!  Thank you

@miroiu  Just had another idea.
Is it possible to use the group node, in addition to move a group of nodes, the group node can collapse the nodes within its container into a single "Group Node"
This collapsing only works in these nodes have incoming and outcoming connections.
Do you think this is possible?

@GeorgeS2019 I can't picture that in my mind. Do you mean something like this?

You could use the nodes from inside the GroupNode of course, instead of selecting and then collapsing the selection. But for this, you need to filter the nodes that have the Location inside the group node because the group node doesn't know what nodes overlap with it.

@miroiu You have done a lot RIGHT.  Yes.  It is more just usability. The approach I suggest only make sense after layout is implemented. So that once the group NODE is created out of a few nodes, the layout automatically apply and a simpler view of the nodes is presented to provide an update of the node hierachy for further analysis.

@GeorgeS2019 Have you considered this approach?

It's not working out of the box but could be done with minor modifications.

@miroiu  As I said, U done a lot!!  However, what you offer, is considered RARE among .NET community.  If you like to address this unmet .NET community need.
Take time...  there are many unmet use cases.
(1) As u suggest above, it is a very Unique solution.  Not sure I have found elsewhere.  => Ideally, after once has done with the layout, one can collapse the group container node to back to a SINGLE node same size as others
(2) The other use case is a hierarchical state machine (U have provided a non hierarchical state machine, how about a hierachical one that looks like the picture others use?

@miroiu  As I said above.. What u have contributed will inspire others!! thank you!

@GeorgeS2019 No worries, if you really like this project, please give it a star ⭐
I'm pretty sure you can achieve what you need with a bit of effort.
I made the Grouping Node collapsible but you won't be able to connect nodes directly from outside. Is this how you imagined it?

@miroiu   Everything is excellent, I will promote this project :-)

@miroiu  Can u address the questions suggested here? This is another use case where Nodify will have an impact!

@miroiu

Btw, UI of nodify looks really good, it can be a great source of inspiration for the upcoming UI improvement for YAFSM.

Source

Hi @GeorgeS2019, thanks for finding some real use cases for Nodify. All of these open-source projects are a good fit for Nodify but I'd rather invest the time working on Nodify than starting big projects like creating a brand new editor.
Thanks for your interest!


emacs: Add withXinput2 argument

Motivation for this change
pixel-scroll-precision-mode need xinput2 support in xorg.
** Emacs now supports use of XInput 2 for input events.
If your X server has support and you have the XInput 2 development headers
installed, you can configure Emacs with the option '--with-xinput2' to enable
this support.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval


Add retry configuration pass through

We're seeing many errors due to Faraday::ConnectionFailed: execution expired. Might be nice to be able to configure retries within the internal faraday client to avoid this.

@jonallured any feedback on this?

Welp I definitely did not have this repo watched so didn't see this until today! 😬
I think I'm maybe more interested in supplying a custom Faraday connection instead of the one that the gem provides. That seems like a cooler way to set all kinds of finicky options. Maybe something like:
custom_connection = Faraday.new(...blah...)
BrazeRuby.config do |c|
  c.set_connection(custom_connection)
end

But that's just sketch, not really something that could be easily done today I guess. I just did a little skimming through the codebase and it appears we have cached clients in the REST base class:
https://github.com/jonallured/braze_ruby/blob/5b34717f9f36e9ada465561df7ca78e13720527b/lib/braze_ruby/rest/base.rb#L19
Which I guess is ok but I'd rather promote this client somewhere closer to the top namespace so that configuring it could be easier. I will ponder this. What do you yall think @JerrodCarpenter @trevorrjohn?

@jonallured what about having options take a block:
options[:connection] = Proc.new do |connection|
  connection.request :retry
  connection.options[:open_timeout] = 2
  // etc.
end

BrazeRuby::API.new(key, host, options)

I am not sure this is the best solution, but it would take minimal changes.

Hey @JerrodCarpenter can you rebase on latest main branch - that should cause CircleCI to build and verify this work. Thanks!

@jonallured thanks! CI worked like a charm.

LGTM?

Ugh I totally owe you a response on this, sorry for the delay! I'm headed out but will follow up tomorrow.

Ok here's what I'm thinking: going to merge #31 and #34 and cut a release. That at least gets us to a point where the gem can accept these options and you're off and running.
Ultimately I'd like to move the gem in the direction of more standard config in the Ruby ecosystem with like a config block rather than sending in options as the api class is instantiated. That change is probably enough to warrant a major version bump. At that point it would make more sense to be to allow for one to send in a configured Faraday connection and then the gem can use that instead. All that to say, let's merge these suckers and publish!


[Feature Request]: SolaceIO - publishing to dynamic topics (like TopicNameMapper in JmsIO)

What would you like to happen?
We have a use case of publishing messages to "dynamic" topics, meaning the name of the topic is depending on the message being published, something like: my/great/topic/{countryCode}/{someType}/{whatever}. These placeholders depend on the payload that is being mapped to a message. This allows consumers to subscribe only to a subset of messages that are interesting to them.
In JmsIO this is easy to do by providing a custom lambda via the topicNameMapper property.
Would you consider adding this to SolaceIO in some form?
CC @bzablocki
Issue Priority
Priority: 2 (default / most feature requests should be filed as P2)
Issue Components

[ ] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[X] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Infrastructure
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

@bzablocki Could you give a hint if this feature would be included in any near-future roadmap?

We're currently finishing up the Write connector, and I believe it has the feature that you mentioned here - see the PR https://github.com/apache/beam/pull/32060/files#diff-b61373f75a4de5bdf91a94bd1d008285b883533994138b07a393a30377140b49R1064-R1065
You'll be able to set a destination for each record you send to Solace. This PR should be merged soon and be released in Beam 2.61 or 2.62.

We managed to release the Write connector in Beam 2.61. Feel free to test and close this request if no longer relevant.

Ah sorry for late reply... Thanks for the update, we are planning to switch publishing to SolaceIO from JmsIO as well so for sure is relevant. I will test it and report any issues in separate bugs if anything occurs.
Thanks again for support!


[CSL-2396] switch over to using runas rather then manifest-tool

Description

Linked issue

Type of change

[ ] 🐞 Bug fix (non-breaking change which fixes an issue)
[ ] 🛠 New feature (non-breaking change which adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
[ ] 🔨 New or improved tests for existing code
[ ] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

[ ] I have read the style guide document, and my code follows the code style of this project.
[ ] If my code deals with exceptions, it follows the guidelines.
[ ] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

QA Steps

Screenshots (if available)

How to merge
Send the message bors r+ to merge this PR. For more information, see
docs/how-to/bors.md.

after extensive testing, ive found that with the installer already being marked as needing admin, there is no need to specially run it as admin


Torrent from "Nix" showing up in the list for "Don't Worry Darling"

In the list of streaming options for Don't Worry Darling (2022), I'm getting an option that references Nix (2022).

https://www.strem.io/s/movie/dont-worry-darling-10731256

Should be fixed, once the caches expire, thanks.


Fix hiding window after animation ends

transitionEnd was not defined and window display style was not set to none when fade out animation was ended

Too many changes were pulled, sorry


Update best-practices.md

Edited best practices with question only ranker

@prakul1991 : Thanks for your contribution! The author, @tulasim88, has been notified to review your proposed change.

#sign-off

@diberry: I'm sorry - only the author of this article, @tulasim88, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Alpha v75 causes Markdown imports to exponentially increase compilation time, rendering my website impossible to compile

🐛 Bug Report
In my Docusaurus website, I have import statements at the top of my Markdown files for the purposes of showing diagrams as React components. When upgrading to Docusaurus v75, these import statements make the development server impossible to start, as it hangs forever.
My website works completely fine on the previous version of 70.
Have you read the Contributing Guidelines on issues?
Yes.
To Reproduce

Install Python 3 (e.g. apt install python3)
pip install svgwrite
git clone git@github.com:hanabi/hanabi.github.io.git
cd hanabi.github.io.git
git checkout -b doc-bug
npm install
npm run start
Observe that compilation takes around 6.5 seconds.
Open the "beginner.md" file. Move a single import statement on line 17 up a line so that it is no longer commented out. Save the file.
npm run start
Observe that compilation takes around 22 seconds.
Open the "beginner.md" file. Move another import statement up so that it is no longer commented out. Save the file.
npm run start
Observe that compilation never completes.

Expected behavior
I expect my website to compile like it has been doing on previous versions of this software. On v70, it compiles in around 20 seconds with hundreds of import statements in around 30 different Markdown files.
Actual Behavior
The website does not compile.

Hey, webpack 5 dude here.  Sorry to hear this is happening!  I'll take a look for you.

Can confirm, will be working to figure out why exactly this is.  Sorry about that!

running "npm ci" fails for me

also, can't run after "npm install":

@slorber As the error message implies, you have to first run pip install svgwrite. I guess that needs to be included in the above instructions.

@RDIL Thanks for looking, did you find anything?

@Zamiell please don't assume I know anything about Python because I don't 😅
I had not planned to learn about how to to make python 3 the default on macos or how to handle a requirements.txt file (because obviously "pip install yaml" does not work")
Now it seems to work, but it was quite time-consuming to get there 😓

It seems your site builds, but there are a lot of broken links reported at the end, is this normal?

Hey Slorber, thanks for taking a look. On MacOS, you simply use brew (i.e. brew install python).

It seems your site builds, but there are a lot of broken links reported at the end, is this normal?

Yes, it is normal because in order to find the problem, I had to "comment out" (i.e. remove) the entire docs folder, and then just re-introduce one file, beginner.md.

brew install python did not change the python --version, had to alias python to python3.
So, you upgraded from alpha 70 to alpha 75. The problem is also there on alpha74 (using Webpack 4), and it's not a Webpack 5 bug.
I found out we have a very slow regex trying to extract a top-level doc markdown title, ignoring the mdx exports above it.
Reported another bug report here for clarity: https://github.com/facebook/docusaurus/issues/4726
Going to close this one.
A workaround to solve this regex problem is to add a md title above the MDX imports, or to not use MDX imports at the very top of the file.
---
id: beginner
title: Beginner's Guide
---

# Beginner's Guide

import CardLayout1 from<EMAIL_ADDRESS>import CardLayout2 from<EMAIL_ADDRESS>import Chop1 from<EMAIL_ADDRESS>import Chop2 from<EMAIL_ADDRESS>import BasicClue from<EMAIL_ADDRESS>
This is useless title duplication, but fixes the perf problem for me.
About your custom plugin, I suggest not importing our getFileLoader() utils and write your own svgr loader, as we are likely to change this: it is internal Docusaurus code, not public API.

Awesome, thanks again for looking into this so quickly.

About your custom plugin, I suggest not importing our getFileLoader() utils and write your own svgr loader

That was me. I just wanted to avoid code duplication, since the svgr loader options in Docusaurus worked fine.

Thanks for reporting this, was not easy to find the issue 😅
About the plugin, it's not a big deal but you'd rather duplicate a few lines rather than being subject to internal changes of Docusaurus. It's likely that this will change again

Ideally, I'd query webpack itself for the options used to load svg files, except that I didn't find such API.
Sure, we'll just instantiate svgr without calling into your internals, thanks for advice!


Move job coherence logic from Workflow to Jobs

Stuff like job dependencies are being check on Workflow, that responsability should be on Jobs.
Jobs (collection of Job) should handle references and variables, detecting missing jobs/keys and incompatible vars.

I've realized that moving this logic to Jobs will cause the following negative effects:

Stricter jobs, as references/variables will require to be previously declared making the workflow syntax too rigid
God class, Jobs will get too many responsibilities

Jobs should be in charge of collecting jobs, that's all. No further validation, it should be just a collection.
Workflow should be in charge of validate the Jobs logic, to amend lazy syntax issues (as to declare a job dependency anywhere) and to be sure that the collection (Jobs) can be executed as another system is in charge of running the workflow.


feat: add flexible component and flexFit enum

:tada: This PR is included in version 1.0.0-fix-doc-release.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Feature] Make compatible with the coloring features

Checking for whether or not an element is of type DebugWrapper and setting the background color to Transparent should do the trick here.

This will be fixed in the next release.

Will be in 1.1.4.


Sending periodical when RFID is read

Is it possible to continue sending MQTT-Messages while a RDIF tag is placed on the reader? Or send a message when it is placed on the reader and another (different) message when it's removed? Function should be similar to a hotel card plugged in slot near the door.
The usage will be a smart home "switch" to send a MQTT message, when e.g. a NFC tag of a phone is placed on the reader to signal night mode.

It is possible indeed. See https://github.com/miguelbalboa/rfid/issues/352 for detecting removed RFID tag.

Thank you, I will take a look at this solution.


The branch name of the Environment is "v-mengwe:new"

OS: Win10
Build Version: 20200906.1
Repro Step:

Expand a Static Web App.
Create an Environment.
Check the branches name of Production and Environment.

Expect:
The branch name of the Environment is the same as master.
Actual:
The branch name of the Environment is "v-mengwe:new".

Sorry, I'm unclear here.  The test environment's branch should also be master?

Create an Environment by the following commands:
git checkout -b new
git add .
git commit -m 'api'
git push origin head

The branch name of the Environment should be "new" instead of "v-mengwe:new".


bugfix: Add debug logs for main request failure

Workflow seeing a 403 response from the main page, but seems to be working fine from local.

Changes planned in another PR.


[Update Snap] Wallet Guard

Checklist
All items in the list below needs to be satisfied.

[x] Is the summary of the change documented in this ticket?
[x] Has a MetaMask Snaps team member reviewed whether the changes need to be vetted?
[x] If there are changes that need to be vetted, attach a description and the relevant fixes/remediations to this issue.
[ ] The corresponding pull request in this repo has been merged.

Summary of change:
Updating the Snap to fix several bugs and add support for Base transaction simulation
Source Diff: https://github.com/wallet-guard/wallet-guard-snap/compare/v1.1.0...v1.1.1
Version to be allowlisted:  1.1.1


Auth disabled by default Issue#29

Add a toggle for authentication (see: function handle());
Auth disabled by default (see:  AUTH_ENABLED).
Since Issue#29

为了保持缩进风格有点折腾 233 其实修改不多


[python] indexer creation performance is slow for Pandas Series vs numpy ndarray

if you build an indexer with a Pandas Series, it is 25X slower than if you build it with a Numpy NDArray.  Example which uses the exact same object, but does a cast before calling the index creator.
Expected result: these should be identical
This is on the (pre-release) release-1.7 branch as of 8d858e6
In [36]: import pandas as pd, tiledbsoma as soma

In [37]: type(obs.soma_joinid)
Out[37]: pandas.core.series.Series

In [38]: type(obs.soma_joinid.to_numpy())
Out[38]: numpy.ndarray

In [39]: obs.soma_joinid.shape
Out[39]: (41939851,)

In [40]: %time soma.tiledbsoma_build_index(obs.soma_joinid)
CPU times: user 50.8 s, sys: 405 ms, total: 51.2 s
Wall time: 51.2 s
Out[40]: <tiledbsoma.pytiledbsoma.IntIndexer at 0x7fa0daa04530>

In [41]: %time soma.tiledbsoma_build_index(obs.soma_joinid.to_numpy())
CPU times: user 1.29 s, sys: 285 ms, total: 1.58 s
Wall time: 1.58 s
Out[41]: <tiledbsoma.pytiledbsoma.IntIndexer at 0x7f9e32a2fb70>

We should also ensure that we correctly (performantly) handle:

Arrow Array (contiguous)
Arrow ChunkedArray (non-contiguous)
pandas.Series (original bug)
numpy.ndarray (which already works)

I tried multiple scenarios and used the np.array as my base line (keys and lookups are equal and I perform one map_location (setup) and one lookup):
Baseline:
keys = np.array(range(1, 100000000))
Setup time: 1.7088468329966418
Lookup time: 0.49534945800405694
pyarrow array:
keys = pa.array(list(range(1, 100000000)))
Setup time: 1.7942252089997055
Lookup time: 0.5838396660037688
pyarrow Chunked Array:
keys = pa.chunked_array([list(range(1, 100000000)), list(range(100000000, 200000000)), list(range(300000000, 400000000))])
3x size the baseline data.
Setup time: 10.952384541000356
Lookup time: 6.603933874997892
Pandas series:
keys = pd.Series(list(range(1, 100000000)), copy=False)
Setup time: 93.01347337499465
Lookup time: 0.49027750000095693
Pandas arrays:
keys = pd.array(list(range(1, 100000000)))
Setup time: 76.63969441700465
Lookup time: 0.5059003329952247
As can be seen panda's array and series lead to major slowdown in the setup phase while the rest are relative close to the baseline. Looking at map_locations I noted that (different from lookup) there are two hooks, one for py::array_t and one for std::vector<int64_t> input types.
        .def(
            "map_locations",
            [](IntIndexer& indexer,
                py::array_t<int64_t> keys,
                int num_threads) {
...
        .def(
            "map_locations",
            [](IntIndexer& indexer,
                std::vector<int64_t> keys,
                int num_threads) {

Investigating more, I found out that the calls ending up to std::vector<int64_t> version are the slow ones. It appeared that in case of pandas somehow the pybind runtime chooses to make the slow vector calls. Removing that version of map_locations, the observed overhead totally disapeared!

After the change:
Pandas arrays:
keys = pd.array(list(range(1, 100000000)))
Setup time: 1.712055790994782
Lookup time: 0.5056431670018355
Pandas series:
keys = pd.Series(list(range(1, 100000000)), copy=False)
Setup time: 1.6870728750000126
Lookup time: 0.4930597909988137

Panda runs:
numpy array:
keys = np.array(range(1, 100000000))
Setup time: 7.595900387968868e-05
Lookup time: 2.611686832999112
pyarrow array:
keys = pa.array(list(range(1, 100000000)))
Setup time: 0.00011958299728576094
Lookup time: 2.5583114580076654
pyarrow Chunked Array:
keys = pa.chunked_array([list(range(1, 100000000)), list(range(100000000, 200000000)), list(range(300000000, 400000000))])
Setup time: 0.5131658750033239
Lookup time: 29.461485624997295
Pandas series:
keys = pd.Series(list(range(1, 100000000)), copy=False)
Setup time: 0.00014925000141374767
Lookup time: 2.2870173749979585
Pandas arrays:
keys = pd.array(list(range(1, 100000000)))
Setup time: 8.699999307282269e-05
Lookup time: 2.6260701669962145
Python list:
keys = list(range(1, 100000000))
Setup time: 10.015719040995464
Lookup time: 12.734747709007934

https://github.com/single-cell-data/TileDB-SOMA/pull/2159


Unable to middle-click to paste in "Find"

VSCode Version:
OS Version:

Steps to Reproduce:

Duplicate of #25783 I believe


minor fix to mappable()

Codecov Report

Merging #20 (53cf57f) into main (a1411b8) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   73.13%   73.09%   -0.05%
==========================================
  Files          26       26
  Lines        3481     3483       +2
==========================================
  Hits         2546     2546
- Misses        706      708       +2
  Partials      229      229

Impacted Files
Coverage Δ

nject/characterize.go
85.97% <0.00%> (-0.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1411b8...53cf57f. Read the comment docs.


Validate hidden spam field in feedback component submissions

What
https://trello.com/c/H8jJvUxV/1021-feedback-component-server-side-fix-for-spam-problem
Validate that the hidden (giraffe) - "honeypot" input - is absent from submissions. The helper "checks if the value is not either nil or a blank string, that is, a string that is either empty or consists of whitespace".
https://guides.rubyonrails.org/active_record_validations.html#absence
Why
It seems likely that by resolving a number of accessibility issues (https://trello.com/c/MOshcFm1/771-update-feedback-component-to-hide-and-show-content-in-a-more-robust-way) we have inadvertently made it easier for spam bots to access the feedback component forms and client side changes have not resolved the problem.
Anything else
Should be deployed after: https://github.com/alphagov/govuk_publishing_components/pull/2586
def spam would seem to be a better place to check for spam:
https://github.com/alphagov/feedback/blob/1e7a40b92b57d389f799c6391662d59bac70bd31/app/models/report_a_problem_ticket.rb#L30-L32
Yet I can't seem to get any changes to work here. I've tried various examples such as:
  ->(ticket) { ticket.what_wrong.exclude?(" ") && ticket.what_doing.exclude?(" ") },
  ->(ticket) { ticket.feedback_maybe.exclude?(nil) },

Would it be possible to add some tests for this to document why/what feedback_maybe is for? e.g: if present we invalidate as likely spam if absent we validate as genuine submission
There are some similar examples for the other fields already in the spec file

Thanks @edwardkerry - I've added two tests to validate the absence / absence of feedback_maybe (added as a separate commit for now but will merge in to a single commit when approved).

It kinda looks ok to me but I agree it would be better in the spam checker - can you maybe pair with someone to investigate that option further? I'm unsure of the var name here - yes/no/maybe made sense for the other form but not so much here. I think avoiding calling it "hey spammers I'm a trap" would be ideal, but something a bit more descriptive to make the code more parseable by future devs would be great. Alternatively something even more obscure like a random string - "maybe" just feels a tad confusing.
As Ed has said, tests are needed here.

Okay, I think I've now managed to move this in to the spam function - which seems to be working okay

This looks good to me but I'm struggling to figure out how to test it! If @edwardkerry  wants to approve this tomorrow I'm happy for it to go through (please update the detail of the field name on the PR description though). I'd like to be taken through how you run it locally though - the combination of the right apps running and what css/js to disable at what point is confusing me. I'm pretty baffled at how the spammers are getting through and starting to wonder if they have a different entry point and our changes were coincidental.

This looks good to me but I'm struggling to figure out how to test it! If @edwardkerry wants to approve this tomorrow I'm happy for it to go through (please update the detail of the field name on the PR description though). I'd like to be taken through how you run it locally though - the combination of the right apps running and what css/js to disable at what point is confusing me. I'm pretty baffled at how the spammers are getting through and starting to wonder if they have a different entry point and our changes were coincidental.

Thanks Max, updated the field name in the description above.

This looks good to me but I'm struggling to figure out how to test it! If @edwardkerry wants to approve this tomorrow I'm happy for it to go through (please update the detail of the field name on the PR description though).

Thanks Max, updated the field name in the description above.

I'd like to be taken through how you run it locally though - the combination of the right apps running and what css/js to disable at what point is confusing me.

No problem 👍


[WIP] Animations part 2 of 2

This PR implements the second part of the animation system targeting mesh skinning, mesh morphing, and the omitted features from part 1.
Implemented features

Set of Action, Mixer, and Clip structs, inspired by the three.js animation system.
Keyframe targets for simple binding pairs.

(Position, Vector3)
(Orientation, Quaternion)
(Orientation, Euler)
(Scale, Scalar)
(Weight, Scalar)

Linear interpolation between keyframes.
Support for node animations in the glTF loader.
Two loop modes, namely Once and Repeat.
Mesh skinning for meshes with a small (≤ 20) number of joints per-vertex.

WIP features

Mesh skinning for meshes with a large number of joints per-vertex.
Morph targets.
Implementation of Discrete, Cubic, and CatmullRom* interpolation modes.
Implementation of PingPong loop mode.

* CatmullRom was removed from the glTF specification.

We're slowing getting there...
One notable change is the way morph targets are being computed. I've introduced generic 'displacement' vertex attributes which influence a_Position, a_Normal, and a_Tangent subject to the values of u_DisplacementContributions.
The snippet below taken from data/shaders/pbr_vs.glsl should explain a bit more:
// Toggles displacement contributions to `a_Position/a_Normal/a_Tangent`.
struct DisplacementContribution {
    // position: 1.0 if morph target weights should influence a_Position
    // normal: 1.0 if morph target weights should influence a_Normal
    // tangent: 1.0 if morph target weights should influence a_Tangent
    // weight: The weight to be applied.
    float position, normal, tangent, weight;
};


Add container's local IP into the /status output

Hi guys!
Could you please add container's local IP attached to the driver's session into the output of the /status endpoint?
This might be useful for someone who want to be able to send some requests directly into container for different purposes(video recording on demand, by sending request to turn it on/off and pull the file as example).
Right now every driver has a unique session_id, that is displayed in the /status. By this id we can see the docker container id that was created for the session:

To get the local Ip of a container you can use "docker inspect <container_id>", where container_id will be taken from the /status above.

It would be super cool if you add this ip_address field into the /status output!
Thanks in advance!

Is now available in aerokube/selenoid:latest container. Will be released in 1.4.2.

Released in 1.4.2.
@addrians status API format has changed in new release. Now we return something like this:
{
  "total": 5,
  "used": 1,
  "queued": 0,
  "pending": 0,
  "browsers": {
    "firefox": {
      "55.0": {
        "unknown": {
          "count": 1,
          "sessions": [
            {
              "id": "c9ed6055-e7c2-46e9-98de-4241a25ad420",
              //Note this change!!!
              "container": {
                "id": "ec8338eb8f271bc91dae7eee0cc16924e5e78fb7cd1b40ad59d50a99fc7534a1",
                "ip": "<IP_ADDRESS>"
              },
              "vnc": false,
              "screen": "1920x1080x24",
              "caps": {
                //...
              }
            }
          ]
        }
      }
    }
  }
}


this.tree.treeModel.update() is not working after pushing new data to nodes ; using Angular 5.2.11

Support Requests should not be opened as issues and should be handled in the following ways:
On StackOverflow using the angular-tree-component tag
In our slack support channel at https://angular-tree-component.herokuapp.com/

We sadly don't support Angular 5 Versions anymore. Please update to a newer Angular version and use the corresponding version of the tree. If the issue is still there on a newer version we can reopen this issue.